Testing alpha release with docker compose: required keyword-only argument: 'recursive_guard'

Describe the bug
The application do not start due to
langflow  |     field.type_ = evaluate_forwardref(field.type_, globalns, localns or None)
langflow  |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/typing.py", line 66, in evaluate_forwardref
langflow  |     return cast(Any, type_)._evaluate(globalns, localns, set())
langflow  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langflow  | TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'

Version

version alpha and 1.0.0a51 and1.0.0a52

docker compose log
docker compose up --build
[+] Building 0.8s (5/5) FINISHED                                                                                docker:default
 => [langflow internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 652B                                                                                0.0s
 => [langflow internal] load metadata for docker.io/langflowai/langflow:1.0-alpha                                                                                0.8s
 => [langflow internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => CACHED [langflow 1/1] FROM docker.io/langflowai/langflow:1.0-alpha@sha256:e6863d4bc7c06de8f75f6b25381eb18009e31b8aec49ee745b424b7c1adaecf4                                                         0.0s
 => [langflow] exporting to image                                                                                0.0s
 => => exporting layers                                                                                0.0s
 => => writing image sha256:9538bd3d9f2fadd7a5797e530ace230f38a0ad4adf687f5a9f1f28b15d2bf9c2                                                                                0.0s
 => => naming to docker.io/library/langflow-langflow                                                                                0.0s
[+] Running 1/1
 ✔ Container langflow  Recreated                                                                                0.0s
Attaching to langflow
langflow  | Traceback (most recent call last):
langflow  |   File "<frozen runpy>", line 198, in _run_module_as_main
langflow  |   File "<frozen runpy>", line 88, in _run_code
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/__main__.py", line 22, in <module>
langflow  |     from langflow.main import setup_app
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/main.py", line 16, in <module>
langflow  |     from langflow.api import router
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/api/__init__.py", line 1, in <module>
langflow  |     from langflow.api.router import router
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/api/router.py", line 4, in <module>
langflow  |     from langflow.api.v1 import (
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/api/v1/__init__.py", line 1, in <module>
langflow  |     from langflow.api.v1.api_key import router as api_key_router
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/api/v1/api_key.py", line 7, in <module>
langflow  |     from langflow.api.v1.schemas import ApiKeyCreateRequest, ApiKeysResponse
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/api/v1/schemas.py", line 9, in <module>
langflow  |     from langflow.graph.schema import RunOutputs
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/graph/__init__.py", line 1, in <module>
langflow  |     from langflow.graph.edge.base import Edge
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/graph/edge/base.py", line 6, in <module>
langflow  |     from langflow.schema.schema import INPUT_FIELD_NAME
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/schema/__init__.py", line 2, in <module>
langflow  |     from .record import Record
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langflow/schema/record.py", line 5, in <module>
langflow  |     from langchain_core.documents import Document
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langchain_core/documents/__init__.py", line 6, in <module>
langflow  |     from langchain_core.documents.compressor import BaseDocumentCompressor
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langchain_core/documents/compressor.py", line 6, in <module>
langflow  |     from langchain_core.callbacks import Callbacks
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langchain_core/callbacks/__init__.py", line 22, in <module>
langflow  |     from langchain_core.callbacks.manager import (
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langchain_core/callbacks/manager.py", line 29, in <module>
langflow  |     from langsmith.run_helpers import get_run_tree_context
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/run_helpers.py", line 40, in <module>
langflow  |     from langsmith import client as ls_client
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/client.py", line 52, in <module>
langflow  |     from langsmith import env as ls_env
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/env/__init__.py", line 3, in <module>
langflow  |     from langsmith.env._runtime_env import (
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/env/_runtime_env.py", line 10, in <module>
langflow  |     from langsmith.utils import get_docker_compose_command
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/utils.py", line 31, in <module>
langflow  |     from langsmith import schemas as ls_schemas
langflow  |   File "/app/.venv/lib/python3.12/site-packages/langsmith/schemas.py", line 69, in <module>
langflow  |     class Example(ExampleBase):
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/main.py", line 286, in __new__
langflow  |     cls.__try_update_forward_refs__()
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/main.py", line 807, in __try_update_forward_refs__
langflow  |     update_model_forward_refs(cls, cls.__fields__.values(), cls.__config__.json_encoders, localns, (NameError,))
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/typing.py", line 554, in update_model_forward_refs
langflow  |     update_field_forward_refs(f, globalns=globalns, localns=localns)
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/typing.py", line 520, in update_field_forward_refs
langflow  |     field.type_ = evaluate_forwardref(field.type_, globalns, localns or None)
langflow  |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langflow  |   File "/app/.venv/lib/python3.12/site-packages/pydantic/v1/typing.py", line 66, in evaluate_forwardref
langflow  |     return cast(Any, type_)._evaluate(globalns, localns, set())
langflow  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langflow  | TypeError: ForwardRef._evaluate() missing 1 required keyword-only argument: 'recursive_guard'
`

**Docker compose file**

`
services:
  langflow:
    build:
      context: ./
      dockerfile: Dockerfile
    pull_policy: build
    container_name: langflow
    restart: unless-stopped
    networks:
      traefik_network:
    #command: python -m langflow run --host <IP_ADDRESS> --port 7870
    environment:
      - TZ=Europe/Paris
      - LANGFLOW_PORT=${LANGFLOW_PORT}
      #https://docs.langflow.org/guidelines/login
      - LANGFLOW_SUPERUSER=${LANGFLOW_SUPERUSER}
      - LANGFLOW_SUPERUSER_PASSWORD=${LANGFLOW_SUPERUSER_PASSWORD}
      - LANGFLOW_NEW_USER_IS_ACTIVE=${LANGFLOW_NEW_USER_IS_ACTIVE}
      - LANGFLOW_AUTO_LOGIN=${LANGFLOW_AUTO_LOGIN}
      #LANGFUSE monitoring: TO BE FILLED AFTER A FIRST START
      #https://docs.langflow.org/guides/langfuse_integration
      - LANGFLOW_LANGFUSE_HOST=${LANGFLOW_LANGFUSE_HOST}
      - LANGFLOW_LANGFUSE_SECRET_KEY=${LANGFLOW_LANGFUSE_SECRET_KEY}
      - LANGFLOW_LANGFUSE_PUBLIC_KEY=${LANGFLOW_LANGFUSE_PUBLIC_KEY}
      #Database, configuration FAILED https://github.com/logspace-ai/langflow/issues/1432
      - DB_USER=${DB_USER}
      - DB_PASSWORD=${DB_PASSWORD}
      - DB_HOST=${DB_HOST}
      - DB_PORT=${DB_PORT}
      - DB_NAME=${DB_NAME}
      - LANGFLOW_DATABASE_URL=postgresql://${DB_USER}:${DB_PASSWORD}@${DB_HOST}:${DB_PORT}/${DB_NAME}
      # This variable defines where the logs, file storage, monitor data and secret keys are stored.
      - LANGFLOW_CONFIG_DIR=app/langflow
    volumes:
      - langflow-data:/app/langflow

volumes:
  langflow-data:

Dockerfile
`FROM langflowai/langflow:1.0-alpha
CMD ["python", "-m", "langflow", "run", "--host", "<IP_ADDRESS>", "--port", "7860"]`

seems to be related to:

https://github.com/pydantic/pydantic/issues/9609
https://stackoverflow.com/questions/78593700/langchain-community-langchain-packages-giving-error-missing-1-required-keywor


Add a simple tracing setup to the docker-compose

I have a couple of open questions:

Should this be in a separate docker-compose config?
Should we also add this to the high-availability setup?
Are we okay with the way I've integrated tracegen? There's no pre-built docker container, so that was the simplest method to get it working.

I'm gonna wait for some tracing support in Promscale and then use that as a source of traces instead of tracegen.

FYI I have added a config on top of ante's open PR here: https://github.com/timescale/promscale/pull/1052. Once that is merged I will rebase and un-draft this PR.


Slow motion movement when sprinting

When using the code in the construction script of the ALS_Base character, a sudden slow motion movement can be seen when sprinting ( on any other client ) this happens with both looking and velocity direction
steps to reproduce - Connect the construction script, then play with 2 clients ( make sure you can see both screens clearly ) start sprinting from client 1 , around the client 2 player . Then while sprinting quickly change the direction ( like immediately run backwards )
now on the client 2 screen you will be able to see that the client 1 player is running in slow motion

you only need to disable this in construct script


fix NewShardOwner to not return a current owner

Fixed meta.NewShardOwner() so it wouldn't return an ID for a data node
that already owns the shard.
Required for all non-trivial PRs

[x] Rebased/mergable
[ ] Tests pass

Closing because this function is no longer needed and will be removed by a followup PR.


Build error of target images

Describe the bug
Build step of target images failed in image/jpeg.cpp
row 476:40:
int32_t exposure_time = metadata.get(libcamera::controls::ExposureTime);

cannot convert ‘std::optional’ to ‘int32_t’ {aka ‘int’} in initialization

This is because of a recent libcamera API change.  A fix for this is under testing at https://github.com/raspberrypi/libcamera-apps/pull/322.
In the meantime, you can build libcamera from github/raspberrypi/libcamera/ .

#322 has now been merged.


[Important] ghprb plugin has a bug

GitHub PR Builder plugin has got a bug https://github.com/jenkinsci/ghprb-plugin/issues/134
Please, use ghprb 1.24.4 from here http://updates.jenkins-ci.org/download/plugins/ghprb/1.24.4/ghprb.hpi untill https://github.com/jenkinsci/ghprb-plugin/issues/134 fixed

Also new version doesn't show:

"Comment file" in Job settings
"Lines of build log to include in comments" in general settings
"Published Jenkins URL" in general settings

When you build CI server from scratch, GitHub PR Builder post empty messages to GitHub when build is failed.

How to solve issue with comments in newer versions(not in all) https://github.com/janinko/ghprb/issues/292#issuecomment-115257608

@Sanchiz can we update ghprb plugin then?

@podarok no, it's still not stable https://github.com/janinko/ghprb/issues/292#issuecomment-165712647

ah, ok, waiting then

Here's issue for Jenkins plugin https://github.com/janinko/ghprb/issues/379

How to fix not available "Comment file" and "Append portion of build log" field in Global/Job Configuration.
Add this code into <extensions> section in configuration file:
<org.jenkinsci.plugins.ghprb.extensions.comments.GhprbCommentFile>
  <commentFilePath>${WORKSPACE}/commentinfo.md</commentFilePath>
</org.jenkinsci.plugins.ghprb.extensions.comments.GhprbCommentFile>
<org.jenkinsci.plugins.ghprb.extensions.comments.GhprbBuildLog>
  <logExcerptLines>25</logExcerptLines>
</org.jenkinsci.plugins.ghprb.extensions.comments.GhprbBuildLog>

For Global Configuration use /var/lib/jenkins/org.jenkinsci.plugins.ghprb.GhprbTrigger.xml file and for Job configuration /var/lib/jenkins/jobs/JOB_NAME/config.xml.


Fix for #2968

My eclipse initially added 10 missing @Overrides (I still don't know why some people don't like 'em), so I used the github file edit feature instead.

I don't know, using the web editor automatically makes any PR suspect.

I know. That's why I first made the change in eclipse and then carefully copypasted the change into the web editor. Then I double and triple checked everything twice more, to make sure that nothing went wrong.

We'll see...

Because they add clutter and aren't needed in the core library. If you want
a better explanation you can find my other github comments on the subject.
They make more sense in user code that uses libgdx. Anyway, I don't care so
much and this PR is fine, but I don't see a point in going through all of
libgdx and adding the annotation.
On Mar 22, 2015 7:40 PM, "Daniel Holderbaum"<EMAIL_ADDRESS>wrote:

My eclipse initially added 10 missing @Overrides (I still don't know why
some people don't like 'em), so I used the github file edit feature
instead.
You can view, comment on, or merge this pull request online at:
https://github.com/libgdx/libgdx/pull/2969
Commit Summary

Fix for #2968

File Changes

M gdx/src/com/badlogic/gdx/scenes/scene2d/Stage.java
https://github.com/libgdx/libgdx/pull/2969/files#diff-0 (2)

Patch Links:

https://github.com/libgdx/libgdx/pull/2969.patch
https://github.com/libgdx/libgdx/pull/2969.diff

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/pull/2969.

I'm for @override so the refactoring of a certain special person doesn't
end up in a bunch of methods that get never called. I'll just write an
Eclipse plugin that hides the overrides for said person who shall remain
unnamed. It's Nate.
On Mar 23, 2015 12:08 AM, "Nathan Sweet"<EMAIL_ADDRESS>wrote:

Because they add clutter and aren't needed in the core library. If you want
a better explanation you can find my other github comments on the subject.
They make more sense in user code that uses libgdx. Anyway, I don't care so
much and this PR is fine, but I don't see a point in going through all of
libgdx and adding the annotation.
On Mar 22, 2015 7:40 PM, "Daniel Holderbaum"<EMAIL_ADDRESS>wrote:

My eclipse initially added 10 missing @Overrides (I still don't know why
some people don't like 'em), so I used the github file edit feature
instead.
You can view, comment on, or merge this pull request online at:
https://github.com/libgdx/libgdx/pull/2969
Commit Summary

Fix for #2968

File Changes

M gdx/src/com/badlogic/gdx/scenes/scene2d/Stage.java
https://github.com/libgdx/libgdx/pull/2969/files#diff-0 (2)

Patch Links:

https://github.com/libgdx/libgdx/pull/2969.patch
https://github.com/libgdx/libgdx/pull/2969.diff

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/pull/2969.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/pull/2969#issuecomment-84729907.

Sounds like a great idea, any eta? :smile:

Because they add clutter and aren't needed in the core library. If you want a better explanation you can find my other github comments on the subject. They make more sense in user code that uses libgdx. Anyway, I don't care so much and this PR is fine, but I don't see a point in going through all of libgdx and adding the annotation.

Maybe I became immune to code clutter, because of my job as a JavaEE dev.
I agree that the annotation is much more useful in user code than in libgdx itself. However, even if it is less helpful, it still provides some use and protection against refactoring mistakes.
When I get home, I will try a project-wide formatting and hopefully this will also add the missing @Override. Eclipse can automatically add the missing annotations, when performing the save actions. In this case I could setup a PR to add all of them at once, then we'll see how bad it would really be.
If that won't work, I'd suggest that from now on, everyone is free to add the annotation (even in Nate's code) if it is missing somewhere and we won't remove them. That way @Override should slowly find its way into libgdx.

I'd prefer if this was just done when people are working on something where it is missing, rather than messing up history for the sake of the annotations.

I agree that the annotation is much more useful in user code than in
libgdx itself. However, even if it is less helpful, it still provides
some use and protection against refactoring mistakes.

While it can help find mistakes in sloppy work, more careful refactoring
using automated tools makes it unnecessary. Since I'm generally the one
refactoring the parts of libgdx I maintain, I don't see a reason to litter
annotations throughout that code.

When I get home, I will try a project-wide formatting and hopefully this
will also add the missing @Override. Eclipse can automatically add the
missing annotations, when performing the save actions. In this case I could
setup a PR to add all of them at once, then we'll see how bad it would
really be.

Again, I personally don't think it is at all interesting to add @Override
project wide. If Mario's plugin can hide them in Eclipse, then I wouldn't
care as much.

If that won't work, I'd suggest that from now on, everyone is free to add
the annotation (even in Nate's code) if it is missing somewhere and we
won't remove them. That way @Override should slowly find its way into
libgdx.

Is there an actual problem we are trying to solve with this?

History repeating such as the @Override saga always fascinated me. :smile:

Again, I personally don't think it is at all interesting to add @Override project wide. If Mario's plugin can hide them in Eclipse, then I wouldn't care as much.

I see that this annotation might be a matter of "taste", but why is it bothering you so much, that you need a plugin to hide it? Nobody these days reads the JavaDoc in front of the method declarations. You hover your mouse over it and then look at the neatly formatted IDE popup that opens up, or read it online. But I bet you don't use a plugin to hide the JavaDoc in code.

Is there an actual problem we are trying to solve with this?

Yes, the (rare) problem of being able to make mistakes while refactoring that could have been avoided if this annotation would have been added before. Is there an actual problem we are solving by not adding the annotation?

I'd prefer if this was just done when people are working on something where it is missing, rather than messing up history for the sake of the annotations.

I thought it will mess the history up a bit less if it's a single commit instead of having the annotations added via PRs, which have nothing to do with it. (Like this one, which would have been 10x @Override for 1 line of actual code change.)
In the end, I don't really care if it's present everywhere or not. I just don't want to feel guilty when my eclipse "accidentally" added the annotation somewhere...

I don't think anyone working on LibGDX should be using anything that 'accidentally' adds things.

By "accidentally" I meant that it is doing it without me noticing it when it's being added, because it does it as soon as I save a file. Of course it's doing it technically correct.

I know, I just don't think that is a good thing.

I see that this annotation might be a matter of "taste", but why is it
bothering you so much, that you need a plugin to hide it? Nobody these days
reads the JavaDoc in front of the method declarations. You hover your mouse
over it and then look at the neatly formatted IDE popup that opens up, or
read it online. But I bet you don't use a plugin to hide the JavaDoc in
code.

I don't hide javadocs both because they are important and that they need
to be kept up to date. I almost always read them through completion or
directly as comments if I'm also looking at the code, only using the
javadoc view for massive docs or when there is a lot of markup.
I don't need to see @Override to know a method is overridden because
Eclipse places a marker on the line number.

Is there an actual problem we are trying to solve with this?
Yes, the (rare) problem of being able to make mistakes while refactoring
that could have been avoided if this annotation would have been added
before. Is there an actual problem we are solving by not adding the
annotation?

When using automated tools (as should be done), @Override has no usefulness
in library code. If refactoring is done manually and mistakes are made
because of missing @Override annotations, maybe that person shouldn't be
doing the refactoring. ;)
Automating insertion of @Override puts it all over the place: on listeners
and other anonymous class methods which are already very verbose, on JDK
and other methods that are impossible or extremely unlikely to ever change,
etc. The importance of my @Override resistance may be questionable, but
either way I still contend that it is indeed clutter (again, I'm only
speaking for library code).
Due to my own OCD, brain damage, or something else, I attempt to keep my
code super pristine. Doing this requires many small rules for coding style,
commenting, naming conventions, etc. I appreciate others also work on this
project and I don't attempt to force my crazy on everyone (just the
formatter). It's not that @Overrides are the end of the world, but I don't
like to bend my little rules without good reason and I really haven't heard
a good argument for it yet. :)
If we do enforce @Override everywhere, I'd probably want to edit the
formatter to put annotations on the same line as the method, so it doesn't
eat a whole line for nothing. The downside with this are: 1) annotations
that are actually useful don't stand out, and 2) annotations that are
verbose push the method declaration to the right and can cause wrapping. I
suppose we don't use annotations a whole lot in libgdx though.
I'd prefer if this was just done when people are working on something

where it is missing, rather than messing up history for the sake of the
.
annotations.
I thought it will mess the history up a bit less if it's a single commit
instead of having the annotations added via PRs, which have nothing to do
with it. (Like this one, which would have been 10x @Override for 1 line
of actual code change.)
In the end, I don't really care if it's present everywhere or not. I just
don't want to feel guilty when my eclipse "accidentally" added the
annotation somewhere...

You should feel guilty since you are in control of your own IDE
configuration and are responsible for its actions! :) You can use per
project settings to prevent the problem.
I've heard a similar argument from people who leave automatically generated
TODO comments in their code. Those people should be flogged!

Okay, I will turn that feature off for the libgdx projects, until the general opinion about the annotation in libgdx has changed. I just thought that it's stupid to not enable it, as it's absolutely no work and might prevent some mistakes.
I understand your point though. I like clean, short code as well and my senses probably just got numb while doing JEE, where I'm writing more annotations than actual code. I just don't notice them anymore.
Maybe you should write a wiki article about @Override. It might save you some time in the long run. :)


Alternative for obsolete SQLiteConnectionPool?

SQLiteConnectionPool is obsolete now. Is there an alternative in the library? Should we implement one ourselves? Or do you advise to not work with connection pools at all for common scenarios (I am not sure we need one)?

I am of the opinion that it is not really needed.

fine, thanks for the quick response.

why it is not needed? what is the best practice?


web.config not copied to acme-challenge folder when running unattended

I'm running the following config:
Windows 2012R2, clean install, all updates applied
letsencrypt-win-simple 1.9.1
When i run letsencrypt.exe in interactive mode, the file web.config is being created in the acme-challenge folder. However when i run it with the following parameters it does not create the file
letsencrypt.exe --accepttos --manualhost [fqdn] --webroot c:\inetpub\wwwroot
Current workaround (using ansible)

create .well-known\acme-challenge directory
copy web.config file from install folder
run lets-encrypt.exe

Are you running letsencrypt as an admin? I'd say if it's not able to create the files that it's a permissions issue so that should resolve the problem for you.

I'm having the same problem as morphje. I am running as Admin with correct rights on the webroot folder. I can resolve my problem using a similar approach to morphje however I wonder if this may be worth looking at. I am happy to work with someone to see if we can see what's going on.

Same problem here as well.

Same here. I'm guessing it's not a permission issue since it does successfully create the folders as well as the challenge file itself. The only file that is missing is the web.config.

Since I'm using the command line tool in a batch file with a larger context I've added folder creation to the overall script like so:
:create_https
rem ===========================================================
rem Create https bindings and letsencrypt cert for site
rem ===========================================================
echo creating required files and folders for TLC certs
if not exist %WEB_PATH%.well-known\acme-challenge mkdir %WEB_PATH%.well-known\acme-challenge
if not exist %WEB_PATH%.well-known\acme-challenge\web.config copy %CERTTOOLPATH%\Web_Config.xml %TLC_PATH%.well-known\acme-challenge\web.config
echo Okay we need to wait a short while for DNS to update so LETSENCRYPT can find the site .........
timeout 30
echo Getting SSL cert from LetsEncrypt for site on %URL%
%CERTTOOL% --accepttos --manualhost "%URL%" --webroot "%WEB_PATH%"
Hope this helps someone :)

This is by design, as the manual mode can also be used without IIS. In fact I believe that is the primary use case for it. Especially with the new features in v1.9.6 it should be possible to create all IIS certificates you want, even unattended, so I'm going to close this issue for now.


Update README.md

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

In this repo i gave just edited my name.And this is my 1st Pull request to any repo thanks for making me learn this.

Hey, I am closing this PR as it's open for a while. Feel free to raise a new PR. if you need any help do let's know in the discord server
__
  Summary: :hammer_and_wrench: This code needs a fix


Error in the example in README

#import "@preview/crossregex:0.1.0"

#crossregex(
  3,
  constraints: (
    `A.*`, `B.*`, `C.*`, `D.*`, `E.*`,
    `F.*`, `G.*`, `H.*`, `I.*`, `J.*`,
    `K.*`, `L.*`, `M.*`, `N.*`, `O.*`,
  ),
  answer: (
    "ABC",
    "DEFG",
    "HIJKL",
    "MNOP",
    "QRS",
  ),
)

fails as expected function, found module. Changing the import to #import "@preview/crossregex:0.1.0": * fixes this.

Thank you very much for your catch! It's my negligence, and the example works well after the import fix.


[no squash] lib: Filter out deprecated bridges from BridgeList

Alternative to https://github.com/RSS-Bridge/rss-bridge/pull/2885.

Thanks for the pr. There's too much going on here. We are not introducing psalm or php8 annotations on my watch. Also using reflection to grab a value from phpdoc is insane.

There's too much going on here.

It is meant to be reviewed commit by commit but I split it to separate PRs if that will make it easier.

We are not introducing psalm or php8 annotations on my watch.

The PHPDoc annotations I introduced are not PHP8 nor Psalm specific – they are widely supported by tools like PHPStan, Psalm and PHPStorm. And I find them immensely useful just for looking at the functions since they allow me to immediately see what the function takes as argument/returns. For example, when I was trying to review #2887, I had to first check where $submissionHTML is defined to find out its type. That lead me to getFASimpleHTMLDOM method, which still did not get me this information, so I continued to defaultLinkTo function, which according to its type annotation returns object. At this point I gave up in frustration. If each function (at least in lib/) contained precise type annotation, I could stop this traversal after one step. Or if I used PHPStorm as an IDE or LSP, I could just hover over the variable with my mouse and would learn the type immediately.

Also using reflection to grab a value from phpdoc is insane.

I believe that is standard way for getting PHPDoc annotations. Normally, I would use something like phpdocumentor/reflection-docblock but since I know your position on dependencies, I decided to roll a NIH implementation :wink:
The only other somewhat clear option I can come up with is to provide this metadata is by implementing an interface like the following:
interface DeprecatedBridge {
    function getDeprecationReason(): ?string;
}

But I would say deprecation status is not an inherent property of a bridge but rather a status conveyed to it so metadata like docblock is better place for this information. (Though this is somewhat philosophical notion and we need not follow it strictly if it clashes with some practical concerns.)

I understand your point about typing. I am in favor of more typing in the actual php code (not docblock). And yes I know that some typing must be done in phpdoc e.g. BridgeInterface[].


Add proposal E

This proposal uses the previously reserved "platform.features" field for specifying strict hardware requirements. This is based on a discussion with a few of the containerd maintainers.
Fixes #12.

cc @stevvooe

From my standpoint, this is functionally almost equivalent to proposal A, it's just putting the metadata attributes in a slightly different spot. I'm indifferent to the two I think, and defer to the runtime tool maintainers.

Switching from user extendable annotations to spec defined values means that scenarios like the MPI version dependency wouldn't be possible unless image-spec decided to support it and containerd implemented it. There's a trade-off between flexibility and control. I'm not pushing for this over A, just getting it documented so it's available as an option if we decide to combine a few of these proposals together later.

If there is still going to be an external artifact, then I can remain indifferent! But if this is just it, this is probably far worse for all the use cases I care about.

Overall the proposal looks good to me, but I am wondering if platform.features should be array of strings or key value pair.
Also it would be good to hear from @stevvooe @estesp if they would consider usage of the platform.features for image selection.

Overall the proposal looks good to me, but I am wondering if platform.features should be array of strings or key value pair.

It's already defined in the spec, so changing the data structure would be a breaking change.
https://github.com/opencontainers/image-spec/blob/main/image-index.md

@sudo-bmitch right, but:

This property is RESERVED for future versions of the specification.

At least in theory, no one has used that field so far.

@sudo-bmitch right, but:

This property is RESERVED for future versions of the specification.

At least in theory, no one has used that field so far.

Damn, I just got called a "no one" 😂
https://github.com/regclient/regclient/blob/1eccd0755c352e37e56a170917857e6dd5711985/types/platform/platform.go#L50-L51

Damn, I just got called a "no one" 😂

Can be an honor depending on who does the calling!
https://youtu.be/rywUS-ohqeE?si=bj_HxsY4CRikiUou

In some aspects this overlaps in the ongoing discussion for proposal H.

If we need a map instead of a slice of strings, that would probably best be done with a new field. But before making a change like that, I'd want to establish the need.

I think it would be a good idea, as @ChaoyiHuang proposed, to introduce a new field platform.compatibilities.
Additionally I would add very fundamental labels that are supported by OCI and cover generic use cases.
Those would be (open for discussion):
cpu.features.<FEATURE_NAME>.present: <bool>
cpu.model.vendor_id: <string>
cpu.model.family: <int>
cpu.model.id: <int>
pci.<class>.<vendor>.<id>.present: <bool>
usb.<class>.<vendor>.<id>.present: <bool>
kernel.config.<CONFIG>: <string>
kernel.modules.<NAME>: <string>
kernel.modules.<NAME>.<PARAMETER>: <string>
kernel.version.range: <string>

I would also allow for custom labels, OCI would not care what is in there.
Example of that
custom.sr_iov.enabled: true // telco specific use case
custom.mpi.version: 5.0 // hpc specific use case
...

My reasoning behind that is: we have to come up with a standard way of describing generic compatibility. Other specific use cases (like telco, hpc) would have to use custom labels. We agreed that we have to build our own tools to solve our specific use cases, so the tooling would recognize the custom labels which are known to the use case.
Finally, if community and OCI see a need to graduate some specific custom label to well known labels we could do it carefully over time.

Additionally I would add very fundamental labels that are supported by OCI and cover generic use cases.

I think we want that, but that's not what this specific proposal is looking at. This is focused at things like CPU features that would prevent a binary from executing on the host, and a finer grain difference than linux/amd64/v1 vs linux/amd64/v2 that pull in a collection of CPU features. The more generic use cases would be better handled by the other proposals.
The goal of submitting this is two fold. First, it's putting up the scenario we discussed with the containerd maintainers so we can properly compare it to the other proposals (it's hard to compare something that doesn't get written down). And second is to have it as a potential building block in an eventual proposal that we adopt, not used on its own, but as part of a collection of solutions that work together.

I've updated this with a link to a Go package that defines a list of possible feature values to further clarify the proposal. I'm leaning on Go since OCI already does that for the architecture support today.


[Update] Firebase for iOS v6.34.0

For review, @Redth @SotoiGhost @dalexsoto
Potentially fixes:
#433, #434, #434, #436, #439
Includes,
GoogleMobileAds updated to v7.66.0 (replaced PersonalizedAdConsent with GoogleUserMessagingPlatform)
GoogleMaps & GooglePlaces updated to v3.9
Ran the sample projects and everything seems to work/link okay.

Wow this is amazing!! Thanks a lot for your contribution ♥, we will have a look at it ASAP!

Looks like the CI failed because it was using an older version of Xcode, let's force it to use 12

Hi,
I' m very familiar with the the ins and outs of code behind these binding libraries. But is correct that the Crashlytics.targets still points to Crashlytics-4.0.0-beta.6.zip?

@mayhammf thanks for pointing that out! I've updated the targets file.
The native framework reference was correct (v4.6.2). The targets file seems to get be grabbing the Firebase source and then using an included executable upload-symbols to push the app's symbols to Firebase. Most likely to get meaningful stack traces and error messages.

@dmariogatto I actually noticed the .targets file as I was testing the NuGet packages produced by this PR and experienced an issue similar to the one described here #440 (VS freezes the moment it imports the Crashlytics.targets)
I hope this won't be an issue once these package are released.

@mayhammf I've made another change to Crashlytics.targets hopefully addressing #440. It now just downloads the single executable, upload-symbols, rather than the whole repo. I have a feeling it might have been hanging on extraction. I've tested on Windows/Mac and it did successfully upload the dSYM file.

Thanks for looking into it ♥, we are testing on our side just to make sure all is good to go

Argh the build failed, let me kick it again, also I've tested the majority of the samples and they are working fine so far, there are some I need to create special provisioning profiles to test, I am looking at those today but really confident with the results so far. Thanks again!

Thanks a lot for your contribution ♥

@dalexsoto @SotoiGhost Thank you both for getting this reviewed & merged! 👍

@dalexsoto thank you & @dmariogatto
Will the packages of this update be available on NuGet.org soon?
Thanks again

Hello they should be available in nuget now


Trystan's Cookie Clicker

Brainstorm ideas:

Snake
JS Calculator
Itunes
Cookie Clicker
Cookie clicker wins because it simple to make/easy to upgrade.
Trystan is creating  his own base cookie clicker with his with his own desired features. Minimally the page should have an image of a cookie and a cursor event to click on the image. The amount of cookies should be displayed.

Issue Closed Final Output

Live Demo: https://trystan-schmits.github.io/CSA1/playground/

Done


[Additional publisher] Codeunit 410, Update Analysis View, OnBeforeUpdateEntriesForGLAccount

Hi Team,
In codeunit 410 - "Update Analysis View", we need possibility to process more on function "UpdateEntriesForGLAccount". Standard publisher OnBeforeUpdateEntriesForGLAccount may help us:

[IntegrationEvent(false, false)]
local procedure OnBeforeUpdateEntriesForGLAccount(var TempAnalysisViewEntry: Record "Analysis View Entry" temporary; AnalysisView: Record "Analysis View"; LastGLEntryNo: Integer; var NoOfEntries: Integer; var IsHandled: Boolean)
begin
end;

Please create dedicated request for making function global

Hi,
I have created another request.
Please help me to process.
Thank you.

This has been implemented already several updates ago, closing the issue. The tag 'ships-in-future-update' is for housekeeping.


PR: Raise timeout for jupyter session

This PR raises the timeout length for a jupyter session.  I believe it changed it the right place.  Please let me know if there is another place.
Reference Issues or PRs

fixes  #1615
https://github.com/nebari-dev/nebari/issues/1615
What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[x ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

This raises the timeout for the jupyter session, but the issue is around raising the timeout for the jupyter terminal session. A slight, but important, nuance.

/bot run tests

I'm not sure why the /bot run tests command isn't working but I'm confident this PR would pass the tests that have been skipped.


Update Apple platform naming in readme

A minor change to reflect how Apple currently names their software:
• Since 2015 AppleTVs run "tvOS" and since 2019 iPads run "iPadOS", rather than both running iOS.
• Since 2016 Macs run "macOS" rather than "OSX". Since macOS's major version number is incremented for major updates the "X" (10 in Roman numerals) doesn't make sense anymore. "OSX (11+)" reads like a contradiction: "Mac OS version 10 (version 11)"

Update docs too: https://github.com/bkaradzic/bgfx/tree/master/docs

:+1:


Ensuring necessary shared libraries are included in the conda package

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

The current conda package does not include the umfile.so file (see this bug report). I believe that this is not included because the current build script relies on pip to build all the supporting packages for cf-python, so conda-build then leaves out the shared library because it is referencing files that are not managed by the conda build system - even though these will be provided later by the run requirements, that is not made explicitly clear to conda build.
So, I've added all the required packages to the build section of the script. Doing this enables pip to create the required libraries in my local conda environments, without pip having to install anything but cf-python, so hopefully it will do the same here too.
I've removed the version requirements from the run section - hopefully these will now be automatically set by conda build using the version information from the build section. That might not happen - if it doesn't we should add these back in.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forgeadmin, please rerender

Can you add a test for this functionality. It seems that it fails with a warning only, so we don't really know if it is working from a green CI. BTW, it is still failing b/c the subprocess call to make is failing to find a compiler:
2022-08-08T10:57:57.0678466Z   ********************************************************************************
2022-08-08T10:57:57.0684501Z   Running: make -C /home/conda/feedstock_root/build_artifacts/cf-python_1659956147498/work/build/lib/cf/umread_lib/c-lib
2022-08-08T10:57:57.0689560Z
2022-08-08T10:57:57.0695950Z   make: Entering directory '/home/conda/feedstock_root/build_artifacts/cf-python_1659956147498/work/build/lib/cf/umread_lib/c-lib'
2022-08-08T10:57:57.0701577Z   gcc -Wall -fPIC -DLINUX -c umfile.c
2022-08-08T10:57:57.0707151Z   make: gcc: No such file or directory
2022-08-08T10:57:57.0712023Z   make: *** [Makefile:47: umfile.o] Error 127
2022-08-08T10:57:57.0718204Z   make: Leaving directory '/home/conda/feedstock_root/build_artifacts/cf-python_1659956147498/work/build/lib/cf/umread_lib/c-lib'
2022-08-08T10:57:57.0723017Z
2022-08-08T10:57:57.0728811Z    --------------------------------------------------------------------------------
2022-08-08T10:57:57.0733990Z   WARNING: Failed to build the UM read C library.
2022-08-08T10:57:57.0739745Z            Attempting to read UKMO PP and UM format files will result in failure.
2022-08-08T10:57:57.0745119Z            This will not affect any other cf functionality.
2022-08-08T10:57:57.0750483Z            In particular, netCDF file processing is unaffected.
2022-08-08T10:57:57.0755803Z   --------------------------------------------------------------------------------
2022-08-08T10:57:57.0760811Z
2022-08-08T10:57:57.0765897Z    ********************************************************************************
2022-08-08T10:57:57.0771646Z
2022-08-08T10:57:57.0776632Z   cf build successful

We will need to patch it to find the gcc binary correctly.

That's an annoying error (seeing as this is what I'm trying to add). I'll see if I can find a fix.

@conda-forge-admin, please rerender

That's an annoying error (seeing as this is what I'm trying to add). I'll see if I can find a fix.

The build won't find gcc as I mentioned above. You'll need to patch the build to use $GCC instead.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Deleting Entries in History/Favourite changes favourite Mark of unrelated Items

Deleting an entry that the user made favourite in this session causes the DataManager to wrongly apply a favourite mark to an unrelated Entry.

This Bug has been recreated again, this is not fixed

This Bug has been recreated again, this is not fixed

The current design causes multiple deletes in a session to make reading already loaded data very inefficient. Will be switched to a new design, that will not have this issue

The current design causes multiple deletes in a session to make reading already loaded data very inefficient. Will be switched to a new design, that will not have this issue


Add note shortcode to 'Debugging Kubernetes nodes with crictl'

Fixes k/website issue 25504
Add note shortcode to 'Debugging Kubernetes nodes with crictl'

/cc @sftim

The preview for the edited page:
https://deploy-preview-25507--kubernetes-io-master-staging.netlify.app/docs/tasks/debug-application-cluster/crictl/


Can't restore from Google Storage

The code uses ListObjectsV2 which isn't supported by the google storage api.
https://github.com/rancher/backup-restore-operator/blob/master/pkg/objectstore/s3minio.go#L170
Errror on restore:
ERRO[2021/02/24 01:54:11] failed to list objects in backup buckets [bucketname]:
A header or query you provided requested a function that is not implemented.

minio fixed it in mc: https://github.com/minio/mc/pull/3101/files#diff-be74cc7510906e23a9983b3164a5dc6e383e0bb2cde5adf62d54ae89e844c3c6
isGoogle(c.targetURL.Host) basically compares the Host value with "storage.googleapis.com"
in minio-go, they offer a ListObjects func that accepts a useV1 option: https://github.com/minio/minio-go/blob/7f05f7e9774ec1860922ce5bf2f6717faf8677aa/api-list.go#L641
I tested just by removing the "V2" from ListObjectsV2 and ran my custom image and the restore worked.
thx,
Eric
gz#15493

@fewkso how were you able to use Google storage from the chart ?

@fewkso how were you able to use Google storage from the chart ?

In GCS settings I created an access key, created a secret and then I configured the chart like this:
secret file:
kind: Secret
metadata:
  name: rancher-backup-creds
  namespace: cattle-resources-system
type: Opaque
data:
  accessKey: $RANCHER_BACKUP_ACCESS_KEY
  secretKey: $RANCHER_BACKUP_SECRET_KEY

values file:
  enabled: true
  credentialSecretName: rancher-backup-creds
  credentialSecretNamespace: cattle-resources-system
  region: northamerica-northeast1
  bucketName: bucket-backup-data
  folder: rancher-ha
  endpoint: storage.googleapis.com```

  This works for backup, but then, the restore fails because GCS api doesn't support v2 calls, thus this issue.

+1 for this bug, same issue here as well !

Root cause
Unable to use Google Cloud Storage as backend
What was fixed, or what changes have occurred
Added support to use a different function to use Google Cloud Storage
Areas or cases that should be tested
Regular S3 usage (and/or Minio) and using Google Cloud Storage as backend
What areas could experience regressions?
Regular S3 usage (and/or Minio)
Are the repro steps accurate/minimal?

Use Google Cloud Storage as S3 backend for backup-restore-operator

Verified on 2.6.5-rc8
Steps to Reproduce:

Create Google Storage Bucket
Create an Access Key (Settings->Interoperability->Access keys for your user account)
Bring up Rancher 2.6.5-rc8
Install Rancher Backups
Create Resources(i.e. users, cluster templates etc)
Create s3 Backup to Google Store using the credentials created in Step 2.
Create more Resources(i.e. users, cluster templates etc)
Restore from s3 Backup on Google Storage (No Errors)


README  example two simplifying

Simplify example two: remove the closure from updateDom. Simply have a function that does the DOM update based on an input parameter and another function that calculates the value of that parameter based on some other logic.

Hi- I was trying to fix this issue because we delivered the workshop today, and I'm pretty sure the example as it is doesn't work (we skipped the example in the end).
This is what I had after trying to simplify, reading @hasansaad1's PR, and the comments from @eliascodes:
initial non-pure
var isVisible = true;

function toggleImageVisibility() {
  var myImage = document.getElementById("myImage");

  if (isVisible === true) {
    myImage.style.opacity = 0;
    isVisible = false;
  }

  else if (isVisible === false) {
    myImage.style.opacity = 1;
    isVisible = true;
  }

}
toggleInvisibility();

refactored purer
function updateOpacity(element, opacity) {
  element.styles.opacity = opacity;
}

function getNextOpacity(imageIsVisible) {
  if (imageIsVisible === true) {
    return 0;
  } else if (imageIsVisible === false) {
    return 1;
  }
}

var isVisible = true

function toggleInvisibility() {
  var myImage = document.getElementById('myImage')
  updateOpacity(myImage, getNextOpacity(isVisible))
  isVisible = !isVisible
}

// When we're ready...
toggleInvisibility();

However this doesn't seem much better, as updateOpacity is the only real improvement to the  toggleInvisibility function, and it is not even pure.

Any thoughts? If someone has a nicer example I'd be happy to try to incorporate it into the README instead of the current one.

This example possibly suffers from the fact that the example of a toggle is too simple. The logic is really just s => !s. Everything else needs to interact with the DOM API to some degree.
It may be clearer to learners if the functionality being demonstrated had a more substantial logic component. At the same time, it's easy to go too far here, and make the example incomprehensible.

@eliascodes I agree, but currently I think the example is incomprehensible. Do you know what has happened when this has been delivered in London?

Do you know what has happened when this has been delivered in London?

Not really, better off asking the CFs.
What about cycling instead of toggling? A -> B -> C -> A ...
Before:
(() => {
  const node = document.querySelector('...');

  if (node.classList.contains('A')) {
    node.classList.replace('A', 'B');
  } else if (node.classList.contains('B')) {
    node.classList.replace('B', 'C');
  } else if (node.classList.contains('C')) {
    node.classList.replace('C', 'A');
  } else {
    node.classList.add('A');
  }
})()

After:
const getNextClass = (class, list) =>
  list[(list.indexOf(class) + 1) % list.length];

const replaceClass = (old, new, node) =>
  node.classList.replace(old, new);

// Usage:
const classes = ['A', 'B', 'C'];
let current = classes[0];
(() => {
  const node = document.querySelector('...');

  // Calculate state (pure)
  const next = getNextClass(current, classes);

  // Effect
  replaceClass(current, next, node);
})()

No need to do getNextClass in a one liner.

@mattlub I don't recall any problems from the last time it was delivered, checked the sgc minutes and it seems to be fine as well...
I would say though that Elias's example is really abstract and something with actual classes/names would make more sense :upside_down_face: (which I'm pretty sure is what you were going for :smiley:)

Feedback from FAC15 a couple of weeks ago:
Pure functions workshop:

mistakes in readme, its talking about stuff that doesnt exist in the code
people not sure whats the point of the exercises, the descriptions should be clearer, so they know what they're expected to do
most did the first 3 functions quite quickly but were rather stuck on the increment array and the following ones
the tests when failing say "the original array had not been altered" which people understood meant they should be mutating the original array in order to pass test.

We delivered this last week with FAC16 and we didn't notice any unusual confusion.


Rebuild aframe-physics-systems

The previous build @ 9bdac9f was a stopgap for the various THREE-related dependencies breaking due to THREE.Geometry deprecation

Due to additional dependency issues within aframe-physics-system, went back to custom build with dfb0b9df (reduced size by omitting three). May end up just forking it for future (timely) updates of cannon-es, etc.


fix recaptcha api localization param according to language

localization of recaptcha api on signup page did not match the language

@mtr574 - updated according to your comment


De-duplicate some unit test paramatrization

This removes a lot of duplication in parametrizing the unit testing, by extracting a common decorator into a new file. I had to move the tests to a new sub-folder to get this to work, I hope that's okay?

Is keeping things in a single file a deliberate design choice? Personally from what I can see splitting up into separate files makes sense, given the original file is already so long.

(I'm going through outstanding PRs)
This does look like a nice simplification. Should we try and resolve conflicts, decide on the single file, and merge?

I don't have time to finish this off now, but someone else is more than welcome to run with it 😄

Closing since I don't have time to work on this any more


Question: German model

HI,
So I noticed there are a lot of German language  related parts in the code. But when I try to initialize
from spacy.de import German
nlp = German()

I get
model 'de>=1.0.0,<1.1.0' not installed. Please run 'python -m spacy.de.download' to install latest compatible model.
Because it is not present https://index.spacy.io/models. So I was wondering what the status of German support is?

Well spotted. We are going to support German soon.

I was wondering how far are you in this.  Which parts are missing? Can one contribute somehow?

Here's the list of features and their status as I understand it:
Annotations

[x] POS tags
[x] Dependency parse
[x] Sentence boundaries (via dependency parse)
[x] Noun chunks (via dependency parse)
[x] Word vectors
[ ] NER
[ ] Lemmas

Engineering integrations

[x] Load languages by ID string (e.g. nlp = spacy.load('de')
[x] Inspect language for data and models via token.lang, span.lang, doc.lang, nlp.lang etc
[x] Select correct noun chunk rules depending on language after parse
[ ] Select correct noun chunk rules depending on language after deserialise
[ ] Select correct lemmatisation depending on language after parse
[ ] Select correct lemmatisation depending on language after deserialise

We're happy to launch without all of the annotations, so the NER and lemmatisation isn't holding things up. But we've gone through a few iterations of how to get the engineering integrations done nicely. The crux of the issue is that we want to avoid a design where we commit to having different language subclasses of the different parts of the library, e.g. we don't want a GermanDoc, or a GermanParser, etc. I think this gets very messy very quickly. We've got a design that works now, so I'm just finishing up a small refactor to keep everything neat.
We'll try to get a development model hosted so you can play with something. But mostly it's just finishing this small refactor, and writing the documentation.

I can't wait to play with the german model! 💃

Sneak peek:
pip install http://github.com/spacy-io/spaCy/archive/master.zip
python -m spacy.de.download all
python

>>> import spacy
>>> nlp = spacy.load('de')
>>> doc =  nlp(y'Ich bin ein Berliner.')

Pretty much everything should be working except lemmatization. Word vectors are trained on a combination of the open subtitles corpus and Wikipedia, so they should have reasonablish domain independence. The NER and syntax are trained on newspaper text, so they might be a bit brittle to conversational text.
Full announcement to follow :)

You can now find the German-compatible code on PyPi and conda:
pip install --upgrade spacy
python -m spacy.de.download all
python

>>> import spacy
>>> nlp = spacy.load('de')
>>> doc =  nlp(u'Ich bin ein Berliner.')

@honnibal , you're the best man! Thanks! One beer on me next time i'm in Berlin.


allow not resolving url in css

What problem does this feature solve?
If we already put the image files in the path we need, there's no necessary to copy them into another folder again.
What does the proposed API of configuration look like?
module: {
  rules: [
    {
      test: /\.scss$/,
      use: [
        "postcss-loader",
        "sass-loader",
      ],
      type: "css",
      options: {
        url: false,
      }
    },
  ],
},

can you help test the webpack behavior

can you help test the webpack behavior

I'll be happy to help, what do I need to provide after testing?

https://github.com/web-infra-dev/rspack-repro a repro for mismatch is enough

This issue will be closed due to inactivity. Feel free to comment and reopen it if you have any further questions.

i am having the same issue.
Having url: false, did the trick in webpack.


Where is docs/ingress.md?

In the file helm/openwhisk/values.yaml, I see the following note:
whisk:
Ingress defines how to access OpenWhisk from outside the Kubernetes cluster.
See docs/ingress.md for a discussion of how to provide these values.
But I can not find out the file docs/ingress.md, where is it? Please help!  Thanks!

ingress.md has been split into several parts and moved to the document for specific k8s clusters. You can find the ingress configuration there.

Docker for Mac
kubeadm-dind-cluster
Minikube
IBM (IKS)
Google (GKE)
Amazon (EKS)

@xieweicarl2018  - thanks for reporting the dangling reference in the docs.  I have submitted a PR to fix values.yaml (as described by @daisy-ycguo above).


Adds matplotlib to the pyproject.toml for score/ to avoid import error

Summary
Fixes #322 by adding matplotlib to the project requirements for score/
Changes proposed

Adds matplotlib (and dependencies) to the following files:

pyproject.toml
poetry.lock
requirements.txt

Steps to review

Conduct a fresh install of the score/ directory following the instructions in #322 to reproduce the error
Checkout this PR then re-run poetry install to get the new dependencies
Open up a python interpreter: poetry run python
Run import matplotlib in the python interpreter and you should no longer receive the ModuleNotFoundError

We are not using matplotlib for the score python file (recently merged), as it was used for the Python notebook version which is no longer part of the codebase.


python39Packages.apache-beam build failure on x86_64-linux as of 7554374d

Issue description
Build of python39Packages.apache-beam failed on x86_64-linux as of 7554374dafc546dfef12cbdfdf1f9a09e3b5fd4d. This is currently breaking python39Packages.tensorflow-datasets.
error: builder for '/nix/store/iqri6xcmlfbi1b8d0y5lav9l8yj3z5gq-python3.9-apache-beam-2.40.0.drv' failed with exit code 1;
       last 10 log lines:
       > Requirement already satisfied: python-dateutil<3,>=2.8.0 in /nix/store/n3f5l2wqxkdzxzsnb6wqk94nx0vfgl55-python3.9-python-dateutil-2.8.2/lib/python3.9/site-packages (from apache-beam==2.40.0) (2.8.2)
       > Requirement already satisfied: crcmod<2.0,>=1.7 in /nix/store/jba7zs48axdcs25fp95v334jxxcvr3rp-python3.9-crcmod-1.7/lib/python3.9/site-packages (from apache-beam==2.40.0) (1.7)
       > Requirement already satisfied: dill in /nix/store/diln9v2dpvynygky6r8cx9j21snikd5d-python3.9-dill-<IP_ADDRESS>/lib/python3.9/site-packages (from apache-beam==2.40.0) (<IP_ADDRESS>)
       > Requirement already satisfied: httplib2<0.21.0,>=0.8 in /nix/store/1i04qlivm11v0cccr3qayyifr6x095j2-python3.9-httplib2-0.20.4/lib/python3.9/site-packages (from apache-beam==2.40.0) (0.20.4)
       > Requirement already satisfied: hdfs<3.0.0,>=2.1.0 in /nix/store/a9lcx41mm17vhq0kfm1wyk4vd9db85h8-python3.9-hdfs-2.5.8/lib/python3.9/site-packages (from apache-beam==2.40.0) (2.5.8)
       > Requirement already satisfied: cloudpickle<3,>=2.1.0 in /nix/store/fzg3jghhjh7jfmx7z5ywq5q1id55sa04-python3.9-cloudpickle-2.1.0/lib/python3.9/site-packages (from apache-beam==2.40.0) (2.1.0)
       > Requirement already satisfied: requests<3.0.0,>=2.24.0 in /nix/store/i7q184p69grljrjhwwn54inda55z0203-python3.9-requests-2.28.1/lib/python3.9/site-packages (from apache-beam==2.40.0) (2.28.1)
       > ERROR: Could not find a version that satisfies the requirement pymongo<4.0.0,>=3.8.0 (from apache-beam) (from versions: none)
       > ERROR: No matching distribution found for pymongo<4.0.0,>=3.8.0
       >
       For full logs, run 'nix log /nix/store/iqri6xcmlfbi1b8d0y5lav9l8yj3z5gq-python3.9-apache-beam-2.40.0.drv'.
error (ignored): error: cannot unlink '/tmp/nix-build-openmpi-4.1.4.drv-0': Directory not empty
error: 1 dependencies of derivation '/nix/store/8xcz6pd090x3nih96qh3przmdbq3v20n-python3.9-tensorflow-datasets-4.6.0.drv' failed to build

full build log
python39Packages.tensorflow-datasets maintainers cc: @ndl
python39Packages.apache-beam maintainers cc: @ndl
Other cc: n/a
Steps to reproduce

Checkout nixpkgs at commit 7554374dafc546dfef12cbdfdf1f9a09e3b5fd4d
Run nix-build -A python39Packages.apache-beam

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.0-1014-azure, Ubuntu, 20.04.4 LTS (Focal Fossa), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - nixpkgs: `/nix/store/vg2xri6d14pzcqb0kh81fdaqv8fmkmfr-source`

Misc.
This issue was automatically generated by nixpkgs-upkeep.

CI workflow that created this issue.
Internal tags: -8659903208900877966 -3403569299502064277

breakage caused by https://github.com/NixOS/nixpkgs/commit/bb32897568cda717953b0655439d47ca3d498b23

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgss-current-development-workflow-is-not-sustainable/18741/99

Did you try unpinning the dependency? If only the pinning is the problem than a revert is not justified.
From their changelog https://jira.mongodb.org/secure/ReleaseNote.jspa?projectId=10004&version=18463
https://jira.mongodb.org/browse/PYTHON-1298

It should be an easy upgrade for applications that previously upgraded to PyMongo 3.0, with most having to make no changes at all.

https://jira.mongodb.org/browse/PYTHON-2245

However, PyMongo's implicit encoding/decoding behavior still does not comply with this specification as these changes are backward-incompatible. We MUST make these changes as part of the PyMongo 4.0 release and include a section about the change in the migration guide.

So maybe unpinning just works? Please give that a try.
Edit:
There is also https://pymongo.readthedocs.io/en/stable/changelog.html#changes-in-version-4-0 which suggests that more is involved.

this is currently blocked on https://github.com/NixOS/nixpkgs/issues/185082

#185273

apache-beam is building successfully now: https://hydra.nixos.org/build/189911127


feat: chat-completion-client retries

Retries by default for LLM Calls

https://github.com/gptscript-ai/gptscript/pull/917 + https://github.com/gptscript-ai/chat-completion-client/pull/3

No new issues were seen when testing ingesting and retrievals  of knowledge files.


Update AMD blueprint with OpenFOAM application and test suite

This PR updates the AMD-optimized blueprint to install an OpenFOAM application that has been compiled with gcc targeting the Zen 3 platform (C2D instances). It also includes and documents a simple mechanism by which to run a test suite.
AMD (and I) have observed runtime failures ("error in IOstream") of the simpleFoam test when compiling OpenFOAM 8 with gcc 12.1. gcc 10.3 is the earliest release with support for AMD Zen 3 instructions.

[X] Is unit test coverage still above 80%?
[X] Have you updated all applicable documentation?
[X] Have you followed the guidelines in our Contributing document?

@SiddalingappaK I appreciate any feedback you have on this PR.

@SiddalingappaK I appreciate any feedback you have on this PR.
In the cluster after executing the command “spack config add concretizer:targets:host_compatible:false” I can compile zen3 applications.

I saw in the blueprint, you already mentioned the command so for clarification I deployed another cluster with openfoam, gcc 10.4.0 zen3, here compilation failed due to the checksum of gcc 10.4.0. In the same cluster,manually I compiled openfoam with gcc 10.4.0 zen3 through spack. Tutorial run also worked( without running “spack config add concretizer:targets:host_compatible:false”).
I also tested with gcc 11.1.0(zen3) and gcc 12.1.0(zen2,x86_64), I am getting error for both the cases while running tutorial run.
With gcc 10.3.0 I compiled, and tutorial run is working fine.
In the new commit as you selected gcc 10.3.0 is better it has checksum, supports zen3 and it is working fine.


Suggestion: Observers in Gamemode 3

http://gyazo.com/c522af1a309f31195908dbd93758f073

This isn't really an issue, and will be considered when there is a fluid way of doing this that doesn't remove functionality.

Maybe should be a "toggeable" option
http://gyazo.com/a008993ff7015d686ca4d05d40833316

@TiTo-418 Spectators don't have a visible inventory

@iEli2tyree011 Good point. but:
If you are in gamemode1: lever
If you are in gamemode 3: a command like /sp o /changegm

Maybe /toggle spectator. That solution seems inconsistent


fix: deployment script, decouple debugging and deployment settings

Description

fix #2007

Fix several bugs of deployment script.
Decouple appsettings to appsettings.Devlopment.json(for composer) and appsettings.Production.json(for azure deployment)

Task Item

Screenshots

@zidaneymar can you elaborate the design of decoupling appsetttings.json into dev.json and prod.json? a few questions is

is this just for publish or will composer need to write to a appsettings.{env}.json instead of appsettings.json?
is this a breaking change? what's the impact here? at least i saw now we need a new arugment to start runtime
i see you hard code development.json and prod.json, what if other env?

anyhow, let's get time to address those, and i put an onhold on this one in case accidentally merged.

@zidaneymar can you elaborate on the design of decoupling appsetttings.json into dev.json and prod.json? a few questions is

is this just for publish or will composer need to write to a appsettings.{env}.json instead of appsettings.json?
is this a breaking change? what's the impact here? at least i saw now we need a new arugment to start runtime
i see you hard code development.json and prod.json, what if other env?

anyhow, let's get time to address those, and i put an onhold on this one in case accidentally merged.

For now composer will update the customized settings file which is in ComposerDialogs\settings\appsettings.json, I think the root appsettings.json will not be changed by composer, it has many startup parameters for botruntime.
This is to fix #2007, previously the deployment script will write the app id, app password, blob storage and other config to the root appsettings.json, if user want to start up the local debugging environment, it will get an 401 unauthorized since the runtime has appid and pwd now.
So we need to decouple the composer dubugging env(deployment) and deployment env(production) to different files.
I'm not sure about the other env, in my understanding we have only two environments for debugging(users could set it as 'composer' but it is still used for debugging) and deployment.


Add propertypairs from the 20170102 dump

I'm not in the WMDE org right now, so doing this as a PR.

@mariushoch have you been added to the org?

@addshore No, and I can't be added until I have 2FA in place… and that is probably going to take me a while.

@mariushoch, ahh, I see!


Listen on AMQP for noop-example graph finish event.

Fixes random workflow test failure.
@RackHD/corecommitters @zyoung51 @keedya @uppalk1

lgtm

build timeout waiting for noop-example workflow to complete...2/3 nodes completed.
test this please

@tannoa2 spoke with @benbp; seems this test is exposing the same random persistent status issue.  The on-taskgraph refactoring effort should resolve those types of behaviors.  Trying to reproduce with the Graph.Discovery test since that also checks the workflow status.

@benbp this is really a non-issue if we're checking the status out of the AMQP message body right?

+1

@RackHD/corecommitters @keedya @uppalk1 @zyoung51 @tannoa2

+1


yahmm Model can't be pickled

IPython QtConsole 3.1.0
Python 2.7.9 |Anaconda 2.1.0 (64-bit)| (default, Mar  9 2015, 16:20:48)
Type "copyright", "credits" or "license" for more information.

IPython 3.1.0 -- An enhanced Interactive Python.
Anaconda is brought to you by Continuum Analytics.

In [1]: import cPickle as pickle

In [2]: import yahmm as ym

In [3]: m=ym.Model()

In [4]: m.bake()

In [5]: m
Out[5]: <yahmm.yahmm.Model at 0xd8df30>

In [6]: pickle.dump(m,open("ttt.p","wb"))

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-6-a10217961e3f> in <module>()
----> 1 pickle.dump(m,open("ttt.p","wb"))

/opt/Anaconda/lib/python2.7/copy_reg.pyc in _reduce_ex(self, proto)
     68     else:
     69         if base is self.__class__:
---> 70             raise TypeError, "can't pickle %s objects" % base.__name__
     71         state = base(self)
     72     args = (self.__class__, base, state)

TypeError: can't pickle Model objects

My understanding is that cdef classes can not be automatically pickled by pickle. This can apparently be solved by adding the appropriate __reduce__() function to the class. So perhaps this issue should be labeled as an enhancement request.

Hi shpigi
I am not adding any more functionality to HMMs in the YAHMM project, just fixing major bugs. I have merged yahmm with my larger pomegranate project as I am using different graphical models in my research now.
However, if you do not have any tied distributions or edges in your model you should be able to use model.write and model.read in order to save your models to an external source. In YAHMM this is a tsv text file, in pomegranate tied emissions/edges are handled and the output is a JSON.
If you'd like to transition your code from YAHMM to pomegranate, all you need to do after pip install pomegranate (assuming a successful install) is to replace from yahmm import * with from pomegranate import HiddenMarkovModel as Model.
Sorry for the inconvenience, let me know if the reading/writing scheme works for you.

Switching to pomegranate !
Way to go !
Thanks.


Project Dates/Hours - not saving correctly

The project Dates and Times are not saving correctly in Production.  When updating the project dates under "Project Rodin - Roof" to 9/24 to 9/26, it appears to save.  I can switch tabs (work Items, Cost Summary) and the new dates display correctly when returning to the Info tab.  But after refreshing the screen or returning to the Projects main view, they would change back and/or have different hour start/end times.

Date and time seemed to change on their own when I tested it. Other changes in Planning and Wrap

Up seemed to behave as expected.

I correct the project controller, but the issue was that when you wanted to set the date for a certain month, the server would use the previous month.
For the planning and wrap-up tab, I was unable to reproduce the bug. Does this happen for any application?

I pulled your changes into develop-2020-aug and tested them on http://<IP_ADDRESS>/. I think you are on the right track, Andy, but there is still something going on with the time. When a change is made it seems to count back 7 hours. I didn't really notice this changing days. Sometimes when I changed a day and refreshed the date changed and sometimes it didn't. Then I noticed the time change. The date changes when the time counts back 7 hours from 6am or earlier. Here are the screen captures where I changed the time, then clicked the page refresh button. This same behavior happens with the Start Date and End Date.

Also, it was only the date saving that I saw issues with. I changed items in Planning, Partner and WrapUp tabs and everything looked like it saved OK, so once we have the date issue fixed I think we can close this Issue.

Thinking about this more the obvious finally hit me. The date and time entered is read and saved as GMT while the date and time retrieved and displayed is PDT (GMT -7 hours). Somewhere between the new entry and saving process there is a mismatch in time zones. Because the date and time doesn't change after refresh without any updates, it appears that once the date is saved the time zones are OK on the read or pull transaction to retrieve the date & time.

Hi Guys,
Sorry for the delay. I noticed the bug when I made the changes for the month. It seems my local server is set up differently so I didn't have the error locally. I believe I should have corrected it in the recent #297 by using the entire string instead. I didn't know that JS could do that, but it should also be a better approach for the months as well since it doesn't converting the date anymore.
Hopefully, I didn't introduce any bugs.

I tested it quickly in the Assessments tab and the Projects tab. Looks like the fix works!


Unit Test commit

Unit test cases created with PynGuin. Details will be provided soon.

It's ridiculous, this project don't even use redis_queue.


MimeTypes dictionary has duplicate keys

The MimeTypes dictionary in HtmlWeb contains 100's of duplicate file extensions.
E.g.
_mimeTypes.Add(".aif", "audio/aiff");
_mimeTypes.Add(".aif", "audio/x-aiff");

So only the last mime type of each duplicate file extension is saved as all previous are overwritten.

Hello @jnyrup ,
In fact, that's worse than this.
A duplicate key cannot exist so the first duplicate line threw an error.
We will look at it to check what's the best way to fix it.
Best Regards,
Jonathan

Help us to support this library: Donate

Hello @jnyrup  ,
The v1.6.10 has been released.
After review, we took the decision to comment all this code. This part of the code has never worked which mean probably no one currently uses it.
Currently, we prefer to concentrate our effort on feature people currently use.
Best Regards,
Jonathan

Help us to support this library: Donate

Sounds like a good choice


Update Tideways version and debian repo

PR Description
Hey Folks,
Volker from Tideways with a small PR to update our Repository for Debian packages.
We changed our Repo from AWS to Cloudsmith and our own domain. The old one is still available for a while so there is no rush or anything, we just wanted to reach up and get this updated :)
You can validate that this is the new Tideways repository at https://tideways.com/profiler/downloads where it's also listed and in case of doubt feel free to reach out to<EMAIL_ADDRESS>for validation.
Thank you!
Checklist

[x] I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Is there something I can do to help move this forward / get this merged?
If it's still waiting for your QA and all is good: Sorry for the ping, but thought I ask :)

Is there something I can do to help move this forward / get this merged?
If it's still waiting for your QA and all is good: Sorry for the ping, but thought I ask :)

Hey @edorian,
No, thanks you already did an excellent work.
It's in our QA queue and waiting for QA. As soon as it will be finished, we are ready to go.

Hey @edorian, small updates from our side.
Unfortunately, during the QA we faced some error just for PHP 8.1.
We are trying to figure out the root cause.
PHP Warning:  PHP Startup: Unable to load dynamic library 'tideways.so' (tried: /usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so (/usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so: cannot open shared object file: No such file or directory), /usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so.so (/usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
We are on the investigation stage.

Thanks for letting me know @alexanderM91
Running docker build -t baz -f debian/bullseye/8.1/Dockerfile . seems to work for me
 ✓ $ docker run --rm -it baz php -v
PHP 8.1.8 (cli) (built: Aug  2 2022 07:20:57) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.8, Copyright (c), by Zend Technologies

 ✓ $ docker run --rm -it baz php -m | grep tideways
tideways

Also testing the php-fpm
root@92ba8cc7d659:/data# SCRIPT_NAME=/fpm-ping.php SCRIPT_FILENAME=/fpm-ping.php REQUEST_METHOD=GET cgi-fcgi -bind -connect <IP_ADDRESS>:9000
Content-type: text/plain;charset=UTF-8
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Cache-Control: no-cache, no-store, must-revalidate, max-age=0

OK

So did
echo "<?php phpinfo(); " > /var/www/html/index.php

SCRIPT_NAME=/ SCRIPT_FILENAME=/var/www/html/index.php DOCUMENT_ROOT=/var/www/html/ REQUEST_METHOD=GET cgi-fcgi -bind -connect <IP_ADDRESS>:9000

which is also loading the config from /usr/local/etc/php/conf.d/tideways.ini.
Sorry I can't be more helpful here but from what I can test things seem to be working.
The extension dir PHP-FPM uses seems to be set correct and the tideways file is correctly linked here by our installer:
root@92ba8cc7d659:/data# SCRIPT_NAME=/ SCRIPT_FILENAME=/var/www/html/index.php DOCUMENT_ROOT=/var/www/html/ REQUEST_METHOD=GET cgi-fcgi -bind -connect <IP_ADDRESS>:9000 | grep extension

extension_dir	/usr/local/lib/php/extensions/no-debug-non-zts-20210902	/usr/local/lib/php/extensions/no-debug-non-zts-20210902

root@92ba8cc7d659:/data# ls -lash /usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so
0 lrwxrwxrwx 1 root root 37 Oct 24 16:50 /usr/local/lib/php/extensions/no-debug-non-zts-20210902/tideways.so -> /usr/lib/tideways/tideways-php-8.1.so

If you think I could help feel free to point me to a container/reproduce. Otherwise no worries; there is no rush from our side :)

Hi @edorian,
with the current image we came across with another issue - Tideways extension cannot be loaded properly.

We did some adjustments for the current PR. You can find them in the attached one.
Thank you.

Curious, as I couldn't reproduce the issue with the Dockerfiles in this branch.
While this is a non recommended install method for Debian systems it also works and when using direct downloads the URLs are also fine :)
So I guess you can close this then :)
I'd be happy to look into the installation issue and fix it if you could provide me with reproduce commands. But that's fully optional of course.

@kalaputsik, could you please provide command which will help to reproduce a command?
Thank you

Hi @edorian,
you can test your image via command
$ docker run -i --rm {image_name} bash -s<<'EOF'
    docker-php-source extract
    echo "Installed extensions";
    echo "====================";
    for ext in `ls /usr/src/php/ext`; do echo ' ' `php -r "if (extension_loaded('$ext' !== 'opcache' ? '$ext' : 'Zend OPcache')) { echo '[x] $ext'; } else { echo '[ ] $ext'; }"`; done
    echo "";
    echo "Disabled extensions";
    echo "====================";
    for f in /usr/local/etc/php/disabled/*.ini; do disabled=$(basename $f | sed -e 's/\.ini$//'); echo " [ ] ${disabled} $(PHP_INI_SCAN_DIR=:/usr/local/etc/php/disabled php -r "echo phpversion('${disabled}');")"; done
    echo "";
    pear list -c pecl
    echo "";
    echo "Composer";
    echo "====================";
    composer -V
EOF```

I see, thank you for the reproduce. That makes sense. The tideways installer puts the .ini file in a folder that is scanned and then another folder with the same file is added.
php --ini in that moment shows me both
/usr/local/etc/php/conf.d/tideways.ini,
/usr/local/etc/php/disabled/tideways.ini

being loaded.
Thank you for letting me know. It's good to confirm that is not an issue with our installer :)
As you are setting this up another way i'd say it makes sense to close this PR then :)

Hey, close the PR as the changes already in master branch.
Thanks a lot for your contribution and problems solving support.
Have a great evening.


Files gone after restart

Expected behavior
I installed Docker Toolbox on Windows 10 Pro and am using VirtualBox.  I installed the official Redmine Docker and using the CLI I ran:
docker run -it -v //c/Users/tholzer/docker://data:rw redmine bash
I then copied files from /data to /usr/src/redmine/public/themes
Then, after restart the files are gone.
Not sure why it keeps resetting the instance.
Actual behavior
Files are deleted instead of retained,
Information about the Issue
Steps to reproduce the behavior

see above

How do you restart? Are you sure that redmine doesn't have a process that touches that particular location?
Also this looks like a CLI command, not something done via Kitematic. Please open it in the appropriate repo docker/for-win


[SPARK-31577][SQL] Fix various problems when check name conflicts of CTE relations

What changes were proposed in this pull request?

This is a followup of https://github.com/apache/spark/pull/28318, to make the code more readable, by adding some comments to explain the trick and simplify the code to use a boolean flag instead of 2 string sets.
This PR also fixes various problems:

the name check should consider case sensitivity
forward name conflicts like with t as (with t2 as ...), t2 as ... is not a real conflict and we shouldn't fail.

Why are the changes needed?

correct the behavior
Does this PR introduce any user-facing change?

yes, fix the fore-mentioned behaviors.
How was this patch tested?

new tests

cc @peter-toth @xuanyuanking @dongjoon-hyun

Test build #121904 has started for PR 28371 at commit dd6cec5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26574/
Test PASSed.

Test build #121906 has started for PR 28371 at commit c4d0a69.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26576/
Test PASSed.

That flag is a nice trick so LGTM, I just left a minor note.
The other 2 fixes also look good.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26590/
Test PASSed.

Test build #121920 has started for PR 28371 at commit 24a487d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26591/
Test PASSed.

Thank you so much, @cloud-fan .

Test build #121904 has finished for PR 28371 at commit dd6cec5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121904/
Test FAILed.

Test build #121906 has finished for PR 28371 at commit c4d0a69.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121906/
Test PASSed.

Test build #121920 has finished for PR 28371 at commit 24a487d.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121920/
Test FAILed.

All Scala/Java/Python test passed, but it's timeouted R testing.
I ran the R UT manually.
══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 13 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 0 ]
✔ |  OK F W S | Context
✔ |  11       | binary functions [1.5 s]
✔ |   4       | functions on binary files [1.3 s]
✔ |   2       | broadcast variables [0.3 s]
✔ |   5       | functions in client.R
✔ |  46       | test functions in sparkR.R [4.4 s]
✔ |   2       | include R packages [0.2 s]
✔ |   2       | JVM API [0.1 s]
✔ |  75       | MLlib classification algorithms, except for tree-based algorithms [55.2 s]
✔ |  70       | MLlib clustering algorithms [23.8 s]
✔ |   6       | MLlib frequent pattern mining [1.8 s]
✔ |   8       | MLlib recommendation algorithms [4.6 s]
✔ | 136       | MLlib regression algorithms, except for tree-based algorithms [50.6 s]
✔ |   8       | MLlib statistics algorithms [0.4 s]
✔ |  94       | MLlib tree-based algorithms [40.7 s]
✔ |  29       | parallelize() and collect() [0.4 s]
✔ | 428       | basic RDD functions [15.0 s]
✔ |  39       | SerDe functionality [2.2 s]
✔ |  20       | partitionBy, groupByKey, reduceByKey etc. [2.1 s]
✔ |   4       | functions in sparkR.R
✔ |  16       | SparkSQL Arrow optimization [10.5 s]
✔ |   6       | test show SparkDataFrame when eager execution is enabled. [0.7 s]
✔ | 1177       | SparkSQL functions [106.5 s]
✔ |  42       | Structured Streaming [53.8 s]
✔ |  16       | tests RDD function take() [0.5 s]
✔ |  14       | the textFile() function [1.3 s]
✔ |  46       | functions in utils.R [0.3 s]
✔ |   0     1 | Windows-specific tests
────────────────────────────────────────────────────────────────────────────────
test_Windows.R:22: skip: sparkJars tag in SparkContext
Reason: This test is only for Windows, skipped
────────────────────────────────────────────────────────────────────────────────

══ Results ═════════════════════════════════════════════════════════════════════
Duration: 378.6 s

OK:       2306
Failed:   0
Warnings: 0
Skipped:  1

Thank you so much for this fix, @cloud-fan and @peter-toth .
Merged to master/3.0.


Unable to create pipe "\.\pipe\chrome.24676.0.173299390" in client mode: The system cannot find the file specified. (0x2)

Fresh install on windows 8. When I run mapbox-studio.exe I get:
C:\Program Files\mapbox-studio>[24676:0215/001629:INFO:CONSOLE(0)] <Sun, 15 Feb
2015 06:16:29 GMT> Mapbox Studio exited with<PHONE_NUMBER>.
[23504:0215/001629:WARNING:ipc_channel_win.cc(309)] Unable to create pipe "\.\p
ipe\chrome.24676.0.173299390" in client mode: The system cannot find the file sp
ecified. (0x2)

@JayDouglass
I had the same problem today
It occurred after installing Visual Studio 2015 CTP6.
CTP 6 seems to seriously mess up the system as I'm also not able to compile some software now.
Did you install some new software recently?
Could you try the following to see, if we get additional error messages?

Open command prompt

Windows Key + r
type cmd, press Enter

type cd "c:\Program Files\mapbox-studio\resources\app", press Enter
type vendor\node index.js, press Enter

Do you get any error messages, dialog boxes or anything else?
If it seems successful, open your browser at http://localhost:3000.
What do you see?

@JayDouglass
I verified with a vanilla Windows install that Visual Studio 2015 CTP 6 causes Mapbox Studio to stop working.
Even uninstalling CTP 6 and re-installing Mapbox Studio didn't solve this for me.

I have Visual Studio community edition installed on that machine, so it looks like it's related to any Visual Studio install.

@JayDouglass Can you elaborate on which version of Visual Studio exactly?
For me, the problems just started after installing VS 2015 CTP 6.
If you are not sure about which version you have, you could post a screen shot of the dialog that comes up, when you click: Help -> About Microsoft Visual Studio.

I've had a two different versions of Visual Studio installed on that machine. VS2013 Professional, and currently VS2013 Community (http://www.visualstudio.com/en-us/news/vs2013-community-vs.aspx).

@JayDouglass
I haven't experienced any problems with VS 2008, 2010, 2012, 2013 and 2015 CTP2 to CTP5.
It just seems that the latest VS2015 CTP6 is causing troubles and changing the operating system in undocumented ways.
So you are on the safe side concerning VS.
Could you try the following steps to see, to see if we get additional error messages?

Open command prompt

Windows Key + r
type cmd, press Enter

type cd "c:\Program Files\mapbox-studio\resources\app", press Enter
type vendor\node index.js, press Enter

Do you get any error messages, dialog boxes or anything else?
If it seems successful, open your browser at http://localhost:3000.
What do you see?

@JayDouglass
Another thing to try, could you look into Control Panel -> Add/Remove Programs and see if you have one or several
Microsoft Visual C++ 2015 CTP Redistributable

entries?
Like this:

If yes, please try these steps:

take a screenshot of the entries (I'm primarily interested in the version number, e.g. 14.0.22512 in my screenhsot
un-install all those entries
re-install Mapbox Studio

Does it work now?

Same problem here:
Win 8.1 clean install
VS CTP 5 and then update to
VS CTP 6 (RC)
Diagnose:
1. running vendor/node index.js causes this exception message box:
node.exe - System Error
The program can't start because APPCRT140.dll is missing from your computer. Try reinstalling the program to fix this problem.
2. I have these 2 entries:

version number is 14.0.22816.0

@urbanhop

then update to VS CTP 6 (RC)

Did you update to CTP 6 or RC?
RC is the lastest at the moment.
Problem is, that our provided binaries are still being built with VS2014 CTP4, requiring an install of VS2014 CTP4 or the CTP4 vcredist.
As there is no stable release of VS2015 yet, an install of a newer version, e.g. VS2015 RC1, automatically removes all previously installed 2014/2015 vcredists in the background, thus rendering our provided binaries unusable.
Right now I'm in the process of bringing everything to VS2015 RC, but it might still take some time as there are quite some dependencies to take care of.
The only solution at the moment would be to remove everything newer than CTP4 and install CTP4 vcredist.
Be warned tough, that VS2014 CTP4 has already expired and the VS IDE cannot be used anymore.
The command line tools (that's what we use) still work.

Sorry, I am on RC now, so I guess it was:
Win 8.1 clean install
VS CTP 5 (maybe, not sure)
VS CTP 6
VS RC)
Got Mapbox running in a Hyper-V machine and will wait until things stabilize. Visual C++ libraries at the time of new releases are a hassle, for me you dont need to hurry fixing this issue.
Btw, find it cool to use an electron based application, looks and feels good.

@urbanhop
great that you have the option to use a Hyper-V machine.
Microsoft provided us with quite a bumpy ride going through all those CTPs.
Hope that things have stabilized with the RC and that RTM will not provide new challenges.

Applies to current version 0.2.7 of Mapbox Studio
Upcoming releases won't have this problem
Problem: an install of Visual Studio 2015 messes with the c++ runtime needed by Mapbox Studio.
Solution:
1.) download
https://mapbox.s3.amazonaws.com/windows-builds/visual-studio-runtimes/vcredist-VS2014-CTP4/vcredist_x64-mini.7z
2.) extract vcredist_x64-mini.7z into
C:\Program Files\mapbox-studio\resources\app\vendor
3.) extract vcredist_x64-mini.7z into
C:\Program Files\mapbox-studio\resources\app\node_modules\mapnik\lib\binding\node-v11-win32-x64

Wow, unlucky me. Just installed vs community followed by mapbox-studio. Really wish it threw the error with a proper warning (It simply closed on start) Running the exe through commandline gave the pipe error (which landed me at this page) and then the .dll error after following your guide. Hope the new version is released soon.

@small-mallet great this solved it for you.
VS2015 unfortunately breaks the Mapbox Studio install.
Working on the new release with full steam.

Same here, also resolved by copying the DLLs. Leaving this comment in a hope that this issue ranks higher up on search engines. When starting Mapbox, window disappears immediately.


Plugin documentation page is 404

I was looking for documentation for using webpack in v6.

https://github.com/nozzle/react-static/blob/master/docs/config.md#webpack --> Points to config docs.

https://github.com/nozzle/react-static/blob/master/docs/config.md#webpack --> Points to plugin API section

https://github.com/nozzle/react-static/blob/master/docs/config.md#plugin-api --> Points to API documentation link

https://github.com/nozzle/react-static/blob/master/docs/plugins.md - 404

Was the documentation moved? I'm trying to migrate a current project to v6.

Or was converted into a directory. It should be
https://github.com/nozzle/react-static/blob/master/docs/plugins/ or
https://github.com/nozzle/react-static/blob/master/docs/plugins/README.md
On Mon, Dec 24, 2018 at 10:13 PM cmontgomerymt<EMAIL_ADDRESS>wrote:

I was looking for documentation for using webpack in v6.

https://github.com/nozzle/react-static/blob/master/docs/config.md#webpack
--> This page links to config docs.
2.
https://github.com/nozzle/react-static/blob/master/docs/config.md#webpack
--> This page links to plugin API section
3.
https://github.com/nozzle/react-static/blob/master/docs/config.md#plugin-api
--> Points to API documentation link
4.
https://github.com/nozzle/react-static/blob/master/docs/plugins.md -
404
Was the documentation moved? I'm trying to migrate a current project to v6.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/920, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCZXKKapWvt-RKqWX0tn0IpCgV6HXks5u8bPqgaJpZM4Zg0iE
.

Please PR any updates to documentation you find! 👍

Thanks.