Update bluetooth article

Mention bluetooth-internals page
Add Bluetooth Descriptors section
Updated implementation status page URL

Does that look good you @scheib @g-ortuno?

Thank you @jpmedley for your feedback. I've addressed it at https://github.com/google/WebFundamentals/pull/4490/commits/782a607b61e37db54877fe8ca53bfd75ce74f9a5
Since article has 34 warnings about "Line must be at most 100 characters", I wish we simply merge it as it doesn't add value there and will mostly clutter Git history. Let me know if that looks good to you.

@beaufortfrancois Regarding the warnings, actually collapse the history when we do the merge, so it won't clutter. In the future, please try to address at least some of them. FYI, if you do 80 characters instead of 100 ahead of submitting the PR, you get enough space to handle 97% of the copy edits without having to redo the line breaks.
Merging for now.


[queue] Add option to drop oldest metrics from the queue

This PR addresses #37 and adds the option to drop the oldest metrics from the queue, and makes it the default drop strategy.
cc @xichen2020

Coverage decreased (-2.5%) to 91.504% when pulling a968fb3195fbb7f23e679cfa69b7cb1f9c2c147a on jeromefroe/queue/add-option-to-drop-oldest-metrics-from-queue into bb37dad9181f4f3f4ad7a45b47f8ae8de5bf7213 on master.

Coverage decreased (-1.0%) to 93.073% when pulling 624e8e0586312cdc618cb4497ac93ed877d239ab on jeromefroe/queue/add-option-to-drop-oldest-metrics-from-queue into bb37dad9181f4f3f4ad7a45b47f8ae8de5bf7213 on master.

Coverage decreased (-1.0%) to 93.053% when pulling 92ee5a247408e51812b249ce27bf274ee71d49cc on jeromefroe/queue/add-option-to-drop-oldest-metrics-from-queue into bb37dad9181f4f3f4ad7a45b47f8ae8de5bf7213 on master.

Coverage decreased (-1.2%) to 92.857% when pulling 92ee5a247408e51812b249ce27bf274ee71d49cc on jeromefroe/queue/add-option-to-drop-oldest-metrics-from-queue into bb37dad9181f4f3f4ad7a45b47f8ae8de5bf7213 on master.


Switch to well known types in google-protobuf package

Once either the google-protobuf or grpc packages contain the well-known types, we don't need to keep them checked-in under lib any more.

These are now available via the grpc-tools package. See the killrvideo-generator project for a script to copy them during the build.


Failing test case for feature branch name with a number

This is just a test to reproduce my issue with feature branches based on
the jira key e.g. feature/JIRA-123-a-description.
I'm not sure what a valid assert should look like, I have 3 examples I could live with, but the current output is broken from my point of view. What do you think would be a valid assert for this case?

Closing, lets continue discussion at #337


SASS on Mac OSX Lion broken

Just updated our systems to Mac OSX Lion. We typically ask SASS to watch an entire directory for changes, like this:
$ sass --watch app/sass:public/stylesheets

However, after updating to Mac OSX Lion, when SASS detects a change to one of our sass files, and attempts to rebuild the destination css file, we receive the following error:
/Library/Ruby/Gems/1.8/gems/sass-3.1.2/vendor/fssm/lib/fssm/backends/fsevents.rb:27: [BUG] Segmentation fault
ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin11.0]

Abort trap: 6

Same problem here on Lion. I'd be pretty interested in finding a resolution to this.

@Schermy This should be fixed by now. What version of Sass are you using?

I'm currently running 3.0.25 using rvm.


1.2.0

Resolves
#55, #54, #53, #52, #51, #40
Updates

Renames BackgroundImg to BackgroundImage
Renames Img to Image
Adds top and bottom caps on Menu
Removes props on MenuButton. It now has same optional props as Button. (#53)
Renames Disclosure to DisclosureBox
DisclosureBox now does not use Reach UI
Adds cursor prop
Adds /examples
Resolves non-DOM properties being forwarded to DOM (#51)
Resolves cases where React typings overlapped with incompatible styled-system properties of the same name
Adds DEVELOPMENT.md with component reference patterns
CSS Reset is now a component called Reset, instead of a string
Generally expands prop options on components
New Components: Action, AspectRatio, BaseForm, BaseAnchor, BaseButton (#54), BaseCode, BaseImage, BaseInput, BaseLabel, BaseSVG, BaseTextArea, Checkbox, RadioButton, Indicator (used internally), ToggleSwitch, ErrorLabel, Inline, ManagedCheckboxField, ManagedForm, FormController, ManagedRadioButtonField, ManagedTextInputField, ManagedToggleSwitchField, Reset, StatelessCheckboxField, StatelessTextArea, StatelessTextInput and StatelessToggleSwitchField
New Icons: Smiley, Heart, XSmall, PlusSmall, Weather, Clock, Chat, Links, Publish, Groups, Gear, LeapArrow, Home, TrashCan

Removals

Removes text editor components for the time being
Removes SideBar, ColumnView, SideBarButton as they are unused and underdeveloped
Removes Layout as it is unused.
Removes Tabs for the time being as they are unused

@liam-fitzgerald Things to change in settings and Publish refactor PRs here.


lis3dh driver support is confusing

Describe the bug
The ST lis3dh sensor device does appear to be supported but using the lis2dh driver, however the way it's been implemented is incredibly confusing and has wasted about an hour of my time this morning trying to figure it out, I'm not the only person that finds this confusing as noted in the original change https://github.com/zephyrproject-rtos/zephyr/pull/12373
The issue is that the lis2dh driver can be used for multiple devices, but there is a lis3dh driver binding which falls flat with the following build message:
zephyr/drivers/sensor/lis2dh/lis2dh.c:353:2: warning: #warning "LIS2DH driver enabled without any devices" [-Wcpp]
  353 | #warning "LIS2DH driver enabled without any devices"
      |  ^~~~~~~

To get it to work, you must change to the lis2dh binding, my personal opinion is that this is annoying and bad, the lis3dh binding should be enough for the driver to work with it.
I haven't tested the other boards but I can see 96b_wistrio and rak5010_nrf52840 both only specify lis3dh bindings so I assume those actually do not work either.
To Reproduce
Steps to reproduce the behavior:

Configure a board with an lis3dh using:
lis3dh@18 {
compatible = "st,lis3dh";
label = "LIS3DH";
reg = <0x18>;
};

Configure any project to use board and LIS2DH sensor

Build, it will output an error about no lis2dh sensors being present

Change DTS line:
compatible = "st,lis2dh";

Rebuild, error vanishes and device communication works

Expected behavior
The sensor to work out the box with the lis3dh binding
Impact
Annoyance
Environment (please complete the following information):

OS: Windows 7
Toolchain: GNU GCC from ARM (version 9.3.1, 2020 Q2 update)
Commit SHA or Version used: f4a26837c8cb6d39f3307193068c3163b20ac584

As long as there's a separate binding for st,lis3dh that's supposed to be supported by the lis2dh driver, I think that driver should iterate over lis3dh devices as well as lis2dh ones.  That would require repeating the generation loop with #define DT_DRV_COMPAT st_lis3dh in scope, assuming that you don't get two binding defines for the same device when the compatible is:
compatible = "st,lis3dh", "st,lis2dh";

which is the way to solve this if lis3dh doesn't have any significant differences in binding content.  In that case just delete the st,lis3dh binding and convert the in-tree devicetree files to use the above compatible, which makes clear the real device but that it's compatible with the one we have a driver for.

As long as there's a separate binding for st,lis3dh that's supposed to be supported by the lis2dh driver, I think that driver should iterate over lis3dh devices as well as lis2dh ones.  That would require repeating the generation loop with #define DT_DRV_COMPAT st_lis3dh in scope, assuming that you don't get two binding defines for the same device when the compatible is:
compatible = "st,lis3dh", "st,lis2dh";

which is the way to solve this if lis3dh doesn't have any significant differences in binding content.  In that case just delete the st,lis3dh binding and convert the in-tree devicetree files to use the above compatible, which makes clear the real device but that it's compatible with the one we have a driver for.

As long as there's a separate binding for st,lis3dh that's supposed to be supported by the lis2dh driver, I think that driver should iterate over lis3dh devices as well as lis2dh ones. That would require repeating the generation loop with #define DT_DRV_COMPAT st_lis3dh in scope, assuming that you don't get two binding defines for the same device when the compatible is:
compatible = "st,lis3dh", "st,lis2dh";

which is the way to solve this if lis3dh doesn't have any significant differences in binding content. In that case just delete the st,lis3dh binding and convert the in-tree devicetree files to use the above compatible, which makes clear the real device but that it's compatible with the one we have a driver for.

Yes, this is the way it is expected to be done in DTS :
compatible = "st,lis3dh", "st,lis2dh";:
The LIS2DH and LIS3DH are register compatible. So same driver should work fine.

As long as there's a separate binding for st,lis3dh that's supposed to be supported by the lis2dh driver, I think that driver should iterate over lis3dh devices as well as lis2dh ones. That would require repeating the generation loop with #define DT_DRV_COMPAT st_lis3dh in scope, assuming that you don't get two binding defines for the same device when the compatible is:
compatible = "st,lis3dh", "st,lis2dh";

which is the way to solve this if lis3dh doesn't have any significant differences in binding content. In that case just delete the st,lis3dh binding and convert the in-tree devicetree files to use the above compatible, which makes clear the real device but that it's compatible with the one we have a driver for.

Yes, this is the way it is expected to be done in DTS :
compatible = "st,lis3dh", "st,lis2dh";:
The LIS2DH and LIS3DH are register compatible. So same driver should work fine.

I'm planning to review this driver using STMEMSC i/f. Not sure exacvtly whether it makes sense to reuse same driver for all register compatible devices (lis2dh/lis3dh/lis2dh12/...) or create separate ones.

I'm currently testing this with the LIS2DE12 sensor for a project we have in Herald. I'll let you know how I progress.

I have confirmed the LIS2DH driver works with the LIS2DE12 sensor also. Sample app and custom board definition for our device (currently actually a nRF52833DK until our hardware is produced) can be found here: https://github.com/theheraldproject/zephyr-devices. Having ran the sample and manually checking the lis2dh.h settings with the LIS2DE12 datasheet, they are clearly compatible. My next task is adding double tap detection which I cannot currently see in the LIS2DH driver... Hopefully it's a relatively simple thing for me to add...
I've noticed that even copying the sample's config for floating point print support that it does not work. I've worked around that in my main.c.
Our code is here: https://github.com/theheraldproject/zephyr-devices

@thedjnK as per the comments posted in this issue, do you think it can be closed?


Issue template and feature template

not needed since the project is not large enough to justify using these features. i'll think about it though


fix(kselect): arrow down navigation [KHCP-12967]

Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-12967
Adds arrow up and down navigation through items in KSelect

@aanchalm01 Does this PR also introduce selecting items via keyboard? So once I use the up and down arrow keys to navigate to an item, can I press Enter or Space to select it?

https://deploy-preview-2358--kongponents-sandbox.netlify.app

Yes, selecting an item via keyboard is now supported (that was introduced in PR that was merged earlier last week).


Cannot Reproduce quality of pretrained model

I have trained a stylespeech model use LibriTTS, but the quality was far worse than pretrain stylespeech model of author. I use default config and parameter and train the model within 100k step. The loss like bellow:

I also upload my audio sample of the text same as demo page in folder Train_LibriTTS_StyleSpeech in attached fille. There are always strange sounds at the end of each audio file, i can't explain that.
meta_stylespeech_results.zip

I think you should train the model on more steps. In my experiments, the mel loss decreased to 0.22~0.23.

I think you should train the model on more steps. In my experiments, the mel loss decreased to 0.22~0.23.

Thanks, I will continue training to 400k step and show the results.

I Found that, the problem come from Montreal Forced Aligner version 2.0.0a22 or newer version, which do not put “sp” or “sil” in the phone tier. To fix this, just add "--disable_textgrid_cleanup" flag during alignment step.

Oh. Thanks for finding the problem! I should update the repo to match with libraries of the newer versions.

@chazo1994 : Even if ['sp', 'sil'] are put in the phones tier, they are anyways ignored in the get_alignment function in preprocessors/utils.py - so if it is there or not shouldn't matter?


docs: create doc site

Overview
Sets up a docsite via storybook which will automatically deploy on push to main.
An example of what this deploys can be seen at https://awslabs.github.io/iot-app-kit/?path=/docs/components-line-chart--docs

Add more testing related utils
⚠ temporarily remove VideoPlayer from being exported from react components due to it breaking the build for the doc-site. Issue added https://github.com/awslabs/iot-app-kit/issues/775 to track this.

Legal
This project is available under the Apache 2.0 License.

What's the state of this PR?

What's the state of this PR?

The PR would be good to merge with the exception of storybook failing to build when VideoPlayer is exported from react-components due to video.js overriding global.window. see https://github.com/videojs/video.js/issues/5680

Do we good with doing that? Or should this PR be set as a draft until the change is made?

Are we good with doing that? Or should this PR be set as a draft until the change is made?

No - marked as draft


feat: add check step to latest release

Fixes: https://github.com/envoyproxy/gateway/issues/888
Signed-off-by: bitliu<EMAIL_ADDRESS>

Codecov Report

Merging #895 (92b3bd2) into main (15fb1a5) will decrease coverage by 0.09%.
The diff coverage is n/a.

:exclamation: Current head 92b3bd2 differs from pull request most recent head 20dbc44. Consider uploading reports for the commit 20dbc44 to get more accurate results

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   63.54%   63.44%   -0.10%
==========================================
  Files          53       53
  Lines        7485     7485
==========================================
- Hits         4756     4749       -7
- Misses       2434     2438       +4
- Partials      295      298       +3

Impacted Files
Coverage Δ

internal/provider/kubernetes/helpers.go
75.40% <0.00%> (-4.92%)
:arrow_down:

internal/provider/kubernetes/controller.go
47.12% <0.00%> (-0.13%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Lookup table for rice coding

Implement a LUT for rice coding to speed up encoding and decoding

Due to variable rice parameters probably not very feasible


Update action.yml

Actually there is a more general strategy needed, i.e. that one can select the Shopware versions. I will merge that for now, but would not advise to use this action :)
https://github.com/aragon999/phpstan-shopware-docker/blob/master/action.yml#L7-L11


Normalize track lengths with gaps before flatten stacks

This PR fixes #1430
I added a _normalize_tracks_lengths function that adds gap items to the end of tracks that are shorter before the flattening happens.

Codecov Report
Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (013fe04) 79.83% compared to head (54374b4) 79.76%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   79.83%   79.76%   -0.08%
==========================================
  Files         197      197
  Lines       21814    21846      +32
  Branches     4362     4380      +18
==========================================
+ Hits        17416    17425       +9
- Misses       2233     2246      +13
- Partials     2165     2175      +10

Flag
Coverage Δ

py-unittests
79.76% <30.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

src/opentimelineio/stackAlgorithm.cpp
28.71% <30.00%> (+0.54%)
:arrow_up:

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013fe04...54374b4. Read the comment docs.

I think I addressed your notes. please take a look when you get a chance :)


Apanova - Logo is missing

ENVIROMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Chrome
Device: laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open URL in browser
Type the name of the company in the search bar

EXPECTED RESULT:
We can see the logo.
ACTUAL RESULT:
The logo is missing.

apnoea s-a schimbat în apanovabucuresti

It work!


Unexport GPIO on Pin closing

Hi @brian-armstrong,
I made this little PR to fix the gpio.Close() method, ensuring Pin is unexported when we close it.

Does this look like it will be merged?


Too many build errors

Please be sure to include:

what OS you are developing on (Linux or macOS, including the version)
Mac OS 10.13

for macOS, what version of Xcode you are using (xcodebuild -version),
for Linux, what version of Swift (swift --version)

xcodebuild -version
Xcode 9.0.1
Build version 9A1004
Also happening on Xcode 8.3.3

what version of Swift is your code set to compile with (i.e. from project
settings, etc.)
Xcode 9.0.1

what branch/tag of SwiftProtobuf you are using (1.0.0, etc.)
/// Protobuf-swift version: 3.0.22

if you are getting compile errors, please be sure include all errors/warnings,
sometimes the error before the one you are stuck on is important.
/// Generated by the Protocol Buffers 3.4.0 compiler.  DO NOT EDIT!
/// Protobuf-swift version: 3.0.22
/// Syntax "Proto3"

import Foundation
import ProtocolBuffers
No such module 'ProtocolBuffers' in XX.proto.swift
Use of undeclared type 'Ee_Depcloudmdmservice_Service_DefineProfileRequest' >> Around 58 errors
XX.service.client.pb.swift
XX.service.server.pb.swift

lastly, if it all possible, provide a snippet of .proto and/or source
that shows the problem.

I do not see any structs created. Please help us to understand what are we missing here.
Thank you!

We just did a 1.0 release (https://github.com/apple/swift-protobuf/releases), so the fact that you say you have Protobuf-swift version: 3.0.22 seems to imply you are using a different project for your protobuf support.

You should file this with https://github.com/alexeyxo/protobuf-swift which is entirely unrelated.

Thanks for your response!
My bad we intend to use Resolving https://github.com/apple/swift-protobuf.git at 0.9.903
Also I am curious if "import ProtocolBuffers" is internally called by swift-grpc or swift-protobuf? I do not have a copy of this locally.

... we intend to use Resolving https://github.com/apple/swift-protobuf.git at 0.9.903

You should use 1.0.0 or later if you can.

I am curious if "import ProtocolBuffers" is internally called ...

swift-protobuf does not use import ProtocolBuffers.  I don't believe swift-grpc uses such a library either.


Update wast to align with GC spec tests

A few changes required to get the spec tests running from the GC repo. Changes include:

Folded expressions are now allowed in places where the text format calls for a "single instruction". This was used by a few spec tests and isn't ambiguous.
ref.any, ref.eq, ref.struct, ref.array, and ref.i31 directives were added as returns. They assert that the returned ref has the given ref type. (FYI to those wishing to use this, it basically implies that you should do a ref.cast or ref.test.)
ref.host <u32> was added as an arg and a return. It represents an internalized host value (i.e. a host value stored as anyref).
ref.extern as a return was changed to make the u32 optional. (ref.extern) is now a valid ref type assertion without asserting anything about the value.
Struct field parsing was updated to disallow the (struct i32) shorthand (see https://github.com/WebAssembly/gc/issues/333#issuecomment-1480201810)

Looks good to me, thanks!

Sorry for the noise on here while I add more changes. Didn't realize you'd get notified for draft PRs.

Oh no worries! I'll archive the notifications until this is ready

@bvisness do you need help with this PR? I was planning to add support for GC syntax myself this weekend but just saw your PR.

I'll be back to this on Monday but if you want to jump on it first, go for it. If anything my code can maybe serve as reference.
The biggest difficulty is a disagreement in how to interpret "single instruction" when omitting e.g. offsets for element segments. The spec tests allow folded instructions while wasmparser currently does not. You can see my attempt at changing this in the last couple commits.

Oh are there particular *.wast files causing trouble? I've had difficulty figuring out how to parse these historically as depending on which tool you're working against at which point of time historically things have been slightly different (or I've just interpreted things wrong)
Basically the element/offset/table text parsing I've always found tricky, and I'm happy to help if you'd like.

This is now successfully building all the GC spec tests on my end. I'm updating the top comment with a description of what I had to do.

Yeah it may be worth clarifying, but to be clear I don't think it's worth blocking this PR for that. With some more tests I'd be happy to merge this. Spec tests are currently updated by updating the tests/testsuite submodule which points to https://github.com/WebAssembly/testsuite. That repository in turn has a script which updates its contents with the actual spec repos. I'm not sure what the status is with gc and the testsuite repo and how far apart they are. If testsuite upstream isn't updated to include this new syntax it's ok to make custom tests/local/*.wast tests for gc things.

The testsuite repo seems to be up to date with the latest GC tests, but how do I actually run the proposal tests? I ran cargo test --all but I'm not seeing any gc stuff in the output (or indeed any testsuite stuff at all).

Sorry back from vacation now, but tests are run as part of cargo test --all and are specifically run as cargo test --test roundtrip. If those aren't picking up gc tests then it's the tests/roundtrip.rs file that needs modifying and/or the submodule (sorry I'm not sure the state of gc and the upstream spec tests)

Ah I see, the GC tests were explicitly ignored. I'll work through that now and make sure they're running as expected.

At this point we need to update the test suite repos in order to pass GC spec tests. However, I'm not sure how to update the test suite for GC stuff without pulling in a bunch of other changes too. After running the update script in the test suite, I'm getting a bunch of errors seemingly related to threading, for example. Strangely this is happening even though my update didn't seem to touch threading at all. I did see that there were some kind of git conflicts while running the update script...
Generally I have to admit I'm a bit lost. Could you give me some guidance on how to proceed?

Sure yeah! Wanna sync up on Zulip and/or hop on a zoom?

I will find my way onto Zulip tomorrow for sure, and would be happy to work through stuff then or on Monday. Thank you!

Ok, got the spec tests in and passing locally. They will not be passing here in the PR yet because the spec test suite needs to be updated - I have an open PR on the test suite here.
I attempted to preserve validation for the parts of the GC proposal that have been implemented so far, namely subtype validation. The implementation for this was incorrect; types with no explicit sub were nonfinal by default, but they should have been final.
Assuming we don't need to rip out the special folded-instruction parser we discussed earlier, I think this should be good to go as soon as the submodule stuff is taken care of. (If the folded instruction stuff will be an issue, I think we should open an issue in the GC repo to clarify what is "one instruction", and I would prefer that discussion not block this work.)

All looks good to me! If you want to pull in the submodule I'll go ahead and merge and get this published (plus the gc encoding changes)

Done!

I think a cargo fmt at the root of the repository should take care of it, but I never manually run that so I'm only 80% sure


new gtm container

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--mammotome--hlxsites.hlx.page/us/en/
After: https://tbt-debug--mammotome--hlxsites.hlx.page/us/en/

used for testing. Now that mammotome.com reached 100, closing this


Toast component with duration doesn't dismiss if another toast is present.

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If multiple Toasts are created on top of each other, only the lowest one wil dismiss. Others will stay.
Expected behavior:
Every individual toast will disappear when duration has ended
Steps to reproduce:
call the function showToast() multiple times before the duration of 2000 has ended (see related Code below)
Related code:
  showToast() {
    let toast = this.toastCtrl.create({
      message: ('deleted'),
      duration:2000
    });
    toast.onDidDismiss(() => {
    });
    toast.present();
  }

Other information:

Ionic info:
cli packages:

    @ionic/cli-plugin-ionic-angular : 1.4.0 (D:\Projects\ionic2\EQ\node_modules\@ionic\cli-plugin-ionic-angular)
    @ionic/cli-utils                : 1.6.0 (D:\Projects\ionic2\EQ\node_modules\@ionic\cli-utils)
    ionic (Ionic CLI)               : 3.6.0 (D:\Projects\ionic2\EQ\node_modules\ionic)

local packages:
    @ionic/app-scripts : 2.0.0
    Ionic Framework    : ionic-angular 3.5.0

System:
    Android SDK Tools : 25.2.5
    Node              : v6.9.4
    OS                : Windows 10
    npm               : 3.10.10

Thanks for opening an issue with us, we will look into this. A workaround in the meantime is to manually dismiss the toast using toast.dismiss() when you are showing two toasts at a time.

Actually, I've tried to make a workaround but that doesn't seem to work
  private showToast(item) {
    let timer = setTimeout(() => { toast.dismiss(); }, 2000);
    let toast = this.toastCtrl.create({ message: ('Toast text') });

    toast.onDidDismiss(() => {
      clearTimeout(timer);
    });

    toast.present();
  }

so although this does show the toast, If I call this function showToast() multiple times, I get the same issue

I narrowed this down to version 3.5.0. It works in 3.5.1
see this plunker
http://plnkr.co/edit/S4KNr7PCLlVzRFBWYc4r?p=preview
Here it does not works (it uses version 3.5.0)
If you change the version in systemjs.config.js on line 37 it starts to work

Is there something I'd be able to do to update to 3.5.1? Somehow I'm unable to google information about it (Admitting I'm not a very experienced coder).
I'm taking the comment about changing the version in systemjs.config.js on line 37, was a refference to the plunker example, as I'm unable to find systemjs.config.js on my own desktop.

just update the entry in your package.json  file in the root of your project and run npm install again.
If you update to 3.6, be a bit carefull, I had to fix some stuff after that.

That worked! I've changed dependencies in my package.json to "ionic-angular": "3.5.1" instead of 3.5.0, and now it's working.

Hello all! As it looks like this has already been fixed in ionic-angular I am going to close this issue for now. Thanks!


Driver / Infiniium oscilloscope : feature requests

As requested by our friends in Sydney.
They would love:

To have a way to use the streaming method for large number of points as it is possible to hit the 1GB limit.
For the get trace to return the current trace not to trigger and wait. (don't use DIGITIZE)
The sin(x)/x interpolation to be disabled so number of points requested = the number of points returned
To have functions to control the state of the scope ie Run, Single, Stop
A function to block until the scope has been triggered and acquired its data/number of averages. using ESR/STB polling or equivalent instead of *OPC? and a long timeout as the scope becomes unresponsive if we decide to interrupt the program.
For the trace command not to change the acquisition mode to real-time. It shouldn't be reset every time get_raw() is called, since the scope may be in equivalent-time or high-res mode

@StevenWaddy @Dominik-Vogel

In doing this, me may want to keep #1147 in mind.

Streaming mode will work for all lengths of data so is there a reason to keep the non-streaming mode?
Its also worth noting that splitting the acquisition and the transfer is the only way to read multiple traces captured at the same moment in time. So I may call the acquire command, then call the transfer command for each channel I care about.
Also with issue #1147https://protect-au.mimecast.com/s/sig2CROAQotAolXysNkg6w?domain=github.com. It wasn't present in the original driver / the derivatives in use in Sydney. The only differences I can see are the Sydney driver uses streaming mode and I also manipulated the raw data by hand so it may be an issue with non-streaming or the pyvisa binary query command.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Dominik Vogel<EMAIL_ADDRESS>Sent: Wednesday, October 24, 2018 8:27:07 PM
To: QCoDeS/Qcodes
Cc: Steven Waddy; Mention
Subject: Re: [QCoDeS/Qcodes] Driver / Infiniium oscilloscope : feature requests (#1335)
Seems like a very good and understandable list of requests to me.
For the realization it seems to me that we can support both the streaming mode and the shot-by-shot mode. This means for 2.) that we have to split the current get function up into one that acquires data and one that transfers the data. (So actually two to acquire data when including the streaming mode).
3.) is already implemented
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://protect-au.mimecast.com/s/Ma_BC4QZ1RFpEnr2TOeXQs?domain=github.com, or mute the threadhttps://protect-au.mimecast.com/s/ctJaC5QZ29FV3zAPhO1xCW?domain=github.com.


[BUG] Pacing layout is broken in Budget section

Describe the bug
When display Pacing in the Budget section, the layout is now broken, since the last YNAB update (July 11th, 2022)
To Reproduce
Steps to reproduce the behavior:

Go to 'Toolkit for YNAB Options'
Click on 'Budget tab'
Click on 'Add Pacing'
Go to 'YNAB'
Open the 'Budget' Tab

Expected behavior
the pacing is properly displayed
Screenshots

Desktop (please complete the following information):

OS: macOS 12.4
Browser firefox 102.0.1
Toolkit Version 3.3.3

Setting Export
[{"key":"AccountsDisplayDensity","value":"1"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AccountsStripedRowsColor","value":"#fafafa"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":false},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":false},{"key":"BottomNotificationBar","value":false},{"key":"BudgetProgressBars","value":false},{"key":"BudgetQuickSwitch","value":false},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":true},{"key":"CalculateIRR","value":false},{"key":"CalendarFirstDay","value":"1"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"2"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseInspector","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmEditTransactionCancellation","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CtrlEnterCleared","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomAverageBudgeting","value":false},{"key":"CustomFlagNames","value":false},{"key":"CustomizeColourScheme","value":false},{"key":"DateOfMoney","value":true},{"key":"DaysOfBuffering","value":"all"},{"key":"DaysOfBufferingExcludeCreditCards","value":false},{"key":"DefaultCCToCleared","value":false},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayMonthlyGoalsOverview","value":true},{"key":"DisplayTargetGoalAmount","value":false},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"DisplayTotalOverspent","value":false},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":false},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":false},{"key":"GoogleFontsSelector","value":false},{"key":"HideAccountBalancesType","value":false},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HighlightNegatives","value":false},{"key":"HoveredBudgetRows","value":true},{"key":"ImportNotification","value":false},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LiveOnLastMonthsIncome","value":false},{"key":"MasterCategoryRowColor","value":false},{"key":"MasterCategoryRowColorSelect","value":"#d1d1d6"},{"key":"MasterCategoryRowDarkColorSelect","value":"#636366"},{"key":"MemoAsMarkdown","value":true},{"key":"MonthlyNotesPopupWidth","value":false},{"key":"NavDisplayDensity","value":"1"},{"key":"NotesAsMarkdown","value":true},{"key":"POSStyleCurrencyEntryMode","value":true},{"key":"Pacing","value":"1"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":false},{"key":"QuickBudgetWarning","value":false},{"key":"ReconcileAssistant","value":false},{"key":"ReconcileBalance","value":false},{"key":"ReconcileConfetti","value":false},{"key":"ReconciledTextColor","value":false},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"1"},{"key":"RowsHeight","value":"3"},{"key":"SavingsRatio","value":"0.60"},{"key":"ScrollableEditMenu","value":false},{"key":"ShowAvailableAfterSavings","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SplitTransactionAutoFillPayee","value":false},{"key":"SplitTransactionTabExpand","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":false},{"key":"StripedBudgetRows","value":false},{"key":"SubtractUpcomingFromAvailable","value":"1"},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"1"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":true},{"key":"ViewZeroAsEmpty","value":true},{"key":"options.dark-mode","value":false}]

i am showing the same issue with pacing in windows for chrome

I am showing the same issue.

+1 for the pacing issue.
Pacing actually seems to be hidden entirely by default now though. The only way I can get it to show up, even with the broken layout is to go into the settings and toggle it off and on again. (After that it will stay until I refresh the page)

Note for anyone else experiencing this, the pacing bar on Budget Rows Progress Bars still works. You get less information than from the dedicated column, but it will at least show you if you're ahead or behind at a glance

+1 for the pacing issue.
Pacing actually seems to be hidden entirely by default now though. The only way I can get it to show up, even with the broken layout is to go into the settings and toggle it off and on again. (After that it will stay until I refresh the page)
Indeed, forgot to mention that in the initial issue, same behaviour for me :)

+1

+1

The issue appears to be connected to the use of the <li> tags for the pacing elements. Converting them to <div> tags appears to resolve the issue. Alternatively, if <li> tags are preferred, "style="list-style: none;" can be included in the tags to remove the bullet.

Any updates on this?  Pacing is one of the tools I use every single day to evaluate my budget and this has been broken for me for weeks.

I have a different issue.  MacOSX running Chrome.  The pacing indicators are totally gone.  Happened a couple of weeks ago.

I have a different issue.  MacOSX running Chrome.  The pacing indicators are totally gone.  Happened a couple of weeks ago.

It's the same issue I would say. As a workaround you can go to the extension settings, then disable and re enable pacing
It should then be displayed with the broken layout
Pacing will be hidden next time you reload the page

That worked!  Thanks so much.

+1
Good feature but it has been broken for a few weeks now. As described by others - the styling is broken (see screenshot) and the pacing column doesn't show when I re-open YNAB (have to go into toolkit settings and disable + re-enable pacing feature each time I load YNAB to get it to show).
Toolkit 3.3.5 using latest Chrome on Windows:

If anyone wants a branch to have it working in the meantime, I put this into a PR. Enjoy :)
https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/2922


Issue on using a elixir heroku compatible buildpack

This will be hard one because before writing this issue I was questioning myself where to do this, because a few projects are involved.
While deploying an elixir app and in this app I use dependencies which refer to a specific git repositories, the app always ends up in missing deps, while this is not the case.
To keep my story short I'll get to the point, Elixir uses Mix, which is a build tool that provides tasks for creating, compiling, testing Elixir projects, etc.
Now, in the file:
https://github.com/elixir-lang/elixir/blob/master/lib/mix/lib/mix/scm/git.ex#L42-L45
mix uses the .git directory to check if dependencies fetch from git are up to date.
def checked_out?(opts) do
    # Are we inside a git repository?
    File.regular?(Path.join(opts[:dest], ".git/HEAD"))
end

Is this the place where the flynn is removing those dirs?
https://github.com/flynn/flynn/blob/master/slugbuilder/builder/install-buildpack#L39
As an example I copy pasted the difference between a directory listing on a heroku app and a flynn app.
➜  oberm git:(master) heroku run ls deps/phoenix_haml/.git --app oberz
Running ls deps/phoenix_haml/.git on oberz... up, run.5258
HEAD  branches  config  description  hooks  index  info  logs  objects  packed-refs  refs

➜  oberm git:(master) flynn run ls deps/phoenix_haml/.git
ls: cannot access deps/phoenix_haml/.git: No such file or directory

Now my question is: is flynn deleting .git directories?
And secondly why does this happens and is there a way to get around this? Where does flynn stand when it comes to keep compatible with heroku's buildpack system?

Yeah, the .git directory is omitted, but I wasn't aware that Heroku included it in app slugs. We do try to maintain Heroku compatibility, but I'm a bit hesitant here because including the full .git directory would mean that the slug size is always a superset of the repo size. This is problematic because many users I've talked to have large repos, and in the vast majority of situations the data will never be utilized.
Is the Heroku behavior documented anywhere?

Yeah, the .git directory is omitted, but I wasn't aware that Heroku included it in app slugs. We do try to maintain Heroku compatibility, but I'm a bit hesitant here because including the full .git directory would mean that the slug size is always a superset of the repo size. This is problematic because many users I've talked to have large repos, and in the vast majority of situations the data will never be utilized.
Is the Heroku behavior documented anywhere?

@titanous I am not sure about Heroku's precise implementation, but as far I as I can see, when running ls on the repo I am getting the following result on the app root:
Let's run ls .git on heroku again, but now on root:
➜  oberm git:(master) heroku run ls .git --app oberz
Running ls .git on oberz... up, run.1565
ls: cannot access .git: No such file or directory

On the root dir there is no .git , which confirms your concern about the slug size, related to the app.
again, but now on one of the included dependencies, which is referring to a git repository.
➜  oberm git:(master) heroku run ls deps/phoenix_haml/.git --app oberz
Running ls deps/phoenix_haml/.git on oberz... up, run.1411
HEAD  branches  config  description  hooks  index  info  logs  objects  packed-refs  refs

Is it safe to conclude Heroku is leaving the .git dir in subs alone while, root .git folders are committed and flynn looks up all .git dirs recursively and deletes them?

This is actually caused by slugbuilder using tar with it's --exclude option which takes a pattern. Thus passing .git as is done in https://github.com/flynn/flynn/blob/master/slugbuilder/builder/build.sh#L202 results in all files matching that pattern to be excluded from the archive recursively.
Changing the exclude pattern to ./.git should correct the problem, excluding the top level .git directory but including those in subdirectories. I will push up a patch.

@josephglanville sounds good, thanks for helping out! Looking forward to the patch.

I tested it, it's seems like it is fixed! Thanks again.


feat(cdk-graph-plugin-diagram): support predetermined node positions

Fixes #853 by adding a nodePositions configuration option that takes a Map of construct ids and maps them to fixed positions.
One caveat is that the default dot-layout engine ignores pos attributes, so we have to resort to a different one. fdp seems like the most reliable in the context of diagrams. The engine only changes if nodePositions is provided and it isn't empty.
Setting a fixed location for WebServer ((0, 10)) results in the following diagram.

Now accounting for your comments - let me know what you think. Happy to elaborate on the docs (had to make it short as I'm on my way to the office.
@cogwirrel

Now accounting for your comments - let me know what you think. Happy to elaborate on the docs (had to make it short as I'm on my way to the office.
@cogwirrel

This looks great to me! Just one minor comment :)
You might also need to specify { [cdkConstructId: string]: NodePosition } for JSII to be happy :) You may also need to change NodePosition into an interface rather than a type for JSII too but I'm not sure - it's worth building locally and iterating if you're able :)

Ooh looks like you need to make sure that index.ts exports NodePositions :)

Let's see if this works ✌

Ah sorry I should have been more specific! You'll need to export from packages/cdk-graph-plugin-diagram/src/index.ts :) I feel like we're really close though! 😄

That was a bit of trial and error. Turns out I had to move out the interface from the internal directory. Apparently, jsii considered it internal similarly to commented interfaces. I also prefixed it with I to be interpreted as a behavioral interface. I'm pretty new to the jsii type system, so if you think it would be better to consider it as a struct, I'd be happy to revert it.
@cogwirrel

@martinjlowm Ah great find! Thanks so much for this! An interface seems like it's consistent with the rest of the configuration so sounds great to me! 😄


Adding possible to override the RouteLocator

Hey, we have a case that we want to used a persistance layers and also adding caching on routes so the hot reload of rules will be those when the cache will be clear.

@piclemx Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@piclemx Thank you for signing the Contributor License Agreement!

You'll have to explain better why you are making this change. Changing beans around shouldn't be done lightly.

Hey ok I have checked this.
The test which failed on Travis is failing also in previous pull request.
So seems not related with my change.
More, locally it passed when run ./mvn test.

You'll have to explain better why you are making this change. Changing beans around shouldn't be done lightly.

For sure,
We want to used the spring cloud gateway for our intern product. We wants to add a different cache so we could add some TTL on element on the cache.
The only way I saw I can do this is to implement my own CachingRouteLocator.
Another way to do this. Could be to have the Flux<Route> to be defined as a been but not sure that will be great.
Another solution could be to add another interface to be able to define to different build.
I open to discuss and if you have any suggestion I'm also open for this.
Example of Flux cache using Caffeine
 String key = "myCategory";
 LoadingCache<String, Object> graphs = Caffeine.newBuilder()
    .maximumSize(10_000)
    .expireAfterWrite(5, TimeUnit.MINUTES)
    .refreshAfterWrite(1, TimeUnit.MINUTES)
    .build(key -> createExpensiveGraph(key));

Flux<Integer> cachedMyCategory = CacheFlux
    .lookup(graphs.asMap(), key, Integer.class)
    .onCacheMissResume(repository.findAllByCategory(key));

@spencergibb I will do something to have a strategic for the caching layer. So, people could write there own caching layer or used the one provide by default.

I'd prefer a different approach. Maybe an interface that CachingRouteLocator implements that extends RouteLocator. Then it is as simple as adding @ConditionalOnMissingBean.

yeah that was

I'd prefer a different approach. Maybe an interface that CachingRouteLocator implements that extends RouteLocator. Then it is as simple as adding @ConditionalOnMissingBean.
Yeah that was the other things I started this morning. I will be able to have a update of the PR soon.

@spencergibb I rethink this. I have both solution done. I propose you this one. Lmk if it's okay with you. With this one, the person using spring-cloud gateway could define it's own version of the cachedCompositeRouteLocator. It's doesn't change the contract at all and add the possibility to define ourself the CachingRouteLocator

Can you retarget the 2.1.x branch?

Can you retarget the 2.1.x branch?

@spencergibb  it's done now.


[SPARK-31580][BUILD][test-hive1.2] Upgrade Apache ORC to 1.5.10

What changes were proposed in this pull request?
This PR aims to upgrade Apache ORC to 1.5.10.
Why are the changes needed?
Apache ORC 1.5.10 is a maintenance release with the following patches.

ORC-621 Need reader fix for ORC-569
ORC-616 In Patched Base encoding, the value of headerThirdByte goes beyond the range of byte
ORC-613 OrcMapredRecordReader mis-reuse struct object when actual children schema differs
ORC-610 Updated Copyright year in the NOTICE file

The following is release note.

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318320&version=12346912

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the existing ORC tests and a newly added test case.

Test build #121919 has started for PR 28373 at commit 4e2c009.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26589/
Test PASSed.

Test build #121923 has started for PR 28373 at commit f4fe22d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26594/
Test PASSed.

cc @gatorsmile and @yhuai since we need to update ORC dependency in branch-3.0.

Retest this please.

Test build #121924 has started for PR 28373 at commit f4fe22d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26595/
Test PASSed.

Test build #121919 has finished for PR 28373 at commit 4e2c009.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121919/
Test FAILed.

Test build #121924 has finished for PR 28373 at commit f4fe22d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121924/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26599/
Test PASSed.

Test build #121927 has started for PR 28373 at commit 4e346c7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26600/
Test PASSed.

Retest this please.

Test build #121928 has started for PR 28373 at commit 4e346c7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26601/
Test PASSed.

Test build #121923 has finished for PR 28373 at commit f4fe22d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121923/
Test PASSed.

Hi, @dbtsai .
Could you review this PR?

Thank you for review and approval, @HyukjinKwon .

Thank you for review and approval, @holdenk !

Test build #121927 has finished for PR 28373 at commit 4e346c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

The above one is passed with -Phive-1.2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121927/
Test PASSed.

Test build #121928 has finished for PR 28373 at commit 4e346c7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121928/
Test PASSed.

Merged to master/3.0.


addr:housenumber tag changes/deletes on its own

URL
No response
How to reproduce the issue?
When editing different buildings/nodes, sometimes when you click on the next building/node to edit it, the addr:housenumber tag is either changed or deleted from the previous one.
For example in changeset 151866677, I moved n3655584338 to create a new node n11935548098 and the addr:housenumber tag disappeared from the first node.
This has happened recently when adding lots of houses and addresses too. The postcode tag might also have been affected on that occasion.
Screenshot(s) or anything else?

Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
No response
Which browsers are you seeing this problem on?
Chrome

I can confirm the bug. Slightly more precise steps to reproduce:

select an existing map feature with an Address field, e.g. an address node with addr:housenumber=1
put cursor in housenumber sub-field
select a different feature with an Address field, e.g. an address node with addr:housenumber=2
sometimes, the full address of the now selected feature will be overwritten with the information in the previous feature. e.g. now reading addr:housenumber=1

this does not happen every time; in my testing sometimes it happened immediately, sometimes it required 10 clicks
it does not happen if the cursor is not in one of the address sub fields of the

fixed in 97d1aa5e2d003b8fb21924b536ca87c4eb3257b9


Change colors of bootstrap theme

Are you requesting a feature, reporting a bug or asking a question?
question
What is the current behavior?
With the last used release (1.0.28) I could do something like this:
Survey.cssType = "bootstrap";
defaultBootstrapCss.navigationButton = "btn btn-primary";

const defaultThemeColors = StylesManager.ThemeColors["default"];
defaultThemeColors["$main-color"] = "#054295";
defaultThemeColors["$main-hover-color"] = "#D62020";
defaultThemeColors["$text-color"] = "#000000";
defaultThemeColors["$header-color"] = "white";
defaultThemeColors["$header-background-color"] = "#054295";
StylesManager.applyTheme("default");

This is not possible anymore (in 1.0.35), because of the change in the StyleManager API.
How can I change the theme colors of bootstrap theme?
What is the expected behavior?
I want to change the colors of bootstrap theme.
Specify your

browser:
browser version:
surveyjs platform (angular or react or jquery or knockout or vue): angular
surveyjs version: 1.0.35

@derchirurg hello! Please try to change the code
Survey.cssType = "bootstrap";

to
Survey.StylesManager.applyTheme("bootstrap");

@dmitrykurmanov thanks, thats correct.
But how do I change the colors like:
defaultThemeColors["$main-color"] = "#054295";

@derchirurg I understand your scenario for now. We don't have this customization for bootstrap theme. (you don't need to load survey.css styles). Because in bootstrap we have bootstrap's way to change your colors (https://getbootstrap.com/docs/3.3/customize/).   Or you can just use css to override any class.


Training custom dataset out of memory

Hello everyone,
Follow this GitHub, I can train new model based on config: configs/cbnet/htc_cbv2_swin_large_patch4_window7_mstrain_400-1400_giou_4conv1f_adamw_1x_coco.py
and pre-trained model:
htc_cbv2_swin_large22k_patch4_window7_mstrain_400-1400_giou_4conv1f_adamw_1x_coco.pth
I use 2 RTX2080Ti 11GB but they're not enough memory, what should I do to can train my dataset
Or another suggests, please reply with me
Thanks very much

same problem here


Trapping Rainwater

I am a GSSOC'21 participant and i would like to add Trapping Rainwater problem's solution in C++. I will add the test cases and the time ,space complexity of this as well.Please assign this issue to me.

I want to work on this issue. Please assign to me as I had recently solved the question with less time complexity

present at #594


Column width issue when grid is % sized

I am using a grid which has the width set to 100%, and have some (but not all) columns sized at fixed values.
This worked fine with rc19, but with rc21 the columns widths are incorrect, each cell is sized to its contents.
This occurs because the new init function is called multiple times, this sets up grid.gridWidth based on the return value of gridUtil.elementWidth($elm). Most of the time this function is returning the width in pixels .e.g 16601 however, sometimes it is returning 100%. The function getWidthOrHeight()` has a shortcut out if the value is not in px, and so the calling code gets confused as it performs some maths on a value of 100% resulting in NaN and so the column width gets set to NaNpx.
As a test, I changed:
grid.gridWidth = $scope.gridWidth = gridUtil.elementWidth($elm);

to:
var w = gridUtil.elementWidth($elm);
if(angular.isNumber(w)) {
    grid.gridWidth = $scope.gridWidth = w;
}

And this did resolve the issue, however as gridUtil.elementWidth() is called in lots of places, this probably needs a more comprehensive fix.
I've been trying to reproduce this in Plnkr but with no success as yet. I'll add a plunk when I can reproduce it.

I have managed to reproduce this here: http://plnkr.co/edit/LORr2MPay1cBGNt2TMV8
As you can see, I create the grid hidden, and then enable it and it goes wrong :-(

It appears that if I wrap my code in an ng-if rather than an ng-show it works, so I guess the root cause is that the grid is created hidden. I'll try to restructure my app to work around, but there is clearly an underlying issue there

Willi1s - were you able to get through this issue? I had the same issue with ng-show and I changed it to ng-if and the table columns now get the correct size, but it still does not render all the rows for me. On page resize or on sorting, I get all the rows. Did you have a similar issue?

Refer http://ui-grid.info/docs/#/tutorial/108_hidden_grids

Solution provided that may resolve it, no comment for 3 weeks, closing, please re-raise or reopen if this is still occurring.

The hidden grid solution is not applicable for when you want to have the grid fit its parent element (when you want your page to be responsive) and set the grid size (height,width) to 100% (or calculated). It seems that the checkSize method is causing the grid to mess the layout (second call to init).

@PaulL1 the link you provided no longer works. I've tried the ngIf directive which does work, but I'd like to see what you were proposing.


How to replace update() of LocatorMixin?

Hi.
I know I can't use LocatorMixin, and should use constructor instead of initState().
However, I wasn't able to replace update() to ref.watch(), because a constructor of controller(which extends StateNotifier) are sometimes called more than once if I use ref.watch().
Could you tell me how to replace update() of LocatorMixin?
Thank you.

I've found that listening to a stream in the constructor of controller usually can replace update() of LocatorMixin.

Riverpod now has ref.listen which would typically be used for this


MRG: eeglab io: don't warn that no events can be converted if 0 events found

closes #3555
@mmagnuski

How about this ...

Broke a test

And I thought this would be a half-liner.
@mmagnuski if/once Travis comes back green, can you test it on some files? It passes the old tests and still works for the thing I'm currently working on, but we better check twice.

Current coverage is 87.29% (diff: 91.66%)

Merging #3557 into master will decrease coverage by <.01%

@@             master      #3557   diff @@
==========================================
  Files           341        341
  Lines         60067      60073     +6
  Methods           0          0
  Messages          0          0
  Branches       9174       9175     +1
==========================================
+ Hits          52436      52441     +5
  Misses         4887       4887
- Partials       2744       2745     +1

Powered by Codecov. Last update 969d8b9...baae244

@jona-sassenhagen Yes, I'll check today. In case you missed my previous comment: what do you think of merging together the "some events..." and "no events..." warnings into a more informative "5 / 125 events could not be ..."?

see lines 614ff

@mmagnuski ?

Sorry for the delay @jona-sassenhagen. Your PR works very well on my files. :+1:

Ok thanks @mmagnuski !

No prob @jona-sassenhagen :smiley:

thx @mmagnuski for checking
and thx @jona-sassenhagen for the fix


Windows Binary Operation of Sloth

hi @slok
I really like the sloth. Especially the use of OpenSLO and other providers.
I am having a few challenges making it work on windows and I am hoping it's just missing documentation.
A) I assume this error is with SLI Plugins rather than the actual spec. It's difficult to understand the error and I had to lint the sample YAML a few times

B) I Then followed the instructions in the SLI Plugins repo https://github.com/slok/sloth-common-sli-plugins

C) I suspect that I need a go runtime on the machine to be able to use the plugins. Is this assumption correct?
D) Is there anyway of bundling the SLI Plugins in to the binary ?
Once again really great tool and I love the syntax

Hi @ahaw021!
Thanks for the kind words 😄
I didn't try myself on Windows, maybe you are the first user! 🎉
My hypothesis is that the problem is with the file loading process and paths and not the plugins itself (not saying that this will work in windows either, however it should). It seems that is loading files as empty files (it doesn't error with a file not found error), strange 🤔.
I would need to make some tests with a windows machine first to give you an answer.

Hey @ahaw021!
I had the chance to use a windows machine and test Sloth. I downloaded the binary and the examples and I didn't have any problems, everything works as expected:
I tested:

Generating from spec files in the same dir.
Generating from spec files in the other dir.
Generating from generic Sloth specs.
Generating from Kubernetes Sloth specs.
Generating loading and using Pplugins.

Check these:
Generic spec and k8s spec:

Using plugins:

All worked correctly. So my guess is that the spec files you downloaded are corrupt, empty, or something related to the file content not being correct.
I'm closing the issue, if you find any other issues reopen this or create a new one!


Question : how can i set specific path or uri in storageHelper.openFolderPicker(REQUEST_CODE_PICK_FOLDER);?

Like this :
Intent intent = new Intent(Intent.ACTION_OPEN_DOCUMENT_TREE);
intent.putExtra(DocumentsContract.EXTRA_INITIAL_URI,pathuri));
startActivity(intent);

Looking for the same.
I need the folder picker by default open /Download/myfolder

Will be included in 0.14.0. For now, you can use the snapshot version, 0.14.0-SNAPSHOT

Added in 0.14.0


Add session list and the ability to sign out of other sessions

This adds a template (using Bootstrap 5, but a Django dev can override the template entirely if they want something different), some template tags, and two views to list a user's sessions and to sign out of all other sessions.
I have contributed to django-user-sessions, and much of this code comes from there. This should be fine since both that project and this project are both licensed under the MIT license.
If this is of interest I would be happy to add some tests and expand the documentation, just let me know either way.
This project is looking great, thank you for your work on it!

I appreciate your participation in this project and the time you've dedicated to it. I also want to thank you for your kindness towards this project.
Unfortunately, this is beyond the scope of this project. Like django, we are solely focused on providing session backends and the necessary features for implementing session management.
Regarding the session management page, the requirements for each project can vary, and our preference is for each project to implement this page as needed, tailored to its specific conditions and in coordination with other user settings pages.
However, we have made an effort to provide features to simplify the implementation of this page. For example, you can delete a session from the cache and the database using session.delete(). Additionally, you can retrieve information related to the user's location or device through session.location() and session.location_info() as well as session.device().

Everything I wrote is optional. If users do not want to use these two views, they don't have to reference this URLConf in their root URLConf (these two views are the only thing in the contributed URLConf). If they want to use the list view but not the template, they can easily override the template in the normal Django fashion.
And I very much appreciate how easy it was to implement this to begin with, with the exact methods you identified.
But it's your project, your perogative over what to include and offer your users.

I created a third-party package to address this: django-bigredbutton


xray for tracing kafka messages

Hello,
I am trying to figure out how can use xray to instrument services that produce/consume kafka messages and have end-to-end tracing across event-driven flows.
This seems to supported in Java as illustrated by this post - https://aws.amazon.com/blogs/opensource/tracing-performance-messaging-applications-kafka-aws-x-ray/
However, we are using golang to develop our kafka services. So I have been trying to figure out how to achieve this using the xray golang sdk. I haven't been able to figure out if my implementation is wrong or are there limitations with Xray or xray-go API.
topic := "xray"

ctx, seg := xray.BeginSegment(context.Background(), "service")
        defer seg.Close(nil)

ctxx, subSeg := xray.BeginSubsegment(ctx, "domain-event")
//ctx := context.Background()
    err = xray.Capture(ctxx, "event.ConsumeClaim", func(ctx1 context.Context) (err error) {
        msg := &sarama.ProducerMessage{
            Topic: topic,
            Value: sarama.StringEncoder("my_message_to_kafka"),
        }

        partition, offset, err := producer.SendMessage(msg)
        if err != nil {
            panic(err)
        }
        fmt.Printf("Message is stored in topic(%s)/partition(%d)/offset(%d)\n", topic, partition, offset)

        return
    })

I can see something like this in aws console

Not exactly able to trace kafka message. Am i doing something wrong here?
@luluzhao  You seem to be working on the similar issue.

Hi @continuum-aditya-pingale,
It appears you're on the right track. You seem to be instrumenting a Kafka producer. To see the end-to-end trace of your producer -> consumer on the X-Ray service map, you must also instrument the consumer code by parsing out the Trace ID, segment ID, and sampling decision from the trace header and beginning a segment with that data as described in that blog post.
Another observation is that you're creating a subsegment domain-event and using the xray.Capture() API. The capture API automatically creates a subsegment, so you probably do not need to manually create the domain-event subsegment. If you choose to keep both, then you must include a subSeg.close() at some point in your function to close the domain-event subsegment, since you are not doing so at the moment.
With those suggestions, your instrumentation of the producer should be good. If you have further questions about instrumenting the consumer we'd be happy to assist.


R file incorrectly classified as Rebol

Preliminary Steps
Please confirm you have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[x] considered implementing an override,
[x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description

An R file in a new project was misclassified as Rebol. Last push was last night (1/23/19 @ 9pm EST) and it was indexed an hour after.

@ngriffiths21 Do you want to submit a pull request for this change?

For the R pattern, would something like (?im:^(?!\s*rebol\s*\[).*) be appropriate or is that too aggressive?

We can simply improve a little the Rebol heuristic rule as discussed and remove the pattern for R. This way files that don't match the Rebol heuristic will be classified as R.

The issue in question is still present. .R files are still sometimes identified as Rebol instead of R.


[AppService] az webapp list-runtimes: Add parameter --show-runtime-details to show detailed runtime stacks and update the format of java related stacks listed

Related command

az webapp list-runtimes
Description

Add parameter --show-runtime-details to show detailed runtime stacks and update the format of java related stacks listed.
Testing Guide

az webapp list-runtimes
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AppService


fix uploader error for mask

Now getting this error for a grayscale mask when click Next: 'cannot reshape array of size 7057600 into shape (3)'. It does now display though.

Yes, our importer currently only handles RGB masks.


fix import not ignoring url path

fix #3609
This PR allows the program to continue if the input is a valid URL.
Podman import used to check filename to only allow tarball path as a file. It should also allow an URL as the doc mentioned.
Signed-off-by: Qi Wang<EMAIL_ADDRESS>

Can I find the URL of image tarball to add test for this?

Can you do
file://localhost/Path/to/tar?

No runtime_img.go downloadFromURL doesn't support this.  Get file:///home/qiwan/Documents/img.tar: unsupported protocol scheme "file"

@TomSweeneyRedHat @mheon @haircommander PTAL

LGTM

/approve

Code LGTM

@QiWang19 Not sure what these test failures are, but I don't think they're you - mind rebasing+repushing?

@mheon PTAL

LGTM
@rhatdan @TomSweeneyRedHat @vrothberg @giuseppe @baude PTAL

/lgtm


Score Routes API

Setting up the basis for the Score Routes API file

Completed get, get by id, post, put for score route.


Translations

Hi @larshp
Would like to add translation to the test. A couple of questions

should I commit directly or via PR as in AG ?
should I commit to this one or create a new repo ? I'm going to implement translation for screens and gui statuses in a while so ... shoull I keep this repo as a minimal working one and add a new one, more complex ? (imho, I'd adjust this one)
what will happen when I adjust this repo ? :) Seems that I completely missed this topic with the automatic tests of AG in the discussions. Is it becomes visible somewhere that it does not pass ? I've seen some jenkins screenshots passing by in slack ...

in the abapGit-tests organization feel free to commit directly or via PR, typically its a new test, so nothing will be overwritten so a new commit is the easiest
new repository, more test cases makes it eaiser to figure out what is wrong. Keep this one as is, add a "PROG_screen_translated" a "PROG_dynpro_translated" a combination of both etc. or just one new repo. Its nice to have the minimal examples
it shows up on https://ci.abapgit.org when Christian updates it

Regarding translations, in general we have some open issues in abapGit regarding this. If you open an issue for what you are working on I'll link it. We need to consider the approach.

Thanks !
P.S. Approach ... yeah ... I also have an idea about the approach, but when I though how to implement it I ended up with "complete rewrite needed" :) As usual :) And I really would like to have those screens and statuses soon ... well, we'll try to get my hands on it this week anyway

And this one can be closed then, thanks for the clarification again :)

If you open an issue in abapGit for translating screens and status'es, I'll add a few thoughts and link there, dont want to link from here(to avoid too much spam)


JML lambda execution role and secrets manager

We are working on a JML (Joiners, Movers, and Leavers) project. We have created a lambda function on the data platform, which queries logs from 'data-platform-apps-and-tools-production' and sends emails to specific users using the 'gov-notify' service. We are using these roles and secrets for that lambda function. If needed more information here is the ticket

Hi @murad-ali-MoJ - the aws_secrets code is fine here if you need the secrets to be durable, but the aws_iam resources can be provisioned through the modernisation-platform-environments repository with an approval from the Modernisation Platform team.
Can you move your IAM code across to your environment in Modernisation Platform Environments, and think about if you need the secrets to be durable - if so, they can be moved too.


AnoikService data supplier and unit tests

I wanted to continue writing more unit tests. I've added a data supplier for AnoikServices so it's testable. I've add settings, fixed it in the DI container and added and mended tests.

recheck

Hm, is the SonarCloud token a repository secret? I think the build keeps failing because of that.

@pkoelemij , Sonarcloud token is in a repository secret.
I will update CI run build and test for external contributor without sonarcloud


Improve default workspace naming

Details
Fixes an issue with deleted policies not being cleared from memory and uses natural numbering for default workspace names
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/229801
Tests

Delete any existing workspaces
Create a new workspace
Verify it's named "{domain}'s Workspace"
Create another workspace
Verify it's named "{domain}'s Workspace 2"
Create another new workspace
Verify it's named "{domain}'s Workspace 3"
Delete "{domain}'s Workspace 3"
Create a new workspace
Verify it's named  "{domain}'s Workspace 3" again

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as Tests

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/6833644/195948280-6f595fbf-c325-4342-8f29-e9bd781f4ec2.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/6833644/195955360-b3143217-49fd-452e-9803-6105860cfa9d.mov
Mobile Web - Safari
https://user-images.githubusercontent.com/6833644/195955823-8230423e-da51-47d7-999d-af140c039c96.mov
Desktop
https://user-images.githubusercontent.com/6833644/195949190-74d87695-05ab-4952-aa30-cf52cd3012c3.mov
iOS
https://user-images.githubusercontent.com/6833644/195952068-dd49eb39-bdd3-43b4-9063-0ec4ed1076b5.mov
Android
https://user-images.githubusercontent.com/6833644/195954401-0e6ee868-e71a-4c5f-9f72-54b51039ac91.mov

Reviewing this now, missed it since didn't receive a notification for renaming the Title from WIP

@arosiclair If I deleted Workspace 2 instead there are two workspace with same name seems like bug, is this okay?

Ready for another review

Ah sorry I also missed this one.  As a rule of thumb, it's always a good idea to leave a "ready for review" comment when you remove [WIP] from the title :)

Sorry, I wasn't able to complete the reviewer checklist and I'm going to be OOO next week. Feel free to add another reviewer if needed!

Ready for re-review. @Santhosh-Sellavel can you complete the check list? @puneetlath Francois is out, you mind reviewing?

Reviewing this now

@arosiclair I'm running into something weird, check out here.
https://user-images.githubusercontent.com/85645967/198107763-8128d32a-97ae-488e-8080-de0b24615d24.mp4

 Screenshots

Web
https://user-images.githubusercontent.com/85645967/198140779-4da4b7c4-d2f5-4f67-8fcb-015d8001fac7.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/85645967/198140820-b2af1347-6072-4403-98c6-d348ea2bd530.mov
Mobile Web - Safari
https://user-images.githubusercontent.com/85645967/198140905-3847f936-b8e7-47b5-bdf8-40111babf7cc.mp4
Desktop
https://user-images.githubusercontent.com/85645967/198140939-e5d850cf-e3ce-4d96-bbd4-264ab20682c5.mov
iOS
https://user-images.githubusercontent.com/85645967/198140973-7601280b-d62b-4a3e-b103-d89b8c51b124.mp4
Android
https://user-images.githubusercontent.com/85645967/198141113-f3fdf4d5-70d3-46a4-9e54-7b70258742dc.mov

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@arosiclair
Is this valid and working as expected?
Created three workspaces, S , S2, S3. Now went offline and deleted S3, creating a new workspace should the name should be S3 or S4.
https://user-images.githubusercontent.com/85645967/198146994-7135c4e3-4d80-4930-b951-46994b2671ba.mov

Is this a separate bug or part of this? After deleting the workspace reappears.

I ran into this in dev as well. This looks to be a separate issue with the OpenApp command not correctly removing policies that were deleted. We can ignore that issue for this PR

Created three workspaces, S , S2, S3. Now went offline and deleted S3, creating a new workspace should the name should be S3 or S4.

Since the delete on S3 is only pending while offline, the new workspace should be S4

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @arosiclair in version: 1.2.22-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.22-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@arosiclair

For all PRs that are linked to E/E issues, C+ comments and tags any assigned Expensify engineers in the PR asking them to check the E/E issue.

If the E/E issue is a bug, a BZ is already assigned, internal engineer cc's the BZ in a comment on the PR so C+ knows who is paying.
If the E/E isn't a bug, internal engineers add the Bug label to assign one, then engineer  comments on the PR tagging the BZ who's assigned to issue payment.

Can you mention the BZ here?

This bug was reported and fixed internally so no contributor payment should be necessary

Ah actually, we need to pay out @Santhosh-Sellavel for his C+ review. I'll tag the issue.

Done @sonialiap !


feat: added fingerprinting health check

It will work automatically once the new version of the browser pool is released. I have just added a health check test that correctly passes options, but the test is not necessary.
Things to consider

Turning it on by default - it "should" not break anything, but it, of course, it can in a magical way 👨🎨 I would let people test it before.
Creating a guide or extending the guide in the browser pool docs to the SDK, so developers know about this feature.

TODOs

[ ] Update browser pool version once it is released.

I would not turn it by default for now. Let's switch it with v3.

As Ondra said, let's switch the default in v3, same with the docs (this will become part of the monorepo, so API docs will work automatically).
Also needs rebase.

idk how you did it, but you have szymons proxy per page PR as part of this branch :D
probably bad rebase, please try to remove it (as a last resort you could squash all the commits and remove those changes manually)

I have created a new PR since I could mess it up with the git commands even more. I think the git magic is not worth the hustle in this case.


mgmt, upgrade network to 2021-05 #25116

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Updated network api-version to 2021-05-01.
close https://github.com/Azure/azure-sdk-for-java/issues/25116
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

[General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-
net/blob/main/CONTRIBUTING.md#general-guidelines)

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Any manual changed code?

No manual changed code involved.


Improve the default Logins

MemberLoginForm has the fields and actions extracted to a separate method, so it's more easily overridable
Moved the global variable $_REQUEST to getting the info from the controller
Updated string variables to ::class
Updated RequiredFields to be a static, so it's overridable/updatable from either Config or code

I think Scrutinizer is broken. Changes implemented though, I should've done it that way in the first place.


Complete Myriad HA Implementation

Commit 1
Scheduler state serialization and deserialization code contributed by Paul Read
StoreContext : Converts SchedulerState to byte[] and back.
ByteBufferSupport : Helper class that adds serialized objects to the bytestream and back
sdaingade: Made changes to add frameworkId
Commit 2
Myriad State Store Implementation
* Added a new interface called MyriadStateStore that every Myriad state store implementation should implement.
* Added a new class MyriadFileSystemRMStateStore that extends YARNs DFS based FileSystemRMStateStore implementation. This class also implements the MyriadStateStore interface.
* Added RMContext Object to the initialization code.
* We store the Myriad frameworkId that we receive during initial registration.
* We also store the state for all NM Tasks (Tasks against which NodeManagers are launched by the Mesos scheduler), their TaskIds, and the state in which these tasks are.
* When Yarn initializes, the starts the state store service starts first. It loads Yarn and Myriad state from the state store and then starts other services like the Yarn scheduler (which initializes Myriad scheduler). See
https://github.com/apache/hadoop/blob/branch-2.7.0/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java#L560

Tested this out on my dev cluster and it worked really well. Great work @sdaingade ! Merging this into phase1.


Update to daemon 0.19.1 when available

The Issue
Update to daemon 0.19.1 when it's released.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Closed in https://github.com/lbryio/lbry-app/pull/1146


World Freezing

When the RoadRunner moe and the Dungeons Mobs mod are used together, the game stops on the sea biome side.
The chunk is not loaded, mob cannot be attacked, command is not used, and it loads indefinitely at the end of the game.
The method of implementing a crash is to use the above two mods together and then fly around the sea biome in creative mode. there's a crash in five minutes.
There is no information left in the log and debug files because the game is frozen rather than crashed.
Of course, a crash report is not generated either.
The mods used in the Test are the latest versions.

If i modify from roadrunner config to mixin.world=false, it is confirmed that the crash does not occur

The cause has been found.
This problem occurs when enableEliteMobs = true in the config of the dungeons Libraries
I will attach the related crash report.
crash-2022-11-27_12.53.23-fml.txt

So it seems we have indeed an incompatibility with RoadRunner. I will try to do some debugging and see if I can fix it.
The thing is that Performance Mods like RoadRunner, often work by disabling certain things. It's very possible here they're disabling something they shouldn't. I'm not sure Dungeons Mobs will be able to fix this, so make sure to report it to the roadrunner team as well.

This bug should now be fixed with latest libraries