Labels Break JSHint

The following produces the error E053 - Export declarations are only allowed at the top level of module scope.
Whilst I appreciate that const and export shouldn't be used in production code (unless controlled environments, eg. Electron - the use case I have) this still shouldn't be happening AFAIK.
testLabel: {
    break testLabel;
}
export const test = 'test';

It appears JSHint isn't matching the closing brace properly, as the following supresses the error despite being syntactically incorrect:
testLabel: {
    break testLabel;
}
}
export const test = 'test';

Confirmed. Here's a further-reduced test case:
// jshint esversion: 6, module: true
x: {}
export default null;

You're right to suspect improper scope tracking. It would appear that the same underlying bug is effecting the binding tracking mechanism. Note how undef: true ought to trigger a warning in the following code but currently does not:
// jshint esversion: 6, module: true, undef: true
{ let y; }
void y;

Thanks for the report!

Submitted a patch here: https://github.com/jshint/jshint/pull/3057

This was resolved in gh-3057 and subsequently released as part of JSHint version 2.9.5.


Add overview comment to util/*

The files in util/ are not commonly used, having the comments will help with maintenance of the repo.

[ ] Dockerfile
[ ] util/Dockerfile
[x] util/clean-spell
[ ] util/github-action-test.sh
[x] util/ignored-methods.txt
[ ] util/issue-with-all-pod6.p6
[ ] util/list-missing-methods.p6
[ ] util/missing-types.p6
[ ] util/new-type.p6
[ ] util/perl-nbsp.p6
[ ] util/sync
[ ] util/sync-build-log
[ ] util/test-links.sh
[ ] util/to-raku.p6
[x] util/trigger-rebuild.txt
[x] util/unskip.p6
[ ] util/update-and-sync
[x] util/update-and-test
[x] util/xt-recent.sh

Related: we have both Dockerfile and util/Dockerfile - They appear to be basically duplicative, with some formatting differences, and direct invocation of commands vs. invoking a script. If we can eliminate one as part of this effort great, otherwise let's include documents on the top level Dockerfile as well so we know why they're different.

You mean inline comments here?
Also, re: Dockerfile. I need to find out why these were done. I think that one is used in Circle, and the other elsewhere. I'm going to check it out.

Right, one is a no-docs Dockerfile used to create the docs (and thus probably useless now, since building is no longer done here). Refers to #2525


Discard log messages when initializing the provider

Messages sent early to the "log" package end up being forwarded to stderr, and Pulumi displays stderr by default to users, which is undesirable.
Later in the provider life-cycle, Pulumi Terraform Bridge will reset log.SetOutput again to capture and appropriately track diagnostic logs, which should still work with this change.
Fixes #4645
A test is added to ensure we do not leak diagnostics again on a simple program.

/release patch


DatabaseSchemaGenerator.WriteSql needs trailing line breaks

When using WriteDDL() and WritePatch(), the generated DDL is missing any trailing line breaks after schema generation.
Current Behavior
DO $$
BEGIN
    IF NOT EXISTS(
        SELECT schema_name
          FROM information_schema.schemata
          WHERE schema_name = 'testbed'
      )
    THEN
      EXECUTE 'CREATE SCHEMA testbed';
    END IF;

END
$$;-- SchemaDiff for Marten.Testing.Documents.User
CREATE INDEX mt_doc_user_idx_username ON testbed.mt_doc_user ((data ->> 'Username'));

Note the lack of line breaks between $$ and -- on the second to last line.
Proposed Behavior
DO $$
BEGIN
    IF NOT EXISTS(
        SELECT schema_name
          FROM information_schema.schemata
          WHERE schema_name = 'testbed'
      )
    THEN
      EXECUTE 'CREATE SCHEMA testbed';
    END IF;

END
$$;

-- SchemaDiff for Marten.Testing.Documents.User
CREATE INDEX mt_doc_user_idx_username ON testbed.mt_doc_user ((data ->> 'Username'));

Closed by https://github.com/JasperFx/marten/pull/426


Web UI dies when mesh.password is set

When  I start two alert managers in a mesh with mesh.password set, and then visit <web.listen-adddress>/#/status, the alert manager who's webUI I have just visited immediately dies with the below stack trace
panic: assignment to entry in nil map

goroutine 15 [running]:
github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh.makeLocalConnectionStatusSlice.func1(0xc420042f40)
        /go/src/github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh/status.go:179 +0x42f
github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh.(*connectionMaker).queryLoop(0xc420154150, 0xc42005d380)
        /go/src/github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh/connection_maker.go:228 +0xf6
created by github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh.newConnectionMaker
        /go/src/github.com/prometheus/alertmanager/vendor/github.com/weaveworks/mesh/connection_maker.go:75 +0x21a

The text "Network error" is displayed in the web UI.
I'm currently starting these with the following commandlines:
./alertmanager -mesh.listen-address <IP_ADDRESS>:6783 -mesh.nickname peer1 -config.file simple.yml -log.level debug -web.listen-address <IP_ADDRESS>:9003 -mesh.password omgwtflol

./alertmanager -mesh.listen-address <IP_ADDRESS>:6783 -mesh.nickname peer2 -mesh.peer-id 68:94:23:5a:20:f1 -mesh.peer <IP_ADDRESS>:6783 -config.file simple.yml -storage.path data1/ -web.listen-address <IP_ADDRESS>:9003 -log.level debug -mesh.password omgwtflol

I'm using the below version, downloaded as a binary from prometheus.io
alertmanager, version 0.8.0 (branch: HEAD, revision: 74e7e48d24bddd2e2a80c7840af9b2de271cc74c)
  build user:       root@439065dc2905
  build date:       20170720-14:14:06
  go version:       go1.8.3

This does not occur if I run the same command without the -mesh.password argument.

This also occurs where I have >2 alert managers in a cluster.

Thanks for the report! We'll look at this soon.

Looks like this is a bug in weaveworks/mesh
https://github.com/prometheus/alertmanager/blob/master/vendor/github.com/weaveworks/mesh/status.go#L170
Seems fixed upstream
https://github.com/weaveworks/mesh/commit/71e3485f35d3d3339f543e4245192f7d73d339a3

@lil-cain Would you mind testing to see if the patch resolves your issue?

Your branch is enough behind master for the test not to work immediately, but when i cherry-pick your fix onto master, it fixes the bug - thanks!

Oh I'm sorry. I've rebased my pr.

Fixed by #960


RethinkDB Storage

Hi there,
I've added RethinkDB:
https://github.com/nofxx/polipus/tree/rethink
But I merged my gem update pull request too (needed it, was having gem issues ;), think I'll get to generate a clean one if you accept that pull request.

Forgot to reference the issue: https://github.com/taganaka/polipus/pull/56


Fix bug for PATCH in EndpointValidator

Description
In case of patching an existing action group object the new object has not been validated properly.
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied I added tests


[Bug] plugin-block: unable to drag the first list item to another list item

Initial checklist

[X] I agree to follow the code of conduct
[X] I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions
6.4.1
Link to runnable example
https://milkdown.dev/online-demo
Steps to reproduce

open https://milkdown.dev/online-demo
create a list with multiple list item
try to drag the first list item to another list item (to re-arrange them). It appears to drag the whole list instead of the first item.

Expected behavior
it should allow dragging the first list item to another list item to re-arrange them.
Actual behavior
It appears to drag the whole list instead of the first item.
Runtime
Chrome
OS
macOS
Build and bundle tools
Screenshot:

It's by design. you can move the second item to first then move it. If I make the first one can be moved, there will be another bug called "unable to drag the entire list"


get tag from username

Get specific tag from username not working,
'username': 'instagram',
'tag': 'fathersday',
still showing all feed.
fyi: im still new at this

Both options are no compatible, you can get the feed of an user or the feed of a tag, can not mix both


Access problem

I couldn't get into Dicord, can I get a new invite?

Try this one: https://discord.gg/qRfMantKwc


L2 Update: Added Postmenopausal clause to one of the LP5 recommendations

We agreed during the meeting on 5/10 to adjust the logic in the G.4 section of LP5 to add "AND NOT evidence of Diagnosis of Postmenopausal" to the first logic clause (see pg. 43 of the most recent L2).
We added this on the off-chance that the clinician did not "close"/adjust the clincalStatus of a Premenopausal diagnosis and later adds a diagnosis of Postmenopausal to the patient record. This clause ensures that an appropriate recommendation will be provided to woman since postmenopausal woman may require distinct care.
G.4 Benign Endometrial Cells in Premenopausal Patients or Benign Glandular Cells in Posthysterectomy patients_
IF
Diagnosis of Premenopausal
AND NOT evidence of Diagnosis of Postmenopausal
AND NOT ‘symptomatic’
AND MOST RECENT Cervical Cytology test FOUND <=5 years ago AND the result = "benign endometrial cells" or "endometrial stromal cells" or "histiocytes"
DISPLAY For asymptomatic premenopausal patients with benign endometrial cells, endometrial stromal cells, or histiocytes,
no further evaluation is recommended (BII).
OR
Diagnosis of Postmenopausal
AND MOST RECENT Cervical Cytology test FOUND <=5 years ago AND the result = "benign endometrial cells"
DISPLAY For postmenopausal patient with benign endometrial cells found via cytology, endometrial assessment is recommended (BII).
OR
Removal of cervix (completed)
AND MOST RECENT Cervical Cytology test FOUND <=5 years ago AND the result = "benign glandular cells"
DISPLAY For patients “post-hysterectomy” with benign glandular cells identified via cytology, no further evaluation is recommended (BII).

@ssebast2 As explained in the following comment: https://github.com/ccsm-cds-tools/ccsm-cds-with-tests/issues/20#issuecomment-1148008558,
Postmenopausal is now modeled as both an Observation and a Condition.
I will close this issue out since the

AND NOT evidence of Diagnosis of Postmenopausal

clause has been added to section G.4 of the L3. However, feel free to pose any follow-up questions about premenopausal/postmenopausal data modeling in Issue #20, which is still open.


livereload doesn't work in the new shib docker environment

Livereload service provided by ember server during development cannot be reached by the browser due to the proxy. We do not necessarily want to change the proxy container to pass this port to ember, as it is being used in pass-docker.
https://pass:7020/livereload.js
For now, we can continue development as before, however, developers must manually refresh the browser to see changes.

Note this is only a thing when using ember serve as it is used to automatically reload when there are code changes. Production will have no such feature.


Checking for ESC-key stroke not during sleep interval. So quitting of program sometimes takes minutes

Fixed


[$500] IOU - In a tax-enabled employee account, after creating a manual request, the tax details are not displayed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Interna Team
Slack conversation:
Action Performed:
Pre-condition: Enable tax option in old dot

Go to https://staging.new.expensify.com/
Login employee account
Tap on employee Workspace chat
Tap plus icon near compose
Tap request money--- Manual
Enter an amount and tap next
Enter merchant field
Tap show more and note tax and tax amount field shown
Tap request
Tap on IOU created to open IOU details page

Expected Result:
In a tax-enabled employee account, after creating a manual request, the tax details are displayed
Actual Result:
In a tax-enabled employee account, after creating a manual request, the tax details are not displayed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/2c71a4c9-02c7-4d84-83bf-3da793f1b20b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e7f9e81ebab2f5cf
Upwork Job ID:<PHONE_NUMBER>966477312
Last Price Increase: 2024-01-16

This is not a bug. Feature is work in progress under wave project here https://github.com/Expensify/Expensify/issues/305057#issuecomment-1889237055


Change Zap Logo to bolt only

I think we should change this logo to remove the copy zap so it is just a bolt:

My reasoning for this is because as I test and work on iOS/Android, draw mocks for our website, tweet, etc. the bolt only is the logo that is used across everything. I think unifying across all platforms as a logo without copy is smart and a small but useful change

Closed via https://github.com/LN-Zap/zap-desktop/pull/2323


[UPDATE] Onboarding/Vault creation to completely include Fast Vaults

Fast Vault introduced some big changes on how the flow on vault creation works.
We optimized the flow, removed screens/views.
Therefore please check figma onboarding flow and update the app accordingly to match the flow.
Figma should be clear on how the flow works, if there are questions please ping me.

This will also fix #1112

this one is implemented closing


MT0022: Align new repos

Description
We have list of new repos and we need to realign them with our mt-prep-toolscript to create training data for machine translation.
Expected output
Realigned new TM repos.
Relaigned new TM repos list(ids).
Implementation Steps

[x] check if bo en repo exits
[x] check if tm repo exists
[ ] modify script to check aspiration-ai for bo en
[ ] run aligner script

Number of ids: 354
Number of unique ids: 347

155 ids with no BO or EN repo:>
{"0443":["BO"],  "2730":["BO"],  "2749":["BO"],  "0043":["BO"],  "2909":["BO"],  "7671":["BO"],  "2751":["BO"],  "2726":["BO"],  "0116":["BO"],  "0667":["BO"],  "2906":["BO"],  "2998":["BO"],  "2736":["BO"],  "0109":["BO"],  "2908":["BO"],  "2733":["BO"],  "0086":["BO"],  "2728":["BO"],  "2768":["BO"],  "0107":["BO"],  "2904":["BO"],  "0079":["BO"],  "0178":["BO"],  "1439":["BO",  "EN"],  "0071":["BO"],  "2744":["BO"],  "0569":["BO"],  "2734":["BO"],  "2739":["BO"],  "2771":["BO"]}

Passang comments on the following issues

@kaldan007 @TenzinGayche,
When running the script on the BDRC server, the process keeps getting killed. This issue might be due to other processes currently running on the server. If many processes are running consistenly in bdrc server from recent period, we may need a server with more memory.
Currently, the script is being run on a personal PC.

@TenzinGayche
from from 151 ids to align and having proper bo and en ids:
Repo with no txt file:
4806, 1854, 4753, 2199, 0784, 4657, 1353, 3793, 7604, 1688, 7006, 4639, 3466, 2986, 4372, 0563, 4814, 2904, 0596, 5591, 2321, 0607, 2744, 4441, 3724, 4591, 3003, 0220,


arkmanager crashes

If i start my server with arkmanager it crashes
./arkdedicated/ShooterGame/Binaries/Linux/ShooterGameServer TheIsland?listen -server -log

If i start normaly it wont...
ark@ns215329:~$ arkmanager run
19:56:57: start
/usr/local/bin/arkmanager: line 510: ulimit: open files: cannot modify limit: Operation not permitted
19:56:57: Running /home/ark/arkdedicated/ShooterGame/Binaries/Linux/ShooterGameServer \?listen -servergamelog
19:56:57: Server PID: 23885
Using binned.
4.5.1-0+UE4 7038 3077 402 5
[S_API FAIL] SteamAPI_Init() failed; SteamAPI_IsSteamRunning() failed.
Setting breakpad minidump AppID = 346110
lsof: unacceptable port specification in: -i :
lsof 4.86
 latest revision: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/
 latest FAQ: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/FAQ
 latest man page: ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/lsof_man
 usage: [-?abhKlnNoOPRtUvVX] [+|-c c] [+|-d s] [+D D] [+|-f[gG]] [+|-e s]
 [-F [f]] [-g [s]] [-i [i]] [+|-L [l]] [+m [m]] [+|-M] [-o [o]] [-p s]
[+|-r [t]] [-s [p:s]] [-S [t]] [-T [t]] [-u s] [+|-w] [-x [fl]] [--] [names]
Use the ``-h'' option to get more help information.
Signal 11 caught.
EngineCrashHandler: Signal=11
/usr/local/bin/arkmanager: line 516: 23885 Segmentation fault      "$arkserverroot/$arkserverexec" "$arkserveropts" "${arkextraopts[@]}"
19:57:07: Bad PID ''; expected '23885'
19:57:07: exited with status 0

Is it normal that it has at this line
19:56:57: Running /home/ark/arkdedicated/ShooterGame/Binaries/Linux/ShooterGameServer ?listen -servergamelog
A backslash infront of "?" ?

It looks like you have removed all of the ARK options from the arkmanager.cfg, including serverMap.
The following settings must be present in arkmanager.cfg:

serverMap or serverMapModId
ark_RCONPort
ark_Port
ark_QueryPort

Oh ok I thought i can remove it anyways becaus its the default value so if it is not set it takes it anyways, ooops xD
Because I comment out all except serverMap and it worked.
On the weekend I dont know why but I commented serverMap out too but restarted yesterday and dont thought it was that^^
I try it again whenn less players are on and post feedback =)
ty for now

Be aware that at the moment, without the ark_RCONPort setting, the arkmanager rconcmd command won't work, and without ark_Port and ark_QueryPort, the arkmanager status command and server auto-restart won't work.

Oh ok good to know really important information maybe should be included in the # coment lines in the file?
But its also logical, where else should the arkmanager get the information^^


Avoid shared state between factory invocation when using buildList

One problem I have is when build a list of objects with options that need to be generated on the fly. Example:
var counter = 0;
Factory.define('thing')
    .option('counter', function() { return counter++; })
    .attr('number', ['counter'], function(counter) {
      return counter;
    });

In this case every time I build a new thing, using Factory.build, a new number will be generated based on the counter. The expected behavior. But this is not true when using Factory.buildList method with options parameters.
Factory.buildList('thing', 2); // works fine
// thing[0].number === 0
// thing[1].number === 1

Factory.buildList('thing', 2, {}, {}); // doesn't work
// thing[0].number === 0
// thing[1].number === 0

This happens because the buildList method pass the shared options object to the factory. So in the first call of the factory.options method the object is empty so the counter option will evaluated. The counter value will be appended to the shared options object.
Thus in the moment of the second factory, the shared options object has the value for counter previously generated.
A solution here is clone attributes and options to make sure they will be unique per factory call.
/cc @eventualbuddha

Thanks @pablolmiranda, I ended up pulling in your test but fixing it a different way (d68f9b0d6eed94712d72c26bb39f990b3d12821d). I released the fix in v0.4.2.

Great! Thanks @eventualbuddha.


[MINOR][TESTS] Fix potential bug for AlterTableTest

What changes were proposed in this pull request?
The pr aims to fix potential bug for AlterTableTest.
Why are the changes needed?
Fix bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Manually test.
Pass GA.

+1, LGTM. Merging to master.
Thank you, @panbingkun and @yaooqinn @LuciferYang for review.


There seems to be an issue with secretKey while encrypting

No matter what length key I give, it is giving the same error.

run into this today, was able to solve with a randomize string of 32 characters, now running into 404 error :(

I figured the issue out and placed a PR for it
https://github.com/sudhxnva/valo-store-bot/pull/2
You can check the code and make those changes to see if it works for you.
@survfate

hey @akylus did you also modify a local version of the valorant.js (since it is outdated right now) for continue using the bot?

Hey Guys! Sorry about the super delayed response, been busy with college and other projects. I will fix this issue in a bit. @akylus thanks for the PR, I'll look into it. Planning on a major rewrite of the project soon, code quality is poor at the moment. There'll be a hosted version of this as well.

looking forward to all that and if possible - night market command for the rewrite as well, thanks @sudhxnva


Cannot modify global variable

I have the following code:
import p_tqdm
d = dict()

def modify_dict(a):
    d[a] = a ** 2

p_tqdm.p_map(modify_dict, list(range(10)))
print(d)

It outputs {} instead of {0: 0, 1: 1, 2: 4, 3: 9, 4: 16, 5: 25, 6: 36, 7: 49, 8: 64, 9: 81}.
In comparasion, concurrent.futures works as expected:
import concurrent.futures
with concurrent.futures.ThreadPoolExecutor(max_workers=50) as executor:
     executor.map(modify_dict, list(range(10)))

Found a workaround: use dicts from multiprocessing.Manager()
import multiprocessing
manager = multiprocessing.Manager()
shared_dict = manager.dict()

def modify_dict(a):
    shared_dict[a] = a ** 2

p_tqdm.p_map(modify_dict, list(range(10)))
print(shared_dict)

The output is {1: 1, 0: 0, 2: 4, 7: 49, 4: 16, 8: 64, 3: 9, 6: 36, 5: 25, 9: 81} (the order might be different)
This is, however, just a workaround. Python dicts are thread-safe, and there are no reason why can't one use it with this library. However, the problem might belong to the dependency, pathos


Remove undefined from MuiPickersOverrides interface

Description
@material-ui's Overrides type has each override, and each key of that override, as optional. Making the MuiPickersOverrides keys possibly undefined does not allow extending Overrides without TS errors.
This PR simply makes all the fields of MuiPickersOverrides not-undefined, allowing users to extend Overrides properly.
Current behaviour
Using the stable version of this package, a TS error is thrown when trying to override:
TS2344: Type 'ComponentNameToClassKey[Name]' does not satisfy the constraint 'string'.   Type '"button" | "hidden" | "fixed" | "dashed" | "inset" | "content" | "default" | "progress" | "text" | "rtl" | "row" | "expanded" | "dense" | "last" | "absolute" | "static" | "sticky" | ... 400 more ... | undefined' is not assignable to type 'string'.     Type 'undefined' is not assignable to type 'string'.

Please show how you are using overrides

in styled.d.ts I have this
import '@material-ui/core/styles/overrides';

declare module '@material-ui/core/styles/overrides' {
  type overridesNameToClassKey = {
    [P in keyof MuiPickersOverrides]: keyof MuiPickersOverrides[P];
  };

  export interface ComponentNameToClassKey extends overridesNameToClassKey {}
}```
as per the documentation in `docs/typings.d.ts`

And then in a different file

export const muiTheme = createMuiTheme({
overrides: {
MuiPickersToolbar: {
toolbar: { backgroundColor: 'blue' }
},
},
});

Running my application I see the following error from `fork-ts-checker-webpack-plugin`

ERROR in /Users/roikoren/development/test-repo/node_modules/@material-ui/core/styles/overrides.d.ts(101,64):
TS2344: Type 'ComponentNameToClassKey[Name]' does not satisfy the constraint 'string'.
Type '"button" | "hidden" | "fixed" | "dashed" | "inset" | "content" | "default" | "progress" | "text" | "rtl" | "row" | "expanded" | "dense" | "last" | "absolute" | "static" | "sticky" | ... 400 more ... | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.

(Webstorm is showing the same error when opening the file and hovering over `ComponentNameToClassKey`).

When I use Webstorm's inspection, `overridesNameToClassKey` resolve to an equivalent of `Partial<Record<keyof MuiPickersOverrides, undefined>>`.

After my changes, there are no errors running my app, and `overridesNameToClassKey` resolves to the same thing, but with the actual class keys of each key of MuiPickersOverrides, instead of undefined.

Before the change this PR is proposing:
![image](https://user-images.githubusercontent.com/26850796/76443516-2e07de80-63cb-11ea-90ae-f5ece3e22092.png)

After:
![image](https://user-images.githubusercontent.com/26850796/76443576-5394e800-63cb-11ea-8fe2-d1f1e2abbeac.png)

I see, but I think that we should fix the reason of the problem in v4.
We will not make a v3 release for such small change. For now you can use Required

Anyway thanks for your intention to help! 👍

I understand, though know that Required doesn't work in this case, as the problem is that MuiPickersOverrides[P] is always undefined.
I will continue with what I currently have, a simple @ts-ignore, until v4 is released then.
Thanks

It should work if you create own type based on MuiPickersOverrides

I think I understand what you mean, I will try.
Thanks again

Just in case someone else runs into this, this should work until a fix is released:
import { MuiPickersOverrides } from '@material-ui/pickers/typings/overrides';
import '@material-ui/core/styles/overrides';

declare module '@material-ui/core/styles/overrides' {
  type overridesNameToClassKey = {
    [P in keyof Required<MuiPickersOverrides>]: keyof Required<MuiPickersOverrides>[P];
  };

  // eslint-disable-next-line @typescript-eslint/no-empty-interface
  export interface ComponentNameToClassKey extends overridesNameToClassKey {}
}


Update repositories.txt

Hello @angelinux3 . Thanks for your interest in contributing to the Arduino Library Manager index. I see that the library does not meet the requirements for admission, so I'll go ahead and close this.
Please work with the library maintainer to bring it (or perhaps better IRLib2, since IRLib is no longer maintained) into compliance with all the requirements listed here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#what-are-the-requirements-for-a-library-to-be-added-to-library-manager
Once that is done, you can comment here and I'll reopen the pull request so we can get the library accepted.
Please let me know if you have any questions.
Regards, Per


uptime: match the gnu version output

This version:
 22:59:49 up 10 days, 11:38, 1 user, load average: 4.07, 2.95, 2.40
GNU:
 23:00:05 up 10 days, 11:38,  1 user,  load average: 4.18, 3.03, 2.44
https://github.com/coreutils/coreutils/blob/master/src/uptime.c#L149
https://github.com/coreutils/coreutils/blob/master/src/uptime.c#L161
This patch provides the same output

@Arcterus any chance you could merge this ?
Or give permissions to others? Thanks


Merge from develop to main

Description
[Describe what this change achieves]
Issues Resolved
#259 #288
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3f28415). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage        ?   79.81%
=======================================
  Files           ?       60
  Lines           ?     1645
  Branches        ?      421
=======================================
  Hits            ?     1313
  Misses          ?      324
  Partials        ?        8

Flag
Coverage Δ

dashboards-notifications
79.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f28415...156f3b0. Read the comment docs.


Upgrade golang to 1.21.10

For https://pkg.go.dev/vuln/GO-2024-2824 (CVE-2024-24788)

The snyk failures are for github.com/opencontainers/runc/libcontainer, which has been withdrawn by github (GHSA-c5pj-mqfh-rvc3).


License in package.json

package.json specify "MAS" as a license (which license is this btw?).
The "license" field should specify a valid SPDX license identifier.
This may seem not so important, but in facts prevents actual usage of the library, since the licensing terms are not clear.

it has been updated, you can check the license info. here (https://opensource.org/licenses/MIT)
Thanks


Pulumi AWS SDK does not accept CloudFront http2and3 settings

What happened?
Try setting http2and3 as HttpVersion in Pulumi for AWS CloudFront distribution. This setting was expected to be accepted since the AWS API supports it, but an error was encountered stating that http_version can only be http1.1 or http2.
Example
$ pulumi preview --stack liveconnect-dashboard-prod
Previewing update (liveconnect-dashboard-prod):
     Type                            Name                                   Plan       Info
     pulumi:pulumi:Stack             web-liveconnect-dashboard-prod
 ~   ├─ aws:s3:Bucket                cloundfront-access-logs                update     [diff: -serverSideEncryptionConfiguration]
 ~   ├─ aws:s3:Bucket                liveconnect-dashboard-prod             update     [diff: -serverSideEncryptionConfiguration,tags]
 +   ├─ aws:cloudfront:CachePolicy   prod-default-CdnCachePolicyCors        create
 ~   ├─ aws:s3:Bucket                liveconnect-dashboard-prod-access-log  update     [diff: -serverSideEncryptionConfiguration]
 +   ├─ command:local:Command        rm-liveconnect-dashboard-prod-command  create
 +   ├─ command:local:Command        cp-liveconnect-dashboard-prod-command  create
     └─ aws:cloudfront:Distribution  dashboard                                         1 error

Diagnostics:
  aws:cloudfront:Distribution (dashboard):
    error: aws:cloudfront/distribution:Distribution resource 'dashboard' has a problem: expected http_version to be one of [http1.1 http2], got http2and3. Examine values at 'Distribution.HttpVersion'.

Output of pulumi about
pulumi about
CLI
Version      3.96.2
Go Version   go1.21.4
Go Compiler  gc

Plugins
NAME  VERSION
go    unknown

Host
OS       darwin
Version  13.4
Arch     arm64

This project is written in go: executable='/Users/mickey/.gvm/gos/go1.21.1/bin/go' version='go version go1.21.1 darwin/arm64'

Current Stack: organization/web/liveconnect-dashboard-prod

TYPE                                                    URN
pulumi:pulumi:Stack                                     urn:pulumi:liveconnect-dashboard-prod::web::pulumi:pulumi:Stack::web-liveconnect-dashboard-prod
pulumi:providers:aws                                    urn:pulumi:liveconnect-dashboard-prod::web::pulumi:providers:aws::default
aws:s3/bucket:Bucket                                    urn:pulumi:liveconnect-dashboard-prod::web::aws:s3/bucket:Bucket::cloundfront-access-logs
pulumi:providers:pulumi                                 urn:pulumi:liveconnect-dashboard-prod::web::pulumi:providers:pulumi::default
aws:s3/bucket:Bucket                                    urn:pulumi:liveconnect-dashboard-prod::web::aws:s3/bucket:Bucket::liveconnect-dashboard-prod
aws:s3/bucket:Bucket                                    urn:pulumi:liveconnect-dashboard-prod::web::aws:s3/bucket:Bucket::liveconnect-dashboard-prod-access-log
pulumi:pulumi:StackReference                            urn:pulumi:liveconnect-dashboard-prod::web::pulumi:pulumi:StackReference::organization/certificate/prod-us-east-1
aws:s3/bucketPublicAccessBlock:BucketPublicAccessBlock  urn:pulumi:liveconnect-dashboard-prod::web::aws:s3/bucketPublicAccessBlock:BucketPublicAccessBlock::liveconnect-dashboard-prod-bucket-public-access-block
aws:s3/bucketPolicy:BucketPolicy                        urn:pulumi:liveconnect-dashboard-prod::web::aws:s3/bucketPolicy:BucketPolicy::liveconnect-dashboard-prod-policy

Additional context
Pulumi AWS SDK: https://github.com/pulumi/pulumi-aws
AWS CloudFront API Reference: https://docs.aws.amazon.com/cloudfront/latest/APIReference/API_CreateDistribution.html
Go version: 1.21.1
Pulumi SDK version: 3.96.2
Pulumi AWS SDK version: 6.14.0 (later updated to 6.17.0)
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @mickey0425. Thanks for reporting this. We should support http2and3.
Examining our code, it seems like it already should, so this is definitely a bug.


Nested Scrolling

Got any ideas on this?  I'm testing some use cases right now.  You'd probably want to mimic native scrolling functionality by making the deepest object scroll, and prevent propagation upward.

I came up with this, but it's pretty expensive. Maybe you guys find a way to cache the closest element:
child.on('mousewheel', function(event) {
    event.preventDefault();

    // TODO find a way to cache this selection
    if( child.is(angular.element(event.target).closest('.ngscroll-container')) ) {
        // If jQuery hid the original event, retrieve it
        var e = event.originalEvent || event;

        var delta = ifVertElseHor(e.wheelDeltaY || e.wheelDelta, e.wheelDeltaX || e.wheelDeltaY || e.wheelDelta);

        scroll( delta );
    }

});

What id we use event.stopPropagation() after the execution  of scroll function???

I have issue like this ,,, any ideas ??

The code mentioned by me above solved my problem. Please try that fragment and comment if that solved your problem.

its work ,cool 👍


[FEAT] Possible to display Start event & User T

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Bad creation of issue


implement --force-join parameter

This solves #61

This PR now fixes both issue #61 and the broken build matrix. All tests now pass.

#61:
When client is already joined, "ipa-client-install" fails. According to the freeipa project the --force-join option allows to override this limitation.

Are there any concerns about merging these changes?

@joshuabaird @stbenjam Can anyone of you guys merge this PR, or at least comment on it?
Is this project still maintained?

Merged. Unfortunately , this module is not maintained as well it should be anymore.  Happy to review and merge any fixes or enhancements though.

Yay! :tada:

A release on Puppet Forge would be cool. Could you make this happen?


Reth slow syncing

Hello team,
It's been 1 week now since reth is syncing and so far it has only synced 5.5 million blocks. It feels like this will take couple of weeks to sync which is super slow.
The server has 1GB connection with NVME disk and has enough CPU and RAM, so slow CPU or less ram is not an issue.
I've checked the usage and its only taking 16gb ram, there is 200gb+ free ram available. Is there is any way i can speed up the syncing somehow for reth? Maybe by allowing it more ram somehow?

Syncing from genesis can take a while, you can look into speeding it up by enabling execution sync or pulling one of our Reth snapshots:
https://docs.base.org/tutorials/run-a-base-node/#snapshots

Syncing from genesis can take a while, you can look into speeding it up by enabling execution sync or pulling one of our Reth snapshots:
https://docs.base.org/tutorials/run-a-base-node/#snapshots

sorry howto?! 🙏
for base-mainnet (12C 96GB memory 6T nvme) seem cannot beat time for bad p2p ,even i started with a snapshot of 2 day old - the sync speed just barely equal (some time faster/slower)  as new block -> could not catchup

any suggestion if starting from snapshot & execution sync still slow to catchup (also nvme disk) , e.g. could team provide a longer peer list explicitly?!

seem OP_NODE_SYNCMODE not considered in op-node entrypoint script actually
, if we use param    --syncmode=execution-layer https://reth.rs/run/optimism.html explicitly instead seems sync process become differently


chat, heap, diary: send migration edits to hosts

During migration, chat identifiers change. As a consequence, references
to chat messages must change if they want to stay pointing to the same
message. However, the old ref alone is not sufficient for constructing
the new ref: you need to know the message being referenced.
Previously, we were doing this transformation during migration strictly
locally. This meant that chat hosts, not uncommonly only aware of the
messages in their own channels, were unable to migrate the chat
references correctly. Newcomers joining the channels would find "bad"
chat references in the backlog, and would be stuck with these forever.
The fix implemented herein depends on the assumption that the author of
a message containing a reference is the one most likely to be able to
resolve the reference successfully. After all, they had already seen the
message previously.
Using this assumption, we further depend on message authors to notify
channel hosts about the updated versions of their own messages. This way
the host can learn of the correctly-migrated reference, and share it
with its subscribers, without needing to chase down the reference itself
(which would require building entirely new pipelines).
The behavior here is as follows: on a per-host basis, when a subscriber
learns about a version match with the host (crucially guaranteeing that
the host has already migrated itself), it goes through its pre-migration
content again, looking for posts/replies authored by itself, containing
references to chat messages. We re-migrate those messages, but instead
of injecting them into the local %channels agent directly, we send an
action, signalling an edit of the original message (in chat's case, with
the new id), that must be sent to the channel host. This then goes on to
resolve as normal, as if the user had manually edited the content
through the ui.
The changes in 56569eb enable support for editing replies. This is a required part of this solution, because replies may contain references also. Previously, only top-level messages could be edited in-place.
Obvious caveat here is that this depends on message authors being online
and running the migration. An acceptable "risk" for p2p software.
Less obvious is the potential network load introduced by this. Each
affected message results in an individual edit, which the host must echo
out to all its subscribers. We don't expect gigantic numbers here, but
it will be a little stress test nonetheless. There are options for
spreading the load slightly, but unclear as of yet whether the
complexity required for that is a worthwhile tradeoff. Investigation
into the numbers on this to follow.
Logic herein untested at this time, further patches might follow.
For LAND-1261.

fixes LAND-1261


Add support for customizing the url used for interacting with websocket

I have a golang service that proxies to gotty. It provides authentication via an ephemeral token in a query parameter as described here. The service doesn't use HTTPS cookies for authentication, and using the built-in basic auth support for authenticating via credentials would be extra overhead due to  already being logged into the system.
In the ideal case, I could specify a custom set of query string parameters - perhaps via some sort of config.js var gotty_query_string like here - that could be included in the query here and then added here to the open of each websocket. This would provide allow my proxy service the ability to handle authentication as is without needing to implement workarounds.
Would you be willing to accept a PR that implemented this?

Sure, sounds perfectly reasonable :)

@sorenisanerd I made a couple of PRs. If you have a chance in the near future, would be great to get some 👀 on them. Happy to make changes as well!

@sorenisanerd friendly bump :)

--ws-query-args
how can i use that to connect from separate xtermjs ?


Dart2js failure if top-level getter and setter not in same library

This issue was originally filed by @mhausner

test language/getter_setter_in_lib_test contains a top-level getter/setter pair named 'bar'. The compiler falsely reports that the name bar is imported twice. The second import is actually the setter name 'bar=', not 'bar'.
tests/language/getter_setter_in_lib_test.dart:16:21:
Error: Duplicate import of 'bar'.
  Expect.equals(77, bar);
                    ^^^
tests/language/getter_setter_in_lib.dart:10:5:
Info: 'bar' is defined here.
get bar => 77;
    ^^^
tests/language/getter_setter_in_lib_test.dart:7:1:
Info: 'bar' is imported here.
import 'getter_setter_in_lib.dart';
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
tests/language/getter_setter_in_lib2.dart:7:5:
Info: 'bar' is defined here.
set bar(a) { }
    ^^^

fixed by CFE


[DO] Update WebSocket Hibernation example

Summary
This example adds the serializeAttachment and deserialzieAttachemt APIs to the existing example. It also shows how to send messages with the following condition:

Send message to the client
Send message to all the connected clients
Send message to all the connected clients except sender

I think we should make the same changes for the non-hibernation example. New devs might look at regular WS example, then see the Hibernation example and be hesitant to use hibernation because it looks significantly more complicated.
If we don't do that, we should at least modify the description of the example, because currently it says "This example is similar to the Build a WebSocket server example, but uses the WebSocket Hibernation API".


RC1 -> RC2 Migration followup

Followup to https://github.com/aspnet/Docs/pull/1161.
Issues that still need to be addressed:

[ ] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L74-L87. I have sent an email explaining what changed here. The content should be updated and maybe even an accompanying explanation.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L184. nit: append .Build() at the end.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L174. nit: there are lots of inconsistent formatting between project.json and project.json. Same with web.config vs web.config. Let's choose one and go with it. Good idea to search the entire document and make sure each occurrence is formatted correctly.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L270. What is meant by the web command? There isn't a dotnet-web. Missing Microsoft.AspNetCore.Server.IISIntegration.Tools and Microsoft.AspNetCore.Razor.Tools? Also, this section doesn't mean much at the moment and it might be better to explain this section a bit more, i.e. how to add tools to a project and how to run them. For RC2, we currently do not have dotnet CLI capability for global tools so each of these tools are project specific and need to be added under the tools section in the project.json along with its required imports subsection. To run them, you need to be in the project directory and run dotnet <tool name> Maybe this explanation belongs in the dnx->dotnet migration doc though.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L340-L341. Formatting looks wrong, the two lines should be merged into a single row.
[x] I brought this up before. Delete RC1StarterWeb - Web Deploy-publish.ps1, see image below. This is a script generated by VS for web deploy. There is a version for RC1 projects (dnx based) and a different script for RC2 projects (dotnet based) which are incompatible with each other. As such, when migrating to RC2, you need to delete the old script and let VS generate a new one to ensure web deploy works for the converted RC2 project.

[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L40. nit: formatting. Function names should be formatted to SomethingLikeThis() and also format project.json, wwwroot, etc.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L60-L69. Headings?
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L108, https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L118. nit: missing semicolon
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L276. nit: inconsistent formatting. IConfigurationSource is formatted IConfigurationProvider is not.
[x] https://github.com/aspnet/Docs/blame/dev/aspnet/migration/rc1-to-rc2.rst#L289. nit: Trace is not formatted
[ ] should also mention removing or updating sdk version in global.json
[ ] if applicationhost.config was created with RC1 or early RC2 it will point to a wrong application folder and the user won't be able to start the appliation with IIS. (https://github.com/aspnet/Tooling-Internal/issues/577)
We should also get another pair of eyes on this since I'm not familiar with some of the changes (like the ones related to MVC).
cc @rachelappel @danroth27

@DamianEdwards, we should figure out how to restructure the document here and what to add/update in the dotnet migration docs.

Added one more line to the issue where it may not be possible to start the application from VS if it was created with RC1 or early RC2. The applicationhost.config file will read wwwroot as the application folder and this is where IISExpress will look for web.config file. Since web.config now lives in approot the application won't start and it is very hard to figure out why (https://github.com/aspnet/Tooling-Internal/issues/577).


Adding image and envs support in include paths

added support for environment variables, as

>>> include
$SOME_ENV/path/to/whatever/**/*

added support for including images (.png, .jpg and .gif) for multimodal OpenAI models (for that the openai Python package must be installed)

>>> include
/path/to/myimages/image.png

updated the doc/vim-ai.txt

Thank you for the contribution, it looks nice! It needs some testing but it will be a cool feature


Breaks links to headings

This plugin is great, but it breaks any links to headings. E.g.:
##1. My Heading

<!-- This link won't work, because the actual anchor is now 1-my-heading -->
[link to My Heading](#my-heading)

Workaround is to manually create anchors for sections you want to link to, or include the heading number in the link, but that option is brittle as it changes when you add headings.
I think the fix would require modifying the HTML instead of the markdown with a :post_convert hook, but it would definitely add some complexity, and would result in e.g. Kramdown's {:toc} not including the heading numbers in its output. As-is, {:toc} works fine with this plugin.
This could be done with CSS instead, but would also not include the heading numbers in {:toc} without it being adapted.

It seems that Kramdown is supposed to remove leading numbers, but it isn't, (at least the version Jekyll is using--2.4.0 in my case).

Adding an id to the heading with the following syntax replaces the auto-generated id and works with numbered headings, {:toc}, and anchor links:
##1. My Heading {#link-to-heading}
[link to My Heading](#link-to-heading)

... so that's not too bad of a workaround.


Drag and Drop sql text file to an existing query editor in azure data studio no longer inherits database connection of existing query editor

Azure Data Studio Version: Version: 1.31.0 (user setup)
OS Version: Windows 10 Version	10.0.19043 Build 19043

Steps to Reproduce:

Create a simple query statement in notepad and save file with test.sql
Open Azure Data Studio
Connect to one of your Sql Server connections
Open a "New Query" on your connected sql server connections
using windows explorer go to where you saved test.sql and drag and drop it to the azure data studio on the tab for the new query

Prior to the update I was able to just drag and drop sql files to an existing query window and it inherited the connection. Now it just defaults to a simple text editor without the ability to use a connection.

Does this issue occur when all extensions are disabled?: Yes

Found the button for default editor action


switch-to-configuration: don't try to figure out active targets ourselves

Instead we use default.target, which mostly has the same behavior, but allows us to start up new services during boot, as needed by amazon-init (and presumably cloud-init if people used it much for NixOS). See https://github.com/NixOS/nixpkgs/issues/23221 for more info.
My main concern is targets that have been spun up manually, so we might still need some of the old logic in place. @bennofs also raises a concern about using it during rescue.target or the like. I imagine it'll need a bit of tweaking before going in, because in theory we can also affect the default unit by passing in systemd.unit on the kernel command line.
cc @edolstra @aszlig @shlevy @wkennington

These VM tests seem to pass after this change:

ec2.nix
boot.nix
boot-stage1.nix
login.nix
misc.nix

Not sure which ones (if any) really stress the systemd target stuff though...
Is there a way (outside of Hydra) to run the full suite of VM tests and get a pretty report of which pass and which fail?

IIRC, this won't transitively start dependencies of targets that are pulled in by default.target. For example, I think this won't start new socket or timer units (pulled in by sockets.target and timer.target). I could be wrong though.

Actually the both the basic.target and default.target is wanted here:
$ systemctl cat basic.target
# /nix/store/zs66inz96fpr0kkq0vaq17hdwd4s16ac-systemd-232/example/systemd/system/basic.target
#  This file is part of systemd.
#
#  systemd is free software; you can redistribute it and/or modify it
#  under the terms of the GNU Lesser General Public License as published by
#  the Free Software Foundation; either version 2.1 of the License, or
#  (at your option) any later version.

[Unit]
Description=Basic System
Documentation=man:systemd.special(7)
Requires=sysinit.target
Wants=sockets.target timers.target paths.target slices.target
After=sysinit.target sockets.target paths.target slices.target tmp.mount

# We support /var, /tmp, /var/tmp, being on NFS, but we don't pull in
# remote-fs.target by default, hence pull them in explicitly here. Note that we
# require /var and /var/tmp, but only add a Wants= type dependency on /tmp, as
# we support that unit being masked, and this should not be considered an error.
RequiresMountsFor=/var /var/tmp
Wants=tmp.mount


NOJIRA split DomainExecutorTest into three separate tests

No real wins here on circle ci. Does yield a reduction of ~20s locally but not really worth it. Back to the drawing board.


Host Comms:  Email Actions

Host emails To Dos

[ ] Send email when they activate as host (@piamancini to finish draft / @znarf to set up)
[ ] change email when purchasing a plan (open collective tier) (Pia to finish draft)
[ ] detect when they are reaching an email / over add funds / collective limit (@piamancini to draft / @znarf to set up)
[ ] monthly email when subscription is renewed (@piamancini to draft)
[ ] Send an email when you add an organization / individual as a host that you own. (Same as the first one / @znarf to set up)
[ ] email when you deactivate as a host (@piamancini to finish draft / @znarf to set up)

[WIP] Email copy document

@znarf Email Document here


completion/svn: import existing, remove copy

Description
Delete our copy of the completion function for subversion; it's part of the upstream package. Replace it with an adaptation of completion/git to find the subversion completion file in non-standard locations.
Motivation and Context
This addresses #1818.
How Has This Been Tested?
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[x] I have added tests to cover my changes, and all the new and existing tests pass.

Hi Team,
I'm not feeling this one.
If the goal is to generally hit a 'global' etc/bash_completion.d folder (i.e /etc/bash_completion.d, /usr/local/etc/bash_completion.d, etc) then I think the load is better left to the system bash completion loaders.
Is there any documentation that svn installed via package managers generally ship with a version of the completion that is not placed into the global bash-completion hierarchy?  And if so, are they stored in folder structure relative to the binary?
Our completion scripts/plugins should not be looking in the standard places for completions. ie. places that system completion loaders would already be looking.
I see Bash-its role in completions more as:

Look in known non-standard locations (ie. package manager is known to place completion somewhere like /var/opt/..., etc) where system completion would not find the file.
Vendor the completion if its available online but NOT always shipped with the binary.  Use system (non-standard-location) completion if present, vendored completion as fall-back
Contain completion in bashit completions/ IFF the completion exists no where else as to be vendored. Use system (non-standard-location) completion if present, bashit completion as fall-back

So the right course of action is based on the general availability (and placement) of the completion as part of the standard SVN installation via package managers.
At the very least, I'd be happy to have bashit vendor this completion

@davidpfarrell, I'm on-board with all of what you said here. How can we check if it's normally included with package managers? Just check a few distros?

How can we check if it's normally included with package managers? Just check a few distros?

Yeah that would likely suffice - I can confirm brew brings it and installs it in the auto-loader location

Debian Stretch:

https://packages.debian.org/stretch/amd64/subversion/filelist

Random RPM suggests they get stored in the right spot on redhat/fedora:

https://fedora.pkgs.org/34/fedora-x86_64/subversion-1.14.1-1.fc34.x86_64.rpm.html

I'm fine removing it entirely (vs vendoring it), but doing so becomes a breaking change ...
just the same, I tend to think its the right move - My feeling is that the svn completion has worked its way into the package managers and that the various systems have adopted good support for bash completions in general

After just going through completion/git, I'm going to try to do that here. That way, we keep the uncommon possibility of svn being installed somewhere weird, don't create a missing file to produce errors for users, and still avoid having to cary a copy of the completion functions.
I'm marking this PR as draft again until I push the new version.

Hi @gaelicWizard, is this PR ready?

Anything else needed for this PR?

gentle ping @davidpfarrell

gentle ping @davidpfarrell

@davidpfarrell, the stubs in /usr/bin are just that: stubs. The rest of the package is inside $DEVELOPER_DIR, which is determined by xcrun.
So, /usr/bin/git may work perfectly because the stub correctly executes /Library/Developer/CommandLineTools/usr/bin/git (or /Applications/Xcode.app/Contents/Developer/usr/bin/git), but /usr/share/git-core simply doesn't exist. /Library/Developer/CommandLineTools/usr/share/git-core does exist and is populated normally, including the bundled completion scripts.
Without xcrun, we can't locate any files other than the executables stub'd from the readonly root partition.

Thanks for taking time to 'splain - I have a little better understanding of the xcrun usage now ...

We could guard against a version mismatch ...

I'm inclined to find value in this idea - At some point it might be better to encourage the usage to fetch a completion over activating a random one ...

Thanks for taking time to 'splain - I have a little better understanding of the xcrun usage now ...

We could guard against a version mismatch ...

I'm inclined to find value in this idea - At some point it might be better to encourage the usage to fetch a completion over activating a random one ...

Peeps should absolutely be just using the regular completion loaded by bash-completions; the only reason I did any attempt to load other potential completions is because you didn't want a breaking change by just deleting this file.

not sure if we should have || true to avoid exit on error settings?

bash-3.2$ set -e
bash-3.2$ echo "$(false)$?"
1
bash-3.2$ false
=== Window terminated (Wed Jan  5 13:21:57 2022) ===

exit-on-error (set -e) does not apply to commands inside subshells. The assignment is successful, even if the command inside the subshell is not. This is explicitly documented Bash behavior that "$?" is set after the subshell, but that it does not treat it as an error. (However, if "$?" is set in such a way at the end of a function or the end of a sourced file, then the function will have that return value and that will be an error.)


Please add service worker + manifest.json so we can install Virtualmin as Chrome app

Hi there,
I wanna say I'm a great fan of this theme, many options, useful, style looks fine etc.
But 1 feature I would really like is to install Virtualmin as a Chrome app, this can only be done if there is a manifest.json file set (that's already the case) and a service-worker.js that indicates the app is installable (and of course a .js file that imports service-worker.js). Could you do this please? Doing this manually isn't always very pretty, I did in the past but it don't want to do it again after an update.
See here for a quick guide
Thanks in advance,
Remy

Hi, Remy. Thanks for the feedback.

I wanna say I'm a great fan of this theme, many options, useful, style looks fine etc.

Thanks.

But 1 feature I would really like is to install Virtualmin as a Chrome app. Doing this manually isn't always very pretty, I did in the past but it don't want to do it again after an update.

:slightly_smiling_face:
What is the real, practical benefit of doing it? I am asking, because most of the times, what a user really needs, is an ability to add a desktop shortcut for their Webmin/Virtualmin panel and have a link alongside with other installed desktop apps. If that is the case, it's already possible by "creating a shortcut" from More Tools sub-menu in Chrome.
Example:

Hi there,
It's just a lot more convenient for me, on Windows a shortcut of a website isn't really what I prefer, a standalone app will make organizing  just a lot more easy for me personally :). I can also just make a script that applies some JS after updating the theme but I think more users would appreciate it since the manifest.json is already there 👍

Would you like to make a commit, once you say you made it work already? 🙂

Haha sure, will do a MR

You can already do a similar thing to chrome app, without needing the manifest etc.
Open Virtualmin in chrome.
3 dot menu
More Tools
Create Shortcut
Fill in your customization, (open as window reccomended)
Then an icon on your desktop will show up

When you run it from that shortcut, you get a Windows taskbar icon and app like window.

Works in Brave, Chrome for sure, maybe more.

You can already do a similar thing to chrome app, without needing the manifest etc.

Yeah, I know. This is why I added manifest.json at the first place. Once it's not a general issue, I think it's time to close this issue.
@abclution Just in case, there is a way to make right side slider to have the same colors as left navigation menu:

I prefer, a standalone app will make organizing just a lot more easy for me personally :)

@RemyyB Upcoming Authentic Theme 19.83 will have it supported.


no method named looking_at found for struct bevy::prelude::Transform

Hello 👋 It's highly possible I'm not understanding this correctly, but I just attempted to replicate one of the examples (3d_scene) in a separate project using bevy as a dependency, and the following code throws an error:
examples/3d/3d_scene.rs:40
        // camera
        .spawn(Camera3dComponents {
            transform: Transform::from_translation(Vec3::new(-3.0, 5.0, 8.0))
                .looking_at(Vec3::default(), Vec3::unit_y()),
            ..Default::default()
        });

error[E0599]: no method named `looking_at` found for struct `bevy::prelude::Transform` in the current scope
  --> src/main.rs:40:18
   |
40 |                 .looking_at(Vec3::default(), Vec3::unit_y()),
   |                  ^^^^^^^^^^ method not found in `bevy::prelude::Transform`

I went and had a look at the source, and it seems like the contents of crates/bevy_transform/src/components/transform.rs is completely different to what gets installed with bevy_transform from crates.io: https://docs.rs/bevy_transform/0.2.1/bevy_transform/components/struct.Transform.html
I'm probably confused about the usage or something, some help would be great 🙂

@FrancoisM on the Bevy discord kindly answered this for me:


forwardAuth.addHeadersToResponse

What does this PR do?

closes #3660
Motivation

described in #3660
More

[x] Added/updated tests
[x] Added/updated documentation

Additional Notes
Before reviewing this please read this comment in related issue for understanding desired behaviour.
This PR CAN be merged, it does pass headers from forwardAuth service to response, but if backend has the same header, it overwrites values of the first one (Set-Cookies headers will be set from both services if have different names, if both responses have same Set-Cookie's name value from backend will be set).
Desired behaviour from my point of view is when values of headers from both services will be concatenated (through Add). So my question is to someone from the core team: what is the best way to deal with it? Or we can merge it now as it is, but implementing desired behaviour in next iteration will be breaking change
Thanks 🙂

Looks like tests not related to current changes have failed

Hey hey,
thanks for your work on that!
We're currently trying to figure out an answer for your question and I think, adding the Add functionality would be great  as its a non destructive approach and would probably help us to avoid strange behavior.
Do you have the time to contribute that as well?

Hi @SantoDE thanks for your response!

Do you have the time to contribute that as well?

Sure, I would like to! Just need a bit of instructions on best way to implement it 🙂

Any updates @SantoDE @jbdoumenjou ? 🙂

Hi @iamolegga,
Thanks for your contribution and sorry for the delay :)
After analysis, as the RFC says :
Servers SHOULD NOT include more than one Set-Cookie header field in the same response with the same cookie-name.  (See Section 5.2 for how user agents handle this case.)
To be compliant, the Set-Cookie header received from the authentication server response should only be applied after checking the Set-Cookie header value sent by the backend. The right way to do that would be to use the ModifyResponse mechanism from go. However, there is currently no way to keep track of the headers from the authentication server until the handling of the backend response.
This is why, to accept this Pull Request, a technical way to apply the header a posteriori must be found.
Unless you have a better technical proposal, we will unfortunately close this PR.
What do you think ?

Hi @jbdoumenjou

Servers SHOULD NOT include more than one Set-Cookie header field in the same response with the same cookie-name. (See Section 5.2 for how user agents handle this case.)

good catch, I didn't see that before, thanks 👍

To be compliant, the Set-Cookie header received from the authentication server response should only be applied after checking the Set-Cookie header value sent by the backend.

I think that passing set-cookie header from auth service is expected behaviour, if we set it, right?
But in case of same name that came from both auth and backend, it would be useful if backend could overwrite default value from auth. Imagine some business logic on backend that could extend default business logic on auth service. Wdyt? 🙂

As I said before, without a technical proposal compatible with the RFC, we are obliged to close this PR.
Feel free to discuss it on the corresponding issue.
Thanks anyway.

Why closing this PR? My proposition is totally compliant with RFC @jbdoumenjou

@jbdoumenjou why are you closing pr that is still in progress, what's the reason? Please read again my previous messages, I just wanted to know if described behaviour could be merged, then I could change this pr to technical proposal compatible with the RFC

Hi @iamolegga,
The team has discussed your proposal to determine if it is compliant with RFC and it appears that it is not. For example, if you copy the header Set-Cookie: name=value from the auth server response and the backend response also includes the header Set-Cookie: name=value2, both will set in the Traefik response which is not compliant as explained here.

Servers SHOULD NOT include more than one Set-Cookie header field in the same response with the same cookie-name.

As mentioned by @jbdoumenjou, to implement said functionality would require logic to handle the auth header being copied only if the backend response does not contain a Set-Cookie header with the same name. One approach would be to use the ModifyResponse mechanism from Go and there is currently no way to keep track of the headers from the auth server before the handling of the backend response.
As there is no technical proposal compatible with the RFC we were forced to close this PR. If you have ideas on how to implement this without breaking the RFC, we would welcome the discussion in the aforementioned issue that relates to this PR.
It is also possible to implement this functionality in custom middleware plugin where it isn't necessarily required to be compliant with the RFC specifications. If you'd like to learn more about how to build such a plugin, please reference the plugindemo repository.
If you have any additional questions or comments, feel free to respond here or in the aforementioned issue.

Hello @notsureifkevin
Sorry, but I didn't get it, are we discussing now only set-cookie header behaviour, right? Because according to current tests, set-cookie set by backend overwrite set-cookie with the same name set by auth. And if there is set-cookie with unique name from auth or backend it's set too. It is desired behaviour, isn't it?
My original question was about concatinating header values from both auth and backend (of course we must exclude set-cookie with same name here), but that could be extra feature, and simple overwriting that is implementing for now could be enough from my point of view.

@notsureifkevin please check this lines

@iamolegga according to the team, the response would include multiple set-cookie headers, both of which could include duplicate name's.

@notsureifkevin um, but tests pass 😐

Hello,
If you swap the lines L81 and L82 in your integration test, you will see that it is not working:
forwardauth_test.go:62:
    c.Assert(err, checker.IsNil)
... value *fmt.wrapError = &fmt.wrapError{msg:"try operation failed: for header Set-Cookie got values [Bar=Auth Bar=Backend], wanted [Foo=Auth Bar=Backend]", err:(*errors.errorString)(0xc000359ca0)} ("try operation failed: for header Set-Cookie got values [Bar=Auth Bar=Backend], wanted [Foo=Auth Bar=Backend]")

This is related to the fact that in your implementation, only the first value of Set-Cookie header is copying to the Traefik response.
If you replace your implementation by the following code, you will see that your test (without any modification) will not work:
for _, headerName := range fa.addHeadersToResponse {
	for _, v := range forwardResponse.Header.Values(headerName) {
		rw.Header().Add(headerName, v)
	}
}

forwardauth_test.go:62:
    c.Assert(err, checker.IsNil)
... value *fmt.wrapError = &fmt.wrapError{msg:"try operation failed: for header Set-Cookie got values [Foo=Auth Bar=Auth Bar=Backend], wanted [Foo=Auth Bar=Backend]", err:(*errors.errorString)(0xc00052e910)} ("try operation failed: for header Set-Cookie got values [Foo=Auth Bar=Auth Bar=Backend], wanted [Foo=Auth Bar=Backend]")

So in case, it cannot be compliant with the RFC.
Thanks anyway.


Solve Minor Entry Point Bug for x64

Hi, your code doesn't work for x64 binaries because of unnecessary call to GetThreadContext

Hey thanks, merged.


Add PostgreSQL Dockerfile and README

This PR contributes to the resolution of LinuxForHealth/connect#59
Once built:
$ docker run -p 5432:5432 IMAGE

To test connectivity once the image is started:
$ psql -U postgres -h localhost -p 5432
postgres=# create database test;

postgres=# \l
                             List of databases
   Name    |  Owner   | Encoding  | Collate | Ctype |   Access privileges
-----------+----------+-----------+---------+-------+-----------------------
 postgres  | postgres | SQL_ASCII | C       | C     |
 template0 | postgres | SQL_ASCII | C       | C     | =c/postgres          +
           |          |           |         |       | postgres=CTc/postgres
 template1 | postgres | SQL_ASCII | C       | C     | =c/postgres          +
           |          |           |         |       | postgres=CTc/postgres
 test      | postgres | SQL_ASCII | C       | C     |
(4 rows)

Note: I've not been able to successfully build this PostgreSQL image for platforms linux/s390x and linux/arm64.
Getting 404s on the following rpms:
linux/s390x : https://download.postgresql.org/pub/repos/yum/common/redhat/rhel-8-s390x/repodata/repomd.xml
linux/arm64 : https://download.postgresql.org/pub/repos/yum/common/redhat/rhel-8-aarch64/repodata/repomd.xml
Also, I was not able to get the PostgreSQL image built off the ubi-minimal base image. Had to use ubi-init.
Do we want different base images besides ubi-minimal or should I include some of the LABEL commands in this image?

did u try this on the r-pi? https://opensource.com/article/17/10/set-postgres-database-your-raspberry-pi

did u try this on the r-pi? https://opensource.com/article/17/10/set-postgres-database-your-raspberry-pi

No, but I'm curious how well this container would run in that environment.

@dixonwhitmire any suggestions for that CMD statement? ☝
Two issues:

static reference to pgsql-12
reference to ${PGDATA} in exec form
These are easily addressed by switching from exec form to shell, but from what I've read the exec form is preferred for CMD and ENTRYPOINT instructions.
Another option may be to add an ENTRYPOINT and pass in some of the commands via docker run.

Feedback has been incorporated, thanks Dixon


MS Edge 18 Object doesn't support property or method 'openKeyCursor'

Hello,
Just letting you know that this error happens since PR #874

Ah, seems like the answer here might be to try using openKeyCursor and falling back to openCursor to maintain browser compatibility. I'd happily review a PR with a fix, but if not I'll try to get to this soon, sometime this weekend I imagine. Thanks for reporting it!

Should this be in the latest version? I am still experiencing it with 1.9.0

I am seeing this in version 1.9 too.. backed off to 1.7.3.. but I would like to see this in a new release so I can keep current with this package.  Any ETA on a new version with this fix?


Unhardcode public key in account contract and inject it into the entrypoint

Given the contract address is derived from the public key (see #661), we can have the public key as an argument to the entrypoint, which gets validated against the current address, instead of hardcoding it. This lets us have a single AA implementation without hardcoding the public key. All credit goes to @joeandrews for this idea!
Update: We are conflating encryption keys and signing keys here. Once we have agreed on a scheme for managing and deriving encryption keys, if that's what goes into the address, then we should use a different set of keys for signing, which we could store in a private note.

Heads up that Noir may not be able to compute the address since it cannot run Pedersen with a non-zero generator (we should check with @sirasistant whether this is now available on aztec3-hacky). If this is still the case, we got two options:

Temporarily remove all uses of aztec3::GeneratorIndex::CONTRACT_ADDRESS in cpp and use zero, so we can generate the same hash from Noir.
Implement everything but the actual constrain that the computed address matches the current one, though this will make it harder to test that it actually works.

Another thing to consider is whether we want to change how we calculate addresses. Since #811 these are calculated as hash(deployer_public_key, salt, function_tree_root, constructor_hash), which means we have to pass all 4 arguments to validate the public key for a given address. And if we want someone else to be able to validate the pub key, we need to reveal the function tree root, which may give away which contract implementation we are using.
Given these reasons, it may be best to calculate the address as hash(deployer_public_key, h1), where h1 := hash(salt, function_tree_root, constructor_hash). This way we only need to pass h1 to the account contract to verify the pub key.

Closing, as status moved to 'Done' (it's a GitHub bug... closing will move an item to 'Done', but not the other way around).
Feel free to reopen.


Sanity arrange schema

Organize Schema Based on Pages

populate yoga pages and support English & Korean

 Sanity: Organize Schema Based on Pages


TestDFSMkdir fails with multiple partitions

3013

 Quality gate: Failed
2 Issues

 2 Code issues

Details

 Quality gate: Failed
2 Issues

 2 Code issues

Details


go fmt the code

It makes any go developers eyes bleed.

The code is go fmted.

but gofmt uses tabs, you guys use 2 spaces.

We don't.

Which means the code is not go fmt'ed, as go fmt provides a consitent formatting.

Actually you are right, I am not sure why github shows it in such an unreadable way.

Ok, github respects .editorconfig which makes the code ackward looking.

Whats the reason behind that?
It makes this project stand out and make it hard to read in github.


FLKAutoLayout causes crash on iOS9 when using topLayoutGuide or bottomLayoutGuide

topLayoutGuide and bottomLayoutGuide used to be subclasses of UIView, but they aren't in iOS9.
I patched my fork with this:
https://github.com/lisbakke/FLKAutoLayout/commit/84eec85d9dae08bae801bffbe051dcf8bd5e7558

I ended up doing this -- I'm not sure if it's perfect, but I wanted to drop it here anyway:
https://github.com/lisbakke/FLKAutoLayout/commit/be76cc2b15ba4cbdffefaf961aa3618127fb5708


Move performance test to examples

This performance test flooded the console during CI without adding much value.
This was initially incorporated to prove out worst-case latency when adding locking mechanisms to the console log.  Since it doesn't actually make any assertions about behavior or performance, I believe that it makes more sense to live as an example.
The example will generate a CSV file that can be visualized as a histogram to show console logging latency with a variable number of threads.
Alternative to #293

Failing test of focal action is another somewhat-flaky performance test

restarted


Integration tests are slow

Most integration tests need --slow, let's add it as the default.

Hmmm. I'm not sure here... I also see lot of unit tests being marked as "slow", shouldn't we also enable them?

Do you have numbers? I thought the majority of unit tests were not marked as slow.

OTOH I think I would rather keep the same defaults than upstream Salt testsuite, so not running slow tests, ssh tests, etc, and then we explicitely enable them if we want to.

Where do you want to enable them? If we don't pass --slow in GH Actions / Jenkins, we'll skip most of the integration tests. I'm okay with not using it as a default, but then we need different automated environments for "fast"/"slow".

Do you have numbers? I thought the majority of unit tests were not marked as slow.

In a full unit tests execution (slow / expensive / ssh / core / destructive), I get:
= 10361 passed, 2669 skipped, 116 deselected, 2 xfailed, 351 warnings in 1735.75s (0:28:55) =

Then, removing the "slow" subset:
= 9831 passed, 3199 skipped, 116 deselected, 2 xfailed, 327 warnings in 411.24s (0:06:51) =

So, it seems 530 tests are marked as slow.

Where do you want to enable them? If we don't pass --slow in GH Actions / Jenkins, we'll skip most of the integration tests. I'm okay with not using it as a default, but then we need different automated environments for "fast"/"slow".

I was thinking on passing the corresponding pytest flags to salt-test on each GH action definition file. I'm also fine about having "Fast" and "Slow" executions of the different testsuite executions.
Something like:

GH action
pytest flags

Unit tests (Fast)
-vvv

Unit tests (Full)
--core-tests --slow --run-expensive --ssh-tests --run-destructive -vvv

Integration tests (Fast)
-vvv

Integration tests (Full)
--core-tests --slow --run-expensive --ssh-tests --run-destructive -vvv

Functional tests (Fast)
-vvv

Functional tests (Full)
--core-tests --slow --run-expensive --ssh-tests --run-destructive -vvv

Scenarios tests (Fast)
-vvv

Scenarios tests (Full)
--core-tests --slow --run-expensive --ssh-tests --run-destructive -vvv

We decided to pass the flags explicitly instead of having them in the default config.


Asynchronous consensus proposals

Currently, if one module is slow generating its consensus proposal it block everything. With HBBFT this design made sense since it was progressing in epochs, with AlephBFT this isn't the case anymore and it might make sense to just propose module CIs whenever the module is ready and produces them.
Thoughts @joschisan?
Would fix #4101.

Right now the only latency critical proposed item is the submission of decryption shares by the ln module. This will be removed in the ng ln module. Then, all CIs left are votes on feerate, blocktime and time, hence information that is used to validate transactions in the broadcast and therefore have to be on the broadcast. Then we can then only call consensus_proposal at the granularity we want to support, e.g. every five seconds and the module simply return all currently available items. Furthermore, using the broadcast for something else but information needed to validate incoming transaction, like signature shares for ecash or client config, might be tempting, but was a very unfortunate design decision every time we did it and led to unnecessary complexity inside and outside of the modules, increased latency and horrible inefficiencies. The current mechanism has been chosen to work in unison and encourage design patterns that make sense for our modules, though it might not seem ideal on first glance. Therefore, if there is a module for which this mechanism constitutes a problem in the future this could imply a suboptimal design on the modules part. I could add this reasoning to the documentation, since I have made this argument multiple times now it seems to be a common point of irritation. If then, we have an external module that actually requires a different mechanism to what we currently have I am happy to adapt it then.

The goal here would be to not block transaction submission in case a buggy module hangs while generating its proposal, not to reduce latency (that might be a side-effect).

@joschisan implemented polling for consensus items in a separate task per module-id . That's what I remember and that's how the code looks to me, so job done? Closing. Please re-open if there's anything else left to do.


Schedule event details dialog buttons not responding

This happens on Firefox and Chrome on my MacOS Yosemite.
Trying to use the event details dialog that appears when I click on one of the events of the schedule, none of the ('save', 'delete', 'save and repeat', .... 'split') buttons respond.

Automagically solved. sorry


When are the manually segmented data included in the training dataset

Heya,
Thanks for making this great tool. I had some issues 3D segmenting my images, so I went forward manually segmenting and uploading them to the server. Could you please give me an estimate of the time it will take for my segmented images to be included in the training daaset?
cheers

these images were added to the cyto2 model in May


Error on pip install

Issue Description
pip install beanmachine on Python 3.9.1 and conda yields the error
...
  copying src/beanmachine/tutorials/utils/baseball.py -> build/lib.linux-x86_64-3.9/beanmachine/tutorials/utils
  copying src/beanmachine/tutorials/utils/__init__.py -> build/lib.linux-x86_64-3.9/beanmachine/tutorials/utils
  running build_ext
  gcc -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /opt/conda/include -fPIC -O2 -isystem /opt/conda/include -fPIC -I/opt/conda/include/python3.9 -c flagcheck.cpp -o flagcheck.o -std=c++17
  creating build/temp.linux-x86_64-3.9
  creating build/temp.linux-x86_64-3.9/src
  creating build/temp.linux-x86_64-3.9/src/beanmachine
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/distribution
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/factor
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/global
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/global/proposer
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/operator
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/proposer
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/stepper
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/stepper/single_site
  creating build/temp.linux-x86_64-3.9/src/beanmachine/graph/transform
  gcc -pthread -B /opt/conda/compiler_compat -Wl,--sysroot=/ -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /opt/conda/include -fPIC -O2 -isystem /opt/conda/include -fPIC -I/tmp/pip-install-b7wb8zlg/beanmachine_d25bd594b6074c1d8df00ef3ac23ba2c/src -I/opt/conda/include -I/opt/conda/include/eigen3 -I/opt/conda/include -I/opt/conda/include/boost -I/usr/include -I/usr/include/eigen3 -I/usr/include/boost169/ -I/usr/include/x86_64-linux-gnu -I/tmp/pip-build-env-2xwbbu_k/overlay/lib/python3.9/site-packages/pybind11/include -I/opt/conda/include/python3.9 -c src/beanmachine/graph/cavi.cpp -o build/temp.linux-x86_64-3.9/src/beanmachine/graph/cavi.o -std=c++17 -fvisibility=hidden -g0 -std=c++14 -Werror
  src/beanmachine/graph/cavi.cpp:8:10: fatal error: beanmachine/graph/distribution/distribution.h: No such file or directory
      8 | #include <beanmachine/graph/distribution/distribution.h>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  error: command '/opt/conda/bin/gcc' failed with exit code 1
  ----------------------------------------
  ERROR: Failed building wheel for beanmachine
  Building wheel for gpytorch (setup.py) ... done
  Created wheel for gpytorch: filename=gpytorch-1.6.0-py2.py3-none-any.whl size=509889 sha256=719038beac82786e389b9387b2a932a94c8d0e7b7b5b308604bcb32821b7b67f
  Stored in directory: /root/.cache/pip/wheels/a7/11/12/42b389759907cbf87eedc2d82b54d341cd95a79c72eebb1074
Successfully built gpytorch
Failed to build beanmachine
ERROR: Could not build wheels for beanmachine, which is required to install pyproject.toml-based projects

Steps to Reproduce
Run pip install beanmachine from a CLI
Expected Behavior
Successful installation
System Info
FROM mambaorg/micromamba:0.19.1
RUN micromamba install --yes --name base --channel conda-forge \
    python=3.9.1 \
    pytorch torchvision cudatoolkit=11.3
RUN micromamba install --yes --name base --channel conda-forge \
    gxx
RUN micromamba clean --all --yes

Additional Context

It seems like the pypi package stripped ".h" files

so build_ext for BMG is failing

More evidence for ^^; the build is fine when using github source: pip install git+https://github.com/facebookresearch/beanmachine.git

Colabs (eg https://colab.research.google.com/github/facebookresearch/beanmachine/blob/main/tutorials/Coin_flipping.ipynb) use Python 3.7 and beanmachine-0.1.0.post1-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl are not affected; this issue is only present in source builds


Rename speedup to timeMultiplier

From the discussion here: https://github.com/AnalyticalGraphicsInc/cesium/pull/7361#discussion_r238831918
This renames ModelAnimation.speedup to ModelAnimation.timeMultiplier and adds a deprecation warning that it will be removed in one more version. I kept the old property and added a @deprecated doc tag. I also tweaked the doc HTML slightly to make sure there's a newline after the deprecated statement so that it looks better.
I was initially going to just call it ModelAnimation.rate but that felt like it was referring to "Frame rate" but glTF animations are based on real time, not a fixed frame rate. I thought about scale or timeScale but just went with timeMultiplier because I it made the most sense to me.
@hpinkos @lilleyse do either of you want to review?

Thanks for the pull request @OmarShehata!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Changes look good to me!  Should it maybe be named just multiplier instead? @lilleyse what's your opinion?

I was worried multiplier on its own might be confused with something about how many times the animation loops but I could just be paranoid. I'm open to suggestions.

Just multiplier is nice because it matches Clock.multiplier.

Should be good now @lilleyse !

Cool, thanks!


Friends page

Should be able to add friends from a user's profile, but the friends page is where you accept requests and see you friends list.
Relevant protobuf definitions from api.proto:
syntax = "proto3";

package org.couchers.api.core;

import "google/protobuf/timestamp.proto";
import "google/protobuf/wrappers.proto";
import "google/protobuf/empty.proto";

service API {
  ...

  rpc SendFriendRequest(SendFriendRequestReq) returns (google.protobuf.Empty);

  rpc ListFriendRequests(google.protobuf.Empty) returns (ListFriendRequestsRes);

  rpc ListFriends(google.protobuf.Empty) returns (ListFriendsRes);

  rpc RespondFriendRequest(RespondFriendRequestReq) returns (google.protobuf.Empty);

  rpc CancelFriendRequest(CancelFriendRequestReq) returns (google.protobuf.Empty);

  ...
  }
}

...

message SendFriendRequestReq {
  uint64 user_id = 1;
}

message FriendRequest {
  uint64 friend_request_id = 1;

  enum FriendRequestStatus {
    // these are the only two states that a user will see
    PENDING = 0;
    ACCEPTED = 1;
  }

  FriendRequestStatus state = 2;

  uint64 user_id = 3;
}

message RespondFriendRequestReq {
  uint64 friend_request_id = 1;

  bool accept = 2;
}

message CancelFriendRequestReq {
  uint64 friend_request_id = 1;
}

message ListFriendRequestsRes {
  repeated FriendRequest sent = 1;
  repeated FriendRequest received = 2;
}

message ListFriendsRes {
  repeated uint64 user_ids = 1;
}

...

@lucaslcode Does this overlap with the user page stuff you did already that could be re-used here? I might pick this next :D

This is more a page for accepting/rejecting requests, but maybe it should include friend info and a "send friend request" link on the user page

I see, doesn't look like there's even a mid-fi design for this yet? Might have to roll along what it looks like on the alpha as a starting point

Yes, the plan is to refactor friends into "connections" which are partly automatically added (like when you accept a host request)

Isn't this the design? https://couchers.invisionapp.com/console/share/2W1JUDHBZ7/483411816


getRenderOutput().props is not accurate

The props object of getRenderOuput() appears to be a copy of the input, rather than the actual props for the rendered component. So if I have a Button component with a render function that looks like this:
let { color, ...other } = this.props;

return <Button {...other}>Test</Button>;

What should be happening is getRenderOutput.props should no longer have a color attribute. Instead, getRenderOutput().props is just a copy of the props passed into shallowRender(). As a result, we can't test to see if a proper was properly consumed.
FYI, this problem began after recently updating SD. Prior to the update (I was using 0.6 I believe), this worked as expected.

Odd, we've got tests specifically for props being the result of the rendering: https://github.com/glenjamin/skin-deep/blob/master/test/test.js#L39
Can you post a fuller example?

Here's the example I'm using (I had to remove some stuff to keep it simple, but this should work):
class TestComp extends React.Component {
    static propTypes = {
        consume: React.PropTypes.bool
    }

    render() {
        let { consume, ...other } = this.props;
        return React.createElement(
            'div'
            other
        );
    }
}

and the test:
    let tree = sd.shallowRender($(Element, { consume: true ));
    let vdom = tree.getRenderOutput();

    expect(vdom.props).not.to.have.property('consume');

The test fails becaue vdom.props.consume exists. It shouldn't, because I'm never passing the consume prop to the rendered div, I'm passing it to TestComp, which consumes it. To avoid es6, you could just give React.createElement an empty object instead of other and the problem remains: the output of tree.getRenderOutput() is effectively saying that all props sent to TestComp are also props on the output of its render function, which isn't true.
This may be a bigger fix than it's worth, in which case I'll just use a deep render for this test, but technically the output of tree.getRenderOutput doesn't accurately describe what the rendered value would look like in the DOM.

For the record, my use case is to avoid a bug that also affected ReactTransitionGroup: https://github.com/facebook/react/issues/4954.

That test is definitely showing a bug - can you add a console.log after the destructuring and confirm that other definitely does not contain consume?
getRenderOutput() just passes through to React's shallowRender system directly, so any bug is unlikely to be with skin-deep itself.
are you using babel to transpile the destructuring?

I tried to reproduce with your sample code, but I don't get an error:
https://gist.github.com/glenjamin/02d7f6465e5eccf35e8a

Hmm, just to make sure I npm-installed mocha/skin-deep and a few other test related packages and now it passes without problem. Not sure what it was, but oh well, case closed :).


sbt assembly error

I downloaded the usb.zip and am following the OReilly video course Introduction to Apache Spark.   There are some places where the presentation is out of sync with the usb.zip contents but this is where it really hurts - I cant seem to compile the examples with the instruction provided in the video, that is, run the sbt.cmd file with the parameter assembly.  Is there a fix for this?  This is the error I get.
D:\Spark\usb\spark-training\sbt>sbt assembly
[info] Set current project to sbt (in build file:/D:/Spark/usb/spark-training/sbt/)
[error] Not a valid command: assembly
[error] Not a valid project ID: assembly
[error] Expected ':' (if selecting a configuration)
[error] Not a valid key: assembly
[error] assembly
[error]         ^
D:\Spark\usb\spark-training\sbt>

These are the examples from the book, I think this is unrelated.


Update to bpmnlint v9.0.0

I guess there is nothing for us to account for on the UI? I'd expect at least one test to verify that the annotations don't crash with this new feature.

This project doesn't actually make use of the new category. I'll add a test verifying it doesn't crash.

@nikku Added a test verifying the new rule-error category works: https://github.com/camunda/linting/pull/62/commits/9aaa97ca5faa25649ae6ba56eb9a0c8e7a8b33a8


fix: clientMethodTrace missing original properties

Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2580
Short description of the changes
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A

Checklist:

[ ] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

Can you please copy the explanation from the issue onto this and provide a test?
Thanks for debugging this


Cannot add anymore automated builds for my organization (since Registry 2.0 ?)

I cannot set automated builds for my github organization anymore
I haven't changed anything on my github account nor dockerhub account, and my membership is public on github
But when trying to add a new automated build for my organization I now only see my personal github account :

I can't figure out if I am missing something here or if there is an issue on my dockerhub account since registry 2.0

Moved issue here https://github.com/docker/distribution/issues/425


[FEATURE REQ] Set download location

Add a command to pass in the folder location for download.

For which command? torrent add? If yes, then that is already supported with --save-path DIR. Can also be controlled with setting a savepath in a category and setting the category with --category=MYCATEGORY.
Try it out and report back if you have any issues.


As a user, I can download the package and click to run on OS X

Some hurdles preventing this:

the package isn't signed
the package isn't executable
the package opens a terminal (this is done deliberately for now while the app is being actively developed.)

PyInstall produces signed DMG files which should address the first 2 points, and we will turn off console operation for release.

Changed the packaging so it is a  .zip file containing an OS X application directory structure. OS X doesn't directly execute zipped content, so this has to be first clicked in the downloads folder, and then the extracted folder itself double clicked to run.
This isn't the ideal solution, but is necessary if we want signed content, and without the complexities of a DMG.


Recreate Special Effects

We need to recreate the special effects such as the admin aura.

The admin aura has been recreated.

The ribbon trail for attacks will require a custom ribbon trail renderer. Therefore, I'm going to put it on hold for now.

We need to recreate weather effects too.


constexpr Vec2, Vec3, Vec4 constructors

Signed-off-by: Cary Phillips<EMAIL_ADDRESS>

Does this address the cases you caught?

What's up with the conflict and no CI tests running?

@cary-ilm, I was just going by the error messages in the failed CI.

OK, this looks fixed now, CI is working.