pip install z80 fails

Running setup.py install for z80 did not run successfully.
│ exit code: 1
╰─> [20 lines of output]
running install
C:\Python311\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-311
creating build\lib.win-amd64-cpython-311\z80
copying z80_disasm.py -> build\lib.win-amd64-cpython-311\z80
copying z80_disasm_parser.py -> build\lib.win-amd64-cpython-311\z80
copying z80_error.py -> build\lib.win-amd64-cpython-311\z80
copying z80_instr.py -> build\lib.win-amd64-cpython-311\z80
copying z80_machine.py -> build\lib.win-amd64-cpython-311\z80
copying z80_main.py -> build\lib.win-amd64-cpython-311\z80
copying z80_source.py -> build\lib.win-amd64-cpython-311\z80
copying z80_token.py -> build\lib.win-amd64-cpython-311\z80
copying z80_init_.py -> build\lib.win-amd64-cpython-311\z80
running build_ext
building 'z80._z80' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
this cpp built tools take over 1.3 GB to install. maybe use another compiler or use the VScode C++ compiler /

https://stackoverflow.com/questions/25595098/force-setup-py-to-use-my-custom-compiler reads like it's possible to specify the compiler with setup.py --compiler. I guess cygwin or mingw32 could be viable alternatives to MSVC on Windows?

Hey
I just tried today (python 3.12.3) with this result:
python3 setup.py
Traceback (most recent call last):
  File "/Users/mortenjc/proj/3rdpty/z80/setup.py", line 4, in <module>
    import distutils.sysconfig
ModuleNotFoundError: No module named 'distutils'

pip install distutils also fails.
https://docs.python.org/3.10/whatsnew/3.10.html#distutils-deprecated
This currently prevents me from setting this up on my Macbook. Is there a known workaround?

It looks like the use of distutils in setup.py is a workaround for a bug that was fixed in Python 3.6, according to the linked bug report. Python 3.8 sunsets in October this year, so it's possible to eliminate this usage entirely without breaking compatibility with most users. (Anyone still on 3.5 probably has bigger problems.)

Right, we should switch to setuptools. Will try that as soon as I have a chance.

References to distutils are removed in 9a5d7447e145d592f45f6192098638d0d7ceaab7. @mortenjc Morten, can you give it a try?

Hi,
This seems to work for me
Best
Morten

From: Ivan Kosarev @.***>
Sent: Friday, July 26, 2024 9:08 PM
To: kosarev/z80
Cc: Morten Jagd Christensen; Mention
Subject: Re: [kosarev/z80] pip install z80 fails (Issue #53)
References to distutils are removed in 9a5d744https://github.com/kosarev/z80/commit/9a5d7447e145d592f45f6192098638d0d7ceaab7. @mortenjchttps://github.com/mortenjc Morten, can you give it a try?
—
Reply to this email directly, view it on GitHubhttps://github.com/kosarev/z80/issues/53#issuecomment-2253319030, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABEHBDRY2UEEXMALDCB76FDZOKNCLAVCNFSM6AAAAABKQ7DNO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJTGMYTSMBTGA.
You are receiving this because you were mentioned.Message ID: @.***>

still not working for me:
Collecting z80
Downloading z80-1.0b3.tar.gz (49 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 49.3/49.3 kB 1.2 MB/s eta 0:00:00
Preparing metadata (setup.py) ... done
Installing collected packages: z80
DEPRECATION: z80 is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
Running setup.py install for z80 ... error
error: subprocess-exited-with-error
× Running setup.py install for z80 did not run successfully.
│ exit code: 1
╰─> [63 lines of output]
running install
C:\Python311\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build\lib.win-amd64-cpython-311
creating build\lib.win-amd64-cpython-311\z80
copying z80_disasm.py -> build\lib.win-amd64-cpython-311\z80
copying z80_disasm_parser.py -> build\lib.win-amd64-cpython-311\z80
copying z80_error.py -> build\lib.win-amd64-cpython-311\z80
copying z80_instr.py -> build\lib.win-amd64-cpython-311\z80
copying z80_machine.py -> build\lib.win-amd64-cpython-311\z80
copying z80_main.py -> build\lib.win-amd64-cpython-311\z80
copying z80_source.py -> build\lib.win-amd64-cpython-311\z80
copying z80_token.py -> build\lib.win-amd64-cpython-311\z80
copying z80_init_.py -> build\lib.win-amd64-cpython-311\z80
running build_ext
building 'z80._z80' extension
creating build\temp.win-amd64-cpython-311
creating build\temp.win-amd64-cpython-311\Release
creating build\temp.win-amd64-cpython-311\Release\z80
"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Python311\include -IC:\Python311\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\ATLMFC\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /EHsc /Tpz80/_z80module.cpp /Fobuild\temp.win-amd64-cpython-311\Release\z80/_z80module.obj
_z80module.cpp
"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\HostX86\x64\link.exe" /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\Python311\libs /LIBPATH:C:\Python311 /LIBPATH:C:\Python311\PCbuild\amd64 "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\ATLMFC\lib\x64" "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22000.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22000.0\um\x64" /EXPORT:PyInit__z80 build\temp.win-amd64-cpython-311\Release\z80/z80module.obj /OUT:build\lib.win-amd64-cpython-311\z80_z80.cp311-win_amd64.pyd /IMPLIB:build\temp.win-amd64-cpython-311\Release\z80_z80.cp311-win_amd64.lib
Creating library build\temp.win-amd64-cpython-311\Release\z80_z80.cp311-win_amd64.lib and object build\temp.win-amd64-cpython-311\Release\z80_z80.cp311-win_amd64.exp
Generating code
Finished generating code
running install_lib
creating C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_disasm.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_disasm_parser.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_error.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_instr.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_machine.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_main.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_source.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_token.py -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_z80.cp311-win_amd64.pyd -> C:\Python311\Lib\site-packages\z80
copying build\lib.win-amd64-cpython-311\z80_init.py -> C:\Python311\Lib\site-packages\z80
byte-compiling C:\Python311\Lib\site-packages\z80_disasm.py to _disasm.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_disasm_parser.py to _disasm_parser.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_error.py to _error.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_instr.py to _instr.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_machine.py to _machine.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_main.py to _main.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_source.py to _source.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_token.py to token.cpython-311.pyc
byte-compiling C:\Python311\Lib\site-packages\z80_init.py to init.cpython-311.pyc
running install_egg_info
running egg_info
writing z80.egg-info\PKG-INFO
writing dependency_links to z80.egg-info\dependency_links.txt
writing entry points to z80.egg-info\entry_points.txt
writing top-level names to z80.egg-info\top_level.txt
reading manifest file 'z80.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE'
writing manifest file 'z80.egg-info\SOURCES.txt'
Copying z80.egg-info to C:\Python311\Lib\site-packages\z80-1.0b3-py3.11.egg-info
running install_scripts
Installing z80-script.py script to C:\Python311\Scripts
error: [Errno 13] Permission denied: 'C:\Python311\Scripts\z80-script.py'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> z80
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

@fmuntean Did you try to pip install wheel before installing z80 as the deprecation message suggests?

This bit:
 error: [Errno 13] Permission denied: 'C:\Python311\Scripts\z80-script.py'

looks like a problem with the Python setup itself. Can you install any packages into that folder at all? Another thing to try is a user-local (pip install --user z80) installation.

pip install wheel
Requirement already satisfied: wheel in c:\python312\lib\site-packages (0.44.0)

pip install --user z80
Collecting z80
Downloading z80-1.0b3.tar.gz (49 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 49.3/49.3 kB 276.8 kB/s eta 0:00:00
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [28 lines of output]
Traceback (most recent call last):
File "C:\Users\mfd\AppData\Roaming\Python\Python312\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
File "C:\Users\mfd\AppData\Roaming\Python\Python312\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\mfd\AppData\Roaming\Python\Python312\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\mfd\AppData\Local\Temp\pip-build-env-ntcsy2lw\overlay\Lib\site-packages\setuptools\build_meta.py", line 327, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\mfd\AppData\Local\Temp\pip-build-env-ntcsy2lw\overlay\Lib\site-packages\setuptools\build_meta.py", line 297, in _get_build_requires
self.run_setup()
File "C:\Users\mfd\AppData\Local\Temp\pip-build-env-ntcsy2lw\overlay\Lib\site-packages\setuptools\build_meta.py", line 497, in run_setup
super().run_setup(setup_script=setup_script)
File "C:\Users\mfd\AppData\Local\Temp\pip-build-env-ntcsy2lw\overlay\Lib\site-packages\setuptools\build_meta.py", line 313, in run_setup
exec(code, locals())
File "", line 10, in
File "C:\Python312\Lib\inspect.py", line 1282, in getsource
lines, lnum = getsourcelines(object)
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\inspect.py", line 1264, in getsourcelines
lines, lnum = findsource(object)
^^^^^^^^^^^^^^^^^^
File "C:\Python312\Lib\inspect.py", line 1093, in findsource
raise OSError('could not get source code')
OSError: could not get source code
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

Does running pip install --upgrade setuptools wheel before installing z80 help?

Does running pip install --upgrade setuptools wheel before installing z80 help?

install --upgrade setuptools wheel
Requirement already satisfied: setuptools in c:\python311\lib\site-packages (65.5.0)
Collecting setuptools
Downloading setuptools-75.0.0-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 3.4 MB/s eta 0:00:00
Collecting wheel
Downloading wheel-0.44.0-py3-none-any.whl (67 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 67.1/67.1 kB 3.6 MB/s eta 0:00:00
Installing collected packages: wheel, setuptools
WARNING: Failed to write executable - trying to use .deleteme logic
ERROR: Could not install packages due to an OSError: [WinError 2] The system cannot find the file specified: 'C:\Python311\Scripts\wheel.exe' -> 'C:\Python311\Scripts\wheel.exe.deleteme'

Installing collected packages: wheel, setuptools
WARNING: Failed to write executable - trying to use .deleteme logic
ERROR: Could not install packages due to an OSError: [WinError 2] The system cannot find the file specified: 'C:\Python311\Scripts\wheel.exe' -> 'C:\Python311\Scripts\wheel.exe.deleteme'

Looks like it doesn't have rights to write the destination folder. Did you try to run this as administrator? Can you install any other packages at all?

I have no problem installing other packages.


530 reordering groups

Trello
The changes in this PR

Add the "Reorder group" link to the Group landing page
Creates the new reorder page

Screenshots below

Page
Screenshot

Landing page

Reorder page

Landing page after reorder

Looks great from the screenshots. @davidtrussler let me know if you want to do a 1-2-1 demo session sometime today or tomorrow

Hi @davidtrussler - thank you! it looks and works great!
A couple of questions from me for the bits above ☝


Incompatibility with JEI and TechReborn

Describe the bug
Recipes for inside the machines are missing for techreborn
Steps to reproduce

Install mods
Place down a tech reborn grinder
Place a diamond inside watch it grind to diamond dust
View JEI Recipes for Diamond Dust
Notice recipe using the grinder is missing only the crafting one
...

Logs
N/A
Additional context
Connector-1.0.0-beta.19+1.20.1-full.jar
ConnectorExtras-1.4.1+1.20.1.jar
fabric-api-0.90.0+1.9.27+1.20.1.jar
TechReborn-5.8.7.jar
jei-1.20.1-forge-<IP_ADDRESS>.jar
Inside the machine

What JEI tell you

You can see recipes for crafting machines, but can't see recipes for crafting inside machines. Some reason only REI allows you too.

That is correct, Tech Reborn contains no JEI plugin and only integrates with REI. If you wish to look up TR recipes, you'll need to use REI.

Oof no way to bridge to JEI? REI is having many issues on its own that I had to deal with.

Unfortunately I'm not aware of any REI->JEI bridges. Both EMI and REI can run JEI plugins, but it doesn't work the other way around.


Macros redefinition while using AWS SDK C++ together with JsonCpp

What platform/OS are you using?
Windows 10 Enterprise, version 1709, build 16299.431
What compiler are you using? what version?
Microsoft Visual Studio 2013
I am working on project which depends both on AWS SDK C++ and JsonCpp. Eventually I found out that there's a JSON_USE_EXCEPTION macros redefinition when you try to include aws\core\SDKConfig.h after json\config.h. Since AWS SDK C++ uses its own "amalgamated" version of JsonCpp stored in only one header aws\aws-cpp-sdk-core\include\aws\core\external\json-cpp\json.h and almost all macroses have AWS_ prefix, it would probably worth to add this prefix to mentioned macros too for preventing such behavior.

Hi thanks for bring this up. We have replaced Jsoncpp with CJson in latest SDK. Is that possible for you to update?

Please reopen this issue if you still have questions.


[BUG]  Used vulnerable package (semver)

Current Behavior
Currently the semver package being used (7.3.9) has a ReDoS vulnerability that has been fixed in a later minor version: https://security.snyk.io/vuln/SNYK-JS-SEMVER-3247795
Expected Behavior
Upgrade package to reduce vulnerable libraries
Github Repo
No response
Steps to Reproduce
N/A
Nx Report
N/A

nx.json
N/A

Failure Logs
N/A

Additional Information
No response

nx-dotnet is a development dependency, so this kind of regex attack isn't viable. We will likely upgrade it at the same time as Nx, so its coming soon, but I'm going to close this out as its not relevant for the project.


On a system with 12 D400 series cameras plugged in simultaneously:

After hardware resetting the cameras, system sees zero (or a subset) of the total  number of devices. Occasionally, non-repeatable, but regularly occurring.
After rebooting, the system then is able to see 7 of the 12 devices.

The solution is to physically unplug and then reconnect the set of USB cables at the back of the computer. This procedure is very inconvenient. We really need a fix for this as these machines may not be accessible to an operator in the future (they may be located in a locked cabinet, for instance).
Note: We adhere to all the USB specs and power requirements and are able to operate these cameras at peak spec under regular conditions. This is an intermittent problem.

Are you connecting the cameras to a single PC with a USB hub with many ports such as a 12 port hub, please?
Doing hardware reset with scripting is the obvious way to reset without physical unplug-replug, but you say that when resetting in your setup, not all of the 12 cameras reset successfully.
A solution may be to iterate through all the cameras, reset them and wait for completion of reset before continuing.  A RealSense community member called West a contributed a script for doing this.
https://forums.intel.com/s/question/0D70P0000068r7PSAQ/d435-streams-work-once-then-crash?language=en_US#558651

Thanks Marty.

Yes, single PC.
I can't describe the hardware configuration further, except to say that it's working great.
We are running proprietary software.

Our typical process is to optionally [user's choice] hardware reset all the cameras, then enable the streams and start the pipeline. Again, usually works great.
Also, to clarify, the devices become invisible to the driver, so, when this bug happens:
rs2::device_list devices = context.query_devices();
devices.size() <- would be less than the # of sensors actually physically plugged into the machine.
Hence the unplug, reconnect mechanism is necessary.
The issue here is that the mode of failure is catastrophic and the user may not have access to the machine in our use case. Additionally, unplugging and reconnecting 12 or more sensors is not an acceptable solution for our customers, even if their operators to have access to the machine. I'd hate to write that into our user documentation.

Having that many cameras attached to a single PC is not usually ideal unless it is a powerful enterprise-grade PC rather than a consumer desktop one.  This is because each camera added in a multi-camera setup causes resources to be consumed.  For example, in a single-PC setup where 4 cameras were connected, a PC with an i7 processor would be recommendable in order to cope with the strain on the hardware.
As you said though, your application is working fine when the cameras are all detectable, so it doesn't sound as though the hardware spec is a problem for you.
My personal hunch for the problem would be a power instability on the USB port, causing the camera connection to drop and making it undetectable / unactivatable.  RealSense cameras are sensitive to the state of the USB port.  If a hub was being used, a mains electricity powered hub can increase stability of power on USB ports.
If the system can see up to 7 cameras of the 12 every single time though after a reboot of the PC and it is never more or less than 7, that would suggest that something other than USB power instability is happening.
It is midnight now in my time zone, so I have to leave off for now, unfortunately.  If someone else does not comment on your case before then, I will be happy to pick up the case when I am back in 7 hours time if you leave a comment below.  Thanks!

Good morning, Marty!
The hardware isn't the problem; everything you said about PC resource consumption is correct, including power draw. We're an OEM with a major PC manufacturer and work with their R&D unit to test bus/bridge performance and so forth. We also have a power electronics team and are capable of measuring the power draw from each camera individually and the entire array of cameras as a whole. We are certain that all cameras are adequately powered and are otherwise not lacking for bandwidth or resource.
I think this is a bug in the driver.

Disconnection issues have occurred with RealSense cameras even on enterprise servers with very high watt PSUs.  So it is not so much a matter of the camera's power draw as a power frequency glitch on the port.  Not all USB ports are made equal despite there being a USB specification, and so a camera that works fine on one make of PC may not work properly on another manufacturer's PC.
The quality grade of USB cable used can also be a factor in stability.  Unless a high grade cable such as an industrial grade one is used, the longer the cable is then the higher the chance of instability.   On an ordinary cheap cable, I would not have expectations of the camera working on a cable longer than 2 meters.
Having said all that, I have not personally dealt with setups larger than about 6 cameras, so one of the Intel staff on this forum such as @dorodnic may be able to advise you better on this subject.

Right, however the bug, as described in the original message, manifests following a hardware reset of all the cameras which we invoke using the API. We are not discussing intermittent dropping of cameras, to your note about power line conditioning. I do not believe that we have power issues, as the systems are able to perform at peak for hours at a time under normal use.
The bug relates to the dropping of cameras specifically following a hardware reset. It seems as though the cameras briefly disconnect, and sometimes not all of the cameras reconnect. Under which circumstance the only remedy is seemingly to unplug and reconnect them.
@dorodnic, any support your able to offer would be most appreciated.

Hi @evercoast-dev,
In the scenario of camera dropping (disappearing) after calling the hardware_reset(), is the total number of cameras show up correctly on the USB bus? Can you share the result of the lsusb?
Perform a firmware upgrade is also strongly recommended to upgrade the latest firmware version and see if the problem persists as well as take advantages of other fixes.
https://downloadcenter.intel.com/download/28724/Latest-Firmware-for-Intel-RealSense-D400-Product-Family

OK, here we go.  Is it plugged in?
Thanks!

What is the length(s) of the USB cable used for these cameras? Just for testing purpose, is there any improvement or difference by using the 1 M USB cable that comes with the camera?

Often times we notice that when cameras "go missing" that a reboot is likely to fix the problem. However, infrequently, but often enough that we're posting a bug report, it happens that some cameras remain inactive following a reboot. It's then that the unplug/reconnection is necessary.
Regarding cable length, it's not really viable to get that many cameras plugged in using only the supplied cable. But, I can say that we do normally operate without dropping frames on all cameras simultaneously. Also, our USB extensions are professional quality.

I am just wondering if there's any update/potential fix that you might have discovered to workaround the issue?
Thank you.

Closing the ticket. Please feel free to reopen if problem remains.
Thank you.

This issue is very persistent and why is it closed?
It is so easily reproducible by plugging and unplugging real sense multiple times and the camera devices are no more detected.
Some times I see /dev/video0, /dev/video1 only mounted, sometimes only one of them is mounted and sometimes nothing at all. Restarting the PC fixes it but definitely is not the solution. Please reopen this issue.

@Ashok93  An issue may be closed by RealSense team members if no further comments are received on the subject for 3 or 4 weeks and it does not have a subject that requires keeping it open for long-term tracking.  Closed subjects are still findable by web search.
In this particular case, improvements to multicam support were released in the latest 2.35.2 SDK version.  The changes may not correct every multicam problem (such as ones related to specific USB hub models) but it may help if the problem is related to the rs2::pipeline.  If you are able to use 2.35.2 then I encourage you to try it and see if it resolves your need to unplug and replug cameras.


refactors test skipping and fixes remaining tests

Yes it's a little strange to submit a PR for a PR, but what the hell. Here's what I came up with to make these tests pass.
I also pulled this down and ran them through the Google API client tests, and they all passed (for Guzzle 5). WOOHOO!

aborting in favor of submitting this from bshaffer fork


[CORE] Bump scalawarts version to prepare for Scala 2.13 support

Bump scalawarts version to prepare for Scala 2.13 support
Fix missing case-class inheritance check for shim layer code
Minor fixes for gluten-it

@zzcclp This PR should make scalawarts work for 2.13

Run Gluten Clickhouse CI

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

remove wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass from pom.xml, it works fine.

Which PR are you using to add 2.13 support? Or it's a internal mission?

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

remove wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass from pom.xml, it works fine.

Which PR are you using to add 2.13 support? Or it's a internal mission?

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

remove wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass from pom.xml, it works fine.

Which PR are you using to add 2.13 support? Or it's a internal mission?

It's in my repo: https://github.com/zzcclp/gluten/tree/support_spark35_scala213, you can try it.

Run Gluten Clickhouse CI

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

remove wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass from pom.xml, it works fine.

Which PR are you using to add 2.13 support? Or it's a internal mission?

With this pr, compile with command mvn clean package -Pbackends-clickhouse -Phadoop-3.3 -Pspark-3.5 -Pscala-2.13 -Pceleborn -Dhadoop.version=3.3.1 -DskipTests -Dcheckstyle.skip, it causes the below error:
[ERROR] error: bad option: -P:wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass

remove wartremover:traverser:io.github.zhztheplayer.scalawarts.InheritFromCaseClass from pom.xml, it works fine.

Which PR are you using to add 2.13 support? Or it's a internal mission?

It's in my repo: https://github.com/zzcclp/gluten/tree/support_spark35_scala213, you can try it.

@zzcclp I've opened https://github.com/zzcclp/gluten/pull/4 which should get things work.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_6154_time.csv
log/native_master_06_19_2024_27c32f1b15_time.csv
difference
percentage

q1
36.33
34.61
-1.716
95.28%

q2
23.78
25.46
1.686
107.09%

q3
40.25
38.59
-1.655
95.89%

q4
32.43
33.98
1.551
104.78%

q5
70.15
70.97
0.821
101.17%

q6
6.68
6.54
-0.137
97.94%

q7
83.88
85.08
1.204
101.44%

q8
85.01
87.11
2.108
102.48%

q9
121.23
123.67
2.442
102.01%

q10
46.35
44.85
-1.501
96.76%

q11
20.58
20.56
-0.022
99.89%

q12
25.50
27.28
1.781
106.98%

q13
40.93
39.58
-1.347
96.71%

q14
20.01
18.81
-1.195
94.03%

q15
32.21
33.35
1.139
103.54%

q16
14.10
14.28
0.178
101.26%

q17
104.55
105.60
1.045
101.00%

q18
149.20
144.60
-4.592
96.92%

q19
13.86
13.77
-0.095
99.32%

q20
29.18
29.04
-0.133
99.54%

q21
264.89
265.23
0.336
100.13%

q22
12.30
12.88
0.574
104.66%

total
1273.39
1275.86
2.473
100.19%


HTML5 section shows alert instead of SVG illustration

When the HTML5 validator has no errors found, it shows an alert with "no data found" instead of the "success" SVG illustration.

Fixed by #16


Expert bot side not showing list of tickets

I noticed that the bot is not registering the tickets for user to search for.

This is from the Expert's channel side, which I understand is where I can open and manage it, however it's not case

@jonnunez Thanks for your feedback, however this is not a bug. This is part of expected behavior - when you are using the experts app in a personal scope, yes you do have access to the messaging extension. However, since the messaging extension works in a Team only, you won't be able to view the tickets in a personal scope


build: update Build ready to publish to AWS Code Artifact

Gradle to 6.8.3
ready to publish to AWS Code Artifact
see: https://metadata.atlassian.net/browse/EX-4472

I don't have write access either. Maybe @davidmilward ?


Style Review Template

As a student, I want to practice code style reviewing so that the style of the code for issue #6 meet specifications
Note, #6 should be complete (not closed) before work proceeds with this issue.

Developer walks through the code with assignees
Copy css and html files in project to W3 Validator Tool and verify no errors are returned

[create bug issues if necessary]

#8 issue created
bug 2 issue created
...
bug n issue created

code style reference

Reviewed to make sure that the code style was neat and clean and easy to read.

update test


[WIP] add Quantum Kernel and Quantum Kernel Training benchmarks

Summary
Implementation of the benchmarks methods for QuantumKernel and QuantumKernelTrainer.
Details and comments
These codes are developed in the project of QAMP22 (mentor @a-matsuo, mentee Leonardo Placidi).
----We are still figuring out the AVS implementation/running of the benchmark.----

@adekusar-drl or @dlasecki could you give me "workflow approval", so I can check what problems my code gives? Sorry for the disturb!

Done. You can run the checks locally. Things like black, pylint, etc easier to run on your machine.

This PR adds a benchmarks folder at root with some benchmark sample. This shouldn't be in this repo as it is supposed to run the applications benchmarks under their folders and not a global benchmark. This folder with its contents should be removed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: Gruntrexpewrus:x: manoelmarques:x: a-matsuoYou have signed the CLA already but the status is still pending? Let us recheck it.


Date comparison fix to prevent disabling the following day

Problem: Currently, the isInvalidDate method is disabling the incorrect day, usually the day after the one configured. This happens due to the presence of time information in the dates, which affects the comparison, along with potential timezone issues.
Solution:
Implicit Time Fix: To avoid date comparison issues with different times, use the .startOf('day') method when comparing the dates in the momentDatesArray and the date being checked. This ensures that the comparison is done only at the day level, ignoring hours, minutes, and seconds.
Correction example:
isInvalidDate: (date) => {
    return momentDatesArray.some(disabledDate =>
        disabledDate.startOf('day').isSame(date.startOf('day'), 'day')
    );
},

Timezone Adjustment: If the dates in the array or the ones being compared are in different time zones, it can cause the wrong days to be disabled. The solution is to ensure all dates are in the same timezone by using .utc() to align the comparison.
Timezone correction example:
isInvalidDate: (date) => {
     return momentDatesArray.some(disabledDate =>
         disabledDate.utc().startOf('day').isSame(date.utc().startOf('day'), 'day')
     );
 },

Conclusion: These changes ensure that the isInvalidDate method works correctly, comparing only the day and disabling the correct date, regardless of time or timezone.

Thanks


[v2.7] KDM Update for K8s April patch release

KDM Updates
TO BE RELEASED: Enabled OOB post Rancher v2.7.2

New Kubernetes Version
Min Rancher Version
Min RKE Version

1.25.9-rancher1-1
2.7.2-patch0
1.4.0-rc0

1.24.13-rancher1-1
2.6.7-patch0
1.3.13-rc0

Rancher System Images & Add-ons
Note: Please update system images and add-ons in the template as needed.
TBD
Developer Changelog

Add templates for new K8s versions. If a template that hasn't been released yet already exists, update it in place.
Update the default K8s version, and add or update the version information (MinRancherVersion and MinRKEVersion) in k8s_version_info.go for new K8s versions if needed (Use table from above).
Confirm versions for system images, add-on templates are correct using versioning reference table from below (expand details to view the table). Update the table if new versions are introduced.
Confirm add-on template version constraints in template.go are correct using versioning reference table from below (expand details to view the table). Update the table if needed.

Versioning Reference

Expand for system images & add-on templates versioning table

Note: Truncated repository names with a * indicates there are multiple images with that prefix. All repository names that match a truncated prefix should be checked for the same version stated in the table.
For example: rancher/weave-* matches weaveworks/weave-kube and weaveworks/weave-npc, and they should both have the same version.
v1.25.9-rancher1-1

Repository
Tag

rancher/mirrored-coreos-etcd
v3.5.4

rancher/hyperkube
v1.25.9-rancher1

rancher/rke-tools
v0.1.87

rancher/mirrored-k8s-dns-*
1.22.8

rancher/mirrored-cluster-proportional-autoscaler
1.8.6

rancher/mirrored-coreos-flannel
v0.15.1

rancher/flannel-cni
v0.3.0-rancher7

rancher/mirrored-calico-*
v3.24.1

weaveworks/weave-*
2.8.1

noiro/* (All ACI images)
<IP_ADDRESS>.1d150da

rancher/mirrored-pause
3.6

rancher/nginx-ingress-controller
nginx-1.2.1-rancher1

rancher/mirrored-nginx-ingress-controller-defaultbackend
1.5-rancher1

rancher/mirrored-jettech-kube-webhook-certgen
v1.1.1

rancher/mirrored-metrics-server
v0.6.2

rancher/mirrored-coredns-coredns
1.9.4

rancher/mirrored-cluster-proportional-autoscaler
1.8.6

rancher/kubelet-pause
v0.1.6

rancher/mirrored-k8s-dns-node-cache
1.22.10

Add-on Name
Add-on Template Version Constraint

Calico
calicov319

Canal
canalv319

Flannel
flannelv115

CoreDNS
coreDnsv183

KubeDNS
kubeDnsv116

MetricsServer
metricsServerv050

Weave
weavev120

Aci
aciv500

NginxIngress
nginxIngressv110Rancher3

Nodelocal
nodelocalv121

v1.24.13-rancher1-1

Repository
Tag

rancher/mirrored-coreos-etcd
v3.5.4

rancher/hyperkube
v1.24.13-rancher1

rancher/rke-tools
v0.1.87

rancher/mirrored-k8s-dns-*
1.21.1

rancher/mirrored-cluster-proportional-autoscaler
1.8.5

rancher/mirrored-coreos-flannel
v0.15.1

rancher/flannel-cni
v0.3.0-rancher6

rancher/mirrored-calico-*
v3.22.0

weaveworks/weave-*
2.8.1

noiro/* (All ACI images)
<IP_ADDRESS>.1d150da

rancher/mirrored-pause
3.6

rancher/nginx-ingress-controller
nginx-1.2.1-rancher1

rancher/mirrored-nginx-ingress-controller-defaultbackend
1.5-rancher1

rancher/mirrored-jettech-kube-webhook-certgen
v1.1.1

rancher/mirrored-metrics-server
v0.6.1

rancher/mirrored-coredns-coredns
1.9.3

rancher/mirrored-cluster-proportional-autoscaler
1.8.5

rancher/kubelet-pause
v0.1.6

rancher/mirrored-k8s-dns-node-cache
1.21.1

Add-on Name
Add-on Template Version Constraint

Calico
calicov319

Canal
canalv319

Flannel
flannelv115

CoreDNS
coreDnsv183

KubeDNS
kubeDnsv116

MetricsServer
metricsServerv050

Weave
weavev120

Aci
aciv500

NginxIngress
nginxIngressv110Rancher3

Nodelocal
nodelocalv121

/backport v2.6-KDM-April-2023-patches

Fresh install checks - PASS

On rancher version v2.7.2, KDM pointing to dev-v2.7-2023-04-patches, cluster creation succeeds for v1.25.9-rancher1-1on all network providers - canal/flannel/weave/calico.
Network checks look good
Canal network checks look good

Upgrade checks - PASS

On rancher v2.7.2, KDM pointing to release-v2.7, cluster creation succeeds for v1.25.6-rancher4-1 with all network providers.
Pre-upgrade checks look good.
Changed the KDM to point to dev-v2.7-2023-04-patches branch.
Upgraded k8s version to v1.25.9-rancher1-1.
Post upgrade checks look good.

RKE default k8s version - PASS
dev-v2.7-2023-04-patches, should have the default as v1.25.9-rancher1-1
 "RKEDefaultK8sVersions": {
  "0.3": "v1.16.3-rancher1-1",
  "default": "v1.25.9-rancher1-1"

Validated following scenarios for kubelet version - PASS

On rancher v2.7.2, KDM pointing to dev-v2.7-2023-04-patches, provisioned k8s v1.25.9-rancher1-1 cluster.
Cluster came Active with all the pods up and running
Validated node version :

Using kubectl :
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.9", GitCommit:"a1a87a0a2bcd605820920c6b0e618a8ab7d117d4", GitTreeState:"clean", BuildDate:"2023-04-12T12:08:36Z", GoVersion:"go1.19.8", Compiler:"gc", Platform:"linux/amd64"}

> kubectl get nodes
NAME               STATUS   ROLES          AGE   VERSION
ip-172-31-11-239   Ready    etcd           17m   v1.25.9
ip-172-31-13-175   Ready    controlplane   17m   v1.25.9
ip-172-31-4-191    Ready    worker         15m   v1.25.9
ip-172-31-5-212    Ready    worker         14m   v1.25.9

Kubelet logs :
"Kubelet version" kubeletVersion="v1.25.9"
Node yaml :
  nodeInfo:
    kubeProxyVersion: v1.25.9
    kubeletVersion: v1.25.9

On UI :
On UI as well correct version is present

RKE checks passed with RKE v1.4.5-rc1 for k8s version v1.24.13-rancher2-1 and v1.25.9-rancher2-1.

Since all the tests passed, closing this issue.


Insert null after update

Hi Nick
I hope you are well.
I have a problem here where when I insert a record the Insert and Update Columns gets set and all is fine
When I do an update the Update Column is set but the Insert column get sets to null
`public abstract class Trackable
{
public virtual DateTime? Inserted { get; private set; }
public virtual DateTime? Updated { get; private set; }
    static Trackable()
    {
        Triggers<Trackable>.Inserting += entry => entry.Entity.Inserted = entry.Entity.Updated = DateTime.Now;
        Triggers<Trackable>.Updating += entry => entry.Entity.Updated = DateTime.Now;
    }
}`

#region If you're targeting EF 6
        public override int SaveChanges()
        {
            return this.SaveChangesWithTriggers(base.SaveChanges);
        }
        public override async Task<int> SaveChangesAsync(CancellationToken cancellationToken)
        {
             return await this.SaveChangesWithTriggersAsync(base.SaveChangesAsync, cancellationToken);
        }

        #endregion

public class PerformanceReviewMaster: Trackable
   {
       [Required,Key]
       public Guid PerformanceReviewMasterId { get; set; }
       [Required]
       public string Description { get; set; }
       [Required]
       [DataType(DataType.Date)]
       public DateTime StartDate { get; set; }
       [Required]
       [DataType(DataType.Date)]
       public DateTime EndDate { get; set; }

   }

I forget to mention I'm on ver 6.08 when trying to upgrade to 6.1 I get
: Could not install package 'EntityFramework.TypedOriginalValues 1.1.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5', but the package does not contain any assembly references or content

Man I hope you can help me I'm 99.9% finished with a 6 month project and I realise this at the last minute

Hi Anton,
That is strange indeed. I can help you tonight once I'm home from work. I hope that's ok for you time-wise.
Nick

Hi Nick
Thanks for getting back to me.
No problem. I'll wait up for you for it is 21:30 here in South Africa

Hi Anton,
I stopped supporting .net 4.5 at the 6.1 release. Is there a chance you can quickly re-target your project to .NET Framework 4.6.1?

I pushed a EF.TRiggers 6.1.1 with some small fixes to mistakes I made in the package and one of its dependencies. no code changes though. Please let me know if upgrading to 6.1.1 fixes your null insert issue or not.

Done targeting 4.6.1 and Upgraded to 6.1.1 but still having  the same problem

So I just made a new .NET 4.6.1 console application, installed EntityFramework.Triggers 6.1.1 and ran this code in DEBUG build with no errors, running as expected. Can you try this on your machine?
using System;
using System.ComponentModel.DataAnnotations;
using System.Data.Entity;
using System.Diagnostics;
using EntityFramework.Triggers;

namespace EfTriggersIssue21
{
	class Program
	{
		static void Main(string[] args)
		{
			using (var context = new Context())
			{
				var performanceReviewMaster = new PerformanceReviewMaster()
				{
					PerformanceReviewMasterId = Guid.NewGuid(),
					Description = "test",
					StartDate = new DateTime(1950, 1, 1),
					EndDate = new DateTime(1950, 1, 1)
				};
				context.PerformanceReviewMasters.Add(performanceReviewMaster);
				context.SaveChanges();
				Debug.Assert(performanceReviewMaster.Inserted != null);
				Debug.Assert(performanceReviewMaster.Updated != null);
				performanceReviewMaster.Description = "change";
				context.SaveChanges();
				Debug.Assert(performanceReviewMaster.Inserted != null);
				Debug.Assert(performanceReviewMaster.Updated != null);
			}
		}
	}

	class Context : DbContextWithTriggers
	{
		public virtual DbSet<PerformanceReviewMaster> PerformanceReviewMasters { get; set; }
	}

	public abstract class Trackable
	{
		public virtual DateTime? Inserted { get; private set; }
		public virtual DateTime? Updated { get; private set; }

		static Trackable()
		{
			Triggers<Trackable>.Inserting += entry => entry.Entity.Inserted = entry.Entity.Updated = DateTime.Now;
			Triggers<Trackable>.Updating += entry => entry.Entity.Updated = DateTime.Now;
		}
	}

	public class PerformanceReviewMaster : Trackable
	{
		[Required, Key]
		public Guid PerformanceReviewMasterId { get; set; }

		[Required]
		public string Description { get; set; }

		[Required]
		[DataType(DataType.Date)]
		public DateTime StartDate { get; set; }

		[Required]
		[DataType(DataType.Date)]
		public DateTime EndDate { get; set; }

	}
}

Hi Nick
Thanks for your help. Your code ran as expected. The problem actually comes in with MVC with code first where the Insert and Update get mapped through migration. Sorry man this is so obvious. Feel like a dumbass for not seeing it earlier.
Thanks Again for your help.


fix release branch styles 2.2.4

Codecov Report

Merging #289 (648bc60) into release-2.2.4 (c924a88) will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-2.2.4     #289   +/-   ##
==============================================
  Coverage          10.31%   10.31%
==============================================
  Files                521      521
  Lines              37777    37776    -1
  Branches            1031     1031
==============================================
  Hits                3895     3895
+ Misses             33453    33452    -1
  Partials             429      429

Impacted Files
Coverage Δ

...nager/components/BivariatePanel/BivariatePanel.tsx
0.00% <ø> (ø)

2 biv icons

wow...
thanks! good think i've did a PR


Accessing pinocchio model to obtain frameId

Hello!
I am using the pip method to build my project. Building the same project using jiminy from source would work, but now whenever I try to access the pinocchio model I get a segmentation fault. I am attaching a slightly modified version of the example pip_extension/double_pendulum.cc
Whenever I uncomment line 38:
  //auto Frame_id = robot->pncModel_.getFrameId("PendulumArm");
I get the segmentation fault. Am I using an outdated way to get the FrameId?
Thanks!
pip_extension.zip

I am attaching the bt

Hum... I will have a look asap, but so far it looks like a mismatch between the Pinocchio version used for compiling and the one imported at runtime using dynamic linkage.

Ok it is running on my computer. So I think it is because there is a mismatch between the jiminy release you are using and the installed version of pinocchio. I should probably enforce the same version in cmake to avoid this kind of misleading issues.


Using Explicit calls to the bot instead of implicit

I've noticed when having conversations using the BibleBot that it's good to introduce the actual text into the conversation, but I think explicit calls might be better because once the verses are introduced, people usually don't want the text again even if they mention the verses again.
I think perhaps having the bot's name @mention'd should trigger it.  This way you can introduce text into the conversation only when you want it.
Adding markup to define an explicit mention would be another way.  Perhaps eventually we could have both... if you @mention the bot it will try to display any verse it finds, otherwise, it will just look for the markup characters

I won't do this, because:

convenience
the method of conversation that would be required for the bot to be "annoying" implicitly

To expound on 2, no one converses like this:
"a: hello i love Genesis 1:1"
"b: in the beginning, eh?"
"a: yep, good ol Genesis 1:1"

for number one, who's convenience are you talking about?
for number two, that's really a strawman, people really do recite the verse when they are having theological dialogue about it, especially when they bring up several verses and then recite one of them to expound or reiterate a point.  I've seen it happen.  I've done it!

If it becomes a major issue, then I'll deal with it. Until then, the bot is staying implicit.

ok


NullReferenceException when calling InterimChangeSet.All.First().ouboundleg

Calling the new methods with the interim results callback:
Task<List<Itinerary>> QueryFlight(FlightQuerySettings flightQuerySettings, Action<InterimChangeSet<Itinerary>> interimResultCallback);
Returns an InterimChangeSet<Itinerary> as epected. However - drilling into the Itinerary properties, like in- and outboundlegs, results in a NullReferenceException.
I've found the problem and I'm preparing a pull-request.

Tested and works for us. Thanks


Issue #SB-13653 fix: Telemetry events are generating for offline download-manager

@anoophm  do a high level review and let me know

@harishgilimi
Onclick of download-manager to close :
Telemetry Events  {"eid":"INTERACT","ets":1565934303848,"ver":"3.0","mid":"INTERACT:b2565f36c750fb46b3afa7a10b3a3976","actor":{"id":"3075dfa43b760f0ce8c21e52762d2040","type":"User"},"context":{"channel":"505c7c48ac6dc1edc9b08f21db5a571d","pdata":{"id":"local.sunbird.desktop","ver":"2.0","pid":"sunbird-portal"},"env":"offline","sid":"1a0f4752-d9ca-15f0-aaac-6733070e3718","did":"3075dfa43b760f0ce8c21e52762d2040","cdata":[],"rollup":{"l1":"505c7c48ac6dc1edc9b08f21db5a571d"}},"object":{},"tags":["505c7c48ac6dc1edc9b08f21db5a571d"],"edata":{"id":"download-manager-close","type":"click","pageid":"download-manager"}}
Onclick of download-manager to open :
Telemetry Events  {"eid":"INTERACT","ets":1565934307673,"ver":"3.0","mid":"INTERACT:d942b8207b2c2cc6ff34687a759811f5","actor":{"id":"3075dfa43b760f0ce8c21e52762d2040","type":"User"},"context":{"channel":"505c7c48ac6dc1edc9b08f21db5a571d","pdata":{"id":"local.sunbird.desktop","ver":"2.0","pid":"sunbird-portal"},"env":"offline","sid":"1a0f4752-d9ca-15f0-aaac-6733070e3718","did":"3075dfa43b760f0ce8c21e52762d2040","cdata":[],"rollup":{"l1":"505c7c48ac6dc1edc9b08f21db5a571d"}},"object":{},"tags":["505c7c48ac6dc1edc9b08f21db5a571d"],"edata":{"id":"download-manager-open","type":"click","pageid":"download-manager"}}
Onclick of content in  download-manager :
Telemetry Events  {"eid":"INTERACT","ets":1565934308733,"ver":"3.0","mid":"INTERACT:62f640ce169347f3205818289e100349","actor":{"id":"3075dfa43b760f0ce8c21e52762d2040","type":"User"},"context":{"channel":"505c7c48ac6dc1edc9b08f21db5a571d","pdata":{"id":"local.sunbird.desktop","ver":"2.0","pid":"sunbird-portal"},"env":"offline","sid":"1a0f4752-d9ca-15f0-aaac-6733070e3718","did":"3075dfa43b760f0ce8c21e52762d2040","cdata":[],"rollup":{"l1":"505c7c48ac6dc1edc9b08f21db5a571d"}},"object":{"id":"do_312533296244498432218923","type":"Resource","ver":"2","rollup":{}},"tags":["505c7c48ac6dc1edc9b08f21db5a571d"],"edata":{"id":"content-click","type":"click","pageid":"download-manager"}}

@harishgilimi @vinukumar-vs I have reviewed the pr. Please check and merge this pr.


Fix user resources

GetUserResources seems to be missing a query param and using that method yields:
Request .query should NOT have additional properties.
returned by the API.
I think this is the missing part of the API call.

Definitely is. Thanks for finding that.


RegexSet and Regex give different results for the same pattern in 1.9

What version of regex are you using?
1.9.3. The issue is present in regex 1.9.0 and later.
Describe the bug at a high level.
RegexSet::new([r"(?m)^ *v [0-9]"]).unwrap().is_match("v 0") incorrectly returns false in version 1.9.0 and later.
It returns true in 1.8.4.
It returns true if I use a Regex instead of a RegexSet.
What are the steps to reproduce the behavior?
fn main() {
    let pattern = r"(?m)^ *v [0-9]";
    let text = "v 0";

    let re = regex::Regex::new(pattern).unwrap();
    println!("re is: {re:?}");
    println!("{}", re.is_match(text)); // true (correct)

    let rs = regex::RegexSet::new([pattern]).unwrap();
    println!("rs is: {rs:?}");
    println!("{}", rs.is_match(text)); // false (incorrect)
}

(playground link)
What is the actual behavior?
re is: Regex("(?m)^ *v [0-9]")
true
rs is: RegexSet(["(?m)^ *v [0-9]"])
false

What is the expected behavior?
The last line should be true.

One interesting bit here is that while is_match returns false, matches(..).matched_any() returns true!
fn main() {
    env_logger::init();
    let pattern = r"(?m)^ *v [0-9]";
    let text = "v 0";

    let rs = regex::RegexSet::new([pattern]).unwrap();
    println!("rs is: {rs:?}");
    println!("{}", rs.is_match(text)); // false (incorrect)
    println!("{}", rs.matches(text).matched_any()); // true!
}

This is fixed in regex 1.9.4 and regex-automata 0.3.7 on crates.io. See #1072 for the details about what caused this. Nice find and thank you for the report!

obviously, killing it here. just wow. i don't have the words


Fresh install after upgrading to creator update

Hi,
Thanks for this aweome feature! 👍
I tried BashOnWindows on the anniversary release. Unfortunately, it was almost impossible to use it for development (eg : issue with nodeJS).
Recently, I removed  bashOnWindows from the windows features and I upgrade from anniversary to Creator update.
Unfortunately, I'm able to found old packages install. I'd like to have a fresh install withtout any package installed. How to proceed ?
Details :

Your Windows build number: Microsoft Windows [version 10.0.15063]

What you're doing and what's happening:  When I'm typing "node", I found the node version installed before unistall of the bashOfWindows feature (and after the upgrade)

What's wrong / what should be happening instead: I'd like to have a clean linux installation without any packages installed

You can remove the old user mode bits by using lxrun.exe /uninstall

perfect, thanks


Create DESIGN-UX-PHILOSOPHY.md

Add comprehensive Design and UX Philosophy documentation to guide and standardize frontend development practices.

#91

@CFIALeronB lines are not wrapped at 80. This seems to be a reoccurring problem with the IDE setup; how do we ensure that all markdown files wrap correctly all the time and that the situation is fixed before a PR is created for all developers?


are the basemaps/downloads displaced?

I'm using this area of interest https://drive.google.com/file/d/1Nh9wPB_vP4cDtQ87i8Ll9N03_fus1E8Q/view?usp=sharing to download a basemap from January 2022, however, it seems like the downloaded asset is pointing to a different location. I've tested comparing with a global basemap + planet analytics product but the displacement is the same.
Is the app doing a reprojection process? do you mind testing on your side?

The downloading of images is effectively a pain as Planet use a specific gridding system (https://github.com/sepal-contrib/planet-order/blob/0f93013fc0b0abc7f6e431827a7ec17c47ba1da1/component/scripts/mapping.py#L84). I'm surprised because normally I reproject the AOI in 3857 before doing anything.
I'll test your AOI from my end to figure it out.
Thank you for reporting

Did projecting the images worked ?

No, the test I made didn't work when reprojecting.

I checked with the latest release and the images are well placed on the map with QGIS:

feel free to reopen if you fance this issue again (note that sometimes the images provided by planet are the issue so you need to report to them directly using their user report tool)


[markuplm] Unable to use with Huggingface

Describe the bug
Model: markuplm

The problem arises when using:

[x] the official example scripts: (give details below)

A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
pip install transformers
# Or main source code "git clone https://github.com/huggingface/transformers && cd transformers && pip install ."

from transformers import AutoTokenizer, MarkupLMForPretraining

tokenizer = AutoTokenizer.from_pretrained("microsoft/markuplm-large")

model = MarkupLMForPretraining.from_pretrained("microsoft/markuplm-large")

ValueError: Tokenizer class MarkupLMTokenizer does not exist or is not currently imported.

Expected behavior
A clear and concise description of what you expected to happen.
The tokenizer and model are properly loaded.

Platform: Google Colab

Python version:

PyTorch version (GPU?):

Now MarkupLM is not supported by the package transformers of huggingface, so you can only use it by downloading our source code. We will work on it to make MarkupLM appear on transformers soon.

Hi,
I've added MarkupLM to Transformers here: https://github.com/NielsRogge/transformers/tree/modeling_markuplm/src/transformers/models/markuplm
However, I've not opened a PR yet, as I'd like to have a MarkupLMTokenizer (similar to LayoutLMv2Tokenizer), that allows to prepare all data for the model (rather than only tokenizing text).
Feel free to work further on my branch.

@NielsRogge Thanks for adding MakupLM into the great transformers library! We have add a processor for MarkupLM like LayoutLMv2Processor as you required, and opened a PR under your branch. However this implementation is not so complete as we are not familiar with all the apis in transformers. We would appreciate it very much if you can kindly help us improve and officially release it.

@NielsRogge Any updates for adding MarkupLM to Transformers?

@NielsRogge you are amazing. Thank you for this!

MarkupLM is now part of the Transformers library, feel free to close this issue :)

Docs: https://huggingface.co/docs/transformers/model_doc/markuplm

Demo notebooks: https://github.com/NielsRogge/Transformers-Tutorials/tree/master/MarkupLM


How to hide seconds?

Show 09:00 instead of 09:00:00?

What type of browser are you using, it is without seconds by default !?
Attach a photo as well so I can see when this happens.

Mozilla Firefox latest version.

Any update on this?

By Default, it does not have seconds:
You Need to Set Format in Model Cast Like Below, maybe it can fix it:
 protected $casts = [
        'start_time' => 'datetime:H:i:s',
        'end_time' => 'datetime:H:i:s',
 ];


Add variable support for user-defined resolver templates.

Issue #, if available:
Add variable support for user-defined resolver templates.
Pertains to #2092, #1946, maybe others.
Description of changes:
Preface: My changes are only 50 or so lines of code, but the linting husky process re-indented nearly the entire file, so apologies for what looks like a large code-change.
Certain resolver files depend on environment-specific variables, especially for
DynamoDB operations like BatchGetItem, where table references are required.
Since table names are dependent on the environment, user may now use 3 tokens
within the file that will resolve to their environment-specific values:
{{env}}: Environment name (Ex: develop, master)
{{apiId}}: GraphQLApiIdOutput (ex: shxxxvihabcj5hswrhxxxxxxxx)
{{apiIdEnv}}: Convenience method matching DynamoDB table name convention (ex: shxxxvihabcj5hswrhxxxxxxxx-develop)
With these tokens, you can now do something like:
ExampleObject.fieldName.req.vtl
#set($ids = [])
#foreach($id in ${ctx.source.userIds})
#set($map = {})
$util.qr($map.put("id", $util.dynamodb.toString($id)))
$util.qr($ids.add($map))
#end
{
"version" : "2018-05-29",
"operation" : "BatchGetItem",
"tables" : {
“ExampleTableName-{{apiIdEnv}}“: {
"keys": $util.toJson($ids),
"consistentRead": true
}
}
}

It would be nice to open this up to more replacement possibilities in the future, like being able
to use Cloudformation parameters, etc.
I welcome feedback if this is not an appropriate way to solve this challenge, but it seems useful to my workflow in that my resolvers adapt to the environment I'm in. Thanks!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry for the large indentation change, husky did it. If you'd rather me push only my changes without pretty-quick running, I can do that, unless you're good with ignoring white-space changes while you review.

Codecov Report

Merging #2539 into master will decrease coverage by 2.2%.
The diff coverage is 0.36%.

@@            Coverage Diff             @@
##           master    #2539      +/-   ##
==========================================
- Coverage   65.33%   63.12%   -2.21%
==========================================
  Files         196      200       +4
  Lines        9735     9986     +251
  Branches     1877     1933      +56
==========================================
- Hits         6360     6304      -56
- Misses       3099     3404     +305
- Partials      276      278       +2

Impacted Files
Coverage Δ

.../graphql-transformer-core/src/util/amplifyUtils.ts
5.46% <0.36%> (-0.43%)
:arrow_down:

packages/graphql-auth-transformer/src/resources.ts
87.8% <0%> (-1.31%)
:arrow_down:

...ib/S3AndCloudFront/helpers/configure-CloudFront.js
94.49% <0%> (-0.38%)
:arrow_down:

...aphql-auth-transformer/src/ModelAuthTransformer.ts
90.83% <0%> (-0.24%)
:arrow_down:

...es/graphql-dynamodb-transformer/src/definitions.ts
85% <0%> (ø)
:arrow_up:

...osting/lib/S3AndCloudFront/helpers/file-scanner.js
78.57% <0%> (ø)
:arrow_up:

packages/amplify-category-xr/commands/xr.js
0% <0%> (ø)
:arrow_up:

...ync-simulator/src/mqtt-server/abstract-listener.ts

...amplify-appsync-simulator/src/server/operations.ts

...sync-simulator/src/velocity/value-mapper/mapper.ts

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de3845...b8d575c. Read the comment docs.

@kevcam4891 No worries we're facing this with our own PRs. Please rebase on master, run pretty quick on the file you're changing, create a commit, apply changes, commit. That way by reviewing just that commit makes the whole review easier IMHO.

@attilah That's a great idea, thanks for the prescription. I'll make those changes.

This is not working for me! I have tried this on my VTL but it couldn't reference apiIdEnv.
`#set($axioBedRoomsData = [])
#foreach($item in ${ctx.args.axioBedRoomItems})
$util.qr($item.put("id", $util.defaultIfNull($item.id, $util.autoId())))
$util.qr($axioBedRoomsData.add($util.dynamodb.toMapValues($item)))
#end
{
"version" : "2018-05-29",
"operation" : "BatchPutItem",
"tables" : {
"PIByBedroomTypeAxioUnitMixFile-{{apiIdEnv}}": $utils.toJson($axioBedRoomsData)
}
}`
What I am missing

This is not working for me! I have tried this on my VTL but it couldn't reference apiIdEnv.
`#set($axioBedRoomsData = [])
#foreach($item in ${ctx.args.axioBedRoomItems})
$util.qr($item.put("id", $util.defaultIfNull($item.id, $util.autoId())))
$util.qr($axioBedRoomsData.add($util.dynamodb.toMapValues($item)))
#end
{
"version" : "2018-05-29",
"operation" : "BatchPutItem",
"tables" : {
"PIByBedroomTypeAxioUnitMixFile-{{apiIdEnv}}": $utils.toJson($axioBedRoomsData)
}
}`
What I am missing

Can we get some confirmation/documentation on this?


Change the namespace dapr-shared runs in?

I tried to install the helm chart using a different namespace. Everything installed, but it was not able to come up because it could not find the configmap.
'Error: configmap "dapr-shared-cm" not found'
I investigated and found that the configmap is in the default namespace and not with the deployment so it cannot come up.

@joshuajohananorthos thanks for reporting this.. let's get this one fixed.. it should be an easy fix.. do you want to submit a PR?


[zkd] testInBox speedup

Scope & Purpose
This is a feature branch for #13650. This is a speedup for the testInBox and compareWithBox function.

https://jenkins.arangodb.biz/job/arangodb-matrix-pr/14508/

https://jenkins.arangodb.biz/job/arangodb-matrix-pr/14510/

Closed in favor of #13798


Purge fails with object that must be quoted

Deploy fails when a trigger on a table that must be quoted is among the managed objects.
postgres@localhost:my_db> select * from pgpkg.managed_object
+-----+-----+----------+-------------------------------------------------------+
| pkg | seq | obj_type | obj_name                                              |
|-----+-----+----------+-------------------------------------------------------|
| foo | 0   | function | bar.find_mail_id()                           |
| foo | 1   | trigger  | insert_mail_id_trigger on bar.FOO_Table |
| foo | 2   | function | bar.matching_mail(name text)                 |
+-----+-----+----------+-------------------------------------------------------+

❯ pgpkg try --verbose
...
pgpkg: 2024/10/11 16:59:14 parsing MOB dbstuff/bar/find_mail_id.sql
pgpkg: 2024/10/11 16:59:14 parsing MOB dbstuff/bar/matching_mail.sql
pgpkg: 2024/10/11 16:59:14 select obj_type, obj_name from pgpkg.managed_object where pkg=$1 order by seq desc [foo]
pgpkg: 2024/10/11 16:59:14 savepoint statement
pgpkg: 2024/10/11 16:59:14 drop function if exists bar.matching_mail(name text)
pgpkg: 2024/10/11 16:59:14 release savepoint statement
pgpkg: 2024/10/11 16:59:14 savepoint statement
pgpkg: 2024/10/11 16:59:14 drop trigger if exists insert_mail_id_trigger on bar.FOO_Table
**pgpkg: 2024/10/11 16:59:14 [notice] relation "bar.foo_table" does not exist, skipping**
pgpkg: 2024/10/11 16:59:14 release savepoint statement
pgpkg: 2024/10/11 16:59:14 savepoint statement
pgpkg: 2024/10/11 16:59:14 drop function if exists bar.find_mail_id()
pgpkg: 2024/10/11 16:59:14 rollback to savepoint statement
pgpkg: 2024/10/11 16:59:14 savepoint statement
pgpkg: 2024/10/11 16:59:14 drop function if exists bar.find_mail_id()
pgpkg: 2024/10/11 16:59:14 rollback to savepoint statement
<internal>:1: unable to install MOB: <internal>:1: unable to execute statement: pq: cannot drop function bar.find_mail_id() because other objects depend on it
<internal>:1: unable to execute statement: pq: cannot drop function bar.find_mail_id() because other objects depend on it
pgpkg: 2024/10/11 16:59:14
pgpkg: 2024/10/11 16:59:14 -->    1: drop function if exists bar.find_mail_id()

As you can see, `bar."FOO_Table" is not adequately quoted, and therefore the drop fails.
A secondary issue is that the error is pretty confusing if I run this without --verbose (the "notice" line + the last 5 lines from above). The real error is marked as a notice, and the last lines are a red herring.

I've just committed a fix for this. Unfortunately, if you have this problem, you will need to update pgpkg.managed_object to quote the schema name to fix it.
In terms of the error message, it's really an artefact of the bug, so this shouldn't be possible any more after my fix. pgpkg doesn't assume the database is in "perfect condition" - for example you might drop a function during development for some reason - and I don't think it's ideal for pgpkg to complain too much about that sort of thing.
Let me know how you get on, then I can close the issue.

Worked great! (After updating my go version). Nothing is in production yet, so no problem there.
I had to truncate pg.managed_object and then delete the managed objects by hand. It occurs to me that this is something that might be necessary often enough (when one gets oneself into tricky situations) that maybe pgpkg should have a subcommand for it? (clean-mobs or something)
Many thanks for the quick fix!
(Also, for the record, I wouldn't choose to use uppercase chars in table names if it were up to me. But it's just as well that pgpkg can handle them!)

Hi Felix
That's awesome.
I could have updated the database tables as part of the pgpkg upgrade, but I was worried about how much work it would be to test it properly, and since it's alpha and I guessed you weren't in production, I didn't think it was worth the effort.
Once I get feedback from you or anyone else about potentially using pgpkg in production, I'll start considering pgpkg "beta" level, and will start using branches and releases. At that point I would definitely have cleaned up the managed_objects table to fix this bug.
Cheers
Mark


AttributeError: 'function' object has no attribute 'format'

Occurs when attempting to pass an anonymous function in diff_merge and lehmer_diff_merge Maybe others.
import vapoursynth as vs
from vsrgtools import box_blur, diff_merge

core = vs.core

test = core.std.BlankClip()

diff_merge(test, test, lambda x: box_blur(x)).set_output()

  File "uhh.vpy", line 8, in <module>
    diff_merge(test*2, lambda x: box_blur(x)).set_output()
  File "/home/morgan/.local/lib/python3.10/site-packages/vsrgtools/freqs.py", line 86, in diff_merge
    blurs = [filt(clip, **kwargs) for filt, clip in zip(filter, clips)]
  File "/home/morgan/.local/lib/python3.10/site-packages/vsrgtools/freqs.py", line 86, in <listcomp>
    blurs = [filt(clip, **kwargs) for filt, clip in zip(filter, clips)]
  File "/home/morgan/.local/lib/python3.10/site-packages/vstools/functions/check.py", line 45, in _wrapper
    return function(*args, **kwargs)
  File "/home/morgan/.local/lib/python3.10/site-packages/vstools/functions/check.py", line 45, in _wrapper
    return function(*args, **kwargs)
  File "/home/morgan/.local/lib/python3.10/site-packages/vsrgtools/blur.py", line 56, in box_blur
    assert clip.format
AttributeError: 'function' object has no attribute 'format'

oh you need to explicitly specify filter=x


Flake setup for bootstrap build

I figured it would be pretty cool, to set up the bootstrap build as flake outputs. Do you have any objections on that? Would you still want to be able to do it the old way or should we go flake-only (for the bootstrap build part).

No objections whatsoever.

Flake-only is fine.

Implemented with #204


be more careful about sending packets without stream data during the handshake

The problem here is that we'd use the wrong packet type during the TLS handshake:

for the client: Until receiving the ServerHello, the next packet type is still ClientInitial. ClientHello however should only be used for packets containing a Client Hello.
for the server: When sending the first server packet, and the handshake state is still ServerStateStart, we assume that this is the case because we returned to that state by sending a HRR. This is only true if we read and acted upon the ClientHello though.

Fixed by #980.


where can I find StormWordCount.log when submit to remote

In local mode I can find the log in current dir I execute the command. While in remote mode(Just a signle machine) , where can I find the log?

Just find It should be the worker who run the WordCountBolt. So the log is in the storm realease dir 's logs dirs. And we need to know which worker was the WordCountBolt. It seems that we can't find the worker id in the storm-ui , I see all the workers's log to find it.


Datasource availability mis-represented due to 0 row segments not cleaned up after compaction

Affected Version
0.14.0, 0.14.2
Description
After tracking the 'druid/coordinator/v1/loadstatus' API over weeks of execution, I started to notice long periods of time when our datasources would not be 100% available even though I could query all data from them successfully. Here is an example response:
{
"npav-ts-metrics-15m": 100,
"npav-ts-metrics": 97.31543624161074
}
When I look at the "missing" segments, I see the following in the unified-console:

This shows that the data is there, and has been compacted, but there are also some '0-row' segments for the same time period that have not been cleaned up. These are being used to reduce the datasource availability even though the data is queryable.
Eventually these rows get cleaned up, but then new ones take their place, so the datasource is very rarely 100% available from the POV of the 'druid/coordinator/v1/loadstatus' API. Maybe these segments could be filtered out when handling the API to more accurately represent the status of the datasource?

Hi @acdn-mpreston there is a lot to unpack in this issue.

You are issue number 8000, congratulations 🎆

I am saddened by the issue your console is having rendering icons

]
I am guessing you are somehow prevented from loading the icon font? This should be addressed in the newly released Druid 0.15.0 , we upgraded to the latest blueprintjs which no longer uses the icon font.

The segments you have highlighted do not really have 0 rows num_rows is only reported for available segments. This is confusing UI and will be fixed in the next iteration of the web console (in 0.16.0). It will then say (unknown).

The segments you have highlighted are actually the segments you want! Look at the version it is higher. Maybe they are the result of the compaction and they have not been loaded yet?

More info is needed to understand what is going on: by I started to notice long periods of time when our datasources would not be 100% available what do you mean by 'long' minutes? hours? days? Also when you say Eventually these rows get cleaned up can you be specific on 'Eventually' is it minutes? hours?

Hey @vogievetsky, thanks for the quick attention!

Thanks!!!
Awesome.
That makes more sense, thank you.
You are correct, I made an assumption based on the "Num rows" being populated and the "Is available" flag being set to true....interesting that there are 3 different versions of the segments all published at the same time.
For the datasource availability, majority of the time it has not been 100%. Here is a graph showing the availability returned over a couple day period where we call the loadstatus API every minute:

Sometimes it will be 100% available, but not regularly. As you can see, it is almost always VERY close to 100% but not 100%. If I query the data, it is always there....no segments are missing it just seems that there is segment tracking that is confused.
In terms of resolution, it takes many minutes or even maybe an hour, to resolve the mis-represented segments.

Also, @vogievetsky this may not be related but I notice that I did not have this issue when replication was reduced from 3 copies to just 1. This graph shows an example of this:

Please keep in mind that some of the noise in the graph is due to some of our tests on this system, but the overall trend of having less frequent instances of datasource availability being less than 100% does still appear to be applicable.
In addition, please note that I am running a custom build based on this other issue currently under investigation: https://github.com/apache/incubator-druid/issues/7926

@vogievetsky my latest test with replication enabled does not have this issue. It must be related to something else around how compaction is executing and not fully replacing the previous versioned segment files.


Support multi-container pods applications

Functional
Allow a user to manage and inspect multi-container pods applications.
UI/UX
Update the application details view to introduce the container dimension. Introduce a new icon to differentiate init containers from app containers.

Note that for the Application containers datatable, the status will have to be updated to match the status of the container NOT the status of the pod.
Update any datatable exposing the image associated to an application to change the value if an application is running multiple containers inside a pod to display a single image name + X (where X is the total number of containers inside the pod -1).

Blocked by:

[ ] #3989
[ ] #3991
[ ] #3994

Removing the block on #3994 since tolerations are set on the pod level and not on the container level, it should not prevent us to continue on this topic.


A bunch of improvements to the website

This can be reviewed by just looking at each individual commit sequentially

Thank you for working on this! I hope I made the right decision to write the playground in plain JavaScript without frameworks, which makes it is easy to modify.

Thank you for working on this! I hope I made the right decision to write the playground in plain JavaScript without frameworks, which makes it easy to modify.

I'm not sure, I'm not super good at web stuff regardless, but this wasn't super hard to add :)


⚠ Spryr has degraded performance

In 79bf83a, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4400 ms

Resolved: Spryr performance has improved in 71141c4 after 11 minutes.


[BrokenLinksH2] Fixed the link path

Deactivated the Example link

Docs Build status updates of commit 861debc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/Authenticating-Users-with-Azure-Active-Directory.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Using VS Code Devcontainers (docker-from-docker) with Non Root User Failing Docker Daemon Credentials Check

VSCode Version:
Version: 1.74.2
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:32:21.587Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0
Sandboxed: No

Local OS Version:
Mac OS X Version 12.6

Local chip architecture: <x86, arm64, Apple Silicon>
Apple M1

Reproduces in: <Codespaces | Remote - Containers | Both>
Remote Containers

Name of Dev Container Definition with Issue:

old location:
https://github.com/microsoft/vscode-dev-containers/tree/main/containers/docker-from-docker
new location:
https://github.com/devcontainers/features/tree/main/src/docker-from-docker
The entry from our devcontainer.json:
    "docker-from-docker": {
      "version": "latest",
      "moby": true
    },

I also tried updating the above to the "new format":
"features": {
    "ghcr.io/devcontainers/features/docker-from-docker:1": {}
}

to no effect.
I posted a question here:
https://github.com/devcontainers/community/discussions/20
to find out where this issue/bug should be created - but this seems like the best place for it.
Steps to Reproduce:
Hi there, we've been successfully using devcontainers (non root user spinning up docker containers) for over a year now.
A new version of docker was pushed out in late December - with a new version of credential helper and it appears to have broken our usage of visual studio code devcontainer's.  Our usage of devcontainers is with a non root user using the "docker from docker" workflow.
This technique has been working for over a year now using the documentation here:
https://code.visualstudio.com/remote/advancedcontainers/add-nonroot-user
We added our non root user to the group docker.
When the issue first started happening we got the following error:
failed to solve with frontend dockerfile.v0: failed to create LLB definition: rpc error: code = Unknown desc = error getting credentials - err: exit status 255, out: `

So we blew away all data (containers, images + volumes) using the docker purge data.
Then when we re-ran docker-compose - we started getting python errors like this:
Pulling <docker image name> (<docker image name>:)...
Traceback (most recent call last):
  File "/usr/local/pipx/venvs/docker-compose/lib/python3.9/site-packages/docker/credentials/store.py", line 76, in _execute
    output = subprocess.check_output(
  File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.9/subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/local/bin/docker-credential-dev-containers-f90694ffd4ef7d23592ec24c6172cf511d70ae8b', 'get']' returned non-zero exit status 255.

Along with a few other python errors - which appear to be similarly just trying to run some command line executables.
After a lot of reading online - it seems the issue is that the
/home/<non root user>/.docker/config.json

is getting populated with invalid credentials in the following format:
{
        "credsStore": "dev-containers-<hash number>"
}

After removing this entry from the config.json - everything "just works" - the non root user is once again able to talk to the docker daemon, create images + subsequently containers.
I'm not sure if this issue needs to be "cross posted" to a docker issue repository since this may be in the realm of an integration issue.

Hi 👋
Thanks for the information.
Few clarifying questions,

What is the version of your dev containers Extension? Can you update to latest and retry?
Is your devcontainer same as the one defined in https://github.com/microsoft/vscode-dev-containers/tree/main/containers/docker-from-docker ? If yes, then do you mind switching to a simpler one below 👇

{
	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
	"image": "mcr.microsoft.com/devcontainers/base:bullseye",

	"features": {
                // docker-from-docker was renamed yesterday 👇
		"ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
			"version": "latest",
			"enableNonRootDocker": "true",
			"moby": "true"
		}
	},

	// Use this environment variable if you need to bind mount your local source code into a new container.
	"remoteEnv": {
		"LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}"
	}
}

If nothing of the above works, can you provide me with a repro (like you dev config)?

devcontains version: v0.269.0
I actually mentioned that in my original ticket - that we tried the new format (to no effect)
Unfortunately - I don't think I can publicly share the entirety of our devcontainer.json + Dockerfile - but I can share snippets of it.  So as mentioned we've tried both (in our devcontainer.json):

  "features": {
    "docker-from-docker": {
      "version": "latest",
      "moby": true
    },

and the updated format:
"features": {
    "ghcr.io/devcontainers/features/docker-from-docker:1": {}
}

I believe the values you populated in your config snippet are actually the defaults - i.e. works the same as empty object afaik.
I can also mention this is what we're using in our Dockerfile:
ARG VARIANT="buster"
FROM mcr.microsoft.com/vscode/devcontainers/base:0-${VARIANT}

Looking at the devcontainer.json here:
https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/debian/.devcontainer/devcontainer.json
and the Dockerfile here:
https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/debian/.devcontainer/Dockerfile
I can say that our Dockerfile (as seen above) differs from the version in the microsoft git repo - since the head version (245.2) has this:
ARG VARIANT=bullseye
FROM mcr.microsoft.com/vscode/devcontainers/base:${VARIANT}

I could try removing the "0-" and/or changing the value for the VARIANT - but does the value from the devcontainer.json actually override that value - i.e. if we have the following in our devcontainer.json?
	"build": {
		"dockerfile": "Dockerfile",
		// Update 'VARIANT' to pick an Debian version: bullseye, buster
		// Use bullseye on local arm64/Apple Silicon.
		"args": { "VARIANT": "bullseye" }
	},

Reading https://github.com/devcontainers/cli/issues/349 looks like docker credential helpers are not supported for Features yet. I believe that should explain why they aren't working now but used to earlier.

Sorry I just realized that in your suggestion - you mentioned the following:
"enableNonRootDocker": "true",

which doesn't look like it is a default value.  I'll give that a try - thanks!

No luck - same error -
i.e. even if I change the config to this:
    "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
      "version": "latest",
      "enableNonRootDocker": "true",
      "moby": "true"
    },

python attempts to run the following command:
subprocess.CalledProcessError: Command '['/usr/local/bin/docker-credential-dev-containers-<hash number>, 'get']' returned non-zero exit status 255.

Reading https://github.com/devcontainers/cli/issues/349 looks like docker credential helpers are not supported for Features yet. I believe that should explain why they aren't working now but used to earlier.

Looks like you've missed https://github.com/devcontainers/features/issues/376#issuecomment-1372862313
Does that make sense to you?

I saw it - but I had hoped that your earlier comment (with the recommendation to update my config) would resolve it.
So for now - it's just "unsupported" - and I should just keep an eye on this issue:
https://github.com/devcontainers/cli/issues/349
and in the meantime - just continue to blow away the contents of:
~/.docker/config.json
?
Thanks again!

Looks relevant to https://github.com/microsoft/vscode-remote-release/issues/7982
@source-transformer can you retry with Dev Containers 0.279.0-pre-release version and see if it fixes the issue?

Hello, I also have the same problem when using "Feature". On my environment, it perfectly reproduces when "Feature" is given in .devcontainer.json.

$ code --version
1.87.2
863d2581ecda6849923a2118d93a088b0745d9d6
x64

$ docker version
Client:
Version:           24.0.7-rd
API version:       1.42 (downgraded from 1.43)
Go version:        go1.20.10
Git commit:        72ffacf
Built:             Wed Nov  1 18:42:47 2023
OS/Arch:           linux/amd64
Context:           default
Server:
Engine:
Version:          23.0.6
API version:      1.42 (minimum version 1.12)
Go version:       go1.20.11
Git commit:       9dbdbd4b6d7681bd18c897a6ba0376073c2a72ff
Built:            Fri Nov 17 20:59:57 2023
OS/Arch:          linux/amd64
Experimental:     false
containerd:
Version:          v1.7.2
GitCommit:        0cae528dd6cb557f7201036e9f43420650207b58
runc:
Version:          1.1.12
GitCommit:        51d5e94601ceffbbd85688df1c928ecccbfa4685
docker-init:
Version:          0.19.0
GitCommit:

$ uname -a
Linux GALLERIA <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Thu Oct 5 21:02:42 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

systeminfo
ホスト名:               GALLERIA
OS 名:                  Microsoft Windows 11 Home
OS バージョン:          10.0.22631 N/A ビルド 22631
OS 製造元:              Microsoft Corporation

{
	"name": "Debian",
	"image": "mcr.microsoft.com/devcontainers/base:bullseye",
	"features": {
		"ghcr.io/devcontainers/features/dotnet:2": {}
	}
}

{
	"name": "Node.js & TypeScript",
	"image": "mcr.microsoft.com/devcontainers/typescript-node:1-20-bullseye",
	"features": {
		"ghcr.io/devcontainers/features/python:1": {
			"version": "3.11"
		}
	}
}

One thing I do have in mind is that my docker environment was changed from Docker Deskto to Rancher Desktop a few monthes ago. I'm not sure that causes this problem or not.

Hello, changing credStore value to "pass" resolves this.
$ cat ~/.docker/config.json
{
  "credsStore": "pass"
}

In addition, my environment could not resolve the name of ghcr.io. In order to fix this, it was necessary to change nameserver to <IP_ADDRESS>.
$ cat /etc/resolv.conf
nameserver <IP_ADDRESS>

Note: By default, resolv.conf will be automatically restored by WSL2, therefore  it is necessary to set generateResolveConf = false.
$ cat /etc/wsl.conf

[boot]
systemd=true

[network]
generateResolvConf = false


Teamcity build: Should the target for building be 'install' instead of 'clean validate'

When a pull request is build it looks like the Maven goals clean validate are executed. We have added a new codec named codec-sockjs which is failing because this is not yet available in a sonatype snapshot repository. If the Maven goal used was install, perhaps skipping tests at this first stage, then this artifact would be available in the local maven repo of the build server.
Does this make sense or am I missing something here perhaps?

@danbev I think the problem would be that it would install stuff locally that is not yet merged and may be picked up on other runs. Or I`m missing something ?

I think the problem would be that it would install stuff locally that is not yet merged and may be picked up on other runs. Or I`m missing something ?

What I'm seeing is that this is a new maven module/project named codec-sockjs, which is not available in any Sonatype snapshot repository yet. The build is currently failing for this reason from what I can see. Does that make sense?
Not sure how I can get the build server to complete as it will not get passed this stage.

@trustin any idea ?

Maybe maven just tries to check for new versions of snapshot dependencies.
You could try using "mvn -o clean validate" or disabling snapshots from sonatype alltogether
    <repositories>
        <repository>
            <id>sonatype-nexus-snapshots</id>
            <name>Sonatype Nexus Snapshots</name>
            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
            <releases>
                <enabled>false</enabled>
            </releases>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
        </repository>
    </repositories>

Unless the final goal is package or install, Maven tries to fetch the snapshot JARs from the repository and that will cause the problem @danbev reported.
There are two ways to solve the problem: 1) deploy snapshot JARs more frequently (e.g. for each commit) or 2) do not run mvn clean validate but just mvn clean package
The reason why I ran mvn clean validate first and then mvn package is because most PRs fail due to checkstyle errors. Given that all the tests and compilation takes much longer time than validation, it's better fail fast.
Probably the simplest solution would be (2) + increased number of TeamCity build agents (i.e. more computing resources)

Another PR build problem I wanna solve with this issue is to reject building a PR with diverged commits. This would be very useful when a user chose a wrong merge target when creating a PR.

do not run mvn clean validate but just mvn clean package

That sounds like a good idea to me and would work around this issue. Perhaps the running of tests could be deferred to speed things up a little so that checkstyle issues could be found early in the process, and then have an explicit run of the tests. Some thing like
$ mvn clean package -DskipTests
$ mvn test

Not sure if that is doable with the TeamCity server configuration. I looked around but could not find where the actual configuration is (might have been a permissions thing).

@trustin I'd be happy to try out your suggestion (nr 2) if you don't have the spare cycles at the moment. If so, could you give me the permissions required on the build server?

@danbev I've just updated the TeamCity settings so that it runs mvn -DskipTests clean package first and then mvn package. Thanks for a great idea!

@trustin Awesome, thanks for that!


Django 1.9 compatibility

Thank you for this ! Since I messed up the travis CI conf, tests were not run on different version of Django (only different version of Python), but I assume you ran all the tests this locally on your machine before submitting.
Also, since we are using Git Flow branching model here, I'll merge your PR into develop and not into master. It we'll be merged into master when a new release is issued, which will be soon.

Since there is apparently no way to change the target branch of a pull request, I'll have to close this one. Could you reopen it, against the develop branch this time ?
I'm sorry about that, anyway, you're help is really appreciated !

Thanks a lot.


Added a self-hostable repository.

I've been hosting this for a while and I think it is pretty awesome.

Thanks!


DCOS-51221: Delete Repositores button not working for Package Repository

Change data layer command so that deleting repositories works.
Closes https://jira.mesosphere.com/browse/DCOS-51221
~This is still work in progress. I still need to figure out how our integration tests work right now and add one for deleting.~
Testing

Go to Settings > Package Repositories
Add a new repository, for example:

name: universe 2
url: https://downloads.mesosphere.com/universe/repo/repo-up-to-1.13.json.gz
priority: 0

Try to delete it
Verify that it gets successfully deleted

Trade-offs
None.
Dependencies
None.
Screenshots
Before

After

Okay, I managed to get integration tests running. However, I think that the cluster we use for tests is not setup to allow deleting packages (and adding as well).

I guess a way to test is to check if the modal has closed.

I added a test that checks if the modal closes when the delete button is clicked. As the modal won't close if the delete action fails (as in this bug), I think this is enough to test this functionality.

:tada: This PR is included in version 2.77.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


OpenBSD: (*Mem).Get() returns zero with no error

Reported in https://github.com/cockroachdb/cockroach/issues/15836
Using 64-bit OpenBSD
CockroachDB calls (*Mem).Get() and that returns zero with a nil error. The zero value is incorrect; an error should be returned instead.

cc @jasperla

Ack, I'll investigate this weekend.

The issue was due to the fact that the underlying kernel structure changed and suddenly we reported 0 npages in use. It didn't fail to retrieve the data, it merely got the wrong data back. I've submitted a fix and some hardening against this type of situation.

Also submitted a fix in #125


Make pack install work with local git repo

Make st2 pack.install work with file:///path/to/local/git/repo.
Add unit tests to cover permutations.

I was missing this too much on my "pack dev workflow testing". See if it's safe enough to shove into 2.1, which I think it is.

Current coverage is 77.58% (diff: 100%)

Merging #3074 into master will increase coverage by 0.30%

@@             master      #3074   diff @@
==========================================
  Files           430        430
  Lines         22061      22061
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          17049      17116    +67
+ Misses         5012       4945    -67
  Partials          0          0

Powered by Codecov. Last update 6a5be8c...754a6f3

LGTM :+1:


feat(Sidebar): add collapsible sidebars

FX-1832
Description
Added collapsible sidebars logic and refactors
How to test

Check the new PageSidebar page in storybook, make sure it's complying with the Figma docs
Be sure that the tests and specs are correctly implemented and make sense

Development checks

[ ] Add changeset according to guidelines (if needed)
[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[ ] Self reviewed
[ ] Covered with tests

Breaking change

[ ] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

Approved as we already checked PRs with partial functionalities

Tested Sidebar, works great 👍


ModuleNotFoundError: No module named 'apscheduler.schedulers.background'

I ran the following commands:
python setup.py install
pip install telegram_crypto_price_bot
After this I changed the config.ini file and added api_id, api_hash and bot_token (from BotFather).
Then ran:
cd app
python bot.py
But the error I am getting is:
  File "/Users/alisolanki/Program Files/cryptoPriceTelegramBot/app/bot.py", line 26, in <module>
    from telegram_crypto_price_bot import PriceBot, __version__
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/__init__.py", line 5, in <module>
    from telegram_crypto_price_bot.price_bot import PriceBot
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/price_bot.py", line 24, in <module>
    from telegram_crypto_price_bot.bot.bot_base import BotBase
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/bot/bot_base.py", line 31, in <module>
    from telegram_crypto_price_bot.command.command_dispatcher import CommandDispatcher, CommandTypes
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/command/command_dispatcher.py", line 30, in <module>
    from telegram_crypto_price_bot.command.commands import (
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/command/commands.py", line 28, in <module>
    from telegram_crypto_price_bot.coin_info.coin_info_scheduler import (
  File "/opt/homebrew/lib/python3.9/site-packages/telegram_crypto_price_bot-0.3.3-py3.9.egg/telegram_crypto_price_bot/coin_info/coin_info_scheduler.py", line 27, in <module>
    from apscheduler.schedulers.background import BackgroundScheduler
ModuleNotFoundError: No module named 'apscheduler.schedulers.background'```

My pip version: pip 22.3.1 from /opt/homebrew/lib/python3.9/site-packages/pip (python 3.9)

Hi, you don't have to install it via setup.py, installing via pip is sufficient. Anyway, it seems that, for some reasons, apscheduler was not installed, you just have to install it.


Remove Vector2D

is inefficient and doesn't add anything not done by a tuple

changed it to a list may not be the most efficient
look back on later


Fix to work with Webpack v4.0.0-alpha

this.options is deprecated in webpack4

@ktsn can you, please, review and merge it? Wepback 4 is out and this issue blocks upgrade. Thanks!

Great thanks! 👍🏻


doc: highlight advantages

Closes: n/a
Goal
Highlight gem's advantages.
Approach
(self-explanatory)
Signed-off-by: Roderick Monje<EMAIL_ADDRESS>

Merging since changes are strictly textual