Bot Framework Custom Action and custom ArrayExpression property

Libraries name and versions

Microsoft.Bot.Builder 4.15.2
Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime 4.15.2

Environment

.NET Core 3.1
Windows 10 Enterprise

The staging
I’m building a bot using Microsoft’s Bot Framework Composer. To extend the composer’s standard features, I also built some Custom Actions, including one that needs input in the form of an array of a specific type.
Here is the schema:
{
  "$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
  "$role": "implements(Microsoft.IDialog)",
  "title": "AdvancePropertyTest",
  "description": "Test advanced properties in for custom actions.",
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "skillSelectors": {
      "$ref": "schema:#/definitions/arrayExpression",
      "title": "SkillSelector Items",
      "description": "SkillSelector Items.",
      "items": {
        "title": "SkillSelector Item",
        "description": "SkillSelector Item.",
        "type": "object",
        "properties": {
          "key": {
            "title": "Key",
            "description": "The skill key to query against.",
            "type": "string"
          },
          "operator": {
            "title": "Operator",
            "description": "Describes how the value of the label is compared to the value defined on the label selector.",
            "type": "string",
            "enum": [
              "Equal",
              "NotEqual",
              "LessThan",
              "LessThanEqual",
              "GreaterThan",
              "GreaterThanEqual"
            ],
            "default": "Equal"
          },
          "value": {
            "title": "Value",
            "description": "The value to compare against the actual label value with the given operator.",
            "type": "integer"
          }
        }
      }
    }
  }
}

which, in the composer, results in:
Composer action with custom properties
So far, so good.
Now, in the dialog's code, in order to retrieve the input data, this is what I did:
[Serializable]
public class SkillSelector
{
    [JsonProperty(PropertyName = "key")]
    public string Key { get; set; }

    [JsonProperty(PropertyName = "operator")]
    public string Operator { get; set; }

    [JsonProperty(PropertyName = "value")]
    public int Value { get; set; }
}

public class AdvancedPropertyTest : Dialog
{
    [JsonProperty("skillSelectors")]
    public ArrayExpression<SkillSelector> SkillSelectors { get; set; }
    //public ArrayExpression<Metadata> SkillSelectors { get; set; }

    public override async Task<DialogTurnResult> BeginDialogAsync(DialogContext dc, object options = null, CancellationToken cancellationToken = default)
    {
        var skillSelectors = SkillSelectors?.GetValue(dc.State);
        // some code

        return await dc.EndDialogAsync(cancellationToken: cancellationToken);
    }
}

The Issue
Unfortunately, this results in the following error message once I run it:
AdvancedProperties.dialog error: Cannot deserialize the current JSON array (e.g. [1,2,3]) into type ‘AdaptiveExpressions.Properties.ArrayExpression`1[SkillSelector]’ because the type requires a JSON object (e.g. {“name”:“value”}) to deserialize correctly.

To fix this error either change the JSON to a JSON object (e.g. {“name”:“value”}) or change the deserialized type to an array or a type that implements a collection interface (e.g. ICollection, IList) like List<T> that can be deserialized from a JSON array. JsonArrayAttribute can also be added to the type to force it to deserialize from a JSON array.

Path ‘skillSelectors’, line 49, position 37.

Interesting fact, using class Microsoft.Bot.Builder.AI.QnA.MetaData as the generic type in the ArrayExpression does the trick, but, of course, is not what I want.
Anyone an idea how to do this ?
Any assistance would be greatly appreciated
Cheers.

@SilvioHuckel, I'd like to try repro'g this using your code, if possible. Are you able to share a copy of your Composer bot, or a slimmed down version of it that adequately demonstrates the issue?

Hey @stevkan,
the following repo contains a slimmed down Composer project:
https://github.com/s1lv1o/bot-framework-customaction

@stevkan Any progress on this?

@SilvioHuckel, thank you for your patience while I've been looking into this. I am able to repro the issue you are experiencing. I have been trying to identify if there is a possible workaround but, as of yet, I have been unable to do so. I am also trying to reach out to some of the devs who originally worked on this part of the code base. However, I'm having some difficultly with this. I'll post another update as soon as I know more.

@SilvioHuckel, I'm glad you found a solution that worked!


Uncaught RangeError: Maximum call stack size exceeded

I'm debugging my server side C code, this happens when I changed the server code to send all the buffered data at once.
Uncaught RangeError: Maximum call stack size exceeded
    at ZmodemReceiveSession._strip_and_enqueue_input ((index):9501)
    at ZmodemReceiveSession.consume ((index):9292)
    at ZmodemSentry.consume ((index):8900)
    at WebSocket.ws.onmessage ((index):339)

Chrome Network Tab shows the maximum websocket message size is 327751.

Changed the buffer size to 32K, it works fine now.

Zmodem (the protocol) specifies 1 KiB packet size. The classic lrzsz tool supports up to 8, so that’s what zmodem.js sends.
Just for curiosity, why are you writing new C code for Zmodem? Does none of the existing libraries suffice?

I'm changing ttyd's code (C, not zmodem 😄 ) to support zmodem on the browser (with zmodemjs).
It's initially done now, may be lack of some error handling. You may wan't to try it:
https://github.com/tsl0922/ttyd/commits/dev


Use mesh to deform terrain

[ ] Create mesh same resolution as terrain tile and position to max tile height: ProBuilder - GeneratePlane; make it a cube
[ ] Try cutting the cube with boundary planes
[ ] Lower mesh vertices close to boundary to terrain level
[ ] Lower mesh vertices that are out of boundary (check boundary mesh vertex / face normal direction) close to boundary to zero
[ ] Smooth vertices outside boundary: ProBuilder - Bevel
[ ] For modified mesh vertices find related terrain vertex and move same as mesh vertex

Using Archimatix


aws Empty Project is missing in Toolkit for Visual Studio 2017

After installing the latest AWS Toolkit for Vision Studio 2017, per aws documentation there should be AWS Empty Project. But it is not present. I see only the following 2 AWS projects:

AWS CloudFormation Project
AWS Lambda Function Project
Is this a bug in AWS Toolkit for VS 2017 or is there any workaround?

Here is the AWS documentation that suggests that there should be AWS Empty project:
https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/CodeSamples.DotNet.html

Thank you for reaching out. The documentation appears to be outdated, I'll look into that further.
Can you try using the standard Console App project (either .NET Core or .NET Framework)? You would then skip step 5 (relating to AWS Credentials).


Bring back _printChanges queue.

Prior to the ReducerProtocol we would queue print changes in the debug operator on reducers:
https://github.com/pointfreeco/swift-composable-architecture/blob/54c384581cd0ed395d4f314dfdaca14dc70acf4c/Sources/ComposableArchitecture/Debugging/ReducerDebugging.swift#L118
We lost that in #1283, but we still used fireAndForget which had a sync overload, and so queuing just naturally happened on the main thread.
But, with 1.0 we got rid of fireAndForget and so instead used run, but then that introduced asynchrony and possible ordering issues with logs. So, currently it is possible for actionA to be sent before actionB, yet the logs for actionB will appear in the console before actionA.
This PR brings back the queue. Alternatively we could @MainActor the run effect. Each approach has their pros and cons. With the queue we run the risk of the logs starting to lag if too much is logged at once, and with @MainActor we risk slowing down the app if too much is logged (only in debug). I went with the queue for now, but open to switch to @MainActor too.

@MainActor making the app lag sounds significantly worse than just the logs themselves lagging, from a DX perspective.


Automate Domain with editable properties and editable contents

Purpose or Intent

With the Git based domains we need the ability to allow for the user to change the Domains properties like

enabled/disabled
priority
git url
select a specific branch or tag
but at the same time lock the contents from being updated.

The system column with a boolean value wasn't sufficient for this task so we added a new column called source that would replace the current system column.
The source can have 4 valid values

system           The properties as well as the contents are not editable
remote           The properties are editable but the contents are not editable (Git backed domains)
user                The properties as well as the contents are editable
user_locked   The properties are editable but the contents are not editable

@h-kataria @Fryguy @gmcculloug
Please review

@tinaafitz Please review

@gmcculloug @mkanoor Looks good.

UI changes look good.

@Fryguy
Please review

@mkanoor Thanks for the updates.


eslint and prettier: lint everything

just adding to what @kyle1james started in this PR https://github.com/processing/p5.js-sound/pull/488
added a commit that manually fixes style issues that eslint and prettier could not resolve on their own.

cc @endurance21

Hey yo, looks like p5.js was removed via this pr https://github.com/processing/p5.js-sound/pull/491 and is now a part of this pr. This is causing the following error "Uncaught ReferenceError: p5 is not defined" #491

@kyle1james good call, tho I think this is a separate issue as removing p5.js library files happened in https://github.com/processing/p5.js-sound/pull/483
Here's an issue to bring them back, perhaps in a better way https://github.com/processing/p5.js-sound/issues/484


Images with unicode chars in file name not show after upload

Hi, I have problems when I try to upload image files throug AjaxFileUpload with unicode chars in file name like 3º Vista general.jpg, the file upload but after, the file looks like corrupt because i can not open it.
If I change the name and remove this unicode chars then the upload is correct and image show well without any problems.

Hi @jsanant1,
This issue was fixed in v15.1.3: https://ajaxcontroltoolkit.codeplex.com/workitem/27655
Would you please clarify what version of the AJAX Control Toolkit you are using?

Hi, yes, i am using an older version but the problem is that when I try to upload this types of images files at the demo page https://ajaxcontroltoolkit.devexpress.com/AjaxFileUpload/AjaxFileUpload.aspx I think the problem persist because the image not show. I would not like to update my project with the new version and make several changes on it if the problem persist.

Exist anther way to fix this problem without installing the new Ajax control toolkit version?

I cannot reproduce this issue on a Sample Site.
Would you please attach a file that illustrates the problem?

Exist anther way to fix this problem without installing the new Ajax control toolkit version?

No, upgrading to the v15.1.3 or above is the only way to upload such files.

Hi, Thank you very much for your help, I hove solved the problem rewriting the Sys.Extended.UI.AjaxFileUpload.ProcessorHtml5 method and now works fine.


fix: show navlist when script disabled

Description:

Show navbar elements when the script is disabled
Reduce CLS

Before:

After:

Bumping for review. Similar to #255.


s/shamir/xor

Replaces Shamir with a simple xor-based 2-3 sharding scheme.
(It sounds like 2-3 is the way to go, so figured I'd make a PR for this one just in case.)

Lovely.


Bug: 菜单的选择不应该触发顶部导航自动隐藏与显示

Version
Vben Admin V5
Describe the bug?

菜单的选择不应该触发顶部导航自动隐藏与显示

https://github.com/user-attachments/assets/a0d21748-7be2-4797-8cd1-f389fa4e0c4d
Reproduction

开启顶部导航自动隐藏与显示
手动选择菜单最上面一条
此时出发了顶部导航的隐藏与显示

System Info
System:
    OS: macOS 14.5
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
    Memory: 12.07 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.22 - /usr/local/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 9.0.5 - ~/.nvm/versions/node/v20.11.1/bin/pnpm
  Browsers:
    Chrome: 127.0.6533.100
    Safari: 17.5

Relevant log output
No response
Validations

[X] Read the docs
[X] Ensure the code is up to date. (Some issues have been fixed in the latest version)
[X] I have searched the existing issues and checked that my issue does not duplicate any existing issues.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

z-index层级问题


[backport] fix diagflat fail if argument is not cupy.ndarray

Backport of #1036

Please backport to v4 branch.

I will create a new PR.


fix bug in rads_to_degrees.md

The first line is "from math import pi", but use "math.pi" in the following function.
Delete the "import" statement for the example.
Before
from math import pi

def rads_to_degrees(rad):
  return (rad * 180.0) / math.pi

from math import pi
rads_to_degrees(math.pi / 2) # 90.0

After
from math import pi

def rads_to_degrees(rad):
  return (rad * 180.0) / pi

rads_to_degrees(pi / 2) # 90.0

This has already been fixed in the content curation epic. Thanks.


Clicking circle zooms out instead of remains in current zoom

Clicking circle zooms out instead of remains in current zoom
Description
Expect to NOT zoom out when I click on any state circle
Steps to Reproduce
Begin zoomed out. Click any circle (I clicked a state within the US). While observing current display of the original circle, click another circle related to a US state. Notice that it zooms back out.
Expected Behaviour
I expect that when I click on another circle, the screen will not zoom back out.

@gmeyer3 Thanks for the issue. I am able to reproduce this, but not consistently. Can you provide some more details on your set and the steps your taking to produce this bug?


watchForceTouches function just like your cordova 3dtouch plugin

Hi,
Thanks for your great efforts. I see you in cordova and nativescript world :). I used your cordova 3dtouch plugin and it has really handy method watchForceTouches. Is there away we can use the same function / add in this plugin ? Like following:
ThreeDeeTouch.watchForceTouches(function(result) {
    console.log("force touch % " + result.force); // 84
    console.log("force touch timestamp " + result.timestamp); //<PHONE_NUMBER>.706419
    console.log("force touch x coordinate " + result.x); // 213
    console.log("force touch y coordinate " + result.y); // 41
  });

hi @EddyVerbruggen  any update on this ? it would be nice to use 3d touch for NS views.

Hi @dotnetdreamer! Can you perhaps share a snippet (in the Playground maybe) how you would use it on Android? That will help implementing a similar API on iOS.

Hi @EddyVerbruggen ,
Unfortunelty i didn't do it before and was just sharing an idea. However, i looked at your Cordova plugin code and did something close to that just for my app in iOS. Here is the short snipped of it.
Now this isn't perfect but i am sure you can make much better than me.
export class ForceTouchGestureRecognizer extends UILongPressGestureRecognizer {
     force = 0.0
     maximumForce = 4.0
     i = 1;
     lastEvent = 0;
     callback = null;
     caller = null;

     constructor() {
         super({target: null, action: null});
     }

    touchesMovedWithEvent(touches: NSSet<UITouch>, event: _UIEvent) {
        super.touchesMovedWithEvent(touches, event);
        // this.normalizeForceAndFireEvent(touches, event);
        let touchesArr: NSArray<UITouch> = touches.allObjects;

        for(let i = 0;i < touchesArr.count; i++) {
            let touch = touchesArr.objectAtIndex(i);
            let percentage = (touch.force / touch.maximumPossibleForce) * 100;
            //console.log(percentage);
            // if(percentage >= 50){
            //     console.log(percentage);
            // }
            this.lastEvent = this.lastEvent || 0;
            // console.log('ts: ' + touch.timestamp + ' lastEvent: ' + this.lastEvent);
            if (percentage >= 75) {
                // let's not flood the callback with multiple hits within the same second
                let ts = touch.timestamp;
                let diff = ts - this.lastEvent;
                // console.log('diff: ' + diff);
                if (diff > 0) {
                    this.lastEvent = ts;
                    // if(percentage >= 75) {
                        // console.log(percentage);
                        // console.log(this.lastEvent);
                    // }
                    this.force = percentage;
                    console.log(this.force);
                    if(this.callback) {
                        let point: CGPoint  = touch.locationInView(this.caller);
                        // console.log(point.x + ' - ' + point.y);
                        this.callback({
                            force: this.force,
                            timestamp: this.lastEvent,
                            point: {
                                x: point.x,
                                y: point.y
                            }
                        });
                    }
                }
            }
        }
    }

    private normalizeForceAndFireEvent(touches: NSSet<UITouch>, event: _UIEvent) {
        // console.log(touches);

        let touchesArr = touches.allObjects;
        let firstTouch: UITouch = touchesArr.objectAtIndex(0);

        if(firstTouch == null){
            return;
        }

        let maximumPossibleForce = firstTouch.maximumPossibleForce;
        this.maximumForce = maximumPossibleForce > this.maximumForce ? this.maximumForce : maximumPossibleForce;

        // //I'm going to use that and normalize it so the developer can use a value between 0.0 and 1.0.
        this.force = firstTouch.force / this.maximumForce;
    }

    //This function is called automatically by UIGestureRecognizer when our state is set to .Ended. We want to use this function to reset our internal state.
    public reset() {
        super.reset()
        this.force = 0.0
    }
}

and Here is the usage
                let forceTouchRecognizer = new ForceTouchGestureRecognizer();
                forceTouchRecognizer.caller = args.ios;
                forceTouchRecognizer.callback = (result) => {
                    // console.log(this.swiperWebViewInterface);
                    if(this.swiperWebViewInterface) {
                        this.swiperWebViewInterface.emit('touchesMovedWithEvent', result);
                    }
                };

Thanks for sharing!

also check here. This question is getting hot. Lot's of people are looking for it...
https://stackoverflow.com/questions/43824289/ios-3d-touch-support-in-native-script

Hey guys! Any progress on this at all? Really need this for a project soon :(

With iPhone 11 no longer supporting 3D Touch at all I think this should no longer be relied upon.


array pruning for LeftShift

Prunes arrays in QScript LeftShift.
Fixes #1851

(Oh, but let me know if you’re going to ignore the comment so I can merge or not.)

@sellout if you're fine merging with the def go ahead and I'll probably make it a val again next time I'm in that file. If not I'll revert it in this PR.

Yep, merging. (Wasn’t going to bother to write that, but the wifi is so slow, it’s taking longer to actually merge than I expected.)


Duplicated symbol bug.

I'm submitting a ...
[X ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

This pull request was a test to see if a symbol could be duplicated. To my surprise it worked. I would have hoped that a symbol had to be unique and not duplicated. I was able to duplicate the symbol "WIN" which was done on both of these contracts:
https://solscan.io/token/Ghh9TRwCMjjGXFexdjqscqrcfwHsETRcxgvFi4puMftx
https://solscan.io/token/AWD7Rkh72ENAZUeHGP5mnubFPk8AeSN1ogosExdF4G2X
Here is the original PR where I did the duplicated symbol: https://github.com/solana-labs/token-list/pull/17050
I have also added another pull request to make a change to the symbol to be "LIME". Here is that PR: https://github.com/solana-labs/token-list/pull/17057
I would hope that name or symbol could not be duplicated.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Please keep in mind, being able to duplicate a symbol OR name will create chaos now that SPL tokens are slated to be traded on CoinBase. Without uniqueness, it will be a huge deterrent to businesses to use Solana spa tokens. Please consider it a bug and address this as soon as possible.
If you don't mind, please respond to this message directly with your thoughts.

Please merge this change to make my token name "Tequila" have the symbol "LIME" The first upload was a test, as mentioned above.
Here is the PR to make the change to the symbol: https://github.com/solana-labs/token-list/pull/17057

merged #17057
for the broader question, will leave this issue open

merged #17057
for the broader question, will leave this issue open

"Closing" was unintentional.


Simplify OpPhi instructions referencing unreachable continues

In dead branch elimination, we already recognize unreachable continue
blocks, and update OpPhi instruction accordingly.  This change adds an
extra check: if the head block has exactly 1 other incoming edge, then
replace the OpPhi with the value from that edge.
Fixes #1314.

The only failure in the bots was a time out for one of the builds.  I'll merge anyway.


"Open in merge tool" does not work with nvimdiff

I am prompted with below error when trying to "open in merge tool"
The diff tool nvimdiff is not available as 'nvim'
fatal: external diff died, stopping at <my repo path>

I have set difftool and mergetool as nvimdiff in git config and have been using it in terminal without issue.
diff.tool=nvimdiff
merge.tool=nvimdiff

(base)$ git mergetool --tool-help
'git mergetool --tool=<tool>' may be set to one of the following:
                nvimdiff         Use Neovim with a custom layout (see `git help mergetool`'s `BACKEND SPECIFIC HINTS` section)
                nvimdiff1        Use Neovim with a 2 panes layout (LOCAL and REMOTE)
                nvimdiff2        Use Neovim with a 3 panes layout (LOCAL, MERGED and REMOTE)
                nvimdiff3        Use Neovim where only the MERGED file is shown
                vimdiff          Use Vim with a custom layout (see `git help mergetool`'s `BACKEND SPECIFIC HINTS` section)
                vimdiff1         Use Vim with a 2 panes layout (LOCAL and REMOTE)
                vimdiff2         Use Vim with a 3 panes layout (LOCAL, MERGED and REMOTE)
                vimdiff3         Use Vim where only the MERGED file is shown

It's because that nvim is a commandline tool that must be exec by some shell. You can use a GUI frontend.
For example, I have test this configure using neovide
[difftool]
    prompt = false
[diff]
    tool = nvimdiff
[difftool "nvimdiff"]
    cmd = "neovide -- -d -O \"$LOCAL\" \"$REMOTE\""

Thanks for the clarification, will try out some UI options in time. Will close the issue first.

If you do NOT want to use any GUI frontend. You can also use nvim in this way (using Windows as example):

Create a sourcegit_nvim.bat file with following content:

start "NVIM DIFF" /wait /separate "${PATH_TO_NVIM_BIN}\nvim.exe" -d -O "%1" "%2"

Modify the difftool.nvimdiff.cmd configuration:

[difftool "nvimdiff"]
    cmd = "\"${PATH_TO_YOUR_SCRIPT}\\sourcegit_nvim.bat\" \"$LOCAL\" \"$REMOTE\""

This will force open a new window for nvim.


A DSC Resource for Unity versions

Now that we can detect installs, find installers, and install unity, we can create a DSC resource for ensuring versions of Unity are installed.

The implementation I want to support is somewhat blocked by #23.


Build Fail (UI Goal Cannot): Bad URL returns 301

Summary
Build failure due to inability to download tarball.
Update: The URL is for http, when npm switched to https, and the plug-in (eirslett/frontend-maven-plugin) doesn't seem to support redirects from http to https.
Configuration

Ubuntu 14.04 Trusty Tahr (clean)
Java 1.8.0_171-b11
Maven 3.3.9

Steps

Install Oracle Java 1.8.0
Install Maven - apt-get install maven
cd /path/to/hygieia
mvn clean install package

Expected Results
As per instructions, expected it to not error: http://capitalone.github.io/Hygieia/setup.html.
This error seems to be related to downloading using: http://registry.npmjs.org/npm/-/npm-5.0.1.tgz.  The mechanism to download this is not working.
Actual Results
INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:33 min
[INFO] Finished at: 2018-05-28T01:40:52+00:00
[INFO] Final Memory: 121M/241M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.29:install-node-and-npm (install node and npm) on project UI: Could not download npm: Could not download http://registry.npmjs.org/npm/-/npm-5.0.1.tgz: Unknown host registry.npmjs.org: Name or service not known -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :UI

NOTES
When I curl manually, I noticed a 301:
HTTP/1.1 301 Moved Permanently
Date: Mon, 28 May 2018 01:53:03 GMT
Transfer-Encoding: chunked
Connection: keep-alive
Cache-Control: max-age=3600
Expires: Mon, 28 May 2018 02:53:03 GMT
Location: https://registry.npmjs.org/npm/-/npm-5.0.1.tgz
Server: cloudflare
CF-RAY: 421d15dc46c76d66-SJC

I identified the bug and potential solution, testing it now.  Thank you to @nireeshT for helping me with this.

https://github.com/capitalone/Hygieia/pull/2248


bug(sidenav): sidenav width "jumps" when a scrollbar is added

Reproduction
Use StackBlitz to reproduce your issue:

https://stackblitz.com/edit/angular-unlegu?file=src%2Fapp%2Fsidenav-responsive-example.ts

Steps to reproduce:

Click on the hamburger icon to open the menu
Click on "Add" until a scrollbar appear
notice behaviour
Can be repeated by clicking on "Remove" until the scrollbar disappears and then "Add" until it reappears

Expected Behavior
When the scrollbar needs to appear, the navbar width should be increased so that it can fit the scrollbar without delay
(possibly the width increase should happen before the scrollbar appears)
Actual Behavior
When the scrollbar needs to appear, it first appears and then the navbar increases in width so that it can fit the scrollbar
(possibly the width increase should happen before the scrollbar appears)
(not the best user experience)
Screenshot
From stackblitz:

From Angular.io/docs (at least I believe that it's the same bug):

(here you can see the chevron icons jumping when the scrollbar appears)
(I mentioned the issue here: https://github.com/angular/angular/issues/42552)
Environment

Angular: 12
CDK/Material: 12.0.4
Browser(s): Version 91.0.4472.101
Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu 20.04.2 LTS

Also I would like to mention that I've found a similar issue already present: https://github.com/angular/components/issues/22909
But I believe that this two are likely two different bugs

Hi @dario-piotrowicz
Have you tried using autosize on your sidenav-container?

Hi @lgaida I just noticed the stackblitz is no longer valid, I recreated it: https://stackblitz.com/edit/angular-4psyzl?file=src%2Fapp%2Fsidenav-responsive-example.html
and as you can see I added autosize but I don't think it's making any difference


demo doesnt work

I tired the demo....its doesn't work...I get no response back...

@Pager07 My bad, I didn't top up the OpenAI credits 😅 Should work now.


model architecture?

hi @bowbowbow, I am doing the end-of-the-year check up.
as i see it, i recognize that you tried some new approaches
to extract events while using bert.
I believe that the new approach can be captured by the NN architecture diagram
if it is possible, please add the diagram so that people can catch the new approach in a glance
thanks, yours sincerely, Yang

Internal Communication.


Variant codegen is incorrect with wasmtime Rust host and wit-bindgen Rust guest

Hi there! I've been updating our bindings from pre-CM to the latest version of wasmtime and wit-bindgen, and have been largely successful, but I've encountered a showstopper issue.
Issue
We use a variant for typed values that we want to transmit between the host and the guest. These are sent as a list of (u32, value) pairs. The guest calls a spawn: func(data: list<tuple<u32, component-type>>) -> entity-id function, which the host then handles.
However, after updating to the CM, I've discovered that the host is receiving entirely incorrect values from the guest. I'm not sure if this is an issue with the host reading or the guest writing; I don't have enough background on what the codegen output should look like to debug it.
To demonstrate, here's excerpts from my minimised example:
// WIT:
variant component-type {
    type-empty(tuple<>),
    type-bool(bool),
    type-entity-id(entity-id),
    type-f32(float32),
    type-f64(float64),
    type-mat4(mat4),
    type-i32(s32),
    type-quat(quat),
    type-string(string),
    type-u32(u32),
    type-u64(u64),
    type-vec2(vec2),
    type-vec3(vec3),
    type-vec4(vec4),
    type-list(component-list-type),
    type-option(component-option-type),
}

// Guest:
let entity = vec![
    ( 0, wit::component::ComponentTypeParam::TypeQuat(wit::types::Quat { x: 0., y: 0., z: 0., w: 1., }), ),
    ( 1, wit::component::ComponentTypeParam::TypeVec3(wit::types::Vec3 { x: 1., y: 1., z: 1., }), ),
    ( 2, wit::component::ComponentTypeParam::TypeVec3(wit::types::Vec3 { x: 0., y: 0., z: 0., }), ),
    (3, wit::component::ComponentTypeParam::TypeF32(0.1)),
    (4, wit::component::ComponentTypeParam::TypeMat4(identity)),
    (5, wit::component::ComponentTypeParam::TypeMat4(identity)),
    (6, wit::component::ComponentTypeParam::TypeF32(1.)),
    (7, wit::component::ComponentTypeParam::TypeF32(1.)),
    (8, wit::component::ComponentTypeParam::TypeEmpty(())),
    (9, wit::component::ComponentTypeParam::TypeEmpty(())),
    (10, wit::component::ComponentTypeParam::TypeEmpty(())),
    ( 11, wit::component::ComponentTypeParam::TypeVec3(wit::types::Vec3 { x: 5., y: 5., z: 4., }), ),
    ( 12, wit::component::ComponentTypeParam::TypeVec3(wit::types::Vec3 { x: 0., y: 0., z: 0., }),
    ),
];
println!("Guest: {entity:?}");
wit::entity::spawn(&entity);

// Host:
fn spawn(
    &mut self,
    args: Vec<(u32, component::ComponentTypeResult)>,
) -> anyhow::Result<types::EntityId> {
    println!("---");
    println!("Host: {args:?}");
    println!("---");
    anyhow::bail!("Unimplemented");
}

This results in the following output:
Guest: [(0, ComponentTypeParam::TypeQuat(Quat { x: 0.0, y: 0.0, z: 0.0, w: 1.0 })), (1, ComponentTypeParam::TypeVec3(Vec3 { x: 1.0, y: 1.0, z: 1.0 })), (2, ComponentTypeParam::TypeVec3(Vec3 { x: 0.0, y: 0.0, z: 0.0 })), (3, ComponentTypeParam::TypeF32(0.1)), (4, ComponentTypeParam::TypeMat4(Mat4 { x: Vec4 { x: 1.0, y: 0.0, z: 0.0, w: 0.0 }, y: Vec4 { x: 0.0, y: 1.0, z: 0.0, w: 0.0 }, z: Vec4 { x: 0.0, y: 0.0, z: 1.0, w: 0.0 }, w: Vec4 { x: 0.0, y: 0.0, z: 0.0, w: 1.0 } })), (5, ComponentTypeParam::TypeMat4(Mat4 { x: Vec4 { x: 1.0, y: 0.0, z: 0.0, w: 0.0 }, y: Vec4 { x: 0.0, y: 1.0, z: 0.0, w: 0.0 }, z: Vec4 { x: 0.0, y: 0.0, z: 1.0, w: 0.0 }, w: Vec4 { x: 0.0, y: 0.0, z: 0.0, w: 1.0 } })), (6, ComponentTypeParam::TypeF32(1.0)), (7, ComponentTypeParam::TypeF32(1.0)), (8, ComponentTypeParam::TypeEmpty(())), (9, ComponentTypeParam::TypeEmpty(())), (10, ComponentTypeParam::TypeEmpty(())), (11, ComponentTypeParam::TypeVec3(Vec3 { x: 5.0, y: 5.0, z: 4.0 })), (12, ComponentTypeParam::TypeVec3(Vec3 { x: 0.0, y: 0.0, z: 0.0 }))]
---
Host:  [(0, ComponentTypeResult::TypeQuat(Quat { x: 0.0, y: 0.0, z: 0.0, w: 1.0 })), (12, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeEmpty(())), (0, ComponentTypeResult::TypeVec2(Vec2 { x: 1.7e-44, y: 0.0 })), (12, ComponentTypeResult::TypeVec3(Vec3 { x: 0.0, y: 0.0, z: 0.0 })), (0, ComponentTypeResult::TypeEmpty(()))]
---

The first value is correct, but everything afterwards is corrupt. Adding the following to the list of components
( 13, wit::component::ComponentTypeParam::TypeList( wit::component::ComponentListTypeParam::TypeString(&["Hello", "world!"]), ), ),

results in a more direct failure:
Error: error while executing at wasm backtrace:
    0: 0x306036 - wit-component:shim!indirect-entity-spawn
    1: 0x1aadb - guest::wit::entity::spawn::h487a4080df6b6eec
    /* ... */

Caused by:
    unexpected discriminant: 225

Reproduction
I've uploaded my minimal reproduction here: https://github.com/philpax/wit-bindgen-variant-codegen-issue
This uses wasmtime 3ff3994a12, wasi-common/wasi-cap-std-sync (preview2-prototyping) 75f8fc615 and wit-bindgen 39030f9ada. I was previously using wasmtime b5e9fb710b as it was the closest version I could find to 6.0.0 that supported the wit hierarchy I'd set up, but I updated from that version to see if the latest version would alleviate this issue.
Running cargo run in the root (I've uploaded a precompiled guest.wasm) should show the issue immediately.
The guest can be built by going into guest and running cargo build && wasm-tools component new ./target/wasm32-wasi/debug/guest.wasm -o guest.wasm --adapt wasi_snapshot_preview1.wasm.
Notes

I have a custom stubbed wasmtime_wasi based on the work in preview2-prototyping. I didn't want to convert my existing bindings to async, which P2-P uses (which would require the wasmtime host to use async), so I figured it'd be easier to replicate the interface and stub out everything we didn't currently need.
wit-bindgen code is generated by the host's build script, not using the guest macro. This is done so that the guest code/API can be uploaded to crates.io - otherwise, the guest would have a Git dependency on wit-bindgen, which would block publishing. As far as I can tell, the build-script codegen should work identically to the guest macro. We are already using this solution in production with the pre-CM version of wit-bindgen et al.

This also required me to subsume wit-bindgen's Rust guest code. Luckily, there's not much of it. I do a few minor changes to the generated code to support the use of the code I subsumed, but it's mostly just importing wit_bindgen::rt from super.

Thanks for the report! I'll try to dig into this soon and see what's going wrong.

Ok the fix for this should be located at https://github.com/bytecodealliance/wasmtime/pull/594, and if you'd like I can work on getting that published on crates.io once it's merged. I also added in https://github.com/bytecodealliance/wasmtime/pull/5943 to help detect this in the future.

Just confirmed that everything works now, thank you so much!
re publishing - that would be nice, but honestly I think I'm pretty happy with having generated output in the published crate. Not having to instantiate the proc macro is pretty nice (especially because our WIT is not near the guest code, so it has to be copied in).
The only complaint I have about this solution is having to copy the runtime code in - having the latest version published would be an improvement, but not essential. It looks like this fix just missed the wasmtime release window, so I'm hoping we can be off all of our Git dependencies (aside from preview2-prototyping) next month!


[BUG] Fix 3.12 cross version persist tests by building the wheel manu…

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Now that we build hnswlib wheels for 3.12, the old version of chroma fetches wheels which do not work, this explicitly makes the cross version tests rebuild the wheels. This was silently failing as the incompatible wheels failed in python with invalid instruction. Testing if the deps work out of the box for old versions is out of scope for this test. That should be handled by the existing tests that promote a given version, not retroactive tests.

New functionality

None

Test plan
How are these changes tested?
These fix tests on main

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Now that we build hnswlib wheels for 3.12, the old version of chroma fetches wheels which do not work

is this just the way our test is set up, or is this true for users who pip install as well?

I think it will break if you try to pip install chromadb with a hnswlib dep that does not have wheels on 3.12 on linux


docs: Updated docs on how to cope with typing env vars

Description
Doing what's written in the current documentation doesn't work.
Updating it to the suggested version works great.
I think it also resolves - https://github.com/vitejs/vite/pull/4928

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 added.


React Query and Next Image, Router components for homepage

Progress towards #112 by converting to client side rendering with caching through React Query and Next Image component. Also switching out router.push to Next Link component to prefetch individual posts.
Limitations of this approach is an initial loading delay, overlay has been included instead of loading text. Possible improvements could be adding a customized initial loading animation and optimizing the api with pagination, etc.

I think combination of initial animation, skeleton loading, and api optimizations should be a big improvement.


Add createdBy and assignedTo in task creation

API contract here
While creating a task using POST /tasks we need to add two more fields:
createdBy

This is to track who created that particular task.
This field shouldn't be sent from the frontend, it should be taken from the cookie itself on backend (reasons: I could send elon-musk in createdBy field from frontend, which is not something which we want 😉 )
This is going to be the userId of the user and not the username since userId will remain constant for a user, but username may change
Can be accessed via req.userData.id

assignedTo

This will track whom the task is assigned to
This will be coming from frontend as a string.
Frontend will be sending username here in req.body, we need to find userId corresponding to the given username and store that in the DB (there are functions in utils/users.js which will help you do this)

It should be clear by now that we will be storing userIds everywhere in the DB. There's a catch though, when we are recieving and sending data, it HAS to be username -- we can't expect developers to remember each other's userIds 😛
So in short, request and response will contain username but the DB will always contain the corresponding userId

I will work on it.


Removing service that has webhook reference causes screen to go blank

Rancher Version: master 12/26
Steps to Reproduce:

Create a service
Create a webhook that references that service
Delete the service
Go back to webhook screen.

Results: Screen is blank.  Error - "receiver.js:17 Uncaught TypeError: Cannot read property 'get' of undefined"
Expected:  No error, screen to redraw.

Discussed with @vincent99  and we decided that we'd only fix this in the UI for 1.3.
@tani do you want to verify @vincent99's fix for this and if that is good to go, assign back over to @mrajashree but change the milestone to 1.4?

Version - master 12/29 - Verified that the UI no longer blows up.  Sending back to rajashree for backend fix.

I don't think we should fix this one on the backend. The driver config is an opaque json blob as far as the webhook listing framework is concerned. The webhook is created independently of the service itself and should be managed separately by the user.

I still disagree, that it happens to be implemented as two independent APIs is not relevant to the user.  Particularly because you can't even edit a hook, there is literally nothing useful you can do with that hook once the associated service is gone.
We never return links (or IDs to things) that will fail anywhere else in the API.  Nor leave dangling ID references with no referential integrity in the DB (that I know of).

Version - master 1/17
Verified fixed


"Python Functions" and "Upload a Columnar file" doesn't appear when Installing Superset from Scratch

A clear and concise description of what the bug is:
Python Functions in the Advanced Analytics section of Explore Chart page doesn't appear when installing Superset from scratch (local installation with pip).
After I installed openpyxl and xlrd, the Upload Excel option appears, but after installing parquet and pyarrow, Upload a Columnar file still doesn't appear.
Expected results
what you expected to happen:
Expect all 3 options for file uploads to appear. Expect Python Functions to be available in the Advanced Analytics section.
Actual results
No Upload Excel (unless I install openpyxl and xlrd), Upload a Columnar file, and no Python Functions.
Screenshots

How to reproduce the bug

Install Superset from Scratch
Login at localhost:8088
3.a. Create a chart. Go to Advanced Analytics and see that there's no Python Functions.
b. Hover over Data tab, and see that there's no Upload Excel and Upload a Columnar file options
Stop server, run pip install openpyxl xlrd parquet pyarrow, run superset db upgrade; superset init, start server.
Go to localhost:8088 and see that Upload Excel has appeared, but no Upload a Columnar file

Environment
(please complete the following information):

browser type and version: Firefox Version 92.0 (64-bit)
superset version: 1.3.0
python version: 3.9.6
node.js version: v14.16.0
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here:
This bug doesn't appear when Installing Superset Locally Using Docker Compose.

@ismaildawoodjee have you tried install via docker?

I installed using Docker first. No problems there. Then I tried out Installing from Scratch, and the functionalities I mentioned above do not appear.

is there a reason you needed to uninstall Docker and build it from scratch?


aws-vault: 6.2.0 -> 6.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/aws-vault/versions.
meta.description for aws-vault is: "A vault for securely storing and accessing AWS credentials in development environments"
meta.homepage for aws-vault is: "https://github.com/99designs/aws-vault"
meta.changelog for aws-vault is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 6.3.0 with grep in /nix/store/87j058d43mfblxiyrpb6spaly4gkjdzm-aws-vault-6.3.0

directory tree listing: https://gist.github.com/e7c0ec40d2aa2822e865c1d542912799

du listing: https://gist.github.com/a092c7db28c53c5ad15c1b8db6d594f0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
aws-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/87j058d43mfblxiyrpb6spaly4gkjdzm-aws-vault-6.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-vault https://github.com/r-ryantm/nixpkgs/archive/682068e16ffe96bd0ce3ef41c494ac5cb3946b10.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/87j058d43mfblxiyrpb6spaly4gkjdzm-aws-vault-6.3.0
ls -la /nix/store/87j058d43mfblxiyrpb6spaly4gkjdzm-aws-vault-6.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

aws-vault

Maintainer pings
cc @zimbatm @kalbasit for testing.

WFM macos 10.14


[Flink AI Flow][Bug][unit test] When running run_tests.sh, sometime grpc UNAVAILABLE happens

Describe the bug
error version： 9dd9c6f
When running unit test locally with run_tests.sh, sometime grpc UNAVAILABLE happens.
The reproduce is random and seems related to machine spec/working condition.

The root cause should be: between two test cases, setup/teardown call grpc.server.stop and then grpc.server.start intermeditately, and sometime the following grpc clients do not wait enough time for grpc server/channel to get ready.
The issue may be able to get fixed by using grpc.channel.wait_for_ready before calling grpc client methods
Your environment
Operating system
Operating system
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
Database
mysql 8
Python version
3.7.11
To Reproduce
Steps to reproduce the behavior (if you can):
cd ./flink-ai-flow
./run_tests.sh

Expected behavior
All tests should pass.
Actual behavior
Sometimes, it shows grpc error
Screenshots

Additional context

close as fixed by https://github.com/alibaba/flink-ai-extended/pull/484


global is not defined

I want to use it for browser. This is my worker code.
var promise;
if(typeof Promise === undefined) {
self.importScripts('Promise.js').Promise;
}
promise = new Promise(function (resolve, reject) {
var url = ajaxArgs.url || '',
data = ajaxArgs.data || {},
type = ajaxArgs.method || 'GET',
isGet = type === 'GET',
request = new XMLHttpRequest();
..........

Are you using in a browser without a window object? If you look at the code, it

I have fixed the issue in this commit. https://github.com/taylorhakes/promise-polyfill/commit/049ec5cb21e6a43b66cff27c331570e5f07c9cea  Let me know if you are still seeing the issue.

I am using web workers, which do not have access to window object. So I am not able to use the Promise. To solve this issue, I used your polyfill promise by importing the script.

Can you help me on how I use this Promise in my web workers because now I am getting Promise as undefined.

The library didn't originally support Webworkers. I just added support with a new release. The previous logic was a little complicated.
module = { exports {} };
importScripts('Promise.js');
var Promise = module.exports;

promise = new Promise(function (resolve, reject) {
  var url = ajaxArgs.url || '',
  data = ajaxArgs.data || {},
  type = ajaxArgs.method || 'GET',
  isGet = type === 'GET',
  request = new XMLHttpRequest();
...

You should be able to use it how you wanted to originally now. Download version 2.0.2
importScripts('Promise.js');
promise = new Promise(function (resolve, reject) {
  var url = ajaxArgs.url || '',
  data = ajaxArgs.data || {},
  type = ajaxArgs.method || 'GET',
  isGet = type === 'GET',
  request = new XMLHttpRequest();
...


Remove bottom margin from info / warning boxes

Info / warning boxes have a margin-bottom: 1rem, which makes them a bit unbalanced vertically and they take more space.

Should we remove it?

I think that is coming from bootstrap itself (because there is a <p> inside the box).
But I agree it looks a bit off, so fine to remove some space for alerts.


The value of property "ciphertext" is longer than 1048487 bytes.

On onlinbe website
we've got this
The value of property "ciphertext" is longer than 1048487 bytes.
FirebaseError: The value of property "ciphertext" is longer than 1048487 bytes.
at new e (prebuilt-4888bff0-430c65bc.js:180:23)
at mn. (prebuilt-4888bff0-430c65bc.js:9829:35)
at At (index.esm.js:358:22)
at St (index.esm.js:338:50)
at In (index.esm.js:982:36)
at Tn (index.esm.js:1035:21)
at mn.Ua (index.esm.js:986:22)
at mn.za (index.esm.js:985:78)
at XMLHttpRequest. (instrument.ts:287:29)
at XMLHttpRequest.r (helpers.ts:87:17)
Seems to freeze all website : unable to share,  white page ...

There's a hard 1MB limit on Firestore documents. We should start compressing data before storing.


ME Capability Adapter randomly auto disable

Hello,
I'm playing Enigmatica 2 Expert 1.82a with the latest version of MECapabilityAdapter ( I manually updated it ).
So I have capabilityadapter-1.1.1 and appliedenergistics2-rv6-stable-7 on a server.
I have multiples ( 7 actually ) Me Capability Adapter with some thermal, mekanism, nuclearcraft, immersive machines.
Sometimes, the Me Capability Adapter stop functioning just after changing the AE network in the compact machine, for example : adding a smart cable,  put an pattern in a ME interface...
After that I have to break all the adapters in the overworld and replace them again. I tried to just cut the energy coming to the AE network and then powering it again but nothing change I still add the break/replace the adapter.
It's like the state of the adapter is lost after some AE events or something like that.
Do you have an idea of what is going on or do you need any pictures?

Re,
Well, I ruled out some problems by not connecting Me capability adapter with multiples Compact machines and force-chunk loading in compact machines, the problem seems to be gone, I will tell you if the problem still happens.

fixe


Event Grid: 2020-06-01 Swagger

Add swagger support for the new Event Grid GA'ed features for 2020-06-01-preview:
o	Event Delivery Schema
o	Input Mapping.
o	Custom Input Schema EventDelivery Schema
o	Cloud Event V10 Schema
o	Service Bus Topic As Destination
o	Azure Function As Destination
o	WebHook Batching
o	Secure webhook (AAD support)
o	ImmutableId
o	IpFiltering
o	Private Link
These features were already part of previous preview APIs and went through in person ARM review and customer/test validation
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

@yungezz can you plz help merge this pr? all checks passed and all changes were already in preview API versions already for some time now

Thank you @pilor  and @yungezz


Using attrs with subclassing Process from multiprocessing (2.7)

Here's sample code i cant get to work with attrs:
import attr
from multiprocessing import Process

@attr.s()
class MyProcess(Process):
      num = attr.ib()

      def __attrs_post_init__(self):
          super(MyProcess, self).__init__()

p = MyProcess(1)
p.start()
p.join()

I apologize, I should have included the error. Thank you


Request Supplemental Report

#1469 #1470
Changelog:

Added migration to add "Request Supplemental" status
pylint/pep8 fixes
Added buttons for Compliance Report and Exclusion Report for "Request Supplemental"
Front-end change to show "Requested Supplemental status in the list
Front-end change for the history to show "Requested Supplemental"

 Compliance Report | Request Supplemental Report |5|

 Exclusion Report | Request Supplemental Report |3|


Tags corresponding to LLVM releases

(Sorry, me again!)
It seems to me a common use case for many users would be building a specific LLVM release. However, I'm not sure this is always possible with the current setup, please correct me if I'm wrong.
For example, LLVM 11.1.0 was tagged at https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312. But there is no corresponding tag in this repository:
https://github.com/google/llvm-bazel/tree/llvm-project-1fdec59bffc11ae37eb51a1b9869f0696bfd5312
I'm guessing this is because the auto-integration step only considers commits on main, and this tag is on a release branch?
I'm not sure how hard it is, but it would be awesome if this repo contained versions for LLVM releases. Like llvm-project-<tag> corresponding to llvm/llvm-project@<tag>.

Good idea :slightly_smiling_face: We are developing so closely against LLVM that we don't really use releases, but I can understand why some people might. Your analysis of why we don't have a tag for this is correct.
That said, as I commented on that other issue, we're planning to move the contents of this repository upstream to the LLVM monorepo (https://github.com/llvm/llvm-www/blob/main/proposals/LP0002-BazelBuildConfiguration.md) in a side directory, so the precise mechanism for getting build files for the release would change (the current automation with the tags is pretty hacky and I haven't tried to productionize it because of the upstreaming hopes). There was some discussion of what this would mean for releases, but since no one had a use case we didn't go into too much detail. Whatever it was, it couldn't add to the burden of the release manager, since this is not going to be a supported part of the LLVM project, but I bet we could work something out if you've got a use case.
You can read some of the discussions linked from that proposal (personally I find it much easier to read them on https://groups.google.com/g/llvm-dev rather than pipermail) as well as the review for the patch: https://reviews.llvm.org/D94451
I really need to add that to the README...

I bet we could work something out if you've got a use case

I guess I assumed releases are more stable/robust than random commits on main? Isn't that what people usually use releases for?
Anyway, yes, not really worth fixing this since the end goal is in-tree build files.
I'm assuming if I want to do this I could try building the LLVM release tag against a nearby commit in llvm-bazel and hope for the best? Or do they need to match exactly?

Yeah I can certainly imagine the reasonable use cases :slightly_smiling_face: I just don't have a ton of interest in doing the work unless there's someone who does use releases who wants this functionality (it's unclear to me if you're saying that you use releases). We update the version of LLVM we're using ~daily because we're actively developing against it (and contributing patches upstream), so we don't have a use for release-specific build files.

I'm assuming if I want to do this I could try building the LLVM release tag against a nearby commit in llvm-bazel and hope for the best? Or do they need to match exactly?

The tags are really just a convenience to allow getting the "best known" build files for a given llvm commit without having to do a bunch of work. Assuming you're getting your copy of LLVM from somewhere other than the submodule within llvm-bazel (e.g. your own submodule or fetching an http_archive with Bazel) then there's nothing tying a given llvm-bazel commit to an llvm-project commit. And if you're only updating once per release or so, then it's not a big deal to manually find the right set of build files (including potentially forking to add some updates or using the http_archive patch mechanism). All this automation is really to support the use case of someone updating all the time. If I were to add  build files for the release to this repository, I would probably just create a branch for it and call it good. In fact, if this ends up blocking you before we get these upstream and you figure out what the build files need to look like for the llvm 11 release, I'd be happy to make that a branch on this repo. As a starting point, I'd choose the commit that was the base for the release before any cherry picks and see if the corresponding llvm-bazel commit works for that.

As for our use case, we're not actively developing against LLVM. We use it for eBPF, and some custom LibTooling based tools. I think for us a release version makes sense. And we're using llvm-bazel rather than a release tarball because we have a policy to build all third-party dependencies from source where possible.
Yes I'm perfectly happy to figure this out for one release. I just thought I'd raise an issue because I assumed others might have the same use case.
Thanks!

With the move of the build files upstream, this is obsolete. Having build files in a release meet some quality standard is something that could be brought up with the community overall, if desired.


BNS registrations in explorer

Would it be possible to add name registrations to the explorer? Ideally, there would be a link to the bitcoin hash data as well - maybe linking out to an independent bitcoin block explorer.

This will eventually happen, but we are blocked on the atlas/bns work that needs to happen. Once that is done and live, we'll be able to have a really tight integration with BNS :)

Things to do for this task are:

[ ] Display the BNS name on the account page
[ ] Link that BNS name to the tx page where it was minted
[ ] The tx page will have block height information


Update with PowerShell examples

The PowerShell method is much easier than REST API in many cases since you don't have to go through the extra authentication steps. Can that approach be fleshed out here?
In relation to that, the Restore example in the reference is pretty weird. Why would you create a new storage account right before restore? It's clearly just copy-pasted from the Backup example, but it should be edited to indicate that you are running this from whatever storage account you put the backup in.
https://docs.microsoft.com/en-us/powershell/module/az.apimanagement/restore-azapimanagement?view=azps-2.5.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 34eef662-c35f-230b-de28-0dcee463d8bc
Version Independent ID: 07206d86-8410-7a58-227a-6e630df50c16
Content: Implement disaster recovery using backup and restore in Azure API Management
Content Source: articles/api-management/api-management-howto-disaster-recovery-backup-restore.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

@dcbrown16 Thanks for the feedback! We have assigned this issue to the content author to review and update accordingly.

@dcbrown16 Could you please clarify where the documentation states to create a new storage account right before restore? I can't find this part.

Inactive
#please-close

@mikebudzynski sorry I missed this question. The new storage account is created in the PowerShell reference example that I linked in the first post.
https://docs.microsoft.com/en-us/powershell/module/az.apimanagement/restore-azapimanagement?view=azps-2.7.0&viewFallbackFrom=azps-2.5.0
I was hoping that something like this example could be brought over to the main document, or at the very least that the PowerShell commands mentioned in the main doc could get links to their reference pages. At the same time, however, I think the PowerShell example is a bit strange - one would expect you to have an extant storage account when you go in to restore. I think it's a copy/paste from the backup command.

@PramodValavala-MSFT please reopen if possible.

@dcbrown16 I've gone ahead and added the links to the powershell cmdlets at the end of the doc.
As for a complete sample, there is one listed under Samples > Azure Powershell


[FLINK-31450][table] Introduce ExecutableOperation for operations to execute

What is the purpose of the change
This pull request introduces an internal interface, ExecutableOperation to represent an operation that is executed for its side effects.
This internal interface is proposed to reduce the maintenance of bloated TableEnvironmentImpl#executeInternal(Operation) and improve code readability as execution logic is co-located with the operation definition. Besides, this interface can be used to extend user-defined operations with customized execution logic once this interface is stable and public in the future.
Brief change log

Introduce ExecutableOperation interface and make TableEnvironmentImpl supports it.
Migrate DropOperations to extend ExecutableOperation and move the execution logic of UseOperations out from TableEnvironmentImpl.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I like the idea of ExecutableOperation and extraction oof implementation of operations from TableEnvironmentImpl

Thank you all for reviewing. Merging...


fix(close-button): use 'latest' as default type and 'post' as default id

Fixes https://github.com/frontity/saturn-theme/issues/49

:tada: This PR is included in version 0.7.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


remove "command -V" check from resolveCommands()?

I would like to make a change to the resolveCommands() function in zopen-build and I'm seeking some feedback.  Currently this function checks for the existence of the command (like command -V ./configure) before it sets the appropriate envar.  Unfortunately at this point sometimes the commands don't exist yet!  For example in the expat build configure is created only after the bootstrap phase.  This currently causes the configure step to be skipped because zopen thinks the configure command doesn't exist. I would like to remove the command -V check altogether.  Thoughts?

Can whoever opened this identify themselves? Looks like it was opened by ZOSOpenTools. @IgorTodorovskiIBM ?


Fix attributes filter network documentation

The unstable allowed_attributes option was replaced but it was still visible on some documents.
After merging this PR, it must be backported to release-1.6.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.89%. Comparing base (c7c8ba5) to head (4bcb324).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #861       +/-   ##
===========================================
- Coverage   79.74%   35.89%   -43.86%
===========================================
  Files         117      114        -3
  Lines        8054     8026       -28
===========================================
- Hits         6423     2881     -3542
- Misses       1226     4782     +3556
+ Partials      405      363       -42

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
35.89% <ø> (ø)

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Master to Dev after 0.36.0 release

@zezha-msft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


CONFIGURATION-794: add test which demonstrates unclosed file handle

Code which reproduces the unclosed file handle problem.

Seems to be a Windows specific problem...

I added this:
commit b84a0ef5ad561e64e98f13e8b912003fda9f5469
Author: Gary Gregory<EMAIL_ADDRESS>2020-10-08 14:42:08
Committer: Gary Gregory<EMAIL_ADDRESS>2020-10-08 14:42:08
Parent: b773e0c309c5fbbe0ab4d36cd47370759589571b (Javadoc: Replace  HTML tags with Javadoc {@code} notation.)
Branches: master, origin/master
Add and ignore
testFileBasedConfigurationBuilder.testGetConfigurationLoadFromJarFile
based on https://github.com/apache/commons-configuration/pull/76
Fails on Windows:
java.lang.AssertionError: Unable to clean up temporary folder
C:\Users\ggregory\AppData\Local\Temp\junit4296513623415900710
at org.junit.Assert.fail(Assert.java:89)
at org.junit.rules.TemporaryFolder.delete(TemporaryFolder.java:274)
at org.junit.rules.TemporaryFolder.after(TemporaryFolder.java:138)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:59)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)

Should I close this PR since you added a test case like this to the master already? Do you have any idea why it fails on Windows?

You can close this PR or rebase it on master if you want to offer a fix or more tests.

It fails on Windows because the OS locks the jar files that it opens.

For future references: Fix was provided with commit https://github.com/apache/commons-configuration/commit/e0888d8afc1598a0e2b801d34023ba81ede32ee3#diff-6dd674b6f0044cb5f3b6a7e2ffc1800cc85bea034c7a87617f87f2a4ab38cb08R142 available from version 2.8.0+.

Actually it seems that it didn't make it into version 2.8.0...
@garydgregory can you confirm this? Release notes indicate that it was added for 2.8.0 but I cannot find the specific class in the JAR file (neither Bintray nor Maven Central).

Actually it seems that it didn't make it into version 2.8.0...
@garydgregory can you confirm this? Release notes indicate that it was added for 2.8.0 but I cannot find the specific class in the JAR file (neither Bintray nor Maven Central).

Version 2.8.0 is not out yet. See previous comment with link to git commit. Let us know if that does not match up with what you are looking for.

Version 2.8.0 is not out yet. See previous comment with link to git commit. Let us know if that does not match up with what you are looking for.

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?

Well, this is embarrassing. I mixed up the two components...
Do you have an estimate when the new version 2.8.0 of commons-configuration will be released?

Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?

Well, this is embarrassing. I mixed up the two components...
Do you have an estimate when the new version 2.8.0 of commons-configuration will be released?

As we have many components within Apache Commons, the confusion is
understandable :-) ! There is no release date set but it is on my to
do list after IO and LANG.
Gary
On Fri, Jan 29, 2021, 05:28 jansohn<EMAIL_ADDRESS>wrote:

Well, someone already did upload a version 2.8.0 for commons-io on Maven
Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO.
What am I missing?
Well, this is embarrassing. I mixed up the two components...
Do you have an estimate when the new version 2.8.0 of
commons-configuration will be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-configuration/pull/76#issuecomment-769720508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJB6NZZ5IHKKWNF2EXGW63S4KEV7ANCNFSM4SILZICA
.

As we have many components within Apache Commons, the confusion is
understandable :-) ! There is no release date set but it is on my to
do list after IO and LANG.
Gary
On Fri, Jan 29, 2021, 05:28 jansohn<EMAIL_ADDRESS>wrote:

Well, someone already did upload a version 2.8.0 for commons-io on Maven
Central and Bintray:

https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0

The title of this ticket is about the CONFIGURATION component, not IO.
What am I missing?
Well, this is embarrassing. I mixed up the two components...
Do you have an estimate when the new version 2.8.0 of
commons-configuration will be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-configuration/pull/76#issuecomment-769720508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJB6NZZ5IHKKWNF2EXGW63S4KEV7ANCNFSM4SILZICA
.


Can you add some custom  items in the ApiInfo build?

[ ] Feature Request

Adding this original intention is also to be able to display our signature rules and precautions directly in it, so that you don't have to let the development look at the word. Something like this moved to swagger。
such as..

@kkrgwbj sorry I dont understand what you meant. Could you explain in a different way perhaps?


[SPARK-9950][SQL] Wrong Analysis Error for grouping/aggregating on struct fields

This issue has been fixed by https://github.com/apache/spark/pull/8215, this PR added regression test for it.

cc @marmbrus

Merged build triggered.

Merged build started.

Test build #40967 has started for   PR 8222 at commit 7e2d8d9.

Test build #40967 has finished for   PR 8222 at commit 7e2d8d9.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class FilterNode(condition: Expression, child: LocalNode) extends UnaryLocalNode
abstract class LocalNode extends TreeNode[LocalNode]
abstract class LeafLocalNode extends LocalNode
abstract class UnaryLocalNode extends LocalNode
case class ProjectNode(projectList: Seq[NamedExpression], child: LocalNode) extends UnaryLocalNode
case class SeqScanNode(output: Seq[Attribute], data: Seq[InternalRow]) extends LeafLocalNode
public final class UTF8String implements Comparable<UTF8String>, Externalizable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40967/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #40980 has started for   PR 8222 at commit 0bbfb1c.

Test build #40980 has finished for   PR 8222 at commit 0bbfb1c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40980/
Test PASSed.

Thanks!  Merged to master and 1.5


hand tracking for Quest 2?

Oculus Quest 2 provides a hand tracking feature, see here: https://support.oculus.com/articles/headsets-and-accessories/controllers-and-hand-tracking/hand-tracking-quest-2/
I wonder if the OpenXR toolkit aims at supporting Quest 2 hand tracking as part of the hand tracking feature in the future?
references:
https://support.oculus.com/articles/headsets-and-accessories/controllers-and-hand-tracking/hand-tracking-quest-2/
https://uploadvr.com/best-oculus-quest-hand-tracking/

There's a catch- it must support hand tracking via the standard OpenXR extension, which did not appear to be the case last time I checked.
However, today I have heard that v37 might have brought up support, see my message here:
https://forums.flightsimulator.com/t/hand-tracking-in-msfs-leap-motion-ultraleap-native-support-for-wmr-openxr/475308/355?u=mbucchia
I don't have a device so I cannot try. Maybe you can follow the steps from my forum post above and give me the output of what OpenXR Explorer gives you?

sure, happy to try. the forum thread is quite long - could you provide the link to the steps to be reproduced here?

My link is to a specific message,  message 355, which is from today (3 posts from the bottom).

it seems to have XR_EXT_hand_tracking

Good start. Looks like your headset maybe not plugged in?
Can you try again, I need to see the stuff on the left pane too. There should be a "supportHandTracking".

pm sent on LinkedIn

I prefer we continue here, plus other developers can then see it.

No activity so I am closing. Meanwhile someone on discord actually provided the necessary info and I will be working with it.

If you still need help i can provide scrrenshots if you want!

Thank you! I think I have everything we need right now.
I should work, but I have to write up some instructions. Please see https://forums.flightsimulator.com/t/hand-tracking-in-msfs-leap-motion-ultraleap-native-support-for-wmr-openxr/475308/355?u=mbucchia and the messages after that one for the latest status.

It's been confirmed to work on Quest 2, with a modifications to the config file. Please see the forum link above.


How to enable manual garbage collection (--expose-gc) in workers/brokers?

... for running the global.gc() function.

Since v2.3.13, worker processes inherit execArgv from the master process. So to expose gc throughout SC, you just need to add the --expose-gc CLI argument before your script's name.
E.g:
node --expose-gc server

Note that if you disable the default gc using --nouse-idle-notification, you may also want to set the killWorkerMemoryThreshold when initiating your SocketCluster class in server.js. See the killWorkerMemoryThreshold option from the constructor method here: http://socketcluster.io/#!/docs/api-socketcluster


Allow to extend others props on the VirtualizedList

Hi, i am so happy that i found this project, thank you so much.
I was trying to add some props from the VirtualizedList, but no extra props is added to the VirtualizedList in the same way that FlatList does, and i am also aware that's not all props that works with the way the masonry works (such debug prop),  but i mean more in basic props such as initialNumToRender and windowSize.
Could we add this?
Thank you.

Looks good thanks!


desktop landing page

helped add content to desktop landing page along with mayana

w

worked on the desktop landing page both hi-fi andlo-fi
https://www.figma.com/file/LEKdq0JqyuzzOGxv0tZWjh/WalletFriendly?node-id=530%3A2028

worked on the desktop landing page both hi-fi andlo-fi
https://www.figma.com/file/LEKdq0JqyuzzOGxv0tZWjh/WalletFriendly?node-id=530%3A2028


Build failed in mina.netty: NioDatagramConnectorExIT

Build 60 failed on oracle and open jdk with the following test failing in mina.netty:
Running org.apache.mina.transport.socket.nio.NioDatagramConnectorExIT
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.468 sec <<< FAILURE! - in org.apache.mina.transport.socket.nio.NioDatagramConnectorExIT
shouldConnect(org.apache.mina.transport.socket.nio.NioDatagramConnectorExIT)  Time elapsed: 0.426 sec  <<< FAILURE!
java.lang.AssertionError: not all expectations were satisfied
expectations:
  expected once, already invoked 1 time: ioHandler.sessionCreated(instance of org.kaazing.mina.core.session.IoSessionEx)
  expected once, already invoked 1 time: ioHandler.sessionOpened(instance of org.kaazing.mina.core.session.IoSessionEx)
  ! expected once, never invoked: ioHandler.sessionClosed(instance of org.kaazing.mina.core.session.IoSessionEx)
what happened before this:
  ioHandler.sessionCreated(<(0x00000001: nio datagram, client, /<IP_ADDRESS>:52995 => /<IP_ADDRESS>:2101)>)
  ioHandler.sessionOpened(<(0x00000001: nio datagram, client, /<IP_ADDRESS>:52995 => /<IP_ADDRESS>:2101)>)
	at org.jmock.lib.AssertionErrorTranslator.translate(AssertionErrorTranslator.java:20)
	at org.jmock.Mockery.assertIsSatisfied(Mockery.java:199)
	at org.apache.mina.transport.socket.nio.NioDatagramConnectorExIT.after(NioDatagramConnectorExIT.java:63)

I was successfully able to build on my machine just now, so apparently this is a sporadic failure, probably not caused by the previous commit.

This is probably happening because the org.kaazing.mina.core.filterchain.DefaultIoFilterChain.fireSessionClosed() method:
{code:java}
public void fireSessionClosed() {
// Update future.
try {
session.getCloseFuture().setClosed();
} catch (Throwable t) {
fireExceptionCaught(t);
}
    // And start the chain.
    Entry head = this.head;
    callNextSessionClosed(head, session);
}

{code}
sets the close future to closed before firing this session closed event on the filter chain which will cause handler.sessionClosed to be called (from the Tail filter), so the expectation for handler.sessionClosed may not be fulfilled if the test completes before that method gets invoked.
:

Fixed by pull request #74 which has been merged.


Adding details for auto backport

Signed-off-by: Vacha Shah<EMAIL_ADDRESS>Description
Coming from https://github.com/opensearch-project/opensearch-plugins/issues/108#issuecomment-1034355435, adding details for auto backport in a .md file.
Issues Resolved
[List any issues this PR will resolve]
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md.

Also, a blog post on adopting backport automation would be great for the blog!

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md - that's where we tell maintainers to enable CI and DCO.

MAINTAINERS.md sounds like a good place for it. CONTRIBUTING.md might not be applicable since auto backports require adding labels to PRs and the Review Process says the maintainers will take care of backporting. WDYT?

Also, a blog post on adopting backport automation would be great for the blog!

Yes, I am going to work on drafting a blog for this.

I think that the developer part of how to use backporting should go into CONTRIBUTING.md and the admin part of how to set it up should go into https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md - that's where we tell maintainers to enable CI and DCO.

MAINTAINERS.md sounds like a good place for it. CONTRIBUTING.md might not be applicable since auto backports require adding labels to PRs and the Review Process says the maintainers will take care of backporting. WDYT?

Yep, you're right.


feat(cli): Added reload-include and reload-exclude in litestar cli

Closes #2875

Thank you!
Could you add the matching tests in (i think) https://github.com/litestar-org/litestar/blob/main/tests/unit/test_cli/test_core_commands.py?

Thank you!
Could you add the matching tests in (i think) https://github.com/litestar-org/litestar/blob/main/tests/unit/test_cli/test_core_commands.py?

Thank you too!) I will send a PR tomorrow with tests for new teams

@ashm-tech Please rebase from develop and change the target to develop; This is a new feature and will go into the next minor release, which is being developed on that branch.


Flutter Plugin(ver 38.2.4) cause android studio not to start properly

Steps to Reproduce

Upgrade Android Studio to Version 3.6 Canary 8
Install flutter plugin with newest version
Restart Android Studio and Android Studio can't start properly.

Delete flutter-intellij folder from %USERPROFILE%\.AndroidStudioPreview3.6\config\plugins path.
Android Studio can start properly.

Output

[√] Flutter (Channel stable, v1.7.8+hotfix.4, on Microsoft Windows [Version 10.0.18362.295], locale zh-CN)
    • Flutter version 1.7.8+hotfix.4 at C:\Develop Tools\flutter
    • Framework revision 20e59316b8 (6 weeks ago), 2019-07-18 20:04:33 -0700
    • Engine revision fee001c93f
    • Dart version 2.4.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at E:\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = E:\Android\sdk
    • Java binary at: C:\Develop Tools\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.
[√] Android Studio (version 3.6)
    • Android Studio at C:\Develop Tools\Android Studio
    • Flutter plugin version 38.2.4
    • Dart plugin version 192.6527
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

Please post the issue to https://github.com/flutter/flutter-intellij as well.

There is already some issues there https://github.com/flutter/flutter-intellij/issues/3840 and https://github.com/flutter/flutter-intellij/issues/3834, should we close this one?


⚠ Bofrost.at has degraded performance

In 98e5f51, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 977 ms

Resolved: Bofrost.at performance has improved in 26d3192 after 27 minutes.


Prettier 1.2.2, refactor runCommand

Summary
Update Prettier to 1.2.2. This required a little change in prettier.js script, so be sure to check that.
I've also unified runCommand's args argument to always be an array, as passing a space-separated string caused problems when filename had a space in it.
Test plan
CI green.

Codecov Report

Merging #3352 into master will not change coverage.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##           master    #3352   +/-   ##
=======================================
  Coverage   64.93%   64.93%
=======================================
  Files         176      176
  Lines        6514     6514
  Branches        4        4
=======================================
  Hits         4230     4230
  Misses       2283     2283
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/vendor/jsonlint.js
55.72% <ø> (ø)
:arrow_up:

...s/jest-editor-support/src/parsers/BabylonParser.js
98.64% <ø> (ø)
:arrow_up:

packages/jest-runtime/src/index.js
75% <ø> (ø)
:arrow_up:

.../eslint-plugin-jest/src/rules/no-disabled-tests.js
94.44% <ø> (ø)
:arrow_up:

...s/eslint-plugin-jest/src/rules/no-focused-tests.js
94.44% <ø> (ø)
:arrow_up:

packages/jest-runtime/src/shouldInstrument.js
68.18% <ø> (ø)
:arrow_up:

...ests/coverage_report/not-required-in-test-suite.js
20% <ø> (ø)
:arrow_up:

packages/jest-cli/src/TestWorker.js
0% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/reporter.js
85.29% <100%> (ø)
:arrow_up:

packages/jest-changed-files/src/git.js
92.85% <100%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9288e4...24f289e. Read the comment docs.

Rebased and disabled computed-property-spacing eslint rule.

awesome!


Adopt TCA 1.2.0

https://github.com/pointfreeco/swift-composable-architecture/releases/tag/1.2.0

resolved in #902


Write e2e tests

As suggested by @nkbt in #30. Maybe we could use nixt.

I'll take it. Want to try nixt as it looks pretty sick. Hopefully will get some base tests out later today

Sweet. I've never used nixt. Looking forward to what you come up with!

Hm nixt does not seem to work properly for me. Spent a bit of time with it, but no luck yet.
https://github.com/vesln/nixt/issues/16
Maybe I will go with bash then for the moment, or look for some nicer alternative... Not today tho

Cool. See if you can make it work cross-platform so we don't shut out windows users.

That might be a concern, though I expected to run e2e on CI to begin with. Generally I doubt it is possible to do completely cross-platform CLI testing, since shell scripts will be running in background anyway =(.

Makes sense. I think we're OK if it's only running in CI

Since nixt is not really working and writing shell scripts at home on my Windows was not an easy option, I  fixed a cli-tester. Not particularly a rocket science thingy...
Had some fun making it work smoothly on all Node versions down to 0.10 (so it is ok with p-s matrix build).
Welcome =)

Cool! Looking forward to seeing the pull request!


Is it possible to also strip br tags?

Of course! It strips all tags. Here's an example.
let striptags = require("striptags");
let html      = '

meow

';
let output    = striptags(html);

return output;

Results in
'meow'

I can't believe i missed that.
Thanks for the quick response


Bot with Y-name missing

There are names for bots for every standard letter in the latin alphabet, except for "Y".
This really needs to be fixed!
I suggest Yaseen.

Added Yoko in 050d9be7e0d9a27422dab27debdebbac98d89c11