[R-package] Add pkgdown documentation support

I will be adding pkgdown support to the documentation of LightGBM.
You can check the branch here: https://github.com/Laurae2/LightGBM/tree/pkgdown
To add support for pkgdown, it will require the following tasks:

[x] Find hosting for the pkgdown documentation (I'll host it, max number of simultaneous users basically infinite thanks to static site hosted on CDNs)
[x] Add badges to R README.md
[x] Change a bit the README.md documentation
[x] Add Authors@R field in DESCRIPTION (@guolinke (aut+cre) + @Laurae2 (ctb) + @yanyachen (ctb) )
[x] Fix Author field in DESCRIPTION
[x] Move Matrix and methods to Depends instead of Imports (fixes many instances of example crashes)
[x] Fix all instances of crashes in function examples
[x] Update date of DESCRIPTION
[x] Regenerate the whole documentation from scratch
[x] Run successfully pkgdown::build_site() on the R-package folder without vignettes
[x] Convert demos to vignettes
[x] Find workarounds for all function examples which crashes and cannot have a direct or immediate workaround
[x] Fix all instances of crashes in vignettes
[x] Find workarounds for all vignettes which crashes and cannot have a direct or immediate workaround
[x] Run successfully pkgdown::build_site() on the R-package folder with vignettes

Extras:

[ ] Add Travis support for running pkgdown so it can perform all examples / vignettes test in one straight command: pkgdown::build_site(run_dont_run = TRUE) (no idea how to do it, if someone can contribute to do it for us that would be great...)

I'm sharing my setup for running pkgdown quickly:
# Load useful libraries for development
library(devtools) # install.packages("devtools")
library(roxygen2) # devtools::install_github("klutometis/roxygen")
library(pkgdown) # devtools::install_github("hadley/pkgdown")

# Set the working directory to where I am
setwd("E:/GitHub/LightGBM/R-package")

# Install package
install()

# Generate documentation
document()

# Check for errors
# devtools::check(document = FALSE) # fails/crashes on LightGBM

# Build static website
pkgdown::build_site(run_dont_run = TRUE) # currently fails/crashes

# Remember to cleanup R-package/src folder after testing (keep only install.libs.R, Makevars, Makevars.win)
# Remember to delete R-package/docs after testing

It will look like this:

Too much advanced example, gives a good baseline of what we can do with pkgdown: https://keras.rstudio.com/index.html

Another (very simplified) example (live): https://laurae2.github.io/LauraeDS/

@Laurae2  For Travis support, you can see:  https://github.com/ropenscilabs/tic#example-applications . I would like to contribute to the LightGBM, but I need some time to get familiar to the package functions.

@Laurae2 Does pkgdown only work for R package ?

@guolinke pkgdown is only for R, I don't know if there are equivalents existing for Python

I guess pkgdown runs just like jekyll, you can see the template, and the function render_template
If you want to build a Python package html pages, maybe  pystache can give you some hints ☺

@BruceZhaoR thanks for interesting in contribution.
You are very welcome, and feel free to ask us if you met any problems.

@Laurae2 any updates ?

@guolinke Didn't find time to work on it currently, this month I have more free time so I might try to do it again.

@Laurae2  I just used pkgdown built my package website: https://brucezhaor.github.io/pjutils/index.html
Want to know if you need any help now?

Is anybody here familiar with conda R environment setup? In case we can manage to build LightGBM R package inside a conda environment, we can build the documentation directly on RTD site along with all other our docs without the need to host GH pages and separate Appveyor job.
I tried to do this today, but without any luck. I installed r-base, r-essentials, make, cmake, m2w64-gcc (I was using Windows) and performed some fixes to make everything work together.
The error after which I abandoned this idea happened on this line of @BruceZhaoR's pipeline. It was
...
cmTC_0b207/fast           0 [main] make 2328 find_fast_cwd: WARNING: Couldn't compute FAST_CWD pointer.  Please report this problem to     the public mailing list<EMAIL_ADDRESS>   /Scripts/make -f CMakeFiles\cmTC_0b207.dir\build.make CMakeFiles/cmTC_0b207.dir/build
...
  The C compiler is not able to compile a simple test program.

and some words about unknown directory, which led me to the following MSYS issue and this fix which seems to be not included in MSYS from conda.

😱
I have used R conda environment to get around Travis not have great built-in support for MacOS + Python (https://github.com/jameslamb/doppel-cli/blob/master/.ci/setup.sh)
Based on that line, are you saying this is failing on installing LightGBM R package itself? Or some dependency for docs?
I'm willing to help with this 😀

(p.s. here is the background, in case you're wondering "why did James say he uses conda R environment to solve a Python issue")

@jameslamb It seems to be a Windows specific issue with MSYS in conda where compiling fails due to a missing pointer from the compiler (not from the compiled software).
@StrikerRUS for RTD can you use R without conda if for Windows or is it required to have conda? Most Windows users will use the standard R installation.

@jameslamb @Laurae2 Thanks for your replies!
@jameslamb Thanks a lot for your links! I'll try to use CI to find out are any other MSYS issues presented in conda's R environment when I have time for it. Also, any help is appreciated, because it's quite uncomfortable to investigate it with CI, local Linux environment will be easier and faster 😃 .
@Laurae2 I'm talking just about the possibility of building the docs on RTD site directly, not about any CI tests or producing R-artifacts for users from this (ugly conda) R environment. So, we just need to be sure that this environment is sufficient for building docs, which requires building the package itself, and not need to worry about any compatibility issues with on users' side.
@Laurae2
RTD provide a few variants for us. Here what we have:

any package from pip (not our variant): https://docs.readthedocs.io/en/latest/config-file/v2.html#python
any conda package (I see the only this variant can be used): https://docs.readthedocs.io/en/latest/config-file/v2.html#conda (BTW, I'm not sure whether we can mix pip and conda)
any pre-installed software from their docker (I see no R-related things, so not our variant; also, I suppose that it's bad idea to rely on this docker, since it can be changed in any time without any notifications): https://github.com/rtfd/readthedocs-docker-images/blob/master/Dockerfile
setup R-environment from our conf.py file (~WTF!~ not sure it's good idea).

@Laurae2 Speaking about normal standard R installation, I've already told @jameslamb but you don't know yet that I successfully configured R environment at Travis and Appveyor for another project. We can borrow that code for testing purposes of LightGBM R-package. But I think that it falls outside the scope of this issue, we can create another one to discuss this.

OK, seems that R from conda on Linux is less broken compared to one on Windows. 😄
So, I had some success in the setup of R docs with the help of pkgdown on RTD site.
Everyone who is interested in helping me is welcomed in #2176.

As requested by @jameslamb, I'm posting here a TO-DO list, which was removed from the source code:
Replace build_r_site.R scrip with one single call of pkgdown::build_site(run_dont_run = FALSE, ...)
To do this the following sub-tasks should be done first:

[ ] build_articles(preview = FALSE)
[ ] build_tutorials(preview = FALSE)
[ ] build_news(preview = FALSE)

Finally #2176 has been merged recently! 🎉
See https://github.com/microsoft/LightGBM/issues/1143#issuecomment-493770556 for actions required to resolve this issue completely.
Now this issue entirely depends on #1944. After rewriting demos it should be rather straightforward replace build_r_site.R file with single pkgdown::build_site() call.
Also, here are some known issue:

broken links for sources of the R-API due to that R-package is located in  a sub-folder at GitHub. As I know, it's not fixable unfortunately.

strange rendering of dimnames function

incomplete list of authors at the main page

According to the policy from #2302, I'm closing this issue as I'm not working on it anymore.

@jameslamb Can you please take a look at known issues 2 and 4? I have an intuition that they are pretty easy to fix, but unfortunately my lack of knowledge of R doesn't allow me to do it.

On number 4...I will take a look. both lightgbm and lgb_shared_params are things I introduced to consolidate some duplicated documentation, but maybe roxygen2 isn't playing nicely with them. I'll try to take a closer look.
For number 2, what do you think is wrong with it? That looks like a faithful representation of the code. It just looks weird because R thinks those are S3 methods, not plain-old functions. That is the danger of choosing function names with dots in them (a practice that is generally discouraged for R code) but now that we have them, I don't think there is much we can do.

@jameslamb

For number 2, what do you think is wrong with it?

I worried about duplicated entry for one method (its' appearance differs from all other methods) and ` signs around the name. In short, is it OK? 😃

Just noticed that callback.R is not documented at all. Adding this to known issues.

@jameslamb

For number 2, what do you think is wrong with it?

I worried about duplicated entry for one method (its' appearance differs from all other methods) and ` signs around the name. In short, is it OK? 😃

yes I think it is ok! The backticks are actually valid R code in that case (they are the way that you create symbols in R which use characters like < that have other meaning)

@StrikerRUS

incomplete list of authors at the main page

For number 3, the are two ways to fix it:

Modify the DESCRIPTION,  Auhtors@R  part,  add aut/cre/fnd to role. Because these 3 roles are the main auhtors, and will display in the sitebar part.

Authors@R: c(
	person("Guolin", "Ke", email =<EMAIL_ADDRESS>role = c("aut", "cre")),
	person("Damien", "Soukhavong", email =<EMAIL_ADDRESS>role = c("aut", "ctb")),
	person("Yachen", "Yan", role = c("aut", "ctb")),
	person("James", "Lamb"<EMAIL_ADDRESS>role = c("aut","ctb"))
	)

due to the pkgdown code:
https://github.com/r-lib/pkgdown/blob/b6eec62574f1a0087c70eeb6574d6af0435828ff/R/build-home-authors.R#L9-L11

add sidebar html code in the _pkgdown.yml file.

home:
  sidebar: "

Links

Browse source code at
https://github.com/Microsoft/LightGBM

Report a bug at
https://github.com/Microsoft/LightGBM/issues

License

MIT + file LICENSE

Developers

 Guolin Ke
  Author, maintainer

 Damien Soukhavong
  Contributor

 Yachen Yan
  Contributor

 James Lamb
  Contributor

All authors...

"

due to the pkgdown code:
https://github.com/r-lib/pkgdown/blob/b6eec62574f1a0087c70eeb6574d6af0435828ff/R/build-home-index.R#L56-L69

@BruceZhaoR Thanks a lot for your investigation! Ah, they have role filter without the possibility to overwrite it, nice!
https://pkgdown.r-lib.org/reference/build_home.html#yaml-config-authors
I saw someone tried to specify roles in _pkgdown.yml, but seems it's pointless.
https://github.com/DeclareDesign/fabricatr/blob/cf0dfe71e9ff064c09a03330f5f805b960b18839/_pkgdown.yml#L13-L17

For number 3, the are two ways to fix it:

I'm leaving this for R maintainers decision.

https://pkgdown.r-lib.org/reference/build_home.html#yaml-config-authors

Yes, it is hard-coded. Only the three roles cre,aut,fnd in the DESCRIPTION can be modified in the Developer sidebar.
Maybe we can open a issue?

I saw someone tried to specify roles in _pkgdown.yml, but seems it's pointless.
https://github.com/DeclareDesign/fabricatr/blob/cf0dfe71e9ff064c09a03330f5f805b960b18839/_pkgdown.yml#L13-L17

It can't be reproducible and pkgdown do not have the roles_include param as far as I know，maybe the author edited the html to change the aut to Contributor.

I think that the current state of our pkgdown stuff, including new changes from #3072 , is sufficient to keep this issue closed. I've marked this :ballot_box_with_check: in #2302 as I don't think any additional work is required
pkgdown site: https://lightgbm.readthedocs.io/en/latest/R/index.html
For more targeted recommended fixes, like #3036 , please create new issues.

@jameslamb Please comment on this: https://github.com/microsoft/LightGBM/issues/1143#issuecomment-493770556.
I thought this issue should be closed after that we can simplify our build_r_site.R script up to simple call of pkgdown::build_site(). We can't (?) do this right now due to remaining TODOs from the comment above.

Ah ok, apologies for missing that commentt.
I'm confused by that comment @StrikerRUS ,can you clarify?
I just ran this and it produced a site that looks identical to our current site:
Rscript build_r.R
cd lightgbm_r
Rscript -e "pkgdown::build_site(install = FALSE)"

If I understand correctly, https://github.com/microsoft/LightGBM/issues/1143#issuecomment-493770556 is actually three areas for improvement that should be documented in their own issues

build_articles(preview = FALSE): by this do you mean "have vignettes"? Writing vignettes in #1944 will automatically get us an Articles section from pkgdown
build_tutorials(preview = FALSE) : this is specific to learnr tutorials, something we haven't talked about creating before. I think it's interesting but I'd rather describe it in its own issue
build_news(preview = FALSE): you will also get this automatically if a NEWS.md file is included in the R package's

If you agree with my comment above, I'll break these into individual issues. That will be a lot more manageable for contributors than parsing the comments in this issue, I think.

@jameslamb Thanks a lot for your explanation!
Actually, I thought that not having those sections in R-package will cause a failure in site building process. In other words, they are required. Now I understand that they are optional.
I'm absolutely OK with breaking this meta-issue into individual ones!
But given that you've said, I believe it is enough to have only #1944.
Can we now replace
https://github.com/microsoft/LightGBM/blob/5cc38e6aa363e6d04a62bcc5e36ea04ca36e917f/build_r_site.R#L10-L20
with build_site() as it doesn't crash without some sections? And after resolving #1944 we'll get articles section at RTD automatically.

I think so, yes! Once we merge #3086 , can you leave the fix/remove-devtools branch enabled on readthedocs?
I'll try pushing a change that replaces build_r_site.R with Rscript -e "pkgdown::build_site(install = FALSE)".
Thanks for all your work getting the R documentation set up!

Sure! Thank you!

^ #3098 removes build_r_site.R


Have lint rules only return one descriptor struct.

Previously, we had Name() and GetDescription() in
each lint rule, this is replacing this with one
call GetDescriptor() that returns a struct.
This now also allows to have the configuration options
described in that meta-data.
The result is a lot less boilerplate and more readable
descriptions of lint rules.
Did away with the different formatting styles in the
descriptor (markdown vs. text), as markdown is sufficiently
readable text anyway. There are still a few remnants that need
to be cleaned up, but this is a good first start.
Manually verified that the generated markdown description
is essentially the same.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #911 (2e227f0) into master (6743872) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

:exclamation: Current head 2e227f0 differs from pull request most recent head 1beac8b. Consider uploading reports for the commit 1beac8b to get more accurate results

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   92.57%   92.54%   -0.04%
==========================================
  Files         316      316
  Lines       20362    20279      -83
==========================================
- Hits        18850    18767      -83
  Misses       1512     1512

Impacted Files
Coverage Δ

verilog/analysis/checkers/endif_comment_rule.h
100.00% <ø> (ø)

...checkers/forbid_consecutive_null_statements_rule.h
100.00% <ø> (ø)

verilog/analysis/checkers/line_length_rule.h
100.00% <ø> (ø)

verilog/analysis/checkers/macro_name_style_rule.h
100.00% <ø> (ø)

...nalysis/checkers/macro_string_concatenation_rule.h
100.00% <ø> (ø)

verilog/analysis/checkers/module_filename_rule.h
100.00% <ø> (ø)

verilog/analysis/checkers/no_tabs_rule.h
100.00% <ø> (ø)

...erilog/analysis/checkers/no_trailing_spaces_rule.h
100.00% <ø> (ø)

...alysis/checkers/numeric_format_string_style_rule.h
100.00% <ø> (ø)

...rilog/analysis/checkers/one_module_per_file_rule.h
100.00% <ø> (ø)

... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6743872...1beac8b. Read the comment docs.


Add example for each image rendered in the book

Refactor the code to allow rendering each image in the book.
Ensure that the scenes module is reused across the examples.

The code organization here : https://github.com/fredmorcos/tvrank/blob/main/lib/ and here https://github.com/image-rs/image/blob/master/Cargo.toml were helpful for reorganizing and writing the toml files correctly.


Total downloads does not count all releases

Are you experiencing an issue with...
shields.io
🐞 Description
The number in the total downloads badge for our repo has been fluctuating lately. We believe the issue is the badge is only counting downloads for the most recent 500 releases, instead of paging over all API result pages for every release.
🔗 Link to the badge
https://img.shields.io/github/downloads/aquasecurity/tfsec/total
💡 Possible Solution
Iterate over each page of the GitHub API call results using per_page=1000 and page=N.
I think the issue is here: https://github.com/badges/shields/blob/23c0406bedfc6930735e8f5ea75dfe34faf1f290/services/github/github-downloads.service.js#L246-L251

I think the max value for per_page on this endpoint is 100, not 1000 (or 500)
https://api.github.com/repos/aquasecurity/tfsec/releases?per_page=500
returns the first 100 items

I'm not sure how common this will be in practice, but we may need something similar to the approach we had to take for the Docker badges of firing off the requests for the pages in parallel. If we have to go through the 5+ page sequence synchronously then I wouldn't be surprised if we run into timeout issues

The other challenge is that while we could theoretically have a max ceiling of two sequential calls with the v3 API (since we can calculate the calls for each page and fire them in parallel). However, I'm not sure the same is viable with graphql, as the latter will require us to actually iterate through each page one by one. This is unfortunate as it's tough to rationalize increased investment in v3 at this point.


Feature: search for radio stream title from full screen player

This adds the feature to click the radio stream title in the full screen player and perform a global search for it.
I think this will be useful to have despite the varying quality and junk sometimes appearing in the stream title metadata!  Despite that, search makes a pretty good job and user can modify the search manually if needed.
Routing to /search when it's already the current route does nothing, so I used the eventbus to notify the seach component - couldn't think of a better way.

I'm assuming we're protected from searching that oddly formatted stream metadata coming from littlebobbytables FM, right? 😅 https://xkcd.com/327/

I'm not sure this is good;
a) there is no common format for streamtitle, radio stations just mess around.
b) like you already discovered some radio stations have jiberish in this stream title, some even put xml or json in there.
c) I'm not sure of the search is well protected
Overall the outcome will not be predictable and cause confusion.
Maybe we can do a safeguard and only start search if there's a hyphen in the title.
Filtering out the jibberish items is something to add to the backend, there is already an issue report open for that:
https://github.com/music-assistant/hass-music-assistant/issues/2136

FYI, this is where the server parses this streamtitle from the icy chunk:
https://github.com/music-assistant/server/blob/main/music_assistant/server/helpers/audio.py#L538

I know, you're correct, the search results will be unpredictable.  I totally get the desire to present a nice clean uniform interface like the rest of MA - the insistence on properly tagged files etc is a good design decision to achieve this.
But MA is not in control of the metadata on these radio streams and trying to massage the data to present uniformity is going to be very difficult given the abuse of fields out there.  Not saying it's useless to try for some of the more structured examples, but for every title the parsing rules fix, there will be another they will butcher, ending up in bug reports and a game of regex whack-a-mole.
There may have to be an acceptance on the user's part that radio stream titles could be very messy in the player.  Post 2.0, could make showing the radio stream title a config opt-in setting with a ? Help explanation about the reasons why and a section in the docs.
For this PR's feature (assuming you want to have this feature in without the config setting above ) there are a couple of other options available to make it less surprising in the UI.  Remove the clickable title and either:

Add a magnifying glass search button next to the title
Add a button to copy title to clipboard
Change the CSS rules to make the title manually-selectable

c) I'm not sure of the search is well protected
Which ever option it is, this needs confirmed of course.

Now I have radio browser available I'm discovering quite a lot of new songs on stations that I want to add to my library, so having an easy method of searching for it within MA would be nice!  Up until now I've been resorting to shazam->spotify.

I had a quick look at the station in https://github.com/music-assistant/hass-music-assistant/issues/2136 looks like it's one of these hls stations - didn't you say somewhere there's a new method for getting metadata from these type of streams?
Looks like that station is blocking certain user-agent strings - got a 403 forbidden in MA when trying to retrieve the playlist:
wget --user-agent="Python/3.11 aiohttp/3.9.3" https://wz2liw.scahw.com.au/live/22000s_128.stream/playlist.m3u8 # 403 Forbidden using MA's UA string
wget https://wz2liw.scahw.com.au/live/22000s_128.stream/playlist.m3u8 # 200 using default wget UA

I had a quick look at the station in music-assistant/hass-music-assistant#2136 looks like it's one of these hls stations - didn't you say somewhere there's a new method for getting metadata from these type of streams?
Looks like that station is blocking certain user-agent strings - got a 403 forbidden in MA when trying to retrieve the playlist: wget --user-agent="Python/3.11 aiohttp/3.9.3" https://wz2liw.scahw.com.au/live/22000s_128.stream/playlist.m3u8 # 403 Forbidden using MA's UA string wget https://wz2liw.scahw.com.au/live/22000s_128.stream/playlist.m3u8 # 200 using default wget UA

I don't think so. HLS streams have no ICY metadata but their own way of setting metadata (not really supported by many providers).
User agent of MA when streaming is not aiohttp but ffmpeg useragent.

User agent of MA when streaming is not aiohttp but ffmpeg useragent.

The 403 is returned when the playlist is retrieved:
https://github.com/music-assistant/server/blob/main/music_assistant/server/helpers/playlists.py#L134
Anyway just something I noticed - it's not causing an issue with playing the stream or getting the metadata.  The url in the playlist seems to be the same as the stream url but with a unique identifier on the end, for tracking I guess.

Just noticed that as it is now, if the metadata has no dash in it, it doesn't only make it non-clickable, it won't even show it.  I'll add a fix for that.


[crashtracker] Make C example emit a file

What does this PR do?
What it says on the tin
Motivation
The current C example was hard to follow, since you needed an instrumented agent to see where the output went.  This is cleaner.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.58%. Comparing base (d351d66) to head (7ccc3fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   70.58%   70.58%
=======================================
  Files         206      206
  Lines       28129    28129
=======================================
  Hits        19856    19856
  Misses       8273     8273

Components
Coverage Δ

crashtracker
16.52% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.43% <ø> (ø)

ddcommon-ffi
75.29% <ø> (ø)

ddtelemetry
58.95% <ø> (ø)

ipc
84.13% <ø> (ø)

profiling
78.78% <ø> (ø)

profiling-ffi
58.64% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
35.42% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
71.14% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
91.03% <ø> (ø)


AgentInitializer behave abnormal

Describe the bug
AgentInitializer behave abnormal
Browser and Version

Browser  Microsoft Edge
Version 114.0.1823.58

To Reproduce
Just reproduc https://logspace-ai.github.io/langflow/python-function
Screenshots

Hey, @westwind027
We've just pushed version 0.2.2 that fixes that issue.

Thx!


Import 7e5904d023: Fix entity animations not playing (by Caitlyn)

This is an automated proposal to look at a commit made by Caitlyn and import it into Overte

Commit:
7e5904d023d34852d212a35f53fb385f253d880d

Author:
Caitlyn

Date:
Thu, 12 Mar 2020 12:33

Fix entity animations not playing

Stats:

Filename
Stats
Lines
Added
Removed
Lines in blame

libraries/entities/src/ModelEntityItem.cpp

2
1
1
1

1 files
-
2
1
1
1

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
If the commit is not useful, tag it with "Tivoli: Discard", and close it.
If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.
You can cherry-pick this issue with this command:
git cherry-pick 7e5904d023d34852d212a35f53fb385f253d880d

static entities


rewrite annotation on ReactiveRetryConfiguration

Should use ConditionalOnReactiveDiscoveryEnabled on ReactiveRetryConfiguration, not ConditionalOnBlockingDiscoveryEnabled

@Jisfeng Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@Jisfeng Thank you for signing the Contributor License Agreement!


Fetch kt collections

PR number 2 to make Arcs so fetch!

Made Collections no longer extend Iterable
Added fetchAll() method that returns all entities in a set
Added iterator() method to Collections

/gcbrun


Add a new event in the CheckAmountMatchedToAppliedLines() procedure of the Payment Journal page (Page 256) or make this control configurable to be able to skip it.

Describe the request
Add a new event in the CheckAmountMatchedToAppliedLines() procedure of the Payment Journal page (Page 256) or make this control configurable to be able to skip it.
If you decide to create an event instead of making it configurable we think the code would be:
Old Code
local procedure CheckAmountMatchedToAppliedLines()
var
    VendorLedgerEntryMarkedToApply: Record ???Vendor Ledger Entry???;
    CustLedgEntryMarkedToApply: Record ???Cust. Ledger Entry???;
    CustEntrySetApplId: Codeunit ???Cust. Entry-SetAppl.ID???;
    VendEntrySetApplId: Codeunit ???Vend. Entry-SetAppl.ID???;
    SmallestLineAmountToApply: Decimal;
    JournalAmount: Decimal;
    AmountToApply: Decimal;
    AmountToApplyMissMatchMsg: Label 'Amount assigned on Apply Entries (%1) is bigger then the amount on the line (%2). System will remove all related Applies-to ID. Do you want to proceed?', Comment = '%1 - Amount to apply, %2 - Amount on the line';
begin
    if Rec. ???Document Type??? <> Rec. ???Document Type???:: ???Payment??? then
        exit;

......
Proposed code
local procedure CheckAmountMatchedToAppliedLines()
var
    VendorLedgerEntryMarkedToApply: Record ???Vendor Ledger Entry???;
    CustLedgEntryMarkedToApply: Record ???Cust. Ledger Entry???;
    CustEntrySetApplId: Codeunit ???Cust. Entry-SetAppl.ID???;
    VendEntrySetApplId: Codeunit ???Vend. Entry-SetAppl.ID???;
    SmallestLineAmountToApply: Decimal;
    JournalAmount: Decimal;
    AmountToApply: Decimal;
    _**IsHandled: Boolean;**_
    AmountToApplyMissMatchMsg: Label 'Amount assigned on Apply Entries (%1) is bigger then the amount on the line (%2). System will remove all related Applies-to ID. Do you want to proceed?', Comment = '%1 - Amount to apply, %2 - Amount on the line';
begin

    _**OnBeforeCheckAmountMatchedToAppliedLines(isHandled);
    if isHandled then
       exit;**_
    if Rec. ???Document Type??? <> Rec. ???Document Type???:: ???Payment??? then
        exit;

.....
Additional context
The reason is that the process becomes very slow for the user when there are hundreds of payment lines settling debt whose amount is always higher than the amount to be settled since there must be a remainder of those payments.
With this event proposal in some customers we could skip this control that slows down their work.
However, ideally this control should be configurable, so that the customer can decide whether to apply it or not and change his mind later.
Internal work item: AB#536981

Availability update: We will publish a fix for this issue in the next update for release 24.
Build ID to track: 20539.


Avoid depending on protobuf internals [phab:D1223]

Created by zarko at 2017-01-05 23:24:01:

shahms accepted this revision at 2017-01-05 23:32:17

zarko closed via commit 6cfb5183bf8b872d8cc5fea79b2dcd9ea65ddf29 at 2017-01-05 23:40:46


SortedDictionary<TKey,TValue> can contain multiple of the same key? (Behavior different than Dictionary<TKey,TValue>)

I have not seen this behavior before and I've spent hours debugging...
Sample code:
source.Remove(key);

var multipleKeys = source
	.Keys.Where(f => f == key)
	.ToArray();

if (multipleKeys.Length > 1)
{
	Debugger.Break();
}

Not always, but very often the above code will break into the debugger within the above if block if the source is a SortedDictionary<TKey,TValue> (or SortedList<TKey,TValue>).
It DOES NOT enter the if block if the source is a standard Dictionary<TKey,TValue>.

I am using .NET Core 1.1 and VS Code.

To add a bit of context, there is only one '.Add' entry point and it occurs just after the above code.
The intention is to use a SortedDictionary as a Heap.  Also, I've used SortedDictionary many times before in .NET 3.5+ and never saw an issue.

Okay, I may have found out why this is happening.  I'll report back.
If the underlying values are mutable, it may be screwing up the underlying algorithm.
Having a similar issue with Red-Black BST.


Wrong active item using reset.css

Hi,
I use 'reset.css', then a 0 margin is applied to 'h2' and 'p'. Also I have a decoration below H2 called 'dotted-5'. Under these conditions I get wrong active item.
I made this example:
http://jsfiddle.net/kurtko/65je5n9v/
Thanks

@jdmoliner really sorry I didn't see this. I don't think this is an issue with reset.css because I've used that as well and it should calculate the exact positioning of the <section> that it wraps each chunk in. I think it actually looks like another bug that I thought I had fixed already, but I'll have to play with it this weekend to be sure.

You can see in my example if you remove the next line works fine:
p , h2 {margin:0;padding:0}

Re-reviewing this and your jsfiddle seems to highlight the correct section. Luckily, the entire plugin is being rewritten to avoid inserting sections to the main content and should resolve any of these issues. Closing in favor of tracking in #86


http://tapi.qbit.ninja/ not working when retreiving balances and pushing transactions to network

Hi,
Unable to retrieve latest balances, and push new transactions to the network.

I restarted the indexer, hopefully fixed in 10min

Seems like the API not working at all at the moment

now?

Working now. Thanks.


Build doesn't define GLDFLAGS anymore

I remember to see in build
-GLDFLAGS="-X $(go_linker_dashX github.com/coreos/fleet/version.Version ${VERSION})"
Did you remove it by any reason ? If so, build file shouldn't use in my opinion. E.g.:
  CGO_ENABLED=0 go build -o bin/fleetd -a -installsuffix netgo -ldflags "${GLDFLAGS}" ${REPO_PATH}/fleetd

Hi @hectorj2f
https://github.com/coreos/fleet/blob/master/build-env
https://github.com/coreos/fleet/blob/master/build#L15
?

@tixxdz Ops! Sure. I didn't find it :+1:


fix: ensure focus outlines match button/link size on click

We used to maintain the hit area for buttons/links during click by having an unstyled element for the button and then applying all visual styles to another element nested directly within the button. This mostly worked, but it introduced a visual issue where the focus outline would be out of sync with the button size on click.
To fix this, I've switched to a different approach where the button/link elements are made with a single element, and the increased hit area is managed by an absolutely positioned pseudo element that is scaled up on click. I implemented this with CSS variables to manage the different hover and active sizes so that we can dynamically calculate the inverse scale required to maintain the hit area.
Note that this means we no longer have the transform property on Box since our approach is more complicated now. Instead, interaction sizing is managed by a CSS utility function called touchableStyles that accepts the same values as transform but returns the required class names.

What do you think of this on Firefox?

Tiny amounts peeking through. I know this is an edge case, so I'm not concerned w/ it. Good to go if you are.

@nickbytes Seems like a rounding issue in their rendering engine. I tried to fix it but didn't have much luck. We might have to look into this separately if we want to fix it.


feat(virtctl): Allow to infer from specified volume in create vm

What this PR does / why we need it:
This changes the --infer-instancetype and --infer-preference flags to
take optional strings which allow to specify the volume of the VM from
which the instancetype or preference should be inferred from. If no
string is passed the previous behaviour is kept (infer from first boot
disk or first volume).
Special notes for your reviewer:
This is based on #9629, merge after.
Release note:

virtctl: Allow to infer instancetype or preference from specified volume when creating VMs

/cc @lyarwood

Hi. Does this mean that the IT / Pref would be infered on the client side?

Hi. Does this mean that the IT / Pref would be infered on the client side?

Nope, that part remains on the backend, this is just populating the {Instancetype,Preference}Matcher with a volume name, the actual backend inference remains the same.

/retest

I think it looks good, thanks Felix!
/lgtm

/approve

/approve

/approve
Hopefully, it should now work


[WIP] [Storage] Support UniformBucketLevelAccess.

[ ] Review from GCS eng team(@thanhld94).
[ ] Review from GCS cDPE team (@jkwlui).
[x] Integration Tests.
[x] Update Bucket Policy Only samples to use UBLA methods instead.
[x] Sample Tests.
[ ] Fix pending for backend bug: 134695162. Remove workaround.

@frankyn I think you should be able to rebase now and linting will work.

Thanks @AVaksman!

Closing, see #903


Form for Notification service

Add label dropdown in goals form which will show all the groups which RDS server has.
Backend api to get all the groups : https://api.realdevsquad.com/discord-actions/groups

@shreya-mishra  Can you please elaborate this issue?

For Goals , we just need members in a drop-down as we cant assign a specific task to groups.


Adding Contributors to the namespace does not work in Kubeflow UI

Reproduce:

Deploy CKF 1.7
Integrate with OIDC (ie. Keycloak)
create 2 users in OIDC (user1 and user2)
Log in as user1, go to Manage Contributors and try adding the email of user2.

Expectation - user2 is added as a contributor for namespace user1.
Do not try to use admin for testing, because it's added automatically to all namespaces.

@Barteus Could you provide instructions you used to integrate with Keycloak?

https://discourse.charmhub.io/t/authentication-with-oidc-and-keycloak/5844


[DOCS LACKING] Either add @const or actually show how to document constants!

If you research the topic on how to document class constants, you will find countless people saying to use @const because they found it in old, alpha/beta, german docs.
@const is not valid, it should be @var.
I honestly think @const just needs to be officially added, it makes the most sense.
Example within a class, using the proper @var tag:
/**
 * @var string APP_NAME The name of the application
 */
const APP_NAME = 'My Cool App';

The @var tag MUST contain the name of the element it documents. An exception to this is when property declarations only refer to a single property. In this case the name of the property MAY be omitted.

So we can get by with @var string The name of the application. However, I wonder how popular IDE's handle/support this? Atom, VS Code, Netbeans, PHP Storm, etc.? Meaning, is there a need to pass the elements name for support in any of the mainstream editors?
If so, then it just needs to be required/standard to pass the element name. This will ensure projects/libraries (once majorly adopted over time) that we use will have better support out of the box with IDE's.
I know with some IDE's, people have to do a little hackery to get some of the comments to show up... So we could stand to bridge this gap.

Alternatively, maybe it is time to just officially add a @const tag? Then the IDE's can specifically handle constants a lot easier.

Is this project even maintained anymore? I saw really old issues, on top of them piling up (over 250 issues), and on the website, there are multiple 404s...

The discussion of adding a new tag is not in the scope of phpdocumentor but more in the line of the PSR-19 working group. I would recommend you to contact them. https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md
The project is more than alive. There are multiple project at github with the age of phpdocumentor that have the same amount of issues. We are not a commercial organization. So mostly things are moving slowly.


chore: OreOreBot2 のパッケージマネージャーを yarn v3 に移行する

Details of implementation (実施内容)
OreOreBot2 のパッケージマネージャーを yarn v1 から v2 に移行しました。
Yarn PnP は使っていません。多分

Codecov Report

Merging #662 (8356318) into main (5dd5145) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   71.67%   71.67%
=======================================
  Files          66       66
  Lines        4643     4643
  Branches      438      438
=======================================
  Hits         3328     3328
  Misses        880      880
  Partials      435      435

Flag
Coverage Δ

unittests
71.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Updated eslint to 2.1.0

It works perfectly on npm@3, but temporarily could cause issues on npm@2 because of this bug:
https://github.com/feross/standard/issues/406

Won't we have to wait for babel-eslint and eslint-config-standard to catch up? I haven't dug too much into the new ESLint config changes, but apparently there are some which means existing configs probably won't port flawlessly.

Current coverage is 47.72%

Merging #576 into master will not affect coverage as of b880c99

@@            master    #576   diff @@
======================================
  Files            6       6
  Stmts           44      44
  Branches         0       0
  Methods          0       0
======================================
  Hit             21      21
  Partial          0       0
  Missed          23      23

Review entire Coverage Diff as of b880c99

Powered by Codecov. Updated on successful CI builds.

I could install all dependencies and build a project successfully with newer eslint with no errors/warnings.

Rebased your PR and continuing it here: https://github.com/davezuko/react-redux-starter-kit/pull/590


ScrollView autoScroll

Hey Guys, I wanted to know if there is anyway to make a scrollview to scroll and pass by all the items automatically.

This issue looks like a question that would be best asked on StackOverflow.
StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.
Will close this as this is really a question that should be asked on StackOverflow.


Nasty nasty namespace poisoning soundness hole

(match t (
   ()
   ( (App( (Lit( ':_s ctk )) (Var v) )) ( ... ) )
   ( (Lit( ':_s _ )) (
      uses ctk from previous scope, forgot to bind this variable in this scope
   ))
))

That is weird that this is still possible within a scope.

This is a pattern matching error with left-hand recursion still positioning these rhs within scope


Migration to GitHub

Hi all. I am currently working at the development of the Brazillian GBIF node.

We have been under a mentoring process with Colombia, and within our debates we have
come to agree that IPT is a tool particularly likely tobe customized for many different
institutions in a single country.

For that reason, and believing to have a best developing and versioning environment
under GigHub, I'd like to propose a migration of the IPT code to GitHub so that we
may start forking it from the current version and customize it in different ways more
easily.

Cheers,

Pedro Guimarães

Original issue reported on code.google.com by tigreped on 2013-08-08 00:49:21

The IPT source code and issue tracking has been migrated to the IPT's GitHub project now.
The IPT User Manual and Wiki is still in the process of being migrated. Therefore for the time being the primary version of the User Manual and Wiki are still made available from the Google Code site: https://code.google.com/p/gbif-providertoolkit/wiki/IPT2ManualNotes?tm=6

The IPT User Manual and Wiki has now been moved to GitHub.
Closing issue.


feat: update for loop to add more posts

Checklist ✅
Thank you for your contribution! Before submitting this PR, please make sure:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] You have commented your code, particularly in hard-to-understand areas.
[x] You have made corresponding changes to the documentation.
[x] Your branch name follows our branch naming conventions.

Testing

[ ] Did you write new unit tests for this change?
[ ] Did you write new integration tests for this change?

Rollout

[x] Can this change be merged immediately into the pipeline upon approval?
[x] Are all dependent changes already deployed to Prod?
[x] Can this change be rolled back without any issues after deployment to Prod?

Description 📝

Now the app can display more posts
Related Issue 🔗

Fixes #9  (issue)
Type of change 💥

[x] New feature (non-breaking change which adds functionality) ✨

Other Information 💡

Screenshots (if appropriate): 📷
Test Configuration: 🧪

LGTM


Confusing get_next_dom() and get_prev_dom()

Hi,
If we have three nodes
A
B
C
What the documentation says and what it is more logical to me is that if we are On node "B" then the get_next_dom() should return node "C" and the get_prev_dom() should return the node "A"
From the docs

If I'm not mistaken, I think that these two methods are doing the inverse of what they should be doing.
If so I think that this should be fixed in the next major version because it's obviously a breaking change.
Thanks for the amazing project, this is truly amazing and is the best tree plugin I have ever used.

get_prev_dom uses previousSibling and get_next_dom uses nextSibling (with some fixes around closed nodes, first node in collection, etc)


[Feature] Design Join us Page

Description
@pooranjoyb
we can design new route /join-us
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Congratulations, @dhruv8433! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

We can redirect the join us to github repo XD. Do it in your assigned repo :)


refactor: code-refactor

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@BugKillerPro can you get the commit message in line with the guidelines?


Installing SAP HANA 2.0, express edition (Virtual Machine Method)

Why insisting on an outdated version of the VMware player? Version 12.1 seems to be the current one - I cannot even find 7.1 on the wmware site for downloading. In addition, all your vmware links are to the vmware.com site - not to the specific download pages for each product. This is confusing and frankly a bit "daft".

The supported hypervisors, and the download links, have been updated.

http://www.sap.com/developer/tutorials/hxe-ua-installing-vm-image.html

Rgds,
John C.


[chore] update maintainer affiliation

@jmw51798 please approve if those changes are acceptable or if you rather would like to move to emeritus status.

Please also merge the pull request, I can't :)

Oh yeah :smiley:


Brep frame transformation

Make minimal example of Brep with frame and play around with transformation.
Establish if it's needed to keep Brep in Frame.worldXY

@chenkasirer delete?


Add players to round after it starts

This is bad if you do it more than once because if you go from an even game to another even game, the last two players added know that they're on opposite teams, but I think if you do it once it doesn't hurt, and since everything is honor code anyway it's fine.

thankyou


A slots=False class inheriting from a slots=True class generates incorrect getstate

I understand that this is a fairly uncommon case, but I was expecting the following to work:
import attr
import copy

@attr.s(slots=True)
class A:
    a = attr.ib()

@attr.s
class B(A):
    b = attr.ib()

b = B(1, 2)
print('ver: {}'.format(attr.__version__))
print('b: {!r}'.format(b))
print('b.__getstate__: {!r}'.format(b.__getstate__()))
print('deecopy(b): {!r}'.format(copy.deepcopy(b)))

Output
ver: 18.2.0
b: B(a=1, b=2)
b.__getstate__: (1,)
deecopy(b): B(a=1, b=NOTHING)

What would you expect us to do here though? The problem is that the base class has a __getstate__ and the subclass hasn’t. Automatically clear the method away? That sounds like it might break stuff.

Sorry, I didn't really think through the technical difficulties to fix this issue. It seems like there is already a discussion in #512 #513. I'll close this in favor of those.


v0.5.0 - s3-endpoint breaking change

Hi,
On version 0.5.0 when using AWS S3 and s3-endpoint (or S3_ENDPOINT env) is not defined there are errors on every function (GET / POST file) like:
"[problem getting object: operation error S3: GetObject, failed to resolve service endpoint, endpoint rule error, Custom endpoint `` was not a valid URI]"
The fix is to set S3_ENDPOINT to https://s3.[region].amazonaws.com along with S3_BUCKET, S3_REGION, etc.
Note that S3_ENDPOINT wasn't required in 0.4.1 and earlier. I think it should be noted as breaking change in changelog.

Please, could you describe how to reproduce?

Steps to reproduce:

Setup docker-compose.yaml like this:

version: "3.9"
services:
  storage:
    image: nhost/hasura-storage:0.5.0
    depends_on:
      - graphql-engine
    restart: always
    ports:
      - "8000:8000"
    environment:
      PUBLIC_URL: http://localhost:${PROXY_PORT:-1337}
      DEBUG: "true"
      HASURA_METADATA: 1
      HASURA_ENDPOINT: http://graphql-engine:8080/v1
      HASURA_GRAPHQL_ADMIN_SECRET: ${HASURA_GRAPHQL_ADMIN_SECRET}
      S3_ACCESS_KEY: ${S3_ACCESS_KEY}
      S3_SECRET_KEY: ${S3_SECRET_KEY}
      S3_BUCKET: ${S3_BUCKET}
      S3_REGION: ${S3_REGION}
      POSTGRES_MIGRATIONS: 1
      POSTGRES_MIGRATIONS_SOURCE: ${DB_URL}
    command: serve

Try to upload file, POST to /files/ and get response:

{
  "error": {
    "message": "an internal server error occurred"
  }
}

Error log:
time="2023-11-22T14:53:22Z" level=error msg="call completed with some errors" client_ip=<IP_ADDRESS> errors="[problem processing request: problem uploading file to storage: problem putting object: operation error S3: PutObject, failed to resolve service endpoint, endpoint rule error, Custom endpoint `` was not a valid URI]" latency_time=2.88124317s method=POST status_code=500 url=/v1/storage/files

Same goes to open file, /files/[uuid]:

level=error msg="call completed with some errors" client_ip=<IP_ADDRESS> errors="[problem getting object: operation error S3: GetObject, failed to resolve service endpoint, endpoint rule error, Custom endpoint `` was not a valid URI]" latency_time=11.225949ms method=GET status_code=500 url=/v1/storage/files/2c9f63e2-af92-4813-92ea-a75a3db9ff04 time="2023-11-22T14:56:04Z" level=error msg="call completed with some errors" client_ip=<IP_ADDRESS> errors="[problem getting object: operation error S3: GetObject, failed to resolve service endpoint, endpoint rule error, Custom endpoint `` was not a valid URI]" latency_time=11.225949ms method=GET status_code=500 url=/v1/storage/files/2c9f63e2-af92-4813-92ea-a75a3db9ff04
Solution:
Add environmental variable S3_ENDPOINT. In above example docker-compose.yaml should look like this:
version: "3.9"
services:
  storage:
    image: nhost/hasura-storage:0.5.0
    depends_on:
      - graphql-engine
    restart: always
    ports:
      - "8000:8000"
    environment:
      PUBLIC_URL: http://localhost:${PROXY_PORT:-1337}
      DEBUG: "true"
      HASURA_METADATA: 1
      HASURA_ENDPOINT: http://graphql-engine:8080/v1
      HASURA_GRAPHQL_ADMIN_SECRET: ${HASURA_GRAPHQL_ADMIN_SECRET}
      S3_ACCESS_KEY: ${S3_ACCESS_KEY}
      S3_SECRET_KEY: ${S3_SECRET_KEY}
      S3_BUCKET: ${S3_BUCKET}
      S3_REGION: ${S3_REGION}
      S3_ENDPOINT: https://s3.${S3_REGION}.amazonaws.com
      POSTGRES_MIGRATIONS: 1
      POSTGRES_MIGRATIONS_SOURCE: ${DB_URL}
    command: serve

Added a note to the release notes, thanks for reporting.


TIM-303 Refactor font size of text on homepage

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#49  👈
#48
#47
#46
#45
#44
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


Create a Footer with Copyright & social media handles

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in path of the file.
If you need to use any icon please use it from Hero Icons
Good luck.

Please assign me this issue, will raise a pr

Hey this is not in the figma file, I guess please choose a component from the figma file.

Hey this is not in the figma file, I guess please choose a component from the figma file. @rahulkarda
Please make a component from this Figma File

Updated the footer image, check if this works @Rajdip019

Please , assign me this issue

Will review your PR. @rahulkarda

Closing this issue as it is resolved.


Dataset Downloader

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: v0.3.0
Habitat-Sim: origin/main
Habitat is under active development, and we advise users to restrict themselves to stable releases of Habitat-Lab and Habitat-Sim. The bug you are about to report may already be fixed in the latest version.
Master branch contains 'bleeding edge' code, but we do appreciate bug reports for it!
🐛 Bug
Place :
China Mainland, While using the autodl accelerator proxy
When running the "python examples/example.py"
It turn out
(habitat) root@autodl-container-3fb9439642-317b707a:~/habitat-lab# python examples/example.py
2024-02-08 11:56:34,752 Initializing dataset RearrangeDataset-v0
2024-02-08 11:56:34,752 Rearrange task assets are not downloaded locally, downloading and extracting now...
No data-path provided, defaults to: ./data. Use '--data-path' to specify another location.
Found the existing repo for (replica_cad_dataset): /root/habitat-lab/data/versioned_data/replica_cad_dataset
 checking out v1.6 and pulling changes from repo.
=======================================================
Not replacing data, generating symlink (/root/habitat-lab/data/replica_cad).
Generating symlink (/root/habitat-lab/data/replica_cad).
=======================================================
git clone --depth 1 --branch v2.0 https://huggingface.co/datasets/ai-habitat/hab_fetch.git /root/habitat-lab/data/versioned_data/hab_fetch
Cloning into '/root/habitat-lab/data/versioned_data/hab_fetch'...
remote: Enumerating objects: 78, done.
remote: Counting objects: 100% (78/78), done.
remote: Compressing objects: 100% (70/70), done.
remote: Total 78 (delta 8), reused 77 (delta 8), pack-reused 0
Unpacking objects: 100% (78/78), 1.00 MiB | 1019.00 KiB/s, done.
Note: switching to 'd3f7c41602e6eea1a46f8f9dfc4d8fb2778c6773'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

Filtering content: 100% (27/27), 30.46 MiB | 935.00 KiB/s, done.
=======================================================
Dataset (hab_fetch) successfully downloaded.
Source: '/root/habitat-lab/data/versioned_data/hab_fetch'
Symlink: '/root/habitat-lab/data/robots/hab_fetch'
=======================================================
git clone --depth 1 --branch v1.2 https://huggingface.co/datasets/ai-habitat/ycb.git /root/habitat-lab/data/versioned_data/ycb
Cloning into '/root/habitat-lab/data/versioned_data/ycb'...
remote: Enumerating objects: 480, done.
remote: Counting objects: 100% (480/480), done.
remote: Compressing objects: 100% (326/326), done.
remote: Total 480 (delta 75), reused 479 (delta 75), pack-reused 0
Receiving objects: 100% (480/480), 50.08 KiB | 8.35 MiB/s, done.
Resolving deltas: 100% (75/75), done.
Note: switching to '5cff4a9f080ee49e43b881147159bc4dc1483eb7'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

Downloading meshes/065-j_cups/google_16k/textured.glb (627 KB)
Error downloading object: meshes/065-j_cups/google_16k/textured.glb (cd034ea): Smudge error: Error downloading meshes/065-j_cups/google_16k/textured.glb (cd034eaf30e18b86b541195c36eb5fe8b8285a16c769b300c2cfeb77b590abd6): batch response: Post "https://huggingface.co/datasets/ai-habitat/ycb.git/info/lfs/objects/batch": read tcp <IP_ADDRESS>:49306-><IP_ADDRESS>:12798: read: connection reset by peer

Errors logged to '/root/habitat-lab/data/versioned_data/ycb/.git/lfs/logs/20240208T115925.887835557.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: meshes/065-j_cups/google_16k/textured.glb: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Traceback (most recent call last):
  File "/root/habitat-lab/examples/example.py", line 31, in <module>
    example()
  File "/root/habitat-lab/examples/example.py", line 15, in example
    with gym.make("HabitatRenderPick-v0") as env:
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/gym/envs/registration.py", line 676, in make
    return registry.make(id, **kwargs)
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/gym/envs/registration.py", line 520, in make
    return spec.make(**kwargs)
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/gym/envs/registration.py", line 140, in make
    env = cls(**_kwargs)
  File "/root/habitat-lab/habitat-lab/habitat/gym/gym_definitions.py", line 91, in _make_habitat_gym_env
    env = make_gym_from_config(config)
  File "/root/habitat-lab/habitat-lab/habitat/gym/gym_definitions.py", line 60, in make_gym_from_config
    return make_env_fn(env_class=env_class, config=config, dataset=dataset)
  File "/root/habitat-lab/habitat-lab/habitat/utils/env_utils.py", line 36, in make_env_fn
    dataset = make_dataset(config.dataset.type, config=config.dataset)
  File "/root/habitat-lab/habitat-lab/habitat/datasets/registration.py", line 22, in make_dataset
    return _dataset(**kwargs)  # type: ignore
  File "/root/habitat-lab/habitat-lab/habitat/datasets/rearrange/rearrange_dataset.py", line 62, in __init__
    data_downloader.main(
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/habitat_sim-0.3.0-py3.9-linux-x86_64.egg/habitat_sim/utils/datasets_download.py", line 927, in main
    download_and_place(
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/habitat_sim-0.3.0-py3.9-linux-x86_64.egg/habitat_sim/utils/datasets_download.py", line 762, in download_and_place
    clone_repo_source(uid, version_dir, requires_auth, prune_lfs)
  File "/root/miniconda3/envs/habitat/lib/python3.9/site-packages/habitat_sim-0.3.0-py3.9-linux-x86_64.egg/habitat_sim/utils/datasets_download.py", line 585, in clone_repo_source
    subprocess.check_call(split_command)
  File "/root/miniconda3/envs/habitat/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', '--depth', '1', '--branch', 'v1.2', 'https://huggingface.co/datasets/ai-habitat/ycb.git', '/root/habitat-lab/data/versioned_data/ycb']' returned non-zero exit status 128.

I'm not very sure about the reason. But there are some additional info:

it's not very convient to use git the checkout the tag

Steps to Reproduce
Steps to reproduce the behavior:

after download all things and install the version with bullet.

python examples/example.py

Please note that without a minimal working example to reproduce the bug, we may not be able to help you.

the original code
Expected behavior

could you solve the download bug?
What's more is it possible to use other ways to download the file ?

use the other mirror to download?(from hf mirrors in  China)
or use scp to transport the file? maybe it'll be possible to use your habitat in the cluster which has no access to website outside China.

Additional context

我也是同样的问题，现在有解决的方案了吗

The error indicates that the Git Large File Storage (LFS) extension is not installed on your system. Habitat-Lab and its associated datasets use Git LFS to manage large files, which is why it's crucial for your setup.
Following these steps resolved the issue on my system:

Install Git LFS:
Open a terminal and execute the following commands to install Git LFS:
sudo apt update
sudo apt install git-lfs
git lfs install

Retry the operation:
After installing Git LFS, navigate back to your Habitat-Lab directory and try running the script again. Git LFS should now be able to fetch the necessary large files.
cd ~/path/to/habitat-lab
python examples/interactive_play.py --never-end

Check for dataset integrity:
If you had attempted to download datasets before installing Git LFS, it's possible that only placeholder files were downloaded. You might need to clear these and retry the dataset setup:
# Remove potentially corrupted datasets
rm -rf ~/path/to/habitat-lab/data/versioned_data/*

# Run your script again to fetch the data correctly
python examples/interactive_play.py --never-end


Update MD file on new branch 2017-11-10_09-23-29

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[release/1.5 backport] Update Go to 1.16.7

backport of https://github.com/containerd/containerd/pull/5842
go1.16.7 (released 2021-08-05) includes a security fix to the net/http/httputil
package, as well as bug fixes to the compiler, the linker, the runtime, the go
command, and the net/http package. See the Go 1.16.7 milestone on the issue
tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.16.7+label%3ACherryPickApproved
Signed-off-by: Sebastiaan van Stijn<EMAIL_ADDRESS>(cherry picked from commit 42a28ad2ca7faecfa3e2024952781136211c1fbf)
Signed-off-by: Sebastiaan van Stijn<EMAIL_ADDRESS>

moved out of draft, now that the PR on main was merged


[DRAFT] Fix: #1090 DID:SOV DIDDoc resolves without a service/endpoint

This PR introduces a fix for the DIDDoc resolution error outlined in issue https://github.com/hyperledger/aries-vcx/issues/1090.
Closes https://github.com/hyperledger/aries-vcx/issues/1090

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (40e9a87) 0.05% compared to head (a80a396) 0.05%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1096   +/-   ##
=====================================
  Coverage   0.05%   0.05%
=====================================
  Files        471     471
  Lines      24109   24109
  Branches    4336    4336
=====================================
  Hits          13      13
  Misses     24095   24095
  Partials       1       1

Flag
Coverage Δ

unittests-aries-vcx
0.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Safari Issue

I've been implementing vue-fixed-header into a project and noticed that it's not working in Safari (I have version 12.1.1 installed). Other browsers I've tested have all been fine.
When I run Vue Devtools and change the value of tag: from "html" to "body" it then works as expected.
The getTargetTag function doesn't seem to look for Safari. Could it be added?

This seems to have been resolved with the latest update to Safari 13. Closing now


Need advice to setup to get a local working model of Stablediffusion

Hello
This looks like a promising app and i like very much your effort in this.
I am trying to develop a full app included frontend for a project of mine using vLogger.
That is quite challenging
However i ran into some issues
I am unable to get a local copy of stablediffusion model
Tried several ways with python
https://chat.openai.com/share/94d052f4-5b87-4848-b347-1982307917e7
This code works for OpenClip and showMaker, fails for sd-v1-5
Do you know any workaround for this?
Thanks

Sorry, I can't open the link in your question. It prompts me to enter my account and password.

hello thanks for the reply
my code is this
`from transformers import AutoModel, AutoTokenizer
model_id = "openai/stablediffusion-v1-4"  # ID of the Stable Diffusion model
Download tokenizer and model
tokenizer = AutoTokenizer.from_pretrained(model_id)
model = AutoModel.from_pretrained(model_id)
Save the tokenizer and model
tokenizer.save_pretrained("/path/to/save/tokenizer")
model.save_pretrained("/path/to/save/model")`

Please someone help. I am stuck around that code above

If you want to call ip-adapter directly on the stable diffusion model, then you need to query the interface of ip-adapter in diffusers
‘’‘
https://huggingface.co/docs/diffusers/api/loaders/ip_adapter
’‘’
The reason for the incompatibility may be that in order to add STEB, I rewrote the model code in the models folder, which may cause the code to be inconsistent with the interface in diffusers.


Provide a way to show the editor hover while debugging

Currently when your program stops at a breakpoint, hover on symbols will trigger evaluate DAP request automatically. And LSP doesn't receive hover request, so no way to show the javadoc during debugging.
Really like having a way to trigger the javadoc during debugging. It could be a shortcut to trigger javadoc manually. Or VS Code client intelligently determines sending the hover request to the correct server (DAP or LSP) based on the hover context. If the hover context is a variable, send to DAP, otherwise, to LSP.

The issue here is that debug hides all other hovers to show the debug custom hover.
Due to that the javadoc hover is not shown.
This is a design limitation of the debug.
However I will leave this open as a feature request to debug so we support this scenario in the future.
As you suggest, the user could explicitly trigger the regular hover.

As you suggest, the user could explicitly trigger the regular hover.

The problem is it's not possible to trigger it manually, because the javadoc request is not exposed to user.

Duplicate of #99856?

Actually this is an older issue, so closing that one.

Idea from @dantup and @weinand use the alt key to switch between hovers

I think Ctrl would be more natural for the fingers.

We use alt in other places in VS Code as a way to show "ALTernative" content

I don't know what it is on Windows, but on Mac if you hold down Cmd when hovering over symbols, it shows a preview of the definition. If this is Ctrl or Alt on Windows, it might be wise to avoid using the same one (otherwise the hover might be larger than expected because it'll have a code snippet in it too).

I have pushed the following change:
While debugging while a user is holding down the alt key we do not show the debug hover, but the regular editor hover.
I tried this out and seems to work quite nicely. But I would be interested a lot in feedback. So try it out with VS Code insiders from Friday and let me know how it goes. I will also present this in our daily team meeting to get more feedback, so still not closing this issue.
Some open questions:

How to make this alt behavior more discoverable
Is it frustrating to hold down alt key while reading a long JSDoc

Alternative approach would be to just have a global command that toggles the hover behavior. However this felt more "heavy" to me and I personally prefer the alt approach.
@dantup Thanks for feedback. I have verified and on Windows this is Ctrl. So it seems like the alt key is free for this.
fyi @weinand @connor4312

* How to make this `alt` behavior more discoverable

That would be my main concern too. Maybe there needs to be a 'status bar' in the popup reading "hold Alt for ...". I vaguely remember something like that from VS.

Alternative approach would be to just have a global command that toggles the hover behavior. However this felt more "heavy" to me and I personally prefer the alt approach.

You probably need to switch fast and often so that would be way too clumsy.

If something like that is done, it should be probably include the others (for example the Cmd/Ctrl behaviour I mentioned above). There are lots of little things like that that aren't very discoverable right now (I only found that one by accident because it was rendering badly due to some other issues).

Feedback from standup was positive. With the overall impression that the ideal solution would be to just show both the regular hover and the debug hover at the same time. However since this is currently not possible due to the way how editor layout hovers this alt approach is a good workaround.
Feedback once you try it out is very welcome.
Status in the debug hover just to always show "hold Alt..." message sounds like a bit too much, especialy since it does not bring value once user figures it out.

if we can add an new pendant(little button?) to the debug popup, while debugging, show the debug popup when hovered, user will see the pendant.
than user can move The cursor to the pendant, then show the comments or infos from lsp. if there is no info, hide the pendant

I tried ⌥ + hover in macOS, the javadoc for a symbol can pop up when debugging a Java program. But i see two issues for the fix:

Cannot pin the javadoc triggered by ⌥ + hover.
If i release the key ⌥ , the doc will disappear immediately. As comparison, in a normal hover ux, if the mouse focus is still on the widget and it will keep there. This is useful when reading a long doc.
⌥ + hover will cause the normal hover action not working.
Below are the reproduce steps:

Starting a debug session, and stop at a breakpoint.
Stop debugging session.
⌥ + hover at a symbol.
hover at a symbol, no javadoc anymore.

A new global command to trigger javadoc at the selected symbol would be a good option. With this, you didn't need deal with the debugging state.

I have pushed a smoother transitoin between the debug hover and the editor hover.
@testforstephen thanks a lot for trying out out.

Good feedback. I will try to improve this right now
I just pushed a fix for this

As for the global command I would only add this if this alt approach proves bad. Before that I would first think about making it more discoverable.

I have also pushed a commit to tackle 1)
Please try it out with VS Code insiders from monday and let me know how it behaves now. Thanks a lot!

@isidorn tried again, the latest insider works well.

Great! I will also create a small test plan item for this so we cover it in Endgame week.


Release extract command

Would it be possible to do an npm release (0.2.0?) with the code implementing the extract (whole archive) command, which is present in master?  That'd be really useful in my use-case.

Mind adding everyone on the core team as an owner in npmjs.org as well? Thanks

<EMAIL_ADDRESS>has been published.

Mind adding everyone on the core team as an owner in npmjs.org as well? Thanks

Done.

It doesn't really matter, but why 0.2.0 (instead of 0.1.3)?

@bwin Because we have added a new command, which I think belongs to "minor" instead of "patch".

First of all, I'm not arguing for or against anything here, it's really just a question. It's just for my understanding.

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public
API should not be considered stable.

That part of semver (above) and the way atom-shell handles things*, were the things that made me wonder.
* = for example: 0.20.6 -> Add webFrame.registerUrlSchemeAsSecure API

In atom-shell, I tend to bump the minor version when there is a very big change, like a new Chrome upgrade, or some architecture change. If there is only a few lines' change, I would bump the patch version, even when it adds a new API. In this way I can let users know when we are having a significant update and they should test everything carefully.
For other projects, I would just follow the custom of the team.

Thanks for explaining.


Navigating multiline debug console input

Testing https://github.com/Microsoft/vscode/issues/64003

Have wrapped lines of text in the debug console input
arrow up/down only navigates history, I can't use it to move the cursor between wrapped lines

Also

Have multiple lines of text (with actual newlines via shift+enter)
Arrow up/down does move the cursor between lines but I can't navigate history

I should be able to navigate through the multiline text, but when the cursor gets to the very top or bottom of the input, then it navigates to the next/previous history item. See the multiline search input.

Actually I see there is just a difference between navigating the history (up/down only goes through history) and editing (up/down only controls the cursor in the input).
I think this is actually not bad, you can close this if you want.

I think I was given less freedome to customise this experience once we started sharing history navigation code.
ANyways the current behavior is not bad, so closing.
Thanks


Cancel job on client TERM signal

Hello!
the client is cancelling jobs on ctrl+c which makes sense. However, it seems like it won't do anything on TERM signal.
This makes it difficult for tools which treat mvn and mvnd the same to stop jobs, e.g (https://github.com/apache/netbeans/issues/7676).
This would be trivial to solve with a shutdown hook, but while playing with this, some problems occurred:

here is a prototype which:

adds a JVM shutdown hook which sends the cancel msg on irregular shutdown (SIGTERM)
this requires to build the native image with --install-exit-handlers, since without it, GraalVM would not trigger shutdown hooks on irregular shutdowns

The problem however is that the build is also setting -H:-ParseRuntimeOptions for the purpose of delegating -D params instead of parsing them as args. This seems to mess with the signal chaining and prevents the shutdown hook from running again.

This almost looks like a graalvm bug to me - but I am not sure. Maybe someone here has more experience with this scenario. (I tried graalvm 22.0.2 and also some older releases).
If the mvnd team thinks this is the right direction I would try to investigate a bit further if this is a graalvm bug or not.
(There are also many ways how to solve this from the side of NetBeans, it could send "ctrl+c" first, however there is probably no way to know how long to wait before sending TERM if nothing happens. Or it could talk to the daemon itself. I think it would be more elegant if both mvn and mvnd would be treated the same though in terms of shutdown.)

@gnodet @ppalaga please chime in!

@mbien your proposal sounds legit to me.  I must admit my GraalVM experience is mostly limited to mvnd, so I won't be able to help much on that side.

thanks! I could reproduce it outside of mvnd and filed a bug upstream https://github.com/oracle/graal/issues/9568


Dont' report success from ec_export if OSSL_PARAM_BLD_to_param failed

If the call to OSSL_PARAM_BLD_to_param() failed then ec_export was
reporting success, even though it has never called the param_cb.
Found due to:
https://github.com/openssl/openssl/pull/18355#issuecomment-1145993650

This pull request is ready to merge


Add operator extra link for Data Docs in the GreatExpectationsOperator

In Airflow, there is a feature which allows for external links to be present as buttons on the Task Instance modal in the Airflow UI called an operator extra link. This feature is really useful to directly navigate from the Airflow UI to an external site which may be for monitoring a third-party execution that Airflow just triggered, handy documentation, etc.
IMO linking to Data Docs directly from a GreatExpectationsOperator task would be really beneficial to users and increase the holistic visibility that's available at their fingertips.

The easiest, and the most widely-used, way to get that data into an operator link is via XCom. If you can push a URL to XCom or whatever values would be needed to build the URL string, you can have the get_link() method that would be overwritten to return the URL.
For some examples, check out Azure Data Factory and dbt Cloud providers. Then in the GreatExpectationOperator you can add the link as attribute. Something like:
class GreatExpectationsOperator:
    ...
    operator_extra_links = (DataDocsLink(),)

    ...
    def __init__(...):

There is some Airflow documentation on creating these operator extra links too.

Completed in 0.2.0


Complete socketpair support

We pretend to implement socketpair, but that's a complete lie. Completing this however doesn't need any involvement with the rest of the epoll plans. We "just" need to allocate somewhere two buffers for the data to be sent between these two endpoints, and then wire up the read/write of the two sockets with the right buffers. This can be tested by directly using socketpair/read/write.
There's also https://github.com/rust-lang/miri/issues/3231.
We can provide more detailed mentoring instructions if needed.

I think this should follow the proposed "project" process: https://github.com/rust-lang/miri/issues/3443.

I wonder if there are libc compliance test suites that are licensed well enough for us to extract tests from

Hi, I am planning to work on this first since it is related to #3448. I will send the link to the proposal here once I finished localtime_r.

@rustbot claim

I wonder if there are libc compliance test suites that are licensed well enough for us to extract tests from

Hmm I couldn't find any test for libc for now, if anyone knows where can I find one please let me know, thanks. Currently I imagine minimally the test should look like this (Note: they wrapped libc around their API, so it looks slightly different)
#[test]
pub fn test_socketpair() {
    use nix::sys::socket::{socketpair, AddressFamily, SockFlag, SockType};
    use nix::unistd::{read, write};

    let (fd1, fd2) = socketpair(
        AddressFamily::Unix,
        SockType::Stream,
        None,
        SockFlag::empty(),
    )
    .unwrap();
    write(&fd1, b"hello").unwrap();
    let mut buf = [0; 5];
    read(fd2.as_raw_fd(), &mut buf).unwrap();

    assert_eq!(&buf[..], b"hello");
}
//source: https://github.com/nix-rust/nix/blob/590ab4d5d0b6228f0529b036e4f8a42265ba6d31/test/sys/test_socket.rs#L311.

source: nix-rust/nix
I might add similar test in the proposal that I am going to send soon.

This is the proposal for socketpair shim: https://hackmd.io/@tiif/Skhc1t0-C. It is still under development, more attention is needed for the problems below:

Should we block write when the buffer is full?
How can miri differentiate read and write of socketpair file descriptors and other kind of file descriptors?

Feel free to provide any ideas or suggestion especially for the buffer mechanism part.

2. How can miri differentiate read and write of socketpair file descriptors and other kind of file descriptors?

Why does it need to? Shouldn't the abstraction provided by the FileDescriptor trait hide all thatvand only the socket pair type implementing that trait would care?

Left some comments,on the doc

Should we block write when the buffer is full?

Yes, we should.

How can miri differentiate read and write of socketpair file descriptors and other kind of file descriptors?

As Oli said: you "just" have to implement the read and write functions of the SocketPair type; the general file descriptor machinery will make sure to dispatch to that when read/write is called on an FD that is (part of) a socketpair.

This is the proposal for socketpair shim: https://hackmd.io/@tiif/Skhc1t0-C. It is still under development, more attention is needed for the problems below:

Thanks! The API description is very helpful. I have left some comments.
What is missing for me is a plan for how the Miri state looks like. In particular, the proposal should say what the fields of struct SocketPair will be. I currently think it will likely be something like
struct SocketPair {
  write_buf: Rc<SocketBuf>,
  read_buf: Rc<SocketBuf>,
}

but that then raises the question of what the fields of SocketBuf are. :) Maybe data: VecDeque<u8> as you sketched out is sufficient.

FWIW, once this is done it should be fairly easy to also support pipe/pipe2. Those are basically just one-directional sockets, for our purposes.

After reading eventfd, I realised both eventfd and socketpair have non-blocking flag, and I think it is good to implement them (and shouldn't be hard?). But currently blocking file descriptor is not implemented yet, and has higher priority, so maybe non-blocking can be left as a FIXME?
Besides, it is likely that SOCK_DGRAM and SOCK_STREAM has some difference in data size handling, but I think maybe we can leave it as a FIXME too?

Does tokio need non blocking sockets? I think no so yeah this can be left for later.
SOCK_DGRAM needs a pretty different implementation (we need to preserve message boundaries) so I think that is also out for now.

Does tokio need non blocking sockets?

I am not sure about socket, but I think we need non-blocking file descriptor for epoll_wait because there is a flag called EPOLLET for edge-triggered notification for file descriptor, and mio used them ( I also traced it to tokio, and yes tokio used that too). For edge-triggered notification, nonblocking file descriptors is used[^1]. I guess the behaviour for non-blocking file descriptor should be similar, so once we get the design down, it should be able applied to other kind of file descriptors.
FWIW, we might also need to provide support for "block with timeout" at some point too because apparently mio has them, tokio has related functions too :)
But I will go through all the flags and what we should do with them again in detail once we start to discuss epoll.
[^1]: The Linux Programming Interface 63.4.6 (for my own record)

Hmm, now I think about it, should we throw_unsup_format for SOCK_DGRAM?

Yes, definitely. We don't currently support it.
Not preserving message boundaries gives just the completely wrong semantics, we should never do that.
(I am not even sure what read/write do on such a socket, one would usually use sendmsg/recvmsg I think.)

For edge-triggered notification, nonblocking file descriptors is used2.

I don't know what you mean by that. Does tokio set SOCK_NONBLOCK or not?
If not, then clearly EPOLLET doesn't require SOCK_NONBLOCK.

Not preserving message boundaries gives just the completely wrong semantics, we should never do that.

I see why it is important to throw_unsup_format for that now, thanks for the explanation.

I am not even sure what read/write do on such a socket, one would usually use sendmsg/recvmsg I think.

I didn't know sendmsg/recvmsg exist, thanks for pointing it out. read/recv/recvfrom and send/write/sendto have the same behaviour when it comes to message boundaries ^1. For either of them, if they are datagram socket, read/recv/recvfrom will retrieve exactly one message. If the message size exceed the length byte, the message is silently truncated to length byte.
// Recall that read looks like this:
ssize_t read(int fd, void* buffer, size_t length);
// Return number of bytes read, or -1 on error

recvmsg is different as user can find out if a datagram is truncated through the MSG_TRUNC flag. ^2

Does tokio set SOCK_NONBLOCK or not?

Yes, both SOCK_NONBLOCK and SOCK_CLOEXEC. Is it a good idea to delay the support for these two flags until I finish implementing basic functionality of eventfd? We need to support non-blocking and close-on-exec flags for eventfd too because tokio uses it. The design should be similar so I am thinking of doing both together.

I don't know what you mean by that.

Oh that's only for epoll, I will explain it again when we get to epoll.

Yes, both SOCK_NONBLOCK and SOCK_CLOEXEC.

Ah. In that case you probably should implement non-blocking sockets first -- i.e., store during socket creation whether the socket is blocking, and then in read/write, if we would have to block, throw_unsup_format!.
It is up to you whether you want to implement support for blocking sockets at all, if it is not needed for tokio.

SOCK_NONBLOCK and SOCK_CLOEXEC are Linux-specific. ^1

x86_64-apple-darwin don't have these two flags. How mio handle them is ^2

Create a socketpair: socketpair(libc::AF_UNIX, flags, 0, fds.as_mut_ptr())
Use fcntl to set the NON_BLOCK flag instead

syscall!(fcntl(fds[0], libc::F_SETFL, libc::O_NONBLOCK))?;
syscall!(fcntl(fds[1], libc::F_SETFL, libc::O_NONBLOCK))?;

I am only mentioning NONBLOCK here becaues SOCK_CLOEXEC will be ignored since miri don't support exec
So to actually support, we might need to do:

Add O_NONBLOCK flag handling in fcntl
Find a way to notify socketpair that this socketpair file descriptor has been set to non-blocking.

Don't worry about running mio on macOS for now. That's going to be completely different anyway, it can't be using epoll.
But the NONBLOCK check in the socketpair function should be gated on Linux.


⚠ Panel - Hydeos has degraded performance

In 735ea94, Panel - Hydeos (https://pterodactyl.hydeos.fr) experienced degraded performance:

HTTP code: 502
Response time: 3255 ms

Resolved: Panel - Hydeos performance has improved in d9cf54c after 13 minutes.


standalone json parsing

for now, zcl_oapi_json will be used for parsing in the generated code
ideally, the generated code should be self-contained, sometime...

is the docu possibly out of date? I've tried generating the classes for Digiseal Web and it is using the standard /UI2/CL_JSON for deserializing


Add a not expectation property returning an opposite expectation

This allows you to run expectations such as:
try expect(...).to.not.beNil()

@kylef here I implemented my version of this that gives a bit better code completion options.
With my implementation it's only possible to use to or to.not after expect(...) and then returned objects have their own sets of conditions. So that things like expect(...).beNil, expect(...).to.to or expect(...).to.not.to.to are not possible.


Zsh autocompletion not working on Mac

Issue Summary
Installing the autocompletion (following instructions) script at:
/usr/local/share/zsh/site-functions
And checking the permissions are all ok, autocompletion does not work
Steps to Reproduce

Install notes on a Mac:
curl -L https://rawgit.com/pimterry/notes/latest-release/install.sh | zsh

Install autocompletion script
curl -L https://rawgit.com/pimterry/notes/latest-release/_notes > /usr/local/share/zsh/site-functions/_notes

Set $NOTES_DIRECTORY on .zshrc

Relaunch shell
notes autocompletion does not work. Other zsh completion scripts for other commands do work

thanks! :-D

OK, running
$ compinit
On the shell makes it work.

Ok, thanks for letting me know. It sounds like this is just a OMZ config issue? If there's something that should be included in the docs to make this clearer though, I'd happily accept a PR :smiley:.


Misleading chromeoptions.args documentation

The problem
Configuration javadoc suggests wrong chromeoptions.args format
Details
https://selenide.org/javadoc/current/com/codeborne/selenide/Configuration.html

chromeoptions.args - Sets the arguments for chrome options, parameters are comma separated If comma is a part of the value, use double quotes around the argument Non-official list of parameters can be found at https://peter.sh/experiments/chromium-command-line-switches/ Example: --no-sandbox,--disable-3d-apis,"--user-agent=Firefox 45, Mozilla"

Comma separated list does not work with chromedriver 74. Cromedriver for win32 supports space as separator, chromedriver for linux does not allow separators, each option should be a separate element in the args array
Tell us about your environment

Selenide Version: 5.2.3
Chrome\Firefox\IE Version: Chrome 74.x
Browser Driver Version: 74.0.3729.6
Selenium Version: -
OS Version: Windows 10, RHEL 7

Code To Reproduce Issue [ Good To Have ]
chromeoptions.args=--incognito,--disable-extensions

cc @vinogradoff as I know you are a fan of this way of passing chrome options

Cromedriver for win32 supports space as separator, chromedriver for linux does not allow separators, each option should be a separate element in the args array

@harshtuna I will be nice to see some link to chromedriver docs/code as proof. Can you share your findings?

chromedriver docs on this subject are missing.
Actually Selenide is properly parsing chromeoptions.args, false alarm, sorry
Odd win32 behavior is in chromedriver - they've got non-documented feature which injects dev tool extension even if --disable-extensions specified

chromeoptions.args format in Selenide Javadoc is correct

Chromedriver disable extension issue in SO https://stackoverflow.com/questions/56273279/how-to-disable-all-chrome-extensions-using-chromedriver


Add zip_safe=False to userguide setup.py

This adds a recommendation of including zip_safe=False to the
userguide/sharing_declarations.rst documentation.
Because cimport will not load pxd definitions from a zipped egg file and
the default format when installing from a source package using
"python setup.py install" is to create a zipped egg, including this
option will guard against this error when people install this way.

If you are a user of PyCharm, you might star this issue

Thanks, but this looks misplaced. I think it would fit better in the compilation docs.

@scoder That makes sense.  Do you think it suitable to have in both places or is this a bad place?  I will update the patch when not at work.

@scoder I reworked this to qualify the recommendation to when using setuptools instead of distutils which doesn't zip the installed files and therefore doesn't have the problem.
Comments welcomed.


Create New Term Box Disappears

When creating a new term, for example a new NHS Business Definition, the details are added in the "Create New Term" field.

If you click away from the field, it disappears and what you have added cannot be retrieved. This could result in work having to be done as we are often distracted whilst creating CRs.
James has a ticket on his board for this, so it was agreed to add a new issue.

Created a new NHS Business Definition and clicked away from it and did the same with the profile and got:


Fix settings export

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #9789
Closes #9799

Details of Changes
Add details of changes here.

Code for export needed to be updated for the new 7z library
Fix crash when viewing properties of file without extension

Validation
How did you test these changes?

[x] Built and ran the app

Could you also add these changes to winui3_mini later? 🙂

Sure thing 👍


Imbalance and noise handling

Hello Ed,
First of all, thank you for this amazing work. I was wondering if you could answer the following questions, it'd be really appreciated.

How do you think RETAIN handles with class-imbalance situation? I personally saw it handled well in my dataset, but couldn't follow why it worked great.

Patients can have common medical codes like hypertension or diabetes, which can be regarded as noise in terms of predicting other disease. Can RETAIN capture such codes with less weight even though they appear a lot?

Best Regards,

Hi dhyoon0527,
Thanks for taking interest in our work. As for your questions:

There is no specialized component in RETAIN that is designed to handle class-imbalance. (It uses a simple cross entropy loss). Not sure why it would work well on your dataset, but I'm sure other sequence models would equally work well.
 Then both hypertension and diabetes would occur about the same number times in both cases and controls (since hypertension and diabetes are not really relevant to breast cancer). In this case, RETAIN would learn that hypertension and diabetes are not useful features, and assign low attention to both. But if you are predicting kidney disease with RETAIN, then I would assume diabetes would occur much more often in cases. So RETAIN would learn to assign higher attention on diabetes.

Best,
Ed

Ed, Thank you for your answer!
The following question is about risk score. It appears that softmax (sigmoid for binary case) is used at the final step. Let's say the risk score of heart failure is 0.34 and it has high probability of getting into heart failure. I tried to scale this score into more reasonable number of probability -- but how is that score different from the probability?
Also, I saw in your other paper that tries to predict code(s) of the next visits. For RETAIN, prediction experiment, can it be changed to the probability of falling into X disease in less than Y time (days, months)? If so, what do you think the best approach for that?


Added blog website

Description 📜

Added a blog website made using HTML, CSS and JavaScript.
The website has two pages, a landing page and a blog writing page. Clicking on "start writing" will lead the user to the 2nd page.
Both the pages are fully responsive.

Fixes #158

This would be great if you provide any of this   📝

[x] Other (If you choose other, Please mention changes below)
[x] Deployment link

Domain of Contribution 📊

[x] Single page website

Checklist ✅

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest contributor

Any tutorials or documentation have you added
(made by you only not from google)

[ ] Tutorial
[ ] Documentation

Screenshots / Gif (Compulsory) 📸
Landing Page

2nd Page

Deployment Link
https://sshiwangi.github.io/Blog-website/

@sshiwangi good work ,  LGTM


adding hiFiveDevelopment

Hi,
I added myself this year again!

I made another pull request with the resolved conflict.


KAFKA-17767 Store the test catalog in Git [2/n] (2nd attempt)

(Re-opened this as a branch PR instead of fork)
Second part of https://github.com/apache/kafka/pull/17397. This patch will take the extracted test catalog generate on trunk and commit it to an orphaned Git branch in the Apache Kafka repository

Here is a commit generated with this PR https://github.com/apache/kafka/commit/6f0b61bdaa5ccf900e41aba7f3f1cd37065e5808
It is missing a number of tests since several tests were not run due to caching. Once this is committed to trunk, it will capture all of the tests.

@chia7712 can you take a look?


Adding Fastlane ignore files

Fastlane https://fastlane.tools/ is a very useful tool that lets you define and run your deployment pipelines for different environments. It helps to unify apps release process and automate the whole process. fastlane connects all fastlane tools and third party tools, like CocoaPods and xctool.
These two ignore lines are the ones that avoid generated files to be checked in to the repo and also used in the fastlane main example: https://github.com/KrauseFx/fastlane-example/blob/master/.gitignore

This seems to have been done in #1704


Cross-validation tests broken and not being run

Expected/Desired Behavior:
Cross-validation tests should run and pass as part of github actions workflow
Actual Behavior:
Cross-validation tests are not being run as part of the CI workflow
Detailed Steps to Reproduce the Behavior:
Look at Actions> observe that the cross-validation tests are not being run.
Additional Information:

Can we close that now?

@juraul1  yes; should have added closes #134 in the commits for #127.
Fixed in #127


Upgrade repos for Drupal 7, Drupal 8, and WordPress

What happened (or feature request):

Task request

What you expected to happen:
We currently run tests against Drupal 7, Drupal, and, and WordPress. All of our repos are currently out of date, including security updates. Given some of the significant changes that have occurred in Drupal 8, we should get onto the 8.3.x branch instead of the current 8.2.x branch.

As we discussed offline, there are larger implications in making it so that we don't have to maintain and/or update these 3 repositories. For example, we could clone off of the Drupal mirror https://github.com/drupal/drupal and simply run ddev config with the default options when running our tests.
Short term, I'm mostly interested in getting Drupal 8 upgraded to the 8.3.x branch before we run any performance tests in #195. Happy to split out a separate issue for the larger solution, but this is a more focused request.

drupal8 upgrade is pending in https://github.com/drud/ddev/pull/236 and https://github.com/drud/drupal8/pull/4
I would really like us to lose this approach, but for @rickmanelius and the purpose of immediate perf testing, here it is.

@rfay understood re:above. When this issue is closed out, let's get a different issue filed for a better long term solution.

If you have no objection, can we change the scope of this to just drupal8? I'm not sure what pushes us on anything else.
I spun off the idea of using direct downloads instead of our own forks in https://github.com/drud/ddev/issues/237

Drupal 8.3.2 upgrade is done in https://github.com/drud/ddev/pull/236, which has been merged. Does that complete this?

@rfay question, it looks like the changelog is still showing 8.3.1. https://github.com/drud/drupal8/blob/master/docroot/core/CHANGELOG.txt#L1.
I can live with ignoring Drupal 7 and WordPress.

They failed to update the CHANGELOG.txt for 8.3.2 :) Pretty funny, http://cgit.drupalcode.org/drupal/tree/core/CHANGELOG.txt?h=8.3.2 - if you want to get a commit credit here's an easy patch!

Ha! I'll consider this closed :)


Overwrite when path or name matches proper or Repack

This is actually a duplicate of #84 as i'm not sure why that was closed becuase it's still a very useful request that is not yet possible.
Essentially an additional config item, something like "overwrite_destination_on_repack_proper" which when true would perform a case insensitive pattern match on the full path for Proper or Repack and force overwriting for these files.

thinking about this it might be better to have some sort of pattern list where overide is forced
"force_overwrite_patterns": [{"match": "REPACK ", "is_regex": false}]

Yeh that seems like a good approach, and shouldn't be to hard to implement once the renaming logic is tidied up in the v4.0