Handle Wikimania sitelinks and regenerate sitelink languages

Western Armenian Wikipedia was added (hywwiki) so I regenerated the sitelink languages.
But first I had to also account for wikimania.wikimedia.org, or else it would have added an empty string to the language array. Sitelink here if you need an example (at the very bottom): https://www.wikidata.org/wiki/Q5296

@noinkling thanks!

published as v6.5.0


Update README: Set up CI to forked

It might be better to add it to Wiki instead of updating the README.
Because optional information about this repository.

I simplified CI running emulators directly instead of FTL, thanks for your PR!

@JoseAlcerreca Good! Thank you for reply and closing!!


Like SPI, other methods now take pin as argument instead of integer. Update docs to match.

SignalGenerator is one example.

Closed via #146


Bug: flicking behavior on update insight page

Describe the bug
When you open update insights the added repositories will be hidden then shown, sometimes it will show the added repositories then hide them, then show them.
I think having a placeholder would be better than this behaviour.
https://github.com/open-sauced/insights/assets/18273833/73ae0215-5092-45e5-b717-eb6967562cb3
Steps to reproduce

go to insights
click on update an insight
you will see this behaviour on added repositories

Browsers
No response
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

.take


chore: Removed eslint comments, added global formatting, fixed errors

Description

Added new script to globally prettify source code
Added lint-staged rule to prettify commits
Removed eslint-disables that were not needed in most cases.
Fixed eslint errors when relevant
Fixed tests

Type of change

[x] chore  just added prettier and fixed linting errors
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[ ] Add documentation (N/A)
[ ] Add hook's story at Storybook (N/A)
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

@xobotyi updated!


feat(patch): fix #758, patch cordova.exec success/error with zone.wrap

patch cordova.exec success/error callback with Zone.wrap, and cordova.exec may not be async so I didn't patch it as a macroTask.
merge fake polyfill (custom_error, fake_cordova) into a single test_fake_polyfill file.

@mhevery, sorry, I will update it now.

@mhevery , I have update the commit ,please review.


Custom State not showing any data when deployed in Azure App Services.

I'm saving a state from a result coming from API request on third-party API. When I access it using Dialog Context, it's not showing.

What state provider are you using?

Azure SQL

Extension SDK does not deal with data storage (or Dialogs for that matter). Did you try asking BotFramework folks at https://github.com/Microsoft/BotBuilder

Okay I see, I actually asked them before about the custom state, if it can be accessed inside Dialogs they said yes and through context but it's during my debugging on localhost. And I saw different results from when I access it through the scope and through dialogs (btw I'm using IBotDataStore), I guess I'm just gonna ask them now that I'm hosting it on Azure.


Use REST API instead of xmlhttprequest

Creating a pull request to make the review process easier.
Fixes #16

@vboctor Many thanks for taking the time to review. I've responded to your comments, let me know
how I should address the version thing (https://github.com/mantisbt-plugins/snippets/pull/26#commitcomment-25161975)

Something's wrong with this PR, it contains an unrelated commit and I can't seem to fix it.


decrypt_into accepts replays.  also next_nonce forces tx/rx to be lockstep synchronous -- is this desirable?

https://github.com/oasislabs/sapphire-paratime/blob/4d20964b38ffdded1357823d7987064d0601f7db/encrypting-proxy/src/crypto/cipher.rs#L101
the incr-by-2 odd/even tx/rx nonce design forces messages to be synchronous, so alice send w/ the tx_nonce which bob checks is as expected and then bob would send a reply w/ rx_nonce which alice checks.  this is okay if synchronous back-and-forth is what we want, but if we may need alice to send 2 messages before getting bob's reply, then it is inconvenient to have a single value where we do self.nonce.fetch_add(2, SeqCst).
instead of the low-order bit denoting whether a number is a tx or rx nonce, we could just use a high order bit.  this looks like a type bit followed by a 63-bit nonce counter space.  or, we could have two separate counters and a "direction" indicator so that messages from alice to bob would not validate as messages from bob to alice (or vice versa).  these are, from a functionality view point, pretty much equivalent (63 bit vs 64 bit nonce space is not a big deal).  granted, we don't have to be starting off viewing things as two separate nonce sequences and a bit to distinguish the direction, since if/when a future change requiring decoupled send/receive functions can separate out the two nonces as suggested, and encode them as 63-nonce plus direction in a wire-format compatible manner, before migrating to allowing a different number of messages being in-flight etc.
anyway, that's the design nit.  it feels weird to me.  it's not wrong, but it feels awkward.
oh, idiomatic rust question.  L103-L107 splits the slices into fields for writing the actual values into, but values are written in L108-L111.  is this idiomatic rust?  i don't like it because i have to ensure that every split slice is actually used -- but maybe the compiler will generate a warning if one field is forgotten and rust programmers habitually rely on that instead?  checking that every field gets initialized is part of audits, obvs, so being able to eyeball that is good, but maybe i'm being old-school and relying on compiler generated errors is better (though being paranoid, i'd prefer to not rely on that solely).
so the code sends both tx_nonce and rx_nonce when they differ by 1.  which is weird.
in decrypt_into L127, no checking of the expected nonce value occurs.  it's used as the input for open_into as the expected value and the AAD for AEAD, i believe.  so this is a bug, right?  since there is no checking of the nonce value from versioned_nonced_tagged_ct with the SessionCipher object's nonce member, a SessionCipher will accept any replayed message and decrypt_into will succeed.

The encrypting proxy has been superseded by client support 🎉 . That makes life simple again! This issue will be reopened if the EP ever comes back.
Thanks for the review.


Fix tests under Django 1.8

Fix the "User has no forum_profile" error we were getting when running
tests under Django 1.8 by shamelessly copying
https://github.com/skorokithakis/django-
annoying/commit/a49a0f37aaa35ee00b06319917b08e37def61325
Now, all tox tests pass
By the way, why do we copy code from django-annoying instead of simply adding the package to our dependencies?

django-pagination - nice example of shitty dependencies, when project was die, after that migrate to linaro pagination all was fine before django 1.8 release ... same story with python3.4 support ;)
PS: i don't want add extra dependings for one function

Fair enough, that was my next question :) how about getting rid of the pagination dependency? Instead of depending on a pagination plugin for "easy" (yeah, right) pagination, we could simply do it "by hand", the "vanilla" django way and get rid of the unmaintained plugin problem.

this is minor task, maybe later
i planning migrate to CBV, bootstrap3, rewrite project structure, add normal tests - this is more critical for me
u can find me in jabber<EMAIL_ADDRESS>or gtalk (slav0nic0)

A switch to CBV will make pagination easier anyways...


WebIDL snippets with default values are being dropped

e.g. https://github.com/w3c/wake-lock/commit/5c34f9a299ad4625fe32398152bf85ab8cdf1c24 lead to https://github.com/web-platform-tests/wpt/pull/17904/files#diff-d83394caf586049a88f0c0cdd880c7bbL12
e.g. https://github.com/w3c/push-api/commit/9179964494a5cedcca4a104c555e98019fbb1135 lead to https://github.com/web-platform-tests/wpt/pull/17826/files#diff-173f90f4b0be112b694720eda63bce08L11

Oh, good catch. That suggests that some attempt is being made to parse the IDL before accepting it, but that doesn't jive with my experience of fixing lots of broken IDL in specs that was already in reffy-reports... curious to learn what's behind this :)

@tidoust @dontcallmedom can either of you help out with this?

Argh. The problem is that right now, Reffy needs to use a pinned version of Respec (23.7.1) because newer versions of Respec do not run under JSDOM (notably because of the use of CreateObjectURL to create a worker). That old version of Respec does not seem to like default values when it parses WebIDL fragments and fails to include the interface in the final IDL index.
I don't know how to make the latest version of Respec run with JSDOM. We may have to get back to running a headless browser instead.
In the meantime, I'll have Reffy extract the IDL from the body of the spec instead of relying on the IDL index at the end of the spec.

Reffy will now ignore the final IDL index from now on, and rather extract IDL definitions from the core part of the spec.
Not to have to wait for tomorrow's automatic report, I also pushed a manual update of the IDL files for Performance Timeline, Push API, User Timing, Wake Lock, WebNFC and Web Share, which had missing IDL definitions because of this.
Please reopen the issue if I missed something!

Sweet, thanks for fixing this, @tidoust!


added actor methods

Pull Request Test Coverage Report for Build 133

11 of 12 (91.67%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 91.922%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/domain/actor/actor.js
8
9
88.89%

Totals

Change from base Build 130:
-0.8%

Covered Lines:
228

Relevant Lines:
242

💛  - Coveralls

Don't forget to add yourself as a contributor in the package.json :D.


remove useless code and optimize logic

Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #1085 into master will decrease coverage by 0.05%.
The diff coverage is 57.77%.

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
- Coverage   56.08%   56.02%   -0.06%
==========================================
  Files         246      246
  Lines       23063    23056       -7
==========================================
- Hits        12934    12918      -16
- Misses       8968     8977       +9
  Partials     1161     1161

Impacted Files
Coverage Δ

pkg/proxy/proxy.go
8.06% <ø> (ø)

pkg/network/filtermanager.go
16.07% <50.00%> (-0.88%)
:arrow_down:

pkg/network/listener.go
52.29% <56.41%> (-5.40%)
:arrow_down:

pkg/server/handler.go
40.04% <100.00%> (-1.30%)
:arrow_down:

pkg/module/http2/frame.go
84.17% <0.00%> (-0.31%)
:arrow_down:

pkg/module/http2/server.go
81.70% <0.00%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90e61d...79400c9. Read the comment docs.


Opening a new folder generates a new window.

Issue Type: Bug
When I open a new window (File / New Window) and then I open a 'folder' (File / Open..) there is a new window with folder content exactly over the 'new' window.
This doesn't happens when I open a single file.
Opening a folder should not generate a new window.
VS Code version: Code - Insiders 1.22.0-insider (6b4d53cdab8bcae1eaaa4934d93c077319b573db, 2018-04-04T13:45:40.906Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz (8 x 2300)

Load (avg)
3, 2, 2

Memory (System)
8.00GB (0.03GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

include-autocomplete
ajs
0.0.4

file-templates
brp
1.2.0

doxdocgen
csc
0.3.1

gitlens
eam
8.2.0

CppSnippets
har
0.0.13

cortex-debug
mar
0.1.18

vscode-todo-parser
min
1.9.1

cpptools
ms-
0.16.1

vscode-code-outline
pat
0.0.13

platformio-ide
pla
0.14.0

vscode-icons
rob
7.22.0

vscode-todo-highlight
way
0.5.12

debug
web
0.22.0

(1 theme extensions excluded)

Have you set the "window.openFoldersInNewWindow" setting /

Thank you, however it was set 'on'.


Replace yamljs with yaml

Explain the changes

Replace yamljs with yaml

Replacing yamljs with yaml as yaml is maintained and yamljs is less maintained.
This is the first step, in the second step we should avoid using any kubernetes calls in the core
@dannyzaken @jackyalbo WDYT?


Turn input/output/etc types in mint module into proper newtypes

Eventually their implementation details should be private, and the newtype structure will take care of transformation between module and API.

Codecov Report
Base: 64.13% // Head: 64.22% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (f0a4a2e) compared to base (eefc2fb).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   64.13%   64.22%   +0.08%
==========================================
  Files         112      112
  Lines       16408    16421      +13
==========================================
+ Hits        10524    10546      +22
+ Misses       5884     5875       -9

Impacted Files
Coverage Δ

fedimint-core/src/outcome.rs
41.93% <0.00%> (ø)

client/client-lib/src/lib.rs
85.16% <100.00%> (ø)

client/client-lib/src/mint/mod.rs
83.29% <100.00%> (+0.07%)
:arrow_up:

client/client-lib/src/transaction.rs
96.77% <100.00%> (+0.01%)
:arrow_up:

fedimint-server/src/consensus/conflictfilter.rs
98.14% <100.00%> (ø)

fedimint-server/src/consensus/debug.rs
96.66% <100.00%> (ø)

modules/fedimint-mint/src/lib.rs
83.33% <100.00%> (+0.37%)
:arrow_up:

fedimint-server/src/net/connect.rs
95.26% <0.00%> (+0.24%)
:arrow_up:

fedimint-server/src/lib.rs
79.43% <0.00%> (+0.31%)
:arrow_up:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix docker tests failing on mac. resolves #1778

Docker on mac requires whitelisting directories before mounting them into docker images. Temp files are created in /var/folders/.... /var is a symlink to /var/private. /private is in the whitelist, but since the canonical name is not being used docker doesn't recognize it.
The workaround of adding /var/folders fails because the GUI will only select the canonical name (/private/var/folders) and because /private is already on the list the change is rejected.
resolves #1778

Jenkins, test this please.

Transient failure?

Jenkins, test this please.


typeChecker.typeToString() should print most derived alias

TypeScript Version:  typescript@next
Code
Playground Link
type First<T, R> = (source: T) => R;
type Second<T> = First<T, T>;

declare function example(): Second<string>;

Expected behavior:
Using the compiler API, typeChecker.typeToString(signature.getReturnType()) of example returns the most derived alias, Second<string>
Actual behavior:
typeChecker.typeToString(signature.getReturnType()) returns  First<string, string>

IntelliSense in the playground and vscode both show the same thing as typeChecker.typeToString(returnType), so I assume they share the same underlying logic.
I tried examining the type object itself to see if I could reach into private APIs to get it, but I couldn't find it. I also tried various formatting flags, but none of them seemed to give me the desired behavior.
I searched for existing issues on this, #17433 seemed similar but digging into it, I think it's different. It's also possible this behavior was intentional of course, if so, lmk. I'm using the compiler API to generate custom documentation for rxjs and there are sometimes a number of aliases used which simplify much more complex structures and hide internals.
I could try to take a crack at a patch if someone knows where I might find the applicable logic. Seems like it would need to be on the type metadata generation side, since I can't find it in the type returned from signature.getReturnType()?
Cc/ @benlesh

This might actually be intended behavior after all, albeit an unfortunate one:
https://www.typescriptlang.org/docs/handbook/advanced-types.html

One difference is that interfaces create a new name that is used everywhere. Type aliases don’t create a new name — for instance, error messages won’t use the alias name. In the code below, hovering over interfaced in an editor will show that it returns an Interface, but will show that aliased returns object literal type.


I'm not familiar with zigbee2mqtt but as long as your device or service can publish MQTT messages you can control an equivalent device in ST.
To be clear though, it doesn't create a device for you in ST. You have to create the device yourself. (I have found that I use the Virtual Switch Type in ST).


[BUG] Breadcrumbs not displayed on detail page on initial load

Project type

[x] Project (generated by CLI)
[ ] Contribution (cloned/forked from GH)

Describe the bug
When hard reloading a detail page the breadcrumbs aren't displayed despite them being available in the page-oject from the CMS. I have the guess that this is maybe a reactivity issue in the useSharedState composable, but I'm not quite sure.
I'm not always able to reproduce this on your demo instance, this also can be a race condition.
EDIT: Seems like the SSR of the breadcrumbs doesn't work, the breadcrumbs are also empty in the HTML. I added the following logging to layouts/default.vue
const getBreadcrumbs = computed(() => {
      console.log("BREADCRUMBS", breadcrumbs, breadcrumbs.value)
      return breadcrumbs.value.map((breadcrumb) => {
        return {
          // map to SFUI type
          text: breadcrumb.name,
          link: root.$routing.getUrl(breadcrumb.path),
        }
      })
    })

This results in the following log on the server:
BREADCRUMBS RefImpl {                                                                                10:02:35
  value: [Getter/Setter]
} []

On the clientside I get the same log, so the breadcrumbs array is empty.
Additional context

node version:
shopware-pwa version: 0.9.1
Shopware 6 detailed version: 6.4.1.x
system:

I cannot reproduce this issue for the current canary.
@niklas-wolf can you confirm it's fixed?

@patzick  I'm sorry, I have to pass on this one, as we currently haven't upgraded any of our projects yet to RC-1 and we only work with fixed versions, not canary and I currently don't have the time to setup a clean new project...
But if you can't reproduce, I trust you that it's fixed ;) :)


try again

is working or not

let's check

so, it doesn't revalidate on route change. But happens when page is refreshed


Fully document templating system

The JSON variable templating system is very powerful, but needs to be fully documented. This is a reminder to add a dedicated section to the docs about variables, ini files, precedence, and the like.

Relates to #205


Adding Slack notification to Jamf LAPS bookmark

Hi, the bookmark routine that you wrote is ingenious! It's the fastest and most elegant way to look up the Jamf LAPS password that I have found.
I'd like to add a slack notification with the username and computer name of the person that clicked the bookmark, date/time stamp, and the target machine name. Is that possible?

Hi, I'm glad you liked it. Thanks for using it.
Unfortunately I do not think a bookmarklet is the best way to handle what you need.
Essentially I could send a payload to a Slack webhook URL which contained that information but you'd need to press it each time and also customise the code to enter your webhook URL. This kind of thing better lives in a SIEM.
I won't be completing this at this point in time.
Thanks for your understanding.


issue in UI while changing back arabic to english language

While I change to english to arabic it is working good all UI and texts but when I switch back from arabic to english then I am facing some issue in UINavigationBar and UITextField.
I have attached images so, it explains everything.

Placeholder change only after I close the app and restart it but other UI displays RTL without restart the app except back navigation.

See this answer issue 6


Rewrite http images to https.

Rewrites all http images to https at display time.
Does not affect text in the actual md file; this is only a display time rewrite.

                            block.Heading = new HeadingData(level);

the tests are here: https://github.com/NuGet/NuGetGallery/blob/995709555c8cbcba05925756b27eefbcff0c8242/tests/NuGetGallery.Facts/Services/ReadMeServiceFacts.cs#L253

Refers to: src/NuGetGallery/Services/ReadMeService.cs:195 in 1e4eb20. [](commit_id = 1e4eb20d7a8115359a4b17b216b96c2dd7367dab, deletion_comment = False)


sass imports from node_modules

My libraries mostly contain scss files which are consumed by components in the library itself and by projects depending on the library.
So sass imports pointing to node_modules dependencies can't be consumed by external styles since the paths have to be relative.
Angular CLI projects are using webpack by default, where those dependencies are imported by using the trailing tilde ~ pointing to the node_modules folder of the current project. To adopt this behavior we could use an importer function for the node-sass library:

lib/steps/assets.ts:~70

const sassImporter = (url: string): any => {
  if (url[0] === '~') {
    url = path.resolve('node_modules', url.substr(1));
  }

  return { file: url };
}

const pickRenderer = (filePath: string, ext: string[], file: string): Promise<string> => {

  switch (path.extname(filePath)) {

    case '.scss':
    case '.sass':
      debug(`rendering sass for ${filePath}`);
      return renderSass({ file: filePath, importer: sassImporter });

    case '.css':
    default:
      return Promise.resolve(file);
  }

}

@dherges I could pr this, if considered useful?

Closing this, since the PR has been merged :)


gh-11 -> Added RestNetwork, uses xhrio to implement UntangledNetwork, provides hooks

Unsure about on-network-error, we didn't talk about it, but I felt we should provide a way for them override the error callback.
I haven't added docs, I'll wait for your approval on the implementation.

Looks pretty good. No documentation? The demos source folder (which also has a demo server) would be a great place to test this out in the wild and show and example.

Should I conform/check what they return? If so, how should I do error handling?


GH-40907: [Java][FlightSQL] Shade slf4j-api in JDBC driver

Rationale for this change
FlightSQL JDBC Driver does not shade slfj4 api which may come into conflict into the version used by an application. If the application uses slf4j 1.x, it may cause the application slf4j backend to not be loaded properly.
The change configured maven-shade-plugin to also shade slf4j-api. To make sure log messages are still visible, slf4j-jdk14 is included as well so that all messages will be redirected to java.util.logging framework. The application can use jul-to-slf4j adapter to redirect log messages back to slf4j.
What changes are included in this PR?
Overrides Driver#getParentLogger() to return the root logger for the JDBC driver (which is org.apache.arrow.driver.jdbc). To make sure shaded dependencies loggers are included as well, change relocation from cfjd.  to org.apache.arrow.driver.jdbc.shaded. (or oaadj for native libraries)
Are these changes tested?
Verifying that slf4j-api is shaded along with the other relocation changes are covered by ITDriverJarValidation
Are there any user-facing changes?
Yes. Driver will not expose directly slf4j api and the logger names for the shaded dependencies have been updated. For applications which were relying on configuring directly a slf4j logging backend for the driver, they may need to include org.slf4j:slf4-api and org.slf4j:jul-to-slf4j for logging configuration to work.

GitHub Issue: #40907

@github-actions crossbow submit -g java


infinispan-cluster does not require infinispan-embedded to run and ca…

…n be replaced with the smaller dependency infinispan-core.


feat(miniapp): update compile miniapp version

[x] 升级 miniapp-compile-config 及 miniapp-builder-shared 依赖至 0.2.x，确保编译时组件工程支持 virtualHost 配置等能力

Codecov Report

Merging #225 (9643d70) into master (ef192e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   78.10%   78.10%
=======================================
  Files          31       31
  Lines        1137     1137
  Branches      209      222   +13
=======================================
  Hits          888      888
+ Misses        249      246    -3
- Partials        0        3    +3

Impacted Files
Coverage Δ

packages/generate-project/src/checkEmpty.ts
25.00% <0.00%> (ø)

packages/iceworks-cli/src/command/config/index.ts
93.33% <0.00%> (ø)

...iceworks-cli/src/command/init/addSingleMaterial.ts
38.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef192e9...9643d70. Read the comment docs.


multiple trials with consistent seeding

Implement a scheme for seeding multiple trials that allows for validating results with JoblibBackend and MPIBackend in #79. Ideally, this will produce the same results as HNN GUI. After this point, we can implement a plan for making changes such as how trials are seeded with provisions for being able to go back and test the "original" seeding scheme.
Note that #55 started to address this, but RMSE is a somewhat separate feature. The checks in test_hnn_core.py are more thorough than RMSE.

Right now, MPIBackend doesn't set unique seeds for each trial. That should be fixed in a PR that addresses this issue. Also JoblibBackend has a scheme that could be improved.
https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/parallel_backends.py#L88-L90
This doesn't guarantee unique seeds for each trial. For example, if a prng_ seed is set to 1, then the first two trials will have the same seed.
HNN's scheme of setting the seed is perhaps unique, but very convoluted. The function reset_src_event_times was adapted to hnn-core in #55:
https://github.com/jonescompneurolab/hnn-core/pull/55/files/39c6f8800fa5e28ecf785cda1ef5440626833c43#diff-535c9c5d7e5fe03d2cd31f20bd77fc25R263
It had different behavior for incrementing the seed depending on if an input is part of Network.extinput_list (increment by 1000)
https://github.com/jonescompneurolab/hnn-core/pull/55/files/39c6f8800fa5e28ecf785cda1ef5440626833c43#diff-535c9c5d7e5fe03d2cd31f20bd77fc25R270
or part of Network.ext_list (increment by 1):
https://github.com/jonescompneurolab/hnn-core/pull/55/files/39c6f8800fa5e28ecf785cda1ef5440626833c43#diff-535c9c5d7e5fe03d2cd31f20bd77fc25R277
@jasmainak what about changing
if trial_idx != 0:
    net.params['prng_*'] = trial_idx

to
net.params['prng_*'] += trial_idx

Can we implement an HNN-backward compatibility inc_prng function that will be deprecated once tests are done comparing to HNN and #136 is closed? See
https://github.com/jonescompneurolab/hnn-core/pull/55/files/39c6f8800fa5e28ecf785cda1ef5440626833c43#diff-91f1465772612a9e40c10b7dfab6c5f6R41

That's fine changing to:
net.params['prng_*'] += trial_idx

By the way, I think I finally understood why this increment of 1000 is done. It's because for the unique input feeds, you have a separate random number generator for each cell, so you add 1000 to avoid the possibility of overlap?
In my opinion, we should try to use the numpy interface for random number generation as much as possible rather than developing an ad hoc procedure which is going to be prone to bugs. For e.g., you can generate a series of 2D floats  and then send them to appropriate processes using either backend. This way we keep the randomness in the codepath outside of parallel.

In my opinion, we should try to use the numpy interface for random number generation as much as possible rather than developing an ad hoc procedure which is going to be prone to bugs. For e.g., you can generate a series of 2D floats  and then send them to appropriate processes using either backend. This way we keep the randomness in the codepath outside of parallel.

Sounds like a good plan. As long as there is a HNN-compatible method too that will be deprecated.

That's fine changing to:
net.params['prng_*'] += trial_idx

By the way, I think I finally understood why this increment of 1000 is done. It's because for the unique input feeds, you have a separate random number generator for each cell, so you add 1000 to avoid the possibility of overlap?
In my opinion, we should try to use the numpy interface for random number generation as much as possible rather than developing an ad hoc procedure which is going to be prone to bugs. For e.g., you can generate a series of 2D floats  and then send them to appropriate processes using either backend. This way we keep the randomness in the codepath outside of parallel.

So the plan down the road (i.e., after we've created a HNN-compatible method) is to have a system where we are no longer incrementally change net.params['prng_*'] right? For clarity's sake, I'm imagining that hnn-core will contain a one-time assignment that 1) instantiates the np.random.RandomState container and then 2) generates all jittered feed start times across trials which can then be passed to parallelized trials/processes. Then, we can add an argument to the ExtFeed constructor that allows the user to supply a single seed if they wish, otherwise, np.random.RandomState() will use a default seed. This will also eliminate the need to specify any 'prng_*' parameters in the param files. @blakecaldwell @jasmainak is this what you both had in mind?

yes, exactly that is the idea.

MPIBackend and JoblibBackend now provide unique seed states for each trial in a simulation that is consistent across backends with #171. What is left to do here is

[ ] Validate results with HNN
[ ] Refactor the process (including updating the API) for how seed states are assigned

@cjayb you might want to look at this issue and the discussion. I think it's related to the feeds PR. Perhaps with @rythorpe you guys could come up with a plan how to move forward on this? Please take a look at this to understand what the GUI currently does.

I wanted to check on the status of this. Is anything else needed @cjayb @rythorpe?

We added this property
https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/network_builder.py#L268
in order to enable this indexing
https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/network_builder.py#L402
that stems from the new 'feed instantiation' moved to Network:
https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/network.py#L315
I had a brief struggle with one of the examples failing to produce different dynamics for consecutive trials here
https://github.com/jonescompneurolab/hnn-core/blob/master/examples/plot_simulate_evoked.py#L49
but fixed that in dipole.py.
That's a long way of saying: I'm pretty sure the trial seeding is reproducible now.

That said, I totally second @rythorpe and @jasmainak above regarding not repeatedly re-seeding the prng! It's a relic from pre- #191 times, where event times were generated in NetworkBuilder, i.e., potentially on different hosts/ranks. Now everything is done in Network, so there's no reason to do that, other than backward-compatibility with the existing examples...
I'm sketching out a new example to demonstrate a new API for creating the feeds/drives we've been discussing for a while now. Being able to re-create the funky HNN-Classic seeding is causing more work than the API itself :)

@blakecaldwell I'm pretty sure, as @cjayb said, that hnn-core now has a fairly stable and consistent method for providing unique seeding across multiple trials. I've been running a few simulations to test the consistent between hnn-gui and hnn-core but something is off. I have yet to determine if the issue is caused by a seeding discrepancy or differences in some other feature.

was there an old commit where there was no discrepancy? If so, you can try to run "git bisect" ... I've found it very useful in narrowing things down in the past

was there an old commit where there was no discrepancy? If so, you can try to run "git bisect" ... I've found it very useful in narrowing things down in the past

I know we can simulate evoked inputs with no discrepancy, but the problems I'm encountering are when rhythmic inputs are added. I'm not aware of a time when we tested such a case and multiple trials were added.

Wild guess: could the cellular targets of the 'common' rhythmic feeds differ? Not just cell type, but location (soma vs dendrites)?

single trial works I believe (I checked this at least visually at some point). So it's got to have something to do with seeds. There is an increment of 1000 to look for somewhere.

This issue is resolved upon validating that the hnn-core output is consistent (explainable difference permissible) with that of HNN for all the following drives. (Please specify whether a single or multiple trials were validated and link to commits to hnn-core, and hnn or a tutorial image in hnn-tutorials.)

[x] evoked drives as defined in default.json produce multiple identical trials in https://github.com/jonescompneurolab/hnn-core/commit/ea2f3a778af04a1ae40ae7c56cbba1480fa2b07a and https://github.com/jonescompneurolab/hnn/commit/a09bb082b2c712f025faa9d755f3edf50f23d36a)
[ ] bursty (rhythmic) drives as defined in the alpha example (@ntolley)
[ ] poisson drives (@cjayb @jasmainak )
[ ] tonic baseline (@cjayb @jasmainak)

I can look into this after Feb 12 :)

I can look into this after Feb 12 :)

Totally fine @jasmainak. I'll probably be able to resolve some of these on my own this week - just wanted to keep y'all in the loop and request help if any of the items are quick fixes.

Running make doc on 58efb61d590737b8c53a54d0853633c6e58b6c52 produces the following results with reference to HNN GUI documentation
Alpha example (bursty/rhythmic drives)
Compare example output to relevant portion of Figure 7.

[x] I'd say this is a "check'

Gamma example (Poisson drive and tonic current clamp)
There are inconsistencies between HNN GUI output (current master) and the documentation. These need to be resolved before hnn-core output can checked against a standard.

Gamma example (Poisson drive and tonic current clamp)
There are inconsistencies between HNN GUI output (current master) and the documentation. These need to be resolved before hnn-core output can checked against a standard.

Are you referring to https://github.com/jonescompneurolab/hnn/issues/264 or are there other discrepancies as well?

Using the L5/L2 weak param file doesn't reproduce the Tutorial figure 4, I think, in current GUI master. Can you (de)confirm?

In my tests, HNN GUI (master) does not reproduce the website tutorial. I'm guessing it has to do with L89 in feed.py:
      t_gen = t0  - lamtha * 2 # start before t0 to remove artifact of lower event rate at start of period

If I change that to
      t_gen = t0

and run HNN GUI master with gamma_L5weak_L2weak.param, I get

I can reproduce this with hnn-core master, using the new API and setting seedcore to 1079 (which, confusingly, logically ought to correspond to prng_seedcore_extpois=-3...)

Note that there's a difference between gamma_L5weak_L2weak.param and gamma_L5weak_L2weak.json (hnn-core) in the seedcore for the Poisson process.
Take home message(?)
hnn-core can reproduce GUI output for Poisson drives, but there's something wonky going on wrt. seed assignments. I would say, though, that this is neat another

[x] check

hnn-core can reproduce GUI output for Poisson drives, but there's something wonky going on wrt. seed assignments. I would say, though, that this is ~neat~ yet another

[x]  check

Thanks for looking into this @cjayb. I had this on my to-do list but you beat me to it. I'm assuming that the difference in how hnn-core and HNN treat the seedcore param has to do with how we set gids?

Sure.

difference in how hnn-core and HNN treat the seedcore param has to do with how we set gids?

Well, it's a combination of params-files sometimes using negative seedcore-values, and the fact that HNN GUI always adds certain drive (feed) gids, regardless of whether they are used. In the end, it turns out that we need to set the Poisson seed to 270 + 2 + 3 x 320 - 3 = 1079... Long story...

I edited the description above for the Poisson. Didn't check it again now but I think it's correct. Please feel free to cross-verify @rythorpe. Note that prior to these two commits, there was a bug in both HNN and HNN-core because np.append return value was not used. While in HNN-core, this was fixed in beb590ff2404329599546ad512c097053d3d647c, in HNN an additional change was made to account for the burn-in.

Discrepancies in seeding between HNN and hnn-core have been removed or accounted for in each drive/bias type as outlined in https://github.com/jonescompneurolab/hnn-core/issues/113#issuecomment-774333145.


LSTM generation?

HI! In run_merlin.py there is a dnn_generation_lstm function that is never called even when the layers are defined with an LSTM as in ['TANH','TANH','SIGMOID','BSLSTM']. Is this a bug? I'm wondering if the DNN test result is accurate if the layers are defined with LSTM, but the generation doesn't use LSTMs?

I just deleted that function in the latest code. It was never used. The default function dnn_generation works for both feed-forward and LSTM-RNN layers.

okay, thanks.


RuntimeError: module compiled against API version 0x10 but this version of numpy is 0xf

RuntimeError: module compiled against API version 0x10 but this version of numpy is 0xf

What OS are you using, what version of python-control and NumPy, and how did you install python-control?


move tail-call checks to compiler

I did some digging, and I don't think this will be possible at the moment since the compiler doesn't know anything about the identity of functions or closures and therefore can't determine if a call is to the same function or closure that is executing in the current frame when a call expression is compiled.

Agreed. Will close this ticket for now.


Update MD file on new branch 2017-12-05_07-32-42

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: mobile ui svg icons

This PR relocates all svgs from the mobile app into the UI library. They are now exported from the UI library as React components with a default size of 24x24 and a 'small' variant of 16x16. All other SvgProps can be passed to change color, size, etc. The theme is used in the UI library to set the 'currentColor' as 'ink.action-primary-default', so the icons work with dark mode.
The native UI library build is now using tsup (aka 'sup'). 😆 Once this is merged, I can refactor the existing 'web' icons to use the svgs, but I wanted to separate the work into two PRs.
Preview of use...

@kyranjamie I'm getting a 'not-to-dev' dependency error here with tsup. Docs say it should be installed as a dev dependency, but we had it as a dependency. I moved it and added tsup to the pathNot, let me know if that isn't the correct way to handle that error. I also gitignored the generated .tsup folder.

Config files like tsup shouldn't be subject to rules of depcruiser, so good to ignore (even globally)


Release v11

Description
Merges all alpha changes to master.
This will add in change to use only event handlers and also adds in new 6.1.x chain events
Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 11.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


doc: Listed L2LB LB class to LB IPAM doc

Added the L2LB LoadBalancerClass io.cilium/l2-announcer to the LB IPAM documentation page.
doc: List L2LB LB class to LB IPAM doc

/test


Two fixes for scancode set 1

This PR updates the scancode set 1 state machine to make the Release and ExtendedRelease states equivalent to the Start state. Before, a clear call was required after each KeyEvent, because the Release and ExtendedRelease state were forever looping.
It also fixes a bug in the new scancode 1 implementation where a decimal 80 was subtracted instead of a hexadecimal 0x80. This fixes the issue that the KeyUp event of the shift key was not recognized so that the input stayed uppercase forever.
This PR also removes some trailing whitespace and runs rustfmt. This is of course optional and I can remove it if it's not wanted.
cc @ZerothLaw

Seems like I broke some tests. I will look into it…

Ok, seems like changing the state machine for scancode set 2 was the problem. I updated the PR to only apply the fixes for scancode set 1.

Thanks for finding that issue!

@thejpster Thanks! Could you release a new crates.io version with these fixes?

I consider this PR a bugfix, so I would probably bump the y. But I'm also fine with bumping the x.

Done


Dataset queries

HI Neel, what a great project it is, awesome stuff man :100:
I also wanted to test it on my local machine , could you please provide with some datasets that I could directly add and use here to directly test it's functionality.
https://github.com/neel-banga/DrinkWise-Cruz-Hacks/blob/8d2906e4f36e12a483fbf29d286de2fd4c28776f/face_model.py#L18
Thanks !!

HI Neel, what a great project it is, awesome stuff man 💯 I also wanted to test it on my local machine , could you please provide with some datasets that I could directly add and use here to directly test it's functionality.
https://github.com/neel-banga/DrinkWise-Cruz-Hacks/blob/8d2906e4f36e12a483fbf29d286de2fd4c28776f/face_model.py#L18
Thanks !!

bro did you run this project in your local machine? can you guide me


created a menu item for displaying app dependencies on ui

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[X] Yes
[ ] No, because:

Have you updated all relevant documentation?

[ ] Yes
[ ] No

Description
Related Tickets & Documents

Related Issue #5223
Closes #5223

QA Instructions, Screenshots, Recordings

Merge Plan

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Feedbacks please

@rohinish404 - Lint tests are failing though

You'll need to add translations

You'll need to add translations

Added!

@psychedelicious @hipsterusername  should i add links to yt and twitter also?

With the current styling as text links probably best to leave as is

With the current styling as text links probably best to leave as is

Okay..then it is ready to be merged! All tests passed!

Thanks for working on this @rohinish404!
I've requested a few changes.
I've also provided a desired design in a video. If you're up for the challenge, you can implement the design. If you are tapped out on this PR, no worries, I can update it.

I'll start working on these! Thanks for the feedbacks! :)

All requested changes done! Now further feedback required!

@psychedelicious couple of pointers on the latest commit -

changed the height of both components to 50 as we discussed in discord.
replaced flex with grid to make the space between deps and versions less (basically to match the example you gave).
replaced the margin top with justify content as you suggested.

Got this error while trying to test:
at InvokeTabs (http://localhost:5173/src/features/ui/components/InvokeTabs.tsx:152:28)
   at div
   at http://localhost:5173/node_modules/.vite/deps/chunk-JJ4RZU4H.js?v=a76f4282:1396:45
   at ChakraComponent (http://localhost:5173/node_modules/.vite/deps/chunk-7IPMFKXC.js?v=a76f4282:5539:35)
   at ErrorBoundary (http://localhost:5173/node_modules/.vite/deps/react-error-boundary.js?v=a76f4282:18:5)
   at App (http://localhost:5173/src/app/components/App.tsx:36:16)
   at DndContext2 (http://localhost:5173/node_modules/.vite/deps/@dnd-kit_core.js?v=a76f4282:2494:5)
   at DndContextTypesafe
   at AppDndContext (http://localhost:5173/src/features/dnd/components/AppDndContext.tsx:22:49)
   at EnvironmentProvider (http://localhost:5173/node_modules/.vite/deps/chunk-PUI7XM66.js?v=a76f4282:68:11)
   at ColorModeProvider (http://localhost:5173/node_modules/.vite/deps/chunk-7IPMFKXC.js?v=a76f4282:328:5)
   at ThemeProvider2 (http://localhost:5173/node_modules/.vite/deps/chunk-JJ4RZU4H.js?v=a76f4282:1443:22)
   at ThemeProvider2 (http://localhost:5173/node_modules/.vite/deps/chunk-7IPMFKXC.js?v=a76f4282:5616:11)
   at ChakraProvider (http://localhost:5173/node_modules/.vite/deps/@chakra-ui_react.js?v=a76f4282:579:5)
   at ChakraProvider22 (http://localhost:5173/node_modules/.vite/deps/@chakra-ui_react.js?v=a76f4282:1344:5)
   at ThemeLocaleProvider (http://localhost:5173/src/app/components/ThemeLocaleProvider.tsx:18:32)
   at Suspense
   at Provider (http://localhost:5173/node_modules/.vite/deps/chunk-UFRHBOCB.js?v=a76f4282:1089:3)
   at InvokeAIUI (http://localhost:5173/src/app/components/InvokeAIUI.tsx:33:23)

Full log:
localhost-1705429568363.log

Thanks! I made a couple very minor changes.

Awesome! Thanks for the merge!🙂


Enhance runtime input with k8sclusterreciver metrics

Description
As part of https://github.com/kyma-project/telemetry-manager/issues/972 enhance the current runtime input with metrics provided by k8sclusterreceiver
Criterias

The metrics for pods and containers are enhanced with additional metrics as outlined in https://github.com/kyma-project/telemetry-manager/issues/1001#issuecomment-2154182359
The new metrics are based on the k8sclusterreicever being wrapped with the leader-election-receiver

Tasks

Use new otel-collector distro
the runtime input generates a k8sclusterreiceiver receiver, selecting the metrics matching the resource selector of the input (RBAC changes needed)
The k8sclusterreiceiver is wrapped by a singletonreceivercreator (RBAC changes needed)
Enhance documentation
Enhance E2E test for runtime input (to assure compatibility of the emmitted metrics)
Come to a decision if new metrics can be added for existing cluster (check the amount of new metrics/labels added per container)
Implement decision results and remove feature flag

Reasons

Attachments

Release Notes

First step:

Enhance kubeletstatsreceiver metrics for pods/containers with k8sclusterreceiver metrics
Hide this change behind a feature flags, we don't want to roll it out to the users before there is a way to exclude metrics

The feature has been implemented without feature flag. Currently a total of 5 new metrics have been exposed when runtime is enabled on metricpipeline


fix: show assets for available chains

check is chain id match for active accounts on assets page

Task linked: CU-8693j5t6f Proxy. Assets page. Does not match with mockups


Q: Filtering ManyToMany in Django authorize_model?

Given the following models:
class Tag(Model):
    name = CharField()

class Article(Model):
    tags = ManyToManyField(Tag)

How would I write an Oso policy that allows access on a tag with a certain name being present on an article?
authorize_model(request, Article)

What I want to do is something like this:
allow(user, "GET", article) if
    article.tags.filter(name: "public").exists()

But calling methods for authorized models is not allowed.

tag in article.tags and

Unfortunately, this yields
InvalidIteratorError: myapp.Tag.None is not iterable

The culprit probably being that the ManyToManyField is not handled properly:
QUERY: _tag_359 in <django.db.models.fields.related_descriptors.create_forward_many_to_many_manager.<locals>.ManyRelatedManager object at 0x7f1238889c90> TYPE `UNKNOWN`, BINDINGS: {}

Hm... is article.tags nullable? I.e., the null state would be article.tags: null instead of article.tags: []?

On Mon, Sep 12, 2022 at 08:20:04AM -0700, Gabe Jackson wrote:

Hm... is article.tags nullable? I.e., the null state would be article.tags: null instead of article.tags: []?

No. In fact, the error occurs both for a ManyToMany relation that has
entries and for an empty relation.

Hi @Natureshadow,
I edited that comment, but the edit may've not made it to your email inbox.

Is Model here django_oso.models.AuthorizedModel?

No, it's not. Also, I am not using authorize_model here, but simply authorize on one single instance.

No, it's not. Also, I am not using authorize_model here, but simply authorize on one single instance.

Sorry, I assumed from the title of the issue that you were using authorize_model. If you're calling authorize on a single Article instance, I'm surprised that the code you pasted earlier didn't work:
allow(user, "GET", article) if
    article.tags.filter(name: "public").exists();

Are you able to share a reproducible example with me?

Sorry, I assumed from the title of the issue that you were using authorize_model. If you're calling authorize on a single Article instance, I'm surprised that the code you pasted earlier didn't work:
allow(user, "GET", article) if
    article.tags.filter(name: "public").exists();

That works with authorize. But my goal is ultimately to use authorize_model. If I rewrite the policy as proposed by you, authorize stops working as well.

The (slightly more complex) instance of the problem is this policy here:
https://edugit.org/AlekSIS/official/AlekSIS-Core/-/blob/492-follow-up-view_persons_rule-not-usable-due-to-use-of-queryset_rules_filter/aleksis/core/policy/permissions.polar
Its goal is to glue Oso and Django permissions together.
It explodes both in line 16 an line 31, with auth.Group.None is not iterable and auth.Permission.None is not iterable, when using authorize_model.


Is it possible to define the react components  within the render() method server side in asp.net core ?

Hello.
I am using a third party react client library for elastisearch (https://opensource.appbase.io/reactivesearch/) where i define the components inside the render() method of  a  .tsx  file.
Is it possible with  react.net to dynamically define the html and react components from the server side in asp.net core  and then consume from the react component.
See I have a design guy who wants to define the rendered template from server side code in asp.net core razor and
pass it into a custom renderer dynamically.
So I am imagining the solution something like the following .
I might have a hidden or nested div inside the main entry point from my razor template in asp,net core (which contains the html and react components ) i wish to pass to the render() method and that will be defined server side ,
Is such a senario possible with react.net ?

I think the same code  should fit your use case, just pass in that url as part of the props


Replace the link to the access token due to the switch to Mapbox Studio

Thanks for catching that @ustroetz, merging.
It's good to work with you again!

Thanks @perrygeo! Nice to see you at Mapbox :)


[WIP] fix unnecessary horizontal scroll bar in message due to trailing whitespace

I added rstrip to each line of code in the fence block before it is sent to output. I included a doctest. Previous doctests were failing due to the tests expecting closing code_wrap to be on separate new lines. So I added new line to code_wrap.
Fixes #3998

Automated message from Dropbox CLA bot
@hollywoodno, it looks like you've already signed the Dropbox CLA. Thanks!

Awesome!  I tried it and it and it looks great.  To finish this project we'll probably want to do 2 things:

Modify the frontend markdown parser to do the same thing; I think static/js/fenced_code.js is the file in question.  I suspect maybe just involves patching handle_line there to use util.rtrim() as well.
Add an end-to-end test in zerver/fixtures/bugdown-data.json.

That looks great @hollywoodno!  Can you rebase to squash the commits and clean up your commit messages?
Check out our GitHub guide and commit guidelines for details on how to do this and why it's important.

Will check out the docs. Thanks.

@hollywoodno congrats on successfully squashing your changes!  The only thing you were missing is using git commit --amend to make the commit message have a more extensive description (and auto-close the original bug).  I merged this as d6716838adbdd8414de133cd0fe986e361d90902 after editing the commit message for you.  Thanks and congrats on fixing a relatively complex issue here!


[No QA] Empty state modal

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/44306
PROPOSAL: -
Tests

PREREQUISITES: you need to have permissions for workspace card enabled

Go to Workspaces -> Workspace -> Expensify card (enable it in more features if you don't have it enabled)
Click Issue New Card, verify that you're redirected to the Choose Bank Account page
Choose a bank account
On web after choosing bank account you will see that under the RHP the page changes. Dismiss the modal. On mobile you will see Issue New Card flow step 1 - go back with back button - you should be redirected to the Expensify Card page.
Verify that you see a modal, the skeletons and two buttons (Issue card and Settings) above.
Scroll the page - after scrolling down you should see the disclaimer.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

n/a

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

padding fix:

iOS: Native

padding fix:

iOS: mWeb Safari

padding fix:

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/d212e7e7-b42a-4d6a-bae0-30092fa18811

padding fix:

MacOS: Desktop

padding fix:

@shawnborton padding fixed:

Amazing - and just confirming that the modal uses 20px padding for mobile devices?

@shawnborton yep, it now has the same styles as Workspace Empty page. I have some problems with building the app on mobile rn, so I can't make a screenshot. When I fix it I'll add one.

Wonderful, thanks again!

@koko57 making a build so you can at least test android
@allgandalf @DylanDylann maybe you could test the native too and provide screenshots to unblock this?

I will take over this PR

The screenshots are looking great! Just one small thing here on mobile where I'm seeing a slight green line/border below the top modal image/illustration:

@shawnborton I'm looking into it. Not sure if it is one of the reasons, but in the SVG the screenshot element is subtly overflowing the green background

Oh good catch on that... here is a new one to try, sorry for all of the different versions of this one. emptystate__expensifycard.svg.zip

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@koko57 It failed on native app

@DylanDylann just pushed a fix for that - can you test on Android, please? I'm still having a problem with building for android, I have screenshots for iOS, will add them in a sec

@shawnborton I've added the screenshots for padding fix for other platforms to the Author's Checklist

@mountiny I'm still fighting with Andorid builds, should I open the PR anyway?

I will test this PR on Android. Feel free to open this PR

Look good on Android

I will try to finish the checklist today

Nice, I think that fixed the illustration too.

conflicts resolved

@koko57 I don't think we should use ScrollView in EmptyCardView Component. We should display the footer in the end of page
https://github.com/user-attachments/assets/a6941d68-f22b-4152-ad9f-151e7746ebc3

I don't think we should use ScrollView in EmptyCardView Component. We should display the footer in the end of page

What we're doing in the video is on purpose though, we want to make the fine print show below the fold here.

@koko57 Please resolve conflict

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@DylanDylann conflicts resolved

@koko57 Lint error 😄

@DylanDylann fixed

Looks good to me! The only minor thing I can spot - do we want a little more space below the buttons and above the empty state rows?

cc @Expensify/design for thoughts

Yeah I think the desktop spacing looks pretty good but I think the mobile/small viewports could benefit from a little extra space below the buttons.

Thanks, I think we can address that in the next design follow up as this is a larger PR to avoid conflicts, I will merge it now and link this to the design polish issue

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.0.11-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


WIP: tcp_proxy tests: Add more integration tests for upstream flushing.

This adds coverage to the previously untested case of exiting Envoy
while flushing.
Signed-off-by: Greg Greenway<EMAIL_ADDRESS>Risk Level: Low

@mattklein123 This adds coverage for one of the cases you mentioned yesterday in tcp_proxy.
However, I haven't figured out how to make the test work yet.  I need to close the fake_upstream_connection after I destroy test_server_, but that doesn't work.  Any thoughts?  I really want the fake_upstream_connection to be in a completely separate space (memory, threads, all dependencies) from the test_server_.

Isn't fake upstream already split into its own thread?    I know we access it a lot but that's what the locks are for.
Are you more hoping it would process on its own without waiting on instructions from the main thread?  If so take a look at the autonomous upstream.  It's mostly wired up to auto-respond for HTTP but I think it could be extended to do TCP as well.

Something doesn't work, because the final waitForDisconnect() hangs forever.  After shutting down the test server, I'd expect the fake upstream to know that it is closed (via remote close).

Huh, I'd try -l trace and/or cerr logging that the connection is torn down and the fd is closed on cleanup.  When a process goes away all open FDs are closed but I don't know if we close all fds for Envoy on connection destruction and server deletion.  That'd be my best guess as to what's going on

(Will review this unless you fix everything tomorrow and Matt merges it before I even see it =P)

@alyssawilk I think I fixed the test, but I'm not happy with what I found.  I single-stepped through the test in the debugger with a tcpdump running.  Envoy correctly called ::close() on the connection, but no FIN was sent, according to tcpdump.  So that's a bit weird.  But there shouldn't be anything wrong with just closing the fake upstream connection, as the latest commit does.  And in a non-test case, when envoy is really exiting, I presume the kernel will fully clean up anything.

Or he can go ahead and approve right after me, since Matt is ever vigilant :-P
I'm still calling not-it on the merge since it still has WIP in the title.


Fix: require audobject>=0.7.2

Closes #13
It uses a new version of audobject which works fine together with audinterface>=0.9.0.

Alternatively, we could also update the requirement to audonnx after https://github.com/audeering/audonnx/pull/44 is released. But of course, adding a minimum version for audobject is also fine.


Migrate to GH Actions

This PR was prepared by an automated action. Closes #17. Fails because of some combinations timing out (#19)

CI failures to be followed up at https://github.com/inveniosoftware/invenio-queues/issues/19.


An app reported split screen when fullscreen

Steps to reproduce

Install bilibili or bilibili hd from some source such as https://www.bilibili.com
Open the app in fullscreen
Play some random video
Click the fullscreen button

✔ Expected Behavior
Go fullscreen
❌ Actual Behavior
The app reported that fullscreen is not possible in split-screen mode
Other Software
No response
Please specify the version of Windows Subsystem for Android
2309

Hi, Android apps on WSA are launched in multi-window mode and not in full screen. Hence, this is by design. To make app full-screen, you can use F11 key.

Hi, Android apps on WSA are launched in multi-window mode and not in full screen. Hence, this is by design. To make app full-screen, you can use F11 key.

The app was full-screen but it doesn't think it is fullscreen so refused to play video fullscreen

Hi, Android apps on WSA are launched in multi-window mode and not in full screen. Hence, this is by design. To make app full-screen, you can use F11 key.

I made it fullscreen


syntactic ambiguity

I just realized there's a pretty interesting ambiguity in the syntax, mostly around defining functions vs applying anonymous functions. Witness:
f = fn x y {
x + y
};
g = fn x y {
x + y
} 10 11;

Technically, the first is a function definition and the second is the application of a function, but
we can't tell that until we get to the next token. It's still LL(1), but it's an interesting case I hadn't considered. Also, this does not impact gn, but does impact fc, because of how they are syntactically defined, which is neat. I'll leave this issue open to stew on how I might want to handle that.

Part of me doesn't really like this, because it means that the thing that determines an anonymous function call or not is whether or not something is immediately terminated by a ;, and I've tended to prefer that things should be clear from the get go. we could add a def form, but I'm not super thrilled about that either; it could be fun ... nuf and match how gn works, and that would mean anonymous functions are just fn.

I should note, I saw the general case of this previously in parsing call forms; it's why we actually end up parsing a call and then if it's a single object returning that rather than a call AST... basically heading down the same route, but it makes thinking about easier in some ways.

also, I'm sorta loving the StandardML style now that I think about it:
fun foo 10 = 10
| foo 11 = 11
| foo n = n + 1
nuf

it allows us to get something like the case lambda form of fc without having to do much more, and it feels like a real ambiguity win for beginners.

(the foo = fn ... form would of course still stay, I just meant for most people it's a clear syntactic delineation in the lexeme stream)

As a note, I added a test for this in the self-hosting compiler, and it correctly compiles the two cases, so closing this at least. Also note that the self-hosting compiler will have support for the fun form shortly as well.
a = fn x is int y { x + y; };
 SandCityAST_Assignment(m_0=IdentType_Ident(m_0='a'), m_1=SandCityAST_FnBody(m_0=SandCityAST_ParameterArray(m_0=[SandCityAST_Declare(m_0=IdentType_Ident(m_0='x'), m_1=SandCityAST_IntT()), IdentType_Ident(m_0='y')]), m_1=SandCityAST_Block(m_0=[SandCityAST_OpCall(m_0=IdentType_Ident(m_0='+'), m_1=[IdentType_Ident(m_0='x'), IdentType_Ident(m_0='y')])])), m_2=SandCityAST_Unit())
f = fn x y { x + y; } 10 20;
 SandCityAST_Assignment(m_0=IdentType_Ident(m_0='f'), m_1=SandCityAST_FunCall(m_0=SandCityAST_FnBody(m_0=SandCityAST_ParameterArray(m_0=[IdentType_Ident(m_0='x'), IdentType_Ident(m_0='y')]), m_1=SandCityAST_Block(m_0=[SandCityAST_OpCall(m_0=IdentType_Ident(m_0='+'), m_1=[IdentType_Ident(m_0='x'), IdentType_Ident(m_0='y')])])), m_1=[SandCityAST_Integer(m_0=IntType_Int(), m_1='10'), SandCityAST_Integer(m_0=IntType_Int(), m_1='20')]), m_2=SandCityAST_Unit())


Update and rename data-migration.md to attributes-type-migration.md

Title is also updated.

Please update the PR with updated references to the document you changed, so the documentation will build. See the errors here: https://travis-ci.org/mendix/docs/builds/228694560.


Help

Hello.I am a beginner.My markdown text has tabs.Can I render it with 4 spaces?Thanks~

https://spec.commonmark.org/0.29/#tabs


ipam/allocator: Fix nil check on node CIDR

See commit msgs.
Fixes: ef6ecbdb61 ("add error log When ipam allocate nodecidr failure")
Fixes: https://github.com/cilium/cilium/pull/13299
Fix bug in cluster-pool IPAM mode where the user is never alerted of a node CIDR allocation failure

test-me-please

retest-gke

retest-gke

retest-net-next

Marking ready to merge as we have code owner approval and all CI passing.


Incorrect ResNext Model

In the original resnext model paper (https://arxiv.org/pdf/1611.05431.pdf), the expansion of their bottleneck block is 2 instead of 4.

@szagoruyko could you have a look at this? You've mentioned the expansion 2 in the past for WRN

in ResNeXt it is 4 from their code https://github.com/facebookresearch/ResNeXt/blob/master/models/resnext.lua#L86
in ImageNet WRN expansion is 2

Yes, but from the paper (Table 1), the expansion of ResNeXt-50 (32×4d) is 2?

@D-X-Y torchvision.models.resnext50_32x4d() gives exactly the same model as in table 1. afaik @fmassa implemented it in a such way that the outer bottleneck size is fixed and only the inner can increase / decrease. but the code is a bit confusing yeah.

I see, the model is indeed the same. Sorry for my mistake.

@szagoruyko if you see ways of making the implementation less confusing, please let me know!


[ADD]: TRACK NOT FOUND GAME  👾

PR Description 📜
This PR is about adding Track Not Found game
Fixes #890

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Working Video 📹
https://github.com/kunjgit/GameZone/assets/92252895/487c107c-72a9-4b5f-a679-3cadb6016001

[ The video can lag due to my low end pc, sorry for the inconvenience ]

Thank you soo much for contributing to our repository 💗

/assign


Docs and Linting changes

All relatively minor. Let me know what you think.

Thanks, looks good 👍 One question re. adding linting section to readme.


versioning

fixes #25

@DougManuel I agree with splitting up the tutorial as soon as we get enough content. I didn't think about validating the parts list, but it sounds like a good idea, unless it's unnecessary? I'll defer to yulric.

@DougManuel I agree with splitting up the tutorial as soon as we get enough content. I didn't think about validating the parts list, but it sounds like a good idea, unless it's unnecessary? I'll defer to yulric.

Validating the parts list isn't a priority at this point, but let's keep in mind for the future. You are off to a good start informally validating a few columns within your validation package.

missing version1* field impl. converting back to draft.


fix(sdk): nonce manager caching bug

Issue being fixed or feature implemented

Fixes bug with the caching of the nonce
What was done?

Changed Map key type from Buffer to String
How Has This Been Tested?

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
[ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

@markin-io why does this fix things?


Rename maxfilesize to max_file_upload_size & Fix Error message

Related to #12152.

While we're fixing this, the error message always shows 25MiB:
static/js/upload.js: msg = i18n.t('"__file_name__" was too large; the maximum file size is 25MiB.', context);
That value is available in page_params as maxfilesize; so I think someone should do a quick PR that:

Renames maxfilesize to max_file_upload_size for consistency.
Makes that i18n.t line use the actual value of max_file_upload_size so the error message isn't wrong.

GIFs or Screenshots:

Nice, merged, thanks @vinitS101!


SafariURLHandler presents SFSafariViewController without keyboard

Description:
SafariURLHandler presents SFSafariViewController without keyboard, making it impossible to type a password in to complete the OAuth flow on Twitch.
OAuth Provider? (Twitter, Github, ..):
Twitch
OAuth Version:

[ ] Version 1
[x] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[ ] CocoaPods
[x] Swift Package Manager
[ ] Manually

Library version:

[ ] head
[ ] v2.1.0
[ ] v2.0.0
[ ] v1.4.1
[x] other: (Please fill in the version you are using.)
2.1.2

Xcode version:

[ ] 11.4 (Swift 5.2)

[ ] 11.x (Swift 5.1)

[ ] 10.x (Swift 5.0)

[x] other: (Please fill in the version you are using.)
Xcode 12.5

[ ] objective c

any reason to not pass to ASWebAuthenticationSession ?
then you could edit the code to see if you find a fix
there is also a factory field to customise the instance https://github.com/OAuthSwift/OAuthSwift/blob/2384f60031ac824826fc367e6ed963b2c3eae797/Sources/Handler/SafariURLHandler.swift#L30


lack of UI during playback online radio

Required Info

Host Operating System & Version
{Ubuntu 20.04.2}

Kernel Version (Linux Only)
(5.x)

Branch
{ kantv }

Android Studio Version
4.2.1

NDK Version
NDK-r14b

Xcode Version
12.5

Language
{Java }

Section
{ HLS }

Issue Description
black screen during playback online radio
How to reproduce the issue

open online Radio  http://sk.cri.cn/am846.m3u8 ( CRI (online english radio from China) )

launch playback

black screen during playback online radio program
Root cause
lack of UI during playback online radio program
UI status / animation should be added during playback online radio program

References:
https://github.com/chaohengxing/VoisePlayingIcon   @chaohengxing, thanks
https://xfans.me/archives/178 (cn)


Generates docs automatically

The CI can generates docs, then pushing them to the gh-pages branch.
Travis CI docs: https://docs.travis-ci.com/user/deployment/pages/
If you are not a fan of giving a GITHUB_TOKEN, which I totally agree (it is like giving our GitHub password), then an other option is to add a SSH public key to the repository.
The issue is that your account will be now the committer.
I have made an image, but the script can be used directly: https://github.com/j8r/dockerfiles/tree/master/gh-pages-ci.
A third option can also be to create a new GitHub user for this.
cc @veelenga

I think i can generate a token and just add it to the Travis build as an environment var. No one will be able to use it afterward.

@veelenga If it is possible to use GitHub Actions, I can do the docs automation myself (I have already done this for some other of my projects) - and no token needed.

@j8r thanks. You were right regarding public key. I didn't want to share it, sorry. Good to know about GitHub Action.


progwrp.lib for unbranded builds.

@win32ss Hi again. Im trying to make a .patch file based on your source to make an unbranded build of Chromium for NT 5.x, i.e. without Supermium branding and without ungoogled patches. However, progwrp.lib is needed for compilation (not just the .dll).
Could you add that to the tree, or make it open source, (or maybe not open source, but just make the .lib and .dll available for usage). If none of that's possible or you don't wish to do so (which I wouldn't blame you for, it's a unique piece of work that probably took alot of time, and which you will probably use in other products from your new company), would you be willing to share it with me under an NDA, just so that I could make builds of Chromium (and possibly Thorium) for Win XP. My mom is a lawyer, so it happens, and she could draft up a contract of some sort basically saying that I wont distribute or share anything related to it except the final .dll in the finished browser.

Known issue:
https://github.com/win32ss/supermium/issues/300
BTW the code is not so hard to reproduce, if you want. Just take some time. You can also create .lib if you want.
But this just "not cosher" for open-source repo.

@IDA-RE-things How would I make the .lib from the .dll?

@IDA-RE-things How would I make the .lib from the .dll?
Just use dl2lib and so on. And you hands ... An some small time.

@IDA-RE-things OK will try.

@IDA-RE-things Update: I was able to generate .lib and .exp files for it. Then I generated a .patch file by copying Supermium over the Chromium tree, then removed the Supermium branding and ungoogled patches. Now I am building, with the .lib placed in the //out/Release folder as well as //build/config (where it is picked up and applied to all build targets). Will let people know here whether I get a successful build or not, and whether it runs properly on Win XP.

@Alex313031 thats Cool. I personally want to build Chromium not just to run on XP, but build on XP. And fixed Microsoft tools for that in the past. Are you use VS2015 to rebuild ?

@IDA-RE-things No. Chromium must be built with 2019 or 2022. And uses functions only present in Windows 8.1 and above. Minimum is MSVS 2019 on Win 8.1/2012 R2.

@Alex313031 , Ok , I can try to fix VS2019 to run on XP also.
I have not so power machine, just Intel Core i3 3500. And I use XP with 16 Gb memory.  If it will take 8 hours instead of 4, -- not a problem for me at this time. This is not everyday job.

@IDA-RE-things Memory is OK.
There is no such model as 3500 in ivy bridge > https://en.wikipedia.org/wiki/Ivy_Bridge_(microarchitecture)#Desktop_processors are you sure it isn't something else?
Compiling on the top of the line Haswell CPU the 4790K, takes about 6 hours. Your setup can compile it fine, but yeah, expect it to take 8+ hours or more.

Intel Core i3 3.5 GHz.
Yes, I know it will take 8 hours and above.
Not a problem. I will spent more time to prepare it to build and to reconfigure all , if it will be needed.

@IDA-RE-things Ahh, top of the line 2 core 4 thread i3. Will probably perform as well as a top of the line 4 core 1st gen "nahlem" CPU.
And lol yeah, sometimes it does.

@Alex313031 , in any case I dont care about this. Its not separate builds machine, but my usual dev environment, witch is enought for me.
What about compiling your Thorium on you side  ? Is it was successful ?  Can you run pdbcopy to create "stripped-down" pdb for its Chrome.dll from Chrome.pdb ? because it fails for PDB created by @win32s for v122, as I  explined here  #

@IDA-RE-things The .lib I created doesn't work.
Trying to run on XP yields AcquireSRWLockExclusive was not found in KERNEL32.dll. This is supposed to be handled by progwrp.dll and using binary grep the string was found in the dll.
On windows 7 it crashes. However, if I remove the progwrp.lib from the linker flags, and change PSAPI_VERSION back to 2 (the normal value for win7+), then it works fine, but of course not on XP.
I think @win32ss supplying the .lib will be the only way to build for XP.

I rebuilt. lib, but Win7 failed and crashed

@IDA-RE-things The .lib I created doesn't work.
Trying to run on XP yields AcquireSRWLockExclusive was not found in KERNEL32.dll. This is supposed to be handled by progwrp.dll and using binary grep the string was found in the dll. This is what I did when making a custom vanilla Chromium patch for Windows 7 to base Thorium-Win7 on.
On windows 7 it crashes. However, if I remove the progwrp.lib from the linker flags, and change PSAPI_VERSION back to 2 (the normal value for win7+), then it works fine, but of course not on XP.
I think @win32ss supplying the .lib will be the only way to build for XP.

I compiled it according to your method, and after running Win7, it crashed

@longyixiao See here. This is all you need to do to make a Win7 build > https://github.com/win32ss/supermium/compare/main...Alex313031:cr-win7:main

@Alex313031 Do you have this situation on your end


Terraform Example Code Optimized

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@ocofaigh can you kindly review this PR, and provide the feedback. Thank you

:tada: This PR is included in version 2.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Metadata / Metadata docs

Metadata docs spec is missing in Event detail and Call detail

and in other places ... find wherever is good to show runtime's metadata docs (definitely call names, event names)

also interlink spec version into metadata explorer


compiletests: unlock // {only,ignore}-* usage.

Opening as draft because https://github.com/Manishearth/compiletest-rs/pull/249 isn't merged yet.
This enables the test from #789 to correctly run only on vulkan1.1 targets, and be ignored on other targets (tested both with the default and --target-env opengl4.5).
We should also be able to use // ignore-* now, without compiletest-rs panicking.

https://github.com/Manishearth/compiletest-rs/pull/249 is now merged, this just needs rubber-stamping.


CHANGELOG.md not updated for latest version

Hi there! 👋
Thanks for creating the Obsidian API - it's so great to be able to create plugins for my favourite note-taking tool 🥳
I can see that a new version of the obsidian npm package was released earlier this week, v1.6.6. The CHANGELOG.md file has not been updated, which makes it hard to know what has changed or if it is safe to update my plugin's dependency.
Would you be update to update the CHANGELOG.md?
Thanks! ❤

For clarity, we have added the following to the top of the changelog file:

This CHANGELOG details any breaking changes to the API or new additions that require additional context. The versions listed below correspond to the versions of the Obsidian app. There may not be a corresponding package version for the version listed below.


Refactor category vuex module. Use getters and actions

Related issues
#2048
Short description and why it's useful
For the first step of #2048 checklist i took category vuex module.
I've created getters, actions and mutations and changed all state references to this getters, and every state direct object change to vuex action.
It doesn't change any logic (except adding available filter - i'm adding whole filter with its options, not per option), just separates layers responsible for changing store.
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

This branch should not be merged before

[ ] naming convention specified and added to our docs
[ ] 1.6 release

@filrak afet apllying my suggestions: yes. We must minimize the number of changes


AX Exchange error when MFMailComposeViewController has been initialized.

Description
when EarlGrey tries to open a  viewController where the MFMailComposeViewController has been initialized,  many warning messages start being printed on the console. and earlgrey keeps waiting  forever until the test is marked as failed.
The warning message is:
AX Exchange error: Error Domain=Accessibility Code=0 "Remote service does not respond to _accessibilityMachPort" UserInfo={NSLocalizedDescription=Remote service does not respond to _accessibilityMachPort}
observations:
If you turn off synchronization the test continues until it finish, which marks the test as success. but the warning messages keeps appearing.

Based on looking around for this error, this looks like a Synchronization problem with the MFMailComposeViewController. Thanks for bringing this to our attention. Is there a simply way by which we could repro this?

To reproduce it you just need to create an instance of MFMailComposeViewController on some ViewController and add it as a property of that ViewController, create that instance inside viewDidLoad()
the view controller needs to have some view attached to it.
and this view should have some accessibilityElements turned on with an accessibilityIdentifier settled.
then, create a simple test that opens that viewController
after that, the error posted above should appear in the console log of xcode.

@PikaRules, was there any update on this from your side? Is it still present?

Fixed by commit: https://github.com/google/EarlGrey/commit/9744dfe35334393c19a01b66610abe754eafc3ab


miss spelling on "Fallow me" :wink:

correcting miss spelling on "Fallow me" -> "Follow me" on the Contact area.

Hi vinisaveg, Thanks for the contribution 😉


steroid dehydrogenases

I think the following terms should be moved to be
children of
steroid dehydrogenase activity ; GO:0016229 ; EC:1.1.1.-
instead of direct children of oxidoreductase activity,
acting on the CH-OH group of donors, NAD or NADP as
acceptor ; GO:0016616.
12-beta-hydroxysteroid dehydrogenase activity ;
GO:0047521 ; EC:<IP_ADDRESS>
12-alpha-hydroxysteroid dehydrogenase activity ;
GO:0047013 ; EC:<IP_ADDRESS>
16-alpha-hydroxysteroid dehydrogenase activity ;
GO:0047005 ; EC:<IP_ADDRESS>
20-alpha-hydroxysteroid dehydrogenase activity ;
GO:0047006 ; EC:<IP_ADDRESS>
21-hydroxysteroid dehydrogenase (NAD+) activity ;
GO:0047007 ; EC:<IP_ADDRESS>
21-hydroxysteroid dehydrogenase (NADP+) activity ;
GO:0047008 ; EC:<IP_ADDRESS>
3(or 17)-alpha-hydroxysteroid dehydrogenase activity ;
GO:0047023 ; EC:<IP_ADDRESS>
3-alpha(17-beta)-hydroxysteroid dehydrogenase (NAD+)
activity ; GO:0047035 ; EC:<IP_ADDRESS>
3-alpha(or 20-beta)-hydroxysteroid dehydrogenase
activity ; GO:0047044 ; EC:<IP_ADDRESS>
3-alpha-hydroxysteroid dehydrogenase (A-specific)
activity ; GO:0047026 ; EC:<IP_ADDRESS>
3-alpha-hydroxysteroid dehydrogenase (B-specific)
activity ; GO:0047042 ; EC:<IP_ADDRESS>
3-beta(or 20-alpha)-hydroxysteroid dehydrogenase
activity ; GO:0047024 ; EC:<IP_ADDRESS>
7-beta-hydroxysteroid dehydrogenase (NADP+) activity ;
GO:0047022 ; EC:<IP_ADDRESS>
estradiol 17-alpha-dehydrogenase activity ; GO:0047881
; EC:<IP_ADDRESS>
testosterone 17-beta-dehydrogenase (NADP+) activity ;
GO:0047045 ; EC:<IP_ADDRESS>
testosterone 17-beta-dehydrogenase activity ;
GO:0050327 ; EC:<IP_ADDRESS>
thanks,
Becky
Reported by: beckyfoulger
Original Ticket: "geneontology/ontology-requests/1564":https://sourceforge.net/p/geneontology/ontology-requests/1564

thanks www.movied.org