Encoding / decoding

Encoding
Say you want to encode a unit as json. Given (meters 10), one reasonable representation is:
[10 , "m"]

another would be:
{
  "amount": 10,
  "unit": "m"
}

to do this you have to write something like:
(require '[anteo.units :as un])
(def m (un/meters 10))

[(un/num m) (anteo.units.impl/->symbol m)]

I think this is useful enought that anteo.units.impl/->symbol should be part of the public API.
Decoding
Say you receive the above json representation and want to construct a unit. Currently there is no good way to do this dynamically. As far as I can tell the only way to construct a meters unit is through the meters construct. So you would need to make a mapping somewhere:
{ "m" meters,
  "kg" kilograms,
  ,,,,; etc
}

I propose we create a constructor that creates a unit given an amount and its symbol. Something like:
(unit 10 "m")

would be equivalent to (meters 10) given that "m" is a registered symbol.
I propose we rename the current unit function to register-unit! and add a unit function as described above. unit doesn't currently have a two element arity so we could just add this to the existing function, but this might make the function confusing.

There are already functions for encoding/decoding in anteo.units.data-literals, named to-edn and from-edn that are used to read/write the tag-literal. I already use these to encode/decode transit in planner in anteo.utils.transit.
But your question reveals that these should probably be elevated to the main ns to highlight them being a part of the public API. And i agree that there should be a simple symbol fn in the API as well.

But the decoding won't work for JSON right?
How would you decode a value coming in at a JSON endpoint as [<amount-number>, <unit-string>]?

Aha, might be this is just an issue of naming then. As a first time user, I would expect to find this function under the core namespace with a more general name.

ahh, right. something like parse maybe?


chore(docker): Upgrade PHP to the latest active version

Version 8.1 is no more active [1].
[1] https://www.php.net/supported-versions.php

Self approve due to lack of team availability.


[SPARK-17763][SQL] JacksonParser silently parses null as 0 when the field is not nullable

What changes were proposed in this pull request?
This PR proposes handling not nullable field properly in JacksonParser. For example, the codes below:
val testJson = """{"nullInt":null}""" :: Nil
val testSchema = StructType(StructField("nullInt", IntegerType, false) :: Nil)
val data = spark.sparkContext.parallelize(testJson)
spark.read.schema(testSchema).json(data).show()

prints
Before
+-------+
|nullInt|
+-------+
|      0|
+-------+

After
org.apache.spark.sql.catalyst.json.NotAllowedNullException: Null not allowed: {"nullInt":null}
    at org.apache.spark.sql.catalyst.json.JacksonParser.failedRecord(JacksonParser.scala:131)
    at org.apache.spark.sql.catalyst.json.JacksonParser.parse(JacksonParser.scala:472)
...

How was this patch tested?
Unit test inJsonSuite.

Test build #66257 has started for PR 15329 at commit 8824186.

Test build #66257 has finished for PR 15329 at commit 8824186.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66257/
Test FAILed.

retest this please

Test build #66258 has started for PR 15329 at commit 8824186.

The tests in JDBCWriteSuite are locally passed, so I re-ran this.

Test build #66260 has started for PR 15329 at commit cb5ece7.

Test build #66258 has finished for PR 15329 at commit 8824186.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66258/
Test PASSed.

Test build #66260 has finished for PR 15329 at commit cb5ece7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66260/
Test PASSed.

Hi @yhuai and @cloud-fan , I recall changing codes here was reviewed by you both. Do you mind if I ask to review this please?

Actually, when will a user want to specify non-nullable for any json field? I am not sure if we are actually addressing the right problem. I am wondering if we should just not allow non-nullable fields for json.

@yhuai Sure, I support that idea too as I think in the same way; these would be corner cases. However, just the case I thought instantly is, to use the same schema used as it is (because inferring schema in JSON is discouraged in production). For example,
df.write.format("json").save(...)
...
spark.read.schema(df.schema).load(...)

or
anotherDF.select(from_json("a", df.schema))

In that case, I guess the original df could contain non-nullable fields.
FYI, as you might already know, it forces to the nullable schema reading/writing it from files but not for structured streaming/reading from rdd/from_json. I opened a PR for the consistency before (https://github.com/apache/spark/pull/14124).

I am willing to follow your decision if you confirm.

Yea. That's a good point. If we do not allow non-nullable fields, we should also let users easily convert nullability field. Let me also check with @marmbrus.

After re-thinking, I think this might be blocked by https://github.com/apache/spark/pull/14124 (or at least closely related). Anyhow, it looks dependent of it. Let me close this for now and try to reopen this if I can feel able to proceed this further independently.


children! and BaseWidget Methods

If i try to use Button::new().set_enabled(false) or .set_name() i get the this error:

<kiss_ui macros>:1:52: 1:62 error: the trait core::convert::From<()> is not implemented for the type > kiss_ui::BaseWidget [E0277]
<kiss_ui macros>:1 ( $ ( $ child : expr ) , + , ) => ( [ $ ( $ child . into (  ) ) , + ] ) ; (  )
^~~~~~~~~~
<kiss_ui macros>:1:1: 2:14 note: in expansion of children!

I don't know how to try it without using children!
But i think is because Button don't  implement set_enabled().

Ah yes, I realized late last night might be an issue. It's not exactly .set_enabled()'s fault, it's how it's called. See, .set_enabled() is implmented on BaseWidget and callable on the other widget types through their DerefMut<Target=BaseWidget> impls. It returns &mut BaseWidget for method chaining, but the result of each expression in children![] needs to be an owned widget type.
You can work around this by constructing the widget in a block:
children! [
    {
        let mut button = Button::new();
        button.set_enabled(false);
        button
    }
]

I've had to do that in a couple examples. It does work, but it's incredibly clunky. I have a fix in mind, but I'll need to do some refactoring.
Basically, I'd move all the methods from BaseWidget into a new Widget trait, and implement that for all widget types. Then all those setter methods can take self by-value and return Self so that you can do method-chaining like this with methods from Widget and from the actual widget type.
It's another import, but I'm thinking about creating a prelude module that users can glob-import to get some of the more common types, such as Widget and BaseWidget.

I've got the solution in #23.

Okay, should be fixed now. Give it a try.

Hey that's great! :+1:
Works perfect, thank you! :)


Fix code scanning alert - otelgrpc DoS vulnerability due to unbound cardinality metrics

Tracking issue for:

[ ] https://github.com/kubernetes-sigs/descheduler/security/code-scanning/16

/assign


Remove stray lifetime on IndexedParallelIterator::drive

Strange that this didn't have a warning, even after I fixed the allow(warnings) conditional.
Thanks!


macOS cannot connect ping self on 0.28.6

I cannot not ping self netbird ip like #1806
device: Apple M1 Max
macOS: Sonoma 14.5（23F79）
To Reproduce
install newest pkg and connect
ping self netbird ip
Expected behavior
can ping self ip
Are you using NetBird Cloud?
Yes.
NetBird version
0.28.6
NetBird status -d output:
Peers detail:
OS: darwin/arm64
Daemon version: 0.28.6
CLI version: 0.28.6
Management: Connected to https://api.netbird.io:443
Signal: Connected to https://signal.netbird.io:443
Relays:
  [stun:stun.netbird.io:5555] is Available
  [turns:turn.netbird.io:443?transport=tcp] is Available
Nameservers:
FQDN: rddemac-studio.netbird.cloud
NetBird IP: <IP_ADDRESS>/16
Interface type: Userspace
Quantum resistance: false
Routes: -
Peers count: 0/0 Connected

PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
Request timeout for icmp_seq 0

same issue here


Improve support for automatic glossaries.

Once again, credit to @fsteimke for the initial implementation.
Close #453
Close #458
This PR incorporates the work Frank did, restructured slightly to make relative URIs in db processing instructions absolute based on the base URI fo the processing instruction. Also changed the PI handling to allow either:
<?db glossary-collection="first.xml second.xml"?>

or
<?db glossary-collection="first.xml"?>
<?db glossary-collection="second.xml"?>

The function fp:pi-pi-attributes in standalone-functions.xsl has a reference to the new variable $v:pi-db-attributes-are-uris. It is undeclared when used outside of the xslTNG Stylesheet. The functions are not standalone anymore.
Maybe you can declare the variable in standalone-functions.xsl?


Refactor API regarding dats to reuse classes for multiple ParticleGroups

At the moment pointers to particle dats are stored on objects. The dats are then used in execute methods. This refactor passes the dats into execute so that the same object can be used from multiple similar ParticleGroups.

The corresponding changes in NESO are in my branch jc/maxwellwave2d3v-2, which will need to be cherry-picked into NESO before the gitsubmodule can be bumped for these changes.


[ Missing Error 404 page]

What happened?
There is currently no Error 404 Page to alert the users when they click on any wrong link or visit any wrong url.
How can we reproduce this bug?
A dedicated Error 404 page for the users to land on as and when they visit any wrong url or click on any wrong link
The users will be redirected back to the homepage

Desktop Information (Optional)
No response
Urgency (Optional)
High priority

@Kushal997-das Kindly assign me this issue so that I can start working on it

@r7projects-shayan Explain in details not clear

@r7projects-shayan As no update closing this Issue.


invalid string

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Laozhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Link to #21


NTR: Cheese related terms

Hi
I would like to submit a request of new terms. They are related to cheese.Of course I also confirmed the issue . I hope these definition and synonyms are useful against ontology developing!
Requests
label: cambozola
definition: Cambozola is a cow's milk cheese that is a combination in style of a French soft-ripened triple cream cheese and Italian Gorgonzola.
	xdbref: https://en.wikipedia.org/wiki/Cambozola
subClassOf: blue cheese
exact synonym: camembert-blue cheese
exact synonym: cambozola cheese

label: canestrato
defitniion: Canestrato is a hard cheese from the Italian regions of Basilicata, Apulia, Sicily, and Abruzzo, made from a mixture of sheep milk and goat milk.
	xdbref: https://it.wikipedia.org/wiki/Canestrato
subClassOf: sheep's milk cheese
exact synonym: canestrato cheese

label: fontina
definition: Fontina is an Italian cow's milk cheese.
	xdbref: https://en.wikipedia.org/wiki/Fontina
subClassOf: cow's milk cheese
exact synonym: fontina cheese

label: roquefort
definition: Roquefort is a sheep milk blue cheese from the south of France.
	xdbref: https://en.wikipedia.org/wiki/Roquefort
subClassOf: sheep's milk cheese or blue cheese
exact synonym: requefort cheese

label: stracchino
definition: Stracchino is a type of Italian cow’s-milk cheese, typical of Lombardy, Piedmont, Veneto, and Liguria.
	xdbref: https://en.wikipedia.org/wiki/Stracchino
subClassOf: cow's milk cheese
exact synonym: crescenza
exact synonym: stracchino cheese

I've just added a swath of new food products so I'll check to see if these are in there early next week.

Do you have an ORCID identifier, or shall I list your name as definition editor?
Damion

Ah, never mind, I see you are Shinya!

I've added these, but made the label have "cheese" in it to ensure easy disambiguation in ontology search engines.  Will be uploading shortly.


Add the dependencies of solid-ssr examples

Pull Request Test Coverage Report for Build 926551347

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.408%

Totals

Change from base Build 908006649:
0.0%

Covered Lines:
1042

Relevant Lines:
1106

💛  - Coveralls


Ui adaptations

Description

Moved some recently made CSS changes (46a32795bcbefd7475d62421a71fbdeff0e2c407 / 2020bfb6a3bf597d762e162a355ea3dfd26857eb) to their newly introduced respective SCSS files
Aligned the dashboard containers properly (see screenshots 1 and 2)
Restored the original quick view tooltip background color (see screenshots 3 and 4)
Fixed the height of the toolbar in dialog views and also stretched it in width (see screenshots 5 and 6

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots:

Unaligned dashboard containers

Aligned dashboard containers

Old quick view tooltip

New quick view tooltip

Old dialog view toolbar

New dialog view toolbar

How Has This Been Tested?
Deployed to local environment and tested functionality.

@shwstppr can you check please. thx

Verified behavior for 46a3279 and 2020bfb. Also behaviour for first 2 sets of screenshots.
LGTM!


[Feature Request] Please add support for monitoring SignificantLocationChanges

Please take a moment to fill out the following (change to preview to check or place x in []):
This is a

[ ] Bug
[x] Feature Request

Which plugin does this impact:

[ ] Battery
[ ] Connectivity
[ ] Contacts
[ ] DeviceInfo
[ ] ExternalMaps
[x] Geolocator
[ ] Media
[ ] Permissions
[ ] Settings
[ ] Text To Speech
[ ] Vibrate
Other:

Version Number of Plugin:3.0.4
Device Tested On: iPhone 6s Plus
Simulator Tested On:
Expected Behavior
Would like GeoLocator to support monitoring SignificantLocationChanges
Actual Behavior
GeoLocator does not support SignificantLocationChanges
Steps to reproduce the Behavior
Please add the ability to monitor SignificantLocationChanges in iOS.

This is already in 4.0.0-beta1, please see other open issues


How to set PrefetchCount = 0; in AzureServiceBusTransport

I can set 0  in Microsoft.ServiceBus.Messaging.QueueClient.PrefetchCount
But How can I set PrefetchCount = 0 in MassTransit ?
If I tried set 0 so I got error "[Failure] PrefetchCount must be > 0"

It should allow zero, I guess. Easy fix.
https://github.com/MassTransit/MassTransit/blob/master/src/MassTransit.AzureServiceBusTransport/Configuration/Configurators/ServiceBusReceiveEndpointSpecification.cs
Recommend reading: https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-performance-improvements

The MassTransit resets PrefetchCount for QueueClient
https://github.com/MassTransit/MassTransit/blob/master/src/MassTransit.AzureServiceBusTransport/Pipeline/PrepareQueueClientFilter.cs
and in My case
I have long running operation (more than 1 hour) with next configuration
cfg.UseRenewLock(TimeSpan.FromSeconds(30));
MaxConcurrentCalls = 1;
e.LockDuration = TimeSpan.FromMinutes(5);
and Some of the messages go to DeadLetter Query
because PrefetchCount
If I set PrefetchCount = 0 so I resolve my problem
Can you fix this "Validate" function ?

Sure

Thanks!!


Alignment issue

Decoding fails when HeaderSize % 4 != 0.
https://github.com/PreetamJinka/sflow-go/pull/10

I don't think the fixes were correct.


Update haproxy package

This PR updates the version of haproxy to 1.8.20

@cf-london Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Implement compose functions from event model into the bundlers

Closes #1573
Implements compose functions from event-model into the bluesky bundler.
To test
Change event-model to event-model@git+https://github.com/evalott100/event-model@switch_from_partials_to_classes in `requirements.txt"

Tests will fail here since the event-model release isn't up to date with main - a new release would be necessary .

Tested to work against https://github.com/evalott100/event-model/tree/switch_from_partials_to_classes, we will need to get this merged into event model before we merge this

This is a regression in mpl 3.7.2!  We should ban that version in requirments-dev.  I'll both fix this upstream and open a PR to bluesky to switch to a better way of doing the layout.

This is a regression in mpl 3.7.2! We should ban that version in requirments-dev. I'll both fix this upstream and open a PR to bluesky to switch to a better way of doing the layout.

Great, thank you! Feel free to add me as a reviewer.

@coretl Merge at will once these last two comments are resolved.


friendica - can only bookmark "starting posts" (not reply)

"error" : "Only starting posts can be bookmarked"

should disable/remove bookmark button in those cases


How to send a WhatsApp message using ContentSid and ContentVariables?

Hey
I came across this doc, which shows how to use the new Content API to send messages using ContentSid and ContentVariables. I was wondering if it is supported in the extension. If so, how do I use it?

Hi twilio team - is there any update on this feature request? This also impacts the ability to send whatsapp messages using templates. Currently there are issues in sending whatsapp messages, for eg #105

I raised a ticket via Twilio for the same thing, and was asked to check Github.
Twilio team, can you provide an update on this please?

+1


Beta 9 released April 24 does not start

X64 machine, W10. Java 1.8
See log file
Arch4 B9 start log.txt

Any other info? Do you have any other external Archi plugins installed? Have you tried re-downloading and unzipping somewhere else on your machine?

My JRE was 1.8.131
I redownloaded the beta.
I have no plug-in installed
I copied the content of the ZIP file to my Archi4 folder, EXCEPT for the JRE folder (which seemed to be 1.8.101)
The program started normally. No log file was created.
From: Phil Beauvoir<EMAIL_ADDRESS>Sent: 25 avril 2017 11:02
To: archimatetool/archi<EMAIL_ADDRESS>Cc: jnerune444<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [archimatetool/archi] Beta 9 released April 24 does not start (#225)
Any other info? Do you have any other external Archi plugins installed? Have you tried re-downloading and unzipping somewhere else on your machine?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/archimatetool/archi/issues/225#issuecomment-297059012 , or mute the thread https://github.com/notifications/unsubscribe-auth/Aarfhx_dsZPB2fiwl9XuACHks2XRJ2D6ks5rzgr3gaJpZM4NHmY0 .  https://github.com/notifications/beacon/Aarfh8RVrXAYgu05k7jxpAZfGG7Rw-4Fks5rzgr3gaJpZM4NHmY0.gif

You need to use the JRE provided in the zip file because it's 32-bit. Using your own 64-bit JRE won't work.

Is the issue resolved for you now?

The issue is resolved for me, but maybe not for you.
What made it work was using the 64-bit JRE instead of the 32-bit JRE supplied with the Beta, contrary to what you said in an earlier reply..
I also installed the beta on a 32-bit Windows 7 machine, and it works ok.
Thanks for your quick reply.

I've always found that it won't work with 64-bit Java


Decode date in $GPRMC and add a simple time variable

The $GPRMC dataset also contains the date. Until now this is not yet decoded. So please add this feature.
At the moment time information is returned in 3 variables containing hours, minutes and seconds. Including the date this will be 6 variables. This is not very comfortable if you want to pass the time information on to other functions. Maybe you could combine these functions all in one variable or structure. Maybe as integer like in the unix timestamp.

Hi @generationmake :wave:
This is not correct. The date is already decoded and stored in a structure. A function converting this to a POSIX timestamp would make sense though.

Hi @aentinger
sorry, i somehow missed that date is already decoded. But I found an issue with it:
When there is only a time fix after startup date values are all -1 although the could be decoded correctly.
At least the u-blox NEO-7M sends a date when it has a time.
Do you need sample data?

No worries. I think I know the source of the issue you've observed. Would you mind to open a new issue (Containing "Bug" in the title) including GPRMC sample data and expected parser output?
@per1234 can you replace the default GitHub labels with others which are a bit more useful? I'd need at least a "Bug Report" and a "Feature Request" label, if you know other labels that make sense then please add them too.


Fix for vsix package not finding some dependencies on activation

Used webpack to package the extension
Added additional options to TS compiler config

Questions for the devs.. Is there a licensing file i should put anywhere that includes the copyright for blackberry?

I noticed a problem when running it from development environment. Using the launch configuration Launch Extension (press F5) to start vscode with the trace viewer extension in debug mode, I get the error message below when switching to the trace viewer view. Could you please fix it with your changes? Thanks!

The error you are seeing is likely due to webpack script was not ran. I will add it under prepare script so it gets ran by default when you run yarn.

Questions for the devs.. Is there a licensing file i should put anywhere that includes the copyright for blackberry?

Any input on this?

Questions for the devs.. Is there a licensing file i should put anywhere that includes the copyright for blackberry?

Any input on this?

I would suggest the LICENSE file in the root directory of the repository. WDYT?

It looks good to me. Thanks a lot for this fix. Do you want me to merge it or do you want to update the License file in this PR first?

Let me update the license file first, and then you can merge it.

Questions for the devs.. Is there a licensing file i should put anywhere that includes the copyright for blackberry?

Any input on this?

I would suggest the LICENSE file in the root directory of the repository. WDYT?

I have update the license file. Let me know if that works for you. Thanks!


/en-US/docs/Web/API/Window/devicemotion_event

Request type

[] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details
Since iOS 12.x, both Safari and Chrome require the user to call DeviceMotionEvent.requestPermission. I would recommend that the compatability table reference this required permission.

Relevant page: https://developer.mozilla.org/en-US/docs/Web/API/Window/devicemotion_event


Getting "Undefined symbols for architecture arm64" build error when trying to package iOS project that uses async callbacks

First I'd like to say that this has been an amazing plugin, so I hope it is still somewhat monitored .
As the title says, I'm getting the following error when trying to package an iOS project:
Undefined symbols for architecture arm64:
UATHelper: Packaging (iOS):       "UMobileNativeCodeBlueprint::SpeechRecognitionCallbackIOS(NSString*)", referenced from:
UATHelper: Packaging (iOS):           -[SpeechRecorderViewController levelTimerCallback:] in SpeechRecorderViewController.mm.o
UATHelper: Packaging (iOS):     ld: symbol(s) not found for architecture arm64
UATHelper: Packaging (iOS):     clang: error: linker command failed with exit code 1 (use -v to see invocation)

As shown in the message, trying to include the iOS callback inside my .mm file causes the error. I've set up the dispatcher correctly it seems as I have no problems with the Android side. From what I can tell, I've implemented it exactly the same as is done in the sample code:

I've declared a stub in MobileNativeCodeBlueprint.h like so:

#if PLATFORM_IOS
    static void SpeechRecognitionCallbackIOS(NSString* sResult);
    #endif

I've defined the Callback method in MobileNativeCodeBlueprint.cpp like so:

#if PLATFORM_IOS
void SpeechRecognitionCallbackIOS(NSString* sResult)
{
  FString fResult = FString(sResult);
  UE_LOG(LogTemp, Warning, TEXT("asyncHelloWorld callback caught in C++! - [%s]"), *FString(fResult)); //Debug log for UE4
  UMobileNativeCodeBlueprint::SpeechResultsDispatch(fResult); // Call Dispatcher
}
#endif

I've included the #include "MobileNativeCodeBlueprint.h" statement at the top of the corresponding .mm file in order to bring the callback into scope.

Could anyone shed some light into what might be be causing the error? Or whether or not I'm missing something?

Calling a static function from .mm is no different if it were called from C++. Therefore, it is very strange that when declaring "MobileNativeCodeBlueprint.h" in the "SpeechRecorderViewController.mm" your code doesn't see UMobileNativeCodeBlueprint::SpeechRecognitionCallbackIOS. Try from the "SpeechRecorderViewController.mm" call the standard plugin function UMobileNativeCodeBlueprint::CallBackCppIOS("@"ExampleText");


Remote Playground and Browser don't working in Pharo 8

"Instance of TlpRemoteDoItReceiver" did not understand #compiler

Fixed in PR 41 of Seamless
https://github.com/pharo-ide/Seamless/pull/41


Define AOI for sample-free alternative classification approaches

Crops to Experiment
Wheat
Maize
Rapeseed
Rice
Sorghum
Soyabean
Sunflower
AOI
Group 1

Ukraine - Ternopilska, Vinnystka
France - TBD
Brazil - Goias, Mato Grosso, Mato Grosso du Sul, Goias

Group 2

Malawi - Lilongwe
Ethiopia - TBD
India - Punjab, Madhya Pradesh

Next:

Get train, test and inference data for the above regions (S1,S2,Weather,L8)
Generate simulation data in Ethiopia
Run experiments

Getting preprocessed inputs using openEO should now be relatively straightforward with: https://github.com/WorldCereal/worldcereal-classification/blob/main/scripts/extractions/patch_extractions/extract.py


Readme.txt

Bug
I had to set the ACCESS_COARSE_LOCATION & ACCESS_FINE_LOCATION in the Droid project file. It is not automatically added as described here:
IMPORTANT
Android:
The ACCESS_COARSE_LOCATION & ACCESS_FINE_LOCATION permissions are required, but the library will automatically add this for you.
Additionally, if your users are running Marshmallow the Plugin will automatically prompt them for runtime permissions.

It is added please check manifest it is in the assembly info.


chat streams need link extraction for uri transformation

When a chat handler runs remotely (wsl, ssh) and streams links they won't be transformed. We need something similar to this - which extracts uris so that they travel as types and get rewritten accordingly
https://github.com/microsoft/vscode/blob/1a85a0881e19b4238f9bc01e3268b32c0c1264d1/src/vs/workbench/api/common/extHostTypeConverters.ts#L356

Hi @jrieken
I would like to contribute to this bug.

@Jaimin020 Thanks for the offer but this issue isn't a good one. You can use the help wanted label to find better issues

Actually not needed as linkification does this


Add more troubleshooting steps

document the jumper cable colors
document how to install build tools
document how to troubleshoot missing i2c permissions

Thank you very much for your contribution to the documentation.

I love what you guys do: https://twitter.com/frightanic/status/1364710456754110469
It appears my changes got lost after you merged them as @MBjoern merged other stuff around the same time.

yes sorry about that. Since we use a internal tool to generate and test the driver we setup a mirroring from our internal git server. We will backport your contribution so it doesn't get overwritten again

Ah, that's what it is, makes sense now. I was really puzzled when I didn't even see my 2nd PR on master.


Migrate to Junit5 + AssertK

Native Kotlin supports and more powerful assertions. See https://github.com/willowtreeapps/assertk.
https://docs.gradle.org/8.9/userguide/performance.html#execute_tests_in_parallel

May merge #65 first.

Can be AssertK due to now we don't test any coroutines logic)

You want https://github.com/cashapp/turbine.

Verified, tests are reported at https://scans.gradle.com/s/yz46z7wp4eyzy/tests/overview.

turbine can be added if necessary in future 🙂


add headers to sidebar cards

as a developer, I need to add headers to the sidebar cards so that the content is more clear to users of the site

Tasks

[ ] add success story header
[ ] add event card header

Definition of Done

[ ] the success story and event cards in the sidebar both have clear headers

@n-devr we are now calling 'Success Stories' as 'Adoption Stories'. Change header language accordingly.

jeremy is able to complete


Breakpoints can't be set/unset if icon shown in gutter

When an icon is shown in the gutter margin, I can't click to set/unset a breakpoint. I can use F9 though.
I've noticed this in other extensions too, so it's probably some issue in vscode.
Is there a way to fix this?

Right click the gutter icon, then you can set breakpoint.


Only node costs are present in the metrics endpoint

Is this by design? I was expecting to get all the cost metrics from the /metrics endpoint.

We started with just total_node_cost, cpu_cost, and and ram_cost as the initial set of metrics available to Prometheus. We're absolutely open to expanding this set. Are there specific metrics you would want to see?

Nothing specific, all of them ;)

By the way,  these node costs, are they relative to the node running the cost-model pod or is it an aggregate of all nodes?

And we must get all of the metrics! :) How about are there any metrics that are more valuable than others to you? As context, we have been actively debating if we should write the entire model (w/ pod resource calculations included) or just resource cost data to the /metrics endpoint.

Node costs in the open source product are based on the price of the current node. Most teams we have worked with use deployments so isn't common for the same pod to have run on multiple nodes. That being said, the data being written to /metrics allows you to track pods across different nodes over time. I think we should have this default available in this project. Let me know what you think.

Actually, I'd be happy with just higher level metrics for the metrics endpoint. Things like node costs, cluster cost and workload cost. And maybe a namespace break down.

That's helpful. It sounds like there is a lot more we can expose here. We can start investigating the best way to do this with flexibility.
Are there specific queries or analysis that you want to complete with these metrics? I just want to make sure that as we start exposing more information it will support what you want to do.

Yes, I'd be interested mostly in cost per namespace and per service. And there are some labels that we assign to namespaces that I'd like to use to aggregate costs.

The higher level metrics I've mentioned before would be useful for capacity planning, with node cost, workload cost and total cluster cost we could make adjustments to the instance types and cluster seizes.

Got it! We've started discussing the right approach. Is it fair to say that this feature would be nice to have before #28 ? It might even be a prerequisite based on what you've shared.
Let me know if you want to be involved in design and/or implementation! :)

Also, is it ok if we rename this issue to something like "Add more data to /metrics endpoint"

Sure. Regarding the priority in relation to #28, it's totally up to you.
Thanks for being so helpful

I gave this some thought over the weekend, and I believe we can give Luis a lot of what he wants with two additional metrics. My initial proposal is below. This would allow relatively simple Prometheus queries to calculate total node costs, namespace cost, workload cost, etc. I vote we look at getting these added quickly and then see what other metrics/labels we can provide.
RAM Allocation Metric
container_memory_allocation_bytes {container,pod,namespace,node}
CPU Allocation Metric
This feels trickier. I really worry about using a rate() metric because of losing time window flexibility, but maybe we could do this with timeWindow == scrapeInterval. Alternatively, I think should just increment a seconds_total counter that a rate() can be applied to.

Sounds good.  I've been thinking, and started experimenting. What if we had a prometeus exporter that gets the data from the cost model api?

@luisdavim the /metrics endpoint with the new data that @dwbrown2 proposed would act as a Prometheus Exporter with the cost model data. You would just need to give Prometheus the scrape configs for this. We could provide an example on how to do this if it would be helpful. Does that help or is there something else you would be looking for?

That helps. What I was talking about was decoupling these into separate components. But if generating the extra metrics for prometeus comes without extra cost it probably makes sense to keep them together.

#38 starts adding cost allocation data to the metrics.

I've also created a first version of documentation for these new metrics:
https://github.com/kubecost/cost-model/blob/master/PROMETHEUS.md

Let us know if there are other immediate needs that you have here.
The only potential addition that I might propose at this point would be creating some type of container_cpu_cost and container_memory_cost metrics, which would be the product of allocation and price metrics as they stand today.

yes, that would be useful.

Cool, let's let these initial metrics soak while I give this some thought. We could potentially just provide a container_total_houly_cost instead of individual ram and cpu metrics, depending on target use cases.

Naming feels tricky here. Other options are container_cost_hourly and container_cost_irate_hourly.
Specifically this would be the hourly run rate based on the recently measured allocation and price.

Let's go ahead and add node_gpu_hourly_cost as well now that teams are using this information.

We've added all the basic metrics from the kubecost model. Any other requests?
If there are no immediate needs, then I would propose we close this in favor of specific requests/issues going forward.


Milestone 0.0.5

Coverage remained the same at 100.0% when pulling 2b983b58284d971242fb263e7b6c4e011ecfaba1 on milestone-0.0.5 into 710195c7ebf038631fdc4bfbe9fc709755e42fe8 on master.


cam_scale_factor parameter

Hello, I tried to search and looked in the code, but I am kind of lost. What exactly is the cam_scale_factor? Thank you for your answer!

Hi, did you figure out what this parameter is?

Hi, not really, but I didn't play around with it.

Got it. BTW, have you met the "floaters" problem when trying your custom_data ?

Yes, I still have floaters, but the results are pretty good for my purpose. Especially when I played around with the parameters: lambda_tv, lambda_tv_sh, and background_brightness.

Thanks! I will try your suggestions.

In most NeRFs, you need to make sure your region of interest is in a "controlled region" of space. You cannot really predict where colmap will put your poses. Therefore, most algorithms (1) recenter the poses (e.g. they compute the average of all poses and assume this the center, or, for non-centered captures they compute some form of "look-at" point) and (2) rescale all the poses to a certain radius. The cam_rescale factor refers to that. It's mentioned in section 3.6 of the paper: "we pre-scale the inner scene to be approximately contained in the unit sphere".

Hm, depends what kind of blurry problem. Can you share an example?

In most NeRFs, you need to make sure your region of interest is in a "controlled region" of space. You cannot really predict where colmap will put your poses. Therefore, most algorithms (1) recenter the poses (e.g. they compute the average of all poses and assume this the center, or, for non-centered captures they compute some form of "look-at" point) and (2) rescale all the poses to a certain radius. The cam_rescale factor refers to that. It's mentioned in section 3.6 of the paper: "we pre-scale the inner scene to be approximately contained in the unit sphere".

Cool!
I got another followup question, why should we set the "cam_scale_factor" ? In this implementation, it's set to be 0.9 or 0.95, after computing the average of all poses, there is already a scale, using the default nvsf dataset format. If we set this "cam_scale_factor" to 1.0, it seems nothing special, is that right ?

I haven't checked the code in detail, but I assume they just make the poses "a tiny bit" smaller than the unit sphere, to be safe. I don't think it's a big deal. What might be important is to take this number into account if you have any "scale-dependent" components in your pipeline. Like, if you are wanting to make a physically accurate object, or something like that.

From your video, it would seem your problem could be related to inaccurate poses. Have you tried to put some nice features on the table (stickers, QRcodes, newspapers?)

From your video, it would seem your problem could be related to inaccurate poses. Have you tried to put some nice features on the table (stickers, QRcodes, newspapers?)

I also think this might be because of the inaccurate poses. I tried to switch poses for 2 similar datasets and got similar rendering results.
But in this regard, is there any advice on how to change the Colmap parameters in case this happens, but I can't change/retake my photos? Or how to change the parameters for Colmap in case it detects fewer photos than I have in the dataset?

From your video, it would seem your problem could be related to inaccurate poses. Have you tried to put some nice features on the table (stickers, QRcodes, newspapers?)

No, I haven't tried the manual feature patterns during taking photos.
I double checked the features extracted by colmap and visualize, the object in the video has few feature points on its smooth and white surface. Inaccurate poses seems to be the reason.
As @povolann mentioned, how can I get a more accurate camera pose using Colmap without retaking my photos?

I haven't checked the code in detail, but I assume they just make the poses "a tiny bit" smaller than the unit sphere, to be safe. I don't think it's a big deal. What might be important is to take this number into account if you have any "scale-dependent" components in your pipeline. Like, if you are wanting to make a physically accurate object, or something like that.

I see. I got another question, can we adjust the "control region" in this repo like others with "aabb scale"? I am checking the code in detail and want to adjust the "control region"(SparseGrid in this repo) to a smaller region so that it may focus more on the foreground. But the SparseGrid seems to be normalized already(center[0,0,0], radius[1,1,1]), that's a [-1, 1] bounding box, covering the whole scene.

From your video, it would seem your problem could be related to inaccurate poses. Have you tried to put some nice features on the table (stickers, QRcodes, newspapers?)

No, I haven't tried the manual feature patterns during taking photos. I double checked the features extracted by colmap and visualize, the object in the video has few feature points on its smooth and white surface. Inaccurate poses seems to be the reason. As @povolann mentioned, how can I get a more accurate camera pose using Colmap without retaking my photos?

Only thing I can think of is:

Trying to evaluate why your poses are bad: are your pictures blurry? Are they downsampled? If so, maybe try some AI-based upsampling/deblurring algorithm, but it's kind of a long shot.
Using commercial software to compute the poses (e.g. RealityCapture, etc...)

But anyway, your results will probably be bound to the garbage-in -> garbage-out motto if your original images don't have enough quality. Otherwise, depending on what's your purpose, you may want to try another algorithm (NerFactor, INGP, NerfStudio)
I don't have enough experience with this code to answer your AABB question. What you say sounds reasonable, have you also tried increasing the grid resolution?

From your video, it would seem your problem could be related to inaccurate poses. Have you tried to put some nice features on the table (stickers, QRcodes, newspapers?)

No, I haven't tried the manual feature patterns during taking photos. I double checked the features extracted by colmap and visualize, the object in the video has few feature points on its smooth and white surface. Inaccurate poses seems to be the reason. As @povolann mentioned, how can I get a more accurate camera pose using Colmap without retaking my photos?

Only thing I can think of is:

Trying to evaluate why your poses are bad: are your pictures blurry? Are they downsampled? If so, maybe try some AI-based upsampling/deblurring algorithm, but it's kind of a long shot.
Using commercial software to compute the poses (e.g. RealityCapture, etc...)

But anyway, your results will probably be bound to the garbage-in -> garbage-out motto if your original images don't have enough quality. Otherwise, depending on what's your purpose, you may want to try another algorithm (NerFactor, INGP, NerfStudio)
I don't have enough experience with this code to answer your AABB question. What you say sounds reasonable, have you also tried increasing the grid resolution?

Thanks for your quick reply. Pose should be evaluated and checked if accurate enough using some other methods. Let me think it later.
I tried increasing the grid resolution, but in my opinion, the grid resolution means the bounding box covering the whole scene, [128, 128, 128] or [256, 256, 256] just means to divide the whole scene into 128 cubic or 256 cubic small grid. It doesn't have relationship between the "control region" (the center object).
As say, the center object may occupy just small proportion grids, when the whole scene consists 128 cubic(more than 1 million) grids, the object may occupy 10k grids or so. It seems there doesn't exist a way to visualize the voxel occupied situation like octree. I wonder whether I get the correct understanding or not.

@Learningm @povolann sorry to bother you. I also encountered lots of floaters when training on my custom data. I tried the parameters you mentioned above, they help, but still not very good. So I wonder besides the lambda_tv parameters, have you tried lambda_beta and lambda_sparsity? Cause they seem more related to floaters, as they are directly pushing sigma to either 0 or 1.

@Learningm @povolann sorry to bother you. I also encountered lots of floaters when training on my custom data. I tried the parameters you mentioned above, they help, but still not very good. So I wonder besides the lambda_tv parameters, have you tried lambda_beta and lambda_sparsity? Cause they seem more related to floaters, as they are directly pushing sigma to either 0 or 1.

I have tried lambda_beta and lambda_sparsity, since the default parameters are already small, I guess they should be bigger and make effect on the foreground & background part, however,  10x or 100x the default parameter always get worse results.

@Learningm Thanks for your reply! Interesting, I also feel that 1e-5, 1e-11 are too small, so maybe I should increase them. But it seems that in your experiments increasing them didn't lead to better results? That's confusing hummm

@Wuziyi616 I got blurry edge problem as the video posted above and it seems hard to solve through tuning parameters. Did you get some good results without the blurry problem on your data?

I'm training on CO3D which has good camera poses. So my results of object surface is all good, just some floaters
https://user-images.githubusercontent.com/37072215/201841878-1aac4ead-527c-4cbe-9663-0764b3782faa.mp4

@Wuziyi616 Your result looks good. I tried using the same data in CO3D and cannot get a good one. Did you use the 'co3d.json' and increase the lambda_tv, lambda_tv_sh, and background_brightness？
Your rendering path seems a little different  to the default ones in 'render_img_circle'? Did you make some modification?

@Wuziyi616 Cool! Thanks for sharing.

Yeah sorry I have not maintained this codebase very much at all. This parameter simply directly scales the overall scene. While our background model allows for modelling unbounded scene, it still matters which portion of the scene is in the scene

A better camera normalization scheme can help, like in instant-ngp. This is implemented in util/util.py
Our COLMAP should be ran with --noradial
Also note custom.json can have too big near clip and custom_alt.json can do better, but adjusting this near clip to something in the middle may be ideal
Adding distortion loss from mip-nerf 360 and switching to exp activations are other improvements possible


[Bug]: Fix the car dontent

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The source and author move up and down as the length of the quote in such cases quotes can either be shown in the center and fix the author, source to bottom of the card.
@JayShukla8 can you assign this issue to me with labels "gssoc-ext" with level 2 and "hacktoberfest-accepted";
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

Thanks but this issue does not need fixing.


weex platform list 报错Cannot find module ，weexpack-platform.js

执行如下命令
 weex platform list

报下面的错误
weex Error: Cannot find module '~/.xtoolkit/node_modules/weexpack/bin/weexpack-platform.js'

环境：
$    weex -v
   v1.3.8
 - weexpack : v1.2.3
 - weex-builder : v0.4.0
 - weex-previewer : v1.5.1

@shixinzi Maybe you have not installed weexpack completely, try weex remove weexpack and then try weex platform list again.


Automated cherry pick of #6421: fix: 优化标签列表过滤参数

Cherry pick of #6421 on release/3.2.
#6421: fix: 优化标签列表过滤参数

Codecov Report

Merging #6422 into release/3.2 will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release/3.2    #6422      +/-   ##
===============================================
- Coverage         7.05%    7.04%   -0.02%
===============================================
  Files              649      649
  Lines           111327   111383      +56
===============================================
- Hits              7856     7845      -11
- Misses          102862   102930      +68
+ Partials           609      608       -1

Flag
Coverage Δ

#aFlag
7.04% <0.00%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/baremetal/manager.go
0.50% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/tasks/baseprepare.go
0.00% <0.00%> (ø)

pkg/baremetal/tasks/bm_register.go
0.00% <0.00%> (ø)

pkg/cloudcommon/policy/policy.go
1.50% <0.00%> (-0.06%)
:arrow_down:

pkg/compute/models/dbinstanceresource.go
0.00% <0.00%> (ø)

pkg/compute/models/guest_actions.go
0.00% <0.00%> (ø)

pkg/compute/models/guests.go
0.56% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/hosts.go
0.30% <0.00%> (-0.01%)
:arrow_down:

pkg/hostman/hostinfo/hostinfo.go
0.00% <0.00%> (ø)

pkg/multicloud/esxi/devtools.go
0.00% <0.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb56db7...168a4c7. Read the comment docs.


Debugger lacks option to return

In Pharo 11 build 726, when inspecting #(1.5 nil 2.5) collect: [ :n | n rounded ], the MessageNotUnderstood can be returned from using ‘Return’ in the debugger (see screenshot below) giving it for example nil as the return expression so that the inspected result is #(2 nil 3). The Glamorous Toolkit debugger in v1.0.977 seems to lack a similar option (unless I’m just overlooking it).

Thanks. Would you like to try to add a custom action for this specific to DNU in the debugger?

I’m not sure it should be a custom action, it would seem better to have the option to return from any context. Using the same example, for the following screenshot, I’ve selected the context below the top one, pressed ‘Return’ and am giving { aBlock value: self first. aBlock value: self third } as the expression so that the inspected result will be #(2 3).


Make the image to not require root user to run

Hi,
at some points, included assets performs yum installs which requires container to run with USER 0.
Would it be possible to make the image run without requiring root?


Auto-detect code blocks around the cursor location. Shift-enter executes the entire block

Shift-enter moves to the next line after executing the current line
Auto-detect code blocks around the cursor location. Shift-enter executes the entire block

Just to say. This might be an improvement and we should totally consider it. But right now we had shift-enter match what the python extension does when sending code to the terminal. So if we have shift-enter move and advance we won't match the main python extension any more. Though maybe we can consider having both advance on shift-enter.

Do #1 for sure. Enter a new issue for #2 if we don't find an easy solution.

No. 2 is on the top of my list of things that would improve VS-py for me, cf. #480 ( #480#issuecomment-479140136 )

So if we have shift-enter move and advance we won't match the main python extension any more. Though maybe we can consider having both advance on shift-enter.

@IanMatthewHuff You would match Jupyter Notebook/Lab behaviour though if Shift-Enter advanced after execution and Ctrl-Enter executed in place.

@aldanor Thanks for the heads up on Ctrl-Enter. I'll look into that, at a minimum I could maybe just add a new Execution in place command and leave it unbound so that users could add it to the keybinding of their choice.

@IanMatthewHuff That would be great, yea - at the very least to be able to remap it to user's liking without having to create macros manually.

This PR for the PyCharm editor shows a video of the sort of features that No. 2 could provide (automatically sending whole class and function definitions): https://github.com/JetBrains/intellij-community/pull/711
It would be nice if the following blocks were supported:

'Colon/indent' blocks (class, def, for, if etc.), if the cursor is on the line with the colon
Long lines split with \
Multi-line bracketed blocks, as is common when using pandas, e.g.:

(pd.DataFrame({'a':[1,1,2,2], 'b':[1,2,3,4]})
 .groupby('a')
 .agg(sum))

I agree that this is closely related to #13495. Would make a lot of sense to implement them together.


Environment variables are not set when using docker-compose V2

Today I'm trying to setup Magento 2 with Warden on a Mac, with latest Docker desktop installed. Got these messages when starting env services:

It took me few hours to figure out the problem is latest Docker desktop is shipped with Compose V2 RC enabled by default:

I downgraded docker-compose to version 1.25.0 and it works well.

This is the setting to downgrade Compose in Docker Desktop.

Amazing, I also solved the same problem when I downgraded docker-compose to version 1.29.2 .

Just had the same issue on a Mac (just downloaded Docker fresh). Disabling that experimental feature worked.

This issue isn’t reproducing anymore. More info https://github.com/davidalger/warden/pull/437#issuecomment-1002186894
I think we can close it


Docs: refine the connect and bind quick starts

Refine the following YAML files for delivery as quick starts in OpenShift:

Connecting OpenShift to Streams for Apache Kafka using the CLI
Binding a Quarkus application to Streams for Apache Kafka using the CLI

@secondsun This PR wasn't really ready to be merged. There was at least one SME review still open (from @DuncanDoyle). Beyond that, we would have also done a peer review and a QE verification.
I'm not sure if using the Draft status is common practice in this repo, but I'll use that next time to be more explicit.
@DuncanDoyle Please leave any comments here, as you normally would have. I'll apply any required updates via a fresh PR and use that for peer review and QE verification.

Ahhh ok. Sorry about that. We usually mark PR's as works in progress or not ready for merging (see https://github.com/redhat-developer/app-services-operator/pull/220 for an example)

Ahhh ok. Sorry about that. We usually mark PR's as works in progress or not ready for merging (see #220 for an example). I've restored the branch and rolled back the PR feel free to continue working.

Thanks, @secondsun. I'll use the [WIP] convention for future PRs.


O(1) mass revocation by deferring to garbage collection?

Suppose that we didn't actually clear the proxy's target and handler when calling RevocationController.prototype.revoke().
Instead, we could make proxies's slots subject to garbage collection if their internal reference to the [[RevocationController]] keeps a boolean .revoked property, and that property is true.
We'd modify each of the traps in section 10.5 to check for the revoked property, and to throw a TypeError just as if the proxies were dead (because we'd require that they were), and to actively clear the [[ProxyHandler]] and [[ProxyTarget]] slots at that moment.
The revoke() call simply sets that flag to true, and we're done.
To summarize:

Each proxy gets a slot for a RevocationController?.revoked property.  Proxies not revocable by a controller have this slot pointing to a constant static false value.  Proxies revocable by a controller have this as a reference to a boolean (boolean & revoked in C++ parlance).
When the controller's .revoke() method is invoked (which directly owns the boolean), it sets that boolean to true.
When executing a trap for a controller-revoked proxy, if the revoked reference is true, then (before calling into the handler but after verifying the handler isn't null):
a. Clear the [[ProxyHandler]]and[[ProxyTarget]]` slots.
b. Throw the TypeError for that trap.
Any proxy with the revoked reference set to true is eligible for garbage collection (or its slots are, if we have to operate that way).  Alternatively, if the garbage collector's iterating over objects in memory, it can call a public method to null those references when it does its first walk.

I admit fully I don't understand exactly how garbage collection works in JavaScript engines.  But it's cheap to store a boolean, and cheap to store references.
Thoughts?

Note: this issue and original comment predate the replacement of RevocationController with a signaling API.


:bug: add support for standalone virtualworkspace server

Summary
This is another change decoupled from the shard-standalone-vw branch from @ncdc
Related issue(s)
Follow up to ##2297 and #2303 which also merged changes from the WIP branch
Fixes #2254
Fixes #2056

Some of the e2e tests are failing hence marking this as WIP until resolved, any help with that or initial review feedback is welcome :)

Thanks for the review feedback @ncdc - I pushed an update which fixes most (but not yet all) of the e2e failures, will leave this as WIP until all tests are green and the review feedback is addressed :+1:

@ncdc quick update on this as I'm still struggling somewhat to get the e2e tests all working in standalone-vw mode
AFAICS some tests (for example TestRootWorkspaces/a_user_sees_his_own_workspaces_at_the_root,_but_no_other_workspaces are failing because they hit the ForeverTestTimeout of 30s.
Locally testing (with sharded-test-server configured with --shard-run-virtual-workspaces=false) e.g
GOOS=linux GOARCH=amd64 go test -v -failfast -parallel=1 -count=1 ./test/e2e/virtual/workspaces/... -run TestRootWorkspaces/a_user_sees_his_own_workspaces_at_the_root,_but_no_other_workspaces -args --use-default-kcp-server --root-shard-kubeconfig=$PWD/.kcp-0/admin.kubeconfig

We see that the test sometimes passes, and if I increase the test timeout it can pass reliably - in some test runs locally I'm seeing a delay of around 50 seconds waiting for the user1-workspace to appear (this is on baremetal so not resource constrained, although I do see high CPU usage).
In the shard logs we can see the proxied requests, and there are some bootstrapping authz errors which I'm thinking may be related?
I1213 17:56:41.503077 2707520 handler.go:138] "proxying virtual workspace request" inURL="/services/workspaces/root/apis/tenancy.kcp.dev/v1beta1/workspaces" outURL="https://<IP_ADDRESS>:7444/services/workspaces/root/apis/tenancy.kcp.dev/v1beta1/workspaces"
I1213 17:56:41.506245 2707520 httplog.go:131] "HTTP" verb="POST" URI="/clusters/root/apis/authorization.k8s.io/v1/subjectaccessreviews" latency="1.454168ms" userAgent="virtual-workspaces/v0.0.0 (linux/amd64) kubernetes/$Format/workspaces-virtual-workspace" audit-ID="5cd9b73b-6526-4798-ae35-3d85c4231534" srcIP="[::1]:35636" resp=201
I1213 17:56:41.507868 2707520 decorator.go:75] "bootstrap policy reason: "
I1213 17:56:41.507930 2707520 decorator.go:75] "local policy for cluster \"root\" reason: "
I1213 17:56:41.507940 2707520 decorator.go:75] "delegated bootstrap.authorization.kcp.dev authorizer reason: access denied\ndelegated local.authorization.kcp.dev authorizer reason: access denied"
I1213 17:56:41.507947 2707520 decorator.go:75] "delegated maxpermissionpolicy.authorization.kcp.dev authorizer reason: access denied"
I1213 17:56:41.507952 2707520 decorator.go:75] "delegated systemcrd.authorization.kcp.dev authorizer reason: access denied"
I1213 17:56:41.507958 2707520 decorator.go:75] "delegated content.authorization.kcp.dev authorizer reason: access denied"

If you have any suggestions where to look next that would be welcome, currently I'm not very sure why there is such a long delay in the workspace creation.

@hardys this particular test will go away as part of the workspace refactoring. Do you have a list of all the tests you're having problems with, and we can see if any of them still need addressing?

@hardys this particular test will go away as part of the workspace refactoring. Do you have a list of all the tests you're having problems with, and we can see if any of them still need addressing?

@ncdc I've mostly been testing e2e-sharded-minimal locally so I don't yet have an exhaustive list, but I'm seeing TestInProcessWorkspacesVirtualWorkspaces/In-process_virtual_workspace_apiserver/create_a_sub-workspace_and_verify_that_only_users_with_right_permissions_can_access_workspaces_inside_it also fail (similar to above, sometimes it passes)
I'm interested to understand why the long delay though, with the in-process VW the workspace list succeeds pretty much immediately, any idea why is it taking nearly a minute in standalone VW mode?

Not offhand. Maybe something to do with the workspace authz cache (which will be going away as part of the workspace refactor)

Not offhand. Maybe something to do with the workspace authz cache (which will be going away as part of the workspace refactor)

Ack thanks, sounds like I should probably pause work on this and rebase after the workspace refactor lands :)

@hardys let me know if you need help after the rebase, from the logs it looks like the requesting user for the SAR passes all authorizers but the local and bootstrap policy one. Unfortanly kubernetes RBAC does not give any reason in case of denials, so the local and bootstrap policy authorizer return empty string.

/test e2e-sharded
Looks like #2501 caused the failure on the last run so retrying

@ncdc this is rebased, passing CI (finally! \o/) and ready for another review pass when you have time, thanks!

/hold
The test-e2e failure looks like a real problem with TestStandaloneWorkspacesVirtualWorkspaces/Standalone_virtual_workspace_apiserver - investigating

/hold

Turns out I lost a bunch of the new changes in test/e2e/virtual/clusterworkspaces/virtual_workspace_test.go due to a rebase mistake, now re-added those, but TestStandaloneWorkspacesVirtualWorkspaces/Standalone_virtual_workspace_apiserver is not passing for me locally so leaving the hold until I figure that out

@hardys let me know if you need help after the rebase, from the logs it looks like the requesting user for the SAR passes all authorizers but the local and bootstrap policy one for the root workspace. Unfortunately kubernetes RBAC does not give any reason in case of denials, so the local and bootstrap policy authorizer return empty string.

@s-urbaniak now rebased, and if you do have time to take another look, help would be welcome :)
AFAICS the standalone VW server is getting denied access to KCP e.g:
I0109 12:03:25.762947 3555316 httplog.go:131] "HTTP" verb="LIST" URI="/services/initializingworkspaces/system:apibindings/clusters/%2A/apis/core.kcp.io/v1alpha1/logicalclusters?limit=500&resourceVersion=0" latency="2.906727ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kcp-apibinder-initializer" audit-ID="bde34168-5d78-4c6c-b82d-636834d6bb04" srcIP="[::1]:36338" resp=403
I0109 12:03:33.696294 3555316 impersonation.go:119] "Forbidden" URI="/services/initializingworkspaces/system:apibindings/clusters/%2A/apis/core.kcp.io/v1alpha1/logicalclusters?limit=500&resourceVersion=0" Reason="access denied" Error=<nil>

Seems authz related, but I've not yet figured out exactly what is causing the requests to be denied, as you say <nil> isn't the most informative, and I don't see many clues in the logs atm...

/hold cancel
@ncdc @stevekuznetsov this is ready for another review when you get some time, thanks!


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_9d9xecprd8/clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in host
ERROR: /tmp/abs_9d9xecprd8/clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_9d9xecprd8/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_9d9xecprd8/clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: /tmp/abs_9d9xecprd8/clone/recipe/meta.yaml:17: uses_setup_py: python setup.py install is deprecated.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7db5t3g45m/clone/recipe/meta.yaml:1: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_7db5t3g45m/clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_7db5t3g45m/clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in host
ERROR: /tmp/abs_7db5t3g45m/clone/recipe/meta.yaml:1: missing_python_build_tool: Python packages require a python build tool such as setuptools.
ERROR: /tmp/abs_7db5t3g45m/clone/recipe/meta.yaml:17: uses_setup_py: python setup.py install is deprecated.
Errors were found


Ignoring titleEdgeInsets on UIButton

If I add titleEdgeInsets to UIButton whole width of a button stays the same as it would without inset and titleLabelText just doesn't display properly

Thanks


This variant of Arm Compiler is licensed only for use with Mbed Studio

I just got this error after a half hour of installations and messing with environmental variables trying to get ARM6 to work with mbed cli.
Building project mbed-os-program (NUCLEO_F103RB, ARMC6)
Scan: mbed-os-program
Compile [  0.1%]: mbed_tz_context.c
Compile [  0.2%]: except.S
[Error] @0,0: A9940E: This variant of Arm Compiler is licensed only for use with Mbed Studio
[ERROR] Error: A9940E: This variant of Arm Compiler is licensed only for use with Mbed Studio
Product: ARM Compiler 6.11 for Mbed Studio
Component: ARM Compiler 6.11
Tool: armasm [5d3b3500]

If Mbed Studio's arm compiler is indeed not licensed for mbed-cli use, maybe there shouldn't be a huge section in the CLI installation docs talking about how to set it up?:
https://os.mbed.com/docs/mbed-os/v5.12/tools/after-installation-configuring-mbed-cli.html

Hi @hierophect, sorry to hear about your installation troubles, perhaps I can help. From the output it looks like you've definitely completed step 2 from the link you posted (otherwise you wouldn't be getting that error). Can you answer the following questions for me?

What OS are you using?

If you are using Windows, are you using the normal command shell (cmd.exe) or are you using something else? Examples include Git Bash, Windows Subsytem for Linux, cygwin, etc

How did you set the environment variable ARMLMD_LICENSE_FILE? You should be able to run the following command from the terminal you're using to run Mbed CLI and see the value you set:

On Mac: echo $ARMLMD_LICENSE_FILE
On Windows (using cmd.exe): echo %ARMLMD_LICENSE_FILE%

I'm on windows via git bash.
I'm using the following file, as specified in the setup instructions. I set it in windows advanced settings. I can verify it's part of my environment via the usual non-mbed commands.
C:\Users<my username>\AppData\Local\Mbed Studio\mbed-studio-tools\ac6-license.dat

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-1185

@hierophect what version of Mbed OS are you using? I'm realizing that docs page could be more clear that using Mbed Studio's version of ARMC6 is only supported in 5.12.0 and later.
If you are using 5.12.0, could you post the verbose output? mbed compile -v.

I've been able to reproduce the issue, thanks for the details. After doing a bisect it looks like this PR broke it: https://github.com/ARMmbed/mbed-os/pull/10182.
I have a fix up here: https://github.com/ARMmbed/mbed-os/pull/10539

The reported issue has been recreated and fix has been provided, closing.

Has this changed in the recent versions of mbed-cli and Mbed Studio? I am currently using the latest stable release of mbed-cli 1.10.4 and Mbed Studio 1.0.0 for mbed-os 6.0.
How do I direct mbed to use the ARMC6 compiler that comes preinstalled with Mbed Studio?
The docs regarding this seem to have changed from v5.12 to v6.0.


[release/1.1] Cherrypick "Set gid 0 when no group is specified" and docs update

Cherrypick commits from #2529 and #2535 for the 1.1.x branch

Codecov Report

Merging #2556 into release/1.1 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           release/1.1    #2556   +/-   ##
============================================
  Coverage        50.11%   50.11%
============================================
  Files               75       75
  Lines             7297     7297
============================================
  Hits              3657     3657
  Misses            2965     2965
  Partials           675      675

Flag
Coverage Δ

#linux
50.11% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

oci/spec_opts_unix.go
21.77% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5627389...4d629f3. Read the comment docs.

LGTM

I'll draft the release note after this get merged.

LGTM


Update rpcdump.cpp

Fix: Changed bitcoin to dingocoin

Good find

There are probably more we should keep an eye open. That one is harsh for newbies


Extending structures (bonds, atom charges, etc)

OPTIMADE specification v1.0.1 defines a structure as a set of sites, occupied by mixtures of atoms, with each atom described by its chemical type, mass and occupancy (proportion in the mixture). Means for expressing disorder are also in place, defined quite similarly to CIF standard.
I wonder whether there would be an interest to add more chemical attributes to OPTIMADE structures such as:

chemical connectivity (bonds)
charge
lone pairs
continuous electron density
...

Some of these attributes can be derived algorithmically (connectivity, lone pairs), but derivation algorithms are often based on heuristics and sometimes fail to arrive at "correct" result. Thus if these details are available at provider's side, it would be nice to have them communicated in OPTIMADE attributes.

I think charges would be a useful property to add.
Some atomistic simulations use the charge of an atom to calculate the interatomic potentials.
In rare cases, the atomistic charges may also be the only way to distinguish chemical structures from one another. (e.g. Ions in cages can be stabilized in unusual oxidation states.)
Some formats like PDB also allow you to specify the connections between the atoms. I (ab)used this feature in the past for visualizing some of my course grained data, so I think this could be a useful feature as well.
A little over a year ago, I talked with some persons from materials cloud about which properties they would like to see standardized.
These properties are mostly the results of calculations on the structures.
The mentioned properties like:

magnetic moments,
spin configuration,
band structure (metallic, insulator, semiconductor)
conductivity
phonon spectra
the Fermi energy

For some of these, I do not really know what they are, so I can't really tell how useful these would be.
They also mentioned space groups but these have already been added in PR#405.
Some other properties that I thought could be useful(mostly for use within trajectories, but some are also useful for structures too) to add are:

Field
Description

Temperature_set
The temperature to which the thermostat was set.

Temperature_measured
The measured temperature.

Velocities
The velocities of the atoms/particles

Forces
The force that is exerted on a particle

B factors
Also known as Debye–Waller factor.

Constraint Force
The Force required to maintain a reaction coordinate.

Time
In case of a trajectory the time belonging to a particular frame

Remarks
A field where some extra information can be given for this spefic entry that does not fit in any of the other fields

Various Energies
we could have fields for the components of the energy such as kinetic energy, potential energy, total energy and electronic kinetic energy.

Enthalpy of formation
The enthalpy of formation for the compound in the structure

I am mostly interested in chemical connectivity. However, I would expect the definition of chemical bond and its types to be quite involving. Could we adopt some already existing convention? CML, for instance, defines integer-numbered bond types for orders 1 to 3 (no 4), aromatic, unknown and other. To this list I would add order 4 and zero-order bonds. Anything else?
I saw @eimrek's addition to OPTIMADE paper manuscript about a database of covalent organic networks, thus it would be interesting to hear their opinion. Also pinging @BobHanson and @vaitkus for comments.

I agree. V3000 allows for dative and coordinate bonds. Whether you call
these "zero order" or not, is up to you.
[
https://depth-first.com/articles/2021/11/17/ten-reasons-to-adopt-the-v3000-molfile-format/
]
But bonding in general adds significant complexity to a model. Beware!

I agree with Antanas. My thought on aromaticity is that -- particularly
with associated 3D structures, as we in this case -- standard Kekulé
bonding is preferable. Aromaticity is not needed, since the 3D structure is
there, and planarity, bond distances, aromaticity, and such can be easily
derived from that.
This also relates to SMILES (clearly also a bonding model). We should be
recommending non-aromatic SMILES. Explicit double bonds. That preference
comes primarily from the fact that generally these SMILES will be targets
-- that is, SMILES that actually represent structures. For searching
structures, one may want an aromatic bonding model for the search
*pattern *(Cc1ccccc1),
but for a target one always needs the Kekulé bonding. Because Cc1ccccc1
will match CC1=CC=CC=C1, but CC1=CC=CC=C1 will not (is not supposed to)
match Cc1ccccc1.  From
https://www.daylight.com/dayhtml/doc/theory/theory.smarts.html:
*SMILES is interpreted as a molecule, and it is the resultant molecule (not
the SMILES string) which is subject to searching. Similarly, SMARTS is
interpreted as a pattern; it is this pattern (not the SMARTS string) which
is matched against molecules. For instance, the SMILES "C1=CC=CC=C1"
(cyclohexatriene) is interpreted as the benzene molecule. This molecule
will be matched by the SMARTS c1ccccc1, which is interpreted as the pattern
"6 aromatic carbons in a ring". The SMARTS "C1=CC=CC=C1" makes a pattern
("six aliphatic carbons in a ring with alternating single and double
bonds") which will not match benzene. *
My point is not about SMILES, though. It's about bonding. I like this
statement, that SMILES doesn't need any aromatic description to represent
benzene. Same goes for what we are talking about using V3000 or whatever
format.
Bob
Personally, I think they made a fundamental mistake in SMILES to allow
aromatic descriptions there. Really they are much more useful and relevant
in SMARTS, and because of this asymmetry of matching, are just a pain in
SMILES.
Bob
On Mon, Feb 13, 2023 at 7:08 AM Antanas Vaitkus @.***>
wrote:

I think it might be quite difficult to agree on a single bonding model
that covers every situation so we could start with something simple and
then extend it in the future as needed. Some general thoughts on the model:

It would be nice to be able to specify the bonding without
explicitly assigning the bond type/order (e.g. only provide the
connectivity graph). I guess this could be achieved by using the CML
unknown bond type or something similar.
Maybe aromaticity should be a separate property of a bond rather
than a bond type? This might be used to convey that certain bonds are
aromatic, but described using the Kekulé notation. Furthermore, the
OpenChemLib https://github.com/Actelion/openchemlib library actually
differentiates between aromatic bonds that can resonate (e.g. in benzene)
and the ones that have a more or less fixed bond order (e.g. in thiophene).
Thus it is quite reasonable under some circumstances to define a bond as
both being aromatic and having a specific bond order.

—
Reply to this email directly, view it on GitHub
https://github.com/Materials-Consortia/OPTIMADE/issues/426#issuecomment-1427913885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHNCW6PNWLQBRTFGKTE5JDWXIW4FANCNFSM6AAAAAARHXTWUA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
We stand on the homelands of the Wahpekute Band of the Dakota Nation. We
honor with gratitude the people who have stewarded the land throughout the
generations and their ongoing contributions to this region. We acknowledge
the ongoing injustices that we have committed against the Dakota Nation,
and we wish to interrupt this legacy, beginning with acts of healing and
honest storytelling about this place.

hi all.
@merkys, our covalent organic framework databases don't contain bond orders and currently no intention to add it, as far as I'm aware. @ltalirz @yakutovicha correct me if i'm wrong.
Regarding atomic charges: there are multiple methods to calculate them: e.g. mulliken, hirshfeld, bader, ESP-derived, ...(https://mattermodeling.stackexchange.com/questions/1439/what-are-the-types-of-charge-analysis). Would this be something that the database provider just decides on which charges they provide? Still, it would be good to have information about method of calculation.
Regarding bond orders, there's a similar argument: there are multiple ways to calculate bond orders that can give different results. Additionally, one thing to keep in mind is how to represent non-kekule molecules, e.g. triangulene, and unpaired electrons and radical sites in general.

Thanks all for interesting responses. I agree that choosing the right representation for bond type/order will require a lot of thought. Thus I find @vaitkus's suggestion really appealing:

It would be nice to be able to specify the bonding without explicitly assigning the bond type/order (e.g. only provide the connectivity graph). I guess this could be achieved by using the CML unknown bond type or something similar.

Separating aromaticity from bond type/order is also a good suggestion.
How about starting from this:
"bonds": [ { "sites": [ 1, 2 ] } ]

sites would be the single REQUIRED property giving a list of sites participating in a bond. As @JPBergsma noted, sites list could contain more than two sites.
JSON object describing a single bond could then later be expanded by introducing properties giving type/order, aromaticity and so on.

I believe @eimrek's suggestion about specifying calculation methods should be promoted to more general level as other properties could benefit from such metadata as well.

I would prefer a more succinct format. Why duplicate "site" a zillion
times? Maybe just array of arrays.
Suggest array of
[index1, index2, type]
Where type is reserved for future use and could be 0 for placeholder.
Mostly just reacting to needless byte bloat
On Fri, Feb 17, 2023, 6:51 AM Andrius Merkys @.***>
wrote:

Thanks all for interesting responses. I agree that choosing the right
representation for bond type/order will require a lot of thought. Thus I
find @vaitkus https://github.com/vaitkus's suggestion really appealing:

It would be nice to be able to specify the bonding without
explicitly assigning the bond type/order (e.g. only provide the
connectivity graph). I guess this could be achieved by using the CML
unknown bond type or something similar.

Separating aromaticity from bond type/order is also a good suggestion.
How about starting from this:
"bonds": [ { "sites": [ 1, 2 ] } ]

sites would be the single REQUIRED property giving a list of sites
participating in a bond. As @JPBergsma https://github.com/JPBergsma
noted, sites list could contain more than two sites.
JSON object describing a single bond could then later be expanded by
introducing properties giving type/order, aromaticity and so on.

I believe @eimrek https://github.com/eimrek's suggestion about
specifying calculation methods should be promoted to more general level as
other properties could benefit from such metadata as well.
—
Reply to this email directly, view it on GitHub
https://github.com/Materials-Consortia/OPTIMADE/issues/426#issuecomment-1434603619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHNCW3FMVLNFVBZP2AJEO3WX5X6ZANCNFSM6AAAAAARHXTWUA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I would prefer a more succinct format. Why duplicate "site" a zillion times? Maybe just array of arrays.

I understand the pros of a more succinct representation, but I tried to retain consistency with the other OPTIMADE properties which use explicit keys. Moreover, suggested plain list representation would not allow for bonds of more than two atoms. Placeholder value of 0 might be perceived as zero order bond by some. It is better to avoid placeholders at all, if no "type" (or something like it) property is given in a bond object, nothing else but some sort of connectivity should be assumed.

It might be nice if this design could also capture generic "connectivity", and serve e.g., list of sites within some cutoff of another site in PBCs. Having pre-computed neighbour lists can really help accelerate some applications and could allow for some kind of local environment/oxidation state searching expressed via correlated list queries (though this might require species data to be added to each bond, maybe not favourable), e.g., "give me all structures that contain SiO4 tetrahedra"
It would then be up to the database to decide this "calculation method" still, e.g., what distance cutoff to use (constant, sum of ionic/vdw radii etc)

Yes, sorry, I was on my phone and, ah, still in bed... Meant to follow that
with:
"That said, the more use of associative arrays, the more easily extended
this will be."
Q: What else do we have that references sites like this?
On Fri, Feb 17, 2023 at 8:17 AM Andrius Merkys @.***>
wrote:

I would prefer a more succinct format. Why duplicate "site" a zillion
times? Maybe just array of arrays.
I understand the pros of a more succinct representation, but I tried to
retain consistency with the other OPTIMADE properties which use explicit
keys. Moreover, suggested plain list representation would not allow for
bonds of more than two atoms. Placeholder value of 0 might be perceived as
zero order bond by some. It is better to avoid placeholders at all, if no
"type" (or something like it) property is given in a bond object, nothing
else but some sort of connectivity should be assumed.
—
Reply to this email directly, view it on GitHub
https://github.com/Materials-Consortia/OPTIMADE/issues/426#issuecomment-1434712127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHNCWZL7EME6D5CLZLATWTWX6CATANCNFSM6AAAAAARHXTWUA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Robert M. Hanson
Professor of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr
If nature does not answer first what we want,
it is better to take what answer we get.
-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900
We stand on the homelands of the Wahpekute Band of the Dakota Nation. We
honor with gratitude the people who have stewarded the land throughout the
generations and their ongoing contributions to this region. We acknowledge
the ongoing injustices that we have committed against the Dakota Nation,
and we wish to interrupt this legacy, beginning with acts of healing and
honest storytelling about this place.

@BobHanson

Yes, sorry, I was on my phone and, ah, still in bed... Meant to follow that with: "That said, the more use of associative arrays, the more easily extended this will be." Q: What else do we have that references sites like this?

OPTIMADE has assemblies to describe disorder, and that uses similar level of verbosity.

This might be slightly off-topic, but how does one get atom bonding out of QM calculations? Can existence of bonds/their types be objectively detected via QM, or would one need some heuristic (i.e., distance-based criterion) to derive them? Pinging @gmrigna.

This might be slightly off-topic, but how does one get atom bonding out of QM calculations? Can existence of bonds/their types be objectively detected via QM, or would one need some heuristic (i.e., distance-based criterion) to derive them? Pinging @gmrigna.

Here's a small overview of QM bond order methods: https://mattermodeling.stackexchange.com/questions/901/what-are-the-types-of-bond-orders/1508
Most of these (or at least the popular ones, Wiberg, Mayer and Laplacian, which I also have some experience with) are fully determined based on the electronic structure (so, the density/density matrix/occupied molecular orbitals/or derived orbitals) and the atom-atom distance is not "explicitly" used.

A suggestion for a queryable property: distance between Voronoi neighbours.


Fix abort handling of tileload events

Tile loading events, like used in the tile-load-events.html example, get out of sync between loading and loaded when tiles are aborted, e.g. because of a small and full tile cache.
By keeping track of which tiles are being loaded, and also dispatching a tileloadend event for aborted tiles, this issue can be fixed.

Thanks for the review. I updated the test description to make it clearer what it tests.


Angular5.2.0, StaticInjectorError(AppModule)[HttpHandler -> Injector]

Hi qjon, I'm having trouble to make it past the dependencies. I've imported all necessary packages in my target module where I'm printing the File Manager:
repository.module.ts
import {FileManagerModule, IFileManagerConfiguration} from '@rign/angular2-filemanager';
import {TranslateModule, TranslateService} from 'ng2-translate';
import {EffectsModule} from '@ngrx/effects';
import {StoreModule} from '@ngrx/store';
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
import {TreeModule} from '@rign/angular2-tree';
import {ConfirmationPopoverModule} from 'angular-confirmation-popover';
...
const fileManagerConfiguration: IFileManagerConfiguration = {
    urls: {
      foldersUrl: '/api/folder',
      filesUrl: '/api/files',
      folderMoveUrl: '/api/folder/move'
    },
    isMultiSelection: true,
    mimeTypes: ['image/jpg', 'image/jpeg', 'image/png'],
    maxFileSize: 50 * 1024,
    allowChooseMultipleFiles: true
}
...
@NgModule({
    imports: [
        BrowserAnimationsModule,
        ConfirmationPopoverModule.forRoot(),
        StoreModule.forRoot({}),
        EffectsModule.forRoot([]),
        FileManagerModule.forRoot(fileManagerConfiguration),
        TreeModule.forRoot(),
        TranslateModule.forRoot(),
    ],
...

repository.component.ts
import {FileManagerConfiguration, FileManagerDispatcherService} from '@rign/angular2-filemanager';

@Component({
	selector: 'jhi-repository',
	templateUrl: './repository.component.html'
})
export class RepositoryComponent implements OnInit, OnDestroy {

constructor (
        public fileManagerConfiguration: FileManagerConfiguration,
        private fileManagerDispatcher: FileManagerDispatcherService
	) {

	}
public toggleMultiSelection() {
    this.fileManagerConfiguration.isMultiSelection = !this.fileManagerConfiguration.isMultiSelection;

    if (!this.fileManagerConfiguration.isMultiSelection) {
      this.fileManagerDispatcher.unSelectAllFiles();
    }
}

When I remove all FileManager... references from repository.component.ts and both lines FileManagerModule.forRoot(fileManagerConfiguration) and TreeModule.forRoot() from repository.module.ts @NgModule imports the webapp does start with the other dependencies, otherwise I'm getting this error:
app.main.ts?3881:13 Error: StaticInjectorError(EReportAppModule)[HttpHandler -> Injector]:
  StaticInjectorError(Platform: core)[HttpHandler -> Injector]:
    NullInjectorError: No provider for Injector!

I had to install the http library in @angular/http apart from the standard in @angular/common/http for it to work as ng2-translate needs to import the Http model and module from that location.
Right now I'm completely blocked, I'd really could use a tip.

It looks like you don't import HttpClientModuleor use HTTP over HttpClient which is recomended. Please look at the demo folder, there are two examples with BE and without.
If that not help give me more info I will try to help you.

Hello qjon, we couldn't make it work on our app, we had to implement ng2-tree our own way. Thanks for the quick response though, adn sorry for my belated.


IllegalArgumentException: indicators wasn't setup yet.

I get the following error whenever I try to use this library:
IllegalArgumentException: indicators wasn't setup yet. Make sure the indicators are initialized and setup correctly before trying to compute the click area for each step!

It looks like compute() calls computeStepsClickAreas(), which depends on a valid array of indicators; however, the indicators array isn't initialized until after the call to computeStepsClickAreas().
Or am I using the library incorrectly? This is against v1.0.4

It looks like this may be fixed in the master branch. Any plans to cut a new version soon?

I'll release a new version tomorrow, until then you should be able to use it with the latest commit hash
compile 'com.github.badoualy:stepper-indicator:3675b4dd8e'

Sounds good, thanks :-)


fix: loss information from

close #69

Thanks Tolking, definitely a missed line when we were refactoring another issue. I will accept this "as is" since you did put in the snapshot artifact. I will add a full test self describing test for this in my next PR I push so that we start to have a full description of features in the tests.

Having looked at my latest code, I'm concerned that there might be other problems hiding out in this functionality. I have built a number of tests on a feature branch so we'll have really comprehensive testing soon but what I haven't yet done is isolate this change to the current 12.x branch so i think it might be worth just waiting from my PR to hit (which includes the comprehensive tests and fixes). That said, if there is lots of urgency @tolking I can do the isolated testing and assuming there's no downsides then we can get this out sooner.

Sitting on the beach on an iPad so don't have proper connectivity but once I'm back in front of my laptop I may share my current testing strategy which -- if either of you @tolking @antfu have time -- would love your validation that the logic I'm testing is sound.

Since VueJS 2.x only has <script> blocks things are much more focused on the VueJS 3.x scenarios but if you think there's more needed on 2.x let me know too


Mattocto/2023 post calibration

Trying to incorporate the feedback from @gian-lorenzetto and @cstrzadala, I've added more details about the "shapedness" of the work L3s and L4s are taking to production.
L3

Responsibility and direction needed: Takes vertical slices of larger products from idea to production.

I confidently and autonomously lead the shipping of well-shaped ideas from conception to production.

L4

Responsibility and direction needed: Consistently takes brand new ideas from inception to production with limited supervision.

I take pitch documents describing a complex problem space and help turn them into well-shaped work for myself or others to deliver.


Something wrong when add another target

I add a target first,then i when i add another target,there is something wrong.It seems when i add another target ,the form don't refresh and the key had been there.The same problem seems been when i add last target and open the target before i added,i start to run the agent ,the agent scan the last tartget i added but not the target i select

And the code
reconness   |   Exception data:
reconness   |     Severity: ERROR
reconness   |     SqlState: 23505
reconness   |     MessageText: duplicate key value violates unique constraint "PK_Targets"
reconness   |     Detail: Key ("Id")=(bdea8f4b-2217-4483-a935-7ee25e480c76) already exists.
reconness   |     SchemaName: public
reconness   |     TableName: Targets
reconness   |     ConstraintName: PK_Targets
reconness   |     File: nbtinsert.c
reconness   |     Line: 570
reconness   |     Routine: _bt_check_unique
reconness   |    --- End of inner exception stack trace ---
reconness   |    at ReconNess.Data.Npgsql.ReconNessContext.CommitAsync(CancellationToken cancellationToken) in /app/DAL/ReconNess.Data.Npgsql/ReconNessContext.cs:line 235
reconness   |    at ReconNess.Service1.AddAsync(TEntity entity, CancellationToken cancellationToken) in /app/ReconNess/Service.cs:line 153 reconness   |    at ReconNess.Web.Controllers.TargetsController.Post(TargetDto targetDto, CancellationToken cancellationToken) in /app/ReconNess.Web/Controllers/TargetsController.cs:line 76 reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfIActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments) reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask1 actionResultValueTask)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
reconness   | --- End of stack trace from previous location where exception was thrown ---
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|24_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
reconness   | --- End of stack trace from previous location where exception was thrown ---
reconness   |    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
reconness   |    at Microsoft.AspNetCore.Routing.EndpointMiddleware.g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
reconness   |    at Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
reconness   |    at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
reconness   |    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
reconness   |    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

Thx @xxnbyy. Trying to replicate these issues.

I can nort reproduce this issue I'm going to close this ticket


Official Debian package

Hello,
I noticed that just is available in official repositories for Debian Sid (unstable) and Trixie (current testing). It might be worth updating a readme about it:

https://packages.debian.org/trixie/just
https://packages.debian.org/sid/just

Sweet! Finally Rust in Debian :)
Hmm, interesting. It looks like rust packages get a rust:PACKAGE project on Repology. I added the rust:just package table to the readme in #2032.
Eventually the install instructions should be updated to include Debian, but I'd like to wait un that until they're available in stable.


v12 PF2E Integration

I was wondering if anyone was planning on integrating for the PF2E system, as the https://github.com/reyzor1991/pf2edragruler project is not planning on moving forward into v12.

The PF2e System has a build in drag Ruler, as i found out today :D Go into the module settings, then on the PF2E system and on the bottom you can enable the build in Dragruler

I created a PF2e drag ruler integration for v12, if you're interested: https://github.com/Valerionn/foundry-dragruler-pf2e
Since I created it today, I couldn't test it that thoroughly yet and haven't written a README yet - but you can already install it by using https://raw.githubusercontent.com/Valerionn/foundry-dragruler-pf2e/main/module.json as Manifest URL. I'll probably extend it a bit and publish it to Foundry when it's more complete and I have time for this, but currently the following features are supported:

Currently only the default speed is taken into consideration (no fly/swim/burrow/climb speed)
You can configure the colors for each action, like in pf2edragruler
When a token has the "Quickened" condition, a 4th action is shown as well
When a token has the "Slowed" or "Stunned" condition, the shown actions are reduced accordingly
When a token has the "Prone" condition and at least 10ft speed, then the crawl speed is shown (5ft per action)
When a token is immobilized/unconscious/petrified/paralyzed, then no movement is possible

Compared to the PF2e built-in ruler that @Roger92 mentioned, you can see how far you can move per action (like with pf2edragruler)


Create contributing docs

Almost done.

Done.

Found the github action for 'take'

Found the github action for 'take'

Oh nice, that's pretty straight forward; maybe we just implement that in this PR?

I think it is pretty straightforward, but I would like to take a careful look at our CI as part of implementing this. I opened an issue for it. I would like to merge this PR since it represents a lot of changes.


question is possible to use transaction

hi is is possible to use transaction and two-phase transaction ?

@publicocean0 WriteBatch gives you the ability to commit multiple operations atomically. You're on your own for isolation.
Chrome implements IndexedDB transactions as a wrapper around WriteBatch. You might find the code around this file helpful: https://cs.chromium.org/chromium/src/content/browser/indexed_db/leveldb/leveldb_transaction.h