README: use legit markdown + tweaks

Remove HTML markup
Decrease size of headers
Rename some headers
Add License
other misc. tweaks

Preview: https://github.com/luzpaz/AnimationFreeCAD/blob/README/README.md

obviously these are suggestions, feel free to pick and choose what you'd like to keep.
Question:

[ ] Have you tested on MacOS?
[ ] Have you tested on FreeCAD v0.20dev (which will be released soon since we're in a feature freeze ATM)
[ ] Why did you choose Apache license?

obviously these are suggestions, feel free to pick and choose what you'd like to keep.
Question:
* [ ]  Have you tested on MacOS?

* [ ]  Have you tested on FreeCAD v0.20dev (which will be released soon since we're in a feature freeze ATM)

* [ ]  Why did you choose Apache license?

Unfortunately we were not able to test it on Mac OS as none of us have one.
This version has not been tested on FreeCAD version 0.20.
We have chosen the same license as using the PyFlow Framework because we are comfortable with these rights.

We are very close to releasing FreeCAD v0.20 stable. So it would be great if this workbench would be compatible (as best as possible) with it when we do. Theoretically, we could add this workbench to the FreeCAD addon manager under experimental. If we do, would you be open to testing v0.20 and fixing bugs from users higher probability we could find some macos testers as well)

Yes, we will be very proud to offer our module in experimental.
Where can we download the dev version of FreeCAD 0.20.
Will FreeCAD be able to update its modules automatically in this version?

@SHaiZen25
https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds
snap edge/nightly: https://github.com/ppd/freecad-ppd
The Addon Manager is a lot more intelligent in v0.20. It may be able to install all the dependencies you need (but we need to make sure those 3rd party packages are available via pip and are added to https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/AddonManager/ALLOWED_PYTHON_PACKAGES.txt
Best place to start a conversation is in the forum.freecad.org


ComplianceBot Grant-CsTeamsComplianceRecordingPolicy not working ( probably )

Describe the issue
I am trying to follow the documentation as described in the ComplianceBot. The Grant-CsTeamsComplianceRecordingPolicy step goes thru without any errors, but I don't think the policy actually gets associated with the user. See powershell commands below.
PS > Get-CsTeamsComplianceRecordingPolicy
Identity                        : Global
ComplianceRecordingApplications : {}
Enabled                         : False
WarnUserOnRemoval               : True
Description                     :
Identity                        : Tag:TESTPOLICY
ComplianceRecordingApplications : {Id=37553c7e-831e-4087-968f-79ea3eabed9c;RequiredBeforeMeetingJoin=True;RequiredBeforeCallEstablishment=True;RequiredDuringMeeting=True;RequiredDuringCall=True;ConcurrentInvitationCount=1}
Enabled                         : True
WarnUserOnRemoval               : True
Description                     : Test policy created by Prashant
PS > Grant-CsTeamsComplianceRecordingPolicy -Identity<EMAIL_ADDRESS>-PolicyName TESTPOLICY -Tenant cd2c5a75-c821-42a8-8c41-775b48d8d206
PS > Get-CsOnlineUser<EMAIL_ADDRESS>| ft sipaddress, tenantid, TeamsComplianceRecordingPolicy
SipAddress                 TenantId                             TeamsComplianceRecordingPolicy

<EMAIL_ADDRESS>cd2c5a75-c821-42a8-8c41-775b48d8d206
Please let me know if I missed something.

Overnight this issue got resolved somehow. Now, the policy is associated with the user:
Get-CsOnlineUser<EMAIL_ADDRESS>| ft sipaddress, tenantid, TeamsComplianceRecordingPolicy
SipAddress                 TenantId                             TeamsComplianceRecordingPolicy

<EMAIL_ADDRESS>cd2c5a75-c821-42a8-8c41-775b48d8d206 TESTPOLICY
When I start a call as this user, I get a message that the recording has started. About 60 seconds later, I get another message that the recording has ended. Is there a way to increase the length of the recording? Also where is the recording stored?

It normally takes 30-60 seconds for the policy to be applied.  Please let me know if you find it takes much longer than this.

Helllo, it took significantly longer than that. More like several days. As you can see the logs I posted, yesterday the policy was not associated with the user. This morning it somehow got associated with the user.
Can you kindly please answer the other two questions?

When I start a call as this user, I get a message that the recording has started. About 60 seconds later, I get another message that the recording has ended. Is there a way to increase the length of the recording? Also where is the recording stored?

The bot has logic to publish the recording states.  It does not actually do any recording.
https://github.com/microsoftgraph/microsoft-graph-comms-samples/blob/06b6ef2849a03123ea5177bd02d1eb4a83ec56ba/Samples/BetaSamples/LocalMediaSamples/ComplianceRecordingBot/FrontEnd/Bot/CallHandler.cs#L136-L138


[TwigComponent] fix typo in compoundVariants documentation

Q
A

Bug fix?
yes

New feature?
no

Issues
-

License
MIT

I think there is a typo in the documentation in the compoundVariants part, and it made me confused a little. The example in the doc was throwing An exception has been thrown during the rendering of a template ("Warning: foreach() argument must be of type array|object, string given").

Thanks Morgan!


Git Commit History (Udacity lesson)

Udacity workshop  "Git Commit History"

Using diff to Find Bugs: The diff checks out and compares two files and mark with "-" all symbols that was removed from document and with "+" mark - all symbols that was added.
Reflect: Using History for Efficiency: The checking of changes history helps us to find all changes more efficiently and to return to some version if it needs.
Reflect: Manual Commits: I prefer to do manually commit than automatical because automatical commits run everytime at the same time (for example, a minute, an hour etc.). But if I have done nothing for this time? Or if I have done a lot of changes for others parts of code? So it's not very good purpose to use automatical commits, I think. It's might be used but not always and not anywhere. But at other hand, we must always to watch to your code structure. You must commit the changes for alone structure of your code. Remember, the change of one part of code - one commit.
Reflect: Multi-File Commits: Git allows the group commit because all files in this group can belonges to one part of code. I mean, for example, one webpage (index.html, index.css, behaviour.js). So they need to commit changes together.
Reflect: Using Git to View History: git log views information about all repositories commits. There are commit ID, author of commit, date of commit and commits message. We can to use diff command to view the difference between two commits.
Reflect: Confidence from Version Control: The using of control version makes me more confident to make changes because I'm not afraid to break the program. If it's happened I'm able to checkout out to previous commit without error code.
Reflect: How Do You Want to Use Git? I'll try to view commit's log of asteroid's repository and try to checkout to some commit's ID and to watch what will happen.


Prevent user from deleting last full access key from their account

Problem
User by mistake or from misunderstanding might try to remove the full access key that they are accessing this account with.
Similar true about their recovery key.
Expected Behavior
Prevent or have a "danger" message with confirmation for deleting full access key and especially the one that is currently active in the wallet and recovery key.

@kcole16 @ilblackdragon @Patrick1904  let's have the "type your account name" guard (similar to how dangerous transactions are confirmed) for removing the key owned by current wallet.

I think we should remove the "Full Access Key" section entirely once recovery management and multi-device support are live.
If users want to remove a device key (only in localStorage), they should have to do it from a different device. Alternatively, we could allow them to delete the current device key, but only by creating a new key first.

Agree with @kcole16
@vgrichina what you suggesting we should add to "delete account" functionality: enter beneficiary and then confirm that you know what you are doing (that all of your assets won't actually end up there, unless you transfer them manually first for exmaple). Not sure we should expose this any time soon though.

Closed by #486

User is now prevented from deleting their last full access key on their current device. This will be optimized in #422


How to get the no glyph placeholder rasterize drawable?

like this:

Some fonts have a outline for their FontId(0) unsupported glyphs I think, but most of the ones I use will just render nothing. Maybe other programs render their own placeholder outline based on the glyph position & dimensions?

I get it. Thank you.
I try font.glyph_id('\0'), it is effective in some fonts.


New release please

I've started using this in pydantic :tada:, can we get a new release please so I haven't done too much with v0.2 before the next release.

https://github.com/annotated-types/annotated-types/releases/tag/untagged-ad3c56e367b52ea46aa4
Remind me: we just publish the tag on GitHub and CI will release on PyPi right?

I think we need to change
https://github.com/annotated-types/annotated-types/blob/7351d1bf7c1ea1a9828f92356aea7b0096c50601/annotated_types/__init__.py#L44
Then just create a release.

Done!

Thanks so much.


chore(deps): update terraform terraform-ibm-modules/cos/ibm to v8.1.8

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
patch
8.1.7 -> 8.1.8

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.1.8
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#589) (833d803)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 7.18.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Automate integration tests

Description
Add dynamically changed sources based on job's context
Related issue(s)
https://github.com/kyma-project/serverless/issues/417

/retest


Add test enhancements

Test for single characters (not strings) as package
designators
Bind package to various standard packages in introspection
test

Beep boop

Merged. Thanks a million!


[Docs] Default not displayed when set by internal subcomponent.

For example, DatePicker mode defaults to portrait, but this is set by Calendar (I think...), so the default isn't shown in the properties table.

@mbrookes : The documentatin has been updated now. I can see mode being mentioned in the Datepicker component itself.
Can this be closed?

I don't believe this has been systematically reviewed for all components, so I would suggest to leave it open.

I would close that issue for #3172


SerializerGenerator throws exception when IsRecursive = true and target primitive types

New feature of ver 0.6.0 SerializerCodeGenerationConfiguration.IsRecursive is good.
But if target type contains primitive types, throws serialization exception.
var settings = new SerializerCodeGenerationConfiguration
{
    IsRecursive = true,
};
var code = SerializerGenerator.GenerateCode(settings, typeof(int));

System.Runtime.Serialization.SerializationException: Cannot serialize type 'System.Int32' because it does not have any serializable fields nor properties.

My expected result is do nothing.

Thank you for suggestion. It is bug of recursive target selection.

Fixed in 0.6.1.


fix: typos and grammatical errors

Changes proposed
This PR fixes typos and grammatical errors in home page and header.
Github -> GitHub
Linkedin -> LinkedIn
Theme dark -> Dark Theme
Theme light -> Light Them

@Jay-Karia could you please attach the issue in the PR description?

Adding resolvedTheme?.charAt(0) ... might work.


targeted member list refresh, fixes #31

Changes
Changes to address #31
Add ability for targeted member list refresh via context menu on source file.
Also, update create, delete, copy, updateText, rename functionality on members to use targeted refresh.
Checklist

[x] have tested my change
[x] updated relevant documentation
[x] Remove any/all console.logs I added
[x] eslint is not complaining
[x] have added myself to the contributors' list in the README

Note: I think I still kind of suck at git branch workflows. So I was trying to get a workflow of
upstream/master -> origin/master -> origin/feature/fixes -> upstream/feature/fixes going.
Should I be doing something different in the future? I figured I shouldn't do a PR straight to master.
I can close this PR and resituate my commits if need be (with a little guidance)

This is an awesome feature fix. The issue is that, yes, you branched off an old branch.
It might be a bad idea for me to merge a branch that has 63 new commits in it. For some reason, git has includes those thinking they're all new commits.
In the future, you should only PR off of master and not another branch (unless I have explicitly mentioned it somewhere).
Would it be possible, whenever you can, to resubmit your PR based off of master?

@worksofliam Yeah definitely a good idea. No problem, that works for me


If no package is uninstalled the cmdlet should emit an error

Summary of the new feature / enhancement
If no package is uninstalled during a run of Uninstall-PSResource the cmdlet should emit a warning so that the user knows no action was completed. The warning can suggest users run Get-PSResource.
Alternatively this message could only be included in runs with -Verbose parameter
Proposed technical implementation details (optional)
No response

Uninstall * should return nothing
Uninstall  should return an error

Not sure when this got resolved, but I believe we currently have the appropriate behavior.
PS C:\> Uninstall-PSResource notamodule
Uninstall-PSResource: Did not successfully uninstall package

I'll update the message here to actually reference the package name and version

@alerickson, when you're updating the error message it should say it failed because it does not exist. The current message just saying it failed for no reason is bad.
If you need an example, use Remove-Item as that error message is explicit to the user.


Update stable version in repo from 3.2.2 to 3.2.4

Think about update stable version to 3.2.4
Version: stable=3.2.2 (43 days old) => latest=3.2.4 (30 days old)
Installs: stable=1015 (46.14%), latest=211 (9.59%), total=2200
Click to edit

This issue seems to be outdated
This issue suggests to update the stable version of this adapter to 3.2.4 but in meantime an updateto version 3.4.0 is sugested.
So this issue will be closed and repleaced by an updates one.


Add magics that work with GRR

Add magics that work with GRR

waiting for the GRR colab package to be released via pypi


[Feature Request]: Support for Laravel 11.x

Feature Description
I know Laravel 11.x is not out yet, but we can install it already.
I don't see any issues, so i will submit a PR to allow version 11.x for illuminate/support
Is this feature valuable for other users as well and why?
No response

See #83

v3.0.4 adds support for Laravel 11.x and php 8.3. I would've merged your PR, however I looked at the PR from shift first, which did the same thing.


Should this work for Base64 encoded Webp?

No matter what I've tried, I always get the missing image icon on Safari for Mac and iOS. It works fine if I link to a file. Is there some way to leverage this awesome module for use with Base64 images as it currently exists, or is some PR required?

@chase-moskal - I'm working on this issue, but when bundling I'm getting this error:
 browserify dist-cjs/webp-hero.bundle.js -p tinyify -o dist-cjs/webp-hero.bundle.js
SyntaxError: 'import' and 'export' may appear only with 'sourceType: module' (1:333541) while parsing C:\projects\myProject\packages\shared\webp-hero\libwebp\dist\webp.js while parsing file: C:\projects\myProject\packages\shared\webp-hero\libwebp\dist\webp.js

This seems to be the solution, but I don't want to depart wildly from what you've already setup so I can submit a PR without including a rebuild of the compiler workflow.

hello @Slapbox,
first, let's look at the base64 situation:

does webp-hero currently work to polyfill base64 encoded images?

not yet

what does webp-hero currently support for polyfilling?

old fashioned image elements, such as <img src="pic.jpg" alt=""/>
nothing else

what is not yet supported by webp-hero, but would desirable enhancements?

base64 encoded data-uri's (both for img elements, and also css images)
css images (background-image, in document stylesheets, and inline-styles)

how can we enhance webp-hero to support base64 images?

in source/webp-machine.ts, we'd want to enhance the polyfillImage method
how it currently works

this method takes in an <img> element, loads the webp binary data with an http request for the src uri, and decodes that binary data into a base64 png data uri which is set as the <img> element's new src
so the image's src is actually overridden with the decoded png as a base64 data uri

what changes are needed

the change would be to inspect the src and check if it's a webp base64 data uri, and if so, convert the base64 data into binary data (an arraybuffer) that can be fed into the decode method
so, if the image src is a base64 webp, we'd decode the base64 and pass that to decode, instead of loading the binary data from an http request as is currently done

next, let's look at the bundling issue
first, the bundle command
browserify dist-cjs/webp-hero.bundle.js -p tinyify -o dist-cjs/webp-hero.bundle.js
is giving you this error
SyntaxError: 'import' and 'export' may appear only with 'sourceType: module' (1:333541) while parsing C:\projects\myProject\packages\shared\webp-hero\libwebp\dist\webp.js while parsing file: C:\projects\myProject\packages\shared\webp-hero\libwebp\dist\webp.js
that's odd, because the bundle command doesn't make any reference to any files that would contain an import or export statement, so that's interesting, since the error is about import/export syntax
now, let me be clear -- during development of webp-hero, you should not run the bundle command on it's own -- especially because it actually overwrites the "bundle source" in-place.. it's a little weird that way
when developing webp-hero, after you make any changes, you should simply run npm install everytime to run a full build
are you getting this error when using npm install in the webp-hero project?
your error indicates it's somehow looking in webp-hero\libwebp\dist\webp.js, and that shouldn't be the case --  i can't find a part of the webp-hero build routine that should be touching that file which the error indicates
for your purposes, you don't need to touch anything within the libwebp directory -- that entire directory is dedicated to rebuilding the google libwebp sourcecode -- you're looking to modify the way webp-hero grapples with the HTML page, which you'll find in the source area
hopefully we can figure this out together, and it would be great if you could provide a PR which enables the polyfilling of base64 encoded images!
to open source, cheers! :beers:

fyi, i just pushed a commit on master, just updating all of the npm dependencies :+1:

@chase-moskal thanks a ton for this great info! I'm bouncing around between a lot of tasks, but I'll revisit this soon and this should definitely be enough information to start making headway.

Is Safari desktop enough to reproduce this error? If so I'll lend a hand.

@chase-moskal @Slapbox Would something like this be acceptable?
https://github.com/theonetheycallneo/webp-hero/pull/1

Sorry, life is too crazy and I never got to come back to this. I don't know what the best way to handle this is, but here's what worked for us:
window.webpMachine = new WebpMachine({
  detectWebpImage: imgEl =>
    /(webp;base64|\.webp.*$)/i.test(imgEl.src),
});

this feature, implemented by @theonetheycallneo, has now been merged to master and published in the latest version of webp-hero. i honestly haven't setup a test for it, i just assume it works!
if anybody experiences any problems with it, please open a new issue!


Handler for legacy URLs

This is post-milestone-5. Extracting a task out of https://github.com/wellcomecollection/platform/issues/4686.
It's for the point when the wellcomelibrary.org content-managed site is switched off.
The host name wellcomelibrary.org should then be pointed at iiif-builder (aka Wellcome.Dds.Server), which is already the fall-through handler for routes not otherwise matched.
This can respond to requests for old IIIF and other API with redirects to their new iiif.wellcomecollection.org equivalents.
Which means we need to write endpoints to receive old URLs, translate them to their modern forms, and send HTTP redirects.
This is mostly simple, although there will be some form of lookup involved to translate index-based URLs to the METS-derived identifier equivalent.
A separate task is required if there is a need to redirect human-facing content (editorial) to new equivalents - but if so, that could live as a module here too.

This can be something in Dds called by a cloudfront lambda.
Give it a wl.org path - e.g., /iiif/b19974760/manifest - and it returns the iiif.wc.org path (not the host): /presentation/b19974760
The above example is trivial, but vol 37 issue 21 of C&D is not.

See https://github.com/wellcomecollection/iiif-builder/pull/94
for discussion of rules (at time of PR, more have been added since)

To refine this issue -
New DDS doesn't handle legacy URLs itself. This will be done by cloudfront lambdas - they do the actual redirecting.
For some of those redirects (e.g., editorial content), the new DDS is no help.
But for others, the new DDS is the only source of information for the new path.
For example:
Old URL is https://wellcomelibrary.org/service/alto/b28047345/0?image=400
New DDS URL is https://iiif.wellcomecollection.org/text/alto/b28047345/b28047345_0403.jp2
(note the use of the METS-derived identifier for the canvas, rather than the index-based parameter).
New IIIF Builder includes a service at https://iiif.wellcomecollection.org/wlorgp/ that provides the new path:
https://iiif.wellcomecollection.org/wlorgp/service/alto/b28047345/0?image=400
=> https://iiif.wellcomecollection.org/text/alto/b28047345/b28047345_0403.jp2
If called with the wlorgp first path segment, it returns the new URL as a plain text body.
If called with the wlorgr first path segment, it returns a 301 (permanent redirect) to the new location.
Cloudfront lambdas could either

call the wlorgp and use the result to perform the redirect themselves
redirect the request to the wlorgr path, allowing it to do another redirect to the actual path.

The framework for doing all this is in this controller with all the hard work done, adding more routes should be easy.
MOH routes could go in here later too.

This is mostly superseded by #5116
The MOH site will remain at the address wellcomelibrary.org/moh/ (but on new infra, obviously)
Given that, the web app serving MOH can also handle old links of static content, particularly embedded UV instances.
This means that while a path like wl.org/item/b12121212 is intercepted by a lambda and redirected to the works page, a path like wl.org/moh/report/b12121212 is forwarded to the wl.org app.
This should also apply to the wl.org paths /assets/, /plugins/, /scripts/, /spas/, /timelines/


Document environment variables

The readme doesn't make it clear that you have to create a .env file, nor what the different variables are

True.  In the immediate short term, refer to .env.example and .env.defaults but yes, better documentation is needed

I am, and the db names are relatively self-explanatory, but not sure what (if anything) to put for the github and redis variables

If you aren't testing the /feedback endpoints they can probably be blank/empty strings

At some point, will probably split that bit off from the core data api


Throttle batch management commands that invoke the git API

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling

[ ] Desktop screenshots
[ ] Mobile width screenshots

[ ] Migrations

[ ] Migration is backwards-compatible with current production code

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

[ ] Settings

[ ] New settings are documented and present in app.json
[ ] New settings have reasonable development defaults, if applicable
[ ] Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?
Closes #905
What's this PR do?
(Required)
How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)

Codecov Report

Merging #909 (4723719) into master (b9f1149) will decrease coverage by 0.30%.
The diff coverage is 90.27%.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   91.94%   91.63%   -0.31%
==========================================
  Files         194      188       -6
  Lines        7284     7016     -268
  Branches     1275     1251      -24
==========================================
- Hits         6697     6429     -268
- Misses        509      511       +2
+ Partials       78       76       -2

Impacted Files
Coverage Δ

...ort/management/commands/import_ocw_course_sites.py
0.00% <ø> (ø)

static/js/components/forms/validation.ts
89.09% <0.00%> (-5.25%)
:arrow_down:

static/js/lib/urls.ts
100.00% <ø> (ø)

static/js/pages/App.tsx
100.00% <ø> (ø)

static/js/types/modal_state.ts
90.90% <ø> (-9.10%)
:arrow_down:

static/js/types/websites.ts
100.00% <ø> (ø)

websites/constants.py
100.00% <ø> (ø)

websites/models.py
94.20% <ø> (+0.86%)
:arrow_up:

websites/urls.py
100.00% <ø> (ø)

static/js/lib/site_content.ts
97.54% <71.42%> (-1.18%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1fee1f...4723719. Read the comment docs.


No console after issueing a factory reset (console menu option 4)

Problem is caused by the absence of loader.conf.local in /boot.
When making a copy of loader.conf to loader.conf.local, the console returns normally after a factory reset.

Which image and version is this? We never once write loader.conf.local and I can't reproduce on a recent iso install. :(

Problem already existed in 15.7.11 and is still present in the most recent ISO (15.7.18), which I installed via USB key.
The problem already occurs on a fresh install. Just issue a factory reset from the console menu and the console will not come up after the system has restarted.

Let's slow down a little, ISO via USB key? Can you let me have the exact image name you used so that I can retest...

Sorry, I meant the serial installer: http://sourceforge.net/projects/opnsense/files/15.7.18/OPNsense-15.7.18-OpenSSL-serial-amd64.img.bz2/download

Thanks, will test when I get back home on the weekend. :)

(FWIW, ISO+VM seems to be unaffected)

Sorry for the confusion about the installer type. :$

No worries, let's keep the bug repots coming :D

FYI: we always use the serial installer on our appliances. Even the QuadCore Gen3, which does have on-board VGA. But this connector only exists on the mainboard as a pin-header, so it is not accessible to the user. The video interface is used by VNC via AMT though, but normally the console port is used for console access.


source command is for composer not bash

this is a source of confusion - source is currently a composer command whereas it should be prioritized as a bash command.

yes, we should either eliminate this command, or rename it in favor of the bash command


Test Case 9_9

Summary
Im facing trouble w test Case 9.
Description
My method is to put in the self checkouts into the same serverImList passed through all events. Then in Arrive, I check for

Idle server first
Idle Self checkout counter
Available server queue
Available SCC queue

However, I am facing a problem such that my customer is waiting in server queue instead of the SCC. (SS below). Since i have passed the first 9 test cases I am assuming that my queueing and updating of queues is correct thus far. Any advice on what is wrong here? Thanks!
Screenshots (if any):

Update: I realised I didn't save the Wait file with updated toString method, but I am still facing issues with Server queue

You should change your code such that all the self-checkout servers will share the same queue. Therefore, when the queue is full, the customer will leave automatically.

you can consider adding the same customer to all SCC queues and removing index 0 of the queue from all SCC queues when the customer is served.

thanks all, i realise the issue was with how i handled the serverQueue of SCC. I did not properly update and dequeue from the first SCC :O


Success event does not execute

Description
When creating a CachedImage in code and giving it a Source, neither the Success not Error events fire. I am attempting to find the height/width ratio of an image that was retrieved/taken using the Media plugin. I have tried using ImageSource.FromUri, ImageSource.FromString, and ImageSource.FromFile, and none of them fire the 2 events.
Steps to Reproduce
See code below. The task never completes because neither event fires.
Expected Behavior
The Success or Error event should fire.
Actual Behavior
Neither the Success not Error events fire.
Basic Information

Version with issue: <IP_ADDRESS>9
Last known good version: N/A
Platform: iOS

Reproduction Link / Code
private async Task<double> GetImageRatio()
{
    var ratio = 0d;
    var cachedImage = new CachedImage {
        WidthRequest = 500,
        HeightRequest = 500,
        DownsampleToViewSize = true
    };

    var task = new TaskCompletionSource<double>();
    cachedImage.Success += (sender, e) =>
    {
        var h = e.ImageInformation.OriginalHeight;
        var w = e.ImageInformation.OriginalWidth;

        var r = w / h;
        task.TrySetResult(r);
    };

    cachedImage.Error += (sender, e) => {
        task.TrySetException(e.Exception);
    };

    cachedImage.Source = ImageSource.FromFile(_selectedFile.Path);// ImageSource.FromStream(() => _selectedFile.GetStream());

    ratio = await task.Task;

    return ratio;
}

cachedImage is not added to views hierarchy. It won't work as it's not displayed.
Maye you should use fluent API instead? See this: https://github.com/luberda-molinet/FFImageLoading/wiki/API

Description
When creating a CachedImage in code and giving it a Source, neither the Success not Error events fire. I am attempting to find the height/width ratio of an image that was retrieved/taken using the Media plugin. I have tried using ImageSource.FromUri, ImageSource.FromString, and ImageSource.FromFile, and none of them fire the 2 events.
Steps to Reproduce
See code below. The task never completes because neither event fires.
Expected Behavior
The Success or Error event should fire.
Actual Behavior
Neither the Success not Error events fire.
Basic Information

Version with issue: <IP_ADDRESS>9
Last known good version: N/A
Platform: iOS

Reproduction Link / Code
private async Task<double> GetImageRatio()
{
    var ratio = 0d;
    var cachedImage = new CachedImage {
        WidthRequest = 500,
        HeightRequest = 500,
        DownsampleToViewSize = true
    };

    var task = new TaskCompletionSource<double>();
    cachedImage.Success += (sender, e) =>
    {
        var h = e.ImageInformation.OriginalHeight;
        var w = e.ImageInformation.OriginalWidth;

        var r = w / h;
        task.TrySetResult(r);
    };

    cachedImage.Error += (sender, e) => {
        task.TrySetException(e.Exception);
    };

    cachedImage.Source = ImageSource.FromFile(_selectedFile.Path);// ImageSource.FromStream(() => _selectedFile.GetStream());

    ratio = await task.Task;

    return ratio;
}

Any tips on this?


Consider improving the translator export-system design to solve potential updating-related issues

According to the intended first design of the translate export system, the Composer hosts the Gadget Spec and the message Bundles.
However, the Composer GETs the original Gadget Spec before every view, and dynamically injects Locales to the Bundles. The default locale is respected, and simply links to the original.
This way, if the original author updates the application (and the default locale), then the changes take effect immediately, without any change to the translated versions of the apps.
However, this has some potential issues:

Workload and Latency issues: External GETs and dynamic generation are required.

If the original author adds a translation for a specific language, or modifies a translation for a specific language, these changes wouldn't take effect on the translated apps.

If the original author removes some variables from a translation for a specific language, again, the translated apps are not updated.

System changed completely


chore: allow manual dependency workflow trigger

:tada: This PR is included in version 1.0.10 :tada:
The release is available on:

v1.0.10
GitHub release

Your semantic-release bot :package::rocket:


MolGIN paper implementation

🚀 Feature
I am interesting to implement or see your advice on the following paper. Equation 5 the dimension of the torch objects in the addition between the (1+eps)*h and sum of concate(h,z) looks strange. Can you tell me if this is compatible to the pytorch-geometric package:
https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9189862
Motivation
This new model looks better than GIN (to be confirmed)

That is indeed compatible, and can be implemented in the message function via torch.cat, e.g.:
def message(self, h_j, z_j):
    return torch.cat([h_j, z_j], dim=-1)

Thanks a lot and about equation 7, this sigmoid function:
def forward(self, x, edge_index, edge_attr):
    """"""
    x = x.unsqueeze(-1) if x.dim() == 1 else x
    Out = self.nn((1 + self.eps) * x + self.propagate(edge_index, x=x, edge_attr=edge_attr))
    return out

def message(self, x_j, edge_attr):
    return torch.cat(F.sigmoid(x_j), edge_attr], dim=-1)

correct ?

That looks correct to me.

Try several possibilities around nothing work when I concate:
here my current version
class MolGINConv(MessagePassing):      """The modified :class:MolGINConvoperator from the"Enhanced Graph Isomorphism Network for
Molecular ADMET Properties Prediction" https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9189862_     paper introduce the gate and the edge concate procedure => the emb_dim can change layer by layer ...     case the gate need to be dynamic with the input size     :param nn: (torch.nn.Module): A neural network :math:h_{\mathbf{\Theta}} that             maps node features :obj:x of shape :obj:[-1, in_channels] to             shape :obj:[-1, out_channels], *e.g.*, defined by             :class:torch.nn.Sequential.     :param eps (float, optional): (Initial) :math:\epsilon value.             (default: :obj:0)     :param train_eps (bool, optional): If set to :obj:True, :math:\epsilon             will be a trainable parameter. (default: :obj:False)         **kwargs (optional): Additional arguments of             :class:torch_geometric.nn.conv.MessagePassing`.
"""
def init(self, nn, eps=0, train_eps=False, **kwargs):
super(MolGINConv, self).init(aggr='add', **kwargs)
self.nn = nn
self.initial_eps = eps
emb_dim = 49
if train_eps:
self.eps = torch.nn.Parameter(torch.Tensor([eps]))
else:
self.register_buffer('eps', torch.Tensor([eps]))
# self.edge_embedding1 = torch.nn.Embedding(num_bond_type, emb_dim)
# adding the gate
self.lin = torch.nn.Linear(emb_dim, emb_dim, bias=True) # this is not correct!
self.act = torch.nn.Sigmoid()
self.reset_parameters()
def reset_parameters(self):
    reset(self.nn)
    # initialize the gate
    glorot(self.lin.weight)
    self.eps.data.fill_(self.initial_eps)

def forward(self, x, edge_index, edge_attr):
    x = x.unsqueeze(-1) if x.dim() == 1 else x
    #edge_attr = self.edge_embedding1(edge_attr)
    out = self.nn((1 + self.eps) * x + self.propagate(edge_index, x=x, edge_attr=edge_attr))
    return out

def message(self, x_j, edge_attr):
    # create the gate of x_j itself
    gatex_j = x_j
    #gatex_j = self.act(self.lin(x_j))
    # compute the gate ie gatex_j*x_j + concate it with edge attribute
    #return gatex_j*x_j
    return torch.cat([gatex_j*x_j, edge_attr], dim=-1)`

message works only if I do only one convolution using this code:
`    def message(self, x_j, edge_attr):
# create the gate of x_j itself
gatex_j = self.act(self.lin(x_j))
return gatex_j*x_j
with 2 convolutions:
/opt/conda/lib/python3.6/site-packages/torch/nn/functional.py in linear(input, weight, bias)
1608     if input.dim() == 2 and bias is not None:
1609         # fused op is marginally faster
-> 1610         ret = torch.addmm(bias, input, weight.t())
1611     else:
1612         output = input.matmul(weight.t())
RuntimeError: size mismatch, m1: [834 x 120], m2: [49 x 49] at /pytorch/aten/src/THC/generic/THCTensorMathBlas.cu:283
Now is I try to concate with this other code:
    def message(self, x_j, edge_attr):         # create the gate of x_j itself          gatex_j = x_j         # compute the gate ie gatex_j*x_j + concate it with edge attribute          return torch.cat([gatex_j*x_j, edge_attr], dim=-1)
got this error
--> 143         return torch.cat([gatex_j*x_j, edge_attr], dim=-1)
144
145
RuntimeError: Sizes of tensors must match except in dimension 0. Got 410 and 834
I play with ESOL dataset
Any solution or advice ?

Your first operator looks correct to me, but emb_dim should not be static (and actually depends on the output dimension of self.nn of the previous layer).

Thanks Matthias,
ok but do you really think that equation 7 is correct based on dimensions
for the addition step ?
I decided to change data preprocess step like this now : data x =
cat(node_feature, edge_attributes) so the concate is done in the data.
But I have still an issue on the neighbour feature weighting gate part.
Based on this paper, we need to learn the weights per feature not per
atoms.
I don't know how to make this operation in pytorch / PyG indeed.
that would be nice if you can take a look please,
thank you
Best regards,
Guillaume
Le lun. 19 oct. 2020 à 10:27, Matthias Fey<EMAIL_ADDRESS>a
écrit :

Your first operator looks correct to me, but emb_dim should not be static
(and actually depends on the output dimension of self.nn of the previous
layer).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rusty1s/pytorch_geometric/issues/1729#issuecomment-711836242,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJBWYXNG3SHRTQVMOYDY53SLP2ADANCNFSM4SRP4QFQ
.

Yes, Eq (7) looks wrong from a dimensionality perspective. You can either append zero vectors to your central node features or use a linear projection to transform incoming messages to the same dimensionality.
IMO, you already learn the weights per feature since gate_x_j computes a weight for each feature.


[Views] Tree view - Fail

Precondition
Launch the application with the arguments "example/example.asn -type EXAMPLE.Sequence"
Switch tool to Tree view
Steps to Reproduce:

Step
Action
Expected
Status

1
Select Sequence
Sequence members are displayed in content view (right side)Only "trivial" types (not sequence, choice, sequence of) are displayed
Pass

2
Select example1
Only members of sequence example1 are displayed in content view
Pass

3
Select optionalSequenceOfEnable optionalSequenceOfIncrease elements to 2Select both elementsDecrease elements to 1
Correct number of elements are displayed at all times as children of optionalSequenceOfMembers of elements are displayed in content view when selected
Pass

4
Select choiceExampleSelect all possible values of choiceExample
Child of choiceExample always reflects the choice selectionChild contents always reflect child type
Pass

5
Right click choiceExampleChoose Collapse
choiceExample node is collapsed, child is no longer visible in tree
Fail

6
Right click choiceExampleChoose Expand
Child is visible in tree
Fail

7
Right click sequenceChoose Collapse all
Only the root of tree is visible
Fail

8
Right click sequenceChoose Expand all
All tree items are visible
Fail

Right clicking an element does not change the content panel, but it should.

https://futsch1.testquality.com defect D10. Do not remove or edit.


Inconsistent tag format may be causing failing galaxy installs

We've found our ansible-galaxy installs are failing recently and it appears to be related to frzk.chrony's change in tag format.
[WARNING]: - frzk.chrony was NOT installed successfully: Unable to compare role
versions (1.0.0, v2.0.0) to determine the most recent version due to
incompatible version formats. Please contact the role author to resolve
versioning conflicts, or specify an explicit role version to install.
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

I have a requirements file like such:
- src: frzk.chrony
  version: 1.0.0

Our builds are unable to execute now and I cannot figure out how to get Ansible to just use the given version. Please advise

Hello,
Thanks for pointing out that issue. This is rather unexpected, I'm sorry that it makes your installs fail :-/
I'll try to fix this somehow as soon as possible.

add tag 2.0.0, remove tag v2.0.0

Hello,
Sorry for the delay. I finally replaced the v2.0.0 tag with 2.0.0 and fixed the release.
Ansible Galaxy has been updated too.
I hope this won't break things for people using the v2.0.0 tag.
Thanks again for reporting this.


Red hex outlining

The current red color scheme makes the redzone look like 1 big hex. Outlining the red hexes may make it more clear.

fixed in #31


Endpoint to create a connection between to users

A 'to' field will be passed with a userId.

A 'to' field will be passed with a userId.

A 'to' field will be passed with a userId.

A 'to' field will be passed with a userId.


Is there anyway to configure the default event log at stdout when starting app?

Hi, is there any possible way to disable the stdout event log or configurate it to generate log in file instead when starting app

Here is the configuration of event log docs with Echo framework.
https://docs.rkdev.info/user-guide/web/echo/logging/#concept
In your case, I think bellow configuration will work.
event:
  - name: my-event
    outputPaths: [""]   # set to empty if want to ignoring all event logs
echo:
  - name: greeter
    port: 8080
    enabled: true
    eventEntry: my-event

It still doesn't work in my case, I have tried this method before

@emilebui I will create a demo package with the configuration ASAP. Maybe it is because of old version.

@emilebui Please try this example: https://github.com/rookie-ninja/rk-demo/tree/master/echo/v2/ignore-event
It works for me on my local machine. Also, please check rk-echo and rk-boot version in go.mod.


Use travis test function to replace bash syntax

Change description
Solve couple human problems:

remove unnecessary evil of bash syntax inside travis configuration file
make configuration file more readable

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     87.09%   87.09%
  Complexity       23       23
=========================================
  Files             9        9
  Lines            62       62
=========================================
  Hits             54       54
  Misses            8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e1284...2022bfb. Read the comment docs.


Web Application Improvement (text and design)

Here's these improvements:

Adding warning about using high level of noise reduction
Adding Russian language (I'm native Russian speaker)
Many little design improvements

About noise reduction: People don't know what variant is better, but noise reduction makes image look badly if image didn't have noise before. Many people use noise reduction when it doesn't need because they don't know that it's not good idea to use denoise every time. People are disappointed in the algorithm but it's unfairly because algorithm is very good.

That help-message cannot be accepted even if that was true.

High (not recommended)
Warning! You should use noise reduction only if image really has noise because in other way it makes image looks worse. Additionally we never recommend to use high level of noise reduction, it almost always makes image worse, it makes sense for only some rare cases when image had really bad quality from the beginning.

Can you change the help-message something like this?

When using 2x scaling, we never recommend to use high level of noise reduction, it almost always makes image worse, it makes sense for only some rare cases when image had really bad quality from the beginning.

Done. But what was wrong in previous help-message? May be there's need less frightening message? Somethink like that:
When using 2x scaling, you should use noise reduction if image really has noise or it may cause opposite effect. Also it's not recommend to use high level of noise reduction, if image had not really bad quality from the beginning then high level almost always makes image worse.
PS. Sorry for my English

Thanks.
In japan, popular card game uses very noisy JPEG image. (high)noise reduction(without 2x scaling) is basic usage for that.

Well, I do say noise reduction is very great feature, it's really amazing, but what I want to say is that each program, algorithm and feature need to use smart. In some case I can get really amazing result that I can not get with any other algorithm, in some case I should use NNEDI3 (some video), in some case I don't need noise reduction.
«In japan, popular card game uses very noisy JPEG image» — I have tested noise reduction on random anime art in my collection. In 70% cases better choice is medium noise reduction, in that cases noise reduction is really great future. In 25% cases better choice is no noise reduction (just upscaling, if I choose medium noise reduction then I get worse image than without noise reduction). In 5% cases better choice is high noise reduction. In other words I think people should know that they must use algorithm wisely.
By the way. I have tested 2x scale on anime Tokyo ESP. I take 1080p (BD), downscaled it to 540p and upscaled it to 1080p with the waifu2x. And I get 2 times better quality than was before! That mean anime creators have used worse upscale than waifu2x can do! And if anime creation would use waifu2x in the future then anime can get better quality without any costs. It's really amazing, thanks =)


Improve error messages

Hi. I thought we might be able to improve the error messages that are generated to be more user friendly.
Before:

After:

I kind of backported IF_T100_DYN_MSG for this and replaced the errors in DEVC with the new approach as a start.
Not sure if this is something you categorically rule out, because I edited ZCX_ABAPGIT_EXCEPTION "by hand" in eclipse. SE24 still does not allow to edit the constructor of exception classes afaik. If so just close the PR.

Thanks, will take a look later today.
I'm thinking it might be possible to do a few changes, and have the default constructor in the exception class

Hi,
Can you try to check if this is possible to implement without changing the constructor manually? We just need some attributes, which are automatically added as input to the constructor when adding via SE24
Plus do you know if if_t100_message exists on 702?

Should be possible without changing the constructor, just need to add some more logic to the raise methods. Naming conventions will get broken though :P
I am not sure which release it was added. Do you know the releases by date?

naming conventions: yes, they are also broken in the existing exception classes
release: I guess its okay, lets just try

Sorry for the delay...
Constructor is now the generated one. Though I wasn't able to generate it using SE24 (I assume because of the pragma, but that cannot be removed in either eclipse nor SE24 o0).
So ADT regenerated the constructor with the quick fix thing.

no problem, looks good, merging


make it so when the code is just comments or whitespaces or tabs then the framerate badge is not shown

so, this a slightly interesting one, and it's currently working slightly differently between the two languages.
in both languages, if you type in any combination of white space, new lines and tabs, then the framerate/stats stuff won't show up. As soon as you type in a letter it appears. It will then stay around if you just delete all the letters/code, and will only disappear again once there's no text (including whitespace)
the difference between the two languages is that V2 won't show the stats if you type in a comment, whereas V1 will.

hmmm this is linked to https://github.com/davidedc/livecodelab/issues/142#issuecomment-114506777 - ideally we want to enable the badge only when rendering, and ideally based on whether any drawing primitive has been called.

so this should be fixed now I believe


dynamically loaded code snippets via HTMX missing "hljs" class on subsequent element swaps

Describe the issue/behavior that seems buggy
I use HTMX to load code snippets from my go backend, dynamically on clicking a button. The backend templates the desired code inside the
 tags and returns it to the requesting browser. The buggy behavior is that only on the first swapping-in of the templated element the "hljs" class is applied to the element that is to be highlighted. If I load a new code snippet without a full page refresh, the "hljs" class is now missing from the classes attribute of that element. The code lines themselves are still highlighted, but the surrounding style container and padding provided by the "hljs" class are missing.
The clarify, I swap the "inner HTML" in HTMX terms, meaning I fully replace all the templated data on each swap. The server returns the data as presented below (with the code to style obviously present).
To workaround this class omission, I need to manually add the "hljs" class to my code tag's classes attribute inside the template. After that, it works consistently on the first and on any subsequent element swaps, with the "hljs" class present.
I tried this with multiple styles incl. the default one.
Sample Code or Instructions to Reproduce
Template code (only working when swapping this in for the first time):

{{ . }}

Template code (workaround, with manually added hljs class):

{{ . }}

Expected behavior
given that I specify the the element's ID to be styled, and having verified that the script fires correctly on each swap-in of the templated data listed above, I would expect the "hljs" class to be added correctly also on subsequent swaps, since the entire code element is always replaced.
Additional context
latest versions of highlight.js and htmx used, tested in chrome and firefox

If you check the highlighted dataset attribute in-between do you find it set to true?  We will refuse to highlight in that case - you'd have to first clear status that from the dataset before attempting to highlight the same element more than once.
Otherwise this is very, very simple code in our library: https://github.com/highlightjs/highlight.js/blob/main/src/highlight.js#L727
If you can create an isolated JSFiddle with just our library (no HTMX, etc) reproducing the issue, we'd be happy to have another look.  But if it only happens with HTMX, perhaps it's a HTMX bug, not us.

Also check your console for warnings, etc.

Thank you for those hints and your help, Josh! I got no error or other messages as indicated by the source you linked, but I went down the rabbit hole and tried to verify my observations with a jsfiddle. Turns out, with vanilla JS and no templated returning of script tags on my side, it works just fine when replacing the entire container. No need to remove the attribute or pre-add the hljs class if I remove it all. However, styling state was also indeed honored correctly limited to that dataset attribute that I could remove when loading in content dynamically into a static container. So with that understanding I reworked my approach entirely (see below).
I will close this issue here and leave a few explanations on what I did to properly solve this for my specific usage with HTMX, maybe another wanderer might find this to be useful in the future.
I revamped my entire templated script inclusion, and actually got rid of the templated code+script tag approach as shown above all together. Now I just return the naked code and apply the styling in a static container that gets re-styled after the HTMX swap-in, and reset (the dataset attribute) before swap-in, like this:

The button that triggers this now looks like this, to allow for a loading message to be shown inside the
 tags while the data is being fetched from the backend:
View

I can now safely swap different code snippets in and out dynamically, same modal container, no problem.
Thanks a again and have a nice weekend :relieved:!


Adding a Screen Recorder would be awesome.

Description of the new feature / enhancement
I can record anything in my screen very easily.
Scenario when this would be used?
Sharing something with anyone. For example my friend don't know how to change wallpaper. 😂 I can show it to him.
Supporting information
No response

Duplicate of #143

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue to centralize the thread.
Thanks for helping us to make PowerToys a better piece of software.


Fix/support 32bit

Support 32-bit machine (e.g. GOARCH=386)
test result: https://github.com/jclab-joseph/miracl-go/actions/runs/4944890215/jobs/8840884016

Hi @jclab-joseph thanks for the work on this. Right now, for general purposes, the 64bit build seems to be more practical but we'll add a 32bit pre-build version too in the future.


CMake Windows Error: Configuring incomplete, errors occurred

When I run cmake CMakeLists.txt from the cpputest-latest folder as it says in the Getting Started guide, I get this:
D:\Projects\Libraries\cpputest-latest>cmake CMakeLists.txt
-- Building for: Visual Studio 16 2019
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.16299.
-- The C compiler identification is MSVC 19.29.30037.0
-- The CXX compiler identification is MSVC 19.29.30037.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for fork
-- Looking for fork - not found
-- Looking for gettimeofday
-- Looking for gettimeofday - not found
-- Looking for pthread_mutex_lock
-- Looking for pthread_mutex_lock - not found
-- Looking for strdup
-- Looking for strdup - found
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
CMake Deprecation Warning at D:/Projects/Libraries/googlemock-release-1.6.0/CMakeLists.txt:46 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

CMake Deprecation Warning at D:/Projects/Libraries/googlemock-release-1.6.0/gtest/CMakeLists.txt:43 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Found PythonInterp: C:/Python27/python.exe (found version "2.7.18")
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
CMake Error: Could not open file for write in copy operation D:/Projects/Libraries/cpputest-latest/INSTALL/CppUTestConfig.cmake.tmp
CMake Error: : System Error: No such file or directory
CMake Error at G:/Programs/CMake/share/cmake-3.19/Modules/CMakePackageConfigHelpers.cmake:336 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  CMakeLists.txt:154 (configure_package_config_file)

CMake Error: Could not open file for write in copy operation D:/Projects/Libraries/cpputest-latest/INSTALL/CppUTestConfigVersion.cmake.tmp
CMake Error: : System Error: No such file or directory
CMake Error at G:/Programs/CMake/share/cmake-3.19/Modules/WriteBasicConfigVersionFile.cmake:49 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  G:/Programs/CMake/share/cmake-3.19/Modules/CMakePackageConfigHelpers.cmake:231 (write_basic_config_version_file)
  CMakeLists.txt:158 (write_basic_package_version_file)

-------------------------------------------------------
CppUTest Version 4.0

Current compiler options:
    CC:                                 C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe
    CXX:                                C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe
    CppUTest CFLAGS:                     /FI "D:/Projects/Libraries/cpputest-latest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
    CppUTest CXXFLAGS:                   /FI "D:/Projects/Libraries/cpputest-latest/include/CppUTest/MemoryLeakDetectorMallocMacros.h"
    CppUTest LDFLAGS:

Features configured in CppUTest:
    Memory Leak Detection:              ON
    Compiling Extensions:               ON
    Support Long Long:                  OFF
    Use CppUTest flags:                 ON

    Using Standard C library:           ON
    Using Standard C++ library:         ON
    Using C++11 library:                OFF

    Generating map file:                OFF
    Compiling with coverage:            OFF

    Compile and run self-tests          ON
    Run self-tests separately           OFF

-------------------------------------------------------

-- Configuring incomplete, errors occurred!
See also "D:/Projects/Libraries/cpputest-latest/CMakeFiles/CMakeOutput.log".
See also "D:/Projects/Libraries/cpputest-latest/CMakeFiles/CMakeError.log".

D:\Projects\Libraries\cpputest-latest>

CMakeFiles folder with the logs:
CMakeFiles.zip

There is a file called INSTALL in the root directory, if you change it's name you will get past this error.  Also, you might want to download pkg-config-lite-0.28-1_bin-win32.zip from https://sourceforge.net/projects/pkgconfiglite/files/ and put the executable somewhere on the PATH.

The  reason this causes a problem is that the Windows file system is case insensitive, and INSTALL and install are the same. so the make dir command fails (silently).

Hmm.  Adding to the confusion is the fact that, we only get this problem on Windows when we try to build CppUTest in the same directory as the root CMakeLists.txt file.  (or as a within source build.)   When you do an out of source build there is no conflict.

I would agree. Permanently renaming it isn't a good option as you said, it is part of the GNU standard.  Moving it away for a windows CMake build feels harmless

hello, i met a problem when i was using cmake to configure my code, it was
CMake Error at cmake/DownloadProject.cmake:171 (message):
CMake step for libigl failed: 1
Call Stack (most recent call first):
cmake/FloatTetwildDownloadExternal.cmake:15 (download_project)
cmake/FloatTetwildDownloadExternal.cmake:29 (float_tetwild_download_project)
cmake/FloatTetwildDependencies.cmake:44 (float_tetwild_download_libigl)
CMakeLists.txt:77 (include)
I dont understand this problem,so please could you tell me about this?
thanks for you answer.


Is it possible to Get Current page Data in ngx data table?

Hi All,
is there a way to get all the visible rows in current page.
say for example i have 10 pages with 10 rows in each page.
on click of a button i need to see all rows visible in the current page
Thanks in advance!
Vivek

Hi, you can get the data on current page by table.bodyComponent.rowIndexes. It will return a map with data on current page.
@ViewChild(DatatableComponent) table: DatatableComponent;
Array.from(this.table.bodyComponent.rowIndexes.keys()) will return the data as array.
Hope it will help you.

Yeah it worked thanks

Yes it works Thank you @TangTing528

This is not working for me with version 17.0.0.  The following code returns a WeakMap:
this.table.bodyComponent.rowIndexes.keys()
And when trying to convert it into an array it throws an exception, any idea how solve this problem?
I need to display the sum of the visible rows of a column, but that code does not seem to work for me.
As you can see in the attached screenshot, it returns a WeakMap and keys() is undefined.

Thanks!

have any way to get the sorted data from the entire table?

have any way to get the sorted data from the entire table?

this.table.bodyComponent.rows

@TangTing528  mu viewChild just return undefined   @ViewChild('table') table: DatatableComponent;
      <ngx-datatable
        class="bootstrap"
        [rows]="usersFiltered"
        [headerHeight]="40"
        [footerHeight]="40"
        [limit]="50"
        [columnMode]="ColumnMode.flex"
        rowHeight="auto"
        #table <--- this
      >
            [...]

Could you mock up the component in StackBlitz?

@TangTing528 my viewChild just return undefined @ViewChild('table') table: DatatableComponent;
      <ngx-datatable
        class="bootstrap"
        [rows]="usersFiltered"
        [headerHeight]="40"
        [footerHeight]="40"
        [limit]="50"
        [columnMode]="ColumnMode.flex"
        rowHeight="auto"
        #table <--- this
      >
            [...]

here: https://stackblitz.com/edit/angular-ivy-toqxlq

Could you mock up the component in StackBlitz?

@TangTing528 my viewChild just return undefined @ViewChild('table') table: DatatableComponent;
      <ngx-datatable
        class="bootstrap"
        [rows]="usersFiltered"
        [headerHeight]="40"
        [footerHeight]="40"
        [limit]="50"
        [columnMode]="ColumnMode.flex"
        rowHeight="auto"
        #table <--- this
      >
            [...]

@TangTing528 here: https://stackblitz.com/edit/angular-ivy-toqxlq

Could you mock up the component in StackBlitz?

@TangTing528 my viewChild just return undefined @ViewChild('table') table: DatatableComponent;
      <ngx-datatable
        class="bootstrap"
        [rows]="usersFiltered"
        [headerHeight]="40"
        [footerHeight]="40"
        [limit]="50"
        [columnMode]="ColumnMode.flex"
        rowHeight="auto"
        #table <--- this
      >
            [...]

@TangTing528 here: https://stackblitz.com/edit/angular-ivy-toqxlq

Table was not ready in ngOnInit. Need to wait view ready.
Try:
ngAfterViewInit(): void {
console.log(this.table.bodyComponent.rows);
}


[ZP-7118] Update authorize method android

Description of Change
Android users were having problems logging in via SSO. The issue was that there was an update due to this issue, but we haven't updated our library in a while.
This change is mostly in the session.start method and will fix the double login call it was generating, causing our weird behavior in the SSO login.
Risk Management

🚧 Medium Risk
Checklist

[ ] Tests: I have added tests or explained why tests weren't added in the risk section above.
[x] Performance: I have reviewed my changes for performance issues and tested it under load if necessary (i.e. DB queries, indexes, deadlocks).
[ ] Backwards compatibility: I have designed and tested with backwards compatibility for mobile in mind or added instructions to the risk section below.

Migrations
N/A
Dependencies
Related PR: SSO FIX PR

@davidofwatkins good idea! should we create a PR for the dependency update branch and then pulled them and work over those upgrades?

After trying to use the function _parseAuthorizeResponse we currently have, I couldn't login successfully. I replaced the old code with the new one and call that function inside the session.start method inside Authorize. This causes an issue of making a double request, I honestly don't know why.
The way we have it in the PR is the way the has worked for me testing it from my android. I know we have some similar logic there, but I didn't expect that the refactor of that method cause trouble with the double request.
Want to know your opinion of keep digging of ship this solution. @Smotko @davidofwatkins

Looks good to me, but once all of this is merged, please let the QA team know that they should test SSO on android, ios, and windows for both new and existing sessions.

For sure! I'll leave a comment in the Jira ticket for QA in order to test all devices and also the steps to reproduce this with a demo video. Just to keep record of the video and changes in the ticket 😄  Thanks for the review @Smotko


Interpolation with {js||js} strings doesn't work

{j||j}, {js| |js} strings could eventually work, but they don't right now so it's better to raise a [%error] in the ppx level and wait for the feature to be implemented
Any idea how to support it @pedrobslisboa?

https://github.com/ml-in-barcelona/server-reason-react/pull/139 ?

Interpolation don't work

I'm drunk or tired, you are right @anmonteiro both are implemented


add a working control pannel

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

no legacy apps please


use real arrays of objects for whereFilters

Jira: -
KBC: -
whereFilters[] was just human-readable tweak, but it was incorect. It also generated wrong examples
https://keboola.slack.com/archives/CFVRE56UA/p1678714448172729?thread_ts=1678705598.398669&cid=CFVRE56UA
Before asking for review make sure that:
Checklist

[x] New client method(s) has tests
[x] Apiary file is updated

Release

[x] I gave the PR a proper label:

major (BC break)
minor (new feature)
patch (backwards compatible fix)
no release (just test changes)

Martin tomu dal palec takže OK, klidně bych to merdžnul


admin setting missing

my admin panel have only three options ,is this right?  I think there shuld have a system setting option?
should i set something?

Hi @xiaoweizha :wave: This looks like a default view for non-admin user (e.g author or editor), there are more options available if you are logged in as ad administrator or owner.  Let me know if that's not a case  :+1: but closing this issue for now.


Build Scanner with nested column projection and limit / offset push down.

A code snippet to run
import time

import duckdb
import lance

ds = lance.dataset("s3://eto-ops-testing/coco.lance")

start = time.time()
scan = lance.scanner(ds, columns=["annotations.label"], limit=10)
print(duckdb.query(
    "SELECT annotations.label, count(1) FROM (SELECT UNNEST(annotations) as annotations FROM scan) GROUP BY 1"))
end = time.time()
print(f"Query time: {end - start}")


Handle all auto*, not just autorequire

Since Puppet 4.0.0 types can specify autobefore, autonotify, autorequire and autosuscribe. This allows testing these relations.

It fails in the same way. I think that's just broken in master because it doesn't even get to the testing part.

It fails in the same way. I think that's just broken in master because it doesn't even get to the testing part.

It fails in the same way. I think that's just broken in master because it doesn't even get to the testing part.

Yeah, it looks like we'll need to bump the version of OpenSSL on those AppVeyor Windows hosts or something along those lines.
I'll see if I can do a quick tyre kick on a local Windows host internally

See #830

Thanks for the patience @ekohl . Now #824 is merged, would you mind rebasing with rodjek/master?

Trivial rebased done.


error message of "TypeError: Object of type float32 is not JSON serializable" on RMtools_1D/do_RMsynth_1D.py

Hi,
Execution on  pops out the error message "TypeError: Object of type float32 is not JSON serializable".
json.dump() seems to not support the float/int of NumPy. It can be fixed by converting the np float/int to the Python float/int as below.
Ruolan
saveOutput function
.......
for k, v in outdict.items():
if isinstance( v, np.float32 ) or isinstance( v, np.float64 ):
outdict[k] = float(v)
if isinstance( v, np.int32 ) or isinstance( v, np.int64 ):
outdict[k] = int(v)
json.dump(dict(outdict), open(outFile, "w"))

Hi Ruolan:
Can you send me the data you were running that generated this error, and the settings you used? I'd like to recreate it so that I can better understand where it came from (so as to avoid similar problems in the future).
Thanks,
Cameron

@Cameron-Van-Eck  - this has bitten me in SPICE-RACS as well. Although, in my case the JSON came from my database format, rather than writing to disk. It's strange we haven't seen this issue earlier. If it's helpful, it can be nice to use the numpy primitives to capture all float (or whatever) types. Here's an example from the SPICE-RACS pipeline:
    # Ensure JSON serializable
    for k, v in mDict.items():
        if isinstance(v, np.float_):
            mDict[k] = float(v)
        elif isinstance(v, np.int_):
            mDict[k] = int(v)
        elif isinstance(v, np.ndarray):
            mDict[k] = v.tolist()
        elif isinstance(v, np.bool_):
            mDict[k] = bool(v)

    do_RMsynth_1D.saveOutput(mDict, aDict, prefix, rm_verbose)

@Cameron-Van-Eck I think it is because the built-in json package supports the Python basic type only, not all the numpy datatype. The example below can reproduce the this issue
import json
import numpy as np

for dtype in [np.int8, np.int16, np.int32, np.int64, np.int_]:  # np.int_ == np.int64
#for dtype in [np.float16, np.float32, np.float64, np.float128, np.float_]:    # np.float_ == np.float64
    try:
        json.dump(dtype(np.pi), open("foo", "w"))  # numeric
#        json.dump({"key": dtype(np.pi)}, open("foo", "w"))  # dict

        print("{} passed".format(dtype))

    except TypeError:
        print("{} failed".format(dtype))
#        raise

For integer variables (and values in dict), only numpy.int64 passed for Python 2.7.16, and none for Python 3.10.8. For floating number, only numpy.float64 passed for both Python 2 and 3.
I am not sure why the recipe in the SPICE-RACS pipeline works since this issue occurs when not isinstance(v, np.int_) and not isinstance(v, np.float_)

Can you send me the data you were running that generated this error, and the settings you used? I'd like to recreate it so that I can better understand where it came from (so as to avoid similar problems in the future).

Hi Cameron,
It was just the sample data (Soucre1.dat created using 'mk_test_ascii_data.py') you provided. XD
Ruolan

For whatever reason, I can't reproduce the behaviour on my own machine (I can reproduce @hfhsieh's example, but not within RM-Tools). But since a solution has been suggested, I've implemented it into the JSON-saving code in rmsynth1d, rmclean1d, and qufit. Could someone please try the updated version (47e8915) and confirm that this fixes the problem?
Thanks,
Cameron


Velocity Rotation - self rotating when

Gif is just example of the issue that I did come a cross.
Its only on velocity rotation. I am not sure if that is part of setting that I can change or it is a bug? So have to ask how to make player stop rotating when he move towards object or other actor?
It is really problematic when character is moving towards and trying lets say swing a sword but then player self rotating to the side.

This is not really a bug per se, just a property of using velocity direction.
The workaround is to change the calculation to use input direction instead.
Perhaps only when detecting a wall in front of the character.
I don't think this repo needs to do anything about this, this is how ALS has always been (and how many games work).
It is unfortunate that it ruins mantling in velocity direction though.

yea, I did look around Discord. Its common thing.  So solution would be as you mention to remove velocity direction or maybe create separate rotation mode just for control rotation or... I just found today that "roll" function has some bool for input direction. Maybe it would be possible to move that function.
Overall it would not be problematic but it is in my case. Character quickly self rotate when he collide other character.


[minor] link to a tutorial for the #[implement(...)] macro

Tiny doc addition as a follow-up to https://github.com/microsoft/windows-rs/issues/2882

I'm not a fan of increasing the number of pointers to Kenny's personal blog/domain, but not going to block this.

We'll hopefully move the tutorials I wrote over to windows-rs soon.


getSelectedDocument returns wrong document when there are multiple files open

Hi there,
I have noticed in Sketch 53.1 that the Document.getSelectedDocument() seems to bind itself to the first document that opens, and from then on the value does not update when switching to other documents.
You can reproduce this by creating 2+ sketch files, and logging out the Document.getSelectedDocument().path whenever you switch between them. You will see that it doesn't update.
Any suggestions to help workaround or solve this issue?
Thanks!

I should also mention that I tried the alternative method of accessing the current document from #253, but it did not seem to help.

So is there an issue?

Looks like the issue was that my Document.getSelectedDocument call was nested inside a sketch-module-webview win.on('focus') callback, which I setup 'onOpenDocument', so I need a way to update this webview whenever I switch documents as well. So I don't think there is an underlying issue.


Makefile changes with 9dda52d cause 'make install' to fail

The 'ln' commands at the end of the Makefile lack -f to clobber any existing symlinks.

You should see about making pull requests :)

I will do that :) I need to better learn how to use Github and Git in general.

On 12 Nov, 2015, at 11:53:31 AM, cyoung<EMAIL_ADDRESS>wrote:
You should see about making pull requests :)
—
Reply to this email directly or view it on GitHub.

This is a fun-ish way to learn:
http://
http://www.google.com/url?q=http%3A%2F%2Fpcottle.github.io%2FlearnGitBranching%2F&sa=D&sntz=1&usg=AFQjCNHJITlkdUc2PkGUokzfIXWh76-r2w
pcottle.github.io
http://www.google.com/url?q=http%3A%2F%2Fpcottle.github.io%2FlearnGitBranching%2F&sa=D&sntz=1&usg=AFQjCNHJITlkdUc2PkGUokzfIXWh76-r2w
/
http://www.google.com/url?q=http%3A%2F%2Fpcottle.github.io%2FlearnGitBranching%2F&sa=D&sntz=1&usg=AFQjCNHJITlkdUc2PkGUokzfIXWh76-r2w
learnGitBranching
http://www.google.com/url?q=http%3A%2F%2Fpcottle.github.io%2FlearnGitBranching%2F&sa=D&sntz=1&usg=AFQjCNHJITlkdUc2PkGUokzfIXWh76-r2w
/
http://www.google.com/url?q=http%3A%2F%2Fpcottle.github.io%2FlearnGitBranching%2F&sa=D&sntz=1&usg=AFQjCNHJITlkdUc2PkGUokzfIXWh76-r2w
On Nov 12, 2015 13:55, "loather"<EMAIL_ADDRESS>wrote:

I will do that :) I need to better learn how to use Github and Git in
general.

On 12 Nov, 2015, at 11:53:31 AM, cyoung<EMAIL_ADDRESS>wrote:
You should see about making pull requests :)
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/cyoung/stratux/issues/115#issuecomment-156216959.

Thanks. i'll give those a look!


Error when starting code from within WSL

VSCode Version: 1.40+
OS Version: Windows 10 Pro OS build 17134.48

Steps to Reproduce:

Upgrade VS code to 1.40 (or use latest code-insiders).
From WSL / Ubuntu shell, try to open something with code (like code foldername).
Get error: Error: EINVAL: invalid argument, uv_pipe_open vscode

Downgrading to 1.39 resolves the issue. This has been reported on other issues (linked) and was marked as resolved, but it seems that there has been a regression. I also get the error with latest code-insiders.
https://github.com/microsoft/vscode-remote-release/issues/1420
https://github.com/microsoft/vscode-remote-release/issues/1490

What verison of Remote WSL do you use?
When you see the error message, is there still a remote WSL window opened, or is the command no longer working?
I'm not able to reproduce on
Remote WSL version: 0.40.2,
VSCode 1.41.0-insider (user setup)
Commit: 213bdddb72ff7a6c8eed071420de8ddac4293cb1
Date: 2019-11-11T05:40:31.150Z
OS: Windows_NT x64 10.0.17134


UI: Error when trying to access Timelines in UI (Issue #3497 )

Added references to self for building binary blob for a report result. This was preventing the resource_type and resource_id from being set an effectively creating an orphaned binary blob.
They were accidentally removed while fixing rubocop warnings for a previous PR

Only need the first one.
And can we add a spec?

@matthewd Please review

@gtanzillo See Closing issues via commit messages for proper way to auto-close a GitHub Issue.

@chessbyte Thanks, I'll make sure I use that syntax going forward.

@gtanzillo You can also put the right string in the PR.  See https://github.com/blog/1506-closing-issues-via-pull-requests


Attempt to present <SFSafariViewController: 0x18e63a60> on <RNPaypal: 0x18e632b0> whose view is not in the window hierarchy!

on physical device calling requestOneTimePayment doesn't show up the paypal page and log this error on the console.
on the emulator it works.

Hello @kotomono, do you still have the same issue? IIRC you can ignore that warning, but I'm not sure at the moment. If you still have issues with that, would you mind sharing your AppDelegate.m code?


Fix XML parsing for sites with only one entry

My friend's site using XML feed and only have one entry.  When I try to fetch the feed it returns
Trace: TypeError: item.map is not a function
    at parseRSS (file:///home/neizod/feed-reader/src/utils/parser.js:88:24)
    at read (file:///home/neizod/feed-reader/src/main.js:34:27)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async extractFromUrl (file:///home/neizod/feed-reader/eval.js:10:17)
    at extractFromUrl (file:///home/neizod/feed-reader/eval.js:14:13)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

As I investigate, the item variable, after parsed from XML into JSON, can be an array or an object (like the case of Atom in the same file).  Thus, .map function fail to work on when it is actually an object.
This PR should fix the issue.

Coverage remained the same at 95.122% when pulling f64f48a9f136558cfb27b502ee7e6e52d2a2b7a8 on neizod:main into 5c4bfc26315392586ee17cb18060117123a53766 on ndaidong:main.

Coverage remained the same at 95.122% when pulling f64f48a9f136558cfb27b502ee7e6e52d2a2b7a8 on neizod:main into 5c4bfc26315392586ee17cb18060117123a53766 on ndaidong:main.

@neizod thank you for your fix. I will merge this pr now.


Never rejecting promise in promise middleware

Just an idea, maybe promise could be always resolved, but with an object with one of the following params: success, error, abort
Why? Because otherwise there are issues with requests aborts which will raise unhandling promise rejection error. The same goes for error, sometimes you don't want to handle an error in a specific place because there aren't any predictable error and random network errors you wanna handle globally.
After this, we could give up meta.asPromise as well as auto config in promise middleware . We could promisify all requests simply because there would be no negative side of doing so, it would reduce the boilerplace.
Connected with #93 , #128 , #179 , @nemosupremo , @mowbell, @megawac , what do you think?

@strdr4605 If you have some time, I would like to know your opinion. On removing saga branch actually I will remove also promise middleware. This does not make sense anymore as because request sending logic will be in another middleware which will replace sagas, I can return promise there directly, simplifying the code.
And also because saga will be removed, promisified request action will be the only way to wait for a response in the place you dispatch request action, which is often needed.
Previously this could also be done with sendRequest which must be gone as it is just saga.
I want to remove meta.asPromise, handleRequest promisify and autoPromisify options.
The reason for those to exist was to avoid unhandled promise rejection warning...
The problem is, if you distatch(fetchSth()), this returns promise which will be resolved on success and rejected on error and abort. But often you dont care about it, you can for instance handle exception in another place, or even you might not doing this at all as error is kept inside reducer.
I am thinking the best would be to always resolve promise with either success, error or abort key. Then no warning will be present. Also maybe it is more logical as we have 3 potential response types and promise supports only 2.
What do you think?

I like more the idea of getting the request results from the redux state and not from dispatch(fetchSth()).then(.... This is why I like using redux middleware like redux-saga.
About redux-saga-requests I would also like to use it as a middleware (even without redux-saga) and access data only through redux state.
Can you give an example where I would need to use dispatch(fetchSth()).then(... instead of getting data from the state.
I don't really want to promisify every action by default. And I think that  error and abort should be dispatched on Promise.reject as it's a natural way.
Never rejecting promise may confuse people who will have some issues and try to debug. The same applies to new contributors.
This library already enforces some constraints which are hard to understand and adapt for some people (as in the case with my team, and even I have confusion).
So still solve this case where dispatch(fetchSth()).then(... is needed I would suggest having a custom
dispatch function that will promisify the action. Something like this:
import React from 'react'
import { useResolveDispatch } from 'react-saga-requests'

export const Component = ({ state }) => {
  const resolveDispatch = useResolveDispatch()

  resolveDispatch(fetchBooks()).then(successOrRrrorOrAbortAction => {
  // do something with action
  })

  return (
    <div>
      ...
    </div>
  )

@strdr4605

I like more the idea of getting the request results from the redux state and not from dispatch(fetchSth()).then

me to, and usually this is what I do, but sometimes it is more convenient to handle response in the place you dispatch request action, for example:

In React component in onSubmit like:

onSubmit = values  => {
  dispatch(doMutation(values)).then(resetForm);
}

This is a very common use case especially to update some local state not kept in Redux. As a comparison, this is very easy to do with redux-thunk which returns promise, but hard or impossible with redux-saga - you would need to pass resolve/reject to saga or resetForm to call inside saga, which is terrible as you then pass ui related logic to redux layer

Some people like to do SSR by implementing static methods in top Route component, for instance you have a component with method:

static fetch() {
  return store.dispatch(fetchSth())
}

Then they collect all components, call all static fetch methods and wrap in Promise.all

Using saga u can easily do sth like yield take(success(FETCH_STH)), but some people don't like it, I had issues in this library where people said they prefer to get response in the place they dispatch request, so for example they could do const response = yield putResolve(fetchSth())

There are many more use cases like that, those are just examples.

I don't really want to promisify every action by default.

I am thinking about doing this so you don't need to worry about it, generally promisyfying request action doesn't cause any problems, if you do dispatch(fetchSth()) and you don't care about result, then you don't care it is promise or not
The only disadvantage is this promise rejection warning... that's why I was thinking about having:
const { response, error } = await dispatch(fetchSth());

// not
try {
  const response = await(fetchSth());
} catch(e) {

}

I just want to weight all pros and cons and decide, whether allow not to promisify all actions and whether resolve or reject errors and aborts. I favour promisyfying everything because I could remove some options from API and resolving always to avoid unhandle rejection warnings. But maybe I am missing some cons of doing so, that's why I created this topic.

This library already enforces some constraints which are hard to understand and adopt for some people (as in the case with my team, and even I have confusion).

Could you please give me examples? I really want this library to be easy to use and logical. It is a good time to improve things before 1.0, but I need to know what problems are. Whether this is confusing API or missing examples/docs.

useResolveDispatch

Interesting idea, it could be done theoretically by wrappping useDispatch and for instance adding special action.meta. This is only for React though, many people would still want to have this in redux layer, for examples in sagas like I showed in examples
I really admit this topic is a tough one and I really want to make a good call before 1.0.

As I see usage for Never rejecting promise
onSubmit = async (values)  => {
  const { success } = await dispatch(doMutation(values));
  if (success) {
    resetForm(success.data);
  }
}

onSubmit = async (values)  => {
  dispatch(doMutation(values))
    .then(response => {
        if (response.success) {
          resetForm(response.success.data);
        }
    });
}

instead of
onSubmit = async (values)  => {
  try {
    const response = await dispatch(doMutation(values));
    resetForm(response.data);
  } catch() {}
}

onSubmit = async (values)  => {
  dispatch(doMutation(values))
    .then(response => {
          resetForm(response.data);
    }).catch();
}

So the question is:
another if vs try ... catch

Thx for the feedback. For now I favour never rejecting promise, because unhandled promise rejections cannot really be avoided for aborts (which is not even an error) or errors if u just handle them in other places, like by reading from state. This not only spams console, sentry if u use it, but also could exit nodejs process with ssr, I am not sure for which node version, but I read in the past that this warning will actually exit nodejs process in future nodejs version.
Anyway, assuming we will go this way, I would actually flatten this a little, so:

for success I would resolve as { data, action: successAction }
for error I would resolve as { error, action: errorAction },
for abort I would resolve as { aborted: true, action: abortAction }

So as you see, no response but data directly, which thogether with error will resemble useQuery hook, which is good I think.
Also, in all cases I would pass action key with response action (no matter what type) if someone needs it. One could even access request action as action.meta.requestAction.
Also, in theory I could make it customizable, but really I dont want to do it as I want to keep API to the minimum, which also avoids confusion.
One could always add own middleware to listen for promises which could once again reject them for abort and error responses.

So interface will look like:
interface PromiseAction<DataType = any> {
  data: null | DataType[] | DataType
  error: null | Error
  aborted: boolean
  action: SuccessAction | ErrorAction | AbortAction
}

Yeah, that would be it, just I think that  data would be  data: null |  DataType;, this array was for batch request I guess, but this can be any type (because interceptor or meta.getData could change it like https://github.com/klis87/redux-saga-requests/blob/master/examples/basic/src/store/actions.js#L12), and if it is array, one could pass DataType as array directly.

I would also suggest changing aborted -> isAborted.

Thx

data: null | DataType[] | DataType;

I added array because of https://github.com/klis87/redux-saga-requests#getquery:

multiple: set to true if you prefer data to be [] instead of null if data is empty, false by default

Good eye, and actually in previous version it might be like that.
But in current version multiple is only on selector level, and dispatch should resolve data just to those returned from server, plus optionally modified with onResponse interceptor and action.meta.getData

So
const response = await dispatch(fetchSth());

will have data that comes from the server and NOT data which was processed with action.meta.getData?

@strdr4605 both, the procedure is this:

middleware awaits response, for error it just returns error, for success see data processors in next points
if batch request, mutliple responses are merged as one object with data as array, for normal requests nothing is done
meta.getData is called if defined
interceptor onResponse (I should rename it to onSuccess) is called

and only that processed data is then passed to reducer and returned from promise dispatch
also, if you have ssr response or cached response, those 2-4 of course are not done, as it was already done for initial request. This is because caching works like that, if you fire request and sth is cached, then instead of making request it just gets state from reducer and returns that, but that was already processed with getData etc so it won't be again

Done in 0.28.0


added my details

Hi @pranjalg131, you need to name your file as .json to pass the checks.

Changes looks good to me. Merged!! ✌


Deprecation warning for cookie_date in Django 2.1+

django.http.utils.cookie_date was deprecated in Django 2.1 in favour of http_date in the same package, which conforms to the latest RFCs for setting cookie expiry. This function exists all the way back to Django 1.11, so there should be no reason not to use it.
Expected Behavior
Using django-user-sessions' SessionMiddleware does not trigger RemovedInDjango30Warning.
Current Behavior
Using django-user-sessions' SessionMiddleware triggers RemovedInDjango30Warning:
[snip]/python3.6/site-packages/user_sessions/middleware.py:52: RemovedInDjango30Warning: cookie_date() is deprecated in favor of http_date(), which follows the format of the latest RFC.
    expires = cookie_date(expires_time)

Possible Solution
Swap cookie_date for http_date

Never mind, this is already in #90.


Run sshd in a seperate container

when the user successfully logs in via ssh, it then runs docker exec -it console bash

Will there be an easy interface to the sshd config?

oh gosh - https://www.digitalocean.com/community/tutorials/how-to-use-cloud-config-for-your-initial-server-setup looks horrible for sshd_config


Update bindings to work with JSON reference tests

This PR will:

Convert the success tests to JSON.
Add a new failure test case for each function. Just a placeholder.
Update each binding to accept JSON tests.

Going to scrap this & support yaml tests instead. I thought both would be available.


Edits lost because vscode reloads the file while editing it

VSCode Version: 1.11.2
OS Version: Win 10

Steps to Reproduce:

Open a folder from a network share served by samba on ubuntu 16.04
Work for some hours in vscode
Eventually the file you are working on will reload (without any file change from elsewhere) and you loose all your edits
That happens about 1 time in 2 hours.

@RobIsHere to be clear, the editor was not dirty at the time your changes got overwritten, or was it?

It was dirty! The file reloads and all unsaved edits are just discarded.
I opened the file, wrote about 50 LOC in the file and then it flickered and my yet unsaved stuff was gone.
I'm using vscode for some time now and I'm very happy with it in general. This happened the first time after upgrading from 1.8.1 to current about 2 weeks ago. In 1.8.1 it never happened.

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

Interesting thought. I'm only using quite common extensions like eslint. So i don't think so or you would have a lot more reports. But I'll try switching them off the next days.

@RobIsHere any results?

It didn't happen since then even with extensions on. The "fix" may also come as a side effect of changes I made for watchman https://facebook.github.io/watchman/docs/install.html#system-specific-preparation.

Ok closing until we see it again.


JDK16 build instead of JDK15

Previous testing in https://github.com/square/okhttp/pull/6325/files

Possibly some fixes required before gradle 7 https://melix.github.io/blog/2021/03/gradle-java16.html


Add trailing slash to login endpoint in login form

Checklist

[ ] All new and existing tests are passing
[ ] (If adding features:) I have added tests to cover my changes
[ ] (If docs changes needed:) I have updated the documentation accordingly.
[ ] I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
[x] I have written proper commit message(s)

What changes does this Pull Request introduce?

Adds trailing slash to login URL in the admin login form.
Why is this necessary?

For some reason this causes an issue logging in when running locally, but the issue doesn't happen on my live Isso instance

Sorry, I already pushed that.


Webpack loaders issue

Hello, I am a beginner with vue 3, i have the following problem with vue3-charts after npm run serve:
My dependencies:
"dependencies": {
"core-js": "^3.6.5",
"vue": "^3.0.0",
"vue-slider-component": "^4.0.0-beta.4",
"vue3-charts": "^1.1.22"
},
The Error:
`in ./node_modules/vue3-charts/dist/vue3-charts.esm.js
Module parse failed: Unexpected token (6533:20)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loadersepts#loaders
|       ]),
|       createElementVNode("g", _hoisted_4$3, [

    (!_ctx.axis?.primary?.hide)

|           ? (openBlock(), createBlock(_component_axis, {
|               key: 0,
/vue-loader-v16/dist??ref--0-1!./sr
@ ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader-v16/dist??ref--0-1!./src/App.vue?vue&type=script&lang=js 2:0-32 7:11-16
@ ./src/App.vue?vue&type=script&lang=js
@ ./src/App.vue
@ ./src/main.js
@ multi (webpack)-dev-server/client?http://<IP_ADDRESS>:8080&sockPath=/sockjs-node (webpack)/hot/dev-server.js ./src/main.js`

What is the setup? Simple vue-cli setup or you guys are using custom webpack file?

Same here, just using Vue3 cli

Yes same issue using @vue/cli 4.5.15 yarn 1.22.10 and node v14.18.0

Please see my comment for a fix (I'm not using webpack anymore but this used to work for me)

This is fixed in version 1.1.27.


Improvement/build log levels

Codecov Report

Merging #562 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #562      +/-   ##
============================================
+ Coverage     99.47%   99.49%   +0.02%
  Complexity     1479     1479
============================================
  Files           238      238
  Lines          4544     4541       -3
  Branches        228      227       -1
============================================
- Hits           4520     4518       -2
  Misses            2        2
+ Partials         22       21       -1

Impacted Files
Coverage Δ
Complexity Δ

...ssera/transaction/EncryptedTransactionDAOImpl.java
100% <ø> (+3.7%)
6 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5915fa7...931a0ab. Read the comment docs.