Arrow function should build into es5 before publish

https://github.com/sindresorhus/split-on-first/blob/master/index.js#L3

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser. You can find a more detailed explanation here: https://github.com/sindresorhus/ama/issues/446
If you use Webpack, check out babel-engine-plugin, which transpiles only the dependencies that needs to be transpiled.
If you use Create React App, upgrade to Create React App v2. It supports automatic transpilation of dependencies, which will make this package just work.

https://github.com/umijs/es5-imcompatible-versions/pull/26

https://github.com/sindresorhus/query-string/commit/73e57caabfdea7d17966fdf2621a178c472a15a1
@ycjcl868 Maybe you are using query-string > 6. This package only supports Node.js since v6.


Unexpected dismissal when transitioning between destinations (prerelease/1.0)

Description
When a screen is presented with multiple possible destinations, the view unexpectedly dismisses when transitioning between these views.
Checklist

[X] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[X] If possible, I've reproduced the issue using the main branch of this package.

(n/a)

[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
The view will smoothly transition between destinations without dismissing when a single ifLet reducer/fullScreenCover modifier is used.
Actual behavior
The destination view dismisses before transitioning to the new destination.
Steps to reproduce

Start a fresh SwiftUI iOS project.
Add TCA/prerelease/1.0 to the project dependencies
Copy and paste the following code into the ContentView.swift file
Run the app and note the dismissal between the first and second presented screens.
Change the App file's content view to VanillaContentView to see the expected behavior.

import ComposableArchitecture
import SwiftUI

public struct AppFeature: Reducer {
    public struct Destination: Reducer {
        public enum State: Equatable {
            case first(FirstDestination.State)
            case second(SecondDestination.State)
        }

        public enum Action: Equatable {
            case first(FirstDestination.Action)
            case second(SecondDestination.Action)
        }

        public var body: some ReducerOf<Self> {
            Scope(state: /Destination.State.first, action: /Destination.Action.first) {
                FirstDestination()
            }
            Scope(state: /Destination.State.second, action: /Destination.Action.second) {
                SecondDestination()
            }
        }
    }

    public struct State: Equatable {
        public var text: String = "Press Me"
        @PresentationState public var destination: Destination.State?
    }

    public enum Action {
        case presentButtonTapped
        case destination(PresentationAction<Destination.Action>)
    }

    struct Core: Reducer {
        func reduce(into state: inout State, action: Action) -> Effect<Action> {
            switch action {
            case .presentButtonTapped:
                state.destination = .first(.init())
                return .none

            case .destination(.presented(let destinationAction)):
                switch destinationAction {
                case .first(.nextTapped):
                    state.destination = .second(.init())
                    return .none

                case .second(.dismissTapped):
                    state.destination = nil
                    return .none
                }

            case .destination(.dismiss):
                return .none
            }
        }
    }

    public var body: some ReducerOf<Self> {
        Core()
            .ifLet(\.$destination, action: /Action.destination) {
                Destination()
            }
    }
}

public struct FirstDestination: Reducer {
    public struct State: Equatable {}

    public enum Action: Equatable {
        case nextTapped
    }

    public var body: some ReducerOf<Self> {
        EmptyReducer()
    }
}

public struct SecondDestination: Reducer {
    public struct State: Equatable {}

    public enum Action: Equatable {
        case dismissTapped
    }

    public var body: some ReducerOf<Self> {
        EmptyReducer()
    }
}

public struct ContentView: View {
    let store: StoreOf<AppFeature> = .init(initialState: .init(), reducer: AppFeature())

    public var body: some View {
        WithViewStore(store, observe: \.text) { textViewStore in
            Button(textViewStore.state) {
                textViewStore.send(.presentButtonTapped)
            }
        }
        .fullScreenCover(
            store: store.scope(
                state: \.$destination,
                action: AppFeature.Action.destination
            )
        ) { destinationStore in
            SwitchStore(destinationStore) {
                CaseLet(
                    state: /AppFeature.Destination.State.first,
                    action: AppFeature.Destination.Action.first
                ) { firstStore in
                    WithViewStore(firstStore, observe: { $0 }) { viewStore in
                        Button("Next View") {
                            viewStore.send(.nextTapped)
                        }
                        .tint(.cyan)
                    }
                }

                CaseLet(
                    state: /AppFeature.Destination.State.second,
                    action: AppFeature.Destination.Action.second
                ) { secondStore in
                    WithViewStore(secondStore, observe: { $0 }) { viewStore in
                        Button("Dismiss") {
                            viewStore.send(.dismissTapped)
                        }
                        .tint(.red)
                    }
                }
            }
        }
    }
}

public struct VanillaContentView: View {
    @State var state: AppFeature.State = .init()

    public var body: some View {
        Button("Press Me") {
            state.destination = .first(.init())
        }
        .fullScreenCover(unwrapping: $state.destination, onDismiss: { state.destination = nil }) { $destination in
            if let _ = Binding(unwrapping: $destination, case: /AppFeature.Destination.State.first) {
                Button("Next View") {
                    state.destination = .second(.init())
                }
                .tint(.cyan)
            }
            if let _ = Binding(unwrapping: $destination, case: /AppFeature.Destination.State.second) {
                Button("Dismiss") {
                    state.destination = nil
                }
                .tint(.red)
            }
        }
    }
}

The Composable Architecture version information
prerelease/1.0
Destination operating system
iOS 16.4
Xcode version information
Xcode 14.3
Swift Compiler version information
No response

Hey @junebash! I'm afraid this is the expected behavior in vanilla, where the change of ID triggers a re-presentation. I have a pending PR in swift-navigation that replicates this behaviors for .fullscreenCover(unwrapping:…), but it wasn't merged yet. It was baked-in TCA
This is a behavior I personally find counter-intuitive, and I would expect the same as you are, but if we follow vanilla behavior, I'm afraid we'll have to replicate it.

So in that case, is there any way using TCA to get the desired behavior of not dismissing and re-presenting when the destination changes?

Interesting! Looking at the APIs, I find that behavior surprising; I would expect two different fullScreenCover modifiers to produce two separate presentations, and one fullScreenCover to produce only one presentation, but it seems that it's the opposite. Is that how vanilla SwiftUI is as well? (I realize now my "vanilla" example really isn't quite "vanilla".)
In any case, even though it feels counterintuitive to me, that does indeed give me a solution. Thanks!

We too were a little surprised by it and we want to look into it more. I'm going to convert this to a discussion, and we this documented in our notes to look at before final release. Also please let us know if you uncover anything else.


Revert "chore: disable renovate"

Reverts 9renpoto/.59-node#1724

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.556%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
25

Relevant Lines:
42

💛  - Coveralls


Define boundary conditionts 9

Conditional to eventual comments on pull request #32, this pull request is ready for review.
If any fixes are needed for pull request #32, those can be propagated to this pull request #34.

@aronnoordam I am implementing the changes in a new pull request in which I am a bit refracturing the repo.
Will make an intermediate pull request soon enough, but this pull request is superseded.

@aronnoordam I am implementing the changes in a new pull request in which I am a bit refracturing the repo.
Will make an intermediate pull request soon enough, but this pull request is superseded.

I don't completely understand. Do you mean that I have to wait reviewing this PR until the other PR is merged?


fix: fix native optimization

Fixes #89
It also enables most of the features in the CI for testing.

Thanks for the quick action! Will you generate a release for this fix?

You're welcome. Yes, I will. I have requested @ddalcino's review as well to confirm the bug fix.

Thanks for the quick action! Will you generate a release for this fix?

You're welcome. Yes, I will. I have requested @ddalcino's review as well to confirm the bug fix.

Cool :)

I separated the questionable part of this PR. This can be merged as is.


Add a command buffer to re-execute similar commands

Similar to traditional terminals, navigate the buffer with up/down arrows

resolved by c6c64c8468ba48f8a1d1fa87543dc721faa6bc37


justify-content: space-evenly

Report

[x] I have searched existing issues and this is not a duplicate

In the css flexbox guide it mentions space-evenly as an option for pretty grids.
justify-content: space-evenly;

It would be really cool to see this in yoga / react native.
Issues and Steps to Reproduce
Screen capture:

Expected Behavior
N/A
Actual Behavior
N/A
Link to Code
N/A

Didn't knew this was a thing 😄 . See #658 . Thanks for the hint @aj0strow

@woehrl01 thank you! my goodness that was fast


Geocoder.search returns empty result for some addresses

Expected behavior
Running in rails console
Geocoder.search("24 rue de Chaligny,Paris") should return response with latitude longitude and more infos...
Actual behavior
empty result
irb(main):002:0> Geocoder.search("24 rue de chaligny,Paris")
=> []

Steps to reproduce
Run in rails console : Geocoder.search("24 rue de Chaligny,Paris")
Environment info
Geocoder version: 1.5.1
Rails version: 6

Any workaround or something ?

Sorry, looks like you'll need to configure a different :lookup with better coverage in the Paris area. Please see the API guide for choices.

It's not only for Paris it doesn't work too for this adress for exemple :
84 poruthota road, negombo, Sri Lanka.
Le lun. 30 sept. 2019 à 20:50, Alex Reisner<EMAIL_ADDRESS>a
écrit :

Sorry, looks like you'll need to configure a different :lookup with
better coverage in the Paris area. Please see the API guide
https://github.com/alexreisner/geocoder/blob/master/README_API_GUIDE.md
for choices.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexreisner/geocoder/issues/1410?email_source=notifications&email_token=ABPJ5GHM4Y2XLGUGTOJWYFLQMJC73A5CNFSM4IY3REW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76WF3A#issuecomment-536699628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPJ5GHSTDXTVRROKYJD34LQMJC73ANCNFSM4IY3REWQ
.

Yes, I understand. But this is an issue with the API, not with the Geocoder gem. All the APIs have very different coverage areas. You'll have to pick the one that works best for your application.


Update me-shim.js

options property is having reference of mejs.MediaElementDefaults.
Extending the options with o parameter will override the mejs.MediaElementDefaults properties.
in result, multiple use of mejs.MediaElementDefaults in multiple instances cause the unexpected result.

Thanks for pointing this out. It's a great idea. The only problem is that the core MediaElement object is designed to be used without jQuery, so this needs to be done without a references to $.


Twitter Post with video and picture

so now there twitter premium they can post video with picture too! but it not gonna work when use tvdl shorcut. hopefully you can update. love ya shorcut <3

Hi @dinouse, yes that's a feature that I am currently considering. It's a little more complicated though.


NO_TICKET: Several client nitpicks

This PR covers several points:

The rustdocs for the library and help strings for the binary were all reviewed and consistent terminology used throughout
The README was fixed (it hadn't been updated after the renaming of global_state_hash)
Since the PR to warp-json-rpc has been merged and published, the node can now handle strings as the RPC IDs, making it compliant with the JSON-RPC spec.  The client has been updated to take advantage of this.
Simple session args and payment args need to be wrapped in double quotes to be parsed correctly; the help strings were updated to cover this
The node_address arg now has trailing /s removed, meaning values like http://localhost:7777/ now succeed

bors r+


error: Module "mymodule" has no exported member "mycomponent"  after upgrading to angular 16

Which @angular/* package(s) are the source of the bug?
core, Don't known / other
Is this a regression?
Yes
Description
i am using an angular workspace with a blend of applications and libraries of my own which are used by these applications. My workspace configuration/structure is the same since i started the project with angular 10 (some changes along the way at each upgrade but nothing major).
but today after migrating to 16, one and only of my libraries failed to be imported in my application, the other libraries are imported just fine. I can't find any differences in the way they are configured though, particularly in angular.json.
this is how it is imported :  import { DesignerComponent } from 'process';
I get the error below.
If I import it like this :
import { DesignerComponent } from '../../../../../process/src/lib/designer/designer.component';
then it compiles just fine
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
error TS2305: Module '"process
"' has no exported member 'DesignerComponent'.

15 import { DesignerComponent } from 'process';

Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 16.1.7
Node: 16.16.0
Package Manager: npm 8.11.0
OS: win32 x64

Angular: 16.1.8
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1601.7
@angular-devkit/build-angular   16.1.7
@angular-devkit/core            16.1.7
@angular-devkit/schematics      16.1.7
@angular/cdk                    16.1.7
@angular/cli                    16.1.7
@schematics/angular             16.1.7
ng-packagr                      16.1.0
rxjs                            7.8.1
typescript                      4.9.5
zone.js                         0.13.1

Anything else?
No response

process is a builtin Node module, which is likely confusing the module resolver. I would highly recommend to avoid using builtin modules as name of your own packages. The typical approach of avoiding name conflicts is to make use of a scoped  package name, e.g. @my-scope/process.

really ? is it a new module in angular 16 ? because i never had this issue before
my package is called indeed @my-scope/process and this is how it is imported when used in applications that are outside my workspace
however for applications inside the same workspace i import it as 'process'.   will try to rename to see if it makes a difference

It is a builtin Node module since forever. It could be that module resolution or project configuration changed in subtle ways that has resulted in a change of behavior.

@JoostK  Thanks man ! this was it 👍   I renamed it to process-designer and now it compiles just fine. Funny this has never occured before this upgrade.


Typo "resouce"→"resource"

https://github.com/microsoft/dotnet/blob/main/releases/UWP/net-native2.2/README.md
#PingMSFTDocs

Good to merge @danmoseley?

whoops, not sure why I didn't do that


Possible unused Font

I found Clash Display but its not configured in app.css and is nowhere used in the Site 😕

Thanks for pointing it out! I initially wanted to use Clash Display as a display font but I decided against it in the end. I've now removed the unused Clash Display font in a new update to the repo. Hope this helps :)


Test pandas 1.1.x / 1.2.0 releases and pandas nightly

Thanks for starting this, I've been a bit busy lately :)

I fixed some of the obvious ones. Mind if I push?

Great, feel free to push!
Some notes about the failures I already investigated up to now:

I identified one regression in pandas related to merge -> https://github.com/pandas-dev/pandas/issues/38616
The failures related to reduction ufuncs with np.prod seems to be caused by the fact that we now execute this column-wise (or actually dtype block-wise) by implementing DataFrame.__array_ufunc__ (https://github.com/pandas-dev/pandas/issues/38616), and np.prod overflows on integer columns, while before those integer columns were cast to float if there was also a float column present (as is the case in the test), not having this overlfow issue.
This is probably an acceptable side effect of implementing DataFrame.__array_ufunc__, in which case the test need to be updated.

I was just reading the Future Warrnings and trying to fix up any that I could.

The following failure is due to https://github.com/pandas-dev/pandas/issues/28507, comparing tz-naive and tz-aware timestamp no longer raises an error, but returns False:
 ___________________________ test_set_index_timezone ____________________________

    def test_set_index_timezone():
        s_naive = pd.Series(pd.date_range("20130101", periods=3))
        s_aware = pd.Series(pd.date_range("20130101", periods=3, tz="US/Eastern"))
        df = pd.DataFrame({"tz": s_aware, "notz": s_naive})
        d = dd.from_pandas(df, 2)

        d1 = d.set_index("notz", npartitions=1)
        s1 = pd.DatetimeIndex(s_naive.values, dtype=s_naive.dtype)
        assert d1.divisions[0] == s_naive[0] == s1[0]
        assert d1.divisions[-1] == s_naive[2] == s1[2]

        # We currently lose "freq".  Converting data with pandas-defined dtypes
        # to numpy or pure Python can be lossy like this.
        d2 = d.set_index("tz", npartitions=1)
        s2 = pd.DatetimeIndex(s_aware, dtype=s_aware.dtype)
        assert d2.divisions[0] == s2[0]
        assert d2.divisions[-1] == s2[2]
        assert d2.divisions[0].tz == s2[0].tz
        assert d2.divisions[0].tz is not None
        s2badtype = pd.DatetimeIndex(s_aware.values, dtype=s_naive.dtype)
        with pytest.raises(TypeError):
>           d2.divisions[0] == s2badtype[0]
E           Failed: DID NOT RAISE <class 'TypeError'>

dask/dataframe/tests/test_shuffle.py:650: Failed

For the failing dask/dataframe/tests/test_arithmetics_reduction.py::test_reductions_non_numeric_dtypes, that's because std() is now implemented for datetime dtype.

For the failing dask/dataframe/tests/test_arithmetics_reduction.py::test_reductions_non_numeric_dtypes, that's because std() is now implemented for datetime dtype.

It seems reasonable to me to just skip that test for this case until someone gets around to implementing it. The dask implementation depends on var, which pandas doesn't yet have for datetime.

It seems reasonable to me to just skip that test for this case until someone gets around to implementing it. The dask implementation depends on var, which pandas doesn't yet have for datetime.

Indeed, that sounds best. We should open an issue for that on the pandas side.
The parquet failures are a bit strange: I can reproduce them locally in an environment with pandas 1.2.0rc, but it seems I also get the same failure with the latest stable pandas (but here on CI there is no such failure). So there might be an interaction with another library version in play, don't directly see it.

The parquet failures are a bit strange

I have been seeing the parquet failures locally for a while. I can't tell if it is related to pandas version or not. I don't think dask has been doing any tests against pandas > 1.0.* except for the upstream ones which have been failing for a while #6148

Ah, indeed, it's already failing on pandas 1.1, but passing on pandas 1.0. So basically writing a partitioned parquet dataset where the partition column is categorical dtype is completely broken.

I don't think dask has been doing any tests against pandas > 1.0.*

Ai .. pandas 1.1 is a half year old, so we probably should have been testing that ..

I opened https://github.com/pandas-dev/pandas/issues/38642 for this on the pandas side.

So basically writing a partitioned parquet dataset where the partition column is categorical dtype is completely broken.

Maybe we should xfail those tests for now while the conversation goes on

I think we are mostly down to the ufunc tests. It sounds like you have in mind how to fix them?

Ah no, there are failures on https://github.com/dask/dask/pull/6996/checks?check_run_id=1597495686 now as well. Maybe the sparse skip in https://github.com/dask/dask/pull/6996/commits/90de1b4bb744023e19883fd02e8210bd1b2cfc1a should be more nuanced?

Some additional parquet tests are failing using pandas nightly, which is caused by a recent change on pandas master, reported as https://github.com/pandas-dev/pandas/issues/38944.
Will include a fix for that here.

Some additional parquet tests are failing using pandas nightly, which is caused by a recent change on pandas master, reported as https://github.com/pandas-dev/pandas/issues/38944.
Will include a fix for that here.

Ok, @jorisvandenbossche I am going to leave it with you for now. Let me know if there are any parts that you want me to handle.

Ok, @jorisvandenbossche I am going to leave it with you for now. Let me know if there are any parts that you want me to handle.

@jsignell If you could look into the sparse failures, that would be very welcome

@jsignell If you could look into the sparse failures, that would be very welcome

Also, I now pinned pandas to 1.0.x in the 3.7 env, and to 1.1.x in the 3.8 env (and kept 0.25.x in the 3.6 env). Ideally, we would also pin to 1.2.x in one of the envs, but there are only 3 different env files used for the basic CI at the moment. Any ideas how to best handle this?

Also, I now pinned pandas to 1.0.x in the 3.7 env, and to 1.1.x in the 3.8 env (and kept 0.25.x in the 3.6 env). Ideally, we would also pin to 1.2.x in one of the envs, but there are only 3 different env files used for the basic CI at the moment. Any ideas how to best handle this?

Ideally, we would also pin to 1.2.x in one of the envs

Shouldn't upstream handle this for now?

Ideally, we would also pin to 1.2.x in one of the envs

Shouldn't upstream handle this for now?

I changed the upstream test to use the actual pandas nightly build instead of the release candidate (since the final 1.2.0 release is out now, we shouldn't be testing the release candidate anymore). I could of course use plain pandas 1.2.0 in the upstream build, but I think that's not really the goal of the upstream build? (released pandas should be tested in normal CI builds?)

I changed the upstream test to use the actual pandas nightly build instead of the release candidate (since the final 1.2.0 release is out now, we shouldn't be testing the release candidate anymore). I could of course use plain pandas 1.2.0 in the upstream build, but I think that's not really the goal of the upstream build? (released pandas should be tested in normal CI builds?)

I could of course use plain pandas 1.2.0 in the upstream build, but I think that's not really the goal of the upstream build?

Yeah you are right. I am not sure how dask wants to handle testing against so many minor versions of pandas. I guess we could add another job to the test matrix, but that feels like overkill. Is it really necessary to test each minor version of pandas?

I could of course use plain pandas 1.2.0 in the upstream build, but I think that's not really the goal of the upstream build?

Yeah you are right. I am not sure how dask wants to handle testing against so many minor versions of pandas. I guess we could add another job to the test matrix, but that feels like overkill. Is it really necessary to test each minor version of pandas?

@jorisvandenbossche I checked with some other dask maintainers and the consensus for implicit date slices is that we should follow pandas. Should I go ahead and make that change in this PR?

@jorisvandenbossche I checked with some other dask maintainers and the consensus for implicit date slices is that we should follow pandas. Should I go ahead and make that change in this PR?

Since this is already a mix of quite some changes, maybe rather keep it for a separate PR if that's OK? (but don't care too much, for the tests it might be easier to do it here)

Since this is already a mix of quite some changes, maybe rather keep it for a separate PR if that's OK? (but don't care too much, for the tests it might be easier to do it here)

:+1: I'm fine separating it out. My preference is to finish this first and then make behavior changes after this is merged.

:+1: I'm fine separating it out. My preference is to finish this first and then make behavior changes after this is merged.

Almost green! ;)
The windows failure is a "RuntimeWarning('overflow encountered in ldexp')" from applying a ufunc on a pandas series, and that gets elevated from warning to error. Will add a filter for that.
For the upstream build, I added a bunch of filterwarnings for deprecations, which can be further addressed in follow-up PRs. I also catched another regression on pandas master, reported as https://github.com/pandas-dev/pandas/issues/38944

Almost green! ;)
The windows failure is a "RuntimeWarning('overflow encountered in ldexp')" from applying a ufunc on a pandas series, and that gets elevated from warning to error. Will add a filter for that.
For the upstream build, I added a bunch of filterwarnings for deprecations, which can be further addressed in follow-up PRs. I also catched another regression on pandas master, reported as https://github.com/pandas-dev/pandas/issues/38944

Almost green!

Yeah! There is still an issue with sparse in the upstream as well. But I am happy to merge this once the regular tests pass.

Almost green!

Yeah! There is still an issue with sparse in the upstream as well. But I am happy to merge this once the regular tests pass.

(will still add 1.2.0 in one of the envs before merging)

(will still add 1.2.0 in one of the envs before merging)

There was a mystery for a moment, as I needed to remove/update the skips for the categorical failures we had above, and I also could no longer reproduce it locally (which I was able to do 3 weeks ago, according to the comments above).
But it turns out that the latest fastparquet release which came out in the meantime as a side effect of another PR (https://github.com/dask/fastparquet/commit/e7abbb91777e52922bf2b3032f2784bf70e19b44) also fixed the regression caused by the pandas groupby indices regression.

There was a mystery for a moment, as I needed to remove/update the skips for the categorical failures we had above, and I also could no longer reproduce it locally (which I was able to do 3 weeks ago, according to the comments above).
But it turns out that the latest fastparquet release which came out in the meantime as a side effect of another PR (https://github.com/dask/fastparquet/commit/e7abbb91777e52922bf2b3032f2784bf70e19b44) also fixed the regression caused by the pandas groupby indices regression.

Is there anything I can do to help with this?

Is there anything I can do to help with this?

I've been able to successfully apply this to the Fedora dask package for testing in Rawhide, and it appears to pass tests with Pandas 1.2.0 fine. Other than a rebase/merge, not sure if anything else needs to be done here.

I've been able to successfully apply this to the Fedora dask package for testing in Rawhide, and it appears to pass tests with Pandas 1.2.0 fine. Other than a rebase/merge, not sure if anything else needs to be done here.

cc @crusaderky

cc @crusaderky

Merged master to resolve conflicts.
I think the last remaining item for this PR is https://github.com/dask/dask/pull/6996#discussion_r555066971: the rolling tests are failing once in every few runs (a floating point precision issue, setting the tolerance in the assert to a higher value might solve it, but it's still potentially worth investigating why it fails with pandas 1.2 and not with other versions)
In addition, there are a few follow-ups required (things for which I only added a workaround or skip in this PR), but will list those in a new issue.

Merged master to resolve conflicts.
I think the last remaining item for this PR is https://github.com/dask/dask/pull/6996#discussion_r555066971: the rolling tests are failing once in every few runs (a floating point precision issue, setting the tolerance in the assert to a higher value might solve it, but it's still potentially worth investigating why it fails with pandas 1.2 and not with other versions)
In addition, there are a few follow-ups required (things for which I only added a workaround or skip in this PR), but will list those in a new issue.

See eg the failure in the last builds: https://github.com/dask/dask/pull/6996/checks?check_run_id=1730329886#step:5:192 (here it failed in the Mac build, but it's not Mac-specific, it failed before on Linux as well)

See eg the failure in the last builds: https://github.com/dask/dask/pull/6996/checks?check_run_id=1730329886#step:5:192 (here it failed in the Mac build, but it's not Mac-specific, it failed before on Linux as well)

setting the tolerance in the assert to a higher value might solve it

There are other places where we have upped the tolerance for specific pandas versions. https://github.com/dask/dask/blob/72304a94c98ace592f01df91e3d9e89febda307c/dask/dataframe/tests/test_rolling.py#L263:L270 we should probably do something similar here.

setting the tolerance in the assert to a higher value might solve it

There are other places where we have upped the tolerance for specific pandas versions. https://github.com/dask/dask/blob/72304a94c98ace592f01df91e3d9e89febda307c/dask/dataframe/tests/test_rolling.py#L263:L270 we should probably do something similar here.

I'm going to up the tolerance on the rolling precision tests so that we can hopefully get this in before the release on friday.

I'm going to up the tolerance on the rolling precision tests so that we can hopefully get this in before the release on friday.

I think we should change back "run upstream every time" and merge this.

I think we should change back "run upstream every time" and merge this.

Thanks for those last updates! I think it's then indeed good to to be merged.
(I will create an issue with the follow-up tasks identified here)

Thanks for those last updates! I think it's then indeed good to to be merged.
(I will create an issue with the follow-up tasks identified here)

hmm the special commit message for test-upstream doesn't seem to work as expected. That isn't this PR's job though. Will merge when green.

hmm the special commit message for test-upstream doesn't seem to work as expected. That isn't this PR's job though. Will merge when green.

I pushed an empty commit to try to get the tests to pass.

I pushed an empty commit to try to get the tests to pass.

@jorisvandenbossche :clap: :clap: merged!

@jorisvandenbossche :clap: :clap: merged!

And opened the follow-up issue now listing all outstanding issues to resolve: https://github.com/dask/dask/issues/7100

And opened the follow-up issue now listing all outstanding issues to resolve: https://github.com/dask/dask/issues/7100


Browserify cherry picking

What is the recommended way to import these decorators using Browserify?
I'm cherry picking the chain decorator so that the others won't need to be included in my app bundle.
This works but looks odd:
import { chain } from 'js-deco/dist/commonjs/chain'

Wondering if there is a better way?
Also, what is the difference with the underscore version? E.g. _chain

FYI the syntax shown in README does not work with Browserify.
import { chain } from 'js-deco'

Error: Cannot find module 'js-deco' from '/Users/seb/GitHub/cofounders/lgtm/src/frontend'

Been a while since I used JSPM so not immediately sure where the conflict lies. Ideas?


quantization process takes too long

during the ptq process, it only use 1 gpu, although i have set 4 gpus in the config file (i have 4 gpus installed).
it takes almost 52 hours to quantize my 8B flux model (the Step 3 in your readme) using a L40s gpu, is this normal?
can we accelerate the ptq process by quantizing blocks parallelly on different gpus?
thanks.

Hi, i encountered OOM problem when running step 3 on a single L40s gpu. How did you solve it?

Maybe because my flux model is smaller, only 8B, and my L40s gpu has 45GB memory, it is enough.

Maybe because my flux model is smaller, only 8B, and my L40s gpu has 45GB memory, it is enough.

Thanks for reply, i also use pixart-sigma, 800M parameters, encountered OOM on 45GB L40s gpu too. I use the original config yaml, should i modify it?

there is a

batch_size: 256

in the config file, maybe the batch size is too large for your device.

thanks for your advice. i run sdxl-turbo on my gpus, but it costs many hours. Waiting for parallel acceleration too :)

Hi

during the ptq process, it only use 1 gpu, although i have set 4 gpus in the config file (i have 4 gpus installed).
it takes almost 52 hours to quantize my 8B flux model (the Step 3 in your readme) using a L40s gpu, is this normal?
can we accelerate the ptq process by quantizing blocks parallelly on different gpus?
thanks.

Hello @yyfcc17 , I didn't see where we can set the gpu number in the config files. May I ask how you set this?

Hi

during the ptq process, it only use 1 gpu, although i have set 4 gpus in the config file (i have 4 gpus installed).
it takes almost 52 hours to quantize my 8B flux model (the Step 3 in your readme) using a L40s gpu, is this normal?
can we accelerate the ptq process by quantizing blocks parallelly on different gpus?
thanks.

Hello @yyfcc17 , I didn't see where we can set the gpu number in the config files. May I ask how you set this?

it's in examples/diffusion/configs/__default__.yaml, seems only for evaluation


[Compute] Disk encryption set: add --enable-auto-key-rotation

Description

Resolve https://github.com/Azure/azure-cli/issues/17064
Resolve https://github.com/Azure/azure-cli/issues/17063
Python SDK is not ready.
    --enable-auto-key-rotation     : Enable automatic rotation of keys.  Allowed values: false,
                                     true.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

/azp run


Should I use transaction around modify?

Hello, there is my  db schema
db.version(1).stores({
  planner_documents: `id&, room_id, idempotency_key&`,
});

I want to modify one of documents, maybe in multiple browser tabs, how to make it safe?
Do I  need explicit transaction like
async function save_serialized_doc(doc_id, content, position) {
  return await db.transaction("rw", db.planner_documents, async () => {
    await db.planner_documents
      .where({ id: doc_id })
      .and((e) => !e.last_saved_id || e.last_saved_id < position)
      .modify({ saved_document: content, last_saved_id: position });
  });
}

If you only do a single expression, like your sample shows, explicit transaction is not needed - the modify operation will perform an implicit transaction around the whole querying and modification parts anyway.

Note: This regards to the atomicity of it (which I suppose was the doubt in your case). If isolation is considered it's another story and there would be a difference, at least in Dexie 4 with the default optimistic cache enabled.
If you would have an ongoing liveQuery, it may react to the change before the implicit transaction commits, which could theoretically manifest in a temporary successful change that later on disappears if the implicit transaction finally fails. Should this be a consideration and you absolutely need full isolation also against liveQueries observing the data, an explicit transaction will make a difference and provide full isolation and only wake up live queries after the transaction commits.

Hm, would the livequery be restarted after transaction fail?

Hm, would the livequery be restarted after transaction fail?

Yes, if the livequery was optimistically notified about the operation but and then finally the implicit transaction fails for some reason, the livequery will be retriggered with data according to reverted operation.


[Bug]: mercure.hub.default doesn't exists.

What happened?
If you haven't installed the symfony mercure bundle you get:
The service "Drinksco\ConsoleUiBundle\EventListener\CommandWatcher" has a d
!!    ependency on a non-existent service "mercure.hub.default".
Installing the bundle solves it, but maybe it could be added as a dependency?
Edit:
I also encountered the following problems:
Warning: Undefined array key "MERCURE_HOST"
and after setting a dummy host in my .env file
sh: 1: exec: ./mercure: not found
Steps To Reproduce
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow our user Code of Conduct

Hi @arnedesmedt, thank you for taking the time to open an issue :raised_hands:.

Installing the bundle solves it, but maybe it could be added as a dependency?

It is https://github.com/drinksandco/symfony-console-ui/blob/main/composer.json#L8. The issue is in the docs. Also, with Symfony Flex installed, Mercure Hub requires downloading its binary. You can find it here. Take care of downloading the legacy version for your SO. Then extract the binary in the project root directory. We documented it in the section on how to install without using flex. We must put it on the flex side too.
In the next version, we will have implemented the Symfony Docker integration https://github.com/drinksandco/symfony-console-ui/pull/12, it will be easier to run.

Warning: Undefined array key "MERCURE_HOST"

We use three new environment variables, as in the first case, a lack of documentation at the early stage of the project. When we have the Flex recipe, it will set up all configs automatically. Since that point, I suggest following the installation without Flex instructions.

I will rework the service requirement to not use the default hub. It also creates issues on the Symfony recipe. We better add our own service definition as we did with the queue connection.
Thanks again for opening the issue.

I will rework the service requirement to not use the default hub. It also creates issues on the Symfony recipe. We better add our own service definition as we did with the queue connection.
Thanks again for opening the issue.


adds a date to the blog post

I think this was deliberate according to https://github.com/digital-land/digital-land.github.io/commit/0f5f29f587503f95aae4a11a2e95765603b53af3.

Addressed in https://github.com/digital-land/digital-land.github.io/commit/1478a72d776b7f10902cfb43c32bd4f1a1385f0a


[Bug]: Regex suggest invalid completion

Description
import ballerina/lang.regexp;
public function main() {
    regexp:RegExp _ = re ``<cursor>;
}

Gives invalid completions as (), [], ^
Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This happens for the below case as well,
string:RegExp _ = re <cursor>``;


Vite HMR issue since 0.22.0

Description
Since v0.22.0, there seems to be a bug with PandaCSS + Vite dev server.
I am unsure if it's Vite, Panda, or a combination, but downgrading to v0.21.0 resolves the issue.
Issue:
Whenever I change a file, a style or anything that triggers a Hot Module Reload, the initial few HMRs are fast but become increasingly slower with every update.
After 10-20 HMR, the browser hangs, trying to load the index.css file that contains the Panda layer rules.
I've tried anything I could think of, downgrading several packages, including Vite, disabling Mock Service Worker and numerous other things, but downgrading to Panda v.0.21.0 resolves the issue.
I cannot serve a concrete reproduction of the issue, but I hope you have enough context to possibly debug what happened after v0.21.0 or find that this is entirely unrelated to PandaCSS.
Project relevant deps:

Vite 5.0.10
Turborepo 1.11.2
Typescript 5.3.3

Steps to reproduce
N/A.
JS Framework
React (TS)
Panda CSS Version
0.22.0
Browser
Chrome latest
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information

hey, we're aware there was a perf regression for the HMR, we're actively working on it here
https://github.com/chakra-ui/panda/pull/1860


Fix browserify-versionify dependency

As is the case in the current Pixi
https://github.com/pixijs/pixi.js/blob/master/package.json#L35
browserify-versionify is picked up when it's a dependency, not a dev dependency.  Tried against the latest version of browserify.

Good catch @BrianRosamilia 👍


[Feature] Table of Contents Markdown Support

The idea is to support relative link via fragments like on some npmjs repos - this would improve usability of the README page but really it's just a "nice-to-have".
# Table of Contents
1. [Example](#example)
2. [Example2](#example2)
3. [Third Example](#third-example)

## Example
## Example2
## Third Example

Clicking on "Example2" would auto scroll to the "Example2" section of the page.

Something like GitHub and npmjs does, yeah, I think is handy. Do you know what library they use for it?

It might be this one https://github.com/github/markup

Oh that is just the library to determine what library to use. Looks like they use https://github.com/gjtorikian/commonmarker for markdown files. It's a ruby library so it might not be the best for integration with verdaccio

I use mod-markdown as an Apache mod which I think uses Discount markdown engine, which is in C, which in turn is a port of a python markdown lib, I cant recall then name.  But yes, this feature would be great!


We don't need to consider angle

In the elastic_collision.py file, you have include a variable angle, since we are doing the one dimensional elastic collision, I don't think it is necessary to consider angle there.

@LinxuanHu Yes, you are right. I will be removing those extra variables.

@LinxuanHu Merge request sent.


TEST-#2290: Cover by tests General Parsing Configuration parameters of read_csv

Signed-off-by: Alexander Myskov<EMAIL_ADDRESS>
What do these changes do?
This PR adds tests related to General Parsing Configuration parameters of read_csv function, removes duplicated tests, slightly modifies get_unique_filename function (file uniqueness occurred now by getting of kwargs dict hash, not a values as it was before) and detaches test_io.py tests into the separate CI job (number of io tests is big enough now and will be increased in the nearest future).

[x] commit message follows format outlined here
[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #2290
[x] tests added and passing

Problem was found for the CI case: test-ubuntu io part (engine dask, python 3.8):
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/queues.py", line 245, in _feed
    send_bytes(obj)
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 200, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 411, in _send_bytes
    self._send(header + buf)
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
BrokenPipeError: [Errno 32] Broken pipe

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: https://github.com/modin-project/modin/issues/2008.

There is a lot of tests that x-passed, almost 30% of all that marked as x-failed, maybe we can somehow move those cases in a separate test without xfail mark?
1364 passed, 10 skipped, 895 xfailed, 342 xpassed

Problem was found for the CI case: test-ubuntu io part (engine dask, python 3.8):
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/queues.py", line 245, in _feed
    send_bytes(obj)
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 200, in send_bytes
    self._send_bytes(m[offset:offset + size])
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 411, in _send_bytes
    self._send(header + buf)
  File "/usr/share/miniconda/envs/modin/lib/python3.8/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
BrokenPipeError: [Errno 32] Broken pipe

Now all tests are passing, looks like this fail wasn't caused by PR changes.

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: #2008.

Now all CI passes for ~45 mins, number of parallel jobs is increased by 21 (55 number of parallel jobs max now). Should it take into account that many PRs can be tested on one tier?

There is a lot of tests that x-passed, almost 30% of all that marked as x-failed, maybe we can somehow move those cases in a separate test without xfail mark?
1364 passed, 10 skipped, 895 xfailed, 342 xpassed

Test suit was reworked, so now number of xpassed tests is reduced to 26 (also test_read_csv_col_handling xfailed tests were marked as skipped - there are many test combination of parameters with ray engine fails, so all test_read_csv_col_handling tests were marked as xfailed, see https://github.com/modin-project/modin/issues/2312).

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: #2008.

Now all CI passes for ~45 mins, number of parallel jobs is increased by 21 (55 number of parallel jobs max now). Should it take into account that many PRs can be tested on one tier?

It's too much. At the moment it is better not to add additional jobs in ci.yml, push.yml.

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: #2008.

Now all CI passes for ~45 mins, number of parallel jobs is increased by 21 (55 number of parallel jobs max now). Should it take into account that many PRs can be tested on one tier?

It's too much. At the moment it is better not to add additional jobs in ci.yml, push.yml.

Ok, then there are several ways we can use to decrease the time of test_io.py tests:

We can split big test suits into smaller groups. In this case bugs caused by inter parameter influence can be missed.
We can use class scope fixtures to create common for many tests files only once as it was done here. In this case it will be necessary to prohibit parallel tests execution (or find a workaround), because in that case fixture teardown (test files deletion) can be done before tests are competed.
We can decrease the size of test file by decreasing the number of rows (now it's 2000). In that case i suppose we can miss some bugs caused by wrong partitioning (for example if it will be left only one partition). This change can be not so critical if we set small datasets for pre-commit checks and bigger dataset for merged to the master commits.

Using this modifications (or some of them) tests execution time can be decreased and there will be no need to add new CI jobs. So, what do you think about it?

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: #2008.

Now all CI passes for ~45 mins, number of parallel jobs is increased by 21 (55 number of parallel jobs max now). Should it take into account that many PRs can be tested on one tier?

It's too much. At the moment it is better not to add additional jobs in ci.yml, push.yml.

Ok, then there are several ways we can use to decrease the time of test_io.py tests:

We can split big test suits into smaller groups. In this case bugs caused by inter parameter influence can be missed.
We can use class scope fixtures to create common for many tests files only once as it was done here. In this case it will be necessary to prohibit parallel tests execution (or find a workaround), because in that case fixture teardown (test files deletion) can be done before tests are competed.
We can decrease the size of test file by decreasing the number of rows (now it's 2000). In that case i suppose we can miss some bugs caused by wrong partitioning (for example if it will be left only one partition). This change can be not so critical if we set small datasets for pre-commit checks and bigger dataset for merged to the master commits.

Using this modifications (or some of them) tests execution time can be decreased and there will be no need to add new CI jobs. So, what do you think about it?

Yes, we can, but it should be borne in mind that not all parameters are dependent on each other and also that this function is much complicated and, as a rule, a small subset of parameters is used.
What about scope="session"?
We can reduce the number of rows until we know for sure that multiple partition are being created.

How much did the testing time and the maximum number of parallel jobs increase?
We have some limits: #2008.

Now all CI passes for ~45 mins, number of parallel jobs is increased by 21 (55 number of parallel jobs max now). Should it take into account that many PRs can be tested on one tier?

It's too much. At the moment it is better not to add additional jobs in ci.yml, push.yml.

Ok, then there are several ways we can use to decrease the time of test_io.py tests:

We can split big test suits into smaller groups. In this case bugs caused by inter parameter influence can be missed.
We can use class scope fixtures to create common for many tests files only once as it was done here. In this case it will be necessary to prohibit parallel tests execution (or find a workaround), because in that case fixture teardown (test files deletion) can be done before tests are competed.
We can decrease the size of test file by decreasing the number of rows (now it's 2000). In that case i suppose we can miss some bugs caused by wrong partitioning (for example if it will be left only one partition). This change can be not so critical if we set small datasets for pre-commit checks and bigger dataset for merged to the master commits.

Using this modifications (or some of them) tests execution time can be decreased and there will be no need to add new CI jobs. So, what do you think about it?

Yes, we can, but it should be borne in mind that not all parameters are dependent on each other and also that this function is much complicated and, as a rule, a small subset of parameters is used.
What about scope="session"?
We can reduce the number of rows until we know for sure that multiple partition are being created.

Class scope fixture was implemented (works fine both in parallel and sequential modes) and number of rows in test files was decreased, so now TestReadCSV tests take <30 seconds locally, so think we don't have to split test suite for now.


cut a new gem?

september 2013 is a while ago. any chance you can push a new version to rubygems? thanks a ton! :gem:

Master is working great for me, I've also really appreciate it if you could update the gem on rubygems!


[stable/cert-manager] make the README more helpful

the cert-manager chart's README could use some improvement
https://github.com/kubernetes/charts/blob/master/stable/cert-manager/README.md

the install/uninstall doesn't mention the chart name, so doesn't actually work as described (unless of course someone pulls the chart repo and cd's into this directory, but no other chart expects that in their install/uninstall descriptions so it'd be better to be consistent)
the tl/dr and introduction sections are a bit redundant
but most importantly, the details here about configuring are much more relevant and helpful than anything else in this README: https://github.com/jetstack/cert-manager/blob/master/docs/user-guides/deploying.md#addendum
Maybe it's better to link to this doc from the the helm README, so not creating two locations to maintain. I guess that's a decision for @munnerz who wrote both

/assign

I've opened https://github.com/jetstack/cert-manager/pull/290 upstream to resolve this.
Namely:

I've added some notes to the README that link to how to set up an issuer, as well as configuring ingress-shim
I've included those same notes as part of the NOTES.txt too
Removed 'tl;dr' and introduction sections from README
Updated chart name so we don't advise helm install .


[Java] ListView Implementation for C Data Interface

Describe the enhancement requested
Java ListView integration will contain multiple steps as described in https://github.com/apache/arrow/issues/41271.
Thus supporting C Data Interface is an important component for ListViewVector.
Component(s)
Java

Issue resolved by pull request 43686
https://github.com/apache/arrow/pull/43686


[Spark-17025][ML][Python] Persistence for Pipelines with Python-only Stages

What changes were proposed in this pull request?
Implemented a Python-only persistence framework for pipelines containing stages that cannot be saved using Java.
How was this patch tested?
Created a custom Python-only UnaryTransformer, included it in a Pipeline, and saved/loaded the pipeline. The loaded pipeline was compared against the original using _compare_pipelines() in tests.py.

Test build #80421 has started for PR 18888 at commit 85a98d6.

@jkbradley @MrBago @WeichenXu123 Can you please review this?

Test build #80421 has finished for PR 18888 at commit 85a98d6.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80421/
Test FAILed.

Merged build finished. Test FAILed.

Test build #80426 has started for PR 18888 at commit ba4402c.

Test build #80426 has finished for PR 18888 at commit ba4402c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80426/
Test FAILed.

Test build #80427 has started for PR 18888 at commit 22ebe3e.

Test build #80427 has finished for PR 18888 at commit 22ebe3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80427/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80465 has started for PR 18888 at commit cdcd1cc.

Test build #80465 has finished for PR 18888 at commit cdcd1cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80465/
Test PASSed.

Test build #80513 has started for PR 18888 at commit cf1a08d.

Test build #80513 has finished for PR 18888 at commit cf1a08d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80513/
Test PASSed.

Test build #80547 has started for PR 18888 at commit 18c902c.

Test build #80547 has finished for PR 18888 at commit 18c902c.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PipelineSharedReadWrite():

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80547/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80548 has started for PR 18888 at commit 2b63eea.

LGTM pending tests!

Test build #80548 has finished for PR 18888 at commit 2b63eea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80548/
Test PASSed.

@jkbradley Quick reminder to merge this since the tests have passed!


All elements in window are moving a less or more from right to left after app startup

I've tried all versions, it occurs on my machine at home and on various machines at work.

Can you please make a GIF?

@rabambar Sounds like, that you mean the transition effect. This can be disabled with the MetroWindow Property WindowTransitionsEnabled when you set it to false.

WindowTransitionsEnabled helped. Thx


Detailed descriptive Note in the document

Customer feels that this statement "If you are on version 8.0 or later, there is no longer a data upgrade between application versions." can be more clear and descriptive.
Reference document: https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/migration-upgrade/upgrade-data-to-latest-update?source=docs#feedback

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe0d2c68-08ea-77b8-af74-cd889a8344ca
Version Independent ID: d88b6646-49de-f7eb-3d7c-7d1e700131e1
Content: Upgrade data in development or demo environments - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/migration-upgrade/upgrade-data-to-latest-update.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

@clpurush, thank you for providing this feedback.
@laneswenka, please clarify the note.

@clpurush, thank you for providing this feedback.
@laneswenka, please clarify the note.

Bug 9118719 has been logged in the LCS database.

Bug 9118719 has been logged in the LCS database.

Have made a clear callout to the Rebuild section.  Changes in PR, thanks!


Where does remote stream attach to devices speakers?

We are in need to attach/deattach remote streams to different output devices. Where does that happen? How can one do that?

For example only audio stream?

webrtc seems has it's own audioplayer ( it will initiate it automatically. ) this is the most confused part compares to web audio elements.
I use react-native-incall-manager, it listens devices plug/unplug event and make sure the audio type during flow changes.
But I don't know if you can force audio stream goes through specific devices.

Nothing actionable, closing.


jsoncpp: Broken symlink with enableStatic

Describe the bug
As described in this issue and fixed in this pr, jsoncpp no longer appends _static to the static library path (except under MSVC). This breaks enableStatic, introduced in this pr.
Steps To Reproduce
See attached archive. TLDR:

Make package that depends on pkgs.jsoncpp.override { enableStatic = true; })
Compile and statically link jsoncpp.
Error involving libjsoncpp.a being a broken symlink.

Additional context
Could be fixed by either specifying -DSTATIC_SUFFIX="_static" to cmake or just removing the postInstall hook, not sure which would be preferred.
Notify maintainers

@tfc as the submitter of the original PR, @tteggel @cpages as listed in meta.maintainers.
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.37, NixOS, 23.11 (Tapir), 23.11pre501608.f292b4964cb`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.15.1`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

reproduce.zip

This particular thing is also fixed in this PR: https://github.com/NixOS/nixpkgs/pull/235024

Closing as completed in mentioned PR.


do what the PR says

Codecov Report
Patch coverage: 50.00% and no project coverage change.

Comparison is base (25fb724) 57.52% compared to head (de88e24) 57.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   57.52%   57.52%
=======================================
  Files           8        8
  Lines         565      565
=======================================
  Hits          325      325
  Misses        240      240

Impacted Files
Coverage Δ

src/base.jl
45.27% <0.00%> (ø)

src/linear_algebra.jl
48.38% <100.00%> (ø)

src/multipliablematrices.jl
71.71% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Using ctrl + backspace for the "Clear Single Word" feature of Chat Commands removes an extra character

Discussed in https://github.com/runelite/runelite/discussions/14940
Per the title, setting Clear Single Word to Ctrl + Backspace processes the backspace after clearing the last word, effectively removing the trailing space in the chatbox. This should be consumed like it is with any other keybind, like it is with the default keybind of Ctrl + W.

@Nightfirecat @LlemonDuck Omg thank you this has driven me crazy forever. Ya'll the best


Allow copy -> paste

paste into first field shall parse text and spread it over other fields

Is this resolved yet? It doesn't spread over the other fields for me.

not yet, looks like slowly we need this feature...


Felix resyncs when the etcd cluster restarts while it's watching

This is the Felix part of a fix to issue #340 - it also requires an appropriately patched version of python-etcd (https://github.com/Metaswitch/python-etcd/pull/2)

@fasaxc you might want to take a look too

This looks plausible, though I'd like to know why the UT failed.

The UT is pretty unexciting - it didn't have the right version of python-etcd, so couldn't import the exception.

I have a pull req open for the same feature, which includes adjusting the python-etcd version and updating tox config: https://github.com/Metaswitch/calico/pull/384 so I'm going to close this one.


can't train customized model on multiple gpus

I have customized a model using the fairseq and want to train it on multiple gpus, but I got this following error:
`Traceback (most recent call last):
File "train.py", line 313, in
cli_main()
File "train.py", line 305, in cli_main
nprocs=args.distributed_world_size,
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/multiprocessing/spawn.py", line 167, in spawn
while not spawn_context.join():
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/multiprocessing/spawn.py", line 114, in join
raise Exception(msg)
Exception:
-- Process 3 terminated with the following error:
Traceback (most recent call last):
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/multiprocessing/spawn.py", line 19, in _wrap
fn(i, *args)
File "/cluster/home/nnikolov/convtransformer/train.py", line 272, in distributed_main
main(args, init_distributed=True)
File "/cluster/home/nnikolov/convtransformer/train.py", line 85, in main
train(args, trainer, task, epoch_itr)
File "/cluster/home/nnikolov/convtransformer/train.py", line 128, in train
log_output = trainer.train_step(samples)
File "/cluster/home/nnikolov/convtransformer/fairseq/trainer.py", line 267, in train_step
ignore_grad
File "/cluster/home/nnikolov/convtransformer/fairseq/tasks/fairseq_task.py", line 237, in train_step
optimizer.backward(loss)
File "/cluster/home/nnikolov/convtransformer/fairseq/optim/fairseq_optimizer.py", line 74, in backward
loss.backward()
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/tensor.py", line 102, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/autograd/init.py", line 90, in backward
allow_unreachable=True)  # allow_unreachable flag
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/nn/parallel/distributed.py", line 445, in distributed_data_parallel_hook
self._queue_reduction(bucket_idx)
File "/cluster/apps/python/3.7.1/x86_64/lib64/python3.7/site-packages/torch/nn/parallel/distributed.py", line 475, in _queue_reduction
self.device_ids)
TypeError: _queue_reduction(): incompatible function arguments. The following argument types are supported:
1. (process_group: torch.distributed.ProcessGroup, grads_batch: List[List[at::Tensor]], devices: List[int]) -> Tuple[torch.distributed.Work, at::Tensor]
Invoked with: <torch.distributed.ProcessGroupNCCL object at 0x2aba50398848>, [[tensor([ 5.1338e-04,  3.3774e-03, -2.8672e-04,  4.5749e-04, -2.5838e-04,
-8.6781e-05, -1.4793e-03,  5.2592e-05,  3.1613e-04,  1.7187e-04,
-4.1386e-06,  3.4677e-04, -2.4201e-03,  1.7680e-04,  7.3398e-04,
-9.7241e-04,  5.3283e-05, -5.9374e-04, -6.8135e-05,  7.6470e-04,
-1.7447e-04, -7.4860e-06,  2.7631e-03, -7.9307e-04,  3.0332e-04,
-5.0689e-04, -2.0335e-04, -5.0705e-04, -1.8029e-04,  1.7714e-03,`
Any idea on how to solve this issue? Thanks!

Do you have some unused parameters in your model? Can you try passing --find-unused-parameters to your train cmd?

Do you have some unused parameters in your model? Can you try passing --find-unused-parameters to your train cmd?

Yes I added --find-unused-parameters to the train command, still not working

Do you get same error msg or different error msg when passing --find-unused-parameters?

Do you get same error msg or different error msg when passing --find-unused-parameters?
Nope, this is all I get.

What is the dtype and device of the tensor in your traceback? It's currently cutoff so can't tell for sure, but is it possible you have a model parameter whose type is not supported by NCCL?
You might also try --ddp-backend=no_c10d. That will switch to a simpler distributed training implementation that is typically more robust, although it still uses NCCL so it won't help if you have some unusual parameter type in your model.

What is the dtype and device of the tensor in your traceback? It's currently cutoff so can't tell for sure, but is it possible you have a model parameter whose type is not supported by NCCL?
You might also try --ddp-backend=no_c10d. That will switch to a simpler distributed training implementation that is typically more robust, although it still uses NCCL so it won't help if you have some unusual parameter type in your model.

thanks for the reply. using --ddp-backend=no_c10d does help. problem solved.


Change Socket::Server#accept to return IO and add default implementation

This PR changes the return type of  Socket::Server#accept and #accept? to IO and IO?.
It decouples the interface from a specific Socket design. Right now, every Socket inherits from IO, but for a UDP socket implementation, this doesn't make sense because it is not a stream (see #5778).
The purpose of the Socket::Server#accept methods is to accept an incoming connection to use it as a stream IO. That's what the IO class is meant for.
It also adds a default implementation for #accept which returns the value of #accept? or raises if it is nil.
It is the same implementation as already used in Socket#accept.
This makes it easier for classes inheriting the module to implement the interface, they might just need to override #accept?.

There are datagram protocols which use accept(), such as DCCP. accept or not depends on whether the protocol has the concept of a "connection". That's entirely orhogonal to whether the protocol is stream-based or not.

@RX14 Yes, I see, there are two different definitions of what gets accepted by a server. Either a socket connection or an IO stream. Right now in the stdlib it is everywhere used as returning an IO stream. Changing the return type to IO makes it more versatile so this concept can be used without explicitly using sockets (for example to mock a network connection).
Since we have no type in stdlib that models a non-stream socket connection and probably won't need that ever, I'm not sure if it makes sense base an abstract interface on this concept. And if if does, it should be an additional one.
Maybe it would be a good idea to rename Socket::Server to IO::Server or something similar to more explicitly express its purpose to accept IO streams.

I'm unsure of the overall direction of these socket PRs, what's the end goal, what's the design?

@ysbaddaden

Why not? Socket doesn't say anything about its purpose. We actually want an IO in order to use it for example in HTTP::Server to read and write to it.
The example just illustrates that, if accept returned an UDP socket, it wouldn't be useful in a context where you'd expect an IO.

@RX14 That's exactly my idea to have a raw socket implementation and let protocol specific implementations build upon that. Because of the complexity involved, I figured to first propose individual changes which are independent of the large socket refactoring because they already make sense with the current structure.

There's a million different combinations a socket can behave, and only a few which are commonly used.

An accept method returning a generic Socket instance isn't very useful as it doesn't specify how  this socket is supposed to be used. It essentially says the thing it returns is a socket, but you need to know from the context if it is an IO stream or some other connection.
The only meaningful use case is to return an IO stream. This PR reduces complexity. accept simply returns an IO and everything's fine.

@straight-shoota I don't understand how Socket#accept doesn't return a Socket. We've already covered a situation where it doesn't return an IO. Socket shouldn't be an IO, and it should have no subclasses. Accept returning a socket is absolutely the most useful thing that can be done.
TCPServer#accept will return a TCPSocket which is an IO. That's what 99% of users will use.

We're talking about Socket::Server#accept, not Socket#accept!

because it's a low-level interface that extremely few people will use.

Socket is low-level. Socket::Server is actually a high-level interface and only implemented by TCPServer and UNIXServer. They're providing IO streams.
When the return type is IO, it could also be implemented by a MockServer which is used for testing to mock a network connection.

@straight-shoota currently, TCPServer < TCPSocket < IPSocket < Socket. So Socket::Server#accept is Socket#accept! That's the insane part and needs to be tackled first.

Please, let's close, this is going nowhere. An API musn't be design to "ease testing". Don't mock but test the real thing instead.
Let's spend energy to change TCPServer / UNIXServer to compose a TCPSocket / UNIXSocket instead, which has already been accepted numerous times.

An API musn't be design to "ease testing"

I don't quite agree with this.

@asterite I think what @ysbaddaden means was that an API shouldn't be degraded only to ease testing.

Ah, that makes more sense.

I agree. But testability is not the reason for this change. It's just a nice byproduct.
@ysbaddaden This was supposed to be one step in preparation for decoupling the socket types. But if you insist that this should not be merged as is, fine. It'll be in a later PR then.

Note that specifying that some method returns IO doesn't conflict with subclasses returning a stricter type. And then, the compiler doesn't cast the return value tui the return type, so if it really returns a Socket you can still call Socket methods.


Fixes #90

Checks if there is an id in the URL and throws a 404 if not.
If there is then load that team and check for ownership.
If the current authenticated user is not that team's owner throw a 403.

Codecov Report

Merging #91 into master will decrease coverage by 0.84%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   76.12%   75.27%   -0.85%
==========================================
  Files          15       15
  Lines         356      360       +4
==========================================
  Hits          271      271
- Misses         85       89       +4

Impacted Files
Coverage Δ

src/Mpociot/Teamwork/Middleware/TeamOwner.php
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffea927...d17803a. Read the comment docs.


Syntax highlighting

Is your feature request related to a problem? Please describe.
Code blocks don't use syntax highlighting. This makes code hard to read.
Describe the solution you'd like
If you use ```[language] instead of simply ``` to start a code block, it should highlight the syntax as the selected language like Github does. Here with python as an example:
def foo():
  bar = 1
  return bar

Describe alternatives you've considered
n/a
Additional context
We already use react-syntax-highlighter but we only use language='text':
https://github.com/stackernews/stacker.news/blob/78520b787b928756c81700ab5b3ac16170ac9084/components/text.js#L134-L136
However, it requires more than passing the language since if I manually set it to python, it does not do syntax highlighting.

We used to do this. It made the bundle size HUGE for not much gain. It can probably be done efficiently with selective, dynamic imports.
A solution should use https://nextjs.org/docs/app/building-your-application/optimizing/bundle-analyzer to make sure it doesn't bloat the bundle.

How about just importing the files for a few popular languages to tackle this one? If so, which languages would you want to support?

If they’re dynamically imported, it shouldn’t matter how many we support. But maybe we can find the top 5 somewhere

I'm not sure how you'd decide when to "dynamically import" a language file. Selectively importing languages on build would keep the size down but you'd be limited those that you choose. If you mean importing them on the fly then that's a whole different ball game.

If you mean importing them on the fly then that's a whole different ball game.

That's the ball game I mean.
Unless we use dynamic imports, this isn't worth the bundle size bloat. Maybe we can dynamically import all languages. It's been a long time since I've looked at the code, but I think each language can be imported only when they're used.

Well there is such a thing as dynamic imports but that isn't what you refer to as dynamic imports. You can choose which languages you want ahead of time but not during runtime.

https://mieszkogulinski.github.io/next-js-conditional-dynamic-import/

That's cool but once you've imported how do you decide when to drop it?

You don't decide to drop it. The browser caches it or doesn't. The main thing is that it's only downloaded if it's used.

However, it requires more than passing the language since if I manually set it to python, it does not do syntax highlighting.

It does work! Style was imported for the prism version of react-syntax-highlighter
// not working
import { LightAsync as SyntaxHighlighter } from 'react-syntax-highlighter'
import atomDark from 'react-syntax-highlighter/dist/cjs/styles/prism/atom-dark'

// working
import { LightAsync as SyntaxHighlighter } from 'react-syntax-highlighter'
import atomOneDark from 'react-syntax-highlighter/dist/cjs/styles/hljs/atom-one-dark'

Language auto-recognizing doesn't work though, we should get the language from the user atp.


Running Android in debug mode. Game crashes.

E/AudioTrack(  780): AudioTrack::set : Exit
E/ACDB-LOADER(  243): Error: ACDB AudProc vol returned = -19
E/ACDB-LOADER(  243): Error: ACDB AFE returned = -19
I/trace   (30804): Lib.hx:360: Null Object Reference
I/trace   (30804): Called from *._Function_1_1 (ApplicationMain.hx line 98)
I/trace   (30804): Called from Reflect.callMethod (C:\HaxeToolkit\haxe\std/cpp/_std/Reflect.hx line 50)
I/trace   (30804): Called from Main.main (Main.hx line 68)
I/trace   (30804): Called from openfl._legacy.display.DisplayObjectContainer.addChild (openfl/_legacy/display/DisplayObjectContainer.hx line 31)
I/trace   (30804): Called from openfl._legacy.display.DisplayObject.__setParent (openfl/_legacy/display/DisplayObject.hx line 423)
I/trace   (30804): Called from openfl._legacy.display.DisplayObjectContainer.__onAdded (openfl/_legacy/display/DisplayObjectContainer.hx line 379)
I/trace   (30804): Called from openfl._legacy.display.DisplayObject.__onAdded (openfl/_legacy/display/DisplayObject.hx line 362)
I/trace   (30804): Called from openfl._legacy.display.DisplayObject.dispatchEvent (openfl/_legacy/display/DisplayObject.hx line 70)
I/trace   (30804): Called from openfl._legacy.display.DisplayObject.__dispatchEvent (openfl/_legacy/display/DisplayObject.hx line 182)
I/trace   (30804): Called from openfl._legacy.events.EventDispatcher.dispatchEvent (openfl/_legacy/events/EventDispatcher
E/AppsCustomizePagedView( 2437): Create Res Apk Failed

@smks which API are you targeting, and which one is in use on your device/emulator?

Hey, was targeting SDK 23 and dispatching to both a Samsung Galaxy Note and a Oneplus 1.

The error was specified in the fourth line, Null Object Reference, coming from Main.hx line 68.

what's mean about Creat Res Apk Failed?how can i  deal with that?


Add page which documents the supporting formats

Suggested route: /help/formats
Model formats

BNGL
SBML

Simulation formats

SED-ML

Archive formats

COMBINE/OMEX

I added help information about this


typo fix

options had spelled WITHNOWAIT instead of WITH NOWAIT.

Docs Build status updates of commit fc3c895:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/t-sql/language-elements/shutdown-transact-sql.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@rwestMSFT,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


About feed with pi3 a +

Hello
I'm using translation because I'm not good at the English.  sorry.
I'm trying to feed using the recently released pi3 a +.  It seems that the cpu performance is better than pi2 and pi3, so basically I'm not dissatisfied, but for some reason I can't feed to flightaware.  I have installed the package and dump1090-fa is working properly and is able to feed other services.  However, even if I try using the top command, piaware is not working and it is not displayed on the flightaware management screen.
Is there any workaround for this?
I'm sorry for the rudimentary question.  Thank you for reading the long text.

Can you enter piaware-status and send me the output?
Also what do your piaware logs say? tail -f /var/log/piaware.log

Thank you for your prompt response.
The status is output as command not found.
The log looks like this:
tail: cannot open '/var/log/piaware.log' for reading: No such file or directory
tail: no files remaining
I have repeated the official procedure from the beginning of rewriting the raspi-os about twice, but this is the situation every time.

I don't think you have piaware installed.
The simplest solution would be to use the SD card image: http://piaware.flightcdn.com/piaware-sd-card-4.0.img.zip
If you want to go the package install route, following the steps at number 2 here and let me know the output: https://flightaware.com/adsb/piaware/install

When I tried -sudo apt-get install piaware- again according to the official procedure introduced, it was installed normally and it was also displayed on the management screen.
Thanks to the easy-to-understand advice, I was able to solve it. Thank you very much for your busy schedule.

When I tried -sudo apt-get install piaware- again according to the official procedure introduced, it was installed normally and it was also displayed on the management screen.
Thanks to the easy-to-understand advice, I was able to solve it. Thank you very much for your busy schedule.

You're welcome.


7.2 High DPI: Message box scaling issues at non-primary DPI

A message box shown on a monitor that is not operating at the primary system DPI (i.e. the DPI of the primary monitor), will have scaling issues. The most obvious and commonly occurring of these is that the grey band drawn under the buttons is not scaled from the primary DPI and so is drawn at the wrong position and with the wrong extent.
To Reproduce

On a multi-monitor system with differing DPI scales between primary and secondary monitors, open a workspace on a secondary monitor (or move one from the primary monitor).
Type some random text
Click the workspace close button
A prompt to save changes will appear

Actual

Expected

Discussion
This is a bug in the Windows message box. It is probably not fixable at an application level, and likely Microsoft are not interested in fixing it either since the old message box has been superseded by Task Dialog.  In Dolphin 8 the MessageBox class does now use a Task Dialog, but it would be a significant undertaking to backport to Dolphin 7.2, so probably this is a Won't Fix for 7.x.

Closing this because we cannot fix or work around this Windows 10/11 bug (except by backporting the D8 MessageBox based on the newer Windows Task Dialog back to D7, which would involve significant effort that isn't justifiable).


Make chunk size samller

coverage: 50.639% (-0.04%) from 50.677%
when pulling f45a534168869f07f11a5ecd7bc975720715e2de on shrink_chunk
into b489fa9665719f9beec5f4c51701e4a6476026e7 on main.

coverage: 50.639% (-0.04%) from 50.677%
when pulling f45a534168869f07f11a5ecd7bc975720715e2de on shrink_chunk
into b489fa9665719f9beec5f4c51701e4a6476026e7 on main.


Create 4 duplicate entities

HA creates duplicate enties with postfix _1, _2,_3,_4.
And unable to delete those entities.
Only first entity _1 working. The rest on and off no response.

Show device diagnostics

Hi there.
How would I do this, sorry new to this.

From: Alex X @.>
Sent: Friday, March 31, 2023 6:59:23 PM
To: AlexxIT/SonoffLAN @.>
Cc: Erwin Ballack @.>; Author @.>
Subject: Re: [AlexxIT/SonoffLAN] Create 4 duplicate entities (Issue #1152)
Show device diagnostics
—
Reply to this email directly, view it on GitHubhttps://github.com/AlexxIT/SonoffLAN/issues/1152#issuecomment-1492267858, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4Q4B4CFE37A7ZRUF2UKSKLW64EOXANCNFSM6AAAAAAWOUQMMQ.
You are receiving this because you authored the thread.Message ID: @.***>


Add --debug output for the file being processed.

For debugging purposes it would be helpful to know what file is currently processed.
Initially suggested by @schlessera.

@ocean90 Using sprintf() and multiple lines here is overkill and detracts from the actual logic. I'd prefer each of these to be single lines instead.

All failures unrelated (and waiting for https://github.com/oscarotero/Gettext/issues/231 to get solved), so merging as-is.


onBlockStartBreak does not exist but It's still mentioned

onBlockStartBreak does not exist on 1.20.6 but it is still mentioned here: https://docs.neoforged.net/docs/blocks/#the-actually-breaking-stage

Fixed by #96


Creating an environment from the dev portal doesn't use the manifest default values

Hi Team,
As the parameters' default values of the ARM template I use in catalog are defined for a production environment, I set different default values in the manifest.yaml file.
However, when I create an environment from the dev portal it is using the default values of the ARM template instead of the ones defined in the manifest.
It is quite counterintuitive as it is not the values displayed in the dev portal during creation that are actually used.
Is it the expected behaviour? Is it possible to improve that behaviour as it would be very useful to be able to use different manifest files with the same ARM template for different environment type?

Hey @SimonDraime. Thanks for the report! This is definitely a bug, we should be honoring what is defined as the default in the YAML file. I'll let you know when we've got a fix ready.

Though I am curious to understand more about your last part:
it would be very useful to be able to use different manifest files with the same ARM template for different environment type?
We don't currently have this ability in the product. Mind expanding a bit more on what you're hoping to achieve?

Yes, it would be a good idea to use the environment type to define some parameters that are always the same for a specific environment type.
However, where would you define these parameters' values on the Azure portal, it's not very clear for me how are linked the catalogs and the environment definitions to the environment types? What if you have several environment definitions in your catalog? How to defines the parameters' value for each environment definition in the environment type?

@j-rewerts Do you have an idea of the timeframe for the fix availability?

Nothing to report currently, I'll follow up once we're getting close to shipping the fix.

Thank you for bumping this bug. We are taking a look at it and will update you once a solution is available.

Hi @timwebster9,
This issue is fine to leave open. You are correct that this bug exists and is not just for Terraform. Expected behavior is that the environment yaml is the source of truth so what users see in the DevPortal is what they get. We are taking a look and will update when the fix has hit all regions.


Load order conflict with enchantment perk Twin Moons

Describe the bug
The Twin Moons perk near the top of the Enchantment perk tree claims that there's a load order conflict.
To Reproduce
Steps to reproduce the behavior:

Go to the top of the Enchantment perk tree.
Find the Twin Moons perk.
Read the perk description.

Expected behavior
Perk description should indicate the function of the perk.
Screenshots

Modlist version
0.3
Did you add any additional mods?
Fertility Mode

Put simply it's the smashed patch, it catches Adamant first but Path of Sorcery loads after it. the smashed patch didn't forward the path of sorcery description or anything else for that matter.
SSEEdit image:

Solution is easy forward the data from Path of Sorcery into the smashed patch to fix it (or create an espl custom patch) but it'll likely be fixed in the next update

Fixed in the next update


I am unable to stream anime

I was trying to watch anime but it doesn't work, I've installed all the dependencies including mpv

join the discord

okk


Remove CLI

Remove https://github.com/TUCAN-nest/SDF-pipeline/blob/f814777df3a14dc7fbdeb63cb9b44c71b2c76375/src/sdf_pipeline/drivers.py#L13. The CLI is a premature abstraction that didn't turn out to be that useful in practice.
Adapt examples accordingly.

Closing with e036913c45184095add528ab4866aa037deebccb.


secrets not in sys.path when using --venv

Overview
This arose from a discussion on slack. The repo https://github.com/yjabri/debug-pex-import describes how to reproduce the bug in the README.md.
The culprit appears to be pex_bootstrapper.py#L672. Just prior to the line, in a debugger I can successfully import secrets. (A cause of flask failing to import). However just after the line, in a new debugger session import secrets raises a ModuleNotFoundError exception.
Some details
The line https://github.com/pantsbuild/pex/blob/main/pex/pex_bootstrapper.py#L672 converts my sys.path from
['/home/yjabri/Projects/debug-pex-import',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python310.zip',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10/lib-dynload',
'',
'/home/yjabri/.local/lib/python3.10/site-packages',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10/site-packages',
'dist/.pex' ]

to
['/home/yjabri/.pex/venvs/6c8eaec5b07b6fe5d8c257cd72d1297dfafdfc8e/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.10/site-packages',
'dist/.pex']

My understanding is that this doesn't include standard library which would be in  '/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10'
For reference, python dist/.pex -c "import sys; print(sys.path)" outputs
['',
'/home/yjabri/.pex/venvs/6c8eaec5b07b6fe5d8c257cd72d1297dfafdfc8e/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python310.zip',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10',
'/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10/lib-dynload',
'/home/yjabri/.pex/venvs/6c8eaec5b07b6fe5d8c257cd72d1297dfafdfc8e/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.10/site-packages']

Why does this happen?
If I set
sys.path = [
    '/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10',
    '/home/yjabri/.pex/venvs/6c8eaec5b07b6fe5d8c257cd72d1297dfafdfc8e/779eb2cc0ca9e2fdd204774cbc41848e4e7c5055/lib/python3.10/site-packages',
    'dist/.pex'
]

I can import secrets without a ModuleNotFoundError.
In general, if I create a venv manually via
python -m venv venv

and run venv/bin/python -c "import sys; print(sys.path)" I see
['', '/home/yjabri/.pyenv/versions/3.10.13/lib/python310.zip', '/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10', '/home/yjabri/.pyenv/versions/3.10.13/lib/python3.10/lib-dynload', '/tmp/foobar/venv/lib/python3.10/site-packages']

I get ModuleNotFoundError by running
venv/bin/python -c "import sys; sys.path = sys.path[3:]; import secrets"

but not
venv/bin/python -c "import sys; sys.path = sys.path[2:]; import secrets"

does not raise the exception. If I replace secrets with other standard library packages like http or random I get the same ModuleNotFoundError exception.

If I make the modification
with ENV.patch(PEX_ROOT=pex_info.pex_root):
    if not execute:
        for location in _activate_pex(entry_point, pex_info, venv_dir=venv_dir):
            from pex.third_party import VendorImporter

            VendorImporter.install(
                uninstallable=False, prefix="__pex__", path_items=["."], root=location
            )

        # Include compatible interpreter for python standard library
        interpreter_test = InterpreterTest(entry_point=entry_point, pex_info=pex_info)
        try:
            target = find_compatible_interpreter(interpreter_test=interpreter_test)
        except UnsatisfiableInterpreterConstraintsError as e:
            die(str(e))
        sys.path.insert(0, "{}/lib/python{}".format(target.prefix, target.python))

        return

I can import flask without a ModuleNotFoundError exception after
Would a PR be welcomed? I'd probably need a little time to learn how to run tests in this repo as I've never used tox before.

Awesome. In the PR I'd create a test in pext/tests/integration  for this issue. Removing all the unnecessary  details about ipython and jupyter this can be distilled to the following
Expected Behavior
The following is expected behavior. Run
rm -fr output.txt
dist/pex Flask -o flask.pex
python script.py
cat output.txt

where script.py is
import sys
error = ""

try:
    sys.path.append("flask.pex")
    import __pex__
    import flask
except Exception as e:
    error = str(e)

with open("output.txt", 'w') as f:
    f.write(error)

and observe the file is empty. Note I excluded --venv when building the pex.  It's worth noting that python --version prints
Python 3.9.18
Unexpected Behavior
To reproduce the bug run
rm -fr output.txt
dist/pex Flask -o flask.pex
python script.py
cat output.txt

and observe output.txt contains the line No module named 'contextvars.
Writing a Test
To write a test, I'm going to need to use subprocess to orchestrate the following

Create a pex from source. test_issue_1872.py looks like a good reference
Write the above script to a tmpdir
Execute it with python (I think I ought to use sys.executable) for this?
Check output.txt and assert it's empty.

Does that sound good?

That sounds about right. You should pin the flask dep so that CI is more stable over time and the version of Flask you pin will necessitate adding a @pytest.mark.skipif that skips the test for unsupported Pythons, likely sys.version_info[:2] < (3, 7) (or 3.8).

Is the intention to strip all of the following?
/home/yjabri/.pyenv/versions/3.9.18/lib/python39.zip
/home/yjabri/.pyenv/versions/3.9.18/lib/python3.9
/home/yjabri/.pyenv/versions/3.9.18/lib/python3.9/lib-dynload

If I try something like
import sys
sys.path[:] = [
    "/home/yjabri/.pyenv/versions/3.9.18/lib/python39.zip",
    "/home/yjabri/.pyenv/versions/3.9.18/lib/python3.9",
    "/home/yjabri/.pyenv/versions/3.9.18/lib/python3.9/lib-dynload",
]
import secrets

It only works if I have (/home/yjabri/.pyenv/versions/3.9.18/lib/python39.zip or /home/yjabri/.pyenv/versions/3.9.18/lib/python3.9) and /home/yjabri/.pyenv/versions/3.9.18/lib/python3.9/lib-dynload.
The specific paths seem like an implementation detail specific to whatever installed the interpreter being used.
For example I need different paths if using /usr/bin/python3.9. I haven't even checked what these would be on Mac (or Windows).
Would it make sense to capture sys.path near the beginning of BOOTSTRAP_ENVIRONMENT and ensure we don't strip necessary paths like the ones listed above? Would this break other uses of  __pex__?
I'm going to thinking about this, but thought I'd check  base and make sure I'm on the right path towards solving this.

As I said above (https://github.com/pantsbuild/pex/issues/2235#issuecomment-1716808615) and you originally sketched above (https://github.com/pantsbuild/pex/issues/2235#issuecomment-1712726080) I think sys.path.insert(0, ...) is the right thing to do and probably the only needed fix. The thing to insert is the same thing ~inserted today, namely venv.site_packages_dir.

Maybe this makes the situation more clear - I have absolutely no clue why I did this crazy slice nor how it passed review:
https://github.com/pantsbuild/pex/blob/5c0c29c192bd99335b5a1ab5b68a0f8556cd97aa/pex/pex_bootstrapper.py#L672
The only operations that make sense are to either prepend the venv PEX site-packages to the existing sys.path or else append to the existing sys.path. Nuking parts of the existing sys.path is insane. Somehow though I proceeded to do that and get it checked in.

That does indeed make things more clear!

Alright @yjabri - thanks for your help on this. Your fix is now live in Pex 2.1.146:

https://pypi.org/project/pex/2.1.146/
https://github.com/pantsbuild/pex/releases/tag/v2.1.146


Clean lazy-loading logic. Added types.

No functional change. Main changes:

Declare types of lazy-loaded modules. Added _ imports that are removed by TypeScript at compile time (not because of the underscore, that's just a notation, but because they are only used as types).
Added types to one component as an example. Minor clean up there. Not applied to other components yet, I'd like to get feedback first but I'd be happy to do it in the context of this PR.
Initially I tried to extract simpler methods to lazy-load modules, but Webpack doesn't allow it, as the require.ensure method must be used with literals (both for modules and chunk names), otherwise the preprocessor won't do its job well.

This is a big showstopper to me: I'd like to encapsulate lazy-require calls so I don't spread them throughout the application code. Specifically we're polluting with:
Webpack info: what if we change to another build system? What if System.import() becomes standard finally?
Chunk information: what if we change how we create our chunks? What if we rename and forget any literal?

Another good point on lazy loading is to use it to load a group of subpages (e..g. let's load in one go all the Accounting group of pages), by doing this we just load subareas of an app in one go (I think this makes sense, loading a single page lazy could be an overkill (if pages are not rich) , but loading a group of related pages could be a good idea (load time, vs functionallity)

@brauliodiez This code already creates a chunk for the 2 member pages together, this is achieved by the "MemberPages" constant. We don't need to repeat the modules that belong to each chuck, Webpack does this work at build time and when you request a page (plus its chunk name), it will get the entire chunk.


For.Publishers should return a Publisher not an AnyMSeq

Returned Publisher can easily be subscribed to (to create a Flux / ReactiveSeq or any Cyclops collection type). AnyMSeq (currently) requires dynamic monad interpretation, which is overly complex and unneccessary (see -> https://github.com/aol/cyclops-react/issues/417)

Removed : Merged in https://github.com/aol/cyclops-react/pull/451


New CoprBuildEvent.from_build_id() to return None if build_id not in DB

I'm seeing lots of empty task results in redis:
"{\"status\": \"SUCCESS\", \"result\": null, \"traceback\": null, \"children\": [], \"task_id\": \"1e6888d5-c73c-4023-bbca-f308c56c9b41\"}"

This change should make Parser.parse_copr_event() return None instead of empty CoprBuildEvent.
That prevents SteveJobs.process_message() from running handler and sending empty task results to Celery backend.

merging myself, please review anyway


Fix major security problem regarding french word

Fix major problem regarding french language
"content" -> "contenant"

Thanks, fixed in c0367af05bbd0126c592877b4dfe7b81b1f5275f