Update readme to include a link to the roadmap and a stronger introduction.

Roadmap.
Intro should better describe the overall purpose and value of the tool. The current intro is factually correct, but doesn't really convey the value.

I know I'll need to get this to a PR, but given that I imagine this will lead to some discussion, I'm keeping this in the issue thread first and I'll move to a PR if there are no major objections to this approach.
I think the roadmap section could be expanded to beyond a simple link of "here's our roadmap" and provide more context as to why we have a roadmap, what it means, and who is in charge of it (in the spirit of transparency with the public). To that end, here's some sample verbiage that could eventually be moved into our community docs and simply referenced.
Roadmap
Each DRUD product has a dedicated product owner, who serves as the primary advocate for customers and end-users when making decisions regaring the public roadmap. For the ddev roadmap, @rickmanelius is currently serving as the product owner.
The purpose of our roadmaps is to balance high level, 1-6 month targets with short term fluidity that occurs within our weekly sprints. Feedback from customers and end-users does help shape both our short and long-term focus, so please review the roadmap and the ddev issue queue to see what's on the horizon as well as submit bugs and requests.

Regarding the project description, I would like to modify as follows:
ddev
The purpose of ddev is to help Drupal and WordPress abstract away the complexity and effort of adopting and maintaining a docker based local development stack. You can see all "ddev" usages using the help commands, like ddev -h, ddev start -h, etc.
If I get no objections by COB next Monday, I'll proceed with a PR and tag for reviews.

Related to #202

PR merged in. Closing out.


Add refined to the projects that use macro-compat

https://github.com/fthomas/refined/pull/89
Thanks to macro-compat I can compile with -Xfatal-warnings again!

Awesome! Thanks :-)


Unable to build project on mac - resize-inspector/index.js error

Name of Defective Feature
Unable to build the current project.
System Settings (Required)
ToolKit Version: 8a64916c5c865d29e7faa2afa3e47a69f9ea24ba
Operating System (Mac/Windows/Etc): Mac
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 62.0.3202.62 (Official Build) beta (64-bit)

Steps to Reproduce the Behavior

I followed the instructions here.

versions of noteworthy things:
python: 2.7.10
yarn: 1.2.1
node: v6.9.1

2. I run ./build and get the following output/error:
$ webpack
(node:15051) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Hash: 53ea6606382feae4a00d
Version: webpack 3.6.0
Time: 7567ms
                                    Asset    Size  Chunks                    Chunk Names
source/common/res/features/ynabToolkit.js  298 kB       0  [emitted]  [big]  main
   [6] ./sauce/main.js 2.34 kB {0} [built]
   [7] ./sauce/features/index.js 13.8 kB {0} [built]
   [8] ./sauce/features/accounts/additional-columns/index.js 7.73 kB {0} [built]
  [19] ./sauce/features/accounts/adjustable-column-widths/index.js 7.74 kB {0} [built]
  [22] ./sauce/features/accounts/calendar-first-day/index.js 4.62 kB {0} [built]
  [23] ./sauce/features/accounts/change-enter-behavior/index.js 4.15 kB {0} [built]
  [24] ./sauce/features/accounts/clear-selection/index.js 3.38 kB {0} [built]
  [25] ./sauce/features/accounts/custom-flag-names/index.js 7.56 kB {0} [built]
  [26] ./sauce/features/accounts/emphasized-outflows/index.js 2.25 kB {0} [built]
  [29] ./sauce/features/accounts/larger-cleared-icons/index.js 2.19 kB {0} [built]
  [32] ./sauce/features/accounts/row-height/index.js 4.23 kB {0} [built]
  [39] ./sauce/features/accounts/show-category-balance/index.js 4.61 kB {0} [built]
  [65] ./sauce/features/budget/highlight-current-month/index.js 3.81 kB {0} [built]
 [155] ./sauce/features/general/show-intercom/index.js 3.54 kB {0} [built]
 [156] ./sauce/features/general/square-negative-mode/index.js 2.17 kB {0} [built]
    + 144 hidden modules

ERROR in ./sauce/features/budget/resize-inspector/index.js

/Users/Alex/code/toolkit-for-ynab/sauce/features/budget/resize-inspector/index.js
  1:25  error  Unable to resolve path to module 'core/feature'     import/no-unresolved
  2:32  error  Unable to resolve path to module 'helpers/toolkit'  import/no-unresolved

✖ 2 problems (2 errors, 0 warnings)

 @ ./sauce/features/index.js 53:23-59
 @ ./sauce/main.js

ERROR in ./sauce/features/budget/resize-inspector/index.js
Module not found: Error: Can't resolve 'core/feature' in '/Users/Alex/code/toolkit-for-ynab/sauce/features/budget/resize-inspector'
 @ ./sauce/features/budget/resize-inspector/index.js 10:15-38
 @ ./sauce/features/index.js
 @ ./sauce/main.js

ERROR in ./sauce/features/budget/resize-inspector/index.js
Module not found: Error: Can't resolve 'helpers/toolkit' in '/Users/Alex/code/toolkit-for-ynab/sauce/features/budget/resize-inspector'
 @ ./sauce/features/budget/resize-inspector/index.js 12:15-41
 @ ./sauce/features/index.js
 @ ./sauce/main.js
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I noticed that the most recently merged PR had to do with the resize inspector (https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1007), I'm not sure if something is involved there.
Admittedly, this is my first time building this project - it's possible I've done something wrong. I'd love some direction on this!

For now add toolkit/ to the import statements. We had a bit of a chicken and egg situation with the PR that introduced the alias of toolkit and it wasn't added for this PR. I'm working on another PR for this code and I'll add the alias.

That worked great, thanks!

I've got problems on Windows 10 where the alias path won't resolve so I have to figure that out before I can complete my PR. Not good.


Fixed temporary lock_guard instances.

This diff fixes the temporary lock_guard instances giving those a name.

@jcf94

@jcf94


Fix remote registration field errors not showing

Description
MA-2944
#815 added a popup dialog in addition to the field errors. However, it caused a regression in that it failed to display field-specific errors returned by the server (thus only displaying field errors upon the initial local validation). This pull request fixes this by readding the call to the field error handler.
Reviewers
If you've been tagged for review, please "Start a review" with the GitHub GUI.

Code review: @miankhalid, @BenjiLee

Done in commit 44dce1ff78b212958606595d9607957f55ef87e3.
On Thu, Oct 20, 2016 at 4:51 PM, Mi@N Kh@LiD <EMAIL_ADDRESS>wrote:

@miankhalid requested changes on this pull request.
This requirement got missed:

App shows dialogue message twice if user enters email and username both
which already has an account.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/edx/edx-app-android/pull/867#pullrequestreview-5052876,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEDCjXgbWW5-e6aGIUxeNXvjCI6P3gBBks5q11XegaJpZM4KcBbD
.

Current coverage is 18.99% (diff: 0.00%)

Merging #867 into master will increase coverage by 0.05%

@@             master       #867   diff @@
==========================================
  Files           469        469
  Lines         19941      19942     +1
  Methods           0          0
  Messages          0          0
  Branches       2915       2915
==========================================
+ Hits           3775       3787    +12
+ Misses        15719      15706    -13
- Partials        447        449     +2

Powered by Codecov. Last update 7b3d10f...20d0d7b

Alert dialog is popping up twice when submitting the following form

I forgot to check in the small but critical part where the original dialog flow was removed, so it was only working locally on my side 😞 I have opened #869 to address this.


Introduce ilab model standards and ux standards

Introduces two new development documents. The first establishes standards for using model path flags across the project to standardize the flag usage. The second document outlines general UX standards to ensure a consistent and user-friendly experience across the application.

I really like the changes proposed in this PR. It seems like we just need to change the functionality so we do:

If a model path matches against an OCI directory, first check if that exists
Check if the provided path matches against a file (doing os.path.exists(model_path) will cover both the absolute & relative path case)
If it didn't match, check against the output of ilab model list

It also sounds like we need to extract the logic that's currently in ilab model list and make it globally available, so that way we can achieve consistent behavior across the project.
It also sounds like we'll need to do the same for the data we generate

what do we need to get this dev doc merged? its been sitting for a while


Format the output of tophelpers in tabular form + adding logback + utility message templates

The primary goal of this PR is to format the output of /tophelpers in a tabular form. As a part of the task, additional application side transformations were delegated to native SQL
Current output of the command:
#1 Zabuzard#3452 - 3328 messages in help channels in the last 30 days
#2 Alathreon [3824 - 9095 - 9308]#8051 - 2929 messages in help channels in the last 30 days
#3 illuminator3#0001 - 2487 messages in help channels in the last 30 days
#4 borgrel#7091 - 1403 messages in help channels in the last 30 days
#5 emccue#1975 - 1294 messages in help channels in the last 30 days
#6 dhrubajyoti_g#1718 - 786 messages in help channels in the last 30 days
#7 D4FuQ#5130 - 721 messages in help channels in the last 30 days
#8 Hayden#7709 - 659 messages in help channels in the last 30 days
#9 ericmp#6201 - 562 messages in help channels in the last 30 days

Output after changes:
    | Name                                | Msg Count(last 30 days)
----+-------------------------------------+-------------------------
  1 | Zabuzard#3452                       |                    4878
  2 | Alathreon [3824 - 9095 - 9308]#8051 |                    3600
  3 | illuminator3#0001                   |                    3271
  4 | borgrel#7091                        |                    1440
  5 | emccue#1975                         |                    1371
  6 | thenotsoOP#7288                     |                    1346
  7 | dhrubajyoti_g#1718                  |                    1078
  8 | Silk#6031                           |                     997
  9 | doctorpangloss#6014                 |                     838
 10 | D4FuQ#5130                          |                     768

PS: Ignore the differences in msg count as these were from 2 different environments

imo it'd also be better to change Msg Count(last 30 days) to Message Count (in the last 30 days) to make it look cleaner

Updated PR as per review comments

time to merge


Fix for issue #1647

I really don't like these Fix for issue commit titles. Please write a real description.


Updates to streaming/state in Custom Functions overview

There are also some other changes in here because I was going through searching for which, below, that, is, are, etc just to see if there was anything else to clean up. I was hoping that changing streamed to streaming would avoid merge conflicts, but apparently no?

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\ag3q-s, target branch: master, target branch commit: a68d56f577cf038289548d883b799315e9ba8d8e, source branch: michelle-overviewfix, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\no3s-s, target branch: master, target branch commit: a68d56f577cf038289548d883b799315e9ba8d8e, source branch: michelle-overviewfix, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add test to cover unregister non existing rule

I saw the method unregister isn't fully covered because there isn't a test to prove what happens when you delete a rule.
The RuleSet shoulld remain equal and no exception should be thrown

Coverage remained the same at 89.329% when pulling 3b28f42106b100e78687aa8d46abd89b816e45d8 on danrivcap:master into 2022c4b73907bef3ea8c21052f360fa37d4de35e on j-easy:master.

Nice thanks!
I'll merge your PR asap.
Kr
Mahmoud


azure-identity live tests

Closes #5726 with smoke tests to ensure the basic credentials satisfy AAD and don't fall over when given a real response. It would be nice to test managed identity scenarios live, because these are trickier and painful to test manually, but managed identity environments aren't available in our engineering system.
No recordings are included (adding them is tracked by #5980). I'm doubtful of their value given the simplicity of these tests and what can be accomplished with mocking.

Can one of the admins verify this patch?


[BUGFIX] Codeigniter tries to get composer vendor in APPPATH

When installs codeigniter using this command:
composer create-project bcit-ci/codeigniter CI-Clean --prefer-dist
install the "vendor" directory on codeigniter root (FCPATH) including "mikey179/vfsstream" but $composer_autoload tries to get it on APPPATH.'vendor/autoload.php'

It's not a bug.
Use the search bar.
#3636
#4197


cannot handle space in post names

I ended up with a file with a space in name - gives me error like this:
java.lang.IllegalArgumentException: Invalid identifier found: [roq-gen/posts/2020-05-28-beyondhello copy]
Might be valid issue but:
a) show the filename causing the issue
b) "identifier" is not something users know/should care about is it?

Yeah this should be easy to fix


chore(main): release 0.4.0

:robot: I have created a release beep boop
0.4.0 (2024-03-14)
⚠ BREAKING CHANGES

Have coercers take in a type instead of the full field
Update Field's types to a support Sorbets T::Types::Base classes
Changed serialize return value to a Result
adds SerializationError ancestor

Features

Add BooleanCoercer (acd220f)
Add EnumCoercer (5c0e2b5)
Add from_hash and from_json helpers to Schemas (#44) (55c2da7)
Add idempotency to Struct coercer (3a42957)
Add option to serialize values to HashSerializer (710d365)
Adds TypedArray coercer (795ddd9)

Code Refactoring

adds SerializationError ancestor (f8ea753)
Changed serialize return value to a Result (948c678)
Have coercers take in a type instead of the full field (c06169e)
Update Field's types to a support Sorbets T::Types::Base classes (9ef1cd5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/maxveldink/sorbet-schema/releases/tag/v0.4.0 :sunflower:


Expose storage usage

I know that these metrics are not exposed by Nextcloud, but it would be great to have

at least, global storage usage (even with primary storage on S3)
better, by user usage, like that app https://apps.nextcloud.com/apps/user_usage_report

I've submitted an Issue on Nextcloud/server project https://github.com/nextcloud/server/issues/37547, to eventually have more info via the  /ocs/v2.php/apps/serverinfo/api/v1/info API.
But perhaps nextcloud-exporter can be extended with DB queries ?

@GillesMocellin Sorry for not replying, April and May have been busy so far.
I'll have a look into this soon, I hope.


About SSIM loss

Hi, thanks for your work. Reading the paper, I have the doubt if your proposed loss (MAE+SSIM) produces more blurrier spectrograms or is it the other way around. Unfortunately it is not clear to me in the sentence:
"We compared our decoder to a variant trained without using
the SSIM loss. This produced blurrier spectrograms, but the
difference in audio quality was not noticeable."
Thank you in advance!

Hi, thanks for your interest in SpeedySpeech. The absence of SSIM loss resulted in blurrier spectrograms. So the combined MAE+SSIM gave sharper spectrograms and should sound a bit better. But the difference in voice clarity was not really noticeable for me.

Hi, thanks for your interest in SpeedySpeech. The absence of SSIM loss resulted in blurrier spectrograms. So the combined MAE+SSIM gave sharper spectrograms and should sound a bit better. But the difference in voice clarity was not really noticeable for me.

Thanks for your fast answer. Indeed, adding SSIM loss resulted in less blurrier spectrograms. Thanks for your work!


[request] A ddl tool

Hi, I am currently developping a ddl tool for various files and websites. Its goald is to cover most fields. It is already available here : https://github.com/FrenchGithubUser/Hatt
Would it be possible to add it to the list ?

Sure. This looks nice. Can you please send a pr? I don't have access to pc these days.

Done !

Thanks. Done on my part too.


Automate TLS cert renewal

https://www.digitalocean.com/community/tutorials/how-to-use-certbot-standalone-mode-to-retrieve-let-s-encrypt-ssl-certificates-on-ubuntu-22-04
Completed in this pull request: https://github.com/katefike/sage/pull/104

Manual edits
kfike@prod:~/sage$ cat docker/certbot/get_certs.sh
#!/usr/bin/env bash

# This script is only run in production

# Make the project root pwd and export the current working directory
__dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cd $__dir/../..
PROJECT_ROOT_PATH="$PWD"
export PROJECT_ROOT_PATH

set -o nounset -o pipefail -o errexit

# Load all variables from .env and export them all
set -o allexport
source ".env"
set +o allexport

# Convert $DOMAIN string to lowercase using two commas
certbot_cert=/etc/letsencrypt/live/prod.${DOMAIN,,}/fullchain.pem
certbot_key=/etc/letsencrypt/live/prod.${DOMAIN,,}/privkey.pem

# Check if a cert and key exist or not
if ! [[ -f ${certbot_cert} && -f ${certbot_key} ]]; then
    echo "Cert file not found at: ${certbot_cert}. Private key not found at: ${certbot_key}"

    # If they don't exist, create new certs (in a dry run during development)
    echo "Genererating TLS certs..."

        exit
    fi

else
    # If they exist, check if they're expired
    current_date=$(date)

    # Get the expiration date of the certificate
    raw_cert_expiration_date=$(openssl x509 -enddate -noout -in ${certbot_cert} | cut -d= -f2)
    cert_expiration_date=$(date -d "${raw_cert_expiration_date}" +"%a %b %d %T %Z %Y")

    # Get the earliest date the certificate can be renewed (30 days before the expiration)
    cert_renewal_date=$(date -d "${cert_expiration_date} -30 days")
    echo "Expiration date: ${cert_expiration_date}"
    echo "Renewal date: ${cert_renewal_date}"

    # Check if the certificate has passed the renewal date
    if [[ "${current_date}" > "${cert_renewal_date}" ]]; then
        #exit
	echo "Would have exited"
    fi

    #echo "The TLS cert is expires on ${cert_expiration_date}. Renewing in a dry-run..."
    #docker run --rm \
    #    --name certbot \
    #    -p 80:80 \
    #    -v "/etc/letsencrypt:/etc/letsencrypt" \
    #    -v "/var/lib/letsencrypt:/var/lib/letsencrypt" \
    #    certbot/certbot renew --dry-run
        # TODO: Use --deploy-hook to load certs and restart mailserver container

    # Get the new expiration date of the certificate
    new_cert_expiration_date=$(openssl x509 -enddate -noout -in ${certbot_cert} | cut -d= -f2)
    # Check if the renewal was successful
    if [[ "${new_cert_expiration_date}" == "${cert_expiration_date}" ]]; then
        echo "CRITICAL ERROR: Failed to renew TLS certs."
        exit
    fi
fi

echo "Copying TLS certs to sage-mailserver Docker container..."
docker cp -L ${certbot_cert} sage-mailserver:${certbot_cert}
docker cp -L ${certbot_key} sage-mailserver:${certbot_key}

echo "Restarting the sage-mailserver Docker container..."
docker restart sage-mailserver


Comment display/counter

Added comment display option.
Added comment counter option.

Hey Boku i took a look at it
and it looks nice

the comment will be stored in the API ✔
the comment will be sent and received from the API ✔
the comment counter works great
best practice for JavaScript

Well done 🔥

go a head it is ready to be merged !


Allow use of an object storage as storage backend

https://goharbor.io/docs/2.2.0/install-config/configure-yml-file/#backend

https://docs.docker.com/registry/configuration/#storage

Nearly two years old. Closing.


[Feature] Refactor FedRunner, optimize trainer module and optimize CI

This PR is Based on https://github.com/alibaba/FederatedScope/pull/408, and I add CI and doc based on it.
What's changed

Runner -> StandaloneRunner + DistributedRunner and use get_runner to replace FedRunner
Add README for Trainer module
Make num_val_batch, num_total_train_batch.... (related to cfg) as @property method (Users could still use setattr or = to change these values, but the changes will make the @property function invalid.)

@property
def num_total_train_batch(self):
    if self.get('num_total_train_batch'):
        return self.get('num_total_train_batch')
    return self._calculate_batch_epoch_num(mode='train')[3]

Optimize doc string for hook functions and API ref.
Bind each metric with one and only key THE_LARGER_THE_BETTER
Move functions in utils to xxx.utils
Optimize CI, as you can see below.

BTW, maybe we should unify the name of directories, e.g. trainers or trainer/workers or worker/criterion or loss in different tasks(core/cv/gfl/nlp/mf)


Adding initial Ada OpenGL Bible example

This is my first pull request.
I'm not sure what's supposed to happen next.
From the above comment I'm assuming that someone "with write access to this repository" will merge this pull request?

Yes, that would be me. I will look at your changes and give you some comments on what to improve. You can improve your PR by just pushing more changes to the my-examples branch in your fork.

Thanks Flyx.
This is a bit of a learning curve for me but hopefully I will learn from your comments.
I've made the changes indicated above.
I'm still not very competent with Gist yet; so more learning required and I'll leave off attempting to update my submission.

The important thing is that after you've made the changes, you need to commit them and then push them to your fork at GitHub. They will then automatically be applied here. So far, your changes have not yet arrived here.

I believe I've committed and then pushed requested changes to my fork at GitHub.
Is there anything else that I need to do at this stage.
I'm using GitHub Desktop.

You did everything you needed to do. Please be patient, I may not have time for a review until after Christmas.

OK, that's fine, I just wasn't sure of the process.
Enjoy your Christmas.

Absolutely no offense!
I'm grateful for your advice.
Regarding  indentation and spacing; I agree absolutely, it has been annoying me also.
My problem is with GPS which I must investigate how to get it to do things properly as, at the moment, it automatically formats things strangely; unlike other editors that I have used that do automatic indenting and colon alignment properly.
It might take me a few days to attend to all your recommendations and will give me a break from fighting my framebuffer example.

Note that I squashed your commits together in order to avoid unnecessary bloat in the commit history ;). This means that you should not further work on your my-examples branch since it now has a rather different history than the master branch.


[BUG] Not providing access needed with site permission API

First we create an app reg:
$appName = "KK test 7"
$url = "https://xx.sharepoint.com/sites/Segato-test11"

Connect-PNPonline -url https://xxx.sharepoint.com -interactive
$appReg = Register-PnPAzureADApp -ApplicationName $appName -Tenant xxx.onmicrosoft.com -Store CurrentUser -GraphApplicationPermissions "Sites.Selected" -Username<EMAIL_ADDRESS>-Password (Read-Host -AsSecureString -Prompt "Enter Password")

Following we grant access to that app reg:
Grant-PnPAzureADAppSitePermission -AppId "xx-74a9-xx-968c-xx" -DisplayName $appName -Site 'https://xxx.sharepoint.com/sites/Segato-test11' -Permissions Write

Everything seems to work. However when I get the permissions it looks like this (notice roles are empty):
`$url = "https://xx.sharepoint.com/sites/Segato-test11"`

Connect-PNPonline -url https://xx.sharepoint.com -interactive
Get-PnPAzureADAppSitePermission -Site https://xx.sharepoint.com/sites/Segato-test11

And when I try to test the app reg i get an 403 forbidden:

$conn = Connect-PnPOnline -Url $url -ClientId 6af22786-74a9-4aab-968c-bf4901fc8f8c -ClientSecret  "q.xx.7x-xx-"
$Site = Get-PnPSite -Connection $conn

I can confirm this bug as well.  I have tried with PnP PowerShell, Postman, and Graph Explorer making sure the appropriate API permissions were set Sites.FullControl.All on the app before granted the other app Sites.Selected (followed: https://mmsharepoint.wordpress.com/2021/08/18/accessing-sharepoint-sites-with-resource-specific-consent-rsc-and-microsoft-graph/) and get the same issue. This may not be a PnP issue.  I'm open to suggestions.

I tried with pure graph API same result.

@gautamdsheth - Do you have an opinion on that one? 🙂

If it fails with pure Graph API as well, not sure we can do anything about it.
Also, this permission level is still in preview, so I guess would suggest that you reach out to Microsoft about it.

It does not fail with pure Graph API when retrieving an access token manually and calling the API with Postman. Using the same access token and trying to use it with connect-pnponline fails with 401 unauthorized.


Added ability to fetch a 5-day forecast for a single city

Thank you. I've changed branch to a new branch to review and update the readme!

@Staphylococcus Thank you for your help! I've just released a new version (v0.6.0) with your new methods!


OpenAI API incompatiable with some GPT Frontend

The API that used by https://github.com/Yidadaa/ChatGPT-Next-Web is /v1/chat/completions?xxx
The API Server created by vllm offerring api like /v1/completions?xxx

Why is that? Can't VLLM load model for chatting purpose?

Hmmm we do support chat completion in the OpenAI compatible API server as well
See
https://github.com/vllm-project/vllm/blob/8516999495114926c9838c2d6e0feb580d4d983f/vllm/entrypoints/openai/api_server.py#L189-L191

Hmmm we do support chat completion in the OpenAI compatible API server as well
See
https://github.com/vllm-project/vllm/blob/8516999495114926c9838c2d6e0feb580d4d983f/vllm/entrypoints/openai/api_server.py#L189-L191

However in the documentation here it just decleares the v1/completions interface, which is same as what happen when used: When I send via v1/chat/completions interfaces the VLLM logs says NOT FOUND error...
Is the version problem?

That's possible. Can you try the latest version?

@simon-mo I am using the latest https://github.com/vllm-project/vllm/releases/tag/v0.2.1.post1 version.

Ah you might be hitting the model name check issue
https://github.com/vllm-project/vllm/blob/8516999495114926c9838c2d6e0feb580d4d983f/vllm/entrypoints/openai/api_server.py#L62-L69
You might want to start with server with parameter --served-model-name gpt-3.5-turbo or something else that your client is expecting.

@simon-mo Ah...you might spot the real reason! Thank you very much! Maybe can be merged into the documentation for better experience for other developer?

Definitely! Contribution welcomed here.


[ted] Unable to extract info json

Make sure you are using the latest version:

[x] I've verified and I assure that I'm running youtube-dl 2017.06.25

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
$ youtube-dl -v http://www.ted.com/talks/julie_lythcott_haims_how_to_raise_successful_kids_without_over_parenting
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://www.ted.com/talks/julie_lythcott_haims_how_to_raise_successful_kids_without_over_parenting']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.06.25
[debug] Python version 3.4.5
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[ted] julie_lythcott_haims_how_to_raise_successful_kids_without_over_parenting: Downloading webpage
[ted] julie_lythcott_haims_how_to_raise_successful_kids_without_over_parenting: Extracting information
ERROR: Unable to extract info json; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube-dl/youtube_dl/YoutubeDL.py", line 762, in extract_info
    ie_result = ie.extract(url)
  File "youtube-dl/youtube_dl/extractor/common.py", line 433, in extract
    ie_result = self._real_extract(url)
  File "youtube-dl/youtube_dl/extractor/ted.py", line 127, in _real_extract
    return self._talk_info(url, name)
  File "youtube-dl/youtube_dl/extractor/ted.py", line 154, in _talk_info
    talk_info = self._extract_info(webpage)['talks'][0]
  File "youtube-dl/youtube_dl/extractor/ted.py", line 117, in _extract_info
    webpage, 'info json')
  File "youtube-dl/youtube_dl/extractor/common.py", line 782, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract info json; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

This issue occurs with any TED talk.

@dstftw Thanks I confirm this works fine.


Query whether HOOK can cancel the current record

Your Question
I perform some Redis operations in AfterFind to prevent duplicate recommendations (do not return the current record), I read the documentation and issues and it is not resolved

The document you expected this should be explained
https://gorm.io/zh_CN/docs/hooks.html#查询对象

Expected answer

I can return an error, or call an api to not return this record

The AfterFind hook is not the place to filter or exclude records from the result set. It's invoked after the query has been executed and the results have been loaded. You can use it to perform transformations on the data or update some fields, but not to exclude records from the result set.
If you want to exclude certain records based on some Redis operations, you should do that in the query or manually filter the results after GORM has returned them.


fix(deis-dev/manifests/deis-minio-service.yaml): make the minio service listen on port 80

Fixes #138
Ref deis/deis#4853
cc/ @smothiki @kmala

@bacongobbler were you able to get a cluster to successfully run with this change? In my testing the database went into CrashLoopBackoff

I think these are relevant logs here are the relevant logs from the database pod:
/docker-entrypoint.sh: running /docker-entrypoint-initdb.d/002_create_bucket.sh
Traceback (most recent call last):
  File "/bin/create_bucket", line 21, in <module>
    conn.meta.client.head_bucket(Bucket=bucket_name)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 231, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 478, in _make_api_call
    operation_model, request_dict)
  File "/usr/local/lib/python2.7/dist-packages/botocore/endpoint.py", line 117, in make_request
    return self._send_request(request_dict, operation_model)
  File "/usr/local/lib/python2.7/dist-packages/botocore/endpoint.py", line 146, in _send_request
    success_response, exception):
  File "/usr/local/lib/python2.7/dist-packages/botocore/endpoint.py", line 219, in _needs_retry
    caught_exception=caught_exception)
  File "/usr/local/lib/python2.7/dist-packages/botocore/hooks.py", line 226, in emit
    return self._emit(event_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/hooks.py", line 209, in _emit
    response = handler(**kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 250, in __call__
    caught_exception)
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 273, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 313, in __call__
    caught_exception)
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 222, in __call__
    return self._check_caught_exception(attempt_number, caught_exception)
  File "/usr/local/lib/python2.7/dist-packages/botocore/retryhandler.py", line 355, in _check_caught_exception
    raise caught_exception
botocore.exceptions.ConnectionClosedError: Connection was closed before we received a valid response from endpoint URL: "http://<IP_ADDRESS>:80/dbwal".

botocore.exceptions.ConnectionClosedError: Connection was closed before we received a valid response from endpoint URL: "http://<IP_ADDRESS>:80/dbwal".

That's an interesting error. The database saw the service port change but it's not able to receive a response from minio?

apparently so, however, minio does seem to get requests from the database after the bucket create failure happens. those requests fail, of course, because the bucket doesn't exist :(

Interesting. I'll revoke my LGTM until I get to the bottom of this.

Sounds good, thanks @bacongobbler

I came to the same conclusion, but I do not know why we cannot connect to minio. Perhaps this is the same issue as to why we cannot get minio working as a standalone docker image for https://github.com/deis/postgres/issues/41?
In other words, connecting differently than how minio is configured: https://github.com/deis/minio/blob/addf8e6225cab434b546795a532284fa8db16f73/boot.go#L131

Perhaps we should punt on this one for now? Seems like a nitpick more than a significant change, at least for the time being.

I'm good with that. However, this is a requirement to close https://github.com/deis/deis/issues/4853, which is also on beta. @slack thoughts on moving https://github.com/deis/deis/issues/4853 to RC1?

If we expect folks to want to upgrade in-place from Beta to RC or Release then we should do this before beta.
I know these changes (deis/deis#4853 and deis/deis#4952) are introducing instability in the 11th hour. I believe that even while late, it puts on a better footing for post beta activities. If there is consensus that it isn't worth it, we can move these issues to RC.

@slack ah, yea, I forgot about that small (!) point

Just to clarify my comment a bit further. There certainly no love lost if we do move these to RC! I see both sides on this one.

So here was the uncaught error from minio that I've since fixed with https://github.com/deis/postgres/pull/61:
Traceback (most recent call last):
  File "/bin/create_bucket", line 22, in <module>
    conn.meta.client.head_bucket(Bucket=bucket_name)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 231, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 489, in _make_api_call
    raise ClientError(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (403) when calling the HeadBucket operation: Forbidden

And the issue is (bum-bada-bum-bummm!) boto3! Who would've guessed that the port number is significant to boto3?
root@deis-database-59l70:/# cat /etc/wal-e.d/env/S3_URL
http://<IP_ADDRESS>:80
root@deis-database-59l70:/# envdir /etc/wal-e.d/env create_bucket
Traceback (most recent call last):
  File "/bin/create_bucket", line 21, in <module>
    conn.meta.client.head_bucket(Bucket=bucket_name)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 231, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 489, in _make_api_call
    raise ClientError(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (403) when calling the HeadBucket operation: Forbidden

Changing S3_URL just a bit...
root@deis-database-59l70:/# cat /etc/wal-e.d/env/S3_URL
http://<IP_ADDRESS>
root@deis-database-59l70:/# envdir /etc/wal-e.d/env create_bucket
root@deis-database-59l70:/# echo $?
0

God I hate boto3 some days.

Still some more boto3 bugs...
./docker-entrypoint.sh: running /docker-entrypoint-initdb.d/003_restore_from_backup.sh
Rebooting postgres to enable archive mode
LOG:  received smart shutdown request
LOG:  autovacuum launcher shutting down
LOG:  shutting down
waiting for server to shut down....LOG:  database system is shut down
 done
server stopped
waiting for server to start....LOG:  database system was shut down at 2016-03-05 01:56:17 UTC
LOG:  MultiXact member wraparound protections are now enabled
LOG:  database system is ready to accept connections
LOG:  autovacuum launcher started
 done
server started
wal_e.main   CRITICAL MSG: An unprocessed exception has avoided all error handling
        DETAIL: Traceback (most recent call last):
          File "/usr/local/lib/python2.7/dist-packages/wal_e/cmd.py", line 532, in main
            backup_cxt.backup_list(query=args.QUERY, detail=args.detail)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/operator/backup.py", line 66, in backup_list
            for bi in bl_iter:
          File "/usr/local/lib/python2.7/dist-packages/wal_e/worker/base.py", line 153, in __iter__
            for key in self._backup_list(self.layout.basebackups()):
          File "/usr/local/lib/python2.7/dist-packages/boto3/resources/collection.py", line 83, in __iter__
            for page in self.pages():
          File "/usr/local/lib/python2.7/dist-packages/boto3/resources/collection.py", line 166, in pages
            for page in pages:
          File "/usr/local/lib/python2.7/dist-packages/botocore/paginate.py", line 99, in __iter__
            response = self._make_request(current_kwargs)
          File "/usr/local/lib/python2.7/dist-packages/botocore/paginate.py", line 171, in _make_request
            return self._method(**current_kwargs)
          File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 228, in _api_call
            return self._make_api_call(operation_name, kwargs)
          File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 486, in _make_api_call
            raise ClientError(parsed_response, operation_name)
        ClientError: An error occurred (SignatureDoesNotMatch) when calling the ListObjects operation: The request signature we calculated does not match the signature you provided.

        STRUCTURED: time=2016-03-05T01:56:19.502750-00 pid=860
No backups found. Performing an initial backup...
wal_e.main   INFO     MSG: starting WAL-E
        DETAIL: The subcommand is "backup-push".
        STRUCTURED: time=2016-03-05T01:56:19.649489-00 pid=867
wal_e.operator.backup INFO     MSG: start upload postgres version metadata
        DETAIL: Uploading to s3://dbwal/basebackups_005/base_000000010000000000000002_00000040/extended_version.txt.
        STRUCTURED: time=2016-03-05T01:56:19.955556-00 pid=867
wal_e.blobstore.s3.calling_format INFO     MSG: connecting to S3 with WALE_S3_ENDPOINT (http://<IP_ADDRESS>:80)
        STRUCTURED: time=2016-03-05T01:56:19.955980-00 pid=867
botocore.credentials INFO     Found credentials in environment variables.
boto3.resources.action INFO     Calling s3:put_object with {'Body': <cStringIO.StringI object at 0x7f84fd4f2828>, u'Bucket': 'dbwal', 'Key': 'basebackups_005/base_000000010000000000000002_00000040/extended_version.txt'}
botocore.vendored.requests.packages.urllib3.connectionpool INFO     Starting new HTTP connection (1): <IP_ADDRESS>
wal_e.operator.backup WARNING  MSG: blocking on sending WAL segments
        DETAIL: The backup was not completed successfully, but we have to wait anyway.  See README: TODO about pg_cancel_backup
        STRUCTURED: time=2016-03-05T01:56:19.993189-00 pid=867
NOTICE:  WAL archiving is not enabled; you must ensure that all required WAL segments are copied through other means to complete the backup
wal_e.main   CRITICAL MSG: An unprocessed exception has avoided all error handling
        DETAIL: Traceback (most recent call last):
          File "/usr/local/lib/python2.7/dist-packages/wal_e/cmd.py", line 557, in main
            pool_size=args.pool_size)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/operator/backup.py", line 197, in database_backup
            **kwargs)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/operator/backup.py", line 487, in _upload_pg_cluster_dir
            content_encoding='text/plain')
          File "/usr/local/lib/python2.7/dist-packages/wal_e/worker/worker_util.py", line 13, in uri_put_file
            content_encoding=content_encoding)
          File "/usr/local/lib/python2.7/dist-packages/wal_e/blobstore/s3/s3_util.py", line 51, in uri_put_file
            k = bucket.put_object(Key=url_tup.path.lstrip('/'), Body=fp)
          File "/usr/local/lib/python2.7/dist-packages/boto3/resources/factory.py", line 481, in do_action
            response = action(self, *args, **kwargs)
          File "/usr/local/lib/python2.7/dist-packages/boto3/resources/action.py", line 83, in __call__
            response = getattr(parent.meta.client, operation_name)(**params)
          File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 228, in _api_call
            return self._make_api_call(operation_name, kwargs)
          File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 486, in _make_api_call
            raise ClientError(parsed_response, operation_name)
        ClientError: An error occurred (SignatureDoesNotMatch) when calling the PutObject operation: The request signature we calculated does not match the signature you provided.

        STRUCTURED: time=2016-03-05T01:56:20.042688-00 pid=867

@bacongobbler since deis/postgres#61 has been merged, is this now working?

This is still not working due to the above errors. I have not been able to determine what causes this issue to occur once you change the port number.

k, thanks for letting me know. gonna hold off on this still

Can we close this PR

@arschles @smothiki  can we close this?

yes. let's close for now and open a ticket on deis/postgres


Add etcd and Calico Roles

Calico is a new virtual network solution, and it's added in the project
to enable the IP per container functionality.
etcd is added in the project as a key-value storage and a service
discovery mechanism for Calico.

@loshkovskyi Pardon my ignorance on this topic, but why can't Consul be used for a K/V store and service discovery?

@siddharthist there is no Consul support in Calico. In addition, I started working on Calico for Kubernetes which doesn't support Consul as well. I'm not fond of using multiple service discovery tools either. But we could work this out iteratively. For example, we could contribute Consul support for Calico by writing a new datastore or making the datastore pluggable.

@siddharthist @loshkovskyi The plan is to slowly move towards consul and remove the need for etcd. There are two locations in Calico that will need changes. One is pluggable and we can write a new datastore type (as linked above in @loshkovskyi 's comment) to support consul fairly easily. The other however is hardcoded and will need integrating into calico more deeply. The calico team are onboard to help if we want to make this happen, but it wasnt as high on the priority list as proving out a working MI/Calico integration. Hope this info helps?
Matt

I think it's important to add that in order to use Calico, we first need to merge this PR: https://github.com/CiscoCloud/microservices-infrastructure/pull/483
I have tested that PR with floating IPs number of times. The reason is simple: we can't update Neutron ports to allow Calico traffic on shared Neutron networks. That is, we need to create our own network, attach it to a router and then connect VMs to that network. When we create a private network, we need to connect to it somehow to deploy our code. So we could allocate and use floating IPs for such deployments.

Related PR https://github.com/CiscoCloud/microservices-infrastructure/pull/618
For some reasons I'm no longer able to change the environment variable DOCKER_HOST for mesos-slave in Mesos 0.23.0. Perhaps, it has something to do with the latest changes in Mesos containerazier. It works well with Mesos 0.22.1. Moreover, Marathon hasn't been tested enough with Mesos 0.23.0. More details in the issue https://github.com/CiscoCloud/microservices-infrastructure/issues/614

I have resolved this problem, so we can use Mesos 0.23.0 now.
I think I have covered all questions here. I will rebase my commits, sync with the latest master and open a new pull request.

New PR https://github.com/CiscoCloud/microservices-infrastructure/pull/626


Finding the negative cycle in a graph

The program will find the negative cycle if present in the graph.

@veenit1802 mention the language.

I will be doing it in cpp.

Hey @rudrakshi99
I am a GSSoC'21 participant. I would like to do this problem in Java.
Can you assign me this issue

Hey @rudrakshi99
I am a GSSoC'21 participant.
I would like to do this problem in CPP with well-explained code.
You can assign this issue to me.

Hey @rudrakshi99
I am a GSSOC'21 participant.
I would love to do this problem in PYTHON3 with proper comment, indentation and test-cases.
Please assign this issue to me.

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.


Monkey patch

https://datarobot.atlassian.net/browse/PRED-1587 implemented a quick hack to address a failure in batch-scoring. This code addresses the problem more directly.
The code needs to be tested in python 2.7 and python 3.x because there is a use of a python 3.x library function (functools.lru_cache) that has no backport in python 2.7, so I provided an implementation. I will merge only after local tests show it working in both python environments with various numbers of concurrent thread counts.

I still do not fully understand what was the initial problem. @hughdbrown, could you please write a comment just near a monkey-patch with explanations why do we need it?
P.S: If the problem is that getaddrinfo is not thread-safe, why do we need lru_cache? Why just to do not monkey-patch it where we acquire some lock and call original implementation? It seems like introducing caching is not related to the bug at the first glance.

Coverage increased (+0.3%) to 82.712% when pulling 914b7409af13cf86d797aa6be16f135be77f5f58 on monkey-patch into bc81f05781428d38fced61eaf864a037add97e0d on master.

Coverage increased (+0.3%) to 82.753% when pulling 914b7409af13cf86d797aa6be16f135be77f5f58 on monkey-patch into bc81f05781428d38fced61eaf864a037add97e0d on master.

Coverage increased (+0.3%) to 82.703% when pulling 914b7409af13cf86d797aa6be16f135be77f5f58 on monkey-patch into bc81f05781428d38fced61eaf864a037add97e0d on master.


How to set this up with a multi-stage docker built and using node server.js

When following the Docker build that Vercel recommends here (https://github.com/vercel/next.js/blob/canary/examples/with-docker/Dockerfile), they use a multi stage build and runs node server.js when it starts.
Because of this, next-runtime-env does not execute and doesn't generate the __ENV.js file that is needed.
Not sure if there's some way make this work like https://github.com/kHRISl33t/runtime-env-cra did for the create-react-app projects.

I ended up adding the following line to my Docker entrypoint:
node -e "const { configureRuntimeEnv } = require('next-runtime-env/build/configure'); configureRuntimeEnv();"
That ensures that environment variables are loaded before node server.js starts.

@bhl-0 I just found the same problem in my setup

If you're using the App Router, you no longer need to update your next.config.js to use this package. That would indirectly resolve your issue 🙂
We've completely revamped our solution to support Server Components and the App Router. 🙌
Please check the development branch for docs and examples.
We've also published a version 2.0.0-alpha.1 on NPM. 🚀


Max AR on ITEM not possible over 255

How to reproduce:
On you script create an item with 255 Armor
[ITEMDEF 013c5]
DEFNAME=i_leather_sleeves
NAME=Brassard en cuir
TYPE=t_armor_leather
FLIP=1
ARMOR=255

You will see 255 Armor. and you can go higher with adding modAR EX: modar 10

Infortunatly, if you set AR 256 on script, it go to 0

But you can add modAR 10 too and get 10 of AR.
The bug is you cant create an AR over 255 by default. At least, we should have a decent option of 1000 for some custom shard.

It's not a bug, it's the maximum value for the data type assigned used for the old AR value

ah no it's a word, should be allowed up to 65k

Changed.

Fast Fix and working good!  Thx VM


Regulated organization: fill in all information

https://www.figma.com/file/35NiapHpSyGcZP24H2HWZF/Ideation-Co-design-wires?node-id=544%3A17092

[x] Headquarters location
[x] Type of regulated entity
[x] About (with capability of uploading a file)
[x] What we offer
[x] Accessibility and Inclusion
[ ] Website and social media links

Resolved in #485.


Usage create_element_attributes_through_ti

I'm struggling with how to use "create_element_attributes_through_ti".
I see in the code:
statements = ["AttrInsert('{}', '', '{}', '{}');".format(dimension.name, ea.name, ea.attribute_type[0])
for ea
but I fail to understand where these ea values and properties are coming from.
I searched the examples, but alas...
Do you have an example how I could use this?

Hi @hermie64,
it's a list comprehension. The AttrInsert statements are created based on element_attributes property of the hierarchy.
            statements = ["AttrInsert('{}', '', '{}', '{}');".format(dimension.name, ea.name, ea.attribute_type[0])
                          for ea
                          in h.element_attributes]

The function is from 2017. I believe it was created because back then there was an issue in the REST API w.r.t. creating element attributes. The function is essentially obsolete in TM1 11.

So in TM1 11, to add an element attribute to a dimension/hierarchy, you can do it in a more straightforward way like this:
from TM1py import TM1Service

with TM1Service(address="", port=12354, ssl=True, user="admin", password="apple") as tm1:
    hierarchy = tm1.hierarchies.get(dimension_name='d1', hierarchy_name='d1')

    hierarchy.add_element_attribute(name='New Attribute', attribute_type='String')

    tm1.hierarchies.update(hierarchy)

Hi @MariusWirtz,
OK, thanks for clarifying!


Allow to use non-arm instances

Hi. I'm trying to run this module with t2.micro, and I can't use it b/c of the wrong (?) arm regex checker. I'm not a master of regex, but for me, it looks a little bit wrong. I was trying to use regex101 but found redundant backslashes.
[a-zA-Z]+\\d+g[a-z]*\\..+ should be [a-zA-Z]+\d+g[a-z]*\..+
╷
│ Error: Error in function call
│
│   on .terraform/modules/fck-nat/main.tf line 2, in locals:
│    2:   is_arm             = regex("[a-zA-Z]+\\d+g[a-z]*\\..+", var.instance_type) == var.instance_type
│     ├────────────────
│     │ while calling regex(pattern, string)
│     │ var.instance_type is "t2.micro"
│
│ Call to function "regex" failed: pattern did not match any part of the given string.

Hi, I'm away for now so I won't be able to debug this. As for your comment on the regex itself, double backslash is needed to escape the backslash itself for Terraform.
To make it work you might want to try t4g instances which are cheaper than T2 (T3 is actually cheaper than T2 as well), you'd run ARM though.

Yeah, it's cheaper but not free (for free-tier).


Raw dataset importer

Changes:

Ported over the raw importer from my Unity plugin
Added a window for changing the import settings so that users can import custom raw datasets.
Added a small sample dataset (this is nice for testing btw, since it's fast to read)

Question:
I added my scripts to a new "RawDatasetImporter" folder. Should we maybe put all importer-related code inside an "Importer" folder? I guess the number of files is going to grow a bit..

Yes, I think is better to put all importer-related code inside a dedicated folder

Fixed! :)

Perfect, very nice ;)


Throttle Not Decreasing

For some reason, when I press the throttle down key bind, nothing happens and the plane doesn't slow. Is there any way of visualising the throttle to see if it is decreasing.

Also, the brakes don't seem to be working

Can you share your project files, or at minimum your AeroBody scene?

Looks like this issue is already solved in the main branch, so I've pushed out a new release, 0.6.0. Let me know if you have any other issues after updating.

I think the throttle is decresing, however, i'm not sure the brakes are working. I have the "Brake Control -> Positive Event" set to the space bar, however, the plane seems to not be slowing down. I have some labels on the side of the screen, using the AeroUnits Global, showing Altitude and Speed. When the plane is on the ground, and I hold the space bar, the plane slows, but very very slowly, but I think this is not the brakes doing the slowing.

There's not really a way to display throttle, other than printing the AeroBody throttle.
As for the brakes, are you trying to use the vehicle wheel brakes? My control system doesn't interact with the VehicleWheels, but maybe I should adjust it so that it does.

Printing the AeroBody throttle should work, how can I do this?
For the brakes, I have attached a seperate script to some VehicleWheels, and that seems to work.

Its fine I worked it out. Thanks.


cmd/go: go list prints the wrong Origin data for the version resolved from a non-semver query

What version of Go are you using (go version)?

$ go version
go version devel go1.21-18e17e2c Thu Jun 29 23:06:46 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/usr/local/google/home/bcmills/.cache/go-build'
GOENV='/usr/local/google/home/bcmills/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/tmp/tmp.oKChmSObvX/.gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/tmp/tmp.oKChmSObvX/.gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/google/home/bcmills/sdk/gotip'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/google/home/bcmills/sdk/gotip/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='devel go1.21-18e17e2c Thu Jun 29 23:06:46 2023 +0000'
GCCGO='/usr/bin/gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3913236638=/tmp/go-build -gno-record-gcc-switches'

What did you do?
$ go list -json -m -e golang.org/x/exp@master

What did you expect to see?
A result with either a non-cacheable Origin (currently, an empty Hash, TagSum, and RepoSum), or an Origin with a Ref matching the one we would need to re-resolve in the upstream repo.
What did you see instead?
When a proxy is used, the result may include a cacheable Origin, as if the command had requested the fully-resolved version instead of a query:
$ go list -json -m -e golang.org/x/exp@master
{
        "Path": "golang.org/x/exp",
        "Version": "v0.0.0-20230713183714-613f0c0eb8a1",
        "Query": "master",
        "Time": "2023-07-13T18:37:14Z",
        "GoMod"<EMAIL_ADDRESS>        "GoVersion": "1.20",
        "Origin": {
                "VCS": "git",
                "URL": "https://go.googlesource.com/exp",
                "Hash": "613f0c0eb8a17a98ecdb096a7f9f7d5053c1c963"
        }
}

(Found while investigating #61415.)

if the Version field prints the resolved version, why shouldn't the Origin field print the origin data corresponding to that version?

Perhaps it should?
But in that case, the -reuse flag will need to know to invalidate it.


Make Metadata DB Calls more reusable

User Story
As a ReportStream developer, I want to minimize duplicate code to make the program more maintainable.
Description/Use Case
The code in the database classes related to fetching from the Metadata tables is very specialized at the moment. For example, Delivery Facilities directly fetches formatted facility data.
Risks/Impacts/Considerations
Reusable code is not always the fastest code, there may be queries that need to keep their code unique.
Dev Notes
Identify and update queries where possible so that use-case-specific formatting is not done in the Database classes.
Acceptance Criteria

[ ] Reduction of copy/pasted code on Metadata-related DB code

Hey team! Please add your planning poker estimate with Zenhub @arnejduranovic @jack-h-wang @mkalish @thetaurean @victor-chaparro


Question: how can we best support sqlite3_auto_extension for adding extensions?

sqlite3_auto_extension is an exported function and needed for adding extensions to sqlite. I do not immediately see a direct C# equivalent in this library. How can we best do this with this library?

It might not be difficult for me to add support for that function, but I suspect it would end up being very difficult to use.
The docs indicate this function is for statically linked extensions, but almost everyone that uses SQLitePCLRaw is using the dynamic libraries that come as part of its bundle packages.
Even if we did somehow support that function, what would you pass to it?  We currently don't provide any easy way to write SQLite extensions in C#.  Where would you get the function pointer?
Currently I'm guessing the most natural way to approach this problem would be to do your own custom SQLite build with your extension compiled in, and initialize the SQLite provider manually instead of using a bundle package.

I think that it would be a very useful extension of the library if you could add a function to load static extensions (usually written in C/C++). Compiling these into the core sqlite library is not a good approach, also because then you need to call the initialization function of each extension in some way.
What would be very useful is to have a function which calls sqlite3_auto_extension internally with the path of the extension dll and the name of the initializer. The function should get the function pointer from the dll. This should then enable the extension for all subsequent connections.
The other solution is the already existing sqlite3_enable_load_extension/sqlite3_load_extension functions, but this needs to be called for each connection.

Compiling these into the core sqlite library is not a good approach,

I'm not saying it's a good approach.  I'm saying it is an approach that is available to you now.  Furthermore, if it is true (as the docs suggest) that sqlite3_auto_extension actually requires that the extension be statically linked with SQLite itself, then a custom native build is the only option.

also because then you need to call the initialization function of each extension in some way.

No.  What I was suggesting was you could create a DLL that contains a custom build of SQLite AND your extension and do the sqlite3_auto_extension call yourself.
And the reason I made this suggestion, again, is because the docs for sqlite3_auto_extension say that it is for statically linked extensions.  You propose passing it a function pointer obtained from a different DLL.  Have you verified that this will work?

Yes, I can do this in C++/C with a dll extension (not statically linked to sqlite). It would be great if you could make this in C# with the library.

If you want to make some tests here is an extension that you can compile for testing: https://www.sqlite.org/src/file?name=ext/misc/zipfile.c or this https://www.sqlite.org/src/file?name=ext/misc/spellfix.c

Okay.  I'll investigate the possibility of adding this feature as soon as I can.  Thanks.

@zsogitbe.  It sounds like you want to make a dynamic library which loads itself persistently and then registers as an automatic extension so that any future connections use it automatically.
I believe the canonical example is https://sqlite.org/src/file/ext/misc/vfsstat.c which calls sqlite3_auto_extension "on itself" and then returns SQLITE_OK_LOAD_PERMANENTLY. This allows the extension it to be loaded dynamically but still used on every connection.
It is most appropriate to do this from the extension itself because the return value from the extension initializer is of critical importance. If you tried this approach with a dynamically loaded extension that was not expecting to be used with  sqlite3_auto_extension, it would return SQLITE_OK at the end of its extension initializer instead of SQLITE_OK_LOAD_PERMANENTLY. When the first connection closes the extension would still be unloaded.
In other words, what you want to do is possible, but should probably be done entirely from within the extension itself.
Doing it that way would not require any modifications or extensions to the exposed SQLitePCLRaw API.

@sjlombardo unfortunately, this solution just keeps the dll in process, but the extension still need to be registered for each connection: "To clarify: an extension for which the initialization function returns SQLITE_OK_LOAD_PERMANENTLY continues to exist in memory after the database connection closes. However, the extension is not automatically registered with subsequent database connections.

@sjlombardo & @ericsink, I was able to modify my C++ code based on @sjlombardo's example and use the existing infrastructure in SQLitePCL.raw to load a module permanently for all future connections with sqlite3_load_extension. There are a few important things to note:

The example is misleading because it is not enough to just register the sqlite3_create_module  part of the extension! You need to recreate everything you have created before registering the extension. For example, if you define functions, then you need to define them again in the sqlite3_auto_extension() callback. If you do not do this, then the auto loading will fail and you will not be able to open the DB in the given process forever.

Thank you for your input!


Supporting two module which dependency by 'InternalsVisibleTo'.

I have two modules. One module reference another module by invoking its internal member by setting the 'InternalsVisibleTo'.
Could the internal symbol name be obfuscated but the reference still works? If I just write two module section in configuration XML, is it works?

You’d better try and come back with results.


Blue color of dark-mode code-block

Greetings.
For users that have dark mode on and a blue-light filter active, the blue color of the code-block (for variables) is invisible.
It's a pretty dark blue - maybe a lighter one will have a little more contrast?
Is there a way I can modify this color?

Like __name__ in the screenshot below?

I see what you're saying - it is pretty dark.
How's this?

The syntax highlighting uses two different shades of blue - so it's quite tricky making them both differentiated enough, but still visible on dark backgrounds.
We could just use something other than blue.

I've added a PR which lightens the shade of blue, it's easy enough to tweak it further though.

Yeah - the second shade of blue is visible and ok to see
Thank you 👍

OK, cool - will merge that in. Can always tweak in the future.


Remove JODA Time

Removing JODA time will introduce some creaking changes as the way time zones are formatted has changed between JODA time and the Java 7 Time API
Formatting the time zone as +0000 used to be Z now it's Z but preferably xx
Formatting the time zone as +00:00 used to be ZZ now it's xxx
Formatting the time zone as Europe/London used to be ZZZ now it's VV


changing show_datetimes does nothing

hello so i tried setting show_datetimes to false in config but that dosent do anything

What version of twitch-tui are you on? Please post the output of twt --version.
Thanks!

Oops, I thought I had fixed it at some point and it was in one of the newer versions. Turns out I had never fixed it, but now it'll appear in the next release.
Fixed in b54755d515e8bf3af2e95b7ffbe90fbb647b1ec7.
Thanks for the issue!

https://github.com/Xithrius/twitch-tui/releases/tag/v2.5.0

well now it shows this

I'm also getting that same error when trying to run on Windows.

@Dark-Sol could you paste your config without the token? Thanks.

@Dark-Sol could you paste your config without the token? Thanks.

Sure can!
[twitch]
# Your username on Twitch.
username = "[username removed]"
# The streamer's name.
channel = "[removed]"
# The IRC channel you'd like to connect to.
server = "irc.chat.twitch.tv"
# OAuth token that authenticates you into Twitch. Acquired through https://twitchapps.com/tmi/.
token = "[token removed]"

[terminal]
# The delay in milliseconds between terminal updates.
tick_delay = 30
# The maximum amount of messages to be stored.
maximum_messages = 150
# The file path to log to.
log_file = ""
# The state the application will start in.
start_state = "dashboard"

[storage]
# If previous channels switched to should be tracked.
channels = false
# If previous username mentions should be tracked.
mentions = false

[filters]
# If filters should be enabled at all.
enabled = false
# If the regex filters should be reversed.
reversed = false

[frontend]
# If the time and date is to be shown.
date_shown = true
# The format of the date and time outputs. Formats can be found at https://strftime.org/.
date_format = "%Y-%m-%d %H:%M:%S"
# If the username should be shown.
username_shown = true
# The color palette for the username column: pastel (default), vibrant, warm, cool.
palette = "pastel"
# Show title with time and channel.
title_shown = true
# The amount of space between the chat window and the terminal border.
margin = 0
# Show twitch badges next to usernames.
badges = false
# The theme of the frontend, dark (default), or light.
theme = "dark"
# If the user's name appears in chat, highlight it.
username_highlight = true
# If there should be state tabs shown on the bottom of the terminal
state_tabs = true
# The shape of the cursor, block (default), underscore, or line.
cursor_shape = "block"
# If the cursor should be blinking in input boxes.
blinking_cursor = false
# If the scrolling should be inverted.
inverted_scrolling = false
# If scroll offset should be shown (bottom right of chat window).
show_scroll_offset = false
# Show twitch emotes.
twitch_emotes = false
# Show betterttv emotes.
betterttv_emotes = false
# Show 7tv emotes.
seventv_emotes = false
# Array of channel names as strings to be displayed at start screen.
start_screen_channels = [removed]
# What the style of the border should be.
border_type = "plain"
# If the usernames should be aligned to the right instead of the left.
right_align_usernames = false

Off the top of my head, probably something to do with authentication stuff. I'll be able to look into it in a couple hours.

Should be fixed in https://github.com/Xithrius/twitch-tui/releases/tag/v2.5.1.
If you still experience panics, please let me know.


Cannot yarn start after installing dependencies

Hi,
Tried to run the game using yarn and yarn start in an AWS instance. I changed the port to 3000, but as the image below shows, something is wrong with the client. (Everything works properly when using docker-compose up or yarn serve)

Hi @pelillian,
Do you have any errors showing up? I never tried to launch the game with yarn start in a production environment.
When using yarn serve, the game's files are being served directly by the server itself on port 3001 (the game's files are copied over in the Dockerfile). When using yarn start you play the game on port 3000 and contact the server on port 3001 (they are both launched at the same time with concurrently). I do not know exactly how create-react-app behaves when launched on server (even less with concurrently binary).
What is your need to launch the game with yarn start on the server? This could give me some more context.

Oh, in README.md under the development section it says to start the server with yarn start. I’m able to use serve but I wanted to use nodemon.
I guess I’ll just use serve in the future.


Remove specs without open changes for git-sync-fork

@charlierudolph @allewun @ricmatsui
Implements parts of #506

Looks like you also need to rename
features/main_branch/no_conflicts_with_open_changes.feature
to
features/main_branch/no_conflicts.feature
After that, :ship:

good catch


Reevaluate 'inclusion' as prefix for metrics

Sitting in the OSS Summit, there is a CTA (on the heels of XZ to focus on 'trust' (which makes sense) but what doesn't make sense is the idea that this is an area for new ideas, rather than a time build on a lot of work that already exists (and broader community) has been doing for a decade.  I think some of the work is invisible, because it's framed under the context of diversity/incursion and thus feels more  like a nice to have, than must have for people who (frankly) don't invest in those metrics, but who care about this 'trust' attribute.
I want to propose a revisiting to metrics prefixed with inclusion to evaluate if they should just be statements about how things should be done for 'trust'.   Specifically starting with Inclusive Leadership, but perhaps expanding to Inclusivity Labels. Something like 'trusted leadership' or just 'Leadership'. Something like that, but less opinionated on name, than proposing we find a way to elevate and make visible this existing work for people to build on.
So my proposal is not to change it from being about inclusion (that matters) but shift the language to make it feel more relevant to what is in front of people - and right now thats security + risk = trust.

Thanks for this Emma. We talked about it in our DEI WG meeting and we are sort of leaning towards the development of a new metric -- Accountable Leadership (?). @ElizabethN is going to start this as a new metric and we would love your input when we have a bit more to share.

sounds good, sorry I couldn't make the meeting. Will follow along, contribute as I can

I dropped this in slack, but there is a first draft of the Accountable Leadership metric here for anyone who would like to contribute!

Just doing a little cleanup in the repo today! We could never land on a solid document for this. I'm going to bring this up in the next DEI working group meeting, but for now I'm going to close this issue.


Translate Editor-Setup page

Translate Editor-Setup page

@harshilparmar@idarshan181@TheRakeshPurohit
can anyone please review this PR?

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

@harshilparmar Yes, I have read the Gujarati Glossary table words.
I would like to know, is there any mistake in the current PR?

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

@harshilparmar Yes, I have read the Gujarati Glossary table words. I would like to know, is there any mistake in the current PR?

I have found few changes where exact translation is not conveying the meaning in Gujarati. I will mention it here.
Note: Its good to use translation service as assistant but it should be align with Gujarati grammar and context.

@harshilparmar could you please let me know what changes are needed so I can fix it?

@harshilparmar could you please let me know what changes are needed so I can fix it?

I have suggested some changes to specific lines. Please review them and make the necessary revisions.

@idarshan181 My system does not display the changes you suggested. Did you submit them?

@idarshan181 @harshilparmar Thank you for your feedback. I made the changes. Please re-review.

@harshilparmar changes done, Please re-review

@shubhamkhunt04 Ok thanks, I don't think there is anything left but I will review it over the weekend and give my last suggestion if any.

@shubhamkhunt04 Ok thanks, I don't think there is anything left but I will review it over the weekend and give my last suggestion if any.

Sure!

@harshilparmar @idarshan181 @TheRakeshPurohit
Could you please let me know if there have been any updates on this pull request (PR)? I appreciate your time and attention on this PR. Let me know if anything needs to be changed. Thanks again!

@harshilparmar changes are done!

Thanks @shubhamkhunt04 🥳 Congratulation for contributing to first translation page of react gujarati.

Thanks @shubhamkhunt04 🥳 Congratulation for contributing to first translation page of react gujarati.

@harshilparmar Thank you so much :D


Avoid failing when res['invocation'] has no module_name key

Tries to address #18

Merging. Thanks again @oryband for reporting the issue!


Entering blank answer ends process

Entering no text for a guess stops the process and returns this error:
Error in wrong.location + right.location :    non-numeric argument to binary operator

I think this is somehow related to #2 because there is no check for word length.  i think it may require some kind of nested while situation to work together with the spell check step

Related to word length but causes an error before our word length check. May be able to add something directly to the readline call? Either way, solution lies in the guess_fn

Leaving a note for my future self (or whoever tried to fix this): probably best way to fix this, and avoid future problems is move the checks to directly after the readline call in the guess_fn and do the reprompting within that function


DOC: move documentation to versioned folders

Copy pytorch/audio#992  and pytorch/text#1075 to this repo.
ping @brianjo. This enhancement to the gh-pages branch

creates the documents in structured directories to allow versioning
creates the first version of documentation in the gh-pages branch. Previously documentation was copied into the pytorch/pytorch documentation build, but that was removed, requiring a special build for the 0.7 documentation. For this PR, 0.8.1 documentation was built and copied to master and 0.8
changes index.html to redirect to stable/index.html
adds a README.md

Todo in future PRS:

add a version selector like on the pytorch site
automate doc building on a merge (to the "master" directory) (see pytorch/audio#1006)
automate doc building on a tag (to a numbered directory) (see pytorch/audio#1006)
rethink serving the _static content. After this PR, each directory uses its own _static subdirectory, i.e, 0.8/index.html uses 0.8/_static resources for stylesheets and javascript. It would be nice if the content were shared across versions, so that a styling update would be applied to the older versions automatically: 0.8/index.html would use /_static.

It might be difficult to review this PR because of all the added files. I added a README.md to try to explain how it should work.

ping. The audio and text subprojects have merged the equivalent of this PR. I also submitted follow on work to the master docs on the nightly CI builds and push them to the gh-pages branch of the repo, and am waiting for this to go in to do the same here.

@fmassa @brianjo: thoughts?

@fmassa @brianjo: thoughts?

Sorry I missed this. I'll mege today after our meeting. Thanks!

Sorry I missed this. I'll mege today after our meeting. Thanks!

@fmassa Can you take a look at merging this? I'm getting an error.

@fmassa Can you take a look at merging this? I'm getting an error.


Rework ibc::ics04_channel::events module

Crate
ibc
Summary
The various channel events defined in the ibc::ics04_channel::events module are all defined as newtypes over the same Attributes which has some optional fields which are expected to always be defined for specific events. As such, this forces us to unwrap these values in some places. We should refactor this module to perform this check when parsing the source event, and perhaps refactor the parsing code a little bit while we're at it.

For Admin Use

[x] Not duplicate issue
[x] Appropriate labels applied
[x] Appropriate milestone (priority) applied
[x] Appropriate contributors tagged
[x] Contributor assigned/self-assigned

@romac  I've made a draft implementation here https://github.com/Wizdave97/ibc-rs/blob/david/rework-channel-events/modules/src/core/ics04_channel/events.rs, I want to know if that's on track, especially the use of TryFrom<Attributes> instead of From<Attributes> since the other events still use optional channel_id values,  or do I enforce existence of channel_id on all other events?


fix: MeetingDetails dates are nullable

Fixes #6336

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll

Pull Request Test Coverage Report for Build 305177

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 78.945%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs
3
89.62%

Totals

Change from base Build 304888:
-0.003%

Covered Lines:
25373

Relevant Lines:
32140

💛  - Coveralls


Timesheet - 12/04/2021 - Usman Khalid

Task 1

Edited the information at thenewboston channel under the information category.
Answering Discord-related queries of the community.

Proof of Work

Check thenewboston channel under the information category. https://discord.com/channels/774574985510518806/775322546387157002/775356264548663316

Time Spent
1.5 hours

Account Number
86cbaa1e021cc7d21ceedefc493051004c5ffffbc09a4ecd25e3a8dc49975d3e

Hey @Rajputusman there are some texts from the issue template in this report can you please remove them and then label it Ready for Review when done

Approved

Approved

we close this now, because the payment has been sent.


⚠ ClamAV has degraded performance

In 24712dd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 227 ms

Resolved: ClamAV performance has improved in fdf232c.


Android - Expenses - "Unexpected error" when submitting track expense to someone

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Open the Expensify app
Open self DM
Tap on the "+" button and select "Track Expense"
Complete the expense creation flow and send it to chat
On the options displayed below the expense, select "Submit to Someone"
Submit the expense to any other user
Navigate to the chat where the expense was sent
Open the expense report and wait for one or two minutes
Verify all the information is displayed correctly and no error is displayed

Expected Result:
After creating a track expense and selecting "Submit to Someone", the expense should be submitted to the selected user without any error
Actual Result:
"Unexpected error submitting this expense" message is displayed in expense report, a few minutes after creating a track expense and selecting the "Submit to Someone" option."
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/4789367d-bcaa-4124-94a9-3e7dde1ca71e
View all open jobs on GitHub

Dupe of https://github.com/Expensify/App/issues/45086


ci: Also build wheels for aarch64 to allow use in embedded systems

As github runners can be used with qemu we simply emulate the aarch64 cpu needed to build for it. This allows faster installations on tradionally weaker embedded hardware.
The full aarch64 run roughly takes  90 minutes which should be taken into consideration if it is worth the occasional but additional time investment on release.

I dont think the python 3.7 failures are due to the PR. They also pop up on the previous head
https://github.com/Mimoja/dbus-fast/actions/runs/9673188373/job/26686694693

I'll rip out 3.7 support later today if my flight isn't delayed

As github runners can be used with qemu we simply emulate the aarch64 cpu needed to build for it. This allows faster installations on tradionally weaker embedded hardware.
The full aarch64 run roughly takes  90 minutes which should be taken into consideration if it is worth the occasional but additional time investment on release.

It's no problem to do the aarch64 as well since the shell builds happen after the release and get uploaded lazily

first build failed. I think https://github.com/Bluetooth-Devices/dbus-fast/pull/285 will fix it

new attempt is https://github.com/Bluetooth-Devices/dbus-fast/actions/runs/9674505623

Awesome. Thank you!

Can confirm install working now perfectly fine on aarch64 musl and glibc. And it can now be installed on low memory systems which previously failed \0/


WIP: Run buildkite agent on instances rather than docker

This simplifies the whole setup and eliminates a layer of docker-in-docker.

is this still the direction you're shooting for? Agents directly on the machines?

I'm kind of torn on this. The downside is that it's very difficult to support multiple parallel docker versions. I think probably no.

Yeah, perhaps you'd create a new cluster to test a new Docker version? And I guess a project could depend on a new Docker feature… but I guess the downside of running on bare metal is they're less disposable / more cruft-accreting?


Loading nvm is unbelievably slow (7-46 seconds)

I've been using nvm for quite some time now and I recently installed it on a new laptop running Ubuntu 16.04. I've been experiencing extremely high load times: between 7 and 46 seconds on both zsh (my primary shell) as well as bash.
Here's the output of nvm debug (I had chsh-ed to try bash):
nvm --version: v0.32.0
$SHELL: /bin/bash
$HOME: /home/vivek
$NVM_DIR: '$HOME/.nvm'
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
nvm current: v6.7.0
which node: $NVM_DIR/versions/node/v6.7.0/bin/node
which iojs: iojs not found
which npm: $NVM_DIR/versions/node/v6.7.0/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v6.7.0
npm root -g: $NVM_DIR/versions/node/v6.7.0/lib/node_modules

I tried rm -rf ~/.nvm and reinstalled, but there was no improvement. I downgraded to 0.31.7 and saw some improvement - most load times were around 7 seconds now.
Please let me know whether there are some additional debugging steps that might help - I really can't believe that loading nvm could be this slow without something messing around!

Try changing the line in your profile that sources nvm to something like . "$NVM_DIR/nvm.sh" --no-use - does that speed it up?

Yep, nvm use is the culprit. After the sub-second source, running nvm use default took a full 47 seconds!

Is there a local workaround solution to this issue? Or is it just something that nvm will have to fix?

I'm not aware of a workaround, since I'm still not sure why it's particularly slow. npm config get prefix is the slowest part of nvm use, but it usually adds 400ms, while the rest of the command takes another 400ms - it wouldn't explain 7 seconds.

What's interesting is that this only happens the first time I load nvm after boot. All future loads in other terminal tabs are pretty fast, about ~1 second. What's different the first time it loads?

Hmm, that's a good question. I wonder if your filesystem is caching things (like what's inside $NVM_DIR, or something)?

Any ideas on how I could check whether it's doing that? $NVM_DIR is about 390 MB in size, though, so it definitely can't be caching all of it.
Also, is there a good way for me to profile each step in the loading process? I could put a set -v and change my PS4 to echo the time, but any better way? Maybe I can confirm what causes the slowdown on my system.

I was thinking it cached the directory listing (not the contents), but I have no idea.
I know that zsh offers profiling like that, but I've no idea how to use it :-/ If you can figure out some profiling that would help a ton.

Right, that definitely makes more sense. :P
I'm busy the next couple of days, but after that, I'll try to profile stuff and let you know how that goes.

Last boot, loading nvm took about 8 seconds. I ran zmodload zsh/zprof before loading nvm, and then ran zprof to get the profiling output. The results are in a gist here: https://gist.github.com/polybuildr/26d7fafdac767b8c9a83d5a9de509260
I haven't analyzed the output much yet (will try again in a couple of days), but just the zprof output might be useful.

@polybuildr thanks! As expected, nvm_die_on_prefix takes the most time (because it's calling npm config get prefix). It does, however, seem like that's called more times than it should be - I'm not sure how to read zprof output. Can you clarify which lines constitute distinct calls into nvm_die_on_prefix?

As far as I can tell from the zprof output, it looks like it only gets called once every time (from the "calls" column). I tried to see - crudely - how many seconds the npm config get prefix call takes:
Called 'npm config get prefix'...
Thu Oct 27 16:04:03 IST 2016
Thu Oct 27 16:04:03 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 16:04:03 IST 2016
Thu Oct 27 16:04:04 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 17:05:21 IST 2016
Thu Oct 27 17:05:21 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 17:31:20 IST 2016
Thu Oct 27 17:31:21 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 18:32:09 IST 2016
Thu Oct 27 18:32:09 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 19:30:57 IST 2016
Thu Oct 27 19:30:58 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 19:57:00 IST 2016
Thu Oct 27 19:57:00 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 20:30:07 IST 2016
Thu Oct 27 20:30:08 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 20:56:59 IST 2016
Thu Oct 27 20:57:00 IST 2016
Called!
Called 'npm config get prefix'...
Thu Oct 27 23:38:57 IST 2016
Thu Oct 27 23:39:06 IST 2016
Called!

Mostly 1 or 2 seconds, but sometimes ~9 seconds. Any idea why this drastic variation? Also, are there any other possible culprits than npm config get prefix that I should specifically look into?

I'm not sure why there's variation - it's all internal to npm.
Other than that, there's calls into nvm_ls (via nvm_version via nvm_ensure_version_installed) that are probably also slowing things down.

Last boot, the load time was 70 seconds :disappointed: I did another zprof and got this: https://gist.github.com/polybuildr/9aeb92664146a289383f9e19a9a57089
So whatever it is, it definitely happens inside nvm_die_on_prefix. The log for tracking npm config get prefix showed:
Called 'npm config get prefix'...
Fri Oct 28 10:35:05 IST 2016
Fri Oct 28 10:36:15 IST 2016
Called!

So, while there are some other issues, this is definitely the whopper. As a workaround, I've simply hardcoded my current version's npm prefix where nvm.sh makes the call to npm. I tend to use the same version of node everywhere, so until I update, this shouldn't cause any problems, should it?
Additionally, I think I should also file a bug in npm - 70 seconds just seems crazy!

@polybuildr filing an issue in npm would be great, and yes, hardcoding that won't break as long as when you update, you use the normal install script, and as long as you never set the "prefix" config :-)

I've filed the issue at npm/npm#14458.

Oh and thanks a lot for confirming that this hardcoding solution will work for now! :)

I'm also experiences incredible slow load time for NVM.
real	0m11.387s
user	0m1.308s
sys	0m0.608s

Timing . "$NVM_DIR/nvm.sh"
I'm trying to understand the work-around - where exactly do I write the node version?

I added a bunch of debug info to find the slow parts of nvm initialization on a small embedded system (Raspberry Pi-like) and most of the slow load time is due to the two times that npm is called during nvm use.  Once for npm --version and once for npm config --loglevel=warn get prefix.
If I want to know what the npm version is, I can just run npm --version myself (and wait about 3 seconds on a good day when caches are nicely primed).
I don't understand exactly what nvm_die_on_prefix is doing but it seems like I can safely skip this entire function on shell init at least.
@ljharb what do you think about skipping these two calls to npm on shell init, perhaps with environment variables to opt in, like NVM_SKIP_NPM_VERSION and NVM_SKIP_PREFIX_CHECKS?  Under what situations is it actually necessary to call nvm_die_on_prefix?
The next slowest portion of init is nvm_resolve_local_alias default, so it might also be a good idea to be able to specify an exact version to use on init.

@nylen you're quite right that the npm invocations are what's slowing everything down. You can use --silent on most commands and it will skip the npm --version call, but that's not really slow anyways - npm config get prefix is.
And no, I will not allow any way to skip the prefix checks; it's necessary on every single call to nvm use.

Ok, can you explain a bit about what the prefix checks are actually doing?

Sure. The prefix is what determines npm root -g, ie, where npm installs global modules and links. nvm requires that location be inside its own version dirs, and is incompatible with that setting.
Many people have it set from following ill-advised tutorials, for example. By adding these checks, a very very large number of monthly bug reports stopped coming in.
Basically, it's doing npm config get prefix, and then if that location isn't inside the nvm version dir, it errors out.

On this small machine I'm using, npm --version is just about as slow as npm config get prefix (3 seconds from a well-primed cache, details at https://github.com/npm/npm/issues/14458#issuecomment-366882873).  nvm_resolve_local_alias default is not far behind at about 1.5 seconds.
I would still like a way to skip as many of those three phases as possible (npm --version, npm config get prefix, and nvm_resolve_local_alias default).  I'm happy to submit PRs if we can agree on a general approach.

nvm use --silent whatever will skip the version call; the auto-use-on-source logic already passes --silent.
the "default" resolution only happens when an explicit version is not provided, or with auto-use-on-source.
the auto-use-on-source logic can be bypassed by changing the sourcing line in your profile file to have --no-use at the end

You're right, I removed --silent while adding debug info, so this was a bug I introduced.
the "default" resolution happens with auto-use-on-source - I'd like to be able to skip this.  I know what the default version of node is on this system and I'm fine with specifying that manually.
"the auto-use-on-source logic can be bypassed" - This is true, but I only have node installed through nvm (no system version) because that's by far the most convenient way to do it.  So doing this defeats much of the point of using nvm.

nvm_resolve_local_alias default is basically just cat-ing a file; i'm pretty surprised that's a slow operation on any system. If you can think of ways to speed up alias resolution, I'm all for it.

The approach in https://github.com/creationix/nvm/pull/1737 works well for me.

https://github.com/nylen/dotfiles/commit/9483fc583b01efbb651d5348b8da45a0a86c4772 also works for me and doesn't require any modifications to nvm code.
Before these changes, initializing nvm takes about 6 seconds on a primed page cache and 15 seconds on a non-primed cache.  After, well under 1 second regardless of cache state.
For me, personally, the performance improvement is dramatic and well worth the trade-offs.

I made a dynamic NVM loader to speed things up. This way we don't run the NVM loader code every time we open a new terminal window.
#!/bin/zsh
# ~/loadnvm.sh

#delete this alias
unalias nvm

#(this is the loader code nvm put in my .bashrc)
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

#pass on the arguments of the alias to nvm
nvm "$@"

and then in .zshrc (or .bashrc)
# nvm
alias nvm='. ~/loadnvm.sh'

You could even put this script in your .nvm directory if you don't want it cluttering your $HOME.

Don't forget npx, and all the global packages installed in your default node version. Also iojs if it's v1-v3.

So I am now using this code snippet and it has really used my startup time in zsh shell while ensuring that I also have access to global packages as well as yarn globals and yarn project have same node env version.
export NVM_DIR="$HOME/.nvm"
#[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
#[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

NODE_GLOBALS=(`find ~/.nvm/versions/node -maxdepth 3 -type l -wholename '*/bin/*' | xargs -n1 basename | sort | uniq`)
NODE_GLOBALS+=(node nvm yarn)

_load_nvm() {
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
}

for cmd in "${NODE_GLOBALS[@]}"; do
eval "function ${cmd}(){ unset -f ${NODE_GLOBALS[*]}; _load_nvm; unset -f _load_nvm; ${cmd} \$@; }"
done
unset cmd NODE_GLOBALS

export PATH="$PATH:$HOME/.yarn/bin"```


Add detect() method for the space-between-declarations.js

To reproduce:
Put mystyle.css into the project root directory.
mystyle.css.txt
Run:
csscomb -d mystyle.css
Observe:

Apply the current PR changes, run the command again and observe:

Hi! Me again :D
Would you can refresh this too?


Fix display of "Double spend" of inscription

Last Friday I sent an inscription from Account 1 → 2.
I want to test sending it again, so I sent my full balance to account 1 → 2 to fund account. On broadcast of this tx, the UI showed that I sent the inscription again.
Note that after getting mined this tx looks as expected

When mined

This is a display bug, not anything deeper, correct?

Duplicate of #5079
Seems like a filtering issue


chore: increment dynamodb_lock version

Description
cc @houqp @rtyler  will need one of you to help with publishing a new release.
Related Issue(s)
For example:

closes #1191

Documentation

@wjones127 sent you an invite to the create!


should have good documentation: basic, advanced usage and how to develop teracy-dev

basically, done.


fix the tenant list in add account dialog

the tenant list is not correctly implemented, it is not showing anything and has wrong size.
use tab key to navigate to the remove button (shown in screenshot below)

and now press tab key, you will get to the blank screen and the account list disappeared.

please either remove the tenant list or fix it.

Can we have proper tenant list implemented? As today Data Studio does not work when having multiple tenant under same account, and especially with MFA enabled

This has since been fixed, so closing.


Default branch on codecov.io is seemingly incorrect

When navigating to codecov.io, the default branch appears to be master. I think this is probably the cause of the README coverage badge displaying "unknown".
CircleCI also seems to be using the master branch instead of main.

Removed the badges. Couldn't make codecov one to work and not using CircleCI anymore.


Add optional AWS Config Paramater: 'Token'

Hi. I'll accept the PR once the merge conflict is fixed.

Accidentally closed. Sorry.

I just tried the patch. You didn't run the tests, right, because they are not adapted and fail to compile.


V1.5

What does this PR mean?

Merged the main branch with this branch, so I got the last commit from there;
Add missing dependencies;
Fixed some errors.

Done, thanks 🚀


Remix 1.17.0 support

Hey 👋
I came across this package because I was interested in what my JS bundle contains.
During my search I came across Kent's call and your package which both should support analysis of the bundle.
However, with the current version of Remix (1.17.0 at the time of writing). I don't believe any of the provided solutions work with the current codebase. I'd love to help with this, but I'm not familiar with how the @remix-run/dev package works 😅

Thanks. Yes, there have been a lot of changes to the dev compiler in recent releases. I haven't had a chance to update the patch to support this. When I have some free time, I'll create one.

I'll be closing this off as this is now supported in the latest Remix release 😊