Error: [object Object] is not a PostCSS plugin After updating to Angular 11.1.0

🐞 bug report
Affected Package
the application itself
Is this a regression?
Not a regression
Description
I updated my app from Angular 11.0.9 to Angular 11.1.0 because there was a bug with the HttpClient and now it doesn't compile
🔬 Minimal Reproduction
I ran
ng update @angular/cdk @angular/core @angular/cli @angular/material
Process finished successfully
And then tried to ng serve or ng build and yields the output below
🔥 Exception or Error

✔ Browser application bundle generation complete.

Error: ./src/main.ts
Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) Error: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: [object Object] is not a PostCSS plugin
    at Processor.normalize (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:168:15)
    at new Processor (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:52:25)
    at postcss (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/postcss.js:55:10)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:94:41)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/webpack/lib/NormalModule.js:313:13
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/@ngtools/webpack/src/ivy/loader.js:57:9
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
 @ multi ./src/main.ts main[0]

Error: ./src/polyfills.ts
Module build failed (from ./node_modules/@ngtools/webpack/src/ivy/index.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) Error: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: [object Object] is not a PostCSS plugin
    at Processor.normalize (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:168:15)
    at new Processor (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:52:25)
    at postcss (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/postcss.js:55:10)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:94:41)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/webpack/lib/NormalModule.js:313:13
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/@ngtools/webpack/src/ivy/loader.js:57:9
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
 @ multi ./src/polyfills.ts polyfills[0]

Error: ./src/bootstrap-grid.min.css
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: [object Object] is not a PostCSS plugin
    at Processor.normalize (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:168:15)
    at new Processor (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:52:25)
    at postcss (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/postcss.js:55:10)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:94:41)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/webpack/lib/NormalModule.js:316:20
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:103:7)
 @ multi ./src/assets/style/tailwind-out.css ./src/bootstrap-grid.min.css ./src/assets/style/styles.scss styles[1]

Error: ./src/assets/style/tailwind-out.css
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: [object Object] is not a PostCSS plugin
    at Processor.normalize (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:168:15)
    at new Processor (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/processor.js:52:25)
    at postcss (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss/lib/postcss.js:55:10)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:94:41)
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/webpack/lib/NormalModule.js:316:20
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at Object.loader (/Users/miquel/AngularProjects/mit-evida/frontend/web/node_modules/postcss-loader/dist/index.js:103:7)
 @ multi ./src/assets/style/tailwind-out.css ./src/bootstrap-grid.min.css ./src/assets/style/styles.scss styles[0]

Error: ./src/assets/style/styles.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: [object Object] is not a PostCSS plugin

🌍  Your Environment
Angular Version:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 11.1.0
Node: 14.15.0
OS: darwin x64

Angular: 11.1.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1101.0
@angular-devkit/build-angular   0.1101.0
@angular-devkit/core            11.1.0
@angular-devkit/schematics      11.1.0
@schematics/angular             11.1.0
@schematics/update              0.1101.0
rxjs                            6.6.3
typescript                      4.0.5

Anything else relevant?
Nothing else, can't build the app

In the reproduction from @jerkovicl the main.js has the following code:
ApiService.ɵfac = function ApiService_Factory(t) { return new (t || ApiService)(_angular_core__WEBPACK_IMPORTED_MODULE_2__["ɵɵinject"](_angular_common_http__WEBPACK_IMPORTED_MODULE_3__["HttpClient"])); };
ApiService.ɵprov = _angular_core__WEBPACK_IMPORTED_MODULE_2__["ɵɵdefineInjectable"]({ token: ApiService, factory: ApiService.ɵfac });
ApiService = Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__decorate"])([
    Object(_ngneat_until_destroy__WEBPACK_IMPORTED_MODULE_1__["UntilDestroy"])({ checkProperties: true }),
    Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__metadata"])("design:paramtypes", [HttpClient])
], ApiService);

You can note that there is a bare HttpClient identifier, which has no definition. Earlier on you see _angular_common_http__WEBPACK_IMPORTED_MODULE_3__["HttpClient"], which does work.
Looking at the output of the Angular compiler (before webpack) we see:
ApiService.ɵfac = function ApiService_Factory(t) { return new (t || ApiService)(i0.ɵɵinject(i1.HttpClient)); };
ApiService.ɵprov = i0.ɵɵdefineInjectable({ token: ApiService, factory: ApiService.ɵfac });
ApiService = __decorate([
    UntilDestroy({ checkProperties: true }),
    __metadata("design:paramtypes", [HttpClient])
], ApiService);
export { ApiService };
(function () { (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(ApiService, [{
        type: Injectable
    }], function () { return [{ type: i1.HttpClient }]; }, null); })();

Here you can see that there are i1.HttpClient references, which are the ones that get converted to the webpack imports.
But the __decorate() handler contains the bare HttpClient, which is what is undefined later on.

In the reproduction from @jerkovicl the main.js has the following code:
ApiService.ɵfac = function ApiService_Factory(t) { return new (t || ApiService)(_angular_core__WEBPACK_IMPORTED_MODULE_2__["ɵɵinject"](_angular_common_http__WEBPACK_IMPORTED_MODULE_3__["HttpClient"])); };
ApiService.ɵprov = _angular_core__WEBPACK_IMPORTED_MODULE_2__["ɵɵdefineInjectable"]({ token: ApiService, factory: ApiService.ɵfac });
ApiService = Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__decorate"])([
    Object(_ngneat_until_destroy__WEBPACK_IMPORTED_MODULE_1__["UntilDestroy"])({ checkProperties: true }),
    Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__metadata"])("design:paramtypes", [HttpClient])
], ApiService);

You can note that there is a bare HttpClient identifier, which has no definition. Earlier on you see _angular_common_http__WEBPACK_IMPORTED_MODULE_3__["HttpClient"], which does work.
Looking at the output of the Angular compiler (before webpack) we see:
ApiService.ɵfac = function ApiService_Factory(t) { return new (t || ApiService)(i0.ɵɵinject(i1.HttpClient)); };
ApiService.ɵprov = i0.ɵɵdefineInjectable({ token: ApiService, factory: ApiService.ɵfac });
ApiService = __decorate([
    UntilDestroy({ checkProperties: true }),
    __metadata("design:paramtypes", [HttpClient])
], ApiService);
export { ApiService };
(function () { (typeof ngDevMode === "undefined" || ngDevMode) && i0.ɵsetClassMetadata(ApiService, [{
        type: Injectable
    }], function () { return [{ type: i1.HttpClient }]; }, null); })();

Here you can see that there are i1.HttpClient references, which are the ones that get converted to the webpack imports.
But the __decorate() handler contains the bare HttpClient, which is what is undefined later on.

Update on the missing HttpClient import... This code that is problematic is being generated by TypeScript because of the tsconfig setting: "emitDecoratorMetadata": true,.  Setting this to false avoids generating this code, which is redundant in almost all cases anyway, and fixes the problem.
The only time when this setting needs to be true is if your application queries the metadata at runtime, which is fairly rare these days and if you are doing so then you probably know what you are doing.
That being said, we should probably work out why this import is being dropped...

Update on the missing HttpClient import... This code that is problematic is being generated by TypeScript because of the tsconfig setting: "emitDecoratorMetadata": true,.  Setting this to false avoids generating this code, which is redundant in almost all cases anyway, and fixes the problem.
The only time when this setting needs to be true is if your application queries the metadata at runtime, which is fairly rare these days and if you are doing so then you probably know what you are doing.
That being said, we should probably work out why this import is being dropped...

I note from the ngc output that it is TypeScript (or Angular) that is dropping the HttpClient import.
Source:
import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { UntilDestroy } from '@ngneat/until-destroy';
import { Observable } from 'rxjs';
@UntilDestroy({ checkProperties: true })
@Injectable()
export class ApiService {

Compiled:
import { __decorate } from "tslib";
import { Injectable } from '@angular/core';
import { UntilDestroy } from '@ngneat/until-destroy';
import * as i0 from "@angular/core";
import * as i1 from "@angular/common/http";
let ApiService = class ApiService {
    constructor(http) {
        this.http = http;
    }

I note from the ngc output that it is TypeScript (or Angular) that is dropping the HttpClient import.
Source:
import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { UntilDestroy } from '@ngneat/until-destroy';
import { Observable } from 'rxjs';
@UntilDestroy({ checkProperties: true })
@Injectable()
export class ApiService {

Compiled:
import { __decorate } from "tslib";
import { Injectable } from '@angular/core';
import { UntilDestroy } from '@ngneat/until-destroy';
import * as i0 from "@angular/core";
import * as i1 from "@angular/common/http";
let ApiService = class ApiService {
    constructor(http) {
        this.http = http;
    }

My refrenceError with angular-cli 11.1.0 is with Observable like as
@select('controls') readonly controls$: Observable<RegistrationCompControl>;
Keeping @angular 11.1.0 and downgrading of the cli to 11.0.7 resolved my problem for now.

My refrenceError with angular-cli 11.1.0 is with Observable like as
@select('controls') readonly controls$: Observable<RegistrationCompControl>;
Keeping @angular 11.1.0 and downgrading of the cli to 11.0.7 resolved my problem for now.

I can reproduce the issues reference errors; disabling the new Ivy integration in the CLI does not show the same issue so there appears to be some bug there. A workaround could be to set the environment variable NG_BUILD_IVY_LEGACY=1 which deactivates the new Ivy plugin.

I can reproduce the issues reference errors; disabling the new Ivy integration in the CLI does not show the same issue so there appears to be some bug there. A workaround could be to set the environment variable NG_BUILD_IVY_LEGACY=1 which deactivates the new Ivy plugin.

Good news for the HttpClient reference errors (and other reference errors): the root cause has already been found and is being addressed in #19841

Good news for the HttpClient reference errors (and other reference errors): the root cause has already been found and is being addressed in #19841

The postcss errors have been traced to an npm package hoisting inconsistency which causes the wrong version of postcss to be used.  From initial tests, it does not appear that yarn is affected.  However, a fix is currently pending for the CLI (#19847) that will force the postcss-loader package (using a recently released new option) to use the correct version of postcss even in these cases.
In regards to the reference errors (fix pending as well: #19841), the emitDecoratorMetadata option is responsible for the initial creation of the code that is being subsequently broken.  This TypeScript configuration option is no longer required by Angular (8.0.4+) and newly created projects no longer contain the option. Unless a third-party library or application code specifically requires the option, it can be safely removed. The need for this option is generally uncommon. Also of note is that the option generates code (more details) that has the potential to cause runtime errors with certain source code constructs.
However, for the cases where the option is required, a fix will be in the next patch release.

The postcss errors have been traced to an npm package hoisting inconsistency which causes the wrong version of postcss to be used.  From initial tests, it does not appear that yarn is affected.  However, a fix is currently pending for the CLI (#19847) that will force the postcss-loader package (using a recently released new option) to use the correct version of postcss even in these cases.
In regards to the reference errors (fix pending as well: #19841), the emitDecoratorMetadata option is responsible for the initial creation of the code that is being subsequently broken.  This TypeScript configuration option is no longer required by Angular (8.0.4+) and newly created projects no longer contain the option. Unless a third-party library or application code specifically requires the option, it can be safely removed. The need for this option is generally uncommon. Also of note is that the option generates code (more details) that has the potential to cause runtime errors with certain source code constructs.
However, for the cases where the option is required, a fix will be in the next patch release.

Just published v11.1.1 which should contain the necessary fixes for this issue. Please update to that version.

Just published v11.1.1 which should contain the necessary fixes for this issue. Please update to that version.

I solved this by running:
rm -rf node_modules && npm cache clear --force && npm install

Works like a Magic :)

I solved this by running:
rm -rf node_modules && npm cache clear --force && npm install

Works like a Magic :)


Added icons for arrow keys

Summary
As it says on the tin, this adds an icon for arrow keys rather than depending on an emoji (which might get replaced in WP by some other image).
This is a follow-up to #4525.

Verified in QA

Verified in QA


init container to decide allowing reconciliation of manager

we want to run manager only when required, i.e, we are going to reconcile and manage CSI among other operands. we are achieving that by adding an init container which only get successful if client-operator is deployed standalone or running in provider configured odf cluster.
Depends on: red-hat-storage/ocs-operator#2717
ref: red-hat-storage/odf-operator#450

/cherry-pick release-4.16

/hold

Testing:
- No StorageCluster CRD
I0729 14:00:24.636988 2124186 main.go:51] StorageCluster CRD not found and proceeding with reconciliation of operands

- CRD exists but not storagecluster
I0729 13:51:26.625930 2120304 main.go:77] Waiting for StorageCluster to be deployed
I0729 13:51:31.638621 2120304 main.go:77] Waiting for StorageCluster to be deployed
^Csignal: interrupt

- storagecluster exists but not in Provider mode
> k -nopenshift-storage get storagecluster/ocs-storagecluster -ojsonpath='{.metadata.annotations}' | jq 'del(."kubectl.kubernetes.io/last-applied-configuration")'
{
  "uninstall.ocs.openshift.io/cleanup-policy": "delete",
  "uninstall.ocs.openshift.io/mode": "graceful"
}
I0729 13:52:24.907032 2120630 main.go:79] Waiting for StorageCluster deployed mode to be 'Provider'
I0729 13:52:30.179057 2120630 main.go:79] Waiting for StorageCluster deployed mode to be 'Provider'
^Csignal: interrupt

> k -nopenshift-storage get storagecluster/ocs-storagecluster -ojsonpath='{.metadata.annotations}' | jq 'del(."kubectl.kubernetes.io/last-applied-configuration")'
{
  "mode": "provider",
  "uninstall.ocs.openshift.io/cleanup-policy": "delete",
  "uninstall.ocs.openshift.io/mode": "graceful"
}
I0729 13:56:41.060310 2123137 main.go:72] StorageCluster is configured to run in 'Provider' mode and proceeding with reconciliation of operands

update to the client-console deployment is yet to be tested.

Why do we need a new service account an a new RBAC? Why can't we just use the operators SA and RBAC?

We have two deployments in CSV, client-op (custom sa) and client-console (default sa)
We need to inject sidecar into both of these deployments, however custom sa in client-op is enough for it's init containers but using the same which has more privilege for init container in client-console didn't seem good
Reusing client-op sa for client-console reduces good chunk of rbac in this PR which I could do based on your comment, wdyt?

I realized something when replying to the comments, CSV will only be successful if Pod is in Running state, with an init container, pod will only be in Running state after init which could potentially fail d/s CI. Overall we might need to rethink on this.

Why do we need a new service account an a new RBAC? Why can't we just use the operators SA and RBAC?

We have two deployments in CSV, client-op (custom sa) and client-console (default sa)
We need to inject sidecar into both of these deployments, however custom sa in client-op is enough for it's init containers but using the same which has more privilege for init container in client-console didn't seem good
Reusing client-op sa for client-console reduces good chunk of rbac in this PR which I could do based on your comment, wdyt?

I realized something when replying to the comments, CSV will only be successful if Pod is in Running state, with an init container, pod will only be in Running state after init which could potentially fail d/s CI. Overall we might need to rethink on this.

CI should take into account that this pod is waiting on installation, not the other way around

Tested:

client-op is running standalone : proceed
client-op is installed alongside odf with
a. storagecluster doesn't exist : wait
b. storagecluster not in provider mode: wait
c. storagecluster in provider mode: proceed

I have raised tracker issues for other u/s projects which tries to consume client-op as olm bundles, need to fix them if those projects required updated client-op bundles:
red-hat-storage/ocs-operator#2722
red-hat-storage/odf-operator#461

/lgtm

/unhold


refactor: Move github-action to topic folder

Task:

Move github-action folder to topic folder
Update the https://github.com/tungbq/devops-basic#topic table to point to new location of github-action

Similar task with #118, and PR #125

Done


Correct misspellings of Jeni Tennison's name. Fixes issue #143

This pull request affects only comments in files to correct misspellings of Jeni Tennison's name as reported in issue #143.
Many of the affected comments are copyright statements and contain a notice to not alter the comment. This change only corrects a misspelling and does not alter the meaning of the text in any way, so I think this is a reasonable change.

@cirulls could this be included in version 1.1?

@vincentml: I'm archiving the branch issue/143 you used for this pull request (now merged into master).

Fixes #143


how to use IntelliJ for java example

I finally can build java example. it's cool but how can use IntelliJ to programming and build a project.
I want to use JavaFX and maven in IntelliJ to build a desktop application, can anyone help me?

I use IntelliJ to develop Java solution. Once you've built the Java example, you can copy all the Java files *.java into Maven source directory src/main/java. Don't forget the generated one — org.drinkless.tdlib.TdApi.java. Once you've copied everything, the structure looks like:
$ tree src/main/java/
src/main/java/
├── yourpackage
│   ├── A.java
│   ├── B.java
│   └── C.java
└── org
    └── drinkless
        └── tdlib
            ├── Client.java
            ├── Log.java
            ├── TdApi.java
            └── example
                └── Example.java

You can now develop your own solution as a usual Maven project. However, there's a tricky point for execution. You must include the Telegram Database library (JNI) to run your final JAR:
$ java -Djava.library.path=/path/to/tdlib -jar /path/to/jar

tnx @mincong-h,  I don't look to org.drinkless.tdlib folder after the build Java.
it looks like fine but I have two another problem

how to run the project from IntelliJ? I add java.library.path=/Users/peter/Downloads/td/ to VM options of Run/Debug Configurations bug get this error
Error: Could not find or load main class java.library.path=.Users.peter.Downloads.td.
I use this library for java packager.
how to add tdlib to it or another library for java packager? JavaFX-maven-plugin can add VM option my question is how to add tdlib to it for all windows

-Djava.library.path=/Users/peter/Downloads/td/

This path is incorrect. The shared library is stored in /Users/peter/Downloads/td/example/java/bin, which is relevant with the documentation:

Now you can run Java example:
cd <path to TDLib sources>/example/java/bin
java '-Djava.library.path=.' org/drinkless/tdlib/example/Example

tnx @mincong-h,  I run this project on IntelliJ with VM options of Run/Debug configurations.
and in maven, I think maybe need other option to set for compile code but this is not and it's like other projects


Packaging

From the readme, there is no packing and installation.

We have updated the readme with instructions on How to pack and install Kytos SDX Napp. Additionally, we also added the Dockerfile and we added steps on the GitHub actions to build and publish a docker image.


No status updates in ExternalClient.Create implementations are allowed after crossplane-runtime #283

What happened?

After https://github.com/crossplane/crossplane-runtime/pull/283, status updates from managed.ExternalClient.Create implementations are no longer persisted by the crossplane-runtime. However, certain implementations in provider-azure, such as the postgresqlserver.external, attempt to store the future returned from the asynchronous azure-sdk-for-go create call in status.
How can we reproduce it?

crossplane-runtime version consumed in provider-azure is not updated yet to include https://github.com/crossplane/crossplane-runtime/pull/283/. However, this issue is a blocker for it.

I had a debug session for this issue, please see my observations.
Firstly the crossplane-runtime version was upgraded to v0.15.1 that contains the following PR: https://github.com/crossplane/crossplane-runtime/pull/283 Then I provisioned PostgreSqlServer resource that is used the asynchronous azure-sdk-for-go create call.
My first observation is that, create calls after the first one do not cause an error and return HTTP 202 code. And also readiness reporting is not affected by the future storing problem. Because we do not rely to the future for determining the readiness state of resource. We decide to the readiness state with the status conditions of resource and the status conditions are set by using the UserVisibleState field of cloud resource.
However, for some scenarios we need to check the future. For example, the server name must be globally unique. When you try to create a PostgreSqlServer with an existing name, you can only see the error (already exists) by checking the future.
The asynchronous process is used for four resources: PostgreSqlServer, PostgreSqlServerConfiguration, MySqlServer, MySqlServerConfiguration. We may consider the checking future in a different way instead of reading from the status.atProvider.pollingUrl

Linking https://github.com/crossplane/crossplane-runtime/issues/285 . A workaround could be to store the polling URL in the annotations similar to external name so that it is not lost.

Sorry I didn't assign this to myself. I'm working on this as part of https://github.com/crossplane/crossplane-runtime/issues/285.


[Gradle] Log an error where an Android plugin misses gradle files

As we're migrating to a pubspec schema where each plugin specifies exactly the platform it supports, when the Flutter gradle plugin ignores an Android plugin that's missing a build.gradle it should log an error.

this is not needed after https://github.com/flutter/flutter/pull/97823/files


Added get targets action

Fixes #1820
info <user.cursorless_target>:
    target_info = user.private_cursorless_get_targets(cursorless_target)
    print(target_info)

def private_cursorless_get_targets(target: Any) -> list[dict]:
        """Get information about Cursorless target"""
        return actions.user.private_cursorless_command_get(
            {
                "name": "private.getTargets",
                "target": target,
            }
        )

[
    {"contentRange": {"start": {"line": 71, "character": 23}, "end": {"line": 71, "character": 53}}}
]

Checklist

[x] I have added tests
[/] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet

@phillco

Thank you! ❤

@pokey test added


Achieve masking

Hi All,
I have a function that is only defined for a subset of events (it has to use the first muon in the event, if there) and I would like to attach it to the full event table, because I am stubborn :) and to bundle the data. I am looking for something that allows the following:
event_mask = np.array([True, True, False, False, True, False]) # size 6, 3 True
event_observable = awkward.JaggedArray.fromiter([[1,2,3], [4,5,6], [7,8,9]]) # jagged, size 3, only for the true events
awkward.MaskedSomething(event_mask, event_observable) # --> behaves like a shape (6, -) with empty or NaN values in the false part, I don't particularly care

Is there some class that supports this functionality? How? I checked MaskedArray and IndexedMaskedArray, but both require the value to be as large as the mask, which in my case cannot be.

I made it a to-do item yesterday: https://github.com/scikit-hep/awkward-1.0/issues/127
But you can use the IndexedMaskedArray constructor to make option-type data (data with Nones) without changing the length of the content.
What you have to do is make a "mask" that is increasing, non-negative integers for non-masked values and -1 for masked values:
mask = np.full(length_of_table, -1)
mask[selection] = np.arange(np.count_nonzero(selection))
to_put_in_table = awkward.IndexedMaskedArray(mask, events[selection])

The word "mask" is inappropriate here because this is a reshaping index with negative values interpreted as None. It will be changing to "IndexedOptionArray".

Indeed it works, I don't know why it did not when I tried, but thanks!

Sorry to bother again, the masking in this way works, but when trying to compute a deltaR between a Jagged LorentzVectorArray and a flat IndexedMaskedArray I get an exception, the shapes match, I think there is just some assumption in the broadcasting. Now is quite late, I will try to write a simple test case in the next days.
    return self.awkward.numpy.sqrt(self.delta_r2(other))
  File "/home/mverzett/miniconda3/lib/python3.7/site-packages/uproot_methods/classes/TLorentzVector.py", line 86, in delta_r2
    return (self.eta - other.eta)**2 + self.delta_phi(other)**2
  File "/home/mverzett/miniconda3/lib/python3.7/site-packages/numpy/lib/mixins.py", line 25, in func
    return ufunc(self, other)
  File "/home/mverzett/miniconda3/lib/python3.7/site-packages/awkward/array/jagged.py", line 1027, in __array_ufunc__
    content = recurse(data)
  File "/home/mverzett/miniconda3/lib/python3.7/site-packages/awkward/array/jagged.py", line 1024, in recurse
    content[good] = x.reshape(-1)[parents[good]]
  File "/home/mverzett/miniconda3/lib/python3.7/site-packages/awkward/array/base.py", line 256, in __getattr__
    raise AttributeError("no column named {0}".format(repr(where)))
AttributeError: no column named 'reshape'```

This might be related to https://github.com/scikit-hep/uproot/issues/458, though you're not using ChunkedArrays.
Somewhere in there, there's an assumption that an array node's content is a numpy.ndarray, and that assumption is not true. (This is exactly the sort of inconsistency that led me to a rewrite—in Awkward0, some of the arrays are Awkward and some of them are NumPy. Overly strong assumptions didn't get caught in normal usage, but they are caught as we get into more complete usage of the Awkward model: IndexedMaskedArrays and ChunkedArrays).

Here's where it fails:
https://github.com/scikit-hep/awkward-array/blob/a2645fdaed1a6997c4677ae47cbb2cd0663e8a21/awkward/array/jagged.py#L1020-L1025
It's applying a ufunc and needs to broadcast one side of the binary operation to fit the other (or it's just going through the motions, if it already fits). The array it's looking at has a shape (I think I needed to add that to everything so that Pandas or Dask would be happy) and it has multiple, regularly sized dimension (i.e. not 1D and not using arbitrary-length sublists through JaggedArray). The array isn't a NumPy array, so there's no reshape.
Maybe the quick fix is to give all Awkward0 arrays a reshape operation. On any type that allows a non-1D shape, reshape(-1) would just apply reshape(-1) to its starts, stops, index, mask, or other structure array. As a very quick fix, we could just put in an if-statement to catch your array type.
A maybe even quicker fix is to not use regular-sized dimensions in your analysis: use JaggedArrays instead. I think structure1d() does that.
I'm looking for quick-fixes here because Awkward1 is almost ready. It will be glued into Uproot in April, and then it would be the primary version for many users. (Awkward1 doesn't have this issue because it uses a new RegularArray node type to represent rectilinear dimensions for non-NumPy content.)

@jpivarski quick fixes are good for me! :) Can you make an example of structure1d() usage?

(If I remember right!) It's a zero-argument method you can call on any array, or maybe just JaggedArrays. It returns a certain if the same data with regular dimensions replaced by JaggedArrays.

Indeed it works, thanks!


ci: Add docker auth to circleci config

Summary
Update config to add auth.
Related Issues or PRs
closes #633
How To Test

CI should run successfully

@eeeady is this it? Or am I missing something else that needs to happen here

I forgot to comment before... sorry Hana!
It looks like it would work but when I check the workflow in CircleCI it doesn't seem like it's using the credentials. We might need to make changes so that the context stuff works. One moment.

So if you look at the job in circleci it looks good but if you click into "spin up environment" you'll see the lines:

Starting container circleci/node:12.16.2
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
image is cached as circleci/node:12.16.2, but refreshing...
12.16.2: Pulling from circleci/node

so the job isn't using the auth we think you set up.
I think I can make a PR against yours OR I can pull this branch down and make changes. Do you have a preference @haworku ?

We might need to change branch protections to block on "build" rather than "workflow" from circleci.

Made the branch protection change. Checking the build job for the output I want to see.

Output is expected. no warning:

Build-agent version 1.0.48308-8a85a016 (2020-12-10T14:02:10+0000)
Docker Engine Version: 19.03.13
Kernel Version: Linux 3d864dd0b6d4 4.15.0-1077-aws #81-Ubuntu SMP Wed Jun 24 16:48:15 UTC 2020 x86_64 Linux>
Starting container circleci/node:12.16.2
image is cached as circleci/node:12.16.2, but refreshing...
12.16.2: Pulling from circleci/node
Digest: sha256:7335cef9567718b3bfd03cdaaf60d457fd1ee39630d02fad3710f092e6cff072
Status: Image is up to date for circleci/node:12.16.2
pull stats: N/A
time to create container: 3.091s
using image circleci/node@sha256:7335cef9567718b3bfd03cdaaf60d457fd1ee39630d02fad3710f092e6cff072

@eeeady thanks for pointing to the place in the circleci build specifically where the warning was. Entirely missed that!


Does not work with Elden Ring (windows 10 64bit) ?

I tried this program specifically for Elden Ring, since it notoriously allows the mouse cursor to leave the game window every time any kind of menu has been opened regardless of is it "full screen" or "windowed mode" (map, inventory, equipment etc..).
Unfortunately no matter what i tried the AutoCursorLock did not prevent the Elden Ring from allowing the cursor to wander onto my 2nd monitor.
On a side note its a bit unclear what is the meaning of the above red line "Cursor Locked: False" when the below green line states "Locking Enabled: True"... the messages are contradictory and confusing to a simple end user.
No matter what i tried the above message in red did not change from False.
Here is a screenshot of the config (i tried pressing the hotkey many times and exiting & starting up the program).
Thanks for trying to solve this really annoying issue Windows imposes on us all.

Yeah they definitely seem a bit confusing. The lower one is basically whether the program is attempting to detect windows to lock on to. The upper one is whether the cursor is locked at that exact moment.
Would "Locking enabled" -> "Window detection enabled" be better? Or something else.

Does the upper "Cursor Locked" change to True when Elden Ring is in focus?

Hey thanks for replying & explaining!
Honestly i would not mind a more verbose description, be it as the main colored text or as some kind of an additional line of text below the main colored text explaining what the current state & intent is.
I tried ER+AutoCursorLock a few more times and it seems that the above text does change to the green True while ERing is in focus - but the actual mouse cursor itself is not locked in any way.
The mouse cursor in Elden Ring behaves the same with or without AutoCursorLock.
That is to say that as soon as any kind of map/inventory/equipment is open the mouse can leave the ERing window and the only way to lock it back into ERing is to (furiously) click 5+ times into the game window.
Thank you for working on this issue!

Interesting. Can you download and run DebugView (made by Microsoft), and see if there are any errors being printed while using AutoCursorLock?

Hi, I have also tried this and in my case the eldenring process doesn't show up in AutoCursorLock (with and without admin rights).
Before, I tried this program but it (also) lets the cursor wander off to other screens slightly.

Interesting. Can you download and run DebugView

Also having same issue, the cursor just doesn't get locked within Elden Ring (seems working fine for other windows)

Here are the logs from debug view, but there is no error message in here :D

My current workaround is to use Dual Monitor Tools and lock the cursor to a specific monitor and by holding Ctrl I can bypass the lock.

@Aluerie thanks for testing it with DebugView.
The fact that there are no errors means either Elden Ring is not reporting its window size correctly, or it is actually clearing the window lock.
If it's the window size problem then I could add a setting to lock the cursor to a monitor rather than a window. The difference between that and Dual Monitor tools would be that it locks in when the window is in focus, and unlocks as soon as you alt-tab.

The next release will support locking the cursor to the monitor the window is on. Hopefully that fixes the issue.

Unfortunately, again, it works perfectly with other apps/games but Elden Ring (and Sekiro - also Fromsoft's game) - nope.
The logs again don't have any error.

I do own Sekiro so I can test that out later.

It also does not work with the game Grounded, which recently fails to lock my cursor. Neither in "Lock to Window" nor in "Lock to Monitor" mode. Its window name is "Maine-Win64-Shipping", for whatever reason.
Weirdly enough, it also doesn't work for any other program, like VS Code, or Putty. Maybe it's a problem with my machine, perhaps I should try rebooting...
Here's the log file: log.txt

Okay, the game locks the cursor like normal after a reboot, so no need for your tool. Maybe some other unknown program was causing all cursor locks to fail. Sorry for the useless comment above.
(However, it might be helpful for future users to know that a reboot could help)

Extremely late reply, but since I got Elden Ring during this winter sale I decided to troubleshoot this a bit more, and unfortunately I can confirm Elden Ring is clearing the cursor lock for some reason.
I can add an option to periodically re-apply the cursor lock but it will never be perfect as AutoCursorLock fights to keep your cursor within bounds, meaning it would be possible to click something outside of bounds if you click at the perfectly wrong time.

I added an option in v2.2.0 to re-apply the cursor lock on a configurable interval. It's not the best solution because your cursor can still leave the window, but when combined with a configurable margin (already implemented), I think this is the best it's gonna get so I'm closing the issue.
Details in #28.
Side-note, but I noticed while troubleshooting that the sound you get when hovering over menu buttons in Elden Ring still plays when there's a window on top of Elden Ring, so it's clearly doing something weird. Putting this here in case someone else knows more about what Elden Ring is doing in the future.


Local exec provisioner error - activation pipeline - violation resource location

Hi again,
I have already posted one issue connected to local exec provisioner error
https://github.com/GoogleCloudPlatform/marketing-analytics-jumpstart/issues/215
After patches it all went very well (good job guys!) but once again the error occured.

@jakubpietrzyk21 we added this change last week:
https://github.com/GoogleCloudPlatform/marketing-analytics-jumpstart/blob/main/infrastructure/terraform/modules/activation/main.tf#L828 which ensures that the build is kept in the specific region for the build, could you re-try this in your environment and validate whether the change fixes the issue? You may also need to delete the existing cloud build bucket {project_id}_cloudbuild if its created in the wrong region.

Hey,
Thanks for your comment!
For sure I will re-try but first I want have comments to all of my issues -> #228

Issue solved!


Is there an implementation of ByteSizeLong or ByteSize

Please be sure to include:
OSx 10.13.6
Xcode 10.0
Build version 10A255
Apple Swift version 4.2
SwiftProtobuf (1.1.2)
This is a question, no an issue.
Is there any implementation of ByteSize() or ByteSizeLong()  (https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.message_lite#MessageLite.ByteSizeLong) in Swift protobuf.
I would like to get the size of a protobuf object without doing the serialisation of the object.
I could not find anything in the documentation about it: https://github.com/apple/swift-protobuf/blob/master/Documentation/API.md
Thanks

We have
  internal func serializedDataSize() throws -> Int {

but that's internal to the library right now.
Could you explain what you use this size for?  Personally, I've never needed to know the size of a message before I encoded it, so I'd like to better understand your use case.

Yeah sure.
We would like to know the transfer speed in communication with protobuf.
Our protobuf has a timestamp parameter and if we have the size of the protobuf object, the client (the iOS app) will be able to calculate the transfer speed.

It would be much faster to check the size of the data object before you deserialize it and use that.  Computing the serialized size is almost as expensive as doing the serialization (it requires walking the object and inspecting every field and field value).

Well, the thing is I don't deserialize the object. We are using grpc, so the response just gives you a protobuf object in it ( I'm assuming grpc probably deserialize the object somewhere in the communications process, but I can't have access to the raw data, that I'm aware of).
About the fact it takes the same time, I was assuming that because ByteSize() makes an estimation of the size, it would be faster than serialize the protobuf object.

So even if we exposed a method for the binary size, I'm not sure that would really help you calculate the transfer speed the transfer speed in communication with protobuf.  Protobuf just provides binary and JSON encoding methods.  It takes something like gRPC to add on a layer for framing to say what message is requested, etc.  That framing can be thin or think, include sidecars data, etc.; so to now the transfer speed you really would need the data at the gRPC level, not just the at the protobuf layer.

It's very important for streaming with forward compatibility, it's been implemented with reasons.

Closing this out since it seems to have been a question that has been answered.


Formfields custom

If you need custom field, then make field file, for example: /voyager/formfields/custom/subcategories.blade.php and paste Optional Details in BREAD
For example:
{
    "formfields_custom": "subcategories"
}

I won't be able to merge this without merging #1521 first due to how you did your branches.  Closing it for now, please either rebase or cherrypick the appropriate changes onto a new branch created from upstream/master and reopen this (or open a new one if the branch name is different).


hotfix: Fix type hint

Not sure why my local pre commit hooks/even just running mypy doesn't catch this, probably some inconsistency between CI config and local config

thanks xianzhe :)


does this actually work and how do I make it work.

Please help

Hello @Raideridk,
Yes It works sometimes and to make it work If you have some little knowledge about installation.

Install any version of NodeJS.
Git this repository.
Install the packages needed.
Run the code.


error upgrading encfs to 1.9 (missing: FUSE_INCLUDE_DIR FUSE_LIBRARIES)

On OSX 10.11.6
==> cmake .. -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG
Last 15 lines from /Users/mike/Library/Logs/Homebrew/encfs/01.cmake:
-- Check for working CXX compiler: /opt/brew/Library/Homebrew/shims/super/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /opt/brew/Cellar/cmake/3.6.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
Could NOT find FUSE (missing: FUSE_INCLUDE_DIR FUSE_LIBRARIES)
Call Stack (most recent call first):
/opt/brew/Cellar/cmake/3.6.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
cmake/FindFUSE.cmake:29 (find_package_handle_standard_args)
CMakeLists.txt:55 (find_package)

Is the right forum for reporting (install) bugs?

I have had brew cask osxfuse installed all along. Just manually upgraded it (to 3.5.0) but got same error from encfs install.  OS is 10.11.6.  Any help gratefully appreciated!

Update: I just tried to upgrade to encfs 1.9 on a second machine (also running 10.11.6) and got the same error.  Is there some brew-specific thing I need to do to fix this perhaps?

I ran into the same error on macOS Sierra (10.12) and was able to resolve the issue by installing OSX Fuse (https://osxfuse.github.io/).  I installed the stable version 3.5.0.
@maspotts I restarted my terminal app after upgrading OSX Fuse, was that why you couldn't get it to work?

@jonathanou thanks for that!  I started a new terminal but got the same error.  Did you install osxfuse via the brew cask osxfuse?  (I used the cask, followed by a manual update via the preferences pane.)

@maspotts I didn't use cask, I installed the OSX fuse package directly using the installer.  Perhaps you should give it a try, it may be something with cask that's causing the problem.

@jonathanou just tried that, but no luck.  did you also install the optional "macfuse compatibility"?

Yes, I believe so.  After the install I also restarted my terminal since
the error message looked like it was missing either environment variables
or some script variable.  I restarted the terminal to make sure everything
was initialized correctly.
On Mon, Sep 26, 2016 at 1:38 PM, maspotts<EMAIL_ADDRESS>wrote:

@jonathanou https://github.com/jonathanou just tried that, but no luck.
did you also install the optional "macfuse compatibility"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Homebrew/homebrew-fuse/issues/66#issuecomment-249483324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABO2uoasHd0S2uCYLd039e1JNMY_Q70gks5qt1pigaJpZM4J6x6g
.

rats: tried all that, no luck :(  thanks for the help anyway!

I figured this out: to work around my problem I had to patch the encfs.rb formula to add:
ENV.append "CMAKE_INCLUDE_PATH", "/usr/local/include", ":"
ENV.append "CMAKE_LIBRARY_PATH", "/usr/local/lib", ":"

I assume this is necessary because I have my homebrew installed into /opt rather than /usr/local, although I'm not enough of a homebrew/ruby expert to confirm this.  Nevertheless with this patch the install works.  I think this is a no-op if homebrew is installed into /usr/local.  Would it be reasonable for me to submit a pull request for encfs.rb on this basis?

@maspotts The problem is all the Homebrew's libraries are installed under /opt but only the OSXFUSE is installed under /usr/local regardless of Homebrew's prefix.
I would personally like to pass options -DFUSE_INCLUDE_DIR=/usr/local/include -DFUSE_LIBRARIES=/usr/local/lib to cmake, avoiding accidental inclusions of libraries.

This will be fixed by Homebrew/brew#1549.

@umireon Many, many thanks: very elegant and timely!!

Just curious: I see the osxfuse_requirements.rb file was updated (with the references to /usr/local), but I still can't build the encfs formula: do I need to do anything to force those requirements to be picked up?

@maspotts I think that problem should be fixed in upstream.

Thanks!  Any idea when it will show up in a "brew update"?  I see I have the new requirements file already, but I don't understand how/when the encfs.rb formula will become dependent on it...

https://github.com/Homebrew/brew/pull/1549 was merged and part of brew update.


Adding FC-DenseNet (Tiramisu) to models.

I'm using a custom pytorch implementation of DenseNet Tiramisu at work. I'd like to know what are the steps needed to add a pretrained instance of the model to this repo.
I read in #321 and #260 some requirements like that the model should be trained using pytorch and torchvision.
I have no problem with this but I'm not sure about what code should be included along with the pretrained weights:

Do I need to also include the training script (examples/imagenet do not apply here, I think)?
Should I reuse some of the blocks of the existing Densenet implementation (At work I'm using some custom blocks)
Should I train the model using the same hyperparameters and dataset as the original paper?
Related with the previous question, should I add CAMVID to Datasets?

Sounds awesome!
Does your code use the efficient densenet memory model or the naive one?
I'm not on this project, but I can give typical general answers that others can confirm or correct as needed.

Do I need to also include the training script (examples/imagenet do not apply here, I think)?

Yes, since single label problems can't run on image segmentation problems

Should I reuse some of the blocks of the existing Densenet implementation (At work I'm using some custom blocks)

Ideally reuse as much as possible, particularly if a small but clear and easy to understand API change can retain backwards compatibility while enabling the new functionality need for a problem with this model.

Should I train the model using the same hyperparameters and dataset as the original paper?

If you have something that produces better results you can use that, but be sure to evaluate and provide the performance metrics on a standardized evaluation dataset and the code in your PR should enable others to reproduce the model.

Related with the previous question, should I add CAMVID to Datasets?

I don't know their policy, but if you're adding a segmentation model there should be at least one segmentation dataset.

any advance?

We currently only provide pre-trained models for image classification in pytorch (which are trained using examples/imagenet.
It would be great to extend that for other vision tasks as well.
For reproducibility, it would be necessary to have a reference implementation that is open source and used to train the models that we add.
I'm still figuring out if we want to add those mode specific models to torchvision or to dedicated repos.
It depends on where the reference training implementation will live, but we will want to push most of the generic and reusable bits to torchvision.


dgrijalva/jwt-go is no longer maintained

The new repository is https://github.com/golang-jwt/jwt
Can I update the package to the new one?
If yes, please assignee this issue for me and will send the pull request

I was checking the source code and actually the github.com/go-chi/jwtauth don't use this package anymore too.
now they are using https://github.com/lestrrat-go/jwx and not (dgrijalva/jwt-go or golang-jwt/jwt)

hey there, thanks a lot for the pull request! As I was already trying to update all packages including chi, so this should be good now. Tanks again!

 Great job with this boilerplate! 🚀


Add try catch blogs around constructShapeFromMsg

Description
Fixes #1952
The shape constructors called in constructShapeFromMsg throw a runtime_error if it is provided with invalid dimensions (for example here. This PR catches these expectations for better error handling &renames two spartanly named variables.
Checklist

[ ] Required by CI: Code is auto formatted using clang-format
[ ] Extend the tutorials / documentation reference
[ ] Document API changes relevant to the user in the MIGRATION.md notes
[ ] Create tests, which fail without this PR reference
[ ] Include a screenshot if changing a GUI
[ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 64.53901% with 50 lines in your changes missing coverage. Please review.

Project coverage is 50.78%. Comparing base (faa4795) to head (bf3c6e6).
Report is 254 commits behind head on main.

Files with missing lines
Patch %
Lines

...kinematic_constraints/src/kinematic_constraint.cpp
34.05%
31 Missing :warning:

moveit_core/robot_state/src/conversions.cpp
80.25%
16 Missing :warning:

moveit_core/planning_scene/src/planning_scene.cpp
76.93%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
+ Coverage   50.35%   50.78%   +0.44%
==========================================
  Files         390      391       +1
  Lines       31954    32157     +203
==========================================
+ Hits        16087    16328     +241
+ Misses      15867    15829      -38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing this due to lack of time to finish it


Multicast packet forwarding not working for the coap_server sample and Openthread

Describe the bug
Multicast packet forwarding in combination with Openthread is not working. I have a setup of 4 devices.
1 Leader
2 Router
3 Child_L (child of leader)
4 Child_R (child of Router)
If the Leader sends a multicast packet, the Router and Child_L will receive the multicast packet. However Child_R won't. It seems like the packet is not forwarded over the Router towards its child.
To Reproduce
Steps to reproduce the behavior:

build coap_server sample with Openthread support
Send a coap multicast message from the leader, for instance to mcast address: [ff03::1]
Watch all the devices receiving the packet except for Child_R

Expected behavior
I expect all devices to receive the multicast message.
Impact
I am not able to address my whole Openthread mesh network using one single multicast packet.
Environment (please complete the following information):

nrf: v1.7.0-rc2
zephyr: v2.6.99-ncs1-rc2

Everytime a multicast packet is transmitted, the following is printed out at Child_R:
[00:01:32.471,221] <inf> net_openthread: [INFO]-MAC-----: Frame rx failed, error:UnknownNeighbor, len:68, seqnum:219, type:Data, src:0xa000, dst:0xffff, sec:yes, ackreq:no
[00:01:32.496,459] <inf> net_openthread: [INFO]-MAC-----: Frame rx failed, error:UnknownNeighbor, len:68, seqnum:221, type:Data, src:0xa000, dst:0xffff, sec:yes, ackreq:no

Using a packet sniffer it has become clear that the parent does not retransmit the multicast packet towards its children. Could this be an issue with MPL?


[BACKLOG-33979] Configure spring securities to allow password encryption

:white_check_mark: Build finished in 20m 43s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 4836, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 21m 37s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMqttStreamSingleTopic (click to expand)
${result.errorDetails}

Tests run: 4836, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 17m 44s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMqttStreamSingleTopic (click to expand)
${result.errorDetails}

Tests run: 4836, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

We think the test failure is unrelated.


Certain folder names in accounts.conf causes freeze when trying to switch between folders

I'm trying to add multiple folders per the example in accounts.conf. I have:
[personal]
source=imaps://CyanBlob:password@imap.gmail.com:993
folders=Inbox,Sent

If I open the aerc, I see my inbox. If I try to switch to my sent folder with 'J' or ":next-folder", the program freezes and sits at 100% cpu usage, requiring me to force-kill it.
If I change "Inbox" to "INBOX", the freeze does not occur, but I still cannot access my sent folder.
I'm sure it's likely that I'm configuring something incorrectly, but this lock should be prevented.

What folders are displayed when you don't have a filter?

Additional information: your inbox is required to be named INBOX per the IMAP spec. I will eventually add a means of aliasing the names of folders, but for now you've gotta use INBOX. I think your Sent folder has a different name with GMail, and is possibly nested under some other tree. Folder names in the GMail web UI do not match the folder names in IMAP.

With no filter, I have "INBOX" and "[Gmail] ..". The web interface shows the sent folder in the same level hierarchically as my inbox. It actually looks like GMail may be using a "sent" label instead of an actual folder. Would there still be an actual sent folder?

Yes, if I recall correctly it'll be under the [Gmail] folder. Subfolders are not supported yet, but you may be able to manually cd into [Gmail]/Sent


fix s:Function()

ref #1

Your change from ^s: to ^(s:)? is causing the E120: Using <SID> not in a script context: s:JobHandler error. If you can revert that, then I'll merge.

wtf. I rebased and github closed my issue? this never happened to me


Polish Translations

PR includes PL translations to enhance language support.
Translation progress:

[ ] algorithms-bits-seven.article
[ ] algorithms-data.article
[ ] algorithms-fun.article
[ ] algorithms-numbers.article
[ ] algorithms-searches.article
[ ] algorithms-slices.article
[ ] algorithms-sorting.article
[ ] algorithms-strings.article
[ ] arrays.article
[ ] channels.article
[ ] composition-assertions.article
[ ] composition-decoupling.article
[ ] composition-grouping.article
[ ] composition-mocking.article
[ ] composition-pollution.article
[ ] constants.article
[ ] context.article
[ ] data_race.article
[ ] embedding.article
[ ] error-handling.article
[ ] exporting.article
[ ] functions.article
[ ] generics-basics.article
[ ] generics-behavior-constraints.article
[ ] generics-channels.article
[ ] generics-hash-table.article
[ ] generics-multi-type-params.article
[ ] generics-slice-constraints.article
[ ] generics-struct-types.article
[ ] generics-type-constraints.article
[ ] generics-underlying-types.article
[ ] goroutines.article
[ ] interfaces.article
[ ] maps.article
[ ] methods.article
[ ] pointers.article
[ ] slices.article
[ ] struct-types.article
[ ] variables.article
[x] welcome.article

I won't merge anything into main until it is 100% ready. Once you feel it's ready let me know, I'll run the branch locally and then we can make that decision.
I'm letting each team decide if the comments should be translated.

Translations done. It needs to be 👀 after generating index.tmpl files. @Ja7ad could you help with that?


Contact section is aligned properly

Description
Contact section is aligned properly
[Please include a brief description of the changes or features added]

I have corrected the typo
Info section is moved at the left
Forms are aligned at the right

Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes #230

Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]
@Anishkagupta04
I am contributing under GSSoC 24 and Please label and assign me this PR under GSSoC 24

@SuhainaFathimaM Please post scr of changes

@Anishkagupta04

Ig possible can you remove the right side of this name email ....etc coz contact us already have query page and it is repeatedly made if possible try to add a new feature

@SuhainaFathimaM Any updates on this?

@Anishkagupta04 I am working on it..

@Anishkagupta04 Please give me some suggestions to add the thing instead of contact section

@SuhainaFathimaM Didn't get it?

@SuhainaFathimaM Any updates on this?

No activity


[Feature] Disabled widgets need to be styled in the same way.

Summary
The way input widget looks when disabled looks very different from the way a dropdown looks when disabled. Need to have a consistent looks for the disabled widgets.
Additional Context
This issue was reported by a user on Discord.
Pasting the chat:
One more issue/feature request:
- Disabled widgets should be styled the same way; in the screenshot the input background is greyed and the dropdown is not

Also, I think it's enough to just change the background, and to keep the text color in black or very dark grey, to get a bit more contrast

@momcilo-appsmith Note:

We need a design guideline change here to get this consistent everywhere (disabled style on any widget)
We need design for any exceptional case is required.

@areyabhishek should this be focused on right now?

It's not urgent, but we need to address this problem for consistency.

@yatinappsmith can we have some QA efforts towards this. We need to identify any inconsistencies visible across widgets, We can fix everything at once then

@somangshu Currently the colours are inconsistent for different widgets on disabled state. Refer the screenshot for all the widgets.

The cursor design is also different for some widgets. The widgets for which the cursor design are different with input widget are: (Assuming cursor design is correct for input widget)

Label widget
Radio widget
Rating widget
Rich Text Editor

We need more information here @vivekverma2312, As discussed before kindly discuss with the design team to find the set of condition for a disable element given any widget. Once we have that we should formulate a comprehensive list consisting of all required change which will be worked on by the dev. I want to look as this holistically so that we can make better changes and have better consistency in the future

My suggestions:
For buttons:

Use rgb (194,197, 199, 1) as background color
No border
Text in white

For Inputs:

Leave it the same way it is

For checkboxes, radio buttons and toggles:

Use the same settings as for the toggle button

Thanks could you update the design system with this too?

What about the RTE @momcilo-appsmith ? Is the current state alright?

@somangshu The current state is alright.

the issue persists in 3 scenario

Select, Multi-select, and multi-select trees when these 3 widgets are disabled the style is not the same

For the Rich editor widget when the user hovers on the options instead of hand icon the arrow icon is displayed this not same as in other widgets
When the text widget is disabled text color looks different from the input widget

There seems to be a misunderstanding about the text widget
Text widget doesn't have a disabled mode, it has the option to disable processing text as links.
And it's used as illustrated below.

So, this cannot be treated as a disabled state.
@somangshu, please correct me If am wrong.


Omit validation on the ValueFromPipeline parameter in a proxy command

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Not sure whether this qualifies as a bug or is actually by design (or even could be resolved):
When creating a proxy command from a script that has validation on the ValueFromPipeline parameter, I would expect that validation to be remove for the current item as that item is likely be modified in the process block:
function Test-Cmdlet {
    [CmdletBinding()]
    param(
        [Parameter(Mandatory=$true, Position=0, ValueFromPipeline=$true)]
        [ValidatePattern('^\w+$')]
        [string] $String
    )
    begin {}
    Process { $String.ToUpper() }
    end {}
}

function Test-Proxy {
    [CmdletBinding()]
    param(
        [Parameter(Mandatory=$true, Position=0, ValueFromPipeline=$true)]
        [string] $String
    )
    begin {
        if ($PSBoundParameters.TryGetValue('OutBuffer', [ref]$Null)) { $PSBoundParameters['OutBuffer'] = 1 }
        # $PSBoundParameters['String'] = $PSBoundParameters['String'] -Replace '\W'

        $wrappedCmd = $ExecutionContext.InvokeCommand.GetCommand('Test-Cmdlet', [System.Management.Automation.CommandTypes]::Function)
        $scriptCmd = {& $wrappedCmd @PSBoundParameters }

        $steppablePipeline = $scriptCmd.GetSteppablePipeline()
        $steppablePipeline.Begin($PSCmdlet)
    }
    Process {
        $_ = $_ -Replace '\W'
        $steppablePipeline.Process($_)
    }
    end {
        $steppablePipeline.End()
    }
    clean {
        if ($null -ne $steppablePipeline) { $steppablePipeline.Clean() }
    }
}

Test-Proxy 'Test 123'

Expected behavior
TEST123

(No error)
Actual behavior
Test-Cmdlet: C:\Users\boder\GDrive\Scripts\PowerShell\GitHub\Base64-SecureString\bug.ps1:24
Line |
  24 |          $scriptCmd = {& $wrappedCmd @PSBoundParameters }
     |                                      ~~~~~~~~~~~~~~~~~~
     | Cannot validate argument on parameter 'String'. The argument "Test 123" does not match the "^\w+$" pattern. Supply an argument
     | that matches "^\w+$" and try the command again.
OperationStopped: C:\Users\boder\GDrive\Scripts\PowerShell\GitHub\Base64-SecureString\bug.ps1:31
Line |
  31 |          $steppablePipeline.Process($_)
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Object reference not set to an instance of an object.

Workaround
Also modify adjust the ValueFromPipeline value in the begin block (as comment-out in the issue example):
$PSBoundParameters['String'] = $PSBoundParameters['String'] -Replace '\W'

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.5
PSEdition                      Core
GitCommitId                    7.3.5
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I think most of the time validations which were needed in the original function are still needed in the proxy.
It is easier to have the developer remove the validation for the parameter which they fix in the process block, than it is for them to put the validation back if they don't fix it.

@jhoneill,

I think most of the time validations which were needed in the original function are still needed in the proxy.

I think most of the time someone creates a proxy is because he wants to extent the function with extra features which might included features that are restricted by the validation. As in my used case were I was trying to write a prototype for ConvertTo-SecureString that accepts Hexadecimal strings with newlines...
Anyways, I just wanted to reported and I generally agree that this issue low impact.


Adding a dumpload of documentation

Just entered Ernest Hemingway mode, guys :grin:
Documentation split (#1157) should be completed before this can be merged.

Can you insert linebreaks?
That would make in-line commenting easier.
Thanks!

shall do Boss :grin: what's the max line no of characters, 79 like for pep8?

79 should be ok.

ok @bouweandela will do :disappointed:

@mattiarighi @ledm please feel free to edit any changes you may find are needed. I am done with this, and will open new dox PRs for other dox stuffs, so this one's at your discretion now :beer:

I took this over since @valeriupredoi is on holiday.
@hb can you have a look?

cheers for taking care of this, guys - am fully back from holidays and happy to see you've cleaned up my mess :grin :beer:

Any clue why the tests are failing?

Any clue why the tests are failing?

yes, we need r-lintr that is no longer installed correctly - I added it to the env file and let's see if we get the same fail

just to confirm the error:
Your R code does not follow our formatting standards.

Please fix the following issues:

Error in dyn.load(file, DLLpath = DLLpath, ...) :
  unable to load shared object '/home/users/valeriu/anaconda3/envs/esmvaltool2/lib/R/library/stringi/libs/stringi.so':
  libicui18n.so.64: cannot open shared object file: No such file or directory
Calls: lint ... namespaceImport -> loadNamespace -> library.dynam -> dyn.load
Execution halted

has nothing to do with the branch we are on, I have just encountered it on version2_development on RHEL 6.10 but not on Ubuntu 16.04LTS

OK updating conda and the env results in this on a Ubuntu platform as well:
conda update -y conda
conda env update
conda activate esmvaltool
conda install -c conda-forge -yS r-lintr
python setup.py test
...
Your R code does not follow our formatting standards.

Please fix the following issues:

Error in dyn.load(file, DLLpath = DLLpath, ...) :
  unable to load shared object '/home/valeriu/anaconda3/envs/esmvaltool/lib/R/library/stringi/libs/stringi.so':
  libicui18n.so.64: cannot open shared object file: No such file or directory
Calls: lint ... namespaceImport -> loadNamespace -> library.dynam -> dyn.load
Execution halted

I need an OK on this asap because we are needing this documentation sooner than later and people have already done (most of the) changes, plus this is starting to seriously lag behind with other dox contributions being forwarded in the main branch. @ledm @schlunma @bouweandela signature please :beer: (@hb326 is on holidays)

cheers dude @ledm :beer:


Errors and exceptions handling improvement

This PR aims to fix #36 and to generally improve the exceptions potentially raised by the integration using the Home Assistant exception classes
WIP

Currently testing this version on my HA instance.
I have tested by forcing a returned status to 500 at random, and it effectively resends the same request after 0.5s repeatedly, until the return status is 200. If the 5 tries all failed with 500, then it aborts and raise a SwitchbotInternal500Error exception to the Home Assistant core.

And of course, since I started testing this fix, the 500 error status no longer appear for me ...
Making it ready for review anyway, still testing

Going back to draft during testing
Not tested yet, I'll let you know

It is actually working!
When trying to send a turn_off command, i've noticed a unusual slightly longer delay between me pressing the button and the AC signaling a received command.
When checking the logs, here is what I've found :

...
2024-04-08 19:35:00.318 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.remote] Sending command turnOff
2024-04-08 19:35:00.318 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.remote] Command payload {'commandType': 'command', 'command': 'turnOff', 'parameter': 'default'}
2024-04-08 19:35:00.318 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.client] Calling service https://api.switch-bot.com/v1.1/devices/01-202404032246-40583347/commands
2024-04-08 19:35:00.662 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.client] Received http error 500 {"message": "Internal server error"}
2024-04-08 19:35:00.662 WARNING (SyncWorker_27) [custom_components.switchbotremote.client.client] Caught returned status 500 from SwitchBot API server
2024-04-08 19:35:00.662 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.client] tryNumber = 0, waiting 500 ms
2024-04-08 19:35:01.164 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.client] Calling service https://api.switch-bot.com/v1.1/devices/01-202404032246-40583347/commands
2024-04-08 19:35:01.694 DEBUG (SyncWorker_27) [custom_components.switchbotremote.client.client] Call service https://api.switch-bot.com/v1.1/devices/01-202404032246-40583347/commands OK
...

So the fix is actually working properly. Marking it as ready!

Great, merging


Improve GCP authentication process

Currently, we have a service account called datasette-log-viewer that has the BigQuery Data Viewer and BigQuery Job User for catalyst-cooperative-pudl GCP project (project is the lowest level that BQ Job user can be granted).  datasette-log-viewer has one service account key that never expires. Google recommends against using service account keys because they are long-lasting passwords that pose security threats.
There are some safer authentication alternatives I tried but couldn't get working:

Workload Identity federation (WIF)
Impersonate service account using user accounts
Expiring service accounts
User accounts

Workload Identity Federation
(WIF) seems like the most secure authentication offering from Google, however, it is very confusing. They have decent documentation for when you need to authenticate from AWS or Azure but I couldn't find helpful information on how to use WIF for local development. This is the best documentation I could find.
The good news is WIF is integrated with Github actions so hopefully, authenticating using WIF in our CI/CD will be easier.
Impersonate service account using user accounts
Another more secure option is to impersonate service accounts using user account credentials. This allows you to use short-lived tokens from authenticating your user account using OAuth to authenticate as a service account.
I tried this using the google auth python client  but kept running into a very frustrating error. I was able to produce a google.auth.impersonated_credentials.Credentials object that impersonated the datasette-log-viewer service account but when I tried to read data from BQ into pandas I got this error:
RefreshError: ('Unable to acquire impersonated credentials: No access token or invalid expiration in response.', '{\n  "error": {\n    "code": 403,\n    "message": "IAM Service Account Credentials API has not been used in project<PHONE_NUMBER>88 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/iamcredentials.googleapis.com/overview?project=262006177488 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.",\n    "status": "PERMISSION_DENIED",\n    "details": [\n      {\n        "@type": "type.googleapis.com/google.rpc.Help",\n        "links": [\n          {\n            "description": "Google developers console API activation",\n            "url": "https://console.developers.google.com/apis/api/iamcredentials.googleapis.com/overview?project=262006177488"\n          }\n        ]\n      },\n      {\n        "@type": "type.googleapis.com/google.rpc.ErrorInfo",\n        "reason": "SERVICE_DISABLED",\n        "domain": "googleapis.com",\n        "metadata": {\n          "service": "iamcredentials.googleapis.com",\n          "consumer": "projects/262006177488"\n        }\n      }\n    ]\n  }\n}\n')

The trusting part is the IAM Service Account Credentials API has been enabled in the catalyst-cooperative-pudl project and the Catalyst GCP org doesn't have a project with the project number<PHONE_NUMBER>88. This seems like a  bug or I am really misunderstanding something.
Expiring service accounts
If we have to user service account keys we can limit our vulnerability by rotating our keys. By default user account keys never expire but you can upload your own keys with expiration dates. We could create new keys every couple of months. We could also set the project's default service key expiry.
User accounts
I've used user account authentication via the pandas-gbq library in DBCP. It works by sending you to google OAuth page in your browser. Once you authenticate using your password it gives you a token to paste into the terminal.
Unfortunately, I don't dagster likes having this cli input step. When I use user authentication in the usage_metric project I get an error:
dagster.core.errors.DagsterExecutionStepExecutionError: Error occurred while executing op "raw_logs":

  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/execute_plan.py", line 222, in _dagster_event_sequence_for_step
    for step_event in check.generator(step_events):
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/execute_step.py", line 342, in core_dagster_event_sequence_for_step
    for user_event in check.generator(
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/execute_step.py", line 69, in _step_output_error_checked_user_event_sequence
    for user_event in user_event_sequence:
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/compute.py", line 169, in execute_core_compute
    for step_output in _yield_compute_results(step_context, inputs, compute_fn):
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/compute.py", line 137, in _yield_compute_results
    for event in iterate_with_context(
  File "/app/.local/lib/python3.9/site-packages/dagster/utils/__init__.py", line 400, in iterate_with_context
    return
  File "/usr/local/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/utils.py", line 73, in solid_execution_error_boundary
    raise error_cls(

The above exception was caused by the following exception:
EOFError: EOF when reading a line

  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/utils.py", line 47, in solid_execution_error_boundary
    yield
  File "/app/.local/lib/python3.9/site-packages/dagster/utils/__init__.py", line 398, in iterate_with_context
    next_output = next(iterator)
  File "/app/.local/lib/python3.9/site-packages/dagster/core/execution/plan/compute_generator.py", line 65, in _coerce_solid_compute_fn_to_iterator
    result = fn(context, **kwargs) if context_arg_provided else fn(**kwargs)
  File "/app/usage_metrics/assets/datasette.py", line 32, in raw_logs
    credentials = pydata_google_auth.get_user_credentials(SCOPES)
  File "/app/.local/lib/python3.9/site-packages/pydata_google_auth/auth.py", line 266, in get_user_credentials
    credentials = app_flow.run_console()
  File "/app/.local/lib/python3.9/site-packages/google_auth_oauthlib/flow.py", line 437, in run_console
    code = input(authorization_code_message)

Going forward
I think for now we should securely share the service account key. Going forward, we should set a default expiry date for our service keys or have someone walk us through WIF.

#22 now reads google credentials from google.auth.default() which enables people to run the ETL locally by authenticating using their user account. The user account must be added to the pudl-usage-metrics-etl Google IAM group. The service account key is only needed in the Github action now.


Add original logo SVGs

Added original logo files for:

$pac
actn
aeon
arg
bsd
btdx
cmm
colx
ctxs
dash
dht
dock
drop
fjc
gmr
gsc
gxlt
gzr
hight
hodl
ht
iotx
loom
moac
msr
neu
nexo
npxs
ok
ost
pasc
payx
rap
safe
shift
sib
soc
stq
tern
trtl
tusd
vrsc
wicc
xin
xmo
xrp
xsg
zest

Currently in my Top 100 market share these 4 are missing.   Since you've done the others, I was wondering if you could add these as well.
DNotes (NOTE)
https://dnotescoin.com/
Cortex (CTXC)
http://www.cortexlabs.ai/
MyBit(MYB)
https://mybit.io/
Centrality (CENNZ)
https://www.centrality.ai/

@deanlogic Open a separate issue per coin and follow the issue template: https://github.com/atomiclabs/cryptocurrency-icons/issues/new


AST: Downgrade diagnostic for @backDeployed with opaque result type to warning

Reverts https://github.com/apple/swift/pull/67528.
Resolves rdar://113745241

@swift-ci please smoke test


[Bug]: Excluded routes still appear in the no-config sidebars

Version
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i5-10310U CPU @ 1.70GHz
    Memory: 2.99 GB / 15.69 GB
  Browsers:
    Chrome: 121.0.6167.185
    Edge: Chromium (122.0.2365.92)
    Internet Explorer: 11.0.19041.3636
  npmPackages:
    rspress: ^1.0.0 => 1.15.1

Details
I added the following lines to the rspress.config.ts :
route: {
    exclude: ["assets/**/*", "**/4-ignore.*"],
  },

expecting all assets in /docs and the 4-ignore.md not to have routes created for them and not appear in sidebars.
The routes are indeed not created but they still appear in the sidebar:

I don't really know if this is a bug but I would say that no-config sidebars should not display non-existing pages.
Reproduce link
https://codesandbox.io/p/devbox/minimal-route-exclude-in-sidebar-reproduction-gwzr65?file=%2Frspress.config.ts
Reproduce Steps

remove _meta.jsonin docs/guide
add assets in docs/guide/assets/
add some markdown files in /docs/guide including 4-ignore.md
in rspress.config.ts add

route: {
    exclude: ["assets/**/*", "**/4-ignore.*"],
  },

the assets and the Ignore route still appear in the guide sidebar

Yes, you are right. When fallback to readdir, we need add exclude. Welcome PR

Reply to your side note:
config hooks can not determine the order, maybe you need to add sidebar to avoid internal plugin.


Ensure that printing, triggered from scripting, won't accidentally throw in PDFScriptingManager._updateFromSandbox

The issue that this patch fixes is extremely unlikely, but still theoretically possible, and I really should've caught this earlier.
Note how BaseViewer.pagesPromise will only be defined when a document is active, see below, and that if a printing event (triggered from scripting) arrives while the document is been closed there's a small chance that the promise isn't defined.
https://github.com/mozilla/pdf.js/blob/eb92ed12f202de4cc8b0060aac1f1a06b26f83a4/web/base_viewer.js#L426-L428

/botio integrationtest


Update wide-world-importers-oltp-install-configure.md

The sample code to apply row level security incorrectly referenced the [Application].[Configuration_ApplyAuditing] SP instead of the [Application].[Configuration_ApplyRowLevelSecurity] SP.

@ctrembea : Thanks for your contribution! The author, @MashaMSFT, has been notified to review your proposed change.

Hi @ctrembea , thanks so much for your contribution and thanks for catching this typo! You are correct :) #sign-off


Learn to write good commit message and description

It's a follow-up for:

@decentral1se @ssbarnea I've got a collection of articles about writing meaningful commit messages. I'll post it as a separate issue so that anyone could go through this and we could be on the same page...
Sounds fair?

Originally posted by @webknjaz in https://github.com/ansible/molecule/pull/1883#issuecomment-477972258

According to common commit style guides, it is required to write messages in an imperative manner. Make them actionable and atomic. Also avoid using -m as you often need to express more detail in a long way. Here's several articles sharing best practices:

http://chris.beams.io/posts/git-commit/
http://alistapart.com/article/the-art-of-the-commit
https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message
https://github.com/erlang/otp/wiki/writing-good-commit-messages
https://wiki.openstack.org/wiki/GitCommitMessages
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
https://dev.to/gonedark/when-to-make-a-git-commit

N.B. This all applies to issues and PRs as well. If you submit a patch, everything in diff should refer to only one logical change making it atomic. Ideally, applying a single PR should transition a project from one working state to another completely working state, meaning there shouldn't be a change submitted via two PRs and there shouldn't be anything more than needed to fulfill what's in description and title of the PR.
P.S. Don't scare (other) maintainers with huge changes. Reviewing a PR is hard work. The bigger it is the more chance is that somebody will postpone it until better times (trying to find an appropriate slot in their calendars to the review in one pass).
Smaller changes attract more viewers and people, in general, are more likely to understand tiny patches and their impact.

There's also a number of things I encourage people to learn about Git. Maybe you will find something for yourselves.

ProGit 2 :ukraine:
Try Git
Try Git Branching
Interactive diagram/cheatsheet about git
You're using git wrong

Extras:

A useful template for commit messages
Understanding the GitHub Flow
Closing issues using keywords

A serious resource! I wonder should you have a canonical URL on http://webknjaz.me/ :)

@decentral1se what do you mean about canonical URL there? :)
Are you suggesting to put up a web page with those links? I normally post this as GitHub issues/tasks in repos for my mentees...

Read a good advice recently: https://twitter.com/jefflembeck/status/1118892291995734016

While this ticket is still very useful I will be closing it because there is no end to it as it not molecule specific.
Most of this coud be included in a docs page but the next question would be: why to document this in molecule when we could just defer this to ansible itself.


SOLVED? itself...:Javascript error, URI malformed using Topic Note

UPDATE: Topic notes seem to work now. After updating plugin advanced URI.... maybe there is a causal relation?
hi,
i wanted to try out the Topic Note for the first time. Tried under Firefox/Librewolf (122.0 (64-Bit)).
Clippings to the daily note work perfectly though.

Any idea?
This plugin is really great!

mh, it works now. recently advanced URI pligin got an update, maybe there is a causal relation?

I will take a look at this one more. I know I originally had issues when testing on Linux with URL's needing to be encoded twice for some reason. Please let me know if you see this issue again.
There shouldn't be any dependency on the obsidian-advanced-uri plugin.


Fix incorrect image tensor shape

Fixes #126
Hi @kipcole9, can you check if this breaks something in image?

@akash-akya I will check in the next 24 hours. I suspect it will require an update on my side. And this may explain some unexpected behaviour I had to work around.  Will revert ASAP.

@akash-akya, I've updated image to reflect this change. As expected, I needed to modify Image.to_nx/2 and Image.from_nx/1.
I will publish an image update when you publish the update to vix.  Do you plan on setting the vix version to 0.23.0?

Thanks for the update! I'll merge and push new version today

@kipcole9 v0.23.1 is released. Please use v0.23.1 (not v0.23.0) version, which contains a minor compilation fix. 🎉

I've published image version 0.38.3. Thanks for the early warning Akash, much appreciated.


code coverage of branch master is not enabled

The code coverage of branch master is not updated since 5 months ago, should we enable it?

Enabled


Finding_Runner-up_score_#56.java, Bill_division_#70.java

Finding the Runner-up score in java. #56

@kirthi0 LGTM , Thank you for the contribution. Still 2 more PRs to complete you hacktoberfest.


Ignore false gosec violation

The SQL query is dynamically generated using prepared statements for user provided values.

/cc @dhaiducek


Base-255 compression trims leading as

When compressing a string using øc, or base-255 compression, any leading as in the string are removed from the resulting string.
Example: Try it Online!

This... should not be happening. The base-255 compression  alphabet should be changed to start with  .


wip: Do Not Merge. Possible alternative dependency checking method.

WIP Prototype of an alternate implementation of dependency checking.

Relies on the OpenStack Client / SQLAlchemy (which is included with every OpenStack project as a dependency), so no extra image or binaries are required.
Does not interact with the API, so pods can be isolated from it, reducing the potential attack surface upon K8s.
Failing rather than waiting, so operators gain visibility of pods/services that require attention.
Checking service operation directly, rather than relying on status checks, so we get confirmation that not only are the required services reporting as available but that they are also actually serving requests, and accessible by the pod that needs to consume it.
Removing the coupling from K8s services and job history allows OpenStack Helm to be simply deployed in many more configurations than previously possible, including federated clusters, brownfield sites and/or in combination with external services, whilst retaining dependency checking.

Currently, this is very much a WIP, and only supports DB and Keystone-related functions, but the pattern can easily be expanded to cover sockets and other services as required.
The commit that is relevant in this PR is https://github.com/att-comdev/openstack-helm/commit/c49edfbd2c4613f0325805721c3c781b77ac1976 (particularly from here onwards), which uses Cinder as an example.
Sample output from this prototype is here:

https://gist.github.com/intlabs/06541d4aed6d346d8ed7200791f87375#file-cinder-openstack-output
https://gist.github.com/intlabs/06541d4aed6d346d8ed7200791f87375#file-cinder-openstack-helm-entrypoint-L912-L1028

This Prototype/Proposal is potentialy relevant to the discussions in https://github.com/att-comdev/openstack-helm/issues/88 and https://github.com/att-comdev/openstack-helm/issues/32.

This change is

One thought that occurred to me - this would also need to account for validating the schema is in place as well.  Even better if it validates the correct schema is in place but likely that would have to be future.
In other words, this would OK if the databas existed but dbsync was still in flight.  This can take 5+ minutes on a nova/neutron install as it runs through the history of patches.  The fear would be we would allow things to continue, to connect, only to find them crash as they tried to access tables that don't exist.

@alanmeadows: Though we have discussed this offline I'll add some comments here for posterity:
I made a start at the db schema checking using cinder as a guinea pig:

values.yaml
init-container-snippet
usege in a pod template

To complete this, we will need to get the schema version for each OpenStack release and then compare the value returned from the db version command.
Over the next few days I'll get this a bit more PR worthy, most likely by starting a new PR that breaks the concepts introduced here into more manageable chunks.

I continue to support this change.  One comment:
The stab above would suggest as long as db version exits successfully, we would be good to go.  This is an improvement over a simple auth check to the database.  But it does differ from our discussion of comparing it to a specific target version.  Perhaps that is a next evolution I am simply overlooking?
It's a good stop gap but the one challenge with this as is (versus what we discussed, checking for a specific version pinned to the target release) would be during upgrades.  This would likely return success while a second (post-install, during upgrade) db_sync is in progress on an existing schema taking it to the target version.  The old "legacy" approach would of protected against this because an upgrade would of required the end user delete the db sync job before upgrading and changing the container image for that job (its own problem, I'll admit), thus ensuring entrypoint checks on the job completing would hang until it finishes.  If we want to replace that I think we need to make sure we don't move backward in capabilities.

this work got left on an island too, and i don't want to lose any of the effort (especially the great conversation). perhaps we can approach this work in phases or create issues for the parts of this work we don't want to lose if this PR were to drop. thoughts @intlabs?

@v1k0d3n This PR is very hard to break up in its current form. But I'm very keen on continuing this work as it will be vital for cross-cluster operation and interaction with externally managed infrastructure services. Once the DB work in https://github.com/att-comdev/openstack-helm/pull/206 is merged I'll be able to make meaningful progress on this topic again.

ok sounds good. @intlabs we'll work on this tomorrow ;)

Thanks for this work @intlabs.  We'll file a blueprint once we're in OpenStack to track this work going forward.  Until then, we'll leave this PR open for you to reference after that point.

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm


Web - User email is shown for chats created  offline but not for chats created online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a New chat with a New User
Go to the profile by clicking on the header and notice Email is not displayed
Force Offline
Create a New chat with a New User
Go to the profile by clicking on the header and notice Email is displayed.

Expected Result:
Consistency between online and offline
Actual Result:
Inconsistency between online and offline
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.37-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/705059fc-cf18-43b2-81e3-d3e88ac24419
https://github.com/Expensify/App/assets/93399543/7c394454-bfb8-48e2-82af-08ca2e993b10
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688671203208689
View all open jobs on GitHub

Will review today!

Reviewing today, got caught up before, sorry!

Unable to repro, seeing email in online and offline. @daveSeife can you confirm if still occurring on current build?

@dylanexpensify i still can reproduce it too

ahhh I can repro on production, but not staging, which leads me to think it'll be fixed with next deploy!

I'll reopen if not!

Hi, @dylanexpensify I was able to repro this after the last two deployments can you please check if this issue should be reopened?
https://github.com/Expensify/App/assets/49120316/ad35d211-3cb9-421a-8593-f3abf15b3a3b

Friendly bumb @dylanexpensify


Getting total size of a directory

I think this would be a nice addition, as for example rclone size google-drive: may cause API bans and plexdrive already caches anyway.

What do you mean to execute? I can run something like this:
felix@plex:/media/TV$ time du -ms *
25561	11.22.63
26245	12 Monkeys
29893	13 Reasons Why
18747	24- Legacy
54629	2 Broke Girls
72411	Alaskan Bush People
16924	Alaska State Troopers
48428	American Crime
13369	American Crime Story
9799	American Gladiators
118389	American Horror Story
107902	American Idol
48508	World War II in HD Colour
35040	You're the Worst
2086	Zapped!

real	0m13.643s
user	0m0.028s
sys	0m0.140s

This feature is not planned, plexdrive is made for streaming. It's not a copy of rclone.


Add siddhi-runner image changing section to the k8s deployment

Purpose

The kubernetes deployment section of the siddhi documentation did not contain the details about how to change the default siddhi-runner image in the siddhi-operator level.

Goals

Add details about the changing siddhi-runner docker image.

Approach

We can change docker image in two levels (operator-level and CRD level). Thus add note sections to operator deployment subsection and siddhi app deployment subsection.

Codecov Report

Merging #1332 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1332      +/-   ##
============================================
+ Coverage     62.68%   62.68%   +<.01%
  Complexity       37       37
============================================
  Files           624      624
  Lines         25686    25686
  Branches       4046     4046
============================================
+ Hits          16100    16101       +1
  Misses         8276     8276
+ Partials       1310     1309       -1

Impacted Files
Coverage Δ
Complexity Δ

...java/io/siddhi/core/stream/input/InputHandler.java
80.64% <0%> (+3.22%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c3a26...58a33ca. Read the comment docs.