[$1000] Workspace - The default currency and name doesn't sync for Workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in with the same account in both Devices ( main - Desktop, secondary - IOS app)
In the main testing device, Navigate to WS > General Settings
Change the default currency, name or picture
Observe secondary device and check if the changes have updated without tapping save or refreshing

Expected Result:
The data the user updated also updates on the secondary devices logged in to the same account (without refresh)
Actual Result:
The data is not updated on the secondary devices logged in to the same account without refresh.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/221033335-0d26a966-1f7a-4702-8650-85fc34ae846c.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c0937e9862011f7f
Upwork Job ID:<PHONE_NUMBER>869180416
Last Price Increase: 2023-02-24

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01c0937e9862011f7f

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The data in secondary device is not updated if user changes it in other device
What is the root cause of that problem?
When user saves data in the form of first device, it's updated on the defaultValue in the form of second device but
In https://github.com/Expensify/App/blob/2b352b182a61751b6ae3715d6a8d6852ec50cbd1/src/components/Form.js#L240-L246
We just update the value is defaultValue if this.state.inputValues[inputID] is undefined. At this time, in the form of first device, the input has already value that why it's not updated
What changes do you think we should make in order to solve the problem?
we should store the defaultValue and then In https://github.com/Expensify/App/blob/2b352b182a61751b6ae3715d6a8d6852ec50cbd1/src/components/Form.js#L240-L246
we have the new logic the check if the defaultValue from onyx gets changed we'll update it in defaultValue of Form as below
if (this.defaultValues[inputID] !== defaultValue) {                 this.state.inputValues[inputID] = defaultValue;                 this.defaultValues[inputID] = defaultValue;  }
Result

@neil-marcellini Is this correct?

Observe secondary device and check if the changes have updated without tapping save or refreshing
Expected Result:
The data the user updated also updates on the secondary devices logged in to the same account (without refresh)
Actual Result:
The data is not updated on the secondary devices logged in to the same account without refresh.

@neil-marcellini Is this the correct expected behavior?

Yes. You can see in the video that it works for the workspace avatar but not for the name or currency. At a quick glance @tienifr's proposal looks pretty good. Please let me know what you think.

@neil-marcellini  What do you think above this proposal - https://github.com/Expensify/App/issues/15437#issuecomment-1443900899
Form.js already support 'value' props to use for this kind of issue.

@neil-marcellini
For workspace Avatar we have a different flow. Save is triggered in Edit photo page and sync starts.

But for name & currency save is triggered only after pressing Save button. After saving changes we can expect sync but not before.
If it's based on auto sync for all changes I'm not sure why there is a Save button.

@Santhosh-Sellavel
I think the issue here is,
"After we press save in one device, its not reflected in another device if it was already on workspace setting page and only going back and forth updates the UI in another device for name and currency"
Correct me if wrong.

@Santhosh-Sellavel Yes I agree with @abdulrahuman5196. The reproduction steps should be updated to include clicking Save before expecting the other device to be updated, as shown in the video.

@neil-marcellini
Steps reproduce in issue description confused me

Observe secondary device and check if the changes have updated without tapping save or refreshing

Alright I'll check proposals again shortly, thanks!

@Santhosh-Sellavel @neil-marcellini what would you suggest the repro steps be updated to? Would like to get these updated :)

@neil-marcellini I still think this is something unnecessary, can you reconfirm if is this expected to replace the values in the form that's being edited in another session?

The data is not updated on the secondary devices logged in to the same account without refresh.

This is wrong, values get updated in all other (read-only) places.

So first of all, this is a pretty rare flow and therefore it's a relatively low value issue. If I'm going to update some settings on my workspace I probably won't open the page on both devices at once. That being said, it could happen and I don't see why we can't make it work well.
Maybe it would be weird if I entered "New Name A" on device A, did not save, then entered "New Name B" on device B, then hit save. Even then it would make sense for device A to update the value in the form to "New Name B", because I just took that action.
I'm thinking out loud here. You might have a good point because in the future when we have multiple admins on a workspace, another user could update the name while you are in the process of editing, and you probably wouldn't want that update to overwrite your changes.
As long as the settings update on the second device if you leave the page and come back, then I'm fine with the current behavior and I think we can close the issue. I just checked that and that is the case. Also, you can see that the current name was updated in the header, which lets you know that it has been changed while you were editing. I'm going to close this. Thanks so much @Santhosh-Sellavel for making sure that the expected behavior makes sense!


watchPosition is not working for me on Either Android and iOS

I want to get user's location after every second in app so that I can use latest coordinates to change my Map marker and somethings more, but this is not working for me, I have done everything as doc said and also have all the permission given on my mobile app but nothing is working for me.
I have made a separate hook for watching position here is the code:
`const useWatchLocation = () => {
const dispatch = useDispatch();
const [subscriptionId, setSubscriptionId] = useState<number | null>(null);
const watchPosition = () => {
    try {
        const watchID = Geolocation.watchPosition(
            (position) => {
                let location: CURRENT_LOCATION = formatLocation(position.coords.latitude, position.coords.longitude);
                console.log('location', location);
                dispatch(setUserLocation(location));
            },
            (error) => { _showConsoleError(`Error while watching location: ${error}`) },
            {
                enableHighAccuracy: true,
                fastestInterval: 1000,
            }
        );
        setSubscriptionId(watchID);
    } catch (error) {
        _showConsoleError(`Error while watching location: ${error}`);
    }
};

const clearWatch = () => {
    subscriptionId !== null && Geolocation.clearWatch(subscriptionId);
    setSubscriptionId(null);
};

useEffect(() => {
    return () => {
        clearWatch();
    };
}, []);

return {
    watchPosition,
    clearWatch,
}

}
export default useWatchLocation`
You can see that I'm updating redux state upon on new location. I have used this location state as dependency in another screen, here is the code:
useEffect(() => {         if (location && mapRef && mapRef.current) {             let camera: Camera = {                 center: { latitude: location.latitude, longitude: location.longitude },                 zoom: 18,                 altitude: undefined,                 heading: 0,                 pitch: 0,             };             mapRef.current.animateCamera(camera);         }     }, [location])
I'm also showing coordinates using Text so that I can see that on moving location is also updating in mobile application but nothing is working, can anyone please help me out in this?

Can you provide me with repro example?

Watch Position is not working for me as well

Geolocation.watchPosition(
position => {
console.log('watchPosition', position);
dispatch(UserLocation(position))
},
error => {
console.log(error.message);
},
{
enableHighAccuracy: false,
timeout: 10000,
distanceFilter: 1,
maximumAge: 1000,
},
);

Could you give me a bit more context on how you use this code? Maybe a small repro project?

I'm also facing this issue

You can use "react-native-geolocation-service"

I'm using this one as well, but not able to get updated location

I have followed the exact example code, given all permissions on both Android and iOS but nothing is working

Can you please update the example with the latest RN version? Example's patch is not working on the 0.71.2 version.
And pod install was failed on the current example app.
I tried to use the example app, as watchPosition didn't work on my app. It shows following error.
Sending geolocationDidChange with no listeners registered.

@hristo0624 I recommend you to install expo-location-package using expo-modules-package in bare project. Its really good package handles everything very nicely.


Use stable angle method (atan2) to avoid precision problems in dihedr…

Very quick/minor fix for a case I had when measuring dihedrals at very close to 180 degrees. Floating point rounding errors meant we were trying to calculate Math.acos(-1.000001) or similar which produces NaN, this instead uses the v3angle method (Math.atan2 underneath) which doesn't suffer these kind of precision/domain issues.

Going to just merge this, please shout in the unlikely event it causes problems


IFTTTLaunchImage

IFTTTLaunchImage - Put your asset catalog launch images to work for you.

@lfarah I'll close this one, as the last commit is from 15 Sep 2015. Reopen if you don't agree. :)


[Improvement] Create RollViewLogRequestCommandTest.java

Purpose of the pull request
Add a test case about RollViewLogRequestCommand

It seems that  forgot to add this test file in the parent pom

It seems that forgot to add this test file in the parent pom

Thanks for the review，I have added the test file to the pom file, please check it

Codecov Report

Merging #5417 (47c71c5) into dev (d93a9dc) will increase coverage by 3.39%.
The diff coverage is 44.56%.

@@             Coverage Diff              @@
##                dev    #5417      +/-   ##
============================================
+ Coverage     45.21%   48.61%   +3.39%
- Complexity     3395     3883     +488
============================================
  Files           538      598      +60
  Lines         23053    24298    +1245
  Branches       2687     2781      +94
============================================
+ Hits          10423    11812    +1389
+ Misses        11698    11404     -294
- Partials        932     1082     +150

Impacted Files
Coverage Δ
Complexity Δ

...eduler/plugin/alert/script/ScriptAlertChannel.java
16.66% <0.00%> (ø)
1.00 <0.00> (ø)

...org/apache/dolphinscheduler/alert/AlertServer.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...che/dolphinscheduler/api/ApiApplicationServer.java
33.33% <0.00%> (ø)
1.00 <0.00> (ø)

...scheduler/api/controller/DataSourceController.java
4.16% <0.00%> (-0.49%)
1.00 <0.00> (-1.00)

...uler/api/controller/ProcessInstanceController.java
4.54% <0.00%> (+0.90%)
2.00 <0.00> (ø)

...nscheduler/api/controller/SchedulerController.java
4.76% <ø> (-0.96%)
1.00 <0.00> (-1.00)

...heduler/api/controller/TaskInstanceController.java
55.55% <ø> (-26.80%)
2.00 <0.00> (-1.00)

...cheduler/api/controller/WorkerGroupController.java
6.66% <0.00%> (-11.52%)
1.00 <0.00> (-1.00)

...duler/api/interceptor/LoginHandlerInterceptor.java
80.95% <ø> (ø)
6.00 <0.00> (ø)

...scheduler/api/service/impl/MonitorServiceImpl.java
13.63% <0.00%> (ø)
2.00 <0.00> (ø)

... and 298 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c6237...47c71c5. Read the comment docs.


Chp_02.ipynb, import statement

Greatly appreciated effort here, thank you.
cloned your latest repository, created an environment as per instructions. Noted in the environment.yml we have entires for pymc3 and pymc-theano, but not for pymc.
The first cell of chp2 is:
import arviz as az
import matplotlib.pyplot as plt
import numpy as np
import pymc as pm
import scipy.stats as stats
Output
ModuleNotFoundError                       Traceback (most recent call last)
Input In [9], in <cell line: 4>()
2 import matplotlib.pyplot as plt
3 import numpy as np
----> 4 import pymc as pm
5 import scipy.stats as stats
ModuleNotFoundError: No module named 'pymc'

I have found this issue as well. I have gotten around it by pip installing pymc after I activate the stat-rethink2-pymc environment. I am sure this is not the preferred way to do this, but I have had success running the code using the new version of pymc. That may be suitable a suitable solution until the environment file is updated.

Thx @yahrMason, after running pip install pymc it also worked for me.


Does not work for IE

http://stackoverflow.com/questions/27492807/image-download-from-canvas-doesnt-work-in-ie-11

Sorry, but I don't really have time to make this work on IE, especially since I don't need IE to work in my use case. I would definitely accept a pull request though if you know how to fix it. :)

I mean, duh... Nothing works in IE lol


Revamp iOS samples to use XcodeGen

This revamps the iOS samples to use an Xcode project generation tool called XcodeGen which makes it much easier to update and add Xcode projects. Changes to Xcode projects are now more obvious and don't get lost among the noise. I still plan on commiting the full Xcode project so users don't have the burden of installing / running XcodeGen.
Each iOS sample now has a project.yml which defines the project-specific settings. It includes app-template.yml which defines a template for Filament iOS projects.

@prideout Technically no, but for now at least I want to commit them so users don't have to install XcodeGen.


Fix issue #2090.

Create new helper module for http.
Update set_user_agent to only monkey patch http.request the first
time.

Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.

[x] I signed Google's Contributor License Agreement
[x] My code conforms to Google's python style.
[x] My PR at a minimum doesn't decrease unit-test coverage (if applicable).
[x] My PR has been functionally tested.
[x] All of the unit-tests still pass.
[x] Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

Fixes #2090

I have verified this fix is working.  Deployed to a test VM instance on for it, and it has been running for over 5 days, with a cron job that repeats every minute.


[Feature] Add Narcissistic Number Calculator

Description
The calculator tells that whether the entered number is a narcissistic number or not
Eg : 371 = 3³ +7³ +1³
@Rakesh9100 I would like to work on this under GSSoC
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 I would like to work on this

Proceed @SuhainaFathimaM

Pls provide your PR @SuhainaFathimaM

@Rakesh9100 I will do that after making that readme document pr as soon as possible

@Rakesh9100 #1457 After merging this PR i will complete this one


Desktop shortcut for Linux

Hello
Great work with scrcpy, this really impressive software.
To make my life easier, I have written a desktop icon for Linux that allows a user to a) run scrcpy, 2) run scrcpy with touches showing, and 3) record footage from scrcpy - all without using the terminal.
Would there be any opposition to me submitting a pull request to edit the readme.md file to include a link to my shortcut for those that may find it useful?  (Edit would make clear that this is external to the amazing work you are doing).
(Never submitted a pull request before, so thought I get in touch beforehand!)

Those three things seems much more than just a desktop icon. If you added features to a scrcpy fork, please send a pull request of the code. That's much better than changing Readme to external resources.

The desktop icon part looks like the same feature request as #295. I guess recording a footage can be achieved with the new v4l2 feature in 1.18.

I guess recording a footage can be achieved with the new v4l2 feature in 1.18.

To record a file, it's better to use scrcpy --record file.mp4 though: the timestamps are from the device, and no frame may be skipped.

Awesome! Those additional actions can be added to the desktop file as Desktop Action XXX groups.


 in e-mail subject while following examples in docs

Hi guys,
Let me start out by saying this was exactly the missing puzzle piece in the whole ELK stack. Good implementation as well, with enough flexibility. I'm fiddling around with the e-mail now and want to change the alert_subject but keep getting . I think I'm following the docs to the letter so I was wondering if you could lend a hand?
My rule config looks like this (partial)
 # (Required)
# Rule name, must be unique
name: "symfony-errors"

# (Required)
# Description used in alerts
description: "Symfony application errors, level Error or higher"
...
# Tweak the e-mail subject
alert_subject: "Alert {0} ({1}) at {2}"
alert_subject_args:
  - issue.name
  - issue.description
  - "@timestamp"

Because I'm provisioning with Ansible, I also have the possibility to just fill the args by using quoted strings as args (see below) but with the same result. Looking at the code, this isn't a possibility, is it?
# Tweak the e-mail subject
alert_subject: "Alert {0} ({1}) om {2}"
alert_subject_args:
  - "symfony-errors"
  - "Symfony application errors, level Error or higher"
  - "@timestamp"

the first case I described is (I think) in the docs: http://elastalert.readthedocs.org/en/latest/ruletypes.html#alerts
What am I doing wrong here?

Never mind, was probably just using it wrong. Turns out it's about the values of the hits that you can access, not of the rule.


Volume shrink error

Current Behavior
Volume shrink action causes an error. Volume shrinks fine.

{"level":"info","ts":1692104125.842518,"logger":"volumes.shrinkVolume","caller":"storage/storage.go:354","msg":"migrated sectors","volumeID":2,"oldMaxSectors":7209,"newMaxSectors":6914,"count":239}
{"level":"error","ts":1692104126.0282094,"logger":"volumes.resize","caller":"storage/storage.go:785","msg":"failed to resize volume","volumeID":2,"error":"failed to expand volume metadata: transaction failed: cannot shrink volume to 6889 sectors, 25 sectors are in use: volume is not empty","stacktrace":"go.sia.tech/hostd/host/storage.(*VolumeManager).ResizeVolume.func1\n\tgo.sia.tech/hostd/host/storage/storage.go:785"}

Expected Behavior
.
Steps to Reproduce

Go to Volumes
Edit volume size to smaller one
Wait few seconds and check alters

Version
v0.1.4
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?
Windows 11
Anything else?
No response

Fixed by #151


add resampling audio input transformation defense in torch

Discarding samples from a waveform during downsampling could remove a significant portion of the adversarial perturbation, thereby prevents an adversarial attack.

Hi
Thanks for the pull request!
Could you comment a little on this pull request purpose?
As far as I know such downsampling followed by an upsampling either introduces aliasing or deletes information from the signal in which case the upsampling is not really needed. Maybe I am missing something?
@dhalf An opinion on this topic?

Thanks for the response.
I guess I'm still a bit puzzled by this defence from a signal perspective. To put it bluntly, what is the point of upsampling back since you already lost the extra signal quality of wideband by downsampling to narrowband? Why would you not directly sample the signal at 8kHz as the defender?

I agree with your doubt and will be thankful if someone helps us out with the reason. I have followed what was mentioned in the paper https://core.ac.uk/download/pdf/228298313.pdf for re-sampling defense and implemented the same.

Thanks!
I was not aware of this specific work but have seen resampling in other papers. Afaik these other works did not justify resampling against the points I made above either.
I'll check with other maintainers, get consensus and come back to you?

I checked with the other maintainers.
We'll accept the pull request but it would be nice to have a comment outlining the potential signal limitations of the defense.
Can you format the code to black and add a comment to that effect?
Thanks a lot for the contribution

I have formatted the code to black using this link. Please check if it is the appropriate way to write the code in this format. I have added the comment to elaborate why using this defence.  Sorry I couldn't get what comment you are expecting to add. Can you please elaborate it further?

Thanks!
Can you add in the warnings that the defence is disputed from a signal point of view?

I ment the fact that this defence may yield aliasing and that it is not obvious why you would downsample then upsample rather than just use the narrowband sample rate.

Thanks for the added limitation.
These issues are linked to the Shannon sampling theorem and the fact that lost information cannot be recreated.


Allow zero coin in TxOuts in Conway

Description
As it turns out there are some TxOuts from Byron era that contain zero Coin.
For that reason we will allow zero coin, but not zero multi asset
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

Closed in favor of a better approach implemented in #3530


Can't import both material-icons and material-icons-outlined

Is your feature request related to a problem? Please describe.
I can't use both the outlined and normal material icons in my project.
Describe the solution you'd like
I'd like to be able to reference the outlined font family as 'Material Icons Outlined' like the google fonts version.
Additional context
This package is awesome! Thank you for your work here.

Thoughts on two separated packages for this? That way, it won't require much custom work to implement (since the current code only accommodates one font name per package).
Although, I suppose we can implement the custom logic when working on #152.
I think the latter might be better for organisation, but the former is still an option.

I'm totally fine with another package. That makes it a non breaking change too.


Add compression to elasticsearch output

Hello. I need a client-side compression for elasticsearch output, so I implemented this.
I did make test, make fmt, make lint.
I am using this commit in my service, and it seems it works well.

Thanks @cookieshake, looks good!

@mihaitodor thank you for checking my code!
@Jeffail I changed compression to gzip_compression. The integration test failed because the dockerd of my pc was not working properly. I did the test on another ubuntu VM, and the test for output/writer was successful. But other tests like mssql test failed.


Rename SIG ContribStrat --> TAG ContribStrat

I've been known to do a little search/replacing in my day, so I'll take this up now that the vote has passed.
Things to think about:

simple search/replace
potential link-breaking:

[x] repo name (shouldn't break in the case of a single rename): https://github.com/cncf/sig-contributor-strategy/pull/100
Zoom meetings
Calendar things?
mailing list
website references

cc: @parispittman @jberkus @amye
(FYI and for anything I'm missing off the top of my head)

I've been known to do a little search/replacing in my day, so I'll take this up now that the vote has passed.

Zoom meetings
Calendar things?
mailing list

These are things that staff can take care of, the only one I have questions on is the website references in netlify.

@carolynvs so what parts of the website did this just break?  Do you need help fixing it?

Has everything been transitioned now?

I think so, can we close this?

I think we are done, so say we all!


Highlight Active Drawer Menu According to the Route

Major feature add:
Highlight the active tab according to the route, now the selected menu item is clearly indicated for the user

Other changes:
reordered the import lists according to categories for AppFrame file, added some comments for the codebase, and removed home.js from components folder

@FeynmanDNA One test is failing on Travis-ci. Please try to duplicate the issue by running npm test locally.

The test failed because I previously removed the old Home.js:

However, the test file and snapshot file related to the old version of Home.js were still there. I have since removed those two files as well.

Duplicate of #281


运行python startup.py "Write a cli snake game based on pygame"报错

Traceback (most recent call last):
File "D:\GitProject\metagpt\startup.py", line 7, in
from metagpt.roles import Architect, Engineer, ProductManager, ProjectManager, QaEngineer
File "D:\GitProject\metagpt\metagpt\roles_init_.py", line 9, in
from metagpt.roles.role import Role
File "D:\GitProject\metagpt\metagpt\roles\role.py", line 12, in
from pydantic import BaseModel, Field
File "pydantic_init_.py", line 2, in init pydantic.init
File "pydantic\dataclasses.py", line 48, in init pydantic.dataclasses
# +=========+=========================================+
File "pydantic\main.py", line 120, in init pydantic.main
TypeError: dataclass_transform() got an unexpected keyword argument 'field_specifiers'

pydantic的版本太高了，其他包的版本跟不上，安装指定的包就可以解决
pip install pydantic==1.10


AzureOpenAI embedder should have a separate file...

🐛 Describe the bug
Offshoot of #1347, AzureOpenAI should have a separate file under embedders.
Change the strategy dictionary as well.

I can work on this.

@vatsalrathod16 Please feel free to work on this.


Ability to save comments

Currently there is a 'save' button on posts in the post view. This adds a post to the 'saved posts' page they can access from their user page.
Users want to be able to save comments also. So, add a 'save' button to the list of options on comments, and add a 'saved comments' page they can access from their user page.

Addessed in my repo here:
https://github.com/globalistas/ceknito/commit/d2b2e40f14b81f5f5224bcf2177f0b7a1dd74afc


benchmarks

benchmarks:
Array (Maybe a) vs MaybeArray a
SmallArray (Maybe a) vs SmallMaybeArray a

This is an excellent idea.

thanks i am very innovative


Add support for workers to send custom messages to parent in jest-worker

Summary
This PR part of an effort to break down PR #9001, so that we can eventually have #6616
It adds jest-worker the ability for workers to send "custom messages" to their parent while they are still running. This will eventually allow us to report per test case updates to the reporter.
Test plan
This should not break the API, and I added multiple tests for it. I should also add an e2e test for it, but that is still pending.
I intentionally kept it undocumented given that I'm still not 100% sure that this is the right interface. Currently it uses a PromiseWithCustomMessage interface, that allows to call p.onCustomMessage(listener) to a thenable.
export interface PromiseWithCustomMessage<T> extends Promise<T> {
  onCustomMessage?: (listener: OnCustomMessage) => () => void;
}

I would love feedback on that interface or potential new ideas for it.

🙀 I missed this PR @rogeliog, sorry!

I can't give large PRs like this a proper review atm, only just managed to get back below ~30 Jest notifications after months. But if there are parts around how workers exit, which I've dealt with somewhat recently, happy to take a look at specifics.


Handle text with internal nuls

Fix insertion and selection (#657).

Re: #658, no objections here to using this instead, though I guess this approach means sqlite needs to allocate an extra byte to store the unused trailing \0.
It looks like Error::NulError is not used anywhere else. As there's been a breaking change in function definitions in master, perhaps it's worth removing the enum case as well?

If you try to remove this block, you can see that NulError is actually used.

Sorry, that's embarrassing - I just quickly grepped through the sources without reading them carefully.


Improve Shader Compiler

[ ] Add support for #include<....>
[ ] Add support for runtime compilation

@JeanPhilippeKernel  please enhance the description

I updated the description


[BUG] Harvester management VIP address not working after rebooting nodes

Describe the bug
After setting up a multi-node Harvester cluster, I rebooted the nodes. The management VIP address does not come up unless I start the node that held the management address before the reboot. While the VIP is back now that the existing nodes are running, I can't join additional nodes, error message is:
Get "https://[management VIP address]:8443/ping": dial tcp [VIP]:8443: connect: connection refused
Port 443 is available, though, and the UI is accessible using the management VIP address.
To Reproduce
Steps to reproduce the behavior:

Create a new cluster and join some nodes. All is well.
Shut down the cluster, then start up all nodes except the one that held the VIP. The running nodes don't bring up the management VIP address.
Start up the node which held the VIP. Now the management VIP address is up and the UI is accessible.
Try to join another node. When entering the management address, the VIP isn't accepted since the ping-URL gets connection refused despite the management VIP address being up.

Expected behavior
When the VIP-holding node is unavailable after rebooting the cluster, another node should take over the VIP.
When the VIP is accessible after rebooting the cluster, it should be possible to add another node using the VIP as management address.
Support bundle
supportbundle_43cce680-695a-4e67-8622-766b7dee6f2f_2021-11-03T13-42-29Z.zip
Environment:

Harvester ISO version: harvester-v0.3.0-amd64.iso
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Baremetal with Dell Optiplex 3060/7040/7050

Additional context

Tried it twice, completely reinstalling the nodes. So far the Harvester cluster doesn't seem to be fully functional after a reboot.
Nodes were configured with DHCP, using static address assignment by MAC address. VIP was configured with Static IP address.

By now I managed to add more nodes by doing the following:

Bring up all existing nodes. (VIP is working, but adding nodes isn't because of ping-URL not working.)
 (Another node takes over, there the ping-URL is working.)
Add new node. (Works now that ping-URL is available.)

The VIP works normally according to the kube-vip log from the support bundle. We will try to reproduce this case.
2021-11-03T12:57:17.170718938Z time="2021-11-03T12:57:17Z" level=info msg="server started"
2021-11-03T12:57:17.170857219Z time="2021-11-03T12:57:17Z" level=info msg="Starting Kube-vip Manager with the ARP engine"
2021-11-03T12:57:17.170871631Z time="2021-11-03T12:57:17Z" level=info msg="Namespace [harvester-system], Hybrid mode [false]"
2021-11-03T12:57:17.170912250Z time="2021-11-03T12:57:17Z" level=info msg="Beginning cluster membership, namespace [harvester-system], lock name [plndr-svcs-lock], id [rhea]"
2021-11-03T12:57:17.171264294Z I1103 12:57:17.170896       1 leaderelection.go:243] attempting to acquire leader lease harvester-system/plndr-svcs-lock...
2021-11-03T12:58:17.187810200Z E1103 12:58:17.187700       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T12:59:18.530732575Z E1103 12:59:18.530541       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:00:20.155476128Z E1103 13:00:20.155329       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:01:21.170638289Z E1103 13:01:21.170516       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:02:22.917334890Z E1103 13:02:22.917204       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:03:24.200126178Z E1103 13:03:24.199914       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:04:25.749185616Z E1103 13:04:25.749018       1 leaderelection.go:325] error retrieving resource lock harvester-system/plndr-svcs-lock: the server was unable to return a response in the time allotted, but may still be processing the request (get leases.coordination.k8s.io plndr-svcs-lock)
2021-11-03T13:05:04.702323908Z I1103 13:05:04.702147       1 leaderelection.go:253] successfully acquired lease harvester-system/plndr-svcs-lock
2021-11-03T13:05:04.702734197Z time="2021-11-03T13:05:04Z" level=info msg="Beginning watching services for type: LoadBalancer in all namespaces"
2021-11-03T13:05:18.349350486Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-prometheus-adapter] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.349374444Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-webhook] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.349822898Z time="2021-11-03T13:05:18Z" level=info msg="Service [csi-resizer] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.351062827Z time="2021-11-03T13:05:18Z" level=info msg="Service [longhorn-backend] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.351096981Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-prometheus] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352266177Z time="2021-11-03T13:05:18Z" level=info msg="Service [harvester-webhook] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352290628Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-coredns] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352297911Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-kubelet] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352305537Z time="2021-11-03T13:05:18Z" level=info msg="Service [rke2-coredns-rke2-coredns] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352311945Z time="2021-11-03T13:05:18Z" level=info msg="Service [longhorn-frontend] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352537072Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-operator] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.352753777Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-expose] has been addded/modified, it has an assigned external addresses [<IP_ADDRESS>]"
2021-11-03T13:05:18.352772989Z time="2021-11-03T13:05:18Z" level=info msg="New VIP [<IP_ADDRESS>] for [rancher-expose/e80dbaf4-c58d-410b-88d0-86f92dbafc0d] "
2021-11-03T13:05:18.353169669Z time="2021-11-03T13:05:18Z" level=info msg="Starting advertising address [<IP_ADDRESS>] with kube-vip"
2021-11-03T13:05:18.357643218Z time="2021-11-03T13:05:18Z" level=info msg="Started Load Balancer and Virtual IP"
2021-11-03T13:05:18.357650305Z time="2021-11-03T13:05:18Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:18.363028791Z time="2021-11-03T13:05:18Z" level=info msg="Service [kubevirt-operator-webhook] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.363140765Z time="2021-11-03T13:05:18Z" level=info msg="Service [rke2-metrics-server] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.363533163Z time="2021-11-03T13:05:18Z" level=info msg="Service [csi-provisioner] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.363566037Z time="2021-11-03T13:05:18Z" level=info msg="Service [prometheus-operated] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.363599612Z time="2021-11-03T13:05:18Z" level=info msg="Service [csi-snapshotter] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364090609Z time="2021-11-03T13:05:18Z" level=info msg="Service [harvester] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364116954Z time="2021-11-03T13:05:18Z" level=info msg="Service [kubevirt-prometheus-metrics] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364143694Z time="2021-11-03T13:05:18Z" level=info msg="Service [csi-attacher] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364573764Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-kube-state-metrics] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364603997Z time="2021-11-03T13:05:18Z" level=info msg="Service [virt-api] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.364629957Z time="2021-11-03T13:05:18Z" level=info msg="Service [kubernetes] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.365117027Z time="2021-11-03T13:05:18Z" level=info msg="Service [gitjob] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.365134781Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-grafana] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.365172695Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher-monitoring-prometheus-node-exporter] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.365457794Z time="2021-11-03T13:05:18Z" level=info msg="Service [rancher] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:18.365484071Z time="2021-11-03T13:05:18Z" level=info msg="Service [webhook-service] has been addded/modified, it has no assigned external addresses"
2021-11-03T13:05:21.390568705Z time="2021-11-03T13:05:21Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:24.430781847Z time="2021-11-03T13:05:24Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:27.462544438Z time="2021-11-03T13:05:27Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:30.491357513Z time="2021-11-03T13:05:30Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:33.527433461Z time="2021-11-03T13:05:33Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:36.563366810Z time="2021-11-03T13:05:36Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"
2021-11-03T13:05:39.599642530Z time="2021-11-03T13:05:39Z" level=info msg="Broadcasting ARP update for <IP_ADDRESS> (64:00:6a:74:cb:9c) via harvester-mgmt"

I tried to reproduce this problem but it didn't occur.


Model accuracy

Now I use 7000 photos as input, but the model accuracy is around 80%. How can I improve the accuracy of the model?

Could you please help me with this?? @chen0040

Hello chenaifang, how many images do you have for each individual person ?

Hello chenaifang, how many images do you have for each individual person ?

two


Add option to skip SSL certificate verification

First of all thank you for your
This option will allow to use HVAC with vault API secured with StartSSL certs.

Hello! It's not documented in the readme, but there is an option when constructing the client to disable SSL verification.
https://github.com/ianunruh/hvac/blob/master/hvac/v1/__init__.py#L6

Great ! Thanks

@tdi FYI, if you're trying to make your environment secure, you should tell HVAC where the CA certificate is, so it can actually verify the cert. You can do this by passing the path to the CA certificate (in PEM format) to the verify parameter on the constructor, like so:
from hvac import Client

client = Client(url='https://vault:8200', verify='/path/to/startssl/ca-cert.pem')

Yes ! works nicely with ca-bundle.pem form StartSSL super thanks @ianunruh


[opusfile] Update to v0.11

Update opusfile to v0.11.
Tested on Windows.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hesiod sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the update and sorry for the delay!


⚠ GitLab Server has degraded performance

In 39aca98, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6571 ms

Resolved: GitLab Server performance has improved in 97c7dff.


Fixing  TypeError with six types

This PR incorporate the PRs

Fixed a TypeError using python3 #361
Workaround for python 3 in css parser. It returned error in some cases. #362

And change how str/unicode is managed, removing the class class byte(bytes) and using the six types.

Coverage decreased (-0.3%) to 48.785% when pulling 9c990ef573eea4bda412f2cb62312f4a745a9a8d on luisza:six_types into f3b35483f98880a0492470473b839535aa9a3360 on xhtml2pdf:master.

Coverage decreased (-0.3%) to 48.785% when pulling 9c990ef573eea4bda412f2cb62312f4a745a9a8d on luisza:six_types into f3b35483f98880a0492470473b839535aa9a3360 on xhtml2pdf:master.

Coverage decreased (-0.1%) to 48.927% when pulling 1d44393b215c12553c21bc0c7defc8d82e050972 on luisza:six_types into f3b35483f98880a0492470473b839535aa9a3360 on xhtml2pdf:master.

Coverage decreased (-0.06%) to 48.994% when pulling 6ca491cfdb0b7864058f30350f285bd79cbfdf56 on luisza:six_types into f3b35483f98880a0492470473b839535aa9a3360 on xhtml2pdf:master.


Swift 5 / Xcode 10.2 compatibility

Swift 5 / Xcode 10.2 compatibility
Estimote iOS SDK version: 4.27.0
iOS device(s) affected: Building for Xcode 10.2 / Swift 5 compiler
Whats wrong?
When I build with Xcode 10.2 / Swift 5 compiler, I get an classic error "Module compiled with Swift 4.2.1 cannot be imported by the Swift 5.0 compiler"
What needs to be done?
Can this please be built with Xcode 10.2(.1) Swift 5.0, as with ABI stability this should be the last time a maintenance update like this is required.

The Fleet Management SDK is a static Obj-C framework, so your error must be coming from another library. Maybe you meant the Proximity SDK? (https://github.com/estimote/ios-proximity-sdk) This one got the Swift 5 update in version 1.3.x.

You're right, I had a moment just then. All sorted thanks


table keyboard cmd focus #3651

table becomes interactive only if you click on its container.
i had to make changes in colReorder plugin because otherwise if we e.g. had focus in code cell and then clicked on a table header focus wasn't removed from the code cell because event was prevented and we got both typing in code cell and table interactions

:+1:


[Bug] format json output

Proposed changes
#6519
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have created an issue on (Fix #6519 ) and described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

I suggest to use bigint or some other library in javascript to solve this problem.
So that we won' t lose type info of the data.
It will be resolved later.

ok,I will close this PR


Update bookings-faq.yml

removed references of companion App
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12173

@JohanFreelancer9 Please copy review

@kwekuako Please merge this PR. Thanks


[stable/jenkins] update agent image

What this PR does / why we need it:
jenkins/jnlp-slave is deprected and jenkins/inbound-agent should be used instead

https://hub.docker.com/r/jenkins/inbound-agent
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @wmcdona89

/lgtm


404 not found

After set config and run project in this API (/rest/tests/1.0/testrun) I give "404 Not Found" and just create test cycle. Why ?

Hi, @mhsafaeii
Most likely, this is because the REST API request is not composed correctly. Try the following:

Open Zephyr
Open DevTool
Create a test cycle
Find the POST /testrun request in DevTool
Copy this request copy --> cBash (curl bash)
Paste this request into Postman and send.

If it works correctly, then compare this request with what the library generates.
Perhaps the project key is specified incorrectly. Or the test cycle status is specified incorrectly. Then I will need to fix this.

Hi
Create testcycle when I run code with your code and set ""statusId": 3247" but in response show 404 not found
Now I follow step by step with your comment. My ""statusId": 32" and give status code "201 created".
This problem is due to wrong set of statusId.

You hardcode set statusId is 3247. Why ?

Моя ошибка. Исправлено.


Fix KubeMismatchVersion false positive alert on Kubernetes < 1.14

This is a continuity of https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/253
to fix fix false positive kubeversionmismatch for Kubernetes < 1.14
After this I'll create a PR to sync the rules in prometheus-opeartor chart.

Thanks!


Fixes cache usage in extraction

Current coverage is 88.66%

Merging #255 into master will decrease coverage by -0.35% as of 68cacaf

@@            master    #255   diff @@
======================================
  Files          191     191
  Stmts         6000    6033    +33
  Branches         0       0
  Methods          0       0
======================================
+ Hit           5341    5349     +8
  Partial          0       0
- Missed         659     684    +25

Review entire Coverage Diff as of 68cacaf

Powered by Codecov. Updated on successful CI builds.


Fix bug in math.frac layout code

Fixes #4855.
Turns out the actual problem was in the fraction layout code. The gap between the numerator/denominator and fraction rule was being calculated incorrectly. According to this, the gap is measured from the top/bottom of the fraction rule, not the axis height. Based on my testing in LuaTeX, the height of math content in Typst is now identical to LuaTeX (I didn't do extensive testing, I only tried a couple situations).
50 tests needed to be updated. I added one new test math-frac-gap to test $ sqrt(n^(2/3)) $ from the linked issue.

Will trust you on this one. Thanks! :)


Win tracker added

Win Tracker Added

Fixes #23

@iamparas0 Will you please review this one ??

Hey @iamparas0 , Review this !!


Option to remove default layers

https://groups.google.com/d/msg/osm-android-bikerouting/wub9db8lTtg/qg8qpayIBgAJ

New option in config.js:
BR.conf.clearBaseLayers = true;


README.md: Remove statement about K8s e2e tests

/area documentation
/kind cleanup
To my latest understanding, there is no capacity to proactively look into K8s e2e tests (looking into test failures and test setups - some may just need to be skipped because they are not applicable in the Gardener context) and the intention was to drop the execution of these e2e tests for now.
Release note:

NONE

/lgtm


ForeignKeyExistsPrecondition throws PreconditionFailedException with foreign keys whose name end with space and also exist in the database

in liquibase 4.3.5 with an h2 database

in https://github.com/liquibase/liquibase/blob/2d333a24a5ffe0c07a55d6bc00e41f48e20e4d57/liquibase-core/src/main/java/liquibase/sqlgenerator/core/AddForeignKeyConstraintGenerator.java#L49
a ForeignKey is saved with trailing spaces if the foreign key name has trailing spaces
in https://github.com/liquibase/liquibase/blob/256675bca43a089e32c940e10ed8ed7a5f9d66f6/liquibase-core/src/main/java/liquibase/precondition/core/ForeignKeyExistsPrecondition.java#L83
a PreconditionFailedException is raised when the foreign key was not found in the database
the foreign key exists in the database but it is not found because the comparison with existing ForeignKeys is done after trimming the name of the existing foreign keys in https://github.com/liquibase/liquibase/blob/8512769590ae3175982c34b4f91d3ff33abdf377/liquibase-core/src/main/java/liquibase/snapshot/ResultSetCache.java#L328
the comparison between ForeignKeys with trimmed name and the ForeignKey that is the object of the foreignKeyExistsPrecondition is done in https://github.com/liquibase/liquibase/blob/256675bca43a089e32c940e10ed8ed7a5f9d66f6/liquibase-core/src/main/java/liquibase/snapshot/SnapshotGeneratorFactory.java#L147

I am aware i should not create foreign keys whose name has trailing spaces and this was not done on purpose, but when trying to fix a database foreign key whose name contains spaces, in a new changeset, the foreignKeyExistsPrecondition throws  PreconditionFailedException.

i expected the foreign key whose name ends with trailing spaces to be found

thank you for your time and for this project!

Hello! It looks like it could have been fixed for liquibase 4.17.2. Can you try upgrading?


Interpretation of edge_attr in FragMolBuildingEnvContext

Hi!
Thanks for the great work on GFlowNets. I am going through the code, to understand and reproduce the multi-objective molecule generation experiments (from the Multi-objective GFlowNets paper).
I am a little bit confused by the interpretation of edge_attributes created by FragMolBuildingEnvContext.graph_to_Data
The edge_attr tensor is initialized as
edge_attr = torch.zeros((len(g.edges) * 2, self.num_edge_dim))

and then filled as follows
for i, e in enumerate(g.edges):
    ad = g.edges[e]
    a, b = e
    for n, offset in zip(e, [0, self.num_stem_acts]):
        idx = ad.get(f'{int(n)}_attach', -1) + 1
        edge_attr[i * 2, idx] = 1
        edge_attr[i * 2 + 1, idx] = 1
        ...

I do not completely understand how I should interpret the features edge_attr[i * 2, :] and edge_attr[i * 2 + 1, :] of the edge number i.
If I understand correctly, in the code above idx takes value 0 when the attribute f'{a}_attach' (f'{b}_attach') is not set. Otherwise, idx is the 1-based index of the stem of node a (b). In particular, if both attributes f'{a}_attach' and f'{b}_attach' are set to 0, then the edge_attr[i * 2, :] = [0, 1, 0, 0, 0, ... ].
Questions:

Is edge_attr[2 * i, :] supposed to be the one-hot encoding of the stems of nodes a and b connected by the i-th edge?
If that's the case. Shouldn't the code be something like this?

self.num_edge_dim = (most_stems + 1) * 2

...

edge_attr = torch.zeros((len(g.edges) * 2, self.num_edge_dim))

...

for i, e in enumerate(g.edges):
    ad = g.edges[e]
    a, b = e
    for n, offset in zip(e, [0, self.num_stem_acts]):
        idx = ad.get(f'{int(n)}_attach', -1) + 1
        edge_attr[i * 2, idx + offset] = 1
        edge_attr[i * 2 + 1, idx + offset] = 1
        ...

Hi @timgaripov, I think you're correct 🤔 by fixing a bug in the encoding in this PR and removing offset I actually introduced another.
For the fragment environment, the edges are actually directed, so we should actually encode the one hot of (a,b) for one edge and (b,a) for the other. I think something like this should be the correct loop:
for i, e in enumerate(g.edges):
    ad = g.edges[e]
    a, b = e
    for j, (n, offset) in enumerate(zip(e, [0, self.num_stem_acts])):
        idx = ad.get(f'{int(n)}_attach', -1) + 1
        edge_attr[i * 2 + eoffset, idx + self.num_stem_acts * j] = 1
        edge_attr[i * 2 + 1 - eoffset, idx + self.num_stem_acts * (1 - j)] = 1

Good catch! Thanks! If you'd like the attribution feel free to open a PR.
Ironically this may not make a big difference, in terms of performance; deep learning is magical that way. I can rerun our benchmarks to see if this breaks/improves anything.

@bengioe, thanks for the prompt response! I am glad that my understanding is correct. I just sent a PR for this.
I was also thinking that edge feature encoding probably wouldn't have a significant effect on the final result. However, taking into account the magical ways of deep learning, I wouldn't be too surprised to see any imaginable (or unimaginable) outcome :grin:


Unable to place 6-sided logs

Hi! So I'm attempting to build a shop on my server, and I'm of course using a schematic. Well, they used 6-sided logs. I've tried using SchematicaReplace, however, it doesn't even replace the logs. Basically, there's no way to pick or actually give myself the 6-sided Spruce log, and it won't place it. Anyway to fix this?

I've posted about this before and never got an answer (hopefully because they're too busy working on the mod)
From what I can tell, it's due to the minecraft coding for blocks and how the newer logs variants coding is so much different than the old ones. 1.13 streamlined the coding and names a lot but since schematica has hit a wall with 1.12, there's nothing that can be done. Hopefully it's fixed in 1.13 or 1.14 update but who knows when that'll be.


Scheduled withdrawal feature

To allow users to exit Theta Vaults with amounts exceeding >10% of the vault, we need a feature that allows users to create a scheduled withdrawal. Each scheduled withdrawal is identified by (msg.sender, withdrawalID).

User calls withdrawLater to avoid getting their assets being allocated into the next short when the user calls rollToNextOption
User calls completeScheduledWithdrawal to close their scheduled withdrawal.

Things I hadn't considered before writing code:

It's possible for an attacker to grief the vault by doing withdrawLater(someLargeNumber) and making the pool's funds unavailable to write shorts. The amount will be locked up potentially permanently.
The solution to this is to verify that the msg.sender actually has sufficient shares to do withdrawLater. So we may have to abandon the use of withdrawID


Why no info on disable?

If I disable Hot Reload the app will not execute as I get a resource (Gray950) not found.  This page does not warn about this.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 31cbef98-89fe-fb8a-c1a5-3119c1f0c207
Version Independent ID: 31cbef98-89fe-fb8a-c1a5-3119c1f0c207
Content: XAML Hot Reload for .NET MAUI - .NET MAUI
Content Source: docs/xaml/hot-reload.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @sqlguy6212
This doesn't sound like a hot reload issue - more likely an issue with bin/obj and resources not rebuilding when hot reload is disabled. The best thing you can do is log an issue in the engineering repo. Thanks!


State not reloaded

I've configured Flow in my single-activity app according to the documentation.  The backstack works correctly and I can see via the debugger that the stack is saved out when the app is closed.
However, when I reopen the app the InternalLifecycleIntegration.load() function is never called.
In my Activity I can see that the normal onCreate, onStart, onResume lifecycle is followed.
Why would the app not reload the saved state?

With further digging it seems that InternalLifecycleIntegration.onActivityCreated() is always called with a null bundle, thus it is unable to load.  However I clearly see that a reasonable bundle (with the right screen objects) is being created in InternalLifecycleIntegration.onSaveInstanceState() and added to the outState bundle.  But it seems like the OS just doesn't resupply the saved bundle in onActivityCreated.
Any idea why this would happen?   FYI I am using a Pixel emulator with API 25.  Also tried a Motorola Nexus 6 (not emulator) with API 24 and same results.

Bundle will be non-null if you put the application in background with HOME, click the "terminate application" button in Android Studio, then relaunch the app from launcher. This is how you can simulate low memory condition behavior.


add logic to stop a consumer after a number of seconds

add logic to stop a consumer after a specific time

@mateusjunges can you take a look ?!

@mihaileu How do I set the max time when creating a consumer using the Kafka facade?

added missing facade method


Full bundling of precomputed slider states

This is a draft PR for a draft PR! Precomputed sliders require many files which are often small and very similar to one another. Bundling solves both these problems in one go:

Bundles can be stored in a single larger file, which can be served statically in its compressed form to reduce size
Notebook clients need only request a bundle once, meaning precomputed values contained within load instantly once the bundle has been downloaded

With the following notebook we see a massive 96% compression of the staterequest folder (where the notebook updates are stored)
BEFORE BUNDLING
17M     60qMnIsupXiarVwdoPP2Vg9cewKaBJfJTlSOgeeEtW0/
AFTER BUNDLING + COMPRESSION
608K    60qMnIsupXiarVwdoPP2Vg9cewKaBJfJTlSOgeeEtW0/

There are inherent limitations to this method, so this PR will not be helpful for all notebooks. For very large slider spaces, bundling the entire space will simply be too large to load in a browser. Future changes may or may not address this issue by implementing partial bundles which only include a certain carefully chosen subset of slider values.
EDIT: Complimentary changes to the sliderserver client are in Pluto.jl#slider-server-bundled

Super nice!!! Can you make a draft PR on the pluto side and link here?


Add driver for GR716 pinmux

This adds a pinmux driver allowing to configure the I/O function
select registers found on the GR716 MCU.

Marking this DNM in hopes that we get the new pinctrl api sorted out.


tasks(sep/base): add Base Sepolia MCP L1 playbook

This PR adds the Base Sepolia MCP L1 upgrade task.
Review instructions:

Follow this folder's instructions to execute playbook and make sure it does not revert
Verify:

That the Validations file is exactly what you see on Tenderly
That the Validations file is consistent with what we'd expect via our notion analysis
That the hardcoded values in ./tasks/sep/base-001-MCP-L1/SignFromJson.s.sol are all accurate and sensible

Diff the new tasks/sep/metal-001-MCP-L1/SignFromJson.s.sol against the existing tasks/sep/base-001-MCP-L1/SignFromJson.s.sol to better see the changes, since most of the file is a copy/paste of that.

Description
We’re putting together Base Sepolia’s MCP upgrade transaction and during the validation of the Safe bundle there were unexpected storage layout changes. This is a point where we want to pause and take a close look at the changes to make sure we're confident in the expected results of the upgrade. The following points can be used to ensure the storage layout changes are a non-issue:

Check what version Base is on, and compare it with the MCP version

If storage variables (not immutables or constants) were only appended, layout is compatible
If storage variables were changed in other ways, make sure the initialize function properly re-sets all variables

Perform the same check for contracts that each contract inherits from. For these contracts, appending is only safe if the __gap size shrinks by the amount of storage variables added.

L1 Contract Comparison
The following l1 contracts are changing in this upgrade. They’ve been pulled from the `VALIDATION.md file, which is what the Tenderly simulation UI shows from the safe bundle simulated state changes.
Relevant Commits

MCP Release Implementation: https://github.com/ethereum-optimism/optimism/commit/e6ef3a900c42c8722e72c2e2314027f85d12ced5

Commit: e6ef3a900c42c8722e72c2e2314027f85d12ced5

Deployment commit compared with MCP

Base Sepolia’s Deployment Implementation: https://github.com/ethereum-optimism/optimism/commit/a7ff5a811612fa338d0a6d6dd72dc2ec9badef6d

Self reported commit: a7ff5a811612fa338d0a6d6dd72dc2ec9badef6d

https://github.com/base-org/contract-deployments/blob/main/sepolia/2023-09-26-deploy/.env

Diff of Base Deploy Commit & MCP Commit: https://github.com/ethereum-optimism/optimism/compare/a7ff5a811612fa338d0a6d6dd72dc2ec9badef6d...e6ef3a900c42c8722e72c2e2314027f85d12ced5

L1StandardBridge upgrade commit compared with MCP

Their L1StandardBridge implementation was upgraded after initial deployment

Current Implementation: https://github.com/ethereum-optimism/optimism/commit/e3ba24e72085d85bb5584dda33a03ccf60db86f0

Self reported commit: e3ba24e72085d85bb5584dda33a03ccf60db86f0

https://github.com/base-org/contract-deployments/blob/main/sepolia/2023-10-07-upgrade-l1-standard-bridge/.env

Diff of Upgrade Commit & MCP Commit: https://github.com/ethereum-optimism/optimism/compare/e3ba24e72085d85bb5584dda33a03ccf60db86f0...e6ef3a900c42c8722e72c2e2314027f85d12ced5

Note: The GitHub commit diff tool doesn’t allow you to compare on the file level, so I just searched the contract name in the Files changed tab.

0x21eFD066e581FA55Ef105170Cc04d74386a09190 (L1ERC721BridgeProxy)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0x21eFD066e581FA55Ef105170Cc04d74386a09190)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L4)

Diff: https://github.com/ethereum-optimism/optimism/compare/a7ff5a811612fa338d0a6d6dd72dc2ec9badef6d...e6ef3a900c42c8722e72c2e2314027f85d12ced5

packages/contracts-bedrock/src/L1/L1ERC721Bridge.sol

No storage variable changes

packages/contracts-bedrock/snapshots/storageLayout/L1ERC721Bridge.json

Did not exist at deployment commit

packages/contracts-bedrock/deployments/mainnet/L1ERC721Bridge.json
packages/contracts-bedrock/deployments/sepolia/L1ERC721Bridge.json

0x49f53e41452c74589e85ca1677426ba426459e85 (OptimismPortalProxy)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0x49f53e41452c74589e85ca1677426ba426459e85)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L8)

Diff: https://github.com/ethereum-optimism/optimism/compare/a7ff5a811612fa338d0a6d6dd72dc2ec9badef6d...e6ef3a900c42c8722e72c2e2314027f85d12ced5

packages/contracts-bedrock/src/L1/OptimismPortal.sol

reinitializer(2) to initializer
guardian removed

/// @notice Address that has the ability to pause and unpause withdrawals.
/// @custom:network-specific
address public guardian;

spacer and superchainConfig added

/// @custom:legacy
/// @custom:spacer paused
/// @notice Spacer for backwards compatibility.
bool private spacer_53_0_1;

/// @notice Contract of the Superchain Config.
SuperchainConfig public superchainConfig;

0x709c2B8ef4A9feFc629A8a2C1AF424Dc5BD6ad1B (AddressManager)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0x709c2B8ef4A9feFc629A8a2C1AF424Dc5BD6ad1B)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L2)

Diff:

packages/contracts-bedrock/scripts/interfaces/IAddressManager.sol

Implementation doesn’t exist for this legacy contract

packages/contracts-bedrock/snapshots/abi/AddressManager.json

Did not exist at deployment

0x84457ca9d0163fbc4bbfe4dfbb20ba46e48df254 (L2OutputOracleProxy)

⚠ The storage layout change seems like a hotspot.

Links:

[Etherscan](https://sepolia.etherscan.io/address/0x84457ca9d0163fbc4bbfe4dfbb20ba46e48df254)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L6)

Diff:

packages/contracts-bedrock/src/L1/L2OutputOracle.sol

SUBMISSION_INTERVAL, L2_BLOCK_TIME, and FINALIZATION_PERIOD_SECONDS immutables were removed
/// @notice The interval in L2 blocks at which checkpoints must be submitted.
///         Although this is immutable, it can safely be modified by upgrading the
///         implementation contract.
///         Public getter is legacy and will be removed in the future. Use `submissionInterval`
///         instead.
/// @custom:legacy
uint256 public immutable SUBMISSION_INTERVAL;

/// @notice The time between L2 blocks in seconds. Once set, this value MUST NOT be modified.
///         Public getter is legacy and will be removed in the future. Use `l2BlockTime`
///         instead.
/// @custom:legacy
uint256 public immutable L2_BLOCK_TIME;

/// @notice The minimum time (in seconds) that must elapse before a withdrawal can be finalized.
///         Public getter is legacy and will be removed in the future. Use
//          `finalizationPeriodSeconds` instead.
/// @custom:legacy
uint256 public immutable FINALIZATION_PERIOD_SECONDS;

submissionInterval, l2BlockTime, and finalizationPeriodSeconds state variables added. They were not just appended, the proposer and challenger sit in between.
	/// @notice The interval in L2 blocks at which checkpoints must be submitted.
/// @custom:network-specific
uint256 public submissionInterval;

/// @notice The time between L2 blocks in seconds. Once set, this value MUST NOT be modified.
/// @custom:network-specific
uint256 public l2BlockTime;

/// @notice The address of the challenger. Can be updated via upgrade.
/// @custom:network-specific
address public challenger;

/// @notice The address of the proposer. Can be updated via upgrade.
/// @custom:network-specific
address public proposer;

/// @notice The minimum time (in seconds) that must elapse before a withdrawal can be finalized.
/// @custom:network-specific
uint256 public finalizationPeriodSeconds;

reinitializer(2) to initializer

packages/contracts-bedrock/deployments/mainnet/L2OutputOracle.json

0xb1efB9650aD6d0CC1ed3Ac4a0B7f1D5732696D37 (OptimismMintableERC20FactoryProxy)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0xb1efB9650aD6d0CC1ed3Ac4a0B7f1D5732696D37)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/5ad42cbb49472a0bf164ade976426f7526ee6dfe/superchain/extra/addresses/sepolia/base.json#L7)

Diff:

packages/contracts-bedrock/src/universal/OptimismMintableERC20Factory.sol

spacer and gap added
	/// @custom:spacer OptimismMintableERC20Factory's initializer slot spacing
/// @notice Spacer to avoid packing into the initializer slot
bytes30 private spacer_0_2_30;

/// @notice Address of the StandardBridge on this chain.
/// @custom:network-specific
address public bridge;

/// @notice Reserve extra slots in the storage layout for future upgrades.
///         A gap size of 49 was chosen here, so that the first slot used in a child contract
///         would be 1 plus a multiple of 50.
uint256[49] private __gap;

reinitializer(2) to initializer

Contracts this inherits from

packages/contracts-bedrock/src/universal/Semver.sol

deleted and the ISemver.sol interface didn’t appear, so it was unchanged

packages/contracts-bedrock/src/dispute/interfaces/IInitializable.sol

initialize() was changed from external to payable
Initializable.sol did not appear, so it was unchanged

0x5D335Aa7d93102110879e3B54985c5F08146091E (L1CrossDomainMessengerProxy)

⚠ To double check, the new state variables were added/appended, but idk if removing a state variable changes the validation considerations outlined in the description above.

Links:

[Etherscan](https://sepolia.etherscan.io/address/0x5D335Aa7d93102110879e3B54985c5F08146091E)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/5ad42cbb49472a0bf164ade976426f7526ee6dfe/superchain/extra/addresses/sepolia/base.json#L3)

Diff:

packages/contracts-bedrock/src/L1/L1CrossDomainMessenger.sol

PORTAL removed
/// @custom:network-specific
/// @custom:legacy
OptimismPortal public PORTAL;

superchainConfig and portal added
/// @notice Contract of the SuperchainConfig.
SuperchainConfig public superchainConfig;

/// @notice Contract of the OptimismPortal.
/// @custom:network-specific
OptimismPortal public portal;

reinitializer(2) to initializer

0xf272670eb55e895584501d564AfEB048bEd26194 (SystemConfigProxy)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0xf272670eb55e895584501d564AfEB048bEd26194)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L10)

Diff:

packages/contracts-bedrock/src/L1/SystemConfig.sol

startBlock removed

/// @notice The block at which the op-node can start searching for logs from.
uint256 public startBlock;

Only constants added
reinitializer(2) to initializer

0xfd0Bf71F60660E2f608ed56e1659C450eB113120 (L1StandardBridgeProxy)
Links:

[Etherscan](https://sepolia.etherscan.io/address/0xfd0Bf71F60660E2f608ed56e1659C450eB113120)
[Superchain Registry](https://github.com/ethereum-optimism/superchain-registry/blob/a62fd38c9239459b27ea50a2df895e89a3305382/superchain/extra/addresses/sepolia/base.json#L5)

Commits:

MCP Release Implementation: https://github.com/ethereum-optimism/optimism/commit/e6ef3a900c42c8722e72c2e2314027f85d12ced5
https://github.com/ethereum-optimism/optimism/compare/e3ba24e72085d85bb5584dda33a03ccf60db86f0...e6ef3a900c42c8722e72c2e2314027f85d12ced5

Diff:

packages/contracts-bedrock/src/L1/L1StandardBridge.sol

superchainConfig added
/// @notice Address of the SuperchainConfig contract.
SuperchainConfig public superchainConfig;

After review, all of these state changes look safe and expected. There is one specific call out from taking a close look at the implementation contracts. In regard to the SystemConfig, similar to  OptimismPortal, the removed variable does not have a storage setter call meaning we’ll have a dangling storage value. Unlike OptimismPortal, no future upgrade would clear this. Having this dangling storage poses no risk currently, but is just a bit dirty and is possible (but unlikely) to be an issue in the future if we forget about it.

For example, we add a slot to SystemConfig that we intend to leave at 0 during deployment, and for Base this value would not be zero. In reality we should explicitly initialize to zero in this case.
Interestingly, Base Mainnet SystemConfig version (1.3.0) is older than their sepolia one, and is one we used in production, and therefore does not have this same risk. This lends itself towards the “leave as-is” category.

Safe now, but may be unsafe in the future, for Sepolia only. We could manually add an additional storage setter to the input.json transaction bundle to clear this. However this can always be cleared in a separate, future, dedicated “upgrade” that Base does, which is probably the best approach.


[4.5.0] Nginx-acme: Set LetsEncrypt as default CA

Updated cert generation script to first set LetsEncrypt as the default CA before cert generation.

(cherry picked from commit 5aab5e2f939d24319b9ce26deac8ed1a450fd86f)

Build finished.


Check the documentation for overview section.

Justine and I modified the documentation, please check to see if it makes sense.

This looks good for now, but I think we are missing some commands. Let's revisit the command list when we have our pending commands merged.

@jcocchi It's definitely not comprehensive, I wasn't sure whether or not it'd be appropriate to include admin, owner, or private room commands in the readme. For now, I listed user or room based commands.


Update SOCKS5 page, follow-up to pr 31527

This PR is a follow-up to PR https://github.com/kubernetes/website/pull/31527
to address comments/suggestions
/assign @divya-mohan0209

Thanks @reylejano for opening this!


Error when adding RHEV provider: "undefined method `url' for nil:NilClass"

While attempting to add a RHEV provider via the latest master on the latest nightly appliance build the follow error appears in the UI (upon clicking 'validate' to validate credentials) and in evm.log:
[----] E, [2015-03-17T18:19:12.576725 #7844:8c5e88] ERROR -- : MIQ(ems_infra_controller-create):
undefined method `url' for nil:NilClass
The root cause of this error is unknown (investigating) though others have encountered this and it is reported as not being an issue in the 5.3.2 standard build.

@jrafanie Please see.  I think this may be related to some other issues like we are seeing with Amazon as well.

Seems to be an issue w/ the ovirt gem, specifically resource is nil on this line:
https://github.com/ManageIQ/ovirt/blob/master/lib/ovirt/service.rb#L220
undefined method `url' for nil:NilClass ["/var/www/miq/vmdb/app/models/ems_redhat.rb:74:in `rescue in verify_credentials_for_rhevm'",
 "/var/www/miq/vmdb/app/models/ems_redhat.rb:68:in `verify_credentials_for_rhevm'",
 "/var/www/miq/vmdb/app/models/ems_redhat.rb:127:in `verify_credentials'",
 "/var/www/miq/vmdb/app/controllers/ems_common.rb:200:in `create'",

Debugging further
["/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:220:in `rescue in resource_verb'",
 "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:195:in `resource_verb'",
 "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:172:in `resource_get'",
 "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:37:in `api'",
 "/var/www/miq/vmdb/app/models/ems_redhat.rb:69:in `verify_credentials_for_rhevm'",
 "/var/www/miq/vmdb/app/models/ems_redhat.rb:128:in `verify_credentials'",
 "/var/www/miq/vmdb/app/controllers/ems_common.rb:200:in `create'",

@Fryguy @jrafanie
Investigating further the ovirt gem seems to be getting tripped up when constructing the base_uri (hence the resource never gets instantiated & is nil) which in return is being caused by Uri::Generic not being able to verify the port which is throwing the InvalidComponentError here:
http://apidock.com/ruby/v1_9_2_180/URI/Generic/check_port
Looking at the validation request, the only parameters that are being sent to the 'create' action are 'button', 'type', and 'id':
[----] I, [2015-03-18T15:35:15.476415 #5081:ac3e88]  INFO -- : Processing by EmsInfraController#create as JS
[----] I, [2015-03-18T15:35:15.476503 #5081:ac3e88]  INFO -- :   Parameters: {"button"=>"validate", "type"=>"default", "id"=>"new"}
[----] I, [2015-03-18T15:35:15.494945 #5081:ac3e88]  INFO -- :   Rendered layouts/_flash_msg.html.haml (0.6ms)

This was verified on the client side w/ firebug. This should be sending all the parameters from the form for verification should it not?

@movitto good find!  i'll open an WIP PR on ovirt with ideas.

@movitto @Fryguy see https://github.com/ManageIQ/ovirt/pull/25, please try that so we can see what exception is being raised when trying to create the resource.

@jrafanie while the patch looks like an improvement (removing the assumption that the resource has been created in the err handler) the root cause of this is due to an error that URI::Generic is throwing.
URI::Generic is attempting to validate the port being specified when invoked from the ovirt gem which is failing due to the port parameter not being specified in the POST to the MiQ  EmsInfraController#create method (from what I can tell). Why these parameters are not appearing in the request a mystery to me (perhaps some recent UI changes?)

Yes, we need to see the real error.  What's the URI error?  Is the port a string instead of a Fixnum?
For example, this:
irb(main):002:0> URI::Generic.build(:port => "123")
URI::InvalidComponentError: bad component(expected port component): 123
	from /Users/joerafaniello/.rubies/ruby-2.1.5/lib/ruby/2.1.0/uri/generic.rb:697:in `check_port'
	from /Users/joerafaniello/.rubies/ruby-2.1.5/lib/ruby/2.1.0/uri/generic.rb:745:in `port='
	from /Users/joerafaniello/.rubies/ruby-2.1.5/lib/ruby/2.1.0/uri/generic.rb:196:in `initialize'
	from /Users/joerafaniello/.rubies/ruby-2.1.5/lib/ruby/2.1.0/uri/generic.rb:141:in `new'
	from /Users/joerafaniello/.rubies/ruby-2.1.5/lib/ruby/2.1.0/uri/generic.rb:141:in `build'

Is this related: I saw @blomquisg was doing .to_i on a port and thought it was odd
https://github.com/ManageIQ/manageiq/pull/2178#discussion_r26629860

This should be sending all the parameters from the form for verification should it not?

I believe the parameters from the form are sent as you type them and stored in the session.  So, when you press Save, it uses what's in the session.  @dclarizio Is that correct?

This should be sending all the parameters from the form for verification should it not?

I believe the parameters from the form are sent as you type them and stored in the session. So, when you press Save, it uses what's in the session. @dclarizio Is that correct?

Correct, the latest values from the form are in the session and that is what would be used when validate is done.

@jrafanie Full error:
bad component(expected port component): 443
["/opt/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/uri/generic.rb:697:in check_port'",  "/opt/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/uri/generic.rb:745:in port='",
"/opt/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/uri/generic.rb:196:in initialize'", "/opt/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/uri/generic.rb:141:in new'",
"/opt/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/uri/generic.rb:141:in build'", "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:257:in base_uri'",
"/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:128:in api_uri'",  "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:189:in create_resource'",
"/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:197:in resource_verb'", "/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:172:in resource_get'",
"/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:37:in api'", "/var/www/miq/vmdb/app/models/ems_redhat.rb:69:in verify_credentials_for_rhevm'",
"/var/www/miq/vmdb/app/models/ems_redhat.rb:128:in verify_credentials'", "/var/www/miq/vmdb/app/controllers/ems_common.rb:200:in create'",
Debugging further it seems that the 'port' attribute of the EmsRedhat instance is infact a string, so unless it is being converted this would cause the error above.
require 'uri/generic'
g = URI::Generic.build :host => "whatever"
g.send(:check_port, "443")

Again perhaps a recent UI / app change is the cause of a string being sent instead of a fixnum? Related to #2243 ?

thanks @movitto.  @blomquisg ping, can you take a look?  I'm not sure why the .to_i was needed in #2178 and the related #2243.  It should be ok to do it but we need to understand what is providing port values as strings and determine where this should be fixed, in the originator of the string or each of the consuming provider classes.

@blomquisg @Fryguy it looks like we have port as a string in the database :bug:
Please tell me one of you can fix this.
From my local schema.rb:
grep -E -B 10 "string.+\bport\b" db/schema.rb
  create_table "ext_management_systems", id: :bigserial, :force => true do |t|
    t.string   "name"
    t.string   "port"
--

  create_table "storage_managers", id: :bigserial, :force => true do |t|
    t.string   "ipaddress"
    t.string   "agent_type"
    t.integer  "last_update_status"
    t.datetime "created_at",                      :null => false
    t.datetime "updated_at",                      :null => false
    t.integer  "zone_id",            :limit => 8
    t.string   "name"
    t.string   "hostname"
    t.string   "port"

Once this is fixed, we should drop the .to_i business.

Yes.   I knew about this,  but this had always been working so didn't
realize it was related.   I started switching to integer with the multi
endpoint but that got back burnered
On Mar 20, 2015 6:17 PM, "Joe Rafaniello"<EMAIL_ADDRESS>wrote:

@blomquisg https://github.com/blomquisg @Fryguy
https://github.com/Fryguy it looks like we have port as a string in the
database [image: :bug:]
Please tell me one of you can fix this.
From my local schema.rb:
grep -E -B 10 "string.+\bport\b" db/schema.rb
create_table "ext_management_systems", id: :bigserial, :force => true do |t|
t.string   "name"
t.string   "port"
create_table "storage_managers", id: :bigserial, :force => true do |t|
t.string   "ipaddress"
t.string   "agent_type"
t.integer  "last_update_status"
t.datetime "created_at",                      :null => false
t.datetime "updated_at",                      :null => false
t.integer  "zone_id",            :limit => 8
t.string   "name"
t.string   "hostname"
t.string   "port"
—
Reply to this email directly or view it on GitHub
https://github.com/ManageIQ/manageiq/issues/2219#issuecomment-84168015.

@jrafanie @Fryguy so what's that status on this?

@movitto does it work now? @matthewd fixed what I would think is the issue in PR #2258 in commit:  3a04e02ced3593e1a56b647c3b93ac1a42dbb535
Can you git pull and try it now?

@jrafanie looks good, was able to add the rhev provider when I updated to latest master. Closing

Great, thanks @movitto

@jrafanie  @Fryguy  Seemingly related error reoccurring in the logs:
[----] E, [2015-03-31T16:28:28.571230 #23816:249aaf0] ERROR -- : [NoMethodError]: undefined method url' for nil:NilClass  Method:[rescue in block in start_event_monitor] [----] E, [2015-03-31T16:28:28.571283 #23816:249aaf0] ERROR -- : /opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:220:in rescue in resource_verb'
/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:195:in resource_verb' /opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:172:in resource_get'
/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/service.rb:109:in standard_collection' /opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/inventory.rb:100:in standard_collection'
/opt/rubies/ruby-2.0.0-p643/lib/ruby/gems/2.0.0/gems/ovirt-0.4.0/lib/ovirt/inventory.rb:33:in events' /var/www/miq/lib/ovirt_provider/events/ovirt_event_monitor.rb:26:in each_batch'
/var/www/miq/vmdb/lib/workers/event_catcher_redhat.rb:34:in monitor_events' /var/www/miq/vmdb/lib/workers/event_catcher.rb:99:in block in start_event_monitor'
/var/www/miq/vmdb/lib/extensions/ar_thread.rb:11:in `block in new_with_release'
Not sure what is causing, though am investigating other issue when attempting to add RHEV host credentials. Running on latest master.


feat(Symfony Version) add Symfony Version.

If we speak about theory, the variables that we must consider for the matrix are:

version of Symfony
version of the dependencies (lowest and highest)
version of PHP
OS

Exploding such matrix into builds will generate a lot of them, that's a fact, but it's also the correct way to ensure that everything works well in all scenarios. Any other solution involving less builds is likely better for resources and time, but it will be also more error-prone. I've seen other repos where they have a lot of checks, and I don't think it would be a problem for us to do the same in terms of numbers, and our CI is anyway fast enough to not take ages to complete

If we speak about theory, the variables that we must consider for the matrix are:

version of Symfony
version of the dependencies (lowest and highest)
version of PHP
OS

Exploding such matrix into builds will generate a lot of them, that's a fact, but it's also the correct way to ensure that everything works well in all scenarios. Any other solution involving less builds is likely better for resources and time, but it will be also more error-prone. I've seen other repos where they have a lot of checks, and I don't think it would be a problem for us to do the same in terms of numbers, and our CI is anyway fast enough to not take ages to complete

Due to the Symfony BC promise, it should be superfluous to test all those versions though.
Also, I'm not sure about OS, since we shouldn't have any OS-dependent handling in this bundle, whereas in the base SDK we have something more low-level that could, and in fact we test it.

Due to the Symfony BC promise, it should be superfluous to test all those versions though.
Also, I'm not sure about OS, since we shouldn't have any OS-dependent handling in this bundle, whereas in the base SDK we have something more low-level that could, and in fact we test it.

@Jean85
I think it's important to check now (Symfony 4.4.* / Symfony 5.0. *) together with PHP versions 7.4 and 8.0. in the future the most popular number of projects.

@Jean85
I think it's important to check now (Symfony 4.4.* / Symfony 5.0. *) together with PHP versions 7.4 and 8.0. in the future the most popular number of projects.

@Yozhef still, the BC promise protects us in that regard: 5.0 is the same as 4.4 without deprecation, and any 5.x will still be compatible with 5.0.
So I would test against:

3.4
4.4
5.x
prefer-lowest (which is forcibly 3.4)

This would mean 4 deps versions + 4 PHP versions already (7.2 -> 8.0) or 8 if you count OS variation, for a total of 12 + static analysis... If you add any version in between we're going over 20-30!

@Yozhef still, the BC promise protects us in that regard: 5.0 is the same as 4.4 without deprecation, and any 5.x will still be compatible with 5.0.
So I would test against:

3.4
4.4
5.x
prefer-lowest (which is forcibly 3.4)

This would mean 4 deps versions + 4 PHP versions already (7.2 -> 8.0) or 8 if you count OS variation, for a total of 12 + static analysis... If you add any version in between we're going over 20-30!

@Jean85 I think that's enough, but ready to listen to what you suggest to change? Now we have:
Symfony 5.0.* PHP 8.0
Symfony 5.0.* PHP 7.4
Symfony 4.4.* PHP 8.0
Symfony 3.4 PHP 7.2
Symfony 4.4.* PHP 7.4
PHP 8.0
PHP 7.4
PHP 7.3
PHP 7.2
PHP 7.2 - lower

@Jean85 I think that's enough, but ready to listen to what you suggest to change? Now we have:
Symfony 5.0.* PHP 8.0
Symfony 5.0.* PHP 7.4
Symfony 4.4.* PHP 8.0
Symfony 3.4 PHP 7.2
Symfony 4.4.* PHP 7.4
PHP 8.0
PHP 7.4
PHP 7.3
PHP 7.2
PHP 7.2 - lower

I repeat, testing 5.0 on its own in addition to the latest 5.x doesn't make sense, for the same reason for which we don't test for 4.0.
I would test like this:

PHP 8.0 (implicitly selects latest SF 5.x)
PHP 7.4 (implicitly selects latest SF 5.x)
PHP 7.3 (implicitly selects latest SF 5.x)
PHP 7.2 (implicitly selects latest SF 5.x)
PHP 7.4 SF 4.4
PHP 7.4 SF 3.4
PHP 7.2 prefer lowest

For a grand total of 7, to double it with OS variation if we want. 14 jobs seems enough to me.

I repeat, testing 5.0 on its own in addition to the latest 5.x doesn't make sense, for the same reason for which we don't test for 4.0.
I would test like this:

PHP 8.0 (implicitly selects latest SF 5.x)
PHP 7.4 (implicitly selects latest SF 5.x)
PHP 7.3 (implicitly selects latest SF 5.x)
PHP 7.2 (implicitly selects latest SF 5.x)
PHP 7.4 SF 4.4
PHP 7.4 SF 3.4
PHP 7.2 prefer lowest

For a grand total of 7, to double it with OS variation if we want. 14 jobs seems enough to me.

I've re-targeted this to develop to reduce the noise in the diff. It could change again if we merge develop into master due to the preparation of the 4.1 release.

3.4 is giving us some issues: https://github.com/symfony/symfony/pull/40679 has not been backported there since it's not a security fix, the only way I see to fix this is we should switch to pcov here too.
Also, we need to exclude 8.0 + 3.4 because there's no compatible set of components: https://github.com/getsentry/sentry-symfony/pull/410/checks?check_run_id=2336880519


fix: ignore erroneous 404s in cypress tests

We're getting erroneuous 404s when these tests are running that seem to have to do with the redirect and hosting on S3. These 404s do not appear when using the app in practice. I'm ignoring them here because in every case we go on to validate actual behavior after we visit.

Valid run: https://github.com/systeminit/si/actions/runs/9946056125


additional data defaults when importing keys from export files

Fixes #1229
Proposed Changes
For export-importer

backfill report type
backfill transmission risk
backfill days since onset

Release Note
Export-importer changes to backfill missing data on export files during processing.

/hold

/hold cancel


Rename prepper to processor in pipeline configuration sample for Data Prepper

Signed-off-by: Hai Yan<EMAIL_ADDRESS>Description
This PR updates the deprecated prepper name to processor in the pipeline configuration sample.
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS , This change is valid in the current version of Data Prepper and we are happy to have it merged and deployed at your earliest convenience.


Switch state does not change

Home Assistant release (hass --version):
0.51.2
Python release (python3 --version):
3.5.3
Component/platform:
Web GUI
Description of problem:
Turning on/off a switch changes the switch state for a second and then turns back to starting state.
Additional info:
I am using home assistant with an nginx reverse proxy. Everything works nice so far. The switch that I try to use is a zwave switch. The state on the hardware side does change for real, so the general zwave stuff works just fine.

This is a NGINX config issue, if I connect to HASS directly, without reverse proxy, switches work fine. Something needs to added/modded in the server block, something is breaking it.

I can't acknowledge this. With the current HASS version and a direct connection (without any proxy) I have the exact same behaviour.

I don't think this is a UI problem either. I have 2 Aeotec Smart Switch 6 units with speakers attached, and 2 automation for each which turns them on/off based on the state of Chromecast Audio units.
Sometimes, when an automation turns on a smart switch, that switch will remain off in the UI. As an other automation will only turn that switch off again if it is indeed on (to avoid sending pointless commands), the switch will just stay on indefinitely if I don't intervene. This means the state isn't just shown as being off in the UI, but Home Assistant actually thinks the state is still off so my automation won't fire. Admittedly, I have yet to put in time to figure out if this is a Home Assistant issue, or a reliability issue on my Z-Wave network. I'm not quite sure how to troubleshoot that, though.
Other times, when I toggle the switches in the UI, they will switch back to the old state for a few seconds, before showing the actual new state. Here, I have yet to test if accessing the UI via the host ip address, rather than through an nginx reverse proxy, makes a difference. If it doesn't...then I wouldn't be sure how to troubleshoot this either.


Feature Request: Additional Output/Logging when KubernetesSecretConfigProvider Fails to Enumerate Values

I Strimzi crew 👋 Thanks for the great tool(s)!
Backstory
I was recently pulling my hair out over a KafkaConnector not connecting to our brokers. It was complaining about not being authorised to access the subject in Schema Registry. I spent quite a bit of time debugging everything on our clusters and in Kafka, but it wasn't until I took a wild guess and hard-coded my credentials into the KafkaConnector manifest that I realised that my ${secret:<namespace>/<name>:<key>} entries in spec.config weren't being templated because we hadn't granted the correct RBAC... in reality the Connector was trying to authenticate with the following literal string in it's configuration:
value.converter.basic.auth.user.info=${secret:dev/my-app-secret:userinfo}

instead of the expected
value.converter.basic.auth.user.info=secret_username:super_secret_password

Request
It'd be really nice if there was some output indicating that the secrets weren't enumerating correctly in my spec.config. I'm not super familiar with the inner workings of the codebase, but I assume it'd be additional logging on KubernetesSecretConfigProvider and KubernetesConfigMapConfigProvider?
Thanks again for the great tool.

What does it mean KubernetesSecretConfigProvider Fails to Enumerate Values?

What does it mean KubernetesSecretConfigProvider Fails to Enumerate Values?

When the operator fails to turn ${secret:namespace/kubernetes-secret:KEY} into the secret value and instead just uses ${secret:namespace/kubernetes-secret:KEY} as a literal string.

This is not handled by any operator. This is done by Kafka. So if it was not used properly, I guess you misconfigured something ... for example you didn't properly configure the provider or might have some special characters somewhere? Or Kafka does not support the provider in a place where you are trying to use it.
I have no idea what value.converter.basic.auth.user.info is or where it is. So I do not know if it is expected that the configuration providers would work there or not.
In any case, I do not think this is a problem of logging -> when the value stays the same as you entered it, the config provider was likely never called by Kafka. So there is no way it can log something.

Sorry, my explanation must be lacking.
The specific request is to have any failed invocation of kafka-kubernetes-config-provider be more verbose when it fails to expand on a ${secrets:......} string.

But as I said, I don't think there was any failed invocation. Based on what you shared, the provider was likely not called at all.