feat: support max_results and pagination_token parameter at GET /2/tweets/:id/retweeted_by #270

Close #270

Codecov Report

Merging #277 (478e9eb) into main (6b319d2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   96.64%   96.65%   +0.01%
==========================================
  Files          60       60
  Lines        2560     2571      +11
==========================================
+ Hits         2474     2485      +11
  Misses         58       58
  Partials       28       28

Impacted Files
Coverage Δ

tweet/retweet/types/parameter.go
95.89% <100.00%> (+0.72%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@michimani I may be mistaking but it seems the pagination has been added into the input but not the output.
when manually calling the related api from twitter, i do see the meta with the nextToken in the response.
without having that value returned in the output / response, it seems impossible to use the pagination on that endpoint.
same goes for like.ListUsers ie https://api.twitter.com/2/tweets/:id/liking_users and userlookup.Get ie https://api.twitter.com/2/users/:id


Missing Images in VG_100K_2 Directory

When preparing the dataset, I encountered missing images in the VG_100K_2 directory. Specifically:

Total examples in JSON: 1431521
Available examples: 1357759
Missing examples: 73762

Example missing files:

/images/VG_100K_2/51.jpg
/images/VG_100K_2/52.jpg
/images/VG_100K_2/53.jpg
/images/VG_100K_2/54.jpg
/images/VG_100K_2/55.jpg ....

Could you please provide guidance on how to obtain these missing images or update the dataset accordingly?

Hi, how did you solve the issue?

The huggingface dataset is missing VG_100K_2.
Download it from the original source and unzip it in the images/ folder.
Reference: https://huggingface.co/datasets/ranjaykrishna/visual_genome/blob/65bc9e7e7353fff750326c9523e384701934e530/visual_genome.py#L54


Spotlight | Reactions to scrolling/window resize shouldn't smoothly animate

Currently when scrolling while the spotlight is targeting an element, the spotlight will smoothly animate to the new position - which makes it feel like it's lagging behind. Ideally it should just scroll with the page contents. The same happens when the screensize changes
Dev hint: The useMemo for the spotlight rectangle bounds can update as usual, but the useSpring config needs to be set() with immediate: true when it is triggered by a scroll.

:tada: This issue has been resolved in version 1.16.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Auto-completions from global type definitions don't work without initial text

TS Template added by @mjbvz
TypeScript Version: 3.9.6
Search Terms

untitled
suggest / suggestions

I'm not sure if this is the right place to open the issue (I also don't know where the TS language server is on github), so if it isn't, move the issue to the right place please :)
Steps to Reproduce:

Open a new untitled file
Set the syntax to javascript
Paste the following code:/**
 * @type {import('webpack').Configuration}
 */
module.exports = {

};

Ctrl+click the word Configuration to jump to the type definitions file, and make sure it is the one that comes with VSCode (on Windows it's %LOCALAPPDATA%\Microsoft\TypeScript\3.9\node_modules\@types\webpack\index.d.ts).
Go back to the untitled file, and place the cursor inside the braces of the exports object
Trigger autocompletion popup using Ctrl+Space
Only snippets and words from the current file are suggested, instead of members from the type definition.
Close the popup using Escape
Type m
The completions for mode and module appear, from the type definition.

If you repeat this with a saved file inside a folder with @types/webpack installed in node_modules, the autocompletion will show all the members as expected.

VS Code Version: Code - Insiders 1.47.0-insider (376d9d9d785ccca128fdbb16f001446d0ad64d32, 2020-07-03T10:27:06.804Z)
OS Version: Windows_NT x64 10.0.18363

Does this issue occur when all extensions are disabled?: Yes

@RyanCavanaugh can you explain why is this awaiting feedback and tagged as a suggestion?
To me this seems like a bug.
The behavior is the same if you start typing whether the type definitions are local or global, but if you don't type anything the behavior is different.

Yep, you're right


retroarch cask is unfortunately out of date

Hello there,
could someone please update the retroarch cask? Sorry for creating this issue, but I didn’t figure out who’s maintaining this cask.
Is there any beginner friendly tutorial for updating casks?
Thanks a lot!

but I didn’t figure out who’s maintaining this cask.

There are no maintainers for specific casks. Anyone can update one.

Is there any beginner friendly tutorial for updating casks?

Yes. Not only instructions, but a whole script geared for it.

https://github.com/caskroom/homebrew-cask/pull/19406


GitHub CI Tests

Add pre-submit, and post-submit jobs.
Add test-no-verify target.

Merge #11 first in order to test the pre-submit job

Merge #11 first in order to test the pre-submit job

I think it makes more sense to merge this one first, so the new unit test is actually executed on its PR?
/lgtm
/hold

Merge #11 first in order to test the pre-submit job

I think it makes more sense to merge this one first, so the new unit test is actually executed on its PR?
/lgtm /hold

It does make sense.
/unhold

/lgtm


Folders refactoring

No problems with the code, but we should preserve folded/unfolded state of folders during screen rotation.


Native Editor - Make sure intellisense works in the native editor

Not sure if it's working or not. Test it to make sure. If it isn't fix it.
Likely the dummy document we create is not being updated correctly as typing occurs.

Adding new cells breaks intellisense

Moving back to in progress.
We need to inform the intellisense provider whenever we

Delete a cell
Add a cell
Reorder cells (this affects the underlying document)

I think that would likely be possible if the baseIntellisenseProvider tracked the sendInfo message and passed the cells in it onto the document. The document could then check if the order changed or if any cells were added/removed.

This is going to be a big refactor, everything in baseIntellisenseProvider and IntellisenseDocument assumes it getting the document from the interactive window.

Sorry but I'm still having problems if I delete and then move a cell. Repro'd with a simple notebook with 2 cells in it and some markdown

Move cell up
Delete bottom cell
Add new cell

Intellisense doesn't work on top cell anymore.

Validated


Bug Fixing For Positive Reputation

fixed the bugs that are mentioned in https://github.com/forta-network/starter-kits/pull/318

deployed 0.0.11 to prod


Create Wait Function

Create Wait Function:
Start with wait for time function (modifier so make modal screen too!)
Then do wait for event function (blocks--like if)

wait for events to be figured out

look into using "+ (WWCommandSet *) moveStop;" (seen in WWCommandToolbelt.h)


Do not allow attaching to a non-running container

This is how the Docker CLI behaves. Attaching to a non-running container
hangs indefinitely. Fixes #288

cc @rgrunber

cc @rgrunber

This looks fine to me, so 👍 . I would only add that similar logic may need to be added in place for execCreate/execStart, but it'd be fine to do all that in a separate issue/pull request.

Thanks. I've updated the javadoc. I made a similar one for execCreate here https://github.com/spotify/docker-client/pull/574.


ci: merge opae-libs

Automated changes by create-pull-request GitHub action.
Must be use a normal merge (not squash-merge and not rebase-merge)

Coverage increased (+0.1%) to 67.405% when pulling 1d6cf951003baa640ec6d7ad601efe5dac49b012 on auto/update-libs into a1b9ae497e655bcada01870aac928558260e7d0f on master.


Implement first-pass dbt project and initial reports

After working with ClickHouse and Superset a bit it's obvious that we should implement our dbt models sooner rather than later to ease working with the OARS datasets, increase performance, improve data quality, etc. To get started we should implement the following:

Create a new dbt project in this repo
The sources for this pass should be the xAPI table that Ralph writes to and the coursegraph tables
Documented and tested models should exist for a downstream model that implements:

xapi_parsed_all, with the exception of also pulling up the object id to the top level
Children of xapi_parsed_all for each current "event type"- enrollment, video, problem, etc. that pull up to the top level any fields which are common to all events of that type (ex: problem id, attempts, or video id)

We should keep the following in mind while creating the structure

dbt best practices about project structure, testing, and being able to run in CI (in this repo for purposes of testing dbt changes)
dbt & tutor may allow us to configure different database backends such as Snowflake, so we should be careful and document ClickHouse specific code

Create a Tutor "do" command to run dbt that can take the various dbt command options and also respects any Tutor settings that change the defaults created above

There are a few painful things about using JSON in ClickHouse at this point, so it would be helpful to bring the object id up to the top level of xapi_events_all_parsed. If we need to parse out course keys and block ids we should do it once here as well. It will make everything downstream easier.

This is done!


Document the tlsEnabled configuration for legacy KoP versions

Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[x] doc
(If this PR contains doc changes)

For the broker, tlsEnabled is deprecated and not used to determine whether the broker exposes a TLS port.
For the client, see https://github.com/streamnative/kop/pull/1848


Catch and swallow no-node exceptions (#93)

Handle race condition between checking if a node exists, and removing the node.

@stanlemon backporting this to 0.9.x branch


PushNotificationsAPI : Failed to register device: NOKResponse(error=Something went wrong, description=Device could not be created)

Please fix this issue please...
for the PushNotificationsAPI giving us a pain where the error to be
### Failed to register device: NOKResponse(error=Something went wrong, description=Device could not be created)

This is a duplicate of https://github.com/pusher/push-notifications-android/issues/149

I'm also getting this error in console, notifications do not work on Android phone, i do not get one in message receive listener.
It start happening after i update sdk to 34 and android gradle plugin. Libraries updated as well.

I also have an issue PushNotificationsAPI    com.myfamilychannel.familyapp    W  Failed to register device: NOKResponse(error=Unauthorized, description=The device token provided could not be validated against any known credentials). IOS works just fine. android 34 as well.

Same here. It seems to be working in sdk < 34, but not in 34. The device is not receiving any push notifications. The thing is, this error is only visible in console, so it took a while when I found it.
Also the  PushNotifications.setUserId is not responding with a failure callback, nor a success - which seems to be related to the mentioned bug.

Is there any update on this issue ?

@deeborania can you please release a new version from main branch
I can see that issue is already fixed but need to release a new version

Any updates on this issue?

This has been an ongoing issue for almost three months, and the Pusher Beams team hasn’t released an update despite having fixed it. We’ve already migrated from Pusher Beams to WonderPush. It’s a great tool that is cheaper, offers many features, and has an almost 100% delivery rate. Their customer support is also excellent, and I highly recommend giving it a try.

There's a 1.10.0 on MVN released on Oct 2nd, but I cannot confirm the issue is fixed. Can anyone give it a try?
https://mvnrepository.com/artifact/com.pusher/push-notifications-android

This released 1.10 not working

Not working for me as well

I just migrated to Firebase and set everything up within an hour. There will be no more discussions with the Pusher team, which has no responsibility. Move on!
@IrynaDoroshenkoDev
@Atraxmaster

Hello everyone!
Ever since the deprecation of the Legacy FCM APIs, we have seen this issue with multiple clients. What helped us solve it was:

Downloading the latest google_services.json file from the android console for your app. Update this in the application directory of your android how to.

In the root level (project) build.gradle file use the following dependencies:

    id("com.google.gms.google-services") version "4.4.2" apply false

In the application (module) build.gradle file use the following dependencies:

    implementation("com.google.firebase:firebase-messaging:22.0.0")
    implementation("com.google.firebase:firebase-iid:21.1.0")
    implementation("com.pusher:push-notifications-android:1.9.2")

We have tested this with SDKs 33, 34, and 35 and for all the tests, we have successfully acquired an FCM token and received notifications.

I also have an issue PushNotificationsAPI Failed to register device: NOKResponse(error=Unauthorized, description=The device token provided could not be validated against any known credentials). IOS works just fine. Android with Pusher -doesn't work
build.gradle : // React Native Pusher Notifications implementation 'com.google.firebase:firebase-core:21.1.1' implementation 'com.google.firebase:firebase-messaging:22.0.0' implementation "com.google.firebase:firebase-iid:21.1.0" implementation 'com.pusher:push-notifications-android:1.9.2' implementation project(':react-native-pusher-push-notifications') testImplementation 'junit:junit:4.12'
classpath 'com.google.gms:google-services:4.4.2'
Android SDK=34
My Results:

I've registered the Pusher beam successfully with the correct key;
Registered a user successfully;
get it's ID successfully;
Subscribed on interests successfully;
I've got a token from the API for pusher - looks correct for the correct user and with exp in the 1 day (24h as in the tutorial);
6)FCM token works I tested it via Firebase console, and all pushes in all states work;
But I still see all the time an error: PushNotificationsAPI : Failed to register device: NOKResponse(error=Unauthorized, description=The device token provided could not be validated against any known credentials)

Hi @IrynaDoroshenkoDev, this react-native is a 3rd party implementation and is not maintained by us and as you see here, it's using older dependencies.

This is still not working, even on the latest versions. Getting this error every time and no push notifications. Failed to register device: NOKResponse(error=Something went wrong, description=Device could not be created)

Hey @jaime-gomez We can't reproduce the issue on our setup. Can you provide an example app with the dependencies you are using that we can use?

Hey @aonemd I have the same dependecies, also the the pusher java client 2.4.4 which we use to receive pusher events, that one is working fine and events are coming as espected, but when we add

@jaime-gomez That got fixed after this step,
Downloading the latest google_services.json file from the android console for your app. Update this in the application directory of your android how to.
Note : you have to update your local file as well as on beams.

Hi @aonemd I've uploaded again the google.services.json file again on the beams console, created a new dummy project with only this dependency and only start push notifications and still i'm getting the same error, and in the console the waiting for device button never ends indicating that the connection never took place. If you send me and email address I can send you the dummy project so you guys can check

Hey @jaime-gomez , could you send it to us on<EMAIL_ADDRESS>Thanks 🙏


nixos/switch-to-configuration: Proper unit file parser

Motivation for this change
This replaces the naive K=V unit parser with a proper INI parser from a
library and adds proper support for override files. Also adds a bunch of
comments about parsing, I hope this makes it easier to understand and
maintain in the future.
There are multiple reasons to do so, the first one is just general
correctness with is nice imo. But to get to more serious reasons (I
didn't put in all that effort for nothing) is that this is the first
step torwards more clever restart/reload handling. By using a library
like Data::Compare a future PR could replace the current way of
fingerprinting units (which is to compare store paths) by comparing the
hashes. This is more precise because units won't get restarted because
the order of the options change, comments are added, some dependency of
writeText changes, .... Also this allows us to add a feature like
X-Reload-Triggers so the unit can either be reloaded when these change
or restarted when everything else changes, giving module authors the
ability to have their services reloaded without having to fear that
updates are not applied because the service doesn't get restarted.
Another reason why this feature is nice is that now that the unit files
are parsed correctly (and values are just extracted from one section),
potential future rewrites can just rely on some INI library without
having to implement their own weird parser that is compatible with this
script.
This also comes with a new subroutine to handle systemd booleans because
I thought the current way of handling it was just ugly. This also allows
overriding values this script reads in an override file.
Apart from making this script more compatible with the world around it,
this also fixes two issues I saw bugging exactly 0 (zero) people. First
is that this script now supports multiple override files, also ones that
are not called override.conf and the second one is that 1 and on are
treated as bools by systemd but were previously not parsed as such by
switch-to-configuration.
Related to #49528.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

FAQ:
Q: Why is there no changelog
A: I will provide one when #150859 is merged and have one combined entry for both

About me removing the comment from parseKeyValues: This is actually correct when parsing the output of systemctl show and not parsing a unit file.
This does not matter however because I also plan on dropping that subroutine entirely and replacing it by systemctl show --value --property so we don't have to do the splitting ourselves and can just systemctl do it for us

A classic while writing the test: I found that the current behaviour that detects whether a unit is in auto-restart was broken. This is now fixed and slightly refactored (second commit) and a proper test case is added.


Feat/group selection UI tweaks

This PR has Discord groups selection UI tweaks #411
Added:

Repositioned the add role button towards top-left
Hover effect while hovering over the group list item and mouse pointer

Before:

After:

Hey @shubhamsigdar1, thank you for your review.
@ankushdharkar had assigned this issue to me and the design was given by him only.
Could you please merge it?

Hey @shubhamsigdar1, thank you for your review.
@ankushdharkar had assigned this issue to me and the design was given by him only.
Could you please merge it?

Reach out to @RitikJaiswal75 @prakashchoudhary07 @ankushdharkar


move topology struct and config items to types package

This PR moves the topology struct to types package and adds some  helper functions to make the nodes initialization more uniform.
Still a WIP.

the rest LGTM,
thank you for being able to get this properly structured 🙏


MT.1020: All Conditional Access policies are configured to exclude directory synchronization accounts or do not scope them should not match all CA policies

Regarding the test:

MT.1020: All Conditional Access policies are configured to exclude directory synchronization accounts or do not scope them.

It seems like it's matching any CA policy that has All cloud apps. However, there are several scenarios where I think we can Pass this test instead of Fail. For example, if you have a CA policy requiring all Guest users to MFA to All Cloud Apps - no need to exclude directory synchronization account then.
On way is to check only for the scenario when you have Include: All Users and Require multifactor authentication?

I think we should exclude CA policies that are for 'All guest users'.
We can't limit it to MFA only. What is someone adds the account to require compliant device. That could break the sync too.
@f-bader thoughts?

For guest only conditional access policies the exclusion is a great idea. Will change the function.


Add timestamps to Kafka messages

As a consumer of Holmes' Kafka messages I want to be able to determine the creation date of the message.
We want to enable this feature by adding timestamps to the Kafka messages using Kafka's new message format introduced in 0.10. The Sarama library now supports this new message format (https://github.com/Shopify/sarama/pull/678).

The timestamp is not set currently, since we must set the minimal Kafka version in the sarama config of our producer to 0.10.


Branch to Trigger logreg tests

/modeltest
include:
dataset_branch: "logreg"
 - dataset: ["financial-demo"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

/modeltest
include:
dataset_branch: "logreg"
 - dataset: ["financial-demo"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

/modeltest
dataset_branch: "logreg"
 - dataset: ["financial-demo"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

/modeltest
dataset_branch: "logreg"
include:
 - dataset: ["financial-demo"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

/modeltest
dataset_branch: "logreg"
include:
 - dataset: ["financial-demo", "Carbon Bot", "Sara"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

Adam pointed out on slack that it's a bit unfair not to include an entity extractor in the pipeline. So I'll re-run the experiments one more time but now with a CRFEntityExtractor in there.

/modeltest
dataset_branch: "logreg"
include:
 - dataset: ["financial-demo", "Carbon Bot", "Sara"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression"]

/modeltest
dataset_branch: "logreg"
include:
 - dataset: ["financial-demo", "Carbon Bot", "Sara", "Private 1", "Private 2", "Private 3"]
   config: ["Base DIET", "Base DIET no Transformer", "Logistic Regression", "Logistic Regression Dense"]

/modeltest
dataset_branch: "logreg"
include:
 - dataset: ["financial-demo", "Carbon Bot", "Sara", "Hermit"]
   config: ["Logistic Regression", "Logistic Regression Dense"]

Since we have the stats that we're interested in, we can close this PR.


Feature: Frontend - Implement Login and Signup UI

Develop the user interface for the Login and Signup functionality, with form validation and integration with the backend API for user registration and authentication.
Tasks:

Design a Signup form with fields: username, email, and password.
Design a Login form with fields: email/username and password.
Perform input validation (password strength, valid email, etc.).
Provide user feedback for successful or failed registration/login attempts.
Redirect users to the dashboard after successful login.
Ensure the UI is responsive and user-friendly.

Feature Requirements:

Integrate the forms with the backend API for user registration and authentication.
Store JWT tokens in local storage or cookies for session management after login.
Display error messages for invalid credentials or form errors.
Handle successful registration/login with redirection and session management.

Hey @manikumarreddyu I can work on it.

can you please let me know how much time do you need to complete this issue @harish08102004

hi @harish08102004 ..any updates..?


Devices not available "Timed out connecting to ... after 15 seconds."

Hi,
I have some Eglo Connect E27 bulbs (ESML-c9i, version 2.2.6 (HW 4.0)) that I'd love to connect to Home Assistant. I installed the latest beta of this integration to do that (1.3b3). The reason I'm using this beta version is the conflict with the latest HA (https://github.com/fsaris/home-assistant-awox/issues/59). Installation and login to my Awox account went well after switching to the beta.
But I can't get the Awox lights to connect. I'm not sure if the issue is related to the bluetooth dongle (TP-Link UB500 Nano), an issue in the integration, or something else.
Environment:
Home Assistant 2022.8.7.
Running in "container" mode on Debian 10.
The bluetooth controller seems to be available:
> docker-compose exec homeassistant bluetoothctl list
Controller E8:48:B8:C8:20:00 WHEATLEY [default]

The lights are quite close to the bluetooth dongle (the "corner lamp" is ~2.5m away).
Below, the logs from Home Assistant:
2022-09-16 01:07:19.884 DEBUG (SyncWorker_5) [custom_components.awox.awox_mesh] startup
2022-09-16 01:07:20.465 INFO (MainThread) [custom_components.awox.awox_mesh] Search for AwoX devices to find closest (best RSSI value) device
2022-09-16 01:07:21.566 INFO (MainThread) [custom_components.awox.scanner] Scanning 20 seconds for AwoX bluetooth mesh devices!
2022-09-16 01:07:41.744 INFO (SyncWorker_1) [custom_components.awox.bluetoothctl] found: {}
2022-09-16 01:07:41.744 DEBUG (MainThread) [custom_components.awox.scanner] Found devices: {}
2022-09-16 01:07:42.012 DEBUG (MainThread) [custom_components.awox.awox_mesh] Scan result: {}
2022-09-16 01:07:42.012 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:82:66:42][EGLO PLUG PLUS] Device NOT found during Bluetooth scan
2022-09-16 01:07:42.012 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:e7:07:58][Corner Lamp ] Device NOT found during Bluetooth scan
2022-09-16 01:07:42.012 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:90:69:da][Little Lampv2] Device NOT found during Bluetooth scan
2022-09-16 01:07:42.012 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:e6:29:5b][Lamp 1v2] Device NOT found during Bluetooth scan
2022-09-16 01:07:42.013 INFO (MainThread) [custom_components.awox.awox_mesh] async_update: Request status
2022-09-16 01:07:42.013 INFO (MainThread) [custom_components.awox.awox_mesh] Queue command requestStatus {'dest': 65535, 'withResponse': True}
2022-09-16 01:07:42.013 DEBUG (AwoxMeshCommands-Mze8RdZa) [custom_components.awox.awox_mesh] process 0/0 - {'command': 'requestStatus', 'params': {'dest': 65535, 'withResponse': True}, 'callback': <function AwoxMesh._async_add_command_to_queue.<locals>.command_executed at 0x7fba53485630>, 'allow_to_fail': False}
2022-09-16 01:07:42.015 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:82:66:42][EGLO PLUG PLUS] Trying to connect
2022-09-16 01:07:42.393 INFO (SyncWorker_1) [custom_components.awox.awoxmeshlight] Connecting to a4:c1:38:82:66:42 with timeout=15
2022-09-16 01:07:57.494 ERROR (SyncWorker_1) [custom_components.awox.awoxmeshlight] Timed out connecting to a4:c1:38:82:66:42 after 15 seconds.
2022-09-16 01:07:57.496 ERROR (MainThread) [custom_components.awox.awox_mesh] exception Timed out connecting to a4:c1:38:82:66:42 after 15 seconds.
Traceback (most recent call last):
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 101, in connect
with self._receiver.event("connect", timeout):
File "/usr/local/lib/python3.10/contextlib.py", line 142, in __exit__
next(self.gen)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 191, in event
self.wait(event, timeout)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 157, in wait
raise NotificationTimeout()
pygatt.exceptions.NotificationTimeout: None
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/awox/awox_mesh.py", line 324, in _async_connect_device
if await self.hass.async_add_executor_job(device.connect):
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 196, in connect
self.btdevice = self.adapter.connect(self.mac, timeout=15)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 108, in connect
raise NotConnectedError(message)
pygatt.exceptions.NotConnectedError: Timed out connecting to a4:c1:38:82:66:42 after 15 seconds.
2022-09-16 01:07:57.498 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:82:66:42][EGLO PLUG PLUS] Failed to connect, trying next device [Timed out connecting to a4:c1:38:82:66:42 after 15 seconds.]
2022-09-16 01:07:57.498 DEBUG (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:82:66:42][EGLO PLUG PLUS] Setting up Bluetooth connection failed, making sure Bluetooth device stops trying
2022-09-16 01:07:57.499 DEBUG (SyncWorker_4) [custom_components.awox.awoxmeshlight] force stopping ble adapter
2022-09-16 01:07:57.800 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:e7:07:58][Corner Lamp ] Trying to connect
2022-09-16 01:07:58.151 INFO (SyncWorker_0) [custom_components.awox.awoxmeshlight] Connecting to a4:c1:38:e7:07:58 with timeout=15
2022-09-16 01:08:02.014 ERROR (MainThread) [custom_components.awox.awox_mesh] Timeout fetching awox data
2022-09-16 01:08:02.016 DEBUG (MainThread) [custom_components.awox.awox_mesh] Finished fetching awox data in 41.551 seconds (success: False)
2022-09-16 01:08:13.252 ERROR (SyncWorker_0) [custom_components.awox.awoxmeshlight] Timed out connecting to a4:c1:38:e7:07:58 after 15 seconds.
2022-09-16 01:08:13.253 ERROR (MainThread) [custom_components.awox.awox_mesh] exception Timed out connecting to a4:c1:38:e7:07:58 after 15 seconds.
Traceback (most recent call last):
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 101, in connect
with self._receiver.event("connect", timeout):
File "/usr/local/lib/python3.10/contextlib.py", line 142, in __exit__
next(self.gen)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 191, in event
self.wait(event, timeout)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 157, in wait
raise NotificationTimeout()
pygatt.exceptions.NotificationTimeout: None
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/awox/awox_mesh.py", line 324, in _async_connect_device
if await self.hass.async_add_executor_job(device.connect):
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 196, in connect
self.btdevice = self.adapter.connect(self.mac, timeout=15)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 108, in connect
raise NotConnectedError(message)
pygatt.exceptions.NotConnectedError: Timed out connecting to a4:c1:38:e7:07:58 after 15 seconds.
2022-09-16 01:08:13.254 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:e7:07:58][Corner Lamp ] Failed to connect, trying next device [Timed out connecting to a4:c1:38:e7:07:58 after 15 seconds.]
2022-09-16 01:08:13.254 DEBUG (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:e7:07:58][Corner Lamp ] Setting up Bluetooth connection failed, making sure Bluetooth device stops trying
2022-09-16 01:08:13.254 DEBUG (SyncWorker_5) [custom_components.awox.awoxmeshlight] force stopping ble adapter

Your Bluetooth device isn't able to find the lights. Is your Bluetooth controller in reach of one of your lights?
Maybe you could test this also directly in the container by using the command hcitool lescan

Hi fsaris, thanks for the quick response! Although (at least one of) the lamps are quite close to the bluetooth adapter ( < 3 m), hcitool lescan gives no other output then LE Scan .... I also tried bluetoothctl scan on, which has the same result. So either  my bluetooth adapter is not (quite) working  yet. Or the devices are too far away.

Should the lamps be in a specific state? I.e. on or off? Or should they be reset or somehow set to "pairing" mode?

Should the lamps be in a specific state? I.e. on or off? Or should they be reset or somehow set to "pairing" mode?

Just make sure they have power. They should be initial paired with your awox account that's what the integration uses to get the needed credentials

I have the same issue.
Smartphone can connect without any issue (it is further away than my HA device).
Before upgrade to 2022.7 my HA device could always connect via bluetooth. Position (distance) has not changed since then.

@ZTHawk can you provide some debug logs?

Here is an extract. Two of my four devices. It is the same for the other two and then repeats.
2022-09-17 22:55:38.130 DEBUG (SyncWorker_4) [custom_components.awox.awox_mesh] startup
2022-09-17 22:55:38.163 INFO (MainThread) [custom_components.awox.awox_mesh] Search for AwoX devices to find closest (best RSSI value) device
2022-09-17 22:55:38.865 INFO (MainThread) [custom_components.awox.scanner] Scanning 20 seconds for AwoX bluetooth mesh devices!
2022-09-17 22:55:59.052 INFO (SyncWorker_7) [custom_components.awox.bluetoothctl] found: {}
2022-09-17 22:55:59.053 DEBUG (MainThread) [custom_components.awox.scanner] Found devices: {}
2022-09-17 22:55:59.227 WARNING (MainThread) [homeassistant.util.async_] Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for awox doing blocking calls at custom_components/awox/awox_mesh.py, line 346: devices = await DeviceScanner.async_find_devices(hass=self.hass, scan_timeout=20)
2022-09-17 22:55:59.335 DEBUG (MainThread) [custom_components.awox.awox_mesh] Scan result: {}
2022-09-17 22:55:59.336 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:b8:11:29][Lampe über Treppe] Device NOT found during Bluetooth scan
2022-09-17 22:55:59.336 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:2b:d6:b6][Lampe vor K2] Device NOT found during Bluetooth scan
2022-09-17 22:55:59.337 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:ce:52:6a][Lampe vor Bad] Device NOT found during Bluetooth scan
2022-09-17 22:55:59.337 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:64:7a:3e][Lampe vor E] Device NOT found during Bluetooth scan
2022-09-17 22:55:59.338 INFO (MainThread) [custom_components.awox.awox_mesh] async_update: Request status
2022-09-17 22:55:59.338 INFO (MainThread) [custom_components.awox.awox_mesh] Queue command requestStatus {'dest': 65535, 'withResponse': True}
2022-09-17 22:55:59.341 DEBUG (AwoxMeshCommands-ntOc9VHB) [custom_components.awox.awox_mesh] process 0/0 - {'command': 'requestStatus', 'params': {'dest': 65535, 'withResponse': True}, 'callback': <function AwoxMesh._async_add_command_to_queue.<locals>.command_executed at 0x7f6a27fd8430>, 'allow_to_fail': False}
2022-09-17 22:55:59.343 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:b8:11:29][Lampe über Treppe] Trying to connect
2022-09-17 22:55:59.761 INFO (SyncWorker_1) [custom_components.awox.awoxmeshlight] Connecting to a4:c1:38:b8:11:29 with timeout=15
2022-09-17 22:56:14.863 ERROR (SyncWorker_1) [custom_components.awox.awoxmeshlight] Timed out connecting to a4:c1:38:b8:11:29 after 15 seconds.
2022-09-17 22:56:14.869 ERROR (MainThread) [custom_components.awox.awox_mesh] exception Timed out connecting to a4:c1:38:b8:11:29 after 15 seconds.
Traceback (most recent call last):
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 101, in connect
with self._receiver.event("connect", timeout):
File "/usr/local/lib/python3.10/contextlib.py", line 142, in __exit__
next(self.gen)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 191, in event
self.wait(event, timeout)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 157, in wait
raise NotificationTimeout()
pygatt.exceptions.NotificationTimeout: None
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/awox/awox_mesh.py", line 324, in _async_connect_device
if await self.hass.async_add_executor_job(device.connect):
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 196, in connect
self.btdevice = self.adapter.connect(self.mac, timeout=15)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 108, in connect
raise NotConnectedError(message)
pygatt.exceptions.NotConnectedError: Timed out connecting to a4:c1:38:b8:11:29 after 15 seconds.
2022-09-17 22:56:14.873 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:b8:11:29][Lampe über Treppe] Failed to connect, trying next device [Timed out connecting to a4:c1:38:b8:11:29 after 15 seconds.]
2022-09-17 22:56:14.873 DEBUG (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:b8:11:29][Lampe über Treppe] Setting up Bluetooth connection failed, making sure Bluetooth device stops trying
2022-09-17 22:56:14.873 DEBUG (SyncWorker_7) [custom_components.awox.awoxmeshlight] force stopping ble adapter
2022-09-17 22:56:15.178 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:2b:d6:b6][Lampe vor K2] Trying to connect
2022-09-17 22:56:15.537 INFO (SyncWorker_0) [custom_components.awox.awoxmeshlight] Connecting to a4:c1:38:2b:d6:b6 with timeout=15
2022-09-17 22:56:19.338 ERROR (MainThread) [custom_components.awox.awox_mesh] Timeout fetching awox data
2022-09-17 22:56:19.344 DEBUG (MainThread) [custom_components.awox.awox_mesh] Finished fetching awox data in 41.181 seconds (success: False)
2022-09-17 22:56:30.648 ERROR (SyncWorker_0) [custom_components.awox.awoxmeshlight] Timed out connecting to a4:c1:38:2b:d6:b6 after 15 seconds.
2022-09-17 22:56:30.651 ERROR (MainThread) [custom_components.awox.awox_mesh] exception Timed out connecting to a4:c1:38:2b:d6:b6 after 15 seconds.
Traceback (most recent call last):
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 101, in connect
with self._receiver.event("connect", timeout):
File "/usr/local/lib/python3.10/contextlib.py", line 142, in __exit__
next(self.gen)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 191, in event
self.wait(event, timeout)
File "/usr/local/lib/python3.10/site-packages/pygatt/backends/gatttool/gatttool.py", line 157, in wait
raise NotificationTimeout()
pygatt.exceptions.NotificationTimeout: None
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/config/custom_components/awox/awox_mesh.py", line 324, in _async_connect_device
if await self.hass.async_add_executor_job(device.connect):
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 196, in connect
self.btdevice = self.adapter.connect(self.mac, timeout=15)
File "/config/custom_components/awox/awoxmeshlight/__init__.py", line 108, in connect
raise NotConnectedError(message)
pygatt.exceptions.NotConnectedError: Timed out connecting to a4:c1:38:2b:d6:b6 after 15 seconds.
2022-09-17 22:56:30.654 INFO (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:2b:d6:b6][Lampe vor K2] Failed to connect, trying next device [Timed out connecting to a4:c1:38:2b:d6:b6 after 15 seconds.]
2022-09-17 22:56:30.655 DEBUG (MainThread) [custom_components.awox.awox_mesh] [a4:c1:38:2b:d6:b6][Lampe vor K2] Setting up Bluetooth connection failed, making sure Bluetooth device stops trying
2022-09-17 22:56:30.655 DEBUG (SyncWorker_6) [custom_components.awox.awoxmeshlight] force stopping ble adapter

@ZTHawk strange the Bluetooth scan doesn't find any device to connect. Do you have the HA Bluetooth integration enabled? Maybe that is claiming the Bluetooth controller

End try to do a BLE scan directly on your host to check if it can find some Bluetooth devices just to be sure nothing else broke after upgrade of HA.
Run hcitool lescan or bluetoothctl and then scan on

For testing purposes, i put one of the lamps right next to the bluetooth adapter (as shown in the picture). But still the adapter can't seem to find it (this time directly from the host, not inside the container):
> /opt/pihole# hcitool lescan
Enable scan failed: Input/output error
 > /opt/pihole# bluetoothctl
Agent registered
[CHG] Controller E8:48:B8:C8:20:00 Pairable: yes
[bluetooth]# scan on
Discovery started
[CHG] Controller E8:48:B8:C8:20:00 Discovering: yes
[bluetooth]#

But nothing is found. I even put my soundbar in "pairing mode" to see if it would show up but it didn't. So I'm thinking something is up with the bluetooth adapter itself, or the awox plugin is claiming it so my direct commands don't work.

It seems that my bluetooth adapter is not working.
Bluetooth: hci0: command 0xfc01 tx timeout
Bluetooth: hci0: FW download error recovery failed (-110)

HA is running in a virtual machine (virtualbox). But the bluetooth adapter was running before HA changed the bluetooth driver.
Host system does recognize the bluetooth adapter and scanning is working fine.

Sorry can't help with that. I have it running in docker supervised


Feat add end reward method

Description
closes #61
Must be merged after the merging of #68 into the main.

Looks like continuous integration (for the liquidity-rewards/ smart contracts) on this branch did not trigger?

@hhio618 Could you take a look at the merge conflicts?


Add GitHub action to run unit tests with every PR.

I opted not to Dockerize this, in contrast to what's been done in note-arduino. The build already runs in a GitHub-provisioned VM, so the addition of a container inside that seems like overkill.
Zak and I talked, and I decided to go the Docker/container route in the end, for a few reasons:

No hidden dependencies. For example, the GitHub VMs come with CMake installed, among other packages we need. With the Dockerfile, we fully enumerate our dependencies, so nothing is implied or hidden.
Easier for developers to run the GitHub action locally. This is mainly due to 1: the container will set up whatever dependencies it needs; we don't need to install anything up front.
Easier to migrate to a different CI platform if we ever outgrow GitHub actions.

One key downside is that, for the moment, we're building the Docker image anew on every CI run. When we eventually get set up with a container registry (e.g. Github's container registry), this problem will go away, as we'll be able to pull down images from the registry.

Not wanting to add more to the scope, but how about adding code coverage reporting to Coveralls? You can probably borrow from the existing implementation in note-arduino, recast as CMake scripts.


Company Query Should Return 400 Bad Data

Summary
Company Query Should Return 400 Bad Data
Background
In production, the following API response was observed in the CloudWatch logs:
Some of the 500 status error on Prod.
Field	Value
@ingestionTime
1629403795293
@log
716487311010:api-gw_service
@logStream
api-gw/web/02cb712b48654a7baee17eef153b8c20
@message
AccessLog - cla-service 68b063c0-0129-11ec-b4eb-4b6f349d8665 <IP_ADDRESS> - GET "/v4/company/name/undefined" - sc-500 1657
@timestamp
1629403792032

Expected behavior

Invalid or malformed data should return a 400 bad request

Screenshots
N/A
Environment
Please complete the following information:

Environment:

[ ] ALL
[ ] DEV
[ ] STAGING
[x] PROD

Browser:

[ ] Chrome/Brave
[ ] Firefox
[ ] Opera
[ ] Vivaldi
[ ] LibreWolf
[ ] SRware Iron
[ ] Dissenter
[ ] Slimjet
[ ] Midori
[ ] Edge
[ ] Lynx

Version: v1.0.XX

Additional Context
Reported by Onkar Kathane
Acceptance Criteria
The "done" criteria when this feature or problem is resolved. Such as:

Unit Tests added and running in CI
Functional Tests updated to cover feature, if applicable
Demonstrate the set of capabilities to the product team while the code is running in the STAGING environment.

References

Provide any code or specification references that would be helpful for the developer implementing this feature.

Closing issue due to inactivity.


Unexpected EOF

Build 'ubuntu-server.proxmox.ubuntu-server-focal' errored after 375 milliseconds 936 microseconds: unexpected EOF

I get this error every time I try to build packer. I believe I have my configuration setup correctly as I had to fix some errors earlier.

I don't have self-signed certificates and I needed to uncomment the line "insecure_skip_tls_verify = true" in the /boilerplates/packer/proxmox/ubuntu-server-focal/ubuntu-server-focal.pkr.hcl file


Update redirected and deprecated resources

Cops under rubocop-rspec moved to the main project.
rubocop-cask has been deprecated and merged into Homebrew.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[ ] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


How to connect to BigQuery ?

The following steps make the connection to big query possible:

install atoti-sql
download the jdbc driver from https://cloud.google.com/bigquery/docs/reference/odbc-jdbc-drivers
extract JDBC driver jars on your computer
Code for a public database :

import atoti as tt
import glob

session = tt.create_session(config={"extra_jars": [item for item in glob.glob("./extra_jar/*.jar")]})

table = session.read_sql(
    "jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;ProjectId=PROJECT_ID;OAuthType=0;OAuthServiceAcctEmail= EMAIL_OF_SERVICEACCOUNT(Bigquery user is enough rights);OAuthPvtKeyPath=path/to/json/keys;",
    """
    SELECT
      term,
      ARRAY_AGG(STRUCT(rank,week) ORDER BY week DESC LIMIT 1) x
    FROM
        `bigquery-public-data.google_trends.top_terms`
    WHERE
        refresh_date =
            (SELECT
                MAX(refresh_date)
            FROM
            `bigquery-public-data.google_trends.top_terms`
            )
    GROUP BY
        term
    ORDER BY
        (SELECT rank FROM UNNEST(x))
    """,
    username="",
    password="",
    table_name="BigQueryTable",
    driver="com.simba.googlebigquery.jdbc42.Driver"
)

In atoti 5.5.5
import atoti as tt
import glob

config = tt.create_config(extra_jars=[item for item in glob.glob("./extra_jar/*.jar")])
session = tt.create_session(config=config)

table = session.read_sql(
    "jdbc:bigquery://https://www.googleapis.com/bigquery/v2:443;ProjectId=PROJECT_ID;OAuthType=0;OAuthServiceAcctEmail= EMAIL_OF_SERVICEACCOUNT(Bigquery user is enough rights);OAuthPvtKeyPath=path/to/json/keys;",
    """
    SELECT
      term,
      ARRAY_AGG(STRUCT(rank,week) ORDER BY week DESC LIMIT 1) x
    FROM
        `bigquery-public-data.google_trends.top_terms`
    WHERE
        refresh_date =
            (SELECT
                MAX(refresh_date)
            FROM
            `bigquery-public-data.google_trends.top_terms`
            )
    GROUP BY
        term
    ORDER BY
        (SELECT rank FROM UNNEST(x))
    """,
    username="",
    password="",
    table_name="BigQueryTable",
    driver="com.simba.googlebigquery.jdbc42.Driver"
)


'No "exports" main resolved' running build inside WSL 2

Current Behavior

Expected behavior
It should finish the build successfully.
Suggested solution(s)
I am not sure if it doesn't boil down to some issue in Babel, would like to know your opinion before escalating it.
Additional context
The WSL 2 is the latest Windows Subsystem for Linux. So far it worked pretty well for all tasks, this is the first bummer. Running build directly on Windows works without an issue, so that's some potential culprit here. Unless it's a problem of Ubuntu (or any *nix system). I can't verify that.
I tried to reproduce the issue in some minimal environment, but no luck so far. The same is happening when building either mobx-react or mobx-react-lite packages. You can clone those and try npm run build, but I don't suppose anyone here has access to Ubuntu or Windows :)
Your environment

Software
Version(s)

TSDX
0.13.2

TypeScript
3.7.5

Yarn
1.22.4

Node
14.4.0

Operating System
Ubuntu 20.4 (in WSL2)

Duplicate of #630

I am not sure if it doesn't boil down to some issue in Babel, would like to know your opinion before escalating it.

The error isn't coming from TSDX, so I would say that would be a better place to start. Per the issue this duplicates, it is upstream in Babel and actually upstream in Node.
You wrote that you're on Node 14.4 which is confusing as the issue should be limited to Node 13.1-13.8, but #747 and its upstream issues point to a potential regression in Node.

but I don't suppose anyone here has access to Ubuntu or Windows

Not readily, but the test suite runs in a matrix which includes both Ubuntu and Windows:
https://github.com/formium/tsdx/blob/5e5c3f804e68609083be978a080ab905dc7ec19d/.github/workflows/nodejs.yml#L32

Thanks @agilgur5, that's really interesting. It's true that on WIndows machine itself I have Node 10.20.1, so that would be probably a reason why it works there.
At least on Ubuntu I can use NVM. Upon switching to 12.16.3 it works as well, but 12.17.0 is where it got broken apparently. So I am fine with a solution like that.


Document that the GTK bindings can't be completely safe and document the caveats

Main known issue is related to disposed but not finalized widgets, which would happen when e.g. their surrounding window is closed. Calling anything on such widgets might crash or do whatever, and this is design constraint in GTK.
See https://gitlab.gnome.org/GNOME/gtk/-/issues/3711 for details.
This also effects GTK4, but probably nothing apart from GTK as it's AFAIK the only library calling g_object_run_dispose() explicitly at specific times. It might also affect other GObject libraries if used together with a GC'd language binding in the same process but it's not entirely clear if the problems actually happen there in practice.
CC @bilelmoussaoui

More specifically, this only applies to widgets and not other GTK objects.

To be honest, this should probably be part of the gtk-rs book, it is a better place to write about this then in the documentations.

@Hofer-Julian What do you think?

Yeah, the book is probably a good place for that. In a supplementary chapter at the end or so.

Let us move this to gtk4-rs then


improve UI

[x] https://thenounproject.com, probably for Checkbox and Radio
[ ] add position and top left right bottom to Box. Should be probably multiples of sizes as padding and margin.
[ ] PR for getFelaMountNode
[ ] Rework React Native styles
[ ] add accessibility https://github.com/necolas/react-native-web/blob/master/docs/guides/accessibility.md and https://github.com/necolas/react-native-web/blob/master/src/modules/createDOMElement/index.js
[ ] media queries https://github.com/styled-components/styled-components/issues/256#issuecomment-265126210
[ ] port more components from rebass and bootstrap
[ ] print style

This is nice https://css-tricks.com/fun-line-height
repeating-linear-gradient should work in React Native as well https://github.com/react-native-community/react-native-linear-gradient

Ok, React Native style props order doesn't matter.
<View marginVertical={10} margin={30}> is the same as <View margin={30} marginVertical={10}>
We should enforce the same behaviour.


OTP not working when there is a Federated IDP login option

When a user is forced to change a password giving an OTP and if the application has a Federated IDP login option as well, using basic login with the OTP gives an error.
Tested in IS 5.3.0
Steps to reproduce,

Enable admin services and start the pack(doc link)
Create a user
Make the One Time Password claim supported by default.
Create a fIDP (no need actual values as this will not be used).
Create a SP and add an ouath app.
For the created SP in Advanced Authentication Configuration add basic local authenticator and the created fIDP as a federated authenticator for step 1
Perform a force password reset for the user(doc link)
Try to login to the created app with the OTP, the login will fail.

Resolved with https://github.com/wso2-support/carbon-identity-framework/pull/451
https://github.com/wso2/carbon-identity-framework/pull/2030


chore: update create-release-pr job

This PR updates the release pipeline so it works (please work 🙏).
Solving issue
Fixes: CDEP-2970
How to test
Not really possible to test.
Maybe just read through the files and check if something looks off to you.
Additional context
Our last release with these workflows failed miserably - hence the update.

@theJohnnyMe Also activated prettier for the workflow files to future proof it.


aws installing parsl dev branch fails to communicate with worker node

Pip installing parsl from a local cloned repo, or from pip install git+... doesn't seem to work, and results in an interchange exchange error (see logs below)
Replicate
Setup
$conda create --name parsl_py368 python=3.6
$conda activate parsl_py368
$python --version
Python 3.6.8 :: Anaconda, Inc.
$pip install git+https://github.com/Parsl/parsl.git
$python -c "import parsl; print(parsl.__version__)"
0.8.0
$pip install boto3

used ami with packages already installed, see issue #1094 - image is public
import parsl
from parsl.config import Config
from parsl.executors import HighThroughputExecutor
from parsl.providers import AWSProvider
from parsl.app.app import python_app

parsl.set_stream_logger()

parsl_config = Config(
  executors=[
    HighThroughputExecutor(
      label='htex_local',
      worker_debug=True,
      address=myip,
      cores_per_worker=1,
      max_workers=1,
      provider=AWSProvider(
        image_id='ami-078018a195b149801', # image with packages already installed
        instance_type='t2.micro',
        nodes_per_block=1,
        init_blocks=1,
        max_blocks=1,
        min_blocks=0,
        region='us-east-2',
        key_name='myKeyPair',
        state_file='awsproviderstate.json',
        linger=True
      ),
    )
  ],
  strategy=None,
)

parsl.load(parsl_config)

@python_app
def hello ():
  return 'Hello World!'

print(hello().result())

Logs
parsl.log
2019-06-25 18:11:02.889 parsl.dataflow.dflow:80 [DEBUG]  Starting DataFlowKernel with config
Config(
    app_cache=True,
    checkpoint_files=None,
    checkpoint_mode=None,
    checkpoint_period=None,
    data_management_max_threads=10,
    executors=[HighThroughputExecutor(
        address='<IP_ADDRESS>',
        cores_per_worker=1,
        heartbeat_period=30,
        heartbeat_threshold=120,
        interchange_port_range=(55000, 56000),
        label='htex_local',
        launch_cmd='process_worker_pool.py {debug} {max_workers} -p {prefetch_capacity} -c {cores_per_worker} -m {mem_per_worker} --poll {poll_period} --task_url={task_url} --result_url={result_url} --logdir={logdir} --block_id={{block_id}} --hb_period={heartbeat_period} --hb_threshold={heartbeat_threshold} ',
        managed=True,
        max_workers=1,
        mem_per_worker=None,
        poll_period=10,
        prefetch_capacity=0,
        provider=AWSProvider(
            'ami-078018a195b149801',
            iam_instance_profile_arn='',
            init_blocks=1,
            instance_type='t2.micro',
            key_file=None,
            key_name='testKeyPair',
            launcher=SingleNodeLauncher(),
            linger=True,
            max_blocks=1,
            min_blocks=0,
            nodes_per_block=1,
            parallelism=1,
            profile=None,
            region='us-east-2',
            spot_max_bid=0,
            state_file='awsproviderstate.json',
            walltime='01:00:00',
            worker_init=''
        ),
        storage_access=[],
        suppress_failure=False,
        worker_debug=True,
        worker_logdir_root=None,
        worker_port_range=(54000, 55000),
        worker_ports=None,
        working_dir=None
    )],
    lazy_errors=True,
    monitoring=None,
    retries=0,
    run_dir='runinfo',
    strategy=None,
    usage_tracking=False
)
2019-06-25 18:11:02.891 parsl.dataflow.dflow:81 [INFO]  Parsl version: 0.8.0
2019-06-25 18:11:02.891 parsl.dataflow.usage_tracking.usage:126 [DEBUG]  Tracking status: False
2019-06-25 18:11:02.891 parsl.dataflow.usage_tracking.usage:127 [DEBUG]  Testing mode   : False
2019-06-25 18:11:02.891 parsl.dataflow.dflow:103 [INFO]  Run id is: d383b22b-0861-4b5d-88b4-3fc51b17b870
2019-06-25 18:11:02.995 parsl.dataflow.memoization:52 [INFO]  App caching initialized
2019-06-25 18:11:02.996 parsl.executors.high_throughput.executor:430 [DEBUG]  Starting queue management thread
2019-06-25 18:11:02.997 parsl.executors.high_throughput.executor:307 [DEBUG]  [MTHREAD] queue management worker starting
2019-06-25 18:11:02.997 parsl.executors.high_throughput.executor:434 [DEBUG]  Started queue management thread
2019-06-25 18:11:03.007 parsl.executors.high_throughput.executor:266 [DEBUG]  Created management thread: <Thread(Thread-1, started daemon<PHONE_NUMBER>56576)>
2019-06-25 18:11:03.007 parsl.executors.high_throughput.executor:240 [DEBUG]  Launch command: process_worker_pool.py --debug --max_workers=1 -p 0 -c 1 -m None --poll 10 --task_url=tcp://<IP_ADDRESS>:54221 --result_url=tcp://<IP_ADDRESS>:54573 --logdir=/home/ubuntu/runinfo/016/htex_local --block_id={block_id} --hb_period=30 --hb_threshold=120
2019-06-25 18:11:03.007 parsl.executors.high_throughput.executor:243 [DEBUG]  Starting HighThroughputExecutor with provider:
AWSProvider(
    'ami-078018a195b149801',
    iam_instance_profile_arn='',
    init_blocks=1,
    instance_type='t2.micro',
    key_file=None,
    key_name='testKeyPair',
    launcher=SingleNodeLauncher(),
    linger=True,
    max_blocks=1,
    min_blocks=0,
    nodes_per_block=1,
    parallelism=1,
    profile=None,
    region='us-east-2',
    spot_max_bid=0,
    state_file='awsproviderstate.json',
    walltime='01:00:00',
    worker_init=''
)
2019-06-25 18:11:04.051 parsl.providers.aws.aws:500 [INFO]  Started up 1 instance i-0b9163994b922b477 . Instance type:t2.micro
2019-06-25 18:11:04.052 parsl.providers.aws.aws:598 [DEBUG]  Started instance_id: i-0b9163994b922b477
2019-06-25 18:11:04.052 parsl.executors.high_throughput.executor:547 [DEBUG]  Launched block 0->i-0b9163994b922b477
2019-06-25 18:11:04.052 parsl.dataflow.strategy:125 [DEBUG]  Scaling strategy: None
2019-06-25 18:11:04.054 parsl.dataflow.dflow:687 [INFO]  Task 0 submitted for App hello, waiting on tasks []
2019-06-25 18:11:04.054 parsl.dataflow.dflow:697 [DEBUG]  Task 0 set to pending state with AppFuture: <AppFuture super=<AppFuture at 0x7f5e3ebe9898 state=pending> parent=None>
2019-06-25 18:11:04.054 parsl.executors.high_throughput.executor:514 [DEBUG]  Pushing function <function hello at 0x7f5e3a9e16a8> to queue with args ()
2019-06-25 18:11:04.112 parsl.dataflow.dflow:463 [INFO]  Task 0 launched on executor htex_local
2019-06-25 18:13:03.622 parsl.executors.high_throughput.executor:345 [WARNING]  Executor shutting down due to exception from interchange
2019-06-25 18:13:03.622 parsl.executors.high_throughput.executor:347 [ERROR]  Exception: Manager b'314849c805b4' attempted to register with a bad registration message. Caused a critical failure
NoneType: None
2019-06-25 18:13:03.622 parsl.dataflow.dflow:250 [ERROR]  Task 0 failed
Traceback (most recent call last):
  File "/home/ubuntu/miniconda3/envs/parsl_py368/lib/python3.6/site-packages/parsl/dataflow/dflow.py", line 245, in handle_exec_update
    res = future.result()
  File "/home/ubuntu/miniconda3/envs/parsl_py368/lib/python3.6/concurrent/futures/_base.py", line 425, in result
    return self.__get_result()
  File "/home/ubuntu/miniconda3/envs/parsl_py368/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
parsl.executors.high_throughput.interchange.BadRegistration: Manager b'314849c805b4' attempted to register with a bad registration message. Caused a critical failure
2019-06-25 18:13:03.623 parsl.dataflow.dflow:271 [INFO]  Task 0 failed after 0 retry attempts
2019-06-25 18:13:03.623 parsl.executors.high_throughput.executor:384 [INFO]  [MTHREAD] queue management worker finished
2019-06-25 18:13:03.625 parsl.dataflow.dflow:822 [INFO]  DFK cleanup initiated
2019-06-25 18:13:03.626 parsl.dataflow.dflow:733 [INFO]  Summary of tasks in DFK:
2019-06-25 18:13:03.626 parsl.dataflow.dflow:764 [INFO]  Tasks in state States.failed: 0
2019-06-25 18:13:03.626 parsl.dataflow.dflow:771 [INFO]  End of summary
2019-06-25 18:13:03.626 parsl.dataflow.dflow:846 [INFO]  Terminating flow_control and strategy threads
2019-06-25 18:13:03.627 parsl.providers.aws.aws:625 [DEBUG]  Ignoring cancel requests due to linger mode
2019-06-25 18:13:03.627 parsl.executors.high_throughput.executor:618 [INFO]  Attempting HighThroughputExecutor shutdown
2019-06-25 18:13:03.627 parsl.executors.high_throughput.executor:622 [INFO]  Finished HighThroughputExecutor shutdown attempt
2019-06-25 18:13:03.627 parsl.data_provider.data_manager:98 [DEBUG]  Done with executor shutdown
2019-06-25 18:13:03.627 parsl.dataflow.dflow:878 [INFO]  DFK cleanup complete

interchange.log
2019-06-25 18:11:03.003 interchange:138 [DEBUG]  Initializing Interchange process
2019-06-25 18:11:03.003 interchange:146 [INFO]  Attempting connection to client at <IP_ADDRESS> on ports: 55225,55991,55561
2019-06-25 18:11:03.004 interchange:159 [INFO]  Connected to client
2019-06-25 18:11:03.004 interchange:187 [INFO]  Bound to ports 54221,54573 for incoming worker connections
2019-06-25 18:11:03.004 interchange:201 [INFO]  Platform info: {'parsl_v': '0.8.0', 'python_v': '3.6.8', 'os': 'Linux', 'hostname': 'ip-172-31-25-66', 'dir': '/home/ubuntu'}
2019-06-25 18:11:03.006 interchange:319 [INFO]  Incoming ports bound
2019-06-25 18:11:03.013 interchange:236 [INFO]  [TASK_PULL_THREAD] Starting
2019-06-25 18:11:03.013 interchange:260 [DEBUG]  [COMMAND] Command Server Starting
2019-06-25 18:11:03.024 interchange:246 [DEBUG]  [TASK_PULL_THREAD] 0 tasks in internal queue
2019-06-25 18:11:03.025 interchange:427 [DEBUG]  Managers count (total/interesting): 0/0
2019-06-25 18:11:03.025 interchange:460 [DEBUG]  [MAIN] either no interesting managers or no tasks, so skipping manager pass
2019-06-25 18:11:03.034 interchange:246 [DEBUG]  [TASK_PULL_THREAD] 0 tasks in internal queue
2019-06-25 18:11:03.035 interchange:427 [DEBUG]  Managers count (total/interesting): 0/0
2019-06-25 18:11:03.035 interchange:460 [DEBUG]  [MAIN] either no interesting managers or no tasks, so skipping manager pass
2019-06-25 18:11:03.045 interchange:246 [DEBUG]  [TASK_PULL_THREAD] 0 tasks in internal queue
2019-06-25 18:11:03.045 interchange:427 [DEBUG]  Managers count (total/interesting): 0/0

<skipping repeated messages>

2019-06-25 18:13:03.555 interchange:460 [DEBUG]  [MAIN] either no interesting managers or no tasks, so skipping manager pass
2019-06-25 18:13:03.561 interchange:246 [DEBUG]  [TASK_PULL_THREAD] 1 tasks in internal queue
2019-06-25 18:13:03.566 interchange:427 [DEBUG]  Managers count (total/interesting): 0/0
2019-06-25 18:13:03.566 interchange:460 [DEBUG]  [MAIN] either no interesting managers or no tasks, so skipping manager pass
2019-06-25 18:13:03.567 interchange:352 [DEBUG]  [MAIN] starting task_outgoing section
2019-06-25 18:13:03.568 interchange:365 [WARNING]  [MAIN] Got a non-json registration message from manager:b'314849c805b4'
2019-06-25 18:13:03.568 interchange:366 [DEBUG]  [MAIN] Message :
b'314849c805b4'

2019-06-25 18:13:03.575 interchange:246 [DEBUG]  [TASK_PULL_THREAD] 1 tasks in internal queue
2019-06-25 18:13:03.626 interchange:264 [DEBUG]  [COMMAND] Received command request: MANAGERS
2019-06-25 18:13:03.627 interchange:304 [DEBUG]  [COMMAND] Reply: [{'manager': '314849c805b4', 'block_id': None, 'worker_count': 0, 'tasks': 0, 'active': True}]

on worker node
manager.log
2019-06-25 18:13:03.556 parsl:524 Rank:0 [INFO]  Python version: 3.6.8 (default, Jan 14 2019, 11:02:34)
[GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]
2019-06-25 18:13:03.556 parsl:525 Rank:0 [INFO]  Debug logging: True
2019-06-25 18:13:03.556 parsl:526 Rank:0 [INFO]  Log dir: /home/ubuntu/runinfo/016/htex_local
2019-06-25 18:13:03.556 parsl:527 Rank:0 [INFO]  Manager ID: 314849c805b4
2019-06-25 18:13:03.556 parsl:528 Rank:0 [INFO]  Block ID: 0
2019-06-25 18:13:03.556 parsl:529 Rank:0 [INFO]  cores_per_worker: 1
2019-06-25 18:13:03.556 parsl:530 Rank:0 [INFO]  mem_per_worker: None
2019-06-25 18:13:03.556 parsl:531 Rank:0 [INFO]  task_url: tcp://<IP_ADDRESS>:54221
2019-06-25 18:13:03.556 parsl:532 Rank:0 [INFO]  result_url: tcp://<IP_ADDRESS>:54573
2019-06-25 18:13:03.556 parsl:533 Rank:0 [INFO]  max_workers: 1
2019-06-25 18:13:03.556 parsl:534 Rank:0 [INFO]  poll_period: 10
2019-06-25 18:13:03.556 parsl:535 Rank:0 [INFO]  Prefetch capacity: 0
2019-06-25 18:13:03.556 parsl:107 Rank:0 [INFO]  Manager started
2019-06-25 18:13:03.559 parsl:121 Rank:0 [INFO]  Manager connected
2019-06-25 18:13:03.560 parsl:140 Rank:0 [INFO]  Manager will spawn 1 workers
2019-06-25 18:13:03.565 parsl:314 Rank:0 [DEBUG]  Manager synced with workers
2019-06-25 18:13:03.567 parsl:188 Rank:0 [INFO]  [TASK PULL THREAD] starting
2019-06-25 18:13:03.567 parsl:194 Rank:0 [DEBUG]  Sending registration message: b'{"parsl_v": "0.8.0", "python_v": "3.6.8", "worker_count": 1, "block_id": "0", "prefetch_capacity": 0, "max_capacity": 1, "os": "Linux", "hname": "ip-10-0-15-190", "dir": "/root"}'
2019-06-25 18:13:03.568 parsl:207 Rank:0 [DEBUG]  [TASK_PULL_THREAD] ready workers:1, pending tasks:0
2019-06-25 18:13:03.568 parsl:214 Rank:0 [DEBUG]  [TASK_PULL_THREAD] Requesting tasks: 1
2019-06-25 18:13:03.568 parsl:268 Rank:0 [DEBUG]  [RESULT_PUSH_THREAD] Starting thread
2019-06-25 18:13:03.568 parsl:323 Rank:0 [INFO]  Loop start
2019-06-25 18:13:03.568 parsl:271 Rank:0 [DEBUG]  [RESULT_PUSH_THREAD] push poll period: 0.01
2019-06-25 18:13:03.578 parsl:245 Rank:0 [DEBUG]  [TASK_PULL_THREAD] No incoming tasks
2019-06-25 18:13:03.578 parsl:207 Rank:0 [DEBUG]  [TASK_PULL_THREAD] ready workers:1, pending tasks:0
2019-06-25 18:13:03.578 parsl:214 Rank:0 [DEBUG]  [TASK_PULL_THREAD] Requesting tasks: 1

<skipping repeated messages>

2019-06-25 18:14:44.548 parsl:207 Rank:0 [DEBUG]  [TASK_PULL_THREAD] ready workers:1, pending tasks:0
2019-06-25 18:14:44.548 parsl:177 Rank:0 [DEBUG]  Return from heartbeat: None
2019-06-25 18:14:44.548 parsl:214 Rank:0 [DEBUG]  [TASK_PULL_THREAD] Requesting tasks: 1
2019-06-25 18:15:14.549 parsl:245 Rank:0 [DEBUG]  [TASK_PULL_THREAD] No incoming tasks
2019-06-25 18:15:14.550 parsl:254 Rank:0 [CRITICAL]  [TASK_PULL_THREAD] Missing contact with interchange beyond heartbeat_threshold
2019-06-25 18:15:14.550 parsl:256 Rank:0 [CRITICAL]  [TASK_PULL_THREAD] Exiting
2019-06-25 18:15:14.551 parsl:328 Rank:0 [CRITICAL]  [MAIN] Received kill event, terminating worker processes
2019-06-25 18:15:14.560 parsl:293 Rank:0 [CRITICAL]  [RESULT_PUSH_THREAD] Exiting
2019-06-25 18:15:14.560 parsl:335 Rank:0 [CRITICAL]  Terminating worker <Process(Process-1, started)>:True
2019-06-25 18:15:14.562 parsl:337 Rank:0 [DEBUG]  Worker:<Process(Process-1, stopped[SIGTERM])> joined successfully
2019-06-25 18:15:14.563 parsl:343 Rank:0 [INFO]  process_worker_pool ran for<PHONE_NUMBER>8510437 seconds
2019-06-25 18:15:14.563 parsl:555 Rank:0 [INFO]  process_worker_pool exiting

worker_0.log
2019-06-25 18:13:03.567 worker_log:399 Rank:0 [INFO]  Worker 0 started
2019-06-25 18:13:03.567 worker_log:401 Rank:0 [DEBUG]  Debug logging enabled

False alert - I needed to also edit the aws template.py to install from git as well. Things work as intended and this issue should be ignored.


Added new kafka backend

Made metric agent by configurable as usual django configs.

Codecov Report

Merging #36 into master will decrease coverage by 4.92%.
The diff coverage is 85.22%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage     100%   95.07%   -4.93%
==========================================
  Files           6        8       +2
  Lines         180      264      +84
==========================================
+ Hits          180      251      +71
- Misses          0       13      +13

Impacted Files
Coverage Δ

time_execution/backends/threaded.py
100% <100%> (ø)
:arrow_up:

time_execution/backends/kafka.py
100% <100%> (ø)

time_execution/decorator.py
100% <100%> (ø)
:arrow_up:

time_execution/backends/base.py
80% <50%> (-20%)
:arrow_down:

time_execution/serializer.py
57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993b046...0b0757f. Read the comment docs.


Use Python logger for logging

Partially for this issue #31

@andyndang @ibackus is it stale or should I should I make the change in the review ?

@lalmei the specific changes here may be stale (not sure), but the general feedback should be applied for python logging, i.e:

Use the logger
don't configure the logger at import (we can use a convenience function if we want)
initialize loggers within function calls, not at the module level
Use warnings as follows:

warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning
logging.warning() if there is nothing the client application can do about the situation, but the event should still be noted

I'll cancel this one! @lalmei


NTR: decreased transport along microtubule

To mirror
https://github.com/geneontology/go-ontology/issues/12521

decreased transport along microtubule FYPO:0005526

edit file: 2c1f3954eb41e1e924972274fa79f9dca97f499c
release: 8122bc163911279170474760863ce139a3bbd738


[FEATURE] Make it possible to render vertical slider

It would be good to have some option to define if we want to render horizontal or vertical slider.

Indeed this would be a great feature. However, this is pretty complicated do implement it with the current codebase because it has been completely written with only horizontal in mind.
But a PR would be awesome! ;)


Add spine animation format support

Add spine animation format support for godot engine
A surprise present :D

I will be trying to add support for the spine format in 1.2 so it imports using Godot built-in animation features. If it proves to be too difficult, this can be merged instead

The use of the official spine export format, for artist is more easy to use

Please use free softwares:
https://www.youtube.com/watch?v=uoQZV1f_J1s

I want to be able to import Spine animations
On Tue, Jan 19, 2016 at 11:03 AM, alabd14313<EMAIL_ADDRESS>wrote:

Please use free softwares:
https://www.youtube.com/watch?v=uoQZV1f_J1s
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/pull/1734#issuecomment-172862260.

Does this commit really support spine animation data? Godot lacks sprite deformation, which spine uses. Does this add that feature to godot's animation system?

I will be trying to add support for the spine format in 1.2 so it imports using Godot built-in animation features. If it proves to be too difficult, this can be merged instead

@reduz What's the status on this?

There is importer for spine animations: https://github.com/jjay/godot-spine-importer. It import spine as 3d scene with viewport and viewportsprite. Mesh deformation supported for either weighted meshes attached to multiply bones or deform meshes attached to single bone.

IMO @jjay's plugin is a great way to implement this feature. @reduz Do you still want to consider including spine animation support in core, or are you happy with a third party plugin on the assetlib?

I think godot should have this feature built into it's animation system.
The implementation here seems like a hack in a way imo and is useful only
to people who own a spine license (300$)
On Mon, Oct 3, 2016 at 11:26 AM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

IMO @jjay https://github.com/jjay's plugin is a great way to implement
this feature. @reduz https://github.com/reduz Do you still want to
consider including spine animation support in core, or are you happy with a
third party plugin on the assetlib?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/1734#issuecomment-251074083,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMbVVOm5F1izSYSgexk2PrpWKYaqN1nks5qwNhmgaJpZM4EId6F
.

I will soon be implementing 2D meshes in Godot, including skeletons. That
should allow importing from any animation software
On Oct 3, 2016 12:48 PM, "Todor Imreorov"<EMAIL_ADDRESS>wrote:

I think godot should have this feature built into it's animation system.
The implementation here seems like a hack in a way imo and is useful only
to people who own a spine license (300$)
On Mon, Oct 3, 2016 at 11:26 AM, Rémi Verschelde<EMAIL_ADDRESS>
wrote:

IMO @jjay https://github.com/jjay's plugin is a great way to implement
this feature. @reduz https://github.com/reduz Do you still want to
consider including spine animation support in core, or are you happy
with a
third party plugin on the assetlib?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/1734#issuecomment-251074083,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AGMbVVOm5F1izSYSgexk2PrpWKYaqN1nks5qwNhmgaJpZM4EId6F>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/1734#issuecomment-251143603,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z24fyace24gowmX_4tVFV2iFc1Y40ks5qwSPmgaJpZM4EId6F
.

As per the above, Spine importing will be done for 3.0 but with a different implementation, so closing this one. Thanks for the (long lived!) proposal though!


Dex provider

Allows use of a generic OIDC provider with a generic group implementation

mostly copied from: https://github.com/buzzfeed/sso/pull/118

Could it be you want this PR to go to the upstream repo?

@0xR this is mainly for my personal reference


[WIP] Modal windows

Modal is running I only need to see how control errors in modal...it seems the best way is...angular ^^
What do you think about this modal? :)

Coverage increased (+0.01%) to 95.814% when pulling 355fc92d6c1cc8b64b8154bf54c0f043f50d1199 on aljesusg:modal_windows into 001a203b1a4bac1671e2fa5f70725328f37b8b50 on propedeutica:master.

I do like it...
Cleaner and better than the old way....

In the gif, you need to provide room: "name", when calling I18n.t


fix: consider tx_index in transfers by block endpoint

:tada: This PR is included in version 1.0.0-beta.15 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-brc-20.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


make the policy managed, encrypt the EBS

I've been installing this for the subs team, and we really need to encrypt our logs due to PII risk.
I also need to reference the kinesis writer policy so I can attach it to my instances' role.
Not sure if these are changes that should apply to everyone, but they could be parameterised if necessary.
@adamnfish @jfsoul @TBonnin you guys have been PRing this project recently so you can critique my PR 😛

Only just seen this! Change looks reasonable to me and I think makes sense to make it compulsory for everyone, unless there is a downside that doesn't occur to me.
Not sure I can comment on the writer policy change though.  Why is that necessary?

the writer policy is so we can apply that policy to other instances rather than just being in this cloudformation.  Maybe I didn't know how to do it otherwise though!


GO error when compiling

Hello, I wonder if anyone else has the same problem... The compiler quits with an error:
`===>  photoprism-g20220901 USES=go has invalid arguments: 1.19.
*** Error code 1
Stop.`
My Go version is 1.19.2
Thanks!

Can you paste the line of GO_VALID_VERSIONS in the  /usr/ports/Mk/Uses/go.mk?
The correct value should be  GO_VALID_VERSIONS=	1.18 1.19 1.20-devel

No such a line in the go.mk file.
$FreeBSD: head/Mk/Uses/go.mk<PHONE_NUMBER>-02-24 22:39:56Z dmgk

I did a
portsnap fetch
portsnap extract
portsnap update
and now the go.mk is the right version with GO_VALID_VERSIONS= 1.18 1.19 1.20-devel
and the build was successfull. Thanks for helping me out!


PR: Use setup.cfg and conftest.py instead of runtest.py

Fixes #4424
~This is just a proof of concept, I hope this works 🙈~ It works!! 😄
~I know I shouldn't be working on this~

Great job @rlaverde! Before merging, I'd like you to make one of the tests of main window to fail, to see if pytest fails as before.

Please ping me when you do it.

@ccordoba12

Unfortunately, tests are hanging up on Windows (instead of finishing with a failure), as you can see in Appveyor (I'm going to kill this build to avoid an unnecessary and time consuming process).
I avoided this in run_tests.py by forcing an exit 1 call on failure but I don't know how to do the same here.

Maybe with a session-scoped autouse fixture?

@bilderbuchi, how that would work?

@ccordoba12 like this:
$ cat conftest.py
import pytest

@pytest.fixture(scope="session", autouse=True)
def ensure_exit(request):
    """Make sure that a pytest run can exit even if Qt hangs."""
    print('In session fixture: Start')
    yield
    print('In session fixture: After tests have run')
    if request.node.testsfailed:
        print('Some tests have failed. Exiting hard...')
        raise SystemExit(1)

$ cat test_something.py
def test_passes():
    print('A passing test')
    assert True

def test_fails():
    print('A failing test')
    assert False

$ pytest -s
======================================================== test session starts ========================================================
platform linux -- Python 3.5.3, pytest-3.0.7, py-1.4.33, pluggy-0.4.0
rootdir: <snip>, inifile:
collected 2 items

test_something.py In session fixture: Start
A passing test
.A failing test
FIn session fixture: After tests have run
Some tests have failed. Exiting hard...
E

============================================================== ERRORS ===============================================================
__________________________________________________ ERROR at teardown of test_fails __________________________________________________

request = <SubRequest 'ensure_exit' for <Function 'test_passes'>>

    @pytest.fixture(scope="session", autouse=True)
    def ensure_exit(request):
        """Make sure that a pytest run can exit even if Qt hangs."""
        print('In session fixture: Start')
        yield
        print('In session fixture: After tests have run')
        if request.node.testsfailed:
            print('Some tests have failed. Exiting hard...')
>           raise SystemExit(1)
E           SystemExit: 1

conftest.py:12: SystemExit
============================================================= FAILURES ==============================================================
____________________________________________________________ test_fails _____________________________________________________________

    def test_fails():
        print('A failing test')
>       assert False
E       assert False

test_something.py:8: AssertionError
============================================ 1 failed, 1 passed, 1 error in 0.03 seconds ============================================

I added a couple of prints and  -s to make the program flow visible, normally it would be less noisy.
Note that I don't fully understand why you need that in the first place. There might be a more elegant way from within pytest to exit cleanly, without kicking the legs out from under pytest's feet like you seem to do currently, and getting an Error.

@rlaverde, please try to use @bilderbuchi's suggestion.
@bilderbuchi, the problem is (I think) pytest could be running things in the background (e.g. closing the main window) when an error is generated, and that doesn't allow it the pytest process to finish on errors.

Hm, could you put together/suggest a minimal example? Then I could take this up with the purest devs, but ud like to have a good failure description before that.

Is this something that only happens on appveyor, or on local windows machines, too? Is there a previous spyder issue about that?

Closing for now because our tests are working relatively well.


Update all packages README's

Is your feature request related to a problem? Please describe.
The module project pages (GitHub and NPM) contain links to the old documentation sites.
Describe the solution you'd like

[x] Update all packages README's to contain the correct links
[ ] Remove old documentation sites
[ ] Create redirects from old documentation sites to new site

Describe alternatives you've considered
N/A
Additional context
Site module (example):

https://www.npmjs.com/package/druxt-site
https://github.com/druxt/druxt.js/blob/develop/packages/site/README.md
https://druxtjs.org/modules/site

All modules follow the same pattern.

Assigning this issue to @BrianGilbert
Ideally I'd like redirects from indexed pages to their new location, and in most cases a pattern should be able to get the redirect most of the way.
But I'd like the sites down ASAP, ideally before DrupalCon EU (Next week)


Vimar french pr

Motivation/Description of the PR

Add French translation to CodeceptJS

Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[ ] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] puppeteerCoverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[x] translation
[ ] wdio

Type of change

[ ] :fire: Breaking changes
[x] :rocket: New functionality
[ ] :bug: Bug fix
[x] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[] Tests have been added
[x] Documentation has been added (Run npm run docs)
[x] Lint checking (Run npm run lint)
[] Local tests are passed (Run npm test)

Awesome, thank you! :fr:


feat: add influxdb trace collection

Description
This PR adds a influx db client to the Node struct that we can use to push arbitrary trace data to a db. It also adds this functionality to the e2e test.
see README.md
Closes: #968

I've removed all default instances of data collection, since I'm not actually sure how we want to use this yet. This way, I think we can merge as is and adjust later. @cmwaters raises a good point that we can likely do a better job of combining this with the existing metrics/instrumentation. Originally, we went with this approach because we needed a push based approach to get past testground's limitations, but since then, the devops team has implemented a telegraf scraper that can get around this problem, so perhaps we can just use that influx instance for everything. This is even more relevant if we ever get to the point where we replace our e2e test with testground.
However, this approach does exactly what we need for the time being, so we might want to merge as is to better debug things like #965 (what I'm currently doing on the temp/feat/trace-collection-plus-timings branch)

This is even more relevant if we ever get to the point where we replace our e2e test with testground.

IMO, this should be one of our milestones: converge on testground as the framework for covering all "e2e" styled tests


First test run fails with open _ftl/[...]: no such file or directory

info:foo: Building module
ftl: error: failed to build module "bar": failed to extract module schema: err: exit status 1: stderr: go: cannot load module _ftl/go/modules listed in go.work file: open _ftl/go/modules/go.mod: no such file or directory

This is probably caused by #1500, it's the only thing that I think has touched the build system recently.


SPI ExclusiveDevice: access the bus object

Sometimes it might be necessary/useful to access the SPI bus object that is held by an ExclusiveDevice. One such case might be adjusting SCLK speed based on some data read from the SPI device.

This was discussed a bit in today's meeting. Sounds like a good feature to have. Could you send a PR?

Definitely, if something like an inner()/inner_mut() pair sound good. I'm on a vacation, though, so earliest is next week.

I htink the convention is inner(), inner_mut(). We might want to do into_inner() too, to deconstruct it.


merge from arlac77/npm-package-template-esm-only

package.json

fix(engines): add >=12.14.1 remove >=12.14.0 (engines.node)

.travis.yml

chore(travis): (jobs.include)
chore(travis): (jobs.include.node_js)
chore(travis): (script)

README.md

docs(README): update from template

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   93.99%   93.99%
=======================================
  Files           4        4
  Lines         283      283
  Branches       25       25
=======================================
  Hits          266      266
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efbf87...4e53ffb. Read the comment docs.

:tada: This PR is included in version 8.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Desktop notifications on Windows 10 have incorrect app name

OS: Windows 10 Pro Build 14393.10
Issue Descriptions:
Desktop notifications have an an incorrect app name in the notification bubble

Steps to Reproduce:

Enable Desktop notifications in Settings -> Labs
Restart
Play/Skip song - notification will appear with wrong app name

@ZephireNZ It looks like you are running an old version, did you get the update a few days ago?

Hmm, that's odd. I definitely did update the other day - I noticed in the changelog about the Windows 8 notifications. Yet, this morning it must have somehow reverted to the previous version - it's currently set as "start with Windows". A quick restart and it's working... No idea what's happening, but it's fixed for now at least xD

Not sure whether I should make another issue for it, but it seems that I have two different versions. When windows starts up the 3.3.0 welcome message shows, however when I stop and start it manually 3.4.0 welcome is shown instead. Something is fishy for sure...

Note that I upgraded using the prompt within the app, not by reinstalling the setup exe

@MarshallOfSound mentioned an issue with the startup script in another thread earlier today. I believe you need to open 3.3.0, disable auto start, and then close it, open GPMDP again and enable it.

If that's fixed should I close this issue, or shall I keep it open (and rename it for version mismatching)?

Does 3.4.0 show the correct notifications? Did what I suggest fix 3.3.0 auto launching?

Yep, the startup script was launching 3.3.0 instead of 3.4.0, and disabling helped. I was just asking if it'd been fixed in upstream so that when it updates to, say 3.5.0, it won't happen again. Otherwise may as well keep this around as a tracker of fixing that.

Ah, well if 3.4.0 has fixed notifications I'd close this and open a new issue about the start up script. If @MarshallOfSound has fixed that already he'll swing by and close it.

@ZephireNZ I'll save you some time it was fixed in https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/commit/80010fc98511af44c32c1593889b5171781240f7


Illegal ordering of White rook, queen, king on the first rank

Sherlock doesn't detect this position as illegal: 3r3r/p2p1p1p/b1p2kp1/1p1npq1n/P7/8/1PPPPPPP/RNB2RQK w - -

The order of the White rook, queen, king on the first rank is impossible.
On the kingside, QKR and QRK (because of castling) are possible, but not RQK.

Same as #42.
I guess a cage rule... Although it seems too concrete for these cases.
I would love to find something more general than that.


Added tests for StartingMessageParams.ts

Description

Added StartingMessageParams.test.ts file in src/vessel-charging/messages.
Fixes Issue #28
Related Issue

#31
Motivation and Context

The test file checks whether the serialize and deserialize methods work as it should.
How Has This Been Tested?

I executed npm run jest and made sure my code was not breaking.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

closes #28


fix: added functionality to skip-to-content

Description
I have added a functionality to skip to content button. Previously, the skip to content/navigation button was just present but did not provide the required functionality that is skip to the main content of the page and avoid the navigation bar. The function has been added.
Related issue(s)
Fixes #692

any updates? @developer-diganta

Hi @akshatnema ! Sorry for the delay. I have issue that is happening. Whenever I try to add an id to <Container>' inside , I seem to not be able to add that to the page. But if I add it to the  inside, it works. But my question is that is ` a generic element that is used somewhere else too? Since then, adding the id would not be correct.

You can add the id element inside GenericLayout by initializing a new div wrapping the children and providing it with id as main-content.

Hi @akshatnema! Thanks for the suggestion! I have made the appropriate changes. Do let me know if there is something else to change!

@akshatnema Made the suggested changes!

@akshatnema Done!


What happened to "az ml image" commands?

The earlier (preview) versions of the CLI extension contained commands for manipulating the Docker images (e.g. "az ml image create container"). This was very useful, because it made it possible to decouple the time consuming task of building the image from the actual deployment to a compute target and allowed verification of the image prior to deploying to production.
In the latest version, the image commands are not present in the CLI, even though the relevant classes (Image, ContainerImage) are still there in the SDK. What was the reason for the removal of the commands? Can they be added back in the future?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31f6989f-eb38-b376-d01f-9c462c2d1761
Version Independent ID: dbcf97e5-2f30-e98d-7959-69d39a74305a
Content: Machine learning CLI extension - Azure Machine Learning service
Content Source: articles/machine-learning/service/reference-azure-machine-learning-cli.md
Service: machine-learning
Sub-service: core
GitHub Login: @jpe316
Microsoft Alias: jordane

@jberezanski-mdg Thanks for the feedback! We are currently investigating and will update you shortly.

@jberezanski-mdg Hi Jakub, are you mentioning the following commands https://docs.microsoft.com/en-us/cli/azure/image?view=azure-cli-latest#az-image-update ?

@YutongTie-MSFT No, I'm referring to the image manipulation commands from the Machine Learning CLI extension. The older version of this docs page mentioned them:

Create an image that contains your machine learning model and dependencies:
az ml image create container -n myimage -r python -m mymodel:1 -f score.py -c myenv.yml

These commands were available in preview version 1.0.10 of the Machine Learning extension (installable via a link provided on the same docs page).

@jberezanski-mdg  Thank you for the detail. @jpe316 Hi Jordan, could you please share your idea here?

@jberezanski-mdg I ran into this issue yesterday. It appears as though now you use the new InferenceConfig in place of the image commands before you deploy. For instance, I am using the following in Python:
from azureml.core.model import InferenceConfig
inference_config = InferenceConfig(runtime=runtime,
                                   entry_script="score.py",
                                   conda_file="environment.yml")

See the documentation here: https://docs.microsoft.com/en-us/azure/machine-learning/service/how-to-deploy-and-where#2-define-your-inferenceconfig

@joelhulen yes, it appears that a facade was added to the SDK (Model.deploy()) which is able to handle both local and remote deployments. Internally, for remote deployments it simply calls the existing method from Webservice (Webservice.deploy_from_model()), which creates the image on the fly.
I can still build the image and deploy the webservice as separate steps using the SDK, Image.create() and Webservice.deploy_from_image(). What pains me, however, is that I can no longer do it from the CLI.

@Blackmist

I apologize for the inconvenience @jberezanski-mdg
During preview, the CLI did have an image command. This was removed when the CLI became generally available (released). My understanding is that many customers gave feedback that they didn't want to have to create images, just directly deploy models. Which is how we got to Model.deploy() and no image command for the CLI.
The documentation team can't assist with this, as we only maintain the docs, not the service or CLI. I recommend using User Voice to add a request to add this functionality back to the CLI.
@YutongTie-MSFT This is product feedback. #please-close

@jberezanski-mdg
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.

@Blackmist Thank you for the explanation, I'll submit a request on UserVoice then.

https://feedback.azure.com/forums/257792-machine-learning/suggestions/37745380-bring-back-cli-image-commands-az-ml-image-create

Awesome, thanks @jberezanski-mdg !


feat: update client providers

Please describe the changes this PR makes and why it should be merged:
Add docs for https://github.com/necordjs/necord/pull/1117
Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

LGTM


Use a better ultrafeedback

I notice that mistral-orpo-beta has been trained on argilla/ultrafeedback-binarized-preferences-cleaned, but  simpo and other baselines was trained on HuggingFaceH4/ultrafeedback_binarized. Did you try to experiment on the first ultrafeedback dataset to make a better performence?

Hi,
We haven't tried using a different UltraFeedback version, but I think the relative performance comparisons among different methods should generally hold regardless of which version we use. If you are looking to obtain better performance, we'd suggest running the Mistral-Instruct setting which uses on-policy data and yields better results than the original off-policy UltraFeedback.
Best,
Yu