Soft Security for Events

Please provide a summary of the feature
Going to break these issues into multiple parts. People can claim specific sub-features.

Prevent specific users from submitting more than 5 event objects into the database.

Recurring events cannot be more than 3 months between start and end. Can either reject the input or stop the object from

Start dates cannot be in the past

Start or end dates can only exist for 2022/2023. No 2024+ or before 2022.

Are there any potential issues you foresee with this feature
Is this feature related to any current or past issues? Please provide the #
Additional context
Add any other context or screenshots about the feature request here.
If you're interested in working on this feature, please comment so you can be assigned

@Caleb-Cohen I can take this

@Caleb-Cohen I can take this

Which ones? I have this broken into parts.

These two -
Start dates cannot be in the past
Start or end dates can only exist for 2022/2023. No 2024+ or before 2022.
They pair up nicely.

These two -
Start dates cannot be in the past
Start or end dates can only exist for 2022/2023. No 2024+ or before 2022.
They pair up nicely.

assigned!

I can take "Recurring events cannot be more than 3 months between start and end. Can either reject the input or stop the object from being submitted". I have some basic ideas on how to do possibly this using React hooks and the like. I'm new to the project so I'll definitely have some questions about how the project's structure.
Also I'm aware that some new features are going to be merged back into the "development" branch very soon, specifically the form to add events. Should I wait until those are merged before beginning implementation?

I can take "Recurring events cannot be more than 3 months between start and end. Can either reject the input or stop the object from being submitted".
I have some basic ideas on how to do possibly this using React hooks and the like.
Also I'm aware that some new features are going to be merged back into the "development" branch very soon, specifically the form to add events. Should I wait until those are merged before beginning implementation?

feature/formSecurity already has the features you speak of to add events. You should be able to fully test out security as is.

Hey, I'd really love to help out on one of these if I could. Even to just hang out and try to learn something would be great!

@Caleb-Cohen, we have fixed these issues. It's ready to be merged!

@Caleb-Cohen, we have fixed these issues. It's ready to be merged!

Merged what into where? I do not see an open PR.

Quick update to end 2022:

Our plan is to implement some tests that check each field's respective value in the FormContext individually
"Errors" for each test will appear on the form in the client respective to each failed test
Also we had merge errors at some point and it was a nightmare, but we pushed through them.

Quick update to end 2022:

Our plan is to implement some tests that check each field's respective value in the FormContext individually
"Errors" for each test will appear on the form in the client respective to each failed test
Also we had merge errors at some point and it was a nightmare, but we pushed through them.


Allow users to configure which walks are returned in a GetWalks operation

Currently GetWalks only returns full walks. In some cases users may also want to return partial walks.
For example if you do 4 hops you may want to return an walks that are length 3 or length 4.
In this case:
1 - 2 - 3 - 4
1 - 5 - 6
We should not return the walk 1 - 2 - 3 as we will return the length 4 walk instead.
To achieve this we should add a new field to the GetWalks operation. This field should allow users to configure the types of Walks that are returned. Perhaps this field could be an object that contains a transform Operation and a Predicate, similar to the Conditional object used in If and While. We would need to pass test Walk objects to the transform/predicate so that we can test whether or not we return it.
By default we should continue to only return full walks.

@m29827 What is the status of this issue please?

I believe this issue can be closed due to #2372


Docs List "Last Example" rightIconMenu not rendering

I am working on implementing a List similar to the "Last Example" from the docs. However, the rightIconMenu MenuItems no longer render with the latest release.

It looks like the primaryText prop needs to be provided to MenuItem now instead of passing the text as the child.

Btw I am enjoying the frequency of updates, fixed, and new features! Keep up the good work!

@llhupp : I was not able to understand your issue. Is this still an issue?
I am closing this issue or now , if you feel the issue still persists feel free to leave a comment below.


[WIP]Add colorsys module

Looks like unittest module is using round function interally, so please review #240 first.

Already implemented, closed.


Cuda for Jeston TX2

Initial CUDA support for conversions and pointcloud generation.
Performance improvement:
As tested on the Jetson TX2:

Description
Resoultion
fps
No Cuda, avg. (ms)
With Cuda, avg. (ms)

YUY2 into RGB8
1920x1080
30
30 - 32
5-7

YUY2 into RGBA8
1920x1080
30
34
7.5

YUY2 into BGR8
1920x1080
30
35
5 - 7

YUY2 into BGRA8
1920x1080
30
37
7 - 10

YUY2 into Y16
1920x1080
30
10
5 - 8

Splitting Y8I to Y8, Y8
1280x800
30
9 - 10
3 - 5

Splitting Y12 to Y16, Y16
1280x800
25
22.9
5 - 7

Pointcloud (deproject depth)
640x480
30
8 - 9
3 - 5

In order to activate GPU full power run: sudo ./jetson_clocks.sh
Acknowledgements:

cuda_conversion.cuh and cuda_conversion.cu is partly based on Mehran Maghoumi's work: https://github.com/Maghoumi/culibrealsense

Patches for Jetson TX2 in src/linux/backend-hid.cpp and src/linux/backend-v4l2.cpp were added as suggested by JetsonHacks in the following repository: https://github.com/jetsonhacks/buildLibrealsense2TX

Related issue: #1861

Will it be possible to "BUILD_WITH_CUDE" on a PC with Nvidia card (i.e not on a Jetson)?


automation: use ceph-mon ips instead of hosts for tests

This is terrible and I dont like it. But it fixes the changes done in https://github.com/crowbar/crowbar-ceph/pull/84
The reasoning behind this is due the the test suite not taking into account the difference between all nodes and only mon nodes : https://gitlab.suse.de/ceph/qa-automation/blob/storage3/update_template#L38
Not sure if we want to get this so we can fix the ceph issue asap and then tackle the cleanup and fix on the test side, or we can wait a bit more for this fix and I should tackle it on the qa-automation repo instead (will also need a fix on the automation repo as well)

 (5) S53P6 bsc#1018869 - Failed to apply Ceph proposal

See https://github.com/crowbar/crowbar-ceph/pull/84#issuecomment-273221316


add inherits=FALSE to use of exists()

In most (all?) cases we do not want to search in enclosing environments when we use exists.
I would like to go through and add inherits=FALSE in all cases, but checking the logic to see if there are any cases where we do want to look in enclosing environments. I am a bit worried about changing it in all cases though my general feeling is this is more robust to user choices of object names.
@perrydv @danielturek let me know of any thoughts.

My initial reaction is to be cautious.  I think this might have been explored previously.  More consistent handling of scoping issues is on the redesign agenda.  Let's discuss.

This was partially addressed in PR #825.


App market does not work

Hi.
We developed an app market prototype when we created the ANT manager.
However, it can be used for testing, but there is a problem in general use.
Some improvements are needed in relation to the app market for the expansion of the ANT ecosystem.

Need to prepare a process for ANT app developers.
Need a server to store and manage the ANT app package.

I will try to resolve it after I complete to handle Issue #122.

Due to Issue #137, we have a long-term plan of ANT; changing multi-app architecture to single-app architecture.
It is because most of IoT devices have single-app scenario and multi-app architecture means just complicated and useless one.
Therefore, app market is also not required for now.
I close this issue.


Problem with pmicp tutorial

Followed the following tutorial https://libpointmatcher.readthedocs.io/en/latest/ICPIntro/
It works well till I open cloud_0.vtk and cloud_1.vtk in PARAVIEW and at the next step of launching pmicp with an empty ICP configuration I get an error, I tried to copy paste the file from the tutorial, In that case the error is following:
terminate called after throwing an instance of 'PointMatcher<float>::ConvergenceError'
  what():  ErrorMnimizer: no point to minimize
Aborted (core dumped)

and when I launched the same YAML in the package you provided, the output is very unexpected:
* KDTreeMatcher: initialized with knn=1, epsilon=0, searchType=1 and maxDist=inf
match ratio: 0.900055
ICP transformation:
   0.993545   -0.113204  0.00724467    0.608055
   0.113237    0.993559 -0.00431907 -0.00381928
-0.00670904   0.0051116    0.999964   0.0106469
          0           0           0           1

Please help how to correct this.
Ubuntu 15.10
Ros kinetic

Thanks for trying out our library. It seems that the tutorial is slightly outdated. We added some safety checks to avoid computation problems when their is zero point that were matched. Also, the FileLogger doesn't seems to behave properly.
I'll update the tutorial and investigate what is happening with the FileLogger during the week.
Thanks for reporting!

The tutorial has been updated with the commit 836393079cdba12020c79a8d32fcab05bb90e7eb


[WFCORE-5155] Ensure that the LogContextConfiguration.prepare() is in…

…voked before registering the afterPrepare() step. Note too the rename of the method from afterCommit() to afterPrepare(). This was done as really it's always been invoked before LogContextConfiguration.commit() is invoked.
https://issues.redhat.com/browse/WFCORE-5155
Upstream PR: #4357

@jamezp thanks!


Closes #238 removes references to Democracy Earth

@GinaAbrams  PLEASE REVIEW. CONTENT removal changes significantly docs in the following sections:

https://deploy-preview-240--docsproduction.netlify.com//develop/appMiningFAQ.html#is-app-mining-decentralized
https://deploy-preview-240--docsproduction.netlify.com//develop/appMiningFAQ.html#what-is-the-app-mining-timeline
https://deploy-preview-240--docsproduction.netlify.com//develop/mining_intro.html#reaching-the-final-scores

Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

@GinaAbrams the changes are in.


SSH Warn on close - make optional setting (global or per ssh entry)

Relates to https://github.com/Eugeny/terminus/issues/2512
Now that we are warned and need to confirm every disconnect, it is laborious to close multiple warning prompts (personally, I roll through most of my working tabs with Ctrl-D once I've finished a bunch of sessions for the day..., found it smoother before this feature)
I agree it's necessary feature - and ideally I'd like to be able to set "Warn on disconnect" per SSH entry - but for now, allowing a global "Warn on disconnect: true/false" in the terminal or ssh config would be great.

+1

Both suggestion would be awesome.

A global prompt
A configuration per connection - with the default begin inherited from a global 'default config'

Added a UI option to SSH settings. You can also override it (warnOnClose) for individual connections through the config file.


Traceback Error

I'm not able to get the update script to run. I am receiving an error when trying to run it, even when using the --help switch.
[factorio@localhost factorio-updater-master]$ python update_factorio.py --help
Trackback (most recent call last):
File "update_factorio.py", line 4, in <module>
import os, posixpath, requests, re, sys
ImportError: No module named requests
CentOS 7
Updated everything. Python, PIP and Request installed per instructions.

Nevermind. Had to install 'requests' about 10 times for it to finally see that it was installed.


how to close application in tear down using robotium

From<EMAIL_ADDRESS>on January 26, 2012 23:33:07
What steps will reproduce the problem? 1.how to close application in tear down using robotium
2.solo.finishOpenedActivities() is not closing the app if the tests stops/hangs in between the exectuion 3. What is the expected output? What do you see instead? It should close the app. What version of the product are you using? On what operating system? Robotium 3.0, ADT 15 Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=219

From<EMAIL_ADDRESS>on January 30, 2012 10:11:51
Issue 196 says the problem is fixed in Robotium 3.1. I'm still testing that.
But my solution for Robotium 3.0 was to press Back button 15 times in tearDown() before I call solo.finishOpenedActivities()

From<EMAIL_ADDRESS>on January 30, 2012 21:27:01
In my application, if i press back for 15-20 times some times it says within the app, but not closing the app. This affects subsequent tests execution.
I'm using 3.0, what i'm doing tearDown() is closing all the activities. Based on the all the opened activities; finishing the activites untill it gets null.
while(solo.getAllOpenedActivities() != null)
{
solo.getCurrentActivity().finish();
i++;
if (i == 10)
{
break;
}
}
Kindly let me know if it works for you.
I've n't tried Robotium 3.1, pls try it and let me know if it works without additional modifications in our scripts.

From<EMAIL_ADDRESS>on January 31, 2012 00:59:30
This is an application issue. What finishOpenedActivities() does it to finish all the activities and then pressing back (just to make sure) that all activities are exited. There is nothing more that can be done from Robotium in order to finish activities.
Status: Invalid


[1777] Fix voteHoverCard -> fetchDelegate server action not working

Hi @andreitr @Flip-Liquid @stepandel would love to get your feedback on this draft PR.
When hovering over every voter, with standard server actions only one action at a time is being processed, which looked like it was canceling the requests when hovering over multiple voters at the same time since the first request takes >2s to resolve and all the other requests during this 2s are effectively not being done.
VoteHoverCard was never resolving as you can see on the screenshot, you can try to hover over multiple voters here https://vote.optimism.io/proposals/47253113366919812831791422571513347073374828501432502648295761953879525315523 to check data is never resolved except for the first hover.

I was looking at react "use server" docs: https://react.dev/reference/react/use-server#serializable-parameters-and-return-values and more concretely saw this:

Server Actions are designed for mutations that update server-side state; they are not recommended for data fetching. Accordingly, frameworks implementing Server Actions typically process one action at a time and do not have a way to cache the return value.

So I decided to give it a shot and do a random fetch to a random GET to see if I was not having this problem about requests not being done. I thought it made sense, following the docs, to just do a fetch GET request to our API endpoint to retrieve some data. Now it works perfectly fine and the bug is solved. In the future, client requests to the backend that do data fetching should probably be done this way, due to all the errors in this sense we have been having these past days. But this is something we can test in the upcoming weeks.
Lastly, here is a video demonstrating this statement: https://www.loom.com/share/b7b5bbc6423147078d415ca01eadfda6?sid=95c978d0-a0b7-4a7b-ba46-f8938b62ae9f

PR-Codex overview
This PR introduces a new useFetchDelegate custom hook for fetching delegate data, updates delegate-related components to use the hook, and refactors API calls.
Detailed summary

Added useFetchDelegate custom hook for fetching delegate data
Updated components to use useFetchDelegate hook instead of direct API calls
Refactored API calls for fetching delegates

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@ferrodri @andreitr leaving a few more thoughts here following up from yesterday, overall good with the approach we discussed
I think it would still behoove us to push as much rendering/data fetching onto the server as possible, but as we discussed, it does not quite fit our use for the hover cards (infeasible to prefetch ~1000s of delegates)
for client fetching data, we can move ahead with using the same API surface as we'll use for external developers.
@ferrodri can you merge this to add in the authentication lib? we can then integrate key validation into the route you have above.
Also, the below might be a useful wrapper you can co-opt for use in the FE:
agora-next/src/app/lib/agoraAPI.js

@ferrodri @andreitr leaving a few more thoughts here following up from yesterday, overall good with the approach we discussed
I think it would still behoove us to push as much rendering/data fetching onto the server as possible, but as we discussed, it does not quite fit our use for the hover cards (infeasible to prefetch ~1000s of delegates)
for client fetching data, we can move ahead with using the same API surface as we'll use for external developers.
@ferrodri can you merge this to add in the authentication lib? we can then integrate key validation into the route you have above.
Also, the below might be a useful wrapper you can co-opt for use in the FE: agora-next/src/app/lib/agoraAPI.js

Great! Could you approve, just converted it to a ready for review PR. Here is the preview link: https://agora-next-pammpl1rp-voteagora.vercel.app/

two points of feedback:

let's keep the API routes as plural for both /delegates and /delegates/{address}
can you add authentication to the /delegates/[address] route? similar to the /delegates route

Changes done, LGTM :)

@ferrodri, looks good, but I think you're still deleting src/app/api/v1/delegates/[addressorENSName]/route.ts in the PR


OverrunBufferException

Traceback (most recent call last):
File "evtxtract/carvers.py", line 174, in extract_chunk_records
File "Evtx/Views.py", line 186, in evtx_record_xml_view
File "Evtx/Views.py", line 169, in _build_record_xml
File "Evtx/Views.py", line 160, in rec
File "Evtx/Views.py", line 156, in rec
File "Evtx/BinaryParser.py", line 64, in call
File "Evtx/Nodes.py", line 1002, in fast_substitutions
File "Evtx/BinaryParser.py", line 534, in unpack_systemtimeOverrunBufferException: Tried to parse beyond the end of the file (read: 0x5a26a7b50, buffer length: 0x1900000000)
Killed

this exception should be correctly handled by the catched except Exception statement on line 190.
i think the Killed notice is unrelated, possibly from the OOM killer on the system.


Setting password for Users

I created a user from the admin dashboard as admin but there's no option to set password for the user and hence i can't login with the said user. Any fix for this?

Hi @DeStiNi10 you're right, I've checked and I've pushed a new version solving this issue, password field was added to create and edit form, by now it is an input type text, i'll solve it soon.

Hi @DeStiNi10 you're right, I've checked and I've pushed a new version solving this issue, password field was added to create and edit form, by now it is an input type text, i'll solve it soon.

Thank you very much! I'll follow up when you solve it. Could you just give a notification on this thread once you solve it?

Thank you very much! I'll follow up when you solve it. Could you just give a notification on this thread once you solve it?

Yes, I'll coment here when solved.

Yes, I'll coment here when solved.

@DeStiNi10 It is now solved, please pull the repo and it'll be done.

@DeStiNi10 It is now solved, please pull the repo and it'll be done.

Thank you very much!

Thank you very much!


19 Gems!

Why does this install 19 Gems, including Jekyll 2.5.3, redcarpet, and pygments? I'm trying to use this with  Jekyll 3.x.

vagrant@jekyll3:/vagrant/jekyll/jekylltest$ gem install octopress-paginate
Fetching: fast-stemmer-1.0.2.gem (100%)
Building native extensions.  This could take a while...
Successfully installed fast-stemmer-1.0.2
Fetching: classifier-reborn-2.0.3.gem (100%)
Successfully installed classifier-reborn-2.0.3
Fetching: execjs-2.5.2.gem (100%)
Successfully installed execjs-2.5.2
Fetching: coffee-script-source-<IP_ADDRESS>.gem (100%)
Successfully installed coffee-script-source-<IP_ADDRESS>
Fetching: coffee-script-2.4.1.gem (100%)
Successfully installed coffee-script-2.4.1
Fetching: jekyll-coffeescript-1.0.1.gem (100%)
Successfully installed jekyll-coffeescript-1.0.1
Fetching: jekyll-gist-1.2.1.gem (100%)
Successfully installed jekyll-gist-1.2.1
Fetching: jekyll-paginate-1.1.0.gem (100%)
Successfully installed jekyll-paginate-1.1.0
Fetching: blankslate-<IP_ADDRESS>.gem (100%)
Successfully installed blankslate-<IP_ADDRESS>
Fetching: parslet-1.5.0.gem (100%)
Successfully installed parslet-1.5.0
Fetching: toml-0.1.2.gem (100%)
Successfully installed toml-0.1.2
Fetching: redcarpet-3.3.2.gem (100%)
Building native extensions.  This could take a while...
Successfully installed redcarpet-3.3.2
Fetching: posix-spawn-0.3.11.gem (100%)
Building native extensions.  This could take a while...
Successfully installed posix-spawn-0.3.11
Fetching: yajl-ruby-1.2.1.gem (100%)
Building native extensions.  This could take a while...
Successfully installed yajl-ruby-1.2.1
Fetching: pygments.rb-0.6.3.gem (100%)
Successfully installed pygments.rb-0.6.3
Fetching: liquid-2.6.2.gem (100%)
Successfully installed liquid-2.6.2
Fetching: jekyll-2.5.3.gem (100%)
Successfully installed jekyll-2.5.3
Fetching: octopress-hooks-2.6.1.gem (100%)
Successfully installed octopress-hooks-2.6.1
Fetching: octopress-paginate-1.1.2.gem (100%)
Successfully installed octopress-paginate-1.1.2
19 gems installed

This gem requires Octopress Hooks which requires Jekyll >= 2.0.0. All of those dependencies are because of Jekyll 2.5.3. The way Rubygems handles dependencies, Jekyll 3 doesn't meet >= 2.0.0 that requirement until it has a stable release. Also, currently this gem does not work with Jekyll 3, but I'm working on that right now.

You can track the progress of Jekyll 3 support in PR #7.

Ok Thanks, that's good to know. I do appreciate all your hard work on this.


update dataspace analytics result to contain function info and executable info

What type of PR is this?

Improvement
What does this PR do / why is it needed ?

update dataspace analytics result to contain function info and executable info

Which issue(s) this PR fixes:

Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?

I think we are in the right direction, but we need to be mindful of not restoring the same exact information. We should store only things we need. I think we can keep the template info inside execution context based on your filtering. But for functions, it should be stored globally in the DataSpaceAnalysisResult class.
Furthermore, one thing I would like you to improve (separate PR is fine).
We should not store mapped entities for the same mapping twice.
So we should move that also to the global class.
Major use of execution context is to have the same mapping but different runtimes.
So we should only store one graph per mapping.

I think we are in the right direction, but we need to be mindful of not restoring the same exact information. We should store only things we need. I think we can keep the template info inside execution context based on your filtering. But for functions, it should be stored globally in the DataSpaceAnalysisResult class.
Furthermore, one thing I would like you to improve (separate PR is fine). We should not store mapped entities for the same mapping twice. So we should move that also to the global class. Major use of execution context is to have the same mapping but different runtimes. So we should only store one graph per mapping.

For moving mapped entities , I am concerned that it will not be backward compatible if I move it to the root as this field has been there since the beginning


Only consider enrolled tsps

Description
We need a mechanism to ensure that only the TSPs in the Bamford & Martin trial are awarded shipments. A proposal for updating the Award Queue was written here. This PR implements the approach documented there.
Additionally, there were a few error cases that weren't being handled, which have been fixed. To ease the code review, these are commented on the PR.
Code Review Verification Steps

[x] End to end tests pass (make e2e_test).
[x] Code follows the guidelines for Logging
[x] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[x] Update the diagram in docs/schema/dp3.sqs (see Updating and changing the model)
[x] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #dp3-engineering

[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change
Proposal for how to update the AwardQueue to handle trial TSPs.

This is a locking migration.   Please consult the PostgresSQL Locking Migrations document.  Please see if something like this will work:
add_column("transportation_service_providers", "enrolled", "bool", {default: false})
sql(“UPDATE transportation_service_providers SET enrolled=false’;”)
sql("ALTER TABLE transportation_service_providers ALTER COLUMN status SET DEFAULT false;")


resolve() fatal error when $delta['path'] is null

When there is no path on the $basePath parameter and no leading slash on the $newPath parameter, a fatal error is generated.
<?php
require('vendor/autoload.php');
$path = \Sabre\Uri\resolve('http://www.mydomain.com', '#');

Fatal error: Uncaught TypeError: strpos() expects parameter 1 to be string, null given in vendor/sabre/uri/lib/functions.php:59
Stack trace:
#0 vendor/sabre/uri/lib/functions.php(59): strpos(NULL, '/')

It is being caused by null being passed into strpos() at the first parameter with strict types enabled.
It could be resolved by casting or null coalescing the value to a string to mimic php5 behaviour, or throwing an exception if this is behaviour you do not want to support.

Hi!
This might be the weirdest thing I've seen so far. I added a unittest which passed (don't pay attention to the failed build here, different reason).
But, when I slightly change the unitest to force it to fail, I your fatal error. I can't' explain it, I don't get it. Hopefully ill have some more info here soon

Never mind, I was looking at it wrong! Only happens with a fragment that does't have a value


Allow building static libs with CMake

Currently you're forced to build a static lib because it's added with the STATIC keyword
Cmake has a built in option users can set to build shared/static called BUILD_SHARED_LIBS so it would be good to allow users to decide themselves what to do
To avoid potentially breaking changes I've also added it as an option to the Optick script as the CMake default is to build static

Any updates on this? It offers extra functionality without breaking anything existing so hopefully there are no objections

@bombomby is this likely to be merged or not?


#387 allow embedd fonts from jar-file for pdf creation

fonts can now added in fop configuration via classpath notation.
Also added FreeSans.ttf

Incredible. I could swear I tried that. Verapdf reports two glitches in the PDF/A file but I consider to just upstream that to the Fop guys
Validation Report.zip

Maybe one could move the font in the font directory, but i couldn't figure out how that is done.


how i can skip plugin which does not exist ?

If i have
require ( 'xxx' )

and "xxx" does not exist,  it leaves unchanged.
That webpack does not add error message

Could you provide a real example of the issue you're running into? It's hard to determine the problem without actual examples. Thanks!

I have already found another solution.


Latest issues

I did the following tasks :

Fix components alignment
Correct design responsivity
Change banner background to a carousel

Congrats !!!! You did a great job...
Only there are still some fixes to adjust.  I Hope you can see this

Fixed !!!!!


There's a square around the close icon on the intro modal

This still looks exactly the same as the picture above.


filter events for all sessions

Fix for #523

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage decreased (-0.03%) to 62.32% when pulling ac05eeefdcc3c944a57903d4f51562681d1ff876 on #523-evenbus-filter into 74b848f12bf88021c2072f053ff8d71c4a98ca33 on master.


Support offline mode

I run 2 Fabric servers through Velocity and I would really appreciate if it you made this mod work with online-mode = false

I'll see what I can do this weekend.

Any progress?

I've been preoccupied with other projects but I'll most likely get an update out in the next 32 hours or so

I went ahead and made a push to support offline mode, but I'm still planning on adding a few features before the next release, so I haven't made a separate release yet.
You're more than welcome to clone it and build it yourself until I make that separate release.


Unable to make TrimString middleware work

<?php

namespace Illuminate\Foundation\Http\Middleware;

use Closure;
use CloudCreativity\JsonApi\Contracts\Http\Requests\RequestInterface;
use Symfony\Component\HttpFoundation\ParameterBag;

class TransformsRequest
{
    /**
     * The additional attributes passed to the middleware.
     *
     * @var array
     */
    protected $attributes = [];

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @param  array  ...$attributes
     * @return mixed
     */
    public function handle($request, Closure $next, ...$attributes)
    {
        $this->attributes = $attributes;

        $this->clean($request);

        return $next($request);
    }
...

Request trims successful but using the Dingo\Api\Http\Request. How can I use trim request used by this package?

Tried using this app(CloudCreativity\JsonApi\Contracts\Http\Requests\RequestInterface::class) but throws binding resolve exception

Hi!
So thanks for pointing this out as it hadn't previously occurred to me that string trimming would not be working.
The reason it's not working is because this package is built on top of a framework agnostic package: neomerx/json-api. As that is framework agnostic, it uses the PSR ServerRequestInterface in several places. As a result we're getting the HTTP request body (JSON) from the server request, rather than the Illuminate request - but the trim strings middleware runs on the Illuminate request.
The other problem we have is that we need the JSON body as an object, not an assoc array to validate it against the spec. This is because there is a semantic difference in JSON between the client sending something as an object or an array - and if we decode as an assoc array, we can't tell whether the client sent something in the body as an object or an array as both are decoded as an array. The trim strings middleware runs against the JSON as an array, not an object, because the Illuminate request's json method returns an array, not an object.
I think the solution to this is to validate the request body against the spec as an object, but once that passes, uses the Illuminate request's json method for everything else... i.e. for validation and creating/updating records. This would mean that the trim strings middleware will then have an effect. I would need to make this change when working on the validation upgrades that I have planned.
As a side-note, the JSON API request interface is only bound into the service container within JSON API routes - i.e. after the json-api middleware has run.

I believe changing this will also make the ConvertEmptyStringsToNull middleware work.

has this been fixed in 1.0.0-beta?

Not yet, but it will be fixed during the beta cycle.

thanks a lot for your time!


Xfailed a number of projects.

The following projects/configurations were xfailed:
fluent, 5.0, Swift Package
fluent, 4.2, Swift Package
Kitura, 5.1, Swift Package
Kitura, 4.0, Swift Package
Moya, 5.1, Swift Package
SRP, 5.1, Swift Package
SRP, 4.0, Swift Package
Sourcery, 5.1, Swift Package
SwiftLint, 5.1, Swift Package
SwiftLint, 5.0, Swift Package
SwiftLint, 4.2, Swift Package
SwiftLint, 4.0, Swift Package
siesta, 5.1, Swift Package
vapor_console, 5.0, Swift Package
vapor_console, 4.2, Swift Package
vapor_database-kit, 5.0, Swift Package
vapor_database-kit, 4.2, Swift Package
vapor_multipart, 5.1, Swift Package
vapor_multipart, 5.0, Swift Package
vapor_multipart, 4.2, Swift Package
vapor_routing, 5.0, Swift Package
vapor_routing, 4.2, Swift Package
vapor_service, 5.0, Swift Package
vapor_service, 4.2, Swift Package
vapor_template-kit, 5.1, Swift Package
vapor_template-kit, 5.0, Swift Package
vapor_template-kit, 4.2, db35b1, Swift Package
The failure of
SRP, 5.1, Swift Package

is tracked by
https://bugs.swift.org/browse/SR-13190

All other failures are tracked by
https://bugs.swift.org/browse/SR-13189

@swift-ci test

@swift-ci test

@swift-ci test


capnp schema needs better hive coordinates support

Current schema does only partially support stitched data. Besides hiveX and hiveY the orientations are needed.
Suggestion: I propose to the stitched data into its own struct Stitched which looks nearly exactly like DetectionsDP so plug and change is possible. See below for implementation.
I also suggest removing hiveX and hiveY completely.
struct Stitched{
  xpos @1 :UInt16;               # x coordinate of the grid center wrt. the comb
  ypos @2 :UInt16;               # y coordinate of the grid center wrt. the comb
  zRotation @5 :Float32;         # rotation of the grid in z plane
  yRotation @6 :Float32;         # rotation of the grid in y plane
  xRotation @7 :Float32;         # rotation of the grid in x plane
}
struct DetectionsDP{
  idx @0 :UInt16;                # sequential index of the detection, counted from 0 for every frame
                                 # the combination (idx, Frame.id) is a global key
  xpos @1 :UInt16;               # x coordinate of the grid center wrt. the image
  ypos @2 :UInt16;               # y coordinate of the grid center wrt. the image
  zRotation @5 :Float32;         # rotation of the grid in z plane
  yRotation @6 :Float32;         # rotation of the grid in y plane
  xRotation @7 :Float32;         # rotation of the grid in x plane
  radius @8 :Float32;            # radius of the tag
  localizerSaliency @9 :Float32; # saliency of the localizer network
  decodedId @10 :List(UInt8);    # the decoded id, the bit probabilities are discretised to 0-255.
                                 # p(first bit == 1) = decodedId[0] / 255
  descriptor @11 :List(UInt8);   # visual descriptor of the detection. ordered from most
                                 # significant eight bits to least significant eight bits.
   stitched @8 :Stitched; # the stitched data, optional
}

# Corresponds to an image in the video.
struct Frame {
  id @0 :UInt64;                 # global unique id of the frame
  dataSourceIdx @1:UInt32;       # the frame is from this data source
  frameIdx @6 :UInt32;           # sequential increasing index for every data source.
  timestamp @2 :Float64;         # unix time stamp of the frame
  timedelta @3 :UInt32;          # time difference between this frame and the frame before in microseconds
  detectionsUnion : union {
    detectionsCVP   @4 :List(DetectionCVP);   # detections format of the old computer vision pipeline
    detectionsDP    @5 :List(DetectionDP);    # detections format of the new deeppipeline
    detectionsTruth @7 :List(DetectionTruth); # detections format of ground truth data
  }
}

Can somebody familiar with the code assess which parts of the code need change?
side note: issue is set to high prio since the person working on the stitching can implement them earlier than later and will be gone soon, meaning more work for other people. Especially when other people also depend on the current schema with hiveX and hiveY

hiveX und hiveY sollen aus der jetzigen detectionsDP raus


Ethers.js callback fails on return

see https://github.com/AlphaWallet/alpha-wallet-android/pull/853#pullrequestreview-287144323

It is working as expected in iOS. The trick like @JamesSmartCell mentioned is to create an account and login first to reproduce it properly.


making wording clearer on extra in impersonation

should implies that an extra can be mixed case.  but really it can't because a mixed case extra will mismatch on an RBAC ClusterRole once the header is canonicalized.

The names of HTTP headers are not case sensitive. If Kubernetes expects a particular case for that header name, I think that's a Kubernetes bug (that needs fixing), and not a detail to document.
My understanding is that Kubernetes should coerce the ( extra name ) to a consistent case.
/sig auth
/hold

I opened this PR after running into an issue with the client-go SDK cannonicalizing the extra attribute remoteAddr to the HTTP header Impersonate-Extra-Remoteaddr (notice that the R is now capitalized and the a is now lower-case).  I brought the issue up on sig-auth where @enj said:

Extra keys must be lower case
Because header keys are case insensitive and canonicalized

given that the client-go sdk won't work with camel case, and I'm pretty sure based on my own developement that golang would canonicalize a camel-case extra too, the wording should say must instead of should

Let's document that Kubernetes canonicalizes the extra key to lower case, but you can use whatever capitalization you like at the HTTP level.

(Also, we don't assume that developers are writing their API clients in Go).

this is according to the code https://github.com/kubernetes/kubernetes/blob/555623c07eabf22864f6147736fa191e020cca25/staging/src/k8s.io/apiserver/pkg/authentication/user/user.go#L31-L41

// In order to faithfully round-trip through an impersonation flow, these keys
// MUST be lowercase.

shouldn't the code's comment's expectations match in the documentation so the user's excpectations and the dev's expectations match?

(also, going to update this PR with a note about including usage specific suffix per the same docs)

The audience for code comments is a lot different from the audience for docs. I won't object to someone improving the comment in the code, but I also wouldn't insist on it.

ok, so there's a gap here between the expectations of the code and what's being presented to users.  You're saying that this is a bug in k8s, not something that should be addressed in documentation?

Here's the situation how I see it:

You can impersonate when invoking the Kubernetes API
When you impersonate, you can set extra data

extra data is key/value pairs
the keys are lower-case strings
the values are strings

you set extra data when impersonating using an HTTP header

the name of the HTTP header is "Impersonate-Extra-" with the key string appended
at the HTTP level, you can use any case for the key string
within Kubernetes, the key string is coerced to lowercase

If you have an RBAC rule
- apiGroups: ["authentication.k8s.io"]
  resources: ["userextras/scopes"]
  verbs: ["impersonate"]
  resourceNames: ["lowercaseexample","PascalCaseExample", "camelCaseExample"]

and you try to set that using an HTTP header: Impersonate-Extra-camelCaseExample
then it doesn't work, because the resourceName camelCaseExample should have been written as camelcaseexample in that rule, to match the internal coercion to lowercase.
With the same rule, if you use an HTTP header: Impersonate-Extra-LOWERCASEEXAMPLE then it works fine. The extra key from the HTTP header is coerced to lowercaseexample, which matches.
I don't think the new wording makes that clear; instead, readers might think that at the HTTP level, the case they use matters.

Any change that clarifies things is welcome!

/lgtm
/approve

I see your point that the HTTP header's name doesn't need to be lower case, it's the ClusterRole's rules[].resources that must be lowercase and that part of the docs is talking specifically about HTTP headers.
What if I switched must back to should, but add a sentence to the section on defining the ClusterRole that says the resources must be lowercase?

Hi @mlbiam . Yes, I like your suggestion. Do you have time to add the clarification? Thanks!

/hold cancel


Fix black error catch bug

This pull request fixes a small bug in which the wrong exit code was used to set the black_error.

🧪 test resutls (succesful)


move all 'algorithm'-functions to 'algorithm.py'

Only keep functions in 'aligner.py' that are the API of brdr. All specific function that do the calculations has to be moved to algorithm.py (or utils.py, depending on the use of the function)

algorithm.py not  made. Instead some refactroing is done inside aligner.py. All internal functions start with '_'


Fix epmd service existence check

systemctl doesnt have --value option. I was getting this error systemctl: unrecognized option '--value' on CentOS 7.6 after make install
https://manpages.debian.org/jessie/systemd/systemctl.1.en.html

I'm afraid your fix won't work:
$ systemctl show epmd --property=FragmentPath
FragmentPath=

so, it returns not an empty line, but key with no value, which can't be checked using -z "" test

You are right, what about checking for existence of /etc/systemd/system/epmd.service ?
FILE=/etc/systemd/system/epmd.service
if [ -f "$FILE" ]; then
    echo "$FILE exist"
else
    echo "$FILE does not exist"
fi

How about
if [ -z "`systemctl show -p FragmentPath epmd | cut -d = -f 2`" ]; then

You are right, I think this one is better :+1:

So, should be fixed by 46800f0671f1ea796e9aab3461d04f90e4811592. Thanks for your help!


FAQ

Add a FAQ to the forum.
Topics:

Set locale if not set and there are strange chars.

hi,
i use gunbot-monitor V.0.0.27 and this is very good.
i want to updated V.0.0.31 but your update command is don't work.
i want to deleted and new installed but i don't know.
you can help me?

What command did you use?
What error did you get?


[flakes] add and remove packages, individually

Summary
This is a work in progress. It works, but the code can be cleaned up and tests added.
And this PR is kinda big, so I should split it.
How was it tested?
>  DEVBOX_FEATURE_FLAKES=1 DEVBOX_FEATURE_NIXLESS_SHELL=1 DEVBOX_DEBUG=0 devbox shell
(devbox)>  DEVBOX_FEATURE_FLAKES=1 DEVBOX_FEATURE_NIXLESS_SHELL=1 DEVBOX_DEBUG=0 devbox add vim emacs
(devbox)>  DEVBOX_FEATURE_FLAKES=1 DEVBOX_FEATURE_NIXLESS_SHELL=1 DEVBOX_DEBUG=0 devbox rm emacs

Current dependencies on/for this PR:

main

PR #584

PR #597   👈

This comment was auto-generated by Graphite.


Some suggestions / improvements

Hey!
It's the first time I'm using Tingle, and I'm enjoying it so far!
Now, as I'm using it, I'm noticing some stuff that could (imo) be changed/improved/implemented.
(I apologize in advance if any of this things are already implemented, or in the 'TODO', or if I'm just misusing the plugin ... or, you know, if they're just dumb ahah )

~~ Have a seperate modal.setTitle() method ~~
Have an option for showing/hiding the default close button (I'm using footer buttons to close the modal)
Add opacity and visibility to the .tingle-modal's transition (so that it fades out nicely)
Have a way to keep the window scrollbar (I know they disappear for a reason, but I don't really like the little "translation" they cause when appearing and disappearing) (I wouldn't mind the content underneath the modal to be scrollable as a side-effect)
Have a .less file too (because, vars)

I'd be more than happy to help out, so let me know if I should start submitting PRs left and right 😃
Edit: I just noticed there's already a PR for the modal.setTitle() method, so forget about that one.

Hi p-realinho,
Firstly, thanks for your suggestions :)
Regarding tingle, I’m trying to keep the plugin simple, extensible and clean. I don’t want to add a lot of features because many other plugins already do this very well.
For example, the modal's title can be done by setting content and some custom classes, and I think it’s a better way to do this for fitting every needs. It’s the same thing for the transition, the style is just a base that could/should be customized.
Concerning LESS, I explained here why I don’t want to add any preprocessor.
I know there are some issues with the scrollbar, and it’s really tricky to handle it properly because it relies on the browser and also depends on the OS but I’m definitely working on this.
Same for the close button and click outside behavior, I just want to think a little bit more about it before setting up a clean API.
I hope that I have been able to answer all your questions.

Hi, thanks for your response.
Yea, I understand, and agree with your vision for the plugin.
Thank you again for the great repo, and keep up the good work :)


⚠ ClamAV has degraded performance

In 9fcdb7e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 56 ms

Resolved: ClamAV performance has improved in 4eee9f0 after 5 minutes.


Update users.ts

Added IdeaScale as we are using turbo

@nureweb thanks for your patience here. could you rebase once for me?

Feel free to re-submit with a rebase and ping me!


Game crashed right after song clear, is there a way to manually upload score?

My game crashed right after finishing a song. the score is safe, I think, because I can play the Replay in game just fine
is there a way to upload this score manually?
BS 1.25.1

send your log please. BeatSaber\Logs\latest.log

(im no official person)
since it can't be verified who the replay is from i'm pretty sure uploading a replay manually is not possible.
for the crashes post your tombstone-errorlogs


switch binding breaks if case-key includes space

i noticed that when my switch binding case key includes a space, the binding breaks.
specifically 'not sent' >>> 'not\ sent'
workaround:
bindings: {
    'model.mediaStatus': {
        type:  'switch',
        cases: {
            'uploading':  '.progress',
            'processing': '.progress',
            'encoding':   '.progress',
            'failed':     '.failed',
/*jshint -W044*/  //ignore warning: Bad or unnecessary escaping.
            'not\ sent':  '.actions',
/*jshint +W044*/
            'finished':   '.actions'
        }
    }
}

preferably should not require escaping space,
i found solution by reading code (undocumented - thus as bug, should be fixed)

Added a test case for https://github.com/AmpersandJS/ampersand-dom-bindings/pull/39 and it seems to pass with a space in case...

I'm gonna close this since we have a test confirming that is passes now in the dom-bindings lib.


Error while building ARM Compute Library

I was following this guide to build arm compute library and ran the following line to execute the build
scons arch=arm64-v8a neon=1 opencl=1 embed_kernels=1 extra_cxx_flags="-fPIC" benchmark_tests=0 validation_tests=0

The build runs for some time but then I'm facing the following error
In file included from ./src/cpu/operators/CpuDirectConv3d.h:38,
                 from src/runtime/NEON/functions/NEConv3D.cpp:30:
./src/cpu/kernels/CpuDirectConv3dKernel.h:78:38: error: noexcept-expression evaluates to ‘false’ because of a call to ‘arm_compute::Size3D::Size3D(size_t, size_t, size_t)’ [-Werror=noexcept]
   78 |     Conv3dInfo            _conv_info{};
      |                                      ^
In file included from ./arm_compute/core/Types.h:30,
                 from ./arm_compute/core/ITensorInfo.h:30,
                 from ./arm_compute/runtime/NEON/functions/NEConv3D.h:29,
                 from src/runtime/NEON/functions/NEConv3D.cpp:24:
./arm_compute/core/Size3D.h:43:5: error: but ‘arm_compute::Size3D::Size3D(size_t, size_t, size_t)’ does not throw; perhaps it should be declared ‘noexcept’ [-Werror=noexcept]
   43 |     Size3D(size_t w, size_t h, size_t d)
      |     ^~~~~~
In file included from ./src/cpu/operators/CpuDirectConv3d.h:38,
                 from src/runtime/NEON/functions/NEConv3D.cpp:30:
./src/cpu/kernels/CpuDirectConv3dKernel.h:78:38: error: noexcept-expression evaluates to ‘false’ because of a call to ‘arm_compute::Padding3D::Padding3D()’ [-Werror=noexcept]
   78 |     Conv3dInfo            _conv_info{};
      |                                      ^
In file included from ./arm_compute/core/ITensorInfo.h:30,
                 from ./arm_compute/runtime/NEON/functions/NEConv3D.h:29,
                 from src/runtime/NEON/functions/NEConv3D.cpp:24:
./arm_compute/core/Types.h:775:5: error: but ‘arm_compute::Padding3D::Padding3D()’ does not throw; perhaps it should be declared ‘noexcept’ [-Werror=noexcept]
  775 |     Padding3D()
      |     ^~~~~~~~~
In file included from ./src/cpu/operators/CpuDirectConv3d.h:38,
                 from src/runtime/NEON/functions/NEConv3D.cpp:30:
./src/cpu/kernels/CpuDirectConv3dKernel.h:78:38: error: noexcept-expression evaluates to ‘false’ because of a call to ‘arm_compute::Size3D::Size3D(size_t, size_t, size_t)’ [-Werror=noexcept]
   78 |     Conv3dInfo            _conv_info{};
      |                                      ^
In file included from ./arm_compute/core/Types.h:30,
                 from ./arm_compute/core/ITensorInfo.h:30,
                 from ./arm_compute/runtime/NEON/functions/NEConv3D.h:29,
                 from src/runtime/NEON/functions/NEConv3D.cpp:24:
./arm_compute/core/Size3D.h:43:5: error: but ‘arm_compute::Size3D::Size3D(size_t, size_t, size_t)’ does not throw; perhaps it should be declared ‘noexcept’ [-Werror=noexcept]
   43 |     Size3D(size_t w, size_t h, size_t d)
      |     ^~~~~~
cc1plus: all warnings being treated as errors
scons: *** [build/src/runtime/NEON/functions/NEConv3D.o] Error 1
scons: building terminated because of errors.

Hi @saswat0
Which ACL release are you using? This has been fixed in master dev branch: https://review.mlplatform.org/plugins/gitiles/ml/ComputeLibrary/+/refs/heads/master/arm_compute/core/Size3D.h#43
Please try building with the latest ACL release, for previous versions please try adding noexcept as shown in the link above.
Hope this helps.

I pulled from the github repository as mentioned in the official guide
Is this not updated?

Hi @saswat0
It's a build error with a specific toolchain, to fix this please see:
https://github.com/ARM-software/ComputeLibrary/issues/948
As mentioned you have to add noexcept clause in the code.

Got it. Thanks a lot!


fix data race in cert revoke check

Proposed Changes

fix data race in cert revoke check
adds runtime race condition check in gh build action workflow
closes #201

POC
$ go run -race . -u scanme.sh,projectdiscovery.io

  _____ _    _____  __
 |_   _| |  / __\ \/ /
   | | | |__\__ \>  <
   |_| |____|___/_/\_\	v1.0.5

		projectdiscovery.io

scanme.sh:443
projectdiscovery.io:443
[INF] Connections made using crypto/tls: 2, zcrypto/tls: 0, openssl: 0


Correction for raw affiliation Department of Earth, Ocean and Atmospheric Sciences, University of British Columbia, Vancouver, Canada; Hakai Institute, Victoria, Canada; Institute of Oceans and Fisheries, University of British Columbia, Vancouver, Canada

Correction needed for raw affiliation Department of Earth, Ocean and Atmospheric Sciences, University of British Columbia, Vancouver, Canada; Hakai Institute, Victoria, Canada; Institute of Oceans and Fisheries, University of British Columbia, Vancouver, Canada
raw_affiliation_name: Department of Earth, Ocean and Atmospheric Sciences, University of British Columbia, Vancouver, Canada; Hakai Institute, Victoria, Canada; Institute of Oceans and Fisheries, University of British Columbia, Vancouver, Canada
new_rors: 02qa1x782;03rmrcq20;02pry0c91
previous_rors: 02qa1x782;03rmrcq20;01a583453
works_examples: W3200121334
contact: 84e67b9e5a4541318b20a1ac2ce2b3d5:4c59ba34 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


SEV2.5 GAMBLING DOWN

Impacted

!points
!gamble

2 Customers impacted
Mitigation
Since feature is not crititcal to function of stream, this can be handled after stream.
Fix will be deployed tomorrow when streamer has time to fix.

Will there be a COE?

I don't see any +1s so no

Issue is mitigated as commands work after a new deployment
reducing to SEV3
Issue cannot be closed as an error appears on almost every command
TypeError: Cannot read property 'response' of null


Clarify what's unused

Following profunctors, make the types indicate what's unused.

Ah, neat trick. I didn't know about this. Waiting for travis, then I'll take another look.

@sjakobi what are your thoughts on this? I'm in favour. The only drawback might be that type errors are slightly more confusing, though it's unlikely that users are going to pass anything but a function in practise anyway. also, perhaps the use of this trick should be documented.

I'm not so sure about the type variable name/presentation. I think we should use something infix to suggest a function arrow. Since we can't use actual operator characters in a type variable, maybe something like a `arr` b?

Or maybe a `to` b?

Neat idea!
We have the following note in the haddocks:

All of the functions in this module take an argument that solely directs the type of the coercion. The value of this argument is ignored.

So how about something like
type Director a b = a -> b
We could then have haddocks on the type alias.

BTW @chessai, had you seen https://github.com/sjakobi/newtype-generics/pull/5? I sometimes feel bad about having this neat API just lying around. I suspect that it's actually better than what either coercible-utils or newtype-generics currently offer.

Neat idea!
We have the following note in the haddocks:

All of the functions in this module take an argument that solely directs the type of the coercion. The value of this argument is ignored.

So how about something like
type Director a b = a -> b
We could then have haddocks on the type alias.

I think I'd prefer something more like type Director p a b = p a b. That way they could pass anything of kind Type -> Type -> Type. But, perhaps this flexibility is unnecessary, and a type alias would be preferred, since the only goal here is clarity of consumption.

I'm not a fan of this Director business, for two main reasons. One is that I'm opposed to type synonyms in most cases; they add mental indirection for nothing here. Also, I don't even see how that's supposed to be mnemonically helpful here. Much better, I think, to give the type variable a name that indicates what it's supposed to do.

I think the right place to document what the to/arr/coerceTo type variables are about is the documentation at the top of the module.

By the way... if you want to keep precisely the same API as before while still communicating the same thing, one option would be
class IsArrow p | -> p
instance IsArrow (->)
-- or
class IsArrow p
instance p ~ (->) => IsArrow p

(#.) :: (Coercible b c, IsArrow p) => p b c -> (a -> b) -> a -> c
(#.) _ = coerce	(#.) _ = coerce

This means the argument will be inferred as having a function type, but (#.) can't make use of that fact. I don't think this is really a good idea, but I figured I'd mention it...

I'm not a fan of this Director business, for two main reasons. One is that I'm opposed to type synonyms in most cases; they add mental indirection for nothing here. Also, I don't even see how that's supposed to be mnemonically helpful here. Much better, I think, to give the type variable a name that indicates what it's supposed to do.

I generally share this opinion. Type synonyms are generally distracting, I only like using them for quick hacking. Almost all usage of type synonyms are banned at work, except for the common transformers+Identity story.
Okay, I think we should just name p to something useful and make it infix.

@chessai, for what it's worth, I have found more uses for type synonyms than that. Several higher-rank ones can be useful, like type f ~> g = forall x. f x -> g x, and stuff from lens (though that's always controversial). In heavily typish code they often show up with type families, such as
type family ReverseOnto acc xs where
  ReverseOnto acc '[] = acc
  ReverseOnto acc (x ': xs) = ReverseOnto (x ': acc) xs

type Reverse xs = ReverseOnto '[] xs

I recently found them useful for working around nasty limitations of the type role system, where sticking a newtype in how I'd prefer prevented necessary coercions (the whole mess got wrapped under a newtype before exposing it to the world anyway).
My final "approved by me!" use for type synonyms is as throw-away constraint synonyms appearing once as a superclass constraint, once as an instance constraint, and never again.
type CS a b c d = (Blah a, Boop a b, Bleep b c, Huh c d b, .......)
class CS a b c d => C a b c d
instance CS a b c d => C a b c d

Sorry for the irrelevant ramble; can't help myself.

it's ok; i enjoy your rambles. i can see uses for all of those.

Yeah, Director wasn't a good name.
I'd be fine with something like
a `to` b

or
coerce a b

Although I'd like to see the haddocks before we make the final decision.

I changed the name of the type variable and updated the documentation.

Thank you @treeowl! :)


Better CSRF tokens

Unfortunately, I couldn't find a security contact to discuss it privately before opening a pull request. It might be good to add a security policy with such info.
I'd suggest to update CSRFTokenUtility:

Use SecureRandom to generate a key for MAC. That strengthens the key, and makes it more difficult to forte a CSRF token.
Use MessageDigest.isEqual() when validating tokens. String.equals() uses a non-constant-time algorithm to compare inputs. As a result, it might allow an attacker to run a timing attack. Instead, it is better to validate tokens with MessageDigest.isEqual() that uses a constant-time algorithm whose time doesn't depend on the content of the inputs.
Use StandardCharsets.UTF_8 when converting strings to byte arrays. That allows to get rid of a try-catch block for UnsupportedEncodingException.

Pull Request Test Coverage Report for Build 6296

2 of 5 (40.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 44.845%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-web-server/src/main/java/azkaban/webapp/CSRFTokenUtility.java
2
5
40.0%

Totals

Change from base Build 6294:
0.007%

Covered Lines:
17412

Relevant Lines:
38827

💛  - Coveralls

@artem-smotrakov Good suggestions.

@artem-smotrakov Good suggestions.

Thanks for the feedback @aditya1105 It would be great if someone from the project maintainers reviewed the patch.


Fixed comment about scala versions.

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

This is incorrect as Flink 1.7 also builds with scala 2.12. The entire section nee

This is incorrect as Flink 1.7 also builds with scala 2.12.

This is incorrect as Flink 1.7 also builds with scala 2.12.
👍

@zentol PTAL.


Refactor: changed font

I thought that the font can be more readable if we use Noto Sans Mono. Hope this helps.

I'm not super keen on this change. Monospaced fonts aren't very legible in an article format. If you're interested in moving to a separate sans-serif font, feel free to open another PR.


Refactor/aiohttp session

Description

Related issues

Introduce aiohttp_session as a way to handle the session instead of the custom way that was there before.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

added aiohttp_session as dependency
fixed function comments and missing information
refactored auth to include  new session management
refactored unit tests
fixed some typing Any
migrated to variables used by motor 3 for SSL https://motor.readthedocs.io/en/stable/migrate-to-motor-3.html?highlight=ssl_certfile#renamed-uri-options

Testing

[x] Unit Tests

Mentions

I tested this branch and e2e test still fail from github CI pipeline.

@hannyle, does it also fail if you run locally?

@hannyle, does it also fail if you run locally?

They run fine locally.

@hannyle is it the same redirect issue?

@hannyle is it the same redirect issue?

Yes, the issue of redirection from localhost:5430 --> localhost:5430/error401

We have changed so much code after this was initially made! I will try to make it work again, and see if the previous issues will still exist.

It seems to run as expected ^^. Still need to investigate the previously existing issues.

The issue seems to come from changing the setup for checking for valid sessions in middlewares.py. There used to be a check for static files, which was removed. Restoring that removes the unexpected redirect.
It's still a bit of an issue, though. Because the previous code was checking for static routes, which the new one discarded that. But at the same time, we don't know all the static routes that exist, so we can't check them. We should instead serve static files only with external hosting, or change the setup.
We don't really test static routes in the backend, but the frontend does.
Checking sessions was done on a global level, but it shouldn't check routes that match the static routes that would match the frontend. Those should always return the static files.
It would be nice to be able to mark (decorate) routes that are checked, instead of a global check which should keep track of which routes exist. Sounds like a prone to error approach.
Perhaps we should use nested applications, so we can apply the session checking middleware only to the API routes, and the public routes are not checked. We might need then to prepend the API routes with, for e.g. /api. I think this would be a good solution.

This PR was already quite large, so I'll make another PR, which makes some changes to API, and fixes the issues created by this one, mentioned above.


Implement more efficient hyperparameter search

Several options for achieving good coverage of hyperparameter space more efficiently than systematic grid search are discussed in scikit-learn documentations. Can pick or experiment and pick to enable us to explore large parameter search space within 'reasonable' time. Should lead to better-performing models.
Sampling-based HPO can be a good alternative. E.g., https://github.com/optuna/optuna or one of sampling-based option provided by scikit-learn.

@rachelt44 Time permitting, I will look into this, before returning to explore extrapolation.


Feature: Add useEffectTill

PR Description
Summary
This PR introduces a custom React hook, useEffectTill, designed to run an effect only until it is marked as done, handling cleanup afterward. The hook enhances the standard useEffect by allowing for precise control over when the effect should run and when it should be cleaned up.
Changes Made

Added TypeScript type definitions for the callback functions used in the hook.
Implemented the useEffectTill hook, including tracking if the effect has already run and handling cleanup.
Added internal comments to enhance code readability and understanding.

Usage Example
useEffectTill((done) => {
  if (data) {
    // Do something.
    done();
  }
}, [data]);

Why
The useEffectTill hook fills a gap in the React ecosystem by offering developers a way to execute effects with precise control over their lifecycle. It enhances code readability and reduces potential bugs related to effect cleanup.
How to Test

Apply the useEffectTill hook in a React component.
Write tests to cover scenarios where the effect should and should not run.
Verify that cleanup occurs correctly once the effect is marked as done.

Additional Notes

This implementation aligns with best practices in React development.
The code includes appropriate TypeScript typings for a seamless integration into TypeScript projects.

I think useEffectUntil is a better name if this is being added. "Til" is a contraction of "until" anyway (and mis-spelt as "till" here).


Missing step to download repo code in Readme

Describe the issue:
Missing step to download repo code.

Suggestion:
Add the following step before step 1:
Run the following command to download this project code:
azd init -t AzureCosmosDB/cosmosdb-nosql-copilot or git clone https://github.com/AzureCosmosDB/cosmosdb-nosql-copilot.git
@markjbrown and @hemarina for notification.

This issue has been resolved, we will close it.


Pending after receiving over lightning does not go away

Taking over @klochowicz

Unasigning myself if someone else wants to have a look.

Additional info:

payment from ldk-sample to maker works

payment from maker to ldk-sample works

keysend from ldk-sample to maker work

payment from taker to maker works

payment from maker to taker works.

This makes me think that our code is correct but it has something todo with how we store state.
It could be that the channel_manager or key_store does not know about the hash/secret when receiving the payment and hence does not accept the payment.

@bonomat did you try ldk-sample or ldk-bdk-sample?
was this an outgoing channel from the sample to the maker?

@bonomat did you try ldk-sample or ldk-bdk-sample? was this an outgoing channel from the sample to the maker?

I used our ldk-sample fork: https://github.com/itchysats/ldk-sample/
I've always opened a channel to the maker from either taker or ldk-sample

can you check whether it works for you with ldk-bdk-sample? https://github.com/klochowicz/ldk-bdk-sample
I can't get the payment to work this way now:
{"status":500,"title":"Failed to pay lightning invoice","detail":"LightningError { err: \"Failed to find a path to the given destination\", action: IgnoreError }"}%
which is weird, I have an open and usable channel  direct channel with the other party, and the destination is correct.

I think I found something, I managed to successfully pay the taker.

I think I found something, I managed to successfully pay the taker.

woop woop... i'm curious :)

I think I found something, I managed to successfully pay the taker.

woop woop... i'm curious :)

was too excited I think! I got around some of the errors, but I still get the one you mentioned.
Added some in-between PR, and continuing the work:
https://github.com/itchysats/10101/pull/349


[META] Fix Problems Relating to macOS Notarization/Signing

Introduction
Etterna is currently distributed as an unsigned app on all platforms, including macOS.
Windows throws some mildly-scary looking warnings up to users (which most people are conditioned to bypassing anyway), but macOS takes many active measures to severely limit the functionality of unsigned apps for security reasons.
At this point, many bugs exist and have been encountered by users stemming indirectly from this problem:
App Translocation:
By default, macOS prevents apps from accessing resources relative to the app's location.
This is to prevent a class of attacks known as "dylib hijacking", wherein an attacker maliciously replaces external resources used by an app, which can potentially cause even signed intact apps to exhibit unintended malicious behavior. [1]
To fix this, recent versions of macOS do not always launch apps with a current working directory equal to where the app actually lives on disk. Instead, apps are sometimes launched from a read-only dynamically created volume under /private/var/ containing the app and any internal resources. This process is known as "App Translocation", and occurs when certain conditions are met, including the launching of an unsigned app with the com.apple.quarantine xattr set (which occurs automatically when apps are downloaded through Safari) [2] [3] This breaks Etterna because we intentionally store the Songs and Saves directories relative to Etterna.app itself, instead of within ~/Library/Application\ Support like Apple intends us to.
We currently work around this in an incredibly hacky way, by explicitly checking if we are undergoing app translocation, locating the real location of Etterna.app if so, and directly removing the com.apple.quarantine xattr from our own app ourselves before then killing and relaunching Etterna. See:

https://github.com/etternagame/etterna/blob/9a0b9fb94ea0c1f4d24b707bd00fad24d94d22ec/src/Core/Platform/PlatformMac.mm#L24-L69

This workaround is bad for a number of reasons:

It is fragile, in that it relies upon the internal function SecTranslocateCreateOriginalPathForURL in the Security framework [4]
This is certainly something Apple doesn't want us doing and relies upon an internal function that could change or disappear in the future.
The roundaboutness of the way we try to do this has caused problems

Sometimes, removing the quarantine xattr from only Etterna.app itself doesn't seem to be enough, and it must be removed from additional resources like crashpad_handler: https://github.com/etternagame/etterna/issues/1128
Sometimes, we fail to untranslocate ourselves for whatever reason (e.g. Etterna mistakenly being launched from a read-only volume), and the way our current code responds is by repeatedly opening new Etterna instances which then kill themselves after opening others in an eternal loop: https://github.com/etternagame/etterna/issues/1174

It appears macOS Ventura/Sonoma may have once again changed how the quarantine process works -- I (bluebandit21) had a Discord DM conversation helping someone with problems they encountered with our unquarantining process; see also [5]
This might make our approach stop working, as it appears only certain trusted apps (e.g. Terminal) can interact with the protected com.apple.provenance xattr
TODO: Expand this further/confirm?

Input Handling
Currently, we use a horribly outdated API for handling low-level input on macOS, as described by https://github.com/etternagame/etterna/issues/1260 and other issues/discussions.
This API requires elevated permissions to be allowed for use by an app, namely the Input Monitoring permission, without which certain API calls fail with a lack-of-permissions error. (TODO: Expand, link to relevant detailed sources)
Unfortunately, the system for handling per-app permissions seems to somehow interact with whether the app is signed or not; sometimes the com.apple.quarantine xattr seems to have to be removed before it's even possible to grant Etterna permissions to Input Monitoring in the first place! (TODO: This is possibly also related to us not having a valid CFBundleID; investigate further...)
See: https://gist.github.com/bluebandit21/d34d7b0b4f9137c34c167e607db63c03
Native M-Series (Apple Silicon) Builds
To ease the transition when Apple switched from Intel's x86_64 chips to their own in-house ARM (aarch64) chips, Apple created the library Rosetta v2 which transparently and efficiently lets Apps compiled for the x86_64 architecture run on aarch64, via a JIT compilation layer. [6] This fortunately means that existing Etterna apps built for x86_64 do not encounter any more problems than we already do when trying to run on M-series machines.
However, we definitely want to get native ARM macOS builds working at some point for two main reasons:

One, we take a moderate, but not insignificant, performance hit by operating through the rosetta v2 translation layer.
Two, eventually Apple will stop support for x86_64 apps in the future, and the only way to run apps on modern Apple computers will be by compiling them targeting ARM. When Apple released Rosetta v1 for the PowerPC to Intel transition, they supported PowerPC apps from 2006 until 2011, or five years. [7]
Apple released Rosetta V2 in 2020; if we assumed the same five-year lifespan for it, we'd expect them to drop support sometime in 2025, less than two years away from the time of this issue's creation!

Why is this of potential concern w.r.t. notarization/signing? Because modern versions of macOS require any apps running natively on M-series to be signed and notarized to run!

Beginning in macOS 10.14.5, software signed with a new Developer ID certificate and all new or updated kernel extensions must be notarized to run. Beginning in macOS 10.15, all software built after June 1, 2019, and distributed with Developer ID must be notarized. However, you aren’t required to notarize software that you distribute through the Mac App Store because the App Store submission process already includes equivalent security checks. [8]

Conclusion:
We should probably actually figure out how to notarize ourselves on Etterna!!
The most straightforward route would probably be to have a single individual developer for Etterna (most likely @jameskr97 or @bluebandit21 ) pay for a personal Apple Developer license at the cost of $99/year and sign all releases intended for public distribution. [9]
This would likely have to be a manual process, or we'd have to very carefully modify the CI to make it possible for this signing to occur without leaking the personal signing information of the said developer...
Another possible way would be establishing an Organization Apple Developer account for Etterna, also at the cost of $99/year. This obviously has the relative downside that we'd have to somehow generate this money specifically for Etterna, while the "Individual random developer" route might be "free" in the sense that we might just have access a developer that already pays this cost and lets us use their signing identity at no additional cost to either us or them.
However, it is theoretically possible we could get this fee completely waived for us by applying for a non-profit fee waiver.[10]
This would require Etterna to have a legal Non-Profit status, which might be much more work than the potential benefit it provides.

@jameskr97 Could I ask you to quickly double-check this hecking essay of an issue post for correctness?
I believe everything I'm saying is correct and should be well-supported by the many citations I've included inline, but always good to have a second set of eyes :)


Release 0.3.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


Addition of yml file is not triggering any PR creation even though orbs are out of date

I have added this yml file
labels:
  - dependencies
  - circleci
target-branch: Upgrade-Otis-circle-orbs

and I know all of my circle orbs need updating, but no PRs are being created. Please help!

Hi @darrenarbontalis it is our readme that is missing some steps. I will get back to you when we have updated it :)

Sorry for the delay @darrenarbontalis, we will get there in the new year :)

@brondum no probs, I manually upgraded them for now.

It is now ready to use and available to be installed from https://github.com/apps/dependabot-circleci
Please let us know if you have any issues with it :)


C++ syntax highlighting is broken

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:41:20.664Z)
OS Version: Linux x64 4.4.0-57-generic
Extensions:

Extension
Author
Version

githistory
donjayamanne
0.1.2

python
donjayamanne
0.5.5

cpptools
ms-vscode
0.9.3

csharp
ms-vscode
1.6.2

Steps to Reproduce:
Create a.cpp file:
class Foo {
    long Sum() {
        return 1;
    }
    long A() {
        return true ?
            Sum() : 0;
    }
};

class Bar {
};

int main() {
    Bar bar;
    return 0;
}

Expected behavior: both words "class" are highlighted (blue).
Actual behavior: first word "class" is blue, second is gray.

On VSCode 1.9.0-Insider with no C++ extension installed, it works correctly
http://img11.hostingpics.net/pics/725424Capturedecran20170107a135044.png

Moved to Cpp tools repository

@dimmo This was fixed in VS Code 1.9 when they started using the newer atom/language-c (it wasn't a cpptools bug).


Only check unique neighbour IDs

Fixes https://github.com/brainglobe/cellfinder-core/issues/145, at least for me locally.

Works for me. It seems very slow on my machine, but that's possibly linked to https://github.com/brainglobe/cellfinder-core/issues/73#issuecomment-1515285112


Not allowing any Element Upgrade selection

Not allowing any Element Upgrade selection with latest version

Intended. https://github.com/wchill/steamSummerMinigame/commit/c7264e5a2ec3ca8dbb56f17538d71df86afb9b09

I see.  What's the intention for not allowing any?

Not needed anymore.


Prepare Menu and add action based permission checking for routing

@aerinsol I will tag you in two places in the code:

where the MenuItems are defined and their titles and what action based permissions you will need to have to see the menu.
where the routes are defined and what action based permissions you will need to have to see the menu.

Could you check for both if I have put the correct permissions?
This is how the menu looks now in mobile:

This is how the menu looks now in desktop:

 2.0 Prepare Menu and add action based permission checking for routing

@HaGuesto looks ok, but I didn't see in the route protection area anything related to V1 in the area you tagged me in. Is that handled elsewhere?

The v1 routes are defined in dropapp repo. I cannot implement a route protection in this repo for routes that are outside the react app. The only thing I did and can do is to show the links to v1 only if the user has the correct action based permissions.

@aerinsol I updated the PR according to your request. Could you approve the PR and merge it.
Then you can test it. I especially, would like you to test the transfer menus as<EMAIL_ADDRESS>who does not have permissions for all routes.

@HaGuesto I want to log that I'm force merging as requested, although codecov is complaining about lack of test coverage.


[SPARK-46272][SQL] Support CTAS using DSv2 sources

What changes were proposed in this pull request?

https://github.com/apache/spark/pull/43949 supports CREATE TABLE using DSv2 sources. This PR supports CREATE TABLE AS SELECT (CTAS) using DSv2 sources. It turns out that we don't need additional code changes. This PR simply adds more test cases for CTAS queries.
Why are the changes needed?

To add tests for CTAS for DSv2 sources.
Does this PR introduce any user-facing change?

No
How was this patch tested?

New tests
Was this patch authored or co-authored using generative AI tooling?

No

cc @cloud-fan

LGTM if all tests pass

@cloud-fan the test failure seems unrelated

Can you retrigger the GC jobs?

thanks, merging to master!


Review links to OWASP wiki

Describe the bug
We have references to other OWASP projects in our files:
rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf
28:# https://www.owasp.org/index.php/PHP_Top_5#P1:_Remote_Code_Executionh
366:# https://www.owasp.org/index.php/PHP_Object_Injection

rules/REQUEST-921-PROTOCOL-ATTACK.conf
194:# Reference: https://www.owasp.org/index.php/Testing_for_HTTP_Splitting/Smuggling_(OTG-INPVAL-016)

rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf
97:# https://www.owasp.org/index.php/ModSecurity_CRS_RuleID-96000

CHANGES.md
977:  https://www.owasp.org/index.php/AppSensor_DetectionPoints

rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf
690:# https://www.owasp.org/index.php/Unrestricted_File_Upload

rules/scanners-user-agents.data
58:# https://www.owasp.org/index.php/Category:OWASP_DirBuster_Project

We need to double check they are still valid and update if not.

Hi @fzipi, Would you mind if I take this ticket? I would like to contribute and get more familiar with CRS :)

Not at all, please go ahead!


MISSING ITEM: Ring of Ghoulish Glee

https://www.wowhead.com/wotlk/item=49121/ring-of-ghoulish-glee

Force refresh or restore defaults to see it in Phase 1, if the item is not showing it should appear when Phase is set to 5.


feat(WAKU2-MESSAGE): added meta attribute to waku message

As part of the Message Unique ID initiative, a metadata optional application-specific field has been proposed.

[x] This PR adds the field to the Waku message protobuf definition.

Note
This PR depends on the RFC PR: https://github.com/vacp2p/rfc/pull/573

LGTM
unrelated, but do we plan to include experimental feature fields in this repo? (i.e rln proof field on slot 21)
ref<EMAIL_ADDRESS>
That's a good question. Note this comment in the RFC conversation: https://github.com/vacp2p/rfc/pull/573#issuecomment-1446294482

In case we should need specific data to be associated with a message for relay layer DoS protections, I'd suggest introducing a new field for this.

This is the case for RLN. The RLN relay validator precise a proof Waku message attribute. Maybe that field could be generalized/standardised in a particular manner so it can be used for different purposes.

I would argue that the process would be something like this:

Extract a generic field definition usable for other DoS mechanisms. A generic name (I am not entirely convinced with proof. It sounds too RLN-specific to me), a backwards compatible type (e.g. an optional variable length byte array), and a size limit (we should try to keep Waku message attributes shorter than the payload).
Add it to the Waku message RFC: Add it to the attributes section with its description and finality and the protobuf section as #21. Similar to what I am doing with the meta attribute.
In parallel to the RFC, open the "protobuf PR" (like this one).

I think that this work is worth an RFC issue to track it and have the discussion there.

Merging this PR, as the associated RFC has been approved an merged 😁


DASH + multiple subtitles adaptation sets issue

Have you read the FAQ and checked for duplicate open issues?
Yes.
What version of Shaka Player are you using?
4.2.3.
Can you reproduce the issue with our latest release version?
Not tried.
Can you reproduce the issue with the latest code from main?
Not tried.
Are you using the demo app or your own custom app?
My own app.
If custom app, can you reproduce the issue using our demo app?
Not tried.
What browser and OS are you using?
Chrome 107.0.5304.88 (Build officiel) (64 bits)
Windows Windows 10 Professionnel 21H2
What are the manifest and license server URIs?
Manifest excerpt:
<AdaptationSet
        id="3"
        group="3"
        contentType="text"
        lang="fr"
        mimeType="application/mp4"
        codecs="wvtt"
        startWithSAP="1">
    <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
    <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
    <SegmentTemplate
            timescale="1000"
            initialization="1167569875-1665437344_france-domtom_DRM-$RepresentationID$.dash"
            media="1167569875-1665437344_france-domtom_DRM-$RepresentationID$-$Time$.dash">
        <SegmentTimeline>
            <S t="0" d="10000" r="259"/>
            <S d="2480"/>
        </SegmentTimeline>
    </SegmentTemplate>
    <Representation
            id="textstream_fre=1000"
            bandwidth="1000">
    </Representation>
</AdaptationSet>
<AdaptationSet
        id="4"
        group="3"
        contentType="text"
        lang="fr"
        mimeType="text/vtt">
    <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
    <Role schemeIdUri="urn:mpeg:dash:role:2011" value="subtitle"/>
    <Representation
            id="988352792"
            bandwidth="1000">
        <BaseURL>textstream_fre=1000.webvtt</BaseURL>
    </Representation>
</AdaptationSet>

What did you expect to happen?
As per specification, if several AdaptationSet with the same group are present, ony one should be presented:
https://dashif.org/docs/DASH-IF-IOP-v4.2-clean.htm#:~:text=Only one Representation in a Group is intended to be presented at a time.
So, getTextTracks() should return onyl 1 subtitles track.
What actually happened?
getTextTracks() returns the 2 subtitles tracks.

I can see from your example that the two tracks are equivalent in language, and only differ in format.
This is analogous to video and audio, where you may have the same resolutions/languages available in multiple codecs.
For video and audio, we select a single codec early, because we don't yet have the ability to switch codecs during a presentation.  (See #1528.)  However, that is not the case for text.  Because text stream parsing happens at the JavaScript level, we can switch between text streams without concern for their format or codec.
If we should only return one track in your case, how should we choose?
For audio and video, we introduced some configurations to let applications decide how we choose.  (See preferredVideoCodecs and preferredAudioCodecs under https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.PlayerConfiguration)
Should we introduce a similar config for text?  Something like:
player.configure('preferredTextFormats', [
  'wvtt',  // in MP4
  'text/vtt',  // as text
]);

I'm agree with adding preferredTextFormats if we have the same language, same role, and forced.

Thanks for answering.
I really like the preferredTextFormats option, indeed.
But besides that, the player should choose and present only one text track (maybe the first one?) per group. Is your understanding of the spec different from mine?


Font problems

If i do something like this: Versão
I'll see the text in the app like: Vers?o. Worst than that, every text of the application have this bug, but if i set the text via C#: versao.Text = "Versão";
The text'll be displayed correctly.

You could check the encoding of the xaml file.

I never checked this on the XAMLs, cause i never had trouble. I'll check this right now.

Oh man... it worked! I had to open the files on Notepad and change the encoding from "ANSI" to "UTF-8", thank you!

You are welcome 😊


Super user with disabled/expired projects

When user has SUPER role and has access to only disabled/expired projects should has access to managment page.
The massage is "Project is not enabled"

This error could not be reproduced in v3.0.5


Time out when acquiring locks during transaction setup instead of deadlocking

Rationale
Deadlocking the server is really bad. Similar to how we switched to timing out with an exception when DB connections aren't available from the pool, we can time out when trying to acquire (most) lock objects passed to DbScope.ensureTransaction()
Changes

Time out after 2 minutes of failing to get a lock
Unwind already acquired locks when one fails
New test coverage
Enable test that now seems to pass
More descriptions for loggers

@labkey-adam Indeed. Fixed with my latest commit. I'll kick off the dailies to make sure this doesn't introduce other subtle problems.

https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_DailyPostgres_2/1553901

@labkey-adam I've made a number of followup changes here but they're not as exciting as the original change. Up to you if you want to review again. I'll merge tomorrow if I don't hear objections.

Seem fine to me


Video is not available

🐛 Bug Report
Video is not available after running tests (error while running)
Example on Sauce: https://app.saucelabs.com/tests/b0b16667a0e64d85bf8720139202f214
$ saucectl run

><EMAIL_ADDRESS>test /home/seluser
> DISPLAY="$(cat DISPLAY)" DEBUG="puppeteer:*" jest --config=./.config/jest.config.js --runInBand

cat: DISPLAY: No such file or directory
Watch test: https://chrome-devtools-frontend.appspot.com/serve_file/@ec99b9f060de3f065f466ccd2b2bfbf17376b61e/devtools_app.html?ws=localhost:9222/devtools/page/3FA97E9D36927AF8AFA340BE5EFF9C0F&remoteFrontend=true

PASS tests/example.test.js
  saucectl demo test
    ✓ should verify title of the page (576ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        3.645s
Ran all test suites.

Open job details page: https://app.saucelabs.com/tests/b0b16667a0e64d85bf8720139202f214

To Reproduce
Steps to reproduce the behavior (including the executed commands):
npm i -g saucectl
set Sauce Labs environment variables in terminal
saucectl new (select puppeteer)
saucectl run
Expected behavior
A clear and concise description of what you expected to happen.
Scripts and configuration needed to reproduce this issue (when applicable)
N/A
Environment
OS: Windows 10
Docker version: Docker version 19.03.8, build afacb8b

Hm, looks like this isn't just the video missing, but also other assets as well (logs, commands) 🤔

Any idea? Is the upload part of docker or the saucectl tool?
Von meinem iPhone gesendet

Am 21.05.2020 um 17:40 schrieb Alex Plischke<EMAIL_ADDRESS>
Hm, looks like this isn't just the video missing, but also other assets as well (logs, commands) 🤔
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Unclear at the moment (I assume this is reproducible and not just a one-off?). We know that the upload request was able to reach our webservices and failed there. So there was an attempt to upload the assets. However, the root cause of the failure is currently unclear. This warrants further investigation on our end.
PS: It's also took note of cat: DISPLAY: No such file or directory, which was in the output you posted. It's possible that something failed in the container first, which then caused us to not be able to pickup the assets.

yes, this bug is reproducible always.
here is another sauce result, in case it helps: https://app.saucelabs.com/tests/adc65c422cd04193ab061fbcaaab65a9

Hey @pako88, it's been a while, but could you try this again with the newest available saucectl?

Docker image: saucelabs/sauce-puppeteer:3.0.4
saucectl version 0.6.3
now it didn't upload the results at all
><EMAIL_ADDRESS>test /home/seluser
> DISPLAY="$(cat DISPLAY)" DEBUG="puppeteer:*" jest --config=./.config/jest.config.js --runInBand

cat: DISPLAY: No such file or directory
  console.error
    Unhandled error

      at process.uncaught (node_modules/jest-jasmine2/build/jasmine/Env.js:248:21)

  console.error
    Error: Failed calling listJobs, status code: 404, reason: Not found
        at Request._callback (/home/seluser/node_modules/saucelabs/build/index.js:206:25)
        at Request.self.callback (/home/seluser/node_modules/request/request.js:185:22)
        at Request.emit (events.js:310:20)
        at Request.EventEmitter.emit (domain.js:482:12)
        at Request.<anonymous> (/home/seluser/node_modules/request/request.js:1154:10)
        at Request.emit (events.js:310:20)
        at Request.EventEmitter.emit (domain.js:482:12)
        at IncomingMessage.<anonymous> (/home/seluser/node_modules/request/request.js:1076:12)
        at Object.onceWrapper (events.js:416:28)
        at IncomingMessage.emit (events.js:322:22)

      at process.uncaught (node_modules/jest-jasmine2/build/jasmine/Env.js:249:21)

Watch test: https://chrome-devtools-frontend.appspot.com/serve_file/@ec99b9f060de3f065f466ccd2b2bfbf17376b61e/devtools_app.html?ws=localhost:9222/devtools/page/C80622BCE216F8A2689DCAB8032181EA&remoteFrontend=true

PASS tests/example.test.js
  saucectl demo test
    ✓ should verify title of the page (615ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        3.103s
Ran all test suites.
Error: Failed calling listJobs, status code: 404, reason: Not found
    at Request._callback (/home/seluser/node_modules/saucelabs/build/index.js:206:25)
    at Request.self.callback (/home/seluser/node_modules/request/request.js:185:22)
    at Request.emit (events.js:310:20)
    at Request.EventEmitter.emit (domain.js:482:12)
    at Request.<anonymous> (/home/seluser/node_modules/request/request.js:1154:10)
    at Request.emit (events.js:310:20)
    at Request.EventEmitter.emit (domain.js:482:12)
    at IncomingMessage.<anonymous> (/home/seluser/node_modules/request/request.js:1076:12)
    at Object.onceWrapper (events.js:416:28)
    at IncomingMessage.emit (events.js:322:22)
npm ERR! Test failed.  See above for more details.


chore: update fitactivity README.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3b3ebec) to head (b35373c).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #404   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           41        41
  Lines         3691      3691
=========================================
  Hits          3691      3691

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Testing against multiple redis-stack versions

Codecov Report
Patch and project coverage have no change.

Comparison is base (a39b818) 93.27% compared to head (25808e7) 93.27%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   93.27%   93.27%
=======================================
  Files          77       77
  Lines        4582     4582
  Branches      424      424
=======================================
  Hits         4274     4274
  Misses        186      186
  Partials      122      122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


div overflowing fix and others...

Fixed div overflowing causing it to be scrollable and centered credit text.
also is there a reason why embedded style sheets are not used and rules are directly specified in html?

The reason that style sheets aren't used, is that the CSS style has been quite minimal for a long time. We could move the style to a CSS sheet now.
The code looks good to me! I'll test it locally when I get home, but I think it'll work fine.

Though the links definitely look nicer on desktop and mobile, they may overlap on some devices. The iPhone 6/7/8 with iOS 11 has this issue on landscape mode, for example - most smartphones and tablets experience this issue in landscape mode.
Could you make it so the user has to scroll down to the credits if their screen has this problem?

Oh, 😳 my bad, forgot to check responsiveness, not home right now will open a PR implementing fix soon.

Are you home yet? 😉


Attempt to fix performance issue on CI runners

DO NOT MERGE YET
MacOS and Windows CI runners / tests are taking ~4x as long as the Linux tests do.
For MacOS there is already an issue that reflects the numbers we get (https://github.com/actions/runner-images/issues/1336) but to make sure that it is not us, removing the lines to install numpy < 2 for Windows and MacOS helps to debug.

With https://github.com/huggingface/transformers/pull/35236 merged this is no longer needed.