update for 1.9.6

1.9.6 deprecates Directory and Path in favor of a more robust API, this PR updates to use this new API
Added an example in classic warrior behavior how to buff battle shout which was previously broken
Added tests for the new fs API

I vote no


[5.3] Trying to fix issue: Alias in delete makes invalid query #18085

Something like this can solve Issue #18085
For master-branch see https://github.com/puggan/framework/tree/delete_18085

Bug is not clearly explained and this would need unit tests. Please re-submit with those two things if possible.


forbidden error

Hello, I am receiving forbidden errors when testing EDR endpoints with the mvision_edr_creds_generator client and secret.
Does anyone know if the creds generator will work with the developer portal APIs https://www.mcafee.com/enterprise/en-us/solutions/mvision/developer-portal.html?

Hi eldawt,
You have to use the --preprod switch to generate credentials to the dev environment.

Hi eldawt,
You have to use the --preprod switch to generate credentials to the dev environment.

Thank you for your reply msilvaca-trellix, I am testing in a US west tenant that is production when I receive the errors.

I may need to use the credentials created via API Access Management instead of the mvision_edr_creds_generator


⚠ Samsung has degraded performance

In 9bcedc1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2222 ms

Resolved: Samsung performance has improved in 7f6b250.


Make genetic demultiplexing optional

Genetic demultiplexing is a slow and expensive process, as it requires full alignment and SNP calling in multiple bulk samples and each multiplexed library. So we should have the ability to skip it if it has already been completed for a particular library.
To do this we can follow the patterns of https://github.com/AlexsLemonade/scpca-nf/pull/77 and https://github.com/AlexsLemonade/scpca-nf/pull/87.
While it might be nice to save the intermediate alignments to save the most costly step, unfortunately that is not a good option, as those alignments will contain patient genetic data that we do not want to keep long term. So we will be limited to repeating the whole genetic demultiplexing process in an all-or-none fashion. I expect we will want to make that a separate flag from the normal mapping: I can imagine we might want to remap RNA with a new salmon version, but don't want to do a full realignment with STAR.

Closed by #102.


Upgrade to Babel 7

Babel 7 is required to build the upcoming versions of React Native,
while still compatible with the current version.
This PR consists of:

Upgrade babel-core. The next version has changed names, so
use the different package.
Upgrade babel-preset-react-native
Change generate-webview-js script to use Babel 7.

Hmm, do you know what the story is with the test failures? We should fix those, obviously.
 FAIL  src/events/__tests__/eventActions--test.js
  ● Test suite failed to run

    Plugin 0 specified in "/home/greg/z/mobile/node_modules/babel-preset-react-native/index.js" provided an invalid property of "default" (While processing preset: "/home/greg/z/mobile/node_modules/babel-preset-react-native/index.js")

      at Plugin.init (node_modules/babel-core/lib/transformation/plugin.js:131:13)
      at Function.normalisePlugin (node_modules/babel-core/lib/transformation/file/options/option-manager.js:152:12)
      at node_modules/babel-core/lib/transformation/file/options/option-manager.js:184:30
          at Array.map (<anonymous>)
      at Function.normalisePlugins (node_modules/babel-core/lib/transformation/file/options/option-manager.js:158:20)
      at OptionManager.mergeOptions (node_modules/babel-core/lib/transformation/file/options/option-manager.js:234:36)
      at node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:14
      at node_modules/babel-core/lib/transformation/file/options/option-manager.js:323:22
          at Array.map (<anonymous>)
      at OptionManager.resolvePresets (node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20)

Also, since we're changing the behavior of generate-webview-js, it's important that we rerun it and update the file it generates -- otherwise we risk a surprise when we eventually do rerun it.
It looks like last week's commits editing js.js neglected to do that :-/ -- I'll go take the update and test a bit. Fortunately the edits were all pretty small and intended to have no real effect on behavior, so hopefully nothing's affected.

I would rebase this at RN 0.57 as a bit complicated to implement separately.

This was added to #2955
Closing this PR.


OCPBUGS-31725: include hostnetwork SCC CPO role for 4.13 and earlier

/jira refresh

/cherry-pick release-4.15


[FEATURE] security_authentication cookie lacks SameSite attribute

During proxy authentication flow, the security_authentication cookie lacks SameSite attribute.
A warning is emitted by the Console browser tab:

What solution would you like?
Would it be possible to set SameSite to 'Strict' or make it available as a parameter ?
What alternatives have you considered?
This is warning. So that's OK.

Hi, this is configurable today. Have you tried adding opensearch_security.cookie.isSameSite: Strict  to opensearch_dashboards.yml file and restarting dashboards?


Change case M_cli, M_cli2

Fixes error
Dependency name 'M_CLI' found, but expected 'M_cli' instead
Dependency name 'M_CLI2' found, but expected 'M_cli2' instead

This is a minor correction to the registry so I'll merge.


Calico for OpenStack needs Python 3 support in order to run with Stein release and later

Calico neutron plugin is missing python3 support.
Since Openstack Stein release (which already moved to python3) calico plugin is unavailable and not supported to work with neutron.
Reference: https://bugs.launchpad.net/pypi/+bug/1856485
Best,
Vasili

Thanks @vasilinamatov for tracking this here.  I'll move the error log down here:

ERROR neutron.manager [-] Plugin 'calico' not found

and update the title to reflect the underlying Python 3 issue.

The following error is an issue so I added it under issue subject.
Now you changed the subject to what should be done in order to fix the issue. So not sure that you suggested subject is really convenient. Anyway, its upon you how to track the issues.
Thanks anyway.
Best,
Vasili

For search engines its great to have this error available.
ERROR neutron.manager [-] Plugin 'calico' not found

@vasilinamatov I believe this issue has now been addressed by https://github.com/projectcalico/networking-calico/pull/25.  Please let me know of any further issues!


Projection queries fail with no error information.

The code:
            Query query = new Query("Task")
            {
                Projection = { "priority", "percent_complete" }
            };
            // [END projection_query]
            Assert.IsFalse(IsEmpty(_db.RunQuery(query)));

The error:
Test Name:	TestProjectionQuery
Test FullName:	GoogleCloudSamples.DatastoreTest.TestProjectionQuery
Test Source:	C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\datastore\api\DatastoreTest.cs : line 491
Test Outcome:	Failed
Test Duration:	0:00:01.2299546

Result StackTrace:
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Grpc.Core.Internal.AsyncCall`2.UnaryCall(TRequest msg)
   at Grpc.Core.Calls.BlockingUnaryCall[TRequest,TResponse](CallInvocationDetails`2 call, TRequest req)
   at Grpc.Core.DefaultCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)
   at Grpc.Core.Internal.InterceptingCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)
   at Google.Datastore.V1Beta3.Datastore.DatastoreClient.RunQuery(RunQueryRequest request, CallOptions options)
   at Google.Api.Gax.ApiCallExtensions.<>c__DisplayClass0_0`3.<MapArg>b__0(A a, CallSettings callSettings)
   at Google.Api.Gax.ApiCallRetryExtensions.<>c__DisplayClass1_0`2.<WithRetry>b__0(TRequest request, CallSettings callSettings)
   at Google.Api.Gax.ApiCallExtensions.<>c__DisplayClass0_0`3.<MapArg>b__0(A a, CallSettings callSettings)
   at Google.Api.Gax.ApiCall`2.<>c__DisplayClass6_0.<Sync>b__0(CallSettings callSettings)
   at Google.Api.Gax.ApiCall`2.Call[T](TRequest request, CallSettings perCallCallSettings, Func`2 fn)
   at Google.Api.Gax.ApiCall`2.Sync(TRequest request, CallSettings perCallCallSettings)
   at Google.Datastore.V1Beta3.QueryStreamer.<Sync>d__7.MoveNext()
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Linq.Enumerable.<SelectManyIterator>d__16`2.MoveNext()
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at GoogleCloudSamples.DatastoreTest.IsEmpty(DatastoreQueryResults results) in C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\datastore\api\DatastoreTest.cs:line 349
   at GoogleCloudSamples.DatastoreTest.TestProjectionQuery() in C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\datastore\api\DatastoreTest.cs:line 499
Result Message:
Test method GoogleCloudSamples.DatastoreTest.TestProjectionQuery threw exception:
Grpc.Core.RpcException: Status(StatusCode=FailedPrecondition, Detail="")

Right - I suspect this is due to the fields not being indexed. I see the same thing in my snippets. There are three issues here:

I haven't explicitly marked the fields as unindexed, so based on the documentation I'd expect it to be okay.
The RPC exception doesn't have any detail
There's no way of configuring the index through the API as far as I can tell, which is a bigger issue

Will raise these internally with the Datastore team - we can't really address any of them in the client library.

The error message is now included:
Detail="no matching index found. recommended index is:
- kind: Task
  properties:
  - name: percent_complete
  - name: priority
"


Manases -> AutoMapper added, BookRepository completed, InMemory data added for testing, three endpoints (get all, get by id, and create)

A few changes added to the BookService:
BookService:
Book repository added
InMemory data for testing instead of using database
3 endpoints added to the book controller (get all, get by id, post/create)
OrderService
SQL relationships using EntityFrameworkCore

Thanks for the review, fixed, let me know if anything else is needed


Types of Multicall are incorrect

https://github.com/yjl9903/naria2/blob/8383183d3d8ad61f43c8a966115045e020a8f88e/patches/maria2%400.3.2.patch#L25-L31
I have forgotten what is wrong here 😂, but I did some patches to make it more make sense.

It seems that the response structure of multicall is wrong.
It'll be check this Sat and be fix. :) @yjl9903


Liza/display correct question counts

This addresses two separate issues.
The first, which affects files app/assets/javascripts/qsets.js and app/views/questions/show.html.erb, makes it possible for users to now vote on the quality of a question directly after answering it, instead of restricting this functionality to the qset view. The functionality was previously tested by Katherine as part of a previous PR that was not incorporated.
The second, which affects files app/controllers/qsets_controller.rb and app/models/qset.rb, addresses a bug that prevented a particular qset's question count from being correctly updated and displayed if the type of its subsets were later altered. For instance, if a qset was of type "questions" and was later changed to type "subsets," it now doesn't include its former questions in its new question count. See trello card: https://trello.com/c/CnSZaVAG/509-display-correct-question-counts

Great work! I found a few bugs.
1.The question count doesn't update properly when a question is added to a qset of either type 'questions' or 'mixed' when its parent qset is of type 'subsets' and that parent's parent qset is of type 'subsets'. If the parent qset is changed to type 'mixed', then the parent's parent qset doesn't display the correct question count anymore.

Let's say you have a qset 'Biology' of type 'subsets'. Inside Biology you have a qset 'Population Ecology' of type 'Mixed'. In this qset, you have a qset 'Population Ecology Subset 1' of type 'Mixed'. In this qset 'Population Ecology Subset 1', let's say you have one question. When you go back up to check the question counts, 'Biology', 'Population Ecology', and 'Population Ecology Subset 1' all correctly say 1. However, if you change the qset_type of 'Population Ecology' to 'questions', then if you go to check the question counts, for 'Population Ecology' it says 1–even though it should say 0 since the user can no longer see the question in subsets of 'Population Ecology' (i.e., it should say 0 since there are no questions immediately within the qset 'Population Ecology'). For 'Biology', however, it correctly displays 0. This may or may not be affected by bug 3 below.

For some reason, there are inheritance issues where if I change the qset_type through the edit qset modal, its children also adopt this new qset_type. Hopefully this is because you haven't incorporated my updated code for how qset types are edited and initiated (it used to be inherited from parent qsets but I changed it to default to 'questions' if the user didn't choose a particular qset_type when they first created the qset). This may or may not affect your code.

See if you can recreate some of the bugs I came across and let me know if you have any questions!

I also left a small comment on your code if you go to the 'Files changed' tab above.

Looking into @rckim77's issues.

I could not reproduce this.

I found a couple of things that were making stuff go wonky. The first is a Ruby thing:

0> 'a' == 'a'
=> true

0> 'a' == 'b'
=> false

0> 'a' == ('a' || 'b')
=> true

0> 'a' == ('b' || 'a')
=> false

wha?... indeed Ruby just appears not to work this way. Instead, use:
0> ['a', 'b'].include?('a')
=> true

0> ['b', 'a'].include?('a')
=> true

Hence, this line can be changed to:
if ['mixed', 'subsets'].include?(child.settings(:permissions).qset_type)

The second was that the grandchildren (i.e. children of the immediate children of the qset#show's @qset) are always checked, regardless of the type of their parent (i.e. one of the immediate children of the qset#show's @qset).
So, showing qset hierarchy below, where for each qset XY X=(Subset|Mixed|Questions) (type) and Y=its level relative to the root of the tree:
S1
  Q2
    M3
    Q3

If you're getting qset counts for level 1, this line in conjunction with this line were ensuring that grandchildren of level 3 were always being checked, even though S1's immediate child Q2 was of type Q.
Whew... anyways, here's a naive fix:
  def question_count_descendants
    if ['mixed', 'subsets'].include?(self.settings(:permissions).qset_type)
      [self] + question_count_descendants_helper
    else
      [self]
    end
  end

There might be other ways to restructure the algorithm to make it more compact, but I tested this (probably not as thoroughly as @rckim77!) and it seems to work.

From what I can understand from #78 , new qsets do not inherit from parents, but if you edit an existing qset's properties, all of its settings will propagate to all of its descendants. I don't think #78 changed that behavior, so I don't believe there's anything unusual happening in this PR #83. (Please do point out if I'm missing something @rckim77!)

Great work, and great review @rckim77 ! When the algorithm is fixed up, I think this is good to move.

👍


MFA not working

I am not able to authenticate with MFA I get the
{"mfa_type":"app","mfa_required":true}
response when I provide just my username and password but when I add the mfa_code value I am getting a 500 server error.
is there something I have to do to the 2FA auth value before I pass it?

MFA only working with SMS right now.


Issue with Android Phones - Scrambled canvas

Please make sure you are testing with the latest release of html2canvas.
Old versions are not supported and issues reported for them will be closed.
Please follow the general troubleshooting steps first:

[x] You are using the latest version
[ ] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console
[x] NPM version

Bug reports:
It works great on Desktops / Laptops, iPads, Android Tablets (only tested on Android v11), but not on Android Phones (v8, v10, v12).
Using a different browser doest not seem to affect it at all, it seems to me it is an Android version thing or even a device thing (meaning Android phones)
Canvas contents gets scrambled, like in this print preview:

What we pass to the library is this:

The logo image is not there, but it's ok.
Nothing on the console.
Specifications:

html2canvas version tested with: 1.4.1 and 1.3.2
Browser & version: Android 12, Chrome 107; Android 10, Chrome 89; Android 8, Chrome 101;
Operating system: Android for phones; Not happening on Android 11 tablet.

+1


Fix issues when connecting to PS 2018

Fixing the following issues:

CreateNewInstance won't work if you don't specify the maximum version that you want to use
CreateNewInstance won't work using the following version formats "2018.0" or "2018.0.0"
Updated Unit tests to ensure that there were no issues connecting to PS 2018 no matter if:

Using CreateNewInstance, UseExistingInstance or CreateSingleInstance
Maximum version was not specified
version format was "2018.0.0" or, for instance,"18.1.0"

I've confirmed that this fixes the issues I encountered. 👍


[8.x] Add whenWhere method to query builder

🤞🏽  This feature gives the option to limit the possibilities of writing duplicate conditional where query codes.
Redundant
Model::when($user_id, fn ($q) => $q->where('user_id' $user_id)
  ->when($status, fn ($q) => $q->where('status' $status)
  ->when($type, fn ($q) => $q->where('type' $type)
  ->when($conversation_id, fn ($q) => $q->where('conversation_id' $conversation_id)

Better
Model::whenWhere([
  'user_id'           => $user_id,
  'status'            => $status,
  'type'              => $type,
  'conversation_id'   => $conversation_id
])

I hope this feature will be useful for artisans.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Overriding Core Nodejs Module Types

I began trying to write types for Node's tls module. This file was within types/tls.js which .flowconfig used under its [libs] block.
However, I was unable to actually leverage my types:
lib/test.js
/* @flow */
import * as TLS from 'tls'

TLS.connect({ host: 'localhost', port: 9000 })

$ flow
lib/test.js:13
 6: TLS.connect({ host: 'localhost', port: 9000 })
        ^^^^^^^ property `connect`. Property not found in
 6: TLS.connect({ host: 'localhost', port: 9000 })
    ^^^ module `tls`

Found 1 error

@jeffmo noted that Flow ships with types for Node's core modules and hence perhaps causing the user's declarations to be somehow overridden.
If @jeffmo is correct then I would suggest a patch that inverses this relationship somehow, such that users can have the final say on type declarations. Even if tls was not an empty TODO, a user may wish to update / improve / change the types to their liking. I'm not saying its likely, but it should be possible.

Indeed this seems to be a conflict between the built-in TODO and the user-defined version here.
We should fix this, but a workaround that might get you unblocked in the meantime might be to copy the built-in flow libs from here in to your own project's library directory, erase (or update) the offending conflicts in your copy of those libs, and then use flow --no-flowlib to omit all built-in libraries when checking.

a workaround that might get you unblocked in the meantime might be to copy the built-in flow libs from here in to your own project's library directory, erase (or update) the offending conflicts in your copy of those libs, and then use flow --no-flowlib to omit all built-in libraries when checking.

@jeffmo Thanks for this stopgap. I admit it made me wince : ) but such is life. I will report back upon trying.

I'm reminded of an old XP maxim, "if something is hard, do it more often." I think it's time we removed the dom, node, and react libs out of the default flowlib and just keep core. We'll be forcing users to pull in the libs they need, so we need to find some way to make that less painful.
We need to do it eventually, because APIs change—React 0.14 is upon us, and it should have it's own separate declaration file. Node's API will change, too. We might want to have separate declaration files for different versions of the DOM API, too. Making this stuff opt-in will open the door to all that, we just need to make it convenient.

@samwgoldman :+1: I just ran into a function that is present in Node v0.12 but gone in v4.1 and was curious about the future of the lib files.
Do you see Flow maintaining and shipping these libraries still?

@samwgoldman: For things like React, yea that's ultimately the goal. We need a way for those libs to ship their own interface definitions first, though (DefinitelyTyped really isn't ideal because it isn't coupled/versioned alongside the library itself...). Fortunately @gabelevi is working on this featureset (ability to publish interface defs alongside a library and have Flow understand this trivially).
As for libdefs for various common environments (Node, DOM, etc) -- I actually thing we should include these with Flow and just allow the user to specify which of them they want (opt-in?) in their .flowconfig options. These are just so pervasive there's very little chance that you want neither of them in most projects.
In any case, though, we should probably warn if a user's lib defs collide with some built-ins.

I agree that we can continue to include the node/dom lib defs with Flow. We just shouldn't load them by default, and ideally we should provide versions as you hinted at. I agree that .flowconfig is a reasonable place for that.

@jeffmo et al: How does one start flow (server) with --no-flowlib? I see flow check --no-flowlib but not flow --no-flowlib.

I was wondering about moving the node libdefs out of flow and found my way to this issue.
It would be nice if there was an easy workflow for importing various external lib def(s) as npm package(s) and configuring their use in a project. Babel's plugin's and presets come to mind here. This would make it easier to have different libdef versions matching different underlying versions (node 0.12 vs 4.x vs 5.x) and would enable competing libdefs with different approaches (more/less strict).

We hit a similar issue.  The frustrating part is that flow is silent about the module name conflicts.  We found out the hard way that flow is ignoring our type definitions in [libs] when there is a module with the same name (but no flow types) in /node_modules/.
Flow should be very vocal about ambiguities such as this.

Looks like my previous comment is being handled under #676 :)

In case anybody finds this issue, the workaround that I'm using until there's a real solution for this:
a file without the // @flow annotation, say src/unchecked.js:
export { mkdtempSync } from 'fs';

then I can import from there:
import { mkdtempSync } from './unchecked';

//...
let tmpdir = mkdtempSync(prefix);

Hope it helps.

If you want to change the Node.js type definitions you can contribute to Flow or use Flow without the builtin libdefs. We hope to move the builtin libdefs to flow-typed at some point where they will be easier to contribute to 😊


Zoom Slice views independently from 3D view

Hi,
I would like to be able to zoom and interact with each 2D slice views without the 3D view adapting to what I do. Especially when zooming I don't want the 3D part to get automatically clipped.
It would be helpful to know if I can either completely disable that, or if I can manually change parameters in the JSON to override that behaviour?
Thanks

Normally, when you opt to show the cross sections in the 3d view, the cross sections are exactly what is shown in the separate cross section views.
However, through the JSON state and Python API you can add additional cross sections to the 3d view that are decoupled from any cross section views:
https://github.com/google/neuroglancer/blob/master/python/examples/example_cross_section.py


Project Console - Github organizations are not displayed in any particular sort order

Background

Launch https://project.dev.lfcla.com
Login as Project Manager
Click on Academy Software Foundation
Data in Github Organization section are not sorted in any particular order

Verified that github organizations are sorted in alphabetical order

@dealako Verified and working fine now.

The old v1 console is deprecated and removed.


Can't make detach() work

      ODatabaseDocument db = new ODatabaseDocumentTx("remote:localhost/Run");
      ODocument d;
      try {
         db.open("admin", "admin");
         d = new ODocument("User");
         d.field("name", "phoebe");
         d.save();
         d.detach();
         //d.deserializeFields(d.fieldNames());
      } finally {
         db.close();
      }
      System.out.println(d.toJSON());

This does not work. Although, if I comment the d.detach(); line, and uncomment the line below, it works.
What am I doing wrong?

Wich version? (Please report ALWAYS version to avoid such message)

It was 2.0-rc1. I've updated, and it works.
Sorry.

In this case, neither commented lines work.
      ODatabaseDocument db = new ODatabaseDocumentTx("remote:localhost/Demo");
      List<ODocument> resultList;
      try {
         db.open("admin", "admin");
         resultList = db.command(new OSQLSynchQuery<ODocument>("select from User limit 10")).execute();
         for (ODocument d : resultList) {
            //d.deserializeFields(d.fieldNames());
            //d.detach();
         }
      } finally {
         db.close();
      }
      for (ODocument d : resultList) {
         System.out.println(d.toJSON());
      }

com.orientechnologies.orient.core.exception.ODatabaseException: Database instance is not set in current thread. Assure to set it with: ODatabaseRecordThreadLocal.INSTANCE.set(db);
	at com.orientechnologies.orient.core.db.ODatabaseRecordThreadLocal.get(ODatabaseRecordThreadLocal.java:52)
	at com.orientechnologies.orient.client.remote.OSBTreeBonsaiRemote.firstKey(OSBTreeBonsaiRemote.java:230)
	at com.orientechnologies.orient.core.db.record.ridbag.sbtree.OSBTreeRidBag$SBTreeMapEntryIterator.init(OSBTreeRidBag.java:483)
	at com.orientechnologies.orient.core.db.record.ridbag.sbtree.OSBTreeRidBag$SBTreeMapEntryIterator.<init>(OSBTreeRidBag.java:417)
	at com.orientechnologies.orient.core.db.record.ridbag.sbtree.OSBTreeRidBag.rawIterator(OSBTreeRidBag.java:524)
	at com.orientechnologies.orient.core.db.record.ridbag.ORidBag.rawIterator(ORidBag.java:152)
	at com.orientechnologies.orient.core.fetch.OFetchHelper.processRecordRidMap(OFetchHelper.java:143)
	at com.orientechnologies.orient.core.fetch.OFetchHelper.fetch(OFetchHelper.java:70)
	at com.orientechnologies.orient.core.serialization.serializer.record.string.ORecordSerializerJSON.toString(ORecordSerializerJSON.java:327)
	at com.orientechnologies.orient.core.serialization.serializer.record.string.ORecordSerializerStringAbstract.toString(ORecordSerializerStringAbstract.java:665)
	at com.orientechnologies.orient.core.record.ORecordAbstract.toJSON(ORecordAbstract.java:192)
	at com.orientechnologies.orient.core.record.ORecordAbstract.toJSON(ORecordAbstract.java:188)
	at ...

I assume it's because of the edges linked to these records. detach() does not work in these situations?
Here's an example of what a user looks like in my db.

      ODatabaseDocument db = new ODatabaseDocumentTx("remote:localhost/Demo");
      ODocument user;
      try {
         db.open("admin", "admin");
         List<ODocument> resultList = db.command(new OSQLSynchQuery<ODocument>("select from User limit 1")).execute();
         user = resultList.get(0);
         user.detach();
      } finally {
         db.close();
      }
      for (String s : user.fieldNames()) {
         System.out.println(s);
      }

This shows the fields were detached. But if any of those fields is an ORidBag, I can't do nothing with it.

Detaching a ridbag with remote connection could mean loading millions of items on the client side. Now detach() works only with plocal connections. You could rather avoiding using bonsai in ridbag by setting this option at client and server sides:
-Dindex.embeddedToSbtreeBonsaiThreshold=-1

But huge edge collection will be much slower.

I don't want to detach the records inside ORidBag.
I would like to know the size of the ORidBag, the RID's inside, ... but it seems I can't.
Thanks @lvca :)

I think this is not supported out of the box, sorry.

@lvca Is it possible to detach only one depth-level?

Nice feature to have :-) Please, could you open a new issue for that?

#3482
Don't know if it's understandable.


"Open with atom" context menu action should not open a new instance of the editor

Using the "Open with atom" context menu shortcut, it can be a little frustrating when a new instance of atom has to start up just to see the contents of a file. True, i could drag the file into the current editor window, but usually i'm on another screen, or in a foreground explorer window somewhere... Seems to make sense that opening a new editor should happen via this context menu action (and should continue to be a user action from within atom or from the taskbar/application icon).
i'm writing of the behavior as it is in Windows 8 (Atom 1.12.7). i'm not sure if this behavior is the same on other OS's. Also, the system settings for enabling the context menu should all be checked on:

Current Behavior (using the "Open with atom" context menu):

Open a file from one directory. Then open another file in a neighboring directory. Notice how the two tabs are within the same editor, but only the contents of the first directory make it into the tree-view:

Open a file or directory in atom. Then open another neighboring/parent/child/or even distant directory. Notice how the target is opened in a new instance of atom:

i realize that this is probably trivial to implement. All that's required is "-a" being inserted into windows registry value for the atom cli interaction. i modified src/main-process/win-shell.coffee and tested a build... and it works.
Suggested Behavior (using the "Open with atom" context menu):

Thank you for your submission!
I have passed along the information to the maintainers team, for review after the holidays have passed. Because we treat our issues list as the Atom team's backlog, we close feedback issues after passing along the information to the maintainers to keep our backlog clean and focused.
I've also referenced this in our tracking issue #10517 where we're collecting various problems with Atom's launch story in general to make future improvements.


Feature request - view number of imports for a package

When looking at a package it would be helpful to be able to see what packages import the respective package.
Why ?
So I can see examples of the package being used.
So I can see how popular a package is.
The same functionality exists in golang with godoc, and I feel it's worthwhile.
I would prefer this to be implemented at the web GUI level.
Please let me know if there are any questions.

You can use dependency:pkg_name in the search field to list/search the packages that depend on the package. (soon a change will be deployed: dependecy*: will list all of the transient dependents, while dependency: will list only the ones directly referenced in pubspec.yaml).


Added ABI test with components

This change is

change target

crates/cairo-lang-starknet/src/plugin/plugin_test_data/contracts/upgradable_counter line 181 at r1 (raw file):
Previously, orizi wrote…
Why?

reverted


[UI] Applications, fix number of commits for GitLab source

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

There is only one commit displayed
The list of commits is displayed very slowly

Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS:
- Architecture:
- Epinio Version:
- Cluster:
  - Provider:
  - Options:
  - Kubernetes Version:

Logs
No response
Anything else?
No response

closing, will be tested as part of https://github.com/epinio/ui/issues/173


Fix centering in Body#setSize()

This PR

Fixes a bug

When calling Body#setSize(…, center = true) for a scaled sprite, the calculated offset was wrong.
https://codepen.io/samme/pen/ZEYZJBa

👍

This pull request has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/how-to-move-sprite-and-his-body/6055/9


docs(GeoSearch): add height requirement

On the element that contains the map, in our case .ais-geo-search--map.


LLVM Patch Error

Hi! I am installing Legion with GPU configuration with the following command on Slurm:
# Module loads
ml gnu7/7.3.0 pmix/2.2.2 intel/python/2019-3.6.8 cuda/10.2 openmpi3/3.1.0
# Build config
export CONDUIT=ibv
export CC=gcc
export CXX=g++
# Path setup
export LEGION_DIR=~/codes/legion
export HDF_ROOT="$LEGION_DIR"/language/hdf/install
export HTR_DIR=~/codes/HTR-solver
# CUDA config
export CUDA_HOME=/usr/local/cuda-10.2
export CUDA="$CUDA_HOME"
export GPU_ARCH=kepler
# Legion setup
export USE_CUDA=1
export USE_OPENMP=1
export USE_GASNET=1
export USE_HDF=1
export MAX_DIM=3

mkdir -p ~/codes && cd ~/codes
git clone -b control_replication https://gitlab.com/StanfordLegion/legion.git "$LEGION_DIR"
git clone https://github.com/stanfordhpccenter/HTR-solver.git "$HTR_DIR"

cd $LEGION_DIR/language
srun -p gpu scripts/setup_env.py --llvm-version 38 --terra-url 'https://github.com/StanfordLegion/terra.git' --terra-branch 'luajit2.1'

However, I am encountering the following error:
make[3]: Leaving directory `/home/darve/adncat/codes/legion/language/gasnet/release'
make[2]: Leaving directory `/home/darve/adncat/codes/legion/language/gasnet/release'
make[1]: Leaving directory `/home/darve/adncat/codes/legion/language/gasnet/release'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15.7M  100 15.7M    0     0  11.3M      0  0:00:01  0:00:01 --:--:-- 11.3M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 9380k  100 9380k    0     0  13.1M      0 --:--:-- --:--:-- --:--:-- 13.1M
Traceback (most recent call last):
  File "scripts/setup_env.py", line 456, in driver
    install_llvm(llvm_dir, llvm_install_dir, scratch_dir, llvm_version, llvm_use_cmake, cmake_exe, thread_count, cache, is_cray, insecure)
  File "scripts/setup_env.py", line 274, in install_llvm
    apply_patch(llvm_source_dir, os.path.join(os.path.dirname(os.path.realpath(__file__)), 'llvm-3.8-gcc.patch'))
  File "scripts/setup_env.py", line 88, in apply_patch
    subprocess.check_call(['patch', '-p%d' % strip_levels, '-i', diff_path], cwd=dest_dir)
  File "/opt/ohpc/pub/compiler/intel-19/intelpython3/lib/python3.6/subprocess.py", line 306, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/opt/ohpc/pub/compiler/intel-19/intelpython3/lib/python3.6/subprocess.py", line 287, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/opt/ohpc/pub/compiler/intel-19/intelpython3/lib/python3.6/subprocess.py", line 729, in __init__
    restore_signals, start_new_session)
  File "/opt/ohpc/pub/compiler/intel-19/intelpython3/lib/python3.6/subprocess.py", line 1364, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'patch': 'patch'

I am not sure what to do at this point, any help would be appreciated. Thanks!

Looks like you somehow don't have patch in your path?  What does
which patch

say on that system?

Yes it is not in my path. Is this a package that I should install myself on Slurm?

patch is a standard tool that usually lives in /usr/bin.  What kind of system are you running on?

Here are the system info:
Linux yellowstone-login-0-2 3.10.0-693.el7.x86_64 #1 SMP Tue Aug 22 21:09:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
It looks like there is no patch in usr/bin,
[adncat@yellowstone-login-0-2 bin]$ which patch
/usr/bin/which: no patch in (/opt/ohpc/pub/compiler/gcc/7.3.0/bin:/opt/ohpc/pub/compiler/intel-18/compilers_and_libraries_2018.2.199/linux/bin/intel64:/opt/ohpc/pub/compiler/intel-18/compilers_and_libraries_2018.2.199/linux/mpi/intel64/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/home/darve/adncat/.local/bin:/home/darve/adncat/bin:/home/darve/adncat/julia-1.5.0/bin)

I will ask the system manager about this issue then. Thanks!

Can this be closed?

Yes, I am closing this issue. Thank you.


react/promise 3.0 support?

Hi, are there any plans to support react/promise 3.0?

Hi, in short: yes.

0.5 will stick to promise v2 while 0.6 will go with promise v3 only. It's not ideal, tried to get v3 into 0.5 but due to the way v3 works it's not compatible with 0.5.


Mongo index

Collection.findOne({ 'key' : key });
Might be good to do an ensureIndex call for key.

I actually tried to do that, specific to text indexes but when I last tried it was a feature not supported with the current MongoDB version.

From what I understand, Mongo "text" indexes are for searching:
http://docs.mongodb.org/manual/core/index-text/
findOne({ 'key' : key }) is a regular query, not a search query, so it would benefit from a regular index?

Oh sorry, I just confused two repositories. I think that's a good idea. I'll let this open and add the call ensureIndex for the key field soon-ish.


listing tables and columns

closes #76

:books: Documentation preview :books:: https://jupysql--95.org.readthedocs.build/en/95/

Exciting feature, tag when ready for review.

ready for review

@edublancas there is a conflict

@edublancas there is a conflict

Review regardless :)

addressed all te comments

returns the error: NoSuchTableError: prices

can you verify the prices column exists in the schema you're passing to the --schema argument? Based on the error, it looks like it's doing the right thing but cannot find the table. I'm surprised this isn't working on postgres since I'm using SQLAlchemy, which should take care of running queries compatible with postgres.

@yafimvo: since you're running the CREATE TABLE without an explicit schema, it'll still create it in the default schema (not in the test_schema schema). I verified this works on postgres when doing CREATE TABLE test_schema.names
however, this helped me realize that %sqlcmd tables didn't allow users to select a custom schema, so I added a --schema option. pushed


Storage/Datalake test coverage improvement

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

Mark changed test cases as LIVEONLY temporarily to wait for test records.

/azp run cpp - storage


otel.SetMeterProvider(pusher.MeterProvider()) no longer works

otel.SetMeterProvider(pusher.MeterProvider()) no longer works
for golang demo

Documentation need to be modified.

I found this issue as well. I think you can now import go.opentelemetry.io/otel/metric/global and then use global.SetMeterProvider(...)`. I'm learning but the context of a "global" package makes sense. Seems like the API shifted.

Posted what I hope is a fix here https://github.com/open-telemetry/opentelemetry.io/pull/625

Thanks so much. It works now.


Dimensionality when creating AnalogSignalArray from list of AnalogSignal

I'm somewhat new to python, so it's possible that I'm missing something obvious. The Neo.IO Axon data conversion returns blocks of AnalogSignals, even though the data are identical length and sampling. So I'm trying to convert this to an AnalogSignalArray. I've tried the following code:
import quantities as pq
import numpy as np

sig1 = nc.AnalogSignal(signal=[100.01, 103.3, 109.3], units='nA',
                     sampling_period=.1*pq.s)
sig2 = nc.AnalogSignal(signal=[100.01, 103.3, 109.3], units='nA',
                     sampling_period=.1*pq.s)
sigarray = nc.AnalogSignalArray([sig1, sig2], units='nA',
                                    sampling_period=1*pq.s)

The result is a 2 second AnalogSignalArray of dimension 3 rather than a 3 second array of dimension 3. So the next attempt is to use numpy to stack the AnalogSignals into a 3x2 array (in order to match the normal AnalogSignalArray constructor syntax).
sigarray = nc.AnalogSignalArray(np.stack([sig1, sig2],axis=-1),
                                    units='nA',
                                    sampling_period=1*pq.s)

This yields the error
ValueError: Unable to convert between units of "dimensionless"                                  and "nA"

I assume this must be because the numpy stack ends up killing the units of the original AnalogSignals but doesn't actually convert them to a generic ndarray. But I'm stumped on how to force that conversion.

I believe I have solved my problem. The key is to first convert the Quantity array returned by np.stack fully to a numpy ndarray. So we need
testsigarray = nc.AnalogSignalArray(np.stack([sig1, sig2],axis=-1).magnitude,
                                    units='nA',
                                    sampling_period=1*pq.s)

It would be nice if stacking AnalogSignals yielded an AnalogSignalArray, so I'll leave this active.


Why do differently public key between pybitcoin and Qt wallet ?

FeathercoinPrivateKey('e2ee135cc175081810bbaa603df551f657c8e8a37aca1321883fc588022f95d6').public_key().to_hex()
the result: 04edb297ba63c35998ec23cfca60666bb4d0d1c3e810b93d2d20c94e3a129774407b719ecf902de8a20c6d99ed0ad0d8c5af178640fdcb0c5dee26c41d39306998
This length is 130.

CPubKey vchPubKey;
pwalletMain->GetPubKey(keyID, vchPubKey)
LogPrintf("addressbookpage vchPubKey=%s\n", HexStr(vchPubKey).c_str());
the result:
02edb297ba63c35998ec23cfca60666bb4d0d1c3e810b93d2d20c94e3a12977440
This length is 65.
secp256k1 tell me , PUBLIC_KEY_SIZE  = 65
Why your public key size is 130 ? How to make it with Qt wallet code ?

They are same between 3 and 65.


[Physics] PhysicsComponent Attach() ignoring existing ColliderShape

Release Type: Latest
Version: Latest
Platform(s): Any
Describe the bug
Quoting sebl on Discord
"Hello,
i'm currently trying to create a physicscomponent from code. although i set a collidershape, it doesn't get added to the component. i think the reason is somewhere here
the NativeCollisionObject is null, so the collidershape doesn't get added.
so, maybe anyone has an idea of what i am missing here?
also, i get this error in the log:
'Entity xyz has a PhysicsComponent without any collider shape'"
so, maybe anyone has an idea of what i am missing here?
also, i get this error in the log:
'Entity xyz has a PhysicsComponent without any collider shape'
To Reproduce
StaticColliderComponent sc = new Xenko.Physics.StaticColliderComponent();
BoxColliderShape bcs = new Xenko.Physics.BoxColliderShape(False, SomeSize);
sc.ColliderShape = bcs;

Once the engine hits PhysicsComponent.Attach It checks for if (ColliderShapes.Count == 0) and returns immediately afterwards without checking for an existing ColliderShape.
Additional context
I'll be taking care of this issue through this PR.

The error still persists. Is there a solution to this?
myEntity.GetOrCreate<StaticColliderComponent>().ColliderShapes.Add(new StaticMeshColliderShapeDesc { Model = myModel });
'Entity Entity has a PhysicsComponent without any collider shape'

Sad that 3 line bug still not fixed after 4 years...

still not fixed


Update README.md with CarsXE API

Added CarsXE API to the Vehicles section.
Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[X] Your submissions are formatted according to the guidelines in the contributing guide
[X] Your additions are ordered alphabetically
[X] Your submission has a useful description
[X] The description does not end with punctuation
[X] Each table column should be padded with one space on either side
[X] You have searched the repository for any relevant issues or pull requests
[X] Any category you are creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

Thanks for contribution @idarwishman 😄
But the CarsXE API no has free tier.
https://api.carsxe.com/pricing

For an api to be added here, it must have a free tier. As described in the contribution file.


Remove Badge from User

Hi, currently there does not seem to be a way to remove a badge from a user other than to delete the badge entirely. I would be good if this functionality could be added to the following screen so badge admins or those that can grant the badge are able to remove the badge from a single user.

I know it is not the best solution, but the interim solution is to delete the badge / the badge type. That removes all the "badge awards" for that badge / type.
Not sure when (and if) I will be able to add that functionality, but always happy to receive external contributions :smile:

hey @larkox could you maybe implement a function to delete badges via PluginHTTP API the same way you can create one with ensure ?
i.e.
/com.mattermost.badges/papi/v1/delete

No promises, but I'm planning to look into implementing this next week. While ideally there'd be buttons on the screen that zjbren screenshotted, in the interest of getting this up and running quickly, I'm planning to add a /badges revoke command that repurposes as much of the /badges grant modal UI and backend as possible.
Assuming that all comes to pass, I'll open a PR when I'm done.

another supportive voice here.
it's very important to have an option to recall the badge.
thanks a lot for your contribution, @larkox, it's very nice plugin, I love it

Been a while, is the plugin still being developed?

Hi @ados8
The plugin is functional, but I am not putting any development time on it. Nevertheless, if anyone wants to add a PR, I am happy to review and get it into the code.


Even powers

I don't have the book handy, but this seems wrong wider than necessary
julia> x = Ubound34(-1,1)
UnumX.Interval{UnumX.Unum{3,4,UInt64}}
[-1.0,1.0]

julia> x*x
UnumX.Interval{UnumX.Unum{3,4,UInt64}}
[-1.0,1.0]

julia> abs(x)*abs(x)
UnumX.Interval{UnumX.Unum{3,4,UInt64}}
[0.0,1.0]

Maybe it is worth checking if x === y in *.
I think @alanedelman mentioned that the intervals were growing faster than expected and this might be a reason why. I wanted to run an SVD on Ubound34s, but because this issue, the norm, used in the scaling of the elementary reflectors, included negative numbers.

I don't think checking for === would be correct (in fact, === is the same as ==). This should probably be done through ^ (which is currently unimplemented).

The book deals extensively with this problem, both the specific cases of x*x (page 141) and any other routine where x appears more than once ("single-use expression" or SUE, to the interval arithmetic community). Chapter 16. If you want to use an algorithm crafted for floats, such as SVD or just about any LINPACK-type routine, you need to implement the guess function and apply it after every operation to mimic the way floats replace ranges with specific floats (rounding).
In particular, please read Chapter 17 on solving equations. Unum solutions to linear algebra problems are far superior to the ones you can obtain with floats, but don't expect to simply change a classic routines data type from float to unum and get a nice result unless you also have the unums set up to mimic rounding error (Chapter 18).

It might be possible to do something like that via macros?

Macros or some kind of environment setting, not unlike a compiler flag. My preference would be that it be shown explicitly, like "guessu(timesu(x,y))" to show a rounded value for the unum product of x and y. A simple preprocessor could apply the guess function to every unum operation, and it would make the code look messy but it would then expose all the place where there is rounding.
Then, you can try taking some of the guess calls out and see what happens. If you only guess, say, after every ten operations, it will pick the midpoint of the ubound range and I suspect that will often be a better guess than the one made by floats. Like a delayed rounding.
It also should become obvious where some loops should be replaced by fused operations. In LINPACK, for example, any call to the BLAS routines SDOT or DDOT should be replaced with the exact unum dot product. That will make a massive improvement in any routine that uses dot products as its innermost loop. Some routines use a different loop nesting that places SAXPY or DAXPY as the innermost loop, and those could use fused multiply-adds (followed by the guess function) but will not show as much benefit from unum accuracy control. If we use Level 2 BLAS and higher, it should always be possible to make an exact dot product the kernel of an array-times-array operation.


Write-Host -ForegroundColor Gray Shows Whatever The Supplied Foreground Color in Scheme is

Windows Terminal version (or Windows build number)
1.6.105671.0
Other Software
PS 7.1.3
Steps to reproduce
Write-Host "Hello world!" -ForegroundColor DarkGray
Write-Host "Hello world!" -ForegroundColor Gray
Write-Host "Hello world!" -ForegroundColor White
Expected Behavior
Write-Host -ForegroundColor Gray "Hello world!" returns a string formatting using the Gray (White or BrightBlack?) color as defined in the console.
Actual Behavior
Strings formatted with -ForegroundColor Gray are whatever the console's Foreground color is defined as, in the color scheme JSON of the WT theme.
When using Write-Host with -ForegroundColor Gray, Windows Terminal uses the Foreground key from the Color Theme's JSON to determine the color, instead of the White key.
Here is a screenshot with the defaults as the theme

Here is a screenshot with the foreground key turned off

Here is a screenshot using White as the foreground key

Here is a screenshot using Red as the foreground key

Here is a screenshot using Cyan as the brightBlack key

Here's a screenshot with the foreground key turned off, and the Powershell console's foreground set to white.
Finally, here's a screenshot with the foreground key set to Red, and the Powershell console's foreground set to white.

Thanks for the comprehensive report. This boils down to how we handle compatibility with poorly-behaved powershell versions.

Unfortunately, this is by design. PowerShell erroneously tells us to use a black background and gray foreground so often that it would cause there to be black streaks across the display (even if the terminal background was set to white or acrylic transparency) and your preferred foreground color to be ignored.
We had to disable gray foreground and black background for PowerShell, specifically. #6810. Tracking the "fix" in /dup #6807.


FindAreaOfASquare.c

Description
#include <stdio.h>

float edge;

int main(void){
    printf("Enter the square edge:\n");
    scanf("%f", &edge);

    printf("The area of the square is: %f\n", edge*edge);

    return 0;
}

!assign

Hey @ShivamK2002, !assign command is only for good first issue !!!
Please choose another issue.
Thanks for your interest in contributing to this project.

Hey @Idanos99
Please create a pull request for #434
You can comment !assign on #434, to be auto-assigned
Thanks for contributing 🤗


Client: Restore Breadcrumbs

Breadbrumbs could be done in the same way as the menu (using routers).

Done.


Fix for #1 (Pipeline compatibility)

Here is another fix for #1 that's perhaps easier to follow than #2
@greg2001 could you please confirm whether you're still maintaining this plugin and if so please consider merging and releasing?
Thanks!

@tilln Thanks for contributing!


Does the glx module overlap with rust-glx?

I came across this while looking at how realistic it would be to merge https://github.com/servo/rust-xlib/ and x11-rs. Is there a reason to prefer this repository's glx module over https://github.com/servo/rust-glx/?

There's also been talk of merging glutin's X11 bindings (which are also extensive) with rust-xlib, but we would need to put rust-xlib on crates.io first. If we can just shift over to using x11-rs instead, that's even less work :)

Presumably a PR to glutin that removes ffi.rs and uses a released version of x11-rs. It would be worth ensuring that @tomaka is open to this idea, too :)

There are actually some generated XCB bindings over at https://github.com/Aatch/rust-xcb, they just haven't been updated for a while. I've been working on trying to make things compile now that rust seems to be in a more stable place.

@bjz ^


Update themes legacy to current

Changes made:

Consistent use of title case throughout page
Changed all instances of the word "legacy" to "current theme"


[WFCORE-499] : System properties are broken in domain mode.

Allowing the boot-time attribute for managed servers.
Jira: https://issues.jboss.org/browse/WFCORE-499

Core - Full Integration Build 398 is now running using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b

Linux Build 1121 is now running using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b

Windows Build 820 is now running using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b

Windows Build 820 outcome was SUCCESS using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b
Summary: Tests passed: 2981, ignored: 95 Build time: 0:17:57

Linux Build 1121 outcome was SUCCESS using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b
Summary: Tests passed: 2981, ignored: 95 Build time: 0:18:38

Core - Full Integration Build 398 outcome was SUCCESS using a merge of 8d981b41a1a8f6a616d024b709f5158687e7e19b
Summary: Tests passed: 2856, ignored: 378 Build time: 0:51:24

The "boot-time" attribute doesn't belong on a server. It's an instruction to the HC to apply the property as part of the command used to launch the java.lang.Process; i.e. used in ManagedServerBootCmdFactory. So any system-property resource with that set to 'true' should not become part of the server's configuration model.

My guess is this was the problem:
https://github.com/wildfly/wildfly-core/pull/387
and this is the fix:
https://github.com/bstansberry/wildfly-core/commit/0065d42f72623690f8366368d68ae2f8a0847a78

That commits fixes the https://issues.jboss.org/browse/WFLY-4299 problem, which looks to be just a specific example of WFCORE-499.

Fixing missing code and covering with a test.

Core - Full Integration Build 421 is now running using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736

Linux Build 1147 is now running using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736

Windows Build 843 is now running using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736

Windows Build 843 outcome was SUCCESS using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736
Summary: Tests passed: 2987, ignored: 95 Build time: 0:18:17

Linux Build 1147 outcome was SUCCESS using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736
Summary: Tests passed: 2987, ignored: 95 Build time: 0:18:45

Core - Full Integration Build 421 outcome was FAILURE using a merge of 0a642e6ac320ea2de264f29ce4c4d5ba2a590736
Summary: Tests failed: 1 (1 new), passed: 2855, ignored: 378 Build time: 0:48:40
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testStatelessFailover: java.lang.AssertionError: 0 invocations were routed to node-1
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)


Fix typo

Issue #, if available:
Description of changes:
Fix typo
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/cherrypick release-0.9


Inconsistent IO on JRuby

While trying to fix a JRuby specific bug in Vagrant http://vagrantup.com/, which uses ChildProcess to execute some commands, I found that output cannot always be retrieved from a subprocess.
I've been able to reproduce the bug in a single file here:
https://gist.github.com/1647275
It is creating two ChildProcesses (via the Subprocess class), and executing
them in order.
Vagrant::Util::Subprocess.new("VBoxManage", "--version").execute
Vagrant::Util::Subprocess.new("VBoxManage", "--version").execute

In the execute method, a ChildProcess is created:
process = ChildProcess.build(*@command)
stdout, stdout_writer = IO.pipe
stderr, stderr_writer = IO.pipe
process.io.stdout = stdout_writer
process.io.stderr = stderr_writer
process.duplex = true

Then it tries to read the output from the stdout pipe:
data << io.read_nonblock(READ_CHUNK_SIZE)

The first time, the ChildProcess works correctly, but the second time it
yields no output.
INFO subprocess: Starting process: ["VBoxManage", "--version"]
DEBUG subprocess: Selecting on IO
DEBUG subprocess: stdout: 4.1.8r75467
DEBUG subprocess: Waiting for process to exit. Remaining to timeout: 32000
DEBUG subprocess: Exit status: 0
INFO subprocess: Starting process: ["VBoxManage", "--version"]
DEBUG subprocess: Selecting on IO
DEBUG subprocess: Waiting for process to exit. Remaining to timeout: 31999
DEBUG subprocess: Exit status: 0

I've created a workaround in Vagrant for this issue by using IO.popen4 like this:
IO.popen4( cmd ) do |pid, stdin, stdout, stderr|
 Thread.new(stdout) {|stdout_io|
   stdout_io.each_line do |data|
     @logger.debug("stdout: #{data}")
   end
 }.join
end

https://github.com/mitchellh/vagrant/pull/709
But it seems that this should be pushed down into Childprocess.  I'm already looking into how this could be done, but would love some advice.  Thanks.

Reproduce with this script:
https://gist.github.com/1647275
Background:
http://markmail.org/thread/e7rmwy4jp53e3wjj
https://github.com/mitchellh/vagrant/issues/658
http://jira.codehaus.org/browse/JRUBY-6362

Closing the write streams after the process has finished appears to solve the problem:
diff --git a/subprocess.rb b/subprocess.rb
index 1b5d4ca..c1c478b 100644
--- a/subprocess.rb
+++ b/subprocess.rb
@@ -67,10 +67,6 @@ module Vagrant
         # Make sure the stdin does not buffer
         process.io.stdin.sync = true

-        # Close the writer pipes, since we're just reading
-        stdout_writer.close
-        stderr_writer.close
-
         # Create a dictionary to store all the output we see.
         io_data = { :stdout => "", :stderr => "" }

@@ -124,6 +120,10 @@ module Vagrant
           raise TimeoutExceeded, process.pid
         end

+        # Close the writer pipes, since we're just reading
+        stdout_writer.close
+        stderr_writer.close
+
         @logger.debug("Exit status: #{process.exit_code}")

         # Read the final output data, since it is possible we missed a small
(END)

Awesome! thanks

FTR, i submitted this patch to vagrant:
https://github.com/mitchellh/vagrant/pull/711

Now I've found another problem.  If I add the following line to the script above:
Vagrant::Util::Subprocess.new("VBoxManage", "showvminfo", "d70641b6-1dc5-47a2-9f5a-13464db8ac8d").execute

I get this output (note that this won't work exactly because UUID for the box will be different):
 INFO subprocess: Starting process: ["VBoxManage", "showvminfo", "d70641b6-1dc5-47a2-9f5a-13464db8ac8d"]
DEBUG subprocess: Selecting on IO
DEBUG subprocess: stdout: N
NativeException: java.lang.IndexOutOfBoundsException: null
  pump at /Users/jkutner/.rvm/gems/jruby-1.6.5/gems/childprocess-0.3.0/lib/childprocess/jruby/pump.rb:33
     run at /Users/jkutner/.rvm/gems/jruby-1.6.5/gems/childprocess-0.3.0/lib/childprocess/jruby/pump.rb:18
    call at org/jruby/RubyProc.java:270
    call at org/jruby/RubyProc.java:224

The "N" is the first character in the output, which is really "Name: " and then about 100 lines of stuff.  I suspect the reason this command fails is the longer output (total SWAG).

I'm trying to create a more easily reproducible result.  Should I open a new ticket?

Test case would be good. Let's just use this ticket.

Yes, it appears to be the length of the output.  Here is the script using cat temp.rb (assuming the name of the script bug.rb)
https://gist.github.com/1748321

You may want to try this patch against childprocess:

diff --git a/lib/childprocess/jruby/pump.rb b/lib/childprocess/jruby/pump.rb
index adfc58b..7cac056 100644
--- a/lib/childprocess/jruby/pump.rb
+++ b/lib/childprocess/jruby/pump.rb
@@ -30,6 +30,7 @@ module ChildProcess

           while read != -1
             avail =<EMAIL_ADDRESS>1].max
+            avail = BUFFER_SIZE if avail > BUFFER_SIZE
             read = @input.read(buffer, 0, avail)

             if read > 0

I've pushed it to a branch here so you can try it out:
https://github.com/jarib/childprocess/tree/issue-30-index-out-of-bounds

Thanks, looks like my fix is correct then. I'll push 0.3.1 shortly.

Thank you for the amazingly fast response!!!

You're welcome :) 0.3.1 is out now.

this appears to fix all jruby related issues in vagrant.  danka!

Yeah, at least on non-Windows (there's still #26). Thanks for digging into these!

@jkutner
Just realized a huge bug (see mitchellh/vagrant#721). On Windows non-Java, you have to close the writer pipes BEFORE starting the process, or reading doesn't work. You can see the commit I made to fix this: I basically check whether we're in JRuby or not and do the close at the proper place.
Annoying. Oh, subprocess IO, never easy.

Ugh.


BART fine tuning pauses

🐛 Bug

To Reproduce
Tried finetuning BART and it pauses in epoch 001 a 3%
script used
TOTAL_NUM_UPDATES=20000
WARMUP_UPDATES=500
LR=3e-05
AX_TOKENS=1024
UPDATE_FREQ=16
BART_PATH=/nas/home/tuhinc/fairseq/bart.large/model.pt
python train.py fullstory
--restore-file $BART_PATH
--max-tokens $MAX_TOKENS
--task translation
--source-lang source --target-lang target
--truncate-source
--layernorm-embedding
--share-all-embeddings
--share-decoder-input-output-embed
--reset-optimizer --reset-dataloader --reset-meters
--required-batch-size-multiple 1
--arch bart_large
--criterion label_smoothed_cross_entropy
--label-smoothing 0.1
--dropout 0.1 --attention-dropout 0.1
--weight-decay 0.01 --optimizer adam --adam-betas "(0.9, 0.999)" --adam-eps 1e-08
--clip-norm 0.1
--lr-scheduler polynomial_decay --lr $LR --total-num-update $TOTAL_NUM_UPDATES --warmup-updates $WARMUP_UPDATES
--memory-efficient-fp16 --update-freq $UPDATE_FREQ
--save-dir "checkpoint-fullstory"
--ddp-backend=no_c10d
--skip-invalid-size-inputs-valid-test
--find-unused-parameters;
~
Steps to reproduce the behavior (always include the command you ran):

Run cmd '....'
See error

Code sample

Expected behavior

I have finetuned BART previously n this never happened. The length of individual samples have increased as I was training previously on truncated version of same dataset
Environment

fairseq Version (e.g., 1.0 or master): 0.9.0
PyTorch Version (e.g., 1.0) 1.3.1
OS (e.g., Linux): Linux
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version: 3.7.3
CUDA/cuDNN version: 10.1.243
GPU models and configuration: RTX 2080 ( 4 gpus)

@myleott  @ngoyal2707

Hmm, often when things get stuck it's because of some failure on one of the workers, which blocks the rest of the workers from continuing. Does it still get stuck if you use a single GPU? What about if you lower the batch size?

it works on a single gpu

Assuming this is the same underlying setup as #1772, it's almost definitely an OOM on one of the workers causing the other to hang :/


Leak in ConcurrentSkipListMap's Marker nodes

Marker nodes are bound to leak in ConcurrentSkipListMap as they are self-referencing.
https://github.com/google/j2objc/blob/master/jre_emul/android/platform/libcore/luni/src/main/java/java/util/concurrent/ConcurrentSkipListMap.java#L415
As self referencing go, I believe the proper workaround / fix would either be to weakify the self reference iff this is a marker node, OR to break the cycle when removing a marker node from the ListMap.

What we've done for other concurrency classes with self-references is replace them with assignment to a shared sentinel. Would you be interested in creating a pull request with this class updated to do the same? There are two unit tests for that class, so it should be safe if the tests pass.
https://github.com/google/j2objc/blob/master/jre_emul/android/platform/libcore/luni/src/main/java/java/util/concurrent/ConcurrentLinkedQueue.java#L924

Thanks @tomball for the quick reply! We’ll have a look!

(Please reopen)


Problems with fetchBalances() for Three Out of Five Exchanges

I'm attempting to use five exchanges right now, all of which work fine except for Poloniex, Bitfinex, and Kraken when it comes to fetchBalances(). I get these errors:
poloniex: Error: poloniex POST https://poloniex.com/tradingApi 422 Unprocessable Entity
bitfinex: Error: bitfinex POST https://api.bitfinex.com/v1/balances 400 Bad Request Possible reasons: invalid API keys, market down or offline, on maintenance, DDoS protection, rate-limiting in effect
kraken: TypeError: Cannot convert undefined or null to object
They all return loadProducts() just fine, and I know have the correct credentials. Is there something special about these exchanges I might be missing when it comes to fetching balances? So far, GDAX and Bitstamp work fine.

Hi!
Thanks for posting this!
We now have a fix for this issue, it should be available in version 1.1.81 already. The Kraken exchange should also work normally. We made a special case for the beast, that is until we find a more elegant solution to this problem.
Code for testing:
const ccxt = require ('ccxt')
const kraken = new ccxt.kraken ({
    apiKey: 'CGAra4mIwKxgV3uYB4XZI4nVVmjXyIpER+5bFUuXGlIQ4MJFKLQfTJWK',
    secret: 'wrkstzsrwdj9pJlUGjj+wOTQgYAaO8MankKJPhASNGEY7hbFAtumQ45C7K/2SwCSgL8WcusUuTgarP5mmqo1uQ=='
})
(async () => {
    await kraken.loadProducts ()
    console.log (await kraken.fetchBalance ())
}) ()

This snippet should output the following:
{ info: {} } # no error, just an empty balance

Can you test it in your console and report if you have any errors? You didn't mention the language you're using, so, I written it here in JS, but here's a Python version of the same snippet just in case:
import ccxt
kraken = ccxt.kraken ({
    'apiKey': 'CGAra4mIwKxgV3uYB4XZI4nVVmjXyIpER+5bFUuXGlIQ4MJFKLQfTJWK',
    'secret': 'wrkstzsrwdj9pJlUGjj+wOTQgYAaO8MankKJPhASNGEY7hbFAtumQ45C7K/2SwCSgL8WcusUuTgarP5mmqo1uQ=='
})
kraken.load_products ()
kraken.fetch_balance ()

Also, note, that you have to update ccxt to version 1.1.80+ for this to work.

Hi, kroitor. I am using the latest version under Node.js. I updated it after the prior issue was completed. Here is the console output for when I run your test code:
`$ node test_kraken.js
C:\Users\c.k.lester\Documents\repos\csx\test_kraken.js:6
(async () => {
^
TypeError: (intermediate value) is not a function
at Object. (C:\Users\c.k.lester\Documents\repos\csx\test_kraken.js:6:1)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Function.Module.runMain (module.js:605:10)
at startup (bootstrap_node.js:158:16)
at bootstrap_node.js:575:3`
Is there a command I can run to get the version of the module I'm using?
I'm using node 8.1.4 and npm 5.0.3.

I confirmed I'm using ccxt 1.1.83.

After we debug your Kraken connection, then we will move to see what's wrong with your Poloniex and Bitfinex, may be nonce issues, but we should debug Kraken first, as it should work normally after recent updates.

Please report if/when you have Kraken up and running normally. That snippet should output an empty balance.

The test from a file worked. I didn't try from the command line. I didn't even know about that! :-)

Ok, I'm going to post testing snippets for Poloniex and Bitfinex now, to see what you get in response. Give me a sec, I'll get back to you very soon!

When I tried with my credentials, I got this output:
$ node test_kraken.js (node:4476) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: request timed out (node:4476) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
That could just be timeout issues with Kraken.

No, it might be a nonce issue. Did you use your credentials previously with other software? Can you try a new fresh keypair?

I generated a new keypair, and it worked for me!

Ok! Good to know that, but hold on a little )
If you experience such problems in future, you don't need to regenerate your keypairs, you may be fine with the nonce overrided. Here's how it's done:
And in a file:
let ccxt = require ('.ccxt')
let kraken = new ccxt.kraken ({
    apiKey: 'YOUR_OLD_API_KEY_THAT_DIDNT_WORK',
    secret: 'YOUR_OLD_SECRET_THAT_DIDNT_WORK',
    nonce: Date.now, // ← this line added, overrides the nonce
})
async function test () => {
    await kraken.loadProducts ()
    console.log (await kraken.fetchBalance ())
}
test ()

You can test it with your old keypair to see if this helps. Now I'm going for Poloniex and Bitfinex test samples, one sec.

I tried the old creds with the nonce override, and it still came back with errors. I think maybe the old creds got spoiled...?

Could be even bigger nonce used already with your old credentials. That may be called 'spoiling' :)
At least, we know that the problem is not with Kraken support in the library, but a problem with your old credentials. Now that it's gone with a new keypair, we will debug your Poloniex and Bitfinex, I'll post examples. Also, I would highly recommend reading the Manual very carefully from the beginning to the very end )
I'll get back to you in a couple of minutes.

Well, I'm wondering if a new keypair for Poloniex and Bitfinex will clear things up as well. :-D

"use strict";

let ccxt = require ('./ccxt')
let bitfinex = new ccxt.bitfinex ({
	"apiKey": "5A1VikyEtDpmFkrzX4e52LsaVgCxXyMnY9JElqvNMxo",
	"secret": "Rgxxw1BGnq6NLTLq1hn0oQ5FBDRLYFFVRzyEKYbz1io",
})

async function test () {
    await bitfinex.loadProducts ()
    console.log (await bitfinex.fetchBalance ())
}

test ()

Does this work for you?

Here's the output:
$ node test_bitfinex.js { info:    [ { type: 'exchange',        currency: 'btc',        amount: '0.0051689',        available: '0.0051689' },      { type: 'exchange',        currency: 'usd',        amount: '0.0',        available: '0.0' } ],   BTC: { free: 0.0051689, used: 0, total: 0.0051689 },   LTC: { free: undefined, used: undefined, total: undefined },   ETH: { free: undefined, used: undefined, total: undefined },   ETC: { free: undefined, used: undefined, total: undefined },   RRT: { free: undefined, used: undefined, total: undefined },   ZEC: { free: undefined, used: undefined, total: undefined },   XMR: { free: undefined, used: undefined, total: undefined },   DASH: { free: undefined, used: undefined, total: undefined },   BCC: { free: undefined, used: undefined, total: undefined },   BCU: { free: undefined, used: undefined, total: undefined },   XRP: { free: undefined, used: undefined, total: undefined },   IOT: { free: undefined, used: undefined, total: undefined },   EOS: { free: undefined, used: undefined, total: undefined },   SAN: { free: undefined, used: undefined, total: undefined },   OMG: { free: undefined, used: undefined, total: undefined },   USD: { free: 0, used: 0, total: 0 } }

Well, with a new keypair Bitfinex should also work normally then. Can you try a new one?

This is for Poloniex:
"use strict";

let ccxt = require ('./ccxt')
let poloniex = new ccxt.poloniex ({
	"apiKey": "BLWC235I-69P3AOOG-9K2PIH6N-HGZPOXAQ",
	"secret": "34ebd79b4400df54114c5d3e2b339b27d28eccc747766c78c0d42826ebc3d2a21bb4c9870f2168dcc6d9437dc08e6253f5949fe85b4b73e30b7e56e879624f8d"
})

async function test () {
    await poloniex.loadProducts ()
    console.log (await poloniex.fetchBalance ())
}

test ()

Standing by for your report.

https://github.com/kroitor/ccxt/wiki/Manual#troubleshooting
Worth reading )

Sorry! I missed that troubleshooting section. Good info. Thank you!

Do you have any problems remaining?

Your test code for Bitfinex and Poloniex come back fine with your credentials, but they are having problems with my credentials. I'm going to get new credentials for both and continue testing.

We will try to state in a more clear way in the error reporting from the library, so that users would not be confused with this anymore. In the meantime, waiting for your status.
I suppose, that's five of five, so give me five, man! ;) I'm closing it, please reopen if you still have problems with new keypairs. Thanks for your involvement!

Will do! Thank you!


docstring on eq function on quanumcircuit and dagcircuit.

Summary
The issue was missing doc on eq on both quantum and dag circuit.
I have add docstring for both eq function and examples.
Details and comments
fix #9044

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @uchoi91 . Thanks for the PR. Regardless of the final form the PR takes, you'll need to sign the CLA as noted above. If you have any trouble with this, please leave a note here.

hi @uchoi91 currently where you have put this docstring it will not render in the documentation website. I believe what was suggested in the original issue was that this text should be moved up to the class level docstring (so the docstring right at the top around line 135) not in the __eq__ docstring itself.

Thanks @javabster for catching that.
First time going through the doc update didn't realize there is sphinx/makefile that generates the documentation.
I have made changes (using automethod) to populate the doc at the class level.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 85.967%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
3
91.14%

crates/accelerate/src/sabre_swap/layer.rs
4
97.32%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
71473

Relevant Lines:
83140

💛  - Coveralls


Fix issue with non-list To header in GmailSendMessage Tool

Fixing the problem of feeding str instead of List[str] to the email tool.
Fixes #6234
Who can review?
Tag maintainers/contributors who might be interested:
@hwchase17

Please check it, it's quite important.

@hwchase17
@dev2049
@agola11
@eyurtsev


I am not receiving the injected headers

Hello,
After completing the installation of EasyAuth and fulfilling all the prerequisites, I am not receiving the 'x-injected-' headers on my backend/app as described on this page: https://github.com/Azure/EasyAuthForK8s/blob/master/docs/headers.md
Has anyone else experienced this issue ? Did I forget something in the configuration ?
Thank you for your help.

Hello @ibersanoMS, @jonlester
Any ideas on how to solve this problem?
Thanks in advance


[Cosmos] fixing bug with not passing kwargs/ response_hook in create_container_if_not_exists

Addressing this issue pointing out a gap in our SDK's response_hook behavior for certain methods.

API change check
API changes are not detected in this pull request.


chore: Release Noir(0.19.4)

:robot: I have created a release beep boop
0.19.4
0.19.4 (2023-11-24)
Features

Add --check option to nargo fmt for dry-run formatting verification (#3530) (4469707)
Committing to fake master (381b114)
Committing to fake master (5edd062)
Committing to fake master (640a648)
Committing to fake master (6c07471)

Bug Fixes

Compiler version error message (#3558) (026a358)

0.35.0
0.35.0 (2023-11-24)
⚠ BREAKING CHANGES

Move circuit serialization circuit into acir (#3345)
expose pedersen hash in acir and bb solver (#3269)
Switch to new pedersen implementation (#3151)
Pass ACIR to ACVM by reference rather than passing ownership (#2872)
wasm: improve and simplify wasm compiler interface (#2976)
Maintain shape of foreign call arguments (#2935)

Features

acvm_js: Export black box solver functions (#2812) (da8a98e)
acvm: Separate ACVM optimizations and transformations (#2979) (5865d1a)
Add ACIR serializer C++ codegen (#2961) (7556982)
Add conditional compilation of methods based on the underlying field being used  (#3045) (2e008e2)
Add debugger commands to introspect (and modify) the current state (#3391) (9e1ad85)
Expose pedersen hash in acir and bb solver (#3269) (0108b6c)
Extract Brillig VM to allow step debugging (#3259) (f6431f9)
Implement euclidean division and signed division in terms of AcirVars (#3230) (b8b7782)
Maintain shape of foreign call arguments (#2935) (f7869e6)
Pass ACIR to ACVM by reference rather than passing ownership (#2872) (b3a9c34)
Pass brillig bytecode to VM by reference (#3030) (4ee290b)
Refactor debugger and separate core from UI (#3308) (8466810)
Replace boolean range constraints with arithmetic opcodes (#3234) (949222c)
Save Brillig execution state in ACVM (#3026) (88682da)
Solve fixed_base_scalar_mul black box functions in rust (#3153) (1c1afbc)
Switch to new pedersen implementation (#3151) (35fb3f7)
wasm: Improve and simplify wasm compiler interface (#2976) (1b5124b)

Bug Fixes

ACIR optimizer should update assertion messages (#3010) (758b6b6)
acvm: Return false rather than panicking on invalid ECDSA signatures (#2783) (155abc0)
Determinism of fallback transformer (#3100) (12daad1)
Fix method program_counter, change method signature (#3012) (5ea522b)
Minor problems with aztec publishing (#3095) (0fc8f20)
Prevent duplicated assert message transformation (#3038) (082a6d0)
Return error rather than panicking on unreadable circuits (#3179) (d4f61d3)

Miscellaneous Chores

Move circuit serialization circuit into acir (#3345) (122119b)

This PR was generated with Release Please. See documentation.

this is me testing docs workflow with a fake branch, please ignore


Would be possible to support section name in camelCase(e.g., easyRpm)?

I am using jscs with requireCamelCaseOrUpperCaseIdentifiers and would like to use a valid section name that satisfies:
var camelCase = 0;
var CamelCase = 1;
var _camelCase = 2;
var camelCase_ = 3;
var UPPER_CASE = 4;

So, just to be clear, you want the identifier in the grunt options to satisfy your style constraints?  I suppose it could be done, but it would need to be backwards-compatible with the existing easy-rpm key.

Closing due to inactivity.  Still not sure exactly what is being asked, precisely.


improve error message when rolling could not be completed

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[ ] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:
Error message improved to include longitude bounds of the dataset when the bounds requested in a subset (ops.subset) are not within range and rolling could not be completed.

Does this PR introduce a breaking change?:

Other information:

@agstephens I'm struggling to think of how to rephrase it, how does this sound?

The input longitude bounds (lon_bnds) are not within the longitude bounds of this dataset and the data could not be converted to this longitude frame successfully. Please re-run your request with longitudes within the bounds of the dataset: (lon_min, lon_max)

I've read it so many times, I'm not even sure this makes sense anymore..

@ellesmith88, here is a slightly tweaked suggestion:
The requested longitude subset (lon_bnds) is not within the longitude bounds of this dataset and the data could not be converted to this longitude frame successfully. Please re-run your request with longitudes within the bounds of the dataset: (lon_min, lon_max)

I hope that looks alright to you.

@agstephens Looks good - I've implemented your suggestion.


[*] some changes for speed

Description of Changes

Hey,
I've replaced some code with a more performant in my opinion. Hope it might become a little bit faster :)

Replaced Array.ofDim(..).map(...) with Array.fill(...)(...). It's like 2 intermediate structures vs 1.
Replaced creation of slices inside the loss and the lossGrad functions with a private precalculated one.
Replaced code in ClassificationMetrics with already defined methods and reduce the number of intermediate structures created.

Includes

[x] Code changes
[ ] Documentation
[ ] Tests

Thanks, @nikdon, much-appreciated :D. I'll merge and refactor later (remove comments and empty lines, add the same loss and lossGrad fix to softmax).


Visa api Demo update

Hi Mark,
This is the VISA API Demo update changes.
Keith

@keithpuzey I think the change we were planning on mergin in for this was essentially the DigitalBank app as you demo'd it where the 'Transfers/Payments' section remains and there is just the additional '3rd Party Transfers' section added.

I have not had time to peek through this PR yet, but is that what this is?
Can probably just rebase that branch with the updates Mark has made since you forked and should be good to go.


[route] Add top level typed per filter config to RouteConfiguration

Commit Message: Add top level typed per filter config to RouteConfiguration
Additional Description: Kick starter for issue #17662
Risk Level: LOW
Testing:
Docs Changes:
Release Notes: Add top level typed per filter config to RouteConfiguration
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

SG.
I will work on it when I get cycles, unless Yan or Adi beat me on this.
Currently we are happy with inserting the data to the vhost::metadata.


Ip listed due to TCP reflection using spoofed IPs

One of our ips has been listed due to TCP reflection attacks using our spoofed IPs (e.g. <IP_ADDRESS>)
This has already happened in the past (see https://github.com/firehol/firehol/issues/437#issuecomment-678143417).
What is the process to get removed and whitelisted?

Hi @mpfau
Added it to whitelist and updated the ipsum accordingly
Best regards


Set up app for Expo SDK, add haptic feedback for long presses with Expo Haptics

NOTE TO REVIEWERS:

Most of the diff comes from changes to package-lock.json, which was updated to support unimodules and expo. While this diff may seem extremely large, I personally think it's useful to allow ourselves to use Expo SDKs, since they provide an easy-to-use and well-supported SDK for a ton of important features that we may want to add later on. You can read more about other Expo SDKs here by using the links in the sidebar.

Details
I previously opened https://github.com/Expensify/Expensify.cash/pull/3586, which added haptic feedback from a haptics library that wasn't as popular as we would have liked, so @marcaaron suggested I use Expo Haptics.
This PR sets up our app with react-native-unimodules, which is needed to use any Expo SDKs, including expo-haptics. I used this guide provided by Expo to set up react-native-unimodules, which is the source of the diffs in any Objective-C, Java, gradle, and Pod files.
It also adds haptic feedback using expo-haptics for any long-presses detected on PressableWithSecondaryInteraction components.
Fixed Issues
Fixes https://github.com/Expensify/Expensify.cash/issues/3576
Tests (must be tested on an actual device and NOT a simulator)

Open any chat with messages.
Long press a message.
Verify that you feel some haptic feedback (a very short and abrupt vibration).

QA Steps
Same as the above tests
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
N/A

Just realized that this requires a change to the babel.config for web to work! I'm playing around with it now, will take it off draft-mode once I figured it out.

Got the webpack stuff working! Although, I've learned that we won't be able to use a lot of the Expo on web (and they'll throw exceptions if we try to).

I've learned that we won't be able to use a lot of the Expo on web (and they'll actually throw exceptions if we try to)

@jasperhuangg is this ready for review? I wasn't sure based on the previous comment, but I wouldn't expect to be able to implement haptics on mobile web.

@marcaaron Yup! Sorry if that wasn't clear with my previous comment, this is all good to go 👍

Implemented the suggestions @marcaaron suggested, it still builds fine on Web, and haptics still works great on Android 👍

@marcaaron Got rid of the unnecessary stuff, should be good for another look!

@HorusGoul @timszot Would love to hear your thoughts on what we've done here! I'm definitely not the most knowledgable about this stuff.

Have we considered supporting Mobile Web by leveraging the Vibration API? Only Android browsers support that API, but we could implement it as a progressive enhancement, and when Apple decides to ship the API in Safari, it will work.

Vibration API

Ohh interesting, I haven't heard about this yet. That would definitely be a great idea to get more coverage, interested on hearing other people's thoughts.

I'm cool with whatever you want to do here @jasperhuangg.
I personally like the idea of including as many progressive web app features that we can into the mobile web side, but less certain if this is a company wide priority. Feels maybe a bit out of scope to me and we can probably go back and add something like this later.

I'm cool with whatever you want to do here @jasperhuangg.
I personally like the idea of including as many progressive web app features that we can into the mobile web side, but less certain if this is a company wide priority. Feels maybe a bit out of scope to me and we can probably go back and add something like this later.

Sounds good, I think I'll drop a question in #product or #expensify-open-source, and depending on what they say I'll create a new issue for it. In the meantime, I'm gonna go ahead and merge this 👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.77-6🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@marcaaron Can you please confirm this is expected to be tested on Mobile devices only for haptic(Vibration) feedback? Desktop and Web will not be easy to validate

@mvtglobally That's correct. And also note that this will not work on mobile web either. This is expected.
Only Android and iOS devices with haptic feedback features + running the native app will pass this QA.

🚀 Deployed to production         in version: 1.0.79-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Create Base Model Selector

[x]  Update Config.yaml
[x]  Resreach or Analysis
[x]  Update the entity
[x]  Update the configuration in src config
[x]  Update the components
[x]  Update the pipeline
[x]  Test Case added

Completed the Base Model Selector with good accuracy


dont use native promise for createOffer yet

since promise-ified createOffer is broken... :-(
see https://bugs.chromium.org/p/chromium/issues/detail?id=619289
createAnswer is collateral damage. Seemed better than to split createOffer and createAnswer, I assume this is quite temporary.

cc @alvestrand
travis failure in Firefox... seems unrelated. Maybe kick it?

LGTM.
Re Firefox, noticed this in other tests as well, seems like webdriver is not supporting latest stable :(


Unread streams should not be expanded by default in unread tab in left drawer

Atleast the muted streams should not expanded

Not having collapsible streams is intentional for now.
No further action on this, until we hear feedback from real users.

Should unread messages on muted streams appear in this view at all?

Good point. For now, they show quite dimmed (which I implemented after your feedback).
Let's wait and see how it does in practice? Maybe the backend will omit these even if we see people don't like them.

Yeah, getting feedback sounds good.  I can also imagine sorting them to the bottom under a "Muted streams" heading or something.

@timabbott after latest discussion, I actually think not showing them at all is the best option and we should try it (will push this soon)

Closing as implemented the hiding of muted streams & topics.


add link to rust community

🚀 Deployed on https://6351c19800871b22ae17f440--cozy-fox-0defec.netlify.app


Processextractor

Using go library to find binary dependencies rather then using objdump

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is 18.18%.

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   54.96%   54.96%
=======================================
  Files          38       38
  Lines        4152     4152
=======================================
  Hits         2282     2282
+ Misses       1676     1673    -3
- Partials      194      197    +3

Impacted Files
Coverage Δ

enforcer/nfq.go
0% <0%> (ø)
:arrow_up:

cmd/remoteenforcer/remoteenforcer_linux.go
0% <0%> (ø)
:arrow_up:

enforcer/datapath.go
70.19% <0%> (-0.47%)
:arrow_down:

monitor/linuxmonitor/linuxMonitor.go
66.31% <100%> (+4.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c7aee...ea10246. Read the comment docs.


Broadcasting

Hello, I'm using uWebSockets.js along with a Protobuf protocol for a production project. It's really amazing! But is there a way to broadcast data to all currently connected clients out of the box? or the best way to do it, thanks

If uWebsocket.js doesn't collect all connections in array or set, you should do it yourself and then, by iterating through this array send message to each of stored connection. It's how broadcasting works.

Yes I tried that but the « ws » in the close event is just an empty object so I don’t know how to keep track and correctly remove clients when they disconnects

might be related: https://github.com/uNetworking/uWebSockets/issues/875
https://github.com/uNetworking/uWebSockets.js/issues/57
https://github.com/uNetworking/uWebSockets/issues/790

Yes with pubsub we can do something like broadcasting but what if we want to keep track of connected users and when they disconnect to keep these events?

It's kind of weird that we can only publish by ws object, when it shouldn't be related. Publishing should be a thing of app.
https://github.com/uNetworking/uWebSockets.js/blob/master/examples/PubSub.js
backing to question: ws should be undefined when close event occurs, it has to be bug I guess

also there's currently no way to do "frame-once/send-many" (discussed somewhere in https://github.com/uNetworking/uWebSockets/issues)
so only thing we can do for now is to track active connections manually
personally i'm using two Sets: one for "active" connections, and one for "idle" connections
so emulating broadcast (pub/sub with url client connected to as group name) would be like:
const bufferToString = buf => new Uint8Array(buf).join('.')
const getIpAddress = (res, req) => (req && req.getHeader('x-forwarded-for')) || bufferToString(res.getRemoteAddress())

const main = uws.App({})

const clients = new Set()
const idle = new Set()

main.ws('*', {
  compression: 0,
  maxPayloadLength: 1e6,
  idleTimeout: 0,
  open: (client, req) => {
    client.endpoint = req.getUrl()
    client.ip = getIpAddress(client, req)
    clients.add(client)
  },
  message: (source, message) => {
    clients.forEach(source.endpoint, client => {
      if (!client.send(message, true, false)) {
        clients.delete(client)
        idle.add(client)
      }
    })
  },
  drain: client => {
    // actually it's better to check bufferedAmount here
    clients.add(client)
    idle.delete(client)
  },
  close: client => {
    clients.delete(client)
    idle.delete(client)
  }
})```

it works
you know "waaay better than enything available out there"

@Kamil93 It's not undefined but look

![Capture d’écran 2019-05-10 à 11 35 31](https://user-images.githubusercontent.com/7302317/57517727-c8b11000-7317-11e9-8c2a-9342ad866a0f.png)

@yovanoc show sth more, bit of code that displays it?

I've put the console.log in the second screen? what do you mean by "more code" ?

@yovanoc yes, you can not call any ws method, but it is same ws object you've received in .open handler7 so you can track it

@yovanoc nvm, I saw there 1 screen, now are 2

@dbl0null Oh yes I know what you mean now, I will try that

@dbl0null Your custom forEach is to broadcast to all users connected to the same endpoint?

@yovanoc
Just use:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/forEach

@yovanoc

forEach
drop-in replacement would be:

    clients.forEach(client => {
      if (source.endpoint === client.endpoint) {
        if (!client.send(message, true, false)) {
          clients.delete(client)
          idle.add(client)
        }
      }
    })

*will update previous message

Broadcasting with a loop is the "bubble sort" solution, it works but is the least efficient way. The built in pub sub support, still unfinished, will be the way to go.

How much of a performance increase will there be? currently I do
open:(ws,req)=> {ws.id = ++socketCount; allSockets[ws.id] = ws},
close:(ws,req)=> {delete allSockets[ws.id]}
// broadcast to all
for(let s in allSockets) allSockets[s].send(message)


Orphan rule: implementing From for String

Summary
impl<'a> From<&'a JsString> for String

How can the js_sys implement the From trait for String if both of these traits are defined in an external crate? Doesn't this violate the orphan rule?

Thanks for the report! In this case JsString is a local type, so wasm-bindgen the crate can implement it.


Group referrers by domain

Hi!
I think it would be cool to group the referrers by domains and possibly exclude those that are the same domain.

As you can see this section is flooded with same-site referrers

They might have the same domain, but I guess all with different pages? Tracking the pages (and not only the domains) is usually helpful. Image only tracking twitter.com. You wouldn't be able to see who has tweeted about your page/

Yeah I know this is important to keep the pages but I think it would be cleaner to display a list of domains and when you click on it it gives detailed infos (namely the pages). Also, any idea how to exclude the same domain? In my case in need to scroll quite a bit to see useful data (Twitter links, ...).

I second that.
I would go a step further. One area should show external referers, so you see who brings you traffic.
The "internal" referers could be used to show a flow diagram on how the users navigate through the sites (Homepage -> Page 1 -> Page 2 -> Exit).

@lucasdcrk You could overwrite the siteReferrer until there's a better way.


Broken Link fixed

REF ISSUE NO #330

With this PR I am closing this issue as I have checked no more broken links exist.


Use node 18 for test and bundle with release

LGTM but kitchen sink tests are 🤔 Might need to bump some container dependencies for Node 18.

Bumped the base image to 0.4.0 which is built on focal. Should be good now.


Add Indonesia Open University

@054722871 I am sorry, the domain ecampus.ut.ac.id is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


update to latest jule version

I can't approve this PR. This is not even a valid Jule code.
Thanks for your contribution.


mint: Pin to crystal 0.30 to fix build

Motivation for this change
Fixes the mint build on 20.03 that was broken due to newer crystal versions
Relevant for ZHF #80379
Master is fixed by updating mint in #80391
Things done

[x] Built mint successfully
[x] Verified that it works with a new project

Ah yeah the reason is just that before https://github.com/mint-lang/mint/commit/770e4a75c9d20d4cf1c204207b126a54bfa978a8 (in 0.7.1), it only supported crystal versions up to 0.30

I'll also quickly look into the darwin failure for crystal 0.30 itself

Turns out all (non-binary) crystal versions fail on Darwin, but only if the sandbox is enabled. So I think it's nothing to worry about, since it's disabled by default on Darwin, and I didn't see a quick fix for when it's enabled.


iter method not defined error

Environment data

Pylance language Server version: 2021.6.3 (pyright e66600b2)
OS and version: ArchLinux
Python version: 3.7.3

Expected behaviour
No error
Actual behaviour
GeneralTypeIssues error on subplot of pyplot, when in reality it works fine:

And obviously does not give error without it:

And an horrible solution to it can be:

The stubs we ship for matplotlib largely aren't for type checking (but for editor features like completion/hover), so may have a few holes like this.
I can see from the docs that subplots can return a single Axes or more than one Axes. I'll have to come up with an overload that can describe that behavior.

This has been fixed with an update to the matplotlib stubs. If you are still seeing the problem, please reopen. Thanks!