warnings should not be enabled by default

Many project has their level of warnings control (and may contain -Werror but not contain -Wall), enable it by default may break their compilation. And because cmake-rs depends on gcc-rs, the change may also break projects that depends on cmake. More worse, cmake-rs doesn't have a way to make it off without add -w to cflags and cxxflags explicitly.

The intention here is that gcc is primarily used for compiling local C code rather than upstream dependencies. I've just published a new version of the cmake crate which disables warnings (as it's intended to do) to retain the original behavior.
Are there more situations you were thinking of, though, where foreign code is compiled with warnings by accident?

Some projects uses makefile to maintain compilation dependencies. When wrapping those projects, usually either use shell or gather all the sources manually. In the latter case, the change will still break compilation. But this is a easy-to-fix case though because it depends on gcc-rs directly.

Yeah I'd expect that any compilation of foreign sources to disable warnings, but I'd also expect the number of instances of that to be pretty small.

On windows, /Wall will introduce a lot of warnings, some are even from windows sdk itself. It seems like /W4 is recommended.

Sure! I've pushed a commit to do that instead

I'm going to close this and leave warnings enabled by default, but if there's any problems please be sure to let me know!


Create a list of exercises

Within the lesson, not in an outside document. This will make it easier to onboard helpers. Creating this overview also helped me to see the bigger picture of the lesson and to identify gaps.

i'll add this to the instructor guide!

I would add it to the index, like here: https://coderefinery.github.io/git-intro/ (bottom left)

ok sure

Reasons:

easier to share with helpers who may not be interested in everything else that might be relevant for instructors
instructor guides do not seem to be actually read; I have seen tons of outdated text when going through some


add withcallback.js, support both callback and promise

Coverage remained the same when pulling 79865f81ba3e22e3c6d8a12d424ead2c755246b5 on callback into 27fa50bad00b65a1e664ca085c65acd8c5988572 on master.

Coverage remained the same when pulling 79865f81ba3e22e3c6d8a12d424ead2c755246b5 on callback into 27fa50bad00b65a1e664ca085c65acd8c5988572 on master.

added on npm. feel free to merge and publish

@dead-horse I've just submitted a new pr based on your code to see if we can reduce code duplication. Let me know what you think!


Question: How do I record the input and save it so I can use it later for play along like a piano learning app?

Question: How do I record the input and save it so I can use it later for play along like a piano learning app?

Hi @SeunghunSunmoonLee! Good question. The way I do this is to save the played notes during either onPlayNote or onStopNote (I use onStopNote).
For example,
class App extends React.Component {
  state = {
    recordedNotes: [],
  }

  playNote = (midiNumber, prevActiveNotes) => {
    // ...whatever you're doing to actually play a sound for midiNumber
  }

  stopNote = (midiNumber, prevActiveNotes) => {
    // ...whatever you're doing to stop playing sound for midiNumber

    // react-piano actually gives you the notes that were being played (prevActiveNotes)
    // right before stopNote occurs, so you can use this to record notes.
    this.setState({
      recordedNotes: recordedNotes.concat(prevActiveNotes),
    });
  }

  render() {
    <Piano
      onPlayNote={this.playNote}
      onStopNote={this.stopNote}
      {...other props...}
    />
  }

There's actually a bit more to this logic needed if you want to record chords correctly. I'm planning to create a comprehensive codesandbox soon that covers what you need to do to record and play back input. Hope this can help you get started though.

Hi Kevin, thanks for the reply. I came up with saving midiNumber, timing as follow.
      this.setState((state, props) => {
        return {
          recordButton1Clicked: true,
          recordButton: 'stop',
          recording: [...state.recording].push({
            midiNumber,
            duration: 1,
            currentTime: audioContext.currentTime,
          })
        }
      })

I have following two questions.

How can I play array of midi numbers with time with web audio api or midi api or sound font player or react-piano?
Is there a way to record using MediaStreamRecord

Currently my brain is battling with these resources. Helps appreciated!
references:
https://stackoverflow.com/questions/14418530/record-sounds-from-audiocontext-web-audio-api
https://developer.mozilla.org/en-US/docs/Web/API/MediaStream_Recording_API/Recording_a_media_element
https://github.com/higuma/web-audio-recorder-js/blob/master/lib/WebAudioRecorder.js
https://codepen.io/kulak-at/pen/oqbKpq
https://hackernoon.com/a-web-audio-experiment-666743e16679

Sorry, I've been pretty busy and haven't had a chance to take a look at this - I'll be able to get back to you more in depth by the end of this weekend.

@SeunghunSunmoonLee sorry for getting back to you later than expected. I had to actually do a new release (v3.1.0) to make the API more intuitively support recording/playback (so I recommend upgrading to v3.1.0 first).
I've written up a full featured demo of an app that uses soundfont-player for playback, and records notes that are played and allows you to then play the recorded notes back: https://codesandbox.io/s/l4jjvzmp47
The code is a little complex but it demonstrates how to record "events" that can be played back. Hope this helps.

Did the demo app help? Going to close this issue for now but feel free to re-open and update this with any additional questions you have. Thanks!


Plugin Should Prevent Multiple Logins Using Same CircleCI Build

Currently, it is possible to obtain multiple tokens using the same CircleCI build, so long as that build is still running.  The plugin should only allow a single authentication attempt per CircleCI build (whether it's successful or not).  This added constraint will minimize the window of opportunity for an attacker to obtain a token.  And in the event where an attacker can beat CircleCI and obtain a token first, the build's attempt to authenticate will fail, which will signal the fact that a breach has occurred.

PR #16 fixed this issue.


Introduce chttpd_plugin:before_response

Update dependencies to include following EPI hooks:

chttpd_plugin:before_response/4
chttp_plugin:before_serve_file/5

COUCHDB-2966

+1


Installation for 2.2.3

Current docs say that we need to edit
For android:

AndroidManifest.xml
MainActivity.java

For ios:

Info.plist
AppDelegate

The example, however, only modifies MainAppliation.java and then calls new Client('API_KEY').  What are the correct steps for a proper installation of 2.2.3?

Thanks for the report, @dharik. The docs are correct, and the example app has not yet been updated for 2.2.3.


withRouter higher order component

For #3847
Currently passes down the following props:

location
history (excluding location) - includes history methods (push, go, listen etc...)
router

Just thought I'd get a PR created to start a discussion on the specifics (or if we want one at all).
Todo:

[x] Add withRef, displayName, hoistStatics functionality
[x] Add tests
[ ] Update docs

There's a couple things needed here. Check the v3 HoC.

withRef support to get a ref to the wrapped component.
displayName support.
hoistStatics so that things like data loading statics and others are still available after wrapping.

Do you agree with the props being passed down: history, location, and router?

Yes, but you'll also need to pass through params (which you should already be doing).

Params are passed as a separate prop to Match components already yes

I've gone with the withRouter(options)(Component) API as opposed to the withRouter(Component, options) API, as this lets withRouter be fully used as a decorator
// With options
withRouter(options)(Component)
// OR
@withRouter(options)
class Component {}

// Without options
withRouter(Component)
// OR
@withRouter
class Component {}

I'd be interested to hear of any caveats if there are any, or if anyone thinks you should always have to supply an options argument, making the simplest decorator usage: withRouter().

I'd like to only see location and router passed, exactly as they are on context. Not history though.

I think one of the main use cases for this was to be able to access history methods like go/goBack and replace. If we don't pass history, devs will have to make their own withRouter HOC which gets history off context, or just grab it off context in each component.

I already have use cases for router, location and history. I acquire them all from the context at the moment.

I agree history is useful. I often use the .listen to make the app to react to browser location change.

@ryanflorence what are your current thoughts about passing history down as well? I really think we should allow the user access to the history methods through here, and I think it's okay to expose internal stuff here as I see withRouter as more of an advanced feature.
Even though requiring the history object is not the common case, I think we should make it easy to access for the few that really do need it.

It should also pass params, the withRouter component might not be a direct descendent of the Match.
You may hae a generic component that needs to access router, params and history.

After the commit https://github.com/ReactTraining/react-router/commit/935649e60762ece415282f139345f14c3cc992aa with a comprehensive message "some refactoring", this pull request will not work, because Broadcast has gone.
See the new Link implementation to get the idea how to read location in a new way.
Summon @ryanflorence to help to push this forward.

I'm afraid this PR is a bit outdated. We've got a withHistory HOC in current v4 that should do what you need, except for the hoistStatics bit. Please take a look and holler if it's not adequate.

@mjackson Although the withHistory HOC does provide what I require (match, location, push etc.) I find it a bit confusing the the history object is spread directly into the params.
My main concern is the naming of the history methods being confusing out of context.
I.e I would prefer to write:
const { history } = this.props;
...
history.push(...);

Over:
const { push } = this.props;
...
push(...);

I find the first case to be more obvious about what is going on.

@nzjoel1234 withRouter now passes three props to the component it wraps: history, match, and location. You can read more about it in the documentation. The code that does this is not yet released, but it is on the way,

Docs corrected link: https://github.com/ReactTraining/react-router/blob/v4/packages/react-router/docs/api/withRouter.md

@biganth the docs link is down again.. :(

@Hookkid the docs are here https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/api/withRouter.md 😃


replace umap with mapbox or maptiler

To enhance the experience while surfing the map, umap is goint on the limit of being fluent.
Test a way with mapbox to be more fluent in scrolling the map.
Addition: the defi data is since last change and delivery from github, very fluent

Chnuessli, i'm having a problem with adding my Mapbox map on my umap...
How can I solve this problem?


change: Make signatures formatting more consistent?

Reported on Matrix.

One rather small nit with signatures, when using separate signatures formatted by Black, is that the formatting varies depending on how many arguments there are and how long they and their possible types and default valus are. All these formats are possible:

compact(arg: int) -> bool

semi_compact(
    first_arg: int, second_arg: int
) -> int

verbose(
    first_arg: int = 1,
    second_arg: int = 2,
    third_arg: int = 3
) -> int

I undertand why the format changes and it isn't a big problem, but it is still somewhat confusing and inconsistent if two functions in same module have different signature formats. It would be great if there was a way to force the verbose style to be used always or, perhaps better, always when there's more than one parameter. Unless Black has a such configuration option this may be too hard to implement, though, and Black isn't known for supporting much configuration.

My answer there:

You're right, won't be possible if black doesn't allow it. The second and third examples are bothering me in that they don't append trailing commas. I think Black has a setting for that? But even then, formatting once will append the trailing comma, but it would need a second formatting to actually break each param on its own line. I think that's one of the things Ruff does differently, exactly to avoid the need for double-formatting.
Anyway I'll see what we can do :)

I'd like to switch to Ruff at some point, but we'll need a Python binding to avoid spawning tons of subprocesses.

As I wrote in the discussion, I wouldn't like trailing commas be added to signatures if they aren't in the source code already. They have a benefit that they make diffs smaller if items are added at the end, but at least less technical users could be confused. Ideally there could be an option to control this behavior, but even then the default should be respecting what's in the source.

Respecting the source will be tough, as we would have to reimplement parts of Griffe to use CSTs instead of ASTs. That's kinda of a goal though, as it would unlock nice use-cases, but it's just tough to achieve, so will need time :slightly_smiling_face:


new DB system error

Loaded System.Buffers, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 into ScriptDomain_776791877
Error resuming coroutine: citizen:/scripting/lua/scheduler.lua:577: bad argument #1 to 'unpack' (table expected, got no value)
stack traceback:
        [C]: in function 'table.unpack'
        citizen:/scripting/lua/scheduler.lua:577: in local 'on_query'
        base.lua:83: in local 'f'
        [string "vrp/lib/Proxy.lua"]:60: in upvalue 'handler'
        citizen:/scripting/lua/scheduler.lua:175: in function <citizen:/scripting/lua/scheduler.lua:174>
[vRP] query vRP/get_srvdata (query) params = {"key":"vRP:hidden_trs"}...

"The error is common with any driver, at the first on_query it seems, it's probably related to async/proxy/etc and Citizen.Await."

Solved, but now cached queries are not guaranteed to be executed in order. https://github.com/ImagicTheCat/vRP/commit/9b33e2cd1b3f9c1936d01aa17faced1795fa5a93


Screenshot of Step 4 of Create an Office 365 application in Azure Active Directory is out of date

Howdy!
As mentioned above, the step four screenshot for Create an Office 365 application in Azure Active Directory is out of date.
Many thanks~

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06524f5f-beb1-de55-b30b-8dcc0513191a
Version Independent ID: 730c62fb-ea4d-ed73-af86-ca8d5a959ff7
Content: Office 365 management solution in Azure
Content Source: articles/azure-monitor/insights/solution-office-365.md
Service: operations-management-suite
GitHub Login: @bwren
Microsoft Alias: bwren

Hi @rosmithj - Thank you for your feedback! We will review and update as appropriate.

We don't really maintain this article much anymore since the O365 onboarding primarily moved to Sentinel, but this is a pretty straightforward fix to make.  #in-progress

Looks like it was corrected; many thanks for the help, everyone~


Error: Cannot read properties of undefined (reading 'status') on panel pages with views blocks

Describe the bug
Some routes produce this error message:

Cannot read properties of undefined (reading 'status')

At the same time the following cors-errors are reported:

Access to XMLHttpRequest at 'https://www.djurensratt.se/router/translate-path?path=/engagera-dig/stod-oss' from origin 'https://druxt-prototype.netlify.app' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

www.djurensratt.se/router/translate-path?path=/engagera-dig/stod-oss:1          Failed to load resource: net::ERR_FAILED

Other routes on the site work fine.
However this is a panel page with a bunch of views so there might be a problem with the panel or views system.
Other panel pages give the same result: /engagera-dig, /engagera-dig/bli-aktiv
To Reproduce
Steps to reproduce the behavior:
Go to this url: https://druxt-prototype.netlify.app/engagera-dig/stod-oss
Or grab our druxt experiment repo, run it and go to the route /engagera-dig/stod-oss
Expected behavior
I would expect the route to load but probably with messages from druxt debug about things missing or not being set up right.
Your Environment (please complete the following information):

Device: desktop
OS: fresh ubuntu install
Browser chrome
Version: the latest

Additional context
The same thing happens in local dev and on netlify static hosting

I created a panel page containing only a simple text block so it's likely panel pages, not views, that are at fault.
Example url: https://druxt-prototype.netlify.app/demo-simple-panel-page

Hi @emdahlstrom,
The issue with https://www.djurensratt.se/router/translate-path?path=/engagera-dig/stod-oss is that there's no direct support for Panels pages in the Decoupled Router module (https://www.drupal.org/project/decoupled_router)
I have previously opened an issue with the intent of making the Decoupled Router module more extensible, allow it to better support third party router providers, such as Panels, but I haven't had the time to prioritise the issue yet: https://www.drupal.org/project/decoupled_router/issues/3146024
The issue does have an example of how you can currently extend the routes support, based on the Druxt Drupal module which provides support for Views.
The CORS issue will likely just be a symptom of the unsupported decoupled route.

@Decipher Excellent, thanks for the clarification!
We're planning to move from Panel Pages to Layout Paragraphs in our project so I'll focus on figuring that out.
I'm not clear on the status of panel pages in the ecosystem these days. I'd guess that Layout Builder will be more popular for site building and Layout Paragraphs for editorial content.


Remove golang.org/x/exp dependency and upgrade to Go 1.21

Fixes #77

Disabling lint workflow for now due to https://github.com/golangci/golangci-lint/pull/3922#issuecomment-1670243139


add parens around binops

Filter expression And(x, OR(y, z)) compiles to SQL expression x AND y OR z which means (x AND y) OR z, which is incorrect. This fixes it by adding parens around every binop.
We could try to get rid of extra parens when possible but this seems very low-priority to me.

Rats, need to fix some tests.


BulkInsert messes primary keys

hey,
In general: I have list of entities, where each entity has sub-list of entities. So, like documented, i try to do two bulk inserts:
    await database.BulkInserAsync(parents, new BulkConfig { PreserveInsertOrder = true, SetOutputIdentity = true});
and then I process identities and try to insert children:
                foreach (var parent in parents)
                {
                    foreach (var child in parent.Children)
                    {
                        child.ParentId = parent.Id;
                    }
                }

                await database.BulkInsertAsync(parents.SelectMany(s => s.Children).ToList());

Unfortunately, it seems to mess up Ids - parents entry say for example that its id is 123, but in database it is actualy 125, and score with id 125 in code has id 123 in database etc. Which completely messes with saving data - children get persisted for wrong parents!
Is that a known issue, am i doing something wrong with PreserveInsertOrder and SetOutputIdentity?

Hmm, seems like it is reversing Ids order? I can see, quite consistently, that first parent's children get last parent's id, second parent's children get second-to-last parent's id etc.

Ah, never mind! It finally clicked what I was missing from the documentation. It is not just the order that matters, but I have to, before saving, enter some fake Ids for parents that would indicate the order in which they were added to the list. The order in the list itself did not matter, algorithm picked them from the end of the list it seems. But it was in the documentation, I just didn't get it until I found an error and figured out what exactly is going on until documentation text clicked in my brain.
Thanks for the library,
Jarek


async_std::fmt

Exposes async_std::fmt as unstable. Ref #247. Thanks!
Screenshot

Closing as per the discussion in https://github.com/async-rs/async-std/issues/247


Keep linting/styling/etc modules separate from project

I have multiple projects and use pipenv for them all.
They all use tox so that's present in the Pipfile:
[dev-packages]
tox = "*"

However, while developing I also use black, flake8 etc. to deal with styling and linting and VSC adds these "automagically" to the Pipfile. Which I don't want. Because they're not relevant to the actual project.
Any linting/styling that happens outside of VSC is handled by tox.
So VSC should be happy if the chosen linting- and styling tools are available globally.

@BeyondEvil Are you any extension that adds these styling (black, flake8)? Because AFIK VSC out of the box does not add any such styling unless there are extensions doing it.

@sandy081 Yes, I'm using Python Extension for VSC and honestly that's where I thought I had logged this issue.
Mind moving it? Thanks.

Filed - https://github.com/microsoft/vscode-python/issues/6221


[Doc Issue][Blur images for AAD SSO sbs]

Docs Build status updates of commit 4d0ca99:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Tab-ME-SSO/add-a-scope-final1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/add-a-scope.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/add-client-application.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/add-client-application21.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Tab-ME-SSO/appid-uri1.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
86
36
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Closing the PR.


Build a macOS app bundle and publish a macOS distributable, clean up binary asset names.

Renamed ltheory-bin-<platform>.zip -> dev-binaries-<platform>.zip. Renamed ltheory-distro-win32.zip to ltheory-win32.zip. These changes will break the launcher, but should make the assets much more obvious.
Closes #263

Final artifacts:

I added rust-cache to the PR build as well in https://github.com/Limit-Theory-Redux/ltheory/pull/264/commits/d39b86e2a2f22985474d7df82d2609129b7d91ca, and changed the release workflow to use the shared cache key, so now I think the cache should be shared across all branches when the dependencies don't change. Reduce the macOS and Windows build+test times down from 16 minutes to 8 minutes.


Relocated repo to codedellemc

This patch rewrites all of the "github.com/emccode" to "github.com/codedellemc" in source files, documentation, and other build-related content.

Current coverage is 8.67% (diff: 0.00%)

Merging #611 into master will not change coverage

@@            master      #611   diff @@
========================================
  Files           15        15
  Lines         2097      2097
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
  Hits           182       182
  Misses        1911      1911
  Partials         4         4

Powered by Codecov. Last update 429cfdf...116eb81


Make sure only master branch is watched

ScmUtils multiScm block was watching all branches by default, if no tag was specified vis "use_versions" variable.

@marcesher @Scotchester @vickumar1981 Please review.

Added some docs for shallow clone.

hmm, that is a delegate. Somewhat special for groovy. It sets the closure execution context. It may only confuse people, if I added to the docs.

Fair enough.

Thanks for fixing the shallow clone default! :+1:


Fast HotStuff Vote Msg Storage

Current dependencies on/for this PR:

feature/pos-fast-hotstuff-consensus

PR #640

PR #641

PR #642

PR #643

PR #645

PR #648   👈

This comment was auto-generated by Graphite.


Documentation: refer to the right button name.

At the final install screen, the button is called 'Install'
not 'Next'.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Thanks!


Scanning artifacts function alternate between missing rows and repeating rows for certain resolutions

Current Behavior
In resolution 2560x1440 (full screen on my PC) and 1920x1440, I find the tool frequently misses rows and repeat rows when scanning artifacts. This happens when the artifact UI scrolls with the 1st row of the artifact grid being imperfectly aligned with the box that displays artifacts. When the misalignment is big enough, Inventory Kamera appears to select which row to continue based on how much the 1st row is cut off.
This method is however unreliable and result in the scan alternating between missing a row, being correct on a row, and repeating a row. (Never strictly alternative between these 3. Only loosely alternating.)
I think the tool needs to be able to identify the highlighted artifact as that labels the previously selected and scanned artifact. Since the scrolling UI does not change the previous highlight, that will always identify the correct row to scan next.
Expected Behavior
The scanner to not miss row or items
Reproducing a Behavior
Use 2560x1440 and 1920x1440 in Genshin graphics setting.
Start scanning artifacts.
Pay particular attention to the alignment of artifact grid with the display box.
For any resolution where misalignment occurs, there should be missing rows and repeated rows.
Device OS
Windows 10
Genshin Impact Version
3.7
Inventory Kamera Version
1.3.8
Screen resolution, screen mode, and UI scale
2560x1440, 1920x1440
Additional notes and remarks
No response
Evidence
Here is the result from one of the scans I visually noticed missing/repeated rows.
I don't have a tool myself to parse the json file and don't really have an easy way to detect duplicates.
It is easy to verify missing artifacts, however.
This is part of my current inventory in the same state. Note the number of level 1 head pieces from the Emblem set is 11.  Meanwhile, in the scanned result, there are only 3 level 1 head pieces from Emblem set.
Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[X] I have attached the video recording to the bug report.
[X] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

An issue already exists describing this issue. I am closing this as a duplicate.


icudt.dll

v0.10.0 of node-webkit changed icudt.dll to icudtl.dat
https://github.com/rogerwang/node-webkit/wiki/How-to-package-and-distribute-your-apps#which-files-should-be-shipped
A simple change in pkg/pkg.go fixed this.

Fixed thanks to khaos-one in commit 29f4aaa054d09b04a0edcdf8e6bcd9b29b069b28


Fix multi-index location unpacking in db3

Multi-index locations were not being unpacked in a manner that was
detectable when composing the reactor model on load. The solution was to
unpack multi-index locations into a list of tuples, and to teach the
Grids how to return one when presented with such a list in getitem().
Fixes #251

Ohh, thanks for keeping me honest; added a release note


[BUG] 开启vllm后，输入模型的知识库文本很长时，返回结果为空

问题描述 / Problem Description
不开启vllm，知识库文本很长时，可以有正常返回，只是速度很慢。开启vllm后，速度会提升很多，但是知识库文本很长时，返回结果为空。控制台没有报错，就是马上打印出answer为空。
显卡用的是两张4090，显存占用都是21439MiB /  24564MiB。
环境信息 / Environment Information

langchain-ChatGLM 版本/commit 号：v0.2.10
是否使用 Docker 部署（是/否）：是
使用的模型：Qwen-14B-Chat
使用的 Embedding 模型：m3e-base
使用的向量库类型 ： faiss
操作系统及版本: ubuntu
Python 版本: 3.10

你好 @Leo4zhou！很高兴再次看到你。希望一切都好！
您好，Leo4zhou，
关于您提到的问题，Langchain-Chatchat v0.2.10在启用vllm并且输入模型的知识库文本很长时返回空结果，可能与处理大量文本数据的限制或未针对非常长的文本优化的特定配置有关。然而，根据提供的上下文，langchain-ChatGLM GitHub issues中并没有直接提及或证据指向此行为的特定原因。
没有明确的错误信息、系统配置或关于vllm（非常大的语言模型）如何实现或预期处理大知识库文本的具体细节，很难确定确切的原因。这种行为可能是由于模型设计的限制、文本预处理的问题，或者在提供的上下文中不明显的内存管理策略。
关于vllm可以处理的知识库文本的最大长度，是由MAX_TOKENS变量决定的，如search_knowledge_base_iter函数中所见。然而，给定的上下文中并未提供MAX_TOKENS的实际值，这意味着无法从提供的信息中确定具体的最大长度（以token为单位）。
max_tokens=MAX_TOKENS,

源码：

server/agent/tools/search_knowledgebase_complex.py

如果您能提供更多关于您遇到的问题的信息，例如具体的错误消息、系统配置或vllm的实现细节，可能会有助于我们更好地理解和解决这个问题。
Sources

knowledge_base/samples/content/test_files/langchain-ChatGLM_closed.jsonl
server/agent/tools/search_knowledgebase_complex.py

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.

这里max_tokens 和 max_num_batched_tokens 都设置为了None

context_len

context_len 默认就是2048，没有改动过

The issue you're experiencing with Langchain-Chatchat v0.2.10 returning an empty result when the vllm is enabled and a very long knowledge base text is inputted, despite having no error messages in the console and having set both max_tokens and max_num_batched_tokens to None in the search_knowledge_base_iter function, can be attributed to the handling of the context size before it is passed to the LLM for generating the response.
In the provided code snippet, the context for the LLM is constructed by concatenating the page content of documents found by the search_docs function:
context = "\n".join([doc.page_content for doc in docs])

However, there are no checks or limitations applied to the size of the context string. Large knowledge base texts can result in a context that exceeds the maximum context size allowed by the underlying LLM model, even if max_tokens is set to None. Most LLMs, including those from OpenAI (e.g., GPT-3), have a maximum context size limit (in terms of tokens) that they can process in a single request. Exceeding this limit can lead to the model not generating any output, which could be why an empty result is observed.
The absence of error messages in the console suggests that the issue is not being caught or logged effectively. The code does not include explicit handling or logging for cases where the context size exceeds the model's limitations.
To address this issue, you could implement a mechanism to check the size of the context and split or truncate it as necessary before passing it to the LLM. Additionally, introducing logging for cases where truncation occurs or the context size exceeds known limits could help in diagnosing similar issues in the future. You can refer to the source code here.
Regarding the maximum context size allowed by the underlying LLM model used in Langchain-Chatchat v0.2.10, it is 2048 tokens. This is specified in the ApiModelWorker class constructor with the parameter context_len set to 2048.
def __init__(
    self,
    model_names: List[str],
    controller_addr: str = None,
    worker_addr: str = None,
    context_len: int = 2048,
    no_register: bool = False,
    **kwargs,
):

You can refer to the source code here.
Sources

server/chat/knowledge_base_chat.py
server/model_workers/base.py

About Dosu

context_len 默认就是2048，没有改动过

通过max_model_len参数和max_num_batched_tokends参数进行配置,设置到合适的值就可以解决了


Mobs have laggy and jumpy movement in single player

Describe the bug
In a single-player world, mobs have delayed hit reactions and movement, occasionally jumping to a different spot as well.
Modpack version
5.6.3
Launcher
Prism Launcher
Confirm

[X] This bug report is about an issue with the modpack itself, I have not modified the mods nor added any resource packs. If this is not the case, I know that I should post the issue to modpack's Discord support channel instead.

Additional context
No response

Please update to the latest version and retry.

Please update to the latest version and retry.

The latest update seems to have fixed the issue, thank you!


Feature request: First page set to RECENTLY USED

With my personal experience, 99% of my emoji usage are centred on about 10 high frequency emojis. Clicking from the recently used list is much faster than typing and searching for the 99% cases.
Could it possible to set the first page at recently used, or make it an option?
Thank you.

Good question, I need to think about how to implement this.

Hi @Endle , the default category is set to recently used in v0.0.5: https://github.com/walsvid/logseq-emoji-picker-fork/commit/5778768727a1a117aaf34d9c7ba9f3a985ae6827


Option to set custom directory for drafts

Problem
Currently drafts are saved to the 'drafts' folder within the package folder for loid, making it hard to access the raw markdown files generated by loid.
Solution
Allowing the user to set an alternate directory for loid to use for saving drafts.
I think this would be a useful feature as it would allow people to automatically store their markdown files in a location that is more convenient for them.

Thanks for the suggestion will be implementing it and pushing the code soon


svg that crashes your code.

https://docs.gtk.org/gtk3/gtk-logo.svg
I was trying this:

  Future<Uint8List> _renderToBytes(
      {required ImageByteFormat format, Size? scaleTo}) async {
    final si = await ScalableImage.fromSvgHttpUrl(
        Uri.parse('https://docs.gtk.org/gtk3/gtk-logo.svg'));

    await si.prepareImages();
    final vpSize = si.viewport;
    final recorder = PictureRecorder();
    final Canvas c = Canvas(recorder);
    if (scaleTo != null) {
      c.scale(scaleTo.width / vpSize.width, scaleTo.height / vpSize.height);
    }
    si.paint(c);
    si.unprepareImages();
    final size = scaleTo ?? Size(vpSize.width, vpSize.height);

    final Picture pict = recorder.endRecording();
    final rendered =
        await pict.toImage(size.width.round(), size.height.round());

    final ByteData? bd = await rendered.toByteData(format: format);
    final r = Uint8List.fromList(bd!.buffer.asUint8List());

    rendered.dispose();
    pict.dispose();

    return r;
  }

toImage bombs.

Picture is not part of jovial_svg.  You didn't give a full, reproducible example (or the exact error message with stack backtrace), but I assume you mean Flutter's Picture class.  That's where you need to submit the bug.

maybe your corrupting memory?  I tried removing the unprepareImages and it seemed to work bettter.

Given that there's no native code in jovial_svg, no.  BTW, I did check using the demo program, and that SVG renders fine.
You really do need to file the bug against the library where the crash is occurring.  When you do, I'd suggest providing more information, like what exactly you mean by "crash," what exact error you get, what platform you're on, backtrace (assuming there is one), etc.  Saying vague things like "seemed to work better" isn't much help.

flutter_svg crashes too.  (app just exits, no logs, no nothing)
Yes the svg seems to render fine, but drawing into a canvas and the toImage crashes?
I'm banned from the flutter github.  Could you post this bug?

It seems it only crashes in flutter 3.22

I'm banned from the flutter github. Could you post this bug?

I could do that, if you'd submit a complete, reproducible bug report.  That would include a short, stand-alone program that reproduces the problem (and not just a program snippet -- include something that can be actually be built, e.g. with the imports), and include all the standard stuff for this kind of bug report, like your platform, the output of "flutter doctor -v", etc.  Take a look at the flutter bug submission guidelines to see the sort of things that need to be include.
You should also include everything you know.  Like, what do you mean it "works better?"  Do you mean it works?  In English, "works better" means that there are still problems.  What, exactly?  Or are you just being imprecise?
As a general rule, try to be polite, give complete and clear information.  Don't say "bombs" - that could mean any of a dozen things.  Say what actually happens.  And don't leave out important information, like the fact that you have the same problem with flutter_svg.  Generally speaking, do some work yourself before firing off a bug -- especially when the bug comes up when you call an API that isn't even in the package you're submitting against!
You're asking for a favor.  Don't make the person you're asking the favor from do a bunch of guesswork.

https://github.com/sgehrman/to_image_bug
see readme for info.
Thanks.

https://github.com/SachinGanesh/screenshot/issues/185
@zathras could you post this info on the flutter bug?  I reproduced it using 'screenshot' with the border radius issue @azkadev mentioned.  I want to get this resolved quickly.  thanks.


Syncer: Sweep Btc

Part of #493 , the sweep btc functionality is implemented to eventually allow for recovery of funds stuck in the funding address.

Codecov Report

Merging #499 (429cb0b) into main (a2f8071) will decrease coverage by 0.2%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #499     +/-   ##
=======================================
- Coverage   12.3%   12.1%   -0.2%
=======================================
  Files         34      34
  Lines       9033    9156    +123
=======================================
  Hits        1111    1111
- Misses      7922    8045    +123

Impacted Files
Coverage Δ

src/error.rs
0.0% <0.0%> (ø)

src/syncerd/bitcoin_syncer.rs
0.0% <0.0%> (ø)

src/syncerd/types.rs
25.4% <0.0%> (-0.1%)
:arrow_down:

src/lib.rs
9.2% <0.0%> (-0.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f8071...429cb0b. Read the comment docs.


Sonoff led S1

I don't know if it's an HA or component error, but after updating HA to version 2021.4.0, the Sonoff led strip doesn't work and reports an error.
AttributeError: 'SonoffLED' object has no attribute 'supported_color_modes'

After updating the SonoffLan, the light works properly again. Thanks.
I will close the problem today.


⚠ PrivateHD has degraded performance

In 4b161fe, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3422 ms

Resolved: PrivateHD performance has improved in dd4e593.


[Feature request] Btc payment would be a nice feature

Basic :
Show btc address and QR code in the UI for the user to pay. Configuration in env file is just the btc address.
Advanced :

A way for the payment to be associated to particular user. This may be in implemented in any of the following ways.

Have btc address of user as user property and whenever a pyament to the site's address from any of the user's adress, it can be known that is the user. This is insecure (but simple) still. One person can give another person's address.

User btc address verification (like email verification or some credit card verification), some random minimal amount can be asked to be sent by the user (or sent by the server)

A random 4 or 5 digit number can be a user property. For eg: if 1234 is the user's random number, then the last 4 digts of the user's transaction should be that random number. If he has to pay 0.01 btc, he will send 0.01001234. So that later it can be identified that its particular user.

Different wallets for every users. This way users dont face any friction like wallet address verification or random number payment. But this will be a hassle for the site owner since he have to manage so many wallets unless he automated it to send to his main wallet whenever any wallet recieves any.

Payment history. Automatically scan transactions to the site wallet and find the user payments and show it in the payment history page.

Referencing some prior discussions: https://github.com/sahat/hackathon-starter/pull/308

Won't be able to add it to the project if it requires a copy of the blockchain to be stored on the server.  If I understood your request correctly, that might be required.  If not, feel free to propose a PR.

Showing QR code, or transaction management does not fall under the current intended scope of the project.


Extension README not updated on website

Describe the bug
Our extension's README is not updated on the Marketplace website after publishing an update. The extension page in VS Code shows the updated README. The extension page on the website shows the new version as the latest version but still has the old README.
At the time of writing, the version with the updated README (0.0.20998) has been published for about 15 hours and remains the latest version published.
Update: New versions have been published since and the README has finally updated, so the steps below do not show the issue anymore.
To Reproduce
I was unable to reproduce the issue with a new extension, so I can only post the steps I took to compare the two READMEs.
Steps to reproduce the behavior:

Open VS Code
If installed, uninstall the symflower.symflower extension and restart VS Code
In "Extensions" open the page for symflower.symflower
Clear any browser caches and go to https://marketplace.visualstudio.com/items?itemName=symflower.symflower
Compare the READMEs. If the issue still persists, the README should be different in VS Code.

You can also just search for "Test Skeleton" which should appear in the new version but not in the old version.

Expected behavior
The README on the website should be the same as the README in VS Code.
Desktop (please complete the following information):

OS: openSUSE
Browser: Chrome, but also tried from several different locations with the Tor Browser

I can confirm this is also the case for https://marketplace.visualstudio.com/items?itemName=HashiCorp.terraform, which should look like https://github.com/hashicorp/vscode-terraform/blob/main/README.md
I assume this is an artifact of the recent spam mitigation?

I assume this is an artifact of the recent spam mitigation?

@jpogran do you have a link on an announcement that the marketplace is doing some form of spam mitigation? Seems my Google-foo is not strong enough.

@zimmski https://github.com/microsoft/vsmarketplace/discussions/343

Update: We've published new versions and the README has finally changed. I'd leave this issue open since it still seems like a bug that you have to publish another version to update the README.
I'm pretty sure it's the new version that caused it to update and not anything time-based since the Terraform extension has had its new README out for over a week now and it's still stale on the website.

@zimmski #343

@jpogran thanks!

I'm pretty sure it's the new version that caused it to update ...

@symmb will post a smaller change to the README later today. Let's see if the marketplace changes again with that pattern.

This one seems to be similar to https://github.com/microsoft/vsmarketplace/issues/468 since both the extensions mentioned have platform-specific packages. We have fixed the issue. I checked, the Terraform extension shows the latest committed version of Readme file on Marketplace. Please let me know if the issue still exists or whether we are good to close this issue.

Let's close the issue. We can always reopen if we see the problem again. We are going to have some more updates for our README anyway and then i will monitor if the updates are active right away or not.

Sure, feel free to reopen the issue if the problem ever resurfaces. I will close it for now.


⚠ Bofrost.es has degraded performance

In f2ea54e, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 6263 ms

Resolved: Bofrost.es performance has improved in d4e2421.


[Bug] Cache needs to be invalidated after a certain point to reevaluate blocked exits

Exits can be temporarily blocked in the case of Novice zones and other potential obstructions. We need a way to invalidate the cache and reevaluate paths.
https://github.com/ScreepsQuorum/screeps-quorum/blob/f6868c56ef4ba77029b506aea840cc3bf9c31415/src/lib/map.js#L19-L33

The cache automatically invalidates after 150 ticks (that's what the maxttl is for).

Interesting, I was running into an issue where my creeps thought an exit was blocked, long after it had been unblocked. I'll dig in a little deeper and see where the true error lies.

You may want to look at the costmatrix generation and caching code, as anything there would trickle up to the pathfinding layer.

Ok, thanks. I'm going to close this issue until I can get a better understanding of where it went wrong.


fix: Use cjs extension for diagnose output

I ran into a problem using the diagnostics because my package.json type is set to module. To get the diagnostics script to run I needed to rename the output file to use the cjs extension instead of js. This PR fixes that and a typo

Can you explain to me what's going on here and why this change is necessary? I'm assuming this has something to do with some internal workings of esbuild.
Also, any change should ideally be accompanied by a tests which illustrates the problem and make sure that it doesn't resurface again.

First, you should understand how Node determines if a file is CommonJS or an ES Module. See https://nodejs.org/docs/latest-v18.x/api/packages.html#determining-module-system for more info on how Node determines which to use.
Since the output script is placed into the workspace of the project that invoked the diagnose script, Node will consider the file as either a CommonJS script or an ES Module based on how that project is configured. If the project has it's package.json type set to "module", then Node will throw an error when the output file is require()d by diagnose.ts on line 161, because an ES Module cannot be required. To make Node consider the output file as an CommonJS module, it's extension just needs to be renamed to cjs.
Here's an example of that error:

Another option is to use a dynamic import on line 161 instead of require. This may be the more logical option as esbuild will output a IIFE meant for the browser by default, so the output file isn't really CommonJS. Dynamic imports are supported from Node 13 and up in both CommonJS and ES Modules. I'm not sure which versions of Node you are targeting, so it may be a breaking change to use a dynamic import.
Which would you prefer? I'll create tests as well

I don't have a strong preference towards any of the solutions. It's more important to me that there's sufficient test coverage.

I tried using a dynamic import, but it unfortunately doesn't work because TypeScript will convert it into a require() unless the module is set to ES in the compiler options. Changing the output module type won't work either because the code is require()d by<EMAIL_ADDRESS>and ESM modules can't be required.
I was able to add a test confirming that the change is working. It fails if you revert it to .js

I've merged and released this as v16.0.2.


Allow specifying some diff options, e.g. --histogram

<EMAIL_ADDRESS>would have been much easier to read with a --histogram diff.

As I pointed out in my reply:
Currently, there is no way to do that yet. It should not be too difficult to implement code to pick up a footer in the PR description to do that, I just don't have the time right now to do so.
Essentially, it would have to imitate the already-existing code path that picks up the Cc: footer in the PR description.
If you're interested, have a look at the parsePullRequestDescription() function in lib/patch-series.ts, in particular these lines.


[aes] aes_core simulation using ModelSim

Description
Hello,
we're trying to simulate aes_core module using ModelSim simulator with Vivado IDE and we're getting this error:
** Error: ../../../../hw/ip/prim/rtl/prim_lfsr.sv(467): (vlog-2980) Error: The 'slice_size' portion of the streaming concatenation operator must
be a simple data type or a constant expression.
the error refers to:
{<<LfsrIdxDw{col}};
which is a correct syntax byt is failing with ModelSim
we've tried verilator too but we cannot seem to find a way to generate waveforms for aes module.
can you help?
thanks

Hi @Adam11072000 ,
at the moment we use primarily VCS and Xcelium for OpenTitan. Other simulators like Questa/ModelSim might work or not. As I don't have access to this tool, I cannot really assist here.
Regarding Verilator, I see two options to get traces:

You use the Verilated simulation of the Earlgrey top-level which also instantiates the AES core. You can run e.g. aes_smoketest and enable tracing to get some AES waves. For details, please refer to the documentation of the Verilator setup.
I have developed a scratch verification TB in Verilator to develop the AES unit. It's not in the repository but on my personal branch here: https://github.com/vogelpi/opentitan/tree/aes-dev-verilator  For details on how to run it, please refer to the README.

When using verilator, you could also have a look at my branch. Unfortunately, it's very out of date (better not to use it as I don't know it it runs with the current aes core), but my commented aes_tlul_sequence might help to understand the bus communication better  and the python script can be used to generate longer stimuli.


feat: customize tracer randomNumber func on config.New() called

Which problem is this PR solving?

I want set tracer randomNumber when the config.New() called

Short description of the changes

Added the WithRandomNumber function and the randomNumber field for config.Options. Finally, apply the setting in the config.NewTracer() function

Please make sure all commits are signed. Might be easier to squash them into one. See CONTRIBUTING.md.


Good to rename AuthService

AuthhService is a very generic name and could easily conflict with some other npm module.
Perhaps "GoogleAuthService".
Up to you of course. Just a suggestion.

A very good suggestion Chris. Thanks. I'll implement it in the next release.

You're welcome. I mainly noticed it because I have an internally defined AuthService.
It was no problem for me to rename my service but if it was in an external npm module it would be harder.
I've only had a brief look at your module so far. I will experiment more as time permits. It looks like a great idea which will be very useful. Thanks for publishing it.

@chriscurnow I think that you don't need to rename your own AuthService. Instead, call this with an alias, like:
import { AuthService as GoogleAuthService, AppGlobals } from 'angular2-google-login';
Hope that in the future the AuthService was renamed to avoid confusion : )


Refine bat consistency cleanup

Fixes #5359
Changes proposed in this pull request:

Moved functionality of /d to /debug and /x to /jmx for refine.bat.
Implemented /d, /v and /x for refine.bat.
Cleaned up some of the argument parsing to be more clear and concise.
Changed the usage statement to reflect the changes.

Great - sorry this was only linked from the owning issue and I didn't track back to there. All looks good to me


Tic-tac-toe JavaScript game

hey @prabhat7k go ahead remember don't forget to sync fork while submitting the PR and also attach the screen shot of the project while submitting the PR

Okk thanks.


Inconsistent data format for API listParentDSTrio

While validating the WMCore DBS3Reader, as from this discussion:
https://github.com/dmwm/WMCore/issues/10842
tests for the listParentDSTrio API - currently only used for the StepChain parentage fix thread - are failing and the reason for that is a different output data format between the Python and Go-base servers.
It can be checked with something like:
dbs = DbsApi(dbsURL)
dbs.listParentDSTrio(dataset='/Cosmics/ComissioningHI-PromptReco-v1/RECO')

where the python-based server responds with data like:
[{'36092526': [[180851, 2], [180851, 1]]}, {'36092560': [[180841, 14],...

while the go-based server response is:
{36092526: [[180851, 2], [180851, 1]], 36092560: [[180841, 23], [180841, 2],...

In short, 2 problems:

output is not encapsulated in a list object
key for the dictionary is not a string

@amaltaro thanks for spotting this, it is silly mistake in DBSClient. I fixed it in this PR https://github.com/dmwm/DBSClient/pull/67 But I doubt we should go back to put keys as string. Those are parent ids and as such are not string by definition.
Let me know how to proceed. I can cut new DBSClient release to fix output list object issue, but I don't know how we should deal with keys. Can you point out where exactly they used in WMCore code? We can check if there are anything related to data-type of the key.

@vkuznet Valentin, with the client fix that you provided, our DBS3Reader.getParentDatasetTrio method no longer crashes. It's still not clear to me whether we will be able to write those file ids back - using a write API - in the format of an integer. But it's likely the case in the database schema, so I'm pretty confident with this.
Once you merge that and release a new dbs3-client version, I think we can close this out.
I'm reluctant in getting yet another deployment of reqmgr2 with this new client, even though this would be the safest approach...

new release 4.0.7 is available on PyPi. I'm closing this ticket.


On Mac, allow dropping some files on the app's dock icon. …

Store the settings.ini and prompt.log in ~/.embroidermodder/ as is the convention for Unix programs running on Mac (App directories are expected to be read-only). The change should not affect other platforms. https://github.com/Embroidermodder/Embroidermodder/commit/5fd354d49baa8e15ad36ecf5f159b3089ee0be2a - change 5fd354d is the same but with a few newlines added to comply with the coding style guide.

Thanks David! My hackintosh isn't hooked up at the moment but I did a quick review of the code and it looks ok to me and it passed the initial travis-ci sniff test so I'm merging this in.


Windows install generally fails due to missing WinPCap

Either need to install WinPCap as a prerequisite (Wix supports this but doesn't seem go-msi does out of the box) or offer instructions on doing that and handle it not being there more gracefully.

I opened a quick issue on msi-go to see if I am missing something: https://github.com/mh-cbon/go-msi/issues/29
However I think this will require digging into the Wix config files more and create a new set of templates for go-msi to use.

Should be solved by #48


Admin settings

This meanders a little bit because I had to remove references to a doc that I was trying to delete. I just rewrote the articles that mentioned it, rather than trying to do something more superficial.
@rishig

Thanks @Lyla-Fischer! Merged all but the last commit (and did a significant rewrite of the message editing and deleting doc).
For the last commit; not sure whether to keep the two "generic settings" docs or not. Maybe let's keep it for now and revisit at the end.


support more map operations

Maps should support removal, renaming and adding of keys

6 new methods in Maps: (adding|renaming|removing)Value(InPlace)


Add docs command

Adds basic docs using :ex_doc
To use you can run make docs and open the generated html files on your browser.

I hear the song of a thousand angels
I open the docs and it sounds like this https://www.youtube.com/watch?v=Vd6wi8nDJhU


none of the demos work?

In all of the demos, after uploading an image, there is a brief flash where the cropper and image is visible and then the canvas disappears.  The only thing left after that is the initial cropped image.

i will checkout, i haven't made new release after accept new pulls. If you use latest release all should be good.

people still using that crappy jquery and passed some of it on latest push. @TimoPerplex and @CedricEugeni please check the code you have added in PR and remove Jquery.

@CrackerakiUA : I didn't use Jquery in the code I produced.
Are you talking about the following line of code :
element.children(".loading").remove();
I didn't do this line of code but if I look at the PR I did, there is this line added while I didn't do it.
If that is where the problem is coming from, how can I remove it ? Create another PR ?

Yes, please create another PR.

Looks fixed.

Hi, @CrackerakiUA, @CedricEugeni,
This pull request  #111 indeed introduced a jQuery dependency (my bad), but this pull request #112 fixed that.
The bugfix of #111 and #112 has now been reverted which reintroduces the following bug:
When you select a bad file (xlsx, dll or anything that is not an image) the loading overlay shows. When you after this select a valid image, the image is shown with the loading overlay.
This is because there are now two loading overlays (the first one is not removed).
The pull request removes all loading children messages within the element thus fixing the problem stated above.
To reproduce:

Go to http://codepen.io/Crackeraki/pen/avYNKP
Select anything other than an image
Select a proper image
The loading overlay is still visible

Hi @TimoPerplex, it seems that PR #111 and PR #112 only modify source files and not generated files (maybe you forgot to do a gulp build before committing).
Can you fork from what is available on master right now and put your #112 fix again, then generate files using gulp build?
I think this will help @CrackerakiUA to put things back in order easily.

@CedricEugeni, @CrackerakiUA
Done, i ran gulp build on the source and added a new pull request: #118.
Your revert #117 wasn't merged so didn't need to add the fix again.

Great @TimoPerplex ! :)


Removing trash bytes from the end of RSA private key

I was parsing the RSA key with my own PEM parser and found out that the vector lengths inside the key don't match the data, there's 3 bytes of trash in the end of the array. This doesn't really fix anything, but it shouldn't break anything either. So take it or leave it, just thought I should report. :)

Interestingly - since shairport originated as a vehicle for publishing & proving the key extracted from an AirPort - that key is verbatim from the hardware (IIRC, it was base64 encoded and everything).
Thanks for the AES cleanup :)

Oh, I kind of expected the additional bytes at the end of the key were part of the firmware image and got accidentally encoded as base64 by you...but they were added by Apple? That's interesting, makes me wanna know the story how they got there. :)
But yeah, the base64 decoded key starts with DER encoded bytes "30 82 04 a5" where 0x04a5 is the content length and therefore the total key length is 1189+4=1193 bytes, three less than were originally included. And thank you once more for digging out the key, it makes life so much easier...


[Suggestion] Unbreakable (using the unbreakable tag)

Let's say you have a tool with Unbreaking 2 and the option to only make tools unbreakable with the max level enabled
As soon as you evolve into Unbreaking 3, the mod REMOVES the enchantment, apply the Unbreakable NBT Tag (vanilla, has a nice tooltip) and make the tool unable to receive Mending and Unbreaking (since it is already unbreakable)

or make it so if you right click a tool with max level Unbreaking with a Nether Star in your offhand, it consumes the star and makes the tool Unbreakable

sorry, i wasn't able to do it when using a nether star or as soon as you get the max level unbreaking so i decided to make the tool apply the unbreakable tag when the durability is reduced.


⚠ Bofrost.at has degraded performance

In 6b2a487, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1328 ms

Resolved: Bofrost.at performance has improved in 2e6a723 after 9 minutes.


Cant see any characters in vscode browser terminal in ipad

if I open vscode in browser in ipad，I cant see any characters interminal

does changing terminal.integrated.gpuAcceleration help?

does changing terminal.integrated.gpuAcceleration help?

Yes. Thanks!

gpu acceleration is not supported on certain versions of safari
/duplicate #165416


Tasks - Week 13 Feb

Review Actions
Review killMS.py
Pipeline for actions - test one tool.
Explore homogenisation of parameters (format, syntax and semantic). Matching.

I have created a workflow to test wsclean-3.2. It builds the image and perform a cleaning test whenever any file of its folder is modified

Added a Dockerfile and parameters of killMS and DDFacet


Would you be interested in adding snap support on Linux?

Feature description
NPM is a messy way for a user to install an app. Would you be interested in supporting a modern packaging format for your Linux users? Snaps, flatpaks and appimages would fit the bill. I've made a work-in-progress snap version at https://snapcraft.io/percollate which can be easily installed on any Linux distribution which supports snaps using snap install --edge percollate . I'd like to know whether it is worthwhile continuing to work on this, and whether you'd be interested in accepting the snap upstream when ready? There are issues with sandboxing clashing with snap confinement and at least one security issue to iron out as one of the generated binaries has an executable stack, but apart from this it already seems to run well.
Existing workarounds
It looks as if you've been working on docker support. For an end user, this is only marginally less messy than using npm. Supporting snaps or flatpaks would let users install your app from their favourite distribution's software store.
Many thanks for building this useful application!

Hi Neil, sorry for the late reply, I was away from the computer last week. Between this proposal and @pedrolucasp's PR here, coupled with some issues that people have been running into when installing from npm on Linux, it seems more reliable mechanisms are welcome.
I'll have to read up on AUR and snaps to understand what each would entail on my side, and how it interacts with npm releases, but otherwise I am open to offering as much flexibility as possible.

I'd like to know whether it is worthwhile continuing to work on this, and whether you'd be interested in accepting the snap upstream when ready?

If you could let me know, even in very general terms, how the process works, that would be very helpful. (I'll also dig up some official documentation to get up to speed.)

Thanks Dan. I've just been chatting to some of the upstream snap team about some of the issues in snapping your application. Let me hack on this a bit.
The end goal, if you're interested, is to add a snapcraft.yaml to your repo and connect this to Canonical's build infrastructure. They should build a snap every time you update the repo and add it to the --edge channel. When you make a stable release you should be able to drag this in the web gui to the --stable channel. The idea is for it all to be automated, and all you'd have to do is promote builds to stable when you want to.
The snap would be available to any Linux users who are running snapd. By default, that would be everyone on an Ubuntu-based distribution (which accounts for the majority of Linux users) and raspberry-pi users on Raspbian. Users of other distributions can add snap support quite easily but some of the support is quite shaky.
Alternatives would be flatpaks or appimages, but I'm much less familiar with those.
I'll let you know if I get something functional then create a pull request to discuss further, if that's OK?

Yes, perfect, thank you! I'd be glad to add it when you sort it out.

On Fri, Sep 25, 2020 at 04:56:27PM +0000, Neil McPhail wrote:

Alternatives would be flatpaks or appimages, but I'm much less
familiar with those.

I strongly recommend that we should not support flatpaks.
About flatpaks: https://www.flatkill.org and https://www.flatkill.org/2020/

https://www.reddit.com/r/linux/comments/9n50ba/lets_see_why_flatpak_and_sandboxing_are_awesome/
I think issues are being addressed by flathub and flatpak as well as repositories like flathub will improve.
Flatpak is a good solution and is better than snap.

I'd rather this didn't turn into a debate about different package managers, which has been repeated a thousand times before. My experience has been with making and using snaps, and I'm happy to work on making one for this project. If there's a flatpak which gets there first, I'd be happy to use that instead of a snap. I'm not knowledgeable enough about them to make one myself.
What I do know is that no solution is perfect, but any solution would be better than expecting a casual user to wrestle with npm. My proof of concept snap in the edge channel already "works", barring the security issues mentioned above, and is straightforward to install for a huge number of Linux users. But all I want is to be able to use this application easily; if flatpak or appimage does the job first I'm happy to switch.


WIP: helios-testing: refactor with breaking changes

This PR makes the following changes in order:

Make TemporaryJobs instead of the user manage HeliosSoloDeployment
Make HeliosSoloDeployment package local
Make helios-solo container have logic to clean up and kill itself to prevent leaked containers even when TemporaryJobs is SIGKILLed
one HeliosSoloDeployment per JVM process per test run

TODOs:

split TemporaryJobs into two classes - one that implements AutoCloseable and another that implements JUnit's Rule
delete other stuff?

CircleCI now takes twice as long to build :) I suspect many of the tests no longer make sense, eg HeliosIT or the tests that inherit TemporaryJobsTestBase.

Tests became flaky starting with at least commit e014893. Ignoring the mind-blown inception of HeliosIT deploying a helios master, ZK, and agent as separate containers using helios-solo, how is the agent job already deployed? https://circleci.com/gh/spotify/helios/4547. I don't see any other instances where we deploy the agent as a job.

is this ready for review? I am confused by the "WIP" titles

@gimaker Would you say this one is ready for review?

@mattnworb This is ready for review. I'm trying to keep each commit green and reviewable by itself when taken in order.

@davidxia great, will take a look today. Can we merge and release #927 first though, so that users can upgrade to it and not have to deal with any incompatibilities before having to deal with the incompatibilities in this change?

Yes, we can.
On Thu, May 26, 2016 at 9:35 AM, Matt Brown<EMAIL_ADDRESS>wrote:

@davidxia https://github.com/davidxia great, will take a look today.
Can we merge and release #927 https://github.com/spotify/helios/pull/927
first though, so that users can upgrade to it and not have to deal with any
incompatibilities before having to deal with the incompatibilities in this
change?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/spotify/helios/pull/922#issuecomment-221872106

--
David Xia
Software Engineer
<EMAIL_ADDRESS>

Reviewable, yes. Releasable... maybe.

Is it no longer possible to control REGISTRAR_HOST_FORMAT via the typesafe config file? If not, that will break a large number of internal user's tests.
If that functionality is unchanged then the TODOs in HeliosSoloIT seems incorrect

docs/integration_tests_with_helios_solo.md and probably docs/testing_framework.md should be updated as they are outdated now

If TemporaryJobs now managed HeliosSoloDeployment, is it intended or accidental that it doesn't close the HSD instance in TemporaryJobs.close()?

If TemporaryJobs now managed HeliosSoloDeployment, is it intended or accidental that it doesn't close the HSD instance in TemporaryJobs.close()?

Intended, if you ask me. I think it makes sense to decouple the lifetime of the HeliosDeployment from the lifetime of the TemporaryJobs instance.
For example, you might want to reuse HeliosDeployment across multiple tests, but clean up jobs after each of them. I think it's fair to make the user responsible for closing the HeliosDeployment.

@mattnworb regarding https://github.com/spotify/helios/pull/922#issuecomment-221967892. I'm pretty sure users can still specify REGISTRAR_HOST_FORMAT with a helios.conf file in their resources directory.
I had to change the SRV record in HeliosSoloIT because HeliosSoloDeployment is created automatically now by TemporaryJobs and I didn't know how to programmatically alter the helios.conf file in the resources file. So I'll remove the TODO. But let me know if there's a better way to test this or if I'm mistaken about the preservation of the functionality.

I'll hold off on updating the docs for now. Things are probably going to change. I noted it as a TODO in the PR description above.

I like the idea of including a documentation update in the PR that makes the change itself, so that it is much harder to forget to update the docs.

Yea, I was thinking the same.
On Tuesday, May 31, 2016, Matt Brown<EMAIL_ADDRESS>wrote:

I like the idea of including a documentation update in the PR that makes
the change itself, so that it is much harder to forget to update the docs.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spotify/helios/pull/922#issuecomment-222753523, or mute
the thread
https://github.com/notifications/unsubscribe/AAdVbQqszX9AEdm7Rd-C4F5XKvMejSr1ks5qHGotgaJpZM4IiRpz
.

--
David Xia
Software Engineer
<EMAIL_ADDRESS>


Creating a blue line for dragging tabs

💬 Description
A utility span component to render a blue line for dragging and hovering over a tab. It supports a left line, right line or a whole border.
✅ Checklist

[ ] Tests written
[ ] Browser tested
[ ] Added to documentation
[ ] Added to storybook

 Implement new tabs inside Structure editor


Tesseract version?

Thanks for the great work on this. I was wondering what version of Tesseract this uses?
Reason is I tested pgsrip via CLI against SubtitleEdit which uses Tesseract 5.2, and the latter seems to be more accurate with fewer errors, but I suppose that could also just be due to the config of tesseract in pgsrip.
Appreciate the help. Thanks.

psgrip uses the available tesseract that's installed. And you should also define where's the tess data to use with an environment variable.
In case you're using the docker image, the image was built three weeks ago using latest Debian bullseye, installing tesseract-ocr amd64 4.1.1-2.1 and using the trained data from https://github.com/tesseract-ocr/tessdata_best
Could you have examples of the output differences?
If the difference is because of the version, I could check how to install the latest on our docker image.
Otherwise only looking in detail the differences to see how to improve

Here's a zip with two files, one with the pgsrip output, and one that was generated by SubtitleEdit (tesseract 5,2)
srt_files.zip
Mostly it seems like the accuracy is off in the pgsrip version, there are missed spacings, incorrect punctuation, and also sometimes certain speaker names are not included (see subtitle #5).
I was not using docker, just running locally.

Now I understand and I can see the differences. Since you're not using the docker image, I'm assuming pgsrip is using exactly the same tesseract installation that subtitleedit is using. And I'm also assuming it is using the very same trained data as subtitleedit.
Let's point one by one:

pgsrip uses cleanit to post-process the extracted subtitle. The default rules/tags used by cleanit are:

ocr: Fix common OCR errors
tidy: Fix common formatting issues (e.g.: extra/missing spaces after punctuation)
no-sdh: Remove SDH descriptions
no-lyrics: Remove lyrics
no-spam

For instance, the bellow example shows cleanit removing the SDH descriptions from the subtitle:
subtitleedit
194
00:10:12,027 --> 00:10:13,195
ELLIOT:
Are you still there?

pgsrip
177
00:10:12,028 --> 00:10:13,196
Are you still there?

You can control what tags you want to use with the option -t, --tag:
  -t, --tag TEXT                  Rule tags to be used, e.g. ocr, tidy, no-
                                  sdh, no-style, no-lyrics, no-spam (can be
                                  used multiple times).

And you can even specify your own cleanit rules if needed:
  -c, --config PATH               cleanit configuration path to be used

Spacing issues / OCR errors:

pgsrip
388
00:25:04,420 --> 00:25:06,422
pointing toalistener
on Tyrell's machine.

For a given subtitle track, we create a single image (if the image gets too big, we could have 2 or more) and then we apply some image processing to prepare the input data for tesseract. It's mainly to have it monocromatic and with clear edges. This is not perfect, but enhances tesseract accuracy. In initial versions I was calling tesseract multiple times for each subtitle entry. Then I realized that putting all subtitles in a single image is better for tesseract's AI, so tesseract can see multiple occurrences of a given character. But the results can vary a lot depending on the subtitles font/style and also the image processing part. The only way to improve this is to fine tune some parameters, but I need to have the PGS to do that.
Another common OCR issue is when the wrong language is used/passed to tesseract. But I assume this is not happening, since pgsrip takes the language information from the track metadata.
I also see that subtitleedit does some post processing in the extracted subtitle, since some entries that are 3 lines are changed to 2 lines. Probably they also have some common OCR fixes applied in the subtitle.
For some issues that I see in pgsrip, a new rule in cleanit would solve them, for instance the following error is a good example:
182
00:10:29,671 --> 00:10:32,382
If I'm alive,
! must have been right.

I would like to improve pgsrip, but I would need the PGS used for that.
And one final thing, only if you're willing to try something else, you could check if running pgsrip from the docker image produces the same result or not.

I'm looking subtitleedit code and it seems they used their own trained data:
https://github.com/SubtitleEdit/support-files/tree/master/tessdata
Since tesseract is very powerful and generic, probably subtitleedit created their own trained data feeding the AI only with subtitles, which seems a good idea

I'm wondering in your case when running pgsrip, which trained data tesseract is using...
did you install tesseract yourself? did you downloaded any trained data? how are you executing psgrip?

I'm working on a Windows PC, so I had installed pgsrip using the instructions from the repo README.md into a WSL Ubuntu VM, so it should be completely logically separated from SubtitleEdit, which is installed on Windows.

Thanks for the information.
I published a new release with a few things:

I updated the instructions in order to install the latest tesseract.
I also tested a pure windows installation and updated the instructions for it
I added some more options to the cli to keep the extracted PGS file and to dump the generated image (that can help troubleshooting and to further optimize the image before hand it over to tesseract)

If you're still willing to help, you could execute with the following options:
pgsrip --keep-temp-files --debug -vvv  <your_media_path>
There should be some output pointing to a temporary folder where you could find the extracted PGS and 1 or more PNG files.
The PNG files could give us a hint how the image that we're passing to tesseract looks like. Maybe, depending on the subtitle font, the image processing needs to be enhanced and with that I could improve this tool.

I'm trying subtitleedit myself. I see there's plenty of options there...
What I found is that when using pure tesseract 5.3.0, without fallbacks and fixes I'm getting this error:

And if I put to fallback to tesseract 3.02, it parses correctly.
It seems subtitleedit has some dictionary to validate what was parsed and if there's some strange word, it tries fallbacks, like tesseract 3.02, and this old version of tesseract seems to be more accurate when parsing some font types/styles.

Thanks for the information.
I published a new release with a few things:

I updated the instructions in order to install the latest tesseract.
I also tested a pure windows installation and updated the instructions for it
I added some more options to the cli to keep the extracted PGS file and to dump the generated image (that can help troubleshooting and to further optimize the image before hand it over to tesseract)

If you're still willing to help, you could execute with the following options:
pgsrip --keep-temp-files --debug -vvv <your_media_path>
There should be some output pointing to a temporary folder where you could find the extracted PGS and 1 or more PNG files. The PNG files could give us a hint how the image that we're passing to tesseract looks like. Maybe, depending on the subtitle font, the image processing needs to be enhanced and with that I could improve this tool.

Here's the output from the debug command
1.en.srt-13-0.zip

I tweaked pgsrip to increase accuracy:

Added some border to the png image
Increased gaps between subtitle entries in png image
Switched tesseract from PSM 11 to PSM 6, since the text and font is uniform

Releasing a new version with it


PR template, like martin did for tree-sitter-javascript

See https://github.com/tree-sitter/tree-sitter-javascript/pull/171
test plan:
wait to see if get the template for my next PR
Checklist:

[ ] All tests pass in CI.
[ ] There are sufficient tests for the new fix/feature.
[ ] Grammar rules have not been renamed unless absolutely necessary.
[ ] The conflicts section hasn't grown too much.
[ ] The parser size hasn't grown too much (check the value of
STATE_COUNT in src/parser.c).

This implements https://github.com/tree-sitter/tree-sitter-javascript/issues/170 for the tree-sitter-java


Memory leak within canvas

This may be a core JavaScript issue but I have a bunch of Vizceral graphs that I'm loading one at a time via a drop down menu. The problem is when each graph loads, it sets the current Vizceral object to null in hopes of the JS garbage collector picking it up. There seems to be a memory leak, where the memory occupied by Vizceral is still present and this is eating up the browser memory. I am running on Mozilla Firefox 40 and I know this utilizes Spider Monkey as opposed to the V8 JS engine in Google Chrome. Thoughts? Is this a JS issue and not Vizceral related?

Did some more testing with the Chrome memory profiler and I'm seeing the memory increase during each new graph draw (graph update). I'm doing this (keep in mind Angular services keep state in memory):

// Angular service:
this.viz = null;

this.updateVizceral = function(data) {
   this.remove();
   if (this.viz === null) {
      this.loadVizceral(data);
   } else {
      updateData(data);
   }
};

this.loadVizceral = function(data) {
   if (!angular.element('#graph').html( )) {
      var graph = "<canvas class='vizceral' id='graph'></canvas>";
      angular.element('#graph-parent').append(graph);
   }
   var canvas = angular.element('#graph');
   var canvasWidth = canvas.clientWidth;
   var canvasHeight = canvas.clientHeight;
   this.viz = new Vizceral.default(canvas);
   this.viz.updateData(data);
   this.viz.setView();
   this.viz.animate();
   resize(canvas, canvasWidth, canvasHeight);
};

this.remove = function() {
   if (this.viz) {
      this.viz = null; // mark as removed for garbage collector
   }
};

The native updateData(data) should never be invoked since remove sets this.viz to null. The updateVizceral gets invoked with new API data for the selected graph and updates (generates) a new Vizceral graph with the new graph data. The API data returned from our REST endpoint contains the nodes, edges, and graph name. This works for our UI but the memory leak is definitely present.

It appears you're trying to create and destroy vizceral objects.  I would not recommend reusing the same canvas for every different vizceral object. I would recommend destroying the canvas and creating a new canvas anytime you want to create a new vizceral object.
That being said, destroying and creating vizceral objects multiple times was never a use case we considered, so there will probably be some leftover WebGL shaders and textures hanging around that aren't getting cleaned up properly.

@jrsquared I appreciate your response. You can see my user case though right? If I have a bunch of disconnected graphs that must be displayed, then what would be a better approach? Rather than having every sub-graph on one large, canvas where the number of nodes will approach 300 and eat up a ton of of the CPU/GPU time, we found that isolating these subgraphs and allowing a user to select what graph to display from a drop down menu was most beneficial. It seems to me like you're use case is that you have a graph with at maximum 75 nodes, and that is the only graph you need to visualize correct? Is the graph cyclic? I'm just trying to get a sense for what kind of a foot this shoe (i.e. Vizceral) can fit. Also I am destroying the entire canvas from the DOM every time a user clicks on a new graph to display from the menu with:
angular.element('#graph').remove(); // there is a canvas directive with the id of 'graph'

Essentially I'm just doing a massive tear down and reconstruct (redraw) of the graph based off of the new nodes and edges.

We have multiple graphs of 100-200 nodes, with another graph for each node being loaded into a single vizceral object. Effectively ~600 graphs that can be navigated between each other; very similar to vizceral-example, just larger.
That is very interesting.  They may be a memory leak when destroying vizceral and maybe it should have an explicit teardown function. Please let me know what you find!

I'm testing in Firefox 40 and Chrome 40. I have managed to get the graphs to load properly but each reload, slows down the animated tics between nodes and eventually Firefox cores. Seems like there's something or things lying around and I'll keep looking through it. I prefer Chrome to FF because of Chromes impressive memory profiling tools, but most of our users are using Firefox, so I may need to profile with Chrome and then reexamine Firefox.

@jrsquared How hard would it be to create an explicit teardown function? Perhaps have something so that we can do the following:
this.remove = function() {
   if (this.viz) {
      **this.viz.teardown(); // explicitly tear down Vizceral WebGL objects**
      this.viz = null; // mark as removed for garbage collector
   }
   angular.element('#graph').remove();
};

It probably wouldn't be too difficult, I look forward to your pull request.

Ha! Well... I'll see if I can get around to it.  Can you cover it? ;-)

Have no fear! The PR review process will help prevent you from messing something up :D  We look forward to the contribution.

@aaronblohowiak so far my time is maxed but yes if I do get around to it post grad school I'll check it out. I found for the time being that a page refresh on each click works for me. It's a bit sloppy and the user will notice a page reload but it does work. I'll have to put this ticket on my TODO list along with PhantomJS based unit tests with Karma and Gulp code coverage. :+1:


MariaDB image for apple M1

Hello, I saw this issue and comment https://github.com/wodby/docker4drupal/issues/465#issuecomment-785844022. According to this comment the mariaDB supports arm64, but for me it does not look like true:
Output of docker inspect $(docker images | grep "wodby/mariadb" | awk '{ print $3 }') -f '{{.Architecture}}'
amd64

So, is it expected behavior and everything is fine or I have to configure something?
Output of docker info
Client:
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc., v0.8.2)
  compose: Docker Compose (Docker Inc., v2.6.1)
  extension: Manages Docker extensions (Docker Inc., v0.2.7)
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc., 0.6.0)
  scan: Docker Scan (Docker Inc., v0.17.0)

Server:
 Containers: 3
  Running: 3
  Paused: 0
  Stopped: 0
 Images: 3
 Server Version: 20.10.17
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
 runc version: v1.1.2-0-ga916309
 init version: de40ad0
 Security Options:
  seccomp
   Profile: default
  cgroupns
 Kernel Version: 5.10.104-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 1
 Total Memory: 1.928GiB
 Name: docker-desktop
 ID: FKWQ:LLHO:Q72C:MXUA:EONZ:T6US:HZ5N:X2CU:JTZR:RIPH:QD7L:74ZT
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5000
  <IP_ADDRESS>/8
 Live Restore Enabled: false

Contents of your docker-compose.yml
version: "3"

services:
  mariadb:
    image: wodby/mariadb:$MARIADB_TAG
    container_name: "${PROJECT_NAME}_mariadb"
    stop_grace_period: 30s
    environment:
      MYSQL_ROOT_PASSWORD: $DB_ROOT_PASSWORD
      MYSQL_DATABASE: $DB_NAME
      MYSQL_USER: $DB_USER
      MYSQL_PASSWORD: $DB_PASSWORD
    ports:
      - "3306:3306"

Contents of your .env
DB_ROOT_PASSWORD=password
DB_NAME=drupal
DB_USER=drupal
DB_PASSWORD=drupal

MARIADB_TAG=10.8-3.21.2

we've removed the builds for arm64 for now because the cross-compilation doesn't fit in gh actions 6 hours limit and gh actions has no arm64 machines support https://github.com/wodby/mariadb/issues/36

Clear, do you have any plans to solve it somehow in the future?

Clear, do you have any plans to solve it somehow in the future?

I am using image: arm64v8/mariadb:10.3. Work fast and fine

I know it would be better to have ARM images for MariaDB, but for those who just wants to get their project started, the latest wodby/mariadb image that supports M1 is 10.4-3.13.21, so you can use it in your .env file like so:
MARIADB_TAG=10.4-3.13.21

Can we please have a fix for this asap?


Not working with current replays

Are there any plans to get this working with the current version of the game? I think this is a very interesting tool and want to try to make something using it but can't get it to work on the current replay files.

The tool should be updated for 8.04 now. There are two unknown variables in GameSettings, if you know what they are feel free to contribute.

Thank you! I still am getting an error "Error: Second version check does not match first version check" but that might be user error.

Just double check you’ve installed the latest version, might be worth running from source in case there’s been any publishing issues.Feel free to upload your replay file or post your discord username and I can have a look for you.On 15 Feb 2024, at 18:21, J-Sears @.***> wrote:
Thank you! I still am getting an error "Error: Second version check does not match first version check" but that might be user error.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I've made sure that I've installed the latest version and I'm still encountering the error. Here's the replay file I've been trying to open, it's just the most replay file in the folder. I might have node.js configured improperly or am not installing the command line tool properly. I appreciate all the help with this.
[8.04] DemonIsland.zip

Seems like it was a publish issue<EMAIL_ADDRESS>should fix this.

Problem is fixed and the reader is working, thank you so much for the help!


Transfer fails

Current Behavior

Transfer doesn't complete.
Expected Behavior

Transfer should be completed successfully.
Steps To Reproduce

Initiate negotiation.
Validate Negotiation state FINALIZED.
Initiate transfer.
Check Transfer State.

Related to: eclipse-edc/Connector#3810
Possible Fix

Generate a private / public key pair and store it in connector's vault.
Define vault keys as connector config. Check config details here.

The fix solves not the complete problem see (https://github.com/eclipse-tractusx/tutorial-resources/pull/232#issuecomment-1932036523).  It looks like that the created token has an invalid signature.


[ansible] add cluster_public_hostname

The cluster_hostname is already present (to be able to reach the
private/internal vip kube api).
The goal of cluster_public_hostname is to have the same thing but for
public access to the api.
If the public vip domain is not part of the certificat, when you will
try to access to the api via kubectl you will have something like that :
Unable to connect to the server: x509: certificate is valid for
cluster_hostname, master0, master1 ..., not cluster_public_hostname

This change is

I signed it!

I signed it!

I signed it!

@redhat-k8s-bot test please

Suggested changes have been applied

@redhat-k8s-bot test please

/lgtm
/approve


Wireing correct but no Display output

Uploading the code  and the Wifi Setup works perfectly.
I even can reach the WEB GUI of myClock with a web browser.
But the display shows nothing.
Before I tried the first version of the Morphing Clock (https://www.instructables.com/id/Morphing-Digital-Clock/). This works with no problems. The display shows the time.
I also tried the PXMatrix examples. All the examples worked.
So the wireing seems to be correct.
Any ideas?

Found the problem.
Had to uncomment "#define double_buffer"

Odd! I tried recompiling  with latest library and now mine no-longer requires that double_buffer, and does not work, with it. Previously it was required. Not sure what changed, but thanks for the find! :)

In the file display.h you may need to comment out the double_buffer line
like:
//#define double_buffer
On Sat, Mar 21, 2020 at 3:53 PM flighter18<EMAIL_ADDRESS>wrote:

Uploading the code and the Wifi Setup works perfectly.
I even can reach the WEB GUI of myClock with a web browser.
But the display shows nothing.
Before I tried the first version of the Morphing Clock (
https://www.instructables.com/id/Morphing-Digital-Clock/). This works
with no problems. The display shows the time.
I also tried the PXMatrix examples. All the examples worked.
So the wireing seems to be correct.
Any ideas?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dragondaud/myClock/issues/23, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGM5GPXTOHEQVBK6NCR5FUDRIUZORANCNFSM4LRB43HA
.

--
david denney
dragondaud AT gmail DOT com
719-821-8900


Remove methods referencing individual URLs as parameters

As discussed in the mtg [1] we should remove all methods (joinLRA, updateCompensator) that reference individual participant URLs (compensate, complete, forget, status, leave) and allow only methods that take annotated resource classes.
[1] https://docs.google.com/document/d/1HBPiXpsXcQp9T8JeoT-IDs-EblZX1SxuTV5qjUPzwrM/edit#bookmark=id.b81wa02cige

Just to be clear, I think URL returned from joinLRA is still allowed and methods that take "LRA recoveryURL" parameter are still allowed - it's not clear from the title of the issue but I think this just applies to participant

@tomjenkinson understood, I thought "individual URLs" would be enough to clarify. Would you like me to rename it?

Your confirmation via that comment is sufficient in my opinion - thanks for the response

Closing as PR is merged


Vertical split with system settings not working properly

Describe the bug
There is no gap between System settings and any other application. It looks like system setting is truncated and not resized.
To Reproduce
Steps to reproduce the behavior:

Install Polonium
Activate Polonium
Log in and out to make sure it works
Open system settings and make it split vertically as per screenshot

Expected behavior
There should be a gap and resizing between system setting and the other app.
Log
No output from journalctl --user --no-pager -e | grep "Polonium"
Screenshots

This may be because the system settings window has a minimum window size, as a workaround you can add a window rule for that window (or all windows) where you manually override the minimum size of the window to something much smaller

I'll look into it, thanks

I tried this and it works on X11 but not on wayland for some reason.. Seems like system settings ignores my window rule for requested minimum window size when on wayland


fix: empty string causing url widget validation to trigger

Fix for #887
Steps to recreate this bug:

Log in as bc-cas-dev
Go to operator form
Edit the website field and remove the URL all together and save
Click edit again and try to save
The URL validation triggers because django is returning empty string

To solve this I have added a useEffect which will convert an empty value to undefined so validation won't erroneously trigger.

Thanks for tackling this one; it's been such a pain!
The main operator form works well now, but something's gone wrong with the parent operator form. I have to double-click the button to show the form and then once I start typing, the radio box goes back to "no".
Another way to fix this bug might be to set the rjsf default value to "undefined" (haven't tested it, just a thought)

Wow what a catch haha. Seems like the useEffect gets triggered no matter what since RJSF re-renders the entire form as you use it. I had considered adding a default value but it seems like a bit of a band aid solution and someone might run into the same problem in the future.
I tried removing the useEffect dependencies so it would only run once and it was still causing issues. So I've removed the useEffect all together and just run the onChange without it and this seems to be working well and no funny business with the array fields. Let me know what you think.