Add CopyInterceptor support to SelectionArea

Spiritual continuation of https://github.com/flutter/flutter/pull/126835

Right now, copying text in a SelectionArea copies it with no separation. Since SelectionArea is very useful with vertical lists of Text widgets this is not ideal. This PR adds a copyInterceptor field to SelectionArea so that developers can add custom copy behavior to SelectionArea widgets.
https://github.com/flutter/flutter/issues/104548
I added a new test for this
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai Let's see if we like this one

MultiSelectableSelectionContainerDelegate is abstract and requiring users to create their own delegate class for that behavior seems overly complicated. Maybe we need a new intermediate widget to handle it?

Something like this maybe?
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';

class SelectionInterceptor extends StatelessWidget {
  const SelectionInterceptor({
    super.key,
    required this.copyInterceptor,
    required this.child,
  });

  final CopyInterceptor copyInterceptor;
  final Widget child;

  @override
  Widget build(BuildContext context) {
    return SelectionContainer(
      delegate: _SelectionInterceptorContainerDelegate(copyInterceptor: copyInterceptor),
      child: child
    );
  }
}

class _SelectionInterceptorContainerDelegate extends MultiSelectableSelectionContainerDelegate {
  _SelectionInterceptorContainerDelegate({required super.copyInterceptor});

  @override
  void ensureChildUpdated(Selectable selectable) {
    // TODO: Do we need to do anything here?
  }
}

Well that code didn't work and these delegates seem overly complicated to design. Can we just reuse the _SelectableRegionContainerDelegate?
class SelectionInterceptor extends StatelessWidget {
  const SelectionInterceptor({
    super.key,
    required this.copyInterceptor,
    required this.child,
  });

  final CopyInterceptor copyInterceptor;
  final Widget child;

  @override
  Widget build(BuildContext context) {
    return SelectionContainer(
      registrar: SelectionContainer.maybeOf(context),
      delegate: _SelectableRegionContainerDelegate(copyInterceptor: copyInterceptor),
      child: child
    );
  }
}

@Rexios80 I agree, I think having to create a delegate right now is complicated. We can make it easier for users to create a SelectionContainerDelegate if we re-used _SelectableRegionContainerDelegate and made it public.
Then they can do the following, without an intermediate widget:
SelectionContainer(
  delegate: MySpacesCopyInterceptorSelectionContainerDelegate(),
  child: Row(
    children: <Widget>[
      const Text(
        'Text widget 1',
      ),
      const Text(
        'Text widget 2',
      ),
      const Text(
        'Text widget 3',
      ),
      const Text(
        'Text widget 4',
      ),
    ],
  ),
),

class MySpacesCopyInterceptorSelectionContainerDelegate extends _SelectableRegionContainerDelegate {
    @override
    CopyIterator get copyIterator => CopyIterator.spaces;
}

What do you think?

I think having users create any class at all is too much work to achieve this behavior. If the SelectableRegionContainerDelegate is public couldn't they just use it directly instead of subclassing?

I think having users create any class at all is too much work to achieve this behavior. If the SelectableRegionContainerDelegate is public couldn't they just use it directly instead of subclassing?

I think your code in this post works https://github.com/flutter/flutter/pull/146625#issuecomment-2052648650 , but I don't think we need an intermediate widget if we are making SelectableRegionContainerDelegate public.
My other concern is similar to https://github.com/flutter/flutter/pull/146625/files#r1563001791 . For Text, exposing copyIterator may sometimes produce unexpected behaviors because a Text widgets RenderParagraph will internally split its text into multiple Selectables in the case when WidgetSpans are involved. In that case i'm not sure how useful exposing copyIterator is here.
I think the expected behavior of copyIterator on SelectionArea/SelectableRegion can also be unclear when you have a complex layout with many widgets that may be selectable. This is because a selectable may be either a single Selectable, or a SelectionContainer that may manage multiple Selectables, so it's not clear what widgets copyIterator is actually affecting when declared under a SelectionArea/SelectableRegion. This has me leaning towards keeping this functionality configurable through wrapping a desired subtree with a SelectionContainer and a configured delegate.

If that's the case then we can just create a delegate such as this
class CopyInterceptorContainerDelegate extends _SelectableRegionContainerDelegate {
  CopyInterceptorContainerDelegate({
    required this.interceptor,
  });

  final CopyInterceptor interceptor;

  @override
  SelectedContent? getSelectedContent() {
    final List<SelectedContent> selections = <SelectedContent>[];
    for (final Selectable selectable in selectables) {
      final SelectedContent? data = selectable.getSelectedContent();
      if (data != null) {
        selections.add(data);
      }
    }
    if (selections.isEmpty) {
      return null;
    }
    return SelectedContent(plainText: interceptor.intercept(selections));
  }
}

and revert the rest of the changes in this PR. My concern with doing it this way is user discoverability of this feature. With a copyInterceptor field discoverability is easy and we can even provide default behavior.

@Rexios80 I understand your concern about discoverability but I'm a little hesitant to add copyIterator to widgets were the behavior might be ambiguous. I think we should still keep the defaults you have defined in this PR as they are useful. The defaults for Text and Scrollable are reasonable, though I am unsure about having a default for SelectionArea/SelectableRegion other than none, what do you think?
We should also make it easier for users to create a SelectionContainerDelegate so they can easily wrap subtrees with a SelectionContainer with custom handling. If someone wanted to change the "global" copyIterator like this PR does in SelectionArea.copyIterator, one would just need to wrap the child given to SelectionArea with a SelectionContainer with their custom delegate.
I think we could always add a copyIterator field to these widgets later if we see a need for it.

@Renzo-Olivares I agree that having the default separator as none for SelectionArea/SelectableRegion makes more sense, however I'm not sure I agree with removing the copyInterceptor constructor parameter entirely. Removing that parameter would require users to always use 2 widgets to create a SelectionArea with proper copy support unless the child widget is one of the ones we are adding copy interceptors to in this PR.
I also agree that it makes more sense to use SelectionContainers for nested interceptors instead of nesting SelectionAreas, but I'm still considering having a separate widget so it's easier to discover/use.

I'm not sure we would need to "penetrate" SelectionContainers. If we were to add a SelectionContainer to a widget that would need a copyInterceptor, it would extend the MultiSelectableSelectionContainerDelegate which forces you to implement the copyInterceptor parameter.

I'm not sure we would need to "penetrate" SelectionContainers. If we were to add a SelectionContainer to a widget that would need a copyInterceptor, its delegate would extend the MultiSelectableSelectionContainerDelegate which forces you to implement the copyInterceptor parameter.

What I meant is if we add a SelectionContainer for a inside a widget, it will override all copyinterceptor above.
My Idea is we can do it through inheritedwidget, so that customer would have full control over the copy. One Idea is to add it to DefaultSelectionStyle

@chunhtai I made a proof of concept for using a widget for this. Please let me know what you think.

Hey @Rexios80 thanks for the updates. It looks like there are some failing checks, can you take a look?

@Piinks I've already rewritten this PR 4 times. I don't want to put effort into fixing CI if we don't like the idea.

@chunhtai do you have any thoughts?

(Triage) Hi @Rexios80 what is the status of this PR?

@Piinks to move on I need to know what method we want to use to accomplish this. If someone could point me in the right direction I can rewrite this (hopefully) one last time.

Going along with what @chunhtai and @Renzo-Olivares suggested, I'm probably going to rewrite this PR using DefaultSelectionStyle to hold the copyInterceptor.
I just haven't had time yet. If anyone has an objection to this approach or would like to implement it themselves please comment.

I will make a new PR when I have a chance to make the new implementation


Preview is not at the correct position on iPad

I played with some of the examples showing preview on my iPad Pro. I found that the previews are showing at weird positions. Unlike desktops that the previews are near my fingers, on iPads, the previews are very far away from my fingers. Wonder if anyone runs into similar issues and how to fix it. Thanks a lot!
Steps to reproduce the behavior:

Visit the following example links on an iPad and try to drag things around
Single Target
Copy or Move

A screenshot is attached.

iPad Pro 10.1"

OS: the latest iOS,
Browser: Safari
Version

I noticed the following note:
For touch support, use React DnD with the touch backend instead of the HTML5 backend.
I will put in code to detect if user is on an iPad or not. If yes, switch to use the touch backend. Hope that touch devices can be officially supported by React DnD at some point.


add Ukrainian translation

This pull request adds a Ukrainian translation file.
Also, I found out that building the mod on a Windows machine results in an encoding problem for Unicode characters.
I think that's the Gradle-related issue, and mods I worked with use this snippet as a fix:
tasks.withType(JavaCompile).configureEach {
    it.options.encoding = "UTF-8"
}

but I unfortunately couldn't find where to put it in your project.

Thanks again for the contribution! :D

Also, I found out that building the mod on a Windows machine results in an encoding problem for Unicode characters. I think that's the Gradle-related issue, and mods I worked with use this snippet as a fix:
tasks.withType(JavaCompile).configureEach {
    it.options.encoding = "UTF-8"
}

but I unfortunately couldn't find where to put it in your project.

That's since I've centralized my build scripts into a gradle plugin, but the encoding is already set to UTF-8.
For reference, take a look at the ModMaster Plugin.


(add | remove)_(request | response)_headers should be able to be set globally

Currently

add_request_headers
add_response_headers
remove_request_headers
remove_response_headers

Are only able to be set on a Mapping. We should extend this to be set on all routes globally by adding them to the ambassador Module.

Anybody have thoughts on this? Would also like to see this


[HOLD for payment 2024-10-29] [$250] [Dupe Detection] Unable to resolve duplicates on one-expense reporrts

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727339112704349
Action Performed:

Create a new workspace, upgrade to Control
Make sure you’re on the duplicate detection beta
Enabled delayed submission with a weekly frequency. Enable approvals (with you as the approver)
Have user a submit a report, with the merchant McDonalds for $50. Approve the report
Have the user create another expense report for the same merchant and amount (McDonalds and $50)
Have the user submit the report

Expected Result:
The approver is able to resolve a duplicate
Actual Result:
The approver is unable to resolve the duplicate, as no resolve duplicate button appears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839321413603387914
Upwork Job ID:<PHONE_NUMBER>603387914
Last Price Increase: 2024-09-26

Issue OwnerCurrent Issue Owner: @sobitneupane

One way we could handle this is by adding a Resolve duplicates button to the header, like so:

cc @JmillsExpensify @Expensify/design

Nice, I like that idea!

Same. Looks good to me

@shubham1206agra The duplicates might be in a different report

Thanks for the proposal @daledah

We should remove canUseDupeDetection check in

I am not sure how is the change related to this issue. Dupe Detection is behind beta and the function is serving the purpose.
Can you please add more details to the 2nd point in your proposal.

@sobitneupane thoughts now?

Thanks for the proposal @daledah
We would prefer not to display the 'Resolve Duplicate' button in the Expense Report that contains several "batched" expenses, as shown in the Result section of your proposal.

Currently, we already display the 'Resolve Duplicate' button within a transaction for Expense Report that contains several "batched" expenses. However, when there is only one expense, the button is not shown. The only page where we would like to add the 'Resolve Duplicate' button is:

Expected UI: https://github.com/Expensify/App/issues/49793#issuecomment-2377242596

@dannymcclain  Should we use the text "Review duplicates" instead of "Resolve duplicate", since that is the term currently being used? https://github.com/Expensify/App/issues/49793#issuecomment-2377242596

Should we use the text "Review duplicates" instead of "Resolve duplicate", since that is the term currently being used?

This is a good question for @JmillsExpensify — I'm tempted to say let's use the language we already have, but I'm not 100% sure.

Yeah, let's keep the language that we already have, no need to change it for now.

@daledah when can we expect updated proposal?

Thanks for the update, @daledah.
The proposal from @daledah looks good to me. However, we still need some styling changes to achieve the requested UI.
🎀 👀 🎀 C+ reviewed

Assigning @daledah to the issue!

Awesome, thanks for the quick work on this one!

Reassigning as I head to parental leave next week! Thanks Matt!

@daledah , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021853927916382654201
@sobitneupane , plz fill out the BZ checklist above, I imagine we want a test case for this

Regression Test Proposal

Create an expense report and submit it in a control workspace.
Create another report with the same amount and merchant as step 1.
Open the expense report submitted in step 2
Verify that: "Review duplicates" button appears.

Do we agree 👍 or 👎

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ]  [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/40153

[ ]  [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/40153#issuecomment-2459870163

[ ]  [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ]  [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[ ]  [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

https://github.com/Expensify/App/issues/49793#issuecomment-2459847200

Contributor: @daledah paid $250 via Upwork
Contributor+: @sobitneupane owed $250 via NewDot
Test case created

https://github.com/Expensify/Expensify/issues/442377

Thanks!

$250 approved for @sobitneupane


SDN re-deployment wizard cannot be displayed if Customer want to deploy again

[Enter feedback here]
HI Team,
we have a customer deployed SDN via WAC, but for some reason, customer want to redeploy it agian. We follow the doc that remove NC and NC host agent resgistry settings, but the SDN deployment wizard cannot be displayed, then casuse customer cannot deploy the SDN again. Finally, we just remove the cluster from WAC and then add the cluster to WAC for management, the we can see the SDN deploy wizard. So  i just want to let you know if we can add this steps to make the steps more accurate and save customer time and efforts, thanks !
BR,
Jason Mei

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 842bf434-fd3f-5a56-4dee-794858175bed
Version Independent ID: 779df781-d6a7-0a43-1f1a-2fc66eb9e82f
Content: Deploy SDN using Windows Admin Center - Azure Stack HCI
Content Source: azure-stack/hci/deploy/sdn-wizard.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @ManikaDhiman
Microsoft Alias: v-mandhiman

@JasonMei11
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@ManikaDhiman
Can you please check and add your comments on this doc update request as applicable.

Hi @VikasPullagura-MSFT, I started an internal thread to review this issue and update the article as needed. Thanks!

Hi @JasonMei11: Thanks for your feedback! The Redeploy SDN Network Controller section is now updated with an additional step as described in your feedback. Thanks again for helping us improve our docs!
@VikasPullagura-MSFT: Please review the changes and close this issue. Thanks!
#please-close


Host crash when client join on duplicant choose menu

If my friend join my game when i choose my 3 first duplicants the game crash for me

Duplicate of #30


Blank line as statement delimiter issue

Hi,
My version of DBeaver is 4.2.2
In my "Preferences", I have configured the SQL editor to have the blank line as statement delimiter.
This works fine, except when the last line of the first statement finishes with a comment.
Exemple:
SELECT 1

SELECT 2

This works fine
But:
SELECT 1 -- This is my comment

SELECT 2

The blank line is no more considered as a statement delimiter and I get a syntax error.
Regards,
Cedric

Hm, I can't reproduce that.
Note: in script mode (alt+x) blank line never works as delimiter, only in single query mode.
BTW do you use the most recent version? There were some issues with trailing comments in some version.

Thanks for your answer.
My DBeaver version is the most recent version (4.2.2), with Linux Mint as OS.
I'm using it with PostgreSQL 9.6, where I get the issue. But if I try the same with SQL Server, it works.
So, it seems related to PostgreSQL.

This is quite odd. As scripts are parsed on client side and it doesn't depend on database type.
And I can't reproduce that (if I copy-paste you example abode in DBeaver for PG9.6 - it works like a charm).
Please check your script doesn't contain any special characters (which may look like spaces) in some special encoding.

This is probably because I'm not clear enough in the steps to reproduce it.
OK, here is what I do:

create a new script
write "SELECT 1", and execute the query with cursor at the beginning of the line => OK
add a blank line
write "SELECT 2", and execute the query with cursor at the beginnig of the line => OK
go back to the end of the first line, add a space and a comment like " -- this is a comment", then execute the first query with cursor at the beginning of the line (without selecting any word) => error message.

I hope it could help to reproduce.

I'm quite sure this was fixed a time ago. Please reopen if this problem persists.


solc: 0.8.2 -> 0.8.12

Motivation for this change
solc updated. This time hopefully for real.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Any updates on this? I would like to be able to use the LSP included in 0.8.11 with Kate. :( @akru @lionello @dbrock

Can someone with merge permission help merge this?

Seems that solc.passthru.tests fails (log)?
Testing Python scripts...(B
..........................................................
----------------------------------------------------------------------
Ran 58 tests in 0.010s
OK
Testing LSP...(B
./scripts/tests.sh: line 87: ./scripts/../scripts/test_solidity_lsp.py: No such file or directory
builder for '/nix/store/ygmzlfc7kd9dvm28ih60g5fylvrwv7yi-solc-0.8.12.drv' failed with exit code 127
error: build of '/nix/store/ygmzlfc7kd9dvm28ih60g5fylvrwv7yi-solc-0.8.12.drv' failed

Seems that solc.passthru.tests fails (log)?
Testing Python scripts...(B
..........................................................
----------------------------------------------------------------------
Ran 58 tests in 0.010s
OK
Testing LSP...(B
./scripts/tests.sh: line 87: ./scripts/../scripts/test_solidity_lsp.py: No such file or directory
builder for '/nix/store/ygmzlfc7kd9dvm28ih60g5fylvrwv7yi-solc-0.8.12.drv' failed with exit code 127
error: build of '/nix/store/ygmzlfc7kd9dvm28ih60g5fylvrwv7yi-solc-0.8.12.drv' failed

Looks like it's an upstream issue. The specified file does not exist (relevant commit: https://github.com/ethereum/solidity/commit/927b24df1f37cdffc794a74081cfb37d01d47c17), but judging by the CircleCI config, it should be pointing to test/lsp.py. Could be a good idea to patch it upstream if this is indeed the case.

solc 0.8.13 has been released, but it takes forever to compile on my system. Could someone check out that it does work well? Also merge it to master while we are at it.

solc 0.8.13 has been released, but it takes forever to compile on my system. Could someone check out that it does work well?

Not the case for me, it only takes 5 minutes on my desktop

bruhs, bumping this. It's only a matter of merging. @akru @lionello @dbrock


Freedrive Controller

The PR aims at introducing the possibility of enabling the freedrive mode through the ROS2 driver. It relies on the implementation of a specific controller to handle it, in order to correctly deactivate other controllers and avoid unsafe jumps of the robot once the freedrive mode is switched off.

Would an action be nicer, semantically?
Start of action -> enable freedrive.
Cancel action -> stop freedrive.
The goal client handle would become something similar to a 'token' or 'mutex' (not exactly, as it wouldn't be as safe or strict, but conceptually).
Concurrent goal -> reject (something/someone else already has 'control' of the freedrive mode).
it would also make it (slightly) harder for something to take over control of the robot by just spamming Bool messages.
And it would make it semantically clearer it control some specific functionality (ie: because a custom action goal needs to be submitted, instead of a generic Bool).

One aspect that would need some thought though: time-out (ie: when should freedrive be stopped due to the client no longer 'responding').
There might be some way to exploit liveliness QoS or something, but I'm not sure how that would work with actions.

Currently reached a first version working state, still missing:

[ ] Handling timeout
[ ] Tests

Tested on URSim, requires #34.

High-level comment (nice work already though): the (proposed?) action is called EnableFreeDriveMode.
To me (non-native speaker though) this implies the action of enabling freedrive mode -- so changing the state of the robot from not in freedrive mode to having freedrive mode active -- is what this is about.
I realise something like "keep-robot-in-freedrive-mode" is a bit silly as a name, but that seems to be more what this controller does, correct?

One aspect that would need some thought though: time-out (ie: when should freedrive be stopped due to the client no longer 'responding').
There might be some way to exploit liveliness QoS or something, but I'm not sure how that would work with actions.

I wrapped my head around this and I currently don't see a way of doing this.
One option would be to use a separate topic for a keepalive signal that could be used opt-in or opt-out, but that feels like a cumbersome workaround.

High-level comment (nice work already though): the (proposed?) action is called EnableFreeDriveMode.

I was also stumbling upon that. Maybe "use freedrive mode" could be a proper label? That could imply that, as long as this action is running, the robot's freedrive mode is used. I don't quite like the word "use". Matching synonyms could be "utilize", "operate", "run".

I see the point on the action name and I agree that "enable" is not the best choice to describe what the action does. If we exclude using two words (like StartandKeepFreedriveMode),  I would also choose something similar to "use", and tha regard maybe I like "run" more.

I wrapped my head around this and I currently don't see a way of doing this.

I haven't looked into it, but would there be a way to retrieve the liveness QoS data/settings for the feedback or perhaps status publisher and see whether it's still connected to a client?
It might need some unorthodox reaching around/into the action-machinery, but DDS certainly supports these kinds of things.

I've been testing around with that already on https://github.com/fmauch/Universal_Robots_ROS2_Driver/commit/f3a2e3d170e7ab554ff04edd42224c3dd989ce88 (Another feature branch, another action, but I just had that at hand).
Setting a lifespan (which seemed the most obvious thing for me) of 100ms seemed not to have any effect. My test was running a trajectory through our example_move script and then exiting that script during motion.
One question is, whether the underlying action server implementation would care at all, if this would happen. If the message would expire on a DDS level - would that even be visible to the publisher / the action server? Then, API access is a whole other story.
But thank you for supporting me that I have been poking in the right direction.

Setting QoS is just one thing that would be needed. I would probably go for Liveliness instead actually.
You'd then have to register a callback to be called whenever the Liveliness requirements are no longer met.
I can't really look for it right now, but I'm pretty sure I've seen discussion/PRs around callbacks for these kinds of events in the ROS 2 stack (perhaps even at RMW level).

I just tested things locally and had discussions with others.
I would like to stick with the heartbeat topic instead of the action as we had it initially for now because of the following reasons:

Handling timeout using the action doesn't really seem straightforward. From my understanding (and that of my colleagues who know QoS stuff better than I do) it is not intended for a publisher to know whether or not a certain subscriber went away or not.
Some people were also saying that this is a great misuse of an action. From their point of view an action should be something that's requested for execution, informs the caller about the progress while executing the thing and then finishing at some point either successful or not. Our action here is never supposed to be finished and we don't give the caller any feedback (we could think of some, though). Instead, we want feedback from the caller, whether it is still alive or not.
With local tests the action wasn't even reliably canceled when using ros2 action send goal from the command line. As long as we haven't figured out a reliable way to handle timeout, I don't really want to take that route.
Using the heartbeat topic should be straightforward to use. Yes, there can be potentially multiple clients requesting to keep freedrive mode active but that's easy to debug with standard ROS tools.
Others have come up with using the heartbeat topic, as well, e.g. https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/pull/718

I'm not saying that this is the right interface to use, but for the sake of getting this PR forward to a mergable state, I would say that another, maybe semantically more meaningful interface can be added at a later stage.

I just resolved the conflicts with the main branch. @VinDp is this ready to review?

@Mergifyio backport humble


Sni/configuration with class loading using reflection

Make default configuration with reflection to load factories and member injectors.

Coverage decreased (-0.2%) to 94.573% when pulling 5ebb79361fbae55f0f2b101c0b0c261f7f0c3aa0 on sni/configuration-with-class-loading-using-reflection into 20e935a47239977e9e14b0f0778e2c645bdcd6ba on master.

Coverage decreased (-0.2%) to 94.538% when pulling 769966ff33b3ff7e6a9745b7f528b9247a4e06c8 on sni/configuration-with-class-loading-using-reflection into 20e935a47239977e9e14b0f0778e2c645bdcd6ba on master.

Some comments and then 👍

RTM when green

Changes Unknown when pulling 66101af44454505cefbb7a58ecd0aa7acbd04d4d on sni/configuration-with-class-loading-using-reflection into ** on master**.


std.logger 32 bit unittest race condition fix

@WalterBright maybe this helps. From the errors I saw, there is a race somewhere on 32 bit.

thank you

Same test is still failing for me in https://github.com/dlang/phobos/pull/8555

Judging from the message I saw (foo), the race is between the test modified in this PR and this test, which also accesses sharedLog.

I think I understand the problem. The created thread executes code after the test is done. It has to be joined before the test is over. I'll create a PR.


patterns.map is not a function

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 7

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
angular-cli: 1.0.0-beta.28.3
node: 6.6.0
os: win32 x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/compiler-cli: 2.4.6

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
I upgraded from beta 16 to beta 28.3

The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.
I updated angularjs from 2.0 to 2.4. This required me to update my cli as well. However since the update I am not able to run my project on localhost. I get "patterns.map is not a fumction" error when running "ng serve" command.

Thanks! We'll be in touch soon.

@kumaraksi if you not did so after upgrading your packages, can you remove node_modules and npm install ?
Also, please note that the latest version of the project lives in the @angular/cli package.
To work with this version uninstall angular-cli globally: npm uninstall -g angular-cli, locally npm uninstall --save-dev angular-cli and install @angular/cli globally and locally.

@beeman I removed the node_modules and then ran npm install. Still getting the same error.
Also unistalled angular-cli globally and locallyand installed @angular-cli globally and locally.
Still getting the same error.
My package.json is as below :
{   "name": "invoice",   "version": "0.0.0",   "license": "MIT",   "angular-cli": {},   "scripts": {     "serve": "ng serve",     "lint": "tslint \"src/**/*.ts\"",     "test": "ng test"   },   "private": true,   "dependencies": {     "@angular/common": "^2.4.0",     "@angular/compiler": "^2.4.0",     "@angular/core": "^2.4.0",     "@angular/forms": "^2.4.0",     "@angular/http": "^2.4.0",     "@angular/platform-browser": "^2.4.0",     "@angular/platform-browser-dynamic": "^2.4.0",     "@angular/router": "~3.4.0",     "core-js": "^2.4.1",     "rxjs": "^5.0.1",     "ts-helpers": "^1.1.1",     "zone.js": "^0.7.2",     "angular2-jwt": "^0.1.23",     "angular2-materialize": "^5.1.4",     "hammerjs": "^2.0.8",     "materialize-css": "^0.97.7"   },   "devDependencies": {     "@angular/compiler-cli": "^2.3.1",     "@types/jasmine": "2.5.38",     "@types/node": "^6.0.42",     "angular-cli": "^1.0.0-beta.28.3",     "codelyzer": "~2.0.0-beta.1",     "electron-prebuilt": "^1.4.1",     "faker": "^3.1.0",     "jasmine-core": "2.5.2",     "jasmine-spec-reporter": "2.5.0",     "json-server": "^0.8.22",     "karma": "1.2.0",     "karma-chrome-launcher": "^2.0.0",     "karma-cli": "^1.0.1",     "karma-jasmine": "^1.0.2",     "karma-remap-istanbul": "^0.2.1",     "protractor": "^4.0.9",     "ts-node": "^1.2.1",     "tslint": "^4.0.0",     "typescript": "^2.0.2"   } }

You need to remove angular-cli and install @angular/cli.
Please see here for specific steps to ensure a successful upgrade.

Just a quick note to say that I had exactly the same problem attempting to run Jeremy Elbourn's (jelbourn) Material 2 App straight out of the Github box. I successfully solved the issue with a combination of 1) Meligy's Angular CLI upgrade; and 2) rebuilding the app from a fresh 'ng new material2app' project andcpy across relevant content.

Thanks mate for the help. Issue was resolved after I followed the steps mention in the link provided by @Meligy . Was searching the net for a similar article on upgrading  from angular-cli to @angular-cli.


Find a way to integration test GCS

we have minio for s3 but it's been hard to find something for GCS.
Maybe https://github.com/oittaa/gcp-storage-emulator?

I've added unit tests here: https://github.com/discentem/cavorite/pull/105
fake-gcs-server also provides a docker container so we can use that for integration tests


[User Management] Edit User

Is your feature request related to a specific problem?

Demonstrate that a UI user (with the correct Manage User Privs) can edit a users info
1.1 Editable fields are: First and Last name, selected privileges. (username should not be editable)

Clarifying questions:

How is this view accessed? I see both "Edit" button and "Change Password" button on the page.
Is this a different view from the profile landing page, or are we just hiding/showing buttons and/or modals on button clicks?
Does a POST/PATCH endpoint exist for users and what does it look like

Elements:

Editable fields
Buttons to edit/save/cancel
Change password modal (I think you mentioned only this field pops up a modal?)
Selected privileges checkboxes


feat: expose search field's TextEditingController

This PR exposes the search field's TextEditingController for extensibility.
I'm planning to use this for setting or getting the current search query.

Resolved in #53.


Invalid signature if the url parameters has ']' or '[' symbols.

Laravel Version: 8.14.0
PHP Version: 7.4.11
Database Driver & Version: MySQL 8.0.22

Description:
Hi all.
I'm facing that the calling URL::temporarySignedRoute('download', 60, $parameters) generate invalid signature if the parameters has [ or ] symbols.
Steps To Reproduce:
$parameters = ['operator[menu_category_name]' => 'like'];

$url = URL::temporarySignedRoute('download', now()->addMinutes(5), $parameters);

This works for me? I copy and paste the URL returned into my browser.

@taylorotwell please add signed middleware to your something route.

You should generate signed url and after try make a request to this signed url.

Oh whoops lol

Hmm it still works for me to hit it in the browser.

I suspect your issue has something to do with URL encoding.

I'm using postman for getting signed url and after getting response I copy this url and paste to browser and get invalid signature at the moment.

Share your exact response in Postman.

Looks like you're trying to encode JSON in the URL?
If you dig into the signed route code, see what query string values your code can see. Probably all messed up from the equals %5D=

As I understand that temporarySignedRoute can't convert any json data from post request, am I right?

I have no idea. I'm not sure I even understand the question.

Maybe try base64 encoding your parameter array JSON string and then base64 decoding it later.

Hi @taylorotwell the main question of the issue is it ok that the temporarySignedRoute method can't correctly convert any data for getting valid signed url?

I set up this routes to try to replicate the issue

returning the url in an array to have it converted to a json

the url returned is valid and the operator parameter on the request contains the correct data

I created a post route to test it with your payload from a rest client

this returns an invalid signature error when accessing the page
I suspect the error you are having is you are encapsulating your params inside a "params" attribute
I send the payload as this

if $url is dd, the url can be copy and pasted correctly on the browser, if returned as json, it needs to be decoded first, but it's been generated properly

your getDownloadUrl method should look like this, to make it work

temporarySignedRoute is working properly, unless it should accept objects in get parameters, like the object
{ 	"params": { 		"team_id": 454, 		"menu_category-name": "%ce%", 		"operator[menu_categoryname]": "like" 	} }

Closing this for now.

Any guided solution on this, getting invalid signature


Clean up drive strategies

We should clean up the strategies such that the strategies in common are completely done in common (including OnUpdate), instead of relying on the user program to impl a single, cherry-picked method. The implementation should be in common or team code as a whole, not split.

The reason I did it this way is for Joy input; 5663 has no ControlMap file, and it is definately not identical to ours; esp as they have xbox controllers vs our joystick ones. In future I will try to make generalisations of the joysticks to help with this stuff, but that's in the future; lots of other stuff (including, in my mind, the initilaiser list stuff to make JoystickGroup work properly) has higher priority.


Non-offline buildpacks are downloaded again and again

When multiple apps are deployed using the same buildpack (e.g. https://github.com/cloudfoundry/java-buildpack.git#v4.2) then the buildpack is downloaded again and again for each application.
Isn't it possible to cache online-buildpacks? Buildpacks don't change, but apps are deployed often.
This slows down deployments extremely.
Is there a plan to

implement caching for online-buildpacks?
provide v4 java offline buildpacks?

Thanks for your help!

Hi @christianschaible,

Is there a plan to implement caching for online-buildpacks?

You can use cf create-buildpack to upload a buildpack to PCF Dev so that it doesn't need to be downloaded during each stage. (Assuming by "online-buildpacks" you mean buildpack URLs. The online/offline property actually has to do with whether buildpack dependencies, like Java, are downloaded each time. Buildpack URLs can point to buildpacks that are online or offline.)

Is there a plan to provide v4 java offline buildpacks?

The buildpacks in PCF Dev are matched to the buildpacks in PCF.

Isn't it possible to cache online-buildpacks?

Assuming you mean "cache buildpack URLs," no. We shouldn't assume that the buildpack bits available at a particular URL stay the same.


feat: add CLI command for mergeARB

This adds a bin cli command for "mergeARB".
One can specify a base file (the most left in the file list),
and the specify multiple files which are merged into the base file
one by one. The resulting ARB is then outputed to the stdout or
written to a specified output file (if any).

ping @Rodsevich

Sorry @buehler, didn't see this before. Thanks for tle ping!
I'll publish it ASAP on pub.dev


Update stable version in repo from 4.0.5 to 4.0.6

Think about update stable version to 4.0.6
Version: stable=4.0.5 (124 days old) => latest=4.0.6 (15 days old)
Installs: stable=245 (46.49%), latest=41 (7.78%), total=527
Click to edit

done


Removed react-native-router-flux but still getting error

Version

react-native-router-flux v3.39.1
react-native v0.44.0

Expected behaviour
Previously I've installed it using
npm i react-native-router-flux --save
and I got a similar error like #1832 so I removed it manually from package.json, uninstalled all node_modules folder, and reinstalled everything again, but with yarn
I expected to keep everything as the same
Actual behaviour
I got this error:
error: bundling: Error: ENOENT: no such file or directory, open 'D:\<my-folder>\node_modules\react-native-router-flux\node_modules\react-native\Libraries\Components\ActivityIndicator\ActivityIndicator.js'

Did you reset the cache?

If you mean npm cache clear then yes, i've done that.
Also I've deleted all the content where I installed all the npm install --global just in case.

Blow away the yarn.lock file and run yarn again. Or use npm install.

I recall deleting the yarn-lock file, but seems that now it worked!
Dunno.. but... thanks!
We can close now


Added full coverage tests for the telemetry code in AndroidSdkInstaller

Added full coverage tests for the telemetry code in AndroidSdkInstaller
Added mock-fs to mock the file system
Added mock-spawn to mock child_process.spawn
Replaced process with tacoUtils.ProcessUtils.getProcess() in more places, so we can easily mock it
Added some improvements to the fake objects

Tests
All test pass. Tested install-reqs on an empty Windows 10 machine and it worked, I was able to build on Android after that.

:+1:


toggle-sidebar bug sidebar

When the page in the toggle-sidebar class is reduced, the element that is clicked to open the sidebar also appears without a complete shrinkage. I guess these lines should be corrected.
                                                          
"d-md-inline d-lg-none" replace "d-sm-inline d-md-none"

@EmirCanSANCAR In which browser are you having this issue? I could not replicate it in the latest versions of Chrome and Firefox.


update zhouxingye.md

Add in some info about Xingye
Fixes #51

Furthermore, fix trailing white spaces in the developer guide, and add a newline at the EOF of zhouxingye.mc


License

I would like to use this for a project but the repo is missing a license? Could you update the repo to contain the MIT license that is mentioned on https://rubygems.org/gems/pagemaster/versions/1.0.0?

The LISCENSE.md file is now available in the repo on master.


WMS GetFeatureInfo incorrect point position

Sandcastle example
Browser: All
Operating System: All
Reported also: https://github.com/TerriaJS/terriajs/issues/5057

When using WMS in a WebMercatorProjection instead of GeographicProjection user will get the wrong feature position in response. The issue seems to be coming from https://github.com/CesiumGS/cesium/blob/ca8b918f167421ff49966f5951ea0fc4446c1521/Source/Scene/GetFeatureInfoFormat.js#L88-L92
which incorrectly assumes that point coordinate is in GeographicProjection. Also, the issue that might affect more users is the selection indicator that is wrongly positioned. In some rare cases, it might even fly around as user rotate the globe (see photo below).
Any tips on approach solving this, thinking about passing a tilingScheme or MapProjection instance to GetFeatureInfo.

You can use this URL https://gs-stable.geo-solutions.it/geoserver/unesco/wms, instead of the one in a sandcastle. Hopefully, folks from Geosolutions won't be mad for the link, I found it on google.
updated sandcastle

Thanks @zoran995!
I'm afraid the problem is several layers deep:

The WebMapServiceImageryProvider constructor inputs an Array of GetFeatureInfoFormats.
The GetFeatureInfoFormat constructor inputs a callback function to convert the WMS response to ImageryLayerFeatureInfo objects
The default callback function assumes GeographicProjection, as you noticed.

The solution (as you guessed) is to include a MapProjection in the callback. Unfortunately it has to be wrapped in some custom code to handle the conversion from WMS features to ImageryLayerFeatureInfo.
Here is an updated sandcastle illustrating this approach.
Let me know if this solves your problem for this specific example. We are still thinking about how to make it easier to handle different projections.


Add Jina LLM support

Description
This PR adds Jina LLM support into Embedchain
Fixes #688
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (does not change functionality, e.g. code style improvements, linting)
[ ] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.

[x] Unit Test
[x] Test Script (please provide)

from embedchain import App
from embedchain.llm.jina import JinaLlm
from embedchain.config import BaseLlmConfig
import os

os.environ["OPENAI_API_KEY"] ="sk-xxx"
os.environ["JINACHAT_API_KEY"] = "xxx"

app = App(
    llm=JinaLlm(),
)

app.add("https://en.wikipedia.org/wiki/Pok%C3%A9mon")

config = BaseLlmConfig(top_p=1,max_tokens=10, stream=True, system_prompt="Pokemon is a")

response = app.query("What is a pokemon?", config=config)

print("Answer: ", response)

Ouput:
A Pokémon is a fictional creature found in the PokémonAnswer:  A Pokémon is a fictional creature found in the Pokémon

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

This is great. Can you please also update the docs in the docs/ directory?


Pypdfium2 clashes with multiprocessing support

A regression was introduced in commit https://github.com/facebookresearch/nougat/commit/9e2572bf5d100a5a7521576908eb5713e0dd24c8: previously with PyMuPDF or pdf2image rasterizer implementations, it was possible to run nougat in a multiprocessing pool, so that multiple PDFs could be parsed at the same time.
With pypdfium2 this is no longer possible. Running with multiprocessing results in errors like this:
ERROR:root:daemonic processes are not allowed to have children
ERROR:root:list index out of range
WARNING:root:Image not found
ERROR:root:list index out of range
WARNING:root:Image not found
ERROR:root:list index out of range
WARNING:root:Image not found

It happens because the pypdfium2's Document.render method has these lines:
with mp.Pool(n_processes, **pool_kwargs) as pool:
    yield from pool.imap(_parallel_renderer_job, page_indices)

and in Python it is not possible to nest multiprocessing pools (at least not with the built-in implementation). Although it is possible to set n_processes to 1 in Document.render, there is no option not to create sub-processes altogether.
For comparison, the torch.DataLoader class solves this by allowing num_workers to be set to 0 and handling it as a special case:
def _get_iterator(self) -> '_BaseDataLoaderIter':
        if self.num_workers == 0:
            return _SingleProcessDataLoaderIter(self)
        else:
            self.check_worker_number_rationality()
            return _MultiProcessingDataLoaderIter(self)

but I guess it might be more difficult to solve this from the pypdfium2 side than to switch back to the earlier pdf2image implementation, unless there is a good reason to use pypdfium2?

I switched to pypdfium2 because of the poppler dependency of pdf2image.
I'll have a look


link to client display from the level component in the dashboard is broken

currently links to https://ip-10-113-80-245.evoforge.org/skills and needs to be updated to https://ip-10-113-80-245.evoforge.org/administrator/skills

PR: #359

:+1:


will you add X_101_64x4d and Cascade R-CNN in this project?

❓ Questions and Help
will you add X_101_64x4d、ResneXt_152 and Cascade R-CNN model in this project? Even more  test augument like softnms?

This is not in the current plans, but contributions adding those features are more than welcome!

@fmassa Can you give some advice how to implement this elegantly?


NAG Optimizer with multi-precision support

Description
NAG Optimizer with multi-precision support. Tests already exist for this.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

C++ implementation of nag opt with multi-precision support.

@eric-haibin-lin @ptrendx

Still need to add proper doc strings for the update functions.

@mxnet-label-bot add [Optimizer, pr-awaiting-review]

Cool :-) - I actually wanted to do this after finishing AMP. Since you used the same lgeneral layoutlike I did for SGD - do you think it would be beneficial to generalize it a little bit (so that adding more optimizer like this is easier in the future)?

@ptrendx MP_NAG_InferType can be generalized right away. I will see what else can be generalized. do you have any specific suggestions?

@anirudhacharya very cool! Would be great if you can comment a bit about how/when is NAG delivering better results compared to other optimizers.

@anirudhacharya @lupesko it's a great feature which is also very useful for CPU BF16 :)
Feel free to ping me if anything needs our team to cover.
@ZhennanQin @TaoLv

@anirudhacharya Can you look into the CI failures on this one. ?

@lupesko
Nesterov Accelerated Gradient or NAG is an improvement over SGD with Momentum optimizer.
As we know SGD with Momentum helps to accelerate the optimizers descent to the desired minima by reducing the oscillations in the parameter updates by adding a fraction of the update of the past time step to the update of the current time step. This enables faster convergence of the model.
But this can also cause the optimizer to overshoot the global minima due to larger parameter updates. NAG optimizer fixes this by changing the update rules to decelerate the optimizer as it nears the global minima. This has shown better performance while training RNNs as described here - https://arxiv.org/abs/1212.0901. The following diagram will illustrate the difference -

(image source is a stack exchange thread)
This PR also adds multi-precision support to the NAG optimizer, which is very useful while training in fp16 because multi-precision optimizers keep a copy of the weights in fp32 but performs backward pass and parameter updates in fp16. This technique prevents any loss in accuracy of the model while giving us significant benefits in improved memory and time taken for training. For more details on mixed precision training, please see here - https://devblogs.nvidia.com/mixed-precision-training-deep-neural-networks/

@mxnet-label-bot remove [pr-awaiting-review] add [pr-awaiting-merge]

@nswamy @sandeep-krishnamurthy @anirudh2290 - Please review and merge


Nagios [Epic Task 1]: Install & Configure Nagios Server Core Application From Ansible

As part of issue #2445 , some code is required to create and configure a new Nagios Core monitoring server, the following sub tasks are involved :-

[x] Create ansible playbook to install Nagios Server Core on Ubuntu 22.04 via Ansible
[x] Install bespoke tooling for Nagios server

[x] nagios_slack.pl - Perl Script To Send Notification To Slack
[x] nagios_graph - Nagios Plugin
[x] pnp4nagios - Nagios Graphing Tool

[x] Manage User Configuration / Backup / Restore / Automate ? ( cgi.cfg / htpasswd.users )

[x] Default Nagios Admin User Created

[x] Update server related global config files ( resource.cfg )
[x] Update server related global config files ( nagios.cfg )
[x] Create commands.cfg file from source.

[x] Add Nagios/Slack Notification Command

[x]  Create Monitoring Configuration For Nagios Server
[x] Test Playbook On VM

Follow On Tasks:

Determine How To Manage Users On New Nagios
Nagios backup/restore
Configure Security ( Certificates / SSL etc )

@sxa could you assign this to me please ?

NOTE: This is awaiting the approve and merge of https://githuhttps://github.com/adoptium/infrastructure/pull/2638

Above PR is merged so I'm closing this


Importing STL files shows all sorts of artifacts

Importing the HeartGears2-3.stl file from here:
https://www.thingiverse.com/thing:243278/files
using this code, has lots of artifacts, and holes in the outputed stl file.
package main

import (
    "github.com/hschendel/stl"
    "github.com/soypat/sdf/helpers/sdfexp"
    "github.com/soypat/sdf/render"
)

func main() {

    solid, err := stl.ReadFile("HeartGears2-3.stl")
    if err != nil {
        panic(err)
    }

    tris := make([]render.Triangle3, len(solid.Triangles))

    for i, t := range solid.Triangles {
        for k := 0; k < 3; k++ {
            tris[i][k].X = float64(t.Vertices[k][0])
            tris[i][k].Y = float64(t.Vertices[k][1])
            tris[i][k].Z = float64(t.Vertices[k][2])
        }
    }

    object, err := sdfexp.ImportModel(tris, 0)
    if err != nil {
        panic(err)
    }

    err = render.CreateSTL("out.stl", render.NewOctreeRenderer(object, 500))
    if err != nil {
        panic(err)
    }

}

I am aware of artifacting bug(s) somewhere in the sdfexp.Import -> CreateSTL pipeline.
That said there may be an issue in how you import the triangles. sdf's triangles are oriented and have their normal implicitly defined by their vertex ordering, unlike STL triangles.
Modify the for loop block to do the following
norm := r3.Vec{X:t.Normal[0],Y:t.Normal[1], Z:t.Normal[2]}
 for k := 0; k < 3; k++ {
            tris[i][k].X = float64(t.Vertices[k][0])
            tris[i][k].Y = float64(t.Vertices[k][1])
            tris[i][k].Z = float64(t.Vertices[k][2])
}
if r3.Dot(tris[i].Normal(), norm) < 0 {
    tris[i][0], tris[i][1] = tris[i][1], tris[i][0] // Swap two vertices to invert normal direction to match render.Triangle type
}

Let me know if this helps. Keep in mind it might not fix all of the artifacts, or any at all if stl triangles were already oriented well.

Thanks! Yeah it didn't help much. I'm sick ATM so it won't be for a while before I can look at this again. Thanks for taking a look.

Alright, good to know others are experiencing this bug. I've been wanting to fix it for some time now but I'm quite swamped with university work. If all goes well I'll be graduating this year and so be free to put in some more time to sdf.

Hey there! I'm not sure what the plan is with this but I ended up writing my own SDF for meshes a while ago that seems fairly stable. I think the issue is that the k-tree that's being used doesn't always give the proper closest triangle. I ended up writing my own boundary interval hierarchy implementation of it, which worked well for a few meshes I tried, although sharp edges tended to disappear (not sure if it's because of some bug in my SDF or because of how the mesh generation process works in general). I accidentally ended up switching approaches in my project so it won't be developed further, but I could try to work it into this repo if you're interested, here's a link to it: https://gist.github.com/cactorium/91ac2d917a6d9378a43d70ef881aea44

Thank you so much for your suggestion! That looks awesome and I'd love to see how it stacks up against the current buggy implementation! If you have time to incorporate it into the exp package- that'd be awesome!

I'll try to work on it this weekend!

Moving development to https://github.com/soypat/gsdf. Closing all issues here.


Has AidStream had it's hostname changed?

Hi,
Some AidStream files on the IATI Registry are throwing errors. e.g.

The message is about hostname www.aidstream.org' not matching either of aidstream.org or np.aidstream.org. Do you have any knowledge of what might be happening?
Some organisations where this is happening:
https://www.iatiregistry.org/publisher/basicneeds
https://www.iatiregistry.org/publisher/ipa
https://www.iatiregistry.org/publisher/tbalert

Hi Amy,
On checking the individual organization's page, the URL of the individual Activity and Organization file is perfectly okay when I access those xml files from the URL on the browser.
However, these issues were arising when IATI was trying to access the aidstream server with the domain www.aidstream.org instead of aidstream.org. We were not aware of this issue and we are working to fix this issue. Thank you for pointing it out.
Regards,
Mani

Thanks Mani! We came to the same conclusion.
We'll try and get a bulk fix done on the relevant AidStream files currently published to the IATI Registry. It would also be great to prevent the error from occurring again.
Best wishes,
Amy

Hi Amy,
We have fixed the issue from our end too and the hostname issue is only showing for one activity file for Basicneeds. Hopefully, it will also be updated once IATI refreshes the link.
Regards,
Mani

Thanks Mani!


Feature: Prefix table names with schema names

I have an SQL Server database with multiple schemas. Some of the table names in these schemas overlap, which causes mermerd to generate two entities with identical names. When rendered, mermaid will combine these entities into a single entity.
Ideally, these table names would be prefixed with the schema name in the generated Mermaid graph, optionally with a configurable separator like an underscore.

That makes total sense - I will be releasing that feature shortly

This feature is available in Version 0.6.0
The schema prefix is disabled by default, but can be enabled by the config showSchemaPrefix. For the separator . is used by default, but can be overwritten by schemaPrefixSeparator.
All the configs can either be set via the command line, run config or the global mermerd config (see readme for details)
Your described example can e.g. be achieved by mermerd --showSchemaPrefix --schemaPrefixSeparator="_"
If anything does not work as expected, please let me know

Thanks, the entities are now generated correctly with schema prefixes. But showSchemaPrefix doesn't seem to apply to entity relationships.

The Version 0.6.1 fixes that issue.

0.6.1 works fine, thanks.


Get bounding rectangle of whole head

Is it possible to get the bounding rectangle of the entire head, not just the face?

Not, with the face detectors, no.


APPSRE-3556 deprecate saas-file-1

saas-file-1 deprecation has been reverted due to missing logic change in qr.
After qr logic cleanup is merged we can revert the revert :)

saas-file-1 logic is now removed from qr https://github.com/app-sre/qontract-reconcile/pull/2351


kia_uvo Exception in kia_uvo login : 'redirectUrl' - traceback: Traceback (most recent call last):

I get this error while trying to login.
It's a UVO to Kia migrated account (migrated a while back).
I checked the credentials and they are correct.

Can you try this;

create a new account from scratch
share your car with that account
try to login with the new account

I have the same problem. Created a brand new account, got it verified through phone number, but when installing the integration i keep getting:
'''
Logger: custom_components.kia_uvo.config_flow
Source: custom_components/kia_uvo/config_flow.py:169
Integration: Kia Uvo / Hyundai Bluelink (documentation)
First occurred: 14:33:42 (2 occurrences)
Last logged: 14:34:22
kia_uvo Exception in kia_uvo login : 'redirectUrl' - traceback: Traceback (most recent call last): File "/config/custom_components/kia_uvo/config_flow.py", line 154, in async_step_user self.token = await self.hass.async_add_executor_job( File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run result = self.fn(*self.args, **self.kwargs) File "/config/custom_components/kia_uvo/KiaUvoApiEU.py", line 151, in login parsed_url = urlparse(response.json()["redirectUrl"]) KeyError: 'redirectUrl'
'''

Same problem here with Hyundai Bluelink. Account created last week.

I need to setup local debugging environment and login into one problematic account (i have one) but it is clear that there is a problem between old and new accounts

Hope you can fix it soon

Same issue here:
kia_uvo Exception in kia_uvo login : 'redirectUrl' - traceback: Traceback (most recent call last): File "/config/custom_components/kia_uvo/config_flow.py", line 154, in async_step_user self.token = await self.hass.async_add_executor_job( File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run result = self.fn(*self.args, **self.kwargs) File "/config/custom_components/kia_uvo/KiaUvoApiEU.py", line 151, in login parsed_url = urlparse(response.json()["redirectUrl"]) KeyError: 'redirectUrl'
I have my car (and account) only for 2 weeks so it's a "new" account. Tried logigng out and in on the Kia Connect and UVO app, to no avail. Let me know if I can do something to help testing.

Can we help here in any way?
What debug/traces do you need?

I think I might be having the same issue:
kia_uvo Exception in kia_uvo login : 'redirectUrl' - traceback: Traceback (most recent call last): File "/config/custom_components/kia_uvo/config_flow.py", line 154, in async_step_user self.token = await self.hass.async_add_executor_job( File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run result = self.fn(*self.args, **self.kwargs) File "/config/custom_components/kia_uvo/KiaUvoApiEU.py", line 151, in login parsed_url = urlparse(response.json()["redirectUrl"]) KeyError: 'redirectUrl'
the account it new. made yesterday on bluelink, so it shouldn't be on an old server.
The account works in the app and on the hyundai web pages.

Looks like this is how bluelinky fixed the issue.
https://github.com/Hacksore/bluelinky/pull/168
If I get a chance in the next few days I'll see if I can do something similar.  Also looks like a manual workaround may exist by putting the redirect into a browser and accepting it.

This cannot be in issue for us because our issue is happening even after acknowledging this consent

Gotcha - that is unfortunate.

I will try to replicate new login strategy here: https://github.com/Hacksore/bluelinky/blob/7336aca9296d988e808083da68c711806a2b80a9/src/controllers/authStrategies/european.brandAuth.strategy.ts

I am able to login with new flow (it is dumb hell), I will work with @Flight777 to test changes locally before publishing them

EU Kia and Hyundai users, please give latest version a try and report back

Great work! I could login now and integrate with hass!

Could not login to my kia account:
version cc2046d
log:
kia_uvo Exception in kia_uvo login : can only concatenate str (not "NoneType") to str - traceback: Traceback (most recent call last): File "/config/custom_components/kia_uvo/config_flow.py", line 154, in async_step_user self.token = await self.hass.async_add_executor_job( File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run result = self.fn(*self.args, **self.kwargs) File "/config/custom_components/kia_uvo/KiaUvoApiEU.py", line 108, in login ) = self.get_access_token() File "/config/custom_components/kia_uvo/KiaUvoApiEU.py", line 312, in get_access_token "grant_type=authorization_code&redirect_uri=https%3A%2F%2F" TypeError: can only concatenate str (not "NoneType") to str
does anyone know what I can do to resolve it?

I was able to test with a Hyundai account, i might need a kia account to debug this. If we can do this together, you can share your car with me in agreed times and i can debug.
Otherwise, i don't have a solution to debug, sorry.

L.S.
I have no problem sharing my car to make it possible to debug.
Send me the neccesary accountdata and ik wil make the account and share.
Met vriendelijke groet,
Herman v.d. Zijden
@.***

Op 14 nov. 2021 om 22:59 heeft Fuat Akgün @.***> het volgende geschreven:
I was able to test with a Hyundai account, i might need a kia account to debug this. If we can do this together, you can share your car with me in agreed times and i can debug.
Otherwise, i don't have a solution to debug, sorry.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

EU Kia and Hyundai users, please give latest version a try and report back

New version worked like a charm - I can login now and am getting _all the data.

New version worked like a charm - I can login now and am getting _all the data.
Hyundai or Kia?

@RubenKremer is it Kia or Hyundai?

Sorry - forget to mention - Hyundai Europe

@HMvdZijden , please write an email to me<EMAIL_ADDRESS>Apparently, all is working for Hyundai Europe but failing for Kia Europe.

@HMvdZijden , please write an email to me<EMAIL_ADDRESS>Apparently, all is working for Hyundai Europe but failing for Kia Europe.

Sounds about right.
"kia_uvo Exception in kia_uvo login : can only concatenate str (not "NoneType") to str - traceback: Traceback (most recent call last): File "/config/custom_components/kia_uvo/config_flow.py", line 154, in async_step_user self.token = await self.hass.async_add_executor_job( File "/usr/local/lib/python3.9/concurrent/futures"

The subject is getting quit long.
Op ma 15 nov. 2021 15:34 schreef Cevendir @.***>:

@HMvdZijden https://github.com/HMvdZijden , please write an email to me
@.***
Apparently, all is working for Hyundai Europe but failing for Kia Europe.
Sounds about right.
"kia_uvo Exception in kia_uvo login : can only concatenate str (not
"NoneType") to str - traceback: Traceback (most recent call last): File
"/config/custom_components/kia_uvo/config_flow.py", line 154, in
async_step_user self.token = await self.hass.async_add_executor_job( File
"/usr/local/lib/python3.9/concurrent/futures"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fuatakgun/kia_uvo/issues/79#issuecomment-968970237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4G6XBTQBY4RJNA4EIAHWTUMEK6XANCNFSM5FQSU7OA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I am fine if this is getting long, we have nailed down Hyundai EU problem, I need someone to email me so we can discuss about car sharing for Kia EU.
my email<EMAIL_ADDRESS>

EU Kia users, please give this a try

Had received multiple success stories over email, resolving now, comment if you face any issue

Another success report here, thanks a lot for the effort :tada:

Fixed for me as well! (EU/Kia). Thank you very much!

Not working for me. Kia Sweden. Same error as previous. Do I need to add car before login?

@riksarchen This is not the same error that has been reported in this issue. And yes, the stack trace looks like you need to add a car with the app first.


License shown wrong in RTF

Currently license is shown in RTF file using HTML anchor, e.g.
Licences of use: This work is licensed under a Creative Commons Attribution (CC-BY) 4.0 License.
Only the title of the license should be shown linking out to the text of the license.

Issue verified.


[BUG] Missing 'label' info during gremlin query with GAIA engine under vineyard store

vineyard_version: v0.4.1
graphscope version: main branch (0aa8c3c6f0f18cb5c2a4aabc2814561a2357699c)

This can be resolved in #1615


$forceUpdate enhancement

What problem does this feature solve?
Here is an example of executing the $forceUpdate in a component, the children of this component won't be re-rendered.
https://codesandbox.io/p/sandbox/kind-hermann-ykxrhn
The$forceUpdate seems only updates the current node, sometimes you may want to re-render all the children nodes without any tricky.
<!-- this is tricky-->
<Child :key="Math.random()" />

What does the proposed API look like?
should the $forceUpdate work as React that re-renders the current node and all its children nodes?
or can we add an updateStrategy option to the $forceUpdate method for flexibility? such as supporting the following scenarios

only update the current node (current behavior)
update the current node and all its children nodes, including those nodes whose key and props remain unchanged
except for the nodes whose key and props has not been changed, update the current node and all its children nodes

@Shyam-Chen
if you want to build a combination of lib + components, the lib should be agnostic of frameworks.
the components are built on top of the lib, and they can be either Vue or React components, even components from other frameworks.
some states are handled in lib, they are not reactive, and the states are updated manually.
in this case, the $forceUpdate is useful for triggering the rendering when a state is manually updated.

@Shyam-Chen
please note the data or state is not reactive.
the flow is doing an action via a lib method, then passing the state to a component and re-render.

@SunnyCrypto Which Vanilla Lib are you using? I use Highcharts. Its data cannot be reflected directly, but I can still re-render it through Watch.


Contextily install in google colab

When I try to install contextily on google colab (! Pip install contextily), an error appears in the cartopy installation. This I solved this way: https://github.com/googlecolab/colabtools/issues/85#issuecomment-372532728.
The installed version is 0.99. The problem is that it does not have the "contextily.add_basemap" function.
After searching, I saw pypi.org for the latest version and installed it without problems:
pip install contextily==1.0rc2
Now everything is working!
Here is the hint if someone has the same difficulties.

Thanks! I had the same problem installing contextily on linux. With the 1.0rc2 it works

I faced this morning (2020_0321) and solved as @hugonbgg suggested.

When I try to install contextily on google colab (! Pip install contextily), an error appears in the cartopy installation. This I solved this way: googlecolab/colabtools#85 (comment).
The installed version is 0.99. The problem is that it does not have the "contextily.add_basemap" function.
After searching, I saw pypi.org for the latest version and installed it without problems:
pip install contextily==1.0rc2
Now everything is working!
Here is the hint if someone has the same difficulties.


Fix clippy for Rust 1.67, allow uninlined_format_args

Pull Request
milli part of https://github.com/meilisearch/meilisearch/pull/3437

spurious failure, let's try again
bors merge

this time it passes!
bors merge


Allow MolDraw2DCairo and MolDraw2DSVG to determine canvas size based on the molecule

If the width and height of the canvas are set to -1, then the canvas size will be automatically calculated from the molecule size and MolDraw2DOptions::scalingFactor.
The majority of the substantive code changes are in MolDraw2D::calculateScale()
Caveats:

This only works with drawMolecule(); drawMolecules() will throw an error if called with width and/or height set to -1.
This cannot currently work with MolDraw2DJS or MolDraw2DQt because those both take pre-configured objects (which already have a size) to draw upon.

Other changes:

Adds MolDraw2DOptions::baseFontSize to help with #4652
updates a bunch of expected hash values for SVGs and PNGs.

I'm not set up to try this quickly. What happens if you pass width and height -1 to MolDraw2DJS or MolDraw2DQt? I think I read a comment from you that they can't work with this approach, but what's the effect of trying?

Good catch.  There was no check at all, but I just added the same PRECONDITIONs which would have been previously triggered when calculateScale() was called.


fixing missing company phone in document

1. Why is this change necessary?
The document configuration value companyPhone can be set by the Admin UI, but is not accessible by code.
2. What does this change do, exactly?
Adding variable $companyPhone to class DocumentConfiguration so you can access it.
3. Describe each step to reproduce the issue or behaviour.
$documentConfiguration->companyPhone
throws an error
4. Please link to the relevant issues (if any).
https://github.com/shopware/platform/issues/2672 (thanks to @applifaction)
5. Checklist

[x ] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x ] I have read the contribution requirements and fulfil them.

First pull request ever. Hope everything is alright 🙌

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey,
I will close this pull request as it is inactive for a while. Feel free to create a new one.


[Request] Uptime功能添加 badge 功能

与 Uptime Kuma 的 badge 类似的功能

uptime kuma not has badge feature, did you mean tag?

ok, interesting.


Update Get-RemoteMailbox.md

Added Note to ResultSize per IM request.

Learn Build status updates of commit 8a6ff2f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add group_by_success to API

While the API sorts bulk actions, it has come up a couple of times that the result passed back from the bulk actions is difficult to work with (ie, not being able to simply grab all of the failures).
This proposed solution accepts
"group_by_success": "true"

in the body of the request. If this is passed in, the returned result will then be in the following format:
{
  "results": {
   "successes": [{"success": true, "id": 1 }, {"success": true, "id": 3}],
   "failures": [{"success": false, "id": 3}]
  }
}

open for discussion about the best way to handle this and format the new response.
cc: @AllenBW @imtayadeway @abellotti
@miq-bot add_label enhancement, api

I LOVE THIS IDEA!!!
Feeling a lil like whoever saw that financial crisis thing that happened to the USA a few years ago, we are looking down the :gun: of a notification crisis!
This represents a critical step towards making batch actions, well actionable.  Wanta delete 3000 services? half of them fail, half of em succeed, wanta act on only the 1500 that failed? Well that just got easier!  Empowering the user to act on the results of an action rather than redoing the action would be huge.

I'm not too keen on this. while I understand the use, not sure this is the API's role here.  It's job is to return one result action per resource, so clients can correlate input resource per output result. What if there's somehow no identifiers.  Group by success, id, or whatever else needed. feels like a client thing to do.

@jntullo @abellotti bump


Autoplay mod compatibility

When running in Autoplay using the autoplay mod, there are references to the LocalPlayer which will sometimes return -1 and thus nil in certain functions. I have found two places in this mods UnitFlagManager.lua and can be fixed like this:
In UnitFlag.SetColor (around lines 508) wrap the "War Check" with
if Game.GetLocalPlayer() > -1 then
    -- War Check
    [...]
end

and in OnPlayerTurnActivated (line 1464) after
local idLocalPlayer = Game.GetLocalPlayer();
insert
if idLocalPlayer < 0 then
    return
end

Edit:
also line 163 and 187 should be changed to
if(CQUI_ShowPaths) and (Game.GetLocalPlayer() > -1) then

Alright, thanks for sharing! If you'd like to be properly credited for this fix, then please use the "Fork" button near the top and use the web editor to commit the changes. Finally, use the "Pull Request" button to submit your proposed changes. If that seems like altogether too much work, that's fine too, but you won't show up in the Github contributor list and it will be harder to claim credit for helping with this project as a result

Credit is not a big deal, but I created a pull request anyway


Add indicator example in getting started guide

@delaneyj is there anything we can do to remove the requirement for elements using data-indicator to have an ID, without having to wait for an Idiomorph fix or port? Could the plugin add an ID to the element if one doesn't already exist? It's not ideal but feels like the right kind of magic to help prevent people getting tripped up by this anomaly.

Let me gaze into my orb for a bit


Tab autocomplete truncated !

Hi
Great job for your plugin. He save time for admin job on my server to edit Commands block, when it require a color text modification.
But now when i use command block and the string test is big, i use the text like this :
"/nbt Block command = [TAB]"
It made only 1 lign and trunc it with that "            ..."        (3 points).
Impossible to set the text !
Can you correct them ?

ohh forget to mention :

server on spigot 1.8.3 but i think it come on minecraft client version, not server.

You can see text by command:
/nbt Block command full
If you need to restore text with [TAB] more than 60 characters, edit config.yml (or create):
limit:
    vertical: 10
    horizontal: 60

Thx a lot.

Use § instead of a & when editing the file

Sorry, but it don't work
Ok let me explain what i want :
I put a command block and write this :
"
/summon ArmorStand ~ ~ ~ {NoGravity:true,Invisible:true,CustomNameVisible:true,CustomName:"Bienvenue sur le serveur Nitrado",Invulnerable:true}
"
After that i try to put the color so i write on minecraft :
/nbt block Command < $test
A new test.nbt file is create and inside :
"
[]   /summon ArmorStand ~ ~ ~ {NoGravity:true,Invisible:true,CustomNameVisible:true,CustomName:"Bienvenue sur le serveur Nitrado",Invulnerable:true}
"
I try to modify the text, save and type in minecraft :
/nbt block Command > $test
And it is there where it said : PowerNBT : Wrong format !
What i do wrong ?

Don't use a text editor for this.
Here's the nbt editors:
webNBT: https://irath96.github.io/webNBT/
other: http://minecraft.gamepedia.com/NBT_format#Software

Ok, i try this and this is my result :
If i save on NBT format => webNBT can edit (but with no name for the data, strange), i save, i upload and when i reaffect the value inside data : error java ...
If i save on NBT format => NBTExplorer => can not open file ?????
If i save on NBTZ format => webNBT is the same result above (the first line)
If i save on NBTZ format => NBTExplorer => It can open file (with correct name DATA = ...). I save, reupload. And work ok when i reaffect the value.
So I'll use NBTZ format file via FTP to open it with NBTExplorer.
Thx a lot for you patience and help. your plugin is very usefull for admin like us.
Bye


replace netsh commands with Powershell equivalents

Update MTU and firewall operations with their Powershell equivalents to avoid netsh (netsh operations are crashing on Win11 23H2)

I've completed the migration of netsh commands to powershell while still supporting them for older operating systems to ensure backwards compatbility for OSes that I can't easily test (2003/2008/7/8)


Add patch to 1.26 for CVE-2023-45288

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm

/hold


cleanup unused methods and endpoints

First part of changes from #1105: cleanup of CloneRepositoryController.kt and support changes in save-cli

Save CLI part is refactored without testing, it will be covered in scope #1061


Add Mint L2

This PR Is requesting to update the information of Mint Blockchain on L2Beat.
Mint Blockchain is a Layer 2 network for NFTS.
Homepage: https://www.mintchain.io/
Twitter: https://twitter.com/Mint_Blockchain
Testnet will be launched soon.

https://twitter.com/Enamul1590

Hi @lucadonnoh , can you reveiw this request?
Mint is the L2 Blockchain for NFTs. Mint blockchain is developed based on OP Stack. Mint Testnet will be launched in Q1 2024.
Website: https://www.mintchain.io/
Twitter: https://twitter.com/Mint_Blockchain
Thanks for your time!

Hi, please format the mint.ts file. You can do that by running yarn format:fix in the config subpackage

Hi, please format the mint.ts file. You can do that by running yarn format:fix in the config subpackage

ok, the mint.ts file is format already.

do you have a live testnet already?

do you have a live testnet already?

we now have an internal testnet, the public testnet is not yet online

@lucadonnoh hi, is there any other information that needs to be modified or submitted?


pipelines files

Closing in favour of rebased version https://github.com/Activiti/activiti-cloud-query/pull/60


Dependabot creates misleading links to PR's due to embedded changelog

Package manager/ecosystem
ALL

Manifest contents prior to update
Not Applicable

Updated dependency
Any

What you expected to see, versus what you actually saw
Dependabot PR's embed the changelog of the updated dependency in its PR body.

These changelogs often include text in the form of:
go: duplicate conversion functions when parent structs have the same base name (#2697) (52bd510), closes https://github.com/aws/jsii/issues/2632

This creates a closing relationship between the dependabot PR and the issue mentioned in the changelog.
This creates clutter and confusion, as the dependabot PR most certainly does not resolve the issue it mentions.
In addition, if the PR is approved/merged by a user that has permissions to both repositories, merging the dependabot PR will actually close the mentioned issue, which is not intended.

Images of the diff or a link to the PR, issue or logs

For example, the following dependabot PR in the aws-delivlib-sample repository, closed an issue in the jsii repository.

You can also see the amount of links created to this issue due to dependabot PR's in unrelated repositories.
I would expect dependabot PR's to not create any implicit links to other issues, and this indeed doesn't seem intentional, but rather a consequence of GitHub functionality.

👋 @iliapolo this looks like a regression, we try to not backlink github links in dependabot PRs. Will take a look.

@iliapolo we already fixed this here, just confirmed new PRs to update jsii-pacmak don't create backlinks anymore: https://github.com/awslabs/cdk-watchful/pull/399


Dates these release

Can we please add the dates for when each of these versions release?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca25ead-3b5d-4434-1865-0d4fef57ebdf
Version Independent ID: 8d146609-15b5-b8a0-62bf-108f29248991
Content: What's new in Microsoft Defender Advanced Threat Protection for Linux - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/linux-whatsnew.md
Product: w10
GitHub Login: @Dansimp
Microsoft Alias: dansimp

There sort of is some form of history, as mentioned 8 months ago in issue ticket #6640 (Please add version history), which is this page:

https://github.com/MicrosoftDocs/windows-itpro-docs/commits/public/windows/security/threat-protection/microsoft-defender-atp/linux-whatsnew.md

But then again, I don't know if the Defender for Endpoint updates truly and factually coincide with the page updates.
Waiting for feedback from one of the MS Docs team members.

There sort of is some form of history, as mentioned 8 months ago in issue ticket #6640 (Please add version history), which is this page:

https://github.com/MicrosoftDocs/windows-itpro-docs/commits/public/windows/security/threat-protection/microsoft-defender-atp/linux-whatsnew.md

But then again, I don't know if the Defender for Endpoint updates truly and factually coincide with the page updates.
Waiting for feedback from one of the MS Docs team members.

Duplicate of #6640. See comment, https://github.com/MicrosoftDocs/windows-itpro-docs/issues/6640#issuecomment-624175839

Duplicate of #6640. See comment, https://github.com/MicrosoftDocs/windows-itpro-docs/issues/6640#issuecomment-624175839


Remove extra registry pod when it is created

Signed-off-by: akihikokuroda<EMAIL_ADDRESS>
Description of the change:
This PR adds a mutex block around the creation of the configmap retistry pod.  I reproduced this error locally a couple of times.  I saw 2 registry pods created with the same configMapResourceVersion.  The 2 queue process workers created the pod at the same time.  This mutex block prevent 2 workers checking and creating the registry pod at the same time.
Motivation for the change:
Closes #2613
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

/hold

/unhold

/hold
The mutex block doesn't seem enough because of the cached pod instances.

/unhold
Change the currentPod function not to use cache to get the list of pods.

It must be the cache misses.  Here is the catalog operator pod log when the CI test failed.  The  catsrc id=wEdnr and catsrc id=iFe3m ran back to back and the catsrc id=iFe3m saw the check registry server healthy: false after the ensured registry server by catsrc id=wEdnr
time="2022-01-28T18:39:08Z" level=debug msg="syncing catsrc" id=wEdnr source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="checking catsrc configmap state" id=wEdnr source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="check registry server healthy: false" id=wEdnr source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="ensuring registry server" id=wEdnr source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=info msg="syncing catalog source for annotation templates" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=ev0O2
time="2022-01-28T18:39:08Z" level=debug msg="this catalog source is not participating in template replacement" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=ev0O2
time="2022-01-28T18:39:08Z" level=debug msg="RemoveStatusConditions - request to remove status conditions did not result in any changes, so updates were not made" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=ev0O2
time="2022-01-28T18:39:08Z" level=debug msg="Got source event: grpc.SourceState{Key:registry.CatalogKey{Name:\"mock-ocs-main-w9dzd\", Namespace:\"operators\"}, State:1}"
time="2022-01-28T18:39:08Z" level=info msg="state.Key.Namespace=operators state.Key.Name=mock-ocs-main-w9dzd state.State=CONNECTING"
time="2022-01-28T18:39:08Z" level=debug msg="Got source event: grpc.SourceState{Key:registry.CatalogKey{Name:\"mock-ocs-main-w9dzd\", Namespace:\"operators\"}, State:3}"
time="2022-01-28T18:39:08Z" level=info msg="state.Key.Namespace=operators state.Key.Name=mock-ocs-main-w9dzd state.State=TRANSIENT_FAILURE"
time="2022-01-28T18:39:08Z" level=debug msg="ensured registry server" id=wEdnr source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="syncing catsrc" id=iFe3m source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="checking catsrc configmap state" id=iFe3m source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="check registry server healthy: false" id=iFe3m source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=debug msg="ensuring registry server" id=iFe3m source=mock-ocs-main-w9dzd
time="2022-01-28T18:39:08Z" level=info msg="syncing catalog source for annotation templates" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=sY5K/
time="2022-01-28T18:39:08Z" level=debug msg="this catalog source is not participating in template replacement" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=sY5K/
time="2022-01-28T18:39:08Z" level=debug msg="RemoveStatusConditions - request to remove status conditions did not result in any changes, so updates were not made" catSrcName=mock-ocs-main-w9dzd catSrcNamespace=operators id=sY5K/
time="2022-01-28T18:39:08Z" level=debug msg="ensured registry server" id=iFe3m source=mock-ocs-main-w9dzd

I made change to not to use the Lister to check the registry pod in the currentPods and currentPodsWithCorrectResourceVersion.  This should make the second sync to see the registry pod created.
I couldn't make the tests that causes this failure with the original code.  It seems a small timing gap case.

closing PR as stale. Please re-open if it's still important.


install_vagrant_key: expected string, got bool

install_vagrant_key is defined as bool.
    "install_vagrant_key": true,

Packer (v0.8.0) is not happy about that.
$ make vmware/centos71
rm -rf output-vmware-iso
mkdir -p box/vmware
packer build -only=vmware-iso -var 'cm=nocm' -var 'headless=' -var 'update=' -var 'version=1.0.18' -var 'ssh_username=vagrant' -var 'ssh_password=vagrant' -var 'install_vagrant_key=true' -var 'iso_path=iso' centos71.json
Failed to parse template: 1 error(s) occurred:

* variable install_vagrant_key: '' expected type 'string', got unconvertible type 'bool'
make: *** [box/vmware/centos71-nocm-1.0.18.box] Error 1

$ packer version
Packer v0.8.0

Would it be rude to ask why the issue and PR were closed without any comment, @annawake?


[FIXED JENKINS-38454] Make sure we add the triggers before starting.

https://issues.jenkins-ci.org/browse/JENKINS-38454
abayer:
This was...complex. But it works. We make sure the triggers property
has been added before starting, in case the start method for a trigger
class expects the trigger to already be present on the job. Existing
tests all pass, and the new test failed without the changes to
WorkflowJob and PipelineTriggersJobProperty. Phew.

Note - I'm working on getting rid of the need for posting hardcoded
JSON and just using form manipulation.

Creating PR to get artifact for testing.

This change is

@abayer is there any progress on it?

cc @reviewbybees esp @jglick since this is actually my change in the first place. =)

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

How much time do you need to fix thing that break existing installations?

#29

That's all?


Improve navigation to payment methods

We seem to be leaking the exchange_routes terminology into our UI

It isn't obvious what the Routes tab will lead to. I think we should term this as Payment Routes/Payment Methods in the UI.

For the tab though, we could use just 'Payments'

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30156053-improve-navigation-to-payment-methods?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

I think that it is good that we're leaking it. =) It provides transparency to people on how the funding actually work.
Sticking to Payment narrows Gratipay to being just accounting system. With Gratipay 1.0 Routing concept meant that people can reroute the donations to other people, and now they will be able transparent view on how money are moving, and how the routes are setup.
Yes, the UI is not there yet, because Gratipay 1.0 is shut, but I think that Routing is still more useful menu item than Payments. It you want to de-clutter interface, I would move Emails into Settings, renamed History into Balance (I believe @Changaco did that already) and moved that balance out of Settings.

(I guess @techtonik is talking about https://github.com/liberapay/liberapay.com/issues/67, but it's only tangentially related to this ticket. Liberapay has a Money I/O label for issues related to routes, but we don't have a Routes page, we have a Payin and a Payout page instead.)

Yes, but this ticket is labelled improve navigation, so it is related to user experience when they need to find a way to what:

"add money to their account"
"need to pay"
"need to setup the source of payment"

but this ticket is labelled improve navigation

Exactly, @techtonik. As a first-time user who isn't familiar with Gratipay terminology, would you expect the Routes tab to lead to any of the 3 options you mentioned above?

When I was working with #3887, it took me a while to understand that Routes actually means Payment Routes. If Payments doesn't exactly describe it, I think Payment Routes is a better option than just Routes. It at least makes it clear that it has something to do with payments.

That is the reason that I added Payment Routes instead of Routes in 86ca3d8cdec98c85ac0ba7189b271af9f487bfbd.

It isn't obvious what the Routes tab will lead to.

I agree that "Routes" is confusing to users (and I like "Money I/O" as a developer-facing term). I didn't go with "Payment Routes" originally because it was so long relative to the other nav items. "Payments" is maybe okay—probably better than "Routes"—though that's still ambiguous: is that payments I've made in the past? recurring payments I want to make in the future? oh, it's ... my bank account and credit card.
Looks like PayPal handles this with a "Money" page (which could start to move us towards #1063):

Not sure how deep we want to set the plow here, though. We could spend a lot of time and energy if we stir the pot on navigation and IA, and I think we have bigger fish to fry. I'd accept a simple PR that changes "Routes" to "Payments" (or "Money").

+1 on Twitter.


Whats new September 2019

Docs Build status updates of commit 1ef9308:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sysinternals/index.md
:warning:Warning
View
Details

toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

sysinternals/index.md

Line 32: [Warning] Invalid file link:(~/downloads/procexp.md).

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\cncm\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\cncm\bread\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1ef9308:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sysinternals/index.md
:warning:Warning
View
Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

sysinternals/index.md

Line 32: [Warning] Invalid file link:(~/downloads/procexp.md).

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\jy35\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\jy35\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.