add optional ax argument

Based on my issue raised.
Didn't add any tests but there none existed before.

:books: Documentation preview :books:: https://pymc-marketing--344.org.readthedocs.build/en/344/

Docs render a bit better now
https://pymc-marketing--344.org.readthedocs.build/en/344/api/generated/pymc_marketing.clv.plotting.plot_probability_alive_matrix.html#pymc_marketing.clv.plotting.plot_probability_alive_matrix

Thanks @wd60622


[Question]: How we can subscribe on state when all migrations will be applied ?

Is there any way to subscribe on upgrading state ?
As workaround we could set additional flag, wrapped all promises from upgrade function and set to true when all promises will be resolved
class DB extends Dexie {
  private static VERSION = 10;
   constructor(dbName: string) {
       this.version(Database.VERSION)
        .stores({ ... })
          .upgrade(tx => {
          if (Database.VERSION === 10) {
            void runLongTimeMigrations(tx, Database.VERSION);
          }
          console.log(`Database was upgraded to v.${Database.VERSION}`);
        });
   }
}

const db = new DB('DBName');
db.on('ready', () => {
    console.log('DB READY TO START');
   //  But actually DB is not ready and continue applied migrations
});

@dfahlander  thanks for response,

What I want to achieve:

start application when DB created schema if db is not exist.
if db is exist, start application only if all migration on data or schema will be done.

Callback on ready invoked when database in opened but I guess it better to run it when all migrations in upgrade function will be done

runLongTimeMigrations for ex. if we have a lot of data and we need to iterate and update smth,  inside it call dexies async func, upgrade` function by typings of typescript should not return promise, thats why I dont await it

@dfahlander I got your point,
If I correctly understand how I can manage migrations is wrap all of them by Dexie.waitFor:
for my example  I use only Dexie transaction updater for tables and dont call third party async func
class DB extends Dexie {
  private static VERSION = 10;
   constructor(dbName: string) {
       this.version(Database.VERSION)
        .stores({ ... })
        .upgrade(tx => {
           // wrapped all promises here
            Dexie.waitFor( async () => {
                  await runLongTimeMigrationsOnFirstTable(tx, Database.VERSION);
                  await runLongTimeMigrationsOnSecondTable(tx, Database.VERSION);
                  console.log(`Database was upgraded to v.${Database.VERSION}`);
              });
            });
        }
}

// migrations looks like
const runLongTimeMigrationsOnFirstTable = async (tx: Transaction, version: number): Promise<void> => {
 await tx.table('tableName').clear();
 // ..... populate with different data;
}


Extensions.DependencyInjection: KestrelServer unable to instantiate for https

System.AggregateException: One or more errors occurred. (ComponentActivator: could not instantiate Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer)
 ---> Castle.MicroKernel.ComponentActivator.ComponentActivatorException: ComponentActivator: could not instantiate Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer
 ---> System.Exception: Could not instantiate Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.
 ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.ArgumentNullException: Value cannot be null. (Parameter 'provider')
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerOptions.EnsureDefaultCert()
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerOptions.ApplyDefaultCert(HttpsConnectionAdapterOptions httpsOptions)
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions, Action`1 configureOptions)
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions)

Using the solution here seems to solve the issue: https://github.com/volosoft/castle-windsor-ms-adapter/pull/21

I don't think this is an issue necessarily, I seemed to have resolved it somehow.


prometheus-nextcloud-exporter: 0.6.2 -> 0.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/xperimental/nextcloud-exporter/releases.
meta.description for prometheus-nextcloud-exporter is: Prometheus exporter for Nextcloud servers
meta.homepage for prometheus-nextcloud-exporter is: https://github.com/xperimental/nextcloud-exporter
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.0 in filename of file in /nix/store/gd84l3lan1izv8d41c2dz35fip11pymw-prometheus-nextcloud-exporter-0.7.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
prometheus-nextcloud-exporter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gd84l3lan1izv8d41c2dz35fip11pymw-prometheus-nextcloud-exporter-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A prometheus-nextcloud-exporter https://github.com/r-ryantm/nixpkgs/archive/6198b255bae711d576a0027a033ffd496003f1fa.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6198b255bae711d576a0027a033ffd496003f1fa#prometheus-nextcloud-exporter

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gd84l3lan1izv8d41c2dz35fip11pymw-prometheus-nextcloud-exporter-0.7.0
ls -la /nix/store/gd84l3lan1izv8d41c2dz35fip11pymw-prometheus-nextcloud-exporter-0.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

prometheus-nextcloud-exporter

Maintainer pings
cc @WilliButz for testing.

Done in #298118.


fix: make "EntityType" type compatible with objects

Fixes https://github.com/mswjs/data/issues/250

Hey, @kettanaito
I was trying to export AnyObject but it doesn't solve the build error.
I think it's related with other thing.
Please take a look at it if you can.
Thanks

Released: v0.11.2 🎉
This has been released in v0.11.2!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/data@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


LoggingInterceptor is removing headers

When I setup interceptor my authorization header was removed

@Popalay Hi,
Can you share your code sample?

Retrofit @Header annotations must be handled.


[BUG] Microsoft.Azure.Functions.Worker.Extensions.ServiceBus generates references to NuGet packages with known vulnerablities

Issue Transfer
This issue has been transferred from the Azure SDK for .NET repository, #42260.
Please be aware that @seancostigan is the author of the original issue and include them for any questions or replies.
Details
Library name and version
Microsoft.Azure.Functions.Worker.Extensions.ServiceBus 5.17.0
Describe the bug
When referencing the Microsoft.Azure.Functions.Worker.Extensions.ServiceBus NuGet package in a .NET 8 Azure Function, the WorkerExtensions.csproj file that is created during the build is referencing Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.13.5, which has transitive dependencies on 2 NuGet packages with known high severity vulnerabilities (Grpc.Net.Client 2.49.0 and Grpc.AspNetCore.Server 2.49.0). This is causing our code scanning tool to block the application due to the vulnerabilities.
This is the WorkerExtensions.csproj file that is generated during the build:
<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <TargetFramework>net6.0</TargetFramework>
        <LangVersion>preview</LangVersion>
        <Configuration>Release</Configuration>
        <AssemblyName>Microsoft.Azure.Functions.Worker.Extensions</AssemblyName>
        <RootNamespace>Microsoft.Azure.Functions.Worker.Extensions</RootNamespace>
        <MajorMinorProductVersion>1.0</MajorMinorProductVersion>
        <Version>$(MajorMinorProductVersion).0</Version>
        <AssemblyVersion>$(MajorMinorProductVersion).0.0</AssemblyVersion>
        <FileVersion>$(Version)</FileVersion>
        <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
    </PropertyGroup>
    <ItemGroup>
        <PackageReference Include="Microsoft.NETCore.Targets" Version="3.0.0" PrivateAssets="all" />
        <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="4.2.0" />
        <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.13.5" />

    </ItemGroup>
</Project>

Please update Microsoft.Azure.Functions.Worker.Extensions.ServiceBus and Microsoft.Azure.WebJobs.Extensions.ServiceBus so that they use later versions of the NuGet packages to address the vulnerabilities.
Expected behavior
Using Microsoft.Azure.Functions.Worker.Extensions.ServiceBus should not pull in NuGet packages with known security vulnerabilities
Actual behavior
Microsoft.Azure.Functions.Worker.Extensions.ServiceBus pulls in NuGet packages with known security vulnerabilities which is causing my pipeline code scanning tool to block my application
Reproduction Steps

Create a new .NET 8 Azure Function
Select Service Bus Topic trigger
Once the project loads, open the NuGet package manager and update all directly referenced NuGet packages to the latest version
Build the project
Check the bin\Debug\net8.0.azurefunctions folder and you will find Grpc.Net.Client 2.49.0 and Grpc.AspNetCore.Server 2.49.0
You can view the WorkerExtensions.csproj file in \obj\Debug\net8.0\WorkerExtensions
Open the .csproj file and you can see that it is referencing <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.13.5" /> which has transitive dependencies on Grpc.Net.Client and Grpc.AspNetCore.Server

Environment

Windows 10 .NET 8.0 (.NET SDK 8.0.102)
Visual Studio 17.8.7

@seancostigan The servicebus extension package version you mentioned does not have any vulnerabilities. But I see your Microsoft.NET.Sdk.Functions package is not the latest version. Can you please update Microsoft.Azure.Functions.Worker.Sdk package to the latest stable version in your function app project? That should bring the latest version of Microsoft.NET.Sdk.Functions package in the auto genreated WorkerExtensions project. This should solve your issue.
Let us know if you are still experiencing any issues. Thanks!

@kshyju I updated Microsoft.Azure.Functions.Worker.Sdk to the latest version (1.17.1) and that did update Microsoft.NET.Sdk.Functions to 4.3.0 in the WorkerExtensions.csproj
Here are the package references now in WorkerExtensions.csproj:
<ItemGroup>
    <PackageReference Include="Microsoft.NETCore.Targets" Version="3.0.0" PrivateAssets="all" />
    <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="4.3.0" />
    <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.13.5" />
</ItemGroup>

However, in the bin/Debug/net8.0/.azurefunctions folder for my Azure Function, it is still referencing the two vulnerable Grpc NuGet packages. I believe those are being pulled in by Microsoft.Azure.WebJobs.Extensions.ServiceBus, so I think that is the package that needs to be updated.

Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.13.5 does not have any vulnerabilities. You can verify this by creating a project which has a reference to this package and then run dotnet list package --vulnerable --include-transitive.

Try a dotnet clean and see that helps? Can you run dotnet list package --vulnerable --include-transitive on the auto generated WorkerExtensions project and share what it reports? If it reports any warnings, let's take a binary search approach to narrow down the culprit entry. Try removing half of the package reference entries and execute the command again. try the binary search approach until you find out the package reference entry which is causing the error. Please share what you find.

I ran the dotnet list package --vulnerable --include-transitive command on my project and I get the same results as you (no vulnerable packages). However, the vulnerability scanning tool integrated with my pipeline is reporting two vulnerabilities.

Both are related to this item: https://nvd.nist.gov/vuln/detail/CVE-2023-32731

Looks like some other package your project references is causing the issue. Can you share all the package references you have? Can you make sure all of them are the latest stable versions?

I confirmed all the directly referenced packages in my project are at the latest version:
<ItemGroup>
  <FrameworkReference Include="Microsoft.AspNetCore.App" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker" Version="1.21.0" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.1.0" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore" Version="1.2.1" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.ServiceBus" Version="5.17.0" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" Version="1.17.1" />
  <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" Version="2.22.0" />
  <PackageReference Include="Microsoft.Azure.Functions.Worker.ApplicationInsights" Version="1.2.0" />
</ItemGroup>

Looking at the WorkerExtensions project, I see that the Grpc.AspNetCore.Server and Grpc.Net.Client packages are being pulled in as transitive dependencies from Microsoft.Azure.WebJobs.Extensions.ServiceBus

Hm, that is strange, with the nuget command, I still do not see any vulnerability issues being reported for Grpc.Net.Client 2.49.0 when trying in a console app.

May I ask what scanning tool you have in your CI?

We are using Aqua

@seancostigan I do not see any information in the linked CVE page which says the Grpc.Net.Client 2.49.0 version is impacted. Can you point me to the page which has this information?

AquaSec's (Who makes Trivy) vulnerability team associated the issue with the base upstream GRPC source to the NuGet packages. Aqua's page is here: https://avd.aquasec.com/nvd/2023/cve-2023-32731/
That public page contains the same information as NVD. Their tooling reports that the issue also impacts Grpc.Net.Client and Grpc.AspNetCore.Server.
The following are the information blocks from the AquaSec Scanner reported in the UI:

Any progress on this issue or plans on doing anything with it?

@JamesNK could you comment on this CVE that reportedly comes from gRPC packages? Nuget does not have any vulnerability reported for those package versions. Does this CVE not apply here? Was it an oversight to not flag those nuget packages as vulnerable?

I got a notification about this issue being marked as stale and needing a response to keep it from being closed. So responding here, but I think @jviau captured the open question in the response above.

That CVE is wrong. Grpc.Net.Client and Grpc.AspNetCore.Server aren't impacted. It's HTTP/2 implementation is different.
Can you please give feedback to whoever says those packages are vulnerable to fix it.

@JamesNK Thank you for confirming that there is no issue with these packages. I have relayed the information to my Product Security team and they are going to work with AquaSec to identify this as a false positive.

Closing this as resolved/no action.


apply ackable message to user-group management messages in persistent mode for management sdk

apply #1464 to other user group management messages

Please don't merge until 1.13.0 is released.

Got it

This can be merged now .


Sync main with dev

Purpose
Sync main with dev.

Configuring:
1)https://wso2.com/choreo/docs/administer/configure-an-external-idp/configure-asgardeo-as-an-external-idp/
2)https://wso2.com/choreo/docs/administer/configure-an-external-idp/configure-azure-ad-as-an-external-idp/
Setting up

https://wso2.com/choreo/docs/authentication-and-authorization/secure-api-access-with-asgardeo/
https://wso2.com/choreo/docs/authentication-and-authorization/secure-api-access-with-azure-ad/


mashery-toolbelt ls (for package)

Hi @schovi , we have existing function to get list of services "ls command".
Can we plan to have similar function to get list of packages?
It will be great to get all the packages names & ids (similar to mashery-toolbelt ls) and us it to backup with "backup-package  [backupName]" in a single run.

@schovi this function works. Task can be closed.. :)


README typos

Did you know: 3 jobs ago I was working with somebody called Togher, they were one of only 2 people to respond to my goodness email. But that wasn't with Mithril - it was with React.

Hi Barney 🙂 Thanks for the fixes..
Now, what is this little story here? I'm not sure I catch the context or meaning of it. Care to elaborate ? 🤔

Well the original text read "Togher with Mithril", but you see I distinctly remember being with Togher, and it was definitely not with Mithril ;P


feat: add file create trigger

At the meeting, we discussed the changes.

I've deleted all unnecessary comments


Validate node's providerID in case it's empty

When the kubelet is not run with --cloud-provider=aws, the value of node.Spec.ProviderID is "". I found this to be the case in our cluster since we didn't need persistent volume support right away and were running without the cloud provider enabled.
In the absence of this validation, the error is fairly hard to identify. The result is a call to IsNodeHealthy with an empty string as the instance ID which calls ec2:DescribeInstanceStatus with the same input. Amazon rejects that request with a 400.
I've also added a short section to the setup docs mentioning that the cloud provider is required.

Coverage decreased (-0.03%) to 23.934% when pulling 92cc1fcf074ff97cee283e12cc9034e82c4672ee on bendrucker:validate-provider-id into 86ceee1e0ff05b0f414bf831f131a4ab95bcf923 on kubernetes-sigs:master.

nice find! Thanks @bendrucker


swift::fatalError crash

Describe the bug
Pock crashed.
How to reproduce
Unknown, no user interaction when it crashed.
Expected behavior
Pock does not crash.
Crashlog
Pock_2021-02-23.crash.txt
If applicable, add crashlog to help me investigate your problem.
1. Open the Console application located at "Application -> Utilities -> Console.app."
2. Click on "User Reports" in the left menu, then locate the latest Pock crash report. (You can filter reports by typging "pock" into the searchbar on the top)
3. "ctrl + click" on the latest Pock crash report and click on "Reveal in Finder" option, then attach the .crash file in this issue.

Versions:

macOS version: 11.2.1
Pock version: 0.8.1-5

Additional context
Add any other context about the problem here.

Maybe this will work.
diff --git a/ControlCenter/Sources/PressableSegmentedControler.swift b/ControlCenter/Sources/PressableSegmentedControler.swift
index b2bc1c9..f5d6596 100644
--- a/ControlCenter/Sources/PressableSegmentedControler.swift
+++ b/ControlCenter/Sources/PressableSegmentedControler.swift
@@ -51,4 +51,8 @@ class PressableSegmentedControl: NSSegmentedControl {
         location = .zero
         super.touchesEnded(with: event)
     }
+
+    deinit {
+        timer?.invalidate()
+    }
 }


D-ECE Computation

Can you provide the code snippet you used for D-ECE computation? I am trying to reproduce the D-ECE results with your checkpoints, but it is not matching. In COCO val dataset, there seems to be many images with no GT boxes. I would like to know how you handled them in D-ECE computation.

Thank you for your interest. Please follow the guidelines here
You need to input det files along with imageids.

There are some images for which no annotation is present (eg image ids: 25593, 41488, 49091, 58636). For now, I simply ignored them in ECE computation. My code to compute D-ECE is as follows:
    def compute_d_ece(val_data_loader, coco_api_val):

	thresh_levels = np.arange(50, 100, 5)/100
	dataset_matched = {thresh:torch.zeros(0).to(device) for thresh in thresh_levels}
	dataset_confidences = torch.zeros(0).to(device)

	for count, (samples, targets) in enumerate(val_data_loader):

	    #get the output for each sample
	    outputs = model(samples)
	    orig_target_sizes = torch.stack([t["orig_size"] for t in targets], dim=0)
	    results = postprocessors['bbox'](outputs, orig_target_sizes)[0]
	    pred_boxes, pred_labels, pred_confidences = results["boxes"], results["labels"], results["scores"]

	    """ target_box_labels and target_boxes are obtained with img ids. Used a batch size of 1 """
	    ann_ids = coco_api_val.getAnnIds(imgIds=targets[0]['image_id'])
	    target = coco_api_val.loadAnns(ann_ids)
	    anno = [obj for obj in target if 'iscrowd' not in obj or obj['iscrowd'] == 0]
	    target_box_labels = torch.tensor([obj["category_id"] for obj in anno], dtype=torch.int64).to(pred_boxes.device)
	    target_boxes = box_ops.box_xywh_to_xyxy([obj["bbox"] for obj in anno])

	    if len(target_box_labels)>0:
		""" used this condition because for some images, there were no GT boxes """
		dataset_confidences = torch.cat([dataset_confidences, pred_confidences], dim=0)
		#compute ious and label match
		ious = torchvision.ops.box_iou(pred_boxes, target_boxes)
		label_match = (pred_labels.unsqueeze(1).repeat(1, target_box_labels.shape[0]) == target_box_labels)

		for thresh in thresh_levels:
		    iou_match = (ious>=thresh)
		    matched = torch.any(label_match*iou_match, dim=1)
		    dataset_matched[thresh] = torch.cat([dataset_matched[thresh], matched], dim=0)

	n_bins = [20]
	ece_thresh_levels = []
	ece = netcal.metrics.ECE(n_bins, detection=True)
	for thresh in thresh_levels:
	    calibration_score = ece.measure(dataset_confidences.cpu().numpy(), dataset_matched[thresh].cpu().numpy())
	    ece_thresh_levels.append(calibration_score)

	print("Final ECE: [ With NETCAL]: {}".format(np.array(ece_thresh_levels).mean())

This is giving an ECE as follows using your checkpoint of Cal-DETR:
Final ECE: [With NETCAL]: 0.05589909592506961
For MBLS checkpoint, it is around 0.06.
Can you please help me to identify where I am doing wrong in D-ECE computation.

Please go through this code
You can see how it proceed with detections and ids. Also score threshold and number of bins matter to compute D-ECE. Note that our bins setting is 10 and threshold is 0.3 as specified in code. Run for few examples first then scale it for whole test set.

Thanks, Akhtar for the clarification. I will work with the example and change the parameters as you mentioned.


Still need to specify technique="MS" to read ziline .tsv without EC data

It is very common to run zilien without linking an EC experiment for all kinds of reasons.
However, when doing so and using
meas = Measurement.read(path_to_tsv), it raises this error:
ixdat.exceptions.SeriesNotFoundError: <ixdat.readers.zilien.ZilienTSVReader object at 0x7f2eabc74c90> loaded without ECMSMeasurement essential series 't'
This is because the zilien reader by default uses the ECMSMeasurement class rather than the MSMeasurement class as would be appropriate in cases without biologic data. It would be nice if the ZilienMPTReader would use MSMeasurement by default and only ECMSMeasurement when it can detect that EC data is included.
meas = Measurement.read(path_to_tsv, technique="MS") works.
I feel this issue has been raised before, but can't find it. (I also misremember it as having been solved before). Possibly related to https://github.com/ixdat/ixdat/issues/114

Closing as a duplicate of #95 (I was sure it had already been reported...)


Dont import all scripts maybe

If there are eventually too many builtin scripts maybe make it possible to import some of the less common ones separately.

this will be done at the very end to break out the scripts into helper modules such as rendering and physics


Lazily compile regular expressions to speed up load time

I'm wrapping up re-writing a CLI tool where responsiveness is critical and during the switch from toml to tomli I noticed load time increased by ~1-2 milliseconds. This PR brings it down the equivalent amount.
If you don't like the singleton you can eventually use https://www.python.org/dev/peps/pep-0562/ but I haven't benchmarked that way.

Thanks for the PR!
I believe this should mostly be helpful in CLI invocations where TOML isn't actually parsed (but import tomli still runs). The parsing of almost any real world TOML file will probably still run the code path where regexes are compiled. Do you agree?
If the assumption is correct, then maybe it is more reasonable that applications where this 1-2 milliseconds is critical make this optimization themselves by importing Tomli lazily, only when parsing actually happens?
If we still come to the conclusion that this optimization makes sense, what do you think about implementing this with something like
@lru_cache(mazsize=None)
def regex(name: str) -> "re.Pattern":
    if name == "datetime":
        ...
    elif name == "number":
        ...
    ...

in _re.py. And then
from tomli._re import regex
# Just an example
regex("datetime").match(src, pos)

in _parser.py
Then we'd not need the singleton and also slightly less dunder magic.

Btw triggering GitHub actions via pre-commit.ci is absolutely genius :smile: Had not realized one could do that. Will start using that trick myself if I ever need it.

Hmm, good point. I hadn't read the code thoroughly: so the patterns are always used for every invocation of loads()?

In the current state, if the TOML file contains a value assignment of a number (float, integer, hex, etc.), inline array, or inline table, then all regexes will be compiled. If these are not assigned but a datetime or localtime is, then some, but not all regexes will be compiled.
I assume there's not many TOML files where for example no integers or floats are assigned.

Ah okay thanks! Yes my pyproject.toml files also have no floats nor integers. This is what I'm seeing:
$ python -m timeit -n 1 -r 1 -s "from pathlib import Path;t=Path('pyproject.toml').read_text()" "import toml;toml.loads(t)"
1 loop, best of 1: 7.36 msec per loop
$ python -m timeit -n 1 -r 1 -s "from pathlib import Path;t=Path('pyproject.toml').read_text()" "import tomli;tomli.loads(t)"
1 loop, best of 1: 8.68 msec per loop

Lazy compilation of the regular expressions + your idea of re-ordering makes the first run as fast as toml even with numbers! I just pushed a commit.

Great! Would you mind using the "lru_cache" implementation I described earlier? I'd much prefer it over "setattr/_getattr_/singleton" if there's no significant performance or other drawbacks.
No worries about bad commit history or force-pushes btw, I will do a squash when we merge this anyways.

Also, would be great if you could confirm that this actually fixes the responsiveness issue of your CLI tool (a real world problem), and that the issue is not fixable by lazily importing Tomli.
This is already in a territory of micro-optimizations where we have to do trade-offs: we sacrifice some performance of parsing large TOML files and TOML files with numbers, to achieve better performance with small files without numbers. I don't think that this is that obvious trade-off to make, so would be much happier merging if at least we fix your real-world problem.

If there are no numbers then this fixes it, otherwise no. If only the number pattern wasn't greedy and could come before dates since dates aren't that common 😄
However, I think it would still be beneficial overall to incorporate your idea and move those 2 simple equality checks to before those 3 regex searches. Would you like me to keep that one change?

Thanks!


Split the trade currency settings on a per game basis

Currently, the same setting is used for both PoE1 and PoE2. The economy is vastly different in both games (exalts in PoE2, divines in PoE1). Having distinct settings should be a better experience

Previously fixed


Fork, Commit, Merge - Easy Issue (Python)

Fork, Commit, Merge - Easy Issue (Python)
Simple Python Program to Interact with Lists
Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!
The aim of this task is to create a Python script that creates a list of numbers and performs simple operations on it. Specifically, the program should create a list of the first 10 natural numbers (1 through 10), print the list and print the sum of the numbers in the list.
Acceptance Criteria:

The program should create a list of the first 10 natural numbers.
The program should print the created list to the console.
The program should print the sum of the numbers in the list.

Hint: You can use Python's built-in sum function to calculate the sum of numbers in a list.
Start by opening the tasks/python/easy directory from the root of the project.
Then open number_list.py file and start working on your solution!
To test the program, you can run python3 tasks/python/easy/number_list.py to see if it works as expected.

To work with this issue, you need to have Python installed to your local machine.
Check out README.md for more instructions of installing Python and how to make a pull request.
Feel free to ask any questions here if you have some problems!
Also, kindly give this project a star to enhance its visibility for new developers!

assign it to me i am working on this

assign it to me i am working on this

Hi! As it says on the description, these educational issues are not assigned since they are supposed to be always open.


compiler.run callback doesn't receive any errors

If I run webpack cli tool I get errors (which is correct!), but if I run it as a Node module i don't get any errors in my callback.
I made this repo to help you reproduce the issue.

Did you check the stats object for the errors? They should be there.

Yes I do, both the error and the stats.errors, there's nothing there.

Damn it, I found the error: the right way of checking for errors is by stats.hasErrors().
Although it could be easier to find out =/


Update product-details.tpl

Hi everyone,
I propose a modification of the page which allows to hide the availability date if the product is in stock, because this information is visible when the product is available.
At the same time, I add a modification of the date format, depending on our location.
Lucas,
Piment Bleu Agency (FR)

Questions
Answers

Description?
I propose a modification of the page which allows to hide the availability date if the product is in stock, because this information is visible when the product is available. At the same time, I add a modification of the date format, depending on our location.

Type?
Bug fix.

Deprecations?
No.

Fixed ticket?
No.

How to test?
You need a product with stock and an availability date to view.

Possible impacts?
None.

@lucasvavon same as in the other PR you provided:
https://github.com/PrestaShop/classic-theme/pull/12#issuecomment-1070656522

Hey @lucasvavon
What about a scenario where you sell hand-made products? You want to be able to sell them, but their available date is, for example, two weeks in the future.

Hi @lucasvavon,
Since we have had no news from you since March, I will follow our guidelines, and I'll close this pull request as it seems stale. Feel free to reopen or open another one if you think it's still relevant.
Thanks!


All-sigs meeting for October 31 (tenative)

Tenative - Nick L will be out, so geds-dm (discord) may officiate.

SIG-Core Update:
Roadmap

Work on the Quality and Scalability Framework is paused, but will continue soon https://github.com/o3de/sig-core/issues/57

New RFCs

RFC to discuss ideas on improving first time Asset Processor experience for a new project has been published: https://github.com/o3de/sig-core/issues/59

Meeting Recording: https://drive.google.com/file/d/1LnAy_fuB7W0a2OD9gE14MT8HRhjoUBPn/view?usp=sharing


Experimental: cloudflare workers example

Add a simple example to show how cloudflare workers can be glued up to a lambda handler
The natural next step would be a bidi server that supports websockets
Uses a dist-tagged worker release of the typescript sdk - the sdk needed to be bundled differently (and with various polyfills for node native libraries) in order to support this properly

@jackkleeman Is this still relevant?

Nope


feat(project): add dev api support

add dev api for internal testing purposes
add dev player for testing purposes

IN PROGRESS
Steps completed:

According to our definition of done, I have completed the following steps:

[ ] Acceptance criteria met
[ ] Unit tests added
[ ] Docs updated (including config and env variables)
[ ] Translations added
[ ] UX tested
[ ] Browsers / platforms tested
[ ] Rebased & ready to merge without conflicts
[ ] Reviewed own code

@dbudzins should work now.

api host value gets saved internally why navigating within application. We don't keep the value in the query, if the page gets reloaded we lose it.
In case we change the config to a production one, we use a production api by default (when no additional env query provided)
I have also added a separate player for dev stored in our ott account.
player value for dev environment is taken only from a local value in the codebase. For production api we first analyse the .env file and then use a local value (as it worked previously).

PR is a bit out of date from several refactors. If we pursue this, we can use the new structures to start fresh.


Set the DNS record for Vercel deployment

The configuration for the domain is located at https://vercel.com/xarray/pangeo-io/settings/domains. We need to set the A Record and CNAME at the account at http://dns.he.net/ in order for this site to be deployed to the pangeo.io domain.

@jhamman would you be willing to update the DNS record for Pangeo, as someone who's both part of the Xarray Vercel team and HE account? Otherwise I'll ask to be added to the HE account, but I'd rather leave the DNS management to others. I would be super grateful for your help with this 😄

I can definitely do this. Should be done in the next 24 hours.

This is done now!

https://pangeo.io/
https://www.pangeo.io/

DNS is still updating so let me know if folks notice anything odd.


Not full port? Scroll/sticky/parallax is present?

Hi guys. Recently discovered UIKit, but was frustrated since it's using jQuery. Then I found you, but frustrated once again, since I can't find all UIKit components, that I needed in first place:
Animation
Grid parallax
Parallax
Scroll
Scrollspy
Sticky
Is there any specific issues/reasons why you can't implement them? Or may be it's in plans?

Hi @kodeJ, we are porting what we need/use in our projects. Beside Sticky, which is on the list, the rest is currently not planned.

Ok. Well, proper sticky implementation also nice. Hope it will be compatible with SSR, since other Vue-sticky packages are not (at least I wasn't able to load them).


Fix typo in link to certificate REST APIs

This changes the link text from "Keys operations with REST" to "Certificate operations with REST"

@ryanq : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks correct; verified link target titles.


[bug] play.image needs pygame.image.load instead of strings

What happened?
A bug happened!
to change the image, currently this works:
afbeelding = play.new_image('chips.png')
afbeelding.image = pygame.image.load('door.png')
the preferred way would be:
afbeelding = play.new_image('chips.png')
afbeelding.image = 'door.png'
without pygame.image.load
Version
latest
Relevant log output
No response

True! This is not intended behavior, when accessing ._image you're messing with internal code, not with intended behavior for users.


RT-1.32 Adding med and local pref sub tests

Adding below testcases

RT-1.32.2 - IPv4, IPv6 eBGP set MED
RT-1.32.3 - IPv4, IPv6 iBGP increase MED
RT-1.32.4 - IPv4, IPv6 eBGP increase MED
RT-1.32.5 - IPv4, IPv6 iBGP set Local Preference
RT-1.32.6 - IPv4, IPv6 eBGP set Local Preference

Pull Request Functional Test Report for #2713 / c215714e5815b9c51a4a54cf997ac9be8be5403c
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
43bed08e
Log

Cisco 8000E

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
33ed69a6
Log

Cisco XRd

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
7faba675
Log

Juniper ncPTX

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
6f9c9322
Log

Nokia SR Linux

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
66d33dbd
Log

Openconfig Lemming

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control
e0517011
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Cisco 8808

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Juniper PTX10008

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Nokia 7250 IXR-10e

RT-1.32: BGP policy actions - MED, LocPref, prepend, flow-control

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.056%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1736

Relevant Lines:
3272

💛  - Coveralls


Add /usr/libexec/cups to the list of system dirs

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

Currently some uninstall pkgutil: casks (example) fail on uninstall when trying to chmod 777 /usr/libexec/cups since this directory has sunlnk flag set. This PR adds it to the list of system directories to prevent uninstaller from trying to change the permissions or remove it.

What extactly does the sunlnk flag do? Could this be used to determine whether a file/directory is a system file/directory?

It's a flag inherited by macOS from BSD. macOS man pages no longer mention it, but FreeBSD ones still do in chflags(1):

 sunlnk, sunlink
     set the system undeletable flag (super-user only)

More in chflags(2):

 SF_NOUNLINK	 The file may not be renamed or	deleted.

There is also a semantically similar (same?) restricted flag introduced in El Captain with SIP. Here is the list of directories from the current list with either flag set:

sunlnk

/Applications
/Applications/Utilities
/Library
/Library/Filesystems
/Library/Preferences
/System/Library/Caches
/System/Library/Extensions
/System/Library/Speech
/private
/private/var
/usr/local
/usr/share/manrestricted

/System
/System/Library
/System/Library/Accessibility
/System/Library/Accounts
/System/Library/Assistant
/System/Library/Automator
/System/Library/BridgeSupport
/System/Library/ColorSync
/System/Library/Colors
/System/Library/Components
/System/Library/Compositions
/System/Library/CoreServices
/System/Library/DTDs
/System/Library/DirectoryServices
/System/Library/Displays
/System/Library/Filesystems
/System/Library/Filters
/System/Library/Fonts
/System/Library/Frameworks
/System/Library/Graphics
/System/Library/IdentityServices
/System/Library/InternetAccounts
/System/Library/Java
/System/Library/KerberosPlugins
/System/Library/Keychains
/System/Library/LaunchAgents
/System/Library/LaunchDaemons
/System/Library/LinguisticData
/System/Library/LocationBundles
/System/Library/LoginPlugins
/System/Library/Messages
/System/Library/Metadata
/System/Library/MonitorPanels
/System/Library/OpenDirectory
/System/Library/OpenSSL
/System/Library/Perl
/System/Library/PreferencePanes
/System/Library/Printers
/System/Library/PrivateFrameworks
/System/Library/QuickLook
/System/Library/QuickTime
/System/Library/Recents
/System/Library/SDKSettingsPlist
/System/Library/Sandbox
/System/Library/ScreenReader
/System/Library/ScriptingAdditions
/System/Library/ScriptingDefinitions
/System/Library/Security
/System/Library/Services
/System/Library/Sounds
/System/Library/Spotlight
/System/Library/StartupItems
/System/Library/SyncServices
/System/Library/SystemConfiguration
/System/Library/SystemProfiler
/System/Library/Tcl
/System/Library/TextEncodings
/System/Library/UserEventPlugins
/System/Library/Video
/System/Library/WidgetResources
/bin
/etc
/sbin
/tmp
/usr
/usr/bin
/usr/include
/usr/lib
/usr/libexec
/usr/sbin
/usr/share
/var

A file or directory that has either of these two flags is preconfigured by OS to be effectively undeletable. If that sounds reasonable, I can modify the code here to consider any directory with either flag to be a system directory. I would appreciate though if we do it in a separate PR and merged this one as is: this change is smaller, and it blocks casks for any pkgutil printer drivers.

Here is the list of directories from the current list with either flag set:

Ok, seems like our current approach covers a lot more, especially user directories, so let's keep it that way then.

Thanks!


No static "create" method found

Also "redis://" did not work on my mac at least

I now saw that the create method exists in 4.x.

Thanks for your PR. The documentation reflects already the 3.4/4.1 code. That's the reason why you noticed the missing create methods.


use ObjectManager instead of EntityManager

EntityManager (that extends ObjectManager) is not required to work with Algolia.
Replacing EntityManager by ObjectManager allows us more flexibility without regression and is compatible with so used $doctrine->getManager() method.

Hi @chrjean,
Thank you for your contribution. I reviewed your PR and I think all your changes have been introduce by this PR #54. Please let me know if I missed something and I'll reopen it.


It appears like the examples/flutter_gallery is not being built for github PR presubmit tests

My change in https://github.com/flutter/flutter/pull/20427 had passed all the tests. After landing it broke half of the builders on the flutter dashboard.
It seems like the github PR presubmit tests don't build the flutter_gallery. I think we should add building the gallery to the tests we run on cirrus.

I see flutter_gallery being tested as part of the PR presubmit checks:
⏩ RUNNING: cd examples/flutter_gallery; ../../bin/flutter test

00:00 +0: loading /tmp/flutter sdk/examples/flutter_gallery/test/simple_smoke_test.dart
00:01 +0: loading /tmp/flutter sdk/examples/flutter_gallery/test/simple_smoke_test.dart

Could it be the issue you saw was caused by different version of dart sdk on build machine vs device lab machines?

There is a difference between flutter test and flutter build apk/aot.
From this log you can clearly see an error:
[ +263 ms] [ +308 ms] Error detected in pubspec.yaml:
[        ] [        ] No file or variants found for asset: packages/flutter_gallery_assets/food/image10.jpg.

All cirrus presubmit tests were green and did therefore not report this issue.

I think it's safe to close the issue as mentioned above PR is merged on April 6. Please correct me if I'm wrong.


About the virtual machine hot plug problem

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind enhancement

What happened:
Hello, I am hot-plugging the disk into the virtual machine, whether it is Windows or Linux operating system, when the hot-plugged disk is recognized, it can be recognized as an unformatted empty disk.
But after I format this disk, I cannot perform removevolume operation on the disk.
$ virtctl removevolume ubuntu --volume-name=example-volume-hotplug
Error removing volume, admission webhook "virtualmachineinstances-update-validator.kubevirt.io" denied the request: Number of permanent volumes has changed

What you expected to happen:
My understanding is that hot plugging can be used to plug and unplug available disks while the virtual machine is powered on.
How to reproduce it (as minimally and precisely as possible):
apiVersion: cdi.kubevirt.io/v1beta1
kind: DataVolume
metadata:
  name: example-volume-hotplug
spec:
  source:
    blank: {}
  pvc:
    accessModes:
      - ReadWriteOnce
    resources:
      requests:
        storage: 5Gi

virtctl addvolume ubuntu --volume-name=example-volume-hotplug

Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@newhuangchuan the formatting shouldn't have any effect on the hotplug and unplug. Could you please provide is the sequence of the commands you are trying? Where does the formatting take place?
Are you able to add and remove the volume as it is? Just by performing:
$ virtctl addvolume ubuntu --volume-name=example-volume-hotplug
$ virtctl removevolume ubuntu --volume-name=example-volume-hotplug

Could you please also provide the virtctl version output?
FYI @awels

In the current environment:
$ virtctl addvolume ubuntu --volume-name=example-volume-hotplug
error adding volume, Operation cannot be fulfilled on virtualmachineinstance.kubevirt.io "ubuntu": Unable to add volume [example-volume-hotplug] because it already exists
$ virtctl removevolume uos-test1 --volume-name=example-volume-hotplug
Error removing volume, admission webhook "virtualmachineinstances-update-validator.kubevirt.io" denied the request: Number of permanent volumes has changed

Kubevirt version

$ virtctl version
Client Version: version.Info{GitVersion:"v0.41.2", GitCommit:"29ce26e09eeed30f89f3fd5d1ad0598955de9648", GitTreeState:"clean", BuildDate:"2021-07-28T16:23:53Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.41.2-dirty", GitCommit:"29ce26e09eeed30f89f3fd5d1ad0598955de9648", GitTreeState:"dirty", BuildDate:"2021-07-28T16:57:02Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}

My disk was formatted in a virtual machine, including using diskmgmt.msc in Windows and fdisk /dev/sda in Linux system.

@newhuangchuan can you try with a fresh VM without formatting the disk? From the example, it seems to me that you already added that volume. It is just to ensure that it is just the unplug and exclude the formatting

@newhuangchuan can you try with a fresh VM without formatting the disk? From the example, it seems to me that you already added that volume. It is just to ensure that it is just the unplug and exclude the formatting

You mean. Are you creating a DV and adding it to a new virtual machine?
This operation is no problem. The newly created DV is an unformatted empty disk and can be inserted and removed all the time.
However, because in Linux system or Windows system, it needs to be formatted before it can be used.
So I wonder if this hot-swappable disk is only suitable for a disk that has been written by the file system for hot-swapping.

@newhuangchuan can you try with a fresh VM without formatting the disk? From the example, it seems to me that you already added that volume. It is just to ensure that it is just the unplug and exclude the formatting

Hello, I re-tested here, created a DataVolume, and then virtctl addvolume to the virtual machine.
Execute the command mkfs.ext4 /dev/sda && sudo mount /dev/sda /mnt, and then unplug it is no problem.
I'm thinking about a question, is it caused by the partition operation of fdisk I performed

Can you post the VM definition of the VM where this is not working from a KubeVirt perspective we don't care at all what you do with a disk once it is attached to the VM. The error message you are seeing is highly unusual and really should never happen. We have some logic that identifies which disks are hotplugged and which ones are not. And the error is coming from there.

Hello, the following is the content of the yaml file of my virtual machine. After the Windows system is formatted, it cannot be removed. The Linux system can be removed without partitioning. After partitioning, it fails.
$ cat windows-nfs.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: winhd-nfs
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 100Gi
  storageClassName: nfs
---
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachine
metadata:
  name: windows-nfs-1
spec:
  running: false
  template:
    metadata:
      labels:
        kubevirt.io/domain: windows-nfs-1
    spec:
      domain:
        cpu:
          model: Nehalem
          cores: 4
        resources:
          requests:
            memory: 4G
          limits:
            memory: 4G
        devices:
          disks:
          - bootOrder: 1
            cdrom:
              bus: sata
            name: cdromiso
          - bootOrder: 2
            disk:
              bus: virtio
            name: harddrive
          - cdrom:
              bus: sata
            name: virtiocontainerdisk
          interfaces:
          - name: default
            masquerade: {}
          rng: {}
        machine:
          type: q35
      networks:
      - name: default
        pod: {}
      terminationGracePeriodSeconds: 0
      volumes:
      - name: cdromiso
        persistentVolumeClaim:
          claimName: windows-nfs-iso
      - name: harddrive
        persistentVolumeClaim:
          claimName: winhd-nfs
      - containerDisk:
          image: kubevirt/virtio-container-disk
          imagePullPolicy: Never
        name: virtiocontainerdisk

I am wondering if it is related to my version of kubevirt?
]$ virtctl version
Client Version: version.Info{GitVersion:"v0.41.2", GitCommit:"29ce26e09eeed30f89f3fd5d1ad0598955de9648", GitTreeState:"clean", BuildDate:"2021-07-28T16:23:53Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.41.2-dirty", GitCommit:"29ce26e09eeed30f89f3fd5d1ad0598955de9648", GitTreeState:"dirty", BuildDate:"2021-07-28T16:57:02Z", GoVersion:"go1.13.14", Compiler:"gc", Platform:"linux/amd64"}

@newhuangchuan can you just try with one of the examples like for example vm-apline-datavolume and try to add and remove a volume from that VM?
This should prove at least if it is your kubevirt version

Hello, what if it is a virtual machine with persistent volumes?

hotplugging should not care if it is a DV or a PVC, a DV is just a wrapper around a PVC, and in the end its a PVC mounted into the pod.

Is this still a problem?

Is this still a problem?
Yes, I am currently using the hot-swappable disk and snapshot function, and I feel that there are some problems with these, I don't know if it is because of the version.


Add integration tests (all test classes renamed!!!)

so that default gradle build doesn't halt on contractTest
Now, gradle build works even of the smart contract doesn't. To trigger test with contract, do gradle integrationTest
there are only renaming stuff in the PR so you can safely approve it and merge if the two commands works correctly on your PC
gradle build should work
gradle integrationTest should fail with the testContract problem.
gradle check should fail too as it includes integrationTest.
See below.
$ gradle build
Configuration on demand is an incubating feature.

BUILD SUCCESSFUL in 1s
5 actionable tasks: 2 executed, 3 up-to-date
a@thinkpad:~/IdeaProjects/attestation$ gradle integrationTest
Configuration on demand is an incubating feature.

> Task :integrationTest

ProofOfKnolwedgeIntegTest > TestContract() FAILED
    org.opentest4j.AssertionFailedError at ProofOfKnolwedgeIntegTest.java:36

1 test completed, 1 failed

> Task :integrationTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':integrationTest'.
> There were failing tests. See the report at: file:///home/a/IdeaProjects/attestation/build/reports/tests/integrationTest/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 12s
3 actionable tasks: 2 executed, 1 up-to-date

gradle integrationTest and gradle check fails as expected, but gradle build also fails as well for me

gradle integrationTest and gradle check fails as expected, but gradle build also fails as well for me

I mistook check as a higher level task, but it is a lower level task than build hence build covers it.  Now the expected behaviour is:
gradle build should work
gradle integrationTest should fail with the testContract problem.
Make sure to update the code - it is rebased - then test


[node.js] Support running tests in Node in all OSs

Fixes the issue with ERR_UNSUPPORTED_ESM_URL_SCHEME on Windows (reported in the Color.js repo). Now, hTest should work in all major OSs.
We still have some UI glitches because our emojis are not well-supported in different Windows terminals. But I think we can work on it in a different PR.

Thx!


Missing template parameter for user-header in typed C++ API

Required information
Operating system:
all
Compiler version:
all
Observed result or behaviour:
The Publisher and Subscriber alias do not have a default parameter for the user-header which means that PublisherImpl and SubscriberImpl must be used directly.
Expected result or behaviour:
The Publisher and Subscriber alias can be used for the user-header.
Conditions where it occurred / Performed steps:
Try to add a second template argument to the Publisher and Subscriber.

reopen for PR to release_1.0 branch


Drop support for Python 3.4

Python 3.4 reached its EOL on 2019-03-18, see https://www.python.org/dev/peps/pep-0429/#release-schedule
This allows to make full use of PEP 484, see https://docs.python.org/3/whatsnew/3.5.html#pep-484-type-hints

I'm fine with this, but I probably won't merge until we add something that fails with 3.4 and not everything else.

One thing to remove (after adding something that fails with 3.4): collate can be dropped. Python 3.5 supports all the features of that function with heapq.merge.

I'd like to pick up PR erikrose/more-itertools#263, but with inlined type hints.  Since typing was added in Python 3.5, this would fail on Python 3.4. :)


[SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions

What changes were proposed in this pull request?

This PR makes sure that SharedState would be only initiated once across SparkSessions.
Why are the changes needed?

This helps us to fix the listener(e.g., SQLAppStatusListener) leak issue, and allow SparkSessions created by getOrCreate to share the CacheManager,  global temp view, etc.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added UTs.
Close https://github.com/apache/spark/pull/31053

Test build #134299 has started for PR 31268 at commit 9c32d18.

Test build #134299 has started for PR 31268 at commit 9c32d18.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38885/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38885/

Test build #134299 has finished for PR 31268 at commit 9c32d18.

This patch fails from timeout after a configured wait of 500m.
This patch merges cleanly.
This patch adds no public classes.

Test build #134299 has finished for PR 31268 at commit 9c32d18.

This patch fails from timeout after a configured wait of 500m.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134299/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134299/


add pkg-config support (install a ross.pc file)

(for general information about pkg-config see http://www.freedesktop.org/wiki/Software/pkg-config/)
ROSS currently installs a ross-config script that allows other projects to pick up the appropriate library and cflag options.  pkg-config is the more modern mechanism for doing, this though.
A basic ross.pc file would look something like this, and would be installed in ${prefix}/lib/pkgconfig/ross.pc:
Name: ross
Description: Rensselaer's Optimistic Simulation System
Version: 1.0
URL: https://github.com/carothersc/ROSS
Requires:
Libs: -L/some/dir/lib -lROSS -lm
Cflags: -I/some/dir/include
I'm not exactly sure how to generate a file like this with cmake, but there are probably some examples available in other projects?

One quick example of why this would be valuable: if a model depends on multiple libraries, then pkgconfig makes it easier to specify dependencies by setting a PKG_CONFIG_PATH variable at configure time rather than using several explicit --with-somedependency= arguments.

@carns let us know when CODES-base and CODES-net no longer rely on the ross-config file.

We probably need to leave it until we drop another official numbered
codes release, but we can let you know.
On 07/16/2015 09:54 AM, Elsa Gonsiorowski wrote:

@carns https://github.com/carns let us know when CODES-base and
CODES-net no longer rely on the ross-config file.
—
Reply to this email directly or view it on GitHub
https://github.com/carothersc/ROSS/issues/39#issuecomment-121980196.

codes master is now using pkg-config for ROSS.


pageInit on script file not called from page back

Framework7 version: 3.1.1
Platform and Target:Mobile Chrome Browser

This pageInit always called from page back
app = new Framework7({
    on: {
           pageInit: function (page) {
            }
          }
});

But the pageInit in the files not called from page back. It only called on load page
<template>
</template>
<script>
    return {
        on: {
            pageInit: function (e, page) {
           }
       }
}
</script>

Expected behavior
Both pageInit on app or insider files should be called

It is by design, because iOS theme holds previous page in DOM, use pageBeforeIn instead


Add core to STD_DEPS

See #731.

Thanks!
bors r+
I boldly think that we probably can live without a test here: testing with std is slow.


T265 pose precision consultation

Hello, I want to ask about the positioning and direction error of the T265 camera.
good luck

@quxichao , I'm not sure I understand what do you mean by that.
Can you be more specific and elaborate the actual use-case and the concern with the positioning/direction info ?

Accuracy of any SLAM system is always in the order of multiple cm. I have measured T265 error to grow on average to 25cm after 25m motion and to 0.8m after 50-60m. Loop closure would help but it is not working that I know of.

We are always working on ways to improve and build upon the current accuracy of the T265.  Do monitor our releases which comes with target fixes or enhancements for stability and improvements on the algorithm.  There are many different environment features that can go into the performance of the T265 camera.
If there is a specific issue with details of user scenario available please open a new issue.  Thanks.


Using '**' in a GlobPattern does not match any number of path segments in Windows

VSCode Version: 1.30.0 and also 1.31.0-insiders
OS Version: 17763.107

I have tested this issue on both Mac and Windows and have only seen the unexpected behavior in Windows.
I would like to create a FileSystemWatcher to watch all file changes that are a variable number of levels deep inside of a specified directory. To create the globPattern passed to the vscode.workspace.createFileSystemWatcher() method I followed this documentation: https://code.visualstudio.com/docs/extensionAPI/vscode-api#GlobPattern.
On Mac, the globString looks like:
/Users/example.user/Documents/projects/my-vscode-project/{force-app,another-app}/**
On Windows, the globString looks like:
c:\Users\exampleuser\Desktop\my-vscode-project\{force-app,another-app}\**
My example project has a structure like so:
my-vscode-project
|-- force-app
.........|-- example-file-one-level-deep.js
.........|-- main
.................|-- default
.........................|-- example-file-three-levels-deep.js
|-- another-app
........|-- another-example-file-one-level-deep.js
On Mac, changes made to example-file-one-level-deep.js, example-file-three-levels-deep.js, and another-example-file-one-level-deep.js all trigger the fileWatcher.onDidChange() listener, and this is the behavior that I would expect.
On Windows, only changes made to files directly inside of force-app and another-app trigger the fileWatcher.onDidChange() listener. Files nested more than one level deep will not trigger the change listener. In other words, changing example-file-one-level-deep.js and another-example-file-one-level-deep.js will trigger the change listener, but changing example-file-three-levels-deep.js will not.
I am creating the globString and FileSystemWatcher like so:
const packageDirectoryPaths = ['force-app', 'another-app'];
const globString = path.join(
    vscode.workspace!.workspaceFolders![0].uri.fsPath;,
    `{${packageDirectoryPaths.join(',')}}`,
    '**'
);
vscode.workspace.createFileSystemWatcher(globString);

Please let me know if I have misunderstood how to create the correct globString. This behavior is unfortunately blocking https://github.com/forcedotcom/salesforcedx-vscode/pull/822 from moving forward.
Thanks!

@allileong let me guess, you are not getting an event for your file when a delete happens in a parent folder?

@bpasero, what do you mean by 'parent folder'? In the above example, if I delete example-file-one-level-deep.js whose parent folder is force-app, then I am getting an event for the deletion.

@bpasero, this issue seems to be similar in that '**' is not successfully matching on parent directories, but it doesn't seem to be a direct duplicate of those issues since this issue is affecting the file create, change, and delete events alike rather than just delete events.

@bpasero Thank you for the info. RelativePattern with / works for me. I had made incorrect the assumption that I needed to use the backslash for Windows.


Missing API Methods

[ ] Update Product - in case someone wants to enable offline licenses after they initially chose to disable it, or to update the version
[ ] Recover Store - in case someone switches installations of WordPress, they could invoke this method with their signature on it
[ ] Recover product public key - in case someone lost their product's public key
[ ] Get product IDs - in case someone didn't save their product IDs to the database
[ ] Deactivate Machines - in case a user wants to deactivate some machines on their licenses
[ ] Increase Machine Limit

Update: Store recovery will not need to be done on the server side. This can be achieved with a file that store owners can download. It will be a password encrypted file using a Password Based Key Derivation Function (PBKDF) such as argon, and the encrypted file will contain the store ID and the store's private key.


Samples: max17048: updated voltage output and added units

present sample shows no unit in output.
sample shows voltage in mV.
updated sample shows units.
updated ssample shows voltage in uV.
fixes #75492
Signed-off-by: Rahul Goyal<EMAIL_ADDRESS>

@MaureenHelm or @nashif Can we merge this?


Note Editor Config in Readme

Hey great tool.
I plan to use it for publishing some work I'm doing learning Neovim.
Feel free to reject this, but I was confused for a moment when I went to edit a gist. It opened nano as the editor because I had not set my system default.

Thank you!


Prepare 2.13 release

Issue #, if available:
Description of changes:
Preparing 2.13.0 release
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: e18a4f76e644cd078ee70965a8b2722aca833ef0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: e18a4f76e644cd078ee70965a8b2722aca833ef0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 75045614e45e404c9f3455d90cefd3d87cfe0c95
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 75045614e45e404c9f3455d90cefd3d87cfe0c95
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add skeleton UI for the Users table.

UI components are functional but mostly unstyled (screenshot attached). Currently using dummy data; real data is not wired up yet.

Looks great! Merging.


Json to Query(SELECT)

What feature or new tool do you think should be added to DevToys?
Because I manual copy field by field from json to sql query
Why do you think this is needed?
A feature will convert json data to query (SQL,...) in SELECT to I can quick query in DB
Solution/Idea
No response
Comments
No response

Hi,
This is a good idea for an extension, but I don't think it fits DevToys' default tools.
Thanks


Corrected spelling mistakes and some grammatical errors.

Made the verbal part grammatically correct and corrected some misspelled words.

Thank you, @acgoliyan.


Position aware suggestions on intellisense

VSCode Version: 1.4.0
OS Version: 10.11.5

It would be great if the suggestions were related to the location you're typing, for example if in css i do display: the suggestions would be block, inline-block, flex, inline etc. At the moment it seems a free for all.

Thanks and keep up the good work!

Found duplicate here #7273


No seed files matched pattern supabase\seed.sql

Describe the bug
After updating to 1.203.0 I can no longer seed my db with my seed file.
To Reproduce
Steps to reproduce the behavior:

Update the cli to 1.203.0
Run one of the supabase commands that will seed the local db (db reset, start, stop, etc)
See the error in the terminal "No seed files matched pattern: supabase\seed.sql"

Expected behavior
It should use my seed file to seed the db.
Screenshots

sss of the err

but it's there!
System information
Rerun the failing command with --create-ticket flag. <-- this does nothing?

Ticket ID: NA
Version of OS: Windows 11 Home - 23H2
Version of CLI: 1.203.0
Version of Docker: Docker Desktop 4.34.2
Versions of services:

No seed files matched pattern: supabase\seed.sql

       SERVICE IMAGE      │      LOCAL       │   LINKED
 ─────────────────────────┼──────────────────┼─────────────
   supabase/postgres      │ <IP_ADDRESS>       │ <IP_ADDRESS>
   supabase/gotrue        │ v2.162.1         │ v2.162.1
   postgrest/postgrest    │ v12.2.3          │ v12.2.3
   supabase/realtime      │ v2.30.34         │ -
   supabase/storage-api   │ v1.11.7          │ v1.11.7
   supabase/edge-runtime  │ v1.58.11         │ -
   supabase/studio        │ 20240930-16f2b8e │ -
   supabase/postgres-meta │ v0.83.2          │ -
   supabase/logflare      │ 1.4.0            │ -
   supabase/supavisor     │ 1.1.56           │ -

Additional context
I tried setting in my config.toml too, but still no dice.
[db.seed]
enabled = true
sql_paths = ['./seed.sql']

Hi @red2678,
Could you try using the latest beta release channel with the following command and let me know if it resolves your issue?
npx supabase@beta db restart

We've included a potential fix in the v1.204.1 release.

Yes sir, that did work! To note, I'm sure you meant reset.

Closing as this has been resolved in v1.204.1

I am currently experiencing the same issue as mentioned by @red2678 above .
I have had no issues seeding Locally up until today, and now I am continually getting the message:
No seed files matched pattern: supabase\seed.sql
Despite having a seed.sql file within my projects /supabase directory that was generate via the CLI using my usual go to:
supabase db dump -f supabase/seed.sql --data-only
What I have tried:

Updating Supabase CLI to latest using Scoop (I am now running v1.203.0), the issue persists
Setting explicit seed paths in the config.toml, the issue persists
And now after finding this thread I have tried using npx supabase@beta db reset, and the same issue persists

System information
I also tried creating a ticket using --create-ticket flag. To no avail.
Ticket ID: NA
Version of OS: Windows 10 Home - 22H2
Version of CLI: 1.203.0
Version of Docker: Docker Desktop 4.34.3

I am currently experiencing the same issue as mentioned by @red2678 above .
I have had no issues seeding Locally up until today, and now I am continually getting the message:
No seed files matched pattern: supabase\seed.sql
Despite having a seed.sql file within my projects /supabase directory that was generate via the CLI using my usual go to:
supabase db dump -f supabase/seed.sql --data-only
What I have tried:

Updating Supabase CLI to latest using Scoop (I am now running v1.203.0), the issue persists
Setting explicit seed path, e.g. sql_paths = ['./seed.sql'] in the config.toml, the issue persists.
And now after finding this thread I have tried using npx supabase@beta db reset, and the same issue persists

System information
I also tried creating a ticket using --create-ticket flag. To no avail.
Ticket ID: NA
Version of OS: Windows 10 Home - 22H2
Version of CLI: 1.203.0
Version of Docker: Docker Desktop 4.34.3

Hey @brishan3,
We’ve just released CLI version 1.204.3, and I recommend upgrading to see if that resolves the issue.
If the problem continues, it would be really helpful to get more information about your project’s file structure. For example, are you working in a monorepo with multiple Supabase projects, or is there anything unique about your setup?
This will help us better understand and reproduce the issue on our end. Let us know how it goes!

Thanks for your response, @avallete!
Moments ago I resolved my issue by updating the Supabase CLI.
I noticed that after I ran npx supabase@beta db reset, the message "A new version of Supabase CLI is available: v1.204.3 (currently installed v1.203.0)" was printed out.
My issue was resolved after running npm update supabase -g

Quick note regarding the release: it's been about 6 hours since the release went out, so I see the "new release available" message in the CLI, but when I try to update with scoop it still thinks the newest version is 1.203.0:

Just flagging in case this delay isn't normal. Let me know if I should file a separate issue.

To answer my own question, it looks like I just have to sit around and wait for Scoop's update bot to get around to it: https://github.com/ScoopInstaller/Main/commits?author=github-actions[bot]


Remove dependencies from procfs and sysfs onto xfs, nfs, bcache, and iostats

Make the xfs and nfs packages dependent on procfs
instead of the procfs package dependent on xfs and nfs.
This allows clients to depend on procfs without bringing
in xfs and nfs.
This is a possibility for option 1 of issue #135

From a quick look, it looks ok to me.

@juliusv @beorn7 Would you please review this refactoring?

I'm not familiar with this code. Wouldn't @grobie be the most natural reviewer?

@grobie isn't maintaining this much anymore. We're currently working on finding a new owner.

Understood. Currently, I cannot volunteer as a new maintainer for lack of time.
For the time being, I would still prefer if @grobie could have a look here. I guess his lack of time is as bad as mine, but he would need less time to review this as he already knows the code.

@grobie Can you just let us know if you will be reviewing this? I know you wanted to propose doing exactly this IIRC, so naturally you'd be the best person to review this.
If you don't have time, no worries. I'll just do my best to review :)

I'll give it a look tonight or tomorrow night. Thanks for mentioning.
On Sun, Mar 17, 2019, 10:19 discordianfish<EMAIL_ADDRESS>wrote:

@grobie https://github.com/grobie Can you just let us know if you will
be reviewing this? I know you wanted to propose doing exactly this IIRC, so
naturally you'd be the best person to review this.
If you don't have time, no worries. I'll just do my best to review :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/procfs/pull/136#issuecomment-473647549,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAANaPpTbKWGv2OmbUyprkGOpXynpSQoks5vXgi6gaJpZM4bFrqx
.

Rebased to get circleci build config changes.

I left a few minor comments, but don't have bigger concerns. Do you plan to adjust the functions in procfs accordingly so that all functions have a similar signature?

@grobie Yes, I think it would be good to completely remove the FS type and associated functions and adjust the remaining functions in procfs and sysfs.  I think this would work well in the typical usage in node_exporter since each collector creates its own FS and does it's own file system checks, etc.


Unable to capture the full screenshot in desktop view for the website https://www.amazon.jobs/ by using PuppeteerSharp

We are using the below source code to capture the full screenshot in desktop view, but the footer is missing, Also you can see the output screenshot.
Source Code:
using var browserFetcher = new BrowserFetcher();
await browserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision);
var browser = await Puppeteer.LaunchAsync(new LaunchOptions
{
Headless = true,
DefaultViewport = new ViewPortOptions { Width = 1900, Height = 2000 }
});
var page = await browser.NewPageAsync();
await page.GoToAsync(siteUrl, new NavigationOptions { Timeout = 100000 });
await page.EvaluateExpressionAsync("window.scrollTo(0, document.body.scrollHeight)");
await page.WaitForTimeoutAsync(4000);
await page.EvaluateExpressionAsync("window.scrollTo(0, 0)");
await page.WaitForTimeoutAsync(2000);
await page.ScreenshotAsync(imageSavePath, new ScreenshotOptions { FullPage = true });

Please reply as soon as...kindly help us to sort this issue.

Did you try with Headless in false?

Thanks for the reply.
Yes, I have checked with the Headless = false and removed the default DefaultViewport option also but the result is the same.
Also, we are facing an issue while capturing the site (https://eatfoodwithpurpose.com/). below is the attached screenshot of both mobile and desktop view (incomplete captured screenshots). Please suggest something to resolve this issue.
var browser = await Puppeteer.LaunchAsync(new LaunchOptions
{
Headless = false
});
var page = await browser.NewPageAsync();
using var browserFetcher = new BrowserFetcher();
await browserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision);
await page.GoToAsync("https://www.amazon.jobs/", new NavigationOptions { Timeout = 100000 });
await page.EvaluateExpressionAsync("window.scrollTo(0, document.body.scrollHeight)");
await page.WaitForTimeoutAsync(4000);
await page.EvaluateExpressionAsync("window.scrollTo(0, 0)");
await page.WaitForTimeoutAsync(2000);
await page.ScreenshotAsync(""CapturedImage.png"", new ScreenshotOptions { FullPage = true });
[Ist Screenshot: https://www.amazon.jobs/]

[2nd Screenshot : https://eatfoodwithpurpose.com/]
(Mobile View)

(Desktop View)


Clarify LWJGL2 Compatibility with JDK17+ in Documentation

OS: Linux
gdx-liftoff version: <IP_ADDRESS>
Steps I used to reproduce:

Create a project with template Game.
Tick legacy desktop as a platform (I kept lwjgl3 too)
Try running the project with lwjgl2->application->run in intelliJ.

It says the run was successful but in reality the application didn't show up and I had this log:
Executing 'run'...

> Task :core:compileJava UP-TO-DATE
> Task :core:processResources NO-SOURCE
> Task :core:classes UP-TO-DATE
> Task :core:jar UP-TO-DATE
> Task :lwjgl2:compileJava UP-TO-DATE
> Task :lwjgl2:processResources UP-TO-DATE
> Task :lwjgl2:classes UP-TO-DATE

> Task :lwjgl2:run

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.6/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 884ms
5 actionable tasks: 1 executed, 4 up-to-date
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.lwjgl.LWJGLUtil$3 (file:[redacted]/.gradle/caches/modules-2/files-2.1/org.lwjgl.lwjgl/lwjgl/2.9.3/3df168ac74e4a8c96562cdff24ad352e255bf89c/lwjgl-2.9.3.jar) to method java.lang.ClassLoader.findLibrary(java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.lwjgl.LWJGLUtil$3
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Inconsistency detected by ld.so: dl-lookup.c: 106: check_match: Assertion `version->filename == NULL || ! _dl_name_match_p (version->filename, map)' failed!
Execution finished 'run'.

openjdk-17 doesn't work for running LWJGL2. You can stick with openjdk-8, or you may have better luck with other Java distributions. LWJGL2 is not maintained (last release 9 years ago) so this will not be fixed.

Might be easiest to ask the user if they know what they're doing, if selecting that option, as issues with the LWJGL2 backend extend far beyond this. In a way, this specific issue is a niche one - the number of people who will want to use the obsolete and abandoned backend is minimal, and the subset of those users who are on Linux with the JRE from their distro-provided repositories is even smaller.

Yeah, this isn't really a Liftoff issue, it's an issue with specific vendors of OpenJDK (on Linux or maybe MacOS only) not interoperating with the dilapidated LWJGL2 code. I'm also pretty sure that LWJGL2 is broken on distro-provided JDKs for versions earlier than 17, though I don't know how early. I think Adoptium should work. I don't have a Linux machine to test on right now.


Camel 4.7 - Reflection in jms and sql component

Describe the feature here
https://github.com/apache/camel/blob/main/components/camel-jms/src/main/java/org/apache/camel/component/jms/JmsServiceLocationHelper.java
https://github.com/apache/camel/blob/main/components/camel-sql/src/main/java/org/apache/camel/component/sql/SqlServiceLocationHelper.java

@davsclaus How about if ActiveMQConnectionFactory is wrapped by such JMSPoolConnectionFactory provided by quarkus-pooled-jms ?

@davsclaus How about if ActiveMQConnectionFactory is wrapped by such JMSPoolConnectionFactory provided by quarkus-pooled-jms ?

We should not use runtime specific dependency where possible.

OK, so for camel-jms we could only add jakarta.jms.ConnectionFactory to the reflection configuration in native mode. And for camel-sql adding javax.sql.DataSource?
Then if using with quarkus-pooled-jms, there might be an issue to get brokerUrl?

Ah, maybe we can consider to add ActiveMQConnectionFactory reflection configuration in quarkus-artemis extension?

Ah, maybe we can consider to add ActiveMQConnectionFactory reflection configuration in quarkus-artemis extension?

Can we not just use Jandex and discover all impls of ConnectionFactory & DataSource?

@jamesnetherton well, it looks like quarkus-artemis-jms has not included jandex yet.

I don't think this can work OOTB. The problem is that the ConnectionFactory and DataSource are synthetic ClientProxy beans. When you do reflection on them, the methods that get returned are those of the generated proxy and not the actual target type.
We could maybe investigate doing ClientProxy.unwrap before beans get returned from RuntimeBeanRepository.

Hi @davsclaus what version of camel jbang should be used? I run with 4.7 but there is no --address
JBang version: 0.117.1
Camel JBang version: 4.7.0

Unknown option: '--address'
Usage: camel get endpoint [-h] [--short-uri] [--watch] [--wide-uri]
                          [--filter=<filter>]
                          [--filter-direction=<filterDirection>]
                          [--filter-total=<filterTotal>] [--limit=<limit>]
                          [--sort=<sort>] [<name>]
Get usage of Camel endpoints
      [<name>]            Name or pid of running Camel integration
  -h, --help              Display the help and sub-commands
      --watch             Execute periodically and showing output fullscreen
      --sort=<sort>       Sort by pid, name, age or total
      --limit=<limit>     Filter endpoints by limiting to the given number of
                            rows
      --filter=<filter>   Filter endpoints by URI
      --filter-direction=<filterDirection>
                          Filter by direction (in or out)
      --filter-total=<filterTotal>
                          Filter endpoints that must be higher than the given
                            usage
      --short-uri         List endpoint URI without query parameters (short)
      --wide-uri          List endpoint URI in full details

I think we renamed it to camel get service There is a --metadata option that shows more data

OK, I run camel get endpoint to get
 PID   NAME     AGE   DIR  TOTAL  STUB  REMOTE  URI
 44995  camel-1  1h2m                      x     jms://test

but camel get service return empty result even with --metadata

the blog shows how it should look
https://camel.apache.org/blog/2024/07/camel47-whatsnew/

try this example in jbang
https://github.com/apache/camel-kamelets-examples/tree/main/jbang/camel-1.0

Thanks a lot @davsclaus !

Run in a plain camel with camel run MyRouteBuilder.java, the camel get service returns

PID   NAME            COMPONENT  DIR  PROTOCOL  SERVICE                           TOTAL  ID      ENDPOINT
62506  MyRouteBuilder  activemq   in   jms       failover://tcp://localhost:61616      0  route1  activemq://test.MyQueue

Run in quarkus runtime with camel run MyRouteBuilder.java --runtime=quarkus --quarkus-version=3.13.0 --dep=io.quarkiverse.artemis:quarkus-artemis-jms:3.4.0, it returns

  PID   NAME     COMPONENT  DIR  PROTOCOL  SERVICE                           TOTAL  ID      ENDPOINT
 62942  camel-1  activemq   in   jms       failover://tcp://localhost:61616      0  route1  activemq://test.MyQueue
 62942  camel-1  activemq   out  jms       failover://tcp://localhost:61616      0          activemq://test.MyQueue

Hmm, why there is another one?

Is there any way to run in a quarkus native mode?

there are 2 because they are IN and OUT

In native I guess you need to add something to that build time graal thingy as it uses reflection to get the data

there are 2 because they are IN and OUT
But why does it appear in quarkus runtime, in plain camel there is only one of IN?

In native I guess you need to add something to that build time graal thingy as it uses reflection to get the data

I see and is there any option with camel run to build it in native?

export to quarkus and run the quarkus native build via maven

@davsclaus I'm still confuse why running with the same Java file, there is a different output of camel get service between the plain camel and quarkus runtime?

@davsclaus if setting camel.main.endpoint-runtime-statistics-enabled=true, there will be only one IN result with camel get service when running with quarkus.
I found the following codes which might be related
https://github.com/apache/camel/blob/main/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultEndpointServiceRegistry.java#L93-L99
So @jamesnetherton does it make sense to default enable endpoint-runtime-statistics in camel-quarkus-cli-connector ?
Also I create https://issues.apache.org/jira/browse/CAMEL-21163
For native support, it looks like even camel-quarkus-cli-connector is only JVM support right now. So not sure if we can get it working in native.

you see all this extra stats in camel-jbang as it runs camel in dev mode that turn on various stuff. For production mode, then its expected to not see these information from this CLI.
Its a CLI for development / troubleshooting etc.
See ProfileConfigurer in camel-main

So maybe what quarkus need is that if you use mvn quarkus:dev then it runs in developer mode, and set this on camel
camelContext.getCamelContextExtension().setProfile("dev");

So maybe what quarkus need is that if you use mvn quarkus:dev then it runs in developer mode

Which unfortunately is broken until we get Camel 4.8.0. https://github.com/apache/camel-quarkus/issues/6083.

Ha, thanks @jamesnetherton and I will check it again when 4.8.0 is out.

@davsclaus

you see all this extra stats in camel-jbang as it runs camel in dev mode that turn on various stuff. For production mode, then its expected to not see these information from this CLI.

Its a CLI for development / troubleshooting etc.

IIUC, only when I uses camel run MyRouteBuilder.java --dev, these extra stats can be returned by camel get service?
If I run in production like camel run MyRouteBuilder.java --profile=prod, them should not be listed. Is it right?
But I test with --profile=prod, them are still be listed.

its only when you have those extra stats you can know for sure if its only IN or OUT - if no stats then you just have both.


Add Node.js library API

I added a way for Node.js project to import the project as a library and apply the optimizations, this will be useful for running these optimizations in elm-review.
You can review the changes commit by commit, but here are the highlights (not in the order of commits):

Split index.js into

bin.js which defines the program and handles the CLI part (and changed bin/elm-optimize-level-2.js to import this file).
index.js which is the main file for the library part
run.js which has the optimization-applyinh logic, and which is called from the previous 2 files.

Added a lot more arguments to run, so that we can inject CLI or library-dependent behavior, and the wanted options from the CLI user or library user.
Made run return the path to the output file
Replaced process.exits and console.error by JS exceptions
Replaced console.log calls by calls of an injectable function, in order for them not to appear in the library use
Made program exit with an error for a lot of the already existing error cases
Made it so that by default only the exception's error message is displayed, but added a verbose flag to show stack traces and enable verbose mode of the compiler (maybe this wasn't needed in retrospect).

Notes:

I added some of the same options as for node-elm-compiler. There are more to add, and from my testing, I don't even need some of these for elm-review, since I went for the "use elm-optimize-level-2 on a JS file, not an Elm file" for now.
I haven't worked on making the commented benchmark work again. They probably need a bit of updating.

Let me know what you think. I hope I didn't break anything, tests are already broken in master.

Looks great! Thanks!
Yeah, the benchmark code is a little tough right now as I'm not totally sure how to include it without including a dep on selenium webdriver.


Consider to remove '.decode('utf-8')?

python3.10/site-packages/pytarql/pytarql.py", line 178, in emit
format=self._args.output_format).decode('utf-8')
AttributeError: 'str' object has no attribute 'decode'. Did you mean: 'encode'?

Changing this to encode 'works', but then another problem pops up
File "C:\Users\camer\AppData\Local\Programs\Python\Python311\Lib\site-packages\pytarql\pytarql.py", line 184, in emit
output.write(serialized.strip())
TypeError: write() argument must be str, not bytes

I just removed the decode function and used the serialized data. It worked.
 serialized = self._graph.serialize(format=self._args.output_format)


"First frame problem".

There is a common problem with async rendering: due to async data arrival and async switching to ui thread you're effectively skipping first frame.
In many cases it's not really a problem because it's very hard to notice one frame without data, especially if default layout state already displays something.
However in some cases like very different default state of the layout compared to the state with data (ie whole content is invisible by default, etc) it can be noticeable.
This GitHub issue tracks possible solutions and general discussion of this problem.
cc @alexjlockwood @kxfang
Also related to RxAndroid https://github.com/ReactiveX/RxAndroid/pull/228

Right now Domic renders everything by posting to Choreographer at constant time intervals.
Changes posted to Domic's DOM do skip current frame and are rendered on the next frame which is not a problem in general since data arrives asynchronously in the first place but it falls into "First frame problem" case.
Possible solution:
Expose an API to force rendering of the current buffer ie Renderer.renderCurrentBuffer() (naming is not final).
Default Renderer implementation, AndroidRenderer will render current buffer synchronously if renderCurrentBuffer() was called on main thread (throw exception if called on non main thread?).
Call to this method can be integrated into userland code or frameworks like Scoop, Fragments, Activity, etc to render current buffer when first lifecycle method finishes thus giving user a way to solve "First frame problem"
ie:
class MyActivity : Activity {

    override fun onCreate(…) {
        setContentView(R.layout.myactivity)

        // Bind Domic, push some changes to render.

        renderer.renderCurrentBuffer()
    }

}

We could do some heuristics inside Domic to make it automatic, but that doesn't look scalable and flexible enough to be able to integrate with different frameworks like Scoop.

Please note that lots of apps already skip first frame due to observeOn(mainThread) applied everywhere before interaction with the view layer which posts to Handler thus skipping current frame
See also:

https://github.com/JakeWharton/RxBinding/issues/28
https://github.com/ReactiveX/RxAndroid/pull/228
https://github.com/ReactiveX/RxAndroid/pull/416

Solving this problem is not the goal of Domic's existence, but looks like we can do something about it in more controllable way than RxAndroid or RxBinding can since we have rendering pipeline with buffering.

I'm not sure that something like renderer.renderCurrentBuffer() will work. Given your data sources are asynchronous and emitting from different threads, you might just not have all the data needed to render in Activity's onCreate.
So first of all, data sources have to have a cached data and emit it synchronously on subscription, but I suppose that kinda contradicts to Domic's idea.

@Dimezis we obviously can't solve async data problem in Domic on general sense, that's not a goal and as you noted Domic is actually async-only by design
However, often times even in async systems data is cached in memory and is effectively accessed synchronously! Unless there are enforced thread jumps.
For example just yesterday @kxfang measured that about 66% of data in golden path of our app comes from memory but due to observeOn(mainThread) we're still skipping first frame.
I linked issues from other Rx projects because it's a known problem in async/reactive systems and there are cases when, yes, you're writing async code but it actually gets synchronously executed.
This API won't solve problem of async data arrival but it'll help get the first frame  for data cached in memory which is not bad right :)
We won't be promoting it as "The Solution" but rather like "We did what we could on our side and gave you the tools, now it's up to you :)"


[DDW-155] Persist "Blank screen fix" / "--safe-mode" flag between Daedalus restarts

This PR depends on https://github.com/input-output-hk/cardano-shell/pull/361.

Testing Checklist

Slack QA thread
[ ] Test if "Blank screen fix" option persists between Daedalus restarts

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DmitriiGaico merging this one without QA confirmation since it is not platform specific and I have confirmed it is working on macOS...


Simplified joystickd.py, added clarity and sources

Simplified if statement for gamepad
Added link to Linux gamepad documentation
Added some example gamepad definitions
Tested self.cancel_button using Xbox One controller and nothing happens

Tested multiple gamepad buttons from Xbox One controller mapped to self.cancel_button, but none had any effect.

Closing as it's not clear what the goal of this PR is. See the contributing guidelines: https://github.com/commaai/openpilot/blob/master/docs/CONTRIBUTING.md.

@adeebshihadeh the main goal of my PR was refactoring and simplifying the code and comments.


Account for duplicate file sizes and speed up channel list page loading

@jayoshih Could you give me some steps on how to test this?

@jonboiser If you upload a file multiple times, does it add the file size multiple times under the following locations?
File uploader:

Publish Modal:

Import:

Ok, tested it out on both modals, and it looks good.