Monitoring - Cluster custom user can enable/disable monitoring on cluster level

Bug.
Rancher master on 12/5
Steps:

logged in as admin to add a standard user to a cluster as a cluster custom user with only permission to view node
logged in as the cluster custom user, go to the cluster -> Tools-> Monitoring

Result:
The cluster custom user can see settings and turn on the monitoring.
Expected result:
The cluster custom user should not be able to turn on the monitoring.
Other details might be helpful:
If the monitoring is already enabled by the admin/cluster owner, then the cluster custom user will see the following uncompleted sentences:

Does not need to be fixed for alpha

Cluster   owner can enable/disable monitoring on cluster level
Cluster member   cannot enable/disable monitoring on cluster level
Cluster custom   member cannot enable/disab;e monitoring on cluster level
Project owner   cannot enable/disable monitoring on cluster level
project member   cannot enable/disable monitoring on cluster level
project custom   member cannot enable/disable monitoring on cluster level
project   read-only member cannot enable/disable monitoring on cluster level

@thxCode

The bug also exists on HA setup.

The bug fix is validated on master 1/4
Steps:

logged in as admin to add a standard user to a cluster as a cluster custom user with only permission to view node
logged in as the cluster custom user, go to the cluster -> Tools-> Monitoring

Result:
The cluster custom user cannot turn on/off the monitoring.
Also validate all following cases mentioned in this comment:

Cluster   owner can enable/disable monitoring on cluster level
Cluster member   cannot enable/disable monitoring on cluster level
Cluster custom   member cannot enable/disab;e monitoring on cluster level
Project owner   cannot enable/disable monitoring on cluster level
project member   cannot enable/disable monitoring on cluster level
project custom   member cannot enable/disable monitoring on cluster level
project   read-only member cannot enable/disable monitoring on cluster level

Reopen the ticket because it turns out the cluster owner cannot enable/disable monitoring on the cluster level.
@thxCode @loganhz  Should the cluster owner who is NOT admin be able to turn on/off the cluster-level monitoring?

Hi @jiaqiluo  I didn't reproduce this issue in rancher/rancher:master 04/01

Create a standard user
Assign the user to a cluster with cluster owner role
Login as the created user
Enable/Disable monitoring

Did I miss something?


Pressing enter in combobox is unintuitive

Describe the bug
When pressing enter in a combobox, my expectation would be that the first item from the filtered results is selected. There also isn't an easy way to handle the "Enter" key event. I can capture it on the Combobox.Input component with on:keydown however it seems to fight whatever logic is going on behind the scenes.
The Combobox.Root component has handlers for things like onOutsideClick, so I'm wondering if we create a handler for onEnterPressed to let the developer handle this implementation as to not assume Enter == select.
Reproduction
https://stackblitz.com/edit/github-95qa4o?file=src%2Froutes%2F%2Bpage.svelte
Logs
No response
System Info
System:
    OS: Linux 6.1 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD EPYC 7B13
    Memory: 43.13 GB / 62.79 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.11.1/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 8.15.4 - ~/.nvm/versions/node/v20.11.1/bin/pnpm
    bun: 1.0.31 - ~/.bun/bin/bun

Severity
annoyance

Closing as fixed in bits-ui@next


Speed improvements on repos that have nothing to build

This improves performance by 20% when building repositories that haven't changed since last build.

something is wrong, it started to copy files from source to build dir while nothing had to be built

It copied png files, so it means the action was not the right one (we expect conversion to webp or crn), so something is wrong in file profile parsing.

I get no sensible speedup with the repository config file optimization.

I merged the first commit.

The other proposed solutions may not work reliably because of race conditions.
Anyway, I did the deep rewrote I wanted to do for years to fix the issues addressed here.
It's still not possible to get a return in less than a second, but time was divided by 2 or 3.
Also most of the time was spent in git calls to compute versions.


Fix #294: Handle global commandline args

So they appear in asv $COMMAND --help

argparse seems to be clumsy here. Note that asv --config=foo run
becomes disallowed here. There doesn't seem to be a way to allow both
places; the parent parser trick mentioned on some web pages is somewhat
wrong, doesn't work for action='store_true'. Other pages suggest not
add_subparsers at all, but that seems also clumsy.
.
The other option would be not fighting against argparse, including asv --help output on the documentation page, and using "add_parser('run',
prog='asv [global options] run', ...)" to indicate to the user that
there are some global options...
.
This change breaks some of my scripts, because asv --config=foo run
becomes disallowed. Not a big deal in itself, though.

There's a way to do it, actually: https://github.com/pv/asv/tree/pr-295
as copied from https://bugs.python.org/issue24251
(Note that travis didn't run for 746c0bd --- there's also a missing import).


Fix crash with switch expression as a lambda body

Fixes #524
Fixed by bumping Checker Framework version

Pull Request Test Coverage Report for Build #682

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.672%

Totals

Change from base Build #681:
0.0%

Covered Lines:
4107

Relevant Lines:
4580

💛  - Coveralls


Add more missing unit tests

Working on that coverage %. Hustle to 💯
Seriously tho, nearly maxed the coverage that is realistic. I think we need to spend some time on the grid layout tho, there are parts untested that also are unnecessary. I should file a 3.0.0 issue to track work on that.
Waiting for CI ✅

Coverage increased (+0.5%) to 97.964% when pulling e9811780d86bc5674c1a2b0e91e51de003c74d11 on updater-tests into 626d26839bc9238325794a40c057a82400145326 on master.

Coverage increased (+0.5%) to 97.964% when pulling e9811780d86bc5674c1a2b0e91e51de003c74d11 on updater-tests into 626d26839bc9238325794a40c057a82400145326 on master.

UI test failure again on iOS 10.1


What's up with the extra newline after return/yield/etc?

It seems very idiosyncratic – are there any existing style guides that do this? I think of vertical whitespace as a separator, not a way of emphasizing the previous line. Why do you put the emphasis line after the control statement, instead of before it? Why do these statements in particular need extra emphasis? If they do, then wouldn't it be better to configure your syntax highlighter to wrap them in <b><blink>...</blink></b> or something? Should we ask Guido to rename the tokens to RETURN and YIELD to make sure no-one misses them? (Presumably during the transition period we'd have to do from __future__ import SHOUTY_TOKENS, but black could insert that for us.)
Of course all style guidelines are idiosyncratic and part of the reward for spending lots of time working on a tool like black is to make sure that it's your idiosyncratic preferences that everyone ends up using, so feel free to ignore this. But I figured I'd at least open an issue so people can click the little emoji buttons before it gets closed as WONTFIX.

If return is your last statement in a function, it already receives an extra empty line or two because of function separation.
If you escape early from a function or loop, this is easier to miss. This extra newline helps the reader to consider the change in flow. You're right that you can think of it as a separator from what comes after. After all, you shouldn't just keep reading as if it was still the same block.
Do those extra lines prevent you from doing something you could do otherwise?

Okay, here's the promised examples.
 For example, in both of these cases, you're seeing the whole function:
     async def wait_socket_readable(sock):
         if type(sock) != _stdlib_socket.socket:
             raise TypeError("need a socket")
+
         await wait_readable(sock)

    def capture(sync_fn, *args):
         try:
             return Value(sync_fn(*args))
+
         except BaseException as exc:
             return Error(exc)

In other cases, we have some genuinely complicated functions, like trio.run. The whole function body is too long to paste here, but you can see it here. If you follow that link, you'll see it already uses blank lines to divide the body into 4 logical sections: (1) pytest's magic __tracebackhide__ declaration, (2) error checking, (3) interpreting arguments and setting up global state, (4) a chunk of complicated error handling logic with nested try and with blocks wrapped around the actual work (and then the work itself is factored out into a separate function). And in that last part, black inserts a number of newlines:
    try:
        with ki_manager(
            runner.deliver_ki, restrict_keyboard_interrupt_to_checkpoints
        ):
            try:
                with closing(runner):
                    # The main reason this is split off into its own function
                    # is just to get rid of this extra indentation.
                    result = run_impl(runner, async_fn, args)
            except TrioInternalError:
                raise
+
            except BaseException as exc:
                raise TrioInternalError(
                    "internal error in trio - please file a bug!"
                ) from exc
+
            finally:
                GLOBAL_RUN_CONTEXT.__dict__.clear()
            return result.unwrap()
+
    finally:

This really doesn't make sense to me to read, like -- how can you have a "logical section" break in between two except clauses? Or between the contents of a try and the contents of its finally? For the existing logical sections I could easily describe their high-level purpose, but I can't do that for these at all.
Anyway, I know this is hair-splitting, hence the silly first message (I hope it came across as silly rather than whiney!). But it's genuinely unclear to me when this behavior would ever improve code – maybe you're used to working on codebases with over-complicated control flow that should be factored into multiple functions? :stuck_out_tongue_winking_eye: If black didn't respect manual newlines, then it would at least feel coherent: it's taking full control over the vertical layout, and making the best guesses it can. But after e911c79809c4fd9b0773dea5b6a0e710b59614cf it feels inconsistent that black is sometimes trying to control section breaks inside functions, and sometimes letting the user control it.

how can you have a "logical section" break in between two except clauses?

Looking at the standard library, less than 1/3 of except: clauses have raise or return within. So in a majority of cases we don't break the flow when handling exceptions. An additional empty line showing that within a given block you do exit early helps differentiate between the two cases.
You asked why I put the empty lines after control flow statements. I do this because they break flow, so it seems natural to me they should also break visual flow of a function or loop. Why do I find it helpful? In code review I did over the last decade, I find that in changes that people make to code they didn't write (or don't remember), they surprisingly often make wrong assumptions about control flow. Or if they don't, the reviewers do. Combine this with insufficient testing and you get bad changes landing in the central repository.
And I don't think you actually disagree with this. Where I see the core of our difference in opinion is that you believe in forming strict "blocks" of code using empty lines which disallows any other vertical whitespace. Funnily enough, I personally have an even stricter opinion on this: "sections" within functions are a smell. I said this much in the comment you referred to. In it, I also mentioned that if you really need sections, placing standalone comments that describe what those sections represent is the way to go. In this situation, it's the comments that form the "block", not the empty line alone.
I agree with you that this was a message better sent when Black used to totally remove vertical whitespace from function bodies. But as expressed by others #19 (and quite a few conversations I had elsewhere), this is unpopular in the community and would seriously hurt the adoption of Black.
On the other hand, I didn't get anybody else to object against making control flow statements prominent. I will need to gather more feedback. So far I'm pretty strongly in the "it's worth it" camp.

PS. If you want to see a pathological example of this style, look no further than in Black's own whitespace function. This is the part of the codebase I'm least proud of and will definitely refactor once the bigger rocks are dealt with. I actually like that the style highlights how ugly this function is. After all, it has a ridiculous cyclomatic complexity of over 70. Linus Torvalds would say it's in poor taste and I don't disagree.

I figured out a shorter way to express my position here :-). It is:
Blank lines inside a function are effectively a kind of extra-terse comment. Comments are really tricky for a code formatter to handle, but they're crucial, because they're a way for developers to express intent and increase readability. Black shouldn't be in the business of adding or removing comments.

You win, @njsmith. Thanks for taking the time to clearly express your opinion.
FWIW, I still recommend making flow control statements prominent but I decided it's not worth alienating Black users over it.


Apply DeploymentController in OS template

@sabre1041 notes that he prefers using a DeploymentController to a ReplicationController in the OS template:
"it aligns with the OpenShift model as well as making the majority of the environment variables in the container as template parameters in case they would need to be overridden"
Let's make the switch.  Non-critical I believe as things seem to be working as-is, but we aim for best practices here in Developer Programs. :)

@ALRubinger Small correction as it should be a DeploymentConfig vs ReplicationController. A deploymentconfig will actually create a replicationcontroller which in turn will manage the lifecycle of pods for the particular deployment. I ran into issues during adb testing since both API objects are currently present in the template

@sabre1041 Feel free to edit the issue description as needed; you got the plan here!

a411672


[Task] Add all functionallity from Contract to Account

Background
NEAR API JS has a similar interface for Contracts, which users tend to find confusing and hard to extend. Based on our experience in support, users understand better how to generalize to multiple contracts:
Account.function_call(contract_id, method)

than:
Contract.function_call(method)

For this exact reason is that we changed our docs in the past to stop using the Contract object, and simply show how to instantiate an Account and use it
After this, we stop getting questions about how to easily communicate with multiple contracts.
User Story

[ ] As a user, I want to use my account to interact with multiple contracts, without having to instantiate multiple objects

Acceptance Criteria
The Account object can do all the actions that an account can:

[ ] account.deploy()
[ ] account.call_function()
[ ] account.delete()
[ ] ...

Resources & Additional Notes
No response

Hey, thanks for creating this issue. You raise a good point worth considering. However, I tend to favor separating account management (e.g., NEAR, keys, etc.) from contract interaction. Even though it's a single entity, it seems logical to distinguish between the two.
I agree that we could add the function call at the account level, but it wouldn't be very helpful in this case. The account doesn't hold anything that would simplify the process. Signing is abstracted and performed a bit later.

As a member of the Developer Relations team, I would kindly ask you to consider adding the ability to call functions and deploy contracts directly from the Account object
My feedback comes from giving support to the community, seeing how they use our APIs, and the common errors that many of them encounter

This API is informed by near.cli.rs design and I have never heard anyone complaining about the “contract” vs “account” menus.
Contract object in near-api-js was terrible since it required a signer account upfront, even though it doesn’t need it for view-function calls and many other cases. Also, it had magical methods automatically generated that were hard to discover.
@gagdiez I am reluctant to overload Account object with more methods as that will create “too many options to choose from” problem. “Contract” follows the “function_call” pattern you mentioned, so the only difference is that you like it under Account name. Let’s ask real users of the library what they think

Yeah, I don't mind to have that. We might just wrap contract invocation in Account.
Will keep Contract though

@frol I would prefer if we follow the way workspaces-rs works, which better reflects real world interactions: you task accounts with calling functions in contracts
Specially if you need to interact with multiple contracts, with the current implementation you are forced to instantiate multiple contracts, when the important actions come from the account
The current logic to deploy a contract is weird as well, you instantiate a contract and then deploy on it. Feels more natural to create an account, deploy a contract in it, and then use any account to interact with it
But I agree, let's ask the community for feedback here

I'll close this PR until we have a clearer idea on how to make near-api-js and near-api-rs more homogeneous

As I am relatively new user of the NEAR tools I am aware that near-workspaces-rs API is sincere intuitive one. Its quite obviously to have an Accountobject that has ability to deploy and iteract with contract. Regarding the view methods, it seems we need to have option to call it without a signature and might make sense to keep aContractobject but design anAccount` as the top layout


Avoid unneeded zero initialization

CI seems broken, perhaps because of the migration from travis-ci.org to travis-ci.com.

CI finished after two hours but failed due to #43.


Review 3: UserSettings.jsx and CustomLineChart.jsx

Overview
Please pay attention too:

Javascript issues
React components

Review Branch
review-3
Files to review

UserSettings.jsx
CustomLineChart.jsx

Checklists

Architecture
Design
JS
React

Due date
Monday, 9/30/2024
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

UserSettings.jsx:
Design-05: The comments on lines 26 and 46 can probably be removed as they serve no purpose.
Design-07: The code from lines 25-55 and lines 60-77 could maybe be spaced out for readability.
React-01: Lines 11-21 could possibly be made into a subcomponent.

CustomChartLine.jsx:
Design-01: The stylization from lines 53-57 for LineChart could be made into a CSS class.
The type and stroke from lines 65 and 66 could also be made into a CSS class if possible.

UserSettings.jsx
DESIGN-05: L:35 comment disables an eslint check on the following line, which is bad practice.
DESIGN-07: Parameters of submit function (L:27) should be commented on to describe them.
CustomLineChart.jsx
DESIGN-01: Refactor styling into a CSS class or id (L52-59) and (L65-66)

UserSettings.jsx
DESIGN-01: L:33,38 There is duplication in the error and success handling for the two Meteor.call methods (for updating company name and password). Refactoring this into a reusable function could reduce the repeated code for displaying swal alerts.
CustomLineChart.jsx
Design-01: L 9–11 and Line 15–17: The structure of the data objects repeats across multiple entries.

UserSettings.jsx
L35: ESLINT-01: Remove this comment that disables eslint, then rename the second error differently
CustomLineChart.jsx
L6-48: Design-09: Example data should be placed in settings.development.json
L51-68: Design-09: Styling could be placed into style.css

UserSettings.jsx
Design-05: Irrelevant Comment for code (Line 35)
Custom LineChart.jsx
Design-09: Ensure reusable code is exported or made available in the appropriate place: Default Data for graphs should be in the json default file.
Design-07: Ensure code is readable: Possibly add comments for better readability incase modification is required.

CustomLineChart.jsx

adding a data parameter to the component would allow the code to accept different values for the line chart

UserSettings.jsx
DS-02: Multiple If/else. Might be another way to handle this.
We should verify that this is a safe way to change passwords. Might be good to include useTracker for updates.
Currently able to change password with same older password.
CustomLineChart.jsx
DS-05: Could use comments in other sections.

UserSettings.jsx
I think there might be a problem with calling Meteor.call inside of Meteor.call (Besides just an eslint problem), I'm assuming that it creates a child process, which might have undefined behavior if a user spams the button.
CustomLineChart.jsx
I think the data starting from line 6 and ending at line 49 should be in settings.development.json

Overview of Review Meeting
New issues:

cleanup UserSettings.jsx eslint comment by removing Meteor.call() in if-else
UserSettings.jsx implement a safe way to change passwords
cleanup CustomLineChart.jsx by refactoring the styling into classes or ids in a CSS file
Default data should be in settings.development.json in CustomLineChart.jsx


[BUG]: Title goes here

Please provide a video showcasing how this template can be used. If you really want to use this as a template it should be easy to use another REST API by simply changing some data structures, layouts being used, etc., as this project is so massive (unbelieable how much work you put in it), it is difficult to find where to start and where to change something.

I'd suggest you read about Clean Architecture, Modularization and MVVM.
For example here: https://medium.com/proandroiddev/mvvm-with-clean-architecture-c2c021e05c89
For the UI, look at presentation.
Remember that I have used RxJava and Coroutine to show the usages.
So, the codebase contains both. Follow the one that suits you more. I tried to distinguish the Coroutine ones by adding ...ByCoroutine to the end of the names (class names, method names, etc).
The Use Template comes from Github itself: https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-repository-from-a-template


Request page takes more time to load for Non Admin users

Request page takes more time to load for Non Admin users

The time was reduced by the fix.


Developer workflow for Lambda

How can a different parameter value be passed to name service from webapp service?
What is the minimal workflow after one of the Lambda function is changed?

How can this be done for SAM Local using CLI?

Is the workflow to test the functions locally using SAM Local, then deploy it manually and finally deploy to AWS?
Is there a way to create test, dev and staging environments?
X-Ray integration?
A/B deployment

@allinwonder will provide instructions on how to pass the parameter value to downstream Lambda functions
@arun-gupta will test the workflow if only greeting function is changed. CloudFormation stack needs to be updated and will ensure only the changed function is updated.
@allinwonder will add instructions on how to use stage name in the CloudFormation template.
@allinwonder will update instructions for X-Ray integration in the CloudFormation template. Add a parameter that will keep X-Ray off by default and turn on by specifying the correct value.
@allinwonder Linear deployment method which allows to specify the % of traffic that can be directed to new deployment based upon a timer. It also allows rollback. It uses CodeDeploy for the underlying implementation. Will add instructions.


Cheat: Infinite Durability does not work on fused weapons

Hi all,
When fusing any weapon to another weapon with the infinite durability mod enabled, the fused weapon eventually breaks, leaving only the base weapon.
I know that the mod is working generally because the base weapon does not break (even when it has lower durability than the fused weapon), and this issue never occurs when a material is fused instead of a weapon.
I've tried multiple times to add a Royal Greatsword over the Royal Guard's Sword, for example, and the Royal Greatsword always eventually breaks, while the Royal Guard's Sword is still intact.

Thanks for the response! Hope to see a fix sometime soon, when possible of course.


raftstore: increase region size from 64M to 96M

Close #1447

Should update the etc/config-template.toml too

PTAL

LGTM

In our test, for 128MB region size, snapshot applying can cause IO higher and affect the raftstore thread.
I think we should support SST ASAP @hhkbp2.

@hhkbp2 seem we can use SST to test this now.

LGTM
This PR is ready to go.

I prefer to merge the PR into 1.0.rc3, it's ready. PTAL

LGTM


Geometries get deformed because translation is applied too early

This is practically the same issue that cjio has. Geometries are deformed because the whole transform is applied very early in the process. This leads to floating point inaccuracies.
To reproduce the problem, load files in CityJSON Ninja (which uses cityjson-threejs-loader), and notice the difference. The test files are below
simplified2.city.json
simplified2_less_translation.city.json
My suggested solution is to only apply the scale from the transform at first, do all the processing normally, and then add the translation afterwards to the position of loader.scene (or if there's a better root node, then that).

Hey @wlinna,
Thanks for reporting the issue 🙌
I think this is already fixed by this: https://github.com/cityjson/cityjson-threejs-loader/commit/d6a98376424764e4d13388fe23f2adb416cf31c9. It's on the develop branch. I need to merge it to main soon.
I still haven't released a version of ninja that contains this fix as I had some issue with building it and I need to find some time to resolve it. If you are using this library directly, you may think about switching to the develop branch. If your concern is about how this propagates to ninja, I'll do my best to release a new version of it soon so that the fix is included there.

In this library, I do not transform the coordinates to Y-up. You can either use a transformation matrix to finally transform everything to Y-up, or you can set the camera to assume a Z-up coordinate system (see here.

Okay, thanks for the clarification


Correction on Scope authorization url and overload getRecentMediaByLocation

Econde on instagram should be something like this "likes+comments" and formURLEncoded broke it.

Coverage decreased (-8.8%) to 58.55% when pulling b5be52ac4da86dfe8511d2eb769d44b86b802fcb on robsoncassol:master into 6e062eb16b9f4676749ae1d04e6e554622829666 on sachin-handiekar:master.


Enable syntax highlighting in code samples

My eyes are bleeding

Another feature enabled by default in DevSite ;)

This was a problem with jsdoc and I was just about to PR in a hack but realised this is an extremely nice way to do this and should be fixed now.


Loading Notification?

Is there some way to denote that the PHP script is attempting connection?
I have a issue where while the ping is contacting the server, the surrounding PHP/HTML fails to load in.
I am not a skilled PHP developer so I apologize if there is an obvious answer.

Can you send me the contacted server ip or/and your example code?

This is all loaded in to the main page via PHP require();
Basically if the server is down, all of the code below waits to load in until the Ping has timed out.
I would like the surrounding HTML to somehow load in before your PHP ping is returned.
I have tried placing the PHP in another file, but it still waits to load all of the code until the ping times out.

            Vanilla

            Vanilla Minecraft with Plugins

            An experience you can't miss, with an Earth map and more.

            <button id="copyVanilla" data-clipboard-text="theyellowsub.us" data-tooltip="Copy Vanilla IP Address"
                    data-inverted="" class="ui huge green button">Vanilla IP
            </button>

            <?php
            require_once('vendor/autoload.php');
            $response = MCPing::check('theyellowsub.us');
            echo $response->getMotdToHtml();
            if ($response->online) {
                echo '
Server is UP
';
                echo '
' . $response->players . ' Online
';
            } else {
                echo '
Server is DOWN
';
            }
            ?>

This is how PHP works...
PHP is a server side language. You can't load html before your php script ends...
To accomplish your goal, you need to call your separate php script via AJAX with javascript.

This is how PHP works...
PHP is a server side language. You can't load html before your php script ends...
To accomplish your goal, you need to call your separate php script via AJAX with javascript.

Okay, thank you I apologize for openening a ticket for this then.


Truncate long tokens

Description
Instead of discarding all tokens beyond 32 bytes, keep all of them, but truncate at 16 bytes.
This makes the vocabulary more compact, since we don't need to store so long tokens in samples.json). This ensures that we keep some relevant tokens such as comments used as delimiters (e.g. ///...).
Checklist:
N/A

No change in cross-validation with default flags.
Changes for cross-validation with --all:
--- before.all.list	2021-02-10 00:06:23.721999209 +0100
+++ after.trunc.all.list	2021-02-09 23:54:18.966015279 +0100
@@ -64 +64 @@
-Apex/BooleanUtils.cls GOOD
+Apex/BooleanUtils.cls BAD (EQ)
@@ -1225 +1225 @@
-NCL/gsn_csm_xy2_time_series_inputs.ncl BAD (Perl)
+NCL/gsn_csm_xy2_time_series_inputs.ncl GOOD
@@ -2011 +2011 @@
-Text/filenames/README.mysql BAD (RUNOFF)
+Text/filenames/README.mysql BAD (Markdown)
@@ -2224 +2224 @@
-XML/wixdemo.wixproj BAD (Oxygene)
+XML/wixdemo.wixproj GOOD

Changes for cross-validation with --all:

Is this expected? For example, why does using truncated tokens result in different and potentially incorrect classification:
@@ -64 +64 @@
-Apex/BooleanUtils.cls GOOD
+Apex/BooleanUtils.cls BAD (EQ)

... and ...
@@ -2011 +2011 @@
-Text/filenames/README.mysql BAD (RUNOFF)
+Text/filenames/README.mysql BAD (Markdown)

Is the "correction" of the others really a correction?

@smola Changes for cross-validation with --all:

@lildude Is this expected?

Kind of.
The cross-validation script, for each sample trains a new classifier with all samples excluding the tested sample, and then it classifies the sample with that classifier. By default, without --all, the call to the classifier considers only "ambiguous languages" (per filename and extension). This is quite close to real-world conditions. When using the --all flag, every language is considered for every sample, regardless of filename and extension.
I try to minimize errors with both settings. While considering all languages is not what linguist does in practice, a good tokenizer and classifier should also be better at classifying languages without previous disambiguation (in theory).
Now, when comparing diffs for the results, either with or without --all, changes to the tokenizer and the classifier also lead to some new errors, even if the overall error count decreases. This often happens with Raku and Perl, some assembly samples or some C/C++ samples, where the classification scores are so close that they easily flip between 2 languages.
Sometimes these changes are hard to explain with anything other than "chance". The current classifier is very sensible to 2 parameters: a) total token count across all samples and b) total token count within a language. The former affects the probability of the unknown token and the later affects the token probabilities within a language. Some tokenizer changes lead to significant changes in these counts, so they affect classifications that are not conceptually related.
In this case, this change avoids discarding tokens longer than 32 bytes, which increases the total token counts. I think this might be the reason for the flip in the classification of Apex/BooleanUtils.cls (with --all). Note that with the master branch, the scores for this sample are: -2740.84 (Apex) and -2741.27 (EQ), and with this branch they are -2741.49 (Apex) and -2741.39 (EQ). The scores are so close that it's easy to flip this classification. Luckily, EQ is not associated with the .cls extension.
Regarding NCL/gsn_csm_xy2_time_series_inputs.ncl, the new correct classification seems to be because of the ;*************** token (now truncated, previously discarded).
Text/filenames/README.mysql has still an incorrect classification, but the new classification does look as an improvement. The file is pretty close to Markdown. This change seems to be causes by the truncation, since the ================ token, usually present in headers for Markdown and others, are now present in the vocabulary, while they were previously discarded if longer than 32 bytes, or scattered across a lot of different tokens.
I'm not really sure about XML/wixdemo.wixproj.


Move The Cursed Pirate to it's own repo, publish to GHPages

Done: https://github.com/PurpleKingdomGames/pirate-demo


merge: Merge dev-lewis-2 with developer

Completed main functionality of app.
Next step: enhance and make sure unit tests are all linked and work correctly with the new functionality.

Reviewed over teams, looks good


readkey() does not work with esc key

You may already know this, but when escape is pressed, readkey() does not return.  I understand why this is (some other keys are escape sequences), but there must be a way to handle this, since many programs seem to be able to do it.
Edit: Additionally, it looks like Windows doesn't use ANSI escape codes, so readkey might not work with non-ascii keys on Windows. I have not tested that.

Hmmm... Interesting.
I really have no idea how to implement that. If you see the readchar_linux.py code, everything reduces to read from stdin (just sys.stdin.read(1)). The problem with ESC key is the code it generates: 0x21, just the first code generated by F1-F12 or any ALT/CTRL combination.
How can it be implemented? Well... I find three ways:

by adding a parameter to return the ESC code when read. If it is set to true, the ESC management is delegated to the caller. I really hate this solution.
by checking if there is any character in stdin, ready to be read. This is the best one, but there is no primitive to do that.
by creating two threads. The first one will read the char and the other will give some time to get the char. If no additional character is ready by then, then return just the ESC key.

The last solution may fit the bill, but it can generate unexpected results: it could return different results depending on the time it requires to be generated. And it may add an important delay (just a few milliseconds but for each readkey call).
I really do not want to do that, so I think I will leave this issue as open, so anyone can suggest another solution or implementation.
Thank you very much.

Generally speaking, in UNIX systems you could use select to check if there is something else to read.
The problem in python is that file objects are usually buffered, e.g. sys.stdin is. So when reading from them, even if you only want to read a character, it will read its buffer size, in the next reads it will be giving you characters from its buffer, not from the underlying file itself.
This provokes select (that in python is directly mapped to the system call and doesn't know anything about python buffers) to see the OS buffer empty, because python has already buffered everything, so for it there is nothing to read.
This can be workarounded in two ways:

Running python unbuffered (-u flag).
Programatically by "re-opening" stdin without buffer, see an example bellow:

import sys
import select
import termios
import tty
import os

old_settings = termios.tcgetattr(sys.stdin)
tty.setcbreak(sys.stdin.fileno())
try:
    unbuffered = os.fdopen(sys.stdin.fileno(), 'r', 0)
    while True:
        if select.select([unbuffered,],[],[],0.0)[0]:
            print ord(unbuffered.read(1))
            sys.stdout.flush()
finally:
    termios.tcsetattr(sys.stdin, termios.TCSADRAIN, old_settings)

I hope it helps.

Another way to get around the buffering is to use the lower level os.read.

True, this is probably a better way to do it.

I will try this evening.

published in version 1.0.0.
Thank you!

This seems not to be working anymore
In [1]: from readchar import readkey

In [2]: readkey()
Out[2]: '\x1b\x1b'

I had to press twice
In [3]: import readchar

In [4]: readchar.__version__
Out[4]: '0.0.8'

% pip freeze | grep readchar
-e git://github.com/magmax/python-readchar@84ca04ab4992f61dfa6a911ea6358c10afd7af57#egg=readchar


initial commit for minari integration

Oh, and one more thing, we will likely be releasing Minari v0.4.0 today. I think it would be ideal to target that version with this PR, since it will have some breaking changes to how dict/tuple spaces are handled, and adds full support for text spaces.

@balisujohn i've made the changes for adding the remote flag and added unit tests for minari_utils.py. once the changes are up for Minari v0.4.0, will make the relevant changes to the code post that.
cc : @nicku-a

minari 0.4.1 is released, and I'd recommend targeting that version, since 0.4.0 has a missing dependency.

@nicku-a i've updated the minari version in the PR, apart from that not much change is needed for the integration, PR is ready for your review.

This also fails the build checks because minari 0.4.1 depends on h5py 3.8 - can you reflect this in the requirements too please? Thanks @shreyansjainn!

@nicku-a removed whitespaces and changed the h5py package version.

@nicku-a apologies i missed out on removing the whitespaces from the test file, have removed them now.

We're nearly there.
It also still fails the ruff linting check: 'tests/test_minari_utils.py:86:5: F841 Local variable dataset is assigned to but never used'.
Could you use ruff (https://beta.ruff.rs/docs/) to very quickly check your updates. Thanks and sorry for being pedantic!

@nicku-a is there a way i can run the workflow locally to test out if its running properly or not? i'll accordingly make the changes and then push the necessary edits.

Simplest is to just run:
ruff --format=github --target-version=py37 --ignore E501 .
and pytest

@nicku-a have pushed the changes, had to make some changes for the dataset name structure (there is a check for that in minari 0.4.1). validated it with pytest and ruff commands too, hopefully it passes the test now 🤞

Nice work @shreyansjainn @balisujohn, thanks for your help! Merging now👍


missing or invalid api key (get free api key & configure it from https://cloud.projectdiscovery.io/?ref=api_key)

i use asnmap on a kali linux in virtual box

I upload a key but not give a result show You are logged in as (@abhisheknagar41153)

Hello can you resolve this problem. Know about it

It looks like we're having some issues with our backend. It should be back up and running if you give it another try, @abhiyanka.

not fixed here yet

sorry for my last comment its fixed .
thanks for supporting I appreciate your team and work .


Console error

Hi i get this message in the console when trying to use this lib:
warning.js:36Warning: You are manually calling a React.PropTypes validation function for the renderStarIconHalf prop on t. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

@SLockyer sorry, I cannot reproduce your case with latest React version. Also this library use propTypes properly - https://github.com/voronianski/react-star-rating-component/blob/master/src/StarRatingComponent.jsx#L5-L14 (without calling them directly and there're no third-party propTypes). Please check this article - https://facebook.github.io/react/warnings/dont-call-proptypes.html and share code if you still need some help with it.

I don't know why, but I also get this issue.

This is how I use the component, and I got the warning.
import React, { Component } from 'react'
import StarRating from 'react-star-rating-component'

class Stars extends Component {
  render() {
    const {
      name,
      value,
      starCount,
      starColor,
      emptyStarColor,
      editing,
      style
    } = this.props

    return (
      <StarRating
        name={name}
        starColor={starColor || '#ffb400'}
        emptyStarColor={emptyStarColor || '#ffb400'}
        starCount={starCount || 5}
        editing={editing || false}
        value={value}
        style={style}
        renderStarIcon={(index, value) => {
          if (Math.ceil(value) === index && value % 1 !== 0) {
            return
          }

          return <span className={index <= value ? 'fa fa-star' : 'fa fa-star-o'} />
        }}
      />
    )
  }
}

export default Stars


Update writeup_template.md

Written down reflection of my project.

Written down reflection of my project.

This should not be merged in as it provides answers - not only that, this is for the wrong project.  This writeup is for the first project - the lane lines detector.

Though we are a little delayed in responding, this PR contains your personal work that cannot be added to Udacity's repository (starter-code).
Although, feel free to suggest an update to the starter code.
Happy Learning
Udacity


Add Social Media Buttons

Checked other resources

[x] added a very descriptive title to this issue.
[x] searched the greatbuilder documentation with the integrated search.
[x] used the GitHub search to find a similar question and didn't find it.

Issue Image (if any)

Description
Add social media icons with having links in highlighted section on the footer.
Icon should contain:
Twitter
Github
Linkedin
System Info
Windows 11
npm 10.2.3
node 20.10.0
Related Component

[ ] Deployment
[x] Nextjs
[ ] LLMs
[ ] Langchain
[ ] Rust
[ ] Python

these links will be used for login or to redirect to a profile ?


add deploy script

To summarise, this PR adds scripts that register and does a deposit for 2 accounts along with initializing the contract with a genesis state root. Is the summary correct?

It registers 2 public keys and initializes a genesis state root. But no deposit.


RuntimeError occurs when run quantized int8 Llama-2-7b-hf

Describe the bug
When run a compiled int8 Llama-2-7b-hf, the following error message pops up:
"RuntimeError: probability tensor contains either inf, nan or element < 0"
To Reproduce
Steps to reproduce the behavior:

test sript:

import torch
from intel_npu_acceleration_library.compiler import compile
from transformers import AutoModelForCausalLM, AutoTokenizer

MODEL_ID = "meta-llama/Llama-2-7b-hf"
torch_dtype = torch.int8

model = AutoModelForCausalLM.from_pretrained(MODEL_ID, use_cache=True)
tokenizer = AutoTokenizer.from_pretrained(MODEL_ID, use_default_system_prompt=True)
with torch.no_grad():
    compile(model, dtype=torch_dtype)

prompt = "What is the meaning of life?"
print(f"Prompt: {prompt}")
inputs = tokenizer(prompt, return_tensors="pt")
generate_ids = model.generate(
    input_ids=inputs.input_ids,
    attention_mask=inputs.attention_mask,
    max_new_tokens=30
)
response = tokenizer.batch_decode(
    generate_ids,
    skip_special_tokens=True,
    clean_up_tokenization_spaces=False
)
print(f"Generated: {response[0]}")

Error:

Traceback (most recent call last):
  File "C:\npu-llama\\llms\debug.py", line 16, in <module>
    generate_ids = model.generate(
                   ^^^^^^^^^^^^^^^
  File "c:\npu-llama\.conda\Lib\site-packages\torch\utils\_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "c:\npu-llama\.conda\Lib\site-packages\transformers\generation\utils.py", line 1622, in generate
    result = self._sample(
             ^^^^^^^^^^^^^
  File "c:\npu-llama\.conda\Lib\site-packages\transformers\generation\utils.py", line 2829, in _sample
    next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: probability tensor contains either `inf`, `nan` or element < 0

Desktop (please complete the following information):

Window 11
Intel NPU driver version: <IP_ADDRESS>8
intel-npu-acceleration-library==1.2.0

Same issue as https://github.com/intel/intel-npu-acceleration-library/issues/48, going to see what can be done to mitigate it

@alessandropalla, When I use intel-npu-acceleration-library==1.0.0, torch.int8 and simple quantization works well.
So, I think the issue is caused by the quantization library which was added in ver1.1.0.

I have the same experience with the test script.

We nailed don where the problem is. Fix is coming

Fixed with commit https://github.com/intel/intel-npu-acceleration-library/commit/cf896af789c648f0514dbd5905e1c66efd87d0d1.


AVRO-3688: Fix UnionSchema resolution if a UnionSchema contains a reference

What is the purpose of the change
This PR adds a test-case for the issue reported in AVRO-3688 and a potential fix.
The root cause of the issue is that a UnionSchema may contain any Schema variant, including a Schema::Ref. If a Schema::Ref is not properly resolved prior to resolving the UnionSchema itself, then schema resolution will fail with an unhandled panic.
Verifying this change
This change added tests and can be verified as follows:

Run cargo test from avro/lang/rust/avro

Documentation

Does this pull request introduce a new feature? No
If yes, how is the feature documented? not applicable

Thank you for the contribution, @RikHeijdens !
Awesome work!

Thank you for the quick review! 😁


/undo not working without --auto-commits == true

Issue
I understand that /undo performs git reset HEAD^, but returning to the previous chat status would be more useful.
This is particularly helpful in buggy situations when the code isn't working well enough for a commit.
Moreover, aider can make multiple commits in a single run, which may complicate returning to a previous status (e.g., to refine the prompt, add more details to the prompt).
Version and model info
Aider v0.56.0
Main model: claude-3-5-sonnet-20240620 with diff edit format, infinite output
Weak model: claude-3-haiku-20240307
Git repo: .git with 63 files
Repo-map: using 1024 tokens, auto refresh

Thanks for trying aider and filing this issue.
Aider uses auto-commits to implement /undo, so you need to leave them on if you want the safety of undo.
You can always squash the many aider commits afterwards if you want a tidy git history.


NFS data set

Hello, it is a great honor to see your excellent work! I would like to ask you if you have any questions about the NFS data set downloaded from the NFS Data set official website and how to set the path of the NFS data set.
There are no anno and sequences files in the original dataset, and I got the following ValueError when I ran it: could not convert string '0 520 260 564 369 1 0 0 1 "person"' to float64 at row 0, column 1.
I wonder if you have met it before. Looking forward to your reply, thank you

Hi there, may I ask if you are downloading NfS directly from here? That's exactly what I did and the code would run smoothly if I remember it correctly. Maybe these two answers (https://github.com/visionml/pytracking/issues/211, https://github.com/visionml/pytracking/issues/377) can help you to solve your issue. If it doesn't work, I also found a newly opened issue (https://github.com/visionml/pytracking/issues/400) that mentions a similar question. Since the codebase is based on PyTracking, I think most instructions and solutions from them are probably suit for this project as well.


Added tests to ensure defaults are handled correctly when using attributes.

We will have a swing at the new spec draft regarding defaults with the October release #3192.


linux-cachyos: init at 6.2.10

Having to pre-compile is tedious without proper hardware.

IS the config now fixed? Does it work now correctly?

It should - I've provided the config in the group for you to check a few days ago 👀


occur error when install requirement package dotenv

I use the conda environment,python version 3.10.9, when I exectue pip install -r requirement.txt occurs the error.
Collecting dotenv (from -r requirements.txt (line 6))
  Using cached dotenv-0.0.5.tar.gz (2.4 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [66 lines of output]
      /home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
        warnings.warn(
        error: subprocess-exited-with-error

        × python setup.py egg_info did not run successfully.
        │ exit code: 1
        ╰─> [16 lines of output]
            Traceback (most recent call last):
              File "<string>", line 2, in <module>
              File "<pip-setuptools-caller>", line 14, in <module>
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/setuptools/__init__.py", line 2, in <module>
                from setuptools.extension import Extension, Library
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/setuptools/extension.py", line 5, in <module>
                from setuptools.dist import _get_unpatched
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/setuptools/dist.py", line 7, in <module>
                from setuptools.command.install import install
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/setuptools/command/__init__.py", line 8, in <module>
                from setuptools.command import install_scripts
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/setuptools/command/install_scripts.py", line 3, in <module>
                from pkg_resources import Distribution, PathMetadata, ensure_directory
              File "/tmp/pip-wheel-4_e44bv7/distribute_789d4844bd21483ba4d2eed22e22534b/pkg_resources.py", line 1518, in <module>
                register_loader_type(importlib_bootstrap.SourceFileLoader, DefaultProvider)
            AttributeError: module 'importlib._bootstrap' has no attribute 'SourceFileLoader'
            [end of output]

        note: This error originates from a subprocess, and is likely not a problem with pip.
      error: metadata-generation-failed

      × Encountered error while generating package metadata.
      ╰─> See above for output.

      note: This is an issue with the package mentioned above, not pip.
      hint: See above for details.
      Traceback (most recent call last):
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/installer.py", line 82, in fetch_build_egg
          subprocess.check_call(cmd)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/subprocess.py", line 369, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['/home/isoface/anaconda3/envs/textgen/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpv_yshx_r', '--quiet', 'distribute']' returned non-zero exit status 1.

      The above exception was the direct cause of the following exception:

      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-eej6j084/dotenv_5920fc86e3454fcebef593d54cd63f66/setup.py", line 13, in <module>
          setup(name='dotenv',
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/__init__.py", line 86, in setup
          _install_setup_requires(attrs)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/__init__.py", line 80, in _install_setup_requires
          dist.fetch_build_eggs(dist.setup_requires)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/dist.py", line 874, in fetch_build_eggs
          resolved_dists = pkg_resources.working_set.resolve(
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/pkg_resources/__init__.py", line 815, in resolve
          dist = self._resolve_dist(
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/pkg_resources/__init__.py", line 851, in _resolve_dist
          dist = best[req.key] = env.best_match(
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/pkg_resources/__init__.py", line 1123, in best_match
          return self.obtain(req, installer)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/pkg_resources/__init__.py", line 1135, in obtain
          return installer(requirement)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/dist.py", line 944, in fetch_build_egg
          return fetch_build_egg(self, req)
        File "/home/isoface/anaconda3/envs/textgen/lib/python3.10/site-packages/setuptools/installer.py", line 84, in fetch_build_egg
          raise DistutilsError(str(e)) from e
      distutils.errors.DistutilsError: Command '['/home/isoface/anaconda3/envs/textgen/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpv_yshx_r', '--quiet', 'distribute']' returned non-zero exit status 1.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.

I chage the requirement.txt dotenv to python-dotenv to solve... Is the same package?

sorry I forgot to check the closed issue

but the dotenv still exists... so i reopend it 😀

Sorry, it seems the package is named python-dotenv, rather than dotenv. Updating requirements

Should be fixed now


Adapt UITextField to use UIKit.Xaml.TextField as backing control

This change

mainly move the core implementation of UITextField to UIkit.TextField to follow the new UIkit paradigm. As a result. We have a lot less cached object in UITextField.
Refactor code to use shared functions for AdjustFontSizeToFit which is used on UILabel as well.

:shipit:


lerobot/common/policies/normalize.py divide by zero

System Info
Normalize class could have a divide by 0 problem, e.g. when some of the states or actions have a fixed value.

This can be fixed if https://github.com/huggingface/lerobot/blob/main/lerobot/common/policies/normalize.py#L150 is changed to

batch[key] = (batch[key] - min) / (max - min + 1e-8)

Information

[ ] One of the scripts in the examples/ folder of LeRobot
[X] My own task or dataset (give details below)

Reproduction
This occurs when I extend push T / Diffusion policy to a real robot, and start by fixing the non-XY states / actions.
Expected behavior
Should be able to compute loss even when there are states and actions that have a single fixed value in the entire dataset

@ruijie-he thanks a lot for reporting. We'll add this to the TODO list, but one question: have you considered contributing a PR? ;)

@ruijie-he if you are not working on this, can I take a stab at it?


Reference control validation error doesn't show

It is relevant also for repeats: true for choice fields


Yay/ARU Install error: install command is not scriptable

When attempting to install hyprlock-git package from the ARU with yay I get the following error:
CMake Error at build/cmake_install.cmake:64 (install):
  install command is not scriptable

==> ERROR: A failure occurred in package().
    Aborting...
 -> error making: hyprlock-git-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
hyprlock-git - exit status 4

I saw that there was a similar error with Nix fixed here, https://github.com/hyprwm/hyprlock/commit/f237dead6cf7c79b713168fb1053758c771a1dfe

likely a problem with the package. Builds just fine manually for me.

The release version of v0.3.0 is broken the same way. I see the VCS package in the AUR is applying a patch labeled for Nix that probably relates to this, but that is a bit ridiculous. The CMakeLists.txt file should just be fixed.

the CMakeLists is not broken, though. It works on my end.
The reason it's there is to not overwrite the pam entry with the default if it already exists. See #209
If you have a different way of achieving the same, that is more compatible, be my guest.

"Works for me" does not make it correct.
I suspect the issue is you are inadvertently testing the host system root instead of (in the case of nearly every distro packaging system out there) the DEST directory where files to be packaged are collected. I don't know my way around CMake, but surely it has a variant of an install() function that handles this kind of use automatically, you shouldn't have to hand check a file like that. In the case of distro packages it will handle creation or update of system files automatically, the job of CMake is just to "install" stuff to a blank directory structure.

I think not throwing this into a script should work too... but that's a method I found on the cmake mailing list. Gimme sec.

yeaaah that doesn't work. I think this could be better addressed when #205 lands, as we can overwrite the hyprlock pam file and just ask people to make a custom file they can set in the config.
I'll reopen this

should be done with d9a6229434fba475ea42b634ee2f03919236798d

Okay thanks.
I've backported that patch and applied to v0.3.0, and also marked /etc/pam.d/hyprlock for backup (so that the package can update it in the future but any user applied edits to the file will get preserved and the user prompted to merge changes from the new package supplied version) and updated the Arch Linux package repos.

thanks for the maintenance work :)


Add simple XML parser to included parsers

Add a simple XML parser to showcase transformer validation errors.
The current grammar does not work -- it enters an infinite loop. Probably due to an underlying issue in rule::parse that I haven't found out yet.

Opened Issue #8 to track the bug preventing this from working.

The errors in the test for the parser had to be replaced with () as error handling is not working -- opened issue #9 for it.
Otherwise, this is fixed. It was a design error by me. As such #8 is closed as well.


Does the module support fine-tuned Llama2?

A fine-tuned Llama2 model may be stored locally. Can be it integrated with lade?
Can lade be used when the model is served in the streaming mode?

Thanks for your interest.
Yes, any model based on LLaMA2 can be supported (if you did not change the model structure).
Regarding the streaming mode, I'm not entirely sure what you're referring to. Could you please provide a bit more context or elaborate on your question? This will help me understand your query better and provide a more accurate response.

@spring1915 by streaming do you mean a live inference endpoint receiving a stream of requests?

I meant the way of serving the model that can produce a stream of tokens for a request, like what we can see with OpenAI chat.

If I understand correctly, it is supported. There are examples in chatbot.py.


Support for SQL server

Hey, thanks for the great product. Just wondering whether this can provide support for SQL server. We already have a OMOP CMD instance based on SQL server. We would like to build a FHIR server on top of it. But I tried the docker one. It seems like it did not support the SQL server only PostgreSQL now?

I tested with Azure SQL server previously. And, it worked fine. Currently, this supports PostgreSQL, SQL server, and BigQuery. However, I haven't tested SQL and BigQuery after I changed the DB driver to POOL based library. For JDBC, we need to use appropriate driver for SQL server.
In environment, you need to set TARGETDATABASE="sql server". And, JDBC_DATASOURCENAME needs to be set to one that works for SQL Server. We are using Hikari for the database connection pool. If you google search, you may find what you need to use for the data source name.
If you set up JDBC_URL, JDBC_DATASOURCENAME, and TARGETDATABASE correctly, it should work. Username and Password passing via JDBC URL are tricky though.   I loaded mssql driver for JDBC already. And, sqlRender transforms SQL to MS SQL. All should work.


Error when running run_vespucci.

I am encountering an error while trying to run Vespucci- run_vespucci function. The error occurs both when running the function with the basic inputs and when additional parameters are provided.
Error Message:
> vespucci_res = run_vespucci(input = input, meta = meta)
Splitting matrix
As no overdispersion parameters were provided, Poisson count splitting will be performed.
Error in auc@x :
  no applicable method for `@` applied to an object of class "NULL"
> data('spatial_sim_distance_metrics_df')
> vespucci_res = run_vespucci(
+   input = input,
+   meta = meta,
+   distance_metrics_df = spatial_sim_distance_metrics_df,
+   test_sim = T
+ )
Splitting matrix
As no overdispersion parameters were provided, Poisson count splitting will be performed.
Error in auc@x :
  no applicable method for `@` applied to an object of class "NULL"

Code:
# Vespucci

# install.packages("devtools")
# install.packages("propr")
# devtools::install_github("tpq/propr")
# install.packages("dismay")
# install.packages("remotes")
# remotes::install_github("skinnider/dismay")
# devtools::install_github("neurorestore/Vespucci")

library(Vespucci)
library(Seurat)

setwd("C:/Users/NXI220005/Downloads/vispu_data")
files <- list.files()
print(files)

load("spatial_sim.rda")
load("spatial_sim_calculated_auc_df.rda")
load("spatial_sim_distance_metrics_df.rda")

ls()

data("spatial_sim")
input = GetAssayData(spatial_sim, slot='counts')
meta =<EMAIL_ADDRESS>
?run_vespucci

vespucci_res = run_vespucci(input = input, meta = meta)

data('spatial_sim_distance_metrics_df')
vespucci_res = run_vespucci(
  input = input,
  meta = meta,
  distance_metrics_df = spatial_sim_distance_metrics_df,
  test_sim = T
)

Despite following the instructions, I keep receiving the Error in auc@x indicating that no applicable method for @ is being applied to an object of class "NULL". Any guidance on what might be causing this issue would be appreciated.

It seems we might have identified the issue here.
In utils.R, the function should be updated from:
countsplit_matrix = function(
    input,
    seed = 42
) {
    set.seed(seed)
    split = countsplit(input, epsilon=0.5)
    auc = split$train
    auc@x = as.numeric(auc@x)
    de = split$test
    out_list = list(
        'run_auc' = auc,
        'run_de' = de
    )
    return(out_list)
}

to:
countsplit_matrix = function(
    input,
    seed = 42
) {
    set.seed(seed)
    split = countsplit(input, epsilon=0.5)
    auc = split[[1]]
    auc@x = as.numeric(auc@x)
    de = split[[2]]
    out_list = list(
        'run_auc' = auc,
        'run_de' = de
    )
    return(out_list)
}

We referenced the information from here. Please let me know if this can be implemented as a fix. If so, I will fork the repository. Thanks!

Hi, thank you for bringing this to our attention. We have implemented the fix as suggested.


feat: Add config setting for value used for ListenAndServe

Updated to latest go-mod-bootstrap v0.0.36
Added Service.ServerBindAddr setting to config files for all edgex-go microservices

fix: #2624
Signed-off-by: Felix Ting<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit subject follows the Conventional Commits spec
[x] The commit message follows the EdgeX Contributor Guide
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] make test has completed successfully

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Before go-mo-bootstrap v0.0.36, the ListenAndServe IP address defaults to binding to an all-interface listener value of <IP_ADDRESS>
Issue Number: #2624
What is the new behavior?
Added a Service.ServerBindAddr configurable value to config file to reflect this change: https://github.com/edgexfoundry/go-mod-bootstrap/pull/84
The default value of ServerBindAddr of each service is blank, so the Service.Host value is now the ListenAndServe IP address. However, it allows env override to set a specific value as needed for different deployments.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Validate branch using local master-dev built docker images.


Add SingleArgumentMessageChain cop

Suggests replacing receive_message_chain(:bar) with receive(:bar).
Fixes #240.

@backus Will you review and merge, please?

Looks great. Nice job


Add logEvent.Level to eventHubData.Properties for easier filtering of…

Small changes to satisfy issue #9

LGTM, let's merge to dev and see how it goes 👍 Thanks!


Partition by dataset, vaccine, and year

This is only necessary if the data become too slow to load and query

Partitioning is premature; we'll deal with this when we have performance problems, if ever


ginga-5.00 release

hcam-finder version: 1.3.5
Python version: 3.11.8
Operating System: Debian linux amd64

Description
ginga-5.00 has recently been released, and ufinder/usfinder/hfinder rotation does not work
What I Did
update from ginga-4.1.1 to ginga-5.0.0 and run ufinder/usfinder/hfinder
ufinder shows..
2024-02-28 10:11:06,531 | E | finders.py:527 (draw_ccd) | failed to draw CCD: 'CompoundObject' object has no attribute 'rotate'
2024-02-28 10:11:09,570 | W | finders.py:333 (click_cb) | failed to draw CCD: 'CompoundObject' object has no attribute 'contains'
Best regards
Paul

Fixed in https://github.com/HiPERCAM/hcam_finder/commit/c7d6d44325ca0d43fc367bd980b371cdd16ed1e6
New release (1.3.7) with these changes


Interface field in FybrikApplication is confusing

We refer to the interface field inside dataset requirements in a different way based on the flow. Sometimes (read, write) it is an interface between the workload and the virtual module endpoint. Sometimes it is a desired protocol/format of a target, as in copy. It is especially confusing when coming to the write scenario where we have both interface between the workload and the module, and the written asset requirements (if exist).
Proposal:  interface will define the interface between the workload and the module, while adding target structure to define requirements on a target (optionally), such as connection, format, metadata.

@shlomitk1, do you have any updates ?


GH-14736: [C++][Python] Ensure no validity bitmap in UnionArray::SetData

Will close #14736

Closes: #14736

Since the discussion here (https://github.com/apache/arrow/pull/14838#discussion_r1039574789) concluded that the bug needs a different fix, I am going to close this PR. And I added an explanation of the above discussion to the issue: https://github.com/apache/arrow/issues/14736#issuecomment-1415879965


Bug: EDF reader crashes for my file

@teonlamont
Hi,
I was trying to read the following file but it crashes with the error:
"ValueError: could not broadcast input array from shape (4960) into shape (160)"
File: http://physionet.nlm.nih.gov/pn4/eegmmidb/S001/S001R01.edf
Thanks!

found it. the structure of the code changed but one line didn't get changed properly. closing for pr #1827.


feat: #1383: add shielded address info

Closes #1383

@TalDerei Right, forgot to remove the redundant css class. Now it looks better:


[Bug]

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Cloud (http://rxresu.me)
Current Behavior
I cannot use the Font subset And font variants options; it directs me to a random page, and when I press back, it takes me to the home page.
Expected Behavior
A working Font Subset and variants option to choose fonts.
Steps To Reproduce
No response
What browsers are you seeing the problem on?
Chrome
What template are you using?
Rhyhorn
Anything else?

@jagrutipixel Ah, I see. This is related to one of cmdk's new breaking changes (https://github.com/pacocoursey/cmdk/issues/230#issuecomment-1986220383) to enforce CommandList, but it seems I have forgotten to add it over here. Thank you for raising the issue, will look into a fix ASAP.


Simplify several FeatureInterpretation classes

Adds inheritance for Geobody, Boundary, Frontier, GeologicUnit, FluidBoundary classes

Codecov Report

Merging #73 (94c62ee) into master (e88c699) will decrease coverage by 0.00%.
The diff coverage is 51.02%.

:exclamation: Current head 94c62ee differs from pull request most recent head 1cd44b2. Consider uploading reports for the commit 1cd44b2 to get more accurate results

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   35.64%   35.64%   -0.01%
==========================================
  Files          49       49
  Lines       21757    21690      -67
==========================================
- Hits         7755     7731      -24
+ Misses      14002    13959      -43

Impacted Files
Coverage Δ

resqpy/organize.py
34.62% <51.02%> (+0.08%)
:arrow_up:

resqpy/model.py
60.79% <0.00%> (-0.08%)
:arrow_down:

resqpy/property.py
37.70% <0.00%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88c699...1cd44b2. Read the comment docs.


Fix memory caching issue with Equivalence.Equals

Currently, memory cache can not handle multiple BarCode instance that have same contents as expected. Bud disk cache can handle that as expected.
This PR implements BarCode.hashCode and BarCode.equals so that Equivalence.Equals works as expected.

Thank you for contribution. Somehow was missed when we moved this external.


CSS Organisation

Hello everybody,
I don't used to contribute with git so please apologize me if it's not the good way or place to do it.
I download Bootstrap V4 to know what's new... And I observe the same problem (for  me) that V3 : the organisation of the CSS. The actual organisation don't allow to gain time when you want to personalize your website. For example, when I want to change the background color of the navbar, I had to read all the css to find what I have to change. A most strong example is this one (I use notepad++ to code) :
Line 76 to 79  :
h1 {
margin: .67em 0;
font-size: 2em;
}
Line 340 to 344 :
h1, h2, h3, h4, h5, h6 {
margin-top: 0;
margin-bottom: .5rem;
}
Line 513 to 515 :
h1 {
font-size: 2.5rem;
}
I checked before posting and the two alone "h1" are the same, not one for a media query for example or else.
Moreover, I also see some contradictions. In the example above, the first h1 has a margin-top = 0.67 em and after, we ask him to have a margin-top = 0.
Now, I present my request. I would like to help you in this project and also I would like to help bootstrap to become a little accessible for all and to allow everybody to gain time with personalisation. So, if you are interested and if you allow me, I would like to reorganised the css file.
For exemple, we could regroup all the general text selectors as h1 or p in a category, regroup all the navbar elements in an other... And I would like to add comment near to the color code to help people.
Thanks to your consideration and sorry if this post is not appropriate.

Use SASS to customize your css.

Thank you for your advice. But I think using Sass won't make disappear the conflict between Bootstrap.css and my own css file that I have sometimes (and I am not alone according to forums).

Line 76 to 79 :

The code you're referring to here is from our vendored copy of Normalize.css. We intentionally leave it unmodified, at the cost of a few redundant declarations near the start of our generated CSS, in order to make upgrading Normalize.css super-easy.
So please ignore the Normalize.css code for the purposes of reducing redundancies.

regroup all the navbar elements in an other [category]

They're already grouped together in https://github.com/twbs/bootstrap/blob/v4-dev/scss/_navbar.scss , unless I'm misunderstanding you.

And I would like to add comment near to the color code to help people.

What would these comments say?

A lot of developers say not to mess with the core bootstrap files, but to just write another .css file to replace what changes you want. Call the .css file right after the bootstrap.min.css file. That may help.

@cvrebert : Ok I ignore Normalize. For the category, I didn't see your file and what you did, that's why I meant : regroup all the same code in the same place and not one part at the beginning and the other part à the end. I took the navbar element as exemple because it is the first thing I saw. When I had to just personalize the color (change grey into another for example).
@cvrebert : the comments will be "dark grey" or "light grey" (I am sorry if you don't understand, I don't remember how to say the different category of a colour). It's just to help to visualize faster the color, we all know the white and black color codes (basis), but for the other codes, we can just say what color to help visualize. It's just a suggestion.
@jakeingit : thanks for the advice but I already do this. I always call my css after bootstrap. And the probelm is still the same : conflicts between my css and bootstrap when I have to personalize even whent I put a personal "id" or "class" on my elements.

Ok I ignore Normalize. For the category, I didn't see your file and what you did, that's why I meant : regroup all the same code in the same place and not one part at the beginning and the other part à the end. I took the navbar element as exemple because it is the first thing I saw.

If you have other examples that don't involve Normalize, feel free to open issues or PRs about them.

the comments will be "dark grey" or "light grey"

Folks should be using sourcemaps, so they should see that these use the $navbar-dark-* variables, which get their values in https://github.com/twbs/bootstrap/blob/5073e756f87de81999a6761609794a3473dbad19/scss/_variables.scss#L486 . I guess we could add comments there, but I'm not sure it'd be worth it. Feel free to open a pull request for that if you want though, and we'll consider it.
Perhaps we should add color palette variables for these in #18462...


[SPARK-34053][INFRA] Cancel the previous build

Similar to: https://github.com/apache/spark/pull/31098 https://github.com/apache/calcite/pull/2318 (solution suggestted by @vlsi - https://github.com/apache/pulsar/issues/9154#issuecomment-756984731)
What changes were proposed in this pull request?
This PR aims to reduce the GitHub Action usage by cancelling the previous build.
Why are the changes needed?
In most case, the last commit is meaningful.
Does this PR introduce any user-facing change?
No
How was this patch tested?

@dongjoon-hyun  Can I ask for review?

@dongjoon-hyun  Can I ask for review?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I might be slightly late, however, https://github.com/potiuk/cancel-workflow-runs seems to be a more up to date action, and the documentation is way better there.
A bonus point is that @potiuk is PMC for Apache Airflow ( https://people.apache.org/phonebook.html?uid=potiuk )

I might be slightly late, however, https://github.com/potiuk/cancel-workflow-runs seems to be a more up to date action, and the documentation is way better there.
A bonus point is that @potiuk is PMC for Apache Airflow ( https://people.apache.org/phonebook.html?uid=potiuk )

@mik-laj, mind mentioning the diff from the fork (https://github.com/potiuk/cancel-workflow-runs) and the original (https://github.com/n1hility/cancel-previous-runs) in the PR description?

@mik-laj, mind mentioning the diff from the fork (https://github.com/potiuk/cancel-workflow-runs) and the original (https://github.com/n1hility/cancel-previous-runs) in the PR description?

ok to test

ok to test

add to whitelist

add to whitelist

@HyukjinKwon  I renamed this file.

@HyukjinKwon  I renamed this file.

Thanks @mik-laj for addressing my comments.

Thanks @mik-laj for addressing my comments.

Test build #133881 has started for PR 31104 at commit 1792fc9.

Test build #133881 has started for PR 31104 at commit 1792fc9.

Let me leave it to @dongjoon-hyun to take another look. I am he are pretty active in the maintenance of GitHub Actions, and I would like to make sure having his thought too.

Let me leave it to @dongjoon-hyun to take another look. I am he are pretty active in the maintenance of GitHub Actions, and I would like to make sure having his thought too.

Ohh. I reverted one change by mistake, but already reverted. Now we use the action from the potiuk / repository and the file has the correct name.

Ohh. I reverted one change by mistake, but already reverted. Now we use the action from the potiuk / repository and the file has the correct name.

Test build #133883 has started for PR 31104 at commit a30c6c3.

Test build #133883 has started for PR 31104 at commit a30c6c3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38470/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38470/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38472/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38472/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38470/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38470/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38472/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38472/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38470/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38472/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38470/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38472/

Test build #133881 has finished for PR 31104 at commit 1792fc9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133881 has finished for PR 31104 at commit 1792fc9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133883 has finished for PR 31104 at commit a30c6c3.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133883 has finished for PR 31104 at commit a30c6c3.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133883/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133883/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133881/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133881/

I enabled this only for the jobs triggered by PRs but there seems a bug in the plugin. If the PR triggers the job cancelation, it cancels all the workflows in the master branch too.

I enabled this only for the jobs triggered by PRs but there seems a bug in the plugin. If the PR triggers the job cancelation, it cancels all the workflows in the master branch too.

I disabled this workflow for now.

Let me know if this is fixed in the upstream.

I disabled this workflow for now.

Let me know if this is fixed in the upstream.

OMG. Thank you for disabling it.

OMG. Thank you for disabling it.

This is not a bug. The plugin works 'aggressively' in cancelAllDuplicates mode - whenever 'cancelAllDuplicates' is run, it will cancel all 'duplicated' runs  (all runs that match the same ('branch', 'oirigin repo', 'event').
So for every PR and every branch (including master) it will only leave the 'latest build` running. All other will be cancelled. This is by design.  The most recent build from master should not be cancelled.
The assumption is that if you merged several merges to master, you really want to run tests on the latest version of this - all the previous merges are not 'valid' any more - they are superseded by the latest build.
In case of Airflow it saves hours of needless builds.. Is this a problem for Spark ?

This is not a bug. The plugin works 'aggressively' in cancelAllDuplicates mode - whenever 'cancelAllDuplicates' is run, it will cancel all 'duplicated' runs  (all runs that match the same ('branch', 'oirigin repo', 'event').
So for every PR and every branch (including master) it will only leave the 'latest build` running. All other will be cancelled. This is by design.  The most recent build from master should not be cancelled.
The assumption is that if you merged several merges to master, you really want to run tests on the latest version of this - all the previous merges are not 'valid' any more - they are superseded by the latest build.
In case of Airflow it saves hours of needless builds.. Is this a problem for Spark ?

The reason why it is so 'aggressive' is that when you have queues, it's very likely that your "cancel runs'  are also queued, so we want to make sure that we cancel everything that we know is a duplicate, whenever any of the 'cancel' runs gets executed.
The plugin can be easily extended to exclude certain branches from this cancelling if you think this is something you need, but I'd like to ask first - what do you loose if those master builds are cancelled if there is another master build already scheduled to run ?

The reason why it is so 'aggressive' is that when you have queues, it's very likely that your "cancel runs'  are also queued, so we want to make sure that we cancel everything that we know is a duplicate, whenever any of the 'cancel' runs gets executed.
The plugin can be easily extended to exclude certain branches from this cancelling if you think this is something you need, but I'd like to ask first - what do you loose if those master builds are cancelled if there is another master build already scheduled to run ?

Actually the feature is already there - you can skip certain event types from being cancelled (in this case skipping the 'push' event will skip cancelling any of the runs that were originated by the "push" event (i.e. all master merges). I will make a PR that should enable it now and feel free to merge it if this is what you really want.

Actually the feature is already there - you can skip certain event types from being cancelled (in this case skipping the 'push' event will skip cancelling any of the runs that were originated by the "push" event (i.e. all master merges). I will make a PR that should enable it now and feel free to merge it if this is what you really want.

@potiuk, I already tried such fix at https://github.com/apache/spark/pull/31121 but it did not work. The cancelation workflow triggered by a PR canceled workflow runs in master branch, which looks not making sense much. If a user open a PR, then it cancels the jobs in the master branch .. ?

@potiuk, I already tried such fix at https://github.com/apache/spark/pull/31121 but it did not work. The cancelation workflow triggered by a PR canceled workflow runs in master branch, which looks not making sense much. If a user open a PR, then it cancels the jobs in the master branch .. ?

The cancelation worklfow must run in master branch in order to utlise GITHUB_TOKEN that has "write" capabilities (otherwise you have no rights to cancel workflo). This is how 'workflow_run' type of even works - it always runs using master code. See this stack-overflow question for example : https://stackoverflow.com/questions/63343937/how-to-use-the-github-actions-workflow-run-event#:~:text=The new workflow_run event enables,token as well as secrets.

This is due to security reasons. Otherwise any person could make a PR where they could change the workflow and do whatever they want to your repository. Workflow_run always runs wtith the workflow that is defined in your master, not in the PR. In order to test any change in the workflow_run you have to push it as master (I, for example, test such changes by pushing the PR branch as "master" to my own fork github push -f potiuk <branch>:master (where potiuk is the remote which is my own private fork).

Yes. The action is 'aggressive` because it is only useful if you are in the situation where your queue is "full" which means that any new action (including the cancel one) might take hours to even start executing. So if 'any' of the cancel workflows starts running - even from PRs that were created hours ago (just to remind - it's always using a master code) - this action looks at ALL builds and cancel ALL duplicate ones. That by default includes all "push" events (any merge to master is 'push', "schedule" events, "pull_request" - both coming from forks and pull requests that are done inside the repo.

The mode of cancelling 'cancelAllDuplicates` does exactly this. It does not even look at the original branch/PR that triggered it.

The change I am opening changes it's behaviour - it will not look for duplicates when there is a "push" or "schedule" event. Which means it will be cancelling ALL duplicates in ALL PRs opened that have more than one build in progress. This means that whenever cancel workflow has a chance to run, only the latest PR push will continue executing, others will be cancelled.

The cancelation worklfow must run in master branch in order to utlise GITHUB_TOKEN that has "write" capabilities (otherwise you have no rights to cancel workflo). This is how 'workflow_run' type of even works - it always runs using master code. See this stack-overflow question for example : https://stackoverflow.com/questions/63343937/how-to-use-the-github-actions-workflow-run-event#:~:text=The new workflow_run event enables,token as well as secrets.

This is due to security reasons. Otherwise any person could make a PR where they could change the workflow and do whatever they want to your repository. Workflow_run always runs wtith the workflow that is defined in your master, not in the PR. In order to test any change in the workflow_run you have to push it as master (I, for example, test such changes by pushing the PR branch as "master" to my own fork github push -f potiuk <branch>:master (where potiuk is the remote which is my own private fork).

Yes. The action is 'aggressive` because it is only useful if you are in the situation where your queue is "full" which means that any new action (including the cancel one) might take hours to even start executing. So if 'any' of the cancel workflows starts running - even from PRs that were created hours ago (just to remind - it's always using a master code) - this action looks at ALL builds and cancel ALL duplicate ones. That by default includes all "push" events (any merge to master is 'push', "schedule" events, "pull_request" - both coming from forks and pull requests that are done inside the repo.

The mode of cancelling 'cancelAllDuplicates` does exactly this. It does not even look at the original branch/PR that triggered it.

The change I am opening changes it's behaviour - it will not look for duplicates when there is a "push" or "schedule" event. Which means it will be cancelling ALL duplicates in ALL PRs opened that have more than one build in progress. This means that whenever cancel workflow has a chance to run, only the latest PR push will continue executing, others will be cancelled.

The PR is here: https://github.com/apache/spark/pull/31153

The PR is here: https://github.com/apache/spark/pull/31153

Sure, I used the same approach at https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml to handle the security issue by leveraging workflow_run when workflow_run feature first came out. I am aware of that.
I see, the new approach sounds much better. Thanks for working on this.

Sure, I used the same approach at https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml to handle the security issue by leveraging workflow_run when workflow_run feature first came out. I am aware of that.
I see, the new approach sounds much better. Thanks for working on this.

I see, the new approach sounds much better. Thanks for working on this.

 Happy to help!
Also the action has quite more sophisticated ways of cancelling the builds. I think at Apache Airflow we are saving at least 30% (in some cases even more) of the build time by pretty aggressive cancelling.
For example when any of our jobs fails at the "static check" failure we also cancel the workflow aggressively as well.
This is important because we have 5-10 minutes long 'static checks' and 40-50 minutes tests. but we want to start tests as soon as possible rather than waiting for static checks to complete. So we want to start them in parallel, but then if any of the static checks fail, we want to cancel all other tests because we know the change will have to be re-pushed anyway.
Unfortunately GA only allow such 'fail-fast' in matrix-jobs, so I had to add this option to the cancel action.
This way we save even more of the precious build time for the whole ASF community.

I see, the new approach sounds much better. Thanks for working on this.

 Happy to help!
Also the action has quite more sophisticated ways of cancelling the builds. I think at Apache Airflow we are saving at least 30% (in some cases even more) of the build time by pretty aggressive cancelling.
For example when any of our jobs fails at the "static check" failure we also cancel the workflow aggressively as well.
This is important because we have 5-10 minutes long 'static checks' and 40-50 minutes tests. but we want to start tests as soon as possible rather than waiting for static checks to complete. So we want to start them in parallel, but then if any of the static checks fail, we want to cancel all other tests because we know the change will have to be re-pushed anyway.
Unfortunately GA only allow such 'fail-fast' in matrix-jobs, so I had to add this option to the cancel action.
This way we save even more of the precious build time for the whole ASF community.


refs #19030 bound the distinct query and replace the count query with fi...

This PR contains the following two fixes:

Bound the distinct query by using latest id of the latest task in the messages collection
celery/kombu uses a count query when declaring queue which is redundant when using the mongo as the underlying transport.

@ChaksChigurupati : The purge operation doesn't act on the size count, but just returns it. Some of the connectors have implemented the purge logic on deactivation, but it calls  other method i.e. _purge_tenant

@ChaksChigurupati : Regarding putting a floor on the distinct query call, @aganapat  based on his experiment seems to perform better and I tested with 1.8M jobs in queue belonging to just one tenant. This is not a final fix and if this change doesn't perform as expected , we can proceed with using the tenants information in elastica_admin db.


AttributeError: module 'pyrealsense2' has no attribute 'pipeline'

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435}

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
jetson nano

Kernel Version (Linux Only)

Platform
NVIDIA Jetson nano

SDK Version
sdk2.0

Language
python3}

Issue Description
AttributeError: module 'pyrealsense2' has no attribute 'pipeline'
I have build librealsense and used pip3 install pyrealsense2-aarch64, everything is right .But when i try to run the example python scripts , the Error ocured as:
:~/.local/bin$ python3 align-depth2color.py
Traceback (most recent call last):
File "align-depth2color.py", line 16, in
pipeline = rs.pipeline()
AttributeError: module 'pyrealsense2' has no attribute 'pipeline'

I'm not sure what the pyrealsense2-aarch64 package is or who made it, but downloading the wheel from PyPi and opening it with 7z reveals that it contains only some example scripts, and not the actual library.
Try uninstalling pyrealsense2-aarch64 and install pyrealsense2 instead.

@swjtuccy Did you try what Iramati suggested? Looking forward to your update. Thanks!

@swjtuccy Any update about this? Thanks!

@swjtuccy If no other questions, will close it at this point. Thanks!

I have install pyrealsense, but run some program was error, the question as follow, please help me to solve this question, thanks!
$ python demo.py
Traceback (most recent call last):
File "demo.py", line 1, in
import pyrealsense2 as rs
File "/home/u16l/WORKS/Codes/pyrealsense2.py", line 6, in
pipeline = rs.pipeline()
AttributeError: module 'pyrealsense2' has no attribute 'pipeline'


Support ng serve

We should allow users to run there single-spa application via ng serve.
Proposed implementation: we have the html file be one in the root config described in https://github.com/CanopyTax/single-spa-angular#check-if-it-works. And then we configure webpack-dev-server to point to that index.html file.

Initial support implemented in #34 via @pauljmelia. There are a couple of other features for it still to go that are recorded in #14.