SBOM validation is failing when uploading files generated using the global tool

I am using the dotnet cyclonedx tool (https://www.nuget.org/packages/CycloneDX) to generate SBOM's using the below command
dotnet CycloneDX .\Dashboard-Web\Dashboard-Web.csproj -t -ipr

Which produces the attached SBOM however when i attempt to upload it using the Dependency Track UI it is failing with the below error

This process was working prior to my company enabling sbom validation and they are hesitant to turn it back off hence wanting to get the tool fixed.
Note I have reproduced the issue with both 3.0.5 & 3.0.6 with 3.0.6 being the latest version.
My latest SBOM using 3.0.6 can be downloaded from https://fxs.skidata.com/message/CRdyZd5fSVfGzXr7MJanII with link valid until 3rd June 2024 @mtsfoni

Problem is that<EMAIL_ADDRESS>has 2 licenses nodes
The fix is already prepared, I just hope/wait for a review of its original author, who is a very active contributor:
#301
As soon as it's merged, I am going to release new versions of the library and the generator.

Great thanks for the quick reply. Will await the fix.

thanks @mtsfoni i can confirm i can now upload SBOM's following the update. Thanks again


feat: Add original huffpost and arxiv datasets with full time resolution

Motivation
Currently we are sourcing arxiv and huffpost datasets from the wilds collection which is preprocessed and samples are binned into years. We want to have finer grained time resolution like in the original datasets. Also, we want to use submission dates rather than arxiv's update_date which is rather some arxiv internal field rather than date that has semantic meaning to a paper submission. E.g. there are a lot of papers from < 2000 that have 2007 <= update_date <= 2008 (probably arxiv imported them back then)

Thank you! I like the general binning logic, but my major comment is that we either need a README that explains necessary steps (where to download the data from) similar to CGLM or to implement the download in code (similar to wild time arxiv). If we don't actually download ourselves, we might want to rename the classes :D After that, I think we're good to merge

Makes sense! I will add a small README :)

Thanks for the review @MaxiBoether :)


Tutorial Issue

When pulling up Part 01 for the Tutorial, I can't get it to display
"Hello from 'dashboardname'"
When adding other extensions from the samples, I am unable to load up all of the extension and usually have partially broken ones appear.
Can anybody help me with this?
Thanks!

Sorry to hear that you are having problems with the tutorial and extensions. From what you describe it is hard to tell exactly what is going wrong. It could be a mismatch with the version of Tableau you are running, or a problem with the localhost web service.  I assume that you have downloaded or cloned the repo on your computer.

Are you running the latest release of Tableau 2018.2 from the beta site?
What error messages do you see when you load the extensions in Tableau?
When you run the npm install and npm start to start the localhost server, do you see error messages about files not found, etc. in the command window?

You could also try a couple of the hosted extensions from the Tableau 2018.2 beta site. Try the Clear Filters or Dynamic Parameter examples, from Dashboard Extensions. If you download the .trex files, you won't need to run a localhost web server.

Please let us know if you are still having trouble with the tutorial using an official release (2018.2 or higher). If so, please re-open and respond with the items Dave mentioned.


chore(main): release 1.8.0

:robot: I have created a release beep boop
1.8.0 (2024-04-16)
Features

🚀 Update deps (4a8cc9f)

Performance Improvements

➖ 去除冗余的配置 (f10e259)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel/viarotel.github.io/releases/tag/v1.8.0 :sunflower:


Hungarian notation

Hungarian notation does not mean what you seem to imply it means in the README.
I think what your trying to say is “Use camelCase for variable names and function parameters.”

@sheeit That is our team mistakes. I've fixed it. The list is still in process so if you find out something like that, please let us know. Thank again for your correction 👍


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/mongogrant-feedstock#3.


Error Exporting BibTex library

Debug log ID
3EBEKLG3-euc/6.7.211-7
What happened?
When I try to export my library as a BibTex file, I get a generic error message saying "Error: An error occurred while trying to export the selected file." I was using the latest version of BibTex then downloaded the older version to see if it solved the problem (it didn't). The screenshot below is from the Error Console if it's relevant. Thank you in advance. I'm in my last two weeks of writing my dissertation and panicking about Zotero breaking all of a sudden :*(

Try build 6576. If it works, please still generate a new log. Something is wrong with an attachment in your library.

Did this work for you?

Did this work for you?

Yes!! It worked! Thank you soooooooo much!
The new debug log is: JEJCU7RG-refs-euc/<IP_ADDRESS>20.6576-7

The attachment that caused the problem is not in JEJCU7RG-refs-euc/<IP_ADDRESS>20.6576-7. Can you try exporting your entire library and sending a new log?

The build I gave you is just a workaround, I don't know what the actual problem is yet, so I'd really appreciate a new log for diagnosis.

For sure, thank you so much for your help. Here is the new debug log: 9IPWQEBB-refs-euc/<IP_ADDRESS>20.6576-7

Can you see if the problem remains fixed on 6603?

It seems like it's working now! Thanks so much. I made another debug log in case it's helpful but I think it's working!
debug log:
FWEP2KHP-refs-euc/<IP_ADDRESS>20.6605-7

If it's working, I've found the error. Thanks so much for testing this. You can keep using this build, it's release-ready. I'm putting a few more finishing touches in and then I'll release a new version tomorrow or day after. You will be upgraded automatically.

A new build will drop here, but you can ignore that, it's a performance tweak.


Pricing for taking over an unmanaged azure active directory

What is the cost (pricing) involved If an admin from the partner org admin takes over an unmanaged directory or viral tenant?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd934d58-08f8-a3ca-2686-0006b0b8f74a
Version Independent ID: 84d9cab3-09b7-95ba-83ea-435ca0ccbb47
Content: Administrator takeover of an unmanaged directory - Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/domains-admin-takeover.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

@skyovi , Thanks for raising the issue. We will investigate and update you.

@skyovi There is no cost involved when you perform an administrative takeover of a viral tenant as Azure AD is a free feature. If you need any licenses for the users in your tenant, then you would have to purchase them accordingly.

@skyovi We have not heard from you in a while. We will now proceed to close this thread. If you have further questions, please tag me in the comments and I will gladly continue the conversation.


Redesign the Intro Box

We can make few changes to the intro box like
The background of India and the whole box is in the same color this doesn't impact much we can change the background of any or or remove the bg of India box
Animation is good just align it more to the right means after completing the whole animation the line will be centered to India
And we can also blur the color of highlight this will look more attractive as we just want to highlight it !
Padding of the intro box can be made to 4 vmin as it is so much close to the edges it don't look good

@GourieJagtap  Will, you like to work on these changes ?

@GourieJagtap Will, you like to work on these changes ?

Yes!

We can make few changes to the intro box like
The background of India and the whole box is in the same color this doesn't impact much we can change the background of any or or remove the bg of India box
Animation is good just align it more to the right means after completing the whole animation the line will be centered to India
And we can also blur the color of highlight this will look more attractive as we just want to highlight it !
Padding of the intro box can be made to 4 vmin as it is so much close to the edges it don't look good

Okay! I'll work on it .


How do use in Swift ?

Hi.
How do i can use your lib "PLPlayerKit" in Swift ?

Hi.
You have to create Bridging-Header and import PLPlayerKit
That is all

Thanks


Icon for HomeView

Hello :v:
It would be awesome if we could give the homeview an icon instead of it spelling out HOME. Or am i missing some feature that i can already do that?

It will have one in the next version.

Awesome!
Thanks :tada:


Update package to run with the latest package resolution changes

Purpose
Fixes ballerina-platform/ballerina-lang#32190
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests

This is addressed in #287, hence closing this PR.


Title: Enhancement of Weather-App

Which pre-existing JavaScript project will you be working on?
Weather App
Describe your enhancement/improvement
Now, you can access the 7-day weather forecast and check the temperature of your current location with a single click.
Anything you need to say to the Reviewers
No response
Add any other context or relevant screenshots about the enhancement here.
No response

@Vijayaa21 Thank you for providing your insight but it is not required as of now.

@Vijayaa21 All the best 👍🏻

I would like to work on this issue, please assign it to me.


FSharp templates not in Command Palette

I have installed the fsharp yeoman generator (https://github.com/fsprojects/generator-fsharp) by doing npm install -g generator-fsharp and this was succesful. See:

But when I try to do this with Ionide by doing:
ctrl + shift + p > F#: New project > popup

I do not see fsharp templates here.
Am i missing something?

Let's close this one and discuss it in #3 as it is probably same issue.


chore: update jsonrpsee to v0.10.1

The main motivation behind this is to solve an issue in the staking miner, remove of duplicate versions.
As bonus I removed an unused dependency in bin/node
polkadot companion: https://github.com/paritytech/polkadot/pull/5264

bot merge

bot merge


Bug in matchmaker causing relayed matches

Description

This bug appears when we want to use custom authoritative matches and matchmaking. It is easily reproducible by creating a Match module (in our case in Go, but as far as I can tell from reading the code Lua and TypeScript would behave the same) and starting a match using the matchmaker. This match cannot be joined by token but only by match id because the token generates a new match id if no match id is returned by the module.
		if !isMatchID {
			// If there was no callback or it didn't return a valid match ID always return at least a token.
			token := jwt.NewWithClaims(jwt.SigningMethodHS256, jwt.MapClaims{
				"mid": fmt.Sprintf("%v.", uuid.Must(uuid.NewV4()).String()),
				"exp": time.Now().UTC().Add(30 * time.Second).Unix(),
			})
			tokenOrMatchID, _ = token.SignedString([]byte(m.config.GetSession().EncryptionKey))
		}

This disassociates the generated match and the token. Since the token also doesn't contain a Nakama node joining a match using this token results in a newly created relayed match as tokens explicitly allow empty relayed matches.
If the the boilerplate code from the matchmaking documentation is used and a match id is returned, no token gets generated. This directly contradicts the documentation which explicitly tells you to join the matchmade match using a token.
Steps to Reproduce

Create a skeleton match module
Use boilerplate code from docs to register matchmaker matched

func MakeMatch(ctx context.Context, logger runtime.Logger, db *sql.DB, nk runtime.NakamaModule, entries []runtime.MatchmakerEntry) (string, error) {
    for _, e := range entries {
        logger.Info("Matched user '%s' named '%s'", e.GetPresence().GetUserId(), e.GetPresence().GetUsername())
        for k, v := range e.GetProperties() {
            logger.Info("Matched on '%s' value '%v'", k, v)
        }
    }

    matchId, err := nk.MatchCreate(ctx, "pingpong", map[string]interface{}{"invited": entries})
    if err != nil {
        return "", err
    }

    return matchId, nil
}

Token is empty
Return empty string in module

func MakeMatch(ctx context.Context, logger runtime.Logger, db *sql.DB, nk runtime.NakamaModule, entries []runtime.MatchmakerEntry) (string, error) {
    for _, e := range entries {
        logger.Info("Matched user '%s' named '%s'", e.GetPresence().GetUserId(), e.GetPresence().GetUsername())
        for k, v := range e.GetProperties() {
            logger.Info("Matched on '%s' value '%v'", k, v)
        }
    }

    matchId, err := nk.MatchCreate(ctx, "pingpong", map[string]interface{}{"invited": entries})
    if err != nil {
        return "", err
    }

    return "", nil
}

Token contains unrelated match id and no Nakama node. Joining the match results in non-authoritative match

Context

[ ] Unity
[ ] Unreal
[x] Other (Server issue)

Your Environment

Nakama: Built from master branch
Database: postgres
Operating System and version: <IP_ADDRESS>-microsoft-standard-WSL2

Hi @mkieweg, we've looked into this and the server behaviour is correct. Matchmaker matched client messages will contain either a match ID, or a match join token, but never both. This is expected and valid.
If the matchmaker matched hook returns a match ID, that indicates an authoritative match has been created or otherwise selected for use - the server will send that in the matchmaker matched client message instead of a token. For the purpose of matchmaker responses match IDs and match join tokens are mutually exclusive.
A matchmaker matched hook that returns an empty "" match ID is functionally equivalent to having no matchmaker matched hook at all. The result will be the server assuming you want a relayed match, and generating a token to help achieve this. In your counter-example if you create an authoritative match but then never return its ID from the hook, the server cannot know that you intend to use this match for the users that have just been matchmade.

If the the boilerplate code from the matchmaking documentation is used and a match id is returned, no token gets generated. This directly contradicts the documentation which explicitly tells you to join the matchmade match using a token.

You are however right, the documentation is not fully clear. We will improve this! 👍


overflowing-rsh-6.rs fails when run with -O

The following fails to fail:
cargo run --bin miri -- -O tests/compile-fail/overflowing-rsh-6.rs

Is this deliberate? It seems to me that overflows are still a bug, and there's no deep reason miri shouldn't also detect them in release mode. That would just be a matter of not ignoring the return value of intrinsic_overflowing.

unoptimized mir:
// WARNING: This output format is intended for human consumers only
// and is subject to change without notice. Knock yourself out.
fn main() -> () {
    let mut _0: ();                      // return pointer
    scope 1 {
        let _1: i64;                     // "_n" in scope 1 at <anon>:4:9: 4:11
    }
    let mut _2: (i64, bool);

    bb0: {
        StorageLive(_1);                 // scope 0 at <anon>:4:9: 4:11
        _2 = CheckedShr(const 1i64, const 64i32); // scope 0 at <anon>:4:14: 4:24
        assert(!(_2.1: bool), "attempt to shift right with overflow") -> bb1; // scope 0 at <anon>:4:14: 4:24
    }

    bb1: {
        _1 = (_2.0: i64);                // scope 0 at <anon>:4:14: 4:24
        _0 = ();                         // scope 1 at <anon>:3:11: 5:2
        StorageDead(_1);                 // scope 0 at <anon>:5:2: 5:2
        return;                          // scope 0 at <anon>:5:2: 5:2
    }
}

optimized mir:
// WARNING: This output format is intended for human consumers only
// and is subject to change without notice. Knock yourself out.
fn main() -> () {
    let mut _0: ();                      // return pointer
    scope 1 {
        let _1: i64;                     // "_n" in scope 1 at <anon>:4:9: 4:11
    }

    bb0: {
        StorageLive(_1);                 // scope 0 at <anon>:4:9: 4:11
        _1 = Shr(const 1i64, const 64i32); // scope 0 at <anon>:4:14: 4:24
        _0 = ();                         // scope 1 at <anon>:3:11: 5:2
        StorageDead(_1);                 // scope 0 at <anon>:5:2: 5:2
        return;                          // scope 0 at <anon>:5:2: 5:2
    }
}

Rustc emits overflowing Shr in release mode.

Right. It does that, as far as I understand, because checking for overflow incurs too much of a performance hit. In Miri, that's not the case, we have the information available anyway. So I feel like it'd make sense for miri to catch overflows even if the MIR says they are unchecked. This issue is meant to open the discussion whether others there agree.
(Btw, the wrapping_add methods are implemented with an intrinsic, so they would be unaffected by this change.)

I think we used to error on the operation itself instead of waiting for the assert to trigger. I'd be fine with this change, if a full rustc test suite run doesn't show any regressions. Or we just turn on overflow checks in miri unconditionally. So they are generated in Mir no matter what the user passes

In the case of unchecked Shr, we can know there will never be an assert as the information about whether this overflowed or not is not returned back to the program.

FWIW the reason the assert is explicit in MIR, aside from perhaps optimizing it away in some cases, is that any panicking has to be explicit for the unwinding path to be correct.
The only thing we have to be wary of, although this won't be a problem once miri is upstreamed, is that the wrapping intrinsics should not be replaced with the same primitives by MIR optimizations.

The only thing we have to be wary of, although this won't be a problem once miri is upstreamed, is that the wrapping intrinsics should not be replaced with the same primitives by MIR optimizations.

Right, that would be a problem if optimizations did that.


Updating navbar links

Fix for bug ticket:
IDVA5-1635

Updating navbar to include 'Your companies' link on verify service.
The structure of the navbar including updated flag status can be viewed here: ch-node-utils

Reflected acsp-web navbar logic under common_variables_middleware to include 'Authorised agent' link only if the user has a valid ACSP number

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


Closes #28: Version 0.3.0

Closes #28:

Documents changes to errors in CHANGELOG.md
Bumps crate version

bors r+


Minor fixes.

Minor fixes/improvements to a small number of basic algorithms.

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #91   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         100    100
  Lines        2033   2015   -18
  Branches      354    347    -7
=====================================
- Hits         2033   2015   -18

Impacted Files
Coverage Δ

...rc/algorithms/math/is-power-of-two/isPowerOfTwo.js
100% <100%> (ø)
:arrow_up:

.../math/least-common-multiple/leastCommonMultiple.js
100% <100%> (ø)
:arrow_up:

...hms/math/euclidean-algorithm/euclideanAlgorithm.js
100% <100%> (ø)
:arrow_up:

src/algorithms/sets/fisher-yates/fisherYates.js
100% <100%> (ø)
:arrow_up:

src/algorithms/math/bits/getBit.js
100% <100%> (ø)
:arrow_up:

...rithms/math/is-power-of-two/isPowerOfTwoBitwise.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bfe97...2e32dff. Read the comment docs.

Thank you for the fixes @Bruce-Feldman


🍒[Swift 6.0] Allow overriding clang++ with an environment variable

Cherry-picking: https://github.com/apple/swift-driver/pull/1605

'+' isn't allowed in environment variable names so it's impossible to set the Clang++ executable at the moment. Replace + with X so that we can set SWIFT_DRIVER_CLANGXX_EXEC to set the clang++ executable.
Fixes: rdar://128007218

Explanation: Replaces + with X in the toolchain while doing tool lookup from an environment variable because + is not allowed in valid environment variable names. This prevents us from telling the driver where to look for the clang++ binary.
Risk: Low. Only affects projects that set the SWIFT_DRIVER_CLANGXX_EXEC environment variable. Since that doesn't do anything today, that would be a silly thing to do. Otherwise, projects cannot currently set SWIFT_DRIVER_CLANG++_EXEC because that's an invalid environment variable name.
Testing: Added test to verify that the substitution is made correctly.
Fixes: rdar://128007218

@swift-ci please test


SD2.1 giving bad results on MPS

I used sd_v2.1_f16.ckpt
It works fine for 512x512 images, but it really messes the image up for any other size.
i suspect that something is unstable in attention or something.
do you know what we could do?
I used DynamicGraph.flags = [.disableMixedMPSGEMM]

also in your CKPT file, seems like you only use 23 layers in openclip, whereas many models are for 24. why so?

Because in SD v2 implementation, they always skip the last layer:
https://github.com/Stability-AI/stablediffusion/blob/main/ldm/modules/encoders/modules.py#L201
https://github.com/Stability-AI/stablediffusion/blob/main/configs/stable-diffusion/v2-inference.yaml#L67

@liuliu  some models are not working properly. eg. : https://civitai.com/models/3725/djz-jovian-skyship-v21
Evan in drawthings app it gives bas results ( even with fp32 attention ) let me know if you are albe to produce anything good with drawthings using this model


1251070 - broken link fixed

:warning: Validation status: warnings

File
Status
Preview URL
Details

Web-Apps-Server-loc/configure-office-web-apps-for-sharepoint-2013.md
:warning:Warning
View
Details

Web-Apps-Server-loc/configure-office-web-apps-for-sharepoint-2013.md

Line 136: [Warning] Invalid file link:(~/deploy-office-web-apps-server#implantar-um-farm-de-servidor-%C3%BAnico-do-servidor-do-office-web-apps-que-usa-https).
Line 136: [Warning] Invalid file link:(~/deploy-office-web-apps-server#implantar-um-farm-com-m%C3%BAltiplos-servidores-e-carga-equilibrada-do-servidor-do-office-web-apps-que-usa-https).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

closing PR without merging as issue has been fixed on another commit.


MacOS Mojave, sidebar background color issue

See attached screenshot. If I disable the sidebar, list of emails panel (whatever's the leftmost pane) gets this issue.
If the app doesn't have the focus, the color scheme works as expected (just as in High Sierra etc.)

Update: it seems to be transparent -- I missed it. Here's another pic:

Maybe I start disabling translucency. I think Apple did that on their apps too.


added CAU

added South Korean Chung-Ang University

@tchaivicon I am sorry, the domain cau.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


feat: add OpenRouter AI provider support

Adds support for openrouter.ai as a new provider, allowing users to access various AI models

Appreciate the addition :)
I'll merge it once I get back to my laptop in a few days

Hey, can you rebase your PR with main and resolve the conflicts?

Done 👍

Can you share the output of these commands to verify that the change is working as expected
cargo r -- -p "openrouter" -k "your-key" explain HEAD
cargo r -- -p "openrouter" -m "invalid-model" -k "your-key" explain HEAD

cargo r -- -p "openrouter" -k "sk-or-v1-xxxx...xxxx" explain HEAD

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
     Running `target/debug/lumen -p openrouter -k sk-or-v1-xxxx...xxxx explain HEAD`
┄Entity: Commit

commit c20307eb1b95d05d41d867e40f43c371889e6e52 | lkonga<EMAIL_ADDRESS>| 2024-11-16 23:02:16

┄┄docs: update OpenRouter model information in README

✓ Done
Core Changes:

• Simplified the OpenRouter model reference in README by replacing specific model listings with a single link to all
  models
• Changed from separate Anthropic/OpenAI model links to a unified model list

Impact:

• More maintainable documentation as it doesn't need updates when specific models change
• Users now have a cleaner, single reference point to view all available OpenRouter models

cargo r -- -p "openrouter" -m "invalid-model" -k "sk-or-v1-xxxx...xxxx" explain HEAD

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/lumen -p openrouter -m invalid-model -k sk-or-v1-xxxx...xxxx explain HEAD`
┄Entity: Commit

commit c20307eb1b95d05d41d867e40f43c371889e6e52 | lkonga<EMAIL_ADDRESS>| 2024-11-16 23:02:16

┄┄docs: update OpenRouter model information in README

error: API request failed with status code 400 Bad Request: invalid-model is not a valid model ID


Added Scene path inference for LoadSceneAttribute & BuildSceneAttribute

Enhanced flexibility of LoadSceneAttribute & BuildSceneAttribute by allowing scene paths to be also fully inferred from the CallerFilePath.
Should the value path be omitted/null/empty from the attribute, the scene path will be derived from the test file name.
/// (e.g., Asset/Tests/ScreenshotTest.cs will load ./ScreenshotTest.unity)
I was not sure if you would've preferred this to be implemented differently but I made a pull request with this feature in case this is something you would see as useful for others. Please feel free to request some changes (or just refuse).

@faviann san, please rebase onto v0.7.3

I rebased on the most recent master branch. If there is anything else needed you feel free to request additional changes.
I will also be more careful to not let silly errors slip by.


Rotation Gizmo Input Bug

Me and @GlynLeine discovered a little issue with the Rotation Gizmo that struck us as rather odd
This is the issue we encountered:

As you can see we are only able to use the gizmo from the parts we cannot actually see.
We made an adjusment to line number 1661 of ImGuizmo.cpp which seems to fix this issue:
//was
if (Dot(Normalized(localPos), gContext.mRayVector) > FLT_EPSILON)
//now
if (Dot(Normalized(localPos), gContext.mRayVector) < -FLT_EPSILON)

As demonstrated here:

gContext.mRayVector is the world vector corresponding to the mouse position on screen.
It depends on the view and projection matrix. I'm wondering if the projection matrix you use is inverting that vector.
https://github.com/CedricGuillemet/ImGuizmo/blob/6c5ed51d41b3dff4a5d9b8125161dc5d3171dac8/ImGuizmo.cpp#L726
Does your change work in the sample app?
Do you compute differently your projection matrix as I'm doing?

The fix does in fact not work with the sample app, it produces the exact reverse result. I'm gonna check what we are doing differently. Maybe this can be a configuration option? Since as far as I can tell our Projection+View Matrix work normally in every other way.

gContext.mRayVector is the world vector corresponding to the mouse position on screen.
It depends on the view and projection matrix. I'm wondering if the projection matrix you use is inverting that vector.
https://github.com/CedricGuillemet/ImGuizmo/blob/6c5ed51d41b3dff4a5d9b8125161dc5d3171dac8/ImGuizmo.cpp#L726
Does your change work in the sample app?
Do you compute differently your projection matrix as I'm doing?

We are using a left handed coordinate system with an inversed depth buffer that ranges from 0-1 in logarithmic fashion. we do so much like any other 3D game engine to improve the precision in the depth buffer near the camera.

I think the gizmo is not reliable enough on left/right hand and different depth buffer technics. I'll try to improve that. In the mean time, you can use your workaround. Is your view/projection matrix computation available as opensource? Can you copy/paste it so I'll try with it?

Our projection matrix is calculated using GLM with the following setup:
perspective(deg2rad(fov * ratio), ratio, farz, nearz)

Where ratio is the aspect ratio and fov the horizontal field of view.
Our view matrix is created using GLM as well like this:
inverse(translate(Translation) * toMat4(Orientation) * scale(Scale))

With orientation being a quaternion.
For all GLM calls the following settings are defined:
#define GLM_FORCE_SWIZZLE
#define GLM_ENABLE_EXPERIMENTAL
#define GLM_FORCE_RADIANS
#define GLM_FORCE_DEPTH_ZERO_TO_ONE
#define GLM_FORCE_LEFT_HANDED

The GLM version we use is version 4.2
I hope this is enough information for you to test? Otherwise, you can find all our source code at: https://github.com/Legion-Engine/Legion-Engine

Thanks! I'll take a look this weekend.

Nice, good luck!

https://github.com/Legion-Engine/Legion-Engine/tree/feature/basic-imgui-gui/legion/engine/rendering

I can't repro :( can you please dump the values of the view and projection matrices please?

Sure thing, here you go:
View-Matrix:
 0.90544575    0.16736053   0.39007503 -0.0
 1.4901163e-08 0.91898674  -0.39428857  0.0
-0.4244621     0.35700688   0.83209264 -0.0
 0.53988063   -0.112123996  7.347309    1.0

Projection-Matrix:
 1.545456 0.0       0.0        0.0
 0.0      2.7474775 0.0        0.0
 0.0      0.0      -0.00010001 1.0
 0.0      0.0       0.10001    0.0

I've added and pushed the logging functionality to this branch of Legion-Engine, if you press the Button that reads "Log-Matrices!" you can generate more examples if needed

Should be good! https://github.com/CedricGuillemet/ImGuizmo/pull/149 Let me now if you still have issues :)


Docs update on NUnit test framework

The task is to update Wiki with informations regarding .NET testing to cover only NUnit test framework.

 Update docs on .NET testing

Resolved as https://github.com/spectre-team/spectre/wiki/CSharp


Update README

Add a new cool looking steam workshop badge (it's not a new line, the diff makes it show like it is)
Add a quick link to the Discord guild because why not

Oops, this tried to merge into the wrong one! Ahh!


Kledex 2.5.1 - Event handlers get called twice

Hi,
I'm using Kledex 2.5.1 with a .net core 3.1 app. I use the event sourcing & cqrs features.
Everything is working fine except one thing : the event handlers are called twice.
So far, I had only one event handler, so I thought I would create another event handler to check whether the behaviour was the same or not. Both event handlers are called twice - they are called at the same time.
Have you experienced this bug before ? Or am I missing something here ?
Thanks !

Drop it, it was in the Startup.cs inside the AddKledex config method.
And someone already had this 'issue'... so, my bad !

No problem :-)


Fix GAPIC headers

The issues with missing gccl/ and stale gapic/ version (0.1.0) needs to be fixed. This was observed with Vision. Its x-goog-api-client header is "gl-node/6.6.0 gapic/0.1.0 gax/0.12.3 grpc/1.2.4".
Then please refresh all GAPICs, and publish their associated packages to npmjs.com.
After that, please update any affect cells in the HTTP header matrix, so I can review (I think Vision is the only API using GAPIC in that matrix).

Just sent up a PR for Vision. Will do the rest once my Artman changes are merged.

Just merged a new GAPIC for Vision, which @stephenplusplus is about to release.
Dropping to P2, but will regenerate all GAPICs soon (after Artman changes are merged).

Released<EMAIL_ADDRESS>with the change.

@stephenplusplus #2228 needs to be released to add the 'gccl' header too!

Sorry, that was my fault; I did not grok that the gccl was not there, and I should have.

<EMAIL_ADDRESS>published with those.

@bjwatson @lukesneeringer @landrito is this resolved?

I believe so.


updates for Go 1.16

Update 1.13, 1.14 and 1.15 Dockerfiles
add 1.16 Dockerfile

Signed-off-by: Sergio Leunissen<EMAIL_ADDRESS>

The PR says you updated the "1.13, 1.14 and 1.15" Dockerfiles, but I'm not seeing that in the commits. Can you confirm?


Epic: kpt should support variant constructor pattern

This is an umbrella issue to track all the sub tasks related to variant constructor pattern. Refer to original issue for details.

[x] Finalize the design for context generation hook
[ ] publish go/kpt-variant-constructor-pattern in kpt repo [in progress]
[x] set-namespace to support use-case for tenant provisioning
[x] Implement in support for including meta/local resources by default in fn render
[x] Implement in support for including meta/local resources by default in fn eval
[x] Implement context generation pipeline
[ ] Vendor source-gcloud-config function as builtin
[x] Audit all functions in kpt-function-catalog to ensure they support variant construction by default
[x] Document the variant constructor pattern with examples and guides
[ ] Implement source-gcloud-config function in the catalog in progress

We have completed all the items that we scoped for this epic. so closing this one out.


[BUG] - SCSS Module styles for slots are overridden by TailwindCSS classes in production

NextUI Version
2.6.8
Describe the bug
I am using Next UI and trying to override styles for a component using the slots API as documented. My project uses SCSS Modules alongside TailwindCSS. Locally, everything works as expected, and my SCSS class takes precedence. However, in the production build, the TailwindCSS classes have higher priority and override my SCSS styles because they appear later in the final CSS output.
Actual Behavior
In the production build, TailwindCSS classes are applied after the SCSS module styles, causing the SCSS styles to be overridden.
Environment
Next UI version: 2.6.8
Next.js version: 15.0.4
TailwindCSS version: 3.4.16
Node.js version: 18.18.2
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Create a Next.js project with Next UI, TailwindCSS or use npx create-next-app -e https://github.com/nextui-org/next-app-template as recomended.
Override a Next UI component's slot with a class from an SCSS module.
// Input.tsx

import styles from './Input.module.scss';
<Input
      aria-label="Search"
      classNames={{
        inputWrapper: styles.inputWrapper,
      }}
      labelPlacement="outside"
      placeholder="Search..."
      type="search"
    />

// Input.module.scss
.inputWrapper {
  background: red;
  padding: 40px;
}

In development mode the styles work as expected, and the SCSS class has higher specificity.
In production mode the TailwindCSS styles appear lower in the compiled CSS output and override the SCSS class.
Expected behavior
The SCSS module styles applied via slots should take precedence over TailwindCSS classes in both development and production modes.
Screenshots or Videos
No response
Operating System Version
macOS, windows
Browser
Chrome

Hi @ArtKira31, I reproduced this problem locally and found that it is not a bug in NextUI. You can try importing the SCSS module globally to make it work.


Issue with robyn_refresh Function in v3.11.1 - fails when creating 2nd refresh model

Project Robyn
Describe issue
I encountered an issue with the robyn_refresh function in the latest version, v3.11.1. When creating a second refresh model, Robyn failed to create report_actual_fitted and report_decomposition images. This issue did not occur with the previous version, v3.10.4.
Provide reproducible example
*Using demo data
Error message is as follows
>> Plotting refresh results for chain: 1_16_3 > 1_72_6 > 1_102_7
Error in dplyr::tibble(solID = names(chainData), window_start = as.Date(unlist(lapply(chainData,  :
  Tibble columns must have compatible sizes.
• Size 3: Existing data.
• Size 2: Column `duration`.
ℹ Only values of size one are recycled.
>>> Exporting refresh CSVs into directory: /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/

Environment & Robyn version
R version: R version 4.4.0 (2024-04-24)
Robyn version: <IP_ADDRESS>00

@gufengzhou This is the issue we talked offline.
@laresbernardo Please take a look above!

All of log
> json_file_rf1 <- "~/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/RobynModel-1_72_6.json"
> RobynRefresh <- robyn_refresh(
+   json_file = json_file_rf1,
+   dt_input = dt_simulated_weekly,
+   dt_holidays = dt_prophet_holidays,
+   refresh_steps = 7,
+   refresh_iters = 1000, # 1k is an estimation
+   refresh_trials = 1
+ )
>>> Recreating 1_72_6
Imported JSON file successfully: ~/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/RobynModel-1_72_6.json
>> Running feature engineering...
Input data has 208 weeks in total: 2015-11-23 to 2019-11-11
Refresh #1 model is built on rolling window of 157 week: 2016-02-22 to 2019-02-18
Rolling window moving forward: 7 weeks
>>> Calculating response curves for all models' media variables (5)...
Successfully recreated model ID: 1_72_6

>>> Building refresh model #2 in manual mode
>>> New bounds freedom: 4.46%
>> Running feature engineering...
Input data has 208 weeks in total: 2015-11-23 to 2019-11-11
Refresh #2 model is built on rolling window of 157 week: 2016-04-11 to 2019-04-08
Rolling window moving forward: 7 weeks
Fitting time series with all available data...
Using geometric adstocking with 20 hyperparameters (19 to iterate + 1 fixed) on 9 cores
>>> Starting 1 trials with 1000 iterations each using TwoPointsDE nevergrad algorithm...
  Running trial 1 of 1
  |=============================================================| 100%
  Finished in 0.4 mins
- DECOMP.RSSD converged<EMAIL_ADDRESS>0.01 <= 0.015 &<EMAIL_ADDRESS>0.021 <= 0.03
- NRMSE converged<EMAIL_ADDRESS>0.00053 <= 0.0014 &<EMAIL_ADDRESS>0.051 <= 0.051
Total run time: 0.41 mins
>>> Running Pareto calculations for 1000 models on auto fronts...
>> Automatically selected 1 Pareto-fronts to contain at least 100 pareto-optimal models (133)
>>> Calculating response curves for all models' media variables (665)...
>> Pareto-Front: 1 [133 models]
 00:00:09 [====================================] 100% | 133
Creating directory for outputs: /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/
>>> Calculating clusters for model selection using Pareto fronts...
>> Auto selected k = 3 (clusters) based on minimum WSS variance of 6%
>>> Collecting 133 pareto-optimum results into: /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/
>> Exporting general plots into directory...
>> Exporting pareto results as CSVs into directory...
>>> Exporting pareto one-pagers into directory...
Exporting charts as: /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/1_102_7.png
>> Exported models as /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/RobynModel-models.json
Selected model ID: 1_102_7 for refresh model #2 based on the smallest DECOMP.RSSD error
>> Exported 1_102_7 as /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/RobynModel-1_102_7.json
>> Plotting refresh results for chain: 1_16_3 > 1_72_6 > 1_102_7
Error in dplyr::tibble(solID = names(chainData), window_start = as.Date(unlist(lapply(chainData,  :
  Tibble columns must have compatible sizes.
• Size 3: Existing data.
• Size 2: Column `duration`.
ℹ Only values of size one are recycled.
>>> Exporting refresh CSVs into directory: /Users/yuyatanaka/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/Robyn_202408052355_rf2/

Code I used
rm(list = ls())
remotes::install_github("facebookexperimental/Robyn/R")
# remotes::install_github("facebookexperimental/Robyn/R", ref = "v3.10.4", force = TRUE)
library(Robyn)
packageVersion("Robyn")

Sys.setenv(R_FUTURE_FORK_ENABLE = "true")
options(future.fork.enable = TRUE)
create_files <- TRUE

data("dt_simulated_weekly")
data("dt_prophet_holidays")
robyn_directory <- "~/Desktop"

InputCollect <- robyn_inputs(
  dt_input = dt_simulated_weekly,
  dt_holidays = dt_prophet_holidays,
  date_var = "DATE", # date format must be "2020-01-01"
  dep_var = "revenue", # there should be only one dependent variable
  dep_var_type = "revenue", # "revenue" (ROI) or "conversion" (CPA)
  prophet_vars = c("trend", "season", "holiday"), # "trend","season", "weekday" & "holiday"
  prophet_country = "DE", # input country code. Check: dt_prophet_holidays
  context_vars = c("competitor_sales_B", "events"), # e.g. competitors, discount, unemployment etc
  paid_media_spends = c("tv_S", "ooh_S", "print_S", "facebook_S", "search_S"), # mandatory input
  paid_media_vars = c("tv_S", "ooh_S", "print_S", "facebook_I", "search_clicks_P"), # mandatory.
  # paid_media_vars must have same order as paid_media_spends. Use media exposure metrics like
  # impressions, GRP etc. If not applicable, use spend instead.
  organic_vars = "newsletter", # marketing activity without media spend
  # factor_vars = c("events"), # force variables in context_vars or organic_vars to be categorical
  window_start = "2016-01-01",
  window_end = "2018-12-31",
  adstock = "geometric" # geometric, weibull_cdf or weibull_pdf.
)

hyperparameters <- list(
  facebook_S_alphas = c(0.5, 3),
  facebook_S_gammas = c(0.3, 1),
  facebook_S_thetas = c(0, 0.3),
  print_S_alphas = c(0.5, 3),
  print_S_gammas = c(0.3, 1),
  print_S_thetas = c(0.1, 0.4),
  tv_S_alphas = c(0.5, 3),
  tv_S_gammas = c(0.3, 1),
  tv_S_thetas = c(0.3, 0.8),
  search_S_alphas = c(0.5, 3),
  search_S_gammas = c(0.3, 1),
  search_S_thetas = c(0, 0.3),
  ooh_S_alphas = c(0.5, 3),
  ooh_S_gammas = c(0.3, 1),
  ooh_S_thetas = c(0.1, 0.4),
  newsletter_alphas = c(0.5, 3),
  newsletter_gammas = c(0.3, 1),
  newsletter_thetas = c(0.1, 0.4),
  train_size = c(0.5, 0.8)
)

InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters)

OutputModels <- robyn_run(
  InputCollect = InputCollect, # feed in all model specification
  cores = NULL, # NULL defaults to (max available - 1)
  iterations = 200, # 2000 recommended for the dummy dataset with no calibration
  trials = 5, # 5 recommended for the dummy dataset
  ts_validation = FALSE, # 3-way-split time series for NRMSE validation.
  add_penalty_factor = FALSE # Experimental feature. Use with caution.
)

OutputCollect <- robyn_outputs(
  InputCollect, OutputModels,
  pareto_fronts = "auto", # automatically pick how many pareto-fronts to fill min_candidates (100)
  # min_candidates = 100, # top pareto models for clustering. Default to 100
  # calibration_constraint = 0.1, # range c(0.01, 0.1) & default at 0.1
  csv_out = "pareto", # "pareto", "all", or NULL (for none)
  clusters = TRUE, # Set to TRUE to cluster similar models by ROAS. See ?robyn_clusters
  export = create_files, # this will create files locally
  plot_folder = robyn_directory, # path for plots exports and files creation
  plot_pareto = create_files # Set to FALSE to deactivate plotting and saving model one-pagers
)
print(OutputCollect)

select_model <- "1_16_3"
ExportedModel <- robyn_write(InputCollect, OutputCollect, select_model, export = create_files)

json_file <- "~/Desktop/Robyn_202408052352_init/RobynModel-1_16_3.json"
RobynRefresh <- robyn_refresh(
  json_file = json_file,
  dt_input = dt_simulated_weekly,
  dt_holidays = dt_prophet_holidays,
  refresh_steps = 7,
  refresh_iters = 1000, # 1k is an estimation
  refresh_trials = 1
)

json_file_rf1 <- "~/Desktop/Robyn_202408052352_init/Robyn_202408052353_rf1/RobynModel-1_72_6.json"
RobynRefresh <- robyn_refresh(
  json_file = json_file_rf1,
  dt_input = dt_simulated_weekly,
  dt_holidays = dt_prophet_holidays,
  refresh_steps = 7,
  refresh_iters = 1000, # 1k is an estimation
  refresh_trials = 1
)

Hi @yu-ya-tanaka thanks for letting me know. I've just deployed the fix in branch bl04. I've tested it for the first refresh and second and works OK. I even tested a 3rd refresh and ran successfully with correct plots.
If you'd like to test it before I merge it to main, you can install it with Robyn::robyn_update(ref = "bl04"), refresh your R session, and test.
Please, do let me know so I can do a PR.

Hi @laresbernardo , Thanks for the quick fix. I was able to run it successfully after installing the updated version with Robyn::robyn_update(ref = "bl04")!


OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed. Error loading "C:\Users\Toby\Desktop\RVC\RVC1006Nvidia\runtime\lib\site-packages\torch\lib\cublas64_11.dll" or one of its dependencies.

Whenever I run go-realtime-gui I get this error:
C:\Users\Toby\Desktop\RVC\RVC1006Nvidia>runtime\python.exe guiv1.py
Traceback (most recent call last):
File "C:\Users\Toby\Desktop\RVC\RVC1006Nvidia\gui_v1.py", line 59, in
import torch
File "C:\Users\Toby\Desktop\RVC\RVC1006Nvidia\runtime\lib\site-packages\torch_init.py", line 122, in
raise err
OSError: [WinError 1114] A dynamic link library (DLL) initialization routine failed. Error loading "C:\Users\Toby\Desktop\RVC\RVC1006Nvidia\runtime\lib\site-packages\torch\lib\cublas64_11.dll" or one of its dependencies.
I have CUDA 11.8 installed with Pytorch 2.3.0. I've added environmental variables for CUDA bin and libnvvp. I've also tried reinstalling my drivers, Python and Cuda.

Can you tell me the environment of your device, it sometimes happen if the CPU is too old

it was working just fine for me yesterday before all of a sudden, torch died.


Video calls redirected to desktop browser in 2.0

Hi, I'm not sure if this is the intended functionality of the app, but whenever I video call someone the desktop browser is opened and I have to log in and make the call there instead of the desktop messenger app.

Ho thanks for reporting. It will be fixed.

Hey, try the latest version: https://github.com/aluxian/Messenger-for-Desktop/releases


Fix potential NPE and missing maxRequestLength enforcement

Motivation:
When there is no service that matches the request path,
HttpServerHandler does not initialize a DecodedHttpRequest with a
ServiceRequestContext because it cannot create a context for a
non-existent service. This leaves DecodedHttpRequest.ctx to be null, and
attempting to access it may result in NPE.
Modification:

Use defaultMaxRequestLength when DecodedHttpRequest.ctx is not
available
Disallow sending beyond defaultMaxRequestLength if the server
responded already on a request to a non-existent service
Ignore an empty HTTP/2 DATA frame so that the Subscriber always gets a
non-empty HttpData
Close the stream instead of sending a GOAWAY frame when a client sends
too large content, so that other streams are not interrupted

Do not send a GOAWAY frame when received the RST_STREAM with unknown
stream ID if it may be just a timing issue.

Result:

Robustness
Ill-behaving client cannot send more than defaultMaxRequestLength

Current coverage is 64.46% (diff: 75.38%)

Merging #231 into master will increase coverage by 0.16%

@@             master       #231   diff @@
==========================================
  Files           276        276
  Lines         10676      10703    +27
  Methods           0          0
  Messages          0          0
  Branches       1546       1556    +10
==========================================
+ Hits           6865       6900    +35
+ Misses         3069       3058    -11
- Partials        742        745     +3

Powered by Codecov. Last update a141ee4...2bbc3cf


[Issue]: Butcher & Fish Crash

Description of the bug/crash
Simply crashed when loading the game.
[ERROR] First anim file needs to be non-null. ButcherStationComplete
(First line of the first error in previous log file)
Steps To Reproduce
Load the game?
Player.log
Player-prev.log

After examining the log, I see that a) your game is trying to download an old version of the mod and b) the mod is semi-installed. some files are missing.
You need to reinstall the mod or update it forcibly.
Throw away the Mod Manager by Ony.
Use the Mod Updater.
Click on this button next to the mod to force the update it.

The mod updater is broken.
Ony's mod manager contains an updater within it.
It shows all mods now fully up to date and has properly updated all of them except for yours I guess. Rather bizarre that it failed on one mod.


Russian locale is unreasonably big

person.json for russian locale is oversized. Compare his 158 klines with 6 klines in english version.
Rapid benchmarking
#!/usr/bin/env python3

from mimesis import Person
import time

def run_test(locale, n):
    start_time = time.time()
    gen = Person(locale)
    for i in range(0, n):
        _ = gen.last_name()
    end_time = time.time()
    print('%s: %d operations, %f seconds' % (locale, n, end_time - start_time))

N = 1000000
run_test('ru', N)
run_test('en', N)

shows such results
ru: 1000000 operations, 8.939918 seconds
en: 1000000 operations, 1.817508 seconds

Dictionaries need to be washed.

Yeah, the names and surnames should be updated for sure. This data was collected from the open resources and they weren't checked.


cache the most common search query (per instance)

One remark from my side: the cache is per instance, potentially adding inconsistency because a user hits a random instance for every request. As a hot fix I would not care, long term the cache should be on search service.

@maartenba has been my main concern too. Issue NuGet/Home#735 tracks it. Also, client cache expiration is twice the server cache expiration and still relatively short-lived. But I agree, service must cache it as well and ideally no per-instance cache on gallery. Consider it a short-term fix to tremendously reduce load on search service.

:shipit:


LeadConversion ApexDoc and some class cleanup

Closes #1308

Can an admin approve this request for build?

mrbelvedere: approved

OK, build is started.  You can view status at http://ci.salesforcefoundation.org/job/Cumulus_feature_ext/66.  If you get a 404, please try again later as the build might be queued.  I will update the build status on the pull request when the build is done

success: The build succeeded!, view the build at http://ci.salesforcefoundation.org/job/Cumulus_feature_ext/66/

success: The build succeeded!, view the build at http://ci.salesforcefoundation.org/job/Cumulus_feature_ext/66/

@davidhabib or @ceiroa whenever you have a moment, this is just class comments, ready to go

or @njjc too :)

Only if someone will get mine first which has been waiting for days!  I
can't get the build to run it!
On Jan 25, 2015, at 10:19 AM, Kevin Bromer<EMAIL_ADDRESS>wrote:
@davidhabib https://github.com/davidhabib or @ceiroa
https://github.com/ceiroa whenever you have a moment, this is just class
comments, ready to go
—
Reply to this email directly or view it on GitHub
https://github.com/SalesforceFoundation/Cumulus/pull/1309#issuecomment-71384302
.

@davidhabib Its not building because the classes aren't implementing the new interface method (getHelpText()) that they need to.  The implementing classes of that interface (the three verification services) need to provide an implementation of that method


[BUG]: Border Glow Button: Remove Framer Motion

Description 📝
We are using Framer Motion for hover and tap scaling. this can be done using pure tailwind.
Link 🔗
https://syntaxui.com/components/button/border-glow-button
Screenshots 📸
n/a

I think it is an easy fix, I will take a look into it


Add gRPC adhoc config protobuf

Only small changes to default port and to indicate that we're dealing with the gRPC :authority header.

Codecov Report

Merging #71 into feature/grpc-adhoc-rules will decrease coverage by 0.16%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           feature/grpc-adhoc-rules      #71      +/-   ##
============================================================
- Coverage                     44.06%   43.89%   -0.17%
============================================================
  Files                            41       41
  Lines                          2376     2376
============================================================
- Hits                           1047     1043       -4
- Misses                         1263     1266       +3
- Partials                         66       67       +1

Impacted Files
Coverage Δ

lib/resolvers/k8s/streamer.go
68.42% <0%> (-7.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356621f...7474081. Read the comment docs.


Clarify the documentation of the Sampler class

Format code in python code block, add missing sample_ids in the call to next_inputs(...), call cell(...) instead of cell.call(...) so the cell gets built if necessary (this makes it easier to take the code example and actually try it out), for example:
import tensorflow_addons as tfa
import tensorflow as tf
from tensorflow import keras

input_tensors = tf.constant([[[1., 2.], [4., 3.], [6., 5.]],
                             [[7., 8.], [10., 9.], [11., 12.]]])
sampler = tfa.seq2seq.TrainingSampler()
(initial_finished, initial_inputs) = sampler.initialize(input_tensors)
cell = keras.layers.LSTMCell(4)
cell_input = initial_inputs
cell_state = cell.get_initial_state(batch_size=len(input_tensors),
                                    dtype=input_tensors.dtype)
max_output_length = input_tensors.shape[1]
for time_step in range(max_output_length):
  cell_output, cell_state = cell(cell_input, cell_state)
  sample_ids = sampler.sample(time_step, cell_output, cell_state)
  (finished, cell_input, cell_state) = sampler.next_inputs(
      time_step, cell_output, cell_state, sample_ids)
  if tf.reduce_all(finished):
    break

Thanks for merging.


Catch all swift services for restarts

When configs change or when package changes, we want all the swift
services to restart. These were missing.
(Looking for help on swift object. Which services are tied to which config files?)

@j2sol We need to add the trigger upgrade block to swift-proxy role as well for that service to recycle.

swift-proxy restart was done in an earlier PR. https://github.com/blueboxgroup/ursula/blob/master/roles/swift-proxy/tasks/main.yml#L17-L23

:+1:


Added autocorrectArg config option so that users can run RuboCop with --auto-correct-all (-A)

Hi, thanks for maintaining this! I've been using a fork of this extension for a long time, where I made it possible to configure the auto-correct argument. Instead of --auto-correct, I like to run it with --auto-correct-all. My actual setting is:
"ruby.rubocop.autocorrectArg": "--except Lint/UnusedMethodArgument,Lint/UnusedBlockArgument --auto-correct-all",

So that it doesn't delete unused arguments or prepend an underscore.
Thanks!

Thank you! I'm gonna do a quick check and merge/release it :)

According to the docs (https://docs.rubocop.org/rubocop/usage/autocorrect.html), the correct or current usage is --autocorrect and --autocorrect-all without the extra dash between auto and correct. Can you please explain why you use the versions with the dash in between?

Sorry I was using an older version of Rubocop (0.93.1), where rubocop -h returns:
    -a, --auto-correct               Auto-correct offenses (only when it's safe).
        --safe-auto-correct          (same, deprecated)
    -A, --auto-correct-all           Auto-correct offenses (safe and unsafe)

Rubocop 1.56.0 returns:
    -a, --autocorrect                Autocorrect offenses (only when it's safe).
        --auto-correct               (same, deprecated)
        --safe-auto-correct          (same, deprecated)
    -A, --autocorrect-all            Autocorrect offenses (safe and unsafe).
        --auto-correct-all           (same, deprecated)

Should probably use -A to make it work with any version

I've updated it to use --autocorrect and --autocorrect-all. (I think this PR is even more useful since it allows people to use older versions of Rubocop.)

I'm sorry, this one slipped off my list. Looks okay to me!


add --fetch-all option

One drawback of using this compared to submodules is:

It's often nice to be able to back up your entire project, without relying on external repositories still existing. With submodules it's easy to do a recursive clone of all submodules, and then e.g. zip up the entire directory. Today this isn't possible with zig-fetch unless you build the project, too, which is not ideal.
I've heard this same desire/feedback from distro package maintainers ("the build system downloading things is concerning, can you ensure releases include everything needed to build from scratch?")

If zig-fetch had a --fetch-all flag, which worked recursively on all dependencies that may use fetch.zig themselves (without actually building the project), I think that'd solve this requirement.

I think this one can be split into two parts:

define how recursive dependencies work
provide a flag (fetch-only, I'm thinking) that is the opposite of fetch-skip, and will only do the fetch step

Hey there! As of https://github.com/bootradev/zig-fetch/commit/bebce6cf40499c9d42ae1c60d22aca16f1004994, recursive fetching and the additional fetch build options should resolve this issue.
In particular:
There are now three build options you can pass into zig build.

fetch-skip - skips fetching entirely
fetch-only - only fetches, doesn't build
fetch-force - forces fetching to happen, even if the dependencies exist in the cache

Additionally, fetching is now recursive - if a dependency is using zig-fetch, it will be built with Dfetch-only=true during the fetch phase.
Please let me know if this satisfies the issue! Thanks again for filing!

I'm going to go ahead and close the issue - feel free to reopen it if you have unresolved concerns!


fixed channel compat: "cache tag indices" errors since we apply 4x even without data

solution looks like itll have to be weird. Add init.vi which calls parent method after pre-initing cached indices to appropriate type for child class.

C:\Program Files (x86)\National Instruments\LabVIEW 2013\vi.lib\NI\Tag Bus Data Framework\fixed module parent\module\execution\cache tag indices.vi
wire cached indices into compat function -- input was not required

woops, wrong location -> https://github.com/TBDFramework/TagBusSampleProjects/issues/5


Ast serde

Summary
Serializing and deserializing ASTs maintaining all information even after compilation into a flat form that is json serializable
Test Plan
unit tests

[ ] PR has an associated issue: #
[x] make check passes
[x] make test shows 100% unit test coverage

@shangyian

Thanks for adding this! Have you done any profiling to see how long the deserialization takes? I can get you some examples of huge queries if needed.

Just ran some to get an idea:
parsing all the spark tpcds spark queries:
3.53 s ± 23.9 ms per loop
serializing all tpcds spark queries:
83.1 ms ± 1.76 ms per loop
deserializing them:
31.8 µs ± 950 ns per loop

@CircArgs Hmm, actually I tried this with one of our use cases -- specifically some metrics that depend on several layers of transforms, each of which have fairly nested subqueries. For those metrics, I serialized the compiled query AST and then deserialized it, but it takes a long time to deserialize (more than five minutes per metric). Maybe there's something else going on, but parsing and recompiling is faster.

@shangyian I can hold off on this for now then. I wonder if there's a big distinction with just serializing/de non-compiled queries vs compiled queries. My timings were all non-compiled

@CircArgs Maybe it's because some compiled queries, if they're pulling together many layers of transforms, can be huge. But I would still expect this to be faster than actually having to compile the queries. 🤔
On that thought, we also need to make the queries built more efficient / readable by removing all the columns that aren't used.


Fixes for Example 56 and AccelerationStructure AssetConverter

Improving Feature/Extension Selection and Report API
Format Promotion and Image Upload Utility Improvements
Maintenance and general plumbing

Examples

[ ] Finalize Porting Example 0.ImportanceSampling

Fixes

[ ] Screenshot Changes

[ ] wait semaphore (https://github.com/Devsh-Graphics-Programming/Nabla/pull/219#discussion_r800543586)
[ ] add convert filter
[ ] add flip image option
[ ] dst access mask (https://github.com/Devsh-Graphics-Programming/Nabla/pull/219#discussion_r800546866)

[ ] freeCommandBuffers_impl (see this)
[ ] drawParameters extention and fix for Vulkan and GLES (https://discord.com/channels/593902898015109131/932586232591024128/934485710193459251)
[ ] Improve Features Selection API and Report (link to issue)
[ ] CGLTF DerivativeMap normalization factor and builtin shader changes (consider normalization + push_constants in a nice struct)
[ ] Const-Correctness of IGPURenderpassIndependentPipeline constructor parameters
[ ] Image Upload Utility

[ ] Convert to Format and Copy Filter instead of manual
[ ] Improve code by using an Iterator that gives you the next region to copy based on available memory
[ ] Utility for calculating image data size in Asset namespace + other functions that may be useful

[ ] Format Promotion (link to issue)
[ ] OpenGLES Extensions that allow more formats

https://discord.com/channels/593902898015109131/942802829918232576/942810567624757288

[ ]  Assert in updateBufferRangeViaStagingBuffer that the commandbuffer was begun with EU_ONE_TIME_SUBMIT_BIT

Features and Extension API

[ ] LogicalDevice function to query Enabled Features/Extension
[ ] move getExtraGLSLDefines() to ILogicalDevice and Implement for Vulkan
[ ] https://discord.com/channels/593902898015109131/936526907648925706/972634976422076476

Edits after Buffer API Changes:

[ ] Fix Ex48 on Vulkan (use utilities downstreaming buffer to download data instead of multiple huge buffers)

Acceleration Structures

[ ] Compaction Example and in AssetConverter
[ ] Use bitflags for accelerationStructure flags now

old tasks, taken by others

[ ] getSizedOpenGLFormatFromOurFormat -> cache formats, and implement format feature functions for GL

(https://github.com/Devsh-Graphics-Programming/Nabla/pull/160#discussion_r801454717)
Swapchain colorformat + colospace + oetf reporting for GL backends

Priorities

Full Physical Device report of all Properties, Limits and Features, treat all extensions "as-if" they were merged into core
Enable features on Logical Device by "editing" a physical device feature struct and passing that to creation
Implicit dependency "patcher" which enabled features required by other required features
PhysicalDevice iterator to choose the best device given an enabled feature set
getExtraGLSLDefines() crossplatform implementation


Do you think it is possible to run news-please in a cluster?

News-please has been very easy to setup & test. I've been getting excellent results during my testing, now I'm considering putting it in to production.
I'm trying to figure out the best way to run multiple instances in an AWS ECS cluster. If multiple News-please crawlers point to the same MySQL database, will this allow them to distribute the tasks across a cluster?
If not; do you have any thoughts on how to run news-please in a scalable cluster?

I'm assuming you're planning to run news-please in CLI mode, since you mentioned storing to MySQL DB. When designing news-please, running it in parallel was one of the design requirements so that should actually work but we've never tested it yet.
You should be able to run news-please in parallel by setting up a different sitelist.hjson file on each of the instances: each instance would deal with a different subset of all the sites that you're planning to crawl. The config.cfg file would be the same on all of them.

Yes I am planning on running it in CLI mode. I'll see if I can get it to work in a AWS container cluster and report back my results. I have a few questions before I start.
When I restart the docker containers any local files will be destroyed. Am I correct that this should not be a problem because the crawl history is persisted to MySQL?
You're suggesting that I segment my crawlers by domain. In this case each node will have a unique sitelist.hjson.
Example:
Node-1

Publication_1.com
Publication_2.com
Node-2
Publication_3.com
Publication_4.com
Node-3
Publication_5.com
Publication_6.com

Is it possible to use subdomains and path in the hjson?
Example:
Node-1

publication_1.com
news.publication_2.com
Node-2
publication_1.com/sports
publication_3.com
Node-3
fashion.publication_2.com
publication_4.com

When I restart the docker containers any local files will be destroyed. Am I correct that this should not be a problem because the crawl history is persisted to MySQL?
Yes.

You're suggesting that I segment my crawlers by domain. In this case each node will have a unique sitelist.hjson.
Correct.

Is it possible to use subdomains and path in the hjson?
Yes, but make sure to set sitemap_allow_subdomains to False in https://github.com/fhamborg/news-please/wiki/configuration

Closing this for now. Feel free to reopen in case any issues occurs or you wanna share your experience with the community. Thank you!

Thank you. I'll let you know how it goes. I just have to workout another part of the pipeline first.


Is it possible to open BuildlessAutoDisposeAsyncNotifier/BuildlessAsyncNotifier for public consumption outside of 'riverpod_generator'?

In continuation of the discussed in https://github.com/rrousselGit/riverpod/discussions/1953
Hello!
I have made a mixin on AutoDisposeAsyncNotifier to reuse code in my AsyncNotifiers with list pagination logics.
/// Mixin for pagination screens.
mixin PaginationMixin<T>
    on AutoDisposeAsyncNotifier<PaginationState<T>> {
  /// Fetch list and manage states.
  Future<PaginationState<T>> fetchList({
    final bool isRefresh = false,
    final bool isSocketUpdate = false,
    final String? search,
    final EvaluationStatus? filter,
  }) async {
    if (isSocketUpdate || isRefresh || !(state.value?.isEnd ?? false)) {
      PaginationState<T> pagination = state.value != null
          ? state.value!.copyWith(
              page: isRefresh ? null : state.value!.page,
              items: isRefresh ? null : state.value!.items,
              search: search ?? state.value!.search,
              filter: filter ?? state.value!.filter,
            )
          : PaginationState<T>();

      if (!isSocketUpdate) state = AsyncLoading<PaginationState<T>>();

      debugPrint('isSocketUpdate $isSocketUpdate');

      final int nextPage = (pagination.page ?? 0) + 1;
      state = await AsyncValue.guard(() async {
        final List<T>? list = await getList(
          isSocketUpdate ? 1 : nextPage,
          length: isSocketUpdate ? (state.value?.page ?? 1) * 20 : null,
          isRefresh: isRefresh,
          search: state.value?.search ?? '',
          filter: state.value?.filter ?? EvaluationStatus.all,
        );
        if (list != null) {
          pagination = pagination.copyWith(
            isEnd: list.length < 20,
            items: <T>[
              if (!isSocketUpdate) ...pagination.items ?? <T>[],
              ...list,
            ],
            page: isSocketUpdate ? pagination.page : nextPage,
            search: search ?? pagination.search,
            filter: filter ?? pagination.filter,
          );
        }
        return pagination;
      });
    }
    return state.value ?? PaginationState<T>();
  }

  /// Load list from repository.
  Future<List<T>?> getList(
    final int page, {
    required final EvaluationStatus filter,
    final int? length,
    final bool isRefresh = false,
    final String? search,
  });
}

It works well, when I am using AsyncNotifier with no additional arguments. But if there are arguments (similar to family), generator creates BuildlessAutoDisposeAsyncNotifier, not general AutoDisposeAsyncNotifier. So the mixin has class mismatch.
This one works well:
/// The controller of EventsScreen states.
@riverpod
class EventsController extends _$EventsController
    with PaginationMixin<EventModel> {
  @override
  FutureOr<PaginationState<EventModel>> build() {
    return fetchList();
  }

  @override
  Future<List<EventModel>?> getList(
    final int page, {
    required final EvaluationStatus filter,
    final int? length,
    final bool isRefresh = false,
    final String? search,
  }) {
    return ref.read(eventsRepositoryProvider).fetchList(
          page,
          length: length,
          isRefresh: isRefresh,
          search: search,
          filter: filter,
        );
  }
}

And this one won't work because of id argument:
/// The controller of [ParticipantsScreen] states.
@riverpod
class ParticipantsController extends _$ParticipantsController
    with PaginationMixin<AccessModel> {
  @override
  FutureOr<PaginationState<AccessModel>> build(final int id) {
    return fetchList();
  }

  @override
  Future<List<AccessModel>?> getList(
    final int page, {
    required final EvaluationStatus filter,
    final int? length,
    final bool isRefresh = false,
    final String? search,
  }) {
    // debugPrint('event controller id: $id');
    return ref.read(participantsRepositoryProvider(id)).fetchList(
          page,
          isRefresh: isRefresh,
          search: search,
          filter: filter,
          length: length,
        );
  }
}

The problem would be solved, if there's a possibility to make mixin on BuildlessAutoDisposeAsyncNotifier (which is only for internal use now), rather than AutoDisposeAsyncNotifier.
So, is it possible to open BuildlessAutoDisposeAsyncNotifier for public consumption outside of 'riverpod_generator'? Or maybe here can be another solution?

That's not reasonable. It isn't meant to be used
You don't need the on clause on mixins for them to work. You can instead do:
mixin PaginationMixin<T> {
  State<AsyncValue<T>> get state;
  set state(State<AsyncValue<T> value);
  Ref<AsyncValue<T>> get ref;
}

If you end up needing this often, you can make an interface
abstract class AsyncNotifierInterface<T> {
  State<AsyncValue<T>> get state;
  set state(State<AsyncValue<T> value);
  Ref<AsyncValue<T>> get ref;
}

mixin MyMixin<T> implements AsyncNotifierInterface<T> {

}

I'll maybe expose it in the future, but I'm a bit skeptical about it for now.
It's not something that was designed to be exposed. I'd need to carefully review it before exposing it.
Considering there's a decent workaround, it's not too important to me.

@rrousselGit Well, I've just thought that it could be possible to expose both Buildless and general Notifiers, if one had already been exposed, but I understand your skepsis about it. Anyway your workaround functions excellent, thank you!
And I just want to specify one more thing concerning the the Ref in a workaround:
If I try to use it like that:
mixin PaginationMixin<T> {
  Ref<PaginationState<T>> get ref;

There is and error, if I try to use the mixin: 'BuildlessAutoDisposeAsyncNotifier.ref' ('AutoDisposeAsyncNotifierProviderRef<PaginationState<AccessModel>> Function()') isn't a valid concrete implementation of 'PaginationMixin.ref' ('Ref<PaginationState<AccessModel>> Function()')
It is solved, if I create mixin this way:
mixin PaginationMixin<T> {
  AutoDisposeAsyncNotifierProviderRef<PaginationState<T>> get ref;

So it is necessary to specify type of ref, isn't it?

So it is necessary to specify type of ref, isn't it?

Depends on what your mixin needs.
Generally AutoDisposeRef<T> vs Ref<T> is enough

Concerning passing a provider to a class as an argument:

Providers shouldn't be passed as parameter at all. So I would argue that's asking the wrong question.


Remove documentation.js dependency?

The documentation.js dependency is very large ~116.5 MB when installed. I think we should remove this dependency from being installed automatically and only install it within the npm run docs script itself.
Would look like this:
"docs": "npm install documentation && documentation build src/*.cpp src/standalone_async/*.cpp src/standalone/*.cpp --polyglot -f md -o API.md"

cc @springmeyer @GretaCB

hey @mapsam , your example above is what the skel used to have before last week. Also, per chat last week, we discovered that the skel didnt have documentation.js as a dep in package.json.
I've since added this step as part of the docs https://github.com/mapbox/node-cpp-skel#installation.

:facepalm:
Sorry @GretaCB totally blanked. I'm working on the cf branch which hasn't been updated with master in a while. Please disregard!


Implement updateProject mutation to work with new version

This webservice get image as pinataUrl in input, after finalizing new version of giveth.io we will remove editProject mutation

@RamRamez  please move it done when you thought this works good

@RamRamez please move it done when you thought this works good

I don't have permission to move.

@MoeNick  Ramin approved this change, you can move it to Done

@mohammadranjbarz  @RamRamez - Any Scenarios to Test this. ? Are we Testing "Updates" Tab Project Section ?

Test Status : PASS in STAGING
Test URL : https://staging.giveth.io/create
Test Results : Update Projects are working fine.


CI: some improvements in printing and folder structure

Add a --verbose flag to run_benchmarks.py and use it in the CI. This allows us to see the output of each run. (Note that we'll see the output for each run on your branch, as well as each run on main.)
Modified the table printed at the end to have 2 numbers in each column: first is the result on the main branch, second on your branch. This should make comparisons easier.
Also print a summary of changes at the end.
run_benchmarks.py uses a folder benchmarks/out-main/ to store the output of the runs on main, instead of re-using the benchmarks/out/ folder. This should allow you to diff between the outputs etc.

CI failed twice, but I think it's because of #50. As this PR doesn't touch the tool at all, it cannot cause regressions.

Thanks @siddharth-krishna. Having the results for main and PR in the same row definitely makes the comparison easier!


Update README.md

It is causing installation error because of the missing system dependencies.
Update the README.md to include how to install dependencies.

Are you still working on 17.04? This package works for me on 16.04 without these changes...

I merged the Readme changes. Thanks!
The build seems to work fine on 16.04. and 18.04.


[Migrated] Cannot invoke task: TypeError: Object of type 'LambdaContext' is not JSON serializable

Originally from: https://github.com/Miserlou/Zappa/issues/1097 by robwatkiss
Context
When invoking tasks a TypeError is raised as zappa tries to JSON encode the LambdaContext object.
Expected Behavior
The task should be invoked
Actual Behavior
A TypeError is raised as context.identity (CognitoIdenity instance) cannot be serialized as it has no '__dict__' attribute and hence cannot be serialized.
Object of type 'LambdaContext' is not JSON serializable: TypeError
Traceback (most recent call last):
  File "/var/task/handler.py", line 505, in lambda_handler
    return LambdaHandler.lambda_handler(event, context)
  File "/var/task/handler.py", line 242, in lambda_handler
    return handler.handler(event, context)
  File "/var/task/handler.py", line 341, in handler
    result = self.run_function(app_function, event, context)
  File "/var/task/handler.py", line 272, in run_function
    result = app_function(event, context) if varargs else app_function()
  File "/var/task/zappa/async.py", line 344, in _run_async
    aws_region=aws_region).send(task_path, args, kwargs)
  File "/var/task/zappa/async.py", line 143, in send
    self._send(message)
  File "/var/task/zappa/async.py", line 151, in _send
    payload = json.dumps(message).encode('utf-8')
  File "/var/lang/lib/python3.6/json/__init__.py", line 231, in dumps
    return _default_encoder.encode(obj)
  File "/var/lang/lib/python3.6/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/var/lang/lib/python3.6/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
  File "/var/lang/lib/python3.6/json/encoder.py", line 180, in default
    o.__class__.__name__)
TypeError: Object of type 'LambdaContext' is not JSON serializable

Possible Fix
Remove unserializable types before serialization or define custom encoder. It's a horrible solution, I admit.
# create dict from context with serializable types (this list almost certainly missing many valid types!)
context_serializable = {k:v for k, v in context.__dict__.items() if type(v) in [int, float, bool, str, list, dict]}
json.dumps(context_serializable)

Steps to Reproduce

Create test task

from zappa.async import task

@task
def my_func():
    print("All good!")

Deploy it
Invoke it zappa invoke bugtest 'test.my_func'

Your Environment

Zappa version used: 0.43.2
Operating System and Python version: Ubuntu, Python 3.6
The output of pip freeze:

argcomplete==1.8.2
base58==0.2.4
boto3==1.4.5
botocore==1.5.40
certifi==2<IP_ADDRESS>
chardet==3.0.4
click==6.7
docutils==0.14
durationpy==0.5
future==0.16.0
futures==3.1.1
hjson==3.0.0
idna==2.6
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.16.1
placebo==0.8.1
python-dateutil==2.6.1
python-slugify==1.2.4
PyYAML==3.12
requests==2.18.4
s3transfer==0.1.11
six==1.10.0
toml==0.9.2
tqdm==4.15.0
troposphere==1.9.5
Unidecode==0.4.21
urllib3==1.22
Werkzeug==0.12
wsgi-request-logger==0.4.6
zappa==0.43.2

Your zappa_settings.py:

{
    "bugtest": {
        "app_function": "test.my_func",
        "aws_region": "eu-west-2",
        "profile_name": "turbogram",
        "s3_bucket": "zappa-bug-test"
    }
}

Reported as an issue in linked closed task.
Marking as next-release-candidate for consideration of inclusion in next release.

Functions decorated with asynchronous.task are not intended to be invoked externally, as they are not an entry point into the code base.
One workaround would be to have a generic entry point that would then be entered and then call the desired decorated task.
Though I'm not sure if the use-case for this is that prevalent.
Documenting how invoke interacts with @task decorated functions works and how to get around it would be a first step.


Documentation style: follow K8s guidance on capitalizing API objects

Opened after reviewing #25945.
I think Cilium docs should follow the Kubernetes style guide for when to (not) capitalize API objects. Specifically:

When you refer specifically to interacting with an API object, use UpperCamelCase, also known as Pascal case.

And:

When you are generally discussing an API object, use sentence-style capitalization.

In the case of #25945, I'd like to see "Gateway API" capitalized, "Gateway" when talking about an API object as an entity, and "gateway" when talking about a specific instance.
This issue is non-blocking for #25945. I mention it specifically because it's a good example of a larger phenomenon I see in Cilium API docs in general.
@qmonnet 👋🏻 I'd love your feedback here
cc @learnitall for visibility

No objection, this makes sense to me. We could do with more guidance on capitalisation, in general - I agree the current situation is far (far, far, far) from consistent. Although this will be hard to enforce.
Do you plan to add it to Cilium's style guide?

@qmonnet I do intend to add it to the style guide. I'm fine with adding it either before or after #26632 merges.

Just to make sure I've got this right here are some examples of what I think is correct and what's not when talking about Gateway API:
Correct:

Gateway API is a subproject of Kubernetes SIG Network.
Cilium is conformant to the Gateway API spec at version 0.7.1.
In order to expose this service, you will create a Gateway to hold the listener configuration.
Traffic from the internet passes through the gateway to get to the backend service. (I'm also using "service" rather than "Service" here because I'm speaking about the abstract idea of a service rather than a specific Kubernetes Service object).

Incorrect:

When we're implementing gateway API, we...
This tutorial shows you how to create a gateway object...

Unsure:

Now that you have created the foo Gateway, you need to create some Routes. (I'm not sure if this should be Gateway or gateway - I would normally prefer Gateway because we're talking about a specific instance of a specific Kubernetes type, but I'm happy to be corrected here).

(Working on Gateway API has made me pretty allergic to imprecision here too, so I want to make sure we're all on the same page.)

@youngnick 👋🏻

Correct:

Yes to all.

Incorrect:

Also yes to all.

Unsure:
Now that you have created the foo Gateway, you need to create some Routes.

This would be foo gateway, because it's talking about a specific instance.

I would normally prefer Gateway because we're talking about a specific instance of a specific Kubernetes type

Wouldn't talking about a specific instance of a specific type make it sentence case?

Working on Gateway API has made me pretty allergic to imprecision here too, so I want to make sure we're all on the same page

🙌🏻

Wouldn't talking about a specific instance of a specific type make it sentence case?

I guess I've been burned by this a bit before because it's common to talk about "ingress" the general concept in the same sentence as "Ingress" the Kubernetes object, and so it's necessary to capitalize to disambiguate. (Similar things apply to "service" and "Service", or "secret" and "Secret").
It's come up a lot in Gateway API because a lot of the object names are also general concepts that can mean very different things.

Ah, oops, I forgot that the PR I merged had this instruction in it. Anyway, the standard Kubernetes guidance is fine for now, but my above comment is something to consider for the future.


Honor weapon .pickup return value.

For FreeCS this means CT-team wil no longer be able to pickup the bomb.

Thanks, I was very short-sighted with commit a80def1d12cbf0ae601d4cd0328c42b0106b4eab, there will be a separate commit to the game specific repositories that'll check for when a weapon is new to avoid the bugs that older commit tried to fix without breaking CS.


speak to text , and Text to Text for language trans "extensions"

whisper can be wrapped with golang easily and then the system can do speak to text.
working demo here:
https://github.com/gedw99/galene-stt that is NOT integrated with broadcast-box yet.
This makefile works everywhere and "dep-test" will run and do an audio to text...

Text to Text might also be useful as another "extension".
Just raising to see if there is support for integration or not.

Hello! This is a interesting idea, I can't speak to whether adding extensions would be feasible, or if that is something Sean would like to add. However, I do have reservations to adding speech recognition. I use and rely on stt and have first hand experience in how inaccurate the transcribing can be. I don't believe that it would be accurate enough to be useful, in my experience the transcriptions often require heavy editing to match what was spoken.
With that said, if it was going to be implemented, I think adding some warnings about accuracy would be a good idea, and that the text may be inaccurate or misleading. This is important because if a user is exclusively relying on the text to understand what is going on they would have no way to verify the accuracy.
I am optimistic about the technology, it has gotten significantly better recently. I would be very interesting to hear other people's opinions about it.
Thanks for the suggestion!


$lqguid

With jquery 2.1.x I get this after downloading the latest livequery version:
Uncaught TypeError: Cannot read property '$lqguid' of undefined
This error keeps livequery from doing its job. Does livequery work in jquery v2.1.3?

I get the same problem with jquery  v1.9.1 .
Online lint tools also show, http://www.jslint.com/ . Bad property name '$lqguid'.

I was using the public signatures incorrectly.

@leblancmeneses could you please elaborate? I still didn't figure out what I am doing wrong... maybe you can help me?

I was using
$('#mylist li').livequery(function(elem) {
});

when the readme.md says
$('#mylist').livequery('li', function(elem) {
});

In the end I choose to just use in my chrome extension.
http://stackoverflow.com/questions/3219758/detect-changes-in-the-dom

The same issue I face, seems it is not fixed when a half year pass

Lol noone cares about this problem ^^. I was looking for the fastest solution and ended up taking the only release version v1.1.1 from here https://github.com/brandonaaron/livequery/releases/tag/1.1.1
It's from 2010 so not really a recommendation...


moving the additional custom js to the very bottom of the master

@fletch3555 or @marktopper could you merge this in for me when you get a chance :) I needed to add the custom_js files that get included in the config to be at the very bottom of the page.
Thanks.

Thanks @marktopper  👍


Tests: un-xfail tests on the freestanding bot

Un-xfailing tests fixed by #72283.
Three tests are still failing:
stdlib/freestanding-check-symbols.test-sh
Concurrency/optional_isolated_parameters.swift
Concurrency/ShrinkWrap.swift

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@swift-ci Please smoke test

There's one failure remaining that wasn't part of the xfail. Concurrency/async_main.swift


Release 0.17.1

I would like to issue a micro-release soon.  Any objections or concerns?

SGTM

Do you have a timeline in mind?

Today or tomorrow sometime if that's alright with everyone

Pushed both dask and distributed packages to PyPI


ES6 import paths starting with "/" should be relative to the web root, not filesystem

From @rconnamacher on April 19, 2018 1:45

VSCode Version: 1.22.2
OS Version: macOS 10.13.4

In an ES6-native project (using web browser module resolution), all module paths must begin with "." or "/", and paths starting with "/" are relative to the root of the web server that's serving them.
However, Visual Studio Code interprets all paths starting with "/" as relative to the filesystem root. So if you type import "/, it will begin autocompleting such root filesystem directories as "/dev", "/etc", "/usr", etc. And once entered, Code has no idea where such files as import App from "/src/js/App.js" are located.
I've tried setting the rootDir and baseUrl parameters in this project's jsconfig.json, but it does not appear to make any difference.

Does this issue occur when all extensions are disabled?: Yes
Copied from original issue: Microsoft/vscode#48168

Related to #13730

#13730's proposed solution would work for this too (and is one I tried as well when attempting different methods of setting the root directory).

Seems like a duplicate of #13730


brace_style not implemented, among other things

rustfmt.toml
#array_width = 60
#attr_fn_like_width = 70
binop_separator = "Front"
blank_lines_lower_bound = 0
blank_lines_upper_bound = 1
brace_style = "AlwaysNextLine"
#chain_width = 60
color = "Always"
combine_control_expr = false
comment_width = 80
condense_wildcard_suffixes = false
control_brace_style = "AlwaysNextLine"
disable_all_formatting = false
doc_comment_code_block_width = 140
edition = "2021"
empty_item_single_line = true
enum_discrim_align_threshold = 30
error_on_line_overflow = false
error_on_unformatted = false
fn_args_layout = "Vertical"
#fn_call_width = 60
fn_single_line = true
force_explicit_abi = true
force_multiline_blocks = true
format_code_in_doc_comments = true
format_generated_files = true
format_macro_bodies = true
format_macro_matchers = true
format_strings = false
group_imports = "StdExternalCrate"
hard_tabs = true
hex_literal_case = "Upper"
hide_parse_errors = false
ignore = []
imports_granularity = "Crate"
imports_indent = "Block"
imports_layout = "Vertical"
indent_style = "Block"
inline_attribute_width = 0
match_arm_blocks = true
match_arm_leading_pipes = "Never"
match_block_trailing_comma = false
max_width = 140
merge_derives = true
newline_style = "Unix"
normalize_comments = true
normalize_doc_attributes = true
overflow_delimited_expr = false
remove_nested_parens = true
reorder_impl_items = true
reorder_imports = true
reorder_modules = true
#required_version = "1.4.38"
short_array_element_width_threshold = 10
#single_line_if_else_max_width = 50
skip_children = false
space_after_colon = true
space_before_colon = false
spaces_around_ranges = false
struct_field_align_threshold = 30
struct_lit_single_line = true
#struct_lit_width = 30
#struct_variant_width = 35
tab_spaces = 100
trailing_comma = "Vertical"
trailing_semicolon = false
type_punctuation_density = "Wide"
unstable_features = true
use_field_init_shorthand = true
use_small_heuristics = "Default"
use_try_shorthand = true
#version = "Two"
where_single_line = true
wrap_comments = true

#emit_mode = "Files"
#make_backup = false
#print_misformatted_file_names = false

main.rs
#![feature(int_log)]

fn main()
{
	(1..=1_000_000u32).for_each(|n| {
		let result: u32 = n.log2();
		println!("{result}");
	});
	let lorem = MyStruct
	{
		i: 1,
	};
	let mut value1:MyStruct=MyStruct{i:69_420i32,};
	let value2:MyStruct=MyStruct
	{
i
:
6969_420i32
,
	};

	unsafe {
		value1=MyStruct{
i:value2.i, };
	}

	let value1 = value1;
	let my_num = ((value1.i + value2.i).log(2));
	println!("{my_num}");
}

struct MyStruct
{
	i: i32,
}

How?
This is after cargo fmt. I don't know why it gets it so wrong. Why is it not even enforcing indentation? Why are the braces not on the next line according to brace_style = "AlwaysNextLine"? Why is lorem not condensed onto one line according to struct_lit_single_line = true? Why does it not put spaces around characters like : or =? Why does it not remove superfluous parentheses on line 28? This is on the latest nightly. I assume I'm doing something wrong.

Thanks for reaching out. As a general ask/recommendation, it's a lot easier to share, review, and discuss specifics in focused conversation, with as minimal a repro as possible (both config and code) and to try to refrain from a catch-all set of issues/questions.
Given that you started the title and initial question relative to the brace_style, I'll try to speak to this first to hopefully clarify what this option does, and what it doesn't do.brace_style as originally introduced only applied to items and not every possible syntactical construct where braces may occur. There's more discussion and detail on this in the stabilization tracking issue for brace_style #3376, but suffice to say it's currently expected that the option doesn't apply in certain contexts. You've probably got something else going on as well, but I suspect the nature of the option may be at least part of it.
Myself or someone else will try to take a closer look at the "other things" as you put it :smile: when time permits, but in the interim if you have the time, it would speed things along if you could try to reduce down the set of config options to the subset that are producing the problem you are experiencing

Turns out this is the same root issue as #5431
This formatting madness is mostly solved by lowering tab_spaces so that it doesn't crash.

only applied to items and not every possible syntactical construct where braces may occur
Why was this the go-to implementation of a feature called braces_style? I imagine it's not very difficult to put a newline character and the proper number of tabs before each { in the file, compared to parsing the "syntactical constructs" and only applying the rule to some of them. Obviously there's other things to consider like other, more specific rules like one-lining a struct instance, but still, this has been an open issue for literally years. I'm going to close this issue and further discussion can take place in #3376. I appreciate the work being done keeping everything in order and carefully considered.

Why was this the go-to implementation of a feature called braces_style? I imagine it's not very difficult to put a newline character and the proper number of tabs before each { in the file, compared to parsing the "syntactical constructs" and only applying the rule to some of them.

I'd encourage you read through the discussion in the issue I linked in my last comment, where the name of the still-unstable option is an explicit discussion point. Also keep in mind that while some users, perhaps including yourself, may want a categorical application of brace styling, there's plenty of others that want different behavior depending on the context (e.g. items vs patterns vs expressions). In these scenarios it's best for us to try to support the community at large instead of trying to pick one camp at the expense of another.
Your second sentence is tantamount to "why wasn't the entire product implemented in a completely different manner", which isn't a topic that's really worth debating at this point, but in general: there's two typical flavors of code formatters, one which follows the token processing and matching from the source file as you describe, and the other that deals with parsing the input and formatting the AST representation of the program against a set of rules (a pretty-printer).
The latter is the approach the Rust community took many, many years ago and is not going to change. There's benefits and tradeoffs to each approach, but the AST pretty-printer approach was taken because it was the best solution to achieve Rust's goals of having a unified default style for Rust code across codebases and to best support the more advanced types of syntactical transformations and restructuring that the community wanted.
That default style is codified in the Rust Style Guide, rustfmt is simply the implementing tool, where we've also added configuration options to allow folks to get results that differ from those codified prescriptions.

I appreciate the very well thought-out reply. I hope I didn't come across as rude. I actually did read the discussion before making the issue here, but not so closely that I remembered that talking point. I was just trying to figure out what's been going on since 2020 when someone commented on closures and such. I completely agree that having fine-tuned behavior per syntactical construct is the optimal solution. I didn't mean to imply that the ideal solution was a one-size-fits-all setting true/false. Rather, I was wondering why that wasn't that starting point, or at least the base behavior, which other, more specific settings could tweak from there. From what you say, I'm assuming that the style of processing done by rustfmt makes a blanket all_braces_newline_default_style option infeasible. I can accept that. I'm just surprised the extremely common preference of such a theoretical setting being set to true hasn't been implemented, or I'm surprised that it isn't a more common request. Again, I appreciate the work that has been done so far, and I look forward to this tool reaching its full potential. I'd be willing to help it along the way once I become more proficient in rust.

No worries, and no rudeness whatsoever, just wanted to make sure you'd seen the other thread. Certainly feel free to ask any questions (there or here) if anything is unclear; I realize some of the discussion over there may presume some inherent knowledge of rustfmt usage that's not necessarily obvious to those new to the tool.

what's been going on since 2020 when someone commented on closures and such
I'm just surprised the extremely common preference of such a theoretical setting being set to true hasn't been implemented
I'd be willing to help it along the way once I become more proficient in rust.

Starting with the last one first, that would fantastic! We've probably got some decent issues in this repository that relatively simple and perhaps a good way to get some Rust practice in.
As to the other points, which share a general theme, this basically just boils down to the basics of open source volunteerism and workloads/priorities vs bandwidth constraints. rustfmt's core goal is to format Rust code according to the style guide as we were discussing earlier, and there's more than enough work on that front to occupy the entirety of the bandwidth of the rustfmt team.
Config options exist to allow users to do something that diverges from that core goal, because they are all about formatting code in ways that's different from the style guide. As such that takes a priority backseat by default, and that's why we typically don't do much work on config options ourselves these days (though there's occasionally exceptions as and when an option has strong alignment to some other goals).
Most often, new config options get added by someone from the community when there's a different style they want badly enough that they are willing to contribute themselves, and the same type of pattern largely holds true for stabilization (someone sufficiently motivated to have an option available on stable for their usage). The difference with stabilization is that a lot more users are on nightly toolchains than one might suspect, so the potential pool of users is even smaller compared to the existence/adding of a new option. We assist users on both fronts, but it's just rarely something we drive ourselves.
Additionally, brace_style, especially in non-item and non-control flow expression contexts hasn't been a hot request/need at all, especially compared to other options (compare the number of commentors, reactions, etc. of that option as compared to one like say imports_granularity.

I'm assuming that the style of processing done by rustfmt makes a blanket all_braces_newline_default_style option infeasible

Nope, your assumption is incorrect (fortunately!). I spoke to this in https://github.com/rust-lang/rustfmt/issues/3376#issuecomment-906051689, but that same type of pattern of having one top-level option that controls everything, but which also influences/works with more granular options is not only possible, it's actually something we've already done before in other cases.


Split [Jetbrains] tests

See https://github.com/badges/shields/pull/3701#issuecomment-511017547.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @PyvesB!

  Generated by :no_entry_sign: dangerJS against ec3586be954eae738001bf86a8c60b4f97eac814

Done, I ended up removing quite a few tests.


Country Mappings (Tags A-D)

Beginning of country mapping, for V3 countries with tags A through D.

For ones you're uncertain about, comment out the line with #