bug([cdk/layout]): [addEventListener is undefined in iOS >=12]

I had issues loading my Angular 9 app on iPhone, it loads in all desktop browsers and android devices, just got an blank page in iPhone. It raised an promiseReactionJob exception .. running the lasted iOS version (13.4.1). I checked  index.html and the scripts are loaded as expected.
So, after isolate the problem, I identified that it was failing in the call below because addEventListener is undefined
this.forMobileLandscapeAndDown.addEventListener('change', this.mediaQueryListener);

I checked the content of fem2015/layout.js and addEventListener does not exist in Safari for iOS.
The fix on my app was check the OS and call addListener instead of removeListener only for iOS.
Environment

Angular: 9.1.2
CDK: 9.2.1
Browser(s): Safari/Firefox/Chrome
Operating System: iOS >= 12

This looks like an issue with your own code. We have zero calls to addEventListener inside the layout module.

I use like below ...
import { MediaMatcher } from '@angular/cdk/layout';

....

private observeViewportWidthChanges() {
    this.forMobileLandscapeAndDown = this.media.matchMedia('(max-width: 767px)');
    this.mediaQueryListener = () => {
       // doing something else
    };

    // On iphone, it fails on the call below, because addEventListener is UNDEFINED,
    // but works fine on Android (Chrome), Windows (Chrome, Firefox, Edge)
    this.forMobileLandscapeAndDown.addEventListener('change', this.mediaQueryListener);
}

Call addEventListener('change', this.mediaQueryListener); only fails on iPhone

I don't see the CDK MediaMatcher being used anywhere in your example.

See the constructor and the line below ...
this.forMobileLandscapeAndDown = this.media.matchMedia('(max-width: 767px)');

I see. All the media matcher does it handle some browser inconsistencies around matchMedia, but it still returns the native MediaQueryList so it's up to you to choose the proper method. If you want this to be abstracted away for you, you can use the BreakpointObserver service.

Closing since this seems unrelated to Angular CDK.


u'djangocms_blog' is not a registered namespace

When I added a plugin to my page, this showed up.
I fixed it by adding url(r'^blog/', include('djangocms_blog.urls', namespace='djangocms_blog')), to the urls.py. If this is the normal way to fix it. Please add it to the installation docs.

I saw a similar error while creating my own djangocms-blog setup.
The problem in that case was that I needed to restart the django server after associating a page with the blog app (apparently because of caching).
Could this be related?

Sadly it still happens for me even if I restart it twice without the url() in the urls.py.

It seems like a bug.
I hope the repo maintainers can comment on this.

djangocms-blog is namespace-enabled thus it requires a application name to be defined when loaded into the urlconf. Normally this is done by using apphooks as documented in the readme, which will ask for the application name into the page advanced settings.
As per django-cms documentation, loading an apphooks requires a server restart because of the way django handles urlconfs.
If this two topics are not clear enough in the current documentation, we'll try to improve it.
Thanks for reporting

Closing as this has been cleared in the documentation

Guys, I would suggest to do an example of apphook configuration in documentation especially for the very newbies

@Dean-Christian-Armada opened as #458


Rebuild:bug --> Refresh Vote page

Happens ins dev and prod build.
Steps to reproduce:

Navigate to "Vote" (Main menu) page.
Refresh the page (on windows hit F5 to refresh)
In prod build I get a 404, in dev build I get error:

Uncaught TypeError: Cannot read property 'path' of undefined

This is fixed on the rebuild-hyperlink branch, which is just waiting to be merged once enough maintainers agree

Good! Closing...


gui: fix wrong jsonrpc delspendtx request

Against https://github.com/wizardsardine/liana/blob/master/doc/API.md

utACK a0890d8eb09e540cf96943f3bacf1ee5d1327ba6 -- I quickly double checked and i didn't find any other mistake.


Windows - pressing a character throws exception

Pressing any character other than ':' on the startup screen, throws this:
fatal.nim(49)            sysFatal
Error: unhandled exception: value out of range: 1 notin -2147483648 ..<PHONE_NUMBER> [RangeError]

Specs:

Windows 10 x64
Nim Devel

Is it only happening on devel for you? i'm on 1.0.6 with windows 10 and haven't seen that error.

I only use devel, yes. To be sure I rebuilt Nim again, but the exception persists.

Ok i reproduced it. I'm guessing this is a bug in devel, since 1 is most definitely between -2147483648 ..<PHONE_NUMBER>. I'll try to see if i can track down a minimal example that throws the error.

I think i narrowed it down: https://github.com/nim-lang/Nim/issues/13698

This is fixed on the latest devel.


[PL-48456] SMP 0.14.4 patch release notes

SMP 0.14.4 patch release notes
For reviewers, a preview is available:
---preview building now--
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screenshot.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65fb0d5e4fa8a50d46e5607e--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65fb433169184a1c2683d631--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65fb464e7788091e2aa131ea--harness-developer.netlify.app


Update to 2.1.8

Hi,
I've rebased your changes on top of the latest v2.1.8 tag. Figured rebasing made sense seeing that keeps the actual changes in this branch on top. Not sure if you can force use this PR or if you have to fix this in another way.

Hi @mbicknese, thank you for this contribution.
I see there are some conflicts that need to be solved.
Once done I will be more than glad to merge it.
Marco

Also it looks like a lot of changed files for an update PR, can you help me find out what is the contribution you made and what is new code from the CRA guys?

Little slow response, sorry about that.
So what I did was rebase your commit f769df214003db390a7b584d41dd616074604f1d, on top of the 2.1.8 release of the upstream create-react-app repo. The conflict has been solved by setting the version to "2.1.8" in the package.json.
The changes you see are the changes made by the Facebook team and contributors.


Configure release flow

What
This adds the option to try to deploy artifacts to maven central from tags. Reducing manual release work to be running release:prepare.
As well as adding a default build/test workflow
Interesting things to consider
How to move to next snapshot version, when not running mvn release:perform locally anymore. Should be a small concern, but would be nice to have automated as well.
Missing information
This repo does not yet have the necessary secrets for this setup to work, but I'll add them as we get closer to merging this PR.

@chriswk there is an error:
Installed distributions
Error: The string '${matrix.version}' is not valid SemVer notation for a Java version. Please check README file for code snippets and more detailed information
I merged this by mistake.

@chriswk It would be great if you can take a look at the build failure. Thanks


i18n(zh-tw): update project-structure.mdx

Description (required)
update project-structure.mdx.
Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-tw
basics/project-structure.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


START48 added

Starter 48 added

@ShouryaGarg
Making multiple pull requests to the same repository will cause spamming and can lead to a temporary/permanent ban of your profile from hacktober fest.
For the same, we won't be able to merge your pull request.
In the mean while we encourage you to keep looking out for other repositories and keep contributing to them.
Happy Hacktober


Rounded up calculations to prevent flyout from hiding when accessed from right or bottom

A fix for issue #82 as discussed

Thanks @bobypenev 🥳


Oauth2 Social Sign-In  In Android App

In generated apk after clicking on sign in it is taking to the browser page where keycloak sign in page is opened and after selecting google social sign in it is giving an error of 'localhost refused to connect'

After Signing in how to redirect to app from browser or is there any other solution

I believe you need to configure the AndroidManifest.xml to allow clear text for this to work. https://stackoverflow.com/a/51902630/65681

Closing due to lack of response.


PrivatyGPT Embedding with Ollama : "concurrent llm servers not yet supported"

What is the issue?
I'm runnign on WSL, ollama installed and properly running mistral 7b model. I'm also using PrivateGPT in Ollama mode. The problem come when i'm trying to use embeding model. It seems ollama can't handle llm and embeding at the same time, but it's look like i'm the only one having this issue, thus is there any configuration settings i've unmanaged ?
settings-ollama.yaml for privateGPT : ```server:
env_name: ${APP_ENV:ollama}
llm:
mode: ollama
max_new_tokens: 512
context_window: 3900
temperature: 0.1     #The temperature of the model. Increasing the temperature will make the model answer more creatively. A value of 0.1 would be more factual. (Default: 0.1)
embedding:
mode: ollama
ollama:
llm_model: mistral
embedding_model: nomic-embed-text
api_base: http://localhost:11434
tfs_z: 1.0            # Tail free sampling is used to reduce the impact of less probable tokens from the output. A higher value (e.g., 2.0) will reduce the impact more, while a value of 1.0 disables this setting.
top_k: 40             # Reduces the probability of generating nonsense. A higher value (e.g. 100) will give more diverse answers, while a lower value (e.g. 10) will be more conservative. (Default: 40)
top_p: 0.9            # Works together with top-k. A higher value (e.g., 0.95) will lead to more diverse text, while a lower value (e.g., 0.5) will generate more focused and conservative text. (Default: 0.9)
repeat_last_n: 64     # Sets how far back for the model to look back to prevent repetition. (Default: 64, 0 = disabled, -1 = num_ctx)
repeat_penalty: 1.2   # Sets how strongly to penalize repetitions. A higher value (e.g., 1.5) will penalize repetitions more strongly, while a lower value (e.g., 0.9) will be more lenient. (Default: 1.1)
vectorstore:
database: qdrant
qdrant:
path: local_data/private_gpt/qdrant```
logs of ollama when trying to query already embeded files : llama_model_loader: Dumping metadata keys/values. Note: KV overrides do not apply in this output. llama_model_loader: - kv   0:                       general.architecture str              = nomic-bert llama_model_loader: - kv   1:                               general.name str              = nomic-embed-text-v1.5 llama_model_loader: - kv   2:                     nomic-bert.block_count u32              = 12 llama_model_loader: - kv   3:                  nomic-bert.context_length u32              = 2048 llama_model_loader: - kv   4:                nomic-bert.embedding_length u32              = 768 llama_model_loader: - kv   5:             nomic-bert.feed_forward_length u32              = 3072 llama_model_loader: - kv   6:            nomic-bert.attention.head_count u32              = 12 llama_model_loader: - kv   7:    nomic-bert.attention.layer_norm_epsilon f32              = 0.000000 llama_model_loader: - kv   8:                          general.file_type u32              = 1 llama_model_loader: - kv   9:                nomic-bert.attention.causal bool             = false llama_model_loader: - kv  10:                    nomic-bert.pooling_type u32              = 1 llama_model_loader: - kv  11:                  nomic-bert.rope.freq_base f32              = 1000.000000 llama_model_loader: - kv  12:            tokenizer.ggml.token_type_count u32              = 2 llama_model_loader: - kv  13:                tokenizer.ggml.bos_token_id u32              = 101 llama_model_loader: - kv  14:                tokenizer.ggml.eos_token_id u32              = 102 llama_model_loader: - kv  15:                       tokenizer.ggml.model str              = bert llama_model_loader: - kv  16:                      tokenizer.ggml.tokens arr[str,30522]   = ["[PAD]", "[unused0]", "[unused1]", "... llama_model_loader: - kv  17:                      tokenizer.ggml.scores arr[f32,30522]   = [-1000.000000, -1000.000000, -1000.00... llama_model_loader: - kv  18:                  tokenizer.ggml.token_type arr[i32,30522]   = [3, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, ... llama_model_loader: - kv  19:            tokenizer.ggml.unknown_token_id u32              = 100 llama_model_loader: - kv  20:          tokenizer.ggml.seperator_token_id u32              = 102 llama_model_loader: - kv  21:            tokenizer.ggml.padding_token_id u32              = 0 llama_model_loader: - kv  22:                tokenizer.ggml.cls_token_id u32              = 101 llama_model_loader: - kv  23:               tokenizer.ggml.mask_token_id u32              = 103 llama_model_loader: - type  f32:   51 tensors llama_model_loader: - type  f16:   61 tensors error loading model: unknown model architecture: 'nomic-bert' llama_load_model_from_file: failed to load model llama_init_from_gpt_params: error: failed to load model '/root/.ollama/models/blobs/sha256:970aa74c0a90ef7482477cf803618e776e173c007bf957f635f1015bfcfef0e6' {"timestamp":1711013580,"level":"ERROR","function":"load_model","line":581,"message":"unable to load model","model":"/root/.ollama/models/blobs/sha256:970aa74c0a90ef7482477cf803618e776e173c007bf957f635f1015bfcfef0e6"} 2024/03/21 10:33:00 llm.go:129: Failed to load dynamic library cuda - falling back to CPU mode error loading model /root/.ollama/models/blobs/sha256:970aa74c0a90ef7482477cf803618e776e173c007bf957f635f1015bfcfef0e6 2024/03/21 10:33:00 ext_server_common.go:85: **concurrent llm servers not yet supported**, waiting for prior server to complete
What did you expect to see?
expecting to see ollama to load noemic
Steps to reproduce
No response
Are there any recent changes that introduced the issue?
No response
OS
Windows
Architecture
x86
Platform
WSL2
Ollama version
ollama version is 0.1.20
GPU
Nvidia
GPU info
NVIDIA GeForce RTX 3070 Laptop GPU, compute capability 8.6
CPU
AMD
Other software
No response

Multiple concurrent model support is tracked in #2109 and is something we're working towards supporting.

Multiple concurrent model support is tracked in #2109 and is something we're working towards supporting.

In some way multi model already works I just can tell for Linux users:
https://github.com/ollama/ollama/issues/2109#issuecomment-2016416883

Multiple generation models work for me but not the embedding model and the generation model as OP stated


creating a correction

I have not understood the bug myself, can some one enlighten me of the bug and it adverse effects.

What issue or bug are you referring to?

Closing this issue since no further clarification was provided.


⚠ Bofrost.lu has degraded performance

In 8d2c97e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1011 ms

Resolved: Bofrost.lu performance has improved in 0fbe8c1 after 20 minutes.


Update: use regexp

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          52     52
  Lines         596    593    -3
=====================================
- Hits          596    593    -3

Impacted Files
Coverage Δ

problems/most-common-word/most_common_word.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d90622...72520dd. Read the comment docs.


markdown: Fix bullet list indentation bug

Previously, the frontend-only javascript processor didn't show the same
output as the backend, resulting in wrong output shown in drafts.
Fixes #10966
Tested various changes to the list implementation in marked.js and the final working solution that I came up with was, since we follow 2 spaces for the next item in a list why not replace all the odd number of spaces to even by reducing 1 space from them, thus adding a replace statement.

@AsociTon I'm skeptical that this won't create other bugs, but am not an expert in the marked.js implementation.  @aero31aero @tommyip FYI in case you have ideas for a better solution.

I would like to see some test cases along with this.
Off the top of my head, I don't think we need the /gm flags here, and the regex seems to be specific to only these problems.
The following test case, for example, would still be different on the frontend and backend because the frontend treats anything beyond four as a 4 space indented codeblock.
- zero
 - one
  - two
   - three
    - four
     - five
      - six
       - seven
        - eight

I will add some test cases.
I checked by removing /gm flags but removal of any of the global or multiline flag makes the logic ineffective, also when we use - or + for instead of * the frontend logic doesn't treats them as list indicators while the backend does.

found this bug while adding node tests, due to the removal of the space the last list element if had odd number of spaces would have the last character left in src which was further processed into  tags causing the above bug, so added 1 to the substring method to take care of such case, another approach I thought of was to apply replace on src too but it would just increase the overall cost of the operation unnecessarily so added 1 to the substring method instead.

I don't know how I missed it at that time, but just repositioning the replace statement was enough to remove the above raised bug, finally did it : ) , and all the test cases pass it too!

Included a frontend test for the odd number of spaces mixed with even spaces for the marked.js implementation, One more case that would be great to add once #11860 is resolved would be to create a miscellaneous test case comprising of +,-,* along with odd and even spacing and that would actually cover almost everything for lists in case of frontend.

ready for a review : )

@aero31aero can you give this another review?

Tested manually, this looks good to me.
On Mon, Apr 22, 2019, 5:39 AM Tim Abbott<EMAIL_ADDRESS>wrote:

@aero31aero https://github.com/aero31aero can you give this another
review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/11830#issuecomment-485292435, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB5JHVT2EVR53SVYT4XAXK3PRT64VANCNFSM4G4XDCLA
.

Actually, I'm sorry I forgot to run that earlier test case with 8 levels of indents. It is still failing. How many levels of list indents do we want to support?
Regardless, I would like to see that added as a test-case in markdown-test-cases.json, even though the backend and the frontend render it differently.

Ideally an arbitrary number of indents, unless there's some reason that's technically infeasible.  You can look at babelmark for how other markdown processors handle this.

Closing as we're generally thinking of standardizing our markdown processor via aligning with Djot or commonmark rather than doing custom changes like this.


A faster way to Get Started

Awesome tool, many thanks for making this available!
I have a suggestion for an addition to the Getting Started section. To open an empty muboard even faster you can enter
data:text/html, <script<EMAIL_ADDRESS>directly into the browser address bar. Works with Chromium 91.0.4472.114 on Arch Linux.

Sorry I just saw that this is what calling muboard.net does. My bad :)


Applying a logistic operator on NaN returns None instead of Bool

from databricks import koalas as ks
import pandas as pd
import numpy as np

##### pandas #####

pser = pd.Series([0, 1, 2, np.nan])
>>> pser
0    0.0
1    1.0
2    2.0
3    NaN
dtype: float64

>>> pser == 0
0     True
1    False
2    False
3    False  <- bool
dtype: bool

##### koalas #####

kser = ks.from_pandas(pser)
>>> kser
0    0.0
1    1.0
2    2.0
3    NaN
Name: 0, dtype: float64

>>> kser == 0
0     True
1    False
2    False
3     None  <- not bool
Name: 0, dtype: object

It's subtle .. thanks for catching this. Are you interested in opening a PR for this issue @harupy ?

Yes, I'll create a PR!


Commit are missing when they have a body without blank line

Describe the bug
If I have a commit with with line like
fix: add something

or a commit with a blank line after the message:
fix: add something

Some description

They show in the changelog.
But I have a commit without a blank line
fix: add something
Some description

They are not showing in the changelog.
To reproduce
Add a commit with the body. Without a blank line.
Expected behavior
All commits to show in changelog
Screenshots / Logs

Software information

Operating system: MacOS 13.4
Rust version: N/A
Project version: 1.3

Additional context
Thanks

try adding { pattern = "\n", replace = " "} in your commit_preprocessors in cliff.toml.
If you don't use other preprocessors, it should look like this
commit_preprocessors = [
    { pattern = "\n", replace = " "}
]

@alfonsocuccaro thanks, that is good workaround. The missing commits are now showing.
However this seems to be conflicting with link_parsers. After doing this, links appear twice in the changelog. E.g. we have a commit like:
feat: add something
https://stax.atlassian.net/browse/ABC-1234

In the changelog the link appears twice
- Add something https://stax.atlassian.net/browse/ABC-1234  [ABC-1234](https://stax.atlassian.net/browse/ABC-1234)

Link parser looks like
link_parsers = [
  { pattern = "https://stax.atlassian.net/browse/(\\w+)-(\\d+)", href = "https://stax.atlassian.net/browse/$1-$2", text="$1-$2"}
]

Hello! Sorry for the late reply.
Commits in the given format are not conventional according to the conventional commits specification,. That's why the underlying library (git-conventional) is unable to parse them thus they do not appear in the changelog. (see the parser here.)
In order to have these commits in the changelog, simply disable conventional commits filter:
[git]
# parse the commits based on https://www.conventionalcommits.org
conventional_commits = false

Now they appear in the changelog as follows:
### Bug Fixes

- Fix: add something
Some description

You can use commit_parsers to change the group/scope of the commit:
commit_parsers = [
  { message = "^fix", group = "Bug Fixes" },
]

Link parsers should also work as expected now.
I hope this helps! 🐻


Documentation conflict regarding postStart

This is a Bug Report
Problem:
Documentation exists that states a container enters a "running" status prior to executing "postStart" hooks.  Other documentation, and observed behavior, states a pod does not enter a "running" status until after "postStart" hooks complete.
Proposed Solution:
Fix the documentation to reflect current behavior.
Currently reads

Once a container enters into Running, postStart hook (if any) is executed. This state also displays the time when the container entered Running state.

Should read

The postStart hook (if any) is executed prior to the container entering a Running state.  This state also displays the time when the container entered Running state.

Current observed behavior is documented here
https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#discussion

The Container’s status is not set to RUNNING until the postStart handler completes.

Page to Update:
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-states

@jjulien would you be willing to replace the pictures of hyperlinks with the URLs as text? That'll help people who want to follow those links.
(you can edit the description of your issue)

Yea, I don't know what was going on when I created this.  It automatically created those images when I tried to paste in the URLs.  They should work now.

Thanks @jjulien
/priority backlog
/good-first-issue

@sftim I can take this one.

I will try to pick this one.
/assign

/close


Cleanup unused code.

Removed the unused classes:

ArrayBasedDocValIterator.java
ArrayBasedSingleValueBlock.java
ArrayBasedSingleValueSet.java
IntArrayBackedImmutableDictionary.java

Current coverage is 64.21% (diff: 100%)

Merging #831 into master will decrease coverage by 0.09%

@@             master       #831   diff @@
==========================================
  Files           727        727
  Lines         34109      34109
  Methods           0          0
  Messages          0          0
  Branches       5218       5218
==========================================
- Hits          21935      21903    -32
- Misses        10625      10659    +34
+ Partials       1549       1547     -2

Powered by Codecov. Last update 69432fb...25a1b26


Work with Firefox's Reader Mode

I use your addon frequently and use Reader mode just as frequently, but once I've entered reader mode the addon does not function properly.

It should detect this URL (or detect if it's in reader mode) and strip this part out before queries or submissions to reddit.

Thank you for the report, I will do this as soo


in DeepTilingModels.py file the function create_sentence_pair is not defined

I added the create_sentence_pair function in DeepTilingModels.py


May I know what is the required scikit-learn version for scikinC?

Thank you for sharing this great project.
I get GradientBoostingClassifier has no attribute loss_ error.
I guess ScikinC is using an old scikit-learn version?
May I know which scikit-learn version used in this project.
Thanks!

Hi, it is tested against scikit-learn 1.2.2 , but test coverage is admittedly not very high.
This might be a genuine bug.


[Google Search] ...

Extension
https://www.raycast.com/mblode/google-search
Description
Would be super excellent if this extension also had the ability to do a google image search (if it already does and I'm missing it, please excuse my being a dummy)
Who will benefit from this feature?
Pretty much anyone and everyone who likes/uses images
Anything else?
No response

Nevermind. I am a dummy, but finally manages to figure out how to do it with a Quicklink ("https://www.google.com/images?q={Query}" in case any other dummies stumble across this)


Add Array#flatMap method

Fixes part of https://github.com/facebook/flow/issues/7397

@nmote

Why does the mapper function return $ReadOnlyArray<U> | U, instead of just $ReadOnlyArray<U>?

@samwgoldman flatMap can work like map
[ [1, 2, 3] ].flatMap(() => 1) // [1]

Oof. Annoying, but certainly in line with the gratuitously overloaded nature of existing APIs.

Well, it's easier to use with conditionals
[ [1, 2, 3] ].flatMap((a) => a[0] === 2 ? a : 1)

this would be much bigger if flatMap supported only arrays

It seems easy enough to just write this:
[ [1, 2, 3] ].flatMap((a) => a[0] === 2 ? a : [1])

oops


Fix access to elements of dense matrices in some methods

In some methods the elements of dense matrices where accessed in row-major order, while they are kept in the column-major order. hat affected the performance very badly.

I apologize for misspelling some words in the commit description - but I hope the sense is clear.

Hi Tzanio,
You're right. Here the order is important.
Cheers,
Mikhail


Optimize if not  then  else  end -> if  then  else  end

if not x then print"hi"else print"bye"end

Can be minified (and optimized) into
if x then print"bye"else print"hi"end

Even better:
print(x and "bye or "hi")

pseudo play
if x then print"bye"else print"hi"end
For each IfStatement node with IfClause and ElseClause, when the body of both clauses is the CallStatement with the same identifier.
Given that pattern is satisfied,

Generate CallStatement node (above IfStatement) with CallExpression, appending (to arguments): LogicalExpression with or operator & LogicalExpression with and operator.
On logical or operator, assign:

left to be the logical and operator,
right to be an argument value (under the ElseClause). (i.e. "hi")

On logical and operator, assign:

left to be condition of the IfClause, (i.e. x)
right to be an argument value (under the IfClause). (i.e. "bye")

Remove the IfStatement.

An additional check could be made to swap the two rights, if the condition of the IfClause appears to have not.
Correct? 🤔
this one is a bit long xD


Fixed websockets

Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.38%. Comparing base (6b6290d) to head (04e0d57).

Files
Patch %
Lines

pkg/httptools/websocket.go
0.00%
11 Missing :warning:

pkg/test/test_websocket.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   28.50%   28.38%   -0.13%
==========================================
  Files          37       37
  Lines         905      909       +4
==========================================
  Hits          258      258
- Misses        639      643       +4
  Partials        8        8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implemented a delete action as per #41

Can now delete an image by setting delete-icons to true and clicking the delete icon on either the thumbnail or gallery. Confirms with the user if they want to delete the image. Will go to the last image in the array after the delete action has occurred. A on-delete callback has also been implemented. Supports edge cases such as an empty images array.
Example usage:
<ng-gallery images="ctrl.images" delete-icons="true" on-delete="ctrl.callback()"></ng-gallery>

Can you post an example of how to use the onDelete callback from the angularjs controller? The callback isn't being called in the controller when I use your implementation.
It's almost as if scope.onDelete({image: image}); isn't actually calling the callback function defined in the controller (passed into the directive as such: <ng-gallery images="images" onDelete="imageDeletedFromGallery()" ng-if="images.length">                 </ng-gallery>


[docker] Fix error in docker build

Hey, I just made a Pull Request!
The step ADD packages/backend/dist/bundle.tar.gz app-config.yaml ./ is also unpacking the tar file.
Before:
Step 4/8 : RUN tar xzf skeleton.tar.gz && rm skeleton.tar.gz
 ---> Using cache
 ---> cf30b6b11527
Step 5/8 : RUN yarn install --frozen-lockfile --production --network-timeout 300000 && rm -rf "$(yarn cache dir)"
 ---> Using cache
 ---> a225e50b3990
Step 6/8 : ADD packages/backend/dist/bundle.tar.gz app-config.yaml ./
 ---> Using cache
 ---> bb1f2488e1ea
Step 7/8 : RUN tar xzf bundle.tar.gz && rm bundle.tar.gz
 ---> Running in 91107ee4a847
tar (child): bundle.tar.gz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
The command '/bin/sh -c tar xzf bundle.tar.gz && rm bundle.tar.gz' returned a non-zero code: 2
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 2

and
$ docker run -it -p 7000:7000 -e NODE_ENV=development  example-backend:latest
2021-04-23T17:10:13.252Z backstage info Loaded config from app-config.yaml
2021-04-23T17:10:13.268Z backstage info Created UrlReader predicateMux{readers=azure{host=dev.azure.com,authed=false},bitbucket{host=bitbucket.org,authed=false},github{host=github.com,authed=false},gitlab{host=gitlab.com,authed=false},fetch{}
2021-04-23T17:10:13.455Z catalog info Locations Refresh: Beginning locations refresh type=plugin component=catalog-all-locations-refresh
2021-04-23T17:10:13.460Z code-coverage info Initializing Code Coverage backend type=plugin
Backend failed to start up [Error: ENOENT: no such file or directory, scandir '/app/plugins/code-coverage-backend/migrations'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/app/plugins/code-coverage-backend/migrations'
}

After:
Step 4/7 : RUN tar xzf skeleton.tar.gz && rm skeleton.tar.gz
 ---> Using cache
 ---> cf30b6b11527
Step 5/7 : RUN yarn install --frozen-lockfile --production --network-timeout 300000 && rm -rf "$(yarn cache dir)"
 ---> Using cache
 ---> a225e50b3990
Step 6/7 : ADD packages/backend/dist/bundle.tar.gz app-config.yaml ./
 ---> Using cache
 ---> bb1f2488e1ea
Step 7/7 : CMD ["node", "packages/backend", "--config", "app-config.yaml", "--config", "app-config.development.yaml"]
 ---> Running in b28b5aa00b20
Removing intermediate container b28b5aa00b20
 ---> 45b33f814f2a
Successfully built 45b33f814f2a
Successfully tagged example-backend:latest
Done in 145.11s.

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Did you see #5088? I wonder what the issue was there that introduced this change - but you are right the current state in somewhere in between 😆

@freben, can you please take another look?


[5.6] Added 'rules' method to SendsPasswordResetEmails class

Implemented a rules() method that returns an array of rules for the email validation.
Utilized the new rules() method in the validateEmail() method.
The intention is to simplify rules extension in this trait, by simply overriding the rules() method in the controller, while maintaining the current funcionality stable.

Thinking the docblock comment is ok as-is.

@devcircus Should I take the change in the comment?

I'd just leave and see what Taylor says

You can just override the method entirely and specify your rules.

@taylorotwell Ok, it's just that a really close trait (ResetsPasswords) works with the rules() method.
IMO, having two different ways to extend such close traits it's counter-intuitive. I had already overriden the rules() method in ResetsPasswords, when I tried to do the same with SendsPasswordResetEmails I was shocked it didn't worked, since most things in Laravel follow a pattern.


Improve Deinit type

Follow-up of #5654

Make Deinit actually useful
Allow it to be an array
Enable no-redundant-type-constituents lint rule


Increase/control timeout

OkHttp default timeout is 10 sec, as transaction post is synchronous and will return after transaction is complete (see https://www.stellar.org/developers/horizon/reference/endpoints/transactions-create.html), we should control or increase this value.
FYI @berryve

fixed by https://github.com/kinfoundation/android-stellar-sdk/pull/6


Have the pluginHead branch auto sync to plugin head.

And document it.
Fixes #33
NOTE: This is a merge of a branch in the main repo to master.  I could not figure out a way to propose a merge request from my fork to a not-yet-existent branch in the upstream.  After this PR goes through we would keep pluginHead, and then merge master into pluginHead whenever new libraries are added.

I'm not a fan of having to constantly remerge master into pluginHead.  If you've got a better idea, let's do that and delete this branch (it has no effect on master yet).

We can get it to build to the latest version by querying the repo tags - see comments about this.
My big question is how is this build triggered? On a time basis, e.g. every 24 hours? It looks like Travis-CI isn't interested in kicking off a build based on a dependant repo: https://github.com/travis-ci/travis-ci/issues/631

Per https://github.com/j2objc-contrib/j2objc-common-libs-e2e-test/pull/38#discussion_r40638717 I'm just closing this PR for now.
We don't need this complexity.


[SPARK-36120][SQL] Support TimestampNTZ type in cache table

What changes were proposed in this pull request?

Support TimestampNTZ type column in SQL command Cache table
Why are the changes needed?

Cache table should support the new timestamp type.
Does this PR introduce any user-facing change?

Yes, the TimemstampNTZ type column can used in CACHE TABLE
How was this patch tested?

Unit test

Test build #140973 has started for PR 33322 at commit 8f9e2bd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45487/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45487/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45487/

Test build #140973 has finished for PR 33322 at commit 8f9e2bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140973/


Fixed merging with self bug.

Issue https://github.com/JamesNK/Newtonsoft.Json/issues/2043
JArray cleared when merged with itself with setting MergeArrayHandling = MergeArrayHandling.Replace.

Thanks! Merged here - https://github.com/JamesNK/Newtonsoft.Json/pull/2134


How to use screenProps on a nested navigator?

The implementation of screenProps as described in the documentation makes sense when you have a single navigator, or if you want to apply screenProps to the root navigator. But what if you want to apply screenProps on a nested navigator? Consider the following setup:
const MainNavigator = StackNavigator({
  ...
  Tabs: { screen: Tabs },
  ...
});

const Tabs = TabNavigator({ // want to apply special screenProps on these nested tabs
  ...
  SomeScreen: { screen: SomeScreen },
  ...
});

Only MainNavigator gets exposed in JSX as a ReactComponent since it's the main entry point:
const App = ({ dispatch, navigationState }) => (
    <MainNavigator
      navigation={addNavigationHelpers({
        dispatch: props.dispatch,
        state: props.navigationState,
      })}
      screenProps={/* root screenProps would go here */}
    />
);

Tabs never gets exposed as a ReactComponent in JSX since it's essentially handled by MainNavigator. So... how do you assign screenProps to it?

But what if you want to apply screenProps on a nested navigator?

Root screenProps will get propagated to all the components within that nested navigator. You will have access to main screenProps inside each of the component (just tested).

Tabs never gets exposed as a ReactComponent in JSX since it's essentially handled by MainNavigator

Yes, but you can always define a custom React component (screen) that renders that TabNavigator and issue would be gone.
Tip: You can just pass this.props.navigation instead of addNavigationState({...})

@grabbou I had a similar issue and did what you suggested at the end there.

you can always define a custom React component (screen) that renders that TabNavigator
I can use this structure to pass screenProps but it brakes deep linking to anything nested under that custom component.

const MyTabNavigator = TabNavigator({
  ...
  Profile: {
    screen: ProfileContainer,
    path: 'profile',
  },
});
...

ProfileNavigator = StackNavigator({
  ...
  Foo: {
    screen: Bar,
    path: 'foo',
  },
});

class ProfileContainer extends Component {
  render() {
    return <ProfileNavigator />;
  }
}

myapp://profile takes me to the Profile screen, but myapp://profile/foo does not take me to the Foo screen, just stops at the Profile screen. Any suggestions on an alternative approach to passing screenProps or how to restore deep linking functionality?

Any update to this issue? I have a nested navigator I want to reuse with a true flag on one, and a false flag on the other.

@mattfysh I pass screenProps into my root navigator and am able to access them via the screenProps. prop from all of my nested navigators.  This is with v1.0.0-beta.13.

@GollyJer This worked for me as well!


confirmSetupIntent doesn't return any callback(promise)

Describe the bug
confirmSetupIntent hook doesn't return any promise in android but new card is adding successfully in stripe.
I'm getting paymentMethod result from createPaymentMethodand hook and its id is correct and call the confirmSetupIntent method from useStripe hook and also it adds a new card into customer's file in stripe but it never returns any result.
There is no error/warning in Android logs.
I haven't tested it out on iOS device.
  const { createPaymentMethod, confirmSetupIntent } = useStripe();

  const saveCard = async () => {
    setLoading(true);

    const createPaymentMethodResult = await createPaymentMethod({
      paymentMethodType: 'Card',
    });

    const paymentMethod = createPaymentMethodResult?.paymentMethod;

    if (!paymentMethod) {
      // ERROR - this part is working fine
    } else {
      const clientSecret = await createPaymentCard(paymentMethod.id);

      if (createSetupIntentResult.success) {
        const { error: confirmSetupIntentError, setupIntent } = await confirmSetupIntent(clientSecret, {
          paymentMethodType: 'Card',
          paymentMethodData: {
            paymentMethodId: paymentMethod.id,
          },
        });

        // UNREACHABLE
        console.log('error', confirmSetupIntentError);
      }
    }
  };

Expected behavior
Catching error of confirmSetupIntent or setupIntent after call confirmSetupIntent method.
Desktop (please complete the following information):

OS: Macos M1 12.6
React: 0.64.0
Version 0.17.0

Smartphone (please complete the following information):

Device: Xiaomi Readmi 10 MUI 13

Additional context
Add any other context about the problem here.

Some of our users are facing same issue, personally I can't reproduce on emulator or real device.

Hi! this was fixed in v0.18.1


Anyone managed to do this with Gmail?

Documentation to set up gmail webhooks is terrible.
Anyone managed to do this and can give some guidance?

It's been a while since I looked at gmail webhooks. Do you have a pointer?

I have made some progress but still not 100% on the workflow. https://developers.google.com/gmail/api/guides/push

This issue was copied to aspnet/AspNetWebHooks#18

This issue was moved to aspnet/AspLabs#53


improve height calculations to not be influenced by global css

@andreypopp any downsides I might have missed?

Thanks!


Aurora League of Legend Profile overrides everything

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ x] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
After uninstalling Aurora it should not switch anymore to League of Legends profile
Actual behavior:
Everytime I boot up my pc or shut it down it always switches to the League of Legends settings (even tho I have uninstalled Aurora and even changed the Lightning Settings. Same issue when I go into a Linux destribution. this damn league of legends profile is ALWAYS active
How often does this problem occur?

This problem occurs... everytime
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Activate League of Legends Profil
Optional maybe: install the league of legends thing in options
restart pc and see how the lightning always switches to that light setting

What is the version of Aurora you are experiencing this issue with?

My version is... the latest one
Does the previous version of Aurora have this issue?
The previous version, (Fill in the version here), did/did not have this issue.
yes
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: http://pastebin.com/
For screenshots, you can use: http://imgur.com/
For files, you can use: http://www.tinyupload.com/ , https://www.dropbox.com/ , or attach them to the issue.

i have ni idea but did you delete the patch in league i mean the light fx thing

There is no uninstall light fx patch. Also the patch is beeing installed into the game folder and the bug has nothing to do with any application. the lightning issue I have always happens when the Keyboard is loading anything, starting up or whatever. it always switches to that months old profile i made which I already deleted and never used again. It also is active in any Linux OS or BIOS or whatever.

Try to press the lightning key and numbers at the same time. That's the hardware combination to change color patterns. You can also press lightning and +/- to change the speed of the effects.

I have the Corsair K70 Lux not sure if I can do that.

I made some screenshots to show you how it looks like:
When i switch bios mode, turn pc on or off, close corsair utility engine or uninstall the drivers completely:
https://i.imgur.com/ApX5wIP.jpg
When I put it into the Steam Link:
https://i.imgur.com/r7SQPk9.jpg
When I boot up Linux and use that:
https://i.imgur.com/aUSfLy2.jpg
It seems like that old profile I made in Aurora for League of Legends has burned itself into the Corsair K70 Lux keyboard and I can't seem to get rid of it.

Oh, I'm sorry. I assume people have the same hardware as me...
Anyway, my keyboard doesn't have a flash memory but probably yours does. I don't know how to change it but wouldn't CUE alow you to do that?
My mouse has 2 modes: Flash memory and Computer-stored profiles; maybe there's something like that for corsair?
Sorry I'm not helping much but I don't own any corsair devices.

I checked CUE and didn't see any flash mode. I tried forcing the newest firmware update on the keyboard but it didn't change anything. But how is it possible that Aurora flashes the league of legends profile on my keyboard memory ?


Explore Python IntelliSense in Copilot chat code blocks

This is an open ended, exploratory item
VS Code recently enabled intellisense in copilot chat code blocks. Although this is mostly implemented in a language agnostic way, language extensions may need to make some changes to get the best support
For this exploration, I'd like the python team's help testing out IntelliSense in copilot chat code blocks. I've provided a list of ideas on what to test below, however feel free to build on it. I've gone through them for JS/TS and found them to be a good starting point. You can also file feature request against VS Code for new feature ideas
Areas to test

The Python extension should see TextDocuments for each chat code block
There will actually be two docs per code block, one with the scheme vscode-chat-code-block: and one with the scheme vscode-copilot-chat-code-block:.  vscode-chat-code-block is the scheme used by VS Code core to provide basic intellisense (such as expand selection. vscode-copilot-chat-code-block is the scheme used by copilot to provide go to definition support. This is needed because copilot registers itself as the go to def provider for vscode-chat-code-block

Basic syntax language features — such bracket matching and Smart Selection — should always work

You should never see errors reported for code in chat code blocks
Try asking copilot to generate invalid code to confirm this

Test hovers and go to definition within a single code block
For example if you ask for binary search in python, there should be a single code block that has these IntelliSense features

Make sure these features work for global symbols
Also test IntelliSense for symbols defined within the block
Check that any special python features in hovers (such as links) work as expected
Make sure the code block IntelliSense observes any relevant workspace/project settings

Test cross code block IntelliSense
Ask a questions such as binary search in python and follow up by asking write some tests for it. The second code block should use the binary search function defined in the first. Inside of the second code block you should be able to hover on it to see documentation and use go to definition on it

Test IntelliSense for workspace symbols
This feature is mostly handled by copilot but still worth testing. For it, as a @workspace question to find code in the workspace. For example, @workspace where's the code for binary search

Make sure can use hover, go to definition, go to implementation, and go to type definition for symbols that come from the workspace
Make sure you can still use these features for globals and locals too

Make sure that code in code blocks is never picked up as a reference
If a code block uses a global symbol for example, when you run find all references  on that symbol in a normal workspace file, you should not see the use in the code block listed

Make sure symbols code blocks never shows up in workspace symbol search

Explore any python specific features/behavior of these IntelliSense features inside these chat code blocks

Think about if there's any additional IntelliSense features that would help users understand code inside of chat code blocks

I'm wondering if our import resolution is going to work. The schema will make us think the file is not on the local file system, so we won't search the workspace. We might have to special case the schema here.

default workspace might work with stdlib with any random url in async server. but that said, feels like it might be better to just create new workspace that deals with copilot specifically? like copilotWorkspace ? and we enable or disable certain features there?

next week I'll try to look more deeply into this, since right now we only support vscode-chat-code-block and I was struggling to get a Pylance build with vscode-copilot-chat-code-block and I'm not sure why.
But so far I noticed that when Copilot uses one of the workspace files as reference, go to def and hover works as expected.
With reference:

No reference (nothing shows when hovering models)

Also noticed that go to definition on .models takes to the Django built-in models module, not my models.py file. But the classes go to the models.py as expected:

Errors are not being displayed indeed, although a few diagnostics such as unaccessed symbol or unreachable code are displayed (note that the "experimental pylance" string is a known bug that has just recently been fixed):

Apart from that, everything else worked well: bracket matching, smart selection, go to def on global variables, response results not showing on symbol search

@mjbvz is there anything special we should do to support this for multi-root workspaces? or should it be working out of the box?

Chat searches through all workspaces so a generated code block may come from files across workspaces. You'll need to make sure Python can correctly handle this when resolving symbols in the code block text document
Beyond that though the feature should mostly just work for multi root workspaces

@mjbvz I think it is very hard for us to support this in its current form. For example, we don't even know when to clear states we create and hold for these random LSP requests. Also, a generated code block may come from files across workspaces, I think we won't be able to support this in any stable way.
If we want this to work, vscode should send something like onDidChangeWorkspaceFolders (workspace/didChangeWorkspaceFolders) for the code block and remove them when you are done with the code block.
If you want to group some code blocks (virtual files), put them in the same workspace (under the same root URI) so the code blocks can see each other. Otherwise, put them in different workspaces (under different root uri).
When they are done, by removing the workspace, you let us know when we can clear states.
As for the referenced files for the code block, I am not 100% sure how you want us to handle it. Since resolving imports/symbols requires knowing where the root is to properly handle them, regardless we search all workspace/files (that could be expensive), without all necessary information, we won't be able to do it reliably. we could do some best effort stuff with heuristic, but that will always feel work randomly.
if the URL is not opaque, you can add those referenced files through fileopen with a specific URI (such as vscode-xxx://rootUri-for-code-block-workspace?file=/fullpath/to/file.py) so we can map the virtual file you added to the actual file on disk. and from there, we can figure out root of workspace for the file.py and how to resolve it correctly.
open to other idea, but I am not 100% sure how we are supposed to figure out what file/module/symbol the import statement is referring to from random text. that will probably only work for demo, but not in real code?

I'm thinking this would be a good start?

we can do that for stdlib, typeshed, site-packages ones assuming they are using default ones.

We could potentially  also support this for 3rd party packages if they're installed in the workspace (e.g. supporting go to def on test below)

To @heejaechang's point on how can Pylance know when to "let go" of the code blocks, this sounded like a good idea?

If we want this to work, vscode should send something like onDidChangeWorkspaceFolders (workspace/didChangeWorkspaceFolders) for the code block and remove them when you are done with the code block.

@mjbvz  would that make sense as a feature request to VS Code core?

@luabud ya, we can support other import roots that we can get from settings such as python interpreter or extra paths and etc that we would normally get for default workspace. we could support user files by adding all regular workspace roots in extra path, but that will only work if generated code has import statement from the workspace root like from helloworld.models

@luabud Restricting this to stdlib and 3rd party packages sounds reasonable to me. Resolving local files is something we should investigate longer term but is much more complicated
Your extension should not worrying about manage document lifecycle manually.  The LSP will synchronize these the same way as it does with other in-memory text documents
I don't think using workspaces makes sense. However chat code blocks uri do use the conversation id as their authority so they can be grouped by conversation:
vscode-chat-code-block://conversation-id/code-block-id

sure, we can use that to create implicit workspace ourselves.


fix: don't error if no open brace is found on control flow expressions

fixes #141

@a-h Is this how you would expect this to have been fixed?

Very close. I was thinking about attempting to search for a greater number of symbols before templ complains about a malformed for or if
For example. The for statement must be constructed in a number of ways.
package main

import "fmt"

func main() {
	var x int
	for ; x < 10; x++ {
		print(x)
	}
	fmt.Println()
	for y := 0; y < 10; y++ {
		print(y)
	}
	for {
		break
	}
	fmt.Println()
	var y int
	for y = 0; y < 10; y++ {
		print(y)
	}
}

https://go.dev/play/p/RjaP5Hj5HkV
I was thinking of still complaining about the for statement not being closed if there's a semicolon in the line. However, that would simply reduce the times that the spurious error occurs.
My concern was developers accidentally turning a malformed for loop into printing for x := 0; x < checkSomething(); x ++ to the HTML.
So I was thinking about ways to reduce the number of spurious errors while providing some protection against forgetting to close a for loop start expression.

Makes sense. It's finding that line between errors that stop someone from writing certain things in an element and allowing broken for loops to be written.
I guess where it gets harder is if and switch statements, they are unlikely to contain any discerning character between the keyword and the open-brace.


How I manage my own domain knowledge articles?

I want to know the format of my documents if I want to fine-tune a model on my domain knowledge.
If my documents are many complete articles should I split them into many small questions :
: questions from articles :answers from articles
or can I feed the model with original article(how can I feed the model with my whole article?).
many thanks!

I also want to know how to deal with the long article or long conversation, many many thanks!.


Update BioBar.tsx dark title implemented

✨ Codu Pull Request 💻

👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
Pull Request details:

INFO ABOUT YOUR PULL REQUEST GOES HERE (Please be as descriptive as possible) 🤜

Any Breaking changes:

IF ANYTHING YOU'RE COMMITTING WOULD BREAK SOMETHING, INCLUDE HERE WHAT WOULD BREAK
IF YOU HAVE NO BREAKING CHANGES, ENTER 'None'

Associated Screenshots:
( Welcome file extensions include gifs/png screenshots of your feature in action )

IF YOU HAVE ANY SCREENSHOTS, INCLUDE THEM HERE.
IF YOU HAVE NO SCREENSHOTS, ENTER 'None'

Feel free to reopen if you want to retake the issue before someone else. 🦾


fix read-targets bug

'() is not safe when calling the outer function many times.
check this out: https://stackoverflow.com/a/16673364

"expand-file-name" will complain when calling
"project-cmake-api-current-buffer-target" in the non
file-buffer.

Thanks for the fixes. They have been merged into main.


Capture the top-level project in the Maven extension

We could do something similar to https://github.com/gradle/gradle-enterprise-build-config-samples/pull/30 so that we capture the top-level project (as specified with -f) in a custom value that's attached to the build scan.

Not sure if this applies here (@marcphilipp invited me to join the discussion): We do have typical builds with mvn -am -pl <project list>: Several modules from a multi-module build would be build then including their dependent modules. For this case it would be hard to derive a proper project name. In multi-module builds we do have many entries in the scan list, all with the same top level project name. From my point of view a custom name would be great (e.g., something like -Dscan.build.name=...).

That's an interesting problem, but out of scope for these extensions as we (the Spring team) don't have any Maven-based builds where we use -pl <project list>.

Thanks, addressed this directly to Gradle: gradle/gradle-enterprise-build-config-samples#32

We're no longer using Gradle Enterprise with Maven.


Feat/update login wording

Sign up to create an account
Login in to Sign in (Amplify comp default to ensure consistent wording for all click events etc.)

TIS21-4836

@Judge40 just saw another runtime console error locally so closed it just in case - but false alarm! 😅

Kudos, SonarCloud Quality Gate passed!
  0 Bugs
  0 Vulnerabilities
  3 Security Hotspots
  9 Code Smells
 68.3% Coverage
 1.8% Duplication

I'll address some code smells in follow-up


fix(i2c-io): fix i2c-io can't write byte

Codecov Report

Merging #4 (bd64e0d) into main (1bf2fdd) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main     #4   +/-   ##
===================================
  Coverage   0.0%   0.0%
===================================
  Files         8      8
  Lines       487    487
===================================
  Misses      487    487

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Ugh, sorry about that. Ignore the failures, it's a new gosec check, this should be fixed separately.


added workflow for closing old issues

Related Issue
Fixes #215
Description
This feature aims to automate the process of managing old issues, ensuring that the repository remains organized and focused on relevant tasks. By automatically closing old issues, it reduces manual overhead for repository maintainers and helps keep the issue tracker tidy and up-to-date.
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist

[X] I have performed a self-review of my code.
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@Ajay-Dhangar please review and merge this PR
Also, please add labels to this PR
Thank You!


hello,nice work for face recognition!have you tried all the loss function that you list?which is best so far?

thx, I have not compare the performance of all loss functions.


Types not compatible with Pixijs 6.0..0

Upgraded from Pixi 5.3.8 to 6.0.0 and it the type fail to extend the declarations of pixi.
Likely due to the fact that pixi.js 5.3.8 had ambient declarations while 6.0.0 seem to export them.

Its possible to extend global interfaces. What exactly do you want to extend?

Its possible to extend global interfaces. What exactly do you want to extend?

Hey, it is not working for me aswell. I am actually migrating to V6 pixi, everything works fine except pixi-layers
When i am extending my scene for example: export default abstract class Scene extends Stage
Stage is not extending from PIXI's container thus has no access to its properties.
i cant even add scene into app.stage because it is not instance of Container

Yes, I still didnt port it to v6. Too much work right now :(

Actually, you can help me with that - certain team members keep telling me that my plugins are not used by people and are not worth it for pixijs community. If you post that issue about pixi-tilemap in main pixijs with description of how you use it - that'll be appreciated :)

Actually, you can help me with that - certain team members keep telling me that my plugins are not used by people and are not worth it for pixijs community. If you post that issue about pixi-tilemap in main pixijs with description of how you use it - that'll be appreciated :)

pixi-tilemap works well for me (@pixi-tilemap v3.2)
i am using kinda custom implementation and usage of TILED editor.
import { CompositeRectTileLayer } from '@pixi/tilemap'; // I am using only this method from pixi tilemap
which is created for each layer. I can provide my code but i am not sure if it is correct way to use it.

@ivanpopelyshev
"pixi-filters": "^4.1.0",
"pixi-layers": "^0.3.1",
"pixi-particles": "^4.3.0",
"pixi-viewport": "^4.31.0",
Modules that i am currently using, they are very useful. Also i will use lights in future for my game and many other modules.

Saying that those modules are useless is kinda weird, all modules have their usecase.

Actually, you can help me with that - certain team members keep telling me that my plugins are not used by people and are not worth it for pixijs community. If you post that issue about pixi-tilemap in main pixijs with description of how you use it - that'll be appreciated :)

i think i missunderstood question :-P

There was a post with plugin list. Return it back please :) I'll move pixi-layers to v6 soon, dont worry

There was a post with plugin list. Return it back please :) I'll move pixi-layers to v6 soon, dont worry

Oh i am sorry
Plugins that i am using:
"@pixi/tilemap": "^3.2.0",
"pixi-filters": "^4.1.0",
"pixi-layers": "^0.3.1",
"pixi-particles": "^4.3.0",
"pixi-viewport": "^4.31.0",
I used those plugins in almost all projects i have ever done in PIXI

Just to chime in,
pixi-layers is absolutely essential to me and thanks for maintaining it
Ivan.
//J
Den tors 13 maj 2021 kl 17:57 skrev Naščák Martin @.***

:

There was a post with plugin list. Return it back please :) I'll move
pixi-layers to v6 soon, dont worry
Oh i am sorry
Plugins that i am using:
@.***/tilemap": "^3.2.0",
"pixi-filters": "^4.1.0",
"pixi-layers": "^0.3.1",
"pixi-particles": "^4.3.0",
"pixi-viewport": "^4.31.0",
I used those plugins in almost all projects i have ever done in PIXI
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pixijs/pixi-layers/issues/65#issuecomment-840656774,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADVCORKEJZA7IBYEO4JZFLTNPZGPANCNFSM4YV3INNQ
.

Pixi layer is awesome!!! Should be incorporated into Pixi.js if you ask me.🥳🥳🥳🥳🥳

All those plugins are awesome and save lot of time for people which are using PIXI Js. Pixi-layer should be implemented in PIXIJs by default aswell as Viewport (or any camera system) ( I know it is easy to make your own).
Also i found very useful pixi-tilemap plugin almost for all games which are using tile-based world

Actually, you can help me with that - certain team members keep telling me that my plugins are not used by people and are not worth it for pixijs community. If you post that issue about pixi-tilemap in main pixijs with description of how you use it - that'll be appreciated :)

I know many people who won't migrate to v6 only because of the missing pixi-layers support :) .

https://www.html5gamedevs.com/topic/47356-using-pixi-with-vitetypescript/
someone made custom typings

https://www.html5gamedevs.com/topic/47356-using-pixi-with-vitetypescript/
someone made custom typings

It looks good, could it be checked and added into main repo?

My friends, I just published @pixi/layers , version 1.0.0. Thank you for all the kind words, now its time to test it!
Functionality is the same, it requires a bit of migration regarding CanvasRenderer and Particles (see README).

And now i published 1.0.1 because of my derp in the only line of code I actually changed

Forgot globals :( now its 1.0.2


RSP-1686: WIP - add isPending prop to

[x] Expose isPending prop that blocks press events/styles
[x] Add usePending hook to manage delay from isPending to isPending + isIndeterminate
[x] Visually hide label and show progress circle when isIndeterminate
[ ] Add i18n'd "Loading" label when pending
[ ] Preserve button width when pending
[ ] Docs

✅ Pull Request Checklist:

[x] Included link to corresponding JIRA ticket.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
View the new "isPending" Button story.
🧢 Your Team:
RSP, AEP

@dkario I am so sorry about how long this one took. We are happy to pick up this work to carry it over the line. If you have comments, please let us know. I asked a couple of questions. Thanks for getting it started.

To be reopened when we pick this up again


Add line colors to links

Allow links to have different colours.
From the way the code has been written looks like the decision may have been made not to do this but here is a PR anyway.
Feel free to reject it. I won't be insulted :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It was on my to-do but I hadn't started yet.
Appreciate your contributions.
This will be included in v0.21.7.


Differentiate current user's chat messages

Probably by floating the current user's messages to the right, and perhaps applying some different styling to those messages, a la FB messenger, tinder, whatsapp, etc.
I'd like to make this configurable, with a default of 'off' (although depending on how good it looks I might be convinced to default it to 'on')
This will require a touch of design; if you're thinking to pick this up, I'd love to see a rough sketch of what you're thinking before implementing :smile:

I've decided against this, and since I'm the OP, I can close it.
ULTIMATE... POWER...
http://giphy.com/gifs/ultimate-warrior-wwe-wrestling-14n5Zi31QTEsla


Title bar problem.

After first launch, when logging in, at least on Ubuntu, there was no title bars  etc.
I think, this change fixed it:
frame: true

Although it removes custom title bar, it is less buggy. I also experienced that the buttons on title bar besides the closing one didn't work. Well, now when title bar is shell default everything works fine.
Another change is implemeting the install-deb.sh script. It checks if you have the deps, if not it installs them. In case I missed something please add it or tell me.
I was thinking about adding install instructions to the documentation. But I don't know about that, please tell what do you think.

This is now configurable so this PR is no longer required.


Did this project became closed-source?

This plugin was recently updated in the marketplace, but there are no changes in the repository. Did this became closed-source? Maybe this should be written in the readme?

Thank you for your interest in DevPilot!
Yes, DevPilot has had several updates on the market recently, and you may have noticed that there are also enthusiastic contributors contributing code in the community (allow me to thank @wsliliang  here).
We have no plans to change the project to closed source at this time. We are trying to design a more flexible solution than simply putting the prompt words in DevPilot, in order to better adapt to the various LLM and easy referencing of private domain knowledge.
We will show you more about this in our ReadMe in the near future.
Thanks again for your continued interest in DevPilot!


Add docs for linking gesture handler on RN >= 0.60

In the docs, I have added config to disable autolinking on both Android and iOS so that linking is easier with react-native-link. Otherwise the user needs to run git checkout ios to revert the changes which is another extra step there.
I haven't tested this. Just sent PR because people are having trouble and this is what I found.
cc @thymikee

No need to disable ios. You can pass --platforms android param to link only Android.

Maybe still worth disabling it? Otherwise we need to list 2 commands, one for React Native 0.60+ and one for below. If autolink worked for both platforms for gesture handler, these separate commands would've been avoidable.


[Bug] Gemini Pro模型不支持流输出

使用docker-compose部署的v2.10.1: Support Google Gemini mode不支持流式文本输出，只能全部输出结果。没有打字机效果哦~

使用docker-compose部署的v2.10.1: Support Google Gemini mode不支持流式文本输出，只能全部输出结果。没有打字机效果哦~

not ready, google currently doesn't have streaming mode in their RESTful API I think

not ready, google currently doesn't have streaming mode in their RESTful API I think

Streaming response is ready. But i haven't check it further. https://ai.google.dev/api/rest/v1beta/models/streamGenerateContent

it's still json

Streaming support is available in PR https://github.com/ChatGPTNextWeb/ChatGPT-Next-Web/pull/3688. Please create an individual issue if you encounter any problems.

https://github.com/google-gemini/cookbook/blob/main/quickstarts/rest/Streaming_REST.ipynb

add alt=sse in query_string, will get response with content type: text/event-stream


debug problem

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: One line description
Description:

Describe the issue.
1: (48501) 1302: elapsed time 0
1: (48735) ->&"DW_FORM_strp pointing outside of .debug_str section [in module /build/.cache/bazel/_bazel_envoybuild/b570b5ccd0454dc9af9f65ab1833764d/execroot/envoy/bazel-out/k8-dbg/bin/source/exe/envoy-static]\n"
1: (48735) ->(gdb)

initial parameter list，insider has break point。
[optional Relevant Links:]

Any extra documentation required to understand the issue.

Not clear what the problem is here, can you elaborate?

if I set break point in contructor of init parameter ,It will show up problem.


Ridge and RidgeClassifier schemas for sklearn >1.0 need to set forOptimizer to False for normalize.

If we set forOptimizer to False for normalize when sklearn version is >=1.0, there seems to be an issue in generating the search space for optimizers.
For example, test.test_core_classifiers.TestVotingClassifier.test_with_gridsearch fails for RidgeClassifier and test.test_core_regressors.TestRegression.test_Ridge fails for Ridge.

forOptimizer only takes care of a special branch/type not participating in the search space. But it does not remove it from relevantToOptimizer. So for a boolean type normalize, setting forOptimizer to False also needs it to be removed from the relevantToOptimizer list.


PR: Update ci for pdf generation

Generating pdf every corresponding push time makes repo's size larger and larger (now 600MB+). Using GitHub Actions to generate pdf like #144 is needed, so this PR makes efforts to:

Adapt the new repo structure of docsaurus;
Reuse old generate-pdf.sh & workflow to generate pdf now.

@skyleaworlder

 @skyleaworlder

@dengliming Thanks for pointing out the problem. I think this is because download OTF part of generate-pdf.sh in this PR is not correct now. I'll try to invoke GitHub Actions after I fix it.
Thank you and I might need another approval about GitHub Actions for I'm new here :)

Thank you and I might need another approval about GitHub Actions for I'm new here :)

No worry. you can ping me. : )

It's just too strange...

I want to rerun this workflow to check if this is not coincidence.

I feel SO SORRY. I found I just comment "prepare" function.

@dengliming I think it works well now~ Please check the log output and @ me if there are still some mistakes~

Thank you for all the help @JooKS-me and @dengliming have provided.
I will focus and keep an eye out for any follow-up bugs.

Thank you for all the help @JooKS-me and @dengliming have provided.
I will focus and keep an eye out for any follow-up bugs.

Good job!

@skyleaworlder Thanks for your contribution. Great job! Can you update the download page?
https://github.com/apache/incubator-shenyu-website/blob/main/i18n/zh/docusaurus-plugin-content-pages/download.md
https://github.com/apache/incubator-shenyu-website/blob/main/src/pages/download.md

@dengliming Of course it's my pleasure; I'm willing to update it.
But PDF links in shenyu.apache.org/download and shenyu.apache.org/zh/download are available now.
In addition, the newest PDFs are not uploaded to main branch. From my perspective, if I update these pages, it means that I need to change them to pdf links under this path (asf-site branch). Docsaurus seems to auto-generate pdf links to assets/files. I don't know if my change would destroy something or not.
Sincerely looking forward to reply to my doubts and some thoughtless considerations.

@skyleaworlder The old pdf links are written dead. You may need to use https://shenyu.apache.org/pdf/apache_shenyu_docs_en.pdf
https://shenyu.apache.org/pdf/apache_shenyu_docs_zh.pdf

@skyleaworlder The old pdf links are written dead. You may need to use https://shenyu.apache.org/pdf/apache_shenyu_docs_en.pdf https://shenyu.apache.org/pdf/apache_shenyu_docs_zh.pdf

Thanks. And I commit this in #620.