Validate user defined names in Generic Object Definition.

Validate property attribute / association / method names of GenericObjectDefinition.
An error message is thrown out when the validation fails.
Prefixed GenericObject private methods with "_" to avoid name conflict.
Links
https://www.pivotaltracker.com/story/show/128430239
cc @bzwei @gmcculloug

@lfu your PR title may be too broad. Should it just be validate user defined names?

👍

@gmcculloug euwe/yes or euwe/no please

@miq-bot add_label euwe/yes

Euwe Backport details:
$ git log -1
commit 451cd4475230abe23118bcfeecb9c54b0aa1d918
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Tue Nov 1 11:39:07 2016 -0400

    Merge pull request #12132 from lfu/go_validate_names

    Validate user defined names in Generic Object Definition.
    (cherry picked from commit 892abf2e011533a64c7b2e8f1945b4f82f5a3730)


mkcloud: use mkcloud_lib_dir variable for script path

:+1:

:+1: if tested

:+1: successfully tested with initial version of mkcloud self-gating (currently manually)


Connecting after a reboot fails consistently

$ xfreerdp \
        /cert-ignore \
        /v:localhost:33890 \
        /size:2560x1650 \
        /u:USERNAME \
        /p:PASSWORD \
        /scale-device:140 \
        /scale-desktop:140 \
        +fonts \
        +compression \
        +toggle-fullscreen \
        -wallpaper

[19:03:02:028] [25056:25057] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_CONNECT_TRANSPORT_FAILED [0x2000D]
[19:03:02:028] [25056:25057] [ERROR][com.freerdp.client.x11] - Authentication only, exit status 1

If I login to the machine and then try to connect, it simply works, after closing the FreeRDP window, the complete output is:
[19:04:18:662] [25130:25131] [INFO][com.freerdp.client.x11] - Closed from X11

I don't know how to get more debugging info or more verbose output, but am happy to do so if it's possible...

@colemickens You can set the environment variable WLOG_DEBUG=trace (or  WLOG_DEBUG=debug for a bit less) debug output.

Hm, that didn't get me any additional output in my scenario.

@colemickens So, what OS is the remote machine running?

It's Windows 10, and I'm trying to RDP into an account from the domain the machine is joined to.

Ah, sorry just now realized my typo, should be WLOG_LEVEL and not WLOG_DEBUG, should not write before first coffee ;)

So, I'm getting more output with that. With a custom built version, I see the actual NTLMSSP tokens printed out. With xfreerdp from Arch repos, I get less output, but it stills fails. On my custom build, the plaintext readable portions of the NTLMSSP tokens seem to be the same between a bad login and a good one.
Also, rdesktop is able to connect, but it doesn't count as a "first login". I still have to physically login to the machine before xfreerdp will connect.

Interesting!
I've noticed that if I log in from another machine that is in the domain... after a reboot, it forces me to manually enter my password instead of using the stored one... and then subsequent logins use the stored password.
Still can't figure out why rdesktop will work but freerdp doesn't, but my workaround is working well enough of logging in with rdesktop, killing it after 10 seconds and then reconnecting with freerdp.

This now affects every single one of my Windows 10 machines. FreeRDP continues to not connnect unless I:

Manually login to the device, then xfreerdp works.

Login via rdesktop, then reconnect with xfreerdp.

I had a similar issue (could not connect to / login on Windows 10 machine). Adding -sec-nla did the trick for me: now instead of supplying the password on the command line, I enter it within the RDP session and connect successfully.

so closing as fixed?
reopen/create a new one if still not solved.


Adds and sets up dotenv

I also added some extra steps and indicators, based on subvisual/theshelf's setup script.

:+1:


Fixing resolution of deep module references without a file extension

Addresses issue #69.  Original code had a bug in it where it'd append a second .js extension if the path already had an extension, rather than appending the extension if the path didn't already have an extension.
I also went ahead and added handling for .json as well, since require.resolve() does the same.

@src-code does the nodejs require function fallback to trying json files?

referring to this line: https://github.com/defunctzombie/node-browser-resolve/pull/73/files#diff-168726dbe96b3ce427e7fedce31bb0bcR192

@defunctzombie Yeah, I believe so, based on this doc: https://nodejs.org/docs/latest-v0.12.x/api/modules.html#modules_all_together

great!

Thank you! :+1:


Test formatting in Travis CI job

I understand the reasoning. Way out would be something like requirements-devtools.txt
autopep8==1.5
flake8==3.7.9
flake8-blind-except
flake8-builtins
flake8-docstrings
flake8-import-order
flake8-rst-docstrings
pep8-naming
pre-commit==2.2.0
pylint==2.4.4
tox==3.14.6

so that tox.ini can contain
[testenv:pep8]
passenv = PYTHONPATH
deps =
    -rrequirements-devtools.txt
commands =
    flake8

and then requirements-dev.txt would look like
-r doc/requirements.txt
-r tests/requirements.txt
-r requirements-devtools.txt

but I'm not sure if that's the way to go ^^
Maybe it's better to think about this later on once tox gets a more thorough implementation (i.e. if we have proper unit tests https://github.com/ComPWA/tensorwaves/issues/19). For the moment, the tox.ini file is really more of a placeholder for the flake8 config (following convention) along with an elementary setup for tox.
_Originally posted by @redeboer in https://github.com/render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjU1Mzk3ODI0OnYy/pull_request_review_threads/more_comments

See also https://github.com/ComPWA/tensorwaves/pull/22 and https://github.com/ComPWA/tensorwaves/issues/19

@spflueger
I don't think it's a good idea to test the formatting in a travis job as this is already done through Codacy (codacy.com/ComPWA/tensorwaves). The formatting checks that are installed through requirements-dev.txt are for local use, particularly at the moment when you commit. This forces the developer to incrementally improve the code quality prior to a PR.

But we definitely need them in the CI. So our decision is between Codacy or Travis.
I guess for now we can stick with Codacy and we can always switch to something else later on.
For me the general way the requirements are currently setup is not ideal.
https://stackoverflow.com/questions/17803829/how-to-customize-a-requirements-txt-for-multiple-environments
I would follow this. So having requirements files for each environment

ci/test
prod
dev

and reuse common dependencies across them.

I will close this issue, feel free to reopen if you think it needs more discussions

Will be closed by https://github.com/ComPWA/tensorwaves/pull/26
Only thing I'm not sure about yet is whether Travis is that great for analysing formatting: it does not provide the nice graphical interface that something like Codacy provides and the only way to fix identified problems is through adding additional commits (no specific ignore buttons).


build: Deduplicate CREATE_DIRS variable

Otherwise build system will complain about generating two exactly the
same rules for the target.

Just learned that make's sort() removes duplicates, so this LGTM


Relative positions for text selections

THIS NEEDS TO BE DONE BEFORE A RELEASE GOES OUT!
Currently, text selections (in both text and .ipynb files) are absolute--that is, they have a static start and end position. This causes the selection to change if a change is made before or after the commented text.
yjs supports relative positions in documents, which would solve this issue. However, the relative positions need to be converted to absolute positions when saved to file and converted back when loaded from file.

Closed by PR #128


Turns unresponsive on deleting files through file explorer

Issue Type: Bug
Steps to reproduce

From the file explorer pane, delete any file.
Observe that clicking anywhere inside the vscode window no longer works, until I close/minimize the window and reopen.

VS Code version: Code - Insiders 1.47.0-insider (7923112cdd20575406ec547b55a99c289dd7d7e2, 2020-06-29T06:49:12.675Z)
OS version: Linux x64 5.7.6-arch1-1

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-3110M CPU @ 2.40GHz (4 x 1864)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: unavailable_offviz_display_compositor: enabled_onvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
5.71GB (1.41GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
/usr/share/xsessions/plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (3)

Extension
Author (truncated)
Version

go
gol
0.15.0

cpptools
ms-
0.28.3

material-icon-theme
PKi
4.2.0

(3 theme extensions excluded)

I can not reproduce.
Can you reproduce with todays vscode insiders (since we went back to elecontr 7)?
Can you reproduce if you disable all extensions?

Yes, I can still reproduce it, even with extensions disabled.
I've upgraded to todays insiders version through yay -S visual-studio-code-insiders

Did you see something like this @deepak1556 @bpasero
Let's leave it open and see if other users are hitting this.

This is https://github.com/electron/electron/issues/11555

Thanks Ben. Then closing as dup of https://github.com/microsoft/vscode/issues/85332


2.0.x

fixes #

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[ ] Run pytest and tox, no tests failed.

Just getting started...


t.skip() should allow for omitting a function

I'll often use test.skip to notify me and others that there are more tests we could write. I'd like to be able to do this without having to specify a function. Something like:
test.skip('adds two numbers together')
test.skip('throws an error when the first argument is a 🐮') // that's for you Sindre :-)

Thoughts? :thought_balloon:

:+1: Would you like trying to do a pull request?

Was going to, but @BarryThePenguin beat me to it :+1:

More bikeshedding took place in #565. We're going for t.todo("title") instead, where a function is not allowed. t.skip() will continue requiring a function. Stay tuned all :smile:


What exactly do you mean by moving the rules to json?

Do you mean move the text to json format or to actually code the rules?

My thought was to structure the text as a big json object, as a precursor to coding the rules in javascript. So yes to both.
Thanks for your interest!

I'm trying to play the game and I'll submit fixes for typos and other problems as I find them.
This game seems like it could be a lot of fun but I had a few false starts, not knowing what I was suppose to do first, before I realized R233 was the entry point to contacts and not R205.  I've tried to imagine what to do in order to make it more playable while coding, instead of doing a bunch of coding then playing.  I think the easiest thing would be to code the daily possible events first.  That is, I'd start scripting R203, then table R233, then R205.
I don't know if I'll actually code anything, but if I do, that's where I'll start.  If you've got a better idea let me know.  But again, my goal is to play it while coding, not wait until it's all done before I can play.  That way, no matter how much coding I do, I'll be able to use what I've done.
BTW, you have no idea how much help this markdown file has been.  Searching through the pages was getting so tedious I actually started converting them to markdown myself.  And then I found yours, which was already complete.  Thank you.

I'm glad one other human found this useful. I'm grateful for any fixes.


CameraAttributes exposure doesn't affect unshaded materials, but auto exposure does

Tested versions
Reproducible in: 4.2.1,stable.official, 4.3.dev4.official
System information
Godot v4.3.dev4 - Windows 10.0.22000 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics (Intel Corporation; <IP_ADDRESS>26) - Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz (8 Threads)
Issue description
Unshaded materials will correctly stay unshaded when manually adjusting a CameraAttributes' exposure, but enabling auto exposure will brighten/darken them. Additionally, the exposure shader parameter doesn't seem to be affected by auto exposure.
Happens in both Forward+ and Mobile renderers.
Steps to reproduce
Make a mesh with an unshaded material. Make a WorldEnvironment, give it camera attributes, enable Auto Exposure. Put them in the same scene and watch the magic happen.
Minimal reproduction project (MRP)
Auto Exposure MRP.zip

I can confirm that exposure does not adjust the unshaded materials correctly and  they will stay unchanged. Tonemap exposure and auto exposure works correctly.

I believe the exposure effect is post processing, not related to any individual mesh, unsure if this is a limitation or a bug, the auto exposure part I think is however material specific in the renderer

Agree. Unshaded is meant to not be affected by light, but exposure is not related with the geometry or the light itself but with the light values of the final render of "Photo" in camera terms. This is being done correctly in all other places where there is an exposure setting.
In unreal this will happen too, and you need an special setup to take exposure into account. I believe a proposal to make this an option for unshaded models may be good for artistic purposes, but even if  you have an unshaded model, most of the time you want to adjust your final image, exposure included.


TensorFlow Lite Build and Linker issues in 2.4 -> 2.8 versions

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): macOS Big Sur
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: 2.4 -> 2.8
Python version: 3.x
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: N/A
GPU model and memory: AMD Radeon series

I pulled a number of versions starting with 2.4 to 2.8 or so and couldn't seem to get the tflite minimal example to build on my own.  I am linking to the libtensorflow-lite.a fine but it is producing strange linker errors with ruy library, even though I am explicitly building it with -DTFLITE_ENABLE_RUY=Off.  I cleaned a million times and it just includes ruy references without being compiled for it.
cmake ../tensorflow/lite -DTFLITE_ENABLE_RUY=OFF -DTFLITE_ENABLE_NNAPI=OFF -DTFLITE_ENABLE_GPU=OFF -DTFLITE_ENABLE_XNNPACK=OFF -DTFLITE_ENABLE_MMAP=OFF
make
It seems to build ruy right away here:
$ make
[  0%] Building CXX object _deps/ruy-build/CMakeFiles/ruy.dir///ruy/ruy/allocator.cc.o
[  0%] Building CXX object _deps/ruy-build/CMakeFiles/ruy.dir///ruy/ruy/apply_multiplier.cc.o
[  0%] Building CXX object _deps/ruy-build/CMakeFiles/ruy.dir///ruy/ruy/block_map.cc.o
[  0%] Building CXX object _deps/ruy-build/CMakeFiles/ruy.dir///ruy/ruy/blocking_counter.cc.o
[  0%] Building CXX object _deps/ruy-build/CMakeFiles/ruy.dir///ruy/ruy/cont
...
And when I link against the libtensorflow-lite.a library I get these:
Undefined symbol: ruy::ThreadPool::ExecuteImpl(int, int, ruy::Task*)
Undefined symbol: ruy::Kernel8bitAvx(ruy::KernelParams8bit<8, 8> const&)
Undefined symbol: ruy::Kernel8bitAvx2(ruy::KernelParams8bit<8, 8> const&)
Undefined symbol: ruy::KernelFloatAvx(ruy::KernelParamsFloat<8, 8> const&)
Undefined symbol: ruy::KernelFloatAvx2(ruy::KernelParamsFloat<8, 8> const&)
Undefined symbol: ruy::Kernel8bitAvx512(ruy::KernelParams8bit<16, 16> const&)
...

Hi @krworks! Could you please look at these threads ? Link1,Link2,Link3


Flow Token Contract Deployment error

Describe the bug
While deploying the Flow Token contract from https://github.com/onflow/flow-core-contracts/blob/master/contracts/FlowToken.cdc
To Reproduce
Steps to reproduce the behavior:

Open play.flow.com
Create a file FlowToken.cdc
Paste the code from https://github.com/onflow/flow-core-contracts/blob/master/contracts/FlowToken.cdc
Deploy from any signer
Proper error message doesn't get logged. But contract doesn't get deployed

Expected behavior
Contract should get deployed to signer.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version: 113.0.5672.93

@jaydeepdey03  was the FungibleToken contract deployed from 0x04 account?

@bthaile I have deployed fungibletoken contract in 0x04, and tried to deploy FlowToken Contract in 0x05.

Ok, thanks for the feedback. It appears there are a few issues going on. The frontend issue was fixed. We'll look at the backend issues.
@DylanTinianov
Seems that FungibleToken contract has been deployed on user 0x04
Then FlowToken fails to be exported on user 0x01.
https://play.flow.com/7a1c6c93-9f53-4132-b06a-ae5636cc48e6?type=contract&id=c465f6dc-ada4-4232-b435-3b252025aaa7
Here is a shared example project.

@jaydeepdey03 Looking at FlowToken.cdc it takes an AuthAccount in the init method the playground does not support passing in arguments. I you want to deploy a FlowToken contract remove the need for AuthAccount.
Closing ticket.

Could you provide an updated FlowToken.cdc contract. The existing one is old and buggy. I am new to Cadence and not sure how to proceed in it.
@bthaile


Updated packages

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.366%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
102

Relevant Lines:
102

💛  - Coveralls


App Registration "Microsoft CRM Portals"

The page mentions "The name of this application will be Microsoft CRM Portals", however with the new portals, the App registration name in Azure AD is  "Power Apps portals - ".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d4322e1-463a-ac81-32da-036adc71ef24
Version Independent ID: d05a3e14-1868-2d19-ba02-77e1493af7a4
Content: Power Apps portals connectivity to a Microsoft Dataverse environment - Power Apps
Content Source: powerapps-docs/maker/portals/admin/connectivity.md
Service: powerapps
Sub-service: portals
GitHub Login: @neerajnandwana-msft
Microsoft Alias: nenandw

Thank you for your feedback! The documentation is currently being updated to reflect this change as well as some upcoming updates.


Synchronized evaluateJavaScript improvement

It works on main thread!
It handles timeout (3 seconds).
Added an out parameter for error.
Moved to WKWebView extension.
Rename evaluateScript to evaluateExpression because it doesn't support
statements.

@jondong , PTAL if you have time.


Stop using _app_ctx_stack in favor of flask.g

We currently have the following deprecation warning:
/home/lukas/.virtualenvs/sipa/lib/python3.10/site-packages/flask_sqlalchemy/init.py:14: DeprecationWarning: '_app_ctx_stack' is deprecated and will be removed in Flask 2.3.
Note the following section in the 2.2 flask docs

An older technique for storing context data was to store it on _app_ctx_stack.top or _request_ctx_stack.top. However, this just moves the same namespace collision problem elsewhere (although less likely) and modifies objects that are very internal to Flask’s operations. Prefer storing data under a unique name in g.

In this case however, the culprit is just the (now unused) flask_sqlalchemy package.


Add kinematic trajectory optimization

This implements basic kinematic trajectory optimization using Drake's MathematicalProgram formulation.
Specifically, this is a direct collocation method on cubic splines in position, with lots of options for bounds on the position/velocity/acceleration/jerk by sampling over the trajectory.
I played with collision avoidance using finite differencing in Drake, but that was prohibitively slow. So I'm going to push that off to a future task of providing analytical gradients.

aw yea


fix: negotiate Docker API version

When a Docker daemon doesn't support an API version that's used by the Go client, it will reject communication as in the issue we've faced in KIC. This change is to avoid such errors by making sure that the client downgrades the API automatically in case the daemon doesn't support the newest one.
Should unblock https://github.com/Kong/kubernetes-testing-framework/pull/931.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (42eebf1) 60.18% compared to head (6f7e244) 60.49%.
Report is 12 commits behind head on main.

Files
Patch %
Lines

pkg/utils/docker/client.go
57.14%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   60.18%   60.49%   +0.30%
==========================================
  Files          49       50       +1
  Lines        4024     4032       +8
==========================================
+ Hits         2422     2439      +17
+ Misses       1298     1290       -8
+ Partials      304      303       -1

Flag
Coverage Δ

integration-test
60.49% <76.92%> (+0.30%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Just a typo fix

Hi everyone,
Nothing special, just a typo/grammar fix.
Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

cool. signed.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thanks for the fix-up!

np! thanks!


[proposal] add ColorCell, EditStepper etc to vanilla

RoboFont includes several custom UI items which could be useful in other apps.
can we move them to vanilla?

UI item
example

ColorCell

EditStepper

EditIntStepper

SliderEditStepper

SliderEditIntStepper

thanks!

see also #68

Most of these have been added to ezui. I'll look into the ComboListCell for List2 on issue #68.


Adds version header to rest client

@brendankowitz,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Does markdown-it have not support parsing md tags with spaces using method parseInline?

Does markdown-it have not support parsing md tags with spaces using method parseInline?
like:  **THISISASTRONGTAG  **
This STRONG label can not be recognized because there is a space after it.

I guess no. Markdown-it works according to CommonMark spec. Please read it and try  commonmark forum for any questions about formatting.


SBT linking error when depending on local project

In an build.sbt file:
val that = RootProject(file("../that"))
val project =
  Project("this", file("."))
    .enablePlugins(ScalaJSPlugin)
    .dependsOn(that)

I'm experiencing linking errors when refering to code from the that dependency. If I symlink the files in the src directory it compiles without any complaints. Is this a know issue?

Is that a Scala.js project, i.e., with .enablePlugins(ScalaJSPlugin)?
Linking errors would indicate that it cannot find the .sjsir files coming from that, which would definitely happen if that is in fact not a Scala.js project.
Other question, what does show this/compile:fullClasspath? Does it include the classes directory of that? Does this directory contain .sjsir files?

Thanks for the quick reply!
And nope, it's not a scala-js project :-) Honestly I assumed it was an inherent mechanism of scala-js to compile and link external source code as well. Is that not how it's normally done with dependencies?

No, dependencies are compiled separately, although they are all linked together. This is like Maven dependencies (because they are Maven dependencies). That means you can only depend on external projects targeting the same platform, i.e., Scala.js-enabled projects.


[TASK] Small readme updates

Added links to a couple of helpful resources regarding email client support for CSS
Added instructions for installing PHPUnit and running tests

I've fixed the PHP_CodeSniffer warnings on Travis. Could you please rebase and re-push? Thanks!

@oliverklee - I've rebased the commit and updated the document to cover the proper method of installing phpunit. Thanks for informing me of that. I guess this experience demonstrates the value of having such instructions in the readme.

For the commit message:

Could you please wrap the lines in the description at 72 characters?
Could you please a bullet lists (using asterisks) for the lines in the description that are no paragraphs?

For more information on good commit messages, please see http://chris.beams.io/posts/git-commit/ .

@oliverklee I've made the requested changes and pushed the rebased commit.

Thanks!


Download files

Looks like the download function crashed :

when clicking on the download button.

Ok so this is due to the fact the we are parsing filenames like this "_".join(filename.split(".")) which is changing the last one as well eg. the .nc


Beginner Challenges

01
name: Apoorva Hegde
github_user_name: ApoorvaHegde21

02
URL of the forked repository : https://github.com/ApoorvaHegde21/oss101.git
Screenshot of the cloned project in a local system :


Nextflow DAG display and tool tab display

Feature Request
Desired behaviour
This one may be tricky to do without language bindings, but its worth a try to see if we can do something basic for now.  Follows #1041

I'm at the point where I have the code properly connecting processes, but ONLY if no operations on the channels have been made.
Nextflow is not like other languages, you can do some extra stuff between tools within a workflow using operations on channels. This is awesome from a user perspective, but parsing this can be a pain. Not only are there like 40 operations, but also you can chain them together.
Nextflow has a collection of high quality workflows found at http://nf-co.re/. Denis suggested that we implement operators that exist in these, so that we can show off what the DAG could be capable of.

There seems to be a related issue of nextflow files not properly being added, will investigate.

Probably not the right place for this, but we need to disable the "Add Checker Workflow" button for Nextflow until we have an idea for how it will work

Closing this as it is sort of a duplicate of https://github.com/ga4gh/dockstore/issues/1041


Enable Vulkan in our Android Release package.

This makes release builds consistent with continuous builds and default
local builds. It also makes it easier to test the Vulkan backend.
Clients who need a smaller APK size can always make their own build.
This also makes filament-android-release.aar go from 1.8M to 2.3M.
Note that we are now including bluevk, vkshaders (for the blit shader),
smol-v (for SPIRV decompression) and vk_mem_alloc (for mem allocation).

We want this for Maven artifacts too, yes? Starting with v1.9.23, I'll exclude the -v flag when building.

That's correct yes.


[PUI] Enable 2FA for new interface

Need to enable 2FA functionality via the API, and implement for:

React interface
Mobile app
etc

In addition to implementing 2FA support via API endpoints, need to setup the user interface elements for the new platform UI

@SchrodingersGat I think 2FA is probably the easiest to do just in the web UI and then used via webviews in the app. Thah way OIDC would also be easy.

Fixed in #6368

@SchrodingersGat are you sure this was fixed?

@matmair you're right, I was thinking SSO.. Too much going on.

@SchrodingersGat are you on board to split this into 2 issues:

(this) Add 2fa to PUI
Add 2fa APIs ( I would wait for the REST release of django-allauth for that)

Yep, on board


Error "Cannot decode JSON from PhantomJS runner" for phantomjs v1.9.8 (2)

Hello, I get this message and the reason is that phantomj returns multi-line result like this
$ ~/.phantomjs/1.9.8/x86_64-linux/bin/phantomjs<EMAIL_ADDRESS>"http://localhost:8888/?spec=Vox" 60000
{"error":"Javascript error encountered on Jasmine test page: ReferenceError: Can't find variable: module","trace":[{"file":"http://localhost:8888/__spec__/helpers/vox_mock.js","line":14,"function":""}]}
{"error":"Javascript error encountered on Jasmine test page: ReferenceError: Can't find variable: require","trace":[{"file":"http://localhost:8888/__spec__/session_spec.js","line":10,"function":""}]}
{"error":"Javascript error encountered on Jasmine test page: ReferenceError: Can't find variable: require","trace":[{"file":"http://localhost:8888/__spec__/vox_spec.js","line":7,"function":""}]}

So, when JSON parser meets the second line in :evaluate_response method it raises an error.
I'm not sure if it is possible to break the string json into several lines and process them one by one.

Thanks for reporting the issue @dima4p.    I've changed how they're reported so it will only log them one at a time.
I just released version 2.0.6 with the changes, please give it a spin and see if it works for you.

I'm pruning old issues and hope the new version worked for you, please open a new issue if you're still having problems


Update net20-pluggable-agent to work with latest 2.0.0 engine package

Update to work with testcentric.engine.core-2.0.0-dev00522

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

GitHub Release
NuGet Package
Chocolatey Package


15.3 preview 3: Solution Explorer does not show SDK nodes for .NET Core 2.0 preview 2 projects

Please reopen in https://github.com/dotnet/project-system/

can repro. using <Project Sdk="Microsoft.NET.Sdk"> projects.
And no Dependencies node either.
using <Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk"> projects:

fix in https://github.com/Microsoft/visualfsharp/issues/3266 /cc @brettfo @KevinRansom @cartermp @Pilchie
locally change C:\Program Files\dotnet\sdk\2.0.0-preview2-006502\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.FSharp.targets to apply the PR changes

@enricosada
So ... the fix for this is in, however, it is not yet in master, nor is it in the preview 2.0 branch, it is in the release 2.0.0 branch.
https://github.com/dotnet/sdk/blob/release/2.0.0/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.FSharp.targets#L51
@cartermp will be working on updated instructions.

Yes, this is now fixed.  You can get things to show up with this CLI/SDK install combo: https://github.com/dotnet/cli/tree/release/2.0.0
That is, the following should work if you install:

15.3 Preview 3
The above linked CLI


Improve nino validation

What
Improve national insurance number (nino) validation
See Crime Apply's PR
Based on NINO allocation rules as per https://www.gov.uk/hmrc-internal-manuals/national-insurance-manual/nim39110 - improved validation to include raising validation errors for specific unused prefixes
Also strips spaces and upcases input prior to validation to allow for input variation (particularly for spaces which are shown as part of the hint text NINO example)
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

closing until there is time to work on it


(OSATE2:23122): Gdk-CRITICAL **: 09:23:55.357: gdk_x11_display_set_window_scale: assertion 'GDK_IS_X11_DISPLAY (display)' failed

Please provide a brief summary of the bug
I am running OSATE2 on linux.
After a recent update it crashes and asks me to report here:
(OSATE2:23122): Gdk-CRITICAL **: 09:23:55.357: gdk_x11_display_set_window_scale: assertion 'GDK_IS_X11_DISPLAY (display)' failed
A fatal error has been detected by the Java Runtime Environment:
SIGSEGV (0xb) at pc=0x00007fe0ce6c732f, pid=23122, tid=23123
JRE version: OpenJDK Runtime Environment Temurin-11.0.13+8 (11.0.13+8) (build 11.0.13+8)
Java VM: OpenJDK 64-Bit Server VM Temurin-11.0.13+8 (11.0.13+8, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)
Problematic frame:
C  [libX11.so.6+0x2d32f]  XInternAtom+0x3f
Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/herbert/nodeflow/osate_dir/core.23122)
An error report file with more information is saved as:
/home/herbert/nodeflow/osate_dir/hs_err_pid23122.log
If you would like to submit a bug report, please visit:
https://github.com/adoptium/adoptium-support/issues
The crash happened outside the Java Virtual Machine in native code.
See problematic frame for where to report the bug.
./osate  113,75s user 3,94s system 99% cpu 1:58,58 total
Please provide steps to reproduce where possible

Open osate2
switch to diagram view

Expected Results
show the diagram
Actual Results
crash and reports with error below
What Java Version are you using?
Unrecognized option: --version
What is your operating system and platform?
Linux, 5.19.1-arch2-1
How did you install Java?
pacman
Did it work before?
yes, all worked well

Did you test with other Java versions?
no

Relevant log output
Github complains:  There was an error creating your issue: body is too long (maximum is 65536 characters).
there are 2000 lines of log file, I have copied it here: https://www.pastiebin.com/62fc9b98d8fa1

@noahsmindfuck Can you try with the latest 11.0.16 and let us know if its still an issue.

Hi @karianna
Thank you for your reply.
I think the JRE is shipped inside the OSATE2 installation bc on my system I have only this installed:
extra/jre8-openjdk-headless 8.345.u01-1 [installed]
I now installed the 11.0.6 version (jre11-openjdk-headless-<IP_ADDRESS>.u1-2) and still receive the same error, although now it references to a version 17
(OSATE2:17504): Gdk-CRITICAL **: 22:30:22.977: gdk_x11_display_set_window_scale: assertion 'GDK_IS_X11_DISPLAY (display)' failed
A fatal error has been detected by the Java Runtime Environment:
SIGSEGV (0xb) at pc=0x00007f6397d1ef0d, pid=17504, tid=17505
JRE version: OpenJDK Runtime Environment Temurin-17.0.3+7 (17.0.3+7) (build 17.0.3+7)
Java VM: OpenJDK 64-Bit Server VM Temurin-17.0.3+7 (17.0.3+7, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
Problematic frame:
C  [libX11.so.6+0x2cf0d]
Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/herbert/nodeflow/osate2-2.11.0-vfinal-linux.gtk.x86_64/core.17504)
An error report file with more information is saved as:
/home/herbert/nodeflow/osate2-2.11.0-vfinal-linux.gtk.x86_64/hs_err_pid17504.log
If you would like to submit a bug report, please visit:
https://github.com/adoptium/adoptium-support/issues
The crash happened outside the Java Virtual Machine in native code.
See problematic frame for where to report the bug.

according to this one it could be a wayland/jre problem
a proposed fix is to run it with "-Djdk.gtk.version=2" to force gtk2

Workaround for me now is to use a desktop environment based on Xorg (not a solution, a very dirty workaround)
Hope that everyone finds the time to migrate away from old monsters,
until then


Dynamic default value for input type text

As per #265, I know use props.dispatch(actions.change("model",value)) to set an initial form state dynamically.
However, this doesn't seem to work on input type text: http://esnextb.in/?gist=68458c20fce449d3657970658e922a32

It seems to be because of the updateOn="blur". How can I bypass this for the initialization of the default state?

If an input has updateOn="blur", then it is an uncontrolled component by necessity right now (because a connected input represents the state, and if you are still focused in the input and type a value, the input's value is not the same as the input's state until you blur).
This will be solved in v1.0. For now, you might need to remove updateOn="blur" if you want it to update, or have the component be controlled yourself.
You also don't have to use <Field>. You can always dispatch the actions directly from your component, such as:
<input value={this.state.foo}
  onBlur={(e) => dispatch(actions.change('user.foo', e))}
/>

There is some incoherence here... updateOn="Blur" should make the component "half controlled", not uncontrolled at all... I don't see what is the use on this updateOn prop on Field if it make the Field component itself useless...
If it were half controlled (synchronizing with the form model/state only at initialization and on blur), then I could have workaround my issue simply by rendering the form after setting the form initial state...

There is no such thing as a "half controlled" component. It is either fully controlled or fully uncontrolled; React will throw a warning if you go from making a component uncontrolled to controlled (and vice versa).
This will be fixed in V1 by making the component fully controlled with regard to its viewValue, which may differ from the modelValue in that it is always in sync with the modelValue but not the other way around.
If you are not loading data in asynchronously and using the input as a normal text field where values always come from the user, updateOn="blur" does not make the component "useless" because it will work as expected.

This is fixed in the latest @beta, now that the component is fully controlled regardless of blur/change.

I have spent the entire day looking for a proper example of ' dynamically updating the initial values' it would be worth adding this in examples. @davidkpiano


Add comments to YourContract.sol

Hey!
We were discussing with Carlos to add the comments in the code for the best developer experience as mentioned in issue https://github.com/scaffold-eth/se-2/issues/91. You can see my comments for the smart contract.
Please lmk what you think. Happy to make the necessary changes if its over or under commented.

hey @carletex! Made the changes as we discussed. Please lmk what you think! Thank you!


How to achieve withoutGlobalScopes() behaviour

For some of our models we employ global scopes through the models boot() method. It is convenient, because those constrains do not need to repeated all over the application. Many relationship definitions etc.
e.g.
  protected static function boot(): void
    {
        parent::boot();
self::addGlobalScope('published', static function (Builder $query): void {
            $query->whereDate('from_date', '<=', Carbon::now())
                ->whereDate('to_date', '>=', Carbon::now());
        });
self::addGlobalScope('active', static function (Builder $query): void {
            $query->where('status', '=', 1);
        });
}

However JSON API faces a problem, "inactive" or "unpublished" records are not found - 404.
I do not see a way to pass withoutGlobalScopes() via schema.
What would be the suggested approach?
create a separate model without scopes for JSON API?

Hi! This is something I could add suppor for. In the meantime, you can implement this yourself via the Driver class. This isn't documented, but basically the query builder instances are created by a driver that the schema returns. This is how I override the default implementation to add support for soft deletes - I change the driver.
For example, the basic driver looks like this:
https://github.com/laravel-json-api/eloquent/blob/develop/src/Drivers/StandardDriver.php
You could write your own (it just needs to implement the interface), then overload the driver() method on the Eloquent schema returning your own driver:
https://github.com/laravel-json-api/eloquent/blob/52667226d6bb3b4df1390b5958cf0b86cf07a809/src/Schema.php#L359-L364

@lindyhopchris
I have simillar question, it is possible to modify query for some schema relationship (also for includes)? For example, i want to disable soft deletes but only for relationship in one schema (main resource should still have soft deletes enabled).

@bbprojectnet i might need to consider that for the future, but in the meantime an easy workaround is to add a specific relationship to the model that disables soft deletes, and then use that relationship in the JSON:API schema.


TypeError: Cannot destructure property 'key' of 'object null' as it is null.

Hi, Thanks for your pay attention
p2o -v
2.7.0

node -v
v16.14.0

p2o postman_collection.json -f open-api.json
TypeError: Cannot destructure property 'key' of 'object null' as it is null

my postman collection is (only rename ext to txt to attach it here):
postman_collection.txt

Hi @Mehrdad-Dadkhah,
Your collection is not correct when i try to import in postman i get that error: "Error while importing Postman Collection v2.1: Cannot read properties of null (reading 'key')"

Best regards.


Add support for theme-specific API request/response examples in Logical Theme System

Describe the feature you'd like
Implement a mechanism for BookStack to recognize and utilize API request/response examples stored within custom themes using the Logical Theme System. Currently, these examples must be manually linked to the /dev/api/requests and /dev/api/responses folders. We propose two possible solutions:

Automatically search for examples within the theme's directory structure, specifically in subfolders like /dev/api/requests and /dev/api/responses.
Allow themes to register their own examples through a defined API or configuration file.

Describe the benefits this would bring to existing BookStack users

Improved documentation: API examples would be more easily maintained and updated alongside the theme code, ensuring better synchronization between functionality and documentation.
Simplified theme management: Users would no longer need to manually create symlinks, reducing the potential for errors and streamlining the theme installation process.
Better organization: Keeping all theme-related content, including API examples, within the theme's directory structure improves code organization and makes it easier to distribute and version control themes as complete packages.
Enhanced developer experience: Theme developers would have a more intuitive and standardized way to include API examples, potentially encouraging more comprehensive documentation.
Easier theme sharing and installation: Themes could be shared as complete packages, including all necessary documentation and examples, making it simpler for users to install and use custom themes.

Can the goal of this request already be achieved via other means?
Yes, the goal can currently be achieved by manually creating symlinks from the theme's examples to the /dev/api/requests and /dev/api/responses folders.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
3 months to 1 year
Additional context
No response

We wrote a logical theme which (besides other customizations) extends the api to include endpoints for token management. We are working with multiple person on extending the Logical Theme, implementing an api client and integrating the functionality in our solution. When working in a team it's great to have the api documentation in a single place.
We are versioning our theme in git. We need to install our theme in multiple bookstack instances (dev, test, prod). Our current process is to create symlinks after cloning our repository:
ln -s ../../../themes/Our.Theme/dev/api/requests/tokens-create.json dev/api/requests/.
ln -s ../../../themes/Our.Theme/dev/api/requests/tokens-update.json dev/api/requests/.

ln -s ../../../themes/Our.Theme/dev/api/responses/tokens-create.json dev/api/responses/.
ln -s ../../../themes/Our.Theme/dev/api/responses/tokens-list.json dev/api/responses/.
ln -s ../../../themes/Our.Theme/dev/api/responses/tokens-read.json dev/api/responses/.
ln -s ../../../themes/Our.Theme/dev/api/responses/tokens-update.json dev/api/responses/.

Another scenario is publishing an api extension to the BookStack Hacks Directory - it would be great if the hack also contains the documentation and examples for new API endpoints.


Function/Variable selector gets expanded and can't be shortened back down

Hi guys
After many many years (since probably 1.0) I've noticed this bug and hoped that it will get fixed in time, but unfortunately it's still here.
Anyway if you watch the video
https://1drv.ms/v/s!AulAg7BeKIMXgqNP_uScCUZliHBF4Q?e=dnsIMO
you will see that as soon as I edit the string the function/variable/... selector gets expanded (I assume to account for some html code or something???), but even if you select something else the window doesn't shrink back down. So the only way to shrink is to close and reopen the file again.
Expected behavior:
That the window doesn't get expanded in the first place. With all the languages I write in VS TypeScript is the only one that is causing this issue.
Actual behavior:
Selector window gets invalid height.
BrW

Looks very annoying, but I can't tell from the video what the code is, so can't figure out how to reproduce it locally. Can you post some code as text, or at least as a screenshot, that we could use as a basis for testing out a potential fix?
Thanks!

Hi Ryan
Try to download the video it should be in full hd (online version is sometimes displayed in lower resolution)... if it's still not visible, we can talk locally and I can show you live (skype, teamviewer,...).
BrW

We can't spend all day transcribing code snippets from video freezeframes. If you're unable to provide a text-based example, then this report isn't something that can be taken as actionable.

Hi Ryan
You don't have to be angry or anything as same as you I'm a programmer. And the first thing is that we are in service for other people.. that is what we do and that is how we earn our living.
And just for a side note I'm a programmer for 30+ years and one thing I know is that we have to have patience.
Now I've seen a lot of bad bug reports in my life to the extend that all I've got is "GUI doesn't work" where just the GUI alone had a million of lines.
Also from my experience seeing a video is 100 times better then seeing an image.
And as the issue is triggered in every class, just constructing a simple string in a similar form as on the video would trigger the bug.
Now to make your life easier here is a simple ts file that triggers the issue (at least on my VS2017.. it did on all the previous versions too and I assume it will in VS2019 too as it's a TS bug).
https://1drv.ms/u/s!AulAg7BeKIMXgqQ5z1b_kHAV9NEgfg?e=g8qP2L
The bug is as simple as opening the ts file and clicking on the right spot (described inside the ts file).
Now for a side note on how to get better, specially as you want to be a lead, is to read a small book named "How to win friends and influence people.". I've seen many arrogant leads that didn't come anywhere in life and have seen many normal programmers that became very successful professionals or managers... maybe on your side the perfect example would be Satya. And I can say 100% that he didn't come to the CEO position being arrogant and inpatient.
So peace and love as we are all trying to help other people and this is where the good feelings in life come from.
Best regards
Waldemar

namespace Privendo.Menu
{
//Enums
	namespace Enum_Filter_Command
	{
		export const enum Value
		{
			Cameras,
			Company,
			Connects,

			PinUnpin
		}
	}

	export class Test
	{
	//To trigger the bug: click with mouse on the right ' of the lower right + '" >''\ section
	//                                                                              ▲
	//                                                                              click here on the lower right text

		private static		m_Page_Element_html =
			'
\

\

\
						{51460} Companies<input type="checkbox" name="companies" >|\
						{51461} Connects<input type="checkbox" name="connects" >|\
						{51462} Cameras<input type="checkbox" name="cameras" >\

\

\
						''\

\

\

\

\

\

\

';
	}
}

Thanks Ryan for reopening the ticket.
Best regards
Waldemar


fix for dp_id not a str; closes #436

Codecov Report

Merging #439 into master will decrease coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   96.73%   96.68%   -0.05%
==========================================
  Files          33       33
  Lines        2049     2050       +1
  Branches      150      151       +1
==========================================
  Hits         1982     1982
  Misses         46       46
- Partials       21       22       +1

Impacted Files
Coverage Δ

...hBoundControllerAbstraction/proxy/faucet/parser.py
72.97% <100%> (ø)
:arrow_up:

...hBoundControllerAbstraction/proxy/faucet/faucet.py
90.69% <66.66%> (-1.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf98b9...f074a93. Read the comment docs.


Update sidenav menu bar to a better UX desing

Will be fixed on v1.2.5

Implemented after change the framework.


Unable to connect to redshift using postgres driver

Postgres driver is a standard way of connecting to AWS redshift database.
Connection fails with error:
PgDatabaseError { severity: Fatal, code: "22023", message: "3 is outside the valid range for parameter \"extra_float_digits\" (-15 .. 2)", detail: None, hint: None, position: None, where: None, schema: None, table: None, column: None, data_type: None, constraint: None, file: Some("/home/ec2-user/padb/src/pg/src/backend/utils/misc/guc.c"), line: Some(26684), routine: Some("set_config_option") }
I see setting extra_float_digits is hardcoded in here:
https://github.com/launchbadge/sqlx/blob/9d71a7f3725041e8822506b76ea3dd6795af93a6/sqlx-core/src/postgres/connection/establish.rs#L36
It would be good to have any options for overriding it for redshift or may be there is a way?

Duplicate of #801

Duplicate of #801


Implement '101 Switching Protocols'  ?

Hi your lib looks amazing ! Do you plan to implement '101 Switching Protocols' ?

I'm sorry I cannot understand your question. What do you mean by "implement '101 Switching Protocols'" ?

Hi sorry my question was not clear.
when trying to connect to my server I have this error "The status code of the opening handshake response is not '101 Switching Protocols".
On your home page it is said : "HTTP response codes other than "101 Switching Protocols" from a WebSocket endpoint are not supported",
will you support other response code in the future ? My previous library could connect properly  so I guess that this 'error' depends on the way you handle connection.

RFC 6455 says "Any status code other than 101 indicates that the WebSocket handshake has not completed". In other words, other HTTP status codes than 101 indicate that the server rejected to talk WebSocket protocol.
Supporting other HTTP status codes than 101 is not a task for a WebSocket client library but a task for a generic HTTP client library. nv-websocket-client is not aiming at becoming a generic HTTP client library.
What behaviors do you expect when an HTTP status code other than 101 is returned from a WebSocket server?

though curently I have just tried my app thats using the library and its not connecting to my webserver "The status code of the opening handshake response is not '101 Switching Protocols'"  I dont know if the issue is  from client or server

In most cases, a client application is to blame for other HTTP status codes than 101. For example, 404 (Not Found) is returned when a client application specified a wrong URL. A server is to blame only when a 5xx status code is returned.
For other status codes than 101, "the semantics of HTTP still apply" (RFC 6455, 1.3. Opening Handshake). If you receive a status code other than 101, it's not a WebSocket problem but a normal HTTP problem.

Thanks for your reply !
Problem is  : my previou socket library connects successfully to my SSL websocket server but yours can't connect to the server, am I missing something ?
Here is my code :
String host = "wss://myserver.com";
mWebSocketFactory = new WebSocketFactory();
websocket = mWebSocketFactory.createSocket(host, 5000);
websocket.setPingInterval(30 * 1000);
websocket.setAutoFlush(true);
websocket.addListener(...);
websocket.connectAsynchronously();

I found my error !
I missed the url port now it works. Strange because there were no need my with previous library, sounds like a redirection problem.
Thanks for your time ! I will test your library now !

Sorry, redirection (3xx) is not supported although I think it would be better to support it.

Released a new version, 1.19.
Since the new version, connect() method throws OpeningHandshakeException (a subclass of WebSocketException) when a violation against the WebSocket protocol is detected during an opening handshake. For example, when a status code other than 101 is returned from a server.
OpeningHandshakeException provides additional methods such as getStatusLine(), getHeaders() and getBody() to access the response from a server.
You can retrieve the redirection URL like the following.
try
{
    // Perform the WebSocket opening handshake.
    ws.connect();
}
catch (OpeningHandshakeException e)
{
    // Get the status code.
    int statusCode = e.getStatusLine().getStatusCode();

    // If the status code is in the range of 300 to 399.
    if (300 <= statusCode && statusCode <= 399)
    {
        // Location header should hold the redirection URL.
        String location = e.getHeaders().get("Location").get(0);
    }
}
catch (WebSocketException e)
{
}

What of the 200 OK code how does one fix that, cos my URL is correct and the server person is saying they implemented a websocket, what can I do?!?

hello, I'm really stuck. I have a strange problem. I get a (not 101) moved permanently 301 error when not using my VPN - but using the VPN I don't have these problems. I use OkHTTP but the only discussions related to this error I could find was the neovisionaries github site.
Could anyone tell me what might be going on? What I should google? would using an actual IP addresses instead of text url help?


Small Edits

Still have some problems locally with pyln.testing wanting python-bitcoinlib of version 0.10.2. We should have a new pypi update of pyln-testing after the release though, which should allow us to peg the requirement to pyln-testing==0.10.0 and hopefully fix this once and for all.

ack https://github.com/rustyrussell/lnprototest/pull/5/commits/14e4e1e058999988159373458589c5ecd647fdd2
I have only one comment on this PR, to work around to the error of the python-bitcoinlib version I ran the command python3 setup.py develop inside the directory lightning/contrib/pyln-testing and at the end of the procedure I noted that another dependence is needed that is pyln.client. With a small jump inside the requirements.txt of pyln-testing, I noted that there isn't this dependence.
Do you think that is good to have it inside the requirements.txt of lnprototest? It would be helpful if the end-user uses a virtual envoirment to run python projects.


Declarative json call to svg files are supported?

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
Declarative list formatting
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[X] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Issue description
This is a direct question to @shagra-ms,
There was situation that a provide elmType was not used as expected  and was blocked by MSFT because of security risk what is understandable.
#8004
I would like to validate with your team action using  "elmType" > "img"  that call "svg" files are valid from MSFT side.
Architecture process:

SharePoint Library where the svg is stored.
Create declarative json that call with following sample:

 {
        "elmType": "img",
        "style": {

        },
        "attributes": {
          "src": "[SharePoint Online url]/Folder/sample.svg"
        }
      }

After this the content of the svg appear in the list. This option allow to use some of the svg properties "animateTransform" and off course not all properties for security reasons.

This process is ok from MSFT or will be internally validated and remove/pause in the future?

Dear @shagra-ms,
Any update on this question or I'm overthinking to much?

Have you tried a base64 encoded SVG as the source?
i guess the general concern on SVG in this regard is that it might contain a script tag, which could indeed be a security risk.

@StfBauer I saw that SharePoint Online security policies is blocking script tag from svg and other properties. didn't try the encode64 but could give a try.

@StfBauer My question is the fact when you upload a svg to SharePoint library and click on the svg, than you have the preview working "off course with some limitations". Base on this i assume you can call the svg from the sharepoint library just don't want to have any surprises and removal of options...


Use @model.id.nil? to determine resource#is_new? instead of resource#id.nil?

Fixes create callback and resource saving when id is overridden to something else, like an UUID.
This happens when I want to keep integer id’s internally for the database relations but use an UUID on the public JSON interface.
Since UUID creation happens on resource initialization create callbacks never run.
Example resource:
class Api::V1::MyResource < JSONAPI::Resource
  def id
    @model.uuid
  end
end

Using a separate ID and UUID in the database also needs some tweaking, like overriding:
class Api::V1::MyResource < JSONAPI::Resource
  def self._primary_key
    :uuid
  end
end

On a sidenote it would be cool if one could define setters not just getters for the resource, and be able to define different required attributes for show and create. So if I want to be able to create an :email attribute but not include :email for the show operation, I'd have to return nils, which can be confusing:
class Api::V1::MyResource < JSONAPI::Resource
  attribute :email # Allows write

  def email; end # disables read
end

Should I open a new issue with these? I am also having trouble running the specs, they fail with all sorts error before running the suite... Shouldn't a bundle install && bundle exec rake be enough?

This PR fails three tests on my local build, all related to using @model.new_record? when the underlying model isn't based on ActiveRecord.
The early failure you are seeing is apparently due to an update to minitest-reporters 1.1.0 (#428). While that is being fixed you could test with the old 1.0.11 version.

#428 is now fixed (by removing the gem, since it was no longer used).

Back to your PR:

This happens when I want to keep integer id’s internally for the database relations but use an UUID on the public JSON interface.
Since UUID creation happens on resource initialization create callbacks never run.

This project originally tried to allow for this sort of alternate id behind the scenes, however we ran into quite a few issues and support was dropped. If I remember correctly the problems were with the relationships.

Thanks for your prompt reply! I will do a rebase and check the tests.
Re: having both IDs and UUIDs, I guess I will be good until I add on some relationships, by then I will eighter move to a 128bit integer in the DB for the primary ID or we see if it's worth adding support for this to this gem.

I have pushed a new version which checks on the model's id attribute, this should make it work in all scenarios.

Based on the fact that support for other types of models has progressed and is_new? is a public method that can be safely overridden in the application, I'd recommend closing this and just overriding is_new? in your resource(s).


Workplace: Option do not restart app, just reposition

Description of the new feature / enhancement
Hello!
I really like the Workplace app. However if some apps (e.g. Outlook) are open already, and I start a workplace, then a new instance of the same app is started. This results in too many open windows.
Therefore I suggest the following feature:

On the 'edit page' there should be a new option for every app called "[ ] Use existing App instances if available"
If the option is disabled: Behaviour is as it is now. New app is started, and window is arranged as requested.
If the option is enabled and no instance of the app is currently active: New app is started, and window is arranged as requested.
If the option is enabled and at least one instance of the app is currently active: The first instance of the app is arranged to the window position, as defined in teh workplace. No new instance of the app is started.

Greetings,
BerndGit
Scenario when this would be used?
When I just want to rearrange my windows, instead of starting new apps.
Supporting information
No response

@BerndGit Hi, with the brand new PT 0.87 the repositioning is possible. All you have to do is to check the "Move existing windows" checkbox in the editor. It applies to the whole workspace.

@donlaci:  WoW, this was fast!  Works like I need it. Thank you for your feedback, BerndGit


Minifilter driver is NOT a universal driver

1>ApiValidation : warning : API FilterVolumeFindNext in fltlib.dll is not a supported universal API. minispy.exe calls this API.
1>ApiValidation : warning : API FilterVolumeInstanceFindClose in fltlib.dll is not a supported universal API. minispy.exe calls this API.
1>ApiValidation : warning : API FilterVolumeInstanceFindFirst in fltlib.dll is not a supported universal API. minispy.exe calls this API.
1>ApiValidation : warning : API FilterVolumeInstanceFindNext in fltlib.dll is not a supported universal API. minispy.exe calls this API.
1>  ApiValidation: Driver located at C:\Users\dcg\Desktop\minispy\filter\Output is NOT a Universal Driver
``

There are lots of these, even for `CloseHandle` and other basic functions. The end conclusion is that this is not a universal driver, and build fails.

No repro
D:\git\github\Windows-driver-samples\filesys\miniFilter\minispy>msbuild /v:m
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

  Building 'minispy' with toolset 'WindowsKernelModeDriver10.0' and the 'Universal' target platform.
  minispy.c
  mspyLib.c
  RegistrationData.c
  Generating Code...
  minispy.vcxproj -> D:\git\github\Windows-driver-samples\filesys\miniFilter\minispy\filter\x64\Debug\minispy.sys
  minispy.vcxproj -> x64\Debug\minispy.pdb (Full PDB)
  Done Adding Additional Store
  Successfully signed: D:\git\github\Windows-driver-samples\filesys\miniFilter\minispy\filter\x64\Debug\minispy.sys

  Driver is a Universal Driver.
  Inf2Cat task was skipped as there were no inf files to process

  Building 'minispy' with toolset 'WindowsApplicationForDrivers10.0' and the 'Desktop' target platform.
  mspyLog.c
  mspyUser.c
  Generating Code...
  minispy.vcxproj -> D:\git\github\Windows-driver-samples\filesys\miniFilter\minispy\user\x64\Debug\minispy.exe
  minispy.vcxproj -> x64\Debug\minispy.pdb (Full PDB)


not working

Hi, I tried to implement this with my knowledge of how it works in Angular, that is, handle the subscription by myself. It worked right, but it was failing in RTL. So I followed the documentation and used the <Subscribe></Subscribe> component to wrap my component, but I was getting an error Uncaught [Error: Missing Subscribe!]. So I brought down my implementation and followed the docs word for word, but the error didn't go away. Below is the code and the error:
import { createSignal } from "@react-rxjs/utils"
import { map } from "rxjs/operators"

// A signal is an entry point to react-rxjs. It's equivalent to using a subject
const [textChange$, setText] = createSignal<string>();

const [useText, text$] = bind(textChange$, "")

function TextInput() {
  const text = useText()

  return (

      <input
        type="text"
        value={text}
        placeholder="Type something..."
        onChange={(e) => setText(e.target.value)}
      />

      Echo: {text}

  )
}

// Previously...
// const [useText, text$] = bind(...);

const [useCharCount, charCount$] = bind(
  text$.pipe(
    map((text) => text.length)
  )
)

function CharacterCount() {
  const count = useCharCount()

  return <>Character Count: {count}</>
}

function CharacterCounter() {
    return (

        <Subscribe>
          <TextInput />
          <CharacterCount />
        </Subscribe>

    )
  }

export default CharacterCount

##Steps to Produce

Create react app with typescript template
Copy paste the code from the documentation
Run npm start

Hi @afroguy16 ! Thanks for reporting this. Unfortunately, though, I can't manage to reproduce the issue.
Could you please provide us with a codesandbox, stackblitz or a github repo that we can use to reproduce this issue?
Thanks!


Added CHANGELOG and verifier workflow

Signed-off-by: Harsha Vamsi Kalluri<EMAIL_ADDRESS>Description
Adds a new pull request template to ensure that making a changelog entry is a required item. Adds a changelog verifier to ensure that each commit has associated change in the changelog.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

There's a discussion on whether issue templates should be duplicated in https://github.com/opensearch-project/opensearch-go/pull/172#discussion_r996026633, let's resolve that before committing copies of those all over the place?


Sails 0.12 to 1.0 upgrade

Sails version: <IP_ADDRESS>
Node version:  9.4.0
NPM version: 5.6.0
DB adapter name: N/A
DB adapter version: N/A
Operating system: CentOS

I am trying to upgrade my app from Sails 0.12 to 1.0. However, I am getting the following error message when making a socket GET call. Its a call to a controller that was mapped to model.
 message: "Model.find(...).meta is not a function" stack: "TypeError: Model.find(...).meta is not a function     at Object.findRecords (/usr/lib/myapp/node_modules/sails/lib/hooks/blueprints/actions/find.js:31:56)     at /usr/lib/myapp/node_modules/sails/lib/router/bind.js:247:46     at routeTargetFnWrapper (/usr/lib/myapp/node_modules/sails/lib/router/bind.js:391:9)     at Layer.handle [as handle_request] (/usr/lib/myapp/node_modules/router/lib/layer.js:93:5)     at next (/usr/lib/myapp/node_modules/router/lib/route.js:144:13)     at Route.dispatch (/usr/lib/myapp/node_modules/router/lib/route.js:109:3)     at handle (/usr/lib/myapp/node_modules/router/index.js:520:11)     at Layer.handle [as handle_request] (/usr/lib/myapp/node_modules/router/lib/layer.js:93:5)     at /usr/lib/myapp/node_modules/router/index.js:296:22     at Function.process_params (/usr/lib/myapp/node_modules/router/index.js:354:12)     at next (/usr/lib/myapp/node_modules/router/index.js:290:10)     at next (/usr/lib/myapp/node_modules/router/lib/route.js:124:14)     at module.exports (/usr/lib/myapp/api/policies/logAction.js:37:10)     at routeTargetFnWrapper (/usr/lib/myapp/node_modules/sails/lib/router/bind.js:391:9)     at Layer.handle [as handle_request] (/usr/lib/myapp/node_modules/router/lib/layer.js:93:5)     at next (/usr/lib/myapp/node_modules/router/lib/route.js:144:13)     at Route.dispatch (/usr/lib/myapp/node_modules/router/lib/route.js:109:3)     at handle (/usr/lib/myapp/node_modules/router/index.js:520:11)     at Layer.handle [as handle_request] (/usr/lib/myapp/node_modules/router/lib/layer.js:93:5)     at /usr/lib/myapp/node_modules/router/index.js:296:22     at Function.process_params (/usr/lib/myapp/node_modules/router/index.js:354:12)     at next (/usr/lib/myapp/node_modules/router/index.js:290:10)"
Did i miss something in upgrade? Thank you!

Do you use sails-hook-validation? It doesn't work and there's no plugins to achieve same behaviour :(

I have this issue on v1.0.0-46

@theunreal @sgress454 was anyone able to solve this?


update to use codecov-action v5

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.77%. Comparing base (608e799) to head (9c0c30d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   50.67%   50.77%   +0.10%
==========================================
  Files        1091     1091
  Lines       99767    99761       -6
==========================================
+ Hits        50555    50657     +102
+ Misses      49212    49104     -108

Flag
Coverage Δ

g3proxy
50.77% <ø> (+0.10%)
:arrow_up:

lib
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Figure out process for gathering newsletter articles

Need to figure out the process of gathering news articles and content for a newsletter from any NC Open Pass team member

Post links in a Google Doc within the marketing folder -> https://docs.google.com/document/d/1ENiXygOZ8LCoXxy0fS2Ww7aSgFUhAqMacAB4ARvrors/edit?usp=sharing


[Service Bus] Batching Receiver Batch Receiver - disconnects Batch Receiver - disconnects (non-session) can receive and settle messages after a disconnect failing in nightly runs

Service Bus nightly test runs are failing with:

Stack trace:
ServiceBusError: Websocket connection failed.
at translateServiceBusError (dist-test/index.browser.js:38649:20)
at MessageSender.open (dist-test/index.browser.js:43249:41)
at async Object.operation (dist-test/index.browser.js:43315:21)
at async retry$3 (dist-test/index.browser.js:15306:26)
at async MessageSender.createBatch (dist-test/index.browser.js:43330:34)
at async ServiceBusSenderImpl.sendMessages (dist-test/index.browser.js:43413:25)
at async Context. (dist-test/index.browser.js:47137:21)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1790758&view=results

A transient issue, closing now.
Will revisit if repeated


Usage permission

Hi,
I found your local storage example to be really helpful, but it currently specifies no license. Would you be happy to add a licence for the code, or give express permission for this to be used please? I want to make use of it for our medical research tools found on the CRSU GitHub account.
Thanks
Janion

Thanks for checking. I updated the repo: https://github.com/RinteRface/shinyLocalStorage?tab=MIT-1-ov-file#readme.

Thanks so much for getting back so quickly!


Add OpenEBS Kubermatic addon

Addon deploys the OpenEBS operator and creates a default storage class
for the Jive storage engine.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@chrkl please add a short description to https://github.com/kubermatic-labs/community-components#kubermatic-addons

@chrkl please add a short description to https://github.com/kubermatic-labs/community-components#kubermatic-addons

@toschneck done

@toschneck done


Generate placeholder for SYNOPSIS, instead of duplicate of SYNTAX

Currently, we use output of Get-Help to generate SYNOPSIS and don't distinguish between a custom one and help-engine generated one.
We should make it a placeholder, if it's not present to avoid confusion and make bootstrap experience better.

@vors
So, are you saying we generate a new header called Synopsis if none exists and leave it with a note saying 'To Be Filled'?
Can you provide the example where you saw this?

No, I'm saying we should do this. Currently we are putting duplicate of SYNTAX, because help engine generates defaul SYNOPSIS as duplicate of SYNTAX and we just using it.

How about this for the look:
Update-MarkdownHelp
SYNOPSIS
{{ Add a synopsis here. }}
SYNTAX
Update-MarkdownHelp [-Path] <String[]> [[-Encoding] <Encoding>] [[-LogPath] <String>] [-LogAppend]
 [<CommonParameters>]

Fixed per c5ac385


bedrock[minor]: add support for metadata filtering

Hey there! Bedrock supports filtering the documents that are searched for information by passing a RetrievalFilter object, and I wanted to be able to use this functionality with LangChain.
I added the necessary parameters to the queryKnowledgeBase function to allow for filters to be optionally passed when querying a Bedrock Knowledge Base.
This PR needs some more work, as I have been unable to build/test the repository when following the contributing guidelines.
This is my first PR on a public repository, so any help would be appreciated!
Fixes #5600

@nick-elpedes Hi, FYI, I reworked this here https://github.com/langchain-ai/langchainjs/pull/6189

Alright, in that case, I'll close this. Thank you!


Update README.md

Change-type: patch

@danthegoodman1 I just created the PR to get the contract-repo rename tested<EMAIL_ADDRESS>), but maybe you can pick it up and replace the readme template

@Hades32 Yep I need to update a few README.mds, will do once I get this publisher tested and everything is working :)


stage and prod profiles

Background
Profiles for stage and production
Problem/Issue
What have I done
Check list
I have:

[ ] Tested with Stub run
[ ] Tested on our HPC

Ran:
/projects/fs1/shared/external-tools/nextflow/latest/nextflow run /projects/fs1/shared/Development_Github/singleCellWorkflows -bg -profile standard,stage --samplesheet /projects/fs1/stage_shared/Jobs/2023_180/2023_180_SampleSheet.csv > /projects/fs1/stage_shared/Logs/Singlecell/2023_180_started231026_090909.log
The command finished without errors, got e-mail, see log:
cat /projects/fs1/stage_shared/Logs/Singlecell/2023_180_started231026_090909.log
N E X T F L O W  ~  version 22.04.5
Launching `/projects/fs1/shared/Development_Github/singleCellWorkflows/main.nf` [lethal_brattain] DSL2 - revision: 3890d63c78
[b0/e87c3c] Submitted process > FLEX_SCRNASEQ:SPLITSHEET
[ad/41d892] Submitted process > VISIUM:SPLITSHEET
[fe/74f1ce] Submitted process > SCMULTI:SPLITSHEET
[26/a1dd5a] Submitted process > GET_ANALYSISES
[4b/40ae03] Submitted process > SC_ATAC:SPLITSHEET
[74/4a7dac] Submitted process > SC_ARC:SPLITSHEET
[90/8a4c8e] Submitted process > SCCITESEQ:SPLITSHEET
[d5/b6d87d] Submitted process > SCRNASEQ:SPLITSHEET
[a6/dd0494] Submitted process > SCRNASEQ:FASTQC (INVR_P1B_D3)
[e2/ba7e26] Submitted process > SCRNASEQ:COUNT (INVR_P1B_D3)
[a8/f1642b] Submitted process > SCRNASEQ:FINISH_PROJECTS:MULTIQC (2023_180)
[b7/3de004] Submitted process > SCRNASEQ:FINISH_PROJECTS:SYNC_MULTIQC (2023_180)
[ec/1c9489] Submitted process > SCRNASEQ:FINISH_PROJECTS:PUBLISH_MANIFEST (2023_180)
[bf/3e0883] Submitted process > SCRNASEQ:FINISH_PROJECTS:MD5SUM (2023_180)
[6b/fdf6cf] Submitted process > SCRNASEQ:FINISH_PROJECTS:DELIVER_PROJ (2023_180)

No files was printed to prod:
ls /projects/fs1/shared/Jobs/
2022_069  2023_098  2023_114  2023_140  2023_150  2023_162    2023_184  2023_196  2023_201  2023_206_fastq  2023_214  2023_223  2023_232  bjhall     Logs
2022_179  2023_108  2023_129  2023_142  2023_159  2023_171    2023_188  2023_198  2023_203  2023_209        2023_217  2023_227  2023_237  GMS_AL
2022_206  2023_110  2023_134  2023_144  2023_160  2023_180_o  2023_190  2023_200  2023_205  2023_212        2023_219  2023_231  2023_239  HMM3HDMXY


Document backend.get_device_from_array

Document chainer.backend.get_device_from_array.

Jenkins, test this please.

Jenkins CI test (for commit 68a42b0c52e7e75f34034ba3449c9d185dcedc2f, target branch master) failed with status FAILURE.

LGTM! Test failures are not related to this PR.


Bump and update for fresh chartpressing

I bumped chartpress but also clarified various things etc in docs.

removed use of deprecated --commit-range that is now handled
automatically.
trimmed paths in chartpress.yaml to what mattered and documented some
reasons for that.
added notes to the Dockerfile which I spent time understanding more in
detail while working on this PR.
added resetTag and resetVersion to the chartpress.yaml configuration,
allowing the use of the --reset flag to reset values.yaml and Chart.yaml
to the state it was in before chartpress was run locally.

Potentially breaking change
Note the Helm chart versions for JupyterHub with names like jupyterhub-0.9.0-alpha.1.033.fd3e470? With chartpress 0.4.3, this is what you will get for BinderHub as well. The pattern is <chartname>-<version>[-<pre-release-tag>[.nnn.sha]], this could influence henchbot etc. perhaps.

@henchc what do you think about the version tag changing and henchbot?
In general I'd be conservative with changing the build infrastructure in this repository. "Never touch a running system." It works well, there are several automations built on top of this that help keep mybinder.org fresh as well as some other public BinderHubs.
Some of the content of the chartpress config were arrived at after debugging subtle bugs that don't always happen (and had gone unnoticed for a long time). So we should take our time when changing things to make sure they don't resurface.
Not against modernisation but at a slow pace please 🐌

@choldgraf could you take a look at https://circleci.com/gh/jupyterhub/binderhub/578?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link which seems to be failing because it can't find a tag/reference. Is this a bit of the docs that is being "copy&pasted" from a different repo? It worked a few days ago when master was last built which makes me wonder if the recent changes (pandas theme re-org) in a different repo broke something:-/

My guess is that this code is what is now failing @choldgraf. A new PR to fix it would be great.

@betatim does this kind of error happen often?
https://travis-ci.org/jupyterhub/binderhub/jobs/613744946?utm_medium=notification&utm_source=github_status
I'm confident it is something I've tracked down and fixed in z2jh + jupyterhub in some PRs, but they require a bump of z2jh + jupyterhub. Anyhow, I assume we can also press restart build job on that to make things succeed.

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:
https://discourse.jupyter.org/t/binder-jupyterhub-activity-round-up-week-1/2704/1


[Question] Results vastly different for an agent created with Stable Baselines3 using hyperparameters optimized in RL Baselines3 Zoo.

❓ Question
Hello,
I first optimize A2C on 1mln steps using RL Baselines3 Zoo:
Firstly i have changed a2c.yml in RL Baselines3 Zoo to work with RAM version of Seaquest:
atari:
  policy: 'MlpPolicy'
  n_envs: 16
  policy_kwargs: "dict(optimizer_class=RMSpropTFLike, optimizer_kwargs=dict(eps=1e-5))"

Then wrote command:
python -m train --algo a2c --env ALE/Seaquest-ram-v5 -n 1000000 -optimize --n-trials 100 --n-startup-trials 10
--sampler tpe --pruner median  --n-evaluations 4 --n-eval-envs 16 --storage "some_valid_database" --study-name test

Top 3 results:

Then using for example these hyperparameters:

and using this code:
def linear_decay_lr(progress_remaining):
    return 0.00027232300584036946 * progress_remaining
if __name__ == "__main__":
    vec_env = make_vec_env("ALE/Seaquest-ram-v5", n_envs=16)
    model = A2C(
        "MlpPolicy",
        vec_env,
        learning_rate=linear_decay_lr,
        n_steps=256,
        gamma=0.999,
        gae_lambda=0.98,
        ent_coef=0.00001753537605091099,
        vf_coef=0.19195701505334234,
        max_grad_norm=0.5,
        use_rms_prop=True,
        normalize_advantage=False,
        verbose=1,
        tensorboard_log="./seaquest/107",
        policy_kwargs=dict(activation_fn=torch.nn.Tanh, net_arch=dict(pi=[256, 256], vf=[256, 256]), ortho_init=True,
                                      optimizer_class=RMSpropTFLike, optimizer_kwargs=dict(eps=1e-5))
    )
    model.learn(total_timesteps=1000000, log_interval=1)

I get results:

As picture shows, result is long way from 456 that RL Baselines Zoo got to. I have used more hyperparameters, but scores are always much lower.
What I'm aware of that can have impact on this issue is seed, as I didn't pick the same. Nevertheless I have tried many instances of A2C and the problem remains.
Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the SB3 documentation
[X] I have read the RL Zoo documentation
[X] If code there is, it is minimal and working
[X] If code there is, it is formatted using the markdown code blocks for both code and stack traces.

Probably a duplicate of https://github.com/DLR-RM/rl-baselines3-zoo/issues/314 https://github.com/DLR-RM/rl-baselines3-zoo/issues/204 and others (see link in the other issues)


IAM ManagedPolicy PolicyDocument Character limit of 6144 should not include whitespaces

cfn-lint version: (cfn-lint --version) 0.48.2
Description of issue.
There is a 6,144 character limit on IAM managed policies but this does/should not include whitespaces (source). cfn-lint flagged a PolicyDocument of mine as too long, while Cloudformation successfully deploys it. This character limit check would be very helpful if it checked against the same 6,144 character limit that AWS does.
The PolicyDocument is defined in CFN in JSON. I can copy-and-paste this JSON into the AWS Policy Editor and it tells me there are only 4,189 characters in it. I can successfully deploy the CFN stack with this same policy. Counting whitespace, there are 9,849 characters so it seems highly likely that cfn-lint is counting whitespace when it should not be.
cfn-lint complaint:
E3502 Role trust policy JSON text cannot be longer than 6144 characters
Please provide as much information as possible:

Template linting issues:

Please provide a CloudFormation sample that generated the issue.
If present, please add links to the (official) documentation for clarification.
Validate if the issue still exists with the latest version of cfn-lint and/or the latest Spec files

Feature request:

Please provide argumentation about the missing feature. Context is key!

Cfn-lint uses the CloudFormation Resource Specifications as the base to do validation. These files are included as part of the application version. Please update to the latest version of cfn-lint or update the spec files manually (cfn-lint -u)

Thanks for reporting this.  I'll take a look.

@tcdachille do you have an example policy I can look at? We are removing white space when doing the analytics?
https://github.com/aws-cloudformation/cfn-python-lint/blob/853522ff0e4c977331ac677a47059cf96b6f3189/src/cfnlint/rules/resources/properties/JsonSize.py#L69
I built one that I'm measuring at 6155 characters and checked it on the policy analyzer which also said it was to large.  I feel like we are comparing correctly here but I may be missing something.  Do you have any CloudFormation functions inside your policy?

An example that's not any more complicated than what I'm doing would be (mostly the first few AWS managed policies strung together) the following-
cfn-lint prints the same E3502 Role trust policy JSON text cannot be longer than 6144 characters error for this, but pasted into AWS Policy editor, it says it's 5,547 characters.
---
AWSTemplateFormatVersion: 2010-09-09

Resources:
  ExamplePolicy:
    Type: AWS::IAM::ManagedPolicy
    Properties:
      ManagedPolicyName: 'example-policy'
      PolicyDocument: |
            {
                "Version": "2012-10-17",
                "Statement": [
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ec2:DescribeAddresses",
                            "ec2:DescribeByoipCidrs",
                            "ec2:DescribeVpcEndpoints",
                            "ec2:DescribeVpcs",
                            "iam:GetRole",
                            "iam:ListRoles",
                            "kms:DescribeKey",
                            "kms:GetKeyPolicy",
                            "kms:ListGrants",
                            "kms:ListKeyPolicies",
                            "kms:ListKeys",
                            "lambda:GetLayerVersionPolicy",
                            "lambda:GetPolicy",
                            "lambda:ListAliases",
                            "lambda:ListFunctions",
                            "lambda:ListLayers",
                            "lambda:ListLayerVersions",
                            "lambda:ListVersionsByFunction",
                            "organizations:DescribeAccount",
                            "organizations:DescribeOrganization",
                            "organizations:DescribeOrganizationalUnit",
                            "organizations:ListAccounts",
                            "organizations:ListAccountsForParent",
                            "organizations:ListAWSServiceAccessForOrganization",
                            "organizations:ListChildren",
                            "organizations:ListDelegatedAdministrators",
                            "organizations:ListOrganizationalUnitsForParent",
                            "organizations:ListParents",
                            "organizations:ListRoots",
                            "s3:GetAccessPoint",
                            "s3:GetAccessPointPolicy",
                            "s3:GetAccessPointPolicyStatus",
                            "s3:GetAccountPublicAccessBlock",
                            "s3:GetBucketAcl",
                            "s3:GetBucketLocation",
                            "s3:GetBucketPolicyStatus",
                            "s3:GetBucketPolicy",
                            "s3:GetBucketPublicAccessBlock",
                            "s3:ListAccessPoints",
                            "s3:ListAllMyBuckets",
                            "sns:GetTopicAttributes",
                            "sns:ListTopics",
                            "secretsmanager:DescribeSecret",
                            "secretsmanager:GetResourcePolicy",
                            "secretsmanager:ListSecrets",
                            "sqs:GetQueueAttributes",
                            "sqs:ListQueues"
                        ],
                        "Resource": [
                            "arn:aws:iam::123456789123:user/example_user1",
                            "arn:aws:iam::123456789123:user/example_user2",
                            "arn:aws:iam::123456789123:user/example_user3",
                            "arn:aws:iam::123456789123:user/example_user4",
                            "arn:aws:iam::123456789123:user/example_user5",
                            "arn:aws:iam::123456789123:user/example_user6",
                            "arn:aws:iam::123456789123:user/example_user7",
                            "arn:aws:iam::123456789123:user/example_user8"
                        ]
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ssm:DescribeAssociation",
                            "ssm:GetDeployablePatchSnapshotForInstance",
                            "ssm:GetDocument",
                            "ssm:DescribeDocument",
                            "ssm:GetManifest",
                            "ssm:GetParameters",
                            "ssm:ListAssociations",
                            "ssm:ListInstanceAssociations",
                            "ssm:PutInventory",
                            "ssm:PutComplianceItems",
                            "ssm:PutConfigurePackageResult",
                            "ssm:UpdateAssociationStatus",
                            "ssm:UpdateInstanceAssociationStatus",
                            "ssm:UpdateInstanceInformation"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ssmmessages:CreateControlChannel",
                            "ssmmessages:CreateDataChannel",
                            "ssmmessages:OpenControlChannel",
                            "ssmmessages:OpenDataChannel"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ec2messages:AcknowledgeMessage",
                            "ec2messages:DeleteMessage",
                            "ec2messages:FailMessage",
                            "ec2messages:GetEndpoint",
                            "ec2messages:GetMessages",
                            "ec2messages:SendReply"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "cloudwatch:PutMetricData"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ec2:DescribeInstanceStatus"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "ds:CreateComputer",
                            "ds:DescribeDirectories"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "logs:CreateLogGroup",
                            "logs:CreateLogStream",
                            "logs:DescribeLogGroups",
                            "logs:DescribeLogStreams",
                            "logs:PutLogEvents"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "s3:GetBucketLocation",
                            "s3:PutObject",
                            "s3:GetObject",
                            "s3:GetEncryptionConfiguration",
                            "s3:AbortMultipartUpload",
                            "s3:ListMultipartUploadParts",
                            "s3:ListBucket",
                            "s3:ListBucketMultipartUploads"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "a4b:RegisterDevice",
                            "a4b:CompleteRegistration",
                            "a4b:SearchDevices",
                            "a4b:SearchNetworkProfiles",
                            "a4b:GetNetworkProfile",
                            "a4b:PutDeviceSetupEvents"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "chime:CreateMeeting",
                            "chime:CreateMeetingWithAttendees",
                            "chime:DeleteMeeting",
                            "chime:GetMeeting",
                            "chime:ListMeetings",
                            "chime:CreateAttendee",
                            "chime:BatchCreateAttendee",
                            "chime:DeleteAttendee",
                            "chime:GetAttendee",
                            "chime:ListAttendees",
                            "chime:ListAttendeeTags",
                            "chime:ListMeetingTags",
                            "chime:ListTagsForResource",
                            "chime:TagAttendee",
                            "chime:TagMeeting",
                            "chime:TagResource",
                            "chime:UntagAttendee",
                            "chime:UntagMeeting",
                            "chime:UntagResource"
                        ],
                        "Resource": [
                            "arn:aws:iam::123456789123:user/example_user1",
                            "arn:aws:iam::123456789123:user/example_user2",
                            "arn:aws:iam::123456789123:user/example_user3",
                            "arn:aws:iam::123456789123:user/example_user4",
                            "arn:aws:iam::123456789123:user/example_user5",
                            "arn:aws:iam::123456789123:user/example_user6",
                            "arn:aws:iam::123456789123:user/example_user7",
                            "arn:aws:iam::123456789123:user/example_user8",
                            "arn:aws:iam::123456789123:policy/example_policy1",
                            "arn:aws:iam::123456789123:policy/example_policy2",
                            "arn:aws:iam::123456789123:policy/example_policy3"
                        ]
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "cognito-identity:*",
                            "cognito-idp:*",
                            "cognito-sync:*",
                            "iam:ListRoles",
                            "iam:ListOpenIdConnectProviders",
                            "sns:ListPlatformApplications",
                            "iam:GetRole",
                            "iam:ListOpenIDConnectProviders",
                            "iam:ListRoles",
                            "iam:ListSAMLProviders",
                            "iam:GetSAMLProvider",
                            "kinesis:ListStreams",
                            "lambda:GetPolicy",
                            "lambda:ListFunctions",
                            "sns:ListPlatformApplications",
                            "ses:ListIdentities",
                            "ses:GetIdentityVerificationAttributes",
                            "mobiletargeting:GetApps",
                            "acm:ListCertificates"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Allow",
                        "Action": "iam:CreateServiceLinkedRole",
                        "Resource": "*",
                        "Condition": {
                            "StringEquals": {
                                "iam:AWSServiceName": [
                                    "cognito-idp.amazonaws.com",
                                    "email.cognito-idp.amazonaws.com"
                                ]
                            }
                        }
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "iam:DeleteServiceLinkedRole",
                            "iam:GetServiceLinkedRoleDeletionStatus"
                        ],
                        "Resource": [
                            "arn:aws:iam::*:role/aws-service-role/cognito-idp.amazonaws.com/AWSServiceRoleForAmazonCognitoIdp*",
                            "arn:aws:iam::*:role/aws-service-role/email.cognito-idp.amazonaws.com/AWSServiceRoleForAmazonCognitoIdpEmail*"
                        ]
                    },
                    {
                        "Effect": "Allow",
                        "Action": [
                            "connect:Get*",
                            "connect:Describe*",
                            "connect:List*",
                            "ds:DescribeDirectories"
                        ],
                        "Resource": "*"
                    },
                    {
                        "Effect": "Deny",
                        "Action": "connect:GetFederationTokens",
                        "Resource": "*"
                    }
                ]
            }
...

Can also workaround with resource-level ignores until this is fixed:
Resources:
  ExamplePolicy:
    Type: AWS::IAM::ManagedPolicy
    Metadata:
      cfn-lint:
        config:
          ignore_checks:
            - E3502

okay I know what the problem is now.  Should have it fixed soon.

Thanks for the quick fix! Yep sorry forgot to update this issue, but was talking with Pat over Slack yesterday and also realized it had to do with converting it to a string :+1:

yea, you two got it.  I finally figured it out :) To make it worse we start adding characters to escape out the special characters so absolutely something we needed to get fixed.


publish docker images

do you have a dedicated Docker hub repo?

Awesome, I set up https://quay.io/tmc/pqstream in preparation!

I want to solve this issue.
I already created a dockerfile update in my fork and I'll see if it's passing.
please tell me what an "official docker image" means and I'll do my best
This is the file I changed