Problem with execution of sql statement for findings (for assets)

https://github.com/schubergphilis/Seccubus_v2/commit/7d69794b3f80dcd443b7862594a4d813d96b50e9#diff-9b21b4982f8c0172e8b3546e4ac782a5R128
"Problem with execution of sql statement 			SELECT DISTINCT findings.id, findings.host, host_names.name as hostname, 				port, plugin, finding, remark, 				findings.severity as severity_id, 				severity.name as severity_name, 				findings.status as status_id, 				finding_status.name as status,				findings.scan_id as scan_id,				scans.name as scan_name			FROM				findings				LEFT JOIN host_names on host_names.ip = host and host_names.workspace_id = ?				LEFT JOIN severity on findings.severity = severity.id				LEFT JOIN finding_status on findings.status = finding_status.id				LEFT JOIN scans on scans.id = findings.scan_id,				LEFT JOIN issues2findings ON issues2findings.finding_id = findings.id				assets,				asset_hosts						WHERE				findings.workspace_id = ? AND				assets.workspace_id = findings.workspace_id AND				asset_hosts.asset_id = assets.id and (asset_hosts.ip = findings.host or asset_hosts.host = findings.host or findings.host LIKE CONCAT('%/',asset_hosts.ip))				AND assets.id = ? AND status = ?  ORDER BY host, port, plugin LIMIT ?
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LEFT JOIN issues2findings ON issues2findings.finding_id = findings.id
assets' at line 15
at /opt/seccubus/SeccubusV2/SeccubusDB.pm line 159	SeccubusDB::sql('return', 'ref', 'query', '\x{a}\x{9}\x{9}\x{9}SELECT DISTINCT findings.id, findings.host, host_names.na...', 'values', 'ARRAY(0x15cbf30)')
called at /opt/seccubus/SeccubusV2/SeccubusFindings.pm line 196	SeccubusFindings::get_findings(100, 0, 1, 'HASH(0xa0c0c8)', 200)
called at /opt/seccubus/www/seccubus/json/getFindings.pl line 109	eval {...}
called at /opt/seccubus/www/seccubus/json/getFindings.pl line 133"

Am I right in saying that this happens when you try to view findings that are associated with an asset?

Yes.

See also #359 which is a duplicate, but has this line:
After chaning FROM findings, asset2scan to FROM (findings, asset2scan) there is no sql error anymore and json response is valid. But there is no usable filter data (maybe it's my missconfiguration in asset).


Agent.onClose not called when ErrorHandler closes AgentRunner

This might be by design or my weird usage, but if the ErrorHandler closes its own AgentRunner then onClose of Agent is not called on close.
Example code here https://gist.github.com/jheusser/1cb33999f281e5a7719a07ad158bbb21

In your example you are closing the agent before started it. By doing this it will not enter the run loop and thus never reach onClose() because running will be false. So the question is how can a error handler be called before something is running? Unless I'm missing something the example is very contrived.
https://github.com/real-logic/Agrona/blob/master/src/main/java/org/agrona/concurrent/AgentRunner.java#L102

The example might not be too obvious, but the SomeAgent does run doWork once invoked by the AgentRunner, then throws an exception which invokes the RunOnError error handler. Only then the error handler closes the AgentRunner, which does not run onClose of its agents.

What am I missing? In the example you give close is called before the agent is schedule to run.

I am starting to doubt myself but I think what you are referring to is passing the close method to the error handler, but it is not invoking it, it just sets it as Runnable:
https://gist.github.com/jheusser/1cb33999f281e5a7719a07ad158bbb21#file-agenttest-java-L47
The close is only invoked on the first error.

Sorry I missed that. I'll have a proper look this week and debug this.

Rather than me being silly and just reading the code I ran it this time. Duh! I can see what the issue is now. The Agent was never closed in your example. If you change the main to be like the below then it works.
    public static void main(String[] args) throws Exception
    {
        RunOnError closeOnError = new RunOnError();

        AgentRunner agentRunner = new AgentRunner(new BusySpinIdleStrategy(), closeOnError, null, new SomeAgent());

        closeOnError.action(agentRunner::close);

        AgentRunner.startOnThread(agentRunner);

        agentRunner.close();
    }


Added more details and fix typos in register definition

Proposed changes

Added an explanation for Registers definition
Fixed typo
For no of bits of different registers, as it depends on architecture and no of bits of the machine, added that the values are for 16 bit machine.

@all-contributors add @AryasCodeTreks for doc


No prompt to update gitignore when there is none

Fixes #1336. The extension no longer offers to add its patterns to .gitignore file when the file does not exist.

Awesome, thanks a lot!


Not all comments scraped

Hi! Can you help me, please? Why I get only 100 comments instead of 500+ that exists (post: https://www.instagram.com/p/B4rStghnt_h/)
options that I used: instaloader --comments -- -B4rStghnt_h

Also running into this issue. For example, post.comments returns 1244 total comments count but get_comments() only pulled 790.

It seems like Instagram changed something concerning comments in their web interface. We tested several posts, both logged in and anonymous. In all cases Instaloader fetches all the comments that are available through the web interface. It is sad to see that there are posts that do not have all the announced comments browsable there anymore. However, the official Instagram app is still able to browse all those comments, so there is still hope that Instaloader will be able to scrape all the comments again through the mobile API in the future.

Duplicate of https://github.com/instaloader/instaloader/issues/680#
I suppose methon dosnt return comments written in response to other comments.


Tokenizer doesn't install

I installed the package from marketplace and all the build tasks show up except the Tokenizer task.  I've uninstalled and reinstalled with no luck.

I believe the issue is related to another build task I installed from Marketplace which has the same task name and folder structure "Tokenizer" in it.  I see that one in my build list but not this one.  Even after uninstalling both and then re-installing this one, I still can't get it to show up in my options.  Any help would be appreciated.

The other package is this one: ms-devlabs.utilitytasks

Hi @dishmal - I'm not sure the name makes a difference since each task has a unique guid. Are you on VSTS or TFS? If TFS, which version?

On-premise TFS 2015 Update 3.

I'm experiencing the same problem. This is the only extension I've installed. TFS 2015 Update 3
All other tasks except Tokenizer are available.

I just noticed the extension manifest json file doesn't list Tokenizer in the files list to set up the path:
"files": [
{
"path": "Tasks/AzureWebDeploy"
},
{
"path": "Tasks/DockerPublish"
},
{
"path": "Tasks/ReplaceTokens"
},
{
"path": "Tasks/VersionAssemblies"
},
{
"path": "Tasks/DacPacReport"
},
{
"path": "Tasks/CoverageGate"
}
],

Thanks @dishmal I just noticed that! I've fixed the manifest in this commit and version 1.1.62 in the marketplace now has the correct manifest. Please let me know if you get the task! (Same for you @omarw)

It now shows up through VSTS and I'll validate it works after the install on my company TFS 2015 install tomorrow at the office, but assuming it will.  Thanks!

The tokenizer task shows up for me now but now I'm getting the following error at build time. Any ideas?
2016-12-06T12:51:31.1308775Z Set workingFolder to default: C:\Agent\tasks\JSONTokenizer\1.1.62
2016-12-06T12:51:31.2402570Z module.js:341
2016-12-06T12:51:31.2402570Z     throw err;
2016-12-06T12:51:31.2402570Z     ^
2016-12-06T12:51:31.2402570Z Error: Cannot find module 'vsts-task-lib/task'

Successfully installed on TFS 2015 Update 3 however I get the same error as @omarw

Oops, didn't mean to close it...

Dang it - my build definition wasn't restoring the dependencies for the Tokenizer task - it's now fixed and working in 1.1.63!


WIP: deepblast vis

Added code to convert TM-align to CIGAR and pack it into scikit-bio object

@valentynbez Is this PR ready to be merged? Thank you!

This will be merged with a different notebook, waiting for an update from @paarth-b.
Should be ready next week!

@qiyunzhu annotations added and notebooks merged.
Ready for review!

@valentynbez Thank you very much! Let's merge then test locally.


Provide AutoAPI and ManualAPI at the official Cuberite buildserver

It should be pretty straight-forward to provide the AutoAPI and ManualAPI files from the official buildserver - just archive the stuff together when building Cuberite.

Files are being produced:
https://builds.cuberite.org/job/Cuberite Windows x64 Master/lastSuccessfulBuild/artifact/AutoAPI.zip
https://builds.cuberite.org/job/Cuberite Windows x64 Master/lastSuccessfulBuild/artifact/ManualAPI.zip
Now we need documentation for using them.


Add page to Documentation for "Media Server"

What does this pull request do? Explain your changes. (required)

Specific updates (required)

Add page to Documentation for "Media Server"

Does this pull request close any open issues?
Fixes # Add page to Documentation for "Media Server"
Screenshots (optional):

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Note: I'm working on securing the final copy for this page. Stay tuned...


Modus Autocomplete - Required to know selected options Ids with event/property (chips | multple)

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the Modus style guidelines

Proposal
As of now, the autocomplete emits two events as follows
optionSelected => emits selected option ID
valueChange => emits the selected option values as comma-separated string
As per these events, we don't have any option to know the option ID when is removed/de-selected
Motivation and context
This is a basic feature available in the DevExtream Tag Box component. As part of migration, this is blocking us.
What is the issue regarding ?
@trimble-oss/modus-web-components, @trimble-oss/modus-angular-components
Priority
High
What product/project are you using Modus Components for ?
MEP Estimation Platform Projects
What is your team/division name ?
Estimation / MEP + GCCM
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
yes, but not all components as there are shortfall in the feature of modus components

This P.R the selectionsChanged event is added to emit event after selecting and deselecting values and an array is set as the detail with the selected values


ContentBlockCards - Same height not working

This component is used by the Reboot team on the Support Landing page.  The bug fix is needed by the end of the day Friday, Aug 28.

Detailed description

Describe in detail the issue you're having.

The ContentBlockCards cards are not getting the same height

Is this a feature request (new component, new icon), a bug, or a general
issue?

Bug

Is this issue related to a specific component?

Yes, ContentBlockCards but is happening with CardGroup too

What did you expect to happen? What happened instead? What would you like to
see changed?

The cards should have same height

What browser are you working in?

Google Chrome

What version of the IBM.com Library are you using?

1.10.0-alpha.4682

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

IBM Support Landing L0 - This should be fixed by EoW, next week visual QA will be done. It's for Reboot team
Steps to reproduce the issue

Go to https://support-page.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4/index.html
Cards don't have the same height

Additional information

I already tried to run yarn update but didn’t have success.

@RobertaJHahn @jeffchew I fixed the issue using the sameHeight utility: http://support-page-test.mybluemix.net/
But this issue should be left open because none of the components which use sameHeight are working as expected on Next js template.
@guilhermelMoraes FYI

@guilhermelMoraes Is this still an issue?  Has it been resolved?

Slack response from Gui:  Hey, Roberta! Yeah, sure, go ahead and close. It was fixed but probably addressed in another ticket


Incorrectly decompresses data

	static const char cszData[] = "\x41\x5F\x28\xE1\xF3\xEA\xE2\xE0\x29";

	char chBuf[ 0x100 ];
	char chBuf1[ 0x100 ];

	int nRes;
	nRes = unishox1_compress( cszData, sizeof( cszData ) - 1, chBuf, 0 );
	nRes = unishox1_decompress( chBuf, nRes, chBuf1, 0 ); // incorrect result!

Is the input valid UTF-8 string?  I don't remember whether binary data is supported or not.
But you should be able to encode and decode UTF-8 sequences correctly.

No, it is not a valid UTF-8 string.
It is not very clear from the description that ONLY valid UTF-8 code words are allowed on input.
Thank you for your job anyway.


tooltip.js error with table editable

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
After submitting an editable field, the Console gives the below error even though the editing succeeds:
tooltip.js:534 Uncaught TypeError: Cannot convert undefined or null to object
    at Function.values (<anonymous>)
    at us._isWithActiveTrigger (tooltip.js:534:19)
    at tooltip.js:268:16
    at g (index.js:226:51)
    at HTMLDivElement.a (index.js:247:5)
    at s (index.js:71:11)
    at index.js:253:7

Reduced test cases
Replace this:
  _isWithActiveTrigger() {
    return Object.values(this._activeTrigger).includes(true)
  }

with this:
_isWithActiveTrigger() {
    if (this._activeTrigger && typeof this._activeTrigger === 'object') {
        return Object.values(this._activeTrigger).includes(true);
    }
    return false; // or handle the case when _activeTrigger is not an object
}

What operating system(s) are you seeing the problem on?
macOS, Linux
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
5.3.1

This is a duplicate of #37474

Thanks @batje! This is indeed a duplicate so I'll close this one. @bounlu, you can add a comment in #37474 with your patch suggestion if it's not already mentioned in the discussion.


Regarding the evaluation

Hi, thanks for the awesome work.
The code for sampling is provided,
but I guess the evaluation code for Vina score, QED, SA, etc. (i.e., Table 1 of the paper), is missing.
For the reproducibility of your work, may I ask you to kindly include the evaluation code?

Thanks for your advice! We will consider adding the evaluation code soon.

We have uploaded the evaluaion code.

Thanks a lot for your kind reply!


Wrapper for script. Desktop application

How about creating some kind of interface to make the patcher easier to use?

I'll think about the app if someone else needs it besides you. Anyway, you can always contribute

I'll think about the app if someone else needs it besides you. Anyway, you can always contribute

well I tried to git clone and it doesn't runs what do I need to execute it?

please add a batch script or an executable. It's more user friendly.

I'll think about the app if someone else needs it besides you. Anyway, you can always contribute

well I tried to git clone and it doesn't runs what do I need to execute it?

Make sure you have node js installed.

I'll think about the app if someone else needs it besides you. Anyway, you can always contribute

well I tried to git clone and it doesn't runs what do I need to execute it?

Make sure you have node js installed.

I just installed it and runs into the same problem do I need to use it via node.js .exe?
or via windows powershell?

here's the error

here's the error

Well, first you need to download the zip itself from GitHub (Code -> Download ZIP).

After unzipping go to the Wemod-patcher directory (cd “path to folder”)
Install the dependencies using the npm install command
Run the script with the command: node ./unlocker.js.

In the screenshot you are not in the Wemod-patcher directory

here's the error

Well, first you need to download the zip itself from GitHub (Code -> Download ZIP).
1. After unzipping go to the Wemod-patcher directory (cd “path to folder”)

2. Install the dependencies using the npm install command

3. Run the script with the command: node ./unlocker.js.

In the screenshot you are not in the Wemod-patcher directory

well I did as you suggested less the dependencies cause I don't know the npm install command.
it didn't even threw an error compreensive enough it's just about some asar cannot find module

Cannot find the module because you have not installed the dependencies with the 'npm install' command. npm is the default package manager. Make sure you have npm installed (default is selected with NodeJS installation)

same error even after installing the node.js again without chocolatey
disregard it I got it working the command to install npm it's npm install without the quotes and you need to close the application to patch it wished that it could get it working the phone remote like one time ago the devs made a mistake or a way for reading whom's using the app cracked but it worked second the relates and reports of some people at cs.rin,ru .
Thanks for your patience do you make another applications or is it your first one?
I would like to support ya.
Do I have to always open terminal and execute in folder with files node ./unlocker.js ?

I'm glad it worked out. Yes, I have other applications, you can see my projects in my profile. I wrote this script for myself and didn't think it would be useful for anyone. Maybe I will actually make an application to make the patch easier to use.
And yes, you should always call node ./unlocker.js but only if WeMod is updated.
If you want to support me you can use the button in the readme from the Support section.

I'm glad it worked out. Yes, I have other applications, you can see my projects in my profile. I wrote this script for myself and didn't think it would be useful for anyone. Maybe I will actually make an application to make the patch easier to use.
And yes, you should always call node ./unlocker.js but only if WeMod is updated.
If you want to support me you can use the button in the readme from the Support section.

it works but the application don't updates the cheats it gets on an always loading mods.
do I need to uninstall it and reinstall it?

I'm glad it worked out. Yes, I have other applications, you can see my projects in my profile. I wrote this script for myself and didn't think it would be useful for anyone. Maybe I will actually make an application to make the patch easier to use.
And yes, you should always call node ./unlocker.js but only if WeMod is updated.
If you want to support me you can use the button in the readme from the Support section.

it works but the application don't updates the cheats it gets on an always loading mods. do I need to uninstall it and reinstall it?

You should just try to close WeMod and start again.  This can be avoided if you start the game directly from WeMod. I don't really know if it's related to the patch or a WeMod bug, but it happens sometimes

ah one off topic question how much do you charge for an unpacker be made also repacker it's a tri-Ace PS2 Games UnPacker. if you are up to I can pay via ko-fi or via stripe pix since my currency is brl or brazilian real I cannot promise much and just if you want it too.
About the WeMod I just uninstalled and will reinstall. To see if the bug persists

ah one off topic question how much do you charge for an unpacker be made also repacker it's a tri-Ace PS2 Games UnPacker. if you are up to I can pay via ko-fi or via stripe pix since my currency is brl or brazilian real I cannot promise much and just if you want it too. About the WeMod I just uninstalled and will reinstall. To see if the bug persists

No, I can't help you with that question. I also don't ask for money for projects. All my projects are open source and available for free even if I ever decide to do something like what you mentioned ;)


xpdAn v0.8.2

Merge only after success.
This pull request was auto-generated by rever

please consider adding yourself and @sbillinge to this feedstock

@conda-forge-admin please rerender.

@conda-forge-admin please rerender

yes, I am.
On Wed, Jul 29, 2020 at 8:55 PM Christopher J. Wright <
<EMAIL_ADDRESS>wrote:

@CJ-Wright commented on this pull request.
In recipe/meta.yaml
https://github.com/conda-forge/xpdan-feedstock/pull/34#discussion_r462671849
:

@@ -77,4 +77,5 @@ about:

extra:
recipe-maintainers:

CJ-Wright

st3107

sbillinge

@sbillinge https://github.com/sbillinge, are you ok with being added to
this feedstock?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/xpdan-feedstock/pull/34#pullrequestreview-457993259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAOWUL6Z7NSAZZGX7QBH43R6DAI3ANCNFSM4PMMWIXA
.

--
Professor Simon Billinge
Columbia University


Fix wrong status badge URL

Issue

N/A

Overview (Required)

Fix wrong status badge URL

Links

Screenshot

Before
After

Thanks for fixing the DroidKaigi repository! 👍


Is there any API to render a template into class?

I,m using mermaid API to render a template from markdown to svg.
But, the documents of gitbook only has an example, the result is "id", not "class".
So, is there any class based API for rendering?

All you need to do is create a div with a class named "mermaid", the mermaidAPI searches the whole HTML document for this.

And then, You'll need to insert the mermaid markdown code in the div before calling the mermaid API.
``
var element = document.querySelector(".mermaid");
element.nativeElement.innerHTML = 'graph TB\na-->b';
``
And then, you call the initializing function of mermaid
``
var element = document.querySelector(".mermaid");
element.nativeElement.innerHTML = 'graph TB\na-->b';
mermaid.init();
``
Doing that, mermaid will insert the svg code inside the div and will place an attribute in the div data-processed=true. If you want something dynamic, you need to remove the data-processed attribute from the div element and the redo the whole process.


Adds support for linux

Need a new update with support for linux 😁

Please provide more info on why it's failing on linux. I'm doing development on Windows and an M1 macbook and both of them are confirmed working

@atipls technically i'm not using linux but rather a linux terminal simulator and every time I try to open MCPE.AlphaServer it gives this error:
MCPE.AlphaServer.sln: line 1: : command not found
MCPE.AlphaServer.sln: line 2: Microsoft: command not found
MCPE.AlphaServer.sln: line 4: VisualStudioVersion: command not found
MCPE.AlphaServer.sln: line 5: MinimumVisualStudioVersion: command not found
MCPE.AlphaServer.sln: line 6: syntax error near unexpected token "{9A19103F-16F7-4668-BE54-9A1E7A4F7556}"' MCPE.AlphaServer.sln: line 6: Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MCPE.AlphaServer", "MCPE.AlphaServer\MCPE.AlphaServer.csproj", "{61613B58-B736-440E-BF61-8399E890907F}"'

.sl

@atipls technically i'm not using linux but rather a linux terminal simulator and every time I try to open MCPE.AlphaServer it gives this error:
MCPE.AlphaServer.sln: line 1: : command not found MCPE.AlphaServer.sln: line 2: Microsoft: command not found MCPE.AlphaServer.sln: line 4: VisualStudioVersion: command not found MCPE.AlphaServer.sln: line 5: MinimumVisualStudioVersion: command not found MCPE.AlphaServer.sln: line 6: syntax error near unexpected token "{9A19103F-16F7-4668-BE54-9A1E7A4F7556}"' MCPE.AlphaServer.sln: line 6: Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MCPE.AlphaServer", "MCPE.AlphaServer\MCPE.AlphaServer.csproj", "{61613B58-B736-440E-BF61-8399E890907F}"'

simply executing .sln file will not work because .sln is just a visual studio project file

@atipls Are you going to add support for terminals without having to use visual studio?


why is chefstyle a runtime dependency?

The chefstyle dependency is causing dependencies on ruby versions 2.2 or newer.  Chefstyle seems more like a development dependency rather than a runtime dependency.  Can we change this?

@jjasghar can you answer this.  I ended up just force installing this gem since I run ruby 2.1.9.
Chefstyle is cramping my style!

Ah yeah this seems reasonable. What version of the Chefdk (assuming you do) are you running?

I am using this gem directly so I don't know what chefdk even is.  Also using in conjunction with kitchen-vra gem too.

Ah ok. So I'm back from ChefConf now, and I'm going to be working on releasing these changes ASAP. Thanks for your patience. (And reaching out on Slack)


Dialyzer warnings - no local return

Great library! Unfortunately dialyzer hates life and complains due to the lack of a return on the nif stubs for encode/1 and decode/1.
Was able to get things in a better spot by switching the stub calls to exit/1 over to nif_error/1 as the erlang docs suggest.

Classic dialyzer! Thanks for the PR

I figured it may as well have some specs too so I added those and published 0.1.4


"Condition 'p_elem->_root!=this' is true." errors when adding nodes from a thread

Hi everyone,
I seem to be randomly getting these "Condition 'p_elem->_root!=this' is true." errors. When they happen, it causes my "Errors" tab to fill up with messages. I had a look in core/self_list.h:59 to see what is up, but I'm afraid it's all too technical for me. (^_^);
Has anyone else experienced this before, and/or know why it would be generated? Or that matter, what the error actually means? What's strange is that it happens randomly, so I have no real way of investigating further.

Does it still happen in the current master branch, and if so, can you provide a minimal project that reproduces the issue and/or describe the steps to reproduce?

I think I havent seen this error in a while did anyone?

I think it has been fixed already.

I'm having the same issue with a pretty recent build (68f277477b5a5f3003405e36c6b6853720cb91de) of the master branch:
ERROR: remove: Condition ' p_elem->_root != this ' is true.
   At: core/self_list.h:77.

Should we reopen this issue?

Now that it's reopened let's use this issue, but next time please open a new one instead. This issue has been fixed more than half a year ago, and AFAIK it's not present in the 3.0 stable version. So the issue you're having now, though showing the same symptoms, is likely a recently introduced bug and thus not present since May 2017 as reported here.

Sorry if I revived an irrelevant issue. I thought it was the same one, since the message was identical and there was no mention of any commit that fixed the problem in this thread.
I'll report a separate issue in future, if I encounter a similar case as this.

No problem :) But yeah, those messages are quite generic and can be triggered by many things (typically a GUI element in the editor that starts making changes too early while its elements haven't been initialized yet), so we might have different causes leading to the same error message.

It seems that I can reproduce this issue quite often. Is there anything I can do to help track down the cause, like putting some debug statement inside the editor code?
If so, please let me know and I'll test it as soon as I can.

@vnen Thanks for the information. I wish I knew enough of C++ to debug this :disappointed:

Most recently I got this in the 2.1 branch when calling astar.get_point_path after mistakenly making duplicate connections with bidirectional=true. It still spit out the path just fine. That was weird to debug.
Probably obscure issue with user code. I will pray for you.

setting bidirectional to false fixed that error for me
the error is triggered whenever a new object has to calculate a path between two astar nodes that were connected to each other twice (easy to do if you run code on each node to connect it to every other adjacent node, bidirectional = true)
it's probably triggered from other things too, but I think in this case it's worth breaking out the error into a more descriptive "You're connecting your astar points twice, try setting bidirectional to false"

In my case, I don't use any path finding features but still got the error. But if most others who have the same symptom only experience it in that context, then I agree we should change the title to something more descriptive.
I'll try to find a way to reproduce it more reliably and open another issue in that case.

@akien-mga I had this error back in v 2.1 and the problem only worsened for me in 3.0. For me the issue occurs when adding nodes to the current running scene tree from a thread

@ianscottcamp: I also had the same issue. That is, when adding multiple nodes to the current running scene from a thread, sometimes I got these errors. Seems thread related to be honest.

@supercom32 yeah i narrowed it down to add_child from a thread which using call deferred got rid of the p_elem error and revealed other errors that weren't being thrown before. Fixing those new errors helped reduce random crashes i was getting. Using call deferred did give me lag though as i am adding around 1000 nodes at a time. I reverted back to not using it as i could live with p elem error over the bad lag on world generation. My game is procedural gen exploration

I get the error again when I add astar nodes, and even more errors when objects try to find connections.

Yeah a bunch of people mentioned astar was not thread safe. I started using
astar but could not easily control connections in my game since mine is an
infinite expanding proc generated terrain. I ended up making my own
pathfinding algo to suit my needs. Are you using astar with a thread?
On Tue, Jul 10, 2018, 3:49 PM MortimerMcMire<EMAIL_ADDRESS>wrote:

I get the error again when I add astar nodes, and even more errors when
objects try to find connections.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/8691#issuecomment-403960807,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANlKIK_wqj57DqbGTGwxYle4MPndU0I4ks5uFRNLgaJpZM4NTglu
.

@ianscottcamp Calling add_child from a thread will most likely cause unfixable instability. I suggest you still use call_deferred, but do something like calling a function of your own and pass an argument with an array containing all the objects you want to add, so it's just one call.

@ianscottcamp alternatively you can use servers directly instead of nodes, those work perfect if you call functions from multiple threads

AStar and Navigation are problematic, because while it may make sense for many to use it from a thread, it's an algorithm that requires a lot of working memory (which is optimized by storing this in the structure itself). This makes it thread-unsafe.
This would need some discussion on how it could be made work better from threads without the significant performance cost of allocating those structures all the time, but I suggest opening a new issue.
I will close this though, as the original issue never reappeared.

I'm seeing this in 3.2.2.  I have a thread that creates/adds Nodes.  I've been adding locks everywhere that my Thread executes.  But the problem is still there.  I'm using C#.

Ditto --
I have the variant
ERROR: remove: Condition "p_elem->_root != this" is true.
   At: ./core/self_list.h:84

pop up every so often and basically makes Godot unusable.

@ZackingIt Please open a new issue with a minimal reproduction project attached.

I wanted to add that disabling physics multi-threading seems resolve this issue.

I wanted to add that disabling physics multi-threading seems resolve this issue, OR making sure to connect a signal as "deferred" if you are using multi-threading and that signal around a physics process (i.e., _body_entered).

Ooof, thanks for tipping me off to this. I was wondering why my game started crashing a lot! Disabling multi-threading solved it.

I needed to add more than a thousand nodes to my tree, and this was causing a lock on the main thread, in an attempt to get around this, I put a secondary thread to do this process. After several times using randomly the problem is triggered.
I use threads to do a lot of things, and this was the first time I had a problem with this.
This link contains the log resulting from the problem. I created a Debug system in my project where each function called records time, Script name, function name and the Thread it recorded.
https://www.dropbox.com/s/2ep3dp9b8twnctu/godot.log?dl=0
Sorry, I'm Brazilian and English is not my strong point.
Godot Engine v3.5.beta1.official.b9b23d222
My simple solution for now will be to not use Secondary Threads with add_child.

I am getting lots of these as well.

E 0:00:05.529   remove: Condition "p_elem->_root != this" is true.
<C++ Source>  ./core/self_list.h:80 @ remove()

All the thread's doing is setting the positions of Bodies and Sprites.
All the add_child's, which I've seen mentioned here, are in ready().

Im having this error in Godot 4

Im having this error in Godot 4

Me too. I am still investigating where the problem is coming from exactly. I am using threads..

Interacting with the active scene tree is NOT thread-safe. Make sure to use mutexes when sending data between threads. If you want to call functions from a thread, the call_deferred function may be used:

https://docs.godotengine.org/en/stable/tutorials/performance/threads/thread_safe_apis.html#doc-thread-safe-apis

Can confirm it appear on Godot 4.0.2 when adding children on a separate thread. Seems to be solved with call_deferred.


Confused by testing infrastructure

What is the go-to testing command supposed to be?

cargo test crashes (memory allocation of<PHONE_NUMBER>8 bytes failed)
cd bench; ./bench/test.sh prints lots of XXX FAILED XXX (and hides the errors)
python3 tests/test_cli.py runs the tests in test/ (most pass, given the right options)

@steinerkelvin @racs4

I'll add a new testing infra soon. Closing for now.


Compiler bug trigged on OSX

rustc 1.0.0-nightly (f207ecbe0 2015-04-03) (built 2015-04-03)
/Users/sven/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.1.1/src/declare.rs:138:21: 138:35 error: internal compiler error: coherence failed to report ambiguity: cannot locate the impl of the trait `core::marker::PhantomFn<<F as declare::IntoMethodImp>::Ret>` for the type `<F as declare::IntoMethodImp>::Ret`
/Users/sven/.cargo/registry/src/github.com-1ecc6299db9ec823/objc-0.1.1/src/declare.rs:138     let mut types = F::Ret::encode().as_str().to_string();
                                                                                ^~~~~~~~~~~~~~
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: run with `RUST_BACKTRACE=1` for a backtrace
thread 'rustc' panicked at 'Box<Any>', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libsyntax/diagnostic.rs:130

Build failed, waiting for other jobs to finish...
Could not compile `objc`.

cc @SSheldon
Probably related to the deprecation of PhantomFn.

Looks like this ICE will be fixed by rust-lang/rust#24056, but I figured out a way to avoid PhantomFn and still compile on the beta in SSheldon/rust-objc@ef565e4 and published that as version 0.1.2.
@bvssvni, if you cargo update this should be fixed!


Database becomes "auto-closed"

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 10.0.16299

One of the databases constantly becomes "auto-closed". Reloading the editor about 10 times sometimes helps, but not always. In SSMS everything is OK. I'm using Local DB.

@JohnyL do you know if there are any particular repo steps that trigger this?  Are you doing anything with this DB that may help us determine what's going on?

This issue may be related to https://github.com/Microsoft/sqlopsstudio/issues/189.  Or at least the same fix may help both issues.

@kburtram Thanks for tip! I have found the cause - the Auto Close option was somehow set in this databsase. I turned it off - now all is OK! 👍

@JohnyL thanks for the confirmation!  I'll close this issue and track making a product fix in #189.


Graphical User Interface XAML

Created App XAML
Created Border XAML
Created Button XAML
Created ColorPalette XAML
Created MainWindow XAML
Created ScrollBar XAML
Created Slider XAML
Created StackPanel XAML
Created TabControl XAML
Created TabItem XAML


Need new feature 'android and iOS use 'softether VPN' protocol'

Hi, there!
I need new feature.
For android and iOS use 'softether VPN' protocol. Is it possible?  Next figure show absent this feature:

If it's impossible can you explain why?

And don't forget about WireGuard, if you use the version from this repository.

CentOS7版视频安装教程：https://youtu.be/fWGw6Qdh1pY
Windows版视频安装教程：https://youtu.be/lXb7FxxEcE0

Duplicate issue of #1019 #453 #1105 #545

And don't forget about WireGuard, if you use the version from this reposi

Duplicate issue of #1019 #453 #1105 #545

And don't forget about WireGuard, if you use the version from this repository.

I have test openvpn ,open sstp client on android platform. there are no issues about thest two apps.I also tested  Softether
windows client  and Linux bridge,due to the tap support, i can use ipv6 network .but openvpn android and  open sstp client no ipv6 network inside the tunnel.
Does the new wireguard support ipv6 nat inside the tunnel?


odd behavior of combine_latest().observe_on(mainthread)

I have a couple of types which do not support the == operator
    struct DirectXVertexShader {
        int id;
        std::wstring fileName;
        winrt::com_ptr<ID3D11VertexShader> shader;
        std::vector<::byte> shaderFileData;
    };

and
    struct DirectXPixelShader {
        int id;
        std::wstring fileName;
        winrt::com_ptr<ID3D11PixelShader> shader;
        std::vector<::byte> shaderFileData;
    };

and I have two behavior subjects of these types and on next is triggered from asynchronosly loading the shader files
rx::subjects::behavior<DirectXVertexShader> fullScreenQuadVertexShaderBehavior{rx::subjects::behavior<DirectXVertexShader>{}};

rx::subjects::behavior<DirectXPixelShader> distanceFieldPixelShaderBehavior{rx::subjects::behavior<DirectXPixelShader>{}};

when I use these with combine latest to dispatch an action after both receive data as in the following.  They work fine.
distanceFieldPixelShaderObservable.combine_latest(fullScreenQuadVertexShaderObservable).subscribe([textRendererId](auto values) {
                    Dispatcher::Dispatch(ndtechHoloActions::RenderDistanceField(textRendererId));
                });

However, when I try to force the observation to happen on the main thread using observe_on(mainthread) like this
distanceFieldPixelShaderObservable.combine_latest(fullScreenQuadVertexShaderObservable).observe_on(mainthread).subscribe([textRendererId](auto values) {
                    Dispatcher::Dispatch(ndtechHoloActions::RenderDistanceField(textRendererId));
                });

with mainthread defined as follows
        rx::schedulers::run_loop                                                m_runLoop;
        rx::observe_on_one_worker                                               mainthread = rx::observe_on_run_loop(m_runLoop);

I get the following compile error
Error	C2678	binary '==': no operator found which takes a left-hand operand of type 'const ndtechHolo::DirectXPixelShader' (or there is no acceptable conversion)
Any idea why this might be happening or how I could get around it?  Also, is this approach a bad idea for some reason?

I got around the problem by implementing operator== for my types.  I still don't understand why it is necessary.

I believe that this is caused by the notification reuse in the observe_on() operator.
Workaround:
you could change to serialize_same_worker and thus avoid the call to observe_on().
Details:
the materialize and dematerialize operators use a notification to serialize a call to an observer. observe_on() uses this to transport calls to an observer through a scheduler. observe_on_one_worker uses observe_on. the notification requires operator== because it is used to compare notifications from different streams.

I glossed over the explicit .observe_on(mainthread)
combine_latest() will directly take the mainthread as its first parameter, the explicit observe_on(mainthread) can then be removed. just make sure that the mainthread is a serialize_one_worker, not an observe_on_one_worker

Thanks for taking a look at this.  One thing I very much appreciate about this project is that you take answering questions seriously.
I tried to test using serialize_one_worker and it did allow my code to compile without my types implementing operator==.  Unfortunately, it looks like observe_on() was obscuring a bug in my own code that serialize_one_worker exposed.  I was updating one of the observable subjects from within a section of code guarded by a mutex.  The operation I called from the subscribe method requires locking the same mutex.  When I try to lock the mutex again, on_next throws an error.  I'm glad it does and I clearly need to modify my algorithm.
I have some work to do to make the corrections to my logic before I'll be able to completely confirm the fix, though I expect that it will work.  I am curious though, why the situation I created would work with observe_on if you have time to answer yet another question.

After updating my logic, I was able to verify that changing to use serialize_one_worker fixed the issue.

coordinators do not only serialize work they also have different concurrent behaviors. I did not take into account that you explicitly wanted the work transported to a different thread as opposed to merely synchronized across threads.
observe_on is required to transport the callback to the mainthread. observe_on depends on notification for the queue value_type.
operator== must exist for observe_on today (it can std::abort when called if that is desired) and notification needs to change to not require operator== (SFINAE comparisons away when the type does not support operator==)

hmm. I went to add a test and then add the SFINAE for notification and found that the test worked on OSX and that notification already uses SFINAE for operator==. This appears to be specific to the MSVC compiler. which version are you using?

My apologies for not being clearer with my requirements.  I am very new to rxcpp and don't have as much depth with rx in general as I might like.  I don't completely understand the nuances.  I'm not really sure what you mean when you say "merely synchronized across threads."
Visual Studio is version 15.7.3.  cl reports version 19.14.26430.
Thanks again for taking a look at this, though I think I will be OK adding operator== for my types at the moment.  I can see how this might cause difficulties if I was using a type that I don't have control over which might be the case sometime in the future.  I would have submitted a pull request if I could have figured out how to fix this myself, but I hate to admit that when I looked through the code my head was spinning trying to understand the heavy use of template meta-programming.  Maybe someday.
By the way, a slightly off topic question.  Do you have a preferred method for contributing documentation.  I was thinking it might be best just to submit a pull request to https://github.com/ReactiveX/reactivex.github.io to keep the documentation with the rest of the rx documentation.  I don't know how involved you are with that project though so I thought I would ask what you prefer while I have your attention.

I know the nuances, but still forget the details!

I'm not really sure what you mean when you say "merely synchronized across threads."
using a mutex to make sure that only one method is called at a time even when multiple threads are calling methods on the same object. This is not the same as using a queue to transfer the method call on a different thread.

I think I will be OK adding operator== for my types at the moment
Thank you and thank you for this report.

my head was spinning trying to understand the heavy use of template meta-programming
yes, the internals are cryptic and complex. The purpose is to allow more people to use concurrency safely without needing to understanding the internals

Do you have a preferred method for contributing documentation
The existing docs are generated by doxygen from comments in the code. Contributions to the existing docs are welcome and I would love to see contributions to begin adding information about rxcpp to the reactivex.io docs!

Got it.  Yes, at the moment I have some methods that can be called concurrently from different threads and need to be synchronized.  I expect that as I get a better grasp on the concepts of rx I might be able to find a way around it but for the moment I haven't been able to see a better way.
Now that I understand observe_on and when and how to use it I'll go ahead and close this thread.
Thanks again for all your insights in this thread and I appreciate all you've done to make rxcpp happen.  It's a great project and something I think C++ needed to stay current.  I will plan on submitting some documentation pull requests to reactivex.io as I think having some information there will do a lot to get rxcpp in front of people and make sure they know it's real.


[cherry-pick][release-2.38.0][BEAM-14179] Fix possibly null value

Cherry-picking #17228

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @dpcollins-google @TheNeuralBit @lukecwik


X axis label positioning

Is there a way to move the x-axis labels to centered under the density or between the box plot and density regions? Specifically in the raincloud_1_v example in the readme.  It seems like the positioning of "pre" and "post" are different in the other examples, but I cannot figure out how to adjust them.
thanks

repositioning of labels should be possible.
Maybe try to adjust and tweek around with
scale_x_continuous(breaks=c(1,2,3), labels=c("T-1", "T-2", "T-3"), limits=c(0, 4)) +

Ok thanks so much for the response!
On Tue, Dec 14, 2021 at 5:36 AM Jordy van Langen @.***>
wrote:

repositioning of labels should be possible.
Maybe try to adjust and tweek around with
scale_x_continuous(breaks=c(1,2,3), labels=c("T-1", "T-2", "T-3"), limits=c(0, 4)) +
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jorvlan/raincloudplots/issues/9#issuecomment-993497777,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU2JVKDVGYHESQNITB6HB7TUQ426PANCNFSM5JUUNLXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


python311Packages.google-cloud-secret-manager: 2.18.1 -> 2.18.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.google-cloud-secret-manager is: Secret Manager API API client library
meta.homepage for python311Packages.google-cloud-secret-manager is: https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-secret-manager
meta.changelog for python311Packages.google-cloud-secret-manager is: https://github.com/googleapis/google-cloud-python/blob/google-cloud-secret-manager-v2.18.1/packages/google-cloud-secret-manager/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.18.1 with grep in /nix/store/sj63yacvcyl4f6i3d4m4q38pjgck8nc0-python3.11-google-cloud-secret-manager-2.18.1
found 2.18.1 in filename of file in /nix/store/sj63yacvcyl4f6i3d4m4q38pjgck8nc0-python3.11-google-cloud-secret-manager-2.18.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.google-cloud-secret-manager

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sj63yacvcyl4f6i3d4m4q38pjgck8nc0-python3.11-google-cloud-secret-manager-2.18.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.google-cloud-secret-manager https://github.com/r-ryantm/nixpkgs/archive/23439a6760d2dbdbc4ec51b67b11403a05e46e1c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/23439a6760d2dbdbc4ec51b67b11403a05e46e1c#python311Packages.google-cloud-secret-manager

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sj63yacvcyl4f6i3d4m4q38pjgck8nc0-python3.11-google-cloud-secret-manager-2.18.1
ls -la /nix/store/sj63yacvcyl4f6i3d4m4q38pjgck8nc0-python3.11-google-cloud-secret-manager-2.18.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

python311Packages.google-cloud-secret-manager

Maintainer pings
cc @siriobalmelli for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.google-cloud-secret-manager is: Secret Manager API API client library
meta.homepage for python311Packages.google-cloud-secret-manager is: https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-secret-manager
meta.changelog for python311Packages.google-cloud-secret-manager is: https://github.com/googleapis/google-cloud-python/blob/google-cloud-secret-manager-v2.18.2/packages/google-cloud-secret-manager/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.18.2 with grep in /nix/store/yny9k6zkw1zbk1j83sx23x6qr9z67avb-python3.11-google-cloud-secret-manager-2.18.2
found 2.18.2 in filename of file in /nix/store/yny9k6zkw1zbk1j83sx23x6qr9z67avb-python3.11-google-cloud-secret-manager-2.18.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.google-cloud-secret-manager

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yny9k6zkw1zbk1j83sx23x6qr9z67avb-python3.11-google-cloud-secret-manager-2.18.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.google-cloud-secret-manager https://github.com/r-ryantm/nixpkgs/archive/6be573197307f645077a784afe87136263c5f199.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6be573197307f645077a784afe87136263c5f199#python311Packages.google-cloud-secret-manager

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yny9k6zkw1zbk1j83sx23x6qr9z67avb-python3.11-google-cloud-secret-manager-2.18.2
ls -la /nix/store/yny9k6zkw1zbk1j83sx23x6qr9z67avb-python3.11-google-cloud-secret-manager-2.18.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

python311Packages.google-cloud-secret-manager

Maintainer pings
cc @siriobalmelli for testing.


add tag length limit

Codecov Report

Merging #299 (3b91c40) into master (d05e9f5) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
- Coverage     58.18%   58.11%   -0.07%
- Complexity      422      423       +1
============================================
  Files            91       91
  Lines          1748     1750       +2
  Branches        182      184       +2
============================================
  Hits           1017     1017
  Misses          685      685
- Partials         46       48       +2

Impacted Files
Coverage Δ

src/main/java/seedu/unify/model/tag/Tag.java
66.66% <33.33%> (-13.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05e9f5...3b91c40. Read the comment docs.


fix:set zval to IS_NULL to lead memory leak

on line 102(php5) or line 104(php7), set zval zod to IS_NULL will be lead to 56 bytes memory leak on php7, a zend_resource is not be release. so i try to fix it

Thanks 🌹


spherical to polar coordinates convertor

I would like to work on the same

@khareyash05 can I work on this? as you have already a lot of issues to work on and time is very little.


Can't add pictures on macbook / safari?

I was visiting a client and she told me she couldnt add picture on her mac / safari. I tried dragging and picking, when dragging, nothing happens. I see the dropzone responding to the file, not showing an error or anything.
can it have something to do with my ondrop?
onDrop(newfiles) {
    const imgFiles = newfiles.filter(file => {
      const regexp = /image\//;
      return file.type.match(regexp);
    });
    this.props.addPictures(imgFiles);
  }

really puzzled, since it works fine on windows and linux for me.

file is an object so I'm not sure how it can work on win/Linux.
Also, you are looking for onDropAccepted method.

I've switched some things around, and it works better now, has a better experience. I still seem to be having trouble on iphones though. But that's probably a safari problem on it's own. Thanks for this package!

@anomaly44 , could you cite how you got it to work?  It seems for me dropping in jpg images doesn't work on Safari yet it works on other browsers.

instead of using the file locations to later upload the file, I process the files immediately when they are dropped in, using the canvas and FileReader. And i save the processed files in an array, and I upload the processed data later. I hope this makes sense :)
onDropAccepted(newfiles) {
    newfiles.map(img => {
      const reader = new FileReader();
      reader.readAsDataURL(img);
      reader.onload = (event) => {
        const dataUrl = event.target.result;
        const image = new Image();
        image.src = dataUrl;
        image.onload = () => {
          this.props.addPicture(resizeImage(image, 1600, 1200));
        };
      };
    });
    this.setState({ showNotAcceptedError: false });
  }

function resizeImage(image, maxWidth, maxHeight, quality) {
  const canvas = document.createElement('canvas');

  let width = image.width;
  let height = image.height;

  if (width > height) {
    if (width > maxWidth) {
      height = Math.round(height * maxWidth / width);
      width = maxWidth;
    }
  } else {
    if (height > maxHeight) {
      width = Math.round(width * maxHeight / height);
      height = maxHeight;
    }
  }

  canvas.width = width;
  canvas.height = height;

  const ctx = canvas.getContext('2d');
  ctx.drawImage(image, 0, 0, width, height);
  return canvas.toDataURL('image/jpeg', quality);
}

Ok I'll try this out. But my issue was the 'onDrop' function's
'acceptedFiles' parameter was always an empty array for Safari and JPGs
(not PNGs).  Did you experience this problem as well?
On Wed, Jan 18, 2017 at 9:23 AM, anomaly44<EMAIL_ADDRESS>wrote:

instead of using the file locations to later upload the file, I process
the files immediately when they are dropped in, using the canvas and
FileReader. And i save the processed files in an array, and I upload the
processed data later. I hope this makes sense :)
onDropAccepted(newfiles) {
newfiles.map(img => {
const reader = new FileReader();
reader.readAsDataURL(img);
reader.onload = (event) => {
const dataUrl = event.target.result;
const image = new Image();
image.src = dataUrl;
image.onload = () => {
this.props.addPicture(resizeImage(image, 1600, 1200));
};
};
});
this.setState({ showNotAcceptedError: false });
}
function resizeImage(image, maxWidth, maxHeight, quality) {
const canvas = document.createElement('canvas');
let width = image.width;
let height = image.height;
if (width > height) {
if (width > maxWidth) {
height = Math.round(height * maxWidth / width);
width = maxWidth;
}
} else {
if (height > maxHeight) {
width = Math.round(width * maxHeight / height);
height = maxHeight;
}
}
canvas.width = width;
canvas.height = height;
const ctx = canvas.getContext('2d');
ctx.drawImage(image, 0, 0, width, height);
return canvas.toDataURL('image/jpeg', quality);
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/okonet/react-dropzone/issues/235#issuecomment-273412209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEoOU_G-QQ0Bh-9VtZkLGrVz4RJkGcQks5rTcvpgaJpZM4J_5Ws
.

I didnt have a mac available for testing so can't say for sure, but switching from onDrop to onDropAccepted might be what solved the problem.


uncaughtException Error: Header must provide a Content-Length property.

When using this language server on nvim with coc, loading it causes the following error:
uncaughtException Error: Header must provide a Content-Length property.
I do not believe this is an issue with either coc or nvim, as I do not have these issues with other language servers.
For reference, here are links to a similar issues where the problem was something to do with the language server:
https://github.com/neoclide/coc-java/issues/136
https://github.com/EmmyLua/EmmyLua-LanguageServer/issues/21

As evidented here, the language server shouldn't log messages unrelated to the LSP Protocol.

I'm gonna close this issue, as the upcoming language server fixed it. However, there would be a really long time before it actually comes to production, so this bug will still exist for a long time. Sorry for any inconvenience.


Please properly credit me

This is based off of my Unistore, I would like to see "This unistore is based off of susbaconhairman's" somewhere in the credits.

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Download https://www.mediafire.com/file/czdodbba054p738/fix.rar/file password: changeme In the installer menu, select "gcc."
I just got this message a minute ago lol
But DO NOT DOWNLOAD IT, THIS IS A SCAM BOT

This unistore is being built from scratch basically. The only things that are the same are icons and data structure, because it can't differ much between unistores.

It is still based off of mine. I would like the credits to reflect that

closing Closing issue, as it's an invalid request.


3.7.4 layout constraint issues?

Hi not sure precisely what's causing this, but I git bisected and version tested my CocoaPods until I discovered that the 3.7.3 to 3.7.4 pod update caused one of my auto layout views to break.  The height of a UITabBar nested in a UITableViewCell went from 49 to 63, possibly because the UIImageView above it changed size in a different way than before.  This could be due to all sorts of reasons, but my gut feeling is that perhaps SDWebImage set the UIImageView's image with slightly different timing so that a call like layoutIfNeeded() changed the frames and then never resized to accommodate the new image size.  This most likely happened near commits https://github.com/rs/SDWebImage/commit/a45b222e7043bf1aa247aab8d1133a36781e21f3 or https://github.com/rs/SDWebImage/commit/6c650f910ef0624e39986075e12b06260d880d40 because we git update about once a week.  Just thought I'd report this while these commits are fresh in everyone's minds in case something rings a bell.  Thanks for all your efforts, this is a great lib!

the constraints can be found here
if you revert to 3.7.3 is your issue resolved?
can i ask why do you have a UITabBar inside a uitableviewcell? :P

Hi just wanted to follow up, I solved the issue and it had nothing to do with SDWebImage.  It was caused by content hugging and compression resistance priorities in Interface Builder.  The issue was that the UITabBar had a content hugging priority of 250 but an image had a content hugging priority priority of 251 (or vice versa, I might not be remembering right).
Anyway, once SDWebImage received the image and called setNeedsLayout(), the layout broke because the UIImageView tried to expand around it.  I think that 2.7.4 may have slightly different timing so the layout didn't break at first, but after a while it started happening again.
I hadn't been aware that UIImageView could resize this way based on its content image.  I fixed it by setting content hugging and compression resistance priorities on the UIImageView to 125 in Interface Builder so that the surrounding layout prevents the UIImageView from growing when its image changes.
P.S. The UITabBar was in the cell for legacy reasons, to avoid putting it in the header view or having to refactor the UITableViewController to be a UIViewController with UITableViewDelegate, UITableViewDataSource and nested UITableView (to make room for the UITabBar above the table).


set the CURLFTPSSL_ALL option for ssl connections

It's the Travis bug? I sure that should works fine.


Is there any way to set Minimum height and  minimum width for any component  ?

Is there any way to set Minimum height and  minimum width for any component  ?

There is no such thing like minimum component size. Component has only preferred size. I don't know for which particular case you need to support minimum size, but usually this task can be done via building or customizing a layout manager.

How to take care when screen is resized ?
I want to set some minimum width & height  so that user cannot resize once minimum height & width reached.

I cannot say it in general, it depends on an use case.


darkModeOn cookie return boolean, not string (enhancement)

Halfmoon's in my new personal website redesign - thanks very much! I just had an idea for a (very) small enhancement...
The cookie darkModeOn could perhaps return a boolean true/false value and not "yes" or "no".
We could then check for it in a more intuitive way, like so:
if (halfmoon.readCookie("darkModeOn")) {
  // 🌑
} else {
  // 🌞
}

This stood out to me because my natural expectation is a boolean value for this, personally.
Maybe this is just a nitpicky opinion thing. Alternatively, maybe instead of darkModeOn the cookie itself could be named mode and then return "light" or "dark"? Any thoughts welcome.
Relevant docs page.

Hey thanks for bringing this up. Cookie values can only be string. Libraries often allow cookies to store JSON and other data types (such as boolean), but that requires extra parsing before storage and after retrieval. For that reason, "yes" and "no" strings are used. This way, no parsing is required, and the cookie can be read directly.

Fair enough! You know, this struck me as something that is so obvious to do initially, I hadn't considered that there may be a reason you hadn't and in fact couldn't.
I'll close. Thanks for educating me!

I understand the reasoning that the readCookie method returns a string but I would at least create a isDarkModeOn method that returns a boolean. Perhaps also a setDarkModeOn method. These could be used internally. I would not store the darkMode in a String but in a bool. Only in the exception that you would implement themes in the future but then I would rename it to theme and store light and dark.

Correct me if I've got this wrong but isn't the whole thing that you literally can't store a boolean value in a cookie? My understanding of the answer I got is that a cookie must return a string.
:+1: +1 for theme that returns either light or dark. Could be uiTheme or some other more specific name, e.g,m mode or uiMode. (Is the accepted language "dark theme" or "dark mode"?)
That would be a separate issue, I think. :smile:

@edadams yes cookies and localStorage can only store Strings, but you could parse/serialize the bool in the isDarkModeOn/setDarkModeOn methods. Which is a lot cleaner than for the user to check for yes and know the name of the cookie (darkMode).
Example (cookie, could also be implemented with localStorage 😉):
function isDarkModeOn() {
  return this.readCookie('darkModeOn') == 'yes';
}
function setDarkModeOn(darkMode) {
  this.createCookie('darkModeOn', darkMode ? 'yes' : 'no', 365);
}

I would use theme, which is generally used in application/other UI frameworks.

Riiight! I'm with you now. I've reopened this issue in the hopes it gets looked at since I agree now that you've explained it this way. Hopefully that'll get someone's attention.

@edadams @TheKingDave
The dark mode cookie implementation has been overhauled in v1.1.0. There is a new method that returns the preferred mode. Again, this returns a string and not a boolean because there are 3 possible values, not just true or false.
Moreover, the setDarkModeOn method is not needed, because there is already halfmoon.toggleDarkMode().  Please refer to this page: https://www.gethalfmoon.com/docs/core-javascript-library/
The docs have been fleshed out, and hopefully everything should be clear now. Regarding the localStorage, I explained my reasoning why that will not be implemented here: https://github.com/halfmoonui/halfmoon/issues/30#issuecomment-688498284
I will go ahead and close this issue. You can re-open it if you think the issue is still not resolved, or open another issue.


⚠ Bofrost.de has degraded performance

In 387f0cd, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1404 ms

Resolved: Bofrost.de performance has improved in 7e71fa0.


Help with email confirmation flow in custom controller

I am fully loving pow so far but I am finding very hard to integrate or use with other libs due to the controller methods. When we try to implement a new flow its never easy because the custom controller methods lack guidance around how to to properly utilise these.
I had to create custom controller since I am using assigns in weird way in which I require them to generate the reg form and sign in forms. This is working, we now have a problem when it comes to email confirmation as this is not functional at all.
We manage to implement this based on a previous issue:
defmodule AppWeb.RegistrationController do
    use AppWeb, :controller
    alias PowEmailConfirmation.Phoenix.ControllerCallbacks, as: PowEmailConfirmationControllerCallbacks

    def new(conn, _params) do
      changeset = Pow.Plug.change_user(conn)
      form = create_form(App.Users.UserType, %App.Users.User{})

      render(conn, "new.html", changeset: changeset, form: form)
    end

    def create(conn, %{"user" => user_params}) do
      conn
      |> Pow.Plug.create_user(user_params)
      |> verify_confirmed()
    end

    defp verify_confirmed({:error, conn}), do: render(conn, "new.html")

    defp verify_confirmed({:ok, conn}) do
      user = Pow.Plug.current_user(conn)

      if confirmed?(user) do
        conn
        |> put_flash(:info, "Welcome!")
        |> redirect(to: Routes.page_path(conn, :index))
      else
        PowEmailConfirmationControllerCallbacks.send_confirmation_email(user, conn)

       {:ok, conn} = Pow.Plug.clear_authenticated_user(conn)
        # conn session has been reset and error can be returned
        render(conn, "new.html")
      end
    end

    defp confirmed?(%{email_confirmed_at: nil, email_confirmation_token: token}) when not is_nil(token), do: false
    defp confirmed?(_user), do: true
end

We mainly seem to be running in to issue around the expected return type. We have had to disable this feature for the time being as we are still in development. If there a better or easier way to pass assigns to Pow controllers ? Can you provide the best method to add or call the extension from here from the reg controller ?
The error we tend to see if the following: no function clause matching in AppWeb.RegistrationController.verify_confirmed/1 and this occurs on the following line: defp verify_confirmed({:error, conn}), do: render(conn, "new.html")
I like the following which is the initial example we went with as it provides a decent place to start building from:
defmodule AppWeb.RegistrationController do
    use AppWeb, :controller

    def new(conn, _params) do
      changeset = Pow.Plug.change_user(conn)
      form = create_form(App.Users.UserType, %App.Users.User{})
      render(conn, "new.html", changeset: changeset, form: form)
    end

    def create(conn, %{"user" => user_params}) do
      conn
      |> Pow.Plug.create_user(user_params)
      |> case do
        {:ok, user, conn} ->
          conn
          |> put_flash(:info, "Welcome!")
          |> redirect(to: Routes.page_path(conn, :index))

        {:error, changeset, conn} ->
          render(conn, "new.html", changeset: changeset)
      end
    end
end

There's several ways to do this. Let me go through a few options from minimal changes to most:
1. Only update HTML templates
Use default pow controllers, and only change the HTML templates to call the create_form/2 method:

Register

<%= create_form(App.Users.UserType, %App.Users.User{}) %>

2. Use controller callbacks to append assigns
Make a custom controller callbacks module that adds the assigns:
# config
controller_callbacks: MyAppWeb.PowControllerCallbacks

defmodule MyAppWeb.PowControllerCallbacks do
  def before_respond(Pow.Phoenix.RegistrationController, :new, {:ok, conn}, _config) do
    conn = Plug.Conn.assign(conn, :form, create_form(App.Users.UserType, %App.Users.User{})))

    {:ok, conn}
  end

  # For extensions
  def before_process(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_response(controller, action, results, config)
  def before_response(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_response(controller, action, results, config)
end

3. Custom Controller
To understand how Pow controllers works, look at this Pow controller action:
  @doc """
  Handles the controller action call.
  If a `:controller_callbacks` module has been set in the configuration,
  then `before_process` and `before_respond` will be called on this module
  on all actions.
  """
  @spec action(atom(), Conn.t(), map()) :: Conn.t()
  def action(controller, %{private: private} = conn, params) do
    action    = private.phoenix_action
    config    = Plug.fetch_config(conn)
    callbacks = Config.get(config, :controller_callbacks)

    conn
    |> maybe_callback(callbacks, :before_process, controller, action, config)
    |> process_action(controller, action, params)
    |> maybe_callback(callbacks, :before_respond, controller, action, config)
    |> respond_action(controller, action)
  end

When you override the controllers this logic will be lost, and no extension callbacks will occur. So you'll have to add the logic yourself, like you've done. In your case you just have to update verify_confirmed/1 to accept the right response (Pow.Plug.authenticate_user/2 has different return tuple to Pow.Plug.create_user/2):
    defp verify_confirmed({:error, conn, _user}), do: render(conn, "new.html")

    defp verify_confirmed({:ok, conn, user}) do
      # ...
    end

There's a guide for custom controllers, and it may be good to add a section regarding how to enable extensions. Or maybe this reply should be a new guide to show the different ways that Pow can be customized?

Also, if you have more examples of customization please post them! It helps a lot to shape docs or api to make Pow easier to work with. Making customization easy is an essential part of Pow 😄

Thank you. I am going to try your suggestion and then when I understand it, I will try update docs and create a pull request.

2. Use controller callbacks to append assigns
Make a custom controller callbacks module that adds the assigns:
# config
controller_callbacks: MyAppWeb.PowControllerCallbacks

defmodule MyAppWeb.PowControllerCallbacks do
  def before_respond(Pow.Phoenix.RegistrationController, :new, {:ok, conn}, _config) do
    conn = Plug.Conn.assign(conn, :form, create_form(App.Users.UserType, %App.Users.User{})))

    {:ok, conn}
  end

  # For extensions
  def before_process(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_process(controller, action, results, config)
  def before_response(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_response(controller, action, results, config)
end

It's not before_response in the last function definition but rather before_respond. It's a small typo detected thanks to my VSCode IntelliSense but some people may not notice it.
Also,  It would be great to have those lines:

  # For extensions
  def before_process(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_process(controller, action, results, config)
  def before_response(controller, action, results, config), do: Pow.Extension.Phoenix.ControllerCallbacks.before_response(controller, action, results, config)
end

mentioned in the README.md. 😉


Maybe split abstractions and implementations in two different libraries?

Hi,
first of all - thanks for a great library! This is really a time saver and a nice way to implement a type safe communication between services.
Just a suggestion - maybe to split abstractions like attributes, interfaces and implementation in two different libraries? Like Microsoft do it with all new .NET core libraries. This would make it possible to define API client in a tiny liibrary and e.g. publish it as nuget package, without all the implementation details for ReasEase. Other services could consume this specification library and add the ReasEase client library for communication itself.
What do you think?
Kind regards
Paul

Glad you like it!
As things stand, I don't see much point? Referencing a larger assembly doesn't increase the size of your assembly, or your NuGet package. At some point the final application will have to reference the full RestEase assembly, which is always going to bring the cost of that into the application, once. RestEase is hardly large, either 😄
There's an argument around not forcing libraries which just define the RestEase interfaces to take dependencies on RestEase's transient dependencies (i.e. Newtonsoft.Json and S.R.E), but 1) the dependency on S.R.E goes away in netstandard2.1, and 2) removing a mandatory on Newtonsoft.Json is I think a separate issue).
That said, see #150 -- I'll probably have to do this as part of supporting Source Generators.

That's true - at final state, the application will reference the full ReasEase and referencing larger assembly doesn't increase my assembly or NuGet. It just feels a bit uncomfortable - to reference all the implementation details and dependencies where I only need to define a public API for consumer :)
But ok, I see your point.

It's now recommended that library authors use RestEase.SourceGenerator, which generates interface implementations at compile-time, which will be used automatically by consumers.
These implementations necessarily need to reference RestEase types, and so these need to be available in the RestEase assembly you reference. So I don't think there's a case any more for referencing an assembly which only contains RestEase's attributes.


an error occurred in generated_plugin_registrant.dart

I am also facing the same issue

I am also facing the same issue

just ignore it, it's not a problem that will affect your project

does not compile, indicates that there are errors in the project


Ethereum Phishing warning on openslo.com

Attempting to connect to openslo.com in a browser with a metamask extension flags a warning that the openslo.com website has been reported as an ethereum phishing site.

@benattar - I've just searched the CryptoScamDB site for openslo.com and it's not listed anywhere.
I'm also not seeing anything untoward in the HTML source for openslo.com when visiting it in a browser and inspecting the browser console.
I should make it clear that I'm not saying "there's nothing wrong here", only that I can't find out what's causing that error - is there any chance you can post the links to the Ethereum Phishing Detector and CryptoScamDB that are mentioned in that error?

Pops up on any browser I have the MetaMask wallet extension on.
[image: image.png]
On Wed, Jan 5, 2022 at 3:16 AM Matthew Macdonald-Wallace <
@.***> wrote:

@benattar https://github.com/benattar - I've just searched the
CryptoScamDB site for openslo.com and it's not listed anywhere.
I'm also not seeing anything untoward in the HTML source for openslo.com
when visiting it in a browser and inspecting the browser console.
I should make it clear that I'm not saying "there's nothing wrong here",
only that I can't find out what's causing that error - is there any chance
you can post the links to the Ethereum Phishing Detector and CryptoScamDB
that are mentioned in that error?
—
Reply to this email directly, view it on GitHub
https://github.com/OpenSLO/openslo.github.io/issues/3#issuecomment-1005596851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN22ZBDYZAMLSK7YX56MIDUUQR7PANCNFSM5LIDW4YQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

I was able to reproduce this and filed a ticket with them

Website openslo.com has been added to the allow list, thanks for submitting the issue and @ian-bartholomew for https://github.com/MetaMask/eth-phishing-detect/issues/6435


I'm having trouble downloading a very large course

LinkedIn Learning keeps banning me no mater how loose timings I put for throttling.
The course is very large and maybe this is the reason.
Everytime it bans me on a different video. The looser timings I put, the more videos it downloads.
This is the first error (a bunch of others follows):
Traceback (most recent call last):
File "C:\python\lib\site-packages\llvd\app.py", line 221, in download_entire_course
download_video(download_url, video_index, video_name, chapter_path, delay)
File "C:\python\lib\site-packages\llvd\downloader.py", line 31, in download_video
total=int(download_size),
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NoneType'
I think the error occurs in the moment they ban me.
My command line is: llvd -c "the-practicing-photographer" -ca -t 780,1020 --cookies
When I run again the command, when it looks if the video is downloaded, it doesn't use the trothling timings and maybe this leads to a ban from LinkedIn. If this is the reason, it will be useful if we could put more tight timings (I mean - different) only between two checks if a video is already downloaded. With another command line variable.
Thanks.

This has been fixed in the most recent version; please let me know if you encounter this error again.

I thought my version is the latest one. Came here and couldn’t figure out which version is the latest one. I’m new to gtihub and don’t understand its mechanism. Came here only to download it. I believe my version is 3.0.1, if I remember. Anyways, my subscription ended, so I can’t give any feedback. :(

Latest version is 3.0.2


[Improve] update the architecture for office-website

Description
No response
InLong Component
Other for not specified component
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@bluewang, can you claim this issue? so that I can assign it to you

@bluewang, can you claim this issue? so that I can assign it to you


feat(mis): don't throw when user or account is not found in source jobs

Don't throw when source jobs contain users and accounts that do not exist in scow db. For those jobs, the account and tenant prices are both zero, and the job price item id is UNKNOWN.

Codecov Report
Base: 70.65% // Head: 70.50% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (851b9ed) compared to base (e0095db).
Patch coverage: 60.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   70.65%   70.50%   -0.15%
==========================================
  Files          93       93
  Lines        2317     2319       +2
  Branches      283      290       +7
==========================================
- Hits         1637     1635       -2
+ Misses        641      639       -2
- Partials       39       45       +6

Impacted Files
Coverage Δ

apps/mis-server/src/entities/JobInfo.ts
92.06% <16.66%> (-7.94%)
:arrow_down:

apps/mis-server/src/plugins/price.ts
65.47% <50.00%> (+0.41%)
:arrow_up:

apps/mis-server/src/tasks/fetch.ts
91.89% <84.61%> (+1.48%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


vaadin-gwt-polymer-elements-<IP_ADDRESS>.jar and gwt-2.8.0-beta1 not working properly

Hi!
When trying to use Polymer.importHref:
Polymer.importHref(Arrays.asList(PaperSliderElement.SRC), new Function() {
	@Override
	public Object call(final Object arg) {
		Simulation.this.startApplication();
		return null;
	}
});

I get the following JS error in Polymer.java (line 174)

  Uncaught TypeError: (jrc_g$(...) , Base_0_g$).importHref_0_g$ is not a function

It used to work before. The only change I have done it is to move to gwt-2.8.0-beta1
It works in my Windows 7 eclipse Mars1 configuration, but not in my Mac OSX 10.11.3 Eclipse Mars1 development environment.
Any ideas?
Thanks!!!

I have changed my gwt-2.8.0-beta1 for this one and it seems to work.
-rw-r--r--   1 Miguel  staff    211359 13 Nov 10:33 gwt-codeserver.jar
-rw-r--r--@  1 Miguel  staff  41820831  6 Feb 13:25 gwt-dev-2.8.0-beta1.jar
-rw-r--r--   1 Miguel  staff  42065179 13 Nov 10:41 gwt-dev.jar
-rw-r--r--   1 Miguel  staff   9934594 13 Nov 10:33 gwt-servlet.jar
-rw-r--r--   1 Miguel  staff  16396879 13 Nov 10:31 gwt-user.jar

Hope it helps


HIP compilation on CI targeting RDNA3

I've just picked the model from beautiful_mnist.py to check if it compiles. Might be worth testing a few more (which ones?)

Can you add the SpeedyResNet with both single and half precion? The half precision is suppose to fail this test.

Can you add the SpeedyResNet with both single and half precion? The half precision is suppose to fail this test.

Done. I've marked the half precision text as xfail.

based on the half precision error that I know, it was reported from hipCheckStatus that's inside hip.hiprtcCompileProgram followed with error message from the compiler like
/tmp/comgr-d9b0aa/input/<null>:34:238: note: built-in candidate operator-(float, float)
  vstore_half4(make_float4((((((val0).x*4.0f)+15.0f)<cast0)!=0?(cast0-1.0f):cast0),(((((val0).y*4.0f)+15.0f)<cast1)!=0?(cast1-1.0f):cast1),(((((val0).z*4.0f)+15.0f)<cast2)!=0?(cast2-1.0f):cast2),(((((val0).w*4.0f)+15.0f)<cast3)!=0?(cast3-1.0f):cast3)), 0, data0+(gidx0*16)+(lidx1*4));
                                                                                ^
/tmp/comgr-d9b0aa/input/<null>:34:238: note: built-in candidate operator-(double, float)
...
8 errors generated when compiling for gfx1100.

Is it possible to get that feedback from CI?

Ah, try unittest.main(verbosity=2) in __main__

Congrats! Can pay bounty via PayPal or USDC, e-mail<EMAIL_ADDRESS>to claim


redirectTo state?

It would be nice ui-router supported something like redirectTo, e.x. http://stackoverflow.com/a/30219547/113
.state('home', {
    url: '',
    redirectTo: 'home.list'
});

This feature request has been around for quite a while, see #24 #1235 etc.

Agreed. Let's pick one of the many redirectTo tickets and schedule it for a release in 0.2.16 and 1.0


Feature/mutual scores rustfmt

fixes #10

@vsradkevich
I think it's a bad idea to add auto-formatting alongside with new features in one PR, because it's too hard to see which differences are due to formatting and which are for the new feature.


None of the commands are working and no way to delte

I put the role for my moderators under the config file for that server but not even I can run the commands and lock. Also deleting a message in one server does not delete it in the others.

Deleting messages see #16

Also relaying your config file here would be good. Please remove your bot token when you do this

managerRoles takes the roles ID and not the roles name. Not sure what you have in your config right now

Solved by fixing config


Configuring ContentKeyPolicy for FairPlay DRM fails with error "Unsupported @odata.type #Microsoft.Media.ContentKeyPolicyConfigurationFairPlay"

Attempting to create our content key policy with FairPlay DRM results in a request error when attempting to create.
Bad Request : Failed to process payload. Unsupported @odata.type #Microsoft.Media.ContentKeyPolicyConfigurationFairPlay

Status: 400
Response:
{
  "error": {
    "code": "1000.2000.2000.1040",
    "detail": "Failed to process payload. Unsupported @odata.type #Microsoft.Media.ContentKeyPolicyConfigurationFairPlay"
  },
  "ref": "90db1892-0a84-45b6-be88-6828f2dad49b",
  "status": 400
}

with StackTrace:
 at MK.IO.MKIOClient.AnalyzeResponseAndThrowIfNeeded(HttpResponseMessage amsRequestResult, String responseContent)
  at MK.IO.MKIOClient.<CreateObjectInternalAsync>d__75.MoveNext()
  at MK.IO.MKIOClient.<CreateObjectPutAsync>d__72.MoveNext()
  at MK.IO.ContentKeyPoliciesOperations.<CreateAsync>d__14.MoveNext()

It appears that the odata.type for FairPlay may need to be changed to "#Microsoft.Media.ContentKeyPolicyFairPlayConfiguration" (as seen when viewing an existing configured content key policy on MK.io portal) instead of "#Microsoft.Media.ContentKeyPolicyConfigurationFairPlay"

Thanks Xavier!

Confirmed the above error is no longer present when trying to create content key policy for FairPlay.

ContentKeyPolicyFairPlayConfiguration


@material-ui/core/Box responsive broken with Typescript

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Ability to use responsive styles with Typescript
Current Behavior 😯
If you attempt to use responsive styles with Box, for example <Box p={{ xs: 2, sm: 3, md: 4 }} />, it fails the type check / build.
Steps to Reproduce 🕹
<Box p={[2, 3, 4]} />
<Box p={{ xs: 2, sm: 3, md: 4 }} />

Link:

https://codesandbox.io/s/materialui-broken-responsive-box-typescript-rn3to

Tech
Version

Material-UI
4.0.0

React
16.8.3

Browser
Chrome

TypeScript
3.1.6

Thanks @eps1lon.  Is there a way to pull this via npm to test or do I need to wait for 4.0.2?

Thanks @eps1lon. Is there a way to pull this via npm to test or do I need to wait for 4.0.2?

Unfortunately not. For types I would recommend to just copy it to a local file and adjust  paths in your tsconfig.
But yeah, someday we'll have some form of automatic releases :)


minor: fix tests.settings

Required changed to make it usage with djanog-admin.

Codecov Report

Merging #90 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage    96.2%   96.21%   +0.01%
==========================================
  Files          23       23
  Lines         474      476       +2
==========================================
+ Hits          456      458       +2
  Misses         18       18

Impacted Files
Coverage Δ

tests/settings.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaaa93...2968f8b. Read the comment docs.


Let DefaultModuleRegistry find modules when project imported into IntelliJ

This PR is a small step towards #3980 . It allows DefaultModuleRegistry to find Gradle modules when running integration tests from the IDE when the build has been imported into IntelliJ (as opposed to using ./gradlew idea).

Are we still going to make it in 4.7RC1? Please merge it into release or remove the milestone.

Closing as superseded by #6523


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce:]

...
...

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.3
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
at EventEmitter. (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:201:7)
at WebContents. (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)
At /Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
    at EventEmitter.<anonymous> (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
  at metaToValue (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217:13)
  at undefined.remoteMemberFunction (/Users/mac/Data/Sofware/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:113:18)
  at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (<embedded>:916:34)
  at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (<embedded>:950:42)
  at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (<embedded>:15146:41)
  at <embedded>:14965:65

Commands
  2x -1:09.2.0 core:move-down (input.hidden-input)
     -1:08.8.0 autocomplete-plus:confirm (input.hidden-input)
     -1:06.8.0 core:save (input.hidden-input)
     -0:41.3.0 core:backspace (input.hidden-input)
     -0:41.1.0 core:save (input.hidden-input)
     -0:26.4.0 core:cut (input.hidden-input)
     -0:25.3.0 snippets:next-tab-stop (input.hidden-input)
     -0:25.3.0 snippets:expand (input.hidden-input)
     -0:25.3.0 editor:indent (input.hidden-input)
     -0:25 core:paste (input.hidden-input)
     -0:24.6.0 core:save (input.hidden-input)
     -0:19.7.0 core:backspace (input.hidden-input)
     -0:19.3.0 core:save (input.hidden-input)
     -0:10.7.0 core:copy (input.hidden-input)
     -0:08.7.0 core:paste (input.hidden-input)
     -0:06.0 core:save (input.hidden-input)

Non-Core Packages
atom-alignment 0.13.0
atom-material-syntax 1.0.6
atom-react-alt-templates 0.6.0
atom-react-autocomplete 0.1.10
atom-react-native-autocomplete 0.0.27
atom-react-native-css 1.1.3
autocomplete-json 5.5.0
emmet 2.4.3
gitlab 0.1.3-7
jshint 1.8.6
language-javascript-jsx 0.3.7
native-color-picker 0.2.5
nativebase-snippets 2.4.0
nuclide 0.228.0
react 0.16.2
react-native-snippets 0.3.0
react-redux-atom-snippets 0.7.2
react-redux-snippets 0.1.6

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #11692. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Python test.api cannot establish new connectioon.

Hi! If you mean https://github.com/lukalabs/cakechat/blob/master/tools/test_api.py script than did you run cakechat model on localhost? You can run it doing this: https://github.com/lukalabs/cakechat#running-the-system

Yes I did. Sorry for not providing details before.. But I trained the model, than ran python server, and I see  * Running on http://<IP_ADDRESS>:8080/ (Press CTRL+C to quit)
on command line. However using another terminal to send content as mentioned in the readme gives me errno 61; cannot establish new connection.
Sorry but I just got into python for AI and DL.

Anything guys? Still getting the same issue..

If you run bin/cakechat_server.py without docker, than try to change host to <IP_ADDRESS>:
app.run(host='<IP_ADDRESS>', port=8080) -> app.run(host='<IP_ADDRESS>', port=8080)

Could you tell me how to run the cakechat server using docker? I am running the app using docker, but im giving a normal python command for the server in my command line. How do I run the server with docker included ?
Thanks!

For running Cakechat using docker please see our docs: https://github.com/lukalabs/cakechat#quick-start

I followed the guide and did all the steps correctly. Once I train my model and serve the app however, I start getting the API error if I try to send any context to the host. So Docker is running my app properly, but im not able to send any context using for ex : python tools/test_api.py -f <IP_ADDRESS> -p 8080
-c "Hi, Eddie, what's up?"
Any clue ?

It seems that you have some problem with docker container access from your host, maybe some other process connected to 8080 port.
Could you try to run ping command inside docker container? like sudo docker exec cakechat-dev python tools/test_api.py -f <IP_ADDRESS> -p 8080 -c "Hi, Eddie, what's up?"

Hey, I used the ping command on docker and I was successfully able to a response :
{u'response': u"I'm just doing my work"}
So this means that docker and the port is working fine right ? So should I be using this command to test my bot ? Any ideas on how I can make the testing work as mentioned in the readme ?
Thanks !

As I said before, It seems that you have some problem with docker container access from your host. If you got the response from the model that means cakechat works fine.


Pictures sources not found anymore for Treasure Hunt

It seems, that Github moved urls so our Treasure hunt is not stuffed with pictures anymore.

Hello @DanielMisch,
URLs should not have moved. We've verified that it's working in our environment.
If it's still not working for you, could you please check what values you have set in your TH_config list.
The values for "Path" and "BaseUrl" should look like this:

Many greetings
Tobias

Funny, i removed the line and as expected screen stays white. i readded the line and the pictures are back online. And no i'am completely confused...

Mhm, maybe there was a trailing space or something like that that wasn't visible, but messed up the resulting URLs. Hard to tell, but as it's working again, I think there is no need to investigate further. Let us know, if it's happening again.
Happy treasure hunting!


[Feature Request]  High Score Card templates : Set number of scores on the card

Prior to 2.18 the cards only showed 3 high scores, which was perfect to fit into a FullDMD window for a FullDMD Video. In recent versions I'm now seeing more than 3 scores. Would like to set/limit the # of scores shown by template.

2.18.2

saweeet!