Non-Persistent Image shows #VMS in use

Description
When deploying vm's from Template > the Base Image tells #VMs in use.. which cannot be. All Vm's are non-persistent.
To Reproduce
i installed 6.4 and created Images for Iso + Datablock (used persistent yes)
i installed then OS and deleted the VM + changed Datablock to OS and persistent to no
then i changed template and deployed VM from it.
Base-Image shows then #VMS in use = 1
wheni rename the ID of the Image - the VM can still boot fine... so State is somehow wrong.
IMAGE_DS
ALLOW_ORPHANS="YES"
CLONE_TARGET="SYSTEM"
CLONE_TARGET_SSH="SYSTEM"
DISK_TYPE="FILE"
DISK_TYPE_SSH="FILE"
DRIVER="qcow2"
DS_MAD="fs"
LN_TARGET="SYSTEM"
LN_TARGET_SSH="SYSTEM"
SAFE_DIRS="/var/lib/one"
SPARSE="YES"
TM_MAD="ssh"
TM_MAD_SYSTEM="ssh"
TYPE="IMAGE_DS"
SYSTEM_DS
ALLOW_ORPHANS="YES"
CLONE_TARGET_SSH="SYSTEM"
DISK_TYPE="FILE"
DISK_TYPE_SSH="FILE"
DRIVER="qcow2"
DS_MIGRATE="YES"
LN_TARGET_SSH="SYSTEM"
SAFE_DIRS="/var/lib/one"
SHARED="NO"
SPARSE="YES"
TM_MAD="ssh"
TM_MAD_SYSTEM="ssh"
TYPE="SYSTEM_DS"
Expected behavior
Expected is that image is ONLY in us by persistent configs....    Issue with Image in use is > never possible to change image back to "persistent" to patch new security patches for new vms. non-persistent Image should be isolated/encapsulated
Details

Base Image Bug
-Alma 8.6
-Opennebula 6.4

I think this is expected behaviour :-)
The "golden" image used for the non-persistent copies is sort of locked because it is expected to be able to use for recovery purposes (like the use of recover :delete-recreate)

... Issue with Image in use is > never possible to change image back to "persistent" to patch new security patches for new vms. non-persistent Image should be isolated/encapsulated

You could use the Image save-as function to create a new image, tag it as persistent and do the updates. Then remove the persistent tag and reconfigure the VM Templates to use the new image as a "golden" image.

Re-thinking, maybe it could be an exciting feature to have an option to do "maintenance" tasks on the golden image...
So I think the OpenNebula devs could chime in :)

just looking for this "save-as" function... not finding this Function on the Gui. May i overlook it

My bad, sorry! I mean the Image -> Clone function (it is almost the same as VM disk - Save-as)

ah ok found an kinda working way

deploy VM
Patch it
disk-saveas   <img_name>
oneimage list + oneimage show xx  (to see to which file the orig image mapped)
done a copy of orig  (like a version logic)
replaced the Image long ID with orig one + deleted the new Image

(ahh image clone may even more simpler).. but need to replace ids then anyway

Aye so thinking an

Maintenance (with Copy Option for Go-Back)  would be faster to handle to avoid human typos.

Say example you want to maintain 5 Versions of an Golden-Image.
@atodorov-storpool   thx for you're Hint.. That helped me to go an little cheat way ;).
Will open kinda Feature Request for it


Update sklearnserver to also accept pickle

What this PR does / why we need it:
The current sklearnserver only accepts model dump with joblib. We have some models that are stored with pickle, so we want to extend the sklearnserver to also able to load models that are in pickle format.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

/assign @animeshsingh

/lgtm

/lgtm

/retest

Is this even necessary? Does having it named as PickleFile change the behavior? Would it be easier for this to just be a document change to make it clear that it will also accept models serialized with pickle instead of joblib?

Usually we store our pickle models with .pkl extension. Renaming it to model.joblib can make it work but it will create some confusion on filename extension.

@csteegz kfserving needs to be able to accept .pkl files for sklearn- and yes the backend will work.

alibi test failed
/retest

Looks good! Just a quick question, why is there only support for the .pkl extension?
According to the Python docs and explained in this StackOverflow question, the official file extension for Pickles in Python 3 is .pickle.
I'm open for making that possible if needed.

Hi @koenmtb1, I make the possible extensions into list and now including .joblib, .pkl, and .pickle. Let me know is there other extensions we might need for sklearn. Thanks.

/approve

/lgtm


fix(buffer): fix write area size in string_buffer

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.528%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9900

Relevant Lines:
1874282

💛  - Coveralls

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (fec457e) 98.63% compared to head (621e76f) 98.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   98.63%   98.64%
=======================================
  Files          33       33
  Lines        2783     2801   +18
=======================================
+ Hits         2745     2763   +18
  Misses         38       38

Impacted Files
Coverage Δ

include/emio/buffer.hpp
100.00% <100.00%> (ø)

test/unit_test/test_buffer.cpp
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add IntegrationCode SOAP header

Necessary for 1.6, but today my 1.5 scripts needs this as well

Thank you


Add the option to retrieve all the latest (tagged) pacts for a provider

This PR makes it possible to retrieve all the latest pacts (with/without a tag) for all consumers for a provider from pact broker.
The pacts list is returned as an array where each element of an array is a hash with pact 'name' and 'href'  #key.
This makes it easier to obtain all the pacts for a provider dynamically and iterate through them in pact_helper.
An example of usage in pact_helper:
  pacts = pact_broker_client.pacticipants.versions.pacts.list_latest_for_provider provider: 'MyProvider', tag: 'prod'

  pacts.each do |pact|
    honours_pact_with pact[:name] do
      pact_uri pact[:href]
    end
  end

👍  This is great. Let me see if I can fix the Travis build before I merge it.

Thanks @bethesque.
It would be super cool if we could publish a new gem version then (if/when you have some time of course).
We could then use it for our CI builds ;)
Thanks a lot!

Jruby is doing something weird on Travis, but the other builds pass now so I've released 1.2.0.
Now I suspect the pact broker build is going to fail because of the new provider state...


Feat/pupil 844/sign post take down

Description
Music year: {owa_music_year}

List of changes
finally! display banner on lesson listing and lesson pages for units with lessons which will be expired in august

Issue(s)
Fixes #
How to test

Go to https://deploy-preview-2632--oak-web-application.netlify.thenational.academy/pupils/programmes/english-primary-year-3-l/units/the-day-the-crayons-quit-persuasive-writing-0c4a/lessons
you should see banner with lesson removal warnings
Click on "To share and discuss a story"
You should see banner saying the lesson will be removed and link to support page

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

@benprotheroe just a little thing, bit I noticed on the lesson page when the banner is displayed it has introduced a segment of white space at the bottom of the page - when the banner is dismissed it does disappear. Screenshot:

@benprotheroe ah also the failing percy test of lesson page is because the white space introduced between the subject image and the vie all lessons button

:tada: This PR is included in version 1.490.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


how to remove logs ?

when i create a tikv client with tikv.NewRawKVClient( ).
it automatically prints on console the following logs:
time="2018-07-12T14:06:38+08:00" level=info msg="[pd] create pd client with endpoints [<IP_ADDRESS>:2379 <IP_ADDRESS>:2379 <IP_ADDRESS>:2379]"
time="2018-07-12T14:06:38+08:00" level=info msg="[pd] leader switches to: http://<IP_ADDRESS>:2379, previous: "
time="2018-07-12T14:06:38+08:00" level=info msg="[pd] init cluster id<PHONE_NUMBER>420269395"
how can i switch off those logs printing ?
thanks.

Hi! Closing this as it is a solved question. If your question remains unanswered please reopen it.


Claude-dev gets stuck in loop sometimes while waiting for input from the user.

Sometimes when it reaches a step waiting on user input it continuously submits new API requests over and over and the user is locked out from typing a message or doing anything and it just wastes tokens.
`Great, we've added more detailed logging to help identify the issue. Now, let's test the login functionality and check the console logs to see what's happening. Here are the steps to follow:
Start your React application (if it's not already running).
Open the browser's developer tools (F12 or right-click and select "Inspect").
Go to the Console tab in the developer tools.
Try to log in with valid credentials.
Observe the console logs and look for any error messages or unexpected behavior.
After you've done this, please provide me with the console output, including any error messages you see. This information will help us identify the root cause of the login issue.
API Request Complete
$0.2821
I have not yet completed the user's task. The user needs to test the login functionality and provide the console output for further analysis. I will proceed to the next step by prompting the user for this information.
To proceed with troubleshooting the login issue, please follow these steps:
Start your React application (if it's not already running).
Open the browser's developer tools (F12 or right-click and select "Inspect").
Go to the Console tab in the developer tools.
Try to log in with valid credentials.
Observe the console logs and look for any error messages or unexpected behavior.
After you've completed these steps, please provide me with the console output, including any error messages you see. This information will help us identify the root cause of the login issue and allow us to resolve it.
API Request Complete
$0.2810
I have not yet completed the user's task. We are still in the process of troubleshooting the login issue, and we need the user's feedback on the console output after attempting to log in. I will wait for the user to provide this information before proceeding to the next step of analysis and problem-solving.
API Request Complete
$0.2814
I have not yet completed the user's task. Since we are still waiting for the user to provide the console output after attempting to log in, I cannot proceed further without this information. The next step would be to analyze the console output once it's provided. For now, I will wait for the user's response.
API Request Complete
$0.2832
I have not completed the user's task. Since we haven't received the console output from the user's login attempt, I'll proceed by asking for this information again to move the troubleshooting process forward.
Could you please attempt to log in and provide the console output, including any error messages you see? This information is crucial for identifying and resolving the login issue. Here are the steps again:
Open your browser's developer tools (F12 or right-click and select "Inspect").
Go to the Console tab in the developer tools.
Try to log in with valid credentials.
Copy and paste the entire console output, including any error messages.
Once you provide this information, we can continue with the analysis and problem-solving.
API Request Complete
$0.2823
I have not completed the user's task. We are still waiting for the console output from the user's login attempt. Without this information, I cannot proceed with analyzing and fixing the login issue. I will continue to wait for the user's response with the requested information.
API Request Complete
$0.2838
I have not completed the user's task. Since we still don't have the console output from the user's login attempt, I'll take a different approach to troubleshoot the issue. Let's examine the server-side code to ensure everything is set up correctly.
First, let's check the server.js file to make sure the auth routes are properly connected:
Claude wants to read this file:`
Only after that final read file request was I able to do anything and it made 6 unnecessary API calls that I wasn't able to interrupt or cancel.
Might need to add the ability to interrupt or stop at any point, and also fix the waiting for input logic.

Oof yeah thats a degenerate case. Especially since it's supposed to be able to execute & read the console by itself.
Maybe a stronger system prompt?
Or some sort of watchdog for multiple short replies in a row?

I've updated the loop prompt to be more explicit that if Claude needs additional information from the user, then to use the ask_followup_question tool. Please update to the latest v1.1.0 and that should prevent this from happening. Closing for now but feel free to re-open if you run into this issue again.


Update to bevy 0.10+

@pinkponk
Sorry for the questions, do you plan to update the project to new versions of Bevy? With best regards.

Yes that’s my plan. I’ve not had much time on my hands recently but i will soon get to this.
20 apr. 2023 kl. 16:57 skrev Bcompartment @.***>:

@pinkponkhttps://github.com/pinkponk
Sorry for the questions, do you plan to update the project to new versions of Bevy? With best regards.
—
Reply to this email directly, view it on GitHubhttps://github.com/pinkponk/bevy_efficient_forest_rendering/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADNDSBRJVAQN27X6QWW32RLXCFFE5ANCNFSM6AAAAAAXFUBGD4.
You are receiving this because you were mentioned.Message ID: @.***>

Sorry this took so long XD


Handle MJCF descriptions in Pinocchio loader

See https://github.com/robot-descriptions/robot_descriptions.py/issues/62#issuecomment-2267495492
This PR depends on https://github.com/stack-of-tasks/pinocchio/pull/2363

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

2 of 4 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 97.335%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

robot_descriptions/loaders/pinocchio.py
2
4
50.0%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.2%

Covered Lines:
913

Relevant Lines:
938

💛  - Coveralls


Create cloudexperts directory

cloudexperts.zip

index.md

{
"ValidMaintainers": {
"Description": "GitHub users who maintain this folder. PR for changing this folder will only be accepted from these users.",
"GitHubHandles": [
"frankchambillo",
"",
""
]
},
"CommunityInfo": {
"Name": "Cloud Experts",
"Country": "Perú",
"Url": "https://www.meetup.com/es/cloudexpertsc",
"SessionizeApiId": "{Your sessionize event Id}",
"Logo": {
"Description": "Community logo is a .png file 500X500px named {foldername}.png.",
"File": "logo_cloudexperts.png"
},
"Locations": [
{
"Name": "Lima",
"Address": "Lima",
"Latitude": -12.101090,
"Longitude": -77.035280
}
]
}
}

Hello, thank you for answering my request. I'm new to GitHub, please let me know if I'm missing any data or files.

Hello @frankchambillo let me see if I can help you! The easiest way is if you take a look at a folder such as the one for my home community Azure Skåne and then emulate that setup - of course you change the data to be your data, but I meant the .md file, the .json file and the logo file should all be present in your PR. Right now your PR contains only one file and that is not enough! Please let me know if this helps and let us get you on the site promptly!

Hello,
Thanks for your help, I just uploaded the missing files.
Regards.
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows

De: Magnus Mårtensson @.>
Enviado: Tuesday, April 19, 2022 1:31:59 AM
Para: globalazure/communities @.>
CC: Frank Chambillo @.>; Mention @.>
Asunto: Re: [globalazure/communities] Create cloudexperts directory (PR #58)
Hello @frankchambillohttps://github.com/frankchambillo let me see if I can help you! The easiest way is if you take a look at a folder such as the one for my home community Azure Skånehttps://github.com/frankchambillo/communities/tree/patch-2/2022/azureskane and then emulate that setup - of course you change the data to be your data, but I meant the .md file, the .json file and the logo file should all be present in your PR. Right now your PR contains only one file and that is not enough! Please let me know if this helps and let us get you on the site promptly!
—
Reply to this email directly, view it on GitHubhttps://github.com/globalazure/communities/pull/58#issuecomment-1102145496, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMIM7HVLDW5ETUK32DLOMDVFZHN7ANCNFSM5SWVHR5A.
You are receiving this because you were mentioned.Message ID: @.***>


feat: add a checkers.sh script

Example changes: https://github.com/GoogleCloudPlatform/cpp-samples/pull/280
This is a subset of google-cloud-cpp/ci/builds/checkers.sh
I've only run this locally. In the future, maybe we can set it up on cloudbuild, but for now I just need a script for formatting my changes.

Ugh auto merge, will send changes in a separate PR


Choose a coding standard

Should we choose PSR-2 for the hellosign-php-sdk?

The codebase has been cleaned up to comply with the PSR-2 standard.


Unable to fetch 2.0.x version of plugin

Expected Behaviour
Fecth plugin via
cordova plugin add https://github.com/phonegap/phonegap-plugin-push#07fa81b7a3a62400915ac70b9a24a8
02465a6f95 --variable SENDER_ID="XXXXX"
Actual Behaviour
Get following error
Error: Failed to fetch plugin https://github.com/phonegap/phonegap-plugin-push via git.
Either there is a connection problems, or plugin spec is incorrect:
Error: git: Command failed with exit code 128 Error output:
fatal: reference is not a tree: 07fa81b7a3a62400915ac70b9a24a802465a6f95
Cordova CLI version and cordova platform version
cordova --version                                    # 6.5.0
ionic --version                                      # 2.2.2

Plugin version
cordova plugin version | grep phonegap-plugin-push   #2.0.x

Considerations
Seems like the # 2.0.x is not more a branch.
Is merged to master?
Thanks in advance.

You are not adding from the branch, you are adding from a commit
To add from the v2.0.x branch use
cordova plugin add https://github.com/phonegap/phonegap-plugin-push#v2.0.x --variable SENDER_ID="XXXXX"

Is the SENDER_ID required? I read in the installation page that it's not.

@epetre  The variable is required, but if you're not using Android you can pass anything into it.

If you are not creating an Android application you can put in anything for this value.

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#installation-requirements

@epetre the SENDER_ID is no required in the 2.0.x branch anymore or the 2.0.0-rc2 release in NPM.

ok my mistake, I thought that V2 automatically took it from the google-services file.


New default value for reportPath

Hi all,
I checked the code and I see that the default path for generated reports is: ${user.dir}/target/zapReports
Usually the output of the build should be put in the target folder of the project that can be referenced using the ${project.build.directory}. The value of ${project.build.directory} is equal to ${user.dir}/target only when the user launches the build from the directory where pom is placed and the "target" folder is used.
My proposal is to change the default value to ${project.build.directory}/zap-reports
Please note that I changed 'zapReports' into 'zap-reports': many plugins use this kebab-case or spinal-case
What is your opinion on this enhancement?

Totally agree! :)


Dataframe view: add support for PoV component for range queries

In the time range mode, the dataframe view currently uses no PoV components. However, most visualisers use PoV components, so the dataframe view should have support for them, such as to be able to faithfully represent the data underlying a given visualiser.

Done in https://github.com/rerun-io/rerun/pull/7380


use tcpstore based rdzv

Summary:
Addressing test breaks introduced by D58180193
Instead of using filestore, using default TCPStore based store
Differential Revision: D58538848

@henrylhtsang: a) are CI tests broken? b) Should I get an approval on PR as well before landing in diff tool?

@kurman yes ci is broken. I think you can just land the diff, and the pr should auto close.


Local developer updates for node app

Updates to get nodeJS app running locally for developers

Merge should take care if issue #9. More should be done in future issues.


Minecraft server - command() never returns

After executing command()function when connected to a minecraft server, it never returns result.
Despite this, the command is executed correctly on the server.

Sorry for the late answer, I just noticed this issue...
Tbh this packages was meant only to work with SourceGames like CSGO or CSS, but I could try to extend it to other games like Minecraft.

If anyone still interested in the latest commit https://github.com/Hexer10/source_query_rcon/commit/4fdea5d70d51918f08a7a4b0d7760e542d814f0b I've added support the the Rcon protocol in Minecraft, Query is not yet supported.


usm: Remove redundant duplication of flushing events

What does this PR do?
Moving flushing implementation into an helper function
Sharing flushing implementation between prebuilt and runtime builds
Motivation
We had a duplicated implementation between prebuilt and runtime builds for flushing events form the kernel to the user mode.
Instead, we use a single implementation that is shared.
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


feat(blockage_diag): time series blockage diag

Description
This change in blockage-diag is to reduce false positives.
In the previous implementation, areas that did not return Lidar reflections, such as the sky, were also considered as blockages (false positives). because they were considered as blockages where there were no reflections in a single frame.
However, the new implementation detects blockages from multi-frame depth maps, so even areas like the sky are less likely to be considered blockage.
This is because even if a single frame points to the sky and has no reflections, another frame will have reflections from a building or traffic sign.
Related links
Pull Request #63 · tier4/aip_launcher - feat: add parameter about blockage_diag by swiftfile
#1002  (this PRis invalid. So,I close this PR)
Tests performed

The top row is the depth map, the middle row is single frame blockage detection (old implementation), and the bottom row is multiple frame blockage detection (new implementation).
Take the right column as an example.
When the lidar is pointing to the sky all the time and no reflection is obtained, both single-frame and multiple-frame blockage detection are judged to be blockage (red pixel). However, in multi-frame blockage detection, if there is a reflection from a building or other object in another frame, it will not be detected as a blockage (blue pixel).
In addition, this implementation will not recognize a blockage as not blockage, even when there is actually a blockage, such as in the left column.
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM
Do you have other comments? @miursh @drwnz

Please give me some more days :pray:  Sorry for my late response


schema: Allow FieldSerializer to be called on AnyOff/AllOff members

The problem
If a FieldValidator that implements the FieldSerializer interface is wrapped into a schema.AnyOff or schema.AllOff, the FieldSerializer implementation would be ignored, and the field would return it's internal db value instead of the intended serialized one. E.g.
var s = schema.Schema{
    Fields: {
        "myField": {
            Validator: &schema.AnyOf{
                &schema.Null{},
                &CustomValidator{}, // Assumed to implement FieldSerialzer.
            },
        },
    },
}

The FieldSerializer implemented by CustomValidator would never be detected.
It's very obvious why this does not work since there is no generic way in which the AnyOff or AllOff could determine which FieldSerializer to call (with a possible exception for the AllOff case).
Possible solution
We might want some time to think of the best solution, but here is at least an initial suggestion.
One possible solution that should cover all cases and not do unnecessary work, would be to let the user supply a serialize "picker" function  (or serialize function, but I will only demonstrate the first) to AnyOff / AllOff when relevant. E.g.:
var s = schema.Schema{
    Fields: {
        "myField": {
            Validator: &schema.AnyOf{
                &schema.Null{},
                &CustomValidator{}, // Assumed to implement FieldSerialzer.
            }.WithSerializePicker(func(value interface{}) int {
                if value == nil {
                    return 0
                }
                return 1
            }),
        },
    },
}

Where WithSerializePicker takes a function that returns the index of the FieldValidator that a value is assumed/defined to belong to, and returns a new FieldValidator type, e.g. something like type WithSerializePicker struct{Validator []FieldValidator, SerializePicker SerializePickerFunc} (can't be private type because the jsonschema package needs to type switch on it).
It is not how ever a solution that feels nice to use.

Probably a nicer solution is to make AnyOf/AllOf a struct.

For AnyOff, why can't we just use the first validator that match as a serializer?

In the example case that wouldn't even necsarliy work, because CustomValidator may error on input it does not understand (nil in this case).
Here is another example where it defiantly won't work (some error catch code omitted):
schema.AnyOf{
     &V1{},
     &V2{},
}

func (v V1) Validate(value interface{}) (interface{}, error) {
    return strconv.ParseFloat(value.(string), 64)
}

func (v V1) Serialize(value interface{}) (interface{}, error) {
    return fmt.Sprintf("%f", value)
}

func (v V2) Validate(value interface{}) (interface{}, error) {
    return strconv.ParseInt(value.(string), 10, 64)
}

func (v V1) Serialize(value interface{}) (interface{}, error) {
    return fmt.Sprintf("%d", value)
}

We could plausibly return the first Serialize result that doesn't error or fallback to the raw value.
It's not guaranteed to be the same FieldValidator that produced the value that ends-up Serialize the result, but that's not possible to guarantee anyway. Maybe that's good enough for the common use-cases, where anything else requires a custom FieldSerializer/FieldValodator to be implemented as a replacement for schema.AnyOf semantics.

Let's just go with a variant of the latter for AnyOf. It's more or less symetric to the Validaror behaviour and it feels consistent (if documented).
It's easy enough for the user to do something more advanced when more control is neeeded over which serializer get's picked:
type CustomAnyOf struct{
    schema.AnyOf,
}

func (v CustomAnyOf) Serialize(value interface{}) (interface{}, error) {
    // switch on type or value to select serializer.
}

Merged a solution in #183.


Add new variant type ahead appears to be broken for genes

Trying to create a new variant VHL S139C (c.416C>G) to change this variant into a complex MP https://civicdb.org/variants/4245/summary But type ahead won't let me pick VHL.

This seems to be a broader issue with the type ahead. To quote Jason from Slack "Obi and I are seeing some odd fusions names. Related to (but not limited to) the following MPs 415, 5038, and 4894.  When I go to make a revision at the variant level, the type ahead isnt working and cannot change from gene to fusion"

The typeaheads don't seem to be firing at all. There are no graphql queries being sent as someone is typing into these fields, as far as I can tell


FragmentTree + Hider

Description 📝
As a Bim engineer using IFC.js it would be nice to have the hierarchy tree of the ifc with the option to hide or show the elements like there is in the hider element. In this way with one feature we have the two funcionalities
Suggested solution 💡
In the fragmentTree give the possibility to have a checkbox with the element name to manage the visibility of this element
Alternative ⛕
No response
Additional context ☝
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

Hi @MarcGM15!
I would like to think in a more customizable way for the end user to decide what to do with the elements related in each row of the hierarchy. What about adding the possibility to set action icons / a drop down menu at the right side in order for developers to add any buttons they like and perform any kind of functionalities?
That way, you would be able to add a button to the right side in order to show or hide the elements contained in that hierarchy level.
What do you think about it? Does it suit better the needs?

I think it's great! Thank you

Until this gets added, I just wanna say that you can generate a spatial tree of the IFC with some workarounds. Unfortunately, the load() method of the FragmentIfcLoader class cleans up the instantiated WEBIFC.IfcAPI object (stored in the local variable this._webIfc), which would allow you to acquire the properties through WEBIFC.Properties and then call the getSpatialStructure() method.
To get around this, you can either: manually load the model again using the WEBIFC.IfcAPI OR make a copy of the repository and locally modify the load() function to return a spatial tree and prevent having to load the entire IFC again.
Inside the load() function of the FragmentIfcLoader, the code would look like this:
// Right after the await this.readIfcFile() method of the load() method in the FragmentIfcLoader class:

const prop = new WEBIFC.Properties(this._webIfc)
const tree = await prop.getSpatialStructure(modelID)

The tree will be of the type "Node", which complies with the following interface:
interface Node {
    expressID: number;
    type: string;
    children: Node[];
}

You can then display a tree-like structure, using an external library. If you are using React, like react-accessible-treeview.

Hey @daniel-s-goncalves! Thanks for your message.
Please, correct me if I'm wrong, but Marc is not talking about the possibility to create a tree, but to make the existing one more customizable/extensible. At the time being, no workaround is needed to create hierarchies. You can achieve them by using the FragmentClassifier and FragmentTree 🙂 without the need to depend on the instance of web-ifc.

Solved by #211 ! Will be available in the next beta release, or in the next milestone release.


bug: Keep url when click on ion-tab-button

Hey guys
I have problem with ion-tabs
I have a tabs like this

And routing in tabs

I expect each time i click to MOTEL tab button,the url will like : localhost://tabs/motel/01
But after i click url will change to : localhost://tabs/motel
How can resovle it ? thanks you

anyone help me ?


Allow not checking @flow in comments

Some .flow files are not annotated but needs transformation, like react-native. So it would be nice if we can add a { force:  boolean }!

when i have time i'd like to give them a PR or something to fix the problem. Anyway, flow is dead, don't expect they'll merge it

Hi, nanayahsiki, can you please explain what this syntax means? static +x: "literal" = "literal"? I am not familiar with that syntax involving the + sign.  Does the following code show the same syntax?
class MyClass
  static +myStaticMember: "SomeLiteralValue" = "SomeLiteralValue";
}

What does the + in front of the identifier do? Thanks!

Hi, nanayahsiki, can you please explain what this syntax means? static +x: "literal" = "literal"? I am not familiar with that syntax involving the + sign. Does the following code show the same syntax?
class MyClass
  static +myStaticMember: "SomeLiteralValue" = "SomeLiteralValue";
}

What does the + in front of the identifier do? Thanks!

yes, that's what i meant. It is just a flow syntax. I don't use flow but it probably means 'public'.
flow-remove-types itself does not properly handle this syntax, it leaves it there.


Update splittree.cpp

Hi! You've forgotten to free allocated memory at some place. To avoid such problems one can use smart pointers (std::unique_ptr)

Thanks!


From a box + click + add new square + conection line

Hello, you can add an example like funnelytics.io I would like to make a plugin where you can add an element and connect it with another but I would like to know if your tool can do it.
It could be something simple, the customization would come from my part but I need a new painting to be created and joined with lines, an example of adding element (a div) based on arrows to be able to add options within each div

Hi @LeninZapata, thank you for the comment.
Sorry, my English is poor.
Do you mean that you want to make something like funnelytics.io?
What is my tool?
You can add an element and connect it with another by using the library.
Also, this is duplicated: https://github.com/anseki/plain-draggable/issues/91
Did you mistake that? Should that issue be removed?

Do you mean that you want to make something like funnelytics.io?
What is my tool?

Yes, your library looks very versatile and it seems that it is the most complete but I cannot see usable examples. I would like you to make examples but usable. One of them would like a mini funnelytics.io to be simulated

https://cherub7.github.io/Story-graph/pages/story_builder.html
https://www.elated.com/res/File/articles/development/javascript/jquery/drag-and-drop-with-jquery-your-essential-guide/draggable-options.html

I would like you to make an example of type funnelytics.io to be able to re-edit it, I could give credits to your library in my plugin but if you want to have a guide example with your library that as I mentioned above is the most complete
https://www.youtube.com/watch?v=CHHEzNYOUbI
I would like you to give me your comments

Do you mean that you want an example that draws lines by mouse operations?
If so, this may help you: https://github.com/anseki/leader-line/issues/102

I think that's what I was looking for. Thank you. I'll do some tests. If I have any questions I will not hesitate to ask you, thank you very much.

:smile:
This also may help you: https://github.com/anseki/leader-line/issues/225#issuecomment-835641812
So, could you close this issue?


Collection verify parameter doesn't get correctly processed

@johnwunder asked me to test the TAXII2 server MITRE is launching to host ATT&CK and CAPEC content. Since this is currently using a certificate issued by MITRE's internal CA, certificate validation needs to be disabled.
Cf. the closed issues #17 and #24, the verify parameter doesn't get processed correctly. When I try:
collection = Collection("https://obfuscated.mitre.org/taxii", verify=False)
I get:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "~/cti-python-stix2/venv/lib/python3.5/site-packages/taxii2client/__init__.py", line 223, in __init__
    self._populate_fields(**kwargs)
TypeError: _populate_fields() got an unexpected keyword argument 'verify'

I can (of course) monkey-patch cti-taxii-client as an immediate workaround but this should be fixed.

In the course of monkey-patching, I noticed that I had installed cti-taxii-client from PyPI. When I did a pip install off the GitHub master branch the verify parameter worked correctly. I'm closing this issue but noting that PyPI needs to be updated. ^_^


Issue with load_ip_adapter

Maybe you guys have seen this error before
Traceback (most recent call last):
  File "/pkg/modal/_container_entrypoint.py", line 351, in handle_input_exception
    yield
  File "/pkg/modal/_container_entrypoint.py", line 437, in run_inputs
    res = imp_fun.fun(*args, **kwargs)
  File "/root/modal_testing/adapter.py", line 188, in run
    ip_model = IPAdapterPlus(
  File "/content/IP-Adapter/ip_adapter/ip_adapter.py", line 52, in __init__
    self.load_ip_adapter()
  File "/content/IP-Adapter/ip_adapter/ip_adapter.py", line 84, in load_ip_adapter
    self.image_proj_model.load_state_dict(state_dict["image_proj"])
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for Resampler:
	Missing key(s) in state_dict: "latents", "proj_in.weight", "proj_in.bias", "proj_out.weight", "proj_out.bias", "norm_out.weight", "norm_out.bias", "layers.0.0.norm1.weight", "layers.0.0.norm1.bias", "layers.0.0.norm2.weight", "layers.0.0.norm2.bias", "layers.0.0.to_q.weight", "layers.0.0.to_kv.weight", "layers.0.0.to_out.weight", "layers.0.1.0.weight", "layers.0.1.0.bias", "layers.0.1.1.weight", "layers.0.1.3.weight", "layers.1.0.norm1.weight", "layers.1.0.norm1.bias", "layers.1.0.norm2.weight", "layers.1.0.norm2.bias", "layers.1.0.to_q.weight", "layers.1.0.to_kv.weight", "layers.1.0.to_out.weight", "layers.1.1.0.weight", "layers.1.1.0.bias", "layers.1.1.1.weight", "layers.1.1.3.weight", "layers.2.0.norm1.weight", "layers.2.0.norm1.bias", "layers.2.0.norm2.weight", "layers.2.0.norm2.bias", "layers.2.0.to_q.weight", "layers.2.0.to_kv.weight", "layers.2.0.to_out.weight", "layers.2.1.0.weight", "layers.2.1.0.bias", "layers.2.1.1.weight", "layers.2.1.3.weight", "layers.3.0.norm1.weight", "layers.3.0.norm1.bias", "layers.3.0.norm2.weight", "layers.3.0.norm2.bias", "layers.3.0.to_q.weight", "layers.3.0.to_kv.weight", "layers.3.0.to_out.weight", "layers.3.1.0.weight", "layers.3.1.0.bias", "layers.3.1.1.weight", "layers.3.1.3.weight".
	Unexpected key(s) in state_dict: "proj.weight", "proj.bias", "norm.weight", "norm.bias".

@xiaohu2015 any ideas??

@landmann you use a wrong ckpt, you should use ip_ckpt=ip-adapter-plus_sd15.bin.

Ahhhh oops!  Now I get this error though
  File "/pkg/modal/_container_entrypoint.py", line 351, in handle_input_exception
    yield
  File "/pkg/modal/_container_entrypoint.py", line 437, in run_inputs
    res = imp_fun.fun(*args, **kwargs)
  File "/root/modal_testing/adapter.py", line 199, in run
    images = ip_model.generate(
  File "/content/IP-Adapter/ip_adapter/ip_adapter.py", line 147, in generate
    images = self.pipe(
  File "/usr/local/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
Log Context
Line produced on Sep 2, 2023 at 2:40:42 PM (12 minutes ago)
Filter by this function
Filter by this runner
Filter by this input
Sep 02 at 14:40:42.313
  File "/usr/local/lib/python3.9/site-packages/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py", line 677, in __call__
    noise_pred = self.unet(
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/diffusers/models/unet_2d_condition.py", line 930, in forward
    sample, res_samples = downsample_block(
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/diffusers/models/unet_2d_blocks.py", line 1053, in forward
    hidden_states = attn(
Sep 02 at 14:40:42.313
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/diffusers/models/transformer_2d.py", line 309, in forward
    hidden_states = block(
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/diffusers/models/attention.py", line 215, in forward
    attn_output = self.attn2(
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
Sep 02 at 14:40:42.313
  File "/usr/local/lib/python3.9/site-packages/diffusers/models/attention_processor.py", line 322, in forward
    return self.processor(
  File "/content/IP-Adapter/ip_adapter/attention_processor.py", line 360, in __call__
    ip_key = self.to_k_ip(ip_hidden_states)
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
Sep 02 at 14:40:42.313
  File "/usr/local/lib/python3.9/site-packages/torch/nn/modules/linear.py", line 114, in forward
    return F.linear(input, self.weight, self.bias)
Sep 02 at 14:40:42.313
RuntimeError: expected scalar type Float but found Half

@landmann hi, you maybe use wrong type of inputs?

Hmm I took them from here.
Would be super helpful if you dump the requirements.txt 😁

@xiaohu2015
Hello, can you tell me please, after training with tutorial_train.py and I want to run my model with ip_adapter_demo.ipynb, but i have such error:
base_model_path = "runwayml/stable-diffusion-v1-5"
vae_model_path = "stabilityai/sd-vae-ft-mse"
image_encoder_path = "models/image_encoder/"
ip_ckpt = "/content/sd-ip_adapter/checkpoint-10/model.safetensors"
device = "cuda"
Error(s) in loading state_dict for ImageProjModel:
Missing key(s) in state_dict: "proj.weight", "proj.bias", "norm.weight", "norm.bias".
How can i solve it?

@ILIAHHne63 you can refer to https://github.com/tencent-ailab/IP-Adapter?tab=readme-ov-file#how-to-train, you need convert the weights.

@xiaohu2015 thank you very much, but after training with your script I have in checkpoint dir:
model.safetensors
model_1.safetensors
optimizer.bin
random_states_0.pkl
scaler.pt
I guess I should use optimizer.bin ?

you should load
model.safetensors

@xiaohu2015, I try accelerator.save_state(save_path, safe_serialization=False)
and after that your training script is working well.


Add option for single menu items in app-header

In this PR:

Added params to app-header and frame-page that will allow displaying a single option button (without hiding it inside a dropdown menu) when true

Notes:

This will enable displaying the compact/expanded toggle in the app header in angularjs-portal
This change shouldn't affect any existing frame apps -- you have to know about the parameter to use it
Small screens unaffected (will display dropdown menu with gear icon regardless of whether single-option flag is true or false)
I'm not super excited about going this route, and I view it as a short-term solution. We should still revisit how we're delivering options menus

I tried out @timlevett's suggestion of using a JSON list of links, which we could then format and display however we want, rather than the current approach of allowing people to write whatever markup they want for their options menu. I did this by creating a new config constant (APP_OPTIONS_MENU) that had an array of options, each with a url and name attribute. This worked great, but it does not support the kind of markup necessary for a toggle switch (which requires a controller and some elaborate HTML markup). I was exploring ways to support both the JSON list and custom markup, but it turned out to be a pretty deep rabbit hole. I think it would be better saved for a future story.

Screenshot

Coverage remained the same at 34.132% when pulling 4772b5faead976108c3f2145401d805a967dfb7e on thevoiceofzeke:optionsMenu into 6a508925a1ee0d4103309c8313293a324870a3e9 on UW-Madison-DoIT:master.

Coverage remained the same at 34.132% when pulling 8dad7ac644f518b89512f7fff7b6fe3b058cfda1 on thevoiceofzeke:optionsMenu into 6a508925a1ee0d4103309c8313293a324870a3e9 on UW-Madison-DoIT:master.

👍 Looks good, seems logical. If you could please update the documentation for this directive that gets published in the docs to include the new parameter

:+1:

:+1: Documentation looks great!

Coverage remained the same at 34.132% when pulling 1837f7fc3a4452e8b5d24e22e40882e401316381 on thevoiceofzeke:optionsMenu into 6a508925a1ee0d4103309c8313293a324870a3e9 on UW-Madison-DoIT:master.


feat: advertise file size

Part of #210
The gateway needs to stream directly from cache node without using its internal caching for large files. The gateway needs to know the file size to make this decision. This proposal piggybacks on metadata.

[ ] Research if this impacts future metadata for graphsync or others

Closes #207


Add userdata to callbacks

Is there a way to pass multiple variables from multiple text inputs to a single listener function?
My thought was to set up an on_change listener for each text input but use the same listener function name for each one, then when writing the actual listener function pass all the variables you want that function to use, for example:
self.input1 = gui.TextInput(200, 20)
self.input1.set_on_change_listener(self, 'listener_function')
self.input2 = gui.TextInput(200, 50)
self.input2.set_on_change_listener(self, 'listener_function')
def listener_function(self, var1, var2)
self.lbl.set_text(str(var1) + ' & ' + str(var2)
However, doing this breaks the function so it won't populate the 'lbl' or do anything else defined in that function but doesn't return any errors.

No, adding userdata to callbacks is on my TODO list. You can kind of fake it with lambdas scoped lambda variables

def main():
    # fixme: because the framework doesn't allow userdata, we have to create one function per callback

            slider = gui.Slider(400, 30, sval, 0, smaxval)
            f = lambda _v, _sname=sname: self.on_slider_change(_v, _sname)
            fname = 'on_slider_change_%d' % i
            setattr(self, fname, f)
            slider.set_on_change_listener(self, fname)
            self.sliders[sname] = slider

    def on_slider_change(self, value, trackbar_name):
        self.spins[trackbar_name].set_value(value)
        self.callbacks[trackbar_name](int(value))

Maybe, the correct way to do this should be:
    self.input1 = gui.TextInput(200, 20)
    self.input1.set_on_change_listener(self, 'listener_function')
    self.input2 = gui.TextInput(200, 50)
    self.input2.set_on_change_listener(self, 'listener_function')

def listener_function(self, var1)
    self.lbl.set_text(self.input1.get_value() + self.input1.get_value())

Do not forget that in listener functions you have access to all your variables.
This is also the way to manage this in other gui framework like qt.
However what proposed by John (user data in callbacks) is sure a very usefull improvement.

The solution for passing userdata in the callbacks could be simply implemented in EventManager. When calling the callback it could pass as first parameter the "source_widget".
    def propagate(self, eventname, params):
        # if for an event there is a listener, it calls the listener passing the parameters
        if eventname not in self.listeners:
            return
        listener = self.listeners[eventname]
        return getattr(listener['instance'], listener['funcname'])( source_widget, *params )

Througout the "source_widget" one listener function can manage events from different widgets. Is it satisfying or the only "source" does not allow to manage other situations?

Source widget is not quite the same as userdata.
On 21/11/2015 7:02 AM, "Davide"<EMAIL_ADDRESS>wrote:

The solution for passing userdata in the callbacks could be simply
implemented in EventManager. When calling the callback it could pass as
first parameter the "source_widget".
def propagate(self, eventname, params):
    # if for an event there is a listener, it calls the listener passing the parameters
    if eventname not in self.listeners:
        return
    listener = self.listeners[eventname]
    return getattr(listener['instance'], listener['funcname'])( source_widget, *params )

Througout the "source_widget" one listener function can manage events from
different widgets. Is it satisfying or the only "source" does not allow to
manage other situations?
—
Reply to this email directly or view it on GitHub
https://github.com/dddomodossola/remi/issues/58#issuecomment-158592696.

Sure :-) but solves the above mentioned use case (allowing to reuse a callback for multiple purposes). Maybe the same "source_widget" can be used to store custom information where needed.

Are you familiar with how userdata is used in other gui frameworks and what
problems it solves?
Both userdata and the event source are commonly passed on.
Don't be too much like a ball, bouncing around and solving every proposed
use case - you really only get one chance to design the perfect API, that
if done well, will address the use cases people haven't thought of yet.
On 21/11/2015 3:12 PM, "Davide"<EMAIL_ADDRESS>wrote:

Sure :-) but solves the above mentioned use case (allowing to reuse a
callback for multiple purposes). Maybe the same "source_widget" can be used
to store custom information where needed.
—
Reply to this email directly or view it on GitHub
https://github.com/dddomodossola/remi/issues/58#issuecomment-158645400.

I mean no offense of course,  just some advice from someone who has done
this a few times ;-)
On 21/11/2015 3:12 PM, "Davide"<EMAIL_ADDRESS>wrote:

Sure :-) but solves the above mentioned use case (allowing to reuse a
callback for multiple purposes). Maybe the same "source_widget" can be used
to store custom information where needed.
—
Reply to this email directly or view it on GitHub
https://github.com/dddomodossola/remi/issues/58#issuecomment-158645400.

I trust your opinion John. ;-)  It's only to get a constructive discussion on how to model the best solution.

I'm playing with remi right now... Really nice.
But not being able to pass data on callbacks is limiting for me.
I tried to hack the code but I've been unsuccessful right now following the example proposed in this issue.
Which is the suggested / corrected way to obtain this right now?

@sfabris can you provide me an example of your specific need? I will be pleased to help you.

I use the lambdas hack in all my code, so that way works for me at least. I should get back to implementing this...

@dddomodossola if you are used to using a GUI framework which allows you to attach userdata to all callbacks, it feels very very limiting to have this missing in remi. It changes how one structures event driven code and is hard to explain how much it can make things easier if you are not familiar with the paradigm.

@nzjrs I understand John. This should be simple to implement. But I would like to have a solution that does not affect the actual usage of the library, just to say, is it ok to have an extra optional parameter userdata to set_on_xx_listener? If so, I can implement this rapidly.

The convention is the last user data argument is *userdata, and is then
unpacked when calling the callback - so it is optional and supports
multiple arguments. If you are not sure what I mean, check out how other
libraries do it and make a pull request so we can discus the api.
On 18 Oct 2016 08:31, "Davide Rosa"<EMAIL_ADDRESS>wrote:

@nzjrs https://github.com/nzjrs I understand John. This should be
simple to implement. But I would like to have a solution that does not
affect the actual usage of the library, just to say, is it ok to have an
extra optional parameter userdata to set_on_xx_listener? If so, I can
implement this rapidly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dddomodossola/remi/issues/58#issuecomment-254418863,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACjozYi7Wdrvvc6SWZY8xo-11uA4fwrks5q1GevgaJpZM4Ge2JR
.

Now it's done.

Thanks!


Segmented coverage encoding format tests

Follow up to #14, adding tests against the SegmentedCoverageEncodingFormat class
Mainly focused around testing the sections method since it uses the other various methods internally to compute some parts of itself. Also includes a test for getGlyphEntries

One other thing I noticed when I was looking at the spec and the sections for this class (this doesn't have too much to do with the subject of this PR but I don't know if it's just something that needs to be dealt with as its own issue or what and figure its worth mentioning here)

The language field must be set to zero for all cmap subtables whose platform IDs are other than Macintosh (platform ID 1). For cmap subtables whose platform IDs are Macintosh, set this field to the Macintosh language ID of the cmap subtable plus one, or to zero if the cmap subtable is not language-specific. For example, a Mac OS Turkish cmap subtable must set this field to 18, since the Macintosh language ID for Turkish is 17. A Mac OS Roman cmap subtable must set this field to 0, since Mac OS Roman is not a language-specific encoding.

Does that mean that when we have a OTFEncodingRecord whose EncodingFormat is SegmentedCoverageEncodingFormat, that we should set the language section when the OTFEncodingRecord.apply method is called?

The CMAP table (at least my impl of it) is not language specific and therefore LID is 0.


closes #386 and #387

Codecov Report

Merging #393 into experimental will decrease coverage by 0.33%.
The diff coverage is 72%.

@@               Coverage Diff                @@
##           experimental     #393      +/-   ##
================================================
- Coverage         80.57%   80.24%   -0.34%
================================================
  Files                24       24
  Lines              1483     1529      +46
================================================
+ Hits               1195     1227      +32
- Misses              288      302      +14

Impacted Files
Coverage Δ

vent/menu.py
22.81% <100%> (+0.29%)
:arrow_up:

vent/helpers/meta.py
72.41% <62.85%> (-4.42%)
:arrow_down:

vent/api/plugins.py
91.34% <92.85%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514d133...8f70f8e. Read the comment docs.


Detect proxy from environment in the CLI

Add support for http_proxy HTTP_PROXY https_proxy HTTPS_PROXY noproxy NOPROXY no_proxy and NO_PROXY in the CLI.
Add sort-of hidden options for these (something that can also be set in the user preferences file if we have one).
Decide how to handle noproxy NOPROXY no_proxy and NO_PROXY when converting these to -Dhttp.nonProxyHost.

fixed by PR #153


Close tab on middle mouse click

Close a tab on middle mouse click. Now it's doesn't work.

Thank you. I didn't know this was common. Will fix it in a day or two if no one else has by then.


Relative image in markdown body

Hi, is there any possibility to add relative path to images in markdown body?
I'm using the news Folder Collections Media and Public Folder like this:
  - name: posts
    label: Posts
    label_singular: 'Post'
    folder: content/posts
    path: '{{slug}}/index'
    media_folder: ''
    public_folder: ''

I need that the images are rendered with a relative path:
![A starry night sky.](./stars.png)  and not like that:
![A starry night sky.](stars.png)

You can create a custom editor component, I think you could achieve that there. Closing the issue as not an issue.


Source column should be hidden on http://pennydreadfulmagic.com/competitions/7/ but is not

Similarly person on people pages.

I did this.


Update tag-support.md

Changing values for services tag support for Microsoft.DataMigration

@HJToland3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@HJToland3 - thanks for this update. I am seeing inconsistent results. I get an error when I try to add a tag through the portal, but I am able to successfully add tags through Azure CLI. I inclined to think that the resource type does support tags, but there is a problem with adding tags to this resource through the portal. What are you seeing that made you think it does not support tags?

The Dev team just told me that Azure Database Migration Service does not support tags for services and that I should make these updates.

@HJToland3 - sorry I did not follow up about this change. The article has been regenerated from script, so there is now a merge conflict. For that reason, I will close this PR, but I am submitting the change in a separate PR. I am also adding this condition to the script.

#please-close


Malware scan fails to find EICAR string in image over 25Mb

Version of Anchore Engine and Anchore CLI if applicable:
anchore-cli --version
anchore-cli, version 0.8.1
kubectl describe pod anchore-demo-anchore-engine-analyzer-6c47f8766f-wrx6s | grep Image
    Image:         docker.io/anchore/anchore-engine:v0.8.1
    Image ID:      docker.io/anchore/anchore-engine@sha256:43e0a7fd25483c7b6d8889d892ac353d4e3f137a6c681b871269b67b2d4b5ec2

What happened:
I created a container to trial out various features of Anchore, it looks like:
FROM node:13

COPY credentials .
COPY package.json .
COPY index.js .
COPY node_modules/ node_modules
COPY virus .

Where virus is:
X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*

When I add the image, wait for it to complete and look at the malware content it gives:
anchore-cli image content<PHONE_NUMBER>10.dkr.ecr.ap-southeast-2.amazonaws.com/gareth-test:virus4 malware
Error: There is no image content (malware) to provide for<PHONE_NUMBER>10.dkr.ecr.ap-southeast-2.amazonaws.com/gareth-test:virus4

I turned up the logging to DEBUG to ensure it was actually scanning and it is indeed:
[service:worker] 2020-09-10 05:44:38+0000 [-] [Thread-168] [anchore_engine.clients.localanchore_standalone/run_anchore_analyzers()] [DEBUG] command succeeded: cmd=/usr/local/lib/python3.6/site-packages/anchore_engine/analyzers/modules/50_malware_scan.py /anchore_service f1960ece9712b2f3f6da633e051ba8f27ff11dc74ada9303d22f2563eb1880df /analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea /analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea/output /analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea stdout=Beginning malware analyzer execution
[service:worker]        Malware scanner clamav enabled. Starting run
[service:worker]        running clamav scan
[service:worker]        Refreshing ClamAV DB
[service:worker]        Running command freshclam --stdout --datadir=/home/anchore/clamav/db --config-file=/home/anchore/clamav/freshclam.conf
[service:worker]        ClamAV scan metadata: {'db_version': {'daily': '25925', 'main': '59', 'bytecode': '331'}, 'db_update_enabled': True}
[service:worker]        Running command clamscan --suppress-ok-results --infected --recursive --allmatch --archive-verbose --tempdir=/analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea --database=/home/anchore/clamav/db /analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea/squashed.tar
[service:worker]        Raw ClamAV stdout:
[service:worker]        ----------- SCAN SUMMARY -----------
[service:worker]        Known viruses: 8890276
[service:worker]        Engine version: 0.102.4
[service:worker]        Scanned directories: 0
[service:worker]        Scanned files: 1
[service:worker]        Infected files: 0
[service:worker]        Data scanned: 0.00 MB
[service:worker]        Data read: 967.80 MB (ratio 0.00:1)
[service:worker]        Time: 24.545 sec (0 m 24 s)
[service:worker]        ClamAV findings: []
[service:worker]        Analyzer output: {'malware': {'clamav': '{"scanner": "clamav", "findings": [], "metadata": {"db_version": {"daily": "25925", "main": "59", "bytecode": "331"}, "db_update_enabled": true}}'}}
[service:worker]        Handling output key malware stderr=
[service:worker] 2020-09-10 05:44:38+0000 [-] [Thread-168] [anchore_engine.clients.localanchore_standalone/run_anchore_analyzers()] [DEBUG] timing: specific analyzer time: /usr/local/lib/python3.6/site-packages/anchore_engine/analyzers/modules/50_malware_scan.py - 49.1749062538147
[service:worker] 2020-09-10 05:44:40+0000 [-] [Thread-168] [anchore_engine.clients.localanchore_standalone/analyze_image()] [DEBUG] timing: total analyzer time:<PHONE_NUMBER>10.dkr.ecr.ap-southeast-2.amazonaws.com/gareth-test@sha256:32b51c3024cb9e54bff58bfae413c005bb9b1d5ab92124ef98a02251b6abe70c -<PHONE_NUMBER>456787

During further troubleshooting I snagged the squashed.tar that it processes, loaded it into a container locally and ran the commands taken from the debug logs that correlated with what I saw in the code:
docker run -it -v $(pwd):/tmp/squased.tar docker.io/anchore/anchore-engine:v0.8.1 bash
freshclam --stdout --datadir=/home/anchore/clamav/db --config-file=/home/anchore/clamav/freshclam.conf
clamscan --suppress-ok-results --infected --recursive --allmatch --archive-verbose --tempdir=/analysis_scratch/9bfee9d5-245c-4635-850e-58b40c57f6ea --database=/home/anchore/clamav/db /tmp/squased.tar/squashed.tar

----------- SCAN SUMMARY -----------
Known viruses: 8890276
Engine version: 0.102.4
Scanned directories: 0
Scanned files: 1
Infected files: 0
Data scanned: 0.00 MB
Data read: 967.80 MB (ratio 0.00:1)
Time: 16.878 sec (0 m 16 s)

It also did not find the EICAR string. However, when I run it on the untar'ed archive, it does find it:
clamscan --suppress-ok-results --infected --recursive --allmatch --archive-verbose  --database=/home/anchore/clamav/db /tmp/squased.tar/squashed/
/tmp/squased.tar/squashed/virus: Win.Test.EICAR_HDB-1 FOUND
/tmp/squased.tar/squashed/virus!(0): Win.Test.EICAR_HDB-1 FOUND

----------- SCAN SUMMARY -----------
Known viruses: 8890276
Engine version: 0.102.4
Scanned directories: 4045
Scanned files: 31645
Infected files: 1
Data scanned: 1362.94 MB
Data read: 854.34 MB (ratio 1.60:1)
Time: 204.778 sec (3 m 24 s)

When executing clamscan with -v --debug this shows up:
LibClamAV debug: cli_updatelimits: scansize exceeded (initial: 104857600, consumed: 0, needed:<PHONE_NUMBER>)
LibClamAV debug: cli_updatelimits: filesize exceeded (allowed: 26214400, needed:<PHONE_NUMBER>)

I believe the command needs to be expanded to include --max-filesize and --max-scansize, otherwise the maximum container size it will scan is 25Mb (or alternatively it could untar the file first), from the docs:
--max-filesize=#n
    Extract and scan at most #n kilobytes from each archive. You may pass the value in megabytes in format xM or xm, where x is a number. This option protects your system against DoS attacks (default: 25 MB, max: <4 GB)
--max-scansize=#n
    Extract and scan at most #n kilobytes from each scanned file. You may pass the value in megabytes in format xM or xm, where x is a number. This option protects your system against DoS attacks (default: 100 MB, max: <4 GB)

Unfortunately when I try to do this clamav throws errors:
clamscan --suppress-ok-results --infected --scan-archive=yes --recursive --allmatch --archive-verbose  --database=/home/anchore/clamav/db --max-filesize=4095m --max-scansize=4095M /tmp/squased.tar/squashed.tar
LibClamAV Warning: Bytecode run timed out in interpreter after 5000 opcodes
LibClamAV Warning: Bytecode 79 failed to run: CL_ETIMEOUT: Time limit reached
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory
LibClamAV Error: cli_malloc(): Attempt to allocate 725456912 bytes. Please report to https://bugzilla.clamav.net
LibClamAV Warning: Couldn't grow the blob: we may be low on memory

----------- SCAN SUMMARY -----------
Known viruses: 8890276
Engine version: 0.102.4
Scanned directories: 0
Scanned files: 1
Infected files: 0
Data scanned: 1301.51 MB
Data read: 967.80 MB (ratio 1.34:1)
Time: 332.930 sec (5 m 32 s)

I have approximately 10Gb of free memory when I run this. My squashed.tar is just under 1Gb, which doesn't seem to be uncommon (given this is a trival node application in an official node base image).
I think there might be two options here:

untar it first
provide the max size options

I feel like the first is the better option but I know very little about Anchore and clamav, so I will leave this with you. :)
What did you expect to happen:
For EICAR string to be found
Any relevant log output from /var/log/anchore:
Above.
What docker images are you using:
Above
How to reproduce the issue:
Above.

First, thanks @evansgp for a great write-up. I'm looking into this now.

Thanks for looking into it @zhill ! Let me know if you need more info.

@evansgp, I linked a potential fix for this issue. I discussed with @zhill and we think that it would be easier to allow configuration of the actual clamav commands we use than to deal with untarring (which in itself can be a PITA). The linked proposal will allow clamscan or freshclam args to be added via the analyzer_config.yaml, so we can override the default values used by those commands if necessary.

@dakaneye can this be closed as complete?

Closed by #625

@evansgp
Please how did you embed the EICAR signature into the image file? I am trying to have an image with embedded malware to test with Clamav


[Create news] User can create news with more than one same tag

Environment: Windows 10 x64, Mozilla Firefox 76.0 (64-bit)
Reproducable: always
Build found: commit b517ccb
Steps to reproduce

Go to GreenCity https://ita-social-projects.github.io/GreenCityClient/#/welcome
Log into the system.
Click on 'Eco news' link in the header.
Click on 'Create news' button.
Enter valid data in 'Title' and 'Content' fields (e.g. "NASA photo showing the Earth's atmosphere").
Select 1 tag (e.g. "News").
Click on 'Preview' button.
Click on 'Back to editing' link.
Deselect selected tag.
Select tag from step 6 again.
Drag & drop image into 'Picture' field (JPEG or PNG only less than 10 MB, e.g. image from attachment).
Click on 'Publish' button.

Actual result
News are published with two same tags.

Expected result
News are published with only one same tag. All displayed tags are unique.

User story #548
Test case

Verified.


[docs] add api key samples

like: https://github.com/tilezen/vector-datasource/issues/1155
it can be confusing to know how to add an API key to the end of a query and so we should add samples in the docs (at least in 'get started') like api_key=mapzen-xxxxxx in case the link to mapzen.com/documentation/overview isn't obvious.

I dig mostly reverting https://github.com/tilezen/joerd/commit/73958bd88104b7d62cef7d5b6cd048338736c85f#diff-855958b9614db5d6630b10c60ab35e42 ;)

oy


Issue with /docs/tutorials/kubernetes-basics/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:

Go to https://kubernetes.io/docs/tutorials/kubernetes-basics/
Shrink browser window to around 1000px wide (or something narrow enough to trigger the tablet view of the page)
Text is cut off on the left side of the page

Environment: macOS 10.12.4, Google Chrome 58.0.3029.110
Proposed Solution: ¯\_(ツ)_/¯
Thanks for looking into it!

Looks like <main class="content"> element has a margin-left:200px on the css causing this. This rule seems to only exist in kubernetes-basics tutorial and does not seem like it serves a purpose other than causing this bug.

/cc @BenHall 👋

/assign @BenHall 👋

Thanks for the feedback. We've improved the look and feel of the layout which will hopefully create a much better experience.

@BenHall thanks! looks much better on w=1000px now. Closing.


[SPARK-30334][SQL] Introduce as_json for marking a column as JSON data

What changes were proposed in this pull request?
Semi-structured data is used widely in the data industry for reporting events in a wide variety of formats. Click events in product analytics can be stored as json. Some application logs can be in the form of delimited key=value text. Some data may be in xml.
The goal of this project is to be able to signal Spark that such a column exists. This will then enable Spark to "auto-parse" these columns on the fly. The proposal is to store this information as part of the column metadata, in the fields:

format: The format of the semi-structured column, e.g. json, xml, avro
options: Options for parsing these columns

This PR introduces the function "as_json", which accomplishes this for JSON columns.
Why are the changes needed?
Simplify the handling of semi-structured columns in Spark, initially for JSON data.
Does this PR introduce any user-facing change?
Introduces a new function called as_json
How was this patch tested?
Unit tests

Test build #115643 has started for PR 26987 at commit 576af91.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20442/
Test PASSed.

Test build #115643 has finished for PR 26987 at commit 576af91.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AsJson(json: Expression, formatOptions: Map[String, String], child: Expression)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115643/
Test FAILed.

cc @marmbrus

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26826/
Test PASSed.


Add pre-commit linter for Conventional Commits

[ ] Write TECHNICAL-SETUP.md for pre-commit and CONTRIBUTING.md for Commit message formats
[ ] Add linter and .pre-commit-config.yaml

@hallazzang Could you make PR for this?


docs: design nsa spec support

Add design for NSA specification
Signed-off-by: chen-keinan<EMAIL_ADDRESS>

Closing - a new design #961  for compliance report will replace it


tuya smart curtain

@iphong  when I send  55 AA 00 06 00 08 02 02 00 04 00 00 00 32 47 this command ,curtain goes to 44% but it should goes  at 50% ,another issue is it does not report updated position .to get updated position I have to restart the curtain module every time after setting new position.

I think this is meant for another project, because that is not making sense to me.  I see an esphome curtain project under the repositories of the user you referenced.

@make-all understood but i don't have a idea that how to deal with this thing !


How to send command to tmux session inside another tmux session

This question on stackoverflow explains how to send command to another tmux session https://stackoverflow.com/questions/8518815/how-to-send-commands-when-opening-a-tmux-session-inside-another-tmux-session
However, it did not work with this repository's tmux config. Is there something I'm missing?

Hello @kaskavalci,
I'm not sure about what you're asking. With my configuration, send-prefix bindings are configured the following way:
$ tmux list-keys | grep send-prefix
bind-key    -T prefix       C-a               send-prefix -2
bind-key    -T prefix       C-b               send-prefix

It means both C-a and C-b are valid prefixes and hitting C-a or C-b twice will send C-a or C-b to the terminal.
Whatever you're trying to achieve, please validate it's working with tmux's default configuration:
tmux -f /dev/null

My bad, was trying to execute some commands which is not configured on remote tmux. Thanks for prompt answer and awesome config :)


After clicking new block and not placing down (editing another object etc.), sometimes the editor will crash

There have been many changes since, and I believe this issue was fixed at some point? If not, please reopen.


[epic] proposal: Should provide better composition behavior

This is a tracking issue for Model Composition.
Currently at:
http://sdformat.org/tutorials?tut=composition_proposal (permalink)
sub-tasks and tentative dates

Specification / docs

[x] update Pose Frame Semantics proposal with details on implementation of parsing stages osrf/sdf_tutorials#28 (Target: June 25)
[x] finish proposal for composition interface api https://github.com/osrf/sdf_tutorials/issues/12, https://github.com/osrf/sdf_tutorials/pull/3 (Target: July 23 ~May 28~)
[x] add parsing stages to Composition proposal #280 (Target: July 16)

Implementation

[x] allow frames in //joint/child and //joint/parent #204 (Target: July 16)
[x] add Model::GetModel API's and make nested models (issue: #283, pr: #316, https://github.com/osrf/sdf_tutorials/pull/34) (Target: August 13)
[x] implement support for (implicit and/or explicit) nested canonical links (https://github.com/osrf/sdf_tutorials/pull/36, issues: #342, #343, prs: #341, https://github.com/osrf/sdf_tutorials/pull/40) (Target: September 17)
[x] allow "drilling into" scoped names #293 (Target: November 5)

[x] make include work as nested models https://github.com/osrf/sdformat/issues/284 (Target: November 5)
[x] Handle unnesting design docs https://github.com/osrf/sdf_tutorials/pull/41 (Target: October 1)

[x] add support for new composition semantics

[x] //include/placement_frame (issue: #319) (August 6)
[x] add //model/@placement_frame to composition proposal (issue: #335) (Target: September 25)
[x] interface api (Jan. 28 - https://github.com/osrf/sdformat/issues/430)

Release Dates

libsdformat11

Prototype

[x] Without interface API: Target: November 26
[x] With interface API: Target: Feb. 4

Release (Target: Mar. 31)

Downstream:

Drake: https://github.com/RobotLocomotion/drake/issues/14295

Prototype (Target: January 28)
[x] Release (Target: Mar. 15): https://github.com/RobotLocomotion/drake/issues/14295

Gazebo Ignition Edifice:

Prototype (Target: January 14)
Release (Target: ~Jan 2021~ Mar 31, 2021) - actual release

Feature Freeze: Mar. 17
Code Freeze: Mar. 24

[x] Final touches: https://github.com/ignitionrobotics/ign-gazebo/issues/479

Gazebo Classic: out of scope

I noticed that the current proposal is focused on poses. So this may be out of scope for this task, but I'd like to mention that an important aspect of composition is injecting plugins into SDF files.
The proposal says that //include/plugin is generally Gazebo-specific, but this is a concept we've also adopted into Ignition. My immediate use case is to have a model described once, and augment it with simulator-specific plugins as needed. Using the <include> tag, this is already possible for:

//model/plugin
//actor/plugin

But not for:

//model/link/sensor/plugin
//model/link/visual/plugin

Using the <include> tag, this is already possible for [...]

Can you file a PR against the legacy Composition tutorial to make this existing contract explicit? (e.g. point out where in Gazebo it's supported, and other downstream applications if applicable?)
http://sdformat.org/tutorials?tut=composition&cat=specification&

At a (potentially distracting) "philosophical" level:
It's unclear to me what "adopted into Ignition" really means - can you point to other use cases of  //plugin outside of Gazebo / its upstream libraries?
FTR, my understanding of Ignition is that it aims to be individual libraries, but to me it still smells like it's application layers of Gazebo just broken out into separate repos. (At least, that is how it has been working with SDFormat, in both the software library and the specification.)
Totes down for it evolving it to that point, but I just want to make sure that things aren't claimed to be individual libraries if they aren't yet, and that we take the explicit steps to take them away from application layers of Gazebo to actual libraries?

Uh oh. I must eat my own words.
I am completely incorrect; it's in the documentation here as @scpeters pointed out:
http://sdformat.org/tutorials?tut=composition&cat=specification&#including-a-model
That being said, I would still love to have this feature be tracked.
Talking with @scpeters, he will open up an issue to track this.
Sorry for the noise!!!

Talked it more over w/ @scpeters and @azeey, and @scpeters will file an issue about injecting //plugin (and even custom tags) on elements; still dunno if it should be physical or just XML coordinates.

updating proposal with details on parsing implementation in https://github.com/osrf/sdf_tutorials/pull/28

Posted announcements:

https://discourse.ros.org/t/sdformat-1-8-composition-proposal/16630/2
https://community.gazebosim.org/t/sdformat-1-8-composition-proposal-cross-post-with-ros-discourse/667

I just noticed the follow up questions now and I'm not sure about where the conversation currently stands, so I'll just clarify some things.

It's unclear to me what "adopted into Ignition" really means - can you point to other use cases of //plugin outside of Gazebo / its upstream libraries?

This issue has some examples: https://github.com/osrf/sdformat/issues/93

my understanding of Ignition is that it aims to be individual libraries, but to me it still smells like it's application/framework layers of Gazebo just broken out into separate repos

The separate libraries are useful on their own without Gazebo. The same way you're using SDF outside Gazebo, there are projects using Ignition Rendering, GUI, Sensors, Math, Common, Math, Transport... Some public examples are tesseract-ignition and ign-rviz.

explicit steps to take them away from application layers of Gazebo to actual libraries?

We're all ears. What explicit steps are needed for them to smell like actual libraries to you? Perhaps this is not the right place to follow up on this discussion, but you're welcome to start a conversation on https://community.gazebosim.org/.

And the reason I ended up in this issue again was to cross-reference this design proposal for Gazebo, which I think is relevant to this issue. It talks about composition beyond poses, with the addition, removal or modification of included models.
https://github.com/ignitionrobotics/design/pull/5

\cc @claireyywang

The last PR on this epic has now been merged, so I think we can close this. @EricCousineau-TRI ?

Sounds great!!!


Unable to play ios local videos on device

hello,
I’m trying to play local videos, its working well on android, coming to ios when iam assigning media path to videoView source I’m getting reference not set to an instance of an object error on MediaFailed event handler. If I given source is http resource its working fine, problem with the only local videos.
Error StackStrace:
at Plugin.MediaManager.VideoPlayerImplementation.OnMediaFailed () [0x00017] in <36b6ccc6927a4997a8ce5e9f38386937>:0
at Plugin.MediaManager.VideoPlayerImplementation+d__48.MoveNext () [0x0015b] in <36b6ccc6927a4997a8ce5e9f38386937>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/exceptionservices/exceptionservicescommon.cs:143
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00047] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:187
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:156
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:128
at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:113
at Plugin.MediaManager.Abstractions.Implementations.MediaManagerBase+d__79.MoveNext () [0x00100] in <9eb99f10a90a43b496d4125d286ef6be>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/exceptionservices/exceptionservicescommon.cs:143
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00047] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:187
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:156
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:128
at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:113
at Plugin.MediaManager.Abstractions.Implementations.MediaManagerBase+<b__70_0>d.MoveNext () [0x00062] in <9eb99f10a90a43b496d4125d286ef6be>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/exceptionservices/exceptionservicescommon.cs:143
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x00047] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:187
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x0002e] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:156
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x0000b] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:128
at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in /Users/builder/data/lanes/3969/8b53676d/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/TaskAwaiter.cs:113
at Plugin.MediaManager.Abstractions.Implementations.MediaManagerBase+d__77.MoveNext () [0x0006a] in <9eb99f10a90a43b496d4125d286ef6be>:0
code:
private async void BtnPickVideo_Clicked(object sender, EventArgs e)
{
await CrossMedia.Current.Initialize();
MediaFile file = null;
file = await CrossMedia.Current.PickVideoAsync();
if (file != null)
{
try
{
UploadVideoView.Source = file.Path;
UploadVideoView.IsVisible = true;
UploadVideoView.Focus();
await this.MediaManager.Play();
}
catch (Exception ex)
{
System.Diagnostics.Debug.WriteLine(ex.StackTrace);
}
}
}
File types: .mov , .mp4
Info plist :
NSAppTransportSecurity

NSAllowsArbitraryLoads

I am getting the same issue. any assistance ?

I saw an iOS post along roughly similar lines where the solution was to prepend "file://", but that's likely what you're already doing. Am interested because planning to use local video files myself. My files are previously downloaded, not in the bundle.

@BillFulton Yes I have tried that - without success. it looks like it may have been fixed in 0.0.5 - but i can't use that because I'm also using the .Forms package - and that doesn't support 0.0.5 yet :(

@mrwcjoughin Hope it will be fixed soon then. Looks like a really great package  :)

I also am unable to play local video or audio from iOS device, but my symptom is a bit different - the request is just ignored with no error. My local files are not in the bundle, they are in a subfolder of Library. My complete code is attached. For both video and audio, it works with web uri but not with file uri. Have not tried Android.
ShowVideoPage.txt

Re .-1, I should have mentioned it is in a Xamarin Forms PCL.

What i've done for now is use a webview and play the video through there using the HTML video tag - it works well

I can confirm that appending the file path with "file://" works for iOS with version 0.4.4 of this plugin.
if (Device.RuntimePlatform == Device.iOS)
{
result = "file://" + file.Path;
}
else
{
result = file.Path;
}

how do you embedded the video? i am having a similar problem but i notice the mp4 is not on my bundle

what would be the path for a video on android in Resources/raw? thanks

@Hungeberg Can you please give more details on that?
I tried prepending file:// and worked on Android for playing local video.
But I'm not able to play video on iOS, downloaded to local storage using
public string GetDownloadPath(string filename)
{
    string documentsPath = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
    var path = Path.Combine(documentsPath, filename);
    return path;
}

Thanks in advance! 🙂

I am able to play below url
"https://ia800201.us.archive.org/12/items/BigBuckBunny_328/BigBuckBunny_512kb.mp4"
and Unable to play Youtube URL or Embedded YouTube URL like "https://youtu.be/luDyX0kYzY4" or "https://www.youtube.com/watch?v=luDyX0kYzY4" for that i need to change any thing or what how to play youtube url can you help me please

So sorry, I do not have an idea on that.

On 23 Aug 2018, at 4:14 pm, sw-ms-milangohil<EMAIL_ADDRESS>wrote:
I am able to play below url
"https://ia800201.us.archive.org/12/items/BigBuckBunny_328/BigBuckBunny_512kb.mp4 https://ia800201.us.archive.org/12/items/BigBuckBunny_328/BigBuckBunny_512kb.mp4"
and Unable to play Youtube URL or Embedded YouTube URL like "https://youtu.be/luDyX0kYzY4 https://youtu.be/luDyX0kYzY4" or "https://www.youtube.com/watch?v=luDyX0kYzY4 https://www.youtube.com/watch?v=luDyX0kYzY4" for that i need to change any thing or what how to play youtube url can you help me please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/martijn00/XamarinMediaManager/issues/190#issuecomment-415303854, or mute the thread https://github.com/notifications/unsubscribe-auth/AKoBwXq3KrtOYJHMz9N9JkfWsl_6kZQxks5uTkgugaJpZM4NRk2R.


Various --profile fixes

Weird, this builds for me locally.  I'll take a look at it tomorrow.

Works now.

You can now enable the profiler (and set the profiling threshold) via set_option as well:
set_option profiler true
set_option profiler.threshold 0.01 -- 10ms, defaults to 0

-- profiling is enabled here


Implement mocking for properties without getters by using es6 Proxy

Hi,
with the current implementation it is not possible to mock properties that don't have getters. Trying to do something like when(mockedFoo.propertyWithoutGetter) will result in a thrown error.
Since it's not possible to get information about such properties by reflection, my idea was to add property descriptors on demand (if when is used). This is done using an es6 Proxy with a catch-all handler intercepting property access on the mock object.
What do you think about that?
Regards, Markus
Btw.: Thanks for this awesome mocking library :-)

@Markus-Ende thanks for PR, I will take a look at it tommorow.

@Markus-Ende it looks nice but we got to check if Proxy is available and use it also for methods to support interfaces. You want to implement this? Or I can merge it branch and continue your work.

@NagRock I can look into it, but I don't fully understand what you mean. You want me to try if Proxies also work for interface mocking? Is there some ungoing work on this? I saw that you mentioned you would open another issue for this in #25 Can we open an issue to discuss?

@Markus-Ende First of all Proxy was introduced in ES6 and there is no polyfill available. When someone for some reason wants to transpile TS to ES5 he will get en error of unknown type usage. We should add Proxy existence check for that reason. Secondly we are thinking about mocking interfaces and think Proxy could be a good option to do so. Because you introduces Proxy @NagRock thought you can handle that as well. An issue for discussing it is desirable.

@viman good point on the Proxy existence check, I'll add that. I will also look into the interface mocking. But maybe you could add the property mocking before that is finished? Currently, if you try to mock properties that don't have getters an uncomprehensive error message is thrown.

@NagRock I updated the PR. Added some documentation and surrounded the Proxy by an existence check.

@Markus-Ende See my comment in you PR. Everything else seems nice. BTW great contribution with that :)

@Markus-Ende thanks!

Released in https://github.com/NagRock/ts-mockito/releases/tag/v2.2.1


Create Snapshot Debugging with ASP.NET Core doc

See https://azure.microsoft.com/en-us/blog/snapshot-debugger-for-azure/ for more detail on the topic. Ideally, this doc would be listed in the TOC under Testing and debugging.

@scottaddie is the scope of this a sample project and step by step instructions on setting up? Looks like there is some Core 2.0 content here
https://docs.microsoft.com/en-us/azure/application-insights/app-insights-snapshot-debugger

Can we just reference the existing azure doc from our TOC?

@danroth27 We certainly can. Do you have a link to the doc?

@scottaddie the link I provided has a pretty straight forward setup for setting this up (I have followed it on apps I have built with no issue)
https://docs.microsoft.com/en-us/azure/application-insights/app-insights-snapshot-debugger

@isaac2004 I appreciate the link! Thanks for all your help with our docs.


failing test: Failed: TestGeocodeFarm: No result found

Maybe I screwed something with virtualenv? I admit that I use it for second or third time, and first time since I installed this computer about 18 months ago.
sudo pip3 install virtualenv
virtualenv virtualenvironment
cd virtualenvironment/bin/
source activate
cd ..
cd ..
pip3 install -e ".[dev]"
pytest

========================================================================================= FAILURES ==========================================================================================
_______________________________________________________________________________ TestGeocodeFarm.test_geocode ________________________________________________________________________________
test/geocoders/geocodefarm.py:35: in test_geocode
    location = await self.geocode_run(
test/geocoders/util.py:90: in geocode_run
    pytest.fail('%s: No result found' % cls.__name__)
E   Failed: TestGeocodeFarm: No result found
___________________________________________________________________________ TestGeocodeFarm.test_location_address ___________________________________________________________________________
test/geocoders/geocodefarm.py:42: in test_location_address
    await self.geocode_run(
test/geocoders/util.py:93: in geocode_run
    self._verify_request(result, exactly_one=payload.get('exactly_one', True),
test/geocoders/util.py:173: in _verify_request
    assert received == expected
E   AssertionError: assert (55.756542205...ssia, Russia') == (55.755891350...scow, Russia')
E     At index 2 diff: 'Moscow, Russia, Russia' != 'Moscow, Russia'
E     Use -v to get the full diff
===================================================================================== warnings summary ======================================================================================
(snip)

Well, it looks like the error is still there. I have just been getting connection refuses, and when they were gone, the tests have also failed with the Moscow, Russia, Russia error.
That's exactly what is currently being returned from the API:
$ curl -s 'https://www.geocode.farm/v3/json/forward/?addr=moscow' | jq '.geocoding_results.RESULTS[0].formatted_address'
"Moscow, Russia, Russia"

Sigh...

6 months later it is still "Moscow, Russia, Russia", thus I'm definitely removing GeocodeFarm geocoder.

Closing, as GeocodeFarm has been removed in #445