Minimal go images

Build plan update: Base image is now specified in the setup phase
Provider API update: Providers can specify a run image in the start phase. If this image is provided then we will add the following to the generated Dockerfile

FROM {run_image}
WORKDIR /app/
COPY --from=0 /app /app/

so that only the app source and any build artifacts will be present in the final build. This is useful for compiled langauges that can produce a single staticically linked binary.

Compile Go with CGO_ENABLED=0

The result is that the go image produced for examples/go-mod drops from 1.15GB to 76MB
The run image can be overridden by setting the NIXPACKS_RUN_IMAGE environment variable.

Suggested edit:
diff --git a/src/nixpacks/mod.rs b/src/nixpacks/mod.rs
index f5b49af..fc8c2b3 100644
--- a/src/nixpacks/mod.rs
+++ b/src/nixpacks/mod.rs
@@ -513,20 +513,22 @@ impl<'a> AppBuilder<'a> {
             .unwrap_or_else(|| "".to_string());

         // If we haven't yet copied over the entire app, do that before starting
-        let mut start_files: Vec<String> = Vec::new();
-        if build_phase.only_include_files.is_some() {
-            start_files.push(".".to_string());
-        }
+        let start_files = if build_phase.only_include_files.is_some() {
+            vec![String::from('.')]
+        } else {
+            vec![]
+        };

-        let mut run_image_setup: Option<String> = None;
-        if let Some(run_image) = start_phase.run_image {
-            run_image_setup = Some(formatdoc! {"
+        let run_image_setup = if let Some(run_image) = start_phase.run_image {
+            Some(formatdoc! {"
                 FROM {run_image}
                 WORKDIR /app/
                 COPY --from=0 /app /app/
             ",
             run_image=run_image})
-        }
+        } else {
+            None
+        };

         let dockerfile = formatdoc! {"
           FROM {base_image}


Rectification

I can not connect my polkadot.js to https://portal.astar.network/#/balance/wallet. Anyone know the steps?

Please log it with them, no idea about different apps, this is focussed on phishing operations only.


Support full Unicode in the database

This is done by using utf8mb4 instead of MySQL’s utf8 charset which (spoiler alert) isn’t proper UTF-8 at all.
See https://mths.be/utf8mb4.
(Submitting as a patch because this may require changes to your local setups.)

Applied in 5891791b2379a5f15bc13b839975af6c6c031ff3


Upgrade templates without git incantation

Fixes #990.
Some details on which I would like feedback:

I have proposed the name spin templates upgrade rather than update.  This aligns with the plugins UI, where 'update' refers to updating the catalogue and upgrade is used to actually install a new version.  However, update is established in spin templates install --update (easy to alias), and is misleading if a user is moving back to an earlier version of Spin.
~I have defaulted it to upgrading templates from all known repositories.  If the user wants to be selective, they can pass --ask.  An alternative approach would be to prompt by default, and require --all to upgrade all without prompting.~  After feedback, it now prompts by default, with a --all flag to upgrade all without prompting.
I have allowed the user to upgrade a specific repo (optionally, to a specific tag) via the --repo/--branch options.  This is an exact synonym for install --update - is it worth bothering?  I'm leaning against it now.  (The user could pass --ask and just select the one repo, but could not then select a specific tag.)

~The report at the end is a work in progress.  It will not, actually, boo errors (deserve it though they might).~  This is now fixed: have at it.
The ~--ask~ prompt UI is via the dialoguer crate and looks like this:

I'm not much in love with it but I don't want to invest in re-implementing it.  If there are better Rust terminal libraries then I'm happy to change.
Signed-off-by: itowlson<EMAIL_ADDRESS>

prompt by default, and require --all to upgrade all without prompting

I like this one. this is also inline with our spin new --accept-defaults UX.

I have allowed the user to upgrade a specific repo (optionally, to a specific tag) via the --repo/--branch options

hm, i can see it can be useful when user is working on changing template from e.g. fork of a repo.

@rajatjindal @mikkelhegn Thanks for the feedback - it now prompts by default.

However, update is established in spin templates install --update (easy to alias), and is misleading if a user is moving back to an earlier version of Spin.

So are we keeping install --update for backwards compat? My vote would be to change it to install --upgrade if we are choosing to distinguish update and upgrade. Better to eliminate the confusion now than it become bothersome post 1.0

Yes, if we agree that the command should be called upgrade, we should change the flag to --upgrade with an alias to --update for back compat.  I was waiting for agreement on the new command name but there seems to be general acceptance.  I've made that change.
(I have left the Rust field as being called update for now, because that term is widely used in the template installation code.  It would be good to change it to stay in sync with the UI, but I don't want to clutter this PR with renaming noise.)

LGTM code-wise. I am +1 for the experience discussed above.

Awesome upgrade! 💯


WIP: Rework Analyzer Topology

Based on Alioune's suggestions in https://github.com/mehab/DTKafkaPOC/issues/50#issuecomment-1288799243.
The topics used by this application have been renamed to better signal their purpose:

Topic
Description
Key
Value

component-analysis
Components submitted by the API server for analysis (prev. EventNew)
Component UUID
Component Details

component-analysis-cpe
Components re-keyed to CPE
Component CPE
Component Details

component-analysis-purl
Components re-keyed to PURL
Component PURL
Component Details

component-analysis-swid
Components re-keyed to SWID
Component SWID Tag ID
Component Details

component-analysis-vuln
Vulnerability analysis results as emitted by individual analyzers (OSS Index, Snyk)
Component Identity (CPE, PURL, SWID Tag ID)
Vulnerability Details, Analyzer Identity

component-vuln-analysis-result
Vulnerability analysis results for consumption by API server
Component UUID
Vulnerability Details, Analyzer Identity

This implementation will make all dedicated producers using the producer API (org.acme.producer package) obsolete. The same is true for all individual consumers and streams defined in the org.acme.consumer package.
While the application is running, the topology can be visualized in the Quarkus dev console at http://localhost:8089/q/dev/io.quarkus.quarkus-kafka-streams/kafka-streams-topology

@syalioune Please don't sweat it, it's still very rough on the edges and has lots of duplicated and unused code. :sweat_smile:

Current output of scanning two components with the same PURL twice in close succession:
Received component: 2bda3139-647f-47ff-9c35-ffc16adf3076
Re-keyed component: a4396bd6-631c-428e-822a-f2759a50a6df -><EMAIL_ADDRESS>Joined<EMAIL_ADDRESS>-><EMAIL_ADDRESS>vulnerabilityResults=null)
Cache miss<EMAIL_ADDRESS>Performing OSS Index analysis for 1 components<EMAIL_ADDRESS>Performing Snyk analysis for 1 components<EMAIL_ADDRESS>Re-keying result<EMAIL_ADDRESS>-> a4396bd6-631c-428e-822a-f2759a50a6df
Re-keying result<EMAIL_ADDRESS>-> a4396bd6-631c-428e-822a-f2759a50a6df
Re-keying result<EMAIL_ADDRESS>-> a4396bd6-631c-428e-822a-f2759a50a6df

Received component: 2bda3139-647f-47ff-9c35-ffc16adf3076
Re-keyed component: a4396bd6-631c-428e-822a-f2759a50a6df -><EMAIL_ADDRESS>Joined<EMAIL_ADDRESS>-><EMAIL_ADDRESS>vulnerabilityResults=[org.acme.model.VulnerablityResult@32678adb, org.acme.model.VulnerablityResult@3d7ef798, org.acme.model.VulnerablityResult@6c994225])
Cache hit<EMAIL_ADDRESS>

@syalioune Please don't sweat it, it's still very rough on the edges and has lots of duplicated and unused code. 😅

Duely noted ! patiently waiting to test it 😉


the problem for s3read can't  be fixed

library(s3mpi)
data_train <- s3read(name = "data_train_extra_features.RDS",path =  "s3://[redacted]/Blackwell/shared/Train/")

sh: 1: : Permission denied Error in gzfile(file, "rb") : cannot open the connection In addition: Warning messages: 1: In fetch(path, storage_format, bucket_location, ...) :   Nothing exists for key s3:///data_train_extra_features.RDS 2: In gzfile(file, "rb") :   cannot open compressed file '/tmp/RtmploRNgS/file194aa63c626be', probable reason 'No such file or directory'

This is the error that you get when you read a key that does not exist. Are you reading the correct key? How did you s3store the data?
@robertzk @kirillseva We may want to make this kind of "key not found" error more explicit.

My colleague may install the old version. For me, it always get this error.
When I use s3.get to read data from s3, it works. But for s3read, it aways
get this error.
On Thu, Jul 27, 2017 at 11:40 AM, Peter Hurford<EMAIL_ADDRESS>wrote:

This is the error that you get when you read a key that does not exist.
Are you reading the correct key? How did you s3store the data?
@robertzk https://github.com/robertzk @kirillseva
https://github.com/kirillseva We may want to make this kind of "key not
found" error more explicit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318450342, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtcYVHeK2Zl_z8D6E4ycuEmiK3Yjpks5sSNmLgaJpZM4OlrHX
.

For the simplest exmaple, it still does not work
On Thu, Jul 27, 2017 at 11:58 AM, Feng Li<EMAIL_ADDRESS>wrote:

My colleague may install the old version. For me, it always get this
error. When I use s3.get to read data from s3, it works. But for s3read, it
aways get this error.
On Thu, Jul 27, 2017 at 11:40 AM, Peter Hurford<EMAIL_ADDRESS>wrote:

This is the error that you get when you read a key that does not exist.
Are you reading the correct key? How did you s3store the data?
@robertzk https://github.com/robertzk @kirillseva
https://github.com/kirillseva We may want to make this kind of "key
not found" error more explicit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318450342, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtcYVHeK2Zl_z8D6E4ycuEmiK3Yjpks5sSNmLgaJpZM4OlrHX
.

@Bee-zest So s3mpi:::s3.get("s3://spotloan-marketing/Blackwell/shared/Train/data_train_extra_features.RDS", cache = FALSE) works for you? How do you use s3.get to get your data?

Thanks @Bee-zest -- good point, I get a similar error.
R-ENGINES> s3read('idontexist')
ERROR: S3 error: 404 (Not Found):

Historically we've never minded this, but given that we're trying to improve the public-facing aspects of these packages it makes sense to wrap this with a nicer error.

@robertzk I expanded on that and filed https://github.com/robertzk/s3mpi/issues/73

No, the same error with s3read. The
data_train <-
s3.get("s3://spotloan-marketing/Blackwell/production/Train/2017-06-30_Blackwell.RDS")
works for me.
On Thu, Jul 27, 2017 at 12:12 PM, Peter Hurford<EMAIL_ADDRESS>wrote:

@robertzk https://github.com/robertzk I expanded on that and filed #73
https://github.com/robertzk/s3mpi/issues/73
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318459002, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtS8TaPdMm3Wxwvlq8HsrP0wlUVfrks5sSOEfgaJpZM4OlrHX
.

@Bee-zest What if you set your s3 buckets:
options(s3mpi.path = "s3://spotloan-marketing/")
data_train <- s3read("Blackwell/production/Train/2017-06-30_Blackwell.RDS")

Got this error
[image: Inline image 2]
On Thu, Jul 27, 2017 at 1:13 PM, Robert Krzyzanowski <
<EMAIL_ADDRESS>wrote:

@Bee-zest https://github.com/bee-zest What if you set your s3 buckets:
options(s3mpi.path = "s3://spotloan-marketing/")data_train <- s3read("Blackwell/production/Train/2017-06-30_Blackwell.RDS")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318473274, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtfbvjYHEhJjCNwC_jJsArSBJo9IUks5sSO9QgaJpZM4OlrHX
.

Thanks @Bee-zest -- can you post in the GitHub URL rather than email? The image doesn't seem to have been attached.
https://github.com/robertzk/s3mpi/issues/72

options(s3mpi.path = "s3://spotloan-marketing/")
data_train <- s3read("Blackwell/production/Train/2017-06-30_Blackwell.RDS")

ERROR: Parameter problem: Expecting S3 URI instead of 'Blackwell/production/Train/2017-06-30_Blackwell.RDS'
Show Traceback
Rerun with Debug
Error in gzfile(file, "rb") : cannot open the connection In addition: Warning messages:
1: running command 's3cmd get Blackwell/production/Train/2017-06-30_Blackwell.RDS /tmp/RtmploRNgS/file194aa7d15953 --bucket-location US --no-progress  ' had status 1
2: In gzfile(file, "rb") :
cannot open compressed file '/tmp/RtmploRNgS/file194aa7d15953', probable reason 'No such file or directory'

@Bee-zest Strange, it doesn't seem to be using the path. Try:
data_train <- s3read("Blackwell/production/Train/2017-06-30_Blackwell.RDS", "s3://spotloan-marketing/")

The same error.. Hi robertzk. Do you have old version?

@Bee-zest What version are you on? We're the developers, so naturally we have the latest version. ;)

yes. I think I'm using the latest version. I installed the packages from your github homepage yesterday.

Hi, could you please send me the old version of s3mpi? I can't fix the
problem of the latest version
On Thu, Jul 27, 2017 at 2:42 PM, Peter Hurford<EMAIL_ADDRESS>wrote:

@Bee-zest https://github.com/bee-zest What version are you on? We're
the developers, so naturally we have the latest version. ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318494756, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtQkxkR1IkA83gAch8zdET1LwW-Qwks5sSQRFgaJpZM4OlrHX
.

s3read <- function(name = NULL, .path = s3path(), cache = TRUE, ...) {
if (is.null(name)) name <- grab_latest_file_in_s3_dir(.path)
if (substr(.path, nchar(.path), nchar(.path)) != "/") { .path <-
paste0(.path, "/") }
s3key <- paste(.path, name, sep = '')
if (!isTRUE(cache) || is.null(getOption('s3mpi.cache'))) {
value <- s3.get(s3key, ...)
} else if (is.not_cached(value <- s3cache(s3key))) {
value <- s3.get(s3key, ...)
s3cache(s3key, value)
}
s3normalize(value, TRUE)
}
options(s3mpi.path = 's3://spotloan-marketing/Blackwell/production/Train/')
data_train1 <- s3read(name = "2017-06-30_Blackwell.RDS")
nrow(data_train1)
I check your previous function for s3read. It now works. But why the latest
one doesn't work
On Fri, Jul 28, 2017 at 8:53 AM, Feng Li<EMAIL_ADDRESS>wrote:

Hi, could you please send me the old version of s3mpi? I can't fix the
problem of the latest version
On Thu, Jul 27, 2017 at 2:42 PM, Peter Hurford<EMAIL_ADDRESS>wrote:

@Bee-zest https://github.com/bee-zest What version are you on? We're
the developers, so naturally we have the latest version. ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318494756, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtQkxkR1IkA83gAch8zdET1LwW-Qwks5sSQRFgaJpZM4OlrHX
.

Hey @Bee-zest - which version are you looking for? You can pull old versions from github by grabbing the associated tag.
git clone git@github.com:robertzk/s3mpi.git
cd s3mpi
git checkout <version>
Rscript --vanilla -e 'devtools::install(".")'

Thanks @Bee-zest -- it appears the rocco documentation is very out of date. The below call should install the version as of that rocco doc.
<EMAIL_ADDRESS>

Thanks Robert. I install the version 0.2.12. The same error.
On Fri, Jul 28, 2017 at 9:12 AM, Robert Krzyzanowski <
<EMAIL_ADDRESS>wrote:

Thanks @Bee-zest https://github.com/bee-zest -- it appears the rocco
documentation is very out of date. The below call should install the
version as of that rocco doc.
<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318696367, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtYtHWxEbVHp2LIVfvgfLj2snDM-aks5sSghxgaJpZM4OlrHX
.

The 0.2.12 doesn't work
On Fri, Jul 28, 2017 at 9:17 AM, Feng Li<EMAIL_ADDRESS>wrote:

Thanks Robert. I install the version 0.2.12. The same error.
On Fri, Jul 28, 2017 at 9:12 AM, Robert Krzyzanowski <
<EMAIL_ADDRESS>wrote:

Thanks @Bee-zest https://github.com/bee-zest -- it appears the rocco
documentation is very out of date. The below call should install the
version as of that rocco doc.
<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robertzk/s3mpi/issues/72#issuecomment-318696367, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdCCtYtHWxEbVHp2LIVfvgfLj2snDM-aks5sSghxgaJpZM4OlrHX
.


fix: Button Group, MenuButton, Tabs undo Redo fixed.

Description

Button Group, MenuButton and Tabs Widget Undo - Redo issues Fixed.
Also for the ButtonGroup and MenuButton widgets the re-ordering was not working.
Last, the property pane navigation for the MenuItems was not working.

Fixes #10175
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Manually on the Canvas.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/button-group-undo

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.58 (0.01)
36.83 (0)
34.86 (0)
55.88 (0.01)

:green_circle:
app/client/src/components/propertyControls/ButtonListControl.tsx
33.33 (1.82)
27.27 (0)
10.53 (-0.58)
32.88 (1.89)

:green_circle:
app/client/src/components/propertyControls/MenuItemsControl.tsx
31.51 (1.93)
22.22 (1.53)
10.53 (-0.58)
30.99 (2)

:green_circle:
app/client/src/components/propertyControls/TabControl.tsx
58.67 (6.17)
45 (6.11)
42.11 (7.11)
58.11 (6.21)

:green_circle:
app/client/src/sagas/WidgetAdditionSagas.ts
70.07 (0.5)
66.67 (5.45)
62.5 (0)
71.07 (0.58)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

:green_circle:
app/client/src/widgets/ButtonGroupWidget/component/index.tsx
24.49 (0.28)
11.02 (-0.18)
4.17 (-0.18)
26.44 (0.56)

:green_circle:
app/client/src/widgets/MenuButtonWidget/component/index.tsx
26.23 (0.81)
11.76 (0)
0 (0)
31.37 (0.76)

Thanks @rahulramesha for debugging this issue with me. Thanks @arunvjn for debugging this issue with me and suggesting the  this.updateProperties()  function call.

@rahulramesha you can see we are using orderBy multiple times in our code to order the items by index, this is done both under the Property Pane's Items Draggable List & the widgets. Can we not order the items while putting them into the DSL (Redux State) it will reduce the number of orderBy items call. It will also prevent any future mistakes if a code change happens and we forget to order the items. Please share your thoughts.

@rahulramesha you can see we are using orderBy multiple times in our code to order the items by index, this is done both under the Property Pane's Items Draggable List & the widgets. Can we not order the items while putting them into the DSL (Redux State) it will reduce the number of orderBy items call. It will also prevent any future mistakes if a code change happens and we forget to order the items. Please share your thoughts.

Not possible at this point in time, we might need to sort the items at the undo stage, this needs investigation and also need to take into account other drag and drog properties like Table columns, etc.

@yaldram Tested and working fine.

/ok-to-test sha=9ccdde3

/ok-to-test sha=abe3041


bootstrap_sdk_container: Fix a check for an official build

It should happen after we had a chance of processing input parameters, otherwise we were always operating on empty values which resulted in always having an unofficial build.

Tested locally.

Cherry picked to 3227, 3277, 3346 and 3033.


Generates invalid output with certain properties

The React team encountered an issue with Closure Compiler when compiling the React DOM bundle. It's quite specific, but it seems to somehow confuse the compiler into re-using a variable that is not safe to use given a given scenario.
https://github.com/facebook/react/pull/18670#issuecomment-623481140
Reproduction steps:

Git clone React from https://github.com/facebook/react
Checkout branch from https://github.com/facebook/react/pull/18670#issuecomment-623481140
Run yarn install
Run yarn build --type=NODE_PROD
Run yarn test-prod-build ReactDOMServerIntegrationTextarea. This will run the Jest test which shows the error.

This error should be seen:
TypeError: Cannot read property 'focusedElem' of null. It seems to be related to JSCompiler_inline_result. Which incorrectly gets re-used from a null value.
Specifically, the change that causes this is when we convert this logic:
function prepareForCommit(containerInfo) {
  ...
}
...
prepareForCommit(root.containerInfo);

to:
function prepareForCommit(containerInfo) {
  ...
  return null;
}
...
prepareForCommit(root.containerInfo) || null;

These are the flags we use for this particular build:
compilation_level: 'SIMPLE'
language_in: 'ECMASCRIPT_2015'
language_out: 'ECMASCRIPT5_STRICT'
env: 'CUSTOM'
warning_level: 'QUIET'
apply_input_source_maps: false
use_types_for_optimization: false
process_common_js_modules: false
rewrite_polyfills: false
inject_libraries: false
assume_function_wrapper: true

It would be helpful if you could narrow down a smaller repro case.

tl;dr I don't think we can reasonably investigate this without a smaller repro that doesn't require building react.
I tried to reproduce this today, but hit a roadblock.
$ yarn build --node=NODE_PROD
yarn run v1.22.4
$ node ./scripts/rollup/build.js --node=NODE_PROD
internal/modules/cjs/loader.js:583
    throw err;
    ^

Error: Cannot find module 'rollup'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/local/google/home/bradfordcsmith/b/155643260/react/scripts/rollup/build.js:3:16)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

# OK, I guess I have to do yarn install first...

$ yarn install
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got
 "10.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

I'm afraid that figuring out how to get react to build is beyond what we can reasonably do to investigate a bug. Sorry.

@brad4d I'm sorry you weren't able to build React locally, let me help! If you install the latest stable Nodejs from here:
https://nodejs.org/en/download/
You should be able to run yarn install and repro the issue as per the original post.
Unfortunately, I haven't been able to make a smaller repro of this case, probably because of how large our bundles are, which might be what adds to the complexity of this particular problem.

@trueadm I think your original description missed the yarn step before yarn build.

@trueadm yarn install fails on my system. (See above).
I'm sorry, but I'm not going to go find a Windows machine in order to repro this issue.

@brad4d This should work fine on a non Window machine. I personally use Mac/Ubuntu and the above works fine (unless you meant the inverse). The link above to install should also work for other OSs too, not just Windows. I can package up the build tomorrow for you, so there's no build step required, if that helps?

Oh sorry I missed this part in your output.
$ yarn install
yarn install v1.22.4
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got
 "10.9.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

If you run yarn install --ignore-engines it should work.

Ping just in case — reusing variables when it's not safe seems like a scary bug. I totally understand if you'd rather not spend time on it due to a too large repro case though.

Oops, sorry this fell through a hole in our triage process for so long.
I think that the steps to run this do work after adding the --ignore-engines flag.  Namely, I'm able to run:
git clone https://github.com/trueadm/react.git
cd react/
yarn install --ignore-engines
yarn build --type=NODE_PROD
yarn test --prod --build ReactDOMServerIntegrationTextarea

That said, there's no TypeError: Cannot read property 'focusedElem' of null error. The final step passes, which I think is unexpected:
$ /usr/local/google/home/blickly/repos/node_modules/yarn/bin/yarn test --prod --build ReactDOMServerIntegrationTextarea
yarn run v1.22.10
$ node ./scripts/jest/jest-cli.js --prod --build ReactDOMServerIntegrationTextarea
$ NODE_ENV=production RELEASE_CHANNEL=experimental node ./scripts/jest/jest.js --config ./scripts/jest/config.build.js ReactDOMServerIntegrationTextarea

Running tests for default (experimental)...
 PASS  packages/react-dom/src/__tests__/ReactDOMServerIntegrationTextarea-test.js
  ReactDOMServerIntegrationTextarea
    ✓ renders a textarea with a value and an onChange with server string render (39ms)
    ✓ renders a textarea with a value and an onChange with server stream render (18ms)
    ✓ renders a textarea with a value and an onChange with clean client render (21ms)
    ✓ renders a textarea with a value and an onChange with client render on top of good server markup (35ms)
    ✓ renders a textarea with a value and an onChange with client render on top of bad server markup (23ms)
    ✓ renders a textarea with a value and readOnly with server string render (26ms)
    ✓ renders a textarea with a value and readOnly with server stream render (17ms)
    ✓ renders a textarea with a value and readOnly with clean client render (21ms)
    ✓ renders a textarea with a value and readOnly with client render on top of good server markup (37ms)
    ✓ renders a textarea with a value and readOnly with client render on top of bad server markup (24ms)
    ✓ renders a textarea with a value and no onChange/readOnly with server string render (16ms)
    ✓ renders a textarea with a value and no onChange/readOnly with server stream render (16ms)
    ✓ renders a textarea with a value and no onChange/readOnly with clean client render (21ms)
    ✓ renders a textarea with a value and no onChange/readOnly with client render on top of good server markup (42ms)
    ✓ renders a textarea with a value and no onChange/readOnly with client render on top of bad server markup (24ms)
    ✓ renders a textarea with a defaultValue with server string render (16ms)
    ✓ renders a textarea with a defaultValue with server stream render (17ms)
    ✓ renders a textarea with a defaultValue with clean client render (23ms)
    ✓ renders a textarea with a defaultValue with client render on top of good server markup (37ms)
    ✓ renders a textarea with a defaultValue with client render on top of bad server markup (23ms)
    ✓ renders a textarea value overriding defaultValue with server string render (16ms)
    ✓ renders a textarea value overriding defaultValue with server stream render (17ms)
    ✓ renders a textarea value overriding defaultValue with clean client render (26ms)
    ✓ renders a textarea value overriding defaultValue with client render on top of good server markup (37ms)
    ✓ renders a textarea value overriding defaultValue with client render on top of bad server markup (22ms)
    ✓ renders a textarea value overriding defaultValue no matter the prop order with server string render (16ms)
    ✓ renders a textarea value overriding defaultValue no matter the prop order with server stream render (16ms)
    ✓ renders a textarea value overriding defaultValue no matter the prop order with clean client render (20ms)
    ✓ renders a textarea value overriding defaultValue no matter the prop order with client render on top of good server markup (34ms)
    ✓ renders a textarea value overriding defaultValue no matter the prop order with client render on top of bad server markup (21ms)

Test Suites: 1 passed, 1 total
Tests:       30 passed, 30 total
Snapshots:   0 total
Time:        2.867s
Ran all test suites matching /ReactDOMServerIntegrationTextarea/i.

Does that mean that this issue has been fixed in the meantime?

Did you check out this branch? https://github.com/facebook/react/pull/18670
I don’t believe the issue existed on master.

Ok, great, thanks for catching that!
Then the actual repro steps are:
git clone https://github.com/trueadm/react.git
cd react/
git checkout break-gcc
yarn install --ignore-engines
yarn build --type=NODE_PROD
yarn test-prod-build ReactDOMServerIntegrationTextarea

And that does give the expected error, namely (several) failed tests with:
 TypeError: Cannot read property 'focusedElem' of null
``

Yep! Let me know if you need any more info. I don't have the time to reduce it right now but I can answer questions about the build/test setup etc. The build being used should be in build/node_modules/react-dom/cjs/react-dom.production.min.js.

I think if you pass --pretty to the build command, it should disable the renaming pass and Prettify the output, which should make it easier to read and analyze.

I had a go at trying to extract the issue into a standalone reproduction, but wasn't able to trigger the inlining bug:
https://gist.github.com/developit/0c919f6a2390dba1fa2e69d075738ae2
Not sure if it's useful, but here's roughly the difference between the working version and the broken one:
https://gist.github.com/developit/40189d836529562fd48954efc25e6c4f/revisions#diff-0052e4cc6e4061a1ecbc63f9cd9e149a2785dceda16e9e8eddc53f37de501ef7L16059
You can see that the prepareForCommit() and getSelectionInformation() functions (and a few others) are dropped entirely. That makes me wonder if this caused by Closure not knowing that certain DOM methods are side-effecting.

I've just tried to follow the repro instructions posted by @blickly
Sadly the world has moved on and the break-gcc branch doesn't work with the latest version of node.
I get a failure when I try to do the yarn install.
I tried just rebasing break-gcc onto master, but there are conflicts I don't know how to resolve.

@brad4d
You got this error because package.json explicitly specifies "supported" Node versions as a list. Since Node 15 did not exist back then, it was not in the list. I've looked at the error stack to learn this, and then made this change to package.json to get yarn running again (https://github.com/trueadm/react/commit/911994149562c2699be04b99586fd61a5cddf3d8):
  "devEngines": {
-    "node": "8.x || 9.x || 10.x || 11.x || 12.x || 13.x"
+    "node": "*"

I've just pushed this fix for your convenience. I've verified that the incorrect output still reproduces with latest Node.

If this is still cumbersome to follow I can take a stab at further extracting it. But I'm hoping that was the last missing step for you to get the repro running. Let me know if not!

Here's another bug that might (or might not) be related: https://github.com/google/closure-compiler/issues/3788

Is there still anything that prevents looking at this, or is the issue in the time constraints? I worry that if each repro attempt happens months after the report, there'll be something else that breaks, and we'll keep going in cycles. The repro is ready and should work today.

OK, I've just reproduced this today.
All of the "TypeError: Cannot read property 'focusedElem' of null" error messages point one of 2 places.
    TypeError: Cannot read property 'focusedElem' of null

      51 |       if (forceHydrate) {
      52 |         ReactTestUtils.act(() => {
    > 53 |           ReactDOM.hydrate(reactElement, domElement);
         |                    ^
      54 |         });
      55 |       } else {
      56 |         ReactTestUtils.act(() => {

      at bk (build/node_modules/react-dom/cjs/react-dom.production.min.js:270:227)

OR
    TypeError: Cannot read property 'focusedElem' of null

      55 |       } else {
      56 |         ReactTestUtils.act(() => {
    > 57 |           ReactDOM.render(reactElement, domElement);
         |                    ^
      58 |         });
      59 |       }
      60 |       // We can't use the callback for resolution because that will not catch

      at bk (build/node_modules/react-dom/cjs/react-dom.production.min.js:270:227)

@gaearon I want to modify the options that are passed to closure-compiler for the build, but it's not obvious to me where I would do that in the React build setup.
Also, what command can I give that would just mean "build the JS output" without running the tests?

All of the "TypeError: Cannot read property 'focusedElem' of null" error messages point one of 2 places.

It seems like the displayed location (ReactDOM.render/ReactDOM.hydrate call) is not helpful because it excludes the actual frame where the error happens inside the bundle. I presume maybe the test runner filters out the frames inside node_modules. The actual issue is in build/node_modules/react-dom/cjs/react-dom.production.min.js.

I want to modify the options that are passed to closure-compiler for the build, but it's not obvious to me where I would do that in the React build setup.

Look for closureOptions in scripts/rollup/build.js. Note that it's being Object.assigned with a few other options at the usage site, so look for its usage too.

Also, what command can I give that would just mean "build the JS output" without running the tests?

# This only does the build:
yarn build --type=NODE_PROD

# This only runs the tests:
yarn test-prod-build ReactDOMServerIntegrationTextarea

I pushed one more commit. With that commit, you can get a faster build for easier iteration.
After you git pull, you should be able to replace yarn build --type=NODE_PROD (which takes a lot of time) with this:
yarn build react/index,react-dom/index,react-dom/test-utils,react-dom/server,scheduler --type=NODE_PROD

(builds much faster)
You'd still need to run yarn test-prod-build ReactDOMServerIntegrationTextarea after each build to actually run the tests.
Additionally, you can use the --pretty flag when building to disable the minification pass. This makes it a lot more readable. So in that case the command would be:
yarn build react/index,react-dom/index,react-dom/test-utils,react-dom/server,scheduler --type=NODE_PROD --pretty

I verified that running yarn test-prod-build ReactDOMServerIntegrationTextarea after that still produces the error, but the bundle in build/node_modules/react-dom/cjs/react-dom.production.min.js is now human readable.

To sum up, my suggested workflow is:
git pull

And then
# To build:
yarn build react/index,react-dom/index,react-dom/test-utils,react-dom/server,scheduler --type=NODE_PROD --pretty

# To test:
yarn test-prod-build ReactDOMServerIntegrationTextarea

And manually inspect build/node_modules/react-dom/cjs/react-dom.production.min.js to see the code.

Thx for the detailed instructions.
I'm seeing stuff that makes no sense to me at all.
With your new build instructions when I look in react-dom.production.min.js there is only 1 location where a focusedElem property is accessed.
    JSCompiler_inline_result = current.focusedElem;

That should narrow it down, right?
With some careful grepping I believe the reference to focusedElem we're interested in is in ReactInputSelections.js on line 119.
What's more I can see in  react-dom.production.min.js that

current gets assigned the value from selectionInformation
selectionInformation is only ever assigned the value null.

Hmmm.
I'm also really puzzled about why I see JSCompiler_inline_result used all over the place.
That is only ever supposed to be a prefix to which additional text is added for uniqueness.
The string is defined here.
https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ExpressionDecomposer.java#L787
And it is only used here, where suffixes are added.
https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ExpressionDecomposer.java#L808
I cannot explain that. Could you be using some old version of the compiler?
(Though I don't think "old compiler" really would explain it. We have always generated unique suffixes AFAIK.)

The restoreSelection method containing the problem reference to focusedElem is only called in one ReactDOMHostConfig.js on line 270, where it is passed the variable selectionInformation.
The only assignment to selectionInformation that isn't null is on line 255 where it is assigned getSelectionInformation() inside of the prepareForCommit() function.
AFAICT the version of prepareForCommit() in ReactDOMHostConfig.js is never called anywhere.
The only calls to it I can find are importing it from ReactFiberHostConfig.js
Is it possible that there are actually, intentionally, no calls to prepareForCommit() in the set of files you're passing to closure-compiler, because you expect it to be called from something outside of the compilation unit? If so, you need to define externs to prevent it from being removed.
You may find some useful advice on that here.
https://github.com/google/closure-compiler/wiki/How-do-I-make-closure-compiler-stop-breaking-my-API-by-renaming-things%3F

AFAICT the version of prepareForCommit() in ReactDOMHostConfig.js is never called anywhere. The only calls to it I can find are importing it from ReactFiberHostConfig.js

Yes, but ReactFiberHostConfig is being replaced by ReactDOMHostConfig at the build time before it is passed to the Google Closure Compiler. So any import of ReactFiberHostConfig actually becomes an import from ReactDOMHostConfig.

It seems the problem is related to a need for the project to use externs to prevent the removal of symbols that are part of its published API.

No, this is incorrect. There are no external calls to it. I would not have filed this issue if there were external calls.

I'm also really puzzled about why I see JSCompiler_inline_result used all over the place. That is only ever supposed to be a prefix to which additional text is added for uniqueness.

Yes, I also find this behavior of Google Closure Compiler confusing. This is why I filed this issue in the Google Closure Compiler repository.

Looks like I'm wrong on this one. I've extracted the standalone case, and it appears that the input passed to GCC is already wrong. I suspect that it's the earlier Rollup pass that causes the issue. Since both Rollup and GCC do optimizations.
So you were right to close the issue. My apologies.

For posterity, here's the likely cause: https://github.com/rollup/rollup/issues/4455


ObjectiveCDMDownloadTask one at a time

Thanks for sharing this great library.
I want like one task should download at a time.

Same ! want 1 item to be download at a time but 2 items is downloading at item. Is there any way to restrict it


Add debug logging of authorization subject

This adds debug logging of x.509 proxy subjects and json web token sub claims.  Debug logging for the scitokens helper wasn't working at all, and this fixes that.
Fixes #28.

Where does SetLogAuthzDebugFile get called?  By CVMFS itself?

Where does SetLogAuthzDebugFile get called? By CVMFS itself?

No, it's in the first line of CheckSciToken() in this PR.

Ok, great!


Test on video

how to test these models on .mp4 video without training the models?
what are the steps?

Hi, the code is for testing is designed for videos from the MOTChallenge dataset to be image sequence format. For example, the test sequence MOT17-01-FRCNN video sequence contains frames 000001.jpg, 000002.jpg, etc. If testing on a random .mp4 video, it is necessary to convert the video into images first. Then, it requires modification on data loading, as the code currently only supports MOT dataset. You need to build a lib\dataset\new_dataset.py similar to the lib\dataset\mot.py, and import in related files. Hope this helps!

how about taking live data (images) from camera ? for a self driving car project
will i need to adjust "lib\dataset\mot.py"  same as  mp4?

While it is possible to take live data (build a similar data loader format as you mentioned), you may need extra code for capturing images and processing them. Moreover, this project is specialized for the public detection (given by existing detectors) and may not be suitable for a self driving car project. I would recommend do some search on more efficient live private multi-object trackers.

There are tracking datasets more related to self driving, such as nuScenes and KITTI-360. You can check their leaderboards for the best performing algorithms.

This would be extremely useful. I found the current implementation too heavily reliant on config files and paths that it makes implementing a method that just does inference on a video clip too cumbersome.


Crash on join to server

When I join to server my game crash. It's start crashing when i add compact chat 2.0.2
My mods folder:
compact-chat-2.0.2
fabric-api-0.91.1+1.20.3
litematica-fabric-1.20.4-0.17.0
malilib-fabric-1.20.4-0.18.0
sodium-fabric-mc.1.20.3-0.5.5
cloth-config-13.0.121-fabric
The game crashed whilst unexpected error
Error: java.lang.NoClassDefFoundError: net/minecraft/class_2585
Minecraft Luncher Exit Code: -1
latest.log - https://pastebin.com/5yiTjE10
crash-2024-01-03_14.29.46-client.txt - https://pastebin.com/8MsN1zk0

You are using Minecraft 1.20.3, which is unsupported.
If you want to use 1.20 or 1.20.1, use Compact Chat v2.0.2
If you want to use 1.20.4 or higher, use Compact Chat v2.0.3.

Will there ever be support for 1.20.3?

1.20.4 and 1.20.3 are very similar, so no. I'd recommend you just use the latest version considering it fixes a data-loss issue introduced in 1.20.3, @Krzychu4u.


Should brew audit complain about incorrect file permissions?

A detailed description of the proposed feature
brew audit should not actually complain about "incorrect" file permissions for formulas (at least, as far as write/executable permissions for group or other), given that permissions aren't actually committed by Git.
The motivation for the feature
I have g+wx permissions for the tap directory and its contents because I use brewdo, and everything is then owned by _homebrew:_homebrew (my own user account is a member of the _homebrew group). This allows one to use Git in the tap in a much more ergonomic manner, and allows for using my own Git settings for operations. Of course, Girt can either be used manually for updating the tap or resolving issues, or moreover in my case, creating branches, performing various Git operations needed for adding a new formula, and finally making the pull request. As already stated, Git does not commit permissions in any case (at least, as far as I'm aware, and what I seemed to garner from Internet searches).
How the feature would be relevant to at least 90% of Homebrew users
It probably would not, considering most people do not use brewdo and the tap directory and its contents are all owned by user:admin or such (with no group write permissions necessary). That said, it would be of great use to brewdo users, and is trivial to implement.
What alternatives to the feature have been considered
There are none that I see without using brew do git ... for every Git command, but then that loses all shell configuration (environment variables, Git settings, etc.) for the user performing the commands, which is far from desirable.

I think it should, yes.
Please always fill in the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

If you add the necessary information to this issue (don't create a new one, please) then this issue may be reopened.

@MikeMcQuaid Okay, lots more info now.

That said, it would be of great use to brewdo users, and is trivial to implement.

Given this: we'll review a PR.

@MikeMcQuaid Thanks. I'll have a go.


Client can create blocking pool with from_url

Hi, why don't inject the instance BlockingConnectionPool using the connection_pool keyword of the StrictRedis class ?
>>> from redis import client
>>> from redis.connection import BlockingConnectionPool
>>> c = client.StrictRedis(connection_pool=BlockingConnectionPool.from_url("redis://localhost:6379/0"))
>>> c.set("foo", 1)
True
>>> c.get("foo")
'1'

This param is ready to get no only pools implemented by redis-py, also other pools implemented  by the user - inherited from the ConnecitonPool - can be injected.

@pfreixes yeah, obviously！
I mean from_url func can also use custom pools implemented by others, not just c = Redis() or c = StrictRedis()

I think what @pfreixes is asking is why do we need an extra argument to this method? Everything you need is already available by calling BlockingConnectionPool.from_url(...) and passing the return value to the connection_pool argument of a client class.
It's actually (slightly) more to type your way:
# already possible with no code changes
r = StrictRedis(connection_pool=BlockingConnectionPool.from_url('redis://localhost:6379/0'))

# your way
r = StrictRedis.from_url('redis://localhost:6379/0', connection_pool_class=BlockingConnectionPool)

Right now the redis client allows to the developer use the BlockingConnectionPool through the connection_pool keyword, therefore the developer is not restricted on that.
Accepting this MR  redis-py will get a bit of more technical debt, IMHO the current interfaces are a bit messy and they should be revisited to get a more friendly interface.

I don't think this makes sense to merge for the reasons above. You can already do everything you want to do with the existing API.


Add implementation for Semi-supervised Semantic Segmentation via Strong-weak Dual-branch Network

Thanks for your sharing and the repo is quite helpful for me to understand the work in SSL segmentation. If possible, could you add the implementation of Semi-supervised Semantic Segmentation via Strong-weak Dual-branch Network (ECCV 2020), which is a simply dual branch network. It's a quite easy and inituitive idea but I could not reproduce the results with deeplabv2. It would be great if you could add this into the repo.

Hi, thanks for your attention.
I will check it and response you ASAP.

@syorami
I have checked the paper. The paper seems focus more on weak-supervised learning.
I am sorry that we do not have enough time to reproduce it this month.

Does 'weak-supervised learning' indicate the usage of DSRG to generate weak annotations?

Oh... Yep...
They use DSRG to generate weak annotations.. So we can regard the method as a semi-supervised method.
Now we are reproducing S4GAN. We will consider reproducing this work then.

Got it. Thanks for your kindly response.


Accessibility: Aria selected property for selected date in date and time picker.

Is your feature request related to a problem? Please describe.
Users who are using accessibility software like Windows Narrator are getting incorrect information due to the aria-selected property. Currently when navigating through the date/time picker, If May 24th date is selected, Narrator is announcing as "Choose Monday, May 24th, 2021" instead of "Monday, May 24th, 2021 selected"
Describe the solution you'd like
The area selected property should be defined in a way that if a day is currently selected then navigating on it a user should not be asked to chose but instead told the date is currently selected.
Additional context
Try example on
https://reactdatepicker.com/#example-select-time.

I have not seen any activity here, we are still facing this issue. Is it okay if I raise a PR?


fix: update release instructions in maintainers guide

Summary
Fix release instructions in maintainers_guide.md
Category

[ ] slack_sdk.web.WebClient (sync/async) (Web API client)
[ ] slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
[ ] slack_sdk.socket_mode (Socket Mode client)
[ ] slack_sdk.signature (Request Signature Verifier)
[ ] slack_sdk.oauth (OAuth Flow Utilities)
[ ] slack_sdk.models (UI component builders)
[ ] slack_sdk.scim (SCIM API client)
[ ] slack_sdk.audit_logs (Audit Logs API client)
[ ] slack_sdk.rtm_v2 (RTM client)
[ ] /docs-src (Documents, have you run ./scripts/docs.sh?)
[ ] /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
[ ] /tutorial (PythOnBoardingBot tutorial)
[ ] tests/integration_tests (Automated tests for this library)

Requirements

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Also, creating the next patch version is preferred. I mean I've closed 3.28.0 and created 3.28.1 for forthcoming issues and PRs.


bug: HTML5 video player style messed

Type: bug
Platform: android 4.1 browser
The HTML5 video player in Android 4.1 (at least) has a messed appearance due to "ionic.css".
To reproduce the issue create a basic project (using "ionic start" for example) and add the following code to a template:
<video id="video1" width="480" preload="metadata" controls webkit-playsinline>
	<source type="video/mp4" src="http://www.w3schools.com/html/mov_bbb.mp4"></source>
	<source type="video/ogg" src="http://www.w3schools.com/html/mov_bbb.ogg"></source>
	Your browser does not support HTML5 video.
</video>

The video player has the appearance in the first attached image. Nevertheless, when removing the line <link href="lib/ionic/css/ionic.css" rel="stylesheet"> from "index.html", the player has a better appearance, as shown in the second attached image.

Original forum post: http://forum.ionicframework.com/t/html5-video-tag-style-messed-in-ionic-css/3254

Six months later and still no fix? This is discouraging.

Should be fixed via https://github.com/driftyco/ionic/commit/7e762b9cbfc4cdd7c2c2997ff44d36abbb66ab8a
Can you all grab a copy of the nightly builds and test it out?

This issue was fixed via https://github.com/driftyco/ionic/commit/7e762b9cbfc4cdd7c2c2997ff44d36abbb66ab8a
If that is not the case, please leave a comment.

The problem still persists. the controls renders correctly but clicking on the controls does noting. It works in the browser, but fails to play on the device (android 4.4).


feat(dashmate): Add contract and block height data to dashmate status output

Expected Behavior

Dashmate status command have info about block height data
Current Behavior

It does not show block height data
Possible Solution

Add block height data to the status command. Additionally, the fallback strategy for obtaining best block height should be implemented.
Call to the external blockchain explorer is used in dashmate status for obtaining the correct chain for best block height and its used as truth of source. This call can fail, server may be down, or other reasons, and this leads to the command fail as well. Add fallback to the getchaintips dashcore RPC method and mark the information as the local by coloring it in yellow.

Remote block height is currently broken in v24, because insight is answering too slow

Why it works in v0.23 then?

Why it works in v0.23 then?

In v23 there is no client timeout implemented and it simply waits for the response and it can take ages to receive the answer. If the request dropped by timeout with server, the command will throw an error

I'm not sure getchaintips will help us to indicate that node is not actually syncing. @strophy what do you think?

getchaintips will usually show if a particular node has at least heard of nodes with a higher block height, but really we should treat insight (and a fallback) as a reliable external source of block height. We should diagnose why insight is replying slowly instead maybe, there has been an update there in the last few weeks.

@strophy According to what you saying fallback will confuse people because you don't know is it a view from outside or just vision of an isolated node.

In the event of a chain fork, everyone will be trying to figure out if they are on an isolated network or if the insight/fallback data is incorrect because the remote source ended up on a chain fork. I think the best option here in the status command is to provide multiple clearly labeled block heights to help people diagnose errors quickly, and highlight our height in green if matches insight.

Sounds good to me!


Unable to Install Push Plugin on iOS

I'm installing this push plugin on my iOS project but getting this following error
Failed to install 'phonegap-plugin-push': Error: pod: Command failed with exit code 1
             at ChildProcess.whenDone
        (/Users/abdulwahab/Documents/mobileapps/hcApp/platforms/ios/cordova/node_modules/cordova-common/src/superspawn.js:169:23)
             at emitTwo (events.js:125:13)
             at ChildProcess.emit (events.js:213:7)
             at maybeClose (internal/child_process.js:927:16)
             at Socket.stream.socket.on (internal/child_process.js:348:11)
             at emitOne (events.js:115:13)
             at Socket.emit (events.js:210:7)
             at Pipe._handle.close [as _onclose] (net.js:545:12)
        Error: pod: Command failed with exit code 1

So far I've tried the following

Updated pods
Reinstall pods
Remove platform then again add platform and install
Remove plugin and re add plugin after updating pods
Created new project and tried all this but same error

This is my system configuration
CocoaPods Version: 1.3.1

cli packages: (/usr/local/lib/node_modules)

    @ionic/cli-utils  : 1.9.2
    ionic (Ionic CLI) : 3.9.2

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : android 6.2.3 ios 4.4.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    Android SDK Tools : 25.2.5
    Node              : v8.4.0
    npm               : 5.3.0
    OS                : macOS Sierra
    Xcode             : Xcode 8.3.3 Build version 8E3004b

Okay I've somehow able to fix this problem. I did the following

Reinstalled cocoapods
Removed ios platform
Added ios platform
Reinstalled push plugin
Run 'pod setup'
Run 'pod repo update'
Again reinstalled plugin
Run command 'ionic cordova build ios'


hi

Hi, thanks for the wonderful work.
When will the source code be released?
thanks！

Sorry for the late update, we have uploaded the code, checkpoints and predictions.

您好，请问这个怎么来做中文语料的摘要？好像bart不支持？有什么推荐的办法吗，谢谢大佬回复～


Do not pin version of requests in setup.py

According to the Python Packaging User Guide under the install_requires section:

install_requires is a setuptools setup.py keyword that should be used to specify what a project minimally needs to run correctly. When the project is installed by pip, this is the specification that is used to install its dependencies.

and

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

On travis, the following occurred when testing the client code, which required requests==2.11.1
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/pkg_resources/__init__.py", line 612, in _build_master
    ws.require(__requires__)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/pkg_resources/__init__.py", line 918, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/pkg_resources/__init__.py", line 810, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (requests 2.11.1 (/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages), Requirement.parse('requests==2.9'), {'BigchainDB'})

Hence, if a dependency version is pinned, users of are constrained to use that version.

Current coverage is 92.27% (diff: 100%)

Merging #580 into master will not change coverage

@@             master       #580   diff @@
==========================================
  Files            22         22
  Lines          1178       1178
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1087       1087
  Misses           91         91
  Partials          0          0

Powered by Codecov. Last update 1797960...92bd90d


Tomhaile/ch8847/max text on dispute form input should have

Clubhouse Story
Simple cosmetic change to not have up/down arrows in numeric input box for dispute and migrate rep.
use flash to setup env to test dispute and fork to test migrate rep.
Submitter checklist

[ ] Test covering functionality added/fixed in
Check the linked story includes the following:

[x] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass

Fixed I had to force the style on the REP input box.

Looks good!


Fix blind cast of CallableStatement

@theturrible , can you open a Jira for this issue, and add a test case
Thanks a lot

@theturrible I tried to check when this branch is executed, and it's not the regular ProcedureCall. Is it that you were using stored procedure for CRUD?

I think this is issue HHH-10256

Fixed with the following commit.


HDFS-501: Backport HDFS-433 to sdk-0.40

Clean cherry-pick.

Thanks @porridge.
Looking at the git logs between master and sdk-0.40 it seems as if:
commit a22272f450919dc4695b5154920e0b2934bd009a
Author: Nima Vaziri<EMAIL_ADDRESS>Date:   Fri Feb 16 10:33:13 2018 -0800

    Removed update strategy as default should always be serial (#2272)

Could also be backported. I will create a separate ticket so as to keep the logs more comparable.

@porridge feel free to merge once the HDFS CI passes.
We may have to update the squash commit message and indicate that this should make it into the release notes.

@elezar is there a certain format I should follow w.r.t the message?

BTW, GitHub says  You're not authorized to merge this pull request.

With regards to:

@elezar is there a certain format I should follow w.r.t the message?
No, not that I know of. We could just start with RELEASE-NOTES: or something?

Then:

BTW, GitHub says You're not authorized to merge this pull request.
I have pinged @benclarkwood to add you to the team.


Build CuPy from source with C++ 14

CUB 1.9.9 and 1.9.10 require c++14. Is it possible to build CuPy from source and pass c++14?

CUB 1.9.9 and 1.9.10 require c++14.

C++11 is not yet dropped, only deprecated: https://github.com/thrust/cub/pull/21. I think this deprecation will be done in both Thrust and CUB that come with CUDA 11. But, given that some Linux distros still ship old compilers (say gcc <=4.8.5; this is also part of the reason that blocks CuPy from making CUB built-in) and that a lot users will still be on CUDA<11 even it's out, dropping them might be a little too soon.
Just FYI, #2584 was a plan to bundle CUB with CuPy so that the CUB support works for pre-CUDA 11 users. Since a git submodule is used, updating to newer CUB is easy.

Is it possible to build CuPy from source and pass c++14?

If you build from source, you can change this line: https://github.com/cupy/cupy/blob/e6474838a922b7869fb56380c8b9421702da1b26/cupy_setup_build.py#L850
It'll affect both modules cupy.cuda.thrust and cupy.cuda.cub (the only two modules in CuPy that require nvcc).

@leofang You are correct! Sorry for the misstatement. Thanks!

Should we make this change in conda-forge package @leofang? The compilers there already support C++17.

I don't think there'd be any problem. But unless 1. CUDA 11 is out, or 2. CUB support is to be built, does it matter which C++ standard we pick?

It's worth noting I don't write that much C++ these days. That said, here's a nice blogpost on C++17 changes. There can be performance improvements in newer standards (C++17 has some copy elision improvements). Some standards make behavioral changes (though I think C++11 is more notable for this). Though the main reason to use a newer standard would be features (not sure how much that matters to us here).
Though to the conda-forge point, it would ensure are packages are being built more closely to the default conda-forge compiler flags, which include C++17 support.

My impression is that currently (pre-CUDA 11) both Thrust and CUB do not support C++17. I could  be wrong, though. C++14 (if we're gonna do it) seems safer.


fitted_soft_wl_subtree.pkl

Hi. Thanks for your great work!  May I ask you a question？
run:  BiGraph Applied to Breast Cancer.ipynb
result:  Did not run as expected results, the reason should be missing the file “fitted_soft_wl_subtree.pkl ”, I do not know how to get it?
thank you very much for your outstanding contribution！

Hi,
Thank you for your interest! The fitted_soft_wl_subtree.pkl file is very large (approximately 15GB), and I am currently looking for a way to host it since GitHub cannot accommodate such a large file.
In the meantime, if you want to reproduce the results shown in the paper, you can run the run_all.py script. This should generate the figures as presented in the paper. Please note that there may be slight differences due to the randomness involved in the clustering of subtrees. I will update the repository once the exact fitted_soft_wl_subtree.pkl file is available.
If you want to apply BiGraph to your own data, please modify the specified part in the run_all.py script with your own data path.

Feel free to reach out if you have any other questions.


compability with Elixir versions below  1.12

Hey there,
Since Elixir version requirement isn't specified, I'd love to make the latest version of the lib compatible with versions below 1.12, where Kernel.then was introduced.
Removing it was enough to make the lib compile using at least Elixir 1.11, haven't tried another versions.
Consider 1.10 almost deprecated https://hexdocs.pm/elixir/compatibility-and-deprecations.html
By the way, first PR in Open Source project, so let me know if something isn't right :)

Hey @bclaud
in that case, congrats on your first OSS contribution :tada:


Support functions with >= 6 arguments

AFAICT currently ocaml_export doesn't really know about restrictions around the number of arguments. It would be pretty nice if ocaml_export notices that and generates the bytecode version of the function as well.
I'm happy to take a crack at this and create a PR if you think this is a reasonable thing to add.

@mt-caret hello! Yes, you are correct, the current macro doesn't take into account bytecode functions (but you should be able to do the same thing that is done in C).
But it is indeed reasonable to add support for this, I am just not sure about what it should look like (somehow, the bytecode name for the function needs to be provided in the macro, so that the wrapper function can be generated too). Did you have anything in particular in mind?

I'm actually kind of a Rust noob so please correct me if I'm proposing something that's impossible, but I was thinking of just tacking on _bytecode to the name and exporting that as a quick-n-dirty thing we can do.

but I was thinking of just tacking on _bytecode to the name and exporting that as a quick-n-dirty thing we can do.

The symbol for the bytecode version name needs to be provided explicitly because with these macros new symbols cannot be generated. Other than that it shouldn't be complicated. Let me think about it.

I see, that makes sense. I was trying to manually working around this when I realized that ocaml-interop doesn't work as-is with bytecode compilation anyway due to https://github.com/tizoc/ocaml-interop/issues/34 (I think?), so I guess even if we had something like this it won't be as useful as I originally thought.

@mt-caret it can be worked around by enabling the no-caml-startup feature in the crate, or setting the OCAML_INTEROP_NO_CAML_STARTUP environment variable.
See https://github.com/tizoc/ocaml-interop/pull/37/commits/aebbdc5be302b894ecb77faf1172f22fd034a5cf and the related discussions:

https://github.com/tizoc/ocaml-interop/pull/37
https://github.com/zshipko/ocaml-rs/issues/70 (example loading the code form utop here)

It is all kinda dirty and not ideal, my hope is to be able to improve all this as part of the upgrade for supporting OCaml 5 (which requires improvements to how the runtime handle is implemented and also domain locks).

@mt-caret I am still unsure about the syntax, but see #50

Woah, this looks awesome!

Just merged #50 50, closing this

Awesome, tyvm!

@mt-caret uff, the moment I published the new version I noticed I am generating the wrong code, I will fix it and publish it as v0.9.1

@mt-caret ok, just published v0.9.1 with the fixed expansion.


Add support for the Sensirion SEN5x family sensors

Description

Adds support for the Sensirion SEN5x family devices. This is an all-in-one sensor for PM, temperature, humidity, VOC gasses and NOx gasses.
Updates the device-listing (for auto-update of README) to include the "nox" category.

Motivation and Context
How Has This Been Tested?
The driver was tested on the Sensirion SEN54 variant of the SEN5x series. All functionality could be tested, except the NOx-specific settings which is unique to the SEN55 variant. It was connected to an M5Core2 device on the default I2C pins.
Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[x] New feature (non-breaking change which adds functionality to code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project (only if there are changes in source code).
[ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[x] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[x] I have read the CONTRIBUTING document.
[x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[ ] I have added new tests to cover my changes.

Thanks for the PR, can you add the linter on the project? See https://github.com/nanoframework/nanoFramework.IoT.Device/tree/develop/StyleCop
Your code is already following a great pattern. The linter will find tiny little things, missing intellisense comments, things like this.

Thanks for the detailed review. All comments have been addressed/processed.


Refactor Integrate Asset

This is a followup PR from https://github.com/pypeclub/OpenPype/pull/2898 which was merged to an intermediate branch and we've added a few commits.
To be able to merge this, we've moved hosts and families filters for both the old and the new integrator to their respective GUI settings. The names of classes don't help here, but we can't easily rename the original class as we need to keep production backwards compatibility with existing project settings overrides.
The settings are here
project_settings/global/publish/IntegrateAssetNew (the original integrator)
project_settings/global/publish/IntegrateAsset (the refactored integrator)
This PR makes all of the hosts and families default to the refactored integrator. The plan is to merge do develop and look out for any issues that appear while testing any other PRs or production deployments. As soon as an issue appears, that particular combination of host and family should be moved to the legacy integrator in the settings. That action will revert it to the original and won't affect production, however, it will also automatically start generating a list of problematic combinations that need to be addressed in further PRs on the path to eradicate the old and ugly integrator plugin.
Please make sure that before you deploy develop, or next minor release into production, someone has the rights to quickly change system settings on these two plugins in case of any production issues.

Modified code:

New integrator has same host and families filters as legacy integrator (all of them)
New integrator marks instances for legacy integrator to skip them and avoid double integration
Make sure that order of legacy integrator is after new integrator
New integrator ha settings where is possible to "skip" host and families combinations to easily fix production when something breaks. If instance is skipped using this settings it will be integrated using legacy integrator.
Settings for publish templates are taken from legacy integrator

they will be moved elsewhere out of plugin settings in future PR (this is to avoid break compatibility of settings twice)

New integrator does not crash if all representations are marked for deletion and representations filtering happens before registering
CollectSubsetGroup was renamed to IntegrateSubsetGroup and was changed it's order to happen in integration

few minor changes

Explanations (To avoid confusion)

New integrator: Plugin IntegrateAsset in ./openpype/plugins/publish/integrate.py
Legacy integrator: Plugin IntegrateAssetNew in ./openpype/plugins/publish/integrate_legacy.py

It worked on basic published in:

AE
PS
Nuke

Just fixed the exclusion condition. Ready to merge


Cannot Login to Microsoft Learn

I recently changed my Microsoft email a few weeks ago and ever sense then I have been unable to progress in Microsoft Learn courses. Any time I try and start a new course it asks me to either login or continue without saving. I am unsure on how to progress.
Every time that I click on the log on link it takes me to the following page. https://techprofile.microsoft.com/en-US/Error?replyUrl=https://docs.microsoft.com/en-us/learn/browse/&
Profile - https://techprofile.microsoft.com/en-us/sesoccer911

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 71.0.3578.98 (Official Build) (64-bit)

Sorry @sesoccer911, it seems that GH notifications were mutes.
@Sampy can you help troubleshooting this issue? It seems that @sesoccer911 has tried everything.

This is an issue we are aware of (users changing the email used to sign in to their MSA not being able to sign in) and the good news is we have a fix in the works that we are hoping to roll out this week or next.

We have deployed a change that should fix this issue. It may take some time to roll out to you so try it again and let me know if you are still hitting the problem. If so, there may be another cause we need to look into.

Thank you for the update, I can report that the issue has been resolved!
Thanks!

Hi!I am facing a similar connection problem today: in fact, I've changed my password for safety reasons a few hours ago but it's impossible to connect to my Microsoft learn profile. When selecting the "sign in" button on the screen the Microsoft page stays in the same position and do not give me the chance to write down any password etc. It seems that "sign in" is deactivated...Could you please have a look? I don t want to loose my level information and score as well. Thank you so much!

Hi!I am facing a similar connection problem today: in fact, I've changed my password for safety reasons a few hours ago but it's impossible to connect to my Microsoft learn profile. When selecting the "sign in" button on the screen the Microsoft page stays in the same position and do not give me the chance to write down any password etc. It seems that "sign in" is deactivated...Could you please have a look? I don t want to loose my level information and score as well. Thank you so much!

@sampy and @jialge can you look at this issue?

Can you share what page you are on when you try to sign in? Please try this in an InPrivate/Incognito mode browser as well which will help isolate the issue.
We are going to be deploying some changes to the way we sign users in over the next few weeks that will be transparent to you but may resolve this issue as well.

My browser is on  [https://docs.microsoft.com/en-us/learn/] page but on any other page I have tried to connect to Microsoft learn it was impossible, too.
Thank you! I've just tried the private mode but nothing happened. Still "sign in" choice seems to be totally deactivated...Neither may I achieve a new score since not being able to connect...


crypto.randomUUID() fails on mobile in Dev

Describe the bug
<!-- routes/+page.svelte -->
<script>
	let arr = [];
	const add = () => (arr = [{ id: crypto.randomUUID() }, ...arr]);
</script>

<button on:click={add}>add</button>
{#each arr as item (item.id)}
	<p>{item.id}</p>
{/each}

npm run dev -- --host

  VITE v3.2.4  ready in 681 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: http://192.168.X.X:5173/

open Network in dev mode on mobile and click add button. Not working
deploy on vercel site open on mobile. Working
Reproduction
repo
Logs
No response
System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 AMD Ryzen 9 5900HS with Radeon Graphics
    Memory: 7.96 GB / 15.41 GB
  Binaries:
    Node: 18.0.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.819.0), Chromium (107.0.1418.42), ChromiumDev ((@(&"C:/Users/dange/AppData/Local/Programs/oh-my-posh/bin/oh-my-posh.exe" init pwsh --config="C:\Users\dange\AppData\Local\Programs\oh-my-posh\themes\jandedobbeleer.omp.json" --print) -join "`n") | Invoke-Expression)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.88
    @sveltejs/kit: next => 1.0.0-next.551
    svelte: ^3.44.0 => 3.53.1
    vite: ^3.1.0 => 3.2.4

Severity
serious, but I can work around it
Additional Information
No response

This almost certainly just means you're using an old browser that doesn't implement the Web Crypto API. What browser is it?

Oh, except you said it works in prod. That's... bizarre.

test in all possible browsers in Android 12 (except iOS) chrome/firefox/samsung internet/edge. It was very difficult to know the problem, since desktop works.

https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID

Secure context: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers.

That makes sense then - localhost runs on http by default

@repsac-by oh, i didn't expect it. maybe there is something i am not understanding should it work on desktop in dev mode which is also not https?

secure contexts

Locally-delivered resources such as those with http://<IP_ADDRESS> URLs, http://localhost and http://*.localhost URLs (e.g. http://dev.whatever.localhost/), and file:// URLs are also considered to have been delivered securely.

Most browsers do treat HTTP localhost as secure, except not Safari IIRC.

Presumably the problem is that the mobile browser is connecting to http://192.168.X.X:5173/ rather than localhost? Not sure there's a lot we can do about that, and it isn't specific to SvelteKit, so I'm inclined to close this as wontfix

@Rich-Harris It's certainly not specific to Sveltekit, it's okay to close it, but given the behavior is different in some browsers, a little warning in the docs could prevent someone else from spending hours looking for a 'bug' that never shows up in the console.

We just can't be responsible for documenting every aspect of the web platform — we're not MDN (where the secure context limitation is called out at the top of the page). Closing


Cannot query some parquet files in S3, but they work locally

Describe the bug
I am trying to query parquet files in S3 from the CLI. Some work, and some do not.
To Reproduce
DataFusion CLI v12.0.0
❯ create external table test stored as parquet location 's3://nyc-tlc/trip data/yellow_tripdata_2022-06.parquet';
ObjectStore(Generic { store: "S3", source: MissingLastModified })

However, if I download the file locally it works.
$ aws s3 cp "s3://nyc-tlc/trip data/yellow_tripdata_2022-06.parquet" /tmp/yellow_tripdata_2022-06.parquet
download: s3://nyc-tlc/trip data/yellow_tripdata_2022-06.parquet to ../../../../../../tmp/yellow_tripdata_2022-06.parquet

ataFusion CLI v12.0.0
❯ create external table test stored as parquet location '/tmp/yellow_tripdata_2022-06.parquet';
0 rows in set. Query took 0.006 seconds.
❯ select * from test limit 10;
+----------+----------------------+-----------------------+-----------------+---------------+------------+--------------------+--------------+--------------+--------------+-------------+-------+---------+------------+--------------+-----------------------+--------------+----------------------+-------------+
| VendorID | tpep_pickup_datetime | tpep_dropoff_datetime | passenger_count | trip_distance | RatecodeID | store_and_fwd_flag | PULocationID | DOLocationID | payment_type | fare_amount | extra | mta_tax | tip_amount | tolls_amount | improvement_surcharge | total_amount | congestion_surcharge | airport_fee |
+----------+----------------------+-----------------------+-----------------+---------------+------------+--------------------+--------------+--------------+--------------+-------------+-------+---------+------------+--------------+-----------------------+--------------+----------------------+-------------+
| 1        | 2022-06-01 00:25:41  | 2022-06-01 00:48:22   | 1               | 11            | 1          | N                  | 70           | 48           | 1            | 32          | 3     | 0.5     | 2          | 6.55         | 0.3                   | 44.35        | 2.5                  | 0           |
| 1        | 2022-06-01 00:44:40  | 2022-06-01 01:01:48   | 1               | 4.2           | 1          | N                  | 170          | 226          | 1            | 14          | 3     | 0.5     | 0          | 0            | 0.3                   | 17.8         | 2.5                  | 0           |
| 2        | 2022-06-01 00:23:07  | 2022-06-01 00:39:50   | 1               | 9.49          | 1          | N                  | 264          | 113          | 1            | 26          | 0.5   | 0.5     | 5          | 6.55         | 0.3                   | 42.6         | 2.5                  | 1.25        |
| 1        | 2022-06-01 00:25:53  | 2022-06-01 00:57:06   | 2               | 12.1          | 1          | N                  | 132          | 17           | 2            | 37          | 1.75  | 0.5     | 0          | 0            | 0.3                   | 39.55        | 0                    | 1.25        |
| 1        | 2022-06-01 00:23:58  | 2022-06-01 00:33:43   | 0               | 1.8           | 1          | N                  | 140          | 163          | 1            | 9           | 3     | 0.5     | 2.55       | 0            | 0.3                   | 15.35        | 2.5                  | 0           |
| 2        | 2022-06-01 00:01:27  | 2022-06-01 00:10:53   | 1               | 2.02          | 1          | N                  | 148          | 158          | 1            | 9           | 0.5   | 0.5     | 0.64       | 0            | 0.3                   | 13.44        | 2.5                  | 0           |
| 2        | 2022-06-01 00:16:25  | 2022-06-01 00:40:45   | 1               | 8.08          | 1          | N                  | 158          | 116          | 1            | 26.5        | 0.5   | 0.5     | 7.58       | 0            | 0.3                   | 37.88        | 2.5                  | 0           |
| 1        | 2022-06-01 00:11:08  | 2022-06-01 00:27:02   | 1               | 4.3           | 1          | N                  | 246          | 262          | 1            | 15          | 3     | 0.5     | 3.75       | 0            | 0.3                   | 22.55        | 2.5                  | 0           |
| 2        | 2022-06-01 00:21:42  | 2022-06-01 00:42:01   | 1               | 8.78          | 1          | N                  | 197          | 191          | 1            | 26.5        | 0.5   | 0.5     | 5.56       | 0            | 0.3                   | 33.36        | 0                    | 0           |
| 2        | 2022-06-01 00:23:05  | 2022-06-01 00:30:45   | 1               | 1.76          | 1          | N                  | 48           | 186          | 1            | 7.5         | 0.5   | 0.5     | 2.26       | 0            | 0.3                   | 13.56        | 2.5                  | 0           |
+----------+----------------------+-----------------------+-----------------+---------------+------------+--------------------+--------------+--------------+--------------+-------------+-------+---------+------------+--------------+-----------------------+--------------+----------------------+-------------+
10 rows in set. Query took 1.792 seconds.

Expected behavior
Should work
Additional context
None

If I move the file into my own bucket then I can query it, so this seems to be an issue with authentication.

root cause is https://github.com/apache/arrow-rs/issues/2795

This was resolved


Unable to expand Z-Wave options after update from 66.1 to 67

Home Assistant release with the issue:
0.67
Last working Home Assistant release (if known):
0.66.1
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.IO, running on Debian 9.4 (Intel NUC) installed with Install Script
Component/platform:
Z-Wave
Description of problem:
After update to version 0.67 im unable to expand Z-Wave node options

Node Values
Node Group Assignment
Node Config Options

Node Entities still works and can expand
Additional information:
I did a revert to 0.66.1 and now it works again as expected and i can modify my Z-Wave devices again.

Duplicate of https://github.com/home-assistant/home-assistant/issues/13740.
Fix will go out in 0.67.1.


Noisy warnings when detecting .txt files translation format match

Going forward I'd like to keep any import .txt and .fob files in my AL project (e.g. exported legacy files with the old syntax, new syntax, .fob files, etc). But the AL compiler presents me with warnings on every .txt file it finds e.g.
'<path to .txt file>' does not match any definition.
Why is this build warning even present? It's a .txt file and unless I'm mistaken, the compiler should completely ignore them and focus on the relevant file types only @ build (e.g. .json, .al, .xlf, .rdlc, .docx).
I didn't find any properties in launch.json nor app.json to allow me to tell VS code to ignore certain file types.
My present workaround is to rename those .txt files to use the extension ".txt.ignore"

The .txt files are used for translations so the compiler needs to detect which ones match the translation file format.
We will consider how to reduce the noise in cases like yours but in general I wouldn't recommend keeping non-AL related artifacts in the same folder as AL sources/resources. Why not store them one folder level higher?

Good idea I'll consider it

@StanislawStempin just curious, why does VS code even look for translations in .txt files? Shouldn't it ignore those files and instead focus solely on validating .xlf files?
If I view/edit a .txt file I usually have the expectation that the payload isn't XML.

@SteveKrisjanovsD365 the TXT files are used for translating the C/AL base application. In Fall 2019, we will switch to using .xlf files for translating it, but the validation will stay. Have you found a satisfying workaround for this issue?


[BUG] Cannot delete replicas via UI

Describe the bug (🐛 if you encounter this issue)
One of the nodes went down due to disk pressure. Actually it's my fault that didn't manage to keep available space. But how can I find and remove replicas? I have 4 nodes and each volume has 3 replicas, to make some space available need to delete some replicas of big sized volumes. How do I find a replica and delete them with kubectl?

To Reproduce

Expected behavior

Support bundle for troubleshooting

Environment

Longhorn version:
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of management node in the cluster:
Number of worker node in the cluster:

Node config

OS type and version:
Kernel version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe/HDD):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:
Impacted Longhorn resources:

Volume names:

Additional context

in web UI, I can see the volume that I want to delete. But with kubectl cannot find it with "kubectl get replicas -n longhorn-system". Could it be because of longhorn pods are down on that node? Can I just delete replica volume manually directly on the kubernetes node? Like "rm -f /var/lib/longhorn/replicas/pvc-xxxx-xxxx-xxxx" ?

in web UI, I can see the volume that I want to delete. But with kubectl cannot find it with "kubectl get replicas -n longhorn-system".

Do you mean volume? The command should be kubectl get volumes -n longhorn-system.


[Feature request] Add track number field to metadata

Hey, thanks for this great flutter plugin.
Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great.
Thank you.

Hey, thanks for this great flutter plugin.
Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great. Thank you.

Sure, I will implement support for this.

Hey, thanks for this great flutter plugin.
Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great. Thank you.

Sure, I will implement support for this.

Thanks Erikas. Unrelated question...
I have a largeish music collection (1000 songs) and I'm getting errors reading the tags for various files (errors drilling down into your plugin) along with invalid picture data (using MemoryImage).
As the cause of this could be due to numerous things (filenames, special characters etc, bad metadata), it could be hard to reproduce at your end.
Would giving you read access to the music on my dropbox account help in diagnosing these problems at your end?
Thanks again.

The files will help with debugging. You can compile a list of problem files and send them as a zip as an attachment.

The files will help with debugging. You can compile a list of problem files and send them as a zip as an attachment.

Thanks. I created a separate issue for that, to keep this one on topic. https://github.com/erikas-taroza/audiotags/issues/7

Ok thank you.
I have added support for the track number and track total metadata fields in ccbda92
Let me know if need any other fields. I will be happy to add them.

Ok thank you.
I have added support for the track number and track total metadata fields in ccbda92 Let me know if need any other fields. I will be happy to add them.

You work fast! Thank you very much.
I do have a list of other fields that would be great to have. I'll open a new issue for those.
PS: do you have a build bot that builds a new version of the plugin and pushes it live to pub.dev?
Thanks again.

I do have a list of other fields that would be great to have. I'll open a new issue for those.

Ok sounds good.

PS: do you have a build bot that builds a new version of the plugin and pushes it live to pub.dev?
No. I have a CD that creates the libraries and uploads them as a GitHub release asset. I still upload to pub.dev manually.


Code-Sign the PS Module

... when publishing to PS Gallery

The development part is done, the next release will be signed.


Personal/quwan/feature anonymized patient group export

Description
Support De-identified export for Patient and Group export.
The behaviors can be viewed at Using $export command.
Examples
GET https://<<FHIR service base URL>>/Patient/$export?_container=<<container_name>>&_anonymizationConfig=<<config file name>>&_anonymizationConfigEtag=<<ETag on storage>>
GET https://<<FHIR service base URL>>/Group/[ID]/$export?_container=<<container_name>>&_anonymizationConfig=<<config file name>>&_anonymizationConfigEtag=<<ETag on storage>>
Testing
Manual and unit test
FHIR Team Checklist

[ ] Update the title of the PR to be succinct and less than 50 characters
[ ] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[ ] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[ ] Tag the PR with Azure API for FHIR if this will release to the managed service
Review squash-merge requirements

Semver Change (docs)
Feature (An extension of De-identified export)

        return !string.IsNullOrEmpty(_exportJobRecord.AnonymizationConfigurationLocation);

I'm suprised we don't check AnonymizationConfigFileETag

Refers to: src/Microsoft.Health.Fhir.Core/Features/Operations/Export/ExportJobTask.cs:664 in cc63cc2. [](commit_id = cc63cc20944c881f98c275ddc4d795380870b8d6, deletion_comment = False)

public class ExportJobTask : IExportJobTask

Design question.
Why we have to pass so many parameters to private functions in this class?
If I correctly understand this object represent specific state of export job.
Why can't we have state of the job inside object instead of passing it around through functions?
For example progress, why it's not just a private field? Or anonymizer? Or cancellation token. Considering what they are same through whole export job.

Refers to: src/Microsoft.Health.Fhir.Core/Features/Operations/Export/ExportJobTask.cs:33 in cc63cc2. [](commit_id = cc63cc20944c881f98c275ddc4d795380870b8d6, deletion_comment = False)

        // Validate that the request does not contain query parameters that are not supported.

It's a bit tricky to support action filter and controller filter in sync, so can I suggest to switch to this approach instead of hardcoding "expected" parameters?
https://stackoverflow.com/questions/55451408/reject-requests-containing-unknown-query-parameters

Refers to: src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportRequestFilterAttribute.cs:72 in 300e9ab. [](commit_id = 300e9abf5bc2b7fbfb4dccfbe0b744944b6b761e, deletion_comment = False)

public class ExportJobTask : IExportJobTask

Design question.
Why we have to pass so many parameters to private functions in this class?
If I correctly understand this object represent specific state of export job.
Why can't we have state of the job inside object instead of passing it around through functions?
For example progress, why it's not just a private field? Or anonymizer? Or cancellation token. Considering what they are same through whole export job.
Refers to: src/Microsoft.Health.Fhir.Core/Features/Operations/Export/ExportJobTask.cs:33 in cc63cc2. [](commit_id = cc63cc2, deletion_comment = False)

Thanks for advice. In fact there's only one ExportJobTask instance, and each time a new export request received, ExportJobWorker will create a ExecuteAsync task to do the export job. So I feel like maybe those related instances (anonymizer, progress and cancellation token) better not be the private fields.
I thought a potential optimization here is to create ExportJobTask for each export job, but that can be another refine work.

        // Validate that the request does not contain query parameters that are not supported.

It's a bit tricky to support action filter and controller action in sync, so can I suggest to switch to this approach instead of hardcoding "expected" parameters?
https://stackoverflow.com/questions/55451408/reject-requests-containing-unknown-query-parameters
Refers to: src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportRequestFilterAttribute.cs:72 in 300e9ab. [](commit_id = 300e9ab, deletion_comment = False)

That's sounds good, I think this approach would be more flexible.
Seems like this part is written by @namadabu , do you have any concerns if I update the supported parameters in this way?
From my experiment, the conditions will be like
IList<ParameterDescriptor> parameters = context.ActionDescriptor.Parameters == null ?                                                                    new List<ParameterDescriptor>() :                                                                    context.ActionDescriptor.Parameters; .. if (parameters.Any(parm => string.Equals(parm.BindingInfo?.BinderModelName, paramName, StringComparison.Ordinal))) {  continue;  }

I was under impression what ExportJobTask got created via DI, and it's registered as transient object so it would be new for each incoming request.
It's perfectly fine to have current code, it was more question towards other people in codereview (which I forgot to mention, so sorry for my sloppiness).
I still think it would be nice to refactor code a bit, but it's too much to ask from current PR, it serves different goal. Sorry for distracting you.

In reply to: 781932463 [](ancestors = 781932463)


deploy.sh interface_arr[$interface]=$if_counter

line 285 in deploy.sh
interface_arr[$interface]=$if_counter
variable $interface is not a number (it is name of interface). so during the for cycle the expression is always:
interface_arr[0]=$if_counter
we used instead (not sure if it is ok with rest of the code however)
interface_arr[$if_counter]=$if_counter

Hi Peter,
I think this is OK.  We can use names as the key for an associative array:
http://www.artificialworlds.net/blog/2012/10/17/bash-associative-array-examples/
But you are right it looks like there is a bug because I don't declare it explicitly:
$ blah[em1]=0
$ blah[em2]=1
$ blah[em3]=2
$ echo ${blah[em2]}
2
$ echo ${blah[em3]}
2
$ echo ${blah[em1]}
2
$ declare -A MYMAP
$ MYMAP[em1]=0
$ MYMAP[em2]=1
$ MYMAP[em3]=2
$ echo ${MYMAP[em1]}
0
$ echo ${MYMAP[em2]}
1
$ echo ${MYMAP[em3]}
2
Will patch this by adding the declare statement.  Thanks for finding this!

Fixed and closed.  Thanks @pbandzi for finding this!


Add license

@galmog @Abayomi-Olabode please weigh in on preferred license ASAP

@ArtPoon I suggest we leave it open, in the public domain with free access to modify.

Of course, but which license?  MIT?  GPL?

@ArtPoon oh Sorry. I would say MIT.

MIT sounds good


Showing image as bits when using data-remote under BS3

I found that the "data-remote" attr isn't work with Bootstrap 3.3.7. It will showing bits rather than and image, even the image is loaded correctly within microseconds. Can anyone tell me how to fix it?
I am test it with Google Chrome. You may try it on official site: http://ashleydw.github.io/lightbox/bs3.html#data-remote
The screenshot:

I have found the same issue today. I guess that the error is located in how the image is requested to the server because the same request is sent twice but the first one is requested as X-Requested-With: XMLHttpRequest even if the data-type is set to image.

see http://ashleydw.github.io/lightbox/#force-type

I have tried that and got the same result. Also tried the disable-external-check option.

Didn't realise it was Bootstrap 3 - I'm not sure, it looks like the entire content div is getting replaced. I suggest going back to an older version; something like https://github.com/ashleydw/lightbox/releases/tag/v3.3.3

It works but there is an error in the console
Uncaught TypeError: url.indexOf is not a function
at jQuery.fn.init.jQuery.fn.load (libs.js:9857)
at Image.d.onload (project-view.js:14810)
  | jQuery.fn.load | @ | libs.js:9857
  | d.onload | @ | project-view.js:14810
  | load (async) |   |
  | preloadImage | @ | project-view.js:14809
  | detectRemoteType | @ | project-view.js:14784
  | modal_shown | @ | project-view.js:14758
  | (anonymous) | @ | project-view.js:14748
  | dispatch | @ | libs.js:5183
  | elemData.handle | @ | libs.js:4991
  | trigger | @ | libs.js:8249
  | (anonymous) | @ | libs.js:8327
  | each | @ | libs.js:354
  | each | @ | libs.js:189
  | trigger | @ | libs.js:8326
  | (anonymous) | @ | libs.js:11383
  | fn | @ | libs.js:4932
  | handle | @ | libs.js:10437
  | dispatch | @ | libs.js:5183
  | elemData.handle | @ | libs.js:4991
The line 14810 is part of this library:
var b;return b = a("<img />"), b.attr("src", d.src), b.addClass("img-responsive"), e.lightbox_body.html(b), e.modal_arrows && e.modal_arrows.css("display", "block"), b.load(function () {
          return e.resize(d.width), e.options.onContentLoaded.call(e);
        });

Maybe it needs a different jQuery version but that will be too much downgrade to fix this. I'll try to  attribute around the image with the image ref instead of using data-remote and see what I get.

I wrapped the image with an  element with the library data attributes and it does the job but the data-remote issue still there in BS3.

I suggest we rename data remote into something like lbremote. It conflicts with Bootstrap 3 usage of remote modal that was deprecated and removed in BS 4.
https://getbootstrap.com/docs/3.4/javascript/#modals-options

Perhaps it can and should be done without renaming. The real culprit is copying data to _config and passing it along with data-remote to .modal.