Remove -mtune=native

Per @xorinox this is probably why current chiapos can be 10-20% slower than b17 based on local CPU.

the reason I added this was to ensure __popcnt64() would turn into the single-instruction on x86, rather than falling back to a software implementation. Perhaps new versions of GCC assume a recent enough x86 architecture to do this anyway.

the reason I added this was to ensure __popcnt64() would turn into the single-instruction on x86, rather than falling back to a software implementation. Perhaps new versions of GCC assume a recent enough x86 architecture to do this anyway.

We're going to package this into dev and have @xorinox test to see if the desired performance returns. If not, we'll revert.

We're going to package this into dev and have @xorinox test to see if the desired performance returns. If not, we'll revert.

to be clear, I don't doubt that this could cause a performance regression. I'm just suggesting it might be a good idea to verify that we still get the popcount instruction. There may be a better flag for instance, specifying a specific SSE version we require.
(although, I would be surprised if this flag causes a performance regression when built and run on the same machine).

to be clear, I don't doubt that this could cause a performance regression. I'm just suggesting it might be a good idea to verify that we still get the popcount instruction. There may be a better flag for instance, specifying a specific SSE version we require.
(although, I would be surprised if this flag causes a performance regression when built and run on the same machine).


WIP: Binned PR-related metrics

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes #95 .
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@maximsch2 how is it going here, ready for review?

@Borda, I need to fix up isort and do a short cleanup, will get to it some time this week.

@maximsch2 how is the clean-up doing? ;]

@Borda , I've moved out the function I wanted to do, feel free to take a look now. Another thing I think I should probably do is to move out test data generation code into a central place, but actually curious about your feedback to see if we should just replace the main one with it?
The motivation is to get a reasonably-looking model, so that metrics like<EMAIL_ADDRESS>can be computed as the random data never actually reaches that precision :)

Hello @maximsch2! Thanks for updating this PR.

In the file tests/classification/test_binned_precision_recall.py:

Line 124:121: E501 line too long (126 > 120 characters)

@Borda , mind taking a look now?

Sounds good, let me work on that. While I started I've noticed another clean-up opportunity. Also, what's up with circleci? I see bleu failing intermittently even though I'm not touching it

Addressed comments. On docs, is your preference to go for strict alphabetical order? I was putting the binned versions close to non-binned ones so that people will notice them together, but I can move the new one to the to the sorted place as well.

I was putting the binned versions close to non-binned ones so that people will notice them together, but I can move the new one to the to the sorted place as well.

that is also an option, I do not have strong preference here :]


Issue with get_desire_lines()

Hello Robin,
How do I get around the error below when I get when I ran this command: leeds_od = get_od(region = "west-yorkshire")?
`trying URL 'https://s3-eu-west-1.amazonaws.com/statistics.digitalresources.jisc.ac.uk/dkan/files/FLOW/wu03ew_v2/wu03ew_v2.zip'
Content type 'application/zip' length 12409884 bytes (11.8 MB)
downloaded 11.8 MB
Parsed with column specification:
cols(
Area of residence = col_character(),
Area of workplace = col_character(),
All categories: Method of travel to work = col_double(),
Work mainly at or from home = col_double(),
Underground, metro, light rail, tram = col_double(),
Train = col_double(),
Bus, minibus or coach = col_double(),
Taxi = col_double(),
Motorcycle, scooter or moped = col_double(),
Driving a car or van = col_double(),
Passenger in a car or van = col_double(),
Bicycle = col_double(),
On foot = col_double(),
Other method of travel to work = col_double()
)
|====================================================================| 100%  103 MB
Parsed with column specification:
cols(
MSOA11CD = col_character(),
MSOA11NM = col_character(),
BNGEAST = col_double(),
BNGNORTH = col_double(),
LONGITUDE = col_double(),
LATITUDE = col_double()
)

View(leeds_od)
desire_leeds = get_desire_lines(region = "Leeds")
Error in get_od(region, omit_intrazonal = omit_intrazonal) :
region must contain a valid name in the pct_regions_lookup
desire_leeds = get_desire_lines(region = "west-yorkshire")
trying URL 'https://s3-eu-west-1.amazonaws.com/statistics.digitalresources.jisc.ac.uk/dkan/files/FLOW/wu03ew_v2/wu03ew_v2.zip'
Content type 'application/zip' length 12409884 bytes (11.8 MB)
downloaded 11.8 MB

Parsed with column specification:
cols(
Area of residence = col_character(),
Area of workplace = col_character(),
All categories: Method of travel to work = col_double(),
Work mainly at or from home = col_double(),
Underground, metro, light rail, tram = col_double(),
Train = col_double(),
Bus, minibus or coach = col_double(),
Taxi = col_double(),
Motorcycle, scooter or moped = col_double(),
Driving a car or van = col_double(),
Passenger in a car or van = col_double(),
Bicycle = col_double(),
On foot = col_double(),
Other method of travel to work = col_double()
)
|====================================================================| 100%  103 MB
Parsed with column specification:
cols(
MSOA11CD = col_character(),
MSOA11NM = col_character(),
BNGEAST = col_double(),
BNGNORTH = col_double(),
LONGITUDE = col_double(),
LATITUDE = col_double()
)
Downloading population weighted centroids
Parsed with column specification:
cols(
MSOA11CD = col_character(),
MSOA11NM = col_character(),
BNGEAST = col_double(),
BNGNORTH = col_double(),
LONGITUDE = col_double(),
LATITUDE = col_double()
)
Not all flows origins have ID in centroids, removing 96190 OD pairs.
Error in if (grepl(pattern = "POLYGON", x = unique(sf::st_geometry_type(zones)))) { :
argument is of length zero`

It works fine on my computer, I cannot reproduce the error:
library(pct); pct::get_od(region = "west-yorkshire")
#> Parsed with column specification:
#> cols(
#>   `Area of residence` = col_character(),
#>   `Area of workplace` = col_character(),
#>   `All categories: Method of travel to work` = col_double(),
#>   `Work mainly at or from home` = col_double(),
#>   `Underground, metro, light rail, tram` = col_double(),
#>   Train = col_double(),
#>   `Bus, minibus or coach` = col_double(),
#>   Taxi = col_double(),
#>   `Motorcycle, scooter or moped` = col_double(),
#>   `Driving a car or van` = col_double(),
#>   `Passenger in a car or van` = col_double(),
#>   Bicycle = col_double(),
#>   `On foot` = col_double(),
#>   `Other method of travel to work` = col_double()
#> )
#> Parsed with column specification:
#> cols(
#>   MSOA11CD = col_character(),
#>   MSOA11NM = col_character(),
#>   BNGEAST = col_double(),
#>   BNGNORTH = col_double(),
#>   LONGITUDE = col_double(),
#>   LATITUDE = col_double()
#> )
#> # A tibble: 96,190 x 18
#>    geo_code1 geo_code2   all from_home light_rail train   bus  taxi motorbike
#>    <chr>     <chr>     <dbl>     <dbl>      <dbl> <dbl> <dbl> <dbl>     <dbl>
#>  1 E02002183 E02000001     3         0          0     1     0     0         0
#>  2 E02002183 E02000371     2         0          1     0     0     0         0
#>  3 E02002183 E02000573     1         0          0     1     0     0         0
#>  4 E02002183 E02000575     1         0          0     0     1     0         0
#>  5 E02002183 E02000576     1         0          0     1     0     0         0
#>  6 E02002183 E02000581     1         0          0     0     0     0         0
#>  7 E02002183 E02000589     1         0          0     0     0     0         0
#>  8 E02002183 E02000672     1         0          0     1     0     0         0
#>  9 E02002183 E02000878     1         0          0     0     0     0         0
#> 10 E02002183 E02000890     1         0          0     1     0     0         0
#> # … with 96,180 more rows, and 9 more variables: car_driver <dbl>,
#> #   car_passenger <dbl>, bicycle <dbl>, foot <dbl>, other <dbl>,
#> #   geo_name1 <chr>, geo_name2 <chr>, la_1 <chr>, la_2 <chr>

Created on 2020-05-01 by the reprex package (v0.3.0)

Session info
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 3.6.3 (2020-02-29)
#>  os       Ubuntu 18.04.4 LTS
#>  system   x86_64, linux-gnu
#>  ui       X11
#>  language en_GB:en
#>  collate  en_GB.UTF-8
#>  ctype    en_GB.UTF-8
#>  tz       Europe/London
#>  date     2020-05-01
#>
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version     date       lib source
#>  assertthat    0.2.1       2019-03-21 [2] CRAN (R 3.6.0)
#>  backports     1.1.6       2020-04-05 [1] CRAN (R 3.6.3)
#>  callr         3.4.3       2020-03-28 [1] CRAN (R 3.6.3)
#>  class         7.3-17      2020-04-26 [2] CRAN (R 3.6.3)
#>  classInt      0.4-3       2020-04-06 [1] Github (r-spatial/classInt@d024051)
#>  cli           2.0.2       2020-02-28 [1] CRAN (R 3.6.2)
#>  crayon        1.3.4       2017-09-16 [2] standard (@1.3.4)
#>  curl          4.3         2019-12-02 [2] CRAN (R 3.6.2)
#>  DBI           1.1.0       2019-12-15 [2] CRAN (R 3.6.2)
#>  desc          1.2.0       2018-05-01 [2] standard (@1.2.0)
#>  devtools      2.3.0       2020-04-10 [1] CRAN (R 3.6.3)
#>  digest        0.6.25      2020-02-23 [1] CRAN (R 3.6.2)
#>  e1071         1.7-3       2019-11-26 [2] CRAN (R 3.6.1)
#>  ellipsis      0.3.0       2019-09-20 [3] CRAN (R 3.6.1)
#>  evaluate      0.14        2019-05-28 [2] CRAN (R 3.6.0)
#>  fansi         0.4.1       2020-01-08 [1] CRAN (R 3.6.2)
#>  fs            1.4.1       2020-04-04 [2] CRAN (R 3.6.3)
#>  glue          1.4.0       2020-04-03 [2] CRAN (R 3.6.3)
#>  highr         0.8         2019-03-20 [3] CRAN (R 3.5.3)
#>  hms           0.5.3       2020-01-08 [1] CRAN (R 3.6.2)
#>  htmltools     <IP_ADDRESS>03  2020-04-09 [1] Github (rstudio/htmltools@1a7d0dc)
#>  KernSmooth    2.23-17     2020-04-26 [4] CRAN (R 3.6.3)
#>  knitr         1.28        2020-02-06 [1] CRAN (R 3.6.2)
#>  lifecycle     <IP_ADDRESS>00  2020-03-16 [1] Github (r-lib/lifecycle@355dcba)
#>  magrittr      1.5         2014-11-22 [2] CRAN (R 3.5.2)
#>  memoise       1.1.0       2017-04-21 [3] CRAN (R 3.5.0)
#>  pct         * 0.4.0       2020-04-13 [1] Github (itsleeds/pct@c0edad4)
#>  pillar        1.4.3       2019-12-20 [1] CRAN (R 3.6.2)
#>  pkgbuild      1.0.7       2020-04-25 [2] CRAN (R 3.6.3)
#>  pkgconfig     2.0.3       2019-09-22 [2] CRAN (R 3.6.1)
#>  pkgload       1.0.2       2018-10-29 [3] CRAN (R 3.5.1)
#>  prettyunits   1.1.1       2020-01-24 [1] CRAN (R 3.6.2)
#>  processx      3.4.2       2020-02-09 [1] CRAN (R 3.6.3)
#>  ps            1.3.2       2020-02-13 [1] CRAN (R 3.6.3)
#>  R6            2.4.1       2019-11-12 [2] CRAN (R 3.6.1)
#>  Rcpp          <IP_ADDRESS>     2020-04-09 [1] CRAN (R 3.6.3)
#>  readr         1.3.1       2018-12-21 [2] CRAN (R 3.5.3)
#>  remotes       2.1.1       2020-02-15 [1] CRAN (R 3.6.2)
#>  rlang         <IP_ADDRESS>00  2020-03-25 [1] Github (r-lib/rlang@a90b04b)
#>  rmarkdown     2.1.2       2020-04-09 [1] Github (rstudio/rmarkdown@65dd144)
#>  rprojroot     1.3-2       2018-01-03 [2] CRAN (R 3.5.3)
#>  sessioninfo   1.1.1       2018-11-05 [3] CRAN (R 3.5.1)
#>  sf            0.9-2       2020-04-14 [1] CRAN (R 3.6.3)
#>  stringi       1.4.6       2020-02-17 [1] CRAN (R 3.6.2)
#>  stringr       1.4.0       2019-02-10 [2] standard (@1.4.0)
#>  testthat      2.3.2       2020-03-02 [1] CRAN (R 3.6.3)
#>  tibble        3.0.1       2020-04-20 [1] CRAN (R 3.6.3)
#>  units         0.6-6       2020-03-16 [1] CRAN (R 3.6.3)
#>  usethis       1.6.1       2020-04-29 [1] CRAN (R 3.6.3)
#>  utf8          1.1.4       2018-05-24 [2] CRAN (R 3.5.3)
#>  vctrs         <IP_ADDRESS>11 2020-04-25 [1] Github (r-lib/vctrs@d4a943d)
#>  withr         2.2.0       2020-04-20 [2] CRAN (R 3.6.3)
#>  xfun          0.13        2020-04-13 [1] CRAN (R 3.6.3)
#>  yaml          2.2.1       2020-02-01 [1] CRAN (R 3.6.2)
#>
#> [1] /home/robin/R/x86_64-pc-linux-gnu-library/3.6
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library

@mrzeyyyyy can you try installing the pct package with:
remotes::install_github("itsleeds/pct")

If you cannot get the data that way you can download the lines as a geojson file in the downloads tab from here: http://www.pct.bike/m/?r=west-yorkshire

Okay, I might not need this dataset anymore but I'll try the method you suggested. Thanks Robin! You may close this issue. Cheers.


Caching browser binaries

GHA caching docs recommend caching the NPM / Yarn cache (~/.npm / yarn cache dir), which does not have browser binaries. This means that the binaries are downloaded on every CI execution, which can be optimized. With the @actions/tool-cache package, this Action can potentially implement caching for binaries.
What this could look like:

Define the PLAYWRIGHT_BROWSERS_PATH environment variable to specify a fixed location for the binaries to be downloaded
Cache this location with tc.cacheDir(dir, 'playwright-browsers', playwrightVersion) (docs)
Restore at the same location with tc.find (docs)
This would require defining runs.post in the action.yml, like the actions/cache does it here. However, this bit is not documented in the metadata syntax reference for GHA ~(is it for some whitelisted actions only?)~

Verified with #11 that runs.post will work

Alternatively, we could achieve caching in user-land by reusing the cache action (this could be an MVP implementation):

Set the PLAYWRIGHT_BROWSERS_PATH to a certain path, and use the same path with the cache action
Use the cache action in the workflow (this will end up being duplicated, since users will have a caching action for npm/yarn already)

- name: Cache browsers
  id: cache-browsers
  uses: actions/cache@v1
  with:
    path: <same as PLAYWRIGHT_BROWSERS_PATH>
    key: key: ${{ runner.os }}-${{ hashFiles('package.json') }}

Define the PLAYWRIGHT_BROWSERS_PATH environment variable to specify a fixed location for the binaries to be downloaded

This has to be defined in user land - I think we won't be able to export env from-inside our action so that  it's used later on by clients steps. :(
Regarding the user-land setup - I'd probably cache against package-lock.json.
Also, do I understand correctly that those clients that already use cache action to cache their node_modules/ are caching browsers as well?

Also, do I understand correctly that those clients that already use cache action to cache their node_modules/ are caching browsers as well?

No, they are not. GHA caching for npm caches the ~/.npm directory (not node_modules) – docs.

I think we won't be able to export env from-inside our action so that it's used later on by clients steps. :(

Looking at the set-env command in GHA, it is possible for actions to share environment variables (all subsequent actions after set-env can access the variable). I'll try to do this from inside the action to validate the experience.

@arjunattam any success on that? Do you need help?

@arjunattam any success on that? Do you need help?

Currently its not planned to cache browser's. It's different on each language binding and depends on the version.
If you still want caching, you can do it manually with https://github.com/actions/cache
A
Cache key: playwright version (or whole file e.g. package.json, requirements.txt etc.)
Cache folder: https://playwright.dev/docs/browsers#managing-browser-binaries
As written above, this can be also leveraged using the PLAYWRIGHT_BROWSERS_PATH environment variable.

For caching binaries on GitHub Actions, see https://github.com/microsoft/playwright/issues/7249#issuecomment-1154603556
(Sorry for the zombie post; this issue comes in as the top result when searching for Playwright cache binaries, and I wanted to point weary travellers [such as my future self] in the right direction)


Combine fingerprint and add 808

Adding the 168 and 808 into one fingerprint for the 2018 Chrysler Pacifica Hybrid

Can you please rebase this on devel, so that the new fingerprint tests will run?

No. As I don't understand what you want me to do.

@arne182 , the request was to merge devel into your branch so automatic regression tests run and we can automatically catch if the fingerprint change will cause any issue.

What Riccardo said was correct. This link also has a good write up on what rebasing is. We would like to get this fingerprint fixed.

I've now included this change in https://github.com/commaai/openpilot/pull/590


When importing causes a startup error (Bun)

I have ran into this error when using bun for this when you import this package I run into this Error:
6:27:01 PM [vite] Error when evaluating SSR module /Users/eveeifyeve/projects/TeaClient/Website/astro.config.ts: failed to import "astro-page-insight"
|- Error: could not find function name for: function(string, characterLimit) {
  return Util.truncate(string, characterLimit);
}
    at getRuntimeFunctionName (/Users/eveeifyeve/projects/TeaClient/Website/node_modules/lighthouse/core/lib/page-functions.js:263:20)
    at module code (/Users/eveeifyeve/projects/TeaClient/Website/node_modules/lighthouse/core/lib/page-functions.js:270:35)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at <anonymous> (:2:1)
    at processTicksAndRejections (:12:39)

[astro] Unable to load your Astro config

could not find function name for: function(string, characterLimit) {
  return Util.truncate(string, characterLimit);
}
  Stack trace:
    at getRuntimeFunctionName (/Users/eveeifyeve/projects/TeaClient/Website/node_modules/lighthouse/core/lib/page-functions.js:263:20)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at moduleEvaluation (:1:11)
    at <anonymous> (:2:1)
error: script "dev" exited with code 1

repo to reproduce here: https://github.com/teaclientmc/website

Thanks for the report.
I'm not very familiar with bun, but from what I've found, it doesn't seem to be able to run lighthouse with bun right now.
https://github.com/oven-sh/bun/issues/4958
so I can't fix anything from this package at this time, so I'm closing it, sorry.

but I think it is accepted to work now (I just don't know what atw means well, though.)
https://github.com/oven-sh/bun/issues/8624


route matching

router.on({'tracks': function () {
console.log('tracks');
}
});`
router.on({'artist/:id/tracks': function (params) {
console.log('artist/' + params.id + '/tracks');
}
});
when the two routes are placed like this the second route is not marching it matches the first route it only works properly when the second route is on top

@cultulhul unfortunately the order of routes' addition matter in Navigo. The matching is based on regular expression so whatever matches first it wins. What I'm saying is that that's not a bug but an expected behavior.

ok thanks for clearing it up


Original dim 219, after padding 6 translation, 225

Hello,
Thanks for providing the model.
I am not sure how to pad the 6 translation to 225.
/Wenjie

Hi.
I have the same question.
Did you understand how to pad? thanks

@liruilong940607  @YIN95  where is the code pad 6 dims ?


Rest Parameter: Allow Bounded Array Type (Feature Request)

Marking as feature request (unless I'm misunderstanding this), but this would be really helpful... 😃
const test = <A: Array<*>, B>(func: (...args: A) => B, ...args: A): B => {
    return func.apply(null, args)
}

3: const test = <A: Array<*>, B>(func: (...args: A) => B, ...args: A): B => {
                                                 ^ A. rest parameter should have an explicit array type (or type `any`)
3: const test = <A: Array<*>, B>(func: (...args: A) => B, ...args: A): B => {
                                                                   ^ A. rest parameter should have an explicit array type (or type `any`)

Flow.org | Try

This is a known issue with Flow's implementation of rest params (at least).

Is this issue resolved or why was it closed? Or is there another issue covering this?


Added x86 architecture for Go version 1.14.7.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Is it detecting malware? The file is being hosted by Google.

/azp run

/azp run

/azp run


#572 and #612: DuckDB - PartitionedDataStore - PersistentDataStore

Fixes #572
Motivation

All analytics will run more efficiently by operating on top of partitioned parquet files.
Further, a lot of load/requirements can be offset from the duck.db persistent-storage and moved to our "efficient querying parquet export".
Live data requirements can then be met by querying persistent storage which should be up-to-date.

PartitionedDataStore deliver the requirements we need for [Process 3] of the ETL Pipeline.

DoD:

[x] Implemented DuckDB
[x] Introduced PartitionedDataStore for managing time-partitioned Parquet data (hive_partitioning).
[x] Implemented methods: append_data, finalize_data, query_data.
[x] Added pytest cases in test_partitioned_data_store.py.

PartitionedDataStore middleware:
please update/adjust/sign off when completed

[x] create_and_fill_table(self, df: pl.DataFrame, dataset_identifier: str)
[x] insert_to_table(self, df: pl.DataFrame, dataset_identifier: str)
[x] fill_from_the_csv_destination(bla bla [IDK for now)
[x] finalize_data_with_date_hive(self, dataset_identifier: str)
[x] finalize_data_with_address_hive(self, dataset_identifier: str, address_column: str)
[x] finalize_data_to_target(bla bla [IDK for now)
//Creates a temporary VIEW and the DB for the data, expensive but we can use if we run many queries on the same dataset
[x] create_view_and_query_data(self, dataset_identifier: str, query: str) -> pl.DataFrame
//The SQL query to execute. The query must contain a {dataset_path} placeholder.
[x] query_data(self, dataset_identifier: str, query: str, bla bla) -> pl.DataFrame

@kdetry can you please:

Address each conversation by providing a brief answer and resolving them
Update the checklist as you work towards completing this

Cheers!

I will add a short description about the work. Tests are not completed yet

I am going to split it into two separate PRs


RN 0.64: Scrollview StickyHeaderIndicies do not adjust when direct siblings' height changes

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
We have a scrollview with sticky elements where the height of certain items can change.
[StickyItem]
[NonStickyItem - height can change]
[StickyItem]
[NonStickyItem - height can change]
On version 0.63.4 this was working fine, however on 0.64 when the height of a non sticky item increases from 1X to 2X the sticky header gets pushed off the screen as if it was still 1X. Downgrading to version 0.63.4 fixes the issue.
React Native version:
System:
OS: macOS 11.3.1
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 9.26 GB / 64.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.14.0 - ~/.nvm/versions/node/v14.14.0/bin/node
Yarn: 1.22.10 - ~/.nvm/versions/node/v14.14.0/bin/yarn
npm: 6.14.8 - ~/.nvm/versions/node/v14.14.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK:
API Levels: 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 30.0.0, 30.0.3
System Images: android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>42882
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_282 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: ^0.64.0 => 0.64.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

create a ScrollView with sticky & regular elements
change the height of the regular elements
observe sticky headers scroll out before they should

Expected Results
It works like in RN 0.63.4

Closing as this version of React Native is several years old. Please re-open a new issue against the latest stable if the issue persists


Handwritten simple schema tracking PR

This PR will be used for tracking the progress of the handwritten typescript code that should later be generated by the typescript codegen.
The current version is still very basic and is following a simple schema (will added in this PR). Anything that could be of relevance for now is located in loader.ts but will later be moved to appropriate files and directories.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5abb127). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   69.84%
=======================================
  Files           ?       32
  Lines           ?      756
  Branches        ?      139
=======================================
  Hits            ?      528
  Misses          ?      165
  Partials        ?       63

Flag
Coverage Δ

unittests
69.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abb127...114f95f. Read the comment docs.

@ZimmerA Great to see the progress! How is the test coverage going?

More familiar with JS, but can read TS by focusing very hard and remembering some of the JS and Java 😄 great job @ZimmerA ! Looking forward to being able to parse CWL directly in the browser (wonder if we could incorporate it somehow in CWLViewer and move some of the processing off server to the client?).
Feel free to discard any of my review comments. I think the license is the only one that needs addressing before merging.
-Bruno

Thanks a lot for the review! For some reason I completely oversaw it (sorry 🤕) I will look at your suggestions as soon as I start working tomorrow 😄
Right now this code will probably only work in node but Browser support is my main priority after I have the basics working in Node!

@ZimmerA Great to see the progress! How is the test coverage going?

Going pretty well, I decided to start Implementing the actual codegen so I have more schemas to test against.
Definitely planing on adding more unit tests for the utility classes and functions though! I might need some help with that though, as my lack of experience with salad sometimes makes it hard for me to write meaningful tests.

I removed the types for ArraySchema, EnumSchema, RecordSchema, Recordfield because they weren't really needed for this example. Most of this is now auto generated code by the schema-salad TS codegen branch (see https://github.com/common-workflow-language/schema_salad/pull/479) excluding the test for SimpleSchema and the github workflow.
Now all that should be left to do is generating documentation strings and doing more testing (and Browser support)!

Closing this in favor of https://github.com/common-workflow-lab/cwl-ts-auto/pull/2
Thanks everyone for the help so far 🚀


fix get_ip error in pure ipv6 environment

fix https://github.com/vllm-project/vllm/issues/2685

@Yard1 @simon-mo Can any of you help review this PR? tbh, I don't have knowledge to review this PR :(

@simon-mo Can we merge this PR?


Update build workflow for Pypi; fixes for pubmed tests

The failing tests are both in test_pubmed:

test_pubmed_to_pmc (this works for me locally)
test_full_text (this also fails for me locally - returns None

Opened issue for that last failing test - this should be OK otherwise


diagnostics/tracing: inc RemoteRecorder max_span_batch to 100

Getting a lot of cassandra zipkin pool is busy connection error. Increasing max span batch per this:
https://groups.google.com/a/lists.datastax.com/forum/#!topic/java-driver-user/p3CwOL0kNrs
@cshoe @ckwang8128

@spladug I added to the commit msg

💇♂


DID document with string as verification method array

The DID document for did:onion:fscst5exmlmr262byztwz4kzhggjlzumvc2ndvgytzoucr2tkgxf7mid contains
strings instead of arrays for the properties authentication, assertionMethod, etc.:
https://github.com/BlockchainCommons/torgap-demo/blob/9ef2c68ffbf53404894a0e7ac73491142d550e09/public/.well-known/did.json#L31-L35
This is valid in JSON-LD. We could support this by using OneOrMany instead of Vec in the Document struct.

It is not clear that this is allowed in the DID core specification for authentication (and also assertionMethod, etc.):

The authentication property is OPTIONAL. If present, the associated value MUST be a set of one or more verification methods. Each verification method MAY be embedded or referenced.

A set seems to imply a list, and it's unclear that a single item constitutes a set with n=1. If our interpretation that this is not valid as per did-core and we decide not to support non-standard forms, then we can (1) request that the did-onion authors update their implementation. We could also (2) adopt a more permissive policy, but those tend to see interesting (mis)use when dealing with security elements.
I'm partial to (1) but would be happy to hear any feedback and discuss.
cc @ChristopherA

@wyc I agree with your observation.  The example also suggests so.
I have updated our live example and will open a PR to did-onion spec
cc: @OR13

Closing since even though it's valid JSON-LD, it's not clear if it's valid in DID Core - and we no longer have a DID document "in the wild" that uses this form.
There is some discussion about verificationMethod in https://github.com/w3c/did-spec-registries/pull/277 - but more about it's use in proof objects rather than in DID documents.


Feature request: Enlarge template to account for token shape

Option to take into account token shape, and add the token diameter/width/height to the template when template is centered on caster. So area spells centered on the caster function as expected with larger tokens.

Added in v0.6.8.


QA-14892 Backport

JIRA

https://jira.jahia.org/browse/QA-14892
Description
Backport

I'm a bit confused on this backport. We do not have this change in master: https://github.com/Jahia/jcontent/blob/master/src/javascript/JContent/JContent.accordion-items.jsx#L65
I'm assuming it's backporting this one https://github.com/Jahia/jcontent/pull/1143? but looks to be in a different spot in the code.
Should the change be done here instead? https://github.com/Jahia/jcontent/blob/2_x/src/javascript/JContent/JContent.accordion-items.jsx#L110


i18n-launch: SolutionForm disallowing Python projects

Included in the i18n launch was PR #40225 which added validation that campers are submitting the link to the live URL for their backend projects. This is great for the Node.js projects, but has broken the ability to submit Python projects.
This should be adjusted to pull the Python projects out of the scope of this validation.
Related forum post: https://forum.freecodecamp.org/t/problem-submitting-solution/445429?u=nhcarrigan

Sorry about that, I am getting right on it.
This completely slipped my mind.

Thanks Shaun, let me know if I can help.  While you're doing that, I'll put together some tests to make sure we don't recreate this bug.

@ojeytonwilliams A test or 2 would be ideal 👍


PD Basic Pipetting Steps: Pause (Sidebar)

As a protocol designer, I'd like to be able to view created pause steps in the steps sidebar.
Acceptance Criteria

Visual design updated to reflect mockup (linked below)
User can view pause icon
Clicking on step in sidebar opens pause editor

Closing as per @howisthisnamenottakenyet and @IanLondon


typescript dependency on typescript@next

TypeScript Version:  1.9.0-dev.20160627-1.0
I tried to install typescript only once using https://github.com/mariocasciaro/npm-workspace in a project with many small components, each of whom depend on TypeScript as a dev dependency.
When evaluating the output I saw that the typescript/node_modules folder contained a link pointing to itself again.
After some investigation I found out that this is due to the dependency of TypeScript on typescript@next in package.json.
Is there a real requirement on this, or this is an oversight that has not yet caused problems?
(I have no issue with that, but some code toolings follow this dependency again and again causing problems. (see also https://github.com/mariocasciaro/npm-workspace/issues/18))

We have dependency on typescript@next is used in out build system, gulp and tslint.

Interesting, I assumed there was some more sophisticated bootstrapping.
I can resolve this issue on my end by installing in "production" mode (i.e. ignoring the devDependencies).


Problem syncing received streams with a list in windows forms

Hello,
I’m having some trouble syncing the received streams with the loaded ones in a windows forms application.
I use the delegate to get the available subscribers and I put them in a list. Here’s the delegate I use, just  like in the examples:
private void Session_StreamReceived(object sender, Session.StreamEventArgs e)
{
Console.WriteLine("Session stream received");
// add the stream to the list of available streams, to connect them later...
}
The problem is that when I use just one connected user, there’s no trouble, but when I have multiple users connected, the streams received don’t sync with the ones I load in my list.  ( I add the Stream to the list in the delegate ).
How the windows sdk is working? with another thread , right?  How should I sync the list of available users I have?
please let me know
thanks so much
best

Hi,
I saw you posted this same in a stackoverflow question
Let me crosspost the comment here in case it helps anyone
Hi!, Can you provide some more details? The streams are only valid in the same session, if you connect to a different session you cannot use them. Once anyone joins the session and publish video StreamReceived will be called just once. When it leaves the session the StreamDropped is called. You should be able to maintain a list of subscribers by listening both events.

Have you found a solution? Can we close the issue?


Gauges not redrawing when window resize

This issue can be reproduced by using the code I sent you yesterday.
Just set the CustomPanel  as center to scene and then maximize window - gauges won't redraw.
Then minimize the window - gauges will be drawn with the scale as they're in the maximized window.
Note: This seems only to be affecting LinearSkin (maybe BulletChartSkin too), other gauges will redraw.
Note: Using medusa-5.3
PS> sorry for another issue

Also try setting values to gauges and then resize

Hmm...strange...I can't reproduce this one on OS X. I see the problem with the drawing outside it's bounds which seems to be related to the FullScreen Mode switch and I will try to fix this but I can't see the effect you described. Ideas?
Oh and btw don't worry about new issues...I'm happy to fix everything you'll find :)

Sending you screenshots
I was able to reproduce this on 2 PCs, both running Windows (8.1 & 7)
Issue persists even if I run this in JFXPanel
medusa_bug1 is when the window has full size
medusa_bug2 is when it's resized back from full screen - seems to draw gauges scaled to the max window

will test right now

Made further tests and release 5.5 seems to fix this problem...I hope ;)

Can confirm that the commit fixed both problems, BTW thanks for this awesome lib

Awesome...thanks a lot for testing... :)


Client Allocation Request for: 四川达见卓鸿广告传播有限公司

Client Allocation Questions
Core Information

Name: 四川达见卓鸿广告传播有限公司
Website / Social Media: https://aiqicha.baidu.com/company_detail_31235007382009
Region: Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f3wl2d5r2mscnbpk7piabeap2hafzepqllioqyoonehol23tjyialqxfsdjdtrguaxdkgujqk5mxnq4f2k455q
Notary Requested: MRJAVAZHAO

@hkhjkhoujkh Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hello, @hkhjkhoujkh
Please provide the following materials.
Organization name, business scale, social media accounts&follwers, and business license (could be sent by email); if you are an individual, please provide name, date of birth, working company and scale, employment certificate, social media accounts&follwers, and ID card (can be sent by email);
When did you start learning about Filecoin? Please give a description about the projects you have participated in ? What do you want to get from Filecoin? Any suggestions or expectations for the Filecoin Network?
Is there any law risk? What percentage of questions are yours?
Please describe your organization, such as established time, the number of employees, users volumn, the number of social media followers.
How about your data volume, source and later planning? Please describe the type, format, source, storage capacity, publicity (and if data could be public, how can others retrieve it?) of the data to be stored in Filecoin.
In which area do you plan to store you data? How many miners do you want to find ? Please list the miner ID. How about the proportion of the storage for each miner? What are the requirements about miners? At last, please state your redundancy plan.
Do you agree to disclose transaction information? If you get DataCap, please make the transaction information public on the Issue in time.

Sichuan Dajian Zhuohong Communication Co., LTD
We provide all integrated marketing services, including advertising, data and consulting. We customize brands according to different stages of brand development and specific needs based on market orientation, such as retail terminal promotion management, brand launch conference, brand product research, and special brand promotion. Cooperative industries such as tobacco industry, tourism industry, real estate industry and so on.
We do not operate official company social media accounts for the time being.
We learned about Filecoin this year, and because of the nature of our business, we had a lot of data and wanted to store it in a cost-effective way, so we looked at new technologies.
Sichuan Dajian Zhuohong Communication Co., Ltd. does not exist any legal risk.
Sichuan Dajian Zhuohong Communication Co., Ltd. was established in 2020. Although it is a newly established company, we have accumulated substantial customer resources before the establishment. Darjian Zhuohong has been committed to assisting customers to develop their brands and businesses. We continue to create precious cases with creativity, and through the integration of talent and expertise, innovation and operation. We have about 50 colleagues from operations, growth and innovation, advertising, and consumer experience working together to help our clients. At present, we have cooperated with more than 100 enterprise users, such as China Tobacco Yunnan, Shanghai Tobacco Group, Xiao You Technology and other well-known enterprises.
At present, our data has exceeded about 200T, and the stored data mainly includes various files, pictures, videos and market research reports in the business development process of the company. The data is partially public, and the ratio of public to non-public is about 3:7.
We don't care about the storage area, the number of miners is around 5 and there are no actual storage transactions yet, so everything is still pending. The storage ratio is probably in the range of 10%-30%. Miners need to be experienced in storing real data to ensure data security.
I agree to disclose

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzaceaasiuh7ujmnlb6gyme5gcvl4bovbdixhu6krz663ih6nbmcn7rva

Address

f3wl2d5r2mscnbpk7piabeap2hafzepqllioqyoonehol23tjyialqxfsdjdtrguaxdkgujqk5mxnq4f2k455q

Datacap Allocated

2TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzaceaasiuh7ujmnlb6gyme5gcvl4bovbdixhu6krz663ih6nbmcn7rva


[ FEAT ] Add client

Changes

[x] Add client dir
[x] remove unnecessary impoert in test
[x] rename actions

Can you tell us why we should add clients to this repo? (or why you prefer this way?)

The reason why monorepo is good for this kind of relatively small dapps projects that I think are

it enables us to share manifest.json and build bindings abi data(/dojo/typescript/model|contracts.gen.ts) easily.
When building project (e.g. Vercel) we need to refer the contract manifest.json but if repo is different, it'd be hard compare to monorepo
Having many repositories for the same project on GitHub makes it harder to maintain a clear overview, and since we currently have a small team of developers who aren’t working in a distributed manner, there’s no particular advantage to operating with a multi-repo setup.
Especially in the case of dApps, contracts can be easily deployed via RPC, and the frontend can be hosted on platforms like Vercel, so there are no significant disadvantages in managing resources within a single repository.


Sanitize each element of an array

I spotted a flaw when working with Swagger and using this tool - including within an array context (e.g. Swagger's parameter list) it returns an object rather than an array as it does for objects
base.yml
object:
  bob:
    type: "string"
    enum:
      $include: "items.yml"
fred:
  - type: "string"
    enum:
      $include: "items.yml"

items.yml
- "item1"
- "item2"
- "item3"

Output
## --------------------
## DON'T EDIT THIS FILE
## --------------------
## Engine<EMAIL_ADDRESS>## Source: base.yml

object:
  bob:
    type: string
    enum:
      - item1
      - item2
      - item3
fred:
  - type: string
    enum:
      '0': item1
      '1': item2
      '2': item3

With this fix in place:
object:
  bob:
    type: string
    enum:
      - item1
      - item2
      - item3
fred:
  - type: string
    enum:
      - item1
      - item2
      - item3

My JS foo is a work in progress so there might be a better solution?

@stefancarlton Thanks for your support!!!! :smiley:


Support Tact 1.4.4 when it lands on NPM

@logvik Tact v1.4.2 bugfix release just landed on NPM. Can you please update the plugin to use it?

Actually, let's update to Tact v1.4.3. @logvik do you have a timeline in mind?

Published today

Awesome! Thanks a lot!


Baseline monitoring infrastructure

Once the application is deployed and running, we'll want to be able to monitor things like queue throughput, availability, latency etc.
CloudWatch has enough tooling to be able to do what we need, and Spring Boot has built in metrics (through Micrometer) which can integrate with CloudWatch.
We should

configure Spring Boot to feed metrics to Cloud Watch - see https://reflectoring.io/spring-aws-cloudwatch/ for some background, we want to use Micrometer to have a minimal amount of configuration and management
set up a minimal dashboard through terraform
configure at least one metric to ensure it all feeds through - lets use /event-data-receiver for ingested events, incrementing a counter for each call to the API

Later, we'll need to consider what the most important metrics are and what we need to worry about

Logs have been covered in #36

This has been implemented and data is feeding through


Static egress IP addresses

The Scale team is launching a new feature that provides a set of static IP addresses for our users.
Refer to the launch document  and the Initiative document.
@albertoperdomo is SME.
https://prisma-company.slack.com/archives/C5Z9TH6N9/p1642711034099300

Alberto and I agree that we will create a sub-page of the PDOP doc to cover most of the content about IP addresses (motivation - why use static ips, context - when can you use when not, how it works - description of the feature), and also a "read more" link from the main PDP page to this sub-page.
PR # 2764 addresses the link, and PR # TBD addresses the sub-page.


fix(bch-js): Increased to v4.3.0

:tada: This PR is included in version 2.0.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Feature Request - Browser Based & Data Export

Hey, many thanks and keep up the great work! The iOS app has been wonderfully helpful.
Feature request(s):

It would be nice to have a chrome extension or be able to open up a web browser to view metrics/ change settings vs downloading / compiling and installing a whole application.  Similar to how configuration of a standard router would be; login page at "xxx.xxx.xxx.xxx", then dashboard/tabs/other layout.

Thank you for the simple metrics graph, this is very helpful in-app.
It would be great to export this data for further analysis. I would like to view this data in a spreadsheet environment to track metrics over a much greater period of time compared with other speed and usage vs outage metrics.

I second this feature request. Both of the features described by @SLAPSTICKdev would be incredibly convenient.

The last time I checked, neither the Nokia nor the Unified API gateways have a CORS policy that lets web apps make requests to them from a different domain. I can dig out an Arcadyan gateway and check again, but I doubt it's changed. That pretty much makes it impossible to make a hosted web app.
You should be able to export the snapshot data as JSON from the Settings page where you enable the graph.

Thanks for the quick response.
Shame about the browser. I honestly thought it would be relatively simple. Silly me. I can't understand how applications could be allowed to communicate with the device, but the browser running on the same device creates friction.
Unless I'm missing something, the iOS app doesn't have an export option on the settings page. There is an enable toggle and a clear button.

CORS is a browser-level policy that prevents websites from making local requests to other domains without those domains explicitly allowing it. In this case "domain" includes IP addresses. It's possible to make a web app that would be hosted at something like hintcontrol.app that makes a request on the browser side to <IP_ADDRESS>, but since the gateway doesn't allow requests from anywhere besides <IP_ADDRESS>, the browser will block them. Full applications don't have this limitation since CORS is part of the browser and not network requests themselves.
On iOS, there isn't an export button for the snapshots. Instead, open the Files app, go to the Browse tab, back out of iCloud Drive, go to On My iPhone, and then go into the HINT Control folder.

So a local server on a desktop with a simple html UI isn't allowed to work on the browser, but an application can contact the same ip as the host machine and it works? Doesn't the application make the same type of requests to the ip? This clearly goes beyond my scope of understanding. I appreciate your knowledge and patience.
Json has been found. He will be loved, but unfortunately put to work.
Thanks again!

A local server wouldn't be limited by CORS, but Compose isn't really set up to run as a server, just as a normal web app if that compilation target is enabled.
Theoretically I could add some extra logic to a web target to ask the user to set up a CORS proxy on the local network and provide the IP, but Compose for web still has a long way to go, and it ends up being easier to just use one of the native application targets.

Within the json file there seems to be multiple redundant entries, e.g. All of the "/mainData/signal/" values are duplicates of a subset of the "/cellData/cell/" values. Is there a reason for both of these entries to be displayed?

The snapshots just are just compiling the data returned from the various endpoints in the Unified API. /cellData/cell/[4g|5g]/sector is identical to /mainData/signal/[4g|5g] at least in structure. I haven't done enough testing to see if they're always the same data.


Print a warning when completion provider change the insert behaviour during resolve

This is one outcome from https://github.com/microsoft/vscode/issues/85741 and about a message (and telemetry?) that we should show whenever a CompletionItemProvider changes an item so that its insert, sorting, or filtering behaviour would change. E.g. only detail and description should be filled in. When command and/or additional edits come are added that also bad but less bad than changing range or filter text.

@mjbvz fyi - TypeScript is also on the radar for this because during resolve it modifies command and/or additionalTextEdits

Keeping this item open so that I can file issues based on telemetry


feat: godot 4.2

Depends on: https://github.com/decentraland/godot-explorer/pull/111
Re-imported assets were required due to the following warning:
WARNING: At least one surface uses an old surface format and needs to be upgraded. The upgrade happens automatically at load time every time until the mesh is saved again or re-imported. Once saved (or re-imported), this mesh will be incompatible with earlier versions of Godot.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7679c99) 13.05% compared to head (c9b4062) 13.03%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feat/update-gdext     #112      +/-   ##
=====================================================
- Coverage              13.05%   13.03%   -0.03%
=====================================================
  Files                    111      111
  Lines                  13874    13874
=====================================================
- Hits                    1811     1808       -3
- Misses                 12063    12066       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: nonce_mismatch log parsing

The actual error log that would bubble up is actually (using this in celestia-node)
broadcast tx error: account sequence mismatch, expected 357545, got 357544: incorrect account sequence

So seeking a prefix for account sequence mismatch would not work.

hmm the existing error message parsing seems fragile but why would it not work? If the error is: account sequence mismatch, expected 357545, got 357544: incorrect account sequence then that error message does have the prefix account sequence mismatch.
Before we change the behavior here, I think we need unit test coverage for the expected error messages.

hmm the existing error message parsing seems fragile but why would it not work? If the error is: account sequence mismatch, expected 357545, got 357544: incorrect account sequence then that error message does have the prefix account sequence mismatch.
Before we change the behavior here, I think we need unit test coverage for the expected error messages.

The error starts with: 'broadcast tx error: '

The error starts with: 'broadcast tx error: '

Is that just when the error gets bubbled up to celestia-node? I think that at the point where this error parsing is happening, the error message is just: account sequence mismatch, expected 357545, got 357544: incorrect account sequence. We need unit tests before we can be confident this change has the desired effect.

@rootulp let me know if a unit test is needed and if you have any particular flow you'd want to test, given above info!

Given that this piece of code (ParseExpectedSequence, ParseNonceMismatch) is not used

This PR changes the behavior of ParseExpectedSequence so how does it fix the issue if ParseExpectedSequence is not used?
Do you have concrete steps on how I can repro the issue you're observing? It would be helpful for me to repro if you created a bug report issue

We run a fork of celestia-node and we run it in our infra (a light node for mocha4 and mainnet).

We can only support on official releases from @celestiaorg here, FWIW.

I think it would make sense to contribute those changes to celestia-node so that others can use it and so it can be upstreamed to prevent you from running a fork. have you made a PR?

I think it would make sense to contribute those changes to celestia-node so that others can use it and so it can be upstreamed to prevent you from running a fork. have you made a PR?

Not yet, ran them over @renaynay (Rene Lubov) and was waiting for feedback.


Clicking a checkbox and clicking again during the timeout phase deletes multiple items in the table

Clicking a checkbox and clicking again during the timeout phase deletes multiple items in the table

Fix: Removed the timeout animation


node: gax typescript fix

One more fix related to #2070. Since google-gax TypeScript conversion GoogleProtoFilesRoot is now exported directly as gax.GoogleProtoFilesRoot, not as gax.grpc.GoogleProtoFilesRoot as before.

Codecov Report

Merging #2091 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2091   +/-   ##
=========================================
  Coverage     86.83%   86.83%
  Complexity     4987     4987
=========================================
  Files           448      448
  Lines         19722    19722
  Branches       2080     2080
=========================================
  Hits          17125    17125
  Misses         1889     1889
  Partials        708      708

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730f3fd...fa8782b. Read the comment docs.


Remove pod after Workflow/Pods finished

I think It's a good idea to delete finished pods to save disk usage.
so I add a strategy to implement this feature. #1230 , #1098 .
podgcstrategy is the strategy to control when to delete pods for GC.
after the pods deleted, you will never see it by kubectl get pods or argo logs <pod-name>.
it include four strategy

"upon-pod-completed": delete pods immediately when pod is completed, the completedPhase including phase succeeded, failed, error and skipped.
"upon-pod-succeeded": delete pods immediately when pod is Succeeded.
"upon-workflow-completed": delete pods when workflow is completed.
"upon-workflow-succeeded": delete pods when workflow is succeeded.

and there is the demo workflow to test it .
# podgcstrategy is the strategy to control when to delete pods for GC.
# after the pods deleted, you will never see it by `kubectl get pods` or
# `argo logs <pod-name>`.
# it include four strategy
#    - "upon-pod-completed": delete pods immediately when pod is completed, the completedPhase including phase succeeded, failed, error and skipped.
#    - "upon-pod-succeeded": delete pods immediately when pod is Succeeded.
#    - "upon-workflow-completed": delete pods when workflow is completed.
#    - "upon-workflow-succeeded": delete pods when workflow is succeeded.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: parallelism-limit-
spec:
  entrypoint: parallelism-limit
  podgcstrategy: upon-pod-succeeded
  parallelism: 2
  templates:
  - name: parallelism-limit
    steps:
    - - name: sleep
        template: sleep
        withItems:
        - arg1
        - arg2
        - arg3
        - arg4
  - name: sleep
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["echo lk; sleep 0.5; exit 0"]

do you have any suggestion about it ? @jessesuen @alexmt

I like the idea of this feature! Can we also customize the GC policy per workflow?
My company has a Kubernetes cluster with Argo for our researchers and they make their own own workflows and pods in their own namespaces. I think the policy of pod GC depends on the researcher, so we will need it configurable per workflow.

Oh, I realized you implemented it like so. That's cool!

@dtaniwaki , Of course	you	can	，you can define different GC policy for each Workflow.

@jessesuen Can you have a look? I want this :)

@discordianfish yes, we will make sure this is part of next release.

That's a very good improvement, specially in environments where the resource limit is strict as it doesn't allow to run further workflows unless the pods are deleted.

@jessesuen I see this was removed from v2.4. Is there anything I can help with to get either back into v2.4 or progress ready for v2.5? I have users making heavy use of Argo and managing the PVCs is becoming problematic for them.

I think it's being tracked by #1098

We can also use https://github.com/hjacobs/kube-janitor for complicated rules, but having simple GC in workflows is still a good idea.

@jackywu I meant to push my requested modifications to my fork, but accidentally pushed it to your fork! Anyways I pushed what I felt were improvements. Please take a look?
@dtaniwaki @sarabala1979 can you also take a look to see if we agree with syntax?

@jessesuen ok，I'll have a look very soon.

@jessesuen the code looks great, let's continue

I think we need a validation for the field.
By the way, is it possible to keep N pods per workflow, or is it too much?
For example,
podGCStrategy:
  onPodSuccess:
    history: 5
    delay: 30m

What do you think?

There's always room for adding functionality later, which is why I suggested to make it a struct instead of string. Here is my proposed syntax:
spec:
  podGC:
    strategy: OnPodSuccess

Note that strategy is a string, but podGC is a struct. This will leave room for something like this in the future:
spec:
  podGC:
    strategy: OnPodSuccess
    limit: 5
    delay: 30m

Note that OnPodSuccess is a string since all strategies would benefit from delay/limit.

@jessesuen Oh, I was reviewing old diff. That's cool! We can improve the strategies later.

K added validation.

cool.

I hope that it's not too late in the process, but I would suggest changing the name of podGC to podTermination so as to make it consistent with the Kubernetes jargon (see Termination of Pods).


tf.load_op_library unable to load manylinux2010 repaired custom ops

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No -- using https://github.com/tensorflow/custom-op (But it breaks for addons too)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu16.04
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): tf-nightly & tf-nighty-2.0-preview

Describe the current behavior
Currently when I build a custom op in the tensorflow/tensorflow:custom-op-ubuntu16 docker image using the defined steps I get an install-able pip package tensorflow_zero_out-0.0.1-cp27-cp27mu-linux_x86_64.whl
This works fine, however if I repair that wheel to be manylinux2010 compliant, then tf.load_op_library will fail to find the custom-op.
python -c "import tensorflow as tf; print(dir(tf.load_op_library('manylinux/tensorflow_zero_out/python/ops/_zero_out_ops.so')))"

['LIB_HANDLE', 'OP_LIST', 'ZeroOut', '_IS_TENSORFLOW_PLUGIN',
'_InitOpDefLibrary', '__builtins__', '__doc__', '__name__', '__package__',
'_collections', '_common_shapes', '_context', '_core', '_dispatch', '_doc_controls',
'_dtypes', '_errors', '_execute', '_kwarg_only', '_op_def_lib', '_op_def_library',
'_op_def_pb2', '_op_def_registry', '_ops', '_pywrap_tensorflow', '_six',
'_tensor_shape', 'deprecated_endpoints', 'tf_export', 'zero_out',
 'zero_out_eager_fallback']

python -c "import tensorflow as tf;print(dir(tf.load_op_library('manylinux2010/tensorflow_zero_out/python/ops/_zero_out_ops.so')))"

['LIB_HANDLE', 'OP_LIST', '_IS_TENSORFLOW_PLUGIN',
'_InitOpDefLibrary', '__builtins__', '__doc__', '__name__', '__package__',
'_collections', '_common_shapes', '_context', '_core',
'_dispatch', '_doc_controls', '_dtypes', '_errors', '_execute', '_kwarg_only',
'_op_def_lib', '_op_def_library', '_op_def_pb2', '_op_def_registry', '_ops',
'_pywrap_tensorflow', '_six', '_tensor_shape', 'deprecated_endpoints', 'tf_export']

Notice  'zero_out' &  'zero_out_eager_fallback' are not found in the loaded library for manylinux2010
Code to reproduce the issue
git clone https://github.com/tensorflow/custom-op.git && cd custom-op
docker run -it --rm -v ${PWD}:/workspace -w /workspace tensorflow/tensorflow:custom-op-ubuntu16 /bin/bash

pip install tf-nightly
./configure.sh
bazel build build_pip_pkg
bazel-bin/build_pip_pkg artifacts

# Installed auditwheel is too old for manylinux2010
pip3 install --upgrade auditwheel

# Libtensorflow framework needs to be on LD path
export LD_LIBRARY_PATH="/usr/local/lib/python2.7/dist-packages/tensorflow_core"

# Repair logs look more or less okay
auditwheel -v repair --plat manylinux2010_x86_64 artifacts/tensorflow_zero_out-0.0.1-cp27-cp27mu-linux_x86_64.whl &> repair.txt

Other info / logs
Here are the auditwheel repair logs:
repair.txt
Here are the readelf inspections of the so files:
readelf.txt
readelf-manylinux2010.txt
Here are the so files:
so-files.zip
cc @perfinion @gunan @yifeif
--------------------------EDIT--------------------
Here are the extracted whl directories which will work with the python tf.load_op_library commands from above. (Manylinux2010 repair makes it so the custom op depends on a newly copied libtensorflow_framework.so which is part of the new whl):
custom-op-dirs.zip

I remember I encountered an issue when there is a collision of names for added kernel ops. (used to be fine for 1.14, not with new tf-nightly) Wondering if there are multiple versions of zero_out kernel ops?

I remember I encountered an issue when there is a collision of names for added kernel ops. (used to be fine for 1.14, not with new tf-nightly) Wondering if there are multiple versions of zero_out kernel ops?

Thanks! Looking at the binaries' symbols I'm not seeing any duplication that isn't present in the .so before auditwheel repair though:
https://www.diffchecker.com/pfJbJX8g
Is there a way to increase the verbosity of the load_library call so we could see if there is a conflict or something else?
The only major difference I see is that the repaired binary requires the newly copied libtensorflow_framework-65610c2c.so.1 instead of the libtensorflow_framework.so.1 that would get picked up from the TF install. I'm not sure what the implications of that are though and without being about to step through load_library function it's a bit tough.

My previous issue was the LMDBDataset. I initially implemented LMDBDataset (C++) into TF's core rep (tf.contrib) some time ago. Later on since we try to modularize, the LMDBDataset has been moved to tensorflow/io. So there are two copies if both tensorflow and tensorflow-io are loaded.
That used to be fine. However, very recently I noticed that LMDBDataset in tensorflow/io is not working anymore with tf-nightly (couldn't remember which version but must be very recent), and I have to change the name in tensorflow/io to LMDBDatasetV2 to get around it.
Don't know if this could be related as well.

Ah the ibtensorflow_framework.so.1 is a known limitation of auditwheel.
I wrote a patch for auditwheel, to get around the issue :  tensorflow/io@02dcf4a

@yongtang Amazing thanks so much! Could you explain what that file edit does / why that patch works?
We'll should probably describe this and include the patch in custom-op repo.

EDIT -- Found out what policy.json was being editted:
https://github.com/pypa/auditwheel/blob/master/auditwheel/policy/policy.json
Thanks again for the patch @yongtang!

In the auditwheel 5.2.0 which is recently released, one can use --exclude option instead of editting policy.json:
auditwheel repair --exclude libtensorflow_framework.so.2 --exclude libtensorflow_framework.so.1 --exclude libtensorflow_framework.so some_wheel.whl

If one uses cibuildwheel, add the following option to pyproject.toml.
[tool.cibuildwheel.linux]
repair-wheel-command = "auditwheel repair --exclude libtensorflow_framework.so.2 --exclude libtensorflow_framework.so.1 --exclude libtensorflow_framework.so -w {dest_dir} {wheel}"


Nothing cannot accept level file directly anymore

This feature has a problem. If after loading a "singleton level" from the CLI I want to go to the level picker with (send '(game menu)) I actually have no place to go to, because I never provided the level folder.


Fix for go 1.17

This PR:

allows goversion to detect FIPS-only TLS for Go 1.17+ (code for that is borrowed from https://github.com/rsc/goversion/pull/21/commits/42d9398b0959b0342b4ff4087622c118cc164f69)
go mod tidy & go mod init

To test that this change works you can follow steps in fips-builds (Jetstack internal project) Readme against a fips version of cert-manager built with Go 1.17+ i.e v1.7.2 https://github.com/jetstack/fips-builds#verifying-the-images to verify that the build is/isnt' built with FIPS only TLS enforced

/lgtm


why is the isClosed  true after successfully connected

I have a problem in the production for reason. There is an issue almost like this issue#57 one. When occur any issue like passing wrong column name or smthg like that and after that sometimes we get closed connection and next queries fall with error Due to closed connection. As I declare my db variable final so I can fix my issue by reloading server. Now I want to check connection state before get Database instance and decide to whether reinitiate connection or not.

void main() async {
  final db = Database(
        '''
  );

  await db.open();
  print('isClosed: ${db.connection().isClosed}');
}

Just for Notice
My postgres is running in a different Docker container and my server is running in a different one. When any error occurs on the postgres site, its docker restarts and my server loses connection. How I can check state and reinitiate connection? I am open for any solution
postgress_db:
    container_name: "rohtj_db"
    image: postgres:16
    restart: always
    volumes:
      - ./rohtj_db/data:/var/lib/postgresql/data
    environment:
      POSTGRES_DB: rohtjdb
      POSTGRES_USER: rohtjdbuser
      POSTGRES_PASSWORD: ------
      PGDATA: /var/lib/postgresql/data/pgdata
    ports:
      - 5434:5432
    expose:
      - 5434
    networks:
      - rohtj-backend

Please check if this issue still happens with version `0.14.0


Create Calendar timeZone/Region/Country Specific

Firstly, what an awesome plugin. Design is great and easy to use, we'll documented.
Create Calendar timeZone Specific
Use case:
mygiftshop website(store based in Australia) allows users from around the world
to purchase a gift and have it delivered to their family in AU on a certain date.
Could we set the timeZone of the calendar displayed to the user?
Is there a quick workaround for this?
Cheers Thank you,

I dont understand your question. Can you explain, why you need a change of the timezone? Is there any time that is displayed? maybe you can add some screenshots?

Hi there,
thanks for your feedback!
At this point, MCDatepicker does not support time zone changing.


Use notify-forked

The notify crate updated its fsevent-sys version which broke our builds. @ashleygwilliams forked notify and pinned its dependency to a version that works.

What's the advantage over having the code into a folder ./deps (or similiar) in this repo?

@xtuc this is temporary - will switch back when this issue is solved https://github.com/passcod/notify/issues/211
Going to merge this because it's breaking everything


Add a props to remove the on hover on table rows

add props withoutHOverOnRow

Codecov Report

Merging #709 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files         264      264
  Lines        6802     6802
  Branches     1588     1588
=======================================
  Hits         6783     6783
  Misses         19       19

Impacted Files
Coverage Δ

src/components/tables/Table.tsx
100% <ø> (ø)
:arrow_up:

...omponents/tables/table-children/TableChildBody.tsx
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa72354...176d0fa. Read the comment docs.


build: do we have a way to build golang package with more security option

We build golang use following commands reference from
https://src.fedoraproject.org/rpms/golang/blob/rawhide/f/golang.spec
./make.bash --no-clean -v
GOROOT=$(pwd) PATH=$(pwd)/bin:$PATH go install -buildmode=shared -v -x std
GOROOT=$(pwd) PATH=$(pwd)/bin:$PATH go install -race -v -x std
The golang binary and libs in package is not include security option, such as: pie, bind_now, relro, sp(stack protection) etc.
Is there a way to enable these options?
We can add these option for normal go programs use command like below:
CGO_ENABLED=1 \
CGO_CFLAGS="-fstack-protector-strong -fPIE" \
CGO_CPPFLAGS="-fstack-protector-strong -fPIE" \
CGO_LDFLAGS_ALLOW='-Wl,-z,relro,-z,now' \
CGO_LDFLAGS="-Wl,-z,relro,-z,now -Wl,-z,noexecstack" \
go build -buildmode=pie -ldflags '-extldflags=-static' -ldflags '-w -buildid=none -linkmode=external -extldflags=-Wl,-z,relro,-z,now ' -o xxx .

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

i may face the same question,here is the disscution gopher slack link


CupertinoContextMenu is using setState after it was unmounted

In order to reproduce, delete a few items from the context menu.

Minimal reproducible code

import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(const MaterialApp(
    home: Scaffold(
      body: SomeStateful(),
    ),
  ));
}

class SomeStateful extends StatefulWidget {
  const SomeStateful({super.key});

  @override
  State<SomeStateful> createState() => _SomeStatefulState();
}

class _SomeStatefulState extends State<SomeStateful> {
  final items = List.generate(2, (index) => index).toList();

  @override
  Widget build(BuildContext context) {
    return ListView(
      children: items
          .map((e) => CupertinoContextMenu(
                  actions: [
                    CupertinoContextMenuAction(
                      child: const Text('DELETE'),
                      onPressed: () {
                        setState(() {
                          items.remove(e);
                        });
                        Navigator.of(context).pop();
                      },
                    )
                  ],
                  child: SizedBox(
                    width: MediaQuery.of(context).size.width,
                    child: Material(
                      child: ListTile(
                        title: Text('Item $e'),
                      ),
                    ),
                  )))
          .toList(),
    );
  }
}

Code block where the exception happens context_menu.dart
void _routeAnimationStatusListener(AnimationStatus status) {
    if (status != AnimationStatus.dismissed) {
      return;
    }
   // here the CupertinoContextMenu state is unmounted but we call setState
    setState(() {
      _childHidden = false;
    });
    _route!.animation!.removeStatusListener(_routeAnimationStatusListener);
    _route = null;
  }

Hi @tapkain
I'm not sure I can understand the issue. Can you be more specific?
I'm seeing you call setState() on CupertinoContextMenuAction. How does this sample code present the issue?

@huycozy it would be nice if you would run the example.

CupertinoContextMenu is pushing a preview route to render the context menu preview.
We delete an item in the CupertinoContextMenuAction and pop this preview route
CupertinoContextMenu route starts to play its route pop animation
one of the "items" state property got removed  in CupertinoContextMenuAction, so we rebuild the State
CupertinoContextMenu unmounted itself from the widget tree, yet the route pop animation above calls setState inside CupertinoContextMenuState., bad things happen later.

my current solution which worked for me is just to check if the state is mounted in context_menu.dart > _routeAnimationStatusListener
the issue in nutshell is when there is a list of CupertinoContextMenus and they are built from some state and if we have a delete action inside those menus, it will always throw by playing the pop animation.

if we have a delete action inside those menus, it will always throw by playing the pop animation.

Do you mean it should not have pop animation? Can you be more specific on Actual result and Expected result?
It looks like a proposal to add unmounted check to _routeAnimationStatusListener. Can you be specific about that check with sample code?

I mean it should not call setState if not mounted. The pop animation is fine.
Actual result - after pop animation calls setState while being unmounted
Expected result - after pop animation does not call setState

context_menu.dart change proposal
```dart
void _routeAnimationStatusListener(AnimationStatus status) {
    if (status != AnimationStatus.dismissed) {
      return;
    }
   // here the CupertinoContextMenu state is unmounted but we call setState
   // add here check for mounted
    if (mounted) {
    setState(() {
      _childHidden = false;
    });
    }
    _route!.animation!.removeStatusListener(_routeAnimationStatusListener);
    _route = null;
  }
```

Thanks for raising the issue! @tapkain

Code block where the exception happens context_menu.dart

I can reproduce the exception using your code sample

logs
flutter: ══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
flutter: The following assertion was thrown while notifying status listeners for ProxyAnimation:
flutter: setState() called after dispose(): _CupertinoContextMenuState#01594(lifecycle state: defunct, not
flutter: mounted, tickers: tracking 0 tickers)
flutter: This error happens if you call setState() on a State object for a widget that no longer appears in
flutter: the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error
flutter: can occur when code calls setState() from a timer or an animation callback.
flutter: The preferred solution is to cancel the timer or stop listening to the animation in the dispose()
flutter: callback. Another solution is to check the "mounted" property of this object before calling
flutter: setState() to ensure the object is still in the tree.
flutter: This error might indicate a memory leak if setState() is being called because another object is
flutter: retaining a reference to this State object after it has been removed from the tree. To avoid memory
flutter: leaks, consider breaking the reference to this object during dispose().
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1103:9)
flutter: #1      State.setState (package:flutter/src/widgets/framework.dart:1138:6)
flutter: #2      _CupertinoContextMenuState._routeAnimationStatusListener (package:flutter/src/cupertino/context_menu.dart:595:5)
flutter: #3      AnimationLocalStatusListenersMixin.notifyStatusListeners (package:flutter/src/animation/listener_helpers.dart:240:19)
flutter: #4      AnimationLocalStatusListenersMixin.notifyStatusListeners (package:flutter/src/animation/listener_helpers.dart:240:19)
flutter: #5      AnimationController._checkStatusChanged (package:flutter/src/animation/animation_controller.dart:815:7)
flutter: #6      AnimationController._tick (package:flutter/src/animation/animation_controller.dart:831:5)
flutter: #7      Ticker._tick (package:flutter/src/scheduler/ticker.dart:249:12)
flutter: #8      SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1289:15)
flutter: #9      SchedulerBinding.handleBeginFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:1141:11)
flutter: #10     _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
flutter: #11     SchedulerBinding.handleBeginFrame (package:flutter/src/scheduler/binding.dart:1139:17)
flutter: #12     SchedulerBinding._handleBeginFrame (package:flutter/src/scheduler/binding.dart:1056:5)
flutter: #13     _invoke1 (dart:ui/hooks.dart:158:13)
flutter: #14     PlatformDispatcher._beginFrame (dart:ui/platform_dispatcher.dart:337:5)
flutter: #15     _beginFrame (dart:ui/hooks.dart:101:31)
flutter:
flutter: The ProxyAnimation notifying status listeners was:
flutter:   AnimationController#ce10a(⏮ 0.000; paused; for _ContextMenuRoute<void>)➩ProxyAnimation
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════


Add ars-technica extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Yep! lgtm. Thanks!


New tag for PR #9

Hi! We are currently implementing this terraform module and ran into the issue fixed in https://github.com/threatstack/threatstack-terraform/pull/9
Can we get a new tag/release so we can pin to an actual release with notes and not pin to a git sha? Thanks!

All set @sherzberg Check out 2.1.1 (https://github.com/threatstack/threatstack-terraform/releases/tag/2.1.1)

Thank you!


Running Balances not displayed correctly

Name of Defective Feature Running Balances
System Settings (Required)
ToolKit Version: 2.0.3
Operating System (Mac/Windows/Etc): Windows 10
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: Version 64.0.3282.167 (Official Build) (64-bit)
Other Extensions: AdBlock, Grammerly, Wikibuy, EBates
Export of Toolkit Settings (Bottom Left of Settings Page)
 Import/Export Settings
Settings Export

[paste settings here]Show Running Balance
Adds a running balance column to the accounts page (does not appear on All Accounts View)

Steps to Reproduce the Behavior

Open YNAB
Open any account (Checking, Savings, etc.)

Expected Behavior
 correct display
Actual Behavior
outflow is under memo.  inflow and balance (is not displayed completely ie 2000 is displayed 20... is under outflow )

Doesn’t appear to be same issue.  Columns are shifted in display.
From: Josh Madewell<EMAIL_ADDRESS>Sent: Tuesday, February 20, 2018 5:23 PM
To: toolkit-for-ynab/toolkit-for-ynab<EMAIL_ADDRESS>Cc: manfromnc49<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [toolkit-for-ynab/toolkit-for-ynab] Running Balances not displayed correctly (#1196)
@manfromnc49 https://github.com/manfromnc49  I think this is related to: #1161 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1161  and should hopefully be fixed with #1186 https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1186
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1196#issuecomment-367141400 , or mute the thread https://github.com/notifications/unsubscribe-auth/AbNqy-OMfshikruyQAuQT9_htxEocvjYks5tW0WpgaJpZM4SMwOY .  https://github.com/notifications/beacon/AbNqy77a5IhIXKR5rrGOxAtqKXToY5-fks5tW0WpgaJpZM4SMwOY.gif

Hey @manfromnc49 the fix for this should be in our current release. If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!

Thanx Josh…I am trying it and the fix appears to be working….Michael…
From: Josh Madewell<EMAIL_ADDRESS>Sent: Friday, March 16, 2018 12:08 AM
To: toolkit-for-ynab/toolkit-for-ynab<EMAIL_ADDRESS>Cc: manfromnc49<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [toolkit-for-ynab/toolkit-for-ynab] Running Balances not displayed correctly (#1196)
Closed #1196 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1196 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1196#event-1524752901 , or mute the thread https://github.com/notifications/unsubscribe-auth/AbNqyxq7nXw32Dt2VLzIM6kha3z4QtIGks5tezqSgaJpZM4SMwOY .  https://github.com/notifications/beacon/AbNqy2Mj1xLBQ632w9WmY1fL9y3hmsKWks5tezqSgaJpZM4SMwOY.gif


Added ROI Calculator

Fixes Issue🛠
Closes #859
Description👨💻
Gives the amount gained on your investment.
Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅

[x] Tested all the results from an already existing ROI calculator on web
[x] Verified all the results from the manual formulae.

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Pls style and enhance the UI to little extent and always add your calculator in index.html file in alphabetical order @Yuvraj960

@Rakesh9100 I have Updated the styles.css, I am sure you will like it.

@Rakesh9100  Some unusual conflict was happening in the merging so one calculator named salary estimation calculator was removed, I have added that back again in new commit so please verify if everything is all right in merging activity now.

Merged 🎉 @Yuvraj960
Pls check these and keep in mind on priority basis from the next time contribution:-

CSS file name should be style.css and not styles.css.
Add the Readme according to the template, you can check the Readme of existing calculators. You can add your extra things as well but maintain the structure.
Add your calculator in index.html file in alphabetical order!!


Transition weirdness from disabling inputs/buttons

https://jsfiddle.net/langdonx/enztjawz/
The transition on .btn has it appearing disabled slightly behind its neighbors.
Is there anything that can be done to also transition the inputs to disabled, or is that a browser thing that we have no control over?

The .btn class has a transition duration of 0.2s while the .form-control class has transition of 0.15s which is why you're seeing the delay.
You could just override the CSS of the .btn or .form-control classes to match like so:
https://jsfiddle.net/enztjawz/3/
Not sure if that was intended, if needed I could submit a PR for it to update transitions to all match but its a quick fix to do in your own CSS file.

Transitions matching as of e7ae1d90698a618d4c7847621c50a13ce31ae7f9.


Enables iterating over index endpoint results in a given block

In stead of creating a very large array I would prefer to iterate over the results directly.

This allows us to do the following:
client = Ioki::PlatformClient.new
product = client.products.first
stations = client.stations(product, options: { auto_paginate: true }) do |station|
  puts station.id
end

LGTM. And sorry for the delay. I'll probably not be working on ioki-ruby this month.

Sorry, didn't have the time earlier. Since we're not streaming, I don't really see the advantage and it loses the clearness of "each" in the call. But that might be just me. I'm not opposed to it, just wondering why this is better than good old ".each do", which signals iteration.

@rmehner The advantage is, that the results array is not created in its entirety, because it could become rather large. Instead each page is requested one by one and the results are yielded. So in a sense, this is a sort of streaming, but rather on a index page basis.

Instead each page is requested one by one and the results are yielded.

I read that part of the code wrong. That makes a lot of sense indeed. Thanks for clarifying!


Ignore files and folders with a name starting with a dot

If it doesn't already, generate_site.sh should ignore dotfiles and folders. They are either generated by the system (not the user) and not really photos, or generated by the user and meant to be hidden.
For some reasons, one of my albums had a few dotfiles otherwise named like a photo (with a JPG extension), but they were 4096B big and weren't really pictures. They caused PIL to fail with an PIL.UnidentifiedImageError. I removed then and moved on.

Interesting. It should already be ignoring anything starting with a dot. Perhaps a regression though, as I refactored a lot of the directory stuff.

Ok dotfiles should not be skipped all through the tree, not just at the top.


Update request: seahub 9.0.10 → 11.0.0

Package name: seahub
Latest released version: 11.0.0

Current version on the unstable channel: 9.0.10
Current version on the stable/release channel: 9.0.10

[x] Checked the nixpkgs pull requests

The package is broken on nixos-unstable because Django 4.2 removed the providing_args argument for django.dispatch.Signal. https://docs.djangoproject.com/en/4.2/internals/deprecation/#deprecation-removed-in-4-0.
The package failed in runtime instead of build time because the package sets dontBuild = true.
The issue was fixed in upstream https://github.com/haiwen/seahub/pull/5502. And the fix is already released in v11.0.0-pro.
Log:
Oct 03 04:19:16 mtl0 systemd[1]: Starting Seafile Server Web Frontend...
Oct 03 04:19:16 mtl0 systemd[1]: Started Seafile Server Web Frontend.
Oct 03 04:19:16 mtl0 gunicorn[8928]: Traceback (most recent call last):
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/bin/.gunicorn-wrapped", line 9, in <module>
Oct 03 04:19:16 mtl0 gunicorn[8928]:     sys.exit(run())
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 67, in run
Oct 03 04:19:16 mtl0 gunicorn[8928]:     WSGIApplication("%(prog)s [OPTIONS] [APP_MODULE]").run()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/base.py", line 236, in run
Oct 03 04:19:16 mtl0 gunicorn[8928]:     super().run()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/base.py", line 72, in run
Oct 03 04:19:16 mtl0 gunicorn[8928]:     Arbiter(self).run()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/arbiter.py", line 58, in __init__
Oct 03 04:19:16 mtl0 gunicorn[8928]:     self.setup(app)
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/arbiter.py", line 118, in setup
Oct 03 04:19:16 mtl0 gunicorn[8928]:     self.app.wsgi()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/base.py", line 67, in wsgi
Oct 03 04:19:16 mtl0 gunicorn[8928]:     self.callable = self.load()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
Oct 03 04:19:16 mtl0 gunicorn[8928]:     return self.load_wsgiapp()
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
Oct 03 04:19:16 mtl0 gunicorn[8928]:     return util.import_app(self.app_uri)
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/6d2hnh4p82r0w3zhslxnr019k7fl8rnx-python3.10-gunicorn-21.2.0/lib/python3.10/site-packages/gunicorn/util.py", line 371, in import_app
Oct 03 04:19:16 mtl0 gunicorn[8928]:     mod = importlib.import_module(module)
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/pzf6dnxg8gf04xazzjdwarm7s03cbrgz-python3-3.10.12/lib/python3.10/importlib/__init__.py", line 126, in import_module
Oct 03 04:19:16 mtl0 gunicorn[8928]:     return _bootstrap._gcd_import(name[level:], package, level)
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap_external>", line 883, in exec_module
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/08dwi9sf17j33dnm1gawl655nfw9rli5-seahub-9.0.10/seahub/__init__.py", line 2, in <module>
Oct 03 04:19:16 mtl0 gunicorn[8928]:     from .signals import repo_created, repo_deleted, clean_up_repo_trash, \
Oct 03 04:19:16 mtl0 gunicorn[8928]:   File "/nix/store/08dwi9sf17j33dnm1gawl655nfw9rli5-seahub-9.0.10/seahub/signals.py", line 5, in <module>
Oct 03 04:19:16 mtl0 gunicorn[8928]:     repo_created = django.dispatch.Signal(providing_args=["org_id", "creator", "repo_id", "repo_name", "library_template"])
Oct 03 04:19:16 mtl0 gunicorn[8928]: TypeError: Signal.__init__() got an unexpected keyword argument 'providing_args'
Oct 03 04:19:16 mtl0 systemd[1]: seahub.service: Main process exited, code=exited, status=1/FAILURE
Oct 03 04:19:16 mtl0 systemd[1]: seahub.service: Failed with result 'exit-code'.

Notify maintainers

@greizgh @schmittlauch

Note for maintainers: Please tag this issue in your PR.

I have a local branch that updates seafile-server and seahub to the latest, but it doesn't yet handle upgrading the local database. I'm also unsure I've covered every new python dependency, but it's at least got me to the point where it passes nix-build -A nixosTests.seafile, seahub working locally and I can upload a file.
In case that amount of work helps maintainers, please let me know and I can push my branch somewhere or open a draft PR against nixpkgs.

It seems that version 11 is still in beta (according to the download page, their tags cannot really be trusted).
Also note that there is a PR to update to 10: https://github.com/NixOS/nixpkgs/pull/249523

In case that amount of work helps maintainers, please let me know and I can push my branch somewhere or open a draft PR against nixpkgs.

Thank you for that, that would be super helpful :pray:

EDIT: if maintainers find themselves too busy at this moment, I could put in some more time and try to work the database migration out by myself and get a PR out for review.

I can't promise anything but having a PR we can discuss would definitely be a first step. The update process is fairly barebone: we execute specific sql scripts.

Also note that there is a PR to update to 10

Oh, nice. I see you added a reviewer too. Does it make sense to get your PR in before I create one to update to seafile 11, especially since 11 is beta (I hadn't noticed that)? Would it help if I review it?

The update process is fairly barebone: we execute specific sql scripts.

Oh, I saw that but think I saw somewhere that seafile's update script does a bit more than just applying changes to the sqlite DB. But I might be misremembering. In any case, you've done this before and I have just installed seafile a month ago, so I think it's safe to ignore whatever I think I saw for now.

In case that amount of work helps maintainers, please let me know and I can push my branch somewhere or open a draft PR against nixpkgs.

I would be interested in that to try out the latest seahub.

@mohe2015 I have pushed my branch with seafile 11 to https://github.com/mzabani/nixpkgs/, branch update-seafile-only. Please backup your seafile data before trying that, as it does not have data migration code yet. It might also be on top of not very recent nixpkgs, but it shouldn't be too hard to rebase.

I am getting an error building seahub on nixos-unstable from today:
error: builder for '/nix/store/v0pli8c784ja24qzjwz18x8fkf6bv19w-python3.12-django-compressor-4.5.1.drv' failed with exit code 1;
       last 10 log lines:
       > /build/django_compressor-4.5.1/dist /build/django_compressor-4.5.1
       > Unpacking to: unpacked/django_compressor-4.5.1...OK
       > Repacking wheel as ./django_compressor-4.5.1-py2.py3-none-any.whl...OK
       > /build/django_compressor-4.5.1
       > Finished executing pypaBuildPhase
       > buildPhase completed in 34 seconds
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for django_compressor-4.5.1-py2.py3-none-any.whl
       >   - django>=4.2 not satisfied by version 3.2.25
       For full logs, run 'nix log /nix/store/v0pli8c784ja24qzjwz18x8fkf6bv19w-python3.12-django-compressor-4.5.1.drv'.
error: 1 dependencies of derivation '/nix/store/fjc7kqmgx8kln903r9vpr18jzid6vq2c-seahub-10.0.1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/xr6hs6bvmgavjrq681lcfnhxbp6a571q-unit-seahub.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/q7bnjcry95wxahi8wgya2v696p3yn5x1-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/izywdiz9fdqrsn7zywwfdjaxqmi6hadb-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/k59ckcz9wqn4l3ak2cwjs2h06q7h2gjv-nixos-system-raspberrypi-24.11.20240926.1925c60.drv' failed to build

Is anyone else running into this? I don't know if I'm doing something wrong so it'd be good to confirm. And it might be good to check if seafile 11 helps avoid this issue..


Missing comma in SQL script

Hi,
i noticed there is a comma missing in this SQL script
SELECT
TOP 100 *
FROM
OPENROWSET(
BULK '/users/NYCTripSmall.parquet',
DATA_SOURCE = 'ContosoLake'          <-
FORMAT='PARQUET'
) AS [result]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7fd3e66e-a012-dd40-34f3-1e84865605bc
Version Independent ID: d0fc26d6-2a86-dbed-2f48-c798b551f3f0
Content: Tutorial: Get started analyze data with a serverless SQL pool - Azure Synapse Analytics
Content Source: articles/synapse-analytics/get-started-analyze-sql-on-demand.md
Service: synapse-analytics
Sub-service: sql
GitHub Login: @saveenr
Microsoft Alias: saveenr

@DaSenf Thanks for your feedback! We will investigate and update as appropriate.

@DaSenf I am seeing it correctly -

Are you checking en-us language version of the document ?

Thanks
Saurabh

Someone fixed it yesterday. I´m seeing it correctly now as well :)

@DaSenf We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Run ClearCache on Setup Install

This is an attempt to fix #1162. For some reason, the component model cache is not being cleared properly onNTVS upgrade installs with VS 2015 update 3. This force clears the cache.

:+1: if this is sufficient (the word "attempt" is throwing me off). much better than custom actions.

I tested with a local, unsigned msi and it worked but this needs more verification before I'm confident. I'm going to merge this in and send out a signed build for testing.


[EventGrid] Add a from_connection_string method

one of the feedback in ux study was to add a from_connection_string method similar for storage, keyvault.

There is no concept of connection string in KeyVault (unsure what you're talking about then)
Storage has one, because you can copy/paste a connection string from the portal
As far as I'm aware, there is no way to get a connection string from the portal for EventGrid, and connection string builder are not recommended on client side (that's not why we have some).

To discuss with wider team, but I'm suspicious there is anything to do here.

Agree that there's no value in having a connection string builder for the sake of this, but would be worth to discuss it with service team and keep this in backlog.

Agree that there's no value in having a connection string builder for the sake of this, but would be worth to discuss it with service team and keep this in backlog.

Putting it in backlog, we shall not do it until service team provides a connection string on portal

Putting it in backlog, we shall not do it until service team provides a connection string on portal


Error get_provider_name

Hi,
I found a mistake inside the class. (v1.3.0 (2016-02-20))
line 690 : get_provider_name($this->claimed_id) == 'yahoo'
PHP said : Fatal error: Call to undefined function get_provider_name()
'$this' is missing. I added it and it's working perfectly now.

Oups I just saw the pull request with the same subject...

i merged the bugfix :)
you need to change get_provider_name to $this->get_provider_name

@Arthom, thanks for the PR!

Thanks for the notice, guys!
I don't use this library (or PHP at all) anymore, so I didn't have an environment to test the whole library after the change and only tested the function implementation itself in an online PHP-sandbox.
I merged the PR, the issue is now fixed.