Incorrect credentials issue when uploading directory directly to GEE Assets

#Thanks very much for this tool. Everything seemed to work well for me except that I couldn’t upload a directory to GEE Assets due to the issue below after I typed the password. I am pretty sure I input the correct password and tried many times but always got the same error. Any suggestions? Thanks!
“2017–11–02 18:08:31,628 :: root :: ERROR :: Incorrect credentials. Probably. If you are sure the credentials are OK,  #ref
resh the authentication token. If it did not work report a problem. They might have changed something in the Matrix.”
Cheers
Joey

Hey,
Thanks for reporting! Can you share an archive with the directory you wanted to upload? It would also help if you could tell me more about your environment (OS, Python, anything special?). Also, please make sure you don't have two-factor authentication enabled.
Cheers,
Lukasz

Sorry for the late reply.
I am using Windows 10 (Education) with Anaconda Python 2.7.13 (64-bit).
Two-factor authentication is not enabled for my gmail account and I also turned on the "less secure apps".
My command on Command Prompt is
"geebam upload -u<EMAIL_ADDRESS>--source "E:/GRACE" --dest "users/zunyixie/GRACE_Img_Collection"
Every time after I input the password, I will get the "Incorrect credentials error" below.

I am having the last try via Google Service account as below, but still wait for google earth engine to approve my account.
geebam upload -s<EMAIL_ADDRESS>-k "C:/Users/uqzxie1/Google Drive/Google_Earth_Engine/Moudles/privatekey.json" --source "E:/GRACE" --dest "users/zunyixie/GRACE_Img_Collection"
I will keep you updated after my service account gets approved.
Thanks for your help!
Cheers
Joey

Hi Lucasz,
Please close this issue as I believe this should be my single unlucky issue.
I had my last try on my Windows desktop at home, and found exactly the same error saying 'Incorrect Credentials', then I started suspecting my gmail account.
I registered a new gmail account and used it to apply a new GEE, then try geebam/geeadd again, it worked!!!!!! I used my current gmail to register GEE in 2014 but never used it until recently. I had no problem of logging in GEE using this email but have no idea why it has no credential to access my GEE given that I have made all the settings like earthengine authenticate etc.
Now I will upload data to this new gmail account and share the data with my old one, where I stored all my testing scripts.
Sorry for the hassle, and thanks for trying to help.
Cheers
Joey

Hi Joey,
Many thanks for coming back with this information. Unsurprisingly, I could not figure out what could be wrong, because, as usual, "it works our end". Since it's not uncommon problem, I will create a troubleshooting guide on what to check first. I am glad it worked for you ultimately!
Cheers,
Lukasz

Hi Lukasz,
Thanks very much for your geebam, which runs like magic now.
Cheers
Joey
On 9 November 2017 at 01:03, Lukasz Tracewski<EMAIL_ADDRESS>wrote:

Hi Joey,
Many thanks for coming back with this information. Unsurprisingly, I could
not figure out what could be wrong, because, as usual, "it works our end".
Since it's not uncommon problem, I will create a troubleshooting guide on
what to check first. I am glad it worked for you ultimately!
Cheers,
Lukasz
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tracek/gee_asset_manager/issues/40#issuecomment-342844270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJhCSGPYiS63DuRPhASAnPCm557hpIoks5s0cKmgaJpZM4QQkbV
.


impossible to install on my Android phone

I am under Adroid 11, it is not possible for me to install this version (04.0) it just marked (application not installed) The 0.3.2 installation works.

From what I could find It can be caused by a lot of different things... I finally managed to launch the open testing campaign on the Playstore. I could work better https://play.google.com/store/apps/details?id=net.casimirlab.frigoligo.

Fine !
Thanks !

Just so you know, the underlying issue should have been fixed with the latest release: https://github.com/casimir/frigoligo/issues/56#issuecomment-1677380376.


Issue with static IP and Layer 4 LoadBalancer on GKE

Rancher versions:
rancher/server:preview
When I want to expose a workload, say nginx, to the world, I configure the port 80 to be exposed as port 80 as L4 LoadBalancer. For GKE, Rancher then automatically creates an IP in GKE causing an issue when you already have a static IP (quota exceeded). Either it should take the one that is already there or ask me which one I would like to link to (or at least give me the option to configure it).

@Toflar - Rancher uses port 80 for ingress.  You will have to use a different port to expose nginx out to the world.  This is not a bug and we do not plan on changing it.

Rancher is not installed on the the GKE cluster...

Rancher creates a service with type=LoadBalancer, which goes into Pending state.  The cloud provider configured for the cluster is then responsible for watching for these and creating/assigning a balancer to satisfy them.  In this case the cloud provider is GKE's, and they create a new balancer with a new IP for each request.  There may be an annotation or something you can specify to request reusing one.
(But if so you'll need to create the workload and service separately, since there's nowhere to pass annotations for the service in the UI while creating a workload.  And creating standalone services has not made it into the UI yet, though you can do it with YAML).


Endless loop rancher server logs on helm3 install failure

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Add catalog:  	https://argoproj.github.io/argo-helm specify helm2 name it helm2
Add catalog  	https://argoproj.github.io/argo-helm specify helm3 name it helm3
Using helm2, install app argo-cd and name it foo
Delete foo
Using helm3, install app argo-cd and name it foo

Result:
This fails as expected due to helm3 not having the crd-install hook option. However, there are endless logs on the rancher server every 1 second:
2020/03/06 22:28:37 [ERROR] AppController p-kctnb/foo [helm-controller] failed with : wait helm template rendering notes failed. manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: namespace: , name: foo-argocd-application-controller, existing_kind: rbac.authorization.k8s.io/v1, Kind=ClusterRole, new_kind: rbac.authorization.k8s.io/v1, Kind=ClusterRole
: exit status 1

Other details that may be helpful:
This happened for me in an upgraded setup. I previously had deployed a few apps in the setup before upgrading (using helm2) and used the same chart URL on my new catalog after upgrading, but had that one use helm3.
Can workaround this by deleting the clusterroles and clusterrolebindings that were created in this case: kubectl delete clusterroles foo-argocd-application-controller foo-argocd-server
kubectl delete clusterrolebindings foo-argocd-application-controller foo-argocd-server
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): Rancher version 63306835a (master-2375-head)
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): 3 Linode nodes all roles
Machine type (cloud/VM/metal) and specifications (CPU/memory): 2cpu 4gb each node
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:20:10Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-11T18:07:13Z", GoVersion:"go1.13.6", Compiler:"gc", Platform:"linux/amd64"}

When I am running with the most recent code in head I am seeing this upon initial delete
W0307 17:19:45.915485   49630 reflector.go:326] github.com/rancher/steve/pkg/clustercache/controller.go:184: watch of *v1.PartialObjectMetadata ended with: an error on the server ("unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout exceeded while reading body)") has prevented the request from succeeding
W0307 17:19:45.923993   49630 reflector.go:326] github.com/rancher/steve/pkg/clustercache/controller.go:184: watch of *v1.PartialObjectMetadata ended with: an error on the server ("unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout exceeded while reading body)") has prevented the request from succeeding

And then when I try to install again I see:
E0307 17:38:12.342875   49630 reflector.go:307] github.com/rancher/steve/pkg/clustercache/controller.go:184: Failed to watch *v1.PartialObjectMetadata: the server could not find the requested resource
2020/03/07 17:38:12 [INFO] Stopping metadata watch on argoproj.io/v1alpha1, Resource=applications
2020/03/07 17:38:12 [INFO] Shutting down argoproj.io/v1alpha1, Kind=Application workers

Steps to reproduce (least amount of steps as possible):
Add catalog: https://argoproj.github.io/argo-helm specify helm2 name it helm2
Using helm2, install app argo-cd
Delete foo
Using helm2, install app argo-cd again
I turned off steve and it seemed to fix the issue and I do not see the endless rancher server logs even when following the original steps you submitted

Current master has proxy turned off by default - this seems to have fixed the issue of fresh install having helm 2 and helm 3 crd install issues

Validated in master-2417-head Rancher version 01c482d5f
This issue has been resolved. The same steps do not generate any endless logs, and the apps install correctly with no issues with both helm2 and helm3.


[SPARK-44652] Raise error when only one df is None

What changes were proposed in this pull request?
Adds a "raise PySparkAssertionError" for the case when one of actual or expected is None, instead of just returning False.
Why are the changes needed?
The PR ensures that an error is thrown in the assertion for the edge case when one of actual or expected is None
Does this PR introduce any user-facing change?
Yes, the PR affects the user-facing API assertDataFrameEqual
How was this patch tested?
Added tests to python/pyspark/sql/tests/test_utils.py

Merged to master and branch-3.5.


how to connect to king-phisher server in amazon aws

Issue Description
How to connect to King-Phisher server installed on amazon aws
I have installed king-phisher server in ubuntu machine hosted in amazon-aws , how should i connect to this using king-phisher client. what should be the username and password i should be using (since aws uses key pair for normal ssh connection and there is no password associated with the usename)
Reproduction Steps

Start King Phisher
Do something to trigger the crash

Environment Details

Host OS: Ubuntu 15.10 GNOME, Kali 2, etc.
Error Details / Stack Trace

If you are opening an issue regarding the client, copy text from the "Error
Details" of the error dialog in the client here. If you are opening an issue
regarding the server copy the relevant lines from the logs here.

ssh into your AWS server and set the password for the account via the passwd command. Once you have set the password. From there you will need to adjust your client configuration file to utilize the ssh key for authentication along with your password that you have set. Server Authentication section of the wiki will walk you through this process.


Delete event log when model is deleted

Is it possible to delete any related event logs, when the model is removed.
For example.
User 1 created Book 1
User 1 was then subsequently removed, thus meaning the activity would need to be deleted too

At the moment, if I delete User 1 I now get Trying to get property of non-object in the activity log.

The package does not do that for you, you'll need to take care of this yourself.


Video Player

Add video player. This could be done with auto-blocking, i.e. by embedding the video player when encountering a-tags with a youtube source.
Should have features:

youtube source
can be used independently or  in columns / other blocks
can be on the same page multiple times
thumbnail image
overlayed play button
after clicking, video features as per original site

Mobile (here multiple on same page):

Desktop (here multiple on same page):

Inspirations:

https://github.com/hlxsites/elco-aerotop-sg/tree/main/blocks/youtube-player
https://github.com/adobe/helix-block-collection/tree/main/blocks/video

@Acidham yes that's just a side effect of me having uploaded thumbnails of different aspect ratio in the content. an author would fix that by using same-sized images everywhere.


Add possibility to inject string into cache instead of file from disk.

Adds the possibility to insert a string as the contents of a file in the cache, instead of reading it from a file from disk. Allows completion from in-memory strings without going through the filesystem.

Hi @bjornarg
Thanks for the patch, do you have code that uses/requires this?

racerd requires the ability to cache buffers like this. There are a few gotchas worth mentioning. First, it is important to also update the masked version of the source as well. If the masked version had been accessed before updating the cache, future operations could result in a panic due to differences in the raw vs masked (imagine asking for a completion from a position in raw which doesn't exist in masked). Second, without changes to the FileCache, old allocations will be leaked. This is probably not an issue for short lived processes, but it is a critical issue for racerd.
This branch attempts to address the mentioned issues. I hope to get this merged eventually, but there is currently some unsafe code in the FileCache implementation that needs to get refactored into an Arena implementation that supports allocation reuse (and thus remove the unsafe code from Racer). Further discussion of the racerd branch should probably be in #422 as to not hijack this thread.

Closing because functionality is in #452, thanks @bjornarg


Pocketmine CRASH

[Server thread/CRITICAL]: ClassNotFoundException: "Class spoondetector\SpoonDetector not found" (EXCEPTION) in "/src/spl/BaseClassLoader" at line 144

How do you reproduce the issue?

He isn't using the poggit build

@NiclasQueen Try downloading the latest phar here.


Demo site doesn't work due to missing tables

I'm not sure if this is new with Rails 6, but when I try to load https://localhost:3000/ after running the following, I get a "ActiveRecord::StatementInvalid in BootstrapController#form. Could not find table 'users'" error:
bundle
cd demo
./bin/rails db:setup
./bin/rails s

Yeap. I adjusted readme. Thanks.

Thanks! My apologies for not just submitting a PR for that.


Windows: Both insider and normal version: Unable to open 'xxx': Assertion Failed: argument is undefined or null

Both insider and normal version:
Insider:
Version: 1.44.0-insider (user setup)
Commit: 6cf3dd97465b2f4f666b66758991d720e003b0f4
Date: 2020-03-27T06:00:06.803Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
Normal version:
Version: 1.43.2 (user setup)
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
Steps to Reproduce:

Open any file with vscode

Unable to open 'react-debug.md': Cannot read property 'other' of null.
Unable to open 'react-debug.md': Assertion Failed: argument is undefined or null.
3. Already tried to delete C:\Users\username\.vscode and C:\Users\username\.vscode-insiders. It doesn't work.

Update
4. When I deleted settings.json, vscode works again...

Does this issue occur when all extensions are disabled?: Yes

Hi! I have problem exactly like this. I delete setting.json but It doesn't work. There is another solution for this? Thank you!

I had the same problem with Normal VSCode, but Insider Version worked for me.
Deleting settings.json from Normal Version also worked for me.
Location: $HOME/Library/Application Support/Code/User/settings.json

Same issue here. This issue must not be resolved.

I just had the same issue and this is how I fixed:
go to -> C:\Users[USER_NAMD]\AppData\Roaming\Code\User\settings.json
and look for "editor.quickSuggestions": null. Change the value to either false or null
I hope it helps you.

"editor.quickSuggestions": null

I got this line added going through the Settings user interface screens to Text Editor | Suggestions, and clicking "edit in settings.json" under Quick Suggestions. Removing this line entirely also gets around this issue.

I just had the same issue and this is how I fixed:
go to -> C:\Users[USER_NAMD]\AppData\Roaming\Code\User\settings.json
and look for "editor.quickSuggestions": null. Change the value to either false or true
I hope it helps you.

This actually works.

I just had the same issue and this is how I fixed:
go to -> C:\Users[USER_NAMD]\AppData\Roaming\Code\User\settings.json
and look for "editor.quickSuggestions": null. Change the value to either false or true
I hope it helps you.

Thanks, it worked:)

I have this problem, open vs code, open file display
Unable to open 'react-debug.md': Cannot read property 'other' of null.
Unable to open 'react-debug.md': Assertion Failed: argument is undefined or null.
Can't open settings.json in settings
I installed vs Code on D disk and couldn't find settings.json.
I hope you can help me

Why this issue is closed. I have spent with solving this whole evening. It is a bug

I just had the same issue and this is how I fixed:
go to -> C:\Users[USER_NAMD]\AppData\Roaming\Code\User\settings.json
and look for "editor.quickSuggestions": null. Change the value to either false or true
I hope it helps you.

Thanks, it worked:)

I just had the same issue and this is how I fixed:
go to -> C:\Users[USER_NAMD]\AppData\Roaming\Code\User\settings.json
and look for "editor.quickSuggestions": null. Change the value to either false or true
I hope it helps you.

Thanks it worked :)
And for ubuntu users to edit settings.json go to this path: $HOME/.config/Code/User/settings.json.
You can check this website:   https://supunkavinda.blog/vscode-editing-settings-json

Having the same problem:   cannot open any files in editor.  Maybe an extension corrupted something.  I have uninstalled and reinstalled multiple times and I keep getting the message below when I try to open - for example - an html file.
"Assertion Failed: argument is undefined or null."


x/tools/cmd/goimports: support repairing import grouping/ordering

I'm working on a tool to fix up non-conventional or incorrect imports grouping/ordering, but I'd much rather have this be part of goimports. Would it be welcome?
What goimports does now
When goimports adds or removes an import, it heuristically attempts to find a good place for it. So if I add an os.Open() call, and my imports already look like this:
import (
	"context"
	"testing"

	"github.com/Sirupsen/logrus"
)

Then goimports will put "os" in the proper spot, beween "context" and "testing". That's great!
What goimports does not do
If my imports are not grouped and sorted in the conventional way, goimports will not usually fix the problem. For example, if I was using the old context package, my imports might look like this:
import (
	"testing"

	"github.com/Sirupsen/logrus"
	"golang.org/x/net/context"
)

When I edit the context import to the new package, "context", I have this:
import (
	"testing"

	"github.com/Sirupsen/logrus"
	"context"
)

Running goimports will notice that logrus and context don't make a proper group, so it will separate them:
import (
	"testing"

	"context"

	"github.com/Sirupsen/logrus"
)

But this isn't what we really want. Ideally, it would just re-group and re-order all the imports, to yield:
import (
	"context"
	"testing"

	"github.com/Sirupsen/logrus"
)

Work so far
I have a tool that will globally reorder imports according to the grouping rules, including the associated doc-comments; see below. I could also develop similar funcitonality inside goimports.
My tool is not nearly perfect: It doesn't handle multiple import declarations; it doesn't know about import "C". It's not even clear what should happen to random non-doc-comments inside the import block, eg:
import (
	"github.com/Sirupsen/logrus"

	// When we re-order, what happens to this comment?

	"testing"
)

Automatically grouping and ordering would also be a behavioral change for goimports, so it would have to be behind a flag for now.

Improving goimports is welcome.

Hey can I please pick this issue ? I would need a bit guidance though.

Here's what I did before: https://github.com/vasi-stripe/gogroup . Note that this is not exactly what we want in goimports, it still has a number of issues.

So it turns out that goimports already does this, but only in limited cases. If a file is missing an import, and has multiple import decls, they get all merged together and then sorted. The merging seems to lose associated comments, but otherwise this should be possible to repurpose.
See https://github.com/golang/tools/blob/master/go/ast/astutil/imports.go#L151-L173

Hi @vasi-stripe, in my opinion the goimports should have an option to remove all blank spaces before formatting.  Today, if I have imports unordered and separated by spaces the tool doesn't work as expected.
Example (goimports will not do anything):
import (
	"strings"

	"github.com/pkg/errors"

	"net/http"
)

Expected:
import (
	"net/http"
        "strings"
        "github.com/pkg/errors"
)

@wedneyyuri, I disagree with two things there:
(1) "goimports should have an option". We don't like options in code formatters.
(2) that you expect no blank line between the standard library imports and github stuff. goimports is opinionated in that regard.
I agree that the original bug report at the top is a bug, though. It should try to pack things nicely.

I'd like to extend this proposal with a specific grouping of imports: stdlib, VCS repo-local, non-local.
For example,
package foo // github.com/org/repo1/foo

import (
    "context"
    "os"

    "github.com/org/repo1/foo/bar" // Same VCS repo as this file
    "github.com/org/repo1/foo/baz"

    "github.com/org/repo2/quux" // Different VCS repo
    "github.com/thirdparty/repo"
)

I have written a tool importsort that achieves this by finding the VCS root directory for the file that it is processing, then it looks at the imports in the file and checks if a path is prefixed by the VCS root directory import path.

I just learned that goimports does allow grouping imports with the -local flag, but does so in the order of stdlib, non-local, local. That ordering is fine.
My proposal is determining local/non-local programmatically by looking at the VCS root directory.

I think ideally ordering should only depend on contents of the imports block. Reasons why not VCS/etc:

vendor vs GOPATH vs GOROOT vs ... Package may reside in various places and it may or may not be under VCS control. Different users of the same project may have different setup of their dependencies and goimports must (IMO) produce exactly the same output for them so it cannot rely on assumptions like this. Also some other tools store packages in completely different places - Google Bazel is an example (see Working with external dependencies).
I don't know how people use it but I personally like to run goimports before tests/builds to remove unnecessary imports, etc. The more work goimports needs to do to format the imports the less viable this option is. Doing more disk I/O is not great.

Why not something simple like this
import (
    "context" // Std lib goest first
    "os"

    "github.com/org/repo1/foo/bar" // Everything else goes second after one blank line
    "github.com/org/repo1/foo/baz"
    "github.com/org/repo2/quux" // Comment X
    "github.com/thirdparty/repo"
)

I would really like goimports to be as deterministic and as opinionated as possible. Like gofmt - nobody's favourite formatting but one of the most liked features. During PR reviews I've never had to say anything about formatting but many times about the "wrong" grouping/ordering of imports. Would be great to solve this problem once and for everybody.

Is anyone working on this? The algos for groupings is one thing but repairing holes in the simples possible stdlib/otherlibs can perhaps be done first?

@dahankzter, I don't know of anybody working on this. They would generally announce so here.

I've fixed this case through clearing new lines between imports and then regrouping them.
But now, test for https://github.com/golang/go/issues/7132 issue is failing. The issue #7132 looks very similar to that, the only difference - here we have "std package".
Due to this set of funcs, "context" and "gu" are the same for goimports:
// importToGroup is a list of functions which map from an import path to
// a group number.
var importToGroup = []func(importPath string) (num int, ok bool){
	func(importPath string) (num int, ok bool) {
		for _, p := range localPrefixes() {
			if strings.HasPrefix(importPath, p) || strings.TrimSuffix(p, "/") == importPath {
				return 3, true
			}
		}
		return
	},
	func(importPath string) (num int, ok bool) {
		if strings.HasPrefix(importPath, "appengine") {
			return 2, true
		}
		return
	},
	func(importPath string) (num int, ok bool) {
		if strings.Contains(importPath, ".") {
			return 1, true
		}
		return
	},
}```

@bradfitz Should I separate std and such "gu" packages?

@bradfitz Is anything blocking the above "pull request"?
I've been using Serhii's changeset for a while now and IMO it makes working with goimports quite significantly more pleasant to use. I'd be nice if we could merge the changes sooner than later. 🙂

@lhecker, vacation is. I'm back in a week. I'll get to it at some point after then.

@bradfitz Oh I'm sorry. Don't bother with my silly question - Please do enjoy your vacation instead. 😄
We'll surely get around to this at some point either way. 🙂

I'm using this too. There were some cases when it doesn't work properly, so it's better to use the last patch.

Given the issues (#27673, #28200) introduced by this CL, please roll golang/tools@12a7c31 back.

IMHO a tool pretending to be smart and doing wrong things should be avoided.
We actually use a 4-group layout: standard, local, third-party, and protos.
And for some cases, we use a 5th group for packages that are imported for side-effects.
This CL doesn't really make the already organized code more readable, but only helping the real chaos ones -- and it's not capable to tell if such regroup is actually needed.

@bradfitz please, revert this CL. Needs to handle the comments issue and clarify what import groups should be on the output.
@ashi009 Do you manage import grouping manually?

@saheienko, the revert no longer merges cleanly due to changes made since then.
Could you send a manual revert?

Nevermind, I rebased it. It's now reverted.

@ashi009 Maybe we can allow goimports to give people the right to sort imports in both the old way and the new way.  By doing so, everyone's need can be satisfied.

@ashi009 Maybe we can allow goimports to give people the right to sort imports in both the old way and the new way.  By doing so, everyone's need can be satisfied.

gofmt does it one way and is not configurable and people like it that way. Why goimports should work differently? In fact, why imports formatting is not part of gofmt?

We are not adding style preference knobs to goimports.

@bradfitz if I sent a change for determining the local import path with the module path, sorting all imports as the reverted commit does and also fixed the comment issues, is there a high chance of it being merged?

For anyone who wants this now and doesn't really care that the comments get misplaced, feel free to use go.coder.com/go-tools/cmd/goimports. That fork will be kept up to date for Coder's usage.

There is already a "knob":
  -local string
    	put imports beginning with this string after 3rd-party packages; comma-separated list

But it is pretty useless without full re-grouping :(

Is there any prescriptive behavior that goimports could adopt here that doesn't break the use-cases above?
One idea that addresses the original concern is to maybe reorganize imports more prescriptively from any import block that's "wrong" (contains imports from multiple sources) but leave any other blocks alone. So, e.g.:

 import (
     "testing"

     "github.com/Sirupsen/logrus"
     "context"
 )

Second block contains a mix of stdlib and 3rdparty, and should be broken up. goimports sees that there's an existing stdlib block, so it moves "context" there:
 import (
     "context"
     "testing"

     "github.com/Sirupsen/logrus"
 )

 import (
     "testing"

     "github.com/Sirupsen/logrus"

     "github.com/org/repo1/foo/bar"
 )

No blocks contain a mix of sources: nothing to do.

Though honestly, I would prefer a tool that was more prescriptive.
I see the benefits to not having knobs (things are more similar across different codebases, no need to argue about the values of the knobs), but by both not being prescriptive by default and not allowing for prescriptive knobs, we're back to needing humans to catch style violations in code review, needing authors to fix things manually, and maintaining a style guide, all of which feel worse than having knobs.
And as @ernado points out, there already is a knob fairly related to this functionality.
Spitballing: instead of a -local knob, maybe there could be a more generic knob that takes some specification of what sections are desired? Something like -sections stdlib,3rdparty,gitlab.com/mycompany/repo,gitlab.com/mycompany/repo/go/genproto

I'm +1 on being more prescriptive and making goimports more aggressively normalize import blocks.  There should be one true way to do it, including whitespace.
If we really need to add a knob, I'd want it to be IN the codebase (per file or per module) rather than a flag to the binary.
IMO, running goimports with no special args should be the canonical guidance to import ordering.

I've never seen so many engineers agree with each other! We at CircleCI are also planning to switch away from this tool to gosimports because it actually enforces the 3 sections, and we're wasting too much time manually correcting the results of goimports

GCI  would do this.

GCI  can do this and it is built-in in golangci-lint.

@daixiang0 But GCI does not support multiple prefixes in one group https://github.com/daixiang0/gci/issues/107

@yjc567 you can implement it in GCI.

I have recently implemented a tool and framework for programmatically managing imports that is

Deterministic
Handles comments gracefully
Handles user import groupings gracefully
Highly configurable and easy to extend and build on top of
Compatible with https://pkg.go.dev/golang.org/x/tools/go/analysis

https://github.com/NonLogicalDev/gofancyimports


Demo-Chat Code?

Great work! It's a very good design for the Demo-Chat web, allowing users to choose the image token. Could you pls upload the Demo-Chat Web code in the repository?

Hi @xjywhu 🤗,
We have uploaded the demo code to the new branch, 'demo-chat'. :wave:
And the code is based on the LLaVA framework with modifications. To help with analysis, we've provided the original unmodified LLaVA code in the commit 49b53a00dfd3a2d62ab79b8fdf5bc20d41b17ab9. You can compare this with the latest version to see the changes made.
I will close this issue. If you have any further questions, feel free to open a new issue or re-open this one. :blush:
Best,
Senqiao

Hi Senqiao:
Great! Many thanks for your demo code!
Best,
Jingyu

Hi Jingyu,
Thank you for your kind words. I hope VisionZip will be helpful for your research.
Best,
Senqiao


fix: Corrects the wrong JSdoc comments

Wrong comments lead to a faulty Typescript Definition file missing
the depth attribute.
Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)

Updates the Documentation

Describe the changes below:
Depth property was missing in generated type script definition file. Correcting these paths fixes this error.

👍


First value different on CUDA/ROCM when setting seed

What is the issue?
This seems to be an issue with the kv cache on Nvidia/AMD GPUs. See https://github.com/ggerganov/llama.cpp/issues/2838

Worth noting, setting temperature: 0 didn't seem to give consistent results either. Despite what is said in that linked ticket. Not sure if that is a related issue or something separate. See #5012 for reproducible error


Error: wrong number of arguments for macro 'baz' (given 0, expected 0)

Hello,
This code:
module Foo
  module Bar
    macro baz
    end
  end
end

include Foo::Bar

Foo.baz # Should be undefined

Fail, but with the wrong error message:
Error: wrong number of arguments for macro 'baz' (given 0, expected 0)

It seem append since the version 0.23:

carcin v0.22.0
carcin v0.23.0

Reduced:
module Foo
end

macro foo
end

Foo.foo # Error: wrong number of arguments for macro 'foo' (given 0, expected 0)


Publisher Cache Folder

How would I navigate the WebView to a html page that is in a Publisher Cache folder?
I would like to share this html file across multiple UWP applications with the same publisher so this is probably where one would put the file but I don't know the Uri that points to that folder. If I use the path to the page in the Publisher Cache folder then I get some HRESULT exception with no details as to why it failed.
Help would be greatly appreciated.

This appears to be a question about the feature itself, not a question about the sample. You can follow the instructions on Windows developer support for support options. (Click "Forums and community".)
(I don't know if this is the best way, but one way is to create a stream from the file, and then navigate to the stream.)

This appears to be a question about the feature itself, not a question about the sample. You can follow the instructions on Windows developer support for support options. (Click "Forums and community".)
(I don't know if this is the best way, but one way is to create a stream from the file, and then navigate to the stream.)


Bug: 当使用devtools时,如果组件在项目包目录下packages/@core下,无法定位

Version
Vben Admin V5
Describe the bug?
webstorm , 通过插件点击概览

无法识别@

Reproduction
如上图
System Info
webstorm

Relevant log output
Could not open sub-menu.vue in the editor.
When running on Windows, file names are checked against a safe file name pattern to protect against remote code execution attacks. File names may consist only of alphanumeric characters (all languages), periods, dashes, slashes, and underscores.
Validations

[X] Read the docs
[X] Ensure the code is up to date. (Some issues have been fixed in the latest version)
[X] I have searched the existing issues and checked that my issue does not duplicate any existing issues.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

这个应该不是项目的原因，可以向插件仓库提issue。


Build binaries for all platforms

Build release binaries for Windows, Mac, & Linux.
These binaries are also uploaded to GitHub release pages.

@shayne my github release workflow doesn't have permission to write to ghcr.io/shayne/tsnet-serve.
I'll try and figure out what to do about that later.

I just granted you perms on the package

It worked!


[Question] Support for Moodle Website

Hi,
Your plugin seems to be great ! I would like implement it on our Moodle Website for sharing scripts with our developers, users... We use the last version of Moodle. The Text Editor is Atto. We already use syntaxhighlighter plugin (Prism is better) and it works fine (this is a specific moodle plugin).
My question is the Prism compatibility with Moodle ? How integrate it on this Framework (i have difficulties with this) ?
thanks !
Quentin

Hi. I guess this could be made the same way the syntaxhighlighter plugin was made. The thing that might be tricky is that Prism does not autodetect languages.


Android Basics: Load and display images from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:'
labels: ''
assignees: ''

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-internet-images?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-4-pathway-2%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-internet-images#2
In which task and step of the codelab can this issue be found?
Task: 3
Step: "Use Binding Adapters"
Sub-step: 4
Describe the problem
The text "add a let{} block to the imageURL argument" should read "add a let{} block to the imgUrl argument"
Additional information
Include screenshots if they would be useful in clarifying the problem.

@hassan0599
Thank you for reaching out to us. The typo was fixed and published:


[v2023.1.0 compatibility]: RR's Kafka driver updated

Hey @butschster 👋🏻
RR Kafka driver was in the BETA stage. The new driver, which is arriving in the v2023.1.0, has a different configuration and doesn't fit the current PHP implementation. Currently, you may see the new JSON keys in the code (just look at the json marks): https://github.com/roadrunner-server/kafka/blob/master/kafkajobs/opts.go#L62
Later, they will be available with the description in RR's .rr.yaml configuration reference. But until that, you may evaluate the amount of work TODO.
One important note, the NEW driver configuration is going to be STABLE, not beta.

@rustatian Hi!
Could you provide informtion about required fields and default values?

@rustatian Hi!
Could you provide informtion about required fields and default values?

Here you are: https://github.com/roadrunner-server/roadrunner/blob/master/.rr.yaml#L1527


Spike: metadata completeness

Following on from ministryofjustice/data-catalogue#62
Create a report/dashboard which pulls from postgres (DataHub entity store) to display metadata completeness
Could be:

Superset dashboard
A page on find-moj-data which live queries postgres
A scheduled workflow on find-moj-data which feeds a static file for a page, to avoid loading the database so much

#62


Markdown links on third-party modules containing images are overriden by a link to the image itself

See the 'docs' badge at https://deno.land/x/bcrypt/ for an example.
The README  has a link to the actual docs but gets overridden by the following code in the markdown renderer:
https://github.com/denoland/deno_website2/blob/56f9497569eb52da237e846888dc8860dcbea706/components/Markdown.tsx#L88-L90
This results in the following being rendered:

This results in the link to the image prioritised over the real link.
I'm not sure why you'd need to wrap an image in a hyperlink so an easy solution would be to remove the anchor surrounding the image. I'd be happy to submit a PR for that if there's no reason it can't be removed.
I've noticed this with badges on other third-party modules too.

Yeah that wrapper link can be removed. If you wanna open a PR that would be great :+1:

I've created the PR to remove it. I couldn't find the contribution guidelines for the website so I hope everything's alright. It seems like a pretty simple change anyway.
If there's some process I've missed, let me know and I'll sort it 👍


Why can't I access method defined outside the exposed function callback or evaluate callback in page context ?

const pptr = require('puppeteer');
require('mocha');
const {
    assert,
    expect
} = require('chai');

let browser, page;

const mockChromeStorage = {
    local : {
        propertyWorks: "ABC",
        getValueDoestWork: (key, cb) => {
            cb("Result");
        }
   }
};

before(async() => {
    browser = await pptr.launch({
        headless: false,
        args: [
            '--no-sandbox',
            '--disable-setuid-sandbox',
            '--disable-web-security'
        ],
        ignoreHTTPSErrors: true,
        devtools: true
    });
    page = await browser.newPage();
    page.setViewport({
        width: 1800,
        height: 1080
    });
});

describe('Test', () => {
    it('test storage', async() => {
        await page.goto('http://localhost:8088/integration/host.html');
        await page.exposeFunction('mockChromeStorage', () => {
            return mockChromeStorage;
        });
        await page.evaluate(async ()=>{
            const mockStore = await window.mockChromeStorage()
            console.log("Property: ", mockStore.local.propertyWorks); // able to access "ABC"
            console.log("Method: ", mockStore.local.getValueDoestWork()); // undefined is not a method
        });
        assert(true, true);
    });
});

I should be able to mock methods exposed to page. And test expected result easily. Why can't we access methods defined outside of the evaluate or exposeFunction callbacks (How I am able to access other kind of properties(non-functions)  ) ? Why it has to be defined within those callback ?

Tell us about your environment:

Puppeteer version: 0.10.x
Platform / OS version: MacOS 10.12.6

@apdarshan the exposeFunction method is a pretty low-level primitive: it allows to expose functions that accept and return JSON.stringify'able values.
If you want to create a complex objects exposed to the browser page, you should create them by yourself using page.evaluate and page.exposeFunction methods:
// expose a method
await page.exposeFunction('pptr_foo', () => 'foo!');
// and create an object that refers to the previsouly-exposed method
await page.evaluate(() => {
  window.PPTR = {
    foo: pptr_foo,
  };
});


feat(104): added acd as a supported ens type

closes #1353

@Stef3st I tested the CDC=ENC. It works very well.


Input view is stuck behind Keyboard. background Scrollview is incorrectly positioned.

@jessesquires, please watch http://101media.ru/JSQMessages-kbd.mov
See how keyboard covers the input view. What issue is this?

Hey @cellard :smile:
My first guess is that you aren't calling super from the view lifecycle methods.

Thank you!


Docs website inconsistent UX

Issue to track following fixes as observed when used across browsers and builds:

[x] Major: Chrome service workers are not being refreshed with latest build

Action: remove offline plugin

[x]  Minor: Logo link not returning to homepage
[x] Minor: Logo not appearing in Mobile version
[ ] Minor: API docs side bar doesn't have a link to return to main docs

Action: Create custom mako template for pdoc

API results no longer showing in the search - https://github.com/algolia/docsearch-configs/pull/1998


Break backends out in to their own packages

Backends have their own dependencies which makes installation potentially unwieldy.
Consider breaking out each backend in to its own package, similar to how llm breaks out LLM backends.

Do you mean separate installable packages? Or separate top-level packages?


compilation broken on 2.0.0-beta.5 due to missing manifest dependency

we are failing to build docs for 2.0.0-beta.5 on Swiftinit due to the following error:
/home/ubuntu/unidoc/checkouts/hummingbird-lambda/.build.ssgc/checkouts/hummingbird/Sources/HummingbirdCore/Request/RequestBody.swift:15:8: error: no such module 'Collections'
import Collections
       ^

compiling locally with --explicit-target-dependency-import-check=error reveals the problem:
error: Target HummingbirdCore imports another target (Collections) in the package without declaring it a dependency.

I never saw this issue on my macOS, Linux CI was not complaining then as soon as you post this issue the examples CI failed. I cannot replicate this locally but anyway it obviously an issue so added dependency and did a new release of Hummingbird


pixi build doesn't include dependencies and incorrect version

Checks

[x] I have checked that this issue has not already been reported.

[x] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
https://github.com/Quantco/polarify/pull/81
Issue description
i'm currently playing around with pixi build and found that the package generated with pixi build doesn't include polars >=0.14.24,<0.21 in its dependencies, even though it's specified in pyproject.toml as well as pixi.toml.
Currently, index.json looks like this:
{
  "build": "pyhbf21a9e_0",
  "build_number": 0,
  "depends": [
    "python"
  ],
  "name": "polarify",
  "noarch": "python",
  "subdir": "noarch",
  "timestamp":<PHONE_NUMBER>257,
  "version": "0.1.0"
}

Expected behavior
I would expect it to look more like this:
{
  "build": "pyhbf21a9e_0",
  "build_number": 0,
  "depends": [
    "python >=3.9", // from pyproject.toml requires-python or pixi.toml dependencies?
    "polars >=0.14.24,<0.21" // from pyproject.toml or pixi.toml?
  ],
  "name": "polarify",
  "noarch": "python",
  "subdir": "noarch",
  "timestamp":<PHONE_NUMBER>257,
  "version": "0.2.0" // <- should be 0.2.0, from pixi.toml's package.version
}

Also, the package doesn't include a recipe file. Is this intended?

Did you specify the dependencies with [run-dependencies]?
[dependencies] is used by the workspace. [run-dependencies] specifies the run dependencies of the package. If you then include
[dependencies]
polarify = { path = "." }

[run-dependencies]
python = "*"
polars = "*"

It should work. Note that this doesnt work with features. We are looking into using a form of variants to make that work properly.

makes sense, thanks!
[run-dependencies] is currently not in the schema yet; we should add it there

Also, the package doesn't include a recipe file. Is this intended?

It should contain a finalized recipe file eventually but not a recipe.yaml file because we don't explicitly create that.


Mock GetFiles/GetFileSystemEntries does not list files

I've noticed that using Directory.GetFiles and Directory.GetFileSystemEntries does not return files in the given directory. See below example, where a real FileSystem works as expected but the MockFileSystem does not
[Test]
public void TestSneakyFile()
{
    var realFs = new FileSystem();
    realFs.Directory.CreateDirectory("C:/a");
    realFs.Directory.CreateDirectory("C:/a/b");
    realFs.File.WriteAllText("C:/a/testfile.txt", "some content");

    // All assertions succeed
    Assert.That(realFs.Directory.GetFileSystemEntries("C:/a"), Has.Length.EqualTo(2));
    Assert.That(realFs.Directory.GetFiles("C:/a"), Has.Length.EqualTo(1));
    Assert.That(realFs.Directory.GetDirectories("C:/a"), Has.Length.EqualTo(1));
    Assert.That(realFs.File.ReadAllText("C:/a/testfile.txt"), Is.EqualTo("some content"));

    realFs.Directory.Delete("C:/a", true);

    var fs = new MockFileSystem(new Dictionary<string, MockFileData>
    {
        { "C:/a/testfile.txt", new MockFileData("some content") },
        { "C:/a/b", new MockDirectoryData() },
    });

    // These assertions fail: Length is 1 lower than expected
    Assert.That(fs.Directory.GetFileSystemEntries("C:/a"), Has.Length.EqualTo(2));
    Assert.That(fs.Directory.GetFiles("C:/a"), Has.Length.EqualTo(1));

    // These assertions succeed
    Assert.That(fs.Directory.GetDirectories("C:/a"), Has.Length.EqualTo(1));
    Assert.That(fs.File.ReadAllText("C:/a/testfile.txt"), Is.EqualTo("some content"));
}

Version (from NuGet): <IP_ADDRESS>
OS: Testing from Windows 10

Thanks for reporting! Which OS are you on? the usage of forward slashes seems that you’re testing this on Unix, while the c: at the start indicates Windows.

I'm testing from a Windows 10 pc - I put it in the original post too now.
The forward slashes is mostly for readability since it's compatible with both Unix and Win

Yep, we assume „correct“ path separators. I assume your test cases would work if you build paths with .Path.Combine.

But if it works with System.IO but not with the Mocks it is clearly a problem with the mocks.
The product code can't control ftom where it gets its paths, because they might be directly frtom user input

@fgreinacher you are correct. The assertions do pass if I replace all / with \\.
However, I agree with @siprbaum that since System.IO handles it without issues I would expect the mocks to do the same.

Got it, thanks! I’ll mark it as up for grabs, so feel free to get started on it if you want 😁

After having a little look at the source I was wondering why I was experiencing this issue and realized I should have just updated my project to use the latest version of this library.
This bug is not present in the latest code and works after updating my project, so apologies for the bug report :) I'll close it.

No worries and thanks for the update!

Getting almost the same issue here. Cannot get files in the mock system.
filesSystem.Directory.Exists(@"C:\csv") returns true
fileSystem.DirectoryInfo.FromDirectoryName(@"c:\csv").GetFiles() returns no files
fileSystem.FileInfo.FromFileName(@"c:\csv\test.txt")  returns does not exist
So basically I can find directories but when I do GetFiles its empty( tried using Path.Combine but that did not work- well the directory path is fine so that could not be the issue)
Tried updating to the latest nuget but still the same thing
https://stackoverflow.com/questions/61123112/system-io-abstractions-mockfilesystem-getfiles-not-returning-any-files

@baibhavgh550 Which version are you using?


Restructured & Extended

-Restructured to be more robust and naturally guide new members in learning about the existing codebase and Smartbike.
-All new files should be empty, forgot about pushing this earlier.
-Content prepared for some parts but will be included in separate PRs.

Merged manually


Not compatible with windows 64bit

application not compatible with 64 bit windows

It is a pretty old project, so the executable may lose its compatibility.
You can build the code to provide for your need :)


JFXDialog transparent background and white borders on Android 5.1.1.

Hello!
I have a problem with JFXDialog on Android 5.1.1.

My source code:
        StackPane main = new StackPane();
        main.setPadding(new Insets(8.0));

        JFXButton jfxButton = new JFXButton("Button");

        jfxButton.setOnAction((PushButtonAction) -> {
            JFXTextField jfxTextField = new JFXTextField();
            jfxTextField.setPromptText("Text field");
            jfxTextField.setLabelFloat(true);
            StackPane pane = new StackPane(jfxTextField);
            pane.setPadding(new Insets(16.0));
            JFXDialog dialog = new JFXDialog(main, pane, JFXDialog.DialogTransition.TOP);
            dialog.show();
        });
        main.getChildren().add(jfxButton);
        final Scene scene = new Scene(main, 300, 200);
        stage.setTitle("JFX Test Demo");
        stage.setScene(scene);
        stage.show();

Hello,
What version of JFoenix are you using? are you applying any stylesheet files to the scene?

Hello,
I used current snapshot version of JFoenix. No, I used dialog without stylesheet files.

try adding the following css to your project
.jfx-dialog-layout .jfx-layout-body{
    -fx-background-color: WHITE;
}

try adding the following css to your project:
.jfx-dialog-overlay-pane > StackPane {
    -fx-background-color: WHITE;
}

Thank you, But your solution did not resolved problem with white borders on shadow around dialog window.

I had the same problem https://github.com/jfoenixadmin/JFoenix/issues/652 , i tried with css but i did not get any changing.

Hi there ,to resolve your issue you should make node background as empty value :
`JFXTextField jfxTextField = new JFXTextField();
        jfxTextField.setPromptText("Text field");

        jfxTextField.setLabelFloat(true);

        StackPane pane = new StackPane(jfxTextField);

        pane.setBackground(Background.EMPTY);

        pane.setPadding(new Insets(16.0));

        JFXDialog dialog = new JFXDialog(main, pane, JFXDialog.DialogTransition.TOP);

        dialog.show();   `


Not able to extend core modules

I'm specifically trying to override the category/list action in category module.
I've a requirement where I need to generate multiple urls for single category (ex. {baseUrl/category1/filter1 , baseUrl/category1/filter2 ....} fo that I want to override list action of category module. I've tried almost everything mentioned over the vuestorefront website to do that, seems like there's no way now to override the core modules as we are registering them already on core.
Outdate documentation : https://docs.vuestorefront.io/guide/modules/introduction.html#extending-and-overriding-vue-storefront-modules
Forum link  - https://forum.vuestorefront.io/t/vsf-module-extending-in-1-11-1/1343/6
Forum link - https://forum.vuestorefront.io/t/extend-user-module/494

Hey, here is example how you can do that by creating vsf module
import { extendStore } from '@vue-storefront/core/helpers'

const exampleNameModule = {
  actions: {
    async list ({ dispatch }, { url, params }) {
      // ...
    }
  }
}

export const ExampleName: StorefrontModule = function ({app, store, router, moduleConfig, appConfig}) {
  extendStore('url', exampleNameModule)
}

Yes, this is what I did inside my theme folder, seems like it requires pre-existing store to extend it but I want to do extend it before even registering it.
Thanks 👍


peer-to-peer code review

Sergio did a great job, congratulations.

We suggest that when displaying the form the input fields are not filled with data from local storage.

Hi @SergioPeralta22
You have done an excellent job, however, I kindly suggest you consider using new Date().toDateString();
This way you will optimize your code, check the documentation if you want to change the output format.
Happy coding


ARROW-1219: [C++] Use Google C++ code formatting

Our coding style guide has a ton of rules. I put up this patch to discuss since we don't have too many patches outstanding right now. This uses the exact Google style used in TensorFlow and other projects, but relaxes the column limit to 90 characters.
The main change is horizontal alignment in function signatures:
 void ValidateBasicStructArray(const StructArray* result,
-    const vector<uint8_t>& struct_is_valid, const vector<char>& list_values,
-    const vector<uint8_t>& list_is_valid, const vector<int>& list_lengths,
-    const vector<int>& list_offsets, const vector<int32_t>& int_values) {
+                              const vector<uint8_t>& struct_is_valid,
+                              const vector<char>& list_values,
+                              const vector<uint8_t>& list_is_valid,
+                              const vector<int>& list_lengths,
+                              const vector<int>& list_offsets,
+                              const vector<int32_t>& int_values) {

I find the paren-aligned version a bit more readable, but it's a matter of taste

@pcmoritz @robertnishihara @cpcloud @xhochy do you have any feelings on this? I think the Google style is more similar to what the Plasma codebase was prior to importing into Arrow.

I like the change aesthetically, the simpler clang-format, and the consistency with other projects. However, I don't feel strongly about this.

+1 for the change

I'm open for everything as long as ninja format works. Another thing that bothers me more: Could we pin the clang-format version? I have different versions on different systems and everywhere I would be able to install 3.8 , 3.9 and 4.0 but am unsure which one we currently use and thus often have reformatting changes in unrelated code.
Also I would merge the other open C++ PRs first before doing any reformatting to avoid huge merge conflicts, esp https://github.com/apache/arrow/pull/797.

ninja format and make format work definitely. According to http://apt.llvm.org/ LLVM 3.9 is the "stable" version, but maybe this is a typo. I've been using that. I am happy to pin 4.0 as long as that is easy to obtain on both Linux and macOS. I just opened https://issues.apache.org/jira/browse/ARROW-1221 about this
It's not necessary to merge this right away. I can wait until https://github.com/apache/arrow/pull/797 and other PRs are merged and then do the reformat

Bombs away


Fixed Watch.unmarshal_event when data is not a JSON-serialized object

Log streaming using Watch was introduced in https://github.com/kubernetes-client/python-base/pull/93/, but the users faced errors when the log line was a single number or an empty string.
This PR fixes those issues.
Fixes https://github.com/kubernetes-client/python/issues/982
Fixes https://github.com/kubernetes-client/python/issues/983

Codecov Report

Merging #171 into master will decrease coverage by 0.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   93.41%   93.35%   -0.07%
==========================================
  Files          13       13
  Lines        1398     1400       +2
==========================================
+ Hits         1306     1307       +1
- Misses         92       93       +1

Impacted Files
Coverage Δ

watch/watch.py
98.82% <50%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b65461...f11587d. Read the comment docs.

/cc @jiahuif

As discussed here https://github.com/kubernetes-client/python/issues/982#issuecomment-544780986
If the object has a field named "object", the fix would not work. We should not rely on one of the field to determine the type.

If the object has a field named "object", the fix would not work. We should not rely on one of the field to determine the type.

Unfortunately, dictionaries are duck-typed by design.
The code in question insists on accessing the 'object' key.
Without the fix, the code is randomly broken in large number of cases.
Can you please suggest another way to fix the common path?

@jiahuif any update for @Ark-kun ?

@scottilee See kubernetes-client/python#1032

/lgtm
/approve


Improve documentation

Coverage remained the same at 100.0% when pulling 6c3047b147f242ca9d556a05ba64c1d3dae8dd04 on docs into 53069c6f9c2c4f6bc974f0e998325d1b677b1e72 on master.

Coverage remained the same at 100.0% when pulling a7e7d9955523c6a5ca29721adf7b2d7eeaf220c8 on docs into 53069c6f9c2c4f6bc974f0e998325d1b677b1e72 on master.


Enable kxreus for using model server

roslaunch kxreus eusmodel_server.launch

(load "package://kxreus/euslisp/kxr-interface.l")

(kxr-init :namespace nil)

loop...
2.irteusgl$ (kxr-init :namespace nil)
[ERROR] [1709030304.370361535]: unknown ros::param::get, key=/eusmodel_hash
[ERROR] [1709030304.370567197]: unknown ros::param::get, key=/eus_robot_name
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030304.372841438]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030305.380943728]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030306.389889675]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030307.397676511]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030308.406300142]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030309.414234303]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030310.422000753]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030311.430745600]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030312.439332074]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030313.447073497]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030314.455894335]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030315.464029565]: Waiting model file from server url http://localhost:8000/nil.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/nil.l: No such file or directory
[ INFO] [1709030316.472585019]: Waiting model file from server url http://localhost:8000/nil.l

2.irteusgl$ (kxr-init :namespace nil)
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030377.801897762]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030378.810710963]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030379.819456490]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030380.828250174]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030381.836008040]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030382.844587149]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030383.853199274]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l
/home/naoya/ros/kxr/src/rcb4/ros/kxreus/models/cache/7c77d2901e8abc2775d0b127523f1576.l: No such file or directory
[ INFO] [1709030384.861848398]: Waiting model file from server url http://<IP_ADDRESS>:8000/7c77d2901e8abc2775d0b127523f1576.l

In radxa
rock@radxa-zero:~/ros/kxr/src/rcb4/ros/kxreus/models$ ls ~/ros/kxr/src/rcb4/ros/kxreus/models/
7c77d2901e8abc2775d0b127523f1576.l

I fixed minor bug.
https://github.com/iory/rcb4/pull/39


feat: create databricks volume destination connector

Leverage the databricks python sdk (databricks-sdk-py) to push content from the Unity Catalog Volumes. This is a general blob storage similar to s3. This should also support conversion from json into a dataframe before being uploaded to support the workflow of data being synced from volume to databrick's native delta table offering.
Option to convert to dataframe/csv could be supported as an optional across destination connectors that would support that.

Closing since we have databricks_volumes.py now.


migrate to mbedtls 3.x with mbedtls 2.x backward compatibility

This pull request adds support for mbedtls 3.x while retaining mbedtls 2.x compatibility. mbedtls support is still limited to WinPR library builds, as we don't yet have full support for making FreeRDP hybrid openssl/mbedtls builds in one go. For our internal builds, we build WinPR+mbedtls first, then FreeRDP+openssl against WinPR+mbedtls. Fixing the build system for this would be better off done in a separate pull request, and start with mbedtls 3/2 compatibility.
Here is how I've built mbedtls 2 and 3 locally:
git clone<EMAIL_ADDRESS>cd mbedtls

git checkout v3.5.1
mkdir build-mbedtls3 && cd build-mbedtls3
cmake -DENABLE_TESTING=OFF -DENABLE_PROGRAMS=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_INSTALL_PREFIX="/opt/deps/mbedtls3" ..
make
sudo make install
cd ..

git checkout v2.28.6
mkdir build-mbedtls2 && cd build-mbedtls2
cmake -DENABLE_TESTING=OFF -DENABLE_PROGRAMS=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_INSTALL_PREFIX="/opt/deps/mbedtls2" ..
make
sudo make install
cd ..

Here is how I have built WinPR against both versions of mbedtls locally (yes, the CMakeLists.txt in FreeRDP/WinPR can be used as the "root" one for WinPR-only builds):
cd FreeRDP/winpr
mkdir build-mbedtls2 && cd build-mbedtls2
cmake -DCMAKE_PREFIX_PATH="/opt/deps/mbedtls2" -DCMAKE_INSTALL_PREFIX="/opt/deps/winpr-mbedtls2" -DWITH_MBEDTLS=ON -DWITH_OPENSSL=OFF ..
make
sudo make install

cd FreeRDP/winpr
mkdir build-mbedtls3 && cd build-mbedtls3
cmake -DCMAKE_PREFIX_PATH="/opt/deps/mbedtls3" -DCMAKE_INSTALL_PREFIX="/opt/deps/winpr-mbedtls3" -DWITH_MBEDTLS=ON -DWITH_OPENSSL=OFF ..
make
sudo make install

And now, to build FreeRDP against a prebuilt WinPR (this requires a bit of fiddling in cmake/ConfigureFreeRDP.cmake that I'll look into a future pull request for the build system improvements):
cd FreeRDP
mkdir build-mbedtls3 && cd build-mbedtls3
cmake -DCMAKE_PREFIX_PATH="/opt/deps/mbedtls3;/opt/deps/winpr-mbedtls3" -DCMAKE_INSTALL_PREFIX="/opt/deps/winpr-mbedtls3" -DWITH_MBEDTLS=ON -DWITH_OPENSSL=OFF -DFREERDP_UNIFIED_BUILD=OFF -DWITH_SERVER=OFF ..

That's it! Most of the changes were to remove deprecated algorithms, and I also removed a bunch of definition mappings we were likely never going to use (I originally had replicated the entire set from mbedtls). Some struct members became private, requiring the usage of functions to access them. I added backward compatibility wrappers such that it can still build with mbedtls 2.
Since RC4 and MD4 were removed from mbedtls, I set the default to use internal RC4, MD4 for mbedtls, while leaving them on (previous default) for openssl builds. The old havege random number generated was also removed from mbedtls, so I added code for the newer APIs which aren't as straightforward to use, but should do the trick.

@akallabeth changes have been made according to comments, as for the removal of mbedtls id mapping of DES, Blowfish ciphers, they've been removed in mbedtls 3.x, and it's not worth using ifdefs for compatibility. As for camelia ciphers, we never needed them, and they're bound to be removed eventually, so might as well rip the band aid now. I do use the AES ciphers in other projects that use WinPR without FreeRDP though, so we're keeping those.

@awakecoding your changes break the openssl build on the ci.

I'll do another pass of changes on Monday to get this pull request clean and ready to go. I'll put the camellia ciphers back, but blowfish and DES will still be removed because they're no longer defined, is that okay? In other words I'll limit the ID removal to what's been removed in mbedtls 3.x

@awakecoding I´d just keep all the defines in the public header, but no need to implement that (no longer existing) ones for mbedtls. (just return a failure where appropriate)
just want to keep the headers and defined symbols consistent for 3.0

@akallabeth it should all be good now!

@awakecoding great, and merged!


Allow customize connection timeout

I personally use kcptun on Android. Every time I wake my Android device from deep sleep, disconnection occurs. And push service (like FCM) using a long connection didn't work correctly.
This commit allows user to specify connection timeout, just in case.

Coverage remained the same at ?% when pulling 08de96cb44032fc1bd323a22ed145e318b04e54f on hexian000:master into baf532e1b143525bc4ef845072b9e073f9d58be0 on xtaci:master.

Coverage remained the same at ?% when pulling 08de96cb44032fc1bd323a22ed145e318b04e54f on hexian000:master into baf532e1b143525bc4ef845072b9e073f9d58be0 on xtaci:master.

Coverage remained the same at ?% when pulling 08de96cb44032fc1bd323a22ed145e318b04e54f on hexian000:master into baf532e1b143525bc4ef845072b9e073f9d58be0 on xtaci:master.

Coverage remained the same at ?% when pulling 08de96cb44032fc1bd323a22ed145e318b04e54f on hexian000:master into baf532e1b143525bc4ef845072b9e073f9d58be0 on xtaci:master.


Bug with weather custom variable example in .local file

I found that the weather custom variable did not work out of the box:
https://github.com/gpakosz/.tmux/blob/fa601ed607300f0884306493d9ddfdbde6bff11d/.tmux.conf.local#L421-L424
I tested by setting this and looking for weather information. I have curl installed:
tmux_conf_theme_status_right='#{prefix}#{mouse}#{pairing}#{synchronized} , %R , %d %b #{weather} | #{username}#{root} | #{hostname} '

It was verifiable by running the command used to process them: (only online appears, not weather)
$ perl -n -e 'print if s!^#\s+([^_][^()\s]+)\s*\(\)\s*{\s*\n!s%#\\\{\1((?:\\s+(?:[^\{\}]+?|#\\{(?:[^\{\}]+?)\}))*)\\\}%#(cut -c3- ~/.tmux.conf.local | sh -s \1\\1)%g; !p' < ~/.tmux.conf.local
s%#\{online((?:\s+(?:[^{}]+?|#\{(?:[^{}]+?)}))*)\}%#(cut -c3- ~/.tmux.conf.local | sh -s online\1)%g;

I was able to fix by removing the 'second comments' from the custom variable:
# # /!\ do not remove the following line
# EOF
#
# # /!\ do not "uncomment" the functions: the leading "# " characters are needed
#
# weather() {
#   curl -f -s -m 2 'wttr.in?format=3' || printf '\n'
#   sleep 900
# }
#
# online() {
#   ping -c 1 <IP_ADDRESS> >/dev/null 2>&1 && printf '✔' || printf '✘'
# }
#
# "$@"
# # /!\ do not remove the previous line

After this, weather worked for me.

Hey @mreishus 👋
Good catch!
Can you please add comments back and try the gh-603 branch please?

Can you please add comments back and try the gh-603 branch please?

I'll gladly try, but I'm not seeing that branch yet :) https://github.com/gpakosz/.tmux/branches/all

Forgot to push!

Working for me. LGTM :heavy_check_mark:


Failed to send the request: Upload Id not found in create-multipart-upload response

Hi there,
I am currently creating a simple integration test for our spring boot application, it is just one controller with some endpoints to upload and download a file. I am using TestContainers and the S3AsyncClient via S3CrtAsyncClientBuilder.
This is the log from my Application:
2023-06-16T18:35:17.673+12:00 DEBUG 53321 --- [           main] o.s.web.client.RestTemplate              : HTTP POST http://localhost:50195/transfer
2023-06-16T18:35:17.689+12:00 DEBUG 53321 --- [           main] o.s.web.client.RestTemplate              : Accept=[application/json, application/*+json]
2023-06-16T18:35:17.690+12:00 DEBUG 53321 --- [           main] o.s.web.client.RestTemplate              : Writing [[B@7bbe5548] with org.springframework.http.converter.ByteArrayHttpMessageConverter
2023-06-16T18:35:17.774+12:00  INFO 53321 --- [r-http-kqueue-2] a.c.acme.controller.TransferController  : UploadHandler: mediaType application/octet-stream, length=70502978, fileKey = 99aadc13-4379-41cd-8714-2acf8527845f
2023-06-16T18:35:17.780+12:00 DEBUG 53321 --- [r-http-kqueue-2] software.amazon.awssdk.request           : Sending Request: DefaultSdkHttpFullRequest(httpMethod=PUT, protocol=http, host=localhost, port=49228, encodedPath=/vanillabeanz-demo/99aadc13-4379-41cd-8714-2acf8527845f, headers=[amz-sdk-invocation-id, Content-Length, Content-Type, Expect, User-Agent, x-amz-meta-file_name], queryParameters=[])
2023-06-16T18:35:17.883+12:00 ERROR 53321 --- [nc-response-0-6] a.w.r.e.AbstractErrorWebExceptionHandler : [574b79b9-1]  500 Server Error for HTTP POST "/transfer"

software.amazon.awssdk.core.exception.SdkClientException: Failed to send the request: Upload Id not found in create-multipart-upload response
	at software.amazon.awssdk.core.exception.SdkClientException$BuilderImpl.build(SdkClientException.java:111) ~[sdk-core-2.20.78.jar:na]
	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Error has been observed at the following site(s):
	*__checkpoint ⇢ Handler au.com.acme.controller.TransferController#uploadHandler(HttpHeaders, Flux) [DispatcherHandler]
	*__checkpoint ⇢ org.springframework.web.filter.reactive.ServerHttpObservationFilter [DefaultWebFilterChain]
	*__checkpoint ⇢ HTTP POST "/transfer" [ExceptionHandlingWebHandler]
Original Stack Trace:
		at software.amazon.awssdk.core.exception.SdkClientException$BuilderImpl.build(SdkClientException.java:111) ~[sdk-core-2.20.78.jar:na]
		at software.amazon.awssdk.core.exception.SdkClientException.create(SdkClientException.java:43) ~[sdk-core-2.20.78.jar:na]
		at software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter.handleError(S3CrtResponseHandlerAdapter.java:127) ~[s3-2.20.78.jar:na]
		at software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter.onFinished(S3CrtResponseHandlerAdapter.java:93) ~[s3-2.20.78.jar:na]
		at software.amazon.awssdk.crt.s3.S3MetaRequestResponseHandlerNativeAdapter.onFinished(S3MetaRequestResponseHandlerNativeAdapter.java:24) ~[aws-crt-0.21.8.jar:0.21.8]

This is the log from the S3Mock container
2023-06-16 06:35:17.576 DEBUG 1 --- [tp1733581655-21] o.s.web.servlet.DispatcherServlet        : POST "/vanillabeanz-demo/99aadc13-4379-41cd-8714-2acf8527845f?uploads", parameters={masked}
2023-06-16 06:35:17.578 DEBUG 1 --- [tp1733581655-21] s.w.s.m.m.a.RequestMappingHandlerMapping : Mapped to com.adobe.testing.s3mock.MultipartController#createMultipartUpload(String, ObjectKey, String, String, String, String, HttpHeaders)
2023-06-16 06:35:17.653 DEBUG 1 --- [tp1733581655-21] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Using 'application/xml', given [application/x-www-form-urlencoded, application/xml] and supported [application/xml]
2023-06-16 06:35:17.656 DEBUG 1 --- [tp1733581655-21] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Writing [com.adobe.testing.s3mock.dto.InitiateMultipartUploadResult@f35d0a6]
2023-06-16 06:35:17.658 DEBUG 1 --- [tp1733581655-21] o.s.web.servlet.DispatcherServlet        : Completed 200 OK

As you can see, it worked on your side, but for some reason, the AWS CRT Client didn't like it.
This is the S3Mock configuration in my test:
    @Container
    private static final S3MockContainer s3Mock = new S3MockContainer("2.12.2")
            .withValidKmsKeys("arn:aws:kms:us-east-1:1234567890:key/valid-test-key-ref")
            .withRetainFilesOnExit(true)
            .withEnv("debug", "true");

    @DynamicPropertySource
    static void registerDynamicProperties(DynamicPropertyRegistry registry) {
        registry.add("app.props.transfers.s3.endpoint", s3Mock::getHttpEndpoint);
    }

This is how I create the client:
    @Bean
    public S3AsyncClient s3client(S3ClientConfigurationProperties s3props, AwsCredentialsProvider credentialsProvider) {
        S3CrtAsyncClientBuilder builder = S3AsyncClient.crtBuilder()
                .credentialsProvider(credentialsProvider)
                .region(s3props.getRegion())
                .forcePathStyle(true)
                .targetThroughputInGbps(20.0)
                .minimumPartSizeInBytes(8 * MB);
        if (s3props.getEndpoint() != null) {
            builder = builder.endpointOverride(s3props.getEndpoint());
        }
        return builder.build();
    }

If I change the implementation to the default S3AsyncClient, it works flawlessly but I lose the CRT Multipart advantages.
    @Bean
    public S3AsyncClient s3client(S3ClientConfigurationProperties s3props, AwsCredentialsProvider credentialsProvider) {
        S3AsyncClientBuilder builder = S3AsyncClient.builder()
                .credentialsProvider(credentialsProvider)
                .region(s3props.getRegion())
                .forcePathStyle(true);
        if (s3props.getEndpoint() != null) {
            builder = builder.endpointOverride(s3props.getEndpoint());
        }
        return builder.build();
    }

I have traced the error message to https://github.com/search?q=repo%3Aawslabs%2Faws-c-s3 AWS_ERROR_S3_MISSING_UPLOAD_ID&type=code
Can you please have a look? Maybe the CRT handler is expecting something else, I don't know.
Thanks!

@campidelli not sure what goes wrong with your code.
I added an integration test that uses the CRT client, and it works just fine, see linked PR...

there are two ways to add the CRT client to the S3AsyncClient - see S3TestBase.kt. It's in Kotlin, but the syntax is not too different from Java.
Not sure why, but I can't get one of the CRT clients to work with an https endpoint.
The test works with both of them.
Only the "autoCrt" client (using your way to set it up) lands in this method though:
		at software.amazon.awssdk.services.s3.internal.crt.S3CrtResponseHandlerAdapter.onFinished(S3CrtResponseHandlerAdapter.java:93) ~[s3-2.20.78.jar:na]

Hi @afranken, thanks for the prompt response.
I have followed this tutorial (https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/transfer-manager.html) where they ask for this specific version or higher, I didn't know the client was part of the SDK already, good catch!
The project I am working on is similar to this, but it is an internal one.
If I change the Client to use the HTTP version, I lose the multipart upload feature< I quote from https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/crt-based-s3-client.html

Although both components use libraries from the AWS Common Runtime, the AWS CRT-based S3 client uses the aws-c-s3 library and supports the S3 multipart upload API features. Since the AWS CRT-based HTTP client is meant for general purpose use, it does not support the S3 multipart upload API features.

For this specific test I am using the putObject API, as you can check on the following code (from my REST controller):
    @PostMapping
    public Mono<ResponseEntity<UploadResult>> uploadHandler(@RequestHeader HttpHeaders headers, @RequestBody Flux<ByteBuffer> body) {

        long length = headers.getContentLength();
        if (length < 0) {
            throw new UploadFailedException(HttpStatus.BAD_REQUEST.value(), Optional.of("required header missing: Content-Length"));
        }

        String fileKey = UUID.randomUUID().toString();
        Map<String, String> metadata = new HashMap<>();
        metadata.put("file_name", "test");
        MediaType mediaType = headers.getContentType();

        if (mediaType == null) {
            mediaType = MediaType.APPLICATION_OCTET_STREAM;
        }

        log.info("UploadHandler: mediaType {}, length={}, fileKey = {}", mediaType, length, fileKey);
        Mono<PutObjectResponse> putObjectResponseMono = Mono.fromFuture(s3client.putObject(PutObjectRequest.builder()
                        .bucket(s3config.getBuckets().upload())
                        .contentLength(length)
                        .key(fileKey)
                        .contentType(mediaType.toString())
                        .metadata(metadata)
                        .build(),
                AsyncRequestBody.fromPublisher(body)));

        return putObjectResponseMono
                .map((response) -> {
                    checkUploadResult(response);
                    return ResponseEntity
                            .status(HttpStatus.CREATED)
                            .body(new UploadResult(HttpStatus.CREATED, new String[]{fileKey}));
                });
    }

Can you please include this in your test and see if it works?
Thanks!

Just added a test, works without problems:
https://github.com/adobe/S3Mock/blob/main/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/CrtAsyncV2IT.kt
must still be something with the way you set up the client, or the interaction with Spring reactive?
Maybe you could try to reproduce the problem in your example service...

Yes, I am going to do it right now, thanks!

I have updated my project and the error doesn't happen anymore.
However, I am facing another issue, which is probably an implementation error, I would gladly accept a hand here.
https://github.com/adobe/S3Mock/issues/1182
Thanks!


no module find

Altought I achive to install it with pip, I coudnt start to work.
the error is

from instagram.client import InstagramAPI
Traceback (most recent call last):
File "", line 1, in
File "instagram.py", line 1, in
from instagram.client import InstagramAPI
ImportError: No module named client

and files
/usr/lib/python3/dist-packages/friends/tests/data/instagram-login.dat
/usr/local/lib/python2.7/dist-packages/instagram
/usr/local/lib/python2.7/dist-packages/python_instagram-1.3.2.egg-info
/usr/local/lib/python2.7/dist-packages/instagram/init.py
/usr/local/lib/python2.7/dist-packages/instagram/init.pyc
/usr/local/lib/python2.7/dist-packages/instagram/bind.py
/usr/local/lib/python2.7/dist-packages/instagram/bind.pyc
/usr/local/lib/python2.7/dist-packages/instagram/client.py
/usr/local/lib/python2.7/dist-packages/instagram/client.pyc
/usr/local/lib/python2.7/dist-packages/instagram/helper.py
/usr/local/lib/python2.7/dist-packages/instagram/helper.pyc
/usr/local/lib/python2.7/dist-packages/instagram/json_import.py
/usr/local/lib/python2.7/dist-packages/instagram/json_import.pyc
/usr/local/lib/python2.7/dist-packages/instagram/models.py
/usr/local/lib/python2.7/dist-packages/instagram/models.pyc
/usr/local/lib/python2.7/dist-packages/instagram/oauth2.py
/usr/local/lib/python2.7/dist-packages/instagram/oauth2.pyc
/usr/local/lib/python2.7/dist-packages/instagram/subscriptions.py
/usr/local/lib/python2.7/dist-packages/instagram/subscriptions.pyc

solved
dont name your file "instagram.py"


Create Status Attribute and FindStatus Command

#8 #9 #20
This is an essential feature as recruiters need to keep track of applicants' status.
Let's

Add Status attribute in Person
Create FindStatusCommand

Codecov Report
Base: 65.08% // Head: 65.75% // Increases project coverage by +0.67% :tada:

Coverage data is based on head (04e0dd1) compared to base (b3dcb56).
Patch coverage: 78.94% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #81      +/-   ##
============================================
+ Coverage     65.08%   65.75%   +0.67%
- Complexity      463      486      +23
============================================
  Files           100      104       +4
  Lines          1521     1580      +59
  Branches        165      174       +9
============================================
+ Hits            990     1039      +49
- Misses          492      496       +4
- Partials         39       45       +6

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
66.66% <0.00%> (-7.25%)
:arrow_down:

.../java/seedu/address/model/util/SampleDataUtil.java
20.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
92.68% <60.00%> (-4.54%)
:arrow_down:

...c/main/java/seedu/address/model/person/Status.java
70.00% <70.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
95.83% <77.77%> (-1.85%)
:arrow_down:

.../model/person/StatusContainsKeywordsPredicate.java
85.71% <85.71%> (ø)

...java/seedu/address/logic/commands/EditCommand.java
95.89% <87.50%> (-1.13%)
:arrow_down:

...eedu/address/logic/commands/FindStatusCommand.java
100.00% <100.00%> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Get parts to finish the box

Have to get parts to finish the box, primarily new wooden boards, that will be used to close the box and extra plates for maybe mistakes and also for the robot and our charging pads.

The wooden boards have been acquired together with the copper tape, so all the materials should be in inventory, if there are more purchases needed that will be added later and the issue will be reopened.


Work Edit Actions UI Components

We need a UI component providing users with the ability to initiate a variety of actions related to the management of their work. This component will likely appear on the work page for works the user can edit. (replaces #207).
Edit actions for a work include:

[ ] Change Access Controls #277
[x] Create a DOI for the work if none exists (#150)
[ ] Changing visibility (toggle b/w Public & Penn State) (#601)
[ ] Setting Embargo (#621)

(Note, these also apply to collections)
Edit actions for work versions:

list versions (not strictly an admin action)
request withdrawal for work version
delete draft version

Instead of packing all this functionality into the drop down and modal UIs, it may be easier and more user friendly for the gear icon to be a link ("gear Work Settings") to a separate page where you can do all this stuff.
I'm imagining something like this:


x64: only enable VTune dependencies on x86_64 targets

As described in #4523, the ittapi dependency necessary for Wasmtime's
VTune support does not compile on aarch64-linux-android. There are
several incompatible parts here: though ittapi supports all OS
combinations that Wasmtime does and builds on all CPU targets, VTune is
not primarily intended for aarch64 profiling and linux-android is not
a high priority platform for the library. We could conditionally depend
on ittapi for Wasmtime's supported OS combinations, but I think a
better answer is to limit it to x86_64 targets, since this more clearly
shows why the ittapi/VTune support is present and also fixes #4523.

Could you double-check that this fixes at least the issue in #4523 (although I suspect more exist)

Could you double-check that this fixes at least the issue in #4523 (although I suspect more exist)

Like compile with cargo build --target aarch64-linux-android or something else?

Looks like something else is the problem now:
$ cargo build --release --target aarch64-linux-android
...

error: failed to run custom build command for `psm v0.1.18`

Caused by:
  process didn't exit successfully: `/home/abrown/Code/wasmtime/target/release/build/psm-d3851756418374a6/build-script-build` (exit status: 1)
  --- stdout
  OPT_LEVEL = Some("3")
  TARGET = Some("aarch64-linux-android")
  HOST = Some("x86_64-unknown-linux-gnu")
  CC_aarch64-linux-android = None
  CC_aarch64_linux_android = None
  TARGET_CC = None
  CC = None
  CFLAGS_aarch64-linux-android = None
  CFLAGS_aarch64_linux_android = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  cargo:rustc-cfg=asm
  cargo:rustc-cfg=switchable_stack
  running: "aarch64-linux-android-clang" "-O3" "-DANDROID" "-ffunction-sections" "-fdata-sections" "-fPIC" "-Wall" "-Wextra" "-xassembler-with-cpp" "-DCFG_TARGET_OS_android" "-DCFG_TARGET_ARCH_aarch64" "-DCFG_TARGET_ENV_" "-o" "/home/abrown/Code/wasmtime/target/aarch64-linux-android/release/build/psm-975239bbdf5842b2/out/src/arch/aarch_aapcs64.o" "-c" "src/arch/aarch_aapcs64.s"

  --- stderr

  error occurred: Failed to find tool. Is `aarch64-linux-android-clang` installed?

Could you perhaps set AR=true CC=true and see how far the build goes? Given the error you got it's unlikely you even reached compiling ittapi-rs

Could you perhaps set AR=true CC=true and see how far the build goes? Given the error you got it's unlikely you even reached compiling ittapi-rs

$ AR=true CC=true cargo build --release --target aarch64-linux-android
...
error: could not find native static library `psm_s`, perhaps an -L flag is missing?

error: could not compile `psm` due to previous error

And, yeah, I do not see ittapi being built in the compiled crates up above that error.

@gneworld, could you test out this branch to see if it resolves #4523 for you? I don't think I have the right system environment (toolchains, libraries, etc.) to check if indeed this commit will fix the build issue you found.

@gneworld, could you test out this branch to see if it resolves #4523 for you? I don't think I have the right system environment (toolchains, libraries, etc.) to check if indeed this commit will fix the build issue you found.

Compiling wasmtime-jit v0.40.0 (/home/mi/ext/minacore_mi11/mina_jit_aot/wasmtime/crates/jit)
error[E0433]: failed to resolve: use of undeclared crate or module rustc_demangle
--> crates/jit/src/demangling.rs:7:28
|
7 |     if let Ok(demangled) = rustc_demangle::try_demangle(name) {
|                            ^^^^^^^^^^^^^^ use of undeclared crate or module rustc_demangle
error[E0433]: failed to resolve: use of undeclared crate or module bincode
--> crates/jit/src/instantiate.rs:270:5
|
270 |     bincode::serialize_into(&mut bytes, &info)?;
|     ^^^^^^^ use of undeclared crate or module bincode
error[E0433]: failed to resolve: use of undeclared crate or module bincode
--> crates/jit/src/instantiate.rs:421:21
|
421 |             None => bincode::deserialize(section(ELF_WASMTIME_INFO)?)
|                     ^^^^^^^ use of undeclared crate or module bincode
error[E0433]: failed to resolve: use of undeclared crate or module cpp_demangle
--> crates/jit/src/demangling.rs:9:49
|
9 |     } else if let Ok(demangled) = cpp_demangle::Symbol::new(name) {
|                                                 ^^^^^^ not found in cpp_demangle
|
help: consider importing one of these items
|
3 | use object::Symbol;
|
3 | use object::write::Symbol;
|
help: if you import Symbol, refer to it directly
|
9 -     } else if let Ok(demangled) = cpp_demangle::Symbol::new(name) {
9 +     } else if let Ok(demangled) = Symbol::new(name) {
|
For more information about this error, try rustc --explain E0433.
error: could not compile wasmtime-jit due to 4 previous errors


Update about-github-pages-and-jekyll.md

Resolves broken quotations around link (Issue #30984  )

Why:
Closes: #30984

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@minding-myown-business Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏


Latest @octokit/auth-app not compatible with octokit-auth-probot

I'm getting the following compilation error when I attempt to update the dependencies of a library that uses octokit-auth-probot:
node_modules/octokit-auth-probot/dist-types/types.d.ts:14:75 - error TS2694: Namespace '"/Users/bencoe/google/repo-automation-bots/packages/gcf-utils/node_modules/@octokit/auth-app/dist-types/index"' has no exported member 'AuthOptions'.

14 export declare type AuthOptions = TokenAuthTypes["AuthOptions"] | AppAuth.AuthOptions | {

Thanks Ben I'll look into it

@gr2m thank you \o/

Should be good now. I've also added npm run build to the test ci so we shouldn't miss that in future

Thank you @gr2m.


Need a Glossary of Concept Terms

I made this for Code.org and it gets a lot of use.  I think we should have one, too.
The information is pulled from a spreadsheet that's easy to sort and keep up to date.  Can we do that in our system?
https://code.org/curriculum/docs/k-5/glossary

I am assuming this is just a markdown in the documentation. Feel free to create one.

I need a way to pull spreadsheet into markdown first.  It's too difficult to keep something like this up in doc form.

Can we do the markdown first and automate it later if updating is a frequent affair? I am not sure about the engineering work required to do so, but we don't have bandwidth for the same in near future.


[Bug] The engine hangs after requesting health_generate 190 times.

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 5. Please use English, otherwise it will be closed.

Describe the bug
When only requesting /health_generate, the 190th request times out because the engine hangs. However, if I use --disable-cuda-graph, it works okay.
Reproduction
use the code for requesting:
#!/bin/bash
i=0
while true
do
	curl -m 60 "http://host:port/health_generate"
	i=$((i+1))
	echo "done $i"
done

Environment
I suppose it's irrelevant to the GPU environment and models we use. The following is the environment I use, for reference only：
OS：ubuntu22.04
GPU: A800
CUDA Driver: 530.30.02
CUDA Runtime: 12.1
Model: Qwen2-72b-instruct-gptq-int4
sglang：latest

try this
https://bit.ly/3XQLHlH
you may need to install the c compiler

0.3.0 sglang hanged for me as well, this was on ubuntu 23.10 (bad choice), 535 nvidia drivers, 12.2 cuda (another bad choice, tho shouldn't matter cause sglang pulls its own cuda 12.1 via pip). Hang didn't happen when calling health_generate but while generating, however, health_generate does ping the GPU, so CUDA and nvidia drivers are involved in the process.
now I moved to ubuntu 22.04, 560.35.03 drivers, 12.1 cuda (actually, not sure what's going on here but nvcc --version reports 12.1.105, while nvidia-smi reports 12.6 - probably screwed sth up; it will bite me later no doubt), sglang 0.3.1.post2 and no issues since (nothing else changed - same server, same GPUs, same model, same run params for sglang)
try experimenting with different combos of nvidia drivers, ubuntu versions and cuda runtimes. imo, dreadful work. once you find a working combo, you can lock them in with
sudo apt-mark hold nvidia*
sudo apt-mark hold cuda*

this magic spell will prevent apt from changing versions of drivers and cuda even when you apt upgrade
If willing to experiment, try 24.04 and bleeding edge drivers.
wget https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2404/x86_64/cuda-keyring_1.1-1_all.deb
sudo apt install ./cuda-keyring_1.1-1_all.deb
sudo apt update
sudo apt install cuda-toolkit

currently they ship with open source drivers -- yes, nvidia started open sourcing their drivers

@unix1986 can you try the latest version and @smallstepman 's suggestions?

I started experimenting some more after I wrote that comment. Turned out my current setup also hanged, and the primary reason was insufficient memory. You'd think that 2*3090 should be able to fit 34B Q4 model, but once all knobs we're cranked to eleven (--dp 2, with cuda-graphs enabled) the server during loading of the model reported "max_tokens_context_lenght_somethingsomthing=1500" so basically context window of 1.5k. Once a batch job was submitted (~30 items, with input context lenght ranging from 800 to 18000) the system hanged. I wish SGLang would report OOM or crash, but it simply hanged with HTTP connections still active but no response from the process (also the process must be forcibly killed - ctrl-c won't work).
I then spent $20 in runpod.io to start experimenting with different hardware configurations & models & server configurations (dp/tp/cuda graphs/torch compile) and everything started making more sense, seeing how sglang also can stifle when I'm trying to run too big of a model on too of a small card.
@merrymercy - related question: no matter what GPU configuration I picked (84090, 8A40) and what model I picked (qwen2.5 0.5/7/14/34/72B) I was unable to run it with all these three: --dp 8 --enable-torch-compile and with cuda graphs enabled. I tried manipulating the value of mem_fracion_static, but I always got either "not enough memory, increase mem_fracion_static" or CUDA OOM "decrease mem_fraction_static, disable cuda graphs, or disable torch compile".
In your tests, were you successful in combining data parallelism with cuda graphs and torch compile? Is so, can you share your hardware configuration/os/SGLang version, so I could try to replicate?

Test on 0.3.1.post03，without --disable-custom-all-reduce on 4 * A100/A800 solved the issue.
/opt/conda/bin/python -m  sglang.launch_server  --model-path /model-path --disable-radix --tp 4 --context-length 32000
OS：ubuntu22.04
GPU: A800
CUDA Driver: 530.30.02
CUDA Runtime: 12.1
Model: Qwen2-72b-instruct-gptq-int4
sglang：latest

@smallstepman This works for me on 8xH100 (80GB)
 python3 -m sglang.launch_server --model Qwen/Qwen2-7B-Instruct --dp 8 --enable-torch-compile

@Xu-Chen Great to hear that. Let me close this for now.


Initial setup_circle action

          1 Warning

:warning:
Please provide a changelog summary in the Pull Request description @KrauseFx

  Generated by :no_entry_sign: Danger


cannot find run_fol_for_AD.py/all_track_files

Hi, author.
What is all_track_files numpy files contain?
Please help me! Thanks.

Hi @hwk0702 what specific file do you point to?

In the run_fol_for_AD.py code, the numpy file in track_dir is loaded. I am wondering what constitutes the numpy file and what format it is in.

@hwk0702  Great question! The .npy files are in the output format of deep-sort. Basically it's a 2D numpy array with columns as: frame_id, track_id, x1, y1, w, h. where x1 and y1 are the left top box vertex coordinates and w, h are box width and height. You can checkout the deep-sort repo to get better understand of this .npy format.

Can you show me an example?
frame_id = 130
track_id = 1, 2, 3, 7, 12, 13, 22
bbox = [434, 346, 725, 567], [922, 304, 1276, 606], ...

[130, [1,2,3,7,12,13,22], [[434, 346, 725, 567],[922, 304, 1276, 606], ...]]
[[130,1,[434, 346, 725, 567], [130, 2, [922, 304, 1276, 606]], ...]


Update error message to show actual error thrown by defi node

Update error message to show actual error thrown by defi node.

Can I ask what is the whitespace change in the JSX is it just whitespace

Can I ask what is the whitespace change in the JSX is it just whitespace

Can I ask what is the whitespace change in the JSX is it just whitespace

Yes, it's just whitespace.

Can I ask what is the whitespace change in the JSX is it just whitespace

Yes, it's just whitespace.