compareSync returned true on different stringified objects

I am trying to understand the behaviour of compareSync function. Please see the example from hashing a jsonstringify string, where we try to compare 2 stringified objects (with slight differences in their property value), since the strings are different the compareSycn should return false, but it returned true instead.
see the console result, the second line should return false instead of true
Put the snippet here as well
var bcrypt = require("bcrypt");

var first = {
    propOne: '56940cd0d8aa0fcd401ef101',
    propTwo: '56940cd0d8aa0fcd401ef102',
    propThree: '56940cd0d8aa0fcd401ef103'
};

var firstString = JSON.stringify(first);
var firstHash = bcrypt.hashSync(firstString, 10);
var firstStringMatchesFirstHash = bcrypt.compareSync(firstString, firstHash);
console.log('First string matches hash (expect: true): ' + firstStringMatchesFirstHash)

var second = {
    propOne: '56940cd0d8aa0fcd401ef101',
    propTwo: '56940cd0d8aa0fcd401ef102',
    propThree: '56940cd0d8aa0fcd401ef103fff'
}

var secondString = JSON.stringify(second);
var secondStringMatchesFirstHash = bcrypt.compareSync(secondString, firstHash);
console.log('Second string matches hash (expect: false): ' + secondStringMatchesFirstHash)

var firstStringMatchesSecondString = firstString === secondString;
console.log('First string matches second string (expect: false): ' + firstStringMatchesSecondString)

output
"First string matches hash (expect: true): true"
"Second string matches hash (expect: false): true"
"First string matches second string (expect: false): false"

See readme

Per bcrypt implementation, only the first 72 characters of a string are used. Any extra characters are ignored when matching passwords.


Allow vested funds to be staked via nomination pools

Currently, vested funds cannot be staked.
Since we have vested transfer, it should be possible to move the vested fund to the pool, and stake it.
Ideally, we want vested funds to be stake-able similar to direct staking.
Although, this is not super critical as vesting funds were mainly used for initial sales of DOT and are mostly done by now.
I am not 100% sure if this possible, ergo unconfirmed.

Okay, some thoughts on this:
vesting works off the basis of locks. locks prevent us from transferring funds from the user account to the pool account, which we absolutely have to do.
One option would to to keep the funds in the user account, and mint fake tokens in the pool side. but this is tricky because we have to make sure that the funds that are locked in pools cannot be reused in the native staking system. Perhaps we could reserve the funds (using named-reserves) and then mint some fake tokens on the pool side, but this is still hacky. With all such approaches, slashing would be quite difficult to get right.
Alternatively, we can force_transfer the funds out of the user account into the pool, and keep their vesting schedule. There nothing wrong with having a vesting lock on your account that is decreasing e.g. from 50 DOTs, while you have 0 DOTs. once you get e.g. 80 DOTs back sometime in the future, 50 of them would still be subject to vesting.

Here's a draft of a stupid, but possibly viable approach:
diff --git a/frame/nomination-pools/src/lib.rs b/frame/nomination-pools/src/lib.rs
index 3661a7f70b..e3b3c65058 100644
--- a/frame/nomination-pools/src/lib.rs
+++ b/frame/nomination-pools/src/lib.rs
@@ -875,7 +875,7 @@ impl<T: Config> BondedPool<T> {
 	) -> Result<BalanceOf<T>, DispatchError> {
 		// Cache the value
 		let bonded_account = self.bonded_account();
-		T::Currency::transfer(
+		Pallet::<T>::transfer_ignore_vesting(
 			&who,
 			&bonded_account,
 			amount,
@@ -1131,7 +1131,7 @@ impl<T: Config> Get<u32> for TotalUnbondingPools<T> {
 #[frame_support::pallet]
 pub mod pallet {
 	use super::*;
-	use frame_support::traits::StorageVersion;
+	use frame_support::{traits::{StorageVersion, LockableCurrency}, PalletId};
 	use frame_system::{ensure_signed, pallet_prelude::*};

 	/// The current storage version.
@@ -1153,6 +1153,8 @@ pub mod pallet {
 		/// The nominating balance.
 		type Currency: Currency<Self::AccountId>;

+		type VestingSchedule: frame_support::traits::VestingSchedule<Self::AccountId>;
+
 		/// The type that is used for reward counter.
 		///
 		/// The arithmetic of the reward counter might saturate based on the size of the
@@ -2104,6 +2106,25 @@ pub mod pallet {
 }

 impl<T: Config> Pallet<T> {
+	/// Transfer funds from a member wishing th join an account (upon [`Call::join`] or
+	/// [`Call::create`]) to the bonded account of the given pool.
+	///
+	/// This is just like a normal transfer, but will temporarily disable the lock associated with
+	/// vesting, and set it back in.
+	fn transfer_ignore_vesting(
+		from: &T::AccountId,
+		to: &T::AccountId,
+		amount: BalanceOf<T>,
+		req: ExistenceRequirement,
+	) -> DispatchResult {
+		use frame_support::traits::VestingSchedule;
+		let s = T::VestingSchedule::get_schedules(&from);
+		let res = T::Currency::transfer(&from, &to, amount, req);
+		// NOTE: event if the transfer fails, revert the schedule. Perhaps we can actually open a new transaction layer here.
+		T::VestingSchedule::set_schedules(&from, s);
+		res
+	}
+
 	/// Returns the pending rewards for the specified `member_account`.
 	///
 	/// In the case of error, `None` is returned.
diff --git a/frame/support/src/traits/tokens/currency/lockable.rs b/frame/support/src/traits/tokens/currency/lockable.rs
index a10edd6e3e..e16558d32c 100644
--- a/frame/support/src/traits/tokens/currency/lockable.rs
+++ b/frame/support/src/traits/tokens/currency/lockable.rs
@@ -73,6 +73,8 @@ pub trait VestingSchedule<AccountId> {
 	/// The currency that this schedule applies to.
 	type Currency: Currency<AccountId>;

+	type BlockNumber;
+
 	/// Get the amount that is currently being vested and cannot be transferred out of this account.
 	/// Returns `None` if the account has no vesting schedule.
 	fn vesting_balance(who: &AccountId)
@@ -105,4 +107,21 @@ pub trait VestingSchedule<AccountId> {
 	///
 	/// NOTE: This doesn't alter the free balance of the account.
 	fn remove_vesting_schedule(who: &AccountId, schedule_index: u32) -> DispatchResult;
+
+	fn get_schedules(
+		who: &AccountId,
+	) -> Vec<(
+		<Self::Currency as Currency<AccountId>>::Balance,
+		<Self::Currency as Currency<AccountId>>::Balance,
+		Self::BlockNumber,
+	)>;
+
+	fn set_schedules(
+		who: &AccountId,
+		schedules: Vec<(
+			<Self::Currency as Currency<AccountId>>::Balance,
+			<Self::Currency as Currency<AccountId>>::Balance,
+			Self::BlockNumber,
+		)>,
+	);
 }

This looks like an interesting issue to work on. @kianenigma are you working on this? If not I would like to give this a try.

I am discussing it with Polkadot auditors if this is reasonable, let me come back to you :)

A total of 800 accounts in Polkadot have vesting schedule, not so significant.

@kianenigma Do you think this feature would be used then? Or do you think this shouldn't be implemented?

This cannot work as I suggested. If multiple vested transfers are made into your account, and you already move parts of your vested funds to a nomination pool, then you are essentially delaying the release of the second vested schedule.


CONTRIBUTING.md should be general to both projects.

Everything that is mentioned in CONTRIBUTING.md also applies to libdaque and may as well apply to any other project we do, so why don't we create a repository hosting our contributing principles and only refer to it from viare's or libdaque's CONTRIBUTING.md?

Yes. It does so far.
But ViaRE will deal with more information eventually. And will require a broader set of contributions: UI/UX, Music, Story, Design, etc. and ViaRE's CONTRIBUTING.md file will be modified when required.

Wouldn't it be good any way to have something like a general CONTRIBUTING.md?
And only do the extra additions in ViaRE's CONTRIBUTING.md.

Discussion in personal meeting arrived at the conclusion that we'd keep CONTRIBUTING.md files in all projects even if they're the same, I can recall.
This to treat every repository apart from the others.
So can we close this?

Yes.


Add UI translations for Arabic, French, Spanish, Ukrainian, Russian

Add UI translations for Arabic, French, Spanish, Ukrainian, Russian. Use the option to translate UI with automatic translation tools.
Use choice of language of users coming from eventyay-tickets or -talk.

I think this can be closed as well


remove Repo#path in favor of Repo#full_name, closes #587

This resolves the extra code noted on #587.  As noted there, full_name is not available until the record is persisted, but (at least now) the tests all pass and the app seems to work anyway so I went with it as-is.  If it turns out that's a problem, please point me in the right direction so I can add a test and adjust this to get it passing.

Thanks - didn't think to look at the mailers.  I will update and try to write a test to make sure the mailers at least pass a basic smell test.

Ready for review?

Yes - sorry, I think this is ready now.

Thanks!


"Sign" UMH Datasource in Grafana

Currently the data source is indicated as unsigned. To remove this badge and get visibility in the Grafana Appstore we should sign the data sources and offer them via the Appstore.

According to the grafana documentation this would require us to get a Commercial plugin level. (Our stack is open-source, but for-profit)

We should still ask them, because you do not need to pay to use it (according to the link it only matters if you need to pay for it and not if it is for profit).
Community

No;
Free of charge

@Scarjit Do you want to ask them?

E-Mail to grafana was send, awaiting reply

Send another E-Mail :(


How to make circuitpython work?

I am trying circuitpython 8.2.6 firmware but it is not working for me.
I see that support for the board has been added to circuitpython here

https://github.com/adafruit/circuitpython/pull/7750

so it seems that someone has it working.
I am able to flash the firmware (using esptool or the firmware downloader from this repository) but that's about it. The blue LED is blinking furiously, the LCD is off and the only data on the serial line is this:
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:12748
load:0x40080400,len:3024
entry 0x400805dc

So, what am I doing wrong? Is it even supposed to work?

When I flash the testing firmware, it works, so it does suggest the board and the flashing process is working.

So the problem is that my board is 4MB variant and the board supported by circuitpython is 16MB variant. I've found out by trying different images to see which one will work (adafruit_feather_huzzah32 worked). The difference was the info about SPI memory. The working board has
CIRCUITPY_ESP_FLASH_MODE = dio
CIRCUITPY_ESP_FLASH_FREQ = 40m
CIRCUITPY_ESP_FLASH_SIZE = 4MB

while the non-working has
CIRCUITPY_ESP_FLASH_MODE = qio
CIRCUITPY_ESP_FLASH_FREQ = 80m
CIRCUITPY_ESP_FLASH_SIZE = 16MB

Creating my own board in ports/espressif/boards with the right config and building circuitpython gave me a working firmware.

@zwn Can you provide the firmware please ?


Add a test for ZR module firmware version streaming

Pull Request Functional Test Report for #2167 / acfee00953aa2ced956b33003463482384e6159f
No tests identified for validation.
Help


Fixes #315: Virus using Turtle

Description
Have added a pyscript that generates a visual animation resulting in an entity looking similar to a biological virus.
Fixes #315
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines (clean code) of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added screenshots that prove my fix is effective or that my feature works.

Hello @bislara, PTAL.

That was quite user-centric!
Updated as per the suggestion.


KV store for wrangler is totally broken

So it seems as though, i can specify kv stores to create but it does nothing to attach my worker to the namespace:
I specified
kv-namespaces = ["NAMESPACE2", "FOO", "BAR"]
and it created those namespaces , but it did nothing to attach those resources

Hey @posix4e - this is a known bug and we're working on implementing support for it in Wrangler. You can track the milestone here: https://github.com/cloudflare/wrangler/milestone/6


Li/no_std support: hashmap to btreeset

#BugFix
HashMap can be unpredictable when we encode/decode it within the Substrate runtime, so to always get the same order and result, we convert it to BTreeMap and then encode.
Solves 1 out of 4 in issue

Hi guys,
This PR removes spin but it's still in use in blockifier::sync.
Perhaps we should test with --no-default-features in CI?


Failure=blank only when using randomize map flag

diffreport-SUCCESS.txt
makeLog-FAILURE.txt
makeLog-SUCCESS.txt
I am able to use the randomizer to generate random ROMs using any of the selected flags except for the randomize map flag. Every time I use the randomize map flag, whether by itself or in any combination of other flags, I receive the below error message every time.
nullThis seed failed to successfully generate a ROM.
Failure=
See makelog for details.
I attached a makeLog file that was a failure, and a subsequent makeLog and diffreport from when I did not select randomize map and it was successful (same seed/ROM tested for all attached files).
If I select any combo of options outside of the randomize map option, the random ROM is generated successfully and those criteria work in game, confirmed by starting games as Ernst and Otto and being assigned different starting ships as well as finding different trade goods in their starting ports.
I have tested having the ROM in my randomizer folder, in a folder inside my randomizer folder, in my C:Documents folder as well as a folder on an entirely separate drive and nothing seems to change the results. I'll also point out that using the randomize map option paired with the map preview flag will fail, but it does generate a map preview that I would assume is the map that I would receive if the file had successfully generated.  The map preview will differ every time based on the selected seed and if any of the continent/island/ice cap sliders are adjusted.
Last thing I'll add just to cover as many bases as possible is my computer shows I have the following version of Java installed. Java 8 Update 321 (64-bit)

I looked at the failure case you sent me (seed and flags) and I was able to successfully generate that rom.
If you look at the randomizer's Theme tab, you should see a list of Kingdoms, Areas, Ports, Supply Ports, Discoveries, and Commodities.  Make sure everything in there is human readable (no garbage).
Also, what size is your ROM?  The randomizer should be compatible with both headered and headerless roms (it is a 512 byte header if you have one), but I personally used a headered rom.

ROM Size: 2.00 MB (2,097,152 bytes) with the following checksum info:
CRC32: 3C3C63E6
CRC64: D9B5D253769F93BE
SHA256: 64BC4707F422661A66618088887E2363A5F896EA683C58984FFFD96DD21AB5F0
SHA1: E63BCBED001C63011DF0AC043BC56D0FE323482F
I did check the randomizer's Theme tab and when I select Edit All under any given tab, the info I see populated is what I would expect to see in game for those fields (whether they are port names, discoveries, trade goods etc).

I found the issue and have uploaded the fix.  Let me know if it works for you so I can close the issue.

You're a genius, you can close it up this is working just fine now thanks again.

If you knew what caused the issue you'd put a dunce cap on my head.  I'm hoping to remove my many dunce caps someday.
Glad to see it working better.


AlexNet, ResNet... fail to compile in the onnxmlirczar/onnx-mlir:s390x container

When compiling AlexNet.onnx, ResNet50.onnx models using onnx-mlir --EmitLib AlexNet.onnx in the onnxmlirczar/onnx-mlir:s390x container, I got the following error:
error: reduction dimension must be the same
error: Failed to scan onnx.MatMul parameters successfully
error: shape inference failed

Notes:

I saved the AlexNet in 'tf' format based on python3.6 tensorflow2.4.0 Ubuntu 20.04.4 LTS Linux version 5.15.0-41-generic s390x,  here is the code:

import tensorflow as tf
import pathlib
import random
from keras.layers import Flatten,BatchNormalization
from keras.layers.convolutional import Conv2D
from keras.layers.merge import add
from keras.models import Sequential
from keras.layers import Input, merge, ZeroPadding2D
from keras.layers import Dense, Activation
from keras.layers.core import Dropout
from keras.layers.convolutional import Convolution2D
from keras.layers.pooling import AveragePooling2D, GlobalAveragePooling2D, MaxPooling2D
from keras.layers.normalization import BatchNormalization
import six
from keras.regularizers import l2
from keras.models import Model
import keras.backend as K
K.set_image_data_format('channels_last')
try:
    from keras import initializations
except ImportError:
    from keras import initializers as initializations

os.environ["CUDA_VISIBLE_DEVICES"]="-1"

class Config(object):
    normal_size = 227
    channles = 3
    classNumber = 1000

class MODEL(object):

    def __init__(self,config):
        self.config = config

    def AlexNet(self):
        model = Sequential()
        # input_shape = (64,64, self.config.channles)
        input_shape = (self.config.normal_size, self.config.normal_size, self.config.channles)
        model.add(Convolution2D(96, (11, 11), input_shape=input_shape,strides=(4, 4),  padding='valid',activation='relu', kernel_initializer='random_normal'))
        model.add(MaxPooling2D(pool_size=(3, 3), strides=(2, 2)))#26*26
        model.add(Convolution2D(256, (5, 5), strides=(1, 1), padding='same', activation='relu', kernel_initializer='random_normal'))
        model.add(MaxPooling2D(pool_size=(3, 3), strides=(2, 2)))
        model.add(Convolution2D(384, (3, 3), strides=(1, 1), padding='same', activation='relu', kernel_initializer='random_normal'))
        model.add(Convolution2D(384, (3, 3), strides=(1, 1), padding='same', activation='relu', kernel_initializer='random_normal'))
        model.add(Convolution2D(256, (3, 3), strides=(1, 1), padding='same', activation='relu', kernel_initializer='random_normal'))
        model.add(MaxPooling2D(pool_size=(2, 2), strides=(2, 2)))
        model.add(Flatten())
        # model.add(Dense(4096, activation='relu'))
        model.add(Dense(1024, activation='relu'))
        model.add(Dropout(0.5))
        # model.add(Dense(4096, activation='relu'))
        model.add(Dense(1024, activation='relu'))
        model.add(Dropout(0.5))
        model.add(Dense(self.config.classNumber, activation='softmax'))
        # model.compile(loss="categorical_crossentropy", optimizer="adam", metrics=["accuracy"])
        return model

C = Config()
model = MODEL(C)
alexnet = model.AlexNet()
alexnet.summary()

alexnet.compile(optimizer=tf.keras.optimizers.Adam(lr=0.001),
            loss='sparse_categorical_crossentropy',
            metrics=['accuracy'])

alexnet.save('.\models-s390x\AlexNet', save_format='tf')

I convert the AlexNet to onnx based on python3.6 tensorflow2.4.0 Ubuntu 20.04.4 LTS Linux version 5.15.0-41-generic s390x, here is the code:

import tensorflow as tf
import onnx
import tf2onnx
import os
import argparse
import json
os.environ["CUDA_VISIBLE_DEVICES"]="-1"

def convert_to_onnx(model, output):
    print('Input model: ' + model)
    tf_model = tf.keras.models.load_model(model)
    # print(tf_model.summary())
    onnx_model_proto, _ = tf2onnx.convert.from_keras(tf_model, output_path=output)
    print('Save onnx model to ' + output)

def main():
    parser = argparse.ArgumentParser(description="convert keras model to onnx")
    parser.add_argument('--saved-model', dest='model', help='saved model')
    parser.add_argument('--output', dest='output', help='onnx model')
    args = parser.parse_args()
    convert_to_onnx(args.model, args.output)

if __name__ == "__main__":
    main()

Can you provide your .onnx file?

Can you provide your .onnx file?

Thanks for your reply! I have uploaded the onnx files

Can you provide your .onnx file?

Thank you for your reply! The onnx files are too big to be attached. I have uploaded the AlexNet.onnx and ResNet50.onnx to Box, and you can download it through this link:https://app.box.com/s/wrir7z7uyblb7qb625qrzgj7qxulbjqh

Can you provide your .onnx file?

Thank you for your reply! The onnx files are too big to be attached. I have uploaded the AlexNet.onnx and ResNet50.onnx to oneDrive, and you can download it through this link: [https://1drv.ms/u/s!AgwO8y5CADa4jTT6iVYUOViUnUFT?e=EQmS7K]

Can you provide your .onnx file?
Thank you for your reply! The onnx files are too big to be attached. I have uploaded the AlexNet.onnx and ResNet50.onnx to drive.google.com, and you can download it through this link:
usp=sharinghttps://drive.google.com/file/d/1EIN0wignnizyx_RQVwziXvYnSsgFrE26/view?usp=sharing

@cfig-xk is this still an issue with the latest releases?

@AlexandreEichenberger I tried compiling the above two models in the latest released container, but got a new error:
error while loading shared libraries: libChloOps.so.16git: cannot open shared object file: No such file or directory

@yaochengji @Connor-XY libChloOps.so.16git is part of third_party/mlir-hlo.  It's not being installed by make install.

@yaochengji @Connor-XY libChloOps.so.16git is part of third_party/mlir-hlo. It's not being installed by make install.

A straightforward way to fix this is to add ChloDialect to the install targets of src/Conversion/ONNXToMhlo/CMakeLists.txt. But I think we need to fix it systematically to avoid further similar bugs.

Can we get a fix for this relatively soon? I'm about to put in a Jenkins step that actually verifies that our user docker image can successfully compile a simple model. Right now, our user docker image is broken and unusable.

@gongsu832 sorry for the delay, https://github.com/onnx/onnx-mlir/pull/1829


Deno support

Hello, I am opening an issue for supporting Deno via ES module importing out-of-the-box, per discussion in issue #138 at the suggestion of @jacoscaz.
Deno is a runtime for JavaScript created by Ryan Dahl (who also built Node). Benefits of Deno include:

Direct support for TypeScript
Security by default
Browser-like behavior whenever possible

Members of the Quadstore team may have a better idea than I do of how far-off this is. I don’t have a great sense of how much the most popular RDF/JS projects depend on Node. However, Skypack or a similar Deno-friendly CDN may be a good way to provide stopgap support.
Some helpful Deno links:

Deno homepage
Deno v1.13.2 manual

Section on module system
Section on using npm / Node.js code
Section on Deno-friendly CDNs, e.g. Skypack

Skypack docs

Package checks: Best practices for Node package authors wishing to support ES modules.
Deno support: How Skypack can be used for Deno specifically, and when this is/isn’t possible.

10 Things I Regret About Node.js - Ryan Dahl - JSConf EU: Helpful for understanding the philosophy and design goals of Deno.
Syntax.fm episode on Deno: A somewhat-silly but comprehensive podcast introduction to Deno that assumes no prior knowledge.

Thanks to the recent addition of separate ESM vs. CJS builds, partial support for Deno is now available through Skypack in<EMAIL_ADDRESS>import { DataFactory } from<EMAIL_ADDRESS>import { Quadstore } from<EMAIL_ADDRESS>import { MemoryLevel } from<EMAIL_ADDRESS>
const backend = new MemoryLevel();
const dataFactory = new DataFactory();
const store = new Quadstore({ backend, dataFactory });

await store.open();
await store.put(dataFactory.quad(
  dataFactory.namedNode('ex://s'),
  dataFactory.namedNode('ex://p'),
  dataFactory.namedNode('ex://o'),
));
const { items } = await store.get({});
console.log(items);
await store.close();

Further work is needed to add support for Deno in quadstore-comunica, thus enabling SPARQL queries in Deno, and likely depends on fixing this upstream issue: https://github.com/RubenVerborgh/SPARQL.js/issues/139 .

Closing - will be a part of the upcoming 11.0.0 release!


How to add extension php-intl

How can I add php extension intl to composer? I got this error requires ext-intl * -> the requested PHP extension intl is missing from your system.

Ideally you don't try to add those extensions to this container, instead run composer install with the --ignore-platform-reqs flag.

@Richtermeister Thank you! You rocks. It works.


PD-2758: Add Slide-tags docker

Slide-tags Dockerfile taken from https://github.com/MacoskoLab/Macosko-Pipelines/blob/main/positioning/Dockerfile
Modified slightly to reduce the number of layers, etc

Created new ticket to deal with the Trivy errors in the PR


Changes to CollisionShape2D debug color project setting are not applied due to the previous default color being considered as custom

Tested versions

Reproducible in: 4.3.dev b091162a9

System information
Godot v4.3.dev (4a0160241) - Fedora Linux 39 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 550.67) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Issue description
Changes to CollisionShape2D debug color project setting are not applied due to the previous default color being considered as custom:

https://github.com/godotengine/godot/assets/180032/8208ad7a-e514-4271-9f89-69f448f64b34
To resolve this, I suggest using the RayCast3D custom debug color behavior instead:

An opaque black color is considered as being "no override". In practice, you'll almost never want a debug shape to be opaque black – and if you really want to, you can use #010101 or #000001 anyway.
Steps to reproduce

Create a CollisionShape2D with a CircleShape2D.
Change debug shape color in the project settings.
Select another node and select the CollisionShape2D again to force the inspector to update.
Notice how the default debug colors becomes considered as a custom debug color in the CollisionShape2D inspector, which means 2 things:

The new default color isn't automatically applied; you have to click the reset icon instead.
The old debug color is written to the scene file as it's a non-default value.

Minimal reproduction project (MRP)
N/A

See #39072.

I think in practice you rarely change the project setting.

To resolve this, I suggest using the RayCast3D custom debug color behavior instead

This option is inconvenient because you need to manually change the alpha channel. For a ray cast it's not necessarily as it is a line, but the collision shape is a figure. Alternatively, we could use PROPERTY_HINT_COLOR_NO_ALPHA, but this would make the alpha channel unconfigurable.


Search Console API Error:  403 Forbidden

Why am I getting this error when integrating the Google search console? Followed the steps exactly.
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (3days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (7days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
[start] [ERROR] Search Console API Error for domain.com (30days) :  403 Forbidden
Running on locally and fly.io. Still the same issue.
Could Not fetch Keyword Data for this Domain from Google Search Console.

Fixed it myself. Thanks

@joepolask86 how did you fix it?

@joepolask86 how? :)

Thanks @PaoloPC
Already fixed it a while ago somehow and I don't remember what I did to fix


Net Generation data missing from generation_eia923.csv datapackage

I was working on https://github.com/catalyst-cooperative/pudl/issues/245 and attempting to calculate gross to net generation ratios using gross generation data from cems and net generation data from eia-923, but I noticed that there is missing data in the generation_eia923.csv data package. I was looking at plant_id_eia = 55397, which has three generators: ST1, CT1, and CT2. Data for these three generators is present in generation_eia923 up to 2017, but the 2018 data only includes data for ST1. I went back and checked the original 2018 EIA-923 excel file, and it contains data for all three generators.
It seems like for some reason, the ETL process might be dropping some of the good data. Looking at the generation function in the eia923.py transform module, I do not see an obvious reason why these records would have been dropped, as the generator_id is not missing, and it has non-zero data available.
I noticed this first while using the v1.0 datarelease of pudl-eia860-eia923-epacems, but downloaded v1.1 of pudl-eia860-eia923-epacems and the problem persists there as well. I have not tried using pudl-eia860-eia923, but I am assuming that the eia923 data should be the same in both?

Are you saying that the net generation for those generators are 0.0, or null?  That does seem weird. Let me play with the live DB a little bit and see what it looks like.

@zaneselvans What I'm saying is that there is no record at all for generators CT1 and CT2 in the 2018 datapackage, even though they both are present in the raw 923 data. It is as if those generators were dropped somehow.

I've been looking into this a bit more and there seems to be a couple of issues with the data:

Sometimes in EIA-923 a plant will appear in "Page 1 Generation and Fuel Data" with nonzero net generation data by fuel, but it is missing from "Page 4 Generator Data" (for example plant 118 in 2017). Not sure if this is an existing data issue that you are aware of with the EIA-923 raw data?

Sometimes a plant appears in both "Generation and Fuel Data" and "Generator Data" in the raw data file with non-zero net generation, but for some reason it does not make it to the generation_eia923 data package file. Not sure if this issue has been explored further since May, but if not, I can try to take a look at what's going on.

Plants 493 and 508 make for an interesting comparison using the 2012 EIA-923 spreadsheet report.  Plant 493 represents its generation in both the "Page 1 Generation and Fuel Data" and the "Page 4 Generator Data" and the net generation between the two pages sums correctly, though Page 1 adds up only the two fuel types driving all the Prime Movers, while Page 4 adds up 3 generators (1, 2, and 3) irrespective of fuel type.  Plant 508 has WND generation data on Page 1 that is not present on Page 4, and the net generation of 508 does not tie between the two pages.
I think that 'generation_eia923' is a bit of a stretch--it is called "Generators" in the 923 spreadsheet, and it looks like generaTION data is secondary to its generaTOR purpose.
In any case, the documentation should definitely call out which should be used for which purpose, and it would be good to see how, as this project matures, it can synthesize a true best-of-breed rendering of this primary data for the widest range of valid use cases.

We definitely need to compile more detailed table-level metadata and
incorporate it into the data dictionary so that it's clear to everyone what
they should expect to find in each table. The only unique information
reported in the "generaTOR" table in EIA 923 is the "generaTION" -- the
rest of it is generator attributes whose home is actually the generator and
plant and utility tables, which comes from the EIA 860, which is why we
renamed it generaTION. The generator attributes reported there (and
everywhere else too...) are harmonized late in the ETL process so that we
can iron out any inconsistently reported values, and in the end the only
unique information that is extracted from this EIA 923 page is the monthly
generation per generator.  But as you've noticed, a large portion of the
generation isn't actually reported there (IIRC it's around 40% of the total
MWh that are "missing" -- because not all generators meet the reporting
requirements for that part of the form) whereas the generation_fuel_eia923
table (and the Generation and Fuel Data page in the EIA 923 spreadsheet)
reports much more generation... but not (insert scream here) on the basis
of generator. Instead it's broken down by plant, prime mover, and fuel.
Helpfully it is broken down by fuel which goes to electricity production,
and fuel which goes to high temperature process heat via CHP systems.
The only plants whose net generation should match exactly between the two
tables are those for which ALL of their generators meet the reporting
requirements for the generation_eia923 table, and also don't have any
associated CHP.
And then on top of all that, the Generation and Fuel Data spreadsheet
reports "total fuel consumption" in terms of heat content (MMBTU), even
when it's not a thermal plant -- wind, PV, hydro, etc. -- using some
arbitrary average fossil plant thermal efficiency to convert the energy
output into an "equivalent" heat input.

Welp, not 100% sure what ultimately fixed this, but this data is thankfully showing up just fine now.


Update demo links in readme to examples with v1.2.1

Related to #342
Link to updated rendered readme

You are the best, thanks so much!


Create a new maven release

The latest commits by @dlew appear to fix all of the current issues I am having with Markdown Lists.  The problem is I cannot get Boost to work correctly so I cannot build.  Its been a year since the last release.  Can someone create a new maven release?

Or simply share the libraries somewhere

Do you think that's possible to create a franken release by copying the new java files with the older native libs?

I have recently performed a build on the project and I am hosting it here as a gradle dependency, feel free to use it:
https://github.com/Commit451/bypasses

Thanks @Jawnnypoo - exactly what I was looking for.
@albert-wang @camr @cwc @DDRBoxman @johnmichaelcook @peter-bonanni @vbonanni you guys have any plans to support gradle dependency like this?


1.20.6 Render Bug

You may have deleted the code responsible for rendering in the file and that's why such a picture at low resolution:

If you took my project, unfortunately it's buggy

I currently have a local dev branch that kind of fixes this. I'm working on correctly fixing the scaling issue for glowing, and that is the same stack as the rest of the renderer. So as soon as I get that to work, the rest should work too. Cheers!

I currently have a local dev branch that kind of fixes this. I'm working on correctly fixing the scaling issue for glowing, and that is the same stack as the rest of the renderer. So as soon as I get that to work, the rest should work too. Cheers!

Your WIP version is working at the rendering resolution but it doesn't affect the numbers in the mod menu only the window size.
I hope you will notice this message quickly and fix it.

Your WIP version is working at the rendering resolution but it doesn't affect the numbers in the mod menu only the window size. I hope you will notice this message quickly and fix it.

This is what it looks like now:

I bid farewell to you past developer of the ResolutionControl mod!
Because there is a new developer who has already fixed the bug!
I hope you will notice and decide to do something about it!
Here is the link if you are interested: https://modrinth.com/mod/resolutioncontrol3/version/1.21-4.0.0

If anything I decided to come back to see how you fixed this bug.


METRON-595: ES Writer uses more than one IP

Resubmitting pull request due to sporadic test failure as per comments on the last pull request.
Simple fix. Before, the client was reinitialized for each ip, so only one was actually used. By initialing the client outside the loop, it uses all of the ip's.

Thanks for this change, @JonathanRider - can you tell me how you tested it?

Just realized we had some custom code since we couldn't get the List object working for feeding in multiple IP's. So I added in the code so you can just have a comma separated list of IP's.
We have a dev cluster that has 3 master nodes, but I only gave the writer 2 ip addresses. I sent data through, then stopped the elasticsearch service on that machine. Sent data through and it works (previously this would give a NoNodeAvailable exception). I then started ES back up on that server, and shut down the ES Service on the other server and sent data through again and it also works.

Is there anything else I need to do in order to get this merged in, @dlyle65535 ?

Could you give it a run up on Quick Dev using your patch rebased on master?

Is quickdev working currently? I just spun it up and tried to start up a parser topology but get an error. Looking at it, it seems like the error seen here: https://community.hortonworks.com/questions/68798/metron-enrichment-fail-to-start-with-ambari-instal.html
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/storm/Config
at org.apache.metron.parsers.topology.ParserTopologyCLI$ParserOptions.(ParserTopologyCLI.java:199)
at org.apache.metron.parsers.topology.ParserTopologyCLI$ParserOptions.(ParserTopologyCLI.java:47)
at org.apache.metron.parsers.topology.ParserTopologyCLI.main(ParserTopologyCLI.java:266)
Caused by: java.lang.ClassNotFoundException: org.apache.storm.Config
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 3 more

quick dev is working - i spun one up this morning from a new branch off of master

And you can start a topolgy in it? This is the command I'm running:
/usr/metron/0.3.0/bin/start_parser_topology.sh -z node1:2181 -k node1:6667 -s bro
And storm version gives <IP_ADDRESS>.3.4.7-4
And the HDP stack in ambari says: HDP-<IP_ADDRESS>-4
Can you confirm that these match yours?

Just ran it on quickdev where I set the es.host in the global json file to "node2,node1" where node2 doesn't exist as it is a single node vagrant.
Using my patch, it writes to ES without a problem as it fails to use node2, so it switches to node1.
I then compiled master and did the same thing and received this error since node2 doesn't exist and it fails to use the second host.:
2016-12-01 21:41:18.942 o.a.m.w.BulkWriterComponent [ERROR] Failing 5 tuples
org.elasticsearch.client.transport.NoNodeAvailableException: None of the configured nodes are available: [{#transport#-1}{<IP_ADDRESS>}{node2/<IP_ADDRESS>:9300}]

@dlyle65535 is there anything specific that you wanted me to test on quickdev that I haven't already done?

Nope, looks like you did a test run with changes and @ottobackwards did the clean one I was going to do, so I'm +1.
Thanks!

@dlyle65535 I did not test, I was answering the question of if quick-dev works at all

Oh, thanks for that. Let me run it up really quickly then. Totally mis-read you, @ottobackwards.

This looks good to me, @JonathanRider - do you want me to use the email on your profile for the commit?

Yep. Thanks!


developers documentation of conf.py

Changes
Describe changes in this PR
Related Issues
Closes # (add issue numbers)
Checks

[ ] updated CHANGELOG.md
[ ] updated tests
[ ] updated doc/

I think this can be closed?
Move the documentation to the WiKi?

please close this PR if applicable and clean up the related branches @vhirtham

Copied documentation to a Wiki page


feature: use remainig amount for fees

I created a transaction to two outputs and both required me to set an exact amount, I quickly calculated the amounts plus my anticipated fee before but of course the fee was a bit different so Sparrow created a dust output...
I know I could've set the fee manually, but I was in a rush. It would be nice to have a button that lets you just use the remaining amount as fee, in those situations I don't mind overpaying fees a bit instead of sitting on a dust output in my wallet now.

I created a transaction to two outputs and both required me to set an exact amount, I quickly calculated the amounts plus my anticipated fee before but of course the fee was a bit different so Sparrow created a dust output...
I know I could've set the fee manually, but I was in a rush. It would be nice to have a button that lets you just use the remaining amount as fee, in those situations I don't mind overpaying fees a bit instead of sitting on a dust output in my wallet now.

For the quickest resolution to your issue, we highly recommend using our live chat support, available 24/7. Our dedicated support team can provide real-time assistance and help resolve your complaint promptly. You can access the live chat here: LIVE SUPPORT.
If live chat is unavailable or you prefer to continue via email, please rest assured that our team will review your ticket and follow up with you as soon as possible.

In general, the coin selection algorithm in Sparrow doesn't create dust outputs by design, and actually operates in the way you desire, increasing the fee unless a substantial (>100k sats) change output can be created. When this cannot be achieved (due to lack of available UTXOs) Sparrow does it's best to fulfil the desires of the user as reflected in the interface.

It would be nice to have a button that lets you just use the remaining amount as fee

The cost of adding another button to an already complex screen is substantial, for what is in essence a niche use case. Sparrow tries to indicate the results of the the desired fee selection in the transaction diagram, and it's fairly simple to adjust the fee slider to achieve the result you wanted. I would argue this is a more elegant interface than another button (which in fairness, you may also have forgotten to use in your rush).


Reduce memcpy by filling the buffer in reverse order.

Additionally, concatenate adjacent memcpy.
My machine's results.
reusebuffer    7.367s
reusebuffer2   5.859s

Optimisations in true branch of if (num_digits != next_num_digits), which gets executed just 8 times (when number grows to next order of magnitude), don't really impact the performance.
However I like the idea of loading number buffer into vector register directly, avoiding extra memcpy, I will think about it. On my machine it gives something like 15-20% speed-up, which is significant.


Ability to apply to just current project or all projects.

I need the ability to apply my current club member to just my current project or all projects. So that I can have different club members for different projects on the same IDE.
I need the ability to apply whether the current project is in dark mode or all projects are either in light or dark mode. So that I can have club members be light or dark on different projects on the same IDE .

I tried, but you can't. Because the UIManager is shared between windows, so you can't have multiple themes.
I've even opened an issue at Youtrack but so far it is not planned. I know that there is an option to do MultiLaf but I couldn't do it. Good luck!

Duly Noted! Thanks for the heads up!

 VM438:2 # 37   Ability to apply to just current project or all projects.   https://api.github.com/repos/cyclic-reference/ddlc-jetbrains-theme/issues/37


[From marketplace feedback] Support the Cosmos DB Emulator

Excellent extension. Support for the Azure CosmosDB Emulator would be a useful addition though.

Thanks for taking this feedback on board. I would like to be able to use the same tool for both development and production and to be able to connect to the Emulator when developing code locally, all from the same tool.


Minimized version of pull-to-reload

Not much to say

Thanks. This addition now requires that all future releases must include a minified version. Which software / compression / minifier did you use?

@mdczaplicki

Hey, yeah sure. Now after every change you need to minify. As you can see
it is almost twice as lighter as normal version.
Easiest to use is https://jscompress.com/ or any other online. But
sometimes code may be stored somewhere on the server - so might not be the
best option to use for some closed-source projects.
You can either use this one - https://github.com/mishoo/UglifyJS - it is
much more advanced.
Z wyrazami szacunku,
Marek Czaplicki
2017-03-06 9:40 GMT+01:00 Erlend Ellingsen<EMAIL_ADDRESS>
Thanks. This addition now requires that all future releases must include a
minified version. Which software / compression / minifier did you use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ErlendEllingsen/pull-to-reload/pull/5#issuecomment-284334016,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIr8atJ_yoymR5rup291oYnwt3isr6Gdks5ri8ZwgaJpZM4MTmbT
.

Yeah I am using UglifyJS for most of my projects😄 just wanted to check what you used

For this one - I have used online tool :)


Possible memory leak when inferencing BLOOM 176B

System Info
- `Accelerate` version: 0.11.0
- Platform: Linux-4.18.0-305.25.1.el8_4.x86_64-x86_64-with-glibc2.17
- Python version: 3.8.13
- Numpy version: 1.22.3
- PyTorch version (GPU?): 1.11.0a0+gitbc2c6ed (True)
- `Accelerate` default config:
	Not found

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
Script:
https://github.com/mayank31398/Megatron-DeepSpeed/blob/add-generation-server/scripts/inference/bloom-accelerate-server.py
Usage: python scripts/inference/bloom-accelerate-server.py --model_name bigscience/bloom --dtype bf16 --log_file data.log --host $ADDRESS --port $PORT
Memory blowup over time discussed here: https://github.com/bigscience-workshop/Megatron-DeepSpeed/pull/308#issuecomment-1205757494
Expected behavior
This memory leak should not occur I think.

The model is used on our side on the inference API with the same options and without any memory leak, so I suspect the memory leak comes from somewhere else in the script and not Accelerate per se. I'm unfamiliar with Flask for instance, so not sure if it properly releases the memory of the objects no longer needed?
In any case, we'd need a smaller reproducer (ideally with a smaller model) to investigate more. We haven't seen anyone reporting any memory leak on large models as of now (including BLOOM, OPT, GPT-Neo-X or T5/T0pp)

Hmm, @sgugger can you tell which library are you guys using for the inference API, if not flask?

We use starlette on our side.

If I call a torch.cuda.empty_cache() after this, then this happens:

Could it be that this is expected behaviour?
@ydshieh
I am seeing a memory blowup with gpt2 also after replacing bigscience/bloom to gpt2
I am not sure if this is correct approach to measure memory in pytorch models

With pdb, I am seeing a blowup too.
But my guess would be this is not right way to measure memory since, I see something similar with GPT2 as well. I think the PyTorch memory allocator allocates some memory a priori for tensors and that is shown up in nvidia-smi.

PyTorch memory allocator allocates some memory a priori for tensors and that is shown up in nvidia-smi.

This is correct. I also had an issue previously, see here. In short, PyTorch won't always release GPU memory - it can re-use them later (faster operations), so it doesn't mean there is memory issue.
But after empty_cache, we should see the usage drops down, although might be partially.

You may also be able to get a bit more by doing garbage collection as well, after deleting the model in python
E.g.:
Import gc
del

@mayank31398 , when you say a blowup too, what it means?
We should measure the difference after the model inference against when the model is loaded to cuda but without running any input.
For GPT2, after loading the model, my GPU uses 1388 MB, and after inference, it goes to 1470 MB. I won't be surprised with this numbers however.

Hi, I have something for you @mayank31398 . Below is an example with t5-large (GPT2 is quite small to see the difference).

model = model.to("cuda"): 3662 MB
After the generation is done, but not return yet: 7746 MB
After the generation is done, and return to the main: 7746 MB
After empty cache: 3732M

So emptying cache can bring the GPU memory usage back to the point where model is loaded to GPU.
Here is the code
(The FRANCE_ARTICLE, SHORTER_ARTICLE, IRAN_ARTICLE, ARTICLE_SUBWAY are copied from https://github.com/huggingface/transformers/blob/0f257a87749e0a72bda260c6f319a45dae1e7c4d/tests/models/t5/test_modeling_t5.py#L924)
import pdb

from transformers import AutoModelForSeq2SeqLM, AutoTokenizer
import torch

def run(model, dct):

    hypotheses_batch = model.generate(
        **dct,
        num_beams=4,
        length_penalty=2.0,
        max_length=142,
        min_length=56,
        no_repeat_ngram_size=3,
        do_sample=False,
        early_stopping=True,
    )

    print("gen. done")
    pdb.set_trace()

if __name__ == "__main__":

    ckpt = "t5-large"
    tokenizer = AutoTokenizer.from_pretrained(ckpt)

    model = AutoModelForSeq2SeqLM.from_pretrained(ckpt)
    model.config.update(model.config.task_specific_params["summarization"])

    dct = tokenizer(
        [model.config.prefix + x for x in [FRANCE_ARTICLE, SHORTER_ARTICLE, IRAN_ARTICLE, ARTICLE_SUBWAY]],
        padding="max_length",
        truncation=True,
        return_tensors="pt",
    )
    print("input / model on cpu")
    pdb.set_trace()

    dct = dct.to("cuda")
    print("input to gpu")
    pdb.set_trace()

    model = model.to("cuda")
    print("model to gpu")
    pdb.set_trace()

    run(model, input)
    print("model run done")
    pdb.set_trace()

    torch.cuda.empty_cache()
    print("clear done")
    pdb.set_trace()

Deleting the model is not an option for me.
I am trying to use the model in a server setting for a lot of folks.
Related PR: https://github.com/bigscience-workshop/Megatron-DeepSpeed/pull/328

You may also be able to get a bit more by doing garbage collection as well, after deleting the model in python
E.g.:
import gc
del model
gc.collect()

(Also sorry for accidently closing, on mobile and hit the wrong button!)

Deleting the model is not an option for me.
I am trying to use the model in a server setting for a lot of folks.
Related PR: https://github.com/bigscience-workshop/Megatron-DeepSpeed/pull/328

Yes, thanks I think Ill try to see the memory usage over time by running in a for loop or something.
To see how this changes memory (both in server and non-server settings).

what @ydshieh said and more:
to track real memory usage / debug potential leaks always:

call gc.collect() first - since python's GC is scheduled and w/o it you might miss object and its associated memory release
then clear the cuda cache
measure

but don't do any of the above for production.

This is not an issue anymore. Thanks for helping guys.
Closing this :)

@mayank31398 Would you like to share what works for you :-) 🙏

I converted my server to flask and ran with gunicorn with 1 worker.
This serializes all requests however


[Bug]: list patterns it not listing all patterns from the patterns folder

What happened?
I just updated fabric with git pull and when running fabric --list it is not listing all the patterns.
~/fabric/patterns $ ll -1 | wc -l
112
~/fabric/patterns $ fabric --list | wc -l
109
Version check

[X] Yes I was.

Relevant log output
No response
Relevant screenshots (optional)
No response

Hey, my issue seems related as well -
I just create personal */patterns/{my_pattern_folder}/system.md.
when I check it with  ls fabric/patterns | grep {my_pattern_folder}  it does found it
However whenever I use fabric -l | grep {my_pattern_folder} it doesn't find it.

Hey, my issue seems related as well - I just create personal */patterns/{my_pattern_folder}/system.md. when I check it with ls fabric/patterns | grep {my_pattern_folder}  it does found it However whenever I use fabric -l | grep {my_pattern_folder} it doesn't find it.

Hi, you have to copy your pattern into the config, not the project directory. The patterns are fetched from ~/.config/fabric/patterns

Hey, my issue seems related as well - I just create personal */patterns/{my_pattern_folder}/system.md. when I check it with ls fabric/patterns | grep {my_pattern_folder}  it does found it However whenever I use fabric -l | grep {my_pattern_folder} it doesn't find it.

Hi, you have to copy your pattern into the config, not the project directory. The patterns are fetched from ~/.config/fabric/patterns

Hey
Thank you @blakesims
I did it as well (probably edited my last comment after you answered, but it doesn't work either)

Alternativly you can put the patterns in the project folder and run fabric --setup which should get them intp the ~/.config/fabric/patterns and make them useable.


[Project Proposal] /randomActOfKindness

Description: This new slash command will tip a random user X bch.
Use:
/randomActOfKindness 0.01

Result:
You tipped 0.01 ($1.38) to @taariqlewis!

Ooh! Yesssss!
On Wed, Apr 25, 2018, 8:46 AM Robert Durst<EMAIL_ADDRESS>wrote:

Description: This new slash command will tip a random user X bch.
Use:
/randomActOfKindness 0.01
Result:
You tipped 0.01 ($1.38) to @taariqlewis!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SFCryptocurrencyDevs/tipmebch/issues/17, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAq1qBIbCBhP8sPA_yTE8in9hEdFOdyNks5tsJo8gaJpZM4TjsCk
.


Get back other http headers (Content type, Accept) in case of adding …

A colleague has found that this pull request brokes communication with Appium. Appium response gives Invalid parameter response, in the case when Except header is set.
After some investigation, I have found that my code
curl_setopt($this->curl, CURLOPT_HTTPHEADER, ['Expect:'];
do not add the header, but re-sets all HTTP headers. So it removes those from constructor part:
[                 'Content-Type: application/json;charset=UTF-8',                 'Accept: application/json' ]

Hi @antoninrykalsky , I updated the PR a bit (this way it would mean adding another Expect header each time the Executor is called to execute some command, because the curl instance is shared for the script lifetime). When Travis is done I will merge it. Thanks!

Hi @OndraM. Good point, thanks


[Missing] Notification exceptions

Notification exceptions is not yet supported by TDLib

Ability to get notification exceptions was added in TDLib 1.4.0. See Change Log for the full list of changes.


Documentation: README is insufficiently clear on how path expansions work on Windows

From experimentation, it seems that when this action is used for the Windows OS, a path containing a Windows environment variable (like %LocalAppData%\Programs\stack) will result in errors (e.g. in one of my projects, I get the error "could not chdir to 'C:\sr\n%LOCALAPPDATA%\Programs\stack'"), but tilde expansions (like ~\AppData\Local\Programs\stack) will work (despite the tilde not being a character that is normally expanded on Windows).
I think this is not adequately documented in the README: it is very unusual behaviour on the Windows platform, and should be documented prominently. Something along the lines of: "PLEASE NOTE: Windows environment variables (like %LocalAppData%) will NOT be expanded by this action; use ~\AppData\Local instead.").
(For that matter, the glob action is not especially well documented either. It says that "~ may expand to /Users/johndoe" [my emphasis] - what on earth is that supposed to mean? The documentation  should say precisely what the action does do, and in what circumstances, not what it may do.)

@phlummox  Would like to open a PR to add this to the docs? For the glob change, please open an issue in the toolkit repo.

Vipul: documentation is supposed to document the intended behaviour of a piece of software. As an outsider to this project, I don't know what you (or other) contributors intend the glob behaviour to be, unless you tell me. So I don't think it would be a good idea for me to open a PR to add this to the docs.
If you tell me what the intended behaviour is, then I suppose massage that into something that might be suitable to add to the docs, though.


Make the 'advanced' videoroom demo advanced

[ ] Move to a separate repo
[x] Add screen sharing support
[x] Add ability to disable cam/mic

Let me know when you have this done, I can try to setup it up - I'll clean up the instructions for it as well.  Thanks!


/var/run/docker.sock: connect: permission denied on test-godaddy-debian8-x64-4

It seems that test-godaddy-debian8-x64-4  is not configured properly to run docker. We got the following error:
12:24:40  docker run --rm -v /home/jenkins/workspace/Test_openjdk11_j9_extended.external_x86-64_linux_wycheproof/openjdkbinary/j2sdk-image:/opt/java/openjdk --rm adoptopenjdk-wycheproof-test:11-jdk-ubuntu-openj9-full
12:24:40  docker: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.38/containers/create: dial unix /var/run/docker.sock: connect: permission denied.
12:24:40  See 'docker run --help'.

https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.external_x86-64_linux_wycheproof/1/console
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.external_x86-64_linux_quarkus/21/console

Seems related to https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/721

On the machine, Ive added the jenkins user to the docker group which I thought should fix it. @jdekonin do you think this is another case where the machine needs to be disconnected from jenkins and then reconnected for this usergroup update to take effect?

Yes - jenkins agent will need to be restarted as the process will have been started without being in the docker group and it can't magically pick i up unfortunately. I'll disconnect/reconnect debian-4 now

jenkins agent now correctly running in the docker group based on checking in the script console:
Result: uid=1001(jenkins) gid=1001(jenkins) groups=1001(jenkins),998(docker)

Ive also made this change to the other 3 test-godaddy-debian8-x64 machines as I suspect they have been misconfigured the same way

Yep - am holding off til we have a verified grinder run for one of the external tests before putting more of them into the pool. Are the godaddy centos ones ok?

Ive configured docker on the test-godaddy-centos machines to the same extent as ive done the debian8 and ubuntu ones, see here,but I have not run any tests on them yet

Rerunning both failed tests, wycheproof and quarkus, I am now getting a different error for both:
15:26:52  Unable to recognize DOCKER_OS from DOCKERIMAGE_TAG = --version!
15:26:52  docker run  --rm adoptopenjdk-derby-test:11-jdk-ubuntu-openj9-full
15:26:52  Unable to find image 'adoptopenjdk-derby-test:11-jdk-ubuntu-openj9-full' locally
15:26:53  docker: Error response from daemon: pull access denied for adoptopenjdk-derby-test, repository does not exist or may require 'docker login'.
15:26:53  See 'docker run --help'.

After a bit of digging, I found this error to be similar to https://github.com/AdoptOpenJDK/openjdk-tests/issues/1768

Re https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/1368#issuecomment-639545515, your Grinder is missing DOCKERIMAGE_TAG
Running the wycheproof on test-godaddy-debian8-x64-4
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.external_x86-64_linux_wycheproof/4/

The above test build did not have docker permission denied error on test-godaddy-debian8-x64-4. It looks like test-godaddy-debian8-x64-4 is fixed.
The test build later failed at BouncyCastleTest  which is unrelated to this issue

My bad, I assumed using the Rerun in Grinder ability would duplicate the failing test.
Seeing as this BouncyCastleTest error is unrelated, I will be closing this issue


Browsing context has been discarded

I tried to run it and received:
selenium.common.exceptions.NoSuchWindowException: Message: Browsing context has been discarded
~/UdemyCourseGrabber# python3 main.py
Paste in your Udemy course URL: https://www.udemy.com/course/modern-javascript-from-novice-to-ninja/
Traceback (most recent call last):
  File "main.py", line 13, in <module>
    course_info = get_info(udemy_url)
  File "/root/UdemyCourseGrabber/functions.py", line 248, in get_info
    course_name = get_course_name(udemy_url)
  File "/root/UdemyCourseGrabber/functions.py", line 15, in get_course_name
    browser.find_element_by_css_selector(".btn-primary > span:nth-child(1)")
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 598, in find_element_by_css_selector
    return self.find_element(by=By.CSS_SELECTOR, value=css_selector)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 978, in find_element
    'value': value})['value']
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchWindowException: Message: Browsing context has been discarded

Great work, please keep it up. Thank you.

What firefox version are you using? Also, thank you for your kind words, it motivates me.

Is the problem still occurring?

Sorry for the late response. I installed a fresh Debian 10 to try again just now.
My Firefox version is firefox-esr (68.3.0esr-1~deb10u1).
I got a different error this times. 🤔
Failed to convert data to an object
~/UdemyCourseGrabber# python3 main.py
Geckodriver not detected, it will now be downloaded...
2335kb [00:01, 1245.72kb/s]
Paste in your Udemy course URL: https://www.udemy.com/course/modern-javascript-from-novice-to-ninja/

Traceback (most recent call last):
  File "main.py", line 10, in <module>
    course_name = get_course_name(udemy_url)
  File "/root/UdemyCourseGrabber/functions.py", line 30, in get_course_name
    "//h1[contains(@class,'clp-lead__title')]").text
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 394, in find_element_by_xpath
    return self.find_element(by=By.XPATH, value=xpath)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 978, in find_element
    'value': value})['value']
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: Failed to convert data to an object

Can you try changing the line
browser.find_element_by_css_selector(".btn-primary > span:nth-child(1)") in functions.py (line 28) by browser.find_element_by_xpath("//span[contains(text(),'Add to cart')]") and telling me the output?

It is better this times, it started the searching before it failed at 3/11 with an error message:
selenium.common.exceptions.NoSuchWindowException: Message: Browsing context has been discarded
# python3 main.py
Geckodriver not detected, it will now be downloaded...
2335kb [00:02, 1075.24kb/s]

Paste in your Udemy course URL, or the course name: https://www.udemy.com/course/modern-javascript-from-novice-to-ninja/

Searching for course on freecourseudemy.com:  27%|█████████████▎                                   | 3/11 [00:21<01:01,  7.73s/it]Traceback (most recent call last):
  File "main.py", line 27, in <module>
    course_info = get_sites(course_name)
  File "/root/UdemyCourseGrabber/functions.py", line 54, in get_sites
    site.get("search_element") + str(course_name) + "')]")
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 394, in find_element_by_xpath
    return self.find_element(by=By.XPATH, value=xpath)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 978, in find_element
    'value': value})['value']
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.7/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.NoSuchWindowException: Message: Browsing context has been discarded

Searching for course on freecourseudemy.com:  27%|█████████████▎                                   | 3/11 [00:24<01:04,  8.03s/it]

Sorry for the late response! I don't actually know why this is happening, but I'll rewrite the program (once again) so that it uses Scrapy. It should be working then.


Update scala-compiler, scala-library to 2.13.10 to fix CVE

Hi @rhuddleston,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
https://www.lightbend.com/contribute/cla

I already signed that agreement (twice) so not sure why it still says not complete

okay signed CLA a 3rd time and looks like we're good now


Switching over to AdminLTE v2.

Hi!
I'm using this fork in my project and everything seems fine for now. If some people can try it and see if there are bugs or regressions it would be awesome.
Thanks!

Thanks for sharing this upgrade. Nicely done.


Add pagination to sp.endpoints() call

A call to sp.endpoints() currenlty gives the last 20 endpoints. We should add limit and offset as parameters to control the behavior.

Fixed in d423475


[AutoRelease] t2-quota-2023-11-02-51065(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4659
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=3083

issue link:https://github.com/Azure/sdk-release-request/issues/4659


feat(api): add bans endpoint

Codecov Report

Merging #394 (c0ae47e) into main (0cbca6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   83.84%   83.84%
=======================================
  Files          14       14
  Lines         291      291
  Branches       61       61
=======================================
  Hits          244      244
  Misses         42       42
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cbca6b...c0ae47e. Read the comment docs.


Update observ-array dependency

The observ-array package is at release v2.0.0, and notably includes transactions, which are very helpful for batching together diffs on mercury arrays. Could this project's package.json file be updated to that version number?

This was issue should have been closed with https://github.com/Raynos/mercury/commit/6f1af5233841e64ed5aae19b544b314539f6959c yeah?

Yup, thanks.


gce-production: Upgrade worker to v4.6.3

refs https://github.com/travis-ci/worker/pull/551

Still waiting for the tag to show up on https://hub.docker.com/r/travisci/worker/tags/.

Applied to prod-1.

Applied to prod-2.

Applied to prod-3.


Added tests for openSCAP audits on salt minions

Tests:

audit salt minions with openscap (currently fails, product bug: permissions problem)
compare two audit reports
delete audit reports (currently fails, product bug)

Tested both in isolation and within whole testsuite.

@Bischoff  great! please remove my name on the commit, 🖤  and squash them


Add concat_columns function to combine woodwork objects

Adds ww.concat that follows the pandas pd.concat format to allow combining the data and typing information from multiple Woodwork dataframes and series
Contains the join and axis parameters
Closes #884

do you think it would be worth reorganizing a bit
@thehomebrewnerd yes, very happy to reorganize the utils tests so that concat_columns tests can have their own file.


Add team field to Person

Changes

Add team field to Person

Fixes #20

Codecov Report
Base: 72.15% // Head: 70.72% // Decreases project coverage by -1.43% :warning:

Coverage data is based on head (6569d31) compared to base (103c409).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     72.15%   70.72%   -1.44%
  Complexity      399      399
============================================
  Files            70       71       +1
  Lines          1232     1257      +25
  Branches        125      129       +4
============================================
  Hits            889      889
- Misses          311      336      +25
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/team/Team.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Good adherence to coding standards. Looks good to merge. Would be nice to see a delete_member command and a visual effect in the UI upon adding a member to the team.

The delete_member command will be done in a separate PR. I think I won't add a visual effect to the so early, perhaps only when the Team model is implemented properly


Fix bug when director returns 404 for PROPFIND

Found a bug when we try to PROPFIND against an outdated director, the director returns a 404 not found (because it redirects to a cache and that cache cannot find the object to PROPFIND so it returns a 404). When this happens the client returns just the error and not the response. Therefore, the fix is to check if we fail querying the director with a PROPFIND, we check if the namespace has a dirlisthost. If dirlisthost is present, we continue and otherwise, we fail. We'll need to eventually create a way to test against outdated directors but for now, we'll stick to this band-aid.

made issue #1255 so we can remember to test this. Since it is so close to release (and this is a significant bug) and because we currently don't have the framework to test against old directors, we should put this fix out in a patch release and revisit making tests for this in the near future.

Instead of blanket covering all errors, can we just target the error we know old directors to do (404?)?

Instead of blanket covering all errors, can we just target the error we know old directors to do (404?)?

Implemented just now

@turetske are you able to throw this in the patch release as well?


New project item component

Overview
This PR updates the project item component and adds a static map component for simple creation of...static maps.
Edit: this also includes a new project detail page
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Demo

Notes
We'll need to decide if the 'View' button should go to the details page or the editor.
Testing Instructions

Make sure your ingested scene projects have nice previews.
Make sure that any projects without scenes don't show a map
Try each of the dropdown options and see that they work as expected.

Closes #1444


Define conflict variable as float rather than [0,1]

Move chance and ConflictWeight scale from Default at 0 to Conflict at 1, interpolated in between.

This feature has now been added to the master branch, and documentation has been updated :).


Modbus client does not comply with the standard limit of registers for read/write requests

The Modbus specification states that the maximum number of registers returned from a Function 3 ("Read Holding Registers") or Function 4 ("Read Input Registers") is 125.
And the number of registers for a Function 16 ("Write Multiple registers") is 123.
The pysunspec2 Modbus client only supports one value for the max register count. By default it is 125. Because there is only one value, this means that there is no way for the client to reach both limits of the standard at the same time.
Could the client be modified to comply with the standard? I think either of the following would be fine:

The default max number of registers for a write is by 123 registers, and default max for a read is 125
When instantiating the client, the max count for write can be configured separately from max count for read

We will add REQ_WRITE_COUNT_MAX = 123 and adjust the write functions to use this a the default value.
I am not sure I understand the second bullet item, are you referring to a configuration point in pysunspec2?

Thanks, @bobfox. That will cover the need perfectly.


core-components: Remove CheckboxTree component (used in Table Filters)

Signed-off-by: Ainhoa Larumbe<EMAIL_ADDRESS>Hey, I just made a Pull Request!
For issue #6618
Removed the option for having CheckboxTree as a Table filter:

Deleted the CheckboxTree component and its uses in Filters
Removed the filter type 'checkbox-tree' from the TableFilter types.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@ainhoaL So! Now that the deprecation PR is merged, this one will need a rebase unfortunately :)


Make mockito to be a test-only dependency

Good catch ! :man_facepalming:

It was already a test-only dependency, because version and scope were inherited from dependency management of the parent pom: https://github.com/joel-costigliola/assertj-maven-parent-pom/blob/master/pom.xml#L70

Reverted, thanks @PascalSchumacher for pointing this out.
@testn to update the version, we need to change pom.xml in https://github.com/joel-costigliola/assertj-maven-parent-pom.

oh thanks @PascalSchumacher  I didn't look there.


[CI]Wait for operator restart after csv patch

The ansible runner image is built by the CI job and the ansibleee-operator csv is patched with the ENV variable to use the freshly built image. This triggers an operator restart which can take more than couple of seconds (we saw 30 secs in some cases). So the CI job needs to wait for the operator to restart before moving forward otherwise it is possible the resources created later will be reconciled by the old operator and therefore uses the old runner image.

looking at the result from the minimal job:
{"changed": true, "cmd": "set -euxo pipefail\n\n\noc wait -n openstack-operators --timeout=120s --for=delete $(oc get -n openstack-operators pod -l app.kubernetes.io/name=openstack-ansibleee-operator -o name)\n", "delta": "0:02:00.340729", "end": "2024-04-04 09:54:13.161935", "msg": "non-zero return code", "rc": 1, "start": "2024-04-04 09:52:12.821206", "stderr": "++ oc get -n openstack-operators pod -l app.kubernetes.io/name=openstack-ansibleee-operator -o name\n+ oc wait -n openstack-operators --timeout=120s --for=delete pod/openstack-ansibleee-operator-controller-manager-5b7cb794b4cj75d\nerror: timed out waiting for the condition on pods/openstack-ansibleee-operator-controller-manager-5b7cb794b4cj75d", "stderr_lines": ["++ oc get -n openstack-operators pod -l app.kubernetes.io/name=openstack-ansibleee-operator -o name", "+ oc wait -n openstack-operators --timeout=120s --for=delete pod/openstack-ansibleee-operator-controller-manager-5b7cb794b4cj75d", "error: timed out waiting for the condition on pods/openstack-ansibleee-operator-controller-manager-5b7cb794b4cj75d"], "stdout": "", "stdout_lines": []}

csv patched at 12:52:12.534359
ansible waits for pods/openstack-ansibleee-operator-controller-manager-5b7cb794b4cj75d
but that was started 12:54:46
that points to a issue with my oc command. If it runs first after the operator is restarted then it will wait for the wrong pod to be deleted and therefore times out.
I need to wait for a different way/.

clusterserviceversion.operators.coreos.com/openstack-ansibleee-operator.v0.0.1 patched (no change)

The code needs to be smarter as there are cases when we patch but no changes happens and therefore no Pod restart will happen.

TASK [dataplane_adoption : use ansible-runner image built from source or latest if none is defined] ***
changed: [localhost] => {"changed": true, "cmd": "set -euxo pipefail\n\n\noc login -u kubeadmin -p 123456789\n\n# openstack-operator catalog pins the sha256, which might differ from latest with time\noc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1  --type='json' -p='[{\n  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",\n  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest\"}}]'\n", "delta": "0:00:00.604663", "end": "2024-04-05 08:03:26.207032", "msg": "", "rc": 0, "start": "2024-04-05 08:03:25.602369", "stderr": "+ oc login -u kubeadmin -p 123456789\n+ oc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1 --type=json '-p=[{\n  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",\n  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest\"}}]'", "stderr_lines": ["+ oc login -u kubeadmin -p 123456789", "+ oc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1 --type=json '-p=[{", "  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",", "  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.io/openstack-k8s-operators/openstack-ansibleee-runner:latest\"}}]'"], "stdout": "WARNING: Using insecure TLS client config. Setting this option is not supported!\n\nLogin successful.\n\nYou have access to 72 projects, the list has been suppressed. You can list all projects with 'oc projects'\n\nUsing project \"openstack\".\nclusterserviceversion.operators.coreos.com/openstack-ansibleee-operator.v0.0.1 patched (no change)", "stdout_lines": ["WARNING: Using insecure TLS client config. Setting this option is not supported!", "", "Login successful.", "", "You have access to 72 projects, the list has been suppressed. You can list all projects with 'oc projects'", "", "Using project \"openstack\".", "clusterserviceversion.operators.coreos.com/openstack-ansibleee-operator.v0.0.1 patched (no change)"]}

TASK [dataplane_adoption : Wait for the ansible-operator to restart with the new ENV] ***
skipping: [localhost] => {"changed": false, "false_condition": "\"no change\" not in ansibleee_csv_patched.stdout", "skip_reason": "Conditional result was False"}

Now the task waiting for the controller-manager restart is properly skipped if the patching did not change the csv.
The other case when we need to wait is being tested in https://github.com/openstack-k8s-operators/data-plane-adoption/pull/374 that is rebased on top of this PR.

#374 shows that the new runner image is properly
TASK [dataplane_adoption : use ansible-runner image built from source or latest if none is defined] ***
changed: [localhost] => {"changed": true, "cmd": "set -euxo pipefail\n\n\noc login -u kubeadmin -p 123456789\n\n# openstack-operator catalog pins the sha256, which might differ from latest with time\noc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1  --type='json' -p='[{\n  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",\n  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.rdoproject.org/openstack-k8s-operators/openstack-ansibleee-runner:42e525ccaa56ed06f00c1ffb8cbc68a9f003bd88\"}}]'\n", "delta": "0:00:00.601583", "end": "2024-04-05 10:20:04.168190", "msg": "", "rc": 0, "start": "2024-04-05 10:20:03.566607", "stderr": "+ oc login -u kubeadmin -p 123456789\n+ oc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1 --type=json '-p=[{\n  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",\n  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.rdoproject.org/openstack-k8s-operators/openstack-ansibleee-runner:42e525ccaa56ed06f00c1ffb8cbc68a9f003bd88\"}}]'", "stderr_lines": ["+ oc login -u kubeadmin -p 123456789", "+ oc patch csv -n openstack-operators openstack-ansibleee-operator.v0.0.1 --type=json '-p=[{", "  \"op\":\"replace\", \"path\":\"/spec/install/spec/deployments/0/spec/template/spec/containers/1/env/0\",", "  \"value\": {\"name\": \"RELATED_IMAGE_ANSIBLEEE_IMAGE_URL_DEFAULT\", \"value\": \"quay.rdoproject.org/openstack-k8s-operators/openstack-ansibleee-runner:42e525ccaa56ed06f00c1ffb8cbc68a9f003bd88\"}}]'"], "stdout": "WARNING: Using insecure TLS client config. Setting this option is not supported!\n\nLogin successful.\n\nYou have access to 72 projects, the list has been suppressed. You can list all projects with 'oc projects'\n\nUsing project \"openstack\".\nclusterserviceversion.operators.coreos.com/openstack-ansibleee-operator.v0.0.1 patched", "stdout_lines": ["WARNING: Using insecure TLS client config. Setting this option is not supported!", "", "Login successful.", "", "You have access to 72 projects, the list has been suppressed. You can list all projects with 'oc projects'", "", "Using project \"openstack\".", "clusterserviceversion.operators.coreos.com/openstack-ansibleee-operator.v0.0.1 patched"]}

TASK [dataplane_adoption : Wait for the ansible-operator to restart with the new ENV] ***
changed: [localhost] => {"changed": true, "cmd": "set -euxo pipefail\n\n\noc wait -n openstack-operators --timeout=120s --for=delete pod/openstack-ansibleee-operator-controller-manager-6587547577pzw8d\n", "delta": "0:00:13.409661", "end": "2024-04-05 10:20:17.832543", "msg": "", "rc": 0, "start": "2024-04-05 10:20:04.422882", "stderr": "+ oc wait -n openstack-operators --timeout=120s --for=delete pod/openstack-ansibleee-operator-controller-manager-6587547577pzw8d", "stderr_lines": ["+ oc wait -n openstack-operators --timeout=120s --for=delete pod/openstack-ansibleee-operator-controller-manager-6587547577pzw8d"], "stdout": "pod/openstack-ansibleee-operator-controller-manager-6587547577pzw8d condition met", "stdout_lines": ["pod/openstack-ansibleee-operator-controller-manager-6587547577pzw8d condition met"]}

applied now as the new playbook is found an run.
https://logserver.rdoproject.org/74/374/7a1657d7d2784a9d24bc72ac47fb5b7458336bc4/github-check/data-plane-adoption-osp-17-to-extracted-crc/7af707b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/pre-adoption-validation-openstack-pre-adoption-openstack-2fv2j/logs/openstackansibleee.log
So I think this fix can land now


How to configure Kafka consumer when it is consuming slow messages

Question
32 * 256G * 3 nodes
8 * 64 * 12 nodes
Configuration 1 and Configuration 2 have the same total resources. Configuration 1 may get overloaded when there are more consumers, but overall resource usage is not high.
Is there a configuration that can be adjusted so that Configuration 1 can consume faster when there are more consumers?

You can try to find the performance bottleneck of the consumers by cnch_system.cnch_kafka_log. Then we can decide how to improve it.
For most cases, just add consumers and expand max_block_size always works. You can try following steps:

modify kafka_max_block_size to 655360 or 983040 to make it possible to poll a large enough block and reduce io;
add kafka_num_consumers according to your number of partitions in the topic;
if your kafka_num_consumers is larger than the number of you nodes, you'd better set kafka_cnch_schedule_mode to 'least_consumers` for load balance.

@skyoct any further question?

IO performance has an impact on data ingestion as the part will be written on local disk. You may need to check if you keep the same IO resource. In theory, with enough resources, the kafka consumption performance should be the same if you set the same consume parameters.

hi @skyoct, is there any further question for this issue?


Gateway API is the default model for service networking in KIC

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
Since gateway-api should be released in version 1.0.0 before KIC 3.0.0, it becomes the default model for service networking in KIC. Thus documentation, examples, etc. should be updated accordingly, and the overall experience (error messages, events, etc. should be smooth). I doesn't mean that Ingress becomes deprecated, it still be supported and has nice documentation.
Proposed Solution
No response
Additional information
The most related issues

#3701
#3994
#4654

Acceptance Criteria

[ ] docs are in place, default examples present usage of Gateway API
[ ] overall experience from a user perspective is smooth

close this because Ingress is provided by default, but gateway APIs are not.


[Bug]: No response when search in area is used at some places

Summary
When going to another location where no images may be available, then no response is shown when clicking SEARCH THIS AREA.

Actual behaviour
No response is shown.
Device name
SAMSUNG A14
Android version
ANDROID 14
Commons app version
Latest Updated
Device logs
When sending a request to the Wikimedia server from the map fragment, this is the response that is received:-
{     "error": {         "code": "invalid-coord",         "info": "Invalid coordinate provided",         "docref": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes."     },     "servedby": "mw2286" }
Screen-shots
https://github.com/commons-app/apps-android-commons/assets/101377978/728c4bbf-13d4-4874-bc69-69a1fc63dbc7
Would you like to work on the issue?
None

Feel free to work on this issue : )

@rohit9625 I am looking into it !

@kanahia1 I think this issue is actually a duplicate of #5461 on which @ShashwatKedia is already working. I suppose you both would need to cross-check that you're not working on the same issue.

That is a different issue. The issue I opened is happening after migration to OsmDroid in Maps of Explore Fragment.

Though that issue mentions an issue with the Nearby screen. It also mentions a problem with the "Search this area" button. So, they're certainly related 🙂

Yeah maybe related but I didn't face that issue before.

In retrospect, #5490 also seems closely related.

@sivaraam I think that #5490 and #5461 are related, as both the Nearby and the Explore fragments don't work correctly when location access is not there. But this issue seems to be when we Search at a particular location where images are not there, so I think it's a bit different.

Ah ok. On reading this comment, I was of the opinion that you were also handling the issue where the "Search this are" button doesn't work as intended.

Oh, my apologies for that. @kanahia1 seems to be working on this.

Hello @rohit9625, I tried going to same place. Here are my logs in prodDebug
2024-01-29 13:27:20.456 18801-28388 okhttp.OkHttpClient     fr.free.nrw.commons                  I  <-- 200 https://commons.wikimedia.org/w/api.php?action=query&format=json&formatversion=2&generator=geosearch&ggsnamespace=6&prop=imageinfo|coordinates&iiprop=url|extmetadata|user&&iiurlwidth=640&iiextmetadatafilter=DateTime|Categories|GPSLatitude|GPSLongitude|ImageDescription|DateTimeOriginal|Artist|LicenseShortName|LicenseUrl&ggscoord=62.36604211252142%7C111.95062541627323&ggslimit=30&ggsradius=10000 (1491ms, 22-byte body)
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W  java.lang.IndexOutOfBoundsException: Empty list doesn't contain element at index 0.
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W      at kotlin.collections.EmptyList.get(Collections.kt:36)
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W      at kotlin.collections.EmptyList.get(Collections.kt:24)
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W      at fr.free.nrw.commons.explore.map.ExploreMapController.loadAttractionsFromLocation(ExploreMapController.java:74)
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W      at fr.free.nrw.commons.explore.map.ExploreMapPresenter.lambda$loadAttractionsFromLocation$2$fr-free-nrw-commons-explore-map-ExploreMapPresenter(ExploreMapPresenter.java:156)
2024-01-29 13:27:20.465 18801-28388 System.err              fr.free.nrw.commons                  W      at fr.free.nrw.commons.explore.map.ExploreMapPresenter$$ExternalSyntheticLambda3.call(Unknown Source:8)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.internal.operators.observable.ObservableFromCallable.subscribeActual(ObservableFromCallable.java:43)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.Observable.subscribe(Observable.java:12267)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at java.util.concurrent.FutureTask.run(FutureTask.java:264)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:307)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
2024-01-29 13:27:20.466 18801-28388 System.err              fr.free.nrw.commons                  W      at java.lang.Thread.run(Thread.java:1012)
2024-01-29 13:27:20.467 18801-18801 AnimatorSet             fr.free.nrw.commons                  D  mReversing is false. Don't call initChildren.

Can you please check again :)
Error here is when there are no images at/near coordinate which is the point of https://github.com/commons-app/apps-android-commons/issues/5457

The exact logs appeared when I tried.
The issue #5457 was about about showing more descriptive response. But here no response seen at all even in the form a Toast.

However, both are related :)
Can you please guide me to the code where response is received?
@kanahia1

Let me check first.

You are right Kanhia, this is the duplicate of #5457.


Design: Create design for User Account component

Issue summary
There is currently no design for the user account component and in order for the project to have a uniform styleguide, a design has to be created for each of the components.
Proposed fix
Create a design for the user account component using the colors of the project which is already given in the README.
Tasks

[ ] Sign-in/sign-up form
[ ] User profile
[ ] Order history
[ ] Wishlist

Before working on the issue, dm me or @AdityaSingh-02 and @purnima143 to be added to the Figma file and please, strictly follow the styleguide.

I am interested to work on this issue. Please assign me this one.

Hey @shanu-user
Thanks for indicating interest on this issue. Please note that it's a design issue and to work on it, you would need to be a designer and good at design.
If that fits you, please join the Pluto UI channel on discord by going to #self-role and selecting Pluto UI from the list of projects there. After you join, tag me @Lovelyfin00 in the chat

Hi , I am contributor under GSSOC'23 and I am eager to showcase my skills and make a meaningful contribution to this project.
Kindly assign me this issue. @Lovelyfin00

@tripathishipra This issue is regarding design and if you are good at designing go ahead and work on it


[eas-cli] truncates long messages for eas update command

Checklist

[x] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
Closes 5234
How
Added a short truncate function and ran the user input through it.
Test Plan
Added some automated tests to check:

truncates long messages
does not truncate short messages
warns the user that truncation has occurred

Truncation flow
https://user-images.githubusercontent.com/15132641/175425347-d8f401d6-b54b-4349-afcf-c4f914ae742c.mov
Non-truncatiow flow
https://user-images.githubusercontent.com/15132641/175425365-47f88cb3-d295-4349-97c4-536363b9b258.mov

/changelog-entry new-feature Truncate long messages for eas update command, rather than failing


Firefox 42 / Electrolysis / links broken

In newer firefox versions with electrolysis activated the following of links is broken. (No link hint numbers are displayed)

this is a duplicate of existing bug

@mmehnert, please close this if it is a dupe.

I guess I'll close it then. :-) #99 looks as if the topic is covered.


feat: Broadcast min_commit_ts for pipelined transactions

Ref: https://github.com/tikv/tikv/issues/17459
Prerequires https://github.com/pingcap/kvproto/pull/1265
Changes

Periodic updates of min_commit_ts
Broadcast min_commit_ts
Periodic updates of full store list

BTW, this is not related to this PR, can you change the RLock/RUnlock to Lock/Unlock here?

Done.

I have a question about the future plan, have you considered apply this broadcast also for slow or large 2pc transactions?

It's possible. But I think we need more empirical data before implementing that. It's unclear now how this optimization would benefit normal large transactions.


Applicant - Better descriptions for "Remote Work" and "Telework"

Description
The terms "remote work" and "telework" are not broadly understood. We need to convey the meaning of these better without cluttering up our interface.
-Telework means that you work from home some days and in the office on others.
-Remote work means that you don't need to live or work in the same city as the rest of the team... essentially you could work from anywhere (maybe even outside Canada... though not necessarily)
Required for Completion
Add/remove others as necessary for this specific task.

[ ] Run Lighthouse (Chrome Dev Tools)
[ ] Browser Compatibility Check
[ ] Update Translation
[ ] Does this affect configuration? (If so discuss with team)
[ ] Create pull request to dev
[ ] Address issues found during peer review
[ ] Have someone else accept pull request into dev

@Jerryescandon suggested we might be able to collapse the two checkboxes (for "remote work" and "telework") since it seems likely that if remote work is allowed, telework will always be allowed. This could clean up the interface a little.
@laurenoncoffee what do you think of this idea?
@JasmitaChawla Could you please ask a couple questions about this when doing your user testing?

low priority - but product shop wants in. can we move this to 2 weeks from now?

Jasmita had some suggestions: in issue #552


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.14.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rename BUILD_PAHO_TRANSPORT cmake option to TRANSPORT_PAHO.

Follow up on https://github.com/Azure/azure-sdk-for-c/pull/732 for consistency of option names used for the transport policy.

Would curl be changed too?