We need a logo!

People! We need a logo 😃
Let out your artistic side and create away! Send your suggestions here!!! 🥳

e.g. add your suggestions  like this

And we can show whether we like it by using emojis. No need to comment that I like this or that, it will add clutter.

Hi, I have an idea, maybe we can do is twitter bird taking a thread in her beak or something like that. I am not good at logo designing, maybe anyone here, if like this idea, can design it.

Minor changes. Arrow is a bit lower than before.

Twindle is Here

Still WIP

Still WIP

can you put that bird, as dot of i

This logo is for dark backgrounds.

(For lighter backgrounds)
We can have twindle text beneath with some brandguidelines if provided.
I have used #14AFBC as primary color

(For lighter backgrounds)
We can have twindle text beneath with some brandguidelines if provided.
I have used #14AFBC as primary color

Good one! But maybe will be better if you remove the first line. Can you try?

(For lighter backgrounds)
We can have twindle text beneath with some brandguidelines if provided.
I have used #14AFBC as primary color

Good one! But maybe will be better if you remove the first line. Can you try?

Sure !!! will send an updated version with first line removed in some time:)

@RafaelBatman55 updated 😄. Looks better now though

changed bird to ball of yarn. any other thing can be placed in the centre as well (like book)

Is the logo finalized? Is there chance for change?

no not yet

Here's one from me. Inspired from Microsoft's FLuent Design(a bit)

Here's one from me

Good work

@PuruVJ good work. Your logo working great

This logo is for dark backgrounds.

@tusharkashyap63 Please add your twitter handle

This logo is for dark backgrounds.

@tusharkashyap63 Please add your twitter handle

https://twitter.com/tusharkashyap63?s=09

@PuruVJ @EYRAM565 @sammjainn @niveth09 @aesthytik @kambleaa007 @MumbiGachomba04 @QuiiBz @cankocman @MrVoicer
Everyone please add your twitter handle below your logo.

@Nivetharathnav2

Nivetharathnav2

add it as a link pls

The idea is that tweet bird delivered file through cloud. The logo is just different shapes together. Can suffice plenty of color combinations and as it is small, can be accommodated in any area on a web page, printed document.
https://twitter.com/JoelVinayKumar

Logo with different type style

https://twitter.com/Pranavgoel_29

by:@tr0mbley_

Have a look at my design.

Have a look at my design.

well.. this will be mine :)

@proful my twitter is @TheRam05

I'm probably spamming with so many logos, but here's another iteration 😁

Another one from me @iamtolopade

Another one from me @iamtolopade

A warmer logo from me @iamtolopade

A logo from me @MontygSharma

Logo from me https://twitter.com/johnjacobkenny @johnjacobkenny
Lol not so much a logo. Probably an illustration for the website

A logo from me! @Sheetal777

A logo from me! @Sheetal777
https://twitter.com/_sheetal_p

Logo #2 from @Sheetal777
https://twitter.com/_sheetal_p

TWINDLE logo. My entry

https://twitter.com/Nivetharathnav2

good one nivetha. unique and creative 👌🏻

https://twitter.com/Nivetharathnav2

good one nivetha. unique and creative 👌🏻

Thanks a lot @aesthytik 😄

Thus can't be any better 😍

Thus can't be any better 😍

Thanks @JoelVinayKumar

Any logo with out bird symbol.
No need to inspire by Twitter.
I want the logo to based on beginner, team, collaboration, learning theme.
No text. Minimal shapes.

Find me Sheetal

Logo #4 by Sheetal

Logo #4 by Sheetal

Logo #4 by Sheetal

Hello team, so did we finally select a logo for twindle out of these samples?

Not yet

This hasn't had any activity since a month and half. Closing it now.
If anybody wants to submit new logo, we can always reopen this issue.


Notification message for the logging configurations contains the copyright header and in html format

Environment
IS 5.4.0 standalone pack
JDK - 1.8
DB - Postgres 9.6.3
OS - ubuntu 15.10
Browser - Chrome - Version 58.0.3029.96
Steps to recreate the issue

Go to Configure ->Logging
Change the Glogbal log4j properties to 'WARN' and update

Observations
Successful notification message contains the copyright header and appearing in html format

Successfully updated Global Log4j Configuration

OK

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


Add new Gabonese Republic phone number format

resolves https://github.com/floere/phony/issues/461

Coverage decreased (-0.2%) to 98.416% when pulling 9c7ae979390992995c6bd1fa97718aab3e743917 on Startouf:patch-1 into e8f6924c9be6d3e5904b927f9900048c9a9e3ed0 on floere:master.

@floere coverage seems to have decreased, but this does not seem to be linked to my PR does it ?

Hi @Startouf!
Thanks very much for this PR! 🎉 Unfortunately, and this is my bad, the process did not catch two errors, which you can see here: https://travis-ci.org/github/floere/phony/jobs/713237721 That is now fixed locally.
I then tried to fix the specs – but the issue is that with the definitions fixed(1) … and fixed(2) … the first will always match.
Looking at https://en.wikipedia.org/wiki/Telephone_numbers_in_Gabon, I am unsure what the rules should be – can you point me in the right direction? 😊 Thanks!


Fixed tailscale status returning exit code 1 when not logged in

Fixes https://github.com/artis3n/ansible-role-tailscale/issues/138

Set a TAILSCALE_CI_KEY in your forked repo's secrets with a Tailscale ephemeral auth key (https://github.com/artis3n/ansible-role-tailscale#development-and-contributing) or let me know if you'd rather I create a branch off of your PR to have CI run on this, which would preserve your contribution.

Gimme a min. Let me check

Also, if you can update this as well: https://github.com/artis3n/ansible-role-tailscale/blob/acf9e84c446ec62330ddedc09e6813ea3c5f4ea6/molecule/skip-authentication/verify.yml#L11

Done ! Pls check again.

Not sure why these are failing, I assume the secret isn't set up correctly. But encountered a hiccup with Debian 11 so I'm working on https://github.com/artis3n/ansible-role-tailscale/issues/140 before validating and merging this.

Also, I observed something odd. If incase user puts a wrong auth key, then tailscale up -authkey takes a long time. Could you add a timeout ?

Also, I observed something odd. If incase user puts a wrong auth key, then tailscale up -authkey takes a long time before failing. Could you add a timeout ?

I'm relying on the native timeout in that command but you're right, the command ends very quickly if successful. I'll add a shorter timeout in the future - can you add an issue for this?

Pull in the latest changes from the main branch and then we can get this CI passing.

Done ! Merged upstream

Sure ! @artis3n

Thanks! I should have done that validation at the start.


vscode ignoring http_proxy/https_proxy environment variables after 1.9.0 release.

VSCode Version: 1.9.x
OS Version: macos 10.12.3

Steps to Reproduce:

export http_proxy/https_proxy environment variable.
run check for updates or install any extension.

Can you help us in #18103 ?


version: 0.7.0

Description
update the version
Type of change
Please delete options that are not relevant.
just version
How has this been tested
N/S
Checklist:

[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Let's make the world better✨😋🐍🌎

Codecov Report

Merging #27 (f922884) into main (ad24e20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   93.98%   93.98%
=======================================
  Files          21       21
  Lines         582      582
  Branches       34       34
=======================================
  Hits          547      547
  Misses         23       23
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad24e20...f922884. Read the comment docs.


Perform cruft update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.36%. Comparing base (f929f00) to head (04c35f7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   97.36%   97.36%
=======================================
  Files           9        9
  Lines         947      947
=======================================
  Hits          922      922
  Misses         25       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixes

Coverage increased (+1.8%) to 97.815% when pulling 7981a64aa5e18620b60b8061868509902a9b1fe4 on fixes into 8e0a4fc0a3a1135080f549f67cc85734c911043b on master.


Fix link to rules page.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Transfer legs

Insert TRANSFER legs, analogous to current ACCESS/EGRESS legs, between any two pt legs directly following one another where the second one starts elsewhere than where the first one ends.
Implement by just routing on the fly -- I currently strongly suspect that this doesn't matter that much, performance-wise, so for now, I'm not pre-computing them and saving them somewhere.
(Simple CH routing is so inexpensive that for short routes it can basically be considered a look-up -- if I'm wrong let's improve later).
On my way, I changed the logic for the access/egress legs a bit -- I think equivalently -- so that we don't expect walk legs returned by GH specifically and only at the first and last position. In this PR, we now convert any walk leg that we may get, and only mark them as ACCESS/EGRESS on first/last position. This is to prepare for GH eventually returning specific transfer legs directly.
I tried to set up my testing infrastructure but ran into an issue -- I think our deserializer refuses to deserialize our current modified response schema (or something), so I left the test commented out -- still putting it in so I can use it locally to trigger things. ,-)

In the process I removed the bit where we were removing edge ids of the last leg from the first leg, because I think we found the root cause of this in the meantime (?) and I wasn't sure how to translate this to the there-can-be-more-than-two-walk-legs situation.... Please verify.

@mark-idleman how much work would this be to update and include in the mew protos? It would simplify the client side a lot!

@mark-idleman how much work would this be to update and include in the mew protos? It would simplify the client side a lot!

Errrr....this is a bit of a can of worms. There will need to be a decent amount of testing with this big of a change, and we'd need to change the GRPC code to include this new logic as well.
I'd strongly prefer getting in the big GRPC java PR and the first proto PR before digging into this. We're getting to the point where we need to start merging stuff so that I can add in these features in a clean way, continuing to pile on to the mega-grpc PR probably isn't a good call anymore haha.

Following up on my last reply, I started to look over this more today and would be happy to get it updated based on recent changes/tested/merged as my next task; I'd still probably like it if we could get the big GRPC PR merged first though, just to make merging this change easier. I can get started by cleaning up/testing the HTTP version that's implemented here, though (the updates to the GRPC codebase should basically be analogous)

@michaz , I did some clean-up and testing here, and overall I think the transfer leg logic is working well! The only issue I've noticed is that we're once again seeing the issue where the last foot leg (EGRESS) always contains all of the stable IDs from the first foot leg (ACCESS) - you mentioned that this might have been fixed so you removed the logic that we had before for deduping this, but it looks like it will need to be added back, which I'll do now.


have you implemented KMN?

If you have done, you can provide the KMN code. I remember there were the KMN results in your "README", but now it disappear.

No. I didn't do that.


Rounding errors

Resolved in 802540d456524eec42453b3726a34643de36d825

https://etherscan.io/tx/0x7c463e5941aab748e9b998a836eb49bf5c341bcf8b7e8d4e7b2139334d411394
This shows only because Barbossa is recipient of both transfers. If it would be other token, supporter would not be shown.
I suggest removing last digit from what user put into input before splitting it to 90 and 10%. x / 10 * 10 should do it.


Add factor to date booster

@SferaDev after this is merged, could you also cut a release so that we can pass the fix to Raae?


[Question] Setting the updater of PS in backend (c++)

I'm wondering if it is possible to set the updater in parameter server using KVStoreDistServer.set_updater directly in the backend (c++), and currently this seems to be called from the C API from Python calls that I do not quite understand.
I'm wondering whether I can achieve the same thing by calling into that method directly? If so, what updater should be used and how?
Many thanks!

You can call it from C++. If you do that you need to set it to a functor with necessary states for the update. The prototype is here https://github.com/dmlc/mxnet/blob/master/python/mxnet/kvstore.py#L39

Thanks! I was looking at the same code, but I don't understand where is the implementation of updater itself. It seems the wrapper wraps the call. What is the actual implementation of updater? Thanks for the patience 😊

https://github.com/dmlc/mxnet/blob/master/python/mxnet/optimizer.py#L800

Thanks! Do I need to reimplement those in c++, or do I need to call that from c++? Sorry I still don't get it 😔

You need to implement the update and optimizer in c++. Shouldn't be too hard, you can see MXNet.cpp for example. ccoptimizer is removed though, you need to use the new operators instead.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


Disable DNS Caching

I've configured PiHole to send queries to this image. PiHole already handles DNS caching, so it would be nice if there was an option to disable caching inside of this image so that PiHole can handle all of that for us. That way, we're not double-caching results.
I did some light research to find the necessary Unbound config that would be needed to accomplish this, but the best solution I came across was to simply set the TTL to something very low with the cache-min-ttl option, which should produce the desired outcome.

Good idea, I'll add the option through an environment variable. I'm however quite busy until the weekend so it will take me a few days to add the feature. Thanks!

Great! Happy to hear you like the idea

Do you think setting msg-cache-size: 0 could solve it? (Link) Or maybe  key-cache-size: 0?
It also looks that setting forward-no-cache: yes would solve it in our case.

Good find. I think the forward-no-cache option is what we're looking for.


forced to purge heroku repo cache on every build

I'm currenting seeing the following error whenever we deploy. It goes away whenever we clear the cache via heroku repo:purge_cache or if i set REBUILD_ALL=true on the target heroku app. Anyone else seeing this or have any suggestions?
Warning: Permanently added 'heroku.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
Counting objects: 59, done.
Delta compression using up to 32 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (34/34), 3.97 KiB | 0 bytes/s, done.
Total 34 (delta 25), reused 30 (delta 21)
remote: Compressing source files... done.

remote: Building source:

remote:
remote: -----> Fetching custom git buildpack... done

remote: -----> Ember CLI app detected

remote: -----> Exporting config vars to environment

remote: -----> Building environment: production

remote:
remote:        PRO TIP: Avoid using semver ranges starting with '>' in engines.node

remote:        See https://devcenter.heroku.com/articles/nodejs-support

remote:
remote: -----> Requested node range:  >= 0.10.0

remote: -----> Resolved node version: 4.1.1

remote: -----> Downloading and installing node

remote: -----> Using default npm version: 2.14.4

remote: -----> Downloading and installing nginx

remote: -----> Adding boot script

remote: -----> Copying configs

remote: -----> Restoring node_modules directory from cache

remote: -----> Restoring bower_components directory from cache

remote: -----> Bower already exists

remote: -----> Pruning cached dependencies not specified in package.json

remote:        unbuild<EMAIL_ADDRESS>
remote: -----> Pruning cached bower dependencies not specified in bower.json

remote:        /tmp/buildpack_86bd6f54dd88c3649d3e56892beab499/bin/compile: line 186: bower: command not found

remote:
remote:  !     Push rejected, failed to compile Ember CLI app

remote:
remote: Verifying deploy....

remote:
remote: !	Push rejected to lift-admin.

remote:
To git@heroku.com:lift-admin.git
! [remote rejected] 113997a5e27f4a58e72883d86d667575cda6ccbf -> master (pre-receive hook declined)
error: failed to push some refs to 'git@heroku.com:lift-admin.git'

Have you followed the steps atop the README.md?
You can also...
$ heroku plugins:install https://github.com/heroku/heroku-repo.git
$ heroku repo:purge_cache -a APPNAME

yeah, heroku repo:purge_cache -a APPNAME clears up the problem for 1 deployment. On the following deploy the problem returns.

Weird. Could you post your bower.json and package.json files? I could be more helpful then :)

sure
package.json
{
  "name": "lift-admin",
  "version": "0.0.0",
  "description": "Small description for lift-admin goes here",
  "private": true,
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "scripts": {
    "start": "ember server",
    "build": "ember build",
    "test": "ember test"
  },
  "repository": "",
  "engines": {
    "node": ">= 0.10.0"
  },
  "author": "",
  "license": "MIT",
  "devDependencies": {
    "broccoli-asset-rev": "^2.0.2",
    "ember-cli": "0.2.5",
    "ember-cli-app-version": "0.3.3",
    "ember-cli-babel": "^5.0.0",
    "ember-cli-content-security-policy": "0.4.0",
    "ember-cli-dependency-checker": "^1.0.0",
    "ember-cli-fastclick": "^1.0.3",
    "ember-cli-font-awesome": "0.0.9",
    "ember-cli-htmlbars": "0.7.6",
    "ember-cli-ic-ajax": "0.1.1",
    "ember-cli-inject-live-reload": "^1.3.0",
    "ember-cli-less": "^1.3.0",
    "ember-cli-numeral": "^0.1.2",
    "ember-cli-qunit": "0.3.13",
    "ember-cli-simple-auth": "0.8.0",
    "ember-cli-simple-auth-devise": "0.8.0",
    "ember-cli-simple-auth-torii": "0.8.0",
    "ember-cli-uglify": "^1.0.1",
    "ember-cpm": "^1.3.2",
    "ember-data": "^1.0.0-beta.17",
    "ember-disable-proxy-controllers": "^0.7.0",
    "ember-export-application-global": "^1.0.2",
    "ember-idx-forms": "liftforward/ember-forms#allow-field-disabling",
    "ember-moment": "1.1.1",
    "ember-reset-scroll": "0.1.1",
    "ember-validations": "2.0.0-alpha.3",
    "express": "^4.8.5",
    "glob": "^4.5.3",
    "http-proxy": "^1.11.1",
    "morgan": "^1.5.3",
    "rimraf": "2.2.8",
    "torii": "0.5.1"
  }
}

bower.json
{
  "name": "lift-admin",
  "dependencies": {
    "bootstrap": "~3.2.0",
    "ember": "1.12.0",
    "ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
    "ember-cli-moment-shim": "~0.0.3",
    "ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
    "ember-data": "1.0.0-beta.17",
    "ember-load-initializers": "ember-cli/ember-load-initializers#0.1.4",
    "ember-qunit": "0.3.3",
    "ember-qunit-notifications": "0.0.7",
    "ember-resolver": "~0.1.15",
    "jquery": "^1.11.1",
    "loader.js": "ember-cli/loader.js#3.2.0",
    "qunit": "~1.17.1",
    "fastclick": "~1.0.6",
    "numeral": "~1.5.3",
    "ember-simple-auth": "0.8.0",
    "lodash": "^2.4.0"
  }
}

Have you tried to update your version on Ember CLI? This is pretty old now...
"ember-cli": "0.2.5"

I think that would fix the issue. It seems like bower isn't included in that build of the Ember CLI itself

LOL old indeed. I'll give that a shot.

I had posted comments in the community of the issue and REBUILD_ALL=true had fixed it for us.
I tried removing the variable to see the performance improvements. The build failed again. I followed the steps added to readme to purge app cache and doing another build with rebuild_all=true. The build was successful.
However, I removed the param from my env vars and it fails again.
My logs look like as follows...
-----> Fetching custom git buildpack... done
-----> Ember CLI app detected
-----> Exporting config vars to environment
-----> Building environment: production
       PRO TIP: Avoid using semver ranges starting with '>' in engines.node
       See https://devcenter.heroku.com/articles/nodejs-support
-----> Requested node range:  >= 0.10.0
-----> Resolved node version: 4.1.1
-----> Downloading and installing node
-----> Using default npm version: 2.14.4
-----> Downloading and installing nginx
-----> Adding boot script
-----> Copying configs
-----> Custom nginx config found
-----> Restoring node_modules directory from cache
-----> Restoring bower_components directory from cache
-----> Bower already exists
-----> Pruning cached dependencies not specified in package.json
       unbuild<EMAIL_ADDRESS>-----> Pruning cached bower dependencies not specified in bower.json
       /tmp/buildpack_e91ba4580419252d15215fc3b80f169f/bin/compile: line 186: bower: command not found
 !     Push rejected, failed to compile Ember CLI app

The error is pointing to bower being unavailable but the same was checked two steps before the error step - 'Bower already exists'.

I'm also getting
remote:        /tmp/buildpack_2f164fb4b7c8e7f5c012a8b90424096e/bin/compile: line 186: bower: command not found```

if i dont use REBUILD_ALL. I'm on `"ember-cli": "1.13.8"`

For now, I've tagged pre-performance release as 0.9.0 and post-performance as 1.0.0. You can point your build pack URL at those

Experiencing similar issues as above:
-----> Fetching custom git buildpack... done
-----> Ember CLI app detected
-----> Exporting config vars to environment
-----> Building environment: production
       PRO TIP: Avoid using semver ranges starting with '>' in engines.node
       See https://devcenter.heroku.com/articles/nodejs-support
-----> Requested node range:  >= 0.10.0
-----> Resolved node version: 4.1.1
-----> Downloading and installing node
-----> Using default npm version: 2.14.4
-----> Downloading and installing nginx
-----> Adding boot script
-----> Copying configs
-----> Restoring node_modules directory from cache
-----> Restoring bower_components directory from cache
-----> Bower already exists
-----> Pruning cached dependencies not specified in package.json
       unbuild<EMAIL_ADDRESS>-----> Pruning cached bower dependencies not specified in bower.json
       /tmp/buildpack_fb50e17f6279ec7203a7c0a0df6a83e5/bin/compile: line 186: bower: command not found
 !     Push rejected, failed to compile Ember CLI app

Ran heroku repo:purge_cache and it built successfully after re-deploy.

I am not clear on what the actual problem or fix is. Deploying is VERY painful and slow. Running on 0.9.0 or 1.0.0 ends with errors until I purge cache. What is the suggested happy path here?

We are experiencing the same issue, we can deploy only after purging the cache.

I having this same issue on a recent Ember project, so I'm using the latest ember-cli and most other components should be of latest version as well.

same here can't deploy unless I purge + rebuild all.
I've tried to use buildpack version 0.9.0 but without success...

Can you try to...
$ heroku plugins:install https://github.com/heroku/heroku-repo.git
$ heroku repo:purge_cache -a APPNAME

And then get on the latest?

I meant I've tried on latest it only works with purging + rebuild all.
I gave a try on 0.9.0 but didn't build correctly.
Sorry for being unclear in my last comment.

I'm going to try to recreate this tonight and fix it. Sorry about the mess! :)

I just noticed that my packages.json didn't actually have bower specified, so the purge action in the buildpack seems to have removed bower on each push to heroku.
I've added "bower": "1.5.3" and it seems to do the trick for me.

Adding bower to the package.json seems to have fixed the issue for me also

Hmm interesting. I'll take a look at ensuring that bower is installed.

Bower now gets locked to 1.5.3 in the install. Should fix this.

See: #110

@tonycoco do we need to have bower in package.json ?
Because I just encountered this error by removing REBUILD_ALL
Delta compression using up to 8 threads.
Compressing objects: 100% (57/57), done.
Writing objects: 100% (65/65), 7.94 KiB | 0 bytes/s, done.
Total 65 (delta 42), reused 0 (delta 0)
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> Fetching custom git buildpack... done
remote: -----> Ember CLI app detected
remote: -----> Exporting config vars to environment
remote: -----> Building environment: production
remote:
remote:        PRO TIP: Avoid using semver ranges starting with '>' in engines.node
remote:        See https://devcenter.heroku.com/articles/nodejs-support
remote:
remote: -----> Requested node range:  >= 0.10.0
remote: -----> Resolved node version: 4.2.1
remote: -----> Downloading and installing node
remote: -----> Using default npm version: 2.14.7
remote: -----> Downloading and installing nginx
remote: -----> Adding boot script
remote: -----> Copying configs
remote: -----> Restoring node_modules directory from cache
remote: -----> Restoring bower_components directory from cache
remote: -----> Bower already exists
remote: -----> Pruning cached dependencies not specified in package.json
remote:        unbuild<EMAIL_ADDRESS>remote: -----> Pruning cached bower dependencies not specified in bower.json
remote:        /tmp/buildpack_31d6231289be5ed18ecfeac448341d99/bin/compile: line 186: bower: command not found
remote:
remote:  !     Push rejected, failed to compile Ember CLI app
remote:
remote: Verifying deploy...


#458 - allow user to set formenctype

Closes #458

@lovasoa will do. Still testing it. I had some trouble with applying it to the textarea input directly. Seems adding it to the submit button works.
I want to make sure this works with also a file input present as they would both trigger adding the attribute to the submit button...

Okay, good! Switching this pr to draft mode, then.
Feel free to switch it back whenever you want.

@lovasoa after reading the following:

https://www.w3schools.com/tags/att_input_formenctype.asp
https://www.w3schools.com/tags/att_form_enctype.asp

I decided to expose the enctype as top-level attribute as formenctype is intended for submit and image type inputs only.
Further, I would suggest we remove the formenctype being added automatically when file type input is present. Even though it's nice for newbies, there are the following short-comings:

it overrides the form enctype  - could be confusing when dev explicitly sets this
it won't be automatically applied to other submit buttons (if any)

For now I updated the docs recommending to set it explicitly for file upload rather than rely on current behaviour. Then we can decide whether to alter existing behaviour independently of this PR

I understand what you mean. But the whole promise of SQLPage is to make it easy to build UIs on top of databases without any other knowledge than just sql. I really think file upload should work by default, and not require even knowing what formenctype means.

For reference - here is proposed changes that I think will make the handling of form encoding to work intuitively whilst still allowing flexability for developer to set specific encoding
https://github.com/djyotta/SQLpage/pull/1

No problem. Thanks for SQLpage making UI easy.
Sorry I couldn't catch the vision on this one. It's hard to see the forrest through the trees sometimes.


Hessian with parameters

Hello,
thank you for this fantastic product. The more I am using it, the more I'm enjoying it. But I'm new and not aware of all the intricacies. So I am bumped again. I have two questions:
a) is there an API documentation somewhere? I am unable to find it.
b) I am trying scipy.optimize with hessian and the following is a mock-example that demonstrates my error. Essentially I have a cost-function that takes in multiple parameters:
import autograd.numpy as np
from autograd import grad
from autograd import hessian_vector_product
from scipy.optimize import minimize

def myfun(x, ttype, const):
    if ttype=='square':
        f = np.square
    if ttype=='sqrt':
        f = np.sqrt
    return f(np.linalg.norm(x)*const)

if __name__ == '__main__':
    ttype = 'square'
    const = 100.

    costfun = myfun
    costgrd = grad(myfun, argnum=0)
    costhes = hessian_vector_product(myfun, argnum=0)

    x0 = np.random.rand(1, 5)
    res = minimize(costfun, x0, args=(ttype, const),
                                    jac=costgrd, hessp=costhes,
                                    method='Newton-CG')

    print ('Optimisation res:\n', res)

I am getting the following error:

Traceback (most recent call last):
File "mytest.py", line 31, in
method='Newton-CG')
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/scipy/optimize/_minimize.py", line 484, in minimize
**options)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/scipy/optimize/optimize.py", line 1571, in _minimize_newtoncg
Ap = fhess_p(xk, psupi, *args)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/wrap_util.py", line 20, in nary_f
return unary_operator(unary_f, x, *nary_op_args, **nary_op_kwargs)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/differential_operators.py", line 24, in grad
vjp, ans = _make_vjp(fun, x)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/core.py", line 10, in make_vjp
end_value, end_node =  trace(start_node, fun, x)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/tracer.py", line 10, in trace
end_box = fun(start_box)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/wrap_util.py", line 15, in unary_f
return fun(*subargs, **kwargs)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/differential_operators.py", line 88, in vector_dot_grad
return np.tensordot(fun_grad(*args, **kwargs), vector, np.ndim(vector))
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/wrap_util.py", line 20, in nary_f
return unary_operator(unary_f, x, *nary_op_args, **nary_op_kwargs)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/differential_operators.py", line 24, in grad
vjp, ans = _make_vjp(fun, x)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/core.py", line 10, in make_vjp
end_value, end_node =  trace(start_node, fun, x)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/tracer.py", line 10, in trace
end_box = fun(start_box)
File "Softwares/anaconda2/envs/geomni35/lib/python3.5/site-packages/autograd/wrap_util.py", line 15, in unary_f
return fun(*subargs, **kwargs)
File "mytest.py", line 13, in myfun
return f(np.linalg.norm(x)*const)
UnboundLocalError: local variable 'f' referenced before assignment

I am using Python 3.5.
If I debug, I am able to see that the error occurs when myfun is called with wrong parameters.
Normally, I see that x is a np.array (or ArrayBox), ttype is a string and const my float constant. But at crash time, x is an ArrayBox (x._value doesn't show values but only that _value itself is also an ArrayBox), while ttype now contains the x-values and therefore none of the if-conditions are satisfied and const now contains the string 'square'.
I believe this is happening when the hessian call occurs.
What am I doing wrong?
Many thanks

A few things.
First off - when you define a function and then pass it too grad, any explicit input is treated as a variable to differentative (so in your case the inputs ttype and const).  Define those elswhere than the definition of myfun instead of having them be explicit inputs.
For example, below is a simplified version of your myfun without these inputs, and where I have used ttype = square.
def myfun(x):
    return np.linalg.norm(x)*const**2

The second thing: before trying an outside optimizer try one of the standard ones in the autograd library itself located at https://github.com/HIPS/autograd/blob/master/autograd/misc/optimizers.py  This will help make sure there's no problem with your code prior to trying i
For example, you can run a simple gradient descent procedure like below - which works fine on my machine.
# define derivatives and constant
costgrd = grad(myfun)
costhes = hessian_vector_product(myfun)
const = 100.

# run simple gradient descent loop
x = np.random.rand(1, 5)
alpha = 0.1
for i in range(100):
    x = x - alpha*df(x)

Having done this I can have some confience that my code thus far works.   If you want to use Newton's method that works natively with autograd you can see an example here.
I then tried the minimizer built into scipy you are aiming to use and got the following result.
x0 = np.random.rand(1, 5)
res = minimize(myfun, x0,jac=costgrd, hessp=costhes,method='Newton-CG')
print (res)

   fun: 13134.655238629284
     jac: array([ 6351.22086682,  2659.17594877,  1789.08089158,  2489.15536201,
        6572.21971038])
 message: 'Warning: Desired error not necessarily achieved due to precision loss.'
    nfev: 24
    nhev: 1
     nit: 0
    njev: 12
  status: 2
 success: False
       x: array([ 0.83421096,  0.34927359,  0.23498961,  0.32694198,  0.8632384 ])


Use decompress.lzo instead of the current implementation

decompress.lzo was specially made for miragevpn and support the compression as well. We probably should use it. To be sure about our implementation we can implement a fuzzer on decompress and see if everything is good.

[ ] implement a fuzzer for decompress.lzo
[ ] incorporate decompress.lzo into miragevpn

thanks, done and merged in #71


PR shows unrelated commits after merge

Gitea version (or commit ref): 1.2.3
Git version: 2.1.4
Operating system: Debian 8
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
After I merged Pull Requests, the PR page sometimes shows commits which are completely unrelated to what the PR has been about. It seems to include commits which happened between creating the branch/PR and the actual merge.
As an example, please see PR 29 on my installation by the user fbn_bmns which consisted of exactly one commit. After merging it, it shows 22 commits in total!
Why is this happening? Is this a Gitea bug? It would be good to have this fixed as it disables us having a decent overview about what happened in a PR after it has been merged...

I believe this is duplicate of #2797 and is already fixed in master and will be fixed also in 1.3.0-rc2 release

You are right, this looks like my problem. Please excuse the duplicate, I didn't find this via the search.


:UpdateRemotePlugins crashes Neovim

I followed all the steps of installation and when executing :UpdateRemotePlugins it crashed Neovim. I have Quicklisp installed to a non-standard location, ~/.local/share/quicklisp/setup.lisp, so I set let g:lisp_host_quicklisp_setup = '~/.local/share/quicklisp/setup.lisp' in my init.vim right before Plug 'adolenc/cl-neovim'.
The first time I had tried it :UpdateRemotePlugins failed (as expected) because I hadn't set g:lisp_host_quicklisp_setup, so the error has to be somewhere after reading the setup.lisp file.
The crash displays:
Assertion failed: (!stream->closed), function wstream_write, file /tmp/neovim-20160912-2107-m91gva/src/nvim/event/wstream.c, line 74.
Abort trap: 6

Before the crash Neovim would appear to be hanging for a while, displaying only
remote/host: python3 host registered plugins ['deoplete', 'chromatica']

Executing Lisp expressions like :Lisp (print (+ 2 3)) seems to work, so I don't know if something is missing. Running :LispHostRunTests doesn't print anything when it's done, so no idea what's going on there, it just opens a new (empty) file called test.lisp_host_testa. Here is my rplugin.vim file (after removing the testing part): http://pastebin.com/NUF8SZUt

Here is also the result of running :CheckHealth lisp:

health#lisp#check
================================================================================
## Lisp provider
  - INFO: Using default bindings ("sbcl") for g:lisp_host_prog.
  - INFO: Found SBCL version `SBCL 1.3.9' at `/usr/local/bin/sbcl'.
  - INFO: g:lisp_host_quicklisp_setup is bound to `~/.local/share/quicklisp/setup.lisp'.
  - INFO: Loading Quicklisp from `/Users/hiphish/.local/share/quicklisp/setup.lisp'.
  - INFO: Quicklisp is installed and gets properly loaded.
  - INFO: cl-neovim can be quickloaded.
  - SUCCESS: Lisp host should be working correctly!

Hey, thanks for the detailed report!
So running :UpdateRemotePlugins definitely shouldn't crash your Neovim, but from everything else you posted it seems like the host should be functioning correctly (according to rplugin.vim it correctly reports the remote plugin specifications and running :Lisp confirms that it properly invokes the host).
I'm sorry for temporary inconvenience as I'll not be able to look into it in detail for a few more days. In the meantime, could I please ask you to check if you can get the simple plugin from README to work? Calling :UpdateRemotePlugins might crash Neovim again, but if my current hypothesis is correct the specs in rplugin.vim should be properly populated and calling :LispSampleCmd should work.
Also could you also please post your Neovim version (and if you didn't install by building it from source, how you installed it so I can reproduce this)?

The sample plugin prints Command: Called 1 times, args: NIL, range: (1 1), bang: NIL to my buffer, so that seems to work. My version is
NVIM v0.1.6-89-g2daf54e
Build type: Dev
Compilation: /usr/local/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Wall -Wextra -peda
ntic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DE
CLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20160912-2107-m91gva/build/config -I/tmp/neovim-20160912-2107-m91gva/src -I/tmp/neovim-20160912
-2107-m91gva/deps-build/usr/include -I/tmp/neovim-20160912-2107-m91gva/deps-build/usr/include -I/tmp/neovim-20160912-2107-m91gva/deps-bu
ild/usr/include -I/tmp/neovim-20160912-2107-m91gva/deps-build/usr/include -I/tmp/neovim-20160912-2107-m91gva/deps-build/usr/include -I/t
mp/neovim-20160912-2107-m91gva/deps-build/usr/include -I/usr/local/opt/gettext/include -I/usr/include -I/usr/include -I/tmp/neovim-20160
912-2107-m91gva/build/src/nvim/auto -I/tmp/neovim-20160912-2107-m91gva/build/include
Compiled by<EMAIL_ADDRESS>
Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD-2daf54e/share/nvim"

Installed from current HEAD via Homebrew package manager on OS X 10.11.6.

Thanks, I'll go at it in a few days.

I guess it takes my Lisp environment that long to set everything up

Yep, you are right. I haven't properly profiled this, but I would assume that Quicklisp adds quite a bit to that startup time. I simply decided that a few second hangup once per session is worth the convenience Quicklisp provides to the end user.

Any crash in nvim is an nvim bug. If you can figure some reduced steps  that would help a lot.

Filed an issue over at Neovim: https://github.com/neovim/neovim/issues/5349

I can no longer reproduce this issue with Neovim version 0.3.0, running on Kubuntu 18.04. Closing the issue.


Ignore ABC abstract methods

Is your feature request related to a problem? Please describe.
Sometimes you want to create an abstract class with abstract methods that will be overridden by other subclasses. For example:
import abc

class Foo(abc.ABC):
    @abc.abstractmethod
    def a():
        ...

class Bar(Foo):
    def a():
        return 1

Pay attention that while Bar.a content should be covered by test, the content of Foo.a should not since there is no actual gain in covering it with a test.
Describe the solution you'd like
Coverage should ignore abstract methods by default and should not require coverage for them.
Describe alternatives you've considered
If you think that sometimes abstract methods should be covered, maybe we can make this ability toggleable by a flag (--ignore-abstract) for example.
Additional context
This API is available only in Python 3, therefore we should make sure we disable it in Python 2.

Will it work for you to update your .coveragerc file to exclude those methods? Like this:
[report]
exclude_lines:
    pragma: no cover
    @abc.abstractmethod

No, but the following might will:
[report]
exclude_lines:
    pragma: no cover
    @abc.abstractmethod
    ...

I'll check it.
Even though it is a solid solution, I think that this case is general enough to be handled directly with a flag or a specific configuration.
What do you think?

You don't want to add "...", that's a regex that matches almost every line of your code (se #1042).  Try the setting I suggested, I think it will work for you.
I'm reluctant to add hard-coded options for language features, because different people approach them differently, and the language changes over time.

I don't know if it would be helpful to add to the default excluded lines pattern?

Another way to do it might be to automatically ignore "trivial" function bodies like mypy already does. "Trivial" function bodies, according to mypy, have a single pass, ..., or raise NotImplementedError statement. This may be possible with a regex, but making rules that handle formatting, comments, etc might be difficult. mypy operates on AST, which makes the implementation of detecting trivial functions trivial :smirk:.

Maybe we could add something to the docs that suggest these sorts of regexes?  I think regexes in the configuration file are powerful enough for what people need to do.

#894 is blocking that.

@ktbarrett can you show me some of the code you are working with, and what you would like to do?

I'd like to ignore the bodies of abstract functions.
@abstractmethod
def method(self, arg: int) -> str:
    """docstring with code examples in it"""
    pass

Adding just pass to exclude_lines means I exclude things like
try:
    return may_fail()
except Exception:
    pass
return NotImplemented

I thought for a second I could write a regex that could detect such cases, but I now realize that isn't really reasonable/possible.
I've adjusted my current strategy to:

add raise NotImplementedError and ... to exclude_lines
by convention use only those statements for type stubs and abstractmethod bodies and not pass
by convention never use those statements in executable code, but I can use pass
update everything that currently does not follow this convention

There's something people are missing in this discussion: since coverage.py v4.1, if you exclude a decorator, it excludes the entire decorated function.  So the best exclude line here would be:
[report]
exclude_lines =
    @abstractmethod
    @abc.abstractmethod

Once you do that, the entire abstract method is excluded from coverage, no matter what statements it contains.
BTW, this is also being discussed in pytest-cov: https://github.com/pytest-dev/pytest-cov/issues/428

Also, I see that this behavior of excluding a decorator isn't mentioned in the docs! I will fix that.

There is the possibility that abstractmethods could have behavior in them that is intended to be run with a super().method() call. I think it's kind of atypical, but possible. However, the decorator solution works for me because I don't do that.

Also doesn't cover setters of abstractpropertys. I unfortunately have to use abstractproperty because mypy does not like layering property and abstractmethod. But it will be covered by other rules.

I've added to the docs in c6d9eb99.


Add type annotations for @intrinsic

Previously using the intrinsic decorator would cause typing issues when invoking the decorated function, e.g.:
@intrinsic()
def myIntrinsic(typing_context, a, b):
   ...

myIntrinsic(a, b) # type checker complains that there's a missing parameter

This can be solved by annotating intrinsic with types that indicate that the decorated function does not take the typing context parameter.

the failure in the docs build seems to be because python version before 3.10 did not have typing.Concatenate. This can by resolved by either taking typing-extensions as a dependency, or possibly moving the annotations into a stub file and making it conditional on the python version. Will try to test that out soon.

I was able to resolve the CI issues by moving the annotations to a .pyi file. This allows importers of numba.core.extending to gain type information about intrinsic, but doesn't actually do any type enforcement within extending.py.

@stuartarchibald now that this is passing tests can the review process proceed?

@stuartarchibald now that this is passing tests can the review process proceed?

@aneeshdurg yes, I've now queued it for review. Thanks!


[feat] Building

Describe the problem
Wix toolset, a bit difficult to use, ugly interface, maybe I'm not using it properly.
Describe the solution you'd like
Can you provide more packaged installation tools? such as NSIS,Squirrel.Windows
Alternatives considered
No response
Additional context
No response

NSIS will be investigated in the future. Currently you'll have to get along with Wix :) at least you don't have to write the XML directly :D

@seahindeniz In the linked PR, I have implemented an option in tauri.conf.json that determines whether your installer will be built to be installed system-wide or for current user


Intellisense doesn't work well frequently

Environment

Steps to Reproduce
1.Create a Python Application.
2.Type import
(more steps from this documentation: https://learn.microsoft.com/en-us/visualstudio/python/editing-python-code-in-visual-studio?view=vs-2022)
Expected behavior
As you type, your completion list should open and prompt for your input accordingly.

Actual behavior
Nothing came up and Error List doesn't show errors or warning

Additional context and screenshots

I don't find a way to repro this. How often does this happen? Did you wait until the pylance server starts?

On this build: 17.9.0 Preview 2.0 [34314.196.main], I have waited for a long time, but it doesn't have any Intellisense
On today's latest build: 17.9.0 Preview 2.0 [34315.153.main], I can't repro this issue, Intellisense works well


How to change Submit button style?

I'm trying to change rhfa-react-native form styles. I've changed everything except the submit button style. I couldn't find the style properties for the button. Please, If anyone knows that let me know.

Hello. Sorry for the delay.
I will take a closer look. At the moment you can provide your own button in two ways:
stand-alone, completely controlled by you
This is the method the demo uses. You use imperative submit to force a submit on that button's click:
    const formRef = useRef()

    function handleImperativeSubmit() {
      formRef.current.submit()
    }

    return (
      <Autoform {...} />
      <MyButton onClick={handleImperativeSubmit} />
    )

As a child of Autoform
That way you can use a type="submit" button and it will trig the submit when pressed.
    return (
      <Autoform {...}>
        <MySubmitButton />
      </Autoform>
    )

Hello. Sorry for the delay.
I will take a closer look. At the moment you can provide your own button in two ways:
stand-alone, completely controlled by you
This is the method the demo uses. You use imperative submit to force a submit on that button's click:
    const formRef = useRef()

    function handleImperativeSubmit() {
      formRef.current.submit()
    }

    return (
      <Autoform ref={formRef} {...} />
      <MyButton onClick={handleImperativeSubmit} />
    )

As a child of Autoform
That way you can use a type="submit" button and it will trig the submit when pressed.
    return (
      <Autoform {...}>
        <MySubmitButton />
      </Autoform>
    )

Thanks for the reply. I wrote a custom button for this. :)


prevent direct navigate to route

Is there a way to prevent direct access to component?
example: allow access to B only if comes from A. and not by navigating directly to B.
is react-router supports this kind of macahnism? i know HoC used to help with authentication but wonder how they can help me in such a case.
The workaround I found for that in the meanwhile is to handle it myself inside the component A, to show B only if the "showB" state is setted to true.
how to do it react-roouter-wise?

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


Added Get and Set operations with custom Converter definitions.

The GetCell, SetCell, GetColumn and SetColumn now take an
optional (last) parameter, specifying what Converter it should
use. This is a very handy way to override the default Converter, per
cell or column. One could now convert non-homogeneous data inside a
csv.
Full examples of usage can be found in test035.cpp.
All interfaces are backwards compatible, requiring no changes to
existing code.
The use of typeid(), for routing the conversions in the Converter
class, was removed and re-implemented, using template specialization.

Thanks for the PR! I've been kind of busy the last week, but I hope I'll get a chance to take a look in the next few days.

@d99kris,
No stress. I'll probably add some more commits to get rid of some compiler warnings, etc. Once you're satisfied, I'll squash-commit all into one commit.

In general I feel this is a very good PR, thanks a lot for submitting it! :)
I added two suggestions for const'ness (but optional - not really important).
One thing though - could you help check if README.md section "Custom Data Conversion" needs to be updated?
Also if you'd like some attribution, feel free to add a "Contributors" section to the README.md - perhaps just a bullet and your (github user)name/link (totally optional).
Once you're satisfied with the PR I'll pull the changes and generate the API doc and bump the version.

Thanks. I'll create an example for the Custom Data Conversion documentation and I think I'll rather make a Contributors file and reference it in the README.md.
I must admit that I didn't generate the doxygen API doc yet, as I was not sure if this monster-patch would be accepted. I'll work on that as well and document all the new members, etc. I'll hopefully have something ready by tomorrow.

Hi @d99kris,
I added an AUTHORS file. Could you please extend this file with the rest of the authors.
Uncrustify was run on all relevant files for this PR and I added another example into the README.md. Surprisingly enough, the Custom Data Conversion part that was in the README.md file had no changes, as that part of the interface stayed untouched. I did however add another example and hope that it will be useful.
Please let me know the PR is ok like this and if you want me to squash-commit it.
Regards

Hi @wingunder - thanks a lot, I think the PR looks very good!
To be honest I don't receive a lot of PRs so I'm not sure what is the best process for merging them, but yeah feel free to squash-commit it - I guess it will then have the correct author (you) vs. me if I were to squash and merge..(?)
Thanks!

Hi @d99kris,

I'm not sure what is the best process for merging them, but yeah feel free to squash-commit it

No problem, I squash-committed it according to this HOWTO: https://github.com/wprig/wprig/wiki/How-to-squash-commits
The diff between origin/master and wingunder/custom_commit is now just one commit c4ce0b2.

Thanks for your contribution @wingunder


feat: Adding Terraform module

Context:
Telco team is trying to build Terraform modules for the Charmed 5G, using the Juju Terraform provider. Main reason for having Terraform modules is that, unlike Juju bundles, they support day 2 operations.
This PR adds a Terraform module for the Grafana charm.
The module uses Terraform Juju provider and allows deploying Alertmanager using Terraform.
All details regarding module's architecture are available in terraform/README.md.
In the next step, this base module will be used by the cos-lite Terraform module (prototype here).

So, we had a brief discussion about this yesterday, and we haven't really agreed on whether we want the modules scattered across the repos, or if we want all of them in the cos-lite-bundle repo. Let's park this PR until we've had a chance to decide.

There are now PRs/initiatives for:

TF for Mimir and COS HA
TF for Tempo HA
TF for Grafana K8s


Wrong parameter shouldRequire()

@DarkGhostHunter hello,
I have tried your library and this config param [shouldRequire()](https://github.com/DarkGhostHunter/Preloader#shouldrequire) makes me stunned a bit, cause there are no such property or method in your source code. Instead, there is another one, called [useRequire()](https://github.com/DarkGhostHunter/Preloader/blob/master/src/GeneratesScript.php#L49 ) and the same property.
Think, this is only the naming bug in the doc. Would be nice if you fix it, so another guys won't be like me))
Thank you!

Think, this is only the naming bug in the doc.

You got that right. Fixing in master. Usually I push to stable along other features, fixes or else.

Fixed in commit. Thanks.

BTW, don't be shy to issue a PR youself.

Fixed in commit. Thanks.

Thank you!

BTW, don't be shy to issue a PR youself.

It was 3 am here, when I realize what is wrong, so was not in condition to make good PR =)
But in future -  yeah


style of nodes

hello,
is there a way to style the nodes? (for example change their shape and color)

https://github.com/joyceworks/flowchart-vue/blob/db1f6cb14c6b0693a9e7d80a45fac29a9c28be5a/src/views/App.vue#L172

how to change colors of node ?


How to use embedding correctly

What kind of model should be used for embedding? When I use nomic-embed-text-v1.5.f32.gguf, it will report protected memory, while when I use tinyllama-1.1b-chat.gguf, it can run normally. However, I feel that the returned float array is not correct. When I use the same text for vector matching, the similarity is only 0.42

I'm not familiar with nomic, but if it's based on the BERT architecture it's supported in LLamaSharp yet. BERT support was only added to llama.cpp a couple of weeks ago (https://github.com/ggerganov/llama.cpp/pull/5423), and we haven't updated our binaries yet.

However, I feel that the returned float array is not correct. When I use the same text for vector matching, the similarity is only 0.42

Do you mean you literally fed the same text in twice at it wasn't identical? If so that's definitely a bug!

I have the same issue using the phi-2 and llama models through the integration of semantickernel. The values returned from the 'memory' seems to be completely independent to the search value.
And I have the same issue I put in an exact match for the search.

I experienced the same issue with the poor similarity matching with Semantic Kernel.
Once LlamaSharp updates the binaries to support the Bert models, this issue should go away.

Why will the update of Bert models help?


scripts: twister: add option to force using sysbuild for every testsuite

CLI option which force to use sysbuild.
The usecase:
Enable testing with twister for 'companion' cores, which needs luncher to start.
E.g. Luncher is executed at Application core and FLPR core executes test/sample.
Usage with west:
west build -b nrf54l15pdk/nrf54l15/cpuflpr . --sysbuild -- -DSB_CONFIG_VPR_LAUNCHER=y
Usage with twister:
python ./zephyr/scripts/twister --ninja  --jobs 1 -T zephyr/samples/basic --platform nrf54l15pdk/nrf54l15/cpuflpr --device-testing --device-serial /dev/ttyACM0 --extra-args SB_CONFIG_VPR_LAUNCHER=y --west-flash --force-sysbuild

This is supplement for #71348

@nashif @golowanow @hakehuang  this is a rather trivial extension, similar to other we already use (e.g. --fixture, --extra-args, etc.) to pass an argument from the top twister call (CLI level) down to all builds

@nashif @golowanow @hakehuang this is a rather trivial extension, similar to other we already use (e.g. --fixture, --extra-args, etc.) to pass an argument from the top twister call (CLI level) down to all builds

I am not convinced this is trivial, maybe in the way it is implemented, however, it is very specific to a single usecase and needs additional command line options which makes it more custom and not generic, something like this need to be implemented at the test level and not be done using twister command line. Did you consider other options?

@nashif I get your point. I also prefer that if this is a platform config level info, it is added there, and not through twister call. This is an alternative solution https://github.com/zephyrproject-rtos/zephyr/pull/73790
Although I think this PR in general is ok. It's just like with --extra-args, if developer want to check some extra config (in this case using sysbuild) without reworking dozens of yamls


transfer closed with xxx bytes remaining to read

transfer closed with xxx bytes remaining to read
Most of the time i get this error is there something wrong with your code.

Can you send me a screenshot or snippet of the error?

I made a tweak to the code. Update the package using composer update.

Thank you..
I have another issue if you can figure out. The result count on dubizzle and by fetching our API is different.
For Example:
https://dubai.dubizzle.com/motors/used-cars/audi/a4/?year__gte=2005&year__lte=2005&body_type=348
IF you check the above link you will see around 5 records but when we fetch via our code below we get 2-3 records why is it not fetching the complete list. can you make an example for this Make/Model/Year/Type.
$params = array(
"country" => 'all',
"city" => 'all',
"section" => 'motors',
"category" => 'cars',
"make" => 'audi',
"model" => '1187', //A4
"body_type"=>'348', //Sedan
"min_year" => '2005',
"max_year" => '2005',
"num_results" => 'all');
$uae_dubizzle = new Search($params);
//Rest you know the code
Help would be appreciated.

I will update the code shortly. Apparently, the reason why you are seeing 3 results instead of 5 is because of the ads post param is set to within a month instead of any time.

In addition, you can use $uae_dubizzle->query_url() to get the exact url to visit and see the results via browser.

If you put 'added_days' => '', it should work. I checked the code and realized that added_days is set to 30.

Thanks for the update.
But still facing an issue.
Check this link from dubizzle
https://uae.dubizzle.com/motors/used-cars/chevrolet/corvette/?site=--&s=MT&rc=140&c1=1235&c2=1239&price__gte=&price__lte=&year__gte=2011&year__lte=2011&kilometers__gte=&kilometers__lte=&seller_type=&keywords=&is_basic_search_widget=0&is_search=1&added__gte=&auto_agent=&body_type=347
Above dubizzle show 1 record and our compiler zero.. Is it that if you get more than one record then only compiler works? Please help me have tested i am not getting singular records only
My code to fetch
$params = array(
"country" => 'uae',
"city" => 'all',
"section" => 'motors',
"category" => 'cars',
"make" => 'chevrolet',
"model" => '1239',  //Corvette
"body_type"=>'347',  //Coupe
"min_year" => '2011',
"max_year" => '2011',
"num_results" => '100',
"added_days"=>'');
$uae_dubizzle = new Search($params);

Apparently, dubizzle had a featured item tag that wasn't captured by the api. I added the capturing of featured items.


There's no way to create a bare array of json objects

At least as far as I can tell.  You can create an array of strings easily (as per the API docs) but what I'd like to be able to do is (something like):
json.array!(things) do |thing|
  json.foo thing.bar
  json.other_foo thing.item
end

to return
[{'foo':'bar', 'other_foo':1}, {'foo':'baz', 'other_foo':2},...]

try this ...
things.each do |thing|
  json << {:foo => thing.bar, :other_foo => thing.item}
end

Ah, that's pretty obvious in retrospect.  It works fine and I guess there's no need for the json. based API.

Is there a way to render a partial within a bare array, such as:
things.each do |thing|
  json.id thing.id
  json.name thing.name
  json.ingest! (render :partial => 'partial')
end

Thanks


⚠ ETF has degraded performance

In fb34dd7, ETF (https://markets.hankyung.com/equity-product/etf) experienced degraded performance:

HTTP code: 200
Response time: 8988 ms

Resolved: 거래대금 performance has improved in 53218be.


feat(api): check if a tip is present on a pipette in the hardware controller

Overview
We have tip presence ability on pipettes and so we should use it to inform the user of an error if a tip fails to pick up. This is the very beginning of tip presence handling and so it does not:

continuously check to see if the tip state has changed while running a protocol
re-try picking up or dropping a tip (although we can do that in a follow-up PR once we figure out a number here)
Support tip sensing for the 96 channel

Test Plan
Create a protocol that picks up and drops tip a few times. On the robot, you should have a tiprack that is missing some tips so that when a pick up tip fails to detect the tip and error raises. This will stop the protocol. You can do the same thing for drop tip by simply removing a tip after it has successfully picked up. I would suggest adding pauses between pick up/drop tip to make this easier to test.

[ ] Check that pick up tip will fail in a protocol if it does not pick up a tip
[ ] Check that drop tip will fail in a protocol if it does not drop an existing tip (we will have to fake this by removing the tip beforehand)
[ ] Check that LPC can handle a failed pick up or drop gracefully
[ ] Once we have done the above, run a regular (short) protocol to check the reliability
[ ] Test all in-use DVT pipettes to see if they have incorrect photointerrupter (definitely on single channels, maybe on multi-channels)

Changelog

Add a command you can use in the hardware controller to query the tip state
Raises an error if the state does not match the expected value when you're picking up or dropping tip.

Review requests
Might've flipped the state. Please check me on this.
Risk assessment
Medium/high. Could potentially be disruptive to ABR work.

[x] Check that pick up tip will fail in a protocol if it does not pick up a tip
[x] Check that drop tip will fail in a protocol if it does not drop an existing tip (we will have to fake this by removing the tip beforehand)
[x] Check that LPC can handle a failed pick up or drop gracefully

[x]  Once we have done the above, run a regular (short) protocol to check the reliability

We'll rework the remaining pipettes with the misplaced photointerrupter flag.


Unused import warnings

I've recently upgraded to 0.3.0 and am receiving a lot of unused import warnings for Component and StatelessComponent. It looks like when the macro expands no reference remains of Component/StatelessComponent. Any chance we can correct this?
Minus the warnings, everything works fine with 0.3.0 in my small app!

I think this can definitely be addressed! Because we now reuse the existing class as the definition class, the extends Component/StatelessComponent is being eliminated. I think the easiest fix will probably be to introduce some dummy element that references the original Component type.


Add role documentation, add system begin & end tokens

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.
Motivation
Lack of documentation on how to use the role of Chat model, and lack of begin/end tokens for the System role.
Modification
Add role documentation, and system_begin(), system_end() function in api.py.
Checklist

Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
Modify documentation as needed, such as docstrings or example tutorials.

please fix the lint error

Should be fixed now.

@objnf-dev Thanks for the contribution!


Tweak documentation style a bit

The following tweaks were made:

Extra whitespace (at the end of a line)
Whitespaces where a tab should be
Over 80 columns
Not a two-space convention
etc...

thanks!

included as of 624bb83619cbd685b1902b016ca


how to train imagenet by keras from scratch

Hi everyone.
I need train imagenet from scratch.I am a new user to keras.I found it litter material about use keras to train imagenet.
my conifguration is。
1、keras 2.20
2、tensorflow 1.9.0
Thank you!
有没哪位老铁指导下呀。本人QQ 571205937，谢谢！

Hi!
This issue isn't related to a bug/enhancement/feature request or other accepted types of issue.
To ask questions, please see the following resources :
https://keras.io/
https://keras.io/#support
https://gitter.im/Keras-io/Lobby
Thanks!
If you think I made a mistake, please open another issue.


Changed MPH format from %.2f to %.0f

This will help in the android app to show the MPH on only one line.  General use for tracking speed in MPH only needs %.0f precision anyway.

Reviewing.


Sunny Home Manager not found

Describe the bug
I set up the adapter with following parameters:

The adapter does not find our installed Sunny Home Manager 2.0:

To Reproduce
Steps to reproduce the behavior:

Install adapter and run instance with default settings.

Expected behavior
SHM 2.0 should be found on IP <IP_ADDRESS>. Objects should be added and filled with readout of the SHM.
Screenshots & Logfiles

I assume that I might need to activate some kind of API in the settings of the Sunny Home Manager?

@stevoboy
This problem typically shows up, when the SHM is not in the same subnet as the iobroker server. Thus the multicasts of the SHM do not reach the sma-em adapter. It is not necessary to make any config to the SHM. It generally multicasts its data right from the start. Rather you should check your network configuration. Multicasts are not generally forwarded by routers between subnets. Also some switches interfere with the multicasts. That is why SMA recommends to switch off IGMP V3 snooping. But I assume your problem roots in a router problem since from your report above I saw that your iobroker is in subnet <IP_ADDRESS> while the SHM is in <IP_ADDRESS> . I suggest that you look whether your router supports multicast forwarding and configure it accordingly. If this does not work I propose that you describe your problem in the iobroker forum e.g. https://forum.iobroker.net/topic/43011/test-adapter-sma-em-v0-6-x-latest
Maybe some other user can help.

I realized one thing last night, if the adapter is listening on port 9522, I must open a port in the docker container as well. I did that now:

Shouldnt the IP address not be found now when I ping it?

@stevoboy
It seems that SMA multicast with docker containers is a general problem.
https://forum.iobroker.net/topic/38520/multicast-sma-em-usg-netztrennung
In https://smarthome.buanet.de/2019/05/iobroker-unter-docker-auf-der-synology-diskstation-v3/
it is clearly stated that the simple docker network bridged mode will not work for adapters which use multicast.
A solution seems to be to configure the docker network to use macvlan. A description can be found https://smarthome.buanet.de/2020/09/macvlan-ueber-portainer-einrichten/

@stevoboy
Have you been able to solve your problem meanwhile? Please indicate whether I can close this issue

Yes, I solved the problem by reinstalling the docker container in host mode.


Create Makefile to run common development tasks locally

🚀 Feature
Hi! I just found this project. Really cool!
I wanted to propose a feature to create a Makefile in the repo.
The objective is to simplify local development and contribution by creating a Makefile that encapsulates and standardizes common development tasks such as running tests, building docs, etc. It is inspired by pydantic's Makefile:
https://github.com/pydantic/pydantic/blob/main/Makefile
I would be happy to contribute.
A first stab at the problem would be to create a Makefile to run the following tasks:

Install dependencies make install
Run tests: make test
Run linter/formater: make lint / make format

In the future, other checks could be run and integrated to the CI:

Run benchmarks
Run mypy.
etc.

Motivation
The motivation is to provide a toolkit for developers in order to simplify the process of contributing to this cool project
Pitch
Add a Makefile to run common development tasks locally.
Alternatives
Additional context

hi @AdolfoVillalobos, really appreciate the suggestion. At this moment, we only have tests that can be used with Makefile, docs live on our platform here. So, it would be an overkill for test.

Fair enough! I will be looking at other ways to contribute. Cheers!


Improve the Python3 template

See the Template Enhancements milestone for details.
Files in scope:

py3.tmpl

Closed in commit https://github.com/FFIG/ffig/commit/be33fd40fcd0ab3c30149fdd39b831e37b4be63a.


Fix for 1.12.2 Chunk dupe exploit?

There is an item duplication exploit in 1.12.2 that lets you use the 1-megabyte limit on Minecraft chunk data filesizes to duplicate items by using written book items filled with random exotic letters and characters (zalgo text, chinese symbols, etc) which can't be compressed properly data-wise and thus can be used to quickly overload the chunk's 1-megabyte data filesize limit, forcing it to revert to an earlier state when (for people intending to dupe items) there were more blocks and items in the chests. When the player relogs after inserting these massive books into the chunk in certain ways, they will be able to take "reverted" copies of items that were in the chests before they logged out and thus dupe their items.
This video explains how to reproduce this exploit (https://www.youtube.com/watch?v=R8VV4sU9Nvk), and I have done this myself before in my own worlds, both singleplayer and online, and was able to reproduce it every time.
This forge mod will allow you to create these hacky exotic-character books required for the dupe exploit to work (though using the client mod is not the only way to do it): https://github.com/Earthcomputer/clientcommands/releases/tag/v20190126-snapshot
There are a number of ways I think this exploit could perhaps be solved without much issue perhaps, such as limiting the variety of allowed characters/symbols for players to write with in books to within a certain amount (such as just characters typable on an English-language keyboard), or disabling players from placing books in regular chests (so they can only place them in ender chests).
I hope this may be reasonable to fix! :)

Hello, It seems like Forge itself already fix this bug. (https://forums.minecraftforge.net/topic/70018-book-duplication-bug-chunk-overload/)

Hello, It seems like Forge itself already fix this bug. (https://forums.minecraftforge.net/topic/70018-book-duplication-bug-chunk-overload/)


vulkaninfo: Check requirements when adding to pNext chains

Only include structures in pNext chains whose corresponding extensions or versions are supported.

CI Vulkan-Tools build queued with queue ID 91575.

CI Vulkan-Tools build # 1299 running.

CI Vulkan-Tools build # 1299 passed.

CI Vulkan-Tools build queued with queue ID 93341.


[HOLD for payment 2024-06-28] [$250] Don't show "We might have a problem. Check out "

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
**Slack conversation:https://expensify.slack.com/archives/C05LX9D6E07/p1717834594513299
Action Performed:

In Network devtools, verify that Ping command is called every 60 seconds (see Network Devtools)
Block https://dev.new.expensify.com:8082/api request to make backend unreachable (see Block network request)
Verify that after a while, 'You appear to be offline.' message appears.

Expected Result:
We should only ever see the 'You appear to be offline.' message
Actual Result:
Sometimes, we see the 'We might have a problem. Check out status.expensify.com.' message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01557bbba5e2f56091
Upwork Job ID:<PHONE_NUMBER>715909319
Last Price Increase: 2024-06-12

Issue OwnerCurrent Issue Owner: @trjExpensify

Essentially, we need to revert this PR without altering future changes made to networking like this PR. @tienifr @DylanDylann @cubuspl42 if you could take a look at this, that would be great since you worked on the original PR to add in this functionality.

@tienifr Please ping me when the PR is ready

Cool thanks, @mananjadhav reassigning to @DylanDylann since he reviewed the initial PR.

Not sure why the automation is failing. @tienifr do you think you can give an ETA for when the PR will be ready?

friendly bump @tienifr

@tienifr did you open the PR on Friday? Could you link it here?

I believe @tienifr is opening a PR today

👋 checklist time!

Bump on the checklist, @DylanDylann!

This is a reverted PR. We don't need the checklist.

This is a reverted PR. We don't need the checklist.
cc @srikarparsi

Oh cool, so no payment is due as it was a regression revert?

@trjExpensify The payment should be handled here because this is not a regression. we intended to implement this feature previously but it seems this is unnecessary so the internal team created this issue as a task to revert the previous PR
cc @srikarparsi

@trjExpensify I accepted the Upwork offer 🙏

Paid, @DylanDylann. Closing!

$250 approved for @tienifr


[Discussion] Dashboard Layout Design

We now have two versions of design:
Left-Right

Top-Down

The display of feedback list is not determined yet. It could be multi-columns or a single column in both versions.
Note in the requirement:

"As a dashboard user I want the landing screen to load as quickly as possible. As the feedback database may contain a large number of reviews, only display the first 25 (the 25 most recently received) on page load.
Provide a means of navigating through the rest of the reviews, with pages returning 25 reviews."
-- Tamas Gyorfi

(25 per page... So it has to be 1*25 or 5*5 to make layout reasonable..)

Or we could just simply follow the demo one Tamas provided:

by putting the phrase item below together with a two-column feedback list.

 SPR7: Dashboard: Design/Organise Layout

 SPR7: Produce prototype designs for Dashboard UI

Initial implementation:


[CARBONDATA-2714] Support merge index files for the segment - Documentation update

Documentation update for Merge index feature

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[x] Document update required?

[ ] Testing done

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5981/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/7206/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5871/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5872/

retest sdv please

LGTM


Add Codecov Config

Codecov Report

Merging #86 (220b859) into master (4969c83) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           32        32
  Lines          509       509
=========================================
  Hits           509       509

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4969c83...220b859. Read the comment docs.


unsloth installation broken at a bad time

the newly pushed changes broke the installation of the library
AttributeError: module 'unsloth.models._utils' has no attribute 'accelerate_old_send_to_device'

Apologies - just pushed new changes to fix it! Hopefully it works now!


Modifybpf map update to prevent potential bugs

What type of PR is this?
Modifybpf map update to prevent potential bugs

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #536
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm
/approve

/cherry-pick release-0.4


Ticket (attendee) model improove functionality

Update functionality to generate order if it is not set when storing model, or update on status change.
Price is copied from ticket_type
Predefined values:
discount: (calculate sum, if discount_code is set)
status:

awaiting payment, upon creation.
cancelled, when ticket is cancelled.

duplicate of #75


Adds comments / clarifies L1 as ethereum, not Base

Due to customer confusion, I added some clarifying comments.

Note: I merged PR #17 into mine -- I thought I had clobbered it (didn't realize my approve didn't actually merge).


[FEATURE] SSL Support

Request
Allow txAdmin to support SSL certification on a different port as previously supported during an old beta stage.
Additional context
https://github.com/tabarra/txAdmin/commit/27585e299f6cadcd6392824d155ed1779f84a7da
I've searched and searched to allow TxAdmin to be viewed over HTTPS, however it seems the support for this feature was removed after being in beta for a short while.
Would there be any plans to bring this back in the future, considering how much SSL is pushed by browsers these days?

Would there be any plans to bring this back in the future, considering how much SSL is pushed by browsers these days?

At the moment, there is not currently any plans to bring back SSL support within txAdmin itself, as we felt the compromise in maintenance, ease-of-use, and support, wasn't worth the extra feature.
This doesn't mean SSL cannot be used, rather you need to setup something like a nginx reverse proxy in front of txAdmin. A quick google search should be able to get you on your way.

I recommend using caddy to set up ssl in front of your txadmin, as well as rate limiting.

Hello,
is there any news here? I've been using txAdmin for a while now and the interface is just awesome!
However, I have now switched my server completely to SSL and boom, txAdmin can no longer be called.
I get an "ERR_SSL_PROTOCOL_ERROR" error right away.
However, the certificate is correctly installed and all websites are also running correctly.
Or is there a guide somewhere where I can change that so that txAdmin can be called up again?
Thanks for the help :)

@silez We recognize the importance of SSL, but we also decided txAdmin is not the right place to manage it.
We suggest you protecting it through some reverse proxy or cloudflare tunnel.

@tabarra
Thank you for your answer. The problem is only if you have completely switched your server to SSL. Because then you automatically no longer have access to txAdmin - unless you don't automatically switch from http to https and don't use hsts.
Nevertheless, it is of course your decision, I simply assigned another native IP to my server and call txAdmin over it. in addition, the surface is protected with .htaccess. should be enough for now I guess :)
In any case, thanks again :)


Version in .abapgit.xml

Propose to add some reference to package version into abapgit.xml file. Could be useful for devops, shields, potential future package management, dotabap.org.
I can see 3 approaches

Indirect locator/selector. Field <version_locator>src/zif_blahblah.intf.abap/gc_version</version_locator> - which would point to a constant in the code and can be parsed

Direct version specification. <version>v1.2.3</version>. This has own benefits and disadvantages. E.g. abapGit uses version in the code. However it is not difficult to parse abapgit.xml on the fly and get it from there (although more difficult then e.g. require package.json ...). for the one-file version abapmerge can put version into a predictable place (lif_dot_abapgit). In the AG UI there can be helpers to manage the version (buttons for major/minor/patch increase). At the same time non-abapgit projects do not have at-hand .abapgit parser - this is a disadvantage

2.1) locator and direct version are not contradictory - both can be implemented and used at develop's convenience

Finally, thinking about the future, 1 or/and 2 can be done a bit smarter and incorporated into a high level tag package which may in future hold e.g. dependencies and replicate a structure similar to apack (as an alrternative).

...
<package>
  <version>...</version>
  or (xor!)
  <version_locator>...</version_locator>
  <dependencies>...</dependencies>
</package>

which use cases are we trying to solve with this? there is also a git tagging feature

git tagging is good, but it is not native. tags can be added and removed - they are not a part of history, they are not a part of language.
Well, I guess the case is native abapgit package versioning with all the consequences whatever can it be used. If you think abapGit does not need it I can cancel :)

badges/shields are cool, we can add it just because of that
versioning in abap is difficult, so its difficult to add a new/another way to do something, we need to consider if its needed, and what it can solve
AFAIK annotated tags are part of the git history? https://mijingo.com/blog/two-types-of-git-tags

This also overlaps with version in the .apack-manifest.xml right? Main dependency stuff issue: #217
I would have liked to have apack evolve outside of a cloud-only and ADT-only environment and avoid having multiple implementations of the same feature.

adding to the brew, I think https://github.com/larshp/abapGit/issues/2236 is still relevant to implement in abapGit

Annotated tags: nice, didn't know this. Still it is a git feature. Not native. No clear way to extract this data from abap. The version should be universal.
The badges should not be the only driver - this is for sure :) Although it is cool (and almost ready ;) ). But even without dependencies, having a clear universal and always working (! apart from apack) method of reading the version will be good.

dotabap is a good candidate. Displaying version, doing some notification on releases at least...
in mockup loader I add new features and build a small validation to check the installed version fits - helps a lot (well, this is clearly solved by a constant, no need for .abapgit frankly - but to show that there are practical in-code use of versioning)

@flaiker: it does overlap. And, I confess, I'm a bit pessimistic about apack. Imho it is not secure (due to code execution) and not compatible (because of orphan interface). I'd personally like to have a native alternative. I would use it. And I would have some inclination to contribute to what I'm using. In terms of tooling (abaplint and whatever else) there is no difference between apack and .abapgit - both are cool enough. Finally - the data structure of apack looks fine ... it can be reused directly in .abapgit. Or even, if this is principal ! there can be an alternative approach to create apack manifest. E.g. if no class implements the interface, go to .abapgit, check if there is a reference to some apack class (<apack_provider>), which can do the same without the interface (though the security concern remains). This would also do.

perhaps we should do a real world telephone conference call some day, invite a few more people, this is difficult stuff, as ABAP basically does not support versioning(version 1 and 2 of class ABC cannot run in the same system at the same time)

A good alternative will be to link a specific commit to a version in .abapgit. This will be used to News functionality comparing commits of changelog file between two versions

@sbcgua did your discussion regarding a "build to zip step" help for this?

@sbcgua did your discussion regarding a "build to zip step" help for this?

mmm ? what do you mean ?


Separate checking for Scatter from requesting connection to desktop

Right now using connect will actually request a user provides access to scatter, which is the only way to check if they have scatter desktop installed but isn't a great user-experience.
These two should be separated into two different pathways to provide applications a way to check if a user has scatter installed but only prompt for app permissions before they first request an api route

Maybe you could just "ping-pong" the scatter desktop to detect-it, if succeed, the link app permission should be ask the first time you getIdentity

btw the application link listener if off when i start scartter desktop,i should start it manually


OpenMP Merge-SpMV algorithm from Merril & Garland for CSR SpMV

This PR brings Merge-SpMV algorithm from Merril & Garland for CSR SpMV. The implementation is based on the original article https://github.com/dumerrill/merge-spmv/raw/master/merge-based-spmv-sc16-preprint.pdf and source code https://github.com/dumerrill/merge-spmv/blob/master/cpu_spmv.cpp from Merril & Garland work back in 2016. It is using a "2D" approach to do a better load-balancing between the threads. In my extensive investigation on 6 Arm and x86 machines with 8 SuiteSparse matrices using Ginkgo 1.6, this algorithm was performing between -4% to 80% better than the current CSR SpMV implementation.
Implementation in this PR was tested and optimized only for RHS=1, but in principle it should work for RHS>1 as well. Note that I have also tested the second variant of Merge-SpMV algorithm (Algorithm 4 in https://github.com/dumerrill/merge-spmv/raw/master/merge-based-spmv-sc16-preprint.pdf), but it was always performing worse than the original Merge-SpMV algorithm (except for a few matrices on A64FX machine, but I believe this can be ignored).
At the moment the code in this PR still lacks 3 things that I leave to the experts to propose what is the best way to do it:

Integration with the rest of Ginkgo.
If necessary, addition of any tests or comparisons with the default CSR SpMV.
I guess my name and affiliation ("Luka Stanisic<EMAIL_ADDRESS>Huawei Technologies Duesseldorf GmbH") as well as Merge-SpMV project (3-Clause BSD license https://github.com/dumerrill/merge-spmv/blob/master/LICENSE.TXT ) should be mentioned somewhere.

Thank you for the review @yhmtsai, I agree with every single comment that you have made. Unfortunately, I am losing the access to the machine from which I can make public contributions. Therefore, I was hoping that Ginkgo community could take over with merging this PR.


Supporting quantile and other scale type in aggregation layer

Calculate domain based on style type
Add test to bin-sorter

Coverage increased (+2.7%) to 82.643% when pulling 7ce1dba1ae007dce031c028bfd7fc3697c548337 on support-quantile-aggregation into d212bab73af61d40d1c6b44298be8d3b8f8aabd3 on 7.3-release.

Once landed,  cherry-pick this to master branch.


feat: sort all scripts unless npm-run-all is a dependency

This restores the default behaviour of sorting scripts alphabetically followed by pre & post unless npm-run-all is a development dependency in the package.json being sorted.
Closes #220

Doesn't cover npx npm-run-all case, but having npm-run-all as a dev dependency seems like a reasonable requirement in case if I don't want my scripts to be sorted. LGTM 👍

The idea is good, but the implementation is bad, we should not pass packageJson all the way around.
I would check npm-run-all in sortPackageJson function and created a different overFields function.

@fisker I'm not sure if I'd say that's a better solution - the advantage I see with passing packageJson around is that it can be used elsewhere for other advanced checks and it's implementation does that in a very clean way by encapsulating the special logic within the function that handles sorting scripts so other functions don't need to know about that.
If you were to make a different overFields function, if I understand you correctly, that'd result in something more complex and special-case-y since it would be devoted purely to the scripts fields, e.g. how would you handle a second independent field with similar behaviour? You'd have a third, maybe even four different overFields functions?
That's if I understand your thinking correctly - I've not done a lot of work with this sort of functional currying & piping layout so it's possible I've missed an easy trick :)

what do you think my suggestions?

I'm not too opposed to them, but am interested in what others think as I originally did have the code like that, but the problem I saw was that to me it means you don't have this strong guarantee that the parameter is the package json that was passed in which is sort of the underlying idea: that a field is ensured it'll be passed whatever the value of the field is and the whole package json object.
For me this is the sort of thing where I'd feel more comfortable using a general spread if I was writing TypeScript because I know that'll be able to ensure I'm getting passed the right properties for the field function I'm writing but when writing plain Javascript I prefer having that extra distention.
Additionally, this is all internal API - so shipping it how it is right now shouldn't later prevent switching to using a spread if the becomes a reason to sometimes pass more than one argument or an argument that isn't the whole package json object.
tl;dr: I don't know if there's a lot of value in using spread right now when we're always passing in the same two values, vs the extra clarity of using named parameter 🙂

I don't think that either approach is too bad. I don't think that dragging json is too bad for perf. But maybe better for ease of understanding.  I'm just excited to see #220 fixed asap :)

@keithamus are you ok to just commit the suggestions made by @fisker that you want made, since that should be all that's needed but I'm not at my laptop right now 😅

Posting here too for visibility: You can also add numerics to your script names to force a specific sort order while retaining the ability to automatically alphanumeric sort. IMO this is preferable than adding tool specific behaviors.


Convert Embulk's timestamp values to Calcite's timestamp with timezone

In the current impl. of the plugin, Embulk's timestamp values are converted with long unix timestamp. It's even better usability to convert them with timestamp with timezone.

Fixed on https://github.com/muga/embulk-filter-calcite/pull/4


How can we obtain force values

Hi,
How can we obtain force values relating to the arm joints of robotis-op3?
Is it possible?  We see lines relating to force in manager.
Do you have  lines of code to measure force.
Thanks

Hi,
There is no way to obtain the force value in ROBOTIS-OP3.
There is no way to help. sorry.
Regards,
Kayman

This issue will be closed as there isn't any recent activity. Please feel free to reopen when necessary.


Minor passport cleanup

Following behind #9263, I realized we weren't running the passport tests in CI.
This PR should fix that and I also DRYed up a few really repetitive functions.
I tested the refactor locally with Google and things seemed to still be functional. I'll give it a shot in staging before this is deployed, but pretty confident it's all good.

@damassi A todo comment felt more honest/useful than disabling the linter warnings! 🤷


Get rid of async

While async is nice in some cases, it really just gets in the way, particularly for making everything truly parallel instead of just concurrent, I think we could get better throughput by just using a blocking reqwest client and using rayon for parallelization.

Resolved by #168


[Bitwarden] Avoid password exposure

Hi,
First I'd like to say that this extension is amazing. Really useful and easy to use.
I'd like to just suggest an improvement to its usability, security, and privacy: it would be great if when we use the Paste Password command, the password could be sent directly to the active app, without using the system clipboard. This would avoid the password being exposed by the Clipboard History extension.
The idea is to make it behave just like the Snippets extension, i.e. when you use it to paste a snippet into the active app, the snippet content doesn't appear in Clipboard History, unless you open actions menu and choose Copy to Clipboard instead.
Just an idea to make this great extension even better.
Cheers.
Cristiano

Also it would be nice to have autolock timer too


Multi-user enteprise-wide deployment with custom xmlnotepad.settings.template

Maybe it could be useful having a xmlnotepad.settings template with default options in this use case.  I mean, maybe you have a computer where several users can login and you want to provide default settings. You could use a portable installation but then you only have a global xmlnotepad.settings for every user (unless you duplicate the installation for each user).
The idea would be:

Add a xmlnotepad.settings.template. It would be a standard xmlnotepad.settings.
If there is a xmlnotepad.settings in the installation folder, the app would use it.
If there is not a a xmlnotepad.settings in the installation folder, the app would load the xmlnotepad.settings.template and save it to appdata local or roaming depending on the configuration.

Interesting idea, but Windows has lots of specialized ways to do centrally managed software distribution for enterprise, so I'd rather not re-invent this wheel just for XML notepad.  Besides I'm not sure anyone would use the xmlnotepad.settings.template feature...

Thank you for considering it.  It is very common having a default configuration file (template) with the system installation and, when you launch the application for the first time, the config file is copied to the users local or roaming profile (Notepad++ works in this mode). Some applications have the global configuration in the system in programdata folder.
For enterprise distribution is not so easy (I'm not an expert) if you want a system installation because you don't know what user will login in a computer. This is only if you want a default config and also allow each user to change it. Maybe you can configure the default user profile but it is weird.
Thank you again. I understand you have to prioritize and this is not a common feature for individuals.

Ok, you convinced me.  It's super easy to do anyway, so it's now on my list... :-)

Here's the code for it in case you want to take it for a test drive:
https://github.com/microsoft/XmlNotepad/commit/ea6f084bd49590545ed7cba05c8d912e0d6016ba

Thank you. It works great.
Maybe in future releases you could consider to handle Allow Analytics or DPI configuration in the default config template directly instead of the Env variables XML_NOTEPAD_DISABLE_ANALYTICS or XML_NOTEPAD_DISABLE_HIGH_DPI.
For me it is ok 👍 👍

You can in fact disable analytics in the XmlNotepad.template.settings, see https://microsoft.github.io/XmlNotepad/#help/analytics/ which says these settings will do it:
<Settings>
  <AnalyticsClientId>disabled</AnalyticsClientId>
  <AllowAnalytics>False</AllowAnalytics>
</Settings>

Perfect. I can also configure that in the template :)
Thank you!


Remove useless ca-certificates file management

This file serves no obvious purpose and currently breaks on RHEL7.
This PR is a more radical alternative to #37 . Feedback welcome.

@ckaenzig +1 if unit tests fixed

@mcanevet : working on that right now ;)

Sounds good to me, as this files are coming from the redhat package.


Release 6.0.0

RevenueCat Capacitor SDK v6 is here!! 😻
This is the first release of this SDK after RevenueCat took over development. We have moved the plugin to:
@revenuecat/purchases-capacitor

This release updates the SDK to use BillingClient 5 in Android. This version of BillingClient brings an entire new subscription model which has resulted in large changes across the entire SDK.
Additionally, we have added a lot of new functionality previously not supported on this plugin.
Migration Guides

See the full list of API changes in our v6 migration doc

See Android Native - 5.x to 6.x Migration for a
more thorough explanation of the new Google subscription model announced with BillingClient 5 and how to take
advantage of it in V6. This guide includes tips on product setup with the new model.

make-release failed but I finished it manually.

the link to the migration doc is broken?

the link to the migration doc is broken?

Oh interesting.. the one in the CHANGELOG.md does work, but the one on the PR doesn't. I used a relative path so seems like in the PR description it's not actually pointing to a reference, so it's failing there. Will fix the PR description link

          1 Error

:no_entry_sign:
Label the PR using one of the change type labels

Label
Description

breaking
Changes that are breaking

build
Changes that affect the build system

ci
Changes to our CI configuration files and scripts

docs
Documentation only changes

feat
A new feature

fix
A bug fix

perf
A code change that improves performance

RevenueCatUI
A change to the RevenueCatUI library

refactor
A code change that neither fixes a bug nor adds a feature

style
Changes that don't affect the meaning of the code (white-space, formatting, missing semi-colons, etc

test
Adding missing tests or correcting existing tests

next_release
Preparing a new release

dependencies
Updating a dependency

phc_dependencies
Updating purchases-hybrid-common dependency

  Generated by :no_entry_sign: Danger