requestHeaders aren't documented

If I add a couple of requestHeaders to my documentation, they show up under the Documentation section in API Gateway, but they aren't included in the exported swagger. If I go to Resources > [method] > Method Request the HTTP Request Headers section isn't populated. My Request Body section is populated however, so that gets included in my swagger. I'm using lambda-proxy.
I'm guessing the equivalent of addRequestModels from src/models.js needs to be implemented for requestHeaders?

I will take a look into this for 0.7.0. But can't give you any ETA for this

I'd love to spend some time on it. Do you think that my guess is correct, that's the way I should solve it?

This commit seems to work: https://github.com/kabo/serverless-aws-documentation/commit/c320aac5048a5f37db8ac0c1a2066930316f8bb1
I added a required option to the requestHeaders object. Defaults to false.
requestHeaders:
  - name: X-MyHeader
    desciption: My Header
    required: true

But it the code should probably not be in models.js...

Looks good :)
Thanks for taking over!
Yeah, that probably should go to documentation.js.
When you are ready, can you also add some unit tests for that part?
After that I will gladly merge the PR :)

I reopened this because this also is the case for queryParams and body (probably other values too).
I am currently working on that.


login doesn't work with Password authentication

I am trying to use login with password but it is not working. I am passing an Object with {email<EMAIL_ADDRESS>password: "password"} to FirebaseAuth.login
However authWithPassword works fine.

Are you configuring login in the bootstrap phase?
import {bootstrap} from 'angular2/core';
import {
  FIREBASE_PROVIDERS,
  defaultFirebase,
  firebaseAuthConfig,
  AuthProviders,
  AuthMethods
} from 'angularfire2';
bootstrap(MyApp, [
  FIREBASE_PROVIDERS,
  defaultFirebase('https://<some-firebase>.firebaseio.com'),
  firebaseAuthConfig({
    provider: AuthProviders.Password,
  })
]);

@davideast Yeah. I am doing this. I am doing something like this.
firebaseAuthConfig({
provider: AuthProviders.Password,
method: AuthMethods.Password
})
And Also I am logging in like this this.fbAuth.login(credentails); where this.fbAuth is FirebaseAuth.

//   this.credentails = credentails;
//   console.log(credentails);
//   console.log(this.fbAuth.login(this.credentails));

//   return this.fbAuth.login(this.credentails);

let promise = new Promise((resolve, reject) => {
    this.ref.authWithPassword(credentails, (error, userData) => {
        if(!error) {
            this.local.set('userInfo', JSON.stringify(userData));
            resolve('Done');
        } else {
            reject(error);
        }
    });
});
return promise;

Code in the comments doesn't work, but the code below it works for login. I am doing something wrong?

Same issue here.
export class FbAppApp {
  items: Observable<any[]>;
  email: string;
  password: string;

  constructor(public af: AngularFire, public auth:FirebaseAuth) {
    this.email = "";
    this.password = "";
  }

 login(){
     this.auth.login({email: this.email, password: this.password});
 }

}

Configured everything in the bootstrap phase just like imsingh did.
EXCEPTION: Error: Uncaught (in promise): You must include credentials to use this auth method.

I'll take a look into this.

Yep. This seems to be a bug. Probably an issue with reading the wrong overload. Will queue this up for the next release.

Closed with #132.

I'm getting this error again with the update to the 3.0 SDK.
Uncaught (in promise): You must include credentials to use this auth method.
I've also bootstrapped the app similar to above. This is my service:
export class UserService {
  constructor(private af: AngularFire) {
  }

  signUp(email: string, password: string) {
    var creds: any = {email: email, password: password};
    this.af.auth.createUser(creds);
  }

  login(email: string, password: string) {
    var creds: any = {email: email, password: password};
    this.af.auth.login(creds);
  }

}

Note that signUp() works, login() fails.

So this issue is resolved, I'm currently trying a simple username: password: providing both, setting up both provider and method as password in bootstrap, and I keep getting the "You must include credentials" error.
Anything I should be looking at?


Install script is not creating registry values

The install script for Windows is not creating registry values like the Installer on dot.net does. This is a problem because I'm programmatically using these registry keys to determine if .NET Core is installed and use the script if not but since the script is not creating the registry keys its repeating itself.
Could it be the installing script just downloads the zipped binaries and copy them to a folder instead of downloading the installer and installs it? In this case the docs need to tell that and there should be an option to download the installers instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2e484a9-5e0c-eb3e-1413-7b507c4fa07d
Version Independent ID: 5bc7caa5-f1c2-d7d5-fe02-80c65cca9672
Content: dotnet-install scripts - .NET Core CLI
Content Source: docs/core/tools/dotnet-install-script.md
Product: dotnet-core
Technology: dotnet-cli
GitHub Login: @mairaw
Microsoft Alias: mairaw

Thanks for your feedback @Symbai. @johnbeisner can you please comment on this issue about the install scripts?

@Symbai
The install scripts do not create a registry key values. You are correct, the install scripts just downloads the zipped binaries and copies them to a folder. If you need the registry key values, use the .NET installers.

Thanks for confirming @johnbeisner. Do you know what registry keys are we talking about here? I think it would be worth adding a note to the docs about this.

Maybe it shouldn't be called install script then but download script. It is misleading to have a install script near installers where the script only downloads a zip and copies files where the installers do different things.
Sadly I can't use the installer as the "install" script is the only way to programatically "install" .NET Core because the Installers are only available with hardcoded links and might be invalid in the future.
@mairaw: The installer creates many keys at HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\dotnet\... which gives information about the installed versions. I'm not sure if it creates more.
But it's not only the registry keys are missing. The whole "dotnet" command line API isn't available as well which should also be documented as this is often recommended as "fallback" detection method for retrieving the installed .NET Core versions.
So yeah, there is a huge difference between installers and script.

These also don't have uninstall entries, and by default go to the user folder instead of program files which are both different to the installer. Mixing the two creates a kind of Frankenstein monster install.


Revert "build(deps-dev): bump jasmine from 3.10.0 to 4.0.2"

Reverts hanazuki/node-jsonnet#108

jasmine@4 does not support nodejs@10


[Explicit Module Builds] Support explicit builds of packages witn inter-dependent Swift targets

Building a Swift module in Explicit Module Build mode requires passing all of its module dependencies as explicit arguments to the build command. Thus, building a SwiftPM package with multiple inter-dependent targets requires that each target’s build job must have its target dependencies’ modules passed into it as explicit module dependencies.
When planning a build that involves multiple Swift modules (targets), because planning takes place before any of the targets are built, the dependency scanning action will not be able to discover such modules. In such cases, we must provide the driver with information about all such external dependencies, including the path to where their compiled .swiftmodule will be located, once built, and a full inter-module dependency graph for each such dependency. Only then will the driver be able to create explicit-module build jobs for targets with dependencies.
This PR adds explicit package build handling by planning builds for all targets in a topological order and directly passing information about target's dependencies (module path and dependency graph) into the driver planning action.
This change works in tandem with the corresponding Dependency Scanner change in:
https://github.com/apple/swift/pull/33032
And a corresponding swift-driver change:
https://github.com/apple/swift-driver/pull/181
Both of which will have to be submitted first.
cc @nkcsgexi

@swift-ci please smoke test

@DougGregor, this mostly refactors the code that involves invoking the integrated driver during build planning. Could you please take a look?

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

It seems that the self-hosted CI jobs are not using the latest toolchain snapshot, they are using the machine's installed Xcode toolchain.
@neonichu, @aciidb0mb3r, do we specifically want this to test against some stable toolchain or would it be okay to switch the self-hosted CI to use the latest development snapshot? For example, this PR adds a test that needs to invoke the integrated driver, which nowadays is very tightly coupled to some recent swift changes.

My hope with the self hosted bot was to enable development with latest Xcode (including betas). Maybe it’s possible to make the test conditional somehow?

@swift-ci please smoke test


Design Get Started page

The app does not have a Get started page as per the old design. While still waiting for any new designs, I would like to design this page.
Please assign this issue to me.

test

@m0hit-kumar2 Hello I want to work on this issue

go ahead

Could you please asign this task to me . I would like to contribute on this issue


Shader Error when trying to run examples

Not sure if this is more glkit related but anyway, here we go:
Link Log:
WARNING: Output of vertex shader 'f_pos' not read by fragment shader
   [Condition of type SIMPLE-ERROR]

Restarts:
 0: [*CONTINUE] Return to the SDL2 main loop.
 1: [ABORT] Abort, quitting SDL2 entirely.
 2: [ABORT] abort thread (#<THREAD "SDL2 Main Thread" RUNNING {1006331B33}>)

Backtrace:
  0: (KIT.GL.SHADER:COMPILE-AND-LINK-PROGRAM NIL :VERTEX-SHADER " ..)
  1: (KIT.GL.SHADER::PROCESS-SOURCE #<KIT.GL.SHADER::SHADER-DICTIONARY-DEFINITION {1005D5A683}> #<KIT.GL.SHADER::PROGRAM-SOURCE :FILL-SHADER> #<KIT.GL.SHADER:PROGRAM {10063419B3}>)
  2: ((:METHOD KIT.GL.SHADER:COMPILE-SHADER-DICTIONARY (KIT.GL.SHADER::SHADER-DICTIONARY-DEFINITION)) #<KIT.GL.SHADER::SHADER-DICTIONARY-DEFINITION {1005D5A683}>) [fast-method]
  3: (SKETCH::INITIALIZE-ENVIRONMENT #<SKETCH-EXAMPLES:HELLO-WORLD {10063319B3}>)
  4: ((:METHOD INITIALIZE-INSTANCE :AFTER (SKETCH:SKETCH)) #<SKETCH-EXAMPLES:HELLO-WORLD {10063319B3}>) [fast-method]
  5: ((SB-PCL::EMF INITIALIZE-INSTANCE) #<unused argument> #<unused argument> #<SKETCH-EXAMPLES:HELLO-WORLD {10063319B3}>)
  6: ((LAMBDA NIL :IN INITIALIZE-INSTANCE))
  7: (SDL2::HANDLE-MESSAGE (#<CLOSURE (LAMBDA NIL :IN INITIALIZE-INSTANCE) {1006331D2B}> . #S(TRIVIAL-CHANNELS:CHANNEL :QUEUE #S(TRIVIAL-CHANNELS.QUEUE:QUEUE :HEAD NIL :TAIL NIL) :Q-CONDITION #<SB-THREAD:W..
  8: (SDL2::GET-AND-HANDLE-MESSAGES)
  9: (KIT.SDL2::MAIN-LOOP-FUNCTION #<SDL2-FFI:SDL-EVENT {#X0062CA90}> NIL)
 10: (KIT.SDL2::MAIN-LOOP)
 11: ((LAMBDA NIL :IN KIT.SDL2:START))
 12: (SDL2::HANDLE-MESSAGE (#<FUNCTION (LAMBDA NIL :IN KIT.SDL2:START) {1005B3C73B}>))
 13: (SDL2::SDL-MAIN-THREAD)
 14: ((LAMBDA NIL :IN BORDEAUX-THREADS::BINDING-DEFAULT-SPECIALS) #<unavailable lambda list>)
 15: ((FLET #:WITHOUT-INTERRUPTS-BODY-1002 :IN SB-THREAD::INITIAL-THREAD-FUNCTION-TRAMPOLINE))
 16: ((FLET SB-THREAD::WITH-MUTEX-THUNK :IN SB-THREAD::INITIAL-THREAD-FUNCTION-TRAMPOLINE))
 17: ((FLET #:WITHOUT-INTERRUPTS-BODY-335 :IN SB-THREAD::CALL-WITH-MUTEX))
 18: (SB-THREAD::CALL-WITH-MUTEX #<CLOSURE (FLET SB-THREAD::WITH-MUTEX-THUNK :IN SB-THREAD::INITIAL-THREAD-FUNCTION-TRAMPOLINE) {B24DCFB}> #<SB-THREAD:MUTEX "thread result lock" owner: #<SB-THREAD:THREAD "..
 19: (SB-THREAD::INITIAL-THREAD-FUNCTION-TRAMPOLINE #<SB-THREAD:THREAD "SDL2 Main Thread" RUNNING {1006331B33}> NIL #<CLOSURE (LAMBDA NIL :IN BORDEAUX-THREADS::BINDING-DEFAULT-SPECIALS) {1006331ADB}> (#<SB..
 --more--

This happens under OSX El Capitain with SBCL 1.3 or CCL 1.11 and an Intel Iris Pro GPU for all examples. If you need any more information, or feel that this should be reported to glkit, please let me know.

Hey, thanks for the report. I cannot reproduce the bug, but I think it's because your driver doesn't like having superfluous variables in shaders (f_pos in this case). The variable is removed now, so if the theory is right, the bug should be fixed. Can you clean your caches and pull?

Great, thank you very much. That fixed the issue!!!
One more little thing. When loading sketch/sketch-examples one little problem occures, but which can be bypassed easily:
The constant SDL2-FFI:+SDL-PATCHLEVEL+ is being redefined (from
4 to 3)
   [Condition of type DEFCONSTANT-UNEQL]
See also:
  Common Lisp Hyperspec, DEFCONSTANT [:macro]
  SBCL Manual, Idiosyncrasies [:node]

Restarts:
 0: [CONTINUE] Go ahead and change the value.
 1: [ABORT] Keep the old value.
 2: [TRY-RECOMPILING] Recompile autowrap and try loading it again
 3: [RETRY] Retry loading FASL for #<CL-SOURCE-FILE "sdl2-image" "autowrap">.
 4: [ACCEPT] Continue, treating loading FASL for #<CL-SOURCE-FILE "sdl2-image" "autowrap"> as having been successful.
 5: [RETRY] Retry ASDF operation.

Excellent.
That's a cl-sdl2-image / cl-sdl2 problem I think, just pulled the newest revision of cl-sdl2 and now I'm receiving the same error. Can you open an issue there?

Sure. This seems to unveil a problem with ClozureCL on OSX. With SBCL I get an situaiton which can by bypassed and after that the sinewave demo runs fine. I will file issues to sdl2/sdl2_image. Thanks for your effort. Great work by the way!

Sorry, try updating autowrap, which is sortof-necessary for cl-sd2's recent update.  Also, pull cl-sdl2 again if you haven't gotten the most recent update where .spec files are included in the .asd.  This fixes a number of issues.
The issue here is autowrap used defconstant for numbers, which causes issues when the minor version is bumped.  New version uses defparameter for everything.

I ditched my quicklisp directory, repulled all packages and it works for now without any issues so far. Thanks guys!
Best regards
Anes

On 08 Feb 2016, at 20:49, Ryan Pavlik<EMAIL_ADDRESS>wrote:
Sorry, try updating autowrap https://github.com/rpav/cl-autowrap, which is sortof-necessary for cl-sd2's recent update. Also, pull cl-sdl2 again if you haven't gotten the most recent update where .spec files are included in the .asd. This fixes a number of issues.
The issue here is autowrap used defconstant for numbers, which causes issues when the minor version is bumped. New version uses defparameter for everything.
—
Reply to this email directly or view it on GitHub https://github.com/vydd/sketch/issues/4#issuecomment-181492488.


Force some known column widths to prevent truncation of others

Port/count won't exceed a certain width so slim those down to free up
space for the IPs.
This can be extended to CPU/memory in the future but that needs a little
more refactoring in the number renderers
Fixes #1532
Fixes #1492

LGTM


Added Role Id , Image URL in Settings

[Added] TZ for Heroku deployment (Time Zone for Updated message)
[Added] Role ID for Configuring Bot (Also works with Heroku Deployment).
[Added] Image URL for Configuring Maps Locations (If defined in settings than only it will be used but prioritized by servers file and Also works with Heroku Deployment).
NOTE : ROLE ID has to be integer format, so replace 123 with role id that can be obtained by right clicking on role in Server Settings and using Copy ID settings. Do not use any type of "" or '' with it.

Thanks for your contribution!


fix(projects): Fix project creation and deletion.

Current coverage is 53.95% (diff: 83.33%)

Merging #203 into dev will increase coverage by 0.78%

@@                dev       #203   diff @@
==========================================
  Files           157        158     +1
  Lines          3297       3303     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1753       1782    +29
+ Misses         1544       1521    -23
  Partials          0          0

Powered by Codecov. Last update 263dd73...a8432d7


EPIC: Prisma and Codesandbox

WIP: This issue is still evolving
This issue tracks all the sub-issues that are required to make Prisma and Codesandbox gel together nicely.
Prisma issues:
Faster photon generation: https://github.com/prisma/photonjs/issues/264 ✅
CSB issues that impact Prisma
File synchronization limit: https://github.com/codesandbox/codesandbox-client/issues/2896 ✅
node_modules API sync: https://github.com/codesandbox/codesandbox-client/issues/2897 ⚠
CSB issues that do not impactPrisma:
Tooltip contents are blocked by editor tab: https://github.com/codesandbox/codesandbox-client/issues/1910 ✅
Animation flickering: https://github.com/codesandbox/codesandbox-client/issues/2895 ✅
Unclassified issues:
Core dump issue: https://github.com/prisma/prisma2/issues/783 ✅

Moving this to my passively tracked stuff to get clear up assignments.

The only missing feature was Prisma client autocompletion but I can confirm that autocompletion also works with the experimental "Use container language server" option enabled.


ANDROID SDK , NO RESULT (bad json response)

hello ,
i have successfully migrate the data from parse to mongodb using the tools from parse ,i also installed parse server locally and its running , i have tested a query in terminal its working. However , when i tried the android sdk the app didn't show any results it show an error which says bad json response
.

the result from the query

the shell script which a run to query

android configuration for local parse

the query (same as the shell)

android manifest.
the error

please help

i had the same problem.
try to add '/' on the end of url (http://localhost:8080/parse/)

@pccrazy Please try @theolm 's suggestion and let me know if that does not fix things.

I don't think localhost is the correct hostname because it refers to the device on which the code is running.
If you are running your app in the Android emulator you should use <IP_ADDRESS> instead of localhost.

That is a good point... hehe, I didn't realize he's running it on Android.

@gfosco @rciovati @theolm  thanks guys i will try it now , i will let you know what happens

@gfosco @rciovati @theolm hi guys i have tried it , it seems i am having issues with my localhost so i upload the app in google app engine then i just added / in the last last of url and it did work finally thank you too much i appreciate it
here is an ex of google app engine url
https://.appspot.com/parse/

for android the server link https://localhost:1337/parse/1/
this worked for me


Installed modules scope bug

Solved issue about classes bound in a parent scope not being injected using the right scope.
Also updated the internal provider structure and naming:
What is a internal scoped provider? A provider that is attached to one scope AND uses always the same scope create instances?
That's not true anymore, as bound classes (through a module installation) are attached to one scope BUT DO NOT always use the same scope to create instances.
So from now on, all internals providers use the class InternalProviderImpl and they are considered scoped if they are attached to one scope. That happens for 2 cases:

Bound classes
Injected classes not bound but with scope instances annotations

Coverage decreased (-0.1%) to 85.47% when pulling 3787d50dd0b82c404eb89b20ad2c80d276db045d on installed_modules_scope_bug into 07b9bdff7aa3502600ffebb2e70b80df13927a0c on master.

Coverage decreased (-0.2%) to 85.402% when pulling f281872584f6747c0752b18927e2c04e4d0ec280 on installed_modules_scope_bug into 07b9bdff7aa3502600ffebb2e70b80df13927a0c on master.

Coverage decreased (-0.2%) to 85.413% when pulling feeec1d4aa9182452a3e603b6bce4305fc6fa9ad on installed_modules_scope_bug into 07b9bdff7aa3502600ffebb2e70b80df13927a0c on master.

I see so the problem is that we could be binding providers in a scope via a module, but this is actually an unscoped provider in the old terminology... right ? It would always create instances in the scope it was bound to but it should actually use the scope it is used in...

Good PR. Just a few comments... the Scope scope = factory.getTargetScope is probably useless at the beginning of the PR. Merge it when done, I will have to deal with the changes..bouhh :)
Good catch though. :)

UPDATE : DO NOT MERGE. I THINK THIS PR IS DOING THE SAME MISTAKE AS LAST TIME...
If we have  a module that is installed in the application scope : bind(IFoo.class).to(Foo.class), it is normal that all instances of Foo will be created in the application scope. This is not a bug, this is the expected behavior.
Otherwise :

Why would it be installed in the application scope otherwise ?
What is the difference between installing it in this scope or a lower scope ?
What happens if Foo needs  a dependency in a a sub-scope ?
What is the relationship with scope annotation annotated classes ?

Let's have a chat tomorrow.


Data saved is not persistent on the disk

I have build and run the example project in this repository. Data is being stored successfully, but it is not persistent. When I go back the page and then come again, the saved data is missing. Please help me what am I missing.
Demo Video

Also if you can specify, where is the default.realm file is put then it will be help to browse that with realm browser. It used to be in the app's document directory in react native but I did not find any realm file in document directory of flutter app in simulator.

On the RealmProvider set a Configuration with a persistant name or ID.
@override   void initState() {     super.initState();     final configuration = Configuration(inMemoryIdentifier: "your_persistan_ID"); //HERE     realm = Realm.open(configuration);   }

This solution worked. Thank you very much.

On the RealmProvider set a Configuration with a persistant name or ID.
@override void initState() { super.initState(); final configuration = Configuration(inMemoryIdentifier: "your_persistan_ID"); realm = Realm.open(configuration); }

I did this but even after adding the persistence id it seems it is storing in memory so after killing the application data is no longer available. Am I missing some configuration here?


Dsl/moist/radiation coupling - RadCouple Port in pyMoist

Ticket [NDSL] Radiation Coupling #937
do_qa not implemented in radiation_coupling.py
Waiting on up to date testing data
Tests fail for CLDREFFL (5.55%) and CLDREFFI (5.08%)
Max Error set at 1e-9

0 diff explainer: this is related to the port of the Moist physics to the NDSL stack, it's execution and compilation is deactivated by default


Hostname invalid error when running on localhost as non-admin

I am trying to automate starting winappdriver.exe by spawning a background process from Ruby in my Cucumber script. No problem with spawn, as I have tested using it with other commands.

The first problem is that I have to run winappdriver.exe as administrator. I looked into runas.exe but that still requires input, so it's bad for scripting. There are other reasons not to chase this.
The alternative is to use "localhost" as the host, since winappdriver.exe tells me I can run only as localhost without admin privileges.

winappdriver.exe localhost 4723/wd/hub
However, when I try to create the Appium webdriver, I get the following error:
  unexpected response, code=400, content-type="text/html"
  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
  <TITLE>Bad Request</TITLE>
  <META HTTP-EQUIV="Content-Type" Content="text/html; charset=us-ascii">

Bad Request - Invalid Hostname

HTTP Error 400. The request hostname is invalid.

   (Selenium::WebDriver::Error::WebDriverError)

Now if I just start winappdriver manually as administrator using <IP_ADDRESS> it works fine...
winappdriver.exe <IP_ADDRESS> 4723/wd/hub
..but the problem is that it's not great for fully automating my tests (starting and stopping winappdriver between my Cucumber runs would be nice, instead of the choice of either manual or always on).
Seeing that localhost and <IP_ADDRESS> are essentially the same, I did not expect an error when using one but not the other.
Thanks.

Hi @jsbakker
I'm a little confused as to why you need to run winappdriver.exe <IP_ADDRESS> 4723/wd/hub as administrator and not as a regular user?
Also, if you launch an appium test, appium should launch WinAppDriver for you.

@khouzam This is the output if I run as non-admin:
C:\Users\jbakker>winappdriver.exe <IP_ADDRESS> 4723/wd/hub
Windows Application Driver listening for requests at: http://<IP_ADDRESS>:4723/wd/hub

Access denied: attempting to add Address 'http://<IP_ADDRESS>:4723/wd/hub'. Run as administrator to listen on an hostname other than localhost, or to listen on port 80.

Failed to initialize: 0x80004005

After a Windows restart I was able to run it once successfully, but after stopping the server (by pressing ENTER key to exit), I keep getting this message when running as non-admin.

Thanks for the followup @jsbakker
Can you confirm which build of WinAppDriver you're running?

I'm pretty sure I downloaded the 1.0 RC .msi from the releases page. The file version of the .exe shows 1.0.1708.10001.

Please reopen if this issue persists with the latest WinAppDriver v1.1 release.

@hassanuz I am able to start a session without admin mode with <IP_ADDRESS> but I am not able to remotely connect to it. I can connect properly when I use the ip address, but unfortunately, using IP needs elevated admin permissions. If I am running in a CI/CD env, I will not be able to get elevated permissions. How do we bypass this?


[master] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc knative-sandbox/source-wg-leads lberk
/assign knative-sandbox/source-wg-leads lberk
Produced via:
./hack/update-deps.sh --upgrade --release v0.21
./hack/update-codegen.sh

Details:
bumping knative.dev/eventing d395f6f...b10d720:
  > b10d720 [# 4744] Bump test zipkin version (# 4755)
  > 2b95f45 upgrade to latest dependencies (# 4747)
bumping knative.dev/pkg 5bb97df...75d66b5:
  > 75d66b5 preserve the stable webhook logger names we had before (# 1994)
  > 22f4898 upgrade to latest dependencies (# 1990)

/lgtm
/approve
/ok-to-test

/lgtm
/approve
/ok-to-test


Comment & Share Functionalities not working

Hey Sergio,
first of all: thank you so much for this enhanced Threads app clone!!
I just finished the AppStuff tutorial and was hoping to find some more material on GitHub... which I did 😁
I was wondering if the comment & share functionality is already implemented and just not pushed to remote. You mention it in the readme but the ThreadCell's onCommentTap and onRepostTap don't include any functionality. Maybe you already implemented it and it's just not pushed yet. Just hoping. I just started learning SwiftUI a couple days ago so I'm still getting used to everything.
Gracias y saludos!

Hi Philip, thanks for your message. I'm glad to hear that you found this repository useful. As for the features you mentioned, they are still under development. I haven't completed them yet, nevertheless, in this project I spent a lot of time implementing a better architectural approach rather than adding a bunch of features.
I'll let you know as soon as I have any news on this.
Regards!


Stop src/render from compiling via tsc

Currently all the files in src/render are being built by both webpack and tsc. This makes no sense considering they for the render process only.

Changing the tsconfig file results in editor intellisense no longer working for project. When packaging the product consider removing the files, although the difference in insignificant


Replace uses exec_program with execute_process

As of CMake 3.28, uses of exec_program produce a deprecation warning suggesting to replace it with execute_process.
With this pull request I replaced the occurrences of exec_program with the equivalent invocation of execute_process.
See https://cmake.org/cmake/help/latest/policy/CMP0153.html

Thank you for your contribution!


Add support for HFSS-PI solution setups

Description of the feature
Support for creating HFSS-PI solution setups in 2024 R1 and later would be helpful to test this beta feature.
Steps for implementing the feature
No response
Useful links and references
No response

@isaacansys I moved the issue to pyedb after discussing with @svandenb-dev .
Please close it if it is solved already.


[webview_flutter] Hybrid Composition fails to dispose native webview

After refactoring webview_flutter with Hybrid-Composition as below, native webview fails to dispose when Navigator.pop
branch: https://github.com/Sunbreak/plugins/tree/feature/hybrid-composition
commit: https://github.com/Sunbreak/plugins/commit/a80ac746c9e4db53a8c113640c4bb923911cabbf
Screenshot of chrome://inspect#devices:

Steps to Reproduce

git clone https://github.com/Sunbreak/plugins -b feature/hybrid-composition
cd packages/webview_flutter/example
flutter run
press the floating action button several times and press back button
open chrome://inspect#devices to check the native webview instance

Expected results:
Webview instances in chrome://inspect#devices are destroyed after Navigator.pop, as the non-Hybrid webview_flutter does.
Actual results:
Webview instances in chrome://inspect#devices are keep-alive

Logs
flutter run
Launching lib/main.dart on Nexus 5 in debug mode...
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                         2.5s
✓ Built build/app/outputs/flutter-apk/app-debug.apk.
Waiting for Nexus 5 to report its views...                           9ms
Syncing files to device Nexus 5...                                 510ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Nexus 5 is available at: http://<IP_ADDRESS>:53022/AjNd4rnOuAU=/
I/WebViewFactory( 5405): Loading com.google.android.webview version 85.0.4183.101 (code 418310150)
I/cr_LibraryLoader( 5405): Loaded native library version number "85.0.4183.101"
I/cr_CachingUmaRecorder( 5405): Flushed 5 samples from 5 histograms.
W/chromium( 5405): [WARNING:dns_config_service_posix.cc(342)] Failed to read DnsConfig.
W/cr_media( 5405): Requires BLUETOOTH permission
E/libEGL  ( 5405): validate_display:255 error 3008 (EGL_BAD_DISPLAY)
I/flutter ( 5405): Page started loading: https://flutter.dev/
I/OpenGLRenderer( 5405): Initialized EGL, version 1.4

Application finished.
wangkun@C02CN0H4MD6V example %
wangkun@C02CN0H4MD6V example % ~/flutter/flutter-1.20.x/bin/flutter run
Launching lib/main.dart on Nexus 5 in debug mode...
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                         2.7s
✓ Built build/app/outputs/flutter-apk/app-debug.apk.
Waiting for Nexus 5 to report its views...                           8ms
Syncing files to device Nexus 5...                                 525ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Nexus 5 is available at: http://<IP_ADDRESS>:54345/3Y3v2Oh5bKI=/
I/WebViewFactory( 7165): Loading com.google.android.webview version 85.0.4183.101 (code 418310150)
I/cr_LibraryLoader( 7165): Loaded native library version number "85.0.4183.101"
I/cr_CachingUmaRecorder( 7165): Flushed 5 samples from 5 histograms.
W/chromium( 7165): [WARNING:dns_config_service_posix.cc(342)] Failed to read DnsConfig.
E/libEGL  ( 7165): validate_display:255 error 3008 (EGL_BAD_DISPLAY)
W/cr_media( 7165): Requires BLUETOOTH permission
I/flutter ( 7165): Page started loading: https://flutter.dev/
W/VideoCapabilities( 7165): Unrecognized profile<PHONE_NUMBER> for video/avc
I/VideoCapabilities( 7165): Unsupported profile 4 for video/mp4v-es
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336961
D/SurfaceUtils( 7165): set up nativeWindow 0x9a0d9808 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x9a0d9808 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/flutter ( 7165): Page started loading: https://flutter.dev/
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336962
D/SurfaceUtils( 7165): set up nativeWindow 0x90fd5f08 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336963
D/SurfaceUtils( 7165): set up nativeWindow 0x90fd5f08 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x97147b08 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x97147b08 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
I/flutter ( 7165): Page finished loading: https://flutter.dev/
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336964
D/SurfaceUtils( 7165): set up nativeWindow 0x9e8b8a08 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x9e8b8a08 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/flutter ( 7165): Page finished loading: https://flutter.dev/
I/flutter ( 7165): Page started loading: https://flutter.dev/
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336965
D/SurfaceUtils( 7165): set up nativeWindow 0x97c54908 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x97c54908 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/chromium( 7165): [INFO:CONSOLE(263)] "The deviceorientation events are blocked by feature policy. See https://github.com/WICG/feature-policy/blob/master/features.md#sensor-features", source: https://www.youtube.com/s/player/12237e3d/player_ias.vflset/en_US/base.js (263)
I/flutter ( 7165): Page finished loading: https://flutter.dev/
I/art     ( 7165): Background partial concurrent mark sweep GC freed 54328(2MB) AllocSpace objects, 8(536KB) LOS objects, 28% free, 40MB/56MB, paused 705us total 102.257ms
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
I/cr_MediaCodecBridge( 7165): create MediaCodec video decoder, mime video/avc
I/OMXClient( 7165): Using client-side OMX mux.
I/MediaCodec( 7165): [OMX.qcom.video.decoder.avc] setting surface generation to 7336966
D/SurfaceUtils( 7165): set up nativeWindow 0x9e8c3c08 for 1080x820, color 0x7fa30c04, rotation 0, usage 0x42002900
D/SurfaceUtils( 7165): set up nativeWindow 0x9e8c3c08 for 1088x832, color 0x7fa30c04, rotation 0, usage 0x42002900
W/cr_MediaCodecBridge( 7165): Releasing: OMX.qcom.video.decoder.avc
W/cr_MediaCodecBridge( 7165): Codec released
E/chromium( 7165): [ERROR:aw_gl_functor.cc(100)] Received unexpected kModeProcessNoContext
E/libEGL  ( 7165): call to OpenGL ES API with no current context (logged once per thread)

Application finished.

flutter analyze
Analyzing webview_flutter...

   info • `Future` results in `async` function bodies must be `await`ed or marked `unawaited` using `package:pedantic` •
          example/lib/main.dart:98:9 • unawaited_futures
   info • Dead code • example/lib/main.dart:106:5 • dead_code

2 issues found. (ran in 2.6s)

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.269, on Mac OS X 10.15.4 19E287 x86_64, locale en)
    • Flutter version 1.22.0-10.0.pre.269 at /Users/wangkun/flutter/flutter-1.20.x
    • Framework revision 51fa704642 (8 days ago), 2020-09-19 11:27:04 -0700
    • Engine revision 4b8477d115
    • Dart version 2.10.0 (build 2.10.0-142.0.dev)
    • Pub download mirror http://dart-pub.byted.org
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/wangkun/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/wangkun/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/wangkun/Library/Android/sdk
    • Java binary at: /Users/wangkun/Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.2

[✓] Android Studio (version 4.0)
    • Android Studio at /Users/wangkun/Applications/Android Studio.app/Contents
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Users/wangkun/Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 49.0.4
    • Dart plugin version 202.7206

[✓] VS Code (version 1.49.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (1 available)
    • Nexus 5 (mobile) • 061f18eff0ec871a • android-arm • Android 6.0.1 (API 23)

• No issues found!

Issue replicable on latest stable (1.20.4)
The webview instances persists.

flutter doctor -v
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.4 19E2269, locale en-IN)
    • Flutter version 1.20.4 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision fba99f6cf9 (13 days ago), 2020-09-14 15:32:52 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (1 available)
    • SM A260G (mobile) • 5200763ebcfa861f • android-arm • Android 8.1.0 (API
      27)

• No issues found!

cc @blasten @jason-simmons I cross-referenced another issue that may be similar to this one. If the lifecycle of plugins in affected hybrid-composition, we should investigate it ASAP.


StyleSheetManager target prop not injected styles in the node

Currently I'm running this on latest CRA with ant design.
My main intention is to clone a node with style element inside to be used on third party websites.
The target prop does not respect any other node outside of document.body. Is it because it's outside of React influence? Would be great if I could inject the styles as children because targeting them with querySelector is not optimal.
Side note. Grabbing the style node on localhost worked fine, but when I build and deploy CRA, style element is empty, but the styling is applied.

There's no reproduction or details here for me to look at it respond to unfortunately. But maybe look at my response for this issue: https://github.com/styled-components/styled-components/issues/3548
Another note, the style element may not be empty. Check it's CSSOM rules, which the browser will not display as text in the devtools.
Also, if it works with a query selector, there's a good chance you simply haven't passed it a DOM element references in your regular non-queried variant of your code


Add Model option

First off, I was thinking about wanting a feature like this for a while, I'm glad you made it!
So, feature request: right now the controllable options are limited - in particular I'd love if you add an option to set the model by name.
For example, I'd want an SD 2.1 preset that instantly changes model to SD 2.1 and width/height to 768.
There's a lot of other potentially useful options worth adding as well, so I'll just reference my own Infinite-Grid extension's option list for your consideration - https://github.com/mcmonkeyprojects/sd-infinity-grid-generator-script/blob/master/scripts/infinity_grid.py#L147-L173
Feel free to use it as a reference for ideas and/or code for adding new options.

I'm hesitant to add too many fields to the presets since it reduces their flexibility.
If I could find a way in the code to not update components if they are omitted from the config then then I'd consider it, but I can't figure out how to do that.

I tried adding the model as a config preset with the new "Add tracked fields..." button, but those top row buttons are actually part of the web ui settings and are out of scope for the config preset dropdown to manipulate with the extension is implemented.
Adding the model, or anything else in the top row of the web ui, would require custom attention that this extension isn't designed for.

@Zyin055 Personally I don't have much use for model swapping, but if you want, you could connect certain preset keys to lambda functions, which are then called along with a value change. It's a fairly simple and dynamic method, though naturally it would still require extra research on webui's infrastructure per such preset. I've used that method in regional to apply loading & colour correction to the mask preset.


What‘s the difference of the final metrics log between test.py and eval.py???

As described in the title, I found that the metrics obtained after running test.py are different from those obtained after running eval.py, but I believe they should be the same. Why is this happening?

hello,Have you figured out why the output of test.py and eval.py is different

hello,Have you figured out why the output of test.py and eval.py is different

I don't know yet

I suppose the results in test.py are the mean values of all registration pairs, and the results in eval.py are the mean values of all scenes (first calculate the mean values of each scene, then calculate the mean values of all scenes)


Fix typo/language

Alternatively:

Tried to pack incomplete...

PS: Afaik the newline at end of file was created by the GH in-page editor, hope you don't mind.

Thx


Submitting form by pressing Enter in a form field

Hi,
I think there is an issue with submitting forms when pressing enter in a form field when there are two buttons (a submit button and a cancel button). I was able to reproduce this issue using the FullForm example from the docs.
If the user presses enter within a form, the form is not always submitted. Instead the onClick action associated to the first button defined within the form's DOM will be executed, i.e. if the submit button is defined before the cancel button, pressing enter will submit the form. However, if the cancel button is defined before the submit button, pressing enter will 'cancel' the form, i.e. execute the onClick action associated with the cancel button.
This issue can be observed by changing
<Footer>
  <Menu direction="right">
    <Button label="OK" primary={true} strong={true} onClick={this.props.onSubmit} />
    <Button label="Cancel" onClick={this.props.onCancel} />
  </Menu>
</Footer>

to
<Footer>
  <Menu direction="right">
    <Button label="Cancel" onClick={this.props.onCancel} />
    <Button label="OK" primary={true} strong={true} onClick={this.props.onSubmit} />
  </Menu>
</Footer>

in the FullForm sample. (I have also added log messages to FormDoc to see which function is executed).
I know this is not really a grommet specific issue, but maybe a hint in the documentation would be useful because in my opinion adding the primary attribute to a button suggests that the action associated with a primary button will be the default action when hitting Enter while filling out the form.
I suppose a solution with <input type="reset"> and <input type="submit"> as in this fiddle is not a feasible solution for grommet because it would require dedicated "form buttons". That's why I think a hint in the documentation would be sufficient.

Fixed


Add support for aliases of primitive types

Adds conversion support properties using types that are just names (and validation rules) for simple primitive types, including conversion to and from those primitive types where required.
Adds support for assignments between properties that are KnownResourceReference.
A single handler for every case where we are copying from an optional type, reducing the number of handlers required, helping to avoid a combinatorial explosion of handlers.
Also

Changes to avoid use of local variables in generated code in some cases
Enhance astbuilder.Statements() so it filters out nil values
Fixes a bug in assignToEnumerationType where the expression passed wasn't being used
Add clone methods for KnownResourceReference and ResourceReference
A bunch of code gardening improvements to logging, comments and code clarity
Enhances zeroValue() to support more than just primitive types

~Requires #429 to be merged first.~ PR #429 has been merged.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5d30857). Click here to learn what that means.
The diff coverage is 66.89%.

@@            Coverage Diff            @@
##             master     #433   +/-   ##
=========================================
  Coverage          ?   62.45%
=========================================
  Files             ?      145
  Lines             ?     9931
  Branches          ?        0
=========================================
  Hits              ?     6202
  Misses            ?     3176
  Partials          ?      553

Impacted Files
Coverage Δ

...ack/generated/pkg/genruntime/resource_reference.go
45.45% <0.00%> (ø)

hack/generator/pkg/astmodel/allof_type.go
64.70% <0.00%> (ø)

hack/generator/pkg/astmodel/array_type.go
78.57% <0.00%> (ø)

hack/generator/pkg/astmodel/errored_type.go
25.00% <0.00%> (ø)

hack/generator/pkg/astmodel/flagged_type.go
92.45% <0.00%> (ø)

hack/generator/pkg/astmodel/map_type.go
85.00% <0.00%> (ø)

hack/generator/pkg/astmodel/object_type.go
73.84% <0.00%> (ø)

hack/generator/pkg/astmodel/oneof_type.go
56.75% <0.00%> (ø)

hack/generator/pkg/astmodel/resource.go
73.43% <0.00%> (ø)

...erator/pkg/astmodel/storage_conversion_function.go
73.37% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d30857...e8262f0. Read the comment docs.


Added a Django Project

Closes #28

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[x ] I have updated the documentation accordingly.
[ x] I have added a new Project.
[x ] I have added a README.md file for the Project.
[x ] The title of my pull request is a short description of the requested changes.

Screenshots

My bad i'll hide it

any idea why's it still showing failed? I changed the django secret key to a github secret variable

any idea why's it still showing failed? I changed the django secret key to a github secret variable

no idea can you raise a new PR

ok

I'll close this one and open another pr


🐛 [cloud_firestore] Invalid argument error when querying using a WithConverterDocumentReference

Bug report
Describe the bug
When trying the following query (using object names for clarification):
Query.where('fieldname', isEqualTo: DocumentReference<Object>).snapshots()
I get the following ArgumentError:
Invalid argument (dartObject): Could not convert: Instance of '_WithConverterDocumentReference<Team>'
I am querying a collection group where a field is equal to a document reference. In firestore the collection group documents have the field with the reference type.
I am using withConverter() in this project for both the collection group and the document reference I am using in the query.
Steps to reproduce
Steps to reproduce the behavior:
The complete query code is:
FirebaseFirestore.instance
         .collectionGroup(this._name)
         .withConverter<T>(
          fromFirestore: this._fromFirestore,
          toFirestore: this._toFirestore
        ).where(
            'team',
             isEqualTo: FirebaseFirestore
                .instance.collection('races').doc('storm the wall 2021')
                .collection('teams')
                .withConverter<Team>(
              fromFirestore: (snapshot, _) => Team.fromJson(snapshot.id, snapshot.data()!),
              toFirestore: (team, _) => team.toJson(),
            ).doc(id)
          ).snapshots()

Expected behavior
I expected to get a snapshot of the query results.
Sample project
It would be hard to show a sample project since there are a lot of different classes and files in play, but here is the repo: https://github.com/JPGarCar/stw_timing_web_app/tree/firebase-update
The reference I am searching for has a class of Team.dart problem is in line 40,
which extends FirestoreCollectionObject.dart which extends FirestoreObject.dart
The collection group I am searching on has a class of RunCollection.dart
which extends FirestoreCollectionGroup.dart

Additional context
I used debug console to find the problem in line 40 of Team.dart.
When I change the query object being searched to something else, like a string, there are no errors thrown.
Thank you in advance, and let me know if you need more access or more information!

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[√] Flutter (Channel beta, 2.3.0-24.1.pre, on Microsoft Windows [Version 10.0.19042.1052], locale en-CA)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.9.0)
[√] Android Studio (version 4.2.0)
[√] VS Code (version 1.57.1)
[√] Connected device (3 available)

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.14.0-188.5.beta
Flutter SDK 2.3.0-24.1.pre
race_timing_app 1.0.0+1

dependencies:
- cloud_firestore 2.3.0 [cloud_firestore_platform_interface cloud_firestore_web firebase_core firebase_core_platform_interface flutter meta]
- cupertino_icons 1.0.3
- date_time_format 2.0.1
- file_picker 3.0.3 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface]
- firebase_auth 2.0.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.3.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- spreadsheet_decoder 2.0.0 [archive xml]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- archive 3.1.2 [crypto path]
- async 2.7.0 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.2.0
- clock 1.1.0
- cloud_firestore_platform_interface 5.2.0 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.2.0 [cloud_firestore_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.15.0
- crypto 3.0.1 [collection typed_data]
- fake_async 1.2.0 [clock collection]
- firebase_auth_platform_interface 5.0.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 2.0.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.0.1 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_plugin_android_lifecycle 2.0.2 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- intl 0.17.0 [clock path]
- js 0.6.3
- matcher 0.12.10 [stack_trace]
- meta 1.4.0
- path 1.8.0
- petitparser 4.1.0 [meta]
- plugin_platform_interface 2.0.0 [meta]
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.0 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0
- xml 5.1.2 [collection meta petitparser]

Hi @JPGarCar
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/6369.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Does not appear to support WP8.1

I am getting the following error when installing the package for a WP8.1 app:
 Error		Could not install package 'lightbuzz-smtp 1.8.0'. You are trying to install this package into a project that targets 'WindowsPhoneApp,Version=v8.1', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

@zipswich Please take a look at http://stackoverflow.com/questions/24816227/send-email-from-windows-phone-8-1 or https://blogs.msdn.microsoft.com/paraswadehra/2014/08/21/how-to-send-email-from-your-windows-phone-8-1-app/
This lib is more oriented for win10 uwp (I think)


Logic App Service Filter issue

Package Name:    azure-mgmt-logic
Package Version:  10.0.0
Operating System: Windows
Python Version:  3.9.9

Describe the bug
When using a filter to retrieve data from Azure I get an error while iterating over the iterator object returned. If re-running the code the error can occur at different stages of the iteration process (e.g. sometimes it fails at the 3rd iteration sometimes at the 29th). Everything works well if no filter is used.
To Reproduce
Example 1 workflow_runs:
response_runs = logic_app_client.workflow_runs.list(workflow_name=workflow, resource_group_name=resource_group, filter = "startTime gt 2022-09-23T15:02:16.078315Z")
for i, run in enumerate(response_runs):
   print(i)

Error:
HttpResponseError: (InvalidQueryFilter) The provided query filter 'starTime gt 2022-09-23T15:02:16.078315Z' is not valid or not supported. Code: InvalidQueryFilter Message: The provided query filter 'starTime gt 2022-09-23T15:02:16.078315Z' is not valid or not supported.

Example 2 workflow_trigger_histories :
trigger_histories =  logic_app_client.workflow_trigger_histories.list(resource_group_name=resource_group, trigger_name= trigger, workflow_name=workflow, filter="Status eq 'Succeeded'")

for i, trigger_histroy in enumerate(trigger_histories):
    print(i)

Error:
HttpResponseError: (InvalidQueryFilter) The provided query filter 'Status eq 'Succeeded',Status eq 'Succeeded'' is not valid or not supported.
Code: InvalidQueryFilter
Message: The provided query filter 'Status eq 'Succeeded',Status eq 'Succeeded'' is not valid or not supported.

Expected behavior
Return filtered data.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Logic App:0.3111548,Storage:0.13452737,Cosmos:0.078935064'

Hi @jernejknechtl
We have released a new version about azure-mgmt-logichere, the new version can solve your problem, please update azure-mgmt-logic to the latest version and try again.

Thank you! This seems to solve the problem.


fix: basic mime type handling for prerendered pages in preview

closes https://github.com/sveltejs/kit/issues/10839

This looks to do more than just fix the MIME types for prerendered pages in vite preview - it's also switching MIME lookup libraries. I see the one this is switching to is by Luke (is this what's used internally by sirv?), but still, could changing this break anything for anyone?

Yeah, I thought I'd swap it out to reduce the number of dependencies since we're already pulling in mrmime via sirv. I feel like it'd be pretty unlikely to break anything because if a mime type is recognized by mime, but not mrmime, then it will be unable to be served by sirv today anyway


training collapsed cifar10.3@40-1 with 4 GPUs

Dear authors,
any possible ideas result in following training collapsed?
docker environment: (TF 1.14.0) https://docs.nvidia.com/deeplearning/frameworks/tensorflow-release-notes/rel_19.10.html#rel_19.10
CUDA_VISIBLE_DEVICES=0,1,2,3 python fixmatch.py --filters=32 --dataset=cifar10.3@40-1 --train_dir ./experiments/fixmatch

Thanks

Hello, thanks for reporting an issue. We did most of our developments using 1 GPU. We also didn't witness a training collapse before even with multi-GPU training, but need to mention that we didn't experiment as thoroughly with 4 GPUs.
In the meantime, we made some code changes to better support multi-GPU training. Would you please sync your branch and try re-running the code to see if the problem still exist?

@kihyuks problem solved! is that related to batchnorm?

compare between 1gpu and 4gpu in this run:
In same train_step, 4gpu speedup by 2x than 1 gpu.
however, seems 1gpu converged slower but better.

Awesome! Yes, the recent fix is related to batch norm:
https://github.com/google-research/fixmatch/blob/bb377cb012543ce094cda114357184bc9b55a830/fixmatch.py#L99-L101
https://github.com/google-research/fixmatch/blob/bb377cb012543ce094cda114357184bc9b55a830/libml/utils.py#L225-L232
As mentioned in the paper (see Table 4), a variance induced by randomness of training is high when using 40 labeled training examples, so I would consider two results with 1 or 4 gpus are on a par with each other accuracy-wise.


Added effecting hover effect on the icons

Closes: #[#152]
Description of Changes
-Added color to the social icons
-Added colors on the hover effect
Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[ ] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Original
Updated

![Original screenshot](

) | ![Updated screenshot](
https://github.com/ZeroOctave/resource-gallery/assets/83147410/35b511d6-b1bd-4c0b-8872-715f0f276d47
) |
Please provide any necessary screenshots to illustrate the changes made.

It looks good, can you try replacing the languages/frameworks logo, like they should be displayed in black color but when hover on them they should reveal the original logo image. You can achieve this by using a CSS property known as mix-blend-mode. Please try to go for it.

I tried this thing but it's not working, I don't know the reason but I tried


Implement search results page

Based on designs in #83

I noticed we don't have a story for this and it's in progress so created this.

Initial implementation completed: test2

Moving it to in Progress: Making Changes suggested by Daniel

implemented on demand display of search criteria

@Daniel-silve1ra can you take a look and feedback for Vino? The rest of us can take a look too.

Added styles to tools button

Hi @Vino-S ,
Great progress on the page styling of the results page so far. We are getting closer to the original design. Thanks for your hard work on this
There are still a few things which aren't quite matching the original design, though. I've made a google doc which outlines what these are. In the doc I've written some pre-prod code. I've tested most of the code through Chrome dev tools so I feel confident they should work and should facilitate things on your end.
Please feel free to put an appointment in my calendar if you have any questions about it or need me to clarify anything.
The doc
I'll be reviewing the detailed results page and get that to you by the end of the weekend.
Again, thanks for your help on this.
Daniel

Updated some of the changes suggested by Daniel in test2.
Not Sure about the functionality of Jump To. Any example will be helpful

@Daniel-silve1ra can you provide an example for @Vino-S?

@Daniel-silve1ra @Vino-S  is this story still required or can we close?

Will get to this this week
On Mon, 29 Mar 2021, 17:54 Rich Pomfret, @.***> wrote:

@Daniel-silve1ra https://github.com/Daniel-silve1ra @Vino-S
https://github.com/Vino-S is this story still required or can we close?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FreeUKGen/FreeBMD2/issues/256#issuecomment-809541471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AORIDHLADXA6TZPDATTFA43TGC5GBANCNFSM4O4PZTYQ
.

@Daniel-silve1ra any update or opportunity to look at this?

In the absence of any further noted feedback or work, we shall close this.


(experimental) Enable Swarm Mode to support Windows agents

Hi @amanohar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubhuti Manohar). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

cc: @anhowe


feat: add systemd-language-server

Describe your changes
This adds the systemd-language-server package.
I didn't know how to test this, I just copied and adjusted from another pypi package 😅
Issue ticket number and link

Checklist before requesting a review

[x] I have successfully tested installation of the package.
[x] I have successfully tested the package after installation.

Screenshots

Testing is written in CONTRIBUTING.md
Or in short:
Configure your nvim config for mason that you use the local repo on your machine and then :MasonInstall with the new package.
It should then, when everything is done correctly, download and install the package.
For testing the function of the package you need to attach the LSP to the buffer of the file either via autocommand or manually.

Testing is written in CONTRIBUTING.md Or in short: Configure your nvim config for mason that you use the local repo on your machine and then :MasonInstall with the new package. It should then, when everything is done correctly, download and install the package. For testing the function of the package you need to attach the LSP to the buffer of the file either via autocommand or manually.

Yeah, that works! Thanks!
Tho it should be mentioned which yq is needed, on arch (and in my personal preference) https://github.com/kislyuk/yq is the normal one, whereas on deb systems it's https://github.com/kislyuk/yq


Debug.Assert in ModuleAnalysis.ResolveAndAdd

Seems to be regressed in 8e61522a, which overrides BuiltinFunctionInfo.Overloads with LINQ expression, breaking its own GetHashCode.

There are might be other issues too, as using
public override int GetHashCode() => base.GetHashCode()
            ^ Overloads.Aggregate(654754754, (h, o) => h ^ o.GetHashCode()).GetHashCode();

Does not solve the problem completely.

Actually, about recursion tracking in AnalysisValue: does it really need to use value comparison as opposed to using reference comparison, similar to the one suggested here: https://stackoverflow.com/questions/1890058/iequalitycomparert-that-uses-referenceequals

@MikhailArkhipov it creates a new array each time, so its hash code is different on every call.

OK, we can cache both.


objects used in a scenario that has been run should not be editable

FloodAdapt version checks

[X] I have checked that this issue has not already been reported.
[X] I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example
Editing events, projections, measures, and strategies that are used in scenarios that have already been run is allowed. That means that the information between the scenario output and the inputs can be incosistent.
Current behaviour
Currently, you can edit events, projections, measures, and strategies that are used in scenarios that have already been run.
Desired behaviour
The same warning that is currently implemented for the delete method should be implemented for the edit method.
Task list
TBD
Additional context
No response

A lot of unit tests are nog running right now. Since this issue requires some refactoring, first make sure the unit tests are running


Run event emitter in circleci 116067715

@nkeyes
I ran the specs using hosted_graphite v0.0.8, 0.1.0, and 0.1.1 and all are passing with the changes in this branch.

@nkeyes bump

👍


Develop a tuning toolkit

General idea :

[ ] tuning.py based on pandora.cli.tuning_cmd
[ ] Runs a series of configs directly from the command line
[ ] Loads a list of configs from a folder through --configs_dir configs/*.txt
[ ] Keep the last evaluation score in a csv using the name of the config as a key
[ ] Produce a CSV with learning curve to adapt where necessary the learning rate and other params

Other idea :
The actual tuning.py could have a second option to generate such configs using a csv file :
name,include_lemma,include_pos,nb_left_tokens...
config1,True,True,2
config2,True,True,1

Given a dev set there is nothing stopping us from doing hyperparameter
optimization. There are a couple of non-bayesian methods worth trying and
offering them for people with GPUs and time to invest in squeezing the most
out of their data. Things like hyperband or successive halving.
On Mon 23. Oct 2017 at 12:45, Thibault Clérice<EMAIL_ADDRESS>wrote:

Other idea :
The actual tuning.py could have a second option to generate such configs
using a csv file :
name,include_lemma,include_pos,nb_left_tokens...
config1,True,True,2
config2,True,True,1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hipster-philology/pandora/issues/81#issuecomment-338620275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF6Ho2XoE6EKKatPIoCE-ml3JhTVZD6tks5svG42gaJpZM4QCmIH
.

I am all for method-based hyperparameter optimization. The only thing is that it might take more time that just what I described. But please, if you find the time to do this one, I'd be glad to test it :)

Note : we could also simply use existing libraries such as https://github.com/hyperopt/hyperopt


Throws Exception in AWS Lambda

Couldn't find anything documented, that's why I'm opening an issue here
INIT_START Runtime Version: nodejs:18.v6	Runtime Version ARN: arn:aws:lambda:eu-central-1::runtime:a19cefba18c0aa228bfe71e81d95cc5aab18e4570e899b3cfd9f759f022c7f8c
--

ERROR	Uncaught Exception
{
    "errorType": "Error",
    "errorMessage": "Missing tiktoken_bg.wasm",
    "stack": [
        "Error: Missing tiktoken_bg.wasm",
        "    at<EMAIL_ADDRESS>(/var/task/index.js:529075:13)",
        "    at __require (/var/task/index.js:41:44)",
        "    at Object.<anonymous> (/var/task/index.js:532514:34)",
        "    at Module._compile (node:internal/modules/cjs/loader:1254:14)",
        "    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)",
        "    at Module.load (node:internal/modules/cjs/loader:1117:32)",
        "    at Module._load (node:internal/modules/cjs/loader:958:12)",
        "    at Module.require (node:internal/modules/cjs/loader:1141:19)",
        "    at require (node:internal/modules/cjs/helpers:110:18)",
        "    at _tryRequireFile (file:///var/runtime/index.mjs:912:37)"
    ]
}

I'm thinking I'm maybe missing a lambda layer but I could only find one for Python. Any pointers would be greatly appreciated, thanks!

Hello @monostere0!
The error does indicate that the WASM file is not bundled properly. If possible, a reproducible example would be great!

Hi @dqbd, thanks for your reply! Indeed, after drilling more into this issue, it seems like CDK doesn't allow for plugins configuration in its esbuild settings for lambdas. So basically there's no way of doing this with CDK out of the box, however I did find this package which promises to be a workaround. Didn't get the chance to use it yet though, I'll report back once I do.

I had the same problem. One solution that worked was to copy the webassembly into the lambda build directory as part of the deployment. Another was to use the pure JS implementation js-tiktoken


The plugin for class 'rviz_plugins/AerialMapDisplay' failed to load.

Hey guys! So I'm trying to set up rviz_satellite on ubuntu 20.04 on WSL1 with ros noetic... I'm getting this error when launching the demo.launch file:
'[ERROR] [1665163798.105047200]: PluginlibFactory: The plugin for class 'rviz_plugins/AerialMapDisplay' failed to load.  Error: Could not find library corresponding to plugin rviz_plugins/AerialMapDisplay. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.'
I've checked the default library path and it's: "lib/librviz_satellite", I've checked the opt/ros/noetic/lib folder and can't find a library associated with librviz_satellite? Does anyone know how to install this?
Rviz opens up when the demo.launch is launched with odom and map frames... the only output not showing is the AerialMapDisplay plugin which does not respond!
Any help is of course much appreciated, Thanks!

Hi! May I ask how you set up rviz_satellite? For example, the cmd line of the setup process.

Hello, ED562: I have the same issue: [ERROR] [1672799686.885784221]: PluginlibFactory. AerialMapDisplay plugin not shown. Have you got the solution? Thanks.

Hi @xluo6688 Did you source the devel/setup.bash before opening the rviz.

Hello @ulterzlw , Yes, I sourced the devel/setup.bash. Thanks.

Hi @xluo6688 I'm sorry I ended up using mapviz instead 👍

Hi @Ed562, I had the same issue. For me, there was poblem in defined ROS package path. It was sourced to workspace that I am working on and after catkin_make no one of the plugins have been built. I solved problem by sourcing ROS distro directly (/opt/ros/noetic/setup.bash) and deleting build and  devel folder from workspace that I am working on. Then I just ran catkin_make command.
For me, all plugins defined in the workspace packages were built.

hello @Ed562 ,I had the same issue and has solved it.The AerialMapDisplay usually comes from a third-party ROS plugin package, such as rviz_satellite. First Check if the relevant plugin package is installed:roscd rviz_satellite
if not installed: sudo apt-get install ros-<distro>-rviz-satellite  Replace  with your ROS distribution (e.g., noetic or melodic).
Then ,I can successfully run rviz without error.


Conversion to png results with wrong color when using deg units in hsl

This problem was found out when using https://github.com/vercel/satori. Since it is built-in solution there, I am not sure about other details and specifics of its usage.
When defining color like this hsl(200, 50%, 50%), resulting color looks correct (look at second word on picture). But when defining it like this hsl(200deg, 50%, 50%), resulting color is black (look at first word on picture)

You can see replication of it at vercel's playground (switch tabs above image output between svg and png):
https://og-playground.vercel.app/?share=hZNva9swEMa_yiEoScAsTtigiCQwunbbm73Z3gz8RrHOtjJZMpK81Av-7jvZ_Ze2bs8gpOP3HPLdoxPLrUTG2XIJN0Lrvcj_QGFN8CCMhOvaHhQIhyA7I2qVE9KBtkKizAxpCmdr-GptqRFuHmRXX354UAZCpTxIrO2HzAz4b9tCLgwI7S04DK2jPRStyYOyBnJbN9agCaMYodGiK51tjaQK8wVsd3DKDBBofKBVW7eCLcwqr-frNJVYJvApvRiWxewZuX5CnmMRvLvNPO4fYyPV3_NMDB86jdvTcJWXEdv3U_1DDqv1ZfI6E_s8_hiH2bFSAWcT5FHJUBG0StOLKaZCVVbhHUgqH9tJVKHxdooKeBs-a1Ua4nKaBLopUkTqe8Dav4seWh9U0V1RY4h7E-_789yOphPGb0xsfEMGup_AMFh-54S-331DrW2yWUaIpOe1p6Vrkh6t0_JV5WZJLniSW2SmB8gMS5htonE94yc2DIrxSzIXGwfC-Md4kLhvS8YLMj0mjF7DQf3qmvjownE4UZ3omet6j5Lx4Frs-_8

From my understanding, this is part of CSS 4 Color, which is still a draft, and resvg support only CSS 3.
This would not be supported any time soon. Prefer CSS 3 features.

The conversion of various color formats can be handled in satori. In my opinion, this is a very low priority for resvg.

part of CSS 4
It is part of level 3. Are you perhaps mistaking it for new okhsl color definition?

I don't see it mentioned anywhere here: https://www.w3.org/TR/css-color-3/


Separate resolvers for queries and mutations

It appears that the schemaResolver passed in to ParseSchema must contain all root resolvers for both queries and mutations. Since these are separate namespaces in the graphql interface, it would be great to have them be separate namespaces (resolver objects) in the Go implementation too.
Consider the following schema:
schema {
  query: Query
  mutation: Mutation
}

type Query {
    something: Something
}

type Mutation {
    updateSomething(value: String): Something
}

type Something {
    value: String
}

This currently requires an implementation like this:
func init() {
    graphql.MustParseSchema(schemaFromSnippetAbove, &schemaResolver{})
}

type schemaResolver struct{}

func (r *schemaResolver) Something() *somethingResolver {
	return &somethingResolver{}
}

func (r *schemaResolver) UpdateSomething(ctx context.Context, args *struct {
	Value string
}) *somethingResolver {
	return &somethingResolver{value: args.Value}
}

type somethingResolver struct {
	value string
}

func (r *somethingResolver) Value() string {
	return r.value
}

But I would prefer it to require something like this:
func init() {
    graphql.MustParseSchema(schemaFromSnippetAbove, &schemaResolver{})
}

type schemaResolver struct{}

func (r *schemaResolver) Query() *queryResolver {
	return &queryResolver{}
}

func (r *schemaResolver) Mutation() *mutationResolver {
	return &mutationResolver{}
}

type queryResolver struct{}

func (r *queryResolver) Something() *somethingResolver {
	return &somethingResolver{}
}

type mutationResolver struct{}

func (r *mutationResolver) UpdateSomething(ctx context.Context, args *struct {
	Value string
}) *somethingResolver {
	return &somethingResolver{value: args.Value}
}

type somethingResolver struct {
	value string
}

func (r *somethingResolver) Value() string {
	return r.value
}

This would better model what is happening at the graphql layer, which would make the server code more understandable, and also avoid unnecessary limitations (e.g. GraphQL allows you to have a mutation and a query with the same name, but graphql-go does not).

https://github.com/neelance/graphql-go/pull/142
https://github.com/neelance/graphql-go/issues/128
:-)

#142 is not the right solution in my option. I think there should still be a single top level resolver and that resolver should explicitly model the query resolver and the mutation resolver, as described above.

And later, we'll need to add a subscription resolver as well

Exactly

Good idea.

If the query and mutation resolvers are split, it'd be easy to allow only query requests over HTTP GET requests - see issue  #108

The SDL RFC was merged into the specification recently, and I think approaches queries vs. mutations vs. subscriptions in this way: https://github.com/facebook/graphql/pull/90/files#diff-fe406b08746616e2f5f00909488cce66R167

Any working PR about this?

We don't yet have a PR open for this specific change. I'd be happy to work through it with someone if they were to open a PR.
I'd like to get this change in but I'm not quite there yet (still working through the schema and query parsing code to gain understanding).

@tonyghita We can together discuss this PR.

Why not just embed specific resolvers in root resolver?
type RootResolver struct {
    mutationResolver
    queryResolver
}

type queryResolver struct{}
type mutationResolver struct{}

See issue description:

GraphQL allows you to have a mutation and a query with the same name, but graphql-go does not).

If you have a mutation and query with the same name, your suggestion wouldn’t compile.

@nicksnyder Now I see the point. Thank you.

Changes should be compatible with the existing code, if we do not want to break everything, like https://github.com/satori/go.uuid/issues/66

@GhostRussia Yes, you are right. Updated.

Can anyone comment on the status of this? As of now, is there a recommended way of implementing this? I'm having trouble implementing mutations and some guidance would be much appreciated. @nicksnyder

Any progress on this? I really need this feature to implement my API.

Another option would be to add a SchemaOpt that prefixes all function mappings with the root type (Query, Mutation, Subscription).
Would be opt-in, would allow splitting of resolvers without ambiguity.
Otherwise, any progress?

here's a sample patch:
diff --git a/graphql.go b/graphql.go
index be0e1c4..e317c93 100644
--- a/graphql.go
+++ b/graphql.go
@@ -38,7 +38,7 @@ func ParseSchema(schemaString string, resolver interface{}, opts ...SchemaOpt) (
 	}

 	if resolver != nil {
-		r, err := resolvable.ApplyResolver(s.schema, resolver)
+		r, err := resolvable.ApplyResolver(s.schema, resolver, s.prefixRootFunctions)
 		if err != nil {
 			return nil, err
 		}
@@ -69,6 +69,7 @@ type Schema struct {
 	logger                log.Logger
 	useStringDescriptions bool
 	disableIntrospection  bool
+	prefixRootFunctions   bool
 }

 // SchemaOpt is an option to pass to ParseSchema or MustParseSchema.
@@ -98,6 +99,13 @@ func MaxDepth(n int) SchemaOpt {
 	}
 }

+// Add the Query, Subscription and Mutation prefixes to the root resolver function when doing reflection from schema to Go code.
+func PrefixRootFunctions() SchemaOpt {
+	return func(s *Schema) {
+		s.prefixRootFunctions = true
+	}
+}
+
 // MaxParallelism specifies the maximum number of resolvers per request allowed to run in parallel. The default is 10.
 func MaxParallelism(n int) SchemaOpt {
 	return func(s *Schema) {
diff --git a/internal/exec/resolvable/resolvable.go b/internal/exec/resolvable/resolvable.go
index 2780923..d9791d0 100644
--- a/internal/exec/resolvable/resolvable.go
+++ b/internal/exec/resolvable/resolvable.go
@@ -60,25 +60,25 @@ func (*Object) isResolvable() {}
 func (*List) isResolvable()   {}
 func (*Scalar) isResolvable() {}

-func ApplyResolver(s *schema.Schema, resolver interface{}) (*Schema, error) {
+func ApplyResolver(s *schema.Schema, resolver interface{}, prefixRootFuncs bool) (*Schema, error) {
 	b := newBuilder(s)

 	var query, mutation, subscription Resolvable

 	if t, ok := s.EntryPoints["query"]; ok {
-		if err := b.assignExec(&query, t, reflect.TypeOf(resolver)); err != nil {
+		if err := b.assignExec(&query, t, reflect.TypeOf(resolver), prefixRootFuncs); err != nil {
 			return nil, err
 		}
 	}

 	if t, ok := s.EntryPoints["mutation"]; ok {
-		if err := b.assignExec(&mutation, t, reflect.TypeOf(resolver)); err != nil {
+		if err := b.assignExec(&mutation, t, reflect.TypeOf(resolver), prefixRootFuncs); err != nil {
 			return nil, err
 		}
 	}

 	if t, ok := s.EntryPoints["subscription"]; ok {
-		if err := b.assignExec(&subscription, t, reflect.TypeOf(resolver)); err != nil {
+		if err := b.assignExec(&subscription, t, reflect.TypeOf(resolver), prefixRootFuncs); err != nil {
 			return nil, err
 		}
 	}
@@ -130,14 +130,14 @@ func (b *execBuilder) finish() error {
 	return b.packerBuilder.Finish()
 }

-func (b *execBuilder) assignExec(target *Resolvable, t common.Type, resolverType reflect.Type) error {
+func (b *execBuilder) assignExec(target *Resolvable, t common.Type, resolverType reflect.Type, prefixFuncs bool) error {
 	k := typePair{t, resolverType}
 	ref, ok := b.resMap[k]
 	if !ok {
 		ref = &resMapEntry{}
 		b.resMap[k] = ref
 		var err error
-		ref.exec, err = b.makeExec(t, resolverType)
+		ref.exec, err = b.makeExec(t, resolverType, prefixFuncs)
 		if err != nil {
 			return err
 		}
@@ -146,13 +146,13 @@ func (b *execBuilder) assignExec(target *Resolvable, t common.Type, resolverType
 	return nil
 }

-func (b *execBuilder) makeExec(t common.Type, resolverType reflect.Type) (Resolvable, error) {
+func (b *execBuilder) makeExec(t common.Type, resolverType reflect.Type, prefixFuncs bool) (Resolvable, error) {
 	var nonNull bool
 	t, nonNull = unwrapNonNull(t)

 	switch t := t.(type) {
 	case *schema.Object:
-		return b.makeObjectExec(t.Name, t.Fields, nil, nonNull, resolverType)
+		return b.makeObjectExecWithPrefix(t.Name, t.Fields, nil, nonNull, resolverType, prefixFuncs)

 	case *schema.Interface:
 		return b.makeObjectExec(t.Name, t.Fields, t.PossibleTypes, nonNull, resolverType)
@@ -180,7 +180,7 @@ func (b *execBuilder) makeExec(t common.Type, resolverType reflect.Type) (Resolv
 			return nil, fmt.Errorf("%s is not a slice", resolverType)
 		}
 		e := &List{}
-		if err := b.assignExec(&e.Elem, t.OfType, resolverType.Elem()); err != nil {
+		if err := b.assignExec(&e.Elem, t.OfType, resolverType.Elem(), false); err != nil {
 			return nil, err
 		}
 		return e, nil
@@ -212,6 +212,9 @@ func makeScalarExec(t *schema.Scalar, resolverType reflect.Type) (Resolvable, er

 func (b *execBuilder) makeObjectExec(typeName string, fields schema.FieldList, possibleTypes []*schema.Object,
 	nonNull bool, resolverType reflect.Type) (*Object, error) {
+	return b.makeObjectExecWithPrefix(typeName, fields, possibleTypes, nonNull, resolverType, false)
+}
+func (b *execBuilder) makeObjectExecWithPrefix(typeName string, fields schema.FieldList, possibleTypes []*schema.Object, nonNull bool, resolverType reflect.Type, prefixFuncs bool) (*Object, error) {
 	if !nonNull {
 		if resolverType.Kind() != reflect.Ptr && resolverType.Kind() != reflect.Interface {
 			return nil, fmt.Errorf("%s is not a pointer or interface", resolverType)
@@ -223,17 +226,23 @@ func (b *execBuilder) makeObjectExec(typeName string, fields schema.FieldList, p
 	Fields := make(map[string]*Field)
 	rt := unwrapPtr(resolverType)
 	for _, f := range fields {
+
+		methodName := f.Name
+		if prefixFuncs {
+			methodName = typeName + f.Name
+		}
+
 		fieldIndex := -1
-		methodIndex := findMethod(resolverType, f.Name)
+		methodIndex := findMethod(resolverType, methodName)
 		if b.schema.UseFieldResolvers && methodIndex == -1 {
 			fieldIndex = findField(rt, f.Name)
 		}
 		if methodIndex == -1 && fieldIndex == -1 {
 			hint := ""
-			if findMethod(reflect.PtrTo(resolverType), f.Name) != -1 {
+			if findMethod(reflect.PtrTo(resolverType), methodName) != -1 {
 				hint = " (hint: the method exists on the pointer type)"
 			}
-			return nil, fmt.Errorf("%s does not resolve %q: missing method for field %q%s", resolverType, typeName, f.Name, hint)
+			return nil, fmt.Errorf("%s does not resolve %q: missing method for field %q%s", resolverType, typeName, methodName, hint)
 		}

 		var m reflect.Method
@@ -266,7 +275,7 @@ func (b *execBuilder) makeObjectExec(typeName string, fields schema.FieldList, p
 			a := &TypeAssertion{
 				MethodIndex: methodIndex,
 			}
-			if err := b.assignExec(&a.TypeExec, impl, resolverType.Method(methodIndex).Type.Out(0)); err != nil {
+			if err := b.assignExec(&a.TypeExec, impl, resolverType.Method(methodIndex).Type.Out(0), false); err != nil {
 				return nil, err
 			}
 			typeAssertions[impl.Name] = a
@@ -358,7 +367,7 @@ func (b *execBuilder) makeFieldExec(typeName string, f *schema.Field, m reflect.
 	} else {
 		out = sf.Type
 	}
-	if err := b.assignExec(&fe.ValueExec, f.Type, out); err != nil {
+	if err := b.assignExec(&fe.ValueExec, f.Type, out, false); err != nil {
 		return nil, err
 	}

What about that?

We have the above in our fork, I'd gladly push it upstream if the method is acceptable. (https://github.com/dfuse-io/graphql-go)

@abourget, does this mean that, for example, if you want to use both a query and a mutation named Products, then in your Go code in the schema resolver you have methods named QueryProducts and MutationProducts respectively? If that is the case, I am not a big fan of this. I do like that it is opt-in, though.
I still want this to be opt-in (e.i. no braking changes), however, when enabled I would prefer one struct with (up to) three methods, as suggested by the original post above:
type schemaResolver struct{}

func (r *schemaResolver) Query() *queryResolver {
	return &queryResolver{}
}

func (r *schemaResolver) Mutation() *mutationResolver {
	return &mutationResolver{}
}

func (r *schemaResolver) Subscription() *subscriptionResolver {
	return &subscriptionResolver{}
}
...

The way you suggest it doesn't add breaking changes but adds semeiotical meaning to the name of the resolvers. This in turn increases complexity...

TBH, although it might sound like a cliche, there is no short path to where we want to go. Having semantic prefixes feels like magic. And requires internal knowledge of the library or reading documentation in order to use it. In other words, it is not intuitive. I would prefer to wait until I'm happy with the solution. With that being said, what is the problem with reusing the DB code the Query, Mutation and Subscription resolvers respectively? Could you give me a very simple example of how you use it? I want to understand your point of view.

@pavelnikolov Please do we have any update on this?

Not that I am aware of.

Still no progress here?
Since the lib is still pre version 1.0, would expect a breaking change not such a big thing. Currently, a clean interface should be a higher goal.

For info, we use PR #421 in production and we like the way it feels. Personally, I add the option in every project we do, the resolve reads better in my opinion even when there is no conflicts.
func QuerySomething(...) { ... }

func SubscriptionTransactions(...) { ... }

func MutationUser(...) { ... }


[P4_Symbolic] Use p4-symbolic's test data instead of SAI P4 for deparser tests.

Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 669 targets (5 packages loaded, 377 targets configured).
INFO: Found 669 targets...
INFO: From Compiling P4 program p4_symbolic/testdata/conditional/complex_conditional.p4:
p4_symbolic/testdata/conditional/complex_conditional.p4(55): [--Wwarn=unused] warning: Table n1 is not used; removing
table n1 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^
p4_symbolic/testdata/conditional/complex_conditional.p4(58): [--Wwarn=unused] warning: Table n4 is not used; removing
table n4 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^
p4_symbolic/testdata/conditional/complex_conditional.p4(59): [--Wwarn=unused] warning: Table n5 is not used; removing
table n5 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^
p4_symbolic/testdata/conditional/complex_conditional.p4(64): [--Wwarn=unused] warning: Table n10 is not used; removing
table n10 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^^
p4_symbolic/testdata/conditional/complex_conditional.p4(69): [--Wwarn=unused] warning: Table n15 is not used; removing
table n15 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^^
p4_symbolic/testdata/conditional/complex_conditional.p4(70): [--Wwarn=unused] warning: Table n16 is not used; removing
table n16 {key = {hdr.h1.f1: exact;} actions = {@proto_id(1) a1;}}
^^^
INFO: From Compiling p4_symbolic/deparser_test.cc:
In file included from ./p4_symbolic/z3_util.h:18,
from p4_symbolic/deparser_test.cc:31:
./p4_pdpi/string_encodings/bit_string.h: In member function 'void pdpi::BitString::AppendBytes(absl::lts_20230802::string_view)':
./p4_pdpi/string_encodings/bit_string.h:55:23: warning: comparison of integer expressions of different signedness: 'int' and 'std::basic_string_view::size_type' {aka 'long unsigned int'} [-Wsign-compare]
55 |     for (int i = 0; i < bytes.size(); i++) {
|                     ^~~~~~~~~~~~
./p4_pdpi/string_encodings/bit_string.h: In instantiation of 'void pdpi::BitString::AppendBits(const std::bitset<_Nb>&) [with long unsigned int num_bits = 8]':
./p4_pdpi/string_encodings/bit_string.h:41:50:   required from here
./p4_pdpi/string_encodings/bit_string.h:49:23: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
49 |     for (int i = 0; i < num_bits; i++) {
|                     ^~~~~~~~
INFO: Elapsed time: 10.609s, Critical Path: 6.82s
INFO: 36 processes: 4 internal, 32 linux-sandbox.
INFO: Build completed successfully, 36 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 669 targets (0 packages loaded, 45 targets configured).
INFO: Found 453 targets and 216 test targets...
INFO: Elapsed time: 181.259s, Critical Path: 117.36s
INFO: 270 processes: 326 linux-sandbox, 18 local.
INFO: Build completed successfully, 270 total actions
//dvaas:port_id_map_test                                                 PASSED in 0.9s
//dvaas:test_run_validation_golden_test                                  PASSED in 0.1s
//dvaas:test_run_validation_test                                         PASSED in 0.6s
//dvaas:test_run_validation_test_runner                                  PASSED in 0.0s
//dvaas:test_vector_stats_diff_test                                      PASSED in 0.1s
//dvaas:test_vector_stats_test                                           PASSED in 0.1s
//dvaas:test_vector_test                                                 PASSED in 0.7s
//dvaas:user_provided_packet_test_vector_diff_test                       PASSED in 0.1s
//dvaas:user_provided_packet_test_vector_test                            PASSED in 0.1s
//gutil:collections_test                                                 PASSED in 0.5s
//gutil:io_test                                                          PASSED in 0.5s
//gutil:proto_matchers_test                                              PASSED in 0.6s
//gutil:proto_ordering_test                                              PASSED in 0.6s
//gutil:proto_test                                                       PASSED in 0.6s
//gutil:status_matchers_test                                             PASSED in 0.5s
//gutil:test_artifact_writer_test                                        PASSED in 0.6s
//gutil:testing_test                                                     PASSED in 0.5s
//p4rt_app/tests:response_path_test                                      PASSED in 6.2s
//p4rt_app/tests:role_test                                               PASSED in 1.6s
//p4rt_app/tests:state_verification_test                                 PASSED in 3.5s
//p4rt_app/tests:vrf_table_test                                          PASSED in 2.6s
//p4rt_app/tests/lib:app_db_entry_builder_test                           PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test                                 PASSED in 0.1s
//p4rt_app/utils:table_utility_test                                      PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test                           PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test        PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test      PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test         PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test                   PASSED in 0.8s
//sai_p4/instantiations/google:sai_p4info_test                           PASSED in 1.1s
//sai_p4/instantiations/google:sai_pd_proto_test                         PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test                          PASSED in 0.7s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test              PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test                PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.2s
//sai_p4/instantiations/google/test_tools:test_entries_test              PASSED in 1.0s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test          PASSED in 3.5s
//sai_p4/tools:p4info_tools_test                                         PASSED in 0.6s
//sai_p4/tools:packetio_tools_test                                       PASSED in 0.8s
//tests:thinkit_gnmi_interface_util_tests                                PASSED in 1.2s
//tests/lib:p4info_helper_test                                           PASSED in 1.0s
//tests/lib:p4rt_fixed_table_programming_helper_test                     PASSED in 0.8s
//tests/lib:packet_generator_test                                        PASSED in 26.9s
//tests/lib:switch_test_setup_helpers_golden_test                        PASSED in 0.1s
//tests/lib:switch_test_setup_helpers_golden_test_runner                 PASSED in 0.1s
//tests/qos:gnmi_parsers_test                                            PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner                                     PASSED in 0.0s
//tests/sflow:sflow_util_test                                            PASSED in 0.9s
//thinkit:bazel_test_environment_test                                    PASSED in 0.6s
//thinkit:generic_testbed_test                                           PASSED in 0.9s
//thinkit:mock_control_device_test                                       PASSED in 0.6s
//thinkit:mock_generic_testbed_test                                      PASSED in 0.8s
//thinkit:mock_mirror_testbed_test                                       PASSED in 0.7s
//thinkit:mock_ssh_client_test                                           PASSED in 0.0s
//thinkit:mock_switch_test                                               PASSED in 0.8s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 0.8s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 0.9s
Stats over 5 runs: max = 0.9s, min = 0.7s, avg = 0.8s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 45.0s
Stats over 50 runs: max = 45.0s, min = 0.8s, avg = 2.9s, dev = 8.6s
Executed 216 out of 216 tests: 216 tests pass.
INFO: Build completed successfully, 270 total actions

/azp run

Co-authored-by: Srikishen Pondicherry Shanmugam<EMAIL_ADDRESS>