Revert "fix: Override upgrade button link for MITx Online production"

⚠ This PR doesn't need to be merged right away, We'd want to merge this when we launch MITx Online .
This revert PR is associated with https://github.com/mitodl/mitxonline/issues/953, in response to https://github.com/mitodl/mitxonline/issues/953#issuecomment-1262603741. We'd want to change the redirect back to MITx Online.
Reverts mitodl/ol-infrastructure#1067

@blarghmatey what is involved with deploying this to production on Tuesday? How long will it take?

Once it merges the Concourse pipeline will build and deploy to QA automatically. Then we can trigger the deploy. The build takes about 5 to 10 minutes and the full rollout takes about 20


Add XarrayVariableEqualityComparator

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bb31843) 100.00% compared to head (7b59e3c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           62        63    +1
  Lines         2179      2206   +27
  Branches       384       385    +1
=========================================
+ Hits          2179      2206   +27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Spelling

Just in case it's helpful, I noticed on the README that this could be corrected:
"paramaters" -> "parameters"

Thanks for pointing out


docs: updating terraform-docs with latest changes

terraform-docs hasn't been run with the latest changes.. updating readme docs.

@aleksasiriski How come the flow is not running, because we removed the staging branch maybe, no? I will change it to "master" again, what do you think?

Exactly! I will fix this then. Thanks :)

Closed in favor of #1227


merge stable branch into canary because i am dumb enough to not see the canary branch

oops i forgot to select the correct branch to merge to


WordPress 5.6 Compatibility

Task Description
Previously: #3300

[ ] Update CI test matrix
[ ] Do some manual testing for key affected areas
[ ] Write/Update tests where applicable
[ ] Bump Tested up to value
[ ] Consider dropping support for WordPress 5.3

https://core.trac.wordpress.org/changeset/49102 might be relevant

RC 1 is scheduled for next week: https://make.wordpress.org/core/5-6/

I think we should only drop support for a version of WordPres when it becomes expensive to support it

Update CI test matrix

Current 5.5 is not referenced in the test matrix. Latest is and would cover 5.6. Should make the matrix, 5.3, 5.6, latest.

Do some manual testing for key affected areas

I did some manual testing and can't find any issues. Even read the change tickets in 5.6 and can't see anything that jumps out that would effect us

Write/Update tests where applicable

As above, not sure what tests we need here.

Bump Tested up to value

👍

Consider dropping support for WordPress 5.3

I think it is small effort to keep support. In my mind, 5.3 is a kind of LTS for WordPress, in the same way 4.9 was. As of today, 5.3 is 9.1% according to the stats page. I believe it still worth the effort to support. But after 5.6 release, these numbers may change. I think it is worth having these conversions again after 5.6 has been out for a month of two.

Let's start with updating the test matrix. If everything looks good there we can update our staging environment accordingly.
However, I don't think we should just make the matrix 5.3, 5.6, latest

I think we can try out an optimized matrix like this for the unit tests.
matrix:
  php: ['7.4', '7.0']
  wp: ['latest']
  coverage: [false]
  include:
    - php: '7.4'
      wp: 'latest'
      coverage: true

    - php: '5.6'
      wp: '5.3'

    - php: '7.4'
      wp: '5.6'
      experimental: true

    - php: '7.4'
      wp: 'trunk'
      experimental: true

    - php: '8.0'
      wp: 'trunk'
      experimental: true

We'll likely also want to tackle #5338 to run E2E tests against both 5.3 and latest / 5.6


Official docker image

Official docker image for canner-server
We'll use multi-stage docker image (https://docs.docker.com/develop/develop-images/multistage-build/) to build the static files first, and serve it at next image.
There are still some bundle issues we need to resolve. After resolving issues, we'll push images to docker hub for everyone to use.

Can't wait for this to happen! Keep it up!

Hi @PostPollux, you can check out document https://www.cannercms.com/docs/guides-deployment-of-docker . you can deploy using Docker now!


Adjust CI configuration to ros2_control repository.

Remove old CI setup.
Adding adjusted CI configurationt to ros2_control repository.

Codecov Report

Merging #408 (c94e8b8) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.43%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%
==========================================
  Files         189        7     -182
  Lines       17570      737   -16833
  Branches    11592      422   -11170
==========================================
- Hits         6287      221    -6066
+ Misses        994      161     -833
+ Partials    10289      355    -9934

Flag
Coverage Δ

unittests
29.98% <20.43%> (-5.80%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...de/diff_drive_controller/diff_drive_controller.hpp
100.00% <ø> (ø)

...ontroller/test/test_load_diff_drive_controller.cpp
12.50% <0.00%> (ø)

diff_drive_controller/src/odometry.cpp
42.16% <11.11%> (ø)

...ive_controller/test/test_diff_drive_controller.cpp
17.62% <12.08%> (ø)

diff_drive_controller/src/speed_limiter.cpp
46.55% <13.33%> (ø)

...troller/include/diff_drive_controller/odometry.hpp
20.00% <20.00%> (ø)

...iff_drive_controller/src/diff_drive_controller.cpp
32.67% <24.59%> (ø)

...ler/test/test_load_joint_trajectory_controller.cpp

...ectory_controller/test/test_trajectory_actions.cpp

...ontrollers/src/joint_group_position_controller.cpp

... and 192 more

@mergifyio backport foxy galactic


Tasks that need to be completed before release

To get to a new release, we need to complete the following tasks:

[ ] #74
[ ] #78
[ ] #86
[ ] #79
[ ] #80
[x] #67
[ ] #72
[ ] #81
[ ] #82
[ ] #84
[ ] #83
[ ] #85
[x] #87
[ ] #59

these need to be done last

[ ] Update changelog
[ ] Nudge the major version

Assigning this Issue to myself so it doesn't get lost in the initial Issues list.


Thank you for the hard work :)

HI Sam
Just wanted to let you know I have been able to follow your instructions for raspberry and have a working setup ( minus the signal lol )
(side note)
python3 tools\keymsg-decrypt.py EncryptionKeyMessage_001F2904C905.bin 001F2904C905
was causing issues for me, From my limited knowledge the \ I was thinking should have been /
python3 tools/keymsg-decrypt.py EncryptionKeyMessage_001F2904C905.bin 001F2904C905 and it worked so was able to finish the installation on the Pi
I have built a cantenna on a 90cm dish but unfortunately my signal is not locking. Will post a picture of my sdrsharp today to see what the issues are as the frequency is slightly off at 1692170 ? if I use my other sdr its then at 1692100. also i should add my dish will hold a signal when I turn the dish 2-5 degrees in any direction( left, right, up & down) which leads me to scratch my head as when I play with ku band lnb setups if I'm off my 1 degree I completely lose my signals
Have some free time today will try for a lock and send a picture or two of the waterfall.
Thank you for the hard work, effort & tutorials you have provided

Hi Sam
Here is a 2 snap shots of my laptop running sdrsharp. I have ( silly me) figured why frequency was wrong, Was me lol ppm correction was off I think.
Appreciate your time

Hi Sam
I have pickup a suggested wifi antenna from
http://www.citytechnology.com.au/store/19dbi-2.4ghz-square-grid-dish-antenna#!prettyPhoto
Put it together and made the modification as suggested. Still no luck with a lock :( . I've noticed that even with this antenna i can move up/down/left&right about 10 degrees and still see a signal was wondering if you have any clues to what might be going on?
I was at max getting in sdrsharp a snr of 11 with the 90cm offset with cantenna now with the wifi antenna im seeing 13/14 snr.
Any guidance is greatly appreciated mate.
Adam

Hi Adam,
Apologies for not replying sooner.
Your signal in SDRSharp looks good! Have you been using goesrecv-monitor when trying to get goesrecv to lock? Could you also copy your goesrecv.conf file into a comment here for me to double check?

I should add my dish will hold a signal when I turn the dish 2-5 degrees in any direction( left, right, up & down) which leads me to scratch my head as when I play with ku band lnb setups if I'm off my 1 degree I completely lose my signals

Good eye! This is because the beam-width of a dish becomes narrower as frequency increases, assuming the dish diameter is the same. For example, the -3 dB beam-width of a 1m dish at L-band is about 12°, but at Ku-band it's about 1.7°.

From my limited knowledge the \ I was thinking should have been /

Yes Windows prefers backslash in file paths but will tolerate forward slash. I've updated that line in the setup guide to use a forward slash. Thanks for pointing that out.

Hi Sam
thank you for the help mate.
Here is a cut and past of the goesrecv.conf
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"
[airspy]
frequency =<PHONE_NUMBER>
2500000 for the R2, 3000000 for the Mini
sample_rate = 3000000
gain = 18
bias_tee = true
[rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
bias_tee = true
device_index
[costas]
max_deviation = 200e3
[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576
[monitor]
statsd_address = "udp4://localhost:8125"
[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"
I have the goesrecv monitor running also on laptop but through movements I see no change in the "eye " or Verb.
thank you for the information on bean-width great to learn something new
Cheers
Adam

I don't know why in last post its changes the font size of the information in the config file  all i did was cut and paste it, in the file its all the same size font , no bold, no underlines?
Lol could this be the issue

Hi Sam
Sorry for multiple posts
another cut and paste
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"
[airspy]
frequency =<PHONE_NUMBER>
2500000 for the R2, 3000000 for the Mini
sample_rate = 3000000
gain = 18
bias_tee = true
[rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
bias_tee = true
device_index
[costas]
max_deviation = 200e3
[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576
[monitor]
statsd_address = "udp4://localhost:8125"
[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"

Ah that would be the GitHub markdown formatting. "#" is used to create a heading line. I've edited your comment to make it a code block so it ignores formatting characters.
Your config file looks fine, one thing I would try however is to remove the "# " from # gain = 30. The automatic gain in the RTL-SDR may be misbehaving, so forcing it to a higher gain may help. Restart goesrecv after doing that and see if it locks.

Ok Sam
Thank you will try that this afternoon.  Appreciate the help mate
Cheers

Hey Sam
One more question if you dont mind, Am going to set it up all outside this afternoon and go for a lock.
If i adjust a setting in the goesrecv.conf do i have to reset the Pi or can i just " Ctrl C " the  " goesrecv -v -i 1 -c goesrecv.conf " and restart it - Or is it capable of seeing the changes I make on the fly with editing the goesrecv.conf be seen straight away by the program when i edit it with WinSCP and save ?
Thanks again mate, will update you with the results.

You'll need to stop goesrecv with Ctrl + C then run the command again. No need to reset the whole Pi.

Hi Sam
Unfortunately I’m going to have to get back to you next week mate. My
nooelec Lna just died :/ lol .. I also have the goes Lna arriving hopefully
during the week and extended tuning sdr. Will update you.
Mate thank you for the help and great software you have provided everyone
what a great effort and abilities you have 👍👍🙏👍👍
Cheers
Adam, North Qld
On Sat, 5 Dec 2020 at 2:11 pm, Sam<EMAIL_ADDRESS>wrote:

You'll need to stop goesrecv with Ctrl + C then run the command again. No
need to reset the whole Pi.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-739120227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y6I5JGRA5MYSYMYASDSTGXIRANCNFSM4UIJ7N7Q
.

Hi Sam
I have setup the dish again without success, I removed the "#" from gain but have noticed I'm having to remove the "#" from bias_tee for it to turn on the lna (I didn't have to do this before). I appreciate your help but I'm scratching my head as to what's going on as I have also set it up with sdrsharp and see a good signal.  One thing I'm using a standard nooelec lna not the Goes sawbird would this be part of my problem?
I will try again tomorrow .. unfortunately  I'm dealing with a bad summer here in Cairns the U.v is every high and can only work outside in the early evening so time is limited for me.

Hey Sam
not luck :( . something weird is going on still with gain but have attached pictures with the gain settings from config file in the background. I also thought maybe(silly I know- wrong satellite) and have included a snapshot of hrit GK-2a and another of lrpt GK-2a.  through SDR# on my laptop I get a great snr.
I have tried 2 different sdr's and have used 1. different usb cables 2. different length usb 3.power injector 2 way usb cable  4. direct to Pi (no usb leads) 5. a new sd card and whole new install of your great software. 6. sma patch lead from first lna to the second lna incase of them been hooked together in series was an issue.
I had just for fun also compiled the Goes Raspberry beforehand and put that sd card into the Pi and changed the settings in the config file to yours and besides the "HRIT", "GOES" up the top the first line which came in showed 2 packets then were all errors after the first line.  I'm hoping this helps in someway as to maybe what's going on because as of now I'm at a loss as my abilities are subpar. hope I haven't rambled or provided to much to read.
my setup is

RTL-SDR Blog v3 , Generic RTL-SDR .
2x Nooelec Lana's
City Technology (AU) Wifi antenna (modifications made)
Raspberry Pi 3b+ 32gb running Raspberry Pi OS ( Port of Debian desktop )
Putty & winscp for communications to desktop

Thank you for reading and helping a noob
Adam

Hi Adam, this is very strange. Are you able to record some IQ in SDRSharp and sent it to me via WeTransfer? I can then try demodulate it here to confirm your SNR is sufficient. From the screenshots it looks ok.

Ok Sam
Will do that now mate, give me 15

Hey Sam
Can I have your email to send the link for wetransfer mate ?
Cheers
On Wed, 16 Dec 2020 at 4:29 pm, Sam<EMAIL_ADDRESS>wrote:

Hi Adam, this is very strange. Are you able to record some IQ in SDRSharp
and sent it to me via WeTransfer https://wetransfer.com/? I can then
try demodulate it here to confirm your SNR is sufficient. From the
screenshots it looks ok.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-745796384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y5DSXOTTOQ6UYQOHVDSVBHVJANCNFSM4UIJ7N7Q
.

<EMAIL_ADDRESS>

Ok
Transferring now mate 👍
On Wed, 16 Dec 2020 at 4:52 pm, Sam<EMAIL_ADDRESS>wrote:

<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-745805883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y7CULSL7B6J6HVQYGTSVBKMPANCNFSM4UIJ7N7Q
.

Thanks, I'll check it out when I'm home later tonight.

👍
On Wed, 16 Dec 2020 at 4:58 pm, Sam<EMAIL_ADDRESS>wrote:

Thanks, I'll check it out when I'm home later tonight.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-745808242,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y4S4IMAAW2TNISWJ33SVBLBZANCNFSM4UIJ7N7Q
.

Hi Adam,
When you play your recording back in SDRSharp do you see something like this? I can see a large DC spike in the center of the spectrum when playing the recording here. Otherwise the SNR looks good.

The test demodulator I have in GNU Radio was unable to lock on this recording at first.

I then added a DC blocker inside the demodulator and now the signal is locking fine.

I quickly connected it all to xrit-rx and it is decoding the signal correctly, so no issues with your RF setup! This looks to be a software or configuration issue.

Something else you could try is to changing the sample rate in the goesrecv.conf file.
Under the [rtlsdr] section try changing sample_rate = 1024000 to sample_rate = 900000.
If that does not work try adding a # before sample_rate so goesrecv can automatically pick a sample rate.

Hi Sam
Its great to know the Rf side is mostly right. No I don't see a spike in the middle on the recording but I will setup live when home this morning as work an early shift, will be home at 10am Qld time and will try with a sample rate of 900000 in sdr# first.
I have had the (#) before sample_rate and also with out I have tried the 1024000 and also 2400000 but not ever your suggested 900000. Just for reference and to try and learn about this why would I not  been seeing the DC spike ? For a while I was thinking maybe I was on fengyun 2f ( very close) but for the life of me couldn't find the freq for it to clarify.
Thank you for the efforts in helping and teaching me Sam, Talk soon when home

ok update, I have sdr# at work and downloaded the wetransfer file and If i take the tick out of (Correct IQ) I get a big spike. hope this helps in some way. If listening to the Raw file and take the tick  correct IQ in sdr# I can hear a data stream with it unticked I hear just Noise - garbage.
At lest now I see this
Adam

Hi Sam
Have update the suggested line and unfortunately no success. I tried sample_rate = 900000 but wouldn't accept it , so I used sample_rate = 900001 which didn't produce an error but still no packets mate. funny thing I've noticed with SDR# is when live rtl-sdr usb I get no DC spike ( With correct IQ on or off ), If I record it and play it back the spike is there with correct IQ off ?
I have uploaded another raw file to wetransfer if your interested. I have TeamViewer on my laptop if you would like access and have some time to help further or are keen to know what's at the heart of this issue. Also Is there a compiled raspberry Pi 3 image with your software at hand that I  could try ( was something I thought of to rule out my user error )  I have this morning tried

a battery pack power supply for Pi
a different power pack for Pi
Supplied direct power to lna with DC Block ( Incase Pi wasn't powering it correctly )
sample_rate = 900000 which gave an error and exited
sample_rate = 900001 which worked but still had no packets
gain or # gain to get manual gain I need to be from 6-19, If I input 5 the gain is automatic and with each line moves up in values. If I let it climb to max gain still no packets of data or lock
Cheers

Adam

Hey Sam
I had another thought ( learning still ) . would it be worth putting Ubuntu on a laptop and compiling the software again to rule out the hardware of the Pi? I have twice installed Raspberry OS, Or is there a better Pi OS to install ?
I see lots of people getting your great work setup correctly and want to succeed. I know as a developer your time should be on time off and making your software better all the time and am so happy with the time and information you have given me mate

Just an update mate
I have installed Ubuntu on my old laptop and installed all Goestools and Xrit-rx  with the same results. Its not the Pi. I installed sdr# on it also and for some reason the signal is very very weak. If I plug up my windows laptop it shows a great strong signal with a SNR of 14-15. On Ubuntu wouldn't be getting a SNR of 5-6 ( have adjusted gain and also tried manual gain with no success. I will this afternoon try when back home another sdr but the sdr I'm using atm is the sdr-blog v3 which as far as I'm aware is better at 1.692.140 mhz.
any suggestions or thoughts on this are welcome and appreciated
Cheers
Adam

Hi Adam,
Lets lock the sample rate at 1024000 and gain to 25 in goesrecv.conf just to reduce the number of variables we're working with. So far we know the RF hardware is OK and the signal is strong enough but goesrecv never locks. The downlink frequency seems to be spot on based on your IQ recordings, so that's unlikely to be the issue.
Many people are using the RTL-SDR v3 dongle for L-band stuff so that's fine. Just double checking you've been compiling librtlsdr yourself as per the guide? The bias-tee on the v3 will not work unless this particular version of the library is used.

I've just noticed the PLL warning in your goesrecv screenshots ([R82XX] PLL not locked!). This is likely to cause an issue where goesrecv cannot tune the SDR to the LRIT frequency. I also noticed you have the frequency parameter under [airspy] uncommented, I've seen this cause issues when not using the Airspy mode.
I have prepared a goesrecv.conf file below which is setup for a RTL-SDR. Try replacing your goesrecv.conf file with the one below then running goesrecv again.
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"

[airspy]
# frequency =<PHONE_NUMBER>
## 2500000 for the R2, 3000000 for the Mini
# sample_rate = 3000000
# gain = 18
# bias_tee = false

# [rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
# bias_tee = false
# device_index = 0

# [nanomsg]
# sample_rate = 2400000
# connect = "tcp://<IP_ADDRESS>:5005"
# receive_buffer = 2097152

[costas]
max_deviation = 200e3

[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152

[quantization.soft_bit_publisher]
bind = "tcp://<IP_ADDRESS>:5001"
send_buffer = 1048576

[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576

## Demodulator JSON statistics output (gain, frequency correction)
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"

## Decoder JSON statistics output (Viterbi, RS)
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"

## Aggregated statistics output (counters, gauges, and histograms)
[monitor]
statsd_address = "udp4://localhost:8125"

Great, thanks!
Will try when home in and hour mate
thank you
On Sat, Dec 19, 2020 at 1:15 PM Sam<EMAIL_ADDRESS>wrote:

I've just noticed the PLL warning in your goesrecv screenshots ([R82XX]
PLL not locked!). This is likely to cause an issue where goesrecv cannot
tune the SDR to the LRIT frequency. I also noticed you have the frequency
parameter under [airspy] uncommented, I've seen this cause issues when
not using the Airspy mode.
I have prepared a goesrecv.conf file below which is setup for a RTL-SDR.
Try replacing your goesrecv.conf file with the one below then running
goesrecv again.
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"
[airspy]
frequency =<PHONE_NUMBER>
2500000 for the R2, 3000000 for the Mini
sample_rate = 3000000
gain = 18
bias_tee = false
[rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
bias_tee = false
device_index = 0
[nanomsg]
sample_rate = 2400000
connect = "tcp://<IP_ADDRESS>:5005"
receive_buffer = 2097152
[costas]
max_deviation = 200e3
[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152
[quantization.soft_bit_publisher]
bind = "tcp://<IP_ADDRESS>:5001"
send_buffer = 1048576
[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576
Demodulator JSON statistics output (gain, frequency correction)
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"
Decoder JSON statistics output (Viterbi, RS)
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"
Aggregated statistics output (counters, gauges, and histograms)
[monitor]
statsd_address = "udp4://localhost:8125"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-748411062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y63D4WUAV5QLZVD7EDSVQLFFANCNFSM4UIJ7N7Q
.

Hi Adam,
Lets lock the sample rate at 1024000 and gain to 25 in goesrecv.conf just to reduce the number of variables we're working with. So far we know the RF hardware is OK and the signal is strong enough but goesrecv never locks. The downlink frequency seems to be spot on based on your IQ recordings, so that's unlikely to be the issue.
Many people are using the RTL-SDR v3 dongle for L-band stuff so that's fine. Just double checking you've been compiling librtlsdr yourself as per the guide? The bias-tee on the v3 will not work unless this particular version of the library is used.

Sam
I have just followed the guide to to the extent of copying and pasting mate. librtlsdr I just followed the instructions and copied them ( noob)  sorry have I missed something ?
I have tried again with the config and no ppl lock :(

The Bias-tee turns on though I need to uncomment it (#bias-tee = true) wont work I have to (bias-tee = true)
also in the config information you sent I had to uncomment  ( # [rtlsdr] )  to ( [rtlsdr] )
merry Christmas mate

Ah yes, good spot! Did you also comment [airspy] when you made that change?
Here's an updated config file for you to try:
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"

# [airspy]
# frequency =<PHONE_NUMBER>
## 2500000 for the R2, 3000000 for the Mini
# sample_rate = 3000000
# gain = 18
# bias_tee = false

[rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
bias_tee = true
# device_index = 0

# [nanomsg]
# sample_rate = 2400000
# connect = "tcp://<IP_ADDRESS>:5005"
# receive_buffer = 2097152

[costas]
max_deviation = 200e3

[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152

[quantization.soft_bit_publisher]
bind = "tcp://<IP_ADDRESS>:5001"
send_buffer = 1048576

[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576

## Demodulator JSON statistics output (gain, frequency correction)
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"

## Decoder JSON statistics output (Viterbi, RS)
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"

## Aggregated statistics output (counters, gauges, and histograms)
[monitor]
statsd_address = "udp4://localhost:8125"

Heya mate
I’m sure I did. Will let you Know in the morning if that’s ok out with the
family 👍 I’m persistent lol .. will get to the bottom of it and hopefully
give you something back to help others if this appears in the future on
GitHub
👍 legend
Adam
On Sat, 19 Dec 2020 at 4:54 pm, Sam<EMAIL_ADDRESS>wrote:

Ah yes, good spot! Did you also comment [airspy] when you made that
change?
Here's an updated config file for you to try:
[demodulator]
satellite = "GK-2A"
downlink = "lrit"
source = "rtlsdr"
[airspy]
frequency =<PHONE_NUMBER>
2500000 for the R2, 3000000 for the Mini
sample_rate = 3000000
gain = 18
bias_tee = false
[rtlsdr]
frequency =<PHONE_NUMBER>
sample_rate = 1024000
gain = 30
bias_tee = true
device_index = 0
[nanomsg]
sample_rate = 2400000
connect = "tcp://<IP_ADDRESS>:5005"
receive_buffer = 2097152
[costas]
max_deviation = 200e3
[clock_recovery.sample_publisher]
bind = "tcp://<IP_ADDRESS>:5002"
send_buffer = 2097152
[quantization.soft_bit_publisher]
bind = "tcp://<IP_ADDRESS>:5001"
send_buffer = 1048576
[decoder.packet_publisher]
bind = "tcp://<IP_ADDRESS>:5004"
send_buffer = 1048576
Demodulator JSON statistics output (gain, frequency correction)
[demodulator.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6001"
Decoder JSON statistics output (Viterbi, RS)
[decoder.stats_publisher]
bind = "tcp://<IP_ADDRESS>:6002"
Aggregated statistics output (counters, gauges, and histograms)
[monitor]
statsd_address = "udp4://localhost:8125"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-748430486,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y4UY3N3XERHMLUUWWTSVRE2LANCNFSM4UIJ7N7Q
.

No worries! I'll let you know if I think of anything else to try.
I'll leave this issue open here so you can keep me updated.
All the best.
Sam.

Awesome, thanks!
On Sat, 19 Dec 2020 at 5:02 pm, Sam<EMAIL_ADDRESS>wrote:

No worries! I'll let you know if I think of anything else to try.
I'll leave this issue open here so you can keep me updated.
All the best.
Sam.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-748431337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y7NXNO24DKUHAET73LSVRFY7ANCNFSM4UIJ7N7Q
.

unfortunately still no lock (Pll not locked also)
I will update you in an hour mate as have Joes software which I intend to
use with Noaa, Meteor, Metop but have gk-2a option and will send
information through on any issues or problems
My main aim is xrit-rx on the Pi ( easy great code )   and joes software
with my Sarctrac rotator with my 2nd wifi modded for 1.7ghz -  for the
other stuff  (Geo orbit ) with my laptop and airspy mini which ill have
access to on monday/tuesday .
My qhf is all working well for apt so these are the other goals   screen
grabs below from first attempt with your config
On Sat, Dec 19, 2020 at 5:03 PM Adam SkyPixelDS<EMAIL_ADDRESS>wrote:

Awesome, thanks!
On Sat, 19 Dec 2020 at 5:02 pm, Sam<EMAIL_ADDRESS>wrote:

No worries! I'll let you know if I think of anything else to try.
I'll leave this issue open here so you can keep me updated.
All the best.
Sam.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-748431337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y7NXNO24DKUHAET73LSVRFY7ANCNFSM4UIJ7N7Q
.

Sorry Sam
I tried 30 as gain first then 5 through to 14 with ctrl c stop and start
every time
On Sun, Dec 20, 2020 at 8:11 AM Adam SkyPixelDS<EMAIL_ADDRESS>wrote:

unfortunately still no lock (Pll not locked also)
I will update you in an hour mate as have Joes software which I intend to
use with Noaa, Meteor, Metop but have gk-2a option and will send
information through on any issues or problems
My main aim is xrit-rx on the Pi ( easy great code )   and joes software
with my Sarctrac rotator with my 2nd wifi modded for 1.7ghz -  for the
other stuff  (Geo orbit ) with my laptop and airspy mini which ill have
access to on monday/tuesday .
My qhf is all working well for apt so these are the other goals   screen
grabs below from first attempt with your config
On Sat, Dec 19, 2020 at 5:03 PM Adam SkyPixelDS<EMAIL_ADDRESS>wrote:

Awesome, thanks!
On Sat, 19 Dec 2020 at 5:02 pm, Sam<EMAIL_ADDRESS>wrote:

No worries! I'll let you know if I think of anything else to try.
I'll leave this issue open here so you can keep me updated.
All the best.
Sam.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-748431337,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2Y7NXNO24DKUHAET73LSVRFY7ANCNFSM4UIJ7N7Q
.

Sam
I have some interesting information. Joes Software wouldn't work - At first , Though now I see an issue which looks like could be the reason why Pi not working !
Ok so I have attached screen shots of the outcome. I'm using spyserver and was able to run sdr# at the same time and at first i had no signal on 1,692.140 .. I've had this issue before, If I after booting change the freq to 1,492.140 and then back to 1,692.140 I then see a good signal ! ... personally I don't understand why. then If I run Joes software I get a lock ! . If I unlpg the sdr and close all software and dont run sdr# first joes software wont lock ! . if I stop the software and do the above steps changing freq in sdr# start joes software it works .  I will attach screen grabs sorry if to many Sam -  My question is can we port spyserver to goestools ? or can we have it change freq to test this theory I have ?   Maybe its just my sdr but I have also used my other sdr which i will point out hasn't got the thermal protection as the sdr-blog v3 has.  Hope in someway this helps or just proves I have a half faulty sdr which needs a push. either way I hope still to have your software for my Pi running Xrit-rx as this is the one I want for gk-2a and not the laptop.

Sam, I hope this all helps and look forward to a reply .   I had ordered a nooelec e400 extended range and sawbird last month and have an airspy Mini here Monday Tuesday so this can be closed if you like .   Or I would be happy to take steps to see if can be resolved if you want to dig deeper. I hope In someway this may have helped someone who might have come across the same problems - But ( noob here ) Could be all along what you had thought simply regarding config. Though I have tried the other config you sent and still no packets mate
cheers
Adam

Hi Adam,
That's very strange. I can't say I've seen this issue before. I'm happy to leave this open until you have a working setup either with a new SDR or your current one.
I have run out of ideas for this one unfortunately. Let me know if you try it out with your Airspy Mini when it arrives.
I'll let you know if I come up with anything else to try for the RTL-SDR.
Sam.

Hey Sam
Thanks for getting back to me and also all the help.
I thought it’s strange also. Though I have a couple ideas to test settings
in spysever and if see signal without having to change frequency in sdr#
first -  transfer them to the goestools config see if it works.
Will get back to you and let you know the outcome regarding Airspy mini and
also the nooelec extended range when it arrives. I will within the week let
you know how I go with the Airspy mini. Have a fair bit on next few days as
had family arrive.
Have a great Christmas mate and merry Christmas
Cheers
Adam
On Tue, 22 Dec 2020 at 4:09 pm, Sam<EMAIL_ADDRESS>wrote:

Hi Adam,
That's very strange. I can't say I've seen this issue before. I'm happy to
leave this open until you have a working setup either with a new SDR or
your current one.
I have run out of ideas for this one unfortunately. Let me know if you try
it out with your Airspy Mini when it arrives.
I'll let you know if I come up with anything else to try for the RTL-SDR.
Sam.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sam210723/xrit-rx/issues/20#issuecomment-749360768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4V2YY4FXTLV7HPTTPM3BTSWAZZHANCNFSM4UIJ7N7Q
.

Will update you soon with more results mate. Airspy mini working right away.  loving the program and webpage interface ! will update this before  I close it with any findings for the rtl-sdr blog v3 . personally I think its faulty - ish
Adam

Hi Sam
Ok I have a outcome that might help others. I got a Nooelec Sdr extended tuner for Christmas. Plugged it up and changed the config to your guide and straight away it worked like the airspy mini. good lock and working well.
I personally think i had a half faulty rtl-sdr blog. to confirm this if people have this problem follow these steps.

run spysever on Pi or install sdr sharp on Pi
If when you open sdr sharp and go directly to 1.692.140
If when you go this frequency you see no signal follow below step
tune down to 1.492.140 and then back up to 1.692.140
you should now see a signal through sdr sharp and shows you will not be able to use this sdr or similar if you have had issues setting up Xrit-rx you need to use/try another dongle.

I don't know why I'm not smart enough to answer that but from what I've learnt from Sam and taught myself I personally think the rtl-sdr blog v3 may work for this but mine I feel was having issues this high in the spectrum and needed a kick in the bum to work just in sdr sharp on linux/Pi. this maybe a linux issue only though as I have not seen this issue in windows when tuning to the frequency straight away.  I hope this helps someone who faces this issue at some point

Hi Adam,
This sure is a strange one. I know of many people using the RTL-SDR Blog v3 dongle for GK-2A and I had not heard this one before. I'm glad your setup is working now!
I'll close this issue for now. Enjoy the images!


Cannot setup environment on server to run code

To run scilons_pipeline.py, I've been trying to build an image on slurm and install the datatrove[all] package (as per the instructions in the README).
I've tried to re-use several images from /netscratch/enroot (e.g. python+3.10.4-bullseye.sqsh, ubuntu20+conda.sqsh) and then installing the packages but always end up with incompatibility issues in the installed packages, which results in not being able to use the image.
E.g. when I build on ubuntu20+conda.sqsh and install the datatrove library I get:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
conda-repo-cli 1.0.75 requires requests==2.31.0, but you have requests 2.32.3 which is incompatible.

However, the required version of requests in incompatible with the datasets package.
Once I save the image and use it to run the code it cannot find any of the modules.
Any ideas on how to build an image to run the code? Maybe another I need to use another image to install the package in?

Do you need requests for anything in the pipeline? My best guess is that you can simply ignore this error message.
You can also use one of my images: /netscratch/mostendorff/enroot/malteos_eulm_podman.sqsh
It has datatrove==0.2.0 installed.

Thanks! Your image works. :)
However, now when I run the pipeline and it gets to the slurm execution part to launch a job from within the script, I get the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'sbatch' srun: error: serv-3317: task 0: Exited with exit code 1
I tried to look at similar issues (e.g. this one) but they didn't solve the issue.
Any ideas?

Slurm commands are not available within a containerized compute job. See https://github.com/scilons/datatrove/blob/main/src/datatrove/executor/slurm.py#L35
You need to start the Slurm pipeline from a login node or rewrite it to use a local execution pipeline.

The local pipeline works fine and can be ran with an interactive job. I'm wondering if we want to use the slurm, should I create the environment directly in the login machine and run it there?

I've installed mamba and set up a virtual environment, then I ran it from there. I'm closing this, feel free to let me know if you have further questions


Way to pass a vpn container as a network service. Ie gluetun

Hello.
Wondering if it would be possible to add support for the dockers network modes ie "service:containername" or --network=container:containername to be passed to each rooms container.  More info here on gluetun https://github.com/qdm12/gluetun-wiki/blob/main/setup/connect-a-container-to-gluetun.md
Doing it this way would force the entire containers networking to go via the vpn container and not allow local access to the network at a container level.
I can still publish the ports required via gluetuns port mapping feature here https://github.com/qdm12/gluetun-wiki/blob/main/setup/port-mapping.md so normal functionally would not be impacted.  To note however no ports need to be published on the room container as its prepublished on the gluetun container.
I have tried passing NEKO_ROOMS_INSTANCE_NETWORK=container:gluetun however rooms reports that it cannot find the network.
Is there a way i can pass gluetun to these spawned room containers with the mentioned docker feature?
Thanks.

Hi, currently it's not possible to set via neko-rooms because neko rooms was initially only working with traefik and even until today relies on docker nektowrking. The alternative solution is to use proxy, see https://github.com/m1k1o/neko-vpn/
There would need to be implemented other way of proxying using e.g. unix sockets or as well port allocation for frontend ports (same as webrtc ports) if they all would share the same network.


[Fix] Use CordovaPreferences on Android.

Since Cordova Android 4.x, preferences are no longer written in the intent extras and the preferred way is to use CordovaPreferences.
See here: https://github.com/apache/cordova-android/commit/a64203f8174b42d6359f0bbdc7b69d96497b203a
CordovaPreferences is available starting Cordova Android 3.6.x.

awesome. thanks dude!

Hi, could you make a release of this version (cordova plugins registry or npm).
Please :)

@mkliu ?

@micky2be sure

@micky2be interesting, my name is micky too..

Thanks Micky ;)


[Dev] Aqua tests

@PierreMartinon I found how to use Aqua without being warn for dependencies. See https://github.com/control-toolbox/CTBase.jl/blob/main/test/test_aqua.jl.
When Aqua is used, you can add a badge. See https://github.com/control-toolbox/CTBase.jl/blob/a9744ff7cfaed4126c2bdbddce55b8adbf344010/README.md?plain=1#L38.

@ocots I created a workflow to use Aqua.jl without adding it as a dependency:

https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/main/.github/workflows/Aqua.yml

I preferred this approach for Krylov.jl and the other packages in JSO because it doesn't pollute Project.toml.

@amontoison Maybe we could add something like:
PKG_SRC_PATH=`pwd`
PKG_SRC_NAME=`basename -s ".jl" $PKG_SRC_PATH`

to get the name of the package instead of hard-coding Krylov.

Good idea @ocots! I will try it.
I did the script 2 years ago and was too lazy to make it generic.

-> https://github.com/JuliaSmoothOptimizers/Krylov.jl/pull/873


Add vehicle configuration

[x] Enable composed configuration of vehicles

[x] urdf dynamics model
[x] tire params
[x] controller params
[x] chassis params
[x] visual model
[x] vehicle type

[x] Add heavy truck physics model
[x] Add heavy truck visual model
[x] Add light truck physics model
[x] Add SMARTS_ASSETS_PATH
[x] Move smarts.core.models to smarts.assets.
[x] Enable configuration substitution in smarts configuration files.
[x] Use urdf chassis size as Ackermann vehicle size.
[x] Fix tests.

Closes #2120 #2116

test-docs failing is expected until the smarts.assets module exists.


ui/settings style

Improvements to the settings styles, light mode and dark are now respected:

looks much better.. lets merge it, then I will apply some visual modifications


Remove suites from the model

There is should be a few more changes:

Remove titles from the model
Add fixtures to the model
Add parameters to the steps

The first draft is ready https://github.com/allurefw/allure2-model


Repo sync for protected CLA branch

The pull request is created from main637933646149276423sync_temp to main to fix git push error for protected CLA branch

@ghogen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Setup plugin continuous publishing

Setup details
Currently the publication of the plugin in chrome store is done manually, however, it is necessary to automate this process using the Google API.
The CI Pipeline will follow the stages described in the document defined in plugin pipeline.
Acceptance Criteria

[ ] Set up publication stage in Gitlab CI

Chrome extension deployment automation example: https://gokatz.me/blog/automate-your-chrome-extension-deployment-in-minutes/


Correct requests/sec avg in README

According to the output here: https://github.com/iron/iron/wiki/How-to-Benchmark-hello.rs-Example

Requests/sec:  72479.41

Fair enough, thanks.


All .io domains don't seem to parse

I'm using the latest version of whois-parser and whois, the raw record is returned but the parser data seems to empty for everything.
Before I look into it further I wanted to see if this is the case for others as well or if it's just a local issue.

It looks like .io whois is returning as BaseIcannCompliant now.

Looks like it's pretty close to BaseIcann except the Expiry Date has a different title.  Working on a PR and the tests.

.IO moved under Afilias system, hence they are using an Afilias-alike response. I also assume Afilias changed lately to have their system inline with ICANN requirements (which probably also make the base_afilias parsers obsolete).

Looks like #94 addresses this. Would love to see that merged and released.

Closed by https://github.com/weppos/whois-parser/commit/85c956c1b766cf3389e8f8f997c11ee0ae92414e


Duration view on custom cell

I set allowedVideo to false.
Probably you should set cell?.durationView?.isHidden to false value by default.
I understand, that I can handle it in my custom cell, but it will be better do it in TLPhotoCollectionViewCell

Hi, @EgorVeremeychikEffectiveSoft
The option is not to allow video selection. That's why it's hidden.
allowedVideo == false
not want show video type assets -> durationView.isHidden = true

@tilltue Yes, right!
But in my custom cell durationView.isHidden = true by default.
I set allowedVideo to  false, but I still see durationView with durationLabel


[Seeking Feedback] Date API

So I'm looking to clean-up the way dates are referenced in templates. Curious for people's feedback on different approaches.
The current/old way of doing this was all the date properties from the WP database were attached to the TimberPost object:

TimberPost->post_date
TimberPost->post_date_gmt
TimberPost->post_modified
TimberPost->post_modified_gmt

To use the date in a template you would most likely use the display_date method:

Posted on {{post.display_date}}

... which used the date format set in the WordPress admin. However #224 simplifies this, so you can just do..

Posted on {{post.post_date|date}}

From here...
I want to continue making the twig api for this cleaner. As we have post.title, post.content, I think it makes sense to have post.date
Approach 1: Properties
This could be as simple as taking all 4 date properties (listed above) and removing the post_ prefix. Thus in a template you could do:

Posted on {{post.date|date}}

or:

Last updated: {{post.modified|date}}

Questions

Is {{post.modified}} intuitive? Does {{post.date_modified}} make more sense?

Approach 2: Objects
This would involve transforming the date properties into little objects so that templates could use dot syntax:

Posted on {{post.date|date}}

Posted on {{post.date.modified|date}}

Posted on {{post.date.gmt|date('M jS, Y')}}

Questions

Does {{post.date.modified}} or {{post.modified}} make more senese?
Is this needlessly complicated?

Interested to hear some feedback. After writing this up I'm leaning towards approach 1 as it seems much simpler and just as good as writing an object-based approach. But maybe there are benefits/opportunities I'm overlooking.

WordPress allows manual timezone offset, so it might not be possible to create a PHP DateTime object with proper timezone set in all cases... This is unfortunate, as I have to be careful when to use post_date vs post_date_gmt, which are both just strings!


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/220 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit c066167:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Onlaunch Quit mode doesn't work

Is there anyway you can add a feature to use :sleep, :restart, :shutdown like a normal command that will quit Onlaunch?
When I sleep using :sleep, after waking pc from sleep, app still shows up instead of quit but If I use a shortcut to a sleep command line, app quit!

You can use :quit to quit the launcher. I'm not sure if that's what you are asking for. Can you please explain further?

You can use :quit to quit the launcher. I'm not sure if that's what you are asking for. Can you please explain further?

Hey!. Thanks for the quick reply!
The issue can be replicate as follow: Set OnLaunch to Quit, Use :sleep to Sleep PC, wake PC up and the App still shows up instead of quit -> OnLaunch set to Quit supposed to quit the App when using Sleep but nope :(

@WilliamLeGod So you are expecting the launcher to quit immediately after the PC wakes from sleep? The OnLaunch only affects when launching an application, not for special commands.


content-type header is not sent

The Content-type: application/json header is a requirement for many servers, and should be sent as part of the introspection query

Hi 👋🏻
Thanks for the issue. Great point. However ive left this up to the graphql-config file for the user to define this.
The spec stipulates a new application/graphql+json header — so cannot assume this.
You could do this;

.graphqlconfig.json

{
  "projects": {
    "webapi": {
      "schemaPath": "data/webapi.schema.graphql",
      "extensions": {
        "endpoints": {
          "dev": {
            "url": "https://api.graphql.online/web/api/graphql",
            "headers": {
              "content-type": "application/json"
            }
          }
        }
      }
    }
  }
}

That being said, I could quite possible provide this header as a default — unless the user decides to change it 🤝

application/json is a default content type of other is not configured.
Buried somewhere very deeply, so one need to use some defaults here, or delegate responsibility to UrlLoader
https://github.com/ardatan/graphql-tools/blob/master/packages/loaders/url/src/index.ts#L375

schema loading is for sure a very deep concept, could go from this library (the basic and very enterprise friendly case) all the way to graphql codgegen for local schema files etc.
Using something like url-loader has cross my mind before, but there is an entire eco-system surrounding that, so if you need that level of complexity. Better to use that eco system entirely.


installing with NPM doesn't include bg.png

I think it's missing from package.json?

It's no longer used. See the new CSS: https://github.com/tastejs/todomvc-app-css


Courtesy push pipeline should notify on failures

Issue Description
This is related to #14230 - right now if our courtesy push pipeline fails, it does so silently. We should add an extra step to the pipeline that checks if it was a courtesy push run, only runs on failure, and notifies the team that it failed so that we can manually intervene. It could use our slack integration like we do here - https://github.com/microsoft/azure-pipelines-tasks/blob/f462aeacedf56ceeeacd3d29027471a59573eaee/ci/courtesy-push.yml#L57
I'm routing this to our ABTT team, I'm happy to help out on this one though, just ping me or tag me here if any questions pop up

Created PR

Created PR


Include a database_url in env variables

How I can declare DATABASE_URL equals heroku in enviroments variable?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d21b6ef-2440-f2b7-7f38-465ade7c14c6
Version Independent ID: 9b2ebcef-924d-6850-9c27-4f14a2b45b53
Content: Build and test PHP apps - Azure Pipelines
Content Source: docs/pipelines/languages/php.md
Product: devops
GitHub Login: @steved0x
Microsoft Alias: dastahel

I found. Exists a configuration button in pipeline edit.


native.keyboardshow Not Firing

I have a simple function that changes the text of a div on native.keyboardshow with cordova v. 3.5 on an ios app. The emulator has it working great on the iphone io 6.1 but its not firing on iphone retina io 7.1

In my case I just needed to add IonicKeyboard.m to the Target Membership in Xcode

update on this ?

Hmm haven't seen this yet, if someone posts some code replicating the issue I'll take a look.

@tlancina I solved this.  It's not an issue with the ionic keyboard plugin (persay), it's an issue with events getting lost when the keyboard pushes the page upwards.  The ghost click ios fires to focus the input on touchEnd is positionally based and doesn't hit the right target since the target has since moved.
In theory the problem is done away with if you implement a fastfocus mechanism (which you probably should be doing anyway), but it's also something I hit often enough until I did it should be mentioned in the docs with a solution.

@runspired ahh the curse of the 300ms delay :) Thanks for posting your findings! Although that seems strange, since on iOS the event is fired with UIKeyboardWillShow... which I have never observed to not happen when the keyboard did in fact show, regardless of focus or not.
I'll leave this open for now for others who may be having issues, or, if I can replicate it I'll add it to the docs.

This plugin also doesn't fire with none native keyboards. like swiftkey...
is there a solution?

@runspired I've ran into this on android and was wondering if you could elaborate on your fix...
I'm already using a fastclick library and it happens (native.keyboardshow doesn't fire) even when the input isn't shifting on focus..

Still having this problem in Cordova 5.4, any updates?

Is there any fix for this? I have been losing sleep over this for weeks. The plugin behaves very inconstantly on Android, especially due to the variability and inconsistency of the platform.

still having this issue....
cli packages: (/Volumes/Projects/clockwise/mobile/node_modules)
@ionic/cli-utils  : 1.12.0
ionic (Ionic CLI) : 3.12.0

global packages:
cordova (Cordova CLI) : 7.0.1

local packages:
@ionic/app-scripts : 2.1.4
Cordova Platforms  : android ios 4.4.0
Ionic Framework    : ionic-angular 3.6.1

System:
ios-deploy : 1.9.2
Node       : v7.5.0
npm        : 4.1.2
OS         : macOS Sierra
Xcode      : Xcode 9.0 Build version 9A235

Misc:
backend : pro


Fix add delete of rows with buttons

Redmine #6101
Forum https://forum.pfsense.org/index.php?topic=109554.0

Changed this slightly to only increment the deleterow button. There is usually only one button per row, but it is possible to have more so this seemed safer.


Illegal instruction (core dumped)

Describe the bug
Getting "Illegal instruccion (core dumped)" when i try to start docker container
To Reproduce
Steps to reproduce the behavior:

Deploy "docker-compose.yaml" in old cpu (x86-64-v1)
See "container logs"

container logs
Container started
Illegal instruction (core dumped)
Illegal instruction (core dumped)
Container stopped
Container stopped
Container started
Illegal instruction (core dumped)
Container stopped

Expected behavior
Run without problems
Desktop:

OS: Archlinux
CPU: AMD Turion II Neo N40L (1.5Ghz) K625
PC: HP Microserver N40L Gen7
Docker tag image: latest
Docker tag version: 0.4.1-hotfix.2

Additional context

mysql related issue: Using latest mysql failed because need a newest set of instructions (x86-64-v2).
bun related issue: As i see, AVX2 is the minimal instruction set

Possible Workarround
Intel CPU can be emulated using intel-sde
Mentioned in the followed bun issue

bun issue 181(comments)
bun issue 282(comments): intel-sde slow down all process

PD: bun need a cpu with AVX2 support(x86-64-v2), any cpu newer than 2013 fit this. I think is a good idea to take note in documentation. This will help people with older setups.
Edit: (PD2 problem is solved with v0.4.1-hotfix.1)
PD2: I tried in my laptop (x86-64-v3) and can work :D

Hello @DeathGabox!  I guess I'm not great with these "big" releases. Always something that needs fixing right away!
Glad it started to work for you. https://github.com/goniszewski/grimoire/releases/tag/v0.4.1-hotfix.2 provides also some crucial fixes for the initial deploy of the app.

I am going to close this issue as solved because is not a problem with grimoire but bun
This cannot be solved until bun are interest in his Roadmap or Priorities
If you encounter this in deploy, update your CPU to any with support to instruction x86-64-v3 (AVX / AVX2)
To view you cpu instructions
Linux

Use grep avx2 /proc/cpuinfo
This command extract the flag from "/proc/cpuinfo" in your cpu, if you get blank as output, you dont support avx2

Example: Success

❯ grep avx2 /proc/cpuinfo
flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb pti ssbd ibrs ibpb stibp tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp vnmi md_clear flush_l1d arch_capabilities

Example: Failed

❯ grep avx2 /proc/cpuinfo
❯ [1]>

Use /usr/lib/ld-linux-x86-64.so.2 --help
This command help to see if your libraries are detected

Example: Success

...
output ommited
...
Subdirectories of glibc-hwcaps directories, in priority order:
  x86-64-v4
  x86-64-v3 (supported, searched)
  x86-64-v2 (supported, searched)

Example: Failed

...
output ommited
...
Subdirectories of glibc-hwcaps directories, in priority order:
  x86-64-v4
  x86-64-v3
  x86-64-v2

Windows

You can see your cpu instructions with cpu-z

Thanks goniszewski for this repo and hard work in open source and solve issues, its a awesome tool ^^
Happy Bookmark Everyone!


API to get dependencies of old package versions

What's the problem this feature will solve?
Currently the https://pypi.org/pypi/{pkgname}/json API includes data about the requirements under requires_dist but it only includes the metadata for the most recent package version. The old releases are under releases but they have no requirements data. If pip decides on an old version of the package, then if possible it uses LazyWheel to load just the dist-info part of the wheel and read the requirements. Otherwise, it loads the entire wheel.
This seems needlessly complicated to me. I work on Pyodide and we have a small package manager and installer we call micropip. Because of the nature of the browser, packages will have to be installed on every page load, thus speed of dependency resolution is important. We have difficulties with range requests because pypi doesn't set the correct CORS headers on range requests pypa/conveyor#11. We can cache the dependencies of packages in the IndexedDB or other persistent stores to speed up subsequent loads.
Describe the solution you'd like
If CORS headers were included on responses to range requests (resolving pypa/conveyor#11), we could use the same LazyWheel strategy. This would be better than the current situation where we have to pause dependency resolution to wait for wheel download.
However, it seems to me that any of the following options would be better:

Update https://pypi.org/pypi/{pkgname}/json so it returns dependencies of all old versions of packages, say under .releases[version][wheel_index][dependencies] or somewhere else.
Add separate endpoint that returns the dependencies of all versions of a package, or an endpoint that returns dependencies of some particular version.
An API to ask for just the dist-info part of a wheel.

This would benefit us at Pyodide, but also I believe that it would allow on the order of ~300 lines of LazyWheel related code to be removed from pip in favor of the more simple approach of having an API that returns the data needed as JSON.

Add separate endpoint that returns the dependencies of all versions of a package, or an endpoint that returns dependencies of some particular version.
An API to ask for just the dist-info part of a wheel.

I believe this would be discussed in https://github.com/pypa/warehouse/issues/8254

Right, it was a bit hard for me to believe this didn't already exist. Thanks! I guess I should close this as a duplicate.

Well, if we decide to go through the route of your point number 1, then maybe this is not a duplicate :) Let's see what the other say.

Right. I guess it would also be very helpful for us if https://github.com/pypa/conveyor/issues/11 were fixed and also if the range for the Metadata wheel were exposed in somewhere (just saying which range to grab would allow LazyWheel to be drastically simplified).

Closing this as a duplicate of #8254.


Add Data string accessor

Adds a new stringAccessor function in class Data which is implemented in subclasses Element and Aggregate. The Data.bindingToString function uses stringAccessor as a helper to provide better ref names in error messages.
Examples:
Connection between sink (UInt<8>(Reg in DataAccessorSpec_Anon)) and source (UInt<8>(Reg in Inner)) failed @: ... becomes
Connection between sink (UInt<8>(Reg in DataAccessorSpec_Anon)) and source (UInt<8>(Reg in Inner.myReg)) failed @: ...
class Foo extends Bundle { val foo = Vec(2, UInt(8.W)) }
class Example extends Module {
  val tpe = new Foo
  val io: Foo = IO(Input(tpe))
  println(io.foo(0))
}

Used to print: UInt<8>(IO in unelaborated Example)
Now prints: UInt<8>(IO in unelaborated Example.foo[0])
Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

performance improvement

API Impact

None
Backend Code Generation Impact

None
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Thank you @seldridge for reframing this, point well taken.
As Schuyler suggests, we shouldn't conflate .toString with error messages. They've been intertwined in the past and this is a good opportunity to do it right. That being said, I think improving the default .toString to give new users more useful info is still a good idea, and is a stepping stone that forces us to think about the information we want available (in a String format) and how to present it.
I still think MyModule.io.bar[1]: IO[UInt<8>] is the right .toString for bound Data (although maybe we should work in direction as well), but I think it's worth separating out each piece of that String as a separate [internal] API:

Parent Module name

eg. MyModule
this is just _parent.get.toString (except Option safe of course)

Component name

eg. io
this is the "ref" of the top of the binding. It's not set until module close but we can get a pretty good guess by splitting out the code that calls .forceName and putting that in a method on Data

Sub-Component name

eg. .bar[1]
This information is available in the refs of those components (the Slot and whatnot)

Binding

eg. IO
Easily derivable from the binding

Chisel Type

eg. UInt<8>
This should be the same as if you were printing an unbound Data of the same type (eg. this.cloneType.toString, don't implement it that way but that's the behavior)

Direction

eg. Input
This isn't currently in the .toString so maybe shouldn't be, but it'd be useful to be available for error messages

Note that all of this only applies to bound Data (that is not a literal). The current names for literals and regular unbound Data should be kept the same.
If we provide these as internal building blocks, we can then use them to make good error messages. Thus for the original task of improving connection error messages, I see a 3 phase process:

Provide [internal] APIs for the Strings we want and make toString better (this PR)
Use those strings to make good error messages for connections (next PR)
Also provide carets pointing to the source code line (later, unscheduled work)


Fix 404 broken links

Links for <Code /> and <Prism /> lead to 404

Ahh, I actually saw that those links are fixed by #376 so I am closing this one.


packager: update the font version in the title after updating a PR

Thanks, sgtm.

The font version still needs to be updated after updating a PR.
A recent example is HostGrotesk PR. I just manually updated the font version in the PR title.
Given that the title appears on the boards, having the correct version is key during PR revision and when creating push lists :)


Add verbosity options, prompting, .bowerrc handling, tests and CI.

This PR add a lot of functionality and refactores the plugin.
Refactoring
I've taken the freedom to refactor the plugin to smaller methods instead of one large one. This makes to code more readable.
Verbosity option
As requested in #34 the ability to keep the plugin quiet could be nice.
I've implemented the verbosity option with three levels.

1: no log
2: error log
3: info (default as it is now)

Prompting / interactive
When a dependency cannot be resolved the plugin throws an error. As suggested in #35 this is due to the missing catch of event prompt.
I've implemented this and set an interactive option to enable user interaction. If set to false (default) it throws an error and print en error message. If true, the user may select the prober version.
A short coming of this: It is not possible to output the options directly. By having verbosity level 3 the bower output will display where to conflict arrises.
.bowerrc handling
Implement catch on empty .bowerrc file as mentioned in #43.
If the JSON is not valid or the directory property is not set, use default directory (bower_components).
Tests
To help me and other developers to work on the plugin I've implemented tests written in mocha with chai.  It runs on the gulp task gulp test. There is coverage included in this as well.
Further more I've setup travis to run the tests. It uses the npm testcommand which in turn runs gulp post-coverageand gulp lint. This posts coverage results to codecov.io.
When merging this PR the travis setup must be done on this repository. No setup is required on codecov.
API
I've added a section in the readme with a condensed API description for the available options.

Merged


Community Standards guidelines and policies are templates and need refinement

Describe the Feature / Enhancement
In #8, we introduced templates for the following:

Code of Conduct: CODE_OF_CONDUCT.md
Contributing Guidelines: CONTRIBUTING.md
Security Guidelines: SECURITY.md

All three of these are template files and need to be refined to better apply to our community and our project. I'd love any and all teams to provide input on this so we can have documents that better reflect all of us.
Additional Details and Resources
Don't forget to run Alex before committing and pushing changes to check for insensitive or inconsiderate writing:
pnpm alex:check

Once the changes are ready to go, they should be copied over to the backend project as well.
Correct Project Selected

[X] This issue is linked to the appropriate project.

Labels

[X] This issue has appropriate labels.

Also: should we have a changelog?


tabs without autoselection

Ionic version:  (check one with "x")
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] feature request
Current behavior:
I can change the default selected tab, however I cannot start without any selection.
When defining tabs, I can either hide the tab button together with it's tab, nor not at all.
(I cannot hide the button only without adding custom css)
Expected behavior:
I want a page showing some meta information and some tabs with none of them selected at first.
(While still showing the tab bar)
Steps to reproduce:
I tried setting selectedIndex="-1" but that still selects the first tab.
Related code:
<ion-tabs selectedIndex="-1">
  <ion-tab root="DashboardPage" tabTitle="Dashboard" tabIcon="home"></ion-tab>
  <ion-tab root="FirstPage" tabTitle="First" tabIcon="flag"></ion-tab>
  <ion-tab root="SecondPage" tabTitle="Stats" tabIcon="star"></ion-tab>
</ion-tabs>

Other information:
As a workaround, I added a hidden tab: Another Page called HomeMeta which I added as the first tab and then made invisible by adding this scss rule:
.tabbar .tab-button:first-child {
  display: none;
}

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!

I already did talk about this in the slack channel.
And I did not file it as an issue but rather as a feature. :)

Ahh sorry about that! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#235


[BUG] Multiblocks unforming when operation starts

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

[2.0.0-16 and 2.0.0-10,11,12

Why is this important?
Knowing the version of Advanced Rocketry helps us narrow down an offending piece of code faster because we can easily determine what code is added and when.]

Have you verified this is an issue in the latest unstable build

[ ] Y
[ ] N
[x] N/A

[Why is this important?
If you're not testing with the latest build, you may be encountering a bug that's already been fixed.
Reporting bugs that have already been fixed wastes everyone's time.  (please look in open issues too, somebody else could have already reported it!)]

Version of LibVulpes

[1.0.2-27

Why is this important?
Advanced rocketry depends on a library mod (LibVulpes), some errors can really be in that mod.  So knowing the verison helps us not only start looking for fixes there without you needing to anwer more questions, it also helps us know if you have a version mismatch.]

Version of Minecraft

[1.16.5

Why is this important?
Different versions of minecraft have different codebases for Advanced Rocketry.  Knowing the version of minecraft (and thus AR) helps us pinpoint issues quicker!]

Does this occur without other mods installed

[x] Y

If Y, what is the MINIMUM set of mods required.
Lib Vulpes, Advanced Rocketry and JEI (for testing convenience)
[Why is this important?
Sometimes interactions between mods cause issues.  While it can be a problem with Advanced Rocketry, sometimes it's not.  When there are a lot of mods, it can take bugtesters HOURS to go through the list to determine the root cause.  When there are a lot of bug reports, that can add DAYS to the time it takes to fix a large set of issues.]

Crash report or log or visualVM (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read

[insert here

If it's an issue involving lag, please submit a visualVM sampler snapshot.  Mods like lag goggles often do not provide the kind of information needed to debug lag.
For more information on how to create a snapshot, please see "How to Run CPU Sampling" here.  Then export the snapshot as an .nps.  You may have to zip it since github is weird, then please upload it here.

Why is this important?
Full crashlogs contain valuable information like where exactly in the code the error occurred, what other mods may be running and what version of forge you have.  This helps us replicate and diagnose the issue FAR faster.]

Description of the problem

[After assembling a multiblock (personally tested with rolling machine, lathe, precision assember, crystalliser and electric arc furnace) provide power and the resources for any recipe and enter the main GUI, click the I/O button to switch the machine on and it will immediately close the GUI and the formed mulktiblock structure will revert to the component blocks

Why is this important?
If we cannot reproduce the problem, we probably cannot fix it at all.]

i got same problem,is there any solution?

I've got this problem too, is it already solved in the newest version?

im getting the problem too

Yep, same here. Annoyingly it also deletes your resources when this happens, I had to restore a backup because of this after losing my MekaSuit chestplate :(
Fortunately the backup was recent enough that I didn't go back on too much progress, still frustrating though

Checking my logs, it appears something is wrong with the recipe manager; check the recipesmachine class...
[16:26:27] [Worker-Main-4/WARN]: Cannot add recipe!
[16:26:27] [Worker-Main-4/WARN]: null
	zmaster587.libVulpes.recipe.RecipesMachine.addRecipe(RecipesMachine.java:324)
	zmaster587.libVulpes.recipe.RecipesMachine.addRecipe(RecipesMachine.java:397)
	zmaster587.advancedRocketry.tile.multiblock.machine.TileChemicalReactor.registerRecipes(TileChemicalReactor.java:158)
	zmaster587.advancedRocketry.util.RecipeHandler.registerAllMachineRecipes(RecipeHandler.java:36)
	zmaster587.advancedRocketry.AdvancedRocketry.load(AdvancedRocketry.java:443)
	net.minecraftforge.eventbus.ASMEventHandler_1164_AdvancedRocketry_load_FMLCommonSetupEvent.invoke(.dynamic)
	net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85)
	net.minecraftforge.eventbus.EventBus$$Lambda$2441/1622230027.invoke(Unknown Source)
	net.minecraftforge.eventbus.EventBus.post(EventBus.java:302)
	net.minecraftforge.eventbus.EventBus.post(EventBus.java:283)
	net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:120)
	net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:121)
	net.minecraftforge.fml.ModContainer$$Lambda$3979/1651924497.run(Unknown Source)
	java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618)
	java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610)
	java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689)
	java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

Im having this same issue too.

Is it already fixed? I really need the working version...

It's almost like the mod is in alpha or something, isn't it?


drivers: spi: nrfx: fix a CMakeLists.txt bug introduced in #15445

Fix incorrect lowercase logical operators in a CMakeLists file.
Signed-off-by: Andrew Fernandes<EMAIL_ADDRESS>

Paging one or more of @ioannisg, @carlescufi, @anangl, @jarz-nordic, or @nordic-krch...
Sorry for the bother. I don't know how this got through my testing. I guess my inexperience with CMake and Kconfig conspired against me! 😞
The original (already-merged, buggy) PR is #15445.
This same patch on master is #15914.


TargetThermostatMode and ThermostatMode erroneously assumed equivalent

TargetThermostatMode is described by the following enums:

0 - Off
1 - Heat
2 - Cool
3 - Auto

(See https://github.com/KhaosT/HAP-NodeJS/blob/master/lib/gen/HomeKitTypes.js#L2342)
CurrentThermostatMode is described by a similar, but reduced, set of values:

0 - Off
1 - Heat
2 - Cool

(See https://github.com/KhaosT/HAP-NodeJS/blob/master/lib/gen/HomeKitTypes.js#L555)
It would be illegal for a thermostat to report itself as currently "autoing" the house, per the spec.

@beowulfe #62 is the fix which takes the approach you suggested, and preserved backwards compatibility


use vim.fs.find instead vim.fn.findfile

it seems that vim.fn.findfile could not work (neovim 8.2)
use vim.fs.find instead it

vim.fn.findfile always return empty string ""

While I appreciate the proactive PR, I have some questions about the bug you're reporting. Are you saying that :lua =vim.fn.findfile("justfile", "path/to/dir;") is always returning an empty string? Even when there is a justfile in that or a parent directory? I haven't seen that behavior, and I'm on Neovim 0.8.2. Can you provide a minimal repro directory structure and script?

Here is my config
When I run nvim -u NORC, :lua =vim.fn.findfile("justfile", "path/to/dir;") works. With the configuration above, a empty character is always returned, no matter whether the target file exists or not. It seems to be a problem with my configuration file, I will study it again.

When I set :set wildignore=,.pyc,.swp (comma first), vim.fn.findfile doesn't work. Then I set .pyc,.swp to be ok, it looks a bit weird.
If you use set wildignore+=xxx, there should be no problem. But I don't know how to set it in lua, now use vim.o.wildignore = vim.o.wildignore .. ',xxx'

ok, i found it vim.opt.wildignore:append { "*.pyc", "node_modules" }

By the way, I debugged for a long time, but couldn't find the root cause. When I run OverseerRun, the pop-up interface is not a telescope, but this

This is my configuration, is there something wrong with my configuration?

That said if it's working for you now feel free to drop this. I'll migrate to using more vim.fs.* functions at some point.

it feels reasonable to keep the current code

You're not getting a telescope popup because overseer uses vim.ui.select. The default behavior is to use inputlist(), but you can patch that to use telescope instead. The easiest way to do that would be a plugin like dressing.nvim or telescope-ui-select.nvim

i will try. thank you

Closing since I have since completed the migration to vim.fs.find


This pull request is for test release2.5 please don`t merge it.

What problem does this PR solve?
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

/run-all-tests

/run-all-tests

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 profile=spark-3.0

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 profile=spark-3.1

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 tiflash=release-4.0 test-flash=true

/run-all-tests tidb=release-5.0 tikv=release-5.0 pd=release-5.0

/run-all-tests tidb=release-5.0 tikv=release-5.0 pd=release-5.0 profile=spark-3.0

/run-all-tests tidb=release-5.0 tikv=release-5.0 pd=release-5.0 profile=spark-3.1

/run-all-tests tidb=release-5.0 tikv=release-5.0 pd=release-5.0 tiflash=release-5.0 test-flash=true

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 profile=spark-3.0

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 profile=spark-3.1

/run-all-tests tidb=release-6.1 tikv=release-6.1 pd=release-6.1 tiflash=release-6.1 test-flash=true


Add getL1FeeUpperBound to GasPriceOracle

Added getL1FeeUpperBound based on the spec: https://github.com/ethereum-optimism/specs/pull/25/files
Open question: @mdehoog my understanding is this function will only be live when we have Fjord upgraded so this should be Fjord exclusive.

@mdehoog 💇

extracted the cost function.


Big DNS updates

Anyone tried using OctoDNS to update thousands of records at a time?
We need it for our production environment gradual migration and we wonder if OctoDNS will do the trick.
We already found out that there is a MAX_SAFE_UPDATE_PCENT fixed threshold of 30%, but this can be fixed by passing it from config if required.
We are using NS1 and Constellix as providers.

It should be fine, what you'll likely run into is rate limiting from the provider.
What you might want to do is dump the zone you're trying to migrate, (eg. example.com), change the domain to something new (exampletestzone.com), rename files as necessary, etc and put it in your config, then run it against each provider.
This would allow you to set up a parallel/unused zone with the same amount of records. When you're done you can just delete the test zone.
Potentially as well, because I know both those providers can be secondary DNS servers is just set them up Primary/Secondary and then you only have to push to one. I'd recommend NS1 because their have a much easier to use API.

Nothing inherently prevents it. I don't imagine 1000's would specifically be an issue for octoDNS itself and I've tested that sort of numbers in the past looking into performance issues with specific providers etc. You may run into rate-limiting issues (especially with NS1 where there's on-going work/tweaks around that.) I haven't personally used Constellix so can't say there.

I have used octoDNS for (now) multiple provider migrations and for sweeping TTL updates because one origin provider had a silly default. The only hiccup I hit was the 30% change, which the --force flag overrides. However, I only used after vetting the changes, as it is a hammer with dangerous consequences. And the second is the API rate limiting. Luckily, with the mass TTL updates, the provider was feeling generous, and didn't nerf me. However, some of the mass importing/migrations did ruffle some feathers because of the extra API operations.

thank you guys!


feat: Add commitlint hook

I think it is important to also check commit messages in CI (husky can be easily disabled locally).


ENH better parallel performance for hyperband

This PR swaps the inner and outer loops of the hyperband grid search. This swapping allows hyperband to achieve the maximum amount of parallelism.

@elsander We can merge this next week. I know you are busy.

@elsander I think I got everything.


Geo Search demo - Change the marker on the map when you hover on the result page

A client asked me if it was possible to change the marker on the map when you hover on an item in the result page. like on http://www.beaune-tourisme.fr/se-loger/hotels#!/page/1
Though it's not really related to Algolia, it could be great to show that in the geo search demo.

A custom marker is possible, but it's based on the google marker options (code here). With the replacement of this in InstantSearch.js the demo is visible here (code here)


Amazing

Nice Project Ali,
This has to be an issue but  I'll change the role today haha...
KEEP GOING ALI 🚀🚀✌

Will do bro, thanks a lot for testing out the app :)


Correctly include leeway of rolling timer in age comparison

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[ ] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #1106
Pull Request Description
This fixes the fact that the rolling timer might fire early (due to its leeway) and then reschedule itself until the leeway has passed.

          2 Warnings

:warning:
Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.

:warning:
The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #1107 into master will increase coverage by 0.51%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
+ Coverage   36.92%   37.44%   +0.51%
==========================================
  Files          23       23
  Lines        3870     3870
==========================================
+ Hits         1429     1449      +20
+ Misses       2441     2421      -20

Impacted Files
Coverage Δ

Sources/CocoaLumberjack/DDFileLogger.m
56.23% <50%> (ø)
:arrow_up:

Sources/CocoaLumberjack/DDOSLogger.m
62.5% <0%> (+41.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a34a86...dd863b0. Read the comment docs.

@ffried
Should we wait for a comment from @amberstar just in case ?

@sushichop Yea, I'd prefer that. He did a pretty good analysis of the problem in #1106 and I took a slightly different approach than he described (since I didn't round the value, but added the leeway to the comparison). So I'd like to hear his opinion on this first.

Sure🙂

Thanks, @ffried I like your approach it's more explicit. 👍

Thanks for the approval @amberstar!


Add galleon pack

@liweinan This is just a quick example of how we could get the feature pack working. I didn't do a lot of cleanup, but I thought it was a good example to look at. All the tests are passing locally for me and this should kick off a CI run.
I did add a org.springframework.spring module to the feature pack. I'm not sure whether we should do that or not, but it seemed required for some of the tests as they had a Maven process for doing that and modifying the module.xml files which seemed a bit odd to me.

@jamezp Thanks James! Sorry I missed this PR, I'll check it this week and give you back my feedback.


Task :react-native-android-auto:compileDebugJavaWithJavac FAILED

Hello :)
I am trying to use this package but when I install it and try to run via 'react-native run-android' I am getting this error in the console :
> Task :react-native-android-auto:compileDebugJavaWithJavac FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.9/userguide/command_line_interface.html#sec:command_line_warnings
404 actionable tasks: 3 executed, 401 up-to-date
javacTask: source release 1.8 requires target release 1.8

FAILURE: Build failed with an exception.

Any help is welcome :)

I have the same problem did you solved it?

I faced a similar issue regarding the versions not matching to 1.8, I solved this in Android Studio by
File > Project Structure > Modules > react-native-android-auto
Then make sure Target Compatibility matches the source at 1.8 (mine was 1.7)

I tried that but when I set source/target to 1.8 I get compile errors:
rnandroidauto/CarService.java:20: error: cannot find symbol
import com.facebook.react.modules.core.Timing;

Did you experience this maybe?

@josh-deprogram changing JavaVersion.Version_1_7 to 1_ 8 fixed the problem but after that there is error with "cannot find symbol: import com.facebook.react.modules.core.Timing" ..
So I changed the "CarService.java" in "node_modules>react-native-android-auto>android>src/main>java/com/shopify/rnandroidauto"  with the one that @vvusts suggested and now it works..
But what about this line that package suggested:
import { render } from "./src/car/android-auto/module/AndroidAutoReconciler";
(How can that work ..?)

Ok I see that there are other problems too in the actual package so it's better to use the module that @vvusts suggested 👍  ..
However, it's still not clear to me how to use this package ...


Added a Scale=MatchAveragecase option

Status
READY
Description
I have added a Scale=MatchAveragecase option to complement Scale=MatchLowercase and Scale=MatchUppercase, it simply sets the Scale to the average of what MatchLowercase and MatchUppercase would do. This is usefull when you can't make up your mind whether to use MatchLowercase or MatchUppercase, or when neither looks good, as in the example below (where in my opinion, the MatchAveragecase version looks the best)
Todos

[x] Tests added to cover new/fixed functionality
[x] Documentation if necessary
[x] Code follows expl3 style guidelines

Minimal example demonstrating the new/fixed functionality
\setmainfont{TeXGyreSchola}
\newfontfamily\lc[Scale=MatchLowercase]{Fira Math}
\newfontfamily\uc[Scale=MatchUppercase]{Fira Math}
\newfontfamily\ac[Scale=MatchAveragecase]{Fira Math}
\begin{document}
\noindent
Lower {\lc and UPPER} CASE\\
Lower {\uc and UPPER} CASE\\
Lower {\ac and UPPER} CASE
\end{document}

Thanks! That’s a nice idea. I tried for a few minutes to think of a better name for the option but nothing jumped out at me.
I’m not working frequently on the fontspec code at the moment so if you don’t see anything happen here for a while please don’t hesitate to ping me again about this.


Fix pom to inherit from common-parent, instead of common.

By inheriting from common, it adds a dependency (common-utils) to all the poms that inherit from this one, which is not the intended behaviour. Child poms that rely on this dependency should depend on common-utils directly.

Can you run a test build against muckrake? There's a chance downstream repos depend on the dependency from common.

Is not the downstream-validation stage of the Jenkins PR builder enough? I fixed the only repository that failed already.

Something seems off with the PR link, for some reason it's pointing to an internal build instead of the community PR builder, so I can't tell what happened with this build.
However, for downstream builds we're trying to allow for a balance between overhead/cost and risk. By default, which is what this repo uses, we only build repos that declare an explicit dependency on a rest-utils module (see https://github.com/confluentinc/jenkins-common/blob/master/vars/downStreamValidation.groovy#L7 but the full details are also tied into the details of how the dependency resolution works). Because of this, a muckrake build will still (potentially) be more complete since it will also build things with transitive dependencies. That test has always been a bit of a hack that just happens to encompass pretty much everything we care about (especially when there was only one product sku). This could be addressed by enforcing explicit dependencies for imports, but since we're not doing that today, muckrake build gives better coverage than just the downstream check.
We could make this more flexible to support more extensive tests in low traffic repos with larger potential blast area, e.g. by changing https://github.com/confluentinc/jenkins-common/blob/master/vars/common.groovy#L83 to support some flag from the build config, but that isn't there today.
either muckrake directly or ducker would be fine, normally it only takes ~30min to build serially, but it's just a nice sanity check so we don't have to scramble post-merge to unblock another team.

@rigelbm Is this still relevant? If so, can we rebase, re-run jenkins, and get validation of downstreams?


Starred favorites

Adds a favoriting capability to vendor and product list so users can more easily access more important assets. Screen shots are attached below. Review is requested for the user interface which currently uses font awesome stars.
Additionally, I'm not certain of potential interactions with the current infinite scroll for lists long enough to be paginated.

Looks like there are some accessibility issues on the Vendor index page. Travis gives some more details about this; so does running bundle exec rake cucumber

I tested this with a Vendor that has 100 Products, and it worked as it should.

Notes from Eny:
favorite sorting (top of list goes missing?)
-bigger star
-remove box outline
-separate favorites area
-bright green (loading color) for star
-star button up top to filter to favorites
Other notes:
-scroll screen to where favorite's new location is (highlight and fade)
-info
-use cases-> how many items likely to be on the list?

Well- cucumber is still having issues for me locally, but since it's passing on Travis, I guess there's not reason not to review.

I keep getting this error when the page needs the infinite scroll.

We should pluralize these based on the number of products in each category. See this method for some info on how to do that in Rails.

Is this intended effect when there are favorited vendors, but no non-favorited vendors


Minor revisions to README.md

-Rewrote opening sentence to read smoother.
-Minor gramatical fix.

Thanks!


Set up and use a good code sniffing/lint/flake system

Original report by Joseph Fowler (Bitbucket: joe_fowler, ).

Try ruff, which is supposed to be super fast!

Original comment by Joseph Fowler (Bitbucket: joe_fowler, ).

Resolved with PR 208


[Bug]: shopify theme dev preview shows live theme

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
As recently as Friday (2023-08-11) I was working locally on theme development using shopify theme dev, previewing changes locally and making content updates to the remote dev theme via the Theme Customizer.
Actual behavior
Upon starting work this morning, the local preview URL (http://<IP_ADDRESS>:9292) shows the live theme of the test store I'm developing against, as does the preview link (https://<store-name>.myshopify.com/?preview_theme_id=<dev-theme-id>).
However, the preview in the Theme Customizer (https://admin.shopify.com/store/<store-name>/themes/<dev-theme-id>/editor) shows the correct development theme.
Reproduction steps

Run shopify theme dev
Click the localhost preview link output by the CLI
Observe that the preview shows the store's live theme
Open the theme customizer link output by the CLI
Observe that the theme customizer correctly shows the dev theme

I've updated the CLI, cleared my cache, and deleted and recreated my development theme to no avail. Is there a known issue with this?
Thanks.
Operating System
macOS 12.6.7
Shopify CLI version (check your project's package.json if you're not sure)
@shopify/cli/3.48.1 darwin-x64 node-v20.5.1
Shell
iTerm 2 + Bash
Node version (run node -v if you're not sure)
v16.19.0
What language and version are you using in your application?
No response

Same issue here, I don`t see changes in local development, but on the theme editor, it looks fine.

Same here!

This looks to have been resolved now, I see the correct development theme in preview. I'll leave this issue up for a little longer in case there are any official comments.

It started working at the moment, but I didn't change anything, maybe it was a Shopify problem.

Pinging @Shopify/theme-code-tools

I think this was part of the checkout redirect issue we had a few days ago. This seemed to resolve when shopify fixed the checkout issue.

👋 Hello everyone,
Indeed, we experienced some instability on the platform that impacted CLI features, causing the live theme to be previewed instead of the current development theme. However, this issue has been resolved, and the CLI should now be functioning as expected without any need for an upgrade.
Please, don't hesitate to reopen this issue if you continue to encounter this problem.

Experienced this bug. Had to manually copy the Theme ID from the terminal into the localhost window as a preview url parameter to get it to switch from Live.

I have also been getting this problem since yesterday. Was completely fine before.

any update on this? I'm having the same problem

choksi215 try carolinerusso's suggestion in the post just before yours:
Hitting <IP_ADDRESS>:9292?preview_theme_id=YOUR_THEME_ID_HERE
Doing the above solved the problem for me.

Same problem here --version > @shopify/cli/3.50.0 darwin-arm64 node-v21.1.0

Same problem for me with two different stores - one live, one dev.

Sam issue here and No body is here to infrom shopify lol :)

Last time to make it work, I used my local link (i.e. http://<IP_ADDRESS>:9292) and added the preview_theme_id as a parameter and it worked perfectly.