Liked coubs not enough

Hi there!
Can we get also "Bookmarks" from coub ?
And I'm getting "file name too long" error, can we check filename length, and if it's too long, change it ?

If it's possible to get bookmarks it would be great to separate them (folder), 'cause bookmarks more important than liked coubs.
Thanks.

If it's possible to get bookmarks it would be great to separate them (folder), 'cause bookmarks more important than liked coubs.
Thanks.

Long file names like this one:

Long file names like this one:

I've never used bookmarks before so I went to see if it is possible to do and saw this on https://coub.com/dev/docs/Coub+API%2FOverview:
Warning. This API is no longer supported and will be disabled on Feb 1, 2021.
I could not find a "new" API, so seems there will be no API at all :-(

I've never used bookmarks before so I went to see if it is possible to do and saw this on https://coub.com/dev/docs/Coub+API%2FOverview:
Warning. This API is no longer supported and will be disabled on Feb 1, 2021.
I could not find a "new" API, so seems there will be no API at all :-(

Thank you anyway, yes, I saw that warning too, so I liked all my bookmarks manually and execute one more time coubdl  :D

Thank you anyway, yes, I saw that warning too, so I liked all my bookmarks manually and execute one more time coubdl  :D


[WIP] @web5/agent DWN + Web5 RPC Clients

WIP waiting on agent refactoring this is based on.

organize rpc clients into agent/prototyping/clients until they have a permanent home
copy JsonRpcSocket class from @web5/dwn-server
create WebSocketDwnRpcClient and WebSocketWeb5RpcClient

Codecov Report

Merging #433 (43fc3bf) into main (30eae0f) will increase coverage by 0.52%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   90.54%   91.06%   +0.52%
==========================================
  Files         112      119       +7
  Lines       29085    29678     +593
  Branches     2077     2185     +108
==========================================
+ Hits        26335    27027     +692
+ Misses       2715     2616      -99
  Partials       35       35

Components
Coverage Δ

agent
81.04% <100.00%> (+2.20%)
:arrow_up:

api
97.89% <ø> (ø)

common
98.68% <ø> (ø)

credentials
94.95% <ø> (ø)

crypto
93.81% <ø> (ø)

dids
97.65% <ø> (ø)

identity-agent
96.70% <ø> (ø)

crypto-aws-kms
100.00% <ø> (ø)

proxy-agent
96.70% <ø> (ø)

user-agent
96.70% <ø> (ø)


Click+Drag Light Template not working

Select a light template and click+drag to create light. Does not allow variable light radius, hard sets Dim/Bright

This seems to have resolved itself in my game and cannot reproduce.


Show correct vpc-resource-controller version in the userAgent

Brought this up with @orsenthil over slack
What would you like to be enhanced:
The cloudwatch EKS cluster logs for vpc-resource-controller actions shows the userAgent field as:
"userAgent": "controller/v0.0.0 (linux/amd64) kubernetes/$Format",
It would be better if instead of always showing v0.0.0 the logs showed which version of the vpc-resource-controller made the request.
Why is the change needed and what use case will it solve:
It would have been simpler for us to track and report the v1.5.0 trunk initialization issues if the userAgent version mapped to the version of the vpc-resource-controller that made the request.

@ClareCat thanks for reporting this. We have correct agent version showing in EC2 dashboards. I am not sure why CloudWatch doesn't have version correctly showing. I will take a look.

@haouc - I pointed out to the GitVersion that is displayed during the bootstrap ( https://github.com/aws/amazon-vpc-resource-controller-k8s/blob/964a3cce8281e25c185369f63859ed63bedd491f/main.go#L179) . this is different from that log; the request is if the controller version can be set in user agent.

Yeah, this is the userAgent that is set in the manager client. It's probably an option value in there.

Right now it seems like it's just using this default: https://github.com/kubernetes/client-go/blob/master/rest/config.go#L491-L505

I have updated the userAgent to reflect the vpc-resource-controller and gitVersion in this PR https://github.com/aws/amazon-vpc-resource-controller-k8s/pull/455


showShadow is not working!

When I set app:bb_showShadow="false", the shadow is visible! and it's not hidden. Please fix it. Thanks

@a-bahmani are you using the latest version?

@a-bahmani forget it i found the issue :)

#749 this is the PR

Thanks. Yes, I am using version '2.3.0' and  Android Api 19, Does this problem have fixed in this version?

I just sent a PR today

The PR is in, it will go out on the next release

When will the next release?

@SergeyAppDroid @a-bahmani from what @roughike told me, the release will be today, and from his time zone i'm guessing it will be in a couple of hours after he is out of work.

the latest version is out, has some fixes for shadows

It's OK, I tested. ،Thanks for caring about this details. Good luck.

@SergeyAppDroid  i don't think we have a method exposed for that, but if you change the elevation to 0 i think that hides the shadow post-lollipop, but pre-lollipop will still show it cause is done differently

But when I use  app:bb_showShadow="true"  the shadow does not appear. Android 5.0


Bump version up to 0.0.3 and add change log.

@matthewp I tried https://github.com/skywinder/github-changelog-generator to keep a changelog, it seems nice, what do you think?

Cool

Feel free to merge and publish as you need since this is still a 0.0.x project, no need to wait for code reviews yet.


Error installing on Fedora 23

After installing LLVM from the distro, I discovered that install image doesn't come with gcc-c++ preinstalled and I got an error when compiling.  My current issue is the following:
Linking libponyrt-pic gtest_main.cc gtest-all.cc Linking libgtest main.c Linking ponyc /usr/bin/ld: cannot find -lz collect2: error: ld returned 1 exit status Makefile:455: recipe for target 'build/release/ponyc' failed make: *** [build/release/ponyc] Error 1
Any ideas?  Is there anything more you need from me?
Best,
Willem

Per README:
You may need to install zlib, ncurses, pcre2, and ssl
In this case, that error appears to be that zlib isn't installed.

@willemneal once you figure out exactly what you have to install from base for Fedora, can you issue a PR against the README w/ Fedora specific instructions (yum commands and what not)

I indeed didn't have pcre2 installed, the first two are preinstalled and it couldn't find ssl, openssl is already installed though.
I am still, however, getting the same error.

So zlib is installed? The error is that ld can't find it.
Where is zlib installed?
What's it called?
Is the path to it in your linker path?

@willemneal you could also consider using the docker container. that might be easier for initially getting started.

Hey @SeanTAllen thanks for the help. I got it to work!  All I needed was zlib-devel.  I have kept notes and will update the READme soon.

Awesome. Thanks @willemneal.


PowerToys Run very slow to launch after startup

ℹ Computer information

PowerToys version: 0.23.2
PowerToy Utility: Run
Running PowerToys as Admin: No
Windows build number: 1909 (18363.1139)

📝 Provide detailed reproduction steps (if any)

Start system, from power on or resume from sleep
Wait for system stats to calm down (e.g. Antimalware Service Executable to stop hogging every last resource 😅 )
Issue key-combo for PowerToys Run

✔ Expected result
PowerToys Run utility launches
❌ Actual result
No visible effect.
Sometimes the Run box shows up ~60 seconds later, sometimes not.
📷 Screenshots
N/A

could be a dup of #279

is this new? brought on by a recent update or a consistent issue?

I am having the same problem since updating to 0.23.2. It was working fine with 0.23.0.

I saw the issue with at least the last few recent versions.
Can't recall exactly when I first noticed it though unfortunately.

Are you using an ssd or hdd? Have you ever gone through your windows services and pruned some of them by setting them to delayed start or disabled?

My enabled startup items count is low.
This is a screen grab all of the enabled items:

@wolf99 @simonebarbieri Can you please check CPU and memory usage in the task manager when this issue happens? Also, in the case PT Run doesn't start, can you check if powerlauncher.exe process is running?

@somil55 powerlauncher.exe isn't running. Only PowerToys.exe is running. At the moment of the test, CPU usage is oscillating between 4% and 9%, and memory is at 37%.

SSD, the first start of the PowerToys Run takes about 60 seconds, during this time period the powerlauncher process takes about 10-15% of the CPU

Closing this in favor of https://github.com/microsoft/PowerToys/issues/8873 since in 0.29 we made some changes that improved the performance in some cases. https://github.com/microsoft/PowerToys/issues/8873 tracks the problem for 0.29 and later.

Closing this in favor of https://github.com/microsoft/PowerToys/issues/8873 since in 0.29 we made some changes that improved the performance in some cases. https://github.com/microsoft/PowerToys/issues/8873 tracks the problem for 0.29 and later.

I'm still seeing this bug (first startup may take minutes) even in Powertoys v0.81.1.
It is most certainly NOT resolved.


Support Authorisation

Possible duplicate of https://github.com/drashland/sinco/issues/28 ?
Summary
What:
Support authorisation, where web apps or API's might use CSRF tokens to protect endpoints
In my own case, the user needs to make a req to /, they get a CSRF token, that allows them to authenticate against the other endpoints. Because Sinco doesn't hold onto any sessions/headers/cookies etc, when it makes a request to my protected endpoint (even if i GET / first), i get a "No CSRF token passed in"
Why:
A lot of apps use this, without this feauture, it means many people/companies won't be able to adopt Sinco
Acceptance Criteria
Below is a list of tasks that must be completed before this issue can be closed.

[ ] Write documentation
[ ] Write unit tests
[ ] Write integration tests

Example Pseudo Code (for implementation)
// Add example pseudo code for implementation

My thinking around this is:

We should add a setCookie method to the api, that adds a cookie to the browser instance. This makes it easy if someone wants to access a protected resource(eg using csrf), they can just pass in a valid token
A way to hold onto cookies across navigating pages, so say a user enters the home page (that gives them a token), they can now access other resources

Example:
// So i have two resources:
//   - home
//   - users
// Home reosurce gives you a csrf token, users resource requires a token to access the page

// Enter the users page directly
import { csrf } from "./middleware/csrf.ts" // drash middleware
const token = csrf.token
const Chrome = await buildFor("chrome")
await Chrome.setCookie("X-CSRF-TOKEN", token)
await Chrome.goto("localhost/users") // ok
await Chrome.assertSee("you are authed and on this page") // ok

// You enter the home page first to get the token, then go to the users page
await Chrome.goto("localhost") // saves the cookies for the session
await Chrome.goto("localhost/users") // ok, because the cookies for the browser has passed over

Thoughts?


Mislabeled active WAN (Multi-WAN failover)

Describe the bug
The bug appears to only be COSMETIC:
I setup a multi WAN and group for failover. I expect the active WAN to show as active. It does not.
The failover function works fine for me other than the mislabeling.
To Reproduce
Steps to reproduce the behavior:

Create a 2 WAN group
Set your primary to Tier 1. Set failover to Tier 2.
Verify GW utilized by checking public IP from a network host that's using the WAN group as it's gateway.

Expected behavior
Show gateway currently being used as '(active)'.
Screenshots
Gateways (WAN_DHCP is the one 'active' not WAN_DHCP2):

WAN group:

Environment
Type 	opnsense
Version 	23.7.6
Architecture 	amd64

@bmatthewshea while it's true that the GUI shows the desired active one it's also true that this is for default gateway switching specifically which you may not have enabled? This or the reload does not go through as desired.
Cheers,
Franco

Thanks for reply.
It does not show the 'desired' active one. That's the problem. It is true it shows active on one of them but that is not the "active" one (meaning the gateway being used currently).
I am not sure what setting you mean by "default gateway switching" or what it has to do with showing what gateway is "active"? Nor why the gateway would be labeled in a misleading way?
To me "active" means it's active. Right? Or, am I completing misunderstanding it's meaning?
Everything was reloaded/rebooted etc. Same result.

It's showing the system default route that goes through that specific gateway and not the result of the failover group. You can check from System: Routes: Status. Both gateways probably have the same priority... so you can prioritize the tier 1 gateway in your case in the gateway settings under System: Gateways: Single by lowering the value. The default is 255 so setting the tier 1 to 254 should be enough.
But keep in mind this is only cosmetic for routed traffic as it still uses the failover group as per firewall rules (and the firewall decides about that, not the routing table). Only your local firewall traffic will be affected slightly by the change of a default route going out the other tier then.
Cheers,
Franco

https://docs.opnsense.org/manual/gateways.html#default-gateways

Thanks @fichtner & @AdSchellevis - yeah I worked out which gateway to favor by using weight before I wrote OP. Was strictly trying to figure out why active displays on a given GW.
And thought I had read that doc page. I -do- see the explainer for GW switching and 'active' now, though.
I think I somewhat understand now. I still think 'active' is completely misleading when using failover/redundancy. Maybe another word?
I also think (and apparently google does, too) the 'mark as upstream gateway' needs some additional deep explaining in docs.
Closing.

Hmm, I'll re-open this for internal discussion... maybe it would be better to show the current default gateway as active. The page is currently being reworked anyway.
Cheers,
Franco

(it was discussed and it was said to be documented properly in https://docs.opnsense.org/manual/gateways.html#overview-page -- first note after anchor)


Fix colocate balance endless loop bug

Proposed changes
Fix colocate balance endless loop bug when all be down
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] Documentation Update (if none of the other choices apply)
[] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[] I have added tests that prove my fix is effective or that my feature works
[] If this change need a document change, I have updated the document
[] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

you'd better create an issue to describe this problem

Fix #5037

deplicated #5079


feat: modify the image creation process into GitHub matrix

Description
This PR includes changes to the changed functions list script and image building pipeline to run the docker compose tasks using a GitHub matrix (parallel runners).
Context
Changes tested in dev environment.
Type of changes

[X] Refactoring (non-breaking change)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[X] I am familiar with the contributing guidelines
[X] I have followed the code style of the project
[ ] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[ ] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[X] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Tested with 0 changes (skip 2nd part), 1 change, 2 changes, and rebuilding all (change in Shared).


fix: the e2e test for a forbidden case

Related to #201

@cre8ivejp please help me to take a look
the e2e tests passed
https://github.com/bucketeer-io/android-client-sdk/actions/runs/11357966996/job/31591706290


possibility of regulation (and turnoff) for pkg_has_updates / monopolization of pkg by pkgng via pkg-version

For system with lot of packages  execution of:
https://github.com/xaque208/puppet-pkgng/blob/2.1.1/lib/facter/pkg_updates.rb#L8:
50338  1  S      0:00.01 /usr/sbin/pkg version -ql<
50339  1  D      0:00.12 /usr/sbin/pkg version -ql<

for pkg_has_updates facts always lock pkg for a long time and user can do anything with pkg. The problem is the slow 'pkg version' execution when ports not installed (and fetchindex not performed).
For example, on a PC with desktop role (KDE5) and 1746 packages this operation may take ~ 20 minutes (no ssd, one hdd).
More details: https://github.com/freebsd/pkg/issues/1739
it would be nice to regulate this behavior and be able to turn off. Or try to find another solution, for example pkg dry-run:
pkg upgrade -Unq
or
pkg version -RU

That is a lot of packages.  My largest box has 263.  +1 to this change.


update issue templates to more interactive and new format

Is your request related to a new offering from AWS?
No
Is your request related to a problem? Please describe.
No
Describe the solution you'd like.
Updater issue templates to new format and more interactive way as currently:

I am proposing that issues will have different templates with questions for each kind.
Describe alternatives you've considered.
something what is described here https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
Additional context

these are all automatically controlled through the .github repo - see more here https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file
@daroga0002 if you delete those issue and PR templates from the EKS repo then they will inherit and use the default templates setup here https://github.com/terraform-aws-modules/.github


Clearing Searching Field

Hello,
today I installed DailyTxT on my Synology NAS in docker. I already like this tool very much!
One thing which could be improved, is the clearing of the searching result field, when you delete the entered text. The results were also listed when the field is already empty.
Greetings
surfer ;-)

Thanks, I'll consider a solution for your idea, once I continue coding on DailyTxT (will take some more month!).

implemented with next version 319d3ae


want to add scroll button to top

I want to add button which will scroll the site to top when user reach at the bottom of the site

@codervivek5 please assign me this issue


When service with network node "host" is linked to service alias , dns resolution of the link returns nothing.

Server version - Build from master - Aug 13
Steps to reproduce the problem:
Create service test1 and test2 with network mode set to "host" and label - io.rancher.container.dns:true
Create service alias - S1 with targets test1 and test2.
Create service -  "test" with network mode set to "host" which is linked to S1 with service link name -> "mydns".
From containers of "test", dig on "mydns" resolves to no ip address.
Expected behavior:
dig on "mydns" should resolve to the host ip address of the containers (started on "host" network mode) and should be reachable from the container.
The same issue is also seen when the service is linked to Service alias with targets in "managed" network mode.

Tested with build from master - Aug 14
When service with network node "host" is linked to service alias which have targets as service with host network , dns resolution works fine.
When S=service with network node "host" is linked to service alias which have targets as service with managed network , dns resolution works fine.


Build.cmd fails with FS2026 on Windows with VS16.4

Description
Build.cmd fails with error FS2026 on windows if run after checkout
Repro steps

Step A

Check out the repository onto a Windows machine with Visual Studio 16.4 installed

Step B

Attempt to run build with command "./build.cmd" from command line with Administrator Privileges
Expected behavior
Expect the libraries to be built successfully.
Actual behavior
The build process fails with the following error messages

FSC : error FS2026: Deterministic builds only support portable PDBs (--debug:portable or --debug:embedded) [C:\repos\quintusm\ExcelProvider\src\ExcelProvider.DesignTime\ExcelProvider.DesignTime.fsproj]
FSC : error FS2026: Deterministic builds only support portable PDBs (--debug:portable or --debug:embedded) [C:\repos\quintusm\ExcelProvider\src\ExcelProvider.DesignTime\ExcelProvider.DesignTime.fsproj]
FSC : error FS2026: Deterministic builds only support portable PDBs (--debug:portable or --debug:embedded) [C:\repos\quintusm\ExcelProvider\src\ExcelProvider.DesignTime\ExcelProvider.DesignTime.fsproj]

Known workarounds
Not currently aware of any workarounds
Related information

Microsoft Windows [Version 10.0.18363.535]
Current master branch

According to this issue in the compiler this is a new by design behaviour, so we will need to change our build script to reflect this


Recompiling JSM scripts

I started writing support for JSM codes. I do it in a separate assembly, without changing the existing code. Currently ported Deling code to C#. I dunno how much is enough for me, but I hope to finish AST and nice formatting.

[ ] Investigation of Opcodes
⬛⬛⬛⬛⬛⬛⬜⬜⬜⬜ 60%
We have an article on the wiki, a ready-made Deling and Garden sources, topics on the Qhimm  forum and reverse engineering. Half the opcodes aren't documented.

[ ] Disassembling of instructions
⬛⬛⬛⬛⬛⬛⬛⬛⬛⬜ 90%
Handling the stack leads to a lot of errors. It is necessary to go from opcodes to a sequence of high-level instructions.
PSHN_L(0);   PSHN_L(127);   MUSICVOL => SetMusicVolume(channel: 0, volume: 127)
There was a lot of work done in Deling. Unfortunately, only basic instructions are described. The rest will have to finish. Currently, the stack sizes have been clarified for all instructions that were in valid files (several files don't correspond to the JSM standard or contain obvious errors [invalid jumps in test files], they will have to be processed separately).

[ ] Building of abstract syntax tree
⬛⬛⬛⬛⬛⬛⬛⬛⬛⬜ 90%
The bulk of the work has already been done in Deling. It is necessary to eliminate crutches that hide bugs and remove spaghetti from the code.

[ ] Print decompiled sources
⬛⬛⬛⬛⬛⬛⬛⬜⬜⬜ 70%
Similar to the previous paragraph. Bugs less, spaghetti more. Need to refactor code.
Instead of pseudocode, it is better to use C# syntax.

if var622_ubyte == 128 begin
	if var599_ubyte == 32 begin
		var1041_ubyte = 1
	end
else if var622_ubyte < 128 begin
	if var622_ubyte > 1 begin
		var622_ubyte = 2
	else if var622_ubyte == 1 begin
		var622_ubyte = 1
	else if var617_ubyte > 1 begin
		var622_ubyte = 2
	else if var617_ubyte == 1 begin
		var622_ubyte = 1
	else if var618_ubyte > 1 begin
		var622_ubyte = 2
	else if var618_ubyte == 1 begin
		var622_ubyte = 1
	else if var620_ubyte > 1 begin
		var622_ubyte = 2
	else if var620_ubyte == 1 begin
		var622_ubyte = 1
	else if var621_ubyte > 1 begin
		var622_ubyte = 2
	else if var621_ubyte == 1 begin
		var622_ubyte = 1
	else if var616_ubyte > 1 begin
		var622_ubyte = 2
	else if var616_ubyte == 1 begin
		var622_ubyte = 1
	else
		var599_ubyte = 32
	end
end
ret(8)

[ ] Translate to expression tree / IL Code / Custom execution logic
⬛⬜⬜⬜⬜⬜⬜⬜⬜⬜ 10%
The easiest way to execute code without creating your own state machine is to translate instructions into IL code or Expressions. But to support such a thing is difficult. If we choose this path, it is necessary to cover each expression with tests.
But we can use Roslyn, after generating a C# code, and then parsing it.

[ ] Parsing of scripts
⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜ 0%
To support modifications, it is necessary to learn how to parse the text representation of scripts, which is easy for players to edit. If we can use .NET Core and Roslyn, the easiest way is to write scripts in C# and parse them as Syntax Tree.

[ ] Testing
⬛⬛⬛⬜⬜⬜⬜⬜⬜⬜ 30%
The current version enumerates all fileds and generates pseudo-code for them. There is one known bug that I am going to fix soon. In the future, it is necessary to cover with tests all the mechanisms for working with JSM, in order to eliminate bugs in this segment. Analyzing errors in it is VERY difficult.

I completely rewrote the mechanism for parsing opcodes and combining them into instructions.
Changed the indexing of jumps, now they also operate with instructions, not opcodes.
The next task is to combine them into logical blocks:

[ ] if
[ ] if-else
[ ] if-else if-else
[ ] while
[ ] do-while
[ ] until
[ ] goto (?)

[00]	{LBL(_parameter: 0)}
[01]	{POLYCOLORALL(_arg0: PSHN_L(_value: 128), _arg1: PSHN_L(_value: 128), _arg2: PSHN_L(_value: 128))}
[02]	{JPF(Index: 7, Condition: Eval(Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: 64)) == PSHN_L(_value: 0)))}
[03]	{JPF(Index: 7, Condition: Eval(PSHM_B(_globalVariable: gByte_642) & PSHN_L(_value: 64)))}
[04]	{JPF(Index: 7, Condition: Eval(PSHM_B(_globalVariable: gByte_644) & PSHN_L(_value: 128)))}
[05]	{JPF(Index: 7, Condition: Eval(PSHM_W(_globalVariable: gUInt16_84) != PSHN_L(_value: 115)))}
[06]	{POPM_B(_parameter: 646, _arg0: Eval(PSHM_B(_globalVariable: gByte_646) | PSHN_L(_value: 64)))}
[07]	{JPF(Index: 17, Condition: Eval(PSHM_B(_globalVariable: gByte_643) & PSHN_L(_value: 1)))}
[08]	{JPF(Index: 17, Condition: Eval(Eval(PSHM_B(_globalVariable: gByte_648) & PSHN_L(_value: 1)) == PSHN_L(_value: 0)))}
[09]	{JPF(Index: 17, Condition: Eval(Eval(PSHM_B(_globalVariable: gByte_649) & PSHN_L(_value: 16)) == PSHN_L(_value: 0)))}
[10]	{JPF(Index: 17, Condition: Eval(PSHM_B(_globalVariable: gByte_642) & PSHN_L(_value: 64)))}
[11]	{JPF(Index: 17, Condition: Eval(PSHM_B(_globalVariable: gByte_644) & PSHN_L(_value: 128)))}
[12]	{JPF(Index: 17, Condition: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: 64)))}
[13]	{JPF(Index: 17, Condition: Eval(PSHM_B(_globalVariable: gByte_647) < PSHN_L(_value: 8)))}
[14]	{POPM_B(_parameter: 1024, _arg0: PSHN_L(_value: 1))}
[15]	{PARTICLEON(_arg0: PSHN_L(_value: 0))}
[16]	{PARTICLEON(_arg0: PSHN_L(_value: 1))}
[17]	{JPF(Index: 20, Condition: Eval(PSHM_B(_globalVariable: gByte_647) < PSHN_L(_value: 8)))}
[18]	{JPF(Index: 20, Condition: Eval(PSHM_B(_globalVariable: gByte_649) & PSHN_L(_value: 2)))}
[19]	{POPM_B(_parameter: 1036, _arg0: PSHN_L(_value: 1))}
[20]	{JPF(Index: 54, Condition: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: 128)))}
[21]	{JPF(Index: 49, Condition: Eval(Eval(PSHM_B(_globalVariable: gByte_648) & PSHN_L(_value: 32)) == PSHN_L(_value: 0)))}
[22]	{GETTIMER()}
[23]	{POPM_B(_parameter: 658, _arg0: Eval(PSHM_W(_globalVariable: gUInt16_656) - PSHI_L(_index: local0)))}
[24]	{JPF(Index: 30, Condition: Eval(PSHI_L(_index: local0) < PSHN_L(_value: 30)))}
[25]	{POPM_B(_parameter: 1038, _arg0: PSHN_L(_value: 3))}
[26]	{KILLTIMER()}
[27]	{POPM_B(_parameter: 648, _arg0: Eval(PSHM_B(_globalVariable: gByte_648) | PSHN_L(_value: 32)))}
[28]	{POPM_B(_parameter: 646, _arg0: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: -129)))}
[29]	{JMP(Index: 48)}
[30]	{JPF(Index: 42, Condition: Eval(PSHM_B(_globalVariable: gByte_658) <= PSHN_L(_value: 95)))}
[31]	{JPF(Index: 36, Condition: Eval(PSHM_W(_globalVariable: gUInt16_84) == PSHN_L(_value: 126)))}
[32]	{EFFECTLOAD(_arg0: PSHN_L(_value: 4))}
[33]	{POPM_B(_parameter: 1035, _arg0: PSHN_L(_value: 1))}
[34]	{MENUDISABLE()}
[35]	{JMP(Index: 41)}
[36]	{POPM_B(_parameter: 1038, _arg0: PSHN_L(_value: 2))}
[37]	{KILLTIMER()}
[38]	{POPM_B(_parameter: 648, _arg0: Eval(PSHM_B(_globalVariable: gByte_648) | PSHN_L(_value: 32)))}
[39]	{POPM_B(_parameter: 646, _arg0: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: -129)))}
[40]	{MENUENABLE()}
[41]	{JMP(Index: 48)}
[42]	{KILLTIMER()}
[43]	{POPM_B(_parameter: 648, _arg0: Eval(PSHM_B(_globalVariable: gByte_648) | PSHN_L(_value: 32)))}
[44]	{POPM_B(_parameter: 646, _arg0: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: -129)))}
[45]	{JPF(Index: 48, Condition: Eval(PSHM_B(_globalVariable: gByte_648) & PSHN_L(_value: 64)))}
[46]	{MENUENABLE()}
[47]	{POPM_B(_parameter: 648, _arg0: Eval(PSHM_B(_globalVariable: gByte_648) & PSHN_L(_value: -65)))}
[48]	{JMP(Index: 54)}
[49]	{POPM_B(_parameter: 1038, _arg0: PSHN_L(_value: 1))}
[50]	{KILLTIMER()}
[51]	{POPM_B(_parameter: 648, _arg0: Eval(PSHM_B(_globalVariable: gByte_648) | PSHN_L(_value: 32)))}
[52]	{POPM_B(_parameter: 646, _arg0: Eval(PSHM_B(_globalVariable: gByte_646) & PSHN_L(_value: -129)))}
[53]	{MENUENABLE()}
[54]	{JPF(Index: 57, Condition: Eval(PSHM_B(_globalVariable: gByte_648) & PSHN_L(_value: 1)))}
[55]	{POPM_B(_parameter: 1037, _arg0: PSHN_L(_value: 1))}
[56]	{JMP(Index: 59)}
[57]	{JPF(Index: 59, Condition: Eval(PSHM_B(_globalVariable: gByte_649) & PSHN_L(_value: 16)))}
[58]	{POPM_B(_parameter: 1037, _arg0: PSHN_L(_value: 2))}
[59]	{FADEIN()}
[60]	{RET(_parameter: 8)}

Instructions successfully combined into blocks.
I caught all the obvious mistakes, but I could not notice anything. We'll have to test in the future.
The next task is to bring this into a readable form.
LBL(Label: 31)
if(JPF[Index: 23, Conditions: ( Eval(PSHM_B(_globalVariable: gByte_1031) == PSHN_L(_value: 1)) )])
{
	DIR(_arg0: PSHN_L(_value: 196))
	MSPEED(_arg0: PSHN_L(_value: 1510))
	MACCEL(_arg0: PSHN_L(_value: 283), _arg1: Eval(-PSHN_L(_value: 255)), _arg2: PSHN_L(_value: 0), _arg3: PSHN_L(_value: 0), _arg4: PSHN_L(_value: 1500))
	POPM_B(_parameter: 1030, _arg0: PSHN_L(_value: 1))
	RANIMEKEEP(_parameter: 3)
	CTURNL(_arg0: PSHN_L(_value: 222), _arg1: PSHN_L(_value: 20))
	while(JPF[Index: 10, Conditions: ( Eval(PSHM_B(_globalVariable: gByte_1029) == PSHN_L(_value: 0)) )])
	{
		// do nothing
	}
	RANIMEKEEP(_parameter: 4)
	CTURNR(_arg0: PSHN_L(_value: 190), _arg1: PSHN_L(_value: 15))
	ANIMESYNC()
	POPM_B(_parameter: 1030, _arg0: PSHN_L(_value: 0))
	MOVE(_arg0: PSHN_L(_value: 37), _arg1: Eval(-PSHN_L(_value: 63)), _arg2: PSHN_L(_value: 0), _arg3: PSHN_L(_value: 0))
	MOVE(_arg0: Eval(-PSHN_L(_value: 464)), _arg1: Eval(-PSHN_L(_value: 140)), _arg2: PSHN_L(_value: 0), _arg3: PSHN_L(_value: 0))
	TALKOFF()
	RANIME(_parameter: 5)
	CTURNL(_arg0: PSHN_L(_value: 0), _arg1: PSHN_L(_value: 15))
	POPM_B(_parameter: 1039, _arg0: PSHN_L(_value: 1))
	ANIMEKEEP(_parameter: 6)
	TALKON()
}
else if(JPF[Index: 27, Conditions: ( Eval(PSHM_B(_globalVariable: gByte_1031) == PSHN_L(_value: 2)) )])
{
	DIR(_arg0: PSHN_L(_value: 0))
	CANIMEKEEP(_parameter: 6, _arg0: PSHN_L(_value: 46), _arg1: PSHN_L(_value: 45))
	POPM_B(_parameter: 1039, _arg0: PSHN_L(_value: 1))
}

HALT(_parameter: 0)
RET(_parameter: 8)

I corrected several errors, inverted empty conditions, added texts as comments. (Example above)

I began to clean the first game location:
    public dic(IServices executionContext)
    {
        _ctx = executionContext;

        // ScriptId: 0
        this.Model.Change(modelId: 0); // SETMODEL
        this.Animation.Change(animationId: 0, firstFrame: 0, lastFrame: 0); // BASEANIME
        this.BindChracter(CharacterId.Squall); // SETPC
        this.Model.Hide(); // HIDE
        return RET(8);
    }

And to write the execution logic:
    public sealed class FieldObjectModel
    {
        public Int32 ModelId { get; private set; }
        public Boolean IsVisible { get; private set; }

        public void Change(Int32 modelId)
        {
            ModelId = modelId;

            // TODO: Field script
            Console.WriteLine($"NotImplemented: {nameof(FieldObjectModel)}.{nameof(Change)}({modelId})");
        }

        public void Hide()
        {
            IsVisible = false;

            // TODO: Field script
            Console.WriteLine($"NotImplemented: {nameof(FieldObjectModel)}.{nameof(Hide)}()");
        }

        public void Show()
        {
            IsVisible = true;

            // TODO: Field script
            Console.WriteLine($"NotImplemented: {nameof(FieldObjectModel)}.{nameof(Show)}()");
        }
    }

I plan to finish with the start0 location, maybe I will also go through the next one. After that I will make a pull request.

The initial script:
    public dic(IServices executionContext)
    {
        _ctx = executionContext;
        // ScriptId: 0
        this.Model.Change(modelId: 0); // SETMODEL
        this.Animation.Change(animationId: 0, firstFrame: 0, lastFrame: 0); // BASEANIME
        this.BindChracter(CharacterId.Squall); // SETPC
        this.Model.Hide(); // HIDE
        return RET(8);
    }

    public void Defalut()
    {
        // ScriptId: 1
        IGameplayService.IsUserControlEnabled = false; // UCOFF
        IGameplayService.ResetAllData(); // CLEAR
        GByte[272] = 1;
        GByte[273] = 2;
        GByte[274] = 12;
        GByte[275] = 14;
        GByte[276] = 136;
        GByte[277] = 144;
        GByte[278] = 223;
        GByte[279] = 192;
        GByte[280] = 1;
        GByte[281] = 1;
        GByte[282] = 1;
        GByte[283] = 1;
        GByte[284] = 1;
        GByte[285] = 1;
        GByte[286] = 1;
        GByte[287] = 1;
        GByte[294] = 0;
        GByte[295] = 1;
        GByte[296] = 1;
        GByte[297] = 0;
        GByte[298] = 0;
        GByte[299] = 1;
        ISalaryService.IsSalaryEnabled = false; // SARALYOFF
        G[16] = (UInt16)500;
        IGameplayService.IsRandomBattlesEnabled = false; // BATTLEOFF
        GByte[479] = 0;
        IFieldService.FadeOff(); // MAPFADEOFF
        IPartyService.AddPlayableCharacter(CharacterId.Squall); // ADDMEMBER
        IPartyService.AddPartyCharacter(CharacterId.Squall); // ADDPARTY

        // Don't be Afraid (Regular Battle)
        IGameplayService.ChangeBattleMusic(MusicId.Battle01); // SETBATTLEMUSIC
        GByte[261] = (GByte[261] | 2);
        GByte[268] = 41;
        IPartyService.ChangeCharacterState(CharacterId.Squall, isSwitchable: true, isSelectable: true); // HOLD
        IPartyService.IsPartySwitchEnabled = false; // PHSPOWER

        // Disk 1: Liberi Fatali
        // Disk 2: Another Ram
        // Disk 3: Lunar Cry
        IMovieService.PrepareToPlay(movieId: 30, flag: true); // MOVIEREADY
        IMovieService.Play(); // MOVIE
        IFieldService.FadeOff(); // MAPFADEOFF
        IMovieService.Wait(); // MOVIE

        // B-Garden - Infirmary // Hardcoded :(
        IFieldService.GoTo(FieldId.bghoke_2, walkmeshId: 0); // MAPJUMPO
        IInteractionService.CancelAllScripts(); // HALT
        return RET(8);
    }

Holidays began in Russia. I'll take a little break.
Everything I wanted, I did, but I need to make a simple processing queue for objects and their scripts to make sure that the current architecture is suitable for future use.

Holidays are over. I went back to work.

Almost done. I think I will finish tomorrow. And I will need an another day to remove some garbage and merge it.

Okay, I changed the architecture a bit, sketched the execution code. Now it works, and even executes some instructions.
But there is a problem with the if-else condition. For convenience when creating nested blocks, I consider it as a follower of independent blocks. This is good at formatting text, but isn't suitable for execution, as we will try to execute each block.
I will try to replace independent blocks with one solid. I really don't want to add crutches. >_>

Fixed, now conditional blocks correctly check conditions before execution!
In addition, I fixed one rare formatting error.
Now successfully executed (of course, with stubs instead of some actions) 57 out of 72 scripts in the bghoke_2 location.
I think I will check the rest tomorrow and start to upload the changes. Due to unforeseen problems, the dates went a bit, so I plan to finish at the end of this week.

Today I implemented an execution logic for calls of REQEW with the possibility of waiting for their completion before the script continues.
Added a priority queue.
Added formatting multiple instructions.

Phew... I finished. The pseudo-game loop spins, enqueues and pseudo-executes scripts. Tries to animate pseudo-curtains. :)
Object: squall
FieldObjectModel.Change(modelId: 0)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Squall)
SETGETA(242)

Object: squall2
FieldObjectModel.Change(modelId: 1)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Squall)
FieldObjectModel.SetPosition(position: (Triangle: 86, X: -141, Y: 754, Z: 0))
DOFFSET(PSHN_L(Value: 0), PSHN_L(Value: 48), PSHN_L(Value: 0))
FieldObjectModel.SetDirection(angle: Angle: 270°)
FieldObjectAnimation.Play(animationId: 3, firstFrame: 2, lastFra
me: 2, freeze: True)

Object: zell
FieldObjectModel.Change(modelId: 2)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Zell)

Object: selphie
FieldObjectModel.Change(modelId: 3)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Selphie)
SETGETA(33)

Object: quistis
FieldObjectModel.Change(modelId: 4)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Quistis)
FieldObjectModel.SetPosition(position: (Triangle: 74, X: 162, Y: 362, Z: 0))
SETGETA(0)

Object: quistis2
FieldObjectModel.Change(modelId: 5)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Quistis)
SETGETA(0)

Object: rinoa
FieldObjectModel.Change(modelId: 6)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Rinoa)
SETGETA(17)

Object: irvine
FieldObjectModel.Change(modelId: 7)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 2)
FieldObject.BindChracter(Irvine)
SETGETA(5)

Object: kadowaki
FieldObjectModel.Change(modelId: 8)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 1)
FieldObjectModel.SetPosition(position: (Triangle: 85, X: -150, Y: 650, Z: 0))
FieldObjectModel.SetDirection(angle: Angle: 90°)

Object: cid
FieldObjectModel.Change(modelId: 9)
FieldObjectAnimation.ChangeBaseAnimation(animationId: 0, firstFrame: 1, lastFrame: 1)
SETGETA(0)

Object: dic
RenderingService.AddScreenColor(rgbColor: (R: 255, G: 255, B: 255))
MusicService.LoadFieldMusic(musicId: 38)
MusicService.ChangeMusicVolume(volume: 0, flag: False)
MusicService.PlayFieldMusic()
FieldService.BindArea(areaId: 71)
MusicService.ChangeMusicVolume(volume: 127, flag: False, transitionDuration: 180)
FieldService.PrepareGoTo(fieldId: bghoke_3)
RenderingService.AddScreenColorTransition(rgbColor: (R: 255, G: 255, B: 255), offset: (R: 0, G: 0, B: 0), transitionDuration: 180)
RenderingService.Wait()
InteractionService.Wait(frameNumber: 45)
FieldService.FadeOn()

Object: musickun
FieldObjectModel.SetHitbox(p1: (X: -212, Y: 552, Z: 0), p2: (X: -100, Y: 551, Z: 0))
FieldService.BindArea(areaId: 71)

Object: evl1

Object: curtain
RenderingService.DrawBackground()
InteractionService.Wait(frameNumber: 60)
InteractionService.Wait(frameNumber: 1)
RenderingService.AnimateBackground(firstFrame: 1, lastFrame: 4)
InteractionService.Wait(frameNumber: 4)
RenderingService.AnimateBackground(firstFrame: 1, lastFrame: 0)
============ Milliseconds: 31 ============
Object: squall
Object: squall2
FieldObjectAnimation.Play(animationId: 3, freeze: True)
Object: zell
Object: selphie
Object: quistis
Object: quistis2
Object: rinoa
Object: irvine
Object: kadowaki
Object: cid
Object: dic
Object: musickun
Object: evl1

Object: curtain
InteractionService.Wait(frameNumber: 60)
InteractionService.Wait(frameNumber: 1)
RenderingService.AnimateBackground(firstFrame: 1, lastFrame: 0)
InteractionService.Wait(frameNumber: 4)
RenderingService.AnimateBackground(firstFrame: 0, lastFrame: 0)
============ Milliseconds: 5 ============

Also, I added formatting a dozen new instructions. Currently, 97 of 375 instructions are ready for formatting and have test stubs for execution.
Starting tomorrow, I'll begin preparing my changes to merge.


chore: use cairo 1.1.0 features (WIP)

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

@gaetbout actually there are not many updates to cairo after alpha.7, i fixed things that i found in changelog.
LMK if you have any other suggestions.

Ci is red can you fix it plz


Optional PII logging

This PR allows us to get more logs from the user when authentication fails. Unfortunately these logs will contain PII so we're going to have them disabled by default - but if the need arises the user can go turn them on and see the exact responses from Microsoft Identity/OAuth

Coverage decreased (-0.02%) to 37.11% when pulling 456e9279831a5fd0aecf64a58ae3cda5ee868457 on amir/azureAuth/Logger into 347c1934552ffc43a0b3dd040421fc0ee7c40605 on main.


[BLD] Auto rebuild protos if they change in rust

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1902  👈
#1899
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on  Graphite


Add built-in web server feature

Verified with a binary enabled this feature

Thank you for your contribution, looks well.
Could you please provide documentation file too please, from the docs folder


fix: warning message is printed to stdout by CLI

Description
What this PR does / why we need it:
Currently we are printing warning log out to stdout which pollutes the json verification output.
This PR contains following update:

Warning should be logged using the logger.
added a unit test file for cli cmd. However the cli command currently is not unit testable, the test currently only validates the command exist.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1565
Type of change
Please delete options that are not relevant.

[X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Validated the  output only contains the verification result json. The warning is now logged ot stderr.

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

todo: Add issue for improve unit test for cli

todo: Add issue for improve unit test for cli

Can you add the reference to notation CLI test in the issue? https://github.com/notaryproject/notation/tree/main/cmd/notation
Adding unit test for CMDs could be quite effort-intensive.


Legion: problem building on systems with installed complex.h

This problem came up in building TeraChem so I will use that as the example.  This could affect any Regent application when Regent is built and installed with cmake.
Here is a sample of the build error for main.cpp.  main.cpp includes eri-regent.h which includes legion.h.
g++ -O2 -Wall -Werror -std=c++11 -I/usr/local/include -I/home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../../build/include -I/home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../cpp main.cpp /home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../cpp/eri_regent.cpp /home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../cpp/terachem_jdata.cpp /home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../cpp/terachem_kdata.cpp -o /home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../../build/eri_regent_test -L/usr/local/lib -lrealm -llegion -lregent -L/home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../../build/lib -lERIRegent -Wl,-rpath,/usr/local/lib,-rpath,/home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../../build/lib
In file included from /usr/local/include/legion.h:55,
from /home/aheirich/Documents/SLAC/software/terachem/eri-regent/src/tests/cpp/../../cpp/eri_regent.h:4,
from main.cpp:12:
/usr/local/include/legion/legion_redop.h:249:22: error: ‘complex’ was not declared in this scope
class SumReduction<complex > {
^~~~~~~
This happens because Legion has its own version of complex.h which must be included.  On Ubuntu Linux this conflicts with /usr/include/c++/8/complex.h which gets pulled in by g++.  This causes the compilation error.
One way to resolve this would be to rename Legion's complex.h.  Why is there a file that clashes with a system header?

a workaround is to disable complex reductions in regent by editing CMakeLists.txt
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0e6f390e5..8a3e21bef 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -493,14 +493,14 @@ endif()
Complex support
#------------------------------------------------------------------------------#
-if(Legion_BUILD_ALL OR Legion_BUILD_BINDINGS)

option(Legion_REDOP_COMPLEX "Use reduction operators for complex types" ON)
-else()
+#if(Legion_BUILD_ALL OR Legion_BUILD_BINDINGS)

#option(Legion_REDOP_COMPLEX "Use reduction operators for complex types" ON)
+#else()
option(Legion_REDOP_COMPLEX "Use reduction operators for complex types" OFF)
-endif()
-if((Legion_BUILD_ALL OR Legion_BUILD_BINDINGS) AND NOT Legion_REDOP_COMPLEX)

message(FATAL_ERROR "Bindings require Legion_REDOP_COMPLEX to be set")
-endif()
+#endif()
+#if((Legion_BUILD_ALL OR Legion_BUILD_BINDINGS) AND NOT Legion_REDOP_COMPLEX)

#message(FATAL_ERROR "Bindings require Legion_REDOP_COMPLEX to be set")
+#endif()
if(Legion_REDOP_COMPLEX)
define variable for legion_defines.h
set(LEGION_REDOP_COMPLEX ON)

I think this will generally be a problem for building against an installed Legion, no matter whether it was built with cmake or the Makefile flow.  By calling the header "complex.h" and putting it in the root of the Legion include tree, an app will be forced to include it with
#include <complex.h>
and unfortunately, POSIX has already staked out that turf: https://pubs.opengroup.org/onlinepubs/9699919799/
@lightsighter if you had to choose between:

renaming the header to something like "legion_complex.h", or
moving the header into the legion include subdirectory, or
something else,
which would you choose?

I would be fine with renaming it to anything that doesn't have "legion" in the name of the file. It doesn't have anything to do with Legion. It's just an implementation of a templated complex type with support for CUDA. The only other header file that it depends on is the half.h header in the same directory. If we change the name of complex.h then we should also change the name of half.h accordingly.
I am against this for the same reason as above: the complex type doesn't have anything to do with Legion. It's also worth noting that at some point in the future, if Realm provides support for common reduction operators (+,*) then it will need to see this header file as well until it supports dynamic generation of reduction kernels for arbitrary types in the DMA system, so it should not go in the Legion directory.

Ah, I hadn't realized there was a second header file without a namespace...  Rather than sticking an essentially-arbitrary prefix on both filenames, I'd lean towards pushing them both into a subdirectory with a somewhat-meaningful-but-unlikely-to-conflict-with-other-packages name.  My suggestion would be "mathutils".  Thoughts?  Alternative suggestions?  (Vetoes are invalid without a replacement suggestion.)

I'd like to get a fix for this into the next release.  Any objections to moving the headers:
complex.h -> mathutils/complex.h
half.h    -> mathutils/half.h

?

It doesn't really feel like mathutils. More like types or mathtypes. There's no math functionality in there in the sense of algorithms, just types with standard operators.

Ok, let's go with mathtypes then.  types seems too general to be dropping into /usr/local/ or the like without risking conflicts.

Although does this really solve the problem? The header is still called complex.h...

Or do you imagine the user having to write #include mathtypes/complex.h?

I think you should change the name of the header
legion_complex.h
On Mar 20, 2020, at 2:53 PM, Mike Bauer <notifications<EMAIL_ADDRESS>wrote:
Or do you imagine the user having to write #include mathtypes/complex.h?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/StanfordLegion/legion/issues/773#issuecomment-601926077, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAORXXQDNVRKSMHQBDEAFTTRIPQWBANCNFSM4LN2Y4HA.

I already addressed that. The types don't have anything to do with Legion and they don't depend on Legion, so they shouldn't be prefixed with Legion. They are just generic implementations of a complex type and a half type with support for CUDA.

#include mathtypes/complex.h?

Yes, the user will need to type
#include <mathtypes/complex.h>

because #include <complex.h> means "please include the POSIX-standard complex header".

Maybe we should call them cudatypes since their main feature is that they support CUDA. Although the half one is really weird because half_t is already a type in CUDA, we're just providing equivalent support for the same type on the CPU.

This is in master with commit 42b4dd21.  I went with mathtypes in anticipation of future support for other (non-CUDA) accelerators as well.
@aheirich can you undo your workaround and see if you can build with these changes?

@aheirich Can you confirm that this issue is fixed? We would like to get the issue closed for the 20.03 release.

solved in master


Convert all Thumbprint Avatars to circle shape

Thumbprint design is changing entity avatars to be a circular shape, meaning they will now render exactly how user avatars render. However, we will still keep both the ThumbprintUserAvatar and ThumbprintEntityAvatar around to keep the semantics separate and to allow for future changes to one instead of the other.

Tested with local maven build of this PR. You can see the before and after attached:


Wavefront metrics sink

related: https://github.com/kubernetes/heapster/issues/1361

This change is

Closed and re-opened so the bot picks up signed cncf-cla

@ezeev thanks for the contribution. We need someone familiar with the  Wavefront to review it. Do you know such person?
cc @mrcrgl

@piosz thank you for mention me. I could have a look at it.

@mrcrgl Cool, thanks! Will you be interested in becoming sink owner (see https://github.com/kubernetes/heapster/blob/master/docs/sink-owners.md) once this is merged?

@ezeev please, add some tests for your Sink, too.

I've finished my review.
@piosz thank you for asking me being the sink owner. That sounds interesting, lets see how it goes with this PR.

@mrcrgl @piosz - Thank you for getting to this!
I'm an employee at Wavefront so yes I am quite familiar with it. I would like to be the sink owner or at least collab with @piosz closely.
@piosz - thanks for the review! Also - perhaps we can synch together on getting this running in your Wavefront instance?

Hi @mrcrgl
Thanks again for reviewing this. Please take a look at the changes and let me know. Also, I'll send you an email about getting this setup on your Wavefront instance. We're maintaining a fork of Heapster with this sink for users currently.
Thanks,
Evan

Sorry, when I say "fork" - I really meant to say that we're maintaining a container image of heapster packaged w/ this sink (for now).

Hi @ezeev
Thank you for applying my notes. It's fine for me if you would be the sink owner, or we both together.
We're actually using your container image of Heapster in our test-environment and looking forward to use it in production as well.
Best,
Marc

@mrcrgl @piosz is this ok to merge?

Hi @ezeev,
It'd be great to have some basic tests, what do you think?
Best,
Marc

It needs LGTM from @mrcrgl to be merged.

ping @mrcrgl

Hi @ezeev, the looks fine to me but I'd like to have some unit tests added.
In my opinion it is easier and safer to maintain the code afterwards.
/cc @DirectXMan12

@mrcrgl agreed about the unit tests
@ezeev alright, please add some unit tests, and then I think this has the LGTM stamp after those are done (should be something like "given these metrics in Heapster internal format, do we get the right output metrics in Wavefront format").
Once those tests are in place (and I've had a chance to glance over them), I'll merge this.

Thanks @DirectXMan12 @mrcrgl
I'm working on the tests now. They will include a test that ensure metrics are in the proper line format for Wavefront.

@DirectXMan12 any idea what caused this travis-ci error? the last commit was a very small change I tested locally. Did something timeout?

@mrcrgl let me know if this LGTY thank you!

@ezeev LGTM! Thank you for writing the unit tests.
I guess this one could be merged, what do you think @piosz?
/cc @DirectXMan12

Generally LGTM.  Please squash the commits together and add a commit updating the state of the Wavefront sink in the sink-owners.md.  Thanks!

Hi @DirectXMan12
I updated the sink status on the sink owners page. I'm having a hell of a time squashing the commits. I wonder if it is because sink-owners.md did not exist when the original PR was submitted. What do you recommend?
This is the input i'm providing when rebasing from within my repo (git rebase -i):
pick 25c7273 Wavefront metrics sink
pick 85e6654 corrected license
pick 6034d51 moved labels to tags to its own method
pick 8a50311 removed unneeded comment
pick 9a98bbc removed unnecessary if statement in addLabelTags
pick 9b9d96b cleaned up logging
pick e2f215b Changes based on code review suggestions
pick 5f9ff70 Added test mode
pick b2da696 wavefront sink tests
pick 91328b4 resolving gofmt error
pick 3b3d4cf changed metric value test to ParseFloat from ParseInt
pick 4e93964 triggering ci tests
s 8e71c6e updating sink status

The output:
error: could not apply 25c7273... Wavefront metrics sink

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".
Could not apply 25c7273be5b91cee4f005308d94d8e5554052799... Wavefront metrics sink

I forced this through. The latest commit is the squashed version.


Add weibull_cdf Presto function

Resolves #4760

@aditi-pandit @majetideepak - Kindly review this pull request. Thanks.

Fuzzer test output for weibull_cdf:
I20230628 09:47:29.582652 1731535 ExpressionVerifier.cpp:56] ===================
I20230628 09:47:29.582690 1731535 ExpressionVerifier.cpp:67] All results match.
I20230628 09:47:29.582752 1731535 ExpressionFuzzer.cpp:1357] ==============================> Done with iteration 850
I20230628 09:47:29.583197 1731535 ExpressionFuzzer.cpp:1092] ==============================> Top 1 by number of rows processed
I20230628 09:47:29.583209 1731535 ExpressionFuzzer.cpp:1094] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 09:47:29.583216 1731535 ExpressionFuzzer.cpp:1098] weibull_cdf 96259 100.00% 10164
I20230628 09:47:29.583249 1731535 ExpressionFuzzer.cpp:1104] ==============================> Bottom 1 by number of rows processed
I20230628 09:47:29.583256 1731535 ExpressionFuzzer.cpp:1106] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 09:47:29.583261 1731535 ExpressionFuzzer.cpp:1111] weibull_cdf 96259 100.00% 10164
I20230628 09:47:29.583276 1731535 ExpressionFuzzer.cpp:1124] ==============================> All stats sorted by number of times the function was chosen
I20230628 09:47:29.583282 1731535 ExpressionFuzzer.cpp:1126] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 09:47:29.583292 1731535 ExpressionFuzzer.cpp:1130] weibull_cdf 96259 100.00% 10164

@aditi-pandit - Kindly re-review this pull request. Handled the provided comments. Thanks.
Adding fuzzer test output for reference
I20230628 15:03:41.710202 2072104 ExpressionVerifier.cpp:56] ===================
I20230628 15:03:41.710215 2072104 ExpressionVerifier.cpp:67] All results match.
I20230628 15:03:41.710250 2072104 ExpressionFuzzer.cpp:1357] ==============================> Done with iteration 408
I20230628 15:03:41.710522 2072104 ExpressionFuzzer.cpp:1092] ==============================> Top 1 by number of rows processed
I20230628 15:03:41.710542 2072104 ExpressionFuzzer.cpp:1094] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 15:03:41.710554 2072104 ExpressionFuzzer.cpp:1098] weibull_cdf 42796 100.00% 5241
I20230628 15:03:41.710570 2072104 ExpressionFuzzer.cpp:1104] ==============================> Bottom 1 by number of rows processed
I20230628 15:03:41.710600 2072104 ExpressionFuzzer.cpp:1106] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 15:03:41.710608 2072104 ExpressionFuzzer.cpp:1111] weibull_cdf 42796 100.00% 5241
I20230628 15:03:41.710615 2072104 ExpressionFuzzer.cpp:1124] ==============================> All stats sorted by number of times the function was chosen
I20230628 15:03:41.710621 2072104 ExpressionFuzzer.cpp:1126] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230628 15:03:41.710628 2072104 ExpressionFuzzer.cpp:1130] weibull_cdf 42796 100.00% 5241

@Krishna-Prasad-P-V : Please can you check the linux-build failure.

Hi @Krishna-Prasad-P-V, is this ready for another review?

Hi @Krishna-Prasad-P-V, is this ready for another review?

Yes, it is ready now for another review.

@Krishna-Prasad-P-V In the future, it will be great if you can just ping the corresponding reviewers to have another pass. @aditi-pandit

@Krishna-Prasad-P-V : We try to have minimal commits for each PR by separating the PR branch from main and rebasing from it as needed. Please can you try to collapse your changes to a single commit. The changes are looking okay otherwise.

@Krishna-Prasad-P-V : We try to have minimal commits for each PR by separating the PR branch from main and rebasing from it as needed. Please can you try to collapse your changes to a single commit. The changes are looking okay otherwise.

I have opened another PR (https://github.com/facebookincubator/velox/pull/5759) and closing this one. It is difficult squash so many commits into one and with rebasing being done regularly as the PR has been opened a month before. Hence, closing this PR as another new one with a single commit is available.


CSV export in "Advanced export" pane doesn't respect query

It looks like there's an inconsistency when exporting to CSV via the the web interface. Say I'm looking at songs released in 1989 in the classic-rock/classic-rock-song-list table from the Five Thirty Eight data. The JSON and CSV export links at the top of the page both give me filtered data using Release+Year__exact=1989 in the URL. In the Advanced export tab, though, the CSV option gives me the whole data set, while the JSON options preserve the query.
It may be that this is intended behaviour related to the streaming CSV stuff discussed here, but if that's the case then I think it should be a little clearer.

This is the code which is meant to add those options as hidden form fields:
https://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155
It's clearly not working. Need to fix this and add a corresponding unit test.

Here's the test that needs updating:
https://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435

The fix was released as part of Datasette 0.26 - you can see the fix working here: https://v0-26.datasette.io/fixtures-dd88475/facetable?_facet=planet_int&planet_int=1#export

https://fivethirtyeight.datasettes.com/-/versions is now running 0.26 - so your initial bug demo is now fixed: https://fivethirtyeight.datasettes.com/fivethirtyeight-c300360/classic-rock%2Fclassic-rock-song-list?Release+Year__exact=1989#export

Awesome - will get myself up and running on 0.26


It would be nice if event handlers could be dynamically added/removed per connection

Resolved in the latest commit


General examples male/female uses

In all of the examples, you talk about men. The one time you mention a woman, the man is doing the actual work.
This creates an effect that women doesn't belong to this place, I'll explain more in person.

You are right, it can absolutely be improved.
Can you take the lead on this one? :)

Sure, no problem :)
do you want me to edit the existing notes or just review the next ones?

Pick the one you think is better :)

See DabruEleynu and Tamar Eylam Gindin's post on gender-neutral writing in Hebrew


Standalone Init DynamoDb Clients

Type: Feature
Is your feature request related to a problem? Please describe.
Currently the DynamoDb AutoConfiguration is conditional on DynamoDbTemplate.
Describe the solution you'd like
Standalone Initialization of DynamoDb + Enhanced Clients without Depending on DynamoDbOperations and DynamoDbTemplate
Describe alternatives you've considered
Copy+Paste all initialization Logic to our own @Configuration
Additional context
N/A

@maciejwalkowiak , I would love to contribute with PR's. The question is, are you just going to reject them like you have previously done in the past ?

You're welcome to contribute PRs.

The question is, are you just going to reject them like you have previously done in the past ?

Are you sure you want to start this conversation like that?

I just want to know if it's worth that I spend my time creating a PR, that's all

Start small with a PR for a single module. If it's good we will merge.


Create different comment style

New issue?

[X] I have reviewed the Known Issues and confirm this is not a known issue.

TL;DR
It seems that dependabot supports updating version comments as part of its update https://github.blog/changelog/2022-10-31-dependabot-now-updates-comments-in-github-actions-workflows-referencing-action-versions/
However, can the comments look more like https://github.com/pyca/cryptography/pull/10650/files?
I don't know if dependabot would support the ratchet: comments :confused:
Detailed design
No response
Additional information
No response

Hi @stdedos - Ratchet supports more than that GitHub Actions. It would be better to ask dependabot to look for the the ratchet prefix: https://github.com/dependabot/dependabot-core/pull/5951/files#diff-e610ea8f33cbfe74ada7eb6fbeab2afe2e2dad154e191bb209fb69f6ca3d7137R77

Please don't call it completed 😅

That's what GitHub does when you close an issue by default.

There is always https://github.com/refined-github/refined-github/blob/main/source/features/close-as-unplanned.tsx for the utility that Github is not adding 😅


Wait if order status is processing

We noticed that our acme server implementation was not finished creating the certificate as fast as letsencrypt after order finalization. So this patch adds a wait for the order to get out of processing state.

Sadly I no longer have an environment to test these improvements but I am happy to make the changes you suggest or let you do which ever changes you see fit to this PR (or close it and fix it another way).

No problem, I completely understand commitment issues in open source projects: sometimes you don't have time anymore, sometimes you just move on with your life or switch to an alternative software. In any case, your reply is really appreciated: now we know what to expect and can act accordingly. :+1:
So I created #728 to solve the same issue taking into account what you did and the comments I posted in my review.

Replaced by #728, thanks.


[Image_picker] Constant Resetting on Samsung Tab A

I am getting constant crashes on the app I am developing when using the image_picker so rather than looking into if any other plugins were clashing with this one I used the example app on the image_picker plugin.
This happens constantly on my Samsung Tab A.
Unfortunately the "Handling MainActivity destruction on Android" will not work for my app as the end user is required to login before they are able to take pictures so I cannot rescue the lost image. You also state that this is a very rare occurrence but I am experiencing this constantly as are many of my end users.
Steps to Reproduce

Run the image_picker example app
Select image picker camera
Repeat until the app crashes (I have crashes after 3-4 photos)

Expected results: Photo is viewable
Actual results: App resets to the default page (no crash log).
Flutter Version:
Flutter (Channel stable, 1.22.3, on Microsoft Windows [Version 10.0.19041.630], locale en-GB)
• Flutter version 1.22.3 at C:\src\flutter
• Framework revision 8874f21e79 (3 weeks ago), 2020-10-29 14:14:35 -0700
• Engine revision a1440ca392
• Dart version 2.10.3

Hi @Rossdex
I see there's an open issue addressing the case you described. https://github.com/flutter/flutter/issues/70751
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


LINEAR tone mapping disables sRGB encoding.

Hi guys
I want to change the default tone_mapping algorithm,because ACES is too bright .  I tried to change the function tonemap in the file filament\shaders\src\tone_mapping.fs , and rebuild matc, but it seams nothing changed.
Could you please tell how to change the tone_mapping algorithm? thanks in advance

You cannot change the tone mapping operator. If you do change the source file you need to rebuild matc and all materials. But if your problem is that things are too bright it's probably an exposure issue, not a tone mapping issue.

I use the code below to draw image. I create a rendertarget with RGBA16F texture as color backend .
If i use  View.ToneMapping.ACES , the result is brighter than original image, but if i use View.ToneMapping.LINEAR, the result is darker than original image.
So I don't know  how to draw image by unlit mode to render target, so that it is the same bright with the original one
material {
name : "Image 2dmode_normal",
parameters : [
{
type : sampler2d,
name : texture
},
{
type:float,
name:alpha
}
],
requires : [
uv0
],
blending : fade,
shadingModel : unlit
}
void material(inout MaterialInputs material) {
prepareMaterial(material);
float4 texel = texture(materialParams_texture, getUV0());
float4 outputColor = float4(texel.rgb * materialParams.alpha, texel.a * materialParams.alpha);
material.baseColor = outputColor;
}

That's because there's an issue where we don't properly apply gamma encoding when tone mapping is off. Another thing you can do is simply leave the default tone mapping on and apply the inverse tone mapping to your color (see the Materials.md.html documentation).

I just found a workaround
Because I blit the rendertarget to different target, by using the following code. the accumulated effect causes image too brighter. So if Filament provide blit rendertarget directly to Java, maybe we don't need to do blit use the following code
Blit code:
material {
name : blit,
shadingModel : unlit,
parameters : [
    {
        type : sampler2d,
        name : color
    }
],
requires: [
    uv0
],
culling : none,
blending : fade,
flipUV : false

}
fragment {
void material(inout MaterialInputs material) {
    prepareMaterial(material);
    float4 outputColor = texture(materialParams_color, getUV0());
    material.baseColor = outputColor;
}

}

Now, i just close tonemaping for 2d image drawing, instead use that code for 2d image draw. it work great now
material {
name : "Image 2dmode_normal",
parameters : [
{
type : sampler2d,
name : texture
},
{
type:float,
name:alpha
}
],
requires : [
uv0
],
blending : fade,
shadingModel : unlit
}
void material(inout MaterialInputs material) {
prepareMaterial(material);
float4 texel = texture(materialParams_texture, getUV0());
float4 outputColor = float4(texel.rgb * materialParams.alpha, texel.a * materialParams.alpha);
if ( outputColor.a > 0.0 )
material.baseColor = float4(Tonemap_Unreal(outputColor.rgb),outputColor.a);
else{
material.baseColor = outputColor;
}
}

We are rewriting the tonemapper which will give us the flexibility you need. See: https://github.com/google/filament/pull/2561
Closing this for now since you have a workaround. In the future the new tone mapping/color grading APIs will let you choose/provide your tone mapper.


Question regarding Order by highest _score?

Hello, I have installed this package successfully and all is working fine. For 2 days I am wondering and trying to order my results by highest "_score" how can I do this? Thank you for the time in advance!!!

Not sure but it looks like it works :
add the variable sort like that to your search object ( usualy your model ) before launching the search :
$myModel->sort = array('_score' => array('order' => 'desc', 'mode' => 'max'));
$myModel->search('blabla');
hope it can help

You can do it simply with orderBy :
$model->search('myword')->orderBy('_score', 'desc');

I tried this code. It is not taking any effect at all ordering the results. I set this:
$searched = Model::search($q)->orderBy('_score', 'desc')->get();
and there is no effect. If I dd($searched = Model::search($q)->orderBy('_score', 'desc')) I get the following result:
Builder {#508 ▼   +model: Model {#483 ▶}   +query: "the test name"   +callback: null   +queryCallback: null   +index: null   +wheres: []   +limit: null   +orders: array:1 [▼     0 => array:2 [▼       "column" => "_score"       "direction" => "desc"     ]   ] }
I have results that are named Test name but it always shows me the first result, which is The name it is not ordering my results by relevance, but by ID I think. My goal is to sort them by relevance of the combination of several words in the title field.

Can you ty change ElasticsearchEngine.php sort function by :
    protected function sort($builder)     {         if (count($builder->orders) == 0) {             return null;         }         return collect($builder->orders)->map(function($order) {             return [$order['column'] => ['order' => $order['direction']]];         })->toArray()[0];     }

Can you ty change ElasticsearchEngine.php sort function by :

protected function sort($builder)
{
if (count($builder->orders) == 0) {
return null;
}
return collect($builder->orders)->map(function($order) {
return [$order['column'] => ['order' => $order['direction']]];
})->toArray()[0];
}

I just tried it and nothing changed. The results are the same. Ordered by ID ASC.

Maybe it's related to https://github.com/laravel/scout/issues/341
can you check there ?

Ok it's the same kind of issue,
just change the map function by the one on this file :
https://gist.github.com/Julinar/d42d3a9831c416416eb9f7ab52d74702
and it must work :)

Maybe it's related to laravel/scout#341
can you check there ?

Thank you, I managed to fix they issue by changing the public function map in ElasticsearchEngine.php
The current function is:
`public function map(Builder $builder, $results, $model)
{
if ($results['hits']['total'] === 0) {
return $model->newCollection();
}
    $keys = collect($results['hits']['hits'])->pluck('_id')->values()->all();

    return $model->getScoutModelsByIds(
            $builder, $keys
        )->filter(function ($model) use ($keys) {
            return in_array($model->getScoutKey(), $keys);
        })->sortBy(function($model) use ($keys) {
            return array_search($model->getScoutKey(), $keys);
        });
}`

please keep it open so they can fix it later here

Okay. Thank you again for the help!


Style license

I'd like to use this example style for my flutter MapLibre plugin (https://github.com/m0nac0/flutter-maplibre-gl), e.g. to have a style without access token for the CI.
I noticed, however, that the style.json contains the line:

"maptiler:copyright": "This style was generated on MapTiler Cloud. Usage outside of MapTiler Cloud or MapTiler Server requires valid MapTiler Data package: https://www.maptiler.com/data/ -- please contact us.",

Which seems to conflict with the BSD-3-Clause License of this repo. It would be great, if you could clarify whether it's actually okay to use this style.

That's great to hear! Would it be possible to adapt the relevant section of the file?


RET503 autofix errors when function ends with nested block

Example 1
Autofix incorrectly adds return statement inside the last indented block rather than outside. (Not shown in this example, but when there are multiple nested blocks at end of function, a return statement gets added to the innermost block.)
Input
def test(values):
    if not values:
        return False

    for value in values:
        print(value)

Result
$ ruff check --isolated --select RET ret_test.py --fix
Found 1 error (1 fixed, 0 remaining).

def test(values):
    if not values:
        return False

    for value in values:
        print(value)
        return None

Example 2
Autofix adds two return statements when indented code block is at last line of file, has an inline comment, and has no trailing newline.
Input
def test(values):
    if not values:
        return False

    for value in values:
        print(value) # Comment here, no newline at end.

Result
$ ruff check --isolated --select RET ret_test.py --fix
Found 2 errors (2 fixed, 0 remaining).

def test(values):
    if not values:
        return False

    for value in values:
        print(value) # Comment here, no newline at end.        return None
        return None

Example 3
Autofix errors when indented code block at last line of file and has no trailing newline.
Input
def test(values):
    if not values:
        return False

    for value in values:
        print(value)

Result
When run without --fix:
$ ruff check --isolated --select RET ret_test.py
ret_test.py:6:9: RET503 [*] Missing explicit `return` at the end of function able to return non-`None` value
Found 1 error.
[*] 1 potentially fixable with the --fix option.

When run with --fix:
$ ruff check --isolated --select RET ret_test.py --fix

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/charliermarsh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `ret_test.py`, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

ret_test.py:6:9: RET503 Missing explicit `return` at the end of function able to return non-`None` value
Found 1 error.

Version
$ ruff --version
ruff 0.0.247

Thank you for this!

@charliermarsh Thanks for the fix. I tested main branch against the examples from my original post, and looks good except notice that an in-line comment on the last line:
def test(values):
    if not values:
        return False

    for value in values:
        print(value) # Comment here.

...gets moved to the line with added return statement:
def test(values):
    if not values:
        return False

    for value in values:
        print(value)
    return None # Comment here.


Extend UseConsistentWhitespace to pipe and curly braces

Usually, powershell scripts follow those coding rules:

Spaces around pipe

Get-ChildItem -Path $path | Where-Object { ... }
# And not
Get-ChildItem -Path $path|Where-Object { ... }

Spaces inside curly braces

Where-Object { $_.Name -eq "test" }
# And not
Where-Object {$_.Name -eq "test"}

The rule UseConsistentWhitespace is close to checking that. It already checks if there is a space between a keyword and a brace (CheckOpenBrace option), and if operators are surrounded by spaces (CheckOperator option).
Is it possible to add options to check those additional rules?

FYI: I am starting to work on this and looking at how to implement it. I will then decide if new options will be made available for this or if it will be integrated into existing options, any thoughts on that?

Great ! It looks good like this.


remove broken publish job

This CI yml only runs when we tag git.
Tagging git is part of our release process but we publish the jars manually using our personal signing keys.
We have a publish-nightly job that publishes unsigned snapshots and that runs fine.

@pjfanning Please make sure use the right JDK when do the publish.

@pjfanning Please make sure use the right JDK when do the publish.

I used Java 11 to jar building as per

https://github.com/apache/incubator-pekko#building-from-source
https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#build-prerequisites


Fullnode crashes

The Fullnode on stacking mode randomly crashes. It also did the same on previous versions, same mode.
FN version used is StratisBitcoin:1.0.5
Environment: Ubuntu 16.04
info: Stratis.Bitcoin.Connection.ConnectionManagerBehavior[0]
      Node [::ffff:<IP_ADDRESS>]:62200 offline.
info: Stratis.Bitcoin.Connection.ConnectionManagerBehavior[0]
      Reason: Unexpected exception while connecting to socket
info: Stratis.Bitcoin.Features.Miner.PosMinting[0]
      Node staking with<PHONE_NUMBER>0040 (44.82 % of the network weight 2092084.87058546), est. time to find new block is 00:02:22.
info: Stratis.Bitcoin.Connection.ConnectionManagerBehavior[0]
      Node [::ffff:<IP_ADDRESS>]:29906 offline.
info: Stratis.Bitcoin.Connection.ConnectionManagerBehavior[0]
      Reason: Unexpected exception while connecting to socket

Unhandled Exception: System.ObjectDisposedException: Safe handle has been closed
   at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
   at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)
   at Microsoft.Win32.Win32Native.SetEvent(SafeWaitHandle handle)
   at System.Threading.EventWaitHandle.Set()
   at NBitcoin.Protocol.Node.NodeConnection.EndListen(Exception unhandledException) in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 304
   at NBitcoin.Protocol.Node.NodeConnection.<BeginListen>b__16_1() in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 274
   at System.Threading.Thread.ThreadMain_ThreadStart()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
Aborted (core dumped)

This does not sound related to staking.

Fetching new changes from the repo and running without the stacking option. I will report if the same problem arises.

Hi @mtaipe, can you confirm that this issue is still happening?
Please ensure that you have the latest version of the code base 👍

It crashed again, but I was using code of 2 days ago, when I last reported. I will build again a try.

Hello @fassadlr,
The FullNode crashed again. I will try to provide more debug information by running the FN with the parameter: -debug=NBitcoin.Protocol.
Unhandled Exception: System.ObjectDisposedException: Safe handle has been closed    at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)    at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)    at Microsoft.Win32.Win32Native.SetEvent(SafeWaitHandle handle)    at System.Threading.EventWaitHandle.Set()    at NBitcoin.Protocol.Node.NodeConnection.EndListen(Exception unhandledException) in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 272    at NBitcoin.Protocol.Node.NodeConnection.<BeginListen>b__22_1() in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 244    at System.Threading.Thread.ThreadMain_ThreadStart()    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) Aborted (core dumped)

@mtaipe I believe one of our devs has also now experienced this issue. We'll look into this.
Thanks!

@mtaipe PS can you please provide us with the settings you run the node in?

@fassadlr Settings are, -testnet and -debug=NBitcoin.Protocol, however the last didn't provide any logs.
Also tried   adding this line in the NLog.config in their proper section without success:
     <target name=""debugNBitcoinProtocolFile"" xsi:type="AsyncWrapper" queueLimit="10000" overflowAction="Block" batchSize="1000">       <target xsi:type="File" fileName="protocol.txt" layout="[${longdate:universalTime=true} ${threadid}${mdlc:item=id}] ${level:uppercase=true}: ${callsite} ${message}" encoding="utf-8" />     </target>
<logger name="NBitcoin.Protocol.*" minlevel="Debug" writeTo="debugNBitcoinProtocolFile" />
The FN crashed again after two days of running ,  and found this kernel messages:
[897906.312054] TCP: too many orphaned sockets
Let me know if there are some configurations for the NLog.config that could help get more info about this crash.
Unhandled Exception: System.ObjectDisposedException: Safe handle has been closed    at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)    at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)    at Microsoft.Win32.Win32Native.SetEvent(SafeWaitHandle handle)    at System.Threading.EventWaitHandle.Set()    at NBitcoin.Protocol.Node.NodeConnection.EndListen(Exception unhandledException) in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 272    at NBitcoin.Protocol.Node.NodeConnection.<BeginListen>b__22_1() in /home/mtaipe/src/StratisBitcoinFullNode/src/NBitcoin/Protocol/Node.cs:line 244    at System.Threading.Thread.ThreadMain_ThreadStart()    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) Aborted (core dumped)

Thanks @mtaipe. I don't think at this point we need more information. The Node class is subject to refactoring, which will change everything.

Hi @mtaipe there has been various improvements surrounding the disposing of node features, that might have fixed this issue. Can you maybe get the latest code and re-run for us? Thank you!

Closing this issue as @mtaipe has not gotten back to us with any new issues. Plus, a massive amount of refactoring has been done around NetworkPeer. If his issue happens again we can re-raise.

Yes it is likely that the code causing this was removed.

Confirmed, no more crashes. A node with version StratisBitcoin:1.0.7 was running for more than a week without problems.


Convenient way to automatically add conversion to custom types?

Sorry for the newbie question, couldn't find any resource or pointer to answer this.
Assuming I have a custom error like the following:
#[derive(Fail, Debug)]
pub enum MyError {
    #[fail(display = "Custom error 1")]
    CustomError1,

    #[fail(display = "Custom error 2")]
    CustomError2,

}

And would like to use it with the following function:

fn do_something -> Result<(), MyError>
{
    let result: Result<(), std::io::Error> = operation();
    result?
}

Any easy/declarative way to say that io::Error should map to CustomErro2? Do I have to implement std::convert::From myself in such cases?
Thanks in advance

Wouldn't https://doc.rust-lang.org/std/result/enum.Result.html#method.map_err suit that?

@KillTheMule yeah but that would require adding map_err in any place that might raise... I was wondering if there is a way to add them automatically through the macro system, so that I wouldn't have to...

@vmalloc the way you should be using failure is to not make an error kind per type of source error but by type of failure. So instead of having an IoError you have a CouldNotReadConfig etc. That's why no such conversion exists.
This is the rule that boats originally came up with and it's what most people do when they use failure.

I get the general idea behind it, but technically this amounts to loads of map_errs throughout the code... I feel like I'm missing something. For example if configuration is stored across several files, every single I/O operation needs to map manually to CouldNotReadConfig, which is not very ergnomic....

@vmalloc You might consider merging all lower-level operations into one private function that returns the low-level error, and then having a single map_err that maps to your public Fail type.


⚠ Bofrost.at has degraded performance

In 54759f9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1618 ms

Resolved: Bofrost.at performance has improved in d1a38aa.


Kernel request: sinc

The sinc kernel would be handy for applying GP e.g. in bandlimited DSP applications.

This has been a long time ago.
If you still want this kernel to be in GPy, and you know how to implement it, it would be great
if you could try to implement it.
See the docs for how to implement a kernel. All you need to implement is written in there.
Were happy if you get a pull request in, so we can put this feature in.

Any updates?

I keep meaning to do it as it's a useful one for demonstrating at the
summer school ... but haven't got around to it!
We are seeing Thomas on Thursday. Is it in the plan for him to implement
pandas-kernels. Would it be useful 'warm up' for him to do the sinc kernel?
We shouldn't ask him if it's not something that will progress his project
though.
On Tue, Mar 1, 2016 at 8:44 AM, Max Zwiessele<EMAIL_ADDRESS>wrote:

Any updates?
—
Reply to this email directly or view it on GitHub
https://github.com/SheffieldML/GPy/issues/98#issuecomment-190614997.

Did we get this done? If not, can you give me a reference?

Hello mzwiessele.
¿Do you know how to set a new kernel in GPy?
Thanks

Stale.


Website not responsive for Screens.

Horizontal Scroll , Vertical Scroll , not properly fixed.
not ui friendly.

i can fix this , i you allow to me as a contributor.

Hi, can you fork the repo and make a PR?

sure , i will do it.

sure , i will do it.

also can i get some recognition after the work is done.

Yup sure, I think you'll be shown as a contributor on the right panel (e.g., this). I'm not too familiar with Github so if that doesn't work, I could instead create a table/list in the README showing all contributions. Would that be okay with you?

Hey man, I've set overflow to hidden for all textareas except Current Nodes, because someone on Codeforces brought it up and I decided to remove the scrollbars to make it easier to read. Was that the UI issue you were referring to? Or was it something else?

Yup sure, I think you'll be shown as a contributor on the right panel (e.g., this). I'm not too familiar with Github so if that doesn't work, I could instead create a table/list in the README showing all contributions. Would that be okay with you?

this would be fine.

Hey man, I've set display to none for the scrollbars of all textareas because someone on Codeforces brought it up and I decided to remove the scrollbars to make it easier to read. Was that the UI issue you were referring to? Or was it something else?

it was something else

Hi, could you elaborate on the issue in more detail? What is the expected behavior/appearance, and how can I reproduce it? Thanks!


Fatal error hnsd process keeps crashing

I'm on:

macOS Monterey 12.0.1
M1 Max CPU
32GB RAM

There's an another hnsd running likely. Open activity monitor and search for hnsd kill any hnsd processes see if the issue resolves

That was it! Sweet.


Can lagent perform complex visual reasoning task?

Hi,
I think this is an amazing framework and I really appreciate your work!
I am wondering is it possible to use your framework to build an agent performing complex visual reasoning task by using external computer vision models like InternImage / DINO etc.

It can use external computer vision models if the models reimplemented refer to https://github.com/InternLM/lagent/blob/main/lagent/actions/base_action.py


putting an EOL device back on stock ChromeOS is a bad idea. Flex is the best path forward for Haswell/Broadwell Chromeboxes if you want to keep running ChromeOS.

putting an EOL device back on stock ChromeOS is a bad idea. Flex is the best path forward for Haswell/Broadwell Chromeboxes if you want to keep running ChromeOS.
What firmware version is listed on the main UEFI screen?
Originally posted by @MrChromebox in https://github.com/MrChromebox/scripts/issues/246#issuecomment-1419506843

I don't know what you're trying to do here or why you've quoted a comment from another issue.
The error tells you exactly what the problem is with running the script


"error_reason":"invalid_redirect_uri"

According to https://fusionauth.io/docs/v1/tech/oauth/#exchange-the-authorization-code-for-an-access-token , I would expect that /oauth-redirect at
https://github.com/FusionAuth/fusionauth-example-5-minute-guide/blob/22652f49d2c4d2bb62a74947124bc72106c35937/routes/index.js#L55
should instead be /oauth2/token. Yet for both after responding to a login form I get an error like:
{"statusCode":400,"exception":{"error":"invalid_grant","error_description":"redirect_uri: https://MYAPP.fusionauth.io/oauth2/token is not valid.","error_reason":"invalid_redirect_uri"}}

On further consideration, it seems that the url highlighted above should not have query path /oath2/token because that goes to the FA instance (but how would the exchangeOAuthCodeForAccessTokenUsingPKCE fn know where to send it?).
Still, using the query path /oath-redirect would seem to cause an infinite cycle of requests to the FA instance for which it would respond back to /oath-redirect. It seems some other query path and handler is needed.

I found https://github.com/FusionAuth/fusionauth-typescript-client/blob/5571ccf3cc3691cdf67242d2466053540c6bd1d9/src/FusionAuthClient.ts#L1455 but I still don't understand why a handler for route X would specify X as a redirect_url when the handler has no logic for, say, detecting that query params are different so it could avoid an infinite loop of inter-server requests.

http://localhost:3000/oauth-redirect is the local route which catches the authorization code, and then exchanges it for a token from http://localhost:9011/oauth2/token
the server running at 9011 is FusionAuth
the server running at 3000 is custom code.
https://github.com/FusionAuth/fusionauth-example-5-minute-guide/blob/master/routes/index.js#L41 is the custom code, and it uses, on line 52, the FusionAuth client library, but it could also have done a form post like in here: https://fusionauth.io/docs/v1/tech/oauth/#exchange-the-authorization-code-for-an-access-token
Hope that helps.
Also, you might have better luck posting on the forum, as that typically has more eyes on it: https://fusionauth.io/community/forum/

I don't know if it's the chaining of Promise's, each handling a response, or some special behavior of Express routes that I haven't read about yet...but somehow the request sent by the FA instance in response to /oath/token jumps past the code at the beginning of the route-handler to the next Promise. I realize now that this has nothing to do with the FA sample app, so closing this issue.

@MPH-DZP if this is an issue that is confusing to devs new to FusionAuth, definitely want to address it.
Are you able to get the 5 minute app up and running?

@mooreds I am still mystified about how the requests from the FA instance reach the Promise-resolving callbacks. I'm sure the problem is that my mental model of how Promise's work isn't rich enough to explain how Promise's that are pending inbound network events get triggered. Without that mental model, when I consider just the code in the 5 minute app superficially, there is a mysterious jump/goto from the match of the query path, past the code at the top of the handler, to the resolver callback in the then's. I need to keep an eye out for tutorials about this.
Regarding running the 5 minute app, it works fine locally but when deployed to AWS Beanstalk it fails because the express-session module throws an error about it's being inappropriate to use in a production environment without a store: I emailed you separately about whether session storage might use the same connection/service as an app's metadata (e.g. todos)


esphome: 2024.10.3 -> 2024.11.0

https://github.com/esphome/esphome/releases/tag/2024.11.0
To be tested. :construction:

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This broke esphome on  darwin. glyphsets depends on glyphslib depends on ufo2ft depends on cffsubr which is broken on darwin:
error:
       … while evaluating the attribute 'drvPath'
         at /Volumes/extern/git/nixpkgs/lib/customisation.nix:365:7:
          364|     in commonAttrs // {
          365|       drvPath = assert condition; drv.drvPath;
             |       ^
          366|       outPath = assert condition; drv.outPath;

       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:34:12:
           33|
           34|   strict = derivationStrict drvAttrs;
             |            ^
           35|

       … while calculating requiredPythonModules for python3.12-glyphsets-1.0.0:

       … while calculating requiredPythonModules for python3.12-glyphslib-6.9.0:

       … while calculating requiredPythonModules for python3.12-ufo2ft-3.3.0:

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: Package ‘python3.12-cffsubr-0.3.0’ in /Volumes/extern/git/nixpkgs/pkgs/development/python-modules/cffsubr/default.nix:54 is marked as broken, refusing to evaluate.

       a) To temporarily allow broken packages, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_BROKEN=1

          Note: When using `nix shell`, `nix build`, `nix develop`, etc with a flake,
                then pass `--impure` in order to allow use of environment variables.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowBroken = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowBroken = true; }
       to ~/.config/nixpkgs/config.nix.


DRY up objects

Move attr_readers to Redis::BaseObject.
This allows for easier key customization across all object types.
class Redis::BaseObject
  module WithCustomKey
    def key
      "prefix_#{super}_suffix"
    end
  end
  prepend WithCustomKey
end

Move Enumerable functionality to EnumerableObject

Move CoreCommands inclusion to BaseObject

Hi @tmsrjs I appreciate your offer to help maintain redis-objects and am definitely looking for help.  Can you let me know if you're still interested? Thanks.

Hi @tmsrjs I appreciate your offer to help maintain redis-objects and am definitely looking for help. Can you let me know if you're still interested? Thanks.

Hi @nateware! Sure, I'm very much interested. I'll check the issue list and start working on bugs when I have some spare time. Sound good?