alt+click to add multiple cursors also toggles the menu bar

In stable and Insider's build, on Windows.

Hide the menu bar (View > Toggle Menu Bar). You can press alt to toggle its visibility.
Hold alt and click to place a second cursor
When you release alt, the menu bar appears. You can press it again to hide it. But when alt is part of some other action, it shouldn't make the menu bar appear.

Possible fix in #9154

Verified this is OK now.


[Package Issue]: StefansTools.grepWin needs updating

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue
Installation issue.
Brief description of your issue
New package available, manifest needs updating.
Steps to reproduce
-> winget show -e --id StefansTools.grepWin
Found grepWin [StefansTools.grepWin]
Version: 2.0.1098
Publisher: Stefans Tools
Publisher Url: https://tools.stefankueng.com/
Author: Stefan Küng
Moniker: grepwin
Description: Regular expression search and replace for Windows.
Homepage: https://tools.stefankueng.com/grepWin.html
License: GPL-3.0
License Url: https://github.com/stefankueng/grepWin/blob/main/LICENSE
Installer:
  Type: wix
  Download Url: https://github.com/stefankueng/grepWin/releases/download/2.0.9/grepWin-2.0.9-x64.msi
  SHA256: e058c054b2830aa12c9a22e6867dc0392235a356e88fc68bbd5ac569230243a2
  Release Date: 2021-11-27

Actual behavior
Version 2.0.9 is outdated.
Expected behavior
Website show Version 2.0.11 is available.
Environment
Windows Package Manager v1.3.2091
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.2006
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2091.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs
No response

The update doesn't appear to work correctly:
> winget upgrade | findstr /I grep
grepWin x64                                   StefansTools.grepWin                2.0.1125         2.0.1154      winget

> winget upgrade -e --id StefansTools.grepWin
No applicable update found.


got this error "Execution failed for task ':app:minifyReleaseWithR8'." when use the pacakge

I faced this error when trying to run this flutter build apk --release
/Users/abd/StudioProjects/liefer-app-store/build/flutter_sunmi_printer/intermediates/runtime_library_classes_jar/release/classes.jar: R8: Type woyou.aidlservice.jiuiv5.ICallback$Default is defined multiple times: /Users/abd/StudioProjects/liefer-app-store/build/flutter_sunmi_printer/intermediates/runtime_library_classes_jar/release/classes.jar:woyou/aidlservice/jiuiv5/ICallback$Default.class, /Users/abd/StudioProjects/liefer-app-store/build/sunmi_printer_plus/intermediates/runtime_library_classes_jar/release/classes.jar:woyou/aidlservice/jiuiv5/ICallback$Default.class

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:minifyReleaseWithR8'.
> com.android.tools.r8.CompilationFailedException: Compilation failed to complete, origin: /Users/abd/StudioProjects/liefer-app-store/build/flutter_sunmi_printer/intermediates/runtime_library_classes_jar/release/classes.jar:woyou/aidlservice/jiuiv5/ICallback$Default.class

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 57s
Running Gradle task 'assembleRelease'...                          118.4s

┌─ Flutter Fix ──────────────────────────────────────────────────────────────┐
│ [!] The shrinker may have failed to optimize the Java bytecode.            │
│ To disable the shrinker, pass the `--no-shrink` flag to this command.      │
│ To learn more, see: https://developer.android.com/studio/build/shrink-code │
└────────────────────────────────────────────────────────────────────────────┘
Gradle task assembleRelease failed with exit code 1

Do you think because I am using flutter_sunmi_printer: ^0.2.1 and sunmi_printer_plus: ^2.1.00 packages at the same time?

Could be mate. because the both packages use the same AIDL methods to compile try to use just once, there is no explanation to have 2 packages that do the same thing.
Mine has a lot of more features, but keep free to choose the best for you!


Check dependencies and security vulnerabilities

Describe the desired behavior
Make sure we are using the latest versions of dependencies and that we do not have any high or severe security vulnerabilities.
Describe the current behavior
May be using some older packages.
Is this request related to a current issue?
No
Additional Context

PR for this issue is merged. Closing this issue.


Downgrade Jenkins agent to CUDA 9.2, to fix broken NCCL2 installation

See https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-4231/2/pipeline/51.
The current scripts downloads NCCL2 from URL https://developer.download.nvidia.com/compute/redist/nccl/v2.2/nccl_2.2.13-1%2Bcuda${CUDA_VERSION}_x86_64.txz. This URL works fine when CUDA_VERSION is 8.x or 9.x but fails for 10.1.
TODO. Either find a link that's not behind a login wall, OR upload installers to a private S3 bucket.
EDIT. I think it would be best if we place NCCL2 installers inside the worker image. This way, we don't generate unnecessary HTTP traffic.

Codecov Report

Merging #4232 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4232   +/-   ##
=======================================
  Coverage   67.28%   67.28%
=======================================
  Files         132      132
  Lines       12220    12220
=======================================
  Hits         8222     8222
  Misses       3998     3998

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224786f...1af54b8. Read the comment docs.

I created a new issue to discuss improvements to Jenkins: #4234. I'd like to create a major refactor of Jenkins, for the sake of simplicity, de-duplication, and wider coverage.

Hmmm we can probably get the new nccl binary up soon. Suggest merging this though so we can continue to use CI, we can change it back to 10.1 later.

Now that nccl is open sourced, can we compile it ourselves?  I'm doing this for 10.1 setting

That's a very old version of nccl. Maybe upgrade to a newer version?

Merging for now to unblock CI. Will follow up with another PR to support 10.1 properly


Roll engine 0e500daac83b..5a045dd1f702 (19 commits)

https://github.com/flutter/engine/compare/0e500daac83b...5a045dd1f702
git log 0e500daac83b5ed3ba20a8d9452bfaa15b996ede..5a045dd1f702d99cd1578ef4a1b647016ee0b730 --no-merges --oneline
5a045dd1f Log instead of throwing (flutter/engine#8881)
7e05f94ca Roll src/third_party/skia b0d8b76c4f62..9f0eeac8204f (4 commits) (flutter/engine#8879)
e7b944259 Roll src/third_party/skia d05c5eec42e9..b0d8b76c4f62 (1 commits) (flutter/engine#8877)
b226f25cc Roll src/third_party/skia d699a66fa220..d05c5eec42e9 (2 commits) (flutter/engine#8876)
4be57cf7f Roll src/third_party/skia 5f2807b71e71..d699a66fa220 (1 commits) (flutter/engine#8875)
bd3287522 Roll src/third_party/dart 821c75c584..3173e594ba (9 commits)
53309f81c Roll src/third_party/dart 36c315eacc..821c75c584 (2 commits)
bde63ebdc Roll buildroot to pull in Fuchsia SDK flag updates. (flutter/engine#8870)
f6e6d3986 Wire up Fuchsia SDK related updated for shell dependencies. #8869
444925f13 Roll src/third_party/dart cdabea8fe2..36c315eacc (17 commits)
3f9de1abb Roll src/third_party/skia 77af4ecd3546..5f2807b71e71 (3 commits) (flutter/engine#8866)
10cbdd49d Add resize functions to GLFW shell (flutter/engine#8864)
62ab9c7b8 Provide access to GLFW window in plugins (flutter/engine#8806)
4d830d2c9 Roll src/third_party/skia 7d2ad0fdef01..77af4ecd3546 (9 commits) (flutter/engine#8862)
3671182a9 Get prebuilt Dart via CIPD (flutter/engine#8859)
07bb4f9cd Roll src/third_party/dart 125c5cbf4a..cdabea8fe2 (4 commits)
7bcb665e7 Roll src/third_party/dart 67df3ff878..125c5cbf4a (6 commits) (flutter/engine#8856)
94b40540b Roll src/third_party/skia 2f3637bf2ed4..7d2ad0fdef01 (1 commits) (flutter/engine#8857)
2c2f060b7 Roll src/third_party/skia 719a69ca5a6d..2f3637bf2ed4 (2 commits) (flutter/engine#8855)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6080010901782528

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6080010901782528 , https://cirrus-ci.com/task/6294762521362432

Commit queue failed; closing this roll.


Update PPP

Codecov Report

Merging #327 (c697e9b) into master (f170e56) will increase coverage by 13.69%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #327       +/-   ##
=============================================
+ Coverage     62.03%   75.72%   +13.69%
- Complexity      709      851      +142
=============================================
  Files           107      107
  Lines          2629     2604       -25
  Branches        312      311        -1
=============================================
+ Hits           1631     1972      +341
+ Misses          925      520      -405
- Partials         73      112       +39

Impacted Files
Coverage Δ

.../main/java/manageezpz/storage/JsonAdaptedTask.java
89.18% <0.00%> (-5.86%)
:arrow_down:

...c/main/java/manageezpz/logic/parser/CliSyntax.java
93.33% <0.00%> (-0.42%)
:arrow_down:

src/main/java/manageezpz/model/Model.java
100.00% <0.00%> (ø)

src/main/java/manageezpz/ui/TaskCard.java
0.00% <0.00%> (ø)

src/main/java/manageezpz/model/UserPrefs.java
80.00% <0.00%> (ø)

src/main/java/manageezpz/model/task/Date.java
90.90% <0.00%> (ø)

src/main/java/manageezpz/model/task/Task.java
92.30% <0.00%> (ø)

src/main/java/manageezpz/ui/TaskListPanel.java
0.00% <0.00%> (ø)

src/main/java/manageezpz/model/person/Name.java
90.00% <0.00%> (ø)

src/main/java/manageezpz/model/tasktag/Tag.java
30.00% <0.00%> (ø)

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f170e56...c697e9b. Read the comment docs.


Image (icon) of AWS Redshift is missing in VSCode description

Thanks for the report. We updated doc today at https://vscode-sqltools.mteixeira.dev to reflect that the use of this official driver is being deprecated (see #991) in favour of the community driver from @kj-9.
The official driver will continue to work for connections already defined to use it, but that row will disappear from the Details tab of the SQLTools extension.


Create Invasive planning boundary web mapping services

Create Geoserver Planning Boundary Layers
Currently Geoserver does not support the Geographic data type. The addition of a geometry layer is required in order to create the layers. A Web Mapping Service (WMS) is the most common service. However, a Tile Mapping Service (TMS) is required for the Off-lining library within the web map.

[ ] Creation of geometry (Albers) column in the IPMA database layer
[ ] Creation of geometry (Albers) column in the RISO database layer
[ ] Creation of WMS/TMS layer in Geoserver for the IPMA dataset
[ ] Creation of WMS/TMS layer in Geoserver for the RISO dataset
[ ] Aggregate layer (Gravel pit) geometry (Albers) column
[ ] Aggregate layer (Gravel pit) WMS/TMS layer

There seems to be issues connecting to the database. I've checked the credentials and everything works. This is the error message received from Geoserver:
Error creating data store, check the parameters. Error message: Unable to obtain connection: Cannot create PoolableConnectionFactory (Connection to localhost:5432 refused. Check that the hostname and port are correct and that the postmaster is accepting TCP/IP connections.)


Feature/graphical tests

Tests on graphical added to debug some viewmodel issues. Proves all input probs come back as outputs. and all input values come back as the means of the output distributions

My brain is dizzy trying to solve a monotonicity problem. Given a non-monotonically increasing upper quantile, I can calculate how much larger the standard deviation needs to be so that the upper quantile is monotonically increasing. Likewise, given a non-monotonically increasing lower quantile, I can calculate how much smaller the standard deviation needs to be so that the lower quantile is monotonically increasing.
But what if, by fixing one side, we mess up the other?

I think that the errors have come about because we're fixing one side and messing up the other.
So we need to calculate the change in the standard deviation so that both lower and upper quantiles are monotonically increasing.

Aha. I need to reduce this to two equations and one unknown (or four equations and three unknowns). I think I found a path.

I arrive at the standard deviations being equal.

if the standard deviations are the same but the means are equal, then the quantiles equal each other plus the difference of the means where the means are assumed equal.

The current failing test is also a result of the monotonicity logic. Where standard deviation increases fast enough, the standard deviation of distribution i=1 is passed down to every other distribution i = 2, ... n. So in this case, setting the standard deviations equal does not work.

Bob had a separate SampleGraphical method. I disregarded that method because I wanted to create an uncertain paired data object with the graphical data and use SamplePairedData.
It seems like we should instead just let stage_frequency be a graphical object when not created from an LP3 and rating curve and then use a Graphical.SampleGraphical method.

@rnugent3 if you want to do that, that works - i think uncertain paired data implements an interface - IPairedDataProducer
you might just implement the graphical sample under that interface and we may be able to refer to it as the iPairedDtaProducer instaead of uncertainpaired data?

@Brennan1994 anything more you'd like to do here?


Missing files in sdist

It appears that the manifest is missing at least one file necessary to build
from the sdist for version 0.1.2. You're in good company, about 5% of other
projects updated in the last year are also missing files.
+ /tmp/venv/bin/pip3 wheel --no-binary lammps-interface -w /tmp/ext lammps-interface==0.1.2
Looking in indexes: http://<IP_ADDRESS>:9191/root/pypi/+simple/
Collecting lammps-interface==0.1.2
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/a43/e5db5b36c7613/lammps-interface-0.1.2.tar.gz (105 kB)
    ERROR: Command errored out with exit status 1:
     command: /tmp/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-1c5jig3n/lammps-interface/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-1c5jig3n/lammps-interface/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-wheel-1c5jig3n/lammps-interface/pip-egg-info
         cwd: /tmp/pip-wheel-1c5jig3n/lammps-interface/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-wheel-1c5jig3n/lammps-interface/setup.py", line 3, in <module>
        with open('requirements.txt') as f:
    FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

thanks for the heads up @thatch -  fixed in #36 .
Once @peteboyd gets to have a look at some of the open issues, we'll make a new release .


Only 8 SpotLights or OmniLights can be displayed on a given object

Godot version:
3 Beta 2
OS/device including version:
Windows 10 64-bit with NVIDIA GEFORCE 940M
Issue description:
I have 9 SpotLights all aimed at a MeshInstance, but both in-editor and in-game only 8 of them produce light
Steps to reproduce:
create a scene with a mesh instance large enough for several spotlights to hit it, and create 9 spotlights that all shine on their own spots on the meshinstance

Kicking to 3.2, won't be solved in 3.1

This limitation should now be lifted as of commit ee1e89f, closing.

Note that this limitation was also lifted in the 3.2 branch (for Godot 3.2.4) with #43606.
The default number of lights per object is now 32, and you can configure it further.


"run selected" can get disabled after save in debugger (3.0.76)

If you are running sunit tests from the project browser, and save a method in the debugger, when you come back to the project browser, for the method that you saved... the run selected test menu item is disabled in the method list.

get to method RowanSample1Test >> test2
put a breakpoint in
use method menu run selected test.  See debugger.  add a space or something and save method.  use the go arrow to finish running test.  See Sunit tab.
the browser still has the test2 method selected.  Try to run selected again.  change to different tabs and methods and it stubbornly stays disabled... you have to go to a different class to use it.

The instVar isTestMethod was not getting initialized correctly in RowanMethodService. Fixed in 3.0.77.


vscodebot is adding the tag *out-of-scope, and the issue closed

vscodebot itself, not a member of the dev team, is adding the tag *out-of-scope to some issues with enough upvotes, and the issues are closed. Is this an intended behavior?

#11723
#22841
#41289
#42170
#50035
#61838
#84120

Any news on this - all these issues were supposed to be on the backlog and then just disappeared...

Commenting for some more visibility on this post. Any updates?

+1 searched for two issues today where the bot closed things

Still hoping for backgrounds

Implementing backgrounds is such a simple feature, why is it getting swept under the rug? Background transparency as well. Windows terminal guys figured this stuff out years ago, yet vscode closes relevant issues via an automated bot with zero explanation? What the heck?!

@Tyriar if you're not the right person to tag can you please tag them as this is getting worse as time goes on with it closing more and more issues.

These were closed as out of scope while we were issue grooming as mentioned in the closing comment. See https://github.com/Microsoft/vscode/wiki/Issue-Grooming#out-of-scope-feature-requests

Here are the criteria we use to make the decision about closing a feature request:

Does the functionality described in the feature request have any reasonable chance to be implemented in the next 24 months? 24 months is longer than our roadmap which outlines the next 6-12 months. Thus, there is some crystal ball reading on our part, and we'll most likely keep more feature requests open than what we can accomplish in 24 months.
Has the community at large expressed interest in this functionality? I.e. has it gathered more than 10 up-votes or more than 10 comments? This criterion alone covers more than 650 of the 2850 open feature requests as of right now, October 9th, 2019.
Do we think the feature request is bold and forward looking and would we like to see it be tackled at some point even if it's further out than 24 months? (Clearly, this one is the most subjective criterion.)
If the answer to any of the three questions is yes then we ask about affordability:

Can our team afford to implement the feature? I.e. are the costs to implement the functionality reasonable compared to the size of our team?

Chances are they were closed because they likely won't get done in the next 24 months or ever. The team needs to make some decisions sometimes which are hard for the sake of avoiding feature bloat and maintaining our sanity (issue count); no the bot didn't close the issues without some human interaction. You can see why we would let a bot do this instead of a person because of some of the reactions you see in the issues and here.
Regardless, it's much better for everyone if we're honest and close the issue instead of keeping your hopes up. Taking custom background as an example, I expect this would simply never get implemented as it's kind of the definition of feature bloat, there's also extensions available that give you a workaround if it's that important to you.


Debug slight inconsistencies in percentile calculations

While researching BigQuery's performance at calculating deciles on the fly, I noticed some disparities between the results returned by BigQuery (and verified independently by me as correct) and the percentiles in our calculated measures.
I used cerazette measures for practices for January 2016 as my test data. The 90th percentile returned by BigQuery is 0.60389 and my own calculations are in the region of 0.6048. However the 90th percentile in our calculated measures is 0.59918. Other deciles are off by a similar small amount.
I also noticed that for this practice, the Cerazette measure for January 2016 is 100%, but the practice is listed as being at the 97th percentile. This is because we're using method='min' with scipy's rankdata, but we should review whether it's the best way to do things, and whether it's affecting the calculations above.
Debug this and correct any incorrect values.

OK, I think this is because we're using a different set of practices - in our import script we explicitly exclude non-standard practices and practices that were closed or unopened on the date in question, whereas the BigQuery query I used included all practices (and we know that some non-standard practices do prescribe, and also that there can be a lag between a practice closing and prescriptions being processed).
It would still be good to verify using BigQuery though, I'll see if I can do this without it getting too complicated.

I'm closing this as not significant, see my debugging notes.
Basically I found that the margin of error is tiny, and probably to do with there being no standard quantile calculation method.
After some thought, I also decided that using the min method in rankdata is the best approach, for two reasons:

For most of our measures, higher is worse, so we're effectively giving organisations the benefit of the doubt where available, which feels like the right thing to do
The modal measure will be 0, not 100, so using min will be confusing less often

However, we can review this if it does cause usability problems.


Marketplace icon and background color broken

Settings in package.json don't have an effect on the marketplace listing:
https://marketplace.visualstudio.com/items?itemName=mattlott.copy-github-url

This seems to be working now:
https://marketplace.visualstudio.com/items?itemName=mattlott.copy-github-url


How to use this SDK for egress server

Hi,
I want to use this SDK and with gstreamer for python to do an egress server - called "myegress".
My scenario is:

When we send TrackCompositeEgressRequest to livekit server
livekit server will send media stream to "myegress"
at "myegress" will receive this media stream and I will captured it by OpenCV.
And then I will apply AI model detection for captured images

Please advise if I can use this SDK for above scenario?

You should be able to use this SDK to send a TrackCompositeEgressRequest. In your case it sounds like you want to livekit to output an RTMP Stream. I believe you want the livekit.twirp.livekit_egress_twirp module from this library. To be honest I don't know if it's the Client or the Server (this code is generated from the livekit proto files)
The receiver of the stream would likely be a separate process where you would capture it with gstreamer and do your post-processing.

Thank you for your answers. I tried with TrackCompositeEgressRequest and output is RTMP stream. Then I used OpenCV read the RTMP setram. But I got a delay from input stream to output stream ~ 25 seconds (I expected a deplay < 3 seconds). I'm not sure it cause by RTMP stream or cause by OpenCV.
My flow as below:
A client send request: TrackCompositeEgressRequest to livekit-server
Egress extract video and connect to a RTMP server.
The client connect to RTMP server using OpenCV and read RTMP stream
At the client side, I saw that the RTMP stream was deplayed about 25 seconds.
That why, I tried to use another solution - write an egress by using this SDK, so that I dont need to use RTMP. Because, Egress use gstreamer, so I can capture video at egress end point using OpenCV (OpenCV support gstreamer).
Please advise.
Thanks and regards,

Apologies for the delayed response. Unfortunately I'm not able to provide support with this one. I suggest trying to mock up what you want to do using one of the official server SDKs: https://docs.livekit.io/references/server-sdks/ or ask for help through the official livekit channels.


add interface to get finished transaction ids

Codecov Report

Merging #104 into release-rc4 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-rc4     #104      +/-   ##
=================================================
- Coverage          32.23%   32.20%   -0.03%
  Complexity           361      361
=================================================
  Files                 54       54
  Lines               4514     4518       +4
  Branches             376      377       +1
=================================================
  Hits                1455     1455
- Misses              2951     2955       +4
  Partials             108      108

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/webank/wecross/stub/bcos/BCOSDriver.java
22.56% <0.00%> (-0.03%)
34.00% <0.00%> (ø%)

.../webank/wecross/stub/bcos/proxy/ProxyContract.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...bcos/performance/hellowecross/PerformanceTest.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...erformance/hellowecross/proxy/PerformanceTest.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e429e6a...ed62fea. Read the comment docs.


The use of partial classes is unnecessary

It's normal for C# to interact with partial classes regularly but these are usually created by tools like WinForms UI designer, where the partial class is there to help hide the complexity of the auto-generated code.
Using a partial classes for separating properties and methods is unusual and not something I'd consider good practice.
I'd suggest that the ToString override is appended to the Hotel.cs and Address.cs classes. If you're looking to improve readability, you might want to add these to a region named Overrides. For example:
public class Address
   {
       [IsSearchable]
       public string StreetAddress { get; set; }

       [IsSearchable, IsFilterable, IsSortable, IsFacetable]
       public string City { get; set; }

       [IsSearchable, IsFilterable, IsSortable, IsFacetable]
       public string StateProvince { get; set; }

       [IsSearchable, IsFilterable, IsSortable, IsFacetable]
       public string PostalCode { get; set; }

       [IsSearchable, IsFilterable, IsSortable, IsFacetable]
       public string Country { get; set; }

       #region Overrides

       // This implementation of ToString() is only for the purposes of the sample console application.
       // You can override ToString() in your own model class if you want, but you don't need to in order
       // to use the Azure Cognitive Search .NET SDK.

       public override string ToString() =>
           IsEmpty ?
               string.Empty :
               $"{StreetAddress}\n{City}, {StateProvince} {PostalCode}\n{Country}";

       [JsonIgnore]
       public bool IsEmpty => String.IsNullOrEmpty(StreetAddress) &&
                              String.IsNullOrEmpty(City) &&
                              String.IsNullOrEmpty(StateProvince) &&
                              String.IsNullOrEmpty(PostalCode) &&
                              String.IsNullOrEmpty(Country);

       #endregion
   }

This improves the readability and simplifies the project structure.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f14ecb69-f8a0-f4e6-a968-916809dce880
Version Independent ID: e61b508a-b745-9ba7-fc93-75d5b6bc65e8
Content: Quickstart: Create a search index in C# using .NET - Azure Cognitive Search
Content Source: articles/search/search-get-started-dotnet.md
Service: cognitive-search
GitHub Login: @tchristiani
Microsoft Alias: terrychr

@MikeCodesDotNET Thanks for the feedback! We are currently investigating and will update you shortly.

please #reassign to @HeidiSteen

to is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign @HeidiSteen

@MikeCodesDotNET Your suggestion is definitely better C#, but the point of the quickstart sample is to be as short/simple as possible.  We have other C# samples that are supposed to be more of a template for customers who want to copy-paste code.  Your suggestion will be considered for those samples.   This work item is tracking your suggestion:  https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1702505
I'm going to close this issue because we're tracking it in our content database.  Thanks again for the filing issue.
#please-close


Day 7 never appears

If this integration is installed when day 7 data is unavailable, it will never create sensors for the day 7 forecast.

I reloaded the component the other day, and the forecast didn’t actually even have day 6. Need to figure out the best way to handle this. Create dummy sensors anticipating that there eventually be a day 6 appear in the data?

I think that's best. Give them unknown as the state.

Fixed in 0.9


File changes

reorganized directory structure and rename files to snake case
Mie and Go folders no longer have redundant duplicate files
All OPs now stored in /OP_data
All LAPs now stored in OP_data/480band/laps
GO files now stored in OP_data/480band/Go
Mie files now stored in OP_data/480band/Mie
fsds files now stored in OP_data/480band/fsds
refractive indices for water, ice, etc stored in OP_Data/
pigment files in Data/pigments
miscellaneous files stored in Data/additional_data
Closes #25
Closes #19

pigment data are spread between folders and should be merged. In particular, "./Data/pigments", "./Data/pigments/pigments_trials" should be merged and pigment files in and "./Data/additional_data" should also be moved to "./Data/pigments" then duplicate files deleted. also, following files should be deleted: InVivoPhenolData.csv, phenols_invivo_corrected.csv, phenol_mac_correction.csv, phenols_original.csv, phenols_invivo_corrected.csv, ppg_shifted.csv, ppg_raw_extract_mean.csv,
ppg_raw_extract_all_stations.csv.
maybe the bubble_reff_calculator could be moved to a subfolder as it's not a main file
the update_netCDFs also could go somewhere else than the main folder
in "./Data/OP_data/480band/GO" the files GA_HE2a, GA_only_stations, GA_Halbach2021, SA_Halbach_2021, Glacier_Algae_IS should be deleted
suggest to rename "Mie" to "ice grains" and "GO" to "ice crystals" in ".Data/OP_data/480band" to be consistent with "bubbly_ice_files" (itself could be renamed to "bubble_inclusions" or simply "bubbly_ice" - alternatively to keep consistency put the bubbly ice folder in "Mie" but I think we should not organise following the algo used to produce the data, it's less user friendly

Thanks!
ok, agree with pigment data organization - was hoping you would advise on which files are still relevant.
Will address all comments in next set of commits.
Prefer "hexagonal columns" and "spherical grains" to "ice grains" and "ice crystals" for renaming Mie and Go though.

Thanks! ok, agree with pigment data organization - was hoping you would advise on which files are still relevant. Will address all comments in next set of commits. Prefer "hexagonal columns" and "spherical grains" to "ice grains" and "ice crystals" for renaming Mie and Go though.

cool! can we do "ice_hexagonal_columns" and "ice_spherical_grains"? I just think ice should appear somewhere

ok - that should address all your comments apart from moving the r-eff calculator and netcdf builder - can we leave them where they are for now?

ok - that should address all your comments apart from moving the r-eff calculator and netcdf builder - can we leave them where they are for now?

sure!


(maint) Merge 5.5.x to 6.4.x

This PR solves the conflicts for the merge-up between 5.5.x and 6.4.x

puppetlabs/5.5.x:
(PUP-10287) mailalias: comma inside commands fix
(PUP-10227) Close the HTTP connection

Conflicts:

lib/puppet/network/http/pool.rb
lib/puppet/provider/mailalias/aliases.rb
spec/fixtures/integration/provider/mailalias/aliases/test1
spec/unit/network/http/connection_spec.rb

This PR also adds a defense for http.finish and fixes comments from this PR: https://github.com/puppetlabs/puppet/pull/7968

CLA signed by all contributors.

I assume this is missing the top few things on the 5.5.x branch because they haven't gone through CI yet? We are very interested in getting that settings work into master before stop-ship for the release, do folks think that will be possible?

I'm going to redo this without 8acc58cef6058654dcc5dbe58380e2e2f46d52d1, and also new commits landed in 5.5.x that conflict with 6.4.x.


update flask skeleton

The skeleton of routes.py, route '/shopcarts/' accepts four different HTTP methods to implement create, update, delete and list shopcart.

Please remember to connect the pull request to an issue:) I'm assuming this one should be connected with "Create skeleton Flask app", feel free to change!


Confidence level

when I open the confidences in Radial annotator and I have the list of citations I would like to be able to click on them to check the details of citations (titles, journal ...).

@mjy in place or redirect to /citations/xxx" ?

In place
On Thu, Sep 27, 2018, 10:06 AM José Luis Pereira<EMAIL_ADDRESS>wrote:

@mjy https://github.com/mjy in place or redirect to /citations/xxx" ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/530#issuecomment-425128310,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYSGY_a6vXbbRb4u81LkvLYzdWBvPKks5ufOmKgaJpZM4W7VGp
.

@reptalus let me know if this change is what you looking for or if you prefer something different

@jlpereira this nice! What about now the possibility to click on the citation to open that one on the Citations by source page? If it is possible would be nice because I will have the possibility to add extra info on that specific citation by Citations by source tasks.

We might want an icon for citations by source, seems we will use it in
different places.
On Thu, Sep 27, 2018 at 2:15 PM, reptalus<EMAIL_ADDRESS>wrote:

@jlpereira https://github.com/jlpereira this nice! What about now the
possibility to click on the citation to open that one on the Citations by
source page? If it is possible would be nice because I will have the
possibility to add extra info on that specific citation by Citations by
source tasks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SpeciesFileGroup/taxonworks/issues/530#issuecomment-425210917,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABYSMwcWNo3MAm0FVHyZh7UHA_qsctRks5ufSPegaJpZM4W7VGp
.

Try now @reptalus , the citation icon will works like a button. When you click it another tab will be open with the citation by source task

@jlpereira Perfect!


feat(consumer): Wrap consumer strategy with DLQ if it exists

ConsumerStrategyFactory builds the main strategy used by all consumers in Snuba
Optionally pass a DLQ policy to the Consumer Strategy Factory
This will wrap the strategy with a DLQ with the given policy

Here's an example of how this will be used:
https://github.com/getsentry/snuba/pull/2585

Looks good to me though I think it should get a look from somebody who's more arroyo-familiar


Allow disabling timeskipping on TestWorkflowEnvironment

What was changed
This exposes a setting in TestEnvironmentOptions that people can use to disable timeskipping.
Why?
https://github.com/temporalio/sdk-java/pull/813 fixed a bug that was load-bearing for a customer's test that assumed timeskipping was off. This PR should unblock their test by letting them formally disable timeskipping.
Checklist

Closes (no issue)

How was this tested:
There's a new unit test. Because of how it has to rely on the actual passage of time to make its assertions, I'm not a fan of it, but it proves the feature works. I am very open to not committing it.

Any docs updates needed?
No

@nagl-stripe Thanks for your contribution!

@nagl-stripe Thanks a lot! looking forward for the new release 😄


Support for importing tracks from foo_dop

The old component (foo_audioscrobbler) has a feature where it imports played tracks from an iPod device managed by the foo_dop component.
It would be great if the same feature could be added to this component.
I believe this should be possible by using the foo_dop SDK, more specifically portable_device_playbackdata_callback_v2, but I'm not quite sure how interaction between separate components works, or where in foo_scrobble the required code should be added.

Please consider this. I depend on this foo_audioscrobbler feature quite heavily, and it is the main reason I am still using that component.


2 different views with forms for creating and updating articles - bad practice

I suppose it would be better to join them into one view with one article form. Otherwise there is violatation of DRY principe. And it's much more complicated handle of the same html form in 2 different places
I can make PR If you agree with my point of view.

I agree, this violates DRY and is bad practice, would be great if you could fix it!

I agree, this violates DRY and is bad practice, would be great if you could fix it!

just commited pull request

just commited pull request

My post was about using a directive and controlling the method through an attribute, but this seems much neater!

Seems we've already done some refactoring there on the articles module.
Closing.
@ramusus @JuanCaicedo welcome to comment and add anything else if you'd like.


parse variables

What did you implement:
Closes #12345

How did you implement it:

How can we verify it:

Todos:

[x] Write tests
[ ] Write documentation
[ ] Fix linting errors
[ ] Provide verification config/commands/resources

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          136       136
  Branches        13        13
=========================================
  Hits           136       136

Impacted Files
Coverage Δ

src/index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdb298...f3c83df. Read the comment docs.


Add gcs configuration to kubernetes unit and conformance ppc64le periodic jobs

Ref: https://github.ibm.com/powercloud/container-dev/issues/1333

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Rajalakshmi-Girish
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please fix the author's name and email, it is showing root right now.

Please fix the author's name and email, it is showing root right now.

I am not sure where you wanted me to change these details. @mkumatag Can you please elaborate.

I am not sure where you wanted me to change these details. @mkumatag Can you please elaborate.

If you look at the author of this PR's commit it shows as root which is not correct, please amend the commit with the proper email and name and rebase the PR as well to accommodate the latest changes in the code.

I am not sure where you wanted me to change these details. @mkumatag Can you please elaborate.

If you look at the author of this PR's commit it shows as root which is not correct, please amend the commit with the proper email and name and rebase the PR as well to accommodate the latest changes in the code.

Done. @mkumatag please check.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, Rajalakshmi-Girish
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

key test-kubernetes-periodics.yaml using file config/jobs/periodic/kubernetes/test-kubernetes-periodics.yaml

In response to this:

Ref: https://github.ibm.com/powercloud/container-dev/issues/1333

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Shipping method validation

Issue Reference
#5305
Description
Checker added to saveShippingMethod.
How To Test This?
Add a product to cart disable a shipping method and try to use save-shipping API, you will get a 400 error.

@devansh-webkul Thanks for your guide,
I added the property to the abstract class and also add the method to methods array keys and values and checked for references on this method and seems there's no error but it will break all third-party packages.
I think there should be an update on documentation example codes and also bagisto package generator.
I can handle those if this will be the final code.

Yes, this will break the third-party package, I need to discuss this first with the team.

Hi, @devansh-webkul
Thank you, I fixed the code style and doctypes.
thanks for backward compatibility but there's a point if third-parties follow the document instructions we can automatically generate $method with $code_$code and put an extra version compare on top of checker in saveShipping method in cart

Yes. this can be done.

So shall i go with backward compatibility  or you handle that?

No problem, i will manage.

Ok, thanks 💜


Update to latest typescript and fix typing for SubscriptionCallbackBuildStateFunction

@asdanilenk,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


CSS missing after build with latest 0.15.x versions

Describe the bug
I am working on a private project and it uses Ant-Design-Vue 2.x UI framework and integrade Okta Widget for user authentication.
All things works fine with previous 0.14.6 version. But when I upgrade to the latest version, I got several issues after build.

Ant-Design-Vue related:

warnings when minifying css:
Missing '}' at 182:1.
Broken URL 'url(data:image/svg+xml;
  background-repeat: no-repeat;
  background-position: center center;
  background-size: 30%;
}
...
...
@media (min-width: 992px) {
  .logo[data-v-2309f04f] .ant-image {
    width: 220px;' at 11:20. Ignoring.

In my project, the Windicss config does not have transformCSS: 'pre' enabled. If added, the error will change to the Less files in ant-design-vue node_module folder.

Okta Widget related:

Please see the screenshots below as the widget's build-in stylings are lost compare to the old build.
0.15.1 to 0.15.7:

0.14.6:

Minimal Reproductions
Sorry about not able to provide a repo as Okta widget needs some auth server setup to work together.
Versions

vite-plugin-windicss: "^0.15.7"
vite: "^2.2.1"
framework(vue/react/svelte/etc): "Vue 3.0.11"

Can you upgrade vite-plugin-windicss to the least version (both v0.15 or v0.16 are fine) and see if it's fixed? Thanks

In my case it's fixed. Thanks.

Can you upgrade vite-plugin-windicss to the least version (both v0.15 or v0.16 are fine) and see if it's fixed? Thanks

@antfu Thanks for the fix. Upgraded to 0.15.8 and the styling issues are gone. No error occurred.

Good to hear! Thanks for checking out.


Stop Woocommerce Version Check

The plugin must not check for major woocomerce versions . The code must be light as much as possible
After all we do not expect woopoly 1.0.0 to work with woocomerce 2.6 , it is a major update.
Versions check must be for minor changes only in woocommerce and polylang

Tricky decision:
Ideally the first woo3 release should be compatible with both woocommerce 2.6 and woocommerce 3.0 for the convenience of users during their transition period, though it's certainly adding complexity to the code and testing.
As a user myself, my production is up to date with all components except wooCommerce3 and I would be annoyed if the plugins started releasing woo3 only versions.
Should v1 refuse to activate if wooCommerce >3.0 is not detected?

ie add check for woocommerce3 in canActivate() and update activateError.php to indicate dependency on wooCommerce3 or higher ?

At the moment:

the updates for woo3 should work as well or better with woocommerce 2.6 than the current 0.26 version.
New fixes and enhancements are applied to v3 only, leaving execution of old unfixed code for v2.6.

@Jon007 I got your Idea, The last version which supports woo v2.6 will be woopoly v0.29 , the new version must support woo v3.0 only with no support for the old version, and I think this way makes sense. and it is easier to test.
if we need to support users who use woo2.6 or fix some old bugs we can still patch the version 0.29 , these patch versions will be available throw WordPress repo too then users can switch to old version of this plugin using wp-rollback
WooPoly 1.0.0 and later versions will handle this type of checks clearly upon activationt , I am already working on a solution for this. for now we must stop the check for Woo3.0 in our new code . we check only for minor changes in Woo3.0 and Polylang 2.0

ok, understood, let's keep a separate branch for 0.29 patches.
Actually there are some in my previous RC which apply to 0.29, but really we need to focus limited available time on moving forward.
Noting WooCommerce 3.0.7 now out, should update the minimum version:  there is no point supporting 3.0.1-3.0.6, only the latest version.


(grid, z) = read_esri_ascii(hs.content['thun_elevation.txt'], name='topographic__elevation') creates an array that can't be analyzed

When running the following piece of code:
(grid, z) = read_esri_ascii(hs.content['thun_elevation.txt'],
name='topographic__elevation')
It seems as though two variables are returned, one of which is a grid. Upon inspection, it seems that the grid is of type array, but we can't do any sort of iteration or slicing on grid.
The following pieces of code:
grid[0]
for n in grid:
    print n
list(grid)[0]
np.array(grid)[0]
All result in the following error:
/opt/conda/envs/python2/lib/python2.7/site-packages/landlab/field/grouped.pyc in __getitem__(self, group)
   864             return self._groups[group]
    865         except KeyError:
--> 866             raise GroupError(group)
<type 'str'>: (<type 'exceptions.TypeError'>, TypeError('__str__ returned non-string (type int)',))
Upon inspection of this error it appears that the object from which the grid is derived may have a function str(), that does not return a string.

@itaher1995 Please close and move to https://github.com/hydroshare/hydroshare-jupyterhub


MergeSort.cpp: Add Airbnb MergeSort Solution

This adds Airbnb MergeSort Solution which is solved using priority_queues.
Time Complexity:- O(Nlog(N)) where N is the total number of elements in all the lists.
Closes #282

@vivekcrux : Thanks for Contributing


support panoptic segmentation

Is it possible to support panoptic segmentation of ADE20K based on this repo?

This should be feasible, but currently I have only supported COCO's panoramic segmentation. I see that the official mmdetection does not currently support panoramic segmentation for ADE20K. It might be necessary to write a dataloader for it.


Ionic-Angular: ionicons do not load

Describe the bug
Having the following html fragment in a component:
<ion-icon name="add"></ion-icon>

The icon does not appear. There is an attempt to load the svg file, but it returns with a 404:
GET http://localhost:4200/svg/add.svg 404 (Not Found)

Trying to manually open the URL above causes the router to kick in and to redirect to the ** path.
In addition to that, when the application is built, there is no svg directory with the icon files anymore.
angular: 15.0.4
capacitor: 4.6.1
ionic: 6.4.1
ionicons: 6.0.4 (transitive)
nx: 15.4.1
nxext/capacitor: 15.2.0
nxext/ionic-angular: 15.1.0
To Reproduce
https://github.com/whydoievenneedthis/ionicons-not-loading
Expected behavior
The svg file is served correctly and the icon appears in the browser.
Additional context
Last time I know this was working, it was with Angular 13 and the old nxtend plugin (I only have two icons in some rarely visited pages, so it took me a while to notice this).
Downgrading to angular 14, nx 14, nxext 14 and ionicons 5 did not solve the issue.

@whydoievenneedthis In your project.json file, there should an assets path to the folder node_modules/ionicons/dist/ionicons/svg, i.e.,
...
  "targets": {
      "build": {
          "executor": "@angular-devkit/build-angular:browser",
          "outputs": ["{options.outputPath}"],
          "options": {
              ...
              "assets": [
                 ...,
                  {
                      "glob": "**/*.svg",
                      "input": "node_modules/ionicons/dist/ionicons/svg",
                      "output": "./svg"
                  }
              ],
...

Can you verify you have this configuration and that your node_modules folder contains the ionicons/dist/ionicons/svg path to the specific icons you would like to load?

@SimonCockx the indicated line is present in the project.json file:
https://github.com/whydoievenneedthis/ionicons-not-loading/blob/main/apps/my-app/project.json#L21
However the node_modules folder does not have the dependency in it. It only appears under<EMAIL_ADDRESS>suggesting that the issue is not related to the component versions but to the configuration vs. the package manager used.
I would have to add ionicons as an explicit dependency in order to force it to appear directly under node_modules.

@whydoievenneedthis I guess this is by design of pnpm. It enforces strict dependency resolution, so you cannot access transitive dependencies without explicitly stating them as a dependency of your project. (see https://pnpm.io/next/npmrc#shamefully-hoist)
Since you are directly depending on ionicons, I would say it is fair that you should also directly state ionicons as a dependency.
I'm not sure whether having to do this manually is desired or not. Could we automatically add ionicons as an explicit dependency to package.json? At what point should we do so? What if you don't need it?
@DominikPieper what do you think?

@SimonCockx mhh not sure yet. I’ll do Sonne experiments cause I usually don’t use pnpm that often. I plan to do some stuff around the ionic packages the next time


Implement collection sync service [BLOCKED]

See the proof of concept work sync service in SHROOM as a guide for implementing a collection sync service.
This is blocked until collections are fully implemented in H3.

This is done.


Way to serialise back to text ?

Hi, I am just wondering if there is any way to serialize the parsed data back to text.

My gut feeling is that this is one of those hard problems like ambiguity detection (NP-complete maybe?), but @Hardmath123 can probably elaborate.

No, NP-completeness has nothing to do with this.

If you used postprocessors, all hope is lost.
If you didn't use any postprocessors, just flatten the list-of-list structure nearley returns by default.

That being said, why would you ever want to do that kind of thing? If you use a parser, you already have the text.

@Hardmath123 this is for 2 ways editing. For example: an HTML parser generates a DOM. If you change an attribute within the HTML the DOM should reflect the change as well. Conversely, if I change the DOM, I wish the HTML to be updated accordingly. This is what a dom.asHTML() function should do. BTW, writing a serializer should be more simple than a parser.

Yes, but it's not easy for nearley to serialize back automatically, because postprocessors mangle the data. For the use-case you described, you should almost certainly write your own custom serializer. As you said, it's simpler than a parser, and it gives you a lot more flexibility than a built-in serializer ever could.


ResolveAssemblyReference Exception, EmulateFileIOPermissionChecks

msbuild ver 16.5.0+d4cbfca49, installed with visual studio 2019 installer.
after install vs2019, when build some project will fail, cause exception ResolveAssemblyReference
System.AggregateException: 发生一个或多个错误。 ---> System.NotSupportedException: 不支持给定路径的格式。
在 System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)
在 System.IO.FileSystemEnumerableIterator1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler1 resultHandler, Boolean checkHost)
在 System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
在 Microsoft.Build.Tasks.AssemblyFoldersExCache.<>c__DisplayClass3_0.<.ctor>b__0(AssemblyFoldersExInfo assemblyFolder)
after use dnSpy debug msbuild, set capture all exception, i find the problem when read directory from registry, the old uninstalled vs2010 path. the path start with "-:" cause the exception.
regkey: HKLM\Software\Microsoft.NETFramework\v4.0.30319\AssemblyFoldersEx\Public Assemblies v10.0
regvalue: @"-:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE\PublicAssemblies"
but i can't find that regkey in Regedit, i don't known where the value read out.
temp solution, in the below read function, contain a EnviromentVariable Test, can bypass the Folder Check.
internal AssemblyFoldersExCache(AssemblyFoldersEx assemblyFoldersEx, FileExists fileExists)
....
...
if (Environment.GetEnvironmentVariable("MSBUILDDISABLEASSEMBLYFOLDERSEXCACHE") != null)
{
this._useOriginalFileExists = true;
return;
}
after set the EnvironmentVariable MSBUILDDISABLEASSEMBLYFOLDERSEXCACHE=2, then i can build the project successful.
but i think that's a problem, so a i open this issuse.
i have tried use dotNet_TotalUninstaller to uninstall all VS product, and reinstall VS2019, nothing work.
i think may be, need check path or try catch this exception, not throw it. as developer don't known how to do with this exception. and the exception does not show enough exception detail.

NOTE:
1、temp solution, set the EnvironmentVariable MSBUILDDISABLEASSEMBLYFOLDERSEXCACHE=1
2、debug msbuild，set the EnvironmentVariable MSBUILDDEBUGONSTART=2, start msbuild, it will wait for debugger attach. BUT i think the easyest way is to use dnSpy, ;)

i can't find that regkey in Regedit

Did you look in the 32-bit registry under WOW6432Node?
If it's set there, MSBuild is failing due to corrupt state on your machine which I wouldn't treat as a bug.

@rainersigwald YES, i fogot to look in WOW6432Node.
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft.NETFramework\v4.0.30319\AssemblyFoldersEx\Public Assemblies v10.0
-:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE\PublicAssemblies\
I have reinstall the system, so let it go. tks.


port.close error: "asyncClose is not defined"

Summary of Problem
While closing port using port.close() - error "asyncClose is not defined" is returned and port stays open.
What are possible reasons for this error?

I'm trying to close previously opened port
Error "asyncClose is not defined" is generated and port remains open
port should be closed

Versions, Operating System and Hardware

<EMAIL_ADDRESS>Electron 5.0.2 with NodeJS v. 12.0
Windows 10 Pro

After tracing in debugger I realized that question "What are possible reasons for this error?" is rather rhetoric one. As SerialPort.close calls async function close() in win32.js this function returns asyncClose(fd) at line 63. I cannot find asyncClose() to be defined anywhere. Nevertheless super.close() at line 60 of win32.js makes port closed - I just cannot reopen it while receiving error "Access denied". Possibly I'm doing something not OK - I'll investigate more.
I checked everything I could. Port opens properly, I can read and write without any problems but when attempting to close it shows above mentioned error. Subsequently this port cannot be neither closed ("Port is not open") nor open ("Access denied").
It would be useful to have it working properly for the purpose of releasing the port and passing it to other application running on the same system - right now it's not possible.

Same issue here.

<EMAIL_ADDRESS>Node.js v10
Windows 10

Thanks. I'll try new version and let you know the results.

Issue is still present in 8.0.2.  Think it's because the following is missing from the top of bindings/lib/win32.js:
const asyncClose = promisify(binding.close)


swagger and openapi fields cannot be present in the same Swagger or OpenAPI definition

Issue
By default, specs are set as swagger:2.0. To use openapi instead, I followed the documentation:
 swaggerAutogen({openapi:'3.0.0'})(outputFile, endpointsFiles, specs).then(()=>{
    app.use("/api-docs", swaggerUI.serve, swaggerUI.setup(require('./swagger-output.json')));
})

However, it renders both Swagger and OpenApi which causes the following problem:

If I don't pass openapi args, the following code block in module does run, but it still adds swagger 2.0 along with openapi
        if (options.openapi && utils.isNumeric(options.openapi.replaceAll('.', ''))) {
            objDoc.openapi = options.openapi;
        } else {
            objDoc.swagger = '2.0';
        }

I was passing options to swaggerJSDoc and the output spec to this library. swaggerJSDoc added the swagger 2.0 attribute. After skipping it, now it works.
const specs = swaggerJsdoc(options); //removed


Rename Tabasco to ProxyAttestationServer

Documentation, comments, variable names, field names, etc. all renamed.  Tabasco as a name is no more...

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: 374196b80ec7c7836e737a47177a60f8cbaf6859
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: edfc8779959912a633465b60de1373dc227311eb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: e1e9f6d385772b840e702bbbb15d865ea62b60bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

How do the changes to the policy fields here affect #80?

How do the changes to the policy fields here affect #80?

One change will have to be rebased on top of the other, depending on which is ready to merge into main first.

My understanding was the src/custom.rs in Colima was autogenerated as part of the build process.  Is that true?  It's under version control which would imply that this is not autogenerated afresh on every build.  Further, despite having edited colima.proto correctly in the initial set of pushes for this changeset, the custom.rs file was not being updated, and I've just had to do it manually.

Actually, ignore that, I've just worked out I was mixing up two different files in colima!

For future viewers: src/custom.rs is not auto-generated. It contains convenience functions for handling the protobuf stuff. Hand written.

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: c5ccd89963706cb412e8dfb6586cbb41137e21a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: c5ccd89963706cb412e8dfb6586cbb41137e21a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: ca7c2f98b47760072ee3fce929e5c8e30b4a6a77
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: d4ca6db6b1ad79e16fe06eb5d76439b04d9575a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: a4615857b956df7122e52c9ecae161c355cf3229
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: 50862a9074c88dfdd6805100fa0f17872ca43522
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: Veracruz
Commit ID: 8ccc29af471d4fcc553466dc880eaf5d7f0b501e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This is now finally ready for review.

+1+1=+1, merging


docs: fix typo concate -> concat

I didn't change it in docs/modules.html, I assume it gets generated automatically...somewhere. When I ran docs:build around 200 files changed so that didn't see mright either

Thanks! docs:build updates links to source code in every file. That's why you get a bunch of changes.


 Take inspiration and help from flare's giveaway cog and neuro assassin's targeter

#7 did it within 24 hours woohoo.


Bugfix:362_Make PetMe Icon at the footer scroll the page to the top

Wrapped the img tag in a link tag and referenced it to the top of the page...

reviewed.


Feature: Allow setting num_batch and make basic parameters like this available in the chat UI

Is your feature request related to a problem? Please describe.
num_batch can greatly impact inference performance at the cost of more VRAM usage.
Depending on the task, it can be beneficial to sacrifice say some context size if it allows you to increase num_batch or vice versa.
e.g:

Fast responses: num_batch: 2048, num_ctx: 8192
Larger context, but a bit slower: num_batch: 512, num_ctx 32768
Middleground: num_batch: 1024, num_ctx: 16384

Describe the solution you'd like
It would be great if you could set num_batch in Open WebUI.
It would also be really useful if basic parameters such as num_ctx, num_batch, temp/top, num_keep etc... were available in the chat interface without having to go into settings -> advanced and tweak them there each time.
Describe alternatives you've considered
Right now I'm having to create several copies of models with the num_ctx/num_batch in their name in order to quickly switch between settings. It works, but it's painful.

Great suggestion, PR welcome!

PR incoming :)

@sammcj

@tjbck


Move CSV files to assets folder + primitive permissions system

Hello!
While thinking about the authentication system, I had the idea to create a permissions system, since there will be multiple roles (Administrator, Teacher, Student...). Basically, my idea is: there are actions (permissions, mostly CRUD operations) and resources (assignments, tests, grades...), and each role in the hierarchy will be given a set of permissions. This way, is possible to allow say, a teacher grade the tests/assignments of their own classes, but not the classes of other teachers, as well as students will not be able to read everyone's grades, just their own.

Currently I have only created some data structures in order to organize the permissions. I will incorporate it into the system and add more features over time.


TypeError: Passing a set as an indexer is not supported. Use a list instead. Occured in Chapter08.

I faced this issue when I was running 01-Forecasting with ML.ipynb file, the following error occurred when I executed the Sample Household block.
The error originated from src/forecasting/ml_forecasting.py --- line 153
df.loc[:, set(feature_list + self.index_cols)]
The reason of this error is that sets are not hashable and, therefore, cannot be used as an index.
so, I replace that line with the following:
df.loc[:, list(set(feature_list + self.index_cols))]
and it worked.

Thanks for pointing it out.. Will change it in the code

Hi @AhmedGillani, I am closing this issue for now, please reopen if this issue persists.


Fix infinite loop on EOF in the command line debugger

When using the command line debugger (godot -d) on Unix systems, when entering an EOF (ctrl+D), the debugger enters an infinite loop.
Adding a check for EOF in the debugger loop exits the debugger when EOF is entered.
Fixes #50170.

Thanks! And congrats for your first merged Godot contribution :tada:


Please include warning that Azure Artifacts does not support snupkg

Azure Artifacts does not support snupkg according to https://github.com/dotnet/sourcelink/blob/master/README.md and multiple other pages online.
Given that there was no mention of this at all on the documentation page I was quite disappointed. I would have expected a note on this page instead of finding out about it on another page after following all instructions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22767e96-d56f-aa81-f1ca-17e256ed617e
Version Independent ID: d7cdc676-2705-3cb1-bcd6-d1637460d5c7
Content: How to publish NuGet symbol packages using the new symbol package format '.snupkg'
Content Source: docs/create-packages/Symbol-Packages-snupkg.md
Product: nuget
Technology: ****
GitHub Login: @cristinamanu
Microsoft Alias: cristinamanu

This is not completed @cristinamanum
#please-reopen

It is really disappointing that Azure Devops Artifacts still does not support snupkg.
It is not really a new standard so what is going on Microsoft?

Any update on this?
It's really sad to see this platform being neglected so badly.

Can we have any news?

Hey all,
Please file Azure DevOps feedback to ask for that support.
https://learn.microsoft.com/en-us/azure/devops/user-guide/provide-feedback?view=azure-devops and https://developercommunity.visualstudio.com/AzureDevOps?

@nkolev92 I opened this issue to ask for documentation pointing out that this is not supported so that people don't lose time on it.
Can you please reopen this issue? Or did you really mean to say "we're not going to document this"?

What's unusual is that Microsoft's own products don't support this, and that enough people are asking about this everywhere, yet Microsoft's answer is "Please post here"

This issue was filled on Jan 19, 2021, on Aug 17, 2021, the following note was added: https://github.com/NuGet/docs.microsoft.com-nuget/commit/94e47116a87a67e83ad213ce4bc6bcc73aad6d11, so the current do mention that.
Regarding the feature ask, you can follow that on https://developercommunity.visualstudio.com/t/add-snupkg-support-to-azure-devops-artifacts/657354.


IPC between Python and Node

I wanted to share my thoughts on IPC between Python and Node. It could be beneficial now when solving challenges consecutively or if a polyfill ever becomes necessary. As of right now, if Cloudflare's Scrape Shield is bypassed on the first attempt, usually you won't need node again for around 30 minutes. Sharing anyway...
You don't have to use base64 to safely send code to node to run the VM which a similar approach could be taken that isn't as complicated as what I'm doing here. There are other advantages, find them in the code or reason it for yourselves.
Reading from the stdout of Node in Python will have to be non-blocking to poll. This articles details a few ways of doing it: http://eyalarubas.com/python-subproc-nonblock.html
Python's end (not completely developed):
from os import path
from subprocess import Popen, PIPE
# Ideally, this would be done on a separate thread, process inherits stderr
filename = path.join(path.dirname(__file__), 'ipc.js')
# -r means require and execute the JS setup code
process = Popen(['node', '-r', filename], stdout=PIPE, stdin=PIPE)
# Process runs until idle for some time period before being closed
# I would do that from Node's end and check the process in Python
# It can be started back up when needed
code = 'console.log("foobar")'
process.stdin.write('{}\0{}'.format(len(code), code))
# Python reads the answer or the error string
# Should mirror what the other end is doing but check if ouput === error

Node's end (ipc.js):
const vm = require('vm');

// The polyfill code could be a custom bundle of core-js
// Using String.prototype.italics as an example
const polyfillCode = 'String.prototype.italics = function(str) {return "<i>" + this + "</i>";};';
const polyfill = new vm.Script(polyfillCode, {
  filename: 'polyfill.js'
});

let buffer = '';
let remaining = 0;

function send(msg) {
  process.stdout.write(msg.length + '\0' + msg);
}

// Setup the IPC - uses a null byte as the delimiter
process.stdin.setRawMode(true);
process.stdin.setEncoding('utf-8');
process.stdin.on('data', function (data) {
  buffer += data;

  const index = buffer.indexOf('\0');

  if (remaining === -1 && index === -1) {
    // Waiting on the rest of the data that tells us the code size
    return;
  }

  // Check whether we're reading the code size or actual code
  if (remaining === -1) {
    // We're reading the code size
    const size = parseInt(buffer.substr(0, index));

    if (isNaN(size)) {
      // Note: console.error writes to stderr
      console.error('Invalid code size:', buffer);
      // Drop the buffer and send error
      buffer = '';
      send('error');
    }
    else {
      // Everything after the null byte
      const code = buffer.substr(index + 1);
      // If we got all of the code in one go
      if (size === code.length) {
        // Reset the buffer, run code
        buffer = '';
        run(code);
      }
      else {
        // We're waiting for more code, set the buffer
        remaining = size;
        buffer = code;
      }
    }
  }
  else if (buffer.length === remaining) {
    // We have all of the actual code
    const code = buffer;

    // Reset...
    remaining = -1;
    buffer = '';

    run(code);
  }
  else if (buffer.length > remaining) {
    // We were sent the wrong amount of data
    console.error('Invalid data amount:', buffer);
    // Reset...
    remaining = -1;
    buffer = '';

    send('error');
  }
});

function run(code) {
  // Create a new context so theres no chance of XSS
  const context = vm.createContext(void 0, {
    codeGeneration: { string: true, wasm: false }
  });

  // Run the pre-compiled polyfill
  polyfill.runInContext(context);

  // Run the challenge code
  let answer;

  try {
    answer = vm.runInContext(code, context, {
      filename: 'iuam-challenge.js',
      timeout: 5000
    });
  } catch (exception) {
    console.error(exception);
    return send('error');
  }

  send(answer);
}

Would be cool if node was a daemon ;P

Yeh, you could do away with a lot of state management by just putting a JSON.parse call in a try..catch but then you lose the advantage of not having to worry about quotes, spaces, etc.

@VeNoMouS While writing this, I realized that it's better just to use Popen and write to node's stdin if you're going to send arbitrary code, you still need a tiny amount of code on node's side which you can put in separate file and load with the -r flag. Let me know if you'd like me to share a snippet on how exactly that would be done.

@VeNoMouS - tested on Python 2 and 3
from subprocess import Popen, PIPE

challenge = b'var a = {}; a.value = "foobar";'

ipc = 'var challenge = "";' \
      'process.stdin.setEncoding("utf-8");' \
      'process.stdin.on("readable", function () {' \
      '  while (chunk = process.stdin.read()) {' \
      '    challenge += chunk;' \
      '  }' \
      '});' \
      'process.stdin.on("end", function () {' \
      '  var answer = require("vm").runInNewContext(challenge, void 0);' \
      '  process.stdout.write(String(answer));' \
      '});'

process = Popen(['node', '-e', ipc], stdout=PIPE, stdin=PIPE)
answer = process.communicate(input=challenge)[0]
print(answer)

Actually, reading (node as daemon)'s stdout in python can work in a blocking way if you pad node's output to some known length, say 20, that would be good enough.

I also got Chakra working, and its faster than node by ~25ms, when you get on discord you can see the test times.

Modified nodejs.py: https://gist.github.com/pro-src/c1d890e81e1de128333f674417582138


@doc decorator should be able to accept string as a second parameter

Currently, @doc decorator accepts an instance as a second parameter
Let's say I have two models with a slightly different documentation prose:
@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueModified event.")
model AppConfigurationKeyValueModifiedEventData {
  @doc("The key used to identify the key-value that was modified.")
  key?: string;
  @doc("The label, if any, used to identify the key-value that was modified.")
  label?: string;
}

@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueDeleted event.")
model AppConfigurationKeyValueDeletedEventData {
  @doc("The key used to identify the key-value that was deleted.")
  key?: string;
  @doc("The label, if any, used to identify the key-value that was deleted.")
  label?: string;
}

currently a viable solution is having an object (for instance, an enum) and passing it as a second parameter to the decorator
enum AppConfigurationEventTypes {
  modified;
  deleted;
}

model AppConfigurationBase<TResource> {
  @doc("The key used to identify the key-value that was {name}.", TResource)
  key?: string;
  @doc("The label, if any, used to identify the key-value that was {name}.", TResource)
  label?: string;
}
@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueModified event.")
model AppConfigurationKeyValueModifiedEventData is AppConfigurationBase<AppConfigurationEventTypes.modified>;

@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueDeleted event.")
model AppConfigurationKeyValueDeletedEventData is AppConfigurationBase<AppConfigurationEventTypes.deleted>;

Expected Behavior
However, ideally passing a string directly should suffice - like below
model AppConfigurationBase<TResource> {
  @doc("The key used to identify the key-value that was {name}.", TResource)
  key?: string;
  @doc("The label, if any, used to identify the key-value that was {name}.", TResource)
  label?: string;
}
@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueModified event.")
model AppConfigurationKeyValueModifiedEventData is AppConfigurationBase<"modified">;

@doc("Schema of the Data property of an EventGridEvent for a Microsoft.AppConfiguration.KeyValueDeleted event.")
model AppConfigurationKeyValueDeletedEventData is AppConfigurationBase<"deleted">;

priority: 2 (shorthand for looking at what we want to allow in the format string)

Closing as duplicate of #932


Angular 9 Support

Describe the desired behavior
Our components do not work in a project that uses angular v9.
This is an excerpt from the angular changelogs:
Deprecations
Importing directly from the root @angular/material entry-point is deprecated. You should instead import from specific entry-points, e.g. @angular/material/button. This aligns with @angular/cdk, makes clear where symbols originate, and helps safeguard against including unused code. The deprecated style will be removed in Angular v9.
Describe the current behavior
Mat-Divider is not recognized in the Hero Component because the root import has been deprecated.  Angular 9 will not load our component library.
Is this request related to a current issue?
No
Additional Context
Add any other context or screenshots about the feature request here.

Closed via #47


Modify SDK build Cocoapods inclusion to use frameworks instead of libraries

Description

Provide details of the change, and generalize the change in the PR title above.

Upcoming release 9.0.0 will require that Cocoapods be included as frameworks, not as a libraries. This change modifies the existing CMake build to be able to build via frameworks. This requires adding a few different locations to the include paths, as the paths are different when using frameworks (and in a few cases e.g. GTMSesionFetcher, headers are no longer in the public location).

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration test and cpp packaging runs will both be verified.

Type of Change
Place an x the applicable box:

[ ] Bug fix. Add the issue # below if applicable.
[ ] New feature. A non-breaking change which adds functionality.
[X] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@dconeybe The Windows desktop build still seems broken: https://github.com/firebase/firebase-cpp-sdk/runs/6083486670?check_suite_focus=true
Error: Command '['D:\a\firebase-cpp-sdk\firebase-cpp-sdk\ta\auth\it\bin\external\src\firestore-build\Firestore\Protos\pyvenv\FirestoreProtos\Scripts\python3.exe', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status<PHONE_NUMBER>.

@sunmou99 The build_testapps.py script seems to be messing something up about adding the frameworks to the tvOS builds now, with this Cocoapods change. I tried looking into what might be happening but I haven't been able to figure it out. Can you try to reproduce the issue on this branch?

@sunmou99 The build_testapps.py script seems to be messing something up about adding the frameworks to the tvOS builds now, with this Cocoapods change. I tried looking into what might be happening but I haven't been able to figure it out. Can you try to reproduce the issue on this branch?

tvOS platform shouldn't contain CoreTelephony:
https://github.com/google/GoogleDataTransport/search?q=coretelephony
But, we included it anyway.
error: CoreTelephony is not available when building for tvOS Simulator. (in target 'GoogleDataTransport-iOS' from project 'Pods')

@sunmou99 The build_testapps.py script seems to be messing something up about adding the frameworks to the tvOS builds now, with this Cocoapods change. I tried looking into what might be happening but I haven't been able to figure it out. Can you try to reproduce the issue on this branch?

tvOS platform shouldn't contain CoreTelephony: https://github.com/google/GoogleDataTransport/search?q=coretelephony But, we included it anyway. error: CoreTelephony is not available when building for tvOS Simulator. (in target 'GoogleDataTransport-iOS' from project 'Pods')
We could change the Podfile and remove the unwanted target it before we build the testapp

After some more research, it seems that this is a known issue with command-line xcodebuild using the new build system. Unfortunately, we can't use the legacy build system as it doesn't support .xcframeworks. So it seems like the best workaround is to have platform-specific Podfiles (edited on the fly by the script).
I am testing one more possible fix, setting the linkage to static - this worked one time I tested it, though it still printed some warnings.

Everything looks good except an unrelated Firestore error, gonna go ahead and merge this.


Smurf alert

Display potential smurf alert inline with rank (blue icon with rollover text)

Excessive feature? Migrating away from Stratz API could break it anyway.


Merge 2.3 fixes to master

cc @brian-brazil @krasi-georgiev
The fix removing the security headers already exists in master as #4258 (#4259 on the release-2.3 branch) but reading the Wiki, I understand that there's nothing special to do about it.

Thanks!
All this branch messing is a bit confusing.

Wait, did you squash these commits @brian-brazil?? This rewrote the history, instead of merging the branch into master. This completely defeats the purpose of having branches.

But rebasing rewrites the history. This must not be done when merging release branches back into master, as that will duplicate every commit.

If we want to avoid divergent branches, maybe we should work only on master.

We have the release branch concept established for years. Following it would remove the need for any "no more features can be merged" moratoriums and provide a clean and readable diff and history between releases.


Migrate athena_partition_refresh lambda function to tf_lambda module

related to: #1090
Background
We will keep athena_partition_refresh lambda function forverrrrrrrr. So we need to migrate the function to use tf_lambda module to take advantage of code reuse and predefined alarms.
Desired Change
Migrate the function to use terraform/module/tf_lambda

complete with #1217


[$250] Expense - In archived workspace, tapping receipt replace directs to hmm not here page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Pre-Condition:

Create a expense with receipt in workspace chat

Delete the workspace

Launch app

Open archived workspace chat

Open the expense -- receipt

Tap 3 dots -- replace

Expected Result:
In archived workspace, tapping receipt replace option if not allowed must not be shown or otherwise user must be allowed to replace but page must not direct to hmm not here
Actual Result:
In archived workspace, tapping receipt replace directs to hmm not here page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/c84ac075-0bbf-4aff-9fbf-702aa56d6e9a
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840979900027304765
Upwork Job ID:<PHONE_NUMBER>027304765
Last Price Increase: 2024-10-01

Issue OwnerCurrent Issue Owner: @suneox

@adelekennedy  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
In archived workspace, tapping receipt replace directs to hmm not here page.
What is the root cause of that problem?
We are not implementing a check for archived policy reports in canEditFieldOfMoneyRequest.
https://github.com/Expensify/App/blob/71db3f19691069182447b6b1b9fff62ec93be86c/src/libs/ReportUtils.ts#L3062-L3122
What changes do you think we should make in order to solve the problem?

We should hide the edit and delete options when the workspace is archived.
Sudo code:
!isArchivedRoom(moneyRequestReport, getReportNameValuePairs(moneyRequestReport?.reportID))

What alternative solutions did you explore? (Optional)

reproduced

Thanks for all the proposals.
Currently, we also manage editable for another fields at MoneyRequestView so @Krishna2323 primary proposal with the solution to control the read-only prop of ReportActionItemImage atMoneyRequestView is LGTM.
🎀 👀 🎀 C+ reviewed

Thanks for the bump, assigning @Krishna2323 🚀

Checklist

[x] [@suneox] The PR that introduced the bug has been identified. Link to the PR: https://github.com/abzokhattab/App/pull/56
[x] [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment
[x] [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] [@suneox] Determine if we should create a regression test for this bug: N/A
[x] [@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

Payouts due:

[ ] Contributor: $250 @Krishna2323 (Upwork)
[ ] Reviewer: $250 @suneox (Upwork)


[Request] Command to manually update the commitment fee rate

Problem: During a fee event, users might want to increase the fees of the commitment just in case they need to close during the fees at the time.
Proposed Solution:

User sends a command to update the fee to a certain sat/byte or fee/kweight
Partner responds
If successful, commitment fees are increased.

This will allow users to increase or decrease the fees on the commitment.

Some additional context:
During a bilateral, mutual close, where both peers agree and are able to communiate, the fee can be set in a closing_signed protocol message: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#closing-negotiation-closing_signed
If, however, a channel should be closed without relying on the peer (force close, unilateral close), the fee is determined by the last update_fee message that has been acknowledged: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#updating-fees-update_fee and https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#rationale-10
This issue asks for a manual command that can be used to set/increase the fee rate (by sending an update_fee message to the peer), so that this value can be used without relying on the peer (again).
UpdateFee in lnd: https://github.com/lightningnetwork/lnd/blob/master/lnwire/update_fee.go
An update_fee message is sent periodically based on a timer (updateFeeTimer):
https://github.com/lightningnetwork/lnd/blob/master/htlcswitch/link.go#L1087
https://github.com/lightningnetwork/lnd/blob/master/htlcswitch/link.go#L496

Note that the fee may be adjusted (down) again in case the logic cited above is triggered again. As an example, if the (missing) command is used to set the fee to 1000 (whatever the unit may be), a few seconds later the updateFeeTimer may fire, compare 1000 to the network fee value of 500, determine that 1000 is way above 500, and adjust the fee back down to 500. This might not be in the best interest of the human who manually used the command to set the fee to 1000.
How should manual efforts interact with the timed updates? Is there a cooldown phase? Should the timer be disabled for a while? What about restarts (is this information persisted)?

Maybe it's a better idea to adjust the automated process so that no manual adjustments are necessary?

So the current direction we're going in here (post anchor commitments) is just do clamp at say 20 sat/byte (never use a value above that), and then rely on CPFP'ing the anchor output to let users modify the fee. At first they can use BumpFee to do so, but eventually it'll be dynamic to try and sure that the commitment gets into the chain in time if it has any active HTLCs.

Based on the above, I think we can close this since w/ anchors you can bump the fee rate after the fact, and also use the config to set a high water mark.


Added Proteced Property for the RenderHandle of the BlazorComponent

What: Added a protected property to BlazorComponent that exposes the RenderHandle to sub-classes.
Why: This allows sub-classes to be instantiated individually with the ability to set the RenderHandle from the sub-class's IComponent.Init method, which prevents the BlazorComponent to not have the ability to be rendered when accessed as BlazorComponent.

Yes, I want to control instantiation of the sub-class of the component.  Any subclass that wants to be able to trigger a render on itself must have a reference to _renderHandle.  This is not possible without the Get part of the new property.  The Set part of the property allows a sub-class of BlazorLayoutComponent to instantiate the sub-class of BlazorComponent and assign it the RenderHandle that is local to the sub-class of the BlazorLayoutComponent.
Why do I want to do this?  I am creating a navigation library for Blazor that directly models that of UWP, Android and iOS.  I believe that the Url based navigation is a huge hindrance to the flexibility of Blazor.  Also, this would break us free from the tyranny of the browser's back button as we can use JavaScript to disable it and force navigation to be controlled within the app.  This is desirable for embedding applications with Blazor such as Electron or custom browsers so that you can completely remove the normal browser UI elements and make a completely self-contained application environment.
I am willing to use other mechanisms to perform the instantiation of a sub-class of BlazorComponent that can still trigger it's own render.

BTW, wrapping _renderHandle breaks encapsulation only in so much as _renderHandle should have been a protected property or field to begin with as it should be reasonable that any sub-class of BlazorComponent should have the ability to trigger it's own Render and other functionality requiring the _renderHandle.  I have the code for my Navigation framework at home.  I will put up a NuGet project for it today and post a link here to the pertinent code.

      My best guess is that maybe you're hoping to instantiate the components directly and then somehow tie them into the rendering process. If so, this is not a desirable pattern, as it would not match up with other aspects of the component lifecycle such as DI and disposal, or of course future changes to the lifecycle.

I've been working on performing the draw via other methods and I believe I'm on to an alternative.
Having said that, I think there's a strong argument for a blazor component factory that could take in a context, instantiate from DI, and then apply that context to the component, giving the initialized component back to the caller for manipulation.  I'm working on something similar and may focus more effort in that direction.

OK, thanks for the update. I'll close this then, but please let us know how you get on with your alternate approach.


Motion Tracker stealing my ears for it self

Just wanted to say I love the Mod, it works so well with it only showing things that give of vibrations and only if they move great job.
My Problem is that when I use it I hear everything from the trackers point of view.
For example when Im not holding it I either hear from my left or right ear.
And When I drop it and go away I hear myself walk away and than I hear nothing.

This is bizarre. I can't imagine why it would be happening. Does this happen on multiplayer, single player, or both? Does it happen every time?

I confirm, I encountered the same type of problem. Basically all the audio is played by the person holding the motion tracker, if the person is not holding it the audio is played in the last position in which the motion tracker was held.

Are you both using version 0.1.3? I'll try to figure this out tomorrow

yes, regardless the problem is present in all versions of the mod.

This is hopefully fixed in v0.1.4. Can y'all update and let me know?

It's still buggy

I tested the latest version of the mod (1.0.0) and it seems that the bug is fixed. I only tried in singleplayer but I think the issue can be considered solved.

Thanks for the confirmation! I'll close this issue.


Some API are deprecated but no replacement was found

when upgrading webpack to version 5.73.0 and webpack-dev-server to version 4.9.2. For example: 1、"devServer.use is not a function"，2、Invalid options object. Dev Server has been initialized using an options object that does not match the API schema.

options has an unknown property 'clientLogLevel' / 'contentBase' / 'publicPath' / 'quiet' / 'watchOptions'.I hope to find some way to replace but no documentation.

Please read the migration guide for webpack-dev-server v4 here:
https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md#migration-guide

Oh thanks a lot, I've been searching the webpack documentation and haven't been able to find the answer

Please read the migration guide for webpack-dev-server v4 here:

Oh thanks a lot, I've been searching the webpack documentation and haven't been able to find the answer


[Feature request] Delete manually added collaborators

New Feature
Be able to delete on sync, manually added collaborators to the repositories,
Maybe some kind of strict mode to be able to select this new behavior.
Regards!

From my point of view - strict mode switcher will be extremely helpful


Cannot use two infinite scroll pagination in one page in cakephp

When I try to use 2 infinite scrolls in cakephp , using 2 pagintions in controller function, it is taking same page count for both paginations and ignoring rest posts' data.

Thank you for reporting this issue. I'm sorry to see you're having trouble with Infinite Scroll. Could you provide a live URL, or even better a reduced test case? See Submitting Issues in the contributing guidelines.

Login url:- http://syscomprojects.com/hundred/index.php
Username:- tester Password:- 123456
After login:- Check this url :- http://syscomprojects.com/hundred/index.php/logins/timeline
Here , there are 19 wish posts and 18 people posts , both can be seen on click of wish list and people list respectively. We have used infinite-scroll pagination for both with limit of 3 in both . So according to limit, there will be 7 pages for wish and 6 pages for people, but it is taking 6 pages for both and missing last post in wish (numbered 1) and also this is behaving unexpectedly in some pages. How can we use 2 paginations in one page with infinite scroll and not missing any data. Kindly suggest anything for this issue.