Update to ESLint 9

Is your feature request related to a problem?
The project currently uses ESLint 8. ESLint 8 is now EOL and unsupported.
Describe the solution you'd like
The project should use ESLint 9 for linting.
Describe alternatives you've considered
No response
Additional context
https://github.com/vercel/next.js/issues/64409 has been completed. It will be released as part of Next 15 soon. There is no info on support coming to Next 14, so this may require a major version update of Next at the same time.

Attempting to update right now results in peer dependency conflicts
❯ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>|| ^6.0.0 || ^7.0.0 || ^8.0.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/eslint-config-next
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   1 more (typescript-eslint)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   peer<EMAIL_ADDRESS>|| ^8.0.0-alpha.0" from<EMAIL_ADDRESS>npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev<EMAIL_ADDRESS>from the root project

We'll need to wait for full support to release.

When ready to update, these resources will be helpful

https://eslint.org/docs/latest/use/migrate-to-9.0.0
https://eslint.org/docs/latest/use/configure/migration-guide

Depends on https://github.com/github-community-projects/private-mirrors/pull/263


InvalidSignatureException Error

Hello ,
I am getting InvalidSignatureException while running the code. I have checked the credentials are ok along with log group name and stream name. do i need to configure policy at amazon console or is it a configuration issue.

Hi, can you please provide with a full stacktrace? and maybe a snippet of code on how you use the library.
Thanks!


Fix overwrite of file/folder of same name without warning

#18622, is the issue.
I also wanted to ask if should I change the return type of the, _try_move_item() to boolean.
Cause I currently don't see a way for creating a dialog box to ask to cancel operation and reverse all the previous move action of files/folders, in the current selection.
But if it's not supposed to be implemented that way then I think this commit is fine too.

You should use clang-format on document, if you using visual studio you could use this extension - https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.ClangFormat

Noted. Will fix it.

Changing it to boolean and implementing a dialog to ask whether to overwrite or cancel makes sense.

@swarnimarun Would you be willing to implement the dialog? Just getting an error if a file/folder with that name already exists seems bad if you actually want to overwrite those.

@mhilbrunner Yep, sort of fell out of the loop there. But I would be glad to do it. I thought of an alternative way for doing it too.
I will just ask if on would want to Overwrite the File or Skip it inside the _try_move function itself.
Will quickly cook up something.

@mhilbrunner Completed some work, currently I added a couple methods and a default argument to _move_operation_confirmed() to ensure maximum code re-usability although, probably I can put it in a separate function. But that might be too much clutter.
Other than that currently I ask between overwrite and cancel.

If it's all fine I might squash the commits.

Looks good. I'd change the message to "There is already a file or folder with the same name in this location." - or something similar. I think the already and this location are good to communicate a name conflict. I'd drop the parentheses, they IMO clutter the message. :)

Will do.

Done!

Now that Godot 3.1 has been released, we only plan to cherry-pick critical bug fixes to the 3.0 branch, unless there is very strong support in favor of a specific non-critical issue. Removing cherrypick label for 3.0.


Start moving grafana-specific runtime code to external templates

Because everything that is specific to some schemas shouldn't be in cog itself.
That includes knowledge and specific handling of some schema "variants", the registry, ...
This PR focuses on moving the runtime/registry code out of cog and into templates living in the Foundation SDK instead.
See also https://github.com/grafana/grafana-foundation-sdk/pull/492

Since this PR introduces a BC break in cog's config, the diff preview workflow fails to execute.
Here's a diff I generated manually (for v11.4.x):
diff --git a/go/go.mod b/go/go.mod
index 6b9d8a8b..c10f7067 100644
--- a/go/go.mod
+++ b/go/go.mod
@@ -1,4 +1,3 @@
 module github.com/grafana/grafana-foundation-sdk/go

-go 1.21
-
+go 1.21
\ No newline at end of file
diff --git a/java/build.gradle b/java/build.gradle
index 577265d1..9746df34 100644
--- a/java/build.gradle
+++ b/java/build.gradle
@@ -25,7 +25,6 @@ shadowJar {
 allprojects {
     version = rootProject.version
     apply plugin: "java"
-
     repositories {
         mavenCentral()
         maven {
@@ -50,7 +49,6 @@ tasks.withType(Javadoc).configureEach {
 }

 tasks.build.dependsOn shadowJar
-
 publishing {
     publications {
         mavenJava(MavenPublication) {
diff --git a/java/gradle.properties b/java/gradle.properties
index be91336f..aa841f6d 100644
--- a/java/gradle.properties
+++ b/java/gradle.properties
@@ -1 +1 @@
-grafanaFoundationSDKVersion=11.4.0-1733927393
+grafanaFoundationSDKVersion=11.4.0-1734004994
diff --git a/java/src/main/java/com/grafana/foundation/common/Constants.java b/java/src/main/java/com/grafana/foundation/common/Constants.java
index be9af52a..cc841b47 100644
--- a/java/src/main/java/com/grafana/foundation/common/Constants.java
+++ b/java/src/main/java/com/grafana/foundation/common/Constants.java
@@ -3,6 +3,6 @@
 package com.grafana.foundation.common;

 public class Constants {
-    public static final String TimeZoneBrowser = "browser";
     public static final String TimeZoneUtc = "utc";
+    public static final String TimeZoneBrowser = "browser";
 }
diff --git a/php/src/Cog/Panelcfg.php b/php/src/Cog/Panelcfg.php
deleted file mode 100644
index b9b14ca3..00000000
--- a/php/src/Cog/Panelcfg.php
+++ /dev/null
@@ -1,7 +0,0 @@
-<?php
-
-namespace Grafana\Foundation\Cog;
-
-interface Panelcfg
-{
-}
diff --git a/python/grafana_foundation_sdk/cog/plugins.py b/python/grafana_foundation_sdk/cog/plugins.py
index 8c4a5877..50edbc81 100644
--- a/python/grafana_foundation_sdk/cog/plugins.py
+++ b/python/grafana_foundation_sdk/cog/plugins.py
@@ -1,41 +1,42 @@
 # Code generated - EDITING IS FUTILE. DO NOT EDIT.

+
 from ..models import annotationslist
-from ..models import athena
-from ..models import azuremonitor
 from ..models import barchart
 from ..models import bargauge
-from ..models import bigquery
 from ..models import candlestick
 from ..models import canvas
-from ..models import cloudwatch
 from ..models import dashboardlist
 from ..models import datagrid
 from ..models import debug
-from ..models import elasticsearch
-from ..models import expr
 from ..models import gauge
 from ..models import geomap
-from ..models import googlecloudmonitoring
-from ..models import grafanapyroscope
 from ..models import heatmap
 from ..models import histogram
 from ..models import logs
-from ..models import loki
 from ..models import news
 from ..models import nodegraph
-from ..models import parca
 from ..models import piechart
-from ..models import prometheus
 from ..models import stat
 from ..models import statetimeline
 from ..models import statushistory
 from ..models import table
-from ..models import tempo
 from ..models import text
 from ..models import timeseries
 from ..models import trend
 from ..models import xychart
+from ..models import athena
+from ..models import azuremonitor
+from ..models import bigquery
+from ..models import cloudwatch
+from ..models import elasticsearch
+from ..models import expr
+from ..models import googlecloudmonitoring
+from ..models import grafanapyroscope
+from ..models import loki
+from ..models import parca
+from ..models import prometheus
+from ..models import tempo
 from . import runtime as cogruntime

diff --git a/python/pyproject.toml b/python/pyproject.toml
index c805833c..67cd7a61 100644
--- a/python/pyproject.toml
+++ b/python/pyproject.toml
@@ -13,7 +13,7 @@ keywords = [
     "traces",
     "metrics"
 ]
-version = "1733927393!11.4.0"
+version = "1734004994!11.4.0"
 dependencies = []
 requires-python = ">=3.11"
 classifiers = [
diff --git a/typescript/package.json b/typescript/package.json
index c51c9c9c..9351224e 100644
--- a/typescript/package.json
+++ b/typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grafana/grafana-foundation-sdk",
-  "version": "11.4.0-cogv0.0.x.1733927393",
+  "version": "11.4.0-cogv0.0.x.1734004994",
   "description": "A set of tools, types and libraries for building and manipulating Grafana objects.",
   "keywords": [
     "observability",

Note: there still are templates in the Java jenny that should be moved to the foundation SDK (they're fairly specific to panels/dataqueries). Moving them would require a more significant rework of the java jennies since classes that they define are referenced by the jennies themselves. We need to decouple that a bit more.


Descheduler | Log Data Evicted Pod Totals - Specific Strategy & Total of all Strategies

Is your feature request related to a problem? Please describe.
Evicted pods - While testing the descheduler in an EKS cluster running stateful pods with a node affinity of "preferredDuringSchedulingIgnoredDuringExecution"
We had the following evictions early in the log data for LowNodeUtilization which fine, so 2 pods evicted in this case:
I0211 15:05:03.181180       1 evictions.go:117] Evicted pod: "???-dev-mongodb-secondary-1" in namespace "???-dev" (LowNodeUtilization)
I0211 15:05:03.181497       1 lownodeutilization.go:302] Evicted pod: "???-dev-mongodb-secondary-1"
I0211 15:05:03.181525       1 lownodeutilization.go:315] updated node usage: api.ResourceThresholds{"cpu":54.85714285714286, "memory":44.85913009880116, "pods":17.142857142857142}
I0211 15:05:03.181602       1 lownodeutilization.go:267] 1 pods evicted from node "ip-??-??-8-78.us-west-2.compute.internal" with usage map[cpu:54.85714285714286 memory:44.85913009880116 pods:17.142857142857142]
I0211 15:05:03.181712       1 lownodeutilization.go:252] evicting pods from node "ip-??-??-91-42.us-west-2.compute.internal" with usage: api.ResourceThresholds{"cpu":66.28571428571429, "memory":59.13248967569243, "pods":17.142857142857142}
I0211 15:05:03.181922       1 lownodeutilization.go:255] allPods:6, nonRemovablePods:5, removablePods:1
I0211 15:05:03.181984       1 lownodeutilization.go:262] evicting pods based on priority, if they have same priority, they'll be evicted based on QoS tiers
I0211 15:05:03.182281       1 event.go:282] Event(v1.ObjectReference{Kind:"Pod", Namespace:"???-dev", Name:"???-dev-mongodb-secondary-1", UID:"5d7a3627-5740-466c-96f2-57a7ce0c8007", APIVersion:"v1", ResourceVersion:"2482168", FieldPath:""}): type: 'Normal' reason: 'Descheduled' pod evicted by sigs.k8s.io/descheduler (LowNodeUtilization)
I0211 15:05:03.200648       1 evictions.go:117] Evicted pod: "???-dev-mongodb-primary-0" in namespace "???-dev" (LowNodeUtilization)
I0211 15:05:03.200923       1 lownodeutilization.go:302] Evicted pod: "???-dev-mongodb-primary-0"
I0211 15:05:03.200969       1 lownodeutilization.go:315] updated node usage: api.ResourceThresholds{"cpu":49.14285714285715, "memory":40.78102736254651, "pods":14.285714285714285}
I0211 15:05:03.201056       1 lownodeutilization.go:267] 1 pods evicted from node "ip-??-??-91-42.us-west-2.compute.internal" with usage map[cpu:49.14285714285715 memory:40.78102736254651 pods:14.285714285714285]
I0211 15:05:03.201206       1 lownodeutilization.go:139] Total number of pods evicted: 2

But later in the log data we then see an eviction number mentioned for the strategy RemovePodsViolatingNodeAffinity, again it states that there are 2 evictions:
I0211 15:05:05.257202       1 node_affinity.go:70] Executing for nodeAffinityType: requiredDuringSchedulingIgnoredDuringExecution
I0211 15:05:05.257339       1 node_affinity.go:75] Processing node: "ip-??-??-15-12.us-west-2.compute.internal"
I0211 15:05:05.443666       1 request.go:581] Throttling request took 186.209023ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-15-12.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:05.451940       1 node_affinity.go:75] Processing node: "ip-??-??-28-65.us-west-2.compute.internal"
I0211 15:05:05.643616       1 request.go:581] Throttling request took 191.549799ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-28-65.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:05.654971       1 node.go:137] Pod name-env-ambassador-f859b7448-c8jnf fits on node ip-??-??-28-65.us-west-2.compute.internal
I0211 15:05:05.655004       1 node.go:137] Pod tiller-deploy-987c5d4b4-z9gnh fits on node ip-??-??-28-65.us-west-2.compute.internal
I0211 15:05:05.655059       1 node.go:137] Pod tiller-deploy-7848bd544b-nb4sf fits on node ip-??-??-28-65.us-west-2.compute.internal
I0211 15:05:05.655404       1 node.go:137] Pod tiller-deploy-5686b45c86-6zbzq fits on node ip-??-??-28-65.us-west-2.compute.internal
I0211 15:05:05.655431       1 node_affinity.go:75] Processing node: "ip-??-??-32-197.us-west-2.compute.internal"
I0211 15:05:05.843622       1 request.go:581] Throttling request took 188.067107ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-32-197.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:05.851515       1 node_affinity.go:75] Processing node: "ip-??-??-38-203.us-west-2.compute.internal"
I0211 15:05:06.043641       1 request.go:581] Throttling request took 191.968145ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-38-203.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:06.056948       1 node.go:137] Pod name-env-ambassador-f859b7448-99kfh fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057351       1 node.go:137] Pod name-env-ambassador-redis-88fcd86d8-5vfmh fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057472       1 node.go:137] Pod name-env-mongodb-backup-mgob-0 fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057562       1 node.go:137] Pod name-env-nginx-ingress-controller-867979b6df-gm9h5 fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057656       1 node.go:137] Pod external-dns-66757d8c4f-t96jz fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057759       1 node.go:137] Pod prometheus-kube-state-metrics-5d7c775cbc-lxphb fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057848       1 node.go:137] Pod prometheus-server-7bf7dfc69b-vcp9c fits on node ip-??-??-38-203.us-west-2.compute.internal
I0211 15:05:06.057968       1 node_affinity.go:75] Processing node: "ip-??-??-41-72.us-west-2.compute.internal"
I0211 15:05:06.243615       1 request.go:581] Throttling request took 185.422714ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-41-72.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:06.253468       1 node.go:137] Pod name-env-mongodb-arbiter-0 fits on node ip-??-??-41-72.us-west-2.compute.internal
I0211 15:05:06.253500       1 node.go:137] Pod name-env-mongodb-secondary-0 fits on node ip-??-??-41-72.us-west-2.compute.internal
I0211 15:05:06.253541       1 node_affinity.go:75] Processing node: "ip-??-??-68-232.us-west-2.compute.internal"
I0211 15:05:06.443609       1 request.go:581] Throttling request took 189.98173ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-68-232.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:06.455219       1 node_affinity.go:75] Processing node: "ip-??-??-8-78.us-west-2.compute.internal"
I0211 15:05:06.643603       1 request.go:581] Throttling request took 188.175458ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-8-78.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:06.653723       1 node.go:137] Pod name-env-mongodb-secondary-1 fits on node ip-??-??-8-78.us-west-2.compute.internal
I0211 15:05:06.653785       1 node_affinity.go:75] Processing node: "ip-??-??-83-142.us-west-2.compute.internal"
I0211 15:05:06.843632       1 request.go:581] Throttling request took 189.614987ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-83-142.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:06.855780       1 node.go:137] Pod name-env-ambassador-f859b7448-8j6x9 fits on node ip-??-??-83-142.us-west-2.compute.internal
I0211 15:05:06.855837       1 node.go:137] Pod prometheus-alertmanager-7d95895fdb-z86d5 fits on node ip-??-??-83-142.us-west-2.compute.internal
I0211 15:05:06.855879       1 node.go:137] Pod prometheus-pushgateway-bc74885b9-9jfnw fits on node ip-??-??-83-142.us-west-2.compute.internal
I0211 15:05:06.855992       1 node_affinity.go:75] Processing node: "ip-??-??-91-42.us-west-2.compute.internal"
I0211 15:05:07.043614       1 request.go:581] Throttling request took 187.476659ms, request: GET:https://<IP_ADDRESS>:123/api/v1/pods?fieldSelector=spec.nodeName%3Dip-??-??-91-42.us-west-2.compute.internal%2Cstatus.phase%21%3DFailed%2Cstatus.phase%21%3DSucceeded
I0211 15:05:07.053614       1 node.go:137] Pod name-env-mongodb-primary-0 fits on node ip-??-??-91-42.us-west-2.compute.internal
I0211 15:05:07.053663       1 node_affinity.go:107] Evicted 2 pods

But from looking at the log above there does NOT seem to be an eviction mentioned in the RemovePodsViolatingNodeAffinity (node_affinity), with "fits on node"
and the fact we're NOT using the affinity "requiredDuringSchedulingIgnoredDuringExecution"
So why does it mention the last line node_affinity.go:107] Evicted 2 pods?
Is it adding the number already evicted from the previous strategy LowNodeUtilization for a final total?
Describe the solution you'd like
If we could have something along the lines of a eviction total for:

Specific Strategy
Total of all Strategies

As mentioned my @damemi on slack:
"Node affinity does only check requiredDuringSchedulingIgnoredDuringExecution, but I believe all strategies share a common podEvictor, which may be logging the total number of pods evicted across all strategies."
Describe alternatives you've considered
N/A
What version of descheduler are you using?
descheduler version: 0.19.0
Additional context
As discussed on slack - https://kubernetes.slack.com/archives/C09TP78DV/p1613593842089500

/cc @ingvagabund
it looks like node affinity logs podEvictor.TotalEvicted(), but since podEvictor is shared this would be referring to the total across all strategies correct?
/kind bug

since podEvictor is shared this would be referring to the total across all strategies correct?

Yes, that's correct. We might extend the pod evictor to also collect "metrics" for individual strategies and runs and report smth like:

For now, I opened https://github.com/kubernetes-sigs/descheduler/pull/502 to move this log message out of any strategies and into the main loop

I think the main issue here was closed, and opened a new one to track possibly improving podEvictor https://github.com/kubernetes-sigs/descheduler/issues/503


Overlapping Infor and main title

On mobile screen, there is overlaps between the main title and Infor section. Please refer to below pic. Thanks

You have too many info entities on the card. Best is to shorten the title or set less entities


Backend authentication

Make the backend handle the creation and processing of JWT bearer tokens

This is worked on in feat-user-authentication


lxc export: Failed to rename export file

Steps to reproduce
$ lxc init images:alpine/edge a1
$ lxc export a1
Exporting the backup: 100% (1.99GB/s)Error: Failed to rename export file: rename /var/lib/snapd/hostfs/home/sdeziel/a1.backup a1.tar.gz: invalid cross-device link
$ ll a1.backup
-rw-rw-r-- 1 sdeziel sdeziel 3786310 May 22 11:48 a1.backup

The a1.backup file should have been renamed as it was on earlier LXD releases IIRC.
Information to attach
$ snap list lxd
Name  Version       Rev    Tracking       Publisher   Notes
lxd   5.13-8e2d7eb  24846  latest/stable  canonical✓  -

Not sure if that's relevant, but I'm using btrfs with 2 subvolumes:
$ mount | grep btrfs
/dev/mapper/nvme0n1p3_crypt on / type btrfs (rw,noatime,compress=zstd:3,ssd,space_cache=v2,subvolid=256,subvol=/@)
/dev/mapper/nvme0n1p3_crypt on /home type btrfs (rw,noatime,compress=zstd:3,ssd,space_cache=v2,subvolid=257,subvol=/@home)

Fixed by https://github.com/lxc/lxd/pull/11693


Combine matchers

It would be great if it was possible to combine together matchers using boolean "and" and "or". For example, sometimes the object I'm testing is ok if it's in either of two states, and it would be great to be able to say:
expect(num).toEqual(NaN).or.toEqual(null)

There's some subtlety here surrounding not, for example I'd imagine that in:
expect(num).not.toEqual(NaN).or.toEqual(null)

not would bind more tightly than or.
Sorry I haven't contributed any code to achieve this! If I get time I might have a go
Thanks!

I'm not convinced that we'd want to add syntax to allow you to write fuzzier specs -- and I have to admit I'm a bit surprised that with the same inputs you might possibly get two different outputs -- maybe stub whatever is causing the randomness here?
In either case, the good news is that you can write your own matcher to do exactly this! It would look something like the following: https://gist.github.com/1336695 (warning: untested, un-linted, early-morning code).
Try adding that to your spec_helper and seeing if it works.
Thanks for using Jasmine!
.


ForceInertialToBody module

add new module to transform force commands from inertial frame to body frame

Sorry, I wanted to create the PR againt my fork, but ended up here.


add minimum required pluginlib version

Follow-up of https://github.com/ros-visualization/rviz/pull/1217
For users trying to build rviz with an outdated pluginlib version

Is this the right target branch? Or should it be melodic?

I guess since the other was for kinetic, this is fine. Does it need to be forward ported or maybe the forward port needs different version requirements? Or maybe it doesn’t need forward port because the required changes are part of melodic from the start.

As the very first version of pluginlib released in Melodic provided both headers I didn't think it was necessary to put the requirement there. If you do add it, the first version of pluginlib released in Melodic was 1.12.0


feat: Add logging to ai_benchmark execution

The code changes add logging statements using the loguru library to track the execution of the ai_benchmark module. This will provide more visibility into the benchmarking process and help with debugging if any issues arise.
Based on the recent repository commits, the established convention for chore-related commits is to start with the prefix "chore:". However, since this change adds a new feature (logging), the commit message should start with the prefix "feat:".
Please note that the commit message should not include any meta information like issue references, tags, or author names.

@wawa0210 PTAL


Entropy bytes discarded

If syscall_random returns less than the number of bytes needed then those bytes are discarded.  We should perhaps use whatever we get.
https://github.com/openssl/openssl/blob/96d7852cbd0c7861cce155e1dc8c621648c0ba70/crypto/rand/rand_unix.c#L444-L456
All kernels will actually only fail or return the requested number of bytes for the amount we call it with so, while this isn't ideal, it probably doesn't make much difference in practice. We should clean it up though.

This issue was reported by OSTIF.


1.17 please!

can this be updated? :D id love it! thank you either way!

Will update soon! Sorry for the late reply.


langchain[patch]: Update default PDF split lines separator

Hi @jacoblee93 just ran into this change. The langchain default document says otherwise: https://js.langchain.com/docs/modules/data_connection/document_loaders/pdf#usage-one-document-per-page either the code or the doc should probably change.


add additional backtick for code block

Description
When one wantes to use a code block in the changelog section it won't work, because it will end the previous block.
Adding another backtick solves the problem.
Motivation and Context
see above
How Has This Been Tested?
created this PR with the changed text.
Changelog Entry

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[x] Other: PR tempplate

Checklist:

[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.
[ ] I have formatted the code with rustfmt.
[ ] I checked the lints with clippy.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report
Patch and project coverage have no change.

Comparison is base (4071792) 67.96% compared to head (7d79820) 67.96%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   67.96%   67.96%
=======================================
  Files          11       11
  Lines         515      515
=======================================
  Hits          350      350
  Misses        165      165

Flag
Coverage Δ

unit-tests
67.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Better default times

Default of 90 minutes for calendar events, but what about "All-Nighter"?

Related to https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/12, defaulting / guessing duration should only be done as part of generating the calendar file and not in the JSON blob


fix script

Issue:

Demo: https://dev.seomat.com/intercom-facade/
Try to hover + click as fast as possible at intercom bubble.

Thanks @ZsharE !


Linux build failing

Failed attempt to build on oceanonly... log attached
build_log.oceanonly.02022016.txt

@gleckler1 my quick test lead to the following error:
  /export/durack1/160302_pcmdi_metrics/PCMDI_METRICS/lib/python2.7/site-packages/MyProxyClient-1.3.0-py2.7.egg
  Processing dependencies for MyProxyClient==1.3.0
  Searching for cryptography>=0.7
  Reading https://pypi.python.org/simple/cryptography/
  Couldn't retrieve index page for 'cryptography'
  Scanning index of all packages (this may take a while)
  Reading https://pypi.python.org/simple/
  -------------------------------------------------
   From /export/durack1/160302_pcmdi_metrics/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/MyProxyClient-prefix/src/MyProxyClient-stamp/MyProxyClient-install-err.log
  -------------------------------------------------
  Download error on https://pypi.python.org/simple/cryptography/: [SSL:
  CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590) -- Some
  packages may not be found!
  Download error on https://pypi.python.org/simple/: [SSL:
  CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590) -- Some
  packages may not be found!
  No local packages or download links found for cryptography>=0.7
  error: Could not find suitable distribution for
  Requirement.parse('cryptography>=0.7')

It's (almost) fixed in https://github.com/UV-CDAT/uvcdat/pull/1840 - I'm not sure what the status of this is, it's passing all the travis tests that I have seen.. Not certain about what's happening with the mac-bots.. @doutriaux1?

@gleckler1 please try again, the latest changes in UV-CDAT/uvcdat#1840 should have fix this.

@doutriaux1 ok great, this fixes my issues for the pcmdi_metrics - you might want to ping Matthias to try again with the master branch..

@doutriaux1
build_log.oceanonly.02032016.txt

@gleckler1 add:
setenv PATH "$PATH:/export/durack1/bin/downloads/cmake3.2.2/150422_build/bin"

Into the top of your install_metrics.bash - this will isolate if it's a CMake issue..

@doutriaux1 @durack1
Can't build on crunchy either.   Looks like a different issue.   I must be doing something wrong...
build_log.crunchy.02032016.txt

I'm coming to your office

@doutriaux1 @durack1   The cmake update on oceanonly needs also to be on crunchy where build is still failing....
Your branch is up-to-date with 'origin/master'.
removing UVCDAT build directory
LEAN MODE will not build graphics
CMAKE ARGS: cmake /export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat -DCDAT_BUILD_MODE=LEAN -DCDAT_BUILD_ESMF_ESMP=ON -DCMAKE_INSTALL_PREFIX=/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS -DZLIB_PATCH_SRC=3 -DGIT_PROTOCOL=git://
PATH:/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/Externals/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin
PWD:/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat_build
CMake Error: Could not find CMAKE_ROOT !!!
CMake has most likely not been installed correctly.
Modules directory not found in
/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/Externals/bin
CMake Error: Error executing cmake::LoadCache(). Aborting.
ERROR: Could not configure (cmake) cdat code (2)
~/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat ~/METRICS_PACKAGE/PCMDI_METRICS/tmp/metrics
Sorry...
This action did not complete successfully
Please try to re-run this task until successful before continuing further
ERROR: Could not compile (make) cdat code
~/METRICS_PACKAGE/PCMDI_METRICS/tmp/metrics
Sorry...
This action did not complete successfully
Please try to re-run this task until successful before continuing further

yep
From: gleckler1 <notifications<EMAIL_ADDRESS>Reply-To: PCMDI/pcmdi_metrics <reply<EMAIL_ADDRESS>Date: Friday, March 4, 2016 at 5:44 PM
To: PCMDI/pcmdi_metrics <pcmdi_metrics<EMAIL_ADDRESS>Cc: "Doutriaux, Charles" <doutriaux1<EMAIL_ADDRESS>Subject: Re: [pcmdi_metrics] Linux build failing (#307)
@doutriaux1https://github.com/doutriaux1 @durack1https://github.com/durack1 The cmake update on oceanonly needs also to be on crunchy where build is still failing....
Your branch is up-to-date with 'origin/master'.
removing UVCDAT build directory
LEAN MODE will not build graphics
CMAKE ARGS: cmake /export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat -DCDAT_BUILD_MODE=LEAN -DCDAT_BUILD_ESMF_ESMP=ON -DCMAKE_INSTALL_PREFIX=/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS -DZLIB_PATCH_SRC=3 -DGIT_PROTOCOL=git://
PATH:/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/Externals/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin
PWD:/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat_build
CMake Error: Could not find CMAKE_ROOT !!!
CMake has most likely not been installed correctly.
Modules directory not found in
/export_backup/gleckler1/METRICS_PACKAGE/PCMDI_METRICS/Externals/bin
CMake Error: Error executing cmake::LoadCache(). Aborting.
ERROR: Could not configure (cmake) cdat code (2)
~/METRICS_PACKAGE/PCMDI_METRICS/tmp/uvcdat/uvcdat ~/METRICS_PACKAGE/PCMDI_METRICS/tmp/metrics
Sorry...
This action did not complete successfully
Please try to re-run this task until successful before continuing further
ERROR: Could not compile (make) cdat code
~/METRICS_PACKAGE/PCMDI_METRICS/tmp/metrics
Sorry...
This action did not complete successfully
Please try to re-run this task until successful before continuing further
—
Reply to this email directly or view it on GitHubhttps://github.com/PCMDI/pcmdi_metrics/issues/307#issuecomment-192547540.

@doutriaux1 so I have also hit issues on OS X 10.11.3:
OS X: 10.11.3
XCode: 7.2.1
XQuartz: 2.7.8
gfortran: 5.2.0
git: 2.6.2

And using the `install_metrics.bash options:
num_cpus=1
build_graphics=true
build_graphics_against_mesa=false
build_cmor=true
build_parallel=false
keep_uvcdat_build_dir=false
cmake_version="3.4.3"
cdat_version="master"

The error I hit is:
[ 11%] Performing build step for 'freetype'
CMake Error at /Users/pauldurack/Desktop/PCMDI_METRICS/tmp/uvcdat/uvcdat_build/freetype-prefix/src/freetype-stamp/freetype-build.cmake:56 (message):
  CTEST_FULL_OUTPUT
...
Do you want more here?

@doutriaux1 ok got things building on OS X 10.11.3 but have hit a bunch of errors in the tests - as per the attached file 160305_PCMDIMETRICS-master-testlog.txt

@doutriaux1 @gleckler1 it seems this long-standing issue is still a problem..

As the EOS article is scheduled for publication soon, and as we're likely to get a lot of eyes looking at the repo in coming weeks it'd be great to solve this today.

@doutriaux1 the Travis badge still says failing

I know, i know... Need to go thru the mac numbers with @gleckler1


How can I get raw request body in preprocess method?

public Task PreProcessAsync(IPreProcessorContext<TRequest> ctx, CancellationToken ct)
    {
        var requestContent = ReadRequestBody(ctx.HttpContext.Request);
    }

private string ReadRequestBody(HttpRequest request)
    {
        using StreamReader reader = new StreamReader(request.Body, Encoding.UTF8);
        var requestBody = reader.ReadToEndAsync();
        requestBody.Wait();
        return requestBody.Result;
    }

I always get empty string " ";

Have you tried this?

Hi @nefarius
Using IPlainTextRequest I can get plain json body. but could you help me to access the body without using reflection.
Currently i am getting using  ctx.Request.TryGetPropertyValue("key")

@lujamaharjan
by the time control arrives at pre-processors, the HttpContext.Request.Body stream has already been consumed by the serializer (STJ). you can use a bufferring middleware to enable multiple reads, but it's not recommended due to the perf impact.
if you give us more details of why you need to re-read the request body stream, we might be able to give you a better alternative. also you shouldn't be using .Wait() on a task. that's a recipe for future trouble.
if i my assumption is correct, you're using a generic pre-processor and you don't know how to read a common property value of the incoming request dto yes?
if that's the case, just implement an interface which enforces the required common property and cast to that interface in the pre-processor. something like this:
interface IHasCompanyId
{
    int CompanyId { get; set; }
}

sealed class MyRequest : IHasCompanyId
{
    public int CompanyId { get; set; }
}

sealed class MyProcessor<TRequest> : IPreProcessor<TRequest>
{
    public async Task PreProcessAsync(IPreProcessorContext<TRequest> context, CancellationToken ct)
    {
        if (context.Request is IHasCompanyId dto)
        {
            var companyId = dto.CompanyId;
        }
    }
}

Thanks


Update stable version in repo from 1.1.4 to 1.1.6

Think about update stable version to 1.1.6
Version: stable=1.1.4 (282 days old) => latest=1.1.6 (15 days old)
Installs: stable=282 (70.15%), latest=40 (9.95%), total=402
Click to edit

Done with PR https://github.com/ioBroker/ioBroker.repositories/pull/1698


ERC721 Standardisation and in-line library

Update contracts to use standard ERC721.
In-line the verification library.
Update tests in line with these changes.

@JamesSmartCell It would be nice to get this in place so I can use it in the documentation for Devcon and create a simple ERC721 example using the library. Can we merge?

I will merge as Oleg has already approved the request


HBASE-28944 TestShadedHBaseTestingUtility fails with NCDFE: org/mocki…

…to/stubbing/Answer

Hadoop versions having HDFS-15915 need to either have mockito in their runtime or need to explicitly add it or else they fail with NCDFE during MiniDFSCluster initialisation
Hence, instead of changing dependencies explicitly, we fall back to backporting "HBASE-27598 Upgrade mockito to 4.x" to branch-2.5; which is present on all other branches, where this test seems to work as expected
Also, as part of this fix we have made additional changes for the mockito migration as needed

Verified the test passes with this change:
[INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
WARNING: System::setSecurityManager will be removed in a future release
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.801 s - in org.apache.hbase.shaded.TestShadedHBaseTestingUtility
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  24.297 s
[INFO] Finished at: 2024-10-30T16:57:15+05:30
[INFO] ------------------------------------------------------------------------

Shouldn't we just call it HBASE-27598 ?
Isn't this 99% the same ?

We should also make sure that this works with 3.2.4. (The precommit CI should be enough)

Shouldn't we just call it HBASE-27598 ? Isn't this 99% the same ?

Sure I just wanted to keep the context in jira hence avoided updating title. But yeah let me close current jira as duplicate HBASE-28944 and create a backport jira for HBASE-27598 ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m  5s

Docker failed to build run-specific yetus/hbase:tp-31854}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/6415

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Shouldn't we just call it HBASE-27598 ? Isn't this 99% the same ?

Sure I just wanted to keep the context in jira hence avoided updating title. But yeah let me close current jira as duplicate HBASE-28944 and create a backport jira for HBASE-27598 ?

Updated!

LGTM but, ideally @Apache9  should also look at this, perhaps he had a specific reason not to backport to branch-2.5.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s

branch-2.5 passed

+1 :green_heart:
compile
2m  4s

branch-2.5 passed

+1 :green_heart:
javadoc
3m 20s

branch-2.5 passed

+1 :green_heart:
shadedjars
5m 26s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s

the patch passed

+1 :green_heart:
compile
2m  3s

the patch passed

+1 :green_heart:
javac
2m  3s

the patch passed

+1 :green_heart:
javadoc
3m 18s

the patch passed

+1 :green_heart:
shadedjars
6m 16s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
272m 59s
/patch-unit-root.txt
root in the patch failed.

309m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ef6e5bf2dba5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/testReport/

Max. process+thread count
4687 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 14s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s

branch-2.5 passed

+1 :green_heart:
compile
2m 42s

branch-2.5 passed

+1 :green_heart:
javadoc
4m 21s

branch-2.5 passed

+1 :green_heart:
shadedjars
7m 17s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 38s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s

the patch passed

+1 :green_heart:
compile
2m 39s

the patch passed

+1 :green_heart:
javac
2m 39s

the patch passed

+1 :green_heart:
javadoc
4m 22s

the patch passed

+1 :green_heart:
shadedjars
6m 37s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
281m 29s

root in the patch passed.

326m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux dcc1ad717836 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/testReport/

Max. process+thread count
7772 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s

branch-2.5 passed

+1 :green_heart:
compile
7m 17s

branch-2.5 passed

+1 :green_heart:
checkstyle
1m 40s

branch-2.5 passed

+1 :green_heart:
spotbugs
14m 52s

branch-2.5 passed

+1 :green_heart:
spotless
1m  3s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s

the patch passed

+1 :green_heart:
compile
6m 24s

the patch passed

+1 :green_heart:
javac
6m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 57s
/results-checkstyle-root.txt
root: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
16m 57s

the patch passed

+1 :green_heart:
hadoopcheck
30m 51s

Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.

+1 :green_heart:
spotless
1m 14s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
1m 45s

The patch does not generate ASF License warnings.

98m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 8f1212406d6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
180 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 25s

branch-2.5 passed

+1 :green_heart:
compile
3m 31s

branch-2.5 passed

+1 :green_heart:
javadoc
5m 35s

branch-2.5 passed

+1 :green_heart:
shadedjars
6m  5s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s

the patch passed

+1 :green_heart:
compile
3m 20s

the patch passed

+1 :green_heart:
javac
3m 20s

the patch passed

+1 :green_heart:
javadoc
5m 11s

the patch passed

+1 :green_heart:
shadedjars
7m 29s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
309m 40s
/patch-unit-root.txt
root in the patch failed.

359m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 41455b3325ec 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/testReport/

Max. process+thread count
7348 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 30s

branch-2.5 passed

+1 :green_heart:
compile
1m 40s

branch-2.5 passed

+1 :green_heart:
javadoc
3m  6s

branch-2.5 passed

+1 :green_heart:
shadedjars
4m 54s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s

the patch passed

+1 :green_heart:
compile
2m 16s

the patch passed

+1 :green_heart:
javac
2m 16s

the patch passed

+1 :green_heart:
javadoc
3m 58s

the patch passed

+1 :green_heart:
shadedjars
5m 21s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
327m 52s
/patch-unit-root.txt
root in the patch failed.

362m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux b09282ecab04 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/testReport/

Max. process+thread count
4552 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 35s

branch-2.5 passed

+1 :green_heart:
compile
2m 49s

branch-2.5 passed

+1 :green_heart:
javadoc
4m 40s

branch-2.5 passed

+1 :green_heart:
shadedjars
7m  5s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 30s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
javadoc
4m 58s

the patch passed

+1 :green_heart:
shadedjars
6m 59s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
393m 43s
/patch-unit-root.txt
root in the patch failed.

475m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux cb684517e0c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/testReport/

Max. process+thread count
7590 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  6s

branch-2.5 passed

+1 :green_heart:
compile
5m 13s

branch-2.5 passed

+1 :green_heart:
checkstyle
1m 12s

branch-2.5 passed

+1 :green_heart:
spotbugs
11m  5s

branch-2.5 passed

+1 :green_heart:
spotless
0m 43s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
5m  7s

the patch passed

+1 :green_heart:
javac
5m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-root.txt
root: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
12m  4s

the patch passed

+1 :green_heart:
hadoopcheck
21m 21s

Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.

-1 :x:
spotless
0m 43s

patch has 1 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

71m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 5da313ffc322 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
179 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s

branch-2.5 passed

+1 :green_heart:
compile
2m 42s

branch-2.5 passed

+1 :green_heart:
javadoc
4m  2s

branch-2.5 passed

+1 :green_heart:
shadedjars
4m 59s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s

the patch passed

+1 :green_heart:
compile
2m  0s

the patch passed

+1 :green_heart:
javac
2m  0s

the patch passed

+1 :green_heart:
javadoc
3m 36s

the patch passed

+1 :green_heart:
shadedjars
4m 58s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
244m 27s
/patch-unit-root.txt
root in the patch failed.

281m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux cf417fbba7f4 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/testReport/

Max. process+thread count
8122 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 19s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 59s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s

branch-2.5 passed

+1 :green_heart:
compile
2m 25s

branch-2.5 passed

+1 :green_heart:
javadoc
4m 18s

branch-2.5 passed

+1 :green_heart:
shadedjars
6m 34s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s

the patch passed

+1 :green_heart:
compile
2m 21s

the patch passed

+1 :green_heart:
javac
2m 21s

the patch passed

+1 :green_heart:
javadoc
4m  7s

the patch passed

+1 :green_heart:
shadedjars
6m 20s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
276m 19s

root in the patch passed.

319m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux c6b4aee1a58d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/testReport/

Max. process+thread count
7782 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 23s

branch-2.5 passed

+1 :green_heart:
compile
2m  9s

branch-2.5 passed

+1 :green_heart:
javadoc
4m 32s

branch-2.5 passed

+1 :green_heart:
shadedjars
5m 10s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s

the patch passed

+1 :green_heart:
compile
2m  6s

the patch passed

+1 :green_heart:
javac
2m  6s

the patch passed

+1 :green_heart:
javadoc
3m 36s

the patch passed

+1 :green_heart:
shadedjars
4m 43s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
316m 43s

root in the patch passed.

351m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 3a7e318c5de3 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/testReport/

Max. process+thread count
7175 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Hi @Apache9 could you please have a look at this?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s

branch-2.5 passed

+1 :green_heart:
compile
5m 28s

branch-2.5 passed

+1 :green_heart:
checkstyle
1m 16s

branch-2.5 passed

+1 :green_heart:
spotbugs
12m 20s

branch-2.5 passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
6m 42s

the patch passed

+1 :green_heart:
javac
6m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 27s
/results-checkstyle-root.txt
root: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)

+1 :green_heart:
xmllint
0m  1s

No new issues.

+1 :green_heart:
spotbugs
16m 54s

the patch passed

+1 :green_heart:
hadoopcheck
23m 41s

Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 46s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
1m 20s

The patch does not generate ASF License warnings.

83m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux 1b5f09ce8cb9 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
179 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s

branch-2.5 passed

+1 :green_heart:
compile
1m 50s

branch-2.5 passed

+1 :green_heart:
javadoc
3m  5s

branch-2.5 passed

+1 :green_heart:
shadedjars
5m 17s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s

the patch passed

+1 :green_heart:
compile
1m 51s

the patch passed

+1 :green_heart:
javac
1m 51s

the patch passed

+1 :green_heart:
javadoc
3m  5s

the patch passed

+1 :green_heart:
shadedjars
5m 19s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
268m 26s
/patch-unit-root.txt
root in the patch failed.

303m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 0633e6121065 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/testReport/

Max. process+thread count
7722 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s

branch-2.5 passed

+1 :green_heart:
compile
2m  2s

branch-2.5 passed

+1 :green_heart:
javadoc
4m  7s

branch-2.5 passed

+1 :green_heart:
shadedjars
5m 32s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
2m  3s

the patch passed

+1 :green_heart:
javac
2m  3s

the patch passed

+1 :green_heart:
javadoc
3m 17s

the patch passed

+1 :green_heart:
shadedjars
6m  6s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
313m 28s

root in the patch passed.

352m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 55820d6fba51 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/testReport/

Max. process+thread count
7476 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 22s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s

branch-2.5 passed

+1 :green_heart:
compile
1m 39s

branch-2.5 passed

+1 :green_heart:
javadoc
2m 57s

branch-2.5 passed

+1 :green_heart:
shadedjars
4m 37s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s

the patch passed

+1 :green_heart:
compile
1m 40s

the patch passed

+1 :green_heart:
javac
1m 40s

the patch passed

+1 :green_heart:
javadoc
3m  5s

the patch passed

+1 :green_heart:
shadedjars
4m 37s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
425m 25s

root in the patch passed.

456m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ece6b02d0163 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/testReport/

Max. process+thread count
6695 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/6/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s

branch-2.5 passed

+1 :green_heart:
compile
5m 10s

branch-2.5 passed

+1 :green_heart:
checkstyle
1m 10s

branch-2.5 passed

+1 :green_heart:
spotbugs
14m 11s

branch-2.5 passed

+1 :green_heart:
spotless
0m 57s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 37s

the patch passed

+1 :green_heart:
compile
7m 25s

the patch passed

+1 :green_heart:
javac
7m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 34s
/results-checkstyle-root.txt
root: The patch generated 1 new + 42 unchanged - 0 fixed = 43 total (was 42)

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
spotbugs
16m 51s

the patch passed

+1 :green_heart:
hadoopcheck
22m 44s

Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 58s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
1m 20s

The patch does not generate ASF License warnings.

83m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint

uname
Linux ecf8f5dc1f18 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
178 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/7/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 17s

branch-2.5 passed

+1 :green_heart:
compile
2m 30s

branch-2.5 passed

+1 :green_heart:
javadoc
5m 24s

branch-2.5 passed

+1 :green_heart:
shadedjars
6m  7s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 58s

the patch passed

+1 :green_heart:
compile
2m 52s

the patch passed

+1 :green_heart:
javac
2m 52s

the patch passed

+1 :green_heart:
javadoc
4m 48s

the patch passed

+1 :green_heart:
shadedjars
5m 39s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
259m 48s
/patch-unit-root.txt
root in the patch failed.

300m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6415

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 97cd8a50bd13 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 3dc8cd8fc936f37904c44283573e3402e00e12a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/7/testReport/

Max. process+thread count
4907 (vs. ulimit of 30000)

modules
C: hbase-client hbase-http hbase-server hbase-mapreduce hbase-rest hbase-hbtop . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6415/7/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Hi @Apache9 did you get a chance to have a look at this PR?

Failures were not related, merged! Thank you for your review @stoty @ndimiduk and @Apache9


[GHSA-8c6j-ffmf-q6vm] Apache Struts RCE Vulnerability

Updates

Affected products
References

Comments
Add some patch links related to CVE-2016-3081 which fixed in multi-branch.

Hi @sunSUNQ, this contribution isn't being accepted because the commit links do not correspond with the vulnerability described in the CVE description, nor do the fixes correspond with the proposed solution in the Solution section on https://cwiki.apache.org/confluence/display/WW/S2-032. Thank you for your interest in GHSA-8c6j-ffmf-q6vm!


Enable social login to Azkaban Web

We would like users to be able to log into Azkaban Web portal using social auth like Azure AD, Google, GitHub etc accounts w/o the need to pre-create the accounts and passwords by hand.
This would help with compliance and auditing requirements and improves the security of the tool.
Storing login details in an XML file on the disk on the server isn't a great production level feature.

Hi there -
I actually have a fork of Azkaban that has implemented Google SSO, and I've been trying to decide whether it would be worth the effort to get it upstreamed into Azkaban.

It's implemented as a UserManager plugin
It does require, however, modifying the front-end templates in order to add the SSO buttons, and adds a few new configuration parameters, which is why I didn't implement it purely as a plugin.

My main concern is that the logic for managing users is mostly hidden behind the usermanager interface, and as my fork is currently implemented, will introduce some logic that will sprawl beyond that (into the templates, etc.).
If Azkaban would be amenable to accepting such a contribution, I'd be happy to take the time to get it into a state where we could upstream this.

@justin-yan any chance you could share your code as a pull request so that others could fetch & use it needed?


[Storage] az storage share-rm stats: Get the usage bytes of the data stored on the share.

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

Storage


feat!: Rework backend for fallible traits to avoid panic & unwrap

This reworks the backend to leverage the changes for fallible functions. It introduces an error enum with admittedly bad variant names and uses them to map error cases throughout the codebase so panic and/or unwrap isn't used to handle most values.
There are still some TODOs to cleanup even more unwrap cases and it relies on something like https://github.com/noir-lang/acvm/pull/251, but this should be a solid skeleton for how a backend can surface errors to nargo.

You can change the commit to point to acvm 0.11 -- Is this ready for review? If not, then I can push a new PR with the fallible traits but has the same behaviour as without the fallible traits.
Main goal here is to get Keccak upstreamed -- Alternatively, I can add Keccak into the pwg for now by copying this code into here.
Then removing it once we use acvm > 0.11

Promoting from draft because acvm 0.11 was released but we still need to workshop the errors and stuff.

I've completed my TryInto TODOs and split the wasm errors into their own enum. src/merkle.rs still has a lot of unwraps but I don't think we need to update that for this to land.
Besides error variant naming and error messages, I think this should be good-to-go. Will wait on @TomAFrench to do a full review and give feedback on those.

Some thoughts on error variants
// These variants shouldn't exist as we can prevent them at compile time
SchnorrConvert(Vec<u8>),
SchnorrSlice { source: TryFromSliceError },
FieldElementSlice { source: TryFromSliceError },
FieldToArray(usize, usize),

// Can be replaced with a MalformedOpcode(Opcode) error
// This error can be defined down in ACVM and be shared across backends
MissingOutput(usize),
MissingLeaf,
MissingLeafIndex,
MissingPublicKeyX,
MissingPublicKeyY,
MissingSignature(usize),
MissingPublicKey(&'static str, usize),

// I think we can leave this as a panic tbh.
// Calling a backend with an unsupported opcode is calling the `solve` function outside of contract.
Aes,

// Unsure what to do these
Pow2CeilOverflow(u32),
WasmError,

I think this PR is good-to-go and we should hold any other changes/PRs until it lands. We need to get this stuff upstreamed.


C-SPAN audio-only programs fail

[x] I've verified and I assure that I'm running youtube-dl 2017.12.14

I don't know why there are audio-only hearings recorded on C-SPAN (there seems to be video of this hearing available elsewhere, at least in snippet form...), but youtube-dl doesn't seem to work:
pb3:Downloads jhawk$ youtube-dl -v https://www.c-span.org/video/?438311-1/judiciary
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.c-span.org/video/?438311-1/judiciary']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.12.14
[debug] Python version 2.7.10 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg git-2017-02-28-7f62368, ffprobe git-2017-02-28-7f62368, rtmpdump 2.4
[debug] Proxy map: {}
[CSpan] 438311: Downloading webpage
ERROR: unable to find video id and type; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 784, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 437, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/cspan.py", line 115, in _real_extract
    raise ExtractorError('unable to find video id and type')
ExtractorError: unable to find video id and type; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

There is a
                                var jwsetup = {
                                        file: 'https://media.c-spanvideo.org/trimmed/program/049/492999/program.492999.AAC-STD.aac?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly9tZWRpYS5jLXNwYW52aWRlby5vcmcvdHJpbW1lZC9wcm9ncmFtLzA0OS80OTI5OTkvcHJvZ3JhbS40OTI5OTkuQUFDLVNURC5hYWMiLCJDb25kaXRpb24iOnsiRGF0ZUxlc3NUaGFuIjp7IkFXUzpFcG9jaFRpbWUiOjE1MTMzMjUwNDV9LCJJUEFkZHJlc3MiOnsiQVdTOlNvdXJjZUlwIjoiNzEuMjMyLjE5Ljc0In19fV19&Signature=S1TVHl2jeTxiir05RZRpnGDLaKq9yN6ih-oqr2FbxWzpFop9~oNJvJnhD9SUIZTObjYkXugKAdpr8-kldWIy-vE9kq5FKHAr~2ZcMO-T2~Nn3qN6-mW4PZ5tq0vhrD3LHdUEX4c9qk84mIpwhPaDF4AUgdV1QyULazTRHrDDxNQ_&Key-Pair-Id=APKAIHKVWBEAXX562G7Q',

and that URL downloads just fine.

Bah humbug. By the time I got to looking at this, the web page has changed and now has no audio link either... And the https://media.c-spanvideo.org/trimmed/program/ link fails now.
I think I don't understand how c-span manages their content at a fundamental level...

because the url has exprired.
from the Amazon CloudFront Policy in the audio url:
{
    "Statement": [{
        "Resource": "https://media.c-spanvideo.org/trimmed/program/049/492999/program.492999.AAC-STD.aac",
        "Condition": {
            "DateLessThan": {
                "AWS:EpochTime":<PHONE_NUMBER>
            },
            "IPAddress": {
                "AWS:SourceIp": "CLIENT_IP"
            }
        }
    }]
}

I need to find another example, but looking at my dump file (from --write-pages) from last week, the C-SPAN web page had:

And that fails to be matched by _find_jwplayer_data():
https://github.com/rg3/youtube-dl/blob/549bb416f5a9d15c03749a98abd582d0e40418ac/youtube_dl/extractor/common.py#L2299-L2302
because that is expecting to see something like:

and script-video-ck, which is minified, eventually calls:
    var d = jwplayer("video-embed");
    d.setup(jwsetup);

So I imagine this too complicated for the common.py JWPlayer support to handle, so cspan.py needs to search out the var jwsetup and call _find_jwplayer_data() on its own?

@remitamine:

because the url has exprired.
from the Amazon CloudFront Policy in the audio url:

Yeah, I get that. What I'm puzzled by is why the audio link is gone from the c-span page, not why the audio URL itself is invalid.

I need to find another example, but looking at my dump file (from --write-pages) from last week, the C-SPAN web page had:

Here is another example of an audio-only C-SPAN recording which has not disappeared: https://www.c-span.org/video/?438495-1/judiciary
Same jwsetup js pattern and script-video-ck usage.

this will work in the url that you have posted, however it would be better to test on more urls.
diff --git a/youtube_dl/extractor/cspan.py b/youtube_dl/extractor/cspan.py
index 171820e27..1a6426c4f 100644
--- a/youtube_dl/extractor/cspan.py
+++ b/youtube_dl/extractor/cspan.py
@@ -111,6 +111,11 @@ class CSpanIE(InfoExtractor):
                     title = self._og_search_title(webpage)
                     surl = smuggle_url(senate_isvp_url, {'force_title': title})
                     return self.url_result(surl, 'SenateISVP', video_id, title)
+                video_id = self._search_regex(
+                    r'jwsetup\.clipprog\s*=\s*(\d+);',
+                    webpage, 'jwsetup program id', default=None)
+                if video_id:
+                    video_type = 'program'
         if video_type is None or video_id is None:
             raise ExtractorError('unable to find video id and type')

@@ -138,7 +143,7 @@ class CSpanIE(InfoExtractor):
         entries = []
         for partnum, f in enumerate(files):
             formats = []
-            for quality in f['qualities']:
+            for quality in f.get('qualities', []):
                 formats.append({
                     'format_id': '%s-%sp' % (get_text_attr(quality, 'bitrate'), get_text_attr(quality, 'height')),
                     'url': unescapeHTML(get_text_attr(quality, 'file')),

Thanks. I wouldn't have done it that way, but your way gets the C-SPAN metadata so I can see why you chose it.
It also ought to have worked, based on inspection of my saved data, on the original URL.

however it would be better to test on more urls.

Here's are some more test cases:
https://www.c-span.org/video/?437336-1/judiciary-antitrust-competition-policy-consumer-rights
https://www.c-span.org/video/?438047-1/judiciary
I got them from
https://www.c-span.org/search/?sdate=&edate=&audio=1&searchtype=Videos&sort=Most+Recent+Airing&text=0&sponsorid[]=61188
and picking out the ones marked "AUDIO STREAM ONLY" (except for 438311, the original, which is still listed there but broken).
So looks good, except for a youtube-dl test?

So looks good, except for a youtube-dl test?

added a test with only_matching as most of the pages show this error(most likely that a normal test will expire soon):
Video not available at this time

Huh. The older pages do all seem to show that.

I think I don't understand how c-span manages their content at a fundamental level...

Yeah that.
p.s.: seems like a test with skip would make more sense than only_matching but whatever.


showInputBox overwrites input with initial value when input is empty string

VSCode Version: 1.11.2
OS Version: Windows 10 1703

Steps to Reproduce:

Set InputBoxOptions like so:

        const powerShellDbgScriptArgsKey = 'powerShellDebugScriptArgs';

        let options: vscode.InputBoxOptions = {
            ignoreFocusOut: true,
            placeHolder: "Enter script arguments or leave empty to pass no args",
        }

        let prevArgs = this.context.globalState.get(powerShellDbgScriptArgsKey, '');
        if (prevArgs.length > 0) {
            options.value = prevArgs;
        }

        return vscode.window.showInputBox(options).then(text => {
            if (text !== undefined) {
                this.context.globalState.update(powerShellDbgScriptArgsKey, text);
                return new Array(text);
            }

            return text;
        });

When you run this, the user should be able to press Enter on an empty input box to tell us to send no args to the script. However, since we prepopulate the input box with the previous set of arguments, they clear the input box and press Enter.  Unfortunately, that passes the previous arguments as the text instead of the empty string that was in the inputbox before they pressed Enter.

Is there a workaround I can use to get the InputBox to return an empty string when there is an initial (default) value set and the user clears that value and presses Enter?

@jrieken Shouldn't I be able to observe this fix in VSCode Insiders by now?  I tried an insiders build from May 3rd and I still observe this issue.

Insiders has been frozen in the last days because we were preparing for the 1.12 release. In that time we basically make insiders be the same bit as the release build to get more confidence. Insiders should update starting today

Verified fixed in today's insiders build.  Thanks!


Functionality for display of File Structure

IntelliJ has a very useful feature, File Structure (screenshot below), to display a list of the contents of a file in table-of-contents format.  It would be great if intellibot could integrate with this.

yes, that certainly looks like a good thing to implement.  just a matter of finding the right hooks in the IDE code.  I'll investigate.

lang.psiStructureViewFactory extension point

will check that out; thanks for the head start!

that's brilliant, thanks.  When I get a chance I'll set up my environment to get familiar with this code.  Much appreciated.

I started a first pass at this.  It works but needs polish.
https://github.com/mtrubs/intellibot/commit/091f745f7114666625e5343d3fc056bb6f5d8cac
I cannot tell, but if you were looking to contribute that might get you part of the way.
Things I still have to do would be sorting/filtering, maybe some better icons, and of course the jump to source action?

added some polish #129

this is brilliant, thank you! The added filtering is also very much appreciated!

Thanks. I appreciate the feedback.  FYI I intentionally did not do a true structure representation of the file. It seemed like many Robot headers were redundant and having multiple groups of keywords was not valuable in my mind. Hence the flatness. Hope it makes sense as people use it.


Add condition_tag_name table to store all condition tag names for skips

Add condition_tag_name table with id, unique varchar name
Change condition_tag.name to condition_tag.condition_tag_name_id
Change skip_condition_tag.condition_tag_name to skip_condition_tag.condition_tag_name_id

An advantage of this is that, when doing the autocomplete for skips, you can easily return a complete list of previously used condition tag names. Think about how this all needs to be restricted by study in multi-tenancy scenarios.


MINOR: fix standby stream time

#5253 broke standby restoration for windowed stores.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Just a quick note about that last change; I'd been computing stream time as the max time seen so far in the context, but this isn't correct, since different changelogs will have different stream times. I've corrected it to just directly set the stream time in the context and take the max record timestamp out of a specific batch.

Just a quick note about that last change; I'd been computing stream time as the max time seen so far in the context, but this isn't correct, since different changelogs will have different stream times. I've corrected it to just directly set the stream time in the context and take the max record timestamp out of a specific batch.

Did not see this while I'm reviewing, and it is not very clear to me either.. could you elaborate? For a single standby task, shouldn't its stream time be defined as the max of record timestamp across all its fetching changelog topics?

@guozhangwang @bbejeck ,
About the stream time thing:
Let's say we have a topology that starts off like this:
input A -> |-------------|
           | StreamTask1 | -> ...
input B -> |-------------|

           |-------------|
input C -> | StreamTask2 | -> ...
           |-------------|

We can assume that they join up later on, it doesn't matter.
Note that StreamTask1's streamTime is driven by input A and input B, whereas StreamTask2's streamTime is driven by input C. In other words, the two tasks will have different stream times.
Now, suppose that StreamTask1 happens to produce x-state-changelog, and StreamTask2 happens to produce y-state-changelog. Also assume that we have configured to have one standby replica.
If I understand things correctly, then x-state-changelog and y-state-changelog can be assigned to the same StandbyTask. I'm not sure the impact, but I don't think it's correct for our StandbyTask to mix together the stream times of StreamTask1 and StreamTask2.

No the changelog topics should not be assigned to the same standby task,
the stream active task -> standby task mapping should be one-by-one.
On Mon, Jun 25, 2018 at 3:30 PM, John Roesler<EMAIL_ADDRESS>wrote:

@guozhangwang https://github.com/guozhangwang @bbejeck
https://github.com/bbejeck ,
About the stream time thing:
Let's say we have a topology that starts off like this:
input A -> |-------------|
| StreamTask1 | -> ...
input B -> |-------------|
       |-------------|

input C -> | StreamTask2 | -> ...
|-------------|
We can assume that they join up later on, it doesn't matter.
Note that StreamTask1's streamTime is driven by input A and input B,
whereas StreamTask2's streamTime is driven by input C. In other words, the
two tasks will have different stream times.
Now, suppose that StreamTask1 happens to produce x-state-changelog, and
StreamTask2 happens to produce y-state-changelog. Also assume that we have
configured to have one standby replica.
If I understand things correctly, then x-state-changelog and
y-state-changelog can be assigned to the same StandbyTask. I'm not sure the
impact, but I don't think it's correct for our StandbyTask to mix together
the stream times of StreamTask1 and StreamTask2.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/kafka/pull/5288#issuecomment-400116266, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKO4fSkChktZKXMqrmbmUhaq7FN01O4aks5uAWRzgaJpZM4U2mUb
.

--
-- Guozhang

Ah, my mistake. I'll update the code.

@mjsax, It's ready for more reviews now. I'd especially appreciate your scrutiny on the performance question.
Thanks,
-John

@mjsax Thanks for the revuew.
Many of those nitpicks on my tests also applied to other tests in StandbyTaskTest, so I conducted a broader cleanup of the test class.

I've rebased so we can re-run the integration tests (pending).
Also, I'm running the system tests:

branch: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1834/
trunk: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1835/

I'll report back tomorrow with the results.

Well, the trunk version failed in ducktape, but the tests on my PR branch passed (5 runs in 540 minutes):
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2018-07-03--001.1530608831--vvcephei--MINOR-fix-standby-stream-time--c2ebfaa/report.html

Thanks @vvcephei ! Merged to trunk.


Option to disable posting status comments

Fixes #28.

Result of integration 1
Integration took 53 seconds.
Perfect build! All 10 tests passed. :+1:


Misaligned segmentation masks

Downsampling by PyTorch nearest interpolation in main.py results in misaligned masks. That's going to be replaced with Pillow nearest interpolation. Codes and pre-trained models will be updated sometime soon.

FYI: 1/16 downsampling with various frameworks.
So far this repository has been used the right 3 methods.


[feature] Store rotation

Store rotation members so that people don't need to know who is next in order to rotate the assignment.
This needs to include a few commands along with validation and error handling:
[rotation] staff<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>[rotation] assign next
[rotation] reset staff

Feature complete


Is there an easy way to auto resize a gridItem based on the contents inside?

Ex: a gridItem has contents inside that take 300px in height, i wanted the gridItem to resize itself to 300px while the resize feature wouldn't let me resize the gridItem bellow 300px as well.

I was having the exact same question in a dashboard I built using grid-layout.

news?

Yup, this feature would be great

I've implement this feature, but it is not perfect.
onMounted(()=>{

      setTimeout(
        () => {
          eventBus.emit('calcClientHeight')
          setTimeout(() => onWindowResize(), 200)
        },
        300
      );
})

in GridItem:
function calcClientHeight() {
  const size = useElementSize(this$refsItem);
  const { w, h } = calcWH(size.height.value, size.width.value, true)
  emit('height-updated', props.i, h)
  nextTick(() => {
    createStyle();
    if (this$refsItem.value) {
      this$refsItem?.value.classList.remove('autoHeight')
      this$refsItem?.value.classList.add('fixedHeight')
    }
  })
}