Update VolFile::CreateVolumeInfo Struct to use STL Containers

Replace pointers to c-style arrays with std::vector
Remove member container int* fileNameLength
Update container names to be plural
Remove some no longer required memory management
Refactor VolFile::PrepareHeader

There is some missing error handling if something goes wrong with the STL containers. I'd like to save addressing this until HANDLE is replaced with one of our stream classes.
It would be nice to refactor VolFile::PrepareHeader into smaller functions. Quite a lot is happening in there right now.
To ease readability, I removed the tempPointer in the code below. @DanRStevens does this cost us any efficiency?
// Calculate offsets to the files
for (std::size_t i = 1; i < volInfo.fileCount(); i++)
{
	IndexEntry previousIndex = volInfo.indexEntries[i - 1];
	volInfo.indexEntries[i].dataBlockOffset = (previousIndex.dataBlockOffset + previousIndex.fileSize + 11) & ~3;
}

Code compiles without warnings or errors. A vol file is created with the code that properly interfaces with Outpost2.exe.

Next step for me will be more work in VolFile::CreateVolumeInfo. Updating to fixed width variables and replacing the HANDLE with a stream.

Thanks for the review. I pushed the reference fix when calculating file offsets.
I thought the for loop looked suspect, but didn't mess with it because as you mentioned, it will not exist when we change the HANDLE out with a stream.
Thanks,
Brett


Implement GraphQL interface for movedBoxes

This PR brings the GraphQL interface for data about moved boxes.
It can be used to generate a Sankey diagram of the number of boxes donated from a base into "donation" locations, filterable by movement day and product category.

Meeting with @pylipp @MaikNeubert
AGREED:
`
type MovedBoxesResult {
movedOn: Date!
targetId: ID!
categoryId: Int!
boxesCount: Int!
}
type MovedBoxDataDimensions {
target: [TargetDimensionInfo]
category: [DimensionInfo]
}
type TargetDimensionInfo {
id:
label: Base Name for shipment and Location Name for OutgoingLocation
type:  enum<Shipment, OutgoingLocation>
}
`
AGREED: Keep it simple, leave out SCRAP, LOST, shipment states for now

referencing discussion from Slack

@MaikNeubert I tested it with Hermine's base. Target dimension now looks like below, let me know if this is handy or whether you want base and location name to be listed separately.
{
  "data": {
    "movedBoxes": {
      "dimensions": {
        "target": [
          {
            "name": "Würzburg---V85 -JNCR Italy"
          },
...


Adding missing build instruction #1887

Adding missing build instruction that allows jaeger binaries to be built.

Please makes sure the commit is signed.


Feature: add cmake control for building libnuma

Description
The coming CXL he-cache exerciser requires libnuma.so. Adding the cmake support here to handle retrieving/building when the package is not natively installed.
Collateral (docs, reports, design examples, case IDs):
N/A

[ ] Document Update Required? (Specify FIM/AFU/Scripts)

Tests added:
N/A
Tests run:

Build without libnuma installed (single thread).
Build without libnuma installed (make -j $(nproc)).
Build with libnuma installed (single thread).
Build with libnuma installed (make -j $(nproc)).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.979%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
15754

Relevant Lines:
21887

💛  - Coveralls


Add support for large ensembles

zppy can currently be run on multiple simulations/members of an ensemble, by using different configuration files to specify different data paths.
It would be nice to add automation such that a single zppy configuration file could be used to post-process all members of an ensemble. Perhaps a summary pdf could be generated as well, displaying mean, median, etc.

One potential issue may be submitting/queueing the large number of jobs that would be generated, considering post-processing just one simulation/member launches many jobs.

From #186 (a duplicate of this issue): Add support for large ensembles. Add loop to run zppy on multiple experiments.

I ran zppy on a 250-member ensemble using a code that loops over each case and modifies the .cfg file, then submits the runs if I have less than some threshold number of runs in the queue. It worked great!

Is that the solution for all zppy users?

Sorry, I didn't mean to "close" the issue. The method I used works perfectly well, but zppy could certainly come up with its own way.


Hotfix/phantom download

err 作用域问题

Thanks for your PR. But this code has been upgraded.
https://github.com/henrylee2cn/pholcus/commit/3c52850f8e24a63cbe2535db99adf7b68b7154b7


add btc to the payment console

would be great if can utilize btc relay which can use btc as a payment option
https://github.com/ethereum/btcrelay

Hello, @mor888
We are currently implementing integration with coinpayements.net so it will support BTC and 100+ cryptos

Is ready? Also can we disable the kyc portion. Easily?
On Feb 23, 2018, at 2:38 PM, Andrey Degtyaruk <notifications<EMAIL_ADDRESS>wrote:
Hello, @mor888https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmor888&data=02|01||527b0736eac74787019808d57b0e2449|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550223018044848&sdata=sHdYai9oLI%2BRnFx36d5U8IJhQQX2rHE46TZGitxbj%2Fo%3D&reserved=0
We are currently implementing integration with coinpayements.nethttp://coinpayements.net so it will support BTC and 100+ cryptos
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJincorTech%2Fbackend-ico-dashboard%2Fissues%2F82%23issuecomment-368158761&data=02|01||527b0736eac74787019808d57b0e2449|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550223018044848&sdata=4CaBAKZIiSOAeAUFZGkNwy1FJmI5GiN31YYTL%2F2oYas%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAiDnymc2P9GJ51Pqy9PHw4t3akb01qX9ks5tXz3bgaJpZM4RqSCn&data=02|01||527b0736eac74787019808d57b0e2449|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550223018044848&sdata=al5PQhIwwLIGKpoMZW3Jc5Egw%2FROwHyao%2BBcrbHp2T0%3D&reserved=0.

It will be ready approx at 28.02.2018
As for disabling KYC - we will start working on ability to easily disable KYC and partner program right after coinpayments integration. It will take 1-2 business days more.

Yikes we were thinking of using it but we are launching on 28
On Feb 23, 2018, at 2:45 PM, Andrey Degtyaruk <notifications<EMAIL_ADDRESS>wrote:
It will be ready approx at 28.02.2018
As for disabling KYC - we will start working on ability to easily disable KYC and partner program right after coinpayments integration. It will take 1-2 business days more.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJincorTech%2Fbackend-ico-dashboard%2Fissues%2F82%23issuecomment-368160103&data=02|01||5ab782519be24f145c8208d57b0f0a0a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550226910828989&sdata=1jq4m%2FBdoAEMo5fB78Hh2i0vxd6FnZA9HVxQTNPHXSU%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAiDnygnYG_L6oT0dIaf7LG3wRLoQrOvsks5tXz9cgaJpZM4RqSCn&data=02|01||5ab782519be24f145c8208d57b0f0a0a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550226910828989&sdata=nTEL4UnzxU22xpAJs2%2B0LMfxAsm96GqHnWKeE4G1LbI%3D&reserved=0.

@mor888
I'm afraid there is no chance to use our dashboard in this case because even our team would not adopt and setup this dashboard in such a short time even if you don't need that changes. It usually takes us 1-4 weeks to customize dashboard for the new ICO.

Got it thanks
On Feb 23, 2018, at 3:32 PM, Andrey Degtyaruk <notifications<EMAIL_ADDRESS>wrote:
@mor888https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmor888&data=02|01||9756a55801e948d5ea3b08d57b15c122|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550255721725594&sdata=mb%2BdrHyonPcyqdJiQcv8zxkgLFlm8BlP8N828oujM0s%3D&reserved=0
I'm afraid there is no chance to use our dashboard in this case because even our team would not adopt and setup this dashboard in such a short time even if you don't need that changes. It usually takes us 1-4 weeks to customize dashboard for the new ICO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJincorTech%2Fbackend-ico-dashboard%2Fissues%2F82%23issuecomment-368169538&data=02|01||9756a55801e948d5ea3b08d57b15c122|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550255721725594&sdata=tqY78YnYOvWk429Cwtq7aS7KTawhlG3TJfW7NIpK1A8%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAiDnynGZr7TGut2QVAozyo4bqc2NTDgjks5tX0qhgaJpZM4RqSCn&data=02|01||9756a55801e948d5ea3b08d57b15c122|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636550255721881854&sdata=cPQir3jD9x%2BP%2BjANTE0YChpG4JUzvlE32kWn9MdPlEQ%3D&reserved=0.

@hlogeon Hi, thanks! Looking forward for coinpayment features & KYC disable option.
Keep us update! Thanks for your hard work!

@xicop9
Thanks! We really appreciate the interest to our solutions from the community.  Glad to hear that! Can't wait for the updates ;) Thank you

@hlogeon Still no update for disable KYC & coinpayment features?

@xicop9 This Pull-Request will add this feature #103
It needs some final touches. I hope this nice UI animation will help you to understand implementation :)


Redux example doesn't work with mergeCells

Description

As mentioned in our forum https://forum.handsontable.com/t/react-redux-render-with-mergecells-prop-triggers-beforechange-callback-call/3928 once we add mergeCells to the official Redux example we end up with an infinite loop.
Steps to reproduce

Do nothing, just check the console

Demo

https://handsontable.com/docs/7.2.2/frameworks-wrapper-for-react-redux-example.html official example
https://jsfiddle.net/AMBudnik/pftvn5qm/ the same code with mergeCells line 11
Your environment

React wrapper version: 3.1.0
Handsontable version: 7.2.2
Browser Name and version: Chrome 78
Operating System: Windows 10

Hi, this happens regardless the react wrapper: https://jsfiddle.net/rbarato/9yv0om48/3/
And it looks like the changes keep growing exponentially, the more merged cells I have, the more will be added to the array. In my case I have to loop thought the changes so I can process a very specific scenario and we're having issues with a sheet that has 79 areas merged and is generating an 11k changes array which crashes the sheet.

So this is not the same case (there's no infinite loop) but it makes the example unusable when we have many merged cells. We need to check all the scenarios while fixing.
Thank you for the feedback @rbarato

Hi @rbarato,
We merged wrapper for React into our main repository, handsontable/handsontable. Now library and wrapper are available in monorepo.
We also transfer all issues into one common issue board, where you can follow work progress and request issues.


feat: link harpoon highlights to default groups

Apparently this is what the cool plugin devs do :smiley:
Proof:

Telescope
Lazy
Mason
Neogit

ok, fair enough


Multi-line featured resources are not indented properly

When a featured resource with long titles requires more than one line, the second line should start directly below the first line (as in list with bullets). Currently, the second line starts under the star, which doesn't look great:

@juliandsmith - I began messing around with this today. I found the whole 'Featured Resource' panel to be a little crowded and clunky (especially when a user is not logged in). I've separated each resource instance into three buckets: Star or Lock, Title, Content Type Label. They wont overlap now. I've added a little front end logic to check if the user should see a star, or a lock, but they should never see both for a single resource listing. I've attached screen shots of when a user is logged in, and when they aren't. I know that I'll have to tweak some alignments, but let me know what you think!
Logged in:

Logged out, need to align the star and lock:

Looks great aside from the alignment for the star and lock icons!.

I like it too!


Specify Extension

I have several issues with the omission of the video extension. Is it possible to turn it off somehow? The CMS I use adds the extension automatically.

I would love that option too!

Have this problem as well as I'm storing the video in MongoDB and get a GridFS URL without an extension. Can the extension be overriden @VodkaBears ?

I am also having this problem. This also becomes an issue when a video link has GET parameters for authentication purposes such as:
https://domain.com/video.mp4?auth=1234
Vide tries to put the extension after the parameter like this:
https://domain.com/video.mp4?auth=1234.mp4
Which ends up breaking my links
I would love it if you could either specify to not automatically append the extension or to be smarter about where it puts the extension.


build: upgrae protoc and grpc toolchain

Wait a bit for https://issues.apache.org/jira/browse/INFRA-25344 merged and we can test the staging process.


[WHY] Fix silent yank error on macOS

My $tmux_yank_copy_command is reattach-to-user-namespace pbcopy. Running it myself in nohup is fine. However, tmux-fingers running it with nohup produces a silent error: nohup: can't detach from console: Inappropriate ioctl for device. Removing nohup restores my yank ability.
Why does this work? Is this really the solution?
Open Issues

Why is nohup okay in 1 situation but not the other?
Why was nohup necessary? nohup's use seems to be carried over from c267108e's $FINGERS_COPY_COMMAND fix. The commit doesn't say why.

Can the same be done without nohup?

Should tmux-fingers be silencing errors?

Why is nohup okay in 1 situation but not the other?

It's probably because fingers.sh is not running under my default-command.
$ tmux show-option -gqv default-command
reattach-to-user-namespace -l /usr/local/bin/zsh

So another way to work around my original issue is to keep nohup and instead prefix with my default command, that macOS hack:
diff --git a/scripts/fingers.sh b/scripts/fingers.sh
index 1a8cee2..3553832 100755
--- a/scripts/fingers.sh
+++ b/scripts/fingers.sh
@@ -103,7 +103,7 @@ function copy_result() {
   fi

   if [[ $HAS_TMUX_YANK = 1 ]]; then
-    echo -n "$result" | eval "nohup $tmux_yank_copy_command" > /dev/null
+    echo -n "$result" | eval "reattach-to-user-namespace nohup $tmux_yank_copy_command" > /dev/null
   fi
 }

In theory, for system clipboard integration, you don't need any custom copy command if you already have tmux-yank installed as well.
nohup was needed because it xclip hanged used as in $tmux_yank_copy_command, but I never dug deep into why. I'll review when I have bandwidth.
Thanks for PR! :raised_hands:

The copy command from my description is not custom. It is set by tmux-yank, yes.

Thanks a lot for the fix! Had a little brainfart and I was thinking this was about $fingers_copy_command instead.
This is merged now in 0.6.2 version :raised_hands:

🎉
Thanks for trusting my patch as-is! I hope nohup was indeed unnecessary for everyone.


On the decoding performance of PDF417

Compared with other decoding engines on the market at present, I found that they can decode at any angle, such as 10 20 30 80 and so on (tested with a simple pdf417 barcode).
However, at present, the zxing decoding library can only decode pdf417 rotated by 90 180.
I found that zxing can decode qr and aztec at any angle.
Can you provide ideas on how to improve it?

I have been contemplating a rewrite of the PDF417 decoder for quite a while (#145), but I simply don't have the time to tackle that. The current code simply works line-by-line (top to bottom) and while the code is designed to support scanning in an angle (maybe +/- 10°), that will definitively not work for 45° and I fear the implementation as is, does not even cope with 5° reliably.
My idea would be first estimate an angle after having found the finder-pattern on the left and then scan along the upper the border of the symbol. I did already a rewrite of the 'pure' case, which could be a basis for the general case as well.


Kick on ban for entire server group

About the PR

This PR uses postgres notify and listen to notify every game server using the same database of a ban so they can kick the banned player.
PostgreSQL: NOTIFY
PostgreSQL:  LISTEN
Technical details

This works by adding a trigger to inserts on the ban table which calls notify on the BanNotificationChannel with the guid of the banned player.
The PostgresNotificationManager listens on that channel and kicks banned players when it receives a notification.
This makes kick on ban just work™ for any added servers and SS14.Admin.
Video
https://github.com/space-wizards/space-station-14/assets/8915246/f8c361e0-10a7-42ba-a0fb-5578f86a1af7

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Fixes #26199

This is ready for review


Crash when scroll to the latest year

When you scroll to the last year in newest version (1.1.0) the app crashes.

thanks for your effort, i release this fixed version.


[libidn2] update to 2.3.7

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Hm, this robot doesn't look for existing PRs.


Observation.status

Add to guidance:
The result SHALL never be empty. If there is no result, then the result SHALL contain a language specific text that indicates the reason of the missing result.
e.g. result pending, sample not received.

@tomfiers Tom can you please give some more justification for this issue because Nico Vannieuwenhuyze (AMARON) thinks this is a deviation from normal HL7 practice.

I won't comment on how it is transmitted. I trust Nico on that ;)
I'm just concerned with the end result which has to be clear as to why a result is missing: is it because the sample is not received (the specimen status should reflect this too) (and potentially thus never come) ,or is it because the sample is there and the result will be coming.
This is very important information for the receiver.

Comment to Nico Vannieuwenhuyze
The way of working by Tom Fiers is possible in the current definition of the profiles. Tom (as a clinical biologist) thinks this information is clinically important, but the way this is done will be different for every laboratory. Therefore we will keep this in the implementation guide.


⚠ Bofrost.at has degraded performance

In 9a3e529, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1283 ms

Resolved: Bofrost.at performance has improved in b62d299.


Extract separate interface for FileSearchProviderOptions#folderOptions and consider to move pattern into it

Testing #226668
The complete description what to search for is spread out across options#folderOptions and the pattern-argument. During a session, the latter is changing while the former isn't. I wonder if that's an implementation detail shadowing into the API and if pattern should be merged into a "search pattern object"

a "search pattern object" containing info about the pattern, folder, includes, and excludes? I still stand by keeping pattern by itself. In both the Text and File search provider APIs, the first argument is "how to know that something is a match" vs the options contain the details on where to find it and other limitations.

I feel like this issue has the same vibe as this issue, although it's not the same: https://github.com/microsoft/vscode/issues/226814
I believe that, on both sides, it feels motivated by the ambiguity between query/pattern and options. Not sure if this warrants an extra argument or just a different way of organizing info.

the first argument is "how to know that something is a match" vs the options contain the details on where to find it and other limitations.

But aren't those patterns, that are in the options bag, also for "how to know that something is a match". Like, it doesn't help that pattern matches if exclude-pattern don't match. Or did I misunderstand those patterns?

I guess query is mostly the 'within-file' matching parameters, whereas the options control which files we end up looking in. Not sure if that's a valid way of separating them.


Updated all absolute imports to relative imports

Issue #, if available:
Description of changes:

Updated all absolute imports to relative imports

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-637-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-637/1/index.html


Cannot use toltec or opkg

Since I updated my remarkable I have not been able to access the repository or any of the apps.
I found this out when I went to update my packages:
-sh: opkg: command not found
I went to install toltec as I though it might have disappeared with the update. All the files were there. I follow an old guide how to uninstall as toltecctl unistall was not working either. https://github.com/toltec-dev/toltec/issues/295
Reinstalling did not solve the issue, I get this when trying to check for the check sum:
root@reMarkable:~# bash bootstrap
INFO:  Fetching secure wget
ERROR: Unexpected error on line bootstrap:96 in function wget-bootstrap
ERROR: This script failed to install. If you can't solve the above
       issue yourself, please report it at:

           <https://github.com/toltec-dev/toltec/issues>

       (Please also include these error logs to help solving the
       problem faster. Thank you!)
bootstrap: line 60: clean-path: command not found

toltecctl reenable

The error you’re seeing upon reinstalling is #422.

@mioxoim Try running:
sed -i 's/=https/=http/' bootstrap && bash bootstrap

The error you’re seeing upon reinstalling is #422.

Thank you that was the solution!


Flaky: Text file busy (os error 26)

Component
Other (please describe)
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
master branch 0544afd1949e75c4b44370584433f451c80625b9
What command(s) is the bug in?
cargo test --locked --workspace --test '*'
Operating System
Linux
Describe the bug
Similar issue mentioned in #442, but I was unable to consistently reproduce the error.
I setup the environment like this:
docker run -it -v $PWD:/opt/foundry/ rust:1-bullseye

And ran the test suite like this:
root@8ef1dc3ddda5:/opt/foundry# cargo test --locked --workspace --test '*'
   Compiling sha2 v0.9.9
   Compiling tungstenite v0.17.2
   Compiling foundry-cli v0.2.0 (/opt/foundry/cli)
   Compiling reqwest v0.11.10
   Compiling k256 v0.10.4
   Compiling coins-core v0.2.2
   Compiling pbkdf2 v0.8.0
   Compiling tokio-tungstenite v0.17.1
   Compiling ethers-core v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling coins-bip32 v0.6.0
   Compiling revm_precompiles v0.4.0 (https://github.com/bluealloy/revm#211c83ba)
   Compiling revm v1.2.0 (https://github.com/bluealloy/revm#211c83ba)
   Compiling coins-bip39 v0.6.0
   Compiling svm-rs v0.2.9 (https://github.com/roynalnaruto/svm-rs#a128bea6)
   Compiling svm-rs-builds v0.1.0 (https://github.com/roynalnaruto/svm-rs#a128bea6)
   Compiling ethers-providers v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-contract-abigen v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-signers v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-addressbook v0.1.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-contract-derive v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-solc v0.3.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling ethers-etherscan v0.2.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling foundry-config v0.2.0 (/opt/foundry/config)
   Compiling foundry-cli-test-utils v0.1.0 (/opt/foundry/cli/test-utils)
   Compiling ethers-contract v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling foundry-utils v0.2.0 (/opt/foundry/utils)
   Compiling ethers-middleware v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling cast v0.2.0 (/opt/foundry/cast)
   Compiling ethers v0.6.0 (https://github.com/gakonst/ethers-rs#110d1bee)
   Compiling foundry-evm v0.2.0 (/opt/foundry/evm)
   Compiling forge v0.2.0 (/opt/foundry/forge)
   Compiling ui v0.2.0 (/opt/foundry/ui)
    Finished test [unoptimized + debuginfo] target(s) in 1m 27s
     Running tests/it/main.rs (target/debug/deps/it-710d20b40e5989aa)

running 36 tests
test cmd::can_compile_local_spells ... ignored
test cast::finds_block ... ok
test cmd::can_clean_non_existing ... ok
test cmd::can_clean_hardhat ... ok
test cmd::can_clean ... ok
test cmd::can_emit_extra_output ... ok
test cmd::can_execute_run_command ... ok
test cmd::can_init_no_git ... ok
test cmd::can_execute_inspect_command ... FAILED
test cmd::can_execute_run_command_with_args ... ok
test cmd::can_execute_run_command_with_sig ... ok
test cmd::can_handle_direct_imports_into_src ... ok
test cmd::can_compile_without_warnings ... ok
test cmd::forge_utils::tests::foundry_path_ext_works ... ok
test cmd::can_check_snapshot ... ok
test cmd::can_init_non_empty ... ok
test cmd::can_clean_config ... ok
test cmd::can_init_quiet ... ok
test cmd::can_init_repo_repeatedly_with_force ... ok
test cmd::can_init_repo_with_config ... ok
test config::can_set_solc_explicitly ... ok
test config::can_set_yul_optimizer ... ok
test config::forge_utils::tests::foundry_path_ext_works ... ok
test config::can_parse_dapp_libraries ... ok
test test::forge_utils::tests::foundry_path_ext_works ... ok
test config::can_override_config ... ok
test cmd::print_help ... ok
test cmd::can_print_warnings ... ok
test config::can_detect_config_vals ... ok
test config::can_set_config_values ... ok
test config::can_extract_config_values ... ok
test config::can_show_config ... ok
test cmd::can_init_vscode ... ok
test config::can_use_solc ... ok
test test::can_fuzz_array_params ... ok
test config::can_get_evm_opts ... ok

failures:

---- cmd::can_execute_inspect_command stdout ----
thread 'cmd::can_execute_inspect_command' panicked at '

==========
command failed but expected success!

command: "/opt/foundry/target/debug/deps/../forge" "inspect" "Foo" "bytecode"

cwd: root: /tmp/can_execute_inspect_command-0jB3uKo
contracts: /tmp/can_execute_inspect_command-0jB3uKo/src
artifacts: /tmp/can_execute_inspect_command-0jB3uKo/out
tests: /tmp/can_execute_inspect_command-0jB3uKo/tests
libs:
    /tmp/can_execute_inspect_command-0jB3uKo/lib
remappings:

status: exit status: 1

stdout:

stderr: Error:
   0: "/root/.svm/0.8.10/solc-0.8.10": Text file busy (os error 26)

Location:
   cli/src/cmd/utils.rs:104

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

==========
', cli/test-utils/src/util.rs:519:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    cmd::can_execute_inspect_command

test result: FAILED. 34 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 19.73s

error: test failed, to rerun pass '-p foundry-cli --test it'

oh while we fixed the install with an additional lockfile properly, this still can happen when operating on the actual target location /root/.svm/0.8.10/solc-0.8.10

this should be fixed now since we run serial tests now


Applying the optimization options

Change Log
I made changes to the optimization option for release. I don't have any GPU to test the performance gains but these settings are usually good for the speed and the binary size while taking a bit more build time. So, I assume it'd be great to set.

codegen-units to 1
lto to fat

Change Log
I made changes to the optimization option for release. I don't have any GPU to test the performance gains but these settings are usually good for the speed and the binary size while taking a bit more build time. So, I assume it'd be great to set.

codegen-units to 1
lto to fat

Thanks for the commit! I've tested this build configuration, but it results in significantly longer build times without noticeable performance improvements.

Change Log
I made changes to the optimization option for release. I don't have any GPU to test the performance gains but these settings are usually good for the speed and the binary size while taking a bit more build time. So, I assume it'd be great to set.

codegen-units to 1
lto to fat

Thanks for the commit! I've tested this build configuration, but it results in significantly longer build times without noticeable performance improvements.

thanks for the check! As you confirmed, it'd be better not to apply those options.
then, I'll close the PR. thanks for the review!


Getting Error : Not able to get user state and User Attributes after successfull login.

Describe the bug
I am getting Error, after the user successfully login from iOS App.
Issues :

Method

Amplify.Auth.fetchAuthSession { result in
        switch result {
        case .success(let session):
            print("Is user signed in - \(session.isSignedIn)")
        case .failure(let error):
            print("Fetch session failed with error \(error)")
        }
    }

Here the session is returning as true for (session.isSignedIn)
2. Method Amplify.Auth.getCurrentUser()  returning nil
3. returning error
: "Amplify Fetching user attributes failed with error AuthError: Could not fetch attributes, there is no user signed in to the Auth category
Recovery suggestion: SignIn to Auth category by using one of the sign-in methods and then call user attributes apis "
Amplify.Auth.fetchUserAttributes() { result in
        switch result {
        case .success(let attributes):
            print("User attributes - \(attributes)")
        case .failure(let error):
            print("Fetching user attributes failed with error \(error)")
        }
    }

Steps To Reproduce
After user sucessfully login with amplify api, Amplify API does not work as expected
Amplify.Auth.signInWithWebUI(presentationAnchor: vc.view.window!){ result in
            switch result {
                case .success:
                print("\(self.TAG) Sign in succeeded")
                case .failure(let error):
                print("\(self.TAG) Sign in failed \(error)")
                }
        }

Expected behavior
Return user attributes and states

return AuthUser Property from

Amplify.Auth.getCurrentUser()

get user attributes from

Amplify.Auth.fetchUserAttributes() { result in
        switch result {
        case .success(let attributes):
            print("User attributes - \(attributes)")
        case .failure(let error):
            print("Fetching user attributes failed with error \(error)")
        }
    }

Amplify Framework Version
1.28.0
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.0
CLI version
manual
Xcode version
13.4.1
Relevant log output
Amplify Is user signed in - true
Amplify Fetching user attributes failed with error AuthError: Could not fetch attributes, there is no user signed in to the Auth category
Recovery suggestion: SignIn to Auth category by using one of the sign in methods and then call user attributes apis

Is this a regression?
No
Regression additional context
No response
Device
iPhone 13 Pro
iOS Version
ios 15.5
Specific to simulators
No response
Additional context
No response

@harsh62  Thank you for your response.
Please find amplifyconfiguration.json. Feel free to create new user and test
{
    "UserAgent": "aws-amplify-cli/2.0",
    "Version": "1.0",
    "api": {
        "plugins": {
            "awsAPIPlugin": {
                "SampleApp": {
                    "endpointType": "GraphQL",
                    "endpoint": "https://27xj7vwqnzbsbatuywzr74u24m.appsync-api.us-east-1.amazonaws.com/graphql",
                    "region": "us-east-1",
                    "authorizationType": "API_KEY",
                    "apiKey": "da2-cwzecdxdevfnbdfz6sadwdcn5i"
                }
            }
        }
    },
    "auth": {
        "plugins": {
            "awsCognitoAuthPlugin": {
                "UserAgent": "aws-amplify/cli",
                "Version": "0.1.0",
                "IdentityManager": {
                    "Default": {}
                },
                "AppSync": {
                    "Default": {
                        "ApiUrl": "https://27xj7vwqnzbsbatuywzr74u24m.appsync-api.us-east-1.amazonaws.com/graphql",
                        "Region": "us-east-1",
                        "AuthMode": "API_KEY",
                        "ApiKey": "da2-cwzecdxdevfnbdfz6sadwdcn5i",
                        "ClientDatabasePrefix": "SampleApp_API_KEY"
                    },
                    "SampleApp_AWS_IAM": {
                        "ApiUrl": "https://27xj7vwqnzbsbatuywzr74u24m.appsync-api.us-east-1.amazonaws.com/graphql",
                        "Region": "us-east-1",
                        "AuthMode": "AWS_IAM",
                        "ClientDatabasePrefix": "SampleApp_AWS_IAM"
                    }
                },
                "CredentialsProvider": {
                    "CognitoIdentity": {
                        "Default": {
                            "PoolId": "us-east-1:ab09255b-13ec-47fb-b863-208370e3772a",
                            "Region": "us-east-1"
                        }
                    }
                },
                "CognitoUserPool": {
                    "Default": {
                        "PoolId": "us-east-1_YzFpCSndz",
                        "AppClientId": "6uf43jqs99a2tijl9qqd7ke1b6",
                        "Region": "us-east-1"
                    }
                },
                "Auth": {
                    "Default": {
                        "authenticationFlowType": "USER_SRP_AUTH",
                        "OAuth": {
                                                   "WebDomain": "sample-app-stage.auth.us-east-1.amazoncognito.com",
                                                   "AppClientId": "3g0nagu8vl5d2qu5k7tuaf6vi2",
                                                   "SignInRedirectURI":"myapp://signin",
                                                   "SignOutRedirectURI": "myapp://signout",
                                                   "Scopes": ["email","openid"]
                                               },
                        "socialProviders": [],
                        "usernameAttributes": [
                            "EMAIL"
                        ],
                        "signupAttributes": [],
                        "passwordProtectionSettings": {
                            "passwordPolicyMinLength": 8,
                            "passwordPolicyCharacters": [
                                "REQUIRES_LOWERCASE",
                                "REQUIRES_NUMBERS",
                                "REQUIRES_SYMBOLS",
                                "REQUIRES_UPPERCASE"
                            ]
                        },
                        "mfaConfiguration": "OFF",
                        "mfaTypes": [
                            "SMS"
                        ],
                        "verificationMechanisms": [
                            "EMAIL"
                        ]
                    }
                }
            }
        }
    }
}

Response with respect to each method
result of signInWithWebUI -> success

SignInWithWebUI - Success
getCurrentUser - Nil
FetchAuthSession - success (callback is success with isSignedIn -> true)
FetchAttributes - fail (error -> Fetching user attributes failed with error AuthError: Could not fetch attributes, there is no user signed in to the Auth category
Recovery suggestion: SignIn to Auth category by using one of the sign in methods and then call user attributes apis

Closing the issue. @gitton confirmed it was a configuration error on discord.

@harsh62 did not understand. Could you mention where the configuration was wrong? Could not find the details on discord.

@gitton I am really sorry for the confusion. You are correct. Let me investigate this issue. Reopened.

@harsh62  Thank you

@gitton Hi, I know it's been a while since you opened this issue but we're running this same issue on our iOS app currently. I see that you closed this issue but any chance it was closed because you were able to find a solution to it? If so, could you please help out and let me know how you were able to fix this issue?

@sanv725
This issue came up when different AppClientID is used for HostedUI and UserPool. This configuration currently is not supported and breaks the aws-sdk-ios AWSMobileClient implementation.
I'll reopen the issue for our team to prioritize the fix.

Closing. This is no longer an issue in Amplify 2.0.


Automated Package Upgrade

:tada: This PR is included in version 7.7.228 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Extension no longer on Chrome Web Store

Environment details

Operation system: Debian Buster, Chrome 63.0 (Stable)
Extension version: 1.9.0

Expected behavior
Being able to download the extension from the Chrome Web Store ( via URL https://chrome.google.com/webstore/detail/toggl-button/oejgccbfbmkkpaidnkphaiaecficdnfn )
Actual behavior
The Chrome Web Store returns a 404 error.
Steps to reproduce the behavior
Visit https://toggl.github.io/toggl-button/ and click 'Download Extension', or Google 'toggl button' and click on the first result (assuming it's the chrome web store).
Additional details
Seems like the extension no longer exists on the store? :cry:

Is it happening again?


SyntaxError: await is only valid in async function

Running example code from task api doc throw the error: SyntaxError: await is only valid in async function
Steps to reproduce
Just running the following example code:
const { task } = require('folktale/concurrency/task');

const delay = (time) => task(
  (resolver) => {
    const timerId = setTimeout(() => resolver.resolve(time), time);

    resolver.cleanup(() => {
      clearTimeout(timerId);
    });

    resolver.onCancelled(() => {
      /* does nothing */
    });
  }
);

const result = await delay(100).run().promise();
Expected behaviour
Should be run without any error.
Environment
(Describe the environment where the problem happens. This usually includes:

OS: macos
JavaScript VM
Folktale version : 2.3.2
)

Additional information
node v8.12.0

This is indeed confusing :>
Most examples in the Folktale documentation are executed as a part of the automated testing phase. This guarantees that the examples we're putting there actually work when people try to execute them. But asynchronous code is a problem: it's hard to write it in a way that is more-or-less readable for developers. async/await makes that more palatable.
For now, await can only be used inside async functions. There's a proposal to allow it outside of functions as well (https://github.com/tc39/proposal-top-level-await), but that hasn't been implemented yet. This is not very nice for Folktale's docs because code examples aren't generally supposed to provide a function, they're meant to show you how to use an API. So, when running these examples, the test runner just wraps them in an async function, so these top-level await things work.
But if you copy the code as-is and throw it in the REPL or on your own file, it most likely won't. And the error message likely won't be that helpful :')
I'm not really sure how this should be fixed. I suppose a notice could be added on top of each example that does this explaining that top-level await isn't implemented in JS yet.

node --experimental-repl-await

https://nodejs.org/api/cli.html#cli_experimental_repl_await


Laravel 9 support

Seems to work fine with Laravel 9. Can you elaborate what's stopping you? Thanks!

@Tarpsvo I have found the issue that we can not upgrade our projects to Laravel 9.
The reason is because of dependency to lower version of outl1ne/nova-translations-loader package which is ^3.0.0 and in this version there is no support for Laravel 9, so an upgrade to 3.1.4 will fix this issue.
I will send a PR for this.


Rgb images have different resolutions with depth images

Thank you for your good job.
Rgb images have different resolutions with depth images， If I want to align the resolution of two images, do I simply resize them?

Thank you for your good job.
Rgb images have different resolutions with depth images， If I want to align the resolution of two images, do I simply resize them?

Thanks for your attention to our work. In most cases, simple resizing operations can be adopted as a common practice, if your RGB and depth are strictly corresponding (for the totally same image). I don't know your detailed situation or any specific question in our code. For example, a special case might be: if you want to significantly improve the resolution of depth maps (e.g., from 224 to 1080 or higher), simple resizing could cause some blurs. If that is unacceptable in your situation, you can adopt some depth refinement or super-resolution tools for up-sampling.

@RaymondWang987 Thank you for your reply. Do I need to retrain the model if I want the resolution of the output depth map to be exactly the same as the rgb image?

@RaymondWang987 Thank you for your reply. Do I need to retrain the model if I want the resolution of the output depth map to be exactly the same as the rgb image?

For most depth models (e.g., Midas, DPT, or our NVDS), the resolutions of the input RGB image (e.g., inputing $384\times384\times3$) and the predicted depth (e.g., predicting $384\times384\times1$) are the same. In the training stage, input images are resized or cropped to certain resolutions to reduce the computational costs (e.g., GPU memory). In the inference stage, to maintain the best performance, the input images are resized to similar resolutions as the training stage (e.g., $896\times384\times3$, maintaining the aspect ratio of raw images). You can also use the raw resolutions of input images (e.g., $1880\times800$) for inference and the outputs will also be $1880\times800$.
Overall, the models' input and output are in the same resolution. It depends on the specific resolution used for inference. Many models are robust to the resolution changes because training by large-scale datasets or data augmentations. You can directly infer with raw resolutions. If your model is not sufficiently robust to this problem, you can try to train the model with higher resolutions (but also higher training costs) or with data augmentations (e.g., varied resolutions or random cropping).


Create a 'Make me Admin' task

Move / refactor the one in: https://github.com/ULCC/dart_hyrax/blob/master/lib/tasks/ulcc.rake

Moved into JIRA.


update loadUrl to loadURL in file-explorer example

The latest Electron will prompt that loadUrl is deprecated. The new API is
loadURL. We also need to update other samples to use the API instead.

Just the first one need to be merged if accepted.

Thanks for finding it.
I'm not willing to update the new APIs because it is not compatible, which will break the sample running on early versions of electron.

Closing it in favour of #17 .


Allow "go back" on MacOS with a two finger swipe

It would be great to be able to "go back" on MacOS (currently ^ + -) with a two finger swipe, like one can in chrome:

Basically if there is no area on the left to scroll towards, the leftward scroll (or swiping right with two fingers) drags out an arrow, that upon letting go navigates backwards.
I find that this is a critical action for me - I used to use the touch bar on an older mac for it, and a mouse button on a desktop windows PC.
I might remap go back/forward to ctrl + left/ctrl + right, but that does overlap with OS shortcuts for switching between full screen windows.

/duplicate https://github.com/microsoft/vscode/issues/204812

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


feat: Adding support for streamed responses

Closes: https://github.com/lostisland/faraday-net_http_persistent/issues/5
This adds support for a streamed response and is based on the
implementation I saw https://github.com/lostisland/faraday-net_http/blob/9534fd19bd4898f28361ea60dbc3867edadc15ad/lib/faraday/adapter/net_http.rb#L106-L120
The tests are all passing (Yay), I also ran the steps to reproduce provided by @wconrad (Thank you so much, this helped a bunch) locally & had the result (I also tried a few other links, though I didn't check any massive files):

My manual tests look good.  I tested this feature against a get of a largish (12 MB) file.  The size and md5sum were the same for all of these tests run against this feature branch:

no persistence, streaming
persistence, streaming
persistence, not streaming

You guys are truly awesome.  Thanks @iMacTia and @MikeRogers0 !


🐛 Bug Report: Scaffolder EntityFields use humanizeEntityRef for form data as an identifier

📜 Description
While trying to work on a solution for https://github.com/backstage/backstage/issues/15987, I tried to update humanizeEntityRef to return title instead of name. This caused the OwnerPicker and OwnedEntityPicker to use the humanized version instead of the ID, causing weirdness when trying to standup components and during API requests.
👍 Expected behavior
The form should use stringifyEntityRef or pass an entity object through the form instead of using humanizeEntityRef. It should display a human readable name for the object.
👎 Actual Behavior with Screenshots
The form uses whatever is in the TextField as the form value.
👟 Reproduction steps
Update humanizeEntityRef to include non-identifier attributes. The form picks up those attributes.
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Ah yep, OwnedEntityPicker should be updated to pass through the full entity ref in the onChange callback. Do you want to contribute a fix for that?

Happy to, I was already taking a look and ran into the issue of free solo entry. Basically, we're allowing any text to be entered by default. Any preference on how to go forward on that? Current thinking is just to attempt to parse it into an entity ref with the defaultKind and defaultNamespace provided by the form.
https://github.com/backstage/backstage/blob/master/plugins/scaffolder/src/components/fields/EntityPicker/EntityPicker.tsx#L95


Anyone working on kafka sink?

Hi, I am interested in working on a substreams sink for kafka. I started but want to check if anyone has already been working on it. I will contribute if no one is currently building it.

We have not been working on a Kafka integration. Contribution is welcomed!


undefined is not an object (evaluating 'f.forEach')

后台无错误，前台访问的时候报
undefined is not an object (evaluating 'f.forEach')
undefined is not an object (evaluating 'B.length')

升级版本试试


ReactiveX - use in UI

Suggest to mark this one as closed. We use ReactiveUI to make our view-models reactive, for example:

CreateViewModel
https://github.com/SergeyDavidovich/OMSBlazor/blob/127696762f7fa748337642dce2418b90e6a21092/src/OMSBlazor.Blazor/Pages/Order/Create/CreateViewModel.cs#L22
JournalViewModel
https://github.com/SergeyDavidovich/OMSBlazor/blob/127696762f7fa748337642dce2418b90e6a21092/src/OMSBlazor.Blazor/Pages/Order/Journal/JournalViewModel.cs#L14

Also we use ReactiveUI to crate observable streams, for example here we create Observable that set OrderDate if either Employee, Customer or some product was added to order during the process of creation:
https://github.com/SergeyDavidovich/OMSBlazor/blob/127696762f7fa748337642dce2418b90e6a21092/src/OMSBlazor.Blazor/Pages/Order/Create/CreateViewModel.cs#L90


Change Firebase Functions from v1 to v2

Intro
We are currently using Firebase Functions to handle critical backend workflows, including:

saveRoleToFirestore: Saves user roles to Firestore.
deleteUserDocument: Ensures GDPR compliance by deleting user documents upon account deletion requests.
createStripeCheckoutSession: Integrates with Stripe to handle payment workflows by creating checkout sessions.

While these functions have been reliable, they are currently using Firebase Functions First Generation, which may pose limitations as our system scales.
Why
GCFv1 is not deprecated yet, but GCFv2 is the recommended platform for new and updated features, ensuring long-term compatibility and support.
Let’s prioritize this migration to stay ahead and deliver a seamless experience for our users. 🚀

So, the first two functions, we still don't have support for v2. We will continue as it is.
The last one we just changed the type from callable to HTTPS.
We will, too, change the stripeFunction to it's onw file.


Switch from bitbucket to github and update version to 2.0.5

Checklist

[x ] Used a personal fork of the feedstock to propose changes
[ x] Bumped the build number (if the version is unchanged)
[ x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


What are the steps to reproduce?
Include a colon in commit message e.g. "broadlink: learnt all buttons"
What happens?
The commit message is not show in the history panel
What do you expect to happen?
The commit message should be shown
Please tell us about your environment:

[x] Node-RED version: v1.3.5
[ ] Node.js version:
[ ] npm version:
[ ] Platform/OS: Proxmox VM: Ubuntu 20.04 NR via docker-compose
[ ] Browser: Chrome 87.0.4280.141

Duplicate of #3006
Already fixed. Will be in 1.3.6 and 2.0


datasource dev mode

hi ,  i just cloned your work to see what it can be done.
and trying to run springBoot ,  i had a problem with datasource that could not autowire.
can you give us the way i can fix this ?
thanks

Hi,
this project is still a work in progress and I'm surprised that anyone
would want to use it without even knowing what it does.
Anyways, IntelliJ (if you're using that, which you should) is convinced
that the DataSource is not an available bean, but it actually is. Run the
project using gradle bootRun. Also make sure you have copied
application.properties.example in the root folder to
application.properties and filled in your correct (My)SQL credentials.
-- Above message was sent from my mobile phone. There may and will be all
kinds of errors included.
On 15 Mar 2016 16:10, "islam drissi"<EMAIL_ADDRESS>wrote:

hi , i just cloned your work to see what it can be done.
and trying to run springBoot , i had a problem with datasource that could
not autowire.
can you give us the way i can fix this ?
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/xxyy/tingo/issues/1

Is this still an issue? If not, please close this.


Credential input broken when importing multiple repos

When importing multiple repos that require username/password, it will ask for multiple usernames on the same line and everything will get out of wack.
This seems to be fixed by passing -w 1 to the import command to make it only use 1 thread. Can 1 thread be changed to be default?

This looks like a duplicate of #23. If you agree please close the ticket. Otherwise please consider providing a PR to add support for stdin handling.

Yes, looks like a duplicate, I'll see if I can figure out a better way to handle stdin, though it does work fine if there is only 1 worker thread.

The next version will allow to specify the number of worker threads on the command line. See 89b92b9ec03dc0a766e8e1d06203ac03dcc8546d

Yeah, using -w 1 fixes it, that's why I was asking for that to be the default at least for import. I'll take a look and see if there is a way to fix it with mutexes or something. The issue seems to be from the multiple git workers clobbering eachothers stdout.

Imo the common case is that users doesn't enter the credentials manually everytime. And in that case the performance improvement of using multiple worker threads is significant.


My resources page optimization

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[x] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

In order to see a noticeable improvement in page loading time for my resources page, You need to have at least 50 resources. If you have 50 or more resources locally, make a note of page loading time for my resource page with your current working branch. Also make a note of loading time for a specific resource landing page. Then switch to branch '3211-my-resources-optimization' branch. Again load my resources page and compare the page load time with the one you noted earlier. You should see at least 30% improvement in page loading time. Use the same resource for landing page loading time comparison and you should see some improvement here too.

@cuahsimarko, @sblack-usu and @Maurier I have created this PR to get some initial feedback on the changes I have made to improve page load time.

Awesome, I will try to get time to review early this week.

@pkdash - do you have any metrics for how much this improves the response time?

@sblack-usu I don't have exact numbers for the improvement in response time yet. I was mostly looking at the browser response time as I was modifying the code for optimization.

@pkdash Some marginal improvements from what I can observe locally, plus it's just cleaner code now. I'll let Scott approve - looks good.

It seems DB queries are not that expensive compared to the number of records that the template engine need to process. For 100 resources it should take around 10 sec to load. Page load time seems to be directly proportional to number of resources the template engine has to process.

I will be cleaning up this PR in day or two.

@pkdash - that is consistent with what I was finding when profiling my-resources.  One thing I was kicking around is putting the my-resources listing call into a separate response from the initial one.  Then it could feed the list of resources in chunks, allowing the my-resources page to begin rendering sooner.

that may make it hard to handle filtering, but I haven't looked into it yet.

@sblack-usu Feeding it in pieces/lazy loading complicates the sort by

@cuahsimarko... couldn't we just block filtering/sorting until the whole list is loaded?

@sblack-usu technically yes, the implementing engineer would obviously need to run by stakeholders. Also, the changes on back/front to get that working are the reason why I deferred work on that task for now, effort vs edge case (low/mid priority of having over 40 resources)... since 40 resources is generally ok, especially with Pabitra's changes. The original performance concerns were sparked by a total nonexistent/edge case, where 400 resources were present.

If we want we can do the sorting at DB level if that would help lazy loading on front end.

@cuahsimarko and @sblack-usu The changes I made last night causing some test to fail. I know why they are failing and should easily be fixed. The code changes that I made for accessing the resource 'metadata' property seems to improve page load time that is noticeable. We should be able to get 100 resources now in 6-7 secs down from 10-12 secs. This is what I got in my local dev environment. I would expect better results in production environment.

@pkdash understood. @sblack-usu @Maurier - Alva just gave me some great insight into what's going on here. After this PR wraps up, please reach out to me directly, if you are going to spend any more time on this issue. I want to avoid overlapping efforts.

@cuahsimarko I have no plan to work on my-resources page after this PR.

@sblack-usu This is now ready for another round of review. With the latest code changes in this PR, one should see noticiable improvement in my resources page loading time.

@sblack-usu I think I have now addressed your comments/concerns.


ESC button behavior is unpredictable in message editing and viewing source

Go to an old message and narrow to that topic. For example testing123.

Click any message and look at its source.

Now press ESC. This brings you back to the homepage. This shouldn't happen and should only close the viewing source ideally.

Not sure if this is supposed to happen or that it is actually a feature because when you view a source, the CLOSE button is automatically selected and you can press enter to exit viewing source.

This sounds like a bug to me.  It's true that ESC is supposed to take you Home in certain situations, but we should have it do the correct thing locally for things like editing messages.

Agreed.  One thing which is interesting here is that you can have multiple message edits open at a time, and also the compose box open, so we'll need to be thoughtful about the exact semantics.  Maybe something like:

If focus is in compose, it closes compose
If focus is in an edit box, it closes that edit box
If focus is not in any of those places (or some other open modal, etc.), it unnarrows

So the change would be just adding that middle piece.

@zulipbot label "help wanted"

@synicalsyntax I just tried adding the "help wanted" label and it seems like zulipbot is throwing an error.

@zulipbot label "help+wanted"

@zulipbot label "bite size"

That's interesting... taking a look right now

@zulipbot label "help wanted"

@zulipbot claim

@zulipbot label "help wanted"

Claim seems to be working but not the label function; @timabbott Do you mind removing the "in progress" and unassigning me from this issue?

@zulipbot label "area: message view"

@zulipbot label "bug"

@lonerz Issue found; there are too many issue labels, and @zulipbot is only receiving the first page of labels in the repository; implementing fix now!

@zulipbot abandon

@zulipbot claim


i have to enable usb tethering on my phone to use scrcpy otherwise it wont open

Ok nevermind I found the fix for those who may also have an issue of srcrpy not opening try doing this, go to developer option, scroll down to Networking then find; use USB connection for, depending on phone may change i would suggest selecting MIDI device (record and listen to music from the connected device) you can try other options if needed.


Enable Shades dimming on all types of displays (not only AirPlay ones)

Before opening the issue, have you...?

[X] Searched for existing issues

Is your feature request related to a problem? Please describe
I use a TV as a monitor. This device doesn't have DDC control so my only option is software dimming.
The problem arises when I want to use Gamma dimming with f.lux, that also modifies gamma values.
By using Shades dimming, I could use MonitorControl alongside f.lux (f.lux to change display temperature, MonitorControl to dim the display using shades).
Describe the solution you'd like
I'd like to use f.lux to modify the external display temperature using gamma values, and dim the display using Shades.
The MacBook's internal display should be modified by f.lux via gamma, and via the native Apple brightness adjustments.
Describe alternatives you've considered
Currently I'm using f.lux with QuickShade, but the issue is QuickShade doesn't have a per display dimming option so it also dims my MacBook display via software (unnecessary).
Anything else?
No response

Yes, this is a logical idea and could be implemented quite easily with a simple checkbox in Displays.

Yes, this is a logical idea and could be implemented quite easily with a simple checkbox in Displays.

That's great news! I'll be looking forward to it.
Thank you!

You'll be able to toggle this with the 'Avoid gammatable manipulation' checkbox. Please be aware that with shade based dimming the mouse cursor will be exempt and upon entering/exiting full screen mode in an app, the app will briefly light up as the shade cover fails during the transition.

Wow that was quick!
I donated and translated the app to my language, thank you!

Thank you! :)


Location column is incorrect in node template

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Create some DO/AWS node templates
The location region has same values as the Size.
This is seen on 2.5.3 also

Expected Result:
Location column should have the location selected during node template creation.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.4-rc5 and 2.5.3
Installation option (single install/HA): Single/HA (any)

This bug is present in v2.5.5 but fixed in rancher:master-head (d1395c3)

This bug is present in v2.5.5 but fixed in rancher:master-head (d1395c3)

The issue was visible in rancher 2.5.6-rc2 but it is fixed in 2.5.6-rc4.

@bmdepesa May we close?


Azure Monitor Ingestion: Update format using spotless

This PR enables spotless code formatter for Azure Monitor Ingestion. This PR only contains formatting changes.

API change check
API changes are not detected in this pull request.


dummy update for base image rebuild

For https://github.com/open-cluster-management/backlog/issues/11044

This won't fix the image vulnerability. Check the quay.io image scan here: https://quay.io/repository/open-cluster-management/search-operator?tab=tags

@jlpadilla Thanks, Passed after I added the microdnf update. Do we need to update downstream too?

I don't know if we are currently using microdnf update in the downstream images.  There has been conflicting guidance, the last I saw as of last week was to not do the update and wait for the base image to get updated.
Downstream is easier to trigger a rebuild of all the images, so it's less painful than upstream.

/approve
/lgtm


feat: add more kcl artifacts including version 0.4.5 and update readme.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

feat: add more kcl artifacts including version 0.4.5 and update readme.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.803%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2666

Relevant Lines:
5577

💛  - Coveralls


makima: 0.8.4 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cyber-sushi/makima/releases.
meta.description for makima is: Linux daemon to remap and create macros for keyboards, mice and controllers
meta.homepage for makima is: https://github.com/cyber-sushi/makima
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.8 with grep in /nix/store/j2jxk0ww6amaipxqqb3s58gb3d74vica-makima-0.8.8
found 0.8.8 in filename of file in /nix/store/j2jxk0ww6amaipxqqb3s58gb3d74vica-makima-0.8.8

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

makima

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j2jxk0ww6amaipxqqb3s58gb3d74vica-makima-0.8.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A makima https://github.com/r-ryantm/nixpkgs/archive/44142f131858c9e7110b04233a8c2d74674c0a77.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/44142f131858c9e7110b04233a8c2d74674c0a77#makima

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j2jxk0ww6amaipxqqb3s58gb3d74vica-makima-0.8.8
ls -la /nix/store/j2jxk0ww6amaipxqqb3s58gb3d74vica-makima-0.8.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

makima

Maintainer pings
cc @bytesudoer for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cyber-sushi/makima/releases.
meta.description for makima is: Linux daemon to remap and create macros for keyboards, mice and controllers
meta.homepage for makima is: https://github.com/cyber-sushi/makima
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.1 with grep in /nix/store/89kbqddhl9w12hp67bnkcv6ki9inwfa9-makima-0.9.1
found 0.9.1 in filename of file in /nix/store/89kbqddhl9w12hp67bnkcv6ki9inwfa9-makima-0.9.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

makima

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/89kbqddhl9w12hp67bnkcv6ki9inwfa9-makima-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A makima https://github.com/r-ryantm/nixpkgs/archive/287072e003869cf6352383273268a2cf78824aa1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/287072e003869cf6352383273268a2cf78824aa1#makima

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/89kbqddhl9w12hp67bnkcv6ki9inwfa9-makima-0.9.1
ls -la /nix/store/89kbqddhl9w12hp67bnkcv6ki9inwfa9-makima-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

makima

Maintainer pings
cc @bytesudoer for testing.


Move our demo videos for build node to youtube channel (Steve Taylor to help)

We should add an Events menu item on the main navigation.  The Events page would have the upcoming and past events/recordings.
One idea is to include the YouTube playlist into Events page.


when i try to run tensorrt demo with yolox-tiny, i got a wrong result

./yolox ../model_trt.engine -i ../../../../assets/dog.jpg blob image 3ms num of boxes before nms: 67359

what's your converting command?
Also notice that yolox-nano and yolox-tiny have a default size of 416, thus you may have to change the input size in the yolox.cpp

@ruinmessi emm,i forgot to change the input size.


[Request] set color() silently

Hi,
i can change picker color programatically by
picker.color = [205, 220, 57];  // set color

I need something like
picker.colorSilent = '' ;  // set color , do not trigger change event !!!

OR
picker.color = '';  // set color empty string
// change event is triggered
//  should return color as empty as well,  instead of black color

Is there a way to set color silently so that handle and canavs are updated but change event is not triggered.
I am trying to implement Clear and Cancel  functionality and when i click on  Clear button , i set picker.color='' //empty ''' but picker triggers change``` and sends me back black color hex.
It will be helfpful if either change event send color as empty string or null if set picker.color='' //empty '''   Or If I am able to set color silenty without triggering change``` so i can set value of colro to empty string internally.
I hope you understand my issue :)

v1.2.1
const a = AColorPicker.createPicker({});
a.setColor('red', true); // change event is not triggered

Thanx . now works flawlessly.
Can you please add this pen in examples as this may help some users
a-color-picker qtip2 Integration
https://codepen.io/mafar/pen/XWromjQ?editors=0010


Change cat name

After recent events it is probably better to use a different name for the cat.
I just picked a popular cat name to use.

:confused: Thanks. I actually have a real cat named this, and we have exactly the same conflict. Appreciate you noticing this and stepping up to contribute.


scroll top not working in mobile view with swipe tab

Description
Scroll TOP/Bottom and no any anchor tag works within in tab content with swipe tab.
Repro Steps
Layout the steps to reproduce your issue.
Use this Codepen to demonstrate your issue. http://codepen.io/Dogfalo/pen/xbzPQV
Screenshots / Codepen
Add supplemental screenshots or code examples. Look for a codepen template in our Contributing Guidelines.

Provide a real description. Screenshots, codepen, examples, full description of your issue, etc. Feel free to reopen once you done that.


Automated cherry pick of #2469: Bug fix in adding iptable rules * bug fix in

Cherry pick of #2469 on release-1.1.
#2469: Bug fix in adding iptable rules * bug fix in
For details on the cherry pick process, see the cherry pick requests page.

/test-all /test-ipv6-all /test-ipv6-only-all

/test-conformance
/test-e2e
/test-networkpolicy


Simplify oembed dict missing key fallback

Minor cleanup of fallback to empty string using the default fallback of dict.get.
This could also be written as oembed.get('title') or '' if None values are prohibited. However that would be a change is behaviour. They way it is written now, None values can pass through if the key is present in the oembed dict and the value is None.

(Test issues are fixed by updating from main, 421bcbf9c33b0f9e5a0169c6fff6b30d8e85cce9)

I didn't know wagtail also changed to main. I basically came across this bit of code by Google'ing for the Wagtail oembed provider. which pointed me to master.

I've properly rebased now, so the CI should pass 🤞

Thanks @jaap3!


Plugin is not working in OS X/Chrome

OS X Version: : 10.10.5
Chrome: Version 60.0.3112.101 (Official Build) (64-bit)
Symptoms:
The icon keeps spinning but there is no pop up coming up to ask the location access.
In the meantime the same machine has no issues using this:
https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation
So I think there's something wrong with the plugin.

Hmm, it works on my machine. Do you see any errors in the console?

@domoritz Thanks for the reply. Yes, I know found out that it also works on my machine too, however compared to my linux machine or my mobile device it is painfully slow ( spinning for like 30seconds ) before I finally get a location.
Have you experienced something like this in Mac before? I tried enabling/disabling highAccuracy but got similar results.

Hmm, I haven't had problems like that before. I'm surprised that the problem only occurs with my plugin as I am just calling the browser's location API.


Fix issues in CI

Description
Tests failing:

General, PyTorch dismissed the _accumalte function we were using in data/datamodule.py

I added the function explicitly in the datamodule file

On MacOS 14 because it doesn't support some device-related function anymore apparently

This addresses #128
TODO
Check if tests succeed
Status

[ ] Ready to go

The problem should have been fixed in PyTorch from version 2.1 in https://github.com/pytorch/pytorch/pull/111576
The test env installs PyTorch from conda-forge. Probably doing it from the PyTorch channel would give the latest pytorch where
the device issue has been solved
EDIT
I tried to use the latest version of PyTorch, as they apparently addressed the problem, but it didn't change much for us.
For now, I would test it on MacOS-13 and leave an open issue to remember to change it in the future when the 14 becomes stable again.


Angular 14 support

Hello,
Any plans to support Angular 14.x.x?
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/common npm ERR<EMAIL_ADDRESS>from the root project npm ERR!  npm ERR! Could not resolve dependency: npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@avivharuzi/ngx-seo npm ERR<EMAIL_ADDRESS>from the root project
Thanks!

Updated to version 14 to support Angular 14


Opensuse support

Hello,
Can you please add opensuse support? I think your script is great.
Thank you.

Hello, a version for OpenSUSE will be available soon. Thanks for using DNSCrypt-Loader.

You might want to use opensuse build service https://en.opensuse.org/Portal:Build_Service

Cool, thanks for the tip. I'll create a package for openSUSE soon

Thanks! Would you mind replying to this thread when you do? It would be great!

No problem I will notify!

BTW Opensuse build service creates packages and repos for all distros. It could make your work easier.

Hello, rpm packages are available for download. Take a look at the installation guide . Thanks for the tip.

Thank you!


Heroku run php artisan db:seed ERROR

Hi friends,
I am working with Heroku and Laravel using Faker lib and an errors appears when try to do db:seed:
$ heroku run php artisan db:seed
Running php artisan db:seed on jaquenews... starting, run.2196 (Free)
Running php artisan db:seed on jaquenews... connecting, run.2196 (Free)
Running php artisan db:seed on jaquenews... up, run.2196 (Free)
**************************************
*     Application In Production!     *
**************************************

 Do you really wish to run this command? (yes/no) [no]:
 > yes
yes

Seeding: UsersTableSeeder

  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Class 'Faker\Factory' not found

Hi, I don't use or maintain Heroku or Laravel, I invite you to open an issue on their repo.

okay, thanks


chore: fix dep dependency usage

What

packages/scanner/shared/pubspec.yaml removed camera_platform_interface since camera (package above) imports it already
packages/smooth_app/pubspec.yaml removed camera and camera_platform_interface as both are imported by /scanner/shared

Why
I couldn't run pub get anymore. Do to multiple reaons one of them beeing that we had multiple package imports which had different commit hashes resolved. Tidied up the whole thing while fixing this.

There seems to be something really of with the deps on my side, I'm going to further investigate


Service discovery for databases

Service discovery for databases doesn't include the type of database (e.g. mssql, PostgreSQL, ...)
Proposal
The service discovery for databases can also use the SERVICE__ prefix.
This means CONNECTIONSTRING__USERS becomes SERVICE__USERS__CONNECTIONSTRING.
The __PROTOCOL suffix can then be used to indicate the type of database: e.g.: SERVICE__USERS__PROTOCOL=postgresql.
An extension method can be added on IConfiguration to GetServiceProtocol.
cc @rynowak @jkotalik @davidfowl

What does your tye.yaml look like for this? I think adding that extension method makes sense, however I think we'll need to require people to specify the protocol rather than trying to infer it from the connection string, ex:
- name: postgres
  image: postgres
  bindings:
    - port: 5555
      connectionString: <connectionstring>
      protocol: postgres

The CONNECTIONSTRING__ convention predates Tye. I don't think we would want to remove that from the system as it fits nicely with how people do it today without them needing to change. Adding the others as well though is also possible.
Do you have some specific way of using this in mind?

I think we'll need to require people to specify the protocol rather than trying to infer it from the connection string

Agree. Infering is not needed. And protocol is not mandatory.

Do you have some specific way of using this in mind?

Pick the proper EF Core provider based on GetServiceProtocol(...).


Display values with 3 decimal places, including trailing zeroes.

Documentation Is:

[X] Missing or needed?
[ ] Confusing
[ ] Not sure?

Please Explain in Detail...
I want to display trailing zeroes for the 3 decimal places as y-value, but I am unable to make it work.
If there are numbers after the decimal point, it will be displayed, but if they are all zero, it disappears from the label section.
I'm using 4.1.2v.
The data structure is as follows.
data: {
    labels: dataLabels,
    datasets: [{
        label: 'xxx',
        data: data1
    }]
}

data1 = [
    "33.000", "33.000", "100.000", "200.000"
]

If there is a good solution, please let me know. I have tried the following.
・ the method of using the ylabel value in the tooltips callbacks with tofixed(3)
In my case, The tooltips callback did not pass the debug in the first place.
https://stackoverflow.com/questions/59825771/chartjs-is-stripping-trailing-zeros-in-decimal-datasets
https://www.chartjs.org/docs/latest/configuration/tooltip.html#label-callback
https://stackoverflow.com/questions/48038278/chart-js-not-showing-last-zero-in-a-decimal
https://github.com/chartjs/Chart.js/issues/5282
Your Proposal for Changes
If possible, I would like an option that doesn't eliminate trailing zeroes or an option to display the data as is without any modification when displaying.
Example
No response

Thank you for your response. I would like to try it, but since there is no request to format this time, I will close this issue for now. Thank you!


add container registry secret generation v1 param support

bring back support for container registry secrets from v1
V1 supported generating a dockerconfigjson secret automatically from parameters passed to the action (container-registry-url,container-registry-username etc.), and in v2 that was changed to requiring users to add their own secret data manually. This made our most common use pattern, container registry secret creation, significantly more complex as the user has to go run kubectl outside the action to generate a secret every time.
This PR adds support for the original flags while retaining the observability improvements provided in v2 by encoding the dockerconfigjson within the javascript and avoiding wrapping kubectl commands.
Data generated from the container registry credential flags overwrites any supplied data or stringData.

as these changes will now change the default secret type back from generic to a container registry secret, we may need to already jump to v3 since current users could be using the default generic secret type and these changes would be breaking to that use case


Add supporting of custom fdl domain

Add supporting of custom fdl domain

Updated with a tiny change.
Please take a another look and I'm going to merge it. Thank you!

LGTM


Goodwinxp master

A reference to a related issue in your repository.
A description of the changes proposed in the pull request.
@mentions of the person or team responsible for reviewing proposed changes.

update

update


Change AbilityData::footprint_radius to be the actual width/height

In short term, could just do footprint_radius * 2, and assume that is width/height?

This issue was referenced in a PR which is already merged.
Was this solved?


Update builds for 6 1

Merged because its more green than currently, but need to fix that last spec this weekend, as well as solve the assert no error issue, to get a release out.


Overzealous Warnings: Unreachable statement

Godot version:
3.1.1
OS/device including version:
Linux PopOs
Issue description:
return in a match statement does not make the code beneath it unreachable, yet the compiler seems to think it does.
Steps to reproduce:
func on_card_selected(x,y):
	match card_at(x,y).ctype:
		CardInfo.CType.WALL:
			return

	meeples[current_player].slide_to(x,y,card_sz)
	current_player = (current_player + 1 )%4

gives this warning.
W 0:00:00:0777   Unreachable code (statement after return) in function 'on_card_selected()'.
  <Source>       game.gd:60

Minimal reproduction project:
To get this match statement

Duplicate of #30458


The Git Viewlet refreshes when doing file operations outside of the main folder

Testing #29176

on Windows
open a folder working_dir that is using .git
add an unrelated root folder
in the explorer, copy-paste a file
observe how the git viewlet refreshes, even though nothing happened in working_dir.

fyi @jrieken -- I'm not sure what the root cause of this could be (w.r.t. file events), I would assume the git extension (being correct in the single folder case) would not suffer from this issue.

Yeah surely related to the API: https://github.com/Microsoft/vscode/blob/master/extensions/git/src/model.ts#L379

No, the API just forwards whatever comes from the backend. Surely file watcher related.

This is what I see in the file watcher logs when running via --verbose:
[IPC Library: Watcher] [CREATED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher] [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [ADDED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher] [DELETED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher] [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [DELETED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher] [CREATED] c:\Users\daimms.REDMOND\Documents\dev\test-folder\gulpfiles.js
ipc.cp.ts:164 [IPC Library: Watcher] [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\test-folder\gulpfiles.js
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [ADDED] c:\Users\daimms.REDMOND\Documents\dev\test-folder\gulpfiles.js
ipc.cp.ts:164 [IPC Library: Watcher] [CREATED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher] [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [ADDED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher] [DELETED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher] [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [DELETED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git\index.lock
ipc.cp.ts:164 [IPC Library: Watcher]  >> normalized [CHANGED] c:\Users\daimms.REDMOND\Documents\dev\vscode\.git

The .git and .git\index.lock events are fired because of vscode pinging for git status periodically, and the ignore pattern includes:
"**/.git/objects/**": true,
"**/.git/subtree-cache/**": true

Also what does it mean for the git viewlet to refresh? The progress bar up the top showing?

Note that I already ignore the right stuff:
https://github.com/Microsoft/vscode/blob/master/extensions/git/src/model.ts#L631

Here are my expectations:

1. When working with two folders using two separate VS Code windows

Open a window with a folder A with a git repository
Open another window with a different folder B without a git repository
Configure the windows to be shown side-by-side
Create a new file in folder B
Observe: the git viewlet in folder A does not refresh (the icon does not change to indicate refreshing); there is no CPU or FS burden on my machine because I am not touching something impacting folder A. This is correct.

2. When working with two folders using a single VS Code window

Open a window with a folder A with a git repository
Add a root folder B without a git repository
Create a new file in folder B
Observe: the git viewlet refreshes (the icon changes to indicate refreshing); there is CPU and FS burden on my machine for no good reason. This is unexpected.

Since the git extension functions correctly in the single root folder case and does not consume needless CPU when editing files in a different folder, I would expect the git extension to continue functioning correctly and not consume needless CPU also in the multi root folder case. That's why I pinged @jrieken as this is IMHO a breaking change: here is a case where an extension is broken by the multi-root case through the seemingly innocuous file watching API.

Here are gifs for your convenience demonstrating the problem (hopefully this helps in reproducing):
1. Observe no git process is executed

2. Observe the viewlet gets updated and git processes are executed

This issue is about two things:

the git extension needs to change something (of course it will at one point)
but also about that all the extensions that use the vscode.d.ts file watching API and that operate correctly on a single folder case, no longer operate correctly on the multi folder case.

Tricky. The API was always about full file paths  and never scoped to the root path, workspace, or anything. From https://github.com/Microsoft/vscode/issues/20184 @joaomoreno could have known that, tho I guess, like most others, the fix was to the watch for **/myfiles instead of ${rootPath}/myfiles.

I am not very keen on adding a second file watcher API for the multi-root-case but what we could do is to have a new option to watch only on files in the rootPath. That option would be on by default to get the behaviour we have today. Extensions that do support multi-root must flip that option (or maybe we flip it depending on the vscode-version they program against?). Still, a little error prone tho. At the end it's a behavioural change in our system and we somehow need to make sure extension authors understand that and adjust their extensions accordingly...

I suggest to filter out file events for file which are not belonging to the workspace. Today you can end up receiving them by:

open a file which is not inside the workspace
change the file while it is open

I am not sure about multi-root though. We could introduce a new option to opt-in to getting those events, but imho eventually the default should be to get these events.

This has nothing to do with workspaces but rather with the ability to create a watcher for arbitrary folders. The git repository root may not be a workspace folder, nor even within the workspace!
Closing as a duplicate of #3025, since that fix would fix this


Replacing wrong value in EXML using PRECEDING_KEY_WORDS as a search method, find result before PRECEDING_KEY_WORDS not after

In your ModScriptCollection you have a Demo Script called "UnlimitedHyperDriveDistance_UnlimitedJetPack_ZeroLaunchCost"
[ I have tested this extensively even with another person LUA from the nexus with the same result (Nexus Link: https://www.nexusmods.com/nomanssky/mods/918 ) ]
Code Part Causing the issue:
						{
							["SPECIAL_KEY_WORDS"] = {"ID","HYPERDRIVE",},
							["PRECEDING_KEY_WORDS"] = {"Ship_Hyperdrive_JumpDistance",},
							["VALUE_CHANGE_TABLE"] 	=
							{
								{"Bonus",	"9000000"}, 	-- Original "100"
							}
						},

Result:
NMS_REALITY_GCTECHNOLOGYTABLE.EXML
Lines: 3912 - 3934
      <Property name="StatBonuses">
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive" />
          </Property>
          <Property name="Bonus" value="9000000" />
          <Property name="Level" value="1" />
        </Property>
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive_JumpDistance" />
          </Property>
          <Property name="Bonus" value="100" />
          <Property name="Level" value="1" />
        </Property>
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive_JumpsPerCell" />
          </Property>
          <Property name="Bonus" value="1" />
          <Property name="Level" value="1" />
        </Property>
      </Property>

Expected Result:
      <Property name="StatBonuses">
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive" />
          </Property>
          <Property name="Bonus" value="1" />
          <Property name="Level" value="1" />
        </Property>
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive_JumpDistance" />
          </Property>
          <Property name="Bonus" value="9000000" />
          <Property name="Level" value="1" />
        </Property>
        <Property value="GcStatsBonus.xml">
          <Property name="StatsTypes" value="GcStatsTypes.xml">
            <Property name="StatsType" value="Ship_Hyperdrive_JumpsPerCell" />
          </Property>
          <Property name="Bonus" value="1" />
          <Property name="Level" value="1" />
        </Property>
      </Property>

Changing the LUA to use this will make it get the desired effect:
						{
							["SPECIAL_KEY_WORDS"] = {"ID","HYPERDRIVE",},
							["PRECEDING_KEY_WORDS"] = {"Ship_Hyperdrive_JumpDistance",},
                                                        ["VALUE_MATCH"] = "100",
							["VALUE_CHANGE_TABLE"] 	=
							{
								{"Bonus",	"9000000"}, 	-- Original "100"
							}
						},

Even though I was able to do it using that, I assume since your own Demo Script Collection has the first code, it is not supposed to be doing that.
This is easy to duplicate this result by using the Unmodified version of the "UnlimitedHyperDriveDistance_UnlimitedJetPack_ZeroLaunchCost" file in the ModScriptCollection and extracting the PAK and then extracting the NMS_REALITY_GCTECHNOLOGYTABLE.MBIN under METADATA\REALITY\TABLES

This is easy to duplicate this result by using the Unmodified version of the "UnlimitedHyperDriveDistance_UnlimitedJetPack_ZeroLaunchCost" file in the ModScriptCollection and extracting the PAK and then extracting the NMS_REALITY_GCTECHNOLOGYTABLE.MBIN under METADATA\REALITY\TABLES

For info, you know you can always find (for the last script processed) all the MODDED EXMLs in the folder EXML_Helper\MODDED with the ORIGINALs in EXML_Helper\ORG_EXML folder.  No need to do the "extracting / decompiling" yourself.

And putting any pak(s) in ModScript, without any script in the folder, will unpak / decompile it/them and save the results in a folder named for each pak in folder UNPACKED_DECOMPILED_PAKs.
And by any pak, I mean any.  PCBANKS or modded pak.
You can even put MBINs in there and they will be decompiled...

Done

Done in v.3.9.3W


[Bug] YAxis ticks not visible when XAxis value is below zero

Version
5.4.2
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=line-in-cartesian-coordinate-system&lang=ts&code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMmurALYTREC0AjAAwkC-ANCQJ475FKsl4BTAE4QBhWAG0S6VKVIATAIZhFRKXLkS69FrAAs9ALpsNpCQFYdsBkZOnJB3QCYj00sbfow7EAKIByABtKAX83JhJDFCYAbiA
Steps to Reproduce
option = {
xAxis: {
min: -10
},
yAxis: {},
series: [
{
data: [
[-10, 40],
[50, 100],
[40, 20]
],
type: 'line'
}
]
};
Current Behavior

Axis ticks are not visible on XAxis min value below zero
Dark line with axis ticks visible at XAxis 0 value

Expected Behavior

Axis ticks should be visible on XAxis min value below zero
Dark line should not be visible at XAxis 0 value

Environment
- OS: Windows 10
- Browser: Microsoft Edge 115.0.1901.200
- Framework<EMAIL_ADDRESS>
Any additional comments?
No response

This is intended behaviour. If your dont want the axisLine on zero you can set axisLine: {onZero: false}.