feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider

Updates the position of the Camera Rig by rolling a grabbing the sides of a sphere collider's interior, like a hamster ball.
[https://waffle.io/thestonefox/VRTK/cards/5a141a033eb80a02602a376b]

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c

Your commit message body contains a line that is longer than 72 characters

Commits must be in the following format: %{type}(%{scope}): %{description}

Commit: 388ea0bfe788bdfa5e4d87fcbd3272a928819ec6

Your subject line is longer than 72 characters

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

This pull request needs a tidy up.
Requires a squash and a better commit message so we can clean up the gitcop messages.
Let me know if you need any guidance.

There were the following issues with your Pull Request

Commit: 6863447fedda429a5da2f1405140c6555278bcac
Your commit message body contains a line that is longer than 72 characters
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

There were the following issues with your Pull Request

Commit: 1daf52f2e13abfec29768508f988dfaec3a5fe3c

Your commit message body contains a line that is longer than 72 characters

Commits must be in the following format: %{type}(%{scope}): %{description}

Commit: a2abe7ca92e76f1a12f194fe3929466b7b52ea0c

Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

Looks like I'm needing some guidance. I'll take you up on your offer :) Thanks!

There were the following issues with your Pull Request

Commit: c4bf0c973a3e07fd22052c9ba179820ca00a1ad3
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

I'm going to start closing these, we can reopen them if anyone raises it


⚠ Spryr has degraded performance

In 0526ce1, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4331 ms

Resolved: Spryr performance has improved in 9a99a47 after 10 minutes.


Windows support?

Trying to compile the basic example from the docs on Windows, fails in liner. Not sure if it's specifics of my Windows configuration, or whether this crate doesn't have Windows support yet. The original librsync should build normally on Windows.
The crate compiles normally on Mac OS with correct delta files generation. On Linux (Ubuntu server) I noticed different file size generated for a delta patch. And on Windows cannot build yet.
librsync/src/checksum.c(28): error C2491: 'RS_MD4_SUM_LENGTH': definition of dllimport data not allowed
librsync/src/checksum.c(29): error C2491: 'RS_BLAKE2_SUM_LENGTH': definition of dllimport data not allowed

Yeah, I fear this was broken with the last updates. The problem is that I no longer have access to a Windows machine, so I can't easily check Windows support.
Could you follow the steps in https://github.com/mbrt/librsync-rs/blob/master/librsync-sys/README.md and see whether you get different generated headers for Windows?

I got this:
PS C:\Users\admin\Documents\GitHub\librsync\gen> cargo tree
librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)
[build-dependencies]
└── cmake v0.1.12
    └── gcc v0.3.21
        ├── advapi32-sys v0.1.2
        │   └── winapi v0.2.5
        │   [build-dependencies]
        │   └── winapi-build v0.1.1
        └── winapi v0.2.5
PS C:\Users\admin\Documents\GitHub\librsync\gen> cargo run
    Updating crates.io index
   Compiling cc v1.0.69
   Compiling cmake v0.1.45
   Compiling librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)
error: failed to run custom build command for `librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)`

Caused by:
  process didn't exit successfully: `C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-876be86ab9e95625\build-script-build` (exit code: 101)
  --- stdout
  running: "cmake" "C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\.." "-G" "Visual Studio 16 2019" "-Thost=x64" "-Ax64" "-DBUILD_RDIFF=OFF" "-DENABLE_COMPRESSION=OFF" "-DCMAKE_INSTALL_PREFIX=C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\target\\debug\\build\\librsync-gen-02a144ff907295ec\\out" "-DCMAKE_C_FLAGS= -nologo -MD -Brepro" "-DCMAKE_C_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_BUILD_TYPE=Debug"
  -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.17763.
  -- The C compiler identification is MSVC 19.29.30040.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- DO_RS_TRACE=0
  -- Looking for include file sys/file.h
  -- Looking for include file sys/file.h - not found
  -- Looking for include file sys/stat.h
  -- Looking for include file sys/stat.h - found
  -- Looking for include file sys/types.h
  -- Looking for include file sys/types.h - found
  -- Looking for include file unistd.h
  -- Looking for include file unistd.h - not found
  -- Looking for include file fcntl.h
  -- Looking for include file fcntl.h - found
  -- Looking for include file mcheck.h
  -- Looking for include file mcheck.h - not found
  -- Looking for include file zlib.h
  -- Looking for include file zlib.h - not found
  -- Looking for include file bzlib.h
  -- Looking for include file bzlib.h - not found
  -- Looking for __func__
  -- Looking for __func__ - found
  -- Looking for __FUNCTION__
  -- Looking for __FUNCTION__ - found
  -- Looking for fseeko
  -- Looking for fseeko - not found
  -- Looking for fseeko64
  -- Looking for fseeko64 - not found
  -- Looking for _fseeki64
  -- Looking for _fseeki64 - found
  -- Looking for fstat64
  -- Looking for fstat64 - not found
  -- Looking for _fstati64
  -- Looking for _fstati64 - found
  -- Looking for fileno
  -- Looking for fileno - found
  -- Looking for _fileno
  -- Looking for _fileno - found
  -- Looking for stdint.h
  -- Looking for stdint.h - found
  -- Looking for stddef.h
  -- Looking for stddef.h - found
  -- Check size of long
  -- Check size of long - done
  -- Check size of long long
  -- Check size of long long - done
  -- Check size of off_t
  -- Check size of off_t - done
  -- Check size of off64_t
  -- Check size of off64_t - failed
  -- Check size of size_t
  -- Check size of size_t - done
  -- Check size of unsigned int
  -- Check size of unsigned int - done
  -- Check size of unsigned long
  -- Check size of unsigned long - done
  -- Check size of unsigned short
  -- Check size of unsigned short - done
  -- Compiling to Win32 - printf "%zu" size_t formatting support disabled
  -- System is little-endian.
  -- PROJECT_NAME  = librsync
  -- BUILD_HOSTNAME = DESKTOP-P725H9N
  -- CMAKE_SYSTEM = Windows-10.0.17763
  -- Could NOT find POPT (missing: POPT_LIBRARIES POPT_INCLUDE_DIRS)
  -- Could NOT find BZip2 (missing: BZIP2_LIBRARIES) (found version "1.0.6")
  -- Found ZLIB: C:/ProgramData/Miniconda3/Library/lib/z.lib (found version "1.2.11")
  -- Found components for ZLIB
  -- ZLIB_INCLUDE_DIRS  = C:/ProgramData/Miniconda3/Library/include
  -- ZLIB_LIBRARIES = C:/ProgramData/Miniconda3/Library/lib/z.lib
  -- Could NOT find LIBB2 (missing: LIBB2_LIBRARIES LIBB2_INCLUDE_DIRS)
  -- Using included blake2 implementation.
  -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
  -- CMAKE_C_FLAGS  =  -nologo -MD -Brepro -Wno-format
  -- Configuring done
  -- Generating done
  -- Build files have been written to: C:/Users/admin/Documents/GitHub/librsync/gen/target/debug/build/librsync-gen-02a144ff907295ec/out/build
  running: "cmake" "--build" "." "--target" "install" "--config" "Debug" "--"
  Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET Framework
  Copyright (C) Microsoft Corporation. All rights reserved.

    Checking Build System
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\checksum_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\hashtable_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\isprefix_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rabinkarp_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rollsum_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rsync.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\sumset_test.vcxproj]

  --- stderr
  CMake Deprecation Warning at CMakeLists.txt:20 (cmake_minimum_required):
    Compatibility with CMake < 2.8.12 will be removed from a future version of
    CMake.

    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.

  CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
    The package name passed to `find_package_handle_standard_args` (LIBB2) does
    not match the name of the calling package (libb2).  This can lead to
    problems in calling code that expects `find_package` result variables
    (e.g., `_FOUND`) to follow a certain pattern.
  Call Stack (most recent call first):
    cmake/Findlibb2.cmake:12 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:177 (find_package)
  This warning is for project developers.  Use -Wno-dev to suppress it.

  CMake Warning:
    Manually-specified variables were not used by the project:

      CMAKE_ASM_FLAGS
      CMAKE_ASM_FLAGS_DEBUG
      CMAKE_CXX_FLAGS
      CMAKE_CXX_FLAGS_DEBUG

  thread 'main' panicked at '
  command did not execute successfully, got: exit code: 1

  build script failed, must exit now', C:\Users\admin\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.45\src\lib.rs:894:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

If I delete the -Wno-format in CmakeLists.txt, I get this:
PS C:\Users\admin\Documents\GitHub\librsync\gen> cargo run
    Updating crates.io index
   Compiling cc v1.0.69
   Compiling cmake v0.1.45
   Compiling librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)
error: failed to run custom build command for `librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)`

Caused by:
  process didn't exit successfully: `C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-876be86ab9e95625\build-script-build` (exit code: 101)
  --- stdout
  running: "cmake" "C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\.." "-G" "Visual Studio 16 2019" "-Thost=x64" "-Ax64" "-DBUILD_RDIFF=OFF" "-DENABLE_COMPRESSION=OFF" "-DCMAKE_INSTALL_PREFIX=C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\target\\debug\\build\\librsync-gen-02a144ff907295ec\\out" "-DCMAKE_C_FLAGS= -nologo -MD -Brepro" "-DCMAKE_C_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_BUILD_TYPE=Debug"
  -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.17763.
  -- The C compiler identification is MSVC 19.29.30040.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30037/bin/Hostx64/x64/cl.exe - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- DO_RS_TRACE=0
  -- Looking for include file sys/file.h
  -- Looking for include file sys/file.h - not found
  -- Looking for include file sys/stat.h
  -- Looking for include file sys/stat.h - found
  -- Looking for include file sys/types.h
  -- Looking for include file sys/types.h - found
  -- Looking for include file unistd.h
  -- Looking for include file unistd.h - not found
  -- Looking for include file fcntl.h
  -- Looking for include file fcntl.h - found
  -- Looking for include file mcheck.h
  -- Looking for include file mcheck.h - not found
  -- Looking for include file zlib.h
  -- Looking for include file zlib.h - not found
  -- Looking for include file bzlib.h
  -- Looking for include file bzlib.h - not found
  -- Looking for __func__
  -- Looking for __func__ - found
  -- Looking for __FUNCTION__
  -- Looking for __FUNCTION__ - found
  -- Looking for fseeko
  -- Looking for fseeko - not found
  -- Looking for fseeko64
  -- Looking for fseeko64 - not found
  -- Looking for _fseeki64
  -- Looking for _fseeki64 - found
  -- Looking for fstat64
  -- Looking for fstat64 - not found
  -- Looking for _fstati64
  -- Looking for _fstati64 - found
  -- Looking for fileno
  -- Looking for fileno - found
  -- Looking for _fileno
  -- Looking for _fileno - found
  -- Looking for stdint.h
  -- Looking for stdint.h - found
  -- Looking for stddef.h
  -- Looking for stddef.h - found
  -- Check size of long
  -- Check size of long - done
  -- Check size of long long
  -- Check size of long long - done
  -- Check size of off_t
  -- Check size of off_t - done
  -- Check size of off64_t
  -- Check size of off64_t - failed
  -- Check size of size_t
  -- Check size of size_t - done
  -- Check size of unsigned int
  -- Check size of unsigned int - done
  -- Check size of unsigned long
  -- Check size of unsigned long - done
  -- Check size of unsigned short
  -- Check size of unsigned short - done
  -- Compiling to Win32 - printf "%zu" size_t formatting support disabled
  -- System is little-endian.
  -- PROJECT_NAME  = librsync
  -- BUILD_HOSTNAME = DESKTOP-P725H9N
  -- CMAKE_SYSTEM = Windows-10.0.17763
  -- Could NOT find POPT (missing: POPT_LIBRARIES POPT_INCLUDE_DIRS)
  -- Could NOT find BZip2 (missing: BZIP2_LIBRARIES) (found version "1.0.6")
  -- Found ZLIB: C:/ProgramData/Miniconda3/Library/lib/z.lib (found version "1.2.11")
  -- Found components for ZLIB
  -- ZLIB_INCLUDE_DIRS  = C:/ProgramData/Miniconda3/Library/include
  -- ZLIB_LIBRARIES = C:/ProgramData/Miniconda3/Library/lib/z.lib
  -- Could NOT find LIBB2 (missing: LIBB2_LIBRARIES LIBB2_INCLUDE_DIRS)
  -- Using included blake2 implementation.
  -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
  -- CMAKE_C_FLAGS  =  -nologo -MD -Brepro -Wno-format
  -- Configuring done
  -- Generating done
  -- Build files have been written to: C:/Users/admin/Documents/GitHub/librsync/gen/target/debug/build/librsync-gen-02a144ff907295ec/out/build
  running: "cmake" "--build" "." "--target" "install" "--config" "Debug" "--"
  Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET Framework
  Copyright (C) Microsoft Corporation. All rights reserved.

    Checking Build System
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\checksum_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\hashtable_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\isprefix_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rabinkarp_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rollsum_test.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\rsync.vcxproj]
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
  cl : command line error D8021: invalid numeric argument '/Wno-format' [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\sumset_test.vcxproj]

  --- stderr
  CMake Deprecation Warning at CMakeLists.txt:20 (cmake_minimum_required):
    Compatibility with CMake < 2.8.12 will be removed from a future version of
    CMake.

    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.

  CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
    The package name passed to `find_package_handle_standard_args` (LIBB2) does
    not match the name of the calling package (libb2).  This can lead to
    problems in calling code that expects `find_package` result variables
    (e.g., `_FOUND`) to follow a certain pattern.
  Call Stack (most recent call first):
    cmake/Findlibb2.cmake:12 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:177 (find_package)
  This warning is for project developers.  Use -Wno-dev to suppress it.

  CMake Warning:
    Manually-specified variables were not used by the project:

      CMAKE_ASM_FLAGS
      CMAKE_ASM_FLAGS_DEBUG
      CMAKE_CXX_FLAGS
      CMAKE_CXX_FLAGS_DEBUG

  thread 'main' panicked at '
  command did not execute successfully, got: exit code: 1

  build script failed, must exit now', C:\Users\admin\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.45\src\lib.rs:894:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
PS C:\Users\admin\Documents\GitHub\librsync\gen> cargo run
   Compiling librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)
error: failed to run custom build command for `librsync-gen v0.1.0 (C:\Users\admin\Documents\GitHub\librsync\gen)`

Caused by:
  process didn't exit successfully: `C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-876be86ab9e95625\build-script-build` (exit code: 101)
  --- stdout
  running: "cmake" "C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\.." "-G" "Visual Studio 16 2019" "-Thost=x64" "-Ax64" "-DBUILD_RDIFF=OFF" "-DENABLE_COMPRESSION=OFF" "-DCMAKE_INSTALL_PREFIX=C:\\Users\\admin\\Documents\\GitHub\\librsync\\gen\\target\\debug\\build\\librsync-gen-02a144ff907295ec\\out" "-DCMAKE_C_FLAGS= -nologo -MD -Brepro" "-DCMAKE_C_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS= -nologo -MD -Brepro" "-DCMAKE_CXX_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS= -nologo -MD -Brepro" "-DCMAKE_ASM_FLAGS_DEBUG= -nologo -MD -Brepro" "-DCMAKE_BUILD_TYPE=Debug"
  -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.17763.
  -- DO_RS_TRACE=0
  -- Compiling to Win32 - printf "%zu" size_t formatting support disabled
  -- System is little-endian.
  -- PROJECT_NAME  = librsync
  -- BUILD_HOSTNAME = DESKTOP-P725H9N
  -- CMAKE_SYSTEM = Windows-10.0.17763
  -- Could NOT find POPT (missing: POPT_LIBRARIES POPT_INCLUDE_DIRS)
  -- Could NOT find BZip2 (missing: BZIP2_LIBRARIES) (found version "1.0.6")
  -- Found components for ZLIB
  -- ZLIB_INCLUDE_DIRS  = C:/ProgramData/Miniconda3/Library/include
  -- ZLIB_LIBRARIES = C:/ProgramData/Miniconda3/Library/lib/z.lib
  -- Could NOT find LIBB2 (missing: LIBB2_LIBRARIES LIBB2_INCLUDE_DIRS)
  -- Using included blake2 implementation.
  -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
  -- CMAKE_C_FLAGS  =  -nologo -MD -Brepro
  -- Configuring done
  -- Generating done
  -- Build files have been written to: C:/Users/admin/Documents/GitHub/librsync/gen/target/debug/build/librsync-gen-02a144ff907295ec/out/build
  running: "cmake" "--build" "." "--target" "install" "--config" "Debug" "--"
  Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET Framework
  Copyright (C) Microsoft Corporation. All rights reserved.

    Checking Build System
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    checksum_test.c
    checksum.c
    rollsum.c
    mdfour.c
    blake2b-ref.c
    Generating Code...
    checksum_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\checksum_test.exe
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    hashtable_test.c
    hashtable.c
    Generating Code...
    hashtable_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\hashtable_test.exe
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    isprefix_test.c
    isprefix.c
    Generating Code...
    isprefix_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\isprefix_test.exe
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    netint_test.c
    netint.c
    util.c
    trace.c
  C:\Users\admin\Documents\GitHub\librsync\src\trace.c(66,1): error C2491: 'rs_trace_to': definition of dllimport function not allowed [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
  C:\Users\admin\Documents\GitHub\librsync\src\trace.c(71,1): error C2491: 'rs_trace_set_level': definition of dllimport function not allowed [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
  C:\Users\admin\Documents\GitHub\librsync\src\trace.c(106,1): error C2491: 'rs_trace_stderr': definition of dllimport function not allowed [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
  C:\Users\admin\Documents\GitHub\librsync\src\trace.c(111,1): error C2491: 'rs_supports_trace': definition of dllimport function not allowed [C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\netint_test.vcxproj]
    tube.c
    scoop.c
    stream.c
    Generating Code...
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    rabinkarp_test.c
    rabinkarp_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\rabinkarp_test.exe
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    rollsum_test.c
    rollsum.c
    Generating Code...
    rollsum_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\rollsum_test.exe
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    prototab.c
    base64.c
    buf.c
    checksum.c
    command.c
    delta.c
    emit.c
    fileutil.c
    hashtable.c
    hex.c
    job.c
    mdfour.c
    mksum.c
    msg.c
    netint.c
    patch.c
    readsums.c
    rollsum.c
    scoop.c
    stats.c
    Generating Code...
    Compiling...
    stream.c
    sumset.c
    trace.c
    tube.c
    util.c
    version.c
    whole.c
    blake2b-ref.c
    Generating Code...
       Creating library C:/Users/admin/Documents/GitHub/librsync/gen/target/debug/build/librsync-gen-02a144ff907295ec/out/build/Debug/rsync.lib and object C:/Users/admin/Documents/GitHub/librsync/gen/target/debug/build/librsync-gen-02a144ff907295ec/out/build/Debug/rsync.exp
    rsync.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\rsync.dll
    Building Custom Rule C:/Users/admin/Documents/GitHub/librsync/CMakeLists.txt
    sumset_test.c
    sumset.c
    util.c
    trace.c
    hex.c
    checksum.c
    rollsum.c
    mdfour.c
    hashtable.c
    blake2b-ref.c
    Generating Code...
    sumset_test.vcxproj -> C:\Users\admin\Documents\GitHub\librsync\gen\target\debug\build\librsync-gen-02a144ff907295ec\out\build\Debug\sumset_test.exe

  --- stderr
  CMake Deprecation Warning at CMakeLists.txt:20 (cmake_minimum_required):
    Compatibility with CMake < 2.8.12 will be removed from a future version of
    CMake.

    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.

  CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
    The package name passed to `find_package_handle_standard_args` (LIBB2) does
    not match the name of the calling package (libb2).  This can lead to
    problems in calling code that expects `find_package` result variables
    (e.g., `_FOUND`) to follow a certain pattern.
  Call Stack (most recent call first):
    cmake/Findlibb2.cmake:12 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:177 (find_package)
  This warning is for project developers.  Use -Wno-dev to suppress it.

  thread 'main' panicked at '
  command did not execute successfully, got: exit code: 1

  build script failed, must exit now', C:\Users\admin\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.45\src\lib.rs:894:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixed by #22.


Support for custom configuration in DbContextOptions

The mechanism for loading custom configuration settings from the DbContextOptions is not easily discoverable. If we want users to be able to fetch their own settings in a DbContext without registering an IOptions<T> or manually adding settings into the service provider, we should consider providing a simpler method for accessing these settings.
The DbContextOptions provides a dictionary containing the DbContext specific settings from Configuration but the user would be required to cast the instance to IDbContextOptions (in the M.D.E.Infrastructure namespace) or perhaps an IAccessor<T> after API review.
IReadOnlyDictionary<string, string> RawOptions { get; [param: NotNull] set; }

Closing since DbContextOptions now no longer has any connection to the configuration or options infrastructure and does not have any concept of raw values or dictionaries.


feat(kafka topic): partitions flag for update

User should be able to update number of partitions in a topic. The number of partitions can only increase.
Closes #762
Verification Steps

Create a Kafka topic and update its partition count using --partitions flag.

./rhoas kafka topic update rama-topic --partitions 5

Partitions can only increase, trying to reduce number of partitions should throw error.
Validate the interactive update flow. Try providing values smaller and bigger than current partitions count.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

Checklist

[ ] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

While updating non-interactive mode for updating partition topic, this is the displayed error:

Should we set the error message in case statuscode.badrequest? But again a bad request can mean many things and not only invalid partitions.

Should we set the error message in case statuscode.badrequest? But again a bad request can mean many things and not only invalid partitions.

That would be typically only status code. We need backend to return error codes like kafka and map them properly.  If we not getting any info back that can be used to know type of errror I would recomend to:

Create issue in kafka backend to discuss it
create issue in cli to adjust error messages/handling when backend support it.


[FEATURE REQUEST] Code Folding for .txt files

Would it be possible to allow code folding for .txt files as well? Based on indentation.

why would anyone need that though?

its how i organize my notes

+1
I use .txt files for organization too: For outlining, planning etc.
Vscode and the text editor of OneDrive Online are able to fold text files by indentation.
And if you use powertools on Windows you can fold text files in the explorer preview too.
It would be great to have something similar on Android.
At the moment I use the workaround to set yaml as syntax for txt-files.

It should be also possible to use indentation-based folding for any language, but just adding it as a language-selection option (to remove the YAML highlighting) can be enough too.

That folding is much more consistent, and doesn't require language-specific support.
Syntax checkers are much more complex than that feature, they are more prone to errors and harder to maintain.

In this very moment its impossible to use the app for C# , because folding there doesn't work, due to multiple bugs.
I also suggest to rename this Issue to "Indentation-based folding".


Support swapping out Promise library

I'm trying to use fetch-mock to against environments which do not have Promise implemented natively.
I'm using isomorphic-fetch and replacing its Promise implementation with bluebird, so it works in these environments in my production code.
I'm using it something like this:
import 'isomorphic-fetch'
import Promise from 'bluebird'
fetch.Promise = Promise

It would be cool if fetch-mock used a similar mechanism, or (perhaps even better?) looked into the original fetch and used its .Promise property if it exists.
Let me know if you want me to try to PR this (I assume it would be pretty quick and self-evident how to do this)

I'm inclined to be quite dogmatic about only supporting Promise defined as a global because that's what the spec says it should be (and encourage users to polyfill it globally if it's not natively available).
Is there some reason you can't/don't want to do this?

OK, it looks like I was operating under some false assumptions.
It does look like isomorphic-fetch's author wants to explicitly support the pattern I described above, but it is not in the library yet (so that approach does not work)
https://github.com/matthew-andrews/isomorphic-fetch/issues/43
I am currently patching Promise globally which resolves my issue.
I would suggest that if isomorphic-fetch decides to merge in that PR, it would make sense to revisit this, since you explicitly support mocking that library.
In any case, that you for your extremely useful tool!

I would use this. We're using fetch-mock to mock our promises, but moving from isomorphic-fetch to fetch-ponyfill at the moment, looking using the new fetch-mock sandbox functionality.
We're using bluebird promises (both for performance and all the extra features), and fetch-ponyfill takes that promise implementation as an option when it's loaded. That implementation all works fine, giving us fetch and Promise working everywhere without touching any globals at all, but we can't easily test it because of this issue.
@wheresrhys Any enthusiasm for reopening this, especially given that you're now looking at supporting the fetch-ponyfill use case?

I'll consider accepting a PR, but don't have any particular enthusiasm for implementing it myself. There are lots of points in the code and the tests where native Promise is assumed, so adding support isn't straightforward and will arguably clutter the code base.
Given that bluebird implements the Promise spec, would it be an option for you to force using native Promise instead of bluebird in your tests?

Given that bluebird implements the Promise spec, would it be an option for you to force using native Promise instead of bluebird in your tests?

I don't think so, we use bluebird methods (like .timeout) internally, assuming that fetch returns a bluebird promise. We could manually convert it, but with fetch-ponyfill we can guarantee that we don't normally need to at runtime, so it feels messy to have to do that just for the tests.
I've had a look, doesn't seem that tricky I think. I need somewhere to pass in the promise implementation - I'm thinking that actually doing this as part of the sandbox setup is probably sensible, since they're a very similar use case?  E.g.
var fetchMock = require('fetch-mock').sandbox({ Promise: bluebirdPromise })

Does that sound ok? I'll put in a PR a little later today if so.

Yep, good call making it part of the sandbox setup. I'd go for just accepting Promise as the first parameter. Less future proof, but more user friendly. I'll probably regret saying this, but I can't see there ever being a need to pass in any other config to sandbox(), or, more seriously, duck-typing coudl be used to deal with that if it ever happens


feat: support Source Map in TypeScript SDK

Depends on #9031
Implement SourceMap to display the actual position of the definition when codegen.
It's very useful to navigate inside the codebase when using local dependencies since generated function to call
the dependency doesn't directly use the dep's code but instead call it through the Dagger API.
Same as go in #8498
TODO

[x] Registration by the TS SDK (tested manually for now)
[x] Generation on the TS client (tested manually for now)
[ ] Integration tests

Example of generation
export type TestLocationContainerOpts = {
  name: string // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:25)
}

export type TestLocationHumanOpts = {
  name: string // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:20)
  age: number // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:20)
}

export enum TestLocationFoo { // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:6)
  Bar = "bar",
  Baz = "baz",
  Foo = "foo",
}

export class TestLocationPerson extends BaseClient { // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:12)
  ...

  age = async (): Promise<number> => { // test-location (../../../../../../../dagger/location/ts-to-go/test-location/src/index.ts:12)
  ...
  }
}

Demo
https://github.com/user-attachments/assets/f64654b8-c3ff-4a6f-b127-29011b9993c8

Looking good @TomChv - love the demo screen recording!
Please add a todo item to add something (anything) to the docs. I know that @vikram-dagger will enjoy pairing-up with you on this.


Make bin/install executable

On Unix based systems  bin/install should be executable so you can
actually use commands such as rez env pipz -- install avalon-core.

Thanks @jasperges!


chore: promote gogogo-trial to version 0.0.10

chore: promote gogogo-trial to version 0.0.10
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-osama: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
42b54936f504f802e2763be9f20a54b29d719e87
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


[SPARK-44719][SQL][3.5] Fix NoClassDefFoundError when using Hive UDF

What changes were proposed in this pull request?
This PR partially reverts SPARK-43225. Added jackson-core-asl and jackson-mapper-asl back to pre-built distributions.
Why are the changes needed?
Fix NoClassDefFoundError when using Hive UDF:
spark-sql (default)> add jar /Users/yumwang/Downloads/HiveUDFs-1.0-SNAPSHOT.jar;
Time taken: 0.413 seconds
spark-sql (default)> CREATE TEMPORARY FUNCTION long_to_ip as 'net.petrabarus.hiveudfs.LongToIP';
Time taken: 0.038 seconds
spark-sql (default)> SELECT long_to_ip(2130706433L) FROM range(10);
23/08/08 20:17:58 ERROR SparkSQLDriver: Failed in [SELECT long_to_ip(2130706433L) FROM range(10)]
java.lang.NoClassDefFoundError: org/codehaus/jackson/map/type/TypeFactory
	at org.apache.hadoop.hive.ql.udf.UDFJson.<clinit>(UDFJson.java:64)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
...

Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test.

Do you think we can have a test coverage, @wangyum ?

The test cannot cover it because jackson-mapper-asl is in the classpath: https://github.com/apache/spark/blob/branch-3.5/pom.xml#L1825-L1829

thanks, merged to master

the GitHub micro 'close' seems not working, close it manually

Got it. Thank you, @wangyum and @yaooqinn .


[feat] config/ topic

Is your feature request related to a problem? Please describe.
I was away from home and zwave2mqtt stopped talking to my Mqtt server so my HA instance couldn't control any of my wave devices, I couldn't do anything to fix it until I got home.
Describe the solution you'd like
I didn't find anything in the docs, but it would be nice to have zwave2mqtt listen to a config topic  where you can send Mqtt messages to control basic functions of zwave2mqtt like restart, test network, heal node {node id}.
monitor uses monitor/scan/restart
zigbee2mqtt uses it to receive a few basic commands like reset, permit_join, remove, etc.
https://www.zigbee2mqtt.io/information/mqtt_topics_and_message_structure.html
Describe alternatives you've considered
Setting up a VPN so I have full access to my network while away from home could be an option.

@towerhand Interesting feature! What actions do you think need to be acessible from mqtt? Actually for test network and heal node you can use MQTT APIs but there is no way to restart application using mqtt, do you think that is there any other action like restart that could be usefull?

Sorry but as a regular user I didn’t really understand the mqtt api when I first read the docs but looks like mostly can do what I was thinking.
Since restart is not an option then maybe listening to simple topics for fixing basic problems in the nodes and mesh could be beneficial. Hopefully someone with more knowledge can voice their opinion.
Maybe empty message to:
/config/heal network
/config/refresh [node id]
/config/remove failed node
Just a suggestion from my limited understanding of zwave and mqtt.
Thanks for all your hard work.

Yea the mqtt API in the docs you linked seems to do everything I’m asking. I’ll try to update the docs to make it a little bit easier to understand. Thanks.


[HUDI-7480] Fix functional index and avoid multiple initializations

Change Logs
This PR fixes two issues:

When a functional index is updated, it was getting re-initialized. This was happening because metadata partition type only contains the functional index partition prefix while hoodie.properties contains the full name. Due to discrepancy, metadata writer thought there is anew index that needs ot be initialized. This is fixed in HoodieTableConfig#isMetadataPartitionAvailable.
When a functional index is updated, it fetches latest file slices, including the pending ones, in data partition. There was a typo in building the filesystem view. Instead of passing data meta client, metadata meta client was passed.

Added a test which covers both these scenarios.
Impact
Fixes functional index bugs.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Hmm, it looks like there are many test failures.

@danny0405 @bhat-vinay @yihua All tests passed now. Please take another pass.


{attribute 'pack mode' := 1}

{attribute 'pack mode' := '1'}

Good find. This was a mistake.

Still a typo (underscore) in the code example connection.rst {attribute 'pack**_**mode' := 1}

This has been fixed by @chrisbeardy with this commit: https://github.com/stlehmann/pyads/commit/8d70d1a494b8348f805a446c082d795bea6845d2


Assistance Required for Matching Generated Feature Files with Configuration Settings

Hello, I generated the following files after running '**executioner_feature generator. py**_':
1.     X_test_TOW_IDS_dataset_one_class_Wsize_44_Cols_116_Wslide_1_MC_False_sumX_True.npz
2.     X_train_TOW_IDS_dataset_multi_class_Wsize_44_Cols_116_Wslide_1_MC_True_sumX_True.npz
3.     y_test_TOW_IDS_dataset_one_class_Wsize_44_Cols_116_Wslide_1_MC_False_sumX_True.csv
4.     y_train_TOW_IDS_dataset_multi_class_Wsize_44_Cols_116_Wslide_1_MC_True_sumX_True.csv
However, the file names specified for the input data in the configuration files within the directories 'config_jsons/model_test' and 'config_jsons/model_train_validate' do not match the files I have generated in the first step of feature extraction.
Could you advise me on the steps I should take to continue running the code? I would greatly appreciate your guidance in this matter.

Hi Goon,
The reason why some config_jsons have prefixes such as "1510_" and "1210_" is that I've used the date that I generated the files as an index to version the data.
Your files are generated correctly. You can use them as input files for the training and test scripts.
Please let me know if I can assist you with anything else :smiley:

This is precisely what I wanted to know. It has resolved my doubts, and I am very grateful. 😁


Add multiple recipes

Pre-flight Checklist
Please ensure you've completed all of the following.

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.

Description of Change
This PR adds the following new services:

Badoo
Conceptboard
Infomaniak Calendar
Invoice Ninja
Postman
Regex101
Revolt
Strava
Sympatia
Temp Mail

This PR:

closes ferdium/ferdium-app#1140
closes ferdium/ferdium-app#1141
closes ferdium/ferdium-app#1148
closes ferdium/ferdium-app#1149
closes ferdium/ferdium-app#1183
closes ferdium/ferdium-app#1190
closes ferdium/ferdium-app#1219
closes ferdium/ferdium-app#1248
closes ferdium/ferdium-app#1366
closes ferdium/ferdium-app#1382

Awesome, working down the open issues in one sweep with a PR like this :smile:
Unfortunately, I am pretty sure that a lot of these recipe requests will lead to follow up issues to change the URLs: From a quick check of e.g. Revolt Chat, I can see that the actual URL that people would probably want is https://app.revolt.chat/login rather than https://revolt.chat/

Awesome, working down the open issues in one sweep with a PR like this 😄
Unfortunately, I am pretty sure that a lot of these recipe requests will lead to follow up issues to change the URLs: From a quick check of e.g. Revolt Chat, I can see that the actual URL that people would probably want is https://app.revolt.chat/login rather than https://revolt.chat/

Thanks!
Yes, I think I missed that one (changed it on the wrong recipe and then forgot to add changes back) :p I'll correct it

Awesome, working down the open issues in one sweep with a PR like this 😄
Unfortunately, I am pretty sure that a lot of these recipe requests will lead to follow up issues to change the URLs: From a quick check of e.g. Revolt Chat, I can see that the actual URL that people would probably want is https://app.revolt.chat/login rather than https://revolt.chat/

Thanks!
Yes, I think I missed that one (changed it on the wrong recipe and then forgot to add changes back) :p I'll correct it

I just checked and I have https://app.revolt.chat/ so I think everything is fine as it is 😯

Must've mistaken the url for the general website, my bad.
Also just checked all links, looks like you were thorough!

Must've mistaken the url for the general website, my bad.

No worries 😁 it's always good to double/triple check.. that's how problems are usually caught

Also just checked all links, looks like you were thorough!

Thank you 🙏


Allows constructing a DefaultToolExecutor with a ToolRequest

Issue
Now that we are sure that only method names in Tools are unique(https://github.com/langchain4j/langchain4j/pull/1375), we can create a DefaultToolExecutor using a ToolRequest
Change
Add a second constructor to DefaultToolExecutor
General checklist

[X] There are no breaking changes
[X] I have added unit and integration tests for my change
[X] I have manually run all the unit and integration tests in the core and main modules, and they are all green

That was quick ;o) #Thanks


Order alphabetically

Would suggest to order the entries alphabetically for an easier use and better overview, what do you think?

I think it would make sense to order at least some things alphabetically (eg: the plugins section).


Temporarily add workflow.default_jar_spec_revision to infrastructure.toml

Until upstream Hail releases proper fixes for SET-261 and especially SET-247, we need to override the QoB JAR file always.

This is admittedly fairly hackily done, but we also hope to be able to remove it again within weeks.

I don't remember if a merge to main in cpg-infrastructure triggers a redeploy or not. If not, you'll need to manually trigger it in the workflows of cpg-infrastructure-private.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@a26324f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage        ?   90.93%
=======================================
  Files           ?        4
  Lines           ?      430
  Branches        ?        0
=======================================
  Hits            ?      391
  Misses          ?       39
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, I did indeed need to manually trigger the cpg-infrastructure-private workflow.


label/dict.txt for CDS classifier

Hi,  could you provide the CDS-data-bin/label/dict.txt that you used during fine-tuning to map label_ids and labels?
It will be much helpful for running the pre-trained CDS classifier.
Thanks very much!

Hey sure, sorry for the omission and the delay with all this. Here's the file: https://drive.google.com/drive/u/1/folders/1b0YkZipzcrI9lZvJJ2_FibGFKA-wwYFA


Enable gzip compression for CDN

From PageSpeed:

Сжатие следующих ресурсов посредством gzip позволит уменьшить их размер для переноса на 140.9Кб (на 75%).
Сжатие http://cdn.leafletjs.com/leaflet-0.4.4/leaflet-src.js позволит уменьшить размер на 134.7Кб (на 75%).
Сжатие http://cdn.leafletjs.com/leaflet-0.4.4/leaflet.css позволит уменьшить размер на 6.1Кб (на 75%).

Could you explain this in English please? Why was this closed? There is still no gzip compression for the resources on the CDN afaict.

Use google translate, mourner says to use cdnjs which has gzip compression.

Actually I think this should be revisited. Initially I worried that CloudFront doesn't support automatically gzipping and serving based on content headers. But now that all browsers/clients support gzip, we should just gzip by default.

Hi, I saw this issue on http://up-for-grabs.net/ and wanted to give it a shot, see if I can help you guys out.
Does this refer to the leaflet website itself? Anyhow, I have not been able to find the code for the backend, just the frontend, and this looks like either a backend issue or a cdn configuration issue.

We switched our CDN to unpkg.com, so this can be considered fixed. http://leafletjs.com/download.html


test for github slack bot

Steps to reproduce
I don't know what I am doing
Expected behavior
I am hungry
Environments
Desktop

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Test success!


number of latent variables

hi, is there any rule of a thumb how to choose the number of latent variables? i am aware that scvi includes tools for hyperparameter optimization but i wonder if there is a simple (even if not most perfect) solution. thanks!

I think a good place to start is hold everything constant and use our estimator for the marginal LL (log p(x)) at different numbers of latent dimensions. This is probably the simplest way to do it but will take a while.
Using our current API, you can do something like trainer.test_set.marginal_ll() after training. I believe this is actually the negative marginal LL so lower should be better.

Thanks for the advice @adamgayoso
I ran into the following error though:
trainer.test_set.marginal_ll()
Traceback (most recent call last):

  File "<ipython-input-88-3e632497cd3e>", line 1, in <module>
    trainer.test_set.marginal_ll()

  File "/opt/anaconda3/lib/python3.7/site-packages/torch/autograd/grad_mode.py", line 15, in decorate_context
    return func(*args, **kwargs)

  File "/opt/anaconda3/lib/python3.7/site-packages/scvi/inference/posterior.py", line 280, in marginal_ll
    ll = compute_marginal_log_likelihood_scvi(self.model, self, n_mc_samples)

  File "/opt/anaconda3/lib/python3.7/site-packages/scvi/models/log_likelihood.py", line 131, in compute_marginal_log_likelihood_scvi
    return -log_lkl / n_samples

ZeroDivisionError: division by zero

Am I doing something stupid?
My code:
scviDataset = AnnDatasetFromAnnData(adata,batch_label="sample")
    # Train a model
    vae = VAE(
        scviDataset.nb_genes,
        n_batch=scviDataset.n_batches * False,
        n_latent=10,
    )
    trainer = UnsupervisedTrainer(vae, scviDataset, train_size=1.0, use_cuda=False)
    trainer.train(n_epochs=100, lr=1e-3)
    ####
    trainer.test_set.marginal_ll()

As you've set train_size=1.0, there is no test_set you may also do it on the train_set.

of course, thanks, it works now!
do you think I could use a subset of my data set (say, 10%) to estimate the marginal LL for different n_latent to speed up the process?

yes!

Amazing, thank you so much!


Bridge Integration

Integrates Axelar transfers directly into frontend, with the option to connect MetaMask and/or EVM WalletConnect.
Key components

Observable MetaMask and observable WalletConnect objects for interfacing with respective wallet.
/integrations/ folder containing an /axelar/ folder with a modal view, queries, config, and types needed by Axelar.
BridgeTransfer modal that dynamically imports all Axelar transfer dependencies. Saves ~317kb from initial loaded bundle.
Integration is enabled for an IBC asset by adding a AxelarBridgeConfig to the originBridgeInfo member of an entry in ibc-assets.ts's IBCAssetInfos list
IBC transfers now use the new and improved UI + animation. Maintains support for copying addresses on mobile, and editing the withdraw address.
For mobile, I'm simply going to scale the view down

TODO:

[x] Add lottie/bridge animation from Nikita and Syed
[x] Mobile design
[x] Add hardcoded Axelar bridge fee to AxelarBridgeConfig
[x] Ensure user has correct network selected in wallet

I think we need to implement logic to check what the user’s active network on Metamask is set to. If it isn't Ethereum, we should request the user to change it to Ethereum (https://docs.metamask.io/guide/ethereum-provider.html#basic-usage)

Yeah, I also realized that needed to be added to the outstanding to do list.

Note: the large number of line changes are largely from the lottie animation files; 38k and 18k lines.


Fix somato dataset

closes #6770
see also: https://github.com/mne-tools/mne-scripts/pull/22
This should do the trick :+1: thanks for guidance @larsoner

I killed Travis because it was irrelevant, just waiting on the Azure Style run

Thanks for the quick fix @sappelhoff !


chore(main): release 0.72.0

:robot: I have created a release beep boop
0.72.0 (2024-08-21)
What's Changed

Cors pipelines webhook by @qgerome in https://github.com/BLSQ/openhexa-app/pull/762

Full Changelog: https://github.com/BLSQ/openhexa-app/compare/0.71.9...0.72.0

This PR was generated with Release Please. See documentation.

:robot: Created releases:

0.72.0
:sunflower:


Router.go With AutoForm

I am using three forms with three Schemas for each to enter data in a Collection, as a step-by-step, by updating.
I have problems to redirect the user from one form to another after using the  OnSuccess Hook with Router.go ("nextForm") function. I'm using the session to pass the document id to update the document every step, but using the Router.go ("nextForm"), but is returning an error and the next form is not being displayed.
The error on console:
Exception in template helper: RangeError: Maximum call stack size exceeded
at String.toString (native)
at isArguments (http://localhost:3000/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:129:21)
at looksLikeArray (http://localhost:3000/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:147:17)
at Function..each..forEach (http://localhost:3000/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:157:16)
at parseObj (http://localhost:3000/packages/aldeed_simple-schema.js?6b088ed5394a2f8f07e9602d918d515b3acad5e6:1095:9)
at http://localhost:3000/packages/aldeed_simple-schema.js?6b088ed5394a2f8f07e9602d918d515b3acad5e6:1099:11
at Function..each..forEach (http://localhost:3000/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:159:22)
at parseObj (http://localhost:3000/packages/aldeed_simple-schema.js?6b088ed5394a2f8f07e9602d918d515b3acad5e6:1095:9)
at http://localhost:3000/packages/aldeed_simple-schema.js?6b088ed5394a2f8f07e9602d918d515b3acad5e6:1099:11
at Function..each._.forEach (http://localhost:3000/packages/underscore.js?0a80a8623e1b40b5df5a05582f288ddd586eaa18:159:22)

Would need a full reproduction.

+1 but weirdly enough, I get no error message. Router.go('routename') is just silently ignored within the onSuccess hook.

Please retest with autoform 5.0, and post a reproduction if this is still an issue. Hard to say what the problem might be without being able to step through.

I cannot upgrade to 5.0 at this time due to some other component pinning it down to 4.0 (probably bootstrap datepicker) but I'll try it as soon as I can upgrade.


Make sure to check whether KakaoSDK already has an adapter…

...before caling init. Fixes a crash issue that occurs when reloading the app through the Debug Menu

Thanks. I'll release it now.


Overwrite attributes containing hashes

Hi Seth,
when overwriting setting attributes it seems to me that this does not work with entire attribute hashes:
When monkey-debugging my recipe with
puts "Attribute settings: #{node['nagios']['master']['macros']}"
an rspec run with
let(:chef_run) do
runner = ChefSpec::SoloRunner.new
runner.node.normal['nagios']['master']['macros'] = {}
runner.converge(described_recipe)
end
shows that the attribute is not empty but instead returns the settings from the attributes file:
Attribute settings {"USER2"=>"/opt/nagios-plugins"}
How would you advise to test a chef run with an empty (or unset) attribute?
I'm using chefspec 5.2.0.
Thanks
Patricia

@tas50 this is just doing a deep merge between default and normal attributes and is just 'how attributes work'
node.default["nagios"]["master"]["macros"] = {} might work, or node.rm("nagios", "master", "macros") plus setting a value.  although it seems a really weird use case.


Breaking Debug menu through edge case

When you release the trigger to change debug back to config and press the B button you get into this state where the menu is unresponsive except for the pause button.

@Delta-473 Could you check if #423 fixed this issue?

Still possible, it more an issue with the menu logic where there's a small time frame where this is possible.


ServiceBus ManagedIdentityTokenProvider with AzureServiceTokenProvider.

Allows to set customized AzureServiceTokenProvider to ManagedIdentityTokenProvider constructor.
AzureServiceTokenProvider may be constructed using different Managed Identity connectionStrings.

//cc: @SeanFeldman

I'll defer to @nemakam for approval, but I would personally be interested in understanding the scenarios in which you're intending this be used.

@serkantkaraca , could you help reviewing this PR?

    public async override Task<SecurityToken> GetTokenAsync(string appliesTo, TimeSpan timeout)

Nit: override async

Refers to: sdk/servicebus/Microsoft.Azure.ServiceBus/src/Primitives/ManagedIdentityTokenProvider.cs:33 in e14e529. [](commit_id = e14e5299031e153a2f96a7581e21a5d1e72f6fd5, deletion_comment = False)

Hi Everyone. Thank you for taking this into account.
MessageBus authentication had dependency to ManagedIdentity. If you need to use caching of managed identity then it is better to use propriate dependency injection lifecycle for it instead of making static field.
One application may have many Managed Identities. For example AzureFunction may have few. User Assigned Managed Identities require specifying connection string with managed identity ID. Also in out project we had very sophisticated bug related to current implementation with static cached default value. The fact is that default managed identity constructor is not totally universal enough even for localhost debugging with Managed Identity. We experienced problem when adding some libraries (and calling some static constructors) may change behavior of derfault ManagedIdentity instance settings. Long story short, it is important to be able to set managed identity manually into individual ServicBus authentication instance.

Can one of the admins verify this patch?

@serkantkaraca can I ask why this change was merged with failing servicebus ci legs? It is causing other pipelines to start failing like https://github.com/Azure/azure-sdk-for-net/pull/10170.

You can also see the latest failures in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=272484&view=results.
They look something like:
Assert.Equal() Failure
Expected: ··· { }\n public override System.Threading.Tasks.Task<Micr···
Actual: ··· { }\n public ManagedIdentityTokenProvider(Microsoft.Az···

Stack trace
   at ApprovalTests.Reporters.AssertReporter.AssertEqual(String approvedContent, String receivedContent)
   at ApprovalTests.Reporters.AssertReporter.AssertFileContents(String approved, String received)
   at ApprovalTests.Reporters.AssertReporter.Report(String approved, String received)
   at ApprovalTests.Reporters.FirstWorkingReporter.Report(String approved, String received)
   at ApprovalTests.Reporters.ContinousDeliveryUtils.ReportOnServer(String approved, String received)
   at ApprovalTests.Reporters.TfsVnextReporter.Report(String approved, String received)
   at ApprovalTests.Reporters.FirstWorkingReporter.Report(String approved, String received)
   at ApprovalTests.Approvers.FileApprover.ReportFailure(IApprovalFailureReporter reporter)
   at ApprovalTests.Core.Approver.Verify(IApprovalApprover approver, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalApprover approver, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer, IApprovalNamer namer, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer)
   at ApprovalTests.Approvals.Verify(String text, Func`2 scrubber)
   at Microsoft.Azure.ServiceBus.UnitTests.API.ApiApprovals.ApproveAzureServiceBus() in /Users/runner/runners/2.165.0/work/1/s/sdk/servicebus/Microsoft.Azure.ServiceBus/tests/API/APIApprovals.cs:line 32

So sorry, I didn't know it was failing at CI pipeline. I will rollback the merge.

Can you approve https://github.com/Azure/azure-sdk-for-net/pull/10173 ?


No Active volumes found after rename of Default Volume Group

I renamed the Default Volume Group to something more meaningful.
After the change, no streams were being saved.
Log full of
Failed to get lock as no writeable volumes.  This may be because there are no active volumes configured or the active volumes (or the filesystem(s) they sit on) are full

WARN stroom.data.store.impl.fs.FsVolumeService - No ACTIVE volumes found, all vols: 0 non-full vols: 0, non-full ACTIVE vols: 0

[] Add uuid and is_default cols to fs/idx vol grp tables
[] Populate uuid col with uuids
[] Make uuid col not null
[] (de)ser for fs/idx vol group
[] Imp/exp handler for fs/idx vol grp
[] Change feed setting presenter to use docref picker
[] Change appender vol group prop to use docref picker
[] Migrate pipelines to change vol group name to vol group uuid
[] Migrate feeds to change vol group name to uuid
[] Change vol group presenter to add default col
[] Add logic to un-set default from other vol groups when setting a vol group to default


tsl_client transport not has timeout

mabe hangup to
#	0xc17228	internal/poll.runtime_pollWait+0x88					C:/Users/mpc/sdk/go1.20.1/src/runtime/netpoll.go:306
#	0xcad1b1	internal/poll.(*pollDesc).wait+0x31					C:/Users/mpc/sdk/go1.20.1/src/internal/poll/fd_poll_runtime.go:84
#	0xcae836	internal/poll.execIO+0xf6						C:/Users/mpc/sdk/go1.20.1/src/internal/poll/fd_windows.go:175
#	0xcaf537	internal/poll.(*FD).Read+0x2b7						C:/Users/mpc/sdk/go1.20.1/src/internal/poll/fd_windows.go:436
#	0xe464c8	net.(*netFD).Read+0x28							C:/Users/mpc/sdk/go1.20.1/src/net/fd_posix.go:55
#	0xe5d024	net.(*conn).Read+0x44							C:/Users/mpc/sdk/go1.20.1/src/net/net.go:183
#	0x164b2bc	github.com/bogdanfinn/utls.(*atLeastReader).Read+0x3c			C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:791
#	0xc6b217	bytes.(*Buffer).ReadFrom+0x97						C:/Users/mpc/sdk/go1.20.1/src/bytes/buffer.go:202
#	0x164b4a4	github.com/bogdanfinn/utls.(*Conn).readFromUntil+0xe4			C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:813
#	0x1648995	github.com/bogdanfinn/utls.(*Conn).readRecordOrCCS+0x115		C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:620
#	0x164c70c	github.com/bogdanfinn/utls.(*Conn).readRecord+0x6c			C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:586
#	0x164c70d	github.com/bogdanfinn/utls.(*Conn).readHandshake+0x6d			C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:1023
#	0x1676cd8	github.com/bogdanfinn/utls.(*UConn).clientHandshake+0x478		C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/u_conn.go:430
#	0x1675af1	github.com/bogdanfinn/utls.(*UConn).handshakeContext+0x371		C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/u_conn.go:284
#	0x17244a4	github.com/bogdanfinn/utls.(*UConn).HandshakeContext+0x5c4		C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/u_conn.go:219
#	0x1724488	github.com/bogdanfinn/utls.(*UConn).Handshake+0x5a8			C:/Users/mpc/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/u_conn.go:206
#	0x17244a5	github.com/bogdanfinn/tls-client.(*roundTripper).dialTLS+0x5c5

Yeah, I think I found the same problem. Was testing a proxy which uses this library:
goroutine 1298 [IO wait, 9 minutes]:
internal/poll.runtime_pollWait(0x7f6072fcaad0, 0x72)
	/home/jsn/sdk/go1.19.3/src/runtime/netpoll.go:305 +0x89
internal/poll.(*pollDesc).wait(0xc00105f480?, 0xc001468000?, 0x0)
	/home/jsn/sdk/go1.19.3/src/internal/poll/fd_poll_runtime.go:84 +0x32
internal/poll.(*pollDesc).waitRead(...)
	/home/jsn/sdk/go1.19.3/src/internal/poll/fd_poll_runtime.go:89
internal/poll.(*FD).Read(0xc00105f480, {0xc001468000, 0xa000, 0xa000})
	/home/jsn/sdk/go1.19.3/src/internal/poll/fd_unix.go:167 +0x25a
net.(*netFD).Read(0xc00105f480, {0xc001468000?, 0xc000c45000?, 0xc00146ffc3?})
	/home/jsn/sdk/go1.19.3/src/net/fd_posix.go:55 +0x29
net.(*conn).Read(0xc0001342a0, {0xc001468000?, 0xc001124828?, 0xc001124808?})
	/home/jsn/sdk/go1.19.3/src/net/net.go:183 +0x45
github.com/bogdanfinn/utls.(*atLeastReader).Read(0xc00115d5f0, {0xc001468000?, 0x0?, 0x4a5908?})
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:791 +0x3d
bytes.(*Buffer).ReadFrom(0xc0011322b0, {0xa60940, 0xc00115d5f0})
	/home/jsn/sdk/go1.19.3/src/bytes/buffer.go:202 +0x98
github.com/bogdanfinn/utls.(*Conn).readFromUntil(0xc001132000, {0xa60be0?, 0xc0001342a0}, 0x7f607b9c1fff?)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:813 +0xe5
github.com/bogdanfinn/utls.(*Conn).readRecordOrCCS(0xc001132000, 0x0)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:620 +0x116
github.com/bogdanfinn/utls.(*Conn).readRecord(...)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:586
github.com/bogdanfinn/utls.(*Conn).Read(0xc001132000, {0xc00117b000, 0x1000, 0xc000dea060?})
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/utls@v1.5.15/conn.go:1300 +0x16f
bufio.(*Reader).Read(0xc000dea000, {0xc000c19df8, 0x9, 0xc000c78ce8?})
	/home/jsn/sdk/go1.19.3/src/bufio/bufio.go:237 +0x1bb
io.ReadAtLeast({0xa60360, 0xc000dea000}, {0xc000c19df8, 0x9, 0x9}, 0x9)
	/home/jsn/sdk/go1.19.3/src/io/io.go:332 +0x9a
io.ReadFull(...)
	/home/jsn/sdk/go1.19.3/src/io/io.go:351
github.com/bogdanfinn/fhttp/http2.readFrameHeader({0xc000c19df8?, 0x9?, 0xc00139e390?}, {0xa60360?, 0xc000dea000?})
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/fhttp@v0.5.19/http2/frame.go:238 +0x6e
github.com/bogdanfinn/fhttp/http2.(*Framer).ReadFrame(0xc000c19dc0)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/fhttp@v0.5.19/http2/frame.go:494 +0x95
github.com/bogdanfinn/fhttp/http2.(*clientConnReadLoop).run(0xc001124fa0)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/fhttp@v0.5.19/http2/transport.go:2020 +0x165
github.com/bogdanfinn/fhttp/http2.(*ClientConn).readLoop(0xc00114e1a0)
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/fhttp@v0.5.19/http2/transport.go:1942 +0x79
created by github.com/bogdanfinn/fhttp/http2.(*Transport).newClientConn
	/home/jsn/go/pkg/mod/github.com/bogdanfinn/fhttp@v0.5.19/http2/transport.go:821 +0xc4a

There are many goroutines which keep running and consume server resources:

They are closed in 20m or so however. Is there a way to decrease this period? :thinking:

@bogdanfinn
I have prepared a fix in forked repositories (fhttp and tls-client). To explain it, it does the following:

Adds IdleConnTimeout field to Transport struct. Use it for both http2 and http1 requests https://github.com/bogdanfinn/fhttp/commit/f58254fca2dba96586bad1a7e9162069c818d522
Expose IdleConnTimeout to transport options https://github.com/bogdanfinn/tls-client/commit/54921c868be65a13662a1bb8ca1575b033505af6 and https://github.com/bogdanfinn/tls-client/commit/66189503ff28d14d36f8f9cb0e800d988ef76a5f

If the changes seem reasonable for you, I could create prs

@jsnjack thank you for contributing. i will take a look at the changes.
@agui2200
does one of you maybe have an example how to reproduce this issue?

Sure, I think the following should be enough. This example opens 15 https urls (http works fine):
package main

import (
	"fmt"
	"net/http"
	_ "net/http/pprof"

	fhttp "github.com/bogdanfinn/fhttp"
	tls_client "github.com/bogdanfinn/tls-client"
)

var urls = []string{
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/0ad-data-0.0.25b-bp154.1.17.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/2ping-4.5.1-bp154.1.28.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/4pane-lang-7.0-bp154.1.87.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/AppStream-lang-0.15.1-150400.1.5.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/Botan-doc-2.18.2-bp154.1.30.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/CSXCAD-matlab-0.6.2-bp154.2.22.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/ClusterTools2-3.1.2-150<IP_ADDRESS>.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/Crystalcursors-0.5-bp154.1.22.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/DVDStyler-lang-3.1.2-bp154.1.53.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/FlightGear-data-2020.3.11-bp154.1.14.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/FlightGear-docs-2020.3.11-bp154.1.14.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/GeoIP-data-1.6.12-6.3.1.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/ImageMagick-doc-<IP_ADDRESS>-150400.4.7.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/J7Z-1.4.2-bp154.1.48.noarch.rpm",
	"https://ftp.lysator.liu.se/pub/opensuse/distribution/leap/15.4/repo/oss/noarch/J7Z-kf5-1.4.2-bp154.1.48.noarch.rpm",
}

func main() {

	for _, item := range urls {
		client, _ := tls_client.NewHttpClient(tls_client.NewNoopLogger())
		freq, _ := fhttp.NewRequest("GET", item, nil)
		resp, _ := client.Do(freq)
		fmt.Println(item, resp.Status)
		resp.Body.Close()
	}

	http.ListenAndServe("localhost:6060", nil)
}

The example setups pprof endpoint on 6060. You can see hanging goroutines here http://<IP_ADDRESS>:6060/debug/pprof/goroutine?debug=1
Doing something like ls -l /proc/<pid>/fd/ | grep socket | wc -l will show you open sockets for the process

@bogdanfinn I have prepared a fix in forked repositories (fhttp and tls-client). To explain it, it does the following:

Adds IdleConnTimeout field to Transport struct. Use it for both http2 and http1 requests bogdanfinn/fhttp@f58254f
Expose IdleConnTimeout to transport options 54921c8 and 6618950

If the changes seem reasonable for you, I could create prs

Added just on comment on your changeset. Let me know what you think about it. Then you can create prs if you like :-)

Oh I see that you already have everything in order here https://github.com/bogdanfinn/tls-client/commit/e7f07b8eaef4588af9e714f82cd78d6b88dce165
I think it might be simpler for both of us if you just use this commit :) Updating module dependencies is no fun! :D

@jsnjack i was using your suggested fix yesterday to reproduce and debug this issue yes.
i will implement your comment you wrote on my commit and then create a new public version then.
Thank you very much!

Thanks!

https://github.com/bogdanfinn/tls-client/releases/tag/v1.3.10


Prevent null refs in RemoteJSRuntime

Fixes https://github.com/aspnet/AspNetCore/issues/13396

@pranavkm can you elaborate on the type of exception we can expect to see from the jsruntime in the various fail/error conditions, e.g. during timeouts?


Memory spike at fork transition

Describe the bug
Running a local devnet with 1000 validators in a single node, I noticed spikes at the fork boundary. Check how the next fork state is created.

Expected behavior
Keep memory stable

Closing issues for specific incidents on old versions of Lodestar, please re-open if it happens with latest stable


[UI] Colour of tabs does not change based on Theme

Current Behavior
In user/preferences page the colour of tabs does not change based  on dark and light theme.
Dark theme:

Light Theme:

Desired Behavior
Colour should change in accordance with the Save button for better visibility in Dark Mode
Environment

Browser: Firefox
Host OS: Linux
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Source

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@soham4abc are U working on it or if not I am interested to work on this.

I have already completed the work for this @parmishh :-)
If I find any similar issue like this I will mention you!!

@soham4abc Thanks😊


JoSS Review: Automated tests

In conjunction with the review of your package to JoSS (available at https://github.com/openjournals/joss-reviews/issues/2014), here is an issue for you to address for your submission.
Regarding automated testing, I appreciate that you already have some in place. However, there are some points to be made:

You do not detail how to run the automated tests in the instructions/README
One of the industry leaders in running automated tests is pytest, and if a naive user were to attempt to run your test suite using it, the naming conventions you have in place for the test folder and files would inhibit test discovery:

Consider renaming test/ to tests/ and test.py to recan_test.py or basic_test.py

Your tests require the user to run tests from the test/ folder itself. Running the automated tests from the top-level directory causes tests to fail. If this behavior is desired, please detail it in the instructions for running the tests.
Lastly, with regard to test coverage:

$ pytest --cov=recan .
================================================= test session starts ==================================================platform linux -- Python 3.6.7, pytest-5.3.2, py-1.8.1, pluggy-0.12.0
rootdir: /.../recan/recan
plugins: cov-2.8.1
collected 13 items

recan_test.py .............                                                                                [100%]
=================================================== warnings summary ===================================================/.../miniconda3/envs/recan/lib/python3.6/site-packages/Bio/Alphabet/__init__.py:26
  /.../miniconda3/envs/recan/lib/python3.6/site-packages/Bio/Alphabet/__init__.py:26: PendingDeprecationWarning:

  We intend to remove or replace Bio.Alphabet in 2020, ideally avoid using it explicitly in your code. Please get in touch if you will be adversely affected by this. https://github.com/biopython/biopython/issues/2046

-- Docs: https://docs.pytest.org/en/latest/warnings.html

----------- coverage: platform linux, python 3.6.7-final-0 -----------
Name                                  Stmts   Miss  Cover
---------------------------------------------------------
/.../recan/recan/recan/__init__.py       0      0   100%
/.../recan/recan/recan/simgen.py       147     48    67%
---------------------------------------------------------
TOTAL                                   147     48    67%

============================================ 13 passed, 1 warning in 3.23s ============================================= 11:32

and 3. instruction how to run the tests is added to the README
https://github.com/babinyurii/recan
folder test is renamed to tests and test.py to basic_test.py are renamed
I think the coverage is rather low because the large part of code just creates plots. I can't test the plotting statements themselves, and thus the test verifies input genetic distance values for plotting methods.

Thank you for these changes.


Is building with a more recent electron version (32) supported ? If not, is it being worked on ?

Is building with a more recent electron version (32) supported ? If not, is it being worked on ?

I dont know the answer to either of these questions but it's a I-guess-not on the second one. What would be the benefit? Do you volunteer?

Recently I have ported quba-viewer on FreeBSD. It builds and works fine. Although I have been able to make it build and run on FreeBSD with Electron 32.1.2 my knowledge on the npm/electron ecosystem is not competitive enough to make a PR.
Within my limited knowledge simply bumping electron to 32.X.X should work. I can see that you have already bumped electron-builder to 24.13.3 on head which was the key problem while trying to build with 32.1.2.
In case you are interested here is the FreeBSD build scripts:
https://cgit.freebsd.org/ports/tree/finance/quba-viewer

upgraded to electron 33


Error while using 'recursiveSplitModule'

Hi,
I'm trying to run 'recursiveSplitModule' on a sce object. The data I used is 10x data. When I run 'recursiveSplitModule', I got the following error:
Error in rowSums(counts) : 'x' must be an array of at least two dimensions
The code I used is:
data_dir <- 'D:/Data/kidney/rawData/NK08/filtered_feature_bc_matrix'
sce_NK08 <- read10xCounts(data_dir)
## select features
sce_NK08 <- selectFeatures(sce_NK08)

Any idea how I can fix this error? Many thanks.

Hi @linxy29,
Thanks for trying out our package. Can you make sure you have the latest Bioconductor release (v1.6.1) of Celda package installed by checking the following dependencies?

Bioconductor version is 3.12. You can check this by running BiocManager::version() in R.
R version >= 4.0. You can check this by running sessionInfo() in R.

If possible, can you provide the output of sessionInfo() after loading library(celda)? This will greatly help with debugging.
Thanks

Hi @linxy29, my guess is that the class of the matrix is still in sparse format. If you type class(counts(sce_NK08)) you may see something like "dgCMatrix" from the Matrix package. If this is the case, to get it to work with the current Bioconductor version of celda, you can run these commands:
counts(sce_NK08) <- as.matrix(counts(sce_NK08))
storage.mode(counts(sce_NK08)) <- "integer"

Note that a recent update to the development version of celda can handle sparse and/or numeric matrices. You can install the development version with devtools:
install.package("devtools")
devtools::install_github("campbio/celda@devel")

and it should work without having to convert the matrix.

Thanks, @zhewa and @joshua-d-campbell. After updating to the development version, the problem is solved.


make statistics window a system setting in eventgen

[#158417459]
This PR is only for changes on EventGen side. The API server and doc change will be in another PR.

LGTM

LGTM


Documentation for Service::Error behavior should say it is protocol dependent

Version
1.3.1
Platform
Ubuntu 23.10
Description
I am using hyper-util auto server. I return an error from service. Instead of sending GOAWAY and closing connection hyper sends RST_STREAM. I looked into documentation and it looks like the connection should closed, but it sends RST.

let mut builder = Builder::new(TokioExecutor::new());;

.............

let service = service_fn(move |request| {
 async move {
   println!("request");

   Err::<Response<String>, &str>("error")
 }
}

if let Err(err) = builder.serve_connection(stream, service).await {
    println!("{err}")
}

Ah ok, yea, that's a problem with the docs. They should be updated to say that the behavior depends on the protocol version. It will abort the request however the protocol allows, either with some sort of RST_STREAM, or killing the connection if that doesn't exist.

Closed by #3712


Autodetect manager

Based on https://github.com/siddharthkp/auto-install/pull/110
cc @ceafive tests break on this PR

I don't understand, were these changes reverted? I don't see them on master


[BP-1.17][FLINK-29852][Runtime] Fix AdaptiveScheduler add operator repeatedly …

Backport FLINK-29852 to release-1.17.

There is already https://github.com/apache/flink/pull/22074 running for a couple of hours, so I should be able to merge it tonight (if it passes in the next 2 hours).


Web interface only works one way

After following setup instructions as per github, I can successfuly connect to the web interface. I can press the staging button, which will activate staging in the game.
However, only the default data is displayed - it does not update or change

I tried changing my mechjeb version from the latest to <IP_ADDRESS> and a few others, but this didn't change any behaviour sadly.
I have also tried making firewall rules to let the program out, but didn't help either.
In game, I can see on kRPC that the clients are connected fine.

Any help would be greatly appreciated!

Hello @PowerFPV,
Thank you for reporting this issue. kRPC and other extensions are for the staging and flight commands section. The problem could be caused by 3 factors as far as I experienced: It could be python server (It is the window that opens when you start Kerbal Telemetry), DLL file (you can check that as well from the KSP console via Alt + F12) or unknown character errors.
We can start the diagnosis with the data.json file. It is under the Kerbal Telemetry/static folder. But it is probably containing the exact values that you see on the web interface. You can check the Python console, but I am almost sure there wouldn't be any serious errors either. These two are the most common options. You can check the KSP console as I described, maybe we see an error code there.
Also, would you tell me which platform that you downloaded it from? And did you set it up manually? Because another common issue is the file and folder order. Under the GameData folder, there should be a Kerbal Telemetry folder and a Kerbal Telemetry.dll file separately. If I know the facts of these unknowns, I can assist you further.

Thanks for the prompt reply!
The Python console seems to just be a constant loop of GET

This continues to update, which I would assume is normal as it tries to pull data.
I had a look at the data.json file. After launching a ship and then pausing, it matches up with data in KSP - the altitude, ship name, everything is correct. These are the correct values that should be on the web interface!

I have downloaded everything I'm using from GitHub, and followed instructions as per this GitHub repo's guide. Folder structure is correct.

Well, the Python console looks perfectly fine, and we have a working data extraction from KSP. Then all the arrows point to the web interface. Can you look at the browser console as well? You can use this link to open your browser console if you don't know how to do it for your browser. You can clear the website cache as well, it sometimes solves the problem since some errors caused by old version data overlapping the new update.

Cleared website cache, no luck sadly. I tried Chrome, Firefox and even Edge but all the same. Looking at web browser console, I get these reports

Sadly I'm not knowledgeable in anything java, python or the like so not sure if these errors are generic web ones or related to the issue. Firefox console shows the same errors.

Somewhere inside the data.json file, there can be an error. But interestingly, there is no sign of an issue for now. Can you copy-paste the data.json file so I can take a look at it? Sorry for bothering you so much, I don't know the exact issue so I cannot recreate it on my own machine.

Thanks so much for your help! Here is the data.json, taken from a paused flight just shortly after launch. Wasn't able to attatch to github sadly, it reckons the file isn't supported?
{"altitude":287.017507217941,"distanceTraveled":128.364892045583,"externalTemperature":30.4915478079399,"GForce":2.6864028710914,"canComm":"TRUE","situation":"Flying Low","timeToPe":284.093129347382,"lat":-0.0979980567502214,"lon":-74.5608291102572,"verticalSpeed":78.9766656163818,"missionTime":8.78000000817701,"speed":78.7621383666992,"name":"Pegasus 1","atmDensity":1.11632853200913,"currentStage":7,"deltaV":2341.75399780273,"timeToAp":8.09873137669058,"orbitSpeed":177.840940186048,"orbitIncl":1.23246732979071,"orbitEcc":0.995686664469096,"ApA":596.947918774793,"PeA":-598701.912378665,"horizSpeed":16.0841034110084,"partCount":63,"mass":96.0962896159617,"acceleration":16.6975945589751,"convFlux":255.374728808378,"radFlux":-15.3291113033998,"intFlux":32395.4407289728,"planetName":"Kerbin","yaw":258.693542480469,"pitch":81.9373779296875,"roll":-107.425117492676,"coolTemp":25.1285170099669,"coolSkinTemp":25.1914393271723,"coolSkinName":"SuperDraco Engine","hotTemp":41.2851518118914,"hotSkinTemp":32.2520552625437,"hotSkinName":"S3 KS-25 \"Vector\" Liquid Fuel Engine","critTemp":25.3298763703322,"critSkinTemp":27.43103765322,"critSkinName":"Aerocam","targetName":"NON","distance":0,"targetSpeed":0,"targetLat":0,"targetLong":0}
If there is anything at all I can do to help you solve this, I am more than happy to oblige! I very much appreciate it :)

I copy-pasted your code and you can see that data shown up on the web interface. There is nothing wrong with the `data.json` file or the .dll file. I will try to figure out what can I do and I will brief you shortly. Thank you for your patience.

I faced such problem. The solution was to delete the mod folder and reinstall the game. You can simply delete the mod, start the game and reinstall the mod.

You can try @MekoNix's solution idea and check that if it works for now. I am trying to find a general solution since I am not the "reinstall until it works" kind of developer, I will find a way to fix it properly. I installed the game and the mod on four different machines and still couldn't recreate the issue. Tell me if you see an error message of any sort. I developed an error catching algorithm to catch every message. I will polish it and send it to you from here, and we can check if there are any problems that we couldn't see.

Since you have not replied for a while, I will close the issue right now. If you encounter the same issue again, please do not hesitate to tell.


Auto deploy won't work with GCN part

Possibly due to dependency. Manually deploy it for now.

Looks like things are building now after twerking the dependency.
It's pretty cool that we can use the github action resource to train on a small dataset...


Capstone Project Assignees

https://github.com/Ochiengsteven/Module2-Capstone
We are a group of 2 students.

Hi @RicardoEgas and @Ochiengsteven, Kindly update the link in your description above to the link to your GitHub project (kanban board)

@RicardoEgas and @Ochiengsteven, this is the correct  link you should add to the issue above 👍🏿

Hi @Team
Your board setup is complete!
Congratulations! 🎉
Highlights

Good setup   💯

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Feature Request]: Add Exception for Admin username.

When logged in with the user ADMIN from a generated link you cannot access the SeatGroups Link to alter the groups from that username. Due to the token from what I can tell.  Can you add in an exception to that specific user so its editable in case permissions are going crazy from token issues?

I can't reproduce your finding. There is nothing that would prevent admin to configure/manage seatgroups.

can you try to elaborate your finding and provide me intel on how to reproduce?

Check to see if your Admin user has a Token assigned and if its "valid" according to SeAT.  Thats the only thing I can think of as the difference.


Add controllers Factory

Description of changes:
This is the first step towards a more flexible controllers/reconcilers
initialization. Moving the construction out of main and integrating with
the dependencies factory.
The next step would be to remove the provider specific reconciler
construction out the main cluster reconciliation loop.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Broken link on project description

Problem description
Clicking the "Override individual component styles via the style prop" link in the project description redirects to a page that is broken (console says "Uncaught TypeError: n.getCurrentLocation is not a function")
Solution:
Change the link
from:
http://www.material-ui.com/#/customization/inline-styles
to:
http://www.material-ui.com/#/customization/styles

Thanks for the feedback.


Test specific flags in Cranelift filetests

In #1880 @bnjbvr brought up an issue with how Cranelift's filetests use (or don't use) ISA-specific flags. He was trying to use target x86_64 use_new_backend in a test run filetest but the SingleFunctionCompiler doesn't know anything about ISA-specific Flags, only shared Flags. (Perhaps these two sets of flags should be merged in some way, but what I will propose next doesn't require that).
The current behavior is:

check if the default host architecture (used by SingleFunctionCompiler) is the same as the one specified by the target directive; if not, skip the test (though in the future this should print some sort of IGNORED [filename] so the user knows what happened, see #1558)
compile and run the test using the default host TargetIsa

I propose we change the behavior to:

check if the default host TargetIsa is compatible with the one specified by the target directive; if not, skip the test, etc.
compile and run the test using the target directive's TargetIsa--this will use any special flags assigned by the user, e.g. use_new_backend

To get this "is compatible with" behavior, I propose we add a new Flags::matches function to the shared Flags and to each ISA-specific Flags (this likely has to be done as generated code in gen_settings.rs so it only needs to be done once). Then, we expose this function as TargetIsa::matches and implement it in each ISA as self.flags.matches(&other.flags) && self.isa_flags.matches(&other.isa_flags). This way we can compare TargetIsa's for compatibility.
How does Flags::matches work? I think it needs to iterate over the field descriptors and compare them both to the default value and to the other value. Remember that matches only goes one way: if a matches b it does not necessarily mean that b matches a. Though it passes some simple tests, I'm not 100% confident that the following is correct so I would appreciate feedback:
fn get_bit(byte: u8, bit: u8) -> bool {
    let mask = 1 << bit;
    (byte & mask) != 0
}

impl Flags {
    fn matches(&self, other: &Self) -> bool {
        let shared_default = settings::Flags::new(settings::builder());
        let default = Flags::new(&shared_default, builder());

        // Check each detail until we see presets.
        let mut byte_offset = 0;
        for d in &DESCRIPTORS {
            byte_offset = d.offset as usize;
            match d.detail {
                detail::Detail::Bool { bit } => {
                    let self_bit = get_bit(self.bytes[byte_offset], bit);
                    let default_bit = get_bit(default.bytes[byte_offset], bit);
                    let other_bit = get_bit(other.bytes[byte_offset], bit);
                    if self_bit != default_bit && self_bit != other_bit {
                        return false;
                    }
                }
                detail::Detail::Num | detail::Detail::Enum { .. } => {
                    let self_byte = self.bytes[byte_offset];
                    let default_byte = default.bytes[byte_offset];
                    let other_byte = other.bytes[byte_offset];
                    if self_byte != default_byte && self_byte != other_byte {
                        return false;
                    }
                }
                detail::Detail::Preset => break,
            }
        }

        // Then check each preset bit.
        for byte_offset in byte_offset + 1..self.bytes.len() {
            for bit in 0..8 {
                let self_bit = get_bit(self.bytes[byte_offset], bit);
                let default_bit = get_bit(default.bytes[byte_offset], bit);
                let other_bit = get_bit(other.bytes[byte_offset], bit);
                if self_bit != default_bit && self_bit != other_bit {
                    return false;
                }
            }
        }

        true
    }
}

Other thoughts:

the function should probably be named has_compatible_flags or is_compatible_with or something like that
@bnjbvr had issues getting Parser to set the right CallConv--the host's--for the functions it parsed; I think what I described above avoids this issue because we only would be comparing flags and since https://github.com/bytecodealliance/cranelift/pull/942 Parser is already setting the calling convention to the host's default, see https://github.com/bytecodealliance/wasmtime/blob/master/cranelift/reader/src/parser.rs#L96-L101.

Thanks for opening an issue! I think the above is a correct description of the problems I've ran into.

agreed with is_compatible_with which is a better name than matches (although that's the one i used in our zulip discussions :))
the issue with CallConv is two-fold: the SingleFunctionCompiler will check that the calling convention defined by the ISA defined the one used by the function (= the one defined by the parser). But if we use the TargetIsa defined by the target directive (from the parser), since the target directive doesn't know about the OS that's used for testing, it'll use the SystemV calling convention by default. This caused issues on Windows; my partial workaround was to try to set the Triple's missing fields with the Triple's host fields when they were missing during parser, but it was not pretty at all. Perhaps we could just override the CallConv field of the Function's signature and get away with it; I haven't tried this (there might be other places where the initial CallConv setting leaked, e.g. libcalls).

Regarding the Flags::matches implementation, at a skim it seems correct. I wonder if checking for the setting is set to the default value is correct; there's no way to distinguish between "the value has been manually set to use the default" vs "the value hasn't been set at all" (and we'd probably want to do the full if check only in the latter case). We probably don't need to check for presets either, since they're just sets of other settings that could be manually defined without using presets (for instance, one can set add to the target directive the use_sse_41 and use_popcnt flags and get the same set of features that nehalem enables, without explicitly using the nehalem preset).
(Bonus points if you can get a way to have x86 32-bits tests running on x86 64-bits hosts :-).)