feat(nuxt): server/client only composables

🔗 Linked issue

Not an issue but to unblock me on https://github.com/nuxt/nuxt/pull/19302
❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Background
Isolating composables to a specific environment is a useful way to optimise bundles. There are many instances of code which only needs to run on a single environment.
For example, with head data, it's more likely that you only need to add head data on the server, rather then having the client hydrate it.
There is currently a way to handle this by wrapping code in env if blocks. This works okay, but it means the function arguments won't be tree-shaken (afaik).
You can wrap the composable call itself but this gets pretty verbose quickly and is not something module authors have control over.
export function useServerLog(input: any) {
  if (process.server) {
    console.log(input)
  }
}

<template lang="ts" setup>
// this is kept in the client build?
useServerLog({
  foo: 'bar'
  bar: 'foo',
  baz: 'bing',
  bong: 'bar',
})
// verbose!
if (process.server) {
  useServerLog({ /* */ })
}
</template>

Solution
We want to give users and module authors all the power they need to optimise bundles while keeping a good DX. This means opening up access to specifying which composables get tree-shaken in which environments.
Nuxt already has a solution for tree-shaking which we can leverage.
Feature 1: .server / .client file name support
Following the existing Nuxt paradigm of server/client only plugins / components, we allow composables to have .server or .client in the file name, then we tree-shake the composable for the opposite environment.
For example:
// ~/components/db.server.ts
export function updateSomeDbValue(options) {
   // ...
}

This will get tree-shaken out of the client build.

For another example, we can have a composable that accesses the DOM directly, with the tree-shaking we can call this function without it breaking the server build.
// dom.client.ts
export function setBgRed () {
  window.document.body.style.background = 'pink'
}

<template lang="ts" setup>
setBgRed() // SSR just works since it's tree-shaken
</template>

Feature 2: Allow module authors to mark composables as tree-shakable
This acts as an escape hatch for module authors who don't have control over the file name of the composable. For example, if they're importing from a third-party vue package.
Due to the nature of how most imports are imported, providing the mode as part of the import source registration seem a bit too breaking.
Instead we just have a simple function to add the component names.
For example, this could be used with @unhead/vue
addImportSources({
  from: '@unhead/vue',
  imports: [
    'useServerHead',
    // ...
  ]
})

markTreeShakableImports([ 'useServerHead' ], 'server')

<template lang="ts" setup>
useServerHead({}) // will be removed from client build
</template>

Limitations

If there are any side effects outside of the scope of the composable, these can't be tree-shaken. These may lead to some unexpected issues.

For example
// will be included in client bundle afaik
const myDbCredentials = 'username:password'
export function updateSomeDbValue(options) {
   db.connect(myDbCredentials)
   // ...
}

Currently we're restricting composables that don't use the return value, purely because that's what the regex was doing beforehand. Would it make sense to allow a return type?

For example
<template lang="ts" setup>
const val = updateSomeDbValue({/* */}) // this won't be get tree-shaken
</template>

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

Interesting idea! However, I have a few questions:

Should we allow both .server and .client functions to explore the same name to have different functions in different env? If so, it might need some changes on the unimport side.
Note: This will only work with composables when you aren't using their return value. - This pitfall feels a bit too much and may lead to confusion. And honestly might not be that useful as in many cases the return value is important. It was working for Vue because we are tree-shaking mostly the hooks.
The side-effects could also lead to confusion, as from a higher view, users would see the imports in .server being executed on the client side. It can be counterintuitive.

In that sense, I think I would push back for the current implementation as I see the trade-off is not worth it. People better use onMounted or if (process.server) or dynamic import to explicitly control the boundary at this moment.

Interesting idea! However, I have a few questions:

Should we allow both .server and .client functions to explore the same name to have different functions in different env? If so, it might need some changes on the unimport side. (could also lead to problem of function signatures not matched)
Note: This will only work with composables when you aren't using their return value. - This pitfall feels a bit too much and may lead to confusion. And honestly might not be that useful as in many cases the return value is important. It was working for Vue because we are tree-shaking mostly the hooks.
The side-effects could also lead to confusion, as from a higher view, users would see the imports in .server being executed on the client side. It can be counterintuitive.

In that sense, I think I would push back for the current implementation as I see the trade-off is not worth it. People better use onMounted or if (process.server) or dynamic import to explicitly control the boundary at this moment.

Thanks for the detailed review! Good points
I agree that it could be a useful feature but the limitations open the scope for too many issues. I'd like to see it in Nuxt one day but sounds like some work needs to go into Unimport first.
I've minimised the scope of this PR to only make the treeShake config extendable which I think is a bit more reasonable.

Merging so @harlan-zw can go ahead with linked PR. But would particularly appreciate feedback @antfu on the schema change in this PR. If we do end up supporting something like this in unimport down the line, does it give you enough info? (it's in the preset format, so Record<packageName: string, imports: string[]>).
(Happy to change the schema before we release v3.3 if you have any suggestions for improvement.)


Ajouter le filtre de nature juridique

closes #106
closes #162

but please lint this code

@geoffreyaldebert It's the same lint issue (push vs pull request), it will disappear once I merge...


[BUILD]openimageio binding in python doubt

hello;
I am using the brew install openimageio, unable to success will be my/usr/local/Cellar/openimageio <IP_ADDRESS> / lib, and my python3.7 binding.Can I have a detailed demonstration? Do I not quite understand how openimageio is installed on my python3.7

Old and not very descriptive. Closing, with apologies that nobody directly replied as soon as it was filed. If this is still a problem, please re-open with a detailed description of how to reproduce.


Java Bitwise Operator Audio file #1614

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #1614

Type of change 📝

[x] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[x] Java_Domain

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Palak-Srivastava Please make a new PR and the new branch should be a branch of Java not main, currently it is of main.


HBASE-24897 Assign primary regions firstly when create table with reg…

…ion replica

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  2s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-2.2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 11s
branch-2.2 passed

+1 :green_heart:
compile
1m 34s
branch-2.2 passed

+1 :green_heart:
checkstyle
1m 30s
branch-2.2 passed

+1 :green_heart:
shadedjars
4m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
branch-2.2 passed

+0 :ok:
spotbugs
3m 15s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 41s
branch-2.2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
1m 36s
the patch passed

+1 :green_heart:
cc
1m 36s
the patch passed

+1 :green_heart:
javac
1m 36s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
25m  9s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
1m 28s
the patch passed

+1 :green_heart:
javadoc
0m 50s
the patch passed

+1 :green_heart:
findbugs
5m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 41s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
160m 40s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
1m  8s
The patch does not generate ASF License warnings.

231m 34s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2271

Optional Tests
dupname asflicense cc unit hbaseprotoc prototool javac javadoc spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 57f30e136875 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2271/out/precommit/personality/provided.sh

git revision
branch-2.2 / 8329591b45

Default Java
1.8.0_181

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/1/testReport/

Max. process+thread count
3699 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Catch the exception here? Wondering this could happen after the regions are assigned as well.

Catch the exception here? Wondering this could happen after the regions are assigned as well.

Yes. Not the best way but useful now.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.2 Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
branch-2.2 passed

+1 :green_heart:
compile
1m 12s
branch-2.2 passed

+1 :green_heart:
checkstyle
1m 42s
branch-2.2 passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-2.2 passed

+0 :ok:
spotbugs
3m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 27s
branch-2.2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
checkstyle
1m 15s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
25m 59s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
javadoc
0m 37s
the patch passed

+1 :green_heart:
findbugs
3m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
176m 41s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 36s
The patch does not generate ASF License warnings.

240m 49s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2271

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d2dcc65d5192 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2271/out/precommit/personality/provided.sh

git revision
branch-2.2 / 8329591b45

Default Java
1.8.0_181

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/2/testReport/

Max. process+thread count
2861 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2271/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Add log filtering for backup logs

Backup logs contain the credentials - they should be hidden. We have to post process the logs and filter for credentials.

Implemented in #349


Upgrade nacos 1.4.3

Tests passed.
Upgrade plugins version, keep same as Spring boot.
Introducing Testcontainers to do integration tests.
NOTE: nacos 1.4.3 replaces the verification method, can no longer use localhost:8848, use  <IP_ADDRESS>:8848 to replace it.

Due to some problems with the authentication method of Nacos 1.4.3, we decided to use Nacos 1.4.2!


How to check animation is starting?

Hi everybody
I can't find any method/property for check animating start in view? (like isAnimating)
for example start animating in viewWillAppear function and i want when tableview is reloading and finish work in didEndDisplaying func; stop animating...
Thank's

@ghasim: Please check README first. Let me know if it's what you're looking for.

This solution is very bad. I had to define
var activityIndicatorView = NVActivityIndicatorView(frame: frame, type: type, color: color, padding: padding)
in viewDidLoad and when can't use activityIndicatorView in another function ! if define local variable
let activityIndicatorView = NVActivityIndicatorView()
code is error: Cannot invoke initializer for type 'NVActivityIndicatorView' with no arguments
I want check animating like UI blocker func. like this code:
if isAnimating{}
Thanks

@ghasim: Please give snippet, it helps figure out solution for your use case.

Close this, reopen if need be.


KV namespaces are undefined , if miniflare is runned with modules enabled

If miniflare is runned with modules enabled like below,
miniflare -w -m kvtest.js -k TEST_NAMESPACE1 -d
[mf:dbg] Options:
[mf:dbg] - Scripts: kvtest.js
[mf:dbg] - Modules: true
[mf:dbg] - Modules Rules: {ESModule: **/*.mjs}, {CommonJS: **/*.js, **/*.cjs}
[mf:dbg] - KV Namespaces: TEST_NAMESPACE1
[mf:dbg] Reloading kvtest.js...

The KV Namespaces show up in the debug output but trying to access them in code returns undefined.
For example the following code would return  ReferenceError: TEST_NAMESPACE1 is not defined
// kvtest.js
addEventListener("fetch", (e) => {
  e.respondWith(
    TEST_NAMESPACE1.get("key").then((value) => new Response(value))
  );
});

Running the same code with modules disabled returns null.

I think we should add this to the miniflare documentation. As of now miniflare documentation doesn't address this issue.

For the export solution proposed by @mrbbot, I think the --bundle option also needs to be removed from esbuild steps.


flicker when changing the polygon

I use the polygon size 5 times the viewing area
I use<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
import React from 'react';
import {View, StyleSheet} from 'react-native';
import {MapView} from 'expo';

const styles = StyleSheet.create({
   container: {
      position: 'absolute',
      top: 0,
      left: 0,
      right: 0,
      bottom: 0,
      justifyContent: 'flex-end',
      alignItems: 'center',
      backgroundColor: 'red'
   },
   map: {
      position: 'absolute',
      top: 0,
      left: 0,
      right: 0,
      bottom: 0,
   },
});

export default class App extends React.Component {
   state = {
      region: {
         latitude: 37.78825,
         longitude: -122.4324,
         latitudeDelta: 0.0922,
         longitudeDelta: 0.0421,
      }
   };

   handleRegionChange(region) {
      this.setState({region});
   }

   renderPolygon() {
      const region = this.state.region;
      const padding = 5;
      const minLat = region.latitude - region.latitudeDelta / 2 * padding;
      const maxLat = region.latitude + region.latitudeDelta / 2 * padding;
      const minLng = region.longitude - region.longitudeDelta / 2 * padding;
      const maxLng = region.longitude + region.longitudeDelta / 2 * padding;

      const coordinates = [
         [minLat, minLng],
         [maxLat, minLng],
         [maxLat, maxLng],
         [minLat, maxLng]
      ].map(([lat, lng]) => ({latitude: lat, longitude: lng}));

      return <MapView.Polygon
         coordinates={coordinates}
         fillColor={"rgba(51,136,255,0.5)"}
      />
   }

   render() {
      return (
         <View style={styles.container}>
            <MapView
               region={this.state.region}
               onRegionChange={this.handleRegionChange.bind(this)}
               style={styles.map}
            >
               {this.renderPolygon()}
            </MapView>
         </View>
      );
   }
}

is there any information? maybe I could somehow help

I'm struggling with the same problems. Especially when using the polygon with many holes. Have you found a solution for your problems?

No =(

After testing this I figured out that it is an Android specific thing. On iOS the polygon is being updated without the flickering. Maybe someone could take a look on the Android implementation of the Polygon? That would be awesome as my app is highly based around the polygon feature.

When you compare both implementations you see that the Android one might be much slower pretty because each coordinate of the polygon and its holes is being read from a map data structure like this:
AirMapPolygon.java, line 39:
new LatLng(coordinate.getDouble("latitude"), coordinate.getDouble("longitude")));
On the iOS side its just a simple Array read like that:
AIRGoogleMapPolygon.m, line 29:
[path addCoordinate:coordinates[i].coordinate];
Maybe there might be some improvements on that line of code.

Please anyone, it works so well on iOS. It would be awesome if Android could be improved.

@alvelig Sorry to mention you directly but I've seen you fixed some issues regarding flickering of markers. Maybe you could take a look at this one here as well? It would be highly appreciated :)

@oliverdolgener are you using the master branch or expo version?

@alvelig the expo version. Has this already been fixed on the master?

I don't know. You can try.
We here don't support expo, but react-native init version.

@alvelig I can eject and try again with the master branch. I'll let you know. Thank for the heads-up.

@oliverdolgener please don't eject. Build a separate project just to reproduce the problem, target react-native-maps package to master branch in package.json and share it on github. That's the best way to reproduce it.

@alvelig Did you have the time to check out my repo? It's a really annoying issue that blocks my app from being released soon.

Hey @oliverdolgener! First of all thank you for making a reproducible repo, this will definitely help to nail down the issue. Sorry, I've been busy lately. But next week should be easier to find time to have a look at it.
https://workhardanywhere.com/wp-content/uploads/2017/02/keep_calm-1.jpg

@alvelig Any news on this one?

Hey @alvelig are you still working on this issue? Please let me know if you need anything to further progress!

Having the same issue. My polygon is flickering when setting the camera on mapview.

Have the same Issue

It certainly seems to be a problem with the native Google Maps Android SDK. We've created an issue and it seems to be fixed on the next major release. So there's hope! :)
https://issuetracker.google.com/issues/35829280

Response from the Google Maps Team:

Marked as fixed.
Dear developers,
The Maps SDK for Android has recently received a major overhaul, now available in Beta, which made many bugs and feature requests inapplicable or obsolete.
We believe that the issue or feature request reported here has been fixed or is inapplicable with this new release, and therefore closed this report.
You can give this new release of the SDK a try by following the steps in our migration guide [https://goo.gle/v3-migration-guide].
This is a beta release, and we rely on your feedback in the new component of our Issue Tracker [https://goo.gle/gmp-android-sdk-beta-issues] to help us exit beta as quickly as possible with a healthy, happy, bug-free SDK.
The full announcement for this new release is available on our blog at https://cloud.google.com/blog/products/maps-platform/whats-next-for-google-maps-platform.
Thank you,
The Google Maps Platform team

I already tried to enable Google Maps SDK 3.0.0 Beta for Android but I wasn't able to get it running. Maybe someone else could help me with that?

I have the same issue with Marker component. I have server-side clustering and here is what is happening when some markers disappears and new appears:


Added support for setGraphExecutorOptimize with torchscript models.

Description
This PR adds support for torch::jit::setGraphExecutorOptimize which allows the user to prevent model "warmup" periods while torchscript optimizes the model on GPU.
Users can disable the torchscript optimization with the following code:
System.setProperty("ai.djl.pytorch.setGraphExecutorOptimize", "false");

Since this feature is enabled by default in torchscript, it will only enable/disable optimize when the system property has been set.
This change is backwards compatible and does not alter the usage of any existing code.

@frankfliu I created it as a draft pull request as this is my first pull request. Please have a look and you can mark it ready for review.

After doing some testing, there is currently a bug with multi-threaded inference where it will have the same multi-second delay after a few inferences. It does not happen single threaded.
I have fixed it by running PyTorchLibrary.LIB.setGraphExecutorOptimize(false); before every time PyTorchLibrary.LIB.moduleForward is called. This indicates that when using multiple threads, the value of the setGraphExecutorOptimize is being reset in the JNI code or it is not being respected.
I propose that we add another parameter to PyTorchLibrary.LIB.moduleForward which takes in whether setGraphExecutorOptimize is true or false and sets it each time.
I am going to continue investigating to see if I can figure out why the value is not being respected when set in the PtSymbolicBlock on the first inference and only when using more than one thread.

I was able to resolve this by calling JniUtils.setGraphExecutorOptimize(false); in each thread I planned to use. I do not have much experience with JNI, but it seems that because each thread provides its own environment to each JNI call, this causes the reset.
I think the best course of action would to be add a parameter to PyTorchLibrary.LIB.moduleForward as I mentioned above. Let me know what you think.

It might be a good idea to just allow the developer to utilize the JNI function how they want rather than focusing it one way or another. This flexibility will be needed in some situations, like if you want to load models on one thread with optimization and another set of models without optimization. With this global approach, it is much less flexible and it doesn't enforce any changes.
I just reverted my changes to PtSymbolBlock as I think flexibility is the way to go.

Codecov Report

Merging #904 (6ddac4b) into master (e819389) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #904      +/-   ##
============================================
- Coverage     70.34%   70.24%   -0.10%
+ Complexity     5085     5076       -9
============================================
  Files           501      501
  Lines         22432    22437       +5
  Branches       2332     2335       +3
============================================
- Hits          15779    15761      -18
- Misses         5412     5433      +21
- Partials       1241     1243       +2

Impacted Files
Coverage Δ
Complexity Δ

...ine/src/main/java/ai/djl/pytorch/jni/JniUtils.java
90.57% <0.00%> (-0.30%)
194.00 <0.00> (ø)

...c/main/java/ai/djl/pytorch/jni/PyTorchLibrary.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

api/src/main/java/ai/djl/util/Platform.java
43.47% <0.00%> (-5.36%)
8.00% <0.00%> (ø%)

...djl/training/listener/LoggingTrainingListener.java
83.18% <0.00%> (-5.31%)
22.00% <0.00%> (-6.00%)

api/src/main/java/ai/djl/repository/Artifact.java
89.65% <0.00%> (-3.45%)
36.00% <0.00%> (-2.00%)

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
4.00% <0.00%> (ø%)

api/src/main/java/ai/djl/training/Trainer.java
91.83% <0.00%> (-3.07%)
33.00% <0.00%> (-1.00%)

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
21.00% <0.00%> (ø%)

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
42.23% <0.00%> (-1.25%)
15.00% <0.00%> (ø%)

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
51.14% <0.00%> (ø)
14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e819389...6ddac4b. Read the comment docs.


Add options menu

Interpolation options, expose possible interpolation options in PIL
Change Minkowski p-norm. Show "euclidean" or "manhattan" for p=2 and p=1.
Color space choice: RGB, YCbCr, HSV... perform nearest neighbors search in this space

Added in da13a6547b46773222c68e4607b2f06a5e1d7fe7.


PR: Add requires-python to Cargo.toml

Fixes #153

We need to wait until Github Actions is back on


only one pod can be access???

I create an nginx deployment with three replicas.and  i create a svc.
like this:
[root@master ~]# kubectl get  pod -o wide
NAME                       READY     STATUS    RESTARTS   AGE       IP               NODE
my-nginx-379829228-0d203   1/1       Running   2          16d       <IP_ADDRESS>   slave01
my-nginx-379829228-v47h8   1/1       Running   2          16d       <IP_ADDRESS>      slave02
my-nginx-379829228-xs2l5   1/1       Running   2          16d       <IP_ADDRESS>   slave01

when i access the nginx serivce,only one pod can be reach .
[root@master ~]# kubectl logs -f my-nginx-379829228-0d203

^C
[root@master ~]# kubectl logs -f my-nginx-379829228-xs2l5

^C
[root@master ~]# kubectl logs -f my-nginx-379829228-v47h8
<IP_ADDRESS> - - [20/Jan/2017:05:58:34 +0000] "GET / HTTP/1.1" 200 612 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36" "-"
2017/01/20 05:58:35 [error] 5#5: *1 open() "/usr/share/nginx/html/favicon.ico" failed (2: No such file or directory), client: <IP_ADDRESS>, server: localhost, request: "GET /favicon.ico HTTP/1.1", host: "<IP_ADDRESS>:30062", referrer: "http://<IP_ADDRESS>:30062/"
<IP_ADDRESS> - - [20/Jan/2017:05:58:35 +0000] "GET /favicon.ico HTTP/1.1" 404 571 "http://<IP_ADDRESS>:30062/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36" "-"

@pennpeng Can you provide the spec of your service? Did you enable session affinity? Are you seeing dropped requests, or are all requests succeeding?

I've seen this many times with services in KET, hand-crafted and GKE clusters. I believe this to be a result of Kubernetes service load balancing just not working the way I -- and you -- expect, especially with a small volume of requests.
First, it's not strictly round robin -- e.g. if you request 3 things, you aren't guaranteed to retrieve 1 thing from each server.
There's also the issue of connection stickiness. Modern HTTP systems keep connections around for quite some time and it's the connection that's load balanced through a service. If you hit refresh a bunch of times in your browser, you may never leave the same connection, which with a K8s service (and indeed any layer 4 balancer) would mean all your traffic goes to the same pod.
Try throwing some time-seperated volume at at and see if you get different results. Here's a cheap way to do that:
`watch -n 5 curl "http://yourservice/"
This will call your service once every n seconds. Let it run for a minute. I expect you will see roughly equivalent load the longer you let it run.


—
Reply to this email directly, view it on GitHubhttps://github.com/dapr/dapr/pull/5531#event-7848351827, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASEL6BVZY7JGH75I2BBDPDDWJAMWNANCNFSM6AAAAAASDAVGXE.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Refactor the performance measurement system

I'm trying to add some new tests into current benchmark system, found out that there were some places that can be improved.

different time measure method in different files, some files uses gettimeofday, some files uses clock_gettime, other files uses both of them.

common memory allocation module such as huge_malloc is defined in many places.

Here is the improvements.

Extract a single bench.h file that includes all of the common performance functions mentioned above, which can shield the differences of time measure method.

Add three common functions begin(), end(), getsec(), in order to simplify the test case invocation.

Currently only 11 test cases were modified and tested in X86/ARM, The remaining 44 test cases will modified too if current scheme is accepted.

BG info: I am not the approver of any kind, just giving my humble opinion. I did some polishing of R scripts in subdirectory few times.
Shortening code by using abstraction is very desirable because after:

the benchmark code fits in few screens to spot bugs easier
the abstraction does same
While you are at it if you have chance - try static checkers - cppcheck , clang-analyzer aka scan-build , gcc -std=c18 (or c11) , this code got less (to no) attention than main runtime in this regard, this is by no means showstopper, just do it if it is easy to do.


Fix get config parameter function.

Why are these changes needed?
Fixing a bug in getting the config parameter. Fixed according to @yuanchi2807 suggestion.
Related issue number (if any).
Fixes #425

@yuanchi2807 none whatsoever


[BUG] Breadcrumb links have not correct url on product detail

Summary
Breadcrumb links have not correct url on product detail. Locale is missing in the urls.
Steps To Reproduce

Checkout project in version 1.4.0-dev develop branch
npm ci
npm run start
Open https://localhost:3000 in your browser
Go to category womens
Click on a product to reach product detail
Click on link Womens in Breadcrumb
Error is rising with page not found

Expected result
Can click on a link in the PDP Bread Crumb and reaching the correct page with current selected locale.
Actual result
On clicking a link in the Breadcrumb on product detail a page not found error is showing up.
System Information (as applicable)
Browser: Microsoft Edge 97
Node version: Node 14
pwa-kit version: 1.4.0-dev develop branch
Desktop OS: macOS Montery
Mobile Device Info: -
Additional information
x

@nx-renezwinge Thanks for creating the issue with pwa-kit. I see that you are using the latest version. I tried to reproduce the issue using our hosted production site on the same version, and was not able to do so - https://pwa-kit.mobify-storefront.com/
Is that something that occurs when you run it locally? If yes, can you also try after clearing your local cache? Thanks!

Hi @sejal-salesforce ,
it was my mistake, i updated my original post, it is the current develop branch 1.4.0-dev.
I retested it and deleted cache and i currently notify this problem in develop branch 1.4.0-dev.


Investigate failure in emergency_upgrade_test_balances.sh

Nodes are expected to have no errors in logs, yet two of them reported the "historical block should not be executed".
Link to the failed build: https://drone-auto-casper-network.casperlabs.io/casper-network/casper-node/8466/1/4.

6.15.23 - AJ to rerun on 1.5.1 RC to see if the logs report what was addressed in the PR is what IS happening.   NO new release candidate expected either way.


SSE Server-Sent-Events Example (IDFGH-12605)

Is your feature request related to a problem?
I tried creating Server-Sent-Events SSE from the examples withouth any succes.
Server-Sent Events (SSE) is a server push technology enabling a client to receive automatic updates from a server via an HTTP connection, and describes how servers can initiate data transmission towards clients once an initial client connection has been established.
They are commonly used to send message updates or continuous data streams to a browser client and designed to enhance native, cross-browser streaming through a JavaScript API called EventSource, through which a client requests a particular URL in order to receive an event stream.
Describe the solution you'd like.
An Example, how to open a connection, and async listen for data with a callback that is trigger once new data arrives that the server is sending. The current examples are too blury as a starting point.
I think it's a great feature, and its supported by firebase.
Describe alternatives you've considered.
Tried modifying the examples with no succes.
Additional context.
Creates the ability for serverless IoT unidirectional communication Server->ESP32

How did you end up implementing it? I'm currently trying to use SSE as well.

Hi @CharlesMcBaker Thanks for the issue.
Based on your comment you have already successfully implemented the example.
Is it possible for you to share your code by raising a pull request in esp-idf.
It would be helpful for others who are interested in the same feature.
You can follow the guidelines for contributing to esp-idf. Please let me know if you need any help for raising up a PR.

@gudvinr, Thanks for your response.
To share an update from the last time, We have already implemented the SSE handler, the MR is in progress to be merged internally.
Thanks for your inputs.


Add tests for plaintext leaking in logs

It's very important we don't leak plaintext messages in logs. We should be able to test that stdout/log files do not contain certain sentinel strings. This may require some kind "please enable verbose logging" option in the API.

If you mean that you need such an API in the bindings, you should be able to do this already: https://github.com/matrix-org/matrix-rust-sdk/blob/2a03de3bd5ffd57dc63328964cb430be786d426e/bindings/matrix-sdk-ffi/src/platform.rs#L246-L252.

I mean the complement-crypto API - most SDKs have the ability to enable trace logging somehow. I use the rust one already.


Update rook module and image

Update the rook dependency and the image to a version which has the fix to prevent a crash during the uninstall procedure.

@jarrpa @obnoxxx @umangachapagain I am requesting this bump up mainly because we fixed a crash in rook recently without which the uninstall procedure does not complete. The crash was fixed in the release-1.4 branch of rook before the 1.4.6 tag.
The PR for the release-1.4 branch is https://github.com/rook/rook/pull/6372/commits
cc @iamniting

The changes are fine, but i'm confused how this PR got merged without lgtm.
Also, the required tests weren't passing.

@umangachapagain I think I know why this got merged without a LGTM.
I raised two PRs yesterday, #850  and this one.
#850 depends on this PR and has the 3 commits of this PR and 2 commits on the top. @jarrpa provided the LGTM on that one and the PR got merged. Git/Github determined that the 3 commits in PR are merged in #850 and closed this PR as merged.
Raising PRs dependent on each other like this is usual but this is the first instance where I have seen the merge bot work like this. Need to see if the merge bot can be configured to block the merging of dependent PRs till other PRs are merged.


fix: use Scratch's FieldAngle

This PR cleans up and slightly modernizes Scratch's FieldAngle implementation, and uses it in favor of the version provided in Blockly Samples.

This fixes #63 and fixes #101.


RTL support doesn't work in UWP

HP claimed that in the UWP renderer, when running on a full RTL machine (no other languages installed) and displaying a card with RTL content, it doesn't correctly invert the content, they had to do some special work to fix that.
We should test our renderer in RTL languages and check if we can repro this issue.

Linked to https://github.com/microsoft/AdaptiveCards/issues/2144
It's also unclear if the language field has any effect on RTL rendering (which only mentions date/time - but that makes no sense as it's a 2-char language field, and the date/time formats are defined by locale).
Note that properties like horizontalAlignment operate with values like "left" and "right", which are inherently ambiguous in a RTL context. I would recommend (also) supporting more directional terms to avoid confusion (like flexbox uses "start" and "end")..

This should be fixed in the newest builds; if not, please re-open and we'll engage. Thanks!


Add ability to extend rules and actions

We can extend rules and actions from any defined one in the system. And have an ability to override some particular properties.
This will allow to maintain a big amount of similar rules in easy way.

This should be done outside of Parser.


feat(config): unite the values of rpc.starknet_url and central.url

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

Commit type should be chore with config scope, that is, chore(config): ...


Error in sample 04.0-transfer-file: No credentials found for File, will not copy

Discussed in https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/discussions/535

Originally posted by saudkhan116 January 20, 2022
I am trying to run the sample 04.0-file-transfer from the main branch, I got success in contract negotiation but the file transfer process is not working because of the following repeated error:
Error processing transfer request. Setting to retry: 12c044c2-9b7a-486f-a6be-fc45a0bb62b4 Copying data from File to File No credentials found for File, will not copy!
The following steps are executed:

Build and start the connectors, works fine
Initiate contract negotiation, works fine and returned the UUID
Look up the contract agreement ID, works fine, and got the agreement ID
Request the file, thrown the above error

I followed the step by step readme and used the following command to request the file transfer:
curl -X POST "http://localhost:9191/api/file/test-document?connectorAddress=http://localhost:8181/api/ids/multipart&destination=C:/Users/USERNAME&contractId=1:e6f3bda6-c6c5-40b3-8f29-fd0b65bff883"
The only variable which is set in config.properties from the provider side: edc.samples.04.asset.path=C:/Users/USERNAME/Desktop/test-document.txt" (the test-document.txt is placed in Desktop folder) and others remain with default values
I don't know if I am missing some configuration there.
Your advice and feedback would be helpful.

Fixed within #514.


Document how to show top-level mappings

I discovered this simple yet very useful way to view top-level maps:
:lua require('which-key').show()

I suggest you add this to the readme.  I think many others would find this useful as well.  I have this in my init.vim:
nnoremap <leader>k <cmd>lua require('which-key').show()<cr>

Tou may not need to that keymappings. Instead, you can bring up which-key firest and then presee <BS>

I just noticed :WhichKey is in the documentation.  I missed it, I guess.  It shows all mappings.


Gralog 3.0 (beta)

Hiya - have you tested this with v3.0 (beta)?  Getting an error 500 when clicking install after importing the first pack:
Error
Installing content pack failed with status: Error: cannot POST http://<IP_ADDRESS>:9000/api/system/content_packs/e37b2103-eee3-4b77-bcfd-e3d9957ab79f/0/installations (500). Could not install content pack with ID: e37b2103-eee3-4b77-bcfd-e3d9957ab79f
Cheers
Adam

I'm also receiving the same error when using Graylog 3.0.

Same here.  Any chance for an updated content pack?

Hey There!
It's good to see that you are interested in running the content pack in Graylog3.0.
Because of compatibility issues with my config i'm actually stuck in 2.x.
BUT there will be an release of graylog-cp-watchguard which is capable to run on graylog 3.x.
Please be patient an feel free to contribute.
Have a nice day!
Cheers
Thomas

Great stuff – thanks Thomas.
Will contribute if we can!
From: Thomas<EMAIL_ADDRESS>Sent: Wednesday, 15 May 2019 11:45
To: ThoZed/graylog-cp-watchguard<EMAIL_ADDRESS>Cc: Ads<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [ThoZed/graylog-cp-watchguard] Gralog 3.0 (beta) (#26)
Hey There!
It's good to see that you are interested in running the content pack in Graylog3.0.
Because of compatibility issues with my config i'm actually stuck in 2.x.
BUT there will be an release of graylog-cp-watchguard which is capable to run on graylog 3.x.
Please be patient an feel free to contribute.
Have a nice day!
Cheers
Thomas
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ThoZed/graylog-cp-watchguard/issues/26?email_source=notifications&email_token=AK4NC4UV6RHWL55I5ULXIKDPVPSSXA5CNFSM4GTINZYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOIR5Q#issuecomment-492603638, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK4NC4XDMDCXFSJSGPVVCHDPVPSSXANCNFSM4GTINZYA.

Hey There!
It's good to see that you are interested in running the content pack in Graylog3.0.
Because of compatibility issues with my config i'm actually stuck in 2.x.
BUT there will be an release of graylog-cp-watchguard which is capable to run on graylog 3.x.
Please be patient an feel free to contribute.
Have a nice day!
Cheers
Thomas

Hi Thomas! I created 4 PRs for the Content Packs listed. I mostly went through and recreated everything by hand, and as such, there may be something I missed. I had some odd issues with the existing regex, like double or triple backslashes causing Greylog to throw errors, but it all seems to work with my 5 Fireboxes.

Thanks a lot! manikmakki.
there is a new branch "legacy" to support old versions. your patches are merged in development branch for the upcomming version 0.6...
Meanwhile everybody with compatibility issues should use the develop branch.
Thanks!
Cheers Thomas


Banner story with typescript

Part of #735

Stories with multiple components are a separate thing with Storybook. The concept of control doesn't work for children.

Also, I think the Banner is a candidate for some alignment.. It has children as explicit props atm

Tried to export with * in the outer index.ts file to get rid of annoying warning. I had to combine it with a separate type export in Banner index.ts to make it work

Tried to export with * in the outer index.ts file to get rid of annoying warning. I had to combine it with a separate type export in Banner index.ts to make it work

That’s right, the * will just re-export whatever is already exported.

@vnys Not sure if I understood you correctly, but like this?

@vnys Not sure if I understood you correctly, but like this?

I think you could have just accepted the suggestions in Github and they would have been committed

…but yes, that’s the way I think it must be done 😊

@vnys Not sure if I understood you correctly, but like this?

I think you could have just accepted the suggestions in Github and they would have been committed

I was thinking of that, but I did a couple of things more than you did :/ With the initial import at least


SSL issue / port appended after upgrade to 2.9.14

Hello incredible NPM Team !
Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
After the update to 2.9.14 some proxy hosts are not working any more.
It seems that NPM doesn't do correctly the reverse proxy as i see in the browser address that he tries to access the internal port.
Reverting to the previous release fix the issue.
Nginx Proxy Manager Version
2.9.14
To Reproduce
Steps to reproduce the behavior:

Create a Proxy-Host with Linuxserver.io/Heimdall behind.
Apply HTTPS and Force HTTPS
Try to access the site:
Browser reports bad SSL  (SSL_ERROR_RX_RECORD_TOO_LONG) or in the best case the page appears but without any CSS Style

FYI: My NPM is behind Cloudflare DNS
Expected behavior
Site should appear correctly like before
Operating System
Docker Image on Debian 11.2
Reverting to 2.9.13 solves the issue. I'm not an expert with nginx.
Tried to recreate a simple Proxy-Host from scratch but same issue.
Hope this will help someone.
Thanks in advance for your help

Hello,
I'm still able to login into my NPM interface and i can't see any error on my Container Log nor Nginx logs.
I think it's not the same issue as @ch4ox mentionned bt maybe i'm wrong.
Thanks for your help

Have you tried disabling Cloudflare to check whether this only happens in conjunction with cloudflare or with just npm as well?

We're seeing the same issue and have had to rollback to a previous version.  Redirects seem to pick up the internal port

Same problem is happening here.  Had to rollback to 2.9.13.

Same problem, rollback to 2.9.13 fixes issue.

Hello,
@chaptergy : i have tried to diable Cloudflare Proxying and still the same.
To illustrate @vilvic in my case i access https://someapp.mydom.com and i'm automticaly redirected to https://someapp.mydom.com:12784 where 12784 is the internal port of a docker containers exposed to my Lan.
As it does not do this issue with most of my apps i have checked if it's related to the App Behind (linuxserver/heimdall).
I have tried to pull an older version but same issue.
I have tried with a fresh image out of the box but same issue too.
Can somenone tell me what logs or file to check to help solve this issue?
Thanks for your help.

Hello,
Same issue for me... Context:
"Classic DNS" > Home router > rPI 4 (Debian Bulleyes up-to-date) > NPM (HTTP/80&443) > Heimdall (HTTP/82 - docker - network conf. bridge).
Update on 2.9.14 > Page KO
Rollback on 2.9.13 > Page OK
Quick investigation on 2.9.14:

Access to the root page is OK
Every other requests are KO, because mentioning the internal port of the docker container ":82" (as @vilvic explain above)

Don't hesitate to mention me if you need more info ! :-)

Unfortunately I'm currently not able to replicate the issue on my dev instance, but based on the number of thumbs this seems to be a widespread issue. (Btw, very good etiquette of using the reactions instead of commenting +1, thanks!)
One of the things changed with nginx configs is the addition of the X-Forwarded-Host and X-Forwarded-Port headers. But I can't really explain how they cause this. I have found that setting the Host header to the domain with an IP causes a redirect to there, but I'm not yet seeing why the host header would be changed. Maybe the applications you are proxying use this new X-Forwarded-... header and somehow mix this information?
@pseudomix @Killator Would one of you guys be able to edit the nginx config manually (located at /data/nginx/proxy_host/<id>.conf, where <id> is the actual id of the host) and remove these two lines everywhere they are used, to see if they are actually connected to the issue?
proxy_set_header X-Forwarded-Host   $host;
proxy_set_header X-Forwarded-Port   $port;

I tried rolling back to the 2.9.13 docker image but still broken. Any additional steps I need to take?

Hi @chaptergy ,
I checked my host config file but not found any occurrence of the related lines sorry.

Hi @chaptergy,
I confirm, there is no proxy_set_header in my config file either...
`
------------------------------------------------------------
mysite.fr
------------------------------------------------------------
server {
set $forward_scheme http;
set $server         "<IP_ADDRESS>";
set $port           82;
listen 80;
#listen [::]:80;
listen 443 ssl http2;
#listen [::]:443;
server_name mysite.fr;
Let's Encrypt SSL
include conf.d/include/letsencrypt-acme-challenge.conf;
include conf.d/include/ssl-ciphers.conf;
ssl_certificate /etc/letsencrypt/live/npm-20/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/npm-20/privkey.pem;
# Force SSL
include conf.d/include/force-ssl.conf;

access_log /data/logs/proxy-host-25_access.log proxy;
error_log /data/logs/proxy-host-25_error.log warn;
location / {
# Proxy!
include conf.d/include/proxy.conf;
}
Custom
include /data/nginx/custom/server_proxy[.]conf;
}
`
/data/nginx/custom/server_proxy[.]conf > The 'custom' directory don't exist in 'nginx'... (+ 'find' command on *.conf)
conf.d/include/proxy.conf > Seem to be inside the container

Yeah sorry, the directive is only included instead of explicitly generated in the file, so you would have to edit the conf.d/include/proxy.conf file and remove the directives from there

Hi Chaptergy,
This did the trick!
Removing:
proxy_set_header X-Forwarded-Host   $host;
proxy_set_header X-Forwarded-Port   $port;

from /etc/nginx/conf.d/include/proxy.conf worked for me.
In the meantime i have mount this file outside of the image to don't loose the change in case of recreating the container.
Feel free to ask me other test.
Thanks

I have redirect to port 80 since the last update on Pixelfed

Sorry for my ignorance as I'm not 100% familiar with nginx reverse proxy, but why would the following be used:
proxy_set_header X-Forwarded-Port   $port;
in favour of using the following:
proxy_set_header X-Forwarded-Port   $server_port;
Would we not want to use server_port as it's the original requested port?

Please try the jc21/nginx-proxy-manager:github-develop docker image, which has these headers removed and comment whether this is problem is fixed.

Hello jc21,
Problem fixed with this develop version.
Thanks for your investigations and thanks for this awesome developement.

I had problems with the login on Pixelfed- It was always forwarded to port 80. With the developer version it works correctly again

Please try the jc21/nginx-proxy-manager:github-develop docker image, which has these headers removed and comment whether this is problem is fixed.

Working fine ! Thanks a lot ! 👍

I can confirm that I am having the same issue with 2.9.14. If I inspect my site (laravel site) then the server port is appended to the end of the url. This was not an issue before and I don't know how to go back to a previous version. I have pulled and used the latest jc21/nginx-proxy-manager:github-develop image and this has fixed the issue for me as well. I just pulled the latest today and noticed this issue. What is the correct course of action for people with this issue?

On this it did break one of my apps. Invoice Ninja, running in docker swarm. To fix that I changed my internal apache port on that application to 443 and that fixed it, but this thread answers why I was seeing the :80 at the end of the URL.
I will add that it fixed a long standing issue I've been having with an AVideo site. When going from the main site, to the encoder site, it would delay sometimes up to 2 minutes. The usernames/credentials get passed in that transition, these additions fixed that transition.
I can add these headers onto specific proxy hosts through the custom config in the UI? Is that right?
And if anyone has any follow up information to @atbakken 's comment concerning the different way to implement a similar header that might shed some light on this for my use case. This would be great to have by default as it does seem to be an improvement.
And thanks for this project! I'm using it extensively for 100+ websites/applications in front of a multiple node docker swarm configuration.
Sincerely,
Jared

Please try the jc21/nginx-proxy-manager:github-develop docker image, which has these headers removed and comment whether this is problem is fixed.

Hello jc21,
It's not been fixed yet, the docker-compose.yml is as follows:
version: '3'
services:
  app:
    image: 'jc21/nginx-proxy-manager:github-develop'
    #image: 'jc21/nginx-proxy-manager:2.9.11'
    restart: unless-stopped
    ports:
      - '80:80'
      - '81:81'
      - '443:443'
    volumes:
      - ./newdata:/data
      - ./newletsencrypt:/etc/letsencrypt
      #- ./data:/data
      #- ./letsencrypt:/etc/letsencrypt

image: 'jc21/nginx-proxy-manager:github-develop' dit the trick for me.


FIXfix case truncate table first

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Feature flags span events must be set

Feature Request
Demo should conform to OTEL standard regarding feature flag. Namely: A flag evaluation SHOULD be recorded as an Event on the span during which it occurred.
https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/feature-flags/#convention
Is your feature request related to a problem?
I need to see which feature flags (if any) where set on each span.
Describe the solution you'd like:
See above.

Need to make sure this works with the new flag service

flagd and the openfeature instrumentation properly records a span event for flag evaluations! closing this as complete


[Feature]: ensure equal padding width on both sides of the content

What problem does this feature solve?
On my 14-inch Macbook, the left side padding width is 140px, the right side padding width is 120px. This causes the page to look asymmetrical.

What does the proposed API look like?
Can we keep the padding width consistent on both sides of the content?

@chenjiahan I would like to work on this isssue

Thanks!

This issue seems already fixed.


How to make click on the cell to mark a habit as complete?

I'm new to obsidian and i was wondering how i can make it so that when i click on a cell it automatically marks it as complete?
Ideally i would interact with the chart itself instead of creating a new note every single day to mark my habit as complete
is this possible? if so, what's the code for this? 😊

it's impossible now,  because click event not work when cell data is empty.
but it's a good idea, i would try to make it possible in api mode

thank you


Weighted mean in cube.aggregated_by

Hi,
is it possible to use weights to calculate the mean while using cube.aggregated_by.
For instance, I have a cube with several years of monthly data, and I want to produce an annual mean. I have previously used:
cube.aggregated_by('year', iris.analysis.MEAN)

However, this means that the shorter months have the same weighting as the longer months. Is there a weight to weight this calculation by some given weights. (Lets assume that I've calculated them elsewhere!)
ie:
cube.aggregated_by('year', iris.analysis.MEAN, weights=time_weights)

Thanks!

Absolutely yes, it does supporta 'weights' keyword
see here

Hi Patrick!
I'm seeing the error message:
 ValueError: Invalid Aggregation, aggregated_by() cannot use weights.

Which seems to come from:
            # We can't handle weights
            if isinstance(aggregator, iris.analysis.WeightedAggregator) and \
                    aggregator.uses_weighting(**kwargs):
>               raise ValueError('Invalid Aggregation, aggregated_by() cannot use'
                                 ' weights.')

in iris/cube.py:3363 and we're in iris version 2.2.0.
It probably isn't the culprit, but the function that you're linking is the iris.analysis.MEAN function, not the aggregated_by function that I'm using. Is there perhaps a problem with the way I'm passing the weights to aggregated_by?

Sorry, my bad !! :-1:
I was confusing the functions of the aggregator with the stats routine (aggregated_by instead of collapsed).

In principle, this seems possible...
I think it might be worthwhile taking a step back here and holistically rationalising how aggregation and collapse works. Unifying behaviour for use of weights (where appropriate for the statistic) consistently would be a good win - plus there is some technical debt for us to purge, as there is a major overlap between aggregation and collapse that we should take advantage of; I've been itching to do that for years.
The topic of operator laziness (#3280) is also relevant here... and that needs a wee bit more thought. You'd certainly throw away coordinate laziness, but it seems reasonable to expect to keep the data lazy.

This was implemented in #4589

Great work, thanks to the iris team! This will be very useful in the future. Now if I can only remember what I was trying to do back in March 2019, lol.


Change artifact-id for EE inclusion?

Werner Keil pointed out:
Given the license headers were harmonized with the Glassfish umbrella of Java EE, since we have this discussion in the JSR 362 (Portlet 3) EG (only based on Java EE, not even under its umbrella;-), another thing all Java EE JSRs tend to adopt is a unified Maven GroupId and ArtifactId.
Instead of
javax.cache
cache-api
1.0.0
for a new release it would be
javax.cache
javax.cache-api
1.0.0
see http://mvnrepository.com/artifact/javax.faces/javax.faces-api or http://mvnrepository.com/artifact/javax.json/javax.json-api
Jens' statement:
I am not in favor of doing this change in a next MR unless we know there is a strong need for it.
The artifact-ids need to be changed wherever used, that is a big amount of work that JCache users will hate us for. If we really need it, the worst thing that can happen is that we need to do a new MR.
Suggest not scheduling for upcoming MR unless new information.

Thanks, no problem cloning the ticket, but I see no problem with constructive comments here rather than a mailing list like Google Groups;-) I agree, GitHub may be a bit less structured and organized than e.g. JIRA but some projects like C# I follow and see almost daily updates to their issues or "stories" (that's what many of these tickets are;-)

One of the most notable exceptions under Java EE is CDI btw, it (led by JBoss) does not follow the Oracle-recommended (also not so common in other places, e.g. Apache) prefix to the artifact ID. Since Oracle is Co Spec Lead and (see the license question;-) has some say, please have them clarify if it's necessary or not.

Added 1.1 to discuss about it.
A possible solution could be to release the same artifact twice. Under cache-api and javax.cache-api. This allows a smoother transition.

A couple of thoughts. This is now widely used so changing the artifactId is an unnecessary inconvenience to users. I see Werner points out that JBoss does not follow the convention. We had Bill Shannon review all this three years ago and this convention was never mentioned so I am going to conclude it was a not a big deal and close.

Given it is far from certain, if JCache would even be an official part of Java EE 8 or 9, I see this as not such a big deal as well.

Werner
We would very much like this to be part of EE8 or 9.
If you would like to be then please vote for it in the survey.

We heard Linda say what's necessary to make that happen. Just a survey is not enough;-)

I just emailed her to ask her.
Regards
Greg Luck
web: http://gregluck.com http://gregluck.com/
skype: gregrluck
mobile US: +1<PHONE_NUMBER>
mobile Australia: +61 408 061 622

On 3 Oct. 2016, at 1:52 pm, Werner Keil<EMAIL_ADDRESS>wrote:
We heard Linda say what's necessary to make that happen. Just a survey is not enough;-)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/jsr107/jsr107spec/issues/352#issuecomment-251192470, or mute the thread https://github.com/notifications/unsubscribe-auth/AANyhEbYmrUKAfw43CTGABukx4rXkJ4Vks5qwU7fgaJpZM4Igedz.

What is that? I do not know and have not heard.
Regards
Greg Luck
web: http://gregluck.com http://gregluck.com/
skype: gregrluck
mobile US: +1<PHONE_NUMBER>
mobile Australia: +61 408 061 622

On 3 Oct. 2016, at 1:52 pm, Werner Keil<EMAIL_ADDRESS>wrote:
We heard Linda say what's necessary to make that happen. Just a survey is not enough;-)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/jsr107/jsr107spec/issues/352#issuecomment-251192470, or mute the thread https://github.com/notifications/unsubscribe-auth/AANyhEbYmrUKAfw43CTGABukx4rXkJ4Vks5qwU7fgaJpZM4Igedz.

Check the EC F2F Minutes, it should be there;-)


Close browser after function bound with page.exposeFunction() call ?

Is there some standard way to get (async) page result ?

Node.js starts page in puppeteer
there is some self-initiated processing in page
after processed page calls exposeFunction
And how to close (chromium) properly now ?
Inside browser window.close does not work (but reused 1st tab).
Browser cannot be closed after exposeFunction nor from its invocation in Node.js (exception).

const browser = await puppeteer.launch({});
const page = await browser.pages();
await page[0].goto('file:///...');
page[0].exposeFunction('reader', (html) => {
    fs.writeFileSync(path.join(__dirname, pdf.replace('.pdf', '.htm')), html);
    session.on('Page.lifecycleEvent', event => {
        console.log(JSON.stringify(event));
        if (event.name === 'firstMeaningfulPaint') browser.close();
    });
});

Error reported sometimes or if closed without some ansync hook
Error: Protocol error (Runtime.evaluate): Target closed.
    at puppeteer\lib\Connection.js:183:56
    at new Promise (<anonymous>)
    at CDPSession.send (puppeteer\lib\Connection.js:182:12)
    at Page._onBindingCalled (puppeteer\lib\Page.js:568:18)
    at processTicksAndRejections (internal/process/task_queues.js:94:5) {message: 'Protocol error (Runtime.evaluate): Target closed.', stack: 'Error: Protocol error (Runtime.evaluate): Tar…ctions (internal/process/task_queues.js:94:5)'}

Thanks for you response, I suspect that my issue is caused by my Chromium version that is 84.

You probably cannot safely synchronously close the browser from within the exposed function.
You could try to wrap the call to browser.close() as setTimeout(() => { browser.close(); }, 0), so that the function can return before the browser is closed.
However, I'd recommend trying to find a way to return a boolean from the function, and then to use that to close the browser from code that is not in the exposed function.


Blocks/TXs still in the queue when last block is requested are not counted in the total.

The total imported shown when imports complete is not entirely accurate. If the backpressure buffer is large, then the accuracy increases. The total count is measured when the final block is requested from the node - this leads to blocks still in the queue to be written to DB is not counted.

If this is important, set the backpressure TX to 1 and backpressure blocks to 1. It will be a quite a bit slower but will show the correct totals. This will require some more work to figure out and we want to release 1.1.0 now.


Plugin Development - Various Issues relating to loading the assemblies

Hey,
So ive been working on a plugin to communicate with an outside API and do some stuff on my keyboard.  For the most part its working but i'm having several issues that are to do with the plugin architecture.  This is not a criticism, but im wondering if im the first person to really use the Plugin stuff, as i feel like these issues cant be worked around and would likely have come up for other people.
So, Aurora starts, with the plugin loaded but no layers yet created.  I go in, create my layer(s), test them, all works and i exit. This part is fine.
Next, i start up Aurora. This time round, it loads the layer from the profile config and throws an error (its caught but it still throws it).  "Newtonsoft Json - Could not load file or assembly Plugin-pluginName".
As its thrown, the layer doesnt load and it just disappears.  From my understanding, this is because it doesn't know where the plugin assembly exists.  It doesn't know about the Plugins folder and even if it did, i dont think NewtonsoftJson is equipped to load it from another folder.  I know .NET tends to have issues loading assemblies in other folders, so i moved on and tried something different.
Next, i put my plugin assembly in the root folder as well as the plugins folder.  This appeared to work at first. However, i quickly(took all night tbh..) realised that if Aurora starts up with layers already added, when you try to add another you get an error about the URI not existing for the XAML file.  Investigating this further leads me to believe that Aurora was loading the XAML file from the root area (and this means URI looks something like "component;Aurora/something/something.xaml") and when you try to load the XAML file in another way the URI does not start with Aurora (because its now from the plugin so its more like "component;Plugin-pluginName/something/something.xaml") and thus it fails to find it.
So, I cant put it in just the plugins folder and i cant put it in both folders.  So next i tried to stick it in just the root folder. This had some issues ... i had to change the const in the plugin manager so that it didn't look in the Plugins directory and i also had to filter it so that it only looks for "plugin-*.dll" otherwise it was loading the entire root directories assemblies.
This works, the layers save and load, the plugins are loaded in and out correctly all is working.
Now, i don't know if this is an acceptable solution.  Its much cleaner having everything in the plugins directory. Also it does mean, I am having to make modifications to the plugin manager which could potentially break it for other people who have made plugins (if there are any.. i suspect not as I would expect this issue to come up pretty quickly).
Also, you can do all the steps i provided above with the Plugin-Example.  So if you'd like to test you can try it with that plugin.
I hope this all makes sense.  I'm looking for advice on how to proceed really.
Cheers,
Piercy

To give some more context to this, tonight i basically finished off the plugin other than the above modifications i had to make.  So i now have a plugin that can receive any notification from a mobile phone and trigger some layer effects.  I will add more lighting effects, at the moment it only uses the breathing effect.
All keys and colours are configurable but as examples here's how i'm using it currently.
If i receive a phone call, my whole keyboard breathes white.
Facebook, Snapchat, Whatsapp and Email notifications trigger my F1-F12 keys to breath their respective apps colour (Blue, Yellow, Green and Red).
Although i pre-configure these notifications, the software can work with any apps notifications and should be both IOS and Android compatible although i don't have an IOS device to test.

I had a quick look at some of the changes you've made in your fork. I would like to keep the plugins in a separate folder, rather than them being prefixed with "Plugin-", it's just better for the end-user as it is easier for them to keep track of what plugins they have. The state of the plugin system (the way it is in the current dev branch) is nowhere near the finished setup, it was something I had worked on before and hadn't fully finished as I was focusing on other things, hence the fact it isn't mentioned anywhere. I plan to make plugins be able to implement fully functioning Applications and Devices (exactly the same way they exist in the application), similar to how it is currently setup for the plugins to create additional layers. If you have any ideas for improvements that can be made to the system, feel free to post them, or if you wanted, you could implement some, but that's up to you.

Thanks for taking a look.  I agree, it is much messier would much prefer it to be in the Plugins folder.   Also,  keeping the code line separate for plugins would be great as well, allows for different code stlye and less tech support needed in the main application.
I spoke to a colleague at work about the issue i was experiencing. He sent me some code that may potentially work for telling Json how to handle the plugin assemblies.  I look into this and test it with the example plugin (to make sure that im not just fixing in suitable for myself).  If i manage to do it ill submit a pull request.
One other thing i did come across that's worth keeping in mind when you revisit plugins.  Currently, all the interfaces, classes and other code needed for plugins exists inside the main project-aurora project.  This means you need to reference the full project to be able to develop a plugin.  Ideally, some of the bits need pulling out to a separate assembly so other projects can reference the assembly.  Its not important for now but something to bear in mind if/when you swing back round.
Thanks again for taking a look.

Awesome!
I think I might try and separate the main parts of the application into:
UI,
Core Functionality,
And use plugins for Applications, Layers and Devices
By moving that stuff into plugins it'll make it easier to ensure that the plugin system works well.
However, that's just an idea, let me know what you think of it. I reckon I'd likely change this up when I switch to AvaloniaUI for the ui to start attempting to make Aurora work cross-platform.

Yeah, that all sounds good really.  If you were to look at the existing game handlers, and others bits and bobs.  You can clearly see how you can apply the same thing in the plugins to achieve the same result.  I mean, most of my code i wrote was from looking around the project... looking at how X stores settings, how X triggers certain lighting effects. After that i just communicate with an API so i know when notifications are received on my phone.
I think regarding new games and applications plugins are an easy place to start.  You basically grab some of the existing Handlers and UI's that exist. Whack them in a plugin and hook up to the new games API somehow. Whether that's using existing wrappers or specifically coding to a games API.  After that your mostly there.   I think my plugin took me about 3 or 4 days but i was learning as i went.  I think if you are familiar with it, That time could drastically come down meaning new games can be added very easily (provided some form of API support from the game).
So i'm pretty sure a lot of the existing Applications, Layers and Devices will work well.  The tricky part is the cohesion between them.  You don't want people repeating code because they also want say "a rainbow" layer or something silly.  You'll end up with 30 different rainbow effects.  I mean, people could just reference the base plugins but it essentially becomes working out what should be core and what should be plugin.
its almost more a conceptual issue than it is an actual code issue.  But really, for the most part i think plugins fit well with this. You can see in the current project how lots of different things are designed very similar and just slot in.
Side note, I haven't yet tried the code a colleague sent me.  GDPR is kicking my arse at work so i havent really felt like spending time doing more code but i will definitely give it a shot to see if i can solve the saving and loading issue.  That said, i'm happily using the rubbish build i wrote for now.  Havent missed a phone call since doing it so its at least working.  Ill make sure to post back if i find anything .

Yeah, the current way the Applications and Layer Handlers exist make it quite easy to make new ones, especially if they use an existing wrapper, in that case it's just a matter of copying everything, which now, isn't much and changing references to the specific game and adding the appropriate image.
Right now the Application Profiles by default will create particular layers which somewhat throws a spanner in the idea of separating all that stuff into plugins as they would still need to reference eachother. However, I reckon for the core stuff I'd likely make it so that they run through the Plugin system but are required, i.e. the application won't run without them and they can't be disabled, but they will still be executed through the system to keep continuity. With that, it should be safe for those assemblies to be referenced by each other or other plugins so they can add particular layers they want by default. I'll likely try and keep them separated as there really should only be referenced from the Applications to the Layer Handlers, never the other way around, unless they are ones that are only to be used with that application. I reckon that everything in the current project that is going to be set up to be added as plugins should be moved into plugin form.
In theory when it comes to user-made plugins, if someone was to make a layer handler pack for example, someone who wants to use some of them as default layers for an Application they're adding support for should be able to reference the assembly for the pack and use it, and require that the pack is installed for the application to work.
There's no pressure on you to work on this, any help is appreciated, if you don't do it I'll get to it hopefully soon (but considering how I'm getting to things a lot later than I intend it might not be for a while)

im happy to work on it.. Id like to get my build into using the plugins properly.  As im mostly there and have sample code that may work least i can do is try it.


Refactor Codebase of Person to Friend

This will be done in the 2nd half of v1.2b

Given the priority of this issue as severly low and At current timescope, we will jut leave it as Person to prevent any potental blowbacks of our current iteration.