Minor fixes

Hello there! I saw your post on GBATemp and I'm interested in collaborating.
I made for you the templates for bug reports and feature requests, hope you like them!
If you want I can also set up a Crowdin for translations.
Have a good day! :D

EDIT: I installled a GitLocalize on my fork! When people translate the files they get sent to my fork, then I send you a PR so your rep has the translations too.

Hello there!
While I appreciate the contribution, I have some apprehensions about your changes. For one, while translating the database would definitely be a good idea, at least for the warning text, NUSGet currently doesn't have the code required to dynamically load a database from another language. The databases all get embedded into the binary, and it only knows to look for them at data/<console>-database.json. Translations for these databases could definitely happen, but at this point the necessary backend just isn't there yet.
However, what can be translated is the interface. Since NUSGet is based on Qt, I can use Qt's built-in translation features, which automatically load the correct localization, if it exists. I'll gladly accept Italian translations (as well as any other languages people may contribute) via this system. Each translation has a .ts file in resources/translations/, and that file can either be edited by hand (though this is a little rough), or via the Qt Linguist app, which shows you the context everything is used in and makes it much easier. These translations get built when the app is compiled, and then are automatically loaded if your system is set to one of the supported languages (falling back on the default of English). I'd be glad to provide help on working with these.
Lastly, I'm just not sure that the extra emphasis in the database is really necessary. In some cases, the text being emphasized is already in all caps anyway. I do appreciate the correction of Preloader to Priiloader, though, as I can never seem to remember which is the newer one.
I don't want to discourage you from contributing to NUSGet and any other projects, I just want to try to point you in the right direction towards the parts of NUSGet that need the help right now.
Cheers!

Hello! Well thanks for the reply first of all :D
I'll fix the translation stuff right now
On Wed, Jul 3, 2024, 22:46 NinjaCheetah @.***> wrote:

Hello there!
While I appreciate the contribution, I have some apprehensions about your
changes. For one, while translating the database would definitely be a good
idea, at least for the warning text, NUSGet currently doesn't have the code
required to dynamically load a database from another language. The
databases all get embedded into the binary, and it only knows to look for
them at data/-database.json. Translations for these databases
could definitely happen, but at this point the necessary backend just isn't
there yet.
However, what can be translated is the interface. Since NUSGet is based
on Qt, I can use Qt's built-in translation features, which automatically
load the correct localization, if it exists. I'll gladly accept Italian
translations (as well as any other languages people may contribute) via
this system. Each translation has a .ts file in resources/translations/,
and that file can either be edited by hand (though this is a little rough),
or via the Qt Linguist app, which shows you the context everything is used
in and makes it much easier. These translations get built when the app is
compiled, and then are automatically loaded if your system is set to one of
the supported languages (falling back on the default of English). I'd be
glad to provide help on working with these.
Lastly, I'm just not sure that the extra emphasis in the database is
really necessary. In some cases, the text being emphasized is already in
all caps anyway. I do appreciate the correction of Preloader to Priiloader,
though, as I can never seem to remember which is the newer one.
I don't want to discourage you from contributing to NUSGet and any other
projects, I just want to try to point you in the right direction towards
the parts of NUSGet that need the help right now.
Cheers!
—
Reply to this email directly, view it on GitHub
https://github.com/NinjaCheetah/NUSGet/pull/1#issuecomment-2207243111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEDNSHLB2ZG4DN3VGZDZKRPIRAVCNFSM6AAAAABKHK2ZDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGI2DGMJRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ok, translated!

Forgot: I took down the GitLocalize since there's Qt Linguist

While I appreciate your Italian translations (which look good!), I think maybe we need to take a step back here.
I did see that you reverted most of your database changes, but I'm still not entirely certain the ones left are necessary (minus Preloader -> Priiloader which definitely is). I understand what you were going for when changing It is recommended to not modify it., but honestly that sentence just needs to be written entirely because the grammar is awkward either way.
When it comes to translations, I appreciate that you've written a guide, however there are several issues with it. For one, the .ts files that Qt uses to build translations are meant to be automatically generated. The command pyside6-project lupdate automatically generates .ts files based on the strings in the interface and in NUSGet.py. You shouldn't copy existing translation files when setting up a new language, because there's no guarantee that the language file you're copying is up to date. Using the command will update all of them (and keeps existing translations). It's also always best practice to link to tools directly, rather then telling people to google them, because you want to make sure they're getting the right thing. NUSGet is also a cross platform app, so giving Windows-specific advice (like linguist.exe) wouldn't be particularly useful to translators on Linux and macOS.
My advice would be, for now at least, to save nusget_it.ts somewhere outside the project, reset your fork to be based off of NUSGet's main, and then add that back and make that your pull request.
If you have any questions, just let me know, as I'll be here to help as much as I can.

Just wanted to follow up since it's been about a month now. I'm still open to merging your translation, because that looks really good, I just need to know what's happening with the rest.

NinjaCheetah

Yeah forgive me, it's been an hard month. I'll fix the PR today :)
On Fri, Aug 9, 2024, 08:52 NinjaCheetah @.***> wrote:

Just wanted to follow up since it's been about a month now. I'm still open
to merging your translation, because that looks really good, I just need to
know what's happening with the rest.
NinjaCheetah
—
Reply to this email directly, view it on GitHub
https://github.com/NinjaCheetah/NUSGet/pull/1#issuecomment-2277264590,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MADEHH2AMNMLERIPZHNL3ZQRRKNAVCNFSM6AAAAABKHK2ZDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGI3DINJZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[FEATURE] Increase analogy to Kubernetes in terms of un-/deploying apps

Documentation says: "You can think of a wadm application like a Kubernetes Deployment." . Since people are familiar to Kubernetes, it would be advantageous if wadm behaved analogous to Kubernetes. At least, in terms of the undeployment of an app, this is not the case:
# deploy with kubernetes
kubectl apply -f deployment.yaml

# undeploy with kubernetes
kubectl delete -f deployment.yaml

with Wash/Wadm/Wasmcloud, I faced:
$ wash app deploy wadm.yaml
Successfully deployed model rust-http-hello-world v0.0.3

$ wash app undeploy wadm.yaml
Invalid subject: Found extra components of subject, ensure your manifest name consists of only alphanumeric characters, dashes, and underscores.

$ wash app list

  Name                    Latest Version   Deployed Version   Deploy Status   Description
  rust-http-hello-world   v0.0.3           v0.0.3              Compensating   HTTP hello world demo in Rust, using the WebAssembly Component Model and WebAssembly Interfaces Types (WIT)

$ wash app undeploy rust-http-hello-world
Successfully undeployed model rust-http-hello-world

Therefore, the following feature request: wash app undeploy wadm.yaml should undeploy the app which it previously deployed via wash app deploy wadm.yaml.

I'm a huge fan of this request. From the wadm side it's just accepting the name of the manifest on the API, so this should be solved on the wash side in order to keep it simple. wash is actually the component that reads a manifest from the file and then deploys it. Going to move over to wasmcloud/wasmcloud to track there 😄


Open typeahead immediately when @ is entered

At present, we open @-mention typeahead suggestions when the user enters @ (not within a word) followed by another character. Instead, we should pop up typeahead right away without waiting for the first character. This will make it clear to the user that they can use @-mentions in Zulip, and is consistent with expectations from other chat apps (e.g. Slack, Discord).

Implemented in the web app: https://github.com/zulip/zulip/issues/19142

Yeah, I think because of : and # potentially being used at the start of unrelated words (esp. # for issue numbers), let's just do this for @. That also has the advantage of being consistent with the webapp. thanks!


Evaluation strategies

We discussed using fiberfox and also fiberfox-wrapper to create datasets with known artifacts.
We could also use improvements in TRT in a janky dataset as an indication of benefits of the method and comparative evaluation of different methods. We could use the dataset we used here

Also, voxel-wise test-retest reliability in HNU1, SNR of large fascicles (CC, CST, Cingulum), SNR of small fascicles (UF, CAB).
And the maybe use the tractometer to grab some others like: # valid bundles, % valid connections, # invalid bundles, % Invalid connections, # short fibers (e.g. <50mm), # long fibers (e.g. >50mm), bundle overlap, bundle overreach, local angular error (1 compartment + multiple compartments)?

Can I ask to rename this issue to "Validation strategies"?
As I'm suggesting in the other thread, I feel we are not ready yet to "evaluate" this tool.

We discussed using fiberfox and also fiberfox-wrapper to create datasets with known artifacts.

Yes, I think this would be the best way forward if you think of a very scoped validation. You don't need to worry about noise (let's generate a noise-free version of the fiberfox) and you can generate three versions: only-hm, only-ec, hm-and-ec.
In a second iteration, a janky dataset seems the best next step. We would generate all the necessary inputs for this janky dataset (brain-mask, denoised DWIs, etc.) and then try it.
Finally, @dPys' suggestions would fit better in dMRIPrep's proper - testing all those things requires evaluation in the actual settings the solution is deployed.

Actually, "verification" would be even better than "validation" at this point.

I've managed to generate some example data using fiberfox-wrapper, but I think it'd be worth creating a dedicated workflow based on the old ISMRM tractometer to evaluate the simulated data in a controlled framework that is more conducive to sensitivity analysis.
What are everyone's thoughts about creating yet another repo (at least temporarily) for exactly this purpose? For now, we could call it "EMCbenchmarking", but it could eventually be integrated with dmriprep and/or even used as a template for more general optimization of preprocessing choices...

I've managed to generate some example data using fiberfox-wrapper, but I think it'd be worth creating a dedicated workflow based on the old ISMRM tractometer to evaluate the simulated data in a controlled framework that is more conducive to sensitivity analysis.

Can you provide more details about this workflow you are envisioning?

What are everyone's thoughts about creating yet another repo (at least temporarily) for exactly this purpose? For now, we could call it "EMCbenchmarking", but it could eventually be integrated with dmriprep and/or even used as a template for more general validation and optimization of preprocessing choices...

If we could generate static data (e.g., a dataset without head-motion or eddy currents whatsoever) and introduce between-volume motion later, this would be very beneficial, and such "static" dataset could easily go under the https://github.com/nipreps-data portfolio of testing datasets.

Okay, with the idea of (pre-)registered-driven development, this needs to be addressed explicitly now. We don't need to keep this issue open or propagate it to nifreeze.


Help installing

with so many options I am thoroughly confused which link should I follow to install a fresh instance on my local system.
Which is the folder there is a front end, component, hospital run io, hospital run front end and a hospital run server and am thoroughly confused which one to follow - also is there a proper documentation on the same that I can refer to.
I would really appreciate if the team can point me in the right direction.
Many thanks in advance and apologies for such a rudimentary question.

Hi. Please follow this: http://eepurl.com/c7uKJ5


Is there a way in JSModeler to select a mesh object by mouse event?

I am just started looking at JSModeler. So far it is awesome to me. Previously I have used another Canvas/Webgl based 3D library named JSC3D.  It is really lightweight compare to JSModeler.  But  It supports picking an mesh object by mouse event on the model. Does JSModeler provide that sort of functionality? If it does, I will appreciate if I get a sample code.  It would help a lot to select a model component and edit that. Thank you very much. -- Uday

Hello,
What viewer do you use? JSM.Viewer or JSM.ThreeViewer?
Viktor

Victor - Thank you very much for your reply. As I told I have not really
started using JSModeler for my project yet.
I have just started exploring the library. I must say so far I have seen it
is awesome. My project will be to build a
Building Model from user input, that consists of Frame, Column, Rafters,
Connectors, Walls, Girts, Roof, Purlins, Joist etc.
After creating the model for each components of the building, which I
understand will be pretty easy with JSModeler and
It will be render on the screen for user interaction.  Now user should be
able to click (or double click) on any
component on the viewing screen and identify the components id so that the
other related information of the compentts
could be viewed, prefereable by a JSON or database look up.  Therefore I
need to know about the following three things.
a. How to select a specific component from the rendered model and know the
mesh id? In another library JSC3D that I used
before that has the capability to select the specific rendered mesh. I
guess, Three.JS also have the similer
functionality.
b. I can see JSModeler has feature to add, delete a mesh model to existing
model. What I need to know that does it already
have a some sort of Model editing capabilities.
c. Last thing I need to know which I am not sure of that can we use the
custom image as a texture on the model surface?
I think it is already there. But I need some example code.
I will really appriciate if you help me by giving some heads up on my
question. Once again thank you very much for
developing this powerful and easy-to-use library.
Uday Dutta
On Sun, Feb 19, 2017 at 2:33 PM, Viktor Kovacs<EMAIL_ADDRESS>wrote:

Hello,
What viewer do you use? JSM.Viewer or JSM.ThreeViewer?
Viktor
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kovacsv/JSModeler/issues/26#issuecomment-280946559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYrH9wM7U03vHVOD5OeWHFDb2_rgTm8xks5reKcEgaJpZM4MFTLD
.

--
Uday

Hello!
Basically JSModeler has two viewers. An internal one, and a three.js based. Both viewers can detect objects under the mouse, and the possibility to add or remove objects. Custom textures are also available.
I recommend you to check the sandbox folder for examples, and feel free to ask if you have any questions.
Viktor

Excellent!  As recommended, I have looked into example "undermouse.html".
It has perfectly explained what I wanted to know.  I have also noticed that
at renderBody object level  it supports to add properties that really
help to keep non-geometrical information right with the model object. Thank
you very much for all the helps. *JSModeler *is really a very powerful and
promising library.
One question though. Is there any plan to add "3D Shape Recognition",
"Collision detection"  or "Physics Modeling"  type of features to JSModeler
in the near future?
Thanks again.
UCD
On Mon, Feb 20, 2017 at 11:21 AM, Viktor Kovacs<EMAIL_ADDRESS>wrote:

Hello!
Basically JSModeler has two viewers. An internal one, and a three.js
based. Both viewers can detect objects under the mouse, and the possibility
to add or remove objects. Custom textures are also available.
I recommend you to check the sandbox folder for examples, and feel free to
ask if you have any questions.
Viktor
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kovacsv/JSModeler/issues/26#issuecomment-281136699,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYrH9zJJ6oRyhqlopMnX_s-zP6pRBCnIks5recuOgaJpZM4MFTLD
.

--
Uday

Hello!
I'm glad you like JSModeler. Currently I have no plans to do the mentioned features in the near future, but who knows :)
Viktor

Hi! Victor
Is it possible to disable/enable applying the transformation on a selected
body in a model during mouse interaction? I am trying to display a Camera
position with an array indicator ( May be a text or a SVG) on the scene and
I do not want it to get it resized. Also I want to show the axis lines at
Camera Center position. I want to keep length of axis lines constant but I
would like to show the rotation of the axis.
Any tips will be appreciated.
On Tue, Feb 21, 2017 at 2:52 PM, Viktor Kovacs<EMAIL_ADDRESS>wrote:

Hello!
I'm glad you like JSModeler. Currently I have no plans to do the mentioned
features in the near future, but who knows :)
Viktor
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kovacsv/JSModeler/issues/26#issuecomment-281476436,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYrH96kcmtXSRVVdkxr-q5PnewNPb7TMks5re06MgaJpZM4MFTLD
.

--
Uday


fix

Fixed pre-commit failling test...

docformatter works.. properly now.. @gemanor @danyi1212
This pr should be attended to be merging any other pr...

I got the insight to fix this from the following sources:
https://github.com/PyCQA/docformatter/pull/287
https://github.com/PyGithub/PyGithub/issues/3058
https://github.com/Lightning-AI/torchmetrics/pull/2779
https://github.com/PyCQA/docformatter/issues/289

@danyi1212 This is ready for merge...


[Feature Request]: Creating yaml issue templates

Hi @Its-treason, could you please have a look at this issue and let me know if this is required, I'll create a PR for this 👍
About
This is a feature request for creating yaml issue templates which will allow the users to file new issue with ease as the default issue template can't be edited.
Currently is use
Currently the default issue template by GitHub is in use.
Expected
By creating custom yaml based issue templates, it will ease the work for identifying issues whether it's a bug or a feature request or something else.

Could you link a repository that already uses Yaml issue Templates?

Could you link a repository that already uses Yaml issue Templates?

If I've understood correctly, should I create a separate repository containing custom Yaml issue templates and then put it here?

I wanted to see a YAML template that is already in use in a different Repository. I just found it used in mantinedev/mantine and it looks very interesting.
Quick Idea of what we could add:

A Bug template

Checkbox: I use the newest version
Checkbox: I searched existing Issue and have found nothing related to my issue to maybe prevent duplicates
Textare: Describe the Bug
Textare: Screenshots, Images or Error messages
Textare: .bru file to reproduce the bug (If applicaple)

A feature requests template

Checkbox: I searched existing Issue and have found nothing related to my issue to maybe prevent duplicates
Textare: Describe the feature you want to add
Textare: .bru file to reproduce the bug (If applicaple)

A link to the discussions page for questions, feadback etc.
A link to the Discord server for questions, feadback etc.

These are some general idea's, if anyone has more/other idea's please share them.

Thanks for your suggestions 👍, I'll create the issue templates by today.


Upload not working on Android 9 and 10

Hi,
Using flutter_uploader(latest version), I'm trying to upload images/videos on server. Same is working fine on Android 7. But in Android 9 and 10, it is failing. In fact request is not reaching to the server.
Please guide to fix the problem.

@rahul-alld can you please try the latest version from git

Please open a new ticket with reproducible steps.


add test for test-logging-tx-observer

Checklist

[ ]  A link to the issue/user story that the pull request relates to
[ ]  How to recreate the problem without the fix
[ ]  Design of the fix
[ ]  How to prove that the fix works
[ ]  Automated tests that prove the fix keeps on working
[ ]  Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606
Steps to Reproduce

Existing issues

[ ] Stack Overflow issues
[x] GitHub Issues
[ ] Discord history

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 100

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 0

Automated Tests

What documentation has been provided for this pull request

true, would remove it now
On Thu, 10 Oct 2024 at 08:38, Dave Kelsey @.***> wrote:

@.**** requested changes on this pull request.
One last change
In packages/caliper-core/test/worker/tx-observers/logging-tx-observer.js
https://github.com/hyperledger/caliper/pull/1630#discussion_r1792267496:

   logStub = CaliperUtils.getLogger().info;

   observer = createLoggingTxObserver({ messageLevel: 'info' }, null, 0);

});

afterEach(() => {

   sinon.restore();

   logStub.resetHistory();

});

after(() => {

   mockery.deregisterAll();

   mockery.disable();

});

describe('On initialization', () => {

   it('should set up the logger with default settings if no options are provided', () => {

You need to change this test, logStubs.info will always exist because you
create it in the test. So the test doesn't actually prove anything
—
Reply to this email directly, view it on GitHub
https://github.com/hyperledger/caliper/pull/1630#pullrequestreview-2355135853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH6TKS2NBGHBEFK76BB3YXDZ2YVHXAVCNFSM6AAAAABOAQ4Z5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJVGEZTKOBVGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update README.md

**Describe the issue that the Pull Request resolves**
A clear and concise description of the issue. If the issue is present in the list of issues, mention closes #<issue number>

**Describe the changes the Pull Request makes**
A brief description of the changes in logic or code made and how it resolves the issue. No need to mention the list of all the files changed, but mention those files where significant logic changes had been made.

**Mention the person responsible for reviewing the proposed changes**
Use @ to bring out a list of contributors of this repository and choose the person to tag.(Optional)

MAKE SURE THAT THE PULL REQUEST IS TO THE DEV BRANCH AND NOT THE MASTER BRANCH
ANY PULL REQUEST TO MASTER BRANCH WOULD NOT BE MERGED UNLESS THE CHANGES HAVE BEEN TESTED IN THE DEV BRANCH
YOU WILL HAVE TO MAKE ANOTHER PULL REQUEST TO THE DEV BRANCH IF YOU MAKE THE PULL REQUEST TO THE MASTER BRANCH
@SubhamKarmakar24

@SamikshaSankar please see the changes requested


Barcode support for users

User Barcodes should start with  and contain the user name of the user. All other bar codes should work as normal tokens.


MGT Components are not rendering with MS Teams Toolkit

I didn't get the calendar events, to-do list and file-lists MGT components to render on the Teams browser on my local machine following the instructions in this blog:
https://devblogs.microsoft.com/microsoft365dev/build-a-productivity-dashboard-with-microsoft-teams-toolkit-for-visual-studio , although I created these artifacts on my M365 work/organisational account which I used to build the project.
I did get the login component to work, however which showed the logged in user
This is the learning outcome 3 as per this blog "Enhance your Teams app by accessing calendar events, to-do tasks and file folders" which could not be achieved.
I have attached an image of the output Teams browser with personal tab minus the contents from the MGT components although the logged in user is correctly rendered

Can you or anybody in the team help solve this urgent issue?
Regards,
Kaushik Roy Chowdhury
Member .NET Foundation

By any chance did you work this out? I have the same scenario, appears to be connecting to graph ok, all scopes have been setup but nothing in the agenda, files and tasks - also checked that data exists.

Thanks and I could not work this out after many tries. The MGT just renders the login component and that's all it does. I have now gievn up on this after wasting several hours on several days. I have communicated to the author on LinkedIn as well as a comment on her video on YouTube but still didn't get a suitable reply.

Hi @krchome, if you didn't try before, can you please try to add a scopes in the provider and let me know if it works:
<script src="https://unpkg.com/@@microsoft/mgt/dist/bundle/mgt-loader.js"></script>
<script>
        mgt.Providers.globalProvider = new mgt.Msal2Provider({
            clientId: "@Configuration["TeamsFx:Authentication:ClientId"]",
            loginHint: "@User.Claims.FirstOrDefault(c => c.Type == "preferred_username")?.Value",
            redirectUri: "/blank-auth-end.html",
            loginType: mgt.LoginType.Popup,
            authority: "@Configuration["TeamsFx:Authentication:OAuthAuthority"]",
            scopes: ["User.Read", "User.ReadBasic.All", "Calendars.Read", "Files.Read", "Files.Read.All", "Sites.Read.All", "Tasks.Read", "Tasks.ReadWrite", "People.Read"]
        });
</script>

I've injected the code above without any success.    I've built the app using https://devblogs.microsoft.com/microsoft365dev/build-a-productivity-dashboard-with-microsoft-teams-toolkit-for-visual-studio/ and I've also cloned the app from GitHub.
I get the same behavior every time.  I am never prompted to grant Graph permission so the mgt doesn't render.
I put a debugger statement after code snipped above.    When it hits the break point,  loginHint is empty "".   Not sure if that matters.
If I hardcode my user name, it has not effect.

Hi @GeorgiaGit, I am sorry to hear that you are still facing an issue. Did you try to check the browser settings, it might be blocking the pop-up features. You may try to test the productivity dashboard by replacing the person component with the login component which will require a login without single sign on and bring the user profile info:
Login Component:
<mgt-login></mgt-login>

Ayca,
Thanks for taking the time to get back to me.   Using the login component definitely helped with getting the sample operational!
Thank You!
I'll update once I find out the issue with mgt.LoginType.Popup.    The browser doesn't seem to have an issue opening a pop-up when signing in using the  control.   Pop-Ups are allowed under settings in my browser as well.

So glad login component helped @GeorgiaGit, keep me posted please if you find out what could be the reason it doesn't work through SSO without the login component.


Update users.py (Enhancements for InstagramScraper class)

#190 Issue Resolved

Issue Resolved under GSSOC 23

Hey @anupammaurya6767, there are some merge conflicts. Please resolve them first.

@nikhil25803 created another pull request check that


Migrate pallet-sudo to pallet!

Part of #7882.
Converts the Sudo pallet to the new pallet attribute macro introduced in #6877.
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
⚠ Breaking Change ⚠
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Sudo pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Sudo pallet.

CI is failing with this warning as error https://gitlab.parity.io/parity/substrate/-/jobs/867537#L473:
error: associated function is never used: `call_functions`
  --> frame/sudo/src/mock.rs:48:12
   |
48 |     #[pallet::call]
   |       ^^^^

I don't get it because it is clearly used by the construct_runtime expansion: FnEncode ( logger :: Pallet :: < Test > :: call_functions. Any ideas @thiolliere?

yes but the metadata function (which uses call_functions) generated by construct_runtime is unused I guess, thus it complains about unused items.

Ah yeah, I wonder how that worked with the legacy decl_module! though

maybe rustc is not doing the same checks for both macros kind.
Anyway you can add a dummy test:
#[test]
fn dummy_use() {
Test::metadata();
}

Or actually we can add in construct_runtime #[allow_unused] for the function metadata.

Ah yeah, I wonder how that worked with the legacy decl_module! though

The original macro already annotated the generated fn with #[allow(dead_code)], I've just done the same for the new one.


Create INTECAP

INTECAP

@Reginaldo08 liberación/dominios/INTECAP: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Reginaldo08 We regret to inform you that we are unable to process your request at this time due to the file name not following the repository rules.
To resolve this, please take a moment to review the rules at the bottom of this page and submit a new request with the correct file name and the school name.
For new request, please include the following in your comment:

School website URL
School street address (city and country)
URL of an IT-related long-term course page on the website
Proof of official email domain recognition.

We appreciate your cooperation and thank you for your understanding.


Fix and move the filter functionality in ScheduleFragmentViewModel

Actual Behaviour
The filter functionality of ScheduleFragment is implemented inside the Fragment. It isn't working properly as well.
Expected Behaviour
It should be fixed and moved inside the ViewModel
Would you like to work on the issue?
Yes

@simarsingh24 I am already very occupied with other issues hence if you want, you may go ahead with this. I think you're also occupied with implementing the Event invoices and Discount codes, hence if you want we may hand it over to @mayank8318 who could do it a bit quicker.

@srv-twry sure! i will start working on it :)

@srv-twry the core logic for the filter is written inside DayScheduleFragment and the latter doesn't have a ViewModel what should be done?
((DayScheduleFragment) adapter.getItem(position)).filter(selectedTracks);

Oh, i realised now that there are two types of filtering in the ScheduleFragment. The filtering mentioned in this issue is actually in the method filterSchedule.

@mayank8318 I am a bit occupied right now as I have an interview coming and also other active issues, you can go ahead and work on it if you want, (I will finish it if you are also busy). Do drop a comment below and let us know if you are going to work on it

@simarsingh24 I will start working on it.

@sejalgoyal please go ahead !

@iamareebjamal If I am not wrong the current implementation is as follows:

Query all the tracks for the day and sort according to the sort order specified
Make a list of selectedTracks as per the tracks selected in the filter dialog by the user( by default we assume everything is selected)
Execute the String Search Query on this selectedTracks to narrow down on a final list which is displayed to the user.
Please correct me if I am wrong

Yes

Lots of memory leaks and working with arrays. The implementation has problems, not the model. Neither it is reactive and present in ViewModel making it tightly coupled with UI

@iamareebjamal Ok what about this type of implementation ->
We only keep one arraylist in the UI. This will be displayed to the user. All the manipulations will happen in the View Model and this arraylist will be returned to the UI and the UI shall update accordingly. The UI won't know how the array is being manipulated, it will only display it and call for view model methods for manipulation when the user chooses to filter etc.

yes


Use tensorframes v0.4.0

Codecov Report

Merging #138 into master will decrease coverage by 12.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #138       +/-   ##
===========================================
- Coverage   85.37%   73.22%   -12.15%
===========================================
  Files          33       10       -23
  Lines        1921      493     -1428
  Branches       44       44
===========================================
- Hits         1640      361     -1279
+ Misses        281      132      -149

Impacted Files
Coverage Δ

python/sparkdl/param/converters.py

python/sparkdl/param/shared_params.py

...n/sparkdl/estimators/keras_image_file_estimator.py

python/sparkdl/utils/jvmapi.py

python/sparkdl/transformers/keras_image.py

python/sparkdl/transformers/keras_applications.py

python/sparkdl/graph/utils.py

python/sparkdl/graph/pieces.py

python/sparkdl/graph/input.py

python/sparkdl/transformers/keras_tensor.py

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73a4a2...bd9d9e9. Read the comment docs.


unexpected editor background color

after upraged to 232.1, backgroud color of the editor seems weird:

this is the expected color from the last release:

https://www.jetbrains.com/help/idea/configuring-colors-and-fonts.html

hi @4lex4 do you mean this color change in 232.1 is expected? thanks!

ok, i know what u meant. after the upgrade, the editor color theme needs change explicitly. thanks!