Preview pricing

There doesn't seem to be any pricing info here or on the Monitor pricing page:
https://azure.microsoft.com/en-us/pricing/details/monitor/
Do the data ingestion and retention limits and prices apply to this solution? Are there any additional costs?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77f273ec-aed5-1f65-0b6d-87240765d3e0
Version Independent ID: d195959f-5742-7d94-f4f5-e70c0f0581e7
Content: Azure SQL Analytics solution in Log Analytics
Content Source: articles/log-analytics/log-analytics-azure-sql.md
Service: log-analytics
GitHub Login: @danimir
Microsoft Alias: v-daljep

@dcbrown16 Thanks for the feedback! We are currently investigating and will update you shortly.

The Log Analytics pricing listed on this page applies: https://azure.microsoft.com/en-us/pricing/details/monitor/. At this time 5GB/month is free which should be more than enough to monitor couple of databases for free. Above the free tier, the pricing depends on how much diagnostics telemetry monitored databases ingest into the solution. You should note that more active databases with heavier workloads will consume more versus idle databases. The best way to estimate your consumption is to start monitoring and measure it yourself on your specific workloads.

Thanks @danimir, the customer I am working with was unsure because there are often previews for Azure services with no cost or different costs, but I understand that SQL Analytics is billed to Monitor under normal rates. Appreciate the quick response!


[ruby] Boolean methods

In Ruby you get boolean methods indicated with a ? at the end of the function name:
e.g
def boolFunc?
end

To make this work properly it might require some changes to the grammar, since boolFunc? is probably not a valid SimpleIdentifier under normal circumstances, so the node.target is being defaulted to an Unknown() node, which results in the call not being resolved.
Node:

Test code:
class Foo
  def somefunc?
    true
  end

  def bar
    if somefunc?
      puts "baz"
    end
  end
end

I think what's missing is a visitor for methodOnlyIdentifier contexts, i.e.
override def visitMethodOnlyIdentifier(ctx: RubyParser.MethodOnlyIdentifierContext): RubyNode = {
  SimpleIdentifier(None)(ctx.toTextSpan)
}

because in visitMethodCallExpression we are visiting ctx.methodOnlyIdentifier (to extract the target of the SimpleCall) which, by default, gets you an Unknown cf. defaultResult().


Explain that Array.duplicate will not deep-copy Object.

This was somewhat implied by specifically calling out nested arrays and
dictionaries, but I was still unsure and had to test it myself.
One might expect that Resource objects, which have a duplicate
method, might be deep-copied.

Why is it this way, though, if it would technically be possible and the expected behaviour?

Objects don't have a defined copying logic. Resources might, but it's not entirely generalized.

Thanks!


Adapt block creation for Altair

PR Description
Adapt the block creation process to allow for setting the SyncAggregate field in Altair blocks.  Currently the sync committee logic isn't implemented so it's not being set but wanting to get a sense of whether this approach to supporting the setting of different fields works.
The key question is whether we should go this way and keep BeaconBlockBody as immutable or should follow the approach of BeaconState and introduce a MutableBeaconBlockBody and that mechanism for building blocks.  The key challenge being that while the spec module contains the block data structures and BlockFactory, it doesn't have access to the OperationPool and other sources of information that go into a block, so code outside the spec needs to adjust based on whether the block needs a SyncAggregate or not.
Fixed Issue(s)
#3648
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

In other words using potential MutableBeaconBlock is kind of overkill and not safe.
MutableBeaconState was a necessary trade off cause a builder pattern just didn't suite there

In other words using potential MutableBeaconBlock as a builder is kind of overkill and potentially not safe.
MutableBeaconState was an unavoidable trade off cause a builder pattern just didn't suite there

Good, that's justification enough for me to not follow that pattern. Apart from some tidy up around names etc, I was fairly happy with where this landed, just worried about introducing a new pattern if the existing one for states made sense to use.  But sounds like they're different patterns for clearly different use cases so all good.


Cleanup various source code (mostly) formatting issues

The majority, but certainly not all, of this is automated fix up. It is on my TODO to enforce all the style checks on CI so things do not get stale again.

This change is

+@EricCousineau-TRI for review.

, with a few minor comments.

Reviewed 13 of 23 files at r1, 13 of 13 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

drake_cmake_installed/src/find_resource/find_resource.cc, line 53 at r2 (raw file):

    std::cerr << "Should have thrown" << std::endl;
    return 1;
  } catch (const std::runtime_error&) {

BTW This looks a tad odd?

drake_cmake_installed/src/particles/test/test_particle.cc, line 30 at r2 (raw file):

 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 *****************************************************************************/

Can you add a TODO for me in this file to change it to pure C++, and not use GTest?

drake_cmake_installed/src/particles/test/test_particle.cc, line 33 at r2 (raw file):

// clang-format off
#include "particle.h"  // IWYU pragma: associated

BTW Shouldn't this be allowed by default? Seems odd that the linter catches this.

Comments from Reviewable

Review status: 18 of 28 files reviewed at latest revision, 3 unresolved discussions.

drake_cmake_installed/src/particles/particle_test.cc, line 30 at r2 (raw file):
Previously, EricCousineau-TRI wrote…
Can you add a TODO for me in this file to change it to pure C++, and not use GTest?

I added it in the CMakeLists.txt. There are multiple files.

drake_cmake_installed/src/particles/particle_test.cc, line 33 at r2 (raw file):
Previously, EricCousineau-TRI wrote…
BTW Shouldn't this be allowed by default? Seems odd that the linter catches this.

Seems we were not following the Google naming convention for tests. Should be fixed by the latest commit.

drake_cmake_installed/src/find_resource/find_resource.cc, line 53 at r2 (raw file):
Previously, EricCousineau-TRI wrote…
BTW This looks a tad odd?

BTW True, but it keeps clang-format happy.

Comments from Reviewable

Reviewed 15 of 17 files at r3.
Review status: 27 of 28 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable


Remember_token always regenerated when user logs in: existing one never kept anymore

In commit https://github.com/plataformatec/devise/commit/c92996646aba2d25b2c3e235fe0c4f1a84b70d24 a change was made that causes remember_tokens to be regenerated without checking whether the old one has expired. This causes a problem when users log in on multiple browsers or devices. Every time they log in, their session on other browsers/devices is invalidated, because a new token is generated.
My project is forced to stick with Devise 3.5.3 because of this breaking change. The fact that the commit I mentioned still contains a TODO is probably indicative of the fact this is a problem to be resolved.

@michieldewit are you using the manual remember_token? If so, I believe you are right. I completely forgot about this case, sorry about this. We need to tackle it.

@josevalim We use stored remember_tokens indeed. Going back to 3.5.3 did not work for us either, btw, because of the new format of the remember cookies. Right now, we monkey patched Devise::Models::Rememberable.remember_me! in our User model to work more or less like in the old situation. It's ugly, but it works:
def remember_me!
    token_expired = self.remember_token.blank? || self.remember_created_at.blank? || self.remember_created_at + self.class.remember_for < Time.now.utc
    if token_expired
      self.remember_token = self.class.remember_token
      self.remember_created_at = Time.now.utc
      save(validate: false) if self.changed?
    end
  end

@michieldewit you no longer need to renew or expire the token. So my suggestion would be to just set it if none is set. If you want to expire existing tokens, you just clean the database column.

@josevalim About the expiration you are probably right. Still it feels a little safer to know that remembered sign ins will automatically expire when a user has not been active for X days

@michieldewit this property is now intrinsic to the new system.

Any update on this? We've add the monkey patch, but would prefer this fixed in Devise.

Thanks @reedloden and @michieldewit . I think a simpler fix on this is to rewrite the remember_me function to work like this:
      def remember_me!(*)
        self.remember_token ||= self.class.remember_token if respond_to?(:remember_token)
        self.remember_created_at ||= Time.now.utc
        save(validate: false) if self.changed?
      end

Can you please confirm this also works as expected? I only changed the remember_token assignment to use ||=.

I can confirm the simpler fix works, wouldn't this be a bit easier to read though?
  def remember_me!(*)
    return unless respond_to?(:remember_token)

    self.remember_token ||= self.class.remember_token
    self.remember_created_at ||= Time.now.utc
    save(validate: false) if self.changed?
  end

We still need to execute remember_created_at if you don't have respond_to?(:remember_token).

@josevalim Could you explain why we need to execute self.remember_created_at ||= Time.now.utc when self.remember_token isn't being set?

@jjoos because you can use the remember token completely without tokens, by relying on the authentication salt

Still awaiting a fix in Devise for this.

This issue was related to extended remember me configuration was working as always true.
I think it is fixed on Devise 3.5.7 and 4.0.0.
Feel free to reopen if the problem persist.
Related PR: https://github.com/plataformatec/devise/pull/4039

I just upgraded to Devise 3.5.8 and I'm still seeing this issue; the remember_token is reset every time the user logs in, so that if they log in on browser A, and then later on browser B, the remember_token changes and the session on browser A is invalidated.
Am I supposed to be using extend_remember_period = true to get the behavior I want (i.e. logging in to a second device doesn't log them out on the first). The documentation isn't very verbose about what extend_remember_period does.

@bsoule Thank you for the feedback. The extend_rememeber_period configuration about extends the period of remember token validity. When you set to true, every time the authenticate user use the application with a valid remember token the expiration date of the token will be extended. When it is set to false, the expiration date will never be updated until it expires.
The option you have suggested is support multiple remember tokens, I think today Devise does not have this option out of the box. You may want to implement it by yourself or find gem that does.
Feel free to open a pull request to improve the configuration template text or the README documentation with a better explanation.
Best

@josevalim What's the expected behaviour when user sign in using a browser with remember me checked with a valid existent remember token from another browser? Should it override the existent one?  Is possible today Devise support multiple remember me cookie tokens from different browsers?

Thanks for explaining the extend_remember_period option. Much clearer now :-)
From reading the comments in this issue, it sounds like remember_token should not get overwritten when a user is signing in and a valid token already exists. Above @josevalim proposes a fix where you'd set the remember_token with ||= in remember_me!
If the expected behavior is indeed as described in this thread, then the original issue described still remains in the master branch. I can submit a PR for this.

@bsoule You're right. Feel free to submit a PR with this fix :) . Would be good have a regression test too.

Hi people, if anyone has some time to try out the branch with the fix and give us some feedback. I can release a patch version. The PR with the fix: https://github.com/plataformatec/devise/pull/4101

I thinks is fixed now on 3.5.10, 4.0.3and4.1.1`. :pray:


minmax

Here's an implementation of minmax, from our colleagues at Oceanscope. A few thoughts on the first draft:

The helper functions provided by the original authors are included verbatim. Some simplification might be possible since that implementation folded running over lists of profiles into the test logic, whereas AutoQC factors this out.
Unit tests are currently somewhat minimal and could do with some expansion. Currently they check that the temperature mins and maxes and the final QC results come out the same in this implementation as they did in the example provided by the authors for the first profile in their example dataset. That's a good start, but I'd like to see checks on edge cases and more pathological profiles as well, including exception handling around missing data.
QC runs and tests pass in the environment described by the container image iquod/autoqc:1.0-rc3, with the following modifications:

upgrade pandas -> 1.1.4
install xarray at 0.16.1
copy original author's parameter files into /AutoQC/data
I haven't posted this environment anywhere yet as @s-good mentioned we may need to discuss proper attribution before we distribute those parameter files. Perhaps a DOI should be created for them if feasible?

Domain experts: I wonder if it's possible to re-write this to not rely on salinity data, so that we can successfully run this test on profiles that only have temperature, depth, lat and long available. The only thing the salinity data object seems to be getting used for is its depth profile; perhaps we could take that elsewhere and do away with salinity considerations.

Let me know any thoughts on the above or the implementation included, and we can correct from there.

Many thanks to Rachel Killick for the testing, comments and implementation in 713269a!

Tests are now passing for minmax in image iquod/autoqc:1.0-rc4; the fails reported by CI are all actually CoTeDe fails, which are already resolved in #261.
I also include here an outline of a REFERENCES.md where we can list DOIs and other citations; CoTeDe and Wodpy have obvious DOIs to cite and minmax's code will also have one shortly per our discussion with Jerome. @s-good let me know what you think would be best for citing everyone else (AOML, CSIRO, ICDC and others).

The draft paper contains the full list of citations for all the QC checks. We could either link to the paper once it is published or take the information from the paper and put it into a table.
Should we merge this pull request and open a new issue to sort this?


✨ Add Svelte integration

Description
Currently, Svelte isn't supported by style-element, would be great to have the same DX as React but on Svelte.

This is expected to be integrated with other frameworks after the official release of 2.0 and runs with the React version for some time to ensure completeness.


JSON error in model export

When exporting, the current behavior is:

Begin entity = print "FM3" : "..."
Serial = print "id" : aNumber,
Print properties

The issue is occurring when an entity has no properties: the coma after the id number is not followed by anything before closing the object. That is not correct in JSON.

Fixed by #80


wip: fix demo notebook for tensorflow

fix demo notebook for tensorflow
Note: this is still work in progress and not yet for checkin

@imatiach-msft looks like this got put in with flake issues that stopped the tests from even running at all? That seems bad


fix: unpublish published entry

Summary
A fix for the issue described by Mateusz on slack:

New beta feature publish/unpublish, with editorial workflow on (not sure if this is related, just letting you know) ->
When you unpublish, new branch is being created to store the file you unpublished. Good.
Then the file gets displayed under Workflow tab in CMS. Perfect.
I check in repo, and the file exists on this new branch which is cool.
Then you click to publish inside CMS to get file back again, and you randomly get error in cms, on repo branch storing unpublished file gets merged to the main branch, but it says branch has no changes, so its like empty merege, and the “store” branch gets deleted. (so you basically lose your “unpublished”  file)
-> I basically lost that way few files, but I also managed randomly to get things merged from “store” branch as it should wthout error and losing file.

Thanks @erezrokah


completes (and thus fixes https://github.com/openzipkin/zipkin/issues/1646 )

protip: a single line in the description or commit "fixes #1646" would magically close it


WrapperAutounboxing

Java program to convert primitive into objects i.e Autoboxing example of int to Integer (Primitive to Wrapper)

It's Wrapper Autoboxing*


batch process feature

very interested in a batch process feature also
Originally posted by @LexCybermac in https://github.com/Tps-F/sd-webui-blip2/issues/2#issuecomment-1452721299

I second that! Really need this feature

We all need it!!!
Plz help as!!!

Can you be a little more specific?
Looks interesting

Can you be a little more specific? Looks interesting

Look at Train menu at 1111
Than at Preprocess images - Use BLIP for caption checkbox.
If you add Use BLIP2 for caption - will be super! )

Thanks guys!!!
I'll get to it as soon as the school exams are done.

https://github.com/p1atdev/stable-diffusion-webui-blip2-captioner

I'm finish it-
f60e74a

Oops
I'll fix it as soon as I eat.

Make it possible to save in one csv file!

Nice idea! I'll try it.

Done!
0210b3b

Thx Bro !
There is also a cool feature.
Caption min length
Caption max length
https://github.com/p1atdev/stable-diffusion-webui-blip2-captioner/blob/main/screenshots/screenshot-1.jpg


Replace download method for timesformer

Signed-off-by: Jael Gu<EMAIL_ADDRESS>The torch.utils.model_zoo.load_from_url fails to download the proper model weights.
Change to subprocess wget

/lgtm
/approve


Update layers.py

I have added a check on beta with reference to the following issue raised.
https://github.com/tensorflow/tensorflow/issues/11673
Please verify and get back.
Thank you.
I will add update the unit test cases to verify this patch.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

Please add the test as requested in the previous version of the CL, otherwise this looks great, thanks!

https://github.com/tensorflow/tensorflow/pull/13864 contains the updated unit test case.

Can one of the admins verify this patch?

It looks like you may be having trouble updating this PR to include all the changes  -- perhaps it makes sense to resend a new fresh PR with all of the requested changes (layers.py and layers_test.py change in the same PR).  Thanks!


Cannot read property 'call' of undefined

@line 51:
callback.call (window);
It seldom happens to some people, I wonder why?
And it's a great job, thank you very much.

Thanks for reporting.
My code does not check if your callback is valid function before calling it.
So if callback you pass to setInterval and setTimeout are not functions my code will throw error.
I will fix it as soon as possible.

I have fixed it.
Check if it is working as expected, please.

Ok, I will keep monitoring it.
Thank you again for your great work!


Updates to Armeria 1.27.1 and fixes Eureka VIP registration bug

This updates to latest Armeria 1.27.0, which removes some tech debt. This also fixes a bug in the default behavior of Armeria, which is that it sets a host:port value for the VIP address in Eureka. While the instanceId needs to be qualified with port, the VIP address must not, as there's already a port field.
cc @openzipkin/armeria

tomorrow I'll raise a PR on the armeria side about the bad default on vipAddress, which shouldn't be host like http host header, rather a host like dns hostname.

https://github.com/line/armeria/pull/5451 should fix upstream

Thanks for the review @reta!


Showing invalid command when using command to set property with properties that have not been explicitely specified in if-clauses

BkCommonLib version: 597
TrainCarts version: 504
Spigot version: 1573-j

Related to #299
Problem or bug, and steps to reproduce: /cart drivesound shows unknown command even though /cart drivesound BLAZE_AMBIENT is valid.
Expected behaviour: A description of the property, usage information, anything except the unknown command message.

The entire property system needs to be rewritten so that it has metadata such as description, usage, aliases, etc. for every property. There should not be a long list of if-clauses at all, but that's how years of laziness made it turn out to be :)
Question is when I finally start working on that

Closing as it's working in progress, should be released in next TrainCarts release version (supposedly 1.16.4-v2)


Force _WIN32_WINNT variable

Fixes #612.
Compiled on Win 10, launches and works fine on Win 7.

This should be fine tbh probably, as long as it doesn't break newer Windowses (also shouldn't).
Although ngl a cleaner solution would probably to define a shim for CreateFile2 that'd in turn call CreateFileW instead with the right params, as chances are this might be the only cause and place it breaks. Then our own CreateFile2 replacement would be used instead of linking it from Windows... This would be simpler and less risky of potential unknown breakage somewhere else.

Also also also also: https://github.com/zlib-ng/minizip-ng/commit/9829913018955aeb5f24acfd01eb79eaaaffa02f
You should create an issue in the original repo mentioning that since they don't do a check for WinRT API anymore at all, they should just junk that check before CreateFile2 and simply just use CreateFileW, there's ZERO reason for them to use CreateFile2 now to begin with (apart from old limited WinRT API that isn't checked for anymore?), especially that they DON'T use the last LPCREATEFILE2_EXTENDED_PARAMETERS pCreateExParams param of CreateFile2, passing NULL there, meaning they literally could just use CreateFileW...

HANDLE CreateFile2(LPCWSTR lpFileName, DWORD dwDesiredAccess, DWORD dwShareMode, DWORD dwCreationDisposition, LPCREATEFILE2_EXTENDED_PARAMETERS pCreateExParams)

And actually, if we go this way (of this PR), it would be preferred to have this define set only when compiling the actual files of minizip library itself, instead of applying it to main project and all children...

I found a way to define variable only for Minizip lib.

As for the shim func, just do this:
HANDLE CreateFile2(LPCWSTR lpFileName, DWORD dwDesiredAccess, DWORD dwShareMode, DWORD dwCreationDisposition, LPCREATEFILE2_EXTENDED_PARAMETERS pCreateExParams)
{
    return CreateFileW(lpFileName, dwDesiredAccess, dwShareMode, NULL, dwCreationDisposition, NULL, NULL);
}

I'm not sure where to do that. Should it be a WinAPI hook or something else?

I'm not sure where to do that. Should it be a WinAPI hook or something else?

Technically in any file that's getting compiled in, and that should then cause it to be linked (I'm hoping the linker won't complain about symbol duplication though...). As for particular place, perhaps a new file under /primedev/windows/?

This is fine imo with this method, where the variable is limited just to the dependent library and thus limits possible impact of side effects its definition might had otherwise imposed in main project. I assume that the PR author checked that it still works on Win7 with the latter changes xd

Current main branch build is working fine.

For testing, I assume just join a server that requires a mod through MAD and make sure it extracts correctly, right?

Yeah you might do that. But original issue was with linking and bailing out on missing symbol. So just ensuring the game still starts up to begin with on Win10 is enough. If you don't test on actual Win7, then check with some tool like Detect-It-Easy or whatever else (PE Explorer etc) whether in Imports section from iirc kernel32.dll whether there's just CreateFile and not CreateFile2. For extra scrutiny you can confirm that CreateFile2 import is there on DLL before this PR is applied

For testing, I assume just join a server that requires a mod through MAD and make sure it extracts correctly, right?

Btw, I tested joining a server with mad and this PR, and all went fine.

Aight given that this appears to have no effect on newer Windows versions then, I'm fine with merging this even if we don't support older Windows version.
The suggested solution for issues with older Windows versions is of course to switch to Linux update to a supported Windows version, however I also don't see a need to actively oppose a community contribution, given that it has no (negative) effect on supported platforms.


prometheus: move promDistBlockPeerFailures to readFromPeer()

prometheus: move promDistBlockPeerFailures to readFromPeer()
ReadLevel doesn't increment the promDistBlockPeerFailures when we set
ReadSpread in current code. Since GetBlock() for remote peers are
called in readFromPeer, this patch moves promDistBlockPeerFailures
incrementation to readFromPeer()

Can you explain briefly why you want to make this change? Also we actually might increase the counter in getblock func. Moving the accounting to the caller might double count if you do not change getblock.

Sure, I explained it in the first comment.


.htaccess file not wotking in wamp

i watched your video somewhere else and i follow step by step, but seem .htaccess was a burden in wamp that always return 500 or 400 error.
in the end ill' finished your video without htaccess. so to access posts route i use http://localhost?posts/index. this is do the trick for me following your video. i want to know why this happen in wamp(php 7x).
another way to improve this mvc, that i want slashing in the end of route not trigger error, may be you can do with htaccess or with some kind tweak on your Route.php file so if someone access with trailing slash, it should be remove in the end of uri.
one more thing this mvc can improve if {controller}{indexAction} automatically redirect to just controller i mean like this http://localhost/posts/index redirect to http://localhost/posts

To fix the wamp issue edit your .htaccess file and remove the following line
RewriteBase /

Hi,
thank you for letting me know about the WAMP issue. I left the RewriteBase / line in so it was compatible with .htaccess files when the public folder hasn't been assigned as the root. I'll look into a fix so it works universally.
Also, thank you for the suggestion of the default action, good idea! I'll look into the necessary code modifications and let you know.
Cheers,
Dave

Hi @daveh,
I think you should comment this line by default and add a comment like the this https://github.com/joomla/joomla-cms/blob/staging/htaccess.txt#L58-L64
Thanks

Hi,
that's a great idea, thank you for the idea and example! I've tested it and I'm happy with that, so I've done as you suggested.
Cheers,
Dave

@daveh Thank you


Deprecate in README.rst

Add info about deprecation

Codecov Report

Merging #152 (a8786a2) into main (490e434) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   82.50%   82.50%
=======================================
  Files          55       55
  Lines        3573     3573
=======================================
  Hits         2948     2948
  Misses        625      625

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Discuss a license

Now that we are approaching initial release, we must choose a license for the library.
I think that the MIT License is a good candidate.
What do you think?

@faku99 I think it's a good choice as well! For me, we can go for a MIT license.


Fix Cambodia phoneMasks

Cambodia phone numbers can be (0)12 345 678 or (0)12 345 6789. https://en.wikipedia.org/wiki/Telephone_numbers_in_Cambodia

@s-masaya-tt thanks for your contribution!

@s-masaya-tt thanks for your contribution!

Thanks for a great library!


CopyList window position is undetermined with multiple monitor setup

@LandonHammond use getPrimaryDisplay():  https://github.com/electron/electron/blob/master/docs/api/screen.md#methods


Please add Durham, NC

******* A subject message for the email: Defund the Police & Reallocate Funds
******* A list of emails<EMAIL_ADDRESS><EMAIL_ADDRESS>******* A detailed message concerning the budgeting decisions that are at stake in your community
Dear Mayor Schewel & City Council Members:
My name is ________. I am a resident of Durham.
I am writing to object to the allocation of over $70M to the Durham Police Department in the 2020-2021 city budget. It is indefensible to increase the police budget when city workers face layoffs and denial of wage increases, and thousands of our community members face unemployment, and housing and food insecurity in the midst of the COVID-19 pandemic.
 The police cannot protect us from these challenges. In fact, more often than not, when police are dispensed, rather than more qualified medical, psychiatric, and social work professionals, the effect is to bring violence where none previously existed, despite the best efforts of all involved. Moreover, to paraphrase an existing council member, it is not cities with the most police, but the most resources, that are the safest.  To that end, I make a two-fold request to the council:

Reallocate all proposed increases in police budget to Durham Public Schools, affordable housing and rent subsidies, eviction diversions, food resources, and medical supplies, which have both immediate and longstanding consequences that will more positively affect our current residents.
Implement a 5-year plan to reallocate---at a minimum—50% of existing police resources to institutions and experts better equipped to deal with many of the issues DPD have been conscripted, without adequate training, to do. Resources should be allocated to EMTs, social workers, and other social service providers to respond to the majority of current police business, including health and wellness checks, domestic/sexual violence situations, and basic bureaucratic documentation around break-ins, vandalism, wrecks, etc. Additional money should go to community education around de-escalation and community support for drug, SV/DV, and property-related incidents.  I recommend that you follow the lead of progressive cities such as Austin, TX and Camden, NJ in this regard. There is no reason to have armed officers responding the majority of emergency needs in Durham. Finally, I request that you divest over half the force of offensive weapons. Offensive weapons are known to escalate violence, especially when deployed in situations where none existed before. Almost all the current litany of Black men and women dead from police violence were non-violent, unarmed people, for whom armed police became the site of death and violence.   Thank you,

[YOUR NAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

Durham is live! closing this one out.


Fixed sentence error in Readme

Edited the Readme file to add a forgotten word

@onevcat fixed one more mistake

+1


Generate API documentation

This has got to be possible- it's already confusing navigating this project. We should have some kind of documentation generator so people can maintain this.

We'll be using APIDocJS to auto-generate the server API documentation. The requisite infrastructure is in place - I'll design a template to help developers add documentation to our API controller methods. We'll manage this process on a controller-by-controller basis in smaller tickets so I'll close this issue.


Github fav markdown render.

Use the Github official markdown render api to render the markdown text to html.
May or may not persist the doc in local till it got changed.

Done :)


chore(release): v0.12.3

Running acc tests here : https://github.com/aiven/aiven-operator/actions/runs/5541203085


Using custom target json file is breaking artefacts copying ?

Hi, i'm running into an issue and could use some pointers
The gist of it is that i'm using a non standard target (riscv32imacf-unknown-none-elf). It is slightly different from the non float version but enough so it will not link if both are mixed.
As a result the target is different, i.e. instead of
SET(Rust_CARGO_TARGET "riscv32imacf-unknown-none-elf" )
it is
SET(Rust_CARGO_TARGET "${SOME_PATH}/riscv32imacf-unknown-none-elf.json" )
Where the json file is describing the target.
That works fine up to the copy by_product step where it is using TARGET to contruct the path to the source artefact(s) to copy
So, when a json target file is used, it will insert the full path of the json file in the "source" path  & fail.
I can try to provide a patch but could use some guidance.
Thank you

Thanks for the report. I think #316 should be sufficient to fix this, but it would be great if you could verify this.


Website BUG: Back button does not work.

Bug Description
Pressing back in the browser does not work, all it does is remove the preview.
Steps to Reproduce

Open the website
Select a component
Click back

Expected Behavior
The site returns to the list of components
Screenshots
https://user-images.githubusercontent.com/12257112/184516182-5f9ffcfe-2293-449c-a07d-f2ea382963d2.mov
Desktop

macOS Monterey 12.1
Firefox 103.0.2

I've had a look at this but I can't find a solution, do you have any thoughts?
I'm not a Firefox user so this behaviour is new to me, it works fine in Chrome and Safari.

I noticed a few things:

Clicking back removes the first component

Clicking forward brings back the first component

Clicking back twice returns to the origin URL

Closing this due to lack of activity and solution.


Remap not sticking

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
When I remap Shift+Enter to run selection, and apply the changes, it does nothing when I press Shift+Enter rather than either run the selection or run all the code.
spyder: 4.0.1
spyder-kernel: 1.8.1
Operating System: OSX Catalina 10.15.3 (19D76)
PyQt5: 5.12.3
What steps reproduce the problem?

Remap run select to Shift+Enter from f9 on OSX
Try to run a code snippet using Shift+Enter

What is the expected output? What do you see instead?
I expect it to run selection; instead it does nothing
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

I can reproduce this. If I make the changes with spyder running and try to use it I get an Qt message on the Internal  console
(QAction ambiguous shortcut or similar I forgot)
If I restart it works as expected.
Please take a look at this @steff456

I cannot reproduce on Windows on latest master.

But it seems an issue on 4.x (i didnot check master)

But it seems an issue on 4.x (i didnot check master)

On latest 4.x I cannot reproduce also.

Same Qt version? (Maybe it is an OSX issue)
@impact27 could you test if you can reproduce?

Same Qt version? (Maybe it is an OSX issue)
@impact27 could you test if you can reproduce?

No, I run Spyder on Python 3.7.3 64-bit | Qt 5.9.6 | PyQt5 5.9.2 | Windows 10
PyQt 5.12.* is not available in Anaconda, so I cannot test under that version of PyQt easily unfortunately.

@impact27 could you test if you can reproduce?

I can reproduce, I can't run selection from a keyboard shortcut.
Futhermore, the internal console prints when I try to use the shortcut:
QAction::event: Ambiguous shortcut overload: ??
And if I change to maj + R:
QAction::event: Ambiguous shortcut overload: ?R

Spyder version: 5.0.0.dev0 67c105d83
Python version: 3.7.5
Qt version: 5.12.6
PyQt5 version: 5.12.3
Operating System: Darwin 19.2.0

No, I run Spyder on Python 3.7.3 64-bit | Qt 5.9.6 | PyQt5 5.9.2 | Windows 10
PyQt 5.12.* is not available in Anaconda, so I cannot test under that version of PyQt easily unfortunately.

@jnsebgosselin you could use conda forge
conda create --name spyder-test spyder=4 --channel conda-forge

So the problem occurs no matter the shortcut you are using for Run selection?

Possible solution to this problem would be to set the context of the run actions to Qt.WidgetWithChildrenShortcut here :
https://github.com/spyder-ide/spyder/blob/47726b4d3d297b4bfbe6351905b6c44ef2b71e93/spyder/plugins/editor/widgets/codeeditor.py#L3581-L3603
Also, I think that the run_cell_action, run_cell_advance_action and debug_cell_action actions should be registered with register_shortcut here, because they are currently not updated during runtime, only after a restart :
https://github.com/spyder-ide/spyder/blob/47726b4d3d297b4bfbe6351905b6c44ef2b71e93/spyder/plugins/editor/plugin.py#L612-L638

@steff456 please fix this with @jnsebgosselin suggestions

@steff456 please fix this with @jnsebgosselin suggestions

Since I can't test it, I don't know if this is going to fix the issue here. I'm just proposing stuff to try... :P

No, I run Spyder on Python 3.7.3 64-bit | Qt 5.9.6 | PyQt5 5.9.2 | Windows 10
PyQt 5.12.* is not available in Anaconda, so I cannot test under that version of PyQt easily unfortunately.

@jnsebgosselin you could use conda forge
conda create --name spyder-test spyder=4 --channel conda-forge

Thanks!

Also, I think that the run_cell_action, run_cell_advance_action and debug_cell_action actions should be registered with register_shortcut here, because they are currently not updated during runtime, only after a restart :

The shortcut indeed works after a restart

Since I can't test it, I don't know if this is going to fix the issue here. I'm just proposing stuff to try... :P

Thanks @jnsebgosselin! It worked perfectly :)


Can I use the plugin to start my app in background  (or as a service) ?

I need to start my app in background when I boot my device.
Can I use this plugin and how?

Not directly into the background task with this plugin only. Please check out the README.md and the its section "Related plugins". Unfortunately I have no time to maintain this plugin. So it may have some issues with the latest android versions.


Develop

Please first merge my new PR (#83) into dev before merging dev into main.
After that's in, I'll accept this PR. I assume that this PR then reference the updated dev branch? Or would we have to make a new one?


decode_csv: linebreak not escaped in quote

Using tensorflow 1.8, parsing the following file with decode_csv:
"a
b",0
raise the error "Quoted field has to end with quote followed by delim or end".
To reproduce:
file = ['example.csv']

dataset = tf.data.TextLineDataset(file)
dataset = dataset.map(lambda record: tf.decode_csv(
    record,
    record_defaults=[[""],[0]]
))
iterator = dataset.make_one_shot_iterator()
next_element = iterator.get_next()

with tf.Session() as sess:
    print(sess.run(next_element))

I think it is because the linebreak in the quote is not escaped. This behavior seems in contradiction with the RFC2048 specifications (section 2.6).

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@rachellim Do we intend to fully support RFC2048?

We fully adhere to RFC 4180 (https://tools.ietf.org/html/rfc4180) in the tf.decode_csv function.
(I couldn't find anything in RFC 2048, section 2.6 about CSV... I assume that was a typo? Feel free to link me to a different RFC if there is one @PForet)
However, the issue here is that TextLineDataset splits the file on all linebreaks, regardless of whether its encapsulated in quotations (before any notion of CSV is introduced), so the decode_csv function receives an incomplete record as input. I'm working on a fused reading + parsing dataset type that will fix this issue.

RFC 4180 indeed, my mistake. Thanks for the support. Should I edit the title to reflect the fact that the issue relates to TextLineDataset?


Consider support fiber v3

cannot use swagger.HandlerDefault (variable of type func(*"github.com/gofiber/fiber/v2".Ctx) error) as func("github.com/gofiber/fiber/v3".Ctx)

Duplicate of https://github.com/gofiber/swagger/issues/77

close as dup


Code blocks appear on single line

Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Windows
Web browser and version
Chrome 128.0.6613.121 (Official Build) (64-bit) (cohort: Control); Firefox 130.0
Actual Behavior
Code blocks appear on single line.
Current behavior:

Expected Behavior
Expected behavior:

Steps to reproduce
Navigate to: https://p5js.org/contribute/contributing_to_the_p5js_reference/
Would you like to work on the issue?
yes

Appears to be fixed by #536


Don't suggest a fix in "Use DerivingStrategies"

When no deriving strategies on newtypes are not explictly set, it's not possible to know the actual behaviour picked by GHC, so we can't suggest a semantics-preserving replacement.
Following discussion on https://github.com/ndmitchell/hlint/issues/690

CI is failing because of an HLint violation: https://travis-ci.org/ndmitchell/hlint/jobs/552901146

Otherwise looks great

Thanks! I needed to change the tests to assert they no longer produced anything, which I've done.

Oh sorry, I forgot that part. Thanks!
Le lun. 1 juil. 2019 à 22:06, Neil Mitchell<EMAIL_ADDRESS>a
écrit :

Thanks! I needed to change the tests to assert they no longer produced
anything, which I've done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ndmitchell/hlint/pull/698?email_source=notifications&email_token=AABKJ4Z5CN343TP33V35473P5JPUBA5CNFSM4H4UXIIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7GMWY#issuecomment-507405915,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABKJ43CBRLE52L6DVUL523P5JPUBANCNFSM4H4UXIIA
.


[BUG] two paragraphs being added to the editor when using setMarkdown with empty string

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

Describe the bug
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
When using setMarkdown$ function setting the value as empty string (''), it automatically creates a new line after inserting the text.
Reproduction
Start from https://codesandbox.io/p/sandbox/mdx-editor-base-forked-knpmkf to reproduce the problem so that I can observe the issue on my side and make sure that the fix reliably addresses it.
To Reproduce
Steps to reproduce the behavior:

Set up MDXEditor in a file
Then use setMarkdown('') method (you can use by instantiating a ref and using the method)
After type anything to the editor OR use insertMarkdown
See that there is two <p> in the elements, it should be only one

Expected behavior
It should validate if the value is an empty string and not add the new empty line.
Desktop (please complete the following information):

OS: macOS Sequoia 15.1
Browser: Chrome and Safari

Additional context
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 778755d..b8a0239 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -5,7 +5,7 @@ const MdastParagraphVisitor = {
   visitNode: function({ mdastNode, lexicalParent, actions }) {
     if (lexicalTypesThatShouldSkipParagraphs.includes(lexicalParent.getType())) {
       actions.visitChildren(mdastNode, lexicalParent);
-    } else {
+    } else if (mdastNode.children.length > 0) {
       actions.addAndStepInto($createParagraphNode());
     }
   }

Why are you inserting an empty string?

Sorry, didn't catch the notification.
I'm trying to clean the whole text area to an blank state. My use case is a chat message, and when the user send the message it I need it to clean the message box.
It doesn't allow undefined or null, so that's why i'm inserting an empty string.


Kong configuration for functions-v1-all is hardcoded

Bug report
Describe the bug
The url used in the Kong configuration for functions-v1-all is hardcoded in charts/supabase/templates/kong/config.yaml :
url: http://functions:{{ .Values.functions.service.port }}/

Should be :
 url: http://{{ include "supabase.functions.fullname" . }}:{{ .Values.functions.service.port }}/

To Reproduce

Deploy the Helm with a name other than functions for the edge-function.
Request you function through the Kong gateway : curl -X POST http://$IP:$PORT/functions/v1/ping
Looking the Kong logs you will have a DNS resolution error meaning that the Kong gateway cannot find the functions

Set functions.fullnameOverride to functions in the values.yaml fixes temporary the issue.
Expected behavior
The internal DNS name of the functions should be dynamic to support prefixed resources by Helm

This seems to be a duplicate of #61


collapse-all icon for category tree

we need a replacement for sysext/t3skin/extjs/images/tree/collapse-all.gif
It is used on category tree toolbar

thanks


[SUPPORT] OverwriteWithLatestAvroPayload could not combine record by precombineKey

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:

test("Test table type name first merge test") {
withRecordType()(withTempDir { tmp =>
val targetTable = generateTableName
val tablePath = s"${tmp.getCanonicalPath}/$targetTable".replaceAll("\\", "\/")
spark.sql(
s"""
|create table ${targetTable} (
|  id string,
|  name string,
|  ts bigint,
|  day STRING,
|  hour INT
|) using hudi
|tblproperties (
|  'primaryKey' = 'id',
|  'type' = 'mor',
|  'preCombineField'='ts',
|  'hoodie.index.type' = 'BUCKET',
|  'hoodie.bucket.index.hash.field' = 'id',
|  'hoodie.bucket.index.num.buckets'=512
| )
partitioned by (day,hour)
location '${tablePath}'
""".stripMargin)
spark.sql(
  s"""
     |insert into ${targetTable}
     |select '1' as id, 'aa' as name, 123 as ts, '2024-02-19' as `day`, 10 as `hour`
     |""".stripMargin)

spark.sql(
  s"""
     |insert into ${targetTable}
     |select '1' as id, 'bb' as name, 12 as ts, '2024-02-19' as `day`, 10 as `hour`
     |""".stripMargin)

checkAnswer(s"select id, name, ts, day, hour from $targetTable limit 10")(
  Seq("1", "aa", 123, "2024-02-19", 10),
)

})
}

the ut would error
From debug guess parquet base record did not convert to payload to compute with record logs

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.14.0

Spark version : 3.2

Hive version : 1.1.0

Hadoop version :3.2.0

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

@danny0405

Does DefaultHoodieRecordPayload wotk here?

DefaultHoodieRecordPayload can work well，but hudi default payload is OverwriteWithLatestAvroPayload，from
communication master had changed it. @danny0405

@xuzifu666 OverwriteWithLatestAvroPayload is supposed to work like this only.
DefaultHoodieRecordPayload also honours the preCombine value while merging an incoming record with that’s in storage, while OverwriteWithLatestAvroPayload will blindly choose the incoming over anything that’s in storage.

Refer -
https://medium.com/@simpsons/curious-case-of-defaulthoodierecordpayload-vs-default-payload-class-in-hudi-efbfa423c48e

@ad1happy2go @danny0405 All had been resolved，Thanks and close the issue


Not able to set up callbacks in member function of object in c++.

I'm not able to set function call backs in member function of an object. It is not able to cast the type correctly. The callbacks are defined in the same file as the member definition. The settings variable is local to the member function.  This is my header. And this is my implementation file.
I have defined the callbacks in the implementation file and tried to set up the call backs in the member function getRequest in the implementation file, but it is giving me this error :
HttpParser.cpp:153:27: error: cannot convert ‘HttpParser::header_field_cb’ from type ‘int (HttpParser::)(http_parser*, const char*, size_t) {aka int (HttpParser::)(http_parser*, const char*, long unsigned int)}’ to type ‘http_data_cb {aka int (*)(http_parser*, const char*, long unsigned int)}’
  settings.on_header_field = header_field_cb;

Please help me fix this. Thank you.

Simple:

Store object pointer in .data field.
Call appropriate method in callback.

I'm closing this out because it's basically about C++ trivia, not something that is specific to http_parser.

Just wanted to say thanks for the commen


mini-fy file

A script which, given a file path, will find the file and minify it (remove all spaces). Should include options to have the changes themselves persist in a new file, rather than the original file.

Implemented this.


Convert feet to centimeters

Description
1 foot = 30.48 centimeters
Input  : 5
Output : 152.4

Program added successfully :tada:
Thanks for your contribution :hugs:


DEP: removed old-style Composable app classes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
22 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.08%) to 91.407%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-8/lib/python3.8/site-packages/cogent3/app/composable.py
22
92.65%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
178141

Relevant Lines:
194888

💛  - Coveralls


Remove "RUN go get" from DockerFile in Go-Postgres container

Changes in reference to bug AzDO 23066
Result of spike-task: using go mod commands was straightforward to create go.mod and go.sum files that enable go run commands to correctly download and use dependencies + references.
Impact: we de-coupled the go-module(s) "dependency declaration" from the image itself, which is consistent with other containers (i.e. see python containers using environment.yml in DockerFile)
Estimate for fix: a local PR is ready, so mainly review time & confirming approach w/ Chuck

Closed this PR as this branch was merged into microsoft-main repo


Add recursive_generator coroutine type

Add a new recursive_generator<T> type that allows for efficient enumeration over a sequence that is defined recursively.
This type would allow you to pass either a T or a recursive_generator<T> to the co_yield expression.
The increment operator on the iterator would then directly resume the leaf-most coroutine rather than the having to resume each coroutine in the stack until the leaf is resumed and then later suspend every coroutine on the stack for each item.
eg.
generator<directory_entry> list_directory(std::string path);

recursive_generator<directory_entry> recursive_list_directory(std::string path)
{
  for (auto& entry : list_directory(path))
  {
    co_yield entry;
    if (entry.is_directory())
    {
      co_yield recursive_list_directory(entry.path());
    }
  }
}

void usage()
{
  for (auto& entry : recursive_list_directory("foo/bar"))
  {
    std::cout << entry.path() << "\n";
  }
}

The iteration should be cancellable at any point by simply destructing the owning recursive_generator<T> object. This should in turn destruct all nested coroutine frames recursively as the automatic variables within each coroutine fame, which should include the recursive_generator for the nested sequence, are destructed as the coroutine is destroyed.

Commit 6247291b860ea9390437f2106b5aea5773aceec1 added an initial version of recursive_generator.


[SPARK-24817][Core] Implement BarrierTaskContext.barrier()

What changes were proposed in this pull request?
Implement BarrierTaskContext.barrier(), to support global sync between all the tasks in a barrier stage.
The function set a global barrier and waits until all tasks in this stage hit this barrier. Similar to MPI_Barrier function in MPI, the barrier() function call blocks until all tasks in the same stage have reached this routine. The global sync shall finish immediately once all tasks in the same barrier stage reaches the same barrier.
This PR implements BarrierTaskContext.barrier() based on netty-based RPC client, introduces new BarrierCoordinator and new BarrierCoordinatorMessage, and new config to handle timeout issue.
How was this patch tested?
Add BarrierTaskContextSuite to test BarrierTaskContext.barrier()

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1420/
Test PASSed.

Test build #93685 has started for PR 21898 at commit de517f5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1433/
Test PASSed.

Test build #93706 has started for PR 21898 at commit 5c5db85.

Test build #93706 has finished for PR 21898 at commit 5c5db85.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93706/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1449/
Test PASSed.

Test build #93730 has started for PR 21898 at commit 5c5db85.

Test build #93730 has finished for PR 21898 at commit 5c5db85.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93730/
Test FAILed.

Test build #93737 has started for PR 21898 at commit 01c274b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1453/
Test PASSed.

Test build #93738 has started for PR 21898 at commit 766381d.

Test build #93738 has finished for PR 21898 at commit 766381d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #93737 has finished for PR 21898 at commit 01c274b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93738/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #93742 has started for PR 21898 at commit 766381d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1456/
Test PASSed.

Test build #93743 has started for PR 21898 at commit 766381d.

Test build #93742 has finished for PR 21898 at commit 766381d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93742/
Test FAILed.

Test build #93743 has finished for PR 21898 at commit 766381d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93743/
Test FAILed.

Test build #93748 has finished for PR 21898 at commit 766381d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93748/
Test PASSed.

Test build #93785 has started for PR 21898 at commit cb1861d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1487/
Test PASSed.

cc @mengxr @cloud-fan @rxin

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1570/
Test PASSed.

Test build #93890 has started for PR 21898 at commit 94d3671.

Test build #93890 has finished for PR 21898 at commit 94d3671.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93890/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #93911 has finished for PR 21898 at commit 94d3671.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93911/
Test PASSed.

Test build #94005 has started for PR 21898 at commit 5d3deef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1687/
Test PASSed.

Test build #94040 has started for PR 21898 at commit 77d082b.

Test build #94040 has finished for PR 21898 at commit 77d082b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94040/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1718/
Test PASSed.

Test build #94081 has started for PR 21898 at commit 33d4827.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1719/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94083 has started for PR 21898 at commit 2f23e44.

Test build #94083 has finished for PR 21898 at commit 2f23e44.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94083/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1727/
Test PASSed.

Test build #94092 has started for PR 21898 at commit 67dcf17.

Test build #94081 has finished for PR 21898 at commit 33d4827.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94081/
Test PASSed.

Here is what I mean:
case class ContextBarrierId(stageId: Int, stageAttemptId: Int)

class ContextBarrierState(val numTasks: Int) {
  private var epoch: Int = 0
  private val requesters: ArrayBuffer[RpcCallContext] = ...
  private val timerTask: TimerTask = new TimerTask {
    ...
  }

  def handleRequest(requester: RpcCallContext, barrierEpoch: Int): Unit = synchronized {
    // start timer if this is the first
    // throw exception
    // always check if requests = numTasks and if yes reply all, clean requesters, and increment counter
  }

  private def startTimer(): Unit

  def clear(): Unit = synchronized {
    // set epoch to -1
   // clear requesters
    // cancel timer if active
  }
}

val states = new ConcurrentHashMap[ContextBarrierId, ContextBarrierState]

...

case RequestToSync( .... ) =>
  val id = ContextBarrierId(...)
  states.putIfAbsent(id, new ContextBarrierState(numTasks))
  val state = states.get(id)
  state.handleRequest(context, barrierEpoch)

...

def onStop() {
  states.forEachValue(_.clear())
  states.clear()
}

...

Also, if there shouldn't exist two active attempts at the same time for a barrier stage, maybe we should store attemptId as a state variable. Basically, if we see a new attempt ID, we should abort the old attempts.

Also, if there shouldn't exist two active attempts at the same time for a barrier stage, maybe we should store attemptId as a state variable. Basically, if we see a new attempt ID, we should abort the old attempts.

Actually I'm not sure whether we can guarantee that, since kill tasks may take some time, it's always possible that a new stage attempt is launched, and then a zombie task that haven't been killed send a barrier sync message.

Test build #94092 has finished for PR 21898 at commit 67dcf17.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94092/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1759/
Test PASSed.

Test build #94137 has started for PR 21898 at commit e29e3b6.

Test build #94139 has started for PR 21898 at commit 33a8926.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1760/
Test PASSed.

Btw, after refactor, we could actual unit test ContextBarrierState with a mocked RpcCallContext. Not needed in this PR, but it would be nice to create a follow-up JIRA for 3.0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1766/
Test PASSed.

Test build #94158 has started for PR 21898 at commit 16ee90e.

@mengxr I opened https://issues.apache.org/jira/browse/SPARK-25017 to track the test suite for ContextBarrierState.

Test build #94137 has finished for PR 21898 at commit e29e3b6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94137/
Test FAILed.

Merged build finished. Test FAILed.

Test build #94139 has finished for PR 21898 at commit 33a8926.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94139/
Test FAILed.

test this please

Test build #94175 has started for PR 21898 at commit 16ee90e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1775/
Test PASSed.

Test build #94158 has finished for PR 21898 at commit 16ee90e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94158/
Test FAILed.

Merged build finished. Test FAILed.

LGTM pending Jenkins

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1781/
Test PASSed.

Test build #94183 has started for PR 21898 at commit 16ee90e.

Test build #94175 has finished for PR 21898 at commit 16ee90e.

This patch fails from timeout after a configured wait of `300m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94175/
Test FAILed.

Test build #94183 has finished for PR 21898 at commit 16ee90e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94183/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1787/
Test PASSed.

Test build #94193 has started for PR 21898 at commit 16ee90e.

Test build #94193 has finished for PR 21898 at commit 16ee90e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94193/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1799/
Test PASSed.

Test build #94209 has finished for PR 21898 at commit 16ee90e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94209/
Test FAILed.

Merged build finished. Test FAILed.

I don't know why the SparkSubmitSuite keeps failing, they are definitely not related to the changes, and I tested them in a local environment and the tests are happy.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1803/
Test PASSed.

Test build #94214 has started for PR 21898 at commit 53aa316.

Test build #94214 has finished for PR 21898 at commit 53aa316.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94214/
Test FAILed.

Merged build finished. Test FAILed.

It might be caused by jenkins workload. The barrier test also failed due to timeout: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94214/testReport/org.apache.spark.scheduler/BarrierTaskContextSuite/throw_exception_if_barrier___call_doesn_t_happen_on_every_task/. This means we should increase the timeout in our test to handle heavy workload scenarios.

test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1809/
Test PASSed.

Test build #94225 has started for PR 21898 at commit 53aa316.

Test build #94225 has finished for PR 21898 at commit 53aa316.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94225/
Test FAILed.

@jiangxb1987 Seems the SparkSubmit tests are failing deterministically. Usually this is caused by previous tests not cleaning up states/context. I saw many messages in the jenkins log after the barrier suite:
15:57:43.771 ERROR org.apache.spark.rpc.netty.Inbox: Ignoring error
java.lang.IllegalStateException: LiveListenerBus is stopped.
	at org.apache.spark.scheduler.LiveListenerBus.addToQueue(LiveListenerBus.scala:97)
	at org.apache.spark.scheduler.LiveListenerBus.addToStatusQueue(LiveListenerBus.scala:80)
	at org.apache.spark.BarrierCoordinator.onStart(BarrierCoordinator.scala:68)
	at org.apache.spark.rpc.netty.Inbox$$anonfun$process$1.apply$mcV$sp(Inbox.scala:122)
	at org.apache.spark.rpc.netty.Inbox.safelyCall(Inbox.scala:205)
	at org.apache.spark.rpc.netty.Inbox.process(Inbox.scala:101)
	at org.apache.spark.rpc.netty.Dispatcher$MessageLoop.run(Dispatcher.scala:221)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

You should take a look at them.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1818/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94236 has started for PR 21898 at commit da52db2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1819/
Test PASSed.

Test build #94237 has started for PR 21898 at commit 8e888b5.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94236/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1820/
Test PASSed.

Test build #94241 has started for PR 21898 at commit a8fa8db.

Test build #94237 has finished for PR 21898 at commit 8e888b5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94237/
Test FAILed.

Merged build finished. Test FAILed.

    if (barrierCoordinator != null) {       barrierCoordinator.stop()     }
Seems the above statement caused test cases in SparkSubmitSuite timeout, though they actually take very little time to run - I'm still investigating into this.

Test build #94247 has started for PR 21898 at commit ab49fed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1822/
Test PASSed.

Test build #94247 has finished for PR 21898 at commit ab49fed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94247/
Test PASSed.

Looks good to finish without failure.
I am curious why 94247 is successful while 94241 was failed with the same set of test suites since they are tested using the same source revision.

why 94247 is successful while 94241 was failed with the same set of test suites since they are tested using the same source revision.

They are not - I made the variable timer lazy for 94247.

I see. got it, thanks

ok to test

retest this please

LGTM, pending jenkins

Test build #94286 has started for PR 21898 at commit 027ca71.

Test build #94277 has started for PR 21898 at commit 027ca71.

Test build #94275 has started for PR 21898 at commit 1f71e65.

Test build #94279 has started for PR 21898 at commit 027ca71.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1840/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1846/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1847/
Test PASSed.

Test build #94279 has finished for PR 21898 at commit 027ca71.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94279/
Test FAILed.

Test build #94286 has finished for PR 21898 at commit 027ca71.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94286/
Test FAILed.

Test build #94277 has finished for PR 21898 at commit 027ca71.

This patch fails from timeout after a configured wait of `300m`.
This patch merges cleanly.
This patch adds no public classes.

Test build #94275 has finished for PR 21898 at commit 1f71e65.

This patch fails from timeout after a configured wait of `300m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94275/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94277/
Test FAILed.

test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1873/
Test PASSed.

Test build #94318 has started for PR 21898 at commit 1f71e65.

test this please

Test build #94326 has started for PR 21898 at commit 1f71e65.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1878/
Test PASSed.

Test build #94318 has finished for PR 21898 at commit 1f71e65.

This patch fails from timeout after a configured wait of `300m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94318/
Test FAILed.

retest this please

is there a way to increase the build timeout? cc @shaneknapp

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1883/
Test PASSed.

Test build #94333 has started for PR 21898 at commit 1f71e65.

Test build #94326 has finished for PR 21898 at commit 1f71e65.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94326/
Test FAILed.

retest this please

Test build #94341 has started for PR 21898 at commit 1f71e65.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1889/
Test PASSed.

test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1891/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94344 has started for PR 21898 at commit 1f71e65.

@rxin, here we seems indeed starting to hit the time limit now.

Test build #94333 has finished for PR 21898 at commit 1f71e65.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94333/
Test PASSed.

great, finally tests pass! thanks, merging to master!

Test build #94344 has finished for PR 21898 at commit 1f71e65.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #94341 has finished for PR 21898 at commit 1f71e65.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94344/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94341/
Test FAILed.