Recursive references count is wrong

VSCode Version: Version 1.11.0-insider (1.11.0-insider), e1d2e7b41c22acf9c3f63123842d5231bfbc2fae
OS Version: macOS Sierra 10.12.4 Beta (16E192b)

Steps to Reproduce:

Create a recursive function in TypeScript (possibly other languages as well)
don't reference it elsewhere int he code
Look for number of references of that func
Above function says 4 references, in a popup windows says 2 references

Can you please share a code example. I couldn't repo this with a simple case:
class Foo {
    public static x(param: number) {
        Foo.x(1)
    }
}

Also, to help us investigate, please:

Set "typescript.tsserver.trace": "verbose", in your user settings
Restart VSCode and load the offending file
Open the output pane and share the output from TypeScript

Thanks

this is the offending file https://github.com/venil7/chess/blob/master/src/game.ts#L32

@venil7 I still can't repo this using that file. Can you please try collecting the trace as described

Closing as not reproducible / need more info
@venil7 I've cloned the entire repo but still don't see the error you describe. Please try collecting a trace so that we can investigate further


broken code in request.go

I'm getting an error when I try to get this library.
$ go get github.com/qasaur/gremgo
# github.com/qasaur/gremgo
../../go/src/github.com/qasaur/gremgo/request.go:31:17: multiple-value uuid.NewV4() in single-value context

Looks like request.go is not using the uuid library correctly.  Here's the current code:
func prepareRequest(query string, bindings, rebindings map[string]string) (req request, id string) {
	id = uuid.NewV4().String()

	req.Requestid = id
	req.Op = "eval"
	req.Processor = ""

	req.Args = make(map[string]interface{})
	req.Args["language"] = "gremlin-groovy"
	req.Args["gremlin"] = query
	req.Args["bindings"] = bindings
	req.Args["rebindings"] = rebindings

	return
}

The problem is that uuid.NewV4() returns a (UUID, error) (https://godoc.org/github.com/satori/go.uuid#NewV4) but the calling code expects a single value and we are not doing anything the the error value.

Closing this as it has been fixed in #22.


Design proper test for the ComputeVolume functionality

As far as the ComputeVolume functionality is extremly bounded to the face identification and edges identification algorithm, it is not so straight forward to implement a proper set of unit test (as has been done for the ComputeArea functionality for the Faces3D). We should find and alternative way.

done for Tetraand Hexa in https://github.com/albiremo/dualGPy/pull/21


extend Menu Items

Version information

Laravel: v5.6.35
Voyager: v1.1
PHP: 7.2
Database: MySQL 8.0

I am trying to extend the menu items table by adding a publish flag.  So in the menu_items table i have added a new field "publish" int. Now what i would like to do is add a checkbox for publish/unpublish the item. How can this be done?
I dont want to simply delete the item but unpublish it instead.
thanks
Nabi

I'm not sure I understand the reasoning behind this.  You could just user permissions to choose whether to allow a menu item to appear or not.

@fletch3555 i don't want a menu item to appear on the front end. Sure i can delete that particular item but i would rather unpublish it or hide it.
see attached image

Ah, I see, it's for your front-end.  I had assumed you were talking about the Voyager sidebar menu.
You would have to configure the view that renders the menu to choose whether to display it or not.  You'd also have to override Voyager's MenuItem edit-add view(and possibly controller) to add in the field.  Honestly, this is sounding like a lot of customization/overrides.  I would love to have it bundled into the package though.  Would you be willing to modify Voyager and submit a pull request to add a "is published"/"active"/etc field (I'll leave it up to you to decide what to call it)?

ive tried doing this but i cannot get access to the menu_item table in the Database. (TOOLS > DATABASE). If i can get access to this then we can easily add the checkbox field.
Ive added the field manually via Sequel Pro. But this is of no use as its not viewable in admin panel.

Yes, exactly.  That's what I'm saying.  This has nothing to do with the database editor within Voyager, and I wouldn't recommend using that for this change.  You will need to override the Voyager view for the Menu editor in order to add that field, and may need to override the Menu controller as well so it handles it properly.  That's a lot of work for this, which is why I suggested doing it directly to the Voyager source and submitting a pull request.  If you're not comfortable doing that, then I'll open it up for someone else to pick up.

i'll have a look at doing this and let you know if it works.

Closing this for now.  If you need further help, please let me know.


The scheme of DDEV_PRIMARY_URL can't be controlled

My problem is that ddev drush uli always returns an http URL. Chasing back, I believe the value of DRUSH_OPTIONS_URI is set from DDEV_PRIMARY_URL. I can't find any way to control whether DDEV_PRIMARY_URL is http/https in config.yaml
I suggest adding param(s) to give more control over DDEV_PRIMARY_URL.
If this is already possible and I've mislabelled a support request, I apologise. (ddev version v1.17.6, Drush Commandline Tool 10.3.4, Drupal 8.9.16).

If ddev drush uli returns an http URL it's probably because you don't have https set up?
What does ddev list show you? https or http URL? If it's http, then run mkcert -install and then ddev poweroff && ddev start

If ddev drush uli returns an http URL it's probably because you don't have https set up?

Thanks for the reply. That's correct. I want to be able to preference https, without installing mkcert, because I can't control whether other devs on the team install it. ddev list shows:
NAME                 TYPE     LOCATION                                             URL                             STATUS
site-name        drupal8  ~/PhpstormProjects/site-name              http://site-name.ddev.site  running

Everybody should run mkcert -install or they'll be stuck with untrusted https forever. And ddev whines at you all the time! I sure recommend that you get everybody to do that.
Anyway, $DDEV_PRIMARY_URL in your case is in fact http:// - because you haven't properly set things up.
If you really, really have to run using http, I imagine you can change DRUSH_OPTIONS_URI to http://<project>.ddev.site with web_environment in .ddev/config.yaml.

Actually, you may be able to change $DDEV_PRIMARY_URL that way too. But please don't. Please get your people to run mkcert -install. It's a one-time command.

Thanks for suggesting a workaround. I'm going to close the issue.


[Service] Include Container Apps analysis

@Alvaromg45 please complete: src/azqr/Resources/Microsoft.App.managedEnvironments.md


x/playground: upgrade to 1.12

What version of Go are you using (go version)?

$ go version
go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?
Yes.

I run godoc -play that distributed with go 1.12 then open http://localhost:6060/pkg/strings/#ReplaceAll and run example.

What did you expect to see?
moo moo moo
What did you see instead?
prog.go:9:14: undefined: strings.ReplaceAll

The root cause because godoc sending example code to compile at https://play.golang.org/compile that still use v1.11.1.

/cc @dmitshur

Indeed, the playground is still on Go 1.11.1, as https://play.golang.org/p/Ztyu2FJaajl reports.
I'll redeploy it with Go 1.12 now.

I'v checked https://play.golang.org/p/Ztyu2FJaajl it 1.12 now thanks.


Roslyn analyzers + code fixes don't work properly in VS when installed into .NET Core project via a nuget package

(I can't seem to find a repo for raising VS .NET Core tooling issues, so if there's a more appropriate place for this, please tell and I'll be glad to repost it there.)
Here's what happens when a nuget package that contains Roslyn analyzers + code fixes is installed into a .NET Core project via install-package $(AnalyzerPackage):

Analyzer package is added to References > .NETStandard node of Solution Explorer instead of References > Analyzers.
Which also means there's no UI for changing rule severity.
Analyzers are not invoked when the code is being edited. The warnings are reported only when the project is built.
Even then no squiggles are displayed at the warning location, the warnings are only surfaced in the error list.
And probably the most tragic part: the code fixes attached to the analyzer warnings simply can't be triggered.

@sayedihashimi where is the best place to file VS-related issues of this kind?

@blackdwarf let's start with https://github.com/dotnet/roslyn-project-system/issues the team can move it if that's not the right spot.

Thanks @sayedihashimi. @HellBrick can you please move this issue to the above mentioned repo and close this one? Thanks!

@blackdwarf I went ahead and created https://github.com/dotnet/roslyn-project-system/issues/285 to replace this. Going forward please create the issue yourself  (or ask the OP to do so) with the following info.

URL to original issue
Github ID of the OP


Wire context properly to all resource apply helpers

This replaces context.TODO() in resource helpers with context argument which is properly wired from the controller. Every sync() function from the controller factory has a context parameter that is wired to controller context and it is properly closed when the controller is asked to gracefully shut down.

/lgtm


Let external applications attach metadata

An application interacting with Lessy thought its API, may want to attach a note to a task (which is not possible with Lessy). This feature would ask a lot of considerations.
Feature asked by @bnjbvr

Thanks for opening an issue about it!
To expand upon my idea: I think the simplest thing would be the ability to store {0..N} link attachments to a todo (or even better to any entity, including projects). Then, Lessy can keep on doing what it does best (i.e. to handle todos), while another app specialized on other information management can do what it does best and still allow interactions with Lessy data (i.e. attach a Note to a TODO, but we can imagine many more: attach a location in an OSM like app, or an image or video or really anything).
So the simplest implementation of this feature would consist in:

adding a model for attachments, with the relation "a todo can have 0..N attachments". An attachment can be as simple as: a link title, a link href and maybe a link icon among a predefined set (fontawesome or whatever you use/provide).
in the UI, every time a todo has an attachment, show the icon that just opens the link in a new browser tab.

Any thought about this?

Your idea seems very easy to implement… a lot more than what I thought first! :) I'm still not sure of the interest compared to just add a link in the task's label but why not.
However, if we show attachments in the UI, the user will want to add them too. So we have to consider to offer user the possibility to add attachments within Lessy itself.


release: Publish a GitHub release for the latest version compatible version with a v0.19 Nibiru Chain

[ ] Add a scripts/localnet.sh to the repo that runs on nibiru v0.19
[ ] Add a scripts/pricefeeder.sh to the repo that runs on nibiru v0.19
[ ] test: make the test suite easy to run from a script locally
[ ] Publish GitHub release

Related:

https://github.com/NibiruChain/py-sdk/pull/234
https://github.com/NibiruChain/py-sdk/releases/tag/v0.19.8

No longer needed


Update operator sdk

updates operator-sdk to v0.15.3, the current latest release.

Closing for now since it's pretty old and has conflicts.


Added python-dev as a pre-req for Linux-quickstart

While setting up a local instance using the Linux quickstart page, the python-dev dependency is missing from the list of pre-requisites which is needed. This PR adds the python-dev dependency to the documentation.

Thanks @saki-osive. I don't recall needing this package the last time I ran through the quick start, but it might be a new dependency. Hopefully @bcipriano can confirm.

Thanks @saki-osive. I don't recall needing this package the last time I ran through the quick start, but it might be a new dependency. Hopefully @bcipriano can confirm.

Hi, thanks for your reply, can you recall for which version of Python was it for, as for many version I have tried it on, required this dependency?

Hi, thanks for your reply, can you recall for which version of Python was it for, as for many version I have tried it on, required this dependency?

I'm a bit confused here -- the link given for python-dev seems to point to the PyPi page for the Flask library? I can't really think of why we would need Flask for this process. I could be wrong.
Are you sure you don't mean we need the python-dev package? I.e. apt get install python-dev (on Ubuntu/Debian) or yum install python-devel (on e.g. CentOS).

I'm a bit confused here -- the link given for python-dev seems to point to the PyPi page for the Flask library? I can't really think of why we would need Flask for this process. I could be wrong.
Are you sure you don't mean we need the python-dev package? I.e. apt get install python-dev (on Ubuntu/Debian) or yum install python-devel (on e.g. CentOS).

Hi, I exactly mean the python-dev dependency and not the Flask library. As you have correctly pointed out, the link I added was misleading, therefore I have removed it. Please verify this now.

Hi, I exactly mean the python-dev dependency and not the Flask library. As you have correctly pointed out, the link I added was misleading, therefore I have removed it. Please verify this now.

@bcipriano @sharifsalah Please verify the latest commit. Thanks.

@bcipriano @sharifsalah Please verify the latest commit. Thanks.

Thanks, I have reformatted the bullet points, please verify.

Thanks, I have reformatted the bullet points, please verify.


bpf: lxc: transfer sec identity for per-EP loopback in reply direction

l3_local_delivery() contains a special case to bypass ingress policy for loopback traffic. But when redirecting loopback requests / replies in a per-EP config, they don't actually bypass the policy program. The redirect_ep() delivers them to the host-side veth interface, and ingress policy is applied as the packet passes to the pod-side veth peer.
https://github.com/cilium/cilium/pull/27602 recently changed the logic so that hairpin_flow is only set for replies. A subtle side-effect of that change is that in a per-EP config, l3_local_delivery() will now copy the the src sec identity into the skb->mark. cil_to_container() then extracts it, and tail_ipv4_to_endpoint() no longer performs a ipcache lookup for ip4->saddr (which is IPV4_LOOPBACK, and would result in WORLD_ID).
Right now this is mostly a cosmetic improvement, as the identity is not used for policy enforcement of loopback traffic. But there are still users (eg. drop notifications) in tail_ipv4_to_endpoint() that benefit from having the correct security identity in place.
Therefore make the same change in reply direction, so that we also get the correct security identity there (instead of an ipcache lookup for the Service IP, which would return WORLD_ID). For this push the loopback check into the tail-call specific path of l3_local_delivery(), while the per-EP path inserts the identity into skb->mark and then just calls its "normal" redirect_ep().
Reported-by: Timo Beckers<EMAIL_ADDRESS>

/test

I don't see any good reason to pass the identity if the goal is to just bypass ingress policy for loopback traffic anyway.

As described, there's other users of the security identity in the to-container code. And pushing the loopback handling in l3_local_delivery() down a bit further seems like a nice win in itself. Maybe one day it's gone completely :shrug:.

The loopback snat ip has a special meaning. So if we were to assign a special identity, and use that to skip the additional conntrack lookups in the per ep policy enforcement BPF program, it would make sense to pass the correct identity. (I don't remember when the reverse snat happens though).

As mentioned in the patch description, at this point we're dealing with ip4->saddr = Service_IP.

There are couple of considerations to this approach though: do we plumb a special ipcache entry via userspace, or keep it all in the datapath since packet context carries the identity thereby skipping ipcache lookups? Any thoughts?

There's nothing special about passing the "actual" identity via metadata, even when it doesn't match the current packet content. I don't think we suddenly need to start populating the ipcache for these kind of cases.

As mentioned in the patch description, at this point we're dealing with ip4->saddr = Service_IP.

Sorry, I missed that.


wip: add implementation working for predicate deployment

Summary
@luizstacio being a boss - as per usual.
Checklist

[ ] All changes are covered by tests (or not applicable)
[ ] All changes are documented (or not applicable)
[ ] I reviewed the entire PR myself (preferably, on GH UI)
[ ] I described all Breaking Changes (or there's none)

I am working on this now btw

Thanks @luizstacio - we've now merged this into #3251


Bookies at 100% CPU

We're experiencing apparently the same issue that we reported at #110
We having most of our bookies hang at 100% CPU while reading from rocksdb, but our disk metrics show little to no reads on the disks which is strange.
We're running pulsar 1.20 and bookkeeper version <IP_ADDRESS>-yahoo.
Here is a jstack from a bookie:
jstack.txt
Our bookkeeper config is the following:
bk.conf.txt
This is currently affecting one of our production clusters and don't really know how to mitigate it.
@merlimat @sijie do any of you know how to mitigate or fix this, this is of course an issue with the rocksdb storage of bookkeeper.
I found this issue on rocksdb which talks about poor iterato4 performance when iterating through lots of tombstoned items, seems like this could be the case, or at least it expresses the same simptoms. We tried rebuilding the rocksdb index iusing bookkeeper cli and that seemed to work ok, maybe because that rebuilding made a clean index without tombstones?
Do you think this is the case? How could we mitigate this? In the issue they talk about caching the element just after the last deleted.

@sschepens I think to remember that there was some fix between Rocksdb-5.5.5 and 5.8 to handle these cases, though I haven't found the PR/commit yet.

I found this issue on rocksdb which talks about poor iterato4 performance when iterating through lots of tombstoned items, seems like this could be the case, or at least it expresses the same simptoms.

There shouldn't be many tombstones in this case, since we're doing a DeleteRange() from (ledgerid, 0) to (ledgerId+1, 0). The delete range drops the range in a single shot, but it has additional logic and in rocksdb-5.5 there were some of these issues.
I would suggest to either upgrade bookies, or at least upgrade the rocksdbjni.jar to 5.8.6 or newer.

We tried rebuilding the rocksdb index iusing bookkeeper cli and that seemed to work ok, maybe because that rebuilding made a clean index without tombstones?

Correct, rebuilding the index scans the entry logs and reconstruct a new index from scratch, so it would not have the baggage of the old index.

@merlimat I would like to upgrade bookkeeper straight to official Apache 4.7, are these versions compatible with the Yahoo version of bookkeeper and with pulsar 1.20?

Yes @sschepens , the bookies on 4.7 are perfectly compatible with the bookkeper client from yahoo branch, which based on 4.3 release. Some care would only be required if authentication (broker->bookie) was enabled, but I don't think that's relevant for anyone except Yahoo (since there are not even auth plugin implementation available fro 4.3 in OSS).

@merlimat, We saw that the size of the folder /data/ledgers/current/locations was 25 GB before and 3 GB after rebuilding the index. Do you know if there is any setting that could prevent this growing? Or updating bookies and rocksdb is the only fix?
Beyond that, do you think that 3 GB for a clean index is ok? Our bookies currently have 4 GB for blockCacheSize.
Thanks!

@merlimat could you help us with this please?
We're seeing the the locations folder tends to grow a lot and after rebuilding the index, the size drops a lot. Could it be that rocksdb is not deleting the data? Or that it's not compacting frequently?
Is there any settings to tweak this?

I think the 100% cpu usage is related to deleteRange. the change is merged to bk 4.7.2 and will be included in pulsar 2.1.1 and 2.2.0 releases.


Mat-compatible inputs are not being initialized from the template

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Non-compatible "md-mode":
<md-table mdSort
          mdSortStart="desc"
          mdSortDirection="desc"
          mdSortActive="progress" ...>

sort.active: {{sort.active || '???'}}

sort.start: {{sort.start || '???'}}

sort.direction: {{sort.direction || '???'}}

Values of inputs matSortActive, matSortDirection, and matSortStart are to be propagated to the injectable MdSort instance.
What is the current behavior?
Compatible "mat-mode":
<mat-table matSort
           matSortStart="desc"
           matSortDirection="desc"
           matSortActive="progress" ...>

sort.active: {{sort.active || '???'}}

sort.start: {{sort.start || '???'}}

sort.direction: {{sort.direction || '???'}}

These values are not being initialized by the template.
What are the steps to reproduce?
Plunker template: updated demo

First, notice that in "md-mode" (i.e., non-compatible) values are being initially set from the template.
Then, turn on the "mat-mode" (i.e., compatible) by uncommenting the NoConflictStyleCompatibilityMode and the switching to the <mat-table... template, and see that values aren't set.

What is the use-case or motivation for changing an existing behavior?
It seems that making sort inputs mat-compatible didn't affect the initialization process.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 1.6.4, Material 2.0.0, TypeScript 2.3.4

Dupe of #6067

Not really a dupe of #6067, but according to the merged fixes it is not going to be an issue anymore.


Folder at / app root instead /app/views

I am trying to use high_voltage to serve my app yard generated docs.
But:

it seems the only folder we can use is inside /app/views/ , I am trying to use it to access /doc folder
Is it possible to do?

it seems that we can only return text/html mime type, and since doc has its own css and js on the same folder, these files are not loaded correctly. Is it possible to change mime type?

Do you have some suggestion about?
PS: I cannot serve it on /public because I must have an authentication on it.

Since HighVoltage requires the rails stack I do not believe that you would be able to access pages within /doc instead.

it seems that we can only return text/html mime type, and since doc has its own css and js on the same folder, these files are not loaded correctly. Is it possible to change mime type?

HighVoltage is designed for static pages and serving file types like CSS and javascript is out of scope for HighVoltage.


Better symlinking

@jrafanie @bdunne Please review.
This is also needed because I found I needed to symlink something new for the self service UI and I couldn't perpetuate it any longer in the other repo.
cc @simaishi @jPrause

See also https://github.com/ManageIQ/manageiq-appliance-build/pull/58

Keep in mind, the reason it wasn't pulled out was the same code would have to work in rpm as an invoked script and in the upstream kickstart.  I like changing it but it requires some manual testing.

we can figure that out in downstream after we've sorted this out...or perhaps @simaishi can help me.  I don't think that precludes merging this

Only thing I wasn't sure about was the name of the script: enable.  This is more of a one-time thing, so enable might not be the right choice.

Creating these links doesn't seem to be simplifying anything. Especially since this is in a different git repo than the files in that directory. Too hard to sync across repos.
I still feel creating a simple copy_all_files.sh into our git directory may be out best bet. If someone has trouble they can either get a new nightly appliance or run the script.
Separate but similar conversation, it may be easier to just copy these files instead of linking them.

@kbrock I'm confused by your statement.  This PR is doing exactly what you are asking for.  The files live in this repo, so I created a file here that does all the linking and copying, and removed it from the other repo.  I just named it enable, which is admittedly a bad name.
We can debate the copy vs link choice separately.  I don't think a PR that refactors and simplifies the process should be concerned with completely redoing the process.

I don't have as much of a problem with the name "enable", maybe "setup" or "configure" would be better.

Ok cool...I'll go with setup.

@bdunne dunne :stuck_out_tongue:

:+1: LGTM, let's merge


[Scrollbar on Darkmode] Auto show on v5

I am using the latest version of v5 for my project.
But on chrome & Darkmode
browser scroll alway show (even when I use attributes overflow:'auto'  or overflow:scroll ). I have not this problem on the v4 version,
Let me know if this is a feature or a bug and how to fix it, Thanks!
P/s: v5 ,Scrollbar, Chrome browser , Darkmode

Duplicate of #23520


background prelaunchTask blocks launch

Issue Type: Bug
I have a background task defined like this:
{
            "label": "python dev server",
            "type": "shell",
            "command": "python3 dev_server.py",
            "isBackground": true,
            "problemMatcher": {
                "pattern": {
                    "regexp": ""
                },
                "background": {
                    "activeOnStart": true,
                    "beginsPattern": "",
                    "endsPattern": "serving at"
                }
            },
        },

and a launch config:
{
            "name": "Debug in Chrome ",
            "type": "chrome",
            "request": "launch",
            "preLaunchTask": "python dev server",
            "url": "http://localhost:8000",
            "webRoot": "${workspaceFolder}",
            "userDataDir": false,
            "disableNetworkCache": false,
        },

In the previous VSCode version, the browser and debugger were started immediately when the background process printed "serving at localhost:"
In the current version the browser and debugger never starts. I think this is a regression.

VS Code version: Code 1.62.0 (b3318bc0524af3d74034b8bb8a64df0ccf35549a, 2021-11-03T15:24:41.297Z)
OS version: Darwin x64 21.1.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
6, 10, 7

Memory (System)
16.00GB (1.50GB free)

Process Argv
--crash-reporter-id 6c0f1725-6e9b-4c9e-9036-6687233bbc25

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
vsccppwtct:30382698
bridge0708:30335490
pygetstartedt3:30385195
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsqsis300:30386381
vsaa593:30376534
vssld246cf:30386378

@alexr00 are you aware of any changes in task land that could explain this?

None that I'm aware of, and the background prelaunch task + launch configs for the extension samples are still working.
@mmarczell-graphisoft can you share a minimal dev_server.py that can be used with your tasks and launch config to reproduce this issue?

You can even use the builtin one in Python and still reproduce:
{
            "label": "python dev server",
            "type": "shell",
            "command": "python3 -m http.server 8000",
            "isBackground": true,
            "problemMatcher": {
                "pattern": {
                    "regexp": ""
                },
                "background": {
                    "activeOnStart": true,
                    "beginsPattern": " ",
                    "endsPattern": "Serving HTTP on"
                }
            },
        },

I'm also getting this strange error message:

I ran into this exact problem today and have no idea how to fix it (other than running tasks manually, which I'd prefer not to do). Looking forward for any workarounds or fixes...

Maybe a duplicate of https://github.com/microsoft/vscode/issues/136585, because in the example the line that we're problem matching against is the first line.

Yep, its a duplicate of https://github.com/microsoft/vscode/issues/136585.


Did not decode any data when next or prev in Info are null

Hey Maxim, could please provide an example call, where you get that error?

[FIXED] with commit https://github.com/benjaminbruch/rick-morty-swift-api/commit/4eaac2da4f57c2a60e3ced8f72897955382999fe


findandbind: pass found entry to callback

Prior versions of findandbind() passed (err, data) to the callback.
This functionality was broken, I believe inadvertently, in commit
a4b9ce6e8eda61d1c86faf20995464d538b20f6c It's still documented in
the README and the callbacks in the unit tests still accept
(err, data). Since it was broken in a minor version bump (3.0->3.1),
it will break existing code that relies on data being passed back
and uses the caret operator to specify dependency versions.
Restore that functionality, by passing the found entry
to the callback supplied to findandbind().

Thanks for the PR! Looks good!


36d94a94-302b-4764-86ec-1eea8dd8a020

this is for automated testing

4457a389-22e5-4dd4-8ee5-fdd3af41aea2


problem to apply theme in PlatformApp

how to make theme with platformwidget or PlatformApp ?

to implement, this should be used: https://api.flutter.dev/flutter/material/ThemeData/cupertinoOverrideTheme.html

As @uuttff8 suggests you can use cupertinoOverrideTheme. If you need to style ios whilt using MaterialApp. According to the docs:
/// To override individual parts of the Material-derived Cupertino styling,
/// `cupertinoOverrideTheme`'s construction parameters can be used.
///
/// To completely decouple the Cupertino styling from Material theme derivation,
/// another [CupertinoTheme] widget can be inserted as a descendant of the
/// Material [Theme]. On a [MaterialApp], this can be done using the `builder`
/// parameter on the constructor.

If you are using PlatformApp you can see as part of the example that the CupertinoApp.theme needs a CupertinoThemeData which can be created specifically for itself.
I m not 100% on the ins and outs of it but the flutter docs are a good place to start


Add log events to Sentinel master resolution

This pull request adds log events to Sentinel Redis master resolution, providing some much needed insight.

Closes https://github.com/sensu/sensu-redis/issues/1

I like helpful logs! 👍


fix: specify namespace in upgrading v3 to v4 doc

namespace must be specified when upgrading from v3 to v4
part of DOC-100
Signed-off-by: Rohan CJ<EMAIL_ADDRESS>

preview link to relevant section: https://deploy-preview-199--vcluster-docs-site.netlify.app/docs/platform/manage/upgrade-platform/#upgrading-from-v3x-to-v40


Large scale performance test

I tested MQTTnet in a large scale environment. 10000 datapoints with 1000 changes per second are distributed to 50 visualisation clients.
Unfortunately in my typical environment the topic hierarchy is quite flat. Every client has to subscribe approx 200 topics to optimize network traffic.
I measured that the performance bottleneck in this case is not the network but the topic matching logic on the server.
Your topic matching implementation uses linear search per client. So every datapoint change requires 50 * 200 topic matchings.
I was able to modify MQTTnet using topic dictionaries to improve topic matching dramatically.
And I took a look to other MQTT broker implementations like MOSQUITTO. They implemented some optimized topic matching using search trees.
I can imagine that most of the MQTTnet applications do not have such requirements.
But when your intention is to implement a scaleable high perf mqtt broker you should also consider to optimize the topic matching algorithm, I think.
It would be great to support injection of other alternative matching algorithms.
What do you think ?

Which version did you use for this? Version 2.8.0 has lots of improvements. One is the rewrite of the topic matching code.

Yes I used latest version.  Optimization of TopicFilterComparer cannot help in this case. Problem is the linear search per client and per subscribed topic.

@chkr1011 Is this something that is still relevant?

I have found an alternative solution

I have found an alternative solution

Can you share with us?
Thank you in advance


netcoreapp2.0 missing methods

Many of the extension methods of the latest release fail to compile in net471/netcoreapp2.0 mode:

paket.lock:
+    Topshelf (<IP_ADDRESS>-develop)
+      Microsoft.Windows.Compatibility (>= 2.0.0-rc1) - restriction: || (&& (== net461) (< net452) (>= netstandard2.0)) (== netcoreapp2.0) (== netstandard2.0)

If these functions don't exist it would be neat to get warnings at runtime but keeping the API the same. Perhaps PRs can solve the missing functionality?

Many of those types do not exist in .NET Core, even with the Windows compatibility package. I'd rather have it fail to compile than answer 1,000,000 questions of why "project.exe install" is not working from the command line on Linux...

Yes indeed. However, it would be possible for Topshelf to shim e.g. the restart/service recovery setting (probably the most important one there)

Well, in a sense yes; what I asked for. But you have a point too, so I don't want to take away too much from that; perhaps log a warning on stderr if using these APIs with noop-behaviour?


rustfmt destroyed code snippets in doc comments

While running rustfmt-nightly on azerupi/mdBook repository. Rustfmt seems to have destroyed code snippets in doc comments which failed the test on: https://github.com/azerupi/mdBook/pull/437.

This is caused by wrap_comments = true, probably. Please try setting it to false and see if it works fine.

Thanks! It did solve my problem.


Build release candidate with Java 11

Following #31677 doing this for release candidate workflow. The binaries still has Java 8 byte code compatibility.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damccorm


Implement fix for MMS Default issue

Pull Request (PR) description
This PR updates the SPManagedMetadataServiceAppDefault resource to allow configuration of a default MMS Service App per Proxy Group. In the old version, it only allowed one default per farm, which is not correct.
This is however a breaking change, so will be merged into the v4.0 branch
This Pull Request (PR) fixes the following issues

Fixes #1136

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1137 into v4.0-development will decrease coverage by <1%.
The diff coverage is 84%.

@@               Coverage Diff                @@
##           v4.0-development   #1137   +/-   ##
================================================
- Coverage                92%     92%   -1%
================================================
  Files                   120     120
  Lines                 13374   13387   +13
================================================
+ Hits                  12405   12415   +10
- Misses                  969     972    +3

@NikCharlebois Up for a review?

Just tested this again: In order to retrieve the default proxy group, you have to use the "-Default" parameter:
PS C:\> Get-SPServiceApplicationProxyGroup

FriendlyName                     Proxies                                                                    DefaultProxies
------------                     -------                                                                    --------------
[default]                        {App Management, MMS, Search Service Application 1, SecureStore}           {App Management, MMS, Search Service Application 1, SecureStore}
32460f5eec41489485099d62d46a2a57 {MMS2}                                                                     {MMS2}
48b8643ea0f145dc82afaf655b3ae4e5 {UPS}                                                                      {UPS}

PS C:\> Get-SPServiceApplicationProxyGroup -Identity "[default]"
Get-SPServiceApplicationProxyGroup : Object not found.
At line:1 char:1
+ Get-SPServiceApplicationProxyGroup -Identity "[default]"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Share...ationProxyGroup:SPCmdletGetServiceApplicationProxyGroup) [Get-SPServiceApplicationProxyGroup], InvalidOperationExce
   ption
    + FullyQualifiedErrorId : Microsoft.SharePoint.PowerShell.SPCmdletGetServiceApplicationProxyGroup

PS C:\> Get-SPServiceApplicationProxyGroup -Identity "default"
Get-SPServiceApplicationProxyGroup : Object not found.
At line:1 char:1
+ Get-SPServiceApplicationProxyGroup -Identity "default"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Microsoft.Share...ationProxyGroup:SPCmdletGetServiceApplicationProxyGroup) [Get-SPServiceApplicationProxyGroup], InvalidOperationExce
   ption
    + FullyQualifiedErrorId : Microsoft.SharePoint.PowerShell.SPCmdletGetServiceApplicationProxyGroup

PS C:\> Get-SPServiceApplicationProxyGroup -Identity "32460f5eec41489485099d62d46a2a57"

FriendlyName                     Proxies                                                                    DefaultProxies
------------                     -------                                                                    --------------
32460f5eec41489485099d62d46a2a57 {MMS2}                                                                     {MMS2}

PS C:\> Get-SPServiceApplicationProxyGroup -Default

FriendlyName                     Proxies                                                                    DefaultProxies
------------                     -------                                                                    --------------
[default]                        {App Management, MMS, Search Service Application 1, SecureStore}           {App Management, MMS, Search Service Application 1, SecureStore}

The Default proxy group does not have a name, check Name property below:
Proxies                     : {App Management, MMS, Search Service Application 1, SecureStore}
DefaultProxies              : {App Management, MMS, Search Service Application 1, SecureStore}
CanUpgrade                  : True
IsBackwardsCompatible       : True
NeedsUpgradeIncludeChildren : False
NeedsUpgrade                : False
UpgradeContext              : Microsoft.SharePoint.Upgrade.SPUpgradeContext
ShouldDeferUpgradeActions   : False
Name                        :
TypeName                    : Microsoft.SharePoint.Administration.SPServiceApplicationProxyGroup
DisplayName                 :
Id                          : 90a782c1-d249-4f8f-8ae6-0b140098f348
Status                      : Online
Parent                      : SPFarm Name=SharePoint_Config
Version                     : 200675
DeploymentLocked            : False
Properties                  : {}
Farm                        : SPFarm Name=SharePoint_Config
UpgradedPersistedProperties : {}
FriendlyName                : [default]


PSUseOutputTypeCorrectly/[OutputType()] fires incorrectly, reporting that a fn should return string when the function actually return array of strings

Before submitting a bug report:

Make sure you are able to repro it on the latest released version
Perform a quick search for existing issues to check if this bug has already been reported

Steps to reproduce

function Split-KeyValuePairFormatter {
  [OutputType('System.String[]')]
  [CmdletBinding()]
  param (
    [Parameter(Mandatory = $true)]
    [string]
    $Format,

    [string]
    $KeyConstituent,

    [string]
    $ValueConstituent,

    [string]
    $KeyPlaceHolder = "<%KEY%>",

    [string]
    $ValuePlaceHolder = "<%VALUE%>"
  )
  [string[]]$constituents = @();

   # IMPLEMENTATION CODE OMITTED, but you can see that the return statement
   # just returns the array declared as string[]

   return $constituents;
}

Expected behavior
No warning expected
Actual behavior
Error:

RuleName                            Severity     ScriptName Line  Message
--------                            --------     ---------- ----  -------
PSUseOutputTypeCorrectly            Information  split-key- 152   The cmdlet 'Split-KeyValuePairFormatter' returns an
                                                 value-pair       object of type 'System.String' but this type is not
                                                 -formatter       declared in the OutputType attribute.
                                                 .ps1

If I change OutputType to: [OutputType('System.String')], which is clearly wrong as it doesn't reflect the behaviour of the actual code, then there is no error. This does not seem right. As a work around, I'm having to declare an incorrect return type, ie System.string in [OutputType()], and put in a comment to indicate as such. Luckily, there is no effect on the functinality, but I can't omit the OutputType without PSScriptAnalyzer reporting a warning.
Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0
PSEdition                      Core
GitCommitId                    7.0.0
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.19.0
1.18.3

@plastikfan Thanks for taking the time to open an issue and provide details.
I can repro except your statement that it doesn't happen when changing the OutputType to [OutputType('System.String')], it happens in that case as well for me.
Variable analysis seems to infer the type from the right hand side of the assignment @(), that's why PSSA thinks it is of type System.Object[]. Variable analysis in PSSA is something that got forked off the PowerShell project a few years ago and we are looking into updating this code for PSSA 2.0, which has the potential of being more clever and could fix this issue as-is.
For your example, you can help PSSA though to recognize the OutputType correctly by adding a cast to the return statement and then it won't complain any more
   return [string[]]$constituents;

P.S. If you want, you can also shorten the type declaration a bit as PowerShell always assumes the System namespace: [OutputType([string[]])]

I'm just learning how to use PSScriptAnalyzer, and I've just discovered I can suppress the message, so now I'm using this:
[OutputType('System.String[]')]
[CmdletBinding()]
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseOutputTypeCorrectly", "")]
So, I've left the OutputType to the correct type, but as you can see I've suppressed the Rule for this function.

@plastikfan I don't think you understood, by changing your function as follows, you can help PSScriptAnalyzer recongize the output type correctly, no need to suppress in this case:
function Split-KeyValuePairFormatter {
  [OutputType('System.String[]')]
  [CmdletBinding()]
  param (
    [Parameter(Mandatory = $true)]
    [string]
    $Format,

    [string]
    $KeyConstituent,

    [string]
    $ValueConstituent,

    [string]
    $KeyPlaceHolder = "<%KEY%>",

    [string]
    $ValuePlaceHolder = "<%VALUE%>"
  )
  [string[]]$constituents = @();

   # IMPLEMENTATION CODE OMITTED, but you can see that the return statement
   # just returns the array declared as string[]

  return [string[]] $constituents;
}

My previous message crossed-over, so I didnt see your response whilst I was writing that one!
I have made that change and that works, apart from defining the type in OutputType('string[]') did not stop the warning from being issued. I have to use [OutputType('System.String[]')], otherwise the warning pops out.
thanks for your assistance.

@plastikfan No, worries, you have to use brackets instead of single quotes around string[], i.e.  [OutputType([string[]])], then it will work.

Thank you @bergmeister :)

Looks like the type inference visitor in PowerShell understands this:
https://github.com/PowerShell/PowerShell/blob/cefbf3d6a972d9f1365c4ce5c5d6285133c2f304/src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs#L951-L954

Yep @rjmholt, except that its internal. That's exactly the kind of legacy that  I was talking about where this 'forked' (aka copy pasted 5 years ago) version of VariableAnalysis has caused and if we could bring the latest version of variable analysis into PSSA for v2, I'd hope subtle issues like this one would magically go away

My hope is that we can spin the visitors into their own NuGet package and consume it separately. The issue there is that it might not be possible with framework runtime targeting in some circumstances.
But there are other places where these visitors would be useful and I don't want to reinvent them. I'd much prefer to have a standalone library of AST tools that we can reuse.

I also came across this Stack Overflow question, so it seems this is a problem not only for string arrays, but for any arrays. PSScriptAnalyzer always expects it to be an Object array instead of the strongly-typed array that it actually is.


fix: Support generic updater

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #2205 🦕

Also addresses #2125.  It might be nice to have a glob: true example as well.


python -m requests

Often when I'm debugging some HTTP thing, I poke at with curl.  But of course in many cases when I interact with it for real, I am going to be talking to it with requests.  Sometimes - especially in the case of weird SSL debugging - curl and requests will behave differently.  It would be really handy if requests had at least partial emulation of the curl command-line options to enable me to just python -m requests https://example.com/ and see what it's doing independent of my code.
A really cool bonus feature here would be to print out the relevant Python code for making that same request, but I can see how that might be getting a little far out of scope.

Sorry if this is a dup - I could swear I've seen it before but after 15 minutes of searching I couldn't find it.

I have considered this in the past, but opted against it. Might as well use http://httpie.org, which uses Requests.

@kennethreitz Oh - in my defense I did try searching closed issues as well :).

I don't think anyone's asked for it before :)

Bonus-fact: I used to have a function built-in that would turn your Request object into a curl command. It's been removed (obviously), but I think someone's maintaining a version of it (or perhaps the opposite of it) out there somewhere.

Thanks for the pointer to httpie.  I've been using it for testing my latest little creation and it is rad.


handle DocumentSymbolRequest

this gives an outline to the document, and also enables search by symbol
in some editors (at least lunarvim). Currently only labels are indexed,
giving a flat structure to an assembly file (and easy jump to a given
label).

I spent some time playing with this and it works well, thank you! A few nit picks from my end:

Could we run cargo fmt on the modified files so they pass the linting checks
Inside  explore_node(), do you think it makes sense to grab the kind_id's for the label and ident node types and use those instead of using a string comparison? We could do this at the start of the function:

static LABEL_KIND_ID: Lazy<u16> =
    Lazy::new(|| tree_sitter_asm::language().id_for_node_kind("label", true));
static IDENT_KIND_ID: Lazy<u16> =
    Lazy::new(|| tree_sitter_asm::language().id_for_node_kind("ident", true));

And then instead of checking node type like:
if node.kind() == "label" {
we could do this instead:
if node.kind_id() == *LABEL_KIND_ID {
I'll wait on a review from bergercookie, but beyond those two points everything looks great to me. :)

it's the first time I use treesitter's API so I kind of fumbled around until I could reliably find the label nodes. Your suggestion looks better!
btw, it'd be also nice to have "go to def" on labels as well, but it's outside the scope of this PR.

it's the first time I use treesitter's API so I kind of fumbled around until I could reliably find the label nodes. Your suggestion looks better!

Yeah it definitely feels weird. I'm still new to it/figuring it out myself, so no worries! I'd like to look into using tree-sitter's s-expressions for this (I used these in my PR for autocomplete, see the query strings in get_comp_resp() in src/bin/lsp.rs), but any kind of nesting/ recursion can make this difficult/ very messy.

btw, it'd be also nice to have "go to def" on labels as well, but it's outside the scope of this PR.

This is a great idea! I may try and put together a prototype for this in the next week or so depending on free time...

I did run cargo fmt, I don't get why it fails in CI… :/

I’m not sure either. When you run cargo --version what version shows? If that doesn’t fix things, worst case for this PR once you everything else is set I can do the formatting and open a PR on your branch. :)

I have cargo 1.74.0.
For me everything is set, I think — I used the pattern you recommended to recognize particular AST nodes :)

Awesome! I’ll wait for a review from the repo owner but everything else looks good to me. Thanks!

Hi again @c-cube
Apologies for the delay! Taking another look at this, I was curious what level of label "nesting" we're expecting to see in assembly files (I'm not super familiar with assembly specifics). From what I understand, assembly files tend to have a rather flat structure, and the current code's flat list of nodes matches that. Does it make sense to do this kind of recursive search for labels (I assume so that we can later support nested labels) if nested labels aren't a serious concern? If we're not worried about supporting nesting, we could instead issue a tree-sitter query for label nodes and iterate through the matches in a linear fashion.
I can open an example PR on your branch in the next few days if you're curious to see what I mean.
Sorry for the confusion, I hope my question makes sense :)

I didn't have time to review this properly. I might get some time in the weekend but in the meantime, @WillLillis since you've tried this locally and it works, whenever you think it's ready, feel free to merge 🚢

@WillLillis tbh I did the simplest thing (for me) that also reflects the hierarchical nature of the result. LSP's document symbols interface is a tree.
I also imagine that most assembly is going to be flat, but maybe there are variants with a tiny bit of nesting in the syntax. For example, an assembly with more powerful macros might have labels inside each macros that are kind of scoped to it?

@c-cube That seems perfectly reasonable, just wanted to check :)
Whenever you have time, could you rebase this branch so it's merge-able with the master? I'm happy to add it as is.
Thanks again for the contribution!


Browser not supported?

I'm running Version 128.0.6595.0 (Official Build) canary (arm64) on MacOS. The LLM setup has been completed and I can interact with Gemini in Dev Tools.
When I run the simplest example from the README, I get:
AI_LoadSettingError: Browser not support
at ChromeAIChatLanguageModel. (chrome-ai.js?v=108c4043:4882:15)
at Generator.next ()
at chrome-ai.js?v=108c4043:4824:61
at new Promise ()
at __async (chrome-ai.js?v=108c4043:4808:10)
at ChromeAIChatLanguageModel.getSession
thank you

Please try to execute await ai.canCreateTextSession() in chrome console and make sure the result is readily. Otherwise, please read the Enabling ai in chrome part in the readme.

Btw, The latest version of chrome has made some changes with the ai API. The new version will be released and adapted soon. Please use chromeai('text') for now.

Just released<EMAIL_ADDRESS>solves this problem. You can upgrade to this version or use it through playground.


V2 development

Summary
This merges version 2.0 development branch into main. This is a work in progress, so please do not merge into main until all conflicts have been resolved
Description for the changelog
Merge v2-development branch into main
Other info
Versions prior to 2.0 have been preserved on legacy-v1.x branch off main prior to this merge

Well, the conflict files are not as bad as I expected
Also note that any commits to v2-development before the main merge will get merged in as well, so it is safe to carry on commits to v2-development for another day or so

Codecov Report

Merging #364 (8c65e99) into main (6f1c796) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   97.99%   97.50%   -0.50%
==========================================
  Files          26       27       +1
  Lines         548      480      -68
  Branches       31        0      -31
==========================================
- Hits          537      468      -69
- Misses         11       12       +1

Impacted Files
Coverage Δ

td.angular/src/app/app.js

td.angular/src/app/config.route.js

td.angular/src/app/layout/index.js

td.angular/src/app/layout/shell.js

td.angular/src/app/services/datacontext.js

td.angular/src/app/services/index.js

td.angular/src/app/services/threatmodellocator.js

td.angular/src/app/threatmodels/github.js

td.angular/src/app/threatmodels/index.js

td.angular/src/app/threatmodels/webreport.js

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28dc6dd...8c65e99. Read the comment docs.

A couple of things that I had to do :

skip the electron test, as I did not want to delete the file @ShubhamPalriwala
added rate limiting to the express (back end server) app; the code analysis security checks asked for it

Otherwise it was just the normal conflicts - I have been robust :)

Lets goooooo! v2 it is!!

So, it looks good so far - I have run all the commands I can think of on this PR:

pnpm install
npm run build
npm test
npm run dev:server
npm run dev:vue
npm run electron:build
npm run electron:serve
npm run start:site
npm run start:server

The code analysis LGTM will take a while beause it has a lot to chew through ...

Interesting catch by LGTM on rate-limiting. I'm a fan where we're hosting the demo instance in Heroku, a little added protection is nice!

OK, all seems to test correctly and passes the checks so we can merge on Wednesday 9th as planned; probably mid-afternoon GMT ?  Say 12:00 East coast USA / 22:30 Bangalore

OK, all seems to test correctly and passes the checks so we can merge on Wednesday 9th as planned; probably mid-afternoon GMT ? Say 12:00 East coast USA / 22:30 Bangalore

I should be free for about an hour around then.  Please ping me on Slack if anything comes up, as I've been known to lose track of time... If anything needs tidying up afterwards, we can address it later.  So excited to see this moving into main!

+1 to @lreading ! Ping up on Slack if you need any help, I'll be glad to help.
12 hours to go 🚀


chore(ansible): refactor variable structure by moving host-specific and shared vars

This commit restructures the Ansible variables by:

Moving host-specific variables to the host_vars directory.
Moving shared variables to the group_vars directory for better separation and reusability.

Additionally:

The inventory.ini file has been deleted, as it was not being used.
The inventory.yml file has been updated to reflect these changes.

Sample CI runs:
Standalone Kepler: https://github.com/sustainable-computing-io/kepler-metal-ci/actions/runs/10889271916/job/30215848681
Kepler with Model Server: https://github.com/sustainable-computing-io/kepler-metal-ci/actions/runs/10889270537/job/30215852474


[UX] Common UI changes in mgt console

Description:

All instances of the word "Uri" and "Url" should be changed to caps - "URI" and "URL"

Most error messages say "Error is: ". Better not to put the "Error is:" part. For example "Could not add user PRIMARY/minoli. Error is: UserAlreadyExisting:Username already exists in the system. Please pick another username."

Wherever we have mentioned "Step 1 : xxxx", "Step 2 : xxx", the space between the number and the colon should be removed. So it should be "Step 1: xxx" instead of "Step 1 : xxx".

Wherever we have mentioned "select all on this page" and "unselect all on this page", the links can be shortened to "Select all" and "Unselect all"

Suggested Labels:
UX
Affected Product Version:
5.4.0

JIRA link - https://wso2.org/jira/browse/IDENTITY-6476

We will consider this for new admin portal redesign.


Threads die if they attempt to crawl a deleted directory

In crawlFiles I think there needs to be some error handling in cases where a directory or file has been deleted between when it was added to the crawl list and when it is recursed into or stat'd. If this happens for a directory, you get a traceback like this:
Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.7/threading.py", line 764, in run
    self.__target(*self.__args, **self.__kwargs)
  File "diskover.py", line 327, in processDirectoryWorker
    filelist = crawlFiles(path, DATEEPOCH, DAYSOLD, MINSIZE, EXCLUDED_FILES, VERBOSE)
  File "diskover.py", line 212, in crawlFiles
    for name in os.listdir(path):
OSError: [Errno 2] No such file or directory: '/no/longer/here'

And that thread is dead for the remainder of the scan. Since a directory or file can get yanked out from underneath a diskover thread at any time, is it possible to wrap the relevant bits of crawlFiles with a try/except blocks and have it gracefully move on in the event of an OSError? Or would respawning the thread be better/easier?

Good catch, thanks. I've patched this in release v1.0.10 with some other bug fixes and code improvements.

This one is probably related to the patch (thanks for that, btw), it looks like it's calling printProgressBar with a dircount of 0?
Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.6/threading.py", line 484, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/var/tmp/diskover.py", line 335, in processDirectoryWorker
    printProgressBar(dircount, total_num_dirs, 'Crawling:', '%s/%s'%(dircount,total_num_dirs))
  File "/var/tmp/diskover.py", line 74, in printProgressBar
    percents = str_format.format(100 * (iteration / float(total)))
ZeroDivisionError: float division

this has been fixed in v1.0.11


setObjectForKey: object cannot be nil (key: data)'

When I try to pick from photo library I get the following error :

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** setObjectForKey: object cannot be nil (key: data)'

When I look into ImagePickerManager.m, it seems that the following code is producing the error :
if (![[self.options objectForKey:@"noData"] boolValue]) {
  NSString *dataString = [data base64EncodedStringWithOptions:0]; // base64 encoded image string
  [self.response setObject:dataString forKey:@"data"];
}

But in my options I'm not setting "noData" to false. So it shouldn't enter the if statement. If I comment out these lines, the error is not showing up anymore but the uri in my response object is linking to an inexistant picture.
Here is my options object :
var options = {
    title: 'Sélectionnez une photo de profil',
    storageOptions: {
        path: 'images',
        allowsEditing: true,
        noData: true,
        quality: 'medium',
    },
};

Version

react-native-image-crop-picker v0.26.3
react-native v0.44.3

I'm having this same error. Several of my users is having this issue. Not sure if they are using photo library or using camera. Here is my error log from Crashlytics. There is also several report that my user is uploading empty picture, and the number of the issue is similar with this issue, so I suspect they are uploading empty pictures because of this crash. Any one can help here?
Fatal Exception: NSInvalidArgumentException
*** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: data)

Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x1d27a4ec4 __exceptionPreprocess
1  libobjc.A.dylib                0x1d1975a40 objc_exception_throw
2  CoreFoundation                 0x1d271c494 _CFArgv
3  CoreFoundation                 0x1d268fa30 -[__NSDictionaryM setObject:forKey:]
4  Bibit                          0x10052b4c8 __74-[ImagePickerManager imagePickerController:didFinishPickingMediaWithInfo:]_block_invoke (ImagePickerManager.m:380)
5  UIKitCore                      0x1ff41b73c -[UIPresentationController transitionDidFinish:]
6  UIKitCore                      0x1ff424818 -[_UICurrentContextPresentationController transitionDidFinish:]
7  UIKitCore                      0x1ff41f74c __56-[UIPresentationController runTransitionForCurrentState]_block_invoke.440
8  UIKitCore                      0x1ff51d6cc -[_UIViewControllerTransitionContext completeTransition:]
9  UIKitCore                      0x1fff22748 -[UITransitionView notifyDidCompleteTransition:]
10 UIKitCore                      0x1fff223e0 -[UITransitionView _didCompleteTransition:]
11 UIKitCore                      0x1fff244f0 -[UITransitionView _transitionDidStop:finished:]
12 UIKitCore                      0x1fff2c950 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:]
13 UIKitCore                      0x1fff2cf3c -[UIViewAnimationState animationDidStop:finished:]
14 UIKitCore                      0x1fff2cfdc -[UIViewAnimationState animationDidStop:finished:]
15 QuartzCore                     0x1d6db34f8 CA::Layer::run_animation_callbacks(void*)
16 libdispatch.dylib              0x1d21de484 _dispatch_client_callout
17 libdispatch.dylib              0x1d218a9a4 _dispatch_main_queue_callback_4CF$VARIANT$mp
18 CoreFoundation                 0x1d2734df4 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
19 CoreFoundation                 0x1d272fcbc __CFRunLoopRun
20 CoreFoundation                 0x1d272f1f0 CFRunLoopRunSpecific
21 GraphicsServices               0x1d49a8584 GSEventRunModal

I can't seem to reproduce this, but some of my users do seem to getting this crash.
        if (![[self.options objectForKey:@"noData"] boolValue]) {
            NSString *dataString = [data base64EncodedStringWithOptions:0]; // base64 encoded image string
            [self.response setObject:dataString forKey:@"data"]; // Crash here
        }

It's weird because [self.options objectForKey:@"noData"] is false, indicating that there is data. But then either data is nil or the base 64 encoding fails for some reason. According to the documentation base 64 encoding should return a string, and never nil.
Only report I have said that it occurred on an iPhone 6+ running iOS 12.3.1.

I am having the same error, this should be reopened

我分析了代码发现有如下情况：(void)imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary<NSString *,id> *)info方法中，[info objectForKey:UIImagePickerControllerOriginalImage]部分图片上传之后，获取图片资源返回nil，导致闪退。

Reproduced on iPhone 11 Pro Max, 13.3.1

Same issue with users having:

iPhone XR 13.5.0 (17F75)
iPhone 6s 13.2.3 (17B111)

Same. Don't know how to reproduce.
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x1af7d3794 __exceptionPreprocess
1  libobjc.A.dylib                0x1af4f5bcc objc_exception_throw
2  CoreFoundation                 0x1af8292dc -[__NSCFString characterAtIndex:].cold.1
3  CoreFoundation                 0x1af832920 -[__NSDictionaryM setObject:forKey:].cold.3
4  CoreFoundation                 0x1af6afff8 -[__NSDictionaryM setObject:forKey:]
5  MyApp                          0x10320d908 __74-[ImagePickerManager imagePickerController:didFinishPickingMediaWithInfo:]_block_invoke + 383 (ImagePickerManager.m:383)
6  UIKitCore                      0x1b3156cd8 -[UIPresentationController transitionDidFinish:]
7  UIKitCore                      0x1b3160d68 -[_UICurrentContextPresentationController transitionDidFinish:]
8  UIKitCore                      0x1b315b398 __56-[UIPresentationController runTransitionForCurrentState]_block_invoke.503
9  UIKitCore                      0x1b325e5dc -[_UIViewControllerTransitionContext completeTransition:]
10 UIKitCore                      0x1b3cecc60 -[UITransitionView notifyDidCompleteTransition:]
11 UIKitCore                      0x1b3cec910 -[UITransitionView _didCompleteTransition:]
12 UIKitCore                      0x1b3d22344 -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:]
13 UIKitCore                      0x1b3cf6748 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:]
14 UIKitCore                      0x1b3cf6c50 -[UIViewAnimationState animationDidStop:finished:]
15 UIKitCore                      0x1b3cf6da0 -[UIViewAnimationState animationDidStop:finished:]
16 QuartzCore                     0x1b62d3014 CA::Layer::run_animation_callbacks(void*)
17 libdispatch.dylib              0x1af499524 _dispatch_client_callout
18 libdispatch.dylib              0x1af44b5b4 _dispatch_main_queue_callback_4CF$VARIANT$mp
19 CoreFoundation                 0x1af7517fc __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
20 CoreFoundation                 0x1af74c6d0 __CFRunLoopRun
21 CoreFoundation                 0x1af74bce8 CFRunLoopRunSpecific
22 GraphicsServices               0x1b989638c GSEventRunModal
23 UIKitCore                      0x1b387a444 UIApplicationMain
24 MyApp                          0x102c877cc main + 16 (main.m:16)
25 libdyld.dylib                  0x1af5d38f0 start

@damikdk Could you please give more details? And provide the photo?

I can't now, but we got this from Crashlytics, as long as I remember. It happens very rarely and randomly.

+1

was anyone able to solve this? getting this on iPhone X ios 13.6

For some reason, this issue occurs for me when I choose one specific image from the media library. When I edited the same image and tried again, seems to works. I can't say for sure what makes this happens but this info may help someone that wants to try to debug it.

I'm having this issue on iPhone 11 pro as well, after capturing an image from the camera
const options: CameraOptions = {
      mediaType: "photo",
      includeBase64: false,
    };
    launchCamera(options, response => {}

Same issue here. Only for using library, not camera.
Crash occurred on
ios 14.4.2
Hardware Model:      iPhone13,4      (according to crash logs, which seems to be iphone 12 pro max)
if (![[self.options objectForKey:@"noData"] boolValue]) {
                NSString *dataString = [data base64EncodedStringWithOptions:0]; // base64 encoded image string
                [self.response setObject:dataString forKey:@"data"];
            }

last line seems to be the problem starting with "self.response", but not sure how to fix it.


Category Cache Warmup

I see there is been a feature/bug missing from since Shopware 5
Is that cache warmup does not warmup the category page until is visited, then next visit to that category section it is already warmed
This is very important on big catalogues (we running 10K categories)
I there any plan for this?

Hey @Yafar-ISI,
thank you for your request. We are aware of this and have it on our roadmap. There will be different caching solutions implemented in the shopware 6 final release.
Greetings,
Phil


update sdk document and chunk

What problem does this PR solve?
Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.
Type of change

[x] New Feature (non-breaking change which adds functionality)

pdf file is too big for code repository


Use Java instead of Guava classes

jFunk used Guava Predicates and Functions as these weren't available in JDK before Java 8. In many places these are still in use and force usage of Guava classes over the API.
Now everybody uses at least Java 11 with its Functional Interfaces, therefore it is unconvenient to have this old API.
jFunk should use Predicates and Functions from the JDK instead of Guava.
It should also be considered to change the following:

use Java 11 at compile time
only use Guava classes where there is no good JDK alternative
drop Guava dependency if possible or update to the latest stable version

Solved with jFunk 3.4.0


favicon customizer added

Description
Favicon customizer added
new in added all requires files
Fixes:  #887

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK
Before

After

@Sulagna-Dutta-Roy done


Profile stats

Followup to #14695 with a single additional feature, commit ea2e87f, that adds a couple banks of hierarchical profilers to the -stats-output-dir / -trace-stats-events machinery. The user need only pass -profile-stats-events or -profile-stats-entities (along with -stats-output-dir) to get the full feature, so it's still quite easy to explain, capture, transport, etc.
The additional output is a subdirectory full of plain-text hierarchical profiles in the input format to flamegraph.pl, each of which shows time or event-counts arranged into pseudo-stacks formed by the entry/exit events of the FrontendStatsTracer objects, optionally subdivided by source entity (though that makes the profile quite a bit more fine-grained -- it also removes the mystery of which call to "typecheck-decl" is which!).
Here's a (github-sanitized, script-disabled so only half-useful, but you can still get tooltips) version showing the Sema.NumGenericSignatureBuilders counter broken down by source entity in a single file from the Plank project, as an example:

I'll push a few more tests next week, just wanted to get this posted for any early feedback.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 59a83270923a85e4fa36811a85995ff8c59362ee

Build failed
Swift Test OS X Platform
Git Sha - 59a83270923a85e4fa36811a85995ff8c59362ee

Sounds great! Can’t wait to try it out.

David

On Feb 18, 2018, at 2:41 AM, Graydon Hoare<EMAIL_ADDRESS>wrote:
@swift-ci please test
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 59a83270923a85e4fa36811a85995ff8c59362ee

Build failed
Swift Test OS X Platform
Git Sha - 59a83270923a85e4fa36811a85995ff8c59362ee

@jrose-apple Pushed requested changes (removed a bunch of macros too) and added test.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - c054edea2b62be6058ec3c15a9ff7cc04e7cc239

Build failed
Swift Test Linux Platform
Git Sha - c054edea2b62be6058ec3c15a9ff7cc04e7cc239

Note that I left other comments on the other PR.

Oops, missed them, sorry; fixing now.

@jrose-apple pushed update with fixes to both this branch and the prefix (and closing out that PR since you seem roughly ok with this extension).

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 9d7b887d521b8452175c49162951e99593f7319f

Build failed
Swift Test Linux Platform
Git Sha - 9d7b887d521b8452175c49162951e99593f7319f

@swift-ci please test and merge

@swift-ci please test and merge


Return 404 error to TRAPI ARS queries

This issue is in response to a decision made during today's mini-hackathon that KPs return a 404 response to indicate when TRAPI calls are simply not supported by ICEES.

See #140.


Remove duplicate header in a Payload message in the Metrics Protocol

Currently, when sending over a Payload Message to the Monitoring Hub the Payload portion is preceded by a header and the Payload itself contains a header.
Initial payload size is unneeded and can be removed.
Requires updating HubProtocol decoder to accept new message structure.

@JONBRWN Is this issue still relevant?

@jtfmumm yes, although I wouldn't call it a bug as the protocol works fine. just some extra info passed along that we can remove


xflux goes defunct when "nighttime color temperature" is set < 2000

Steps:

run fluxgui
open preferences
set nighttime temperature to any value lower then 2000 (choosing either "sunset/sunrise" or "match flame")

Result:
xflux process goes defunct and screen temperature does not change
Root Cause:
Running xflux with temp setting lower than 2000 seems to be unsupported.
e.g. xflux -l 39.50,-98.35 -k 1850  fails with error: Your kelvin color is out of range. We support 2000-10000K.

Thanks for finding the root cause here! I'm to blame: https://github.com/xflux-gui/xflux-gui/commit/8140fcdb2a697da87535a7e55cef37456d2d83a0 :D
Interestingly, it seems xflux (the program that fluxgui uses to set the screen temp) does support these low temps in preview mode, so it's probably an arbitrary limitation of xflux. You can try previewing a low temp in xflux by quitting fluxgui and running
xflux -l 0 -g 0 -nofork

and then entering a low temp, for example
k=1000<enter>

to set the preview temp to 1000.
In any case, these low temp options will need to be removed from fluxgui.

shouldn't this be reported to xflux so they add support for those ?

@cipri-tom, note that xflux reports that these color temps are not supported; see the "root cause" section in the issue description. So, we could ask for these color temps to be supported, but xflux team already knows they are not. The we thing is that it seems like an arbitrary restriction.
Maybe @herf can tell us why?


ThreeDotsIcon throws unique key prop warning

Description
When using ThreeDotsIcon (used in IconButton specifically) it throws a react warning about not having key props
CodeSandbox/Snack link
https://snack.expo.dev/t3JUBCRz-
Steps to reproduce
(haven't tested CRA but it should complain -- it loves to complain about those. did test with metro.)

Init react-native app (npx react-native init ...)
Add  element in app
Run with metro
See complaint either in devtools warning popup or in metro console

NativeBase Version
3.4.28
Platform

[X] Android
[X] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
"Warning: Each child in a list should have a unique "key" prop."
Looks like it's a bug because the path passed is an array of items to render vs the other icons which is just a single element

Unable to reproduce this issue, attaching a screenshot of the expo snack (link).
The app runs without any errors.

Perhaps this has already been solved?

Unable to reproduce this issue, attaching a screenshot of the expo snack (link). The app runs without any errors.

Perhaps this has already been solved?

Try with steps I provided — it works in expo snack but it could be using a different render method or quieter warnings. CRA and react-native init do NOT like rendering lists without keys. Unless they’re doing some magic where they inject their own unique keys for rendering arrays, it looks to me like expo isn’t bothering to warn on this. ThreeDotsIcon so far as I can tell is the only with an array even though I think it just has one item.

Thanks for the clarification @alexnagelberg !
I've fixed this warning locally and am working on a PR for the same


can't find Fluorescent Fungus

Fluorescent Fungus is a ascension material for some characters but I can't find it, what I've tried:
let db = require("genshin-db")

db.materials("Fluorescent Fungus", { matchCategories: true })

What is the version of the package you are using

What is the version of the package you are using

3.10.3

Fluorescent fungus is only available in v3.11.0+
The latest version is v3.13.1
Please update


Rephrase the Rendering section

Rephrase the Rendering section not to promote the default usage of Polymer Templates. Default should be the renderers.

Closed by https://github.com/vaadin/vaadin-overlay/pull/113


fix: Ensure target task's onExit handlers are run

Fixes #3710

Small Suggestion, try to avoid the runOnExitNode twice. Try to see this will solve this issue.
func (woc *wfOperationCtx) executeDAGTask(dagCtx *dagContext, taskName string) {
	node := dagCtx.getTaskNode(taskName)
	task := dagCtx.GetTask(taskName)
	if node != nil && node.Fulfilled() {
		return
	}

Try to see this will solve this issue.

Tried it without success


fix

What type of PR is this? (check all applicable)

[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] ♻ Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentations?

[ ] 📓 docs (./docs)
[ ] 📕 storybook (./storybook)
[ ] 📜 README.md
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

.i18n-update-push

.i18n-update-pull

.i18n-update-pull

.i18n-update-pull

.i18n-update-pull


unable to find index for $geoNear query

Issue Description
I have 2 classes: Cars and CarShops ( CarShops has a GeoPoint "location" )
I want to query the database for nearest cars.
When i execute the query i get this error:
planner returned error: unable to find index for $geoNear query
Steps to reproduce
var userGeo = new Parse.GeoPoint({longitude:longitude, latitude:latitude});

var locationQuery = new Parse.Query("CarShops");
locationQuery.near("location", userGeo);
var query = new Parse.Query("Cars");
query.include("carshop");
query.matchesQuery("carshop", locationQuery);
query.find()
.then( res => {
	response = res;
})

Which version of mongodb and parse server are you using? We currently require 3.0.8 or 2.6.11 (support for 3.2.6 will be available soon)

@drew-gross spot on! I was running 3.2.x after downgrading and putting new data into the db the geo queries started working :) thanks


flutter_plugin_tools: No such file or directory

I got an error when trying to run flutter_plugin_tools analyze or flutter_plugin_tools format:
Steps to Reproduce
pub global activate flutter_plugin_tools
Package flutter_plugin_tools is currently active at version 0.0.5.
Resolving dependencies... (3.2s)
+ args 0.13.7 (1.0.0 available)
+ async 1.13.3 (2.0.0 available)
+ charcode 1.1.1
+ collection 1.14.3
+ flutter_plugin_tools 0.0.5
+ http 0.11.3+15
+ http_parser 3.1.1
+ path 1.4.2
+ source_span 1.4.0
+ stack_trace 1.8.2
+ string_scanner 1.0.2
+ typed_data 1.1.5
Precompiling executables...
Precompiled flutter_plugin_tools:flutter_plugin_tools.
Activated flutter_plugin_tools 0.0.5.

pub global run flutter_plugin_tools analyze
Activating tuneup package...
Unhandled exception:
ProcessException: No such file or directory
  Command: pub global activate tuneup
#0      runAndStream (package:flutter_plugin_tools/src/common.dart:59)
<asynchronous suspension>
#1      AnalyzeCommand.run (package:flutter_plugin_tools/src/analyze_command.dart:25)
<asynchronous suspension>
#2      CommandRunner.runCommand (package:args/command_runner.dart:194)
<asynchronous suspension>
#3      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:109)
#4      new Future.sync (dart:async/future.dart:222)
#5      CommandRunner.run (package:args/command_runner.dart:109)
#6      main (package:flutter_plugin_tools/src/main.dart:37)
#7      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:263)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)

Flutter Doctor
[✓] Flutter (on Linux, locale en_US.UTF-8, channel alpha)
    • Flutter at /home/marcinus/flutter
    • Framework revision 701d534ba9 (3 weeks ago), 2017-09-12 14:01:51 -0700
    • Engine revision 31d03de019
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
    • Android SDK at /home/marcinus/Android/Sdk
    • Platform android-25, build-tools 25.0.3
    • Java binary at: /home/marcinus/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] Android Studio (version 2.3)
    • Android Studio at /home/marcinus/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2017.2)
    • Flutter plugin version 17.0
    • Dart plugin version 172.4155.35

[✓] Connected devices
    • None

I have tried reinstalling dart and pub, nothing helped.

Do you have pub in your path? The plugin_tools currently require it to be there.

It solved the issue for analyze but format still gives me same error.
pub global run flutter_plugin_tools format
Downloading Google Java Format...
Formatting all .dart files...
Unchanged /MY_PATH/plugins/packages/firebase_messaging/test/firebase_messaging_test.dart
...
Unchanged /MY_PATH/plugins/packages/firebase_admob/example/lib/main.dart
Formatting all .java files...
Formatting all .m and .h files...
Unhandled exception:
ProcessException: No such file or directory
  Command: clang-format -i --style=Google /MY_PATH/plugins/packages/firebase_messaging/example/ios/Runner/AppDelegate.h
/MY_PATH/plugins/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.h
...
/MY_PATH/plugins/packages/firebase_admob/ios/Classes/FirebaseAdmobPlugin.m
/MY_PATH/plugins/packages/firebase_admob/ios/Classes/MobileAd.m
#0      runAndStream (package:flutter_plugin_tools/src/common.dart:59)
<asynchronous suspension>
#1      FormatCommand._formatObjectiveC (package:flutter_plugin_tools/src/format_command.dart:82)
<asynchronous suspension>
#2      FormatCommand.run (package:flutter_plugin_tools/src/format_command.dart:40)
<asynchronous suspension>
#3      CommandRunner.runCommand (package:args/command_runner.dart:194)
<asynchronous suspension>
#4      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:109)
#5      new Future.sync (dart:async/future.dart:222)
#6      CommandRunner.run (package:args/command_runner.dart:109)
#7      main (package:flutter_plugin_tools/src/main.dart:37)
#8      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:263)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)

format requires clang-format version 5 in your path to format Obj-C code. If it's not in your path, you can also specify where to find clang-format on your system with the --clang-format=<path-to-clang-format-5> parameter.
We should probably document this better / provide better error messages.

From Ubuntu 16.04 perspective:
I have installed clang-format (an then format worked) but from what I see latest official release is 3.4. Do you have any guidelines how to install clang-format-5.0 on Linux?

@goderbauer any tips on the question above?

I don’t really. A quick google search points to http://apt.llvm.org, where it looks like “apt-get install clang-format-5.0” should just work, but I haven’t tried that.

@MarcinusX is this still an issue?

@zoechi Moved from ubuntu to mac, so I cannot reproduce anymore.

@MarcinusX thanks for the update!
I'm going to close. Feel free to reopen if you run into it again.


Problem with editing text

Hi, I have a problem with editing text in a game, I know that the BF_Key_Rebinding_Func_Lib.uexp file contains the text shown in the picture, but the UE4 Localizations Tool cannot display this text. Would it be possible to do something about it? I am attaching a file to test. Thank you for your help.

Test.zip

@Mayki07
test this file
BF_Key_Rebinding_Func_Lib.zip

Great, it seems to be working.

I have one more request, would there be any possibility to use UE4localizationsTool to access the texts that are in the *.umap files? The text in the image is in the *.umap file and not in the *.uexp file.
I am attaching a file to test.

Localization_uexp.zip

If it is possible to upload the game files in the archive and on a file sharing service, then I can create a locres file to edit these files. I already tried to create from those files that you sent, I succeeded.

Ok

@Mayki07
what about this?
BF_Key_Rebinding_Func_Lib.zip

Still the same problem, the game crashes when loading.

@Mayki07
and now?
BF_Key_Rebinding_Func_Lib.zip

No. Game crashes.

@Mayki07
Unfortunately I will leave this issue for some time again and will come back to find a solution to it as soon as possible
thanks for test files 🌹

OK, thanks.

OK, thanks.

change .umap to .uassets ,edit it,then change .uassets to .uamp
I have localized this game.
like this
for /r  "Radius\IntoTheRadius\Content\ITR\Levels-Quest" %%a in (*.umap) do  ren %%a .uasset
.\tools\UE4localizationsTool.exe  -importall   "Radius\IntoTheRadius\Content" "翻译.txt"  -f
for /r  "Radius\IntoTheRadius\Content\ITR\Levels-Quest" %%a in (.uasset) do  ren %%a *.umap
the game work well.

OK, thanks.

change .umap to .uassets ,edit it,then change .uassets to .uamp
I have localized this game.
like this
for /r "Radius\IntoTheRadius\Content\ITR\Levels-Quest" %%a in (*.umap) do ren %%a .uasset .\tools\UE4localizationsTool.exe -importall "Radius\IntoTheRadius\Content" "翻译.txt" -f for /r "Radius\IntoTheRadius\Content\ITR\Levels-Quest" %%a in (.uasset) do ren %%a *.umap
the game work well.

Hi, do you have this game localized ?
I'm trying to. The previous question from Mayki was more for me and just forwarded me the answers. I'm having the problem that UE4LocalizationsTool doesn't always load all the text for me. Figure 1 - Left. How did you solve this? Did you edit the hex ? Is there a lot of such texts ?

@Luc2as
Send this example

OK, sorry I have better example here.

notext.zip

@Luc2as
worked!

If I change any item in the black cells the game crashes...

@Luc2as
yes i know this the reason i put this notice

So, this text is not editable.....

@Luc2as
If it's the same length, it will work
for example:
1. System: Game Menu<cf>2.  >>> 1. System: gggg Menu<cf>2.

Okay, I understand... Thank you very much! Good work with this SW

Okay, I understand... Thank you very much! Good work with this SW

I edit a picture replaced it。like this

and change the position  WBP_Block_ControlsLayout.uasset

Okay, I understand... Thank you very much! Good work with this SW

I edit a picture replaced it。like this
and change the position WBP_Block_ControlsLayout.uasset

Hey, man.
Thank you so much!!! Thank you so much!!! Can I ask you about any other problems that I have discovered or I will discover ? In a private message ? Email ?

Okay, I understand... Thank you very much! Good work with this SW

I edit a picture replaced it。like this
and change the position WBP_Block_ControlsLayout.uasset

Hey, man.
Thank you so much!!! Thank you so much!!! Can I ask you about any other problems that I have discovered or I will discover ? In a private message ? Email ?

Yeah，if I can.

Thanks for any help ! But I don't want to interact here and spam this thread with specific questions. Any idea for private communication. I will be very grateful for your advice. Email is not visible on github.

<EMAIL_ADDRESS>&<EMAIL_ADDRESS>

感谢您的任何帮助！但我不想在这里互动并用特定问题向该线程发送垃圾邮件。任何私人交流的想法。我将非常感谢您的建议。电子邮件在 github 上不可见.

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks!

@Luc2as If it's the same length, it will work for example:
1. System: Game Menu<cf>2.  >>> 1. System: gggg Menu<cf>2.

Hey, man.
I have an idea, would it be possible to make a checkbox in the menu that would prevent editing more characters than the black cell contains?
I'm constantly counting them, editing them and the game crashes often.

@Luc2as

UE4localizationsTool.zip

@Luc2as
UE4localizationsTool.zip

Hi,
thank you so much! You're the first person to ever edit something on Github for me !!!
Thank you again!

And small bug here.
https://user-images.githubusercontent.com/114860916/200375343-6a166572-476c-4a00-b7d3-6eb30cecf21b.mp4

@Luc2as
UE4localizationsTool.zip
It won't effect but here it is, btw did you test the game after modify the file?

I know it's just aesthetics. I work with it all the time, yes game tested. Mostly it notifies me when the game crashes. How many times is the text long there are spaces etc.

感谢您的任何帮助！但我不想在这里互动并用特定问题向该线程发送垃圾邮件。任何私人交流的想法。我将非常感谢您的建议。电子邮件在 github 上不可见.

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Hey, man,
I sent you an e-mail about the menu texts.
Is there a solution? Can it be localized?
Thanks for the reply

Hey, man, I sent you an e-mail about the menu texts. Is there a solution? Can it be localized?
Thanks for the reply

Didn't you get the email? If you mean "custom", "Highly Decreased", "For Player and Enemies", etc.Yes ,they could. I have sent an email. Contains a "file. zip"

Hi, I'm having trouble editing text again. I need to edit (translate) text, but it is in a uexp file , not in uasset. Is there anything I can do about it?

I am attaching a file to test.
TestFile.zip

@Mayki07

UE4localizationsTool.zip

OK, thanks...

Hi, I have another problem with text editing. I only have a uasset file that contains text. I am unable to open the file in your tool. Is there any way to edit the text?
I am attaching a test file.

Test_file.zip

@Mayki07
test this

UE4localizationsTool.zip

I don't know what I'm doing wrong, but no text has shown up.

Hi, I have some uasset text file here, but I can't open it in your program. Would you take a look at it, please? I'm attaching a test file.
Test_file.zip

@Mayki07
https://github.com/amrshaheen61/UE4LocalizationsTool/releases/tag/v2.3

Beautiful work, thank you...


⚠ Samsung has degraded performance

In 0585cf2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2210 ms

Resolved: Samsung performance has improved in 05120bd.


AuditTo configuration has bug

Bug Report
public static LoggerConfiguration MSSqlServer(
this LoggerAuditSinkConfiguration loggerAuditSinkConfiguration,
string connectionString,
string tableName,
IConfiguration appConfiguration = null,
LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum,
IFormatProvider formatProvider = null,
bool autoCreateSqlTable = false,
ColumnOptions columnOptions = null,
IConfigurationSection columnOptionsSection = null,
string schemaName = "dbo"
)
{
if(loggerAuditSinkConfiguration == null)
throw new ArgumentNullException("loggerAuditSinkConfiguration");
        var connectionStr = ApplyMicrosoftExtensionsConfiguration.GetConnectionString(connectionString, appConfiguration);
        var colOpts = ApplyMicrosoftExtensionsConfiguration.ConfigureColumnOptions(columnOptions, columnOptionsSection);

        return loggerAuditSinkConfiguration.Sink(
            new MSSqlServerAuditSink(
                connectionString,
                tableName,
                formatProvider,
                autoCreateSqlTable,
                columnOptions,
                schemaName
                ),
            restrictedToMinimumLevel);
    }
}

Please notice,connectionStr  and colOpts have not used,cause to don't open connection and columns is error!

I noticed that in the source code too so I tried to create a sample consisting of a .NET Standard lib and a .NET Core 2.0 app. The app calls the lib which in turn intinalizes the Serilog MSSqlServer sink for auditing. The sample can be found here.
https://github.com/ckadluba/serilog-sinks-mssqlserver/tree/issue-189-AuditTo-MEC-does-not-read-connectionString-from-config/sample/NetStandardDemo
When debugging the project I was surprised to notice that the init code in the following file was called.
Configuration/Extensions/Hybrid/LoggerConfigurationMSSqlServerExtensions.cs
But as far as I understand it the following should have been used in this case.
Configuration/Extensions/Microsoft.Extensions.Configuration/LoggerConfigurationMSSqlServerExtensions.cs
I was not able to find a configuration where the latter one (containing the bug) was called. Is this just dead code?
@hubo0831 do you have a configuration where Microsoft.Extensions.Configuration/LoggerConfigurationMSSqlServerExtensions.cs is really called or did you just see the bug in the source?
Maybe @mivano or other long time maintainery could help us with some hints.

Although I could not test this and still have the suspicion this is could be dead code, I fixed this unused variables bug in PR #244


Support for Multi Area Conditioning Custom Node

Can you please add support for this custom node: https://github.com/Davemane42/ComfyUI_Dave_CustomNode?

Closing


Professorships | Update title text on pages

READY FOR REVIEW
Summary

Request to update the <title> text on Endowed Positions schools/centers pages to the following format:
"Endowed Positions at Stanford: [School/Program/Center/Institute Name] | Giving to Stanford"
Also made update for search results "Endowed Positions at Stanford: Search results for [results] | Giving to Stanford"
Updated STANFORD DOERR SCHOOL OF SUSTAINABILITY => SCHOOL OF EARTH, ENERGY AND ENVIRONMENTAL SCIENCES
Fixed Stanford Libraries results

Review By (Date)
6/30/2022
Criticality

How critical is this PR on a 1-10 scale? Also see Severity Assessment.
9

Review Tasks
Setup tasks and/or behavior to test

Check out this branch
Navigate to /endowed-positions, select any school/center and view the source to see if the <title> text matches the format mentioned above
Try a search term, and then view the source to see if the <title> text matches the format above
Naviage to /endowed-positions/school-of-earth-energy-and-environmental-sciences make sure page works and has results
Navigate to to //endowed-positions/stanford-libraries make sure page works and has results

Front End Validation

[ ] Is the markup using the appropriate semantic tags and passes HTML validation?
[ ] Cross-browser testing has been performed?
[ ] Automated accessibility scans performed?
[ ] Manual accessibility tests performed?
[ ] Design is approved by @ user?

Backend / Functional Validation
Code

[ ] Are the naming conventions following our standards?
[ ] Does the code have sufficient inline comments?
[ ] Is there anything in this code that would be hidden or hard to discover through the UI?
[ ] Are there any code smells?
[ ] Are tests provided? eg (unit, behat, or codeception)

Code security

[ ] Are all forms properly sanitized?
[ ] Any obvious security flaws or new areas for attack?

General

[ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
[ ] Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials

@sherakama The Endowed Positions site was officially announced today–which is great! However, the Donor Relations team jumped the gun with asking us to display the Stanford Doerr School of Sustainability as the label for those listings. They've asked we roll that label back asap, hence the PR. Mea culpa from them, which is something.