[FEAT] IoC container does not resolve nested async deps

Information

Version: 6.x
Packages:  di

Currently, there is no way to register multiple providers, which depend on each other, using the async factory.
Steps to reproduce

Register an async factory (A)
Register another async factory (B) so that it depends on the A provider
Build all providers from the container

Example
import { InjectorService, registerProvider } from '@tsed/di';
import { ok } from 'assert';

registerProvider({
  provide: 'async_provider_1',
  async useAsyncFactory(): Promise<unknown> {
    return {};
  }
});

registerProvider({
  provide: 'async_provider_2',
  deps: ['async_provider_1'],
  async useAsyncFactory(asyncProvider1: unknown): Promise<unknown> {
    ok(
      asyncProvider1 instanceof Promise,
      'The dependency is an instance of Promise.'
    );

    return {};
  }
});

const injector = new InjectorService();

injector.load(); //  AssertionError [ERR_ASSERTION]: The dependency is an instance of Promise.

Actual result
The IoC container passes a dependency as an instance of Promise.
Expected result
The IoC container passes a value of resolved Promise.

Hello @derevnjuk
This is not a but. Async factory cannot depend on another async factory because the invoke method is synchrone. Unfortunatly changing that will be a breaking change if the DI is used manually. I’ll try to take a time to propose an improvment on it and maybe introduce that for v7 if there is a breaking.

With v6 you can do that:
import { InjectorService, registerProvider } from '@tsed/di';
import { ok } from 'assert';

registerProvider({
  provide: 'async_provider_1',
  async useAsyncFactory(): Promise<unknown> {
    return {};
  }
});

registerProvider({
  provide: 'async_provider_2',
  deps: ['async_provider_1'],
  async useAsyncFactory(asyncProvider1: Promise<unknown>): Promise<unknown> {
    const dep = await asyncProvider1

    return {};
  }
});

const injector = new InjectorService();

await injector.load();

Yeah, that's what I use to bypass these limitations) Thanks 👍🏾

I found solution. Release is on going :D

:tada: This issue has been resolved in version 6.72.0 :tada:
The release is available on:

v6.72.0
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 7.0.0-alpha.2 :tada:
The release is available on:

v7.0.0-alpha.2
GitHub release

Your semantic-release bot :package::rocket:


Error

intelliCode wasn't able to apply the user setting 'python.jediEnabled': 'false' automatically, please manually set it.

@MHDFahz - the setting is no longer needed, it has been deprecated. python.languageServer is the setting that controls language engine selection. Thanks.

This seems to relate to jedi, which is now deprecated in lieu of Pylance


feat: add script to generate ebook

Closes https://github.com/phil-opp/blog_os/issues/1070.
I wanted to read this book on my e-reader, so I added a quick script, to generate an e-book from the markdown, using pandoc.  This is not perfect, the issues include:

Some of the used syntax breaks the e-book, so it needs to be removed
Links, that link to the website (e.g. all links starting with @) do not work. Preferably, they would link to the chapter in the book, but I'm not sure how to do that.
The layout is often imperfect, code blocks or text diagrams may be split over pages
No real differentiating between posts
New chapters do not start on a new page
probably another dozen of things I didn't notice

I'm not sure how many of them can be fixed without changing the source content itself, or how to fix most of them, but I think this is a worthwhile start, as it is still readable (an e-book with bad layout is still better than no e-book).
Also added a quick cover image, I'm not a designer, but it gets the job done. Maybe another contributor, with better design skills, can improve it.

Thanks a lot for submitting! Unfortunately I'm quite busy right now and I haven't had time to review this PR and to try it out. I try my best to get to it as soon as possible!

You're welcome. That's absolutey no problem for me, take your time. In the meantime, I've had time to read through it, using the generated e-book, and noticed a few more issues. Most of them were probably caused by my device, as they do not appear when opening the e-book on my pc, but I think it is still worth mentioning them:

Code was not line-wrapped, so it sometimes went off-page
Text was missing in images, which made diagrams unreadable


A problem on TRPO implementation

https://github.com/openai/baselines/blob/b05be68c55d416f7aa71f745aaf3c2999d83b83c/baselines/trpo_mpi/trpo_mpi.py#L177
I wonder if here we should use oldpi to sample trajs instead of using pi.

The trajectory segments are exactly sampled with oldpi.
As the assignment op does (
https://github.com/openai/baselines/blob/b05be68c55d416f7aa71f745aaf3c2999d83b83c/baselines/trpo_mpi/trpo_mpi.py#L215)
just after the sampling.
On Tue, Nov 28, 2017 at 1:30 PM, Jeasine Ma<EMAIL_ADDRESS>wrote:

https://github.com/openai/baselines/blob/b05be68c55d416f7aa71f745aaf3c2
999d83b83c/baselines/trpo_mpi/trpo_mpi.py#L177
I wonder if here we should use oldpi to sample trajs instead of using pi.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openai/baselines/issues/222, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOttHAwqcZoS4xAuwh-R6tt1hW0rX6Mks5s65qNgaJpZM4Qstnj
.


Timeshift can't find the .../script.sh to create a snapshot

Describe the bug
I can't create a snapshot with timeshift v22.06.5 (both cli util and gui), because it can't find the script E: AsyncTask.begin() E: Failed to execute child process “/root/.temp/zl3YQZyf/2023-04-28_19-17-26/script.sh” (No such file or directory) ^C0,00% complete (??? remaining)
(timeshift-gtk:2426): dbind-WARNING **: 19:02:13.384: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
App config loaded: /etc/timeshift/timeshift.json
Mounted '/dev/dm-0 (nvme0n1p6)' at '/run/timeshift/2426/backup'
gelerum@pc:~/ > timeshift-launcher

(timeshift-gtk:3487): dbind-WARNING **: 19:13:48.346: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
[Warning] Deleted invalid lock
App config loaded: /etc/timeshift/timeshift.json
Mounted '/dev/dm-0 (nvme0n1p6)' at '/run/timeshift/3487/backup'

(timeshift-gtk:3487): Gtk-WARNING **: 19:13:48.468: Found an icon but could not load it. Most likely gdk-pixbuf does not provide SVG support.

E: Failed to execute child process “/root/.temp/i0PPJTC6/16826840322234039557.sh” (No such file or directory)
E: Failed to estimate system size

** (timeshift-gtk:3487): CRITICAL **: 19:13:52.348: tee_jee_logging_log_error: assertion 'message != NULL' failed

** (timeshift-gtk:3487): CRITICAL **: 19:13:52.348: tee_jee_logging_log_error: assertion 'message != NULL' failed
App config saved: /etc/timeshift/timeshift.json

------------------------------------------------------------------------------
Estimating system size...
E: Failed to execute child process “/root/.temp/i0PPJTC6/16826840321777694812.sh” (No such file or directory)
E: Failed to estimate system size

** (timeshift-gtk:3487): CRITICAL **: 19:13:52.597: tee_jee_logging_log_error: assertion 'message != NULL' failed

** (timeshift-gtk:3487): CRITICAL **: 19:13:52.597: tee_jee_logging_log_error: assertion 'message != NULL' failed
App config saved: /etc/timeshift/timeshift.json
Creating new snapshot...(RSYNC)
Saving to device: /dev/dm-0, mounted at path: /run/timeshift/3487/backup
Syncing files with rsync...
E: AsyncTask.begin()
E: Failed to execute child process “/root/.temp/i0PPJTC6/2023-04-28_19-13-52/script.sh” (No such file or directory)
^C0,00% complete (??? remaining)

Steps To Reproduce

install timeshift package via home-manager or environment.systemPackages
Enable rsync option
Try to create a snapshot via GUI or timeshift --create

Additional context
I tried timeshift installed via home-manager and via configuration.nix. The same result.
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.108, NixOS, 22.11 (Raccoon), 22.11.3935.60c0f762658`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(gelerum): `""`
 - channels(root): `"nixos-22.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Fixing the "No such file or directory" issue in https://github.com/linuxmint/timeshift/compare/23.06.2...23.07.1

I tried a rsync backup and at least it runs for me now. Please file new issues if it doesn't work for you.

The same problem #247092

Yes, it is not backported to stable yet


Fix changing baudrate

Thanks for the great efforts put into this project. Great to finally see Web Serial support so this is possible 👍
Hardware:

ESP WROOM 32
CH3400 Serial IC
Macbook Late 2013

Software:

Version 89.0.4389.114 (Official Build) (x86_64)
macOS Big Sur 11.2.3

Output:
Adafruit WebSerial ESPTool loaded.
Connecting...
Connected successfully.
Try to reset.
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Timed out after 100 milliseconds
Attempting to change baud rate to 460800...
Timed out after 3000 milliseconds
Error: Didn't get enough status bytes

Try using 115200 if you're seeing this message.

Yes the 115200 is the only one that works for me. Wondering if this is a limit currently with the WebSerial or we could improve the code here ?

I think the code could be improved by adding a try block and falling back to 115200 if it errors and then retrying. I'm going to leave this open for now.

Just created this PR on NabuCasa's fork to get the baud rate to work above 115200
https://github.com/NabuCasa/ESP-Web-flasher/pull/13


Using proc-macro-hack results in unavoidable dynamic linking with libstd

This is most likely caused by unconditionally importing syntax crates that are only available as dynamic libraries.

Thanks! I released proc-macro-hack 0.4 with a fix.


clearOptions() silent option

I was just going to suggest adding the silent option to clearOptions(). I know this argument is already used elsewhere and it would benefit in situations where you would like to clear options on a selectbox because a dependency selectbox has changed but you do not want to fire onchange of the second selectbox...

+1
clearOptions calls clear which has a silent parameter, so it should have one too, to allow to propagate the choice.


New logo Sextant

Hello, I designed a logo for Sextant. I combined a navigasyon and sextant icon. I designed a logo in 2 different styles. If you like any of these, I will send you a pr.

e.g. In the readme file it will look like this;

WoW!
Just wooow! :)
I believe the first one will fit better on a nuget package.
And thank you so much for doing this.

You're welcome. I sent a pr. Please check it.
https://github.com/giusepe/Sextant/pull/18


My experience with directions on this page

[Enter feedback here]
Hello,
 Just a couple of things I discovered while trying to implement sftp server on windows.

When I tired to install the latest version from Github, I could make putty connections, but not sftp nor scp.  The error was something to the effect that no protocol was recognized, is the server running.  Thinking that maybe the github version and the client installed from the Microsoft additional options are conflicting, I uninstalled the github version.
Installing the github version installed it's version of ssh-agent for authentication.  (overwriting the Microsoft one).  Problem being, after I uninstalled, it removed this service which was there previously.
Installing the Microsoft version from windows optional features was problem some due to our enterprise using WSUS.  I had to create a policy to negate the enterprise settings thus, allowing me to install ssh-server via option features.  This did not re-create the ssh-agent service that was deleted from my github install.  I had to re-create the ssh authentication service manually.
The syntax for adding user / group permissions to the sshd_config are vague.  I found (from linux forums) that the allow users supersedes the allow groups.  Its one or the other, not both.  The example on this page is confusing on this.  For my use, I just used the allowusers and that worked.  Also, there was no clear syntax on the use of allowed users.  There should be a space between users as "allowusers user1 user2@localhost user3@remotehost"
There is no mention of how to lock down sshd to use just sftp.  In our case, we did not want users to have console access to our server.  So I found this command on other forums that allowed me to turn this functionality off.   "ForceCommand internal-sftp"

Thank you,
Shane Van Loenen
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8ad5c9a-efb1-d994-0e3c-53c90096a245
Version Independent ID: 5cb0ea97-4c3d-ffdf-b69c-8a717f9f9f3f
Content: OpenSSH Server configuration for Windows
Content Source: WindowsServerDocs/administration/OpenSSH/OpenSSH_Server_Configuration.md
Product: windows-server
Technology: administration
GitHub Login: @maertendMSFT
Microsoft Alias: damaerte

Hi @shane128 ,
Thanks for your dedication to our documentation. Firstly, just for clarity the GitHub verion of OpenSSH for Windows is a beta. Our recommendation is to the built-in version of OpenSSH, unless you are specifically testing the beta. Any issues or requests related to the beta should be raised as an issue in the Win32-OpenSSH repo, where you can follow up there. To get assistance or support for the built-in version, we recommend that you engage with the product community or open a ticket with Microsoft Support. For more information, see Contact Microsoft Support.
With regard to the product document you mention in point 4. We've submitted a documentation change based on your suggestion, and the updated article went live last week.
With regard to point 5, this isn't so much a Windows specific setting an OpenSSH configuration setting. With that in mind please refer to the OpenSSH documentation managed by developers at the OpenBSD Project OpenSSH open source project, which is strive not to duplicate. I was able to find a few community examples like this one How to Allow SFTP and disallow SSH? - Techglimpse, however we haven't tested this.
Thanks,
Robin
#please-close


Workaround to avoid problematic uninstall code path.

Use choco upgrade to workaround packages with problematic uninstall tasks (for packages using Uninstall-ChocolateyZipPackage in ChocolateyUninstall.ps1 exhibiting a behavior to delete the common folder like c:\opt\rosdeps\x64\bin).
This pull request is trying to stop the problematic uninstall path to be propagated to any newly installations.
NOTE: Here is a table when the Chocolatey scripts get triggered: https://chocolatey.org/docs/create-packages#during-which-scenarios-will-my-custom-scripts-be-triggered

would suggest commenting out (and keeping) the current commands if we plan to fix the uninstall issue and still use these commands later on; otherwise, lgtm

would suggest commenting out (and keeping) the current commands if we plan to fix the uninstall issue and still use these commands later on; otherwise, lgtm

Thanks for the suggestion. I added some comments for that.


BladeCompiler parse error

Line 808 - framework/src/Illuminate/View/Compilers/BladeCompiler.php
Somehow the variable $expression does not put the apostrophe after "layouts.app"
<?php echo $__env->make('layouts.app, array_except(get_defined_vars(), array('__data', '__path')))->render(); ?>
but should be
<?php echo $__env->make('layouts.app', array_except(get_defined_vars(), array('__data', '__path')))->render(); ?>
I solved editing the line 808 adding an apostrophe after $expression but it should not be the way to fix it.
This happens with the extends function only.

 If this is a bug, can you provide more detail?

Yes you were right. When I used @include('layouts.app') I forgot to close the quotation marks.
Thank you a lot.


[release-0.18] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

/cc knative-sandbox/source-wg-leads
/assign knative-sandbox/source-wg-leads

/ok-to-test
/lgtm
/approve


Ijulia notebook in the console

This was a little too funny for me not to open an issue about.  I just got access to a new cluster at the University of Washington, and so of course the first thing I do is load IJulia onto it!  I then run ipython notebook --profile-julia over SSH.... and this is what greets my eyes:

At first, I think to myself "Wow, an in-terminal IJulia Notebook?!  We're insane!".  Then I realize it's just because links is the only program available to handle URLs from the command line.  XD
Do we want to special-case out links so that users aren't...... underwhelmed.... by their shiny IJulia interface?  :P  Unfortunately since links doesn't support Javascript I can't do too much.

You could try connecting via 'ssh -L 8998:localhost:8998 user@remote'.
This should forward the remote IJulia port to your local computer. Then just open localhost:8998 in your local browser.
This works for me so far. Unfortunately opening a notebook results in the top right status indicator showing "Kernel busy" and entering any commands results in no answer, just showing the "in computation"-* in the cell.
Can you get any results back? If not I would open an issue for this, as I currently need this feature :(

Yes, ssh tunnels are the way to go for this.

I don't think there's much further to do on this.  If we want a warning for opening jupyter notebook with links suggesting SSH tunneling instead, that would be  Jupyter issue.


Line Style of Grid

It would be nice to be able to change the line style of the grid (solid, dashed, dotted) in the future. Unfortunately this is not possible at the moment due to a bug in react native: https://github.com/facebook/react-native/issues/3159 :(.

As a generic FYI — I am no longer able to maintain this library. I recommend checking out victory-native as it's much more maintained.


update_all with non existing field

I have problem when I am trying to use update_all method on model with non existing field.
My User model is -
class User
   include Mongoid::Document
   field :name, type: String
 end

NOTE: Here I have not included 'Mongoid::Attributes::Dynamic'
When I am trying update_all method on non existing field it is creating field on mongodb
2.1.3 :001 > User.all.to_a
 => [#<User _id: 54e855837368773ff7000000, name: "Shweta">, #<User _id: 54e855877368773ff7010000, name: "Anuja">]

2.1.3 :006 > User.where(name: 'Shweta').update_all(last_name: 'Kale')
 => {"updatedExisting"=>true, "n"=>1, "connectionId"=>20, "err"=>nil, "ok"=>1.0}

2.1.3 :007 > User.all.to_a

 => [#<User _id: 54e855877368773ff7010000, name: "Anuja">, #<User _id: 54e855837368773ff7000000, name: "Shweta">]

Documents from mongo shell
 db.users.find();
{ "_id" : ObjectId("54e855877368773ff7010000"), "name" : "Anuja" }
{ "_id" : ObjectId("54e855837368773ff7000000"), "last_name" : "Kale", "name" : "Shweta" }

It has created field last_name in mongodb
When I am trying to use update_attributes on user, its giving UnknownAttribute Error
2.1.3 :014 > User.last.update_attributes(last_name: 'Kale')
Mongoid::Errors::UnknownAttribute:

Is this bug or I am missing something?

Same thing is happening with class method 'update' as it is also calling "update_documents(attributes)" internally.

Is this intended behavior of update_all?

It is intended behavior. update_all works more like an atomic operation, so it has no checks if the field was declared or not. Whereas update_attributes will run validation/callbacks and works more on the model level.


Fix bug with -Zfeatures=dev_dep and check --profile=test.

-Zfeatures=dev_dep with cargo check --profile=test would crash because the check of whether or not dev dependencies are needed erroneously ignored the "test" flag of CompileMode::Check.  The feature resolver needs to correctly know whether or not dev-dependencies are needed.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit b112255f370a1c1bdfc2ecc484daed0d686f5b4e has been approved by alexcrichton

:hourglass: Testing commit b112255f370a1c1bdfc2ecc484daed0d686f5b4e with merge 71fbc99323c59429a040fc460abae5e88c0697ea...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 71fbc99323c59429a040fc460abae5e88c0697ea to master...


Foundational Test Support

Description
Updated extension to use and pass using the new FoundationalHarnessSuite suite

This work was duplicated in other PRs which were later merged to main


Feature/common plugin code

@nigelramsay yeah, this is because the webpage-tools code has been added to magento as a file, rather than as an npm package, which seems to have different minification rules. I can show you tomorrow, it's hard to explain.


sqlite3_column_text may return non-utf-8, rusqlite does not allow to handle it

we got a real-life case where the lines at https://github.com/jgallagher/rusqlite/blob/master/src/statement.rs#L625 cause a panic because sqlite3_column_text can indeed contain non-utf8. FWIW the sqlite3 docs  https://www.sqlite.org/version3.html say this:

SQLite is not particular about the text it receives and is more than happy to process text strings that are not normalized or even well-formed UTF-8 or UTF-16. Thus, programmers who want to store IS08859 data can do so using the UTF-8 interfaces. As long as no attempts are made to use a UTF-16 collating sequence or SQL function, the byte sequence of the text will not be modified in any way.

In our case we are reading from a database that was created/populated by a non-rust program so we can't change the fact that a text column contains non-utf8.  We'd like to handle the invalid case ourselves -- could the API be amended?  any recommendations on how we could work around the issue?

According to https://www.sqlite.org/capi3ref.html#sqlite3_column_blob sqlite3_column_text does return utf-8 strings

but it might be better to change the code slightly according to the above documentation

The safest policy is to invoke these routines in one of the following ways:
sqlite3_column_text() followed by sqlite3_column_bytes()
sqlite3_column_blob() followed by sqlite3_column_bytes()
sqlite3_column_text16() followed by sqlite3_column_bytes16()

I guess we need to change:
https://github.com/jgallagher/rusqlite/blob/master/src/types/value_ref.rs#L110
impl<'a> ValueRef<'a> {
    pub(crate) unsafe fn from_value(value: *mut crate::ffi::sqlite3_value) -> ValueRef<'a> {

to:
impl<'a> ValueRef<'a> {
    pub(crate) unsafe fn from_value(value: *mut crate::ffi::sqlite3_value) -> FromSqlResult<ValueRef<'a>> {

Fix:
                // sqlite3_value_text returns UTF8 data, so our unwrap here should be fine.
                let s = s
                    .to_str()
                    .expect("sqlite3_value_text returned invalid UTF-8");

And update callers accordingly.

This might be a case where using something like https://github.com/BurntSushi/bstr rather than str is appropriate. (Once it's API is stable enough for that purpose, at least -- at the moment it's recommended against exposing publically)

Should be fixed by release 0.20.


fix to pvlib/spa.py for issue #2077

[X] PR to fix issues #2077
[X] Tests added - details in this gist https://gist.github.com/dgapitts/a8749b5b9aa5413f350606314d48fb1b
[X] I am familiar with the contributing guidelines

Thanks @dgapitts.  Ideally the verification with expected values would be included as a new test in pvlib's test suite.  Would you like to add that to this PR as well?  I am happy to provide guidance if so.

Sure @kandersolar I can add the tests to pvlib/tests/test_spa.py  I see there is already def test_julian_day_dt(self) but

This only contains a single assert_almost_equal check - which was passing despite issue #2077
Makes sense to me to add some or all of the following tests within  def test_julian_day_dt(self)

tests = [
    ((2000, 1, 1, 12, 0, 0), 2451545.0),
    ((1999, 1, 1, 0, 0, 0), 2451179.5),
    ((1987, 1, 27, 0, 0, 0), 2446822.5),
    ((1987, 6, 19, 12, 0, 0), 2446966.0),
    ((1988, 1, 27, 0, 0, 0), 2447187.5),
    ((1988, 6, 19, 12, 0, 0), 2447332.0),
    ((1900, 1, 1, 0, 0, 0), 2415020.5),
    ((1600, 1, 1, 0, 0, 0), 2305447.5),
    ((1600, 12, 31, 0, 0, 0), 2305812.5),
    ((837, 4, 10, 7, 12, 0), 2026871.8),
    ((-123, 12, 31, 0, 0, 0), 1676496.5),
    ((-122, 1, 1, 0, 0, 0), 1676497.5),
    ((-1000, 7, 12, 12, 0, 0), 1356001.0),
    ((-1000, 2, 29, 0, 0, 0), 1355866.5),
    ((-1001, 8, 17, 21, 36, 0), 1355671.4),
    ((-4712, 1, 1, 12, 0, 0), 0.0),
]

I agree, adding all the cases makes sense.  I suggest creating a new test function at the bottom of the test_spa.py file, rather than trying to integrate these new test cases with the existing code.  The tests in test_spa.py use the old unittest style, but new tests should use pytest.  Something like this: https://github.com/pvlib/pvlib-python/blob/main/pvlib/tests/test_shading.py#L229-L309

I've written the extra tests in a separate file.
(.venv) ~/projects/pvlib-python bugfix/issue-2077 $ cat tests_issue_2077.py
# test_sample.py

import pvlib
import pytest

# Define the test cases as parameters
test_cases = [
    ((2000, 1, 1, 12, 0, 0), 2451545.0),
    ((1999, 1, 1, 0, 0, 0), 2451179.5),
    ((1987, 1, 27, 0, 0, 0), 2446822.5),
    ((1987, 6, 19, 12, 0, 0), 2446966.0),
    ((1988, 1, 27, 0, 0, 0), 2447187.5),
    ((1988, 6, 19, 12, 0, 0), 2447332.0),
    ((1900, 1, 1, 0, 0, 0), 2415020.5),
    ((1600, 1, 1, 0, 0, 0), 2305447.5),
    ((1600, 12, 31, 0, 0, 0), 2305812.5),
    ((837, 4, 10, 7, 12, 0), 2026871.8),
    ((-123, 12, 31, 0, 0, 0), 1676496.5),
    ((-122, 1, 1, 0, 0, 0), 1676497.5),
    ((-1000, 7, 12, 12, 0, 0), 1356001.0),
    ((-1000, 2, 29, 0, 0, 0), 1355866.5),
    ((-1001, 8, 17, 21, 36, 0), 1355671.4),
    ((-4712, 1, 1, 12, 0, 0), 0),
]

# Use pytest to parametrize the test
@pytest.mark.parametrize("inputs, expected", test_cases)
def test_julian_day(inputs, expected):
    result = pvlib.spa.julian_day_dt(*inputs, microsecond=0)
    assert result == expected, f"Failed for inputs {inputs}: expected {expected}, got {result}"

(.venv) ~/projects/pvlib-python bugfix/issue-2077 $ pytest tests_issue_2077.py
===================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.12.4, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/davidpitts/projects/pvlib-python-orig
configfile: pyproject.toml
plugins: anyio-4.6.0
collected 16 items

tests_issue_2077.py ................                                                                                [100%]

====================================================================================== 16 passed in 0.38s ======================================================================================

However when I append this test to  test_spa.py to avoid this error:
(.venv) ~/projects/pvlib-python bugfix/issue-2077 $ pytest pvlib/tests/test_spa.py
===================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.12.4, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/davidpitts/projects/pvlib-python-orig
configfile: pyproject.toml
plugins: anyio-4.6.0
collected 0 items / 1 error

============================================================================================ ERRORS ============================================================================================
___________________________________________________________________________ ERROR collecting pvlib/tests/test_spa.py ___________________________________________________________________________
pvlib/tests/test_spa.py:386: in <module>
    class NumbaSpaTest(unittest.TestCase, SpaBase):
pvlib/tests/test_spa.py:447: in NumbaSpaTest
    @pytest.mark.parametrize("inputs, expected", test_cases_issue_2207)
E   NameError: name 'pytest' is not defined
=================================================================================== short test summary info ====================================================================================
ERROR pvlib/tests/test_spa.py - NameError: name 'pytest' is not defined
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
======================================================================================= 1 error in 0.10s =======================================================================================

So git stI had to add the import pytest
(.venv) ~/projects/pvlib-python bugfix/issue-2077 $ pytest pvlib/tests/test_spa.py
===================================================================================== test session starts ======================================================================================
platform darwin -- Python 3.12.4, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/davidpitts/projects/pvlib-python-orig
configfile: pyproject.toml
plugins: anyio-4.6.0
collected 87 items

pvlib/tests/test_spa.py ..........................................sssssssssssssssssssssssssssssssssssssssssssss                                                                          [100%]

================================================================================ 42 passed, 45 skipped in 0.06s ================================================================================

Thanks @dgapitts, that's pretty much what I was imagining.  A few tweaks are needed:

de-indent the test so that it is stand-alone code at the end of the file, rather than included in the NumbaSpaTest class
I think you will need to import pvlib at the top of the file
the linter check will complain until all lines of code are 79 characters or shorter.  Right now the line with the assert is too long.  It's fine to just remove that long string; if the assertion ever fails, pytest will show basically the same information anyway.

I have pushed a commit (correct-test-indention-and-class) as requested @kandersolar.
I was having some issues with my local python venv, fix now and tests working locally again:

(.venv) ~/projects/pvlib-python bugfix/issue-2077 $ pytest  pvlib/tests/test_spa.py
================================================================================================ test session starts =================================================================================================
platform darwin -- Python 3.12.4, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/davidpitts/projects/pvlib-python
configfile: pyproject.toml
plugins: anyio-4.6.2.post1
collected 102 items
pvlib/tests/test_spa.py ..........................................ssssssssssssssssssssssssssssssssssssssssssss................                                                                                [100%]
=========================================================================================== 58 passed, 44 skipped in 0.06s ===========================================================================================
(

@dgapitts you can ignore the failure for that "Top Ranked Issues" action.

There is also a linter error:
Run git diff upstream/$GITHUB_BASE_REF HEAD -- "*.py" | flake8 --exclude pvlib/version.py --ignore E201,E241,E226,W503,W504 --max-line-length 79 --diff
Error: pvlib/tests/test_spa.py:430:1: E305 expected 2 blank lines after class or function definition, found 1
Error: pvlib/tests/test_spa.py:449:1: E302 expected 2 blank lines, found 1
Error: Process completed with exit code 1.

added commit fix-linting-errors-add-blank-lines to address this

2 blank lines before a function, one blank line at the end of a file.

thank you  @dgapitts!


window.showOpenDialog returns an empty Array ([ ]) when canceled

VSCode Version: 1.39.0-insider
OS Version: Windows 10

Steps to Reproduce:

Show an openDialog
Hit cancel without selecting a folder
The return value is [] (used to be undefined)

Does this issue occur when all extensions are disabled?: Yes/No

@isidorn you also were close to this code.


Deeper-spotbugs check

Increase the efficiency to check the spot bugs

[X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[X] Ensure that the pull request title represents the desired changelog entry
[X] Please describe what you did

Unresponsive.


feat: push subcommand for model command

Notes for Reviewers
This PR fixes #

Adds Push subcommand to push model to OCI Registry

Signed commits

[x] Yes, I signed my commits.

@RipulHandoo will you update the slide that covers this behavior in the Meshery Architecture deck?

merge conflict

@RipulHandoo merge conflict

A few lint checks are standing in the way, it seems.

Move the pull and push logic to MeshKit as they will be used heavily across components.
Can you please add tests for pushing and pulling to public OCI registries?

Sure, I can add tests for pushing and pulling models to public OCI registries. However, to properly authenticate and test these functionalities, we'll need access to a username and password.


Students wanting to delete a valid group need to know to contact instructor

Once students form a valid group, there is no longer a button to delete the group.  There should be a note telling them that if they want to delete the group, they need to contact the instructor to change group membership or remove the group.

@tsimica This should be included in the group properties panel.


vc++11 folly build error

Hello jbandela,
Sorry to bring this question here as I couldn't open issue on your VC++11 folly project: https://github.com/jbandela/folly/tree/vc11
I try to build with Visual Studio 2015 but I got the error  'folly-config.h': No such file or directory
Steps I did:
1> Use generate_escape_tables.py to generate EscapeTables.cpp
2> Use generate_format_tables.py to generate FormatTables.cpp
3> Use generate_varint_tables.py to generate GroupVarintTables.cpp
4> Change "#include x86intrin.h" to "#include intrin.h" in GroupVarintTables.cpp
5> Include folder "folly-vc11" to "Include Directories" in VS2015
6> Include folder "folly-vc11\double-conversion\src" to "Include Directories" in VS2015
7> Include folder "boost_1_62_0" to "Include Directories" in VS2015
8> Build
I got the below errors when building. How to solve it?
Thank you in advance
1>------ Build started: Project: follyvc11lib, Configuration: Release Win32 ------ 1>  FormatTables.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  GroupVarintTables.cpp 1>..\..\..\folly\build\GroupVarintTables.cpp(264): warning C4838: conversion from 'unsigned __int64' to 'char' requires a narrowing conversion 1>..\..\..\folly\build\GroupVarintTables.cpp(264): warning C4305: 'initializing': truncation from 'unsigned __int64' to 'char' 1>..\..\..\folly\build\GroupVarintTables.cpp(264): warning C4309: 'initializing': truncation of constant value 1>  Conv.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  dynamic.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  Format.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  json.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  Malloc.cpp 1>f:\programming_language\c++\1_libs\folly-vc11\folly\Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  Range.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  String.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory 1>  Unicode.cpp 1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal error C1083: Cannot open include file: 'folly-config.h': No such file or directory ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Hi Mark-Joy,
To be honest the fork was created for Visual C++ 2012 which did not even
have variadic template or unrestricted unions. Visual C++ 2015 pretty much
supports C++11. I actually think it would be easier and more robust to
adapt current folly to Visual C++ 2015. The biggest thing you would have to
do is remove a few gcc extensions mainly where they are using jemalloc
John
On Sat, Oct 29, 2016, 1:42 AM Mark-Joy<EMAIL_ADDRESS>wrote:

Hello jbandela,
Sorry to bring this question here as I couldn't open issue on your VC++11
folly project: https://github.com/jbandela/folly/tree/vc11
I try to build with Visual Studio 2015 but I got the error
'folly-config.h': No such file or directory
Steps I did:
1> Use generate_escape_tables.py to generate EscapeTables.cpp
2> Use generate_format_tables.py to generate FormatTables.cpp
3> Use generate_varint_tables.py to generate GroupVarintTables.cpp
4> Change "#include " to "#include " in GroupVarintTables.cpp
5> Include folder "folly-vc11" to "Include Directories" in VS2015
6> Include folder "folly-vc11\double-conversion\src" to "Include
Directories" in VS2015
7> Include folder "boost_1_62_0" to "Include Directories" in VS2015
8> Build
I got the below errors when building. How to solve it?
Thank you in advance
1>------ Build started: Project: follyvc11lib, Configuration: Release
Win32 ------
1> FormatTables.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> GroupVarintTables.cpp
1>......\folly\build\GroupVarintTables.cpp(264): warning C4838:
conversion from 'unsigned __int64' to 'char' requires a narrowing conversion
1>......\folly\build\GroupVarintTables.cpp(264): warning C4305:
'initializing': truncation from 'unsigned __int64' to 'char'
1>......\folly\build\GroupVarintTables.cpp(264): warning C4309:
'initializing': truncation of constant value
1> Conv.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> dynamic.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> Format.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> json.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> Malloc.cpp
1>f:\programming_language\c++\1_libs\folly-vc11\folly\Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> Range.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> String.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
1> Unicode.cpp
1>F:\Programming_Language\C++\1_Libs\folly-vc11\folly/Malloc.h(54): fatal
error C1083: Cannot open include file: 'folly-config.h': No such file or
directory
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jbandela/cppcomponents/issues/4, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnz9NP7NP3p2vYruq_syFihCm1rS_f6ks5q4wbjgaJpZM4KkD52
.

Thank you for your project :)
I just generated the file folly-config.h and got your project built successfully under VC++ 2015. I need only the folly/format lib (latest version is the best but old version is still fine to me).
Tried to combine latest folly under MSYS2 and MINGW-W64, but I got some errors.
For now I will stick to your project only. Will try to port latest folly to VC++ 2015 if I have some free time.

Thanks for the kind words and the feedback. If all you are interested in is
folly format, take a look at fmtlib.
https://github.com/fmtlib/fmt/blob/master/README.rst
On Sat, Oct 29, 2016, 9:01 PM Mark-Joy<EMAIL_ADDRESS>wrote:

Thank you for your project :)
I just generated the file folly-config.h and got your project built
successfully under VC++ 2015. I need only the folly/format lib (latest
version is the best but old version is still fine to me).
Tried to combine latest folly under MSYS2 and MINGW-W64, but I got some
errors.
For now I will stick to your project only. Will try to port latest folly
to VC++ 2015 if I have some free time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jbandela/cppcomponents/issues/4#issuecomment-257130726,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnz9HM4jxUp_rLU--QaEancvWVFbDYfks5q5BaIgaJpZM4KkD52
.


Adding support for organizations settings

Optional settings resource creation.
Updated to github provider 5.x

Duplicated PR #51


EPG does not comply with node.js version 22

Describe your issue
Trying to install EPG in docker with
Ubuntu 22.04 and
node.js v22 but fails with

[15/15] RUN npm install:
10.32 npm error code 1
10.32 npm error path /iptv/epg/node_modules/libxmljs2
10.32 npm error command failed
10.32 npm error command sh -c node-pre-gyp install --fallback-to-build --loglevel http
10.32 npm error make: Entering directory '/iptv/epg/node_modules/libxmljs2/build'
10.32 npm error   CXX(target) Release/obj.target/xmljs/src/libxmljs.o
10.32 npm error make: Leaving directory '/iptv/epg/node_modules/libxmljs2/build'

BUT node.js v21 installs alright with few warnings only...
Hence, node.js v22 is yet to be tested?
All the best.

You can workaround this issue by installing latest version of libxmljs2 (0.35.0).
npm install libxmljs2@latest
npm update


traffic-gen: Add verbose prints to trex daemon

This option is available after upgrade to v3.02
depends on #82

We may want to not merge this change, as it can slow the trex operation.

Removing this PR, we don't have any other trex issues at the moment.


Add comdex cerberus and bitsong

add comdex chain, dont set DNS yet. Wait to switch to 1 level sub domain instead of 2 levels to make it easier to add new chain.

could not find snapshot for bitsong, have to run state-sync

DNS set


README Documentation Update Required

Bug report
Documentation update:
config.ini should be updated to .env in accept-a-payment/prebuilt-checkout-page/server/php/README.md
Describe the bug
The accept-a-payment/prebuilt-checkout-page/server/php/README.md references config.ini instead of .env.
Also make a note that .env.example is above the server folder and the copied .env should be in the server folder.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Navigate to https://github.com/stripe-samples/accept-a-payment/tree/main/prebuilt-checkout-page/server/php to see the README.md.
Expected behavior
config.ini should be changed to .env and config.ini.sample to .env.example.
Screenshots
System information
Additional context

Thank you!


added windows 11 and arranaged in order

after reading this article, i confirmed windows 11 is supported

Learn Build status updates of commit ed1c5e9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/security-policy-settings/access-this-computer-from-the-network.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit edc0d2d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/security-policy-settings/access-this-computer-from-the-network.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add support for registry definition in package.json publishConfig

Currently if an alternative/private registry is defined in package.json publishConfig, npmjs.org registry will still be used.
This adds support by reading the registry field in package.json and passing it to npm view with the --registry argument.
Added tests using the Yarn registry as an alternative registry.

1.2.0  is released.


MacOS 13.5.2 with Java

Type: Bug
I am getting the issue "The import {importName} cannot be resolved" for every single import and also this issue too, "The project was not built since its build path is incomplete. Cannot find the class file for java.lang.Object. Fix the build path then try building this project".
This error occured whenever I updated my MacOS system to version 13.5.2; I've tried doing the java clean solution, restarting vsCode and Macbook but none of that has worked
VS Code version: Code 1.82.1 (Universal)<PHONE_NUMBER>d557a81c9d0b5f8a5a1e9274db5585, 2023-09-08T08:49:32.930Z)
OS version: Darwin arm64 22.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 2, 5

Memory (System)
16.00GB (0.26GB free)

Process Argv
--crash-reporter-id 4bdc99a4-0aa5-4114-bf7e-a60cd80ff63e

Screen Reader
no

VM
0%

Extensions (43)

Extension
Author (truncated)
Version

ng-template
Ang
16.1.8

bracket-pair-colorizer-2
Coe
0.2.4

doxdocgen
csc
1.4.0

vscode-eslint
dba
2.4.2

css-flexbox-cheatsheet
dzh
3.3.3

gitlens
eam
14.3.0

vscode-html-css
ecm
1.13.1

prettier-vscode
esb
10.1.0

auto-rename-tag
for
0.1.10

code-runner
for
0.12.0

live-sass
gle
6.1.1

Angular2
joh
16.0.1

git-graph
mhu
1.30.0

vscode-scss
mrm
0.10.0

vscode-docker
ms-
1.26.0

csharp
ms-
2.1.2

vscode-dotnet-runtime
ms-
1.7.2

isort
ms-
2023.10.1

python
ms-
2023.16.0

vscode-pylance
ms-
2023.9.10

jupyter
ms-
2023.8.1002501831

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.309.0

cmake-tools
ms-
1.15.31

cpptools
ms-
1.17.5

cpptools-extension-pack
ms-
1.3.0

material-icon-theme
PKi
4.30.1

java
red
1.22.0

LiveServer
rit
5.7.9

vsfire
tob
1.4.1

vscode-pets
ton
1.25.0

cmake
twx
0.0.17

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.2.30

vscode-java-debug
vsc
0.54.0

vscode-java-dependency
vsc
0.23.1

vscode-java-pack
vsc
0.25.14

vscode-java-test
vsc
0.39.1

vscode-maven
vsc
0.42.0

quokka-vscode
Wal
1.0.564

markdown-all-in-one
yzh
3.5.1

html-css-class-completion
Zig
1.20.0

(4 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30792226
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30803845
282f8724:30602487
f6dab269:30613381
vscrp:30673768
showlangstatbar:30737416
962ge761:30835153
a2ce3375:30757347
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxptcf:30805731
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076
diffeditorv1:30821571
dsvsc015cf:30829746

/extJava

It looks like this is caused by the Java extension. Please file the issue to the Java extension repository. Make sure to check their troubleshooting instructions and provide relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

See https://github.com/redhat-developer/vscode-java/issues/3287.
Related on Stack Overflow: Why is my build path suddenly incomplete for my java project in VS Code?, where I have written up an answer post.


[FEATURE] Add PacketRusher version as tags

As the project continues to grow and more features are added, it would be useful to have the possibility to clone specific versions of this software. Adding tags to specific versions could facilitate users to clone this versions.
Also this tags can be setup along with the Releases.

Hi @Borjis131,
Thanks for the suggestion. We haven't been doing that for now as we didn't really make our first official release. We wanted to tackle #76 / #31 before making our first tag / release, but I'll keep in mind that our users are interested in more frequent tags.
Thanks!
Valentin

Thank you, great work @linouxis9!

Hello @linouxis9, I saw that the current PacketRusher version is 1.0.1. So it seems that the release is more or less official now?
I reach to you because I had a problem using the Docker version that is difficult to solve without having the version as tags.
The Docker container needs the gtp5g module installed on the host machine and the Docker version of PacketRusher was using a different compiled version of PacketRusher. So without having the same version on both places, is difficult to check if the versions match or not.
So, please, if the release is official, consider adding the version as a tag and a release. If not, just keep working, you are already doing a great job!

Hi @Borjis131!
I understand your concern and issue! As such, I've created a tag 20240521: https://github.com/HewlettPackard/PacketRusher/releases/tag/20240521
Does it solve your issue for the time being?
Sadly, PacketRusher is not yet ready for a v1.0.0, and I would like for PacketRusher to respect semver principles, so I would like to avoid to release a v1.0.0 for now, and considering the continuous developement cycle (each commit is usually better than the previous one and fix some issues), I feel releasing from time to time v0.a.b do not make too much sense.
Or we could tag a version each time we do a commit, à la https://github.com/ggerganov/llama.cpp/releases :D
Actually, PacketRusher has reported itself as being v1.0.1 since its open source release.
Does the tag 20240521 work for you (but PacketRusher still reports itself as v1.0.1)? Or would you prefer PacketRusher to output the commit it was built from?
We might want to add inside PacketRusher a check for the correct version of gtp5g maybe as well?
Thanks a lot for using PacketRusher, I hope I can help you :-)!
Valentin


react-i18next:: You will need pass in an i18next instance by using initReactI18next

Describe the bug
There is an ongoing discussion under a closed issue which affects several users including me.
Translations are not available after following the instructions in the README and the example files.
Occurs in next-i18next version
next: 10.0.8,
next-i18next: 8.1.1

There are a number of ways to arrive at that error, which is why a number of users are experience the same output. If you believe you have found a bug within the source code of next-i18next, please do feel free to open an issue. Good luck!

Same here, I've followed the docs again and again.
"next": "10.0.9",
"next-i18next": "^8.1.2",

@giacomoalonzi I happened to have the same problem, which turns out that I have accidentally imported the react-i18next rather than next-i18next.

@pot-code already checked. This is not my case. :\

I also encountered this problem and spent several hours digging through next-i18next code and my own code using react-i18next. I found when I add:
const { initReactI18next } = require('react-i18next');
to next-i18next.config.js and use this module in config:
module.exports = {   (...) use: [  initReactI18next ], }
all starts working like a charm. But this should be done by next-i18next every time. Possibly some version incompatibility?
"react-i18next": "^11.8.11"
"next-i18next": "^8.1.2",

ok, this is my config
next.config.js
const { i18n } = require('./next-i18next.config');

module.exports = {
  i18n,
};

next.config.js
const { i18n } = require('./next-i18next.config');

module.exports = {
  i18n,
};

next-i18next.config.js
module.exports = {
initReactI18next: {
defaultLocale: 'it',
locales: ['it'],
},
};

__app.tsx
import { appWithTranslation } from 'next-i18next';
function MyApp({ Component, pageProps }: AppProps) {
return (
<Component {...pageProps} />
);
}
export default appWithTranslation(MyApp);

this is my config, followed the docs. :\

@giacomoalonzi Check your page-level getServerSideProps too. Ensure that props _nextI18Next sent into your component.

Hello guys. I have the same config as @giacomoalonzi wrote above, and I also followed the rules from the Readme.
Tried to provide getServerSideProps to page-level components and it gives an error in the terminal
error - ./node_modules/next-i18next/dist/commonjs/serverSideTranslations.js:36:0
Module not found: Can't resolve 'fs'

I totally forgot to use the SSR function. I've added
import { serverSideTranslations } from 'next-i18next/serverSideTranslations';
export const getServerSideProps = async ({ locale }: any) => ({
  props: {
    ...(await serverSideTranslations(locale, ['common', 'car-types'])),
  },
});

and all works! Thanks for the support guys!

SUMMARY: Confusion (at least in my case) was that useTranslation is contained in both react -i18next and next-i18next. I started introducing Next.JS into older code that used react-i18next. You have to either switch to next-i18next completely, or you have to configure next-i18next to properly initialize react-i18next as shown below:
I also encountered this problem and spent several hours digging through next-i18next code and my own code using react-i18next. I found when I add:
const { initReactI18next } = require('react-i18next');
to next-i18next.config.js and used this module in config:
module.exports = { (...) use: [ initReactI18next ], }
all starts working like a charm.

could you show your whole module code perhaps?


Overlord

@athiercelin Take a look at Daniel's comments (and sorry for the delay on reviewing this). You are already on a team, so I don't feel it is necessary for you to work on a second iteration unless you want to, or have the time to do so.


Added policies to verifyPresentation in credential-w3c module

What issue is this PR fixing
partially fixes #954
What is being changed
Adding the IVerifyPresentionResponse interface in the credential-w3c module to be able to implement better error handling, the new interface allows the errors to be communicated through an Object containing fields, verified, details, errorCode.

verified defines the state of the verification process, whether it failed or is passed.
details contains details regarding the failure for the verification process.
errorCode can be used to pass machine readable errorCodes from the lower level modules.

Quality
Check all that apply:

[X] I want these changes to be integrated
[X] I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
[X] I allow my PR to be updated by the reviewers (to speed up the review process).
[X] I added unit tests.
[ ] I added integration tests.

Details
Was unable to find specific verification tests in the action-handler.test.ts in the credentials-w3c module so created another test suite like in credentialLD module for issue-verify-flow.

@mirceanis I was wondering whether you'd prefer if I create a IVerifyResponse as a type in Veramo core which will have a general verified and error fields. This can be used generally in all Verification APIs in separate modules.

@mirceanis I was wondering whether you'd prefer if I create a IVerifyResponse as a type in Veramo core which will have a general verified and error fields. This can be used generally in all Verification APIs in separate modules.

Yes, that sounds like a good idea, although IVerifyResult fits the action better, since these are not actually request/response pairs.

I think even if I proceed to create separate PRs for the credential-ld and credential-eip712 modules. I would still need to refactor the verifyPresentationLD to support the current PR because the else clause responds with the LD verification. Which I believe is incompatible with the current IVerifyResult Response.

If we align on the approach, then I think it would not take long to implement similar logic for all the verify* methods.


Use EditorConfig files to encourage/assist in resolving whitespace inconsistencies

I suggest using EditorConfig to encourage/assist with whitespace inconsistencies throughout this project. @Bartvds already spoke out about how we can't all agree on indentation settings, so those would be set in their respective sub-directories.
At the project root, we can have the following settings:
root = true

[*.ts]
trim_trailing_whitespace = true
insert_final_newline = true

Then, in each respective folder, they can have their own indentation settings without root = true, which means the root settings apply to all sub-directories, but not the other way around, like so:
[*.ts]
indent_style = tab

Or for spaces:
[*.ts]
indent_style = space
indent_size = 4

This ensures we're not stepping on anybody's toes.

Thanks for removing this from the pull request.

:+1:
I like this style. it is VisualStudio's default. (isn't it?)
root = true

[*.ts]
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 4

@vvakame I like tabs, so it's the age-old war. If you like the configuration you've specified, all you have to do is add the following to the sub-folders you submit to DefinitelyTyped:
[*.ts]
indent_style = space
indent_size = 4

Since root = true isn't defined, EditorConfig will keep looking up the folder structure until it finds an .editorconfig file with root = true, which it would at the project root. This means your configuration will be merged with the one at the project root, resulting in your exact configuration.
Make sense?

@vvakame BTW you can use ini as the file format for code coloration in EditorConfig files on GitHub.

:+1:

I would propose to use 2 spaces as done in the airbnb/javascript styleguide ...


Add tests to proposed new builtin async_copy functions

The builtin functions that are tested:
event_t async_work_group_copy_2D2D(
__local gentype *dst,
const __global gentype *src,
size_t  num_elements_per_line,
size_t  num_lines,
size_t  src_stride,
size_t  dst_stride,
event_t  event
)
event_t async_work_group_copy_2D2D(
__global gentype *dst,
const __local gentype *src,
size_t  num_elements_per_line,
size_t  num_lines,
size_t  src_stride,
size_t  dst_stride,
event_t  event
)
event_t async_work_group_copy_3D3D(
__local gentype *dst,
const __global gentype *src,
size_t  num_elements_per_line,
size_t  num_lines,
size_t  src_line_stride,
size_t  dst_line_stride,
size_t  num_planes,
size_t  src_plane_stride,
size_t  dst_plane_stride,
event_t  event
)
event_t async_work_group_copy_3D3D(
__global gentype *dst,
const __local gentype *src,
size_t  num_elements_per_line,
size_t  num_lines,
size_t  src_line_stride,
size_t  dst_line_stride,
size_t  num_planes,
size_t  src_plane_stride,
size_t  dst_plane_stride,
event_t  event
)
void async_work_group_copy_fence(clk_mem_fence_flags flags)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Omer Paparo Bivas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.

Superseded by #725 where all the above comments have been addressed.


Cleaner juno/app

Overview
Create app/upgrades dir to have all the upgrades in one place with versions and abstract out all keepers to app/keepers to make the the app/app.go cleaner and more maintainable.
Problem Definition
app/app.go is too big file.
Proposal
split app/app.go into app.go, upgrade/, keepers/ , module.go
ref:
osmosis/app
provenance/app

Hi there! I really liked your PR for the hub, this one:

https://github.com/cosmos/gaia/pull/1580

I have been in seoul and unable to give it a proper review.
Are the osmo and provenance styles different?
Point blank: I agree with you.

@faddat - refactor useful? might be some good practice to get warm

@faddat provenance style is a little different in the sense they define there upgrades as a map with values as the upgrade function like this, then they have functions to deal with this map and create handlers out of this.
In osmo this is more modular and we create a package itself per upgrade version, instead of a key value in map.
I prefer the osmo way since it is cleaner and will be able to do alot more, includig handling forks better as well

I'm very happy ot use the osmo style :D


Issue 8084 - Consistent map naming

Changed all map names corresponding to their ingame type to avoid confusion
Tweak: Tweaked map filenames, ids and paths, to [name]_station for stations and [name]_ship for spaceships, for the sake of consistency
Screenshots

Before:

After:

Oh god I can smell the conflicts.
Anyhow, we throwing PascalCase out the window for map IDs? All other IDs are in that format and imo having an underscore in is an extra character we don't need. But whatever the maintainers decide.

I think i'll just try again with this issue

It was a valiant effort. Feel free to discuss it in the cartography discord channel


Basic Auth & Security Schemes

Hi,
Are the security schemes working on these test apps? I can see that the user docket has only read  only access and is set to Basic Auth, so shouldn't a user be prevented from invoking the POST createUser endpoint?
I have run boot-swagger & spring-java and on each demo was able to create and delete users.
Thanks
Tom

@tomb50 these demos are woefully out of date. They need to be updated to the latest released version

@dilipkrish Ahh okay, thanks for confirming.

The demos should be uptodate as of 2.3.1 atleast

h i, i need basic authentication using springfox. here iam not able to find proper code for that .i am completely new to swagger just i need a code which works with basic authentication.
any help ?

There isn't one right now. However, you could try using jhipster to generate a project that helps.


Image and video cards no longer get rendered in Facebook Messenger

Version
4.8.0
Describe the bug
I am using the new (preview) Microsoft.Bot.Builder.Adapters.Facebook.FacebookHelper and image or video cards no longer seem to be shown in Facebook messenger. I noticed the serialization of attachments is now done differently and disregards any property at the Attachment object level (except Content).
Source: Microsoft.Bot.Builder.Adapters.Facebook.FacebookHelper
Method: ActivityToFacebook
if (activity.Attachments != null && activity.Attachments.Count > 0)             {                 var payload = JsonConvert.DeserializeObject<AttachmentPayload>(JsonConvert.SerializeObject(                     activity.Attachments[0].Content,                     Formatting.None,                     new JsonSerializerSettings                     {                         NullValueHandling = NullValueHandling.Ignore,                     }));                 var facebookAttachment = new FacebookAttachment                 {                     Type = activity.Attachments[0].ContentType,                     Payload = payload,                 };                 facebookMessage.Message.Attachment = facebookAttachment;           }
It seems you only pick one attachment, and you serialize the Content property inside attachment which disregards all other properties that can be defined at Attachment level such as mediaUrl etc..
Expected behavior
Images and videos should be displayed in the chat on Facebook messenger.
Additional context
I took a look at Facebook messenger API and it seems that the assets (images and videos) cannot have any more external URLs.
Reference: https://developers.facebook.com/docs/messenger-platform/send-messages/template/media#url
They need to be previously uploaded to Facebook or using an API to add attachments and then use the attachment ID referenced in the message.
Is this something that the bot framework will address in the future?
[bug]

@Tiagojaduarte
My apologies on the delay. I'm looking into this today.


[hw,uart] Change the uart0 pins

This PR only changes the UART0 RX/TX pins from IOC10/IOC11 to IOC3/IOC4 in order to match the tapeout.
Closes #8355

this looks good to me, but tagging @msfschaffner to double check.

@doreis-lowrisc can you also update sw/device/silicon_creator/lib/drivers/pinmux.c and sw/device/silicon_creator/lib/drivers/pinmux_unittest.cc? Thanks!

@alphan if we forget that update, one of the verilator tests in CI "should" fail right? Because the PASS message will never come out?

@doreis-lowrisc can you also update sw/device/silicon_creator/lib/drivers/pinmux.c and sw/device/silicon_creator/lib/drivers/pinmux_unittest.cc? Thanks!

@alphan if we forget that update, one of the verilator tests in CI "should" fail right? Because the PASS message will never come out?

I think so. But even before that software build should fail because of the unittest failure.
We used to have a production ROM based test in CI which would also fail but we recently disabled it in #8697 (temporarily, tracked in #8902) to unblock e2e tests and it wouldn't be feasible to perform two signature verifications in verilator (rom->rom_ext->owner).

One last thing: I believe you also need to adjust the UART mapping in the Verilator testbench, as otherwise the sim gets stuck:
https://github.com/lowRISC/opentitan/blob/3cf0831f67d7adc16171f182f32961361ce5d981/hw/top_earlgrey/rtl/chip_earlgrey_verilator.sv#L95
https://github.com/lowRISC/opentitan/blob/3cf0831f67d7adc16171f182f32961361ce5d981/hw/top_earlgrey/rtl/chip_earlgrey_verilator.sv#L101-L102
You can use the MioPadIoc3 and MioPadIoc4 enums for indexing.

Additionally, since #9368 merged, you will want to rebase this on master, otherwise sw/device/tests/sim_dv/uart_tx_rx_test.c may revert to using the old test framework.

@doreis-lowrisc let me know if you need help with this PR. the DV folks from Nuvoton have asked for the updated UART mapping that is aligned with the pinout, so it would be good if we can land this soon.

@doreis-lowrisc let me know if you need help with this PR. the DV folks from Nuvoton have asked for the updated UART mapping that is aligned with the pinout, so it would be good if we can land this soon.

@msfschaffner I do need some help. I'm stuck with some unit tests failing on CI, however when I tested them locally on the Master branch they also failed (uart_tx_rx_test for example).
In addition I did not have  much time in the last days to work on that. But I will spend more time on it today and tomorrow. Please let me know if you have any hints.
For now I updated the branch with master to see if there any effect.

FYI @cindychip @weicaiyang @sha-ron this has been merged, so the UART0 should now be mapped to the correct pins in the chip TB.


Windows Support

Are there any plans to make docker-slim available for windows?

Would be great to have, painful to have this working on windows through workarounds with docker-machine

"Fat" images on Windows is definitely a big headache and I know Microsoft is trying to address the problem too. DockerSlim for Windows is possible, but it will require a new Windows-specific sensor. There'll need to be enough interest for this feature to happen. It'll be great if anybody can do a survey. It'll also help if anybody can find a company willing to discover the production use cases.

Moving this to the wishlist(https://github.com/docker-slim/docker-slim/blob/master/WISHLIST.md)


[Feature] Add support for token authentication

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Shoothzj please review again

Currently, it seems the test-cases not set up the pulsar broker. It is not appropriate to submit test cases at this stage.
@JavaXiaoJun What do you think? How others have run this test?


Boolean constant support

Support boolean constants at the HAL -> VM lowering

not llvm related?

not llvm related?

I wanted to highlight that both VMLA and the LLVMJit were now working given its a HAL/VM change (waiting on vulkan changes). Updated comment.

This isn't valid - you shouldn't have any i1 types by the time you are serializing to bytecode - it indicates you are missing an i1->i8 expansion earlier on

I updated to occur at the HAL to VM lowering. I can also place it at the std.const to HAL lowering but it felt a little strange to change the type at that point. Either works but went with the HAL to VM lowering.

You made it one level higher, but it needs to be one level higher still :)
The HAL and the VM have machine-level semantics. Just as you can't malloc 1-bit or memset 1-bit you cannot create a HAL buffer of 1-bit. The conversion you're doing needs to happen between flow (where things are tensors) and hal (where things are buffers).

Yeah this was the clarification I was hoping for. We should probably define the expected types at
the HAL level. Overall how we would expand types should have a firm spec in the future.

This could probably happen in iree\compiler\Dialect\HAL\Conversion\TypeConverter.cpp. As Scott mentions though it is probably worth more exhaustively testing that such a conversion is valid (tests that perform operations on the bool tensors, etc) or what alternatives are. For example, the intent is that an 8/16/32-bit aligned 1-bit tensor could be widened to work on the byte-aligned types if the operations performed on it are compatible (bitwise op, usually). So tensor<8x32xi1> -> tensor<8xi32>. This wastes no memory (vs always expanding) and the HAL doesn't care about what the bits represent so it should pass right through (as 32 i1's and 1 i32 are the same buffer).

For now its probably best to stick to i8 expansion as this is what we assume for VMLA. I don't think
we can perform the conversion in TypeConverter though; it handles the conversion of value types and
does not recursively handle attributes.
Overall its updated to handle the conversion at the lowering to HAL. Important note - notice
that there are two const lowerings. This is to handle the situation where further lowerings to
VMLA create new constants that need to be serialized with VMLA's constant implementation.

I'm still a bit sketched out as this is not consistently applying things. What happens to ops that are acting on these constants? Or values extracted from the constants and used for other purposes? Are there ops that would stop working with the type getting changed? What about constants that are already inlined into dispatch regions and going to other backends like LLVM or SPIR-V?
The issue with doing it in the flow->hal conversion is that you are now making a global assertion (that all i1->i8) but only then handling it in one local usage (VMLA constant ops). This indicates that it's too low level: the whole point of having the flow dialect (and whatever frontend dialects that live above it) is that these kind of global transformations can be applied consistently and that subsequent lowerings don't need to know about these implicit semantics.
I understand just wanting to land some constant bools, but these kind of changes are really hard to debug later on and can greatly complicate backend implementations (that can no longer rely on consistency across the ABI boundary). It's a lot of work to unwind the existing i64->i32 implicit conversions and I'd really like to avoid adding new things like that.
iree\compiler\Dialect\Flow\Transforms\LegalizeInputTypes.cpp is an example of a possible place where this could live. It can perform type conversion and already handles attribute conversion for constant ops. It'll clearly highlight the issues above (what happens to ops that have requirements on certain types like conditional operations, etc) and even if such issues aren't handled right away will at least put them all in a logical place that's easy to find (verification would fail after the pass) and update (just one global location, not per-backend). We don't want people hitting random type issues in linalg because of spooky action at a distance.

I'm still a bit sketched out as this is not consistently applying things. What happens to ops that are acting on these constants? Or values extracted from the constants and used for other purposes? Are there ops that would stop working with the type getting changed? What about constants that are already inlined into dispatch regions and going to other backends like LLVM or SPIR-V?

I think this stems from not having a clearly define boolean representation. Operations in
both LLVM and VMLA assume i1 <-> i8 equivalency and any lowering for constants will need
to match/change those assumptions.

The issue with doing it in the flow->hal conversion is that you are now making a global assertion (that all i1->i8) but only then handling it in one local usage (VMLA constant ops). This indicates that it's too low level: the whole point of having the flow dialect (and whatever frontend dialects that live above it) is that these kind of global transformations can be applied consistently and that subsequent lowerings don't need to know about these implicit semantics.

Similar problem to mentioned above - at this point we dont clearly specify the specify
IREE's boolean buffer semantics. Because we convert straight from the Standard dialect to IREE's internal representation we lack a layer to handle any changing abstraction (though
a solution could be introducing a Flow constant operation).

I understand just wanting to land some constant bools, but these kind of changes are really hard to debug later on and can greatly complicate backend implementations (that can no longer rely on consistency across the ABI boundary). It's a lot of work to unwind the existing i64->i32 implicit conversions and I'd really like to avoid adding new things like that.

This is understandable, but for boolean operations we need to establish how to handle sub
8-bit operations. We can limit the breadth of our first implementations as it is extremely unlikely we will start examining 2-bit or or 4-bit quantized models where the sub-bit benefits become more significant.

iree\compiler\Dialect\Flow\Transforms\LegalizeInputTypes.cpp is an example of a possible place where this could live. It can perform type conversion and already handles attribute conversion for constant ops. It'll clearly highlight the issues above (what happens to ops that have requirements on certain types like conditional operations, etc) and even if such issues aren't handled right away will at least put them all in a logical place that's easy to find (verification would fail after the pass) and update (just one global location, not per-backend). We don't want people hitting random type issues in linalg because of spooky action at a distance.

So the problem with LegalizeInputTypes is that it occurs separately from the lowering to HALBuffers. This means when the i1->i8 conversion occurs any operations that require I1s
are invalidated (e.g. mhlo.compare expects to produce a predicate). While its possible to
change the underlying attribute without changing operation types, this results in validation
error between Constant operation types and attributes. (This could be fixed by introducing
constants into the Flow dialect).
At this point I think we need to define a clear plan for boolean types going forward. While
low-bit representations have some potential for significant performance improvement, we
likely won't be investigating those implementations until examining 2-bit / 4-bit
quantization where the gains will be more significant.

To be clear, boolean and low-bit depth values are not at all the same; you don't perform transcendental math on bools.

I filed some longer term notes here: https://github.com/google/iree/issues/3102
For this PR, I really just want to see that this is something that is more than just hack 1/N - if you're going to be next week needing another hack as you start to do more with bools that's going to continue compounding the tech debt here in a part of the code that really can't hold any more. This means doing some legwork to get what you actually want to run together in IR form so it can be analyzed - which it sounds like you're close to. If this change with some issues/TODOs tracking it works well for your extended use cases (again, not just defining a const value) then it's ok to land and clean up later, but this limited usage doesn't instill much confidence (spoken from experience having written the other hacks that are now causing much pain :).


fix(functions): workarounds for curated layer issues

Describe your changes
Workarounds for blocking issues currently present in the ODW curated layer. These can be removed once ODW-1329 is resolved.
Fixes for:

secretaryOfState and welshLanguage being in incorrect case
missing fields projectNameWelsh, projectLocationWelsh, projectDescriptionWelsh, examTimetablePublishStatus, confirmedDateOfDecision
regions using space rather than underscore

Issue ticket number and link
Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

Issues have been fixed upstream by ODW


[Re-PR] Evidence supports Revocation, with streamlined interface of Add/Create

Summary

Concisely describe the issue and your solution:
Link to existing issue (type "#" to check):
Specify the tests done so far:

Solutions (Optional)
Please describe the details of your solution if it might be too complicated for reviewers.

Codecov Report

Merging #258 into develop will increase coverage by 0.30%.
The diff coverage is 69.69%.

@@              Coverage Diff              @@
##             develop     #258      +/-   ##
=============================================
+ Coverage      38.57%   38.87%   +0.30%
- Complexity      1555     1574      +19
=============================================
  Files            242      242
  Lines          13737    13949     +212
  Branches        1748     1793      +45
=============================================
+ Hits            5299     5423     +124
- Misses          7786     7845      +59
- Partials         652      681      +29

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/webank/weid/constant/WeIdConstant.java
96.66% <ø> (ø)
1.00 <0.00> (ø)

...e/impl/engine/fiscov1/EvidenceServiceEngineV1.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../webank/weid/service/impl/EvidenceServiceImpl.java
41.00% <45.45%> (+1.29%)
42.00 <13.00> (+11.00)

...e/impl/engine/fiscov2/EvidenceServiceEngineV2.java
73.10% <78.70%> (-0.30%)
55.00 <2.00> (+14.00)
:arrow_down:

.../main/java/com/webank/weid/constant/ErrorCode.java
96.38% <100.00%> (+0.02%)
6.00 <0.00> (ø)

...om/webank/weid/protocol/base/EvidenceSignInfo.java
80.00% <100.00%> (+5.00%)
5.00 <1.00> (+1.00)

...e/impl/engine/fiscov2/AuthorityIssuerEngineV2.java
72.76% <0.00%> (-3.66%)
36.00% <0.00%> (-5.00%)

.../weid/service/impl/AuthorityIssuerServiceImpl.java
67.13% <0.00%> (-0.94%)
66.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f852218...b429399. Read the comment docs.


signUpApi post user info

i am thinking about this branch is false, i am recoding this branch, or is this right?


Can I actually deploy a cgi script to something like Heroku?

~

It's definitely possible, because you can use custom buildpacks on Heroku, which basically lets you do anything. But writing a custom buildpack could be quite an undertaking.
The answer here should work - run a persistent app that is a CGI server:
http://stackoverflow.com/questions/13520175/run-python-cgi-application-on-heroku
And some loonbag has already written a custom buildpack which only does CGI - in shell script (turns out quite simple, but it's not exactly production-strength):
https://github.com/charliesome/heroku-buildpack-cgi
Actually using a custom buildpack is not too hard:
https://devcenter.heroku.com/articles/buildpacks
You can specify the buildpack in the app.json:
https://devcenter.heroku.com/articles/app-json-schema
Which means you can deploy it using a button on the GitHub page:
https://devcenter.heroku.com/articles/heroku-button

@tomwhoiscontrary thank you Tom! I will try and investigate this tomorrow. The buildpack is tempting purely because I don't know how capable I'm going to be without it. We will see :)

I spent the last few hours attempting to deploy this to Heroku and it was a complete failure.
The project will be localhost only until I can pay someone to spend time trying to deploy this.

:rage4:
Sounds like something to ignore for release 1, at least!
I'm not very familiar with Heroku (i've used Cloud Foundry, which is similar but different) and yeah, there are a lot of little nuances you need to somehow know about. Even more so if depoying CGI possibly.
I strongly suspect you can deploy your app without having to do anything special with buildpacks. You might have to change the server.py from the built-in web server to Flask. Would be great to find someone who's actually done this with Python and Heroku, ie not me (sorry).

No need to apologise, you definetly gave me some things to look at, I'm just not knowledgeable enough yet to get it working. :+1:

You shouldn't have to play around with buildpacks, you have a requirements.txt file so Heroku should work out that it needs python.
I've not tested all this but hopefully it should give you enough of a start and clue for what to google
Get the server running
First though since you're not using a framework which has a default way to run it you need to tell Heroku to do the python server.py, this is done with a file called Procfile, this is what Foreman uses but you don't need to care, it just needs to be a file with the line:
web: python server.py

in it, which tells Heroku for the web task you want to run this command.
By this point you should be able to deploy and it might not crash but it probably won't work.
To get the web server bit to work you will need to make it listen on the right port and to not just listen on <IP_ADDRESS>
So first change line 4 in server.py to
HOST = "<IP_ADDRESS>"

The difference here is that <IP_ADDRESS> is a special address that is only available from the computer the program is running on, so when you're running it on your machine you can get to it by localhost but someone else even on the same network couldn't. <IP_ADDRESS> means that port will be available on all the networks the computer is connected to (see security issue below).
Next we need to get the the server to listen on a port that Heroku has exposed to the internet. Before running the command in Procfile Heroku will set up some environment variables so they are available to your program. One of them is PORT which is the port exposed to the internet via Heroku's routing layer.
So we need to get access to that variable from inside the python process. In the os module there is a function called getenv that does this for us.
So in server.py add
import os

at the top and change line 3 to
PORT = os.getenv("PORT", 8000)

It will then set PORT to the value Heroku gives it or default to 8000 if you're running it locally.
Security issue
There is a slight security issue here, in that if you are developing on your machine someone else on the network can now get to your app, you might want this but if you don't you could change the code too:
PORT = os.getenv("PORT")
# We are not running on Heroku
if PORT is None:
  PORT = 8000
  HOST = "<IP_ADDRESS>"
else:
  HOST = "<IP_ADDRESS>"

Get the database working
The image of the code that Heroku uses is readonly so line 7 in database.py needs to use a different location. If we are lucky you might be able to change it to:
DATABASE = "/tmp/guestbook.db"

To get it working temporarily, the only issue here is that the computer running your code in Heroku is temporary, so after you haven't requested it in a while Heroku will stop the code and throw away the virtual machine which means next time it starts up /tmp/guestbook.db won't exist anymore. This is why you will need to make it use postgres.
If you don't already have a database attached to the project you can provision one following this guide and you'll then have an environment variable called DATABASE_URL with the connection string in it.
So to access the database when running on Heroku you can change the database setup lines to:
import os
import urlparse

DATABASE_URL = os.getenv('DATABASE_URL')
# use sqlite
if DATABASE_URL is None:
  database = SqliteDatabase("guestbook.db")
else:
  # extract all the database connection parameters from DATABASE_URL
  database_url = urlparse.urlparse(DATABASE_URL)
  # get rid of the "/" from the path to get the database name
  database_name = database_url.path[1:]
  # connection arguments are documented here:
  # http://initd.org/psycopg/docs/module.html#psycopg2.connect
  database = PostgresqlDatabase(
    database_name,
    user=database_url.username,
    password=database_url.password,
    host=database_url.hostname,
    port=database_url.port
  )

We're really close now
It should all work now, fingers crossed, except that the postgres database won't have the tables created in it. This is what frameworks usually call migrations but for the moment you can just cheat and get a python shell on a Heroku node and run database.create_tables() by doing this on your machine
heroku run python

Once you get the python shell
import database
database.create_tables()
quit()

Then if everything has worked you should be able to access it in the web browser. 😬

So! I have made progress thanks to @pkqk. I followed your instructions but make a couple of notes:
to work with the Postgres peewee database, psycogpg2 needs to be installed in the environment with pip. Also, the PORT config var needs to be cast to an int to work.
If you go to: https://afternoon-everglades-3926.herokuapp.com/ you will see the assets load.
https://afternoon-everglades-3926.herokuapp.com/form.html works too. However the homepage (https://afternoon-everglades-3926.herokuapp.com/cgi-bin/script.py) does not and I am not sure why.
I receive the following error message:
sock=backend at=error code=H18 desc="Request Interrupted" method=GET path="/cgi-bin/script.py" host=afternoon-everglades-3926.herokuapp.com with some other bits and a status of 503.
Heroku tells me that:
the ... backend (your app’s web process) socket was closed before the backend returned an HTTP response and I am unsure what to do with this information to make it work.
But, still, progress. And thank you so much @pkqk.

Ah script might be crashing at some point. You might have to resort to print line debugging by adding
import sys

# and then add this everywhere or more informative strings
sys.stderr.write("I got here before crashing\n")

If you're not already getting a backtrace then normal stdout is probably being hidden because that output normally goes to the browser as that's how CGI works so hopefully using stderr for logging will show up in the heroku logs too

So I spent the last hour or two working with someone familiar with the Heroku infrastructure. I learnt a bunch of neat tricks but unfortunately it seems that Heroku just will not support even the simplest of cgi-scripts.
So this project will be local only until some kind of magic happens.
Thank you very much for all your input, @tomwhoiscontrary & @pkqk :+1:

One of the things that prevents it from working on heroku is the use of the filesystem: The filesystem is reset to the original state every 24 hours. You need to use an external database like postgres.

This may be another really unhelpful rabbit-holing comment, but you could try Cloud Foundry. There, the filesystem is only reset when you restart or redeploy the app. So you still want an external database really, but it might be a better short-term solution than Heroku.

I was wrong and forgot, dynos have a read only file system except for one-off dynos. You have to remove all code that mutates the filesystem, which includes updating index.html, counter.txt, and guestbook.db. I'm working on getting it on heroku for fun

@tef thank you so so much for all of your help, I can't wait to go through your PR and take a look at the changes. :balloon:


SWAV result on STL10 no longer valid

🐛 Bug
I am trying to reproduce the STL10 result as is suggested here. I clone the latest the repo and try to run
python swav_module.py
    --online_ft
    --gpus 1
    --lars_wrapper
    --batch_size 128
    --learning_rate 1e-3
    --gaussian_blur
    --queue_length 0
    --jitter_strength 1.
    --nmb_prototypes 512

Since --lars_wrapper is no longer available, I use --optimizer lars. I also disable the fast_dev_run. However, at 50 epochs, the val acc is around 20%, unlike the 70% in the webpage.
Environment

PyTorch: 1.7.1
OS: ubuntu
How you installed PyTorch: (pip)
Python version: 3.8
CUDA/cuDNN version: cuda11.0

@ananyahjha93 any update here?

We are deprecating the self-supervised learning paper implementations in bolts and instead provided a VISSL integration in PyTorch Lightning Flash which can be used to train models using self-supervised learning algorithms. You can refer to the documentation here.


Add ExternalDeploymentTriggerDagRunOperator

Adds an ExternalDeploymentTriggerDagRunOperator to start new Dag runs on external Airflow deployments through the Airflow REST API.

We need to defer and trigger the dag from Trigger not in execute method.
Adding a reference for the same sensor and how it is implemented https://github.com/astronomer/astronomer-providers/blob/main/astronomer/providers/core/sensors/external_task.py#L38-L62.

Thanks for the offer. Time was missing over the last few weeks.
The code is mostly done, I'm adding tests and will be able to open the PR sometime this week.

I have considered using the Airflow API Python client at https://github.com/apache/airflow-client-python
Chose to build a custom Client instead since not all endpoints are currently supported.
Curious to have feedback on this.

I'm sorry I let this PR open for so long. Was working on PS engagements and forgot about it.
I'll address all the comments and fix the failed CI checks this week.

@phanikumv : Fixed all the errors and comments.
Somehow mypy still throws an error on  astronomer/providers/microsoft/azure/hooks/wasb.py:59.
It is not something I've changed with this PR. Let me know what you want to do with it.

Look like maybe some more tests require.

@odaneau-astro this PR is going on since quite some time. not sure whether we still need it?

Closing as there is no activity on this since 2 months


Added Projects Component and Aligned Heading and project cards

Added Projects Component and Aligned Heading and project cards
#23 #40

Any Further Changes Required?

Hi @Baburao-sanivada
Your PR is good to merge but you need to take care of this -

Add spacing to the element.
Adding my-8  to the parent div of the element should take care of this.
It currently looks like

It should look like


Split up arrow_cast::cast

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The cast kernel is currently implemented as a single large module. This has gotten fairly unwieldy, and should be split up.
Describe the solution you'd like

I would like related functionality grouped together into crate private submodules, that are then composed into the top-level cast kernel
Ideas for modules might be:

arrow_cast::cast::decimal - decimal handling logic
arrow_cast::cast::list - list handling logic
arrow_cast::cast::dictionary - dictionary handling logic
arrow_cast::cast::string - string parsing and display logic

In order to make reviews more manageable, and minimize conflicts, these changes should be made across a number of smaller PRs
Describe alternatives you've considered

Additional context

@fansehep are you still working on this? I would like to submit some PRs for this if it is available.

There hasn't been any activity on this for almost 4 months, so I think it would be reasonable for you to pick this up if you're interested


Components font-family using 'Arial' instead of primary font 'Open Sans'

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
It seems the components are using the font-family value 'Arial' instead of the defined primary font 'Open Sans'.
We've observed this in our application, even after adding Open Sans as a resource in the index.html
This can be observed on the Storybook site by viewing the computed CSS values for inputs:

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
High
What product/project are you using Modus Components for ?
Work Center
What is your team/division name ?
Trimble Viewpoint
Are you willing to contribute ?
None
Are you using Modus Web Components in production ?
No response

Observation: this is only affecting input elements.


update main

I changed the implementation a bit in a way that I think makes it a bit more readable? It also works correctly now, at least in my tests far

merged via https://github.com/actions/create-github-app-token/pull/46/commits/68894b67afc9a6757dd178fe2edfcd2bfa7bf449


Protocol readily usable by other platforms

resolves #97

As discussed in a comment above, this PR will move the protos outside the crates directory to a new top-level directory structure for the protocol spec and proto files. This will make it more usable for other implementations.
The current structure of the directory is
+ protocol
   README.md
   + protos
      + google/protobuf
         timestamp.proto
      + warg
         warg.proto

@lann @peterhuene any opinions about the name/structure of this new top-level directory?

I'd probably have preferred api as the top level directory, but kept it the same as the existing crate protocol since there already was an api crate. Also not sure if you'd prefer proto or protos?

@Kylebrown9 the proposed structure works for me.

I'm happy to move forward with Peter and I approving the structure.
Feel free to remove the draft status when you're ready and we can do a final review.

Still reading through the code - the proofs protos applies as well if they are serialized somewhere in there I did not see yet? Is having them in a separate namespace needed?

No, the separate proofs namespace shouldn't have any functional importance.

I think the most common convention is a top level proto/ directory, but as long as everything is package-namespaced under some root I don't think it makes much difference functionally.

On the subject of proofs one of the reason it's separate is that we only need types generated for proofs in the warg-transparency crate and warg in the warg-protocol crate. Any change that moves proofs will need to preserve that.

Ready for review again. Also moved the transparency proofs protos but kept them in separate package from the protocol protos.