XLSearch: Disulfide bond searches suffer from deconvolution issues

Disulfide bonds result in the loss of two hydrogen atoms. When a peptide of z=2 is incorrectly assigned as z=4, XLSearch incorrectly assigns the peptide as crosslinked to itself. This is currently intra, but should be inter (because the protein would have to xlink to a different protein). We need some sort of flag to prevent this, as it's rather common.
Shown below are top 20 intra XLPSMs

Pep1 Base   sequence(crosslink site)
Pep2 Base sequence(crosslink site)

SNVNDGVAQSTRIIYGGSVTGATCKELASQPDVDGFLVGGASLKPEFVDIINAK(25)
SNVNDGVAQSTRIIYGGSVTGATCKELASQPDVDGFLVGGASLKPEFVDIINAK(25)

KELSEPSSTRIYAIAKALENNMSLDEIVRLTSIDK(1)
KELSEPSSTRIYAIAKALENNMSLDEIVRLTSIDK(1)

QHGIPIPVTPKSPWSMDENLMHISYEAGILENPK(11)
GRNDLMEYAKQHGIPIPVTPKSPWSMDENLMHISYEAGILENPK(21)

CDIDIRKDLYANNVMSGGTTMYPGIADRMQK(7)
CDIDIRKDLYANNVMSGGTTMYPGIADRMQK(7)

DGTTRTTSLELFMYLNEVAGK(21)
DGTTRTTSLELFMYLNEVAGK(21)

AGYTDQVVIGMDVAASEFYRSGKYDLDFK(23)
AGYTDQVVIGMDVAASEFYRSGKYDLDFKSPDDPSRYITPDQLADLYK(29)

GSINAMRFLTTVSMEQPEMLEK(22)
GSINAMRFLTTVSMEQPEMLEKVSREIWMRVWSRDEDITEYQSILAAAVK(50)

IPRSTLSALVNGKPYKVTPTIEDPSIFGHIEEVLK(13)
PYKVTPTIEDPSIFGHIEEVLK(3)

DAIIAKLANQAADYFGDAFK(6)
MKDAIIAKLANQAADYFGDAFK(2)

EQTKLKWMQSELNVEEVVNDRSWK(6)
EQTKLKWMQSELNVEEVVNDRSWK(6)

MKRLGSDLTSAQKEMK(2)
MKRLGSDLTSAQKEMK(2)

EEKGLSLEGFQLTGLSEPSLQKSSIDLSTEK(22)
EEKGLSLEGFQLTGLSEPSLQKSSIDLSTEK(22)

SLGGVQPSQTIQPKVETDAAQAAVQSAFAVLLTQLIKAQQSK(37)
SLGGVQPSQTIQPKVETDAAQAAVQSAFAVLLTQLIKAQQSK(37)

MRDILNMDKTLKGLNSDSVTEETLRK(9)
MRDILNMDKTLK(9)

GASLYDLLGKEVELRELRTEAIARPLEINETEKVMRIAIK(10)
GASLYDLLGKEVELRELRTEAIARPLEINETEKVMRIAIK(10)

EVDEQMLNVQNKNSSYFVEWIPNNVK(12)
NMMAACDPRHGRYLTVAAVFRGRMSMKEVDEQMLNVQNKNSSYFVEWIPNNVK(27)

ALVDKWPDFNTVVVRPQEQEMTDDLDFYINTYQVYSK(5)
ALVDKWPDFNTVVVRPQEQEMTDDLDFYINTYQVYSK(37)

LQGWTPMPNVRRATTQPPSLSLRKMKTALPQEEQK(26)
LQGWTPMPNVRRATTQPPSLSLRKMKTALPQEEQK(26)

SLTGAKDLTKNAEVVAGTGEQCLPFDEARCGDGGK(10)
SLTGAKDLTKNAEVVAGTGEQCLPFDEARCGDGGK(10)

One fix might be to remove MS2 fragments found by the alpha peptide to prevent rematching to that peptide in the beta search?

@zrolfs suggestion was implemented in #1449
I don't really have enough disulfide data to test the results

I think it can be tested without disulfide data. The issue was that unmodified (not XL) peptides were being called as crosslinked, so we should no longer see this when analyzing alkylated peptides.

This was fixed a while back. We disallowed a beta peptide from matching to the same peak as an alpha peptide.


Add configuration for Image to be shown without proper TF/fixed frame

I think that it would be nice to be able to see an image with the Image tool even when the frame_id provided by the image header is not found in the TF tree or does not match the fixed frame in Rviz.
It could maybe just be a checkbox to enable in the Image tool ?

I think this is going to be an issue especially with Visual SLAM algorithms, e.g., orbslam. When a vSLAM algorithm loses tracking, e.g., due to poor visual information, rapid motion etc. they will stop publishing updates for their corresponding frame until they relocalise / regain tracking. During that duration where tracking is lost, users of rviz wouldn't see any images whatsoever because there wouldn't be a valid link of the frame to the rest of the TF tree.

Out of cusiosity, what's the rationale behind this? Why not show images that don't have an associated frame? rviz1 was happy to render images regardless of their frame.
Roughly what files / what changes would need to be made to show images without an associated frame?

Out of cusiosity, what's the rationale behind this? Why not show images that don't have an associated frame? rviz1 was happy to render images regardless of their frame.

TBH, I'm not sure this was a conscious decision. It may be more of a bug. It makes sense to me to ignore the fixed from for the image display.
Other displays actually check if the transform exists before deciding to render anything, e.g.
https://github.com/ros2/rviz/blob/b30097c0918eb8e381d96a2178f39b8acdddf4f5/rviz_default_plugins/src/rviz_default_plugins/displays/odometry/odometry_display.cpp#L276
However, the ImageDisplay does not do such a check, so I'm not sure why images are not being rendered...:
https://github.com/ros2/rviz/blob/b30097c0918eb8e381d96a2178f39b8acdddf4f5/rviz_default_plugins/src/rviz_default_plugins/displays/image/image_display.cpp#L195-L207
Maybe it's something to do with the texture?

+1 to this topic, blocking development for me and a huge regression from rviz1. Why would I need my whole TF tree to be resolved correctly to see 2D images?

It appears to be because of the TF filter on incoming image messages? https://github.com/ros2/rviz/blob/ros2/rviz_default_plugins/include/rviz_default_plugins/displays/image/image_transport_display.hpp#L117-L140 So this is explicitly added? Why?

+1 on changing this behavior back to ROS1 behavior: Show images no matter what is available in TF.
At the very least, do not show "(checkmark-symbol) Status: OK", when it should be "(error-symbol) Status: Missing TF  transform".


Dolphin file manager doesn't create PDF and DJVU thumbnails

Describe the bug
KDE's file manager Dolphin doesn't create thumbnails of PDF files, despite being configured to do so and libsForQt5.kdegraphics-thumbnailers being installed. Thumbnails for images, videos, directories, and text files are created as expected.
Steps To Reproduce

Install Dolphin and kdegraphics-thumbnailer on NixOS
Open Dolphin -> Configure Dolphin... -> Previews -> Select "PostScript, PDF and DVI Files" and "DjVu Files".
Set "No Limit" for previews and save.
Open Dolphin, set View -> Show Previews.

Expected behavior
Thumbnails of PDF files are created.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
When I create a new user on my system, I can reproduce the problem.
PDF thumbnails can be created with either Nautilus+evince installed or Thunar+Tumbler installed.
Those thumbnails are not picked up by Dolphin, but by some other apps, such as index-fm.
Potentially relevant entry in the systemd journal:
krunner[19796]: kf.kio.slaves.thumbnail.djvu: QProcess::FailedToStart ""
Installing several further KDE packages, following a working configuration by another user here doesn't resolve the problem.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.89, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5.1`
 - channels(root): `"nixos-22.05pre343944.ff377a78794"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Mostly solved by installing ghostscript.

I don't think this issue should be closed until it works with kdegraphics-thumbnailers.

Still an issue on NixOS 23.05.

By the way, logs (with QT_LOGGING_RULES="org.kde.dolphin=true") unfortunately aren't useful at all:
org.kde.dolphin: Failed to generate hover sequence preview #n for file "file:///path/to/file.pdf" (attempt n/3)


Tutorial exercice 10 failure

In tutorial for exercice n°10:
Now, let's write the mutable version. Notice the keywords 'mutable' placed in front of the field and the method. this.!field = value modifies object in place, much like in any other programming language.
mutable class Point {mutable x: Int, y: Int} {
    mutable fun incrX(): void {
      // TODO: increment the field 'x' by 1
      // HINT: 'this.!x = value' sets the field 'x' to 'value'

    }
}

A compilation error is returned regardless of the expression tested with run:
File "playground.sk", line 1, characters 15-19:
In 'Point's version of the member '!=' inherited from 'Equality'
1 | mutable class Point {mutable x: Int, y: Int} {
  |               ^^^^^
2 |   mutable fun incrX(): void {
File "tests/runtime/prelude/core/traits/Equality.sk", line 26, characters 12-13:
Cannot call this method on a readonly object
24 |
25 |   overridable readonly fun !=(other: inst): Bool {
26 |     !(this == other)
   |            ^^
27 |   }
File "playground.sk", line 13, characters 7-8:
Try annotating '==' method as 'readonly'
11 | extension class Point uses Equality, Show {
12 |   // Defining equality for a Point
13 |   fun ==(other: this): Bool {
   |       ^^
14 |     other.x == this.x && other.y == this.y

Thanks a lot for flagging this!
So the problem is that those two functions have been made "readonly" in the standard lib, and we forgot to update the tutorial.
I fixed the problem and pushed a new version of the site.


Add sanity check notebook

Resolves #303 .
This PR adds a very basic sanity checking notebook for new catalog builds. It reports:

Current access-nri-intake-catalog version
Available catalog versions
Comparison between default catalog and a previous catalog
Rows, models and variables in catalog data sources

Looks good to me.
I'd like to add some further automated checking, but thats a down the line issue.

Stick that in a new issue - we can start collating a 'next release' actions list.


[New Sample] Create Mobile Geodatabase

Description
Implementation of the Create Mobile Geodatabase Sample.
In general, the sample works as expected however, I'd like to make the following observations:

The implementation of this sample in other platforms includes an option for sharing the geodatabase. I am unsure on how to implement this. Consequently, I removed the references to sharing the geodatabase and constrained the sample to saving the file in the user's directory.
I have not verified the contents of the geodatabase with ArcGISPro but the file is being constantly closed and loaded again whenever the user presses the button but adds a new feature afterwards. The table view updates accordingly and I assume the geodatabase does as well.
When the user closes the main window, the window containing the table remains open and while it can be closed manually, perhaps it would be better if both of them closed at the same time.
To create the table view, a new class GeoFeature was created to facilitate this. I am getting a warning because the get methods of this class are not being explicitly used but are however required. I included an annotation to this class.
To control the behavior of the window containing the table view, I created a Boolean variable that would retain the status of the window but also to avoid null references when using the isShowing() method. There might be a more efficient or elegant way of doing this.
There is a good amount of code within the various listeners and unsure if some of it could be moved out safely and improve the general structure or readability of the code.

Thanks in advance for any suggestions.

Checklist:

[ x] Set target branch to master (current release) or dev (next release)
[ x] Request a reviewer
[x ] Assign a reviewer
[ ] Tag reviewer in comment

Hi @Rachael-E, I've implemented the suggested changes and also modified the sample to the MVC layout for further review. Thanks.

Hi @jenmerritt, thanks for a great review and good catch with discovering the little bug! I have implemented the suggested changes.


How to pass authorization header to every single API calls?

Hello,
Could you share an example of how you actually pass headers to requests? For example, I need to pass an authorization header to all my API calls which is a pretty common pattern.
For now we do the following:
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
import * as Client from '@my/client'
import { useToken } from './token'

const queryClient = new QueryClient()

Client.setBaseUrl('https://example.com')

export function ClientProvider({ children }: { children: React.ReactNode }) {
  const { token } = useToken()

  if (token) {
    Client.setFetchFactory(() => ({
      fetch: (input: RequestInfo | URL, init?: RequestInit) => {
        const headers = new Headers(init?.headers)
        headers.set('Authorization', `Bearer ${token}`)
        return window.fetch(input, { ...init, headers })
      },
    }))
  }

  return <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
}

Many thanks for your time and help.

If you use Axios you can set it on the Axios client as in any general example for it


Reactoring into single-process, multi-thread

For your information (I am aware that there is a merge conflict) here you can find my refactoring that natively load a rosbag and process it at the maximum speed allowed by your CPU.
This PR is not meant to be merged but is my way to share with you our work and start discussing how such merge can be done in the future, if you want to.
The nice thing about this version is that:

it has the same level of parallelism as the original code, but...
it is deterministic, i.e. given the same rosbag, the result will always be the same.
inter-thread communication is much more lightweight then the ROS transport.

The determinism allows me to introduce more changes with confidence, because I can alwasys double check if a certain change introduced a change in terms of accuracy or not.
For instance, there is another branch where I made the whole application considerably faster:
https://github.com/facontidavide/LeGO-LOAM/tree/speed_optimization

Sure, that would be trivial. But I prefer to do it in this way, because either you have sufficient throughput or you don't. If the reading thread isn't fast enough, the buffer will grow anyway


Adding initial repo containing Widget sample

Adding repo of Widget Sample

Looks great! I think the only thing that's missing is a readme in the Widget folder (and maybe some screenshots of what the sample widgets look like)


Calculating route on a straight road can produce invalid GeoJSON.

See attachment for a route between:
latlng: 50.8587, 5.493034
latlng: 50.8583, 5.488124
Attached is the output using route.ToGeoJson()
The Linestring-feature only contains 1 point, which is invalid according to http://geojsonlint.com/
I suppose this is because the route was generated on a straight road with no "waypoints" (in the osm-file) between the chosen coordinates.
json.txt

Thanks! Definitely a bug, a route should always include minimum of two points. Two things to do:

[ ] Have GeoJSON code check for invalid LineStrings (with only one coordinate).
[ ] Check why route in this case has only one coordinate.

A small issue in the route builder, now this is the output:
http://geojson.io/#id=gist:anonymous/bfce365041f22678495c36a067e44eb3&map=16/50.8575/5.4900


Disable AL0604 and AL0606 with pragma are not working

1. Describe the bug
It is not possible to disable warning AL0604 and AL0606 if this should throw an error.
2. To Reproduce
Create this AL-File:
codeunit 50002 "Test"
{
    Access = Internal;
    TableNo = Item;
    trigger OnRun()
    var
        Item: Record Item;
    begin
#pragma warning disable AL0604,AL0606
        Copy(Item);
        with Item do begin
            Description := Format(CurrentDateTime());
        end;

    end;

}

use this ruleset:
{
    "name": "Our ruleset",
    "description": "Some specific rules",
    "rules": [
        {
            "id": "AL0604",
            "action": "Error",
            "justification": "Use of implicit 'with' will be removed in the future. Qualify with 'Rec.'."
        },
        {
            "id": "AL0606",
            "action": "Error",
            "justification": "The 'with' statement is deprecated and will be removed for cloud development in a future release."
        }
    ]
}

3. Expected behavior
It is possible to disable warning AL0604 and AL0606 for single objects.
4. Actual behavior

5. Versions:

AL Language: 7.3.486497
Visual Studio Code: 1.57.1
Business Central: 18.2.26217.26795
List of Visual Studio Code extensions that you have installed:

AL Language
AL Code ACtions
AL Extension Pack
AL Navigator
AL Toolbox
AL Variable Helper
AZ AL DevTools/AL Code Outline

If you have elevated a warning to an error in a ruleset then it can't be suppressed. This is by design.

It works for CodeCop warning like AA0181. Why does it not work for AppSourceCop warnings?


WIP: Update filter for CentOS Linux images

What this PR does / why we need it:
CentOS changed their image names in a way our filters did not match anymore: https://wiki.centos.org/Cloud/AWS
Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

/lgtm

/retest


Will alertmanager support output to flock ?

We would like to use the flock instead of slack of the alerting, Flock supporting income webhook for another alerting application, I tested the Zabbix also supported to use.
I used the slack_configs for my Slack is working, for the webhook_configs also didnt works for the Flock, do alertmanager will support or I missed something ?

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

I had asked this question on prometheus-users, but no one back to me, so I asked here.


Update how-to-connect-fed-group-claims.md

One small error. Other groups will not be omitted.

@yuazhou : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close


Updates to Spades

Now can get/set scores and set a bonus reward for winning/losing overall game to returns.

Hi @i-Madsen, thanks for the updates!
Can you pull changes from master to merge with the changes to the master branch? I had to make some cosmetic changes to your code to adhere to the required style. (If you can keep these persistent and apply them elsewhere too, that'd be great.)
Once any conflicts are resolved, please push the merge commit.

Also, note: I will soon not have access to the Internet for the next 8-10 days.. so apologies for any delays in responses.

Ok, think I've got it all merged correctly and pushed once you get back. Let me know if I missed anything.

Hi @i-Madsen,
Ok the CI is fixed now as of  https://github.com/google-deepmind/open_spiel/pull/1250
Can you pull from master and push the merge commit?

@lanctot Ok, should be merged now.

@lanctot Ok, should be merged now.

Ok seems there are some test failures for legitimate reasons (a function is marked void but I guess it's returning a bool?) Can you take a look and push a fix?

@lanctot Looks like it's all passing now (not sure how I missed that before).


Implement serial port interface for linux using termios2

Implementation of the serial port interface for linux using termios2. My code is based on #73 (so the main part is not written by me). I just adapted it to termios2 which allows to set custom baudrates like 10400.
Note: I never coded in C# and with .NET before, so I probably did many things wrong .. but at least it works for me
EDIT: Even though configuring the serial port doesn't fail with an error, it silently fails. If the baudrate has not been previosly configured correctly, it doesn't work as setting the baudrate fails. I'll try to fix that.

Even though configuring the serial port doesn't fail with an error, it silently fails. If the baudrate has not been previosly configured correctly, it doesn't work as setting the baudrate fails. I'll try to fix that.

So what remaining work needs to be done? I set up a Raspberry Pi with an FTDI-based KKL cable this week so I can finally test this once it's functional.

Found the issue with changing the baud rate: NCCS should be 19, not 32. See here for more info: https://github.com/dcuddeback/termios-rs/issues/9
I'll merge this once I fix a few other issues.


Build Issue On ArchLinux - Config.h: No such file or directory

.../code/gltut-0.4.0/glsdk/freeglut/src/freeglut_internal.h:32:14: fatal error: config.h: No such file or directory
Get this error after running the build steps in the README

@broaken13 cd into glsdk/freeglut then run
chmod +x autogen.sh
./autogen.sh
./configure

now go back to gltut root and try building again :).

Working now. Thank you!


Getting 403 on Travis CI

I'm not sure whose issue this may be, Travis or tsd, but when my Travis build tries to run tsd update -so, I get this:
Running "run:update_tsd" (run) task
-> running update
-> an error occured!
unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
Error: unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
    at Request.<anonymous> (/home/travis/.nvm/v0.10.38/lib/node_modules/tsd/build/http/CacheStreamLoader.js:158:28)
    at Request.emit (events.js:95:17)
    at Request.onRequestResponse (/home/travis/.nvm/v0.10.38/lib/node_modules/tsd/node_modules/request/request.js:1142:10)
    at ClientRequest.emit (events.js:95:17)
    at HTTPParser.parserOnIncomingClient (http.js:1689:21)
    at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:122:23)
    at CleartextStream.socketOnData (http.js:1584:20)
    at CleartextStream.read [as _read] (tls.js:514:12)
    at CleartextStream.Readable.read (_stream_readable.js:341:10)
    at EncryptedStream.write [as _write] (tls.js:369:25)
---
unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
/home/travis/.nvm/v0.10.38/lib/node_modules/tsd/node_modules/bluebird/js/main/async.js:93
                throw res.e;
                         ^
Error: unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
    at Request.<anonymous> (/home/travis/.nvm/v0.10.38/lib/node_modules/tsd/build/http/CacheStreamLoader.js:158:28)
    at Request.emit (events.js:95:17)
    at Request.onRequestResponse (/home/travis/.nvm/v0.10.38/lib/node_modules/tsd/node_modules/request/request.js:1142:10)
    at ClientRequest.emit (events.js:95:17)
    at HTTPParser.parserOnIncomingClient (http.js:1689:21)
    at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:122:23)
    at CleartextStream.socketOnData (http.js:1584:20)
    at CleartextStream.read [as _read] (tls.js:514:12)
    at CleartextStream.Readable.read (_stream_readable.js:341:10)
    at EncryptedStream.write [as _write] (tls.js:369:25)
Warning: non-zero exit code 8 Use --force to continue.
Aborted due to warnings.

But it works fine on my local machine.

Hi, really seems to be a problem with github api access. Same issue here: http://stackoverflow.com/questions/30447362/travis-ci-status-code-403-on-github-api
I'll investigate. For now, change your .gitignore file to tracking the typings directory. This will avoid your build error.

Okay thanks, I was considering that workaround.

I'm encountering this error on my local machine:
unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
Error: unexpected status code: 403 on: https://api.github.com/repos/borisyankov/DefinitelyTyped/branches/master
    at Request.<anonymous> (/Users/arobertson/.nvm/versions/node/v0.12.4/lib/node_modules/tsd/build/http/CacheStreamLoader.js:158:28)
    at Request.emit (events.js:107:17)
    at Request.onRequestResponse (/Users/arobertson/.nvm/versions/node/v0.12.4/lib/node_modules/tsd/node_modules/request/request.js:1142:10)
    at ClientRequest.emit (events.js:107:17)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:426:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:111:23)
    at TLSSocket.socketOnData (_http_client.js:317:20)
    at TLSSocket.emit (events.js:107:17)
    at readableAddChunk (_stream_readable.js:163:16)
    at TLSSocket.Readable.push (_stream_readable.js:126:10)

@alexlrobertson, It seems that this error is related to github API access limit https://developer.github.com/v3/#rate-limiting
We have some instruction at the README explaning about how to use "Github OAuth token"
Could you test? https://github.com/DefinitelyTyped/tsd#tsdrc

@Diullei, might that fix my issue as well?

@dbeckwith I think so but I did not have time to test it with Travis. Could you test?

@Diullei yes I will sometime today, I'll let you know if it works.

@dbeckwith Thank you :+1:

@Diullei Worked for me! :smile:

@dbeckwith Good! :+1:  I'll wait @alexlrobertson feedback before to close this issue!

Seems to have fixed it.

@alexlrobertson Good! :+1:


multimodal processing doesn't work for one-shot CLI

This doesn't work:
% ollama run llava "whats in this image ./image.jpg"
 I'm sorry, but as a text-based AI language model, I am not able to directly view or interpret images. However, if the image is related to
the topic of data science or machine learning, it could potentially be something like a dataset, a visualization of data, a chart, or any
other form of data representation. Please provide more context about the image you are referring to so that I can attempt to answer your
question.

But this does:
% ollama run llava
>>> what's in this image ./image.jpg
Added image './image.jpg'
 The image shows a hot dog in a bun, garnished with mustard and ketchup.

>>> Send a message (/? for help)

Yep, it was only ever added to the interactive chat. It should work on /api/generate (vs. /api/chat), so this should be relatively easy to add.


Fix #13, Adding Init and Micro KS files

Added kickstart files for init and micro packages. This will resolve the issue #13.
Added .gitignore to exclude work and temp output fiels.


GPORCA: Fix cardinality estimation for plan nodes with predicates of the form: date_attribute = constant_value

Description
Details are in issue https://github.com/greenplum-db/gpdb/issues/11169
Fix decription
The current patch replaces mapping for date values from DOUBLE number of microseconds to LINT number of days that is in its turns natural representation of date value in PostgreSQL. Such modification doesn't allow to compare dates with other time related typed values in the context of statistics estimation routines. But GPORCA in its current version (as opposed to PostgreSQL optimizer) doesn't consider comparisons between different time related types and assigns to such predicates dummy frequency value.
Notes for reviewer

All changes in *.h and *.cpp regard mapping logic

src/backend/gporca/server/CMakeLists.txt and src/backend/gporca/data/dxl/minidump/EqualityPredicateOverDate.mdp add new test case for equality predicate where date type attribute participates

in src/backend/gporca/data/dxl/minidump/Select-Over-PartTbl.mdp the cardinality of selection with predicate date_attribute < constant is repaired

in all others *.mdp files including that was mentioned at previous point DoubleValue xml attributes for date type column statistics are rewritten to LintValue one with appropriate recalculation of attribute value

There are failed unit tests anymore. I have attached the log to Jira ticket:
The following tests FAILED:
        100 - gporca_test_CICGTest (Failed)
        106 - gporca_test_CAggTest (Failed)
        162 - gporca_test_CTreeMapTest (Failed)

Is TypeMdid="0.1082.1.0" date? There are multiple date values in 106-way-join.mdp in the CTreeMapTest.

There are failed unit tests yet. I have attached the log to Jira ticket:
The following tests FAILED:
        100 - gporca_test_CICGTest (Failed)
        106 - gporca_test_CAggTest (Failed)
        162 - gporca_test_CTreeMapTest (Failed)

Is TypeMdid="0.1082.1.0" date? There are multiple date values in 106-way-join.mdp in the CTreeMapTest.

Thanks a lot for this notice. I didn't expect that so many *.mdp test cases are not covered by debug kind build of gporca test utility

Tests with ORCA passed.


The kernel appears to have died. It will restart automatically. with memory problem?

1
kernel died after running some code
I try to run the code to generate a sample image with the generator I tried to update the conda and Jupiter but none of them worked
I keep watching the memory usage of GPU but it does not use the GPU that much
tensorflow2.0 , ubuntu 18.10, cuda 10.0
python 3.5,
def make_generator_model():
model = tf.keras.Sequential()
model.add(layers.Dense(77256, use_bias=False, input_shape=(100,)))
model.add(layers.BatchNormalization())
model.add(layers.LeakyReLU())
model.add(layers.Reshape((7, 7, 256)))
assert model.output_shape == (None, 7, 7, 256) # Note: None is the batch size

model.add(layers.Conv2DTranspose(128, (5, 5), strides=(1, 1), padding='same', use_bias=False))
assert model.output_shape == (None, 7, 7, 128)
model.add(layers.BatchNormalization())
model.add(layers.LeakyReLU())

model.add(layers.Conv2DTranspose(64, (5, 5), strides=(2, 2), padding='same', use_bias=False))
assert model.output_shape == (None, 14, 14, 64)
model.add(layers.BatchNormalization())
model.add(layers.LeakyReLU())

model.add(layers.Conv2DTranspose(1, (5, 5), strides=(2, 2), padding='same', use_bias=False, activation='tanh'))
assert model.output_shape == (None, 28, 28, 1)

return model

generator = make_generator_model()
noise = tf.random.normal([1, 100])
generated_image = generator(noise, training=False)
[I 10:20:06.664 NotebookApp] KernelRestarter: restarting kernel (1/5), keep random ports WARNING:root:kernel 4406ce3b-1b5b-4ef8-aba9-d5fd9ed129e7 restarted 2019-04-18 10:20:21.002451: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcuda.so.1 2019-04-18 10:20:21.081020: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1589] Found device 0 with properties: name: TITAN Xp major: 6 minor: 1 memoryClockRate(GHz): 1.582 pciBusID: 0000:42:00.0 totalMemory: 11.91GiB freeMemory: 340.69MiB 2019-04-18 10:20:21.081054: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1712] Adding visible gpu devices: 0 2019-04-18 10:20:21.081382: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA 2019-04-18 10:20:21.107510: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55de6ead0990 executing computations on platform CUDA. Devices: 2019-04-18 10:20:21.107562: I tensorflow/compiler/xla/service/service.cc:175] StreamExecutor device (0): TITAN Xp, Compute Capability 6.1 2019-04-18 10:20:21.127890: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz 2019-04-18 10:20:21.129460: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x55de6eed7eb0 executing computations on platform Host. Devices: 2019-04-18 10:20:21.129503: I tensorflow/compiler/xla/service/service.cc:175] StreamExecutor device (0): , 2019-04-18 10:20:21.129616: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1712] Adding visible gpu devices: 0 2019-04-18 10:20:21.129722: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudart.so.10.0 2019-04-18 10:20:21.130785: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1120] Device interconnect StreamExecutor with strength 1 edge matrix: 2019-04-18 10:20:21.130807: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1126] 0 2019-04-18 10:20:21.130819: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1139] 0: N 2019-04-18 10:20:21.131090: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1260] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 115 MB memory) -> physical GPU (device: 0, name: TITAN Xp, pci bus id: 0000:42:00.0, compute capability: 6.1) 2019-04-18 10:20:24.168083: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcublas.so.10.0 2019-04-18 10:20:24.331094: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudnn.so.7 2019-04-18 10:20:24.789774: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR 2019-04-18 10:20:24.791468: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR 2019-04-18 10:20:24.791484: F tensorflow/core/kernels/conv_grad_input_ops.cc:949] Check failed: stream->parent()->GetConvolveBackwardDataAlgorithms( conv_parameters.ShouldIncludeWinogradNonfusedAlgo(stream->parent()), &algorithms) [I 10:20:27.669 NotebookApp] KernelRestarter: restarting kernel (1/5), keep random ports WARNING:root:kernel 4406ce3b-1b5b-4ef8-aba9-d5fd9ed129e7 restarted

@SlowMonk This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!

Closing due to lack of recent activity. Please update the issue when new information becomes available, and we will open a new issue. Thanks!


fix(fe): fetch name from author instead of json

fix: fetch author name from author field instead of json field to avoid getting stale data saved in json

LGTM 👍


Installation problem

I followed the instructions on https://github.com/mono/CppSharp/blob/master/docs/GettingStarted.md.

The dependencies can be automatically downloaded by running:
cd \build
premake5 --file=scripts/LLVM.lua download_llvm # on Windows

At this step I noticed that the Clang dependencies could not be downloaded. What to do in this case?
Downloading: https://dl.dropboxusercontent.com/u/194502/CppSharp/llvm/llvm-cccdd2-windows-vs2013-x86-RelWithDebInfo.7z
Error: .../CppSharp/build/scripts/Utils.lua:96: HTTP response code said error
The requested URL returned error: 404 Not Found

For a while now we've had a NuGet package at https://www.nuget.org/packages/CppSharp/ . It's 64-bit only but if this is not a problem do you, would you mind giving it a try?

Hi,
We're not supporting VS2013 anymore for pre-built LLVM packages. If you want to use you need to follow instructions to compile LLVM yourself.
If you use VS2015 it should work, file name is llvm-cccdd2-windows-vs2015-x86-RelWithDebInfo.7z.

Ah okay. Please add a notice to docs which states this decision, so others won't get confused.


How ckeditor.js can be bundled in the application

How can we provide ckeditor.js to systemjs module loader so it can be bundeled with the application ?

I think you can't, the ckeditor 4.x doesn’t support JS modules atm.
Ckeditor team have fully rewrited their module, and JS modules are supported in 5.x, but still in alpha : https://ckeditor5.github.io/

You're right. CKEditor 4 would need to be wrapped into a ES6 module (should be a fairly simple task).
As for CKEditor 5, by coincidence, I've just wrote a few things on how the build process looks like and possible use case – https://github.com/ckeditor/ckeditor5/issues/345. Curious to have your opinion there.

When will the ckeditor5 be available for angular 4 and typescript

If you want to get your hands a bit dirty, you can integrate CKEditor 5 into your Angular app quite easily straight from source: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/builds/guides/integration/advanced-setup.html
There's a topic about CKEditor 5's compatibility with Angular. It's generally compatible, but there's a problem if you use Angular CLI.

Hey..
I Just could bundle my project with ckeditor4 js files in my angular4 app  that uses angular webpack bundler

Use angular cli^1.6.6, and this is work for me:
$ yarn add ng2-ckeditor
$ yarn add ckeditor

angular-cli.json
{
  "apps": [
    {
      "assets": [
        "assets",
        { "glob": "**/*", "input": "../node_modules/ckeditor/", "output": "./assets/scripts/ckeditor/" }
      ],
....

index.html
<script src="./assets/scripts/ckeditor/ckeditor.js"></script>

custom-editor.module.ts
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';
import { CKEditorModule } from 'ng2-ckeditor';
import { CustomEditorComponent } from './note-editor.component';

@NgModule({
  imports: [
    CommonModule,
    FormsModule,
    CKEditorModule,
  ],
  declarations: [
    CustomEditorComponent,
  ],
  exports: [
    CustomEditorComponent,
  ]
})
export class CustomEditorModule { }


Running Extension in VSCode, keeps getting credentials error.

Hello,
I am trying to run the example provided in the readme:

In a simple program.js file.
Everytime I try to run it, the HF token page pops up but then I get the error Bearer invalid! in VSCode.
I have two tokens in HF one for read and one for write since it is not specified in the documentation.

I have tried those tokens with an curl post and they work fine.
Not sure what I am doing wrong. Can you help please? :)
Thanks

Managed to fix the error by directly adding my token in the settings.json file: "starcoderex.bearertoken": "",


cannot load such file -- gherkin/dialect

cannot load such file -- gherkin/dialect
Error creating formatter: pretty (LoadError)
/Users/vakalini/.rvm/gems/ruby-2.7.0/gems/cucumber-5.0.0/lib/cucumber/formatter/pretty.rb:4:in `require'
Seeing it on both ruby 2.7.0 and 3.0.0
cucumber 5.3.0, 5.0.0, 4.0.0
I removed require 'gherkin/dialect' as a temporary fix
running require 'gherkin/dialect' in IRB returns true

Can you confirm what version of Gherkin you have? Your Gemfile.lock should say.
We have a floating dependency on cucumber-gherkin - I wonder if a recent cucumber-gherkin release might have broken this...

The last 15x release of cucumber-gherkin is 15.0.2, so 16x or higher shouldn't be picked up unless you've declared another gem that pulls in a newer incompatible gherkin version.
I think we need a minimal repo to reproduce this so we can investigate.

There's no gherkin or cucumber in Gemfile.lock (in any word combination). And even before (when cucumber worked) I don't think there were any.
I honestly can't think of anything that changed between then and now what could break it. Few weeks ago it worked and I don't recall updating anything during this time.

 I'm puzzled why cucumber (and its dependencies) are not there. Do you have them in your Gemfile at all? If not, how do you install Cucumber in your project? If you don't have cucumber in your Gemfile I suggest you add it and bundle install again.
If this doesn't solve your problem, we'll look into this if you share a minimal repo that reproduces this behaviour.


Semantic Release plugins

After noticing v3.4.0 and below had change-logs on the GitHub releases and not the later versions (which I guess was due to the previous issues with TravisCI+SR, which caught my attention after waiting for a release to be visible on the repo). I thought it was a good idea to get the plugins I found useful for some of my projects and which I guess was used here before.

Seems fine to me. Cheers!


[ll] First batch of device integration changes [36/..]

Merge the first batch of changes from ll into master. Not everything from #1321 is done atm but to avoid that the branch diverges even more from the current master.
This PR contains the most parts of the device integration. We follow the concepts introduced by the next-gen APIs (Vulkan/D3D12/Metal):

Unified window entry point: Obtain a Surface object from a window, which is a logic representation of a native window/display, and build a SwapChain to the associated Surface. Swapchains are the window interface for the GPU. Every swapchain has an internal backbuffer (list of images) which we can render to and present.

CommandQueue: Gpu devices offer multiple execution pipelines for graphics, compute and DMA transfer operations. Introducing General/Graphics/Compute/TransferQueues where we can submit now command buffers for execution.

Synchronization: Offering two synchronization primitives: Semaphore and Fence.
Semaphore are suited for GPU-GPU synchronization, usually used for synchronizing with the presentation engine by waiting til a backbuffer image has been acquired and present it once the rendering has finished.
Fences are for CPU-GPU synchronization and are used to ensure that resources can be safely reseted (e.g reset command pools, overwrite memory, ..)

CommandPool: Command buffers are now combined into pools which are Send but not Sync! So each thread should have it's designated command pool if we want to record commands on it. Once a command buffer has been recorded, a Submit object will be returned which can be send to the main thread for submission to a queue. Be sure to ensure via synchronization primitives that no command buffer is in use when reseting the pool!

Adapter: Initialization process gets a bit more explicit, similar to the swapchain creation. Adapters are logical representation of the available GPUs of the system. Users can decide which Adapter to open (= device creation) with a desired number of queues.

Backend: Combining the different new trait implementations into a backend trait (similar to the Resource trait). This should help users to write backend acgnostic code (Surface and SwapChain are window specific!)

OMG IT'S HAPPENING

Thank you for the detailed overview!
I don't think it makes any sense to pick on the details here, given the scale of the PR. We agree on the general direction, so I'm going to merge this and then deal with fallout :)


Incorrect Header Check error downloading file

I get this error when trying to download file using this code in amazon-sp-api v1.0.4:
 let sellingPartner = new SellingPartnerAPI(this.configOptions);
      let res = await sellingPartner.callAPI({
        api_path: `/reports/2020-09-04/documents/${args.documentId}`,
        method: 'GET'
      });
      let report = await sellingPartner.download(res, {
        json: true
      });

Error: incorrect header check
    at genericNodeError (node:internal/errors:956:15)
    at wrappedFn (node:internal/errors:510:14)
    at Zlib.zlibOnError [as onerror] (node:zlib:189:17)
    at Zlib.callbackTrampoline (node:internal/async_hooks:130:17) {
  errno: -3,
  code: 'Z_DATA_ERROR'
}

This only seems to occur for some of the documentIds. To be specific, for this document id I got above error:
amzn1.spdoc.1.4.na.2b611da1-4893-46e2-8f82-5bbc9ed207d1.T3CEV4LAOA16EL.18200
Why is it happening and how do I fix it?

I downgraded my version to 0.7.10 and it works fine. not sure why.


Fixed the launch of the useEffect if the state outside has changed

Description
Fixed the launch of the useEffect if the state outside has changed (makes an extra render)
Example
const useBreakpoint = createBreakpoint();

const Component = () => {
  const breakpoint = useBreakpoint();

  const [count, setCount] = useState(0);

  const onClick = useCallback(() => {
    setCount(value => value + 1);
  }, []);

  console.log(count);

  return (

      <button onClick={onClick}>Click</button>

{count}

{breakpoint}

  );
};

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

Hello, what about this fix?

Came here to open this same PR after implementing this library.
Causes infinite render and flood of console errors due to missing dependency array.
https://react.dev/reference/react/useEffect#my-effect-runs-after-every-re-render


Add feature for rendering static html like github pages

We might be able to integrate with nbviewer: https://nbviewer.org to help with this instead of recreating the entire feature.

Interesting! @onmyraedar is this something we could make use of?
I have a new feature branch that expands the capabilities of our 'FileStore' object which plays nice with coop. I added a HTML file-type. Not sure if interactive visualizations will render though...

Hi! To give a more informed opinion on this, I'd like to gain a better understanding of the libraries involved. A minimal reproducible example of one of these interactive visualizations would help!

Thanks! I am trying to create an interactive visualization using the plotly library and render it on a notebook in edsl. Note, this might be an edge-case feature / unneeded feature, since the same issue happens with github rendering of ipynb's too.
If I understand correctly, this library uses embedded HTML/JavaScript to make up a plotly graph. github (and edsl, I am guessing) performs a static render of the ipython notebooks and it doesn't include the embedded HTML/JavaScript. The issue is identical to the explanation here: https://github.com/plotly/plotly.py/issues/931 , see the response by jonmmease.
One solution seems to be to use nbViewer, the other seems to be to export the plotly graph to html and then host on Github Pages.
Happy to chat further if any of this doesn't make sense!


Fixed some typos and grammar in README.md

I don't agree with most of the changes here / they aren't technically correct in describing the codebase. I left comments on some of them. Closing this PR for now.

Sure,
Probably should have raised an #issue rather than a submitted a PR.
Basically I feel the text is a bit too cryptic for people understand the
build-tree structure. This I believe is essential for developers and
contributors to get familiar with the DC/OS code-base.
On Thu, Apr 21, 2016 at 1:16 PM, Cody Maloney<EMAIL_ADDRESS>wrote:

I don't agree with most of the changes here / they aren't technically
correct in describing the codebase. I left comments on some of them.
Closing this PR for now.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/dcos/dcos/pull/4#issuecomment-213098037

--
Avinash Sridharan, Mesosphere
+1<PHONE_NUMBER>


Initialize chat feature at the home page

Trello ticket
Added the chat feature at the homepage before further advancement.
The chat component initializes the team firebase config from the config file then speaks to the database (firestore) via a collection named 'chat-test-db'

@jamesEmerson112 Your feature branch is 10 commits behind main. Can you pull main branch down locally and merge into your feature branch?

Certainly!


[Issue-3063] Merge initial state options

PR Description
Merge --Xws-initial-state ws state sync argument with existing --initial-state argument.
This modifies the startup behavior in a few ways:

We'll now always parse the initial state if it is supplied.  When spinning up an existing database, we check it is consistent with the initial state.  We also use the initial state to modify weak subjectivity options.
Since we're always running validation against the initial state, when overriding the initial state for custom networks users will have to supply the initial state argument at each startup.

Other changes:

Parse NetworkDefinition in NetworkOptions to simplify access to the parsed value.

Fixed Issue(s)
Part of #3063
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Q before I've had a chance to look at the code: If initial state is always required, how do we handle networks that are still pre-genesis?

Q before I've had a chance to look at the code: If initial state is always required, how do we handle networks that are still pre-genesis?

Initial state isn't required.  But if you're doing something like running --network=medalla --initial-state=custom-genesis.ssz, where you're overriding a built-in initial state, you'll have to always supply this initial state.


FileAppend default chunk size is too small

The current default size (2.17.0) is 2048, a transaction can be up to 6144 bytes in size, the chunk size can probably be increased to 4096 without issues. This would reduce the number of transactions needed to upload larger contract files.

You're right, and I thought we already fixed this some time ago since Java defaults to 4096 bytes. Nonetheless, will fix.


Genius hub

Description:
Added support to connect to Genius hub. This brings in climate controls, switches, TRV and room sensors.
Details about Genius hub can be found here: https://www.geniushub.co.uk/
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8815
Example entry for configuration.yaml (if applicable):
geniushub:
  username: !secret genius_username
  password: !secret genius_password
  host: ip_address
  scan_interval: 20

Checklist:

[yes ] The code change is tested and works locally.
[ yes] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ yes] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[yes ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[yes] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[yes] New dependencies are only imported inside functions that use them ([example][ex-import]).
[yes] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[yes] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hello @GeoffAtHome,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

2a9c8d54ee798914164f6fa166ef45588d94b77f - This commit has something that looks like an email address (root@venus.localdomain). Maybe try linking that to GitHub?.
57fc2d4675d021bfa174b06bf8f602ae217d1d79 - This commit has something that looks like an email address (root@venus.localdomain). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

@technicalpickles Help please. How to I move this forward? What do I need to do?

⚠ I was unable to find a documentation PR (matching this code change) in our documentation repository.
Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.
🏷 I am adding the docs-missing label until this has been resolved.

Came across the documentation PR. PR's where not linked. Added links to OP's.
Removing docs-missing label.

There are merge conflicts that need to be solved too.

Nice! Can be merged when build passes.

So we can merge!
I think it looks a lot better after the refactor. 🥇

Hmm, I'm reading the docs PR. Is it true that host config option doubles as option for api key besides host ip address. That's not a good way of structuring the config options. Each option should only have one type of meaning.

I wanted the client API to be agnostic of the two sources of data. The client API has this:
self._api_v1 = not (username or password)
if self._api_v1:  #else is v3
   ...

I really call it a Hub Identifier, the name host is left over from when Geoff originally started the PR.
I can change it if you want, although I guess it would have to be a fresh PR now?
WOuld you accept hub_id, or would you prefer:
geniushub:
  hub_token: skdjflksjfsljd...

... or ...
geniushub:
  host: <IP_ADDRESS>
  username: my_username
  password: my password

But how do I do mutually exclusive keys in CV?

Yes, please open a new PR with these changes. Use vol.Exclusive.
We have CONF_ACCESS_TOKEN and CONF_TOKEN in const.py. hub_token would be ok too.

OK, it's 11:30pm here - I will have it done by tomorrow.


Minor UI improvements

Friendly name is reported immediately after system name (in parentheses) and consistently so across all panes, not just system details.
Pencil icon to edit system details is added to all panes, for quick access
Signature purge/confirm button took up too much vertical space, is now a floaty button on the right
Add sig button didn't fit on row, relabeled to just "add"
Minor transparency on modal dialogs and system tooltips
Main nav bar takes less height (it took away from the map real estate whilst not being used much)
Modal dialogs take less space now (point 2 of issue #239)
Set destination buttons in destination list are smaller now
k-space details are reported on one line instead of an ugly table, sec status coloured

Nice changes, though it would be cool if the commit list would be bit shorter, e.g. commit "typo" could be squashed. Also those "3rd, attempt".

Yeah, I'm a bit of a commit-early, commit-often type, which tends to lead to this :)

Sure. I recommend learning to use rebase efectively at some point though. It's so much easier to find bugs from projects.
Anycase, better to commit often and early, instead of losing data.

Ok, I squashed a whole bunch of commits now...should be better I hope..

Cool. Looks way better imho :)
Give it 1-2 years and rebase and history cleaning is just normal task :P

Btw. Not exatly for this, but could there be addWaypoint button next to setDestination? info system info and saved locations?

There used to be such a button in the destination list if I recall, I may even have been the one who removed it at some point cause I didn't see the need for it and found it cluttering and confusing :$

Well.. I personally check route distances between 2 random entry systems (e.g. 2 maps) setting the first as destination and second as waypoint. The game calculates "N+" number as jumps and the real distance is "N-1". So to find best hisec entry to travel to some other map (e.g. operation) I use that system. Thus the add waypoint would be really handy. Though I think that button can be way smaller than the set destination.

Actually, I implemented a feature for that in my feat_mapoverlap branch (https://github.com/proycon/eve-wspace/tree/feat_mapoverlap). It shows distance between all k-space exits/entries on all maps (and mentions on which map it is). It's not in this PR as it's a bit unpolished still because it doesn't take any map permissions into account.

Omg. that would be handy! I hope you get it polished some day.
Still I'm pretty sure that add waypoint might be usefull sometimes. As it's not so ofthen the button could be small or otherwise less space taking. Even if we can get that as context menu for set destination button, that could work.
Or actually the system name. Right click (or left if that is ok) the system name and it would show context menu with actions "show info", "set destination" and "add waypoint".

:+1: better than attempting to double click on something ten times before it works.
On Wed, Feb 24, 2016 at 4:47 PM, Jaakko Kantojärvi
<EMAIL_ADDRESS>wrote:

Omg. that would be handy! I hope you get it polished some day.
Still I'm pretty sure that add waypoint might be usefull sometimes. As it's not so ofthen the button could be small or otherwise less space taking. Even if we can get that as context menu for set destination button, that could work.
Or actually the system name. Right click (or left if that is ok) the system name and it would show context menu with actions "show info", "set destination" and "add waypoint".
Reply to this email directly or view it on GitHub:
https://github.com/evewspace/eve-wspace/pull/241#issuecomment-188312958

Can you rebase this on top of current develop and squash some of the commits at least.  Most are just small style changes so I don't see need for them to be separate commits.

Right, I'll try to get onto this in the coming days.

Sorry for the delay, I just rebased my minoruiimprovements branch on the develop branch. I'm a bit confused about all of the older unsquashed commits being part of this PR though, things seem a bit messy...

I undid my rebase again, will try anew

Rebase complete, conflict resolved.

I'll test this and merge if fine. Thanks in advance.

Also, if you like you can clean up the history and squash some commits if there is no need them to be separate. E.g. commit "Fix regression" could be merged into the commit that created regression.

Tested, looks good except two minor UI issues which I'll put in a new issue. Gonna merge it.


[external] contrib uniformity with HAX editor

Just because it ties into the build routine here and so it'll be easier to track. I need to normalize the hax integration experience across grav, drupal 6,7, wordpress and backdrop to mirror what it now is in drupal 8.
Things to add:

dropdown to pick a CDN with webcomponents.psu.edu/cdn/ as the default

fallback for "other" to manually define one

verify that cms-hax tag is correctly referenced (minor api changes in last few months)

update directions to reflect that cdn is default and then building on own comes after

set redirect-location so it automatically goes to the next page or whatever it was that is doing the saving. This is definitely important in drupal/backdrop with the dedicated tab to hax mode. WP and Grav maybe not since they are currently wysiwyg hijacking methodologies

[x] Backdrop

[x] GravCMS

[x] Drupal 6 (update but dont verify cause lazy)

[x] Drupal 7

[x] Drupal 8

[x] Wordpress

Test these in the hax-all-the-things test bed repo to verify quality and then cut new full releases of everything. This will make it easier when we get to HAXcms integrations more directly. Use D8 as vehicle going foward since we've got symphony components in our own stuff to improve our own backend more rapidly.

We now have UX and install normalization across all platforms we currently support.
Rough edges still:

Grav doesn't do uploads
internal search not enabled
Drupal 6 so old it can't be tested correctly but has all the right code :p


Dynamic swagger.json based on handler functionality

This resolves #190. The example server uses a handler without a delete function. The corresponding swagger.json should accurately reflect this.
Starting the example server and browsing to http://localhost:16006/rest/swagger.json then searching for the /photos/{id} path should yield just the get and patch functionality.

Good to go: 👍. It will be great to have the more accurate OpenAPI (aka Swagger) docs.

This resolves some of #148


Syshealth app: Add await-readiness stats and adapt to Scheduler

I'm gonna generate latest performance report, so need to add new metrics and Scheduler adaption.
Changes:

Adapt the StorageCore to single-threaded Scheduler
Add a new metric to track awaitReady() latency which includes the overhead of the very first model synchronization as well as Scheduler things.

@yuangu-google sorry, I know the PR is kind of messing up your stability work. :(
But fwiw the adaption to new Scheduler arch should be required by both of stability and performance.

@jasonwyatt pls. help double check if I'm using handle.dispatcher correctly for fetch/store/close/etc. I'll base on the Scheduler adaption to generate new performance numbers.


Ready for .net core

Hi Stan! Are you going to add .net core support when Microsoft releases .net core 3.0?

@IASamoylov Yes - hopefully even sooner than that. I plan for the next release to target NetStandard20 (ie. should work for both .NET full and NetCore). The only issue right now is System.Data.SqlClient nuget. MS has broken batching in current version, but fixed it in 4.7.0-preview. I'm waiting for 4.7.0 to finally get released (ie. non-preview - I don't want to take a dependency on a preview package). All tests pass on 4.7.0-preview, so everything works.
If anyone notices that SqlClient 4.7.0 is released - ping me.

4.7.0 just released a few days ago. Regards
https://www.nuget.org/packages/System.Data.SqlClient/

@sdrapkin I've been running a build targeting 4.7.0-pre in production for a month plus, no issues as far as I can tell. If there is any way to help out with releasing a package update, please let me know. Thanks for your work on this!

@sdrapkin ping! :) ANything I can help with to get a .NET Core build out?

Everyone, sorry for the lack of progress on this one and the delayed response - I've been away.
I'll get on it asap.

TinyORM.1.3.0.zip
Can someone please sanity-test in their environments, to make sure it's ok to publish to Nuget?

@sdrapkin giving it a quick try now.

@sdrapkin all my persistence tests pass, I can run my app locally with the new package. .NET Core 3 app.

Pushed to Nuget.

Awesome, thanks @sdrapkin


[Identity] Add identity layer test

Dependency of the PR
Commits to be reviewed in this PR
[Identity] Add identity header
This patch add identity layer header.
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[Identity] Implement and connect identity layer
THis patch implement and connect identity layer
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>
[Identity] Add identity layer test
This patch add identity layer test
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1795. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


Update vite versions for example applications

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Clean Atlas, Amundsen and metadata_rest

We should only send requests to the sink in the shape of Create requests (or custom models passing required info such as FQN etc).
This way we will be able to clean up the write_tables method from the sink, as it won't be needed anymore

I will be working on this issue.


Add CreateFile/CompleteFile support in worker

What changes are proposed in this pull request?

client sends CreateFile request to worker
worker checks if the target file already exists
worker calls UFS.create() to create an OutStream
worker returns a FileInfo and UUID back to client. Client should embed this UUID in subsequent requests
client closes OutStream. It sends CompleteFile to worker, and worker closes open file handle, updates local metadata.

Why are the changes needed?
To support write.
Does this PR introduce any user facing changes?
N/A

LGTM

alluxio-bot, merge this please


Framework aborts if JSON manifest parsing fails

It appears as if JSON manifests are not even syntax-checked by the resource compiler and the Framework calls abort() if parsing a manifest fails. The Framework should never, ever abort() based on external data. If parsing fails, throw an exception, refuse to install the Bundle, etc.
Try leaving a comma out of a manifest like so:
{
  "bundle.name" : "foo"
  "bundle.version" : "1.0.2",
  "bundle.description" : "This bundle is broken!",
  "authors" : [ "John Doe", "Douglas Reynolds", "Daniel Cannady" ],
  "rating" : 5
}

Add this to a bundle and attempt to install it; you'll die with something like this:
In BundlePrivate at /tmp/CppMicroServices/core/src/bundle/usBundlePrivate.cpp:66 : Parsing of manifest.json for bundle /examples/baaad failed: * Line 8, Column 3
Missing ',' or '}' in object declaration
[  9] 0x00007fff8c60d6df abort+00000129 at /usr/lib/system/libsystem_c.dylib+386783 (no debugging symbols found)
[ 10] 0x00000001126d8ffa us::LogMsg::~LogMsg()+00000314 at /libCppMicroServices.3.0.0.dylib+94202 (no debugging symbols found)
[ 11] 0x0000000112707e38 us::BundlePrivate::BundlePrivate(std::__1::shared_ptrus::Bundle const&, us::CoreBundleContext*, us::BundleInfo*)+00003848 at /libCppMicroServices.3.0.0.dylib+286264 (no debugging symbols found)
[ 12] 0x00000001126fbc97 us::Bundle::Init(us::CoreBundleContext*, us::BundleInfo*)+00000103 at /libCppMicroServices.3.0.0.dylib+236695 (no debugging symbols found)
[ 13] 0x00000001127092f8 us::BundleRegistry::Register(us::BundleInfo*)+00000968 at /libCppMicroServices.3.0.0.dylib+291576 (no debugging symbols found)
[ 14] 0x00000001126ff00c us::BundleContext::InstallBundle(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&)+00000140 at /libCppMicroServices.3.0.0.dylib+249868 (no debugging symbols found)

Thanks you for the report, I agree that we need to validate the data early and not abort in case of malformed data.

Presumably, this was fixed in #119. Now, if JSON manifest parsing fails, we throw an exception
       try
        {
          bc.InstallBundles(testing::LIB_PATH + testing::DIR_SEP + US_LIB_PREFIX + "TestBundleKrish" + US_LIB_EXT);
        }
        catch (std::exception& e)
        {
          std::cout << "EXCEPTION: " << e.what();
        }
        std::cout << "BAR\n";

TestBundleKrish is a bundle with the malformed manifest.json
Output:
EXCEPTION: Failed to install bundle library at L:\devel\CppMicroServices_build\bin\Release\TestBundleKrish.dll: Parsing of manifest.json for bundle TestBundleKrish at L:\devel\CppMicroServices_build\bin\Release\TestBundleKrish.dll failed: * Line 3, Column 3
  Missing ',' or '}' in object declaration
BAR

Closing, as I can't seem to reproduce this issue


Add basic snapshot support

Add support to create snapshots within the pgstream library.
This will cover an initial implementation based on the existing approach used by pgroll backfilling, by performing a dummy operation for all rows in the table, which will trigger replication WAL events creating a snapshot of the database state. Batching should be used to manage the impact of the snapshot on the database, as well as the replication ingestion.
Solution 1
The snapshotting behaviour would be abstracted by a server that receives requests to perform a snapshot for a given schema, table, and identity column(s). This server would insert a row in a postgres table, snapshot_requests, which will generate a WAL event. This event would be intercepted by the snapshot watcher, a decorator around the processor (similar to the translator) that will watch out for insert WAL events for the snapshot requests table, and trigger a snapshot in the background.
This is an initial design implementation, trying to keep the process simple (assuming a single snapshot watcher per pgstream system).

Adding the snapshot watcher as a decorator to the processor instead of being its own processor means it can be used in implementations with no fanout module (such as Kafka), where only one processor can be used at a time. Given the importance of the snapshotting for pgstream adoption, it should be a priority to consider a solution that works with all configurations.
Solution 2
Another alternative would be to use a snapshot service that is not tied to pgstream, and that polls the snapshot_requests table for new requests. This allows us to decouple the snapshoting mechanism from the pgstream replication slot. A server would still receive the snapshot requests as in solution 1, and store them in a snapshot_requests table, but instead of waiting for those inserts to make it down the replication slot, a background task worker (snapshot generator in the graph below) just polls periodically the requests table and process them concurrently. This allows to store the snapshot requests in any store without relying on the replication slot to process them.
In addition to enable the processor implementations to request snapshots, we could have a snapshot signaler wrapper around the processor, that identifies core snapshot scenarios common to all processors (i.e, triggering initial snapshots when connecting pgstream).

Decision
Solution 2 is favoured over solution 1 since it allows us to remove a dependency on the replication slot for snapshotting.

This issue will be closed in favour of implementing a more sturdy approach to performing the initial snapshotting.


Shifted pointer pointermove

Browser
Chrome
Firefox
OL version
5.3.1
Describe the bug
The pointer icon is shifted respect the feature
To Reproduce

Create a React app
Create map with multiple layers and feature
Add event listener pointermove
See error

this.map.on('pointermove', (e) => {

  if (e.dragging) return;

  const pixel = map.getEventPixel(e.originalEvent);

  let hit = false;

  this.map.forEachFeatureAtPixel(pixel, (feature, layer) => {
    if (layer === 'BackLayer') {
      hit = true
    }
  }

  map.getTargetElement().style.cursor = hit ? 'pointer' : '';

}

this behaviour does not happen everytime O.o
Expected behavior
Cursor pointer shows exactly on the feature, if outside the feature cursor must be the default one

you seem to have an icon in you screenshot; do you observe this while the cursor is above this icon or above the line? (or both?)

When the pointer is on the icon  it is the default one, outside the icon it turns into the Hand
Anyway don't care about the line and the poly, the icon represents a feature with specific position

can provide a minimal example in a CodePen or similar that shows the issue?


Neutron aliases do not accept a content block.

Aliases need to be updated to pass a content block to the parent mixin.

Fixed and added some more aliases for future-proofing.
https://github.com/NeutronCSS/neutroncss/commit/1206bf1f227875830724b8f390f50e09017ca0d6


add '-march=armv7-a' to all armv7 linux targets

This is related to my other changes that add support for chromeos specific target triples.

Thanks!


parallel: Fix .collect() for the element par iters

They must not define opt_len to return Some (reserved for indexed iterators).
Added test that shows problem and verifies the fix

tests fail due to prerelease version stuff..


(minor) correcting badly formatted test

It was a rogue space in the test. serves me right for not using an IDE with an auto-formatter
I can confirm the branch build is green. Good to go. Sorry about that

Thanks I'll see whether I can get circle ci running these pre-merge


Tag Innereye workspace template in Terraform

As a TRE developer,
I want to tag Innereye Workspace template
So that this template include information for TRE id and TRE Workspace id
Acceptance Criteria

[ ] Have tre_id tag in the Innereye Workspace template
[ ] Have tre_workspace_id tag in the Innereye Workspace template

closing this story as there's nothing to tag here, the workspace is based on base workspace which was tagged in #1970  and innereye workspace service which was tagged in #1894


Support for AV2010/21A

Support for the Bitron Contact Sensor AV2010/21A
All npm tests passed successfully

This should be the correct line for zigbee2mqtt/lib/extension/homeassistant.js
    'AV2010/21A': [configurations.binary_sensor_contact, configurations.sensor_battery],


Allow cors handler to specify which method is allowed.

Currently, we control cors at host level without checking methods. Need to add another level of control at method level when host is allowed. The cors.json need to be changed.

We can have method level control per host but it will make the configuration to messy and hard to maintain. In most of the use cases, people just want to control methods for all hosts.


[Bullet] body_test_motion causes crash when used with a Rigidbody in Kinematic mode and Bullet

Godot version
3.3.stable
System information
Windows 10
Issue description
The issue is the same as in https://github.com/godotengine/godot/issues/51847, which was fixed in https://github.com/godotengine/godot/pull/50103, but for a RigidBody in Kinematic mode. This case is not fixed by https://github.com/godotengine/godot/pull/50103.
The same crash happens when calling kinematic methods of KinematicBody, when this body's mode has been changed to Rigid and back to Kinematic using the PhysicsServer.
Steps to reproduce
Run the attached project
Minimal reproduction project
PhysicsBody_to_kinematic.zip

Fixed by #53118.


Can't Scroll while using Diz

I imported and used the library into my website but I cant scroll up or down, it simply freezes the page

Hi,
Thanks for trying it out!
Hiding the page scrollbar was done by design because Divz is intended to be a 'fullscreen' experience that can use vertical scroll/swipes for the 3D navigation between its child div items. If you use Divz in a page that scrolls, then page scrolling will trigger the Divz navigation and vice versa.
However I realise there may be some limited use cases, so I have released a small update in v1.1.6 with a new prop called isScrollPageEnabled that you can set to true to override the default behaviour.
<Divz isScrollPageEnabled={true}>
Cheers,
Lewis


Add deprecation notice to readme

Signed-off-by: GuessWhoSamFoo<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 1390

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.511%

Totals

Change from base Build 1386:
0.0%

Covered Lines:
12587

Relevant Lines:
17851

💛  - Coveralls

All good things come to the end. Big thanks to @bryanl , @jessicayuen , @anguslees , @hausdorff , @shomron @abiogenesis-now , @jbeda  and everyone else, who supported, contributed and pushed it forward. It was very important step in declarative app management space and it definitely left a footprint or two :)


exporting and then importing results in the server does not support credential metadata, requires >= 2.6.x error

What version of the credhub server you are using?

1.9.3

What version of the credhub cli you are using?

$ credhub --version
CLI Version: 2.8.0
Server Version: 0.0.0

If you were attempting to accomplish a task, what was it you were attempting to do?

With the current CLI (2.8.0), when we credhub export and then credhub import we receive an error on many credentials of the server does not support credential metadata, requires >= 2.6.x.
It appears that the export includes an empty field for each credential of metadata: {}.
The import is then not able to use this and errors on the import.

What did you expect to happen?

Not to receive this error.
Most likely, credhub export would export a field that is unsupported by the server it is exporting from.

What was the actual behavior?

This error message on every credential trying to be imported -- the server does not support credential metadata, requires >= 2.6.x
The 2 that we manually added, which did not have the metadata: {} worked. As can be seen in the following output.
Example output:
Import complete.
Successfully set: 2
Failed to set: 123
.... more of the same ...
 - Credential '/concourse/main/abrown-deploy-key' at index 113 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/networking_poe_ssl_certs' at index 114 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/s3_access_key_id' at index 115 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/docs-ref-pipeline-repo-uri' at index 116 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/docs-ref-pipeline-repo-key' at index 117 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/s3_region_name' at index 118 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/s3_pivnet_products_bucket' at index 119 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/s3_secret_access_key' at index 120 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/ab-opsman-ssh-key' at index 121 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/reference-pipeline-development/vsphere_ssh_key' at index 122 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/reference-pipeline-development/opsman-ssl' at index 123 could not be set: the server does not support credential metadata, requires >= 2.6.x
 - Credential '/concourse/main/reference-pipeline/opsman-ssl' at index 124 could not be set: the server does not support credential metadata, requires >= 2.6.x
One or more credentials failed to import.

Fixed by #105. Will be released in the next version of cli. Thanks for reporting the issue!


Changed isReady to contentReady property

For #3241
Replaced Cesium3DTile#isReady function with a readonly Cesium3DTile.contentReady property and added documentation.
Do I need to mention any changes in CHANGES.md?

Do I need to mention any changes in CHANGES.md?

You don't have to because 3D Tiles isn't in master yet.

:+1:.

Looks good.


cmd: add backup command to dump meta to a file or load from a file

close #50
Todo:

[x] calculate slice refs when loading
[ ] customize json marshal to stream encode/decode; and to make the dumped file more compact

@Sandy4999 Could you add a few unit tests for them?  loading a sample file into redis/db, verify some functions, then dump it again, and compare the  results.


[Scalar] Remove a now unnecessary check.

Reduces the difference between llvm.org and github.
rdar://problem/35898017

@swift-ci test and merge


Add lenient ident validation

Changes

Current dependencies on/for this PR:

main

PR #303   👈

This stack of pull requests is managed by Graphite.


about icon

hi @abougouffa
I reinstalled your .emacs.d to make sure the environment is clean
Re-downloaded emacs29.0.90     build with ./configure --with-native-compilation
make && make install
then  open emacs  there is some problem  need your help

the icon and icon size looks abnormal
i have rebuild all package  but not resolved
I don't know if it's a  unicode-fonts problem  run (unicode-fonts-setup)  nothing happened

back to 28.2  also problematic

doom-modeline now depends on nerd-icons, I did not execute nerd-icons-install and it has been resolved


Update sbt-scalafix to 0.9.34

Updates ch.epfl.scala:sbt-scalafix from 0.9.29 to 0.9.34.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #90.


[Missing] 404 - Documentation - Custom Edge

https://reactflow.dev/examples/custom-edge ist not found --> 404
The link was found at: https://reactflow.dev/docs/api/edge-utils/

thanks, I updated the docs! We have a repo for the docs incase you find another bug https://github.com/wbkd/react-flow-docs

thanks, I updated the docs! We have a repo for the docs incase you find another bug https://github.com/wbkd/react-flow-docs


chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.10.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.8.11 -> v1.10.0

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper
v1.10.0
Compare Source
Features

add common function to generate test SSH keypair (#551) (c7cf345)

v1.9.2
Compare Source
Bug Fixes

deps: update gomod (#549) (5689c4c)

v1.9.1
Compare Source
Bug Fixes

deps: update gomod (#547) (d8c479a)

v1.9.0
Compare Source
Features

output human-readable change log when the consistency test fails (#544) (2ff81e4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix '-e' option

echo "$1" | cut -c 1 doesn't work with '-e'. It seems that '-e' is interpreted as an option of echo. A possibility I saw to fix quickly, is to use printf instead. Maybe you like to merge that fix.

Thanks!


Added UIButton.ButtonType support to SwiftUI Button

With this is possible to bridge the defaults UIKit button types like this:
Button("", action: {}).buttonType(.close)
I don't know if this is the right place or the filename is right. Fell free to modify.

@lorenzofiamingo this seems great, but also a bit of a hack (UIButton within a SwiftUI Button 😅), so I'm a bit hesitant to add this. Is there a better way of extracting the relevant system image? Or do these button types map directly to relevant SF Symbols?

@lorenzofiamingo, maybe you could make a special Button Type/View for each one, like EditButton() except InfoButton(action:) or CloseButton(action:).
What I'd do, based on my understanding of how this works:
public struct InfoButton : View {
    var action : () -> ()
    public var body: some View {
        Button(action: {
            self.action()
        }) {
            EmptyView()
        }.buttonStyle(ButtonOfTypeStyle(type: .infoLight))
    }
    public init(action: @escaping () -> ()) {
        self.action = action
    }
}

If you'd like to make it so infoLight goes to infoDark in dark mode just add: @Environment(\.colorScheme) public static var colorScheme above var action: () -> ()
and replace .infoLight with self.colorScheme == .light ? .infoLight : .infoDark

@lorenzofiamingo this seems great, but also a bit of a hack (UIButton within a SwiftUI Button 😅), so I'm a bit hesitant to add this. Is there a better way of extracting the relevant system image? Or do these button types map directly to relevant SF Symbols?

Mmm... There are similar (but not exactly same) SFSymbols but I don't like just to replicate the same behavior: Apple can change it in the next versions of iOS.

@lorenzofiamingo I'm closing this PR for the time being - but feel free to reopen if there's a different approach to this. I feel like Apple wants us to use SF Symbols over older and more constrained style enums - so I'm not considering it in scope of this library. I am working on a more opinionated UI library though, called UserExperience. This might a good fit there :)


:white_check_mark: Test: Add more test coverage to tevm/actions

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1309  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


When train the model with running main.py, i triggers a TypeError

Error message is as follow:
File "F:/Implementation-CVPR2015-CNN-for-ReID-master/CUHK03/main.py", line 109, in
main('F:/Implementation-CVPR2015-CNN-for-ReID-master/CUHK03/cuhk-03.h5')
File "F:/Implementation-CVPR2015-CNN-for-ReID-master/CUHK03/main.py", line 21, in main
train(model, dataset_path)
File "F:/Implementation-CVPR2015-CNN-for-ReID-master/CUHK03/main.py", line 49, in train
model.fit_generator(Data_Generator.flow(f,flag = flag_train),
one_epoch,epoch_num,
validation_data=Data_Generator.flow(f,train_or_validation=which_val_data,flag=flag_val),
nb_val_samples=nb_val_samples)
File "E:\Anaconda\lib\site-packages\keras\legacy\interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "E:\Anaconda\lib\site-packages\keras\engine\training.py", line 2079, in fit_generator
do_validation = bool(validation_data)
TypeError: 'float' object cannot be interpreted as an integer
python version: 3.5.2
keras version:2.1.5
tensorflow-gpu:1.7
OS:windows 10
It seems that bool() need a integer argument,but  'validation_data'  is an object of  class 'NumpyArrayIterator_for_CUHK03 '. I don't know how to deal with it.Thanks for your help.
@Ning-Ding

@Geek-Peng  you have to use keras version 2.0.0 since the numpy structure in keras version >2 is different


Each column render cycle adds already existing classes

Each rendered cell contains classes from previous row.
Eg.
header (first render):
Odesílatel

first row:
...

second row:
...

This is caused by multiple usage of Html instance stored in \Ublaboo\DataGrid\Column\Column::$el_cache.

@Danoha Hello, do you have inline edit enabled?


Embedd tasking manger functionality inside microside

All tasks should be accessible from the micro side.
It should be possible to lock/ unlock tasks from within micro side.
It should be possible to display tasks from several projects at once.

Agreed.  Keep an eye on the TM API for full support for this: https://github.com/hotosm/osm-tasking-manager2/wiki/API
Would require:

task_details
lock
unlock

functionality supported by the API.  Pierre discussed the issues with these (particularly, authenticating 3rd-party apps for post requests--i.e. lock/unlock calls) at the Summit.  Will take some time to develop.


Unclear instructions

Challenge Waypoint: Use Conditional Logic with If Statements has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:42.0) Gecko/20100101 Firefox/42.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
// Example
function ourFunction(testMe) {
  if (testMe > 10) {
    return "Yes";
  }
  return "No";
}

// Setup
function myFunction(testMe) {

  // Only change code below this line.
  if (testMe > 5) {
    return "Yes";
  }
  return "No";

  // Only change code above this line.

}

// Change this value to test
myFunction(10);

The instructions for this Waypoint are somewhat unclear. They state Create an if statement inside the function to return "Yes" if testMe is greater than 5. Return "No" if it is less than or equal to 5; however, the last sentence raises the question as to whether an else statement is required for the additional condition. Since else statements haven't been taught yet, that would seem to argue for a "no," but the wording suggests an else statement is expected.
If an else statement is not necessary to handle the second condition, the final sentence should be changed to Return "No" otherwise. I would also like to see a discussion somewhere along the line of the utility and logic of a final else statement vs. no final else statement, as this shows up as a key logical step in the last few beginning Bonfires.

When I was re-writing the Basic Javascript Curriculum, I explicitly and deliberately decoupled if and else statements.  When hanging out in the help rooms I saw that people would slavishly include an else for every single if they wrote and I wanted to break that habit before it started.  That's why these waypoints are presented in this order.
You'll note that there is no mention of else anywhere in the curriculum prior to this introduction (I don't think anyway) so a truly new user wouldn't know to even try to use else.
I also wanted them to think about what being greater than vs less than equal to meant.
I don't necessarily object to the idea of return "no" otherwise, but I don't think it's critical either.

I hear you. Still, I would argue that the wording calls for two explicit conditions, not one explicit and one implicit. So if you'd like to avoid the slavish use of else, even in the minds of those who know about it, I would argue for the wording change. :)

I'm open for a PR if you're up to it.  :wink:

Don't know what that is or how to do it. :/

A PR is a Pull Request:
https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/How-To-Create-A-Pull-Request-for-Free-Code-Camp
Tell you what -
If you propose the whole text, or the part that you'd like to change, I can see about actually making the change.

Sure! I would simply go with
Create an if statement inside the function to return "Yes" if testMe is greater than 5 and return "No" otherwise.

And thanks much! Git is not something I want to fork around with before I'm ready, if you get my drift. ;)

Thanks, @SaintPeter , @raisedadead !


Refactored Code

Refactored the get_user function and globalized the GitHub API URL

@CodiumAI-Agent /describe

Title
Refactoring and Error Handling Enhancement in API Functions

Type
Enhancement, Bug fix

Description
This PR includes a significant refactoring of the code in the 'functions.py' file. The GitHub API URL has been globalized, and the 'get_user' function has been refactored for better readability and efficiency. Additionally, error handling has been enhanced by importing specific exceptions from the 'github' module, which will provide more precise error messages in case of exceptions.

PR changes walkthrough
Relevant files                                                                                Enhancement, error handling1 files

functions.py

        functions.py
The 'get_user' function was refactored to improve readability and efficiency. The GitHub API URL was globalized for better maintainability. Specific exceptions were imported from the 'github' module to enhance error handling. The same changes were applied to the 'validate_alx' and 'get_all_repos' functions.

 +16/-13

___
## User description
Refactored the get_user function and globalized the GitHub API URL

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Code Refactoring
📝 PR summary: This PR refactors the get_user function in functions.py and globalizes the GitHub API URL. It also improves error handling by importing specific exceptions from the github module.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 2, because the changes are straightforward and limited to a single file. However, the absence of tests increases the review effort slightly.
🔒 Security concerns: No

PR Feedback

💡 General suggestions: The refactoring of the get_user function and the globalizing of the GitHub API URL are good improvements. However, it would be beneficial to add tests to ensure the refactored code works as expected.

 🤖 Code feedback:

relevant file: functions.py
suggestion: Consider using a configuration file or environment variables for the GitHub API URL. This will make the code more flexible and easier to manage in different environments. [important]
relevant line: URL = "https://api.github.com"

relevant file: functions.py
suggestion: It would be better to use more descriptive variable names. For instance, 'g' could be renamed to 'github_client' for better readability. [medium]
relevant line: g = Github(base_url=URL)

relevant file: functions.py
suggestion: Consider handling exceptions more specifically. For example, you could log the error message or provide a more user-friendly message instead of just returning None. [important]
relevant line: except (GithubException, UnknownObjectException):

How to use
  Instructions

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@CodiumAI-Agent /improve

@CodiumAI-Agent /ask What is the primary purpose of the get_user function

Question: What is the primary purpose of the get_user function
Answer:
The primary purpose of the get_user function is to retrieve the user object from the Redis cache.
If the user object is not found in the cache, the function makes a request to the GitHub API to fetch the user data, then stores this data in the Redis cache with a 24-hour expiration time.
If the user object is found in the cache, it is returned as a Python dictionary.
In case of any exceptions during the GitHub API call (like GithubException or UnknownObjectException), the function returns None.

@CodiumAI-Agent /add_docs

/describe

@CodiumAI-Agent /describe


Adjust network of trust mechanism

The api host should be able to adjust its network of trust approach for instance it should be able to decide:

who can verify others which are then able to verify others
who can verify others but only things so not one who is then able to verify another one
who can verify others but no one else

=> currently we have
VerifiedIdentityCredential and BasicIdentityCredential
this should be able to be set by the api itself.

remove initiatorId

Also consider what should be done on application layer for instance the backend calling the api.

will create tasks out of the discussion #275


ci(ci): move from veracode to snyk code

https://coveord.atlassian.net/browse/KIT-1443

Looks like the problem with most of these ReactSetInnerHtml errors is mostly just that it doesn't like us using innerHTML at all? Maybe we should still look into eliminating innerHTML from most of these places (even though they are all escaped)

Every place where innerHTML is used is for a good reason, and removing them would mean breaking a useful end user feature.