FINERACT-1557: Fixes integration tests

Description
There were some issues in the integration-test project and that were blocking the release process (Github Actions), some of them were related to use 0 and 1 instead of boolean values in queries, other case were related to business logic that were causing exceptions
Apache Fineract JIRA FINERACT-1557.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

There's a failing test case on PostgreSQL as well: testLoanScheduleWithInterestRecalculation_WITH_ORIGINAL_REPAYMENT_BASED_ARREARS_AGEING()

Included in https://github.com/apache/fineract/pull/2279


Firefox SyntaxError: The URI is malformed on language change.

Error on line 313. Url for xmlHTTP request is "/users/UserName"

Fixed as of 29274625e3db92b2c7df023a11dfaca9a43ed697


Only transfer one fd at a time

The previous code would pass all file descriptors as auxiliary data in a
single cmsg. This, it turns out, very easily hits limits on the size of
cmsg aux data. In practice, this happened at around 300 to 500 listening
sockets.
This changes the code to only pass one at a time, adds a test that
failed before, and for good measure switches to a different upstream
library for doing the transfer.

Tossed in a commit to avoid the race a test was hitting. There might be a better fix, but as best I could tell it would be quite involved, so I've offloaded a bit more cleanup onto our callers instead.


DOC-7565: Reply to messages page needs animated GIFs for mobile app workflows

Summary
This PR adds visual workflows for the Mattermost mobile app tab on the Reply to messages page.
Ticket Link
Fixes #7565

[x] This PR follows Mattermost Contributing Guidelines.
[x] The changes are tested in a local docs build.

Hello @Rutam21,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm Please review and suggest changes, if any. Thanks.

@Rutam21 - The image quality of these mobile images is considerably lower than others you've contributed recently. Is there a way to increase the image quality to avoid the checker-pattern effect when the image is displayed via docs?

@cwarnermm I have updated the GIFs. Please check if the image quality looks okay now.

@Rutam21 - In your latest commit, I noticed that you changed the :scale: value for the screenshots. That hasn't improved the image quality (expected). The scale attribute resizes the image, it doesn't affect image quality.
I recommend reviewing your capture tool configuration -- that's likely where the lower-res quality is coming from.

@cwarnermm I have not only changed the scale but also updated the GIFs with totally newer ones. Please find the screenshot of the updated ones below. This is visible in the preview environment. Are you still seeing them pixelated or distorted?


Change split_from and split_to from int64 to float64

Bugfix for this split:
2022/10/10 13:26:39.854395 ERROR RESTY json: cannot unmarshal number 3.83227428463e+11 into Go struct field Split.results.split_from of type int64, Attempt 1
Error: failed to execute request: json: cannot unmarshal number 3.83227428463e+11 into Go struct field Split.results.split_from of type int64

To match the models in go-apps-reference-splits.

@Darcy-Linde I believe you did these models. Can you please check the other models closely to make sure they match the docs.

@qrpike @clickingbuttons isn't this technically of a breaking change?

@qrpike @clickingbuttons isn't this technically a breaking change?

Yes, but it's also a critical bug. That's why I'm curious what you think it should be released as.

I need to run some Docker things that have this change so I'm merging but not releasing.


TaskRun stays Running when pod goes to FailedMount

Expected Behavior
When a TaskRun can't correctly mount the volume, it should fail.
Actual Behavior
The TaskRun's remains "Running" with the message Pending until it eventually times out. The events with the error are at the pod level.
Steps to Reproduce the Problem

Create a TaskRun with an inexistent config map or secret mount

Additional Info
Very similar issues:

https://github.com/tektoncd/pipeline/issues/4895
https://github.com/tektoncd/pipeline/issues/4890

This comment summarizes the findings for reproducing the 'failedMount' for TaskRun and suggests closing this.

Pod level status:

pod status "Initialized":"False"; message: "containers with incomplete status: [prepare place-scripts]"

Pod status output:

FailedMount

state:
      waiting:
        reason: ContainerCreating

ImagePullBackOff

 state:
      waiting:
        message: Back-off pulling image "does-not-exist:latest"
        reason: ImagePullBackOff

Compared with what's for #4895, where the ImagePullBackOff error can be captured, there is no appropriate way for this issue to be resolved as we could not tell if the volume has been correctly mounting or it should fail. Thus, this shall be closed for now.

Maybe we should consider having a timeout specific for the "ContainerCreating" status? Or maybe we can check if there's any ongoing discussions about this on Kubernetes itself.
I just don't feel this issue should be closed just because we don't have this info on the pod's state. There are still alternatives to consider, I think

A timeout specifically for the containerCreating status sounds too low level for most CI/CD use cases.
I get that the current situation isn't ideal but I think the best course right now is to have this fixed in Kubernetes (see https://github.com/kubernetes/kubernetes/issues/88193)  and have this information surfaced somewhere in the Pod's status.

A timeout specifically for the containerCreating status sounds too low level for most CI/CD use cases.

I'm not sure what you mean by "too low level". I understand that maybe it's not something you want to customize at the Task/TaskRun level, but maybe at controller level would be fine. Tekton is very "low-level" in that sense, I think.

I get that the current situation isn't ideal but I think the best course right now is to have this fixed in Kubernetes (see https://github.com/kubernetes/kubernetes/issues/88193) and have this information surfaced somewhere in the Pod's status.

It's good to know that Kubernetes has an issue similar to this, but it's not clear to me if they will add to the state.waiting fields.

If you have a specific alternative to consider, let us know!

Can't we look at the events directly then? I think that if we had a watcher over events we could use it for more than one scenario. Alternatively, we could only call the Events API when the controller notices the task is stuck on ContainerCreating for too long.

I'm not sure what you mean by "too low level". I understand that maybe it's not something you want to customize at the Task/TaskRun level, but maybe at controller level would be fine. Tekton is very "low-level" in that sense, I think.

A controller level timeout would make more sense but I think it would be hard to come up with a timeout value here that will work for all runs in a cluster

Can't we look at the events directly then? I think that if we had a watcher over events we could use it for more than one scenario. Alternatively, we could only call the Events API when the controller notices the task is stuck on ContainerCreating for too long.

This might work - but I'm not sure if we can rely on it all the time:
From https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/event-v1/:

"Event consumers should not rely on the timing of an event with a given Reason reflecting a consistent underlying trigger, or the continued existence of events with that Reason. Events should be treated as informative, best-effort, supplemental data."


Remove ready-for-review label if changes are requested

Which issue this PR addresses:
Fixes TBD
What this PR does / why we need it:
If a PR is "ready-for-review", but subsequently a code owner requests changes, this action automatically removes the ready for review label until the author is able to address the changes requested. Once they do, they can re-add the label.
This action will not take effect on approved or just commenting reviews, only newly submitted reviews that request changes.
Test plan for issue:
Tested this a bunch on https://github.com/cblecker/test-repo/pull/1 and it works as expected.
Is there any documentation that needs to be updated for this PR?
No, this just alters the workflow to remove a label.

@bennerv it definitely could be reviewed and I've tested and it works.. I just haven't decided if it's a good idea or passed it around for feedback. If you have thoughts, I'm open to them.

@bennerv it definitely could be reviewed and I've tested and it works.. I just haven't decided if it's a good idea or passed it around for feedback. If you have thoughts, I'm open to them.

I'm going back and forth. I think it's fair to have changes requested on a PR that's ready-for-review since the author can still be soliciting responses from others.  It might create more churn in our review process since people forget to update the labels or constant back and forth between ready-for-review & changes requested.
But, it does make sense in practice.  Someone doesn't necessarily need to review a PR that requires changes on it.


Codemirror tweaks

This is branched off the code folding PR, and should not be merged until it is merged.
Added the following CodeMirror features:

Code search/replace
Auto-closing HTML tags
Auto-closing curly braces ({{ }})
Active-line highlight
Trailing space highlight
Making tabs visible in code editor

Issues: #1201 #1202 #1622

Nice. This looks good. Ready to merge I think!

Yay!


[PYTHON/FFI] Search PATH for DLLs

Adds support to search PATH for TVM DLLs.
@tqchen @Huyuwei would you be able to take a look?

Upon second thought, does it make sense to search the PATH for dynamically linked libraries? traditionally tools which link only search link paths, the PATH variable is intended to only be used for resolving executable names in shells.

I'm not sure that PATH is only intended to be used for executable names. For example, when you create an environment in Anaconda on Windows, /Library/bin has lots of DLLs.


Could not locate a supported Microsoft Visual C++ installation

    raise RuntimeError("Could not locate a supported Microsoft Visual C++ installation")
RuntimeError: Could not locate a supported Microsoft Visual C++ installation

this is what I'm getting after running this:
python test.py --name=epoch --epoch=20 --img_folder=./datasets/examples
what am I missing?

Windows
On Windows, nvdiffrast requires an external compiler for compiling the CUDA kernels. The development was done using Microsoft Visual Studio 2017 Professional Edition, and this version works with both PyTorch and TensorFlow versions of nvdiffrast. VS 2019 Professional Edition has also been confirmed to work with the PyTorch version of nvdiffrast. Other VS editions besides Professional Edition, including the Community Edition, should work but have not been tested.
If the compiler binary (cl.exe) cannot be found in PATH, nvdiffrast will search for it heuristically. If this fails you may need to add it manually via
"C:\Program Files (x86)\Microsoft Visual Studio......\VC\Auxiliary\Build\vcvars64.bat"
where the exact path depends on the version and edition of VS you have installed.


growth fetch session cache slot

Versions
github.com/Shopify/sarama v1.26.0
Configuration
c.ClientID = getEnv("sarama")
c.ChannelBufferSize = getEnvInt("256")
c.Version = sarama.V2_4_0_0

c.Net.MaxOpenRequests = 1
c.Net.DialTimeout = time.Duration(getEnvInt("T30")) * time.Second
c.Net.ReadTimeout = time.Duration(getEnvInt("30")) * time.Second
c.Net.WriteTimeout = time.Duration(getEnvInt("30")) * time.Second
c.Net.SASL.Handshake = false

sslCertFile := getEnv("/srv/tracker-consumer/client.crt.pem")
sslKeyFile := getEnv("/srv/tracker-consumer/client.key.pem")
sslCaFile := getEnv("/srv/tracker-consumer/ca.pem")

if (sslCertFile != "") && (sslKeyFile != "") && (sslCaFile != "") {
 if sslConfig, err := NewTLSConfig(sslCertFile, sslKeyFile, sslCaFile); err == nil {
  c.Net.TLS.Enable = true
  c.Net.TLS.Config = sslConfig
 } else {
  panic(err)
 }
}

c.Metadata.Retry.Max = getEnvInt("1")
c.Metadata.Retry.Backoff = time.Duration(getEnvInt("10000")) * time.Millisecond
c.Metadata.RefreshFrequency = time.Duration(getEnvInt("10")) * time.Minute
c.Metadata.Full = true

c.Consumer.Fetch.Min = int32(getEnvInt("122100"))
c.Consumer.Fetch.Max = int32(getEnvInt("2442000"))
c.Consumer.MaxWaitTime = time.Duration(getEnvInt("2")) * time.Second

c.Consumer.Offsets.Initial = sarama.OffsetOldest

Logs
Initializing new client
ClientID is the default of 'sarama', you should consider setting it to something application-specific.
ClientID is the default of 'sarama', you should consider setting it to something application-specific.
client/metadata fetching metadata for all topics from broker <IP_ADDRESS>:9092
Connected to broker at <IP_ADDRESS>:9092 (unregistered)
client/brokers registered new broker #123 at localhost:9092
Successfully initialized new client
client/metadata fetching metadata for [clicks] from broker <IP_ADDRESS>:9092
client/coordinator requesting coordinator for consumergroup tracker_consumer_group from <IP_ADDRESS>:9092
client/coordinator coordinator for consumergroup tracker_consumer_group is #123 (localhost:9092)
ClientID is the default of 'sarama', you should consider setting it to something application-specific.
Connected to broker at localhost:9092 (registered as #123)
client/coordinator requesting coordinator for consumergroup tracker_consumer_group from <IP_ADDRESS>:9092
client/coordinator coordinator for consumergroup tracker_consumer_group is #123 (localhost:9092)
consumer/broker/123 added subscription to clicks/2
consumer/broker/123 added subscription to clicks/0
consumer/broker/123 added subscription to clicks/1
consumer/broker/123 added subscription to clicks/3

Problem Description
continuous growth in slot consumption
# HELP kafka_server_fetchsessioncache_numincrementalfetchsessions Attribute exposed for management (kafka.server<type=F
etchSessionCache, name=NumIncrementalFetchSessions><>Value)
# TYPE kafka_server_fetchsessioncache_numincrementalfetchsessions untyped
kafka_server_fetchsessioncache_numincrementalfetchsessions 421.0
# HELP kafka_server_fetchsessioncache_incrementalfetchsessionevictions_total Attribute exposed for management (kafka.se
rver<type=FetchSessionCache, name=IncrementalFetchSessionEvictionsPerSec><>Count)
# TYPE kafka_server_fetchsessioncache_incrementalfetchsessionevictions_total counter
kafka_server_fetchsessioncache_incrementalfetchsessionevictions_total 0.0
# HELP kafka_server_fetchsessioncache_numincrementalfetchpartitionscached Attribute exposed for management (kafka.serve
r<type=FetchSessionCache, name=NumIncrementalFetchPartitionsCached><>Value)
# TYPE kafka_server_fetchsessioncache_numincrementalfetchpartitionscached untyped
kafka_server_fetchsessioncache_numincrementalfetchpartitionscached 1674.0

Errors in kafka server.log
Node 1 was unable to process the fetch request with (sessionId=1100333569, epoch=591834): FETCH_SESSION_ID_NOT_FOUND. (org.apache.kafka.clients.FetchSessionHandler)

@aoslepov yes this was a known regression in 1.26.0 and is mentioned in the releases tab:

Fetch requests will cause the Kafka broker to continously allocate new Fetch sessions in its cache on every request. Fixed via #1644

Recommend upgrading to the test fix release v1.26.4


[FEEDBACK NEEDED] Adding new crate items

An upcoming update will feature a TON of new crate items and i need your feedback if you want all of them or of some of them should be removed, or if even some items should be removed from the crate items
complete list of all existing and planned crate items
checked items are already added
commented items (either // or /* */ are not planned yet -> needs feedback)

[x] PUMPKIN
// DECORATION
[x] OAK_SAPLING
[x] SPRUCE_SAPLING
[x] BIRCH_SAPLING
[x] JUNGLE_SAPLING
[x] ACACIA_SAPLING
[x] DARK_OAK_SAPLING
[x] MANGROVE_PROPAGULE
[x] OAK_LEAVES
[x] SPRUCE_LEAVES
[x] BIRCH_LEAVES
[x] JUNGLE_LEAVES
[x] ACACIA_LEAVES
[x] DARK_OAK_LEAVES
[ ] MANGROVE_LEAVES
[ ] AZAELA_LEAVES
[ ] FLOWERING_AZAELA_LEAVES
[ ] COBWEB
[ ] GRASS
[ ] FERN
[ ] AZAELA
[ ] DEAD_BUSH
[x] SEAGRASS
[ ] SEA_PICKLE
/*
[ ] DANDELION
[ ] POPPY
[ ] BLUE_ORCHID
[ ] ALLIUM
[ ] AZURE_BLUET
[ ] RED_TULIP
[ ] ORANGE_TULIP
[ ] WHITE_TULIP
[ ] PINK_TULIP
[ ] OXEYE_DAISY
[ ] CORNFLOWER
[ ] LILY_OF_THE_VALLEY
*/
[x] WITHER_ROSE
[ ] SPORE_BLOSSOM
[x] BROWN_MUSHROOM
[x] RED_MUSHROOM
[x] CRIMSON_FUNGUS
[x] WARPED_FUNGUS
[ ] CRIMSON_ROOTS
[ ] WARPED_ROOTS
[ ] NETHER_SPROUTS
[ ] WEEPING_VINES
[ ] TWISTING_VINES
[x] SUGAR_CANE
[x] KELP
[ ] MOSS_CARPET
// MOSS BLOCK
[ ] HANGING_ROOTS
[ ] BIG_DRIPLEAF
[x] BAMBOO
[ ] TORCH
[ ] END_ROD
//CHORUS_PLANT
//CHORUS_FLOWER
[ ] CACTUS
[ ] SOUL_TORCH
[ ] CHAIN
[ ] GLASS_PANE
[ ] VINES
[ ] GLOW_LICHEN
[ ] LILY_PAD
// SKULK
[ ] SCULK_VEIN
[ ] ANVIL
[ ] WHITE_CARPET
[ ] ORANGE_CARPET
[ ] MAGENTA_CARPET
[ ] LIGHT_BLUE_CARPET
[ ] YELLOW_CARPET
[ ] LIME_CARPET
[ ] PINK_CARPET
[ ] GRAY_CARPET
[ ] LIGHT_GRAY_CARPET
[ ] CYAN_CARPET
[ ] PURPLE_CARPET
[ ] BLUE_CARPET
[ ] BROWN_CARPET
[ ] GREEN_CARPET
[ ] RED_CARPET
[ ] BLACK_CARPET
/*
[ ] SUNFLOWER
[ ] LILAC
[ ] ROSE_BUSH
[ ] PEONY
*/
// CORALS ???
[ ] SCAFFOLDING
[ ] PAINTING
[ ] FLOWER_POT
[ ] BELL
[ ] LANTERN
[ ] SOUL_LANTERN
[ ] CAMPFIRE
[ ] SOUL_CAMPFIRE
[ ] SMALL_AMETHYST_BUD
[ ] MEDIUM_AMETHYST_BUD
[ ] LARGE_AMETHYST_BUD
[ ] AMETHYST_CLUSTER
[ ] POINTED_DRIPSTONE
// REDSTONE
[ ] REDSTONE_DUST
[ ] REDSTONE_TORCH
[ ] REDSTONE_REPEATER
[ ] REDSTONE_COMPARATOR
[ ] PISTON
[ ] STICKY_PISTON
[ ] HOPPER
[ ] LEVER
[ ] LIGHTNING_ROD
[ ] DAYLIGHT_DETECTOR
[ ] SCULK_SENSOR
[ ] TRIPWIRE_HOOK
[ ] REDSTONE_LAMP
// TRANSPORTATION
[ ] POWERED_RAIL
[ ] DETECTOR_RAIL
[ ] RAIL
[ ] ACTIVATOR_RAIL
[ ] MINECART
// MISC
[ ] TURTLE_EGG
[ ] COAL
[ ] CHARCOAL
[ ] DIAMOND
[ ] EMERALD
[ ] LAPIS
[ ] NETHER_QUARTZ
[ ] AMETHYST_SHARD
[ ] RAW_IRON
[ ] IRON_INGOT
[ ] RAW_COPPER
[ ] COPPER_INGOT
[ ] RAW_GOLD
[ ] GOLD_INGOT
[x] STICK
[ ] BOWL
[x] STRING
[x] FEATHER
[ ] GUNPOWDER
[x] WHEAT_SEEDS
[x] WHEAT
[x] FLINT
[ ] BUCKET
[ ] POWDER_SNOW_BUCKET
[x] SNOWBALL
[x] LEATHER
[ ] MILK_BUCKET
[ ] BRICK
[ ] CLAY_BALL
[x] PAPER
[ ] BOOK
[ ] SLIMEBALL
[x] EGG
[ ] GLOWSTONE_DUST
[x] INK_SACS
[x] GLOW_INK_SACS
[x] COCOA_BEANS
[x] BONE_MEAL
[x] BONE
[x] SUGAR
[x] PUMPKIN_SEEDS
[x] MELON_SEEDS
[x] ENDER_PEARL
[x] BLAZE_ROD
[x] NETHER_WART
[x] ENDER_EYE
[ ] PRISMARINE_SHARD
[ ] PRISMARINE_CRYSTALS
[ ] RABBIT_HIDE
[x] CHORUS_FRUIT
[x] BEETROOT_SEEDS
[ ] SHULKER_SHELL
[ ] HONEYCOMB
[ ] FROGSPAWN
// FOOD
[x] APPLE
[x] MUSHROOM_STEW
[x] BREAD
[x] RAW_PORKCHOP
[x] COOKED_PORKCHOP
[ ] GOLDEN_APPLE
[x] RAW_COD
[x] RAW_SALMON
[x] TROPICAL_FISH
[x] PUFFERFISH
[x] COOKED_COD
[x] COOKED_SALMON
[x] CAKE
[x] COOKIE
[x] MELON_SLICE
[x] DRIED_KELP
[x] RAW_BEEF
[x] COOKED_BEEF
[x] RAW_CHICKEN
[x] COOKED_CHICKEN
[x] ROTTEN_FLESH
[x] SPIDER_EYE
[x] CARROT
[x] POTATO
[x] BAKED_POTATO
[x] POISONOUS_POTATO
[x] PUMPKIN_PIE
[x] RAW_RABBIT
[x] COOKED_RABBIT
[x] RABBIT_STEW
[x] MUTTON
[x] COOKED_MUTTON
[x] BEETROOT
[x] BEETROOT_SOUP
[x] SWEET_BERRIES
[x] GLOW_BERRIES
[ ] HONEY_BOTTLE
// COMBAT
[x] ARROW
[ ] SPECTRAL_ARROW
// BREWING
[ ] GHAST_TEAR
[ ] WATER_BOTTLE
[x] GLASS_BOTTLE
[x] FERMENTED_SPIDER_EYE
[x] BLAZE_POWDER
[x] MAGMA_CREAM

Pickles and sunflowers ... Perhaps beans [Raw iron/copper/gold] if you're feeling spicy.

All the wools?

All the logs?
Log planks?
Amethyst block?
Honey block?

Quartz blocks!!!!

following will be added:

[ ] Logs and variants
[ ] Honey
[ ] Amethyst
[ ] Wool (carped was planned anyways)
[ ] (raw) Ore blocks and ingots (same as above)
[ ] Flowers

Should the crate items be a separate mod?
/polls "Yes" "No"

unfortunately issues dont allow polls, id be thankful if you check this out and vote on it!
https://github.com/sa-shiro/Minecraft-Compressed-Blocks/discussions/26

Will this update be released for 1.18 Fabric?

Will this update be released for 1.18 Fabric?

1.19 forge will have priority for now and will take some time, mainly because of the textures
after that a backport to 1.18, 1.17 and 1.16 will be done (thats easy, some items just have to be removed)
after that ill look how much changed on the fabric side, might be easy to port as well

Podzol
Glowstone (Block)
Grass Block
Glass Block
Obsidian Block
Snow Block

Podzol
Glowstone (Block)
Grass Block
Glass Block
Obsidian Block
Snow Block

I didn't get grass block to work because of the texture and texture generation...
Obsidian and glass should be a compressed block already, if I don't remember it wrong
Or do you want a crated version specifically?

Or do you want a crated version specifically?

I've checked, Obsidian Block and Glass Block are not compressed; the only glass item compressed (into a crate) is Glass Bottle.
Can we also add Smooth Stone as a compressed block?

Hmmm... obsidian should have been compressed as I gave them different strength and resistances...
Weird, I'll look into it!
Unfortunately I have some deadlines this week so I might not be able to work on it till Friday 🙁

Melon (blocks); Pumpkin has compression, but Melon does not.

Hmmm... obsidian should have been compressed as I gave them different strength and resistances...
Weird, I'll look into it!

@sa-shiro  Is there an update on the progress?

@HalcyonSeas73

Is there an update on the progress?

sorry fpr the late update...
I am currently trying to re-implement configurable compression (currently done with json as parts that code exists already in some way)
but i have to fix several issues with it, like properly generating resources on startup etc. also because its not registered as a real config, i might have to switch to toml later on

Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?

Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?

It is, I am currently working on updating and polishing up my mods which should be done by now.
The next plan is to continue the work on this mod, but it might take a while as I will recreate the crate textures and downscale them, including the atlas files used for this which are quite big

Now that the 1.19.4 update has been released, is there still progress being made on the additions to Compressed Blocks?

quick update on the progress:
it might MAYBE take a bit longer than expected, as i have decided to change the dynamic way of adding crates to registering every crate item one by one (this also improves readability of the code and removes some unnecessary doubled code)
However i try to complete the next update as fast as possible!

a addition to this i forgot:
any items on this list / not on this list you want to see as a compressed / crate variant?

I can think of a few things; essentially just collating the list already in the thread here.
Crates:

charcoal
gunpowder
pickles
all the flowers
perhaps ingots/nuggets?
carpets

Blocks:

Podzol
Glowstone (Block)
Grass Block
Glass Block
Obsidian Block
Snow Block
All the logs?
Log planks?
Amethyst block?
Honey block?
Raw Ore blocks
Melon
Quartz
Wools

Mind you, that's before I add the list at the beginning of the thread you had wondered about.

@HalcyonSeas73
at first i wanna thank you for helping me with your feedback and suggestions!
i have a question for you, what do you think about this change? (ignore the texture for now)
in the upcoming update you will need to craft a crate in order to crate items, this also eliminates potential recipe conflicts to say :D

@sa-shiro I personally don't like that idea,tho the question wasn't directed at me. I use mods that automatically compress items if they can be compressed. (sophisticated backpacks&storage) Having to craft a crate would break that convenience. I have polymorph for avoiding recipe conflicts.

ah okay, i will see what i can do then about recipe conflicts (like crated wheat)

I don't know about everyone else, but things like wheat to hay bales that can already be easily combined and separated, I don't need in this mod. I just need this for things that can't be combined/compressed already, like hay bales.

I don't know about everyone else, but things like wheat to hay bales that can already be easily combined and separated, I don't need in this mod. I just need this for things that can't be combined/compressed already, like hay bales.

yeah, i either just remove those or add an optional config setting to use an empty crate item with recipes to enable those conflicting ones like wheat

Yeah, agreed with PurpleHel, crating like that is not really something I'd like in the mod. I use bdew's Compacter for automated compression, as well as Storage Drawers' Compacting Drawers for long-term storage. I think having conflicting recipes is just going to be part of the mod; you never know what other mod is going to add conflicts.
As for hay bales, the bales themselves could be crated (or blocks), as there's already a 3x3 recipe for wheat.

@HalcyonSeas73 and @PurpleHel
all items have been added by now, just the blocks are missing.
However id like to ask for your opinion about the current texture design
Should the textures remain as they are now or change them?
im not that good of an artist, but im working on a new texture atm, here is a preview of the new texture:
(left is ofc the old texture, but with no item in it)

it is also planned to add numbers on top of the crate to distinguish between the level of crates

The new texture idea doesn't really look like a crate to me, but it's definitely easier to see the contents. I often have trouble IDing the contents of crates when they're in inventory with the current texture, and have to hover over and read the name.

i will keep the current texture design then, however i will fix the texture to make the content more clear and identifiable, thanks for your response!

I can see the new texture being cratelike, like a crate of oranges. it doesnt match the block vibe of minecraft all that well though; despite that, i still like it. If not the new design, maybe the old one could be 'simplified', colour-wise, to make the contents easier to identify? The numbers are also a good idea.

actually the current texture had numbers on its side, however i really dont know what happened that i didnt add it to the final product lol 🤔

Might be a big ask, but adding forge tags to the crates/blocks? Like cb:double_compressed, cb:triple_compressed etc.

Might be a big ask, but adding forge tags to the crates/blocks? Like cb:double_compressed, cb:triple_compressed etc.
Tags make it easier for some mods' filters.

thats not as of a big task as you might think, i already use tags or at least minecraft almost forces you to use tags MINEABLE_WITH_PICKAXE etc. so yeah, i will add that

update: everything is finished by now, howeer because of the amount of new items, the textures still take some time..
I hope i can finish it till the end of this week!

Terrible update...
I'm sorry to share this with you, but unfortunately the update will be delayed even longer....
My MoBo just died today and I have to wait for a replacement
I'm trying to work on my laptop to get the update done however, it's not the fastest :( actually its a terrible old office laptop
I am really sorry for this and I hope you all can understand my situation.

However, if you want a Alpha build of the current started, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture

However, if you want a Alpha build of the current state, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture

Sure! And no worries about your mobo dying; it happens. An old office laptop is better than nothing!
Perhaps related, but the current 1.19.4 release still has a 'conflicting' recipe: the bonemeal->crate of bonemeal recipe is the same recipe in vanilla as bonemeal->bone block. Unsure if you continue to plan on removing conflicting recipes in the meanwhile.

However, if you want a Alpha build of the current state, I can setup a build, but it won't have any textures for the crates, except the empty placeholder crate texture

Sure! And no worries about your mobo dying; it happens. An old office laptop is better than nothing!
Perhaps related, but the current 1.19.4 release still has a 'conflicting' recipe: the bonemeal->crate of bonemeal recipe is the same recipe in vanilla as bonemeal->bone block. Unsure if you continue to plan on removing conflicting recipes in the meanwhile.

Thank you!
Oh, I didn't even know I added Bone meal to the latest available version 😅 I might have added it by accident

@HalcyonSeas73 here is the current dev version, please also let me know if the tags work (#single ... #c0... and maybe even #compression)
be reminded that because of creative inventory changes in 1.19.3 that this version can not be made compatible with 1.19 - 1.19.2 and works only on 1.19.3 and 1.19.4
a version for other minecraft version will be released shortly after the initial release for 1.19.3/4
compressedblocks_1.19.4-4965c3c-1.2.2-SNAPSHOT.zip
(you have to open and extract the archive, github doesnt allow uploading .jar files in comments)

Some feedback:
-Instead of removing crated bonemeal/bone blocks entirely, I would crate just the bone blocks, as that's the end product of combining bone meal anyway, and it can be further reduced into bonemeal individually (reversible recipe); the same might go for wheat via hay bales (that is, having compressed hay bales), since youd just be leftover with some scraps of wheat.

The text in JEI for carpets appears to say (amount) x Redstone (Colour) Carpet; in general, the JEI tooltip is different for the 'newly added' things vs the original/older things; the old tooltips list the amount in the format of X Blocks, whereas new items list it as Xx Item (with the exception to carpet, mentioned earlier)

The tags don't appear to be 'populated' with their relevant blocks?

None of the items under the 'Blocks' section seem to have been added yet, in addition to any (crated or otherwise) ingots or nuggets; it may be worth reconsidering adding nuggets/ingots of the first place, since their Block of X suits the purpose fairly well, relating to the first point of vanilla-crafting the final product.

just as a reminder, its a early snapshot version, i dont have acces to the most recent project files until Wed when the new mobo arrives ^^

everything almost finished
to note the problem with the tags:  https://github.com/mezz/JustEnoughItems/issues/2814  thats why (block) tags dont work, its not supported yet
however my workaround for this is that i just add them as item tags instead

I hadn't been testing tags using JEI, I had been testing block tags via the Filter Card in RFToolsStorage. Item tags might work...?
I can test and see, once a new version with the item tags is released.

addressed in https://github.com/sa-shiro/Minecraft-Compressed-Blocks/commit/d9d16cd25e7f8e4a6ae08809f7526c9bbda484bb


Need to highlight Binding and Signature Hash Algorithm Settings

Since all other settings are highlighted with a red border, it would be good to put a red border around the "Binding" and "Signature Hash Algorithm" settings so admins don't miss these 2 very critical items.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 65a972cb-fe26-60cb-b12d-1af9ed8e87eb
Version Independent ID: ff97a29f-0767-1062-ad5d-b237ecd4b668
Content: Tutorial: Azure Active Directory single sign-on (SSO) integration with Zoom - Microsoft Entra
Content Source: articles/active-directory/saas-apps/zoom-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@dcpoirier
Thanks for your feedback! We will investigate and update as appropriate.

@dcpoirier, yes, I'll update the screenshot as per it.
#please-close

#please-close


Grid.prototype.refreshCanvas refresh issue (ColumnFilters not showing up - height calculation issue)

After explicitly turning 'enableFiltering' on and not seeing any result in my grid, I began stepping through the code to see what was occurring.
Turns out (may be related to the time it takes to fetch my data for binding to gridOptions.data?  I am also manually building out the column definitions) that the header heights were always calculated without the additional height to compensate for the filter.
Grid.prototype.refreshCanvas = function(buildStyles) {
 if (containerHeadersToRecalc.length > 0) {
   // Putting in a timeout as it's not calculating after the grid element is rendered and filled out
   $timeout(function() {
   ........
   });
  }
 };

This timeout was the culprit.  By supplying a delay of 200ms, everything renders as expected.  Is this a code smell of something I am doing that is not best practice?  Or is there a way to correct this?  I haven't analyzed this functionality yet, but am just looking for some high level explanation.

We often use a timeout 0ms to push things to the end of the digest cycle, and whilst that sort of has a smell about it, it seems accepted behaviour in the angular world.  We shouldn't really ever be using a timeout with a value, because that means we're not going to the end of the digest cycle, we're waiting for something to happen and that something is potentially going to take different lengths of time on different browsers.
What version are you on?  The header height issue with filters I think was addressed in rc20, or maybe in unstable.  And if you're turning on the filters after the grid renders, then you also need to call notifyDataChange I think in order to trigger the height change - the tutorial provides an example of that.

In the filter tutorial this works: http://ui-grid.info/docs/#/tutorial/103_filtering
I did previously had a problem where it only worked if the filters were initially enabled and then disabled, but not if they were disabled and then later enabled.  Creating a plunker for that: http://plnkr.co/edit/0osD3ckxLXmA64dayHQR?p=preview it seems to work fine now.
Do you have a plunker that recreates the problem?

OK, #3138 is the same issue and has a plunker, the difference there is that there's a pinned column (selection row header).  Is that also the case for you?

This seems to replicate my issue in that the column definitions are loaded later, after grid render (except I have no pinned columns) - I'm currently using unstable as well.  Going to experiment with firing notifyDataChange for columns today and see if that forces a height recalc.  I'll also give your workaround in #3138 a try as my use case does not need to toggle (dummy columns).

You should check - ui-grid-selection - the header size is calculated  based on the first column. The selection button is the first one, as it does not have a filter it has a maximum size that does not include the filters, thus the explicitHeaderCanvasHeight is calculated to be the "Selection " header height.
For example I needed filters and they did not show in page(rc20).
I ended up with
.ui-grid-selection-row-header-buttons {
height : someDimension;
}
so I can force the display of filters.
All the planker examples work if you remove selection. Without dummy columns.

@marinovicir This was fixed with 7c5cdca1f471a0a3c1ef340. Can you try it with unstable?

@c0bra Just tried with unstable and seeing the same issue in my case.  Here is a plunk of it working with the columnDefs loaded up front: http://plnkr.co/edit/DHTkZEKbzxXM2kBdoOuU?p=preview (this scenario has always worked for me)
However, when loaded after-the-fact, the height calculations are not reapplied:
http://plnkr.co/edit/AUlihNqWgvwU1WZ89nWG?p=preview
Using dummy columns to set the height (as opposed to just an []) is working for me though.

@c0bra Still not working even worse, the height is now 10px? http://plnkr.co/edit/w6ineaMrE0V9QC23tBga?p=preview
I don't think it's easy to fix this. Any way it is done, as long as the Selection Row Header is rendered first it will take that height. Because it will force the rest of the controls to render in that height.
I saw that the header is placed in a "left" render container, maybe those can be pushed to render after the body container. (at least the headers) I assume there is a right one also. It makes sense to render the body first as that is where the "action" will take place.
I did not look too much in the code, If I come up with a solution I will let you know.
Actually on second thought, why not just gridUtils.fakeElement for the header items. After that a max would work.

Yes, sorry. This is my fault. The fix has not been pushed through the build process yet due to tests failing in IE. I am working on it.

@marinovicir Can you check your plunker again? I had to include angular-touch for some reason but that could either be my setup or a separate issue.

@c0bra Hi, It works with a dummy column,

@c0bra
I think I found an easy fix for this, I noticed that the Selection header was present even if there were no custom columns, and it does not make sense to have only that header if I don't have any other columns, so in buildColumns I added a check for options.columnDefs, if there are columns from the user, add the extra headers, if not, don't display them.
  Grid.prototype.buildColumns = function buildColumns(opts) {
......

    // add headers only if we have columns added by user
    if (self.options.columnDefs.length > 0){
        //add row header columns to the grid columns array _after_ columns without columnDefs have been removed
        self.rowHeaderColumns.forEach(function (rowHeaderColumn) {
          self.columns.unshift(rowHeaderColumn);
        });
    }

I can confirm that using the fix proposed by @marinovicir remedies my situation as well.

I'm not convinced this is a great long-term solution, I'd see it as a workaround.  Our header calculations need to be able to be called and correctly calculate header height irrespective of starting condition.  What this is doing is manipulating the starting condition to be one that works, but presumably we'll still have other cases where it doesn't work and the header height will still need to be fixed.

I agree, It is not a long term solution. It just hides a problem in the calculations.

PS. Can`t edit in mobile. I still think the grid should not add headers if none are provided by the user. If the user does not know how the data will look. Why should the grid do anything.


Quick-and-dirty Python3 and Chainer 4 compatibility

I have made some very minor changes to the codebase that make it compatible with Python 3 and a newer version of Chainer. We did this because of some truly apocalyptic dependency issues that we were running into when trying to train our own models. Specifically, it appears as though newer Nvidia GPUs have some API-level compatibility issues with the older version of Cuda that is needed for the older version of Cupy that is needed for Chainer 1.7.
Note that I didn't update the code to use a more modern style of Chainer programming, so it is quite likely that there are things that could be made more efficient or idiomatic. I just got it working. :-)

Thank you for the contribution!


Bump current iOS version

This PR bumps the current iOS version from 15.2 to 15.2.1.

Apple Release: https://developer.apple.com/news/releases/?id=01122022f

Good morning @Ein-Tim Thanks!


Parallelize Run Model 3x

execute_model now runs in parallel in 3x.
Original benchmark was 50 min for execute_model
Now execute_model runs in 20 min.
20x, 10x and 5x were also tried, however, the reliability of the runs was unsuccessful.  Overall, CPU utilization improved, however, there is still a lot on table.  Perfectly efficient CPU would result <10 min per run.

Sorry to be a grump, but can we chat before moving forward with this?  It adds extra complexity (harder to understand and harder to debug issues) and fragility (states/territories are hardcoded in an additional place).
If the speed-up was incredible, then it would likely be worth it.  But there's not that much meaningful difference between 20min and 50min.  Both are basically "kick it off and come back after lunch", especially when you add in the time for the rest of the process (API, deploy to S3).
In general, I'm pretty loathe to be doing parallelization at multiple layers concurrently, especially when we're still not utilizing the machine optimally.  It feels like maybe instead we need to simplify things until the parallelization becomes straightforward.


Query task services

Addresses #84
Quite a lot going on here, a few notes:
Build-time configuration with .env file
I have added .env configuration file for tracking build-time environment config such as API host. The .env format is a convention in the web community stemming from The Twelve Factor App.
Unfortunately this module is lacking a bit in functionality:

updating config requires a change in source code
default config
multiple environments
local overrides

But the alternative (https://github.com/luggit/react-native-config) does not work with Expo/CRNA.
There is an example .env file (.env.example) that needs to be copied to .env before you build.
Service entity & data model
As our front-end data model doesn't current include a Service entity, I have stubbed one in based on the equivalent backend entity in the 211 data. However due to issues with the API (described below) I do not fetch associated organization and location info.
Service search query is arbitrary and english-only
As there is not yet any definition for how a task's related services should be searched, we currently just construct the query by taking the first 3 words from the task's title. This also means that the query is locale-specific and as we only have English content in the backend, we only get results when viewing in english.
Backend API and data model
I have some inline comments that mention some potential shortcomings with the backend API and/or data model as it currently exists.

This shouldn't be merged until #128 is merged and the inevitable conflicts in src/components/task/task_detail.tsx are resolved.

I'll want to see this merged before #128, @bensinjin lost the rebase lottery this time


More logging when authorization is not granted

I decided to look for low-hanging fruit and ended up taking a look at https://github.com/solid/node-solid-server/issues/468 I found that the logging part of that issue is best resolved in this package, but the HTTP error part is harder because NSS' ACLChecker doesn't know why authorization wasn't granted, and so didn't fit my definition of low-hanging fruit. Also, I haven't worked with promises before, so I was not inclined to make changes I didn't grok.
I put in quite a lot of logging when I worked with Group ACLs, and it is now pretty chatty, therefore, I'm not sure this patch is such a good idea. We should probably have a better logging framework with several log levels to choose from. I seems to work, so I put it up there for your review.

Here's an example of logging that results from a call to a resource:
  solid:index Looking for index in /restricted-dir/ +10s
  solid:ACL Using ACL https://robin.kjernsmo.net:8444/restricted-dir/.acl for ./ +17ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Read https://robin.kjernsmo.net:8444/restricted-dir/? +1ms
  solid:ACL Read access denied to (none) +5ms
  solid:server Error page because of: { [HTTPError: Access to https://robin.kjernsmo.net:8444/restricted-dir/ requires authorization]
  name: 'HTTPError',
  message: 'Access to https://robin.kjernsmo.net:8444/restricted-dir/ requires authorization',
  status: 401 } +0ms
  solid:server Access to https://robin.kjernsmo.net:8444/restricted-dir/ requires authorization error: undefined desc: undefined +1ms
  solid:server Redirecting to Select Provider: https://robin.kjernsmo.net:8444/api/auth/select-provider?returnToUrl=https%3A%2F%2Frobin.kjernsmo.net%3A8444%2Frestricted-dir%2F +1ms
  solid:ACL Using ACL https://robin.kjernsmo.net:8444/favicon.ico.acl for ./favicon.ico +1s
  solid:permissions Checking access for agent undefined +1s
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent null +1ms
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Write https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Append https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Control https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Write https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Append https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Control https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:ACL Permissions on https://robin.kjernsmo.net:8444/favicon.ico for (none): read +3ms
  solid:ACL Permissions on https://robin.kjernsmo.net:8444/favicon.ico for public: read +1ms
  solid:get /favicon.ico on robin.kjernsmo.net +0ms
  solid:handlers GET -- Reading /home/kjetil/Projects/Solid/my-test-data/favicon.ico +0ms
  solid:ACL Using ACL https://robin.kjernsmo.net:8444/favicon.ico.acl for ./favicon.ico +2s
  solid:permissions Checking access for agent undefined +2s
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent null +1ms
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Write https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Append https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent null +0ms
  solid:permissions Can agent null Control https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Public access allowed for https://robin.kjernsmo.net:8444/favicon.ico +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Write https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Append https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:permissions Checking access for agent undefined +0ms
  solid:permissions Can agent undefined Control https://robin.kjernsmo.net:8444/favicon.ico? +0ms
  solid:ACL Permissions on https://robin.kjernsmo.net:8444/favicon.ico for (none): read +3ms
  solid:ACL Permissions on https://robin.kjernsmo.net:8444/favicon.ico for public: read +0ms
  solid:get /favicon.ico on robin.kjernsmo.net +0ms
  solid:handlers GET -- Reading /home/kjetil/Projects/Solid/my-test-data/favicon.ico +1ms


Drop session endpoints

Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Current dependencies on/for this PR:

main

PR #243   👈

PR #244

This comment was auto-generated by Graphite.


constat identifier is not highlighted

when we declare
const aConstant = 1
aConstant is highlighten, later on when we use it, it is still default color

Wrong repo, this is the parser (unless you're using the CLI).

Yeah, but when I inspect, constant is detected as usual variable


MPI plane depth values vary across scenes

Hi,
Thank you for the great work! You used depth bounds obtained from COLMAP to determine the near and far depth values for MPI planes (code here), which will vary for each scene.
Could you explain a bit more why it's implemented this way? If I'm understanding correctly, the mask network is agnostic of the near and far value, and thus might be confused if the MPI planes do not correspond to fixed depth values?

Yes, just like what @adahbingee said, ideally the near/far plane should be dynamically placed for maximal coverage.
For example, let's assume we fix the near/far plane values to be 1~100 meters.
Then, if we are given a scene with depths ranging from 1 to 3 meters, we will waste some depth samplings on the planes that are beyond 3m.
This would cause the scene to have depth discretization artifacts similar to the ones shown in Fig. 1. in Srinivasan et al. CVPR 2019 (https://arxiv.org/pdf/1905.00413.pdf), because there are not enough samples in the correct depth range.
As a result, it is always better to dynamically assign the depth ranges such that it can enclose the scene.
You can refer to this line in LLFF. They used COLMAP feature points to determine the approximated scene depths.
Additional note: this technical nuance is also important for newer methods like NeRF as NeRF and MPI both share the same idea of volumetric rendering.

For this work as well as LLFF, the MPI network uses binocular inputs and therefore is expected to output the absolute depth values. I understand that having dynamically adapted depth range will reduce the discretization artifacts, but do you expect the MPI model to generalize well if the model is not aware of the new near and far depth values during test time? With the dynamic and therefore unknown near and far depth values, the MPI model won't be able to associate the depth plane with absolute depth values anymore?
In Tucker 2020 (https://single-view-mpi.github.io/single_view_mpi.pdf), since they use monocular MPI, the depth prediction is scale invariant. They used sparse point cloud from COLMAP to determine depth scale (Section 3.2 equation (2)), do you think that will have similar effect as dynamically deciding the depth range of MPI planes? If the sparse point cloud data is available, I can imagine computing the depth scale as done in Tucker 2020 and using that to decide the depth plane values, which will be potentially more robust to point cloud outliers.

Sorry for the late reply.

The network does not take the depth values as input. Instead, it takes the plane sweep volume. Essentially, it is looking at the PSVs and checking if they converge. If they do, then the network would place objects on that plane. As such, the MPI model does not explicitly know the absolute depth values.
You can directly use the point cloud data to compute the depth bounds for multi-view cases. I think why they computed that is because they want to have the depth regularized to generate accurate depth maps. That is not what we are doing here. Our focus is to maximize the coverage of the planes and setting the bound with sparse point cloud should be sufficient. (Note that LLFF is taking the nearest 0.1 and the 99.9th percentile so it can reject some outliers.)


Generate valid serial strings for volumes

The valid chars are defined in libvirt-1.2.18/src/qemu/qemu_command.c.
Tested on SLE12-SP1

not good to include a merge commit in a PR. please do something like git rebase origin/master

ok


Use go templ instead of go template

Go Templ is an alternate templating engine that can compile templates down to go code. I find the added compiler support to be really helpful for medium to large projects.
Is it possible to integrate it?

Hi - great question. I am familiar with the project but I haven't yet given it a full try, especially within the scope of this. The last time I tried it out, which was a while ago, the Goland integration and tooling was lacking too much for me to feel comfortable considering it as a default for this project. I do need to try that again. Which IDE are you using and how has your experience been?
When I first came across templ, I was definitely impressed and completely onboard with the concept. Adding type-safety to that layer is a huge gain; not to mention other short-comings with standard templates. However, I was a bit hesitant to include it as a default here because it's quite a heavy dependency, requires you to know the language, patterns, add an IDE plugin, build step(s), etc. I'm not sure which is easier: moving to that or moving away from it.
There's nothing stopping you from using templ within pagoda. I can't say how much work that would be, but it will get pretty tricky, given that there's a lot of functionality baked in to the template renderer, everything else tied to the templates, and how they are built, parsed, and rendered, etc. If you do go down this path, please share your experience along the way. I will also be trying this out somewhat soon, if time permits, so I can evaluate it again and reconsider it being part of this.

Hi @mikestefanello,
I am also just getting used to Templ. I used it in a couple small projects before and am planning to use it in a new project which is when I stumbled upon Pagoda. Pagoda has most of everything I need except for templ. Thanks for the time and effort you have put into Pagoda.
I am on VS Code  with the templ plugin installed. It has autocomplete and validations. Yes, it leaves a lot to be desired, but its serving my needs so far. I am a huge fan of devcontainers so having the dependencies and IDE plugins installed is sorted. I agree with the rest of your points. There is a significant barrier to entry for go-templ. That said IMHO, learning go-templates or go-templ seems to have the same effort, especially considering that go-templ lets me use go in the template itself and most of the "magic" in the template renderer in pagoda might just go away.
I did  start integrating templ into pagoda. I haven't got it working yet. So far, the following is my progress:

Made template renderer an interface
Created templ renderer
Moved page cache out of template renderer so that both the template renderer and templ renderer can use it

As of now I am converting all gohtml files to templ files trying to keep the current structure as much as possible. Seems like I might have to change all the handlers as well and make some changes to the page module.
I am trying to keep the current template renderer and the templ renderer together. But as I am progressing I feel that just replacing the current template renderer with the templ renderer might be easier. I would love to know your thoughts about this.
I was planning to give a PR once I get this working, but if you are interested in the changes, I can keep in on a branch in my fork. Let me know.

You're very welcome - I'm glad to hear that you're finding it useful.
I've been a bit busy lately, and I still need to wrap up the final cleanup of backlite so that's in a sufficient state (especially now that pagoda uses it). After that, I do intend to devote a good amount of time to re-investigating templ and seeing if it makes sense to incorporate it. I will certainly keep an eye on your branch but please also update this thread as you make progress and let me know what's working and what's not.
Thanks

I am working on the go-templ branch in my fork.
As for the progress:

I removed the go html renderer and replaced it with the templ renderer thereby making things a lot let complicated. I also removed the template renderer interface as it was no longer needed.
Page cache is still outside the template renderer
Since layout, pages and data in the page behave like function and function parameters in templ, the fields related to  go html layout and Data in the page struct was removed in favor of a new templComponent field. I would like to remove this field and Title to somewhere else but haven't figured out where yet
Converted all gohtml files to templ files
The forms and data structs which were defined in the handlers packge was causing a circular dependency error when used from go-templ files. So moved them to a helpers package for the time being. I am looking for a better solution, suggestions are welcome
Made changes to the Makefile to generate templ files on run

I am yet to re-implement the functions in funcMap so things like urls and images are broken or rather nothing other than rendering works as of now.
If you get time, do take a look at my branch and let me know if you have any suggestions. This rabbit hole is turning out to be a lot deeper than I thought.

Updates:

re-implemented the funcMap module, renamed it to funcs as there is no map anymore
removed sprig as a direct dependency
Updated link/url/file functions in templates

Everything seem to work fine now. Would be great if you can give it a try, in case I missed something

Looks like great progress so far. I've only done a very quick review, but I will dig in more once I get some time to.
Circular dependencies was the first potential problem I thought of when I initially considered templ. I haven't put any though towards a solution yet, but as you mentioned, we'd definitely need a good pattern for it (something other than helpers, etc).
Some quick thoughts/observations:

A noticed a few bugs clicking around the UI (paging is broken, the link on the error page is broken, the About link is broken).
It would be nice to use consts for the route names in the components (they currently exist in handlers but can be moved).
Maybe the Page concept doesn't quite fit any more, and something else should be considered? Not sure, just noting that we're not locked in to using it.
Can the Funcs just be moved to templates so they can be called directly?
Thinking (way) further ahead, I wonder if the form templates can be improved (ie, reusable element components, easier way to add the inline validation stuff, etc)
Also thinking ahead, it feels like there should be a way to bake in the HTMX integration in a more seamless manner.

Big problem, for me, is it seems like the Goland plugin does not work at all.

I've never tried gomponents and had a very negative reaction when I initially saw it, but I was curious if you've tried it out, since it seems to try to accomplish similar things as templ.

Fixed the following:

paging
the link on the error page
About link

Circular dependencies was the first potential problem I thought of when I initially considered templ. I haven't put any though towards a solution yet, but as you mentioned, we'd definitely need a good pattern for it (something other than helpers, etc).

I totally agree. helpers is too generic and has a tendency for eventually becoming  a "dump all" package. A good pattern will need some thought and I would rather do it properly, if we are doing it at all. It'll be a major structure change anyways.

It would be nice to use consts for the route names in the components (they currently exist in handlers but can be moved).
Yes, I was thinking of making the routeNames an explicit type.  In fact I had given it a try but had the following problems:

Calling it from handlers in the templ files causes a circular dependency so it has to be moved out of handlers, if so where to move it?
If we move to a different package, add a route will require changes in two packages handlers and the new package where we are moving the route names to. IMHO changing multiple is a hassle.

Maybe the Page concept doesn't quite fit any more, and something else should be considered? Not sure, just noting that we're not locked in to using it.

Maybe moving the layout, component, title and pagination to a different rendering struct might be a good idea since rest of the fields are project level or request level  and can be populated from something like a middleware and added to the context, which will avoid passing around page everywhere. What do you think?

Can the Funcs just be moved to templates so they can be called directly?

Yes it can be, but since the module requires web *echo.Echo which is not available in templates, it will have to be initialized in template_renderer anyways, so I didn't think it made much difference.  But If think putting it in templates is better, it can be done.

Thinking (way) further ahead, I wonder if the form templates can be improved (ie, reusable element components, easier way to add the inline validation stuff, etc)
Also thinking ahead, it feels like there should be a way to bake in the HTMX integration in a more seamless manner.

Yes agreed

I've never tried gomponents and had a very negative reaction when I initially saw it, but I was curious if you've tried it out, since it seems to try to accomplish similar things as templ.

I had the same negative reaction as you did. IMHO I am not sold on it

html support is far more mature in IDEs etc
It looks tedious (using Raw) if you have a lot of custom html attributes like if you use htmx, alpine or anything these days. Kind of beats the purpose IMHO
Not sure how well and how many custom attributes can be supported if all they ever will be
Personally,  even though I try to avoid JS as much as possible unless the business needs an SPA or something, my background is HTML/JS and am more comfortable with them. This could change in the future though.

I haven't paid for an IDE yet, maybe I should :)

Without IDE support, I really have a hard time taking templ seriously for this project. That's just such a blocker in my mind. Not to mention, all of the other various issues we've discussed. I do like the concept and objective of templ, and I certainly understand that standard Go templates leave a ton to be desired, but perhaps it's just not ready yet.
Are there any other libraries or approaches to consider and try out?

Not at the moment.
I am planning to use pagoda with templ in my future projects. If I make any further changes, I'll push it to the branch and update here.

For anyone interested, I have a heavily modified fork that uses Templ instead of gotemplates. I personally haven't looked back. I trust my code so much more than back when I had to pass maps to components. I love the static typing, and it's got some quite fantastic template composition syntax. It's OSS: https://github.com/leomorpho/GoShip
I'd be happy to merge some things back into Pagoda, but it's just gotten quite off-road from the initial pagoda fork...

Looks great, thanks for sharing. I'll be sure to dig in and try it out once I have some time available. I'm sure I'll have some templ questions when I start exploring it more.

My  fork: PraveenGandhi/pagoda on top of @nithin-bose 's fork.
I am trying to replace Ent with SQLc. Hope it is a reference for anyone who wants.
Thank you @mikestefanello. As pagoda is well thought through and well organized, it is not much complicated to replace Ent with SQLc.
Disclimer:

I am not proficient in Go, hence there is room for improvement.
Not concentrated on Unit testing.

Thank you.

I've never tried gomponents and had a very negative reaction when I initially saw it, but I was curious if you've tried it out, since it seems to try to accomplish similar things as templ.

I understand your thoughts,
but I have seen similar thing in Python: FastHtml and python community loves it.
As far as I have understood it, it is general server rendered web framework. At the same time it has opiniated way with Pico CSS and HTMX
Other referrences:
FastHtml Foundation
FastHtml Tech Stack
FastHtml Components Example
https://github.com/guettli/frow--fragments-over-the-wire
HOTWIRE (HTML over the wire)

@PraveenGandhi You're very welcome. Thanks for the kind words. Out of curiosity, why did you prefer SQLc over Ent? Are you planning to use Gomponents? Have you worked with it enough to be able to share your experience/feedback, etc? I have never really given it a try but I intend to at some point just to see.

htmgo is another interesting (early) project that's similar to gomponents but looks like it has htmx baked in.

I do agree, just like I originally did. I was just trying to keep an open mind and compile a running list of all options/alternatives to consider. It's interesting to see how each project approached the problem and perhaps we can see what each of them do well. I did give gomponents a serious try recently and I just don't see how it's practical or appealing. Maybe for very simple use-cases it can be, but I'm not sure. I imagine I would feel very much the same if I tried htmgo.

why did you prefer SQLc over Ent?

I am new to GO ecosystem, I found SQLc simple to use, I have no opinoin about Ent, but in general I do not like full blown ORMs and prefer to use SQL and some kind of DSL like jOOQ, ExposedSQL


Option to toggle layout account binded

I would like to get an option to have specific tabs shown on the account where it was created on, playing iron and main, is confusing since tabs show on all account

Duplicate of #63.


Nested Folders

On my Computer, I organize my pictures in nested folders like "2021/10" "2021/09" and so on. (in fact I gave up organizing by event :-)  While converting this to my mobile album, I create a flat folder hierarchy like 2021_10, 2021_09. This list gets quite long after 30 years of collecting pictures. Is there a reason why Les Pas - like most of the other picture viewers on Android - does not allow nested folders?

Almost every request for nested folder support is about grouping photos by months, years etc. To me, this shouldn't be done by grouping but rather searching. There is already a search entry in Les Pas, although what you can do now is AI search for certain types of object, but it should be easy to add a search by date feature there too.

Right now I use f-stop as my regular gallery, the main reason is speed, it is really fast. LesPas is regarding speed in the same league. f-stop does also not support nested folders, so I had to flatten my folder hierarchy for the phone gallery...
Still I would also think nested folders would be nice. Searching for something instead of browsing for something is quite different from the intuitive view, I'd say...

Hi @scubajeff, I just discovered your app and it looks very promising.
But I have to agree with the above comments regarding the lack of nested folders.
For me, flat folders will not work because I have many pictures that I already organized like this:
Events

Birthdays

Wife
Kids
Vacation

Place a
Place b
People
Person a
Person b

Tags might address this, but I see from the FAQ it is not supported because you don't want to use tags from Nextcloud. I understand, it makes sense, but you don't have to: EXIF already has support for tags/keywords.
This is a show stopper for me. Actually, I might be able to get used to it, but I will never be able to convince my wife and parents to use it.
Please reconsider this feature because, as I said, the app is promising: I like the fact that I can have photos on my phone but at the same time they are 2-way synced with Nextcloud. I could not find this feature in any other mobile apps. The fact that I can even have photos remotely, but still see them in the app is a bonus.

@nicuh Yes, EXIF could be a good candidate for tagging photo, it's what it means for and many vendors do this. The obstacle Les Pas facing when adapting it is, original full resolution picture file is needed on the phone so that it's EXIF portion can be edited. This means for the simple job as adding a tag to a picture, several mega bytes of data have to travel back and forth between your phone and the Nextcloud server. Considering tagging serveral hundreds of them...
One way to handle this is a companion app running on server side to do the tagging job locally. Then the major problem left is the 2 phase commitment of the new file on both side. But sadly I don't have proper skill of PHP, so let's hope for some PHP guys can join this project.

It's easy to understand nested folder structure when you are working with the file system tree, but Les Pas is a pure mobile experience, a sub-album within an album is quite unnatural, also bring challenge to UI and UX design.

Ah, I just posted a similar issue , sorry didn't see this earlier. But that one is still relevant given the type of implementation requested.
While I understand that les pas is a pure mobile experience, the purpose of lespas for us is to backup photos AND then down the line be able to easily find them on the computer I sync my server with or on the nextcloud web app.
Hence, I strongly believe this option is much needed for just the "Backup" archive folder.
Also, in the official nextcloud app, using Year/Month subfolders is a configurable option. So, not everyone has to agree with it, but the option exists for those it would help!
Like some others above, it is not possible for me to use lespas without this.

Despite your strong opinion on the matter, @scubajeff , here's another example of nesting/tagging (better both) as the only means of managing a big collection accumulated through the years:
~350GB
~70k photos
Current structure:

People/

Ann/

Birthday-2009/

raw/

original-1234.nef
...

processed-selected-1234.jpeg
...

Hiking-2014/

raw/

original-2345.nef

processed-selected-2345.jpeg
...

PhotoSession-2016/
etc...

Kate/
Tom/
Mom/
Dad/
Kid/
...another 10 people

NewYears/

2007/
2009-at-school/
2014-trip-to-Sydney/
...

Landscape/

2017-09-12/

raw/
...

2017-10-23/
2018-03-15/
...

and so on, and on

More than 8000 nested folders in total :warning:
Now, I can't imagine myself scrolling through 8k flat albums, even though each of them does indeed represent an event. But I would very much like the ability to browse the collection with my phone, processing selected images on the go with Snapseed.
And considering that the storage backend you use (nextcloud) natively supports nested folders, the limitation of Les Pas in this respect seems a bit artificial :shrug:

I want to add another important use-case for subfolders: Sharing. I group my pictures by topics like several people have said, although just two levels (Category/Event, e.g. "Family/Reunion 2023").
With the current flat structure, I cannot easily share all pictures of a certain hobby on the nextcloud server with friends from that hobby. It's either giving them access to all pictures (a no-go), or creating 20 individual shares, and remembering to share each new subfolder, and keeping all of them in sync -- this is not practical in any way.

It's easy to understand nested folder structure when you are working with the file system tree, but Les Pas is a pure mobile experience, a sub-album within an album is quite unnatural, also brings challenge to the design of both UI and UX.

While I do not have 8000 folders, scrolling through 80 folders accumulated over 5 years  is already painful, this is not mobile friendly.
Lespas already has a hierarchical view when you enable the phone gallery. I think that would be a good starting point for a UI. Even just two levels would make a huge difference. Please reconsider your opinion.

As you might already point out, a new set of concept has to be introduced to support hierachy/nested folder, even if it's just two levels. This concept, let's just call it 'Group', it's on top of albums. So you have several groups and each group has several albums in it. It's pretty obviouse and understandable if you already organized your collection in such a way. But considering the other case of another type of new user, who has no idea of all these tricks. When he/she tries to create his/her first album by adding a picture to Les Pas, there would be a little frustration ahead of him/her, e.g., he/she need to create a group first, which I believe is a concept hard to swallow for this user.
Don't get me wrong, nested folder is a great way for photo collection. It's just too difficult to impletment because there are a lot of things to consider and balance, concept naming, UI simplicity, genuine UX flow, just to name a few.
For Gallery, Les Pas acts as a viewer only, that's not the same case and it's easy.

I'd also welcome a nested folder feature.
I can understand that fully support this feature on the mobile side is too difficult/time consuming.
Maybe a good starting point would be for Les Pas to support a nested architecture as a viewer only, in the same way it's already done for the photo gallery (like @jwalt mentioned). Allowing to sort photo view of an album by folder rather than ignoring completely the nested folder (That's the behaviour I've noticed on my side).
It would still require to create nested folder on the server/computer side but at least it wouldn't force to use a flat architecture like @allista , @nicuh , @Forza-tng and @steviehs mentioned.

As you might already point out, a new set of concept has to be introduced to support hierachy/nested folder, even if it's just two levels. This concept, let's just call it 'Group', it's on top of albums. So you have several groups and each group has several albums in it. It's pretty obviouse and understandable if you already organized your collection in such a way. But considering the other case of another type of new user, who has no idea of all these tricks. When he/she tries to create his/her first album by adding a picture to Les Pas, there would be a little frustration ahead of him/her, e.g., he/she need to create a group first, which I believe is a concept hard to swallow for this user.

Yeah, I am totally on board with new-user compatibility. I like the idea of calling this "Groups", and there can be a default/unnamed group that represents the toplevel folder. So for new users, there would only be this one unnamed group that is always there. No change in workflow to the current state. The menu could have a "Create Album Group" entry, and only then the UI gets slightly more complex.

Don't get me wrong, nested folder is a great way for photo collection. It's just too difficult to impletment because there are a lot of things to consider and balance, concept naming, UI simplicity, genuine UX flow, just to name a few.

Yes, there would be some UX to be defined, but I don't think this would be too disruptive. The top-level album-list is the most visible change, everything else could be hidden in a menu: create group (i.e. folder), remove group (only if group is empty), move album to different group. Those three operations should be a viable minimal version of that feature. Anything else (e.g. album lists for moving/copying images) can stay as it is now, just with albums named group-name/album-name. Even that minimal feature would make working with 80+ albums much, much easier.


Missing vendor name for UC-Pxx Teams Phones

The Currently certified Teams phones starts off with UC-Pxx devices.  These should be as below including the vendor.
Crestron UC-P10-T (with and without handset)
Crestron UC-P10-C-T (with and without handset)
Crestron UC-P8-C-T (with and without handset)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aaaef9e1-8f1c-ebf0-7856-4c007342a2c3
Version Independent ID: 3eaf671f-375e-8787-9c66-3947c3606559
Content: Devices for Teams - Microsoft Teams
Content Source: Teams/devices/teams-ip-phones.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Thanks for reporting @grahammw


Remove unnecessary env variables

resolves: https://github.com/istio/istio/issues/19177, this should be set from values pass through, otherwise everything would be overwrite by k8s env settings under component specs.

@richardwxn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
8fcebd2d001b6e632d519b20c6e91899f1979d06
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
8fcebd2d001b6e632d519b20c6e91899f1979d06
link
/test gencheck_operator

e2e_operator
8fcebd2d001b6e632d519b20c6e91899f1979d06
link
/test e2e_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e_operator
8fcebd2d001b6e632d519b20c6e91899f1979d06
link
/test e2e_operator

gencheck_operator
9dd34886ca1505fa7edd8b6a384f0ee2f79fed18
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

doesn't this change the defaults?

I guess not from the generated output, did we set these in two places before?

@richardwxn to get your pr moving

rebase on master
make gen
git commit .
git push .........

In response to a cherrypick label: #632 failed to apply on top of branch "release-1.4":
Applying: update goldens
Using index info to reconstruct a base tree...
M	cmd/mesh/testdata/manifest-generate/output/all_on.yaml
M	cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
M	cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
M	cmd/mesh/testdata/profile-dump/output/all_off.yaml
M	cmd/mesh/testdata/profile-dump/output/sds_policy_off.yaml
M	pkg/vfs/assets.gen.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/vfs/assets.gen.go
Auto-merging cmd/mesh/testdata/profile-dump/output/sds_policy_off.yaml
Auto-merging cmd/mesh/testdata/profile-dump/output/all_off.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/all_on.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/all_on.yaml
error: Failed to merge in the changes.
Patch failed at 0002 update goldens


TEMPLATE: QUARTERLY VERSION UPDATE

Placeholder issue - will make this into an issue template going forward
Each quarter at the start of the month, the following tasks should be done:

[ ] Download updated zip file and Guidance from Treasury UAT Portal (or get from partner) and add it to this google folder:
[ ] Update input template and add to this folder
[ ] Run script to update the output file for ARPA Reporter
[ ] Run script to update input file for
[ ] Identify if any other changes are needed to the tool (i.e. upload validation, field mappings, adjustments to audit report, etc)

See details here on technical documentation for running the updates

closing as this is now a template!


Fix path for rails and node environments

Check to see if the image-url function exists
If image-url is not defined (if we are not in a Rails environment), set
a path to /public/images.
This will fix the issue where elements is overriding $path for the govuk_elements_rails gem.
cc. @robinwhittleton @dsingleton.

Checked this with a custom govuk_elements_rails build and it works fine.


[Design] Harmonize checked checkbox behavior (sometimes the text becomes blue, sometimes not)

In Review Workflows :

In CTB :

Done @lucasboilly


Update iiot-architecture.md

@terrymandin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good.


⚠ 한경주요지수-코스피200 has degraded performance

In 5184319, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 5629 ms

Resolved: 한경주요지수-코스피200 performance has improved in 4905b49.


[MRG] Bug fix - resample would break crop

resampling a raw would convert raw._last_samps to a list, which would break raw.crop which expected an np.array
This bug didn't exist in the last release, so I don't feel like this needs an entry in latest.inc. but if you think I should I can add it.

Thanks @bloyl


move BUILD_ONLY dependencies into dependencies list

Lodash, combyne, and js-beautify are required for install when BUILD_ONLY is true. Without these present in the dependencies list, running BUILD_ONLY=true npm install from within my own app will create the following error:
[nodegit] Configuring libssh2.
ERROR - Could not generate native code
{ Error: Cannot find module 'lodash'
at Function.Module._resolveFilename (module.js:440:15)
at Function.Module._load (module.js:388:25)
at Module.require (module.js:468:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/tmp/app/node_modules/nodegit/generate/scripts/helpers.js:4:9)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3) code: 'MODULE_NOT_FOUND' }
[nodegit] Everything is ready to go, attempting compilation
events.js:160
throw er; // Unhandled 'error' event

As a workaround, I can copy these dependencies into my own package.json.

@carpeliam can you try NodeGit 0.14.0? We redid a lot of the install lifecycle stuff and this should help.

All's well in 0.14! Thanks @johnhaley81 and team, feel free to close.


New script: DealCluster

New DealCluster script will enable users to manage the deals in a cluster of bots; prevent multiple (configurable number) of deals for the same pair.

Thanks Peter!


max args to an opal call

opal_entry (and opal-spec.txt) claim 9 arguments may be passed in r3..r11, yet the OpenPower ABI mentions (<IP_ADDRESS> Register Roles) that r11 is not used for parameter passing, and again in 2.2.3 (Parameter Passing in Registers) that only 8 registers are available, with the rest spilling to stack.
A simple test confirms:
    2001021c:   09 00 20 39     li      r9,9
    20010220:   60 00 21 f9     std     r9,96(r1)
    20010224:   0a 00 20 39     li      r9,10
    20010228:   68 00 21 f9     std     r9,104(r1)
    2001022c:   0b 00 20 39     li      r9,11
    20010230:   70 00 21 f9     std     r9,112(r1)
    20010234:   0c 00 20 39     li      r9,12
    20010238:   78 00 21 f9     std     r9,120(r1)
    2001023c:   01 00 60 38     li      r3,1
    20010240:   02 00 80 38     li      r4,2
    20010244:   03 00 a0 38     li      r5,3
    20010248:   04 00 c0 38     li      r6,4
    2001024c:   05 00 e0 38     li      r7,5
    20010250:   06 00 00 39     li      r8,6
    20010254:   07 00 20 39     li      r9,7
    20010258:   08 00 40 39     li      r10,8
    2001025c:   9d fe ff 4b     bl      200100f8 <foo>

If OPAL really does support 9 arguments, the opal_entry logic should be reflected (fetching arg 9 from client stack, yuck)... To me it seems mostly a typo (i.e. OPAL really supports only 8 args, not counting the token in r0), but then r11 manipulation for OPAL_TRACE_ENTRY should be avoided.

On Tue, 2015-05-12 at 01:10 -0700, Andrei Warkentin wrote:

opal_entry (and opal-spec.txt) claim 9 arguments may be passed in
r3..r11, yet the OpenPower ABI mentions (<IP_ADDRESS> Register Roles) that
r11 is not used for parameter passing, and again in 2.2.3 (Parameter
Passing in Registers) that only 8 registers are available, with the
rest spilling to stack.

We should probably enforce it since we know the number of args in
the register macro/functions... we might even be able to do a build
fail.

A simple test confirms:
2001021c: 09 00 20 39 li r9,9
20010220: 60 00 21 f9 std r9,96(r1)
20010224: 0a 00 20 39 li r9,10
20010228: 68 00 21 f9 std r9,104(r1)
2001022c: 0b 00 20 39 li r9,11
20010230: 70 00 21 f9 std r9,112(r1)
20010234: 0c 00 20 39 li r9,12
20010238: 78 00 21 f9 std r9,120(r1)
2001023c: 01 00 60 38 li r3,1
20010240: 02 00 80 38 li r4,2
20010244: 03 00 a0 38 li r5,3
20010248: 04 00 c0 38 li r6,4
2001024c: 05 00 e0 38 li r7,5
20010250: 06 00 00 39 li r8,6
20010254: 07 00 20 39 li r9,7
20010258: 08 00 40 39 li r10,8
2001025c: 9d fe ff 4b bl 200100f8
If OPAL really does support 9 arguments, the opal_entry logic should
be reflected (fetching arg 9 from client stack, yuck)... To me it
seems mostly a typo (i.e. OPAL really supports only 8 args, not
counting the token in r0), but then r11 manipulation for
OPAL_TRACE_ENTRY should be avoided.
—
Reply to this email directly or view it on GitHub.

Cool, just sent a patch out to the list - It'd be great if you one/both of you could ack it. It just fixes docs and the OPAL_TRACE_ENTRY part.

This is resolved now.


feature: Support multiline in YAML camel uri autocompletion

This refactor is able to handle multi-line selection in YAML.
Screencast from 2023-11-27 15-47-17.webm
This is for preparation for https://github.com/camel-tooling/camel-language-server/pull/1001 which will require multiline. Still needs more features in-between before merging #1001 because we need to be able to give more context to camel uris. But now at least you can process whole YAML elements that are on different lines.

Something went wrong with the rebase from main, wait, it should be only four or five files.

This PR contains an "aesthetic" change in which the file ParserFileHelperUtil.java now takes into account that you are potentially going to return more than one line. Didn't want to completely remove the getLine functions, but deprecated them (to slowly remove them from everywhere) and created the new getLines (in plural).
Also, now we pass not only the start position but also the end position.

The file that has more changes is CamelYAMLParser.java which now has to deal with multiple lines parsing and overrides for example the getCamelComponentUri function, because we want to extract more than one line.
This function would probably benefit from receiving the end position too (see previous comment). But for now, we just need a position to retrieve the full YAML element with the URI.

The completion seems to work only when we are at last line of the file

Must be something else but I am investigating it.
Screencast from 2023-11-29 10-19-51.webm

status reported in specific JIRA https://issues.redhat.com/browse/FUSETOOLS2-2268


doxygen: generate sitemap

generate a sitemap when Doxygen is built.
This feature is new in Doxygen 1.9.7 so the doxygen version used by CI needs to be downloaded and installed instead of using the package manager.

Yay! Looks like a sitemap to me 🗺


feat: Added humoris theme

Humoris preview theme:
Preview Link

Looks great! Thanks for the contribution :tada:


Fix for Django 1.11.1

https://docs.djangoproject.com/en/1.11/releases/1.11/#django-template-backends-django-template-render-prohibits-non-dict-context

I don't think i'm going to merge this without proper tests that CI can run


Extend custom wire pin function for STM32

Hi Rob
I was using this project to evaluate the AS5600 with an STM32 Nucleo board. Somehow the standard wire pins did not function. What i ended up with, was setting the pins explicitly which was somehow needed for my setup.
The function is secured with a now extended #ifdef.
Happy to help further tests on the STM32 platform

Thanks for this PR.
I will look into it later today or tomorrow.

Will look at the breaking code later.
At least I know what should work for STM32

@BRTFTW
Created Pull Request  https://github.com/RobTillaart/AS5600/pull/46 for STM32 support (based on your code)

fixed the ESP32 / build-CI  fail
increased version number
minor edits

Can you give the develop branch a try if it works for the STM32?
(if time permits I'll check if there are minor things to add to this release)

Installed STM32 compilation and tested an example (adapted the begin() statement.
The defined(STM32) did not work, replaced with defined(ARDUINO_ARCH_STM32) which works for me
build is running
Can you give the develop branch a try if it works for the STM32?
(if time permits I'll check if there are minor things to add to this release)

Sure, I'll have a look at it on Wednesday.

Rob, it is Mitch again, (Laptophead)
Having 2 sensors on one bus works. But there is still the issue of not getting good initial readings.
Despite the
as5600_R.resetPosition();
as5600_L.resetPosition();
when there are 2 sensors I get erroneous readings such as
REV R: -1
REV L: 0
DEG R= 377487200°
DEG L= 132°
Rolling the motors forward increases the angles as expected, but rolling them back past 0 deg. is
resulting in those huge numbers . Ideally it would go to 359 , 358 etc degrees ,
Would you know what to do about that?
Thanks
mitch


Does this also work when the website is using SSL Certificate and Server Authentication?

My server is using a self signed certificate with server authentication on a DynDNS service. Does this work with nativefier?

Yes, you would need to use the --ignore-certificate option.

Thank you, this worked for me!


Type Archives should be automatically included in parsed types

What is the feature you'd like to have?
When I enter a type that contains a type defined in a Type Library that has not been defined in my analysis, the type parser will import that type from the Type Library and let me use it implicitly. This is not the same for Type Archives. It should be.
Is your feature request related to a problem?
I wanted to use the types in my Type Archive but I have to pull them and stuff first.
Are any alternative solutions acceptable?
Uncertain, maybe an option to auto-pull all types?
Additional Information:
Type parser could be refactored to take a type container as the source of types as well

This is implemented as of 4.1.5067-dev.


Rework 840 SPIM support

While working on the 840, I realized:

We don't implement SPIM3
SPIM0-SPIM2 only support a max speed of 8MHz. If you use a higher speed, it is oddly slow
We don't do implicit copies for embedded-hal

I should be able to submit fixes for this, though I'm not sure if any of the other targets support SPIM3 as well.

Hmm I wonder why I omitted SPIM3 when I wrote the HAL :/

SPIM3 is now implemented as of 0.12.0

SPIM3 is now implemented as of 0.12.0


SQL Server queries should make use of prepared statements

It's currently too easy to introduce the possibility of SQL injection. Parametrized queries should be used instead of string concatenation

Mostly fixed except for the submissions query

Completed - all queries use parametized input (not prepared statements as the title of this issue wrongly suggests should be the case)


Integration tests for CLI

Description
Write an integration tests for CLI.
Describe the feature you'd like to request
Tests cmd/main.go as CLI integration tests.
Describe the solution you'd like
Thinking..

It might be fine to write tests of cmd/main.go.


Series.min/1 throws error on integer series

Seems similar to #242.
Erlang/OTP 25 [erts-13.0.1] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit:ns]
Elixir 1.13.4 (compiled with Erlang/OTP 25)
Explorer 0.2.0
alias Explorer.{Datasets, DataFrame, Series}

Datasets.fossil_fuels()
|> DataFrame.group_by("country")
|> DataFrame.summarise(total: [:count])
|> DataFrame.pull("total_count")
|> Series.min()

Expected output: a number
Actual output:
** (ErlangError) Erlang error: :nif_panicked
    (explorer 0.2.0) Explorer.PolarsBackend.Native.s_min(shape: (222,)
Series: 'total_count' [u32]
[
	5
        [truncated a long list of 5's and 3's]
        ...
	3
])
    (explorer 0.2.0) lib/explorer/polars_backend/shared.ex:17: Explorer.PolarsBackend.Shared.apply_series/3

The problem is that some operations return Series that are from types we don't handle. In this example the series returned by the summarised DF is from the type UInt32, but we only handle Int64 for integers.  See:
https://github.com/elixir-nx/explorer/blob/607e612d449bc9b2f8adfd93ea60027374256dc3/native/explorer/src/series.rs#L480-L487
We need to cast the resultant aggregations or handle more types. I think it's better in terms of performance to handle the additional dtypes. @cigrainger what do you think?
PS: this works:
alias Explorer.{Datasets, DataFrame, Series}

s =
  Datasets.fossil_fuels()
  |> DataFrame.group_by("country")
  |> DataFrame.summarise(total: [:count])
  |> DataFrame.pull("total_count")

s |> Series.to_list() |> Series.from_list() |> Series.min()

We have two options:

Support more types internally.
Support more types and also expose them to users. This means our types are :u8, :u16, :s64, :f32, :f64, and so on.

Which route are we supposed to take?

I would go first with 1. and then we decide if we want to expose more types.


No UVC backend selected in python wrappers.

Issue Description
After building the lib from source, everything seems to work fine with examples, then when I try to build the python wrapper, the follow error was show to me
[  5%] Building CXX object CMakeFiles/pyrealsense2.dir/python.cpp.o
[ 11%] Linking CXX shared library pyrealsense2.cpython-36m-x86_64-linux-gnu.so
[ 11%] Built target pyrealsense2
Scanning dependencies of target pybackend2
[ 17%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/backend.cpp.o
/home/real/librealsense/src/backend.cpp:11:2: error: #error No UVC backend selected. Please #define exactly one of RS2_USE_LIBUVC_BACKEND, RS2_USE_WMF_BACKEND, or RS2_USE_V4L2_BACKEND
 #error No UVC backend selected. Please #define exactly one of RS2_USE_LIBUVC_BA
  ^
CMakeFiles/pybackend2.dir/build.make:62: recipe for target 'CMakeFiles/pybackend2.dir/home/real/librealsense/src/backend.cpp.o' failed
make[2]: *** [CMakeFiles/pybackend2.dir/home/real/librealsense/src/backend.cpp.o] Error 1
CMakeFiles/Makefile2:104: recipe for target 'CMakeFiles/pybackend2.dir/all' failed
make[1]: *** [CMakeFiles/pybackend2.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

I try to add the definition of v4l2 in the CMakeList.text  but the build show me the following error

Scanning dependencies of target pyrealsense2
[  5%] Building CXX object CMakeFiles/pyrealsense2.dir/python.cpp.o
[ 11%] Linking CXX shared library pyrealsense2.cpython-36m-x86_64-linux-gnu.so
[ 11%] Built target pyrealsense2
Scanning dependencies of target pybackend2
[ 17%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/backend.cpp.o
[ 23%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/win/win-helpers.cpp.o
[ 29%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/win/win-uvc.cpp.o
[ 35%] Building CXX object CMakeFiles/pybackend2.dir/pybackend_extras.cpp.o
[ 41%] Building CXX object CMakeFiles/pybackend2.dir/pybackend.cpp.o
[ 47%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/win/win-usb.cpp.o
[ 52%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/win/win-backend.cpp.o
[ 58%] Building CXX object CMakeFiles/pybackend2.dir/home/real/librealsense/src/linux/backend-v4l2.cpp.o
In file included from /home/real/librealsense/src/linux/backend-v4l2.cpp:6:0:
/home/real/librealsense/src/linux/backend-v4l2.h:6:21: fatal error: backend.h: No such file or directory
compilation terminated.
CMakeFiles/pybackend2.dir/build.make:230: recipe for target 'CMakeFiles/pybackend2.dir/home/real/librealsense/src/linux/backend-v4l2.cpp.o' failed
make[2]: *** [CMakeFiles/pybackend2.dir/home/real/librealsense/src/linux/backend-v4l2.cpp.o] Error 1
CMakeFiles/Makefile2:104: recipe for target 'CMakeFiles/pybackend2.dir/all' failed
make[1]: *** [CMakeFiles/pybackend2.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux Ubuntu 16

Kernel Version (Linux Only)
4.10.0-28-generic

Platform
PC

SDK Version
git

Are you building the main Cmakelists.txt or the one inside the python folder?
You should build the main one and only pass the -DBUILD_PYTHON_BINDINGS=ON flag.

or the one inside the python folder <- Yeah this one was my problem, thanks for the help
It works like a charm once you add the
-DBUILD_PYTHON_BINDINGS=bool:true
and the version on python you are using
-DPYTHON_EXECUTABLE=/home/real/miniconda3/envs/py36/bin/python
miniconda python 3.6 in my case
One question though is necesary to add all the suffix to the build ?
My build name -> pyrealsense2.cpython-36m-x86_64-linux-gnu.so
Thanks again


Change font size for blog and project posts

In the global.css file, html body section, I changed the font size from "text-sm" to "text-lg".
This updates the font size in all pages except for blog and project posts.
How can we apply the changes to posts?
Thank you.

Within src/layouts/BlogPost.astro and src/layouts/Project.astro find the prose-sm CSS class and change it to prose-lg.