Buttons: make .btn-secondary default state with transparent background

Note: Please transform - [ ] into - (NA) in the description when things are not applicable
Related issues
NA
Description
Change default state background to transparent.
Motivation & Context
Better fit design needs. For example this use case:

Types of change

Refactoring (non-breaking change)

Live previews

https://deploy-preview-2004--boosted.netlify.app/docs/components/buttons

Checklist

Contribution

[x] I have read the contributing guidelines

Accessibility

[x] My change follows accessibility good practices; I have at least run axe

Design

[x] My change respects the design guidelines defined in Orange Design System
[x] My change is compatible with responsive display

Development

[x] My change follows the developer guide
(NA) I have added JavaScript unit tests to cover my changes
(NA) I have added SCSS unit tests to cover my changes

Documentation

[x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[x] My change introduces changes to the migration guide
(NA) My new component is added in Storybook
(NA) My new component is compatible with RTL
[ ] Manually run BrowserStack tests
[x] Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
[ ] Code review
[ ] Design review
[ ] A11y review

After the merge

[ ] Manually launch Percy tests

@louismaximepiton Have you checked with the designers? Are these buttons on a transparent background in the kits, DSM, etc.? It's not mentioned in the description of the PR.

With the spec review of 25/04:
The default background of these buttons should be transparent. (cf. https://system.design.orange.com/0c1af118d/p/278ebc-buttons-standard/b/247486/i/48901890)

Good catch, I don't how we missed that.
For instance, the issues to tackle:

Back to top

Dropdowns -> Issue with the split dropdown -> Not a big fan of the workaround. Should we force background for dropdowns ?

Input groups -> Should we force background for default state ?

Quantity selector -> Force default background ?

Clearfix, barely visible

/docs/5.3/utilities/position/#examples -> the border goes under the button. -> Need to force default background ?

We already force background for pagination.

Seing all of this, wondering if the transparent background isn't the isolated case. Maybe a solution here could be to add  something like: .bg-transparent-no-important or .btn-transparent-bg and use it everytime we need it for components that have changing states. 😅

Maybe we can try to reintroduce https://getbootstrap.com/docs/5.3/components/buttons/#outline-buttons from Bootstrap but only for .btn-outline-secondary. Would mean no modification of existing components.


Chocolatey

Hi! Are there any plans to submit haruhi-dl to Chocolatey? I think that'd be terrific if it can happen!

I guess we can try to make that happen, I don't know if haruhi-dl has a working Windows build pipeline though.

The Windows binary build script from the ytdl repository uses python 2.7, which we have dropped, so we would have to upgrade the py2exe version. That would probably break the binary patches, which ytdl is applying to make it work on Wine. It seems like the Wine issue has been fixed a week ago, but we will have to wait for the next Wine 6.x release for that improvement to be shipped.

Got a working (tested with just Wine yet) .exe file with Python 3.8.8. I'll test that on actual Windows machines and try to insert Playwright into that somehow, but even if I somehow succeed, this will of course be optional (Playwright and non-Playwright binaries).

Thank you!!!!! Can you say more about what Playwright can do for haruhi-dl? It sounds exciting!

Playwright is required by some extractors, which we couldn't manage to create in a normal way (namely: TikTok user profiles), so instead hdl automates a web browser open in the background to fetch the wanted content. That's the ultimate approach, which we use only if all others fail.

That is so cool! I can see how it’s more of a fallback method, but I still like how it does it. Sounds like a successor to Selenium. Thanks for implementing Playwright!


python312Packages.langsmith: 0.1.56 -> 0.1.57

Diff: https://github.com/langchain-ai/langsmith-sdk/compare/refs/tags/v0.1.56...v0.1.57
Changelog: https://github.com/langchain-ai/langsmith-sdk/releases/tag/v0.1.57
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 310918 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

22 packages built:

pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python312Packages.langchain
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist


Is it safe to copy litedb file when it is used by a process

Can you clarify if it is safe to copy the Litedb file when the process is running?
I need a safe way to backup litedb files while my website is running.
If it is not safe to copy (if there is a possibility it produces a corrupt source or destination file)
I think we need a backup solution for it in the .net library

Hi @HolyOne, it's not safe to copy the datafiles while the database is open.
Currently there is no such option for a hot backup, it's something already requested though.
It's on the feature request list for next LiteDB versions.


idSelector falsely reports attribute selectors

The analyzer will report [href="#foo"] as an id-selector, which it isn't. Maybe the test should be appended with these selectors, which would yield 2 id-selectors:
#foo,
.foo #bar,
[id='baz'],
[href='#crux'],
[href=#foo] {
	content: '#foo';
}

Please use<EMAIL_ADDRESS>Thank you for letting me know. :)


New Bahamasair tail logo

Icon attributes

name
category
accessibility description

Bahamasair Tail
Tail Art
White airplane tail with colorful Bahamasair logo

The icon(s) per this request, has the new art been completed?
Yes, art has been added to the Figma docs
Attach exported SVG files to this issue
Bahamasair_Final.svg.zip

hello @leeejune  can you please make a PR for this issue as this logo needs to be prod by tomorrow


Add link to description of docs directory.

The content of the docs directory is described in detail in the x-api CONTRIBUTING gude.

:+1: (I imagine you're squashing)


Add new backup database dialog to MSSQL extension

This dialog uses the object management framework like our other admin dialogs, but re-uses the same STS calls as our existing backup experience. However, this dialog currently only supports backing up to a local file. I'll be adding URL support in subsequent PRs. We'll keep the current backup dialog around until the new dialog has the same feature parity and passes accessibility testing.
Closes https://github.com/microsoft/azuredatastudio/issues/24588
Screenshots:

With options expanded:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.573%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30786

Relevant Lines:
69355

💛  - Coveralls


LayoutParser should throw ThrowConfigExceptions on unknown properties

Change so it throws NLogConfigurationException when ThrowConfigExceptions = true
https://github.com/NLog/NLog/blob/733ce6e65045fd93de8bad6f9c5c67639e2d0978/src/NLog/Layouts/LayoutParser.cs#L384-L385
https://github.com/NLog/NLog/blob/733ce6e65045fd93de8bad6f9c5c67639e2d0978/src/NLog/Layouts/LayoutParser.cs#L436
https://github.com/NLog/NLog/blob/733ce6e65045fd93de8bad6f9c5c67639e2d0978/src/NLog/Layouts/LayoutParser.cs#L455-L456

I couldn't figure out how to include the entire layout-string but I'll create a PR anyway.


require options

Hi there,
Love the nest-commander package - very helpful to get cli functionality with nestjs :-)
Have hit a slight issue where adding the hint to indicate that a flag is required doest seem to be honoured, is that right or am I using it wrong ly. Example below to hopefully clarify what I mean...
so if i want to make an arg --sample-arg required I should
so according to the docs, using <> should make the flag required
  @Option({
    flags: '-s --sample-arg <sampleArg>',
  })
  parseArg(val: string): string {
    return val;
  }

however i can execute the command above without supplying -s flag so it looks like the option below (using [] syntax) is effectively the same
  @Option({
    flags: '-s --sample-arg [sampleArg]',
  })
  parseArg(val: string): string {
    return val;
  }

Do you have a minimum reproduction of this?

yep hopefully exemplified here https://github.com/digitalbanana/nest-commander-exemplar

Thanks for the reproduction.
With commander and options, the [] or <> syntax determines if a value is required if the option is passed. So if you do node dist/main basic -s it's fine because -s, --string [string] is used, and you'll get back true, but if you do node dist/main basic -n you'll get an error at runtime because the value for number is missing.
Commander has the idea of requiredOptions which are options that are required to be run with the command, i.e. node dist/main basic would then throw an error because it's missing the -n option. I can work on adding that in via an option on the decorator, as right now options are only added in with program.option and not program.requiredOption.

ah ok that makes sense - thanks for clarifying....
required option would be super useful, am happy to contribute if want any help but need a pointer of where to begin :-p

We'll need to update the OptionMetada to include something like requiredOption as a boolean. And probably a bit of refactoring would be necessary on this method of the command-runner service class so that we can track this requiredOption value. Then we should just need to make a switch here to use requiredOption instead of option. Feel free to take a shot at it if you feel comfortable with it

nice feature request!
@jmcdo29 I am giving a shot today to your cli vs nestjs-console.
This console looks very promising! Best of luck

Let me know what you think. Also, I'm active on Nest's Discord Server where there's a dedicated channel for #nest-commander so feel free to message there too.

@digitalbanana just checking in to see how progress on this is coming if you've had the time. No worries if not

🏓

This has been added and published in<EMAIL_ADDRESS>

awesome thanks @jmcdo29


Use different exit code on istioctl parse error

Right now all of the error codes for all CLI errors are hardcoded as 1.
In an effort to make these more useful, this diff changes incorrect CLI
usage to exit code 64. This is a necessary step for #17862.
It also has a bit of an idea on how adding new exit codes would
work--the intention is to add mappings of error type -> integer via a
switch statement in sysexit.go. The name of the file is also a nod
towards the inspiration for the values: sendmail/glibc/BSD sysexits.h
I don't like checking for substrings but cobra doesn't give much
flexibility outside of flag parsing so this is the best I could come up
with.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

@zerobfd: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
8c7a337c2e3955654abaf9e790fa59635406b850
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zerobfd: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
8a8dcab857fd04e84a50b0f4ade0629d7cd4f5fc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Also, it seems https://github.com/spf13/cobra/pull/964 will support unknown command error functions when it gets merged so we can drop the string comparison.


Multi checkbox displays JSON on view rather then the values from the BREAD details

Laravel version
8.6.5
PHP version
7.4
Voyager version
1.5
Database
MySQL 8
Description
Multi checkbox displays as JSON on view rather than the values from the BREAD details
Steps to reproduce
Create a multi checkbox row with options:
{ "checked": false,     "options": {         "checkbox1": "Slab",         "checkbox2": "Frame",         "checkbox3": "Drywall",         "checkbox4": "Inspection",         "checkbox5": "Final"     } }
Expected behavior
On the view page it should show the values of those checked the same way it shows on the browse page. Right now I have the first 2 checked and on the view page I get:
{"checkbox1":"checkbox1","checkbox2":"checkbox2"}
It should display:
Slab, Frame,
Screenshots
No response
Additional context
No response

Looks like there is not a @elseif($row->type == 'multiple_checkbox') in the 'bread/read.blade.php' view, it just dumps the JSON as if it were a text field.
I added this and it's all good now:
`
@elseif($row->type == 'select_multiple')
                            @if(property_exists($row->details, 'relationship'))

                                @foreach(json_decode($dataTypeContent->{$row->field}) as $item)
                                    {{ $item->{$row->field}  }}
                                @endforeach

                            @elseif(property_exists($row->details, 'options'))
                                @if (!empty(json_decode($dataTypeContent->{$row->field})))
                                    @foreach(json_decode($dataTypeContent->{$row->field}) as $item)
                                        @if (@$row->details->options->{$item})
                                            {{ $row->details->options->{$item} . (!$loop->last ? ', ' : '') }}
                                        @endif
                                    @endforeach
                                @else
                                    {{ __('voyager::generic.none') }}
                                @endif
                            @endif

                            // new code

                            @elseif($row->type == 'multiple_checkbox' && property_exists($row->details, 'options'))
                            @if (@count(json_decode($dataTypeContent->{$row->field})) > 0)
                                @foreach(json_decode($dataTypeContent->{$row->field}) as $item)
                                    @if (@$row->details->options->{$item})
                                        {{ $row->details->options->{$item} . (!$loop->last ? ', ' : '') }}
                                    @endif
                                @endforeach
                            @else
                                {{ __('voyager::generic.none') }}
                            @endif

`

You mean this?
https://github.com/the-control-group/voyager/blob/1.5/resources/views/bread/browse.blade.php#L147

Correct. Seems to be missing on the view/read page. I basically copy/paste that into the view.blade.php and change the $data to $dataTypeContent and it functions as expected.

but why in model's table store like this
{"MainBanner":"MainBanner","BoxesArea":"BoxesArea"}
my options is
{"checked":true,"options":{"MainBanner":"Baner","BoxesArea":"BoxesArea"}}


Selected vertexes including their halos covered by rendered names

Currently the selection of a vertex might be invisible because any name of a highway etc. is rendered on top.
Rendered names are automatically hidden when

the cursor is near to the name,
or the named element is selected

Rendered names should also be hidden if any selected, related, or hovered entity is near to the name.

Yes, I agree.. This regressed recently, probably when I did #1645


Move project SonarCloud instance to ASWF organization

Projects repos un the ASWF GitHub org inherit SONAR_TOKEN from organization level secrets which gives access to the ASWF SonarCloud organization where most of the repos already have their analysis results:
https://sonarcloud.io/organizations/academysoftwarefoundation/projects
rez has its own SonarCloud, pre-existing SonarCloud project:
https://sonarcloud.io/project/overview?id=nerdvegas_rez
As per discussion on the #rez channel, it seems the historical data in that SonarCloud project is not super useful, so the suggestion is to delete the existing SonarCloud project, at which point the link between the ASWF SonarCloud project and the rez GitHub repo can be established by the LF RelEng team.
Motivation
It would be nice to have a single SonarCloud dashboard for all ASWF projects, enhancing discoverability.

SonarCloud properties will need to be updated in:
https://github.com/AcademySoftwareFoundation/rez/blob/1ecc85f638d11d70ed78d4bd9c5cdc6f32ac58c4/.sonarcloud.properties
And if deemed sufficiently useful, set up a schedule GHA analysis run.

We should also revisit https://github.com/AcademySoftwareFoundation/rez/issues/1160.

It seems like since this issue was created, nerdvegas_rez was deleted, so the badges on the readme now all display "Project not Found"

To get the process started, a ticket could be opened with LF releng team to have a rez project created under the ASWF sonarcloud org.

ticket opened with LF RelEng.

@jwagantall has updated sonarcloud properties file in #1509 .
I think we need to wait for at least one successful run of rez in the new instance and then I should be able to update the badges.


SDK-19 - made some improvements to the example scripts

@kiranbali Could you take a look at this pull request and my comments as well? Let's make sure the Readme is in line with your documentation standards.

Looking good! Maybe you could squash the commits There's no point in having 4.


feat: smarter verification

Motivation
There is no need in requiring contract name/path in forge verify-contract. For example, hardhat does not require that.
Solution
This PR introduces smarter way of identifying contracts by deployed code which respects immutable/link references and targets exact bytecode match (ContractsByArtifact::find_by_deployed_code_exact). I believe this could be useful for stuff unrelated to verification as current diff score method is not really great.
Also, this PR makes contract: ContractInfo parameter on VerifyArgs optional, thus allowing to do just forge verify-contract <address>. The artifact to use is determined by matching local bytecode through find_by_deployed_code_exact.
I've also changed flow to not rely on cache (except for determining version by looking at recent artifacts). We now trigger compiler directly if we need to get cached abi or metadata and it just uses cache if it's available instead of throwing a error when run on a project without cache.
In combination with --guess-constructor-args it now allows users to verify deployments of arbitrary project contracts much easier by just doing forge verify-contract <address> --guess-constructor-args
Next steps could probably be identifying libraries used when linking contract automatically as well.

eth_feeHistory bug should go away with #7934


MSC3173: Expose stripped state events to any potential joiner

Rendered
FCP vote

Since this is pretty much a clarification / expansion of current behavior, I don't think this really needs an implementation since...the current implementations already implement this. 😄

I don't believe this needs an implementation to go forward, so can probably jump straight to starting FCP now?

Right, it is pretty much implemented already since it is formalizing current behavior. 👍

@mscbot fcp merge

Spec PR: https://github.com/matrix-org/matrix-doc/pull/3606

Merged 🎉


fix: Fix shared element transition problems for older version

Detail:

Only set shared element transition for API version >= 26
Remove delay for loading image

Fixes: #1805, #1804
Discussion on #1799

What about PR #1799

What about PR #1799

I still keep it for issue #1798, I split the two as I think it is not a good habit to make 1 PR for multiple issues, and recently I do it quite a lot...


Enum literal syntax highlighting issues

pub const wlr_xdg_surface_union = @typeInfo(wlr_xdg_surface).Struct.fields[5].name

                    .@"isize" => Type.initTag(.@"isize"),
                    .@"usize" => Type.initTag(.@"usize"),
                    .@"c_short" => Type.initTag(.@"c_short"),

Semi-related:
const foo = enum {
    u8,
    isize,
    noreturn,
    aeouaoeu,
};

These are all valid field identifiers that do not clash against identifiers in the main namespace. This is a problem with the vim syntax highlighting as well.

the enum literal highlighting issue is fixed in the latest release, but linguist is pointed at 28c5a88.

Linguist was updated but the first case is still bugged:
}.not_an_enum_literal
].not_an_enum_literal
.*.not_an_enum_literal
.?.not_an_enum_literal


ShowVer.exe does not return browser versions on Windows 10

The ShowVer.exe does not return any browsers versions on Windows 10.
If you add an error logging in the exec callback you can see that the command returns a "Permission denied" error on Windows 10:
https://github.com/bitovi/launchpad/blob/master/lib/local/version.js#L21
  // Run ShowVer.exe and parse out ProductVersion key (Windows)
  if (process.platform === 'win32') {
    var command = path.join('"' + __dirname, '..', '..', 'resources', 'ShowVer.exe" "' + browser.command + '"');
    var deferred = Q.defer();

    debug('Retrieving version for windows executable', command);
    // Can't use Q.nfcall here unfortunately because of non 0 exit code
    exec(command, function(error, stdout) {
      console.log('DEBUG:', error); // <-- Added logging
      var regex = /ProductVersion:\s*(.*)/;
      // ShowVer.exe returns a non zero status code even if it works
      if (typeof stdout === 'string' && regex.test(stdout)) {
        browser.version = stdout.match(regex)[1];
        debug('Found browser version', browser.name, browser.version);
      }

      return deferred.resolve(browser);
    });

    return deferred.promise;
  }

Output:

I have set the environment variables LAUNCHPAD_BROWSERS and LAUNCHPAD_FIREFOX, LAUNCHPAD_CHROME, LAUNCHPAD_EDGE.

I'm having this issue on Windows 7 as well.
This is causing problems when using the web-components-tester (https://github.com/Polymer/tools/issues/528)
As far as I understand, this happens when you set the environment variables, overriding the default paths.
Does anyone know a way to go around this error?

Closed via #125


feat(block): add Block::all_borders

This avoid creating a block with no borders and then settings Borders::ALL. i.e.
- Block::default().borders(Borders::ALL);
+ Block::all_borders();

Searching on github, 1.3K use .borders(Borders:ALL) for a total of 1.5K .borders( usage.
Names I considered:

all: too implicit, Block::all() in the wild isn't clear
with_borders: would be confused with with_borders(b: Borders) i.e. with a parameter
with_all_borders: the most explicit but too long imo
borders_all: to match with Borders::ALL enum, nothing wrong with that, I just feel like Block::all_borders is easier to read and more natural

Intuitively I would say the correct name for this function would be with_borders or with_all_borders but I see why you chose all_borders. One issue is that it sounds like block.all_borders to me. How about Block::bordered?

How about Block::bordered?

Sounds great, I change it now.

It would be worth taking a look through the following to get some idea of how people are calling this outside and inside ratatui:

https://github.com/search?q=ratatui+"Block%3A%3Anew"+NOT+repo%3Aratatui-org%2Fratatui+&type=code
https://github.com/search?q=ratatui+"Block%3A%3Anew"+repo%3Aratatui-org%2Fratatui+&type=code

Perhaps it would be worth breaking backwards compatibility and introducing borders, and title params to the new function? This would be a two step change - deprecate new() (so users can replace with default()) and then change it to add the new params.
let block = Block::new("title", Borders:ALL);

There's enough ways to create titles (left align, center align, right align; multiple titles etc) that I don't think I'd want to do this.
let block = Block::new("title", Borders:ALL);

Paragraph::new(text) always confuses me because I type Paragraph::new() first. For better or for worse, ergonomic rust is using builder methods.
But I could be convinced that Block::default() should do Block::new().borders(Border::ALL) instead.

For better or for worse, ergonomic rust is using builder methods.

I'm in strong disagreement with this statement. A constructor should accept the most common or most necessary items that a type needs. Builder methods are there for the things which are more optional than necessary. If 90% (unchecked number) of the usages of block set borders and a title, then that is what should be in the new() constructor.

There's enough ways to create titles (left align, center align, right align; multiple titles etc)

That's fine - title should be just fn new<T: Into<Line>(title: T, ...).
"Multiple titles" is a lower priority item as it falls in the 5% bucket.
Also, I've been rethinking the need for block::Title to have an alignment field. Line already has this, so it's unnecessary. Then if we look at position, this is a property of the block, not of the title itself, so that could just be Block::top_title() and Block::bottom_title(), which would remove the Title type entirely. It's 100% unnecessary and sits in a weird place in the widget hierarchy.

Paragraph::new(text) always confuses me because I type Paragraph::new()

Not sure what you mean by this. Paragraph is 100% useless without content, so why would it ever be good to have an empty constructor for it?

https://rust-lang.github.io/api-guidelines/predictability.html#constructors-are-static-inherent-methods-c-ctor

Added an issue for fixing up title:

https://github.com/ratatui-org/ratatui/issues/738

In languages like Python, all three of these can build a Block:
Block(title = "title", borders = "all")
Block(borders = "all", title = "title")
Block(borders = "all")
Block()

In Rust, we have to use this pattern for the same benefits (not breaking future features, configuration of defaults, changing order in which you set fields, etc):
Block::new().title("title").borders(Borders::ALL)

which my understanding of is why it the convention for building structs.
Also, you can build a Block without a title using Block::new().borders(Borders::ALL). Along the same lines of the Paragraph point you pointed out, Block::new(title, borders) implies these are required and doesn't hint at other options (e.g. padding). It also is easier to end up breaking in the future if we decide to add a new field that is of equal importance to title and borders.
fwiw, I like that Paragraph::new takes text because as you said it is useless without content. But I also don't remember every new function in ratatui and their signatures. I don't want to change Paragraph::new or for example the constructor for Table::new, I was trying to give an example where what I type on autopilot doesn't work and the cognitive overhead of different ways of constructing something.
Also, it is generally way faster for me to type $Widget::new().<TAB> and wait for autocomplete to give me options than it is to type $Widget::new(<TAB>, then complete the required arguments, and then continue with $Widget::new(...).<TAB> to look for more options. I find it ergonomic when I get . autocomplete for all available optional configuration.

It'd be nice if GitHub allowed us to fork a thread into a separate issue :) We can continue this discussion off this PR.

It'd be nice if GitHub allowed us to fork a part of thread into a separate issue :) We can continue this discussion off this PR.

https://github.com/ratatui-org/ratatui/discussions/747

Reading https://rust-lang.github.io/api-guidelines/predictability.html#constructors-are-static-inherent-methods-c-ctor, with_all_borders() probably does make the most sense. Approving this though as I don't feel strongly about it in comparison to bordered().

I'd be in favor of with_all_borders if it wasn't for with_selected and such in states (https://github.com/ratatui-org/ratatui/blob/803a72df27190e273556e089e42036bfc001f003/src/widgets/list.rs#L81).
I like bordered too so I think I'll merge this later, waiting to see if anyone has any more objections.

Responding to relevant comments regarding breaking new and cognitive overhead in bulk:
If breaking changes weren't a concern, I would have changed the default of Borders to ALL, because this makes the most sense to me.
This would have changed Block::default to build a bordered block, which is a sane default IMO.
But I get @kdheepak's point where you basically want a clean sheet and add onto it. So I'd keep new to build the most clean block possible.
The opposite could do too, i.e. new builds bordered and default clean. That way we could have "autopilot builder" but also sane/easy default.

As for adding parameters to Block::new, I think block is used in too many different ways to do that. i.e. some use a simple string as title, some configure the title ..., whereas Borders is almost always simply ALL, making it boilerplate from my point of view.
Also that would make the constructor hard to read in user code. And agree to some extent with @kdheepak, it makes sense to build a block without title or border, whereas is doesn't to build a Paragraph without text (but you could and that's a good thing) :

implies these are required and doesn't hint at other options

Anyway I'm afraid this will be too much of a breaking change and thus not worth it. Which is why I choose a specialized bordered constructor as alternative.


Coding-completion takes longer than usual to complete

We have written the needed data into your clipboard because it was too large to send. Please paste.

It looks like you submitted this issue from the issue reporter, but you missed pasting the information from the clipboard

In what file type are you seeing this?
What version of VS Code are you using?
Please share sample code.

Please provide proper description with steps to reproduce and reopen.


Make controller API consistent

There are a few class of issues with the API today

Config Field name (eg: tablename inside table config sometimes has type - sometimes not)
get and put json payloads: json retrieved from get API doesn’t always work with PUT.

A word of caution on this. For table deletion, we specifically added table type sometime back (not sure if it is still there), preventing the operator from deleting realtime table unless they know what they are doing. The reason is that it is very easy to recreate the offline table with data if it is accidentally deleted. We don't have a mechanism to upload realtime segments yet, and so the only option is to re-consume data (and the underlying stream may not have a long retention).

Good point. Yes we should probably continue such safeguards but try to make
other things as consistent as possible.
On Fri, Oct 2, 2020 at 4:43 PM Subbu Subramaniam<EMAIL_ADDRESS>wrote:

A word of caution on this. For table deletion, we specifically added table
type sometime back (not sure if it is still there), preventing the operator
from deleting realtime table unless they know what they are doing. The
reason is that it is very easy to recreate the offline table with data if
it is accidentally deleted. We don't have a mechanism to upload realtime
segments yet, and so the only option is to re-consume data (and the
underlying stream may not have a long retention).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pinot/issues/6099#issuecomment-703002912,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFRXV77JJDTM4DGNVOIALLSIZQTLANCNFSM4SCHMXAQ
.

--
Thanks and regards
Chinmay Soman


Fix the mish fallback.

The fallback should be the python version, not the custom op.

@digantamisra98
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Modrinth download doesn't work for no-chat-reports

Describe the problem
After adding MODRINTH_PROJECTS=no-chat-reports, the build fails with Failed to parse version response. Removing no-chat-reports and the build works normally.
Container definition
podman volume create mc-test-data
podman run -e EULA=TRUE -e TYPE=FABRIC -e MODRINTH_PROJECTS=fabric-api,lithium,phosphor,no-chat-reports -v mc-test-data:/data --name mc-test docker.io/itzg/minecraft-server:latest

Container logs
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x. 9 1000 1000 4096 Aug 28 20:12 /data'

[init] Resolved version given LATEST into 1.19.2 and major version 1.19

[init] Resolving type given FABRIC

[init] Checking Fabric Launcher version information.

[init] Checking Fabric Loader version information.

[mc-image-helper] 20:15:17.512 INFO  : Downloading phosphor-fabric-mc1.19.x-0.8.1.jar

[mc-image-helper] 20:15:17.514 INFO  : Downloading lithium-fabric-mc1.19.2-0.8.3.jar

[mc-image-helper] 20:15:17.593 INFO  : Downloading fabric-api-0.60.0+1.19.2.jar

[mc-image-helper] 20:15:17.657 ERROR : 'modrinth' command failed: Failed to parse version response

Streaming disconnected

Downgrading instance to 1.19.1 made the problem disappear for a while, but it's now back.
Sounds like it might be something on the Modrinth side?

Yeah. I haven't had a chance to investigate yet, but there must be something unusual about the metadata for that one specifically. I'll have to see if there's a heuristic to adapt to what they're doing.

The latest image is building now. With pulling that feel free to reopen and comment if the issue still isn't fixed. There was a bug on my part missing dependencies marked as "embedded".

Build is almost done but looks like I have broken java 8
https://github.com/itzg/docker-minecraft-server/actions/runs/2986036826

It went further (the file name of the mod is printed), but then it failed with 'modrinth' command failed: HttpClient request failed: 404 Not Found.

Recreated the issue by enabling optional dependencies. That led to finding a typo in one of my request URLs. Fix is on the way.

This time it looks like it should be fixed.


[Templating] AdaptiveCards.Templating does not work with Applications using Bot Framework DotNet SDK 4.20.0

Platform
What platform is your issue or question related to? (Delete other platforms).

.NET

Author or host
Host running on ASP.NET Core 6.0 running Bot Framework
Version of SDK
AdaptiveCards.Templating 1.4.0
Issue
The June 2023 version of the Bot Framework (https://github.com/microsoft/botbuilder-dotnet/releases/tag/4.20.0) has changed to use ANTLR 4.11.1
See https://github.com/microsoft/botbuilder-dotnet/issues/6558 and https://github.com/microsoft/botbuilder-dotnet/pull/6586
AdaptiveCards.Templating is using ANTLR 4.8
Unfortunately ANTLR 4.10 (https://github.com/antlr/antlr4/releases/tag/4.10) seems to have broken the generated parsers and lexers in AdaptiveCards.Templating.
When creating a new AdaptiveCardTemplate class
new AdaptiveCardTemplate(templateJson).Expand(rootData)
we get a Type Initialization error
Method not found: 'Antlr4.Runtime.Atn.ATN Antlr4.Runtime.Atn.ATNDeserializer.Deserialize(Char[])'.

Thanks for reporting this issue. We will look into this issue.

+1 here
This incompatibility is very annoying! Is there any ETA on this?
Matt

This issue has been raised by somebody else as https://github.com/microsoft/AdaptiveCards/issues/8615
The other issue seems to be getting a bit more commenting on.

Please follow issue #8614 for further updates, including the ETA


Upgrade commons-text to 1.10 to fix CVE-2022-42889 vulnerability

Apache commons-text-1.9 is vulnerable to CVE-2022-42889 (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42889). Please upgrade to 1.0.10

Fixed will be pushed out in v1.0.36 merged today


refactor(navbar): rename collapsed states in the navbar components in expanded

Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.
Rename:

setCollapseElement in setExpandedNavDropdownElement
setCollapseName in setExpandedNavDropdownName
collapseName in expandedNavDropdownName
collapseElement in expandedNavDropdownElement
setNestedDropdownElement in setDropdownDropdownElement
setNestedDropdownName in setDropdownDropdownName
nestedDropdownElement in dropdownDropdownElement
nestedDropdownName in dropdownDropdownName


ARROW-13579: Expose Create EmptyArray, EmptyRecordBatch and EmptyTable utility functions.

Refactor CreateEmptyArray and CreateEmptyChunkedArray, and create CreateEmptyRecordBatch and CreateEmptyTable.

Hi, everyone. Thanks for your feedback. I updated this PR, and I think it's ready for final review/merging. Let me know if anything needs to be taken care of from my end.

I've already made the requested changes. I think it's ready.

Requested changes are done :)


[RFC]: improve README examples of simulate/iter namespace

Description
This RFC proposes to improve the README examples of the simulate/iter namespace package. Currently, namespace package READMEs only include minimal examples which are not particularly informative and do not showcase namespace functionality.
Historically, namespace examples were not given much effort due to the rapidly changing nature of the project; however, now that development and organization has settled, it would be good to revisit these packages and add proper examples to better communicate to users how to use namespace contents.
For those wanting to contribute to this issue, you can use the following steps:

Browse through the contents of the simulate/iter namespace and identify interesting functions and packages to showcase.
Update the example code block in the "Examples" section of the README for the simulate/iter namespace and open a PR.
When updating the README, examples should follow existing project conventions (e.g., ES5).
Examples may require functionality from other packages to help make examples more interesting.

Related Issues
None.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

I would like to work on this issue !!


Use a better font for the silkscreen

Candidates:

https://fonts.google.com/specimen/VT323?category=Monospace&preview.text=USB BOOT&preview.text_type=custom
https://fonts.google.com/specimen/Roboto+Condensed?category=Sans+Serif,Display,Handwriting,Monospace&preview.text=USB BOOT&preview.text_type=custom
https://fonts.google.com/specimen/Anybody?preview.text=USB BOOT R5 SW27&preview.text_type=custom&category=Sans+Serif,Display,Handwriting,Monospace
https://fonts.google.com/specimen/Barlow+Condensed?preview.text=USB BOOT R5 SW27&preview.text_type=custom&category=Sans+Serif,Display,Handwriting,Monospace
https://fonts.google.com/specimen/Chakra+Petch?preview.text=USB BOOT R5 SW27&preview.text_type=custom&category=Sans+Serif,Display,Handwriting,Monospace
https://fonts.google.com/specimen/Concert+One?preview.text=USB BOOT R5 SW27&preview.text_type=custom&category=Sans+Serif,Display,Handwriting,Monospace

Seems this isn't easy in the current version of kicad. Kicad 7 might have support for other system fonts, so I'll leave this out of v0.3.


More precise errors

Move a bunch (but not all) of our generic BadParamErrors to different, more descriptive, error types.
Generally left some BadParamErrors if the error didn't feel like a validation error to me.

LGTM so long as we're still correctly raising/returning RequestError-types at the end of API calls (so that the HTTP status code gets back to the caller).

Yeah, we still intercept every exception inheriting from SigoptValidationError at the prod.py level and turn it into a BadParamError at the very end- that's one reason I'm not super inclined to kill that particular error overall, we still turn everything into that error when sending it out to the public.

perfect! yeah, BadParam, with its HTTP code, is still an appropriate thing to throw, and now it's only at the right level. awesome!


Add ControlAlert component, tests, and examples

Related issues
This PR closes https://github.com/mapbox/mr-ui/issues/50 as it adds ControlAlert.
Description of changes
👋 Open to discussion/feedback!
ControlAlert
This kind of alert has been used by Accounts-related web apps.

New component, examples, and tests that uses Icon and Tooltip. Allows opinionated variation in the following:

autoFocus
onButtonClick
theme ('error', 'locked', 'success', 'warning')

Conscious design decisions with @angel:

While cards and modals can Close or Collapse, alerts are Dismissed
Theme coloring and icons are set by severity:

success (green)
warning or locked (yellow)
error (red)

TODO:

Should the icons scale with the children text? We do this for ChevronousText but currently not for ControlCard. The screenshots below display Icon with a set width of 18px and an adjusting inline height to the the parent element's line-height.

Testing

Created/updated documentation examples for each component. See the documentation Batfish site with npm run start-docs.
Created/updated Jest test cases and snapshots for each component. See npm test and the test cases app with npm start.

@lshig these look good to me, why is the yellow power ranger centered and in caps?

@angel Oh. Just an example of what's possible... Yellow, eye-catching, and right in the center.

The documentation examples will be hosted at https://mapbox.github.io/mr-ui/ once these changes are released. They can also be viewable locally if you run npm run start-docs.

@lshig can we restrict that the text is always left aligned?

@angel We can make it a general rule of thumb by design: when we use this component in web apps at Mapbox, we should by default let ControlAlert's children body text be left aligned and sentence cased. I don't think it should be the responsibility of ControlAlert to enforce the prop children's styling since we vary in use of margins, padding, capitalization, text size, text alignment, etc.
We discussed this on Slack, but FYI to anyone curious, we decided to scale the ControlAlert icons with 1.3em width. Also to encourage text to be sentence cased or left aligned by example, I adjusted the doc example at 9e44044.


Can not open .app file

It is treated like a folder and anything inside is not recognised as a correct file format. HOW DO IT USE IT???

Sorry man, it is for MacOS, not for MacOS X, right? I am dumb, sorry for that.

What version of Mac OS are you on? ResForge is compatible with 10.14 (Mojave) and later.

It's 12.4 Monterey, sir! I can reproduce this behaviour over and over.

ResForge is indeed compatible with Monterey. Can you post a screenshot of what you're seeing?

Closing due to inactivity, but feel free to reopen if this is still an issue.


Now valid if no rules attached to ValidatableInterfaceElement + tests

resolves #68
No more fatal error for ValidatableInterfaceElement if no rules attached to it. Still printing warning to the console in Debug environment, thus it could be unwanted behavior.

Brilliant. Thanks for writing the test too.

@adamwaite it seems, you haven't merged it instead closed :-)

lol, done now.


Modifying cleanup logic and fixing cli usage of --all

delete commands with component name and --all complains silently and
did not delete the requested resource. As we are providing component
name and related namespace so prioviding --all option is erroneous

As added another PR (https://github.com/SUSE-Cloud/socok8s/pull/40) for fixing --all usage only where resources are cleaned for given namespace only. So abandoning this one as its not needed.


Cannot load factories on CI

Hello everyone,
I fought about two days trying to debug this issue, but I did not get anywhere. Here's the situation. Everything runs smoothly with green Cypress suite locally, but everything fails on Semaphore CI due to the same error in all my beforeEach blocks.
Here's the Rails server logs extract from the same thing passing locally and then failing on Semaphore.
PASSES LOCALLY
[CY_DEV] APPCLEANED
Started POST "/__cypress__/command" for <IP_ADDRESS> at 2019-08-09 10:44:57 +0300
[CY_DEV] handle_command: {"name"=>"factory_bot", "options"=>[["create", "user"<EMAIL_ADDRESS>"password"=>"123456"}]]}
[CY_DEV] running create, ["user"<EMAIL_ADDRESS>"password"=>"123456"}]
[CY_DEV] Loading Factories
[CY_DEV] -- Loading: ./spec/factories/queue_box.rb
[CY_DEV] -- Loading: ./spec/factories/organization.rb
[CY_DEV] -- Loading: ./spec/factories/user.rb
[CY_DEV]    (0.3ms)  BEGIN
[CY_DEV]   User Exists? (1.0ms)  SELECT 1 AS one FROM "users" WHERE "users"."email" = $1 LIMIT $2  [["email"<EMAIL_ADDRESS>["LIMIT", 1]]
[CY_DEV]   User Create (0.9ms)  INSERT INTO "users" ("email", "encrypted_password", "created_at", "updated_at") VALUES ($1, $2, $3, $4) RETURNING "id"  [["email"<EMAIL_ADDRESS>["encrypted_password", "$2a$04$XiCvwiGgEoTq6/2x91rMLO0aXHXOuPd/Bds7q22lnimRaFc7AW4Xa"], ["created_at", "2019-08-09 07:44:57.701176"], ["updated_at", "2019-08-09 07:44:57.701176"]]
[CY_DEV]    (0.4ms)  COMMIT
Started GET "/login" for <IP_ADDRESS> at 2019-08-09 10:44:57 +0300

FAILS ON SEMAPHORE CI
[CY_DEV] APPCLEANED
Started POST "/__cypress__/command" for <IP_ADDRESS> at 2019-08-09 10:07:26 +0000
[CY_DEV] handle_command: {"name"=>"factory_bot", "options"=>[["create", "user"<EMAIL_ADDRESS>"password"=>"123456"}]]}
[CY_DEV] running create, ["user"<EMAIL_ADDRESS>"password"=>"123456"}]
[CY_DEV] Loading Factories
[CY_DEV] KeyError: Factory not registered: "user"

For reference, this the failing test output:
http://localhost:5002/__cypress__/command

The response we received from your web server was:

  > 500: Server Error

This was considered a failure because the status code was not '2xx' or '3xx'.

If you do not want status codes to cause failures pass the option: 'failOnStatusCode: false'

-----------------------------------------------------------

The request we sent was:

Method: POST
URL: http://localhost:5002/__cypress__/command
Headers: {
  "Connection": "keep-alive",
  "user-agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Cypress/3.4.1 Chrome/61.0.3163.100 Electron/2.0.18 Safari/537.36",
  "accept": "*/*",
  "accept-encoding": "gzip, deflate",
  "content-length": 115
}
Body: {"name":"factory_bot","options":[["create","user",{"email":"user+cypress-test1@example.com","pass...

-----------------------------------------------------------

The response we got was:

Status: 500 - Server Error
Headers: {
  "content-length": "8415"
}
Body: Puma caught this error: Factory not registered: "user" (KeyError)

To me it is pretty obvious that when the suite runs on Semaphore, the cypress-on-rails is unable to load the factory definitions. Is there a reason that you suspect behind this?
Finally, in one of my attempts to get somewhere with this, I tried to verify that the paths of the factories are being accessibly/visible from within where the suite runs on Semaphore. So, I did,
bundle exec rails runner "puts FactoryBot.factories.clear; puts Dir[*%w[spec/factories.rb ./spec/factories/**/*.rb]].each { |f| Kernel.load f }"

Running via Spring preloader in process 2739
{}
./spec/factories/queue_box.rb
./spec/factories/organization.rb
./spec/factories/user.rb
exit code: 0 duration: 4s
export SEMAPHORE_JOB_RESULT=passed

hey @ispyropoulos
unfortunately i can't think of any reason why this is not working on Semaphore 😞

I've run into the exact same issue on GoCD 🤯

maybe there is a bug in the file timestamp comparison code.
Try updating your cypress_helper.rb to "always reload" to confirm if that is the case.
EG
CypressOnRails::SmartFactoryWrapper.configure(
    always_reload: true,
    factory: factory,
    files: %w(spec/factories.rb ./spec/factories/**/*.rb)
)

Or maybe the application is not getting started while in the application root.
Try updating your cypress_helper.rb to include the "Rails.root"
EG
CypressOnRails::SmartFactoryWrapper.configure(
    always_reload: !Rails.configuration.cache_classes,
    factory: factory,
    files: ["#{Rails.root}/spec/factories.rb", "#{Rails.root}/spec/factories/**/*.rb"]
)

This worked, thanks!!
CypressOnRails::SmartFactoryWrapper.configure(
  always_reload: !Rails.configuration.cache_classes,
  factory: FactoryBot,
  files: [
    Rails.root.join('spec', 'factories.rb'),
    Rails.root.join('spec', 'factories', '**', '*.rb')
  ]
)

Thanks a lot @grantspeelman! I have managed to make my Cypress branch green finally 🙏
I think it'd be a great idea if we could make this change in master as well. It may save lots of hours of confusion for some people.


🐞[bug]: IMPROVING THE Services page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I want to improve the services page in the website
Expected behavior
I will make it more modern
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@Rizvi-Faiz  go ahead.


enable next cloud in new playground

Changes
just uncommented next cloud route
Related Issues
#1773

It was supposed to have some sort of flare to indicate it's a community solution


Add task script status reporting logic

Closes #319; ~still missing testing and the Go–side code~. See #318 for an explanation of the ExecStart=- syntax.
Bonus: closes #321 with (guess it) pure bash

I would put all that logic inside tpi stop. That would examine the logs and determine if we are OK, failed, etc...

@0x2b3bfa0 should I take this one?

If there isn't a draft pull request by tomorrow morning, 👍🏼

Should I take it?

⌛ 🏃🏼 😓 Pushing things in a few minutes if there isn't any ontehr unexpected issue. It's going to be “plan b” standing for bash, though. 😄

terraform {
  required_providers {
    iterative = {
      source = "github.com/iterative/iterative"
    }
  }
}

provider "iterative" {}

resource "iterative_task" "succeeded" {
  name  = "succeeded"
  cloud = "aws"
  script = "#!/bin/sh\nexit 0"
}

resource "iterative_task" "failed" {
  name  = "failed"
  cloud = "aws"
  script = "#!/bin/sh\nexit 1"
}

resource "iterative_task" "running" {
  name  = "running"
  cloud = "aws"
  script = "#!/bin/sh\nsleep infinity"
}

$ terraform show

# iterative_task.succeeded:
resource "iterative_task" "succeeded" {
    ···
    status          = {
        "running"   = 0
        "succeeded" = 1
    }
}

# iterative_task.failed:
resource "iterative_task" "failed" {
    ···
    status          = {
        "failed"  = 1
        "running" = 0
    }
}

# iterative_task.running:
resource "iterative_task" "running" {
    ···
    status          = {
        "running" = 1
    }
}

@0x2b3bfa0 running == 1 is during the whole cycle? I mean... when it starts but not yet running the user's code is running==1?

Yes, running is about the machine, not about the task. We assume that a running machine will eventually run the user script.

Sounds good. A nitpick would be that I prefer one status vs a composed status... but both are equivalent to some extend

I prefer one status vs a composed status

How would that “one status” look like? Sounds interesting.

I prefer one status vs a composed status

How would that “one status” look like? Sounds interesting.

We have already design this previously. As stated in #319
running, terminated, failed and migrating... something like that we defined

opens #356
opens #357


Feature/model and import wb indicators dataset

Please run:
rails db:migrate
rails cait_indc:import
rails wb_indc:import

@edbrett @j8seangel could you please validate what I did from
5ac5a17 onwards? I want to make sure what I did in  5ac5a17 wont break anyone's environment.

Don't break anything, I've also tested the branch and seems to work well. Thanks!


Garmin - next alarm time shows Unknown

Hello. I remember that Garmin integration worked, then it was removed, then it was added again... However, I cannot get the entity "Next alarm time" to show anything. Other entities work fine, with delay of 2-5 hours. But no matter what, the "Next alarm time" still shows "unknown".

For me this works properly with v0.2.3, some things with timestamps was fixed in there.

I have updated to 0.2.5 and unfortunately Next alarm is still "Unknown". I see that values were updated 1 hour ago, which is asfter I have set the alarm.

I will add some debug log code later so we can see what is wrong, on which device did you program it and what kind of alarm? Daily weekly etc?

@jbrepogmailcom Can you update to version 0.2.6 and copy only the alarm part from the log file after enable debug and restarting:
logger:
  default: info
  logs:
    custom_components.garmin_connect: debug

Or just add last line if you already have logger config
Then just paste this part from log (or last json part you see in log, can be empty, first part is generic garmin data, then weight/body related data and then the alarm data)
2023-01-06 12:54:31.434 DEBUG (MainThread) [custom_components.garmin_connect] [{'alarmMode': 'OFF', 'alarmTime': 540, 'alarmDays': ['M', 'Tu', 'W', 'Th', 'F', 'Sa', 'Su'], 'alarmSound': 'TONE', 'alarmId':<PHONE_NUMBER>, 'changeState': 'UNCHANGED', 'backlight': None, 'enabled': None, 'alarmMessage': None, 'alarmImageId': None, 'alarmIcon': None, 'alarmType': None}, {'alarmMode': 'OFF', 'alarmTime': 1080, 'alarmDays': ['M', 'Tu', 'W', 'Th', 'F', 'Sa', 'Su'], 'alarmSound': 'TONE', 'alarmId':<PHONE_NUMBER>, 'changeState': 'UNCHANGED', 'backlight': None, 'enabled': None, 'alarmMessage': None, 'alarmImageId': None, 'alarmIcon': None, 'alarmType': None}, {'alarmMode': 'ON', 'alarmTime': 420, 'alarmDays': ['F'], 'alarmSound': 'TONE', 'alarmId':<PHONE_NUMBER>, 'changeState': 'UNCHANGED', 'backlight': None, 'enabled': None, 'alarmMessage': None, 'alarmImageId': None, 'alarmIcon': None, 'alarmType': None}]

Hello, updated and got this after restart. The alarm does not seem to be there at all, I have one activated on watch. The interesting point is "Attempting install of garminconnect==0.1.50" - I have checked in HACS and it reports version 0.2.6
2023-01-06 15:48:45.040 INFO (SyncWorker_2) [homeassistant.util.package] Attempting install of garminconnect==0.1.50
2023-01-06 15:49:16.436 INFO (MainThread) [homeassistant.setup] Setting up garmin_connect
2023-01-06 15:49:16.437 INFO (MainThread) [homeassistant.setup] Setup of domain garmin_connect took 0.0 seconds
2023-01-06 15:49:21.970 DEBUG (MainThread) [custom_components.garmin_connect] {'userProfileId': 90088900, 'totalKilocalories': 1428.0, 'activeKilocalories': 135.0, 'bmrKilocalories': 1293.0, 'wellnessKilocalories': 1428.0, 'burnedKilocalories': None, 'consumedKilocalories': 0.0, 'remainingKilocalories': 1428.0, 'totalSteps': 1287, 'netCalorieGoal': 2880, 'totalDistanceMeters': 1120, 'wellnessDistanceMeters': 1120, 'wellnessActiveKilocalories': 135.0, 'netRemainingKilocalories': 3015.0, 'userDailySummaryId': 90088900, 'calendarDate': '2023-01-06', 'rule': {'typeId': 4, 'typeKey': 'groups'}, 'uuid': '105760088ee74038949f8a06f12edcd6', 'dailyStepGoal': 2800, 'wellnessStartTimeGmt': '2023-01-05T23:00:00.0', 'wellnessStartTimeLocal': '2023-01-06T00:00:00.0', 'wellnessEndTimeGmt': '2023-01-06T13:15:00.0', 'wellnessEndTimeLocal': '2023-01-06T14:15:00.0', 'durationInMilliseconds': 51300000, 'wellnessDescription': None, 'highlyActiveSeconds': 197, 'activeSeconds': 2262, 'sedentarySeconds': 24841, 'sleepingSeconds': 24000, 'includesWellnessData': True, 'includesActivityData': True, 'includesCalorieConsumedData': True, 'privacyProtected': False, 'moderateIntensityMinutes': 7, 'vigorousIntensityMinutes': 2, 'floorsAscendedInMeters': 3.729, 'floorsDescendedInMeters': 4.909, 'floorsAscended': 1.22343, 'floorsDescended': 1.61056, 'intensityMinutesGoal': 150, 'userFloorsAscendedGoal': 10, 'minHeartRate': 43, 'maxHeartRate': 141, 'restingHeartRate': 44, 'lastSevenDaysAvgRestingHeartRate': 46, 'source': 'GARMIN', 'averageStressLevel': 19, 'maxStressLevel': 87, 'stressDuration': 10680, 'restStressDuration': 36540, 'activityStressDuration': 3960, 'uncategorizedStressDuration': None, 'totalStressDuration': 51180, 'lowStressDuration': 9060, 'mediumStressDuration': 1440, 'highStressDuration': 180, 'stressPercentage': 20.87, 'restStressPercentage': 71.4, 'activityStressPercentage': 7.74, 'uncategorizedStressPercentage': 0.0, 'lowStressPercentage': 17.7, 'mediumStressPercentage': 2.81, 'highStressPercentage': 0.35, 'stressQualifier': 'UNKNOWN', 'measurableAwakeDuration': 27120, 'measurableAsleepDuration': 24060, 'lastSyncTimestampGMT': '2023-01-06T13:16:25.124', 'minAvgHeartRate': 43, 'maxAvgHeartRate': 138, 'bodyBatteryChargedValue': 69, 'bodyBatteryDrainedValue': 34, 'bodyBatteryHighestValue': 98, 'bodyBatteryLowestValue': 29, 'bodyBatteryMostRecentValue': 64, 'bodyBatteryVersion': 2.0, 'abnormalHeartRateAlertsCount': None, 'averageSpo2': None, 'lowestSpo2': None, 'latestSpo2': None, 'latestSpo2ReadingTimeGmt': None, 'latestSpo2ReadingTimeLocal': None, 'averageMonitoringEnvironmentAltitude': 293.0, 'restingCaloriesFromActivity': 82.0, 'avgWakingRespirationValue': 13.0, 'highestRespirationValue': 20.0, 'lowestRespirationValue': 9.0, 'latestRespirationValue': 12.0, 'latestRespirationTimeGMT': '2023-01-06T12:20:00.0'}
2023-01-06 15:49:22.177 DEBUG (MainThread) [custom_components.garmin_connect] {'startDate': '2023-01-06', 'endDate': '2023-01-06', 'dateWeightList': [], 'totalAverage': {'from':<PHONE_NUMBER>000, 'until':<PHONE_NUMBER>999, 'weight': None, 'bmi': None, 'bodyFat': None, 'bodyWater': None, 'boneMass': None, 'muscleMass': None, 'physiqueRating': None, 'visceralFat': None, 'metabolicAge': None}}
2023-01-06 15:49:22.585 DEBUG (MainThread) [custom_components.garmin_connect] []
2023-01-06 15:49:22.586 DEBUG (MainThread) [custom_components.garmin_connect] Finished fetching garmin_connect data in 1.078 seconds (success: True)
2023-01-06 15:49:22.610 DEBUG (MainThread) [custom_components.garmin_connect.sensor] Registering entity: nextAlarm, Next Alarm Time, None, mdi:alarm, timestamp, True

Thanks, so yeah no alarm data at all, I removed the rest of the data for privacy. The garminconnect==0.1.50 is the python package library used by the home assistant integration which I also code and maintain, that update was also included, it needs a one time installation.
But I have no idea why you don't have alarm data on Garmin Connect server, did you ever choose to not sync it, if that is even possible?

I have no idea. I am a "developer" myself, but not familiar with Garmin API. If you point me how I can fetch data from API myself manually, I can do some debugging myself and try to find why alarm data is not included. Thanks for removing personal data

Here you can find the source code and example code for the garminconnect module.
https://github.com/cyberjunky/python-garminconnect
The APi is closed source, so all information is gathered by reverse engineering (mostly via the html and javascript of the garminconnect.com site using browser dev tools)
The alarm API call can be found here:
https://github.com/cyberjunky/python-garminconnect/blob/6b2131fed2596889c51649235d0c87bf7f387438/garminconnect/__init__.py#L628
First thing you can try is use the example.py program to get device information, this is where the alarms data come from.

I see some people have same issue with other watches and models
https://medium.com/@HighFlyinRunner/garmin-fenix-5-settings-alarm-disappearing-bug-4b321301dea4
https://forums.garmin.com/outdoor-recreation/outdoor-recreation/f/fenix-5-series/128034/alarm-setting-not-synced

Yes. Not a bug on your side, closing.


linux build fails because of template issue in third_party/webrtc/rtc_base/bitstream_reader.h

Describe the bug
Linux build fails with the following errors:
In file included from ../../third_party/webrtc/rtc_base/bitstream_reader.cc:11:
../../third_party/webrtc/rtc_base/bitstream_reader.h:70:13: error: explicit specialization in non-namespace scope 'class webrtc::BitstreamReader'
   70 |   template <>
      |             ^
../../third_party/webrtc/rtc_base/bitstream_reader.h:71:29: error: template-id 'Read<bool>' in declaration of primary template
   71 |   ABSL_MUST_USE_RESULT bool Read<bool>() {
      |                             ^~~~~~~~~~

To Reproduce
Steps to reproduce the behavior:

Download source files
Run build using the RPM SPEC file successfully used to build Ungoogled-chromium 94.xxxx
Build fails at [10335/49258]
See error

Expected behavior
Keep building
Screenshots
Full command line and related error:
[10335/49258] CXX obj/third_party/webrtc/rtc_base/bitstream_reader/bitstream_reader.o
FAILED: obj/third_party/webrtc/rtc_base/bitstream_reader/bitstream_reader.o
x86_64-mageia-linux-gnu-g++ -MMD -MF obj/third_party/webrtc/rtc_base/bitstream_reader/bitstream_reader.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DUSE_X11=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_ENABLE_PROTOBUF=1 -DRTC_ENABLE_VP9 -DWEBRTC_HAVE_SCTP -DENABLE_EXTERNAL_AUTH -DWEBRTC_USE_H264 -DHAVE_WEBRTC_VIDEO -DLOGGING_INSIDE_WEBRTC -DWEBRTC_LIBRARY_IMPL -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -I../.. -Igen -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/abseil-cpp -fno-ident -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Wall -Wno-unused-local-typedefs -Wno-deprecated-declarations -Wno-comments -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-unused-parameter -fno-omit-frame-pointer -fvisibility=hidden -std=gnu++14 -Wno-narrowing -Wno-class-memaccess -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -O2 -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables -faligned-new -Wno-attributes -Wno-ignored-attributes -Wno-error=class-memaccess -Wno-error=unknown-pragmas -Wno-error=array-bounds -Wno-return-type -Wno-error=nonnull -Wno-error=free-nonheap-object -Wno-error=unused -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=maybe-uninitialized -Wno-error=uninitialized -Wno-error=invalid-offsetof -Wno-error=stringop-overflow -std=gnu++17 -fpermissive -w -Wno-error=format-truncation -c ../../third_party/webrtc/rtc_base/bitstream_reader.cc -o obj/third_party/webrtc/rtc_base/bitstream_reader/bitstream_reader.o
In file included from ../../third_party/webrtc/rtc_base/bitstream_reader.cc:11:
../../third_party/webrtc/rtc_base/bitstream_reader.h:70:13: error: explicit specialization in non-namespace scope 'class webrtc::BitstreamReader'
   70 |   template <>
      |             ^
../../third_party/webrtc/rtc_base/bitstream_reader.h:71:29: error: template-id 'Read<bool>' in declaration of primary template
   71 |   ABSL_MUST_USE_RESULT bool Read<bool>() {
      |                             ^~~~~~~~~~

Environment (please complete the following information):

OS/Platform and version: Mageia 8 x64
ungoogled-chromium version: 95.0.4638.54
gcc version: output of gcc -v

Utilisation des specs internes.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-mageia-linux-gnu/10/lto-wrapper
Cible : x86_64-mageia-linux-gnu
Configuré avec: ../configure --prefix=/usr --libexecdir=/usr/lib --with-slibdir=/lib64 --with-pkgversion='Mageia 10.3.0-2.mga8' --with-bugurl=https://bugs.mageia.org/ --mandir=/usr/share/man --infodir=/usr/share/info --enable-checking=release --enable-languages=c,c++,ada,fortran,objc,obj-c++,d --enable-linker-build-id --build=x86_64-mageia-linux-gnu --host=x86_64-mageia-linux-gnu --with-cpu=generic --with-system-zlib --enable-threads=posix --with-linker-hash-style=gnu --enable-shared --enable-long-long --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --enable-ssp --disable-libssp --disable-libffi --disable-werror --with-isl --with-python-dir=/lib/python3.8/site-packages --enable-lto --with-gcc-major-version-only
Modèle de thread: posix
Algorithmes de compression LTO supportés: zlib zstd
gcc version 10.3.0 (Mageia 10.3.0-2.mga8)

Additional context
Hi
with the same spec file (beside patch adjustments to cope with code changes in version 95), I have successfully packaged 94.0.4606.81 and 94.0.4606.61
third_party/webrtc/rtc_base/bitstream_reader.cc seems a new addition with Chromium 95
My distribution has not packaged this 95 version yet. So, it might not be an ungoogled-chromium related issue.
However, before reporting a bug upstream to Chromium, I'd like to make sure it is unlikely related to ungoogled-chromium.
Plus, if you have some ideas how to solve this, it might save me some time ;)
Thanks!

Also had the problem with clang 13 when I was trying to get a build for v94 (-ffile-compilation-dir). Dunno if you are interested in building with clang, but Void fixed that by reversing this patch: use-ffile-compilation-dir.patch.
Void uses clang 12 but that should work for clang 11 also.
Sorry I can't be more helpful, but I don't follow chromium development that closely and I rely on Void's patches to build UC :/.

Hi @DAINRA
You helped a lot already as it is exactly the issue I get. I don’t know anything about Void. I’ll investigate it.
@wchen342 sysroot cannot still be used as adding build/linux/sysroot_scripts/install-sysroot.py --arch=amd64  leads to start downloading from a non existing web page. I will dig into your insights about depot_tools

I will suggest you clone https://github.com/wchen342/ungoogled-chromium-building-scripts and run
./build.py init --shallow
./build.py sync --shallow --os linux
./build.py prepare --os linux
./build.py build -a x64 --os linux

It is designed exactly for this kind of scenario.

Hi @wchen342
In fact, I have been following the path you opened. I mean getting depo_tools and chromium source using hooks.
What I just did:
git clone https://github.com/Eloston/ungoogled-chromium.git
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
export PATH="$PATH:`pwd`/depot_tools"
mkdir -p ./chromium && cd ./chromium
fetch --nohooks --no-history chromium
gclient runhooks

It looks like it ran well.
Then, I did:
cd src
python3 -B path_to_unggoogled-chromium/utils/prune_binaries.py . \
  path_to_unggoogled-chromium/pruning.list

and it get this error message: ERROR: 4631 files could not be pruned.
I have been searching around for an explanation but without success.
Might it be a version mismatch between Chromium and Ungoogled-chromium?
I have been trying to force a version for Chromium but without success. I supposed by doing as above, I would get the latest and similar versions. But maybe not...
Any idea on what am I doing wrong??

The prune error is normal. I have never seen this message gone, it has always been happening. I think it has something to do with different check-outs.

Hum. I don’t get it when I do the pruning on the Chromium tarball source.
I get this error when I get Chromium through depot_tools (fetch and gclient).

I think the tarball has more extra files than the source tree. You can change L63 in utils/_common.py to def get_logger(initial_level=logging.DEBUG): to see which files are not pruned.
If those files doesn't exist then it shall be fine.

@PF4Public @Ahrotahn Maybe we need two prune lists? I have noticed this for some time too since I almost always use source checkout instead of the google tarball and I always got this error.

Maybe we need two prune lists? I have noticed this for some time too since I almost always use source checkout instead of the google tarball and I always got this error.

I suppose, the error comes from here:
https://github.com/Eloston/ungoogled-chromium/blob/c8011bab148961a16e7d89f68fb536cf57b4459b/utils/prune_binaries.py#L35-L37
Is it an error though? May we consider non-existing file as an already pruned file and merely print a warning about that?

I think having two lists would require a little too much maintenance work.  One would need to download both sources every update and update four sets of lists along with that since the domain substitution list would need to be included as well.  Not to mention that the update scripts would need new options to signify which source set is being used since the checkout doesn't contain *.hh or *.gyp* files.
The easiest solution might be to include a line in your script that runs the update_lists.py before doing the pruning and substitution.
Is there a reason you prefer the source checkout over the tarball?  The vast majority of chromium builds use the tarball since it also contains release files like the pgo profiles and extra third-party code.
@PF4Public It does seem a little silly to throw an error for files that don't exist, but I guess the intent is to alert the user that something has changed and requires a look into without letting them ignore the warnings and continue with a possibly compromised build.

Hi. Great to have you on board as I have been pulling too many hairs compared to the one remaining :)
@Ahrotahn I am getting the source checkout because I need to get the clang package provided by sysroot. It looks like clang comes with the hooks. Is there a way to get it with the tarball instead ?
However, for some reasons, the git checkout doesn't give me exactly the same files as in the tarball, for the same given Chromium version, of course (or I have made a mistake with my checkout... but gitk seems to tell me I have got the right version).
Now, the git checkout, still, miss an important folder compared to the tarball which is tools/gn/build
Hence, my build fails on tools/gn/build/gen.py': [Errno 2] No such file or directory
Reading the README.md in tools/gn, I run python tools/gn/roll_gn.py
But it seems deprecated as I get
GN is autorolled by https://autoroll.skia.org/r/gn-chromium-autoroll
See also https://groups.google.com/a/chromium.org/g/build/c/2VH7DqyaVD0

Dead end again.
@wchen342 I cannot use your scripts as such, as I want to create a rpm package and not just build and run ungoogled chromium. I want also to apply the patches coming with my distro.
I went through your patch and tried to get the source using, like you, git clone instead of fetch. But it doesn't help as I still don't get the gn/build folder...
Actually, chromium doc alerts on the fact to use fetch and not git clone, but I have not seen any explanation why.

I guess the intent is to alert the user that something has changed

I do agree, but this holds true only if everyone uses tarballs, which turns to be a false assumption! That's why I suggested to make it non-fatal. Come to think of it, alternatively we may add a commandline key, say --not-a-tarball, which demotes this error into warning.
@squid-f I'm really sorry for us hijacking your issue.

Actually, chromium doc alerts on the fact to use fetch and not git clone, but I have not seen any explanation why.

That is exactly your problem. Chromium comprises miriad of projects, every one of them needs to be checked out, that's wat fetch does!

@squid-f I'm really sorry for us hijacking your issue.

No worries @PF4Public    I am the one entertaining you with my lack of knowledge !

Actually, chromium doc alerts on the fact to use fetch and not git clone, but I have not seen any explanation why.

That is exactly your problem. Chromium comprises miriad of projects, every one of them needs to be checked out, that's what fetch does!

In fact, I do use fetch to check out the source. But I still don't get tools/gn/build folder and its configuration file. It is what does still block me after having passed all the other hurdles...

There are two different ways of getting gn. If you are using tarball it is generated by running bootstrap.py but if you use source checkout then you need to run the one under depot_tools.
@Ahrotahn There are multiple reasons one needs to use source checkout. For example, for Android and Windows tarball doesn't work because they need files not existing in it. Also if you want to develop on top of chromium source tarball is not very convenient too.

There are two different ways of getting gn. If you are using tarball it is generated by running bootstrap.py but if you use source checkout then you need to run the one under depot_tools.

Sorry @wchen342 for my ignorance here. Could you be a bit more precise? There is no tools/gn folder coming with depot_tools.
Should I run bootstrap_python3 from the depot_tools folder?

No, you use the gn file under depot_tools you get in the very beginning where you also has gclient.

No, you use the gn file under depot_tools you get in the very beginning where you also has gclient.

So, I run the gn script included in depot_tools after fetching chromium. Is it what you mean?

I think it will be easier if you can show the spec file. Basically in tarball, gn doesn't come with it so you need to run that gen.py script. But in the case of source checkout, gn comes bundled with depot_tools so where ever you call gn like gn gen something, you now use the gn in depot_tools directly.

@wchen342 The spec is big. I put it in a termbin but I can paste it here if you prefer: https://termbin.com/gud8
The thing is that the command python tools/gn/bootstrap/bootstrap.py --skip-generate-buildfiles '--gn-gen-args=use_sysroot=true .... looks for tools/gn/build/gen.py
I don't get this gen.py by fetching chromium. I don't get it either by cloning depot_tools. Hence, why I am lost.

@wchen342 complement: to get chromium, I run this script:
version=$(rpm -q --specfile --qf='%{version}\n' webylib.spec | head -n1)
echo "get depot_tools"
rm -rf depot_tools
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
export PATH="$PATH:`pwd`/depot_tools"
export DEPOT_TOOLS_UPDATE=0
echo "fetch chromium"
mkdir -p ./chromium && cd ./chromium
fetch chromium
cd src
echo "Available tags"
git tag
echo "git checkout of .spec version"
git checkout $version

Sorry some of the details slipped my mind since I am used to modify chromium sources. So what you need to do is:

Delete the line

python2 tools/gn/bootstrap/bootstrap.py  --skip-generate-buildfiles --gn-gen-args='%{gn_config}'

Delete

buildtools/linux64/gn

from ungoogled-chromium/pruning.list

Change

out/Release/gn gen --args='%{gn_config}' out/Release

to
third_party/depot_tools/gn gen --args='%{gn_config}' out/Release
```.

Hi all.
Here are some news on my endeavor :)
I'd like to thank you a lot, @wchen342
You have helped me a lot and I have learned a lot as well.!
However, going through sysroot and getting the source from git, left me with a source folder of about 50Go.
I might have not done it in the best way possible, though?
Anyway, this size of the source is not suitable to be used to build a package using my BS. I basically spend a lot of time to shuffle the source files around, before even starting to compile.
So, I spent some time to explore the option proposed by @DAINRA
I have got also some inspiration from openSUSE community package to find the proper patches to be able to package Chromium using clang11 instead of clang13.
I don't think the spec of my distro was fully ready to build with clang and I had to tweak more things.
Long story short, I am now able to package Chromium 95 using the tarball source. I have then also packaged ungoogled-chromium on the top of it for Mageia. I have called this package WebyLib. Hope it is not an issue; I have contacted Eloston about this name, but I have never got any reply. Not sure my email has reached him.
Thanks all for your awesome support! :)


Use compact token to communicate the public key

When servers use PKI for token exchange, the public key of the server was communicated over a certificate. However, certificates tend to be big and they eat a lot of resources. In the Trireme case we don't negotiate ciphers or require all the details of the certificates. With this PR we introduce a simpler mechanism where we just communicate over the wire the EC public keys signed by the
CA without all the overheads.

Codecov Report

Merging #237 into master will increase coverage by 0.74%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   54.71%   55.46%   +0.74%
==========================================
  Files          34       36       +2
  Lines        3867     3968     +101
==========================================
+ Hits         2116     2201      +85
- Misses       1569     1584      +15
- Partials      182      183       +1

Impacted Files
Coverage Δ

cmd/remoteenforcer/remoteenforcer_linux.go
0% <0%> (ø)
:arrow_up:

enforcer/utils/tokens/jwt.go
88.7% <100%> (ø)
:arrow_up:

crypto/crypto.go
58.9% <100%> (+3.02%)
:arrow_up:

enforcer/utils/tokens/compactpki.go
90.24% <90.24%> (ø)

enforcer/utils/pkiverifier/pkiverifier.go
94.87% <94.87%> (ø)

processmon/processmon.go
71.81% <0%> (+1.34%)
:arrow_up:

monitor/linuxmonitor/linuxMonitor.go
72.54% <0%> (+3.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0e3672...5b71dda. Read the comment docs.

LGTM


BUG Report on pytorch

See https://github.com/pytorch/pytorch/issues/30651
icefall/icefall/utils.py:41 from torch.utils.tensorboard import SummaryWriter
SummaryWriter may cause errors
SummaryWriter should be add at the very first!!!
Also for?
icefall/transformer_lm/train.py
icefall/rnn_lm/train.py

Could you have a look at #674 for a fix?
Thanks for sharing the link.

Good, THX.
Anyway, I suggest the title of #674 should be changed such as "torch tensorboard SummaryWriter caught Segmentation fault".
Close this issue.


Recommended changes from testing.

Changes proposed in this pull request:

Mainly formatting and changing 'click' to select, per Style Change changes.

@chandlersyal FYI


Simple sample

Overview/summary

Can you improve your documentation? Most people don't care about all the options and API if they cannot simply authenticate successfully. Can you add a code sample E2E do to exactly that?
Currently you have this, which is trying to help but it doesn't. You still need something else to know if your creds work
import '@shopify/shopify-api/adapters/node';
import {shopifyApi, LATEST_API_VERSION} from '@shopify/shopify-api';
import express from 'express';

const shopify = shopifyApi({
  // The next 4 values are typically read from environment variables for added security
  apiKey: 'APIKeyFromPartnersDashboard',
  apiSecretKey: 'APISecretFromPartnersDashboard',
  scopes: ['read_products'],
  hostName: 'ngrok-tunnel-address',
  ...
});

const app = express();

🙏

Hi there 👋
Thank you for your feedback!
A couple of questions for you to help us best figure out our short comings, and how I can best direct you to the appropriate  place for next steps!

What libraries are you currently trying to use? (It looks like just shopify-api? Not shopify-app-express or shopify-app-remix?)
How did you discover this package? Google search? Or did you come from documentation from Shopify.dev? (This info can help us optimize the wayfinding of our documentation.)

If you are just getting started with Shopify App Development I would recommend starting out with the Create an app and Build a Shopify app using Remix tutorials. This is our recommended stack for building apps, and has the most documentation.
If you don't want to use Remix, we do have further example code for express. I believe this example of using the shopify-app-express library could be what you are looking for.


Azure SQL Hybrid Cloud Toolkit Notebooks Extension Command

This PR adds a palette command for the Azure SQL Hybrid Cloud Toolkit Notebook that opens the Hybrid Cloud Toolkit notebooks directly into the notebooks side tab (via the existing Notebook extension)
To use the command: go to the command palette and select "Open Azure SQL Hybrid Cloud Toolkit notebook" to open the books on the notebook side tab.

Pull Request Test Coverage Report for Build 350107841

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 40.224%

Totals

Change from base Build 350099650:
-0.001%

Covered Lines:
21097

Relevant Lines:
48208

💛  - Coveralls

@chlafreniere @barbaravaldez Do we have any sort of general plan for contributed notebooks? This seems like something that falls in line with the BDC TSGs and so I'm wondering if this should really be living in the TigerTools repo instead of being embedded in the extension like this?
Yes, I think these notebooks could be in the tigertool repo, as well. It also depends how they want to access their tsgs and if having them available in offline scenarios is a priority for them.

I added the command to open the notebook in the provided notebooks view of the notebook extension since it will only show up there, this will add a "Jupityr Books" Command to open the Azure Cloud Hybrid Toolkit Book, this command can be removed, but its kept to be consistent with the sqlserver2019 book.

@smartguest I just noticed you didn't add this to the list of external extensions : https://github.com/microsoft/azuredatastudio/blob/main/build/lib/extensions.ts#L239 which means this is going to be packaged into the main product. Was that intended? If so - did you make sure to check with the PMs that increasing the size of the base install like this is OK?

@Charles-Gagnon nice catch, no this should not be a built-in extension (yet 😄).  @smartguest  could you please send a follow-up PR to fix this bug?


update bcgov filepicker component

Update the filepicker story in storybook to list all of its props, and document it's use cases and value. Use the filepicker to check for any bugs that may exist

[x] Storybook documentation
[x] Bugs check

This may be dumb, so disregard if all is well here.
Is it normal to not have the hand icon as the cursor when hovering over the file picker?

No that's a good catch, can definitely change the cursor. Would you be okay with noting these on issue #188, I don't think we have to make an issue for each fix but it'll be easy to grab them all from one spot


Move ls-arm/ls-x86 to jni

To make this app work in android 10 too

They should be run as super user permission. Therefore, that ls-arm or ls-x86 is run means that the app has the root permission. Use chmod to make them executable in android 10.

https://github.com/KYHSGeekCode/Android-Disassembler/blob/c01461194e75e0ead2b417c0fd354a81a354538f/app/src/main/java/com/kyhsgeekcode/rootpicker/FileSelectorActivity.java#L99


problem when using jest to test this package

we are using jest and @testing-library/react-native to test our react-native app
we just upgraded from react-navigation v3 to react-navigation v4, and started using react-navigation-stack directly.
we have a monorepo setup
the error we have is:
 Cannot find module 'react-nativation-stack' from 'testUtils.tsx'

You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'json', 'jsx', 'ts', 'tsx', 'node'].

    See https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

      2 | import { render as testingRender } from '@testing-library/react-native';
      3 | import { createAppContainer } from 'react-navigation';
    > 4 | import { createStackNavigator } from 'react-nativation-stack';

this is our jest.config.js config:
const pkg = require('./package');

module.exports = {
  name: pkg.name,
  displayName: pkg.name,
  preset: '@testing-library/react-native',
  transformIgnorePatterns: [
    'node_modules/(?!react-native|static-container|@react-navigation|react-navigation|@react-native-community|redux-persist|tcomb-form-native|victory-.*|@ptomasroos/react-native-multi-slider|rn-tooltip|react-navigation-drawer)',
  ],
  moduleNameMapper: {
    'styled-components': '<rootDir>/../../node_modules/styled-components/native/dist/styled-components.native.cjs.js',
    '\\.(jpg|ico|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': '<rootDir>/__mocks__/fileMock.js',
  },
  setupFiles: [
    '<rootDir>/test/jest.setup.js',
    '<rootDir>/../../node_modules/react-native-gesture-handler/jestSetup.js',
  ],
  testPathIgnorePatterns: ['/node_modules/', './dist', './scripts', '__generated__'],
  reporters: ['default', 'jest-junit'],
};

we are using react-navigation-stack: 1.7.3
is it safe to upgrade to latest v2?, what are the breaking changes?
everything works well when running code

typo
- react-nativation-stack
+react-navigation-stack


[tree_sitter_v] Fix comment and string and clean

Windows fail unrelated to the v-analyzer but the the v install command on windows, I'll look into it 👍


Configure does not work

This gem could save me a lot of times in upgrading from rails 4 to rail 5.  I am using protectect_attributes but this is no longer supported in rail 4. I would like to use my feature spec tests to discover all the strong parameters declarations.  I have tried the following
ActiveParams.config do |config|
  config.writing = Rails.env.test?
end

but I get the following error
/config/initializers/active_params.rb:1:in <top (required)>': undefined method config' for ActiveParams:Module (NoMethodError)
I have temporarily worked around this by cloning the gem and changing line 33 or lib/active_params.rb.
If there is not a simple fix, would you like me to have to have a go at a pull request with a fix?

It's because I didn't push the latest code (as per README) to rubygems as v1.0.0. Please bundle update active_params, see that it upgrades to 1.0.0 and try again? 🙏

I have done as you suggested, and it works now.
Thank you.


Set TrustServerCertificate=True for entire application?

Instead of setting TrustServerCertificate=true on every connectionstring, is it possible to set it for the entire application?
I was hoping for some kinda ... "Microsoft.Data.SqlClient.TrustServerCertificate = True".
Thanks.

You could do it in a single lokation in your data access layer.

You could do it in a single lokation in your data access layer.

Yes, but we have like 40 applications developed over a periode of 20 years and some are not well structed (our mess), so we have many places to change the connectionstring, Would be easier to set it application wide on start up.

@MojoDK, that needs a bit more of investigation to understand pros and cons of the approach, however you can provide your connection string in an appsetting.json file and have a configuration manager to read from that location all over the application.

@MojoDK this is not something we could do. Driver is not responsible to make this kind of decisions for users. Users need to understand and make that decision deliberately. I am closing this as there is no future plan to add this. As suggested before you can centralize your connection strings in data access layer and manage it from there.


checking how much distance traveled since first check for detecting traffic jam

it's perfect option for checking if second GPS check has sense

check at very beginning if user moved  and if not then dont check. maybe increase delay between to better checking


Change version to 5.4.3-SNAPSHOT

Motivation:
Change version to 5.4.3-SNAPSHOT.

Codecov Report

Merging #212 into 5.4 will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                5.4     #212      +/-   ##
============================================
- Coverage     71.32%   71.25%   -0.08%
+ Complexity      959      957       -2
============================================
  Files           341      341
  Lines         14213    14213
  Branches       2286     2286
============================================
- Hits          10137    10127      -10
- Misses         2881     2892      +11
+ Partials       1195     1194       -1

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com/alipay/sofa/rpc/common/Version.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...m/alipay/sofa/rpc/module/FaultToleranceModule.java
66.66% <0%> (-26.67%)
4% <0%> (-1%)

...pay/sofa/rpc/transport/ClientTransportFactory.java
73.84% <0%> (-4.62%)
0% <0%> (ø)

...ent/aft/impl/ServiceHorizontalMeasureStrategy.java
84.44% <0%> (-2.23%)
26% <0%> (-1%)

...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java
59.37% <0%> (-0.79%)
0% <0%> (ø)

...ay/sofa/rpc/client/AllConnectConnectionHolder.java
62.84% <0%> (-0.28%)
0% <0%> (ø)

.../alipay/sofa/rpc/registry/local/LocalRegistry.java
57.83% <0%> (+0.6%)
26% <0%> (+1%)
:arrow_up:

...ava/com/alipay/sofa/rpc/config/RegistryConfig.java
90.19% <0%> (+0.98%)
0% <0%> (ø)
:arrow_down:

.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java
88.7% <0%> (+1.61%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7017d1...eb74a01. Read the comment docs.


update nowcastin_dataset, and nowcasting_datamodel

Pull Request
Description
Update nowcasting dataset and datamodel\
How Has This Been Tested?
normal unittest

[x] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

@jacobbieker I imagine you did some similar fixes for upgrading the dataset and datamodel version. This now seems to get the tests passing. So we could merge this to main, then you pull as you want into your branch

@jacobbieker I imagine you did some similar fixes for upgrading the dataset and datamodel version. This now seems to get the tests passing. So we could merge this to main, then you pull as you want into your branch

Yeah, sounds good!


How to use the absolute path of the data for training

I want to use the absolute path of my data for training, but when I do this, the following error will occur, how to solve it?
0%|                                                                                | 0/1 [00:03<?, ?it/s]
Traceback (most recent call last):
  File "XXX/anaconda3/envs/valle/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "XXX/anaconda3/envs/valle/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "XXX/project/2023/230118-valle/vall_e/train.py", line 128, in <module>
    main()
  File "XXX/project/2023/230118-valle/vall_e/train.py", line 119, in main
    trainer.train(
  File "XXX/project/2023/230118-valle/vall_e/utils/trainer.py", line 205, in train
    eval_fn(engines=engines)
  File "XXX/project/2023/230118-valle/vall_e/utils/distributed.py", line 69, in wrapped
    return fn(*args, **kwargs)
  File "XXX/project/2023/230118-valle/vall_e/train.py", line 116, in eval_fn
    run_eval(engines, "subtrain", subtrain_dl)
  File "XXX/anaconda3/envs/valle/lib/python3.10/site-packages/torch-1.13.1-py3.10-linux-x86_64.egg/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "XXX/project/2023/230118-valle/vall_e/train.py", line 97, in run_eval
    relpath = path.relative_to(cfg.data_root)
  File "XXX/anaconda3/envs/valle/lib/python3.10/pathlib.py", line 818, in relative_to
    raise ValueError("{!r} is not in the subpath of {!r}"
ValueError: '/data/public/libriTTS/LibriTTS/train-clean-100/103/1241/103_1241_000000_000001.qnt.pt' is not in the subpath of 'data' OR one path is relative and the other is absolute.

Try to add
data_root: /data/public/libriTTS/

In your configuration.

Try to add
data_root: /data/public/libriTTS/

In your configuration.

Thanks for your reply! Now I changed the configuration to this:
data_root: /data/public/libriTTS/
data_dirs: [/data/public/libriTTS/LibriTTS]

And it seemes to run well, is it correct to write this way, both of them use absolute addresses?


Add "main" section into package.json

I've tried to use shower with webpack module builder and it can't import modules without main section in package.json

Thank you!