Media Browser does not filter by the selected Feeder

In the Media Browser, we drill down into:
\- Browser
  \- Bird Buddy
    |- $Account
      |- $FeederName
        |- $BirdSpecies
        |  |- $Image
        |  \- $Image
        \- $Species
           \- $Image
      \- $FeederName
         ...
    \- $Account
       ...
      \- $FeederName
         ...

It's debatable whether we should have this level of granularity in the first place. Especially because collections are tied to an account, with just a soft reference to the feeder (by name, not by id) that generated that image.
To better mirror how the Bird Buddy app itself works, the media browser would probably be better off organized in a similar way:
\- Browser
  \- Bird Buddy
    \- $Account
      |- $BirdSpecies
      |  |- $Image
      |  \- $Image
      |- $BirdSpecies
         ...

If we do that, then we can remove one level from the media browser, and remove the confusion of clicking 2 separate Feeder names, but seeing the same media in both.
To keep the structure as it is now, we would have to filter the media collections by feederName (similar to #31)

Decided to go with the Feeder-less media directory in #38


[ru] Localize Datacenter in Russian

Describe your changes
Localize Datacenter in russian
Related issue number or link (ex: resolves #issue-number)
https://github.com/cncf/glossary/issues/3048
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@shurup, I complete all your changes requests.
Check, please.

Thanks for the PR!
Here are a few suggestions from me.

@FightingFox thanks for the great job! The pull request has been merged. 🚀


Checkbox - Missing properties

Summary
Add appearance prop to checkbox component.
💬 Description
Add appearance property including options for 'Default', 'Light' and 'Dark'.
Check component to confirm which prop options are required.
💰 User value
Provides consistent functionality across all ICDS components.
📚 User Stories
If relevant, describe the high-level functionality as user stories.
As an ICDS user:
I need
So that
📝 Acceptance Criteria
If relevant, describe in full detail the different interactions and edge cases that the component or patterns needs to fulfil.
Given
When
Then
✏ Designs
If there's a Figma design file (or other mock-up), include it here.
## 🧾 Guidance
If there's written guidance or documentation, include a link to it here.
Additional info
Tell us anything else useful to help us understand your suggestion.

No designs for this variant yet, or acceptance criteria, so is blocked until this is defined


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Bloxstrap.Exceptions.HttpResponseException: Could not connect to https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer/channel/zlive because it returned HTTP 401 (Unauthorized)

https://github.com/pizzaboxer/bloxstrap/wiki/'HTTP-401-(Unauthorized)'-when-trying-to-launch-Roblox


Commented method restrainTZoffset

I think, method restrainTZoffset should be removed for I didn't find any restrictions on time zone offset. Also it is the problem that demonstrates itself in issue https://github.com/veraPDF/veraPDF-library/issues/547.

Fixes veraPDF/veraPDF-library#547


Cow: Watch (?-i:cyberphantom432)

Cow requests the watch of the watch_keyword (?-i:cyberphantom432). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:cyberphantom432) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Lockfile Poisoning Analyser Bug in Path Handling

There is a case where strip-ansi-cjs resolves to https://registry.npmjs.org/strip-ansi/-/strip-ansi-6.0.1.tgz. This is a potential Lockfile Poisoning attempt because the package name does not match the conventional URL for the artifact. We need to do the following

Review npm specification on various conventions for URLs
Update --trusted-registries option handling to handle such conventions

Currently vet throws error
** Package `strip-ansi-cjs` resolved to an URL `https://registry.npmjs.org/strip-ansi/-/strip-ansi-6.0.1.tgz` that does
not follow the package name path convention
** Package `wrap-ansi-cjs` resolved to an URL `https://registry.npmjs.org/wrap-ansi/-/wrap-ansi-7.0.0.tgz` that does not
follow the package name path convention
** Package `string-width-cjs` resolved to an URL `https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz` that
does not follow the package name path convention

@insaaniManav This test case can reproduce the bug
diff --git a/pkg/analyzer/lfp_npm_test.go b/pkg/analyzer/lfp_npm_test.go
index d5cee31..1969ef9 100644
--- a/pkg/analyzer/lfp_npm_test.go
+++ b/pkg/analyzer/lfp_npm_test.go
@@ -160,6 +160,13 @@ func TestNpmIsUrlFollowsPathConvention(t *testing.T) {
                        []string{"https://registry.npmjs.org/base", "https://registry.npmjs.org/base1"},
                        true,
                },
+               {
+                       "strip_ansi_cjs package path matches trusted url path",
+                       "https://registry.npmjs.org/strip-ansi/-/strip-ansi-6.0.1.tgz",
+                       "strip-ansi-cjs",
+                       []string{"https://registry.npmjs.org/strip-ansi"},
+                       true,
+               },
        }

        for _, test := range cases {


Allow headless option when initializing controller

Simple change: allow headless option by making it an optional argument to the Controller class. Headless option is already implemented in the Browser class, so all we have to do is pass that down.

Great idea - does it work like expected for you?

Great idea - does it work like expected for you?
yes!


Include demo.ipynb as part of the docs

@angus-g can you help me doing that? if you make a PR that just includes one of the notebooks as a docs page I can take it on from there. Don't bother about the content. I mostly need help with any extra dependencies the docs might need etc..

Yeah, I can do that.

Btw, the link to the notebook in the README is broken. But let's not bother fixing it, let's deal with this and then we can have the README pointing to the docs ;)


Fixes #63: Implement Customizable Model Selection

This PR implements flexible model selection system, allowing users to switch between OpenAI and Anthropic models while maintaining a consistent user experience.

Key technical aspects:

Model Selection Pattern: New abstraction layer in lib.ts that provides uniform interface for different AI models
Type-Safe Integration: Strict typing for model names and configurations using TypeScript literal types
Stateful Model Management: Thread-level model persistence with automatic state handling
Seamless UX: ChatGPT-style model switching with automatic thread management

https://github.com/user-attachments/assets/5d7653f3-e0ff-462b-a914-24bcd0f54329
Changes Made
New Files

src/agent/lib.ts - Core model abstraction and selection implementation

Modified Files
Core Changes

src/open-canvas/index.ts, src/agent/open-canvas/state.ts

Added model state management and type definitions

Updated model implementation across agent nodes in src/agent/open-canvas/nodes/*

Refactored chat model initialization using new pattern

UI/UX Updates

New ModelSelector.tsx component
Updated hooks (useGraph.tsx, useThread.tsx) with model state support
Updated canvas and primitives components for model integration

Testing
Tested with:

Anthropic API integration
OpenAI API integration
Verified model switching functionality
Thread preservation and recreation

Please let me know if any changes or additional information is needed.
Fixes #63

Thank you @bracesproul for the detailed review! I appreciate the clear guidance. I’ll revise the PR to:

Utilize the existing initChatModel class from Langchain
Add support for the specified models
Move model selection to configurable fields instead of state
Keep the original models for tool-calling nodes

No worries about the spec; I’m excited to implement these changes and will push the updates soon. Thanks again!

Great! Very excited to review again once ready. Please just dismiss my change request review & re-request. Thanks!

Hi @bracesproul! I’ve created a new PR (#136 ) for the requested changes to avoid conflicts with the main branch, as the main branch had substantial updates that would make merging challenging. All changes and improvements are now reflected there. Closing this PR to keep everything organized. Thank you for the guidance!


The transition from exclusive state to shared state must be accompanied by copying of actual state values.

https://github.com/microsoft/D3D12TranslationLayer/blob/4a4b40d9c91a9ac8ef728a6e1254c896895c2d43/src/ResourceState.cpp#L105
Most of the time, resources are exclusive and they make the transition on first use to another queue, tipically during PostSubmitUpdateState() -> SetSharedResourceState(). Does I undertand right that we have to copy actual exclusive state to shared in order to be sure that next transition as shared resource will be with correct state "before" ?

Shared resource states are only used on resources that are "simultaneous access." For these resources, states "decay" to COMMON at the end of every ExecuteCommandLists group. A shared state means that no barriers have actually been issued, but the resource has been read from in a "promotable" way. So, no, I don't think anything is missing here.


Include all boards in compact stats

Not sure why the compact stats ignore small boards -- this goes back to the initial commit in 51c291abe65ae2239468b6eb4afa60977d8ac846 -- but they seem relevant to me. Extracted from #46.

@anoek, can you think of a good reason to exclude them?

Mighta just been looking at those stats in particular for rank tuning last time or something, no particular reason to exclude them in general though I don't think


Employees and worker safety

Perform the following tasks for the Employees and worker safety page:

[ ] Review for content design principles
[ ] Get final accuracy approval from Christina/Alex
[ ] Airtable fields confirmed
Title
Slug
Menu
Page description (short text that appears in bookmarks and social media page shares)
Body content

We are no longer going to do this work. Closing this issue.


Force commons-cli lib version

This PR is a part of https://github.com/SpineEventEngine/web/pull/125.
It adds commons-cli:commons-cli to the forced dependencies.
This became necessary after updating to a new Gretty version in spine-web.

@dmdashenkov PTAL.


HBASE-22880 Move the DirScanPool out and do not use static field

HBASE-22880

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
101
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
521
branch-1 passed

+1
compile
50
branch-1 passed

+1
checkstyle
116
branch-1 passed

-1
shadedjars
17
branch has 10 errors when building our shaded downstream artifacts.

+1
javadoc
43
branch-1 passed

0
spotbugs
165
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
162
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
136
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

-1
checkstyle
117
hbase-server: The patch generated 69 new + 255 unchanged - 5 fixed = 324 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedjars
16
patch has 10 errors when building our shaded downstream artifacts.

+1
hadoopcheck
337
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
33
the patch passed

+1
findbugs
150
the patch passed

_ Other Tests _

+1
unit
8845
hbase-server in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

10908

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 741633d74559 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.8.0_222

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/branch-shadedjars.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/diff-checkstyle-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/artifact/out/patch-shadedjars.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/testReport/

Max. process+thread count
4037 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
484
branch-1 passed

+1
compile
40
branch-1 passed

+1
checkstyle
106
branch-1 passed

-1
shadedjars
15
branch has 10 errors when building our shaded downstream artifacts.

+1
javadoc
42
branch-1 passed

0
spotbugs
162
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
161
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
136
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

-1
checkstyle
131
hbase-server: The patch generated 6 new + 255 unchanged - 5 fixed = 261 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedjars
14
patch has 10 errors when building our shaded downstream artifacts.

+1
hadoopcheck
334
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
38
the patch passed

+1
findbugs
156
the patch passed

_ Other Tests _

-1
unit
7186
hbase-server in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

9184

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestHBaseFsck

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ccc7c708ba95 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.8.0_222

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/artifact/out/branch-shadedjars.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/artifact/out/diff-checkstyle-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/artifact/out/patch-shadedjars.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/testReport/

Max. process+thread count
4172 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
43
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
480
branch-1 passed

+1
compile
42
branch-1 passed

+1
checkstyle
107
branch-1 passed

-1
shadedjars
13
branch has 10 errors when building our shaded downstream artifacts.

+1
javadoc
39
branch-1 passed

0
spotbugs
157
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
155
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
114
the patch passed

+1
compile
44
the patch passed

+1
javac
44
the patch passed

-1
checkstyle
103
hbase-server: The patch generated 3 new + 255 unchanged - 5 fixed = 258 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

-1
shadedjars
12
patch has 10 errors when building our shaded downstream artifacts.

+1
hadoopcheck
298
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
31
the patch passed

+1
findbugs
155
the patch passed

_ Other Tests _

-1
unit
1656
hbase-server in the patch failed.

+1
asflicense
20
The patch does not generate ASF License warnings.

3526

Reason
Tests

Failed junit tests
hadoop.hbase.executor.TestExecutorService

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 238bebb260c8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.8.0_222

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/artifact/out/branch-shadedjars.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/artifact/out/diff-checkstyle-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/artifact/out/patch-shadedjars.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/testReport/

Max. process+thread count
734 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/5/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
105
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
508
branch-1 passed

+1
compile
42
branch-1 passed with JDK v1.8.0_222

+1
compile
44
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
94
branch-1 passed

+1
shadedjars
183
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
36
branch-1 passed with JDK v1.8.0_222

+1
javadoc
41
branch-1 passed with JDK v1.7.0_232

0
spotbugs
178
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
171
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
118
the patch passed

+1
compile
40
the patch passed with JDK v1.8.0_222

+1
javac
40
the patch passed

+1
compile
44
the patch passed with JDK v1.7.0_232

+1
javac
44
the patch passed

-1
checkstyle
94
hbase-server: The patch generated 5 new + 255 unchanged - 5 fixed = 260 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
167
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
292
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
29
the patch passed with JDK v1.8.0_222

+1
javadoc
38
the patch passed with JDK v1.7.0_232

+1
findbugs
167
the patch passed

_ Other Tests _

-1
unit
11052
hbase-server in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

13526

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAdmin2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux fb7e0cfeacd1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/testReport/

Max. process+thread count
5189 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
51
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
512
branch-1 passed

+1
compile
39
branch-1 passed with JDK v1.8.0_222

+1
compile
43
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
91
branch-1 passed

+1
shadedjars
172
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
branch-1 passed with JDK v1.8.0_222

+1
javadoc
37
branch-1 passed with JDK v1.7.0_232

0
spotbugs
172
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
169
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
121
the patch passed

+1
compile
38
the patch passed with JDK v1.8.0_222

+1
javac
38
the patch passed

+1
compile
42
the patch passed with JDK v1.7.0_232

+1
javac
42
the patch passed

-1
checkstyle
87
hbase-server: The patch generated 3 new + 255 unchanged - 5 fixed = 258 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
165
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
308
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
30
the patch passed with JDK v1.8.0_222

+1
javadoc
41
the patch passed with JDK v1.7.0_232

+1
findbugs
173
the patch passed

_ Other Tests _

-1
unit
6867
hbase-server in the patch failed.

+1
asflicense
26
The patch does not generate ASF License warnings.

9272

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestClientOperationInterrupt

hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 7033353a86fd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/4/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/4/testReport/

Max. process+thread count
4668 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/4/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
501
branch-1 passed

+1
compile
41
branch-1 passed with JDK v1.8.0_222

+1
compile
47
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
96
branch-1 passed

+1
shadedjars
179
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
branch-1 passed with JDK v1.8.0_222

+1
javadoc
43
branch-1 passed with JDK v1.7.0_232

0
spotbugs
183
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
180
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
127
the patch passed

+1
compile
43
the patch passed with JDK v1.8.0_222

+1
javac
43
the patch passed

+1
compile
47
the patch passed with JDK v1.7.0_232

+1
javac
47
the patch passed

+1
checkstyle
96
hbase-server: The patch generated 0 new + 255 unchanged - 5 fixed = 255 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
172
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
305
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
30
the patch passed with JDK v1.8.0_222

+1
javadoc
42
the patch passed with JDK v1.7.0_232

+1
findbugs
185
the patch passed

_ Other Tests _

+1
unit
6945
hbase-server in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

9412

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux fd785f2502e5 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / bb87e3a

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/6/testReport/

Max. process+thread count
4436 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/6/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
53
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
518
branch-1 passed

+1
compile
38
branch-1 passed with JDK v1.8.0_222

+1
compile
42
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
86
branch-1 passed

+1
shadedjars
164
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
35
branch-1 passed with JDK v1.8.0_222

+1
javadoc
38
branch-1 passed with JDK v1.7.0_232

0
spotbugs
169
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
166
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
114
the patch passed

+1
compile
35
the patch passed with JDK v1.8.0_222

+1
javac
35
the patch passed

+1
compile
41
the patch passed with JDK v1.7.0_232

+1
javac
40
the patch passed

+1
checkstyle
82
hbase-server: The patch generated 0 new + 255 unchanged - 5 fixed = 255 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
157
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
293
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
31
the patch passed with JDK v1.8.0_222

+1
javadoc
37
the patch passed with JDK v1.7.0_232

+1
findbugs
163
the patch passed

_ Other Tests _

-1
unit
7144
hbase-server in the patch failed.

+1
asflicense
24
The patch does not generate ASF License warnings.

9464

Reason
Tests

Failed junit tests
hadoop.hbase.procedure.TestZKProcedure

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 164f10131540 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / 3b07221

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/7/testReport/

Max. process+thread count
3961 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/7/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
52
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
495
branch-1 passed

+1
compile
36
branch-1 passed with JDK v1.8.0_222

+1
compile
41
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
89
branch-1 passed

+1
shadedjars
166
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
34
branch-1 passed with JDK v1.8.0_222

+1
javadoc
36
branch-1 passed with JDK v1.7.0_232

0
spotbugs
166
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
164
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
111
the patch passed

+1
compile
38
the patch passed with JDK v1.8.0_222

+1
javac
38
the patch passed

+1
compile
42
the patch passed with JDK v1.7.0_232

+1
javac
42
the patch passed

+1
checkstyle
85
hbase-server: The patch generated 0 new + 255 unchanged - 5 fixed = 255 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
161
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
299
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
32
the patch passed with JDK v1.8.0_222

+1
javadoc
38
the patch passed with JDK v1.7.0_232

+1
findbugs
179
the patch passed

_ Other Tests _

-1
unit
7377
hbase-server in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

9714

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c831f4e93a99 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / eba383d

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/8/testReport/

Max. process+thread count
4004 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/8/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
1469
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1
mvninstall
545
branch-1 passed

+1
compile
51
branch-1 passed with JDK v1.8.0_222

+1
compile
58
branch-1 passed with JDK v1.7.0_232

+1
checkstyle
117
branch-1 passed

+1
shadedjars
228
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
branch-1 passed with JDK v1.8.0_222

+1
javadoc
53
branch-1 passed with JDK v1.7.0_232

0
spotbugs
231
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
226
branch-1 passed

_ Patch Compile Tests _

+1
mvninstall
164
the patch passed

+1
compile
51
the patch passed with JDK v1.8.0_222

+1
javac
51
the patch passed

+1
compile
57
the patch passed with JDK v1.7.0_232

+1
javac
57
the patch passed

+1
checkstyle
122
hbase-server: The patch generated 0 new + 255 unchanged - 5 fixed = 255 total (was 260)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
225
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
384
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1
javadoc
36
the patch passed with JDK v1.8.0_222

+1
javadoc
49
the patch passed with JDK v1.7.0_232

+1
findbugs
220
the patch passed

_ Other Tests _

+1
unit
9964
hbase-server in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

14354

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/527

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ee62ef010a51 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-527/out/precommit/personality/provided.sh

git revision
branch-1 / d832786

Default Java
1.7.0_232

Multi-JDK versions
/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/testReport/

Max. process+thread count
4323 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-527/9/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Request about the new variables

Could you, please, add some new options for Form variables and conditions?
Add Self here:
https://i.imgur.com/GLUhK1C.png
And Mounting actor here:
https://i.imgur.com/PqRCCrA.png
The reason I'm asking, it's to make equipment overrides more easily.
The variables functions are really powerful and handy to condition. Example you can have a condition like Form Var != 0, which means this variable has loaded a form, and use it to disable or reposition another display.
And another question about these variables, are there any plans to include some functions in the scripts to access them? I think the int and float could be very useful.

are there any plans to include some functions in the scripts to access them?

Yes, I planned that from the start (not sure when I'll get to it though). Form variables will be of most use here, global variables can already be used for integers/floats.

That's awesome.
Yeah, form vars will be very useful indeed, but float and int will have their uses too.
Globals are useful, but you need to create them in a plugin and use them in the scripts. With vars it'll be more straightforward I think.
Anyway, thanks for such cool features.

Hey. Just wanted to ask you something.
Are you amenable to add some functions to return what node is defined for the weapons in "Gear positioning"?
I want to do some dynamic stuff with an animation mod I have.

The existing implementation already tracks which node is positioned where (for anim switching switching purposes) so it'd be simple to add, the problem is that there's currently no way to notify your plugin when a change occurs, you'd have to periodically poll it which isn't ideal. What exactly are you trying to do?

I released this mod, mainly for Nemesis users or for someone looking for alternatives to animations. It uses DAR, conditioned with Globals that correspond to the animation selected in the MCM.
At the moment, it needs manual input, so I was trying to create something more automatic.
It could be useful with overrides as with IED you can define, for example, the Sword back node for swords, but create an override that uses the Sword (hip) instead when a two handed is equipped. In this case the animation would be still the sword at back unless the user manually changes.
Some sort of Event OnWeaponNodeChange or something would be perfect, but a function that returns the node would be enough too, then I could call it with the Event OnObjectEquipped maybe.

Thanks for looking into it.
About the lights, I was trying to create a display to place lit torches near the player with IED, but there where no lights... And now you just dropped this update lol. I will check it in-game now, thanks.

If you want something more realistic, you'll need to make a LIGH form and possibly a mesh. Example below uses the vanilla candlelight spell mesh. 'Play sequence' needs to be checked (set sequence to mLoop) and maybe add some conditions so it turns off if candlelight/invisibility effect is active, during the day, indoors, .. and you've got a nice permanent night light.
IED_Candlelight.zip

Ahh, so that's how "Play sequence" works, it needs to be something that's in the mesh. Got it.
Btw, do I need to toggle something else in order for the lights to work? I created a display for the torch and toggled "Attach light", but it didn't work.
As for the mesh in the file you provided, the light worked only by toggling "Play sequence" with mLoop.

A small mistake caused lights not to get attached at all, fixed in 809e75a. What you probably thought was a light was actually just the glow mesh surrounding it. I'll get new builds up in a bit.

Yeah, I figured it out haha. Thanks.
I'll try to add the candlelight animations to a torch model, a floating torch wouldn't be too bad.
Some really awesome features in this version, you are wizard..

Lights are working fine now and the script functions were just what I was looking for. Thanks...
Btw, I tried to use this mod to create a floating torch display, by creating the light form, with torchlightspellactorfx.nif, just as you did with the candlelight, but it didn't work as expected, as you can see in this video. The giant torch spinning is the IED preset, the torch floating normally to the right is the same item, but placed with console commands. The spell work fine too.
There is probably something in the nif, but I can't put my finger on it.

Spinning one is torchlightspellactorfx.nif , you probably want _torchlightspellhazard.nif, the one that's loaded from the hazard form and links to the light. Make a copy of _Torch01, change the model path to magic\_torchlightspellhazard.nif and use that. Btw NifSkope can play sequences, just load the meshes and check which one has the correct anims.

Yeah, that did the trick. I guess I overlooked the plugin in xEdit and also missed the animation part in NifSkope, smh.
Thanks again.

Hey, I think you can close this issue as the original request is complete, the discussion deviated a little bit.
I could open a new one for the weapon node change stuff, but only if you're going to do that, of course.

I think the best solution would be adding actor variables directly to the animation replacer. Not much chance that will happen with DAR, luckily there's open variant of the animation replacer in the works. The switch needs to happen in real time but with papyrus in the middle of IED and DAR, delays could be very high. Plus the globals condition in DAR isn't of much use for npcs.

Yes, you're right. The global is only useful if all NPCs use the same placement for the weapons.
I think a direct communication between IED and OAR would be best, you would set up the folders names with the animations and IED would send the info to OAR instead of using the FNIS with XPMSE.
Or OAR could have a new condition to look for IED weapon placements, but it would also need a functionality to dynamically detect the actors to properly function with NPCs.
Just thoughts...

Nothing complicated like that, variables like behavior graphs have would be enough. IED would set some predetermined vars based on current positioning, then you could use them in OAR conditions.

I see, thanks for the input.


BUG: Sorting integers with separator masks causes unpredictable behaviour

On larger datasets with lots of integers using masks on 1000 separators, eg comma ',' or period '.' items get mixed up and ordered incorrectly.
Using a comma on numbers, eg 2,000, 1,345 the sorting gets really messed up. On periods, its not quite so bad, but if there's a mixture of numbers, eg some 100s and some 1000s, such as 234, 3.000 then the sort > ascending option groups 100s and 1000s seperately.
There's a fiddle here demonstrating this behaviour:
https://jsfiddle.net/darrenjames/ucts769y/1/
It seems to depend on the range of numbers, eg all 100s, or all 1000s are fine, the fiddle will generate random data each time its loaded to demonstrate.

This should be better on v4.2+ since we consider the column type for the sorting.

The sorting bug is still there in v4.2, although the behaviour is slightly different.
https://jsfiddle.net/darrenjames/ucts769y/7/
Sorting now happens on the first integer on the number, so a list of numbers sorted ascending would be displayed as:
1852
10759
19915
2002
2249
3101


stunting---wasting interaction

@tbhallett, @timcolbourn, I'm looking at the stunting module to figure out what the interaction with wasting module is. There are 2 parameters related to wasting: rr_stunting_prior_wasting: Relative risk of stunting if prior wasting in the last 3 months, and rr_progress_severe_stunting_if_prior_wasting: Relative risk of severe stunting if previously wasted.
However, what seems odd to me is that these are used if predictor un_ever_wasted is True. This property is True if WHZ was ever lower than -2. As these relative risks are called "prior wasting", shouldn't they be used when un_ever_wasted is False?

Another question is whether the predictor is defined as it is meant to be---as "ever having lower WHZ", or should it be "ever having acute malnutrition (MAM or SAM)"?

Lastly, what is meant by the description 'Relative risk of stunting if prior wasting in the last 3 months'? The property un_ever_wasted only carries information on whether they were ever wasted, no way to say if it applies to last 3 months or not.

However, what seems odd to me is that these are used if predictor un_ever_wasted is True. This property is True if WHZ was ever lower than -2. As these relative risks are called "prior wasting", shouldn't they be used when un_ever_wasted is False?

True seems correct to me if it means WHZ was ever lower than -2  given that means if they were ever wasted?

Another question is whether the predictor is defined as it is meant to be---as "ever having lower WHZ", or should it be "ever having acute malnutrition (MAM or SAM)"?

You could rename it to "ever having WHZ <-2" if that's more intuitive - either way I think the definition is the same?

Lastly, what is meant by the description 'Relative risk of stunting if prior wasting in the last 3 months'? The property un_ever_wasted only carries information on whether they were ever wasted, no way to say if it applies to last 3 months or not.

Yes that seems incorrect - I'm guessing the paper Ines used to determine the rr was for "past 3 months"? but it could be "ever" - I think that's fine, given stunting is chronic and there is probably an increased risk even if you were wasted more than 3 months ago? what do the references Ines cites in her methods write-up say?

However, what seems odd to me is that these are used if predictor un_ever_wasted is True. This property is True if WHZ was ever lower than -2. As these relative risks are called "prior wasting", shouldn't they be used when un_ever_wasted is False?

True seems correct to me if it means WHZ was ever lower than -2 given that means if they were ever wasted?

Yes, thank you, you're right. I concentrated on rr_stunting_prior_wasting, which sounded to me like the relative risk of stunting happening prior to ever being wasted, but from the rest, it was actually meant as the relative risk of stunting (progress) if they happened to be ever wasted before. So yes, this is fine.

Another question is whether the predictor is defined as it is meant to be---as "ever having lower WHZ", or should it be "ever having acute malnutrition (MAM or SAM)"?

You could rename it to "ever having WHZ <-2" if that's more intuitive - either way I think the definition is the same?

What I was asking here is if that is what you wanted. Should the relative risk be higher if WHZ < -2, but not if they had MAM/SAM while having normal WHZ? From reading the reference, it seems that they indeed only predicted stunting based on wasting (WHZ), not acute malnutrition. It's okay then.

Lastly, what is meant by the description 'Relative risk of stunting if prior wasting in the last 3 months'? The property un_ever_wasted only carries information on whether they were ever wasted, no way to say if it applies to last 3 months or not.

Yes that seems incorrect - I'm guessing the paper Ines used to determine the rr was for "past 3 months"? but it could be "ever" - I think that's fine, given stunting is chronic and there is probably an increased risk even if you were wasted more than 3 months ago? what do the references Ines cites in her methods write-up say?

Yes, the associations between stunting<->wasting were calculated in 2 consecutive periods; that is what she likely meant (though it would be 2-6 months as they did the measurements monthly in the 1st year, and every 3 months thereafter). I think we can use it as if ever wasted. But it is interesting that you have chosen to use this as a predictor when the relative risk is 1.93, but didn't use it as a predictor if they were ever stunted, for that had a relative risk of 9.50.

But it is interesting that you have chosen to use this as a predictor when the relative risk is 1.93, but didn't use it as a predictor if they were ever stunted, for that had a relative risk of 9.50. Do you recall why?

I think the stunting module remaining unfinished is probably the explanation.

Thanks for clarifications, I'm closing the issue.


Avoid using floating point values as partition values in tests

Fixes #9976.  Similar to #9961 this avoids using floating point for partition values.

build


Added image of 2048 to README.md

Google Code-in Task

Please update or close this pull request.

There's been a few changes to the progrm since the screenshot here was taken.  Also the pull request wasn't updated after changes were requested.  Closing since it will need to be redone anyways now.


ensuring that MPI_File_close() is only called on open MPI file handle

ensuring that MPI_File_close() is only called on open MPI file handle
Fixes #2283

Looks great!


Creating factory for specific types of automata

One small suggestion for discussion: I think this is one of the many cases of specific constructions of automata; I'm thinking if it might be useful to have specific namespace and file with these automata so they don't clog the space. E.g., Mata::AutomataDatabase, or Mata::Factory. This could have functions for creating: universal automata, single word automata, etc.
Originally posted by @tfiedor in https://github.com/VeriFIT/mata/pull/185#pullrequestreview-1313947165

The idea of a factory sounds interesting. As of now, we have been struggling with deciding whether some specific type of automaton is a general enough that it should be in the nfa.hh interface or whether it should be a string solving only function.

yeah, it may be useful to add namespace factory or builder and don't pollute nfa.hh interface.

We should evolve this issue to redesign of library structure which we discussed at the last meeting. Maybe create a design dock or draft PR, where we can tinker with structure of library.

I think this should be linked to #262 , since the PR technically solves this issue. @Adda0 , please confirm.

You are right. I was just waiting right until merging the PR before linking it to this issue, in case we decided to drop the commits creating the builder class and merge the PR without the changes requested in this issue. Right about now, it seems that no one has any objections to merging the PR with the builder class, so I can link this issue to the PR already. Thank you for notifying me.


HESSIOEventSource reads all telescopes, even if allowed_tels is set

The current behavior seems to be broken compared to how it was originally implemented - only the telescopes in the allowed_tels list should be filled into the event data structure, which also speeds up the IO for reading data with super-arrays.
To check, we should add a unit test to ensure that set(allowed_tels) == set(event.r0.tels.keys())

We now use the eventio bases event source.
I think we should not put too much effort into fixing the hessio eventsource.

Does the eventio package completely skip telescopes not specified in allowed_tels? And does not waste time reading them?

Yes, but the speed up is not as large as you might expect, at least in the case for compressed files. As it still has to decompress the bytes.


Add reviewers

Add an option to add and remove reviewers from 'mr edit' and 'mr create'.  This involves generalizing and moving some code around.  I've also added the ability to add and remove reviewers and assignees via user's email addresses.
Closes: #639
Signed-off-by: Prarit Bhargava<EMAIL_ADDRESS>

I'll figure out the failures this morning.  I also have to add testing for the options.

The only issue is a gofmt one:
  func getUserID(user string) *int {
 	var (
-		err error
+		err    error
 		userID int
 	)

The MR I removed manually.
About the testing.. that's true., but is it possible to add the MR author as a reviewer? Otherwise, it can be annoying to add someone real there :). Maybe testing the only the getUserID.

I will push testing for these commands in another PR.

@AlexanderVanEck we're planning to make a release pretty soon. We were facing some issues in the past weeks with our CI/CD and weren't able to officially release a new version. But things are now working again :-)

Thanks Bruno! Great to hear :) looking forward to it.
On Thu, May 20, 2021, 15:21 Bruno Meneguele @.***>
wrote:

@AlexanderVanEck https://github.com/AlexanderVanEck we're planning to
make a release pretty soon. We were facing some issues in the past weeks
with our CI/CD and weren't able to officially release a new version. But
things are now working again :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zaquestion/lab/pull/646#issuecomment-845115597, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUFSKK5QSQUNC7L35TUWTTTOUEGJANCNFSM4ZWE32BQ
.

Works @bmeneguele. Wonderful 🙌  Thank you.


JSC support

This is not really an issue but more like a suggestion. That would be great if this tool could generate a Canvas code based on the given JSX React components (e.i. converting JSC DOM to Canvas elements). I know this is lots of work.

It is possible to generate canvas with react-konva and then call stage.toImage().
I am not sure what is "canvas code".
I am closing this issue for now, as I think it is not useful in this lib.
Reopen if you think otherwise.


Reenable Azure ml test

Reenable Azure ml test for pipeline.

Since we removed the bert.py and resnet.py python scripts from the examples, we are not dynamically creating the workspace config jsons before running the tests. I think we need to do this in the test scripts now like in https://github.com/microsoft/Olive/blob/43a2586b24067046ef857213f332b03f47941ea8/test/integ_test/aml_model_test/test_aml_model.py#L53?
or else the tests will fail with workspace config not found.

Since we removed the bert.py and resnet.py python scripts from the examples, we are not dynamically creating the workspace config jsons before running the tests. I think we need to do this in the test scripts now like in
https://github.com/microsoft/Olive/blob/43a2586b24067046ef857213f332b03f47941ea8/test/integ_test/aml_model_test/test_aml_model.py#L53
?
or else the tests will fail with workspace config not found.

Yeah I just noticed we removed config file here. I'll add this part logic.

If requirements_file_path is None, the Path(None) will throw the exception.

  If requirements_file_path is None, the Path(None) will throw the exception.

Yeah we allowed None value here. I'll add an additional check here.

  If requirements_file_path is None, the Path(None) will throw the exception.

This error is actually because of the typing annotation for requirements_file_path and not because of the validator. The validator doesn't get called when it is None.
For some reason, the annotation requirements_file_path: Optional[str] = None and requirements_file_path: str = None behave differently. For the former, it doesn't allow the user to explicitly set requirements_file_path to None but the latter does.

So, what we want is to remove all Optional from the annotations. You can see that none of the other olive code uses Optional when annotating optional fields that can take None. It automatically becomes optional when the field is provided a default value.


add pretty printer for MetadataInfo

In interactive use, this struct can print a lot of information that the user cannot directly interpret. This PR defines a pretty printer to avoid the wall of text.

Before the PR, I had

With this PR I have:

All looks good!


Catch error when failing to properly read README.rst.

Fixes #2

@oliamb Any chance of getting this merged and published to npm? I'd really like to use this in a project I am working on, but it is currently unusable because of this bug.

Oops. I'm sorry for the delay.

Just published v0.0.4 including your fix. This project is brand new so I'm willing to accept lots of contributions like this one ;-)

Weird, not seeing v0.0.4 on npm.

I'm not in front of a computer right now. I will have a look in a couple of hours. Sorry for that.
Envoyé de mon iPhone

Le 12 mai 2016 à 18:49, Richard Tibbles<EMAIL_ADDRESS>a écrit :
Weird, not seeing v0.0.4 on npm.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

Done, it has been published to a private repo instead...

Awesome, thanks!


Why is there no system clipboard??(ubuntu 16.04)

:reg
--- 寄存器 ---
""   #!/bin/bash^JWORK_DIR=$( pwd )^Jsh $WORK_DIR/stop.sh^Jecho -e "Starting monitor \n"^Julimit -s 64000^Jcd "${WORK_DIR}/src"^Jnohup python3 monitor_main.py &^Jecho $! > $WORK_DIR/mo
"0   #!/bin/bash^JWORK_DIR=$( pwd )^Jsh $WORK_DIR/stop.sh^Jecho -e "Starting monitor \n"^Julimit -s 64000^Jcd "${WORK_DIR}/src"^Jnohup python3 monitor_main.py &^Jecho $! > $WORK_DIR/mo
"1   !/bin/bash^JWORK_DIR=$( pwd )^Jsh $WORK_DIR/stop.sh^Jecho -e "Starting monitor \n"^Jelimit -s 64000^Jddohup python3 monitor_main.py &^Jec
"2   et clipboard^=unnamed,unnamedplusd "${WORK_DIR}/src"^J
"3   #!/bin/bash^J
"4   source ~/.bashrc^J
"5   alias cleos="cleos -u http://<IP_ADDRESS>:8889/"^J
"6   source ~/.bashrc^J
"7   alias gleos="cleos -u http://<IP_ADDRESS>:8889/"^J
"8   source /etc/profile^J
"9   #plugin = eosio::wallet_plugin^J
"-   f
"%   123
"/   usr
vim-scripts vim-gtk vim-gnome  has already installed，
ll /usr/bin/vim*
lrwxrwxrwx 1 root root      21 12月 26 00:49 /usr/bin/vim -> /etc/alternatives/vim*
lrwxrwxrwx 1 root root      21 5月  24  2018 /usr/bin/vim_bak -> /etc/alternatives/vim*
-rwxr-xr-x 1 root root 2437320 11月 25  2016 /usr/bin/vim.basic*
lrwxrwxrwx 1 root root      25 12月 26 00:49 /usr/bin/vimdiff -> /etc/alternatives/vimdiff*
-rwxr-xr-x 1 root root    1051 1月   6  2017 /usr/bin/vimdot*
-rwxr-xr-x 1 root root 2932160 11月 25  2016 /usr/bin/vim.gnome*
-rwxr-xr-x 1 root root 2923968 11月 25  2016 /usr/bin/vim.gtk*
-rwxr-xr-x 1 root root    7940 8月  19  2013 /usr/bin/vimplate*
-rwxr-xr-x 1 root root    2084 11月 25  2016 /usr/bin/vimtutor*
vim --version |grep clipboard
+clipboard       +insert_expand   +path_extra      +user_commands
+emacs_tags      +mouseshape      +startuptime     +xterm_clipboard
why :reg no  no system + or * clipboard

That happens when both PRIMARY selection for "* clipboard" and CLIPBOARD selection for "+ clipboard" have no data to pass from other applications to Vim and vice versa.

but i select content and "+y ,There's still no system paste board, so i can't copy things to external programs

What do you mean by "no system paste board"?  If that means that neither X nor Wayland server is running on your system simultaneously with Vim, then there's no "system paste board" because Vim's copy/paste operation is done through the X11 selection mechanism. If that is the case, then you won't copy or paste anything from one application to another one.  In contrast, if the X server is actually running, then there should be the "system paste board" on your system. Some clarification on whether the X server is running or not is needed.

Hmm, seems like you actually want to say "over ssh connection" instead of "over the xterm terminal connection."  Then, this could help you.

ssh -Y<EMAIL_ADDRESS>xsel -o -b
xsel: Can't open display: (null)
: Success
3.It works the same way, but it still doesn't work，why？thanks

~$ vim --version |grep X11
+diff            +menu            +ruby            +X11

The Q&A I showed you with the link is followed up with two comments in small Latin characters.  Among them, the second comment seems to have an important info for you:

sudo apt-get install xauth did the trick. – jaz Aug 23 '11 at 14:23

The question seems to be specific about how to use the clipboard remotely.
Please ask user questions on vi.stackexchange.com or the vim-use mailinglist. We cannot provide individual support here. Closing.


Card types can include a static typeDisplayName

Looking forward to any feedback, especially about the name, which I don't love.

let's add a test for this in the packages/host/tests/integration/components/card-basics-test.gts

@habdelra thanks, tests added


SyncTrayzor 1.1.9 not talking right to syncthing 0.13.1

Upgraded one computer and did a fresh install on another computer (and did syncthing 0.13.1 upgrade). The folders disappear, the device says unknown, and there is no id. Web interface for syncthing is just fine.
windows 7 Pro
The new install is actually on a brand new computer install, which is why I did the upgrades.

Sounds like it's Syncthing's issue, not SyncTrayzor's?

Syncthing itself works, and I can hit it's web interface to use it with firefox. The SyncTrayzor interface doesn't work (which is weird, as it looks like the web interface).

OK, something funky's going on. Try refreshing it? (Syncthing - Refresh Browser). Otherwise we're into debugging javascript...

Very funky. I switched over to the window on my new computer and it showed properly (before I did anything to it). The old computer is still in never never land.

FYI, After some time, my other computer also just suddenly sync'd back in and worked. It was giving an error on the Listeners while it was broke. I didn't do anything to fix it other than let it just run for awhile. Restarts, reinstalls, refresh browser all failed to do anything.

Same situation here. But i still hope and wait for things getting back to normal as stated by vr-jack.

I saw something similar on the forums, actually, where the web UI (it wasn't related to SyncTrayzor: it was the web UI in general) didn't work while Syncthing migrated the database to the 0.13 format.
Can you confirm that opening the web interface in a browser definitely does not exhibit this problem, at exactly the same time that SyncTrayzor does exhibit the problem?

I can confirm this. And i'm happy to tell that the first machine came back to normal behaviour around 1 hour after the update. Thank you.

Can you edit SyncTrayzor.exe.config (which lives alongside SyncTrayzor.exe) and change <CefRemoteDebuggingPort>0</CefRemoteDebuggingPort> to <CefRemoteDebuggingPort>2004</CefRemoteDebuggingPort> (and restart SyncTrayzor).
When the issue next appears, open Chrome (i.e. normal standalone Chrome) and go to http://localhost:2004, then click on the single link that appears. Click the 'Console' tab at the top, and see what appears (there should be a bunch of errors). What are these?
Also check the 'Network' tab. You might see a bunch of failed requests. If you click one of these, you'll see details about the request. That will be useful to see.

Actually, another thing to try (which might be easier) is to delete C:\Users\<You>\AppData\Local\SyncTrayzor\cef\cache.

I see a page like this:

When I click the link I arrive on a blank page. Probably the same locking problem.
Adress is then something like
http://localhost:2004/devtools/inspector.html?ws=localhost:2004/devtools/page/xxxx-xxx....
But only a white blank page is displayed.

Deleting the cache solved the problem immediately. For other users using the portable Version of SyncTrayzor: The cef folder may reside in the same folder where SyncTrayzor.exe is.

Aah, OK, so the embedded browser (CEF) is probably caching some javascript for a while, or some such. Yay.
Annoyingly, I can't simply delete the cache on startup (for example) as it contains the local storage, which contains the user's langauge selection for Syncthing.
Having said that, it looks like there's a switch to disable the cache but keep local storage which I'd missed. I'll try that...

Can someone who's still seeing this problem try this build please? https://ci.appveyor.com/project/canton7/synctrayzor/build/<IP_ADDRESS>4/artifacts

Sorry :(

OK, that's something new....
Can you post your log please (my email's on my github profile page if you want to keep it private).

Can you tell me which logfile exactly?

Go to File -> Settings -> Logging + STTRACE, click "Show SyncTrayzor log file".

This build should fix that: https://ci.appveyor.com/project/canton7/synctrayzor/build/<IP_ADDRESS>5/artifacts

(It didn't work, apparently)
Trying another approach. Build to follow shortly.

Would someone who can still reproduce this mind trying this build? Thanks! https://ci.appveyor.com/project/canton7/synctrayzor/build/<IP_ADDRESS>6/artifacts

Doesn't seem to fix the issue for me, nor did 1.1.10 that offered to update.  It doesn't bother me much, so I'll let it sit for now... and I have 3 other machines that will probably do the same when I turn them on and make them get ST0.13.1

Oh well. I can't reproduce the issue here, so I'm having to guess at what the problem is, then guess at potential ways to kick the embedded browser into behaving...

I had the same problem on 2 Windows PCs and was able to fix the issue by deleting the cache.

The version 1.1.10 solved the problem for me. Thank you!

Over night, my primary PC fixed itself while running 1.1.10... but it seemed like old versions would do that as well after a while.
I booted up another machine, updated it to 1.1.10 first, then updated ST to 0.13.1 and still had the previous problem.  So it really just looks like time fixes it if you don't want to go and delete things.

Yeah, it's looking that way.
It's annoying that I can't reproduce it. I might hack something together to go and delete the right files whenever Syncthing restarts, or I might look at what cache headers Syncthing is sending out...

I confirm issue on v0.13.2 and 1.1.10 (Shall I send you the logs?)
Thanks!

@opuslux:

When I click the link I arrive on a blank page. Probably the same locking problem.

Bleh, looks like Chrome changed how their debugging tools work, and broke everything....
@marclaporte Mind downloading this version (when it's finished building) and following these instructions?
I'm interested in screenshots of the 'Console' and 'Network' panels as you click Syncthing -> Refresh Browser in SyncTrayzor.
Thanks!

What timezone is everyone in?
Tracking this issue down in the Syncthing sources, and it looks like it might be timezone-related....

Hello from Switzerland

So GMT+1?

In wintertime it is GMT+1 but right now in summtertime it is GMT+2. I hope this is good news ;)

Nah, it's the wrong way: I need you to be behind GMT for my theory to work...

EDT, which is UTC -4

I can confirm, that on two computers (Win 10 x64, ST 0.13.2), it was not showing up properly, as stated in this issue. I was able to click "Syncthing->Open in external browser", to open the interface in Edge which worked perfectly. Deleting the cef cache folder fixed the problem on both computers.

I'm almost certain it's a Syncthing caching issue now, although I can't put my finger on what's causing it (as I can't replicate it).

Problem went away on my end... (so yup, looks like cache)

Agreed. Would it be reasonable to wipe the cache for each SyncTrayzor (or even just syncthing) update?

Wiping it on SyncTrayzor updates won't make any difference, since that's unrelated to Syncthing upgrades. Actually wiping the cache is also a bit of a problem: the embedded browser doesn't provide a means of doing this.
I'm currently working out a better caching strategy with Syncthing, which should (in theory, if our guess at what's causing it is right) sort it out.

Right, I've landed https://github.com/syncthing/syncthing/pull/3221, and the next version will do a complete cache refresh when you click Syncthing -> Refresh Browser (or hit F5). That should take care of everything...

@canton7 thanks for SyncTrayzor love the app!
I just ran into this bug when going from v0.13.4 to v0.13.5.
I could not see any of my recent GUI changes, and had to delete C:\Users\norgeous\AppData\Local\SyncTrayzor\cef
Please make a release soon!

That release has been made, and the Syncthing patches landed. Closing.

Sorry to come back on this but I'm facing the same issue on my intel compute stick (32bit) when there is no screen physically attached. Version is 14.6. While I can connect to Syncthing through chrome SyncTrayzor stays with a white window.
But: I remembered having some similar issues when my laptop had a closed lid and i was accessing it via remote access. Same here: Monitor attached: Works. No monitor: White SyncTrayzor.

Open a new issue please, your issue is different. Tried disabling hardware rendering in SyncTrayzor's settings?


⚠ Bofrost.de has degraded performance

In fa04529, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1555 ms

Resolved: Bofrost.de performance has improved in 797ee82.


Run away zkfc fix

This eliminates the possibility of multiple zkfc nodes being created if a namenode is launched on the same executor.  The executor only gets 1 of each.
also, I added a shutdown hook... so if an executor is killed gracefully, it cleans all running task processes.  This is required for a certification.

@elingg @gabrielhartmann I could use a review.  This has been tested on mesos and dcos.

@kensipe, it seems with your latest code, you have no need of my fix I did in the health checks branch and we can remove this line. https://github.com/mesosphere/hdfs/blob/master/hdfs-executor/src/main/java/org/apache/mesos/hdfs/executor/AbstractNodeExecutor.java#L187. In fact I think your shutdown hook is a better implementation

@kensipe will 1) remove the shutdown(driver) that was implemented before 2) add a check on nn and 3) add the todo. After that I will do a quick final review and merge, assuming no objections from @gabrielhartmann

LGTM, one nit above. Then feel free to merge unless there are objections from @gabrielhartmann

@gabrielhartmann what say you?  :)   @elingg ready to go!

:+1:, will merge if we don't hear any objections from @gabrielhartmann by 3 today


don't send an ACK for every packet received that just contains an ACK frame

This is not as straightforward as it might seem. While it is ok (and desirable) to send an ACK only for every second packet that only contains an ACK frame, if we don't ack the last packet that we received (at the end of a connection), we would trigger a RTO.

See QuicConnection::MaybeQueueAck() in quic_connection.cc.

Chrome seems to ACK either every second packet or after a timer max(RTO/2, 25ms) expires. This doesn't prevent an ACK-cascade, right?
Since 44acb8ca8210d14b8ba5c19672f94dfc568a384c, we delay ACKs for up to 5 ms (if we don't need to send a packet anyway). I'm not sure of the benefit of only ACKing every second packet when there's a timer anyway. Maybe we could simply set our timer to max(RTO/2, 25ms) as well and call this issue solved?

Closing this for #354.


Android: 2022 Redesign

It's time for this year's design changes. There's a good number of them.
You can see the redesign on beta.newsblur.com.

Story titles changed the most

There's now a lot more margin and spacing between title, content, and date/author
Author moved from inline with title to next to date, losing color differences
Read stories are now bold, so unread and read story titles take the same space
Unread indicator and feed favicon switched positions

All new icons. 100% SVGs, all found under media/icons/nouns/* on the pro branch
Missing favicon icon also replaced (world.png -> world.svg)
Almost all uppercase is now in regular, sentence case. Exceptions can and should be made, but buttons and such are now "Sentence case".
Feed title background colors are slightly different to match each other better
All feed favicons now have a border radius
Blurblogs move to below a user's own feeds
All menu icons (site menu, feed menu, folder menu, story menu) were replaced
New icons in Feed Options popover (top style menu)
Difference between Comfortable / Compact was further emphasized
Borders between feeds, folders, and story titles were removed and deemphasized
Story content header has fewer borders and more space
Feed header bar no longer has borders, just the gradient
Story action buttons at the bottom of each story are slightly different too
Highlighted feeds have a border radius and margin to them now

I uploaded a whole bunch of screenshots of the before and after from the web for convenience, but realized it would be easier for you to just switch back and forth between beta.newsblur.com and www.newsblur.com. That should help guide the relative changes since it won't be a 1-for-1 with mobile.

Since we'll be deep in story title layout for this ticket, let's fix this screenshot. There needs to be more padding between elements when the font size goes up. We do this on the web and while it's a lot of work, the results are clearly better.

@samuelclay The redesign changed we're pushed to the main repo and are ready for your initial live review.
The padding issue with enlarged font might have been fixed by the new padding between elements.

Sorry that took so long! I've been on infrastructure all week and it's been eating into my nighttime hours by quite a bit. But I finally released a big change last night that seems to be having a good impact.

@samuelclay Thanks for the detailed list with photos. The branch is ready for another UI review.

Great work! Few more notes:
Feed list

Let's match the three background colors on the web for saved stories, shared stories, and saved searches
The All/Unread/Focus/Saved control in the bottom should have the text next to the icon if there's room. If not, successively remove from the right (saved goes first, then focus, then unread, then all). The web does this nicely, just resize the feed list width.
Font size of top level folders is a point too small. On the web we have a letter-spacing of 0.5px which slightly widens it
The left justification for top level folders and feed folders are off by a pixel or two

Story list

Lighten the bottom and top border to match the web. Those borders should be nearly invisible
Tiny bit more margin (~1-2px) above story title in Comfortable spacing
Tiny bit more margin (~2-4px) above and below in Compact spacing
There's too much space on story titles that have no story content but story content preview is enabled

Story content

Remove the border for the colored feed favicon bar

@samuelclay Ready for another test drive.

This is so, so good. I'm loving this new design with all of its increased space. Few notes:
Story titles list

The search icon looks weird, can we switch that to the new icon? Or is this the new icon? I'd like to have a cleaner icon there
Increase the right-side padding by ~8px. It should be comfortably far from the edge of the screen
Hyphenation is happening at the character level. Let's switch that to word level.

Story detail

There's some extra right padding on story tags

I'm delighted by the new design as well! Dark mode is nicer without the gradients and borders.
The search icon was new but I replaced it with a standard Android one which should do the job. On older devices these SVGs might be rendered a bit weird.
I worked on getting the hyphenation by word but the results weren't consistent for some reason. I suspect the returned measured text width is somehow incorrect. I won't continue on this due to the web having the same hyphenation rules but let me know if you want me to spend more time and give it another try.

Yeah, let's see what we can do about that hyphenation. It's bizarre and feels broken.

Feels broken on the web too! Ok then, ignore it for now and let's see if it bothers me later.

I'll get back to you with notes tomorrow, I want to let it sit for a day.

Perfect, last issue is that there's some extra right padding on story tags.

@samuelclay Could you post a picture with the padding on story tags? I wasn't sure last time either if I was making the right change.

Available in v12.0.0


Validity checker fails with JSON input example in docs

In the Validity Checker documentation, the following example is provided as an example JSON input file beacons.json:
{
  "routes": [{
      "asn": "AS12654",
      "prefix": "<IP_ADDRESS>/24"
    },
    {
      "asn": "AS12654",
      "prefix": "2001:7fb:fd02::/48"
    }
  ]
}

When I follow the example to validate this input file, Routinator exits with an error:
% routinator validate --json --input beacons.json
Failed to read input file 'beacons.json': invalid type: string "12654", expected u32 at line 3 column 20'

I then changed the input to the following, changing "AS12654" to simply 12654:
{
  "routes": [{
      "asn": 12654,
      "prefix": "<IP_ADDRESS>/24"
    },
    {
      "asn": 12654,
      "prefix": "2001:7fb:fd02::/48"
    }
  ]
}

After this change, the operation succeeds:
% routinator validate --json --input beacons.json
[snip]
{
  "validated_routes": [
    {
      "route": {
        "origin_asn": "AS12654",
        "prefix": "<IP_ADDRESS>/24"
      },
      "validity": {
        "state": "invalid",
        "reason": "as",
[snip]

At the minimum, either the software or the documentation needs to be fixed so that the example works correctly. Note that the JSON output returns the ASN in the "AS12345" string format, not as an integer, so it's inconsistent if the input is required to be an integer.
But I would recommend allowing some flexibility in how the ASN is ingested. It would be great if all of these formats were accepted:
"asn": 12654
"asn": "12654"
"asn": "AS12654"

I see this issue both in the latest release v0.12.1 and in v0.13.0-dev (both compiled from source today using cargo on macOS).
% routinator --version
Routinator 0.12.1
% target/debug/routinator --version
Routinator 0.13.0-dev
% git show
commit 953671cd467436052b3e7844b77a8fef8beed21e (HEAD -> main, origin/main, origin/HEAD)
Author: Martin Hoffmann<EMAIL_ADDRESS>Date:   Mon May 1 14:21:04 2023 +0200

Thank you for the report! The intention was indeed to accept both – I suspect older versions of Routinator did – but this fell victim to some refactoring along the way.
This will be fixed ASAP.


[Enhancement] Add multiple bind to address support

It would be nice to be able to specify multiple bind to address values for MPD.
Context: I'd like to have MPD listen via the standard <IP_ADDRESS> address as well as via unix file socket. The unix file socket is necessary for adding music files to MPD's queue using absolute file paths (e.g. if I wanted to play files that are not in the /music directory). While I could switch to exclusively using the unix file socket via the existing MPD_BIND_ADDRESS var, I'd like to have MPD also listen via TCP at <IP_ADDRESS> so that my phone MPD client can connect to it as well.

Hello, sure, will do that, maybe today but I cannot guarantee.
Can you explain me the use case? For my own understading.
On my desktop I used to use Cantata (unfortunately discontinued) which could create an http server for streaming local files.
Thank you

My setup is a little complicated but basically, I have a separate mount point (lets call it /tmpMusic) in addition to the standard /music mount attached to the MPD container. In /tmpMusic, I like to add some temporary music that I don't necessarily want in my normal library yet, but I would still like to have MPD play music in that directory sometimes. I don't want MPD to index those files since its not part of my normal /music library. This is part of a larger setup which is beyond the scope of this issue but basically I have a MPD client that connects to MPD via UNIX socket to issue the commands to play /tmpMusic files (due to MPD's requirement of using UNIX sockets when specifying filepaths outside of the /music directory). This works fine but I can no longer use a MPD client on my phone to listen to music if MPD is not also listening on <IP_ADDRESS>.
I think a simpler and likely more common use case would be something like wanting to use one bind_to_address to listen to requests from localhost and one bind_to_address to listen on a specific IP (perhaps the IP via which a reverse proxy forwards traffic to MPD). The default listen to <IP_ADDRESS> address would work in this scenario, but having two separate bind addresses might provide better security since you only accept connections from localhost and on that one IP used for the reverse proxy.

maybe today but I cannot guarantee.

No rush! Thanks for being so responsive and resolving the other issues I filed 😄

Hello, so did the change work for you?
Would you share your compose file or docker run command?
Thank you!

Yep, the changes worked perfectly.
Here's a simplified version of my compose file:
services:
  mpd:
    container_name: 'mpd'
    image: 'giof71/mpd-alsa:vanilla-latest'
    restart: unless-stopped
    environment:
      RESTORE_PAUSED: "yes"
      DEFAULT_PERMISSIONS: "read"
      PASSWORD: "REDACTED"
      MPD_BIND_ADDRESS: "/var/run/mpd/socket"
      MPD_BIND_ADDRESS_1: "<IP_ADDRESS>"

      # Icecast streaming
      SHOUT_OUTPUT_CREATE: "yes"
      SHOUT_OUTPUT_ENABLED: "yes"
      SHOUT_OUTPUT_HOST: icecast
      SHOUT_OUTPUT_PORT: 8000
      SHOUT_OUTPUT_MOUNT: "/icecast"
      SHOUT_OUTPUT_USER: "REDACTED"
      SHOUT_OUTPUT_PASSWORD: "REDACTED"
      SHOUT_OUTPUT_ALWAYS_ON: "yes"
    ports:
      - '6600:6600'
    volumes:
      - ./mpd/db:/db
      - ./playlists:/playlists
      - ./mpd/log:/log
      - ./mpd/config:/user/config
      - ./mpd/socket:/var/run/mpd/
      # Music dir - path to normal music library
      - ./music:/music
      # Temp music dir for adhoc playing of music not in the regular /music library. Client must use socket for this
      - ./tmpMusic:/tmpMusic

Hello, thank you for sharing your configuration.
May I ask which client do you use? Just curious.
For a scenario very similar to yours, I tend to stick with upnp: I have a MiniDlna instance (also running docker image here) on that "tmpMusic", and then use any control point to play from that library.
In any case I am happy that you can use my container in your setup!

My setup is in flux (mostly just playing around with MPD and trying to get more familiar with it). Currently using mympd but looking into other clients. Will take a look at MiniDLNA as well - thanks for the suggestion!


Backend: Add mutation CreateQuestionTemplate(...)

I don't know what I was on about https://github.com/equinor/fusion-bmt/blob/2cff4dda7a587a32604d883d06e61788ba1641b9/backend/api/GQL/Mutation.cs#L288


Follow best practices for Docker build and test on Github Actions

docker build and test phase should leverage as many best practices as possible (e.g. reusing existing actions, optimizing with caching, etc.)
see best practices docs on docker for model to follow

solved by #36


Add videos to the seed data

Let's find some fun and short videos that we can use for the seed data.
Videos will need to be added to the repo and put into the assets directory. We should ensure that the videos are of a very low filesize so as to not make the repo too big.
Add one Story video for each story in the seed data.

@rudokemper I'll also take this related ticket :rocket:


How to install the wagtail on mac os

I run the pip command according your documentation and install all package, but when i create the mysampleproject with the "wagtail start mysampleproject" and then run the "python manage.py migrate" i encountered with this error:
/Library/Python/2.7/site-packages/treebeard/mp_tree.py:102: RemovedInDjango18Warning: MP_NodeManager.get_query_set method should be renamed get_queryset.
class MP_NodeManager(models.Manager):

I agree. No dice brewing zlib1g-dev.


test: add case with bad parameters to assert on error message

closes #53

@ChristopheBougere my commit message looks to follow the convention. Not sure why it's failing in the build.


config for client

Hi, I tried your solution, totally newbie, sorry, installed the two files in admin folder and wrote this on the server.ovpn:
script-security 3 auth-user-pass-verify WindowsADLogin.exe via-env
(different from your readme)
but what do I have to write on client side?
EDIT:
On client side:
auth-user-pass auth-nocache
Another point, what's this line for if your program check password in AD?
<add key="Password" value="1234abcd!@#$"></add>
thanks.

The readme file is different because I changed the name of the assembly after the latest version, and Now I will recompile the latest release
I noticed "script-security 3 (whether line breaks are missing??) auth-user-pass-verify WindowsADLogin.exe via-env"
You need to open the log in openvpn-auth-ldap.exe.config and attach the log of LoginLog folder, if not then openvpn-auth-ldap may not be running
This password is used by the delegate to query the inheritance relationship
https://mc.lioat.cn/2019/12/0055133.xhtml, This is a description of this plugin, but it is in Chinese

Yes, line breaks disappeared after pasting it(?). Do this password must not be changed?
Anyway, it's working great, tested it on my WS2019 essentials. Any others points I should care about security? Still looking for a solution including Google Authenticator, but I think it's not available for the windows server version. Anyway, thanks a lot sharing your code!

Sorry, I didn't explain clearly in the end due to Google Translate
InheritanceDetection: whether to allow inherited access
ReadGroupUser: Users with read-only access to user groups (only when InheritanceDetection is True)
Password: Password for this user (InheritanceDetection is True only)
You need to create a user and grant that user read group permissions via Delegated Control, this is the most secure Or use the domain admin user directly, but this is extremely insecure because the configuration file is clear text and you may leak the administrator password
I may add 2FA functionality in a future release

Hi, you say: "configuration file is clear text" this is only for Inheritance detection between openVPN server and AD Server, right? The user and password from the client are always encrypted in the VPN tunnel, right? Sorry for my basic knowledge... So as I don't need Inheritance option, seems ok for me. A nice day. Chris

Sorry but you forgot to put the compiled .exe file?

You can download the latest releases
Yes, The user and password from the client are always encrypted in the VPN tunnel, but you need to note that the current version of openvpn-auth-ldap passes passwords through environment variables.(Openvpn->(env)-> openvpn-auth -ldap)
If your server is safe, then this is not a big problem


Created hashmap.h file

Please have a look at https://github.com/amanmehara/programming/blob/master/CONTRIBUTING.md and make changes accordingly.
I'll approve and merge afterwards! 😃

thanks for helping. I will make the required changes.

Hi @amanmehara . I've made the required changes. Please have a look and let me know if it still requires any further changes. 😄


Publish to F-Droid

Could you please help me? @Poussinou, @IzzySoft :)

Looks good as far as I can tell. Have you already opened an RFP? If not, that would be the first step. Linking the two issues together (mention this issue here with the "author supports inclusion" check box – you'll see what I mean when opening the RFP, and link the RFP here) so one can find the way back-and-forth would be a good idea then.

@enricocid, @IzzySoft, @Poussinou:  I don't see that anyone else has yet put in the RFP, so I'd be happy to put it in (via minimal template).  I'll report back when it's submitted.

Here y'all go: https://gitlab.com/fdroid/rfp/issues/1073
Btw, @enricocid, you've a typo in the ReadMe: "vaste" → "vast"

Thanks @TPS (just please next time leave the description unquoted, makes copying easier :wink:). I've setup metadata and kicked it up for our packagers.
@enricocid what would be optional but highly recommended is setting up Fastlane structures to provide e.g. screenshots. If you use the Fastlane binary for that, you can use the same to deploy to Google Play. With Fastlane, you can manage all metadata inside your repo here: screenshots, summary, description (the latter two even for multiple languages), per-release changelogs etc. One place to rule them all: F-Droid would pick that up automatically, and using the Fastlane binaries you can deploy that to Google Play. For a starter: https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/
Let us know when you've set that up and have a tag covering it, as then we'd need to remove description and summary from our metadata so yours from Fastlane gets picked up.

Thanks everyone, gonna add fastlane (screenshots and changelogs) asap! 😁

FASTLANE ADDED!

Thanks! Looks good, will update metadata in the RFP accordingly.
A suggestion, if you permit: imagine people wanting to see the screenshots on their ~5" screens. Your screenshots waste valuable screen estate with that framing then. I'd suggest dropping the frames, they provide no value anyway (especially the area outside the "device frames", though I'd drop the frames completely).  :)

Thanks! Updated screenshots would then be pulled with the next version (as the current tag doesn't cover them; you can of course "move up the tag" – i.e. delete the tag and recreate it – if you think it's worth the effort).

Thanks, gonna release an update/new tag to fix an issue.
Thanks for support, really appreciated 😁👌

You're welcome! Just let me know when the new tag is available, and I update metadata once more to reflect that. Though I assume the packager will check and adjust that anyway when processing it, so that metadata update wouldn't be urgent. Cannot hurt. Never hurts to ask (unless one asks for hurt).

@enricocid Unless you're hoping to recruit even more help for something here, perhaps remove help wanted? 🙇🏾♂

@IzzySoft the new tag is available! :)

Thanks! Metadata is updated, now we wait for a packager to process the RFP.


[Usage]: Inquiry about AsyncLLMEngine's generate method and multi-modal input support

Your current environment
vllm                              0.6.0
vllm-flash-attn                   2.6.1

How would you like to use vllm
I would like to ask whether the generate method of AsyncLLMEngine supports multi-modal input, including both text and images. I have noticed that in the source code, the input type is specified as inputs: PromptInputs, and PromptInputs only supports:
A text prompt (:class:stror:class:TextPrompt)
A tokenized prompt (:class:TokensPrompt) A single data structure containing both an encoder and a decoder prompt (:class:ExplicitEncoderDecoderPrompt)
If I am using a multi-modal model, how can I input images? Thank you!
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

If you take a look at the schema of TextPrompt and TokensPrompt, you can see that they have an optional multi_modal_data field. This is where you pass the multi-modal data.


[bug]: sendcoins fails in bitcoind after v27

Background
sendcoins fails with bitcoin core version 27.
bitcoind before v26.0
lnd sendcoins bcrt1qgy6djk4t4e3l6ldu29r4834zsye2dv9s2h8t5f 1000 succeed.
bitcoind v27.0
lnd sendcoins bcrt1qlzjdmnhhglca7d6l6vpc89jkvly7hq9qs8g6kl 1000
rpc error: code = Unknown desc = unmatched backend error: -8: Fee rates larger than or equal to 1BTC/kvB are not accepted

Your environment

version of lnd : v0.17.2-beta
which operating system : Darwin Kernel Version 23.2.0 arm64
version of bitcoind: v27.0rc1

Steps to reproduce
Prepare regtest environment, start lnd with bitcoind v27.0 backend and execute the following command.
lnd sendcoins --addr <addr> --amt <amt>
Expected behaviour
Sendcoins should succeed.
Actual behaviour
Sendcoins fails with the following error.
rpc error: code = Unknown desc = unmatched backend error: -8: Fee rates larger than or equal to 1BTC/kvB are not accepted

Additional context
This is found in the peerswap operation check.
https://github.com/ElementsProject/peerswap/issues/289
Below is my guess.
Possible cause
maxfeerate is set to 1e8 / 10(sat/kb) as a parameter when calling SendRawTransaction.
But BTC/kvB is the expected value, so the units would be wrong.
Reason for error in v27.0
https://github.com/bitcoin/bitcoin/pull/29434 adds a sanity check for maxfeerate and does not accept values above 1BTC/kvB.
The error message in that case is

Fee rates larger than or equal to 1BTC/kvB are not accepted

I have created a PR to clarify my issue
https://github.com/btcsuite/btcd/pull/2142

Should still be open as we need to merge #8573 still.

Also seeing this on a sweep tx of a force close on testnet:
[INF] SWPR: Candidate sweep set of size=1 (+1 wallet inputs), has yield=0.00000159 BTC, weight=677
[INF] SWPR: Creating sweep transaction 270669fef2898be93b1711c8c5e46272e7da0565aa503ced16ed9ee5dcd7ac97 for 2 inputs (0b7e3cc018368257d4c3ec0e1da41a9cd5e1f489c1a864bf2091209d60029942:0 (CommitmentAnchor), 8d15a2f128a874e07f8ff221462d2f7df28bdc480320beab8fee100d0336f67a:7 (TaprootPubKeySpend)) using 253 sat/kw, tx_weight=725, tx_fee=0.00000183 BTC, parents_count=0, parents_fee=0 BTC, parents_weight=0
[INF] LNWL: Inserting unconfirmed transaction 270669fef2898be93b1711c8c5e46272e7da0565aa503ced16ed9ee5dcd7ac97
[INF] LNWL: 270669fef2898be93b1711c8c5e46272e7da0565aa503ced16ed9ee5dcd7ac97: broadcast failed because of: unmatched backend error: -8: Fee rates larger than or equal to 1BTC/kvB are not accepted
[INF] LNWL: Removed invalid transaction: 270669fef2898be93b1711c8c5e46272e7da0565aa503ced16ed9ee5dcd7ac97
[ERR] SWPR: input cluster sweep: unable to sweep inputs: publish tx: unmatched backend error: -8: Fee rates larger than or equal to 1BTC/kvB are not accepted

Thank you for your advice
I can see in the description:

bitcoind before v26.0
lnd sendcoins bcrt1qgy6djk4t4e3l6ldu29r4834zsye2dv9s2h8t5f 1000 succeed.

Does that mean it also happens with v26.1 same as v27?

The fix has been merged into master, so things should work now.
I think we're looking at making a v0.17.5 release for those that are quick to upgrade to the latest version of bitcoind.


Merge upstream subclassing support

Depends on gtk-rs/examples4#1.
Closes #2.
cc @sdroege @GuillaumeGomez

:+1:


Typings has

Signed-off-by: Jytesh<EMAIL_ADDRESS>Closes #69

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.728%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
312

Relevant Lines:
320

💛  - Coveralls

Nice work, thanks! 👍


ensemble.py:77: DeprecationWarning: imresize is deprecated!

If you follow the installation instructions and install a current version of scipy, you will end up with the following error:
Traceback (most recent call last):
  File "ensemble.py", line 82, in <module>
    x_test64 = resize(x_test)
  File "ensemble.py", line 77, in resize
    resized = scipy.misc.imresize(data_set[i], (64, 64))
AttributeError: module 'scipy' has no attribute 'misc'

after changing import scipy to import scipy.misc, the error will change to
Traceback (most recent call last):
  File "ensemble.py", line 82, in <module>
    x_test64 = resize(x_test)
  File "ensemble.py", line 77, in resize
    resized = scipy.misc.imresize(data_set[i], (64, 64))
AttributeError: module 'scipy.misc' has no attribute 'imresize'

A potential workaround I found was downgrading manually to scipy-1.2, but it still give this huge warning:
ensemble.py:77: DeprecationWarning: `imresize` is deprecated!
`imresize` is deprecated in SciPy 1.0.0, and will be removed in 1.3.0.
Use Pillow instead: ``numpy.array(Image.fromarray(arr).resize())``.
  resized = scipy.misc.imresize(data_set[i], (64, 64))

The DeprecationWarning should probably be fixed.

@brjathu it might be better to fix the DeprecationWarning, as this command has been deprecated already in SciPy 1.0.0.


Add support for send in server side

sbertin-telula patch for send in client was added to wakaama but not the server side.
So I fix the server side part.

I made a separate callback as you suggested

Nice, can you squash the "fix" commits and rebase your branch to the current upstream main branch, such that we get rid of the merge commits and have a nice linear commit history?

I rebase to main. I squish all the commits, not only the fix because of the rebase.


UKIS schema changes

What is the context of this PR?
Content Changes:
Wording changes and
Two additional blocks 9-9 and 9-10
Routing Changes:
If Question 6.14 (question2483) is shown then Section 7 (section611) and Section 8 (section612) should not be shown. Neither should the majority of blocks in Section 9 (section613). I have therefore split section 9 into 3 groups, the introduction (always shown), the group containing questions that can be skipped and a final group of blocks that are always shown.
Skip conditions are common across the 3 skipped groups (Section 7, 8 and 9b) and is the reverse of the skip condition on question 6.14.

@dwyeradam Worth sending a quick launch to someone from the business at this stage?

To fix the summary i'm going to have to change from skip conditions to routing instead.


add pages urls app label

Coverage increased (+0.007%) to 82.183% when pulling a05625ddea1e64366799ce6ff131c5a2c4e99009 on fix-pages-error into 1b541b00c4d7fd0f9aaa7f33798842c520ee345d on main.