Review scope

Review scope.rs.
More match and iter, less 'return'.
Improved mask_comment and mask_sub_scope (40% better in benches).

Hi @tafia,
This looks great, thanks for spending the time.
For me the jury is still out on the return vs no-return changes. I leave out return for functional one-liners, but when there are lots of lines in a function I find 'return' easier on the eye. Do you know if there are any rust guidelines or discussion on the subject?
I'll do some testing and then merge this tonight
Cheers,
Phil

I found this on HN, which agrees with your patch (no-unnecessary-return-at-the-end style)
https://news.ycombinator.com/item?id=8980516

OK indeed
It just feel more rust and I got used to it.
But I have no strong opinion on this particular point
On 2 Feb 2015 14:52, "Phil Dawes"<EMAIL_ADDRESS>wrote:

I found this on HN, which agrees with your patch
(no-unnecessary-return-at-the-end style)
https://news.ycombinator.com/item?id=8980516
—
Reply to this email directly or view it on GitHub
https://github.com/phildawes/racer/pull/130#issuecomment-72413386.

Rebased and removed some warnings with latest rust

D'oh! In my head I'd already merged this. Sorry, will do this tonight

It's really OK !
It is less important than breaking changes or new functionalities
integrated since then.
And I rode your message on racer update 4 ...
Thanks for the last paragraph !
On 6 Feb 2015 17:04, "Phil Dawes"<EMAIL_ADDRESS>wrote:

D'oh! In my head I'd already merged this. Sorry, will do this tonight
—
Reply to this email directly or view it on GitHub
https://github.com/phildawes/racer/pull/130#issuecomment-73206407.

Rebased again and added black_box for more honest benches

Thanks!


Query tests to new IT framework

Migrated the old query group tests to the new IT framework.
This PR migrates the following tests -
ITTwitterQueryTest
ITBroadcastJoinQueryTest
ITSqlCancelTest
ITSystemTableQueryTest
ITWikipediaQueryTest
ITJdbcQueryTest
ITUnionQueryTest

Closing this PR and will be creating a new PR with changes rebased.


Remove Tahoma

Hi. thanks for the app. Please don't ship Tahoma with it. Tahoma is copyright protected font https://www.myfonts.com/fonts/microsoft/tahoma/licensing.htm
Also please  other non-free fonts, you can easily find better and free ones from https://fontlibrary.org like https://fontlibrary.org/en/font/amiri

Thanks for the info. I will check other fonts insha Allah.
If you find any other font used in this project is in question, please let me know.
I will update those in the next release insha Allah.

I guess other than Droid Naskh, others are non-free probably and should be removed but other thank copright issue, there are good free fonts, http://old.arabeyes.org/project.php?proj=Khotot
We can also from @khaledhosny about more free fonts for a free Quran application.

Zajakallahu khairan brother, for your help.
Insha Allah in the next release I will clear the issue.

Assalamu 'Alaikum brother.
Sorry for being so late to handle the issue. Actually I was searching for a font to render Arabic perfectly with diacritics in my Android 4.2.2 to complete the next release to come.
By the way, I have removed tahoma.ttf. And indeed, I have found a very good font in the repository of   khaledhosny and included in this app. Thanks a lot for the link.
Now I have added these fonts being sure that they are free to use:
"jaghb_uni_bold.ttf,
"amiri-quran.ttf",
"amiri-regular.ttf",
"droid_naskh_regular.ttf",
"me_quran.ttf",
"siyamrupali.ttf"
If you see anything wrong please be kind to inform me about that.

Thank you. Of course by "free" I meant the more strict sense as being free and open source licensed (that I guess jaghb_uni and me_quran aren't) but the top priority was Tahoma removal which is already done :)


UnicodeDecodeError: 'utf8' codec can't decode

$ csv2ofx -ov -l PT-BR extrato-201609071200.csv extrato-201609071200.ofx
Traceback (most recent call last):
  File "/usr/local/bin/csv2ofx", line 20, in <module>
    run()
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/main.py", line 141, in run
    write(args.dest, IterStringIO(content), **kwargs)
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 691, in write
    return _write(filepath, content, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 679, in _write
    for c in ft.chunk(content, chunksize):
  File "/usr/local/lib/python2.7/site-packages/tabutils/fntools.py", line 248, in <genexpr>
    generator = (content.read(chunksize) for _ in it.count())
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 110, in read
    return self._read(self.iter, n)
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 103, in _read
    return ft.byte(it.islice(iterable, n)) if n else ft.byte(iterable)
  File "/usr/local/lib/python2.7/site-packages/tabutils/fntools.py", line 183, in byte
    tupled = tuple(content) if hasattr(content, 'next') else content
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 96, in <genexpr>
    return (s.encode(ENCODING) for s in iterable)
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/ofx.py", line 417, in gen_body
    for gd in data:
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/utils.py", line 130, in gen_data
    for group, main_pos, sorted_trxns in groups:
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/__init__.py", line 238, in clean_trxns
    for group, trxns in groups:
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/__init__.py", line 224, in gen_trxns
    for group, transactions in groups:
  File "/usr/local/lib/python2.7/site-packages/csv2ofx/ofx.py", line 451, in gen_groups
    for chnk in chunk(records, chunksize):
  File "/usr/local/lib/python2.7/site-packages/tabutils/fntools.py", line 263, in <genexpr>
    generator = (list(it.islice(i, chunksize)) for _ in it.count())
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 411, in read_csv
    for row in read_file(filepath):
  File "/usr/local/lib/python2.7/site-packages/tabutils/io.py", line 393, in read_file
    names = csv.reader(f, encoding=encoding, **kwargs).next()
  File "/usr/local/lib/python2.7/site-packages/unicodecsv/__init__.py", line 112, in next
    unicode_(value, encoding, encoding_errors)) for value in row]
UnicodeDecodeError: 'utf8' codec can't decode byte 0xd3 in position 10: invalid continuation byte

sample file:
"DATA";"HISTÓRICO DE DESPESAS";"TIPO";"VALOR"
"10/Ago";"COMPRA DÉBITO NACIONAL - SOME         -SAO PAULO-BRA";"Débito";"- R$ 999,99"

Turns out this is fixed for py3 but not py2. Need to push an upstream patch to meza to get py2 working.


there's a lot of TODOs iand missing implementatio in "several subtyping -> one supremum" constraint simplification

i'm hitting an undefined case with
typecheck_hs_from_string("function foo(w::Integer, x::Integer, y::Integer, z::Integer)
                         if z == 1
                            z = x + x + y - 3
                            5.0 * z
                          else
                             w = w + y/2
                             w + x
                          end
                         end" )

the function in question is named convertSubtypingToSupremum and lives in Subtyping.hs

Yes, that's the case that is easy to implement, right?


Open is set to false but its still opening in browser

Hey!
I have this set in the config:
...
file_dir="$HOME/Pictures/screenshots"
upload_connect_timeout="5"
upload_timeout="120"
upload_retries="1"
screenshot_select_command="scrot -s %img" # OS X: "screencapture -i
%img"
screenshot_window_command="scrot %img" # OS X: "screencapture -iWa %img"
edit_command="gimp %img"
edit="false"
exit_on_selection_fail="true"
edit_on_selection_fail="false"
exit_on_album_creation_fail="true"
open="false" // OPEN IS SET TO FALSE
log_file="$HOME/.imgur-screenshot.log"
copy_url="true"
keep_file="true"
check_update="true"

but when I take a screenshot, it still opens in Google Chrome.
Thanks.

Can you try with --debug as the first argument and paste the output here?

Here you go:

Looks like you got a syntax error in your config file:

end with '.png!'

/home/nahtnam/.config/imgur-screenshot/settings.conf: line 10: end: command not found
/home/nahtnam/.config/imgur-screenshot/settings.conf: line 27: unexpected EOF while looking for matching `"'
/home/nahtnam/.config/imgur-screenshot/settings.conf: line 28: syntax error: unexpected end of file

Ah yes.
Thanks a lot!