[YOUTUBE] ERROR: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract Initial JS player n function name...

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

==========================
TESTING NORMAL YOUTUBE-DL:
==========================

[debug] System config: []
[debug] User config: ['--no-mtime', '--match-filter', '!is_live', '--retries', 'infinite', '--fragment-retries', '3', '--skip-unavailable-fragments', '--restrict-filenames', '-i', '-o', '/home/gregorius/home/pending/videos/%(title)s___%(id)s.webm', '-f', '(bestvideo[height<=360]+worstaudio/best[height<=360])[protocol!=http_dash_segments][container!^=dash]', '--console-title', '--hls-prefer-native', '--no-cache-dir', '--cookies', '/home/gregorius/home/scripts/video/youtube-dl-cookies']
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=eMNXpZZBWFE', '-vf', '(242+249/242+250/242+171/242+251)/(243+249/243+250/243+171/243+251)/18', '--no-playlist', '-o', '/home/gregorius/home/scripts/video/TEST_NORMAL_%(title)s___%(id)s.webm']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Single file build
[debug] Python 3.10.12 (CPython x86_64 64bit) - Linux-5.15.0-124-generic-x86_64-with-glibc2.35 - OpenSSL 3.0.2 15 Mar 2022 - glibc 2.35
[debug] exe versions: ffmpeg 4.4.2, ffprobe 4.4.2, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] eMNXpZZBWFE: Downloading webpage
[youtube] Downloading just video eMNXpZZBWFE because of --no-playlist
[youtube] eMNXpZZBWFE: Downloading player 3bb1f723
WARNING: [youtube] Falling back to generic n function search
ERROR: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract \x1b[0;34mInitial JS player n function name\x1b[0m; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.
Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1637, in _decrypt_nsig
    jsi, player_id, func_code = self._extract_n_function_code(video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1719, in _extract_n_function_code
    func_name = self._extract_n_function_name(jscode)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1696, in _extract_n_function_name
    return self._search_regex(
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/common.py", line 1101, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract Initial JS player n function name; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.
Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1637, in _decrypt_nsig
    jsi, player_id, func_code = self._extract_n_function_code(video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1719, in _extract_n_function_code
    func_name = self._extract_n_function_name(jscode)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1696, in _extract_n_function_name
    return self._search_regex(
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/common.py", line 1101, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract Initial JS player n function name; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/YoutubeDL.py", line 875, in wrapper
    return func(self, *args, **kwargs)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/YoutubeDL.py", line 971, in __extract_info
    ie_result = ie.extract(url)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/common.py", line 571, in extract
    ie_result = self._real_extract(url)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 2137, in _real_extract
    self._unthrottle_format_urls(video_id, player_url, dct)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1754, in _unthrottle_format_urls
    n_response = decrypt_nsig(n_param)(n_param, video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1614, in inner
    raise ret
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1606, in inner
    self._player_cache[cache_id] = func(*args, **kwargs)
  File "/home/gregorius/home/scripts/video/youtube-dl-normal/youtube-dl/youtube_dl/extractor/youtube.py", line 1639, in _decrypt_nsig
    raise ExtractorError('Unable to extract nsig function code', cause=e)
youtube_dl.utils.ExtractorError: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract \x1b[0;34mInitial JS player n function name\x1b[0m; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.

===========================
TESTING NIGHTLY YOUTUBE-DL:
===========================

[debug] System config: []
[debug] User config: ['--no-mtime', '--match-filter', '!is_live', '--retries', 'infinite', '--fragment-retries', '3', '--skip-unavailable-fragments', '--restrict-filenames', '-i', '-o', '/home/gregorius/home/pending/videos/%(title)s___%(id)s.webm', '-f', '(bestvideo[height<=360]+worstaudio/best[height<=360])[protocol!=http_dash_segments][container!^=dash]', '--console-title', '--hls-prefer-native', '--no-cache-dir', '--cookies', '/home/gregorius/home/scripts/video/youtube-dl-cookies']
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=eMNXpZZBWFE', '-vf', '(242+249/242+250/242+171/242+251)/(243+249/243+250/243+171/243+251)/18', '--no-playlist', '-o', '/home/gregorius/home/scripts/video/TEST_NIGHTLY_%(title)s___%(id)s.webm']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2024.08.07 [c5098961b] (single file build)
[debug] ** This version was built from the latest master code at https://github.com/ytdl-org/youtube-dl.
[debug] ** For support, visit the main site.
[debug] Python 3.10.12 (CPython x86_64 64bit) - Linux-5.15.0-124-generic-x86_64-with-glibc2.35 - OpenSSL 3.0.2 15 Mar 2022 - glibc 2.35
[debug] exe versions: ffmpeg 4.4.2, ffprobe 4.4.2, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] eMNXpZZBWFE: Downloading webpage
[youtube] Downloading just video eMNXpZZBWFE because of --no-playlist
[youtube] eMNXpZZBWFE: Downloading player 3bb1f723
WARNING: [youtube] Falling back to generic n function search
ERROR: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract \x1b[0;34mInitial JS player n function name\x1b[0m; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.
Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1637, in _decrypt_nsig
    jsi, player_id, func_code = self._extract_n_function_code(video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1719, in _extract_n_function_code
    func_name = self._extract_n_function_name(jscode)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1696, in _extract_n_function_name
    return self._search_regex(
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/common.py", line 1101, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract Initial JS player n function name; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.
Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1637, in _decrypt_nsig
    jsi, player_id, func_code = self._extract_n_function_code(video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1719, in _extract_n_function_code
    func_name = self._extract_n_function_name(jscode)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1696, in _extract_n_function_name
    return self._search_regex(
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/common.py", line 1101, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract Initial JS player n function name; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/YoutubeDL.py", line 879, in wrapper
    return func(self, *args, **kwargs)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/YoutubeDL.py", line 975, in __extract_info
    ie_result = ie.extract(url)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/common.py", line 571, in extract
    ie_result = self._real_extract(url)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 2137, in _real_extract
    self._unthrottle_format_urls(video_id, player_url, dct)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1754, in _unthrottle_format_urls
    n_response = decrypt_nsig(n_param)(n_param, video_id, player_url)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1614, in inner
    raise ret
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1606, in inner
    self._player_cache[cache_id] = func(*args, **kwargs)
  File "/home/gregorius/home/scripts/video/youtube-dl-nightly/youtube-dl/youtube_dl/extractor/youtube.py", line 1639, in _decrypt_nsig
    raise ExtractorError('Unable to extract nsig function code', cause=e)
youtube_dl.utils.ExtractorError: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract \x1b[0;34mInitial JS player n function name\x1b[0m; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose option and include the complete output.

Description

Well, youtube-dl stopped working entirely now.
I updated both regular and nightly to what the GitHub Repos have, which was basically no update at all since months, despite other unrelated Youtube issues not being fixed yet (like inability to bulk download shorts because it cant parse a channels shorts page, or inability to download anything but simple formats like format 18 unless you run a workaround, or inability to specify maximum video length to be downloaded).
Anyways, looks like Youtube changed their webpage layout again since it's the regex that fails, meaning you cannot download ANYTHING now!

This is the same issue as yt-dlp/yt-dlp#11744. I have a fix similar to the PR applied in yt-dlp that will be pushed as soon as QA.

I should mention again that youtube-dl no longer works at all whatsoever for me, this is not just something i can workaround anymore, because it cant even parse the page of a direct video link.
This Issue has forced me to look into why youtube-dlp was not a drop-in replacement for youtube-dl on my setup, and I eventually found out that the Config File was ignored and that was the Issue I had, meaning I have switched to youtube-dlp and rewritten my Scripts now, and can no longer report Issues here in the future.

Please raise the config issue separately since an incompatibility such as you mention is not meant to exist as far as I know.

This is the error im getting on a AlmaLinux server...Maybe this will help.
[youtube] SvVS1_hWiZk: Downloading webpage
[youtube] SvVS1_hWiZk: Downloading player 3bb1f723
WARNING: [youtube] Falling back to generic n function search
ERROR: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract \x1b[0;34mInitial JS player n function name\x1b[0m; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; see  https://github.com/ytdl-org/youtube-dl/#user-content-installation  on how to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; see  https://github.com/ytdl-org/youtube-dl/#user-content-installation  on how to update. Be sure to call youtube-dl with the --verbose option and include the complete output.
Downloads from Python_videos.txt completed.
Downloading videos from /home/jeff/Desktop/Youtube//Computers/Docker/Docker_videos.txt...
Usage: youtube-dl [OPTIONS] URL [URL...]

Hi same problem but in my case on download meta data form youtube.
example in jenkins file download wideo and audio works.

stage('Download Video') {
            steps {
                timestamps {
                    ansiColor('xterm') {
                        sh'''
                            #!/bin/bash
                            set -e

                            # Sprawdzenie obecności youtube-dl
                            if ! command -v youtube-dl >/dev/null 2>&1;
                            then
                                echo "youtube-dl nie jest zainstalowane. Zainstaluj za pomocą: sudo apt install yt-dlp (lub odpowiednio skonfiguruj alias)"
                                exit 1
                            fi

                            # Sprawdzenie obecności ffmpeg w dowolnej lokalizacji
                            if ! command -v ffmpeg >/dev/null 2>&1; then
                                echo "ffmpeg nie jest zainstalowany. Zainstaluj za pomocą: sudo apt install ffmpeg"
                                exit 1
                            fi

                            echo "GET ALL youtube-dl format video"
                            echo " "
                            youtube-dl -F "${YOUTUBE_VIDEO_URL}"
                            echo " "

                            echo "Start download best video: 4K, HD, SD"
                            video_url="${YOUTUBE_VIDEO_URL}"

                            # Lista preferowanych formatów (priorytet: 337, 315, 335, 299, 298)
                            preferred_formats="337+140/315+140/335+140/299+140/298+140"

                            # Pobierz wideo w najlepszym dostępnym formacie
                            echo "Downloading best available format..."
                            youtube-dl -f "$preferred_formats" -o "%(title)s.%(ext)s" "$video_url"

                            # Konwersja plików MKV na MP4, jeśli są dostępne
                            for i in *.mkv; do
                                if [ -f "$i" ]; then
                                    echo "Converting $i to MP4..."
                                    ffmpeg -i "$i" -c copy "${i%.*}.mp4"
                                    rm "$i"
                                fi
                            done

                            echo "Download and conversion completed."
                        '''
                    }
                }
            }
        }
        stage('Download audio') {
            steps {
                timestamps {
                    ansiColor('xterm') {
                        sh'''
                            set -e
                            youtube-dl -f m4a -o "%(title)s.%(ext)s" ${YOUTUBE_VIDEO_URL}
                        '''
                    }
                }
            }
        }

when i try download meta data from youtube this error show:
stage('Download video descryption and metadata') {
            steps {
                timestamps {
                    ansiColor('xterm') {
                        sh'''
                            set -e
                            youtube-dl --write-description --skip-download -o "%(title)s.%(ext)s" ${YOUTUBE_VIDEO_URL}
                            title=$(youtube-dl --get-title --skip-download -o "%(title)s.%(ext)s" ${YOUTUBE_VIDEO_URL})
                            echo "${title}" > ${title}.title
                            youtube-dl --write-info-json --skip-download -o "%(title)s.%(ext)s" ${YOUTUBE_VIDEO_URL}
                            python3 get_tags.py "${YOUTUBE_VIDEO_URL}"
                        '''
                    }
                }
            }
        }

Error info:
19:34:18    File "/usr/local/lib/python3.10/dist-packages/youtube_dl/extractor/youtube.py", line 1606, in inner
19:34:18      self._player_cache[cache_id] = func(*args, **kwargs)
19:34:18    File "/usr/local/lib/python3.10/dist-packages/youtube_dl/extractor/youtube.py", line 1639, in _decrypt_nsig
19:34:18      raise ExtractorError('Unable to extract nsig function code', cause=e)
19:34:18  youtube_dl.utils.ExtractorError: Unable to extract nsig function code (caused by RegexNotFoundError('Unable to extract Initial JS player n function name; please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; see  https://github.com/ytdl-org/youtube-dl/#user-content-installation  on how to update. Be sure to call youtube-dl with the --verbose option and include the complete output.')); please report this issue on https://github.com/ytdl-org/youtube-dl/issues , using the appropriate issue template. Make sure you are using the latest version; see  https://github.com/ytdl-org/youtube-dl/#user-content-installation  on how to update. Be sure to call youtube-dl with the --verbose option and include the complete output.

If yt-dlp fixed this in _extract_n_function_name(), and ytdl has function with basically the same name and same function/purpose, then is it possible to adapt it to 'our' case?

To jest ten sam problem, co w przypadku yt-dlp/yt-dlp#11744 . Mam poprawioną wersję do PR , która zostanie opublikowana po kontroli jakości.

This erroe still is in version https://github.com/yt-dlp/yt-dlp/releases/tag/2024.12.06
I used this version, I only changed the name to match my jenkins pipeline (executable file)
https://github.com/ytdl-org/youtube-dl/issues/32986#issuecomment-2530602819

@TheRealMamuth If you have an issue with yt-dlp, please open an issue there. youtube-dl and yt-dlp are different projects. You are the first person that reported the fix in yt-dlp 2024.12.06 not working.

@TheRealMamuth If you have an issue with yt-dlp, please open an issue there. youtube-dl and yt-dlp are different projects. You are the first person that reported the fix in yt-dlp 2024.12.06 not working.

thx - open issue yt-dlp https://github.com/yt-dlp/yt-dlp/issues/11781

It seems to be fixed in #32987. Tried that and it worked. One can test it here (md5: e2e8b4a7cb7a40221b3b72003a43e5df), before it is released.

As @seproDev kindly and accurately commented, PR #32987 is somewhat misguided. Some fool maintainer relied on the implementation of JS string comparisons that some fool maintainer may have introduced in passing without matching tests, leading to a solution that apparently solved the issue but should not have. However, it is not unrecoverable.
Obviously anyone who wants to use the current PR code may do so but it could fail at any time; also, it will probably be force-pushed out by a better working solution.
In this new player, the challenge JS is testing the type of a variable that is set in a declaration outside the challenge JS, but that is still in scope. The (intended, I guess) effect is that the challenge JS returns the original nsig value if it doesn't know about the variable binding, and so 403 (nowadays) on download.
The yt-dlp solution was to hard-code (a pattern matching) the guilty test and remove it from any challenge JS. This is effective and could be generalised to some extent, but seems unsatisfactory.
As we aren't going to be processing the whole player JS, some better hack is needed. Maybe there could be some way in which typeof varName in the challenge JS could search for var varName = ... in the whole player JS, but again there are endlessly many other ways in which the binding could have been created.
A direct and also effective tactic can be to hook the evaluation of return returnValue; such that if returnValue is the original nsig value the statement behaves like void returnValue; instead, and the challenge keeps on running. Our interpreter doesn't know anything about nsig values, but the YT extractor can bind a magically named variable when calling the challenge code; then the interpreter can secretly look at that variable and not return returnValue; when returnValue matches the value of the magic variable. This is fine until the challenge starts raising an Exception (same technique can be applied) or mixing the value of the alien variable into the challenge calculation.

when are you going to release a new version with the fix?
Thank you very much

when are you going to release a new version with the fix?
Thank you very much

yt-dlp works fine. If in your code you use youtube-dl just download binary of yt-dlp and change name to youtube-dl. It my case works fine

when are you going to release a new version with the fix?
Thank you very much

Looking forward to it too

yt-dlp works fine. If in your code you use youtube-dl just download binary of yt-dlp and change name to youtube-dl. It my case works fine

Indeed works well. Great and thank you very much


[Suggestion] Add a logout button

It would be nice to be able to log out by clicking a button.

@mattman86 I completed this last night, just forgot to push the commit.  I'll get that out soon.

@mattman86 Logout button is now active: https://github.com/causefx/iDashboard-PHP/archive/0.99-3.zip


autoread

knx js library had object Datapoint which provides the autoread function. On startup all configured ga status are fetched by a groupvalue read. This is helpful for eg visualizations.
Please add similar functionality.

Hi
I cannot do that. The API doesn’t create GA objects. It works differently from the knxjs api.
You should simply do it manually after the connection has been established.

sure, but isnt this a feature that most users of a library would need? I've seen it in other implementations and there is a reason why knxjs implemented it.

Hi Franz
Nope. Knxjs works in it’s own way. KNXUltimate works differently. It’s up to you to create your own array containing the GA. Thanks to the “indication” event, you can get every single KNX telegram and change/update your array, even using powerful logic (for example, you can create an object containing the command GA and the status GA and handle in a more sophisticated way than knxjs.

Sorry that I dont understand what is working differently here that restricts having the feature. Is a common use case that after a device reset internal status intformations across devices are not in sync since knx is mostly sending trigger based. Visualisations do it, there's a read on init flag defined

Look again at the readme and samples. I’ve implemented some changes. You should better understand how it works now.

Thank you for the example. But the question of this issue is not the acknowledgement, it is why KNXUltimate is not doing autoread. You worte it works differently but did not explain this design decision


a proposed fix to the strokeCap issue number #44

As I have mentioned that I was facing an issue with the strokeCap={'round'} prop, I was able to figure out what the issue might be, and I decided to push a PR for the proposed fix. NB: this is happening on "version": "1.1.2".
This is related to issue number #44

I think this will break this use case:

After applying your changes I see this:

You also have merge conflicts as I just merged https://github.com/nihgwu/react-native-pie/pull/40 which ran prettier on the Pie.js file.

@SiyabongaNzulwana ready for review again?

@zgordon01 Yes, its ready...

This same line is currently causing our app to crash because the is no const before the variable name. Would you consider updating this, and then @nihgwu can we get this merged in?
My guess is this repo is abandoned at this point, but hopeful!

@CarolynWebster Sorry I don't use RN for years, but if you can confirm this PR works, I'll update your propose directly and merge it


Infinite package restore loop on designtime in visual studio

Is noted in this issue at the dotnet team:
https://github.com/dotnet/project-system/issues/1457

Added comment to the dotnet team since I can not seem to get the proposed solutions to work.

Updated proposed solution works :)

Issue was closed before it was resolved on other projects.


Add doc for johnson_alahi_li_2016

@jbueltemeier Please rebase from the current master. In #122 and #123 I've added the framework to "see the doc strings in action".

Test failure is unrelated. www.wassilykandinsky.net seems to be down.


[MINOR][DOCS] Fix more typos in comments/strings.

What changes were proposed in this pull request?
This PR fixes 135 typos over 107 files:

121 typos in comments
11 typos in testcase name
3 typos in log messages

How was this patch tested?
Manual.

Test build #53044 has started for PR 11689 at commit 2749fe6.

Test build #53044 has finished for PR 11689 at commit 2749fe6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53044/
Test FAILed.

Test build #53045 has started for PR 11689 at commit e2d3def.

Test build #53045 has finished for PR 11689 at commit e2d3def.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53045/
Test FAILed.

Test build #2632 has started for PR 11689 at commit e2d3def.

Test build #2632 has finished for PR 11689 at commit e2d3def.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Heh, yeah nice one. We had a few one-typo PRs recently so glad to see you tried to fix just about every last one at once. Merging to master ...

Thank you, @srowen . :)


[WIP] Enable CDC configuration for cross language StorageWrite API usage

This change enables the configuration of CDC usage for the BigQueryStorageWriteApiSchemaTransformProvider.
By setting configuration.setUseCDCWrites(true) on the provider's config, the transform creation will check for a Row schema like:
{
  cdc_info:{
    mutation_type: "..."              // can be UPSERT or DELETE
    change_sequence_number: "..."     // used for custom insert ordering
  }
  record:{...}                        // actual data to be inserted
}

The implementation also enables the possibility of setting a dynamic destination alongside with CDC usage by using this Row schema:
{
  cdc_info:{
    mutation_type: "..."              // can be UPSERT or DELETE
    change_sequence_number: "..."     // used for custom insert ordering
  }
  destination: "..."                  // destination table for the data
  record:{...}                        // actual data to be inserted
}

In case of using dynamic destination and CDC is only supported when all the destination share the same primary key columns.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

fixes #32527

@ahmedabu98 FYI

completed python integration on #32529


Vertical line italicized

In Roboto-Italic, | U+007C is italicized. This seems contrary to convention.

I think this could be trivially solved by adding the glyph to the "noitalic" list in res/roboto.cfg. @roozbehp, is this something that should be addressed?

I think so. Common Windows fonts seems to have an upright | too.
@raphlinus can you comment please?


License

Figure out what license to use for this.

GNU v2?

Maybe we should actually use the Eclipse Public License ?

Maybe we should use this license that every clojure project seems to use?

Anything works for me. Personnally, I prefer MIT, but GPLv2 and EPL works as well.

Let's just go with MIT and Close this issue already


Specifying volume parameters at the PVC

I would like to specify volume parameter when creating a PVC, rather that having an array of different StorageClasses. It's not clear from the docs whether this is possible.

We have "allowOverride" parameter in the storage class. With this, you can override the volume parameters in the PVC spec.
Please refer to "Test and verify Persistent Volume Claim overrides" in https://github.com/hpe-storage/csi-driver/blob/master/USING.md for more details/examples.

Ah just what I'm looking for! Thanks


1.6.19 Chart History View period always resets to showing 10 days on cloud sensor sync

Description:
User has few local sensors and has also signed into Ruuvi cloud and is syncing some sensors from cloud service.
He has configured Chart History View Period to 1 day in Chart Settings
Actual:
Local BT sensors charts will now show 1 days view in charts view
Cloud sensors charts view will reset to 10 days when cloud sensor data is synced
Expected:
Use local setting for charts view

I couldn't reproduce this issue. Tried with 1 and 2 days settings.

Looks like I've created duplicate of this task and linked fixes to it
https://github.com/ruuvi/com.ruuvi.station/issues/593


add-diffblue-tests

The test cases contained in this PR were automatically generated by Diffblue's Deeptest software. Please feel free to merge them into your repository.
These tests are part of a batch of 192 in total, providing an approximate increase of 6% in line coverage according to JaCoCo.
We would be happy to provide further tests via a subsequent PR.
Results for various open source projects can be viewed at:
http://diff.blue/demo
We welcome any feedback you have on these tests.

Should you choose to merge this pull request, we require you to add a license to the repository.Apache 2.0 is the license we recommend. If this is not possible than potential alternatives include MIT, BSD 2 clause or ISC.


TypeError: dsig.createSignature is not a function.

I am using the code given in the Readme.txt. But I am getting TypeError: dsig.createSignature is not a function. What am I missing.

Looks like the readme is out of date. You might have luck with:
var DigitalSignature = require('xml-dsig);

var dsig = new DigitalSignature();

dsig.createSignature(...);

I haven't touched this code for ages though, and I have no use for it anymore, so you might have to go digging around in the source (like I just did) to figure out any other problems.


Empty reply from server when hitting admin api

I appreciate this probably isn't a bug, but can't figure out why this is isn't working.
After install, Kong starts ok, but I get "Empty reply from server" when hitting the admin api on the default port 8001.  I am running on MAC OSX 10.14.3.  The process appears to be listening on port 8001.  I am using the default kong configuration.  I am starting with "kong start".
 You can unlink it:
  brew unlink nginx

To force the link and overwrite all conflicting files:
  brew link --overwrite openresty

To list all files that would be deleted:
  brew link --overwrite --dry-run openresty

Possible conflicting files are:
/usr/local/bin/nginx -> /usr/local/Cellar/nginx/1.15.10/bin/nginx
==> Summary
🍺  /usr/local/Cellar/openresty/<IP_ADDRESS>: 309 files, 6.3MB, built in 3 minutes 37 seconds
==> Installing kong/kong/kong
==> Downloading https://bintray.com/kong/kong-community-edition-src/download_file?file_path=dists%2Fkong-community-edition-
Already downloaded: /Users/hornchris/Library/Caches/Homebrew/downloads/8e8d7163964e17481b1fc37c779eb01156cf3bc23e1272885eaff75699e1629c--kong-community-edition-1.1.1.tar.gz
==> Patching
patching file kong/templates/kong_defaults.lua
==> /usr/local/opt/luarocks/bin/luarocks --tree=/usr/local/Cellar/kong/1.1.1 --lua-dir=/usr/local/opt/openresty/luajit make
Warning: This keg was marked linked already, continuing anyway
🍺  /usr/local/Cellar/kong/1.1.1: 1,021 files, 7.9MB, built in 3 minutes 7 seconds

Kong starts
$ kong start
2019/04/09 13:38:59 [warn] ulimit is currently set to "256". For better performance set it to at least "4096" using "ulimit -n"
Kong started

Curl to port 8001 fails
$ curl -i localhost:8001
curl: (52) Empty reply from server

Process is listening in port 8001
$ lsof -nP -i4TCP:8001 | grep LISTEN
nginx   63104 hornchris   12u  IPv4 0xa14779bc56db2cd7      0t0  TCP <IP_ADDRESS>:8001 (LISTEN)
nginx   63105 hornchris   12u  IPv4 0xa14779bc56db2cd7      0t0  TCP <IP_ADDRESS>:8001 (LISTEN)
nginx   63106 hornchris   12u  IPv4 0xa14779bc56db2cd7      0t0  TCP <IP_ADDRESS>:8001 (LISTEN)
nginx   63108 hornchris   12u  IPv4 0xa14779bc56db2cd7      0t0  TCP <IP_ADDRESS>:8001 (LISTEN)
nginx   63118 hornchris   12u  IPv4 0xa14779bc56db2cd7      0t0  TCP <IP_ADDRESS>:8001 (LISTEN)

Curl to port 8000 works
$ curl -i localhost:8000
HTTP/1.1 404 Not Found
Date: Tue, 09 Apr 2019 13:09:38 GMT
Content-Type: application/json; charset=utf-8
Connection: keep-alive
Content-Length: 48
Server: kong/1.1.1

{"message":"no Route matched with those values"}

Nginx seems not to be configured properly
$ nginx
nginx: [alert] could not open error log file: open() "/usr/local/Cellar/openresty/<IP_ADDRESS>/nginx/logs/error.log" failed (2: No such file or directory)
2019/04/09 14:11:41 [emerg] 63633#0: open() "/usr/local/Cellar/openresty/<IP_ADDRESS>/nginx/logs/access.log" failed (2: No such file or directory)

Additional Details & Logs

Kong version ($ kong version)
Kong debug-level startup logs ($ kong start --vv)
Kong error logs (<KONG_PREFIX>/logs/error.log)
Kong configuration (the output of a GET request to Kong's Admin port - see
https://docs.konghq.com/latest/admin-api/#retrieve-node-information)
Operating system

Please see: https://github.com/Kong/kong/issues/4471#issuecomment-481989146


Add SweetXml.transform_by/2.

Pull request for issue https://github.com/awetzel/sweet_xml/issues/24, to support complex value transformation.

Hello @seantanly ,
I love your idea, just one remark :
I would think as a user better that in case of list, transform_fun would be applied to all elements instead of applying it to the list (since the "maps" keywords apply to every element on a list).
https://github.com/seantanly/sweet_xml/blob/transform_by/lib/sweet_xml.ex#L407-L411
Do you agree ?

Good catch. For simple case, applying the transform_fun to every element on list is more convenient.
However, it could be semantically inconsistent. Transform by is meant to transform whatever raw output that SweetXpath produces, be it a list, nodes, string, float, integer, etc. This gives the most flexibility and allows easy compatibility with existing code.
If we treat list as a special case, and apply the transform_fun to each element instead, we would lose the ability to process the list as a whole, e.g. reducing a set of nodes into a single set of statistics. Existing code that does this will not be able to make use of it then.

@awetzel I have just rebased the pull request based on master, the merge conflicts should be gone and tests should all pass now.

OK published to 0.6 , there is only a missing README

Do you mean there is a missing section explaining how to use transform_by/2?
I have already taken the liberty and add a Transform by section in the README.md. Feel free to make any amendment/improvements. :)

Ah ok perfect then :) I missed it


Support InputStream/OutputStream

Coverage increased (+0.02%) to 99.102% when pulling 2d6ed56e3ce6a49b21b5635db7fb550944462567 on dota17:stream into 208d3082cd5cdab39da8873cf741f8b672d1af5b on super-csv:master.


translationa BearingFriction brocken

Reported by joerg.ungethuem on 13 Nov 2008 09:07 UTC
Modelica.Mechanics.Translational.Components.SupportFriction does not work. See test model and compare the results with friction-less and analogous rotational models.

Migrated-From: https://trac.modelica.org/Modelica/ticket/119

Comment by joerg.ungethuem on 13 Nov 2008 11:07 UTC
Replying to [ticket:119 joerg.ungethuem@…]:

Modelica.Mechanics.Translational.Components.SupportFriction does not work. See test model and compare the results with friction-less and analogous rotational models.

Sorry, file attachment does not work for me.
Please contact me per pm.

Comment by AHaumer on 17 Nov 2008 11:17 UTC
Fixed by a3c4edcc156d785676f5f73895910833b5984778 vor trunk, as well as 132667c1ed67f7f81d4e33d4d0ec525bb4dcd188 for maintenance\3.0 and maintenance\3.0_ImprovedFriction (who knows which weird version this is???)

Modified by dietmarw on 25 May 2009 09:00 UTC

Modified by beutlich on 12 Dec 2016 21:43 UTC

Changelog removed by beutlich on 12 Dec 2016 21:43 UTC


WIP reproduce FETCH invalid message set issue

Cc @woj-tek

(what's the best way to proceed with this? should I use gh pr checkout 2385 and then create new branch locally?

Yes

I think I can't push to this pr/branch directly?)

Only ASF james commiters can edit this PR, yes.
I think it is easier to open a new branch, new PR, cherry-pick my work then close this one.

I am not fan of basing a decision (skip the data) on a projection (the state of the local in-memory data structure "Selected Mailbox" may be temporarilry out-of-date especially in a distributed setup)
On the example provided the MSN id set conversion 1:* bear the meaning all messages and it would make sense to me to convert it into MessageRange.all(). (right now we are translating 1:* into MessageRange.of(firstUid, MessageUid.MAX).
This would even make sens regarding performances as downstream code akka the mailbox is optimized to handle MessageRange.all().
Thoughts?

CF https://github.com/apache/james-project/pull/2386


azd should not create multiple containers when two postgres.database.v0 Aspire resources share the same parent.

Currently when azd encounters an AppHost with multiple postgres.database.v0 resources it will create a container for each database. This is not desirable. Instead azd should create a single database server, and then inject variations of the connection string for each database that would be hosted on that server.
Developers also need to get a connection string to the database server (whether it is a container or hosted on a managed service).
Workaround:
As a temporary work around developers can pass a reference to the database and then create a new connection after trimming off the database specific entry. We should aim to fix this up for preview 3 so this isn't necessary.

I wonder - are we going to have to do anything special to ensure these databases are created when using the ACA postgres service?  I know when using something like the postgres container you can set an environment variable for the initial database that is created, but I am wondering if you need to run CREATE DATABASE calls for the other databases - or is that something the Aspire component will do as part of booting up?
When we map this to something like Postgres Flexible Server, it seems there's a bicep resource that models the database separate from the account, so the mapping in that world is clear: https://learn.microsoft.com/en-us/azure/templates/microsoft.dbforpostgresql/flexibleservers/databases?pivots=deployment-language-bicep

Like @ellismg mentions, this is definitely straightforward when it's a managed resource (prod). For container app add-ons (dev), there isn't a straightforward option without extra weight on azd or additional support from ACA.
azd currently uses the ACA provided postgres container image / add-on service, which is built upon the official postgres image. The ACA add-on service does additional things like automatically configure pg-password as a Container App secret, and assumes single DB setup. Thus, we could make an ask here to support multiple database setups if we were to stick to the ACA provided postgres add-on service.
If we or ACA were wanting to configure this using the official postgres image, we'd need configure a mounted initialization script with the docker image to create multiple DBs. The easiest way is probably to simply create a derived docker image with something similar looking to this.


Allow uploading drivers license like we do on OldDot

Details
These changes only affect web. I noticed that we do not allow uploading a driver's license on NewDot but do on OldDot. When selecting Identity card option Onfido will not allow me to upload by state driver's license. This PR fixes that by enabling the specific option for driver's licenses.

Fixed Issues
$ https://github.com/Expensify/App/issues/5395
Tests

Go through VBA flow for a Verifying bank account
When you reach the Onfido flow verify there is an option for a driver's license
Upload a US Driver's License
Verify you are able to do so without issue and pass the Onfido step

QA Steps
Internal QA
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
N/A iOS
N/A Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @AndrewGable in version: 1.1.1-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@marcaaron can you let us know when this is QAd so we can check it off the list?

Worked great for me.

Tested too - works great

🚀 Deployed to production by @timszot in version: 1.1.2-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Ideas for a better CSS

While porting the Less framework to Sass, I've got some ideas for improving the CSS structure.
In my experience, following some of the suggestions explained in the CSS guidelines would lead to a cleaner and maintainable CSS. In particular, I'd avoid deep nesting with the adoption of a BEM-like naming syntax, which would allow developers to easily extend the base CSS without the need to understand its structure by reading both the CSS and the javascript.
As example, take the current input.less:
.mui-input {
  textarea {
    &:focus {
      &+.mui-input-placeholder {
        &+.mui-input-highlight {
          &+.mui-input-bar {
            &+.mui-input-description {
            }
          }
        }
      }
    }
  }
  input {
    &:focus {
      &+.mui-input-placeholder {
        &+.mui-input-highlight {
          &+.mui-input-bar {
            &+.mui-input-description {
            }
          }
        }
      }
    }
  }
}

This could become:
.mui-input { // container. Nothing is nested here }

.mui-input__textarea           { } // <textarea />
.mui-input__textarea--focused  { } // <textarea:focus />
.mui-input__textfield          { } // <input />
.mui-input__textfield--focused { } // <input:focus />

.mui-input__highlight   { } //

.mui-input__placeholder { } //

.mui-input__bar         { } //

.mui-input__description { } //

.mui-input__highlight--focused   { }
.mui-input__placeholder--focused { }
.mui-input__bar--focused         { }
.mui-input__description--focused { }

// not a fan of this kind of selectors, but having textearea and inputs
// in the same component we would need something like that:
.mui-input__textarea ~ .mui-input__highlight--focused {
  // Readable way to indicate the focused highlight element when sibling of texture
}

.mui-input__textfield ~ .mui-input__highlight--focused { }

I admit the case of the <mui.Input /> is interesting since there's a lot going on there. So with the CSS above and starting from the following JSX:
<textarea class="mui-input__textarea" ref="field" onFocus={this._onFocus } />

we would add the --focused modifier with _onFocus method:
_onFocus() {
  this.refs.field.addClass('mui-input__textarea--focused');
  this.refs.highlight.addClass('mui-input__highlight--focused');
  this.refs.placeholder.addClass('mui-input__placeholder--focused');
  this.refs.bar.addClass('mui-input__bar--focused');
  this.refs.description.addClass('mui-input__description--focused');
}

Apart from the sibling selector, which I would solve using another component like <mui.Textarea />, this pattern looses the nesting structure and makes it easier to control the content of a mui-inputs container.
It also would help a hopeful javascript refactoring in the future, since it does not fit well with nested selectors.
What do you think?

Maybe use SUITCSS? Borrow many ideas from BEM.

This has been cleaned up with TextField. :)


[$250] Web - Profile - Changes made in offline mode are not saved

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing #11371
Action Performed:

Log in any account
Navigate to Settings > Profile
Disable the internet connection in the device
Modify first name, last name, and your timezone
Save and verify everything looks like it updated correctly
Click back button to go back to settings page
Click profile and verify changes are preserved
Click back button to go back to settings page again
Go back online
Click on the Profile and check

Expected Result:
Correct data should be still in your profile
Actual Result:
Changes made in offline mode are not saved.
Correct data is shown only after refreshing the page.
Workaround:
Refreshing the page fixes the issue
Platform:

Where is this issue occurring?

Web

Version Number: v1.2.12-0
Reproducible in staging?: Y
Reproducible in production?: new feature - save button disabled in offline in production
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/194371484-1054e723-c724-402b-86c3-73a24c7e628e.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

I am confused, does this not mean that https://github.com/Expensify/App/pull/11371 is broken @Julesssss ?

@flodnv it does, but I don't actually see the same result...
https://user-images.githubusercontent.com/10736861/194573739-89415103-d829-40ab-847d-65326757f93f.mov
Hi @kavimuru, perhaps there is an extra step that you did that I missed? Because I can't reproduce with those steps above (web)

Ping @kavimuru ?

@Julesssss @flodnv Still able to reproduce. Edited the steps and adding a new video
https://user-images.githubusercontent.com/43996225/194971354-cc49e1a6-589f-41c8-ab32-b1a4cca67a7c.mp4

Okay, I also see this bug. Let's treat this as a separate issue as the steps are slightly different from the original issue.

Proposal
Problem

Currently, in offline mode when user edits profile and clicks save button, this action will add in networkRequestQueue, and will be called back if back online.
When app reconnects, api?command=ReconnectApp will be called to refresh data and api?command=UpdateProfile to update new user profile asynchronous. So user data has not been updated in time on BE, api?command=ReconnectApp will return old user data.
Please check the evidences below:

Solution
In https://github.com/Expensify/App/blob/299f07bfa29c0dd81a6126691aae29e161097baa/src/libs/actions/App.js#L119 we'll change read method to write method to add api?command=ReconnectApp to SequentialQueue to call synchronous
-  API.read('ReconnectApp', { policyIDListExcludingWorkspacesCreatedOffline }, {
+  API.write('ReconnectApp', { policyIDListExcludingWorkspacesCreatedOffline }, {

https://user-images.githubusercontent.com/58692355/195333665-afa544c9-7d4d-42eb-837b-6e9ce4eceab0.mp4

Proposal
Problem

Currently, in offline mode when user edits profile and clicks save button, this action will add in networkRequestQueue, and will be called back if back online.
When app reconnects, api?command=ReconnectApp will be called to refresh data and api?command=UpdateProfile to update new user profile asynchronous. So user data has not been updated in time on BE, api?command=ReconnectApp will return old user data.
Please check the evidences below:

Solution
In https://github.com/Expensify/App/blob/299f07bfa29c0dd81a6126691aae29e161097baa/src/libs/actions/App.js#L119 we'll change read method to write method to add api?command=ReconnectApp to SequentialQueue to call synchronous
-  API.read('ReconnectApp', { policyIDListExcludingWorkspacesCreatedOffline }, {
+  API.write('ReconnectApp', { policyIDListExcludingWorkspacesCreatedOffline }, {

https://user-images.githubusercontent.com/113963320/195336254-9d12b87c-61ba-4f04-b19c-b521e6de298c.mp4

Awaiting a review from @thesahindia, dropping the priority to weekly

I wasn't able to consistently repro this but yeah the proposal looks good to me and is working correctly.
C+ reviewed 🎀👀🎀
cc: @Julesssss

Awaiting a review from @thesahindia, dropping the priority to weekly

👎 Reviews should be done at least on a daily basis (and ideally several times a day: the most important thing one can do is unblock others)

I meant a proposal review, not a code review. But perhaps the same priority applies?

Yes, as per the bot reapplying the daily label :)
On Mon, Oct 17, 2022, 16:28 Jules @.***> wrote:

I meant a proposal review, not a code review. But perhaps the same
priority applies?
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/11632#issuecomment-1281054647,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7Y2OMYCD6WHQ5GLQDVDALWDVWDVANCNFSM6AAAAAAQ62A4TI
.
You are receiving this because you were mentioned.Message ID:
@.***>

👎 Reviews should be done at least on a daily basis (and ideally several times a day: the most important thing one can do is unblock others)

Thanks, will remember next time.

@Julesssss Could you please send the Upwork link that I can apply to? thanks

Upwork job posting: https://www.upwork.com/jobs/~011b81a6da237bb2ea

Thanks @sakluger, I applied to the job and the PR will be ready by October 21

Issue not reproducible during KI retests. (First week)

Does Melvin think this was a regression? It wasn't

@sakluger @Julesssss @thesahindia @tienifr This is still not fixed unfortunately https://github.com/Expensify/App/issues/12355 I have just tested on iOS staging and the old name comes back after a while

Issue not reproducible during KI retests. (Second week)

Confirmed this is now fixed in staging after latest deploy and we are good to pay the contributor out today @sakluger

Bumping for payment (to remove the outdated label)

Hey @sakluger, can you please pay out, or close the issue if we have already paid? Thanks

@sakluger, payment is pending.

👋 Sorry for the delay on our side. Stepping in to process this to completion today. @thesahindia @tienifr offers have been sent to you both.

Accepted, thanks!

Perfect, paid you both out. Thanks again! 🚀


Where are PowerApps and PowerAutomate Flows in the Default Environment displayed ?

Hi
Where are PowerApps and PowerAutomate Flows in the Default Environment shown in the CoE ?
eg those generated by SharePoint.
Thanks
Nigel

Hello,
apps and flows from Default environment are displayed like from any other environment and on all pages you should find an "Environment" filter (in the grey area on the right hand side) to filter down to only display resources in the Default environment.
For SharePoint specific, see https://github.com/microsoft/powerapps-tools/issues/848
Thank you for using the CoE,
Manuela


Packages from the local npm repository with a slash in their names are not loaded

Describe the bug
I set up verdaccio as a local npm repository, and set up yarp as a proxy. When using verdaccio directly, packages with a slash are downloaded, but not with a proxy
To Reproduce
This behavior is reproduced only on packages where there is a slash in the name or in the dependencies of packages there are packages in the name of which there is a slash. Packages without slashes are downloaded without problems.

Run verdaccio using docker docker run -it --rm --name verdaccio -p 4873:4873 verdaccio/verdaccio
Open or create some frontend project (I use react and yarn) and try add package use local repository yarn add --registry http://localhost:4873 @babel/core . The package will be added.
Create yarp project

code:
var builder = WebApplication.CreateBuilder(args);

builder.Services.AddReverseProxy()
    .LoadFromConfig(builder.Configuration.GetSection("ReverseProxy"));
var app = builder.Build();

app.MapReverseProxy();
app.Run();

appsettings:
{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft.AspNetCore": "Warning"
    }
  },
  "AllowedHosts": "*",
  "ReverseProxy": {
    "Routes": {
      "npm": {
        "ClusterId": "cluster-npm",
        "Match": {
          "Hosts": [ "localhost" ],
          "Path": "{**catch-all}"
        },
        "Transforms": [
          { "RequestHeadersCopy": "true" },
          { "RequestHeaderOriginalHost": "true" },
          {
            "X-Forwarded": "Append",
            "HeaderPrefix": "X-Forwarded-"
          }
        ]
      }
    },
    "Clusters": {
      "cluster-npm": {
        "Destinations": {
          "destination1": {
            "Address": "http://localhost:4873"
          }
        }
      }
    }
  }
}

Run proxy and try add package use local repository with proxy yarn add --registry http://localhost:5184 @babel/core . The package will not be added with error

error An unexpected error occurred: "http://localhost:5184/@babel%2fcore: invalid package".

log yarp
info: Yarp.ReverseProxy.Forwarder.HttpForwarder[9]
      Proxying to http://localhost:4873/@babel%252fcore HTTP/2 RequestVersionOrLower
info: Yarp.ReverseProxy.Forwarder.HttpForwarder[56]
      Received HTTP/1.1 response 400.

log verdaccio when use proxy
2024-09-10 11:51:19 info <-- <IP_ADDRESS> requested 'GET /@babel%252fcore'
2024-09-10 11:51:19 http <-- 400, user: null(::1 via <IP_ADDRESS>), req: 'GET /@babel%252fcore', error: invalid package
2024-09-10 11:51:19 http <-- 400, user: null(::1 via <IP_ADDRESS>), req: 'GET /@babel%252fcore', error: invalid package

log verdaccio without proxy
2024-09-10 11:52:56 info <-- <IP_ADDRESS> requested 'GET /@babel%2fcore'
2024-09-10 11:52:56 info --- auth/allow_action: access granted to: undefined
2024-09-10 11:52:56 info --- allowed access for @babel/core
2024-09-10 11:52:56 http <-- 200, user: null(<IP_ADDRESS>), req: 'GET /@babel%2fcore', bytes: 0/0
2024-09-10 11:52:56 info --- making request: 'GET https://registry.npmjs.org/@babel%2Fcore'
2024-09-10 11:52:57 http --- 304, req: 'GET https://registry.npmjs.org/@babel%2Fcore' (streaming)
2024-09-10 11:52:57 http --- 304, req: 'GET https://registry.npmjs.org/@babel%2Fcore', bytes: 0/0
2024-09-10 11:52:57 http <-- 200, user: null(<IP_ADDRESS>), req: 'GET /@babel%2fcore', bytes: 0/117578

Further technical details

dotnet 8.0.8, sdk 8.0.400
yarp version 2.2.0 https://www.nuget.org/packages/Yarp.ReverseProxy/2.2.0
verdaccio latest version docker hub.
Reproduce on the platforms: Linux, Windows

You ran into #1419 / https://github.com/dotnet/aspnetcore/issues/30655. ASP.NET normally decodes all encoded characters in a request, with the exception of %2F for the /, which it leaves unencoded for security reasons.
To workaround the issue, you can consider manually unescaping that character, e.g.
builder.Services.AddReverseProxy()
    .LoadFromConfig(builder.Configuration.GetSection("ReverseProxy"))
    .AddTransforms(builder =>
    {
        if (builder.Route.RouteId == "npm")
        {
            builder.AddRequestTransform(context =>
            {
                if (context.Path.Value.Contains("%2F", StringComparison.OrdinalIgnoreCase))
                {
                    var uri = RequestUtilities.MakeDestinationAddress(context.DestinationPrefix, context.Path, context.Query.QueryString);
                    uri = new UriBuilder(uri) { Path = uri.AbsolutePath.Replace("%252F", "%2F", StringComparison.OrdinalIgnoreCase) }.Uri;
                    context.ProxyRequest.RequestUri = uri;
                }

                return ValueTask.CompletedTask;
            });
        }
    });

Note that this may be ambiguous between requests like /foo%2F/ and /foo%252F/ as the former will have its path decoded into the latter.

Thanks, it worked, but it looks like a workaround.


fix(xp-treatment): Fix incorrect selector in xp treatment

Motivation
Similar to PR #353, the XP Treatment swagger docs are not functioning correctly if the full name of the XP Treatment app does not happen to be the same as its regular name. That's because the swagger K8s service is using the full name as a label selector whereas the XP Treatment deployment pods are simply using a regular name as a label.
Compare:

https://github.com/caraml-dev/helm-charts/blob/main/charts/xp-treatment/templates/deployment.yaml#L22
https://github.com/caraml-dev/helm-charts/blob/main/charts/xp-treatment/templates/service-swagger.yaml#L18

This PR thus updates the selector value to use the regular name of the XP Treatment service.
Modification

charts/xp-treatment/templates/service-swagger.yaml - Update of the XP swagger service pod selector

Checklist

[x] Chart version bumped
[x] README.md updated

Thanks for the quick review! Merging this now!


what the purpose of those code?

`
    msk[..., 1][msk[..., 2:].max(axis=2)] = False
    msk[..., 3][msk[..., 2]] = False
    msk[..., 4][msk[..., 2]] = False
    msk[..., 4][msk[..., 3]] = False
    msk[..., 0][msk[..., 1:].max(axis=2)] = False

`
I have a question, what does the above code do？ The code is in ‘train50_cls_cce.py’ , about at 235 line.  I've been trying to figure out what this means all day...

@zhijiejia  Did you understand anything??
@vdurnov Can you explain it??


testAdd tpch test cherry pick to branch 21

Proposed changes
pr: https://github.com/apache/doris/pull/30870
commit id: 406cbcda
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Fixed spelling of Acknowledegements in README file

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@RVarshinee can you assign me this issue?

Assign me this issue

❤  Thanks for the contribution. In this case both spellings are considered correct, so I'm going to stick our current usage.


Feature: Add element deletion functionality

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
No response
Describe the solution you'd like
Nodes and connections should be able to be deleted. The deletion changes should be able to be undone.
Teachability, documentation, adoption, migration strategy
Documentation on delete shortcut should be added.
What is the motivation / use case for changing the behavior?
There is currently no ability to delete nodes or the connections between nodes.

Workflow jobs can be deleted


done

[x] Learn the mathematical concept
[x] Use loop "while"
[x] iterate  until we get the index that we want


HeapMergeIterator use wrong output schema.

If scan have unused column, chunk will have wrong schema and cause be crash.

Could you please give some steps to reproduce this issue?


[Enhancement] Add hashJoin execution cost model

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

For different distributed join execution methods, due to their different execution characteristics, they should have different cost. We currently have four execution modes: broadcast join, bucket_shuffle join, shuffle join, and colocate join. The latter three are essentially shuffle joins, so their execution efficiency can be approximately regarded as consistent. The implementation of broadcast join is a little different from the other three.

In the build hash table stage of broadcast join, the parallelism is 1 while it can be parallized in shuffle join.
Broadcast join consumes more memory for redundant data in multiple BEs.
The data size in each hash table of shuffle join is 1/parallelism of right table_size while it is full size in broadcast join. A small hash table can improve probe efficiency.
The process of redistributing data by shuffle operation makes the tasks of each processing thread are more balanced, and it is more conducive to parallel computing.
Therefore, our join execution cost calculation model should comprehensively consider parameters such as join execution mode, parallelism, and left and right table size. The most important thing in the model is the evaluation of the probe cost for each row. When the size of the right table is greater than bottom_number, the average probe cost needs to be expanded. The parallel computing characteristics of shuffle join can offset part of the probe cost. We also set an upper limit on the probe cost to avoid cost distortion caused by too large table data.

Performance Test
https://starrocks.feishu.cn/sheets/shtcnv80yaIBtAj67yE5guA100f
Environment benchmark07.
TPCDS-1t from 806s to 637s.
TPCH-1t from 254s to 250s.
UT changes

hive sql plan chanages. New join execution cost model inclined to shuffle join when the right table is larger than a million level. Cases with a 10M level table join with a 1M level table use shuffle join now. The changes of q2.sql reflects a bug. When the child's best plan was updated, his father's confidence statistics were not updated because of oldChildcost + oldEnforcerCost < newChildCost(smaller than old) + newEnforcerCost(bigger than old).

enumerate paln numbers changes. Join cost number has different from before which may lead to different prune operations.

Sqls in testCountPruneJoinByProject, testJoinWithPipelineDop use broadcast join before is very slow.  This pr optimizes them.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.

starrocks_be_unittest succeeded.

starrocks_be_unittest succeeded.

[FE PR Coverage Check]
:heart_eyes: pass : 99 / 102 (97.06%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/physical/PhysicalDistributionOperator.java
0
1
00.00%
[54]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostEstimate.java
1
2
50.00%
[72]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
35
36
97.22%
[234]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/HashJoinCostModel.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/EnforceAndCostTask.java
3
3
100.00%
[]

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 99 / 102 (97.06%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/physical/PhysicalDistributionOperator.java
0
1
00.00%
[54]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostEstimate.java
1
2
50.00%
[72]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
35
36
97.22%
[234]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/HashJoinCostModel.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/EnforceAndCostTask.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 99 / 102 (97.06%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/physical/PhysicalDistributionOperator.java
0
1
00.00%
[54]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostEstimate.java
1
2
50.00%
[72]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/CostModel.java
35
36
97.22%
[234]

:large_blue_circle:
com/starrocks/sql/optimizer/cost/HashJoinCostModel.java
60
60
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/task/EnforceAndCostTask.java
3
3
100.00%
[]

starrocks_admit_test

run starrocks_admit_test


Add documentation on building uberjars to README

link documentation for building uberjars https://github.com/babashka/neil/issues/140

Thanks!

thanks! I just realized it's not actually in the readme as I just edited README.template.md and didn't run the 'update-readme' task

Ah, can you fix this?

sure, I just ran bb update-readme and submited new pull request. It seems update-readme runs first gen-script which added to neil another small change you did recently in neil.clj


Fix RESPONSIVENESS

The website doesn't look good on smaller screen sizes. I can fix it, assign it to me @Soumyajit2825

Go through it after your work put a screen shot and if i found it helpful then i will assign and merge the pr undr hacktoberfest label


Add missing spaces to let-statement.md

Add missing spaces.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Reference/User-Interface-Help/let-statement.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Documentation: Add option to return to the previous Git resolver

It would be nice if you could document how to return to the previous source resolver.
Context:
The new 3-way git resolver is not clear enough when you have multiple conflicts.
It was difficult for me to find out how to return to the old system one.
For the record, for others who wish to do the same:

Disable Git: Merge Editor
Enable Git > Decorations: Enabled

I am surprised you needed to change git.decorations.enabled
I expected you to have to enable diffEditor.codeLens

@gjsjohnmurray From what I saw, decorators glow the area in two different colours, right? That it's just a nice add.
I'm on a different computer atm. I'll take a look tomorrow.
It's just that it took me a fair amount of time to figure out how to revert to the non-3-ways resolver.

I really don't like how the 3-way resolver look. I don't understand that why don't let the user to choose the which resolver to use ?

/duplicate #156608


feat: solve year 2022, day 6

Closes: #14

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

v1.6.0
GitHub release

Your semantic-release bot :package::rocket:


Implement verify_secure_runner

Implement verify_secure_runner
Description
Implementation verify_secure_runner.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #517 (f5a3fa4) into main (278833d) will decrease coverage by 0.94%.
The diff coverage is 33.96%.

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   92.10%   91.15%   -0.95%
==========================================
  Files          48       49       +1
  Lines        3192     3245      +53
==========================================
+ Hits         2940     2958      +18
- Misses        252      287      +35

Impacted Files
Coverage Δ

src/vm/runners/builtin_runner/bitwise.rs
68.29% <0.00%> (-3.51%)
:arrow_down:

src/vm/runners/builtin_runner/ec_op.rs
75.38% <0.00%> (-2.40%)
:arrow_down:

src/vm/runners/builtin_runner/hash.rs
89.74% <0.00%> (-4.86%)
:arrow_down:

src/vm/runners/builtin_runner/mod.rs
87.50% <ø> (ø)

src/vm/runners/builtin_runner/range_check.rs
89.65% <0.00%> (-6.65%)
:arrow_down:

src/vm/security.rs
0.00% <0.00%> (ø)

src/vm/runners/cairo_runner.rs
94.61% <80.00%> (-0.69%)
:arrow_down:

src/vm/vm_memory/memory_segments.rs
96.25% <88.88%> (-0.94%)
:arrow_down:

src/vm/runners/builtin_runner/output.rs
81.25% <100.00%> (+2.67%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix xIPAddress samples to show safe usage - Fix #123

This is only a change to the Example files for xIPAddress usage to include setting the xDHCPClient to static. This prevents a behavior where if the IP Address of an adapter is assigned by DHCP and the address that has been assigned by DHCP matches the address that a DSC configuration is trying to assign. This situation would cause the DHCP client to remain as DHCP.
It was discussed some time back to separate IP Address setting and DHCP client setting in separate resources to prevent conflicting configurations.

This change is

huh. Strange. Didn't install Pester correctly? @TravisEz13 or @KarolKaczmarek could one of you kick AppVoyer to run again?

I restarted AppVeyor.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Examples/Sample_xIPAddress_StaticIP_FixedValue.ps1, line 12 [r1] (raw file):

    Node $NodeName
    {
        xDhcpClient DisabledDhcpClient

Tests need to pass

Comments from Reviewable


Translated base README.md to Russian

Solution to: #466
What did I do: translated base README.md to Russian
Notes: I see translators to other languages leave their PRs as drafts to continue commiting to them, however I don't know, will I continue translating or not, so it will be better to leave this PR as Ready to review to deliver faster translations.

Done! Looks like all links are now fixed.


Enable pagination when listing Packages in UI

Otherwise the UI is not really usable. The display is limited to 50 rows.

This is now completed by @johnmhoran the UI now supports pagination, closing this


Palindrome challenge

I am working on a challenge that checks if the input string is a palindrome (reads the same backward as forward)

Sounds really interesting! 🔥


Can't install addon on current HA version

Can't install addon with the following error on addon page (for both, CloudFlare and Access Point)
Error fetching addon info: Addon 567c2022_hassio-hostapd with version latest does not exist in the store

My apologies, it was my bad (HA cache, and a few addons testing).


Fix docker-compose + entrypoint

Applied fix:

In latest version of docker compose 'version' is obselete so it return warning when starting stack

Due to an issue with .sh file format container wasn't able to boot when build/run on windows:

To fix this issue, I added a .gitattributes to force .sh file to still be in LF instead of CRLF (git doc)
All shell file was in CRLF so I fixed them to be in LF

After making a global check I'll push a new commit with all patched file. All script are in CRLF


[BACKLOG-8416] Added apostrophe for Windows messages

@mdamour1976

Base build failed with return code 1


copyright is old in info.txt for portable

http://localhost:9335/earth/info.txt - Not sure if its okay to update ( some scripts designed to read a particular line number / keyword and parse these  text files, so we need to verify and then update)

Duplicate of #397


Help with DNS resolution - docker container

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
Hi Team,
Loving Uptime Kuma! Quick one - I can’t get DNS checks working on my container with it’s own networking. I use a Pihole for DNS with Unbound (neither works directly).
As such im trying to use <IP_ADDRESS>:53 to resolve www.google.com with no luck UNLESS I put my container into host networking mode.
I’m sure this isn’t an UK issue but more likely docker - does anyone know how to achieve this but still keep the network segregated?
I’d prefer to keep the network isolated as I eventually plan to allow UK on the internet via Cloudflare.
Thanks!
🐻 Uptime-Kuma Version
1.18.9
💻 Operating System and Arch
Raspian OS
🌐 Browser
Safari
🐋 Docker Version
No response
🟩 NodeJS Version
No response

One solution I've kind of found is to run my DNS queries against the docker daemon's virtual DNS server (<IP_ADDRESS>:53).  I believe this passes onto my local DNS.

Just double checking so we can rule this out:
unbound port is 5335 by default, not 5053 except you changed that.


Failure to release using Maven

I was trying to release the 1.0.6.GA using 'mvn release:prepare' and 'mvn release:perform' and during perform goal I get the following error:
Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.1:perform (default-cli) on project inspektr: Maven execution failed, exit code: '1' -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.1:perform (default-cli) on project inspektr: Maven execution failed, exit code: '1'
....
Caused by: org.apache.maven.shared.release.exec.MavenExecutorException: Maven execution failed, exit code: '1'
...
Any insight, pointers, help will be appreciated.

Anyone, please?

Thank you. I appreciate it. No rush

Is there any way to manually upload the jars into the maven repo if the maven release fails?
Thanks.

Not that I'm aware of.  Do you know if the release pom.xml changes were
committed to the GitHub repo though?  If not, I can just re-run it.  If it
was then we have to fix the version numbers.
On Tue, Jan 3, 2012 at 4:46 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Is there any way to manually upload the jars into the maven repo if the
maven release fails?
Thanks.

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3346742

Haven't messed around with pom.xml. If you could try to re-run it I'd really appreciate it.
Thanks,
D.

Oh, actually yes, here's the commit: https://github.com/dima767/inspektr/commit/04ac22bc01e8ba865e5f9fd0ab836e1cbd7be6f2
Sorry for the confusion

Okay, I will have to revert that first.
On Tue, Jan 3, 2012 at 5:06 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Oh, actually yes, here's the commit:
https://github.com/dima767/inspektr/commit/04ac22bc01e8ba865e5f9fd0ab836e1cbd7be6f2
Sorry for the confusion

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347054

Thanks for your help!
Sent from my iPhone
On Jan 3, 2012, at 17:08<EMAIL_ADDRESS>wrote:

Okay, I will have to revert that first.
On Tue, Jan 3, 2012 at 5:06 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Oh, actually yes, here's the commit:
https://github.com/dima767/inspektr/commit/04ac22bc01e8ba865e5f9fd0ab836e1cbd7be6f2
Sorry for the confusion

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347054

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347081

Released as 1.0.7.GA since a 1.0.6.GA tag existed already.
On Tue, Jan 3, 2012 at 6:13 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Thanks for your help!
Sent from my iPhone
On Jan 3, 2012, at 17:08<EMAIL_ADDRESS>wrote:

Okay, I will have to revert that first.
On Tue, Jan 3, 2012 at 5:06 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Oh, actually yes, here's the commit:

https://github.com/dima767/inspektr/commit/04ac22bc01e8ba865e5f9fd0ab836e1cbd7be6f2

Sorry for the confusion

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347054

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347081

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347974

Great! Thanks again for your help!
Sent from my iPhone
On Jan 3, 2012, at 21:56<EMAIL_ADDRESS>wrote:

Released as 1.0.7.GA since a 1.0.6.GA tag existed already.
On Tue, Jan 3, 2012 at 6:13 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Thanks for your help!
Sent from my iPhone
On Jan 3, 2012, at 17:08<EMAIL_ADDRESS>wrote:

Okay, I will have to revert that first.
On Tue, Jan 3, 2012 at 5:06 PM, Dmitriy Kopylenko <
<EMAIL_ADDRESS>
wrote:

Oh, actually yes, here's the commit:

https://github.com/dima767/inspektr/commit/04ac22bc01e8ba865e5f9fd0ab836e1cbd7be6f2

Sorry for the confusion

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347054

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347081

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3347974

Reply to this email directly or view it on GitHub:
https://github.com/dima767/inspektr/issues/14#issuecomment-3350024


Create january-2021.md

Hi, this is a draft of my first report.
Please let me know your recommendations! Thank you :)
I think the easiest way to distribute it would be to share the link to IRC/Slack? My other idea was to tag folks here, but I think that might be overkill?

I think the easiest way to distribute it would be to share the link to IRC/Slack? My other idea was to tag folks here, but I think that might be overkill?

I agree tagging people on the PR is probably not ideal.  Broadcasting the link and letting people consume it if they want seems to make sense.  IRC + the mailing list seems like a good plan.  Maybe also a tweet?


Merges ANCM into IISIntegration

@pan-wang there are a few build warnings in IISLib, may I fix those before merging?
There is a PR open in ANCM  that actually creates the RequestHandler nuget package. Depending on if that gets approved, I will add it on here.
@natemcmaster I mostly need you to check build stuff.
cc/ @Eilon @muratg as this starts the process of deprecating the ANCM repo.

.gitattributes are now set for .rc files, but git still believes these are binary files. I have no idea why git sees these as binary.

Changes LGTM. :shipit:

But of course, get the PR building on AppVeyor first, if possible

for the build warnings from IISLib, you can leave then as is. The code was duplicated from IISOOB directly. I don't want to change it for now as the code was broadly used by IIS OOB products meanwhile we don't have any unit test for it (even in IISOOB), and ANCM does not have enough test coverage for any potential change in IISLIB either. We can revisit this lib later once we have enough ANCM test coverage


fix import error in metadata: fails on systems without pwd

The standard library module pwd (password database access) doesn't exist on all systems (e.g. Windows or WASM), so don't rely on it. This just replaces the call to it with a default value if it is not there.
This feature was only used in ctapipe.core.metadata.Contact to get the user's name if they forgot to explicitly include it, so it should not break things if it fails (which it currently does).

We need to merge #2150 first to fix the docs build


moment start of time 'year' set Sat Feb 01 2020 00:59:59 GMT+0100

Describe the bug
moment start of time 'year' set to  Sat Feb 01 2020 00:59:59 GMT+0100
To Reproduce
const firstDayOfYear: moment.Moment = moment().startOf('year') ==> Sat Feb 01 2020 00:59:59 GMT+0100
Expected behavior
it would set to January 1st, 12:00 am this year

OS: Windows 10
Browser: chrome

console.log((new Date()).toString()) ==> Thu Jan 23 2020 15:52:29 GMT+0100 (Paris, Madrid)
console.log((new Date()).toLocaleString()) ==>  2020-1-23 15:52:29
console.log((new Date()).getTimezoneOffset()) ==> -60
console.log(navigator.userAgent) ==> "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36"
console.log(moment.version) ==> 2.22.2

Please re-open if you still have issues.


vcbuild.bat doesn't work when run from a VS dev cmd prompt (VS2015)

I'm running into an issue trying to build libuv from a VS2015 dev command prompt.
It seems that vcbuild.bat assumes that if the WindowsSDKDir env variable is set then it can skip straight to the select-target step. Doing that however results in the GYP_MSVS_VERSION env variable not being set. That then produces a VS2010 sln file, which won't build on a machine that doesn't have the VS2010 build tools installed (e.g. on my machine that only has 2015 installed).
The workaround is to manually set the GYP_MSVS_VERSION env variable to 2015 before running vcbuild.bat.

I suspect it's at least in part a GYP problem.  It tries to auto-detect the MSVS version if GYP_MSVS_VERSION is not set but I don't think the heuristic for 2015 is fully baked yet.

gyp seems to prefer VS 2015 (if present) since they added support for it. @DamianEdwards can you please update gyp to the latest (and hopefully greatest) re-test?

Closing, see https://github.com/libuv/libuv/issues/705 for a similar problem and resolution.


glimpse: Drop package and plugins

Description of changes
Drop package and plugins since project is discontinued and doesn't build anymore https://glimpse-editor.org/posts/a-project-on-hiatus/
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Okay I removed the package and plugins :)

Thanks, makes sense to drop it at this point. Tried to fix the build failure the last days, but couldn't really find the time for it.
If anybody wants to bring the package back in the future, I'd be glad to help!

@GrahamcOfBorg build gimp

We should have added an alias :)

Oh right, I'll add one.

Fixed in https://github.com/NixOS/nixpkgs/pull/181111


All py tests from github action are failing

All py tests are failing - need to investigate outside of this PR
Originally posted by @mithmatt in https://github.com/open-metadata/OpenMetadata/issues/2631#issuecomment-1030696819

cc: @pmbrull

Thanks @pmbrull looks like fixed. Closing this issue


https://github.com/metarelate/metOcean/issues/66

updates to translations from
https://github.com/metarelate/metOcean/issues/66

Looks good from a content point of view. :+1:
@pp-mo - do you want this against 1.9.x or master?

I suppose it has to be an improvement on the existing, so please target 1.9.x and I'll include it

I suppose it has to be an improvement on the existing, so please target 1.9.x and I'll include it
@pp-mo
it is targeting 1.9.x so we should be good to go

Are updates to these mappings ever mentioned in the "what's new" pages?

Sorry, missed that !


 Not really sure what they should be since rtx env is already used for something else.
rtx set-env is one idea I had. Or maybe env-set which will sort better.

Is this idea something similar to what direnv does?

direnv doesn't have this feature

I find rtx very useful, so I would like to contribute 😀
To understand the feature, how is this different from using export FOO=bar in current shell?
Or in case of direnv, one can write export FOO=bar in their .envrc and it will get activated once user enters that folder.

Clear!
You can assign this ticket to me. It might take a bit longer as I need to learn the codebase first :)

I am trying to read .rtx.toml file in current directory like this:
fn get_rtx_toml() -> Result<RtxToml> {
    let path = dirs::CURRENT.join(RTX_DEFAULT_CONFIG_FILENAME.as_str());
    let rtx_toml = if path.exists() {
        RtxToml::from_file(&path, false)? // TODO: truested or not?
    } else {
        RtxToml::init(&path, true)
    };

    Ok(rtx_toml)
}

While reading an existing TOML file, where can I see if it is already trusted?

Regarding the command (set-env), I think we should create a subcommand under env, like this:
rtx env set FOO=bar

This way we can add more subcommands there in the future (remove, ls etc..)
This is somehow similar to rtx alias and its subcommands.
What do you think?

not sure about the trusted stuff right now, if you can get a PR ready I'll review it and let you know what I think we should do. We may want to refactor the trusted stuff a little bit but I don't know if that makes sense here or not.
I mentioned the subcommand thing in the issue description here. I think because rtx env is a completely different command that really doesn't have anything to do with the behavior of this new command it doesn't make sense to put it there. I don't think it would be discoverable. If rtx env did not already exist, it would make sense to make rtx env list all of the current env vars in the toml file and rtx env set would modify them.
This is why I was thinking set-env or maybe env-set which would sort better, but on the other hand I think having a set of CRUD commands like we have for rtx alias and rtx settings is probably the right thing to do.
We just can't use rtx env since that's taken and definitely can't be changed at this point. Some ideas to get the ball rolling on this:

rtx local-env set
rtx env-vars set
rtx toml-env set
rtx cwd-env set

I don't love any one of these, but I'll think more about it and see if we can come up with a good idea.

my memory is a bit hazy but I think this is the only section where I read the toml file outside of the complex toolset parsing that isn't likely helpful for you:
https://github.com/jdxcode/rtx/blob/main/src/cli/local.rs#L105-L109C7
However that uses the generic "config_file" interface which could be a legacy file (.node-version) or .tool-version file—neither of which is relevant to you since env vars I believe are only ever used in .rtx.toml files.
One thing we're going to have to watch out for is a situation where you have a .rtx.local.toml file and you run rtx env-vars set FOO=bar. If that local file already defines something for FOO it would probably write to .rtx.toml and not .rtx.local.toml and not actually change anything. For v1 we can probably just not worry about this use-case or maybe show a warning if the variable is overridden but something to think about for the future.

Sorry for the long pause in replying. Got really busy with some personal stuff 😅
I just opened a draft PR regarding this issue.
Reading your comments, I think I like env-vars more than env-file. The reason being that the TOML file is not just for env variables. Calling it env-file might give the impression that it is used for env variables only?
Summarizing your comments, this is what comes to my mind:
$ rtx env-vars FOO=bar # modifies .rtx.toml
$ rtx env-vars --rm FOO # removes FOO from .rtx.toml

$ rtx env-vars .rtx.dev.toml FOO=bar
$ rtx env-vars .rtx.dev.toml --rm FOO # removes FOO from .rtx.dev.toml

rtx env-vars [TOML FILE] [OPTIONS] ARGS...

Let’s make the file an option, e.g.: --file. That’ll make it a lot easier to implement and more clear to the user.


API authentication

Hi all - any clues on how to enable authentication for the REST API? I've got LDAP auth working for the UI using the docker-compose file / mounted config... is there a configuration option to force authentication?
Thanks in advance.

@MattCrum1 you can set the require_auth config to true. From config.yaml
# Setting to determine whether the Oncall API/frontend is available unauthenticated.
# Set to True to force login splash page and authentication on API calls and False to allow read
# APIs without authentication
require_auth: False

Thanks @diegocepedaw - I think the issue is that the config.docker.yaml file doesn't contain any of these comments or the require_auth line; might be worth updating it to include them?


Cmake support of cryptopp>=6.0 and cryptopp-cmake

When trying to build from source I found problems when running cmake .
CMake Error at CMakeLists.txt:52 (find_package):
  By not providing "Findcryptopp.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "cryptopp",
  but CMake did not find one.

  Could not find a package configuration file provided by "cryptopp" with any
  of the following names:

    cryptoppConfig.cmake
    cryptopp-config.cmake

  Add the installation prefix of "cryptopp" to CMAKE_PREFIX_PATH or set
  "cryptopp_DIR" to a directory containing one of the above files.  If
  "cryptopp" provides a separate development package or SDK, be sure it has
  been installed.

I downloaded and compiled and installed (successfully) CryptoPP version 7.0.0
I tried with both master and 0.14.11 versions of Xeus

It makes sense, CyrptoPP 7 does not use CMake so I think it cannot find the cmake config or something.
I tried with an older version of CryptoPP (5.6.5), again, build from source, but this time I get a different message:
CMake Error at /opt/cryptopp-CRYPTOPP_5_6_5/cryptopp-config.cmake:1 (include):
  include could not find load file:

    /opt/cryptopp-CRYPTOPP_5_6_5/cryptopp-targets.cmake
Call Stack (most recent call first):
  CMakeLists.txt:52 (find_package)

-- Checking for module 'libzmq>=4.2.3'
--   Found libzmq, version 4.2.5
-- Found LibUUID: /usr/lib/libuuid.so
CMake Error at CMakeLists.txt:156 (get_target_property):
  get_target_property() called with non-existent target "cryptopp-static".

CMake Error at CMakeLists.txt:157 (get_target_property):
  get_target_property() called with non-existent target "cryptopp-static".

I have the exact same issue. I am trying to package xeus for nixpkgs

Cryptopp stopped supporting cmake with version 6.0.
You can use cryptopp-cmake instead.

Totally agree. A PR is welcome if you feel like fixing this now.

Absolutely. I will do that once I have a working nix build of xeus.

Wonderful! I am really excited about the nix packaging and tooling. Don't hesitate to ping us wherever this takes place.

Sorry @costrouc I didn't see you wanted to do it. I also had problems when installing xeus and fixed it in #94.


Incorrect apiVersion ( autoscaling/v2beta1) in hpa edit screen for hpa autoscaling/v2

Describe the bug
Lens is showing incorrect apiVersion ( autoscaling/v2beta1) in hpa edit screen for hpa autoscaling/v2
To Reproduce
Steps to reproduce the behavior:

Create an hpa using this manifest

apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
  name: pause
spec:
  minReplicas: 2
  maxReplicas: 12
  scaleTargetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: pause
  metrics:
  - type: Resource
    resource:
      name: cpu
      target:
        type: Utilization
        averageUtilization: 50

open HPA screen and edit that HPA

You can see that it is showing incorrect apiVersion
Note that k get hpa/pause -o yaml shows correct api version

Expected behavior
Lens should show autoscaling/v2 apiVersion
Screenshots
Already added above
Environment (please complete the following information):

Lens Version: 2022.12.221341-latest

OS: Ubuntu 22.04.1 LTS

Installation method (e.g. snap or AppImage in Linux): deb

Logs:
N/A
Kubeconfig:
N/A
Additional context
N/A

Duplicate of https://github.com/lensapp/lens/issues/6168