Allow to alter the copied text before putting it into the clipboard

I'd like to modify the copied text before it's put into the clipboard in order to perform some sanitization (trimming etc.).
Is this possible somehow? If not, could the API be extended so I could pass in a function for doing so? Thanks for your consideration.

https://github.com/zenorocha/clipboard.js#advanced-options

I saw the text function, but how can I get hold of the selected text in there? I don't want to return a static text but rather modify the selection. Is there an example for doing so somewhere?

Try this: http://jsfiddle.net/zenorocha/2jph1vuf/

Ok, so I have to look for the source element itself. I had hoped to avoid this, given the fact that clipboard.js already has done this and could simply pass the text to me in a callback. I still think that'd be a valuable addition, but I'll go for the approach you suggest. Thanks.

Can you explain in a JSFiddle how you wanted things to work?

What I'd like to have is the option pass in a function that modifies the selected text:
new Clipboard('.btn', {
    textModifier: function(text) {
        return text + '123';
    }
});

It'd also suffice to pass the selected text to the existing text function alongside the trigger:
new Clipboard('.btn', {
    text: function(trigger, text) {
        return ...;
    }
});

Then one can either return a new text from scratch as of today, or amend the text already selected by the library.


Prevents other applications from listening for captured events

Is there a way to achieve this?

You can't prevent key presses because events are delivered asynchronously to js, at the point where your code runs it is too late to cancel them.

I see that makes sense thanks you :D

so libuiokook should look out for some sort of "blockfile" where we could put some keycodes to block :-)

@valueerrorx If you know which keys to prevent in advance and don't need to check any conditions, then you can:
Pass array of keycodes from js side to C.
https://github.com/SnosMe/uiohook-napi/blob/63745a540828de230392eee3e6cf85d8a4d09e13/src/lib/addon.c#L180
Then check and prevent original non-copied event here.
https://github.com/SnosMe/uiohook-napi/blob/63745a540828de230392eee3e6cf85d8a4d09e13/src/lib/addon.c#L11-L18


chore(CI): Update Ubuntu version in GitHub Action files

Purpose of PR?:
Fixes #1433
Does this PR introduce a breaking change?
No
Checklist:

[x] Bug fix. Fixes #1433
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[x] Commit has unit tests
[x] Commit has integration tests

Hi @daemon1024 @achrefbensaad how can we test all our CI jobs with latest Ubuntu version?

@ShubhamTatvamasi I have approved the CI will wait for it to finish.


Using with tabbar

Hello i have one tabbar and navigation bar for each item inside tabbar.
var contentList = [MenuItemContentViewController]()
let storyboard = UIStoryboard(name: "Main", bundle: nil)
let tabbarVC = storyboard.instantiateViewController(withIdentifier: "TabBarViewController") as! TabBarViewController
contentList.append(tabbarVC as MenuItemContentViewController)

I am trying to add tabbar but it gives me an error. Do you know how can i use with tabbar ?

Hi @berkerbilgi
It looks like you try to use incompatible types because UITabBarController cannot be an inheritor from MenuItemContentViewController that is required to put in contentList.
So at the moment current version of the library doesn't support working with UITabBarController. Sorry about it.
But there is a workaround you might use. You can create TabBarVC that is a  inheritor from MenuItemContentViewController and then to add actual UITabBarController as a child view controller. Here is an example:
    class TabBarViewController: MenuItemContentViewController {
        override func viewDidLoad() {
            super.viewDidLoad()

            let innerTabBarVC = self.storyboard!.instantiateViewController(withIdentifier: "InnerTabBar") as! InnerTabBarViewController

            self.addChildViewController(innerTabBarVC)
            self.view.addSubview(innerTabBarVC.view)
        }
    }

    class InnerTabBarViewController: UITabBarController {}

Thanks for letting me know! Feel free to send me pull requests!

For those who might have been struggling with this approach:

If TabBarViewController is not a viewController in the StoryBoard, the self.storyboard! should be changed to
let someStoryboard = UIStoryBoard(name: "Main", bundle: nil)
let innerTabBarVC = someStoryboard.instantiateViewController(withIdentifier: "InnerTabBar") as! InnerTabBarViewController

The showMenu() function cannot be called from the viewController which is embedded in a TabBarController or NavigationController (even if it is inherited from the MenuItemContentViewController). Because its parent is either UITabBarController (or UINavigationController and they could not be cast to MenuContainerViewController. (Dont worry if you didn't understand this)
So the solution is:
Write a function in the TabBarViewController above (or anything else in your case) and put the showMenu() in it:

public func foo() {
   showMenu()
}

And in your main viewController every time you want to show menu use the code below:
if let parentVC = self.parent?.parent as? TabBarViewController {
     parentVC.foo()
} else {
     print("Oops!")
}

Have FUN!
Amin

@amiinous Thanks for sharing some details about a described approach!
Btw, in the near future, we are going to release next version of our library where we simplify working with TabBarVC and NavigationVC. So, stay tuned on, please.

Hi Andrey,
is it possible to share the code for the sample gif in the Readme. (i.e. the MenuViewController) ?

Hi @amiinous,
This gif is just a sample of using SideBar menu. It's a part of commercial projects and, unfortunately, we haven't enough rights to share its code.
And we are ready to answer any specific questions concerning implementation of MenuViewController if you have them.
Thank you for your comments.

Thanks Olga. I understand.
Cant wait to see upcoming commits.

UITabBarController and UINavigationViewController is now supported in SideMenu 2.0. Please, take a look into the new version and simplified approach of adding menu items. Check Sample, if necessary.
Good luck!

Congrats ;)
is cocoapod update available?
(It shows InteractiveSideMenu 1.0 instead of 2.0)

We are working on it right now. Will be ready soon :)

Yeah, now it's ready https://cl.ly/2V3U0y0H0E3Y. Please, check it and close the issue if everything is ok.
Have fun.

README needs some updating.
or a migration guide.
Spent a good bit looking at the sample to get my 1.0 version working.

@DaveInTO
Thanks for your comments. We will add a migration guide soon.

Hi @DaveInTO,
You could use ChangeLog file to migrate to the newer version. Weren't Migration Notes from that file helpful enough?
It's very important for us to hear your opinion to be able to improve guides if it's necessary. Thanks a lot!

All good now, when i used the sample as a guide, it didn't have UIViewController.
So i replaced all the MenuViewController with SideMenuItem...
And all view objects became unknown.
Easy fix once I prepended UIViewController everywhere.

Ok, thank you!


Refresh page at the pages other than the main page will cause 404

Enter the projects page and refresh, the page turns into 404

Has been fixed at these commits
5f33331e1980e33c0831f0cd12a5206e66da4ac4
a0d456b19b3f98c43d6539f695f417a1be77be6a
e05d2e084198ce444103dddc70e51188dc35bd84


CLI Install: Provide APT package and possibly an apt repository

Describe the enhancement you'd like to see
We should provide a way for users on Debian-like systems to install kusk via apt.
We should additionally consider adding a repository for kusk so that users can get updates automatically.
Additional context
Easier for users to install kusk and potentially update it.

let's use<EMAIL_ADDRESS>

Update: APT repo server is live and can accept packages and packages can be installed from it. All that's left to do is to properly mount a large non-boot disk via the OS to store the packages and create backups of


Client – Figure out how to handle lossy state conversions between RGB/Hex to HSV

Already done; just adding as project task to document it.

Adding some notes to document why state management was so screwy here:

One of the design goals I had for the app was that I wanted to have the majority of the app be based around hex color strings. This would have two main benefits:

The strings would be easier to send over from the server, as compared to a ton of objects
The strings would work better with React's reference-based model, making any memoization easier down the line, and making it a lot easier to prevent any useEffect dependency arrays from over-running.

Of course, working with hex strings is awkward, so I decided there would be a single ColorPicker component that would deal with taking the hex strings and converting them into RGB/HSV values. Only this one component would ever need to know that these other color formats even exist.
To make it clear what options are available at all times, I wanted to display both RGB and HSV values at the same time. The problem is, hex to RGB is perfectly fine, but RGB to HSV is a lossy conversion process, meaning that it doesn't line up with the general React approach of "derive values as much as possible".

I think there's a reason why a lot of React-based color editors (including Adobe Color) don't let you see both at the same time. They're not counting on you noticing that values can jump around a little erratically, just because of how the math formulas work, and general rounding issues.

So basically, the solution was to have the component treat the HSV value as state and keep track of the last hex value that the component dispatched. Whenever the component would re-render, it would compare the hex value received through props against the last known hex, and force a state sync if they didn't match.


NFS example with a cluster local service name only works on GKE but not for minikube/kubeadm

This might be a followup for #237. The change from IP to server: nfs-server.default.svc.cluster.local in
https://github.com/kubernetes/examples/blob/master/staging/volumes/nfs/nfs-pv.yaml#L11
seems to be not well tested. It works on GKE through some black magic, but neither on minikube or kubeadm clusters. The main problem is that the controller is not resolving the IP address against core-dns before building the mount command line that will be run on the node's host system.
But there is more. Even after I patched the hosts resolver so that tools like dig, host, nsloopup can resolve the cluster local name, /sbin/mount.nfs still fails.
Mounting command: systemd-run
Mounting arguments: --description=Kubernetes transient mount for /var/lib/kubelet/pods/7ecbc79e-2228-4447-9667-ef5f590d473d/volumes/kubernetes.io~nfs/nfs --scope -- mount -t nfs nfs-server.default.svc.cluster.local:/exports /var/lib/kubelet/pods/7ecbc79e-2228-4447-9667-ef5f590d473d/volumes/kubernetes.io~nfs/nfs
Output: Running scope as unit: run-rf00d34506d784765bb629f16c2941921.scope
mount.nfs: Failed to resolve server nfs-server.default.svc.cluster.local: Name or service not known

To be clear, no one wants to use a fixed IP address, so using the service name is a great change, but it also need to actually work :)

Using a csi-driver, such as https://github.com/kubernetes-csi/csi-driver-nfs will work with an in-cluster nfs server.

Resolving through service name would be a great change. Can it be taken into consideration asap?

I'm also running into this issue with docker desktop. Any workarounds here? Thanks.


error

ℹ Computer information

PowerToys version: 0.21.1
PowerToy Utility: unsure
Running PowerToys as Admin: yes
Windows build number: 19041.508

Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19041.0
IntPtr Length: 8
x64: True
Date: 09/20/2020 15:13:25
Exception:
System.IO.FileNotFoundException: C:\Users\David\Desktop\regular.exe
at System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName)
at Microsoft.Plugin.Program.Programs.Win32Program.ExeProgram(String path)
at Microsoft.Plugin.Program.Programs.Win32Program.GetAppFromPath(String path)
at Microsoft.Plugin.Program.Storage.Win32ProgramRepository.OnAppCreated(Object sender, FileSystemEventArgs e)
at System.IO.FileSystemWatcher.NotifyFileSystemEventArgs(WatcherChangeTypes changeType, ReadOnlySpan`1 name)
at System.IO.FileSystemWatcher.ParseEventBufferAndNotifyForEach(Byte[] buffer)
at System.IO.FileSystemWatcher.ReadDirectoryChangesCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* overlappedPointer)
at System.Threading.ThreadPoolBoundHandleOverlapped.CompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* nativeOverlapped)
at System.Threading._IOCompletionCallback.IOCompletionCallback_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pNativeOverlapped)
2020-09-20.txt

Fixed with #6425 and will be fixed with 0.23


updated semantic-release and axios to address audit issues

all tests are passing; anything else I need to do?

Thanks for contributing @jcollum ! We're holding the release of the new Axios version until we will measure its memory leak I shared on the issue.
If you want to solve the audit issue in the meantime you can just run the manual fix on your end, or install this package from this branch https://www.google.com/search?q=npm+install+github+branch

Thanks for contributing @jcollum ! We're holding the release of the new Axios version until we will measure its memory leak I shared on the issue.
If you want to solve the audit issue in the meantime you can just run the manual fix on your end, or install this package from this branch https://www.google.com/search?q=npm+install+github+branch

AWS lambdas are failing. How do I fix the credentials issues?

AWS lambdas are failing. How do I fix the credentials issues?

AWS lambdas are failing. How do I fix the credentials issues?

It happens because of this https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
I've added you as a collaborator, so you can open a PR directly on this repo, without forking.
But please read carefully what I've mentioned in the previous comments - we are holding a release for that due to memory leak in Axios, so even upon merging this PR it won't soccer the issue.

AWS lambdas are failing. How do I fix the credentials issues?

It happens because of this https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
I've added you as a collaborator, so you can open a PR directly on this repo, without forking.
But please read carefully what I've mentioned in the previous comments - we are holding a release for that due to memory leak in Axios, so even upon merging this PR it won't soccer the issue.


<EMAIL_ADDRESS>hash check failed

My laptop is running Windows 10.
Download: Status Legend:
Download: (OK):download completed.
Checking hash of SysinternalsSuite.zip ... ERROR Hash check failed!
App:         extras/sysinternals
URL:         https://download.sysinternals.com/files/SysinternalsSuite.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    a510c31c2cc591a16f342e7cba5dc8409eaf08c9b56729cf132c95c69e196787
Actual:      9b9d6bd0718a5680b2322398345271142783156dc8d6f3642bce72f80337850f

This is a duplicate issue.


NAFTA charts Key NaN, titles do not change

Currently have this chart removed to simplify pages.

Updated Chart in case we want to add it back in


how can i compile it plz

mvn clean compile package

i did it also i did maven test i got this error


ability to ignore global

it would be nice to have an option to ignore 'global' for the purposes of determining whether something is a commonjs file.  As currently using it in an es6 module will cause it to be compiled (and thus erroring out) even if it's being dealt with somewhere else

Just discovered this and #50 were merged but never released – sorry, just released 3.0.0 with these changes. thanks!


Upgrade dependencies

Hey @BlueHatbRit,
Would you be open to upgrading the dependencies to the latest versions? For example, it is still using puppeteer 2, which is probably a lot less secure than the latest version.
I see a few open PRs, so before I do any work, I would love to check in with you.
Regards,

Hi @adriaanvanrossum, I'd be open to reviewing and merging some PRs but to be honest I don't have time to do them myself right now, especially if they deal with larger breaking changes to various apis.
If you've got time and would like to submit some fixes you're very welcome to and I'll review them as soon as I can. Just as a disclaimer though, I am about to move house so there may be a few days / weeks where I don't have much in the way of a stable internet connection. None the less, I'll do my best with any PR's that do get raised.
In terms of existing PR's, I believe the reason I didn't merge https://github.com/BlueHatbRit/mdpdf/pull/105 is because it was just the package upgrade and didn't address any of the changes required although it's been a while so I'll try and take a look at it again when I get a moment.

Upgrading meow in #105 would fix one of the audit errors returned by npm audit. Would be great if you could merge that one plus cheerio dependency is also marked as High issue.
# npm audit report

nth-check  <2.0.1
Severity: high
Inefficient Regular Expression Complexity in nth-check - https://github.com/advisories/GHSA-rp65-9cf3-cjxr
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/nth-check
  css-select  <=3.1.0
  Depends on vulnerable versions of nth-check
  node_modules/css-select
    cheerio  0.19.0 - 1.0.0-rc.3
    Depends on vulnerable versions of css-select
    node_modules/cheerio
      mdpdf  >=0.1.6
      Depends on vulnerable versions of cheerio
      Depends on vulnerable versions of meow
      node_modules/mdpdf

trim-newlines  <3.0.1
Severity: high
Uncontrolled Resource Consumption in trim-newlines - https://github.com/advisories/GHSA-7p7h-4mm5-852v
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/trim-newlines
  meow  3.4.0 - 5.0.0
  Depends on vulnerable versions of trim-newlines
  Depends on vulnerable versions of yargs-parser
  node_modules/meow
    mdpdf  >=0.1.6
    Depends on vulnerable versions of cheerio
    Depends on vulnerable versions of meow
    node_modules/mdpdf

yargs-parser  6.0.0 - 13.1.1
Severity: moderate
Prototype Pollution in yargs-parser - https://github.com/advisories/GHSA-p9pc-299p-vxgp
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/meow/node_modules/yargs-parser
  meow  3.4.0 - 5.0.0
  Depends on vulnerable versions of trim-newlines
  Depends on vulnerable versions of yargs-parser
  node_modules/meow
    mdpdf  >=0.1.6
    Depends on vulnerable versions of cheerio
    Depends on vulnerable versions of meow
    node_modules/mdpdf

7 vulnerabilities (1 moderate, 6 high)

I've upgraded a bunch of the deps today, the outstanding one is meow which now requires using esmodules which would need us to convert the project over to that. I started a branch but it's going to take a while to debug and get right so it may not happen quickly unless someone else wants to take that on.

I've done an upgrade of all dependencies on master now. We should be on the latest for everything now. Those upgrades will be bundled with the next release (3.0.2).


LMI-PixelOS-ZenkaBestia

Sir don't build 2 rom in one time
Or your rom will aborted by other user

Hello,
Oh my bad, maybe i missed something in rules.
Will abort the last one. Thank you.
Regards,
Zenka
On Mon, Jan 17, 2022, 11:50 AM Razs @.***> wrote:

Sir don't build 2 rom in one time
Or your rom will aborted by other user
—
Reply to this email directly, view it on GitHub
https://github.com/ROM-builders/temporary/pull/5275#issuecomment-1014113767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM65BYO2OOZT5RPHLHFOM2DUWOGYPANCNFSM5MDUQLYQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


feat(schema): add column_default (defaultsTo) and referenced_table_name (model) to model attributes (column definitions)

This way default values and model associations will be seen when models are generated. These were missing from the code.
Note: I admit there might be a more elegant way to do this:
if (!definition.column_default && definition.is_nullable.toLowerCase() === 'no') {}
else
    column.defaultsTo = definition.column_default;

(hopefully I'm done with these pull requests now... :))

I just realised that pull request https://github.com/SpoonX/sails-generate-models/pull/3 is already doing this for defaultsTo though I don't think it's factoring in if there is no default set, in which case I think it should not be listed (my code does consider that scenario). Should I maybe suggest this change separately though that pull request somehow...?

That PR was interesting, but the feedback didn't get processed. Ever since, we've been working with wetland ORM which is available through a sails-hook; which is why this project hasn't gotten a lot of attention.

Thank you, I will have a look into wetland...
Would you consider merging this one? At the end I did start using this project myself, so I'm assuming others might find it too, potentially. Up to you, of course.

If you have a moment, what do you think of the following check?
if (!definition.column_default && definition.is_nullable.toLowerCase() === 'no') {}
else
    column.defaultsTo = definition.column_default;

I got a little confused and I'd need an expert eye, do you think it would be equivalent to...
if (definition.column_default || definition.is_nullable.toLowerCase() !== 'no')
    column.defaultsTo = definition.column_default;

@benomatis That's the same, yes.

Thanks, @RWOverdijk, I'm thinking of changing that and pushing it up here, what do you think?

@benomatis If that's what you want, I always enjoy making the code better, so I'd like it. But I'd also understand that you wouldn't feel like doing that for a "one-time tool".

Created it as a new pull request (https://github.com/SpoonX/sails-generate-models/pull/9), I wasn't sure if it was possible to add it to this one, I guess not, if it was closed...?

And to your point on making the code better, I'm the same, nonetheless this is my first ever contribution to a public repo, so feel a little excited, even though it's a tiny thing, and might not even be used anymore by people... I know, I'm a little pathetic, so I just hope this will be followed by much greater things... ;)

I like your way of thinking. Would you mind joining our chat on Gitter? https://gitter.im/SpoonX/Dev
Met vriendelijke groet / Kind regards,
Roberto Wesley Overdijk
SpoonX
Founder
M. +31 (0)6 15 55 32 43 (tel:+31615553243)
W. www.spoonx.nl (http://www.spoonx.nl)
E<EMAIL_ADDRESS><EMAIL_ADDRESS>KvK. 60422696
On 14 Apr 2017, 20:29 +0200, benomatis<EMAIL_ADDRESS>wrote:

And to your point on making the code better, I'm the same, nonetheless this is my first ever contribution to a public repo, so feel a little excited, even though it's a tiny thing, and might not even be used anymore by people... I know, I'm a little pathetic, so I just hope this will be followed by much greater things... ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/SpoonX/sails-generate-models/pull/7#issuecomment-294209064), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAvtsTdiSoe4Vj7118VGU6SGbwv4Vuf_ks5rv7sHgaJpZM4M8rW9).

sure, I just did. ;)


Use the Symfony progress bar when uploading directories.

As discussed in pull request #282.

Test fails, can you check and fix it before i merge your PR?

The problem seems to be in symfony/console.
I have implemented the progress bar as per the docs:
http://symfony.com/doc/current/components/console/helpers/progressbar.html
The error is:
There was 1 error:

1) Deployer\FunctionsTest::testUpload
Argument 1 passed to Symfony\Component\Console\Helper\Helper::strlenWithoutDecoration() must implement interface Symfony\Component\Console\Formatter\OutputFormatterInterface, null given, called in /home/koce/Projects/deployer/vendor/symfony/console/Symfony/Component/Console/Helper/ProgressBar.php on line 545 and defined

Is there any progress here @Max-Might?
Did you try to fix the issue?

Yes but I can't find where the problem is :(
I have implemented the progress bar as per the docs.
I get the output stream from deployer and pass it to the progress bar.
The error is in the symfony code.

It's not the Symfony Component that's at fault here, look at the error more closely: https://travis-ci.org/deployphp/deployer/jobs/64213311#L264
It has something to do the way the tests work.
For some reason during that test the output you're passing to the Progress Bar by calling output() giving you null  instead of a proper OutputFormatterInterface object when the component calls the getFormatter method on it : https://github.com/symfony/Console/blob/2.6/Helper/ProgressBar.php#L545
I hope this helps. :)

Yes, this error happens only when we run the tests.
Is this how we create the output stream for the test procedure?
https://github.com/deployphp/deployer/blob/master/test/recipe/Helper/RecipeTester.php#L50

Seems so.
The getFormatter method needs stubbing.

So, this issue have a next problems:

The ProgressBar should be configurable.

As example:
upload('/tmp/temporary.files', '/var/www/domain.com/tmp/temporary.files', true);

The third parameter indicated for use ProgressBar.

How this work in parallel?

What about parallel?

Looks like this needs rebasing.

Please, rebase.


Pokemon Puzzle Challenge: Cannot connect despite ROM identity being valid (BPNE01)

HintMachine version: 1.2.0-rc1
Game: Pokemon Puzzle Challenge
Game / Emulator version: BizHawk 2.9.1 + Gambatte Core
Bug description
Possible pointer issue? RAM Base Address appears to be 0 while ROM Base Address is populated. Looking at the hex editor confirms the code signature is fine (BPNE01) but when trying to connect, the 6 bytes read are all 0.
Screenshots

It worked on my machine, I need to try out other pointers to see which one is the most consistent

Introduced an alternative set of pointers in 03eacb9 on the beta branch, let me know if that fixes it for you

This one works for me


general space information page completed and ready to merge

general space information page completed and ready to merge

@KP-Kim - you've got some checks to do first. Handle this merging problem and I'll close the pull request


Redirect with status code 301

I'm using PrerenderTagHelper and I wanted to implement redirect logic. So I resolved promise in main-server.js with object
resolve({
statusCode: statusCode,
redirectUrl: redirectUrl,
html: html,
});
It works fine, but I noticed that I got a response with status code 302, which is not SEO friendly in my case. What I need is 301 status code
Is there any chance that redirect will be improved in the further release?  And how would you recommend to deal the issue for now?
Thank you

PrerenderTagHelper itself doesn't have any special support for 301s. It just uses the default 302 redirections.
If you need to control this more precisely, you could consider:

Calling ISpaPrerenderer.RenderToString directly from your C# code. This returns a RenderToStringResult so you can see the redirection status code and handle it however you want.
Or, move to the UseSpaPrerendering API from the SpaServices.Extensions package, as it already has logic for recognising 301s and preserving that status code in the response. Docs: https://docs.microsoft.com/en-us/aspnet/core/spa/angular?tabs=visual-studio#server-side-rendering


No rule to process module.modulemap for architecture i386

I want my project to support iOS 7 and later, so I copy all source files from SQLite project.
But Xcode 6.3.2 gives the following warning.
Warning: no rule to process file 'myprojectPath/SQLite/module.modulemap' of type sourcecode.module-map for architecture i386.
Should I just remove module.modulemap from my project's build phases/compile sources?

Yep.


Permission problems

I am trying to use VLC installed with homebrew-cask to watch live streams with Livestreamer 1.8.1. I set the player to /opt/homebrew-cask/Caskroom/vlc/2.1.4/VLC.app and when I try to run Livestreamer I get:
cli][info] Starting player: /opt/homebrew-cask/Caskroom/vlc/2.1.4/VLC.app
error: Failed to start player: /opt/homebrew-cask/Caskroom/vlc/2.1.4/VLC.app ([Errno 13] Permission denied)
When I run Livestreamer with VLC in the normal installation folder /Applications/VLC.app, it works fine. Is there a way fix this permission error?

holy hell I've had this problem for months and only now have I found this solution. I guess it makes sense since VLC.app is just a directory...


Marking SDL2 as required because the library fails to build and link …

…without it, at least on Visual Studio 2015 with OpenCV turned off.

What library fails to build without it? It builds just fine on linux and mac, and I build it just fine without it on VC2015.3.

Okay, so now it is working - must have been because my computer's clock had just reset its time and everything was building strangely.  Sorry for the false alarm.


Artifact Sidetab Repeatedly Opens and Breaks Chat Overview When Switching Between Threads with and Without Artifacts

Bug Report
Bug Summary:
The artifact sidetab opens repeatedly when switching between conversation threads. If one thread has an artifact (e.g., HTML), this causes the artifact tab to show up constantly, even when switching to other threads without artifacts, breaking the overview sidetab functionality and workflow.
Second Problem: Chat Overview will be also constantly suppressed by this behaviour of course!
Installation Method
Manual installation on Windows 10
Environment

Open WebUI Version: open-webui-0.3.32

Ollama (if applicable):  v0.3.12

Operating System: Windows 10

Browser (if applicable): Chrome Version 129.0.6668.100

Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.
[ ] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
When switching between conversation threads where only one thread has artifacts (such as HTML to render), the artifacts should display correctly only when selected.
Actual Behavior:
When one conversation thread contains an artifact (HTML), clicking between threads causes the artifact sidetab to constantly open, even when the other thread has no artifacts. This results in continuous sidetab spam, affecting both the artifact overview and breaking the flow when copying information.
Description
Bug Summary:
The artifact sidetab opens repeatedly when switching between conversation threads. If one thread has an artifact (e.g., HTML), this causes the artifact tab to show up constantly (even when closing the sidetab), when switching to other threads without artifacts, breaking the overview sidetab functionality and workflow.
Reproduction Details
Steps to Reproduce:

Open Open WebUI v0.3.32 in Chrome.
Create two conversation threads:

One thread contains an artifact (e.g., HTML).
The other has no artifact.

Click between the two conversation threads.
Notice that the artifact sidetab continues to open in artifact-less thread regardless if one has closed the sidetab ONCE.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
See attached clip!
https://github.com/user-attachments/assets/20a796f2-5be6-4860-87da-4029067ddc4d
Docker Container Logs:
N/A
Screenshots/Screen Recordings (if applicable):
[Attach any relevant screenshots to help illustrate the issue]
Additional Information
This issue affects the usability of switching between conversation threads and disrupts the workflow, especially when copying data from threads. It appears to be related to how artifacts are handled across multiple threads.
Note
If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Could you share your chat export here?

Could you share your chat export here?

chat-export-1728780188184.json
The json, will this suffice?


Echo warning of "device may be turned off" after completing action successfully

I just wanted to say thanks for this awesome piece of software first of all.
Since upgrading to 4.0.2 and trying out the multiple activities option Alexa tells me the activity failed and may not be plugged in.
This is after it completed.
The activities are a harmony scene, followed by two Vera devices turning off with delays.
The log shows the harmony scene command as info but nothing else.
It all works fine. But after the last light goes up Alexa warns me incorrectly every time.
This is only happening with multiple command not single devices.
Cheers

i believe this our favorite alexa issue where  the command takes too long.

Did I answer your question?


Merge docs updates back into mrtk_dev

Overview
Since our docs are generated from mrtk_dev, it'd be good to get these updates back into the github.io page.

/azp run mrtk_docs


pilot: return the 'InvalidArgument' error code when parsing the node metadata fail

For having more fine-granular view for the error,
PR proposes to return the "invalid argument" error code for the parsing error of node metadata.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/cherrypick release-1.15

/cherrypick release-1.14

/cherrypick release-1.13

@ingwonsong: new pull request created: #41476

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingwonsong: new pull request created: #41477

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingwonsong: new pull request created: #41478

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick release-1.16

@howardjohn: new pull request created: #41493

In response to this:

/cherrypick release-1.16

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


How to install the dependencies correctly?

Describe the bug
Hello, I'm trying to build openroad, so I intall the dependencies first, but I got this kind of problem, I don't know how to handle it.
Expected Behavior
install the dependencies correctly
Environment
Git commit: 0264023b6c2a8ae803b8d440478d657387277d93
kernel: Linux 4.18.0-240.1.1.el8_3.x86_64
os: CentOS Linux 8
cmake version 3.20.3
CMake Error at /usr/local/cmake-3.20.3-linux-x86_64/share/cmake-3.20/Modules/CMakeTestCXXCompiler.cmake:59 (message):
  The C++ compiler

    "/usr/local/bin/c++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /tmp/tmp.ut2MlU26q6/CMakeFiles/CMakeTmp

    Run Build Command(s):/usr/bin/gmake -f Makefile cmTC_202f5/fast && /usr/bin/gmake  -f CMakeFiles/cmTC_202f5.dir/build.make CMakeFiles/cmTC_202f5.dir/build
    gmake[1]: Entering directory '/tmp/tmp.ut2MlU26q6/CMakeFiles/CMakeTmp'
    Building CXX object CMakeFiles/cmTC_202f5.dir/testCXXCompiler.cxx.o
    /usr/local/bin/c++    -o CMakeFiles/cmTC_202f5.dir/testCXXCompiler.cxx.o -c /tmp/tmp.ut2MlU26q6/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
    Linking CXX executable cmTC_202f5
    /usr/local/cmake-3.20.3-linux-x86_64/bin/cmake -E cmake_link_script CMakeFiles/cmTC_202f5.dir/link.txt --verbose=1
    /usr/local/bin/c++ CMakeFiles/cmTC_202f5.dir/testCXXCompiler.cxx.o -o cmTC_202f5
    /usr/bin/ld: cannot find crtbegin.o: No such file or directory
    /usr/bin/ld: cannot find -lstdc++
    collect2: error: ld returned 1 exit status
    gmake[1]: *** [CMakeFiles/cmTC_202f5.dir/build.make:99: cmTC_202f5] Error 1
    gmake[1]: Leaving directory '/tmp/tmp.ut2MlU26q6/CMakeFiles/CMakeTmp'
    gmake: *** [Makefile:127: cmTC_202f5/fast] Error 2

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:84 (project)

-- The CXX compiler identification is GNU 7.5.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - failed
-- Check for working CXX compiler: /usr/local/bin/c++
-- Check for working CXX compiler: /usr/local/bin/c++ - broken
-- Configuring incomplete, errors occurred!

To Reproduce
run sudo ./etc/DependencyInstaller.sh in the OpenROAD root folder
Relevant log output
(base) [yzhu@rios-cad1 OpenROAD]$sudo ./etc/DependencyInstaller.sh
Updating Subscription Management repositories.

This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.

No match for argument: ius-release
No match for argument: epel-release
Dependencies resolved.
================================================================================================================
 Package                Architecture             Version                  Repository                       Size
================================================================================================================
Removing:
 lcov                   noarch                   1.14-1                   @@commandline                   369 k

Transaction Summary
================================================================================================================
Remove  1 Package

Freed space: 369 k
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                1/1
  Erasing          : lcov-1.14-1.noarch                                                                     1/1
  Running scriptlet: lcov-1.14-1.noarch                                                                     1/1
  Verifying        : lcov-1.14-1.noarch                                                                     1/1
Installed products updated.

Removed:
  lcov-1.14-1.noarch

Complete!
Updating Subscription Management repositories.

This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.

Last metadata expiration check: 2:43:59 ago on Thu 02 Mar 2023 04:34:50 PM CST.
lcov-1.14-1.noarch.rpm                                                           31 kB/s |  99 kB     00:03
Dependencies resolved.
================================================================================================================
 Package                Architecture             Version                   Repository                      Size
================================================================================================================
Installing:
 lcov                   noarch                   1.14-1                    @commandline                    99 k

Transaction Summary
================================================================================================================
Install  1 Package

Total size: 99 k
Installed size: 369 k
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                1/1
  Installing       : lcov-1.14-1.noarch                                                                     1/1
  Running scriptlet: lcov-1.14-1.noarch                                                                     1/1
  Verifying        : lcov-1.14-1.noarch                                                                     1/1
Installed products updated.

Installed:
  lcov-1.14-1.noarch

Complete!
Updating Subscription Management repositories.

This system is registered to Red Hat Subscription Management, but is not receiving updates. You can use subscription-manager to assign subscriptions.

Last metadata expiration check: 2:44:05 ago on Thu 02 Mar 2023 04:34:50 PM CST.
ius-release-el7.rpm                                                             8.3 kB/s | 8.2 kB     00:00
Error:
 Problem: conflicting requests
  - nothing provides epel-release = 7 needed by ius-release-2-1.el7.ius.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Screenshots
No response
Additional Context
here is my linux platform

Please run sudo yum update and check cmake version. Minimum required version is 3.24.3.
You're using 3.20.3 version.

As per user update from slack channel, CentOS 8 unable to pull packages from existing path with sudo yum update. Suggested to try this fix: https://www.tecmint.com/error-failed-to-download-metadata-for-repo-appstream/

@b224hisl Are you able to resolve it?


Stop handling down/up sequence only when all fingers have been removed

Fix #6423
And also fix another issue I discovered :

Start translating a feature with one finger.
While still holding that finger, just tap with another finger.
On v3.20.1, Translate Interaction stop working. On master, it's more random.

This looks to me like it introduces a new pinch zoom bug.  Unless I very carefully remove both fingers at the same time, there is an unwanted pan at the end of a zoom.

Thanks for the suggested fix.  I incorporated this into #6445.  There may be more to do, but pinch zooming is working again now.


System.Reflection.ReflectionTypeLoadException (only on mac / linux)

Description
This error is caused in one of my xUnit tests, but I believe has nothing to do with xUnit. The problem does not occur on windows, only linux and mac.
Error Message:
 System.AggregateException : One or more errors occurred. (Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.) (The following constructor parameters did not have matching fixture data: TestFixture fixture)
---- System.Reflection.ReflectionTypeLoadException : Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
---- The following constructor parameters did not have matching fixture data: TestFixture fixture
Stack Trace:

----- Inner Stack Trace #1 (System.Reflection.ReflectionTypeLoadException) -----
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeAssembly.get_DefinedTypes()
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at AutoMapper.ServiceCollectionExtensions.AddAutoMapperClasses(IServiceCollection services, Action`1 additionalInitAction, IEnumerable`1 assembliesToScan)
   at ResourceEntitySeparationExample.Startup.ConfigureServices(IServiceCollection services) in /Users/Moeys/Code/rs/rs-api/JsonApiDotNetCore/src/Examples/ResourceEntitySeparationExample/Startup.cs:line 59
   at ResourceEntitySeparationExampleTests.TestStartup.ConfigureServices(IServiceCollection services) in /Users/Moeys/Code/rs/rs-api/JsonApiDotNetCore/test/ResourceEntitySeparationExampleTests/TestStartup.cs:line 17
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.ConfigureServices(IServiceCollection services)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.EnsureApplicationServices()
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.Initialize()
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
   at Microsoft.AspNetCore.TestHost.TestServer..ctor(IWebHostBuilder builder, IFeatureCollection featureCollection)
   at ResourceEntitySeparationExampleTests.TestFixture..ctor() in /Users/Moeys/Code/rs/rs-api/JsonApiDotNetCore/test/ResourceEntitySeparationExampleTests/TestFixture.cs:line 30
----- Inner Stack Trace #2 (Xunit.Sdk.TestClassException) -----

Steps to reproduce
To reproduce the errors, please clone this project and run the ResourceEntitySeparationExampleTests. Don't forget to remove the docfx package reference, else the project won't build :)
Expected behavior
no error
Actual behavior
error
Environment
.NET Core SDK
Version:   2.2.102 (but same error on all previous SDKs afaik
Commit:    96ff75a873
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.14
OS Platform: Darwin
RID:         osx.10.14-x64
Base Path:   /usr/local/share/dotnet/sdk/2.2.102/
Host (useful for support):
Version: 2.2.1
Commit:  878dd11e62

This repo is for MSTest Framework. From the description, you will need to report this in the xUnit repo.


Fix the minimal/lto configuration

We need to disable opaque pointers when we compiler the runtime the linker complains:
  ld: Opaque pointers are only supported in -opaque-pointers mode

Alternatively, we could pass the opaque-pointers flag to the linker but then it would complain about the swiftc generated files which still use typed pointers.
Until swiftc is fixed, disable opaque pointers for .cpp runtime files.
rdar://106515243

@swift-ci test

@swift-ci test

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset


Licenses.txt to attributions.yml

About the PR
Based on Issue 15607 I started converting licenses.txt to attributions.yml. Woo was that a mistake, well doesn't matter, so there are some issues with it:

Some files aren't mentioned at all anywhere so there is no way to credit them.
Some files are wrongly licensed and some don't even have a proper source.
We will have to find replacements for some files because we cant even use them, bellow will be a list of sounds we cant use or are missing a license or I can't find the author/source.

Files may need replacing:

at /Audio/Effects/
hit_kick.ogg: WE ARE NOT ALLOWED TO USE https://taira-komori.jpn.org/freesounden.html (By Taira Komori)

And some questions:

How specific should the source links be? Can I just add for example if its from tgstation just link the repo or the exact folder the file is in?
From this point on could pull requests that add something to the resources folder and don't add the thing to a attributions.yml file (if its required) reminded to do so and made sure its added correctly?

(Oh yeah I plan on continuing, the plan is: First add everything that is mentioned to attributions.yml files and then check one by one if the license is correct, if the source is correct and lastly add the author in the copyright field because in some I just added for example: by tgstation not the actual author.)

Thanks for this amazing game devs! :)

pop.ogg was created and added by me, the soniss sounds should also all be fine: https://sonniss.com/gameaudiogdc

pop.ogg was created and added by me, the soniss sounds should also all be fine: https://sonniss.com/gameaudiogdc

Nice, so what license should I use for your sound or any other of your sounds? The one most assets use: CC-BY-SA 3.0? Or MIT which is the license for this whole repo?

CC0 1.0

Alr so we still have a problem with that last one. Should I contact the creator and ask him/her if we can use this one? Or should I stay quite until we find a replacement?

would rather just replace sounds esp if they're super generic

Found a good enough replacement under the CC0 1.0 here freesound.org, will cut it and add it to this DPR.

I am aware of the many errors, working on it rn.

FINALLY MY GOD.

Alr so the only issues left should be the ones listed above, also that one font we cant use it. Like really we cant its paid.

Oh yeah it can be merged now

Everything should be alr, if it isnt just create an issue (after this gets merged) and mention me.

 I ONLY ADDED .YML FILES AND ONE SOUND FILE WHY IS NOT COMPILING PROPERLY?!?!?!

My God. I will look into it when I get some sleep and comeback from school. Look through every single file again to make sure everything is how it should be.

You should really break this pr up coz it's going to be conflict bait and take time to address reviews.

You should really break this pr up coz it's going to be conflict bait and take time to address reviews.

How can I do that? The conflicts are easy to resolve anyway.

Hi ElectroJr, I've been also working on closing that issue (on converting license.txts into RGA), but I was too slow + lazy, so I haven't made a PR. If you're saying

You can, and should, just open multiple smaller PRs.

then I can probably open PRs with stuff I've converted so far. I have checked links' licenses so they match the actual licenses. I've also marked some files that need to be changed due to either unavailable video (if the source is a YT video) or an incorrect license. So let me know if it's good to also open a PR, I can also try to replace audios that needs to be replaced.
Also it seems like HighTechPuddle missed some files in RGAs, e.g.: Announcements/attributions.yml, if you compare the number of audio files in the folder and number of files in the RGA, you'll notice that some are missing (it's cause HighTechPuddle hasn't ensured that original license.txts contain all the files for a folder, which is untrue for some cases), meanwhile the RGAs I've done so far don't have that "issue".

I see I did a really bad job, I am sorry I rushed it so much I will rework it entirely following the specified rules and will break it down to smaller PRs.

No need to apologies, your effort is still very much appreciated. And as @ficcialfaint just said they were also working on converting some of the files, which is a another reason why smaller PRs is better, you should probably coordinate so you don't work on the same files at the same time (or just open a draft PR which makes it clear which files you're each working on).
And for faint's comment, yeah some files are just missing attributions and either need to be tracked down or need replacing.


Add base setup for UI

Includes task runners
Compilers
Transpilers
HTMLs, Scss, JS
Changes in the readme explaining the procedure to run

@srivathsankr7 Please review

Changes accepted


Randomize vehicles appearance with different color

Hi @Edwardhk ! Prof. provides an idea that we should make the target vehicles colorful instead of only using red skin!
Previously, @zqh0253 has tried to overwrite the model's texture with pure colors, could you please provides a tutorial on how to do this? We will formalize that idea and create a formal pipeline for color randomization!
@Edwardhk could you please also add this into your to do list? That's an important feature for visualization! Here I draw some items that might need to be used:

find a way to color a single vehicle, create a function for this. If the color of vehicle can be changed run-time that would be great! (run-time means, since we are in MARL env, change the color when re-spawning an existed vehicle to a new location).
call this function when initializing and re-spawning vehicles to new spawn points
provide a config entry to enable / disable this feature
choose a color platte that are colorful yet beautiful

@lqy any other suggestion?
Thanks!

If you want to overwrite a model's texture and apply customized color, you could write a shader and apply that shader to the rendered object.
The DepthCAM in PGDrive is also implemented in this way. You could have a look at its vertice shader file and fragment shader file.

Please feel free to raise question here! @Edwardhk


Demo site broken

Not sure if you are aware but the demo site is broken, none of the animations are working on Chrome v54 Linux.

I can't test it as I have no 64bit Linux distro at my disposal, but I think this is an issue related to Chrome or to GPU acceleration in Chrome.
Animate CSS should work in any capable browser that supports 3d transform and animations. As you're using Linux, it's kinda of usual to not have 3d acceleration turned off because of the lack of drivers. As the system can't use the GPU for transforms, I think that Chrome might be having a bad time with animations. But it's just a guess.

Just tested it on a Mac and it works as expected...guess the latest versions of Chrome for Linux (v54 & v55) are broken.
When you select a new animation from the drop down nothing happens and clicking the animate button refreshes the page instead of executing the selected animation.
The actual animations still work fine in practice however, its just the implementation on the demo site that seems to be broken.

This has been fixed with an updated version of Chrome on Linux.


stm32cubemx: Can't initiate JxBrowser engine

Describe the bug
When clicking "GENERATE CODE" nothing happens, and I get  the error from title in the console log.
I'm not familiar with java but I guess newer cubemx versions require some browser like functionality which failed to init within java runtime due missing .so dependencies.
Startup Info:
log4j user configuration file not found: /home/akill/.stm32cubemx/log4j2.xml
Configure log4j with default settings from jar:file:/nix/store/3mv4p1lz0xmmy5cb3zz9d74vsmqyj58m-stm32cubemx-6.9.2/opt/STM32CubeMX/STM32CubeMX!/log4j/log4j2.stm32cubemx.xml
2023-12-05 21:06:19,347 [INFO] MicroXplorer:98 - [MX] MX Start ==<PHONE_NUMBER>9392
2023-12-05 21:06:19,348 [INFO] MicroXplorer:653 - Detected Java Version = 17.0.7
2023-12-05 21:06:19,620 [INFO] ApplicationProperties:184 - Using Application install path: /nix/store/3mv4p1lz0xmmy5cb3zz9d74vsmqyj58m-stm32cubemx-6.9.2/opt/STM32CubeMX
2023-12-05 21:06:19,632 [INFO] DbMcusXml:78 - Set database path to: /nix/store/3mv4p1lz0xmmy5cb3zz9d74vsmqyj58m-stm32cubemx-6.9.2/opt/STM32CubeMX//db//mcu/
2023-12-05 21:06:19,632 [INFO] ApiDb:274 - Set plugin database path to: /nix/store/3mv4p1lz0xmmy5cb3zz9d74vsmqyj58m-stm32cubemx-6.9.2/opt/STM32CubeMX//db//plugins/boardmanager/

Relevant error log:
2023-12-05 21:06:23,473 [ERROR] JxBrowserEngine:69 - Can't initiate JxBrowser engine com.teamdev.jxbrowser.engine.MissingDependencyException: Missing dependencies have been detected:
	libGLESv2.so => libXext.so.6 libxcb.so.1 libX11.so.6
	chromium => libXfixes.so.3 libasound.so.2 libXcomposite.so.1 libcairo.so.2 libxcb.so.1 libpango-1.0.so.0 libgio-2.0.so.0 libatspi.so.0 libatk-bridge-2.0.so.0 libXext.so.6 libdrm.so.2 libnspr4.so libxkbcommon.so.0 libnssutil3.so libcups.so.2 libgbm.so.1 libglib-2.0.so.0 libsmime3.so libatk-1.0.so.0 libgobject-2.0.so.0 libexpat.so.1 libdbus-1.so.3 libXdamage.so.1 libXrandr.so.2 libnss3.so libX11.so.6
	libtoolkit.so => libgtk-3.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libX11.so.6 libgdk-3.so.0
Exception in thread "Thread-3" java.lang.NullPointerException: Cannot invoke "javax.swing.JComponent.setVisible(boolean)" because "this.webAppContainer" is null
	at com.st.microxplorer.plugins.userauth.UserAuth.activatePlugin(UserAuth.java:200)
	at com.st.microxplorer.maingui.MainFrame.lambda$initialization$0(MainFrame.java:189)
	at java.base/java.lang.Thread.run(Thread.java:833)

java.lang.NullPointerException: Cannot invoke "com.teamdev.jxbrowser.browser.Browser.mainFrame()" because "this.browser" is null
	at com.st.microxplorer.plugins.userauth.WebApp.isAuthenticated(WebApp.java:615) ~[?:?]
	at com.st.microxplorer.plugins.userauth.UserAuth.handleAuthentication(UserAuth.java:452) ~[?:?]
	at com.st.microxplorer.plugins.userauth.UserAuth.getSpecificTask(UserAuth.java:259) ~[?:?]
	at com.st.microxplorer.plugins.projectmanager.gui.ProjectChoiceTab.save(ProjectChoiceTab.java:1349) ~[?:?]
	at com.st.microxplorer.plugins.projectmanager.ProjectManagerView.generateCode(ProjectManagerView.java:1068) ~[?:?]
	at com.st.microxplorer.plugins.projectmanager.ProjectManagerView.getSpecificTask(ProjectManagerView.java:729) ~[?:?]
	at com.st.microxplorer.maingui.RibbonBar$1.actionPerformed(RibbonBar.java:363) ~[STM32CubeMX:?]
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972) ~[?:?]
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313) ~[?:?]
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405) ~[?:?]
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262) ~[?:?]
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279) ~[?:?]
	at java.awt.Component.processMouseEvent(Component.java:6626) ~[?:?]
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3389) ~[?:?]
	at java.awt.Component.processEvent(Component.java:6391) ~[?:?]
	at java.awt.Container.processEvent(Container.java:2266) ~[?:?]
	at java.awt.Component.dispatchEventImpl(Component.java:5001) ~[?:?]
	at java.awt.Container.dispatchEventImpl(Container.java:2324) ~[?:?]
	at java.awt.Component.dispatchEvent(Component.java:4833) ~[?:?]
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948) ~[?:?]
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575) ~[?:?]
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516) ~[?:?]
	at java.awt.Container.dispatchEventImpl(Container.java:2310) ~[?:?]
	at java.awt.Window.dispatchEventImpl(Window.java:2780) ~[?:?]
	at java.awt.Component.dispatchEvent(Component.java:4833) ~[?:?]
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773) ~[?:?]
	at java.awt.EventQueue$4.run(EventQueue.java:722) ~[?:?]
	at java.awt.EventQueue$4.run(EventQueue.java:716) ~[?:?]
	at java.security.AccessController.doPrivileged(AccessController.java:399) ~[?:?]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) ~[?:?]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97) ~[?:?]
	at java.awt.EventQueue$5.run(EventQueue.java:746) ~[?:?]
	at java.awt.EventQueue$5.run(EventQueue.java:744) ~[?:?]
	at java.security.AccessController.doPrivileged(AccessController.java:399) ~[?:?]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) ~[?:?]
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:743) ~[?:?]
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203) ~[?:?]
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124) ~[?:?]
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113) ~[?:?]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109) ~[?:?]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) ~[?:?]
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:90) ~[?:?]

Steps To Reproduce

Spawn shell with stm32cubemx using  nix shell nixpkgs#stm32cubemx --impure.
Create CubeMX project
Generate Code

Expected behavior
Generated project folder with confirmation window.
Notify maintainers
@angaz @wucke13
Metadata
❯ nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.2, NixOS, 24.05 (Uakari), 24.05.20231127.8cfef69`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos"`
 - channels(akill): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

After further investigation I think CubeMX is trying to execute binaries found in ~/.stm32cubemx/.jxbrowser-7.30.2/Chromium, which it downloaded during first startup.
I'm not sure if this is fixable without FHS env.

This bug kind of kills my workflow. Has anyone investigated further? I will try to work things out during the weekend.

I've kinda got it to work using FHS env.
Only issue I have is that the CubeMX now requires login for code generation, and the login window (embedded browser) takes a while to appear on Wayland (Sway) and uses a lot of the CPU for no reason, while it appears OK on X11.
Though you only need to login once, and than it works normaly.
I have updated package here :
https://git.project-cloud.net/asmir/nixos_flake_config/src/branch/master/packages/stm32cubemx/default.nix
I guess I shold make a pull request out of it.

CubeMX now requires login for code generation
It is sad to see ST hurt us like this.

I would appreciate a PR, it seems to be a good solution. You can ping me and I'll have a look.
Not really sure what we can do about the wait and high CPU. I think getting the package usable again, and then trying to fix that problem sounds like a good way to progress.

Thanks for the fast replies! @asmir-abdulahovic  Do you recall how you approached debugging the issue?

@angaz
thanks, will make PR over the weekend most likely
@liarokapisv
I got simmilar error when I wanted to keep pached ~/.stm32cubemx/.../Chromium by setthnc chattr +i.
So cube didn't get permissions to extract Chromium and failed.
Maybe try to remove/backup .stm32cubemx and try again.

I have deleted ~/.stm32cubemx multiple times while doing these checks, and it doesn't change anything.

Than please try to run it with steam-run, maybe extractor is missing something too.
Also please try my package linked above. It's a closed source app so we are verry limited...

There are no libraries under the folder, only the lock file. JxBrowser does seem to support aarch64 linux but maybe there is something wrong at the cubemx side. Thanks for your help!

JxBrowser seems packed into CubeMX.
0:28:49.846 DEBUG Finding chromium-linux64-arm.7z... [FAIL]

Maybe indicated that they didn't put arm version.

Yea, that is possible. Thanks for the help!

Coincidentally, I also tried to get this running last week inside an FHS env, but even with (basically) all dependencies in there (and in x86_64), one of the chromium child processes crashed in some udev function.
It also tried to load some very old libraries like libgcrypt.so.11, for some reason.
Just patching our own chromium in there and preventing it from modifying it might be a better solution, if it can be made to work.


Draft changes are visible to the public

Bug Report
Description
When a draft version of a published work exists, users will be able to see the changes in the draft in the work history.
To Reproduce
TBA
Expected behavior
Work history changes for draft versions should only be visible to users who have edit permissions on the work.

Duplicated of #856

This was erroneously closed, but it's still an issue


Add detail to invalid spectra warning parsers.py

Warning should include why the spectra were invalid e.g. WARNING: Skipped 6745 spectra with invalid charge > 5.

Follow-up comment from Wout: "It can be any reason, including invalid charge, but also other issues encountered during parsing and preprocessing, such as an insufficient number of peaks. Considering that we report spectra as skipped if there's an exception thrown in the parsing/preprocessing without any way to record why those spectra are skipped, unfortunately it's not as simple as just providing more details in the log message."
That said, I think it would still be a good idea to provide this info, though I understand it might require some bookkeeping to track the counts for the various reasons a spectrum might be skipped.


Avalanche end-to-end tests

This is on my todo to review 🫡 Heading back from Brussels atm, sorry for the delay


How to add a tab as a link?

Laravel Version: 5.6.*
PHP Version: 7.1
Laravel-admin: 1.5

Description:
Hello!
How to add a tab as a link which will lead to the sub-page?
http://joxi.ru/12MY4YLHlMRoR2

Supported in version 1.5.x-dev now


SCIM user filtering with ge and le operations for JDBC userstores

The $subject has been introduced for LDAP user stores in https://github.com/wso2/product-is/issues/11214. But this is yet to be added to JDBC user stores.
Currently, JDBC user stores return "ge and le operations are not supported for JDBC userstores." error message at [1].
[1] https://github.com/wso2/carbon-kernel/blob/bd11a1f30f1b61cf44cb2d1e2a26b2fa2605f669/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/jdbc/UniqueIDJDBCUserStoreManager.java#L3282

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!

Reopening this issue as this capability is required when using the SCIM API to retrieve inactive users.


feat: Modify the video link text to a link that can be right-clicked to download

…to download

感谢pr，我会尽快发布这个改动


loadFile from disk?

is there any way to loadFile from disk with absolute path?
Currently I have only two options

Use data in the same path

stage.loadFile('./test.pdb')

make Blob

The browser does not have direct access to the file system for security reasons. It has to go either through a web server or be initiated by the user selecting a file through a file open dialog. Note that there are workarounds for development using command line flags when starting the browser, but these disable said security features.

ok I see. So just let nglview users to use relative path. For text file, could use Blob
blob = open('test.txt').read()
view._remote_call("loadFile", target='Stage',
       args=["type": "blob", 'data': blob])


Add a DragPreviewDiv similar to DragPreviewImage or allow the drag div to work with display="none"

Hello,
I'm using react-dnd in the mui-datatables project to allow for draggable columns. You can see the dragging in action here (drag a column header):
https://codesandbox.io/s/muidatatables-custom-toolbar-hbej7
If you drag the column header over the white area of the page you'll see the drag-preview is a snapshot of the column header. I'm not really a fan of the big white rectangles and would like to make the drag div have rounded corners and a width that was of that of the column header text (and no longer).
I know I can add ref={preview} to another div and that will work, but that has the following problems:

If the div has "display:none" it won't appear as the drag div.
Off screen drag divs don't work.

That means the drag div has to be visible, which is not optimal. The closest workaround I have for this is to put the drag div behind the div I want to drag. You can see that in action here:
https://codesandbox.io/s/elegant-beaver-t8vjg
But as you can tell, even that is not optimal, it also seems a little hacky. It would be nice if there was a way to use another div as the drag image without that div having to be visible on screen.

Hello. You said I'm using react-dnd in the mui-datatables project but I couldn't find any usage of react-dnd in your project (first link), so no way to tell how you are making use of react-dnd.
Shooting blindly I'd probably recommend you to compute "isDragging" via react-dnd and attach a css class to the table header, then with css you could change it's width, maybe display: inline or something.

@leftdevel The library, mui-datatables, uses react-dnd for the column dragging (in the codesandbox above you can drag a column head over another column header).
Using isDragging won't affect the drag preview/snapshot as it's taken right before the dragging starts.

@patorjk If it is still relevant, I had the same issue and solved it using react-dnd-preview


[storage-blob] Migrate test recordings out of repo

Packages impacted by this PR
@azure/storage-blob
Describe the problem that is addressed by this PR
Migrate test recordings out of the repository using the steps provided by the asset sync guide: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/ASSET_SYNC_MIGRATION.md

API change check
API changes are not detected in this pull request.

Beautiful 🟩


[2.x] Dark Mode issues

Package
filament/filament
Package Version
2.10.4
Laravel Version
8.83.0
Livewire Version
2.10.1
PHP Version
8.1.1
Bug description
If anyone facing the issues Kindly let me know in the comments and I will add to the List.  So that it can be tracked and Fixed and upcoming version
Here I am pointing out the List of UI issues caused by Dark Mode.

[ ]  Toggle Field Icon is displayed with white background.
[ ]  Relation Managers tab heading is blurred and while hovering the text turns into black or gray .

Toggle Field Icon is displayed with white background
Screenshot

Reproducible Code
    Toggle::make('is_active')
        ->label('Is Active ?')
        ->inline(false)
        ->onIcon('heroicon-o-check')
        ->offIcon('heroicon-o-x'),

Relation Managers tab heading is blurred and while hovering the text turns into black or gray
Screenshot

Reproducible Code
    Add more than one relation managers to page and you can see the difference

cc @danharrin  @ryangjchandler @ryanscherler

@danharrin  please pin the issues so that users don't duplicate it.

Fixed by #1595 and #1597.

using toggle in Table Filter still causes the issue. In form it looks fine with border but in filter it doesn't have any borders around it

Fixed in the next release

Select displays with light background when searchable() is used


fix: use close as destroyMethod of Bean

Operator does not have a stop method.
In accordance with the meaning, instead of the stop method, the close method was modified to operate as destroyMethod .

Thx @KimDoubleB . good catch!


NRE in InitPowerUpdate()

This error only happens when starting a new game.
[Error  : Unity Log] Thread Error Exception!!! Thread idx:11 LabOutput2Next Factory idx:0 LabOutput2Next gametick System.NullReferenceException: Object reference not set to an instance of an object
  at CommonAPI.ComponentTypePool.InitUpdate () [0x0001a] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at CommonAPI.Pool`1[T].UpdatePoolMultithread (System.Int32 usedThreadCount, System.Int32 currentThreadIdx, System.Int32 minimumCount, System.Func`1[TResult] initFunc) [0x00014] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at CommonAPI.ComponentSystem.UpdateMultithread (System.Int32 usedThreadCount, System.Int32 currentThreadIdx, System.Int32 minimumCount) [0x00013] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at CommonAPI.FactorySystemStorage.UpdateMultithread (PlanetFactory factory, System.Int32 usedThreadCount, System.Int32 currentThreadIdx, System.Int32 minimumCount) [0x00017] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at CommonAPI.CustomFactory.UpdateMultithread (PlanetFactory factory, System.Int32 usedThreadCount, System.Int32 currentThreadIdx, System.Int32 minimumCount) [0x00012] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at CommonAPI.FactorySystemPatch.UpdateMultithread (FactorySystem __instance, System.Int64 time, System.Boolean isActive, System.Int32 _usedThreadCnt, System.Int32 _curThreadIdx) [0x00001] in <5f356e1a9f6e4e3a9c50a90806901285>:0
  at FactorySystem.GameTickLabOutputToNext (System.Int64 time, System.Boolean isActive, System.Int32 _usedThreadCnt, System.Int32 _curThreadIdx, System.Int32 _minimumMissionCnt) [0x00005] in <b91ee4606c7b437f97b70b73197d6f25>:0
  at WorkerThreadExecutor.LabOutput2NextPartExecute () [0x00035] in <b91ee4606c7b437f97b70b73197d6f25>:0

(Error above related but the image below shows the issue)
Mod is DSPSaveMod and afaik because IntoOtherSave is called too early

More details regarding this issue. Error above is only a symptom. Real issue is that function IntoOtherSave is being called too early for new games. When loading and saving its called on initialized game state. But when its called on new save its called before anything is even initialized. This inconsistency is what causes error above. Fix is simple though:
change patch on function EnterGame from
[HarmonyPatch(typeof(UIGalaxySelect), "EnterGame")]
To
[HarmonyPatch(typeof(GameData), "NewGame")]
This will fix this issue.

Fixed by reuploading the mod under different name with the fix. https://dsp.thunderstore.io/package/CommonAPI/DSPModSave/


chore(master): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-10-23)
Features

update deps (d226f2d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ScribeLabsAI/ScribeMiNode/releases/tag/1.0.0 :sunflower:


Extend expr types

Description
The selector, index, and identifier expression only worked inside call expressions ie: equals(some.selector, "banana"). I couldn't do this some.selector == "banana". It would be nice when user's type a query, they can use this shorter and maybe more recognizable expression as well (as seen in this rfd)
The evaluateExpr method already contained all the logic we needed to handle this, so I added this call when we start parsing.
Example use case:
Selector
`first.second.third == "something"`

Index
`first.second["key"] == "something"`

Identifier
`name == "something"`

IIUC the parser system basically already supported these kinds of equality expressions, but they didn't really expect to hit them at the top level, yeah? Like this isn't adding new functionality so much as changing what the parser expects to find where?

yup

closing b/c changes have been approved and these changes are exact of the commit already in master 18a87524aab1abdcd4b908ec2cebdbc611692fee


iOS build succeeds but ipa file does not seem to be accessible from Firebase

I have an iOS build that I am running with CircleCI with the intention for it to be distributed to testers via Firebase.
The build succeeds and I get confirmation the ipa has been uploaded to FIrebase, the specified tester(s) get an email notification, but when they try to access the app they simply get a message saying there is no app.
The Firebase console on my end updates with a distribution and the tester information, but from what I can tell there there does not seem to be any ipa attached to the distribution.
I have ssh'd into the passing Circle build to ensure the ipa is created, and have downloaded it manually.
Please see below my Fastfile, config.yml and build log, is there something I am missing?
Fastfile:
platform :ios do
  before_all do
    setup_circle_ci
  end

  lane :beta do
    match(
      type: "appstore",
      team_id: TEAM,
      app_identifier: APP_ID,
      output_path: "./builds",
      keychain_name: "fastlane_tmp_keychain",
      readonly: is_ci
    )
    settings_to_override = {
      :BUNDLE_IDENTIFIER => APP_ID,
      :PROVISIONING_PROFILE_SPECIFIER => PROFILE,
      :DEVELOPMENT_TEAM => TEAM
    }
    update_project_team(
      teamid: CredentialsManager::AppfileConfig.try_fetch_value(:team_id)
    )
    increment_build_number(xcodeproj: "MyApp.xcodeproj")
    build_app(
      clean: true,
      export_method: "app-store",
      build_path: "./builds",
      output_directory: "./builds",
      xcargs: settings_to_override,
      scheme: "My app",
      export_options: {
        signingCertificate: SIGNING_CERTIFICATE,
        provisioningProfiles: {
          APP_ID => PROFILE
        }
      }
    )
    firebase_app_distribution(
      app: FIREBASE_APP_ID,
      testers: TESTER,
      release_notes: "New updates to test",
      ipa_path: "/Users/distiller/repo/ios/builds/myIpa.ipa",
      firebase_cli_path: "/Users/distiller/repo/node_modules/.bin/firebase"
    )
  end
end

Circle config:
version: 2
jobs:
    build:
        macos:
            xcode: '10.3.0'

        working_directory: ~/repo
        environment:
            FASTLANE_LANE: beta

        steps:
            - checkout
            - run:
                  # We can't set this using an image because that makes the build run in a Linux box
                  name: 'Manually set ruby version to 2.6.3'
                  command: echo "ruby-2.6.3" > ~/.ruby-version
            - run:
                  name: install bundler
                  command: gem install bundler --version 2.0.1
            - run: cd ./ios && bundle install
            - run:
                  # This is necessary to ensure that native modules will compile properly
                  name: 'Install specific Node and NPM versions'
                  command: |
                      curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.1/install.sh | bash
                        echo 'export NVM_DIR="$HOME/.nvm"' >> $BASH_ENV
                        echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
                        echo 'nvm install v10.17.0' >> $BASH_ENV
                        echo 'nvm alias default v10.17.0' >> $BASH_ENV
            - run:
                  name: 'Install JS dependencies and run post-install steps'
                  command: npm install
            - run:
                  name: Fastlane
                  command: cd ./ios && bundle exec fastlane $FASTLANE_LANE

Circle build passing:
[09:41:51]: Successfully exported and compressed dSYM file
[09:41:51]: Successfully exported and signed the ipa file:
[09:41:51]: /Users/distiller/repo/ios/builds/Converge.ipa
[09:41:51]: ---------------------------------------
[09:41:51]: --- Step: firebase_app_distribution ---
[09:41:51]: ---------------------------------------
[09:41:56]: ▸ i  getting app details...
[09:41:57]: ▸ i  uploading distribution...
[09:42:10]: ▸ ✔  uploaded distribution successfully
[09:42:10]: ▸ i  adding release notes...
[09:42:11]: ▸ ✔  added release notes successfully
[09:42:11]: ▸ i  adding testers/groups...
[09:42:11]: ▸ ✔  added testers/groups successfully

+------+---------------------------+-------------+
|                fastlane summary                |
+------+---------------------------+-------------+
| Step | Action                    | Time (in s) |
+------+---------------------------+-------------+
| 1    | default_platform          | 0           |
| 2    | setup_circle_ci           | 0           |
| 3    | is_ci                     | 0           |
| 4    | match                     | 2           |
| 5    | update_project_team       | 0           |
| 6    | increment_build_number    | 2           |
| 7    | build_app                 | 654         |
| 8    | firebase_app_distribution | 20          |
+------+---------------------------+-------------+

Hi LukeAveil, Fabric/Firebase DevRel here.
How many testers do you have? Do they all get the same problem?
Also, can you let me know what your project id is? It will help me look into this better :)
If you don't feel comfortable sharing here, you can reach us at here so we can discuss with more details :)

Facing the same issue even when running locally:
Xcode: 12
fastlane: 2.145.0
fastlane-plugin-firebase-app-distribution: 0.2.1

works after updating to fastlane-plugin-firebase-app-distribution: 0.2.1

Same problem here, even on the latest version (0.2.4)

Having the same problem here, Fastlane shows "App Distribution upload finished successfully." message but there's nothing in firebase

Similar problem here (on 0.2.5): most of the time only the first build and upload result in a correct version in Firebase App Distribution and the consecutive ones report success but nothing shows up. We use Github Actions as CI if that matters

Similar problem here (on 0.2.5): most of the time only the first build and upload result in a correct version in Firebase App Distribution and the consecutive ones report success but nothing shows up. We use Github Actions as CI if that matters

Also here is nothing shown in Firebase Distribution. We are using version 0.2.5 of the plugin and CircleCI.

Hey @rafalzawadzki @komarekw. I think I know why you may be running into this issue. For background, App Distribution has a notion of releases and binaries. For iOS, we uniquely identify a release by its version information (CFBundleVersion, CFBundleShortVersionString) and a hash of just the app code.  This hash excludes resource files such as the provisioning profile. A binary is uniquely identified by a hash of the IPA, including its resource files. For iOS ad-hoc distributions, it's common for releases to have multiple binaries associated with them since it's normal for developers to upload the same code with an updated provisioning profile to give testers access.
In the Firebase Console, the cards you see are releases.  So what may be happening is that you're uploading a build with no code changes. If this is the case, a new release won't be visible in the Firebase Console but the binary will be available for your testers to download.
You can confirm this by using the most recent version of the fastlane plugin. When you distribute if the output says  This IPA has been uploaded before. Skipping upload step. that means the binary is being grouped under an existing release.

Hey @rafalzawadzki @komarekw. I think I know why you may be running into this issue. For background, App Distribution has a notion of releases and binaries. For iOS, we uniquely identify a release by its version information (CFBundleVersion, CFBundleShortVersionString) and a hash of just the app code. This hash excludes resource files such as the provisioning profile. A binary is uniquely identified by a hash of the IPA, including its resource files. For iOS ad-hoc distributions, it's common for releases to have multiple binaries associated with them since it's normal for developers to upload the same code with an updated provisioning profile to give testers access.
In the Firebase Console, the cards you see are releases. So what may be happening is that you're uploading a build with no code changes. If this is the case, a new release won't be visible in the Firebase Console but the binary will be available for your testers to download.
You can confirm this by using the most recent version of the fastlane plugin. When you distribute if the output says  This IPA has been uploaded before. Skipping upload step. that means the binary is being grouped under an existing release.

Thx @tagboola for your answer. Unfortunately we don't get this message. Seems like we have different problem.
INFO [2021-02-08 08:28:27.28]: --------------------------------------- INFO [2021-02-08 08:28:27.28]: --- Step: firebase_app_distribution --- INFO [2021-02-08 08:28:27.28]: --------------------------------------- INFO [2021-02-08 08:28:29.13]: ▸ i  getting app details (Distribution type: ipa)... INFO [2021-02-08 08:28:29.69]: ▸ i  uploading distribution... INFO [2021-02-08 08:28:33.09]: ▸ ✔  uploaded distribution successfully! INFO [2021-02-08 08:28:33.09]: ▸ i  adding release notes... INFO [2021-02-08 08:28:33.25]: ▸ ✔  added release notes successfully INFO [2021-02-08 08:28:33.25]: ▸ i  adding testers/groups... INFO [2021-02-08 08:28:33.79]: ▸ ✔  added testers/groups successfully INFO [2021-02-08 08:28:33.81]: Cruising back to lane 'ios build_and_upload' 🚘

@tagboola thank you for the suggestion, but I think my case is the same as for @komarekw:
[19:01:15]: Successfully exported and signed the ipa file:
[19:01:15]: /Users/runner/work/[xxxx].ipa
[19:01:15]: Cruising back to lane 'ios distribute_staging' 🚘
[19:01:15]: ---------------------------------------
[19:01:15]: --- Step: firebase_app_distribution ---
[19:01:15]: ---------------------------------------
[19:01:15]: Authenticating with --firebase_cli_token parameter
[19:01:15]: 🔐 Authenticated successfully.
[19:01:16]: ⌛ Uploading the IPA.
[19:01:22]: ✅ Uploaded the IPA.
[19:01:22]: ✅ Posted release notes.
[19:01:23]: ✅ Added testers/groups.
[19:01:23]: 🎉 App Distribution upload finished successfully.

The same shows for three consecutive builds which did not result in the release being listed in Firebase App Distribution

Ahh you know what I misspoke in that last post. If you do change a resource file, it will treat it as a new binary so unfortunately you won't see the "This IPA has been uploaded before. Skipping upload step." message. But you still won't see a new release in the console for the same reasons mentioned above. Instead these builds are being "grouped" under an existing release.
@komarekw @rafalzawadzki are you explicitly updating the source code? If not can you make a simple update (like adding a variable and logging it)or bump the version, upload again and see if the release shows up in the console?

@tagboola Interesting. Maybe it's because our project is in React Native and often the only changes are in the RN JS bundle? This would not explain why builds sometimes succeed and sometimes not though

Ahh you know what I misspoke in that last post. If you do change a resource file, it will treat it as a new binary so unfortunately you won't see the "This IPA has been uploaded before. Skipping upload step." message. But you still won't see a new release in the console for the same reasons mentioned above. Instead these builds are being "grouped" under an existing release.
@komarekw @rafalzawadzki are you explicitly updating the source code? If not can you make a simple update (like adding a variable and logging it)or bump the version, upload again and see if the release shows up in the console?

Hey @tagboola ,
we always change code at least for Flutter, because we use it for iOS build upload for a Flutter project.

@rafalzawadzki @komarekw gotcha displaying a more descriptive message after uploading a build so folks know if the build resulted in a new release or was grouped under an existing one is something we've talked about. I'll make sure to share this feedback with the team 🙂

+1, the same problem with the Flutter project :(
Flutter is embedded with CocoaPods.

Checkout project
Build and upload the IPA
FAILURE: Not appeared in App Distribution (because no changes in app binary)
Change any swift file
Build and upload the IPA
SUCCESS: Appeared in App Distribution
Do nothing
Build and upload the IPA
SKIPPED: It's ok, the duplicate is skipped, not even uploaded actually.
Change any dart file
Build and upload the IPA
FAILURE: Uploaded. Not appeared in App Distribution, though.

@rafalzawadzki @komarekw gotcha displaying a more descriptive message after uploading a build so folks know if the build resulted in a new release or was grouped under an existing one is something we've talked about. I'll make sure to share this feedback with the team 🙂

Any idea how can I find the build grouped under an existing release? There seems to be no change to the release, it still has the same date, binary etc and no additional options 🤔

@rafalzawadzki you can search for the build by the release notes? Even though running the action doesn't result in a new release, if you've included release notes the release should the updated release notes.

@rafalzawadzki FYI with newly the released version 0.3.1 the plugin prints out a more detailed error message if the upload results in a build that's grouped under an existing release. It will print out the build and version so it should be easier to find the the release in the Firebase console.

For any Flutter developers that are seeing this issue, make sure you've completed the steps in this Stack Overflow answer:
https://stackoverflow.com/a/63914373/12806961
In my case, I had manually changed the build number so even though I was building my app with a specific build number, it was using the old one.


Issue found in get_url_options function in fetch.rs

There is a issue in the get_url_options function. In the current implementation, if a user uses as an input a URL or Request object, there is a "Missing required URL" error.
A fetch can receive a String, URL, or Request as an input, so when it is an object, it has to get the url string from the URL (href/toString()) or the Request objects.
https://github.com/awslabs/llrt/blob/a34b403d3b77277d86637462954ecce94fc96d7c/src/http/fetch.rs#L184
It should be something like this:
fn get_url_options(resource: Value) -> (Option<Result<String>>, Option<Object>) {
    if resource.is_string() {
        let url_string = resource.get();
        return (Some(url_string), None);
    } else if resource.is_object() {
        let resource_obj = resource.into_object().unwrap();
        let ctor: Object = resource_obj.get("constructor").unwrap();
        let name: String = ctor.get("name").unwrap();

        if name == "URL" {
            let href = resource_obj.get("href");
            return (Some(href), None);
        } else if name == "Request" {
            let url = resource_obj.get("url");
            return (Some(url), Some(resource_obj));
        }

        return (None, Some(resource_obj));
    }
    (None, None)
}

Once this is solved, there is another bug in this line:
https://github.com/awslabs/llrt/blob/a34b403d3b77277d86637462954ecce94fc96d7c/src/http/fetch.rs#L108
A mapping has to be done between the two objects.
In the MDN documentation, there is a link to an example of how it could work:
const myOptions = {
    method: "GET",
    headers: myHeaders,
    mode: "cors",
    cache: "default",
};

const myRequest = new Request("flowers.jpg");

fetch(myRequest, myOptions)

https://github.com/mdn/dom-examples/blob/6d7115ef281a5576d5cc53532380e845eb1adc07/fetch/fetch-with-init-then-request/index.html
Reference:
https://developer.mozilla.org/en-US/docs/Web/API/fetch#resource
https://github.com/awslabs/llrt/blob/a34b403d3b77277d86637462954ecce94fc96d7c/src/http/fetch.rs

Thanks for that crystal clear bug report @gc-victor! I'm working on a fix!

@richarddavison if you didn't start it, I can work on it.

@gc-victor thanks but almost ready with a PR 🥇

I think this should cover it: https://github.com/awslabs/llrt/pull/327
Tries to get option from options arg first. Then if not found falls back to "resource" property. If resource property is is not Request and has a toString method (for example URL) that one is used. If it's a plain object, it's considered as an options object also. I think that should cover all cases, but please review if I missed something.
(Wow, these web APIs has two many alternatives on how to call them)

I have added a couple of minor comments. I didn't test it, but it looks good. In an ideal world, these APIs should be tested using wpt. Deno and other runtimes use it.

(Wow, these web APIs has two many alternatives on how to call them)

It is hard to be compliant with the specifications.
Reference:
https://github.com/web-platform-tests/wpt

Agree. That's why we added support for expect so LLRT tests can run vitest with node and if both passes we're good!

I didn't check that part. I have to take a look into it.


Reponsive of FAQ's form fixed

Responsive of FAQ's form fixed with bootstrap grid

Is this PR supposed to solve https://github.com/corona-warn-app/cwa-website/issues/2601?

Yes exactly @MikeMcC399
I made one addition in my latest push, made the box on mobile bigger.
Before

After

@svengabr
The box width of /en/faq/ looks good when the window width is dynamically decreased, however at full width screen on a desktop the box does not fully display the text.

Yes, you are right. I made another small adjustment and I think it turned out much better. More space now.


Add required param statusPurpose to createCredential().

Addresses #14

Codecov Report

Merging #15 (ad5c931) into main (c3a05ab) will decrease coverage by 1.76%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   95.55%   93.79%   -1.77%
==========================================
  Files           3        3
  Lines         135      145      +10
==========================================
+ Hits          129      136       +7
- Misses          6        9       +3

Impacted Files
Coverage Δ

main.js
93.84% <70.00%> (-1.99%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a05ab...ad5c931. Read the comment docs.


MAS 1.4.3: Elements must have sufficient color contrast (.mtk4:nth-child(25))

monaco-editor version: 0.X.Y
Browser: Chrome
OS: Windows 10
Steps or JS usage snippet reproducing the issue:
As per the recommendations here https://dequeuniversity.com/rules/axe/3.1/color-contrast, All text elements must have sufficient contrast between text in the foreground and background colors behind it.

We are shipping with a High Contrast Theme
Please see https://github.com/Microsoft/monaco-editor/wiki/Accessibility-Guide-for-Integrators


Move to functional components (Part I)

Description
Migrate the following from class-based components to functional components:

src/commons/ContentDisplay.tsx
src/commons/achievement/AchievementTask.tsx
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx
src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx
src/commons/sourceRecorder/SourceRecorderDeleteCell.tsx
src/pages/academy/dashboard/Dashboard.tsx
src/pages/academy/grading/subcomponents/GradingActionsCell.tsx

Also removed unused isAlertOpen state variable

src/pages/missionControl/MissionControl.tsx

Also remove unused editOverview state variable

As well as some minor code quality improvements in the above files.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test

Make sure everything still works.
Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 84 (14.29%)  changed or added relevant lines in 9 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.06%) to 33.015%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx
1
3
33.33%

src/commons/sourceRecorder/SourceRecorderDeleteCell.tsx
1
8
12.5%

src/pages/academy/grading/subcomponents/GradingActionsCell.tsx
1
9
11.11%

src/pages/missionControl/MissionControl.tsx
1
9
11.11%

src/pages/academy/dashboard/Dashboard.tsx
2
11
18.18%

src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx
1
17
5.88%

src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentManageQuestionTab.tsx
1
23
4.35%

Files with Coverage Reduction
New Missed Lines
%

src/pages/academy/grading/subcomponents/GradingActionsCell.tsx
1
3.85%

src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentGradingTab.tsx
1
25.0%

src/pages/missionControl/MissionControl.tsx
1
10.53%

src/commons/editingWorkspaceSideContent/EditingWorkspaceSideContentAutograderTab.tsx
1
4.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
4335

Relevant Lines:
12207

💛  - Coveralls