Async completion doesn't work for non-OpenAI LiteLLM model when using function calling

I can confirm that async completion works via LiteLLM:
from litellm import acompletion
import asyncio

async def test_get_response():
    user_message = "Hello, who are you?"
    messages = [{"content": user_message, "role": "user"}]
    response = await acompletion(model="anthropic/claude-3-haiku-20240307", messages=messages)
    return response

tasks = []
tasks.append(asyncio.create_task(test_get_response()))
tasks.append(asyncio.create_task(test_get_response()))

results = await asyncio.gather(*tasks)
results

Output:
[ModelResponse(id='chatcmpl-8a69b528-bced-4bb0-a3c7-c01a4bf47caf', choices=[Choices(finish_reason='stop', index=0, message=Message(content="Hello! I am an AI assistant created by Anthropic. My name is Claude and I'm here to help you with a variety of tasks. How can I assist you today?", role='assistant'))], created=1711114675, model='claude-3-haiku-20240307', object='chat.completion', system_fingerprint=None, usage=Usage(prompt_tokens=13, completion_tokens=40, total_tokens=53)),
 ModelResponse(id='chatcmpl-d6afe553-5990-4e3e-a053-d6bc599ce800', choices=[Choices(finish_reason='stop', index=0, message=Message(content="Hello! I am Claude, an AI assistant created by Anthropic. I'm here to help with a wide variety of tasks, from research and analysis to creative projects and casual conversation. Feel free to ask me anything and I'll do my best to assist!", role='assistant'))], created=1711114675, model='claude-3-haiku-20240307', object='chat.completion', system_fingerprint=None, usage=Usage(prompt_tokens=13, completion_tokens=56, total_tokens=69))]

However, when I try using magentic, things fail:
@prompt(
    "Tell me three facts about {location}",
    model=LitellmChatModel(model="openai/gpt-3.5-turbo")
)
async def tell_me_more(location: str) -> list[str]: ...

await tell_me_more(location="London")

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/var/folders/gq/jl16rc4171g3102f40n98w0m0000gn/T/ipykernel_52507/228821438.py in ?()
      3     model=LitellmChatModel(model="anthropic/claude-3-haiku-20240307")
      4 )
      5 async def tell_me_more(location: str) -> list[str]: ...
      6
----> 7 await tell_me_more(location="London")

~/miniforge3/envs/obb-ai/lib/python3.11/site-packages/magentic/prompt_function.py in ?(self, *args, **kwargs)
     93     async def __call__(self, *args: P.args, **kwargs: P.kwargs) -> R:
     94         """Asynchronously query the LLM with the formatted prompt template."""
---> 95         message = await self.model.acomplete(
     96             messages=[UserMessage(content=self.format(*args, **kwargs))],
     97             functions=self._functions,
     98             output_types=self._return_types,

~/miniforge3/envs/obb-ai/lib/python3.11/site-packages/magentic/chat_model/litellm_chat_model.py in ?(self, messages, functions, output_types, stop)
    343                 else None
    344             ),
    345         )
    346
--> 347         first_chunk = await anext(response)
    348         # Azure OpenAI sends a chunk with empty choices first
    349         if len(first_chunk.choices) == 0:
    350             first_chunk = await anext(response)

~/miniforge3/envs/obb-ai/lib/python3.11/site-packages/litellm/utils.py in ?(self)
   9807             # Handle any exceptions that might occur during streaming
   9808             asyncio.create_task(
   9809                 self.logging_obj.async_failure_handler(e, traceback_exception)
   9810             )
-> 9811             raise e

~/miniforge3/envs/obb-ai/lib/python3.11/site-packages/litellm/utils.py in ?(self)
   9807             # Handle any exceptions that might occur during streaming
   9808             asyncio.create_task(
   9809                 self.logging_obj.async_failure_handler(e, traceback_exception)
   9810             )
-> 9811             raise e

TypeError: 'async for' requires an object with __aiter__ method, got generator

But it works when I use an OpenAI model via litellm though:
@prompt(
    "Tell me three facts about {location}",
    model=LitellmChatModel(model="openai/gpt-3.5-turbo")
)
async def tell_me_more(location: str) -> list[str]: ...

await tell_me_more(location="London")

Output:
['London is the capital city of England.',
 'The River Thames flows through London.',
 'London is one of the most multicultural cities in the world.']

This only occurs if we're using function calling (or using annotated outputs, which uses function calling under the hood).

This is a litellm bug. I've opened https://github.com/BerriAI/litellm/issues/2644
Magentic should have more tests for litellm w/ tools/functions now that they support it for these models. I've made an issue for that too https://github.com/jackmpcollins/magentic/issues/154

Thanks! I figured as much after trying to replicate -- your issue nails the root cause perfectly.
Re: more tests, it makes sense. In < 1 month we've gone from zero to four GPT-4 level models (Gemini, Claude 3, Mistral Large, Pi 2.5 (rip)). Each has different pros / cons, so I'm anticipating people will start mixing and matching in their workflows (like I'm doing at the moment).

This was fixed in litellm v1.33.7 and corresponding fixes to magentic released in https://github.com/jackmpcollins/magentic/releases/tag/v0.18.1
There is still the separate issue of litellm parsing Claude tool_call responses https://github.com/BerriAI/litellm/pull/2640 / https://github.com/jackmpcollins/magentic/issues/151


Fixed Man-At-Arms

Fix for #39.
Interpreted the same as #56 because the wording is exactly the same.
They stack appropriately.

LGTM - you are knocking these out pretty quick

Sweet!


Hardware 'Sync' button

Add a button to Arduino that toggles the TX_ID_LOCK at runtime. Maybe put the D13/Status LED into a blinking mode until a ID is found, then set LED on.

I'm new to Github - TL;DR - I forked the project and added storing the ID in firmware. https://github.com/adwiebe/Powermon433
(I also removed the rf69 support as I don't use it and needed the pins for status indicators)
I hacked in the button to my circuit this morning: https://www.instagram.com/p/BOlCi-QBi8N

Dang - wrong button. Sorry, didn't mean to close it. I think the changes should be merged back into your repository, right?

No worries. Glad you've made the effort to add features. I think we can close this


Refactor for Namespace and Project

Fixes #1608
Fixes #1611
Fixes #1470

What this PR does :
If a user provides a resource fragment for namespace, add NAME in the xml-config in pom.xml or provide a -Dfabric8.namespace=NAME parameter for ResourceMojo ,
a namespace resource would be generated. And all the other component resource's metadata will have a "namespace : NAME " entry.

sorry I made a blunder with the star imports! I've changed the settings in my IDE now. Shouldn't be a problem in future.


XSS. highlight filter takes text and treats it as html without encoding

The highlight filter is supposed to be used with ng-bind-html but does not perform any html encoding on the input. When items in a select are user generated, there is a potential for malicious behaviour.
For example if a user enters a name as Bob <img src="//porn.xxx/nsfw.gif"> Smith The image will be rendered in the select dropdown
The plnkr shows two ui-selects, one has the problematic highlight, the uses a fixed version of highlight
http://plnkr.co/edit/PR1IndT4oXZCm4UrnrNo?p=preview
The bug is in the highlight filter of in ui-select/common.js in 0.19.8

Hi thanks for this issue. Can you make a PR for this to resolve this issue?

Why it is related to ui-select?
You have used ng-bind-html in-order to put that html.


add default values in extractor2.go

@sudeepdino008 What do you pass to the EVM binary? the filename+".specimen.json",or filename+".result.json", and how do we know in which of the either cases it might fail?

@sudeepdino008 What do you pass to the EVM binary? the filename+".specimen.json",or filename+".result.json", and how do we know in which of the either cases it might fail as in which of the fields might not be populated?

replica/segment block: contains all the field which is the union of result and specimen
specimen: segment minus "output fields" like receipts and logs.
result: segment minus "input fields" like state specimen (accountRead, storageRead etc.)
note that state specimen is a very large in size, and so there's a huge difference between result (couple of 10 of KBs) and specimen (around 1MB or so).
Currently, the bsp-geth outputs replica with all fields populated, but the evm tool ignores the logs and receipts, and regenerates those.


[Go sample] -  Add unit test to cover the project

We should cover the project with unit tests

Closing this one since because we decided to make a proposal with the suggestions for this repo. I will add this topic as well.


Minimal solution to raising of warning instead of writing them

For presentation purpose only. For #262

If we choose this path (that is, allowing to raise if warnings) I am fine with the implementation.
Just the names should change.

@mgeplf , @tomdele this one is ready for review. I can't edit coverage plan. It fails due to 0.01% decrease.

I will be waiting until #263 is merged, so we will have better tests here.

I think you can approve the #263 we should be good

too much responsibility for me, I rather wait for Mike's final response.

Looks great, thanks for moving forward on this.


use native toggle if available

Looks like you decided to use this in the latest release. :+1:

Yes except I'm still unsure if you still need to resort back to the alternative method for older browsers. Do you know?

With this method you will only support IE10+. http://caniuse.com/#feat=classlist


Initialize PrognosticData using a IPrognosticUpdater instance

Currently PrognosticData is initialized using its ad hoc generate() function. Since the functionality to update the values is now provided by the IPrognosticUpdater interface, utilize this to initialize the data instead.

Merged as part of the MVM


Loop Parse not properly converted

The first , after Loop Parse shall be removed by the conversion.
See https://www.autohotkey.com/docs/v2/lib/LoopParse.htm
Loop, Parse, list, % listDelim
is converted to
Loop Parse, list, listDelim
It shall be:
Loop Parse list, listDelim

Added this in v2converter after the call to Convert
outscript:= StrReplace(outscript,"Loop Parse,", "Loop Parse")

Both Loop Parse, list, listDelim and Loop Parse list, listDelim are valid code
Is there any particular reason as to why the second one should be the output?

Infact the examples on the page you linked have commas after parse
https://www.autohotkey.com/docs/v2/lib/LoopParse.htm#Examples

It appears that in v2 syntax, the , after parse is optional, but is not indicated in the v2 documentation.

Almost seems like a v1 thing :)
I think I can close this issue now, but if you feel otherwise just reopen it

I thought I got an error at run because of this missing , after Loop Parse. I will recheck and reopen the issue in case.


Update Release Automation

Currently, the ai-lab uses release-droid for releases which is not maintained anymore as mid of 2024 the Java developers switched release automation with project-keeper.
The current ticket therefore requests to update the release process and documentation.
Current Release Process
For releasing the AI-Lab the developers currently call release-droid (RD), see How to Release the AI-Lab in the Developer Guide.
RD then calls GitHub workflow release_droid_upload_github_release_assets.yml, which then calls
poetry run python3 -m exasol.ds.sandbox.main start-release-build \
  --upload-url "${{ github.event.inputs.upload_url }}" \
  --branch "$GITHUB_REF"

cli/commands/start_release_build.py calls lib/release_build/run_release_build.py which

Extracts the numeric RELEASE_ID (datatype int) from the upload URL provided by RD with regular expression ^https://uploads.github.com/repos/([a-zA-Z0-9\-_/]+)/releases/([\d]+)/assets.
Triggers an AWS CodeBuild.

The AWS CodeBuild template aws-code-build/ci/buildspec_release.yaml calls
poetry run python3 -m exasol.ds.sandbox.main update-release \
  --release-id "$RELEASE_ID" \
  --asset-id "$ASSET_ID"

lib/update_release/run_update_release.py finally

From AWS retrieves the URLs of all assets created by the CodeBuild
Writes an inventory linking to the assets into file artifacts.md
Uploads this inventory to the GitHub release as asset and
Adds the text content of the inventory to the comment/message/notes of the GitHub release.

Proposed Changes

Enhance function create_release() in lib/github_release_access.py

Add parameter tag
Add parameter message-file for reading the release comment/message from specified file

Add a CLI cli/commands/create_github_release.py command for

calling function create_release()
Accepting parameters --tag, --title, --message, --comment-file
Printing the RELEASE_ID for usage in a GitHub workflow

cli/commands/start_release_build.py:

Add CLI parameter --release-id <int>
Forward RELEASE_ID to lib/release_build/run_release_build.py

Calling _execute_release_build() using the RELEASE_ID directly without parsing it from the URL.
Add a new GitHub workflow release.yml

Triggered on: push: tags: - '**'
For experimental purposes also by workflow_dispatch
Creating the release by calling the new CLI command create-github-release (see below)
And calling start-release-build with the obtained RELEASE_ID.

CLI command call
poetry run python3 -m exasol.ds.sandbox.main create-github-release \
  --tag ${GITHUB_REF_NAME} \
  --title ${GITHUB_REF_NAME} \
  --message-file doc/changes/changes_${GITHUB_REF_NAME}.md \

Proposed New Release Process

The Developer calls PTB feature prepare-release, see instructions in the Developer Guide of SAPIPY
The Developer creates and pushes a Git Tag which will trigger the new GitHub workflow release.yml:

TAG="${1}"
git tag "${TAG}"
git push origin "${TAG}"

Proposal from @tkilias : I mostly agree.
Except: create_github_release can be integrated into run_release_build as we don't need two separate CLIs.
This also removed the need in between parsing the ReleaseID from the output in order to pass it to the second call.


zsh: command not found: mongod

Hi there,
I setup  the files according to your doc and even tried the antigen. Before oh-my-zsh mongod worked properly. What did I do wrong?

@rhnkyr The error command not found: mongod suggests the mongod binary isn't in your path. I expect this is unrelated to zsh completions.
Were you able to resolve your issue?
Regards,
Stennie


Link free documents to hocuspocus database via uuid

For free documents we have to serve the document under the /g namespace.

Well, this has been changed! I suppose I have to replace it with /p, which means public. Ask later.


My repo not showing up

Hey @czechboy0,
I was playing with this tool you built, and I tried copying one of the repos your crawler captures to see if my name would show up in the results. It did not. This was the repo I was looking for https://github.com/FareedQ/testRepo.
Further investigation I found that the number of repos it captures seem to be inconsistent. I put a second versions of the app on my computer in a different folder and ran it to find 46 more repos in it's cache folder (my test repo didn't show up).
Does it take a certain amount of time after a repo is committed to github before it shows up?
I'm going to play around with it some more, but was hoping you could help me understand the tool.

The crawler uses GitHub search by actually pretending to be a browser and parsing the returned HTML. GitHub search sometimes returns inconsistent results, so unfortunately I can't do any better. The trick is to run it twice or three times a day after which you should get most the results, but by no means is it 100% deterministic.
Technically you could add your repo to the list (in the Redis db it's a set under the key github_names after which it'll be crawled as well. Just the GitHub search crawling is used for discovering new packages.)

Thank you for the suggestion.
Yes, looking at the code I realize you are being limited by Github's
search. Thanks again.
On Tue, Jun 7, 2016 at 2:04 AM, Honza Dvorsky<EMAIL_ADDRESS>wrote:

The crawler uses GitHub search by actually pretending to be a browser and
parsing the returned HTML. GitHub search sometimes returns inconsistent
results, so unfortunately I can't do any better. The trick is to run it
twice or three times a day after which you should get most the results, but
by no means is it 100% deterministic.
Technically you could add your repo to the list (in the Redis db it's a
set under the key github_names after which it'll be crawled as well. Just
the GitHub search crawling is used for discovering new packages.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/czechboy0/swift-package-crawler/issues/2#issuecomment-224187465,
or mute the thread
https://github.com/notifications/unsubscribe/AEzUkzSyc5ze36TH__dwTZQQfY2_qkE1ks5qJQnbgaJpZM4IvWcN
.

--
www.FareedQ.com
Twitter @IAmFareedQ


Can't use deserializeObject if that class has a manual a constructor method implemented.

I have this class that looks something like this:
@JsonObject
export class UserPublicProfile implements RefBalrogModel {
  @JsonProperty('timestamp', TimestampConverter)
  timestamp: Timestamp = new Timestamp();

  @JsonProperty('user_name', String)
  user_name: string = undefined;

  @JsonProperty('user_id', UserIDConverter)
  user_id: UserID = undefined;

  @JsonProperty('display_name', String)
  display_name?: string = undefined;

  public static reference = DatabaseReference.publicProfile;

  constructor(user_id: UserID, user_name: string, timestamp: Timestamp, display_name?: string) {
    this.timestamp = timestamp;
    this.user_id = user_id;
    this.user_name = user_name;
    this.display_name = display_name;
  }
}

and when trying to deserialize a json object to that UserPublicProfile I get the following error:
 Argument of type 'typeof UserPublicProfile' is not assignaable to parameter of type 'new () => any'.
I want to be able to initialize the object with parameters, and a jsonObject. Is that not possible with this package?

You are right, it does not work that way and we should note that in the ReadMe.
So the problem is the following: When deserializing JSON to the class, json2typescript has to create a new instance of your class. This happens dynamically, so it is logical that you cannot have a constructor like that. Or how would json2typescript know the values of the parameters?
I suggest the following options:

Do not use a classical constructor, use a "fake" overload constructor. Example:

constructor() {}
createUserPublicProfile(user_id: UserID, user_name: string, timestamp: Timestamp, display_name?: string): UserPublicProfile {
    const userPublicProfile = new UserPublicProfile();
    userPublicProfile.timestamp = timestamp;
    userPublicProfile.user_id = user_id;
    userPublicProfile.user_name = user_name;
    userPublicProfile.display_name = display_name;
    return userPublicProfile;
}

Make all params optional

constructor(user_id?: UserID, user_name?: string, timestamp?: Timestamp, display_name?: string) {
    this.timestamp = timestamp;
    this.user_id = user_id;
    this.user_name = user_name;
    this.display_name = display_name;
}

Overall, you should make sure the values are properly typed. It looks like display_name is optional, but in your JSON you did not declare that in the @JsonProperty decorator; instead you set it to string.

Using https://github.com/weichx/cerialize you can define also a non empty constructor. Maybe it is possible to the idea from there.

Using https://github.com/weichx/cerialize you can define also a non empty constructor. Maybe it is possible to the idea from there.

Interesting, thank you for the link.

Hi, i have the same problem but with Dependency Injection, so i cannot use neither optional args nor fake method. I think it is better to pass an instance of the class instead of a reference. That way we can avoid all sort of problems.

Hi, i have the same problem but with Dependency Injection, so i cannot use neither optional args nor fake method. I think it is better to pass an instance of the class instead of a reference. That way we can avoid all sort of problems.

Does https://github.com/appvision-gmbh/json2typescript/issues/47#issuecomment-353693436 not fix it?

No, the constructor args are mandatory.

How do you mean "mandatory". By the DI system?
Yes you can make a PR if you like, but in order to spare us a misunderstanding, I suggest you describe first how you plan to implement it or what you plan to change.

This is an example in one of our projects where we use Json2Typescript.
import { JsonObject, JsonProperty } from 'json2typescript';

@JsonObject('Offer')
export class Offer {
  @JsonProperty('id', String, true)
  id: string = '';

  @JsonProperty('name', String, true)
  name: string = '';

  @JsonProperty('description', String, true)
  description: string = '';

  @JsonProperty('minAmount', Number, true)
  minAmount: number = 0;

  @JsonProperty('maxAmount', Number, true)
  maxAmount: number = 0;

  get title(): string | undefined {
    if (this.minAmount && this.minAmount > 0 && this.maxAmount && this.maxAmount > 0) {
      return this.translateService(`TITLE_1`, { arg1: 'arg1', arg2: 'arg2'});
    }

    if (!this.minAmount && !this.maxAmount) {
        return this.translateService(`TITLE_2`, { arg1: 'arg1', arg4: 'arg4'});
    }

    if (this.minAmount && this.minAmount > 0) {
        return this.translateService(`TITLE_3`, { arg3: 'arg3'});
    }

    if (this.maxAmount && this.maxAmount > 0) {
        return this.translateService(`TITLE_4`, { arg5: 'arg5', arg6: 'arg6', arg4: 'arg7' });
    }

    return;
  }

  constructor(private translateService: TranslateService) {}
}

Where we can't pass the translateService to the title(), because its used more than 15 times in code (angular templates). And adding a function to the class juste for injecting translateService, isn't a good solution because the property will be optional and the compiler will not rise an error if we forgot to call the function.
On general what i'm proposing is adding another functions for deserializing using instances instead of class reference. some thing like deserializeObjectByInstance(Object, Class Instance)


Add arm64 support to ubuntu focal

I tested this patch with https://github.com/clear-code/td-agent-builder/pull/24 and build stops by lintian phase.
Does anyone check this patch?

$ pstree
...
        |-containerd-+-containerd-shim-+-build.sh-+-debuild-+-lintian-+-nproc
        |            |                 |          |         |         `-{lintian}
        |            |                 |          |         |-tee---{tee}
        |            |                 |          |         `-{debuild}
        |            |                 |          `-{build.sh}
        |            |                 `-9*[{containerd-shim}]
        |            `-34*[{containerd}]
...

$ ps axl | grep nproc
4     0  286573  286558  20   0      0     0 -      Z+   pts/0      0:00 [nproc] <defunct>

A brief survey:
https://packages.ubuntu.com/search?suite=focal&arch=arm64&searchon=names&keywords=lintian
lintian 2.62 is used.
https://bugs.launchpad.net/ubuntu/+source/lintian
It seems that it is not already known issue.
https://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=both;repeatmerged=on;src=lintian
It seems that it is not already known issue even though archive.(I've expected something to do with 2.62-2.76)

This pull request itself is no problem, I merge it.
We should support also ubuntu-focal-arm64.
We'll track the lintian's issue at #65.

Until the issue is resolved, we'll avoid this issue by #66
LINTIAN=no rake apt:build APT_TARGETS=ubuntu-focal-arm64


[Event Request] Codeunit::"Whse. Validate Source Line" - Function ProdComponentVerifyChange - OnBeforeProdComponentVerifyChange

We like to request the following Event:
Object: Codeunit::"Whse. Validate Source Line"
Function: ProdComponentVerifyChange
Publisher Event: OnBeforeProdComponentVerifyChange
Reason: To implement custom business logic
Where is the event placed:
IsHandled: Boolean;
begin
IsHandled := false;
OnBeforeProdComponentVerifyChange(NewProdOrderComp, OldProdOrderComp, IsHandled);
if IsHandled then
exit;
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeProdComponentVerifyChange(var NewProdOrderComp: Record "Prod. Order Component"; var OldProdOrderComp: Record "Prod. Order Component"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Implement cookiecutter-plone-starter templates in cookieplone-templates

Fixes #2

cookieplone question: how can I point cookieplone to a branch of the cookieplone-templates like this one?

cookieplone question: how can I point cookieplone to a branch of the cookieplone-templates like this one?

@jensens you can do it with a local checkout, using the env var of cookieplone as in:
COOKIEPLONE_REPOSITORY=/Users/sneridagh/Development/plone/cookiecutter-plone pipx run cookieplone

Findings:

Plone Version wrong at least in constraints.txt and MakeFile
We still have a setup.py it is not needed any more these days and looks ancient -> move all in pyproject.toml

mxdev can be run with pipx as well as probably pre-commit and tox can.

The top-level is used to make tags for the project. @fredvd came up with this iirc.

backend/version.txt is what I meant. And it contains a Plone version number. I doubt we need it.
+1 for a way to define a top-level version for the whole construct of frontend/backend/devops. Not sure if the top-level version.txt is the way to go.

@jensens we need that for the Makefile to get the current Plone version (PLONE_VERSION) to pass it to the images.
ok, now I see that has not been transferred from plone-starter to here.
https://github.com/collective/cookiecutter-plone-starter/blob/main/{{ cookiecutter.project_slug }}/backend/Makefile#L20
https://github.com/collective/cookiecutter-plone-starter/blob/main/{{ cookiecutter.project_slug }}/backend/Dockerfile#L2
So, on upgrade, we only have to update it once in one place. With the exception of the constraints version, which is another story, though.


Is the project abandoned?

This project is still alive? Can I use this great library in my new project?

Not really. Project is working and used in production in some services.
But currently I'm not actively supporting and improving it - lost interest to PHP :)
So it would be great if somebody will take care of it.


bug: syslog parse in rfc3164 tag length limit is 32

https://github.com/jeromer/syslogparser

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

生产过程中发现解析tag是会发生预期之外的数组越界，参照https://github.com/jeromer/syslogparser，加上tag长度限制


Lichess might implement a native "coords on every square"

https://github.com/lichess-org/lila/issues/15212
https://github.com/lichess-org/lila/issues/15189

Lichess did implement it. There is nothing to do. Both implementations can exist without issues.


feat(@angular/cli): cli app redesign

Updated ng new template design
Update favicon to be black as default

CC: @IgorMinar

Initial Mockups
Desktop

Mobile

@alexeagle do you know if this should be part of CLI version 8?

Looks great to get this into 8, but needs to land by tomorrow

@alexeagle let me know if there is anything you need from me! I just made the updates and rebased.

@sjtrimble I'll pick it up from here and fix the failing tests. They are mostly related to the unit tests and e2e expecting the old structure.

Followup PR in https://github.com/angular/angular-cli/pull/14484

@sjtrimble could we remove the changes to index.html? We think developers will accidentally leave these behind in their application.

do we really need the custom font? can we avoid using material icons and fall back to browser built-in font?
can we inline as many styles as possible?
if styles are needed on the body, could they be injected by the component constructor

we want it to be sufficient to delete the component and then you have a clean starting point for an app without any of this boilerplate left behind

For fonts maybe we can use @import in the components style file?
See support: https://developer.mozilla.org/en-US/docs/Web/CSS/@import

Copied over #14484 test fixes per @IgorMinar

Moved all code to the template file for easy removal, except for body zero padding/margin styles.

Let's get this done in 8.1. I'm sorry for deferring it but there are still questions to resolve and as much as I love this change, we shouldn't rush it and pollute new projects with code that we'll regret in the future.

any update on this, it seems that 8.1 has not included this feat

Let's see if we can release it as part of version 8.2.

Hi @sjtrimble - We discussed how to take this forward.
We would like to include this as part of the 8.2 release.
We would like the starter to have the following properties:

No changes to index.html
All changes the user need to do while changing it to their are restricted to  app.component.html, app.component.css
Sort of simple CSS for the app component. The current one is very long
Use a system font without needing to link to an external font file

✅I rebased on the latest master so everything is fresh.
✅I removed the external font references/links and replaced with system fonts.
:small_orange_diamond: Let's chat about the CSS - I think there is value in having a presentable and visually appealing first impression but perhaps we can simplify the code a bit.
:small_orange_diamond: I had managed to take everything out of the index.html file already EXCEPT the body styles - I don't know how else we would access those? Maybe we can use negative margins? I have to check this out again.

@vikerman FYI ⬆


.loaded_embeddings, .active_embeddings,  and .set_active_embeddings should be exposed to the top-level model class from .base_model

Environment info

adapter-transformers version: 3.0.1+ (commit 11bd9d27962ccd8909a531544b0feba324a17388)
Platform: Arch Linux
Python version: 3.10
PyTorch version (GPU?):
Tensorflow version (GPU?):
Using GPU in script?:
Using distributed or parallel set-up in script?:

Information
Model I am using (Bert, XLNet ...): XLMR
Language I am using the model on (English, Chinese ...):
Adapter setup I am using (if any):
The problem arises when using:

[ ] the official example scripts: (give details below)
[ ] my own modified scripts: (give details below)

The tasks I am working on is:

[ ] an official GLUE/SQUaD task: (give the name)
[ ] my own task or dataset: (give details below)

To reproduce
Steps to reproduce the behavior:
from transformers import AutoAdapterModel, AutoTokenizer
model = AutoAdapterModel.from_pretrained('xlm-roberta-base')

model.base_model.loaded_embeddings
# > {'default': Embedding(250002, 768, padding_idx=1)}
model.loaded_embeddings

File ~/.conda/envs/adapter/lib/python3.10/site-packages/torch/nn/modules/module.py:1185, in Module.__getattr__(self, name)
   1183     if name in modules:
   1184         return modules[name]
-> 1185 raise AttributeError("'{}' object has no attribute '{}'".format(
   1186     type(self).__name__, name))

AttributeError: 'XLMRobertaAdapterModel' object has no attribute 'loaded_embeddings'

model.base_model.active_embeddings
# > 'default'
model.active_embeddings

File ~/.conda/envs/adapter/lib/python3.10/site-packages/torch/nn/modules/module.py:1185, in Module.__getattr__(self, name)
   1183     if name in modules:
   1184         return modules[name]
-> 1185 raise AttributeError("'{}' object has no attribute '{}'".format(
   1186     type(self).__name__, name))

AttributeError: 'XLMRobertaAdapterModel' object has no attribute 'active_embeddings'

tokenizer = AutoTokenizer.from_pretrained('xlm-roberta-base')
tokenizer_new = AutoTokenizer.from_pretrained('xlm-roberta-base')
tokenizer_new.add_tokens(['[unused1]'])

model.add_embeddings('new', tokenizer_new, reference_tokenizer=tokenizer, reference_embedding='default')
model.base_model.active_embeddings
# > 'new'

model.set_active_adapters('default')

File /expscratch/eyang/workspace/adapter/adapter-transformers/src/transformers/adapters/heads/base.py:641, in ModelWithFlexibleHeadsAdaptersMixin.set_active_adapters(self, adapter_setup, skip_layers)
    627 def set_active_adapters(
    628     self, adapter_setup: Union[list, AdapterCompositionBlock], skip_layers: Optional[List[int]] = None
    629 ):
    630     """
    631     Sets the adapter modules to be used by default in every forward pass. This setting can be overriden by passing
    632     the `adapter_names` parameter in the `foward()` pass. If no adapter with the given name is found, no module of
   (...)
    639             The list of adapters to be activated by default. Can be a fusion or stacking configuration.
    640     """
--> 641     self.base_model.set_active_adapters(adapter_setup, skip_layers)
    642     # use last adapter name as name of prediction head
    643     if self.active_adapters:

File /expscratch/eyang/workspace/adapter/adapter-transformers/src/transformers/adapters/model_mixin.py:358, in ModelAdaptersMixin.set_active_adapters(self, adapter_setup, skip_layers)
    356     for adapter_name in adapter_setup.flatten():
    357         if adapter_name not in self.config.adapters.adapters:
--> 358             raise ValueError(
    359                 f"No adapter with name '{adapter_name}' found. Please make sure that all specified adapters are correctly loaded."
    360             )
    362 # Make sure LoRA is reset
    363 self.reset_lora()

ValueError: No adapter with name 'default' found. Please make sure that all specified adapters are correctly loaded.

Expected behavior
As specified in the documentation,  .loaded_embeddings, .active_embeddings,  and .set_active_embeddings should be available to the top-level model class. At least should be the same as .add_embeddings.
It is currently available through .base_model but not really ideal.

Thanks for reporting, this is indeed an unintended breaking change recently introduced in the master branch. Should be reversed with the merge of #386.

Thanks, @calpt!


Update cli.py format algorithm with extension detection

Following https://github.com/asreview/asreview-nemo/pull/7/, lets identify algorithms that are not in core.
  feature_extraction  Available feature extraction algorithms:

                      onehot
                      tfidf
                      doc2vec          (nemo_models)
                      labse            (nemo_models)
                      mxbai            (nemo_models)
                      sbert            (nemo_models)

Very nice!
Maybe we can use packages_distributions()[x.value.split(':')[0]]. Then it doesn't matter what the name of the internal module is. The package name is in the lead then. See https://stackoverflow.com/a/78645825

> asreview algorithms
Available active learning algorithms for ASReview.

  feature_extraction  Available feature extraction algorithms:

                      onehot
                      tfidf
                      doc2vec         ASReview-NEMO
                      labse           ASReview-NEMO
                      mxbai           ASReview-NEMO
                      sbert           ASReview-NEMO

  classifiers         Available classification algorithms:

                      logistic
                      nb
                      rf
                      svm
                      adaboost        ASReview-NEMO
                      dynamic-nn      ASReview-NEMO
                      nn-2-layer      ASReview-NEMO
                      xgboost         ASReview-NEMO

With the new implementation, I prefer this solution @J535D165 but I'm not happy with the base_module extraction voodoo.

@J535D165 I like this implementation, its close to main's implementation

Nice. I'm happy with this implementation, including the version. Make sure you format the version in the same way as the main implementation.
Happy to merge soon!

\GitHub\asreview-nemo> asreview algorithms
Available active learning algorithms for ASReview.

  feature_extraction  Available feature extraction algorithms:

                      onehot
                      tfidf
                      doc2vec         [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      labse           [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      mxbai           [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      sbert           [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]

  classifiers         Available classification algorithms:

                      logistic
                      nb
                      rf
                      svm
                      adaboost        [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      dynamic-nn      [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      nn-2-layer      [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]
                      xgboost         [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212]

  query_strategies    Available query strategies:

                      cluster
                      max
                      max_random
                      max_uncertainty
                      random
                      uncertainty

  balance_strategies  Available balance strategies:

                      double
                      undersample

\GitHub\asreview-nemo> asreview -v
usage: asreview [-h] [-V] [subcommand]

ASReview LAB - A tool for AI-assisted systematic reviews

positional arguments:
  subcommand     The subcommand to launch. Available commands:

                 [asreview 2.0a4] - ASReview LAB - A tool for AI-assisted systematic reviews
                        algorithms
                        auth-tool
                        lab
                        simulate

                 [ASReview-NEMO 0.1.dev89+g835e3ac.d20241212] - ASReview New Exciting Models
                        nemo


"header implementation" for all resources subtypes

All the resources subtypes (Schemas, Resolvers, Views, Storages, Files, Archives) actually supports the following format: ld+json, n-triples, vnd.graphviz.
Right now in the SDK, only Resources support this.
It should be implemented for all the Resources subtypes

Suggestions
We could have a function in 'utils' file that takes 'as' from the options provided, and constructs headers, for example,
export function buildHeader(as: string = 'json') {
  let acceptHeader = 'application/ld+json';

  if (as === 'vnd.graph-viz') {
    acceptHeader = 'text/vnd.graphviz';
  }

  if (as === 'n-triples') {
    acceptHeader = 'application/n-triples';
  }

  return acceptHeader;
}

So we could use in httpGet request, something like
return httpGet({
        headers: { Accept: buildHeader(as) },
        path: `${
          context.uri
        }/resources/${orgLabel}/${projectLabel}/${DEFAULT_SCHEMA_ID}/${resourceId}${buildQueryParams(
          opts,
        )}`,
      });

and use it everywhere we need.
🙀

That's exactly what I was thinking :+1:


Make alert helper versatile

Coverage: 93.597%. Remained the same when pulling 450cd2436e2eed81e978101d1a8e7a03383dc390 on nimmo-admin-form-helpers into 18261ef0b532bb1d42c5592b04243f5a6b1b2f3b on main.


Merge pull request #1 from machulav/main

Upgrade Node JS to V20

Fixed: https://github.com/machulav/ec2-github-runner/pull/192


Log ANIm, dnadiff, and ANIb in batches

In order to avoid locking errors writing to SQLite3 on a network drive we had switched to recording the comparisons for these methods a whole column at a time (#216) - and this has been tested with up to 400 workers on 400 genomes.
However, this change means the main application shows zero progress until the first column completes - which is not a good user experience. Quoting myself on #216:

One minor downside is this does mean the progress bar will sit at zero until the first task completes and then it will jump to N / N² complete  (just like the fastANI implementation).

We therefore want to log DB output occasionally, in order to have the main thread progress bar update, but not too often, and not by multiple workers all at once.
Assuming all the pairwise comparisons take the same time, the design here would mean at each round a different column worker would log its progress. This would mean regular updates until all the columns complete, although at any one moment in addition to what has been logged and shown on the progress bar, there will be lots of completed calculations cached and waiting to be logged.
Note the progress bar progression will be non-linear with time, updated relatively slowly during the run (lagging the actual computational progress), and seemingly speed up and show rapid progress near the end as the columns complete.
Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update
[ ] This is a documentation update

Action Checklist

[x] Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
[ ] Fork the pyani-plus repository under your own account (please allow write access for repository maintainers)
[x] Set up an appropriate development environment (please see CONTRIBUTING.md for this repository)
[x] Create a new branch with a short, descriptive name
[x] Work on this branch

[x] style guidelines have been followed (please see CONTRIBUTING.md for this repository)
[x] new code is commented, especially in hard-to-understand areas
[x] corresponding changes to documentation have been made
[x] tests for the change have been added that demonstrate the fix or feature works

[x] Test locally with pytest-plus -v non-passing code will not be merged
[x] Rebase against origin/master
[x] Check changes with linting/formatting tools before submission (please see CONTRIBUTING.md for this repository)
[x] Commit branch
[x] Submit pull request, describing the content and intent of the pull request
[x] Request a code review
[x] Continue the discussion at Pull requests section in the pyan-plus repository

This still needs to be tested on the cluster with lots of workers (i.e. a test run with 400 or more jobs).
We will probably want to think about refactoring after this to reduce the code duplication...

I let this branch go a bit off-topic as I started working on automatically logging any pending comparisons if the column was interrupted. That is working nicely in testing including using kill to send SIGINT or SIGTERM, but not via SLURM scancel. This https://dhruveshp.com/blog/2021/signal-propagation-on-slurm/ hints as a possible explanation, the signal gets lost in the bash wrapper script.


[A11y] cannot control dropdown component with keyboard in Firefox

Detailed description
The item inside component dropdown cannot be entered for Firefox in mac;
The opened list cannot be disappeared after one item selected for Firefox in windows.
The issue can be reproduced in http://react.carbondesignsystem.com/?selectedKind=Dropdown&selectedStory=with default text&full=0&down=1&left=1&panelRight=0&downPanel=storybook%2Factions%2Factions-panel
Dropdown component works fine in Chrome.

Is this issue related to a specific component?

Dropdown

What browser are you working in?

Firefox

What version of the Carbon Design System are you using?

3.10.6
Add labels
a11y

@asudoh @joshblack Can you control dropdown or dropdownV2 component with keyboard in Firefox?
System: MacOS v10.13.2
In chrome Version 63.0.3239.132 (Official Build) (64-bit), with the link dropdown and DropdownV2,
I can control dropdown component with keyboard and can not control dropdownV2 component with keyboard
In firefox Version ESR 52.6.0 (64-bit),with the link dropdown and DropdownV2,
I can not control both dropdown and dropdownV2 component with keyboard

I am able to control both the Dropdown and DropdownV2 in Firefox ESR, 52.6


fix onReset bug

fix fluxible-router example Timestamp click event doesn't work.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA is valid!

Thanks!
cc// @mridgway @redonkulus

:shipit:


creates example/compiler/01_iet.ipynb

OK, perhaps this is even too small :) you can put some initial content and then we can provide some feedback

Sure, sure. I was just sanity-checking if Travis likes my repo. I didn't know he takes that long by the way :0

oh yes, it's because of our continuous integration (CI) systems, which run the entire test suite on multiple platforms to verify that none of the changes have broken anything. This needs some times

Hey Fabio, thank you for your comments.
I'm not sure if we're seeing the same version of the updates.
In my current version I don't use the world scalar at any point.
I also state about such a particularity of IETs.
About Travis' tests, here I read:
All checks have passed 2 successful checks
Let me try to push that again.

Please let me know if that worked.
Just for sanity checking, please let me share the steps I took after editing the file 01_iet.ipynb:
git checkout master
git pull
git checkout iet-docummentation
git merge master
git push origin iet-docummentation

Codecov Report

Merging #624 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage    88.1%   88.03%   -0.07%
==========================================
  Files          91       91
  Lines        8703     8703
  Branches     1738     1738
==========================================
- Hits         7668     7662       -6
- Misses        818      821       +3
- Partials      217      220       +3

Impacted Files
Coverage Δ

devito/data.py
74.87% <0%> (-1.51%)
:arrow_down:

devito/__init__.py
86.51% <0%> (-1.13%)
:arrow_down:

devito/yask/wrappers.py
86.25% <0%> (-0.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2e460...99dbace. Read the comment docs.

The cell execution order is messed up. At some point a print(op) failed. We need to add these notebooks to CI so that breakages are captured. IOW, we have to add some lines to .travis.yml and Jenkinsfile.

Is there a way to test if they pass into Travis and Jenkins locally? Here I see the green light that "All check have passed".
I have recently pulled the new master and merged it into this branch. Should I do it again and re-push this commit?

Never mind the above question. I think I got what you meant.

Closing as moved to #667


Tabris CLI Directives

Is there any way I can use directives with CLI when serving/building?
So in my JS code, I can write code like
{ifdef ENDUSERMODE}
goToDashboard();
{else}
// admin mode
goToUserManager();
{endif}

The idea is to minimalize code rewriting, when we are creating multiple app based on single code base.

Currently you would have to change a local file to contain a flag (maybe json document) that you would read in your app.


Custom reward function

For the DodgeDrone competition, what is the best way to go about making our custom reward function? Currently, the reward function seems to be defined in the Flightmare flightrl source code, which we would have to recompile every time we edit the reward function.

the best way is indeed to change the source code in flightmare,
it is actually not that complicated.  every time after changing the code , you only need to recompile the code by
cd flightlib/build
cmake ..
make -j10
pip install .

Thanks!


RTOS Wrapper documentation

Documentation update
This PR is adding changes into the BPS documentation to include our wrapper functions, and show their function signatures and explain the parameters.
Quality Assurance Checklist
To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.
There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.
Requirements

[ ] Followed Coding Style Guide
[x] Code Build checks pass
[x] No merge conflicts
[x] Software feature has test associated with it.
[x] Software feature has documentation for it updated.
[x] Test provides useful information and uses relevant data to accurately represent BPS

NOTE: If test file already exists, use that one

[ ] 2 Members of the team have already reviewed my PR

NOTE: Approver will not look at PR if 2 other members haven't reviewed first

[x] Did you Have Fun?

Things to Consider

[ ] Even if the above are checked, is this the best way of writing my code?

It's possible to write code that works, but are there ways to make code more efficient?

I think the file should be renamed to like "RTOS Wrapper doc". The doc seems to be more about wrappers and a header file vs documenting the RTOS itself. Maybe we can do like a doc for each RTOS specifically like a Micrium doc or a FreeRTOS doc and have the wrapper doc?

So we don't need documentation for the micrium and FreeRTOS infrastructures because that exists on their website. This document is for documenting our wrapper layer, but it isn't normally called a wrapper layer.

So we don't need documentation for the micrium and FreeRTOS infrastructures because that exists on their website. This document is for documenting our wrapper layer, but it isn't normally called a wrapper layer.

Got it, I'll update that

This documentation is somewhat similar to what is written in the comments in the code. I want you to consider questions you had and try answering those in the documentation. The idea behind documentation is if someone sees the code, the documentation would help them understand how it works and how to work on it. I would recommend writing about how to change the code when moving to a different architecture. Also, you wrote that this code is based on a specific architecture. While that is somewhat true, the idea behind the entire library is that it allows for any architecture so include some information about that (i.e give a brief overview of where this layer sits in between and how it interacts with other layers).

Adjusted order


Knowledge: Wilson Test

this is for testing streamsets system using the cool instructlab.

Please resolve the DCO, and take a first pass at fixing the qna.yaml. If you have questions please ask them here, otherwise please close this PR.


Release Vulkano 0.28

A lot of breaking changes have accumulated already, I think this may be a good moment for a new release?
I've renamed the changelog file because now that vk-sys is gone, there is only one changelog, so there is no need to make the name longer.

All examples ran as expected with the exception of the indirect on Windows 11 / RTX 3060 Ti. I pushed a commit on the pull request to resolve the unused import on windows builds. I am not sure if this example was broken in previous releases, but I don't see this is as blocking.
Will publish upon CI build completion.


netlib/route: add length for add/del route-func to reduce caller stack usage

Summary
fix the stack-overflow bug
Impact
need to ci with apps
Testing
tested on sim

need to CI with apps pull :https://github.com/apache/nuttx-apps/pull/2497 and please help to make it?


Option to skip to next URL in history when existing file is encountered

Could an option be added to skip to the next URL in history when an existing file is encountered? I delete unwanted images after ripping, and don't want them to redownload.

Isn't the URL history exactly for this ? It should skip re-downloading the file you deleted when it notices the link is in URL history.

You're right. I had assumed it was also checking whether the file exists during a re-rip. Closing.


module not found

I am trying to use this plugin with NativeScript 2 and typescript but I got error telling that the module is not found

Can you try the demo app first and see if that works for you?
Also, this is way too little info to even remotely start guessing what's going wrong on your end.

@EddyVerbruggen The demo app is working.
But in my project I can't import this package  using import statement.

You'll have to figure that out yourself if you don't share your code. But please make an effort to compare the demo app with yours first.

Is there any type definition(.d.ts) for TypeScript ?

It's in the root folder of this repo..

I have the same issue using
import {LocalNotifications} from "nativescript-local-notifications/local-notifications";

I've added a little chapter on TypeScript support to the README. Hope that helps!


Onsite SEO implementation

Is your feature request related to a problem? Please describe.
There is no any Title, Description & Open Graphs tags in index.html
Describe the solution you'd like
I can add title, description & Open Graphs tags in index.html these tags are more important for SEO.

Assign me this issue, I can add those tags.

Hi @Krish-Panchani
index.html is the page that appears when the extension is used and it is not a dedicated home page of the extension. Once the home page is built, I feel that SEO optimization would be required for that. @AnsahMohammad needs your opinions.

Yeah, I agree. There’s no need for SEO optimization for index.html since it is only the home page of the extension.

We would encourage you to go ahead and try other issues @Krish-Panchani

Okay


setPW / getPW / enable / disable channel method

The board is capable of setting the clock, the duty cycle of a given channel.
The library is capable to set these measured in the range of a servo angle (eg 0-180).
It would be a nice improvement to define functions to set and get the PulseWidth of the current pattern. (Eg set_pulse_width(1500) should be the same as set_angle(90)).
also it would be nice to have a function to enable/disable the pwm for a given channel (0 pulse-width that is not the same as a 0 degree angle).

The pulse width need a frequency and time/width, which is no different than setting the frequency and duty cycle. Additionally, this is easily accomplished with the on/off methods of the PCA9685 package. I don't really see the benefit of this functionality for users. However, please feel free to submit a pull request or explain how why it is useful.
I don't think the PCA9685 allows users to "disable/enable" channels; at least not through I2C commands. However, feel free to enlighten me... if I am incorrect about that.


Extension: Strike payout

Hello fellow Bitcoiners,
first of all, thank you for Lnbits, it is a great piece of software!
Originated from an internal hackathon, this PR implements a new extension that connects with Strike API.
Strike doesn't yet offer sending capabilities, so we cannot use Strike as a proper underlying wallet (it will come in the future!).
So currently it simply forwards all incoming payments to the target wallet into your Strike account.
Lnbits acts as an LN proxy, middle-man.
This nicely extends Strike capabilities by LNURL and everything that Lnbits provides.
A live demo here: lnbits.mkotas.cz
A few screenshots:

WOW! This is a great extension. I hope to get merged soon. Well done mate
If only LNURLp had a verify mechanism, we could do the same with any LNURLp/LN address provider

You should also PR the theme 🤩

Can you add the strike api endpoint and api key to the extensions DB, that way it can be used by general users of an LNbits install and not just the admin of the server

You should also PR the theme star_struck

I see you have 👍

Strike doesn't yet offer sending capabilities, so we cannot use Strike as a proper underlying wallet (it will come in the future!).

bullish

Why does your theme look so cool? Please PR it!

I really want this merged.

This is basically forwarding..... but you can also use the existing strike apis to create USD pegged invoices.......  I implemented in my project for remittances, its pretty neat.

You can also use the existing strike apis to create USD pegged invoices.......  I implemented in my project for remittances, its pretty neat.

Yea, this is a good idea 👍
@v0l implemented something similar here: strike-tipper
But if we want to take leverage of LNURL, we need some middleman/proxy like Lnbits for now.

Anything I can do to help git this merged?

Codecov Report

Merging #622 (5725939) into main (ae1a2ac) will decrease coverage by 10.61%.
The diff coverage is 47.78%.

:exclamation: Current head 5725939 differs from pull request most recent head 41b6193. Consider uploading reports for the commit 41b6193 to get more accurate results

@@             Coverage Diff             @@
##             main     #622       +/-   ##
===========================================
- Coverage   51.84%   41.22%   -10.62%
===========================================
  Files         225      233        +8
  Lines       12351    12682      +331
===========================================
- Hits         6403     5228     -1175
- Misses       5948     7454     +1506

Impacted Files
Coverage Δ

lnbits/extensions/strike/tasks.py
23.18% <23.18%> (ø)

lnbits/extensions/strike/views_api.py
35.29% <35.29%> (ø)

lnbits/extensions/strike/crud.py
35.55% <35.55%> (ø)

lnbits/extensions/strike/strike_api.py
43.82% <43.82%> (ø)

lnbits/tasks.py
40.29% <50.00%> (ø)

lnbits/wallets/lnpay.py
22.61% <50.00%> (+0.26%)
:arrow_up:

lnbits/app.py
66.19% <66.66%> (ø)

lnbits/extensions/strike/views.py
72.72% <72.72%> (ø)

lnbits/extensions/strike/__init__.py
93.33% <93.33%> (ø)

lnbits/extensions/strike/models.py
94.44% <94.44%> (ø)

... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I've pushed changes for every issue raised in this PR and tests are green.

@leesalminen thank you! 💯
I have deployed it on lnbits.mkotas.cz and tested:
strike_lnbits.webm

Hey @Marfusios, awesome, great news!
I've just pushed up some changes to the README.md for this extension as well.

Since we have pulled out extensions, moved here https://github.com/lnbits/strike and pr'd here https://github.com/lnbits/lnbits-extensions/pull/53


dbcast: make stripe size an option

dbcast takes a parameter that lists the size of the segment at which to slice a file for parallel access.  It makes sense to default to the stripe size of a file if the file is on a parallel file system (or otherwise default to some hard coded value).  Let's add an option to use this default but allow the user to override it.

Closed with commit bfea9b2


Update to tooltip text in the NDC Tracker

WRI team requested a change to the tooltip text on the NDC Tracker to include the Statement (ndce_statement) value for countries that have submitted NDCs.
I inadvertently pushed this up to develop directly and subsequently reverted it - apologies for that.

Hi Alvaro - that's fine with me. This was based on text originally copied
from another component. We can change it to whatever model you would
prefer. Just let me know what option you think is best and ideally an
example from another component so I can sure to follow your patterns.
On Mon, Apr 27, 2020, 5:03 AM Alvaro<EMAIL_ADDRESS>wrote:

@Bluesmile82 approved this pull request.
Hi Kevin. Could you check my comment? If it's possible we prefer to use
elements instead of char line breaks
In
app/javascript/app/components/ndcs/ndcs-enhancements-viz/ndcs-enhancements-viz.js
https://github.com/Vizzuality/climate-watch/pull/1044#discussion_r415637764
:

@@ -79,7 +79,7 @@ class NDCSEnhancementsVizContainer extends PureComponent {
let tooltipTxt;
switch (indicator.locations[id].label_slug) {
case 'submitted_2020':

     tooltipTxt = `Submitted a 2020 NDC on ${dateIndicator.locations[id].value}.`;

     tooltipTxt = `Submitted a 2020 NDC on ${dateIndicator.locations[id].value}.\n\n${statementIndicator.locations[id].value}`;

We prefer to use elements instead of \n to break lines.
This could be a div to create a line break as it's already inside a .
Maybe with a className if you want further styling. Adding JSX to a
container file is not the best option but this specific function I think is
more related to the presentation of the text so it could be moved to the
component instead of the container.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Vizzuality/climate-watch/pull/1044#pullrequestreview-400758811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASZY2GOE5ASS6ENTDUQAV3ROVC5LANCNFSM4MQOBVGA
.

Hi Alvaro,
I understand the approach you're suggesting. I was just asking if there's
somewhere else in ClimateWatch where you are generating tooltip content
containing HTML like this. Again, the current approach is based on a direct
copy from a previously existing component. In updating it, I would like to
continue to match what exists elsewhere as closely as possible. If there is
nowhere else where you are defining tooltip content in the manner you're
describing, that's fine.
Thanks,
Kevin
On Mon, Apr 27, 2020, 10:41 AM Alvaro<EMAIL_ADDRESS>wrote:

@Bluesmile82 commented on this pull request.
In
app/javascript/app/components/ndcs/ndcs-enhancements-viz/ndcs-enhancements-viz.js
https://github.com/Vizzuality/climate-watch/pull/1044#discussion_r415871305
:

@@ -79,7 +79,7 @@ class NDCSEnhancementsVizContainer extends PureComponent {
let tooltipTxt;
switch (indicator.locations[id].label_slug) {
case 'submitted_2020':

     tooltipTxt = `Submitted a 2020 NDC on ${dateIndicator.locations[id].value}.`;

     tooltipTxt = `Submitted a 2020 NDC on ${dateIndicator.locations[id].value}.\n\n${statementIndicator.locations[id].value}`;

Hi Kevin! You could move getTooltipText to the component and there use
some divs for each paragraph. If the content is not separated enough you
could add some className with a margin-bottom so the different lines are
more split apart. I'm not sure what do you mean by an example. Let me know
if you need more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Vizzuality/climate-watch/pull/1044#discussion_r415871305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASZY2FSVGABJE4QAP7OSD3ROWKQVANCNFSM4MQOBVGA
.

Ok, I get you know. We have a very similar tooltip on NDC explore map and LTS explore map:
https://github.com/Vizzuality/climate-watch/blob/6703b135105603d29f63c656f8db118d38b4767c/app/javascript/app/components/ndcs/shared/explore-map-tooltip/explore-map-tooltip.jsx
As you see is using dangerouslySetInnerHTML to preserve the HTML structure of the source

Excellent - thanks! I will rework and resubmit ASAP.
On Mon, Apr 27, 2020 at 12:32 PM Alvaro<EMAIL_ADDRESS>wrote:

Ok, I get you know. We have a very similar tooltip on NDC explore map and
LTS explore map:
https://github.com/Vizzuality/climate-watch/blob/6703b135105603d29f63c656f8db118d38b4767c/app/javascript/app/components/ndcs/shared/explore-map-tooltip/explore-map-tooltip.jsx
As you see is using dangerouslySetInnerHTML to preserve the HTML structure
of the source
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Vizzuality/climate-watch/pull/1044#issuecomment-620095493,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASZY2CCDVMZT2SE75YB2HLROWXSRANCNFSM4MQOBVGA
.

Hi! Let me know if you are going to recheck this PR soon. Maybe we can merge it and fix the code on another one

Sorry for the delay and thanks for your patience!
I've refactored the tooltip component. Let me know if this meets your requirements or if it needs additional work.

Thank you for the changes, Kevin!


Updates to the README.md file and New script for OpenEBS Cloud Deployment

Updated instructions for openebs cloud deployment on AWS

New script 'oebs-cloud.sh' to automate most of the setup process.
Updates to the README.md with instructions to use the script.
Formatting changes to the document.

Signed-off-by: yudaykiran<EMAIL_ADDRESS>

Needs a couple of edits, will raise a new pull request with the edits.


WASM incorrectly advertises dart.library.js

Currently, when compiling in WASM mode, the dart.library.js environment constant is set to true. This constant is used in particular in multi-platform applications to determine when the compilation target is a JS environment and as such various JS-interop libraries, such as dart:js, dart:js_util, and the js package are safe to load. However, this is not true in a WASM environment, causing numerous build failures (which are particularly difficult to debug because they don't include traces indicating the import chain that caused them).
Here's a minimal reproduction:
import 'dart:core'
  if (dart.library.js) 'dart:js';

void main() {
  print('hello, world!');
}

When compiled with dart compile wasm test.dart, this produces
*NOTE*: Compilation to WasmGC is experimental.
The support may change, or be removed, with no advance notice.

test.dart:1:1: Error: JS interop library 'dart:js' can't be imported when compiling to Wasm.
Try using 'dart:js_interop' or 'dart:js_interop_unsafe' instead.
import 'dart:core'
^

/cc @srujzs

Duplicate of https://github.com/dart-lang/sdk/issues/55266
Prefer dart.library.html to differentiate between a JS compiler and dart2wasm for now.
This was added to support some allowInterop stuff early on, but is no longer needed, so should indeed be removed. I believe you'll see the same behavior when doing conditional imports with dart.library.js_util, but that might require some internal migration first before I can remove it from libraries.json.


Upload resilience

The PR finally arrived :-) The timeout for the file upload post request is 5 minutes. A rather generous value but better be patient than sorry, I guess. On bigger files the upload fails for me around the two minute mark. Timeouts can be disabled completely by setting the value to None (see the httpx docs) but I'm not sure what the side effects would be.
Locally I had to disable the filterwarnings = error setting for the tests as they were failing on Deprecating warnings. I did not really get that.
What else? I had to move the upload_file function out of the upload function because the linter was complaining about its complexity. I don't know how strictly you follow it so I complied with it anyway.

thanks so much for this, sorry for the slow response.

No worries, glad to see it merged. I heard you were busy with other things (pyndatic V2 and such).


feat: add mongolian language

This pull request adds Mongolian language (Cyrillic, Mongolia)

[x] Added tests (tests/definitions/mn.csv)
[x] Tests passed
[x] Update HISTORY.md
[x] Update README.md
[x] Update bower.json, package.json

Deployed this in<EMAIL_ADDRESS>Thanks again!


fix(core/listener): make listener to retry subscribing on errors

Resolves https://github.com/celestiaorg/celestia-node/issues/2875

Codecov Report

Merging #2876 (ce836fd) into main (565691f) will increase coverage by 0.13%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2876      +/-   ##
==========================================
+ Coverage   51.57%   51.70%   +0.13%
==========================================
  Files         167      167
  Lines       10787    10798      +11
==========================================
+ Hits         5563     5583      +20
+ Misses       4735     4721      -14
- Partials      489      494       +5

Files
Coverage Δ

core/listener.go
48.80% <0.00%> (-4.71%)
:arrow_down:

... and 10 files with indirect coverage changes

Ideally should test though


Searching for subscribers with a + char in their email address fails to find them

I submitted a pull request here to solve this issue:
#16
In the meantime you can urlencode the e-mail address when looking up the subscriber.


[BitSail][Connector] Migrate Hbase legacy connector to V1 interface

Is your feature request related to a problem? Please describe
Migrate Hbase legacy connector to V1 interface. We did the migration for Redis on #98
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I'd like to try this, could u please assign it me? @garyli1019

Change to #340


replace gopkg.in/yaml.v3 to github.com/goccy/go-yaml

replace gopkg.in/yaml.v3 to github.com/goccy/go-yaml
Implement yaml syntax check, avoid roughly overwriting the incorrectly modified configuration files directly.
#217

Just simple modifications can be used as a reference

$ alterx --version
[INF] Current version: v0.0.4

$ alterx --version
[ERR] alterx yaml configuration syntax error.
 [24:5] required ':' and map value
  21 | payloads:
  22 |   word:
  23 |     - "api"
> 24 |   - "errortest"
           ^
  25 |     - "k8s"
  26 |     - "v1"
  27 |     - "v2"
.

Closing this. Reason: https://github.com/projectdiscovery/alterx/issues/217#issuecomment-2470328734. If you feel otherwise, feel free to raise a new one with the latest version.

Closing this. Reason: #217 (comment). If you feel otherwise, feel free to raise a new one with the latest version.

This pull request is not about whether my issue has been resolved.
I suspect there might be some potential logical issues in the original program when handling cases where the user has provided an incorrect YAML format, which could inadvertently result in the program overwriting the user's custom configuration.
of course, whether this is a program logic issue depends on your opinion. thanks your work.

@uxbug Thank you for your contribution; it is greatly appreciated! If you believe there is a logical error in the code, please don't hesitate to open a new issue with some details. This way, we can resolve it. Thanks again!


broken with current iobroker version

no state settings windows appears. Connection is confirmed but no messages appear anywhere..

cannot confirm, tested with 1.4.2, works fine. Maybe upload adapter files failed?

issue solved. Was a conflict with the overall MQTT setup.


Add custom token providers

Proposed changes
I'd like to use API tokens with another database (mongodb) but creating a custom token provider is not possible at the time (and it's the aim of this Pull request).
I used the same code as for the existing custom providers and guards.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works.
(There aren't any tests for the existing custom providers/guards)
[ ] I have added necessary documentation (if appropriate)
Maybe, I should add this to the documentation like the existing ones. Tell me and I'll open a PR if needed !

Further comments
:warning: There's a small issue, I don't know how to update type declaration for configuration (to hide the warning Type '"custom_provider"' is not assignable to type '"database" | "redis"')

I'm still there :)


Add support blurb to readme

Adding some support info to the readme. But really using it as a quick test to see if Codecov is disabled or not

Codecov Report

Merging #2287 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2287      +/-   ##
============================================
- Coverage     94.62%   93.87%   -0.75%
+ Complexity     1589     1567      -22
============================================
  Files            50       50
  Lines          3871     3740     -131
============================================
- Hits           3663     3511     -152
- Misses          208      229      +21

Impacted Files
Coverage Δ
Complexity Δ

lib/Site.php
73.80% <0.00%> (-13.55%)
23.00% <0.00%> (ø%)

lib/Image/Operation/Resize.php
87.61% <0.00%> (-10.53%)
33.00% <0.00%> (ø%)

lib/FunctionWrapper.php
90.90% <0.00%> (-3.21%)
17.00% <0.00%> (ø%)

lib/Twig.php
96.33% <0.00%> (-3.16%)
65.00% <0.00%> (-22.00%)

lib/Core.php
84.61% <0.00%> (-2.57%)
24.00% <0.00%> (ø%)

lib/Timber.php
94.17% <0.00%> (-1.16%)
34.00% <0.00%> (ø%)

lib/Loader.php
93.93% <0.00%> (-0.77%)
69.00% <0.00%> (ø%)

lib/QueryIterator.php
91.02% <0.00%> (-0.65%)
46.00% <0.00%> (ø%)

lib/Post.php
95.44% <0.00%> (-0.37%)
248.00% <0.00%> (ø%)

lib/MenuItem.php
88.29% <0.00%> (-0.25%)
47.00% <0.00%> (ø%)

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4de5da...0820d3e. Read the comment docs.

Coverage remained the same at 94.317% when pulling 0820d3e90ae5c9f3ba02dd5d07130ad76c063565 on 2286/nudge into 8994c801b00fefd385ef7036ed1a7fcced836841 on master.


Treat empty ivy configuration as a noop

Fixes gradle/gradle#1665
Context

Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

Thanks for providing the pull request. At the very least we'll require you to add a test that verifies the changed behavior. Can you please at it?

Sure, I'll scrape some together this evening.


Adding eduVPN as new application.

This pull request replaces my previous. The manifest file has been updated, so that filtering in the Apps script no longer is needed.
I hope you can add eduVPN as a supported app.
Thanks.
//Jasper

Closing pull request because not all commits are signed. Will create a new one.


rx/docs

Add Nextra config
Docs outlining

Closing due to yarn.lock conflicts #176 clean up branch


Null check operator used on a null value

Describe the bug
It throws a null error at the start of running the project
Reproduction code
NOTE: THIS IS MANDATORY, IF YOUR ISSUE DOES NOT CONTAIN IT, IT WILL BE CLOSED PRELIMINARY)
//get_state.dart

if (widget.global) {
      if (isRegistered) {
        if (GetInstance().isPrepared<T>(tag: widget.tag)) {
          _isCreator = true;
        } else {
          _isCreator = false;
        }
        controller = GetInstance().find<T>(tag: widget.tag);
      } else {
        controller = widget.init;
        _isCreator = true;
        GetInstance().put<T>(controller!, tag: widget.tag);
      }
    } else {
      controller = widget.init;
      _isCreator = true;
      controller?.onStart();
    }

To Reproduce
Steps to reproduce the behavior:

On get: 4.2.5
run a project
See error

Expected behavior
It should not throw a null error at the start of running the project
Screenshots

Flutter Version:
2.3.0-24.1.pre
Getx Version:
4.2.5
Describe on which device you found the bug:
Any device
Minimal reproduce code
//main.dart
void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();

  FlutterError.onError = FirebaseCrashlytics.instance.recordFlutterError;

  await MobileAds.initialize(
    bannerAdUnitId: MyAdmob.getBannerAdId(),
    interstitialAdUnitId: MyAdmob.getInterstitialAdId(),
    appOpenAdUnitId: MyAdmob.getOpenAdId(),
  );
  await MobileAds.requestTrackingAuthorization();

  Get.put(AdmobController());
  // FlutterError.onError = FirebaseCrashlytics.instance.recordFlutterError;
  // Admob.requestTrackingAuthorization();
  //
  // SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle(
  //   systemNavigationBarColor: Colors.greenAccent,
  // ));
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  // Locale myLocale;

  @override
  Widget build(BuildContext context) {
    return GetMaterialApp(
      title: 'appname',
      debugShowCheckedModeBanner: false,
      theme: appThemeData,
      // translations: MyTransalations(),
      // locale: Get.deviceLocale,
      // initialRoute: Routes.HOME_PAGE,
      home: SplashPage(),
      // locale: Get.deviceLocale,
      // translations: MyTransalations(),
    );
  }
}

//splas_page.dart
class SplashPage extends StatefulWidget {
  @override
  _SplashPageState createState() => _SplashPageState();
}

class _SplashPageState extends State<SplashPage> {
  final sp = Get.put(SplashController());
  // RiveAnimationController _controller;
  @override
  void initState() {
    super.initState();
    // _controller = SimpleAnimation('idle', autoplay: true);
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Column(
          children: [
            const Expanded(
              /// Para fines practicos usarremos esta animacion
              /// disponible en linea.
              child: RiveAnimation.asset(
                'assets/splash.riv',
                fit: BoxFit.cover,
              ),
            ),
            Text(
              'loading_txt'.tr,
              style: const TextStyle(fontSize: 32, fontWeight: FontWeight.bold),
            )
          ],
        ),
      ),
    );
  }
}

//home_page.dart

class HomePage extends StatelessWidget {
  // const HomePage({Key? key}) : super(key: key);
  final TextEditingController nameController = TextEditingController();
  var logger = Logger();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('videos'),
      ),
      body: Container(
        decoration: const BoxDecoration(color: Colors.amberAccent),
        child: Padding(
          padding: const EdgeInsets.only(top: 50),
          child: Column(
            crossAxisAlignment: CrossAxisAlignment.center,
            // mainAxisAlignment: MainAxisAlignment.,
            children: <Widget>[
              const SizedBox(
                height: 30,
              ),
              const Text('Introducir nombre'),
              Padding(
                padding: const EdgeInsets.all(8.0),
                child: GetBuilder<HomeController>(
                  builder: (_) => TextField(
                    controller: nameController,
                    decoration: InputDecoration(hintText: 'video_url'.tr),
                  ),
                ),
              ),
              GetBuilder<HomeController>(
                builder: (_) => ElevatedButton(
                  onPressed: () {
                    if (nameController.text.isEmpty) {
                      logger.v("lenght of text: ${nameController.text.length}");
                      nameController.clear();
                      // return null;
                    }

                    // _.getLink(nameController.text);
                    // logger.v(nameController.text);
                  },
                  child: Text('download_btn'.tr),
                ),
              )
            ],
          ),
        ),
      ),
    );
  }
}

Initialize HomeController, and it will work

Same issue here. I can not run the app after updating the package version.

`Null check operator used on a null value
When I run the app on getx 4.3.0 then it's showing an error. But if I run on an older version then it works perfectly.
The relevant error-causing widget was:
Directionality file:///home/monu/FlutterSdk/flutter_updated/flutter/.pub-cache/hosted/pub.dartlang.org/get-4.3.0/lib/get_navigation/src/root/get_material_app.dart:217:12
When the exception was thrown, this was the stack:
#0      PageRedirect.page (package:get/get_navigation/src/routes/route_middleware.dart:199:50)
#1      GetMaterialApp.initialRoutesGenerate (package:get/get_navigation/src/root/get_material_app.dart:212:9)
#2      _WidgetsAppState.build. (package:flutter/src/widgets/app.dart:1533:51)
#3      NavigatorState.restoreState (package:flutter/src/widgets/navigator.dart:3439:41)
#4      RestorationMixin._doRestore (package:flutter/src/widgets/restoration.dart:984:5)`

@Hasib74 I'm facing that same issue that you have faced, It has the same signature but I don't think it's related to the bug that @Blast06 originally opened.
I know the bug is from the following line:
 final _r = (isUnknown ? unknownRoute : route)!;

The line fails because unknownRoute and route are null (it appears that on application start route does not have a value), and thus the null check operator throws.
To fix this you can just ensure that unknownRoute is defined in the GetMaterialApp. i.e. you can use your the first route in the route object as the unknownRoute.
GetMaterialApp(
  routes: routes,
  unknownRoute: routes[0]
);

Well, I'm closing this issue because it has become a compilation of attention errors.
The initial issue was caused by the lack of controller initialization. Now I'm seeing null-exception reports from people who haven't set initialRoute.
Please make sure you are facing a bug before opening an issue, look at the project and check if everything is ok. When you open an issue for lack of attention, you occupy my time that could be spent on a possible real issue.

@Hasib74 I'm facing that same issue that you have faced, It has the same signature but I don't think it's related to the bug that @Blast06 originally opened.
I know the bug is from the following line:
 final _r = (isUnknown ? unknownRoute : route)!;

The line fails because unknownRoute and route are null (it appears that on application start route does not have a value, @jonataslaw might be able to shed some light as to why this might occur), and thus the null check operator throws.
To fix this you can just ensure that unknownRoute is defined in the GetMaterialApp. i.e. you can use your the first route in the route object as the unknownRoute.
GetMaterialApp(
  routes: routes,
  unknownRoute: routes[0]
);

You should use getPages, not routes, please follow the documentation.
You need set initialRoute too

@Hasib74 I'm facing that same issue that you have faced, It has the same signature but I don't think it's related to the bug that @Blast06 originally opened.
I know the bug is from the following line:
 final _r = (isUnknown ? unknownRoute : route)!;

The line fails because unknownRoute and route are null (it appears that on application start route does not have a value, @jonataslaw might be able to shed some light as to why this might occur), and thus the null check operator throws.
To fix this you can just ensure that unknownRoute is defined in the GetMaterialApp. i.e. you can use your the first route in the route object as the unknownRoute.
GetMaterialApp(
  routes: routes,
  unknownRoute: routes[0]
);

You should use getPages, not routes, please follow the documentation.
You need set initialRoute too

@jonataslaw Apologies my comment was mityped, I have all of these set, however anytime I try to route it always sends me to the unknownRoute? and if I don't have unknownRoute I  get the null error...
        initialRoute: HomeScreen.pageId,
        getPages: routes,
        unknownRoute: routes[0],

Worked in 4.1.4 but broken up until 4.3.0

How do you define your route?
Are you sure you aren't missing slashes?
This works well on my projects in production, so I need more details to know where the problem is.

Ah I was missing slashes... Thanks for that!


Implement task 3.

Resolves #8.

16-bit and 8-bit versions of color conversion were implemented.
Demo:
Enter Y, Cb, Cr (comma seprated): 123, 123, 123
Y:123, Cb:123, Cr:123
-- C (floating-point multiply) ---> R:136, G:148, B:134 | took 2595 cycles.
-- Linear ASM (16-bit multiply) --> R:136, G:148, B:134 | took 38 cycles.
-- Linear ASM (8-bit multiply) ---> R:135, G:147, B:133 | took 39 cycles.


ARM-151 server, server_rust & dbmate added

Tests are passing so everything seems to be fine :D

Tests are passing so everything seems to be fine :D


#927 INSERT H1 TAG SOLVED

Description
I added an h1 tag above the h2 tag as mentioned.

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


remove excessive null check inside Optional.IsDefined() block

Describe the issue or request
In the generated serialization codes, we have null check like below: https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/test/TestProjects/MgmtDiscriminator/Generated/Models/CacheExpirationActionParameters.Serialization.cs#L25-L36
However, if you check the implementation of Optional.cs, you'll realize that Optional.IsDefined or Optional.IsCollectionDefined has already check the null. So, the else clause in above codes will not be executed.
I've written some test cases to verify.
        [Test]
        public void IsDefinedNotNull()
        {
            TimeSpan? a = TimeSpan.Zero;
            if (Optional.IsDefined(a))
            {
                Assert.IsNotNull(a);
            }
            else
            {
                Assert.Fail("Should not hit");
            }
        }

        [Test]
        public void IsDefinedNull()
        {
            TimeSpan? a = null;
            if (Optional.IsDefined(a))
            {
                Assert.Fail("Should not hit");
            }
            else
            {
                Assert.IsNull(a);
            }
        }

Describe your ideas for solutions
The null check codes are generated in https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/src/AutoRest.CSharp/Common/Generation/Writers/CodeWriterExtensions.cs#L546-L560
I searched where it's being used, and found that it's always used along with WriteDefinedCheck()

https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/src/AutoRest.CSharp/Common/Generation/Writers/JsonCodeWriterExtensions.cs#L240-L242
https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/src/AutoRest.CSharp/Common/Generation/Writers/XmlCodeWriterExtensions.cs#L67-L68
https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/src/AutoRest.CSharp/Common/Generation/Writers/XmlCodeWriterExtensions.cs#L78-L79
https://github.com/Azure/autorest.csharp/blob/14b67abe16e937f2ce7e24bd63a91545b5dbec98/src/AutoRest.CSharp/Common/Generation/Writers/XmlCodeWriterExtensions.cs#L87-L88

So maybe we can just remove WritePropertyNullCheckIf()?

I found one case that null check is useful. Optional.IsCollectionDefined will return true if null is given. Normally that should not happen since collection properties are not allowed to be null. But in case that happened, the null check can defend from that.
        [Test]
        public void IsCollectionDefinedNull()
        {
            IList<string> a = null;
            if (Optional.IsCollectionDefined(a))
            {
                Assert.Fail("Should not hit");
            }
            else
            {
                Assert.IsNull(a);
            }
        }

Is that the purpose of the null check? If so, then at least we can optimize the null check for non-collection types.

PR for the reference: https://github.com/Azure/autorest.csharp/pull/830

Specifically, this is a commit that added these code bits: https://github.com/Azure/autorest.csharp/pull/830/commits/e1858f03c368fb1e4ed5e96f28ac2a52f57f6d9f


init mod from 'go get' calls

to recreate:
git clone a fresh checkout,, not in gopath
make godeps to download all deps as they currently exist
go mod init github.com/hyperledger-labs/fabric-private-chaincode in base directory.
go mod download can be used to initialize the go build cache in a similar manner to the existing go get calls.
There are probably actual used dependencies (retrieved when compiling the code) that are still missing.
@mbrandenburger  can you try the ecc failure with this patch?

This seems to help with build ecc-vscc.

should I re-enable it in another commit or do you want to build on top of this?

should I re-enable it in another commit or do you want to build on top of this?

I suggest to make a separate PR for plugins.

@MHBauer could you please link this PR to the corresponding issue and briefly explain what is happening here.

@g2flyer
Maybe not necessary to not be in the gopath. Unsure, Wrote down and communicated what I did do. Let's discuss the fabric build later. Remind me.

Yes. Let us do it separately, as part of #247. Demo probably should also be a separate module.
I thought it is done? We can't do it for the tools as those are binary targets. (Another go thing, if go get resolves to a binary, do the download, but also build and install it into go/bin)
I didn't do any builds after this, it's difficult for me to know what exists in terms of output artifacts. go build will modify go.mod and go sum every time if there's any changes needed. Someone should do a build and add a commit here with the changes after successful builds.
No threads here.

Note also that tidy revealed that we forgot to fix one of our chaincodes: demo/client/backend/mock/chaincode/fpc_chaincode.go still references the old v1.4 shim ...

I suggest that we add a TODO to bring the Demo up and running again.

Maybe not necessary to not be in the gopath.  Unsure
See notes under go 1.13 on https://github.com/golang/go/wiki/Modules ....

Yes. Let us do it separately, as part of #247. Demo probably should also be a separate module.
Makes sense (BTW: i've ticked off now ERCC in 247 as this should be now covered?)

I thought it is done? We can't do it for the tools as those are binary targets. (Another go thing, if go get resolves to a binary, do the download, but also build and install it into go/bin)
I missed adding the crucial words "in the dev and peer Dockerfiles". Given that marcus already merged, i guess it needs a separate PR.

I didn't do any builds after this, it's difficult for me to know what exists in terms of output artifacts. go build will modify go.mod and go sum every time if there's any changes needed. Someone should do a build and add a commit here with the changes after successful builds.
Ok, will do that as part of above PR.  You haven't though answered part of my question: should we do each time a go mod tidy or does that cause some issues?

Note also that tidy revealed that we forgot to fix one of our chaincodes: demo/client/backend/mock/chaincode/fpc_chaincode.go still references the old v1.4 shim ...

I suggest that we add a TODO to bring the Demo up and running again.

@mbrandenburger I guess you mean (Work-item) Issue when you say TODO?  Currently some go commands fail now due to that. I will fix that as part of the PR i mentioned in reply to Morgan.  Can you create the work-item? (I've created so many lately, so more diversity in the creators might not hurt :-)

FYI: created PR #308 for the pr mentioned above.  And as issue-creator-in-chief-lately i've also created an issue #309 for the demo ...

@g2flyer as long as everything builds. go mod tidy shouldn't hurt anything.


box-cutter/centos511 is in a 'gurumeditation' state and doesn't work.

Tested on two different machines with:
macOS Sierra 10.12.1 and 10.12
VirtualBox 5.1.8
Any other box runs fine. One of the machines was running an old version of box-cutter/centos511 and it broke when I did a box update.
$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Importing base box 'box-cutter/centos511'...
==> default: Matching MAC address for NAT networking...
==> default: Checking if box 'box-cutter/centos511' is up to date...
==> default: Setting the name of the VM: vagrant_default_1478238840903_98242
==> default: Fixed port collision for 22 => 2222. Now on port 2200.
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
==> default: Forwarding ports...
    default: 22 (guest) => 2200 (host) (adapter 1)
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
    default: SSH address: <IP_ADDRESS>:2200
    default: SSH username: vagrant
    default: SSH auth method: private key
The guest machine entered an invalid state while waiting for it
to boot. Valid states are 'starting, running'. The machine is in the
'gurumeditation' state. Please verify everything is configured
properly and try again.

If the provider you're using has a GUI that comes with it,
it is often helpful to open that and watch the machine, since the
GUI often has more helpful error messages than Vagrant can retrieve.
For example, if you're using VirtualBox, run `vagrant up` while the
VirtualBox GUI is open.

The primary issue for this error is that the provider you're using
is not properly configured. This is very rarely a Vagrant issue.

My vagrantfile is super simple:
Vagrant.configure('2') do |config|
  config.vm.box = 'box-cutter/centos511'
end

Any other box I run including boxcutter/ubuntu runs fine.

This is likely a problem with VirtualBox 5.1.8 itself and not the boxes. I can reproduce the error merely by trying to boot up from a CentOS 5.x boot DVD in VirtualBox. You might want to consider filing an issue with the VirtualBox folks by following the instructions in the error message.

Thanks. I've raised the issue with VirtualBox over at; https://www.virtualbox.org/ticket/15613.

Looks like the issue is in the paravirt support that was added back in recent 5.1.x builds. Here's a workaround: https://twitter.com/amdprophet/status/803679629957435392

https://github.com/boxcutter/centos/commit/f7fcc9d82dcbbf187f47e4a330aa7b3cabecfbb6