Fix hooks example

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (1bb75ea) 100.00% compared to head (5ec07c5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          330       331    +1
  Branches        64        64
=========================================
+ Hits           330       331    +1

Impacted Files
Coverage Δ

src/websocket.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Detect Player playing style and show it in player profile

Big Server
Attacking base-liner
Passive base-liner
All-court

Seems not possible to determine reliably with just serve and return statistics, needs winners/unforced and net approaches stats, which are not available.


would you like to provide vit weights and C++ interface?

wonderful work! I'm interested in interactive segmentation,C++ interface on the way?

wonderful work! I'm interested in interactive segmentation,C++ interface on the way?

The pre-trained weights are already provided, please kindly give it a check. We would like to help if you have difficulty in suing it. In terms of C++ interface, we will try our best to provide but we cannot when it can come out. However, if you are willing to help, we would appreciate and include it in our current project.

I added support for MobileSAM in this wrapper https://github.com/dinglufe/segment-anything-cpp-wrapper

Here is the Segment Anything CPP Wrapper for macOS.
This code is originated from Segment Anything CPP Wrapper and implemented on macOS app RectLabel. We customized the original code so that getMask() uses the previous mask result called as low_res_logits and retain the previous mask array for undo/redo actions.
We hope this macOS version would help to develop the iOS version.
Please let us know your opinion.

Improved "Create polygon using SAM" feature so that you can label pixels using the pixels option. You can label Segment Anything 1 Billion (SA-1B) like dataset by yourself.


group nodes

select several nodes (with pressing strg)
and then when right clicken and choosing diseases/drug/genes only get those that have connections to all the selected nodes


[src/05-led-roulette] microbit v2.2 "Error attaching to RTT"

TLDR: microbit v2.2 runs then fails immediately when using RTT.
TLDR: I misconfigured the Embed.toml. rtt-target is stable even after running 5min.
Section 5.5 requires us to use the rtt-target crate however it appears the microbit v2.2 is having issues regarding RTT.
I believe this is related to https://github.com/probe-rs/probe-rs/issues/1235.
Finished flashing in 1.964s
    GDB stub listening at <IP_ADDRESS>:1337
       Error Error attaching to RTT: RTT control block not found in target memory.
             - Make sure RTT is initialized on the target, AND that there are NO target breakpoints before RTT initalization.
             - For VSCode and probe-rs-debugger users, using `halt_after_reset:true` in your `launch.json` file will prevent RTT
                initialization from happening on time.
             - Depending on the target, sleep modes can interfere with RTT.

To confirm, I removed the call to rprintln!() and replaced rtt_init_print with rtt_init_default, and received the same results as above.
# Embed.toml
[default.general]
chip = "nrf52833_xxAA" # uncomment this line for micro:bit V2

[default.reset]
halt_afterwards = true  # should be false

[default.rtt]
enabled = true

[default.gdb]
enabled = true  # should be false

@mattjperez I am seeing the same error, what did you do to go past this?
(I tried multiple config of embed.toml, but i still get an error.

@mattjperez I am seeing the same error, what did you do to go past this? (I tried multiple config of embed.toml, but i still get an error.

setting halt_afterwards = false fixed this for me


Update boa docs to replace "3.7+" by "3.10+"

Task linked: CU-86a0aw4hv Update boa docs to replace "3.7+" by "3.10+"

coverage: 91.825% (-0.2%) from 92.049% when pulling dbfb7543fe4360c4bd159b6557803c67bf903f53 on CU-86a0aw4hv into 5fdb414bf096051a7eb8d188ca3ce13468d02272 on development.


Func

Closes #9
waiting for #1 to be merged to handle indent and dedent gracefully

Currently, trying to format "#{f1(\n1,\n2,\n3,\n\n)}" expecting #{f1(\n    1,\n    2,\n    3,\n    )\n}"
fails with
thread 'rules::tests::func::basic_func_fmt' panicked at 'assertion failed: `(left == right)`'
  left: `"#{f1(\n    1,\n2,\n3,\n\n)}"`
 right: `"#{f1(\n    1,\n    2,\n    3,\n    )\n}"`

It seems to me the writer can't remember the identation level when buffered.
Any ideas @dvdvgt  ?

 writer.buffered(false, |w| {
                    rule.eat(to_append.clone(), &context, w);
                    let result = w.result();
                    if log_enabled!(Level::Debug) {
                        let diff = similar_asserts::SimpleDiff::from_str(
                            to_append.as_str(), result, "before", "after",
                        );
                        debug!("MATCHED RULE: {rule:?} \ntransforms {to_append:?} in {result:?}\nwith diff:\n {diff}");
                    }
                    // we update the string representing this with the formatted string applied by the current rule
                    to_append = result.clone();
                });
            }
        }
        // since all rules have been applied to this rule, we now may push the final result to the writer
        writer.push(&to_append);

Seems to me the result gets pushed but not the indentation level.

Forget it I just didn't fully understand how to use the writer.

Currently doesn't handle nested function properly.

#[test]
        fn nested_func() {
            init();

            similar_asserts::assert_eq!(
                format_with_rules("#{f1(1,2,f(a,b,c,),),}", &[IdentItemFunc.as_dyn()]),
                format!("#{{f1(\n{0}1,\n{0}2,\n{0}f(\n{1}a,\n{1}b,\n{1}c,\n{0}),\n),\n}}"," ".repeat(4)," ".repeat(8))
            );
        }

left: "#{f1(\n    1,\n    2,\n    f(\n    a,\n    b,\n    c,\n    )\n,\n    )\n,}"
right: "#{f1(\n    1,\n    2,\n    f(\n        a,\n        b,\n        c,\n    ),\n),\n}"
Differences (-left|+right):
 #{f1(
     1,
     2,
     f(
-    a,
-    b,
-    c,
-    )
-,
-    )
-,}
+        a,
+        b,
+        c,
+    ),
+),
+}

The indentation of the nested function is not right, the comma after it's closing parenthesis is misplaced.

Forget it I just didn't fully understand how to use the writer.

Feel free to change the Writer if the functions do not do what we need. We could add a flag to the buffered function to save the indention level, for example.


xActiveDirectory: Requirements section

Pull Request (PR) description
Added a Requirements section to every DSCResource README with the bullet point stating "Target machine must be running Windows Server 2008 R2 or later".
This Pull Request (PR) fixes the following issues
Fixes #394
Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md.

This change is

@JamesFrierson1 Could you please resolve the merge conflicts? It seems your working branch is not using the latest changes merged into the dev branch.
See here how to resolve merge conflicts
https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

Codecov Report

Merging #399 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #399   +/-   ##
===================================
  Coverage    92%    92%
===================================
  Files        20     20
  Lines      2538   2538
  Branches     10     10
===================================
  Hits       2345   2345
  Misses      183    183
  Partials     10     10

a discussion (no related file):
Can you please resolve the failing tests here https://ci.appveyor.com/project/PowerShell/xactivedirectory/builds/25563778?fullLog=true#L307

@JamesFrierson1 with "Please add an the empty row after this section" i meant after the row (after the section header) 🙂

@JamesFrierson1 When you have resolved the review comments, then please go into reviewable and write done on each so I can resolve them. 🙂

Thank you for your patience, @johlju !  I added the proper spacing per your instructions and updated my changlog entry with a link to the issue

@JamesFrierson1 Thank you for this! 😃

You're very welcome @joeyaiello ! My pleasure 😄


Buying Items

Next to Add New item there should be Buy Item. After save it should subtract money from campaign. There should be also Reclaim money button to cancel purchase.

This I want.


VPC Fails to create with when creating stack in cloud formation

I attempted to use the cf template to "Deploy Utility Meter Data Analytics into a new VPC on AWS" and the stack fails to create on the VPC. On the Logical ID of "VPC" I am getting a "S3 Error Access Denied" but unfortunately, no more information is provided in the log than that. the role has Admin Access should I would assume S3 Access Denied should not be a problem. Any suggestions for debugging this would be great.

Hi Adriano,
for further debugging you can switch into the resource tap and open the VPC stack, which should give you more detailed information.
One thought on the error itself: Have you changed the region where the Quick Start should be deployed to? If yes, you have also to adjust the "Quick Start S3 bucket Region" parameter on the template configuration page to the region you want to deploy to.

Sure, so see image below for resource tab, unfortunately it does not provide any additional information other than "S3 Error". Yes, I have changed the region where the Quick Start should be deployed to, however, I did adjust the "Quick Start S3 bucket Region" to be the same region.

Hi, couldn't reproduce yet. I'm working on a solution.

Ok I think I identified the root problem of this particular error after trying all possible combinations in the parameters of this template:
I changed the Quick Start S3 bucket name to be a bucket that I created myself. However when I leave it to the default, this error doesn't happen. Shouldn't it be possible to change the name of this bucket or should it be left to be "aws-quickstart"?

Right, that makes sense. This parameter defines the name of the S3 bucket in which the Quick Start content/artifacts lives.
You only need to change it, if you upload the scripts to a bucket in your own account, this then needs to be referenced here.


New Files created a per Iguana UI standards

Please pull following three files into iguana codebase:
send-to-address.js - new file
send-toaddress.css - new file
dashboard.html ( UI changes applied )

@Iamwebguru it seems that your fork is out of sync

@i


Bobby's Contributions

[X] 01-Introduction/03-python-backgroud
[ ] 02-Using-gem5/01-stdlib (0% Complete)

Still to do.

[X] 02-Using-gem5/11-multisim
[ ] 03-Developing-gem5-models/05-modeling-cores (90% Complete)

Materials "completed example" needs finished.
Need to complete slides explanation of ISA parsing from .isa to .ini files (could use some help here).

[X] 06-Contributing/02-testing
[X] 06-Contributing/01-contributing

None of these sections have been tested, or even checked for formatting, typos, etc. This is very much still a TODO. Completion of the above list is for content, not verification of content.

Closing and replaced with PRs #29 #30 #31 #32


[WIP] Make Seqno uint64

This is because KBFS's RootMetadata pulls in Seqno via MerkleRootV2, and so
the go-codec changes would affect its encoding.

Patched go-codec instead


Sequelize authenticate failure silenced

At the moment the plugin calls Sequelize authenticate() but does not handle the exception that might occur, resulting 404 route not found due to a silenced internal error.
I got a fix for it (still need to write some tests for it), what is the process on this repo to propose a change ? Simply create a fork then PR  ?

@samudurand I suggest you make the PR. Reference this issue you the commit/pull request.

I have a branch ready but I made it from master, not knowing that there is a develop branch too, should I rebase against that one and make the PR against 'develop' ? Or would a PR against master suffice ?

@samudurand I'm not a maintainer here but I'd do it against master as that's the branch used for release. It looks like develop is outdated.

thanks for the advice :)

Opened the PR under my other account


fix(linter): fix rule noFocusedTests checking test call expressions

Summary
closes #3791
Fixed a case where test call expressions are failed to be treated as one of them.
Previously:
describe.only("foo", () => {});
describe.only(foo, () => {}); // ❌ failed to report as linter error

Only supports test call expressions with string-like expressions.
Currently:
describe.only("foo", () => {});

// works with any JavaScript expressions
describe.only(foo, () => {});
describe.only(foo.bar, () => {});

Every JavaScript expressions are supported.

Test Plan
Tests are added.

@chansuke Hi! I think it's ready ❤ Thank you for helping me review this.

LGTM :)
Could you add an entry in our CHANGELOG?

Sure thing!


Update datastores.md

Changes

Fix inconsistency in OrderedDatastore GetSortedAsync example code. Changed code block line 31 from pairs(data) to pairs(entries)

Looks great, thank you @RoyallyFlushed!

Thanks!


P0 - Cloud Deployment script

Create deployment script to deploy on google cloud.

Make Temp directory,
Clone Repo
Checkout to branch shabdak_2
npm install; npm run build
delete everything except build and app.yaml
Google Cloud deploy
Clean the directory

Done and checked in the script


Resiliency in k8s must restart service

I am using Dapr in K8s，but when i applied resiliency spec in k8s，i must restart my app service otherwise it won't work.
below is what i do to make the resilency spec work.

resilency.yaml in namespace tenent1

apiVersion: dapr.io/v1alpha1
kind: Resiliency
metadata:
  name: resiliency-ns1
  namespace: tenent1

scopes:
  - refactor-test-app1

spec:
  policies:
    timeouts:
      general: 2s
      important: 30s
      largeResponse: 30s

  targets:
    apps:
      refactor-test-order:
        timeout: general

kubectl apply -f resiliency.yaml
restart  refactor-test-app1 Service

I have two questions about this

is there any solution that can make the resiliency work without restart service
in my k8s, i may put my service to many namespaces, can i make the resilency spec work in all namespaces，from the example above, the resiliency.yaml is targeted to tenent1 namespace，if i have a namespace tenent2, i have to make a new resilency.yaml file and change the namespace to tenent2

can anyone help me, thanks!

Did you try the hot reloading feature?
https://docs.dapr.io/operations/components/component-updates/#hot-reloading-preview-feature

Did you try the hot reloading feature? https://docs.dapr.io/operations/components/component-updates/#hot-reloading-preview-feature

@scosta-kar  thanks , but i tried , the hot reloading feature does not work for me
i do the following steps,

modify configuration.yaml

apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: appconfig
  namespace: tenent1
spec:
  features:
    - name: "Component Hot Reloading"
      enabled: true
    - name: "Subscription Hot Reloading"
      enabled: true

run command kubectl apply -f configuration.yaml

restart apps
modify resiliency.yaml, timeout.general from 2s to 10s
test call AND the daprd logs as belows
time="2024-09-23T10:36:13.369886491Z" level=warning msg="Error processing operation endpoint[refactor-test-order, refactor-test-order:items/100]. Retrying in 2s…" app_id=refactor-test-app1 instance=refactor-test-app1-6895cc7b57-n7qv2 scope=dapr.runtime type=log ver=1.14.2

it seems the timeout value is still 2s NOT 10s, in fact my service will return in 5s, if the resiliency works, the daprd pod should not trigger timeout policy.

Hot reloading currently only works for Component and declarative Subscription resources. It is planned, but other resources are not currently hot reloaded and require a restart.


Reporting on old-ish DevDependencies

I'm one of those Windows developers that still hasn't installed a virtualbox for front-end development (the effort vs laziness calculate is ongoing). I imagine there aren't many developers tweaking Foundation in a Win10 environment, but a quick idea:
I had a few funky issues building the local docs to test out some javascript tweaks -  here's the gist - and had to override some of the defined version preferences in package.json. Not a Zurb issue, just some of the low level dependencies were a bit wonky compiling for Win x64.
I've used a handy grunt module in the past to report on, and optionally update devDependencies. Here's the notes on Foundation 5.5.3:  Gist: grunt-update-dev.
I use this on my stuff, and if it sounds useful to you, I've stuck in a pull request to add in the required changes. #7015

Looks like it's all change now. Time to learn Gulp.


The user is redirected to the Home screen after restoring the internet connection

Precondition:
The user is logged-in
Steps to reproduce:

Tap the "Send" button
Fill in the "Send to" form and proceed
Fill in the "How much" form and proceed
Fill in the "What for?"


Bump Alloy

We're currently running v0.2.0 while the latest is 0.5.4 which will also contain fix to issues like https://github.com/alloy-rs/alloy/issues/787 that is related to #332

Closed in https://github.com/chainbound/bolt/pull/378


[New Resource] xServerCertReq

I have a custom Document Signing Certificate Template that I would like to request from the CA.
There are 2 reasons the current implementation of xCertReq does not work for this:

The issued Certificate does not have a Subject even if you put one in the inf. Therefore the Primary Key would have to be the friendly name.
It fails if you use "[RequestAttributes]CertificateTemplate = $CertificateTemplate" in the inf. You need to remove that line and instead use certreq -submit -q -attrib CertificateTemplate:$CertificateTemplate -config $CA $ReqPath $CerPath

I would be happy to implement this if the CR is accepted.

For Reference:
The Custom Certificate Template that I am using is enabled for all Domain Coumputers. The properties are:
"pKIDefaultKeySpec" = "1"
"pKIKeyUsage" = "0x30"
"pKIMaxIssuingDepth" = "0"
"pKICriticalExtensions" = "<IP_ADDRESS>"
"pKIExpirationPeriod" = "0 64 57 135 46 225 254 255"
"pKIOverlapPeriod" = "0 128 166 10 255 222 255 255"
"pKIExtendedKeyUsage" = "<IP_ADDRESS>.<IP_ADDRESS>.2"
"pKIDefaultCSPs" = "1,Microsoft RSA SChannel Cryptographic Provider"
"msPKI-RA-Signature" = "0"
"msPKI-Enrollment-Flag" = "32"
"msPKI-Private-Key-Flag" = "0"
"msPKI-Certificate-Name-Flag" = "134217728"
"msPKI-Minimal-Key-Size" = "2048"
"msPKI-Template-Schema-Version" = "2"
"msPKI-Template-Minor-Revision" = "0"
"msPKI-Cert-Template-OID" = "<IP_ADDRESS>.4.1.3<IP_ADDRESS>46803.10615762.2181305.874203.5733703.45.5340052.3640521"
"msPKI-Certificate-Application-Policy" = "<IP_ADDRESS>.4.1.311.80.1"

Hi @aboersch - thanks for submitting this issue - and the offer to resolve it! :grin:
I'm wondering if there is something else there is going on here? Are you able to post the output of the DSC logs for this and also the DSC Config you're using?
I added a Document Signing certificate template (that hopefully should have been the same as yours) to my CA and was able to issue a cert from it using the same basic code from the resource.
Could you check that the CertificateTemplate name you're passing to the resource does not contain spaces (e.g. "DocumentSigning" - not "Document Signing")?

Allow me to first explain what I am trying achieve:
I have created a Document Signing Template using PowerShell on my CA. The purpose of the issued Certificates will be encrypting Credentials in MOFs for DSC as per Microsoft specs.
Now I am trying to get the DSC clients to request such a Certificate.
The name of the Certificate Template is "DSC", no spaces or anything else.
Here is the code to create the template:
`
$templateName = "DSC"
$configContext = ([ADSI]"LDAP://RootDSE").ConfigurationNamingContext
$ADSI = [ADSI]"LDAP://CN=Certificate Templates,CN=Public Key Services,CN=Services,$configContext"
$template = [ADSI]"LDAP://CN=$templateName,CN=Certificate Templates,CN=Public Key Services,CN=Services,$ConfigContext"
if([string]::IsNullOrEmpty($template.Name)){
# create if not exists
$template = $ADSI.Create("pKICertificateTemplate", "CN=$($templateName)")
}
$template.Put("displayName", $templateName)
$template.SetInfo()
$pkiConfig = @{
"pKIDefaultKeySpec" = "1"
"pKIKeyUsage" = "160 0"
"pKIMaxIssuingDepth" = "0"
"pKICriticalExtensions" = "<IP_ADDRESS>"
"pKIExpirationPeriod" = "0 64 57 135 46 225 254 255"
"pKIOverlapPeriod" = "0 128 166 10 255 222 255 255"
"pKIExtendedKeyUsage" = "<IP_ADDRESS>.<IP_ADDRESS>.2"
"pKIDefaultCSPs" = "1,Microsoft RSA SChannel Cryptographic Provider"
"msPKI-RA-Signature" = "0"
"msPKI-Enrollment-Flag" = "32"
"msPKI-Private-Key-Flag" = "0"
"msPKI-Certificate-Name-Flag" = "134217728"
"msPKI-Minimal-Key-Size" = "2048"
"msPKI-Template-Schema-Version" = "2"
"msPKI-Template-Minor-Revision" = "0"
"msPKI-Cert-Template-OID" = "<IP_ADDRESS>.4.1.3<IP_ADDRESS>46803.10615762.2181305.874203.5733703.45.5340052.3640521"
"msPKI-Certificate-Application-Policy" = "<IP_ADDRESS>.4.1.311.80.1"
}
foreach($key in $pkiConfig.Keys){
$template.Put($key, $pkiConfig[$key])
}
Does not work correctly if not done like this
$k = new-Object Byte[] 1
$k[0] = 48 # = 0x30
$template.InvokeSet("pKIKeyUsage", $k)
$template.SetInfo()
Allow Computers to Enroll
$template.ObjectSecurity.GetAccessRules($true, $true, [System.Security.Principal.NTAccount])
$acc = [System.Security.Principal.NTAccount]::new($Using:domainNetbiosName, "Domain Computers")
$enrollObjectType = [Guid]::Parse("0e10c968-78fb-11d2-90d4-00c04f79dc55")
$adRights = [System.DirectoryServices.ActiveDirectoryRights]::ReadProperty -bor [System.DirectoryServices.ActiveDirectoryRights]::WriteProperty -bor [System.DirectoryServices.ActiveDirectoryRights]::ExtendedRight
$rule = [System.DirectoryServices.ActiveDirectoryAccessRule]::new($acc, $adRights, [System.Security.AccessControl.AccessControlType]::Allow, $enrollObjectType)
$template.ObjectSecurity.AddAccessRule($rule)
$template.commitchanges()
`
Should you have a better Template for DSC signing please be so kind as to share your properties here. You can read them using:
`
$templateName = "Workstation"
$ConfigContext = ([ADSI]"LDAP://RootDSE").ConfigurationNamingContext
$ADSI = [ADSI]"LDAP://CN=Certificate Templates,CN=Public Key Services,CN=Services,$ConfigContext"
$template = [ADSI]"LDAP://CN=$templateName,CN=Certificate Templates,CN=Public Key Services,CN=Services,$ConfigContext"
$template.Properties.PropertyNames | ? {$.StartsWith("pKI") -or $.StartsWith("msPKI-")} | % {
Write-Host """$"" = ""$($template.psbase.Properties.Item($).ToString())"""
}
`
I am currently unable to get the exact error message and will add later but the REQ File was not being created when I included the following in the INF:
@" [RequestAttributes] CertificateTemplate = $CertificateTemplate "@

Here is the error from DSC:
PowerShell DSC resource MSFT_xCertReq  failed to execute Set-TargetResource functionality with error message: Certificate Request file 'C:\Windows\TEMP\xCertReq-b48146a6-ad71-4cc2-8cf9-4f7030adf411.req' not
found.

If I invoke the certreq manually:
& certreq.exe @('-submit','-q','-config',"$CAName","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.inf","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.cer")
I get:
Certificate Request Processor: ASN1 bad tag value met. 0x8009310b (ASN: 267 CRYPT_E_ASN1_BADTAG)
This is the config I used
configuration Test{
    Import-DscResource -ModuleName xCertificate
    node localhost {
        LocalConfigurationManager{
            RefreshMode = 'Push'
        }
        xCertReq cert {
            Subject = $env:COMPUTERNAME
            CAServerFQDN = #<Redacted>
            KeyLength = 2048
            CARootName = #<Redacted>
            ProviderName = 'Microsoft RSA SChannel Cryptographic Provider'
            OID = '<IP_ADDRESS>.4.1.311.80.1'
            CertificateTemplate = 'DSC'
        }
    }
}

Test

Set-DscLocalConfigurationManager -Path .\TEST
Start-DscConfiguration -Wait -Verbose -Path .\TEST

And here is the generated INF:
[NewRequest]
Subject = "CN="
KeySpec = 1
KeyLength = 2048
Exportable = TRUE
MachineKeySet = TRUE
SMIME = FALSE
PrivateKeyArchive = FALSE
UserProtected = FALSE
UseExistingKeySet = FALSE
ProviderName = Microsoft RSA SChannel Cryptographic Provider
ProviderType = 12
RequestType = CMC
KeyUsage = 0xa0
[RequestAttributes]
CertificateTemplate = DSC
[EnhancedKeyUsageExtension]
OID = <IP_ADDRESS>.4.1.311.80.1

Hi @aboersch - That is some great info. I'm just doing some work on this resource and will give this a try and include your suggested changes to see if it causes any other side affects (e.g. passes all regression tests)

Hi @aboersch - I've figured out what the issue is:
The xCertReq resource can only request certificates for a machine - it can't request user certificates because the DSC LCM always runs under a machine context (even if you're logged onto the node and applying the config manually).
The DSC template above DSC is created as a user certificate, so xCertReq can't issue it - but you could issue it yourself if you're logged on because you're issuing it under a user context.
So what you'd need to do is create a template that is based on a machine certificate. In my case I just duplicated the Computer template and customized it as per this page.
This is the output of the cert I created:
"pKIDefaultKeySpec" = "1"
"pKIKeyUsage" = "176"
"pKIMaxIssuingDepth" = "0"
"pKICriticalExtensions" = "<IP_ADDRESS>"
"pKIExpirationPeriod" = "0 64 57 135 46 225 254 255"
"pKIOverlapPeriod" = "0 128 166 10 255 222 255 255"
"pKIExtendedKeyUsage" = "<IP_ADDRESS>.4.1.311.80.1"
"pKIDefaultCSPs" = "1,Microsoft RSA SChannel Cryptographic Provider"
"msPKI-RA-Signature" = "0"
"msPKI-Enrollment-Flag" = "32"
"msPKI-Private-Key-Flag" = "16842752"
"msPKI-Certificate-Name-Flag" = "134217728"
"msPKI-Minimal-Key-Size" = "2048"
"msPKI-Template-Schema-Version" = "2"
"msPKI-Template-Minor-Revision" = "7"
"msPKI-Cert-Template-OID" = "<IP_ADDRESS>.4.1.3<IP_ADDRESS>59389.32918.1590937.4996186.12020124.235.10768362.8251361"
"msPKI-Certificate-Application-Policy" = "<IP_ADDRESS>.4.1.311.80.1"

Does that make sense and/or help?

Hi, the above Certificate Template is based on a computer certificate. I am able to request it as the system account, though that issue does affect the the repro i reported

Hi @aboersch - hmm that is odd.
The error is actually occurring when converting the *.INF into a *.REQ. When you're doing this manually you're directly submitting the *.INF:
& certreq.exe @('-submit','-q','-config',"$CAName","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.inf","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.cer")

Can you try:
& certreq.exe @('-new','-q','-config',"$CAName","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.inf","C:\Windows\Temp\xCertReq-015bb903-c3bd-4707-91e6-38c74caa70e8.req")

Does this create the *.REQ file?


trial of enzyme (airbnb test approach for react)

#41
http://airbnb.io/enzyme/index.html
(checkout it out based on the advice from the react home page https://facebook.github.io/react/docs/test-utils.html)
it uses chai (http://chaijs.com) and mocha under the covers.

Coverage remained the same at 100.0% when pulling d01ed6af130bd6e58ae1ac7c8e360ee835ba38f4 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling ea172584359e6eb24fef09cabbd9062aa5435257 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling 8c7b446f0fc5f5877e85410ee77a72c29c7e9224 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling 8c7b446f0fc5f5877e85410ee77a72c29c7e9224 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling 891ee74631daf052adba2af2535134d9c0f7e018 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling 66e0fa023f2e0251e1c5aa41da6adfd362f36209 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling 8b9e3b3033fc3f1c623252de7cf2b64c774f1cba on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage decreased (-98.3%) to 1.748% when pulling ca15e8d3c832e641a6e9411f8c86438c727f3f8f on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

Coverage remained the same at 100.0% when pulling b5aadca6fce015ed0e128a2e5a9a4943798f6ef3 on add-test into e459fb92a8308307105949021889ee8455f90688 on master.

struggling to figure out how to get both javascript and python coverage info into coveralls.
here is a version of the results when just the javascript info is passed through:
https://coveralls.io/builds/5919278
Tried the multiple language option show on this page https://pypi.python.org/pypi/coveralls. No luck.
Will keep digging.

The error message I get suggests that the javascript info is not quite in the right format or is missing something:
$ coveralls -v --merge=coverage/coverage-final.json --output=foo.json
Missing .coveralls.yml file. Using only env variables.
No data to be merged; does the json file contain "source_files" data?
Write coverage report to file...
...

Coverage decreased (-67.0%) to 33.024% when pulling eeadef08c31f08628e84b2d2784877b8c38bf896 on add-test into 7997cfb9b25459542f0f99235a37c294535e5c9c on master.

@rloomans using the coveralls-lcov ruby gem / cli does the trick and the coverage data is merged successfully. need to update the readme with some info.
anything else before I merge? seems like a reasonable spot to start

Looks good to me. Merge it.

Coverage decreased (-67.0%) to 33.024% when pulling 9bb4928505cdc1395d1533b5e7a26700283381e7 on add-test into 7997cfb9b25459542f0f99235a37c294535e5c9c on master.


proposal: testing,cmd/test2json: distinguish error output

Currently the go test -json provides no way to disambiguate output produced by (*testing.T).Error{,f} and (*testing.T).Fatal{,f} from other test logging. This fact makes it difficult for CI systems to identify what part of the output is most pertinent for constructing summaries of test failures.
Consider a test that failed, producing a lot of log messages as a result. Reporting the full log of the test can often be distracting and overly specific, resulting in many CI systems (such as LUCI) not constructing test failure summaries for Go tests at all.
Heuristics such as taking the last line logged before a test fails work often, but not often enough to fully solve the problem. Enough tests call (*testing.T).Error{,f} and fail later (after more log output) that this heuristic is unreliable. This works even less well when considering tests that crash or panic: that last line is often going to be some random line in the stack trace.
I propose adding a boolean field to "output" actions in the JSON produced by cmd/test2json called "Error". This field would be "true" for any "output" actions that were produced via (*testing.T).Error{,f} and (*testing.T).Fatal{,f}. This field would be also be "true" for the first few lines of a crash (but notably not the stack trace itself).
For example:
{"Time":"2023-09-19T15:19:12.447816654Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"--- FAIL: TestHeap (0.00s)\n","Error":false}
{"Time":"2023-09-19T15:19:12.449904543Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"panic: ahhh [recovered]\n","Error":true}
{"Time":"2023-09-19T15:19:12.449923813Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"\tpanic: ahhh\n","Error":true}
{"Time":"2023-09-19T15:19:12.449928103Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"\n","Error":false}
{"Time":"2023-09-19T15:19:12.449932593Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"goroutine 6 [running]:\n","Error":false}
{"Time":"2023-09-19T15:19:12.449936283Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"testing.tRunner.func1.2({0x51ad20, 0x577910})\n","Error":false}
{"Time":"2023-09-19T15:19:12.449940423Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"\t/usr/local/google/home/mknyszek/work/go-1/src/testing/testing.go:1545 +0x24a\n","Error":false}
{"Time":"2023-09-19T15:19:12.449953903Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"testing.tRunner.func1()\n","Error":false}

Which lines of a crash get marked would be entirely up to cmd/test2json. Because it lives in the standard library, it can reasonably be coupled (with tests) to the crash output that the Go runtime produces.
Testing binaries' -test.v=test2json output would need to be adjusted such thatcmd/test2json could interpret errors correctly. For this, I propose the use of a new marker character (I am not picky as to which) at the beginning of a frame (delineated currently by ^V (0x16)).

cmd/test2json consumes the stdout from a test process as its input. Presuming the testing package would need to add some kind of new framing to communicate whether the text that follows indicates an error?

Yup! I don't know the history of how ^V (0x16) was chosen as the current framing marker, but we would need another one probably. I'm not really sure how to pick another one, though. I assume it should probably be invisible again? I'm open to suggestions.

The proposal looks good to me from a LUCI perspective.
Implementation-wise, with the frame markers - is there any concern about race conditions when tests are run in parallel? Or maybe this is the best that is available with the current implementation.
Beyond this proposal - if I can offer a CI perspective on what sort of structured data may be useful for a language like golang to generate -:

Structured reasons for build failures. I note there is an existing proposal in this regard: https://github.com/golang/go/issues/23037
Stack traces for test failures (avoiding the need to scrape logs, e.g. if the user provides an error directly to t.Error() or if the test panics). We do not use these in LUCI Analysis yet, but there have been requests along this line. Having the stack traces seperated out can be useful for presentation reasons, to cluster them for test bug triage, and/or to match stack traces in seen test failures with stack traces seen out in the wild from crash telemetry.

One of the best test frameworks I have come across so far in terms of structured result output is Tast [1], the integration-testing framework for ChromeOS. It captures the time, reason, file and stack trace for all errors that cause a test to fail [2].
[1] https://chromium.googlesource.com/chromiumos/platform/tast/
[2] https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/tools/result_adapter/tast.go;l=63

A few further thoughts:

Where long output is produced, is it guaranteed that all output to one .Fatal() or .Error() call will be output on one test2json output line? I was under the impression that test2json pulls from stdout which is buffered. If one error may be split over two or more test2json output lines, could this affect the ability to recover the source errors? (observing one test may produce multiple errors)
I note the proposal does not specify if the error is fatal or not (i.e. comes from .Fatal(...) or .Error(...)). For failure reasons in LUCI Analysis, we typically capture the first fatal error, or the first error otherwise: https://source.chromium.org/chromium/infra/infra/+/main:go/src/go.chromium.org/luci/resultdb/proto/v1/failure_reason.proto;l=30?q=resultdb failure reason

I think this is because fatal errors are generally seen as more interesting (panics, etc.)
But you could always go with the first error if you prefer. The main thing would be to be consistent with the uploaded failure reason.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

This seems reasonable, and following the existing framing seems fine too.

Have all remaining concerns about this proposal been addressed?

It looks like ^N and ^O are available and make a reasonable amount of sense, as these things go.
^N means start error text ("shift in") and ^O means back to regular text ("shift out").

@patrickmeiring For LUCI, I think first error makes the most sense and is the most consistent. Fatal is defined as Error+FailNow, and some programs or library code do call FailNow themselves. Code should not distinguish Error-generated messages from Fatal-calling-Error-generated messages.

@mknyszek I'm not sure about the part where the first few lines of a crash are tagged "Error":true. It seems clearer conceptually and certainly easier implementation-wise to only tag messages from t.Fatal/t.Error with "Error":true. To tag runtime crashes you'd have to make the runtime emit the ^N and ^O or else have some easily-fooled pattern matching in test2json.
#61839 is (now) about reporting a non-zero exit status in -json output. Perhaps that would be enough for crashes? You'd see the exit status and click on the full output and see the crash text.

@rsc

Re: Selecting first error - that sounds fine to me.
Re: test crashes - extracting the reasons for these would be useful as this is one of the main ways tests fail. Is there no standard panic recovery code path used in go test that we can hook into?
Re:  Have all remaining concerns about this proposal been addressed?
I am seeking clarification on the behaviour if the program emits multiple errors, e.g.

t.Error(strings.Repeat("a", 1_000_000))
t.Error(strings.Repeat("b", 1_000_000))

Will it be possible to identify there were two errors, and to distinguish error a (with possibly long output) from error b?
See comment about buffering above. @mknyszek

Will it be possible to identify there were two errors, and to distinguish error a (with possibly long output) from error b?

Yes, there will be two ^N...^O sequences in the output.

Yes, there will be two ^N...^O sequences in the output.
And how will these sequences be distinguished in cmd/test2json output?

It looks to me like cmd/test2json is stripping out those control characters and slicing the sequences into an arbitrary number of JSON messages.
E.g. the following example output from comment 1:
{"Time":"2023-09-19T15:19:12.449904543Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"panic: ahhh [recovered]\n","Error":true}
{"Time":"2023-09-19T15:19:12.449923813Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"\tpanic: ahhh\n","Error":true}

Looks like it is all the same error based on the "Output" field.
But this is structurally the same as the output I would expect from two errors (aaaaaaa...) and (bbbbb.....):
{"Time":"2023-09-19T15:19:12.449904543Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"aaaaaaaaaaa","Error":true}
{"Time":"2023-09-19T15:19:12.449923813Z","Action":"output","Package":"golang.org/x/exp/trace","Test":"TestHeap","Output":"bbbbbbbbbb","Error":true}

To tag runtime crashes you'd have to make the runtime emit the ^N and ^O or else have some easily-fooled pattern matching in test2json.

Re: test crashes - extracting the reasons for these would be useful as this is one of the main ways tests fail. Is there no standard panic recovery code path used in go test that we can hook into?

I think we could easily tag panics that are recovered and re-panicked by the testing package itself. That doesn't capture runtime fatal panics or panics from other goroutines, but I imagine that would get the vast majority of test panics and should be easy to implement in the testing package.

@patrickmeiring I see what you mean. We need two different ways to flag an output line: "start of error" and "continuation of error".  Perhaps we should use
"Text": "error"
"Text": "error-continue"
and that leaves the door open for other kinds of Text as well, like we could have "Text": "frame" for all the framing text ("=== RUN" and so on) so test systems can decide to gray it out.
?

Have all remaining concerns about this proposal been addressed?
In go test -json output, the "Action":"output" lines would be annotated with an optional new field "OutputType" giving the kind of output included in the entry. The initial kinds would be:

“error”, meaning text produced by t.Error/t.Fatal
“error-continue”, meaning a continuation line from the previous “error”
“frame”, meaning framing text like “=== RUN TestCase” that is already expressed more directly in other events

The specific implementation of “error” and “error-continue” would be that in test2json mode the test would print error text wrapped in ^N...^O, and test2json would recognize and remove these, the same as it does today for ^V around framing.

Have all remaining concerns about this proposal been addressed?

The only open question I can see is whether to capture panics on other (non-test) goroutines and report them as errors. My take here is:

If a panic on another goroutine crashes the go test process instead of just failing a test, I think it is fine to not frame them with ^N and ^O (although it may still be useful to do so).
On the other hand, if a panic on an other goroutine is attributed to a test and ends up failing that test, then it would be better to frame the error so it can be reported as the test failure reason.

Either way, the resolution of this issue need not block the proposal as even a partial ability to extract failure reasons will be a significant improvement over the status quo.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group
In go test -json output, the "Action":"output" lines would be annotated with an optional new field "OutputType" giving the kind of output included in the entry. The initial kinds would be:

“error”, meaning text produced by t.Error/t.Fatal
“error-continue”, meaning a continuation line from the previous “error”
“frame”, meaning framing text like “=== RUN TestCase” that is already expressed more directly in other events

The specific implementation of “error” and “error-continue” would be that in test2json mode the test would print error text wrapped in ^N...^O, and test2json would recognize and remove these, the same as it does today for ^V around framing.

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group
In go test -json output, the "Action":"output" lines would be annotated with an optional new field "OutputType" giving the kind of output included in the entry. The initial kinds would be:

“error”, meaning text produced by t.Error/t.Fatal
“error-continue”, meaning a continuation line from the previous “error”
“frame”, meaning framing text like “=== RUN TestCase” that is already expressed more directly in other events

The specific implementation of “error” and “error-continue” would be that in test2json mode the test would print error text wrapped in ^N...^O, and test2json would recognize and remove these, the same as it does today for ^V around framing.

@rsc Should OutputType be empty/omitted for regular output events? As in if I t.Log("foo") will the event for that have an OutputType?

Design update

^N means start error text ("shift in") and ^O means back to regular text ("shift out").

^N is shift out and ^O is shift in, respectively, so I'm using ^O for start of error and ^N for end of error.
I added ^[ (escape) to escape control/framing characters (^V, ^O, ^N, and ^[ itself). @adonovan asked about escaping ^O within error messages and I discovered that the current use of ^V does not include escaping which leads to faulty -json output in the test2json tests, so I added escaping to all output when framing is enabled.


Flowing water to still water "endless Well"

If you take a Waterblock out of a 1Block deep Sea, normally the other blocks around should fill up the missing water and become standing water.
Without this also the "endless Well" is not working.

What is the contents of your world.ini file?

Oh.. ok perhaps its my bad. I am Sorry. But thanks for your help. here it is

[SpawnProtect]
ProtectRadius=10
[WorldLimit]
LimitRadius=0
[Difficulty]
WorldDifficulty=1
[General]
Dimension=Overworld
IsDaylightCycleEnabled=1
Gamemode=0
Weather=0
TimeInTicks=13403
[Broadcasting]
BroadcastDeathMessages=1
BroadcastAchievementMessages=1
[SpawnPosition]
MaxViewDistance=12
PregenerateDistance=20
X=-611.09742876027
Y=85
Z=1011.5583653016
[Storage]
Schema=Default
CompressionFactor=0
[Plants]
MaxCactusHeight=3
MaxSugarcaneHeight=3
IsCactusBonemealable=0
IsCarrotsBonemealable=1
IsCropsBonemealable=1
IsGrassBonemealable=1
IsMelonStemBonemealable=1
IsMelonBonemealable=0
IsPotatoesBonemealable=1
IsPumpkinStemBonemealable=1
IsPumpkinBonemealable=0
IsSaplingBonemealable=1
IsSugarcaneBonemealable=0
[Physics]
DeepSnow=1
ShouldLavaSpawnFire=1
TNTShrapnelLevel=2
WaterSimulator=Vanilla
LavaSimulator=Vanilla
SandInstantFall=0
RedstoneSimulator=Incremental
[Mechanics]
CommandBlocksEnabled=0
PVPEnabled=1
UseChatPrefixes=1
[Monsters]
VillagersShouldHarvestCrops=1
AnimalsOn=1
Types=bat, cavespider, chicken, cow, creeper, enderman, horse, mooshroom, ocelot, pig, sheep, silverfish, skeleton, slime, spider, squid, wolf, zombie
[LinkedWorlds]
NetherWorldName=world_nether
EndWorldName=world_end
[Generator]
Generator=Composable
BiomeGen=MultiStepMap
ShapeGen=DistortedHeightmap
CompositionGen=DistortedHeightmap
Finishers=Ravines, WormNestCaves, WaterLakes, WaterSprings, LavaLakes, LavaSprings, OreNests, Mineshafts, Trees, Villages, SprinkleFoliage, Ice, Snow, Lilypads, BottomLava, DeadBushes, NaturalPatches, PreSimulator, Animals
BiomeGenCacheSize=64
BiomeGenMultiCacheLength=4
SeaLevel=62
BiomalNoise3DFrequencyX=40.000000
BiomalNoise3DFrequencyY=40.000000
BiomalNoise3DFrequencyZ=40.000000
BiomalNoise3DBaseFrequencyX=40.000000
BiomalNoise3DBaseFrequencyZ=40.000000
BiomalNoise3DChoiceFrequencyX=40.000000
BiomalNoise3DChoiceFrequencyY=80.000000
BiomalNoise3DChoiceFrequencyZ=40.000000
BiomalNoise3DAirThreshold=0.000000
BiomalNoise3DNumChoiceOctaves=4
BiomalNoise3DNumDensityOctaves=6
BiomalNoise3DNumBaseOctaves=6
BiomalNoise3DBaseAmplitude=1.000000
CompositionGenCacheSize=64
WormNestCavesSize=64
WormNestCavesGrid=96
WormNestMaxOffset=32
WaterLakesProbability=25
LavaLakesProbability=10
MineShaftsGridSize=512
MineShaftsMaxOffset=256
MineShaftsMaxSystemSize=160
MineShaftsChanceCorridor=600
MineShaftsChanceCrossing=200
MineShaftsChanceStaircase=200
VillageGridSize=384
VillageMaxOffset=128
VillageMaxDepth=2
VillageMaxSize=128
VillageMinDensity=50
VillageMaxDensity=80
BottomLavaLevel=10
PreSimulatorFallingBlocks=1
PreSimulatorWater=1
PreSimulatorLava=1
HeightGen=DistortedHeightmap
MultiStepMapOceanCellSize=384
MultiStepMapMushroomIslandSize=64
MultiStepMapRiverCellSize=384
MultiStepMapRiverWidth=0.125000
MultiStepMapLandBiomeSize=1024
DistortedHeightmapFrequencyX=10.000000
DistortedHeightmapFrequencyY=10.000000
DistortedHeightmapFrequencyZ=10.000000
[WaterSimulator]
Falloff=1
TickDelay=5
NumNeighborsForSource=2
[LavaSimulator]
Falloff=2
TickDelay=30
NumNeighborsForSource=-1
[FireSimulator]
BurnStepTimeFuel=500
BurnStepTimeNonfuel=100
Flammability=50
ReplaceFuelChance=50000
[Seed]
Seed=361820914
[WaterSprings]
HeightDistribution=0, 0; 10, 10; 11, 75; 16, 83; 20, 83; 24, 78; 32, 62; 40, 40; 44, 15; 48, 7; 56, 2; 64, 1; 255, 0
Chance=24
[LavaSprings]
HeightDistribution=0, 0; 10, 5; 11, 45; 48, 2; 64, 1; 255, 0
Chance=9
[Animals]
AnimalSpawnChunkPercentage=10

You're right, indeed it doesn't work. Weird, I was under the impression that this had been implemented. Perhaps it's in the Floody simulator only?

[WaterSimulator]
Falloff=1
TickDelay=5
NumNeighborsForSource=2
This might be a hint

OK... and.. what should i use here?

No, the value is correct. The code handling it seems to be broken.

Some news here?
Can the code handling be fixed?


commandline codegen theme does not exist

I tryied to http://docs.orchardproject.net/Documentation/Customizing-the-default-theme
but the suggested command "codegen theme" doesnt seem to exist.

Have you enabled the 'Code Generation' feature?

You must specify the name of the the theme you want to generate :
codegen theme MyTheme


Angular 5 upgrade errors

after running AoT in angular v4.x
Can't resolve all parameters for EntitiesDrawerService in

....../node_modules/angular-cesium/src/services/drawers
/entities-drawer/entities-drawer.service.d.ts: ([object Object], ?, ?).
This will become an error in Angular v5.x

Warning: Can't resolve all parameters for EntitiesDrawerService in
 ...../node_modules/angular-cesium/src/services/drawers/entities-drawer
/entities-drawer.service.d.ts:
 ([object Object], ?, ?). This will become an error in Angular v5.x

Yes we are working on a fix. We will realse a fix soon

+1

How is progress on this fix @eitanfr ?


Add share to options in map view

This PR allows a user to share a pin with a friend by pressing 'edit pin' from the map view rather than by having to go to the list view.

@jake-shasteen Looks good, merging.

signed :heavy_check_mark:


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Aahnik Daw

Additional Context:

Where did you meet Eddie?
YouTube
What do you like about this community/ why do you want to join?
Collaborate and learn
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


4.0.1 -  private method `permit' called for #Devise::ParameterSanitizer:...

Have updated from 3.5 to 4.0.1, I began getting deprecation warnings:

DEPRECATION WARNING: [Devise] Changing the sanitized parameters through "Devise::ParameterSanitizer#for(account_update) is deprecated and it will be removed from Devise 4.1.
Please use the permit method:

But, after updating in line with the warning/API readme, I get:

NoMethodError:
private method `permit' called for #Devise::ParameterSanitizer:0x000000106111c8
Did you mean?  print

@Bogadon Thank you for the report. Could you show some use case example code? With the example, we have more information to know what's going on.
Maybe this section on README helps you.

I believe this was caused by an error on my part using the parallel test suite. 4.0.1 seems to work fine now.
Apologies.

Thanks for the feedback!


Updated EXPM1() and Tests to New Engine

Signed-off-by: Matthew Wells<EMAIL_ADDRESS>Description
Updated EXPM1 function to run on the new engine, as well as added integration tests and unit tests. In addition also extracted common code that was repeated in many functions into a standalone base function they can call.
Issues Resolved
https://github.com/opensearch-project/sql/issues/1190
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented.

[x] New functionality has javadoc added
[x] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks for the changes! Shall we send separate PR for PPL?

Seems like a low priority.  We can raise a separate issue to create PPL equivalents.

Thanks for the changes! Shall we send separate PR for PPL?

Seems like a low priority. We can raise a separate issue to create PPL equivalents.

I wonder is this function for PPL low priority or having same scalar function set between SQL and PPL low priority?

This function was migrated from the legacy engine. It is pretty useless though, because expm1(x) === exp(x) - 1.

@dai-chen  https://github.com/opensearch-project/sql/issues/1339 raised to address PPL.  So this one is unblocked.


Slow Cursor Animation on Railway Station Page

🖥 Frontend Issue
Description
The cursor animation on the Railway Station page appears to be running very slowly, creating a lag that gives the impression the system is hanging. This affects the user experience, making the interface feel unresponsive and frustrating for users who may be in a time-sensitive environment.
Steps to Reproduce
1.Navigate to the Railway Station page.
2.Move the cursor around the page, especially over interactive elements (buttons, links, etc.).
3.Observe the delay and slowness in the cursor animation.
Expected behavior
The cursor animation should be smooth and responsive, ensuring a seamless user experience without lag or delay.
Actual behavior
The cursor animation moves sluggishly, leading to a stuttered and slow response time.
Screenshots or Video

Are you participating in GSSoC?

[ x] Yes
[ ] No

Please assign me this . i want to contribut in this

@dhairyagothi please assign me the issue


Widget Colors are only light or dark and do not match rest of color theme when applied to all.

Would be nice if jsapi widget colors could match the rest of the calcite color theme as well.

You could achieve this now by 1) overriding the widget background, foreground and hover states or by 2) setting the vars and recompiling the SASS https://github.com/Esri/calcite-maps/blob/master/lib/sass/support/arcgis-4.x.scss#L1. To apply dynamically like the UI components however is not realistic because there are too many classes and states to handle.

Thanks Allan for the quick responses. Hope to chat with you in person this week. Please update if anything changes on this topic.. Leave it up to you to close or keep open.


[Bug]: initializePaddle method doesn't contain all the available setup options from the docs

What happened?
I am currently trying to setup callback queries for my checkout process.
According to the docs, this apparently cannot be done at the checkout.open() stage. Instead, it should be set at the paddle.setup stage, by setting the eventCallback field.
(Sidenote: I would love it if it were possible to set up the callback when opening the checkout; would allow for passing additional contextual data!)
However, the PaddleSetupOptions type exposed by the typescript wrapper only allows for passing in the following three values, omitting any default settings:

environment
seller
token

Is this intended? Thanks in advance!
Steps to reproduce
N/A
What did you expect to happen?
Expected the initializePaddle and Paddle.Setup methods to support passing in settings for callback queries.
How are you integrating?
React
Logs
N/A

User error. Misread the type definition and missed the extends.... My bad, thank you anyway :)
FR stands though - would be great to be able to pass in the eventCallback method at the checkout.open stage!

Hi @PaulSonOfLars,
Glad that you were able to find the problem.

FR stands though - would be great to be able to pass in the eventCallback method at the checkout.open stage!
This is a good feedback. We will discuss within the team and see what we can do about this.

Thank you.


Have an issue with not finding worldguard on latest version.

Running Paper-1.13.2-b455, using worldguard-legacy-7.0.0-SNAPSHOT-dist, from FAWE Website, and using FastAsyncWorldEdit-bukkit-18.11.21-99fb2b5-2072, and it's giving me this error:
22.11 20:42:25 [Server] INFO Missing either WorldGuard or WorldEdit, Disabling Custom Flag Features...
22.11 20:42:25 [Server] INFO Latest WorldGuard/WorldEdit features could be missing. Please Update!
22.11 20:42:41 [Server] WARN Could not determine original WorldEdit version, treating it as 6.X!
UPDATE: Now getting this...
ERROR Could not pass event ChunkUnloadEvent to WorldGuardExtraFlags v4.1.1

You need to use WG 7 Beta 2 for 4.1.1


Keep VTI format?

Currently, the vti format only works for TreeMesh without AMR. Do we want fix this and make the VTI format available across all mesh types both with and without AMR?

I haven't used the VTI format anymore for at least 1.5 years. I originally implemented it because there were some mesh imprinting issues in the very beginning of Trixi's lifetime. If nobody has been using it, and nobody is willing to fix it, I'd be ok with removing it (although this would be a breaking change and should be reflected in the version number accordingly).


Fix file deletion handling during lint

This addresses some issues that were still causing crashes when files were deleted during a lint.
It adds handling for FileNotFound when LintRunner pushes paths onto the worker queue. It also adds a couple try-finally blocks to make sure that locks get released after a FileNotFound error is thrown.
Otherwise, deleted files would cause Rome to freeze when the onChanges handler is called for those deleted evictedPaths.
I removed the console.error from WorkerManager#getNextWorker so that I could use getFileStatsAssert to throw the FileNotFound error, but I can put it back if it’s still useful.

Looks good! Feel free to merge once CI passes. I wonder if there's a reliable way to integration test this.

Also probably a bunch of other instances where we should be calling lock.release() in a try-finally (unrelated to this PR).

Thanks! I'll see if I can figure out a good way to test this. And I'll look for other places where we should wrap lock.release().


Fix irc-addressed false positives

Commit 3e585499 replaced a subst-mutate with a .= subst as a
result of a v6.d deprecation. The surrounding code relied on the
return value being falsy when no substitution took place. This was
true for subst-mutate but isn't for subst which always returns
the resulting string. In this case, this caused every PRIVMSG to
fire an irc-addressed event.
This is fixed by using s///, which mutates but returns the Match
(or Nil).

Makes sense.


About OC

Do you have a OC version?

@LJYes
self.window = [[NotchKitWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];

Thanks, @Huang-Libo


Fix broken link.

This change is

Would you please squash the commits into one?

Would you please squash the commits into one?

Done, thanks.

@hwchiu thanks!


Clarification about the mask

Hi guys,
I have trouble understanding what is going on here
 # calculate attention mask for SW-MSA
            H, W = self.input_resolution
            img_mask = torch.zeros((1, H, W, 1))  # 1 H W 1
            h_slices = (slice(0, -self.window_size),
                        slice(-self.window_size, -self.shift_size),
                        slice(-self.shift_size, None))
            w_slices = (slice(0, -self.window_size),
                        slice(-self.window_size, -self.shift_size),
                        slice(-self.shift_size, None))
            cnt = 0
            for h in h_slices:
                for w in w_slices:
                    img_mask[:, h, w, :] = cnt
                    cnt += 1

I don't really understand why we need cnt.
Thanks!
Cheers,
Francesco

Hi @FrancescoSaverioZuppichini, the cnt is used to distinguish different areas. For points in different area, we need to add a attention mask for them.
You can find a discussion in this issue: https://github.com/microsoft/Swin-Transformer/issues/38#issuecomment-823806591


Speed up DefUseManager for large modules

Reworks storage of use lists for #846.
Replaces unordered_map<uint32_t, list> with set<pair<Instruction*,Instruction*>>. Storage now only stores def -> user. ForEachUser and ForEachUse replace GetUses. ForEachUse extends ForEachUser by scanning operands.
A side effect of the change is that definitions must be registered with the DefUseManager before analyzing or iterating over the uses.
Note: I still need to analyze the windows run time impact of this change (the original impetus for this issue). I will not finalize this review unless the speed up is significant.

FYI, on the linux build before your change (https://travis-ci.org/KhronosGroup/SPIRV-Tools/jobs/305003853):
82/82 Test #19: spirv-tools-test_link_global_values_amount ...........   Passed   15.11 sec
With your change (https://travis-ci.org/KhronosGroup/SPIRV-Tools/jobs/305055686):
33/82 Test #19: spirv-tools-test_link_global_values_amount ...........   Passed    0.94 sec

@alan-baker and I looked into the Windows debug build hang.  The debug version of the set insertion checks that the less functor has weak ordering. It did not, and the machine raised a Dr. Watson window and hung.

Windows debug build passed and the whole offending test suite took 10sec. I think this review is ready for more eyes. PTAL.

On Thu, Nov 23, 2017 at 10:22 AM, alan-baker<EMAIL_ADDRESS>wrote:

// Ensure that |def| has been registered.
assert(def && def == GetDef(def->result_id()) && "Definition is not registered.");
auto end = id_to_users_.end();
for (auto iter = UsersBegin(def); UsersNotEnd(iter, end, def); ++iter) {

I'm confused. Where do you think the line break is missing?

Never mind.  I completely misread that line.

Hi @alan-baker please rebase.  It's not a particularly pleasant to merge manually.

And I just pushed #999 into master, so that's another reason to rebase.

Rebased and pushed with those small comment fixes.

Rebased, squashed, and pushed into master as 746bfd210a


Add remaining default hci commands

@ConnorRigby I found that I've forgotten to update the list of modules here so some things, like deserializing return parameters currently doesn't work. I'll get it added tomorrow.


Resize window bug in viewport mode with compatibility renderer

Tested versions
Reproducible in Godot v4.3.stable (77dcf97d8)
No problems at Godot v3.5.stable
System information
Godot v4.3.stable (77dcf97d8) - Windows 11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4060 (NVIDIA; <IP_ADDRESS>03) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads) - The system uses 2 monitors
Issue description
At certain project settings, window resizing breaks and the screen goes black.
Steps to reproduce

Set the renderer to Compatibility
Then in Projects Settings -> Display -> Window:
Stretch -> Mode set to Viewport,
Size -> Mode set to Windowed,
Size -> Resizable set to True.
Next, start the project and try to resize the window.

The application screen will become black.
I also recorded a video demonstration:
https://youtu.be/Nw5Qs0URLH4
Minimal reproduction project (MRP)
Viewport Resize Bug.zip

I can't reproduce this issue, maybe nvidia specific.
Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon RX 580 2048SP (Advanced Micro Devices, Inc.; 31.0.21921.1000) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)


Update version: Daum.PotPlayer version 240618

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?
- Resolves #162509

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


Add invocation ID to root level “invoke” operation span

Motivation and Context

Description

Testing

Checklist

[ ] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
[ ] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Originally, this PR was going to address the following functional requirements:

For AWS SDKs, the invocation ID for amz-sdk-invocation-id (PR) should be the same as the one appearing in a debug trace.
Customers should be able to configure an invocation ID generator

custom IDs should appear in a debug trace
For AWS SDKs, those custom IDs should also be set to amz-sdk-invocation-id

Customers who already use InvocationIdInterceptor in AWS SDKs should not be broken by this PR

Hence, we see deprecated code in changes but as pointed out here (which I was also going to mention as a disclaimer). Turns out, however, we do not need to correlate invocation IDs in the log with those in the retry header (at least we don't have that functional requirement at this time).
Closing this PR in favor of
The alternative is that the invocation ID used in the retry header doesn't match the client side logging "invoke ID". Which, all things considered, probably isn't that big of deal.


promise?

Is there anyway to use a promise with request()?
I found this, but maybe there is something better.
https://coderwall.com/p/9cifuw

Hi, hi have use bluebird in my project with request.
I try to retrive a zip file with request, but even after .spread() the file is not complet.
I do something like
request.getAsyn(url)
  .spread(function(res, body) {
    return fs.writeFileAsync(filename, body);
  })
  .then(function(file) {
    // Unzip functions
  });

But it's not working, the file is not complete, even trying to unzip it manually.

@Yimiprod did you try the same code without promises and just plain Request + callback? Maybe you need better options for the request itself.


Incorrect parsing of the pharmacogenetics schema

Describe the bug
The schema showed in the Downloads section for the Pharmacogenetics dataset does not conform to the data.
Observed behaviour

There is also a repetition of the downloadable formats.
Expected behaviour
The actual schema of that dataset is:
root
 |-- datasourceId: string (nullable = true)
 |-- datasourceVersion: string (nullable = true)
 |-- datatypeId: string (nullable = true)
 |-- directionality: string (nullable = true)
 |-- evidenceLevel: string (nullable = true)
 |-- genotype: string (nullable = true)
 |-- genotypeAnnotationText: string (nullable = true)
 |-- genotypeId: string (nullable = true)
 |-- haplotypeFromSourceId: string (nullable = true)
 |-- haplotypeId: string (nullable = true)
 |-- literature: array (nullable = true)
 |    |-- element: string (containsNull = true)
 |-- pgxCategory: string (nullable = true)
 |-- phenotypeFromSourceId: string (nullable = true)
 |-- phenotypeText: string (nullable = true)
 |-- studyId: string (nullable = true)
 |-- targetFromSourceId: string (nullable = true)
 |-- variantFunctionalConsequenceId: string (nullable = true)
 |-- variantRsId: string (nullable = true)
 |-- isDirectTarget: boolean (nullable = true)
 |-- drugs: array (nullable = true)
 |    |-- element: struct (containsNull = true)
 |    |    |-- drugFromSource: string (nullable = true)
 |    |    |-- drugId: string (nullable = true)

To Reproduce
Steps to reproduce the behaviour:

Go to https://platform.opentargets.org/downloads
Search the Pharmacogenetics dataset
See error

The repetition seems to be related to some state in the web not clearing properly on pagination. If you go back and forth the formats available keep growing.

I thunk we observed this behaviour in the past as well, @chinmehta may remember

@javfg and @remo87 I have created a separate issue for the repeated chips behaviour as this is a repeating issue and happens with most of the release. Would be great to resolve it once and for all - #3420

In the latest release the format should be ok. I just checked and it was fine. But we do have another issue and that's the generation of the downloads.json file which is why the pharmacogenomics chips are not showing.

You should now see the update version in dev

I can see it now!

Closing as this issue has been resolved in dev


[Revise subclass] Parkinson disease 13, autosomal dominant, susceptibility to (MONDO:0012466)

Mondo term (ID and Label)
Parkinson disease 13, autosomal dominant, susceptibility to (MONDO:0012466)
Any young-onset Parkinson disease in which the cause of the disease is a mutation in the HTRA2 gene.
Suggested revision and reasons
add
young-onset Parkinson disease (MONDO:0017279)
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Dear @ValWood,
Thank you for reaching out to the Mondo Disease Ontology, part of the Monarch Initiative!
We have received your ticket and will review it as soon as possible.
If you have any additional information or updates relevant to your inquiry, please add them in a comment on this ticket. Your input is valuable in helping us understand and resolve the issue effectively.
Thank you for your patience and for your contributions to Mondo!
Sincerely,
The Mondo Team

Yes, based on the definition...


Add regex matching rules for large groups of uniform line icons

I think it would be a big time-saver to allow regex rules for matching a lot of lines to the same design icon.
For example, i've managed to break almost 300 Bus and Ferry lines that share a number space down into 6 rules:
echtnurich/line-colors - [proposal-regex] /line-colors.csv
I've used regex101.com to validate these.
It also helps with understanding the use of named matching groups to extract the line (or operator) from the hafasLineId.
I'm not sure what syntax would be optimal to actually implement, so for now I'm going to leave it at the proposal for further discussion.
Examples
Primary Metrobuses
^5\-hvv(?'operator'hha|vhh)\-(?'line'\d)$

5-hvvvhh-1
5-hvvhha-7

Secondary Metrobusses
^5\-hvv(?'operator'hha|vhh)\-(?'line'[1-2]\d)$

5-hvvhha-17
5-hvvvhh-21

Citybuses
^5\-hvv(?'operator'hha|vhh)\-(?'line'[0-5,7-9]\d\d)$

5-hvvhha-261
5-hvvvhh-286

Nightbuses
^5\-hvv(?'operator'hha|vhh)\-(?'line'[6]\d\d)$

5-hvvvhh-601
5-hvvhha-607

Expressbuses
^5\-hvv(?'operator'hha|vhh)\-x(?'line'\d{1,2})$

5-hvvvhh-x3
5-hvvhha-x35

Ferries
^6\-hvv(?'operator'had)\-(?'line'[6-7]\d)$

6-hvvhad-62
6-hvvhad-73

especially for hamburg, this would be a nice addition.
hamburg buses usually don't use different line colours, except for some maps online.
a wildcard for hvv routes would be kinda nice, but that might need some discussion imo.
MetroBus/city buses/regional buses

red on bus stops
hexagon

night bus

black on bus stops and, afaik, maps
hexagon

express buses ("XpressBus")

green on bus stops
hexagon

ferries

blue everywhere
trapezoid


Enable AVX512 kernels when compiling with nvc (NVIDIA HPC C compiler)

I have a preliminary patch to a bunch of the SKYLAKEX (AVX512) kernels that enables them to be compiled with nvc, the NVIDIA HPC C compiler.  Without this patch, OpenBLAS runs about 2x as slow on AVX512 systems when compiled with nvc versus gcc or clang.
Unfortunately, I do not know offhand the exact release of nvc in which the AVX512 intrinsics were enabled, so if you want to further refine this patch to guard a specific nvc version or later, I'll have to do some more investigation.  This support has been in our compilers for a while, at least a year or two.
I can follow up with further info if needed.
nvc.patch

Thanks. Based on an older OpenMPI ticket I found, ths might be from release 22.2 onwards - unfortunately the official release notes are too brief to allow me to verify this easily

22.3 it is, 22.2 still stumbled. Will apply the updated patch later today.

Terrific!  Thank you!
FYI - I have found bugs in our current release when compiling the CASUM and ZASUM kernels for SKYLAKEX.  I have an open bug report on this internally.  As soon as I can root cause the issue, I will try to get our developers to fix it for the next release.  These will show up as wrong answers in the test suite when run on a system that supports AVX512.

Oops - are they related to  the microkernels that your patch enables  (as an aside, I notice the casum one is not modified by it) ? And can they be worked around by reducing the optimization level with a suitable pragma ? Certainly do not want to produce wrong answers here, whether in the testsuite or in user code...

Here is the symptom:
Test of subprogram number  7         CBLAS_DZASUM
FAIL
CASE  N INCX INCY MODE  I                             COMP(I)                             TRUE(I)  DIFFERENCE     SIZE(I)
7  1    1 9999 9999  1                      0.00000000D+00                      0.70000000D+00 -0.7000D+00  0.7000D+00
7  2    1 9999 9999  1                      0.00000000D+00                      0.10000000D+01 -0.1000D+01  0.1000D+01
7  3    1 9999 9999  1                      0.00000000D+00                      0.13000000D+01 -0.1300D+01  0.1300D+01
7  4    1 9999 9999  1                      0.00000000D+00                      0.17000000D+01 -0.1700D+01  0.1700D+01

Just tried lowering the opt level to -O1 for these two kernels - did not help.
I'll dive in and see what's going on here.

Building everything with -O0 appeared to work around the problem in my tests, however adding #pragma opt 0
to casum.c and zasum.c instead did not. (As an aside, the online docs for 23.5 only ever mention that some actions of the compiler can be influenced by pragmas, but do not specify which pragmas are recognized. I finally found the "#pragma opt 0" suggested in a forum reply (where it was not entirely clear if it worked as intended).
Of course there is also the possibility that it may be test cases that are miscompiled rather than the kernels (or I may have overlooked the failure messages in the global O0 build)

@martin-frbg - thanks for the feedback on the docs, I'll pass that along to our docs person.
I've traced the problem to our optimizer miscompiling the casum_microk_skylake-2.c and zasum_microk_skylake-2.c files.  We are not loading the correct values into the XMM registers in the case where n = 2.  (And probably the others, but that is the case I'm focused on at the moment.)
I'm writing up my findings in my internal bug report on this issue.  I'm hoping we can get this fixed for the 23.9 release, which is due out in September.  But I'll let you know once I confirm that.

Hmm, I'm currently playing with this again, and just disabling the casum microkernel did not appear to fix the problem for me. I'll see if I forgot to revert some of the previous changes..

So the issue appears to be that nvc actually defines GNUC so that the compiler version guards were already allowing the microkernels to be built even without the proposed patch. What is needed for now is just the opposite - disabling (at least) the casum and zasum microkernels when the compiler also identifies itself as __NVCOMPILER

Oh interesting.  Wondering if we recently removed this in our development branch?  I'll have to do some further investigation.
Sorry for the trouble.

So I think I understand what's going on here now.
nvc defines __GNUC__ to be the equivalent of the underlying GCC version found on the system.
I have a simple program that dumps out the definition of __GNUC__ when it was compiled:
``
#include <stdio.h>
int main(void)
{
printf("GNUC = %d\n", GNUC);
return 0;
}
``
On an Ubuntu 18.04 system, gcc-7.4.0 is the system default.  So this program dumps GNUC == 7 when compiled with nvc:
cparrott@dev-sky5 ~ $ ./gnuc  __GNUC__ = 7 cparrott@dev-sky5 ~ $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper OFFLOAD_TARGET_NAMES=nvptx-none OFFLOAD_TARGET_DEFAULT=1 Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.4.0-1ubuntu1~18.04' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04)
However, our build system is CentOS 7, for maximum backward-compatibility.  gcc-4.8.5 is the system default GCC on this distribution:
cparrott@hsw7 ~ $ ./gnuc __GNUC__ = 4 cparrott@hsw7 ~ $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper Target: x86_64-redhat-linux Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux Thread model: posix gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC)
However, even if I bring a newer GCC into the $PATH, nvc still refers to the system default version:
cparrott@hsw7 ~ $ module load gcc/13.1.0 cparrott@hsw7 ~ $ nvc -o gnuc gnuc.c cparrott@hsw7 ~ $ ./gnuc __GNUC__ = 4 cparrott@hsw7 ~ $ gcc -v Reading specs from /home/sw/thirdparty/gcc/gcc-13.1.0/Linux_x86_64/lib/gcc/x86_64-pc-linux-gnu/13.1.0/specs COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/home/sw/thirdparty/gcc/gcc-13.1.0/Linux_x86_64/libexec/gcc/x86_64-pc-linux-gnu/13.1.0/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: ../gcc-13.1.0/configure --prefix=/home/sw/thirdparty/gcc/gcc-13.1.0/Linux_x86_64 --enable-languages=c,c++,fortran,lto,objc,obj-c++,d,ada,go,m2 --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --disable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --disable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu Thread model: posix Supported LTO compression algorithms: zlib gcc version 13.1.0 (GCC)
This explains why the kernels were not enabled on our build system.
So I'm thinking testing on GNUC for version number may not be particularly useful for nvc here.  Thoughts?

Sorry for the bad formatting above - can't figure out how to make github make it look right here.

You can also use nvc -dM -E with some random C source file like OpenBLAS' ctest.c to see which macros it defines. Indeed checking __GNUC__ only seems to make sense when one can be sure that the compiler actually is gcc, or at least tries to be bug-compatible with the version it masquerades as. The current ifdefs may be a bit too naive in this regard, but they date from the early days of AVX512 support where the important question was if the compiler would cope with these new instructions at all.
(use backticks to achieve somewhat sane formatting, or three backticks in a row for a block of verbatim text)

Thanks - edited the above comment to make it more readable.

Will have to check if e.g. the Intel compiler defines __GNUC__ as well (wouldn't surprise me now if it did...) and try to come up with a new ifdef that does not take ten lines to cater to every compiler under the sun...

so current Intel defines __GNUC__  as well but sets it to 4, meaning they rather than you would need extra help to access the more performant code.... what a mess :(

Interestingly, a similar miscompilation of the casum/zasum microkernels appears to be present in the current release candidate of LLVM17 as well.

It seems NVHPC 23.09 still has this issue, the lapack testcase has a huge number of failures unless I replace 2309 by e.g. 2311 or some other higher number.

Hmm that's bad. 23.11 just came out, I'll test ASAP

I just tested 23.11 and it still has the exact same issue.
 Test of subprogram number  7         CBLAS_DZASUM
                                       FAIL

 CASE  N INCX INCY MODE  I                             COMP(I)                             TRUE(I)  DIFFERENCE     SIZE(I)

    7  1    1 9999 9999  1                      0.00000000D+00                      0.70000000D+00 -0.7000D+00  0.7000D+00
    7  2    1 9999 9999  1                      0.00000000D+00                      0.10000000D+01 -0.1000D+01  0.1000D+01
    7  3    1 9999 9999  1                      0.00000000D+00                      0.13000000D+01 -0.1300D+01  0.1300D+01
    7  4    1 9999 9999  1                      0.00000000D+00                      0.17000000D+01 -0.1700D+01  0.1700D+01

Me too but dinnertime so not allowed too push a PR right away :)

In the end I think the compiler (and icx as well, also LLVM-based) simply optimized out the code since it was dodgy:
https://github.com/OpenMathLib/OpenBLAS/pull/4330


[$500] Welcome message - Hmm its not here not displayed for wrong link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.13-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open the app
Open #announce of workspace of which you are admin
Click on header and open settings - >welcome message
Copy the link and paste in the report
Modify the link and send eg: Add 's' in the end
Click on modified link and observe that nothing happens

Expected Result:
App should display 'hmm its not here' page for wrong welcome message link click
Actual Result:
App does nothing on wrong welcome message link click
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/d2a806ad-2ce6-4b4e-941d-e254a8d5e594
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fb5caa50cbb1c6aa
Upwork Job ID:<PHONE_NUMBER>588982784
Last Price Increase: 2023-12-18

Proposal
Please re-state the problem that we are trying to solve in this issue.
Welcome message - Hmm its not here not displayed for wrong link
What is the root cause of that problem?
When we copy and paste using the composer component, the links are preformatted in HTML keeping the same href.
What changes do you think we should make in order to solve the problem?
We should modify the link when pasting/typing to change the href (URL) to be the same as the user type when modifying a current link

Proposal
Please re-state the problem that we are trying to solve in this issue.
Welcome message - Hmm its not here not displayed for wrong link
What is the root cause of that problem?
We are not validating the URL route for the second parameter when we are building our routes for 'r' parameter in https://github.com/Expensify/App/blob/main/src/ROUTES.ts. e.g:
https://github.com/Expensify/App/blob/11d78212e7575261ad53c34ab41cc40b39a4c52a/src/ROUTES.ts#L155
What changes do you think we should make in order to solve the problem?
We should validate if the reportActionID exists to return our custom 404 error.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Welcome message - Hmm its not here not displayed for wrong link
What is the root cause of that problem?
Because we don't handle 404 page.
What changes do you think we should make in order to solve the problem?

we can validate link and go to 404 page
we need to 404 route

RANDOM_URL: {
        route: 'r/:reportID/:any',
        getRoute: (reportID: string, any: string) => ` r/${reportID}/${any}` as const,
}

and create 404 right modal.
In this case we need to several routes.
What alternative solutions did you explore? (Optional)

Proposal
from: @unicorndev-727
Please re-state the problem that we are trying to solve in this issue.
For the optimistic account, the ReportWelcomeText shows the email as text, not a link.
What is the root cause of that problem?
The root cause is that r/:reportId/welcomeMessages is converted to r/:reportID?/:reportActionID? and the Report page will be displayed.

What changes do you think we should make in order to solve the problem?
If the format of route is r/:reportID?/:reportActionID? and  is not isModalNavigator, we should check if reportActionId is valid.
If not valid, should return 404 error page here.
https://github.com/Expensify/App/blob/7515847fbc32af4d67fa1e787f82bc43b106fa81/src/libs/Navigation/linkTo.ts#L108
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Welcome message - Hmm its not here not displayed for wrong link
What is the root cause of that problem?
The main cause is reportActionID in REPORT_WITH_ID t route . How I see reportActionID is not used in getRoute and the question arises: why is it added there?
When we navigate to link like following r/5104260884112886/ANYTHING the text after last /  will  be our reportActionID and so that we have such route the 404 screen will not be shown .
What changes do you think we should make in order to solve the problem?
I do nor know why we use reportActionID in REPORT_WITH_ID but we can remove or if we know that the valid reportActionID can be only numeric text we can validate that the txt after last / will numeric
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Welcome message - Hmm its not here not displayed for wrong link
What is the root cause of that problem?
The presence of an unnecessary segment /:reportActionID? in the ROUTES.ts config:
REPORT_WITH_ID: {
	route: 'r/:reportID?/:reportActionID?',
	getRoute: (reportID: string) => `r/${reportID}` as const,
},

What changes do you think we should make in order to solve the problem?
Remove /:reportActionID? :
REPORT_WITH_ID: {
	route: 'r/:reportID?',
	getRoute: (reportID: string) => `r/${reportID}` as const,
},

What alternative solutions did you explore? (Optional)
N/A

@samilabud's proposal looks good
🎀👀🎀 C+ reviewed

@hayata-suenaga This might be related to comment linking project.

@roryabraham @perunt as you have worked on comment linking

I don't think this necessarily has to HOLD for comment linking. I agree with @shubham1206agra's recommended proposal.

What happens if numeric but doesn't exist? i.e. r/:reportId/1234567890

In this case, the deep link does reach the correct route: 'r/:reportID?/:reportActionID', but this is not handling any error/404 page for this when reportId is not found, I imagine this would be another bug or feature to develop if not please let me know.

What happens if numeric but doesn't exist? i.e. r/:reportId/1234567890

That will be handled in comment linking project

@hayata-suenaga Waiting for your assignment here

@shubham1206agra @roryabraham I'm so sorry. But I have a complaint. @samilabud's suggestion is updated after my proposal, and the proposed solution is the same as what I proposed earlier. I think it is  against below point in contibution.md

@shubham1206agra @roryabraham I'm so sorry. But I have a complaint. @samilabud's proposal was updated after my proposal, and the proposed solution is the same as what I proposed earlier. if you check any version of his proposal before last update , there is not anything about validating the reportActionID to be numeric. I have doubts that his proposal has been updated based on my proposal. I think this contradicts the point below in contribution.md.

Sorry @shahinyan11 from my first proposal I said we should validate the reportActionID, then I made the change to confirm my proposal and made the update using the code I made to fix this and uploading videos related. From what I see your proposal vs mine only has that overlap the rest has a different approach.

from my first proposal I said we should validate the reportActionID

@samilabud You said we should validate if the reportActionID exists . Your approach was about validation of existence.
Anyway, I don't want us to discuss this with each other. I wrote a complaint, let the reviewers decide whether I’m right or wrong

Yes of course, JTLYN I have never seen your proposal, if you see the time in which I edit mine vs yours the time is so similar that I can not write all that code based on a keyword in your proposal:

from my first proposal I said we should validate the reportActionID

@samilabud You said we should validate if the reportActionID exists . Your approach was about validation of existence.
Anyway, I don't want us to discuss this with each other.
But I am gonna side with @samilabud in this case. As @shahinyan11, your RCA was right, but your solution is little vague, and I was unable to judge what you are saying, and in what direction you are going with your solution.

 You should compare your last update with mine where there is a 3 hour difference

This is not a valid argument in this case.
But I am gonna side with @samilabud in this case. As @shahinyan11, your RCA was right, but your solution is little vague, and I was unable to judge what you are saying, and in what direction you are going with your solution.

@shubham1206agra If you think it's fair then decide so

Hey guys! Whatever decision you will make, please don't delete the reportActionID from the route path. This stuff will be used in the Comment Linking.

Hey guys! Whatever decision you will make, please don't delete the reportActionID from the route path. This stuff will be used in the Comment Linking.

We are not deleting the reportActionID. We are just going to validate this

This is not a valid argument in this case.
But I am gonna side with @samilabud in this case. As @shahinyan11, your RCA was right, but your solution is little vague, and I was unable to judge what you are saying, and in what direction you are going with your solution.

@shubham1206agra You can check the difference between the latest and all previous versions of proposals from @samilabud. And then If you think it's fair then decide so

Sorry. But I still feel we should go with @samilabud's proposal

Looks like @hayata-suenaga is OOO until 2024-01-08, so I'll jump in and take over as the Expensify engineer here.

@shubham1206agra can you please complete the above checklist then accept the job offer? Thanks!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/24411
[x]  [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24411#issuecomment-1889046394
[x]  [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[x]  [@shubham1206agra] Determine if we should create a regression test for this bug. No as this is a new feature (comment linking project) being worked on.
[x]  [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:


Release version 0.8.2

I believe #280 is a pretty bad bug and warrants a new release.
The following still needs to be done:

@david-sawatzke:

[x] Review/merge #280
[x] Review/approve this pull request

@hannobraun:

[x] Rebase this pull request after #280 has been merged
[x] Update date in changelog, if required
[x] Publish on crates.io
[x] Merge this pull request
[x] Create and push release tag

All done!