BUG (Android): onNotificationOpen doesn't fire when app is open and in foreground.

UPDATE: This appears to be a bug in Android only, I finally tested things on my iOS devices and everything works as expected.  When iOS app is open and a push notification message arrives, the onNotificationOpen fires and I am able to process the payload and create a custom message/popup to the user.  This simply does not work in Android - onNotificationOpen never fires.
In the documentation for function onNotificationOpen, the author states:

App is in foreground:
User receives the notification data in the JavaScript callback without any notification on the device itself (this is the normal behaviour of push notifications, it is up to you, the developer, to notify the user)

But best I can tell, when the app is opened and a push is received, onNotificationOpen never fires, so the callback never fires.
  window.FirebasePlugin.onNotificationOpen(function(payload) {
    console.log(payload) ;
  }, function(error) {
      console.error(error);
  }) ;

If app is closed, notification arrives, user clicks on notification, app opens and fires onNotificationOpen - if a payload exists, it gets processed as payload.ObjectKey  - WORKS
If app is open but in the background, the same behavior as #1. - WORKS
But if app is open and in the foreground, the notification never shows in the status bar (apparently native behavior), but what function fires?  It is not onNotificationOpen - DOES NOT WORK.  console.log never fires (not even the error one), thus onNotificationOpen is not firing - this is contrary to author's documentation.

So either its a bug OR the author somehow is referring to another JS callback in his documentation.

i think this is what you need: https://stackoverflow.com/questions/43928185/how-to-read-firebase-push-notification-content-and-fire-a-method-in-ionic2/43950976#43950976
tap which is part of the payload, will indicate if the app was in background/foreground mode when received

I went through that stackoverflow, the first answer references using cordova-plugin-firebase and a repo that uses it.  I combed over the repo and the only thing I found related to tap is this:
		this.firebase.onNotificationOpen().subscribe(
			(notification: NotificationModel) => {

				!notification.tap
					? console.log('The user was using the app when the notification arrived...')
					: console.log('The app was closed when the notification arrived...');

				let notificationAlert = this.alertCtrl.create({
					title: notification.title,
					message: notification.body,
					buttons: ['Ok']
				});
				notificationAlert.present();
			},
			error => {
				console.error('Error getting the notification', error);
			});

Can this be used for a JS implementation in my own code?  The tap part caught my eye...does window.FirebasePlugin.onNotificatinOpen(function(data) {  ... } evaluate tap even if app is in the foreground?  I had put simple console.log messages in it and it never fired.

the end result is that onNotificationOpen does not fire if the app is already opened...so what method does?  I can't seem to find one that does.  In the orig documentation the author says "
onNotificationOpen

Register notification callback:

window.FirebasePlugin.onNotificationOpen(function(notification) {
    console.log(notification);
}, function(error) {
    console.error(error);
});
Notification flow:

App is in foreground:
User receives the notification data in the JavaScript callback without any notification on the device itself (this is the normal behaviour of push notifications, it is up to you, the developer, to notify the user)

Yet provides no information on how to detect an incoming message if the app is already open...can't notify the user if I can't see how/where the notification is coming in.    He indicates in the JS callback...but nothing is coming in.

This probably won't be much help, but I was having the exact same problem. I just set up my Firebase account and started using this plugin and couldn't notifications when the app was open. Suddenly it just started working -- and now it works every time. I changed literally nothing. It seems like some information needed to get propagated through the system somewhere before everything would fully work.
Sorry this isn't much help, but if others are having the same problem maybe waiting an hour will help. It sounds stupid.. trust me.. I know.

so after working with this plugin last week, what is working for our project is...
for Android

make sure the google-services.json app file is in your project root
when you add the android platform, make sure the google-services.json app file is placed in ./platforms/android

for iOS

make sure the GoogleService-Info.plist app file is NOT in your project root
manually place the GoogleService-Info.plist app file in ./platforms/ios/[name-of-app]/Releases/

@captainjim1 - can you post your code on how you are processing notification is the app is open and in the foreground?  Everything else for me has been working properly except this one issue.  App open in background - works.  App closed - works.  App open and foreground - onNotificationOpen is not firing.
@jamesparkes - yup...got all that in place, and I have push notifications working in all app states except when then app is open and in the foreground.  Can you post your code on how to do this?  I have read, am being told, that onNotificationOpen should execute when a notification arrives when the app is opened and in foreground, but I am putting in debug console.log messages just to see if the function fires and it never does.
If you all have it working then obviously its not a bug, but I can't see what I am doing wrong...why won't it fire if the app is opened in foreground, but will fire if app is closed or open and in the background?

sure thing. i'll post something here later this afternoon @rolinger

My working code isn't anything different than what is outlined in the Ionic docs. Like I said before, it just suddenly started working -- all of the time. The only thing I can think of is make sure that you're code that sets up the callback is being run when your app starts. At one point I had my init() function being called from ngOnInit() which doesn't work on Providers/Services. Moving the call to the constructor fixed that for me.
My app has a service to handle the notifications... I'll try to pare it down to the stuff you'd need..
import {Injectable} from "@angular/core";
import {Firebase} from "@ionic-native/firebase";
import {Platform} from "ionic-angular";

@Injectable()
export class NotificationService {
	constructor(private platform: Platform,
				private firebase: Firebase) {
		this.init();
	}

	init() {
		if (this.platform.is("cordova")) {
			// save the token server-side and use it to push notifications to this device
			this.firebase.getToken()
				.then(token => console.log(`The token is ${token}`))
				.catch(error => console.error("Error getting token", error));

			this.firebase.onTokenRefresh()
				.subscribe((token: string) => console.log(`Got a new token ${token}`));

			// called when opening notification from the notif bar
			this.firebase.onNotificationOpen()
				.subscribe(data => {
						this.receiveNotification(data);
					},
					err => {
						console.log(err);
					}
				);
		}
	}

	receiveNotification(firebaseNotif) {
		// do somethign with your notification data here
	}

initializeFirebase() {
	if(!document.URL.startsWith('http')) {
		// initialize push notifications
		this.platform.is('android') ? this.initializeFirebaseAndroid() : this.initializeFirebaseIOS();
	} else {
		console.log('Push notifications are not enabled since this is not a real device');
	}
}

private initializeFirebaseAndroid(): void {
	this.firebase.getToken()
		.catch((e) => {
			console.error(e);
		})
		.then(token => {
			console.log(`This Android device's token is ${token}`);
		});

		this.firebase.onTokenRefresh().subscribe((token: string) => {
				// save device token
				this.subscribeToPushNotifications();
			}, e => {
				console.error(e);
			});
}

private initializeFirebaseIOS(): Promise<any> {
	return this.firebase.grantPermission()
		.catch((e) => {
			console.error(e);
		})
		.then(() => {
			this.firebase.getToken()
				.catch((e) => {
					console.error(e);
				})
				.then(token => {
					console.log(`This iOS device's token is ${token}`);
				});

			this.firebase.onTokenRefresh().subscribe((token: string) => {
					// save device token
					this.subscribeToPushNotifications();
				}, e => {
					console.error(e);
				});
		});
}

private subscribeToPushNotifications() {
	// handle incoming push notifications
	this.firebase.onNotificationOpen().subscribe((pushNotification: Notification) => {
		if (pushNotification.tap) {
			// background received
		} else {
			// foreground received
		}
	}, e => {
		console.error(e).
	});
}

@captainjim1 @jamesparkes - both of your implementations are using onNotificationOpen().subscribe()
At the moment I am simply just trying to get the basic one working while app is open.  My implementation is just for basic push notifications.  I don't have any subscription based notifications, nothing the user is or needs to specifically subscribe too.  I don't think this should be affecting my implementation though as I know my app is still getting them and processing them when the app is closed or open and in the background.

I think you're misunderstanding what's happening with the "subscribe" call.
this.firebase.onNotificationOpen() return an Rxjs observable object. In order for an observer (your app) to see the items being emitted by an Observable it must first subscribe to that Observable with this operator.
Failing to subscribe to the onNotificationOpen() observable means your app is never doing anything when a notification is opened. This has nothing to do with subscribing to more specific types of notifications.

@captainjim1, @jamesparkes  - I guess I don't understand your implementation of of subscribe() then.  According to the plugin docs (and my understanding of them), subscribe('topicA') is specifically looking for notifications for a topicA channel/thread....but if not used, then its just a standard push notification.  Or am I not understanding this correctly?  For my app, I am not using any specific topics/channels that a user would need to specifically subscribe to.  That being said, I am posting all of my code below:
Maybe you can see where I am going wrong...cause I sure as heck can't.
  /// new firebase/push load
  function writeToken(token) {
    var oldToken = getDB("dev_pushID") ;
    if (oldToken != token) {
      setDB("dev_pushID",token,1) ;  // writes the token to local DB
      // apiService sends the specific user info & token to my app server
      apiService.all("PUT",[{table:"userDevice","sid":"user_ID","sidValue":userData.user_ID}]) ;
    }
  }

  // check to see if grantPermissions have changed
  // iOS grantPermission takes place in another section of the app during 1st time app initialization
  window.FirebasePlugin.hasPermission(function(data){
    var oldPushEnabled = Number(getDB('dev_pushEnabled')) ;
    console.log("hasPermission = " +oldPushEnabled) ;
    if (data.isEnabled != oldPushEnabled) {
      setDB('dev_pushEnabled',pushIsEnabled,1) ; // set local app db value
      apiService.all("PUT",[{table:"userDevice","sid":"user_ID","sidValue":userData.user_ID}]) ;
    }
    if (data.isEnabled == oldPushEnabled) {
      console.log("Old & New Match") ;
    }
  });

  // get new token if one doesn't exist
  window.FirebasePlugin.getToken(function(token) {
    writeToken(token)
  });

  // look for new token to see if it has changed
  window.FirebasePlugin.onTokenRefresh(function(token) {
      writeToken(token) ;
  }, function(error) {
      console.error(error);
  });

  // The below function works for open in background, works if app is closed
  // but does not work if app is open and in foreground
  // IF no payload, then its a standard push notification
  //    my understanding is if app is open in foreground, the only way to process any message
  //    info is if it exists in the payload.  (regardless, this function never fires anyway).
  window.FirebasePlugin.onNotificationOpen(function(payload) {
    // console.log("Tap is: " +payload.tap) ;
    // if there is a payload it will be in payload object
    if (payload.action == 1) { // email verification confirmation
      setDB("user_emailVerify",payload.user_emailVerify) ;
    } else if (payload.action == 2) {
      alert(payload.dataTitle+ "\n" +payload.dataMsg) ;
    }
  }, function(error) {
      console.error(error);
  }) ;

  // The above prints out the console.log message when :
  //     1. app is closed, msg arrives, user taps msg and opens app
  //     2. app is open in back ground, msg arrives, user taps msg and opens app
  //But the above console.log msg never prints out when msg arrives while app is open in foreground.
  //This tells me that onNotificationOpen() never fires when app is open in foreground

There are TWO different subscribe functions at play here. The window.FirebasePlugin.subscribe function is not needed to receive generic notifications like you wish. That function is different than this.firebase.onNotificationOpen().subscribe().
this.firebase.onNotificationOpen() returns an Rxjs Observable object. The .subscribe() call you need is a method that belongs to the Observable class. Observables are something that is totally independant from this plugin. Google "rxjs observable" and you'll see there's a lot out there about them. They are similar to Promises, but more powerful.
Remember, different object types can have methods with the same name, that do totally different things.
Another way to think about this would be if we wrote code like this.
const myNotificationHandler = this.firebase.onNotificationOpen();
... this creates myNotificationHandler as an Observable type.
myNotificationHandler.subscribe( incomingNotification=> {
    // do something with a notification
});

.... this makes your app start listening for notifications -- you're subscribing to the observable and arrow the function inside the subscribe method is what you do when you get a notification. Again, this is totally separate from the subscribe() method that exists in the FirebasePlugin object.
Your best bet would be to try our sample code and see if it works for you.  The implementation we've provided is simple enough to work into your code (or test it independently). In the end you'll probably save time by simply trying our code out and seeing if it works for you.

@captainjim1 - thanks for the explanation.  I am going to be reading up on Rxjs Observable objects today and trying to implement the code the way you two have done it.  I guess the thing that throws me, that makes me believe there is an Android bug, is that the above code I posted ALL works on iPhone; this includes properly receiving and processing notifications while the app is open and in foreground.
So why does it work on iPhone and not Android for open/foreground notifications?  why would I have to modify my code for google's Android when in fact the whole plugin is based on google firebase?
This is/has been quite frustrating.  ugh!

The fact that it's working for me and @jamesparkes on Android should tell you it's not an Android bug. I don't see it, but you probably have a small quirk somewhere in your code that is letting it work on iOS when it shouldn't. If anything, there might be a bug in the iOS version of the plugin that's allowing you to get away with not subscribing to the onNotificationReceived() Observable.
I hope it works out - report back!

heh...interesting....a bug that allows something to work.  That one def never occurred to me.  Should be testing things today, will post back later.

@captainjim1 @jamesparkes - well...no luck.  I have tried 10 more methods and still can't get notifications when the app is open/foreground.  I went through Ionic directions and read in quite a few other places - nothing is working.  I have gotten so far off track that I just want to get this back to the basic Javascript plugin.
Does ANYONE have it working in native javascript?  As the author writes:
onNotificationOpen
Register notification callback:
window.FirebasePlugin.onNotificationOpen(function(notification) {
   // open/foreground - message arrives, no status bar icon, console.log should fire, but does not.
    console.log(notification);
   // closed/background - message arrives, status bar icon appears, console.log does fire
}, function(error) {
    console.error(error);
});

Notification flow:

App is in foreground: (this one doesn't work)
- User receives the notification data in the JavaScript callback without any notification on the device itself (this is the normal behaviour of push notifications, it is up to you, the developer, to notify the user) - (at a minimum the console.log should fire)
App is in background:  (the below all works)
- User receives the notification message in its device notification bar
- User taps the notification and the app opens
- User receives the notification data in the JavaScript callback

@captainjim1 - ok...way back on Aug 8th or so (22 days ago) you mention that it all suddenly just started working for you.  Well, I got so frustrated with this plugin that I decided to just forgo trying to get Notifications while app is open and in foreground.  I couldn't delay my next app release any longer, so I compiled my app to submit to Android Play Store and then forked my project into a new development version.
During compiling of the new development version I had a FirebaseCrash.class warning that I hadn't seen before...but the compile didn't fail.  I launched the new development version to my Android phone and decided to test Firebase components to see if that warning was going to cause any problems....I closed the app and sent a Firebase Notification - worked as expected.  Then I opened the app and sent another notification to test if the app would crash when a notification arrived (as I had seen that before)....not only did it not crash, but also my console.log/alert messages all fired (that ONE thing I couldn't get it to do these last 30 days!!!!!!!!!!).
I did nothing...I didn't change or edit any code...I simply just forked the project and recompiled the new development version - and waaaalaaaaa - Notifications were getting received while the app was open and in the foreground.   Are you f'n kidding me!!!!!  30 days trying to get the damn open/foreground thing to work and simply forking the project got it to work.   GGGGrrrrrrrr!
Now I am going to submit this new development version to the app stores (cause I know this one now works)...and then fork it again to continue developing.  Unreal!

Hello @rolinger :)
I have some issue with onNotificationOpen but the diferent is iam sending the notification from firebase console with a parameters, I use that parameter to navégate in the app when the notification is open for some reason when the app is open and I send a notification the onNotificationOpen fires Well, when the app is close th notification arrived when I tab to open the notification the onNotificationOpen is not fire.

Hello
I have partialy the same issue.
when the app is closed, I receive the notification.
But when the app open the onNotificationOpen event don't fire

On iOS everything is OK ( foreground and background)
On Android it's OK  only when the App is closed. And when I tape on the notification it's launch the app.
But when the App is open, I don't receive the notification.
Is there any available solution ?
thank you

Hi!
Any updates?
Android notifications(foreground mode) doesn't work for me also.
Background mode - everything is OK.
iOS - also is works good for both mode.

Hi,
Unfortunately no update.
it's seem to be normal on Android.  the concept of notification is not the
same as iOS.
There two kind of message event.
Now I use   well cordova-plugin-frm   for  iOS and Android.
This plugin strap all event  forground and background.
Regards
2018-06-29 9:30 GMT+02:00 Fikret Kurtiev<EMAIL_ADDRESS>
Hi!
Any updates?
Android notifications(foreground mode) doesn't work for me also.
Background mode - everything is OK.
iOS - also is works good for both mode.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/arnesson/cordova-plugin-firebase/issues/371#issuecomment-401272715,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhQFU5eIRyISrYhQeJNfDD1grcWTxANAks5uBdebgaJpZM4Osf2U
.

the same issue. any solution yet?

hi, still I am facing this issue in ionic 4. when app in foreground state Onnotification() does not trigger. could you please any one give me solutions...

Hy
I don't find solution.
Finaly to be compatible with iOS  and Android  I use an other  plugin :
cordova-plugin-fcm
Best regards
David
Le lun. 17 févr. 2020 à 11:02, sachinbp589<EMAIL_ADDRESS>a
écrit :

hi, still I am facing this issue in ionic 4. when app in foreground state
Onnotification() does not trigger. could you please any one give me
solutions...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/arnesson/cordova-plugin-firebase/issues/371?email_source=notifications&email_token=AIKAKU54YNEJURXXEFARNTLRDJOEXA5CNFSM4DVR7WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL5ZBGY#issuecomment-586911899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKAKU4WVVHBHYZVCPT3T3LRDJOEXANCNFSM4DVR7WKA
.

hi, I am also using cordova-plugin-fcm, but its not working .
-> ionic cordova plugin add cordova-plugin-fcm-with-dependecy-updated
-> npm install @ionic-native/fcm
could you please give me which plugin are you using.

Hi, Also please refere below link-
https://stackoverflow.com/questions/60225787/firebase-onnotification-is-not-working-when-the-notification-is-received-in-an

I use old version
cordova-support-google-services  1.2.0
cordova-plugin-fcm  2.1.2
I don"t use ionic framework  but full javascript project
SAILLARD David
Chef de projet sénior
*Société *DANEM, Zone d'activités Europarc - 40, Rue Eugène Dupuis - 94044
Créteil cedex
*Email *<EMAIL_ADDRESS><EMAIL_ADDRESS>*Web *www.danem.com
Zone d'activités Europarc  https://goo.gl/maps/RP12D40 rue Eugène Dupuis
94000 CRETEIL https://goo.gl/maps/RP12D
Tel : 01 41 94 10 80
https://www.danem.com http://www.danem.com/
Le lun. 17 févr. 2020 à 12:11, sachinbp589<EMAIL_ADDRESS>a
écrit :

hi, I am also using cordova-plugin-fcm, but its not working .
-> ionic cordova plugin add cordova-plugin-fcm-with-dependecy-updated
-> npm install @ionic-native/fcm
could you please give me which plugin are you using.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/arnesson/cordova-plugin-firebase/issues/371?email_source=notifications&email_token=AIKAKU4NBGYOVWRJKRCCLYLRDJWHRA5CNFSM4DVR7WKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL6AW5Y#issuecomment-586943351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKAKU5WR2TCLAQWXOHBGWTRDJWHRANCNFSM4DVR7WKA
.


Milestone 1

Use bootstrap to creat header and footer sections

@Dipeshtwis @Elbie-em Thank you so much for your comments and suggestions. They helped us to clean our code and see some missing things we had.
We corrected all your suggestions:

Add links to The Newsweek logo.
Use buttons for Login and Subscribe.
Correct the size of The Newsweek logo in tablet mode.
Correct the space in desktop mode.
Fix the position of the text right to the Newsweek logo.
Change the size in the CSS to 768px, as per standard.
Add form with a search field.

Optional:

We correct font sizing and colors in the footer.


Add material symbol component

#571

I don't think this component makes a lot of sense to have. We can just use <mat-icon> directly. Instead we can create a standalone storybook file to show off <mat-icon>. @bherr2 What do you think?

I don't think this component makes a lot of sense to have. We can just use <mat-icon> directly. Instead we can create a standalone storybook file to show off <mat-icon>. @bherr2 What do you think?

Sure, and of course you can still make a storybook to demonstrate the mat-icon usage (especially for all cases we support)

Updated to show all icons!


Use full Sass instead of just some PostCSS features?

Currently standing on one foot with just a few PostCSS features (scss syntax, imports, nesting, simple variables and hashes), it might be interesting to move to true Sass.
node-sass + postcss?
Use node-sass for Sass compilation, but keep using PostCSS for hashes?
https://github.com/ianrose/deventy/blob/master/package.json#L11
Gulp?
If so, how to deal with hashes, not native in node-sass CLI? Build with gulp and add gulp-rev?
If we add gulp, why not move JS build to gulp too? 🤷♂
Rollup?
Using Rollup to build CSS seems counter intuitive, as it looks like you can't build just CSS, it has to be injected in some JS build.
But having both JS and CSS (Sass) built with the same tool might me better for DX.

Let's try with Rollup


Cross link top level I/O methods

Link the read and write methods with each other.

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   93.06%   93.06%
=======================================
  Files          27       27
  Lines        3343     3343
=======================================
  Hits         3111     3111
  Misses        232      232

Impacted Files
Coverage Δ

databricks/koalas/namespace.py
90.17% <ø> (ø)
:arrow_up:

databricks/koalas/generic.py
94.02% <ø> (ø)
:arrow_up:

databricks/koalas/frame.py
94.71% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9817994...d6bbf6c. Read the comment docs.

Yea but if we can do a better job than pandas we should do that.
On Mon, Jun 10, 2019 at 8:55 AM Hyukjin Kwon<EMAIL_ADDRESS>wrote:

@HyukjinKwon commented on this pull request.
In docs/source/reference/io.rst
https://github.com/databricks/koalas/pull/441#discussion_r291898670:

@@ -13,8 +13,8 @@ Data Generator

range

-Flat File
+Flat File / CSV
@rxin https://github.com/rxin, this title was from Pandas tho (
https://pandas.pydata.org/pandas-docs/stable/reference/io.html#flat-file)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/databricks/koalas/pull/441?email_source=notifications&email_token=AACO6PCIECUD3Q367CPGLPTPZX3H7A5CNFSM4HWHB7GKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3AB7YA#pullrequestreview-247472096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACO6PFDWOWNVHLRMWNLK5TPZX3H7ANCNFSM4HWHB7GA
.


Modernize Modelforge CI

[ ] Build and push the PyPi package on tags (working example: https://github.com/src-d/minhashcuda/blob/master/.travis.yml#L15)
[ ] Use flake8 as in sourced-ml

@smola How do we upload the autogenerated documentation for this project?

@vmarkovtsev  /docs should be for gitbook (see gitbase) as example.
For autogenerated docs, at the moment we have docsrv to generate and serve them (see engine example).

@smola What are our exact steps to serve the autogenerated Modelforge docs at sourced.tech?

As discussed with @smola docs are postponed until https://github.com/src-d/feature-idea/issues/59


Mass removal of non-unique pokemon

This will remove non-unique Pokemon under the follow circumstances:

Pokemon doesn't have the highest IV
Pokemon isn't a favourite

If you want any changes to do the IV/CP matching let me know.

@bartonp Add preview list and the confirmation

Added a confirmation after the pokemon up for mass trading have been presented


Support for env vars when using GrafanaNotificationChannel

I'm creating a GrafanaNotificationChannel with slack type, which has a sensitive Webook URL configuration.
I'm trying to figure out how to use a secret + envVar for the Webhook URL, similar to supported for datasources.
The grafana container has $SLACK_WEBHOOOK_URL exported as an environment variable, but the Webhook URL ends as a literal string (I think because it's inside spec.json).
Is there a feasible way to do this right now?
apiVersion: integreatly.org/v1alpha1
kind: GrafanaNotificationChannel
metadata:
  name: slack-notification-channel
spec:
  name: slack-notification-channel
  json: >
    {
      "uid": "slack-channel-notification",
      "name": "Slack Channel Notificaton",
      "type": "slack",
      "isDefault": false,
      "sendReminder": false,
      "disableResolveMessage": false,
      "frequency": "5m",
      "settings": {
        "addresses": "",
        "autoResolve": true,
        "httpMethod": "POST",
        "icon_emoji": ":grafana:",
        "icon_url": "",
        "mentionGroups": "",
        "mentionUsers": "",
        "recipient": "#slack-notification-channel",
        "severity": "critical",
        "token": "",
        "uploadImage": true,
        "url": "$SLACK_WEBHOOOK_URL",
        "username": "Grafana Notification"
      },
      "secureFields": {
        "url": true
      }
    }

Furthemore, I just realized that when declaring the URL explicitly,
      "url": "https://hooks.slack.com/xxxxx/xxxxx/xxxx",
       "username": "Grafana Notification"
     },
     "secureFields": {
       "url": true
     }

The GrafanaNotificationChannel is created without encryption, and the Webhook value becomes exposed on the UI.
Once opening the UI and clicking on the Save button, the value becomes encrypted.
I think that this CRD will need support for secureJsonData as well to overcome this.

Hi @eduardobaitello Thanks for raising this, currently the notificationchannel feature only supports raw json as of now (for simplicity), your suggestion definitely makes sense, This would require adding some new structs to the notificationchannel struct from under https://github.com/grafana-operator/grafana-operator/blob/master/api/integreatly/v1alpha1/grafanadatasource_types.go#L66

@eduardobaitello
Env expansion
Datasources are currently supplied to Grafana via a configuration file, that's why environment expansion works there: https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#env-provider
Notification channels are configured directly via API. Grafana doesn't seem to support expansion there. In fact, if you go to Grafana UI, pick webhook notifications and try to set a password there to something like $SLACK_WEBHOOOK_URL or ${SLACK_WEBHOOOK_URL} (assuming this env is available within the grafana container), the password will be sent to a webhook by grafana as is. You can test that yourself with a simple Go code:
package main

import (
	"fmt"
	"log"
	"net/http"
)

func authorizationHandler(w http.ResponseWriter, r *http.Request) {
	header := r.Header.Get("Authorization")
	fmt.Printf("Authorization: %v\n", header)
}

func main() {
	http.HandleFunc("/", authorizationHandler)

	if err := http.ListenAndServe(":8080", nil); err != nil {
		log.Fatal(err)
	}
}

Safe Slack webhook configuration
In Chrome-based browsers, you can open developer tools (F12). There, you could explore Grafana's requests in the Network section. It's always helpful to go there in case you're not really sure about the correct json structure. In the end, both Grafana UI and grafana-operator rely on the same set of APIs.

As you can see on the screenshot, url and token should be placed within secureSettings, not within settings. And secureFields is empty.
Here's the CR spec that you were looking for:
apiVersion: integreatly.org/v1alpha1
kind: GrafanaNotificationChannel
metadata:
  name: pager-duty-channel
  labels:
    app.kubernetes.io/instance: grafana-operator
spec:
  name: pager-duty-channel.json
  json: >
    {
      "uid": "slack-channel-notification",
      "name": "Slack Channel Notificaton",
      "type": "slack",
      "isDefault": false,
      "sendReminder": false,
      "disableResolveMessage": false,
      "frequency": "5m",
      "settings": {
        "addresses": "",
        "autoResolve": true,
        "httpMethod": "POST",
        "icon_emoji": ":grafana:",
        "icon_url": "",
        "mentionGroups": "",
        "mentionUsers": "",
        "recipient": "#slack-notification-channel",
        "severity": "critical",
        "uploadImage": true,
        "username": "Grafana Notification"
      },
      "secureSettings": {
        "token": "",
        "url": "https://hooks.slack.com/services/T00000000/B00000000/XXXXXXXXXXXXXXXXXXXXXXXX"
      }
    }

@HubertStefanski I think there's no need for any enhancements here as the operator already supports the desired configuration.

I could be wrong, but I had already tested this.
I'll try again and let you know here, thanks!

@weisdd thanks for the clarification.
I got your point, and it really makes sense.
A just tested as you suggested, and the Grafana Notification was created with the url encrypted in the Grafana database.
This is enough for what I need, so I am closing this issue. Thanks again! ❤

@weisdd thanks for the clarification.
I got your point, and it really makes sense.
A just tested as you suggested, and the Grafana Notification was created with the url encrypted in the Grafana database.
This is enough for what I need, so I am closing this issue. Thanks again! heart


Allow configuring what version is shown by default

Seeing if this will work - it won't work if you want to show master or next by default.
Only named version that would exist in versioned_docs.
If this does work and we want to go with it - latestVersion in many places seems like a
misnomer. defaultVersion would be better or something
Motivation
Seeing if this will work - it won't work if you want to show master or next by default.
Only named version that would exist in versioned_docs.
If this does work and we want to go with it - latestVersion in many places seems like a
misnomer. defaultVersion would be better or something
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tried on Jest site since Docusaurus currently only has one version.
Related PRs
N/A

Thanks!


Onboarding flow - Find a host

Who is your user?

Newly registered Collective admins wanting to find a host

What are they trying to achieve?

Start their financial activities (fundraising and paying expenses) as soon as possible and with little hassle

When I create a Collective, I want to find the right way to manage my finances, so I can not worry about paperwork
How are they currently doing this?
Browsing using the search page, receive invitations/recommendations
How well understood is this problem?
The research project is documented at #4829

[ ] Surfacing: if you feel this is a seed of an idea that needs to be researched.
[ ] Understanding: if you've done some research and feel it is already well understood and ready for shaping.
[ ] Shaping:  if you feel a solution is clearly defined and can be made into a pitch (read more about shaping)
[ ] Pitching: if you feel that it is ready to be presented for prioritisation (read more about pitching)

Tasks

[ ] Get rid of the "For open-source/any community step."
[ ] https://github.com/opencollective/opencollective/issues/5628
[ ] Implement https://github.com/opencollective/opencollective/issues/4240

Hey @Memo, here are some initial thoughts/reflections/questions to flesh out this need.
1: When ... I Want ... So I can
You stated:

When I create a Collective, I want to find the right way to manage my finances, so I can not worry about paperwork

re: When

is this when I create a collective or when I decided that I want to join a fiscal host?
do I already know what fiscal hosting is, or am I first trying to figure that out?

re: I Want

do people really want to "manage their finances"? I suspect, that, given the possibility, most people don't want to have to manage their finances at all and would prefer to have someone else do it for them.
if someone has setup a collective and looking for a fiscal host I think what they really want is to be able to receive contributions and spend money on the work they want to do ... and in order to do that they need someone else to help them with the legalities
am I looking a "right way to manage my finances" or am I looking for the right people to help me?

re: So I Can

generally, if you want to focus on a concern, maybe better to address the ease that comes from it being addressed so instead of "not worry" something like "So I can feel confident that I have the legal and financial backing to focus on the work I want to do"
specifically, I think that in this case there is a more specific outcome "So I can begin to fund raise for the collective."

2: What does the information landscape look like?

possible query:  number of hosts per location
this may help us understand what kind of challenge are we dealing with - do most locations have one or two hosts or 10-20 hosts? that will help us better understand what users may be facing and how we can help them navigate the choice

3: Comparing fiscal hosts
This may be a bit preemptive (before seeing the results of 2 above)  but assuming the user really is facing a challenge of choosing from a list of fiscal hosts then they are facing two challenges:

How do I compare hosts - what should I be looking for?
Having learned what I should be looking for, how do I narrow down the list of hosts to one or two best options.

The designs I saw in  #4829  defaulted to our familiar "cards" view which is not ideal for comparison. I would experiment with a list view where it is easier to compare hosts with metric such as:

Fee
Average payment processing time
Total money managed in the previous fiscal year
number of expenses paid during the last 30 days
sum of expenses paid during the last 30 days
who are the people who are going to help me with accounting - icons of the team (to give a sense of how many there are (is it just one or two people, or is this an established team), hover over each for a modal small profile  -  with possibility to link each of them to an extended personal profile

A list view also serves as a subtle educational tool: the columns expose to me what I can and should be looking for. This is more difficult to grasp in the "cards" view.
4: Short List
With a list mechanism it can be possible, as I am browsing the list, to select candidates to make a short list of fiscal hosts that appeal to me and then to act on those.
5: What can this look like from the side of the Fiscal Host?

Is there a possibility to also drive this process from the host side?
What if I (an admin of a collective seeking a fiscal host) could indicate "I am looking for a host" and the platform could "magically" respond to me with invitations to relevant hosts (unburdening me from "the search")?
Can we gather enough information from the collective to start with a list of "proposed hosts" instead of a blank search?
Can we let relevant hosts know about a potentially matching collective and enable them to send out an invitation to the collective?

/me leans in. there's possibly also a fair amount of context in the broader #4829 topic as this is a discrete piece of work that started from there.

just trying to clear up some of these questions @iamronen:

is this when I create a collective or when I decided that I want to join a fiscal host?

this is at the point that the user decides they want to accept money, the promo is 'who is going to hold you money' and (to your next question) their is some explanation but arguably not as much as there should be.

do people really want to "manage their finances"?

This look like it's couched predominantly as 'accepting contributions' in the design which I think is a good, practical and understandable context.

do most locations have one or two hosts or 10-20 hosts?

There's a problem here that has been discussed somewhat but perhaps not to the degree that we have an approach: it might be easy to describe where the host is based, but it is very difficult to describe (and provide the freedom to a host to describe) the areas in which they can operate.
For instance, Open Source Collective can work in any country that's not embargoed by the US but is based in CA, USA, Open Collective EU supports projects operating in the EU but is based in Brussels. Open Collective Foundation is the easy case of based in and only operating in the US. Really what we need here is a region(s) type system. This might be the technical complexity we need to enable collectives to find a host that's operating in a territory they are.

Comparing fiscal hosts
The designs I saw in https://github.com/opencollective/opencollective/issues/4829 defaulted to our familiar "cards" view which is not ideal for comparison. I would experiment with a list view.

I think that's a fair comment. It's possible to compare a small number (and honestly, there are probably a small number right now) but I think it's fair to test this against a more tabulated view. I would perhaps ask collectives what they're looking for in a host rather than guess but I can see some of the suggestions being helpful if there any many choices.

Short List

It would be great to have ea problem that requires this solution, but I don't think we're there.

Is there a possibility to also drive this process from the host side?
I think the key here is that the process we have today starts with the collective, and maybe we should solve that first.

Can we gather enough information from the collective to start with a list of "proposed hosts" instead of a blank search?

This sounds like a good option, maybe we could pre-fill some of the search criteria based on what we already know about the collective? (country and maybe denomination?).

Can we let relevant hosts know about a potentially matching collective and enable them to send out an invitation to the collective?

again this kinda feels like it's not leaning into the approach we have today. Fine, we could reconisder that, but it's a bigger project and I would (personally) prefer to lean into what we have.

By way of an update, I think @Memo-Es's original plan was to revisit the design for this and write a pitch. Having looked at this I think we should:

ensure that we continue to consider this project in the context of the larger onboarding https://github.com/opencollective/opencollective/issues/4829
look again at the plan for this project and the next steps https://github.com/opencollective/opencollective/issues/4829#issuecomment-1148103264
involve engineering in the scoping work for this and other projects in that remit.

I think the goal should be to have a program of work that we're all happy to get started on next sprint.

[ ] @Memo-Es and @BenJam take a look at future pitches

[ ] @Memo-Es and @BenJam take a look at future pitches

Clarifications from the call with @hdiniz @Memo-Es:

Featured hosts are the ones recommended based on the category + location. They may not necessarily be internal hosts.
Verified hosts = what we currently call trusted hosts in the code
The category is to be clarified with the rest of the team, but likely to be an editorial choice on our side that hosts can opt into by adding some specific tags to their profile.

Engineering will wait on the design flush to start implementation.

thank you for the signal @Betree
My understanding is different:

The entire window is filtered for category + location
The hosts in the top section are our 1st party hosts
The hosts in the second section are the trusted hosts
The hosts in the third section are the rest

attn @toomuchinformation
attn @carolineawoolard for clarifications around terminology we wish to use here.

Happy to hop on a call about this or to join a demo / workshop space to
discuss.
On Thu, Mar 9, 2023 at 4:42 PM iamronen @.***> wrote:

thank you for the signal @Betree https://github.com/Betree
My understanding is different:

The entire window is filtered for category + location
The hosts in the top section are our 1st party hosts
The hosts in the second section are the trusted hosts
The hosts in the third section are the rest

attn @toomuchinformation https://github.com/toomuchinformation
attn @carolineawoolard https://github.com/carolineawoolard for
clarifications around terminology we wish to use here.
—
Reply to this email directly, view it on GitHub
https://github.com/opencollective/opencollective/issues/5672#issuecomment-1462276698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVCHQZGIG5RLDBZP4CMRTM3W3H243ANCNFSM5ZBA7BFQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

For this week:

[ ] https://github.com/opencollective/opencollective/issues/6501
[ ] Kickoff implementation of the new page

closing as i think all the issues mentioned here are now resolved (and looks great). Thanks to everyone who worked on this ✌


Updates git ls-tree example

Following up on https://github.com/junegunn/fzf/issues/168,
this PR fixes the snippet using git ls-tree
find had an incorrect syntax.

It works as expected on OS X and Linux, what problem did you have?

After more digging, it seems to be the same issue that appeared in https://github.com/junegunn/fzf/pull/97.
My find is aliased to noglob find, which leads to the following error:
$ find * -name ".*" -prune -o -type f -print -o -type l -print
find: *: No such file or directory

I've updated the PR accordingly

Still doesn't work. I'll come back with something more solid.

@xcambar you way want to have unsetop NOMATCH in your zshrc somewhere. This results as the * getting past to find as is rather than zsh throwing an error about it not matching glob.

@george-b Works perfectly, thanks.


chore: write spec & converter for GeoJSON format

The shapefiles outputted by our R script need to be in GeoJSON format to be comprehensible as OpenStreetMap layers. We need to specify the different pieces of the GeoJSON object & write a function that converts the current output of create_index(), which is a two-column table with index value and geographic ID, to a GeoJSON that associates index values with the relevant geographical units.

I think this is addressed by #153

Addressed by a feature included in write_new_polygons #243


Fixed issue with tagging and tagging-label='false'

Reference: https://github.com/angular-ui/ui-select/issues/1214#issuecomment-291153134

Test cases not updated

Hi, I think you have added to much as I see all files in the dist dir. Could you do a clean up so that we can have a look at the PR?
Thanks.

It looks like you still have some conflicts. Could you fix them before i'm reviewing them?


ibmcloud: Use variables for source code repos

This patch remove hard-coded source code repository URLs and branch names, and introduce variables to specify them. The default values are the original hard-coded ones.
Fixes #211

@mattarnoatibm thank you for your comments! I've updated the code. could you take a look?


Custom keyboard action

I didn't find it. is it implemented method somewhere??
Here is API doc
https://core.telegram.org/bots/api/#replykeyboardmarkup

Hi
u can using this code for show keyboard:
ReplyKeyboardMarkup kb = new ReplyKeyboardMarkup();
string[][] str = new string[1][] { new string[] { "Key 1", "Key 2" } };
kb.Keyboard = str;

ForceReply fr = new ForceReply();
fr.Force = false;
kb.OneTimeKeyboard = true;
kb.ResizeKeyboard = true;
kb.Selective = false;
await Bot.SendTextMessage(update.message.chat.id, "Your Message", false, 0, kb);

and using this code for hide keyboard:
ReplyKeyboardHide kb = new ReplyKeyboardHide();
kb.HideKeyboard = true;
kb.Selective = true;

await Bot.SendTextMessage(update.message.chat.id, "Your Message", false, 0, kb);

I found answer, so i close issue. It will be great to have this documented.


chore(main): release 2.4.0

:robot: I have created a release beep boop
2.4.0 (2024-12-09)
Features

add mini.diff and mini.icons plugins support (#265) (5833616)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.4.0
:sunflower:


Compact: issue with the --wait flag

Hello,
A few days ago, my compactor printed the following logs (many times) :
error executing compaction: first pass of downsampling failed: downsampling to 5 min: downsample block 01GTGG68KVJCHM8B45D44KD1KK to window 300000: get chunk<PHONE_NUMBER>9, series 29729833: checksum mismatch expected:187392dc, actual:19f6b70c

I discovered the issue because our compactor started to consume a lot of bandwidth to download the invalid block again and again from our provider (which bills us on trafic).
The issue was fixed later that day (i.e. delete corrupted block), but today I decided to add a prometheus alert to know when this occurs.
We are using the --wait flag to make it act as a daemon, started by systemd and restarted in case the process exit/crash. The process is monitored through its /metrics using alerts.
The metric thanos_compact_downsample_failures_total looked a great candidate, as it is precisely increased when the downsampling process fails.
https://github.com/thanos-io/thanos/blob/3dea8cf3ad9fb75c470ed483b03a7bfeb5be74f1/cmd/thanos/downsample.go#L258-L262
However, when I looked back at the value of this counter (while it was failing), the value was 0 during the whole time.
And the issue was clear : when the downsampling failed, the compactor process exited immediately. It was restarted by systemd and the counter was still 0.
Finally my 'question' is : I don't really understand the --wait behavior 😁
Today the code look like this :
for {
    err := compact()
    if err == nil -> continue
    if err is halt -> halt compaction (but keep responding on /metrics)
    if err is retriable -> log error and continue
    else exit process
}

But I don't understand in which case it is desirable (if I set the wait flag) to exit the process ?
The main idea behind the --wait is not to have something like this ?
for {
    err := compact()
    if err == nil -> continue
    if err is retriable -> log error and continue
    else halt compaction (but keep responding on /metrics)
}

In any case, If there are good reasons to keep the current behavior, the metric thanos_compact_downsample_failures_total cannot be used (or did I missed something ?)
Thanks,
Thibaut
Thanos, Prometheus and Golang version used:
thanos, version 0.30.2 (branch: HEAD, revision: 487fac497a7dcc81d337f4597a035c996e4b9b4b)
  build user:       jenkins@3b4f1c484461
  build date:       20230306-13:39:03
  go version:       go1.19.3
  platform:         linux/amd64

Object Storage Provider:
SWIFT

Same behaviour, we have approx 150 clusters where each clusters has its own folder (prefix) in s3 bucket and this each folder has associated compactor. All clusters are connected to one Thanos (Datasource). From some reasons there are lot of errors in compactor instances saying that there is a checksum mismatch. Could be great to find out easily in which cluster are problems via the metric thanos_compact_downsample_failures_total.


Pass SynchronizationContext to Dbgx.DebugEngine

Hi,
I'm loving the 'Microsoft.Debugging.Platform.DbgX' package and seeing some early successes from it's use.
One frustration however is the use of the SynchronizationContext.Current static value. Would it be possible to pass the SynchronizationContext to use into the DebugEngine constructor? This would simplify it's use and facilite synchronization with other frameworks such as RX.
BTW, I'd happily submit a PR for this but Microsoft.Debugging.Platform.DbgX doesn't seem to be open-source (links from the Nuget page direct to Microsoft.Windows.SDK.Contracts).
Thanks,
Ian

Yes, I can update that. Thanks for the feedback!
The plan is to open source DbgX at some point, but I don't know when.

This is in PR now, and should make it into the next release.


Try benchit with LLaMA

My assumption is that benchit will not work with LLaMA because a bunch of manual hacks are required to get an ONNX file out of LLaMA. That being said, it's worth a try!

cc @danielholanda


url params

url params

Coverage remained the same at 95.479% when pulling e20e78ae7bf3bb1a554ddc2c300f50d9e1767e4c on lium200309:master into c4885fd811bc5c651268bfaa37ede17e22a1833a on ServiceComb:master.

Coverage remained the same at 95.479% when pulling 253019535b4b4c1a383561d3f1328bd29528b83e on lium200309:master into c4885fd811bc5c651268bfaa37ede17e22a1833a on ServiceComb:master.


Dialogic crashes exports

The problem
Describe the bug
When running an exported version of my game, dialogic crashes it with this error message:
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
          at: _process (res://addons/dialogic/Nodes/DialogNode.gdc:424)

This doesn't happen when running from the editor.
To Reproduce
Steps to reproduce the behavior:
I don't know how I did it so I can't show you how.
Expected behavior
I expect dialogue to show up when I start my game
Screenshots

System (please complete the following information):

OS: Windows 11
Godot Version: 3.4.3
Dialogic Version: 1.4.1

Solutions
I don't know
Workaround
A delay before adding dialogic as a child, this didn't work
Possible fixes
I have no idea :/

Is this an export to android by chance? Either way I believe this is a known issue, and the fix is currently in main branch. Try downloading that and see if the error persists.

Okay thanks, and no,this is a windows export

Is this an export to android by chance? Either way I believe this is a known issue, and the fix is currently in main branch. Try downloading that and see if the error persists.

Okay thanks, and no,this is a windows export

I tried that, but the problem is still there. I no get this errors:
**SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
          at: parse_alignment (res://addons/dialogic/Parser/DialogicParser.gdc:178)
SCRIPT ERROR: Invalid type in function 'parse_definitions' in base 'GDScript'. Cannot convert argument 2 from Nil to String.
          at: update_text (res://addons/dialogic/Nodes/DialogNode.gdc:1036)
SCRIPT ERROR: Invalid get index 'waiting' (on base: 'Dictionary').
          at: play_audio (res://addons/dialogic/Nodes/DialogNode.gdc:392)
**

Repro (I guess it's the same issue?) on Windows 10, Godot 3.4.2, Dialogic 1.4.1:

[D] An error occurred when trying to access the custom event folder.
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: resize_main (res://addons/dialogic/Nodes/DialogNode.gdc:210)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_children' in base 'Nil'.
at: clear_options (res://addons/dialogic/Nodes/DialogNode.gdc:1062)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: fade_in_dialog (res://addons/dialogic/Nodes/DialogNode.gdc:1386)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: update_name (res://addons/dialogic/Nodes/DialogNode.gdc:1015)

I tried exporting the game both to HTML and Windows. It crashes as soon as I try instantiate any dialog with Dialogic.

Repro (I guess it's the same issue?) on Windows 10, Godot 3.4.2, Dialogic 1.4.1:

[D] An error occurred when trying to access the custom event folder.
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: resize_main (res://addons/dialogic/Nodes/DialogNode.gdc:210)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_children' in base 'Nil'.
at: clear_options (res://addons/dialogic/Nodes/DialogNode.gdc:1062)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: fade_in_dialog (res://addons/dialogic/Nodes/DialogNode.gdc:1386)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: update_name (res://addons/dialogic/Nodes/DialogNode.gdc:1015)

I tried exporting the game both to HTML and Windows. It crashes as soon as I try instantiate any dialog with Dialogic.

Can you try using the main branch from git hub (our 1.4.2) release candidate, and see if you get the same issue?

Thanks, I just tried that! Now the game doesn't crash, but I get this error:

[D] An error occurred when trying to access the custom event folder.
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: resize_main (res://addons/dialogic/Nodes/DialogNode.gdc:214)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_children' in base 'Nil'.
at: clear_options (res://addons/dialogic/Nodes/DialogNode.gdc:1073)
SCRIPT ERROR: Invalid call. Nonexistent function 'get_value' in base 'Nil'.
at: fade_in_dialog (res://addons/dialogic/Nodes/DialogNode.gdc:1400)

The dialog spawns, but it seems that at first it's invisible - I need to press an action button, and only then it fades in, simultaneously skipping from the first line to the second one.

Can you screen shot the start of the timeline in question if you have a moment?

I tried it with two different timelines with the same result, here they are:

That's right

I have a hunch... are both those characters using the same theme? Or are you only using the default theme? Or did you edit the default theme and are using the edited theme for those characters?

Yeah, the last one. I edited the default theme. Using a completely new theme should solve it?

I'm thinking it might. We get some WEIRD issues with the default theme. Give it a try and report back if you wouldn't mind.

Still the same - I created a new theme and assigned it to both characters, but I'm getting the same error as previously and I still need to press a button to make the dialog actually appear.

More for my own notes than anything else as this isn't actionable...
It appears that the current_theme isn't being set on time. I can't currently recreate the issue, but its clearly affecting a bunch of our users.
@matiwierzba Is there any further stack trace you could share on the issue, or is that it?

Hello again! I stumbled upon a solution for this problem, maybe it will work for others as well. In Dialogic settings I had the "default theme" still set as the default theme (I know how it sounds but I think you know what I mean). None of my characters were using it, but after I changed the default theme in the settings to an entirely new theme the issues disappeared completely, both on Windows and in the web version

Hello again! I stumbled upon a solution for this problem, maybe it will work for others as well. In Dialogic settings I had the "default theme" still set as the default theme (I know how it sounds but I think you know what I mean). None of my characters were using it, but after I changed the default theme in the settings to an entirely new theme the issues disappeared completely, both on Windows and in the web version

This saved my life, thank you.

Is this closeable?

Gotta make the actual fix. Open for now will have it worked out this week.
On Sat, Jun 18, 2022, 6:46 PM Emi @.***> wrote:

Is this closeable?
—
Reply to this email directly, view it on GitHub
https://github.com/coppolaemilio/dialogic/issues/898#issuecomment-1159577338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3CCZMH3E5DOCJIXGJA7WDVPZGU3ANCNFSM5WCSFZMA
.
You are receiving this because you commented.Message ID:
@.***>

This and its dupes should be fixed with #978


components not showing

Hi, I can't seem to get my component working, the example hellopack_react (renamed base example, without webpacker-react and using javascript_pack_tag 'hellopack_react') works fine but my Appointment component and your example hello_react doesn't produce anything.
Can you point me what I am doing wrong ?
the code : here
the index page outputs :
Hellopack Pack!

and no error showing on client or server side.
This is a fresh install of rails with  --webpack=react --skip-sprockets only the appointments controller/model/view have been added alongside the examples.
Thank you in advance and thank you for your work on this plugin

I found the solution : see https://github.com/renchap/webpacker-react-example/issues/3


chore: update coc-deno setup

removed the duplicate installed
link to coc-deno

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The ci/broken-links failed, didn't relate with this changes.


Highgate International College

@MicroDreamIT Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Synchronization of Static Routes

System -> High Availability -> Synchronize Static Routes -> Config Sync
"Automatically sync the Static Route configuration to the other HA host when changes are made."
This does sync gateway changes, but doesnt seem to sync actual static routes. Even if I add one, it does not appear on the second host.
Versions	OPNsense 15.7-amd64
FreeBSD 10.1-RELEASE-p14
OpenSSL 1.0.2c 12 Jun 2015

When trying to reproduce I received some errors from the sync process when static routes should be synced.
Commit https://github.com/opnsense/core/commit/98939e30386777a3fcfd17def183beda6079bb8a should fix the issue.


What's the LICENSE?

Would like to use the library, but I can't make out what the license is.

Hey @sudhirj, it's under the BSD 2-Clause license. https://github.com/imgix/imgix-core-js/blob/master/LICENSE.md


Make create_response async and run _transform_row map async in separate thread

Make create_response (and inner functions) asynchronous and run _transform_row map asynchronously in separate thread.

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ea3f20d) 90.84% compared to head (338b8d6) 87.03%.
 Consider uploading reports for the commit c1f958a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2025      +/-   ##
==========================================
- Coverage   90.84%   87.03%   -3.81%
==========================================
  Files         246       44     -202
  Lines       15244     2553   -12691
==========================================
- Hits        13848     2222   -11626
+ Misses       1396      331    -1065

Flag
Coverage Δ

jobs_cache_maintenance
?

jobs_mongodb_migration
?

libs_libapi
88.13% <45.45%> (-0.38%)
:arrow_down:

libs_libcommon
?

services_admin
?

services_api
86.79% <ø> (-0.30%)
:arrow_down:

services_rows
85.66% <88.88%> (+0.32%)
:arrow_up:

services_search
81.37% <77.77%> (+0.06%)
:arrow_up:

services_sse-api
94.19% <ø> (ø)

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

services/rows/tests/conftest.py
91.78% <100.00%> (+0.73%)
:arrow_up:

services/rows/tests/routes/test_rows.py
92.72% <100.00%> (+0.34%)
:arrow_up:

services/search/tests/conftest.py
88.40% <100.00%> (+1.10%)
:arrow_up:

services/search/tests/routes/test_filter.py
100.00% <100.00%> (ø)

libs/libapi/src/libapi/utils.py
43.83% <50.00%> (ø)

services/rows/src/rows/routes/rows.py
61.66% <0.00%> (ø)

services/search/src/search/routes/filter.py
53.08% <0.00%> (ø)

services/search/src/search/routes/search.py
62.50% <50.00%> (ø)

libs/libapi/src/libapi/rows_utils.py
45.83% <44.44%> (-1.54%)
:arrow_down:

... and 207 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RPI5 MIPI Display Serial Interface DRI fails to load in mesa

Current setup:
Scargarth/Styhead: Raspberry Pi 5, Qt6.8 Demo
MIPI DSI: Waveshare 8.8" with the following Device Tree Overlay
dtoverlay=vc4-kms-v3d dtoverlay=vc4-kms-dsi-waveshare-panel,8_0_inch
Problem observation:
When running, Qt6 QML UI demo, MESA-LOADER fails to load a library with the following error:
MESA-LOADER: failed to open drm-rp1-dsi: /usr/lib/dri/drm-rp1-dsi_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)
Mesa uses software rendering softpipe as a fallback of V3D failure.
Qt6 UI performance is very sluggish and poor due to software rendering.
Hashes used:
meta-raspberrypi: 1aeda3f52a0cb7e9e2ae3a4673c36ca8c0c70241
poky: 8ce494b9cf84e769ac72b201838c76fd2ff894c9
meta-openembedded: 461d85a1831318747af5abe86da193bcde3fd9b4
meta-qt6: 5bf5b55c458c06ff8a037b2508ebe0cb4011dc76
I expected Broadcom Renderer V3D to be used as Qt backend renderer and not softpipe.
Additional info:
HDMI works well and use the correct V3D renderer since it doesn't require mesa to load rp1-dsi_dri.
The library drm-rp1-dsi_dri.so on Raspbian OS bookworm but doesn't exist anywhere else, I couldn't find any sources to build it.

Solution attempt #1:
I tried porting drm-rp1-dsi_dri.so as binary blob from Raspbian, but it had older llvm, libsensors.. etc dependencies that's harder to satisfy.
Solution attempt #1 : Fail.
Solution attempt #2:
I updated mesa to latest and greatest: 24.3.0-rc2 with the following dependencies added:
Build deps: wayland-protocols llvm python3-pyyaml python3-pyyaml-native
Runtime deps: llvm wayland-protocols
Packageconfig -= dri3
packageconfig += gallium-llvm
Solution attempt #2 was a success.
Now mesa-loader doesn't complain about missing library anymore and drm doesn't reference that library.
Qt6 Demo works with full performance, very responsive and RP1 DSI works flawlessly.
Action point:
If you deem my solution useful to upstream, I'm happy to create Pull Request.

Added PR:
https://github.com/agherzan/meta-raspberrypi/pull/1390


Use a client creator instead of a client in AcmeIssuingService.

Fixes #21.

This change is

Current coverage is 99.93% (diff: 100%)

Merging #51 into master will increase coverage by <.01%

@@             master        #51   diff @@
==========================================
  Files            20         20
  Lines          1535       1538     +3
  Methods           0          0
  Messages          0          0
  Branches        139        139
==========================================
+ Hits           1534       1537     +3
  Misses            1          1
  Partials          0          0

Powered by Codecov. Last update b749f4f...9f46f83

Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Judge if lock exists before delete resource group (with or without specify UseExistingRG)

Check lock exists or not whenever set or not set UseExistingRG.
Run a test without set UseExistingRG, then add lock during testing. Test results -
10/02/2019 14:06:51 : [INFO ] VERIFY-DEPLOYMENT-PROVISION ended running with status: PASS.
10/02/2019 14:06:51 : [INFO ] Try to delete resource group LISAv2-OneVM-lili-OF75-20191002140236...
10/02/2019 14:06:51 : [INFO ] Checking if LISAv2-OneVM-lili-OF75-20191002140236 exists...
10/02/2019 14:06:51 : [WARN ] Lock is in place for LISAv2-OneVM-lili-OF75-20191002140236. Skipping RG delete!
10/02/2019 14:06:51 : [INFO ] Failed to trigger delete resource group LISAv2-OneVM-lili-OF75-20191002140236.. Please delete it manually.
10/02/2019 14:06:52 : [INFO ] Test OF75 finished

This change makes more sense if Locks Resources are added during debug session.  And it's more straight forward to detect Locking when trying to delete Azure Resource Group.