SliverPersistentHeader with pinned:true is not pinned when parent CustomScrollView is wrapped in a NestedScrollView

Steps to Reproduce

Execute flutter run on the code sample
Scroll up

Expected results:
Red persistent header should stay pinned below appbar.
Actual results:
Red persistent header scrolls with the other items under the appbar.

Code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class HeaderDelegate extends SliverPersistentHeaderDelegate {
  @override
  Widget build(
      BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(height: 48, color: Colors.red);
  }

  @override
  double get maxExtent => 48.0;

  @override
  double get minExtent => 48.0;

  @override
  bool shouldRebuild(covariant SliverPersistentHeaderDelegate oldDelegate) =>
      true;
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: "App",
        home: Scaffold(
          body: NestedScrollView(
            headerSliverBuilder:
                (BuildContext context, bool innerBoxIsScrolled) {
              return <Widget>[
                SliverOverlapAbsorber(
                  handle:
                      NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                  sliver: SliverAppBar(
                    title: const Text('Books'),
                    pinned: true,
                    expandedHeight: 150.0,
                    forceElevated: innerBoxIsScrolled,
                  ),
                ),
              ];
            },
            body: SafeArea(
              top: false,
              bottom: false,
              child: Builder(
                builder: (BuildContext context) {
                  return CustomScrollView(
                    slivers: <Widget>[
                      SliverOverlapInjector(
                        handle: NestedScrollView.sliverOverlapAbsorberHandleFor(
                            context),
                      ),
                      SliverPersistentHeader(
                        delegate: HeaderDelegate(),
                        pinned: true,
                      ),
                      SliverPadding(
                        padding: const EdgeInsets.all(8.0),
                        sliver: SliverFixedExtentList(
                          itemExtent: 48.0,
                          delegate: SliverChildBuilderDelegate(
                            (BuildContext context, int index) {
                              return ListTile(
                                title: Text('Item $index'),
                              );
                            },
                            childCount: 30,
                          ),
                        ),
                      ),
                    ],
                  );
                },
              ),
            ),
          ),
        ));
  }
}

Logs
[ +100 ms] executing: sysctl hw.optional.arm64
[  +19 ms] Exit code 1 from: sysctl hw.optional.arm64
[   +1 ms] sysctl: unknown oid 'hw.optional.arm64'
[   +6 ms] executing: [/usr/local/Caskroom/flutter/1.22.4/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +14 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 18116933e77adc82f80866c928266a5b4f1ed64
[        ] executing: [/usr/local/Caskroom/flutter/1.22.4/flutter/] git tag --points-at 18116933e77adc82f80866c928266a5b4f1ed645
[ +128 ms] Exit code 0 from: git tag --points-at 18116933e77adc82f80866c928266a5b4f1ed645
[        ] 2.5.3
[  +12 ms] executing: [/usr/local/Caskroom/flutter/1.22.4/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +9 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/usr/local/Caskroom/flutter/1.22.4/flutter/] git ls-remote --get-url origin
[   +8 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +104 ms] executing: [/usr/local/Caskroom/flutter/1.22.4/flutter/] git rev-parse --abbrev-ref HEAD
[   +9 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[   +7 ms] executing: sw_vers -productName
[  +21 ms] Exit code 0 from: sw_vers -productName
[        ] macOS
[        ] executing: sw_vers -productVersion
[  +17 ms] Exit code 0 from: sw_vers -productVersion
[        ] 11.4
[        ] executing: sw_vers -buildVersion
[  +17 ms] Exit code 0 from: sw_vers -buildVersion
[        ] 20F71
[  +81 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +53 ms] executing: /Users/jeduden/Library/Android/sdk/platform-tools/adb devices -l
[  +13 ms] executing: sysctl hw.optional.arm64
[   +5 ms] Exit code 1 from: sysctl hw.optional.arm64
[        ] sysctl: unknown oid 'hw.optional.arm64'
[        ] executing: xcrun xcodebuild -version
[ +876 ms] Exit code 0 from: xcrun xcodebuild -version
[        ] Xcode 13.0
           Build version 13A233
[   +3 ms] executing: xcrun xcdevice list --timeout 2
[   +4 ms] xcrun simctl list --json devices
[        ] executing: xcrun simctl list --json devices
[   +6 ms] executing: xcrun simctl list
[ +164 ms] Exit code 0 from: xcrun simctl list
[        ] == Device Types ==
           iPhone 4s (com.apple.CoreSimulator.SimDeviceType.iPhone-4s)
           iPhone 5 (com.apple.CoreSimulator.SimDeviceType.iPhone-5)
           iPhone 5s (com.apple.CoreSimulator.SimDeviceType.iPhone-5s)
[...]
[  +53 ms] List of devices attached
           ce081718db14e52105     device usb:336592896X product:dreamltexx model:SM_G950F device:dreamlte transport_id:1
[ +161 ms] {
                      "devices" : {
                        "com.apple.CoreSimulator.SimRuntime.tvOS-13-2" : [
                          {
                            "availabilityError" : "runtime profile not found",
                            "dataPath" : "\/Users\/jeduden\/Library\/Developer\/CoreSimulator\/Devices\/02AB5E48-E12C-4860-AA77-7F49E158D278\/data",
                            "logPath" : "\/Users\/jeduden\/Library\/Logs\/CoreSimulator\/02AB5E48-E12C-4860-AA77-7F49E158D278",
                            "udid" : "02AB5E48-E12C-4860-AA77-7F49E158D278",
                            "isAvailable" : false,
                            "deviceTypeIdentifier" : "com.apple.CoreSimulator.SimDeviceType.Apple-TV-1080p",
                            "state" : "Shutdown",
                            "name" : "Apple TV"
                          },
[...]
^[^[[+3042 ms] [
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "12.2 (16E226)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone10,4",
                        "identifier" : "B6937D53-0E8E-4E3D-B03F-5B23FC8B00B1",
                        "architecture" : "x86_64",
                        "modelUTI" : "com.apple.iphone-8-2",
                        "modelName" : "iPhone 8",
                        "name" : "iPhone 8"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "15.0 (19A339)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone12,5",
                        "identifier" : "56396665-03B3-4E5A-B14C-0972D83820AB",
                        "architecture" : "x86_64",
                        "modelUTI" : "com.apple.iphone-11-pro-max-1",
                        "modelName" : "iPhone 11 Pro Max",
                        "name" : "iPhone 11 Pro Max"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "15.0 (19A339)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone13,4",
                        "identifier" : "26247B50-915F-4DE7-A8FC-9612B8D4C3B3",
                        "architecture" : "x86_64",
                        "modelUTI" : "com.apple.iphone-12-pro-max-1",
                        "modelName" : "iPhone 12 Pro Max",
                        "name" : "iPhone 12 Pro Max"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "15.0 (19A339)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPad13,5",
                        "identifier" : "A2236281-E764-4790-9B4A-BB76EAFED02C",
                        "architecture" : "x86_64",
                        "modelUTI" : "com.apple.ipad-pro-11-3rd-1",
                        "modelName" : "iPad Pro (11-inch) (3rd generation)",
                        "name" : "iPad Pro (11-inch) (3rd generation)"
                      },
                      {
                        "simulator" : true,
                        "operatingSystemVersion" : "12.2 (16E226)",
                        "available" : true,
                        "platform" : "com.apple.platform.iphonesimulator",
                        "modelCode" : "iPhone9,1",
                        "identifier" : "D830C871-73D9-4AD8-A0B6-8EE606EA858D",
                        "architecture" : "x86_64",
                        "modelUTI" : "com.apple.iphone-7-1",
                        "modelName" : "iPhone 7",
                        "name" : "iPhone 7"
                      },
[...]
[  +19 ms] Skipping pub get: version match.
[ +133 ms] Generating /Users/jeduden/dev/git/nestedscrollviewbug/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +84 ms] Initializing file store
[  +12 ms] Skipping target: gen_localizations
[   +7 ms] Skipping target: gen_dart_plugin_registrant
[        ] Skipping target: _composite
[   +2 ms] complete
[   +4 ms] Launching lib/main.dart on iPhone 8 in debug mode...
[   +5 ms] /usr/local/Caskroom/flutter/1.22.4/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev /usr/local/Caskroom/flutter/1.22.4/flutter/bin/cache/artifacts/engine/darwin-x64/frontend_server.dart.snapshot
--sdk-root /usr/local/Caskroom/flutter/1.22.4/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --incremental --target=flutter --debugger-module-names --experimental-emit-debug-metadata
-DFLUTTER_WEB_AUTO_DETECT=true --output-dill /var/folders/2b/hjz_cyln6td6qp1mk3t629ph0000gn/T/flutter_tools.jlwlYB/flutter_tool.1mDUlO/app.dill --packages
/Users/jeduden/dev/git/nestedscrollviewbug/.dart_tool/package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-scheme org-dartlang-root
--initialize-from-dill build/c075001b96339384a97db4862b8ab8db.cache.dill.track.dill --enable-experiment=alternative-invalidation-strategy
[  +11 ms] executing: [/Users/jeduden/dev/git/nestedscrollviewbug/ios/] xcrun xcodebuild -list
[  +10 ms] <- compile package:nestedscrollviewbug/main.dart
[+3053 ms] Command line invocation:
                        /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -list

                    User defaults from command line:
                        IDEPackageSupportUseBuiltinSCM = YES

                    Information about project "Runner":
                        Targets:
                            Runner

                        Build Configurations:
                            Debug
                            Release
                            Profile

                        If no build configuration is specified and -scheme is not passed then "Release" is used.

                        Schemes:
                            Runner
[  +12 ms] executing: [/Users/jeduden/dev/git/nestedscrollviewbug/ios/Runner.xcodeproj/] xcrun xcodebuild -project /Users/jeduden/dev/git/nestedscrollviewbug/ios/Runner.xcodeproj -scheme Runner -configuration Debug
-showBuildSettings BUILD_DIR=/Users/jeduden/dev/git/nestedscrollviewbug/build/ios
[   +2 ms] executing: [/Users/jeduden/dev/git/nestedscrollviewbug/ios/Runner.xcodeproj/] xcrun xcodebuild -project /Users/jeduden/dev/git/nestedscrollviewbug/ios/Runner.xcodeproj -scheme Runner -configuration Debug
-showBuildSettings BUILD_DIR=/Users/jeduden/dev/git/nestedscrollviewbug/build/ios
[+1660 ms] Command line invocation:
                        /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -project /Users/jeduden/dev/git/nestedscrollviewbug/ios/Runner.xcodeproj -scheme Runner -configuration Debug -showBuildSettings
                        BUILD_DIR=/Users/jeduden/dev/git/nestedscrollviewbug/build/ios

                    User defaults from command line:
                        IDEPackageSupportUseBuiltinSCM = YES

                    Build settings from command line:
                        BUILD_DIR = /Users/jeduden/dev/git/nestedscrollviewbug/build/ios

                    Build settings for action build and target Runner:
                        ACTION = build
                        AD_HOC_CODE_SIGNING_ALLOWED = NO
[...]
[ +139 ms]  └─Compiling, linking and signing... (completed in 5.5s)
[        ] Xcode build done.                                           24.6s
[   +1 ms] executing: rsync -av --delete /Users/jeduden/dev/git/nestedscrollviewbug/build/ios/Debug-iphonesimulator/Runner.app /Users/jeduden/dev/git/nestedscrollviewbug/build/ios/iphonesimulator
[ +841 ms] building file list ... done
                    Runner.app/
                    Runner.app/Info.plist
                    Runner.app/PkgInfo
                    Runner.app/Runner
                    Runner.app/Frameworks/
                    Runner.app/Frameworks/App.framework/
                    Runner.app/Frameworks/App.framework/App
                    Runner.app/Frameworks/App.framework/_CodeSignature/CodeResources
                    Runner.app/Frameworks/App.framework/flutter_assets/AssetManifest.json
                    Runner.app/Frameworks/App.framework/flutter_assets/FontManifest.json
                    Runner.app/Frameworks/App.framework/flutter_assets/NOTICES.Z
                    Runner.app/Frameworks/App.framework/flutter_assets/kernel_blob.bin
                    Runner.app/Frameworks/Flutter.framework/
                    Runner.app/Frameworks/Flutter.framework/Flutter
                    Runner.app/Frameworks/Flutter.framework/_CodeSignature/CodeResources
                    Runner.app/_CodeSignature/CodeResources

                    sent 116189973 bytes  received 308 bytes  77460187.33 bytes/sec
                    total size is 145367036  speedup is 1.25
[   +2 ms] executing: xcrun simctl install FC0588FD-0538-47C2-88EB-04AA7D190C9E /Users/jeduden/dev/git/nestedscrollviewbug/build/ios/iphonesimulator/Runner.app
[+1048 ms] executing: /usr/bin/plutil -convert json -o - /Users/jeduden/dev/git/nestedscrollviewbug/build/ios/iphonesimulator/Runner.app/Info.plist
[   +9 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Users/jeduden/dev/git/nestedscrollviewbug/build/ios/iphonesimulator/Runner.app/Info.plist
[        ]
{"CFBundleName":"nestedscrollviewbug","DTXcode":"1300","DTSDKName":"iphonesimulator15.0","UILaunchStoryboardName":"LaunchScreen","CFBundleIcons~ipad":{"CFBundlePrimaryIcon":{"CFBundleIconFiles":["AppIcon20x20","AppIco
n29x29","AppIcon40x40","AppIcon60x60","AppIcon76x76","AppIcon83.5x83.5"],"CFBundleIconName":"AppIcon"}},"DTSDKBuild":"19A339","CFBundleDevelopmentRegion":"en","CFBundleVersion":"1","BuildMachineOSBuild":"20F71","DTPla
tformName":"iphonesimulator","CFBundlePackageType":"APPL","UIMainStoryboardFile":"Main","CFBundleSupportedPlatforms":["iPhoneSimulator"],"CFBundleShortVersionString":"1.0.0","CFBundleInfoDictionaryVersion":"6.0","CFBu
ndleExecutable":"Runner","DTCompiler":"com.apple.compilers.llvm.clang.1_0","UISupportedInterfaceOrientations~ipad":["UIInterfaceOrientationPortrait","UIInterfaceOrientationPortraitUpsideDown","UIInterfaceOrientationLa
ndscapeLeft","UIInterfaceOrientationLandscapeRight"],"MinimumOSVersion":"9.0","CFBundleIdentifier":"com.example.nestedscrollviewbug","UIDeviceFamily":[1,2],"DTPlatformVersion":"15.0","CFBundleSignature":"????","CFBund
leIcons":{"CFBundlePrimaryIcon":{"CFBundleIconFiles":["AppIcon20x20","AppIcon29x29","AppIcon40x40","AppIcon60x60"],"CFBundleIconName":"AppIcon"}},"DTXcodeBuild":"13A233","LSRequiresIPhoneOS":true,"UISupportedInterface
Orientations":["UIInterfaceOrientationPortrait","UIInterfaceOrientationLandscapeLeft","UIInterfaceOrientationLandscapeRight"],"UIViewControllerBasedStatusBarAppearance":false,"NSBonjourServices":["_dartobservatory._tc
p"],"DTPlatformBuild":"19A339","NSLocalNetworkUsageDescription":"Allow Flutter tools on your computer to connect and debug your application. This prompt will not appear on release builds."}
[   +3 ms] executing: xcrun simctl launch FC0588FD-0538-47C2-88EB-04AA7D190C9E com.example.nestedscrollviewbug --enable-dart-profiling --enable-checked-mode --verify-entry-points --observatory-port=0
[ +251 ms] com.example.nestedscrollviewbug: 9563
[        ] Waiting for observatory port to be available...
[ +574 ms] Observatory URL on device: http://<IP_ADDRESS>:61452/uyX3QKQ-XMo=/
[   +8 ms] Caching compiled dill
[ +124 ms] Connecting to service protocol: http://<IP_ADDRESS>:61452/uyX3QKQ-XMo=/
[ +222 ms] Launching a Dart Developer Service (DDS) instance at http://<IP_ADDRESS>:0, connecting to VM service at http://<IP_ADDRESS>:61452/uyX3QKQ-XMo=/.
[  +82 ms] DDS is listening at http://<IP_ADDRESS>:61456/uJYpYrwakQw=/.
[  +71 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:61452/uyX3QKQ-XMo=/
[  +16 ms] DevFS: Creating new filesystem on the device (null)
[  +21 ms] DevFS: Created new filesystem on the device
(file:///Users/jeduden/Library/Developer/CoreSimulator/Devices/FC0588FD-0538-47C2-88EB-04AA7D190C9E/data/Containers/Data/Application/B693AE56-043D-4B32-90B9-E32923D2C49E/tmp/nestedscrollviewbugW85LE4/nestedscrollviewb
ug/)
[   +1 ms] Updating assets
[  +69 ms] Syncing files to device iPhone 8...
[   +1 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[   +3 ms] <- recompile package:nestedscrollviewbug/main.dart 8071f511-cc19-416c-ad6a-68e63167b7ab
[        ] <- 8071f511-cc19-416c-ad6a-68e63167b7ab
[  +67 ms] Updating files.
[        ] DevFS: Sync finished
[   +1 ms] Syncing files to device iPhone 8... (completed in 73ms)
[        ] Synced 0.0MB.
[   +1 ms] <- accept
[   +2 ms] Connected to _flutterView/0x7faff8012220.
[   +3 ms] Flutter run key commands.
[   +2 ms] r Hot reload. 🔥🔥🔥
[   +1 ms] R Hot restart.
[        ] h List all available interactive commands.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] 💪 Running with sound null safety 💪
[        ] An Observatory debugger and profiler on iPhone 8 is available at: http://<IP_ADDRESS>:61456/uJYpYrwakQw=/
[ +335 ms] Activating Dart DevTools...
[+3551 ms] Activating Dart DevTools... (completed in 3.6s)
[ +463 ms] The Flutter DevTools debugger and profiler on iPhone 8 is available at: http://<IP_ADDRESS>:9101?uri=http://<IP_ADDRESS>:61456/uJYpYrwakQw=/

Analyzing nestedscrollviewbug...
No issues found! (ran in 1.3s)

[✓] Flutter (Channel stable, 2.5.3, on macOS 11.4 20F71 darwin-x64, locale en-NL)
    • Flutter version 2.5.3 at /usr/local/Caskroom/flutter/1.22.4/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/jeduden/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/jeduden/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A233
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (3 available)
    • SM G950F (mobile) • ce081718db14e52105                   • android-arm64  • Android 9 (API 28)
    • iPhone 8 (mobile) • FC0588FD-0538-47C2-88EB-04AA7D190C9E • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • Chrome (web)      • chrome                               • web-javascript • Google Chrome 96.0.4664.55
    ! Error: Jan-Eric's iPhone is not connected. Xcode will continue when Jan-Eric's iPhone is connected. (code -13)
    ! Error: Jan-Eric's iPhone is not connected. Xcode will continue when Jan-Eric's iPhone is connected. (code -13)

• No issues found!

Hi @jeduden, I tested this on the latest stable and master channel and the issue is reproducible.

output
https://user-images.githubusercontent.com/92717368/143225220-bfe8cadb-44ce-4371-ba51-1d861cd36fc1.mp4

flutter doctor -v
[✓] Flutter (Channel master, 2.6.0-12.0.pre.826, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.826 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c1455a23a (5 hours ago), 2021-11-23 21:13:05 -0500
    • Engine revision 539239e256
    • Dart version 2.16.0 (build 2.16.0-42.0.dev)
    • DevTools version 2.8.0

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (5 available)
    • SM G975U (mobile)                  • R58M95MA95E                          • android-arm64  • Android 11 (API 30)
    • Android SDK built for x86 (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 13 (mobile)                 • EF1251D3-C9C4-475E-9F91-58CD010FDA48 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)                    • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)                       • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.826, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.826 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c1455a23a (5 hours ago), 2021-11-23 21:13:05 -0500
    • Engine revision 539239e256
    • Dart version 2.16.0 (build 2.16.0-42.0.dev)
    • DevTools version 2.8.0

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (5 available)
    • SM G975U (mobile)                  • R58M95MA95E                          • android-arm64  • Android 11 (API 30)
    • Android SDK built for x86 (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 13 (mobile)                 • EF1251D3-C9C4-475E-9F91-58CD010FDA48 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)                    • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)                       • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

I believe this is a duplicate of an issue I posted some time ago https://github.com/flutter/flutter/issues/91972

Since the SliverAppBar's build method configures a SliverPersistentHeader.
See the  SliverAppBar implementation
How about closing one issue and amending the other with the other code sample, so that the person who needs to fix this has all information needed to make a solid fix for all scenarios.

Sorry for the late reply.
I can close my issue, but is it a problem to do so if it has been "labeled for further insights"  as mentioned in this comment?

Good question. Not sure what the best way forward is to ensure this unexpected behaviour gets fixed soon.

Hey @jeduden I think this issue is the same as #91972, so I am going to close it. I'll cross link them so they can both be referenced when someone works on it.


Add unit tests

This PR adds unit tests for the least covered components of the library. There are still several files that are not at %100 coverage but overall we're in a much better state:
Before

After

@shayonj @shkolnik how did you setup lint? When I run rubocop --fix locally it doesn't catch the same things as circleCI

ah! its actually coming from the orb. https://github.com/Gusto/grpc-web-ruby/blob/da8d1c052b5810d7b903f6f0f165c2b82ab6755c/.circleci/config.yml#L23
orb source
Maybe we can init a .rubocop.yml and .todo.yml file in the repo  and exclude/include accordingly 🤔

@shayonj but there is a rubocop.yml in the repo, I wonder if that orb isn't picking it up?

Figured out the rubocop issue, the --fix flag is an eslint thing, not a rubocop thing 🤦♀

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add --omit-publisher to omit publisher part of the path

I added the option to omit the publisher part of the path to flatten the hierarchy and make the directory more intuitively searchable imho.
The wheel was tested successfully.
Already downloaded files can be moved with find ./DriveThruRPG/ -maxdepth 2 -mindepth 2 -type d -print0 | xargs -0 -I {} mv -v "{}" ./DriveThruRPG
Empty publisher folders can be deleted with find ./DriveThruRPG/ -empty -type d -delete afterwards.

Hi @Wuschli , thanks for a PR. I like the idea!
I have a minor complaint, though. I think a user should not be able to combine the new settings and --compatibility-mode as it might be confusing. Could you make this two options exclusive?

You should be able to achieve that with add_mutually_exclusive_group

thanks for your input. I think I fixed both of your points and also added a new test. Can you please review the test, since I am not proficient with python, especially unit tests.
Cheers, Lukas

@Wuschli this looks great, thanks!
I'll take it from here if you don't mind. I'd like to test it locally and will provided any changes if needed.

@Wuschli I've released drpg 2024.11.8 with your changes.


add preprocessing step

This PR adds the preprocessing step into the DSWx-SAR workflow.
The preprocessing includes

reading ancillary data such as dem, hand, worldcover, and reference water and relocating them into the mosaic rtc grid.
applying filter to the rtc images.

@seongsujeong Thank you for your comments. It seems it requires more clearing up. I just finished fixing the code based on your comments. For your information, dummpy_dswx_s1.py will be replaced with the new files. So, I did not modify the code for this.

@oberonia78 Thanks for the information. I'll disregard dummpy_dswx_s1.py when reviewing the PR.

@seongsujeong I revised the PR based on the comments. Let me know if you have any comments. If not, let's merge it ASAP.

@seongsujeong All bugs were corrected and docstrings were added.

one more comment here Please make sure to check that out before merging this PR.


Readme revamp

Description of your changes
Make it consistent with the platform-ref-aws
Signed-off-by: Yury Tsarev<EMAIL_ADDRESS>I have:

[x] Read and followed Upbound's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Patch boost thread_data for ubuntu 21.10 build

Fixes #180

@w2vy can you confirm if this patch fixes the problem with the ubuntu 21.10 builds?

@w2vy Issues closes automatically when tagged on merge to master.
Branch deleted


master issue: Make HTTP requests using IHttpClientFactory

This is the master issue for this doc.  Reopen each issue you are working on so the owner is notified.
PU issues:

[ ]  How to create named clients at runtime / after Startup #16638
[ ] Not clear that AddHttpClient replaces AddScoped, AddTransient, etc #16498
[ ] HTTP POST example? #12580
[ ] Disposing of Dependencies Injected into Custom DelegatingHandlers #18058
[ ] Disposing HttpResponseMessage #16103
[ ] Configuring ALL HttpClients named or unnamed #18162
[ ]
[ ]
[ ]
Not PU:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 881cef77-11ef-ac11-06d0-0996a1ccfa1b
Version Independent ID: 3d356334-e672-7e8b-1fef-7944ebee99eb
Content: Make HTTP requests using IHttpClientFactory in ASP.NET Core
Content Source: aspnetcore/fundamentals/http-requests.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @stevejgordon
Microsoft Alias: scaddie

@Rick-Anderson #16498 and #12580 have been done.


Support for federated logins

Is amplify going to be extended to handle federated logins to Cognito? like Google and Facebook?

Yes @jonsmirl  federated identities on the way. Will be added soon.
Thanks,
Richard

I would suggest that this be a top initial goal, and then add the implementation to Mobile Hub. Over the last few years I've probably seen 500 people people asking for Javascript code to implemented Cognito Social + User Pool logins. It is not a trivial piece of code.  Most of the people posting about this end up moving over to Auth0 which has a finished widget.

Added federated support in PR #57


Why does mask characters appear before the set position

For example, if i have a mask 99/99/9999 and when i start inputting values in the field it adds '//' before even completing set inputs. That means the first slash should appear only after entering 2nd value and the second slash after entering the 4th value in the input field. Also after deleting the slash stays until it the focus is gone from the element.
My simple setting is:
$('#dob').inputmask({
  placeholder: '',
  mask: '99/99/9999',
  showMaskOnFocus: false,
  showMaskOnHover: false,
  jitMasking: true,
});

Please suggest a fix, client does not want to see the mask characters until the position is reached.

Hey, I am also looking for similar solution.
Inputmask('*** - *** - ***')
For this mask, When I enter 1 char, I see mask characters, which I dont want.

Please sugest a fix

Is this even possible or do we need to look for another library?

Hi @sampathkumarm , @ramgaikar ,
I made an example in https://codepen.io/robinherbots/pen/GRpLwMM
What exactly do you expect different?

Hi @sampathkumarm , @ramgaikar ,
I made an example in https://codepen.io/robinherbots/pen/GRpLwMM
What exactly do you expect different?

Hey,
Awesome. Thanks. Didn't knew about jitmasking option. Thanks a ton

Hi @sampathkumarm , @ramgaikar ,
I made an example in https://codepen.io/robinherbots/pen/GRpLwMM
What exactly do you expect different?

OMG, I am really sorry. I know why it was not working even though you see I have 'jitMasking' enabled in my code. The issue is I have been using 2 versions of this library (3.2-3.9 and 5.04). It's my bad.
@RobinHerbots, I know this is a really dumb question but can we use both versions without affecting each other?
Thanks for your reply @RobinHerbots

Not a library issue, instead issue was cause of using multiple versions.


394/page titles

Context
Changes proposed in this pull request
Guidance to review

HFEYP-394 relates to 'EYFS - Page Head titles for Google Analytics'
It should only be a handful of cosmetic changes.

This PR is still in draft mode, so no need to comment yet.

Ok.  Rec'd email saying view/comment/merge PR


Update Solarized Theme -> Flow Theme

Submit a new Plugin to Marketplace
Plugin Github repo URL: https://github.com/nmartin84/logseq-flow
Github releases checklist

[x] a legal package.json file.
[x] a valid CI workflow build action for Github releases. (Optional for theme plugin only).
[x] a release which includes a release zip pkg from a successful build.
[x] a clear README file, ideally with an image or gif showcase. (For more friendly to users, it is recommended to have English version description).


Cannot inline bytecode built with JVM target 17

Cannot inline bytecode built with JVM target 17 into bytecode that is being built with JVM target 1.8. Please specify proper '-jvm-target' option
common/build.gradle.kts
androidTarget {
      compilations.all {
          kotlinOptions.jvmTarget = "17"
      }
  }
jvm("desktop") {
      compilations.all {
          kotlinOptions.jvmTarget = "17"
      }
  }

android/build.gradle.kts
compileOptions {
        sourceCompatibility = JavaVersion.VERSION_17
        targetCompatibility = JavaVersion.VERSION_17
    }
kotlinOptions {
      jvmTarget = JavaVersion.VERSION_17.toString()
  }

desktop/build.gradle.kts
jvm {
        compilations.all {
            kotlinOptions.jvmTarget = "11"
        }
        withJava()
    }

------------------------------------------------------------
Gradle 8.2
------------------------------------------------------------

Build time:   2023-06-30 18:02:30 UTC
Revision:     5f4a070a62a31a17438ac998c2b849f4f6892877

Kotlin:       1.8.20
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          17.0.5 (Oracle Corporation 17.0.5+9-LTS-191)
OS:           Mac OS X 12.7.1 x86_64

0.2.0 has just released with a fix for this problem!

Hi! I've got the same problem in my project. We use jvmTarget 1.8. Why are this library used jvmTarget 11?

@Lavmee Please, take care of this issue


Ominisharp report error when VSCode loading my dotnet core project

I encounter a problem when omnisharp loading my dotnet core project using vscode.
Omnisharp logs:
Starting OmniSharp server at 10/9/2018, 10:19:58 PM
    Target: d:\work\tools\XxxTransfer

OmniSharp server started.
    Path: C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\OmniSharp.exe
    PID: 22356

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on Windows 6.2.9200.0 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 15.0 - "C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild\15.0\Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to 'C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild\15.0\Bin\MSBuild.exe'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 15.0 - "C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild\15.0\Bin"
            CscToolExe = csc.exe
            CscToolPath = C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild\15.0\Bin\Roslyn
            MSBuildExtensionsPath = C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild
            MSBuildToolsPath = C:\Users\xiaoqiang\.vscode\extensions\ms-vscode.csharp-1.16.2\.omnisharp\1.32.5\msbuild\15.0\Bin
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in 'd:\work\tools\XxxTransfer'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.WorkspaceInitializer
        Project system 'OmniSharp.DotNet.DotNetProjectSystem' is disabled in the configuration.
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in 'd:\work\tools\XxxTransfer'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'd:\work\tools\XxxTransfer\XxxTransfer.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in 'd:\work\tools\XxxTransfer'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location 'd:\work\tools\XxxTransfer' on host 21736.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: d:\work\tools\XxxTransfer\XxxTransfer.csproj
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file 'd:\work\tools\XxxTransfer\XxxTransfer.csproj'.
d:\work\tools\XxxTransfer\XxxTransfer.csproj(1,1)
Microsoft.Build.Exceptions.InvalidProjectFileException: The SDK 'Microsoft.NET.Sdk' specified could not be found.  d:\work\tools\XxxTransfer\XxxTransfer.csproj
   在 Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args)
   在 Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpressionConditioned(String directoryOfImportingFile, ProjectImportElement importElement, List`1& projects, Boolean throwOnFileNotExistsError)
   在 Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImports(String directoryOfImportingFile, ProjectImportElement importElement)
   在 Microsoft.Build.Evaluation.Evaluator`4.EvaluateImportElement(String directoryOfImportingFile, ProjectImportElement importElement)
   在 Microsoft.Build.Evaluation.Evaluator`4.PerformDepthFirstPass(ProjectRootElement currentProjectOrImport)
   在 Microsoft.Build.Evaluation.Evaluator`4.Evaluate(ILoggingService loggingService, BuildEventContext buildEventContext)
   在 Microsoft.Build.Evaluation.Project.Reevaluate(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings)
   在 Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings)
   在 Microsoft.Build.Evaluation.Project.Initialize(IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectLoadSettings loadSettings)
   在 Microsoft.Build.Evaluation.Project..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings)
   在 Microsoft.Build.Evaluation.ProjectCollection.LoadProject(String fileName, IDictionary`2 globalProperties, String toolsVersion)
   在 OmniSharp.MSBuild.ProjectLoader.EvaluateProjectFileCore(String filePath)
   在 OmniSharp.MSBuild.ProjectLoader.BuildProject(String filePath)
   在 OmniSharp.MSBuild.ProjectFile.ProjectFileInfo.Load(String filePath, ProjectLoader loader)
   在 OmniSharp.MSBuild.ProjectManager.LoadOrReloadProject(String projectFilePath, Func`1 loader)

[fail]: OmniSharp.MSBuild.ProjectManager
        Attemped to update project that is not loaded: d:\work\tools\XxxTransfer\XxxTransfer.csproj

And below is my csproj file
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.1</TargetFramework>
    <RuntimeIdentifier>win10-x64</RuntimeIdentifier>
    <LangVersion>latest</LangVersion>
    <GenerateDocumentationFile>true</GenerateDocumentationFile>
    <NoWarn>CS1591</NoWarn>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.EntityFrameworkCore" Version="2.1.3"/>
    <PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="2.1.2"/>
    <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1"/>
    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.1"/>
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.1.3"/>
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="2.1.1"/>
  </ItemGroup>
  <ItemGroup>
  </ItemGroup>
</Project>

Could you share the output of dotnet --info?

Thanks! I've seen some cases of SDK resolution failing to locate .NET Core SDK version 2.1.403, but haven't ever been able to reproduce it.
Try this to workaround the issue thy this:

Add a file called omnisharp.json to your project folder with following content:

{
    "MsBuild": {
        "UseLegacySdkResolver": true
    }
}

Restart OmniSharp.

Let me know if that addresses the problem for you.

@DustinCampbell
It did work, Thank you !!!! Thank  you 10000000 times!!!

This didn't work for me. After adding the omnisharp.json I still get this trace:
Starting OmniSharp server at 11/16/2018, 11:18:12 AM
    Target: c:\Users\<me>\Documents\VSCode\experiment

OmniSharp server started.
    Path: C:\Users\<me>\.vscode\extensions\ms-vscode.csharp-1.17.1\.omnisharp\1.32.8\OmniSharp.exe
    PID: 15904

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on Windows 6.2.9200.0 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 3 MSBuild instance(s)
            1: Visual Studio Build Tools 2017 15.8.28010.2048 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin"
            2: Visual Studio Community 2017 15.8.28010.2048 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin"
            3: StandAlone 15.0 - "C:\Users\<me>\.vscode\extensions\ms-vscode.csharp-1.17.1\.omnisharp\1.32.8\msbuild\15.0\Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Visual Studio Build Tools 2017 15.8.28010.2048 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin"
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in 'c:\Users\<me>\Documents\VSCode\experiment'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.WorkspaceInitializer
        Project system 'OmniSharp.DotNet.DotNetProjectSystem' is disabled in the configuration.
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in 'c:\Users\<me>\Documents\VSCode\experiment'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for 'c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in 'c:\Users\<me>\Documents\VSCode\experiment'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location 'c:\Users\<me>\Documents\VSCode\experiment' on host 10556.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file 'c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj'.
c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj(1,1)
Microsoft.Build.Exceptions.InvalidProjectFileException: Could not load SDK Resolver. A manifest file exists, but the path to the SDK Resolver DLL file could not be found. Manifest file path 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\SdkResolvers\Microsoft.Build.NuGetSdkResolver\Microsoft.Build.NuGetSdkResolver.xml'. SDK resolver path: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Microsoft\NuGet\Microsoft.Build.NuGetSdkResolver.dll  c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj
   at Microsoft.Build.Shared.ProjectFileErrorUtilities.VerifyThrowInvalidProjectFile(Boolean condition, String errorSubCategoryResourceName, BuildEventFileInfo projectFile, Exception innerException, String resourceName, Object[] args)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverLoader.TryAddAssemblyFromManifest(String pathToManifest, String manifestFolder, List`1 assembliesList, ElementLocation location)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverLoader.FindPotentialSdkResolvers(String rootFolder, ElementLocation location)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverLoader.LoadResolvers(LoggingContext loggingContext, ElementLocation location)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.Initialize(LoggingContext loggingContext, ElementLocation location)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdk(Int32 submissionId, SdkReference sdk, LoggingContext loggingContext, ElementLocation sdkReferenceLocation, String solutionPath, String projectPath)
   at Microsoft.Build.BackEnd.SdkResolution.CachingSdkResolverService.<>c__DisplayClass3_0.<ResolveSdk>b__0(String key)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Build.BackEnd.SdkResolution.CachingSdkResolverService.ResolveSdk(Int32 submissionId, SdkReference sdk, LoggingContext loggingContext, ElementLocation sdkReferenceLocation, String solutionPath, String projectPath)
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImportsFromUnescapedImportExpressionConditioned(String directoryOfImportingFile, ProjectImportElement importElement, List`1& projects, SdkResult& sdkResult, Boolean throwOnFileNotExistsError)
   at Microsoft.Build.Evaluation.Evaluator`4.ExpandAndLoadImports(String directoryOfImportingFile, ProjectImportElement importElement, SdkResult& sdkResult)
   at Microsoft.Build.Evaluation.Evaluator`4.EvaluateImportElement(String directoryOfImportingFile, ProjectImportElement importElement)
   at Microsoft.Build.Evaluation.Evaluator`4.PerformDepthFirstPass(ProjectRootElement currentProjectOrImport)
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(ILoggingService loggingService, BuildEventContext buildEventContext)
   at Microsoft.Build.Evaluation.Project.Reevaluate(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
   at Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
   at Microsoft.Build.Evaluation.Project.Initialize(IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
   at Microsoft.Build.Evaluation.Project..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
   at Microsoft.Build.Evaluation.ProjectCollection.LoadProject(String fileName, IDictionary`2 globalProperties, String toolsVersion)
   at OmniSharp.MSBuild.ProjectLoader.EvaluateProjectFileCore(String filePath)
   at OmniSharp.MSBuild.ProjectLoader.BuildProject(String filePath)
   at OmniSharp.MSBuild.ProjectFile.ProjectFileInfo.Load(String filePath, ProjectLoader loader)
   at OmniSharp.MSBuild.ProjectManager.LoadOrReloadProject(String projectFilePath, Func`1 loader)

[fail]: OmniSharp.MSBuild.ProjectManager
        Attemped to update project that is not loaded: c:\Users\<me>\Documents\VSCode\experiment\experiment.csproj

@TAGC sorry for the delay. Could you file a separate issue? What you described is different and possibly solved by https://github.com/OmniSharp/omnisharp-roslyn/pull/1347 if you're launching VS Code from a Visual Studio console.

Installing .NET Core build tools like @rainersigwald suggested in #1311 solved it for me.

Great -- this has turned out to be an VS installer issue where one file is dropped on disk, but not another. I believe there are some plans to address this.

@DustinCampbell  Thank you for the tip! I've been battling vscode/omnisharp for a couple of days and it now works!

@DustinCampbell that worked for me as well.
I've just installed Ubuntu from scratch, installed both dotnet and vscode from the snap store, and Omnisharp started complaining...
Creating a simlink (as per below) didn't work for me, however, your solution saved my bacon

"sudo ln -sv /usr/local/bin/dotnet /snap/dotnet-sdk/current/dotnet"

Btw, I've never had this problem when installing vscode and dotnet via sudo apt, so this leads me to believe that dotnet snap is broken.


Return to "play" Blank Screen item after video finished

Please implement "Return to 'play' Blank Screen item after media stopped" feature either as a checkbox in DISPLAY section next to "Include 'Blank Screen' item" or as checkbox "Resume playing this item after another one has stopped" below the Blank Screen item itself.

Hey, just opt out the JW Library compatibility mode. This option is for displaying the JWL Year Text and Media while OnlyM is showing nothing. If you want OnlyM return to the Black Screen, just don't opt this function in. 😉
Many regards,
BenjyW

@supportsobaka Select the "permanent backdrop" option.


verilator: Add pic_static_library  to output files

This turns
$ bazelisk-linux-amd64 cquery --output=files '//hardware:rv32_verilator'
INFO: Analyzed target //hardware:rv32_verilator (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
INFO: Elapsed time: 0.091s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions

into
$ bazelisk-linux-amd64 cquery --output=files '//hardware:rv32_verilator'
INFO: Analyzed target //hardware:rv32_verilator (6 packages loaded, 1150 targets configured).
INFO: Found 1 target...
bazel-out/k8-fastbuild/bin/hardware/librv32_verilator.a
INFO: Elapsed time: 1.237s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 0 total actions

for me.

/gcbrun


accordion

Coverage decreased (-0.2%) to 57.71% when pulling 6eefc4a21886b21b6374ccf78191e52b1b00925c on SeanGG:dev into 0e07dee698fc42ad82f715c827b02fc4c6215652 on ZhonganTechENG:dev.


[REQ] Command line options

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
Add some command line options like joining a game using something like <bloxstrap.exe> --game <gameId>, if that's even possible

roblox://experiences/start?placeId=


Modify Hyper-V driver for use with CRC

added bundle implementation

investigating DNS workaround

Fixed via #364


Update Registry's k8s dependencies

Which area/kind this issue is related to?
/area registry
Issue Description
As part of https://github.com/devfile/api/issues/1303 we should check if we can update the following dependencies:

github.com/onsi/ginkgo/v2
github.com/onsi/gomega

Those dependencies are using<EMAIL_ADDRESS>which we need to update to a newer version.
Acceptance Criteria

[ ] Direct dependencies using<EMAIL_ADDRESS>packages should be updated.

Created a PR to update the listed dependencies


mame 0.165

Version bump.
Changed to use brewed deps instead of building internally, except:

expat: brewed version not picked up automatically, os x version is old.
lua: lua53 is not available in the core.
portaudio: though declared in makefile, seems not being used yet.

test block improved.
Some redundancy cleaned up.

Thanks!

Sorry, @tomyun , I have question.
Is depends_on :python => :build necessary? All Python code are in 3rdparty directory and seems it's not libraries that can link other formulae, it should be use system's Python.
And one more thing, due to non-universal libraries in Homebrew, PTR64 flag is requirement for Snow Leopard. MAME use uname to check architecture and will cause Homebrew build failed in 10.6.

@mbcoguno Thanks for reporting this issue. Just opened #340 for it.


ENH: Simple tabbed template

This changeset aims to simplify the iframe business in the existing tabbed template by scrapping iframes altogether.

Example implementation: https://github.com/turanoo/q2-feature-table/pull/1

Sample visualization: https://view.qiime2.org/visualization/?type=html&src=https%3A%2F%2Fforum-qiime2-org.s3.dualstack.us-west-2.amazonaws.com%2Foriginal%2F2X%2F1%2F12b982ec44eac8f5dfa71111b1cce361e6171fcc.qzv


add env-vars from annotations #2508

Description
PTAL! :) @yaron2
add environment variables from dapr.io/env annotation.
dapr.io/env/key=val is incorrect with annotation syntax
so I implement with this syntax dapr.io/env: key1=value1, key2=value2
Issue reference
closes #2508
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[x] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in th
[ ] https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@moonchanyong please comment on the issue #2508 so that it can be assigned to you.

Thanks for this @moonchanyong!
Can you please open up a corresponding docs update for this feature?

@yaron2  this pr is it.


Appstudio update test-component-pac-dpgq

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-dpgq-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
22 seconds
clone-repository

✅ Succeeded
20 seconds
sast-snyk-check

✅ Succeeded
1 minute
build-container

✅ Succeeded
29 seconds
deprecated-base-image-check

✅ Succeeded
41 seconds
clamav-scan

✅ Succeeded
7 seconds
clair-scan

✅ Succeeded
7 seconds
sbom-json-check

✅ Succeeded
28 seconds
inspect-image

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary


profile-pic without login

In previous I used:
instaloader -P 'cat target.txt'
but now I got :
--login=USERNAME required

Please read https://instaloader.github.io/contributing.html and obey the bug report issue template. Without the error message or the instaloader invocation we have no chance to see what's wrong.

Ah now I see. When downloading profiles with --profile-pic-only, Instaloader prints the login required error message for each profile, but still downloads the profile pictures.


CAMEL-12588 - Improving the fix

doStop() method now shuts down the timeoutCheckerExecutorService pool too
Improvment - used shutdown instead of shutdownNow

Please raise a new PR or squash into one commit


Feature: Add thresholds to bar chart of KRI score.

Feature Details
KRI thesholds on the bar chart disappeared somewhere along the line.
Example Code
      lOutput$lCharts <- MakeKRICharts(
          dfSummary = lData$dfSummary,
          lLabels = lLabels,
          dfBounds = lData$dfBounds,
          vThreshold = vThreshold
      )

Possible Implementation

Additional Comments

fixed in #1614


Support ReSharper 9.2

We should be supporting ReSharper 9.2 too :).

Great...
I hope this is still WIP.

me too, it would be really great to have my resharper support working again. It was working in 9.1.

+1, having to run StyleCop separately from R# is a big inconvenience

I agree with you guys. It would be nice to have the StyleCop extension back.

+1 I just miss stylecop , resharper it's not the same without it!

I'm working on it! It's needing a little bit of love to get it good enough for 9.2. Here's the shopping list:

[x] Removing all of the old versions
[x] Removing old unused code
[x] Clean compile with 9.2
[x] Work without StyleCop installed as a VS extension, so it can be distributed on the ReSharper gallery. Also meant consolidating access to the StyleCop API to better reuse caches (still work to be done here - there are leaks of FileSystemWatcher classes)
[x] Rewrite options page to work with high DPI
[x] Use ReSharper's native extension mechanism for automatically importing settings from a settings file, rather than explicitly rewriting settings
[ ] Update file layout settings to work with ReSharper 9's new file layout editor
[ ] Rework code cleanup module. No more massive list of options here, mainly due to an API change in ReSharper, but also because they're just a bunch of checkboxes that mirror the Enabled setting in the settings files. This is the current bit of work in progress. Done, just needs testing.

I think that's it, but there could be more. Getting very close to releasing it to the gallery.

Sounds all really good, just one question regarding the code cleanup module:
I typically disabled one or two of the options in there because they where conflicting with our code documentation style, is that possibility gone from now on or just configured somewhere else?

It now looks at the settings.StyleCop file(s). This file is used when calculating the warnings, but was mostly ignored for the cleanup. It seems pointless to duplicate the settings into the code cleanup module - the code cleanup should just make the code look like what the warnings want to see (as best it can). So you can disable the rule in the settings file.
The downside to this is that there isn't an easy way to edit those settings right now. If you install StyleCop itself, you'll get a settings editor, so you can double-click the settings.StyleCop and get a bit of a UI that will update the XML file for you. Not ideal, and I'm not sure what to do here, so I think I'm pushing that out to a next release.
Out of interest, what was the setting you changed?

I disabled the constructor/destructor documentation setting. We are using a "======" separator line at the beginning and end of the documentation blocks which works fine for all other code elements, but on the constructors it wants the standard line:
Initializes a new instance of the  class.
But when using the separator line it doesn't seem happy and adds another one of those lines every time you clean up the code, I found files that had that line 5 times for each constructor :)

Also, FWIW, StyleCop.MSBuild has become a very popular way of consuming StyleCop. For me it's the simplest way possible. You just install that package in your project and all of a sudden StyleCop analysis runs on every build. It's fully compatible with package restore which means StyleCop analysis gets carried with the source, but without the binaries, just like any other NuGet package.
It would be great if R# StyleCop support recognised this scenario as a first class citizen, bearing in mind (as usual I guess) that some people working on a codebase with StyleCop.MSBuild installed may have R# and others may not.

Forgot the link - https://www.nuget.org/packages/StyleCop.MSBuild/

Nice work @citizenmatt, looking forward to the release.  Anything you need a hand with?
Also I'll echo @adamralph in that I always use the MSBuild NuGet package, and also the MSBuild Errors NuGet package (https://www.nuget.org/packages/StyleCop.Error.MSBuild/) which sets the false, but it would be nice if we didn't require this MSBuild node and the Settings.StyleCop option of 'Treat violations as errors' triggered this.

All, I've moved msbuild stuff to #11, so as not to derail ReSharper stuff. I'll respond over there :)

@jimmyheaddon nothing at the minute, thanks. Testing once it's out would be brilliant, though. I'll see if I can get to a position for a pre-release version soon.

@citizenmatt Happy to test the crap out of this once you have something. If you need assistance in the interim please divvy out some tasks and I'll be happy to see what I can do.

Hi all. I've just pushed the 9.2 package to the gallery. You should be able to download and install it now, from ReSharper → Extensions Manager.
You can find release notes here: https://github.com/StyleCop/StyleCop/releases/tag/resharper-4.7.0
Consider this a soft launch - please can you test this, and raise an issue for anything dodgy you find, please?

Installing now.

Nice one @citizenmatt - installed and testing now.
For reference I also needed to restart Visual Studio 2013 after installing, as the StyleCop rules failed to show under 'Inspection Severity' for any ReSharper layer.
Am I right in saying that we still need to configure the rules in ReSharper to match those in Settings.StyleCop?

One issue I've spotted - my Settings.StyleCop is configured as 'en-GB', but I am seeing errors for XML comments being spelled incorrectly (it's expecting 'en-US').  I can't see an option for this in the ReSharper layer configuration, should it be inferred from Settings.StyleCop?

Same her with de-DE not being recognized.

Yes, an application restart is required when you install any ReSharper extension.
And you can configure what severity a highlight shows up as in ReSharper, but the settings files should override that - if a rule is disabled in the settings, then it won't run, regardless of what's set in ReSharper.
Spelling should come from the settings files, I think. But I'd need to test it. I'll take a look as soon as I can.

Using a custom settings file, the highlighting works fine.
I have a code cleanup profile where I have selected 'Apply StyleCop rules'. While performing the code cleanup it seems that default settings are used and not the custom one.

Great stuff - I have missed the StyleCop editor squiggles since moving to R# 9.2 (VS2013).
As there is no longer a requirement to have StyleCop installed, does the extension still apply the exact same ruleset? We run StyleCop as part of our TFS builds, so I need to be sure that our developers (using this extension) won't miss any violations that will subsequently be picked up during a server build (using StyleCop) - assuming the same settings.stylecop file is in use on PCs and server of course.
Keep up the good work.

A minor point @citizenmatt, when you run ReSharper 'Inspection Results', if you group by 'Issue Type and File', then all StyleCop errors are grouped under issue type "a", rather than "StyleCop".

@citizenmatt sorry, I don't understand these things:

How to change the default Settings.StyleCop file, where to place it?
Is possible to use MSBuild Nuget package to apply StyleCop to the build? Where install the package, in which project?
I use StyleCop+ (https://stylecopplus.codeplex.com), is possibile to use it?
Thanks a lot for your work.

Since installing this extension, whenever I do a Refactor -> Rename, R# is putting "this." in front of the renamed variables, even though "Code Style -> Add/Remove 'this.' qualifier" and "StyleCop -> SA1101" are both set to "Do not show". Thoughts?

@matteomigliore:

You need to add Settings.StyleCop to the root of the solution. As I understand it, you can also place a copy next to the file being analysed, and at any folder up to the root of the solution. There isn't a settings editor right now, so you pretty much need to know the XML format - more details are available on the original CodePlex site. You can still install the standard StyleCop distribution, which will set up a file association for the .StyleCop files and open them in a nice settings editor.
This project doesn't have an msbuild package. I believe @adamralph has a package of the last released set of rules - StyleCop.MSBuild, or if you're using Visual Studio 2015, you can use the new StyleCop.Analyzers package to install Roslyn analysers.
This project doesn't do anything to support StyleCop+, but looking at the site, it looks like most of the features are already available in ReSharper - you can configure ReSharper to set different naming conventions for different types of entity - classes, interfaces, fields, etc. However, doing so might conflict with existing StyleCop rules, in which case, disable the StyleCop rules in Settings.StyleCop.

@jimmyheaddon I've logged a new issue for the "a" in Inspection Results - #16

@markuskorbel I've added a new issue for the multiple separator lines - #17

@andyste1 the ReSharper plugin hasn't changed the StyleCop engine, ruleset and settings files, so should be exactly the same (although there may be a couple of issues with settings files, there were definitely bugs to begin with - and I've probably introduced some more :smile:)

@citizenmatt yes, StyleCop+ is a StyleCop plugin, a .dll must be added, if I install StyleCop it goes in the installation folder. Where can I place it if the Settings.StyleCop goes at the root of the solution?
I can also install StyleCop e leave the settings in the installation folder?
I've to try the Roslyn analyzer.
Thank you!

@andyste1 setting the severity of SA1101 won't affect what ReSharper does with the code cleanup - that just tells ReSharper how to display the highlights if the code doesn't conform (error, warning, suggestion, hint or hidden). If it's set to Do Not Show, StyleCop still considers it to be in violation, it's just not highlighted to the user. This is kind of awkward, but fits with running it at the command line or via msbuild - ReSharper settings have no effect. You'll need to disable this rule in a settings.stylecop file.
What's the exact setting for the Code Style "Use 'this.' qualifier for" option? This is what drives ReSharper to insert the this. qualifier. The default settings for StyleCop are to have "Field", "Property", "Event" and "Method" checked (the default shipped with ReSharper is "None").

@citizenmatt I've found that checkbox list under Code Editing -> C# -> Code Style, unticked them all and it's okay now. The strange thing is they were unticked in my individual layers, and I only found them ticked when I went via the "Options" menu (rather than "Manage Options"). Curious to know what the difference is, and where the former saves the settings?
I've since noticed other issues similar to the "this." setting, which have started since installing the extension. E.g. many of my reformatting style settings that have been turned off/customised for years, but are now behaving as if they've reverted to default. Again they are still set correctly in the individual layers (via "Manage Options") but not when I go into "Options".

@andyste1 The way the settings work is to ship the StyleCop settings in a settings file that is merged with ReSharper's defaults. In a clean install, this means StyleCop overrides ReSharper's default settings.
More technically, the StyleCop settings file is mounted as a layer, above the defaults, but below the global (and per-solution) levels. So, if you've already set any of these settings, your modifications take precedence (because they live in the higher priority global or per-solution layers).
You can reset the settings back to the StyleCop defaults by going to the StyleCop options page, and clicking Reset Settings. This removes any overriding settings from the global and per-solution layers.
The StyleCop settings shouldn't override any layers that you've already got mounted, as they're set to have a priority lower than globals, and anything you've changed will be saved to the global layer. However, ReSharper is "smart" when it comes to saving - roughly speaking, if the value you're setting is the same as in a lower layer, it simply removes it from the current layer. So, setting something to be the default value will not write the default value to globals, and ReSharper will just use the value from the defaults. But if the StyleCop settings override that setting, the new StyleCop values will win, because they have a higher priority than the defaults.
Hopefully, there's nothing in the StyleCop settings that shouldn't be there - it's mostly about formatting, and should be set up to give you the correct StyleCop format.
(You can also see what files are backing the layers by right clicking and selecting "Open Containing Folder")

@matteomigliore ah, hadn't read the site properly. I've added an issue to get the resharper extension to load custom addins - #18.

In the older version you could right-click in the current file and choose "stylecop" to check the current file and create warnings for it. Would it be possible to enable/add that context menu item?

That's the Visual Studio addin, rather than the ReSharper addin. To get the warnings for a file in ReSharper, just open the file :)
The VS addin still works, pre 2015, and 2015 and up can use DotNetAnalyzers/StyleCopAnalyzers.

@jimmyheaddon, @dfyx StyleCop's spell checker requires Office 2010 to be installed. It looks for the install location of 2010, and directly loads the appropriate spell checker .dll file, using P/Invoke to get at the API. If it can't find the .dll in the Office 2010 folder, it tries to load it from the location of the current AppDomain, or the location of the StyleCop assembly. If it can't load a specific dictionary, such as de-DE, it will fallback to the parent dictionary (de) and try again.
But, StyleCop itself only ships with the en dictionary, which I think is actually en-US.
So, @jimmyheaddon, in your situation, I'd guess that you don't have Office 2010 installed, and so it doesn't load the en-GB dictionary. It tries to fall back to the parent dictionary, which is en, and it finds that installed alongside the main StyleCop.dll assembly, so loads it.
@dfyx, I presume your situation is very similar - no Office 2010, so it can't find de-DE, but also can't find de. There are no more fall backs, so it doesn't load anything, and doesn't catch spelling errors.
You might want to try ReSpeller, a spell checker implemented as a ReSharper plugin - marks typos in the editor and provides alt+enter quick fixes to rename things appropriately.

@citizenmatt interesting, thanks for the update.  I have Office 2013 installed for reference.  I'm using ReSpeller Free already and it works great, it's just the StyleCop warns me that I'm using en-GB instead of en-US :(

Hmm. Easiest thing to do is to disable the spell check rules in the settings.stylecop file. Since StyleCop itself requires Office 2010 installed, this check will never work in your situation, whether you're running the ReSharper extension, the VS extension, MSBuild task, etc.
But "don't use it" isn't really the best solution. Do you have any better ideas for a solution? Should the ReSharper extension automatically hide warnings if the language isn't available? Even though that doesn't help with the other ways of running StyleCop?

Good question, @citizenmatt.  It would be nice if StyleCop checked for Office 2013 and fell back to 2010?  I'm not sure how much effort this change requires, and given that Office 2016 was announced today it might be worthwhile supporting the latest 2-3 editions out-of-the-box?

I'd agree that we should support Office 2016 and Office 2013, although beyond security updates I can't see any justification as a developer to move to a newer version of Office so we should continue to support Office 2010.
I'd extend that justification to Office 2007, but we don't support it already so I see no reason to support it now when it's only got two years of extended support to go.

@citizenmatt I think it's completely ok for the StyleCop plugin to propose the usage of ReSpeller. StyleCop shouldn't be tied to any office installation anyways.

@philippdolder Maybe I'm missing something; but remember that Stylecop is a tool that works on its own. People don't need R# to use Stylecop, so beware introducing a dependency on a R# plugin, when there is currently no requirement to have R# to use Stylecop.

@RichardReeves I'm just relating to the R# plugin for StyleCop. As things look now, the future are Roslyn Analyzers. That's why I think it's ok to not invest a lot in supporting a Feature in the R# plugin when there's another R# plugin that does about the same job. That was my first point.
The other is, agreeing with @citizenmatt, that the best would be to use an open source spell checker instead of relying on an office version. But if StyleCop is about to die sooner or later it's really not worth to put a lot of effort into new things.

@citizenmatt - looking at MSDN subscriber downloads, proofing tools don't exist for Office 2013 or 2016.  There is a beta that apparently doesn't work with 2007, 2010 or 2013, so that might be for 2016.  For now though it seems you'll have to install the 2010 Proofing Tools as a standalonee

@citizenmatt I've sent a pull request for the proofing tool to support Office XP-2013, on both 32 and 64bit machines.

Hi guys, two months no action on this ticket!? Do you know when it will be available?
Thanx for your hard work,
Markus

Oops. Should have closed this - it's available on the Extension Manager right now. Search for "StyleCop by JetBrains" (there are two versions right now, sadly. The other version is buggy and closed source, and the author isn't responding to contact. Hopefully we can merge in the future).


test demo on helm

What do these changes do?

Related issue number

Fixes #2172

Codecov Report

Merging #2412 (100f1ee) into main (0491d27) will decrease coverage by 32.51%.
The diff coverage is 4.34%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2412       +/-   ##
===========================================
- Coverage   72.43%   39.93%   -32.51%
===========================================
  Files          88       88
  Lines        9760     9771       +11
===========================================
- Hits         7070     3902     -3168
- Misses       2690     5869     +3179

Impacted Files
Coverage Δ

...on/graphscope/tests/kubernetes/test_demo_script.py
75.65% <4.34%> (-5.91%)
:arrow_down:

...ython/graphscope/tests/unittest/test_cython_ast.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_serailaize.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

python/graphscope/tests/unittest/test_lazy.py
0.00% <0.00%> (-96.22%)
:arrow_down:

python/graphscope/tests/unittest/test_app.py
0.00% <0.00%> (-96.18%)
:arrow_down:

...thon/graphscope/tests/unittest/test_scalability.py
0.00% <0.00%> (-96.16%)
:arrow_down:

...hon/graphscope/tests/unittest/test_create_graph.py
0.00% <0.00%> (-92.89%)
:arrow_down:

python/graphscope/tests/unittest/test_graph.py
0.00% <0.00%> (-85.92%)
:arrow_down:

python/graphscope/tests/unittest/test_context.py
0.00% <0.00%> (-81.36%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0491d27...100f1ee. Read the comment docs.


manager does not keep last 3 images as per doc

https://github.com/osism/openstack-image-manager/issues/51 says the last 3 images are kept. The documentation as well.
Running tox -e manage -- --deactivate --yes-i-really-know-what-i-do deactivates every image except the latest one.
This is not the expected behavior.

The behavior i expect/want is that the manager keeps the latest image in "public" visibility and the 2 images after that in "community" visibility. Everything else is deactivated/deleted/hidden.


Would like a benchmark tracking install size of hello_world

Including after extracting icudata.
We also get asked about install-size occasionally: https://github.com/flutter/flutter/issues/16833#issuecomment-387019591

Yes, yes it does!

Oh actually no, my bad. We have download size, not install size.


[Event Request] CU1012 "Job Jnl.-Post Line" - procedure Code()

------- ADD PARAMETER : NextEntryNo ---------

    [IntegrationEvent(false, false)]
    local procedure OnAfterRunCode(var JobJournalLine: Record "Job Journal Line"; var JobLedgEntryNo: Integer; var JobRegister: Record "Job Register"; var NextEntryNo: Integer)
    begin
    end;

@AlexanderYakunin This fix is urgent, our client is stuck on validating his purchase invoices. Can we have this fix in CU5 (Update 17.5) please ?

Please let us know country code of your customer and is this cloud or on prem?

Country code : FR and our client is on prem.

Unfortunately, it is late to add any fix to 17.5, as deployment already started. We can add this fix to 17.x immediately, and we can hotfix 17.5 using ICM ticket just after release. The problem is how you can get it for your on prem customer? Do you know?

Currently with VSCode, we are using the Base application version "Microsoft_Base Application_17.4.21491.21531.app". Do you think you can update your app before version 17.6 ?

Absolutely, it will be part of 17.6.

Can we have the fix before the release of 17.6 in early April ?

You can make fix yourself, if you work with base app code and can compile app. If you want to get the fix earlier, you need to check with technical support if this is possible and how to do that and create hotfix request.


favicon is outdated

Favicon is using an old version, needs to be updated.

Additionally, here are some considerations to take into account when updating favicon:

maskable icons
svg prefers-color-scheme
prefers-color-scheme
svg/favicon options


SUBGRAPH: Prove that 38 and 42 are equivalent

claim

propose PR #38

propose PR #39 (resolved conflict)


Fix CI with git diff

There seems to be a regression in the way git diff works when 2 path are given
Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

warning: Not a git repository. Use --no-index to compare two paths outside a working tree

Where do you see this warning? And why? Aren't we in a git repository?

In CI.
https://github.com/prometheus/prometheus/actions/runs/4123425393/jobs/7121429824
Look at some recent PRs which are all showing CI failures.

fixed in golang builder.

What was the issue?  I didn’t understand the fix.


Added .md file extension to dishwasher salmon

Previously it was just a file with no extension. Now that it's .md github will display it in a nice looking format.
Perhaps someone should write some sort of test to make sure recipes have the .md file extension.

I've added another recipe to my branch, closing this PR in favor of opening a new one.


Support parallel build of wheels for multiple platforms

Description
When one targets many platforms, the builder can take quite a while as it needs to do each platform in sequence.
Desired behavior would be to:

run in parallel with n tasks
n being by default the amount of CPU cores (ideally supporting cgroups to run in k8s)
n being configurable via a flag e.g. --parallel=<worker count>

Under the hood asyncio can not be used to IO being blocking by underlying libraries, so a executor pool would be the way to go.
References
No response

Releasd in https://github.com/timo-reymann/python-binary-wheel-builder/releases/tag/3.7.0


add: example on training mlms from scratch on tpus.

Colab Notebook:
https://colab.research.google.com/drive/1wHz14lg93dmGsMu_RZoUWFwdVxBWX9Xe?usp=sharing
Cc: @RocketKnight1

@fchollet thanks for your comments and I just addressed them!
Regarding https://github.com/keras-team/keras-io/pull/1381#discussion_r1199820427, I think it needs a separate design discussion which we'll keep in mind.

@fchollet should be good for you to take the reigns here!


Where did you get 100 Gb of ram

are you using some google collab or something?

I used https://vast.ai/
Their servers aren't quite as reliable or secure as regular cloud providers but they are much cheaper.
But also, I'm working on a version of the training script that will uses less resources! Stay tuned

Piggy-backing on this, are there any hardware requirements beyond a large chunk of RAM? I ask because this seems like a lot of fun to run through, and I run a rather beefy server architecture at home (I work in IT, and I'd rather run my own cloud than use someone else's, for labs and messing around with stuff).

I could be completely wrong but I think no gpu is required to run this training currently.
Those specs are better than what I am running on so you should be able to run it no problem

Joking Tone
100GB of RAM? Those be some Rookie numbers. :P

Piggy-backing on this, are there any hardware requirements beyond a large chunk of RAM? I ask because this seems like a lot of fun to run through, and I run a rather beefy server architecture at home (I work in IT, and I'd rather run my own cloud than use someone else's, for labs and messing around with stuff).

The more CPU's you have the more instances of training you can do (by adjusting num_cpu in run_baseline_parallel.py, I managed twice the amount of threads but your mileage may vary, adjusting that num_cpu higher or lower does cause the RAM usage to go up or down respectively, I'm running fine with num_cpu at 24 with a 12 thread CPU and 32GB of RAM).

Piggy-backing on this, are there any hardware requirements beyond a large chunk of RAM? I ask because this seems like a lot of fun to run through, and I run a rather beefy server architecture at home (I work in IT, and I'd rather run my own cloud than use someone else's, for labs and messing around with stuff).
My ESXI server has 28 physical cores (56 threads), and 192GB of RAM, but no descrete GPU. Is that workable, or do I need a dedicated GPU to run the training?

As the code stands CPU and RAM is needed, and it doesn't touch the GPU. So you could set your num_cpu to 28, and be golden. Maxing out my cores to 24, I only use about 90GB of RAM when things are going. I set my cores to 30 and it maxes out my CPUs, but only went to about 105GB of RAM used. So you should be golden.

Piggy-backing on this, are there any hardware requirements beyond a large chunk of RAM? I ask because this seems like a lot of fun to run through, and I run a rather beefy server architecture at home (I work in IT, and I'd rather run my own cloud than use someone else's, for labs and messing around with stuff).
My ESXI server has 28 physical cores (56 threads), and 192GB of RAM, but no descrete GPU. Is that workable, or do I need a dedicated GPU to run the training?

As the code stands CPU and RAM is needed, and it doesn't touch the GPU. So you could set your num_cpu to 28, and be golden. Maxing out my cores to 24, I only use about 90GB of RAM when things are going. I set my cores to 30 and it maxes out my CPUs, but only went to about 105GB of RAM used. So you should be golden.

Thank you!

Thanks for sharing! I'm wondering if you used Docker to train your model in the cloud or did you take another route?

I can almost guarantee that I can bring the RAM usage way down... porting it now, will need a bit of time. CPU cores will still be non-negotiable, the env is slow. 50 steps/second/core more or less

Found it! https://github.com/PWhiddy/PokemonRedExperiments/blob/fa01143e4b8d165136199be7155757495d16e56a/baselines/run_baseline_parallel.py#L62
n_steps is the number of frames per environment that you are keeping in memory. So 2048*8 for each of 44 environments... 720,896. Napkin math says 44 GB of observations without any optimizations. That batch size is not unheard of in RL, particularly for long games, but probably it can be made lower.

Okay, I got it training with 8GB of RAM. Will see if it learns anything

For all in this thread, the new script run_baseline_parallel_fast.py trains much faster and only uses 15-20G of memory!

How long does a training session useally take?, Or do you just stop it and try the run_pretrained after? (Sorry new to this, but want to join in this fun!!)

How long does a training session useally take?, Or do you just stop it and try the run_pretrained after? (Sorry new to this, but want to join in this fun!!)

This is a trick question/answer.
(Please note I'm training my AI differently then most)
With running 24 cores(instants of the game) with ep_length at 8192 * 10, it takes just over an hour to get a session done. From there you can let the AI keep running another session, or press Control +C to stop it. From there you have to edit the to watch a run with your session folder and your Step file.
Normally starting a new training session with 2048 * 10, you should see your AI start to get the first gym badge. From there you let it keep training, and it gets better at doing it.
The current hangup is Mount Moon, but everyone are trying to find the missing key for this.

How is the _fast.py speeds up the training & reduces down the memory requirement so much? Can you suggest what is the trick here?

In the parallel_fast.py file, what is the tricks which speed up the training?
I noticed that the batch_size shrinked by 4x and num_cpy shrinked by 3x, is there some other tricks that is adopted?

That's actually the mini batch size. The normal batch sized is mathed into the system which also used the ep_length.
With the smaller batch size, it can look at the data fast then looking at the larger 512.


DFBUGS-1199: [cephcsi] RBD images backing VolumeGroupSnapshots cannot be flattened

Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:

Kubernetes links that explain why the change is required
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change

Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow
guidelines in the developer
guide.
[ ] Reviewed the developer guide on Submitting a Pull
Request
[ ] Pending release
notes
updated with breaking and/or notable changes for the next major release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)

/cc @iPraveenParihar @Nikhil-Ladha @nixpanic

@Rakshith-R, can you fix the lint issue
e2e/volumegroupsnapshot_base.go:268:7: hugeParam: v is heavy (80 bytes); consider passing it by pointer (gocritic)
func (v volumeGroupSnapshotterBase) CreateVolumeGroupSnapshotClass(
      ^
e2e/volumegroupsnapshot_base.go:291:7: hugeParam: v is heavy (80 bytes); consider passing it by pointer (gocritic)
func (v volumeGroupSnapshotterBase) CreateVolumeGroupSnapshot(name,
      ^
e2e/volumegroupsnapshot_base.go:361:7: hugeParam: v is heavy (80 bytes); consider passing it by pointer (gocritic)
func (v volumeGroupSnapshotterBase) DeleteVolumeGroupSnapshot(volumeGroupSnapshotName string) error {
      ^

I think we did fix it in upstream 🤔, lets cherry-pick that as well?

I think we did fix it in upstream 🤔, lets cherry-pick that as well?

Yes, please cherry-pick that commit too.

I think we did fix it in upstream 🤔, lets cherry-pick that as well?

Yes, please cherry-pick that commit too.

The actual commit that makes this change, changes a lot of other stuff as well a17fef0
The pr with required commit contains a total of 7 commits. ceph#5021

Indeed, only the commit is needed, not the whole PR.

I would like to avoid including such large amount of changes
I have included the particular changes in one of the current e2e commits PTAL

Ok, the commit only affects the e2e suite, so it would have been ok to include completely. This approach is fine too though. Thanks!
/lgtm


Show draft projects (if any) on user's home page

This will be part of solving https://github.com/sillsdev/languageforge-lexbox/issues/855.
The home page currently shows the projects that the logged-in user is a member of. We want to extend that to show draft projects as well, with a "draft-project" CSS class applied so that we can style them differently. For now, that CSS class will just apply border: thick double red; but in the future it will do more. (In LexBox, a "draft project" is what gets created when a user submits a project-creation request but doesn't have project-creation rights. Once an admin approves the project-creation request, the draft project is deleted and a "real" project is created with the same GUID and project code.)
To implement this, you'll need to do several things:

Look in backend/LexBoxApi/GraphQL/LexQueries.cs for the MyProjects query, and create a similar one called MyDraftProjects which will return a list of DraftProject entities rather than Project entities.

Note: Draft projects do not have a list of members, so the Where clause involving the Users property will be different; for draft projects, there is a single project manager assigned. A draft project should appear in a user's homepage only if that user is the assigned project manager.

In frontend/src/routes/(authenticated)/+page.ts, you'll need to add a GraphQL query to fetch any draft projects the user owns, and return that list in a new draftProjects property from the load function.
In frontend/src/routes/(authenticated)/+page.svelte, you'll need to show draft projects (if any) before the list of "real" projects.

Eventually, the list of draft projects on a user's home page will allow the user to click on any draft project to delete it (thereby cancelling the project-creation request), but that is out of scope for this task. For now, just ensure that any draft projects appear in the user's home page, at the start of the list, apply a "draft-project" CSS class to them, and make that CSS class create a red double border around the draft project's visual representation.

We have a code-generation system set up for GraphQL, that allows it to be type-checked in Svelte code. After you make any changes to GraphQL queries or mutations in C#, you should run task api:generate-gql-schema. This will recreate the auto-generated frontend/schema.graphql file, which is used for type-checking the GraphQL code in Svelte. When you commit your C# changes, make sure you also commit the changes to frontend/schema.graphql in the same commit.
Whenever you edit any GraphQL query, you'll notice that the entire query immediately gets a red wavy line underneath the entire thing, indicating a type error. That's because one of the things the type-checking system does is store the string values of GraphQL queries, and the one you just edited (or created) no longer matches the string that was stored in the type-checking system. To fix that, cd into the frontend directory and run pnpm build. (You can also run task ui:build from the root directory, but doing it via pnpm gives nicer color output). Once you run pnpm build, your GraphQL queries should no longer show red wavy lines throughout. (Unless you've actually made an error, such as requesting a property that doesn't exist, e.g. requesting the users property on a draftProjects query would be an error).
P.S. In GraphQL terminology, a "query" is a request that does not modify data, similar to an SQL SELECT statement. A "mutation" is something that does modify data, similar to an SQL UPDATE statement. Note that in GraphQL, both queries and mutations will return data; typically, we set up mutations to return a copy of the data they just modified, which allows the client-side GraphQL cache to be automatically updated.

Some design ideas:

make the card and text elements muted / greyed out
add the text "requested on [date]" or simply "requested"
another text idea: "requested on [date] and waiting for approval"

I like these clock icons 🤓
But there are lots of tempting icons 😆

https://icon-sets.iconify.design/mdi/clock-check-outline/

https://icon-sets.iconify.design/mdi/progress-clock/
Or
If we replaced all the draft icons with something like this (none of us love the current icon, but it's just challenging to pick a great one):

https://icon-sets.iconify.design/mdi/receipt-text-clock-outline/

https://icon-sets.iconify.design/mdi/book-clock-outline/
...then we don't really need another clock icon and it might look nicer to put "awaiting review" in a little badge:
Something like this (the orange/warning border is optional, but it's kind of cool 🤷  ):

I like the mockup Tim made.
FYI we already have a draft icon on the admin page, so whatever we end up doing should be consistent with that. I think the current icon makes sense, so I'd vote for that one.

In @myieye 's mockup, there is no draft icon after the title name.  Did you decide to drop that intentionally?
I also like having a clock icon next to the text "awaiting approval".

@megahirt Sorry for the confusion. No, I didn't leave the icon or anything else out intentionally. I was just trying to demonstrate the badge idea. I should have made that more explicit.
Regarding the draft icon.
What we currently have is this: (scroll)

Personally, I don't feel like it communicates very much.
I think this: (receipt-text-clock-outline/)

Looks more like a ticket that's been submitted
Explicitly communicates waiting (for approval)

That's all the cents I've got.
I think team CNX should just take it from here.

I agree that the scroll isn't great (I didn't want to spend hours searching at the time), and receipt-text-clock-outline is better.