How to handle pagination

Any example with pagination ?

Another small thing, After logged in, for a second if time instagram home page is being visible, I thought that didstartprovisionalnavigation or didReceiveServerRedirectForProvisionalNavigation should be used to pop to previous controller before redirecting, but i cloud not make it work actually. Any ideas about it ?

Every time we scroll down in our devices to load more data (followers, photos, conversations...), that's called pagination.
When you get Instagram's response, it may contain a next_max_id key, which means there is more data you can load. In order to paginate, you will have to pass that param to the function.
Here is an example:
try? handler.getUserMedia(for: username, paginationParameter: PaginationParameters.maxPagesToLoad(maxPages: 10), completion: { (result) in
    if result.isSucceeded {
        let medias = result.value!
        medias.forEach({ (media) in
            media.items!.forEach({ (item) in
                // get media url or something else here.
            })
        })
    }
})

Unfortunately I’ve made a mistake when developing pagination functions. When you set a maxPages value to pagination, it will receives all data first, then it will returns data to you. And it's not efficient.
I will release a fix for pagination functions to make them more efficent.
If you don’t know how many pages may exists, you can use Int.max value, the function will stops automatically when pages finished.
For your second question,
it's possible to add 2 more functions to InstagramLoginWebViewDelegate protocol.
For Example:
public protocol InstagramLoginWebViewDelegate {
    func userLoggedSuccessfully()
    func webViewFinishedToLoadUser(sessionCache : SessionCache, handler: APIHandlerProtocol)
    func willStartLoading()
    func didFinishedLoading()
}

public override func webView(_ webView: WKWebView, didStartProvisionalNavigation navigation: WKNavigation!) {
    loginDelegate?.willStartLoading()
}

public override func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) {
    loginDelegate?.didFinishedLoading()

    self.fetchCookies(completion: { (cookies) in
        let instagramCookies =  cookies?.getInstagramCookies()
        self.isUserLoggedIn(instagramCookies: instagramCookies!)
    })
}

Unfortunately I’ve made a mistake when developing pagination functions. When you set a maxPages value to pagination, it will receives all data first, then it will returns data to you. And it's not efficient.
I will release a fix for pagination functions to make them more efficent.

when will you fix pagination? How can we help? @TheM4hd1

@canaksoy I'll fix it this week.


Update the Royal Arms graphic in footer (v4.x)

Updates the Royal Coat of Arms in the GOV.UK footer component.
Changes

Replaces the PNG versions of Elizabeth II's Royal Arms with Charles III's Arms: govuk-crest.png and<EMAIL_ADDRESS>

Not pushing for a developer review on this one as the only changes are image assets.


chore(deps): Use Trivy instead of defsec for deps

Merging defsec into Trivy (PR: https://github.com/aquasecurity/trivy/pull/6006) requires some changes to trivy-aws which are contained in this PR.
This and this PR is both require each other to be merged.

Close in favor of https://github.com/aquasecurity/trivy-aws/pull/99


Constantly Getting Disconnected

Most of the time when opening a lesson on the web site by clicking the open button to open the lesson in the IDE. 9 times out of 10 the popup of Loading Remote Code appeats then it gets disconnected. Any help would be most appreciated as it is most frustrating.

Suggest closing this issue as it appears to be an issue for the Learn IDE


Change UnixDate properties to *UnixDate

Fixes bugs related to null dates that were converted to zero-value Unix times (which end up being Jan 1, 1970).  See https://interventionengine.atlassian.net/browse/IE-29.

Found one other bug, which I'm throwing into this PR: Incorrect URL for RxNorm.


When no items are added to offline edit, Text is misplaced

Checklist

[x] Bug Report - The issue you are reporting might be there already. Please search on the issues tracker before creating or reporting an issue.
[x] Before reporting, please ensure (if you can) that you have tested it with the latest (dev) version of the software.
[x] Don't forget to tag your issue, it makes it easier to discover.
Summary:

When no items are added to offline edit, Text is misplaced
Steps to reproduce:
1.Go to offline edit
2.See the error if you haven't add any items
Expected behavior:
The test view must be in a proper position
Device and Android version:
Asus 3s max.OS 7.1
Screenshots:

I want to work on this issue


Remove node-shell tool from cloudshell image

See issue: https://github.com/cloudtty/cloudtty/issues/202

Sorry to see this pr so late.
LGTM


Webpack CSS-build behaves differently in production than in development

Has anyone had an issue with CSS working differently in development than in a production build?
I refactored a large App to CRA, it had a single index.scss entry point which I just import in App.js.
// index.scss
@import "somefile.scss";
@import "someotherfile.scss";

// App.js
import "./index.scss";

Well, I'm noticing that when running npm start the app works perfectly in development. But when running npm run build and then deploy it to a staging environment, the app has slight visual differences, as if "somefile.scss" had higher specificity over "someotherfile.scss" (the opposite should be true). Does webpack do something different when building stylesheets for production?
I do not know how to report this as a bug, I can't reproduce with a small app, so I'm wondering if anyone else is having this issue. I've seen multiple similar issues in other repos but not CRA.
Edit
I'm using<EMAIL_ADDRESS>

I wonder, maybe I could debug this if there is a way to make CRA get a dev-build and a prod-build without all the minifying from webpack on production builds, this way I could compare the outputs and go from there.

I've ran into this issue before.  You can test this by go into node_modules/react_scrripts/config/webpack.config.js and mess around with the configuration to see what works for you.

@bugzpodder

I've ran into this issue before.

Do you mean the CSS issue? If so, do you remember more details about it (e.g. did you work around it or found the issue)?

You can test this by go into node_modules/react_scrripts/config/webpack.config.js and mess around with the configuration to see what works for you.

I'll try that 🤞

For example:
https://github.com/facebook/create-react-app/pull/4706
https://github.com/cssnano/cssnano/issues/661

Thanks @bugzpodder! I'm debugging and will report my findings in 10 minutes.

I found the difference :: not a webpack/CRA bug (per se).
My issue is actually outside of index.scss and happens because our app is lazy-loading some other styles and manually moving them into a child iframe.
The difference between dev and production build is that webpack seems to bundle the lazily-loaded-stylesheets as chunks and loads them using <link> elements, while in development, it uses <style> elements and injects as text.
Like so:
<!-- production -->
<link href="1.chunk.123123.css" rel="stylesheet">

<!-- development -->
<style>
  .code {}
</style>

Long story short: the app was not finding the style tag to be moved and is conflicting with the top frame styles.


adjust handling of exit code from binary (update)

Factorio v 0.12.4 fixed the incorrect exit code on update errors, for completeness I want to adjust the script to use this properly.

leaving "as is" to not mess with backwards compatibility

decided to screw backwards compatibility, latest version now uses the exit code alone


Add 'neovim-plugin' as topic to the GitHub repository

It seems that I'm not authorized to add topics. Who can do this?

I see it is added now.


can't getting token on username and password basis.

I read this document of yours, located at https://github.com/casdoor/casdoor-python-sdk. In this document, you have implemented a way to obtain a token based on a username and password.
However, I am unable to obtain the token.
I am encountering an error. Please refer to the screenshot below for further details.

Answered here: https://github.com/casdoor/casdoor/issues/2038

Thanks for update its work for me.
[cid:af805498-a279-4d23-8582-00955bc59667]Hello World!
Nihal Gurjar
Software Engineer
Cell:<PHONE_NUMBER>
www.47billion.comhttp://www.47billion.com
Read: Bloghttps://47billion.com/blog  |  Follow us: Linkedinhttps://www.linkedin.com/company/47billion  |  Twitterhttps://twitter.com/47Billion  |  FBhttps://www.facebook.com/47Billion

From: hsluoyz @.>
Sent: Tuesday, July 4, 2023 8:54 PM
To: casdoor/casdoor-python-sdk @.>
Cc: Nihal Gurjar @.>; Author @.>
Subject: Re: [casdoor/casdoor-python-sdk] can't getting token on username and password basis. (Issue #48)
Answered here: casdoor/casdoor#2038https://github.com/casdoor/casdoor/issues/2038
—
Reply to this email directly, view it on GitHubhttps://github.com/casdoor/casdoor-python-sdk/issues/48#issuecomment-1620442365, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AY4T4EXDYYY6THNXRX3XAMDXOQYUNANCNFSM6AAAAAAZ5XQDUA.
You are receiving this because you authored the thread.Message ID: @.***>
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


Escape subnormal values

Currently we don't escape subnormal values when generating image data. In sampler read tests, we use != to check the two values even when it is floating-point data, which requires the two values are bitwise equal. However, a sampler might flush subnormal values, causing the test case to fail.
In this patch, when generating random image data, we escape subnormal values.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Section 8.3.3 of the C spec specifically allows sampling to flush denorms, so this change seems to be long overdue.

Reviewing

A bit of spec archaeology, for the Khronos folks:

A fix similar to this one was proposed in Bugzilla 16324.
The spec changes were discussed in GitLab issues 30 and 113.

I don't have privileges to merge the PR. Can someone do it for me? Thanks!

It'd be nice to get one more approval before merging - @silverclaw or @lakshmih maybe?
If not, we'll aim to merge in our next teleconference, on Tuesday (June 4th).

Thanks!  Merging.


Cannot open Plugins => LDAP settings page

Dashboard output
Internal Error.
Oops! Looks like something went wrong!
/admin/plugins/office_ldap
Failed to lookup view "office_ldap" in views directory "/opt/nodebb/build/public/templates"
log output
4/10 11:05:40 [3473] - error: /assets/templates/office_ldap.jst
Error: ENOENT: no such file or directory, open '/opt/nodebb/build/public/templates/office_ldap.tpl'

Same issue here.. Any solution for this. looks like this is with newer versions of noddebb


README: tighten up the readme

Hello @jazzdan, @dbentley,
Please review the following commits I made in branch nicks/ch3888/readme:
95a2324ba6ed419503df939e4ce327cd2cf2b7d0 (2019-11-15 18:17:20 -0500)
README: tighten up the readme
This tries to tighten up the messaging a lot, and refer
people to other docs when they have questions.
6b1573980332956056af86c510c9aef376f92dc1 (2019-11-15 17:40:25 -0500)
README: update readme with github community health files
github has special handling for certain file names, so let's change
ours to be consistent
https://help.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file-for-your-organization

merging all this stuff so that it's ready for tomorrow. happy to address any comments in a follow-up PR


Internal Server Error when making GET request to api_capabiltities endpoint

I'm submitting a ...

[X] bug report
[ ] new feature / enhancement request
[ ] improvement request (usability, performance, tech debt, etc.)
[ ] other

Traffic Control components affected ...

[ ] CDN in a Box
[ ] Documentation
[ ] Grove
[ ] Traffic Control Client
[ ] Traffic Monitor
[X] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[ ] unknown

Current behavior:

When making a GET request to /api_capabilities?httpMethod=DOESNTEXIST the response returned is:
HTTP/1.1 500 Internal Server Error
{
    "alerts": [
        {
            "text": "Internal Server Error",
            "level": "error"
        }
    ]
}

This only occurs when using the optional httpMethod parameter with a value that does not exist.
Expected / new behavior:

Should return an empty response:
HTTP/1.1 200 OK
{
    "response": null
}

Minimal reproduction of the problem with instructions:

Anything else:

I'd say the response in this case should be an empty array ([]), not null.

I'm also not sure how Perl handled it. It possibly returned a 4XX error saying that you didn't give it a proper HTTP request method. Need to look into that.

It seems the Perl version of the handler actually didn't support that query parameter at all and it's currently undocumented, so its handling is pretty much whatever we want at this point. Because of that I'm gonna label this an improvement.


Problem uploading image

Apologies if this has been discussed already, but I couldn't find any issues regarding image upload.
I'm trying the straight demo app, with no changes (except obviously for the Twitter API credentials).  After successfully logging in, I'm trying to upload an image.  Choosing a photo works.  But tapping Upload image yields a problem.
I've traced it to the initializeUpload method in Twift+Media.swift line 120.
This code is throwing an exception
  fileprivate func initializeUpload(data: Data, mimeType: String) async throws -> MediaInitResponse {
    guard case .userAccessTokens(let clientCredentials, let userCredentials) = self.authenticationType else {
      throw TwiftError.WrongAuthenticationType(needs: .userAccessTokens)
    }

Is this an OAuth 1.0/2.0 issue?  Tweeting straight text does work, from the same login and app, and the code to simply post a text tweet doesn't have the same check for userAccessTokens.
Thanks, -- Atul

Never mind, this is fully explained by media uploading not yet supported in the Twitter v2 API.


Delete composer.lock

Not suggested for a library

composer .lock file and support for PHP7.2 (by phpunit 6.1 and use of TestCase)


Patch helps to overcome login issue.

Sometimes the console via ssh is not connected and Login attempt fails, This could be due to network issue. Attempting to login for 5 times if the connection is not established in one go.

I have added the PR to test with CI jobs, we will merge only if everthing goes fine

@abdhaleegit @TasmiyaNalatwad any update on CI run result?

@PraveenPenguin @abdhaleegit , This needs more enhancement. I see the function call self.cv_SYSTEM.console.get_console() is not coming out of this function and remaining there forever time as trying to login with credentials. I am trying to give a timeout to this function call and then try logging in for few times like 5 times in a loop.
Atleast it must fail if the connection is not happening and come out with some connection issue message


Timestamp Changes

This PR addresses issue #20 . It changes timestamp format to include milliseconds and timezone, and renames field name from timestamp to ts in returning JSON

I don't believe these changes match the requested format. for n=3
Implemented
%Y-%m-%d %H:%M:%S.%3N %Z
requested
%Y-%m-%dT%H:%M:%S.%3NZ
Further, is the code assuming the time is GMT?

@bogdanadrianmarc @andrew-pickin-epi  We can coerce a Ruby DateTime to UTC with the .utc method. So we could ensure that all timestamps are UTC by:
def process_timestamp(timestamp)
  format_datetime(timestamp.utc)
end

I guess the question is: what should be the desired behaviour when a log message is emitted during BST?


dismissalTransitionWillBeginCompletionHandler not called?

Hi,
I was really glad to see that dismissalTransitionWillBeginCompletionHandler is present but as I see from the implementation it is not called from any point in the framework. I have implemented the callback just to see that it doesn't work :(

Thanks for leting me know, fixed :)


Convert "day of year" to "month" on x axis

Need to convert day of year to month on x-axis

Looks promising:
https://jakevdp.github.io/PythonDataScienceHandbook/04.09-text-and-annotation.html


Loremaster spell secret not working

Describe the bug
When picking a loremaster spell secret, the list of spells that can be selected is the same as the base class's spellbook. For example, an arcanist taking spell secret can take any spell on the arcanist spell list but none of those only available on the cleric spell list like cure or inflict spells.
Found issue on game version 1.1.0 and mod version 1.9.1b
To Reproduce
Steps to reproduce the behavior:

Level up a spellcaster class to be able to pick loremaster.
Level up loremaster to gain a secret and pick one of the other classes spell list.
Notice the spell selection is that of your base class, not the selected class secret.

Looks like I messed up which list was used when fixing the last of the lore master edge cases, will be fixed in the next build


UrlPath problem

I have an app that can be accessed from two different URLs (www.example.com/app1 and www.example.com/app2). The UrlPath parameter requires including the path base. Do I have to configure 2 Tus instances? Could we have a UrlPattern instead so that all URLs that look like "/[^/]*/files/" would be handled by Tus.

Not a bad idea at all. It would need to be backwards compatible with the current way of doing things. Maybe a regex or a callback function, something like bool ShouldHandleRequest(String uri). Note that the regex also needs to handle requests to files such as /files/asdfg
If you provide med with a PR I would be happy to merge it. Just make sure that all tests work and add new tests for the new functionality.

Another solution that is probably simpler to use than regex/callbacks is to update the URL parsing code to better support virtual paths in the URL (e.g. /app/files).
Code is located here: https://github.com/tusdotnet/tusdotnet/blob/master/Source/tusdotnet/Extensions/ContextAdapterExtensions.cs

Btw you can solve this without changing the code. The configuration factory used can return different values for the path property depending on which of the sites are being accessed.

The comment above was written while in transit. To clarify: The func that you provide to UseTus will be executed on each request and will be provided the request as the only parameter. You can then determine from that request what UrlPath to listen to.
Example:
app.UseTus(context =>
{
	string urlPath;
	if (context.Request.Path.StartsWithSegments(new PathString("/app1/files/")))
	{
		urlPath = "/app1/files";
	}
	else
	{
		urlPath = "/app2/files";
	}

	return new DefaultTusConfiguration
	{
		UrlPath = urlPath,
		....
	};
});

Yes, you're right, thanks!


Get signoff for AWS to CSS mapping

Describe the issue
The Cloud Security Schedule (CSS) was an evolutionary outcome of a brick and mortar schedule and may have some gaps with respect Cloud Service Providers.  There is a desire to improve the CSS.  A CSP when signing up must comply with either BC standards or equivalent GC Protected B Medium Medium (PBMM), Fedramp, CSA*, Schedule G.
Understand the current compliance against cloud security schedule against AWS.  AWS has existing reports, SOC 2 being one of them that may contain helpful security rankings we can map against.
Value to the product/MVP?
It would help with onboarding further services to cloud services, including MVP, and any early adoptors.
Which Sprint Priority is this issue related to?
Additional context
Definition of Done:

Reviewed by Gary Perkins
Alignment with ISB Management

This high level work has been completed. and published internally.


Moving to adminplus locks out superuser from editing

When I add SimpleAdminConfig in settings.py, and set admin.site to a new AdminSitePlus in urls.py, I get the message "You don’t have permission to view or edit anything." when logged in as a superuser.
If I revert those two edits, switching back to the standard admin, I can see and edit as usual.
Happy to help debug but not sure where to start.

And the problem is if you use the @admin.register decorator rather than admin.site.register().  This sounds like a bug so I won't close this out.


feat: add new documentation generator to generate deployment settings file documentation

Issue #, if available:
DOTNET-6152
Description of changes:

Created a new project that is dedicated to generating documentation. At the moment, the project only has a single generator dedicated for generating Deployment settings file documentation. The generator uses Server Mode to retrieve all available recipes and lists the settings in those recipes.
Added 2 new APIs in RecipeController to be able to list available recipes as well as recipe option settings. I did not modify the existing API because I didn't want to make that API bloated and affect it's performance as it is being used by the Visual Studio toolkit.
Added 2 new plugins to mkdocs that enable searching the documentation as well as enable advanced navigation options such as listing markdown files inside directories without needing to define them explicitly.
Updated the doc generator GitHub workflow to run the new documentation generator project before calling mkdocs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Currently, the ListAllRecipes API and GetRecipeOptionSettings API are part of server mode. However, we also have a story in our backlog to improve the discoverability of recipes and option settings via the CLI as well.

DOTNET-6180 - Discovering Deployment Recipes
DOTNET-6181 - Discovering Recipe Option Settings

IMO, the core logic thats makes up these 2 APIs should be defined inside the Orchestrator. This way the CLI and the server mode refer to a centralized location and we can avoid code duplication when we tackle the above mentioned stories.

The APIs you mentioned are extending the already existing API GetRecipe which is being used in the VS Toolkit. Our direction moving forward is to leverage server mode even from the CLI, as in the CLI should be talking to server mode to get information, which would ensure our consistency with the features we provide to the toolkit. If when implementing the tickets you linked we decide that we need to add heavier logic then we would move some things around, but for now I would like to leave these APIs in server mode.

Please do the following:

Move all recipes into a separate Recipes folder
In the "Deployment settings file" add a submenu for ease of reading, e.g. "What is a deployment settings file", "Example of deployment settings file", "How to create deployment settings file"
Add clear instructions on how to create a file and link to Recipes folder for schema.

Done


[Question]: Is there a way to integrate the Gallery Component with react-native-modal?

Summary
I've been trying to use it with react-native-modal to achieve the same result as the Twitter/Facebook Gallery, where I can close modal by swiping down. But every time I try to use it I end up having a conflict between swipes.
Is there a way to fix it? Or even achieve the result using react-native's own modal? Ty
Currently code, using the example provided
import React, { useCallback, useEffect, useRef, useState } from 'react';
import { Text, View } from 'react-native';
import { useSharedValue } from 'react-native-reanimated';
import { Gallery, type GalleryType } from 'react-native-zoom-toolkit';
import {
  getAssetsAsync,
  requestPermissionsAsync,
  type Asset,
} from 'expo-media-library';

import GalleryImage from './GalleryImage';
import { StyleSheet } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler';
import Modal from 'react-native-modal';

type SizeVector = { width: number; height: number };

const GalleryExample = () => {
  const ref = useRef<GalleryType>(null);

  const [assets, setAssets] = useState<Asset[]>([]);
  const [scales, setScales] = useState<SizeVector[]>([]);
  const [open, setOpen] = useState<boolean>(false);

  const activeIndex = useSharedValue<number>(0);

  const renderItem = useCallback(
    (item: Asset, index: number) => {
      return (
        <GalleryImage asset={item} index={index} activeIndex={activeIndex} />
      );
    },
    [activeIndex]
  );

  useEffect(() => {
    const requestAssets = async () => {
      const { granted } = await requestPermissionsAsync();
      if (granted) {
        const page = await getAssetsAsync({
          first: 100,
          mediaType: 'photo',
          sortBy: 'creationTime',
        });

        const pageScales: SizeVector[] = [];
        for (let asset of page.assets) {
          pageScales.push({ width: asset.width, height: asset.height });
        }

        setAssets(page.assets);
        setScales(pageScales);
      }
    };

    requestAssets();
  }, []);

  if (assets.length === 0 || scales.length === 0) {
    return null;
  }

  return (
    <View style={styles.container}>
      <Text>Open</Text>
      <TouchableOpacity onPress={() => setOpen(true)}>
        <Text>Open</Text>
      </TouchableOpacity>
      <Modal
        isVisible={open}
        style={styles.root}
        onSwipeComplete={() => setOpen(false)}
        onBackButtonPress={() => setOpen(false)}
      >
        <Gallery
          ref={ref}
          data={assets}
          keyExtractor={(item, index) => `${item.uri}-${index}`}
          renderItem={renderItem}
          maxScale={scales}
          onIndexChange={(idx) => {
            activeIndex.value = idx;
          }}
        />
      </Modal>
    </View>
  );
};

const styles = StyleSheet.create({
  root: {
    flex: 1,
    backgroundColor: '#000000',
    margin: 0,
  },
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
    backgroundColor: 'white',
  },
});

export default GalleryExample;

This is a problem that raised my attention as mentioned by a reddit user, the problem with swipes is that they are nothing but pan gestures with a set of let's call them "boundaries" and Gesture Handler by being nested within the modal will take a higher priority over the modal's touches.
At this precise moment I can not offer you a solution, however this will be addressed in the next release in the form of a onSwipe property capable of detecting all four directions.

Just Released version 2.0.1, give it a try it does the new onSwipe property you could use for this use case.

Just Released version 2.0.1, give it a try it does the new onSwipe property you could use for this use case.

Working flawless, thank you. Just a question to know if its possible, since I don't know too much of react native. Can I achieve an animation similar to Twitter/Facebook dismiss? When I scroll down it starts to move down and if I scroll pass a threshold, then it finishes the animation and closes?
Again, thank you so much for the new onSwipe property

@enzobocalon It's difficult to tell for me as I don't have such applications, if you can provide a video of what's that you're actively trying to achieve I may give a possible solution if any.

https://github.com/Glazzes/react-native-zoom-toolkit/assets/41443984/9bcd950b-1b3c-49e5-92d2-1b53beea8721
Something like this.

I see what you mean, that's definitively a common pattern among mobile apps and sadly for the moment that's something I have never done myself in previous projects in contrast to all the other features the library provides.
It may require some research and experimentation from my part, and at least for the moment I'd like to rest a couple for a while from this library, I'm pretty burn out from all the changes in this latest release, nonetheless this may be doable.

I understand. Again, thank you so much for the changes, specially for the onSwipe prop.

I've just released version 2.1.0 with the changes you mentioned, it also provides a callback you can use to animate the background based on the translateY value for instance.

Sorry sent you the wrong release, it was 2.1.0, but since it introduced a new bug by accident install 2.1.1 instead.

Working perfect. Thank you so much for your efforts


Remove the Venafi e2e skip

What this PR does / why we need it:
Set up new credentials inside the CI cluster. Tests are passing again!
FIxes https://github.com/jetstack/cert-manager/issues/2175
Release note:

Run e2e tests against Venafi TPP

/kind cleanup

Network errors :cry:

/retest

/retest

/approve
/lgtm


DRILL-7932: Update Hadoop to 3.2.2

DRILL-7932: Update Hadoop to 3.2.2
Description
Update Hadoop to the latest version of the 3.2.x branch and pick up some security fixes along the way.
Documentation
N/A
Testing
Run test suite

It looks like Apache Hadoop moved to Jetty 9.4 between 3.2.1 and 3.2.2. This change would require #2236 to be merged first.

@laurentgo Hi. Is this pull request no longer needed after the DRILL-7135 was merged?

Yes. I'm abandoning it


How to remain table column width during dragging?

I move row and its cells are collapsed close to each other. How to remain cell width the same as table column one?

relate with https://github.com/clauderic/react-sortable-hoc/issues/361


Update install script version for mmlspark

The older version of mmlspark install script fails when trying to pick up the conda environment with an error that looks like this:
/tmp/tmp2lnGXt: line 50: CNTK_WHEELS[$env]: Unknown conda env for CNTK: base
Traceback (most recent call last):
  File "/var/lib/ambari-agent/cache/custom_actions/scripts/run_customscriptaction.py", line 194, in <module>
    ExecuteScriptAction().execute()
  File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 329, in execute
    method(env)
  File "/var/lib/ambari-agent/cache/custom_actions/scripts/run_customscriptaction.py", line 179, in actionexecute
    ExecuteScriptAction.execute_bash_script(bash_script, scriptpath, scriptparams)
  File "/var/lib/ambari-agent/cache/custom_actions/scripts/run_customscriptaction.py", line 149, in execute_bash_script
    raise Exception("Execution of custom script failed with exit code",exitcode)
Exception: ('Execution of custom script failed with exit code', 1)

Upgrading the script version to 0.10 resolved the error.

@mawah @linya9191 Thanks for the update to the mmlspark script version. Don't think we need this PR anymore. I am closing this one.


use context.Context in the middleware

Add an extra parameters: ctx which will be a context.Context{} for communicating between middleware, i.e. a caching middleware reports a cache miss and the prometheus middleware can then report it by examining what's in the context.
Means remaining the current context.go Context to something else.

Done.


A few tests issues

while porting these tests I've found following issues, would like to report:

I've found that ebreak.S test runs c.ebreak instead, my gnu assembler selects smaller instruction ..
I used .option norvc to fix this.
All Privilege directory tests require  rvtest_mtrap_routine define. Is it selected automatically in RISCOF?
when I added this define to model_test.h, fence-01.S stopped to compile , assembler complained of missing mtrap_sigptr label ..

1. I've found that ebreak.S test runs c.ebreak instead, my gnu assembler selects smaller instruction ..
   I used .option norvc to fix this.

These tests aren't supposed to be compiled with the C extension enabled. However, this does seem like a valid problem and the .option should be added to the tests.

2. All Privilege directory tests require  rvtest_mtrap_routine define. Is it selected automatically in RISCOF?

3. when I added this define to model_test.h, fence-01.S stopped to compile , assembler complained of missing mtrap_sigptr label ..

Yes. The tests are configured based on the configuration of the implementation. The rvtest_mtrap_routine includes the trap handler for these tests. The mtrap_sigptr label is defined in the signature section for all the tests(here). I don't see why you are facing this error.

fence-01.S test is missing this code ...
BTW, where the #define rvtest_mtrap_routine should be selected?

fence-01.S test is missing this code ... BTW, where the #define rvtest_mtrap_routine should be selected?

It is intended to be defined via the -D argument of the toolchain.

all this is strange and inconsistent  - c.ebreak has this define inside the test source, but a few others including ebreak don't, why?
all tests, but fence have #ifdef rvtest_mtrap_routine , why?

all this is strange and inconsistent - c.ebreak has this define inside the test source, but a few others including ebreak don't, why?

This is probably an oversight while transitioning from the v2 to v3 of the framework. To get all the "privilege" tests to work, the macro was force defined at the start of the test. During transition, the macros in the other tests were removed but the c.ebreak remained. It should be removed from c.ebreak too.

all tests, but fence have #ifdef rvtest_mtrap_routine , why?

Other tests are mostly generated. This particular test was handwritten and possibly not updated over time.

a simple solution is to add .option norvc just after RVTEST_BEGIN in each test. Probably best solved in CTG wrt to the current test-suite.

The new arch_test.h does have .option norvc in the RVTEST_CODE_BEGIN macro

To put everything in one place:

ebreak.S  should now use the correct instruction ; tests now default to .option norvc in the RVTEST_CODE_BEGIN macro.
Tests that can potentially trap should define  rvtest_mtrap_routine in their RVTEST_CASE string as
;def rvtest_mtrap_routine. (****This is the way it looks now; this is inconsistent with the above statement
It is intended to be defined via the -D argument of the toolchain.*the ***
Tests that cannot trap should not have  rvtest_mtrap_routine defined; Fence and Fence.i  are examples of that.
We should be consistent on conditionalizing the trap signature with rvtest_mtrap_routine.
--- c.ebreak and ebreak tests should be updated to  remove the #ifdef  rvtest_mtrap_routine/#endif because  rvtest_mtrap_routine is already defined and they always trap. (though it is harmless)
The new trap handler should fix the issue of not compiling when rvtest_trap_handler is not defined

To clarify the current state:

ebreak.S now used the correct instruction
tests that trap (which are in the priv test directory) all define rvtest_mtrap_routine in their RVTEST_CASE string (including ebreak, c.ebreak and ecall) but should define it nowhere else
tests that don't trap do not define rvtest_mtrap_routine at all (e.g. fence and fencei)
tests should correctly compile when it is not defined.

This will be closed after all extraneous (but harmless)  #ifdef rvtest_mtrap_routine and matching #endif lines are removed from all tests.

Regarding these 3 specific problems listed in issue#292:

I've found that ebreak.S test runs c.ebreak instead, my gnu assembler
selects smaller instruction ..
I used .option norvc to fix this.

I don't think we necessarily labelled the commit as fixing this, but the
latest ecall and ebreak tests have been modified to disable compressed ops.

All Privilege directory tests require rvtest_mtrap_routine defined.
Is it selected automatically in RISCOF?

Not as far as I can tell; test writers are expected to use the clause "def
rvtest_mtrap_routine" in the 2nd parameter of the rvtest_case macro for any
test that is expected to trap. Pawan can correct me if there is some
automation for that.

when I added this [ rvtest_mtrap_routine] define (to model_test.h,
fence-01.S stopped compile , assembler complained of missing mtrap_sigptr
label ..

In the currently merged arch_test.h file, fence.i doesn't trap, therefore
doesn't define rvtest_mtrap_routine,.
All tests that don't trap) (now) have code that defines the label
mtrap_sigptr when rvtest_mtrap_routine is not defined, so it should be fixed
On Thu, Mar 23, 2023 at 6:04 AM InspireSemi @.***>
wrote:

I do not see a commit in the tree for this?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/292#issuecomment-1481160105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJQFKFBDL3TZMPLGAETW5RC6LANCNFSM6AAAAAARWX3W3U
.
You are receiving this because you commented.Message ID:
@.***>

Regarding #1: if riscof is used, it automatically disables the use of compressed ops in an implementation that doesn't support the C-extension. This fixes all of the problems, so I'm closing this issue.


super tiny improvement to maven pom changes

Really?

Easy...Just for copy paste man, you don't have to merge it.
On Sunday, July 12, 2015, Rofgar<EMAIL_ADDRESS>wrote:

Really?
—
Reply to this email directly or view it on GitHub
https://github.com/fernandezpablo85/scribe-java/pull/559#issuecomment-120760661
.

This would assume that scribe is your only dependency (and that's hardly the common case).

Yes context was bad after looking sorry; I would have done something differently but clearly it's a bit too tedious. Thanks for looking.

no problem man, thanks for trying to improve scribe :)
On Sun, Jul 12, 2015, 9:17 PM Kevin Kuhl<EMAIL_ADDRESS>wrote:

Yes context was bad after looking sorry; I would have done something
differently but clearly it's a bit too tedious. Thanks for looking.
—
Reply to this email directly or view it on GitHub
https://github.com/fernandezpablo85/scribe-java/pull/559#issuecomment-120775693
.


How to get the bitemporal images' labels if the model is trained on LEVIR-CD dataset?

Hello, I'm very interested in your work, but I encountered a problem in the process of research. If the model is trained on the LEVIR-CD dataset, how to obtain the changed labels when there are no segmentation maps for each bitemporal image in the dataset? I would appreciate it if you could solve my problems.

I guess you trained the model based on the bitemporal supervised setting.
If so, ChangeStar directly outputs the change map without object segmentation.

Thank you very much for your reply.


ESM import trigger CJS errors in dependencies

Context
Using version 4.0.1, in a full ESM typescript project
// my-script.ts
import mime from 'mime'

Triggers the following errors:
> build:ts
> tsc --build

node_modules/@types/send/index.d.ts:4:20 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("mime")' call instead.

4 import * as m from "mime";
                     ~~~~~~

node_modules/@types/serve-static/index.d.ts:4:20 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("mime")' call instead.

4 import * as m from "mime";
                     ~~~~~~

Found 2 errors.

Workaround
I've downgraded to v3
Possible fixes
Might have something to do with synthetic default imports either in this repo itself or its dependencies

Provide an MRE (see link in bug template) and I'll take a look.

Adding "skipLibCheck": true to my tsconfig did the trick


Make pip installable

[x] package with setup.py or poetry
[x] upload package to TestPyPI

Package is uploaded to TestPyPI and is pip installable with pip install -i https://test.pypi.org/simple/ pkmodel.

We found some issues with installing a suitable scipy version as part of the package install


MakeWidth/MoveWidth doesn't animate

Hi.
Using .makeWidth(...) or .moveWidth(...) skips animation. Anybody knows how to make it work?
Best regards

This works fine for me. Perhaps it is animating, but it's just difficult to detect... for example, if you're animating a UIImageView it might be hard to see the animation take place given your Content Mode... just a thought!


Question: What are the details of the package selection process (filtering)?

The first two runs show Selection of package updates: 4 candidates, filtered to 3 what I do not really understand atm.

First run was the repo command without additional parameters and the following packages have been selected:

Swashbuckle.AspNetCore
Swashbuckle.AspNetCore.Annotations
FluentAssertions

Log output:
Found 4 package updates
Microsoft.NET.Sdk.Functions to 1.0.24 from 1.0.23 in 1 place since 10 days ago.
FluentAssertions to 5.5.1 from 5.4.2 in 5 places since 2 days ago.
Swashbuckle.AspNetCore to 4.0.1 from 3.0.0 in 1 place since 11 days ago.
Swashbuckle.AspNetCore.Annotations to 4.0.1 from 3.0.0 in 1 place since 11 days ago.
Selection of package updates: 4 candidates, filtered to 3
Selected package update of Swashbuckle.AspNetCore to 4.0.1
Selected package update of Swashbuckle.AspNetCore.Annotations to 4.0.1
Selected package update of Microsoft.NET.Sdk.Functions to 1.0.24
Updating 3 packages
'Swashbuckle.AspNetCore' from 3.0.0 to 4.0.1 in 1 projects
'Swashbuckle.AspNetCore.Annotations' from 3.0.0 to 4.0.1 in 1 projects
'Microsoft.NET.Sdk.Functions' from 1.0.23 to 1.0.24 in 1 projects
Done 3 updates

Then I tried the repo command with --consolidate and the following packages have been selected:

Swashbuckle.AspNetCore
Swashbuckle.AspNetCore.Annotations
Microsoft.NET.Sdk.Functions

If I run it with inspect {localRepoPath} -v d all 4 packages are included, what I actually would have expected.

Is this a bug or a feature? :) If it is a feature, what are the details behind the filtering logic?

By default nukeeper will make a PR for the first 3 packages. It's just first come first serve. If you look at the options you will see the default is 3 for the P parameter: https://github.com/NuKeeperDotNet/NuKeeper/wiki/Configuration#options

There is sorting so that more impactful package updqtes come first (note that Swashbuckle.AspNetCore is in more places and the update has been around for longer than FluentAssertions.
The default count is the top 3, you can change that with -p / --maxpr

Ah, great!
The reason why I did not look into --maxpr was that my assumption was (because of its name) that NuKeeper scans the active pull requests created by it and does not create further PRs when the limit is reached. It was not clear to me that it controls the maximum number of package updates per pull request when in --consolidate mode.
Thanks for the insights, makes totally sense.

Being aware of that this would be breaking change: Do you think it would make sense renaming it to something like --maxpkgs or something? Just a thought.
Please close the issue on your behalf.
Addition: From the configuration document (regarding maxpr) I would also understand a different behavior than controlling the maximum number of updates. Literally speaking maxupdate would have been the term which would make the most sense to me but this is reserved to the update command.

Is there anywhere in writing how the filtering works? Would be nice to know(i realize now that i've seen in the code)

Sorting and filtering needs more docs, agreed.
And the maxpr option is increasingly  misnamed.

The one that threw me initially is the exclusion for packages < 7 days old. I was thinking we might want to make the inclusion/exclusion log better to make the reasoning more apparent.

Moredetails given by #548


dask.array as Coordinate variable

Hi all,
I was wondering if it was possible to have coordinate variables be also Dask arrays?
I am working with pretty big datasets, where coordinates alone can be too big for memory, so I am wondering how I can achieve working with this.
Thanks!

sorry for the late reply, @jennakwon06.
At the moment, we rely on pandas.Index to provide the indexing functionality, so unfortunately having dask arrays as dimension coordinates is not possible. There are plans to eventually support custom indexes (e.g. dask.dataframe.Index) but there is still a lot to do (see #1603).
Note that although they are less useful, it is possible to have dask arrays in non-dimension coordinates.

This is a duplicate of #1094.


fix(nvmx): controller attach context shall be a standalone raw pointer

NVMx controller attach context is now directly accessed via a standalone raw pointer.

bors try

bors try

bors merge


Fix broken footnotes

Some footnote references don't refer to any footnote; they are instead rendered like this:

In a real sense, everything in the discussion below is a way of showing the variance rules by example.[^thanks-to-ryan]

I believe they were broken by f70f1f42, based on the output of this command before and after that commit:
for footnoteRef in $(git grep -h --only-matching --perl-regexp '\[\^[^]]+\]' | sort | uniq); do
  echo
  echo "=== $footnoteRef ==="
  git grep --count -F $footnoteRef
done

When I had fixed the broken footnote references by moving the footnotes themselves, I noticed that f70f1f42 had also swapped the order of the thanks-to-ryan and satisficery footnotes, causing them to end up in the "wrong" order (1, 3, 2 instead of 1, 2, 3). This PR undoes that reordering.
Finally, I deliberately didn't preserve the --- line before ## Notes because no other ## Notes section is preceded by such a line, based on the output of this command:
git grep -B 3 '## Notes'

💡 git show --color-moved is useful.

Are there no gating CI checks for PRs by the way?

Ah, thank you – I will review this later or tomorrow (but I expect it’s great)! As to CI checks: Historically, no – I was basically the only one working on this, so I was just doing some basic checks locally.

Ah, OK. I think I was expecting that any obvious mistake on my part would be caught in CI. :sweat_smile: Automated checks, by the way, are the best thing since sliced bread even for single-maintainer projects! :blush:

Wow does this make me wish mdbook were on the latest version of its Markdown renderer and that I could make it do “normal” footnotes. A project for another day! Thanks for the fixes.


Video Conference Feature Issue

ℹ Computer information

PowerToys version:  0.24 Experimental
PowerToy Utility: Video Conference
Running PowerToys as Admin: Yes
Windows build number: 19042.610

📝 Provide detailed reproduction steps (if any)

Setting the webcam input as "PowerToys VideoConference"
I joined the meeting.

✔ Expected result
What is the expected result of the above steps? Other people can see me and I can enable and disable cam view with Win+Shit+O.
❌ Actual result
What is the actual result of the above steps? Other people can't see me (they see all black) when camera is enabled.
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

I tried to use the "PowerToys VideoConference" and in other softwares like OBS all worked perfectly.

@NotCarti this issue will be tracked here #6246. Please respond and subscribe to that thread.


Extension API: Different Syntax Highlight Schemes for Output Window

Currently the Output Pane syntax highlighting can be performed by having an extension register the text/x-code-output mime type ala https://marketplace.visualstudio.com/itemdetails?itemName=IBM.output-colorizer.
The problem is that there can be only one by one extension for all output windows and as soon as one extension does this it will conflict with others that try to do the same thing. There are multiple extensions (e.g. Azure Functions) that support streaming logs along with standard Git/Terraform/etc. output views, and being able to specify log highlighting on a per output window basis would go a long way to ensuring richer log views and more constant use of the Output Window.
Potential Implementations

Add a feature flag to add the window name to the output window mime type. For example if my Window is named Git then its mime type would be text/x-code-output-Git, if my window is named Terraform than mime type would be text/x-code-output-Terraform.

Now .tmlanguage highlighters can be registered on a per window name basis and different extensions can contribute different syntax highlighters for output windows rather than one "Global" one.
This would ensure broadest compatibility and probably least development effort, but more dynamic output window names may be tricky (perhaps allow wildcards in mime type definition for .tmlanguage)

Make this more explicit, such as registering an output window handler contribution and having vscode handle it natively, or have the extension specify the handler or mime type for the output window to ensure consistency.

Both 1 and 2 can be implemented together to cover both explicit and implicit specification types.

For all interested, I've found a hacky workaround to change highlighting of output panel depending on its contents.
It seems that output channel is implemented as TextEditor which has document property on which you can use setTextDocumentLanguage. The problem is that setting language for this document changes language for all output channels (may be it's the same TextDocument reused or something). So the only way have separate highlighting for different channels is to exploit the fact that only one output can be visible at a time - subscribe to window.onDidChangeActiveTextEditor and apply different language, .e.g
  for (const editor of window.visibleTextEditors) {
    if (editor.document.fileName.startsWith('extension-output'))
      if (editor.document.lineAt(0).text.includes('this is my extension output'))
        vscode.languages.setTextDocumentLanguage(editor.document, 'myLogFormat');
      else
        vscode.languages.setTextDocumentLanguage(editor.document, 'Log');
  }

Also, there is no way to connect between this document/editor and OutputChannel name so one have to analyze text or cache document's name (i.e. extension-output-#7). But at least this workaround can be used to solve existing highlighting conflict between multiple extensions (such as https://github.com/microsoft/vscode/issues/19561) until proper API is implemented.


Fixed broken record destroying

Fixing issue https://github.com/sedubois/mobility-actiontext/issues/3 by utilizing the new configuration option introduced by the pull request https://github.com/shioyama/mobility/pull/525

@thedarkside could you please fix the dependency on mobility and rebase?


Initial test run fix proposal

Changed the way failures are detected.
It should resolove #95. I hope...

Thanks! Just recovering from a case of flu so catching up. I'll review as soon as I can get to it.

@rollenes Could you check if this needs a rebase and then I'll merge? Thanks!

Rebased


Cache for images so they don't take as long to re-load

Such as holding the last x images in a dictionary to see if they get requested again. Base re-request on last-modified date to stop cache from getting stale

Note: image loading is a lot faster with the new parser, but this would still be nice


Ray documentation x3 files in new branch

I created an assembly and two modules for the latest iteration of the Ray documentation.

Superseded by PR 477


Checkbox doesn't remove user-select: none; style from body

🐛 Bug Report
When quickly and repeatedly toggling a checkbox and then moving the cursor away from the component before letting go, sometimes user-select: none; on the HTML element isn't removed.
🤔 Expected Behavior
That style is always removed.
😯 Current Behavior

💁 Possible Solution
A race condition?
💻 Code Sample
https://react-spectrum.adobe.com/react-spectrum/Checkbox.html
🌍 Your Environment

Software
Version(s)

react-spectrum
3.1.0

Browser
Chrome 84

Operating System
macOS 10.15

I do not see that user-select at all? Can you explain more?

Ah, yep, i can do it. Just gotta look at the <html element :)

I'd like to give this a try

thanks! i think this may be related https://github.com/adobe/react-spectrum/pull/893

Thanks! I already made a pr for this using the lates main branch


update yarn

Coverage remained the same at 100.0% when pulling e0adf9c8d96ec57ed2f520005a1e51433989c845 on update-yarn into 390dc546e39465da8f27331dec33e1ba34207f87 on master.


after generate," can't find  run_erl " in windows,  who can save me???

I use rebar to build a otp application,but when I generate success,  I run rebarapp start ,I got a error :  ..../erts-6.0/bin/run_erl:No such file or directory, can you give some help? thank you...

@jiangtiqiang if you can provide more information, we might be able integrate the changes into the templates. In fact, as you have access to Windows, would you like to submit a patch?

@jiangtiqiang if you can provide more information, we might be able integrate the required changes. Actually, as you have access to Windows, would you like to submit a patch?

@jiangtiqiang, does the problem persist, or can this be closed?

Hi, this issue was closed in an attempt to do quick basic filtering. All tickets prior to March 2017 were closed and will be reopened on a per-request basis, please give rebar3 a try and feel free to reopen if it's a pressing issue that is still unresolved.


Fix load & scroll event usage in ScrollSpy tests

Use $.one() instead of $.on() since there are no $.off()s in the code, nor do we expect multiple occurrences of the events.
Remove unnecessary namespacing of listeners for the scroll & load events. These are vanilla DOM events (not custom jQuery namespaced events) and we're not using jQuery namespacing to manage these event listeners either (e.g. $.off()).

CC: @XhmikosR @hnrch02 for review

SGTM


Windows CI: Port docker_cli_rm_test.go

Signed-off-by: John Howard<EMAIL_ADDRESS>This ports the tests in docker_cli_rm_test.go to run on Windows to Windows CI. Output from local run below - all tests in this file are ported and working :smiley:
E:\go\src\github.com\docker\docker>runtest w TestRmContainer
Running test TestRmContainer
DOCKER_TEST_HOST=tcp://<IP_ADDRESS>:2375
DOCKER_HOST=tcp://<IP_ADDRESS>:2375
=== RUN   Test
INFO: Testing against a local daemon
PASS: docker_cli_rm_test.go:53: DockerSuite.TestRmContainerForceRemoveRunning   4.710s
PASS: docker_cli_rm_test.go:61: DockerSuite.TestRmContainerOrphaning    9.510s
PASS: docker_cli_rm_test.go:46: DockerSuite.TestRmContainerRunning      3.353s
PASS: docker_cli_rm_test.go:12: DockerSuite.TestRmContainerWithRemovedVolume    4.979s
PASS: docker_cli_rm_test.go:35: DockerSuite.TestRmContainerWithVolume   4.910s
OK: 5 passed
--- PASS: Test (30.35s)
PASS
ok      _/E_/go/src/github.com/docker/docker/integration-cli    30.559s

E:\go\src\github.com\docker\docker>

@icecrime @thaJeztah The failing win2lin test is known flakey.

All green. Submitted/merged a PR to stub out the flakey test.

LGTM

@thaJeztah SGTM, so LGTM 🐰


Improved ui (Navbar items)

Did some tweaks in UI
It's looking better than before
Changed navbar item's text color to orange when we hover them
https://user-images.githubusercontent.com/54644253/194727635-b18d9f99-c173-49ef-9ab1-ce44381914d9.mp4

Hey @DeveloperAshish8 Could you please review it?

Covered in other PRs


docs: update migration docs for 08-wasm pre-releases

Description
Adds migration docs for #6923 and #6924

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Feel free to adjust as necessary!


App documentation - How to build the web version locally

Enhance the app/README.md or README.md files to explain how to generate the website the same way the workflow does it to deploy it in GH Pages.
The magical commands are:
cd app
flutter build web --target=src/main/app/ods_application.dart

Fixed by https://github.com/Orange-OpenSource/ods-flutter/commit/a023b5a91e0660ca9dbab7ce5c50115b4ee88330


Both sides of flashcards in other language

One side of the card says:
Provide the translation for 'אמא' from Hebrew. To Hebrew:
Other Side Says:
אמא

Hi @alzprojects ! As mentioned in the plugin description (https://ankiweb.net/shared/info/557761805) this plugin does not provide translations.
I'll go ahead and close this request, but let me know if I missed the point and there was something else being requested!


How to test a model only on images that have a certain class ? (the tools\test.py currently test the model on a fixed 5000 images regardless to the dataloader)

Objective:
I need to test different models per category only on the images that have this category. (coco dataset)
example: test model A on images that only have class A, test model B on images that only have class B ....
Steps:
-Adding classwise=True to the val_evaluator --> This will allow me to see APs on all categories including my sought one
-modified the config: specifically the data loaders according to the sought category --> This should filter the images and keep only the images that have the sough category.  (but it is not doing so during testing)
issue:
tools\test.py is indeed giving the per category metrics but it is doing so on a fixed number of images (5000) that are randomly chosen rather than the images that only belong to the category.
Additional info:
I am sure that I have edited the data loaders correctly since once I use them in training, the images used to train the model for a certain category 'A' have the same number of images of category 'A' (same for other categories). The fixed 5000 images are only encountered during testing.

@jawadhaidar You can use a script to split the 5000 images in the COCO validation set into individual images. This way, it will be easier for you to perform your validation.


OOM - 40 commits behind

Moving 40 commits back from master

Pull Request Test Coverage Report for Build 6573

189 of 260 (72.69%)  changed or added relevant lines in 32 files are covered.
38 unchanged lines in 14 files lost coverage.
Overall coverage decreased (-0.2%) to 45.123%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/ExecutionFlowDao.java
8
9
88.89%

azkaban-common/src/main/java/azkaban/executor/container/watch/AzPodStatusExtractor.java
9
10
90.0%

azkaban-common/src/main/java/azkaban/trigger/builtin/SlaAlertAction.java
0
1
0.0%

azkaban-common/src/main/java/azkaban/utils/EmailMessage.java
0
1
0.0%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
2
3
66.67%

azkaban-common/src/main/java/azkaban/executor/AbstractExecutorManagerAdapter.java
4
6
66.67%

azkaban-common/src/main/java/azkaban/executor/JdbcExecutorLoader.java
1
3
33.33%

azkaban-common/src/main/java/azkaban/executor/container/ContainerCleanupManager.java
11
13
84.62%

azkaban-common/src/main/java/azkaban/imagemgmt/daos/ImageVersionDaoImpl.java
0
2
0.0%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunnerManager.java
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

az-core/src/main/java/azkaban/Constants.java
1
21.43%

azkaban-common/src/main/java/azkaban/executor/container/KubernetesContainerizedImpl.java
1
61.68%

azkaban-common/src/main/java/azkaban/executor/ExecutionFlowDao.java
1
68.62%

azkaban-common/src/main/java/azkaban/sla/SlaOption.java
1
81.29%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunnerManager.java
1
16.67%

azkaban-web-server/src/main/java/azkaban/webapp/AzkabanWebServer.java
1
26.27%

azkaban-common/src/main/java/azkaban/executor/container/watch/FlowStatusManagerListener.java
2
75.32%

azkaban-common/src/main/java/azkaban/executor/ExecutorManagerException.java
2
83.33%

azkaban-common/src/main/java/azkaban/executor/ExecutorApiGateway.java
3
91.3%

azkaban-common/src/main/java/azkaban/utils/EmailMessage.java
3
68.46%

Totals

Change from base Build 6554:
-0.2%

Covered Lines:
17699

Relevant Lines:
39224

💛  - Coveralls


Update to latest (20151223) spec

window.screen.orientation is an object that conforms to the ScreenOrientation interface

remove function window.screen.lockOrientation, add function window.screen.orientation.lock
window.screen.orientation.lock should take a single argument that is a [OrientationLockType] (https://www.w3.org/TR/2015/WD-screen-orientation-20151223/#orientationlocktype-enum)
remove function window.screen.unlockOrientation, add function window.screen.orientation.unlock
window.screen.orientation must implement EventTarget
EventHandler window.screen.orientation.onchange should exist
window.screen.orientation.type should exist and should be a OrientationType
window.screen.orientation.angle should exist

Also update the docs and add tests.

Moved to CB-11306


feat: monadic generalization of FindExpr

Not certain this is a good idea. Motivated by code duplication introduced in #3398.

!bench

This generalization is problematic. For example, the monad may have state, and this state may influence the result of p. The reference implementation does not match the actual one because of the checkVisited cache.


FileViewFragment and ChannelCommentsFragment have redundant functions

The Issue
FileViewFragment and ChannelCommentsFragment have redundant functions relating to commenting. The functions initCommentForm, clearReplyToComment, postComment, validateAndCheckPostComments, and more are almost all the same or differ only slightly. These functions should be moved to one spot to significantly improve code quality and make the app easier to develop.
Acceptance Criteria

Redundant functions are made not redundant anymore

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

I am going to code a custom compound view for the "new comment form" layout which will move all those methods into a unique class which then it could be inserted into the layouts.

I am going to code a custom compound view for the "new comment form" layout which will move all those methods into a unique class which then it could be inserted into the layouts.


docs(OpenTelemetry): initial documentation and example

Description

This PR adds initial documentation and an example integration application for using OpenFGA with OpenTelemetry in applications.
References

Note that this relies on changes in #122.
Closes #120
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.45%. Comparing base (6a4aa1a) to head (52f567a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   25.45%   25.45%
=======================================
  Files         102      102
  Lines       10576    10576
=======================================
  Hits         2692     2692
  Misses       7612     7612
  Partials      272      272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error in squash minified bundle, malformed minification.

I have a repo, https://github.com/backspaces/as-app3d, using squash to minify Rollup bundles. Using the minified bundle fails with a browser error. The minified bundle is mal-formed.
In the example I give below, the minified/squashed version fails with:

Uncaught ReferenceError: e3 is not defined

To reproduce:

mkdir test; cd test
curl http://backspaces.net/temp/docs.zip > foo.zip (made for this issue)
unzip foo.zip
(or just clone the repo, and use the docs (github page) for the rest below)

In a browser (chrome for me):  open localhost page test/docs/models/helloesm.html
for my test: http://localhost/home/Downloads/test/docs/models/helloesm.html
result: runs fine

edit docs/models/helloesm.html:
'../dist/as-app3d.esm.js' > '../dist/as-app3d.esm.min.js' (minified with squash)
run url above: console:
Uncaught ReferenceError: e3 is not defined

To test with uglify-es:

uglifyjs docs/dist/as-app3d.esm.js > docs/dist/as-app3d.esm.ugly.js
edit helloesm.html: as-app3d.esm.min.js > as-app3d.esm.ugly.js
run url as above

runs fine
The files involved

-rw-r--r--  1 owen  staff   178K Sep  7 15:10 as-app3d.esm.js
-rw-r--r--  1 owen  staff    57K Sep  7 15:10 as-app3d.esm.min.js
-rw-r--r--  1 owen  staff    71K Oct 30 21:50 as-app3d.esm.ugly.js

The file size difference might suggest a failure.

Here's the specific minified segment that fails:
Uncaught ReferenceError: e3 is not defined
...for(let e=0;e<n.length;e=e3){...
There is no other use of e3 in the file, so not a global.
Here it is prettier-ized
update(e) {
    let t = this.mesh,
        { vertices: n, indices: r } = this.unitQuad,
        o = 1,
        i = t.geometry.getAttribute('position'),
        a = t.geometry.getAttribute('uv'),
        s = t.geometry.getIndex(),
        u = new Float32Array(n.length * e.length),
        c = [],
        l = []
    for (let t = 0; t < e.length; t++) {
        let i = e[t]
        i.sprite || i.setSprite()
        let a = i.size,
            s = i.theta,
            d = Math.cos(s),
            f = Math.sin(s),
            h = t * n.length
        for (let e = 0; e < n.length; e = e3) { <<<<
            let t = n[e],
                r = n[e + 1],
                s = i.x,
                c = i.y
            u[e + h] = (a * (t * d - r * f) + s) * o
            u[e + h + 1] = (a * (t * f + r * d) + c) * o
            u[e + h + 2] = i.z * o
        }
        l.push(...r.map(e => e + t * 4))
        c.push(...i.sprite.uvs)
    }
    i.setArray(u)
    i.needsUpdate = !0
    a.setArray(new Float32Array(c))
    a.needsUpdate = !0
    s.setArray(new Uint32Array(l))
    s.needsUpdate = !0
}


[FEATURE] Support Relative Date-time Strings

Is your feature request related to a problem?
Support relative date-time strings similar to those supported in Splunk.
What solution would you like?
Implement support for relative date-time strings similar to those supported in Splunk, as described below. This should be integrated into the existing date-time implementation, such that date-time values that are declared using relative date-times can be compared and otherwise treated like any other date-time value.
Time Offset
The following time offset formats should be supported:

[+|-]<time_integer><offset_time_unit>
`[+|-]<offset_time_unit>
now

The following offset time unit keywords should be supported:

Description
Supported Keywords

seconds
s, sec, secs, second, seconds

minutes
m, min, mins, minute, minutes

hours
h, hr, hrs, hour, hours`

days
d, day, days

weeks
w, week, weeks

month
mon, month, months

quarters
q, qtr, qtrs, quarter, quarters

year
y, yr, yrs, year, years

Snap-to Time Units
In addition to the supported time unit keywords listed above, the following keywords representing the days of the week should be supported for snap-to times:

Description
Supported Keywords

Sunday
w0, w7

Monday
w1

Tuesday
w2

Wednesday
w3

Thursday
w4

Friday
w5

Sunday should be considered to be to be the first day of the week, such that @w0, @w7, @w, and @week all correspond to the start of the previous Sunday. This is consistent with Splunk, but could be made configurable in the future if desired (i.e. so that Monday could be considered as the first day of the week).
Examples

Relative date-time
Description
Case

-60m
60 minutes ago
Offset without snap-to-time

-h
One hour ago
Offset without time integer

+2wk
Two weeks from now
Positive offset

-1h@h
1 hour ago, to the hour
Relative time with snap-to-time

@d
Beginning of the current day
Snap-to time without offset

-1d@w3
Last Wednesday
Weekday keyword

now
Current date-time
Current time keyword

The following functionality will not be supported (but could be supported in the future):

Specifying offsets from the snap-to time (e.g. @d+12h).

What alternatives have you considered?
None. See #957.
Do you have any additional context?
See #957.

The following functionality will not be supported (but could be supported in the future):

Specifying offsets from the snap-to time (e.g. @d+12h).

@YANG-DB Is this an acceptable limitation for the initial implementation? I think this covers the majority of use cases, and would allow us to get earliest/latest implemented a bit quicker. Once that's done, we can come back to add this functionality if it's needed.

The following functionality will not be supported (but could be supported in the future):

Specifying offsets from the snap-to time (e.g. @d+12h).

@YANG-DB Is this an acceptable limitation for the initial implementation? I think this covers the majority of use cases, and would allow us to get earliest/latest implemented a bit quicker. Once that's done, we can come back to add this functionality if it's needed.

Agree - thanks @currantw


Table 32 Item Ledger Entry Enable Key

On table 32 Item Ledger Entry can you enable Key
Item No.,Open,Variant Code,Positive,Location Code,Posting Date,Expiration Date,Lot No.,Serial No.

Sorry about the delay on this one. We've tried to make this rather simple change for a while now, but somehow it seems to alter the behavior of the product, making a few of our internal tests fail. We're investigating why that it, as that should not be the case.

We have found the reason why we couldn't enable this key without failed tests. Required change is too complex and we cannot make it now. In order to understand your issue better - can you explain why do you need this specific key, if everything works without it?


Missing error handling on allocation failure

In RecastRasterization.cpp the function addSpan does not handle the case when allocSpan returns nullptr. It does so when no memory rcAlloc fails.
This results in a crash on the following line in addSpan.
The addSpan function should probably have a return value to signal allocation failure to callers.

I would offer to send a pull request for the core code, but it's not really possible to fix the problem for users that are not notified about this change, because they will need to check the return value of a function that previously did not return a value.
Affected APIs would be:
rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)
They all have a "ctx" parameter for error reporting though, so it would only affect the return value change from void to bool.

Hi,
I think it is ok to add return bool value and add an error message on those
functions to indicate that they have failed. It should not break any
current code, but allows people to catch it if needed.
--mikko
On Mon, Jun 22, 2015 at 6:50 PM, rafzi<EMAIL_ADDRESS>wrote:

I would offer to send a pull request for the core code, but it's not
really possible to fix the problem for users that are not notified about
this change, because they will need to check the return value of a function
that previously did not return a value.
Affected APIs would be:
rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)
They all have a "ctx" parameter for error reporting though, so it would
only affect the return value change from void to bool.
—
Reply to this email directly or view it on GitHub
https://github.com/memononen/recastnavigation/issues/100#issuecomment-114161175
.

@rafzi Did #102 complete everything you wanted to do with this? Are we ok to close this issue?


broadcast and receive should allow mutually exclusive broadcasts

The following should not result in a "multiple broadcasts" classification as the events can statically be determined to be mutually exclusive:
if x:
    broadcast('event 1')
else:
    broadcast('event 2')

This isn't terrible as "multiple broadcasts" is more of a warning than an error, but it'd be nice to raise less warnings.

Closing this issue due to the time that's been open. If someone would like to fix it, please open a pull request.


Rework presubmit to run KNE tests for all vendors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2069

💛  - Coveralls

This change SGTM if we can figure out what is going on with the cisco_8000e (or exclude it for now until we do).  I made a mistake on my first GCP CPU quota request and am waiting on my second request still.

explicitly enabling nested virt fixed the issue, ready for review


Purging unmanaged ACL's

Hi I was wondering is there is a way in this module to achieve this:
I want to set ACL's on specific folders for end-users programatically. Sometimes users are added, sometimes users are removed. Adding users works perfectly, but whenever I run my dsc script, I want to purge the acl's that are not managed by DSC. Is there a way to do that?
I know I can set acls to absent, but I don't want to ensure 1000 users are absent when I only want to ensure 3 are present.
It currently works fine with AD groups (ensuring specific people are in a group, and the setting a single acl for that group. However, this requires users to log out and back in again, which is a real pain. I want to switch to ACL's for end-users directly.

I am seeing the same issue.  I can present/Absent specific issues, but if I want to enforce my permissions to be exactly what I specify it does not appear to work.
Example:
cNtfsPermissionEntry 'FileShare1User1' {
Ensure = 'absent'
DependsOn = "[File]Share1Folder"
Principal = 'domain\user1'
Path = 'D:\FileShare1'
}
cNtfsPermissionEntry 'FileShare1read' {
Ensure = 'Present'
DependsOn = "[File]Share1Folder"
Principal = 'domain\user3'
Path = 'D:\FileShare1'
AccessControlInformation = @(
cNtfsAccessControlInformation
{
AccessControlType = 'Allow'
FileSystemRights = 'Read'
Inheritance = 'ThisFolderSubfoldersAndFiles'
NoPropagateInherit = $false
}
)
}
Will remove user1 but if user2 exist . . . ignores and does not remove user2.  Will remove user1 and leave or add user3.


Add custom policies

what

Allows the policy variable to be used in a useful way to set a custom S3 bucket policy
Conditionally the data resource for the unused default bucket policy

why

Issue #19 outlines why this is required
I have tested this change and found it to sufficiently create a custom S3 bucket policy sufficient for oganization-level writing.

Closes #19

Could we use something like source_json instead of this ?
See PR https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/pull/10

Could

I've added a commit to rework this as you advise.

/test all

/test all


Fix broken markup on main page

I noticed that the markup on 12factor.net contains an element that doesn't get closed properly. Firefox (and I guess a lot of more browsers) are still able to render the markup, so it's not a big deal.

Thanks!


Global Namespace

At the moment we declare too much in the global namespace. It's generally considered bad practice to place everything in the global namespace.
http://wiki.c2.com/?GlobalVariablesAreBad

Yup, working on that ;)


shimv2 should return grpc error codes

containerd relies on it to determine proper actions, e.g., fail the operation or wait for an exit event.[1]
ref: [1] https://github.com/containerd/cri/blob/master/pkg/server/container_stop.go#L141

/test

cc @lifupan


currentElement and DocumentFragment

If a DocumentFragment is being patched and currentElement is called at the root, then it will actually return a Node and not an Element.
I'm not sure if an assert should be added or if it should be currentNode instead. It doesn't seem like a good idea to expose the node being patched from inside, so an assert making sure that it isn't called at the root might be a good idea.

This is actually one of my needs for currentElement. But let me see if I can get around that with the new skip.

If this functionality is still needed, perhaps we should just add an assert that the current parent is in fact an Element rather than just casting it.


int doesn't have ago in Rails 4, so remove to_i calls

we don't need to call to_i before calling ago.  If we remove that
call, this code should work on Rails 3 and 4

Blech, I swear this passed last night.

@tenderlove This is failing with superclass mismatch for class Duration... Can you take a look?


MarshalIndent doesn't compatible with standard when using map[string]interface{}

I have been to set var jsonByJsoniter = jsoniter.ConfigCompatibleWithStandardLibrary but jsonByJsoniter doesn't prepend space on value as follows:
package main

import (
	"github.com/json-iterator/go"
	"fmt"
	"encoding/json"
)

func main(){

	var jsonByJsoniter = jsoniter.ConfigCompatibleWithStandardLibrary

	data := map[string]interface{}{
		"foo": "bar",
	}

	b1,_:=jsonByJsoniter.MarshalIndent(data, "", "    ")
	fmt.Println(string(b1))

	b2,_:=json.MarshalIndent(data, "", "    ")
	fmt.Println(string(b2))

	fmt.Println(string(b1) == string(b2))

}

Will output:
{
    "foo":"bar"     // doesn't prepend space
}
{
    "foo": "bar"
}
false

fixed

@taowen thanks

@taowen it works when using json. MarshalIndent but doesn't work with ConfigCompatibleWithStandardLibrary.

fixed

@taowen thanks 👍


wget not working

Hi,
I experienced several times 404 error running the wget function.
wget https://andrewhalterman.com/files/geonames_index.tar.gz --output-file=wget_log.txt
The different source in the dev branch works instead.
Is this something expected to happen?
Thanks!

Hi @ahalterman ,
Does the wget link of file work now? Cause I get "Error 404: Not Found" when running the wget function.
I will appreciate it if you can help me. Mordecai seems tremendous and I can't wait to have a try.
Thank you!


Dragging glitch / jumps back if there aren't enough items to show

Hi,
take this example:
https://jsfiddle.net/mfvcu82y/7/
Groups of 3 items are shown, there are 7 items in total.
The first time, when I drag from the far right to the left, the next group (4,5,6) is shown beatifuly.
But the second time, halfway through my dragging to the left, the carousel suddenly jumps back (because there aren't more items to show)
It would be nicer if it allowed you to drag the carousel as far to the left as you want, then when you let go, bounce back to the available items
gif:
http://www.giphy.com/gifs/2t9y28dZqPegK0ROte

Hey @jorgvm, this is just how our dragging works currently. I agree that a feature to toggle a endless-drag or something similarly named would be interesting.
I'll change this into a feature request!


[parade] Move DDL under ddl/

Requires some changes, most notably an ability to get a the pgx pool from a database.  This
should eventually vanish: we could either use pgx more directly, or export enough functionality
from Database to enable Parade directly on top.

Thanks!


feat(prettier): improve the format of ReturnStatement to support longer width

Current dependencies on/for this PR:

main

PR #1335

PR #1336   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 15, 10:03 PM: @Boshen started a stack merge that includes this pull request via Graphite.


when lookup fails, recommend some identifiers that have webfinger resources

Looking at the access logs for the app, it seems people often try plugging in their Gmail address or a random website URL, see that it gets no result, and then walk away.  Instead, we should recommend some values that we know will return a webfinger resource, so they can see a working example.

...and/or a link to the https://webfinger.net/code/ page (in case it is a random page).


Breaking the schema

:x: Validation status: errors

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Add-DatabaseToAvailabilityGroup.md
:x:Error

Details

:x:Error

Details

sharepoint/sharepoint-ps/sharepoint-server/Add-DatabaseToAvailabilityGroup.md

[Error] Unable to load file: sharepoint-ps/sharepoint-server/Add-DatabaseToAvailabilityGroup.md via processor: AzureCliDocumentProcessor: :7:(26) '#### Default
'
Expect Heading level 3

[Error] Markdown.MAML.Transformer.HelpSchemaException: :7:(26) '#### Default
'
Expect Heading level 3
at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.GetInnerContexts(DocumentBuildParameters parameters, IEnumerable1 processors, TemplateProcessor templateProcessor, IHostServiceCreator creator) at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.BuildCore(DocumentBuildParameters parameters) at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.BuildCore(DocumentBuildParameters parameter, IMarkdownServiceProvider markdownServiceProvider, BuildInfo currentBuildInfo, BuildInfo lastBuildInfo) at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.Build(IList1 parameters, String outputDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jwhit-MSFT let me know and I can help with this. The PowerShell schema is very picky. :)

This was just a test to see if the validation check caught it--we were doing training for partners. Sorry for the confusion!

@jwhit-MSFT - ok got you. I will close this one out. Thanks for the training!


Voldivh/model command output update

🦟 Bug fix
Fixes https://github.com/gazebosim/gazebo_test_cases/issues/324
Summary

Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

sign the commit https://github.com/gazebosim/gz-sim/pull/2138/checks?check_run_id=16723688786


Some questions about integrating with HtmlWebpackPlugin babel-env and browserslist.

It's more of a query than an issue, but your README doesn't contain the documentation for this, and I have some questions about integration with an existing codebase, having seen your plugin on https://estimator.dev/:

How would you suggest generating the HTML template for HtmlWebpackPlugin? We currently have several of the following, as an example:

new HtmlWebpackPlugin({
        inject: false,
        filename: '../../../Heritage.HE.Web/Views/Partials/Tags/_HeadTags.cshtml',
        template: './src/templates/headTags.html',
      }),

Do our .babelrc presets and plugin file have to be separated out instead of passing it as an integrated config option (our current codebase passes that in through config)? So you know what I mean, this is our current babel config - we use something that's a little complex in terms of plugins and presets, thanks to some react components.

{
  test: /\.js$/,
  exclude: /node_modules/,
  use: {
    loader: 'babel-loader',
    options: {
      plugins: [
        '@babel/plugin-proposal-function-bind',
        ['@babel/plugin-proposal-class-properties', { 'loose': false }],
        '@babel/plugin-syntax-dynamic-import',
      ],
      presets: [
        ['@babel/preset-env', {
          corejs: 3.6,
          useBuiltIns: 'usage'
        }],
        '@babel/preset-react',
      ],
    },
  },
},

We currently define our browswerslist in our package.json for babel-env to chew on. If we defined such a list in the .babelrc, would it have an effect and would it affect the module or nomodule bundle?

Additionally, our entry point looks like this, as a dependency needs map and set to be polyfilled for IE11.
entry: [
      'core-js/modules/es.promise',
      'core-js/modules/es.array.iterator',
      'core-js/modules/es.map',
      'core-js/modules/es.set',
      './src/js/index.js',
    ],

Hiya - you need to move the babel configuration into a babelrc or babel.config.js, and to remove babel-loader. OptimizePlugin uses your babel config for the modern bundles only.
The legacy bundles are compiled to ES5 without looking at custom configuration, but their syntax level will be based on your browserslist.

I also wanted to open an issue about documentation and that I couldn't make it to optimize our application even further. Is there a demo that we can play with and see the configs and compare results?
@developit Thanks for the explanation. How is that different from using babel-env plugin with useBuiltIns option with usage value?

Hiya - you need to move the babel configuration into a babelrc or babel.config.js, and to remove babel-loader. OptimizePlugin uses your babel config for the modern bundles only.
The legacy bundles are compiled to ES5 without looking at custom configuration, but their syntax level will be based on your browserslist.
You should remove the custom configuration for Set and Map. Both those API's are supported in IE11, and any additional usage will get automatically polyfilled in your legacy bundles.
The premise of this plugin is essentially that you don't need to ever manually configure transpilation or polyfilling - it's all done automatically based on usage.

Thanks, I will give this a shot this week and report any issues here.

Added this to the FAQ.
https://github.com/developit/optimize-plugin#faq


unable to process

Last Error Received:
Process: VR Architecture
If this error persists, please contact the developers with the error details.
Raw Error Details:
MemoryError: "Unable to allocate 3.01 GiB for an array with shape (2, 202192896) and data type float64"
Traceback Error: "
File "UVR.py", line 4716, in process_start
File "separate.py", line 672, in seperate
File "separate.py", line 734, in loading_mix
File "librosa\util\decorators.py", line 104, in inner_f
File "librosa\core\audio.py", line 629, in resample
File "scipy\signal\signaltools.py", line 3294, in resample_poly
File "scipy\signal_upfirdn.py", line 215, in upfirdn
File "scipy\signal_upfirdn.py", line 101, in apply_filter
"
Error Time Stamp [2023-04-09 00:53:05]
Full Application Settings:
vr_model: 1_HP-UVR
aggression_setting: 10
window_size: 320
batch_size: Default
crop_size: 256
is_tta: False
is_output_image: False
is_post_process: False
is_high_end_process: False
post_process_threshold: 0.2
vr_voc_inst_secondary_model: No Model Selected
vr_other_secondary_model: No Model Selected
vr_bass_secondary_model: No Model Selected
vr_drums_secondary_model: No Model Selected
vr_is_secondary_model_activate: False
vr_voc_inst_secondary_model_scale: 0.9
vr_other_secondary_model_scale: 0.7
vr_bass_secondary_model_scale: 0.5
vr_drums_secondary_model_scale: 0.5
demucs_model: Choose Model
segment: Default
overlap: 0.25
shifts: 2
chunks_demucs: Auto
margin_demucs: 44100
is_chunk_demucs: False
is_chunk_mdxnet: False
is_primary_stem_only_Demucs: False
is_secondary_stem_only_Demucs: False
is_split_mode: True
is_demucs_combine_stems: True
demucs_voc_inst_secondary_model: No Model Selected
demucs_other_secondary_model: No Model Selected
demucs_bass_secondary_model: No Model Selected
demucs_drums_secondary_model: No Model Selected
demucs_is_secondary_model_activate: False
demucs_voc_inst_secondary_model_scale: 0.9
demucs_other_secondary_model_scale: 0.7
demucs_bass_secondary_model_scale: 0.5
demucs_drums_secondary_model_scale: 0.5
demucs_pre_proc_model: No Model Selected
is_demucs_pre_proc_model_activate: False
is_demucs_pre_proc_model_inst_mix: False
mdx_net_model: Choose Model
chunks: Auto
margin: 44100
compensate: Auto
is_denoise: False
is_invert_spec: False
is_mixer_mode: False
mdx_batch_size: Default
mdx_voc_inst_secondary_model: No Model Selected
mdx_other_secondary_model: No Model Selected
mdx_bass_secondary_model: No Model Selected
mdx_drums_secondary_model: No Model Selected
mdx_is_secondary_model_activate: False
mdx_voc_inst_secondary_model_scale: 0.9
mdx_other_secondary_model_scale: 0.7
mdx_bass_secondary_model_scale: 0.5
mdx_drums_secondary_model_scale: 0.5
is_save_all_outputs_ensemble: True
is_append_ensemble_name: False
chosen_audio_tool: Manual Ensemble
choose_algorithm: Min Spec
time_stretch_rate: 2.0
pitch_rate: 2.0
is_gpu_conversion: False
is_primary_stem_only: False
is_secondary_stem_only: True
is_testing_audio: False
is_add_model_name: False
is_accept_any_input: False
is_task_complete: False
is_normalization: False
is_create_model_folder: False
mp3_bit_set: 320k
save_format: MP3
wav_type_set: PCM_16
help_hints_var: False
model_sample_mode: False
model_sample_mode_duration: 30
demucs_stems: All Stems

Are you sure you have 3GB available on your computer?

You may see the attached photo. Still have 46.7 G in computer , D drive
still have 931 G
On Sun, 9 Apr 2023 at 1:19 AM, Abhishek Shivakumar @.***>
wrote:

Are you sure you have 3GB available on your computer?
—
Reply to this email directly, view it on GitHub
https://github.com/Anjok07/ultimatevocalremovergui/issues/484#issuecomment-1500937686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A667CAYNWCMDIJ2FQLSNZCLXAGMZ3ANCNFSM6AAAAAAWXR24UM
.
You are receiving this because you authored the thread.Message ID:
@.***>

How much RAM do you have?
On Sat, Apr 8, 2023 at 6:21 PM chnlee178 @.***> wrote:

You may see the attached photo. Still have 46.7 G in computer , D drive
still have 931 G
On Sun, 9 Apr 2023 at 1:19 AM, Abhishek Shivakumar @.***>
wrote:

Are you sure you have 3GB available on your computer?
—
Reply to this email directly, view it on GitHub
<
https://github.com/Anjok07/ultimatevocalremovergui/issues/484#issuecomment-1500937686
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A667CAYNWCMDIJ2FQLSNZCLXAGMZ3ANCNFSM6AAAAAAWXR24UM
.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/Anjok07/ultimatevocalremovergui/issues/484#issuecomment-1500938155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACX3TAY5XIRIAMRTWE3WD3TXAGNC5ANCNFSM6AAAAAAWXR24UM
.
You are receiving this because you commented.Message ID:
@.***>


raise an OverflowError like micropython for too big a value

This allows the micropython test "ticks_add" to succeed when the adafruit_ticks implementation of ticks_add is used. (see https://github.com/adafruit/circuitpython/blob/main/extmod/modtime.c#L191)

I performed my (micropython's) ticks test with Dan's proposed change (corrected) and it passes so it's probably a correct transformation. Thanks @dhalbert


Tunnel "clickbox" is offset.

The "clickbox" of the Tunnel is offset to the side:

Furthermore, deleting a Tunnel leaves a green dot behind.

I am currently using the Tunnel very heavily, and I constantly have to deal with this clickbox issue, editing wires next to the output is impossible unless I move the tunnel away first.

@HypheX  I just fixed it. Can you check it once? You may need to clear your cache to see the update (Ctr+Shift+R). There was another bug regarding deletion of Tunnel. I fixed that too.

Yes! THANK YOU! It is fixed 👍


scroll reveal deleting all other injected style

When I use scrollReveal on a
 that has some style injected into it via another plugin, it gets deleted, even though scrollReveal's injected style attributes are different to the other plugins injected style attribs.
It's not an urgent problem, since I can just create a empty
 and add the data-sr to it instead.
Basically I would like to be able to write...

but I have to write it like...

I can't see why it's necessary for scrollReveal to delete all other injected style, but if it is, I can quite easily make do.

If there is a style attribute present, it will preserve that value—but it will override whatever value is present at runtime.

If there is a style attribute present, it will preserve that value—but it will override whatever value is present at runtime.

And there's no easy way to flag an element as "don't touch"? The problem I'm having is that SR seems to be removing styles from elements that don't have SR attributes on them.

@GeoffreyPlitt SR will never touch the style attribute of an element that doesn’t have data-sr. You can look in the init() method to see how it works.
That said, it may be confusing though, because recently (see #100), SR was updated to remove data-sr attributes once everything is setup.


compress/flate: HuffmanOnly is sub-optimal

Using go1.7beta1
HuffmanOnly mode on flate.Writer sometimes encodes data as raw blocks instead of dynamic blocks when there is something to gain.
 Currently, on go1.7beta1, the flate.Writer on HuffmanOnly mode does not even attempt to encode this dataset (and resorts to outputting raw blocks).
From an entropy perspective, we should be able to encode each symbol with 7.63 bits/symbol. With 10000 symbols, we should be able to compress this to approximately 95375 bytes. So unless the huffman table definition itself would have occupied more than 4625 bytes (unlikely), the writer should have chosen to use a dynamic block instead of a raw block.
On HuffmanOnly mode it may be worth exploring how we split up each block.

/cc @nigeltao @klauspost

This is by design.
If we can only achieve less than a 16th of the input size in reduction, we do not spend CPU time encoding it, and store the block.


Mixer overloaded error after upgrading to 1.1.0

1.0.6 proxies following a control plane upgrade to 1.1.0 are currently logging:
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:Server is currently overloaded. Please try again.
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:Server is currently overloaded. Please try again.
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:Server is currently overloaded. Please try again.
[libprotobuf ERROR src/istio/mixerclient/report_batch.cc:83] Mixer Report failed with: UNAVAILABLE:Server is currently overloaded. Please try again.

Every second.
These errors are no present in 1.1.0 sidecars.

/cc @nmittler @douglas-reid

@Stono you'll need to tune your loadshedding settings, it appears. That's more of an art than it is a science. I believe the default configuration is to reject gRPC requests if P50 latency > 100ms.  If you are constantly stuck there, I'd bump that up. You could try something like 500ms as a shot in the dark, but it'd be better to turn the loadshedding into logonly mode, watch the latency on Report calls for awhile, and then set a limit that matches your environment, watch the logs again, and then turn on enforce when you believe you have a good set of limits.
/cc @mandarjog

Well we don't see it in 1.1.0 sidecars so I don't think I need to tune anything as we're upgrading them all anyway

This should impact both 1.0.X and 1.1 in the same manner, as they should both be hitting the same istio-telemetry workloads, correct?  Load-shedding, in this case, is handled server-side.

They are, but we don't see this in 1.1.0 sidecars....

Closing this as it feels like it won't get fixed, and I didn't see it going from 1.1.6 to 1.1.7, and 1.x is EOL


Provide caret rect to text input plugin

https://github.com/flutter/flutter/issues/77545
Adds required code to provide current caret rectangle to text input plugin. This rect, with addition to current editable transform can be used to position the accent selection menu on macOS similarly to how IME popup is positioned on iOS.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

https://github.com/flutter/flutter/issues/77052

https://github.com/flutter/flutter/issues/30660

Looks like @cbracken is about to land a patch that addresses something similar. Maybe we should wait for that patch to land?
I'm not familiar with how accents work on macos.  Does long-pressing a key initiate a composing region (that highlights the base character) on macos?

Looks like @cbracken is about to land a patch that addresses something similar. Maybe we should wait for that patch to land?

Sure. I wasn't aware @cbracken was working on this when I opened the PR. Don't mean to step on anyone's toes :)

I'm not familiar with how accents work on macos. Does long-pressing a key initiate a composing region (that highlights the base character) on macos?

Not necessarily. The text input controller suppresses normal  key-repeat behavior, showing selection popup on first key repeat instead. However it only enters compositing mode after you change the character selection within the popup. Which currently doesn't work in flutter due to way caret movement and arrow events are handled (but you can still pick up option directly by pressing a number, which works). In which case it generates text insertion event, skipping the composition step altogether.

(PR triage) @LongCatIsLooong @justinmc @knopp What's the status of this PR?

I rebased the PR and added unit tests (as requested by @justinmc). Anything else needed here?