Static property initializers linting error

By using ESLint with babel-eslint I'm getting no-undef errors when using static property initializers.
My .eslintrc is setting babel-eslint properly and .babelrc is also well configured.
When running ESLint from CLI these errors aren't listed.

@fsmaia can you share a workspace that demos the problem ?

Sorry, it was solved when I bumped all versions in package.json. Probably it was a conflict between versions.

Thanks.


Add Page Footer

To do: Build out a custom footer component. Read more here
The footer should look something like this, but for Allo:

Should have the Allo logo in the top left


Conflict with Floating Social Bar Plugin in WordPress

When sites using "Simple Colorbox" plugin also use "Floating Social Bar" (FSB) Plugin the colorbox "picks up" an extra image which forces an error message.
You can view this behavior on any blog post of mine: Example: http://franksdesigns.com/custom-return-address-stamps/
YOu'll see 3 images, the Colorbox reports 4 images, loads the second image first (the first REAL image) If you go back to the first image you get a blank item with this error: "This image failed to load."

Colorbox is doing exactly what it was told to do.  You need to change how you assign Colorbox so that it only selects the elements you want it to.
And you have 4 links on that page that end in '.jpg'.  This is the first one:
Pinterest0

This is how your page currently assigns Colorbox:
jQuery(function($){
			// Examples of how to assign the ColorBox event to elements
			$("a[href$=\'jpg\'],a[href$=\'jpeg\'],a[href$=\'png\'],a[href$=\'bmp\'],a[href$=\'gif\'],a[href$=\'JPG\'],a[href$=\'JPEG\'],a[href$=\'PNG\'],a[href$=\'BMP\'],a[href$=\'GIF\']").colorbox(colorboxSettings);
		});;

You will want make this more restrictive and specific to your site, so that it only selects the images you are interested in showing in the lightbox.  For this page, you could do something like this instead:
jQuery(function($){
    $('.gallery-icon a').colorbox(colorboxSettings);
});


[ConfigTransformer] Use named parameters when tag uses keys

When something is tagged like this:
!tagged_iterator { tag: app.handler, default_priority_method: getPriority }

it should be converted into this:
tagged_iterator(tag: 'app.handler', default_priority_method: 'getPriority')

Before, it would be converted into this:
tagged_iterator('app.handler', 'getPriority')

which is wrong.

@TomasVotruba Before I fix the PHPStan complexity issue I would first like to know if this approach is good or not.

First, it should be converted correctly even without named arguments.
Named arguments can be a benefit from PHP 8. But config transformer will be used definitelly by lots of old projects, it should work even on PHP 7.1 syntax.
Saying that, there are 2 challanges:

fix the bug to with wrong order

add parameter to include PHP version and then print output based on that version - like Rector has Option::PHP_VERSION

Cherry picked in https://github.com/symplify/symplify/pull/3409/files


[VIS] Remapping file

User should be able to decide on node naming, by providing a remap mapping file, such as:
torvalds --> tor
stroustrup --> strou
chomsky --> chm
workernode250.blahblah-workernode450.blahblah --> wn001-wn250

Nai, ayto to issue einai sxetika eykolo kai poly generic, opote aksizei thn prosoxi mas se ayto to stadio!

to teleutaio:
workernode250.blahblah-workernode450.blahblah --> wn001-wn250
praktika,
workernode250-workernode450 --> wn001-wn250
einai trickier.
na to afisw gia twra??


Fix the v78 migration "Drop is_bare" on MSSQL #6707

So #6707 appears to be reporting multiple issues with the drop bare constraint on MSSQL.
https://github.com/go-gitea/gitea/issues/6707#issuecomment-487873555
suggests a piece of code which will try to detect the constraint and execute code to remove it.
This attempts to replicate this code.
Please note I do not have access to MSSQL - so this is untested. (Hence the WIP)

Codecov Report

Merging #6823 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #6823      +/-   ##
=========================================
- Coverage   41.21%   41.2%   -0.01%
=========================================
  Files         421     421
  Lines       58118   58137      +19
=========================================
+ Hits        23952   23958       +6
- Misses      30993   31005      +12
- Partials     3173    3174       +1

Impacted Files
Coverage Δ

models/migrations/v78.go
0% <0%> (ø)
:arrow_up:

routers/repo/view.go
43.03% <0%> (+1.01%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e255df8...7c943c9. Read the comment docs.

@zeripath we have a drone test about MSSQL. And you can run a mssql database on docker.

Fixed and confirmed to be working!

@lafriks what do you mean? The rest of the migrations don't explicitly drop the column - I think the sync2 does that?

I thought this does the drop:
https://github.com/zeripath/gitea/blob/eccab67a3cf4bdb8c068075f1b481957ed756a01/models/migrations/v78.go#L68

Actually it's dropped here:
https://github.com/zeripath/gitea/blob/a10debc778ff67b56d23876cae7f515c0d85891d/models/migrations/v78.go#L76

Btw why aren't you using dropColumns function: https://github.com/go-gitea/gitea/blob/master/models/migrations/migrations.go#L275 ?

OK @lafriks I've changed to use dropTableColumns

dropTableColumns drops columns but only removes the constraints from MSSQL. It misses indexes on other DB types.

Oh great so should we not update dropTableColumns to remove constraints on other types too?

I've reverted the change to dropTableColumns as it's not quite the right thing at present.

This migration has caused many issues to be reported, I'd like to have it in a working state, then we can move the logic of dropping constraints into dropColumns.
On a related note: I wonder why our migration tests didn't catch the fail case. I'm guessing it's like that one user reported where they were using an older version of MSSQL.

So we don't have migration tests for MSSQL as when I wrote the migration tests I didn't have access to MSSQL and it's not entirely clear how to get the T-SQL out of MSSQL.
If I knew XORM better I'd say it should be possible to get XORM to just dummy out the sql commands it would use to create and fill the database and we should be able to just store those but I don't know XORM well enough to do that.

@zeripath so, we need a migration test for MSSQL.

Yes we do.
The correct way to do this, and one that would make it very easy in future to add more migrations is for xorm dump to work correctly - but it doesn't produce valid sql.
Another way would be to somehow get xorm to produce

Anyway there are multiple users out there who are struggling to get to 1.8 because this migration step is still wrong.
If you know a way of getting a t-sql dump out of mssql or can provide a t-sql dump of 1.5.3, 1.6.4 and 1.7.0 I'm happy to add this or we can add it as another pr - however we need to get a fix in.
Similarly if you'd prefer that this was rebased on top of #6849 that's fine, but #6849 would also need to be backported.

Build https://drone.gitea.io/go-gitea/gitea/8698/1/16 shows that when combined with #6851 and #6852 you can see fixes the v78 migration. I'm going to force rebase this back to be just the v78 fix now.

@zeripath merged. Please backport 😃


Horizontal overflow

Description
Described in https://github.com/go-gitea/gitea/issues/24249#issuecomment-1519234504 and https://github.com/go-gitea/gitea/issues/24249#issuecomment-1519235790
Gitea Version
1.20.0+dev-553 and 513
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
try.gitea.io:

gitea.com:

Git Version
No response
Operating System
No response
How are you running Gitea?
gitea.com
Database
None

It's related to :

https://github.com/go-gitea/gitea/pull/19468
https://github.com/go-gitea/gitea/pull/19486

Same issue in dashboard pages.


Handling of Missing Data from API stats calls

During testing it was observed that some phenomena on some sensor instances return no data from the statistics call on the API.
Example:
https://api.opensensemap.org/statistics/descriptive/?format=json&download=false&boxid=5f021451b9d0aa001c3ebb78&phenomenon=PM2.5&operation=geometricMean&window=1h&columns=unit,sensorType,phenomenon&fromDate=2020-08-02T11:29:02.356Z&toDate=2020-08-02T12:29:02.356Z
[
{
sensorId: "5f021451b9d0aa001c3ebb7b",
unit: "µg/m³",
sensorType: "SDS 011",
phenomenon: "PM2.5"
}
]

vs normal response with one or more values returned:
https://api.opensensemap.org/statistics/descriptive/?format=json&download=false&boxid=5f021451b9d0aa001c3ebb78&phenomenon=PM2.5&operation=geometricMean&window=1h&columns=unit,sensorType,phenomenon&fromDate=2020-08-02T15:29:02.356Z&toDate=2020-08-02T16:29:02.356Z
[
{
sensorId: "5f021451b9d0aa001c3ebb7b",
unit: "µg/m³",
sensorType: "SDS 011",
phenomenon: "PM2.5",
2020-08-02T17:00:00.000Z: 0.157037349443589
}
]

At present missing values will cause the sensor detail view to display "- Infinity" as the PM (µg/m³) value.
We need a proper way to handle this and present to the user.
(in future we may replace the API to prevent the missing data)

Handling of missing data improved in commit 948712a
Changed visible in Storybook under SensorViewSelector stories with "missing data"
https://www.chromatic.com/build?appId=5f0e1aa3488d900022d5eb7a&number=36
https://5f0e1aa3488d900022d5eb7a-erhlckscbr.chromatic.com/?path=/story/dial--to-storybook
New look for missing data:


[SPARK-20065][SS] Avoid to output empty parquet files

Problem Description
Reported by Silvio Fiorito
I've got a Kafka topic which I'm querying, running a windowed aggregation, with a 30 second watermark, 10 second trigger, writing out to Parquet with append output mode.
Every 10 second trigger generates a file, regardless of whether there was any data for that trigger, or whether any records were actually finalized by the watermark.
Is this expected behavior or should it not write out these empty files?
val df = spark.readStream.format("kafka")....

val query = df
  .withWatermark("timestamp", "30 seconds")
  .groupBy(window($"timestamp", "10 seconds"))
  .count()
  .select(date_format($"window.start", "HH:mm:ss").as("time"), $"count")

query
  .writeStream
  .format("parquet")
  .option("checkpointLocation", aggChk)
  .trigger(ProcessingTime("10 seconds"))
  .outputMode("append")
  .start(aggPath)

As the query executes, do a file listing on "aggPath" and you'll see 339 byte files at a minimum until we arrive at the first watermark and the initial batch is finalized. Even after that though, as there are empty batches it'll keep generating empty files every trigger.
What changes were proposed in this pull request?
Check the partition is empty or not, and skip empty partition to avoid output empty file.
How was this patch tested?
Jenkins

Test build #75089 has started for PR 17395 at commit 86a7d2f.

Test build #75089 has finished for PR 17395 at commit 86a7d2f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75089/
Test FAILed.

Test build #75094 has started for PR 17395 at commit 42da5af.

Test build #75094 has finished for PR 17395 at commit 42da5af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75094/
Test PASSed.

Let me change this pr into WIP based on the discussion with @HyukjinKwon

Thank you for taking my opinion into account.

Test build #76286 has started for PR 17395 at commit 42da5af.

Test build #76286 has finished for PR 17395 at commit 42da5af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76286/
Test PASSed.

Hi @uncleGen, how is it going?

@HyukjinKwon Sorry for the long absence. I will keep online for next period of time. Please give me some time.

Yea, I just pinged because I am just interested in this :).

hmmm. @uncleGen, shell we close this for now? reopening when it's ready would welcome.


update pytorch codes of ch1-1 and ch1-2

you should not merge this into the master branch, for now, just stay at the PyTorch branch until we find out how to let them live togethret.

这屋网太卡了，卡到点出reopen


Template Response

In https://github.com/BuildTheEarth/website-frontend/commit/1298acbd8c738ff6849d7151fe3852103d930a31 and https://github.com/BuildTheEarth/website-node-backend/commit/86639cb11a891d1d352a66c75d1035c44d3a2f3a


Separate version numbers for each of the play services / firebase libraries

Context #1283
We need to get rid of our one version number and have a separate one for each play / firebase library we use.

This has been fixed and released in 4.0.0


Axis do not stop even if the method is called

We realized that even if the Stop method is called, the axis does not actually stop. However, there is no error. After some troubleshooting we realized that the flattening and unflattening of the Parameters is giving a number out that is none of the stop types.
Namely that saying Decelerate gives out a number that when, trying to typecast it, does not actually lead to Decelerate as a case.
I need to think about the best way to work around this.

The issue was found to be related to the conversion to Double.
Softmotion's three options for Stop are a ring that goes from 11599968 to 11599970 which gets rounded off when going to a Double. So I'll subtract and add the 11599968 before and after the conversion.


CI: test on musllinux

Tests for musllinux, as mentioned on scipy-dev.
The first issue highlighted is #17270, so the CI will currently fail. Perhaps we should have failure toleration to start with?
I used cirrus-ci because it allows one to run tests in a docker container of one's choice. Currently pip installing numpy will require it to build numpy as there isn't a musllinux wheel. This overhead is then recovered by caching the pip cache.
It currently assumes that the alpine image is Python3.10

Thanks @andyfaff, this looks nice and concise. A couple of suggestions:

Can we separate the pip install from the build and test steps in the log, so that we don't have to look at the large amount of link checking noise from pip when looking at test failures
Right now everything works fine up to the ndimage segfault. Rather than failure toleration, how about running python dev.py test -s linalg; python dev.py -s cluster; etc for all the submodules, so we're sure that the build works and tests pass for all but the problematic submodule(s)?

I think this is ready to be merged now.
Should we bother creating musllinux wheels that we upload to nightly? This might be of use downstream. We don't have to release it.

@mckib2 it seems that there may be boost-related fails in special, https://cirrus-ci.com/task/4742343436795904

The tests of arccosh, arcsinh and arctanh that are failing are not using Boost.  The expected true values for these functions are in data files that were generated with Boost.
Before digging into the failures, the first question we should answer is: why are we testing np.arccosh, np.arcsinh and np.arctanh in SciPy?  Shouldn't that be NumPy's job?  If these tests are important, can we push them upstream?
Also note that the documentation for the math library in musl libc says (emphasis added):

Other functions should have small ulp error in nearest rounding mode and the sign of zero should be correct. (the goal is < 1.5 ulp error, ie. the last bit may be wrong, which is met for most commonly used functions, notable exceptions: several complex functions, bessel functions, lgamma and tgamma functions and arc hyperbolic functions)

If we decide that SciPy shouldn't be testing np.arccosh, np.arcsinh and np.arctanh, a pull request to delete those tests is ready to go: https://github.com/scipy/scipy/pull/17315

Might just merge this before anything else goes red.


<EMAIL_ADDRESS>Allow mixed paths

In express docs mixed paths (containing RegExp along with string) are allowed for get(), use(), etc. but current flow typings restrict them.
Here is the fix providing a new express$Path type and using it in express$RouteMethodType interface.

@cema-sp Since this still seems to be the case for the express API, would you mind rebasing this PR or opening a new one? I'd be nice to get this merged.

@GAntoine Sorry for the long response, I have rebased the PR, let me know if you have any questions


About documentation and website

Hi guys !
I just discovered NodeOS ! Its amazing you guys all rocks!
I hope I will help you for development and documentation; and the French translation too (because I'm French).
But I don't understand, where is the source of the node-os.com website ?
First I searched the NodeOS org's repositories for a repository looking like "nodeos.github.io" or "www" or "docs"... but I didn't find any.
Then I browsed the NodeOS/NodeOS repository to find a "docs" branch or a "docs" folder.
I found the docs folder and it looks like the source for the website but weirdly the published docs on the website is more up to date than the source in nthe docs folder...
For example, the page "Using-precompiled-Binaries" exist on the website (http://node-os.com/docs/Using-precompiled-Binaries.html) but not in the docs folder of this repo.
And the markdown file for the sidebar is not filled by a link for that page, but the item exist (https://github.com/NodeOS/NodeOS/blob/master/docs/_Sidebar.md)
So, what it the trick ?
How can I contribute for submiting PRs for the website docs ?
Finally, is there a dedicated team for French translation who I need to talk about before starting to submit PR ? Or I can just submit my PRs ?

@rbecheras sorry to answer so late i thought someone had answered this question.
Someone on our Team has made the website and its laying somewhere on a repository in his account.
If i find it i let you know right away!

Here you go: joshgarde/nodeos.github.io

Ok thanks!
But why not https://github.com/NodeOS/nodeos.github.io ?

Its actually the link you had posted, it has all the commits merged in from joshgarde's repo.

Ok thank you very much.
I close the issue now.


Ban System

Adding the ability to ban and unban people

For this feature to be complete it implies there are users with ManageUsers global role. Should a query to show a users global roles show be included with this?
When banning should we allow for banning multiple users in one request or just one user?
When banning someone who is already banned what is expected behaviour for each of the cases (banned with expires_at set and expires_at unset)?
When unbanning should the entry be removed from the table or set the expiration to now?

i think the ban system is a bit far without the role system first.
allowing multiple bans vs 1 is an easy change but we need a proper permission system

Duplicate of #59


Build maintenance

More build fun - hopefully we can finally get green and be ready for a workshop.

Why the change to drop units? The matplotlib converter should be automatically activated and working. If that's not the case, we need to fix MetPy.

You have temperature and windspeed plotting on the same axis. Matplotlib doesn't grock that apparently as it attempts to convert them to a common unit.

Can we use dew point instead? I'm not exactly wild about teaching with an example that I wouldn't actually advocate in reality.

You've got windspeed tied in throughout, but that notebook should be on the slash and burn list anyway as it's mostly pre the first slash and burn.

Ah, ok. Carry on then.

GREEN!


Returning Option in #[wasm_bindgen] impl block gives error

Summary
This may not be the best example, but for simplicity I am adapting the code from this issue. The problem is as follows:
The following return types work for new with the #[wasm_bindgen] attribute applied to the impl: Universe, Self, Option<Universe>. However, this return type appears not to work: Option<Self>. Is there some deep reason for this, or is this potentially a bug?
extern crate wasm_bindgen;

use wasm_bindgen::prelude::*;

#[repr(u8)]
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum Cell {
    Dead = 0,
    Alive = 1,
}

#[wasm_bindgen]
pub struct Universe {
    width: u32,
    height: u32,
    cells: Vec<Cell>,
}

/// Public methods, exported to JavaScript.
#[wasm_bindgen]
impl Universe {
    // The tutorial has the signature:
    // pub fn new() -> Universe {
    // This signature works:
    // pub fn new() -> Option<Universe> {
    pub fn new() -> Option<Self> {
        let width = 128;
        let height = 128;

        let cells = (0..width * height)
            .map(|i| {
                if i % 2 == 0 || i % 7 == 0 {
                    Cell::Alive
                } else {
                    Cell::Dead
                }
            })
            .collect();

        Some(Self {
            width,
            height,
            cells,
        })
    }
}

This gives the error:
error[E0401]: can't use generic parameters from outer function
   --> src\lib.rs:177:28
    |
139 | impl Universe {
    | ---- `Self` type implicitly declared here, by this `impl`
...
177 |     pub fn new() -> Option<Self> {
    |                            ^^^^
    |                            |
    |                            use of generic parameter from outer function
    |                            use a type here instead

The same problem arises when attempting to use Self with Result and other generics.

The error that arises is the following: E0401: Inner items do not inherit type or const parameters from the functions they are embedded in.. It hints at that an outer type parameter (in this case Self) is being used in an embedded function.
But how can that be when there isn't any inner function? Well, maybe there is. Lets take a look at this even simpler example:
#[wasm_bindgen]
pub struct A();

#[wasm_bindgen]
impl A
{
  #[wasm_bindgen]
  pub fn foo() -> Option<Self>
  {
    None
  }
}

Using cargo-extend we can see what the #[wasm_bindgen] macro does to the function foo with .
impl A {
    pub fn foo() -> Option<Self> {
        #[automatically_derived]
        const __wasm_bindgen_generated_A_f__const: () = {
            pub unsafe extern "C" fn __wasm_bindgen_generated_A_f() -> <Option<
                Self,
            > as wasm_bindgen::convert::ReturnWasmAbi>::Abi {
                let _ret = {
                    let _ret = A::f();
                    _ret
                };
                <Option<Self> as wasm_bindgen::convert::ReturnWasmAbi>::return_abi(_ret)
            }
        };
        None
    }
}

And there you have it. The problem is that the #[wasm_bindgen] macro creates an inner function with a return type that references Self. Which is disallowed according to E0401:
pub unsafe extern "C" fn __wasm_bindgen_generated_A_f() -> <Option<
                Self,
            >

An example that recreates the error without the #[wasm_bindgen] macro could look like this:
pub struct A();

impl A
{
  pub fn foo() -> Option<Self>
  {
    // `bar` is not allowed to reference `Self`.
    fn bar() -> Option<Self> {
      None
    }
    None
  }
}

Thank you for the detailed answer. It sounds like this is expected and there is no viable path to fix this issue in the near term. I suppose explicitly spelling out the type is the best Option then.

That is great to hear! It would certainly remove a sharp corner for newcomers like myself to cut themselves on... 😅
Should the label be changed from question to enhancement then?


Create a Dockerfile to deploy

Create a Dockerfile that can deploy to fly.io as mentioned here:
https://github.com/lightningames/theorderbook#docker

possibly need to make the db litefs or fly postgres in order to work with fly.io as no supported mongodb
see docs: https://fly.io/docs/database-storage-guides/#fly-io-database-projects


Restructure Showcase Apps

Make all projects compatible with MDK 6.0
Add author in readme
Move each projects into separate folders
Add screenshots for all projects
Other minor fixes

Add MultiSelectContextMenuApp app  here https://github.com/SAP-samples/cloud-mdk-samples/blob/restructure-showcase-apps/Showcase_Apps/README.md#applications

ImageHandlingApp

There is an extra .SampleServiceV2Other.xml file  under Services folder
Can we have Same name for both Project and Application (as this is the default behavior for any new project in the editor)? As of now, Project name is ImageHandlingApp but Application name is ProductListApp. (when i executed Check unused files command in the editor, i was looking for ImageHandlingApp in the list but that command list down the app names)

PDFGenApp

Can we update the Showcase_Apps/PDFGenApp/README.md mentioning about adding the bundlerExternals info in the BAS preferences before deploying to mobile services?

There is no DetailLabelViewText property defined in the pdfgenapp.mdkproject>BrandedSettings.json but a text appears in iOS client

PrintAndQRCodeApp

First bullet is no longer needed, right? https://github.com/SAP-samples/cloud-mdk-samples/tree/restructure-showcase-apps/Showcase_Apps/PrintAndQRCodeApp#key-highlights
In Setup Instructions - please mention to provide Externals info ( "nativescript-printer", "nativescript-qr-generator") in BAS preferences before deploying to Mobile Services
There is no DetailLabelViewText property defined in the printapp.mdkproject>BrandedSettings.json but a text appears in iOS client

Open Questions -

should we remove the unused files (except the hidden ones)?
Should we update the schema to latest?

PDFGenApp contains pdfgenapp.mdkproject.zip file.  Is this needed?  I didn't see it referenced in the README.md


Detect and warn when source files are out of date

When we hit a breakpoint, warn the user if the source file is newer than the module containing it.
Please review: @jacdavis @gregg-miskelly @chuckries @paulmaybee

👍

Otherwise looks good to me.

Gregg already covered everything I would have said on this.


Added ARCL Framework as target for installation via Carthage

Is there a reason the Podspec and the GIFs for the README are deleted?

M Sorry about that.. M closing this PR. I will send u another PR for the same Carthage install again. I had to remove Pods for my use case and have send PR from that only.


Profile upon enrollment

This captures system information via a distributed query upon a new node enrollment. Additionally, add some nice UI elements to display it all.

LGTM 👍


Golang Proxy Scrypt module to be compatible with the Perl Crypt::ScryptKDF lib

Wrote this module to be used for creating user passwords in the tm_user table that are backward compatible with the Perl http://search.cpan.org/~mik/Crypt-ScryptKDF-0.010/lib/Crypt/ScryptKDF.pm library being used by Traffic Ops.
The goal is to have this function be useful for Golang TO API testing, TO /login and /users functionality as well.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/661/
Test PASSed.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/662/
Test PASSed.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/663/
Test PASSed.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/667/
Test PASSed.

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/620/

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/621/

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/622/

I agree with @dangogh though, this is great, the login endpoint is one of the "hard" things, great to check off the list for traffic_ops_golang.

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/626/

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/670/
Test PASSed.

SUCCESS
No test results found.
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/671/
Test PASSed.

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/629/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/630/

SUCCESS
No test results found.

FAILURE
No test results found.
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/674/
Test FAILed.

SUCCESS
No test results found.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/633/


Nice error if you don't have Docker

From feedback from @rukletsov .

Codecov Report

Merging #875 into master will decrease coverage by 80.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #875       +/-   ##
===========================================
- Coverage   98.37%   18.11%   -80.27%
===========================================
  Files          24       24
  Lines        1535     1535
  Branches       56       56
===========================================
- Hits         1510      278     -1232
- Misses         23     1256     +1233
+ Partials        2        1        -1

Impacted Files
Coverage Δ

tests/test_cli/test_utils.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/backends/docker/test_docker.py
0% <0%> (-100%)
:arrow_down:

...est_dcos_e2e/backends/docker/test_distributions.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_cluster.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_enterprise.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_cli.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_node.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_legacy.py
0% <0%> (-100%)
:arrow_down:

src/dcos_e2e/backends/_docker/_containers.py
25.58% <0%> (-74.42%)
:arrow_down:

src/dcos_e2e/backends/_docker/__init__.py
27.5% <0%> (-72.5%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6f70c...f837f73. Read the comment docs.


Add merge cells and background color element

@dwiyanr let me know when you are done testing. I can merge and cut a release

hi @ananthakumaran could we merge this?

merged


RTM_EVENTS.MANUAL_PRESENCE_CHANGE Doesn't Fire

It seems the RTM_EVENTS.PRESENCE_CHANGE event does fire but not the manual one.
v2.3.0

Hey, I couldn't replicate this on either the current client or the 2.3.0 client. Mind sending me a code snippet where you'd expect to see this happen?
Also, how are you changing your presence?

I'm setting my away status via /away command as well as the UI
Here's an example of the code & a video:
http://pastebin.com/GyDFALVj
http://screencast.com/t/N7HPQj22Y

Thanks for the context, will take a look

Ok, and to confirm. You've used an API token for coder.swartz account to connect to the RTM API? I believe you should only see manual_presence_change when the user who manually changes their presence is the same as the user that connects to the RTM API stream.

Yep, I just checked this and you should only see manual_presence_change when you're connected as the user who's manually changing their presence. I'm going to close this issue, but please reopen if you're both connected as that user and not seeing the event.

Whoops used two accounts to create the ticket and comment.
Thanks for the heads up about this and confirming the functionality.


Apply enso-formatter

Pull Request Description
Somebody forgot to apply ./run fmt before committing to develop, so now we have a lot of whitespace changes in files.
Important Notes
See https://github.com/enso-org/enso/issues/5166
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Oh, it is actually hilarious. enso-formatter and rustfmt are fighting with each other over changes, so ./run lint fails after ./run fmt. Any ideas? @farmaazon @wdanilo @mwu-tow

Oh, it is actually hilarious. enso-formatter and rustfmt are fighting with each other over changes, so ./run lint fails after ./run fmt. Any ideas? @farmaazon @wdanilo @mwu-tow

This is really strange. IIRC enso-formatter worked by rewriting the Rust files and then calling finally rustfmt to overwrite it once more. Having something conflicting with rustfmt would be no good, as it would make it impossible (or at leat impractical) using autoformatting in the IDE.

I will try to investigate it a bit

It seems the issue was that enso-formatter actually failed to process one of the files and didn't call rustfmt as a result.


dropdown list is not displayed in its entirety

if i open dropdown when i switch folder, my dropdown not displayed.
but i swith to default theme -- all good

Looks like I've got a z-index issue going on. I'll try and get this fixed for the next release

yep, i fix this changed main-content-container: z-index: 9 to z-index-8. But i dont know why dropdown-wrapper with z-index: 1000 !important cant work)

@ivanvkt feel free to open a PR in the future for changes like these!

@gavinmn cool!!! next time I'll open it, didn't think of that))


Errors when running a release build

When doing a windows build of my game, both debug and release, these errors happen exclusively in the release build. The game runs normally with a debug build.

I tried exporting a simple project gd-YAFSM.zip and it works without problem, can you try exporting this project and see if this output any error?
If it works, I guess the resource are not properly exported or loaded. And make sure the resource path in scene file is correct, it happens a lot on Windows since it is not a case-sensitive system.

Yup, looks like there are very similar errors making a build of this without touching the project files. Same issue I had on my personal project of working with debug build but not with a release build

I had the similar error using the version 0.6.1 of the addon and Godot 4.1.1.
Updating the addon to the version 0.6.2 fixes the issue in my case.


Update powervs-utils regions to include us-south and tor

powervs-utils now supports two new zones. Update the version of powervs-utils used to include these.

/retitle MULTIARCH-5163: Update powervs-utils regions to include us-south and tor


Releasing v0.2.7

Description
In the recent PR #1274 , we made a version bump, but didn't clean up the release docs.  So this PR cleans up the release docs.
Also, I made some various linting and text fixing changes.  So... I'm sorry. But it's only the docs/0.2.rst file that is important here.

Checklist

[X] This PR has only one purpose or idea. (Ignoring cleanup, sorry.)
[X] Tests have been added/updated to verify that the new/changed code works.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in setup.py.

Coverage drop looks to be coverage spray.
I think this is good to go!


Updated node provider with npm-9_x and pnpm-8_x

Added npm-9_x and pnpm-8_x to the node provider plus tests. Now, when there is no lockfile, it selects uses npm v9 instead of v8.
These changes will work after this PR on the overlay repo gets merged.
PR Checklist

[x] Tests are added/updated if needed
[x] Docs are updated if needed

There was an error with related to node-gyp. This other PR fixes it.


Fix an issue where adornment can't be clicked in multi-select input fields

I want to merge this change because I want to fix an issue where adornment can't be clicked in multi-select input fields.

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[x] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

Task linked: SALEOR-4086 Variant creator select field widget broken arrow

@bmigirl @Cloud11PL Could this PR also include the same change for single select autocompletes?

@bmigirl @Cloud11PL Could this PR also include the same change for single select autocompletes?

I added the fix for single select autocompletes


ROS2 Development with Visual Studio

Hey there!
I want to incorporate ROS into another Windows project where colcon is not an option.
So I tried to write and run a simple C++ publisher in Visual Studio with a setup like this one:

C/C++ > Additional Include Directories = C:\dev\ros2_foxy\include
Linker > Additional Library Directories = C:\dev\ros2_foxy\Lib
Linker > Input > Additional Dependencies = all .lib files in C:\dev\ros2_foxy\Lib
Copied all .dll files to output

As far as I can see linking is not a problem, but there are two issues right now.
First problem is that I dont habe any pdb files, which means that I can´t debug into ROS.
Would you happen to have these files at hand?
The second issue is that it seems like I get an rclcpp::exceptions::RCLInvalidROSArgsError::RCLInvalidROSArgsError() exception when calling the init function. I tried to call rclcpp::init(0, nullptr); and I tried to build argv myself to pass the path to the .exe file of the Visual Studio project or a working ROS node from my workspace but everything results in this exception.
I don´t expect you to know much about solving this second issue but maybe you happen to have a clue since you work with Windows and ROS.
Apart from that any information about how to run ROS in a Visual Studio Project would be great.

Hi @ItsMeTheBee,
Thank you for your interest in ROS on Windows. We are always interested in talking with users of ROS on Windows and would love to know more about your project. Let me know if you are able to chat about it.
When building with cmake on Windows, pdbs are not typically generated for release builds. If you compile debug, you will have mismatches in the binaries. The ROS2 libraries you are importing into your C++ project were likely built without PDBs. If you need to debug ROS2 binaries, you'll need to rebuild them with --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo.
For the second bug, I suspect that you maybe crossing toolchains. If you install ROS2 from the Microsoft chocolatey distribution (http://aka,ms/ros) these are built with the v142 toolchain. You'll need to make sure that is selected. (When building within the ROS environment, we take care of this for you)
If you can share a sample project, we can diagnose further.
Be well,
Lou

Hey @ooeygui !
Thanks for your answer, I´ve been a bit busy but now I got some more infos.
I checked and the v142 toolchain is already selected.
I managed to build the debug binaries (just FYI I had some issues installing xmllint, not sure if it was my fault or if the tutorial for building ROS on windows is outdated but I needed to build zlib.lib myself).
The issues in rclcpp::init(0, nullptr); happened because I needed to add the path to the ROS binaries to my environment path.
Now I´m getting a "Invalid node name" error. I debugged around a bit and it seems like some characters are added which then lead to that error. Not sure where these characters come from, I added a screenshot of the contents of node_name when I build the class like this:  MinimalPublisher():Node("").

I'm not sure how to share a sample project since all the ROS files (lib, dll, etc) are linked. I´ll try to push it into a new repo and send you the link.
Thanks a lot for your help!

Thank you for the update and screen shots. I'm going to need to be able to reproduce this locally in order to help solve the mystery,
Typically when I see this, it is either a toolchain mismatch (which you ruled out), a calling convention problem (Which shouldn't be the case due to ROS2 code being explicitly tagged), or an optimization problem. The latter are really hard to diagnose because the generated code doesn't actually match what is written.
If you can step through the crossing, you can use the Memory and disassembly windows to see where things go off the rails.
If you can't share your project, I can also do a one on one debugging session with you on your system if you are comfortable. Let me know, and I'll figure out how to contact you about setting that up.

I think you can replicate the error with the code here . The ReadMe should contain everything you need to know.
If this doesn´t work we can do a debugging session as well =)

Hahaha I feel kind of dumb for not trying this sooner, but I just changed the Solution Config to "Release" and it worked :D
Sometimes it's the simple things^^

Ah, I should have had that on the list too - sorry about that. I'm glad it's resolved!

D:\ROS2_source>vcs import --input https://raw.githubusercontent.com/ros2/ros2/humble/ros2.repos src
Fatal error in launcher: Unable to create process using '"d:\python38\python.exe"  "D:\Python38\Scripts\vcs.exe" import --input https://raw.githubusercontent.com/ros2/ros2/humble/ros2.repos src'
What did I do wrong? How should I operate it?

@zanxueyan, I'm not quite sure what you are trying to do, can you elaborate?
I'd recommend using the instructions at https://docs.ros.org/en/humble/Installation/Windows-Install-Binary.html.


Add new device

Here is the lightleak dump:
Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb.zip
Tried building a profile but this was the output:
soul@mintvm:~/Desktop/tuya-cloudcutter/profile-building$ python3 build_profile.py ~/Desktop/2023-12-07_19-14-48_lightleak/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb.bin
[+] Processing file='/home/soul/Desktop/2023-12-07_19-14-48_lightleak/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb.bin' as Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb
RBL containers:
	0x10f9a: bootloader - [encoding_algorithm=NONE, size=0xea20]
		extracted to /home/soul/Desktop/2023-12-07_19-14-48_lightleak/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb
	0x129f0a: app - [encoding_algorithm=NONE, size=0xf4160]
		extracted to /home/soul/Desktop/2023-12-07_19-14-48_lightleak/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb
	0x210f9a: bootloader - INVALID PAYLOAD
Storage partition:
!!! Couldn't unpack KVStorage, perhaps dump file is invalid?
Traceback (most recent call last):
  File "/home/soul/.local/lib/python3.10/site-packages/bk7231tools/__main__.py", line 307, in dissect_dump_file
    kvs = KVStorage.unpack(storage_data, aes=aes)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 455, in unpack
    raise e
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 446, in unpack
    value = cls._read_field(ctx, field, meta)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 327, in _read_field
    item = cls._read_field(ctx, base_field, base_meta)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 284, in _read_field
    adapted = cls._read_value(ctx, meta, field.type)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 261, in _read_value
    return typ.unpack(io=ctx.G.io, parent=ctx, **kwargs)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 455, in unpack
    raise e
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 446, in unpack
    value = cls._read_field(ctx, field, meta)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/main.py", line 302, in _read_field
    return evaluate(ctx, meta.action)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/utils/context.py", line 13, in evaluate
    value = v(ctx)
  File "/home/soul/.local/lib/python3.10/site-packages/datastruct/fields/helper.py", line 147, in _validate
    raise ValueError(f"Validation failed at '{doc}'")
ValueError: Validation failed at 'block magic'; while unpacking 'DataBlock._magic'; while unpacking 'KVStorage.data_blocks'
App code `user_param_key`:
	- found! Extracted to /home/soul/Desktop/2023-12-07_19-14-48_lightleak/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb/Eurolamp_SmartWifiPlus-GU10-6w-RGBCT-Bulb_user_param_key.json
[+] Searching for known exploit patterns
[+] Matched pattern for BK7231N version SDK 2.3.1, payload type ssid
[+] Searching for ssid payload address
[+] ssid payload address gadget (THUMB): 0xD3ABD
[+] Searching for finish address
[+] Finish address gadget (THUMB): 0x1B39B
[!] Storage file not found
[+] SDK: 2.3.1
[+] Device class: oem_bk7231n_light_ty
[+] Version: 1.2.16
[+] bv: 40.00
[+] firmware_key: key8u54q9dtru5jw
[!] uuid was not found
[!] Unable to build complete profile as schema remains missing.

Did I miss something in lightleak?
Dumped it twice in case I forgot to tap the storage button.

Nothing you did wrong, just a bug in lightleak where if you press both read flash and read storage, it uses the same file, and it's technically non-standard.  Just needs a bit of cleanup (truncating at 0x200000).  I'll add a new profile shortly.

Love you dude <3
Will also post a teardown in a bit!

Added as EUROLAMP 147-77903 URGCW1.3 6W GU10 RGBCT Bulb


Compatibility patch for HLTB and Clean Gameview

Currently when you add HLTB (How long to beat) Decky Plugin, it slightly shifts the Clean Gameview sizing, and lowers down the "Play button" a bit, showing a bit of bug.
HLTB is a very useful tool, along with Clean Gameview making things neater. It would be nice to have compatibility for both.

I have discussed this with the dev of HLTB and i think they're rolling out a fix on their end


Data limit - doesnt work

Hello there!
Im noticed that couple days ago many keys with data limit = 0 bytes - working just fine, as there is no limits at all!
Restarting server and turn on\off limits - helps only with some keys, and with couple repeats.
What could be source of that problem, and how fix it?

Thanks for reaching out. It could be that Outline is reading a data limit of 0 as "no limit" rather than "no data." It may be that if you set a data limit of 1 byte it'll work. We'll test this and look into clarifying the intended behavior.

Dupe of #1515


The radical notation module is not working

I tried to paste in 3^(1/4) with the mod turned on, it appeared as \sqrt{\left[4\right]}3
I expected \sqrt[4]{3} instead
Exemple:

Thanks for reporting. This probably occurred due to some substitutions out of order. @Heavenira could you take a look?


[Feat] Support nextjs 15

Target Use Case
If you use nextjs 15 with react 19 and you try to install the library you get an error because of the peer dependency.
shadcn has a great article about this: https://ui.shadcn.com/docs/react-19
Proposal
As a first step add react 19 as peer dependency.

I find it hard to understand why "react": ">=16.8.0" doesn't match the versions 19.0.0-rc-*, but changing this should be fairly straightforward if the library does in fact work without problems in react 19.

Came across this last week as well. I'm working on a basic NextJS example at the moment. Will address this when adding the example

Came across this problem in next 15. For now, you can install with npm install @vis.gl/react-google-maps --force

This should be solved with 1.4.1 (just released)


don't compute a plaintext hash anymore for uploads, use outboxID for stash CORE-8432

Patch does the following:
1.) Drop computing the plaintext hash for uploads. It can be pretty slow for large enough files (big video files).
2.) Replace plaintextHash on UploadTask with a taskHash of the outboxID and whether or not the upload is a preview or full asset. We then SHA256 a string of those two values to get the hash of the upload.

I believe it was a plaintext hash over the whole file so that if a multipart upload didn't finish then when the user did another attempt to upload the exact same file, it would be found in the stash.
Does the new logic handle that?

Yes, I just changed the key to be <outboxID, preview>. The only slight disadvantage here is that if the file changes in between attempts, then we will fail on the ListParts phase more often with this method. I think it is better though overall, since that hash over the whole file could be pretty slow on phones. I tried uploading a 2.5GB video and it would stall for 5-10 seconds on the hash.

I think before since there was no real way to retry an attachment, the file hash was the only way to identify the user was trying to upload the same thing. However, now that a failed attachment stays in the thread view and exposes a "Retry" button, using outbox ID I think is the better play here.

Sounds good, just wanted to make sure the original intention wasn't lost.


Multiboot not working for Hoenn games

Hi there! I downloaded version 1.0.1 onto my Analogue Pocket to multiboot onto my GBA. I was able to get the multiboot to recognize my copy of LeafGreen, however my copies of Ruby, Sapphire, and Emerald would only display "Error reading the data!" after multiboot completed. Do you have any insight on how to get the Hoenn games to read properly?

Hi! I've been already reported this issue. I was investigating whether it was a problem with REG_WAITCNT, but that doesn't seem to be it.
Do you have any way of dumping your games? I'd like to understand what is going wrong, because I actually tested using both E and RS, and I had no issues...
Thanks!

sure, here's a link to my emerald save file: https://we.tl/t-21CDUhlIZO

Hmm... Weird, I can read it just fine. There are a couple of issues, but they don't prevent the homebrew from working for me.
May I ask you to try running the new "Currently Read Info" debug option I added to the main menu? In this zip.
Thanks!
pokemon_gen3_to_genx_mb_debug.zip

Game: E
0x1F1C08FB
0xDC382911
0x1362
0x1362

Interestingly, I booted this with my copy of Sapphire again and it actually worked. I may have misremembered trying both ruby and sapphire earlier, or perhaps the game wasn't all the way in or something? I can get you a backup of my sapphire file if you need, this is the output when run with that game:
Game: S
0x554DEDC4
0xDC382911
0x8012025
0x8012025

As an aside, I tried to select "swap cartridge" and switch in my ruby game but it quit out of the program entirely and started to boot ruby as normal. Is there a trick to getting that feature to work?

0x1362
0x1362

So... The ROM is reading fine.
The issue seems to be that it's not reading SRAM correctly.
So it may be something as simple as the carts not being fully inserted...
How are you multibooting? Are you multibooting without the cart inserted? Or do you have the cart in, then press Start + Select on the GBA logo, and then multiboot? I'd suggest the latter method, if you aren't doing it already...?

Actually, if you still have issues with Emerald, could you try running this version of the debug build?
I think it maaaay have something to do with the banks. But I need proof.
pokemon_gen3_to_genx_mb_debug2.zip

I'm doing the latter start + select method with the cart already inserted to get into multiboot. Here's the latest output from Emerald:
Game: E
0x1F1C08FB
0x8C162460
0x1362
0x1362
0x1362

Found the issue! It's still in ID mode, and reporting the Flash ID, which is Sanyo, or 0x1362. ( https://problemkaputt.de/gbatek.htm#gbacartbackupflashrom )
I have all carts with Macronix flash, so I did not know this, but it NEEDS a second Term command that I am missing.
I am doing some other checks to make sure it fully works.

Can you please try v1.0.2 that I just released?
It should be it. I can't test it myself though, so I really need your feedback. Also, if it loads, try making a trade or changing the clock, and report to me whether it crashed during saving, or the trade concluded successfully. Thanks!
Thanks!

Looks good to me! I got both my Emerald and Ruby games to successfully trade with my copy of Crystal. The only quirk with the trade as far as I can tell is that the Original Trainer of my Crystal pokemon shows up as male in Emerald, while it's actually a female in Crystal. Changing the time also worked fine. Thanks for fixing this issue!

Did you trade those Pokémon to Gen 1 before? Because I am testing myself, and I had no issues like that...?


Support Deflate64 decompression

This adds support for the Deflate64 decompression algorithm, and its use in ZIP archives. Compression is not implemented.
Deflate64 (method 9 in ZIP archives) is a variation of the standard Deflate algorithm.
In Windows Explorer, compressing >2GB files generates a Deflate64-compressed ZIP file.
7-zip can read and write Deflate64 ZIP files.
Entry point is SharpCompress.Compressors.Deflate64.Deflate64Stream, with the same interface as the existing DeflateStream (except only decompression is supported).
Implementation is copied from CoreFX, which is MIT-licensed too. Unfortunately it has to be copied, because it is 1. internal, and 2. not supported on all targeted platforms.
Differences between Deflate and Deflate64 are minor, so I first tried to add Deflate64 support in the existing DeflateStream... but I failed, hence this distinct implementation.

Looks great!
I had thought about using all of the Deflate implementation from .NET Core but yeah it's all internal :(


Orientation bug

(iOS8) When status bar notification is showing, you rotate device orientation, its frame is not right.

fixed in 1.5.1


add config to wither hostility

@RemainingToast can you redo this so it's just the patch you are trying to do? The extra commits are a bit weird


Add documentation on ignoring rules via inline comments.

Per https://github.com/acrmp/foodcritic/issues/115, individual rule violations can be ignored via inline comments in source code, but this isn't documented anywhere.  It took me a while and some digging through the source code to figure out that the correct way to format the comment is as follows:
some_code_here # ~FCXXX

Where XXX is the number of the rule to ignore.

+1.
If it wasn't by @Poohblah, it would've taken a the same or even more time as him to figure it out.


Reduce Python INFO logging verbosity at start-up

Makes two changes to Python worker start-up logging to reduce the verbosity of INFO logs:

Log imports for beam-plugins and modules for beam-plugins at DEBUG instead of INFO (~20 lines per worker)
Has pip invocations at worker start-up run at quiet level 1, suppressing INFO logs (>50 lines per worker)

This reduces the noisy boilerplate logging that happens during these steps but still surfaces errors that occur.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python_Examples PreCommit

Run Python_Integration PreCommit

This has caused #27641, specifically this line:
https://github.com/jrmccluskey/beam/blob/75369abcdf404979b33d95729683ceaef42846a1/sdks/python/container/piputil.go#L41C5-L41C9
TBH it's hard to diagnose, because container startup logs are not available on Jenkins.

I put -q either after --find-links or before -q same issue

Root caused, will open a PR for this


fix: change 'create-next-app' to 'create-nuxt-app'

Hello @OnyekaIjeh, I want to thank you for fixing this issue. It was really very nice of you to contribute. Cool!


MAINT: Use black

black seems to be where the community is going -- NumPy is planning on using it I think (?), and from a quick look it looks like pandas and scikit-learn already do or are headed in that direction. I'm sure @agramfort has opinions/experience to share here :)
It's possible to make a single big commit that makes all the changes, then add this to a git blame ignore file, which removes the potential blame pollution which (to me) was a big barrier to adoption.
So overall +1 for moving to black from me using whatever pre-commit hooks or whatever pandas and scikit-learn have done (despite me actually not particularly liking how black code ends up looking sometimes!).
I can volunteer to help people rebase or merge PRs that are broken by the changes if they need help.
cc @cbrnr who mentioned wanting longer than 79 char line length, this would be one way to do it.
EDIT:

https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/
https://github.com/scikit-learn/scikit-learn/blob/main/.git-blame-ignore-revs

Thanks for opening your first issue here @larsoner 😆!
I'm reluctant to go all Black. Of course this alleviates us from all style-related issues, but on the other hand we sometimes want to use custom formatting to improve readability. This is just not possible with Black.
My vote is to just allow a line length of 92 characters for new code, so no changes are necessary for existing code. Of course, people are then free to rewrap a whole file as part of some other change.

you're so European minded Clemens :)
I would say it's either 0 or 1. Either we go with Black and follow what
sklearn / numpy do or we don't change.
let's not be exceptions here.

Message ID: @.***>

you're so European minded Clemens :)

I hope this is a compliment 😄?
If you really want all or nothing, I'm going to vote against Black.
Can we maybe still do a quick poll just to see what others think?

Leave everything as is (79 chars hard limit with # noqa as a last resort)
Use Black
Just increase our maximum line length to 92 characters

I'm not familiar with Black but I have a vague recollection that I didn't like some of the formatting rules it applies. What would be the benefit of switching to Black (apart from the fact that it seems to be a trend now)?
Currently I'm +1 on staying how it is.

@mmagnuski the benefit is that Black auto-formats everything. The issue is that Black auto-formats everything. So there is no in between if for some reason (readability) you would like to have some custom formatting.

standards are always a middle ground and a compromise. If you deviate
from the standard then it's useless and you are back to exceptions and
it can do more harm than good. Accept the standard as it is or don't
consider it.

Message ID: @.***>

Black is not a standard, it's an opinionated formatter. Line lengths can be set even in Black (https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length), so in my opinion we could set only a new line length (to 92 or 88). I'm happy with our style, it's just the line lengths that bother me.

@cbrnr @agramfort
I'm also happy with our style (much more than what Black does). And I'm happy with current line limit - @cbrnr when is it an issue?

when is it an issue?

Everytime. It's just not enough characters, I almost always have to break it up into multiple lines.
Most recent example: https://github.com/mne-tools/mne-python/pull/10638/files
With 92 characters, the line could have stayed one line:
ch_data = many_chunk[:, ch_offsets[ci]:ch_offsets[ci + 1]].copy()

Now it's this:
ch_data = many_chunk[:,
                     ch_offsets[ci]:ch_offsets[ci + 1]].copy()

I'm neutral on changing the line limit - I rarely encounter such edge cases. And I'd be fine with:
ch_data = (
    many_chunk[:, ch_offsets[ci]:ch_offsets[ci + 1]].copy())

in this particular case. :)
But I understand it can be a bit frustrating at times, when you are forced to perform line-length exercises.

I am in favor of black. I have adopted it for most of my projects and the few times that I have run into issues are heavily outweighed by the consistency, readability, and "ease of reading across projects" that black provides me with.
The issues that i have run into are furthermore typically minor: For example "I want this list to be in one line!" and then black puts it into multiple lines. I can really live with that.
I also use black together with isort to properly sort imports and with flake8 + flake8-docstrings to enforce a reasonable docstring formatting (numpy format).

Everytime. It's just not enough characters, I almost always have to break it up into multiple lines.

+100 on this. 79 chars are just not helping anyone anymore these days. If your display is not wide enough, just enable soft-wraps, but leave the rest of us in peace ;)
No but all joking aside, let's decide to make lines longer. Please.
 I'm so tired of CI telling me I need to reformat stuff because I forgot something again.
Re not liking some of black's rules:
Yeah but so what, at least it will be more consistent than what we're having now :)

I must say I am leaning towards Black (just a little bit) as CIs remind me I forgot something again. But sill reading stories of how Black can rearrange a matrix into 400-line snake monstrocity gives me goosebumps. :)

Just to be clear about what I think the proposals are:

increase our max line length.  sure, +1
Adopt black (with some suitable, possibly non-default configuration), run it on the codebase, and afterward require all subsequent PRs to conform.  I am +1 on this
do as in (1), and also use black in a GitHub commit hook. I am -1 on this and would need to be convinced otherwise / it would depend on the setup and user experience.  To give an example of something I don't want: if we're using pre-commit I do not want it to automatically run black every time I make a commit locally (for big changes, I often make dozens of small commits and then rebase/squash later to make the commits more semantically coherent; running black on every small commit and on every rebase is a waste of time and processing resources). In contrast, if it's up to the user to run black and we have a CI or pull request bot that checks whether the changes conform to our black config...  that would be fine with me but it doesn't fix the complaint that @hoechenberger and @mmagnuski are making (being annoyed at having CIs fail because they forgot to run flake or black or whatever).  So... is there a third way?  Is there something like pre-commit that will only run when you push instead of when you commit?
also adopt isort +1

@drammock we can have a pre-commit on GitHub, but this doesn't mean that you have to use it locally.
So it seems that most of use are fine with increasing our max line length and isort, but we can do that without adopting black, which is still my preference.

But still reading stories of how Black can rearrange a matrix into 400-line snake monstrocity gives me goosebumps. :)

I think there are solutions for that like:

using a trailing comma or
# fmt: off and # fmt: on wrapping that part of the code

https://stackoverflow.com/a/58584557/5201771

Black is not a standard, it's an opinionated formatter

an opinionated formatter that tons and tons of people use and that's also officially hosted on the org of the Python Software Foundation (https://github.com/psf/black) :wink:
@cbrnr I understood your main argument against black is

we sometimes want to use custom formatting to improve readability. This is just not possible with Black.

do you think these situations outweigh the situations where our custom formatting currently makes readability worse?
(especially "cross project readability")

an opinionated formatter that tons and tons of people use

I still think there are more people not using it.

and that's also officially hosted on the org of the Python Software Foundation (https://github.com/psf/black) 😉

That's not a good argument, especially not for MNE-Python. We recommend conda instead of pip, which would be the official tool hosted at PyPA (OK, it's not PSF, but it's basically the same thing).

do you think these situations outweigh the situations where our custom formatting currently makes readability worse? (especially "cross project readability")

I have not used Black extensively, so my experience is limited. I'm using a style which is already pretty close to Black, so maybe y'all are right and we should do it. It's probably really a lot better than our current style.

I looked more into what Black does and I think I'm fine with it. Things I don't like so much I can get used to. I'll test the vscode extension and will likely use it locally.

we discussed during the MNE office hours.
I agreed that switching black is a way forward, although sticking with default black config.
please put your 👍 below this comment if you are on board

Ah, I keep forgetting about the MNE hours. I will try to join you next time!

Is there something like pre-commit that will only run when you push instead of when you commit?

To answer my own question, apparently you can put any executable file into .git/hooks/pre-push so presumably we could set it up so that black runs before pushes, and aborts the push if the check fails.

just a note that after we do this, we should also add a .git-blame-ignore-revs file with the commit hash of the black-and-isort commits. See here for explanation:
https://akrabat.com/ignoring-revisions-with-git-blame/
There may be a few commits in the history we would want to add to that file as well? Not sure, sometimes big moves end up squashed in along with real code changes.

Does anyone have time in the near future to tackle the switch to Black formatting? Once this is implemented, I can enable Black as a pre-commit hook in #11541.

It would be nice to get https://github.com/mne-tools/mne-python/pull/11152 in first if possible since it's big. Maybe https://github.com/mne-tools/mne-python/pull/11064, too, but since I'm authoring that I'm not as worried about the rebase/merge. But I have this marked for 1.4 so it should hopefully get done within the next month.

Could/should we start using Black style in PRs even before the big one is merged? It wouldn't hurt, right?

Yes people can start doing that if they want

please don't use black in a PR that changes things. I would prefer to have
only reformatting
in one PR so I don't have to scratch my head when reviewing.

Message ID: @.***>

I only meant in new code. But it doesn't really work anyway because we're changing our line length from 79 to 88.


Add Turtle* support

It would be nice to add support of Turtle* (any Maybe NTriples*, NQuads* and TriG*) to Rio.
This could be done by adding a disabled by default "star" feature that would add Triple to the term enumeration and renaming the NamedAndBlankNode enumeration to something like Node with also a Triple variant.

This is solved by release 0.6.0; isn'it?

Yes :-)


[Bug Report]: About external config

Steps to reproduce
  "devDependencies": {
    "@farmfe/cli": "^1.0.4",
    "@farmfe/core": "^1.4.2",
    "@vitejs/plugin-vue": "^5.0.4",
    "core-js": "^3.30.1"
  }

import { defineConfig } from '@farmfe/core';

export default defineConfig({
  compilation: {
    external: [
      { jquery: "$" },
    ],
    output: {
      targetEnv: "browser",
      format: "esm"
    },
  },

});

Reproduce link
No response
What is actually happening?
I don't know if it's my question about external configuration or a bug
Using a simple jQuery error(by umd script)

I looked at the translated code and didn't find anything  about module.f fucntion

Here is a simple reproduction of the engineering code
jquery-external.zip
System Info
windows

I'll take a look

fixed in<EMAIL_ADDRESS>


Ticking Memory Connection (java.lang.IllegalArgumentException: id out of range)

http://pastebin.com/4FWd7u9j
I was having blocks appear in the place of others, though it was only visual. Right clicking on them would put 'em right.

Here's a video of the weird block issue: https://youtu.be/OErDxx00500

Block.getIdFromBlock returns -1 for blocks not added to the registry or null. This is possibly a bug in cavebiomes or a compatibility issue with it.

It also with OpenComputers cable at low Y levels on a super flat world if you need a case to replicate @sfPlayer1 .

I'm experiencing those graphical glitches, too.
For example, as I placed a modded wooden door (Biomes o' Plenty, I think) it appeared first as cobblestone/dirt and when right clicking on it then the graphics were corrected to the modded wooden door.

и у меня такой же баг как на видео. ставлю лаву. а там вместо лавы камень земля или песок. кликаю правой кнопкой мыши и лава становиться лавой.
and I have the same bug as video. I put the lava. and there instead of lava stone land or sand. right click and lava to get lava.

@sfPlayer1 This bug has since version 1.4.0 test1. (And without mods this bug is present(Try to use bonemeal))

@fewizz от муки появляются камни и вода=)))
эх...

yay, fixed. Build soon.

NotEnoughIDs-1.4.0Test4

баг пропал..но заметил визуальный глюк. ставишь лаву из ведра и она на 1 миг(меньше секунды) пропадает и возвращается. раньше такова кажется не замечал в самом майнкрафте.. но лаву я давно таким способ ставил...мог и запамятовать..

@SvEgiiVEteR , это вродь в ванильке уже есть.
@stardustrider , now works?

Working for me anyway.

good =P.

When you release a version let me know and I will test it.

Hmm, a similar error with the new 1.4.0Test4:
http://pastebin.com/2XG6XbGP
Maybe you should have another look into it...

Previously (i.e. in Vanilla) this kind of bug would have gone unnoticed. Making the error optional may be doable, but there's likely still a mod bug that needs fixing. In Vanilla it'd just overflow and place the block with id 4095 if someone happens to just enough blocks registered.

Yeah so I have the same error you are discussing
https://gist.github.com/DPxKnightxZero/332eed4bd54f08f1d66e
All I did was make a new world.

@sfPlayer1
So if I understand it right, NEID could do something similar to Vanilla by placing that block with ID 31999 (normally I would say 32767, but there seems to be another limit) or the next lower free ID, if ID 31999 is already set, right?
But then still the question remains what block from which mod caused that issue...
Would be good to set a log entry for that at least.
@fewizz
Just to let you know - the graphical glitches are gone with 1.4.0Test4. So that one seems to be fixed.

I need Fewizz and Player to join my modpack and see this wierd bs. ASAP!
http://www.technicpack.net/modpack/pz-project-ultima-pts.755209/updates
If you need access to any of the files let me know.

Single Player works normal.

If you are wondering what error I was having? Basically Dirt kept replicating placing certain blocks doors have a wierd issue etc. I am going to leave the server up till you can see for yourself.

 If you want I can do rar5 but I am compressing it as much as possible.

"Here's a video of the weird block issue: https://youtu.be/OErDxx00500" My issue as well.

Look at 9 comment

What is the latest Fastcraft?

I am using test17

is this now only broken with fc or even without it?

I will be testing in the next hour please stand by.

Just to let you know everything appears stable.

With what configuration?
With or wothout fastcraft? Which version?
With or without NEID (& NEID Tweaker)? Which version?

With Fastcraft ctest17 and NotEnoughIDS 1.4.0

That sounds good so far!

Well now we have a new issues ... some enemies are their but invisible. Also cannot be hit but using Damage Indicators can be seen. Also they appear on the journey map.

Hmm, some mods like Lykanites Mobs have some sort of invisible mobs. Are you sure that you do not have one of those mods in your modpack?

Well its squids. As in min craft squids.

Hmm, I had squids last evening and they were displayed properly so far. But I'm playing SP at the moment...

I can do that ;P after all it is my purpose of being on this github.

Ticking Memory Glitch - Started After Adding DivineRPG and making a New world.
https://gist.github.com/DPxKnightxZero/1b67f055a9cf89d683e0
Full Client Log after crash
https://gist.github.com/DPxKnightxZero/6962a228ec7107fcb758

@DPxKnightxZero , pls , try use version 1.4.0 T3 (in new world).

Isn't test 4 the latest?
Also test3 wont even run.
You are doing something right in test4

Create new issue if still not fixed with steps to reproduce.


Read timeouts on spotify api

Hi Max, thanks heaps for moving this to java11!
I'm trying to run it on latest MacOS 12.1.
When running it, it runs into read timeout exceptions on the spotify.api. Any clues? Running ping or normal curl commands from the same terminal works just fine.
Cheers,
Andreas

Hi Max, thanks heaps for moving this to java11!
I'm trying to run it on latest MacOS 12.1.
When running it, it runs into read timeout exceptions on the spotify.api. Any clues? Running ping or normal curl commands from the same terminal works just fine.
Cheers,
Andreas

Hey Andreas,
How did you get this run on MacOS?
Stream_reader.pl requests pacmd and pactl on my system, but I did not found the binaries for macOS

For pacmd as part of pulseaudio: https://formulae.brew.sh/formula/pulseaudio
The weird thing is that I don't get any proper logs out of the musicsync application running for hours until it sometimes decides to show me a timeout.

When running the app in me Linux VM, I noticed that stream_recorder.pl is called for every single track from the requested playlist. So far so good, but my Spotify queues all other tracks from the playlist as well. seems linke stream_recorder.pl does not recognize this and keeps on recording until Spotify stops.
Perhaps this produces the timeout on your side.

For pacmd as part of pulseaudio: https://formulae.brew.sh/formula/pulseaudio
The weird thing is that I don't get any proper logs out of the musicsync application running for hours until it sometimes decides to show me a timeout.

Thanks!
How did you make Spotify findable for the stream_reader.pl. When installing it via brew or Spotify page, that does not work.


[Issue 2013]delete useless code for AbstractSendMessageProcessor.java

What is the purpose of the change
#2013 delete useless code for AbstractSendMessageProcessor.java
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.06%) to 50.9% when pulling 3ab377037ad450fe68f47a1e0171da928836ece9 on shendongsd:feature_broker into 7f105361022f3a0de8c1d6feda04d5eba3dba6bb on apache:develop.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@8ef01a6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2012   +/-   ##
==========================================
  Coverage           ?   45.11%
  Complexity         ?     4197
==========================================
  Files              ?      545
  Lines              ?    35732
  Branches           ?     4744
==========================================
  Hits               ?    16122
  Misses             ?    17561
  Partials           ?     2049

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef01a6...3ab3770. Read the comment docs.


perform static code analysis with jshint on each 'build'

gr8 :) Few points:

Use only tabs. No spaces.
Do not commit build files (inside dist/)

Done!
Removed extra spaces and build files
Thanks ;)

merged manually. Nice work :+1:
Note: Open PR against dev branch from next time :)


x/mobile/cmd/gomobile: gomobile install fails when assets dir is symlink

It seems that gomobile fails when the assets directory is a symlink. (In my case equal to ../assets/).
I am using go version go1.5.1 darwin/amd64 and gomobile version +afa8a11 Fri Sep 18 00:19:08 2015 +0000 (android,ios);.
panic: runtime error: slice bounds out of range

goroutine 1 [running]:
main.goAndroidBuild.func4(0xc8201f9140, 0x57, 0xaa4180, 0xc8201f59a0, 0x0, 0x0, 0x0, 0x0)
	/Users/momchil/Workspace/Go/src/golang.org/x/mobile/cmd/gomobile/build_androidapp.go:189 +0x170
path/filepath.walk(0xc8201f9140, 0x57, 0xaa4180, 0xc8201f59a0, 0xc82020bb28, 0x0, 0x0)
	/usr/local/go/src/path/filepath/path.go:349 +0x80
path/filepath.Walk(0xc8201f9140, 0x57, 0xc82020bb28, 0x0, 0x0)
	/usr/local/go/src/path/filepath/path.go:396 +0xe1
main.goAndroidBuild(0xc820156000, 0x0, 0x0, 0x0)
	/Users/momchil/Workspace/Go/src/golang.org/x/mobile/cmd/gomobile/build_androidapp.go:191 +0x1ac0
main.runBuild(0x927140, 0x0, 0x0)
	/Users/momchil/Workspace/Go/src/golang.org/x/mobile/cmd/gomobile/build.go:101 +0x760
main.runInstall(0x927140, 0x0, 0x0)
	/Users/momchil/Workspace/Go/src/golang.org/x/mobile/cmd/gomobile/install.go:36 +0xa7
main.main()
	/Users/momchil/Workspace/Go/src/golang.org/x/mobile/cmd/gomobile/main.go:63 +0x495

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1696 +0x1

Use case: I want to have something that can be compiled both as an Android library but can also be tested as a standalone application, since the later is much quicker to run (and also since Library GL applications are not yet actually supported #12649). I cannot have a lib package and main package in the same folder so they have to be separated and share the assets directory somehow.

CC @crawshaw


Flask_script with venv debug does not working

Environment data
VS Code version:   1.20.1
Python Extension version:  2018.1 (01 Feb 2018)
Python Version:   3.6
OS and version:    Ubuntu 16.04
Actual behavior
ModuleNotFoundError, No module named 'flask_script'
NOTE: if I'll try to run from terminal:
source ./venv/bin/activate
python manage.py runserver --port 50000 --host some.valid.ho.st
All dependencies are working as expected
Expected  behavior
Enable debug and breakpoints. Dependencies imported as expected.
Steps to reproduce:

Add this object launch.json :

{
            "name": "Somename",
            "type": "python",
            "request": "launch",
            "stopOnEntry": false,
            "pythonPath": "${workspaceFolder}/venv/bin/python3.6",
            "program": "${workspaceFolder}/manage.py",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "console": "integratedTerminal",
            "args": [
                "runserver",
                "--port",
                "50000",
                "--host",
                "somevalidHost"
            ],
            "debugOptions": [
                "RedirectOutput"
            ]
        },```
-  Add this workspace settings:
```json
{
    "python.linting.pylintArgs": [
        "--load-plugins",
        "pylint_flake8"
    ],
    "python.linting.enabled": true,
    "python.linting.lintOnSave": true,
    "python.linting.pylintEnabled": true,
    "editor.formatOnSave": true,
    "python.linting.pylintPath": "pylint",
    "python.formatting.provider": "autopep8",
    "python.linting.flake8Path": "flake8",
    "python.linting.flake8Enabled": true,
    "editor.rulers": [
        120
    ],
    "python.terminal.activateEnvironments": false,
    "python.unitTest.pyTestEnabled": false,
    "python.pythonPath": "${workspaceFolder}/venv/bin/python3.6"
}```
## Logs
Output from ```Python``` output panel
None output from Python. From integratedTerminal:

cd /home/path/to/folder ; env "PYTHONIOENCODING=UTF-8" "PYTHONUNBUFFERED=1" /home/path/to/folder/venv/bin/python3.6 /home/user/.vscode/extensions/ms-python.python-2018.1.0/pythonFiles/PythonTools/visualstudio_py_launcher.py /home/user/Documents/project_folder 42923 34806ad9-833a-4524-8cd6-18ca4aa74f14 DUMMYVALUE /home/user/path/tofolder/manage.py runserver --port 50000 --host some.valid.ho.st
Traceback (most recent call last):
  File "/home/path/to/folder/manage.py", line 7, in <module>
    from flask_script import Command, Manager, Option, Server, Shell
ModuleNotFoundError: No module named 'flask_script'```

Output from Console window (Help->Developer Tools menu)
Developer Tools / console is empty

Please confirm flask_script has been installed in /home/path/to/folder/venv/bin/python3.6
Sounds like it isn't installed.
Please try running the script as follows:
/home/path/to/folder/venv/bin/python3.6 manage.py runserver --port 50000 --host some.valid.ho.st

Hi! Thanks for advise.
/home/path/o/folder/venv/bin/python3.6 manage.py runserver --port 50000 --host some.valid.ho.st -
works fine.
So to solve this issue I have add sting "pythonPath":"/home/path/o/folder/venv/bin/python3.6" to launch.json file add that have launched as expected.
At my opinion this this is bug of VS code extention. I think reason in "${workspaceFolder}" flow,because absolute path have launched application. Thank for help. If you need some additional information, I'll be glad to help. Have a nice day and mood.

Duplicate of #691


Updating Rust Driver version and setting a Custom Driver name/version

Currently, we're using an outdated Scylla Rust Driver version and we need maintain it on LTS. But more than that, we gonna need to implement a different driver name under the Rust Driver (for identification inside the Cluster).
Thinking on that, the drivers team recently merged a possibility to settle the driver name/version (https://github.com/scylladb/scylla-rust-driver/commit/36d5edd3a06a6808ce19dd594ea4904c8b48c0c2)
let session: Session = SessionBuilder::new()
  .known_node("<IP_ADDRESS>:9042")
  .custom_identity(
     SelfIdentity::new()
       .with_custom_driver_version("0.3.17")
       .with_application_name("ScyllaDB JavaScript Driver")
       .with_application_version(app_version_from_package_json),
  );

Goal
Upgrade the driver version and validate missing rules to implement this feature.

We could try to change from getting the version from the package.json to the CARGO_PKG_VERSION one instead, it's easier to achieve this in Rust. The only thing that we will need to change to this to happen is sync the package.json bump version to the cargo.toml too.

Hmm, since it will be generating a binary every time I don't think that this can be an issue. We will just have to change this in the Rust side for the versioning...
Apparently Scylla folks are defining a name like the one I sent here so it's only up to versioning.

test

Test


Add Python version in Developer README

This change adds Python 3.10 to the Local Development README page. Currently, if Python 3.11+ is used then the build process fails.
> Task :metadata-ingestion:checkPythonVersion FAILED
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AssertionError: Python version (3, 11) not allowed

Py3.7 and 3.10 are technically both valid (see: https://github.com/datahub-project/datahub/blob/master/.github/workflows/metadata-ingestion.yml#L34), however, 3.7 is already EOL.
I also added the pyenv local version config file to .gitignore since this popular tool allows developers to use pyenv to control their python version.
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Just let the tests run to merge. Typically doc only means they don't get run but the update to the gitignore triggered them so will let them go. Thanks!


Deprecation warning no longer exists

Remove tag from cell and verify that the notebook runs properly.
Closes #1845

I think Runtime is having issues. Let's try restarting CI later today or tomorrow.

I think Runtime is having issues. Let's try restarting CI later today or tomorrow.

This ran for me locally today - I'll try to kick this off again.


Fix large textures

Large textures (8K or 16K) can cause problems, one of which is causing WebGL context loss.  After investigation, also found other issues such as interfering with UI thread while textures are read in and lack of support for these texture sizes in tablets, etc. (even though WebGL reports them as supported).
This PR changes the max texture dimension used on front end to the smaller of 4K or what WebGL lists as supported.
Textures larger than the max are downscaled on the backend using an improved scaler.
In addition, the frontend uses createImageBitmap now, when a properly supported (i.e. Chrome) version of the function is available, to improve performance and UI responsiveness.
https://bentleycs.visualstudio.com/iModelTechnologies/_git/imodel02/pullrequest/193066

Do you intend to work on the other texture-related changes (return image as RGBA instead of RGB) immediately after this?

Yes, hopefully.


is it capable to return user identity information via the /token authentication endpoint?

other than standard attribute from oauth2
is it capable to return user identity information via the /token authentication endpoint
beside,
is a /revoke endpoint available?

with createBodyTokenResponse in BasePassportServer, token information returned as
{
"access_token": "b0e6c4c9933236439101c55e90a52154594a2f0913d5d",
"token_type": "bearer",
"expires_in": 3600,
"refresh_token": "2796b9cace09892ee2ec56ac9dc8781e594a2f0913d98",
"scope": "manage_users"
}
i am thinking if it could return corresponding user identity information like:
{
"id_user": "1",
"access_token": "b0e6c4c9933236439101c55e90a52154594a2f0913d5d",
"token_type": "bearer",
"expires_in": 3600,
"refresh_token": "2796b9cace09892ee2ec56ac9dc8781e594a2f0913d98",
"scope": "manage_users"
}
for /revoke, do you mean i could create an endpoint to do so manually?

Added feature https://github.com/limoncello-php/framework/issues/52

It needs some extra functionality in Passport module. I've added preliminary implementation which I'm planning to finalize later today.

While testing the code I've found a way to improve the code so finalizing takes a bit more.

Passport settings could have a methods for adding extra properties
    /**
     * @inheritdoc
     */
    protected function getTokenCustomPropertiesProvider()
    {
        return [self::class,  'tokenCustomPropertiesProvider'];
    }

    public static function tokenCustomPropertiesProvider(ContainerInterface $container, TokenInterface $token): array
    {
        return [
            'user_id' => $token->getUserIdentifier(),
        ];
    }

added to 0.6.17
I'm closing the question. Feel free to contact if you have any further questions.

noted ^^

tried and tested:
    assert($customPropsProvider === null || $this->checkPublicStaticCallable(
        $customPropsProvider,
        [ContainerInterface::class, TokenInterface::class],
        'array'
    ));

failed at the point of $customPropsProvider === null and checkPublicStaticCallable

@dreamsbond check the method signature. This line ensures the method must have 2 typed parameters and typed return type as array.

@neomerx yes, having the method typed return as array resolved the issue.
but asserting $customPropsProvider === null failed

@neomerx keep telling ErrorException: assert(): assert($customPropsProvider === null) failed

@dreamsbond it does not have a check for signature AND null. It checks either for null OR for a method with the proper signature.

it is quite rare to me.....
after i tried composer dump-autoload
the issue gone..........


Light/Dark theme switch doesn’t always hide NavBar

Description
Light/Dark theme switch suppose to hide NavBar when clicked. Clicking theme switch button doesn't always hide menu which:

not provided by logic
creates bad UX design (user may want to continue exploring si)

Screenshots
https://github.com/EddieHubCommunity/LinkFree/assets/50242030/ca35a36d-9365-4fcd-b42b-68a5af8a74b0
Additional information
No response

I could not replicate this issue, could you share more about your OS and browser?

I could not replicate this issue, could you share more about your OS and browser?
This bug occures in Safari Browser in iOS

This bug occures in Safari Browser in iOS

Interesting, that is what I am using. Let's see if someone else can replicate it

I tried it on Android Chrome & devTools too, but failed to replicate it.
It might be an issue caused due to slow internet or some cached data in your browser!

I tried to replicate this issue on android Chrome, but failed to so.

I happenes every 2-3 clicks. I'll try to test it on other devices.

I tried to replicate this issue on android Chrome, but failed to so.

I happenes every 2-3 clicks. I'll try to test it on other devices.
I tried to replicate this on chrome and brave but it works fine. Even after 2-3 clicks. Might be a Safari issue.

Works fine on android/brave. Issue occurs in safari dev tools. maybe an ios issue


fix(presets): allow merging transform config when using presets

Summary

Addressed in https://github.com/kulshekhar/ts-jest/issues/3828#issuecomment-1256572241
Test plan

Green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-2 of 54 (96.3%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 96.201%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cli/config/init.ts
9
10
90.0%

src/cli/config/migrate.ts
27
28
96.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
4039

Relevant Lines:
4142

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

52 of 54 (96.3%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 96.201%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cli/config/init.ts
9
10
90.0%

src/cli/config/migrate.ts
27
28
96.43%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
4039

Relevant Lines:
4142

💛  - Coveralls


The correct behavior of load balancer algorithms depend on optional stats

Issue Template
Title: One line description
The correct behavior of load balancer algorithms, in particular, unweighted round-robin and unweighted least-request (P2C), depend on optional stats value
Description:
When testing istio default configuration, load-balancer algorithms for unweighted round-robin and unweighted least-request behave like weighted round-robin with all weight 1.
Troubleshooting shows the root cause is due to two stats are not enabled:

max_host_weight in EdfLoadBalancerBase::chooseHostOnce()
https://github.com/envoyproxy/envoy/blob/master/source/common/upstream/load_balancer_impl.cc#L692

rq_active in LeastRequestLoadBalancer::hostWeight()
https://github.com/envoyproxy/envoy/blob/master/source/common/upstream/load_balancer_impl.h#L443

Since these stats are service/cluster specific, it's unreasonable asking control plane installation (e.g. istio) to turn them on by default, unless blindly turning on all cluster.outbound stats.
Ideally it's nice for Envoy to remove the dependency of call logic to the optional stats, say, saving needed info in some other instance variables in addition to stats. Then the call logic is no longer depending on the enabling or disabling of certain stats.
If too hard to do, it's suggested to add clarification in LB documentation. Current doc does not describe dependency of LB to these stats.
[optional Relevant Links:]

Marking help wanted. I agree we can/should do better here.

I think the current issue is related to max_host_weight so #7877 should fix the issue.
About rq_active, I think there is currently no way to disable host stats.  In the future we may want to add a way to disable or otherwise reduce the memory burden of those stats.

Fixed by https://github.com/envoyproxy/envoy/pull/7877


Add better contributing instructions

Tell users how to get started with mack on their local machine.

install poetry
install the dependencies with poetry
run the test suite
anything else?

This is the file that needs to be updated.

@Triamus - a ready-to-use Docker image is a great idea.  Can you please create a separate issue so we can track that request and get it done?  Thanks!

@MrPowers done in #72 .


uv-git should be async

It's hard because the git2 structs aren't Send....

@ibraheemdev should we still do this?

(Presuming this is not relevant anymore)

Our git code is now all process based. Use tokio processes internally isn't clearly better than a single outer spawn_blocking call, so I think it's fine how it is.


Fix for missing dependency?

Should be:
using Newtonsoft.Json.Linq;
instead of
using Unity.Plastic.Newtonsoft.Json.Linq;

Also added fix for Linux Editor

Thank you for your contribution. If you prefer, you're welcome to submit a PR to the develop branch. Alternatively, I can incorporate your changes into the upcoming update that's currently in progress.

Feel free to incorporate them manually, it's only a couple of lines. :)

Will add manually.


Set etcd2 backend for old installations

Depends on: https://github.com/kubic-project/salt/pull/224

it is also related to https://github.com/kubic-project/salt/pull/210


virtualbox: fix extensionPack's hash, fixes #34846

Motivation for this change
Fix #34846.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Is master also affected?

No, virtualbox on master is already on 5.2 and the extension pack's hash is correctly hex-encoded. This was just a mistake in 13c7daac7d16ed3d1a12f775b127102ca1631e87 as can easily be seen by the length of the hash.