Bugs on sample (and maybe library too)

Steps:

choose "activity"
change orientation
Choose "ok result"

Then it crashes.
Tested on Nexus 5x with Android O, OPR4.170623.009
I wanted to put logs, but I don't see anything related to the library or Android OS, that is related to this issue.
When using Fragment, I don't see a crash, but it's still an issue because as I see it, it's supposed to show a snackbar, yet it doesn't do anything.
Also, even without changing orientation, I see something else: if I don't choose "OK RESULT", I always see a snackbar saying there is an error. It doesn't matter what I do, I get this error:
"Activity with request code ... fails expected result code check."

The issue seems to occur even on other projects using this library.
Please fix this.
If you wish, maybe this similar library could help:
https://github.com/tbruyelle/RxPermissions
It's about permissions, but the idea is the same: to get the result from another Activity.

Hi there, version 0.9 is out to address this issue. The error you have mentioned was indeed my fault, at least when starting from Activity. Starting it from fragment, however, requires a bit more work since orientation change recreates that Fragment, see here or example module for more information. Would you kindly try it in your case and let me know if the issue has been resolved?
Thanks for the detailed information and certainly for that RxPermissions link! I should've googled it before creating my own rx permissions library.

Is the fragment issue also fixed?
I gave the RxPermissions sample because I'm very new to Rx (and to Kotlin, but more to Rx), so I find it very hard to help you on this, other than just tell you there is a bug.

I tested the sample with 0.9.
The "fragment" button doesn't do anything.
The "activity" button causes a crash. Here's the log:
10-23 10:11:18.400 3745-3745/com.example.rxactivity E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.rxactivity, PID: 3745
java.lang.IllegalStateException: Could not execute method for android:onClick
at android.view.View$DeclaredOnClickListener.onClick(View.java:5336)
at android.view.View.performClick(View.java:6256)
at android.view.View$PerformClick.run(View.java:24697)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Method.invoke(Native Method)
at android.view.View$DeclaredOnClickListener.onClick(View.java:5331)
at android.view.View.performClick(View.java:6256)
at android.view.View$PerformClick.run(View.java:24697)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
Caused by: java.lang.IllegalArgumentException: Failed requirement.
at com.example.rxactivity.MainActivity.onClick(Unknown Source:26)
at java.lang.reflect.Method.invoke(Native Method)
at android.view.View$DeclaredOnClickListener.onClick(View.java:5331)
at android.view.View.performClick(View.java:6256)
at android.view.View$PerformClick.run(View.java:24697)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Yes the fragment is supposed to be fixed, but I can see it still hasn't in your case. Let me gather more information to be more of help:

On fragment, by "button doesn't do anything", do you mean that next activity is started but onActivityResult is not triggered, or it won't even start next activity?

On Activity, it seems that it is caused by declaring onClick on XML. I will update it to more traditional setOnClickListener once no. 1 is answered.

I actually don't use RxJava that much, but paired with RxAndroid, it can do some pretty amazing asynchronous operations. Kotlin, on the other hand, has pretty much totally changed how I code. It's great that you started, give it some time and you will see that Kotlin's syntax is far more powerful than Java's.

I really mean it doesn't do anything. Anything at all. Nothing is opened. I just checked. "NextActivity" doesn't get opened. Debugging and putting a breakpoint in it doesn't go there.

ok.

About Kotlin, it has some good things, but it also has some disadvantages compared to Java. Java is clearer (less ambiguity than Kotlin). It is more open (overriding is enabled by default). It has more useful visibility modifiers (Kotlin lacks package modifier for classes, for example). Drives to be more efficient (Kotlin suggests to use fields using getters&setters, always, while on Java you can easily use fields when not needed). Less "junk" characters (Kotlin code has a lot of "?" and "!" because of null access). And some other things I forgot that got me annoyed with it.
I will miss Java. I worked with it for a lot of years.
But in all, Kotlin is not that bad. It does usually make code shorter, and I think that if you think enough of what you do , you can work fine with it.
Say, do you know perhaps about Rx as replacement for AsyncTask and AsyncTaskLoader? If so, can you please try to answer this:
https://stackoverflow.com/q/46884644/878126

It seems that those 2 bugs aren't related to onClick or Fragment at all, I just forgot to add default value of SharedPreferences, which again, my bad. Please try the example again as it has been updated.

I think that if you think enough of what you do , you can work fine with it.

Well that is the wisest sayings I've heard today, and there is certainly a truth in that. After all passion is what drives all of us in speaking these non-human languages.
I do use RxJava as a replacement for AsyncTask, or any asynchronous process like REST API. But to be honest, I haven't had a chance to use AsyncTaskLoader and therefore may be unqualified to answer that question.

About the sample, seems both fragment and activity examples work fine.
However, why does it keep saying "onError" for cancelling, finishing, and for custom result?
Shouldn't it provide a result no matter what? there can't be a real error for onActivity result, no?
About replacement to AsyncTask, I see you replied me there. Thanks.

Can you please update the gradle file instructions ? It still says I should use the problematic 0.9 version.
Or maybe the issue was only in the sample?

That actually is the way it is supposed to work. But I do admit it is another one of my fault for not spending much time in README.
But let me explain it here:
For every startActivityForResultAs...(), you should provide an expected result code in second parameter. If no such value is given, Activity.RESULT_OK will be used by default. The emitter will always emits onError() if result code of activity returned doesn't match the expected result when the activity is first started. I find this to be a good use of RxJava's onError(), but in future release I may add support for starting activity without this expected result code.
Version 0.9 isn't actually broken, it was just the example app. What kind of error are you getting from your build.gradle?

So error is just any other result, even if it's a result that can be normally be returned...
Isn't there a way to collect all possible results into the OK result ? After all, the OK is optional. You could return any result you wish, including custom one, with intent data, etc... :

Does your library support getting the Intent data result (including a bundle) ?

Following pattern of my answer in your StackOverflow post, let's use Observable as example again:
startActivityForResultAsObservable(nextActivityIntent, RESULT_OK)
    .subscribe({ data ->
        // if you reach here, then activity started has returned result code: RESULT_OK
        // data is the returned Intent (last param of onActivityResult())
        // to obtain Bundle, call intent.extras
    }, { e ->
        // if you reach here, then activity returned has result code that is not RESULT_OK
        // e.g.: Activity is finished without a result
        // you can still obtain Bundle by calling (e as ActivityResultException).data.extras
    })

I'm actually very open about future development of my libraries. Just like this one, I thought this was the simplest form of starting an activity without having if else code in onActivityResult(), but it turns out to be confusing to some.

I don't say it doesn't work. Just that it's not an error. I don't like to "ride" on callbacks that don't have the correct term.
Original code of onActivityResult can't have an error, so I'd expect everything in the same place.
I have issue with the app we work on, but this might be our code that has issues.
However, even though the sample seems to work fine, I think that the dialogs you create are shown by using the previously destroyed activity.
I can see it by adding a log in the onCreate of the activity, and in the "onNext" within the "onClick", writing what instance of the MainActivity is being used. I can see that for both, it's the same instance, even though the previous MainActivity instance was destroyed.
See here:

So you actually use the previously destroyed instance of MainActivity (memory leak) to handle the onActivityResult of the new one...
See why I think with Rx you have to be more careful than with Android...
:)

Okay I can see your point, thank you for some amazing observation. I suppose it is fixable with activity/fragment instance check I'm currently working on. If not, then I'm afraid this library is doomed.

Sorry I don't have enough experience with Rx to help you on this.
I know only on normal Android framework how it's done: onActivityResult should handle the current instance.

I managed to fix this issue by passing newly created activity in onActivityResult(). There's only one major issue here: since onNext is customized, it is no longer viable to use RxJava's interfaces. You might need to help me rename this lib now...
But for now, would you kindly confirm that example module is working? Only focus on activity-callback code as rx-activity should be deprecated now.

This time, the dialog doesn't get shown on onActivityResult() at all, whether I change orientation or not.
See here:

All I did is press on "activity", and then on "ok result". I didn't change the orientation.

That's odd, I could have sworn it is working fine on AVD and my Pixel XL. I have just pushed another commit, please try it again.

Each time I try to pull the changes it says I have merge issues. I think it's because you have some un-needed folders on the repo, which are specific to your PC configurations (maybe ".idea", not sure).
I have to delete everything and clone the entire repo again and again, after each change you perform.

I still see the "startActivityForResult2" handling being called on the "onClick", which means it will still be called on the activity that died:

I think that the handling of the result should be set in the onCreate. Not in the "onClick". This is because "onCreate" is called before "onActivityResult", so it can be initialized there. "onClick" however is called only by the user.

You have Pixel XL ? I'm interested in this device. How is it? Does it have screen burn?

Anyway, I have to leave this library now. I have other tasks. I might try this at home though.

I'm not sure if it does have anything to do with me being on Mac on you being on PC, but it seems likely. I kinda don't know how to resolve this one.

Actually no, if you look at the last param of startActivityForResult2, it is T.(Int, Int, Intent?) -> Unit where T is the Activity passed from onActivityResult(). So this inside startActivityForResult2 will refer to instance passed from onActivityResult(), not died instance of Activity. But now I'm really baffled because we got different result:

It's the 1st generation though. Speaker could be a little louder, but overall it has been the best phone I've ever owned.

I understand, thank you for all your help!

I got it:
Your log seems to point to this@MainActivity, which already died. While mine point to this@startActivityForResult2, which is a newly created instance. I really do hope we continue this since it has been somewhat productive, but nevertheless thank you for all your help.

Just choose when commiting a change, to ignore the ".idea" folder that you have here:
https://github.com/HendraAnggrian/rx-activity/tree/master/.idea

Actually yes. Every anonymous class has a reference to the class that contained it. It's not a static class you are creating. It's an inner class. There is access to the hosting class (MainActivity) and all of its fields and functions. If you let an anonymous class stay for longer than the Activity that hosts it, and then perform actions on it, they may not affect the new Activity that was created afterwards.
To demonstrate it, you can use a TextView instead of log.

Here, add this TextView to your layout, just above the FrameLayout that has the id "container" :
        <TextView
            android:id="@+id/textView" android:layout_width="wrap_content"
            android:layout_height="wrap_content"/>

Then, change the "onClick" code to have these lines:
override fun onClick(v: View) {
    val textView = findViewById<TextView>(R.id.textView) // this was added
    startActivityForResult2(Intent(this, NextActivity::class.java).putExtra("from", "ACTIVITY")) { requestCode, resultCode, _ ->
        debug("$this Callback")
        supportAlert("Callback", "requestCode = $requestCode\nresultCode = $resultCode", OkButton)
        textView.text="got result..."  // and this was added
        if (resultCode == Activity.RESULT_OK) {
            supportActionBar!!.title = "damn you all to hell"
        }
    }
}

If you don't change orientation when the NextActivity is opened, everything seems ok, because the MainActivity is still the same.
However, if when you go to NextActivity, and then change orientation, you won't see that the TextView has changed, because you do it on the old MainActivity instance.

Does it have screen burn though? I'm worried because it has OLED screen.

But that TextView actually got changed, am I missing something here?

Oh I thought it was only second generation of Pixel that has those issues. Mine doesn't, but then again it's only about 3 months old.

Yes, you are missing the whole issue I wrote in the very first post:
a. choose "activity"
b. change orientation <- you didn't do this part
c. Choose "ok result"

Were you able to see that gif? https://user-images.githubusercontent.com/11507430/31901388-82c58af4-b84b-11e7-9e09-e6f14f478204.gif
The orientation should be changed during NextActivity, right?

Yes, I thought it was shorter. Sorry. Updated

For me it doesn't work.
I've uploaded a video to show the issue.
First I show the case that it works fine. Then I reset it by re-creating the MainActivity. Then, I perform the steps to show the issue.
See here:
https://a.uguu.se/DNNCEpROGDDV_device-2017-10-23-195356.mp4
And these are the changes in code:

if you find identify outside startActivityForResult2, then it points to TextView of a destroyed Activity, no?  Try putting findViewById inside startActivityForResult2 or simply in onCreate.

Something is really weird here.
I did what you wrote, and now it works fine !
But how could it be?
The code of startActivityForResult2 runs on the old Activity. How does writing inside of it affects the new instance of the MainActivity? How when I do there findViewById , it does it on the new instance?
It doesn't make sense...
It's not anonymous class? Then what is it? And how can it reach the new MainActivity on its own? Doesn't it have a reference to the old one?
Is this a Kotlin magic? Or Rx?
I tried to debug the app, but something is wrong on my IDE/SDK because it fails to stop on the breakpoints I put. I tried on older version of the IDE, and on emulator and an older version of gradle . Still can't debug.
I think you just blocked debugging on the sample for some reason. In the gradle file, you've set bad properties for the debug buildType. I had to add this myself:
debuggable true
minifyEnabled false
During debug (after it worked), I noticed there is no reference to the real one. I can't access "this@MainActivity", unless I actually use it in code, which then causes memory leak.
Even weirder, if I call "this", it's actually of the MainActivity type, and it has the new instance.
I then tried to show the bytecode of the MainActivity.kt. The code of startActivityForResult2 isn't there. There isn't even the "applog" text I've put. In fact, even the word "startActivityForResult2" isn't there...
Please explain what is going on. This is very different from what I know on Java, and doesn't make sense to me at all.

It's actually not that complicated, and no RxJava is involved this time.
The last parameter of startActivityForResult2 (callback) is a function types that brings 4 values: Activity/Fragment (T), request code, result code, and nullable Intent. You may see it clearer in Java:

But with Kotlin, that Activity/Fragment is the receiver of that function type. When you call findViewById() within startActivityForResult2(), the java version would look like activity.findViewById(), where Activity is retrieved from first parameter of onActivityResult2():

Since startActivityForResult2() and onActivityResult2() are extension functions, we do not supply it as a param but instead as receiver.
It isn't different at all than what you know in Java, but I suppose shorter syntax makes it look confusing at first glance.

This brings so many questions:

This is an anonymous function. Isn't it the same as anonymous class on Java, just with a function?
Doesn't it have a reference to the higher order scope? Otherwise, how could it reach it when I try to reach it...
They write on the link you've provided, that unlike Java, I can change the values of the higher order scope. Does it really modify them, or just a new instance of them (a clone) ?
You say the first parameter of the Function is Activity/Fragment, but I see in the Java code you've provided it's only Activity.
How did you reach the Java code for this? I can't find startActivityForResult2 in the MainActivity Java code...
Why would "this" actually call the first parameter? Doesn't look intuitive at all... The "this" was supposed to refer to the function... Or is it impossible ?

To me it seems a lot of code here is hidden.

It is anonymous, function types will always be translated to interfaces in Java.
It does have a reference to higher order scope. It's just that since that function type has receiver, this will point to that receiver. If you want to refer to higher order, this@MainActivity is equivalent to MainActivity.this.
I believe they modify. Although I'm not really sure how they do it behind the curtain, they might make a clone without us knowing.
It is actually generic T that I limit only to receive Activity, Fragment, or support Fragment.
I will write the java code equivalent to existing kotlin example to clear things up.
To refer to the function, you may call this@startActivityForResult2, that would point to Activity/Fragment that called that function. But if the function type doesn't have a receiver, this would automatically refer to this@startActivityForResult2.
I'm not sure what this one means.

Yes, I have accepted it as the price to pay to have shorter syntax.

Please take a look at newly added MainActivity2.java and NextActivity2.java.

So it's the same?
If it has a reference to the MainActivity that's getting destroyed, this is a memory leak. Very short one, but still...
I couldn't see that it has a reference to the old one during debug though. Are you sure it has a reference? If so, how did you find it?
My guess is that it's like on C#. It gets cloned, so that the value doesn't really change in the original place. However, if it's a special object, it might get modified within. For example, if it's a list, and you modify one of its items, I think it will change.
Need to test it to verify, of course.
But I see something else in the Java function you showed.
I meant how you showed the Java code behind Kotlin, to see the code of startActivityForResult2 inside MainActivity.
Looking at the code you've shown now, this has a reference to the old MainActivity that's destroyed.
How odd.
Never mind.

Yes, sir.
I'm not sure, it's just my assumption. You clearly have tested it more than I do, so I imagine your findings are far more reliable than mine.
If they do clone some of the variables, won't their hash code differ from the original ones?
It is generic, I just didn't specify the explicit type argument: ActivityCallbacks.<MainActivity2>startActivityForResult(...)
Yes that is why I assume no. 2 has a reference of dead MainActivity. But if we don't use anything from that dead activity, is it still a memory leak?
I typically see it this way: always note whether or not any function you are invoking has receiver.

I completely forgot what this is all about...
2017...

Hello old friend, back then we were leveraging RxJava and Kotlin for Android activity results because we hate request codes LOL. But nowadays Android has a native ActivityLauncher, and there isn't a practical use of the old library.
I wish good luck to you and your career.

OK thanks


Simplify "Building for testing"

Now that https://github.com/rails/rails/pull/46664 is merged, we can simplify the testing instructions.
Technically these instructions aren't true until Rails 7.1, so I'm happy to leave the PR open until then if that's preferred.

:partying_face: Congrats on making that change upstream!
I still feel like people are slow enough to upgrade that it may make sense to keep some version of this explanation around for a while. WDYT?

Yes I agree, I mostly didn’t want to forget about it. We can just keep this PR open for a while. Or are you thinking we have “if you use Rails 7.1, do X, otherwise do Y” style instructions?

I meant, let's leave this unmerged until Rails 7.1 ships.

@flavorjones is this okay to merge now?

@ghiculescu Thank you for the reminder! Merging.


Testing spv2 pc4 3

This should be our last test

Close this in favor of https://github.com/Phala-Network/khala-parachain/pull/227


Fluent update

Added more clean methods to help build queries, Updated the Model protocol to have more convenient  methods. Added StatementGenerator Protocol so that Fluent can have NoSql support later. Adds support for the drivers to handle sql injections by outputting parameterized query and query values as separate properties (That why the drivers can bind the values to the query.)

@timominous let me know what you think about the filters in this case

@Prince2k3 is there a need to import Foundation?

No... I did removed them in another PR though


Potential performance regression in Realm 5

Goals

Over at https://github.com/insidegui/WWDC we are working on upgrading to Realm v5 to take advantage of DispatchQueue-bound realms. Unfortunately, we have encountered what seems to be a performance bug in Realm v5. I have compared the behavior of updating ~1600 realm objects before and after the upgrade.
Unfortunately, we use RxRealm in addition to Realm, which means we have 2 dependency updates happening at the same time. We're upgrading Realm specifically to work through some crashing, so the Realm 5 branch has changes including moving to queue-bound Realms in some areas.
As a result, our goal here is to determine whether the issue lies within Realm or how we're using it.
Expected Results

We expected that the same operations with the same features would behave roughly the same before and after the upgrade.
Actual Results

Realm v4 shows a roughly 2 second 100% thread usage after the updates are committed.

Realm v5 shows a roughly 40 second 100% thread usage after the updates are committed.

Steps to Reproduce

I have created 2 branches in our repository targeting different realm versions that will ensure the issue is always observed after app launch.
These branches can easily be built and run on the WWDC scheme with no additional changes.

checkout branch
execute ./bootstrap.sh to setup appropriate versions
open WWDC.xcodeproj
Run the application, the transcripts take around 20-30 seconds to download and get committed

Realm v4: https://github.com/insidegui/WWDC/compare/master...ah/master-plus-always-index-transcripts
Realm v5: https://github.com/insidegui/WWDC/compare/master...ah/realm5-plus-always-index-transcripts
Code Sample

Unfortunately the app is not as simple as a concise code block for reproduction, but the core code path that precedes the CPU usage is here
fileprivate func store(_ transcripts: [Transcript]) {
    storage.backgroundUpdate { [weak self] backgroundRealm in
        guard let self = self else { return }
        os_log("Start transcript realm updates", log: self.log, type: .debug)

        transcripts.forEach { transcript in
            guard let session = backgroundRealm.object(ofType: Session.self, forPrimaryKey: transcript.identifier) else {
                os_log("Corresponding session not found for transcript with identifier %{public}@",
                       log: self.log,
                       type: .error,
                       transcript.identifier)

                return
            }

            session.transcriptIdentifier = transcript.identifier
            session.transcriptText = transcript.fullText

            backgroundRealm.add(transcript, update: .modified)
        }

        os_log("Finished transcript realm updates", log: self.log, type: .debug)
    }
}

Version of Realm and Tooling

Realm framework version: 4.4.1 vs 5.2.0
Xcode version: Version 11.5 (11E608c)
iOS/OSX version: 10.15.5
Dependency manager + version: Carthage @0.34.0

seeing similar behavior as well.

It looks like it's spending 2/3 of its total runtime scanning the transaction log to check for schema changes in places where there isn't actually a schema change listener registered. Should be pretty simple to just not do that.

Turns out 2/3 was a dramatic underestimate. Before/after comparison with https://github.com/realm/realm-core/pull/3811:

@tgoyne Thank you so much for the rapid turn around! As we're trying to cut a new release with Realm 5, could you help us plan our strategy by providing a rough ETA on a release with this fix?


ESC key missing

Hey there,
One day poof, ESC key missing, Pock useless.
Quitting Pock returns the ESC key to it's rightful location.
Been using Pock for years.
Have a nice day.
Describe the bug
A clear description of what the bug is.
How to reproduce
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll to '....'
4. See error

Expected behavior
A clear description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
To take a Touch Bar screenshot use the shortcut "shift + cmd + 6"
Crashlog
If applicable, add crashlog to help me investigate your problem.
1. Open the Console application located at "Application -> Utilities -> Console.app."
2. Click on "User Reports" in the left menu, then locate the latest Pock crash report. (You can filter reports by typging "pock" into the searchbar on the top)
3. "ctrl + click" on the latest Pock crash report and click on "Reveal in Finder" option, then attach the .crash file in this issue.

Versions:

macOS version: [e.g. 10.14.5 (*required)]
Pock version:  [e.g. 0.5.2   (*required)]

Additional context
Add any other context about the problem here.

imagine if folks downloaded the app and it included the latest widgets and didn't require giving the app "cloud Blanc"?


project tslint.json rules are not working as expected

I've a tslint.json file that I expected would replace the gts one (I would, in practice, use the extends functionality to only override gts but have elected to not do that for the sake of minimizing the surface of the problem).
tslint.json is in the same directory that I am running gts from, I am running gts via npx with the --no-install flag so prevent gts from being installed. I've manually installed gts as a dev-dependency for my project.
My example tslint.json file is as follows:
{
  "rules": {
    // Disable no-default-export for now. Until I can rewrite the routes in to classes like I desired.
    "no-default-export": false
  }
}

It is my understanding that tslint.json supports comments (JSON with Comments format).
	},
	"typeAcquisition": {
		"enable": true
	},
	"compileOnSave": false,
	"include": [
		"src/*.ts",
		"src/**/*.ts",
		"test/*.ts",
		"test/**/*.ts"
	],
	"exclude": [
		"node_modules"
	]
}

This is mostly copy-paste from gts's tsconfig, as I did not like hiding parameters that other developers may not expect.
From package.json, this is the relevant parts.
  "scripts": {
    "check": "npx -q --no-install gts check",
    "clean": "npx -q --no-install gts clean",
    "fix": "npx -q --no-install gts fix",
    "posttest": "npm run check"
  },
  "devDependencies": {
    "gts": "^0.6.0",
    "tslint": "^5.10.0",
    "typescript": "^2.9.1",
  },

When I run npm run check, and I see that npx -q --no-install gts check is executed, I expect the result to not include errors involving default exports. However I see results like this:
Use of default exports is forbidden (no-default-export)
  2 | import { byId } from '../../db/user';
  3 |
> 4 | export default async function(req, res) {
    |       ^
  5 |     const JWT = await openJWTFromHeader(req.headers.authorization);
  6 |     const subject = JWT.sub;
  7 |     const user = await (await byId(subject)).populate('role').populate('organization').execPopulate();

Until such time that we have a Sprint to rewrite our express routes to not use default exports, I would like gts to not flag this as a violation of style. Please help me remedy this, be the issue a fault in my configuration, or a fault in google/ts-style.
Thanks

After looking at the built output of the installed gts module, it seems that the published version I have may not match the current source of this repo.
function lint(options, files = [], fix = false) {
    const tslintConfigPath = path.join(options.gtsRootDir, 'tslint.json');
    const program = createProgram(options);
    const configuration = tslint_1.Configuration.findConfiguration(tslintConfigPath, '').results;
    const linter = new tslint_1.Linter({ fix, formatter: 'codeFrame' }, program);
    const srcFiles = files.length > 0 ? files : tslint_1.Linter.getFileNames(program);
    srcFiles.forEach(file => {
        const sourceFile = program.getSourceFile(file);
        if (sourceFile) {
            const fileContents = sourceFile.getFullText();
            linter.lint(file, fileContents, configuration);
        }
    });
    const result = linter.getResult();
    if (result.errorCount || result.warningCount) {
        options.logger.log(result.output);
        return false;
    }
    return true;
}

So perhaps this issue is only blocked by a release to npm.

Yes, I expect this should be resovled with our next release. Working on that now.

This was fixed by https://github.com/google/ts-style/pull/159.

Fixed in v0.7.0. Please try it out and report back if this is working better.


Typos found in a number of method parameters

Whilst looking through the python methods I've found a number of strange inconsistencies, which I suspect are typos in the parameter names. Although, changing them would be a breaking change, I do suspect this is not intentional and may be a bug from how they were written/generated?
E.g.  m_ass in trpoin
    def trpoin(self, x="", y="", z="", vx="", vy="", vz="", chrg="", m_ass="",
               **kwargs):
        """APDL Command: TRPOIN

        Defines a point through which a particle flow or charged particle trace
        will travel.

        Parameters
        ----------
        x, y, z
            Coordinate location of the trace point (in the active coordinate
            system).  If X = P, graphical picking is enabled and all remaining
            command fields are ignored (valid only in the GUI).

        vx, vy, vz
            Particle velocities in the X, Y and Z directions (in the active
            coordinate system).

        chrg
            Particle charge.

        mass
            Particle mass.

        Notes
        -----
        Defines a point through which a particle flow or charged particle trace
        [PLTRAC] will travel.  Multiple points (50 maximum) may be defined
        which will result in multiple flow traces.  Use TRPLIS to list the
        currently defined trace points and TRPDEL to delete trace points.

        The VX, VY, VZ, CHRG, and MASS arguments only apply to charged
        particles.

        Distributed ANSYS Restriction: This command is not supported in
        Distributed ANSYS.
        """
        command = "TRPOIN,%s,%s,%s,%s,%s,%s,%s,%s" % (str(x), str(y), str(z), str(vx), str(vy), str(vz), str(chrg), str(m_ass))
        return self.run(command, **kwargs)

It seems to be something related to the as characters as pycharm picked up the same issue in multiple places:

And most explicitly in ednb
    def ednb(self, option="", cname="", ad="", _as="", **kwargs):
        """APDL Command: EDNB

        Defines a nonreflecting boundary in an explicit dynamic analysis.

        Parameters
        ----------
        option
             Label identifying the nonreflecting boundary option to be
            performed.

            ADD - Define a nonreflecting boundary (default).

            DELE - Delete a nonreflecting boundary.

            LIST - List all defined nonreflecting boundaries (remaining fields are ignored).

        cname
            Name of existing nodal component to which the nonreflecting
            boundary is to be added or deleted. For Option = DELE, use Cname =
            ALL to delete all defined nonreflecting boundaries.

        ad
            Activation flag for dilatational waves (dampers normal to waves).

            0 - Dilatational activation flag is off (default).

            1 - Dilatational activation flag is on.

        as
            Activation flag for shear waves (dampers tangent to waves).

            0 - Shear activation flag is off (default).

            1 - Shear activation flag is on.

        Notes
        -----
        Nonreflecting boundaries can be defined on the external surfaces of
        SOLID164 and SOLID168 elements that are being used to model an infinite
        domain. They are typically used in geomechanical applications to limit
        the size of the model. For example, when a half space is being modeled
        with a finite geometry, the nonreflecting boundary option can be used
        to prevent artificial stress wave reflections generated at the boundary
        from reentering the model and contaminating the results.

        When using nonreflecting boundaries, you should not constrain the nodes
        at the boundary; doing so would negate the presence of the dampers.
        Usually, the large mass of the finite domain is sufficient to resist
        motion.

        This command is also valid in SOLUTION.

        Distributed ANSYS Restriction: This command is not supported in
        Distributed ANSYS.
        """
        command = "EDNB,%s,%s,%s,%s" % (str(option), str(cname), str(ad), str(_as))
        return self.run(command, **kwargs)

Renaming parameter names shouldn't be an issue considering that not everyone is going to use kwargs in the first place.  Feel free to submit a PR if you have time, otherwise I'll take a look at this today.

Ultra busy with getting plotting.  I think this is right up your alley @jgd10, do you want to self assign yourself to this issue?

shall do


Repo maintained anymore?

Just wanted to see if the authors of this repo are maintaining it anymore, or if its been left for the larger community.

i have always felt this way.  there is little to no movement on this repo except to update dependencies

i am actively using this project, i may create another repo and so it can be maintained properly

Hi All, I am no longer part of Microsoft and due to my current employment can no longer contribute to this project. I did contact forks at Microsoft but haven't heard back anything. If anyone plans to fork and maintain it, I can help with any knowledge required.

i am actively using this project, i may create another repo and so it can be maintained properly
If you fork it, I'll contribute.  I'd like to keep this project going, there are not many open source rules engine projects for dotnet out there!

i created a fork and i have been actively making changes since.  mostly today

Just made the first release in my fork. Updated dependencies and updated to c# 12.0

Neat.  I have solved ALL issues in my fork.  I will be supporting new features and issues in mine.

@asulwer First off all great work! it seems you are determined to take it forward. Just a couple of advice:

RulesEngine traditionally has been conservative towards making breaking changes, if we do, we give people some grace period to move to new implementation.
Since your fork fixes couple of issues and adds new features(and potentially breaking changes), it would be great to add a migration guide(in case u release to nuget) . Users might eventually move to the fork but that would require a little hand holding.
Also you might want to look into the .github folder. It has CI pipelines for PR check. and along its history it had full release pipeline (which was later removed and moved to azure pipelines). It can help setup the release process

@abbasc52
Thank you for the template to the workflow. Just integrated  an updated version of it.

Hey guys, we are using this nugget in one of our core applications… thats essencial we keep maintaining it, count on me on it.
Lets talk to see the future plans for it
Thanks for the great job so far 😄

@abbasc52 we weren't sure if you were still active.  your linkedin profile states you are no longer with Microsoft.  we assumed this meant this wasn't going anywhere.  if you want to sit back and take a break thats fine, would you be willing to let a contributor move this forward? or maybe separate from Microsoft?  my planned direction will continue to make large breaking changes.  my fork wasn't to push you out, please do not think that.  issues are being resolved but not closed, just doing what i can.

@asulwer On the contrary, I want some to take it forward. I believe it is a great project and dont want it to die like this. I have been trying to get someone at Microsoft to take it forward but did not get much confirmation on it.
My comments earlier were just meant to ensure people looking for a maintained folk have a easy way out. If you have a different goal in mind, that is fine too :)
@RenanCarlosPereira , @timophe-91 , @RenanCarlosPereira  and @asulwer maybe you guys can come together and come up with a plan and a single fork? together it should be easier but you would need to agree on where this project should head
I know it is asking too much out of you folks given I cant contribute anything anymore. Just a selfish wish to make sure this library remains useful to others :smile:

I would love to work together on this. But my issue is i don't want breaking changes so early and more in the long run with backwards  compatibility if possible.
And since there are so few RulesEngine for .net it maybe could help too to split and it must not be a bad thing.

I'd love to collaborate on this project, but my main concern is avoiding frequent breaking changes, especially early on. Maintaining backward compatibility in the long run is crucial. Since I'm using this in a working environment, it would be difficult to justify (frequent) migrations to higher-ups. Given the limited number of Rules Engines available for .NET, it might be beneficial to explore splitting the project, as this doesn't necessarily have to be a negative outcome.

@asulwer we can do it.
I don't want any breaking changes any soon as we are using it in some big projects.
I just have only one big concern thats come from this bug 🥺
https://github.com/zzzprojects/System.Linq.Dynamic.Core/issues/821
Lets keep this going with minimal breaking changes as possible.
If you guys want we can set up a quick meeting to talk about forks and other stuffs

@RenanCarlosPereira if RulesEngine is affected please move this to an issue.

Yeah it’s affecting it, I will open a bug, with an example of unit test on how its affecting it, thanks

change is inevitable.  at the request of users, breaking changes occur in my fork but...current incorrectly created methods have been marked obsolete to support old code.  i am moving in a new direction with my fork, so is it a fork? for now yes but in the future no.

@RenanCarlosPereira if RulesEngine is affected please move this to an issue.

opened a new bug for this:
https://github.com/microsoft/RulesEngine/issues/614

@abbasc52 is there a continuation plan for this project? if you are not working for this project, how are we able to move forward but still making sure that we maintain the correct practice of PR's, code reviews and checks? And who might be the best candidates as the gate keepers of this codebase?

@jerbersoft did you take a look at my fork?  all of the listed issues have been resolved there.  i wasn't opening PR's as i should but that has changed

@jerbersoft there are different forks now.

We will try to maintain it in the @asulwer branch
We are going to keep minimal breaking changes.
Please feel free to join as a contributor
Only PRs are allowed, we have 2 breaking changes, not planning to introduce any other breaking changes (not for now)
If we do we will ask the comunity and discuss it together before any release or major changes

@timophe-91, I have reviewed the code changes from 6.0.0 to 6.0.3 and its safe to make the move
Please be aware about those 2 breaking changes in the 6.0.0, other than that all the behavior remains the same.

@RenanCarlosPereira I've got my reasons to not trust that fork. But here is not the place to talk about those things. :) As said in another place, i stay with my own fork. :)

No problem @timophe-91
I got it, anyway, I will try to keep everything in order there, in case you change your mind.
Cheers 🍻

I just found out this is unmaintained and opened https://github.com/microsoft/RulesEngine/issues/625 to mark it as such.
However, what is the active/best fork now? I found the following:

https://github.com/timophe-91/RulesEngine
* https://github.com/asulwer/RulesEngine

Could not you work together to have one active fork?

Hi @rklec,
Thanks for bringing this up. I’m co-maintaining the RulesEngine fork along with @asulwer. This fork is quite active, and we’re committed to addressing issues and updating it regularly. Feel free to contact us anytime — we’re here to help and will do our best to resolve any concerns as quickly as possible.
As for @timophe-91, he’s maintaining his fork independently.
While I’m not entirely sure of his specific reasons, I’m sure he has his motivations for doing so.
For my part, I’m fully invested in the @asulwer fork, which I’m also using in projects for several large companies globally. This is the version I recommend for ongoing development and support.
Best regards,

I just found out this is unmaintained and opened #625 to mark it as such.
However, what is the active/best fork now? I found the following:

https://github.com/timophe-91/RulesEngine
https://github.com/asulwer/RulesEngine

Could not you work together to have one active fork?

I'm not working in the fork of asulwer. As mentioned before i have my reasons to to not do that.

Sorry everyone! Please let me know any pull request needs to be merged


Randomization and loops

The loop and random functions are in babeUtils - babeUtils.loop, babeUtils.loopShuffled and babeUtils.shuffle
const views_seq = [
    intro,
    babeUtils.loopShuffled([
        spr,
        forcedChoice,
        ], 3),
    postTest,
    thanks
];


Added Serde support

This adds serialization and deserialization support via serde. This is done through an intermediate type that wraps each instance of T with its count.

Published in 0.1.5 :tada:


update for node10

Looks like this was an issue from upath. They weren't supporting node 10

Just a minor change: can you change the header to say "For Node 10 Users"? :)

of course. done


feat(button): stacked style flow support

add button stacked flow style to meet teams demand
Closes #1156

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Ripple overflows the button region

Ripple overflows the button region

(Happens on my iOS)

it happens also in Safari for all the outlined+pill buttons. I'll check it out

Ripple overflows the button region

(Happens on my iOS)

it happens also in Safari for all the outlined+pill buttons. I'll check it out. Maybe we should deal with it in a separate issue?

If it's not related to this new change, of course


Add msmarco v2.1 trec rag

Dear all,
with a focus on the current TREC Rag task, this is an initial implementation for accessing documents via the corpus_iter and the document store for the document and the segmented document datasets of MS MARCO v2.1.
This is not completely finished (i.e., mainly documentation todos in the corresponding tickets are open), but as the deadline is soon, this might be useful for others even when the documentation is not yet completed.

Hey- can you try out the revision? I was getting errors running the tests before, so I refactored a bit. Now it's using the classes from v2 where possible.

Perfect, nice that we could re-use more code from v2 classes, thanks!
The changes look good, I started the tests, I think they will run for a while, and will report back when they still work. (but I think everything should work)

Hi, an update from the tests, they still run on my machine and also the other scripts that I had still work, so everything seems to be fine from my side.


[TRI-3840] Logging infinitely recursive javascript objects crashes, inside flattenAttributes.

Problem
If you try and log an object that has a circular reference, our flattenAttributes code will exceed the stack depth and fail.
Example: a user that has blog posts that have an author (that points back at the user).
This is a major issue with MongoDB which returns JS objects like this.
Solution
Detect circular objects and don't add them to the log output, put a placeholder string instead.
From SyncLinear.com | TRI-3840

hey @matt-aitken solve this issue please checkout this PR #1433


chore: address new linter errors

A new version golangci-lint came out and alerted us to some fresh lint errors in the nightly CI run (link).
I'm not in love with min -> mini and max -> maxi so happy to take naming suggestions #nameingishard

Codecov Report
Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (6d9b7ae) to head (2f45f3f).

Files
Patch %
Lines

client/v2/client.go
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   79.18%   79.11%   -0.08%
==========================================
  Files          74       74
  Lines        5669     5669
==========================================
- Hits         4489     4485       -4
- Misses        880      884       +4
  Partials      300      300

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


The parameters doesn't work

The parameters doesn't works. This I have in routes
SimpleRouter {
  routes:
   [ { path: '/user/:id', method: 'GET', fn: [Function: getUser] },
     { path: '/', method: 'GET', fn: [Function] } ] }

If I request with curl -X GET http://localhost:3000/user/4 it return undefined but I I change the router without parameter and request curl -X GET http://localhost:3000/user it receive a body correctly

I just gave a first pass to the SimpleRouter docs: https://github.com/Dashron/roads#simplerouterroad-road. Let me know if you have any questions.
Also, I wanted to give you heads up that I'm moving the body parsing into middleware. I'll make sure to document the change.

@Dashron I like the to put the prefix # and $ because everything that you expecify the type is good. I think in the docs is mixing ’SimpleRouter.midleware(args...)’

At the moment I'm keeping that private, I should probably rename it to _middleware. There's some weird stuff with the request context that makes it complex to open up publicly.

There are some examples in the use documentation here: https://github.com/Dashron/roads#use-callback. The tl;dr is that you should add middleware before you mount the router for any before-route action, and you have two options for post-route actions.

From within middleware added before the route action, put your "after-route" logic in the "then" handler of the promise returned from next();
Add middleware after the route action and make sure your route calls next();

Let me know if you want further examples

It would be cool an example about this case that I mentioned before please

sure. I just added a new section to https://github.com/Dashron/roads/blob/master/README.md#use-callback called "How do I control the order my logic executes?". Let me know if that clears it up

Yes now I understand completly. For example to create a before and after middleware I can do it.
app.use(function (method, path, body, headers, next) {
    console.log('A ' + method + ' request was made to ' + JSON.stringify(path));
    if(next) return next();
});

router.addRoute("GET", "/user/#id", (url: any, body: any, headers: Headers, next: Function) => {
    console.log(`These are the parameter user ${JSON.stringify(url.args)}`);
    return next();
});

router.addRoute("GET", "/person", (url: any, body: any, headers: Headers, next: Function) => {
    console.log("This is a example");
    return next();
});

router.applyMiddleware(app);

app.use((method, path: any, body, headers, next) => {
    if(path.path === '/user/5') {
        console.log("10");
        return new Response({id: "10"}, 200);
    }
    if(next) return next();
});

I have only two small comments on your example.

You will always have next, so you shouldn't need to wrap that in an if statement. Even if there is no additional middleware you will get a next that just immediately returns.
The final function (with the path check) might not always execute. If your logic in the router doesn't call next(), it won't check for /user/5. To ensure you don't have to remember to call next() in every single router function I recommend you include that after logic in your "this is an example" section like this.

router.addRoute("GET", "/person", (url: any, body: any, headers: Headers, next: Function) => {
console.log("This is a example");
return next()
.then(function (method, path: any, body, headers, next) {
if(path.path === '/user/5') {
console.log("10");
return new Response({id: "10"}, 200);
}
});
});

If you provide arrow functions to the use function, they won't have the proper request context. This is a limitation of arrow functions and unfortunately something I'm not able to work around.

About the if was some problem with the typescript that I put it as optional argument and typescript force you to put if, anyway I changed it and now It is required to put it as argument then is no necessary if.
About the second point I have to do like this how I'm doing, I know that I have to call the next function If I want execute the next middleware otherwise I cannot create decorations https://github.com/spieljs/spiel-server/blob/master/test/server.ts, https://github.com/spieljs/spiel-server/blob/master/src/server/set-router.ts

I consider that the parameters is resolved because of this I closed this issue


api key doesn't update with vimrc

Changing the key inside vimrc with let g:openai_api_key='your-api-key-here' doesn't udpate the key.
The old key is persistent even if the plugin is re-installed.
The only way to update the key is to exit vim and change the ENV variable from the terminal.

I'm curious to understand more about why you'd want to update the api_key within a session,  the API key is loaded when the plug in is loaded: https://github.com/CoderCookE/vim-chatgpt/blob/main/plugin/chatgpt.vim#L27 it first checks the system env then g:chat_gpt_key then g:openai_api_key to try to find a key.

Apologies, my bad. I forgot to delete a line in my bashrc which also set the env. All good now.


Improve video label styling

Closes #1735, #1781, #1784

The style of image and video caption is now better aligned 👍
Concerning video size, we have to go with a middle-ground, because videos are currently not responsive.
If we make them bigger they look much too big on mobile screens. Also, video size is not really UI related issue, because you can define it with AsciiDoc.


Add go unit test check in CI 😸

Signed-off-by: Puneet Punamiya<EMAIL_ADDRESS>

/test pull-tekton-catlin-build-tests


I've just spent 3 hours debugging an issue that boils down to an MP3 not being able to be found.
It'd be nice if the application logged that or dealt with it somewhat less ... hidden.

@imsickofmaps another one for monday


Add indeterminate state

Added the indeterminate state from Carbonize as mentioned in https://github.com/sindresorhus/CircularProgress/issues/9.
I need to implement it hiding/showing properly when cancelling the progress, so I marked this as a Draft. (And I wanted to try the new GitHub feature. 🤷♂) All done.

I don't think the percentage text should show when it's indeterminate.

I actually liked it more when it's there. That way you know when progress stalled.

The example doesn't give the best indication of what that would feel like as it abuses a Progress based view and manually activates the indeterminate state.
In a real world scenario it would go up to like 30%, then maybe stall and turn indeterminate. Showing that progress is still at 30%, even though it's currently stalled would be nice to know.

I think we have different use-cases in mind. I was thinking indeterminate is for when you can't know the progress at all. So if the user just does .isIndeterminate = true without setting .progress/progressInstance, we should not show the progress label. This might be how it currently works. I haven't tested yet.

I'll hide the progress label when .progress == 0 or .progressInstance == nil.

I've added the animation in updateLayer() so it works properly when added and modified through IB. The label is hidden when progress == nil or the progressInstance hasn't been set and the progress view is set to be indeterminate.

Changed my mind about adding the animation in updateLayer(). Let's replicate startAnimation(_) and stopAnimation(_) from NSProgressIndicator.
I'll update tomorrow.

Changed my mind about adding the animation in updateLayer().

I'm curious why you changed your mind?

This can be done when we've decided on how it should works, but just noting it now while I remember; The readme needs to be updated with the new methods, and also the fact that isIndeterminate keeps the value if triggered when there is progress.

I'm curious why you changed your mind?

I'm not a fan of if indeterminateCircle.animation(forKey: "rotate") == nil { being called every time updateLayer() is triggered. I tried enabling the animation elsewhere, but everything needs to be added to the view before it'll work. Manually starting and stopping the animation on NSProgressIndicator always felt odd to me, but it wouldn't surprise me if this is why.
So I figured why not adopt the same API for CircularProgress.

This can be done when we've decided on how it should works, but just noting it now while I remember; The readme needs to be updated with the new properties, and also the fact that isIndeterminate keeps the value if triggered when there is progress.

That is on my list, but on halt until the implementation if finalized, like you mentioned.

I'm not a fan of if indeterminateCircle.animation(forKey: "rotate") == nil { being called every time updateLayer() is triggered.

Why is that a problem?

I'll hide the progress label when .progress == 0 or .progressInstance == nil.

You currently hide the progress label when it's higher than 0 too, for example 0.3.

Why is that a problem?  So I would prefer not having the start/stopAnimation methods.

Maybe that's a personal preference, but I'd rather minimize possible performance problems by exposing them like this.
I'll revert back to automatically adding the animation though.

but I'd rather minimize possible performance problems by exposing them like this.

I added a print() to updateLayer and let the example app run for a minute and updateLayer was called about 30 times.

Can you run the GIF through ImageOptim.app?

Except for some minor nitpick, this looks great.

This looks great 👌

Thanks!

Rebasing this. Just a sec.

@sindresorhus All done. 👍

Looks great!


hugegraph: init at 1.0.0

Description of changes
This PR introduces a new package, Apache HugeGraph. HugeGraph has no binary releases and has to be built from source.
I've also provided a from-source derivation for JanusGraph, another Java NoSQL package that I maintain. This required the introduction of grpc-java. The rationale is that JanusGraph is built very similarly to HugeGraph unstable, so the two can be reviewed side by side.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@SuperSandro2000 would you mind having a look?

JanusGraph has a very slow release cycle. The last release has outdated TinkerPop libraries.

Then why not update the older version?

@SuperSandro2000 can this be merged?

I've updated protoc-gen-grpc-web in a separate PR

@SuperSandro2000 can we merge this?

@SuperSandro2000 bump, I'd really like this to get merged.

@SuperSandro2000 all conversations resolved, I also rebased against current master.

@SuperSandro2000 can you have another look?

The hash is unstable. Can you check why this is happening? Using --rebuild and diffoscope should be a big help.

@jlesquembre you might be interested in this.


Set temporalityPreference for exporter when using Cloud Logging

Hey,
As it's currently implemented I cant seem to find a way to adjust the temporalityPreference when exporting to Cloud Logging.
For dynatrace this seems to be defaulted to DELTA while it defaults to CUMMULATIVE for Cloud Logging
https://github.com/cap-js/telemetry/blob/fcac18d3eec78a442f1e062d3bce41f9c1f0efd4/lib/metrics/index.js#L29-L37
Would it be possible to have this be set via env like cds.env.requires.telemetry.metrics.config.temporalityPreference?
Marc

hi @marcsst
sorry for the late reply.
it can be configured via cds.env.requires.telemetry.metrics.exporter.config.temporalityPreference, as metricsConfig is derived from cds.env.requires.telemetry.metrics.exporter.config:
https://github.com/cap-js/telemetry/blob/fcac18d3eec78a442f1e062d3bce41f9c1f0efd4/lib/metrics/index.js#L17
you were only missing the exporter level.
best,
sebastian

Hey @sjvans,
that's the workaround we've been using for now, didn't think that was the intended way 😄.
Maybe this can be added to the readme?
Marc


add headers to Remote Parser for bigquery

Signed-off-by: Sammy El Khammal<EMAIL_ADDRESS>

approved after peer review


Configurable branch deletion

I would love for an option (either in the web UI or in the config file (or both :-)) for a configuring a delay for when to delete branches.
Something like:

1 minute
1 hour
Custom delay?
When dependabot scans next time for new dependencies

My use case is that when I merge a PR (that has successfully been built), a new build of master and the dependabot-managed update branch is triggered. I can't seem to configure my way around this, but then it marks the PR as failed because the dependabot-managed branch is deleted, and thus the build fails.

Ack, that sounds really frustrating.
It's the first time I've heard this request, and my policy with Dependabot is generally to wait until I know there are a number of users who want an option before adding it. If this is affecting others then I'm 👍 on making it configurable.

Closing this due to age and low demand. If this scenario is critical to your workflow please feel free to comment.

I'm experiencing the same issue of the branch being deleted before the workflow (triggered by the pr being closed) has time to start up


build(version): bump to v1.5.0

Codecov Report

Merging #378 (3669cca) into master (74cafef) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   55.45%   55.14%   -0.31%
==========================================
  Files          39       39
  Lines         972      972
  Branches       92       92
==========================================
- Hits          539      536       -3
- Misses        399      401       +2
- Partials       34       35       +1

Impacted Files
Coverage Δ

src/app/shared/add-device/add-device.component.ts
86.36% <0.00%> (-6.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74cafef...3669cca. Read the comment docs.


Fix .upignore patterns and add test coverage

Re: https://github.com/apex/up-examples/issues/47#issuecomment-328409493
Basically this should work:
*
!cmd

Same with:
*
!cmd/api/**
!cmd/api

ok so this works as gitignore does, turns out * is a bit greedy and ignores ., the directory itself, so you need to use .* to ignore everything if you want to negate dirs after. I'll update docs

seems to match gitignore fine I think, though seems like this works in git:
/*
!cmd

might need to look into this more later, updating the docs for now


Confused by this snippet code

In ChartViewBase.swift file, these is a snippet code like this:
/// returns the x-value at the given index
public func getXValue(index: Int) -> String!
{
if (_data == nil || _data.xValCount <= index)
{
return nil;
}
else
{
return _data.xVals[index];
}
}
I am not good at swift but I'm confused about the function's return type: String!, obviously, it may return nil.
I hope what I'm saying is clear enough...thx

That question is suitable for a Swift forum, or Stackoverflow, or just reading the Swift manual by Apple!
But to make long story short, a String! is an optional String (nullable) that will unwrap automatically, avoiding the need to user the ? operator for reading its value.


Add an online Spritesheet Maker animation tool.

Simply adds the Leshy SpriteSheet Tool, honorable mention to be included here.

I'm a bit mixed if this should be added in or not, I never knew the existence of the other SpriteSheet tool before making this PR. 🤔

ok he valid wit it yessirrr


style(contributing): add Contributing guide

@homu r+

:pushpin: Commit e269280 has been approved by MichaelHirn

:hourglass: Testing commit e269280 with merge 2ed3cc6...

:sunny: Test successful - status


Better install with setup.py

Motivation and Context
Issue #13 brought up that the current method of figuring out how to import the bindings leads to confusing error messages when things are installed with setup.py.   The relevant error, that it couldn't import habitat_sim._ext.habitat_sim_bindings`, is buried by the error message that it couldn't import the bindings in developer mode.
This PR uses setup.py to modify the value of a variable such that the code knows where it should expect the bindings to be, and only looks in that location.
How Has This Been Tested
Installed in a clean conda environment.  After deleting the build folder and doing unset PYTHONPATH, python examples/example.py works.   Doing
cd ..
python
>>> import habitat_sim

also works.  That cd .. is still key however.
In a different clean conda environment, I built with build.sh.  Doing
python
>>> import habitat_sim

succeeds and python examples/example.py fails (this is what I would expect to happen).  python examples/example.py works if I add /path/to/habitat-sim to my PYTHONPATH.

I think this now causes an issue if you install via setup.py but also have habitat-sim in your pythonpath. When I had that combo I got this error:
Python 3.6.8 |Anaconda, Inc.| (default, Dec 30 2018, 01:22:34)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import habitat_sim
Traceback (most recent call last):
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/bindings/dev_bindings.py", line 72, in <module>
    import habitat_sim_bindings
ModuleNotFoundError: No module named 'habitat_sim_bindings'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/__init__.py", line 12, in <module>
    from .agent import *
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/agent/__init__.py", line 7, in <module>
    from .agent import *
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/agent/agent.py", line 9, in <module>
    from .controls import ObjectControls, ActuationSpec
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/agent/controls.py", line 10, in <module>
    import habitat_sim.bindings as hsim
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/bindings/__init__.py", line 11, in <module>
    from .dev_bindings import *
  File "/raid/xkcd/external_code/habitat-sim/habitat_sim/bindings/dev_bindings.py", line 83, in <module>
    raise ImportError(msg)
ImportError:
Failed to to import habitat sim bindings in developer mode
----------------------------------------------------------

Could not find the expected bindings build folder: "/raid/xkcd/external_code/habitat-sim/build/esp/bindings"
Make sure to not delete the build folder after building

>>> quit()

I was able to fix it by removing habitat-sim from the pythonpath, but now I just feel like I'm going in circles.

Yeah. If you install via setup.py, it’ll be weird if you also add habitat sim to your pythonpath. At some point we should switch to just having one build method.


Upgrade npm to 6.1.0 (base/8 and base/10)

Upgrade to latest npm.
I'm able to use npm 5.6.0 or 6.1.0, but not any versions in between due to https://github.com/npm/npm/issues/19989. Seems good to upgrade to the latest anyway!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

nice, I love npm 6.1.0 - let me publish new Docker images

ok, I rebuilt cypress/base:8 and cypress/base:10 images

Thanks


Mark executables as executable

Fixes #53.

Hmm, GitHub still doesn't seem to be saving it as executable. Probably can do that when we zip ourselves for the release job, maybe.

Looks like uploaded artifacts don't preserve the executable bit. See https://github.com/marketplace/actions/upload-a-build-artifact#Limitations.
We can set this for the actual release assets, though, since we zip those ourselves.


Add Rails 5 Support

👋
Closes https://github.com/jfirebaugh/konacha/issues/230
I've added Rails 5 and Ruby 2.3.1 to the Travis testing Matrix and added support for Rails 5.
Thanks!

So it looks like something changed in the Travis CI config that stopped selenium from working.
Here is a separate build I ran here: https://travis-ci.org/tarebyte/konacha/builds/175511362 that just added Ruby 2.3.1 to the matrix.
I think there is a bigger issue here, and I'll try to come back to it when I have time.
Sorry for the noise!

Thanks @tarebyte! Sorry about the build failures. It looks like they were due to picking up a new major version release of selenium-webdriver that isn't compatible with something. I don't have time to sort through what the incompatibility is so I just pinned to ~> 2. Want to rebase on master and see if it builds now?

This looks perfect to me. @jfirebaugh, can we get this merged in and cut a new release?

Sure, but we'll need it to be passing CI first.

So if re-run master on travis right now it is totally green?

Anything I can help with @tarebyte?

Anything I can help with @tarebyte?

@maletor I kept playing with it, not sure what's up. If you want to take over this PR feel free this isn't very high up on my priority list.

@tarebyte any update on this ?

@dpoint01 this fell off my radar, I'll try and take a look at it soon.

Closing this to being stale, apologies for dropping the ball on this.


[Unexpected warning]: Machine given to useMachine has changed between renders

Description
I am using Next.js dynamic routing. pages/test/[value].tsx.
[value] is predefined as 1 to 100, so I have pages /test/1, /test/2 ...  /test/100.

Each of the page has a link going to the same route using different [value].
Because nextjs doesn't fully reload the same route page, it doesn't run React.useEffect(() => {}, []) to initialize values.
I am using useInterpret in the Child component
To avoid using the same instance, I am rendering "loading" text on a new value route render.
Then after 1sec, I am rendering the same Child component with a new value that will eventually be a value in the machine context.

So by the number 4, useInterpret should be starting fresh.  However, I see this warning in the console.

Machine given to useMachine has changed between renders. ...

Expected Result
As I think about it, the Child component is dropped on the route change (new value), useInterpret is starting fresh, so there shouldn't be any warnings in the console.
Actual Result
I get this in the console.

Machine given to useMachine has changed between renders. This is not supported and might lead to unexpected results.
Please make sure that you pass the same Machine as argument each time.

Reproduction
https://codesandbox.io/s/unexpected-warning-machine-given-to-usemachine-has-changed-between-renders-20tee

open https://20tee.sse.codesandbox.io/test/1
open console
follow the link
and you will see the warning

If I just toggle ON / OFF the same component, the warning doesn't happen.
https://codesandbox.io/s/unexpected-warning-machine-given-to-usemachine-has-changed-between-renders-20tee?file=/src/pages/toggle.tsx

open https://20tee.sse.codesandbox.io/toggle
click on the button

Additional context

I am exactly not sure, but https://github.com/statelyai/xstate/issues/2210 https://github.com/statelyai/xstate/discussions/2023 https://github.com/statelyai/xstate/issues/995 these are also related?
I found this warning as I was fixing other issue similar to https://github.com/statelyai/xstate/issues/995 https://github.com/statelyai/xstate/discussions/2023
The issue of mine was my nextjs have a page with links going to the same page (pages/products/[id].tsx) with different parameter ([id]).
The initial page load is fine, but if I click a link going the same page with different parameter, the product info doesn't get refreshed although I can definitely  confirm that new data is passed from GetStaticProps.
And I am now thinking this warning is somehow related to this issue?

I do not get errors like this anymore after update to 4.27.0:
https://github.com/statelyai/xstate/releases/tag/xstate%404.27.0
Please confirm that this is now working please.

Similar issue being addressed in #3947

This was largely addressed by https://github.com/statelyai/xstate/pull/4436 . However, I still don't recommend "swapping" machines in production code. If you want to reset your component's state with some new initial data then I'd likely recommend changing the React's key on the component that owns the machine.


Recipe created by user can be shown as already read (light blue color) instead of dark blue color

fixed: the user who has created the recipe will have viewed the recipe already.

This issue was moved to k-sheth/calendar-khana-lagao#42


Installer hash does not match; this cannot be overridden when running as admin

Brief description of your issue
CCleaner  cannot be upgraded.
Installer hash does not match; this cannot be overridden when running as admin
Steps to reproduce
install CCleaner，can't update
Expected behavior
can update
Actual behavior

Environment
Windows Package Manager (Preview) v1.7.2491-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.3448
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.2491.0

Winget Directories
--------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\D…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\s…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Either don't run the terminal as admin, override the hash (not recommended), and let UAC handle elevation for the installer, or wait for the hash to be fixed before you upgrade.

Hi @fate1less,
This is the expected behavior when running WinGet from an elevated session, and a hash mismatch is encountered. Hash mismatches are common when a manifest uses a vanity URL and the package becomes updated, such as a new version. The fix here is usually to submit this new version to WinGet's public manifests, and possibly remove the old.

Duplicate of #1812

#1812

Feel free to submit an issue over at https://github.com/microsoft/winget-pkgs to request an update to the CCleaner package.

One possible workaround is what is described here. In an elevated terminal run:
 winget settings --enable InstallerHashOverride

now in a normal (i.e., non-elevated) terminal run:
winget install <packageName> --ignore-security-hash

please consider that this workaround is insecure and unsafe!


How to debug a "failed to parse all tokens" ParseError?

I'm working on updating ruma-api-macros from syn 0.11 to 0.13 and I finally got the version using 0.13 compiling. However, when I run the integration test, I get this error:
error: proc macro panicked
  --> tests/ruma_api_macros.rs:16:5
   |
16 | /     ruma_api! {
17 | |         metadata {
18 | |             description: "Does something.",
19 | |             method: Method::Get, // A `hyper::Method` value. No need to import the name.
...  |
51 | |         }
52 | |     }
   | |_____^
   |
   = help: message: ruma_api! failed to parse input: ParseError(Some("failed to parse all tokens"))

I see the error is generated here but I'm not sure what to do to figure out why.
The macro invocation looks like this:
ruma_api! {
    metadata {
        description: "Does something.",
        method: Method::Get, // A `hyper::Method` value. No need to import the name.
        name: "some_endpoint",
        path: "/_matrix/some/endpoint/:baz",
        rate_limited: false,
        requires_authentication: false,
    }

    request {
        // With no attribute on the field, it will be put into the body of the request.
        pub foo: String,

        // This value will be put into the "Content-Type" HTTP header.
        #[ruma_api(header)]
        pub content_type: ContentType,

        // This value will be put into the query string of the request's URL.
        #[ruma_api(query)]
        pub bar: String,

        // This value will be inserted into the request's URL in place of the
        // ":baz" path component.
        #[ruma_api(path)]
        pub baz: String,
    }

    response {
        // This value will be extracted from the "Content-Type" HTTP header.
        #[ruma_api(header)]
        pub content_type: ContentType,

        // With no attribute on the field, it will be extracted from the body of the response.
        pub value: String,
    }
}

and I'm attempting to parse it like this:
pub struct Exprs {
    pub inner: Vec<Expr>,
}

impl Synom for Exprs {
    named!(parse -> Self, do_parse!(
        exprs: many0!(syn!(Expr)) >>
        (Exprs {
            inner: exprs,
        })
    ));
}

#[proc_macro]
pub fn ruma_api(input: TokenStream) -> TokenStream {
    let exprs: Exprs = syn::parse(input).expect("ruma_api! failed to parse input");
    # ...
}

Apparently the structure of the macro syntax cannot be represented as a series of Exprs? I tried using ExprStructs instead, but no dice. Is there another type I should be using to represent this syntax? I might be able to figure it out myself if I had a better idea where the parser was getting stuck.

request {
    pub foo: String,
}

This is not syntactically an expression in Rust.

From your sample input it looks like the relevant types are going to be syn::FieldValue and syn::Field. Something like:
use syn::{Field, FieldValue};
use syn::punctuated::Punctuated;
use syn::synom::Synom;

struct Exprs {
    metadata: Vec<FieldValue>,
    request: Vec<Field>,
    response: Vec<Field>,
}

type ParseMetadata = Punctuated<FieldValue, Token![,]>;
type ParseFields = Punctuated<Field, Token![,]>;
impl Synom for Exprs {
    named!(parse -> Self, do_parse!(
        custom_keyword!(metadata) >>
        metadata: braces!(ParseMetadata::parse_terminated) >>
        custom_keyword!(request) >>
        request: braces!(call!(ParseFields::parse_terminated_with, Field::parse_named)) >>
        custom_keyword!(response) >>
        response: braces!(call!(ParseFields::parse_terminated_with, Field::parse_named)) >>
        (Exprs {
            // Convert from Punctuated to Vec.
            metadata: metadata.1.into_iter().collect(),
            request: request.1.into_iter().collect(),
            response: response.1.into_iter().collect(),
        })
    ));
}

Thanks much, @dtolnay! That was enough info for me to progress. Do you think there's anything actionable here in terms of documentation additions? If not, feel free to close the issue.

I just ran into this while trying to figure out https://github.com/dtolnay/syn/issues/436. The trick to debugging this is calling Synom::curse on the type that is not being parsed correctly rather than syn::parse and analysing the result. The result is very informative as it tells you what was parsed and gives you a cursor to the remaining TokenStream. By turning what was parsed to a TokenStream and pretty printing it, you can see what it was parsed into. You can then turn the cursor to a TokenStream by calling token_stream() on it to see what the rest of the tokens were. Enough talk, here is the code:-
let buffer = TokenBuffer::new(input);
match Exprs::parse(buffer.begin()) {
    Ok((exprs, rest)) => {
        println!("Parsed Exprs:- \n{:#?}", exprs.inner);
        println!("Remaining tokens:- \n{:#?}", rest.token_stream());
    }
    Err(error) => println!("Error: {:?}", error),
}

This is being addressed by #47 and will be shipping in 0.15.


More efficient map.putOrAdd and map.putIfAbsent [HPPC-166]

HPPC 0.6.0 has very efficient implementation of map.putOrAdd method: it makes alone lookup.
But HPPC 0.7.2 version makes 2-3 lookups:
 - containsKey

get (optional)
put

Issue: HPPC-166 (migrated from JIRA), created by Konstantin Pavelko, resolved Oct 20 2017

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
Thanks. I'll release the new version during the weekend (or Monday).

Comment by Konstantin Pavelko (migrated from JIRA)
Efficient implementation based on public methods:
	public static double putOrAdd(IntDoubleMap map, int key, double putValue, double incrementValue) {
		int index = map.indexOf(key);
		if (index < 0) {
			map.indexInsert(index, key, putValue);
		} else {
			putValue = map.indexGet(index) + incrementValue;
			map.indexReplace(index, putValue);
		}
		return putValue;
	}

map.putIfAbsent can be improved too

Comment by Konstantin Pavelko (migrated from JIRA)
Dawid, I'm not familiar with HPPC templates. It will be fine if you do it.

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
Correct, this should be improved.

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
Yup, that's exactly what I was thinking of, actually. If you can provide a pull request via github, Konstantin, that'd be great. Remember to edit CHANGES.txt and add the issue/ yourself there in the pull request. If you don't have time I'll do it, time permitting (next week, most likely).


set isolatedModules true

Bundlers that use esbuild can't build your packages, because you don't have this set in your tsconfig and therefore have not been given early warning that you should be importing types with a separate import statement:
// 🛑 bad
import { print, validate, NoDeprecatedCustomRule, } from 'graphql';

// ✅ good
import { print, validate } from 'graphql';
import type { NoDeprecatedCustomRule } from 'graphql';

https://esbuild.github.io/content-types/#typescript
https://vitejs.dev/guide/features.html#isolatedmodules
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export

meh i had the wrong version of graphql... 😅


created PDF is not returned into client browser

Hello,
in my previous version I have sent my form to PHP via standard submit and everything was ok.
Now I am sending form values via AJAX, but problem is, that the PDF is not returned to window of client browser.
To make me sure, that the PDF is created correctly I tried to saveAs on a server and in this case I see, that PDF is created correctly. But I would like to send the PDF to the client browser.
Could be the problem, that connection runs on SSL? but debugger is clean(any X-Windows, CrossDomain , etc, problem)
in debuger in Response I see:
%PDF-1.4
1 0 obj
<<
/Title (þÿ)
/Creator (þÿwkhtmltopdf <IP_ADDRESS>)
/Producer (þÿQt 4.8.6)
/CreationDate (D:20161007120104+02'00')
>>
endobj
3 0 obj
<<
/Type /ExtGState
/SA true
/SM 0.02
/ca 1.0
/CA 1.0
/AIS false
/SMask /None>>
endobj
4 0 obj
[/Pattern /DeviceRGB]
endobj
6 0 obj
<<
/Type /XObject
/Subtype /Image
/Width 4536
/Height 1073
/BitsPerComponent 8
/ColorSpace /DeviceGray
/Length 7 0 R
/Filter /FlateDecode
>>
stream
...
..
.

Thank You for any hint
Regards Zdenek

Sorry, but I can not give support for app specific questions, like "how to make PDF download work with AJAX requests" (which I think is your issue here - and I don't think this will work at all).
This here is really only for issues when you think something is broken with the library.

as you see, the problem is not with AJAX when via saveAs is PDF created correctly

You can not trigger a download dialog with AJAX request.

You are right


Ability to install toys separately

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
Currently PT can only be installed as a bundle, there is no choice which to install (I'm not talking about "which to use" - that is a completely different subject). A user have to install ALL of them even if they just need only 1. This seems highly inflexible and bloated, if you wish. If a user is only interested to use a single tool and wants to install only that tool (regardless of the argument how little space they take - that is not really a valid argument) - he should be able to.
This is not the first time people ask for this feature

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Closing as duplicate of https://github.com/microsoft/PowerToys/issues/6904

So why is making this request not allowed? Why is it just closed? Where did the whole "community vote" thing go? Or is it just "community only can vote for what we allow to vote"? Then what the point of having "voice of community" in a first place. if it is never taken into account properly? To pretend?

 My work banned the entire product because of the "Awake" feature bypasses our security.
Great job Microsoft. Way to screw up yet another great product!


Transform blog as a Plugin

Would you mind transforming your blog classes into an injectable class which follows an Interface to build a transformable features, not all static pages uses just a blog.

I can recommend Sereno for this, it have this separated, and is basically like a fork of Katana i believe.


[REQUEST] Study possibility to run GitHub actions locally

Is your feature request related to a problem? Please describe.
This a split of #416
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Study possibility to run locally github actions
https://github.com/nektos/act

It's actually super simple to use act. We have a bug though so I'll see after refactoring the GitHub workflows in the Docker image PR. #384

This seems like a good solution to some of my other requests.
I was able to download and install act very easily but got this error when running it (not sure it is same one you all got)
(base) elizabeth@Elizabeths-MacBook-Pro-2 gtfs-validator % act
[Java CI/build   ] 🚀  Start image=node:12.6-buster-slim
[End to end/build] 🚀  Start image=node:12.6-buster-slim
[Java CI/build   ]   🐳  docker run image=node:12.6-buster-slim entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[End to end/build]   🐳  docker run image=node:12.6-buster-slim entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[Java CI/build   ]   🐳  docker cp src=/Users/elizabeth/Documents/urbanlabs/CA Interoperable/gtfs-validator/. dst=/github/workspace
[End to end/build]   🐳  docker cp src=/Users/elizabeth/Documents/urbanlabs/CA Interoperable/gtfs-validator/. dst=/github/workspace
Error: error during connect: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.40/exec/0065c54f6c29faca7249ab278e81e5e395f6b86dee472800ab0746297de34754/start": net/http: HTTP/1.x transport connection broken: unsupported transfer encoding: "identity"

So, syncing the latest version of master and passing the command act -j end-to-end
Now works fine with the validator running on all datasets until the persist artifact steps...

... which is a known issue of act
https://github.com/nektos/act/issues/329
The files in question can be manually collected inside the container.
Datasets .zip files are present as well as validation reports .json

I think that's as far as we can go presently. Do you think @e-lo that would be enough to close this issue?

@e-lo the documentation has been updated. Let us know as we will merge it for release v1.3.0 that should happen today no earlier than 14:00 EST


Bot API 6.3 Changes

@EdJoPaTo @pxp9 please take a look when you have time
should be checked against https://core.telegram.org/bots/api#november-5-2022


Sections ordering

How i can set the order of the menu items i add in [params.sections_left] or [params.sections_right].
It seems to the alphabetical, and i cannot find a way to change it.

I'll look into this. Reference: https://github.com/MunifTanjim/minimo/commit/c02af96763d9b189882932c6721acd15c4f843b8


Error match for cargo

I'm not sure where this should be placed in the code exactly, but the following regex seems to do the job for Cargo:
^(?<file>[^\\.]+.rs):(?<line>\\d+):(?<col>\\d+):

Cool thanks! I'm gonna have to figure out somewhere to put stuff like this. In the readme, or directly in the  build tool so it just magically works.
Is output from Cargo always in that format?

I think so. I'll update the code if I ever encounter a different format. In
my opinion the error regexs should be part of the package, and users should
write their own regexs only if they use a build tool which isn't yet
supported by this package
On Thu, Mar 5, 2015, 22:43 Alexander Olsson<EMAIL_ADDRESS>wrote:

Cool thanks! I'm gonna have to figure out somewhere to put stuff like
this. In the readme, or directly in the build tool so it just magically
works.
Is output from Cargo always in that format?
—
Reply to this email directly or view it on GitHub
https://github.com/noseglid/atom-build/issues/47#issuecomment-77447619.

I think that is a sound approach. I will add it to the build in error match! Thanks!


qualys xml report

Good day, qualys xml report is working fine during manual upload.
but it looks like they do not have xml report extraction from their api.
can you please add csv or json parser?
Idea is:
Qualys has api which allows to download only csv, or json however manually you can download xml, which is parsable by Defectdojo.
Please let me know how to process this issue in order to automate.

Best solution is to create the loader part for the JSON formats.
You can take example on this PR which add a parser and the importer => https://github.com/DefectDojo/django-DefectDojo/pull/4962
If implementing the importer is too much, at least create the JSON loader part in the same parser.

@vulnz, if you add a JSON or CSV output file here, I can help you and make a PR for you.

Do you have an update here @vulnz ?

@vulnz do you have an output for qualys?

I guess this is deprecated as there was no response for over a month @mtesauro
In case you still need support for this @vulnz feel free to open another issue, but then please add an output file.


[BUG] Update response endpoint returning 422 when status sent is draft

Describe the bug
@damianpumar detected a bug in which the PUT /api/v1/responses/{response_id} endpoint returns a 422 HTTP status code when trying to update a response and the sent status is draft.
This bug is being caused because we don't have a DraftResponseStatusCode class:
https://github.com/argilla-io/argilla/blob/aeb5b8e9d1dbb52429bc3d1bec508c44659e7e9b/src/argilla/server/schemas/v1/responses.py#L50-L60
Expected behavior
The endpoint return a 200 HTTP status code when called and the sent status is draft.

@gabrielmbmb Can I work on this?


Package pipelinit-cli for Mac using brew

To improve the project's distribution for Mac users, we must package it using https://brew.sh/
It will easier the installation until we don't have signed binaries as described on #6

Initial implementation: https://github.com/pipelinit/homebrew-pipelinit-cli
Usage:
brew tap pipelinit/pipelinit-cli
brew install pipelinit-cli


Data not showing when form is filed from any other location

Another issue i'm facing is that whenever I fill the form from my home network, the data gets saved in the sheet. But whenever my friend fills the same form from his home, the form doesn't get saved in the sheet. I have asked my friend to fill that form from his house(1km from my house) and my brother from his house(different country). Data didn't get saved :(
Any help is highly appreciated

@SakshhamTheCoder Delete and try again..
watch step by step


nice composition diagram from sklearn

Since the more recent versions of sklearn, composite estimators inheriting from BaseEstimator display like this:

This is currently not supported by BaseObject - but it would be nice if it were?
Nb, sktime BaseObject does support it, as it inherits the display method from sklearn.

Yep -- it does. It is one of the tricker parts of the dependency to remove.

We have #17 open related to the preservation of pretty printing (this is and printing classes nicely is part of that) when sklearn dependency is removed. Closing this as we'll make sure to retain this functionality as part of that issue.


Why does deepspeed is commented in the finetune file?

Why dose if args.deepspeed: ... is commented in finetune_sdm_yaml.py? Is there any bug with that?

Hi, no worries, there is no bug with that. It is just an old version code.

Hi, no worries, there is no bug with that. It is just an old version code.


Making macro and any other syntax compatible with the code updating on passage name change

This issue relates to an interaction with Twine 2.  I'm using v 2.3.16 (desktop)
Twine 2 auto updates links and some other code across the whole project when the author changes a passage name.
I've run some tests and found that any links or other code using the [[...}} syntax will be updated, but any code with the passage name in double quotes is not updated.  I've tested this with three macros:
<<include>>, <<goto>>  or <<button>>.
I'm guessing that twine 2 was designed to update passage names in square brackets and not in double quotes because it would not be easy (possible?) to change code  with the passage name in double quotes but not change non-code text that coincidentally had the passage name words in quotes?
Would it be possible to revise the sugarcube code syntax so that all of it could be auto-updated by twine when authors change passage names?
I've systematically searched the sugarcube documentation and (unless I've somehow missed cases)) all the code that mentions passage names offers two formats  - [[...]] and "...".  So would it be possible to deprecate the "..." options?  This would then mean that twine 2 passage change auto-updating would be 100% effective???
(I did a search in the issues list to see if there was anything there already related to this issue.  I didn't find anything.)

Deprecate the "..." options for known macros that take a Passage Name as an argument wouldn't get around situations like the following...
<<set _passage to either("Library", "Study", "Kitchen">>

<<include _passage>>
<<goto _passage>>
<<run Engine.play(_passage)>>
<<run Dialog.wiki(Story.get(_passage).processText())

...as how is the Story Format mean to know that the String values being passed to the either() function are actually Passage Names.
Potentially the is the possibility of adding a new 'data-type' to the engine that represents a Passage Name Reference, and enforcing the usage of it on the Authors, but that would still require a means for letting the Twine 2.x application know how to handle it.
I would also hesitate in using the Mark-up based link syntax for that representation because currently there is no way to tell the Twine 2.x application not to create a "connection arrow" in the Story Map for a Passage Name reference that doesn't lead to a Passage Transition. Thus the linking of the map would become more complex than it already is, and as it's the drawing of those "connection arrows" that are one of the main things that influence the slow-down of the map more is not necessarily better.

I've tested this with three macros: <>, <> or <>.

In future, please use the markdown code markup for inline examples or code fences for block examples so they aren't eaten by the system.

So would it be possible to deprecate the "..." options? This would then mean that twine 2 passage changeautoupdateing would be 100% effective???

All built-in macros that want, or can take, a passage argument will accept the link markup.  No one is being forced to use the separate text/passage argument format, so I'm not seeing the problem or a compelling argument here.
Beyond that there are cases where using the link markup is suboptimal—e.g., when using variables—so having an alternative is nice.
Additionally.  Some people don't like the connection arrows, for various reasons, so….

Thanks.
Is there then any way for twine/compilers or story formats to somehow warn authors on passage name change that they cannot reply on the auto name change process to pick up all references to the old passage name?


fix voluerable lib dependencies

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>Change to minimal version of autorest/adal so that it can pass the scan without changing other codes

/assign @zhiweiyin318

an e2e issue occurred but it doesn't seem caused by this PR

/retest

/retest

/lgtm
/approve


JSON lint tooltip wrong placed.

The tooltip for JSON lint is placed behind 'Add Job' modal.

@saade, i hope that z-index on the code mirror container will fix that. I'll try to figure it out