Project's current formatting makes it hard to contribute non-trivial changes

The project's current code formatting suffers from a couple of issues, affect:
tl;dr: For the sake of making contributions hassle-free it would arguably be preferable to revert to Rust's default format (as applied by rustfmt without a custom rustfmt.toml file) and used by >90% of Rust projects.

It uses a non-standard format
The Rust project recommends using the default formatting configuration to ease collaboration.

It provides a custom rustfmt.toml file but doesn't actually use it
While the project provides a rustfmt.toml file
./rustfmt.toml
# https://github.com/rust-lang/rustfmt/blob/master/Configurations.md
tab_spaces = 3
fn_call_width = 120
chain_width = 120
max_width = 120
fn_single_line = true

Running cargo fmt results in 30+ reformatted files, which should not happen if the code had previously been formatted with it.
As such it is currently impossible to have rustfmt/cargo fmt apply the same formatting as used by the project. And anybody opening a PR on the project gets a nasty surprise when they notice that their IDE auto-formatted the code (as is usually desirable) and now the semantic changes are lost in thousands of formatting changes (as it just happened to me, again).

The rustfmt.toml file requires nightly and is also invalid
Further more running cargo fmt results in a bunch of warnings:
$ cargo fmt

Warning: can't set `fn_single_line = true`, unstable features are only available in nightly channel.
Warning: can't set `fn_single_line = true`, unstable features are only available in nightly channel.
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`
`chain_width` cannot have a value that exceeds `max_width`. `chain_width` will be set to the same value as `max_width`
Warning: can't set `fn_single_line = true`, unstable features are only available in nightly channel.
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`
`chain_width` cannot have a value that exceeds `max_width`. `chain_width` will be set to the same value as `max_width`
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`
`chain_width` cannot have a value that exceeds `max_width`. `chain_width` will be set to the same value as `max_width`
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`
`chain_width` cannot have a value that exceeds `max_width`. `chain_width` will be set to the same value as `max_width`
`fn_call_width` cannot have a value that exceeds `max_width`. `fn_call_width` will be set to the same value as `max_width`
`chain_width` cannot have a value that exceeds `max_width`. `chain_width` will be set to the same value as `max_width`

The project mixes CRLF and LF

37 files use CRLF
31 use LF.

You are correct! I need to merge the byods branch before fixing formatting issues. I don't think I'll switch to the default rustfmt config though.

I don't think I'll switch to the default rustfmt config though.

As long as there's a corresponding rustfmt.toml provided by the repo :+1:.

You can use a nightly rustfmt config values in a rust-stable codebase by sticking rustfmt.toml in a non-root dir:
rustup run nightly cargo fmt -- --config-path fmt/rustfmt.toml

@mkatychev Thanks for the suggestion. I'll get it once I get a chance to merge the BYODS work.

@s-arash it looks like the BYODS work got merged in the meanwhile. Any update on this?

This is a bit ancillary but you can also define your own formatting rules using topiary as well, there's rust support under the hood but this specifically allows one to apply custom rulesets specifically for ascent grammar through s-expressions:
https://topiary.tweag.io/playground/
I've been working on a formatter for OpenSCAD using topiary with great success and have been meaning to finish https://github.com/mkatychev/tree-sitter-ascent sometime this month:
https://github.com/Leathong/openscad-LSP/pull/33#issuecomment-2327561910

Thanks for the reminder @regexident! I'll get to it soon.

Very cool @mkatychev, good luck!

Thanks for taking care of this @s-arash! 🙏
I can't reproduce the formatting on my side though, which was the main goal of is issue, so I'd be hesitant to call it resolved just yet. 😕

When I run cargo fmt I'm getting 57 changed files and a bunch of warnings:
Warning: Unknown configuration option `style_edition`
Warning: can't set `format_macro_bodies = false`, unstable features are only available in nightly channel.
Warning: can't set `fn_single_line = true`, unstable features are only available in nightly channel.
Warning: can't set `where_single_line = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `overflow_delimited_expr = true`, unstable features are only available in nightly channel.
Warning: can't set `match_arm_blocks = false`, unstable features are only available in nightly channel.
Warning: can't set `trailing_semicolon = false`, unstable features are only available in nightly channel.
Warning: can't set `unstable_features = true`, unstable features are only available in nightly channel.

If I run cargo +nightly fmt however it outright fails to format, bailing after this:
cargo +nightly fmt
error[internal]: left behind trailing whitespace
  --> <SNIP>/ascent/ascent_base/src/lattice/tuple.rs:19:19:1
...

error[internal]: left behind trailing whitespace
  --> <SNIP>/ascent/ascent_base/src/lattice/tuple.rs:34:34:1
...

error[internal]: left behind trailing whitespace
  --> <SNIP>/ascent/ascent_base/src/lattice/tuple.rs:39:39:1
...

error[internal]: left behind trailing whitespace
  --> <SNIP>/ascent/ascent_base/src/lattice/tuple.rs:44:44:1
...

warning: rustfmt has failed to format. See previous 4 errors.

This is the Rust setup I'm running the above in:
$ cargo fmt --version

rustfmt 1.7.1-stable (f6e511ee 2024-10-15)

Thanks @regexident. I've fixed those. Can you check again?

cargo fmt stills produces 55 changed files, but cargo +nightly fmt works now (apart from producing a change in scratchpad.rs). 👍

Given that cargo fmt is the default way to format Rust projects (and thus probably the way most if not all your potential contributors have their IDEs configured) it might be worth documenting this unusual requirement somewhere visible though, to keep you from having to ask on PRs to "please re-format using cargo +nightly fmt". And to avoid contributors the hassle of having to re-format their PRs retro-actively.
Better yet: make rust-analyzer do the right thing by adding the following to ./vscode/settings.json, thus avoiding formatting mismatches before they even happen:
"rust-analyzer.rustfmt.extraArgs": [
    "+nightly"
]

(not sure what's the equivalent for RustRover)

FYI, I've just updated my open PRs with the new formatting. Would appreciate if you could take a look some time.


It will add non-breaking space to image url in markdown

Describe the bug
I'm trying to process my markdown document but url to images or documents are also processed. They should be skipped.
To Reproduce
Steps to reproduce the behavior:

Go to 'App typopo'
Switch to Czech
Copy:

![](url-to-image-5.jpg)

[fewfwe](url-to-image-5.jpg)

Result will be

![](url-to-image-5. jpg)
[fewfwe](url-to-image-5. jpg)

Expected behavior
Urls in markdown are not processed.
**Where it happened?

in an app (app.typopo.org)

Additional context
Just want to thank you for a great tool :)

Hi @fabulator, thanks for the report! I'll look into it.

Hi @fabulator, the issue has been fixed in the typopo app and the VS Code extension. Once again, thanks for the report.


Update the Python package dependency version

https://github.com/InsightSoftwareConsortium/ITKThinShellDemons/blob/62d4fe3a3519baaeee7ed865e8e652b206b64399/setup.py#L46
to v5.2.0.post2

@PranjalSahu we should now use 5.3rc3

https://github.com/InsightSoftwareConsortium/ITKThinShellDemons/pull/18


Not working on CentOS 8 - libselinux-python package does not exist

This role breaks on RHEL and CentOS 8, as the libselinux-python package no longer exists; I believe it should instead be python3-libselinux.

Well that works... but now I'm getting an error with the task:
- name: Restart network service (explicitly).
  service: name=network state=restarted

For now I'm trying to just leave that task off and we'll see if things still work okay.


[BUG] Image is not being pulled from configured mirror

What did you do?

How was the cluster created?

k3d create --volume <PATH_TO_CA_CERT>/MY_CERT.cer:/etc/ssl/certs/MY_CERT.cer

Created the following$HOME/.k3d/registries.yaml file before k3d create:
mirrors:
  docker.io:
    endpoint:
      - https://my.enterprise.repo/
configs:
  docker.io:
    tls:
      # we will mount "my-company-root.pem" in the /etc/ssl/certs/ directory.
      ca_file: "/etc/ssl/certs/MY_CERT.cer"

What did you do afterwards?

k3d commands?
docker commands? docker logs k3d-k3s-default-server
OS operations (e.g. shutdown/reboot)?

What did you expect to happen?
Although the mirror is configured, k3d is trying to pull docker.io images from registry-1.docker.io:
failed: rpc error: code = Unknown desc = failed to get sandbox image \"docker.io/rancher/pause:3.1\": failed to pull image \"docker.io/rancher/pause:3.1\": failed to pull and unpack image \"docker.io/rancher/pause:3.1\": failed to resolve reference \"docker.io/rancher/pause:3.1\": failed to do request: Head https://registry-1.docker.io/v2/rancher/pause/manifests/3.1: dial tcp <IP_ADDRESS>:443: i/o timeout"

Our enterprise proxy blocks Docker images downloads from workstations - we must use our mirror (Artifactory).
When I try run a deployment with a docker.io image I get the same error.
Screenshots or terminal output
If applicable, add screenshots or terminal output (code block) to help explain your problem.
Which OS & Architecture?

Linux

Which version of k3d?
k3d version v1.6.0
Which version of docker?
~ $ docker version
Client:
 Version:           18.06.1-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        e68fc7a
 Built:             Tue Aug 21 17:20:42 2018
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.1-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       e68fc7a
  Built:            Tue Aug 21 17:29:02 2018
  OS/Arch:          linux/amd64
  Experimental:     false

same probelm

Hi @rcsilva83, thanks for opening this issue!
Are you able to reach the Artifactory IP from inside the k3d nodes (e.g. docker exec k3d-k3s-default-master -- ping <IP_ADDRESS>)?

Hi @iwilltry42 . Sorry but now I'm using "kind".

@rcsilva83, fair enough 🤷♂
Would still like to help, if needed 👍


CI.yml test to see code coverage in detail

Added a test for netScore to increase code coverage but it unironically takes a minute.


Implement single-selection for datagrid

Select one ...  (check one with "x")
[ ] bug
[x] feature request
[ ] enhancement

Expected behavior

We need to allow datagrids that are selectable but only allow one selection at a time.
Actual behavior

Currently the only options are 1. not selectable, or 2. multi-selection. There's no way to enforce single-selection.
Reproduction of behavior

Environment details

Angular version: 2.0.X

Clarity version: All

OS and version: All

Browser: All

Just to link the issues, this is a fork for part of the discussion on #17.
Single-selection should simply be solved by using radio buttons instead of checkboxes in the Datagrid.

With 0.8.7, I have "clr-dg-action-overflow" on this datagrid. I selected 2nd row as the checkbox on, then clicked the action-overflow on the 1st row.

Per the pdf on #17, I assume that intention of the action overflow is to attach actions for single row selected. (Please correct me if I am wrong.) So for the above case, either of these two should be happened, ( but not sure which makes more sense).

datagrid changes checkbox selection to the 1st row per the action-overflow clicked.
datagrid disables the action-overflow on the other rows not checked on.

Because I think this issue is also considered as "radio" behavior of single row selection, I put my comment here instead of opening new issue.

Hi @chunghha thanks for your comment. We initially considered implementing option 1 from what you have written. However, from the UX point of view, the action overflow is kind of like a right-click on the row and not linked to the current selection. Consider this scenario: you are selecting items that match your criteria, and then you want to do a quick action on a given row before continuing to select items. You don't want the clicking of the overflow to unselect all the other rows.
The radio behavior implementation mentioned in this issue is in review right now so feel free to subscribe to it for updates: #507


CASM-4820: KYVERNO chart upgrade needed for CSM version 1.6.x

Summary and Scope
Kyverno Upgrade Needed for CSM version 1.6.x, to ensure the Kubernetes Version 1.24 Compatibility and N-2 support policy offered by the Kyverno community.
Testing
Install, upgrade, rollback, policy and cluster policy listing, policy report.
Tested on:
Surtur
Test description:
KyvernoLogs1.6.2artiChart.txt

Obsolete - covered by #3571


PreferenceDecorator does not adapt appearance of android.preference.Preference

The appearance of a preference, which is extended from the class android.preference.Preference is not adapted by the PreferenceDecorator.

Fixed in version 2.0.1.


Position of  changes from body to headd

Describe the bug
I have the following code in my [...slug].vue in Nuxt content
<script setup>
const route = useRoute()
const { data: page } = await useAsyncData('content', () => queryContent(route.path).findOne())

// Extract schema from the content's frontmatter
const schema = page.value.schema_org

// Use the nuxt-schema-org composable to add schema
if (schema !== undefined && schema != null) {
  useSchemaOrg(schema) // generates tag in body
} else {
  useSchemaOrg("") // generates tag in head
}
</script>

Depending on which call it makes the tag is generated in the head or body (see comments in the code)
Sidenote: When I call the useSchemaOrg() w/o parameters or a null or undefined value, it does not generate any schema tag.
Reproduction
No response
System / Nuxt Info
- Operating System: `Darwin`
- Node Version:     `v21.7.1`
- Nuxt Version:     `3.13.2`
- CLI Version:      `3.14.0`
- Nitro Version:    `2.9.7`
- Package Manager<EMAIL_ADDRESS>- Builder:          `-`
- User Config:      `-`
- Runtime Modules:  `-`
- Build Modules:    `-`

I believe this should be a bit more stable in the latest version.
Let me know if not, also a reproduction would be handy :pray:


How to extract C3D features？

Thank you for your excellent work. I want to run your model on my own data set, but you are training based on extracted features, can you disclose how to extract C3D video features from the data set? Thank you very much!

The C3D features are provided by the creators of ActivityNet Captions. For additional details, please visit http://activity-net.org/challenges/2016/download.html#c3d.

The C3D features are provided by the creators of ActivityNet Captions. For additional details, please visit http://activity-net.org/challenges/2016/download.html#c3d.

Thank you very much for your reply. I want to train this model on my own data set. In the first step, I follow your instructions to extract tsp features of the video. pkl and.npy files are obtained at the same time, but python merge_pkl_files_into_one_h5_feature_file.py is converted to.h5 using the Python merge_pkl_files_into_one_H5_feature_file. py according to the readme, but errors are reported during the conversion process. I cannot get the.h5 file. How should I proceed?


Cherry-pick HDF5 code from morphocluster-sd-extension-run

[ ] tests added
[ ] all tests pass
[ ] documentation
[ ] AUTHORS entry
[ ] Changelog entry

📚 Documentation preview 📚: https://morphocut--117.org.readthedocs.build/en/117/

3.9 is actually still supported. The commit message is wrong.


Tags in VACP Service Definition for PostgreSQL Credentials

I faced the problem that my connection information from default-env.json was not picked up when I followed the example in the README.md:
{
  "VCAP_SERVICES": {
    "postgres": [
      {
        "name": "postgres",
        "label": "postgres",
        "tags": ["postgres"],
        "credentials": {
          "host": "localhost",
          "port": "5432",
          "database": "dbname",
          "user": "postgres",
          "password": "postgres",
          "schema":"public"
        }
      }
    ]
  }
}

I figured out, when I follow the example from Gregors https://github.com/gregorwolf/pg-beershop the default-env.json is slightly different:
{
  "VCAP_SERVICES": {
    "postgres": [
      {
        "name": "postgres",
        "label": "postgres",
        "tags": ["plain", "database"],
        "credentials": {
          "host": "localhost",
          "port": "5432",
          "database": "beershop",
          "user": "postgres",
          "password": "postgres"
        }
      }
    ]
  }
}

Switching the tags from "postgres" to "plain" and "database" makes the difference. I don't know if this is an issue how cds-pg identifies the service definition or if it works as intended and the README.md needs to be adjusted.
Kind regards,
Sebastian

ah, good catch - we had the dialect resp tags thingie documented for package.json (see README.md), but were obviously missing the corresponding entry for the default-env.json example - mind submitting a PR for this? would be rad 🚀

Hi Volker,
I'm happy to contribute a pull request. But I would like to understand how exactly the credentials are read from the environment.
I'm not sure if this part of cds-pg or cds itself. Looking at https://github.com/sapmentors/cds-pg/blob/main/lib/pg/Service.js I would think that cds provides the options and credentials to the constructor, but the description in CAP how services are located (https://cap.cloud.sap/docs/node.js/cds-connect#vcap_services) and the fact that apparently the dialect in the cds-pg config is important makes no sense to me.
Kind regards,
Sebastian

I have submitted PR #264.

Thank you.


Corrupted zip file?

I've tried downloading these all as a zip but it appears to be corrupted.

Every time I try to extract the contents of the zip, I get an error saying the archive is corrupt.
I am also getting lots of errors when trying to download individual files instead; tga files that won't open, fbx files that appear to be corrupted.

I have the same issue. Over two days I have repeatedly tried to download the zip and it either fails to download or it completes but the zip is corrupt. And the few times it has completed the file size of the zip was different.


emails: Add onboarding team to zulip email.

Adds a 4th onboarding email for users who create a new Zulip organization, which is about the process of choosing the best chat application for their team.
Notes:

There's a prep commit for the test of get_onboarding_email_schedule. This refactor makes it significantly easier to test the addition of a new email to the schedule.
For the text version, I removed the emoji in the first bullet point, and I placed the links in a way that made it easier to read in my opinion.
I'll note that in order to follow our email scheduling rules, most of the time this email is going out 8 days after the user created the new Zulip organization.

Screenshots and screen captures:

HTML version

text version

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! Based on the screenshot, it doesn't look like this has a Zulip Cloud vs. self-hosted conditional for the "contact us" line? We should follow #24260 on that. I think these versions are fine for this email:

Cloud: Do you have questions or feedback to share? Contact us — we'd love to help!
Self-hosted: If you have any questions, please contact this Zulip server's administrators at<EMAIL_ADDRESS>

For the text version, I removed the emoji in the first bullet point

I think we could use a emoticon there? ;)

Updates:

Noticed an issue with the implementation for #24260, so I put up #25357.
Used the macros and text versions of the above for the "contact us" line.
Added the " ;) " to the text version of the email.

Updated screenshots:

Text version - self-hosted

HTML version - self-hosted

Text version - Zulip Cloud

HTML version - Zulip Cloud

Updates:

Just cleaned up the merge conflicts that had accumulated so that this work is up-to-date for further text/format revision. The most recent screenshots above are still accurate for the new onboarding team email, but posting updated self-hosted versions from dev enviroment emails below.

Screenshots:

self-hosted HTML

self-hosted text

I took a pass at tightening up the email content: #26713

Merged the first commit as 84f1ee84ff9bea1c7a5f9e1310e57d12632a6bc5; the code changes otherwise lgtm aside from the content work and the Saturday detail noted above.

@timabbott - Thanks for merging that prep commit with the test clean-up!
#26713 has also been updated for the current changes to this PR. I'm going to close this in favor of that one, so that there aren't two versions of the same code changes with different email text changes.
I'm following that PR and can make the final updates there when @alya settles on the final version of the new team onboarding email text.


support passing metadata at request time

Use case:
I am implementing persisted queries for my own custom backend.  To do this, in production I generate a build artifact that goes along with the query.  Then I want to write a middleware to modify the request on the way out to simply replace the serialized query with the build artifact.  On the server, the artifact gets transformed back into the query.
The problem: there is no (real) way for me to send this artifact through the request for my middleware to consume.  The only way I could get this to work is to "smuggle" it through variables as a magic field that gets extracted out by my NetworkInterface.
This would be much nicer if I could just pass that build artifact through the request to have the middleware swap it out.
Could this be a plugin?
Maybe.  Middleware comes very close to doing everything I need, I just don't have a good API to send it the extra bit of data it needs.
Is there a workaround?
Yes, see above about smuggling it through variables.  However this is super hacky, I would prefer to do it correctly.
Note: the interface for Request indicates that one can pass in additional key/value pairs, but this data unfortunately does not survive to the NetworkInterface/middleware layer.

@roippi I think the right thing to do here would be to make sure that those additional keys don't get stripped out any more. There's probably a line somewhere in the middleware stack or network interface that currently does this. If you find it, please submit a PR!

Yep, can do.

So as brought up in the (closed) PR the issue is here: https://github.com/apollostack/apollo-client/blob/master/src/core/QueryManager.ts#L937
These keys get stripped out before the middleware stack.  My fix unfortunately was too permissive and simply passed through everything on options.  While technically the interface of Request permits that, it has some unfortunate side effects like also sending operationName over the wire.
The idea of using extensions was brought up but I'm not 100% sure that fits - the spec defines that on the response, not the request.  https://facebook.github.io/graphql/#sec-Execution.  And to clarify, I'm not trying to send any extra params over the wire, I'm just trying to get metadata to survive to the middleware layer.
QueryOptions even has a metadata field that I didn't notice before.  This again would be fine for me to use but it gets stripped out in QueryManager.fetchRequest at the aforementioned point.  https://github.com/apollostack/apollo-client/blob/master/src/core/watchQueryOptions.ts#L73
Looking at how things are architected now, this is altogether not an easy ask, since I'm asking for metadata to live through to the networkInterface implementation.  I could write code to strip out metadata in HTTPFetchNetworkInterface.prototype.fetchFromRemoteEndpoint but that's just one network interface implementation... user-provided ones will not be expecting this extra metadata field.

@roippi I believe metadata is the ideal place for "custom" information to be stored. I would like to utilize it for marking certain queries as the ones that require "global" loading spinner. So that I could use that info in a middleware to dispatch the action that will show the spinner.
Do you see any harm in passing metadata all the way to the networkInterface?

I think we could consider passing metadata to the network interface, but we'd have to make sure to strip it out in the networkInterface then. I'd be open to a PR if someone wants to try.

The problem is that NetworkInterface is a public-facing API; the docs freely recommend subbing in your own.  For those that do, this will be a breaking change since they generally won't strip it out.
One way to make this reasonably backwards-compatible is to extract the metadata from the request and shuffle it into some parallel param that gets passed down along with it.  Third-party NetworkInterfaces will just discard it gracefully then.

@roippi @helfer  are we talking about adding metadata field to GraphQLRequest interface? If so, I don't see any breaking changes here, we are adding new stuff, not removing it, I might not see the whole picture though
@roippi Could you please give an example of a situation when this becomes a problem?

@roippi , can you weigh in on whether what @wizardzloy is saying true? That adding metadata wouldn't be a breaking change? I don't see why passing a new field (metadata) to custom network interfaces would break them?
I think for my use case, passing info about how to batch transactions as described in #1656, a metadata field would be a very nice way to solve it.
Thanks!


Problem with BatchNormalization for CNNs

Hi, I'm trying to create a CNN - AlexNet with Keras, and I'm trying to use Batch Normalization for the first 2 layers (Using the Functional API).
I'm running a for loop to pick random variables from lists.
The problem is that when I try to run the loop with a simple line for batch normalization, I get an error: "BatchNormalization' object has no attribute 'shape'"
I don't know what the input shape is going to be since it is random each time.
I somewhat new to coding, I'd be glad for any advice.
`for i in range(10):
#Here are the four hyperparameters that we'll pick at random from the lists above
a = random.choice(activation_list)
h = random.choice(optimizer_list)
batch = random.choice(batch_list)
filters = random.choice(filters_list)
full_neurons = random.choice(neurons_list)
#Build model
##input
visible = keras.Input(shape=(32,32,3))
#1st layer
conv1 = tf.keras.layers.Conv2D(filters,kernel_size = (3,3),strides = (1,1),activation = a, padding = 'same')(visible) #can randomize kernel_size, strides, padding
pool1 = tf.keras.layers.MaxPooling2D(pool_size = (2,2), strides = (1,1))(conv1) #can randomize pool_size, strides
batch_norm1 = tf.keras.layers.BatchNormalization()`

@JCRMT-lima,
Looking at the code, the issue doesn't seem to be related to Tensorflow Hub. Can you please confirm if you are using TF Hub? If you are not using TF Hub, and if the problem is with Tensorflow, please raise the issue in this Tensorflow Github Repository. Thanks!

@JCRMT-lima, Can you share full code or link of notebook file to reproduce mentioned error.

@JCRMT-lima,
Can you please provide the information asked above. Thanks!

@JCRMT-lima,
Can you please provide the information asked above. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Rename Isabell Long => Issy Long in their user manifest

This is a purely cosmetic change.
There are no other changes required, but I'm gradually trying to
deprecate "Isabell".
My Google Account has been Issy for some time, so if people look for
Isabell and don't find me then that could be confusing.
My LDAP username is still isabelllong, because that's even more
difficult to change.

Oh god!
  1) users::isabelllong should have a username of the correct form
     Failure/Error: expect(user[:name]).to eq(uname_from_full), "expected username '#{user[:name]}' to be '#{uname_from_full}' based on fullname and email"
       expected username 'isabelllong' to be 'issylong' based on fullname and email
     # ./modules/users/spec/classes/users_spec.rb:40:in `block (3 levels) in <top (required)>'

I will live with this.


v.1.27.2 container issue on synology

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
the v1.27.2 container does not start on my synology nas. It keeps repeating:
/opt/app/erts-12.2/bin/beam.smp: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /opt/app/erts-12.2/bin/beam.smp
I'm guessing this has something to do with the wrong elixir base image being referenced in the Dockerfile?
This looks similar to the issue that was present in 1.25: https://github.com/adriankumpf/teslamate/issues/2300
Thanks !
Expected Behavior
container should start
Steps To Reproduce
No response
Relevant log output
/opt/app/erts-12.2/bin/beam.smp: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /opt/app/erts-12.2/bin/beam.smp

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v1.27.2

the syno in question:
ash-4.4# docker --version
Docker version 20.10.3, build 55f0773
ash-4.4# cat /sys/firmware/devicetree/base/model
synology_geminilake_720+

Same docker build, synology_geminilake_920+
Teslamate starts without any problem. I start it with attached JSON import file
teslamate.1.27.2 - Kopie.json.txt

Thank you for your confirmation.
I have no idea what I did wrong the other day, but I just retried and it works as expected...
Sorry for disturbing everyone.


The git manager process has crashed. Please restart your application

Category
bug report
What is the current behavior?
I have an error for Gitbook editor, after updating 6.3.0 on Mac 10.12.
If I launch my app, it says that

"The git manager process has crashed. Please restart your application"

I have removed previous versions and reinstall, but it doesn't work.
I even couldn't log in.
What is the desired behavior?

Additional information

I have the same issue on 10.11.

Same problem.

Can you send me the content of ~/Library/Application\ Support/gitbook-editor/log-app.log (OS X) at<EMAIL_ADDRESS>?

Done.

Same problem.

We just released the version 6.3.1, it should fix this issue. Otherwise send me the output of the log file ~/Library/Application\ Support/gitbook-editor/log-app.log by email.


Question: How to better include turn off animation/light effect

In my awtrix matrix, there is a turn off animation whenever the display is turned off, which I think it is nice.
I built an Addressable Lambda Effect in esphome to mimic the same animation on my Ulanzi EsphoMaTrix, assigned it to the light component and it works fine if I trigger the effect manually.
Probably there are simpler ways to achieve this, but here it is for reference, if anyone wants to use it also:
addressable_lambda:
  name: "ZZZ"
  update_interval: 100ms
  lambda: |-
    static int x = 0;
    if (initial_run) {
      x = 1;
      it.all() = Color(0,0,0);
    }
    // it.range() seems to include initial LED # but excludes last LED #
    switch (x) {
      case 1:
        // Line 8 - right to left (from 224)
        it.range(231, 236) = Color(255,255,255);
        x += 1;
        break;
      case 2:
        // Line 7 - left to right (from 192)
        it.range(210, 215) = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it.range(231, 236) = Color(0,0,0);
        it[233] = Color(255,255,255);
        x += 1;
        break;
      case 3:
        // Line 6 - right to left (from 160)
        it.range(172, 177) = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it.range(210, 215) = Color(0,0,0);
        it[211] = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it[233] = Color(0,0,0);
        it[237] = Color(255,255,255);
        x += 1;
        break;
      case 4:
        // Line 5 - left to right (from 128)
        it.range(141, 146) = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it.range(172, 177) = Color(0,0,0);
        it[174] = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it[211] = Color(0,0,0);
        it[208] = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it[237] = Color(0,0,0);
        it[240] = Color(255,255,255);
        x += 1;
        break;
      case 5:
        // Line 4 - right to left (from 96)
        it.range(111, 116) = Color(255,255,255);
        // Line 5 - left to right (from 128)
        it.range(141, 146) = Color(0,0,0);
        it[144] = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it[174] = Color(0,0,0);
        it[176] = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it[208] = Color(0,0,0);
        it[206] = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it[240] = Color(0,0,0);
        it[242] = Color(255,255,255);
        x += 1;
        break;
      case 6:
        // Line 3 - left to right (from 64)
        it.range(75, 80) = Color(255,255,255);
        // Line 4 - right to left (from 96)
        it.range(111, 116) = Color(0,0,0);
        it[112] = Color(255,255,255);
        // Line 5 - left to right (from 128)
        it[144] = Color(0,0,0);
        it[142] = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it[176] = Color(0,0,0);
        it[178] = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it[206] = Color(0,0,0);
        it[204] = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it[242] = Color(0,0,0);
        it[244] = Color(255,255,255);
        x += 1;
        break;
      case 7:
        // Line 2 - right to left (from 32)
        it.range(49, 54) = Color(255,255,255);
        // Line 3 - left to right (from 64)
        it.range(75, 80) = Color(0,0,0);
        it[78] = Color(255,255,255);
        // Line 4 - right to left (from 96)
        it[112] = Color(0,0,0);
        it[114] = Color(255,255,255);
        // Line 5 - left to right (from 128)
        it[142] = Color(0,0,0);
        it[140] = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it[178] = Color(0,0,0);
        it[180] = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it[204] = Color(0,0,0);
        it[202] = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it[244] = Color(0,0,0);
        it.range(241, 246) = Color(255,255,255);
        x += 1;
        break;
      case 8:
        // Line 1 - left to right (from 0)
        it.range(8, 13) = Color(255,255,255);
        // Line 2 - right to left (from 32)
        it.range(49, 54) = Color(0,0,0);
        it[51] = Color(255,255,255);
        // Line 3 - left to right (from 64)
        it[78] = Color(0,0,0);
        it[75] = Color(255,255,255);
        // Line 4 - right to left (from 96)
        it[114] = Color(0,0,0);
        it[117] = Color(255,255,255);
        // Line 5 - left to right (from 128)
        it[140] = Color(0,0,0);
        it[137] = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it[180] = Color(0,0,0);
        it[183] = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it[202] = Color(0,0,0);
        it.range(200, 206) = Color(255,255,255);
        // Line 8 - right to left (from 224)
        it.range(241, 246) = Color(0,0,0);
        x += 1;
        break;
      case 9:
        // Line 1 - left to right (from 0)
        it.range(8, 13) = Color(0,0,0);
        it[13] = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it[183] = Color(0,0,0);
        it.range(178, 183) = Color(255,255,255);
        // Line 7 - left to right (from 192)
        it.range(200, 206) = Color(0,0,0);
        x += 1;
        break;
      case 10:
        // Line 5 - left to right (from 128)
        it[137] = Color(0,0,0);
        it.range(138, 143) = Color(255,255,255);
        // Line 6 - right to left (from 160)
        it.range(178, 183) = Color(0,0,0);
        x += 1;
        break;
      case 11:
        // Line 4 - right to left (from 96)
        it[117] = Color(0,0,0);
        it.range(112, 117) = Color(255,255,255);
        // Line 5 - left to right (from 128)
        it.range(138, 143) = Color(0,0,0);
        x += 1;
        break;
      case 12:
        // Line 3 - left to right (from 64)
        it[75] = Color(0,0,0);
        it.range(76, 81) = Color(255,255,255);
        // Line 4 - right to left (from 96)
        it.range(112, 117) = Color(0,0,0);
        x += 1;
        break;
      case 13:
        // Line 2 - right to left (from 32)
        it[51] = Color(0,0,0);
        it.range(46, 51) = Color(255,255,255);
        // Line 3 - left to right (from 64)
        it.range(76, 81) = Color(0,0,0);
        x += 1;
        break;
      case 14:
        // Line 1 - left to right (from 0)
        it[13] = Color(0,0,0);
        it.range(14, 19) = Color(255,255,255);
        // Line 2 - right to left (from 32)
        it.range(46, 51) = Color(0,0,0);
        x += 1;
        break;
      case 15:
        it.all() = Color(0,0,0);
        break;
    }

If I turn on the light with the effect, it switches from the clock to the animation.
The "problem" is that to stop the animation, I either need:

to apply an effect 'None' (which actually turns on all the LEDs in the matrix, same as turning light on without any effect) or;
directly turn off the light (which actually "reactivates the clock" - which makes sense but not when turning off the display).

So my question here is: how would you guys better include this to behave as a turn off animation? Going from clock or whatever is on the display to the animation and then display off.
Thanks for any suggestions.

After a bit of thinking....
Perhaps it is best to not use an effect, instead add your code to the display lambda. But this is called every 16ms, so you have to slow down your code and disable my tick() and my draw() functions.
Even better support for 8x32 gifs.....

i think the idea with 8x32 animations would be possible with out changing the whole code.
like 8x8 icons with scrolling text and 8x32 animations without text
i will take a closer look.

I didn’t want to suggest that, considering the amount of priceless work you have already put into this component (thanks again for that), but that would be a perfect addition which I think a lot will appreciate.

i added support for 8x32 images and animations. Their display works the same as for 8x8 icons but for 8x32 images no text will be displayed.
breaking: you have to scale all icons your self, i removed the automatic scaling

i added support for 8x32 images and animations (in the 8x32 branch). Their display works the same as for 8x8 icons but for 8x32 images no text will be displayed.

Quick test seems to work, need more time into it.

breaking: you have to scale all icons your self, i removed the automatic scaling

Noticed the error while compiling before installing to esphome, I just wonder if it would be possible to show the whole list of non 8x8 or 8x32 images, instead of the first found from the list, to make it easier to fix without going one by one.

check the recent push to 8x32. icons with wrong size are skipped with warning!

For me, it is rather cumbersome to NOT to be able to specify how many times a screen is to be shown, even more with animations...
I know you have mentioned it here, but  I would still see it as useful, specially with animations.
To be able to achieve an animation to be shown only once (at shutdown, as per my initial question), I'd need to make sure I would delete the screen before the animation would start a second time...

I understand the requirement and see the possible uses, but it is not necessary for my purposes. An implementation would require a redesign of the inner processes.
If someone has an implementation, I am happy about every pull request.
That's why this topic is tagged with "help wanted"

Quick test seems to work, need more time into it.

@pplucky
Can you share a 8x32 animation gif for testing please?

@pplucky Can you share a 8x32 animation gif for testing please?

Sure, here is the 8x32 GIF I generated for the above effect:

starting with 2023.4.0 there is a parameter show_time for each screen, you can set a longer displaytime per screen.
Please read the "how to update" section in the new README.md before trying!
If you included your sample gif under the id sleeping you can display it for e.g. 60 seconds with this call:
service: esphome.ulanzi_add_screen
data:
  icon_name: sleeping
  text: ehmtx
  screen_time: 60

With the possibility to disable the clock you can show this animation all day long.


Add readme-md-generator to command line apps

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖
⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆
reamdme-md-generator is a CLI that generates beautiful README.md files.
It will suggest you default answers by reading your package.json and git configuration.

The tool itself looks good, but I'm going to pass on this as I don't want to recommend such readme's. I think we have very different views on what a "beautiful readme" is. There are too many badges, too many emoji, too much information that does not need to be in the readme.


[CVE RISK] Upgrade urllib3 to v1.26.5

The Issue
An issue was discovered in urllib3, when provided with a URL containing many @ characters in the authority component, the authority regular expression exhibits catastrophic backtracking, causing a denial of service if a URL were passed as a parameter or redirected to via an HTTP redirect.
An issue was discovered in urllib3 before 1.26.5. When provided with a URL containing many @ characters in the authority component, the authority regular expression exhibits catastrophic backtracking, causing a denial of service if a URL were passed as a parameter or redirected to via an HTTP redirect.
How to Fix
The following branches contain urllib3 v1.25.11 and need to be upgraded to v1.26.5 or later.

origin/main
origin/1
origin/1.1

From my understanding, setup.py in the opensearch-benchmark branches install opensearch-py (different versions) which have "urllib3>=1.21.1" in install_requires.
Should I add "urllib3>=1.26.5" in 'install_requires' of opensearch-py or opensearch-benchmark?

As I see it opensearch-py requires urllib3 and downloads it, @AkshathRaghav, I think doing either would work. I think adding urllib3>=1.26.5 on setup.py (depending on how it's installed) should then update it to >1.26.5. Although I think adding it in OpenSearch-py would be the better option.

@AkshathRaghav Either would work as @maddox05 mentioned. Feel free to make a PR request to opensearch-py to see if they'd be willing to bump urllib3 from v1.21.1 to v1.26.5

opensearch-py's setup.py file

If they provide a reason why they cannot, we can opt to add urllib3>=1.26.5 to our own setup.py

@IanHoang will do, I'll keep you updated here.

Pull request to the main branch - https://github.com/opensearch-project/opensearch-py/pull/515
Waiting for the checks to pass before I do the PRs for the other version branches in opensearch-py (which branch 1 and 1.1 here depend on)

@AkshathRaghav possibly hardcoding it in

origin/main
origin/1
origin/1.1
wouldn't hurt.

Sure that'd be easier tbh. But when setting it up, it'd install twice.

it should be installed through opensearch library with the first command, and then if its already installed it should just skip it. Just as a backup in case opensearch-py library installed the wrong ver of urllib3.

If the main opensearch-py setup has a dependency as 1.26.5, it can't install the wrong version; our setup.py will only install it if the module wasn't existing.

that is what I meant yes sorry for the confusion.

Why not bump the opensearch-py version once https://github.com/opensearch-project/opensearch-benchmark/issues/378 happens?

@wbeckler our setup.py's install_requires doesn't specify urllib3 as a dependency since it is installed with opensearch-py. Instead of explicitly specifying it, it'll be more straightforward for OSB to to use the urllib3 that comes packaged withopensearch-py.
Note: https://github.com/opensearch-project/opensearch-py/pull/518 has been merged in

Will do @IanHoang 👍


Make Pill Buttons the default

In Material Design 3, the default button has a 100px radius, since Beercss follows MD3, I think it would be better if it uses pill buttons by default or at least add more border-radius to the current button, maybe make it 12px.
See: https://m3.material.io/components/buttons/overview

Hi @tomatopickle ,
After release 2.2.0 we following all specs of buttons and chips. But we can't use the pill button as default because we have a helper called round. We want to maintain the same logic in all elements to be easy to use and remember. If you want a "pill button" use round helper. So you use round when you want any element to be rounded. Ok?


ocamlPackages.{tyxml,lwt}: always enable camlp4 support

Motivation for this change
camlp4 is now available for OCaml 4.07
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ocamlPackages_latest.lwt ocamlPackages_latest.tyxml

Success on x86_64-darwin (full log)
Attempted: ocamlPackages_latest.tyxml
The following builds were skipped because they don't evaluate on x86_64-darwin: ocamlPackages_latest.lwt
Partial log (click to expand)
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/svg_f.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_print.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_wrap.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_iter.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/META
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib  /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/bin
patching script interpreter paths in /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0
/nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0

Success on aarch64-linux (full log)
Attempted: ocamlPackages_latest.tyxml
The following builds were skipped because they don't evaluate on aarch64-linux: ocamlPackages_latest.lwt
Partial log (click to expand)
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/ppx_tyxml.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/pa_tyxml.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_tools.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_top.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml.cmxs
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib  /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/bin
patching script interpreter paths in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0
checking for references to /build in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0...
/nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0


style: add space before render method

Linter generates errors Missing space bofore function parentheses when generating smart component. Added space before render method to make linter happy. Other files should be fine.

[Current coverage][cc-pull] is 69.41%

Merging [#759][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #759   diff @@
==========================================
  Files            16         16
  Lines            85         85
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             59         59
  Misses           26         26
  Partials          0          0

Powered by Codecov. Last updated by af2f6ae
[cc-base-branch]: https://codecov.io/gh/davezuko/react-redux-starter-kit/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/davezuko/react-redux-starter-kit/pull/759?src=pr

Thanks!

Reworded your commit to abide by our guidelines, but it has been merged (see https://github.com/davezuko/react-redux-starter-kit/commit/efa59fe815f654cba4abb5a813863db0b5d64fe7). Thank you!

Woops, proper hash: https://github.com/davezuko/react-redux-starter-kit/commit/bab3f0d783601428cc37a3ed389308d42cc3cb39


Suggestion: Config option to disable logging

Occasionally I see a ton of new lines in the log coming from this mod - it's not a major issue, but if we're in the middle of a lag spike, then removing these logs might help a little bit.  I'm fine with the option allowing logging by default, this is just something that came to mind while playing.

Nevermind, I just used the LessLogs mod and we're good now.  Thanks for an awesome mod!


Search Base not working

Category

[ ] Enhancement
[X] Bug
[ ] Question
[ ] Documentation gap/issue

Version
Please specify what version of IdFix you are using: [  <IP_ADDRESS>       ]
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.
Expected / Desired Behavior / Question
Able to search a specific OU using the search base option in the connection screen.
Observed Behavior
When entering a value in the search base, tick the box to enable the search base text box, when entering a value, and clicking OK, i then go back in and edit the connection,, the search base box is ticked, but the value entered is blank, so the search base appears to have no effect when doing a search.
Steps to Reproduce
Open IDfix, click the Cog to configure connection, enter value in search base, click OK.  Click cog again, an value is blank.
Thanks,
Steve

For this one search base was applied correctly, but there was a UI bug. If you checked the box and entered a base it was applied. If you returned to the settings and unchecked the box it was removed. If you then returned to settings the checkbox was still checked but the box was empty. We cleaned up this UI behavior. Thanks for reporting the bug!

Just released <IP_ADDRESS> including a fix for this issue. Please try out the latest version and you should no longer see this issue. Thank you for your patience and for reporting the issue allowing us to get it fixed. Thank you!


Crashing on re-entry of preset store

bug report from @Gennadiyev , app crashes after unlocking the phone

cannot replicate this issue


Error in SqliteFailure not exported

I'm trying to check whether an error I get from rusqlite is caused by database being locked, but it seems that the error type necessary for this check isn't quite public (it's not clickable in Rustdoc output, and I can't see its full name):
https://jgallagher.github.io/rusqlite/rusqlite/enum.Error.html#variant.SqliteFailure
I guess the error is public, but from another crate, which would require me to find that crate, add it to my project with a matching version, just to be able to name this type in match.
Could you publicly re-export this type?

Sorry,
The doc at https://jgallagher.github.io/rusqlite/rusqlite/ is not up to date.
You should use https://docs.rs/rusqlite/0.14.0/rusqlite/enum.Error.html#variant.SqliteFailure.
extern crate libsqlite3_sys as ffi;
extern crate rusqlite;

use rusqlite::Connection;
use rusqlite::Error::SqliteFailure;

    if let Err(e) = Connection::open_in_memory() {
        if let SqliteFailure(rc, _) = e {
            println!("{:?}", rc);
            if rc.code == ffi::ErrorCode::DatabaseLocked {
                println!("{:?}", rc.extended_code);
            }
        }
    }

Should I delete gh-pages ?

Deleting of outdated gh-pages would help (I looked at gh pages documentation, because some projects prefer them when docs.rs can't build the crate properly).
I've found the error code is re-exported, but AFAIK I'd still need extern crate libsqlite3_sys to match against error type.

Ah, right.
I think you don't have to use extern crate libsqlite3_sys.
use rusqlite::Error::SqliteFailure;
use rusqlite::ErrorCode;

    if let Err(e) = Connection::open_in_memory() {
        if let SqliteFailure(rc, _) = e {
            println!("{:?}", rc);
            if rc.code == ErrorCode::DatabaseLocked {
                println!("{:?}", rc.extended_code);
            }
        }
    }

Could you please confirm that the following example works as expected:
extern crate rusqlite;

use rusqlite::Connection;
use rusqlite::Error::SqliteFailure;
use rusqlite::ErrorCode;
use rusqlite::OpenFlags;

fn main() {
    if let Err(e) = Connection::open_with_flags("test.db", OpenFlags::SQLITE_OPEN_READ_ONLY) {
        if let SqliteFailure(rc, _) = e {
            println!("{:?}", rc);
            if rc.code == ErrorCode::DatabaseLocked {
                println!("{:?}", rc.extended_code);
            }
        }
    } else {
        println!("OK");
    }
}

?
And close this issue accordingly.

It does.

It would be nice to document such an example, it's not obvious how one can isolate the code enum. I'm glad I found this example here.


Setting the argument find_unused_parameters to False

📚 Documentation
Sean Carter
I’m running into a RuntimeError:Expected to mark a variable ready only once.. A quick google search found that setting the argument find_unused_parameters to False might fix this. Where do I put it in pytorch lightning?

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging PyTorch Lightning, Transformers, and Hydra.

cc @Felonious-Spellfire @akihironitta

I ended up putting a strategy = 'ddp_notebook_find_unused_parameters_false' argument in my pl.trainer.__init__(). However, when this happens, I get a RuntimeError: The server socket has failed to listen on any local network address

@Felonious-Spellfire, this issue has been resolved in Slack. Can we close this issue? Or what is its purpose?

@carmocca
I'll be creating tickets for questions, adding the content to the docs, closing the tickets then closing the loop and adding the URL from the docs to the original Slack post.
While the issue was resolved in Slack, the answer to his original question about where they should put the argument find_unused_parameters to False in PL wasn't.

Okay! I assume you want to check out if the current docs do answer that question.
And update them if they don't.
Could you assign yourself to such issues in the future? Thank you


添加各个组件制作成 docker 镜像的 Dockerfile

这个 PR 实现什么功能/修复什么问题:

添加各个组件制作成 docker 镜像的 Dockerfile
keystone 发现认证来源是 operator 的时候不记录 action log

是否需要 backport 到之前的 release 分支:

/area utils
/cc @wanyaoqi @yousong @swordqiu

Codecov Report

Merging #2127 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2127      +/-   ##
=========================================
+ Coverage    7.13%   7.16%   +0.03%
=========================================
  Files         451     445       -6
  Lines       70323   69564     -759
=========================================
- Hits         5016    4985      -31
+ Misses      64893   64167     -726
+ Partials      414     412       -2

Flag
Coverage Δ

#aFlag
7.16% <0%> (+0.03%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/keystone/models/users.go
2.26% <0%> (-0.02%)
:arrow_down:

pkg/cloudcommon/db/fetch.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/cloudsync.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/skus.go
1.4% <0%> (ø)
:arrow_up:

pkg/httperrors/httperrors.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/ucloud/securitygroup.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/loadbalancerbackendgroup.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/purge.go
0% <0%> (ø)
:arrow_up:

pkg/multicloud/aws/disk.go
0% <0%> (ø)
:arrow_up:

pkg/cloudcommon/db/opslog.go
2.66% <0%> (ø)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6482ee...8057ded. Read the comment docs.

/area util

要不要顺便把yunionio里的内容挪到yunion里去？
https://hub.docker.com/r/yunionio/onecloud-ci

/lgtm

/approve


Remove the RepositoryLayoutEnum class

All the classes using this enum like this:
RepositoryLayoutEnum.NUGET.getLayout()

should now be using:
NugetLayoutProvider.ALIAS

@sanket407 ,
This is related to #434. Would you perhaps Like to look into this as well?

@carlspring  yes

@carlspring RepositoryLayoutEnum class has to be deleted too ? Or only the enum use should be changed as given above ? As RepositoryLayoutEnum.MAVEN_2 is used else where too.

I was just giving an example with NuGet. The same approach used for NuGet
should be applied to Maven as well. This getLayout() string should be
replaced with the ALIAS of the respective layout provider implementation.
On 18 Dec 2017 1:57 pm, "Sanket Sawant"<EMAIL_ADDRESS>wrote:

@carlspring https://github.com/carlspring RepositoryLayoutEnum class
has to be deleted too ? Or only the enum use should be changed as given
above ? As RepositoryLayoutEnum.MAVEN_2 is used else where too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/strongbox/strongbox/issues/437#issuecomment-352406065,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXqaShZfJ3e4IZ6uE6HrRSucc3j6Glvks5tBlM5gaJpZM4RFRLF
.

This will be handled as part of #612.

Resolved.


Update examples to use lowercase reactive.{Calc,Effect,Value}

From #822

This PR changes those names to lowercase, and adds aliases so that the old capitalized names still work.
This PR does not change any examples because if users on a previous version of shiny were to use the example code, it wouldn't work for them, and it would be unclear to them why. In a future release, we should update the examples to use the new lowercase names.

Note that we also need to update the examples in the shinylive repo and py-shiny-site.


Add optional extra barcode preprocessing

Currently, the barcodes called, quality of barcodes called, and sgRNA assigned to barcode are all output by CellProfiler with no option to modify in-recipe.
It would be helpful to be able to perform troubleshooting to optimize barcode calling in recipe by enabling and additional barcode processing step that reads barcodes called but overwrites quality assignment and sgRNA assignment to allow for:

ignoring cycle n from all reads (e.g. we know Cycle 4 had a reagent mistake. Don't use Cycle 4 when determining call quality)
use N cycles (e.g. we gathered and read all 12 cycles but we know the last two are the worst performing and want to consider call quality only from cycle 1-10)

This is complemented by option to drop individual barcodes https://github.com/broadinstitute/pooled-cell-painting-profiling-template/commit/ba4e4ed582c2934de221f520ab282c9555b9722c


Implement back Solder (stack of 10) foundry Recipe

With Aluminium plate and Tin plate you are going to create Solder which is fine but why was the satcked recipe removed? There was no reason for it.
It is much better and easier to use stacked and/or sacked and high-pressure recipes directly instead of stacking and unstacking stuff.
Here is the image of what happened and how it destroyed an important part of my base: https://i.imgur.com/XLEsVA1.jpeg

Hi, apologies for delay in this. I sometimes miss github issues. I'll take a look into this and fix it.

I'm currently able to created stacked solder in various loadouts. Let me know if you still are not able.


Fix crash when extending non-existing GDScript file

Fixes #21682, regression from #21411.
Also fixes a few more related resource leaks.

Updated with a partial revert of #21411.

I think the false positives for these leaks in #21411 could be fixed by replacing script-> with scriptres->. I'm not so sure how coverity works.


Change backing data structure to preserve order.

Looking for a data structure which has O(1) search/get time, O(1) amortized insertion time, not horrible memory requirement - O(n) at worst, and orders by insertion time.
Potential options/research required:

HashMap (currently used; No insertion ordering)
BTreeMap
Linked-Hash-Map crate
IndexMap

In progress on dev branch


add number of updates in projectBySlug

@mohammadranjbarz @CarlosQ96 Is it possible to add No. of updates in projectBySlug?
I need it for new design

@mohammadranjbarz @CarlosQ96 When I use the new query in PR #209 for this project, it returns 3 for totalProjectUpdates.
But using getProjectUpdates, it returns 2 updates.

@CarlosQ96 @MohammadPCh shall we bring it back?

@CarlosQ96 Ramin said it shows +1 donation, I make it back to in-progress.

@MoeNick @RamRamez Found the issue. The count is "correct" but we have in all projects a Hidden projectUpdate that is empty for some reason.....
I'll update the code to ignore this.

@RamRamez
We have deployed it on staging, could you check it, please?

@RamRamez We have deployed it on staging, could you check it, please?

It seems good.

does this issue need further testing or can it be moved to done?

I think we can move it to Done, this is all done. We keep the total project updates # updated at all times every time a new projectUpdate is added or deleted.


Error In bootstrap's ui-Modal

When in bootstrap'e Modal window,report:
Error: ngTransclude:orphan
Orphan ngTransclude Directive

Can you create a Fiddle with some code examples so I can try and re-create


[raven-node] Ignore Errors does not working

ref: https://github.com/getsentry/raven-node/issues/436

Today I have been upgraded to 3.26.2 and same issue.

@nghiepit what exactly is not working? 3.26.2 is raven-js, not raven-node used to report initial issue.

Unified in new SDK


Added the leveldb header dependency to install_python_modules.sh

updated the dev container's install_python_modules.sh script to install the
libleveldb-dev development headers in addition to what's already being installed
created Issue 6741 to track this.

Thanks for the heads up!
I think it's because of dirty py27_requirements.txt file. We have already migrated the modules/common/kv_db lib from leveldb to sqlite.
We can simply remove the plyvel in the py27_requirements.txt file. Could you have a try?


feat(pinia-orm): Add the option for new not to persist the model

🔗 Linked issue
related to #1106

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (ece338e) 99.62% compared to head (4541bdd) 99.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   99.62%   99.62%
=======================================
  Files          88       88
  Lines        5859     5861    +2
  Branches      529      531    +2
=======================================
+ Hits         5837     5839    +2
  Misses         19       19
  Partials        3        3

Impacted Files
Coverage Δ

packages/pinia-orm/src/query/Query.ts
99.52% <100.00%> (+<0.01%)
:arrow_up:

packages/pinia-orm/src/repository/Repository.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Robot multigeometry

This PR provides support for adding circular bodies with an offset from the main robot. The current limit is set to 1 additional body for performance reasons. The main collision algorithm code lies in rmf_traffic/SplineCCD.cpp' collide_seperable_circles. It computes a distance vector to cover along the spline, then uses bilateral advancement to find roots.
see rmf_traffic/Profile.hpp for public api changes
Notable points of contention, let me know your thoughts on any of these:

WRT check_collision, if there are no extra geometry for the profile, we revert to the old FCL method.
Edit*: We could have the new algorithm completely supercede the old method but would entail that we drop our Box tests (since this algorithm uses only circles atm). Also, the old FCL method is faster, check the rmf_planner_viz scenario #8

Tolerance: Set to 0.1 in terms of distance. We might want to allow adjustment of these tolerance values elsewhere in future. Also, the  FCL method seems to use a time of contact error tolerance as seen here

Safety checks: There is another limit based on the number of distance checks used in the algorithm, currently set to 120. This is to prevent infinite loops in runtime caused by a small tolerance values.

Profile api: Should we allow the extra geometry to be named? Y/N?

Vicinity shapes: We still use only one shape for the vicinity. Given the ability to add extra shapes to the footprint, we can  automatically calculate the vicinity to never be smaller than the combined geometry. Problem is how do we deal with custom vicinity geometry? Is it time to enforce a circular vicinity geometry instead? Another option is to let users specify the vicinity shape along with the extra footprint geometry, incurring a performance penalty and extra maintainence cost. Yet another option is to leave the current implementation be, and let users maintain the single vicinity shape themshelves.

Other:

There's a TODO in the new tests in test_Conflict detailing a problem with differential splines generated from splines with no motions. It's not scenario that's likely to occur IRL so we can put it as low priority for now
you can do additional testing by running test_sidecar in https://github.com/osrf/rmf_planner_viz/
Performance tests of minimum 8ms per DetectConflict check have been added

Thanks for the review @mxgrey. Off the top of my head:

I'm not completely sure, but it looks like the implementation only works for circle-circle collisions right now. I'd be very reluctant to merge this feature if the implementation can't be extended to other types of convex shapes.

That's correct. It's easy to extend it to other convex by replacing the distance function. It's on my todo list.

Let's explore the feasibility of adding at least one more convex shape to this, like a capsule. It may be a good idea to first introduce capsules separately as a different PR, and just use the built-in FCL methods for that.

There's a problem in that the FCL implementation of capsules assumes the same radius for both endpoints. This essentially means if we have 2 bodies of different sizes and we want to merge them into a capsule we'll have to take the larger sized radius, using up a good amount of space. Let me know if you think that's fine and I'll put it in.

There's a problem in that the FCL implementation of capsules assumes the same radius for both endpoints.

This actually agrees with the definition of "capsule" that I"m familiar with: the volume of a ball swept along a line segment, with uniform radius from end to end. The more complex convex hull you're thinking of would be a very cool thing to support as well, but I think the ordinary uniform capsule would be a great thing to start with.

It would be good to have some kind of write-up of the performance characteristics of the sidecar. E.g. when you add a sidecar to your profile, how does it impact the speed of conflict detection?

The current implementation is a conditional, it uses the original fcl code path if you have single collision shapes on respective trajectories, otherwise it'll use the bilateral advancement algorithm for more seperable shapes.
Here are some performance results for collision between single objects on respective trajectories using the original fcl vs the bilateral advancement algorithm. Naturally, the latter's performance highly depends on the number of iterations for the bilateral advancement algorithm to reach the goal tolerance levels.
Bilateral advancement algorithm

You can increase the tolerance to 0.1 and the performance becomes 0.126ms with 4 distance checks.
FCL

It would also be good to have a write-up on reliability. Does this implementation give any false positives or false negatives for conflict detection? If so, what are the conditions for those false results? Are there any strategies that users can leverage to mitigate those conditions?

We can sometimes miss collisions and the chance of this happening increases if you specify trajectories with both a change in position and a high change in rotation. The solution is to increase the tolerance used in the algorithm. The following picture shows an example (the bright green double circle is the starting position, the dark green double circle is where the predicted collision is). The trajectory is an arc and there's a rotation too.

I'll put in a PR for the capsule implementation after the repo re-org. But let me know if there are any deal breakers for this method.


Recipes should use Ore Dictionary ingotDarkSteel

Crafting and Repair shall use Ore Dictionary names so it can use ingotDarkSteel from other mods.
With GregTech 5.08.18.jar maintained by @Blood-Asp, Dark Steel ingots are unified to gt:ingotDarkSteel, but these don't work for crafting Dark Steel Ball or repairing Dark Tools and Armour.

I don't think GT's dark steel is comparable to EnderIO's?

It is not, but Gregtech 5.08.18 unificate DarkSteel Ingots from EnderIO into gt:ingotDarkSteell.
I just opened a related issue https://github.com/Blood-Asp/GT5-Unofficial/issues/34 because until EIO can use Ore Dictionary names in recipes, it shall not default to unification.

Well - why should we allow oredict use for EnderIO specific ingots - just because they have the same name?

Currently EnderIO register ingotDarkSteel to the OreDictionary but does not use the OreDictionary name within recipes.
To have other mods to play nicely, either:
If DarkSteel can be produced/referenced by other mods
Then: Use OreDictionary name in recipes
Else: Register a distinct namespace.
Anyway, it seems illogical to register an OreDictionary Name and not make use of it.

GT tries to integrade as many mods as possible into it's material/tool system to allow deeper cross mod interaction.
While Dark Steel is allready in for quite some time, i only activated it's active usage a few versions back on request.
The default unification taget not being EnderIO is my mistake and i will fix it soon. But it is right, that registering something in the oredic and not using oredic recipes makes no sense. If you do not allow materials of the same worth from other mods, then do not register it in the first place.

Fixed via https://github.com/SleepyTrousers/EnderIO/commit/d98be8dd86e02b7ed40419ae01db27ee58063b7e


Git hooks

Addition of git hooks

Fails

:no_entry_sign:
Please assign someone to merge this PR, and optionally include people who should review.

  Generated by :no_entry_sign: dangerJS against 4b67e8387466a896b05d439c0b6b8d5abbbff065


Autoscaling Ingress Controllers | Add HPA to our tenant ingress controllers

Goals

Make our ingress controllers more dynamic with autoscaling worker nodes.
Consume less resources in tenant clusters where IC is not used or is low traffic.
Respond better to peaks in traffic to Ingress Controller.
Have load test coverage for Ingress Controler HPA and cluster-autoscaler.

Current state:

When launching a new cluster we set the number of ingresses to the number of nodes in the workers-array in cluster-operator.
This causes problems as the workers-array is no longer supported as a source of truth for worker counts with cluster-autoscaling.
A cluster with autoscaling will not change the number ICs running according to the changing number of nodes.

TODO

[x] Helm chart with Storm Forger test app - Fer - https://github.com/giantswarm/testapp/pull/1
[x] Storm Forger test in JavaScript - Fer
[x] Update outdated cluster-autoscaler PR - Fer https://github.com/giantswarm/kubernetes-nginx-ingress-controller/pull/78
[x] Use Storm Forger CLI to launch test - Ross
[ ] Add load test to e2etests that creates TC, installs test app and triggers test - Ross
[ ] Check if thresholds for CPU / Memory make sense in production
[ ] Check what the min/max number of ICs should be (also consider how many workers an IC is using?)

EDIT: Updated checklist with current state.

Plan to ship today, except Azure. Doing everything on our side, so they can take over when they're ready.

Shipped AWS.
Today, shipping KVM. Handing Azure release to Celestial.
Once we ship release, we need to create follow up tickets.

add specification in design approach
where else can we use this? for general backlog

HPA was already available for a while, it was disabled by default and no customer used it on their own while we had mix of other solutions (cluster-operator, CronJob) managing number of nginx replicas.
With work in last quarter or so, HPA has been enabled by default for selected clusters, across currently supported channels.
IMO any follow up work can be broken down (evaluated, prioritized) and this epic closed.

This is done. @cokiengchiara create follow up issues. Talk to @sslavic

@sslavic In Slack, you said, "repeatable load test was one of the TODOs in the epic. rest of the TODOs (and more) I think is covered with epic/nginx-tuning."

Add load test to e2etests that creates TC, installs test app and triggers test - Ross

Created this: https://github.com/giantswarm/roadmap/issues/141

The rest I added to https://github.com/giantswarm/giantswarm/issues/10163 and not in separate issues since first two are tasks to "check" let me know if this organization makes sense for you.

Check if thresholds for CPU / Memory make sense in production
Check what the min/max number of ICs should be (also consider how many workers an IC is using?)
Find a better metric to scale the pods giantswarm/giantswarm#10163


Adding more validation for fuzzy queries

Description
Building on #5805. After checking back on my previous PR for Fuzziness, I noticed that negative values (both integers and floats) were not validated correctly (as per the official documentation, only positive values are allowed. Floating point values kept in for this test). I've added a negative value check for both integers and floats in Fuzziness.java and included some values in the unit tests to reflect the changes.
Sample behavior:
$ curl -XGET 'http://localhost:9200/_search?pretty' -d '{"query":{"match_bool_prefix":{"date":{"query":"1972-07-04 00:00:00", "fuzziness":"-10.0"}}}}' -H 'Content-Type: application/json'
{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "Invalid fuzziness value: -10.0"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "Invalid fuzziness value: -10.0"
  },
  "status" : 400
}

Issues Resolved
#4223 #5805
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta could these changes be merged in before code freeze? Don't think the failures from gradlew check is from this

@reta could these changes be merged in before code freeze? Don't think the failures from gradlew check is from this

Sure, we just need to have a clean Gradle check

Codecov Report

Merging #7154 (2050161) into main (ab54c38) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #7154      +/-   ##
============================================
- Coverage     70.60%   70.60%   -0.01%
+ Complexity    59514    59501      -13
============================================
  Files          4859     4859
  Lines        285485   285489       +4
  Branches      41141    41143       +2
============================================
- Hits         201567   201561       -6
- Misses        67352    67361       +9
- Partials      16566    16567       +1

Impacted Files
Coverage Δ

...ain/java/org/opensearch/common/unit/Fuzziness.java
81.73% <0.00%> (-3.27%)
:arrow_down:

... and 425 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sejli please ignore the backports to 1.x and 1.3, I thought we backported original enhancements there but we weren't


Addition of booleans is currently wrong in iree-compile

Addition of booleans is performing xor which breaks causal mapping.

Upstream fix here: https://github.com/llvm/torch-mlir/pull/3820


Invalid initializer shader compile error

I've been converting several GLSL shaders to Godot and hit a few strange errors that change if I move code around.  Here is one I was able to replicate in a concise example.  If the foobar function simply exists in the file it causes the unrelated test function to cause a compile error.  Also just swapping the order of foobar and test makes it work ok.   Very difficult to debug and trace these errors down but I'll try to submit other examples as I can.  I can send a zip of this test case as a project by email if desired.
I'm using 1.1 Stable under windows 7 64 bit.
// Uncomment the following and the shader fails to compile with error:
// "error(1,0): Invalid initializer for variable: testR"
// Also if test is defined before foobar it *will* work ok
/*
float foobar(vec2 co){
    return 1.0;
}
*/

vec2 test(vec2 p)
{
	return p;
}

vec2 testR = test(UV);
COLOR = color(testR, 0.0, 1.0);

Here is another... these are not fun to isolate.  Hopefully these two examples will help pinpoint the problem.

vec3 test_3(vec3 x) {
  return vec3(0.0);
}
// Commenting out test_2 makes it work, with test_2 present it fails with:
// "error(1,0): Invalid initializer for variable: n"
vec2 test_2(vec2 x) {
  return vec2(0.0);
}

float test(vec2 v)
{
	return .5;
}

float n = test(UV);
COLOR = color(n);
COLOR.a = 1.0;

This is a bug due to broken logic within validate_function_call(....) in
shader_language.cpp: Line 1373
As the parser identifies a function only by its arguments types but not its name.
So if you have a function that is
type1 func1 (arg1, arg2 ... argN)
type2 func2 (arg1, arg2 ... argN)
a statement such as
type2 test = func2(arg1...argN)
will be validated using func1, resulting in its return cache being of type1 instead of type2.
Fix this in shader_language.cpp Line 1373 by changing from
if (!fail)  to if (!fail && name == program->functions[i].name)

Thanks for the debugging! Could you make a pull request with your proposed fix?

Done.

Fixed by #2926.


Support configuration of cache-control max-age

Hi,
as of this writing, ghost doesn't seem to support customizing the cache control headers.
It would be great if I could configure that somehow, just in config.js would be fine. This is especially useful since / and the individual posts set max-age=0, which always requires revalidation and might completely disable caching (at least cloudflare with default settings).

This is an interesting proposition, we're currently in the middle of entirely refactoring and then auditing Ghost's configuration, and so it's a good time to propose changes.
I am not sure that a generic max-age config is enough, do you have an idea what configuration options you wanted/needed?

Yes, more sophisticated cache settings would probably make sense. I'm personally most interested in cache settings for the dynamic, non-admin content like / and posts. Right now I setup some rules in CloudFlare to apply cache settings on a per path basis.

Could you be a bit more specific, maybe share the CloudFlare rules you're using?

I simply set 2h TTL for everything except /ghost/*

I've added this as an item for review in #7488. Going to close this as we don't need both issues open for the same task. It will be reviewed before the end of the alpha phase.

FWIW, we should think about setting no-cache on 4xx and 5xx range responses - we don't want edge caches storing these. At the very least, fine grained control might be in order.

I'd also like to be able to set the Cache-Control header max-age that comes back on static assets. It currently seems to be hardcoded at 31536000one year from Express.
I purpose this should be a configuration option in config.js.
cache: {
    # this would modify the header to Cache-Control: public, max-age=3600
    maxAge: 3600
}

See my pull-request https://github.com/TryGhost/Ghost/pull/7916


Add support for refutation cases added in 4.03.

        type _ t =
          | Int : int t
          | Bool : bool t

        let deep : (char t * int) option -> char = function
          | None -> 'c'
          | _ -> .

Notice the dot in the last branch. That is valid source code and helpful with GADTs.

See also #1350

Ah, mine is a dupe then, thanks for reporting!


Text Format Broken in Intel(R) Iris(R) Xe Graphics

Version

Phaser Version: 3.60.0

Operating system: Windows 10

Browser: Chrome 112

Description
When text is getting loaded on the Chrome 112 version windows 10 machine, text is broken, Graphis driver used is Intel(R) Iris(R) Xe Graphics. and the same this is working in Other machine which has different Graphics Driver Installed  Intel(R) UHD Graphics 620.
As You can see the Below text 39 and 25 are not render clearly, text is broken
Example Test Code
Phaser Configuration
static config = {
type: Phaser.CANVAS,
scale: {
mode: Phaser.Scale.FIT,
autoCenter: Phaser.Scale.CENTER_BOTH,
parent: "game",
width: 1920,
height: 1080,
},
dom: { createContainer: true },
physics: {
default: "arcade",
arcade: {
// debug: true
},
},
scene: [LandingPage, MainScene, SaveScore, ShowScore],
};
Additional Information

Sorry, but I'm going to close this issue. I don't believe it's anything we have any control over, as we literally use the Canvas API to draw text. This sounds like a hardware driver issue.


[FEATURE] Dataset Builders

🚨🚨 Feature Request

[ ] Related to an existing Issue
[x] A new implementation (Improvement, Extension)

A "Dataset Builder" for fetching and pushing datasets to Hub, in a standardized manner. It would be responsible for tasks such as:

verifying Hub credentials
downloading a dataset from a given url (streaming for larger files, perhaps with urllib.FancyURLopener)
logging metadata (date created, source url, user, etc.)
checksum (when available, since not all datasets come with checksum)
untar
pushing to a given Hub repo with the appropriate arguments (eg public=False)

If your feature will improve HUB
By standardizing downloads, Hub can programmatically fetch updated versions of datasets. For example, the CORD-19 dataset is updated daily and we would like to continuously fetch the latest version.
Description of the possible solution
It could mimic Tensorflow's DatasetBuilder, which knows where to download data from and how to extract it and write it to a standard format.

Closing this feature request due to inactivity and lack of interest. Will revive it if more users request it.


New random API for integers

Description
Implement a new random API that should have the following name pattern: randomType() where Type is an explicit type.
Here is an example:
val x: NonZeroInt = randomNonZeroInt()

Deprecate the old API.

Checklist

[x] Implement it for the NonZeroInt type.
[x] Implement it for the PositiveInt type.
[x] Implement it for the StrictlyPositiveInt type.
[x] Implement it for the NegativeInt type.
[x] Implement it for the StrictlyNegativeInt type.
[x] Refactor code.
[x] Update Work in progress section in changelog.

Done.


How to disable the current date selection on calendar open?

In single mode, when I click an input and trigger the calendar open, the current date is always selected on default if the input value is empty.
Is there a way to disable this feature, and make the input value remain empty until the user select one?

Yes, you can do this by setting an empty object as the default value.
 const [date, setDate] = useState({});

 return (
   <DatePicker
     value={date}
     onChange={(date) => {
       setDate(date || {});
     }}
   />
 );

https://codesandbox.io/s/beautiful-tesla-sgrnx?file=/src/App.js:119-281

Worked like a charm!! Thank you very much.


Add gradle support

Well, this PR should be from @Morlunk in fact…
it adds gradle support so that we may add this module to any Android Studio project (it uses gradle as default backend).
Already in use for orWall project, works nicely.

Hmpf, I did a PR doing part of this back in May 2014 - without removing jars - and it got ignored. I have prepared the PR again but I don't see the point in posting it again.

ping @n8fr8  to get this merged.

I think we just merged a simpler solution from @SamWhited


unable to start two rs2::pipeline for two d435 cameras

Required Info

Camera Model
D435x2

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04

Kernel Version (Linux Only)
4.15.0-88-generic

Platform
Nuc

SDK Version
2.32.1

Language
C++

Segment
ROS2

I am trying to launch two d435 cameras in two seperate ros2 nodes. I launch each of these nodes from the command line several seconds apart.
Consistently, the second launched node will always crash with the message
[realsense_node-1] terminate called after throwing an instance of 'rs2::backend_error'
[realsense_node-1]   what():  xioctl(VIDIOC_S_FMT) failed Last Error: Device or resource busy

I looked at the core dump for the crash, and the exception occurs here when starting the second pipeline:
#7  0x00007fc77dd76137 in rs2::pipeline::start<rs2::frame_queue> (this=0x7fc73c00ab58, config=..., callback=...) at /usr/local/include/librealsense2/hpp/rs_pipeline.hpp:477

This crash does not occur when using a d435 and d435i, only when using two d435.
This crash does not occur when viewing both d435 through realsense-viewer, or when using ros1 nodes. I looked at the ros1 source for a second, and it appears it is not using a pipeline.
Why is the second d435 pipeline consistently crashing?
The ros2 crash is reported here: https://github.com/intel/ros2_intel_realsense/issues/113

device enable was missing:
  auto sn = dev_.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER);
  cfg_.enable_device(sn);

fixed with https://github.com/intel/ros2_intel_realsense/pull/115


Support Alertmanager with TLS Auth?

Dear all,
I have many Alertmanager and somes with TLS auth.
Is it possible to use a client cert in Unsee to scrape alerts?
Regards

Same as with #182, this would make configuration too complex to expres it with env variables. I need to switch to a config file before it can be implemented.

Raised a PR for that, will likely need some work before merging


fix: Deprecate Physical Bills on services and unit tests

Description
copilot:summary
copilot:poem
Walkthrough
copilot:walkthrough
Clickup
Please add link here
https://app.clickup.com/t/86cvbhh5x
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes

merged with FYLE-86cvbhh5x-2


could alertmanager send alerts to different people according to different conditions?

could alertmanager send alerts to different people according to different conditions?

You can route different alerts (or the same alert with different values / labels)  to different people using alerting routes. have a look at the configuration example at https://prometheus.io/docs/alerting/configuration/#example.

thx


Integrate requirements properly for independent install

Still relying on the icenet-pipeline requirements / conda setup for installation of the necessary requirements, but this needs to be stated/sorted within the icenet package itself.
Backport these changes

Using this to catch a minimal build for basic functionality that is useful for docker builds: get rid of extreme dependencies like tensorflow and cartopy by making them optional. Ensure this is reflected in the icenet README #156

@JimCircadian Has this been covered via the requirements file in the latest releases?

Yes, closing for the moment as icenet is successfully deployed in various situations without the conda environment being required


Readme.md

The readme needs to be updated and connect it to the project so it becomes usable

Yes @Marshud i will work upon it but at first i would like to updates you guys about HkmCode installer in windows that am soon about to finish developing it so that i work in Readme file