[Refactor] Preventing Unnecessary Object Creation and Using Utility Methods

What's changed?

Improved readability by preventing unnecessary object creation and utilizing utility methods.
Translated from Chinese to English.

The translation work is not yet complete.

Checklist

[ ]  I have read the Contributing Guide
[ ]  I have written the necessary doc or comment.
[ ]  I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/nginx/NginxCollectImpl.java:56:8: Unused import - org.springframework.util.ObjectUtils. [UnusedImports]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/nginx/NginxCollectImpl.java:56:8: Unused import: org.springframework.util.ObjectUtils. [UnusedImports]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/http/SslCertificateCollectImpl.java:44:1: Extra separation in import group before 'com.fasterxml.jackson.core.format.DataFormatDetector' [ImportOrder]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/http/SslCertificateCollectImpl.java:44:1: Import com.fasterxml.jackson.core.format.DataFormatDetector appears after other imports that it should precede [ImportOrder]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/http/SslCertificateCollectImpl.java:44:8: Unused import - com.fasterxml.jackson.core.format.DataFormatDetector. [UnusedImports]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/http/SslCertificateCollectImpl.java:44:8: Unused import: com.fasterxml.jackson.core.format.DataFormatDetector. [UnusedImports]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/dns/DnsCollectImpl.java:28:1: Extra separation in import group before 'org.apache.commons.collections4.CollectionUtils' [ImportOrder]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/dns/DnsCollectImpl.java:50:1: Extra separation in import group before 'com.google.common.collect.Lists' [ImportOrder]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/dns/DnsCollectImpl.java:50:1: Import com.google.common.collect.Lists appears after other imports that it should precede [ImportOrder]
Error:  /home/runner/work/hertzbeat/hertzbeat/collector/src/main/java/org/apache/hertzbeat/collector/collect/dns/DnsCollectImpl.java:53:1: Extra separation in import group before 'lombok.AllArgsConstructor' [ImportOrder]

Still something wrong.

Still something wrong.

OMG........... sorry 😢
I'll fix it as soon as possible.....................

Still something wrong.

OMG........... sorry 😢
I'll fix it as soon as possible.....................

Don't worry about it.

@dukbong Hi, I checked the new checkstyle file and found that the import now needs to be sorted alphabetically by package name, I just tested it locally and it worked, but I can't push it to your repository, I hope this helps!

You can run it locally.

Thanks a lot for the help, but I'm currently working without my laptop, so I can't really apply your suggestions properly. 😭😭😭
If my commits end up causing issues with the open-source management, please let me know!
I don't want to break the code base!!!!!!
If that's the case, I'll sit tight until I get home and fix it properly following your advice! 🏃

That's fine. Submit it at your convenience.

@zqr10159 Thanks a lot for the help, but I'm currently working without my laptop, so I can't really apply your suggestions properly. 😭😭😭 If my commits end up causing issues with the open-source management, please let me know! I don't want to break the code base!!!!!! If that's the case, I'll sit tight until I get home and fix it properly following your advice! 🏃

That's fine. Submit it at your convenience.

@dukbong
Refer to this link to install the plugin in IDEA to fix checkstyle problems more conveniently.

You can also run maven's checkstyle plugin directly to check.


AZ-204_lab_10.md

English:
In the Main method, add the following code to initialize
client of type ServiceBusClient
that will provideconnectivity to the Service Bus namespace and sender
that will be responsible for sending messages:
Current Translation:
在 Main 方法中，新增下列程式碼，初始化 ServiceBusClient 類型的 用戶端，提供連線至服務匯流排命名空間，以
及負責傳送訊息的 傳送者
Suggested Translation:
在 Main 方法中，新增下列程式碼，初始化 ServiceBusClient 類型的 client，提供連線至服務匯流排命名空間，以
及負責傳送訊息的 sender
Description:
They should keep English according to the context. Global check

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result ICMS QUERY


Adding All Possible Palindromic Partition

Program goes through every substring starting from first character, checks if it is palindrome. If yes, then add the substring to solution and recur for remaining part.
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python

@Ayush7614 pls assign me this issue.


Migration to Microsoft.App@2022-01-01-preview Resource Provider

This Pull Request is to complete the migration to the new ContainerApp Resource Provider started in PR#17. This is required for all ContainerApp applications as laid out here - https://github.com/microsoft/azure-container-apps/issues/109

The previous pull request had issues because it could not be end-to-end tested. This PR has been tested in my Azure subscription and provisions fully in US East2.
Dapr Components are defined in modules/dapr-components and scoped to just the required ContainerApps.
kubeEnvironment has been migrated to managedEnvironments
Each ContainerApp had been updated to the new namespace and updated dapr configuration.
The deploy.sh script has been updated to include the required extensions to the az cli and registers the Microsoft.App namespace.
The Readme.md has been updated with the required manual steps if the deploy.sh script is not used.

Hey @briandenicola, thanks for your PR! We just finished testing and pushed #17 and it looks like there are some conflicts now with your branch. Mind resolving so I can view a diff of your changes better?

Hey @briandenicola, thanks for your PR! We just finished testing and pushed #17 and it looks like there are some conflicts now with your branch. Mind resolving so I can view a diff of your changes better?

Also curious what you mean by this point as I tested out the PR today e2e and it was working :)

The previous pull request had issues because it could not be end-to-end tested. This PR has been tested in my Azure subscription and provisions fully in US East2.

This pull request can be close. The merge conflict are basically redundant at this point.

Also curious what you mean by this point as I tested out the PR today e2e and it was working :)

The previous pull request had issues because it could not be end-to-end tested. This PR has been tested in my Azure subscription and provisions fully in US East2.

I was referencing the first couple bullets in the initial pull request that the author made when they made the pull around not being able to test daprComponents. It's all good and I'm happy to see their updates merged in.


iOS drag and drop, on-demand CM plugins

So, this is not an issue but more a feature request.
I looked at your code and I like it. Started to youe droppy heavily and would like to get to know you...
I use my iPad heavily too, but there is still many shortcomings. I guess you are able to quickly overcome many of them in few extra effort ;)
One is copy and paste. A rally nasty thing not at all working on iPad.
Do you know this work?
https://github.com/schanzer/CodeMirror/blob/master/demo/iOS.html
Droppy is wonderful on mobile browsers. What an enhancement these tiny features would bring to droppy :)
I also love tern server, but the CM tern addon is not really perfect for the droppy Ressource management. I stopped trying it, when I got "tern.Server" not defined. This happens due to your interesting way of script concatenation...
Please take my highest respect for your wonderful work.
I hope my 2 cents might inspire you additionally...
<EMAIL_ADDRESS>

I'm not interested in adding IOS specificy hacks at this point, and will support Firefox and Chrome on Android, so really not much to do here. CM plugins are on my TODO list though.


TypeError: withNativewind is not a function with expo

Describe the bug
When following the instructions on:
https://next.nativewind.dev/quick-starts/expo
When running the expo start command I get the following error:
TypeError: withNativewind is not a function     at Object.<anonymous> (/Users/x/Documents/GitHub/app/metro.config.js:5:18)     at Module._compile (node:internal/modules/cjs/loader:1256:14)     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)     at Module.load (node:internal/modules/cjs/loader:1119:32)     at Module._load (node:internal/modules/cjs/loader:960:12)     at Module.require (node:internal/modules/cjs/loader:1143:19)     at require (node:internal/modules/cjs/helpers:110:18)     at module.exports (/Users/x/Documents/GitHub/app/node_modules/import-fresh/index.js:28:9)     at loadJs (/Users/x/Documents/GitHub/app/node_modules/cosmiconfig/dist/loaders.js:9:18)     at Explorer.loadFileContent (/Users/x/Documents/GitHub/app/node_modules/cosmiconfig/dist/createExplorer.js:230:12)
To Reproduce
Steps to reproduce the behavior:
Follow the install instructions in the link above.  Versions:
Nativewind: 4.0.0-alpha.7
Tailwind: 3.3.3
Expo SDK: 49.0.11
React Native:  0.72.5
Expected behavior
Should be able to start the expo app and have nativewind running.

You can find the docs for v4 alpha here: https://www.nativewind.dev/v4/getting-started/metro

hey, @mstronge, the next documentation refers to v3, which has been abandoned in favor of v4.  You can read about the change here..
The v4 documentation is here and an expo example here. The example works pretty well for 4.0.0-alpha.4, but does not appear to work with 4.0.0-alpha.5-7.
Note: V4 / main is actively being developed, with weekly commits, so just be aware that the 4.0.0 releases are clearly alpha, and may have issues.
@marklawlor, is that correct?  Perhaps, with v4 merged into main and ongoing development on main, it might be worth updating the Readme, or stickying an issue with clarification about versions and documentation, and what people should or should not be using?

That's a way better link to the v4 documentation, @daannet, thank you. Out of curiosity, were you able to get 4.0.0-alpha.5-7 working?

v4 docs are here https://www.nativewind.dev/v4/overview/


Add theme github.com/willfaught/paige

It looks like there wasn't a newline at the end, which vim added.

error: image "images/tn.png" not found in "github.com/willfaught/paige"

I don't understand. images/tn.png exists.

I forgot to tag the latest commit.

Fixed readme screenshot link.

Ready to rock and roll!


mufft benchmark problem

Recently, I had tried to incorporate mufft into our project. Unfortunately, we found, if we disable sse or avx, mufft is much slower than other fft implements such as kiss fft, small fft etc.
For our test samples, benchmark result will like below:
release version (ms):
kiss fft: 1461
small fft: 1447
mufft with disabled sse :1735
mufft with sse3: 1234
both kill fft and small fft don't have been optimized by sse.
Do you do the same benchmark?

The problem is I do the benchmark using debug mode. Switching to release mode, with neon support, mufft is fast than kiss fft for about 10%.


Add /ub command for beginners channel

This came after much serious bikeshedding in #rust-beginners; there is a surprising amount of people learning rust who would like to try to use fun unsafe features like static mut when they are rarely the correct choice.
Mostly for goofs, this PR adds the ability to track the last time each particular brand of UB is invoked by new users. Currently supported types are static mut and transmute.
This does store timestamps and metadata in the SQLite db, but the storage impact should low given that it stores at most 1 row per type of UB, currently 2.

Lol
Context: https://discord.com/channels/273534239310479360/273541522815713281/1034263841145638942


⚠ Bofrost.com has degraded performance

In 2854ca6, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 976 ms

Resolved: Bofrost.com performance has improved in 12dbd28 after 6 minutes.


[FLINK-24234][connectors] FLIP-171: Adding Time & Byte Size Based Flushing to Async Sink Writer

What is the purpose of the change
User stories:

As a Sink user, I’d like to configure the batch size for items to send to the destination at once (e.g. “flush if there are x number of items in the batch”)
As a Sink user, I’d like to configure the batching logic so that I can flush the batch of requests based on time period (e.g. “flush every 2 seconds”)
As a Sink user I’d like to specify the number of bytes for the batch of requests to be flushed (e.g. ”submit the batch after the total number of bytes in it is above 1KB”)
As a Sink developer, I’d like to use the configuration mechanism provided to allow Sink users to configure my Sink implementation

Context:
The AsyncSinkWriter currently has a static batch size. We’d like to allow Sink users to specify what batch size they would like to use as they are in a better place to choose a batching logic/size for their needs. We’d like to also allow Sink developers to make use of the provided configuration mechanism for their Sink implementations.
Scope:

Allow Sink developers and users to pass batch size config to the AsyncSinkWriter
Add support for time-based flushing (e.g. “flush after x miliseconds”) using the ProcessingTimeService which is part of the Sink interface
Add support for byte-based flushing
Consider the combination of time-based flushing and byte-based flushing, if there are more bytes than configured in the time-based batch, then the last few (however many necessary) items should go in the next batch to satisfy the requirement for the number of bytes.

Brief change log

Added byte based flushing to Async Sink Writer
Added time based flushing to Async Sink Writer

Verifying this change
This change added tests and can be verified as follows:

Added integration tests for successful/unsuccessful persistence of data in barebones implementation of the generic sink
Added unit tests for added code

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): yes
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? JavaDocs

@dannycranmer Thanks for your comment a little earlier about concurrency and thread interleaving.

I have added 2 additional tests to cover situations where a timer triggers a flush while another is in flight. To give us confidence in thread interleaving behaviour and to alert users allowing a non mailbox thread into the class.
I can also confirm that for the 4 public methods and other callback methods (MailboxExecutor and ProcessingTimeService), the only thread that may enter any of these is the mailbox thread. Maybe with the exception of snapshotState() which is read-only.

Longest unit test: 500ms
Longest integration test: 3500ms

Update at 20210914 1905
Rebased atop apache/flink/master:HEAD, tests pass
Waiting on Azure tests on latest force push 3a3f7cb

@dannycranmer Azure tests succeeded. Ready for further review & comments :-)

Rebased atop apache/flink/master:HEAD, tests pass
Waiting on Azure tests on latest force push 7d4fde
🙈🙈


DNM - Testing downgrade libvirt

Depends-On: https://github.com/openstack-k8s-operators/edpm-ansible/pull/558

recheck

recheck

recheck

recheck

recheck

recheck

@arxcruz Hello, Do we still need this pr, if not can we close it?


git describe in repo with no tags produces fatal error message

https://github.com/terrapower/armi/blob/72dd0724278a31fe7b843a1e56db1c7f8ac04f60/armi/bookkeeping/db/database3.py#L638
can produce an ominous message if running in a repository that doesn't have any tags
fatal: No names found, cannot describe anything.

This can be demonstrated with
$ git init simple
$ cd simple
$ git describe
fatal: No names found, cannot describe anything.

Fix appears to be piping stderr to /dev/null like
https://github.com/terrapower/armi/blob/72dd0724278a31fe7b843a1e56db1c7f8ac04f60/armi/bookkeeping/db/database3.py#L631-L632

We have 8 tags in the repo, currently:  https://github.com/terrapower/armi/tags

Oh my apologies. Tags in the repo are not the issue. If I am running an ARMI run in another repository that doesn't not have tags, then this issue appears

I have a fix for this. Incoming.


config: Get mediaTypes config in line with the Hugo version

This gets rid of the big WARNING when building.
Note that this is only Netlify related, so it is backwards compatible.

/lgtm
/approve


Manjaro popped up during PINE64 discussion

This blog post is worth a read (and perhaps inclusion to the readme):
https://blog.brixit.nl/why-i-left-pine64/

We could probably include it under the heading "Unfair monopolization of the Pinephone ecosystem". However, I'm not sure if we should. This repository was initially created for desktop users and is not directly related. Furthermore, this is a deeply personal record of the developer, which I am unsure if I should quote without their consent.
I'll close this issue for now. Please feel free to reopen this issue if you find more information or if you want to make a PR related to this issue, summarizing this issue and referencing the link in the README.


Loading in Individual Datasets within a Package

Is it possible to load in individual datasets within a package? For example:

library(rpart)
data(car90)

But this doesn't work, even though there is a specific AUP444_bama dataset:

library(AUP444)
data(AUP444_bama)
Warning message:
In data(AUP444_bama) : data set ‘AUP444_bama’ not found

With projects now containing many datasets from multiple assay types, it would be nice to be able to only load in specific datasets.

I like the idea. I could alter the saving of data to allow loading data sets separately, and provide a load_all_datasets(“packageName”) command to load all the data from a package.
From:  Jimmy Fulp
Reply-To:  RGLab/preprocessData
Date:  Wednesday, September 2, 2015 at 2:03 PM
To:  RGLab/preprocessData
Subject:  [preprocessData] Loading in Individual Datasets within a Package (#7)
Is it possible to load in individual datasets within a package? For example:
library(rpart)
data(car90)
But this doesn't work, even though there is a specific AUP444_bama dataset:
library(AUP444)
data(AUP444_bama)
Warning message:
In data(AUP444_bama) : data set ‘AUP444_bama’ not found
With projects now containing many datasets from multiple assay types, it would be nice to be able to only load in specific datasets.
—
Reply to this email directly or view it on GitHub.

When converting from a previous version of a package (where all data sets were stored in one rda file) you'll need to manually remove the old "all in one" rda file prior to regenerating the package.

This is implemented in commit 6a00a and fixes the problems in issue #8


Cannot share projects on Chromebooks

Expected Behavior
When you try to share a project by clicking the 'share by email' button you should see a share sheet to select the application you would like to use to share the project. The share sheet should include email, files and drive if available.
Actual Behavior
A message appears at the top of the screen that "No apps can perform this action"
Steps to Reproduce
Device and Operating System
HP x2 Chromebook

Hi @chrisgarrity , I guess the intent type which is wrongly set that causes the issue, could you please give it a shot that change the file JavaScriptDirectInterface.java on line 656 from it.setType(mimetype); to it.setType("message/rfc822");?
But you said this does not appear to be an issue using the old version, so it is maybe also not relevant. If this doesn't work, I will try to get a chromebook or setup a test environment first.
Thanks.

@yueyuzhao that's definitely in the right vicinity. Instead of "No apps..." it opens Chrome with a Gmail compose message. Unfortunately the connection between the Android app running on Chrome and Gmail in the browser loses the attached file (this has always been true). So instead of explicitly opening an email mimetype we need one that will pop open the normal Android share sheet and include options like gmail, drive, files etc.

@yueyuzhao I started to try to figure out where the change was introduced. However I ended up with inconsistent results when installing the app on a couple of Chromebooks I have at home. On one of the Chromebooks I installed the new internal test version of ScratchJr (1.2.12), and I got the problem when trying to export. Then I noticed it needed to restart to update Chrome. After the restart, exporting in the internal test version works fine. The other Chromebook I have is running in developer mode, and it still has the problem with no apps being found.
In the end I think we should wait to see if this appears on other normal Chromebooks - I have some internal testing with other Scratch Team members scheduled. If they don't see the problem I'll close this issue.

Hi @chrisgarrity , thank you for trying out and sorry for this not working attempt. FYI, I got this "No apps ...." message once because I didn't set up the email account in the email app, I can do it normally after the set up.
Also I can still share the project as attachment after change the intent type to "message/rfc822" on my Android tablets.
One question is on iOS if the user want share the project to computer or to files, he/she needs to click the Airdrop button, and when clicking the email button, the user can share the project only via Email. Why don't we implement the same strategy on Android if we need the user to save the project to drive or files?

@yueyuzhao sorry for the false alarm! I had powerwashed the chromebook recently and none of the Android versions of the apps were installed. After I went to the play store and installed the Android versions of Gmail and Drive they showed up as options for export. We actually need to do a full refactor (design and implementation) of the export/import UI. So much has changed since it was implemented in 2015.

That's OK, anyway, Cheers!


test: 25 out of 100 finalizer are not called in tinyfin.go

Failed on windows-amd64-gce builder a few times recently: http://build.golang.org/log/1a2e106640beae06227ade2c6cef55bc7d0cf611
...
##### ../test
# go run run.go -- tinyfin.go
exit status 1
25 out of 100 finalizer are not called
panic: not all finalizers are called

goroutine 1 [running]:
main.main()
	C:/workdir/go/test/tinyfin.go:59 +0x29f
exit status 2

FAIL	tinyfin.go	1.074s

Alex

Yes, I've been seeing this too.
https://storage.googleapis.com/go-build-log/7f62c78e/windows-amd64-gce_97ebdf8d.log
Flaky test needs to be fixed or die. But I suspect it might be real, being GC-related?
/cc @aclements @RLH @dvyukov

This used to work, so looks like a regression.

The actual test appears not to be valid.  Perhaps Go should produce an
error while trying to do setFinalizer on an x that is not valid based on
the following restriction from the docs.
"The argument x must be a pointer to an object allocated by calling new or
by taking the address of a composite literal. "
On Sat, Oct 31, 2015 at 6:23 AM, Dmitry Vyukov<EMAIL_ADDRESS>wrote:

This used to work, so looks like a regression.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/13100#issuecomment-152720230.

@RLH Why?
We would need to associate a new bit of meta-information with each heap object just for the sake of this check. And runtime actually does not care how it was allocated. Am I missing something?
There are other such cases in std lib tests.
I think we need to refine the documentation. As far as I understand the intention was to say "beginning of an individual object".

@rsc

Here are the current failures on the dashboard:
2015-10-26T23:36:22-53d43cb/windows-amd64-gce
2015-10-27T03:48:21-00f4243/solaris-amd64-smartos
2015-10-28T19:51:05-72180c3/windows-amd64-gce
2015-10-29T21:12:08-a59a275/windows-amd64-gce
2015-11-01T04:45:37-3d5163c/windows-amd64-gce
Note that it has happened once on a non-Windows OS.
Looking at the commits before this started, d18167f "runtime: fix tiny allocator" seems like the likely culprit. However, this commit fixed the previously broken tiny allocator so that it actually reused tiny blocks rather than creating a new one for each allocation, so it most likely just revealed an existing bug.
All of these failures are exactly "25 out of 100 finalizer are not called," though note that 25 is the smallest number of not-run finalizers that this test will fail at. It's necessary to accept a few not-run finalizers because of combined tiny allocations, but I'm not sure where the 25 threshold came from. It may just be arbitrary. In the theoretical worst case, every allocation by the test could be combined with some other tiny allocation that's still live, and none of the finalizers will run.


nixos/vaultwarden: assert valid backupDir path

Description of changes
Since stateVersion 24.11 the data path of vaultwarden was changed to /var/lib/vaultwarden which breaks the backup test.
This PR adds an assertion to prevent this issue and fixes the backup test.
Introduced by https://github.com/NixOS/nixpkgs/pull/318933
See https://github.com/NixOS/nixpkgs/pull/325711#pullrequestreview-2165441208
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

But users can pick arbitrary subdirectories, as well as picking dataDir itself.

Then we should exlude that it is the same directory. Any arbitrary subdir should work though.

Then we should exlude that it is the same directory. Any arbitrary subdir should work though.

Doing it this way might introduce unwanted edge cases:

What if users choose /var/lib/vaultwarden/tmp/backups?
What if a future Vaultwarden version creates a new file/directory with the same name as a backup directory?

Additionally, this would make the backup script quite a bit more complex, as a simple "copy everything except *.db" expression would now include a conditional (Is the backup directory inside DATA_FOLDER?) and a variable (BACKUP_FOLDER, but without the DATA_FOLDER prefix). I would argue it would be more beneficial to keep the backup script simple (and reliable!) and just limit the scope of what backup locations are allowed.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4364

This breaks if backupsDir is not set.

Fix in #325861.


Version Availability Mismatch

Hi all
On the "Oasys Software Licensing Portal" where we can download updates to our software, the available version is only <IP_ADDRESS>
The latest GSA-Grasshopper requires 10.1.63.
Can you kindly ask whoever manages the licencing portal to update.

Hi @jjsolly
Apologies for that, there's an issue with SoftwareKey's Electronic Software Delivery (ESD) currently preventing us from uploading the latest version to the portal. I'll email you a direct link to 10.1.63.
Best, Kristjan

Thanks Kristjan!


[BEAM-972] Add unit tests to Gearpump runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @kennknowles
Hi, this is Huafeng from Gearpump team, I'm adding some unit tests to gearpump runner. Please help to review this pr.

Changes Unknown when pulling eb0d333df23624f54aae2abb8d7c7873f8ed2a7a on huafengw:addGPUT into ** on apache:gearpump-runner**.

Hi Huafeng! Thanks for contributing. I am on a little vacation but I I will take a look on Monday.

@kennknowles Thanks, any comment?

Thanks Kenn, I'll keep your advice in mind


Interleave test items in dvsim.py runs

If I've made a change to a testbench (or the design!), I'm going to want to run some tests to make sure I haven't broken it. So I'll run something like
path/to/dvsim.py some-cfg.hjson --reseed 50

Suppose that some-cfg.hjson defines 10 tests. Then this is going to be 500 simulations, which might take a while. At the moment, we run 50 iterations of test 1, then 50 iterations of test 2, etc.
If I've broken something, it's most likely to only break some tests. If I'm unlucky, I might have just broken test 10. Oh no! It would be more helpful when running at the terminal if the tests were interleaved.

@sriyerg: Does this seem reasonable to you? If so, I don't think it would be a difficult change in Deploy.py and I'll happily make the patch, but I wanted to run the idea past someone before doing the work.

Thinking about this, we might not be forcing all tests to run the same number of iterations with --reseed. Maybe it's most helpful just to randomise the dispatch queue. The same tests will be run as now, but they will finish in a (hopefully) more helpful order.

If by interleave, you mean 'dispatch the iteration 1 of all tests, followed by iteration 2 ...', as opposed to 'dispatch all iterations of test 1, followed by all iterations of test 2 ...', then I agree - it sounds like a good idea. I prefer it over a randomized queue.
I think the seed / reseed part need not be touched - IMO it is already WAI. Just need to reorder the dispatch_items.

I think that we have to be slightly more careful than "iteration 1 of everything; iteration 2 of everything". Suppose that there are 2 tests, A and B where A takes 10 times as long as B. Then the default configuration might run A 10 times and B 100 times. Ideally, we'd run ABBBBBBBBBBABBBBBBBBBB etc. Doing that right in general looked like it would take some thought, which is why I suggested randomising the order (which will usually approximate the interleaved schedule), but I think I can see how to do it properly. I'll try to push up a patch in the next couple of days.

Typically, on a change we want to see the full suite of tests run and pass at least for one iteration. So if A runs 5 times, B runs 10 times, it would look like this: ABABABABABBBBBB. It doesn't matter if A runs N times as long as B, we just need to ensure we prioritize on kicking off all unique tests first, so that we can get the feedback of the changes we made deterministically early.

I agree, and the PR I pushed achieves that. The 1st run for each test gets a "tag" of zero, so the sequence will look something like ABCBABBABCBABBABB. Note that the sequence starts with ABC. Maybe it would be better to have further discussion on the PR.

@rswarbrick one question.
if two tests have different build time dependencies - then you would need recompilation in between wouldn't you?

In the dvsim model, there is a single "build" phase that runs VCS/xcelium/whatever to build one or more tests (specified by test class & top-level sequence). Then there's a "run" phase, that runs the these tests with one or more random seeds.
Here, I'm talking about the order that we should run stuff that was generated by a single build, and arguing that we should interleave runs for different tests (i.e. test class/top-level sequence) rather than running all seeds for one test, then all seeds for the next etc.
PS: Gah! I wish there were more nouns available. It feels like "test" means way too many things.

@rswarbrick I agree TEST is used to widely here.
I think we could all be better as using the correct names.
what is typically called test in OpenTitan should be referred to as test sequence IMO.

@rswarbrick one question.
if two tests have different build time dependencies - then you would need recompilation in between wouldn't you?

Build time dependencies are set using build_mode key. If this key is not present, it uses the default build mode (which is the 'vanilla' build without any extra options). If a test needs specific build options, it needs to wrap it in a unique build_mode. See example below:
  // in aes_sim_cfg.hjson, for example
  build_modes: [
    {
      name: aes_foo
      // Set build-time switches
      build_opts: ["+define+foo=1", "+define+bar=2"]
      // Build mode can enable run-time switches as well
      run_opts: ["+foo=1", "+bar=2"]
    }
  ]

  tests: [
    ...
    {
      name: aes_foo_test
      uvm_test: aes_foo_test
      uvm_seq: aes_test_vseq
      build_mode: aes_foo
    }
  ]

When you specify tests that need to be run, dvsim will figure out how many builds are to be dispatched. Example: if you specify on the command line -i aes_sanity_test aes_foo_test, it will dispatch 2 builds in parallel, default and aes_foo first. As each build finishes, it will dispatch the runs that cater to it. So recompilation is not needed (since the compilation happens in parallel).

Fixed by PR #2400.


Log the tag and location

That would break backward compat. More keys should be already possible to add manually by the user, and it make sense, we could have a different function to adds more of them.


flaky test: test_split_region_with_no_valid_split_keys

--- TRY 3 STDERR:        tests::failpoints cases::test_split_region::test_split_region_with_no_valid_split_keys ---

thread 'cases::test_split_region::test_split_region_with_no_valid_split_keys' panicked at tests/failpoints/cases/test_split_region.rs:1530:45:

called `Result::unwrap()` on an `Err` value: Timeout

stack backtrace:

   0: rust_begin_unwind

             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/std/src/panicking.rs:645:5

   1: core::panicking::panic_fmt

             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/panicking.rs:72:14

   2: core::result::unwrap_failed

             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/result.rs:1649:5

   3: core::result::Result<T,E>::unwrap

   4: failpoints::cases::test_split_region::test_split_region_with_no_valid_split_keys

             at /home/jenkins/tikv-src/tests/failpoints/cases/test_split_region.rs:1530:5

   5: failpoints::cases::test_split_region::test_split_region_with_no_valid_split_keys::{{closure}}

             at /home/jenkins/tikv-src/tests/failpoints/cases/test_split_region.rs:1502:48

   6: core::ops::function::FnOnce::call_once

             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/ops/function.rs:250:5

   7: test_util::runner::run_test_with_hook::{{closure}}::{{closure}}

   8: core::ops::function::FnOnce::call_once{{vtable.shim}}

   9: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once

             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/alloc/src/boxed.rs:2015:9

note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Fpull_unit_test/detail/pull_unit_test/1485/pipeline/84/
This case has been captured as flaky in the last two weeks for more than 60 times.

https://github.com/tikv/tikv/pull/17919 hit this test failure as well.
I was able to reproduce this issue locally with a 1% probability (reproduced once in 100 runs). I can take a closer look at this.


License?

As someone coming from the UE4 world, this looks like a great plugin! But it does feel like GPL isn't really compatible with releasing commercial games unless you also release the game itself's source code as open source, right? Is that your intention or am I perhaps misunderstanding how that works?

Ok! Well, I will change the license for MIT for the next version, I don't want to add a new version "just" for this, but it will be done!

Done in the latest commit, it will be edited on the Godot asset store once the new version is totally ready, need to do some testing here and there (The new version has the collection system implemented, so I want to re-check all the plugin feature before publishing it)
I will close this issue once the Godot Asset Store is edited! :)
Commits:
Update for github:
https://github.com/Ward727a/godot_datatable_plugin/commit/253f330ab20a75e67bc582f942147d7d01be882b
https://github.com/Ward727a/godot_datatable_plugin/commit/b7d8b2e8461d364feef0d53ac36d7545a4ae37e6
Update inside addon folder:
https://github.com/Ward727a/godot_datatable_plugin/commit/a2d243c27d74e79c1f0227191cbba36ae8c93e7b
https://github.com/Ward727a/godot_datatable_plugin/commit/641898dba20cddbc6fef90c21399011722ccbcf8

Amazing, thank you!!


add download by release channel route

This adds a new route where you can specify the release channel when downloading the latest version.
/download/:platform/latest/:channel

Thanks!


Reset scroll position of dropdown when opening and closing or typing

If the autocomplete is acting as a select, I think it should reset the scroll position of the select if you open and close it. At the moment it's retained - so if you open it, scroll down, close it, then open again, you get returned mid-scroll.
If we're trying to act in a similar way to selects, opening the autocomplete should be as if it's first opened.

Similarly, if auto-select is on and you type in the box, an item might get selected above the scroll, but it isn't visible - we should scroll to the top / scroll to the selected item (same thing?).

Hi, @nickcolley  where is answer. I am in a very difficult situation. I couldn't find the solution

Hi @tolgakurtulus, at the moment there is no solution for this, sorry.


IP Allocator allows conflicts between discoverySelected Istiod Tenants

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
As of #51576, kclient Indexers do not respect Dynamic Filters.  IP Allocator uses a dynamic filter to restrict istiod to watching only a subset of ServiceEntries (based on DiscoverySelector), and an index to track which Entries are using which addresses.  When a DiscoverySelector is used, IP Allocator may overreport conflicting ip address assignments.  It is not immediately clear what impact this would have on the function of the IP Allocator.
Version
1.23.x
1.24.x

Additional Information
No response

@ilrudie may be able to shed light on the impact of this bug.

Interesting. Is this more of a bug in how Indexers work?
In "normal" circumstances this seems like not a large issue since the namespaces which we should not discover typically won't have workloads using Istio so they are unlikely to have any service entries.
Where this will matter more is when using discovery selectors to run 2 entirely separate Istios in a single cluster I think. The istiods would step on each other for these instances but it would be odd and inconsistent. When there is a conflict inside one istiod the resolution might try to "fix" a service entry it doesn't own in another istiod's domain. This might be real strange too because it is likely to assign an IP which is in conflict, or will become in conflict later, in the other istiod which has its own independent tracking of which IPs are in use! In the end it's probably not a catastrophe but it's certainly annoying, incorrect and difficult to troubleshoot.


Class 'Subject' incorrectly extends base class 'Observable'.

Dear all,
besides problems with Opaque Token, this is my second issue when I start my Ionic App. I really don't have any more ideas how to solve this issue.
Complete message:
Class 'Subject' incorrectly extends base class 'Observable'. Types of property 'lift' are incompatible. Type '(operator: Operator<T, R>) => Observable' is not assignable to type '(operator: Operator<T, R>) => Observable'. Type 'Observable' is not assignable to type 'Observable'. Type 'T' is not assignable to type 'R'.
Error:
*/
| export declare class Subject extends Observable implements ISubscription {
  | observers: Observer[];
Enviroment:
Ionic Framework: 3.9.2
Ionic App Scripts: 3.1.8
Angular Core: 5.0.3
Angular Compiler CLI: 5.0.3
Node: 6.10.3
OS Platform: Windows 10
Navigator Platform: Win32
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Save this line this to a TypeScript file (test.ts):
import {Subject} from 'rxjs/Subject';
this solved my problem in angular2

I'm closing this issue as lacks of detail to investigate more. Please feel freely reopen / create new issue with suggested steps in https://github.com/ReactiveX/rxjs/issues/3281#issuecomment-362032012 .


Fix statusbar css

When a panel (with cover or reveal effect) is with a dark theme, the status bar overlay must be moved with the panel (or the view) to avoid an ugly effect: the panel has the top area with the same color of the status bar.

Sorry, but why? It cannot be common solution and may produce more problems/questions. Default/designed behavior supposed to change status-bar color with opened panel, not moving it. Check for example iOS native Facebook app, and the same is done in Kitchen Sink for example

Below the answer:

Fig.1: kitchen sink with default css
Fig.2: kitchen sink with default css and fixed statusbar color
Fig.3: kitchen sink with this PR

Sorry, i can't agree with this as it is highly depends on app design. What we have now is the most common and easiest to change/tweak way: to change background color or to add transform like in your example. Also there is an idea behind the current realization, if you have half white - half black statusbar background (like on fig 3) then status bar itself can be unreadable as it can be only white or black, so that is why it is easier to handle whole status bar. Actually what is on fig1 is fine, have you checked iOS Facebook app? It and many other native apps behave in the way of Fig1

Certainly the look and fell of the app is subjective and of course I full respect your point of view. Every designer/developer can easily customize her css app and it is not a big deal. I've proposed this PR because there is also an idea behind it. Typically when you open a side panel you need a menu item or a short view of some data (list of friends, etc.): this is not a continuous work status and the informations of the statusbar probably are irrelevant at moment. Probably is nice to see a more clear view without the statusbar (using the cordova plugin). In this case the full colored statusbar overlay is ugly.
Facebook is not an idol and its app is not the best app in the world! :-)
Try to see Jawbone UP (https://itunes.apple.com/it/app/up-by-jawbone/id916240764?mt=8&uo=4) and you can see a look and feel like Fig3.

I know Jawbone UP, they basically hide status bar when panel opened)). Probably we can make your proposed behavior optional, for example with additional class on status bar. I am just afraid that most of users/devs won't know what is happened with status bar and why it is moving, just trying to avoid such questions in future :D

I think that an additional css class is a simple solution :D

@mgesmundo if you could update this PR accordingly that would be great

@mgesmundo
You need to update your merge request (with the additional class)!
Otherwise it should be closed because of no reaction.

Sorry but now I'm too busy :-(

@mgesmundo Got time now? :D


Refine autoset

Reduces the number of database requests to get column metadata to just a single request for the life of the CRUDpanel in the session.
Allows optionally retrieving all of the database columns, not just fillable, including timestamps by adding a filtered = true attribute to setFromDb (I often need to display created_at and updated_at metadata in entity lists).
No breaking changes
All current tests pass

I am having a serious case of deja vu here - I'm sure I've seen this PR before 🤕

Hi @jonphipps ,
I'm sorry, but it looks like we're not going to merge this. I do want to thank you for taking the time to put together the PR, I really appreciate it, but in the meantime:

autoSet has been refactored to make less queries;
we've decided to move away from autoSet: discourage people from using it and instead generate CrudController files with fields&columns explicitly defined;

Again, thanks a lot for the PR, but I don't think we're going to merge this. The issue is closed but not locked, so other people can pile on if you think I'm wrong, and we can re-open it.
Cheers!


after quantization aware training, add operation of resdural block lack min/max value, why? anyone can help?

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):1.12/1.13
Python version:3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:9.2
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
after quantization aware training, when convert to tflite, Array slim_mobilenetv2/Add, which is an input to the Conv operator producing the output array slim_mobilenetv2/Conv_6/Relu6, is lacking min/max data, which is necessary for quantization. If accuracy matters, either target a non-quantized output format, or run quantized training with your model from a floating point checkpoint to change the input graph to contain min/max information. If you don't care about accuracy, you can pass --default_ranges_min= and --default_ranges_max= for easy experimentation.
Fatal Python error: Aborted
Describe the expected behavior
can't convert to tflite?There should have min/max value?
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

anyone can help?

The main reason is FakeQuant() ops are not placed everywhere needed. It was a known limitation with the old quantization rewriter and as a result we're working on a new keras based API. Stay tuned!
Meanwhile, please take a look at post-training integer quantization:
https://medium.com/tensorflow/tensorflow-model-optimization-toolkit-post-training-integer-quantization-b4964a1ea9ba
Feel free to open other issues if you run into problem with it. Thanks!


chore: add pre-test secret check

Companion to https://github.com/Kong/go-kong/pull/247.
This is a duplicate that demonstrates how this runs when the source is a fork.

Codecov Report
Base: 53.31% // Head: 40.06% // Decreases project coverage by -13.24% :warning:

Coverage data is based on head (83d3f9a) compared to base (3a619dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #246       +/-   ##
===========================================
- Coverage   53.31%   40.06%   -13.25%
===========================================
  Files          46       46
  Lines        4183     4183
===========================================
- Hits         2230     1676      -554
- Misses       1478     2204      +726
+ Partials      475      303      -172

Flag
Coverage Δ

2.1.4
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.2.2
40.06% <ø> (ø)

2.3.3
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.4.0
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.5.1
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.6.0
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.7.0
40.06% <ø> (ø)

<IP_ADDRESS>
?

2.8.0
40.06% <ø> (ø)

<IP_ADDRESS>
?

3.0.1
39.39% <ø> (ø)

<IP_ADDRESS>
?

3.1.0
39.39% <ø> (ø)

<IP_ADDRESS>
?

community
40.06% <ø> (ø)

enterprise
?

integration
40.06% <ø> (-13.25%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


🧹 Cleanup a few TODOs

How to categorize this PR?

/area dev-productivity
/kind cleanup
What this PR does / why we need it:

Drop deprecated core.gardener.cloud/apiserver-exposure label and handling, follow-up of https://github.com/gardener/gardener/pull/8062
Drop Bootstrapped condition cleanup in Seed status, follow-up of https://github.com/gardener/gardener/pull/8290
Drop deprecated ChartRenderer.Render and ChartApplier.{Apply,Delete} methods, follow-up of https://github.com/gardener/gardener/pull/8250
Drop legacy NetworkPolicy handling for extension shoot webhooks, follow-up of https://github.com/gardener/gardener/pull/8076

Release note:

The deprecated `core.gardener.cloud/apiserver-exposure` label and handling has been dropped.

The deprecated `ChartRenderer.Render` and `ChartApplier.{Apply,Delete}` methods have been dropped. Use `ChartRendere.RenderEmbeddedFS` and `ChartApplier.{Apply,Delete}FromEmbeddedFS` instead.

Before upgrading to this Gardener versions, you must make sure that the `Service`s of all registered provider extensions serving webhooks for the shoot cluster are annotated with ` networking.resources.gardener.cloud/from-all-webhook-targets-allowed-ports=[{"protocol":"TCP","port":<port>}]`, networking.resources.gardener.cloud/namespace-selectors=[{"matchLabels":{"gardener.cloud/role":"shoot"}}]`, and `networking.resources.gardener.cloud/pod-label-selector-namespace-alias=extensions`.

/approve


Memory usage has been higher

Memory usage has been higher And increasing.

Hi there @Hi-Rube, I appreciate that memory consumption is a serious concern, but there isn't enough information here for anyone to work out what's going on. There are many possibilities for what could be happening here:

the version of Ghost being used could be old or modified
the monitoring software could be interfering with the metrics (this has happened before)
the blog could be under high load (and therefore correctly using more memory)
the theme being used could be memory intensive
the garbage collection may not have run in the time monitored
there might be an issue with the version of node, or other software used in conjunction with Ghost
there might be an issue with your server
there might be a memory issue with Ghost

We need extensive and detailed information to rule out all of the things at the top of the list before we get as far as trying to debug a memory issue in Ghost itself. Therefore I'd suggest treating this as an environment issue until such time as there's information & evidence which points to a problem with Ghost, as we have had recent detailed reports that memory usage in Ghost is improving and stable.
For help with your environment, I recommend using the forum, slack or even stackoverflow.


Add Hints.md  exercises.

First of all, thanks so much for doing this! It's a huge amount of work. I'll do a review somewhere today.
By the way, usually, making pull requests as small as possible is adviced. In this case, having one PR per hints file would make it far easier for me to review things. Furthermore, having one big PR means that it will only get merged if everything in it is okay. If there is a typo in one hints file, the other hint files also won't be merged. With an individual PR per hints file, this wouldn't be a problem. It is more work for the one creating the PR's (you in this case), so there's the trade-off. For this PR, it's fine to leave it as is, just consider it some general advice (as I hope you'll be wanting to do more PR's :)).
Once again, thanks!

There are several files in the PR that should be removed:

.fake/build.fsx_204AE3C7.dll
.fake/build.fsx_204AE3C7_config.xml
.fake/build.fsx_204AE3C7_warnings.txt
.paket/paket.exe
paket-files/nunit/nunit-transforms/nunit3-junit/nunit3-junit.xslt

For this, you could simply delete the .fake, .paket and paket-files directories. My other review comments will follow.

Hi @ErikSchierboom! Thank you for your advice. This was my first time of doing this:) I will review your comments and make changes tonight. Sorry again for inconvenience.

@GalaDe Absolutely no problem! I myself have learned this the exact same way: having a maintainer explain why it is useful to have smaller commits. You should be very pleased with what you have done! I'm really happy with it.  Thank you again for your help! Looking forward to do some more fun stuff after my return!

@ErikSchierboom Great! Thank you!

@GalaDe It's merged! 🎉 Thanks a lot for the work, it is much appreciated.

Ehyyy:)))) Thank you again for your help!!!!!!!


add doi link to the referred publiction

The motivation for this PR was based on today's ITP bug #1079341 by Pierre
Gruet to Debian announcing his intent to package your implementation for this
Linux.  I presumed the link to the primary literature may be beneficial for
Debian's review process.  You can monitor the progress (at least once the
ticket is closed, for instance if the package eventually built is admitted)
here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079341


All entities listed in Entity Configuration include 'six' in the label name

Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/settings/entity-configs/configurator'
Browse all the entities listed on the component
Actual Results: All the entities include 'six' on the label and from the general tab the label name does not include 'six', including the entity getting called from the frontend/swagger

Expected behavior
Remove the 'six' from the list of the entities

Hi @Lukeybooi @James-Baloyi, please check this issue, there might be someone who forgot to remove the text when debugging. There's no where I can locate that 'six' from the endpoint

Related item
#1460

@hlayisanimazuze fixed and PRed


Training

@wrandall22 Here is the training branch which also does cookies. The training section is not fully implemented because it does not get completed training yet. However, the main training section is done, and since this makes the connection to the api work I figured I would go ahead a push it. I will create a new branch for completed training.

Good call. Updated.

Looks good to me.

One more update

I think this is better


Cannot load underlying module for 'SearchTextField'

Getting this issue when I try to import the module
Using Swift 3 on Xcode 9.1
Any help would be much appreciated!
Tried googling it but nothing seems to work

Fixed!
Just kept deleting the following:
"Pods" folder
Podfile.lock
Then running in terminal:
pod install
It didn't work the first couple times, but found somewhere online that sometimes it takes 4-5 cycles to get it to finally work.
That was a fun bug to work out lol


AVIF support in Wagtail

AVIF is a modern image format based on the AV1 video format. It has good browser support, notably with only Microsoft Edge missing (licensing issues?).
Adding it to Wagtail similarly to WebP support (#5092) would result in devs being able to convert images to AVIF via image renditions – and also I imagine allow uploading of AVIF files / support for resize operations on AVIF files.

As with WebP, the first step here would be AVIF support in Willow. This seems like it could be done relatively simply since Willow already includes pillow-heif – Python bindings for libheif, which (surprise!) includes a number of AV1 codecs for AVIF support.

Assigning this to @salty-ivy for the time being at least so we explore what’s involve 🚀

hey @thibaudcolas , I've been chatting to @salty-ivy about this, and he's dones some work into this already. We have a call on Friday to explorer what this work would entail, and one of us will update this issue with more in the next day or so.

https://docs.google.com/document/d/1u9F8Pw4TLGRBIwOt2Fofma3ER8yB9y2MEZ_-U3K9-Zg/edit
additional info about the approach is here In my proposal.

opened a PR https://github.com/wagtail/Willow/pull/115 for the willow support

Hey @salty-ivy
I ended up doing a bit of research about AVIF over the weekend, and I figured it might be useful adding some links that might be relevant for
This post is one of the best ones I have found for understanding the file size savings compared to png or jpeg.
https://jakearchibald.com/2020/avif-has-landed/
The short version is that in lossless mode (which would probably be what we would want to save them as) these take up more space than other lossless formats like png, but in renditions, as long as there is browse support, AVIF represents a significant saving.
The links above show avif files coming in around a quarter of the size of comparable photo jpegs, and for simpler illustrations it's typically half the size or better.
There seem to two main gotchas:

encoding is more computationally expensive when creating the files
decoding is also more computationally expensive in browsers (I wonder if we'd be able to see this in GMT...)

More below:
https://avif.io/blog/comparisons/avif-vs-png/

@mrchrisadams in our case, support for any given image format means:

CMS users being able to upload images in that format, and Wagtail serving those images as-is. In this case there is no re-encoding necessary.
Uploading in a format and generating renditions in the same format. Here, whether the renditions are lossless or not is up to the developer who set up the site.
Uploading in a format and generating renditions in another format. Same as above.

Encoding performance isn’t really a concern for us because it only happens once per AVIF rendition of the image – and renditions are heavily cached (effectively forever)
For decoding performance, that’s a concern, but from what I understood modern software decoders put AVIF within the same order of magnitude as WebP:

First chart of Contemplating Codec Comparisons
First chart of Image Coding Comparisons (note: by the AVIF team).

I think the main gotchas of AVIF compared to JPEG specifically is decoders currently expecting the full image data before starting, and the lack of progressive rendering.


Multiple instructions sheets for Treasure Hunt Resource.

Issue: When downloading the treasure hunt resource with instructions, there is an instruction page every second page.
Currently, the Treasure Hunt resource puts an instruction page in between each of the actual activity sheet.
This is an issue because we don't need that many instruction sheets and it would just waste paper for the teachers to print off all those extra instruction sheets.
This can be fixed by only having one instruction sheet at the beginning of the resource. If the teacher needs more instruction sheets, s/he can just print/photocopy multiple copies them separately.
Currently:

How it should be fixed:

@tah942 is investigating what is best in a classroom environment, either:

One sheet only
One sheet per student

This has been fixed in 4.1.0 as instructions are now written on every sheet.


Issues with local development

Hi,
I followed the step-by-step guide, and everything seems to work well in production.
But, when I want to work with a local version, it's getting tougher.
I also followed the guide, using Vercel and Stripe CLIs, but when I run npm run dev, I have this error showing up:
Error: either NEXT_PUBLIC_SUPABASE_URL and NEXT_PUBLIC_SUPABASE_ANON_KEY env variables or supabaseUrl and supabaseKey are required!
I double checked my env variables, my Supabase createClient() and everything seems to be good.
supabase-admin.ts
const supabaseAdmin = createClient<Database>(
  process.env.NEXT_PUBLIC_SUPABASE_URL || '',
  process.env.SUPABASE_SERVICE_ROLE_KEY || ''
);

Did you guys already have this issue and found a solution?
Thanks in advance!

You have to rename your .env.local.example file to .env.local


refactor: split light polyfill into light and medium

Split light polyfill into light and medium
Closes #516

:tada: This PR is included in version 3.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Open the current merge request with lab mr b

This is a work in progress.
The current code fails with the following error:
../../go/src/github.com/zaquestion/lab/cmd/mr_browse.go:46:17: unknown field 'SourceBranch' in struct literal of type "github.com/zaquestion/lab/vendor/github.com/xanzy/go-gitlab".ListProjectMergeRequestsOptions

There is indeed a ListProjectMergeRequestsOptions.SourceBranch here: https://github.com/xanzy/go-gitlab/blob/master/merge_requests.go#L262
Unfortunately, I have a different file in vi vendor/github.com/xanzy/go-gitlab/merge_requests.go...

Ok I fixed the problems I had but now travis failed. I guess I should update the tests.
@zaquestion How can I run the test locally?

Ok it fails locally:
$ make test
bash -c "trap 'trap - SIGINT SIGTERM ERR; mv testdata/.git testdata/test.git; rm coverage-* 2>&1 > /dev/null; exit 1' SIGINT SIGTERM ERR; /Applications/Xcode.app/Contents/Developer/usr/bin/make internal-test"
rm coverage-* 2>&1 > /dev/null || true
rm: coverage-*: No such file or directory
mv testdata/test.git testdata/.git
go test -coverprofile=coverage-main.out -covermode=count -coverpkg ./... -run= github.com/zaquestion/lab/cmd github.com/zaquestion/lab/internal/...
The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? The authenticity of host 'gitlab.com (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:HbW3g8zUjNSksFbqTiUWPWg2Bq1x8xdGUrliXFzSnUw.
Are you sure you want to continue connecting (yes/no)? ^C--- FAIL: Test_mrCmd (1.59s)
	root_test.go:72: ../testdata-2243430853747698137
    --- FAIL: Test_mrCmd/create (1.55s)
    	mr_test.go:34: POST https://gitlab.com/api/v4/projects/5694926/merge_requests: 409 {message: [Cannot Create: This merge request already exists: ["mr title"]]}
    		/diffs
    		PASS
    		coverage: 13.8% of statements in ./...

        Error Trace:    mr_test.go:35
    	Error:      	"POST https://gitlab.com/api/v4/projects/5694926/merge_requests: 409 {message: [Cannot Create: This merge request already exists: ["mr title"]]}
    	            	/diffs
    	            	PASS
    	            	coverage: 13.8% of statements in ./...
    	            	" does not contain "https://gitlab.com/lab-testing/test/merge_requests"
    	Test:       	Test_mrCmd/create
--- FAIL: Test_projectCreateCmd (1.01s)
	root_test.go:72: ../testdata-4018908385734095056
    --- FAIL: Test_projectCreateCmd/create (0.82s)
    	project_create_test.go:31: 2018/09/23 06:08:01 project_create.go:48: POST https://gitlab.com/api/v4/projects: 400 {message: {base: [PG::NotNullViolation: ERROR:  null value in column "approvals_before_merge" violates not-null constraint
    		DETAIL:  Failing row contains (8514392, testdata-4018908385734095056, testdata-4018908385734095056, , 2018-09-23 04:08:01.041227+00, 2018-09-23 04:08:01.041227+00, 1636476, 2002378, null, null, 10, f, null, null, 0, f, null, null, null, null, t, f, null, f, null, null, null, null, null, t, xji2xdxx7PukEsRxYrPo, null, t, 3600, f, t, f, null, null, t, f, null, nfs-file22, f, null, null, null, , f, null, t, t, 1, null, 11, null, null, null, null, null, f, null, t, null, null, null, null, null, t, t, null).
    		: INSERT INTO "projects" ("name", "path", "description", "visibility_level", "approvals_before_merge", "namespace_id", "creator_id", "runners_token", "created_at", "updated_at", "description_html", "cached_markdown_version", "packages_enabled", "archived", "resolve_outdated_diff_discussions", "container_registry_enabled", "repository_storage", "shared_runners_enabled", "only_allow_merge_if_all_discussions_are_resolved", "only_mirror_protected_branches") VALUES ('testdata-4018908385734095056', 'testdata-4018908385734095056', '', 10, NULL, 2002378, 1636476, 'xji2xdxx7PukEsRxYrPo', '2018-09-23 04:08:01.041227', '2018-09-23 04:08:01.041227', '', 11, 't', 'f', 'f', 't', 'nfs-file22', 't', 'f', 't') RETURNING "id"]}, {limit_reached: []}}

    	project_create_test.go:32: exit status 1
	project_create_test.go:50: failed to find project for cleanup: gitlab project not found
FAIL	github.com/zaquestion/lab/cmd	32.091s
?   	github.com/zaquestion/lab/internal/browser	[no test files]
ok  	github.com/zaquestion/lab/internal/config	0.025s	coverage: 6.6% of statements in ./...
make[1]: *** [internal-test] Error 1
make: *** [test] Error 1

Yeah the tests can be a bit annoying because they test against the real gitlab.com
You should just need to have an ssh key connected to a user on gitlab. Sorry there aren't better instructions on running the tests. You can select tests with
make test run=Test create

You should just need to have an ssh key connected to a user on gitlab.

I had one but I forgot that I changed my laptop since!
The problem now is that I don't have the right to create a merge request on this project.
The problem on travis is that there is an open merge request on the project with the same title: https://travis-ci.org/zaquestion/lab/builds/432038074#L576
I will try to close it via travis.

@zaquestion Maybe it'll be easier if you close it by hand!

Thats a pretty weird error -- I suspect it might be reproducible on master as well and have nothing to do with your code

Do you think you can add a test using https://github.com/zaquestion/lab/blob/master/cmd/mr_browse_test.go as guidance

@MartinDelille The test issue should be fixed by #222 -- can you rebase/update your branch. Sorry for the merge conflict!

It fixed the problem!
I will try to add a test now that the build pass because I don't want to drop the code coverage! 😉

Do you have a test scenario to propose? I'm a kind of lost how to do that.

@MartinDelille Sorry I just started a new job and haven't had much time to help out here. I'd suggest something like the existing test in https://github.com/zaquestion/lab/blob/master/cmd/mr_browse_test.go but don't pass an MR. You may have to checkout the mr test branch as well ( https://github.com/zaquestion/lab/blob/master/cmd/mr_test.go#L17-L23 )
func Test_mrBrowse(t *testing.T) {
	oldBrowse := browse
	defer func() { browse = oldBrowse }()

	browse = func(url string) error {
		require.Equal(t, "https://gitlab.com/zaquestion/test/merge_requests/<not sure what this would be>", url)
		return nil
	}

	mrBrowseCmd.Run(nil, []string{})
}

Codecov Report

Merging #221 into master will decrease coverage by 0.5%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   68.09%   67.58%   -0.51%
==========================================
  Files          41       41
  Lines        2131     2147      +16
==========================================
  Hits         1451     1451
- Misses        533      548      +15
- Partials      147      148       +1

Impacted Files
Coverage Δ

cmd/mr_browse.go
48.38% <0%> (-51.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c6531...09c0a4c. Read the comment docs.

Hi @zaquestion !
It works on my side locally. I tried again to write test but it requires times that I don't have. Maybe you could merge it without test so that people can at least use the feature?
We'll create an issue to create a test for this feature then (I don't like untested code too but sometimes we need to get thing done).


rename the lifecycle methods to Re* instead of Reducer*

Re:
ReInit
ReConfig
ReCond
ReMount
ReUnmount
is shorter, and reads much better than Reducer:
ReducerInit
ReducerConfig
ReducerCond
ReducerMount
ReducerUnmount

and we can finally stop adding to, and maybe get rid of the hacks to force a compilation error due to how easy it is to type ReduceX instead of ReducerX.

Re turned out to be slightly misleading with names like ReInit and ReMount so it was shortened to just R in https://github.com/KurokuLabs/margo/pull/73


Add filter column names to query table list

Currently the "tables required" when doing a query are only built from the return column list. This means if a filter used a table not in the returned column list the proper join would not be made.
Added a new function and test to make sure the join is made in all cases.

_parse_selected_columns doesn't describe returns, unfortunate since the returns really could use some explaining. It took me a while to understand the purpose of the last item, is_orderable_list. And, now that I think I understand what it's for, I don't understand why the code at line 220 gives the right answer. Maybe add a comment there?

I've added some more info in the doc string about what's being returned

Finally, in _render_filter there is an assert. I'm not convinced we need it at all - how could it go wrong if f really is a filter as it's supposed to be? - but if we do it should be changed to raise an exception.

I've moved the check to within _parse_selected_columns , just to make sure the lists come out the same size


GitHub Action failing - missing image

Error in knitr::include_graphics("images/logo.jpg", dpi = NA) :

Possibly better to link to https://github.com/nhs-r-community/assets/tree/main/logo?

Might also be that the merge conflict code is still in the scripts: https://github.com/nhs-r-community/statements-on-tools/blob/d0b16b0a4f50d32993be74f2dddd850a5c6961ee/index.Rmd

better off linking to the hosted version: https://nhs-r-community.github.io/assets/logo/nhsr-logo.svg


A bug in the playground due to a method call after a parenthesized assignment

The following code works fine when executed with crystal run, but in the playground it brings up the bug popup.
(y = 1).itself
y

I am running Crystal 0.22.0 [3c71228] (2017-04-20) LLVM 3.5.0 on Ubuntu 16.04 LTS.

Thanks for reporting. This is a tricky one :-(
When running the playground as $ crystal play -v you will see that the instrumented code is:
_p.i(1) do
  (y = 1).itself
end
_p.i(2) do
  y
end

So y is not longer declared in the top level. Since the first assignment is wrapped in the block. If there wasn't a .itself the instrumentation would have been:
y = _p.i(1) do
  1
end

So the scope of variable is preserved.
Workarounds: declare y = 0 or y = uninitialized Int32 at the beginning.
A fix with the current instrumentation mechanism would be to analyze the variables in all the scope of the source given and add the uninitialized to avoid shadowing. Methods are sensible to this too. In order to do this first the non instrumented code need to be compiled and extract that information similar like in context or in types tool.

Thanks for the workaround! Unfortunately, I found other test cases that break, and the reasons might be different as far as I can tell. These do not bring up the bug popup, but fail in other ways. I am unsure of whether they warrant separate issues or not.
For one, when the pseudo-method is_a? is called, the parentheses seem to go missing. For example, the code
x = ""                      # "" : String
(x = 1).is_a?(Int32)        # true : Bool
x                           # true : (Bool | String)

is turned by instrumentation into
x = _p.i(1) do
  ""
end
_p.i(2) do
    x = 1
.is_a?(Int32)
end
_p.i(3) do
  x
end

The issue is the value and type of x in the end, which should be 1 : Int32.
Similarly, the parentheses go missing when the pseudo-method responds_to? is called. However, the calling line is instrumented differently, so the outcome is changed a bit. Namely, the code
y = ""                      # "" : String
(y = 1).responds_to?(:to_s)
y                           # true : Bool

is turned into
y = _p.i(5) do
  ""
end
y = 1
.responds_to?(:to_s)
_p.i(7) do
  y
end

Again, x should be 1 : Int32.
With a regular method, such as divisible_by, the final output is correct, but the inferred type is wrong. This final one is just a different symptom of the original problem, but I include it here for completeness. So, for example, the code
z = ""                      # "" : String
(z = 1).divisible_by?(1)    # true : Bool
z                           # 1 : (Int32 | String)

is turned into
z = _p.i(9) do
  ""
end
_p.i(10) do
  (z = 1).divisible_by?(1)
end
_p.i(11) do
  z
end

@jbomanson the is_a?/responds_to? pseudo methods is indeed a different issue. And is actually not the playground but the ToSVisitor that might not be emitting the parenthesis probably if the receiver is a complex expression.
The later (z = 1).divisible_by?(1) is indeed another use case that is complicated.
Maybe the secure thing here to be done is to not instrument lines that the outer node is not an assignment, but it contain assignments somewhere (that is not a block).
At least that way there wont be changes in the semantics and both samples should work (with less instrumentation results shown in the right panel).


Remove deprecated createObservable and internal

Closes #607

Codecov Report

Merging #812 into master will increase coverage by 0.4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #812     +/-   ##
========================================
+ Coverage   96.99%   97.4%   +0.4%
========================================
  Files          89      89
  Lines        2727    2694     -33
  Branches      302     302
========================================
- Hits         2645    2624     -21
+ Misses         50      38     -12
  Partials       32      32

Impacted Files
Coverage Δ

...fresh/storio2/sqlite/impl/DefaultStorIOSQLite.java
99.29% <ø> (-0.02%)
:arrow_down:

...tentresolver/operations/get/PreparedGetObject.java
100% <ø> (+2.38%)
:arrow_up:

...olver/operations/delete/PreparedDeleteByQuery.java
91.66% <ø> (+3.66%)
:arrow_up:

...qlite/operations/delete/PreparedDeleteByQuery.java
100% <ø> (ø)
:arrow_up:

...solver/operations/delete/PreparedDeleteObject.java
100% <ø> (+3.44%)
:arrow_up:

...ions/delete/PreparedDeleteCollectionOfObjects.java
100% <ø> (+2.27%)
:arrow_up:

...operations/put/PreparedPutCollectionOfObjects.java
100% <ø> (+2.27%)
:arrow_up:

...ver/operations/get/PreparedGetNumberOfResults.java
100% <ø> (+3.03%)
:arrow_up:

...orio2/sqlite/operations/get/PreparedGetCursor.java
98.3% <ø> (-0.03%)
:arrow_down:

...ions/delete/PreparedDeleteCollectionOfObjects.java
93.82% <ø> (-0.08%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3c59...ab588ad. Read the comment docs.


Factory failure drains available connection max from pool

Issue
If the provided factory returns an error, the pool's total connection limit will permanently decrease by one. Provided this happens enough times, the pool can become deadlocked, with zero capacity.
Here is a playground example of the issue: https://go.dev/play/p/lAy0_uoKMFj
Notice after the first two failures (the number of max connections in the pool) the errors change, due to the pool itself never being able to attempt to fetch new connections.
Expected Outcome
When the factory fails, the reserved slot in the pool should be returned to the pool.

Working on a fix for this now.

Thank you for your contribution @randall-fulton


Update ingest-data-kafka.md

@anagha-microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @anagha-microsoft - Substantial content updates should be made in the private repo, so they can be verified on staging and pass quality validations. Would you submit this update in the private repo? We'll close this PR. Thanks.


Hoist  utilities should always take their closure last

In the world of prettier, you get punished pretty badly if your closure is not the last argument to the function.
There appears to be special casing for that, to allow concise loop like syntax.
This effects withLogDebug(), forEachAsync(), and whileAsync() and perhaps others.
In all cases, we should change it and  document it to take the closure last, but can continue to  support the current behavior for backward compatibility (if we choose to)

Closing this for now -- we can always revisit this when it actually becomes a reality and is causing us pain.


Incompatible infoblox-go-client changes

Update due to incompatible infoblox-go-client changes.
Update due to changes in cni/pkg/skel.

John,
These changes are needed due to changes we've made in Infoblox-go-client a little while back (when you did the example for the libnetwork blog) to support cross-host network sharing.
Would appreciate if you could merge this. I'll then merge in these changes to the branch I'm using for unit tests.

Thanks!


LibC symbols overwritten with LD_PRELOAD

I have overwritten the LibC symbols.....do check it out and let me know if any changes are required...closes issue #102
Thanks

Hey @ashvardanian if everything is fine.... please merge this PR

:tada: This PR is included in version 3.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Use protocol relative URL for OSM tiles

OpenStreetMap have enabled SSL on their services and website. Using protocol relative URLs for the tiles takes advantage of this work out of the box.
see:

OSM blog: http://blog.openstreetmap.org/2014/02/11/osm-enhances-user-privacy/
specification: IETF RFC 3986 section 4.2

This fix didn't make it into 2.13.1 hey? How do the releases work around here? Is there a development release of OpenLayers 2 any more?

OpenLayers 2 is not maintained anymore, so don't expect new releases from it

Indeed. But I was just confused because unless I'm mistaken the last release that did happen (and the last available hosted version on cloudflare), version 2.13.1,  was August 2014, but somehow didn't seem to include this fix, even though it was merged Feb 2014. That's a bummer.
I see there's still some commits to this repo. But no releases hey? I was hoping there might be hosted "nightly" development builds or something, but (looking back when the "development" site was still working) it looks like it was only ever the fixed releases up to 2.13.1

2.13.1 was probably a patch release on top of 2.13, so it did not include all other fixes from master, just regressions
It should be easy enough to build your own?


Cannot install extension manually

Web Browser: Firefox 79.0
Local OS: Ubuntu-20.04.1
Remote OS: Ubuntu-20.04.1
Remote Architecture: amd64
code-server --version: 3.6.2

I was trying to download and install Jupyter manually since the marketplace doesn't have it. But can't install the .vsix file, and the error message was like: "Corrupt ZIP: end of central directory record signature not found".
I downloaded it from here: https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
And I tried to install other extensions:
[Successed] C#: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp
[Successed] Vetur: https://marketplace.visualstudio.com/items?itemName=octref.vetur
[Failed] Go: https://marketplace.visualstudio.com/items?itemName=golang.Go
Any ideas?

Hmm so far I haven't had any luck replicating on 3.6.2. Does unzipping
those files manually work?

Can I ask how to unzip and install it? I didn't find any vsix file after the extraction.
It seems like I can only install the extensions that code-server marketplace has, whether automatically or manually...

I was thinking of unzipping the extension on the command line. If it
works then it indicates code-server is the problem but if it doesn't
then it means the zip actually is corrupt. For example:
$ unzip golang.Go-0.18.1.vsix

You're right. I can only unzip some of the files. Maybe it caused by my OS? The file names are not highlighted as expected in the terminal.

Oh that's interesting. I think ls only colors based on the file
extension or permissions so maybe the permissions are different? Could
check with ls -l. If the permissions aren't different then I'm not
sure; maybe it's checking the file content which makes the corrupted
files not get colored since they aren't valid archives.
It could be caused by a network glitch causing the download to be
incomplete or corrupted. Does re-downloading help at all?
What do you get if you run sha256sum *.vsix? Here's what I've got:
6f659add350b4109c19b5ff19c3081f5266313e5b1cf9c01b6d8c312d7fcaa51  golang.Go-0.18.1.vsix
93e6b322c187ce726a81882ae3903af9f146694836542853995ea15f6e9e8035  ms-dotnettools.csharp-1.23.6.vsix
bd388b0abd52bf1c56a19cf8c583bae215da5293ab4a26498520118e20829b2d  ms-toolsai.jupyter-2020.11.358541065.vsix
80886e117c8f007d6ab1f0df9e99df14c1489e1d57b4933bdbb3d325ea01b5aa  octref.vetur-0.30.2.vsix

Re-downloaded and it works! Thank you!

Glad to hear it! I'll go ahead and close this since I don't think there's anything we can do on the code-server side. If you think of anything though let me know.


Combine k8s and database transactions

The current k8s and database transactions are separate, which will result in situations where a commit/processing failure of k8s will not trigger a rollback of a database transaction.
We need to design a unified transaction management or processing logic to ensure submarine-server to be able to handle exceptions and transaction rollbacks correctly.
For example, by using the @Transactional, or by putting the relevant operations codes/methods into one of our transaction services.

Add a JIRA issue in https://issues.apache.org/jira/browse/SUBMARINE-1309


Problem with Evaluate Active Value out of IsoStore

Hi,
when using the CheckIfActive procedure, I get an error when trying to read the active value out of the Isolated Store
Value "Ja" cannote be evaluated in Type Boolean...
I'm using an AT Version
Problem should be solved if formatting the value when writing in Codeunit SPBPL License Utilities, as you already did it with the DateTime Values
SPBPLIsoStoreManager.SetAppValue(SPBPLExtensionLicense, 'active', Format(SPBPLExtensionLicense.Activated**,0,9**));
Thanks,
Michael

Good catch, this is now in place.


Frame busting and file drops in textareas

Takes two dashboard PRs and moves share-able bits here.

Frame buster, aptible/dashboard.aptible.com#552
Drag-n-drop .crt, bundled .crt, and .key files to create certificates, aptible/dashboard.aptible.com#543

Those both got a merge thumbs up, so I'll merge this on Travis' green light and then do another dashboard PR to set the cli version and implement these changes.

Thanks for this, great work!


Automated ExUnit based test executor

Should create testplans automatically and execute all tests.
Needs an API token.
Browser to be controlled using Wallaby.
Reference: https://gitlab.com/paulswartz/ueberauth_oidcc_certification

BLocked by  #2

@paulswartz Since the GitLab repo does not have a LICENSE: Can you quickly comment that you agree with this usage of your code?

Yep, this is fine! And I'll add a LICENSE when I'm back at a computer.


NRE on spatial search

Hi,
I'm getting this exception sometimes, this is on heavily indexed production environment,
couldn't reproduce this locally.
its happening rarely, with unknown reason / pattern.
all I'm doing is simple spatial search, points close to point, ordered by distance.
I'm using 10km radius filter, with matchalldocs query and sort by distance.
code for sort:
var point = SpatialContext.MakePoint(lon, lat);
var valueSource = SpatialStrategy.MakeDistanceValueSource(point, DistanceUtils.DEG_TO_KM);
var sort = new Sort(valueSource.GetSortField(false)).Rewrite(indexSearcher);

the exception:
System.NullReferenceException: Object reference not set to an instance of an object.
at Spatial4n.Core.Util.GeohashUtils.DecodeBoundary(String geohash, SpatialContext ctx)
at Spatial4n.Core.Util.GeohashUtils.Decode(String geohash, SpatialContext ctx)
at Lucene.Net.Spatial.Util.ShapeFieldCacheProvider1.<GetCache>b__5_0(IndexReader key)      at System.Runtime.CompilerServices.ConditionalWeakTable2.GetValue(TKey key, CreateValueCallback createValueCallback)
at Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource.CachedDistanceFunctionValue..ctor(AtomicReader reader, ShapeFieldCacheDistanceValueSource enclosingInstance)
at Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource.GetValues(IDictionary context, AtomicReaderContext readerContext)
at Lucene.Net.Queries.Function.ValueSource.ValueSourceComparer.SetNextReader(AtomicReaderContext context)
at Lucene.Net.Search.TopFieldCollector.OneComparerNonScoringCollector.SetNextReader(AtomicReaderContext context)
at Lucene.Net.IndexSearcher.Search.Search(IList1 leaves, Weight weight, ICollector collector)      at Lucene.Net.IndexSearcher.Search.Search(IList1 leaves, Weight weight, FieldDoc after, Int32 nDocs, Sort sort, Boolean fillFields, Boolean doDocScores, Boolean doMaxScore)
at Lucene.Net.IndexSearcher.Search.Search(Weight weight, FieldDoc after, Int32 nDocs, Sort sort, Boolean fillFields, Boolean doDocScores, Boolean doMaxScore)
any ideas?

What version are you seeing this in? And does the behavior differ between versions?

What version are you seeing this in? And does the behavior differ between versions?

latest (beta 11, it was also on previous versions from the beta 8, maybe even before but this issue was on beta 8)

maybe this can give more information, i noticed this exception too, (very rarely)
System.ArgumentOutOfRangeException: Index and count must refer to a location within the buffer.  Parameter name: bytes
   at System.Text.UTF8Encoding.GetString(Byte[] bytes, Int32 index, Int32 count)
   at Lucene.Net.Spatial.Prefix.Tree.Cell.get_TokenString()
   at Lucene.Net.Spatial.Prefix.Tree.GeohashPrefixTree.GhCell.get_Center()
   at Lucene.Net.Spatial.Util.ShapeFieldCacheProvider`1.<GetCache>b__5_0(IndexReader key)
   at System.Runtime.CompilerServices.ConditionalWeakTable`2.GetValue(TKey key, CreateValueCallback createValueCallback)
   at Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource.CachedDistanceFunctionValue..ctor(AtomicReader reader, ShapeFieldCacheDistanceValueSource enclosingInstance)
   at Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource.GetValues(IDictionary context, AtomicReaderContext readerContext)
   at Lucene.Net.Queries.Function.ValueSource.ValueSourceComparer.SetNextReader(AtomicReaderContext context)
   at Lucene.Net.Search.TopFieldCollector.OneComparerNonScoringCollector.SetNextReader(AtomicReaderContext context)
   at Lucene.Net.IndexSearcher.Search.Search(IList`1 leaves, Weight weight, ICollector collector)
   at Lucene.Net.IndexSearcher.Search.Search(IList`1 leaves, Weight weight, FieldDoc after, Int32 nDocs, Sort sort, Boolean fillFields, Boolean doDocScores, Boolean doMaxScore)
   at Lucene.Net.IndexSearcher.Search.Search(Weight weight, FieldDoc after, Int32 nDocs, Sort sort, Boolean fillFields, Boolean doDocScores, Boolean doMaxScore)

@eladmarg
I have tracked down issue #296 which also started to appear on 4.8.0-beta00008 and didn't occur on 4.8.0-beta00007. Could you download the packages from the nuget artifact here to see if this problem still exists?
If this issue still exists, it may be possible to trace it to a commit if you can provide a console app and the data that causes it to fail.

Thanks for the update,
I'll deploy next release and hope this will be resolved
It's happening very rarely on production with high frequency request rates

still happen...

I see. Could you please provide complete example code to reproduce the issue (even if it happens rarely)?

this still occurs

System.NullReferenceException: Object reference not set to an instance of an object.
   at IRectangle Spatial4n.Core.Util.GeohashUtils.DecodeBoundary(string geohash, SpatialContext ctx)
   at IPoint Spatial4n.Core.Util.GeohashUtils.Decode(string geohash, SpatialContext ctx)
   at ShapeFieldCache Lucene.Net.Spatial.Util.ShapeFieldCacheProvider.GetCache(AtomicReader reader)+(IndexReader key) => { }
   at TValue System.Runtime.CompilerServices.ConditionalWeakTable.GetValueLocked(TKey key, CreateValueCallback createValueCallback)
   at TValue System.Runtime.CompilerServices.ConditionalWeakTable.GetValue(TKey key, CreateValueCallback createValueCallback)
   at new Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource+CachedDistanceFunctionValue(AtomicReader reader, ShapeFieldCacheDistanceValueSource enclosingInstance)
   at FunctionValues Lucene.Net.Spatial.Util.ShapeFieldCacheDistanceValueSource.GetValues(IDictionary context, AtomicReaderContext readerContext)
   at FieldComparer Lucene.Net.Queries.Function.ValueSource+ValueSourceComparer.SetNextReader(AtomicReaderContext context)
   at void Lucene.Net.Search.TopFieldCollector+OneComparerNonScoringCollector.SetNextReader(AtomicReaderContext context)
   at void Lucene.Net.IndexSearcher.Search.Search(IList leaves, Weight weight, ICollector collector) x 5

finally, I can confirm this is resolved. (thanks to #509)

Thanks for the update Elad.


POC: Setting upstream vhost for nginx.

In the current k8 ingress there's no way to control "Host" header sent to upstream server; it's always the configured vhost.
It's desirable to support custom Host header when proxying for a number of cases. One such case is forwarding to an Service that points to an external host that expect a host paramater (like AWS S3 buckets). There's a number of others.
By default nginx set Host to the upstreams domain name (and not the one passed in) like K8 always forces. This provided an escape hatch to this behavior.
This is a proof of concept PR for review, feedback. I can incorporate all of that; I just need to make sure I'm going down the right path.

This change is

Stuck in getting the CLA signed due to LF CLA issues. But in the mean time I would appreciate the review of the work/direction.

@mtanski apologies for the delay. This feature makes sense in many scenarios.
What you are doing is ok. Please finish the annotation parser so we can test this

@aledbf I'm going to be away for a week; so I'll make those changes when I'm back and solicit feedback then.

Have signed the CLA (org & employee). This was delayed due to some LF internal issue that prevented my org for being able to sign the CLA.

Finally had a chance to get back to this. I have rebased this against master (for ez merging) and added the missing annotation implementation file.

@aledbf any chance to get this into upstream?

@mtanski please rebase

Coverage increased (+0.007%) to 43.688% when pulling 2120aab66cc62af94024475e46835bb0e14ef8b4 on adfin:upstream-vhost into 7eb2b81fd32d70e02913c32a78eb47d4dfabe83e on kubernetes:master.

@aledbf here ya go

/lgtm

@mtanski thanks!

@mtanski Can we just update the docs with this new directive? Thanks!!!

@rikatz Yes. I will send a PR this week; most likely in the 2nd half.


Encoding bug with the teamslogon.aspx redirection service

Double encoding the provided URL, redirecting to an invalid URL and resulting in a 404.
Example:
https://contoso.sharepoint.com/sites/ContosoNet/_layouts/15/teamslogon.aspx?SPFX=true&dest=/sites/ContosoNet/Home%20page.aspx
Will redirect to:
https://contoso.sharepoint.com/sites/ContosoNet/Home%2520page.aspx
See the double encoding with the "Home%2520page" above.
The URL without encoding is working fine.
So, could you please remove highlighted text in below image.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ef9b82d-5475-c5fa-ac7a-7005558e06f1
Version Independent ID: 1d9d4923-c44f-b00b-a553-60c73ed8b8e6
Content: Embedding modern SharePoint pages in Microsoft Teams as personal apps (preview)
Content Source: docs/features/embed-pages-to-teams.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

From the tests I have made, it is not possible to not encode the [pageUrl] part of the URL, in the case you have any spaces or special characters in the URL, the response will give an HTTP Error 400. The request is badly formed.
I think the teamslogon.aspx page needs a fix to not encode the redirected URL twice and result in a 404.
I don't see a workaround for these cases right now.

As of today, it seems like the encoding bug is resolved on our tenants.

There is still a defect - I have a situation with such url:
_https://contoso.sharepoint.com/sites/one/_layouts/15/teamslogon.aspx?SPFX=true&dest=%2Fsites%2Fone%2Fredirect.aspx%3Furl%3Dhttps%253a%252f%252fmysite.azureedge.net%252findex.html%253fparam1%253dtrue%2526param2%253dfalse_
I expect this to go to:
_https://contoso.sharepoint.com/sites/one/redirect.aspx?url=https%3A%2F%2Fmysite.azureedge.net%2Findex.html%3Fparam1%3Dtrue%26param2%3Dfalse_
But instead it is decoding everything and I'm loosing my parameters in the second url:
_https://contoso.sharepoint.com/sites/one/redirect.aspx?url=https://mysite.azureedge.net/index.html?param1=true&param2=false_

This still seems to be an issue.
The Lists Teams app from Microsoft will also just throw a 404 if it's added to a Team where the a site collection for the team has a whitepace in the url i.e. https://contoso.sharepoint.com/sites/Internal Projects
https://contoso.sharepoint.com/sites/Internal%2520Projects/_layouts/15/teamslogon.aspx?spfx=true&dest=%2Fsites%2FInternal%2520Projects/_layouts/15/teamsappconfiguration.aspx?theme=default&locale=en-us


Add "did you mean" message when failing due to invalid cops in configuration

Try to suggest a replacement cop when an invalid cop name is found in the config.
eg:
Error: unrecognized cop Layout/LyneLenth found in .rubocop.yml
Did you mean `Layout/LineLength`?
unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Did you mean `Lint/LiteralAsCondition`?

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Cool idea! I love it!


Dataset work

Some possible sources for graph-datasets. Need to discuss what we are trying to achieve and at which scale. Perhaps we could generate some toy datasets?
https://snap.stanford.edu/data/
https://paperswithcode.com/dataset/reddit

Many thanks! Toy datasets sound good as well. Setting up a planning meeting.


Expose ClickHouse config and support the HTTP interface

This PR:

mounts the ClickHouse config outside of the container so that it's modifiable (ala dokku-redis)
modifies the linked URL for cases when CLICKHOUSE_DATABASE_SCHEME="http" to match the http interface format (port 8123)

This also solves with #2

Mind splitting this into separate PRs?

@josegonzalez split to #20 and #21. Let me know if you want something changed! Thanks


Revert "Update README.md"

Reverts draculadeng/20220106_test#3

pls edit it again!

Close this PR!