Error: Template parse errors: 'swal' is not a known element:

I get the following error when I try to use this library:

Error: Uncaught (in promise): Error: Template parse errors:
'swal' is not a known element:
If 'swal' is an Angular component, then verify that it is part of this module.
To allow any element add 'NO_ERRORS_SCHEMA' to the<EMAIL_ADDRESS>of this component. ("     <form name="form" (ngSubmit)="f.form.valid && login()" #f="ngForm" novalidate>
[ERROR ->]<swal #dialog >

<span class=""): ng:///PagesModule/LoginComponent.html@10:16
syntaxError@webpack-internal:///../../../compiler/@angular/compiler.es5.js:1913:34
TemplateParser.prototype.parse@webpack-internal:///../../../compiler/@angular/compiler.es5.js:13010:19
JitCompiler.prototype._compileTemplate@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27213:18
JitCompiler.prototype._compileComponents/<@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27132:56
JitCompiler.prototype._compileComponents@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27132:9
JitCompiler.prototype._compileModuleAndComponents/<@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27019:13
then@webpack-internal:///../../../compiler/@angular/compiler.es5.js:1902:133
JitCompiler.prototype._compileModuleAndComponents@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27018:16
JitCompiler.prototype.compileModuleAsync@webpack-internal:///../../../compiler/@angular/compiler.es5.js:26947:32
ModuleBoundCompiler.prototype.compileModuleAsync@webpack-internal:///../../../compiler/@angular/compiler.es5.js:27347:16
SystemJsNgModuleLoader.prototype.loadAndCompile/<@webpack-internal:///../../../core/@angular/core.es5.js:5862:44
ZoneDelegate.prototype.invoke@webpack-internal:///../../../../zone.js/dist/zone.js:392:17
onInvoke@webpack-internal:///../../../core/@angular/core.es5.js:4090:24
ZoneDelegate.prototype.invoke@webpack-internal:///../../../../zone.js/dist/zone.js:391:17
Zone.prototype.run@webpack-internal:///../../../../zone.js/dist/zone.js:142:24
scheduleResolveOrReject/<@webpack-internal:///../../../../zone.js/dist/zone.js:873:52
ZoneDelegate.prototype.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:425:17
onInvokeTask@webpack-internal:///../../../core/@angular/core.es5.js:4081:24
ZoneDelegate.prototype.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:424:17
Zone.prototype.runTask@webpack-internal:///../../../../zone.js/dist/zone.js:192:28
drainMicroTaskQueue@webpack-internal:///../../../../zone.js/dist/zone.js:602:25
ZoneTask.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:503:21
invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:1540:9
globalZoneAwareCallback@webpack-internal:///../../../../zone.js/dist/zone.js:1566:17
Stack trace:
resolvePromise@webpack-internal:///../../../../zone.js/dist/zone.js:824:31
resolvePromise@webpack-internal:///../../../../zone.js/dist/zone.js:795:17
scheduleResolveOrReject/<@webpack-internal:///../../../../zone.js/dist/zone.js:873:17
ZoneDelegate.prototype.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:425:17
onInvokeTask@webpack-internal:///../../../core/@angular/core.es5.js:4081:24
ZoneDelegate.prototype.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:424:17
Zone.prototype.runTask@webpack-internal:///../../../../zone.js/dist/zone.js:192:28
drainMicroTaskQueue@webpack-internal:///../../../../zone.js/dist/zone.js:602:25
ZoneTask.invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:503:21
invokeTask@webpack-internal:///../../../../zone.js/dist/zone.js:1540:9
globalZoneAwareCallback@webpack-internal:///../../../../zone.js/dist/zone.js:1566:17

Here is my package.json file:

{
"name": "@coreui/angular",
"version": "1.0.5",
"description": "Open Source Bootstrap Admin Template",
"author": "Łukasz Holeczek",
"homepage": "http://coreui.io",
"copyright": "Copyright 2017 creativeLabs Łukasz Holeczek",
"license": "MIT",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@angular/animations": "~4.4.6",
"@angular/cdk": "^5.0.0-rc0",
"@angular/common": "~4.4.6",
"@angular/compiler": "~4.4.6",
"@angular/core": "~4.4.6",
"@angular/forms": "~4.4.6",
"@angular/http": "~4.4.6",
"@angular/material": "^5.0.0-rc0",
"@angular/platform-browser": "~4.4.6",
"@angular/platform-browser-dynamic": "~4.4.6",
"@angular/platform-server": "~4.4.6",
"@angular/router": "~4.4.6",
"@toverux/ngsweetalert2": "^2.0.1",
"angular2-notifications": "^0.7.8",
"bootstrap": "4.0.0-beta.2",
"chart.js": "2.7.1",
"core-js": "2.5.1",
"font-awesome": "^4.7.0",
"moment": "2.19.1",
"ng2-charts": "1.6.0",
"ngx-bootstrap": "1.9.3",
"rxjs": "5.5.2",
"simple-line-icons": "^2.4.1",
"sweetalert2": "^6.11.5",
"ts-helpers": "1.1.2",
"zone.js": "0.8.18"
},
"devDependencies": {
"@angular/cli": "1.5.0",
"@angular/compiler-cli": "^4.0.0",
"@angular/language-service": "^4.0.0",
"@types/jasmine": "~2.5.53",
"@types/jasminewd2": "~2.0.2",
"@types/node": "~6.0.60",
"codelyzer": "~3.0.1",
"jasmine-core": "2.8.0",
"jasmine-spec-reporter": "4.2.1",
"karma": "1.7.1",
"karma-chrome-launcher": "2.2.0",
"karma-cli": "1.0.1",
"karma-jasmine": "1.1.0",
"karma-jasmine-html-reporter": "0.2.2",
"karma-coverage-istanbul-reporter": "1.3.0",
"protractor": "~5.1.2",
"ts-node": "~3.0.4",
"tslint": "~5.3.2",
"typescript": "~2.3.3"
},
"engines": {
"node": ">= 6.9.0",
"npm": ">= 3.0.0"
}
}

My plunk: https://plnkr.co/edit/uFUaNSvOAjwsnperAZJ5?p=preview

The plunkr seems broken: there's a 404 when loading app/main.ts and the main.ts file (in src/) references an ./app.ts file that is not listed in the Plunkr files.
Anyway, this error generally means that you didn't registered SweetAlert2Module properly. If you have updated the library from v.1 to v.2 without having checked for the breaking changes, please note that forRoot() is now required:
import { SweetAlert2Module } from '@toverux/ngsweetalert2';

@NgModule({
    //=> Basic usage
    imports: [SweetAlert2Module.forRoot()],

    //=> Or provide default SweetAlert2-native options
    //   (here we make Swal more Bootstrap-friendly)
    imports: [
        SweetAlert2Module.forRoot({
            buttonsStyling: false,
            customClass: 'modal-content',
            confirmButtonClass: 'btn btn-lg btn-primary',
            cancelButtonClass: 'btn btn-lg'
        })
    ],

    //=> In submodules only:
    imports: [SweetAlert2Module]
})
export class AppModule {
}

@toverux
I get this error when trying to use this library (from your example):

Strange. Your setup looks good though, based on what I'm seeing.
Can you send me the content of your package-lock.json or yarn.lock ? Also, if your project does not contain sensitive, closed-source code yet, you can send me a .zip of it so I can see what's going on.

@toverux Here is the link to my repository. https://github.com/dyhaz/angular4-coreui

Hi @dyhaz, thanks for the repo!
I can't reproduce, which lets me think that something is wrong on your installation (but what, I've no idea).
It builds flawlessly with from '@toverux/ngsweetalert2', as well as your from '@toverux/ngsweetalert2/dist/esm+types/index' workaround. I don't see what could cause such issue. Maybe just check that it's not your IDE that has a corrupted cache (sometimes they like to make us think we're wrong, while they actually are). If you don't see the same error in the console with Angular CLI, 100% it is your IDE.
I will release a new major of NgSweetAlert2 very soon. If you stil have the problem, you can eventually keep your workaround for now and wait for the new version that as a completely revised build system. If that's ok for you, I let you close the issue :)

The new version has been release meanwhile: https://github.com/toverux/ngx-sweetalert2/releases/tag/v3.0.0
Reopen if you encounter the same problem again.

@dyhaz Could you solve this?


Question: Redis Sentinal Support

Actually the FAQ states that https://github.com/juicedata/juicefs#can-i-use-redis-cluster but is there a way to at least use redis sentinal or is this considered unsafe (and could loose data) aswell?

Replication and Failover should be safe and even be required to deploy Redis. The Sharding in Redis cluster is not supported, since distributed transaction is not supported in redis cluster.

Replication and Failover should be safe and even be required to deploy Redis. The Sharding in Redis cluster is not supported, since distributed transaction is not supported in redis cluster.

thanks for the info, I'm closing the issue, feel free to reopen, if you want to add something to the readme.md

thanks for the info, I'm closing the issue, feel free to reopen, if you want to add something to the readme.md

@schmitch Added this into FAQ, thanks!

@schmitch Added this into FAQ, thanks!


Update dotnet-watch.md

Internal review URL

@pranavkm  hold off commits, I'm working on this.

@pranavkm  I think my commit addressed all the issues, if not, can you fix them. Let me know when I can merge this.

Let's get this in!


fix: correct import of b64decode in migration 0020

I didn't cover it with tests and didn't even run them (sorry), but it was broken for me and now it's not, so might be helpful.

test fail seem to be unrelated to the changes.

Yes there is one failing test that I don't quite understand why, it used to work until not long ago. Maybe a change in python and/or django?
Thank you for this patch! The master branch targets Django 2.0+ and so is now exclusively Python 3, no need for the Py2 compatibility in future patches.


Improve theme system for easier overriding

More theme color vars
Adds ability to override syntax theme
More docs around theming

with my only concern being around what will change for existing users when this gets merged. I think the answer is "nothing", from the look of it?

Yeah, there will be no changes to the themes. I just used a few variables in more places so they could be overridden by custom.scss


Correct develop

Hello @gwenchee! Thanks for submitting the PR.

In the file d3ploy/no_inst.py, following                are the PEP8 issues :

Line 25:1: E302 expected 2 blank lines, found 1
Line 48:80: E501 line too long (85 > 79 characters)
Line 49:15: E131 continuation line unaligned for hanging indent
Line 54:80: E501 line too long (86 > 79 characters)
Line 55:15: E131 continuation line unaligned for hanging indent
Line 55:80: E501 line too long (88 > 79 characters)
Line 62:80: E501 line too long (91 > 79 characters)
Line 63:15: E131 continuation line unaligned for hanging indent
Line 63:80: E501 line too long (95 > 79 characters)
Line 65:80: E501 line too long (84 > 79 characters)
Line 69:1: W293 blank line contains whitespace
Line 86:80: E501 line too long (80 > 79 characters)
Line 120:34: E225 missing whitespace around operator
Line 121:32: E225 missing whitespace around operator
Line 122:34: E225 missing whitespace around operator
Line 123:29: E225 missing whitespace around operator
Line 124:28: E225 missing whitespace around operator
Line 125:33: E225 missing whitespace around operator
Line 126:37: E225 missing whitespace around operator
Line 127:37: E225 missing whitespace around operator
Line 131:80: E501 line too long (86 > 79 characters)
Line 150:80: E501 line too long (86 > 79 characters)
Line 151:80: E501 line too long (86 > 79 characters)
Line 157:5: E303 too many blank lines (2)
Line 159:80: E501 line too long (99 > 79 characters)
Line 160:80: E501 line too long (84 > 79 characters)
Line 164:20: E225 missing whitespace around operator
Line 167:80: E501 line too long (107 > 79 characters)
Line 167:101: E225 missing whitespace around operator
Line 169:15: E271 multiple spaces after keyword
Line 172:41: W291 trailing whitespace
Line 175:80: E501 line too long (87 > 79 characters)
Line 176:80: E501 line too long (83 > 79 characters)
Line 177:80: E501 line too long (90 > 79 characters)
Line 178:35: E225 missing whitespace around operator
Line 180:1: W293 blank line contains whitespace
Line 181:1: W293 blank line contains whitespace
Line 182:1: W293 blank line contains whitespace
Line 183:5: E303 too many blank lines (3)
Line 193:1: W293 blank line contains whitespace
Line 214:80: E501 line too long (87 > 79 characters)
Line 219:1: W293 blank line contains whitespace
Line 221:5: E303 too many blank lines (2)
Line 230:5: E303 too many blank lines (2)
Line 232:80: E501 line too long (88 > 79 characters)
Line 254:80: E501 line too long (82 > 79 characters)
Line 255:58: E251 unexpected spaces around keyword / parameter equals
Line 255:60: E251 unexpected spaces around keyword / parameter equals
Line 256:60: E251 unexpected spaces around keyword / parameter equals
Line 256:62: E251 unexpected spaces around keyword / parameter equals
Line 256:80: E501 line too long (82 > 79 characters)
Line 265:80: E501 line too long (82 > 79 characters)
Line 266:58: E251 unexpected spaces around keyword / parameter equals
Line 266:60: E251 unexpected spaces around keyword / parameter equals
Line 267:60: E251 unexpected spaces around keyword / parameter equals
Line 267:62: E251 unexpected spaces around keyword / parameter equals
Line 267:80: E501 line too long (82 > 79 characters)
Line 313:5: E303 too many blank lines (2)
Line 329:46: E251 unexpected spaces around keyword / parameter equals
Line 329:48: E251 unexpected spaces around keyword / parameter equals
Line 353:48: E251 unexpected spaces around keyword / parameter equals
Line 353:50: E251 unexpected spaces around keyword / parameter equals
Line 371:32: E231 missing whitespace after ','
Line 376:48: E251 unexpected spaces around keyword / parameter equals
Line 376:50: E251 unexpected spaces around keyword / parameter equals
Line 390:1: W391 blank line at end of file

In the file tests/deploy_solver_test.py, following                are the PEP8 issues :

Line 1:14: W291 trailing whitespace
Line 3:1: E302 expected 2 blank lines, found 1
Line 13:1: W293 blank line contains whitespace
Line 24:1: W293 blank line contains whitespace
Line 36:80: E501 line too long (83 > 79 characters)
Line 65:1: W293 blank line contains whitespace
Line 72:80: E501 line too long (117 > 79 characters)


Add double-conversion package.

One of dependencies for Folly (see #838).

By using include_directories(${double-conversion_INCLUDE_DIRS}), I was able to fix compilation. However, I'm not sure based on the project's CMake files why this include directory isn't propagated automatically to the dependent project.

Got it. Thanks!

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2357
https://travis-ci.org/ingenue/hunter/builds/274530379?utm_source=github_status&utm_medium=notification

I have an easy fix for clang-analyzer, but it won't work with -DNDEBUG. clang-analyzer checks assertions to understand valid scenarios, but -DNDEBUG causes #define assert(x)  // do nothing.

Even with the recent fix to double-conversion, the analyzer bug is still present due to the -DNDEBUG setting. See this quote from clang-analyzer docs for details:

ALWAYS analyze a project in its "debug" configuration
Most projects can be built in a "debug" mode that enables assertions. Assertions are picked up by the
static analyzer to prune infeasible paths, which in some cases can greatly reduce the number of false
positives (bogus error reports) emitted by the tool.
Another option is to use --force-analyze-debug-code flag of scan-build tool which would enable
assertions automatically.

https://clang-analyzer.llvm.org/scan-build.html

the analyzer bug is still present due to the -DNDEBUG setting

If you don't know how to fix it or don't want to fix it then just exclude it. There is no need to make all platforms or toolchains working, it's not a requirement.

I mean I have a fix but it means changing the overall analyzer workflow to use debug builds instead of release builds.

I mean I have a fix but it means changing the overall analyzer workflow to use debug builds instead of release builds.

Release + Debug build is default configuration for Hunter.

https://clang-analyzer.llvm.org/scan-build.html

Polly toolchain analyze is not using scan-build tool.
I personally think that analyzer should work with both Debug and Release. The assertion problem can be solved by Clang analyzer aware assert-like macro.
Such issue is out of scope of "adding new package" discussion. Please just exclude this toolchain and open separate issue for discussion if you want to improve behaviour.

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2383
https://travis-ci.org/ingenue/hunter/builds/275408478?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.2393
https://travis-ci.org/ingenue/hunter/builds/275776683?utm_source=github_status&utm_medium=notification

Released https://github.com/ruslo/hunter/releases/tag/v0.19.100


--quiet & suppress warning for default ignored files (e.g. node_modules)

Please add an option to suppress warnings which occure because of default ignored files like e.g. in the node_modules directory.
Thanks for the great extension!

I believe you can just add quiet: true to your .eslintrc

Unfortunately that is not working...

Any idea how to solve it?

I'll look into this today, sorry for the delay.

Hey,
any updates?
Thanks :+1:

I was looking at eslint's codebase last night and think I have a solution that will be good for everyone. On vacation right now, but I should have time tomorrow when I get back to make the appropriate changes.

Just saw the pull requeset on your repo which hopefully will solve the issue.
Thanks for your help!

This will go out in 2.1 via https://github.com/yaycmyk/eslintify/pull/11


runtime parameters like resize shape from config.pbtxt

I want to write preprocessing pipeline that I intend to reuse with multiple yolo models having different input shapes.
Some would have 512x512 input while others might have 256x256, etc. Is there a way to keep this resize_x and resize_y parameters of dali.fn.resize configurable from the config.pbtxt ?
I tried digging through the examples and tried passing these to pipeline_def but it only expects the Pipeline initialisation kwargs. I know these kwargs can be passed from config.pbtxt.
I also saw that I can pass the resize_x and resize_y as in input and get them through fn.external_source but is there a way to pass these values directly in config.pbtxt instead of taking these from user input (since they are dependent on downstream model input size that the user might not have knowledge of). ?

Hi @dumbPy !
Apologies for the late response.
I envision 2 scenarios you can follow:

You want to have a single model.dali (i.e. serialized DALI pipeline) model for all of your YOLO models. In this scenario, since the DALI pipeline is already serialized, your best chance would be to use fn.external_source and feed the model with the input. Unfortunately, Triton does not make it easy to pass constants specified in config.pbtxt. However, you could work this around. If you set up a Python Backend model before the DALI model, Python model might have knowledge about the shape of the YOLO model. This way, Python model can take the user input and pass it (at the minimal cost) to DALI together with the resize parameter.
The other option is to keep unserialized DALI model and then deploy it. Obviously, it's not something that can be always convenient. However, if you have a deployment step before running the server and choosing the YOLO input shape, you can parameterize DALI pipeline serialization:

@pipeline_def
def pipe(rx, ry):
    inp = fn.external_source(...)
    resized = fn.resize(inp, resize_x=rx, resize_y=ry, ...)
    return resized

[...]
def serialize():
    args = args.parse_args()  # argparse in one way to pass the cmdline parameters...
    p = pipe(rx=args.rx, ry=args.ry, ...)
    p.serialize(...)

I hope this is going to help.

Hi @szalpal
thank you, and sorry for my late reply :sweat_smile:
Yes, Solution 2 is what I ended up going with since it's doesn't take much time to compile, while deploying a model.
Thanks a lot..

could you elaborate on option 2 please? do we serialize DALI pipeline on-the-fly in the triton container?


Text selection is broken.

Double clicking or selecting text immediately removes the selection.

YEah, that's cus as soon as you click on a message, focus gets transferred to the input box.
feature?
Is there a way to detect highlighting text vs just clicking?

@TeffenEllis ^^

window.getSelection
https://developer.mozilla.org/en-US/docs/Web/API/Window.getSelection
I've played with a bit and it's a little temperamental. The method always returns a function with a type property indicating if a range has been created.


Added new dev app icons

Added new app icon files with the dev icon image.

Did you already run these through the metadata stripping tool?

Yes I ran the metadata stripping tool.


Do you need anything from xterm.js?

Hi @Eugeny, I'm one of the maintainers on xterm.js. I noticed that hterm appears to be the default frontend and was wondering if there were particular issues on our side for this?

@Tyriar How about getting to work on TrueColor? :/

@MrKumaPants we're getting fairly close to done with the buffer improvements that will allow us to do true color without taking way too much memory https://github.com/xtermjs/xterm.js/issues/791

Hey Daniel, thanks for reaching out!
I've recently posted two feature requests that would definitely make it easier to switch over to xterm in the future:
https://github.com/xtermjs/xterm.js/issues/1803
https://github.com/xtermjs/xterm.js/issues/1824
I'm definitely looking forward to the WebGL renderer as well.
One major pain of integrating xterm is how monkeypatching-resistant it is - with a lot of stuff locked away within closures - e.g. it's absolutely impossible to patch any event handlers installed with addDisposableDomListener(), and the function itself is unreachable from xterm when it's built.
I've considered importing xterm/src/xterm.js directly, which would make all submodules importable on our side as well, but that doesn't work nicely since Terminus has stricter code policy (noUnusedLocals etc), and it results in a ton of build warnings, which TypeScript can't ignore on per-module basis.

Also, what's the state of ConPTY integration in node-pty? The PR looks feature-complete, but I hadn't have a chance to test it yet. I wouldn't mind adding it to Terminus before it's released/stable.

I commented on those 2 issues.

One major pain of integrating xterm is how monkeypatching-resistant it is - with a lot of stuff locked away within closures - e.g. it's absolutely impossible to patch any event handlers installed with addDisposableDomListener(), and the function itself is unreachable from xterm when it's built.

Do you have some examples of what you're trying to do here?

I'm definitely looking forward to the WebGL renderer as well.

Ditto, it's not a priority to push that in currently but I'm going to keep the PR up to date in the meantime.

Also, what's the state of ConPTY integration in node-pty? The PR looks feature-complete, but I hadn't have a chance to test it yet. I wouldn't mind adding it to Terminus before it's released/stable.

It doesn't work in Electron 2 so it's been blocked on VS Code adopting Electron 3, which is likely to happen in the next release so expect me to clean up and merge that PR soon 😃

Thanks!
As to monkey-patching, one example would be hooking the paste events.

@MrKumaPants I've just added True Color support in #23

xterm frontend is now the default


[Feature Request] Do you have plan to do a Tree Select?

Existing Component
No
Component Name
Tree Select
Description
Hello:
Do you have plan to do a Tree Select。It is like a dropdown select，and if you click it , It show a popover，In the popover ,There is a radio tree。In fact it is very useful when you make a form contains a a radio tree，for example chose a organization for user。And when I read the exiting issue find that many people it。thanks:)

We have no plan to add it.


Crash when 2 instruction sequence is encountered

If the following two instructions occur in the instruction steam, Binary Ninja will crash.
0fe0a0e1   mov     lr, pc
08f09de4   ldr     pc, [sp],  #0x8 {var_8}
To repro, just place the opcode bytes in a new file and make an armv7 function out of them.

Crash is here: https://github.com/Vector35/arch-armv7/commit/72a728d061d3dcab83c67af9fb1094a028d19c30#diff-674748bfdb6938a89d14654f976e4a5058d3a0679dfaa5f56a3a0e549e14debfR1618
Because the instruction tgtInstr isn't verified to be an LLIL_JUMP so the

Fixed in 3.4.4158-dev.


Question about behavior of transitive dependencies

Given a project structure like:
fizz depends on bar
bar depends on foo
My understanding is that fizz would end up with both bar and foo as subdirectories but this doesn't appear to be the case.

Is this resolved? @jackkoenig


Maybe use of LethalAPI.LibTerminal?

You can use this dependency (v1 published yesterday) in Thunderstore
https://github.com/LethalCompany/LethalAPI.TerminalCommands
It will make it much easier for you to handle terminal commands and so on.
you can see real-life implementation in my mod and repo:
https://github.com/ustaalon/LethalCompany.ExtraDays

Hi @ustaalon
Good timing, we actually have implemented already and it will be within our next update. I am using this project to teach my kids, so hopefully we have an update out soon with some new features.


Added awesome-r

Added awesome-r to "Other Awesome Lists".
(I guess, R is pretty close to data science).

exactly :+1:


feat: remove a stat info from landing page

Closes #8885

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

@rahulsiddarth Could you please add the screenshots?

Looks good, thanks for contributing

@accodes21 please do not approve pull requests without reviewing properly, this causes noise and confusing to the contributor and the maintainers

Looks good, thanks for contributing

@accodes21 please do not approve pull requests without reviewing properly, this causes noise and confusing to the contributor and the maintainers

Extremely sorry for causing any confusion, will remember not to make such mistakes again


Update README.md

Adding a extra emulator mention to the README so new users can find an up-to-date and more supported version of Citra. Lime3DS has corrected many issues with Citra, such as the audio and cutscene animation lag in games such as Fire Emblem Awakening. Makes the goal of game preservation much easier knowing the primary users who use this tool can accurately stream the games at 3DS quality which old versions of Citra couldn't do.

Hello, those claims are subjective. While a few games may work better, others may work worse. For now I prefer keeping things as they are.

Hello, those claims are subjective. While a few games may work better, others may work worse. For now I prefer keeping things as they are.

I don't really see how this effects anything you have set. It is true that many games work on Lime3DS while not working on Citra. And even with some things not working on Lime, wouldn't it still be best to display both options so the user can choose? I am not discarding your Citra fork with this pull request, it is simply suggesting an alternative to try.

Still prefer to keep things as they are. It has nothing to do with it being my fork or not.


Reenable cooperativeSettle

We commented out cooperativeSettle in https://github.com/raiden-network/raiden-contracts/pull/270
These should be changed back when re-enabling cooperative settle:
Contracts

uncomment cooperativeSettle https://github.com/raiden-network/raiden-contracts/blob/d47aa6b6adbbfc3702e2258387d7695c96101d7b/raiden_contracts/contracts/TokenNetwork.sol#L814
uncomment recoverAddressFromCooperativeSettleSignature https://github.com/raiden-network/raiden-contracts/blob/d47aa6b6adbbfc3702e2258387d7695c96101d7b/raiden_contracts/contracts/TokenNetwork.sol#L1441

Test contracts

uncomment recoverAddressFromCooperativeSettleSignaturePublic recoverAddressFromCooperativeSettleSignaturePublic

Tests

unskip all cooperative settle tests in https://github.com/raiden-network/raiden-contracts/blob/d47aa6b6adbbfc3702e2258387d7695c96101d7b/raiden_contracts/tests/test_channel_cooperative_settle.py
unskip test_recover_address_from_cooperative_settle_signature https://github.com/raiden-network/raiden-contracts/blob/d47aa6b6adbbfc3702e2258387d7695c96101d7b/raiden_contracts/tests/unit/test_unit_signatures.py#L173-L174

Note, withdraw was re-enabled by https://github.com/raiden-network/raiden-contracts/pull/711 . coop seetle is redundant with withdraw, since we can implement it with two withdraws done by a proxy smart contract. This is not really necessary anymore.


Feature Request: add a timeOut for method confirm(), dismiss()

The problem
The alert can appear in more than 4 seconds, and would be great to extend this calling the method
Details
If necessary, describe the problem you have been experiencing in more detail.
Tell us about your environment

Selenide Version: 6.2.0

thanks for the greate product

SelenideTargetLocator implements that feature

implemented in https://github.com/selenide/selenide/pull/1846.
will be released as Selenide 6.6.0


ItemIngredients not compatible with AppleCore

ItemIngredients overrides onItemUseFinish and calls the int, float version of FoodStats.addStats, which bypasses AppleCore's OnFoodEaten event (which expects the ItemStack version of FoodStats.addStats to be called instead).
As far as I can tell, the entire onItemUseFinish override is unecessary, as it's identical to the implementation in the base class that it extends, apart from the version of addStats that is called. If I'm not missing something, the fix could be as simple as removing the implementation of onItemUseFinish in ItemIngredients.
Relevant code:

https://github.com/PenguinSquad/Harvest-Festival/blob/6adc58e18004bad8b106aec7819acd640676f121/src/main/java/joshie/harvest/cooking/item/ItemIngredients.java#L99

yea i know. It never used to extend itemfood, and i made it do that so i
didn't have to do special support for applecore.  I guess i accidentally
left that method in =p


NullReferenceException when loading sound using android asset name

This line causes an NullReferenceException on android when trying to load an asset sound. player is not set but referenced when accessing Loop

Good spot! No clue how we missed this one


Max group by buckets - Prevent queries that would create too many buckets (e.g. group by time(1s) over 1y of points)

#6024

I believe that this bespeaks a design issue. I cannot understand why you would need more buckets in RAM than the number of columns being reported x2. You have your current row plus the previous row data that may be necessary to pull from. The data should be streaming out after it's processed. What is the reason that "over 1y" would make a difference? I don't think it should.


Unfriendly error message printed when user just intend to check usage

Run poudriere first time without root will produce:
[yunchih@FreeBSD ~]$ poudriere image -h
mkdir: /usr/local/poudriere: Permission denied
/usr/local/share/poudriere/common.sh: parallel_shutdown: not found

Obviously, poudriere needs privilege to create that directory, but the above parallel_shutdown: not found error might be confusing for new users.  Why not source the necessary files in exit_handler:
diff --git a/src/share/poudriere/common.sh b/src/share/poudriere/common.sh
index f2df1da..006f45f 100755
--- a/src/share/poudriere/common.sh
+++ b/src/share/poudriere/common.sh
@@ -1091,6 +1091,8 @@ exit_handler() {
        # Ignore SIGINT while cleaning up
        trap '' SIGINT

+    . ${SCRIPTPREFIX}/include/parallel.sh
+
        if was_a_bulk_run; then
                log_stop
                # build_queue may have done cd MASTERMNT/.p/pool,

Interestingly, the ports.sh script can run all the way to printing "usage" before executing exit handler, while the image.sh script jump directly to exit handler before it can source include/*.sh.
poudriere image -h: http://ix.io/Cfl
poudriere ports -h: http://ix.io/Cfm
In addition, maybe it is better to run . ${SCRIPTPREFIX}/common.sh after getopt, so user can avoid running common.sh if they just want to check usage?

The mkdir isn't even needed anymore, it's a leftover from other refactoring. Will remove it.

In addition, maybe it is better to run . ${SCRIPTPREFIX}/common.sh after getopt, so user can avoid running common.sh if they just want to check usage?

The getopts line may depend on defaults set by common.sh so it must come after.
The difference with ports vs image is that image runs with set -e and exits immediately on the mkdir error.


weekdays misbehaviour if using just [4,5,6,0]

Hi, it seems to me that weekdays prop doesn't behave correctly if you just show numbers after 4 as in:
   :weekdays="[4,5,6,0]"
   :weekdays="[5,6]"

(but seems fine with "[4,5,6]")
A codepen is here.

Here clearly names are not sequential and are not correct.
Sometimes the weekday names gets scrambled:
"[6,0]" => missing header
"[5,6,0]" => you just see friday
Did I miss something?

@sandroden Thanks for bringing this to my attention. I should have time to look into this on the wekend. Thanks.

Fix will be in v1.5.1 - sorry for the delay


fix(lint): map grunt lint to coffeelint to enable both

Summary
Maps grunt lint to grunt coffeelint so both commands work
resolves #245

Coverage remained the same at 97.652% when pulling 2791753fb6a2beeeea6232a0ec79ed35a99cd1e5 on 245-correct-the-lint-command into 9cf897354f3d0eab7b8bb74eb2428543e766005e on master.


Update ass.ts

app.use('/:resourceId.*', (req: Request, res: Response, next: any) =>
access direct files with https://example.com/xxxxxxx.ext

Opting to close this for now as ass 15 changes pretty much everything


feat(404): base for not found page

☐☐☐☐☐☐☐☐☐☐☐☐☐☐☐☐☐
fixes https://github.com/robinjoseph08/pokedextracker.com/issues/43
still needs functionality. DO YOU GET IT ^

updatedddddd


There is no documentation on how to add rows to the database

Could you please document the creation and updating of rows to the database?

@finitelife is correct! I'm going to close this issue but feel free to open a new one if you have further questions 🙏


[DC-199] Remove empty tables from dataset preview combobox

Before: There were two groups of tables (with and without data) listed in the dataset preview combobox

After: Only tables with data are listed

I'm going to go ahead and merge this since we have follow-on tickets to address the flaky tests


merge from template-coveralls

package.json

chore(deps): add ^10.12.0 remove ^10.11.3 (devDependencies.npm-pkgbuild)

.github/workflows/ci.yml

chore: (jobs.test.strategy)

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v6.1.0
GitHub release

Your semantic-release bot :package::rocket:


provide 4 new annotations to better handle backend certificates and Host header

Is your feature request related to a problem? Please describe.
I have a problem with how redirects are handled (or not;-) by AGIC. Imagine you have AGIC that is configured for abc.def.com host and port 443 and a AKS backend service that listens on host <IP_ADDRESS>:8443 it has a cert with CN set to service.internal.net (a private self-signed cert).
In order to set up e2e tls. I need to set backend-hostname to service.internal.net.
If I understand correctly AGIC will create Host header by combining backend-hostname with backend service port in my example it would be service.internal.net:8443. Now the backend can be a commercial of the shelf application that can't be customized to process the x-original-host and x-forwared-port headers, so when it does a redirect it returns service.internal.net:8443 as location header and a user gets an error in the browser...
I understand that you plan to address it somehow with rewrite rules but maybe you may consider a simpler solution
Describe the solution you'd like
I'd like to have 4 annotations

appgw.ingress.kubernetes.io/backend-host-server-name: abc.def.com
appgw.ingress.kubernetes.io/backend-host-port-number: 443
appgw.ingress.kubernetes.io/backend-CN: backend-cert-cn
appgw.ingress.kubernetes.io/backend-use-SAN: true/false (false by default)

The values from the first 2 annotations are used to form the Host header "Host abc.def.com:443" the backend-CN is the CN that must matched in certificate of backend and if backend-use-SAN is true the App Gateway checks SAN section of a backend's certificate.

I have similar use case where I'm trying to get minio presigned urls to be rewritten to backend hostname and port to be valid. I was able to accomplish this with Nginx Ingress Controller using nginx.ingress.kubernetes.io/upstream-vhost annotation, but no luck with Application Gateway Ingress Controller. I was trying backend-hostname annotation, among some other solution with no luck.
https://azure.github.io/application-gateway-kubernetes-ingress/annotations/#backend-hostname


Disable the syntax highlighter

Pasting 2-10MB minified JS file will likely hang the whole webcrack tab because of the highlighter taking so long to do syntax highlighting, please add option to disable it.

yeah good idea
but I think that's generally because of monaco-editor, on a sort of recent phone it takes over 30s to paste 100kb without syntax highlighting
codemirror and <textarea> are pretty much instant

yeah good idea but I think that's generally because of monaco-editor, on a sort of recent phone it takes over 30s to paste 100kb without syntax highlighting in <textarea> pasting is a bit faster but it gets stuck when scrolling codemirror and ace seem to perform the best

I tried to follow beautify approach and disable "word wrap", and holy it increases performance by 10-fold:
https://beautifier.io/?without-codemirror
Having both syntax highlighting and word wrap disabled allowed me to paste 2MB text file in... 1s, which is a massive improvement from previous, 30s-50s and sometimes timeout.

I tried to follow beautify approach and disable "word wrap", and holy it increases performance by 10-fold:

beautifier.io is way slower for me (8MB file):
https://github.com/j4k0xb/webcrack/assets/55899582/8f952f26-f069-40d5-8bed-691d1f526c0e


[BUG] Remove incorrect warning for filter_apps argument

Describe the bug
#1300 modified the python tool to raise an error for enum creation from invalid string values.
However, a stale block that raises a warning for invalid string values was not removed. This results in an incorrect warning when using filter_apps=QualFilterApp.TOP_CANDIDATES, (which is a default and valid value).
Steps/Code to reproduce bug
https://github.com/NVIDIA/spark-rapids-tools/blob/df44de8df83989cab70edbcb3da59e544f3387c5/user_tools/src/spark_rapids_pytools/rapids/qualification.py#L142-L151
Expected behavior
The above warning should be removed

Thanks for filing this @parthosa! I also encountered this when testing with --verbose.


Support building with GPU support even when CUDA is not currently available

Currently we use this conditional to determine whether to build with GPU support:
https://github.com/CharlesShang/DCNv2/blob/c7f778f28b84c66d3af2bf16f19148a07051dac1/setup.py#L33
But it would be nice to be able to build the library with GPU support even in environments where CUDA is not available.  In particular, I'd like to be able to do this while building a docker image.
If this sounds like a reasonable change, I'm happy to submit a PR for it.  I think it would look quite similar to https://github.com/pytorch/vision/pull/927.

Hi, I met the same problem. Did you solve it? It would be better to be able to build on a login-node without GPU and to run on a gpu-node

@zhaotf16 I solved it by modifying the conditional to allow being overridden by a FORCE_CUDA environment variable, as in the torchvision commit I linked to.  (I did this only in my copy of the repo and didn't submit a PR for that change.)


Added more cmdlets and classes to ps1 patterns

also removed a pattern from Java that is shared with ps1 files
sample used is the ps1 file found here: https://cccs.atlassian.net/browse/AL-322

Codecov Report

Merging #17 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   60.72%   60.70%   -0.02%
==========================================
  Files         115      115
  Lines        9845     9836       -9
==========================================
- Hits         5978     5971       -7
+ Misses       3867     3865       -2

Impacted Files
Coverage Δ

assemblyline/common/identify.py
0.00% <ø> (ø)

assemblyline/odm/randomizer.py
94.20% <0.00%> (-1.45%)
:arrow_down:

assemblyline/remote/datatypes/__init__.py
69.49% <0.00%> (-0.51%)
:arrow_down:

assemblyline/remote/datatypes/queues/comms.py
77.77% <0.00%> (-0.49%)
:arrow_down:

assemblyline/filestore/transport/azure.py
61.61% <0.00%> (-0.39%)
:arrow_down:

assemblyline/datastore/stores/es_store.py
70.87% <0.00%> (-0.05%)
:arrow_down:

assemblyline/run/pubsub_reader.py
0.00% <0.00%> (ø)

assemblyline/datastore/helper.py
26.11% <0.00%> (+0.04%)
:arrow_up:

assemblyline/run/cli.py
24.54% <0.00%> (+0.04%)
:arrow_up:

assemblyline/common/backupmanager.py
60.41% <0.00%> (+0.25%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62e8fb...7315d94. Read the comment docs.


Fix active tab bottom border

Fixes https://github.com/dperrera/hyperterm-material/issues/6.
I'm not sure if the classes were updated when HyperTerm became Hyper, but this appears to fix the active tab bottom border issue.

Thanks @lukasolson!


Ошибки тестирования пакета для chocolatey

Были выявлены ошибки (https://chocolatey.org/packages/font.gost2.304-81.install):

[x] This package uses a helper function that requires administrative permissions, the tag 'admin' should also be in the nuspec.
[ ] The iconUrl should be added if there is one. Please correct this in the nuspec, if applicable.
[x] The nuspec has been enhanced to allow packageSourceUrl, pointing to the url where the package source resides. This is a strong guideline because it simplifies collaboration. Please add it to the nuspec.
[x] docsUrl - points to the location of the wiki or docs of the software
[ ] mailingListUrl - points to the forum or email list group for the software
[x] bugTrackerUrl - points to the location where issues and tickets can be accessed
[x] projectSourceUrl - points to the location of the underlying software source
[x] The package maintainer field (owners) matches the software author field (authors) in the nuspec. The reviewer will ensure that the package maintainer is also the software author.
[ ] Automated testing can also fail when a package is not completely silent or has pop ups. A package that cannot be made completely unattended should have the notSilent tag. Note that this must be approved by moderators.

(В продолжение #149)

[ ] This package uses a helper function that requires administrative permissions, the tag 'admin' should also be in the nuspec.
[ ] The iconUrl should be added if there is one. Please correct this in the nuspec, if applicable.
[ ] The nuspec has been enhanced to allow packageSourceUrl, pointing to the url where the package source resides. This is a strong guideline because it simplifies collaboration. Please add it to the nuspec.
[ ] docsUrl - points to the location of the wiki or docs of the software
[ ] mailingListUrl - points to the forum or email list group for the software
[ ] bugTrackerUrl - points to the location where issues and tickets can be accessed
[ ] projectSourceUrl - points to the location of the underlying software source
[ ] The package maintainer field (owners) matches the software author field (authors) in the nuspec. The reviewer will ensure that the package maintainer is also the software author.
[ ] Automated testing can also fail when a package is not completely silent or has pop ups. A package that cannot be made completely unattended should have the notSilent tag. Note that this must be approved by moderators.

packageSourceUrl отсутствует в xml схеме nuspec. nuget ругается при сборке. Поэтому добавил, но в комментарий.

Самая серьёзная проблема осталась с "полностью тихим" пакетом. Интерфейс для msi менял сознательно, чтобы обеспечить установку под UAC, потому как choco не запрашивал UAC...
Стоит попробовать полностью отключить интерфейс при установке и удалении msi пакета, и протестировать этот пакет из консоли с правами администратора...

Да, под администратором /quiet /qn вполне можно применять для msiexec...


[BUG] Paste pictures Ctrl+V always at the end

For Bug Reports
BookStack: v0.17.1 to v0.17.4
PHP: PHP 7.0.22-0ubuntu<IP_ADDRESS>
MySQL:  5.7.19-0ubuntu<IP_ADDRESS> (Ubuntu)
OS:  4.4.0-87-generic #110-Ubuntu x86_64 x86_64 x86_64 GNU/Linux:
Expected Behavior
If I paste pictures with CTRl+V I expect them to be pasted at the location where my mouse course is.
Actual Behavior
However the pictures I paste appear at the very end of my editing window.

Confirmed to be an issue on the WYSIWYG editor. Not a problem on the markdown editor. Will mark for next bugfix release.


Update index.md

typo mistake

Thank you!!

I thank you & @pocketbase for your products! I really love them.


Is there a way to disable component recycling?

In my application, I'm using xterm, and I'm mounting it to a referred component on the componentDidMount event.
The application can handle several tabs that are looped through .map, and when a tab closes preact tries to reuse the <Terminal /> component, which looks all the same to him(since he just diffs the JSX part without the terminal element I believe, correct me if I'm wrong).
The problem is that every terminal is linked to a shell, and when it tries to reuse the terminal component it reuses the shell too, so closing a tab will then mess up all the related terminals and shells.
My code is public on GitHub if you want to read it or give it a try feel free to do it.
A critical part of it could be the willReciveProps event that I'm using to prevent from re-rendering when cols, rows and selection of the terminal updates.
Here are the pieces of code:
<Terminal />
<Terminals /> (loop)

Fixed.

@LucaT1 How did you solve it? By passing the key prop when instantiating <Terminal /> components?

Yeah, but i don't know why it wasn't working before

Using key doesn't disable component recycling. key={Date.now()} for example makes your component be recreated on each re-render. Also "component recycling" in preact actually means "reusing dom nodes from components".
@LucaT1 in your case, indeed, having unique keys per terminal should help you.

Yeah in fact it worked. Tough i may have named the issue wrongly


Type hints for optional None values

Currently, we employ three styles to describe parameters that might be assigned as None:

Union[str, None]
Optional[str]
str | None

I personally prefer style 3. However, since this style is only supported in Python 3.10 and later, I'd like to gather the team's opinions on the preferred style. I'm interested in submitting a PR to address this issue in our codebase once we reach a conclusion.

Hey! I feel onboard with option 3! I think the only place we can't currently do it is in _tbl_data.py, since functools.singledispatch does some dynamic type annotation inspection, which breaks in that case.
In any event, a refactor that did (3) anywhere possible would be a huge contribution! Thanks for taking time to emphasize the value of consistency in the codebase :)

@machow Thank you for your response. Another question arises: Do you think we could use native data structures for type hints now? For instance, replacing typing.List with list.

Yeah, I think that now we are 3.9+, using list[...] should work. AFAICT the easiest way to check is to look up the python docs entry for the corresponding typing class, and see if there's a deprecation note:
https://docs.python.org/3/library/typing.html#typing.List

Thank you for pointing out the related docs. I'll start working on a PR to update our type hints using the new style.

I'll go ahead and close this discussion since the resolution has been implemented in the merged PR #315.


feat: ✨ provide accessible solution for validation

Pull Request
📖 Description
This PR provides a new component <syn-validate> that may be used to wrap native input elements and SynergyFormElements to provide inline validation.
🎫 Issues
Closes #412
Closes #623
👩💻 Reviewer Notes

📑 Test Plan

✅ DoD

[x] I have tested my changes manually.
[x] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[ ] I have added documentation to the DaVinci migration guide (if need be)
[x] I have made sure to follow the projects coding and contribution guides.
[x] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[x] I have used design tokens instead of fix css values

Currently if using multiple syn-validate's + syn-input's with the inline validation, only the first invalid input shows it's inline error message.
Is this our wanted behavior, so we have the same behavior as the standard browser tooltip?

  <form>
    <syn-validate class="validation-inline" inline >
      <syn-input label="Inline Validation" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-2" inline >
      <syn-input label="Inline Validation 2" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <button type="submit">submit</button>
  </form>

Another weird behavior is when mixing syn-input's with html input's in a form and pressing the submit button.
The syn-input doesn't seem to get validated at all (no red border) and the input gets validated (even if it is the last element)
  <form>
    <syn-validate class="validation-inline" inline >
      <syn-input label="Inline Validation" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-2" inline >
      <syn-input label="Inline Validation 2" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-3" inline >
      <input type="email" value="team(at)synergy.co"/>
    </syn-validate>
    <button type="submit">submit</button>
  </form>

Currently if using multiple syn-validate's + syn-input's with the inline validation, only the first invalid input shows it's inline error message. Is this our wanted behavior, so we have the same behavior as the standard browser tooltip?

  <form>
    <syn-validate class="validation-inline" inline >
      <syn-input label="Inline Validation" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-2" inline >
      <syn-input label="Inline Validation 2" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <button type="submit">submit</button>
  </form>

As far as I can tell, this is the behavior that is used by shoelaces internal implementation, so we are just hooking into this. As we have to cancel the syn-invalid event to prevent the item to always get a highlight, it seems the only way to be sure that it works.

Another weird behavior is when mixing syn-input's with html input's in a form and pressing the submit button. The syn-input doesn't seem to get validated at all (no red border) and the input gets validated (even if it is the last element)
  <form>
    <syn-validate class="validation-inline" inline >
      <syn-input label="Inline Validation" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-2" inline >
      <syn-input label="Inline Validation 2" type="email" value="team(at)synergy.co" ></syn-input>
    </syn-validate>
    <syn-validate class="validation-inline-3" inline >
      <input type="email" value="team(at)synergy.co"/>
    </syn-validate>
    <button type="submit">submit</button>
  </form>

I think this stems from the issue that Shoelace components are not fully form associated controls. There are other open issues at the shoelace repo for this, like https://github.com/shoelace-style/shoelace/issues/2139. Basically they override the native form behavior to be part of the form submission. The elements are not validated in order of appearance, but but the internal shoelace logic. Most of the time this works, but there are circumstances when it does not seem to work well.

For everything that's not live, could you add a submit button?
Just tested on mobile (as I've sent the PR someone) and it's annoying to have to go intonthe field to activate it

For everything that's not live, could you add a submit button?
Just tested on mobile (as I've sent the PR someone) and it's annoying to have to go intonthe field to activate it

Done in latest version

Hi, I just played a little with the new syn-validate component and want to share my feedback with you:

Works quite nicely with HTML5 client side validation and I like the feature that you can determine for which events the validation message is shown.
I noticed that when I use on=live the focus outline stays blue even when the value is invalid and only turns red after losing focus. I'd expect to turn red immediately on input.

Aside from this "technical" feedback, here some further thoughts that would make syn-validate better suited for our application (SICK ID):

For our tech-stack (angular) it would be nice to have a way to trigger the validation/display of the validation message via javascript. This way the syn-validate component could better be integrated with angular's validation module. (Or maybe there is already a way and I haven't seen it yet?)
Would it be possible to make the entire container of the inline validation message customizable? In our application we don't want to show alert components but only "red text".

Thank you for all the effort.

of the inline validation message customizable? In our application we don't

Hi @huberpaSICKAG,
first of all, thank you for your input. I will have a look into it and will respond tomorrow. For Angular, maybe something like in our demo will work (here you will find the simple logic for this and there the view adjustment for this)?


[SPARK-23700][PYTHON] Cleanup imports in pyspark.sql

What changes were proposed in this pull request?
This cleans up unused imports, mainly from pyspark.sql module.  Added a note in function.py that imports UserDefinedFunction only to maintain backwards compatibility for using from pyspark.sql.function import UserDefinedFunction.
How was this patch tested?
Existing tests and built docs.

@HyukjinKwon and @ueshin I tried to be pretty conservative and only remove imports that were obviously not being used.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1728/
Test PASSed.

Test build #88547 has started for PR 20892 at commit 5214f41.

Test build #88547 has finished for PR 20892 at commit 5214f41.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88547/
Test FAILed.

Jenkins retest this please

Test build #88549 has started for PR 20892 at commit 5214f41.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1730/
Test PASSed.

Merged build finished. Test PASSed.

Test build #88549 has finished for PR 20892 at commit 5214f41.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88549/
Test PASSed.

Thanks @felixcheung and @HyukjinKwon !


fix: langfuse env setting

Langflow uses envs like LANGFLOW_*, not LANGFLOW_LANGFUSE .

LANGFUSE_PUBLIC_KEY
LANGFUSE_SECRET_KEY
LANGFUSE_HOST

thank you! this was added in the meantime


go tendermint staking: reduce DelegationsTo scanning

the escrow address is the first part of the key so we can seek to it

Also consider backporting.


brpc max_connection_pool_size not work?

I set max_connection_pool_size but not work with "options.connection_type = "pooled";",  which makes create and close socket frequently. I look at the code at inline int SocketPool::GetSocket(SocketUniquePtr* ptr) ,  the connection_pool_size used compare wit zero.

max_connection_pool_size is a soft limit which does not prevent you from creating new connections. Instead, it takes effects when a socket is returned to the pool. If the limit is reached, the socket is closed directly rather than being returned.

@jamesge oh, Thanks. I did not noticed  at there.


Job delay ignored when using batches

Laravel Version: 8.18.1
PHP Version: 7.4.13
Database Driver & Version: MariaDB / Redis
Horizon

Description:
When dispatching a queueable job directly via dispatch($job) after adding a delay with $job->delay(now()->addMinute() everything works as intended. I can see that the job will be handled by horizon after one full minute.
But when using Bus::batch([$job])->dispatch(); with the same job and added delay, the job will be processed immediately by horizon.
Steps To Reproduce:

create job class with Batchable trait and ShouldQueue interface
create new instance of said job and add delay on that object
use the Batch facade to batch that job
monitor queue progress and see that the job will be processed instantly

This is the expected behaviour. You may dispatch a delayed job that dispatches the batch if you want to delay processing all jobs of the batch.

Thanks for clarification!
For anyone finding this and implementing the suggested extra job which creates and dispatches the batch with delay:
I was now getting out of memory messages: Allowed memory size of 536870912 bytes exhausted.
I pinned it down to a call to serialize($batch->options) within the DatabaseRepository when calling dispatch() on the batch.
I think the resulting memory issue is somewhat related to this issue: #23505
I am using an eloquent model as a protected property on the new job, handed over in the constuctor.
My workaround was to not accept the model itself, but the primary key instead. Then using find in the jobs handle method.

Thanks for clarification!
For anyone finding this and implementing the suggested extra job which creates and dispatches the batch with delay:
I was now getting out of memory messages: Allowed memory size of 536870912 bytes exhausted.
I pinned it down to a call to serialize($batch->options) within the DatabaseRepository when calling dispatch() on the batch.
I think the resulting memory issue is somewhat related to this issue: #23505
I am using an eloquent model as a protected property on the new job, handed over in the constuctor.
My workaround was to not accept the model itself, but the primary key instead. Then using find in the jobs handle method.

I create pull request to fix this bug
https://github.com/laravel/framework/issues/35619#issuecomment-745494705


Bad file modes in customized shibboleth configuration

When I run the command to generate a customized config:
"docker run -it -v $(pwd):/ext-mount --rm unicon/shibboleth-idp init-idp.sh"
Some of the folders/file it generates have file modes which make them not accessible for me.
Example:
customized-shibboleth-idp/views is set to mode 640 which makes the directory not browsable.  The same thing applies to the contents of this folder as well as customized-shibboleth-idp/credentials and customerized-shibboleth-idp/webapp folders.
Was this expected behavior?
Thanks

I'm having the same issue with file modes.
(running on macOS 10.12)

Hey @sesm  and @jsandas,
Sorry, I missed this ticket. Were you able to retrieve the files by changing the permissions on the directory?
This is not expected behavior. The script probably just needs to change the privs before it finishes.

chmod -R 755 customized-shibboleth-idp/views
chmod -R 755 customized-shibboleth-idp/credentials
chmod -R 755 customized-shibboleth-idp/webapp

A quick resolution for me.

I think this has been resolved... a while ago. Thanks for the info.


Remove smps.yaml from this repo

Description
The smps.yaml has been displaced by smps.proto and sm.proto.
Expected Behavior
smps.yaml should be deleted.

@leecalcote I will work on this issue.

@Dhiraj240 thank you much. Yes, indeed. Simply that, if you would.

@leecalcote Shouldn't smps.yaml should work as an ideal input for specification ?

Yes, although, my impression was that we have accounted for each of these parameters. I could be mistaken.

Yeah, will do this

The yaml file can work as a source of truth like how should I specify my data, as in the protobuf file I have only mentioned the type of data not the format like for example of data/time.


Add sample for copying from a specific (non-default) SharePoint document library

My use case is copying files from a specific (non-default) SharePoint document library. The documentation did not help me in this regard. I propose adding something that would've helped.
I'm referring to this part of the documentation:

The sample to copy from a SharePoint site is currently only this:
POST /sites/{siteId}/drive/items/{itemId}/copy
This copies from the default "Documents" library of a SharePoint site.
Please add the sample to copy from a non-default library of a SharePoint site which would be this:
POST /sites/{siteId}/drives/{driveId}/items/{itemId}/copy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a38d3dcf-49bd-eedc-e4cf-5041af8ed7fe
Version Independent ID: 8a3d3fed-4e6c-0592-5f7c-8105365698d8
Content: Copy a file or folder - OneDrive API - OneDrive dev center
Content Source: docs/rest-api/api/driveitem_copy.md
Product: onedrive
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKe

(Or maybe wait until it's clear that it is not causing problems... see #1566)

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


Fix openAsJson

Make sure openAsJson doesn't fail when run from the command palette.
Fixes: #950

BTW, another thing I noticed — the signature should probably now make item optional.


[SMALLFIX] Do not close channel synchronously

@peisun1115 is the goal to not wait for any Netty calls?

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14692/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, test this please

@calvinjia at least for NettyPacketWriter.java, without this fix, if worker throws exception on client-side packet writer close, client will hang forever.

Got it, we may want to do this everywhere to prevent similar problems.

@calvinjia i've searched sync() in Alluxio codebase and these are the only instances relevant.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14702/
Test PASSed.


Fix version in README.md

Not sure why it wasn't up-to-date, maybe the .announce script wasn't used for the latest version?

Thank you!
.cc @shashachu


Created API documentation

I created API documentation using apipie gem and you can see it on /apipie
Please check all functionality before approve :)

THX bro


[Misc]: Odd number GPU utilization?

Anything you want to discuss about vllm.
Currently tp will not work on odd number of gpus, nor on the number that cannot divide 40 (e.g. 6 gpus). However, it is unavoidable to have these kinds of configurations in some situations.
What are some ways to keep the left-out gpu(s) from being completely idle currently? Are there any plans to solve or circumvent this problem?

Similar issue is here: https://github.com/vllm-project/vllm/issues/1399 (it is said it was fixed, but maybe only for even number of GPUs)

It seems like for multimodal with ViTs you could also just get the ViT hidden state on one unused gpu and then transfer it to the others to do tensor parallel on. This would free up having to store the ViT and its associated memory usage.


Ubuntu Lunar 23.04 playlist from HDHomeRun can't be played

Describe the bug
When I loaded my playlist IPTV from my HDHomeRun the channel reconized it the EPG works correctly but except with MPV the video did't started with player js (i have message in console about the incompatibility with the player) with html5 play the video did't started anymore (but there aren't except when i try to change of channel).
To Reproduce
Steps to reproduce the behavior:

Create a playlist from hdhomerun
Load the playlist
Choose the js player or html5 player
The video never started

Expected behavior
When I loaded my playlist IPTV from my HDHomeRun the channel reconized it the EPG works correctly but except with MPV the video did't started with player js (i have message in console about the incompatibility with the player) with html5 play the video did't started anymore (but there aren't except when i try to change of channel).
Screenshots

Desktop (please complete the following information):

snap version
OS: Kubuntu Lunar 23.04
Browser google chrome
Version last version of snap store (i try it the last relesae from this repo but it's the same thing)

Additional context
Add any other context about the problem here.

Unfortunately many video formats are not supported in js players, here it's a matter of electron/chrome. So the only solution today is to use mpv as a third party player.


Cant pull data

Describe the bug
Tried to pull national data, that made yesterday

curl -X 'GET' \
  'https://api.quartz.solar/v0/solar/GB/gsp/0/forecast?start_datetime_utc=2024-03-13T13%3A00&end_datetime_utc=2024-03-16T13%3A00&creation_limit_utc=2024-03-12T14%3A00' \
  -H 'accept: application/json'

But changing creation_limit_utc to 2024-03-12T13:00 means no data is returned

I think its in the code here - https://github.com/openclimatefix/nowcasting_datamodel/blob/main/nowcasting_datamodel/read/read.py#L485


Fixed: REPLACE action does not call replaceHref function

This left the history replacement (i.e. redirection) function nonfunctional.
Note on test: The test failed (i.e. froze) in its original state with just the action name adjusted. I set the starting path to '/' to ensure a difference between current and new path.

Available in v0.3.2 - thanks @gertsonderby


add basic support for markdown in forms

for example, the following tile.yml.
forms:
- name: my-markdown-form
  label: Markdown Form
  description: This is an example form using markdown
  markdown: |
    ![Here is a cat](https://i.ytimg.com/vi/Lf0kGBW01Vg/hqdefault.jpg)
    # Header
    **bold**
    etc
  properties:
  - name: my-prop
    type: string
    label: My Prop
    description: This is a demo property.

John, thanks!!  Love PRs.
I will definitely merge this, but I wonder if you would agree to take the parameters off the indent filter. Both values correspond to the defaults, and there is at least on other place in the template where we use the same filter without parameters, so it would be more consistent.
Let me know,
Guido.

@guidowb sure, updated as suggested - hadn't noticed its use elsewhere in the templates


Support for imports with absolute path

Due to issue #58 I found out that unfortunately imports like
import { reposLoaded, repoLoadingError } from 'containers/App/actions';

don't work with jest and produces next error:
app\containers\HomePage\tests\sagas.test.ts
  ● Test suite failed to run

    Cannot find module 'containers/App/actions' from 'sagas.ts'

      at Resolver.resolveModule (node_modules\jest-resolve\build\index.js:151:17)
      at Object.<anonymous> (app\containers\HomePage\sagas.ts:8:19)
      at Object.<anonymous> (app\containers\HomePage\tests\sagas.test.ts:7:17)

While normal imports with relative paths behave as expected. It could be problem of jest-resolve module, but we have to try to solve it inside ts-jest or find what exactly causes this problem in jest-resolve.
As always we have to start from tests for this case.

Will passing the baseUrl in tsconfig.json to jest-resolve moduleDirectories do this?

Yup, manually overriding moduleDirectories in jest-resolve module worked for me. Putting together a pull request.

I don't see anywhere this module passing options to jest-resolve. Putting the extra moduleDirectories in package.json jest object works for my case:
"jest": {
    "moduleDirectories": ["node_modules", "src"],

@mohsen1, thank you fro your investigation and moving issues to Jest itself.
I guess we have to add your current workaround to readme and close this issue, because it's not related to ts-jest.
Is it would be ok for you?

Yes. Just adding that config option works.

Closed due to #77

What if this is still an Issue?

@marcusjwhelan the best would be to create a minimal repo that reproduces this and open a new issue with a link to the repo

@kulshekhar , would this repo be too large? binary-type-tree. It really only has to do with the tsconfigs and package.json

@marcusjwhelan it's better than nothing :)
That said, the smaller a repo is, the quicker the issue is likely to be fixed

The weird thing I see in nestjs is when you use "moduleDirectories": ["node_modules", "./"], the resolution fail and throw exception, but it works when "moduleDirectories": ["node_modules", "./"]
I create two branch for it
https://github.com/chungchi300/typescript-starter/tree/use-src-path-in-config - working, src
https://github.com/chungchi300/typescript-starter - failure, using ./


[AutoRelease] t2-recoveryservicesbackup-2022-10-19-12204(Do not merge)

https://github.com/Azure/sdk-release-request/issues/3247
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1021
BuildTargetingString
azure-mgmt-recoveryservicesbackup
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3247


Default StorageClass

Hello, All,
I was wondering if a global StorageClass could be defined before the RHTAP is installed? Because during the installation the pvcs were going in a pending state as no storage class was defined. so I had to manually edit the outstanding pvcs so they could get bound to continue the installation.
https://docs.redhat.com/en/documentation/red_hat_trusted_application_pipeline/1.0/html/installing_red_hat_trusted_application_pipeline/installing-rhtap-in-your-chosen-cluster#installing-rhtap-in-your-chosen-cluster was followed for the installation.

Regards
Ashutosh

Will try to set a default StorageClass in the cluster before Installing RHTAP.
https://kubernetes.io/docs/tasks/administer-cluster/change-default-storage-class/

resolved this by making sure there was a default storageclass set.


[INLONG-8690][Security] Upgrade junit version to 4.13.1

[INLONG-8690][Security] Upgrade junit version to 4.13.1 #8690

Fixes https://github.com/apache/inlong/issues/8690

Motivation
Work around TemporaryFolder on UNIX-like systems not restricting access to created files, improving the security
Modifications
Upgrade junit to version 4.13.1 in inlong-tubemq/tubemq-connectors/tubemq-connector-flume/opm.xml
Verifying this change

[ ] This change is a trivial rework/code cleanup without any test coverage.

Documentation

Does this pull request introduce a new feature? no

The newest version is 4.13.2, and InLong has already changed to this version, so I think this PR isn't needed now.


Version bump: postfixadmin 3.0 & PHP 7

Upgrade to the recently released postfixadmin 3.0
Upgrade to PHP 7.0 using the alpine based PHP core image provided by the vendor.

Thanks!


Question for help for translation?

Hello @terjeio
I‘d like to ask, If I/we can help you, translating the Program into other languages?
Maybe you can tell, where the files are located, so that I/we could help you translating it?
Maybe there could be a „Config“ File for the name templates in the future, that could be easily edited.
I‘m not a „pro“ in this, but maybe some of these things can help.
It‘s just a thought, because for some people english it not the best solution, because they don‘t understand it...
Greets
Chris

Thank you for your offer.
Problem is it is not ready for translation yet - I have to go through all code to make it translatable by changing all translatable text to tokens or whatever they call it. I will put it on my todo list and come back to you when ready.


Update http4s-blaze-server, http4s-circe, ... to 0.21.19

Updates

org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.21.16 to 0.21.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #217.


refactor: move components, rename folders

This change is

rebased on main and resolved conflicts

Thanks @jolierabideau, looks like reviewable is holding us back


Index is required

Hi
Thank you for developing a project
It worked for me with a few changes
I am writing about a problem I encountered here
In this function create_test_run_folder we need index overwise give a this message : "message": "Index is required"
to this body I added index and fix it
{
"name": folder_name,
"projectId": self.JIRA_PROJECT_ID,
"index": 0
}

@mhsafaeii, Hi!
Thanks for the note. I fixed this in version 0.1.27 too.


Add pre-rollout Tasks

Like the post-rollout Tasks we would like to have pre-rollout tasks which are running before any Kubernetes Objects are updated

These tasks run in the "old" cli pod?

this was implemented in 6cf8f79a


Request to add f2fs support

An MX user requested this.
Seems like it should be straightforward to include
https://wiki.archlinux.org/index.php/F2FS
Gentoo suggests these kernel options: https://wiki.gentoo.org/wiki/F2FS
 CONFIG_F2FS_FS
F2FS_FS_XATTR
CONFIG_F2FS_FS_POSIX_ACL
CONFIG_F2FS_FS_SECURITY

What I can do is add the option and force people to put /boot on a different partition.

Sounds like the best option for now.

What I can do is add the option and force people to put /boot on a different partition.

Sounds like the best option for now.

I tried, GRUB install successfully but it still fails to boot.

What I can do is add the option and force people to put /boot on a different partition.

Sounds like the best option for now.

I tried, GRUB install successfully but it still fails to boot.

According to the Arch wiki, you need  'NAND-based flash memory equipped with Flash Translation Layer.' Did you test on that?

What I can do is add the option and force people to put /boot on a different partition.

Sounds like the best option for now.

I tried, GRUB install successfully but it still fails to boot.

According to the Arch wiki, you need 'NAND-based flash memory equipped with Flash Translation Layer.' Did you test on that? (just checking)

That's not my understanding, the file system should work on any support, it just takes advantage of those features or relies on them to for write distribution. I was able to format a virtual drive in VBox with this file system and copy and read files to/from it.

check the grub.cfg to make sure the UUID of the root= matches the UUID of
the f2fs partition.
On Wed, May 8, 2019 at 2:57 PM AdrianTM<EMAIL_ADDRESS>wrote:

What I can do is add the option and force people to put /boot on a
different partition.
Sounds like the best option for now.
I tried, GRUB install successfully but it still fails to boot.
According to the Arch wiki, you need 'NAND-based flash memory equipped
with Flash Translation Layer.' Did you test on that? (just checking)
That's not my understanding, the file system should work on any support,
it just takes advantage of those features or relies on them to for write
distribution. I was able to format a virtual drive in VBox with this file
system and copy and read files to/from it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gazelle-installer/gazelle-installer/issues/22#issuecomment-490608758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTAQ7PPOGEE3HA5EK5LISLPUMPA5ANCNFSM4HLRCGUA
.

Bump. Would this be a difficult thing to add for MX-19 or antiX-19?

closing.  this has been added to the installer.


data.table conversion, machine generalization, data updates

Hi Liz,
Here is the that update I promised you. Please let me know if you'd like to chat about what all I've done here.
Many thanks!

Yes, you've captured it well.

First and foremost, I'd like to make sure _data-compile.R and all the scripts it sources runs on your computer. Can you try it and let me know if you encounter any bugs?
Some 2019 to 2021 alignment has been done. For example, '08-derive-var-trip-mode-group.R' explicitly derives variables that align. However, there is yet to be a fully inventory of fields that need to be aligned.
I have a readme in the previous code folder detailing a vision for how to approach that folder. Let me know if you agree/disagree with it?
If I'm being honest, the data.table conversion is mostly preference. If I was going to be the primary person maintaining this repo, I wanted it to be data.table. Give you're news, I might not be the primary maintainer in the future, so I dont want to totally claim its because of speed and stability improvements.
I wasn't thinking about the renaming of tbi19_rmPII.
We still need the _db_connect connection script, so I'm going to add it back.

I'm going to make a handful of further refinements and push again.

@Brandon-Whited, sounds good! Honestly, I need to get into data.table because of the speed improvements. The time difference from dplyr is noticeable on my end.
For another time, I can help with variable aligning. I've done some of that work with the EV report, but it would be nice to have it centralized here.


fix: use goBack when navigating to More Feature page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43755
PROPOSAL: https://github.com/Expensify/App/issues/43755#issuecomment-2176069089
Tests

Go to https://staging.new.expensify.com/home
Tap profile icon -- Workspaces -- Workspace
Tap more features
Toggle on distance rate
Tap settings
Tap more features link
Tap app back button

Verify: From more features page tapping back user must be directed to settings page

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to https://staging.new.expensify.com/home
Tap profile icon -- Workspaces -- Workspace
Tap more features
Toggle on distance rate
Tap settings
Tap more features link
Tap app back button

Verify: From more features page tapping back user must be directed to settings page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome
aweb.webm

iOS: Native

https://github.com/Expensify/App/assets/165644294/7a34035f-4ce4-447e-8839-e79a74e5d85a

iOS: mWeb Safari

https://github.com/Expensify/App/assets/165644294/c41d4e3b-fe5a-4212-8736-8899318489a4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/165644294/c829171e-30d9-474b-b37f-9af9af41812b

MacOS: Desktop

https://github.com/Expensify/App/assets/165644294/cccf165f-c6f8-40fe-9ec8-1593b53f4175

Will review this today/tomorrow.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/3069065/d1007d31-61ed-4f66-8ff5-ddff6c926e26

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/dcecb3e0-6fe5-44ac-bc46-9362aef672f7

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/40a816ca-580c-4676-939f-4829d64c4d8a

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/1bff4b49-72cb-43b8-88df-c08485575a64

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.4-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


HDMF LOAN PDF Report as of march 2016

wala branch name all affiliates
pa export to excel.
-wala series # ang PDF report sa Big Italian Serving - CDO
-dapat full name ang m reflect sa report for confirmation s actual reporting (all branches)
-wala series # all branch sa dulcinea

@FNCGROUP : ano ang series #?

@FNCGROUP : ready for review.

@FNCGROUP : ready for review


Nicknames not updating properly

I have noticed in my server that the nickname of the user which appears in the beginning of the thread is not up to date with the user's current nickname. Having done some tests on it myself, I can also confirm that it doesn't update properly when I change my own nickname and message the bot. To me, it looks like a caching issue, and I'm curious to know why the nickname isn't being fetched from Discord's API.

I think you need to restart bot and after i think nicknames will be updated

@Immortalizd Did you enable the Server Members list privileged intent for your bot application? If not, your bot will not receive the members list, which means the vast majority of updates relating to server Members will not be received by the bot, leading to data being outdated.

@Immortalizd Did you enable the Server Members list privileged intent for your bot application? If not, your bot will not receive the members list, which means the vast majority of updates relating to server Members will not be received by the bot, leading to data being outdated.

Sorry for the very late reply, but yes, I have done that. The bot still doesn't update the nicknames.

@Immortalizd I tested it and I couldn't reproduce this, does that still happen? If yes, what's your modmail version?