Development setup not working. App doesn't start and listen at 8080

The development setup is not working for me. This is the log I get for the production environment script :
Log :
karuppiah@karuppiah ~/F/Mail-for-Good> export NODE_ENV=production ; ./node_modules/pm2/bin/pm2 start server/index.js --node-args=server/feedback-consumer/consumer.js --no-daemon
pm2 launched in no-daemon mode (you can add DEBUG="*" env variable to get more messages)
2017-07-16 10:08:58: Launching in no daemon mode
2017-07-16 10:08:58: [PM2] Starting /home/karuppiah/FOSS/Mail-for-Good/server/index.js in fork_mode (1 instance)
2017-07-16 10:08:58: Starting execution sequence in -fork mode- for app name:index id:0
2017-07-16 10:08:58: App name:index id:0 online
2017-07-16 10:08:58: [PM2] Done.
2017-07-16 10:08:58: ┌──────────┬────┬──────┬───────┬────────┬─────────┬────────┬─────┬───────────┬──────────┐
│ App name │ id │ mode │ pid   │ status │ restart │ uptime │ cpu │ mem       │ watching │
├──────────┼────┼──────┼───────┼────────┼─────────┼────────┼─────┼───────────┼──────────┤
│ index    │ 0  │ fork │ 15788 │ online │ 0       │ 0s     │ 14% │ 25.1 MB   │ disabled │
└──────────┴────┴──────┴───────┴────────┴─────────┴────────┴─────┴───────────┴──────────┘
2017-07-16 10:08:58:  Use `pm2 show <id|name>` to get more details about an app
2017-07-16 10:08:58: [--no-daemon] Continue to stream logs
2017-07-16 10:08:58: [--no-daemon] Exit on target PM2 exit pid=15778
2017-07-16 10:08:58: [STREAMING] Now streaming realtime logs for [all] processes
10:08:59 0|index    | Feedback consumer started: watching for feedback messages (bounces, complaints, etc) from SQS
10:08:59 0|index    | (node:15788) DeprecationWarning: Using the automatically created return value from client.query as an event emitter is deprecated and will be removed in<EMAIL_ADDRESS>Please see the upgrade guide at https://node-postgres.com/guides/upgrading

@zhakkarn @ZaynMalloc Is it working for you guys ? I tried in staging and even in master branch. Both of them don't work for me

Okay, looks like there have been some changes in the package.json file and I removed the node_modules folder and did a clean npm install
But even now, the start script doesn't work and also, the dev script did start the app but says URL not found for /login and other URLs too

Can you let me know your Node version?

I bumped it up to 8.1.3 and did a clean npm install

Can you paste the error when you run 'npm run dev'?

It doesn't show any errors in the console, or I would paste it here. It only showed in the browser that the page is not found. No error or any other log in the console

I'm not able to reproduce this - I've used both Docker and npm run dev. @zhakkarn have you encountered anything like this?

I've changed the 'npm start' script as it shouldn't really use a process manager.
Double check you're running both redis & postgresql as services. Alternatively, docker-compose will handle this for you.

Yes, I double checked. The thing is, I don't get any errors too.
The thing is, I recently dropped my database to reproduce an issue in the repo for development setup. The issue was relating to an error about a relation not existing. That's the only thing I did. I did it again now and created a new database for the app, but still same behavior. You have to drop your database and create a new one to reproduce this bug (and the old "relation doesn't exist" bug still seems to exist for the start script but not for the dev script)

Also, for the "relation doesn't exist" error, if I run dev script first and then the start script, I get rid of those errors. This happened last time too

But last time, the app worked and served pages and did stuff. It doesn't work this time though

Thanks @karuppiah7890 - I've confirmed this bux and am working on a fix.
It is related to newer versions of npm.

This was related to #https://github.com/npm/npm/issues/17708, the nested node_modules folder in socket.io-client was not being handled by NPM v5.0 correctly.
I think it's something to do with the lockfile, but it's all very unclear. By some manner of magic, I think this is now fixed.

@AndrewGHC Uh, I don't get you exactly. I will check more about the npm bug and about the exporting you just mentioned. I thought having the socket.io-client module explicitly was the only way to get it to work.
And by the way, I think you mixed up #167 and this ( #166 ) issue and closed it without talking much about this issue

The socket.io-client module is included with the socket.io library. It is nested within this module's node_modules directory.
I did mix it up a bit with this issue. This one is also now fixed.
Please try out the latest staging branch and let me know if https://github.com/freeCodeCamp/mail-for-good/issues/167 persists.

@AndrewGHC Yes, I did see that in the socket.io repo issue you referred and checked it in my node_modules folder inside socket.io module. But I didn't know about exporting and stuff though.
And yes, I just tried it out. Still some issues due to unavailability of development dependencies. Some weird npm issues. I mentioned it even in #167 too

npm ain't installing the development dependencies

I just cloned the repo to try to make a contribution, and am running into the same issue. The server will start and serve pages, but I cannot logout/login, and the current user is "undefined." Also, adding a list seems to be broken.
Ubuntu 16.04
Node 8.1.3
NPM 5.0.3

@ZackWard Yes, sorry about that. The issue is regarding some login/logout thing in the dev mode, from what I see (I just tried it out too). I just found a workaround for you to start developing. First run the application in production mode like this :
$ npm run build
$ npm start

And then use the application in the browser and login. After this, don't logout. Now stop the npm start process with Cmd/Ctrl + C and then do npm run dev and you should be able to see the app already logged in and you can start developing now

@ZackWard The new version of NPM threw a bit of a wrench into the works, a few issues appear to have emerged. Next week I'll do another fresh install on an Ubuntu VM to debug this.

Or try it in a Ubuntu Docker container :)

Hey guys.
Just installed the app myself and can confirm the login/logout issue is still happening.
Any ideas when this will be fixed?

@omulmicsinegru Can you give more detail ? Logs and what error you saw in the browser, may be a snapshot

@karuppiah7890 sure thing.

Okay, so you don't get the Google login screen at all.
What do you get in the console ? Please paste the log

this is what i get in the terminal:
Mateis-Mac:Mail-for-Good matei$ npm run dev

><EMAIL_ADDRESS>dev /Users/matei/Work/GitProjects/Mail-for-Good
> DEV_SEND_RATE=200 NODE_ENV=development node server/index.js

Clickthrough tracking: Make sure that geoip data has been downloaded:
   $ cd node_modules/geoip-lite
   $ npm run-script updatedb

  ############################
  #   Mail 4 Good started    #
  ############################
  # Port: 8080
  ############################

(node:442) DeprecationWarning: Using the automatically created return value from client.query as an event emitter is deprecated and will be removed in<EMAIL_ADDRESS>Please see the upgrade guide at https://node-postgres.com/guides/upgrading
webpack: wait until bundle finished: /index.html
webpack built a0e0bd16e21712dc9a7b in 16823ms

webpack: Compiled successfully.

@karuppiah7890 I don't know where the logs are. Can you please tell me so i can paste those as well?

@omulmicsinegru I was asking for the above logs only actually :) Okay, can you check the Network logs in the browser and also check the Console tab for errors by refreshing the page ?

And do mention the node and npm version using this
node --version
npm --version
:smile:

@karuppiah7890 the versions

and the network error

@omulmicsinegru Ah. It's the npm version I think ? I had issues when I used v5.3.0. Try using v5.0.3. I have to update my local repo and try too. Been long since I used the App

@karuppiah7890 thanks for the help. I'll downgrade and try again.
Off-topic: I took a look at the repo and haven't seen alot of activity lately. Is help still needed?

@omulmicsinegru Trust me, we need all the help we can get. Softwares can always be made better :smile: Also, we have a lot of issues you can check out. There are bugs, and a lot of feature requests

@karuppiah7890 thanks for the answer 😄  i'll take a look an help where i can.
Tried it with npm v5.0.3.. same error 😢

That's bad. Did you remove the node_modules folder and reinstall all the modules ? If you have done that, then I think you might be facing the same issue as @ZackWard who commented the same.

I will try a fresh install in my PC and get back to you :smile:

thanks.

@omulmicsinegru I am getting the same issue too
cc @AndrewGHC
Also, I don't see any package-lock.json file which should actually be included in the git repo. What version do you guys use ? cc @zhakkarn @AndrewGHC

The issue exists with the dev script only. the start script works for me

Alright, I don't like my answer but here it is :
The problem comes partly from the webpack-dev-config as it serves you the react app before you can authenticate yourself. Normally you query localhost and you get the redirected by the backend app on the login page then you get the front end app served, overwriting the URLs.
So I've put the public path of the frontend app from '/' to '/dist/' in order to get served the login page if I query "localhost:8080/" but I get endlessly redirected to "/login". I don't know what causes this infinite loop of redirects. All I know is that this loop only exists if the env variable is set at "development".
I'm giving up on this issue (for now) and will keep on the back of my head in case I stumble upon the line which checks for the dev environment then cause this infinite redirection.
As for now, a simple workaround would be to start MfG with "npm start", login, shut down the app then run "npm run dev"


Consider providing RedisConnectionRepository and RedisUsersConnectionRepository officially

Thanks for working on creating such a nice project!

Hey, I created a pull request which implements this, right here.
The Redis implementations of the ConnectionRepository and UsersConnectionRepository uses spring-data-redis-1.7.0.RC1 because that one introduces JPA repositories for Redis, which is awesome!
So I'm hoping they'll merge that PR into the next version of Spring-Social 😄


[Comments] Handle new line mix betweeen \n and \r\n in the code on CommentedCodeAnalyzer

when code is generated code or being read by some tool may cause multiple different line endings, so can't rely on PHP_EOL, use \r?\n regex instead,
see https://3v4l.org/Y8pSD
The behaviour is same with Rector's NewLineSplitter https://github.com/rectorphp/rector-src/blob/a16a04d0bc90df11918efd4b7fc117a9e3dcc1c3/src/Util/NewLineSplitter.php#L15-L23

All checks have passed 🎉 @TomasVotruba I think it is ready.


Originally posted by @777777dl in https://github.com/0xBlockchain/anchor-token-contracts/pull/1#pullrequestreview-931112865

https://github.com/TheAlgorithms/Javascript/actions/workflows/Ci.yml/badge.svg?branch=0Zeta%2Ffix-prime-check&event=page_build

Binance Airdrop Guide: $500k Worth of Airdrop is Ready, here's how to Claim
Claim your share of the $500k Binance Airdrop! As the year comes to an end, we're giving away $500 in BNB to celebrate. Follow the steps above to secure your tokens. Don't miss out on this festive giveaway!

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Winners: @


feature: 支持 GSE 2.0 证书密码文件配置 (closed #1546)

Codecov Report

Merging #1547 (ba37e71) into v2.3.2-dev (6784a5c) will decrease coverage by 0.03%.
The diff coverage is 30.00%.

@@              Coverage Diff               @@
##           v2.3.2-dev    #1547      +/-   ##
==============================================
- Coverage       73.36%   73.33%   -0.03%
==============================================
  Files             387      387
  Lines           26060    26069       +9
==============================================
- Hits            19120    19119       -1
- Misses           6940     6950      +10

Impacted Files
Coverage Δ

apps/backend/agent/artifact_builder/base.py
92.85% <ø> (ø)

.../agent_adapter/config_context/context_dataclass.py
95.20% <ø> (ø)

...eps/agent_adapter/config_context/context_helper.py
30.98% <12.50%> (-2.35%)
:arrow_down:

apps/backend/agent/artifact_builder/agent.py
100.00% <100.00%> (ø)

apps/node_man/constants.py
96.34% <100.00%> (+<0.01%)
:arrow_up:

... and 3 files with indirect coverage changes


can't create relationships from indicator to observ data!

https://github.com/STIX-Modeler/UI/pull/29/files

please feel free to submit pull requests in the future. thanks!


PL-11711 remove the old category property from the post request and fix displayName and description now being an object with en and nl translations

Task linked: PL-11711 lvl cannot create components


chore: add injection framework

Interesting, the test Cross-origin set-cookie seems to be failing consistently on this but I don't see why.

Interesting, the test Cross-origin set-cookie seems to be failing consistently on this but I don't see why.

The test was bad. It captured the first response which, because we evaluate something else before now, wasn't the response we were expecting. It passes now with a simply response check.


Remove "Recommended" column from Fare Calculator

Summary of changes
Asana Ticket: 🎫 Trip Planner | Eliminate CharlieCard - CharlieTicket/Cash differential
Remove "Recommended" column from Fare Calculator after the fare transition on 9/1.
Depends on https://github.com/mbta/dotcom/pull/602

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

Is this rebased after my fare mapper work? I was wondering if by merging two fare matches into one, this column would automatically go away?

@amaisano The column does not automatically go away.

@thecristen Well this section already uses empty divs that way, that seems to be how it's designed. I also started with using css more, but the design calls for the columns of the first table to line up with the ones on the second.

@thecristen Well this section already uses empty divs that way, that seems to be how it's designed. I also started with using css more, but the design calls for the columns of the first table to line up with the ones on the second.

Oh... I probably disliked the markup structure then too! Otherwise looks 👍🏼


vmnames not matching .json config name

win2012r2-datacenter.json: "vm_name": "win2012r2-datacenter-ssh"

Thanks for the heads up. I was really sloppy. My apologies.


Use node 20

Sumary of the issue
Node 16 has reached his end of life, and GitHub recommends to use Node 20.
cc: @everlytic

Any updates on this topic? Would be happy to see an update :)


fix: format js code snippets

Description

Format JS code and wrap in liquid tags so they display as code blocks.

Testing required outside of automated testing?

[X] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.33.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cannot specify -Dorg.gradle.jvmargs=-Xmx1g on Windows

While trying to run any gradle command with the JVM options specified, gradle build fails with the following message:
Task '.gradle.jvmargs=-Xmx1g' not found in root project '<project_name>'.`

The same command works perfectly fine in Linux and WSL2.
Expected Behavior
Gradle JVM should be configured with the passed properties.
Current Behavior
Gradle build fails with `Task '.gradle.jvmargs=-Xmx1g' not found in root project '<project_name>'.``.
Context
I'm trying to configure Gradle JVM with more memory on Windows.
Steps to Reproduce
See https://github.com/xSAVIKx/gradle-win-jvm-issue
Your Environment
Windows build scan URL: https://scans.gradle.com/s/bteby3p7h3vx2
WSL build scan URL: https://scans.gradle.com/s/kxyzzzrkjax56

Looks like the issue is related to PowerShell usage. For some reason -D in PowerShell behaves in some odd way.
The option works fine with cmd.exe.
The workaround for PowerShell is to quote the parameter: .\gradlew.bat "-Dorg.gradle.jvmargs=-Xmx1g".


RequestStream buffering async support improvement?

(In 1.2) when RequestStream buffers (large) incoming data streams to file, it does it synchronously, but if it buffers (small) data streams to memory, it does it asynchronously, but waits in the method for the copy to finish. Aside from seeming backwards (: it seems like both operations should be async. If RequestStream is going to buffer, It makes sense to push the async responsibility back to the caller (in my case NancyHost) to allow for a more true async operation, and use async operations in the actual copying. It also makes sense to not buffer at all in some situations. (#1892)
This seems to suggest more drastic architectural changes to the RequestStream's construction method, which I would not presume to suggest in an initial issue report because too many of my customers do that already. ;)

Has this been fixed by #2015 or #2053 ?


Zipkin use net.parseIP and model functions for IDs

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

Coverage decreased (-0.03%) to 99.969% when pulling 70c599e8d3450784bac23aae40da3e7dc28151b0 on pavolloffay:fix-zipkin-todos into 975982bc79f255490cc111993cc3ddcc636f0927 on jaegertracing:master.

Coverage remained the same at 100.0% when pulling 63009c39befdef3a8ca4c55578f2c89456b7d781 on pavolloffay:fix-zipkin-todos into 975982bc79f255490cc111993cc3ddcc636f0927 on jaegertracing:master.

Coverage remained the same at 100.0% when pulling 71663dee7a86fd2031ca96d30e3ddd0ca62c5f51 on pavolloffay:fix-zipkin-todos into 658d6a3ec340e0de24eeb05b717391adddd15118 on jaegertracing:master.


The Last Merge Bug

Hello! I try to install gcc with the last commit: HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_BUILD_FROM_SOURCE=1 brew install gcc --without-glibc
==> Installing gcc --without-glibc
==> Downloading https://ftp.gnu.org/gnu/gcc/gcc-5.5.0/gcc-5.5.0.tar.xz
######################################################################## 100.0%
==> Patching
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/gcc/graphite.h b/gcc/graphite.h
|index 4e0e58c..be0a22b 100644
|--- a/gcc/graphite.h
|+++ b/gcc/graphite.h
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Error: undefined method `ErrorDuringExecution' for Utils:Module
/home/vx00727/.apps/Library/Homebrew/utils/popen.rb:18:in `safe_popen_write'
/home/vx00727/.apps/Library/Homebrew/patch.rb:70:in `apply'
/home/vx00727/.apps/Library/Homebrew/formula.rb:1104:in `each'
/home/vx00727/.apps/Library/Homebrew/formula.rb:1104:in `patch'
/home/vx00727/.apps/Library/Homebrew/build.rb:130:in `block (2 levels) in install'
/home/vx00727/.apps/Library/Homebrew/formula.rb:1117:in `block in brew'
/home/vx00727/.apps/Library/Homebrew/formula.rb:2037:in `block (2 levels) in stage'
/home/vx00727/.apps/Library/Homebrew/utils.rb:564:in `with_env'
/home/vx00727/.apps/Library/Homebrew/formula.rb:2036:in `block in stage'
/home/vx00727/.apps/Library/Homebrew/resource.rb:120:in `block in unpack'
/home/vx00727/.apps/Library/Homebrew/resource.rb:189:in `block in mktemp'
/home/vx00727/.apps/Library/Homebrew/mktemp.rb:55:in `block in run'
/home/vx00727/.apps/Library/Homebrew/mktemp.rb:55:in `chdir'
/home/vx00727/.apps/Library/Homebrew/mktemp.rb:55:in `run'
/home/vx00727/.apps/Library/Homebrew/resource.rb:188:in `mktemp'
/home/vx00727/.apps/Library/Homebrew/resource.rb:115:in `unpack'
/home/vx00727/.apps/Library/Homebrew/resource.rb:93:in `stage'
/home/vx00727/.apps/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/forwardable.rb:202:in `stage'
/home/vx00727/.apps/Library/Homebrew/formula.rb:2014:in `stage'
/home/vx00727/.apps/Library/Homebrew/formula.rb:1112:in `brew'
/home/vx00727/.apps/Library/Homebrew/build.rb:124:in `block in install'
/home/vx00727/.apps/Library/Homebrew/utils.rb:564:in `with_env'
/home/vx00727/.apps/Library/Homebrew/build.rb:121:in `install'
/home/vx00727/.apps/Library/Homebrew/build.rb:202:in `<main>'

[+] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Linuxbrew/homebrew-core: https://github.com/Linuxbrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[-] ran brew update and can still reproduce the problem?
[-] ran brew doctor, fixed all issues and can still reproduce the problem?
[-] ran brew config and brew doctor and included their output with your issue?

Hi. I think the patch applied in the gcc.rb formula needs to be “removed” by using: unless OS.mac?. Mind opening a pull request in the core repository? I’m home in around 1 hour and will fix it then.

Will be fixed by https://github.com/Linuxbrew/homebrew-core/pull/8720


[Storage] SharedKey and SAS query parameters multivalue sort improvement.

During implementation of https://github.com/Azure/azure-sdk-for-java/pull/11101 we discovered that order of query parameters when computing SAS or Shared Key signatures matter (per https://docs.microsoft.com/en-us/rest/api/storageservices/authorize-with-shared-key#shared-key-format-for-2009-09-19-and-later ).
Ideally this should happen at https://github.com/Azure/azure-sdk-for-net/blob/7086132896588ffa6480009a4166d163c63b913c/sdk/storage/Azure.Storage.Common/src/Shared/StorageSharedKeyPipelinePolicy.cs#L131-L142 instead of relying on each feature implementation to sort them.

Per discussions today, this is still an active issue

Closing as this has been completed


Not everybody has Fira code font installed

When activating the theme I see an ugly serif fonts (Times New Roman) because I don't have and use Fira Code.
My suggestion, either removes this lines entirely https://github.com/justinribeiro/chrome-devtools-theme-atom-dark-green-cursor/blob/3b9ea1eb86b114718440e26f6a81f3b7bcd6b9a0/less/_global-styles.less#L5-L14
or set the font-family at least to
font-family: 'Fira Code', 'Helvetica Neue', 'Lucida Grande', sans-serif !important

or some monospace backup font in case Fira Code is not available.

Thanks, could you explain me how to edit CSS of the plugin?
I've installed fira code but it is bold, like really really bold...


Login with OAuth provider

I understand that Chatter Net’s DID-based accounts is a key part of its offering as a user-owned platform. I truly believe it has the potential potential to be my default online identity provider in the future.
However, the bulk of my online identity is currently tied up with the likes of Google and GitHub. For many of my friends it’s things like Facebook and Instagram.
I’m not gonna be able to onboard regular internet users to join me on Conversely/CN unless there’s a simple migration path from the status quo of the dominant Web 2.0 platforms.
Matrix recognized this as well, resulting in a major transition towards OIDC support: https://areweoidcyet.com/
..incidentally, they also have an example of how to log in with Mastodon OAuth: https://matrix-org.github.io/synapse/latest/openid.html#mastodon
I propose a completely optional login path for users who wanna start off on Conversely by authenticating with their favorite ‘social login’ provider.
For example via:
https://github.com/ory/kratos
https://github.com/ory/kratos-client-rust
https://github.com/zitadel/zitadel
https://github.com/smartive/zitadel-rust

I did a round trip trying to figure out which repository this belongs to.
I would write the expected outcome as follows: a user can log into Conversely using OAuth 2.0 credentials. At first I thought this is a Chatter Net wide issue, but now I think this is a choice apps on Chatter Net can make for themselves.
I can see two needs that this can address. If you can think of others please let me know:

A new user comes to Conversely, they get a default account, want to secure the account, so they must make a password. They are now managing one extra password. This could turn people off of the platform.
A new user comes to Conversely, they are seeing accounts they recognize, but don't know if they can trust them. If those accounts were linked with some external ID, it would make it easier to search and discover contact.

These two points will require different solutions.
Private key store
This would require a server which stores user's private keys, and sends it to them if they can prove their identity using OIDC. The tech to build this in rust is mature and accessible, so I think an implementation could be reached relatively quickly. Handling secrets for a user does come with a very high bar though, so maintaining this server could be a bit of a burden (it would be an appealing target for hackers).
Platforms which use such a private key store and don't allow the user to see their private key are effectively bypassing the decentralized identity mechanism of Chatter Net. It's basically DID over OAuth at this point. However, this could be an effective tool to onboard new users. So I think it's an appealing project.
Associating external credentials to a DID
This would require a server which would accept a request for verification from a user with a DID. The user would authenticate with the server using OIDC. The server would then send challenge data to the user and the user would have to sign that data.
Once the server sees the DID has been used to sign the data, it knows that the person controlling the DID is the same one who authenticated using OIDC. The server can then sign a message (lets call it an attestation) links some information about the external account (e.g. email address) to the DID.
The reason this needs to happen on a server is that users will need to trust the server to know that the attestations aren't just generated without doing any OIDC verification. This has the unfortunate consequence that whoever controls the server can emit false information, and can restrict the service. However, there is nothing stopping many such services from existing, so none can monopolize a user's identity.

At first I thought this is a Chatter Net wide issue, but now I think this is a choice apps on Chatter Net can make for themselves.

That’s right. I see this is an entirely opt-in convenience feature that is up to each individual CN instance to provide as an option for users.

Handling secrets for a user does come with a very high bar though, so maintaining this server could be a bit of a burden (it would be an appealing target for hackers).

That’s why the recommended approach to offer this kind of utility add-on should IMO be to outsource it entirely to a trusted 3rd party like the Ory Network.
I don’t need the DID to be an identity-container that only I and I alone control. The power of the DID for me is identity-portability.

Platforms which use such a private key store and don't allow the user to see their private key are effectively bypassing the decentralized identity mechanism of Chatter Net.

Why wouldn’t the platform allow the user to see their private key though? I would not use a platform that kept my private key from me.

It's basically DID over OAuth at this point. However, this could be an effective tool to onboard new users. So I think it's an appealing project.

Exactly. The thing is, my self-sovereign DID-based identity is kinda worthless until it’s been in active use for a while, with an increasing amount of content and relationships tied to it. Once it has become valuable to me, I may opt to decouple it from the 3rd party safe-keeping service and start managing it completely independently.
That said, I think I would personally always want some sort of backup-service involved, for the same reason I’m in no hurry to move my money from my local, highly regulated bank to a USB drive in drawer somewhere.


Is it possible to write a equalitySaturationWithTrace?

Hi,
Thank you very much for this amazing library!
I was wondering if it is possible to write a equalitySaturationWithTrace function that returns the sequence of rewrite rules used to get into the optimal expression.
This would help a lot to debug bogus rules!
If you could point me out where I can catch this trace, I might be able to implement it myself.
Thanks again.

Hi,
I've given it some thought -- I don't think it is easy to get an exact trace of the rules applied to get an exact trace!
Equality saturation works by representing a term (and necessarily all its sub-terms) in an e-graph and then applying rewrite rules over and over. These will match the terms represented in certain e-classes, and add the rewritten version in the same e-class.
I imagine it might be possible by tracking the origin of each term (e.g. if add was called by eqsat for rule X, or if it was called by the eqsat init, or by recursing inside a larger term?...), and then when extracting (choosing the best term out of each class that the main term depends on) compose this information into a useful trace.
I think there might be a compromise that avoids a pervasive change like that:
It'd be cool if you could elaborate on your use case and possibly provide examples for what you'd like to see printed out.
One idea from your mention of debugging bogus rules:
What if we tracked all the rules that fired and printed them out, deduplicated, at the end of equalitySaturationWithTrace? Or just print them out as they fire (for posterior analysis with e.g. grep 😛)?
Though I can see the benefit of a more involved tracing system! We can discuss it further :-)

For example, I had the expression log ( x * (x / x) ) - x  that entered an infinite loop because of the rules negate x := 0 - x and 0 - x := negate x. But since I have so many rules, it took me some time to find the culprit. (I'm taking notes of my experiments and going to write some minimal code to reproduce them).
I think printing them out could already help a lot (or enveloping the function with a Writer monad). But, like I said, I'm still studying the code so that I can do some actual contribution :smile:

I see! Which means that if the rules that fire were to be printed out, eventually you'd see the loop printed out.
Let me know of any questions regarding the implementation. I can help you understand the code.
On approaching this: I think we can either have a compile time flag -fdebug or a module Data.Equality.Saturation.Debug in the spirit of Debug.Trace with duplicated code from Data.Equality.Saturation that calls trace here and there.
I think it's a good idea to add something like this!

Perfect! I'll try to implement that (but no promises I can do it quickly :laughing: )

This is probably where you want to look:
https://github.com/alt-romes/hegg/blob/7a3d18cc3bca8857b63b3235acf799419b437653/src/Data/Equality/Saturation.hs#L127-L128
Possibly adding a Debug.Trace.trace there already goes a long way! It would mean that for each match on the e-graph you'd get the rewrite rule printed out.
I can suggest you add your fork of hegg to your cabal.project as follows, and commit this trace change (you might require some additional Show constraints too) and try it out on your use case.
Create a cabal.project file in your project root and add the following incantation:
source-repository-package
     type: git
     location: https://github.com/alt-romes/hegg.git
     tag: the-sha-of-your-commit-with-the-trace

It should override the hackage package and use your fork of hegg with the change.
Let me know how it goes, if the output is useful enough, etc...
Thanks!

Just to let you know, the debug.trace helped a lot to generate a minimal number of rules that leads to some issues. I found a minimal example that seems to create an infinite loop in the current code, but haven't figured it out how and why. I'll create another issue with this code.

Glad to know, then Equality.Saturation.Debug sounds like a good idea.
I'll take a look at the loop asap.
Thanks for your help!


feat(changelog): add tag message to release context

Description
added to the release context the tag's message if it exists
Motivation and Context

closes #623
How Has This Been Tested?

Screenshots / Logs (if applicable)
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[X] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report
Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (94891c2) to head (30e7fd7).

Files
Patch %
Lines

git-cliff/src/lib.rs
0.00%
12 Missing :warning:

git-cliff-core/src/repo.rs
28.58%
10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   36.59%   36.36%   -0.22%
==========================================
  Files          19       19
  Lines        1468     1480      +12
==========================================
+ Hits          537      538       +1
- Misses        931      942      +11

Flag
Coverage Δ

unit-tests
36.36% <21.43%> (-0.22%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good at first glance, I can add a proper review if you can fix the CI & polish the implementation 🐻

Very nice! I had some comments.
Can you also add a little documentation under website/docs/usage/adding-tag-messages.md?

Thanks!
added the docs: eafe9b0

Thanks everybody for implementing this! @

When will this feature be updated to git-cliff-action?

When will this feature be updated to git-cliff-action?

I don't use the github action (I use gitlab) so I'm not 100% sure. But, I guess it's already there and all you need is to use the message variable in the template. As described in the docs

Just updated git-cliff-action to use git-cliff 2.4.0: https://github.com/orhun/git-cliff-action/releases/tag/v3.3.0


Import changes from refs/heads/main

I am operating with carte blanche, no one can stop me. Thanks TES


Consider necessity of bazel_buildtools

description
bazel buildtools - ie buildozer and buildifier was previously added as a requirement for building docs from the api
this is no longer necessary as the information is taken directly from bazel and/or config files now.
we may wish to remove it as its not used anywhere by CI, otoh we might want to update docs and potentially even the scripts triggered by the git hooks to make use of the bazel loaded version
there are also other possible uses that we may wish to keep or readd this for - eg we could use these tools to auto fix dependency dates or shas, or update other bazel files automatically
if we keep we probably want to move it from api/bazel/repository_locations.bzl -> bazel/repository_locations.bzl

cc @moderation

@phlax I'm in favor of removing if we are not using

yep, i think me too - i probs want to readd it - but it needs to be moved from where it is - and if its not being used i think there is not point putting it anywhere else just now - ill raise a pr to remove

cc @keith
closing this as we have removed the build tools for now

If we ever want to revisit this I think we could use something like https://github.com/keith/buildifier-prebuilt/ to make vendoring these trivial


[OR-1846] sync the submodules

make submodules version same to optimism's

Thank you very much.
@nguyenzung
I'm sorry. It's not affect to us contracts I think. But We must have same version with Optimism's.

@nguyenzung
We have to use after rebase main branch!
I think it is urgent. I will merge into main directly...
I'm sorry.


MGDCTRS-787 feat: expose the desired state

This change exposes the desired state field for a connector when the
connector is in a transitioning state to better inform the user what is
happening.  This commit also adds a few more rows to the
connectorsPolling fixture so it's easier to develop against the various
status possibilities.

I also tried to make some of the naming more consistent with the connector field names.

Thanks!


Cannot pack electron app

Describe the bug
Cannot pack fresh electron app after creating new blank project.
To Reproduce
run this:
cd /tmp
ionic start # go through the installer, react, blank
npm i @capacitor-community/electron
ionic build
npx cap add @capacitor-community/electron
#npx cap open @capacitor-community/electron # works correctly
cd electron
npm run electron:pack #fails

Error
error TS2688: Cannot find type definition file for 'keyv'.
  The file is in the program because:
    Entry point for implicit type library 'keyv'

Expected behavior
Normal compilation for electron pack
Desktop (please complete the following information):

OS: Archlinux
Browser irrelevant (opera)
Version @capacitor-community/electron: 4.1.2

install package in electron folder

@hotrungnhan
running:
cd electron
npm i package
npm run electron:pack

Still fails with the same error (tried with both 'package' and 'packager')

Solved!
missing package was "keyv" didn't think it was solved this easily.
npm i keyv in the electron folder.
I am not closing the issue though since the platform command should add all its dependencies itself


Fix MismatchedInputException on deserializing repeated json property name model

Ref #25164
This PR fixes the bug by updating the nodePath check to verify against the depth (nesting value) of traversal path  instead of the constant value 2.
Hence, leading to fixing the bug by looking up the property name in the immediate parent instead of the global root node (where duplicate property keys may occur).

/azp run java - core - ci


QR code texture changes on the “ My code “ screen when a user enters too long name in the Name field from the Edit Profile page

Frequency: 100%
Repro on build version: Android internal build v1.3.0(1004294316) & Test Flight build v1.3.0(27)
Repro on devices: Samsung Galaxy Note 5(7.0) , IPone SE2 (13.5)
Testing Account:<PHONE_NUMBER>  / Back up Key:
https://docs.google.com/spreadsheets/d/1Iy41GGA6e2pES2XHjBn7nb8X3n8zZsu7EW1jvwD2e70/edit#gid=0
Repro Steps:

Launch the application and login with valid credentials.
Go to the QR code section on the ‘My code’ screen & observe the texture of QR code.
Now go to the Setting option from the Hamburger Menu.
Go to the Edit profile section & enter too long profile name in the Name field with spaces between words.
Now again go to the QR code section on the ‘My code’ screen.
Observed that QR code texture changes as compared to previous one.
Current Behaviour: QR code texture changes as user enter too long Profile name
Expected Behaviour: QR code texture should not be changed if user enter too long name
Attachment: QRCodeTextureChange.png

Hi I have verified this issue using latest Android internal build v1.5.5(1004294316) & Test Flight build v1.5.5(34) & observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) , iPhone SE (13.5.1)

Hi I have verified this issue using latest Android play store build v1.5.5 & App store build v1.5.5 & observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) , iPhone SE (13.5.1)

Hi I have verified this issue using latest Android internal build v1.6.0(1004294326) & Test Flight build v1.6.0(37) & observed that issue is still reproduced.
Repro on Devices: Samsung Galaxy A5(7.0), iPhone 7 Plus (14.1)

Hi @nityas  I have verified this issue using Play store build v1.6.0 & App store Build v1.6.0 and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) ,iPhone SE (14.2)

Hi @nityas I have verified this issue using Android internal build V1.7.1(1004294328) & Test Flight Build V1.7.1(39) and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) ,iPhone 8 (14.2)

Hi @nityas I have verified this issue using Android internal build V1.7.2(1004294329) & Test Flight Build V1.7.2(39) and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) ,iPhone 8 (14.2)

Hi @nityas I have verified this issue using Android internal build V1.8.0(1004294329) & Test Flight Build V1.8.0(40) and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) , iPad Air 1 (12.4.6)
Observation:

Also it is observed that Oops! something went wrong screen display with Restart App button when user enter too long name (i.e. near around 240 words)
Attachment: LongNameQRCodeNotDisplay.jpg

Hi @nityas I have verified this issue using Android internal build V1.8.0(1004294329) & Test Flight Build V1.8.0(40) and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) , iPad Air 1 (12.4.6)
Observation:

Also it is observed that Oops! something went wrong screen display with Restart App button when user enter too long name (i.e. near around 240 words)
Attachment: LongNameQRCodeNotDisplay.jpg

Hi @nityas I have verified this issue using latest released Android Internal Build V 1.10.1(1004294336) & Test Flight Build V1.10.1(46) and observed that issue is still reproduced.
Repro on devices: Samsung Galaxy A5(7.0) , iPhone XR(14.2)
Observation:

Also it is observed that Oops! something went wrong screen display with Restart App button when user enter too long name (i.e. near around 240 words)


Log error

Hi Gary - thanks again for all the efforts the other day. I'm not sure if this is related but I get this in my log.
Everything seems to be working but not sure what this means.
Any pointers?
Many thanks
Max
This error originated from a custom integration.
Logger: custom_components.icloud3
Source: custom_components/icloud3/helpers/messaging.py:497
integration: iCloud3 v3 (documentation, issues)
First occurred: 10:14:15 (25 occurrences)
Last logged: 11:15:06
iCloud3 Error > Error extracting device info from Apple Acct data, Device-Max iPhone (iCloud3) (max_iphone_icloud3), AppleAcct-. iCloudName-

By way of an update, I now get this every few seconds. I'm not sure this is giving much info but hopefully it's a known issues?
Many thanks.
2024-11-19 17:34:40.794 ERROR (SyncWorker_16) [custom_components.icloud3] iCloud3 Error > Error extracting device info from Apple Acct data, Device-Max iPhone (iCloud3) (max_iphone_icloud3), AppleAcct-. iCloudName-

It looks like the Apple account is not set up for max_phone _icloud3. Go to Configure > iCloud3 Devices screen > Select Device and verify the configuration for the Apple Acct field

Thanks. The strange thing is that it's working. It's the main family account and tracking of all the phones in the family is working.
The only thing that was not set correctly was the linking "Apple account iCloud device". It was set to none.
Could this have been the reason?
Thanks
Max Mlinaric
07931 505 330
On Thu, Nov 21 2024 at 02:16, Gary Cobb < @.*** > wrote:

It looks like the Apple account is not set up for max_phone _icloud3. Go
to Configure > iCloud3 Devices screen > Select Device and verify the
configuration for the Apple Acct field
—
Reply to this email directly, view it on GitHub (
https://github.com/gcobb321/icloud3_v3/issues/371#issuecomment-2489926178
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/BLCVEZMHXMEGDZUW5RCE2RL2BU7A7AVCNFSM6AAAAABR52RQOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBZHEZDMMJXHA
).
You are receiving this because you authored the thread. Message ID: <gcobb321/icloud3_v3/issues/371/2489926178
@ github. com>

Thank you - sorted :-)


Port remaming components to "Microsoft.Data.SqlClient"

dotnet-sql-cache tool
SqlConnectionHealthCheck (cc @rynowak) Not a shipping thing, a sample. Never mind.

cc @ajcvickers @divega

Assigning since you're looking at this already.

Merged #12447 to update to the latest. Leaving this open because we need to update to the RTM build when it's available.

#12957 is tracking this now.


vulnerabilities

I cloned the repo and installed it and saw the message listed at the bottom of this message. Is it a bad idea to use this EventEmitter2 now? Do you have any modules you suggest to use instead?
message seen after installing EventEmitter2 with npm install

found 10 vulnerabilities (9 moderate, 1 high) run npm audit fix to fix them, or npm audit for details
$ npm audit
             === npm audit security report ===

Run  npm install --save-dev<EMAIL_ADDRESS>to resolve 10 vulnerabilities
SEMVER WARNING: Recommended action is a potentially breaking change

Nyc is a dev dependency so it's not actually being loaded if you're installing EventEmitter2 as a dependency.
A PR to update the version in package.json would also be welcome. 😁

I installed it and all was well. Thanks.


mqueue: revert refactor of mqueue

Summary
This PR reverts #13413 which refactors mqueue.
The reason for this is that this refactor broke the WiFi CI on both Xtensa and RISC-V Espressif devices.
So far, the following has stopped working across affected SoCs:

ifconfig after reboot not responding as it used to
connection to AP using wapi throws many errors and is unstable
Multiple failures on WiFi performance test using IPERF.

If this affected Espressif devices using those tools, it is possible it affected other devices as well. I'm keeping an eye open on new issues.
Impact
Restores WiFi support on Espressif devices.
Testing
Reverted #13413 on master, run the entire CI and everything works again.

Hold for some time, and I will give you a different way to handle this issue.

@fdcavalcanti
Please, provide how to build, how to execute the bin, how to reproduce the issue.

Hi @GUIDINGLI. I'll check if QEMU can reproduce this.
Meanwhile, a quick way of viewing the errors:

Build setup: ./tools/configure.sh esp32-devkitc:sta_softap
Set CONFIG_DEBUG_FEATURES, CONFIG_DEBUG_NET, CONFIG_DEBUG_NET_ERROR, CONFIG_DEBUG_NET_WARN, CONFIG_DEBUG_WIRELESS, CONFIG_DEBUG_WIRELESS_ERROR, CONFIG_DEBUG_WIRELESS_WARN
Build and flash.

Run wapi scan wlan0 a couple of times and it stops responding.

Hold for some time, and I will give you a different way to handle this issue.

What's your plan here?

Hold for some time, and I will give you a different way to handle this issue.

What's your plan here?

Sorry, don't have esp32 env current now.
Can reproduce on Qemu? If so, that will be very helpful for this issue

@fdcavalcanti
Please see:
https://github.com/apache/nuttx/pull/13841
The rootcause is not mq's refactor, but there already has a bug on esp32 time calculation.
One suggestion, if you meet a question, try to fix the bug first time.

@fdcavalcanti
You can close this PR now.

@GUIDINGLI thank you for the fix.
I hope you did not take this personally. Sorry about the confusion around this issue.

Please let's stand by on this.
Don't know what gave the impression that PR should be merged but the proposed fix did not work and we have WiFi still failing across all devices. Still looking into it.

@GUIDINGLI thank you for the fix.

Sorry, from this reply, I think you verify that https://github.com/apache/nuttx/pull/13841 fix your problem.


How to solve the problem of ProjectURL not displaying?

As stated in the title.
To Reproduce
Steps to reproduce the behavior:

Here is my .csporj file.

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net6.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>
  <PropertyGroup>
  <PackageId>SysTools</PackageId>
  <Version>1.1.1</Version>
  <Company>OmniCode</Company>
  <RepositoryUrl>http://gitlab.omnicode.cn:30999/xxx.git</RepositoryUrl>
  <projectUrl>http://gitlab.omnicode.cn:30999/xxx.git</projectUrl>
  <Authors>SomebodyThatiUsedToKnow</Authors>
  <Description>Something</Description>
</PropertyGroup>
</Project>

I first executed the command dotnet pack, and then executed dotnet nuget push -s http://Mysever/v3/index.json ./bin/Debug/MyPkg1.0.0.nupkg.

Expected behavior
I hope to be able to click on the Project URL on the webpage and be redirected to the corresponding project address, but that is not the case in reality.

Can you try using <PackageProjectUrl>...</PackageProjectUrl> instead of <projectUrl>...</projectUrl>.
PackageProjectUrl is the name of the property to use inside the .csproj file.
https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target


Invalid Time Configuration: App Allows Closing Time Earlier Than Opening Time

Why does the app allow setting a closing time earlier than the opening time, or am I misunderstanding?

This is actually not a bug. Our application allows overnight queues eg. open at 9PM, closes at 4AM. Thanks for pointing this out.


load model in Card class

#96 added a function in the Card class to load the model if provided a file path.
sorry if the implementation looks naive

Right now, the model is eagerly loaded during init. Recently, we made a move to prevent this (see https://github.com/skops-dev/skops/pull/163). However, lazy loading could be costly because it would be done for each call to repr. Maybe we can store the actual model in a different attribute (say, _model) when it's called for the first time?

But we need to make sure we invalidate that whenever the _model changes.

But we need to make sure we invalidate that whenever the _model changes.

This could be done with a setter but maybe we can come up with an easier solution?

We need to have a test for this. If you need help implementing the test, let us know.
Yes sure, there will be same test function but instead of model instance we have to pass a tmp model file (one for skops and one for pkl).
The docstring of the Card class needs to be updated.
Right now, the model is eagerly loaded during __init__. Recently, we made a move to prevent this (see #163). However, lazy loading could be costly because it would be done for each call to __repr__. Maybe we can store the actual model in a different attribute (say, _model) when it's called for the first time?
On this as the same argument is supporting both model and model_path so in representation and in _generate_card we will be doing model loading there else we can do it in representation on 1st call and set _model to model instance but in that case both model and '_model' will have the instance when user will provide model instance to Card class.

Yes @BenjaminBossan i changed the functionality to skops file as well as pkl file and also mentioned some of the things about thr design choice.
Waiting for input from you guys about that.

We need to have a test for this. If you need help implementing the test, let us know.

Yes sure, there will be same test function but instead of model instance we have to pass a tmp model file (one for skops and one for pkl).

So here we would like to see unit tests for the new feature being added, similar to what we have here. Would you please work on that? We can help if needed.

On this as the same argument is supporting both model and model_path so in representation and in _generate_card we will be doing model loading.
else we can do it in representation on 1st call and set _model to model instance but in that case both model and '_model' will have the instance when user will provide model instance to Card class.

So I prefer the second solution. When the model is first accessed, if it's a path, it is loaded, if it's already a model, then we're good. It should be stored on a private attribute like _model. Then the next time, the model is already loaded and we don't need to load it again. When the user changes the model attribute, we need to invalidate _model, since it could now be a different model.

thanks @BenjaminBossan will update the changes

thanks @BenjaminBossan for the code snippet and detailed explanation i have added required changes, i also added a deleter for model. have a look.

Formatting
Could you revert the formatting changes you made? It looks like some tool you use (your IDE maybe?) reformatted the files you worked on to use 79 or 80 characters per line. However, we use black with the default settings, which comes down to ~88 characters per line. If you undo these changes, the code will be much easier to review because the formatting changes distract from the real changes.
The best way to achieve this would be if you could first undo your formatting changes, then add black via a pre-commit hook. This step is explained in our contribution pipeline but the gist is that you should do something like:
pip install pre-commit
pre-commit install

from within your Python environment. After doing this, each time when you commit, the code will be checked for black compliance.

I used the contribution setup before raising the PR but i think my local black setup formatted the code before the being formatted by pre-commit.

Testing
If I understand correctly, you have duplicated a number of tests. Examples are test_plot_model_false_from_path and test_add_from_path. The change you introduced was to have the card initialized from a file instead of passing the model directly, the rest is identical.
IMO, it is not necessary to duplicate all those tests, since the actual thing they're testing is not related to how the model was passed. Instead, it is sufficient to have tests that show that passing a model or a str or a Path do the same thing, and that modifying the .model attribute works (as in the last test class (which btw. should also test deleting, which you correctly added)). The duplicated tests can then be removed.
Another suggestion I have, which is not as clear cut, is to move _load_model out to be a standalone function and not a method on Card. Then add a few tests just for this function. Once we know that this function works well, testing the Card class will be much easier because we know that the model loading part is covered.

okay, I will remove the duplicate tests and make standalone _load_model function and write tests for funtion as well as passing path.

Test fixtures
I think there is a misunderstanding regarding the use of pytest fixtures. Let's take this example:
@pytest.mark.parametrize("suffix", [".pkl", ".pickle", ".skops"])
def test_save_model_card_from_path(destination_path, model_card_from_path):
    model_card_from_path.save(Path(destination_path) / "README.md")
    assert (Path(destination_path) / "README.md").exists()

Here you use the fixture suffix but your test doesn't make use of it. This means that the exact same test will be run 3 times, with no additional value. The correct way to use fixtures is to create the decorator (as you did), then add the fixture name as an argument to the function, and then to use that argument in the function (e.g. in test_plot_model_false_from_path you use the fixture correctly).

Fixture parameterisation
here the pytest fixture model_card_from_path has a param named suffix  and pytest is implicitly passing the values. have a look at the above stackoverflow link, so the pytest behaviour is correct(i checked the test locally and verfied the output and behaviour before the PR ).

here the pytest fixture model_card_from_path has a param named suffix and pytest is implicitly passing the values. have a look at the above stackoverflow link, so the pytest behaviour is correct(i checked the test locally and verfied the output and behaviour before the PR ).

Ah I see, I didn't know about this new feature. It's kinda cool but also a bit magic. I wonder if it's really preferable over using request.param to parametrize a fixture.

Oh nice, finally pytest supporting this. Been waiting for it for ages. I personally find it more intuitive than using request.param. But everywhere this pattern is used, I'd leave a comment saying it's a parameter passed to the fixture for future developers to figure it out easily.

Created a fresh PR in #205 for this.


Cannot marshal <type 'wrapper_descriptor'> objects

I'm getting this error when I try to send a WordPressPost object using the EditPost method. It looks as though python's xmlrpc is iterating through the _def attribute of the WordPressPost object to get to this. My post is a large one with a number of custom_fields (using the advanced custom fields plugin). I'm using various versions of python 2.7 (2.7.10 on OS X El Capitan, 2.7.6 on Ubuntu 14.04). Any ideas of what to look for?
Thanks!

How did you solve it?


Missing v4.0.0 on packagist

I was about to update to roadrunner 2023 with roadrunner-jobs 4.0, which requires spiral/goridge 4.0. However, composer fails because there's no such version published in packagist.

The weird thing is that there seems to be a 4.0 git tag, so maybe some automation on packagist side has failed?

Sounds like we had a webhook issue, fixed.

Thanks!


Tomcat 8.5.47 COMBINED

Hi, I use lastest release:
$ goaccess --version
GoAccess - 1.3.

I have set up server.xml as
<Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs"
          prefix="api-example_access_log" suffix=".txt"
          pattern="combined" />

than after restart new file generated logs like:

<IP_ADDRESS> - - [13/Feb/2020:23:29:49 +0100] "GET / HTTP/1.1" 302 - "-" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0"
<IP_ADDRESS> - - [13/Feb/2020:23:29:50 +0100] "GET /login/auth HTTP/1.1" 200 2283 "-" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0"
<IP_ADDRESS> - - [13/Feb/2020:23:29:50 +0100] "GET /favicon.ico HTTP/1.1" 404 46 "-" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0"

COMBINED
after running
$ goaccess ./logs/api-example_access_log.2020-02-13.txt --log-format=COMBINED
I received:

Parsing... [0] [0/s]                                                                                /./logs/api-example_access_log.2020-02-13.txt
Parsed 1 linesproducing the following errors:
Token '13/Feb/2020' doesn't match specifier '%d'
Format Errors - Verify your log/date/time format

same error pops up if I start goaccess without --log-format param and choose NCSA Combined Log Format
same issue if I run
$ LANG="en_US.UTF-8" bash -c 'goaccess ./logs/api-example_access_log.2020-02-13.txt --log-format=COMBINED'
VCOMBINED
after running
$ goaccess ./logs/api-example_access_log.2020-02-13.txt --log-format=VCOMBINED
I received:

Parsing... [0] [0/s]                                                                                /./logs/api-example_access_log.2020-02-13.txt
Parsed 1 linesproducing the following errors:
Token '+0100]' doesn't match specifier '%h'
Format Errors - Verify your log/date/time format

sam eissue if I run
LANG="en_US.UTF-8" bash -c 'goaccess ./logs/api-example_access_log.2020-02-13.txt --log-format=VCOMBINED'
$ uname -a
FreeBSD example.com 11.3-RELEASE-p3 FreeBSD 11.3-RELEASE-p3 #1: Tue Oct 15 01:53:29 CEST 2019

Any help will be appreciated

Solution
LC_ALL="en_US.UTF-8" bash -c 'goaccess ./logs/api-example_access_log.2020-02-13.txt --log-format=COMBINED'
Explanation
my system has different locale:
$ locale
LANG=
LC_CTYPE=pl_PL.UTF-8
LC_COLLATE=pl_PL.UTF-8
LC_TIME=pl_PL.UTF-8
LC_NUMERIC=pl_PL.UTF-8
LC_MONETARY=pl_PL.UTF-8
LC_MESSAGES=pl_PL.UTF-8
LC_ALL=

I had to explicitly enforce US locale (for alphabetic name of the month)

Good call on that. Probably a better error message should be displayed on those cases.


add NaN check to allow non-digits handling.

The background is that not every data in every dataSet is valid number in real life.
add NaN check to allow non-digits handleing. if a CGPoint contains NaN, simply ignore it, this will ignore current point and continue the path with next valid point.
This is helpful, where dataSet 1 contains invalid data but dataSet 2 has valid data. People can have a chance to insert NaN if user found the data is nil/null/NSNotFound/ifinity/DOUBLE_MAX.... any number that cannot be drawn on screen or even exists in real life, and still get the chart.
I only add the fix for radar chart, since I am more fimiliar with it and gives the demo. If it is a valid scenario, you can change other charts accordingly.
for example,
xValues: [1,2,3,4,5]
dataSet 1: [5,6,NaN,8,9]
dataSet 2: [11,12,13,14,15]
With NaN support, the radar chart will connect dataSet 1 values: 5-6-8-9 as a web, and dataSet 2 as 11-12-13-14-15 as another web.

Check out the little white dot with yellow, its corresponding blue line has NaN so we don't have to highlight it and draw it.


[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

    "replicationStatus": {

Does this have a fixed set of values? If so, it should be a string enum.

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18118 in bbd756d. [](commit_id = bbd756d438fefe5839bc0e512bc519e7a5dd6a52, deletion_comment = False)

  "properties": {}

ARM recommends against the use of the additionalProperties/empty/unschematized object pattern. ARM favors stronger typing wherever possible because it allows all consumers of your API to reason about it. This has benefits for everyone that interacts with your API including basic infrastructure, other Azure features, SDK owners, and customers. Unschematized objects are essentially API contracts that bypass Azure versioning infrastructure.
Generally, this pattern should only be used when needed and the object properties are dynamic, unknown, or user defined. Ref: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined.

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18690 in bbd756d. [](commit_id = bbd756d438fefe5839bc0e512bc519e7a5dd6a52, deletion_comment = False)

    "deleteMigrationResources": {

If this has a fixed set of values, it should be modeled as string enum.

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:24219 in bbd756d. [](commit_id = bbd756d438fefe5839bc0e512bc519e7a5dd6a52, deletion_comment = False)

    "instanceType": {

This should be a string enum so the known types are discoverable.

Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:21636 in bbd756d. [](commit_id = bbd756d438fefe5839bc0e512bc519e7a5dd6a52, deletion_comment = False)

@singhabh27 - Please fill out the ARM Review checklist in the submission form. Be sure to review the materials mentioned and attest to that by checking the box.

    "replicationStatus": {

Does this have a fixed set of values? If so, it should be a string enum.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18118 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

We want this field to be of type String.

    "instanceType": {

This should be a string enum so the known types are discoverable.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:21636 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

We want to keep InstanceType as String like other places.

  "properties": {}

ARM recommends against the use of the additionalProperties/empty/unschematized object pattern. ARM favors stronger typing wherever possible because it allows all consumers of your API to reason about it. This has benefits for everyone that interacts with your API including basic infrastructure, other Azure features, SDK owners, and customers. Unschematized objects are essentially API contracts that bypass Azure versioning infrastructure.
Generally, this pattern should only be used when needed and the object properties are dynamic, unknown, or user defined. Ref: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2022-05-01/service.json:18690 in bbd756d. [](commit_id = bbd756d, deletion_comment = False)

Included property.

Hi @singhabh27 Please fix the failed and required CI item:

Hi @singhabh27 Please fix the failed and required CI item:

Fixed.

Hi @singhabh27 please remove DoNotMerge if you want to merge the PR:

Hi @JeffreyRichter Please help review the swagger breaking change. Thanks!

/azp run

Hi @JeffreyRichter Please help review the swagger breaking change. Thanks!

It is fake warning.


decodeAudioData does not seem to work - throws InvalidArg

const context = new AudioContext({ sampleRate: 44100, latencyHint: 'interactive' });
const buf = Buffer.from([1, 2, 3]);
const audioBuffer = await context.decodeAudioData(buf);

At the last line I'm getting an Error with code: 'InvalidArg' set.
Basically, I have 2 requests: besides fixing the actual issue, I think everyone will benefit from the code throwing a more digestible error, so that you guys would have way more information to act upon.

Hey, thanks for the feedback.
Actually decodeAudioData requires an ArrayBuffer as argument, bot a Buffer (see change in the last line):
const context = new AudioContext({ sampleRate: 44100, latencyHint: 'interactive' });
const buf = Buffer.from([1, 2, 3]);
const audioBuffer = await context.decodeAudioData(buf.buffer);

Now the code will fail but because the given buffer is not recognized as a valid audio format, which is fine.
The type check for a  more readable error was actually broken, this is fixed in 497f60a and will be shipped in next release

Thanks for the answer. But I'm puzzled a bit.
Is this behavior by design?
Asking because

according to TS typings, it must work with anything implementing ArrayBuffer's interface, means it must have byteLength and be able to .slice()
the competition (in the form of web-audio-engine and electron's built-in AudioContext) both work with Buffer no issues

Sorry for the late response,
Actually, the spec says that the argument should be an ArrayBuffer, cf. https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-decodeaudiodata
And the current behaviour seems consistent with the one of browsers:
const context = new AudioContext({ sampleRate: 44100, latencyHint: 'interactive' });
const buf = new Float32Array([1, 2, 3]);
const audioBuffer = await context.decodeAudioData(buf);

throws TypeError: Failed to execute 'decodeAudioData' on 'BaseAudioContext': parameter 1 is not of type 'ArrayBuffer'.
So I don't really know why web-audio-engine and electron's accept a Buffer, but it doesn't feel right regarding the spec from what I understand


Select does not visually update when value changes from outside the component

Current Behavior
Select does not visually update value when the value changes.
https://github.com/tamagui/tamagui/assets/8202335/85239964-9187-496f-b4e1-5fb1c2a95e50
Expected Behavior
When value changes, select should visually reflect the value state. This is important for resetting forms, or when state is hydrated later, such as after an api call.
Tamagui Version
1.76.0

Platform (Web, iOS, Android)
Web
Didn't test ios/android

Reproduction
https://codesandbox.io/p/sandbox/gallant-hooks-hzrxt4?file=%2Fpackages%2Fapp%2Ffeatures%2Fhome%2Fscreen.tsx%3A13%2C16

System Info
  System:
    OS: Linux 6.1 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (2) x64 AMD EPYC
    Memory: 104.06 MB / 2.01 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 3.6.3 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm
    Watchman: 20220528.183901.0 - /usr/local/bin/watchman
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.21.0
    @manypkg/cli: ^0.19.1 => 0.19.2
    check-dependency-version-consistency: ^3.0.3 => 3.0.3
    eslint: ^8.21.0 => 8.39.0
    node-gyp: ^9.3.1 => 9.3.1
    prettier: ^2.7.1 => 2.8.8
    turbo: ^1.10.3 => 1.10.3
    typescript: ^4.9.4 => 4.9.5
    ```

Same issue

Also having this issue

+1

https://github.com/tamagui/tamagui/issues/1928

This should be fixed as of last release, I updated the logic there. Lmk if not.


[INFRA] Update miss hit configuration

lock miss_hit version to 0.9.15
addresses cpp-lln-lab/CPP_SPM#182
add bug finder to CI

Need to refactor saveToLogFile
src/saveEventsFile.m: metric: exceeded file_length: measured 522 > limit 500
In src/saveEventsFile.m, line 345
| function logFile = saveToLogFile(logFile, cfg)
|                    ^^^^^^^^^^^^^ metric: exceeded cyc: measured 17 > limit 15
MISS_HIT Metric Summary: 53 file(s) analysed, 2 metric deviations(s)
Error: Process completed with exit code 1.


Match current configured ui.theme

Source color scheme from currently configured ui.theme

Thanks for this! I will adjust the highlight color of the QTextEdit also as now depending on the ui.theme used you may get inconsistent colors for the place where you clicked and the rest of highlighted elements.


Cannot switch off scene

I defined a scene in my configuration.yaml. I can switch it on, but I can't switch it off (using the frontend).
When I switch it on (using the switch in the frontend), the settings are applied, but the switch immediately slides back to "off". This makes it impossible to switch off a scene from the frontend.
I'm using the following configuration:
scene:
  - name: Evening
    entities:
      light.light_a:
        state: on
        color: [0.5294, 0.4529]
        brightness: 123
      light.light_b:
        state: on
        color: [0.5294, 0.4529]
        brightness: 123
      light.light_c:
        state: on
        color: [0.5294, 0.4529]
        brightness: 123

After turning on, what is the state of the lights? Especially brightness and color values? A scene is not considered on if the state does not exactly match it.

The brightness is the same, but the color does not exactly match (although it is close).
I'm using hue, is there a known conversion error there? It seems odd that if the scene sets the colors on the lamps (I checked it by giving them completely different colors before switching on the scene), the colors turn out to be slightly off the set value, thereby causing the scene to "forget" that it is turned on

Only solution I can think of right now is to set the scene color values to a color that gets reported by Hue.

hm, I tried copying back the values that I found on the "set state" page after clicking one of the lamps, but after using that in the configuration file it shifted once more..

I guess that's why most systems have a fire and forget instead of this scene is active approach. Not sure about a solution

This behavior also happens when I set the color of a single lamp using the api (which the frontend uses under the hood).
POST to /api/services/homeassistant/turn_on:
{
    "entity_id": "light.livingroom_left",
    "xy_color": [0.732, 0.24]
}

Response:
[
    {
        "attributes": {
            "brightness": 189,
            "friendly_name": "Living room left",
            "xy_color": [
                0.73199999999999998,
                0.23999999999999999
            ]
        },
        "entity_id": "light.livingroom_left",
        "last_changed": "15:08:34 26-04-2015",
        "last_updated": "15:10:26 26-04-2015",
        "state": "on"
    }
]

I'm not sure where this conversion is made...

Setting light color using hue and saturation is supported by the phue library that Home Assistant uses to talk to the Hue lights but it is currently not supported in Home Assistant.

I filed a bug report in the Philips hue dev forum at http://www.developers.meethue.com/content/bug-setting-xy-color-reported-hue-bridge-results-different-xy-color

Closing this as the fault is due to a bug in the information that Philips Hue reports.

I think we should consider re-opening this,
I suspect Philips are going to have trouble fixing this,
From the discussion at http://www.developers.meethue.com/content/bug-setting-xy-color-reported-hue-bridge-results-different-xy-color they are probably using an integer quantized hue/saturation model in the lamps. Having this convert reversibly into an exact floating point value for xy_color will be very difficult.
I wonder if we should consider doing something that will allow states to work - either not comparing the floats exactly - or doing some type of quantization ourselves.
(For the purists I don't think What Every Computer Scientist Should Know About Floating-Point Arithmetic (http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html, applies if there is a quantization in the lamps - at that point all bets are off!)

One idea would be that when setting the state on an 'unreliable device' we could do a set - and then read back the state that the device actually set - and store that, rather than what we expected it to set.

:+1: I second pavoni's comment. I was struggling for the last two hours trying to figure out why the scene was turning off.

Switching off scenes has been removed in the latest dev branch.


Fixing the baseline in math content

Per #2214 , it turns out that in fn layout_text of math/ctx.rs, which handles the layout of math content, regular text is  handled by the typst standard text layout (which will be calling the shaping engine), while the a single letter in a math font or a number is handled without going into the standard layout routines, but instead with an ad-hoc layout function in MathFragment::GlyphFragment.
The baseline shift is not taken consideration by the GlyphFragment which causes the issue of #2214. This PR fixes the issue as well as providing the bug's test case tests/typ/bugs/math-shift.typ.
hello #text(baseline: -5pt)[123 #sym.WW\orld]\
hello #text(baseline: -5pt)[$123 WW#text[or]$ld]\

result:

Thanks!


Fix the default config description

From @matheuss on July 21, 2017 4:19
Copied from original issue: zeit/now/pull/38

From @nkzawa on July 21, 2017 7:19
btw https://git.io/now-global-config redirects to a wrong url. Can you fix it too.

https://github.com/zeit/email-prompt/issues/22


Animated points

It would be very nice to have ability to animate points of shape with the animationPlayer.

we talked about this and I think everyone agreed that it's something we want to add


[5.4] Added relative dates validation support

The related issue: https://github.com/laravel/framework/issues/18894
Currently, a date validation rule is successfully passed by relative dates with the "main part":
2006-12-12 10:00:00.5 +1 week +1 hour

Under the "main part" in this example I mean 2006-12-12 10:00:00.5.
But the "fully" relative dates without the "main part" are not supported. Validation always fails.
+1 week +1 hour
yesterday

This PR was made to address this problem.

To be honest I'm not sure if we support this, tomorrow and yesterday might not be acceptable values of a date field, it seems like it's better to have this as a custom rule inside ones app if they desire this behaviour.

No plans to add this for now.

@themsaid @taylorotwell please, keep in mind that 2006-12-12 10:00:00.5 +1 week +1 hour still successfully passes the date validation rule. It may be an unwanted behavior.
So the question is: should we consider relative dates as valid dates or not. If not, the above string validation should fail.

@chimit IMO that should change but in 5.5 since people may be using it in 5.4 already.


Add language model training pipeline

Motivation

For decoding with language model.


Syntax update and comment shortcuts

I updated the syntax with more feature and fixed #1 and fixed #8.
Also added sublime-syntax file that might give some performance improvements with latest Sublime Text 3 build.

Thanks for your contribution @Ballzz :+1:


Speed up testing for InfinitePotentialWell3D

https://github.com/ohno/Antique.jl/actions/runs/9029704039

The evaluation of the kinetic energy operator is taking a long time. As a workaround, comment out the test. Please consider using a formula processing system https://github.com/ohno/Antique.jl/issues/57.

Commenting out the InfinitePotentialWell3D test did not solve this problem.


Exporting translations to new path

This is related to the lsbuild warning.
The new path for the .lcl needs a one-time manual sync.

/azp run


More entity colors

We are assigning a new color to every entity we create. Currently we are using material UI colors as you can see in this image:

Currently we are using the CirclePicker of this component:
https://casesandberg.github.io/react-color/
@broham89 I'm pretty sure we can expand the colors of the picker. Do you want to create a pallete of colors for us?

Also, system entities use this color, it should be nice if those system entities could have a different color. Currently, they are sharing colors

If you're using a generator to pick those colors then it's totally fine to use that. Just make sure the colors are not too light to the point you can't see the text behind a white bg.

Closed with 5e951ea02a32cbf14021398128f0520f5202f634


Enable Virtual Environments in testing

This sets up the virtual environments for running python onnx tests.
ctest's fixtures are used to ensure that the virtual environment is
set up before the tests are run.

@pfultz2 I have made changes to the requirement files for version specific python requirement files. Can you please take a look to see if this looks good.
I have not disabled backend tests for 3.6 as they can be run with an older onnx version provided we have the models downloaded (which I believe is how QA does testing).

@pfultz2 Thanks for taking a look and providing feedback. I have tried to address the comments. Can you please take a look to see if I have addressed the comments correctly? I am not a 100% sure if the current implementation is how you'd like it.
Side note: The backend test seems to be timing out, I am investigating that but thought to put this up in the meanwhile to get your feedback on the implementation strategy.
Thanks!

Side note: The backend test seems to be timing out, I am investigating that but thought to put this up in the meanwhile to get your feedback on the implementation approach. Thanks!

The timing out of backend test was system related. A reboot of the system helped fix the issue.

Looks like we have also have try/except clause in another test test_numpy.py as well: https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/blob/a50cb30242d9b328a05f17e34a225310d1210134/test/py/test_numpy.py#L26
Should we also remove this try except clause or leave it as is? @pfultz2

That should be removed as well.

That should be removed as well.

Thanks! Removed through https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/pull/2316.

Updated with develop branch to pull fix of cppcheck issue that has been fixed by df5f8c969316b148be4daa854856e9d9bbb28061.

add a flag to disable the virtual environments so we arent installing these packages everytime we are running tests in the CI.

@pfultz2 Thanks for approving the PR and for all your suggestions/feedback during the course of it. I have opened an issue to add a flag to disable virtual environments: https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/issues/2324


[BUILD] pyopenvdb install locatiion

Environment
Operating System: Ubuntu 20.04 LTS
Version / Commit SHA: Current master
CMake Version: 3.22.1
Compiler: gcc 9.4.0
Describe the problem
I installed openvdb and the python bindings according to the build instructions, but am unable to locate where pyopenvdb is installed. I am working inside a virtual environment, but doing
import pyopenvdb

results in a ModuleNotFoundError: No module named 'pyopenvdb'
Is there any way to set the install location of pyopenvdb that I am missing?
To Reproduce
git clone git@github.com:AcademySoftwareFoundation/openvdb.git
cd openvdb
mkdir build
cd build
cmake -DOPENVDB_BUILD_PYTHON_MODULE=ON -DUSE_NUMPY=ON ..
sudo make -j$(nproc) all install

in python:
import pyopenvdb

Additional context
I have tried importing pyopenvdb in my main python installation as well, so outside the virtual environment, but the same problem occurs there. I have also tried a different fork of openvdb with the same problem
Thanks in advance

I was able to solve the issue. There exists a flag PYOPENVDB_INSTALL_DIRECTORY that I had to set. In the end, my cmake command looked like this:
cmake -DOPENVDB_BUILD_PYTHON_MODULE=ON -DUSE_NUMPY=ON -DPYOPENVDB_INSTALL_DIRECTORY=".venv/lib/python/dist-packages .."


fix: bind released method to "this" context to properly access this.name on local scope

Hi!
This PR is fixing a bug that happens when the iomonad.js released event is fired. It's necessary to bind the released function so it can properly access the name property in the context, otherwise this will be undefined on the local scope and throw a type error.

Coverage increased (+0.08%) to 89.04% when pulling f70131ebc427a8e13bc8e26b3d0c20d961f7b580 on rafaelcardoso:hotfix/released-bind-this into 80b63c08bdb32d04fd36502f24180e0c8e8f69ee on arobson:master.

Coverage remained the same at 88.956% when pulling 6db5853f65212b290c82c3cc8133be2d29ef310d on rafaelcardoso:hotfix/released-bind-this into 80b63c08bdb32d04fd36502f24180e0c8e8f69ee on arobson:master.


Is there a way to send broadcast messages from the client

Is there a sample?

very good question

Duplicate of #114


Use youtube-dl

Includes #6, rebasing this on top of master would be a bit annoying because of the large number of changes in #6, but could probably be done if #6 is not accepted.

Oh, nice, back in 2018 there wasn't a crate for this (I remember looking for it).  This is much better!  I usually rebase before merging anyway, but I'll likely just merge this in one step this week end.  If you want I can also give you maintainer access btw.

I'm not sure if I'm going to make much use of the maintainer access, but sure, why not :)
Btw, what do you think about moving the various parts of this (the server, ultrastar-txt and this repository) into some common organization to make them easier to find? If not on GitHub, Spline GitLab or codeberg would be nice too.

Sorry for the delay, I thought I'd have merged this already.
Definitely an organization would be nice, but I only "own" this repository which should be rebranded anyways since ascii-star really is only about a minimal feature set and we have higher goals/ambitions.  Parts of it should be a library/crate anyways.


EIP-6110 Stop Eth1 data polling

PR Description
If we have already transitioned to the new deposit mechanism:

Don't log missing deposit data
Don't do actual Eth1Data vote, just return the one from the state
Don't update Eth1Data metrics
Don't initialize and start PowchainService services
Implement stop for AsyncRunLoop because TimeBasedEth1HeadTracker was running in loop and stop was not implemented

Also attached FinalizedCheckpointChannel to PowchainService to stop Eth1 polling when transitioned on the fly. I am not 100 % sure of the cleanest way to pass a state to PowchainService because RecentChainData is initialized after starting of the services, so passing it before that will be in null. That's why chose to pass a Supplier (along with some comments) but happy for suggestions.
Update:
Refactored PowchainService to initialize when starting. This has couple of benefits. No initialization needed when we have already finalized the transition to the new deposit mechanism. This allows thing like using the websockets web3j client after Electra instead of relying on http, so no more of this error:
if (executionWeb3jClientProvider.getWeb3JClient().isWebsocketsClient()) {
   throw new InvalidConfigurationException("Eth1 endpoint fallback is not compatible with Websockets execution engine endpoint");
 }

It also allows to log the eth1 polling disabling only in case it has been enabled before.
Fixed Issue(s)
will solve one of the tasks under #7898
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

Do I understand it correctly that since EIP-6110 we don't need DepositTree and snapshots any more? Though I think we need to approve it I still have some concerns on transition moment, that we are not breaking something too early when we are in Electra but former mechanism is not yet disabled. Anyway, we will run testnets for this.

Yes, once we have finalized state where eth1_deposit_index == deposit_receipts_start_index we no longer need the DepositTree and snapshots since the getDeposits method would be ZERO from that point onwards, so no merkle proof needed. So the idea here is to stop once we finalize such a state and also don't even initialize if the anchor point on startup is such a state.