presentation(s) for JMC need work

It just occurred to me to look at the JMC folder in the beamer presentation, which isn't currently working.
It would probably be quicker to just copy and paste elements from the recent SRG presentations than to manually edit the broken parts. I can work on this on Monday morning but probably not before.

Yes, can't it just be the main SRG presentation? Be easier to start with one of this year's I expect. I don't think Chris is in today - I can likely help if you need it.

I should be able to help later today, but tomorrow for sure.  Let me know
Ian what you are planning or if you want to discuss further.
On Mon, Feb 27, 2017 at 9:58 AM, andrew-edwards<EMAIL_ADDRESS>wrote:

Yes, can't it just be the main SRG presentation? Be easier to start with
one of this year's I expect. I don't think Chris is in today - I can likely
help if you need it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/296#issuecomment-282798189,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHk_-psRLLoJwmhBiwGaqDXK8YVbSimMks5rgw7XgaJpZM4ML3Pe
.

--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>

I think that pattern in the past has been to condense the longer SRG talks into a single presentation for the JMC, I finally looked at the agenda just now in
https://drive.google.com/drive/folders/0B8vORV3L9mJJdXhPdk9CZFNvbWM
and it seems that we're scheduled for tomorrow morning from 10-11am. That should be time for separate talks but probably only if they're condensed just a little from the SRG versions or we go very fast.
I'm happy to present any or all of the JTC stuff or leave it to anyone else.
Andy, are either or both of you and Chris attending the meeting?
Aaron, I know you're home recuperating from surgery, but happy to see that you're the painkillers aren't preventing you from writing coherent emails.

For some reason I thought the meeting started Weds.  Ok, Tuesday.... so
I'll be available throughout the day if you want to assign me a task.
I also see its labelled the 'JTC chairs' report on the agenda.  We don't
have a chair, but I suppose that would default to me this year.  So a big
thanks to you Ian (and others) for stepping in on my behalf to deliver the
report/presentation.  If applicable, please send along apologies to the JMC
for not attending (it's a good enough excuse I guess...).
On Mon, Feb 27, 2017 at 10:36 AM, Ian Taylor<EMAIL_ADDRESS>wrote:

I think that pattern in the past has been to condense the longer SRG talks
into a single presentation for the JMC, I finally looked at the agenda just
now in
https://drive.google.com/drive/folders/0B8vORV3L9mJJdXhPdk9CZFNvbWM
and it seems that we're scheduled for tomorrow morning from 10-11am. That
should be time for separate talks but probably only if they're condensed
just a little from the SRG versions or we go very fast.
I'm happy to present any or all of the JTC stuff or leave it to anyone
else.
Andy, are either or both of you and Chris attending the meeting?
Aaron, I know you're home recuperating from surgery, but happy to see that
you're the painkillers aren't preventing you from writing coherent emails.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/296#issuecomment-282808756,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHk_-p9ts4fjHUZaqY4nNugu9Bw369FLks5rgxetgaJpZM4ML3Pe
.

--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>

We've tried to clarify for years that the JTC doesn't have chairs, but I think that the JMC just keeps editing the same agenda document and doesn't bother to change it.
For simplicity, I think that a single presentation will be easier, even if all of us at the meeting take a share of presenting it. I'll make a stab at merging and winnowing the SRG talks over the next few hours and will share what I come up and ask for help or input as needed.

I see that last year's JMC talk was 29 slides, as opposed to a combined 89 slides in our 4 SRG presentations. I will email the file to you all in case you don't have it accessible.

Sorry for the string of postings instead of taking time to combine my thoughts into one. It seems that the talk I have is an unfinished draft which I just uploaded as beamer-hake-JMC_draft.pdf to
https://drive.google.com/drive/folders/0B5lSVg5Eq86ud0l0MEpsODF1eVU
The missing AtAge figure was last year's equivalent of our Fig 42.

 I just wanted to let you know I fixed the JMC presentation to work with this year's setup not long ago so you should be able to get it working without too much trouble. I don't have my computer with me or I would try to help.

Hi Chris,
Sucks that you're sick. Rest well. I agree that we don't all need to be there.
Looking at the file history, I see that you had it compiling successfully in November and then again in December so you're right, fixing up this presentation shouldn't be hard. I'll start with that and then can copy and paste a few slides from the SRG if there is new stuff that seems valuable to include.

I'm not going either to the JMC meeting - thanks Ian for attending. I think we forgot to discuss this, or you had maybe mentioned you'd be there (Chris said it is not too far away for you). Feels like we've hardly had time to pause in the last few weeks, and I hadn't even had time to think about attending it - my wife's away for work anyway, so I'd have childcare issues.
Comment here if you need anything done...

No worries. I don't mind representing the JTC.
Andy, can you help me understand how to compile the files in \extra-calculations?  I didn't take the time to  look through all the commits. Are these files linked in the assessment doc or do they create a stand-alone document?

Don't worry about those - they were just to show some people how the numbers in the new Table 25 were calculated (to prove that the numbers made sense). Good news is that I got the same answers as Table 25 doing them manually (the comments on earlier Issues helped).
.Snw files are just Sweave files (Sweave is the older version of knitr) - I based them on old .Snw files I had for expediency to get them done on Thursday. They're standalone files.
But just ignore them - I committed them to share with Chris mainly (which was good as I then got sick on Friday).
So - ignore!

Sounds good.
As Chris predicted, it wasn't too hard to get last year's JMC presentation working. I've made a few edits and changes, mostly just copying updates from the SRG slides, in recent commit: 35f089e. At this point there is not yet anything about time-varying selectivity, but I will add a few slides about that since it will surely be an element in the SRG presentations.
I don't think there's anything further needed from the rest of you at this stage, but if you have time to build the presentation and look over for errors before 10am tomorrow, please feel free. Thank you.

Builds okay and looks good.
Only issue - slide 14 bullet points. I'll take a quick stab at making them clearer.

Committed some suggestions. Hopefully they're useful (and all easily undoable). Mainly on the slide talking about prob of bad things happening - I don't think the text really helped explain much, but it's certainly useful to have a slide to talk about probabilities before jumping into the decision tables.

These all look great. Thank you. I think some of those not-super-helpful explanations have been recycled for a few years and the refresh is appreciated.

Indeed - plus we don't get time to think about this stuff much. I'm around in the morning, but that's probably too late for you. Looks like it's all in hand. Thanks again.

Looks great, I found one small grammar error on the last slide which I committed a fix for.
Also - during a call with the Canadian delegation last week I quickly tried to come up with a number for the 2017 starting biomass for the 2014 cohort in the cohort table. I was trying to multiply the surviving biomass of 1250.2 with the ratio of the age 3/age 2 from 2016 (1.5) as a quick-and-dirty method (they were putting on a lot of pressure). Unfortunately due to the pressure and other things that were happening on the call, I made a mistake and instead ended up multiplying the starting biomass from the year before (1661.3 * 1.5) which gave 2491. This is just a heads-up that you might hear this number from them. I did mention that it was in no way official so it hopefully won't be an issue.

Thank you. The "above well above B40%" phrase was copied from the management presentation at the SRG which means that I've probably looked at that sentence about 10 times by now without noticing the error.
Don't worry about the starting biomass calculations. Given that it takes multiple people and multiple iterations to get the grammar right in a sentence, it also takes time and teamwork to refine any more complex calculations.

I agree the presentation looks great Ian, nice job.  A couple of general
comments, none of which require changing the presentation for today.
1.forecast age compositions for 2017 fishery catch bar graph slide: first
point mentions assumptions about selectivity but another important
discussed is the use of overall mean weight-at-age.  The overall mean is
similar to recent years up to age 3 and 4, but then is somewhat higher for
ages 5+ (but that of course depends on how far back 'recent' means).
2. Summary slide: "uncertainty is large"
3. Harvest rule predicted catch for 2017 slide: just curious if the JMC (or
others) in the past have asked for forecasts using the highest posterior
density (or mode of posterior) TAC estimates.  Maybe that is something that
should be one of our default levels presented in the assessment document -
I'd want to know that level after looking at the posterior.
On Tue, Feb 28, 2017 at 7:58 AM, cgrandin<EMAIL_ADDRESS>wrote:

Looks great, I found one small grammar error on the last slide which I
committed a fix for.
Also - during a call with the Canadian delegation last week I quickly
tried to come up with a number for the 2017 starting biomass for the 2014
cohort in the cohort table. I was trying to multiply the surviving biomass
of 1250.2 with the ratio of the age 3/age 2 from 2016 (1.5) as a
quick-and-dirty method (they were putting on a lot of pressure).
Unfortunately due to the pressure and other things that were happening on
the call, I made a mistake and instead ended up multiplying the starting
biomass from the year before (1661.3 * 1.5) which gave 2491. This is just a
heads-up that you might hear this number from them. I did mention that it
was in no way official so it hopefully won't be an issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cgrandin/hake-assessment/issues/296#issuecomment-283079789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHk_-oWEn0n7OUomibK8ZU1LGqzYGPwYks5rhEQjgaJpZM4ML3Pe
.

--
Aaron M. Berger, Ph.D. Research Mathematical Statistician
Fishery Resource Analysis and Monitoring Division
Northwest Fisheries Science Center
2032 SE OSU Dr. Bldg. 955
Newport, OR 97365-5275
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Got it. Edited for 1 and 2. Presentation file uploaded to JMC Google Drive but not yet committed. Gotta get to meeting now.

Aaron's idea of exploring the Maximum Posterior Density for the default catch limit seems like a good idea although I haven't heard anyone request that number yet. The precise number would depend on the binning/smoothing assumptions.
Since that's not directly related to this issue and the talk won't change between now and 10am, I will close this issue.


Relativize some imports

Description
I noticed that there were a couple of absolute from napari... imports scattered here and there, so I did a grep and replaced them anywhere where it seemed reasonable. There are still a couple places where it's absolute, cause I wasn't sure if it was on purpose (conftest.py for example?) but I'm happy to fix those as well if necessary.

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Thanks for the fixes @brisvag

There are still a couple places where it's absolute, cause I wasn't sure if it was on purpose (conftest.py for example?) but I'm happy to fix those as well if necessary.

I think that anything related to tests and pytest should always use absolute imports.

I also think the benchmarks should remain absolute, since they are there for convenience but not distributed with napari, so eventually could live somewhere else.

Is there any reason to prefer relative over absolute imports other than being concise? In my experience, the conciseness rarely saves lines and often just means my poor brain has to jump up a few directories to work out where that module is. Note that PEP 8 generally recommends absolute imports, though also clarifies relative imports can be fine too. I don't feel strongly here, but am curious about the preference.

For it's for:

consistency: I don't like having ajust a couple of absolute ones, it seems they refer to an external package
brevity

I agree that it can be confusing, but really the problem there is that we're not very good at naming modules... we have utils in a bunch of places :P

I'm against this change. I would even change all imports starting with more on dot to absolute import. The only reason is that gthub interface doe not follow relative import
Absolute import screenshot:

Relative import screenshot:

So relative imports make it harder to review someone's changes or respond to someone's questions as I first need to launch IDE, follow imports, and when found the source, go to browser and determine all links to be in response. Thi is even more problematic, when I need to switch branch from currently working.

Those are good points. I just feel like consistency is valuable here, so maybe we should consider switching to absolute everywhere :P

https://github.com/MarcoGorelli/absolufy-imports

MarcoGorelli/absolufy-imports

I just want to post the same link.
At this moment, I do not found a tool that allows doing relative import in the same package, but not from parent packages.

I think is consistency is very importante. I do not have an argument for relative imports, I prefer absolute ones :)
So all in for making the absolute, or just uniform if not absolute. 🚀


Maybe: Wrong dependency versions in Master / v0.7.2 ?

Hi,
currently I cant install videogular via bower using angular 1.3.7 because dependencies in
https://github.com/2fdevs/bower-videogular/blob/master/bower.json aiming on angular 1.2.x
Current master's dependencies are focusing 1.3.x
https://github.com/2fdevs/bower-videogular/blob/v0.7.2/bower.json
Is this a mistake?

Yes, this is related with #2 and we're working on v1.0.0 that will solve this problems very soon.

https://github.com/2fdevs/bower-videogular/issues/2 is still open. Soon? =)

Yes, I will try to fix this issue and #4 this week.

As I said in #4 I will fix this for v1.0.0 but not previous releases in order to maintain what people could expect.


Algorithm for blind movement as a function of distance and time

Inspired by this discussion https://github.com/dxdc/homebridge-blinds/pull/41 I'm taking a stab at a physics-based equation for determining blind movement.
This YouTube seems like a good first start: https://www.youtube.com/watch?v=UJF_34TSAwQ
Initial results seem promising, if the physics interpretation are correct, although it doesn't account for gravity and I'm not quite sure how to do that yet.
Download file

TimeFormula.xlsx

Background
It's based on the following parameters:

Mass of blind per unit height
Mass of any weight at the bottom of blinds (e.g., most blinds have some kind of weight at the bottom)
Total height of blinds
Time for blinds to move from bottom to top

I'm attaching a draft Excel sheet here, which is set up for both Imperial and Si units.
How to Use
To use it, first input the following parameters. I estimated them in this case.

Then, review the data table/graph below.

Finally, to perform a specific calculation, just input the starting and ending %.

@slavikme After some reflection, I realized I'm really overthinking this :)
I studied my blinds a bit more... here's what I can tell (and would be curious to your analysis also). I'm wondering if the uptime/downtime is actually too simplistic and an imprecise way to deal with the cause.
For me, the speed of the blinds (once moving) appears to be constant regardless of the direction of the blinds.
If this is true for you as well, this leaves us with the two edge cases -- blinds at the top, and blinds at the bottom.
A lot of this depends on how the vertical limit is set for the blinds, both at the top and bottom. At the top, additional motor turn will not result in very much vertical rise in the blinds - just compression of the material. At the bottom, additional motor turn will just lower more material to the floor.
So, the problem is that what we're calibrating as "0%" or "100%" is really more like "-5%" or "103%" for example. So, I'm thinking about something like this:
Mark the the following positions for your blinds: 0%, 10%, 90%, 100%, then measure the time:

A: to raise from 0% to 10% (use motor noise, not just movement)
B: to raise from 10% to 90%
C: to raise from 90% to 100% (use motor noise, not just movement)

motionTime = B / 0.8
extraTimeFrom0to1 = A - (B / 4)
extraTimeFrom100to99 = A - (C / 4)

Then, we can apply these extra delays at the edges. Let me know how this compares with your observations!

Btw, another way to confirm if this is correct for you:

Set motionTime to a constant value (both up and down)
Mark position on the wall
Set blinds at 20% and mark position on wall
Cycle blinds between 80% and 20%. It doesn't matter if this is accurate in terms of height, just that it stopping at the same position after multiple runs. Of course, response_lag will need to be set properly as well for this to work accurately.

The other parameter that could be important, btw, is a different motor delay blinds going up vs. down due to the difference in acceleration. I'm not sure how significant this would be though, depends on the overall weight of the blinds. This would be more in line with what I presented in the top of this issue since the mass will vary depending on the height of the blinds.


fix issue #669 - invalid prop dispatch on  tag for React Native Web

Please read and mark the following check list before creating a pull request:

[x] I read and followed the CONTRIBUTING.md guide.
[x] I read and followed the New Feature Checklist guide.

Short description of what this resolves:
Whenever using a Button and a Text component with ReactJS v16..0 even though elements are rendered and they work as expected an error message is displayed with the text:

Warning: Invalid value for prop dispatch on  tag. Either remove it from the element, or pass a string or number value to keep it in the DOM. For details, see https://fb.me/react-attribute-behavior

Thanks for opening a PR @gianpaj! 👍
I don't think this is a good solution because now it leaves an unused dispatch variable. I also have some ideas to solve this issue in a better way but I'm not able to solve this right now. You may contact us via support email if interested in contributions.


bug: New metamask "Set a spending cap" feature causes transaction to fail

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.12.6
Current Behavior
Metamask (v.10.26.2) added new feature for approving amount.
Now, when calling approve function on contract, additional metamask dialog appears where amount for approve needs to be confirmed.
When setting amount in addition metamask dialog larger (for example: 20) than initially approved (for example: 1) in most cases following error will appear:
next-dev.js?3515:20 Error: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data="0x", transaction={"from":"0xdEB2746e8f40397056Dbf39F30f99217D81C399E","to":"0x501dF51feDd7fA301eca905184F5FDd0737395a8","type":2,"accessList":null}, error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":80,\"error\":{\"code\":-32000,\"message\":\"execution reverted\"}}","error":{"code":-32000},"requestBody":"{\"method\":\"eth_call\",\"params\":[{\"type\":\"0x2\",\"from\":\"0xdeb2746e8f40397056dbf39f30f99217d81c399e\",\"to\":\"0x501df51fedd7fa301eca905184f5fdd0737395a8\"},\"0x852b54\"],\"id\":80,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://rpc.ankr.com/eth_goerli"}, code=CALL_EXCEPTION, version=providers/5.7.2)
at Logger.makeError (index.js?dd68:224:1)
at Logger.throwError (index.js?dd68:233:1)
at checkError (json-rpc-provider.js?8679:64:1)
at StaticJsonRpcProvider.eval (json-rpc-provider.js?8679:575:1)
at Generator.throw (<anonymous>)
at rejected (json-rpc-provider.js?8679:6:42)

When I try to do this directly on contract (example: https://goerli.etherscan.io/address/0x501df51fedd7fa301eca905184f5fdd0737395a8#code ), there is no error and transaction passes.
Expected Behavior
Transaction should complete without error.
Steps To Reproduce

Open Minimal Reproducible Example.
Connect to metamask wallet
Click on Approve button
Set amount to 20 in additional "Set a spending cap" metamask dialog
Confirm transaction
Check console

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
https://stackblitz.com/edit/next-typescript-9p9q8e?file=pages%2F_app.tsx,pages%2Findex.tsx
Anything else?
No response

For me, it seems like I get this error when the contract reverts, which is expected. My guess is that something is happening in the contract, because the calldata I sent between a successful call and a reverted call was identical.


oauth error using example code from External wiki page

When trying to sign in via github, it works the first time. However, after I sign out (using the built-in logout method), authorizing via Github throws this error:
bad_verification_code: The code passed is incorrect or expired. error=bad_verification_code&error_description=The+code+passed+is+incorrect+or+expired.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23bad-verification-code

Hi @jsierles, I'm sorry for late reply. Have you solved this issue? Is it something that we need to fix in Sorcery?

Sorry - this was some issue with my specific github account, I believe. I'll reopen if it pops up again. Thanks!


Why use this connector the system privilege OPTIMIZER ADMIN

In the connector log appears:
[2018-09-17 08:50:15,844] INFO Table "U220619"."u220619_avro" exists.Validate the schema and check if schema needs to evolve (com.sap.kafka.connect.sink.hana.HANASinkTask)
[2018-09-17 08:50:15,844] INFO flush records into HANA (com.sap.kafka.connect.sink.hana.HANAWriter)
[2018-09-17 08:50:15,854] INFO flushing records to HANA successful (com.sap.kafka.connect.sink.hana.HANAWriter)
[2018-09-17 08:50:15,854] INFO PHASE - 1 ended for task, with assigned partitions [u220619_avro-9, u220619_avro-8, u220619_avro-11, u220619_avro-10, u220619_avro-1, u220619_avro-0, u220619_avro-3, u220619_avro-2, u220619_avro-5, u220619_avro-4, u220619_avro-7, u220619_avro-6] (com.sap.kafka.connect.sink.hana.HANASinkTask)

In SAP HANA no rows are in the table. I found the following error in the SAP HANA trace:
[14780]{308580}[36/-1] 2018-09-14 14:36:06.094788 i TraceContext     TraceContext.cpp(01108) : UserName=U220619, ApplicationUserName=u220619, ApplicationName=HDBStudio, ApplicationSource=csns.admin.commands.AdministrationHandler$1$1.call(AdministrationHandler.java:338);csns.admin.commands.AdministrationHandler$1$1.call(AdministrationHandler.java:1);java.util.concurrent.FutureTask.run(FutureTask.java:266);java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149);java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624);java.lang.Thread.run(Thread.java:808);, StatementHash=30a6992ab41b9ef3cde46d535b1a39e4, StatementExecutionID=1407387769045229
[14780]{308580}[36/-1] 2018-09-14 14:36:06.094781 i Authorization    SQLFacade.cpp(02593) : User U220619 is missing system privilege(s): OPTIMIZER ADMIN

After I fix it, all Messages are written in the table. Why use this connector this privilege and why apears no error by writing the message?

Hello @git-aybo ,
Can you plz check & let me know how a normal insert statement behaves in such a case?
For example:
insert into "U220619"."u220619_avro" values('', '')

Does it throw any error that it cannot insert?

Hi sbcd90
An insert in sapstudio works fine, without error.

@git-aybo I apologise for the delay. It has been a while and we have fixed several issues. Therefore, I am closing this ticket.
I think the error that you saw was unrelated and came from your admin tool which required that privilege.
The connector itself doesn't require anything other than the grant required to create an update the table in the relevant schema. The particular log from the connector seems to indicate no records were in the flush buffer.
If you encounter some issue using the current version, please open a new issue.
Thanks.

@git-aybo I apologise for the delay. It has been a while and we have fixed several issues. Therefore, I am closing this ticket.
I think the error that you saw was unrelated and came from your admin tool which required that privilege.
The connector itself doesn't require anything other than the grant required to create an update the table in the relevant schema. The particular log from the connector seems to indicate no records were in the flush buffer.
If you encounter some issue using the current version, please open a new issue.
Thanks.


fix/help function: 'NoneType' object has no attribute 'format_help'

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
New try/except block to catch AtributeError mentioned in issue #5189
This error is encountered whenever a help argument does not exist, resulting in subparser being of NoneType
Tests performed by the developer:
Tips for QA testing:

LGTM!
-- Review provided in representation of the Hummingbot Foundation Technical DAO

PRP at Snapshot:
https://snapshot.org/#/hbot-prp.eth/proposal/0x8ae60e50253ad2ea68b5156efe60b9b4e1a62ed8b4ee08719791220b2f102a32

PRP Snapshot Link:
https://snapshot.org/#/hbot-prp.eth/proposal/0xd0f4b5538168f3a5a0c38d8512effcee65f209144f0ca40e88a2d2d2d8263d9d

Hi @ashrajesh, please rebase your PR to development because we don't push changes to master branch

Hi @ashrajesh, please make the necessary changes or we will close this PR. Thanks!


OS Capacity: Support providing a CA certificate

For clouds that use an internal CA, it is necessary to provide a CA certificate to OS capacity.

Adapted from https://github.com/stackhpc/stackhpc-kayobe-config/pull/896/

Has this been tested?
When testing #896 on SMS lab the container would always crash on SSL validation even when the cacert was provided and mounted in the container.
That could’ve just been me messing it up though.

I've tested it in a multinode, and it fixed the container's restart loop.


[requires.io] dependency update on master branch

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.

Coverage remained the same at 71.43% when pulling b1ef295ce033202ed2c650fa5485148843885576 on requires-io-master into 5b51a02986bd1c25e5f7ed24aa1049de8801d97f on master.


add hexo-generator-readtime plugin

https://hexo.io/docs/plugins#Publishing
https://github.com/AsemAlhaidary/hexo-generator-readtime/issues/2
Check List
Please read and check followings before submitting a PR.

[ ] I want to publish my theme on Hexo official website.

[ ] I have read the theme publishing doc.
[ ] name is unique.
[ ] link URL is correct.
[ ] preview URL is correct.
[ ] preview URL web site is rendered correctly.
[ ] Add a screenshot to source/themes/screenshots.
[ ] Screenshot filename is same as value of name.
[ ] Screenshot size is 800 * 500.
[ ] Screenshot file format is png.

[x] I want to publish my plugin on Hexo official website.

[x] I have read the plugin publishing doc.
[x] name is unique.
[x] link URL is correct.

[ ] Others (Update, fix, translation, etc...)

Languages:
[ ] en English
[ ] ru Russian
[ ] zh-cn simplified Chinese
[ ] zh-tw traditional Chinese

Note
No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning
ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

Only need to add the readTime plugin (from the data file). Don't merge the other changes.

Apologies. Files restored.


Show all service offerings even those which don't fit account resource limitations

For service offerings which cannot be created when a user selects, show the modal dialog with the message:
"The service offering cannot be selected because it doesn't fit the account resources available."

To separate into 2 issues

@bwsw We suggest showing a message in the list and disable select button instead of opening a modal dialog. Please, take a look

@ershovaelena looks good

Description changed

@rennervo  Check our document in google disk with use cases
Test:
vm_creation_so, vm_creation_so_custom, vm_SO_change

Lack:1
1) Custom service offerings are not available for selection if the account has unlimited resources.
Selection of Custom SO is not available when account resources have limits is "infinity". The behavior is repeated to create the VM and for the VM sidebar
Steps:

Log in and make sure that the resources of the current account are not limited
Go to VM and click to "Create" button (Screenshot 1)
Click to "Select" in "Service offering" string
Go to "Custom" tab and click to any Custom SO

Actual result: There is an error about the lack of resources, select of any custom SO is not available (Screenshot 2)
Expected result: No error, any Custom SO is available for selection.
Feature ID: vm_creation_so_custom, vm_SO_change

2) An error message appears in the console with the text " Cannot read property 'isAvailableByResources' of undefined " if the default is Custom SO
If the custom SO is selected by default, an error will appear in the console when opening a window for selecting SO when VM creating. The behavior is repeated if you create a VM with a custom SO, go to the sidebar of the VM and try to change SO.
Steps:

Select custom SO as by default in config.json
Log in and go to VM
Click to "Create" button
Click to "Select" in service offering string and go to "Custom" tab

Actual result: An error message appears in the console with the text " Cannot read property 'isAvailableByResources' of undefined "
Expected result: No error

Additional bug (based on discussion with PO):
3) SO changing not available when not enough free resources to create the selected SO in full
An error about insufficient resources appears in if the user does not have enough free resources to fully cover the selected service offering. This happens if a change is made to the SO more than the current one, less than the current one and equal to the current one.
Steps:

Create a new account with limits (3 CPU, 1536 Mb of RAM)
Log in as created user
Go to VM
Create VM with custom SO (2 CPU and 1024 Mb of RAM) (Screenshot 1)
Go to the sidebar of created VM and click to "Change" icon in SO area
Click to Custom SO (Screenshot 2)

Actual result: Fields for settings parameters of SO are not available, an error about insufficient resources appears, SO cannot be changed.
Expected result: The change in the SO is allowed, a resource failure error occurs only if the additional resources requested are greater than the total number of resources minus the resources occupied.
Feature ID: vm_SO_change
Screenshots:


Retry history (or maybe request history via retries?)

Would be great if we have somekind of retry request history in the retry object. There's a TODO for this in the code.
Ideally we'd do this by replacing our observed errors counter with a list of objects describing the respective requests.
If we end up doing a request history (and requests have a retry attached per #578), then this issue would be obsolete.
Related: #185 which adds redirect_history, but we should be able to do better now that we've refactored some of the code.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9920040-retry-history-or-maybe-request-history-via-retries?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github).

I might take a look at this sometime in the future. Of course if someone wants to get involved in urllib3 we can work together on it if you'd like.

This should be resolved in #848.


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 68.286% when pulling f54356a11beb14e15bdfb675c32ae86af5509f80 on analysis-orMN5N into 208b4b88d63a5c0ae07f8dc2f5304f3ec81ea0fb on 2.0.3.

Coverage remained the same at 68.286% when pulling f54356a11beb14e15bdfb675c32ae86af5509f80 on analysis-orMN5N into 208b4b88d63a5c0ae07f8dc2f5304f3ec81ea0fb on 2.0.3.


Build(deps-dev): Bump ts-loader from 9.4.1 to 9.4.2 (#4447)

Pull request opened by the merge tool on behalf of #4447

Merged in b97668d0b9b90675c07eab7dfdb72bae660e94c2


Fix statevector silently dropping final measurements

Summary
This fixes a bug where the BasicAer statevector simulator was returning different output to the Aer statevector simulator.
Details and comments
The BasicAer statevector simulator was silently dropping final measurements which should have collapsed the statevector on circuits where measure sampling was valid. This PR fixes this issue by disabling measure sampling if the number of shots in the circuits is not greater than 1.

can you add a test for the bug?


Possible new option

An interesting option could be to implement a score based cutoff... so instead of providing the number of primitives one would specify the desired "score" where the result should be produced.
I am not sure I fully understand the scoring at the moment. Is a score of 1 (1 x 100) meaning 100% away from source picture and a score of 0.01 (0.01 x 100) meaning 1% away from source...

I created a pull request for this feature: https://github.com/fogleman/primitive/pull/29


Different installation doc for DTLS steps in examples/client/README.md and README.md

Following the doc in the "client" example's README (https://github.com/eclipse/wakaama/blob/master/examples/client/README.md), I get stuck at the autoreconf part :

cd examples/shared/tinydtls
autoreconf -i ./configure
autoreconf: 'configure.ac' or 'configure.in' is required

However the doc from the main README.md seems to work better.

Thank you for spotting this.
Fixed by #204


Allow customize the application name

Allow customize the application name ie this one :

Close #172

/retest

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5a69de4). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage        ?   69.54%
=======================================
  Files           ?       22
  Lines           ?     1392
  Branches        ?        0
=======================================
  Hits            ?      968
  Misses          ?      315
  Partials        ?      109

Impacted Files
Coverage Δ

cmd/pipelines-as-code/main.go
41.66% <100.00%> (ø)

pkg/cmd/pipelineascode/pipelineascode.go
68.25% <100.00%> (ø)

pkg/webvcs/github.go
73.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a69de4...dac3136. Read the comment docs.


Tutorial Docker gives error about 4.1 version

Description:
manifest for wso2/wso2am:4.1.0 not found
Suggested Labels:
Update repository to fix this issue as this image is not found.
Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

The Docker Image for version 4.1.0 does not exist, you can use the latest or the 4.0.0(the latest right now).
https://hub.docker.com/r/wso2/wso2am


Feature request: object storage performance testing

Is anyone currently working on adding an object storage performance workload (cosbench/warp/hsbench) or would that be something new to contribute?

Is anyone currently working on adding an object storage performance workload (cosbench/warp/hsbench) or would that be something new to contribute?

This would be new.
I am familiar with cosbench but not the others. Happy for someone to contribute that.

fio also has an http ioengine:
https://github.com/axboe/fio/blob/master/examples/http-s3.fio
This would be very easy to add to the current fio_distributed ansible role by creating a new configmap and a few variables. The gotcha seems to be that the filename_format would be something like
filename_format=/{{workload_args.http_s3_bucket}}/fio-object.${HOSTNAME}.$jobnum
instead of
filename_format=f.$jobnum.$filenum
which testing shows is incompatible with the fio wrapper:
https://github.com/cloud-bulldozer/benchmark-wrapper/blob/ab94b45c644cb0015a64661a32588d584e81b181/snafu/fio_wrapper/trigger_fio.py
Not sure if updating the trigger_fio.py script would be more work than adding a new workload for cosbench.

fio is not intended for object storage benchmarks, don't use that.   Talk
to Shekhar Berry, he has a OCS S3 COSBench-based benchmark.  Let me know if
you have trouble getting that into benchmark-operator.
On Wed, Nov 25, 2020 at 1:31 PM Frank Ritchie<EMAIL_ADDRESS>wrote:

fio also has an http ioengine:
https://github.com/axboe/fio/blob/master/examples/http-s3.fio
This would be very easy to add to the current fio_distributed ansible role
by creating a new configmap and a few variables. The gotcha seems to be
that the filename_format would be something like
filename_format=/{{workload_args.http_s3_bucket}}/fio-object.${HOSTNAME}.$jobnum
instead of
filename_format=f.$jobnum.$filenum
which testing shows is incompatible with the fio wrapper:
https://github.com/cloud-bulldozer/benchmark-wrapper/blob/ab94b45c644cb0015a64661a32588d584e81b181/snafu/fio_wrapper/trigger_fio.py
Not sure if updating the trigger_fio.py script would be more work than
adding a new workload for cosbench.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloud-bulldozer/benchmark-operator/issues/479#issuecomment-733880065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANDG4YHM6ERAQEVKHA2NKTSRVEOZANCNFSM4T3TXNGA
.

opening back up

I was on PTO last week, but I'm working on it.


python310Packages.pip-tools: update format

Description of changes
Fix build (https://hydra.nixos.org/build/205585354)
Fixes #211343

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 212459 run on x86_64-linux 1

2 packages built:

python310Packages.pip-tools
python311Packages.pip-tools


Add signed integer extend instructions

Noticed that these were missing. Let me know if there's anything you'd like me to change.

Looks good to me. Thanks for adding these!

Looks good to me. Thanks for adding these!


feat: simplify special asset pairs calculations

Seeing some wierd go mod errors on builds and tests - started appearing 3 commits ago at 497e5be

Note: The original bug was in the logic for pairing normal assets durign max withdrawal, in which the position object was mutated by subtracting borrowed and collateral values from special asset pairs. The amount subtracted was too high, resulting in a negative coin amount.
This logic no longer exists in the refactor


corrected behaviour spelling in conduct file

Corrected all the spelling from conduct.md file.

Behavior is the preferred spelling in American English, so there is no need of any correction in the spelling.


fix: normalize windows paths to slashes

#43 without lockfile conflicts. Fixes #80.
Since I wasn't the author and the PR is 9 months old, I figured I would make a new one instead of waiting for the original author from the old one. Credits for this PR goes to @kling90.

No clue why the build failed. I tested it locally, ran into for building but I assume it's because I'm on windows.
I had to change build:node  from package kit-docs to get it to build by passing all arguments directly to node.
{
    "build:node": "pnpm build:node:ext",
    "build:node:ext": "node ../../.scripts/build.js --external=vite,@sveltejs,shiki --entry=src/node/index.ts --outdir=node --platform=node --bundle --requireshim",
}

Working fine locally, here's a screenshot of the bug fixed

As you can see, both categories and Previous / Next buttons are working fine


Allow starting learning rate to be changed in range_test()

Allows the user to change the starting learning rate when calling LRFinder.range_test() instead of relying on what was set at the time the optimizer was created.
Also, documents in the README that the optimizer shouldn't have a scheduler attached to it.
Related to #11

I've run this revision and all worked fine!
However, would it be better to throw an exception/warning to remind user about the issue you mentioned?

Also, documents in the README that the optimizer shouldn't have a scheduler attached to it.

Beside, it seems would be better to convert start_lr to a list and assign the new value to each parameter group of the optimizer. It would be useful if users want to use LRFinder with a model in which lr is different in some layers (I recall that it called layer-wise learning rate).

@NaleRaphael think your suggestions are implemented. Thanks for the feedback

That's nice! I've run the latest revision and it worked fine.
Thanks for your effort, too!

I'm a bit late to the PR, but everything looks great. Good job lads!


update pyyaml to 6.0.0

Thanks for the pull request, I checked and after upgrading the version everything works, also accepted.


high error rate on training RTL  Persian-Arabic script

I am training persian-Arabic script
generated image lines= 500
why do I get a very high error rate
2 Percent improvement time=5600, best error was 99.665 @ 1000
At iteration 6600/6600/6600, Mean rms=8.606%, delta=51.091%, char train=97.628%, word train=99.967%, skip ratio=0%,  New best char error = 97.628 wrote checkpoint.
is this because of the limited line number or something else?
different fonts used in images but the ground truth is written in one font style is this causes high error rate ?

Well, with 6000 steps and 500 lines CER should be way lower. But it is hard to tell from a distance without knowing your data... Sry.

@sam-kurdi, could you solve the problem? RTL needs special handling when generating the box files and currently not supported out-of-the-box by tesstrain.

according to this issue
https://github.com/tesseract-ocr/tesstrain/issues/157#issuecomment-614774418
suggested by Shree, I did this modification and will test.
Changes to the generate_wordstr_box.py as follow:
create WordStr line boxes for Indic & RTL
for line in lines:
line = unicodedata.normalize('NFC', line.strip())
if args.rtl:
#FIXME: This should not be necessary. Compare with e.g. kraken
line = line.translate(str.maketrans("()[]{}»«><", ")(][}{«»<>"))
if line:
print("WordStr 0 0 %d %d 0 #%s" % (width, height, line))
print("\t 0 0 %d %d 0" % (width, height))'
On Thu, Apr 16, 2020 at 8:19 PM Stefan Weil<EMAIL_ADDRESS>wrote:

@sam-kurdi https://github.com/sam-kurdi, could you solve the problem?
RTL needs special handling when generating the box files and currently not
supported out-of-the-box by tesstrain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesstrain/issues/151#issuecomment-614784659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOZY7DRRYQEMRD5PSHUOHQ3RM443ZANCNFSM4LS22F6A
.


[feature]: Examples should be shown as Notebooks in Kaggle platforms.

We will show our example in Kaggle platforms.

As we discussed, we implement all the example inside unit test. So, we do not need to add further example code.


Added release note, changed formatting

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66e4be01a3e53a885f84e288--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66e4be541d296b98678451cc--harness-developer.netlify.app


Callback for getConnection not firing

I am creating my first node app in lambda accessing mysql.  It appears that the callback for the getConnection is not being called.  I am sure this is something I am doing wrong.  In the output
I am seeing the "1" log entry but never see the "1.5", "2", "3" or "4".  I then do get the "I should not be here".
I am not sure what would cause it not to fire.  I can run this locally minus the exports.handler with a local mysql and it works just fine.  There is something with how it is working in Amazon Lambda that I cannot figure out.  What is the best way to debug this?
'use strict';
console.log('Loading evoman');

// create connection pool for mysql
var mysql = require('mysql');
var dbconfig = require('./database.json');

exports.handler = (event, context, callback) => {

    var pool  = mysql.createPool({
        host        : dbconfig.dbhost,
        user        : dbconfig.dbuser,
        password    : dbconfig.dbpassword,
        database    : dbconfig.dbdatabase,
        insecureAuth: true
    });

    //console.log(pool);

    context.callbackWaitsForEmptyEventLoop = false;
    console.log("1");

    pool.getConnection(function(err, connection) {
        console.log("1.5");
        if (err) {
            callback(err);
        }

        console.log("2");

        connection.query('SELECT * FROM EventTickets', function (error, results, fields) {
            console.log("3");

            connection.release();

            if (error) {
                callback(error);

            } else {
                callback(null, results);
            }
        });

        console.log("4");

    });

console.log("I should not be here");
//callback(null, "it did not end well");

};

I think it's something to do with your Lambda trying to connect to your MySql server and ending on connection time out. Please check your Lambda configuration if it has access to your MySql server or reside inside the VPC of your RDS (if your mysql is in the RDS).
Try also to ping the mysql server to check if my doubt is correct.
connection.ping(function (err) {
  if (err) console.log(err);
  console.log('Server responded to ping');
})

You were correct, I made a change so I could use Mysql workbench from here and then when I was done backed it out and backed out too much.
But this brings up another question.  Why does it not return an err or something so that you know what the problem is?  Or does it indicate somehow and I am not checking for it?  A timeout error is what I would expect to get back in this scenario.
Thank you for the help.

Hi @netnutmike it should be returning an error, including a timeout error. It's really weird that it's not and I'm not sure why. I would like to debug through the issue and see what is happening. Can you provide instructions for how I can replicate the issue? Thanks!

Have you received timeout on Lambda?
I'm pretty sure you didn't get any connection from the pool and before callback error return, Lambda function ended on timeout.


Cannot read property 'parentNode' of null at Avatar._scaleTextNode

Hi,
When I create a new contact in my app there is this error:

It's null:

I can make the check that should prevent this more strict. But even with the current check this should not be happening.
Could you create a small example / demo of how you are using the Avatar component on codesandbox? That should help me diagnose the root cause of this issue.

Experiencing similar issue.

Props passed -
<Avatar name={fullName} round unstyled maxInitials={2} size={35} />

Scope when Conditional Breakpoint was triggered -

Please check this issue and provide any suitable fix/suggestion, Thanks !

Hi @gswebspace
Thanks for letting us know this issue still exists, however I was unable to reproduce the issue you are experiencing with the information provided (see test). Would you mind setting up a sample on codesandbox.io (or something similar) that exhibits the described behaviour? This would help a great deal in solving this issue.

Hi @JorgenEvens, I tried a very basic integration and it works fine. So this is probably not a major issue.
My hunch is that, I am using bootstrap to show/hide user detail panels based on clicking a users avatar. That causes the available space for the list itself to change as the panel mounts and this might be triggering a media query for a few milli-seconds in which the list itself is hidden and re-appears with list+panel both(for a user nothing changes in the list area, but I can see a flicker if I really focus).
In this small gap when the timeout triggers, maybe the spanNode/parentNode actually does not exist in the dom (bcoz the whole list dissapears and comes back).
This is just a theory, you can probably understand better the code internals.
I will try to improve the css first (which can take a while), maybe that is what needs to be fixed.

Thanks for the update @gswebspace, I've tested for scenario's such as the one you are describing before and they didn't seem to present any issues. I'll see later today if I can re-create the issue some other way.

@jaemil I have the same issue.
to reproduce:
<div style={{display: 'none'}}>
  <Avatar name={name} />
</div>

@JorgenEvens @jaemil found and fixed the issue. more details in the PR https://github.com/Sitebase/react-avatar/pull/229


msvc: remove direct Bitcoin Core compat.h include

My (untested) assumption is that this was only being used for a ssize_t
definition. Remove the include, and define ssize_t to SSIZE_T.
I'm planning on making a similar change in the Core codebase, and will pull a subtree update if this is merged.
See:
https://docs.microsoft.com/en-us/windows/win32/winprog/windows-data-types#ssize_t

@fanquake Does Bitcoin Core compile on MSVC with this change? Because minisketch itself has no MSVC CI.

@sipa I cherry-picked a subtree update + this change into https://github.com/bitcoin/bitcoin/pull/25493, to test the MSVC CI, and it's compiled / run the unit tests fine. Functional tests running at the moment: https://cirrus-ci.com/task/6565150772690944.

MSVC build has finished all green in our repo.


Help tooltip is cropped on mobile

iOs 14 safari - the help tooltip text is cropped. It needs to be moved to be displayed in the visible browser area.

Done

verified


Zero-shot Code

Thanks for the great work! Can you share the code of zero-shot transfer on the ESC-50 and Urban sound 8k? Thanks.

Hi there,
We haven't done zs exp on esc-50/urban sound 8k so don't have code to share.
-Yuan

Thank you for your response


Quantifying fsatrace's coverage

For a paper we're writing about Rattle (which uses fsatrace) we'd like to quantify in some way how much of the filesystem API fsatrace covers. Right now, it looks like 25 functions are overridden on Linux, which is my estimate just by grepping for R(. Is that accurate? Is there a way to tell how many relevant functions glibc provides? Or anything else in this neighborhood?
cc @ndmitchell @spall

Grepping for R( won't do it, since there're some #ifdefs and some bare calls to resolv. I guess you can invoke a preprocessor pass via gcc -E and count the resolv( occurrences (subtract 1 for the definition itself).
As to figuring out the glibc functions, no idea. I picked that set using nm, looking at the weak symbols in the library and trying to figure out which ones were relevant. But I guess there must be some documentation.
Please, share the results, I might have missed a bunch of hooks.

I ended up looking manually, and counting the calls to resolv etc. I have been unable to find anything that mentions xlstat at all, so my documentation search was pretty fruitless.


Enable resumable downloads or hf transfer

Hey
So it seems like the download wrapper  doesn't use the keyword arg resumable_download (see here)
So I'm proposing to either use resumable downloads (a bit slower but resumable in case of a failed connection or a crash) or if not use maybe use hf_transfer.
The latter require both a new dependency and a new key in the package.json

Added resume_download keyword


Type Geograph

I get this error while migrating my database from Render.
  // geolocation
  @Column({
    type: 'geography',
    spatialFeatureType: 'Point',
    srid: 4326,
    nullable: true,
  })
  @ApiProperty({
    description: 'GeoLocation of the farmhub',
    type: String,
    example: {
      type: 'Point',
      coordinates: [116.443987, 39.920843],
    },
  })
  GeoLocation: Point;

QueryFailedError: type "geography" does not exist
at PostgresQueryRunner.query (/home/beaver/ifoodsos/nccgbackend/src/driver/postgres/PostgresQueryRunner.ts:331:19)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at PostgresQueryRunner.executeQueries (/home/beaver/ifoodsos/nccgbackend/src/query-runner/BaseQueryRunner.ts:660:13)
at PostgresQueryRunner.createTable (/home/beaver/ifoodsos/nccgbackend/src/driver/postgres/PostgresQueryRunner.ts:610:9)
at RdbmsSchemaBuilder.createNewTables (/home/beaver/ifoodsos/nccgbackend/src/schema-builder/RdbmsSchemaBuilder.ts:635:13)
at RdbmsSchemaBuilder.executeSchemaSyncOperationsInProperOrder (/home/beaver/ifoodsos/nccgbackend/src/schema-builder/RdbmsSchemaBuilder.ts:225:9)
at RdbmsSchemaBuilder.build (/home/beaver/ifoodsos/nccgbackend/src/schema-builder/RdbmsSchemaBuilder.ts:95:13)
at DataSource.synchronize (/home/beaver/ifoodsos/nccgbackend/src/data-source/DataSource.ts:339:9)
at DataSource.initialize (/home/beaver/ifoodsos/nccgbackend/src/data-source/DataSource.ts:277:43)
QueryFailedError: type "geography" does not exist

This template is just plain Postgres database, you would likely want to use the PostGIS template - https://railway.app/template/postgis


Radiation tool fails on ninecubes scenario

The scenario we ship as an example does not work with the radiation tool. We found this out while installing the CEA on johannes' computer.  It might also fail for other scenarios:
Executing: RadiationTool C:\Users\johhofer\Documents\CEA\ninecubes\baseline Zurich 2014 46.9524055555556 7.43958333333333
Start Time: Mon Jan 09 15:17:57 2017
Running script RadiationTool...
longitude: 7.43958333333
latitude: 46.9524055556
complete calculating sunrise
complete burning buildings into raster
complete calculating boundaries

Traceback (most recent call last):
  File "C:\Users\johhofer\Documents\GitHub\CEAforArcGIS\cea\GUI\radiation_tool.py", line 130, in execute
    longitude=longitude, year=year, gv=gv, weather_path=weather_path)
  File "C:\Users\johhofer\Documents\GitHub\CEAforArcGIS\cea\resources\radiation.py", line 119, in solar_radiation_vertical
    CalcObservers(Simple_CQ, observers, DataFactorsBoundaries, path_arcgis_db, gv)
  File "C:\Users\johhofer\Documents\GitHub\CEAforArcGIS\cea\resources\radiation.py", line 373, in CalcObservers
    arcpy.ErasePoint_edit(Observers0, NonoverlappingBuildings, "INSIDE")
  File "c:\program files (x86)\arcgis\desktop10.4\arcpy\arcpy\edit.py", line 90, in ErasePoint
    raise e
ExecuteError: Failed to execute. Parameters are not valid.
ERROR 000732: Remove Features: Dataset C:\Users\johhofer\Documents\ArcGIS\Default.gdb\Non_overlap does not exist or is not supported
Failed to execute (ErasePoint).

Failed to execute (RadiationTool).
Failed at Mon Jan 09 15:18:31 2017 (Elapsed Time: 33.34 seconds)

We tried the reference-case-open and we have tried both weather files: Zurich and Zug.
@JIMENOFONSECA can you take a look at this and assign it to yourself?

who is johnhofer? somebody messed up the code and commited to the master withotu permission. is  thi issue still open?

Tested. It works in my pc with the latest version of CEA , no changes made. pleas let me know if this is still the case

@daren-thomas it works in mine, maybe gabriel's work fixed this issue. is it working in yours?

@JIMENOFONSECA what happened to the zip file? I think that breaks some of my code (not in a bad way, just, will need to fix)

So it should be there in master. But in the other pull requests it will change to an unzipped folder structure of an scenario so it can be read and read from pycharm. Would you agree with it? We can also put it as a zip file which could also work and everytime it changes we zip it again. Maybe this keeps some kind of data integrity?
Best, Jimeno
On 21 Mar 2017, at 17:13, Daren Thomas <notifications<EMAIL_ADDRESS>wrote:
@JIMENOFONSECAhttps://github.com/JIMENOFONSECA what happened to the zip file? I think that breaks some of my code (not in a bad way, just, will need to fix)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/architecture-building-systems/CEAforArcGIS/issues/452#issuecomment-288018484, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIjrgiAZEzXJutbK3BlLaDjvQ4g7fTK6ks5rn5S0gaJpZM4LfKA1.

I just zipped it.


Build a kind of real custom image: Base Image + Docker

Definition of Done:

playbook to Install Docker
update CI pipelines

The packer template is done.

refactor the scripts, directories, ...

Repeat yourself if you need to have consistent build structure by scaffolding, for example cookiecutter template.


Wow! Any possibility of getting the bcrypt module out for 2.12?

I am impressed! I found this repo by looking for webjars for bcrypt.
My question is in the issue title!

When you say 2.12, do you mean Scala 2.12.x?

👍 regarding getting a build for Scala 2.12.x.  Appologies, I am a new to the Scala/js ecosystem.  Tweaking the build.sbt led to dep failures that I couldn't immediately resolve.
I am happy to help with a little direction.  cheers.

Welcome to Scala.js!
I've actually been working on the next major release of this project, in which I've also ported it to Scala 2.12 and Scala.js 0.6.14 (see link below). I must warn you, this is a code breaking release as the package hierarchy is completely different (org.scalajs.xxx has been changed to io.scalajs.xxx). Additionally, because of new functionality in Scala.js 0.6.14, I'm removing the "require" function as it will no longer be necessary. Please see the code under ./src/test/scala in each sub project/module for examples. I'll be updating the README.md soon to reflect all of the changes.
Cheers.
https://github.com/ldaniels528/scalajs-node-npm/tree/feature/scala-2.12

Looking forward to the new release for Scala 2.12!


One outcome per path for Jordan

Trello card
Create one outcome per path for Jordan marriage abroad
Motivation
Marriage abroad is the most complex Smart Answer to update. It's also one of the most frequent Smart Answers to be updated. We want to simplify the updates so they are quicker, less complex and reduce the need for Developers to make the update. By creating one template per outcome for a country we greatly reduce the amount of logic in the templates.
Expected changes
As this is a refactor of Jordan, and not a change to the content or flow of the smart-answer, users should not experience any changes. The changes that have occurred to the code are:
Create one outcome per path through the flow for Jordan. This results in 18 new outcomes.
Remove references to Jordan in other outcomes.
Remove Jordan from all country lists.
Developer note
Jordan did not have a template of its own and was included in a template for several countries, with outputs determined by evaluating in the MarriageAbroadDataQuery calculator or from logic in the template.

@pmanrubia have re-used the contact_method partial as that partial name made more sense in the context of the page, whereas the overseas_passport one (while used underneath) felt slightly confusing to me.

@ikennaokpala addressed and fixed up

@chao-xian sure will take a look


Error Installing Kotlin SDK

Description
I am attempting to install the Kotlin SDK by running the command: ./build-sdk.sh, but am getting the error: Could not create service of type ScriptPluginFactory using BuildScopeServices.createScriptPluginFactory()...
Logs
FAILURE: Build failed with an exception.
What went wrong:
Could not create service of type ScriptPluginFactory using BuildScopeServices.createScriptPluginFactory().
Could not create service of type PluginResolutionStrategyInternal using BuildScopeServices.createPluginResolutionStrategy().

@TannerJuby1  Are you properly following the installation guide given  in readme. I think it is enough to setup the project.

How was this resolved?


Additional metrics

Changes

Added liveness_latency histogram metric, cache_size gauge and batcher_size gauge
Made the datastore_partitioned metric always present
Ensured that we only record datastore_latency metrics if the timing data is present
For redis_cached we aggregate the datastore span calls by the batcher flushes
Refactored to store the metrics layer consumer function in a Box, enabling different consumer functions to be provided
Added a batcher_flush_size histogram
Added an eviction_listener to the cache to allow us to decrement the cache_size as well as to monitor the evicted_pending_writes in a histogram
Still thinking on the implementation.. but added a counter_overshoot histogram for when we add_from_authority and which pushes us over the counter max val

diff --git a/limitador-server/src/metrics.rs b/limitador-server/src/metrics.rs
index b09444b..d41df57 100644
--- a/limitador-server/src/metrics.rs
+++ b/limitador-server/src/metrics.rs
@@ -1,6 +1,5 @@
 use std::collections::HashMap;
 use std::ops;
-use std::sync::Arc;
 use std::time::{Duration, Instant};
 use tracing::span::{Attributes, Id};
 use tracing::Subscriber;
@@ -73,12 +72,12 @@ impl SpanState {
 }

 pub struct MetricsGroup {
-    consumer: Arc<fn(Timings)>,
+    consumer: Box<fn(Timings)>,
     records: Vec<String>,
 }

 impl MetricsGroup {
-    pub fn new(consumer: Arc<fn(Timings)>, records: Vec<String>) -> Self {
+    pub fn new(consumer: Box<fn(Timings)>, records: Vec<String>) -> Self {
         Self { consumer, records }
     }
 }
@@ -99,7 +98,7 @@ impl MetricsLayer {
         let rec = records.iter().map(|r| r.to_string()).collect();
         self.groups
             .entry(aggregate.to_string())
-            .or_insert(MetricsGroup::new(Arc::new(consumer), rec));
+            .or_insert(MetricsGroup::new(Box::new(consumer), rec));
         self
     }
 }

Works on my computer™ 😉

Addressed that now @alexsnaps - I think I must have been confusing things with the original implementation where I was having difficulty with the boxed function


How do I write a JSON column to a postgres table?

I'm trying to write a pandas dataframe that contains a JSON column into a postgres database using odo. Here is what I have:
from odo import odo odo(df, 'postgres://localhost:1234/testdb::test_table')
test_table has a JSON column called data. odo is unable to copy the dataframe and gives me
*** NotImplementedError: No SQL-datashape match for type JSON.
I then tried to explicitly specify the JSON type for the column:
odo(df, 'postgres://localhost:1234/testdb::test_table',
    dshape='var * {data: json}')
*** TypeError: DataShape json is not NumPy-compatible

As you can see, it then gives me an error that DataShape json is not Numpy-compatible. How do I go about doing this with odo? Pandas to_sql works without a hitch, btw. The only problem is it's really slow.

Bump. Would appreciate some help! :)


Prevent mouse cursor on the media display

This is not a feature request nor a bug report. Just wanted to get some feedback on the problem in subject.
As you may know, unlike SoundBox, JW Library allows system mouse cursor on the media display.
Normally we don't want this to happen and distract audience's attention.
Is there any 3rd party software that you're using it to prevent this like "Dual Monitor Tools" or something similar or you just train the AV operators to be careful when handling the mouse during the meetings?
Thanks for your input.

@LvDaniel there are a number of free tools that allow you to restrict mouse movement to your primary display (along with a quick key combination to free it up if required). I've not used any though.

@AntonyCorbett thanks for feedback.


feat(api): MultiQueryRetriever with WeaviateHybridSearchRetriever

Contradict to our earlier discussion; I suspect what we want to replace WeaviateHybridSearchRetriever with is MultiQueryRetriever instead of ConversationalRetrievalChain. However, it seems to perform even worse than the MultiQueryRetriever when it comes to what is astro python sdk?. astronomer-providers, airflow things seem to work. For testing, we can use the same set of env var and the exact same way to bring up the test env locally.

@Lee-W Now that we have MultiQueryRetriever with WeaviateHydridSearchRetriever. We should try the following two at the earliest when you start the day as Rahul needs to run the test for these.
We should try the following:

Increase the number of documents we retrieved per rewording to 5
when joining the docs together, we should rerank using something like cohere reranker

Let me know if you need any you need to connect on this, please

Increase the number of documents we retrieved per rewording to 5

tested with 6. a bit better but might have room to improve

when joining the docs together, we should rerank using something like cohere reranker

not yet have time to work on it today. will continue work on it early tomorrow

close this one, as changes included in https://github.com/astronomer/ask-astro/pull/170


Use npm ci instead of npm install

Signed-off-by: tpmccallum<EMAIL_ADDRESS>Content must go through a pre-merge checklist.
Pre-Merge Content Checklist
This documentation has been checked to ensure that:

[x] The title, template, and date are all set
[x] Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
[x] File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
[x] Has passed bart check
[x] Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
[x] Headings are using Title Case
[x] Code blocks have the programming language set to properly highlight syntax and the proper copy directive
[x] Have tested with npm run test and resolved all errors
[x] Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

Also, as this PR I just checked that we can do the following and local preview:
$ cd spin-up-hub/
$ npm ci
$ cd ../
$ npm ci
$ spin build
$ spin up -e PREVIEW_MODE=1

All worked a treat!


Fix GSM Validator for IE7

This change fixes the GSM Validator for use in IE7 after creating a browserify built script.
It seemed the problem was that IE7 is unable to index an array by a string.
The fix moves from using an array to using an object with character code indexes as properties. This approach was chosen to reduce the need for looping to assert that a character is GSM.

FYI: Stackoverflow: string.charAt(x) or string[x]?


ERC20Cogateway subgraph setup

fixes #276

Please run below commands after syncing the graph node
npm run create-local

Please run below commands after syncing the graph node
npm run create-local

Thank you Abhay.
I have run the above command and subgraph gets created with following output on console

> mosaic-subgraph@ create-local /Users/gulshanvasnani/Documents/forks/facilitator/subgraph/auxiliary
> graph create --node http://<IP_ADDRESS>:9425 mosaic/aux-erc20-gateways

Created subgraph: mosaic/aux-erc20-gateways

Please take latest develop changes and test the subgraphs by deploying on graph nodes.

Please take latest develop changes once and test the subgraphs by deploying on graph nodes.

Done


More accurate moon shadow

The app currently renders a circular "shadow" for the region of visible total eclipse over the course of the event. It is, however, innaccurate as the region "stretches" (that is, it is elliptical with increasing eccentricity) as a function of the sun's phase angle. It's not yet certain this can be achieved accurately with the current NASA data set.

This issue is superseded by issue #9 which more clearly explains the root problem and ideal solution.


Associations not being saved

Say I have the following models:
module.exports = {
        tableName: 'location',
	attributes: {
		name: {
			type: 'string'
		},
		eventInstance: {
			model: 'eventInstance',
			columnName: 'eventInstanceId'
		}
	}
};

module.exports = {
    tableName: 'eventInstance',
    attributes: {
        name: { type: 'string' },
        locations: {
            collection: 'location',
            via: 'eventInstance'
        }
    }
};

I would expect the following to work:
Location.create({
    name: l.name,
    eventInstance: model.eventInstance.id
}).exec(function(err, savedLocation) {
    if (err) {
        winston.error(err);
        rej(err);
    }
    model.eventInstance.locations.add(savedLocation);
    model.eventInstance.save(function(err){
        if (err) {
            winston.error(err);
            rej(err);
        }

        winston.info('done saving ' + savedLocation.name);
        res(savedLocation);
    });
});

However - eventInstanceId is always null on location - i am actually trying to force it twice here!
I have also tried
 eventInstance: model.eventInstance

and all host of other connotations... nothing seems to take...
Any ideas? This is using Postgres btw

How are you retrieving model.eventInstance? I can't see any Location.find().populate('eventInstance') in your code...

That happens a step previously and it is a valid populated eventInstance model. It's id is 1
Sent from my iPhone

On 17 May 2015, at 11:03, Dário<EMAIL_ADDRESS>wrote:
How are you retrieving model.eventInstance? I can't see any Location.find().populate('eventInstance') in your code...
—
Reply to this email directly or view it on GitHub.

var ei = {
					name: model.clash_finder.current_import.desc,
					slug: helpers.slugify(model.clash_finder.current_import.desc),
					start: new Date(model.clash_finder.current_import.startDate * 1000)
				};

				EventInstance.create(ei, function(err, saved) {

					if (err) {
						winston.error(err);
						reject(err);
					}

					model.eventInstance = saved;

					model.saved_import_data.importFor = saved;

					resolve(model);

				});

eventInstanceId is always null on location

By "location" which particular variable are you referring? Is it savedLocation?

The location.create comes back with an ID for eventInstance but looking in the db it is always null
Sent from my iPhone

On 17 May 2015, at 11:34, Dário<EMAIL_ADDRESS>wrote:
eventInstanceId is always null on location
By "location" which particular variable are you referring? Is it savedLocation?
—
Reply to this email directly or view it on GitHub.

So, from your app perspective it's fine, is it just at the DB level that things are not what you expect?
Is the FKey being saved in another column, for example eventInstance, instead of eventInstanceId?

So yeah savedLocation has the ID but the db is null
Sent from my iPhone

On 17 May 2015, at 11:34, Dário<EMAIL_ADDRESS>wrote:
eventInstanceId is always null on location
By "location" which particular variable are you referring? Is it savedLocation?
—
Reply to this email directly or view it on GitHub.

Nope. It doesn't store any reference at all.
Weirdly the code works elsewhere using other models. So artist has a one to many with images and the same code, but with artist and image works. The model definitions are the same pretty much except for the names of the models being referenced.
Sent from my iPhone

On 17 May 2015, at 11:51, Dário<EMAIL_ADDRESS>wrote:
So, from your app perspective it's fine, is it just at the DB level that things are not what you expect?
Is the FKey being saved in another column, for example eventInstance, instead of eventInstanceId?
—
Reply to this email directly or view it on GitHub.

    model: 'eventInstance',

Try model: 'eventinstance', lower case.
The rationale is that model fields takes the identity of the collection and the identity must be lowercase (docs). Sails is likely lowercasing 'eventInstance' for the identity when it passes the collections to waterline.

Ok, I'll try that. Is this likely a bug?
Sent from my iPhone

On 17 May 2015, at 12:07, Dário<EMAIL_ADDRESS>wrote:
model: 'eventInstance',

Try model: 'eventinstance', lower case.
The rationale is that model fields takes the identity of the collection and the identity must be lowercase (docs). Sails is likely lowercasing 'eventInstance' for the identity when it passes the collections to waterline.
—
Reply to this email directly or view it on GitHub.

Nah, just a frustrating limitation of waterline. At some point I guess waterline will either:

support cased identities;
lower case identities automagically.

I vote for 1.
The problem in this case is that sails.js is lower casing the identity behind the scenes hiding this (documented) particularity of waterline.

It works - if I remove the locations property from the eventInstance... This isn't good :p

Try adding identity: 'eventinstance' to the eventInstance model definition. I'm not a 100% sure how sails processes the model definitions.

Closing this as inactive, please re-open at any time if you have new information or believe this hasn't been fully answered.


How could Pelorus work in a JenkinsPipelineStrategy buildconfig that executes a binary build to build the image?

FYI: JenkinsPipelineStrategy is deprecated in 4.3:

https://docs.openshift.com/container-platform/4.3/release_notes/ocp-4-3-release-notes.html#ocp-4-3-deprecated-features


Edit button for course and stream on their pages

When lecturers and admins are on the page of a course (e.g. /course/2022/S/mycourse) or stream(e.g. /w/mycourse/42) they might want to edit the content. Having a button redirecting them to the appropriate admin page would be nice.

I'd like to work on this! For now I'm assigning it to myself for the time being. If anyone wants to work on it aswell, feel free to message me and I'll look for something else.


Make logs copy-paste friendly

Service logs, OS logs and Kernel logs should be easy to copy and paste. Ideally, also to save to a file.
Currently it is not straightforward to copy a log under Windows and Android, because in both environments, the native behavior (right click, select, long tap) is inhibited.
The only way I found is to inspect the window from the browser, and paste the HTML logs code to a new HTML file, then open the resulting file.

This is both a bug report and feature request (can split in 2 if necessary)
Right-click works fine in Linux, need to test across all environments for the bug
Adding the ability to save logs to file would be a nice-to-have

There's already a ticket to download logs to a text file: https://github.com/Start9Labs/embassy-os/issues/1341

Closing in favor of https://github.com/Start9Labs/embassy-os/issues/1341.
Noted there to add copy/paste functionality in addition to file download.

Actually, reopening this as a single bug report for making sure its copy/pasteable in broken environements (Windows, Android).


TextModelPart is disposed!

Error: TextModelPart is disposed!
at f.g in src/vs/editor/common/model/textModelPart.ts:17:10
at f.getWordAtPosition in src/vs/editor/common/model/tokenizationTextModelPart.ts:208:8
at x.getWordAtPosition in src/vs/editor/common/model/textModel.ts:1964:42
at T.D in src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts:528:21
at T.F in src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts:612:22
at T.C in src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts:520:8
at h.value in src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts:292:9
at d.y in src/vs/base/common/event.ts:1140:13
at d.z in src/vs/base/common/event.ts:1151:9
at d.fire in src/vs/base/common/event.ts:1175:9
at h.value in src/vs/editor/browser/widget/codeEditorWidget.ts:1714:38
at d.y in src/vs/base/common/event.ts:1140:13
at d.fire in src/vs/base/common/event.ts:1171:9
at I.s in src/vs/editor/common/viewModelEventDispatcher.ts:64:18
at I.endEmitViewEvents in src/vs/editor/common/viewModelEventDispatcher.ts:109:8
at m.S in src/vs/editor/common/viewModel/viewModelImpl.ts:1092:26
at m.setCursorStates in src/vs/editor/common/viewModel/viewModelImpl.ts:987:15
at N.runCoreEditorCommand in src/vs/editor/browser/coreCommands.ts:392:41
at L.moveTo in src/vs/editor/browser/view/viewController.ts:224:33
at L.dispatchMouse in src/vs/editor/browser/view/viewController.ts:207:11
at i.G in src/vs/editor/browser/controller/mouseHandler.ts:610:24
at i.start in src/vs/editor/browser/controller/mouseHandler.ts:485:8
at v.G in src/vs/editor/browser/controller/mouseHandler.ts:327:29
at <anonymous> in src/vs/editor/browser/controller/mouseHandler.ts:130:83
at callback in src/vs/editor/browser/editorDom.ts:165:4

Go to Errors Site

This fills our insiders error telemetry many pages and looks like a top hitter.

I'll keep an eye on this, but I think this was closed yesterday with #196405 being released. Error was last hit 16 hours ago, will keep an eye out.

Still no hits, pretty confident in this being fixed. Will close, and reopen if I see any activity.


Sound doesn't play, yet no error..

Description
For some reason the sound (wav's) doesn't play while nafas also doesn't report an error..
Steps/Code to Reproduce
pip3 install nafas
python3 -m nafas
Expected Behavior
Sound should play when I start a breathing program
Actual Behavior
The program starts and counters start, however no sound is played.
I double checked if my audio is on, but for some reason it just won't play
I even went and ran the command while being inside the install location (because it has the sounds subfolder), still nothing:
/usr/local/lib/python3.9/site-packages/nafas
Operating System
MacOS 11.3.1 on a MacBook Pro 13" Intel
Using the iTerm app
Python Version
Python 3.9.5
Nafas Version (Use : nafas.__version__)
0.4
Thank you for making this app! really appreciate the work!

Thanks for your issue. :handshake:
We will take it into consideration.

@naxels
Thanks for your comment 🙏🙏
It's something related to playsound library.
Unfortunately, I don't have access to an OSX-based device, if it's possible for you, please check the following in your system and then inform me :

Install playsound library in your system and test it

>>> from playsound import playsound
>>> playsound('/path/to/a/sound/file/you/want/to/play.mp3')

Install pyobjc and repeat the first step

Best Regards

Thank you,
After running the playsound command, it failed, telling me there was an AppKit error.
Running pip3 install pyobjc installed the required libraries
and then running the playsound again, solved the problem.
Now running nafas also plays the sounds :)
I guess the question that remains is:
Could it be possible to return an error when playsound returns an error/fails for this to nafas?
In the code I see this only happens when debug is set:
try:
        playsound.playsound(sound_path)
    except Exception:
        if debug:
            print(SOUND_ERROR_MESSAGE)```

Surprisingly I would have hoped that playsound package would have had a dependency on macOS to
resolve this automatically on install..

Thank you!

@naxels
Thanks for your efforts 🥇

Now running nafas also plays the sounds :)

Good news, now we have a solution 👍

I guess the question that remains is:
Could it be possible to return an error when playsound returns an error/fails for this to nafas?
In the code I see this only happens when debug is set:

Yes, we did this to ensure that this program works on all systems (at least without sound)
But we will add an option to test the sound system at the beginning and warn the user

Surprisingly I would have hoped that playsound package would have had a dependency on macOS to
resolve this automatically on install..

Yeah, it's a bit weird!
We will try to solve this in a future release
Best Regards

@sadrasabouri Would you please handle this issue?

Sure, ASAP.


helm s3 plugin install

Is it possible to helm s3 plugin install, I would like to PR but i do not have permission

Hm, that's weird, you should be able to send in a PR..have you forked the repo? If not, then that could explain it.

No I have not forked, let me forked and create PR

Closing issue since it's addressed in the latest release


Multi-module java application fails on docker build step

Describe the bug
The kaniko build process fails for Java multi-module applications due to an incorrect kaniko context. This results in Kaniko being unable to locate the expected artifacts in the /target folder. The issue seems to be related to not using deployable.module as the mountpoint, which is necessary for kaniko to process the build correctly.
To Reproduce
What did you do?

Configured a Java multi-module project for building with kaniko within our CI/CD pipeline.
Triggered the build process using the existing CI/CD pipeline configuration, which does not specify deployable.module as the mountpoint for kaniko.

What did you expect to see?

The kaniko build process was successfully completed.
Kaniko should have located the necessary artifacts in the /target folder for each module, creating the expected container image.

What did you see instead? Under which circumstances?

The Kaniko build process failed with an error indicating that it could not find the expected artifacts in the /target folder.
This issue occurred when using a default kaniko context, without specifying deployable.module as the mountpoint.

Additional context

The issue appears to be solvable by configuring the CI/CD pipeline to use deployable.module as the mountpoint for kaniko. This would ensure that kaniko has the correct context to find and use the artifacts located in the /target folder for Java multi-module applications.


Implement a Enhacing Disease Detection page | As of now it takes us to no where

Hey @manikumarreddyu please allow me to complete this task

Hey @shubhagarwal1

Please follow the issue template
Please check the website thoroughly
Disease detection api is working fine


Improved signout in external providers

FIXED: Added [AllowAnonymous] to Logout action (this is the redirect URI after logout in external provider, keep in mind that first you are logged out in your local identity server).
Added a custom SignInManager: you need keep the issued "id_token" for signout later in external provider. (See ExternalController: https://github.com/IdentityServer/IdentityServer4/blob/main/samples/Quickstarts/3_AspNetCoreAndApis/src/IdentityServer/Quickstart/Account/ExternalController.cs).

You can try this pull request by adding the "Demo Identity Server" in your StartupHelper:
authenticationBuilder.AddOpenIdConnect("oidc", "OpenID Connect", options =>
            {
                options.SignInScheme = IdentityConstants.ExternalScheme;
                options.SignOutScheme = IdentityServerConstants.SignoutScheme;

                options.Authority = "https://demo.identityserver.io/";
                options.ClientId = "interactive.public";
                options.ResponseType = "code";
                options.UsePkce = true;
                options.TokenValidationParameters = new TokenValidationParameters
                {
                    NameClaimType = "name",
                    RoleClaimType = "role"
                };
                options.SaveTokens = true;
                options.Events.OnRedirectToIdentityProviderForSignOut = async options =>
                {
                    options.ProtocolMessage.IdTokenHint = await options.HttpContext.GetTokenAsync("id_token");
                };
            });

Thank you for your PR 👍🏼
I will test it, maybe I would like to use same approach in the implementation like in IS4 sample - in controller, not create custom SignInManager, but I will check the details around that and definitely thanks for your fix 😊

Ok, I thought the same as you but I think it's hard work ... if you don't want to use the SignInManager class (AccountController in QuickStart.UI doesn't use it) you have to change a lot of things in your AccountController (user provisioning, registration, two factor auth, etc.).
Anyway, you probably have more experience working with IS4 than me... I'll be stay tunned.

You are right, I will check it - thank you for your clarification for your implementation. 👍

Thanks for your PR. 👍

Hi @skoruba,
I detected two issues dealing wih external providers:

When you login on an external provider and you have two factor authentication enabled, the id_token is lost due twofactor auth remove the external cookie before invoke SignInWithClaimsAsync mehod. I think I fixed this issue using ExternalCookieAuthenticationScheme and overriding the GetExternalLoginInfoAsync method in CustomSignInManager to use these scheme. I tested it and works like a charm.

If you disable local login in your client and have enabled two factor auth (and only one external provider), when you enter the auth code you are redirected again to login page, and then to external provider and then asking for two factor code again. I think the login page is required and not auto redirect the user to external provider.

I'm working on this issues, I hope send you a pull request soon.

Thanks 👍

@zinkpad - did you find any way how to find the issues which you mentioned above? I would love to use your changes in next RC4.
Thanks 👍

Yes, you can check my last commits on my fork repository:
https://github.com/zinkpad/IdentityServer4.Admin/commits/improve-external-providers
But I think I have to revert the commit : https://github.com/zinkpad/IdentityServer4.Admin/commit/a6871333b71c0c580ae7e7ae7decdace2ce20ece because these changes are not needed.
The key to resolve these issues is to use the ExternalCookieAuthenticationScheme and remove multifactor authentication claim to prevent signin issues with external providers.

Can you please send a PR with your changes? It would be the best. 😊
Thanks for your job!

FYI, CustomSignInManager class is based on source code at: https://github.com/dotnet/aspnetcore/blob/master/src/Identity/Core/src/SignInManager.cs you can check it.
My environment consists in:

A custom Skoruba.STS.Identity server with these improvements:

Support for Oracle (also with serilog support).
Auto user registration and claims sync issued by our external provider.
Configured our custom Identity Server as external provider.
[...]

Our company Identity Server with support for:

Intranet login support.
Azure AD
Windows auth
Cl@ve

Can you please send a PR with your changes? It would be the best.
Thanks for your job!

Sure!...I just send you a pull request, please test it.


performance.mark doesn't exist in node@16 when using jsdom globals

FakeTimers version<EMAIL_ADDRESS>Environment : node@16
Example URL : Minimal repro: https://github.com/msluther/sinon-timers-jsdom-bug
Other libraries you are using: global-jsdom

What did you expect to happen?
performance.mark is a function
What actually happens
performance.mark is undefined
How to reproduce
Minimal repro is available here: https://github.com/msluther/sinon-timers-jsdom-bug
Effectly though it's just this in node@16:
require('global-jsdom/register'); // This setups up jsdom and copies properties from `window` up to global, including a minimal Performance type
const sinon = require('sinon');
global.performance.mark(); // works
sinon.useFakeTimers();
global.performance.mark(); // throws as `mark` is now `undefined`

This is related to this issue: #394
From my comment on that issue:
Hrm. So, the fix works but makes the assumption that the functions on global.Performance.prototype are a superset of global.performance.* functions. This is currently not the case when using node@16 and jsdom. jsdom is injecting a global.Performance object based on the minimal W3C spec for hr-time.
This isn't necessarily a bug with either library, but feels like a gap between the two.
However, @sinon/fake-timers ends up replacing a good global.performance.mark with undefined in this situation. Should the code here use both prototypes to make sure this is the case or maybe prefer the global.performance over global.Performance?
The work around that I posted above still works in this case as long as its injected prior to sinon & jsdom, so I'm not blocked by any means, but just requires making sure that happens in my tests everywhere.

While it's not strictly a bug I think it's very reasonable to support this use case and the fix shouldn't be too hard.

This is currently impacting me, but on node v18. What would an acceptable unit test be for this?

From my own manual testing, swapping the order here: https://github.com/sinonjs/fake-timers/blob/b568150a78c41dc89c8fd73186dc8fa10b1b2c6e/src/fake-timers-src.js#L1756 is enough to resolve the issue for me anyways.

@zbyte64 feel free to open a PR

PR merged 🥳 Thanks a bunch


Add region / subregion numeric codes

How would you feel about a PR to add in region and subregion geographic composition numeric codes, as represented by the UN Statistics Division?

Anything that adds to the data set is :+1:

This has been added a long time ago


Why the repo can't support install by yarn add repo-name command?

Such as the title desc, thanks.

Solved, thanks.


Set road_class=motorway when motorroad=yes

The motorroad tag is documented here: https://wiki.openstreetmap.org/wiki/Key:motorroad

The motorroad tag is used to describe highways that have motorway-like access restrictions (i.e. cyclists and pedestrians banned) but that are not a motorway.

IMHO this should be stored in a separate encoded value to handle things like access. But for example max speed might differ.

If motorroad=yes was a separate encoded value would you use it to model access and speed? And if yes how?

Sorry I am a bit late with my reply @easbar.
For example in Germany there are some highway=primary with motorroad=yes.
For cars I guess the average speed might be higher on these roads.
For bicycles, foot, etc. access should be blocked (or made very unlikely).

For cars I guess the average speed might be higher on these roads.

We use the motorroad tag to determine the average speed (via the average_speed encoded value), e.g. here:
https://github.com/graphhopper/graphhopper/blob/0522c495ccad5f22fe19c6e858a40a7bd6f74eae/core/src/main/java/com/graphhopper/routing/util/CarFlagEncoder.java#L109-L115

For bicycles, foot, etc. access should be blocked (or made very unlikely).

We do this via the access encoded value:
https://github.com/graphhopper/graphhopper/blob/8ace2228fb9cfd9cbd089184df8e3141bd490c56/core/src/main/java/com/graphhopper/routing/util/BikeCommonFlagEncoder.java#L262-L263
Changing the road_class for motorroad=yes does not affect access and speed encoded values. But of course if motorroad was a separate EV we could use it in more sophisticated ways via custom models. That's why I was wondering what kind of custom models that use such a motorroad encoded value people would come up with.

Yes for example this could help when developing a custom model for Mofa or Scooter.
One other idea might be if you have a vehicle where you want to avoid complicated turns (like an RV), you might want to prefer motorroads.
I think it might be helpful for custom models.

Ok yes it is probably helpful, but at least I am just speculating, I don't know what we would actually do with motorroad in a custom model. The meaning of the motorroad tag is not entirely clear to me at also seems to be country-dependent. That's why I was wondering if you or anyone can already tell me how exactly it could be used (and especially why it definitely should not simply be used to change the road_class like in this PR).

If you look at the highway=primary motorrad=yes, they are different from motorways. Also different from trunk as well (but less different). So for me these are different types of road. For example when I look at the path details and GraphHopper would return trunk/motorway for a primary that would feel wrong.
On the other hand, why is OSM not just tagging these as highway=trunk :).

also seems to be country-dependent

Yes, IMHO that's one more reason not do something that might make sense for Country A, but might be wrong for Country B :).

Can anyone give an example where we want to distinguish between e.g. road_class == trunk && motorroad=yes and road_class == motorway?

There are probably cases where they are different. Maybe toll calculation/avoidance? I guess speed is probably not the same, motorways will be higher. If you look at: https://wiki.openstreetmap.org/wiki/Key:motorroad most countries use motorroad for access restrictions but don't assume any max speed changes (only min speed).
I think they should not be the same. I am not sure if anyone would want to use in a custom model, my guess is yes, but probably not a high prio tag for custom models.

Probably we should ask this on the tagging list?

Definitely.

This is somewhat related to #2692