Timeouts of corelib_2/compare_to2_test since 722b8391 on vm-kernel-optcounter-threshold-linux-release-ia32

I've approved the failure.
Logs:
/==================================================================\
| corelib_2/compare_to2_test failed again (Timeout, expected Pass) |
\==================================================================/

--- Command "vm" (took 02:34.000370s):
DART_CONFIGURATION=ReleaseIA32 out/ReleaseIA32/dart --optimization-counter-threshold=5 --random-seed=1817671361 --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/tests/corelib_2/compare_to2_test.dart

exit code:
null

diagnostics:
Process list including children: [8258]
Trying to capture stack trace for pid 8258
PID 8258 - process
TID 8258:
TID 8259:
TID 8262:
TID 8263:
TID 8267:
TID 8271:

eu-stack: dwfl_thread_getframes tid 8258: Success
eu-stack: dwfl_thread_getframes tid 8259: No such process
eu-stack: dwfl_thread_getframes tid 8262: No such process
eu-stack: dwfl_thread_getframes tid 8263: No such process
eu-stack: dwfl_thread_getframes tid 8267: No such process
eu-stack: dwfl_thread_getframes tid 8271: No such process
eu-stack: Couldn't show any frames.

You mentioned elsewhere that this happened after my change - by that did you mean 85360?
Being new to gardening - how come this failure was "approved"? I thought the point of approving failures was to silence expected failures. Was this expected?

FWIW, what I can read out of this is that:

The (32 bit) dart runtime is being invoked on tests/corelib_2/compare_to2_test.dart
It loads and invokes the entry point.
Some Dart code runs, which eventually results in a stack overflow.

The stack trace as well as the code in compare_to2_test.dart looks entirely generic, and doesn't hint at anything I'm aware of having touched.
As such I'm inclined to unassign myself from this issue. I don't know who would be a better assignee?

Although it appeared from the CQ that the timeout was caused by your change, it might not necessarily be at fault. Have you tried running the test locally to confirm that it's affected by your change? It also might just be slow.

Seems to be stale.


[th2-2567] added book_name to MessageID and EventID

Related to https://github.com/th2-net/th2-common-j/pull/144

Please increase the version and redirect merge to a branch related to book and page

Done, please see

@Nikita-Smirnov-Exactpro I think I should do your comment here.
https://github.com/th2-net/th2-estore/pull/24#discussion_r755254658


Update 2014-11-01-jekyll-links.md

The previous URL is going to be removed. Thank you very much for your links ;)

Took me a while to see your pull request. Thank you :)


Changed warning category to PendingDeprecationWarning

Fixes #200
Changed warning category from UserWarning (which was default warning) to PendingDeprecationWarning in files given below:-

src/einsteinpy/utils/bl_coord_transforms.py

src/einsteinpy/utils/coord_transforms.py

Hello @abhijeetmanhas! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/einsteinpy/utils/bl_coord_transforms.py:

Line 7:102: E231 missing whitespace after ','
Line 7:121: E501 line too long (127 > 120 characters)

In the file src/einsteinpy/utils/coord_transforms.py:

Line 7:102: E231 missing whitespace after ','
Line 7:121: E501 line too long (127 > 120 characters)

You will first have to get the quality checks passed :)

I cannot understand  why my commits can't pass CircleCI: quality checks.
In details, under check Black style division of quality test, it shows:

would reformat /home/circleci/repo/src/einsteinpy/utils/coord_transforms.py
would reformat /home/circleci/repo/src/einsteinpy/utils/bl_coord_transforms.py
All done! 💥 💔 💥
2 files would be reformatted, 39 files would be left unchanged.
Exited with code 1

Can anyone help me out?

Thanks @shreyasbapat, all checks passed!
Is something else required in the code?

Please squash the commits into one as there are more than one merge commits in this PR.


[Bug]: Change column header to "Characteristics" didn't work

Contact Details
<EMAIL_ADDRESS>What happened?
I want to update a existing column from a "Parameter" to a "Characteristic". This didn't work. You can select "Characteristic" but the column header is not updated. If you want to change the column to any other term it works.
Maybe there is a bug in the selection because "Characteristic" is the first term in the selection.
What did you expect?
No response
Host
Standalone
Host Details
Standalone (Browser Google Chrome)
Swate version
I assume v.1.00 beta 07

Hello thanks for the feedback, i am currently still on vacation. Will look into this as soon as i get back.
For now you can fix this by editing the xlsx file by hand. I am sorry for the inconvinience!

No problem, I only wanted to let you know.

I checked it and i think the issue is with characteristic being the default. The component checks applies updates on selection change. By clicking on characteristic it does not change as it is selected by default. If i click anything else and then characteristic it works. Can you verify this behavior on your side @SabrinaZander ? If yes, i will start working on a fix

Yes, exactly

Done! will be live with the next release!


[SPARK-33587][Core]Kill the executor on nested fatal errors

What changes were proposed in this pull request?
 However, if the fatal error is wrapped by another exception, such as

java.util.concurrent.ExecutionException, com.google.common.util.concurrent.UncheckedExecutionException, com.google.common.util.concurrent.ExecutionError when using Guava cache or Java thread pool.
SparkException thrown from https://github.com/apache/spark/blob/cf98a761de677c733f3c33230e1c63ddb785d5c5/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala#L231 or https://github.com/apache/spark/blob/cf98a761de677c733f3c33230e1c63ddb785d5c5/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala#L296

We will still keep the executor running. Fatal errors are usually unrecoverable (such as OutOfMemoryError), some components may be in a broken state when hitting a fatal error and it's hard to predicate the behaviors of a broken component. Hence, it's better to detect the nested fatal error as well and kill the executor. Then we can rely on Spark's fault tolerance to recover.
Why are the changes needed?
Fatal errors are usually unrecoverable (such as OutOfMemoryError), some components may be in a broken state when hitting a fatal error and it's hard to predicate the behaviors of a broken component. Hence, it's better to detect the nested fatal error as well and kill the executor. Then we can rely on Spark's fault tolerance to recover.
Does this PR introduce any user-facing change?
Yep. There is a slight internal behavior change on when to kill an executor. We will kill the executor when detecting a nested fatal error in the exception chain. spark.executor.killOnNestedFatalError is added to allow users to turn off this change if the slight behavior change impacts them.
How was this patch tested?
The new method Executor.isFatalError is tested by spark.executor.killOnNestedFatalError.

Test build #131910 has started for PR 30528 at commit 4156c03.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36507/

Test build #131910 has finished for PR 30528 at commit 4156c03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131910/

Test build #131915 has started for PR 30528 at commit 2720b60.

Test build #131916 has started for PR 30528 at commit 1ec1c1d.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36512/

Test build #131915 has finished for PR 30528 at commit 2720b60.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131915/

Test build #131918 has started for PR 30528 at commit 312f042.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36513/

Test build #131916 has finished for PR 30528 at commit 1ec1c1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36515/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131916/

Test build #131918 has finished for PR 30528 at commit 312f042.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131918/


Build files in dist folder are not working

getClientRect function throws an exception in dependecy 'dom-plane', makes dist build files unusable.
Always throws exception when DOM element is provided, because of rext.x typo. (should be rect.x).

dom-plane is fixed. Going to get ready to push dom_autoscroller.

Ok fixed.


How can i place STOP-LIMIT order?

How can i place STOP-LIMIT order?
There is no stop-limit order type here. In the original Binance API documentation, I see the type "STOP", but it doesn't exist in types in this framework.

I have got similar issues with order types in this library. Some of the order types (ORDER_TYPE_* constants) does not even work with binance api. You can try to pass custom order type as a string parameter for *_create_order() method, like that:
client.create_order(..., type='STOP')

You can find a list of order types in API documentation or by sniffing api requests from binance web interface (using network debug tool of your browser).
I think that ORDER_TYPE constants should be extended to include order types such as:
STOP
STOP_MARKET
TAKE_PROFIT_MARKET
and some other types.


Dockerfile, shadow: use the branch name instead of the commit

I've done few changes and pushed a new version so the old commit
doesn't exist anymore.  Since I am probably going to make more
changes, it is safer to use the branch.
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

/cc @jessfraz @AkihiroSuda

Thanks!


ci: Update Github's SSH key

https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/backport


Property Page resets values of settings after being opened once

Repro Steps:

Create a new project
Open the Project Properties, check optimize on the build settings page. Save.
Close the properties page.
Open the csproj and remove the optimize line. Save.

Expected:
Optimize is reset to false in both the project properties and properties page, project is not considered dirty.
Actual:
Optimize box is still checked in the project properties, and still set to true in the properties page. Project is considered dirty. If you close and reopen the solution, optimize is false as expected.
Related to https://github.com/dotnet/roslyn-project-system/issues/1245. /cc @davkean

When you do close the solution, the dirty popup will appear. As far as I can tell, saving does nothing, and the removal of the optimize line is correctly handled.

Also, this is written about the optimize property, but it applies generally.

Ugh, I can't imagine what this is.

This smells similar: https://github.com/dotnet/roslyn-project-system/issues/1348, but I have to have the editor open for the repro to occur.

@adrianvmsft, this does seem very similar to #1348. I've debugged through the property pages, and it does appear that the underlying property page is returning true as the value of the property I've been testing with (Optimize), even though the project file does not have the value set, and the default is false.

Where did we land with this? I've confirmed that #1348 is fixed, but I'm still running into this.

@davkean, it does look like a different issue. What I'm seeing is that the value of the property the page is retrieving really is incorrect, but I've been looking at a few other issues and haven't followed up more on this one.


Downloading the same file twice does not work

downloading an same apk file , it can only do once on Android. when refreshing the file link, nothing happens. I need go to "Download Manager" on my Android phone to delete the downloaded file , then it can be downloaded again.
please help me on this issue, thank you.

Hello, I would like to work on this issue, can someone give a piece of advice where I should start?

@smathson maybe ?

Hi @Taym95! Thanks for your interest in this issue.
My guess is that the Android DownloadManager refuses to download a file with the same filename as one that already exists. I'm not sure exactly what behavior we'd like to have here. We could follow the example of browsers and try to append a (#) to the end of the filename, or we could just show the user an error message instead of doing nothing. It doesn't look like overwriting the existing file is an option.
The code that actually creates the download request can be found here: https://github.com/react-native-community/react-native-webview/blob/master/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java#L222
Since the download filename is chosen when the request is created, this is where we'd could add some code that queries the filesystem and determines the best name for the file to download. A recursive file exists check that keeps appending a new (#) to the end of the filename until it determines a good filename would probably do the job.
The code that actually tells the DownloadManage to enqueue the request can be found here: https://github.com/react-native-community/react-native-webview/blob/master/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewModule.java#L208
It's not clear to me from the DownloadManager documentation exactly how to do proper error handling for an enqueued download request, but it probably belongs here. I see a reference to the following error constant which we could check to provide a user friendly error: https://developer.android.com/reference/android/app/DownloadManager.html#ERROR_FILE_ALREADY_EXISTS
Let me know if that's enough to get started or if you have any other questions. Thanks again!

Thanks a lot for the explanation 🙏

I was able to download the same file multiple times, and have multiple downloads of the same file running without issue. The download manager was adding -# as a suffix (ex: filename-2.zip) on subsequent downloads.
I tested on the following:
Android 9, Pixel XL
Android 9, Pixel 2 XL
Android 8, Samsung Galaxy S9
Android 7, Samsung Galaxy S7
Perhaps @atilaqi could provide more details on the steps required to run into this issue.


Only log error when tag sync fails

Fix #28843
This PR will bypass the pushUpdateTag to database failure when syncAllTags. An error log will be recorded.

I wonder if this is really the only place to ignore this hash or if it needs to be lower level. Does git also have special handling for this hash?

Edited in a more accurate title.


The draw.io app/pencil window needs a frame for the desktop app

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
I am using draw.io as the desktop app called pencil. The window is drawn without a frame line. I cannot tell where the pencil app ends and other windows begin due to lack of a frame.
I checked the various menu options. I did not see an option to turn on the window frame. Related, I did not see an option to set high contrast colors. My apologies if I missed them.
The lack of options to turn on a frame or set high contrast color is probably a UI bug. The inability to set high contrast colors is kind of egregious since visually impaired users will have problems with the app.
The pencil app works perfectly at draw.io. The browser provides a window frame, and it is easy to discern windows on the desktop.
To Reproduce
Steps to reproduce the behavior:

Start pencil desktop app.

Expected behavior
I would like the frame drawn so I can discern the app's window from other windows on the desktop. Or, an option to have the frame drawn.
Screenshots
Please see below.
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version: 3.1.0
pencil version: 3.1.0

Desktop (please complete the following information):

OS: Ubuntu 20.04
Browser: N/A
Version: N/A

Smartphone (please complete the following information):

Device: N/A
OS: N/A
Browser: N/A
Version: N/A

Additional context
N/A

What is pencil? draw.io 3.1.0 is very old, it has critical security holes. You need to update immediately.

Thanks @davidjgraph,
I think this is the upstream Ubuntu bug: Snap distributes vulnerable version of draw.io, https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1987075 .
(This looks like it could be a rabbit hole. Ubuntu is telling folks to use Snap to install the software. I've got a feeling no one is officially responsible for Snap packages. It is one of those "best effort").


Remove Header for price data fetching

It would be beneficial if we could remove the requirement for headers with chainId info when using certain queries.
Here is an example if I want to fetch price data for a set of addresses:
query TokenGetTokensDynamicData($addresses: [String!]!) {
    tokenGetTokensDynamicData(addresses: $addresses) {
        price
        tokenAddress
        priceChange24h
    }
}

I need to provide an array of addresses plus I need to configure the header such as:
context: {
            headers: {
                chainId: chainId
            }
}

Ideally, the API should be able to resolve pricing for a set of addresses without the need of providing a chain ID header. It works for mainnet but for other networks I need to specifically provide the chainId.

If I understand right, you are looking for a way to fetch prices for a set of addresses, not necessarily linked to any chain? So for example the filter param could be a mix of addresses from different chains?

This query should be extended to also allow a chain to be passed as the param instead of the header.

Agree with @franzns that probably the most clean solution would be to pass the chain as a param


get_actions  error in version  v1.3.0

when I call the rpc methodget_actions ,it returns me an error  in version v1.3.0  which  all going well in version v1.2.5. Is it a bug ??? ,  Tell me what's going wrong , Please ???

what's error

2018-09-25T10:14:26.566 thread-0   history_plugin.cpp:371        get_actions          ] params: {"account_name":"xxxxxx","pos":1,"offset":2} 2018-09-25T10:14:26.566 thread-0   history_plugin.cpp:383        get_actions          ] pos: 1 2018-09-25T10:14:26.566 thread-0   history_plugin.cpp:407        get_actions          ] start: 1 end: 3 2018-09-25T10:14:26.566 thread-0   http_plugin.cpp:580           handle_exception     ] FC Exception encountered while processing history.get_actions 2018-09-25T10:14:26.566 thread-0   http_plugin.cpp:581           handle_exception     ] Exception Details: 10 assert_exception: Assert Exception (b & ~1) == 0:     {}     thread-0  raw.hpp:339 unpack Error unpacking field context_free     {"field":"context_free"}     thread-0  raw.hpp:368 operator() error unpacking eosio::chain::action_trace     {"type":"eosio::chain::action_trace"}     thread-0  raw.hpp:616 unpack

hi @heifner , looks like the new field context_free in struct base_action_trace has broken the old data in de-serialization. would you help?

--hard-reply will solve this issue.

--hard-reply will solve this issue.

Even if this  solve this issue ,but the efficiency is too low .It will take me some days to fish this.  Comparing with  reloading  the blocks data, it has no any superiority. Is there another way ??

Seeing this across many nodes too. Might need to think about informing the wider BP community about this, as its affecting quite a few apps, especially those that rely on history.

Same error, too.

same error too

same error too ,how to fixed

--hard-reply  will solve this issue

I can now confirm that a full --hard-replay from version 1.3.0+ fixes this.


Update to the react router redux recommendation

I'd recommended at a minimum updating the wording for this recommendation. Having router state in redux can be very valuable for both debugging and testing. Simple example is authorization flow. If you are a developer that is responsible for this feature then you would want to make sure that:

User goes to protected route
User is then redirected to sign in page

If this breaks you might also want to have the action log sent to the server for debugging. If you have no way of recording what the router is doing (or playing it back) then it can be very hard to test and support these types of routing scenarios.

I'm not sure what you're referring to. But if you have a specific recommendation for the documentation, please use a PR.


Drush Error

Hi.
I have followed this project for a while, and was excited about testing the 2.0 version with drush.
It doesent seem to work on my machine.
Here is my specs:
Php version: PHP 5.3.6 with Suhosin-Patch (cli)
Drupal version: 7.9
Drush version: 4.5
Netbeans version: 7.0.1
OS version: Mac OSX 10.7.2
Here is some screenshots:
http://www.biso.dk/drush-error.png - (Command not found!?)
http://www.biso.dk/drush-config.png  - (I use drush daily, so I know the  locally  installation is fine))
Am I missing something?
/Steffen

When you enter a command don't include drush with it. For example for drush status you would just enter status. The actual drush part is added automatically when building out the full command line.

Im really embarrassed now :)..- It works like a charm, amd nb-hook is a great command!..- Thanks for the quick repley, and for this awesome tool!

LOL no problem at all! It actually catches me a few times. I might work in a trim function on the input to get rid of "drush " just to prevent the mistake from happening.


feat: initial oscal component definition

Created initial oscal component definition file for Jira.
Jira partially meets a few admin controls.
Jira does meet a few technical controls but every tool has to meet those, logging, encryption, etc
Did do a new namespace for the control-implementations props using https://lula.dev/ns/oscal of the name implemented and value of partially. Working towards showing a way for anyone to see its partially met including tools (thinking reword of the COMPLIANCE.md tool) to see that.
Used the oscal-cli to validate the schema is correct including the custom namespace for props.

/test e2e

/test e2e


Move base API URL to the custom one (e. g. to the 'api/v1')

Many programmers prefer to use api/v1 instead of api

I made pull request for it #295


istioctl: subcommand tag support set tags for config validation

Please provide a description of this PR:
The istioctl tag does not currently support ValidatingWebhook, this pr tries to add support for it.
Add the "--disable-config-validation" flag to the "istioctl tag set/generate" command. Use this tag to satisfy the "values.global.configValidation=false" setting during installation.

Hi @believening. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


1.7.1 Clipboard.js is not working in firefox 38.6.0, but working fine in Chrome

We are using clipboard.js 1.7.1 version. but it is not working in firefox browser.

@zenorocha Please

clipboard.js only lists support for Firefox 41+, While document.execCommand is widely supported, copy/cut was not enabled by default until that version of Firefox.
You can catch the error and prompt the user to manually copy.
Do you expect a significant portion of your users to be using such an old version of Firefox?

Is current version 55? If so version 41 seams ancient and we must expect users to be using a newer version than that. IMHO this issue should be closed.


[$250] Invoice - "Approve" button shows up for the invoice receiver under "Pay"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.63-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause  - Internal Team
Action Performed:

Admin: Navigate to https://staging.new.expensify.com/
Admin: Log in with a new Gmail account
Admin: Create a workspace
Admin: Navigate to Workspace settings - More features
Admin: Enable "Workflows" and "Invoices"
Admin: Navigate to Workspace settings - Workflows
Admin: Enable "Add approvals"
Admin: Navigate to Workspace settings - Members
Admin: Add a new Gmail account as a member
Admin: Navigate to the LHN
Admin: Navigate to FAB - Send invoice
Admin: Send an invoice to the workspace member with any amount, company name and URL
Member: Log in
Member: Navigate to the invoice room
Member: Click on the "Pay" button on the invoice preview
Member: Click on "Approve"

Expected Result:
"Approve" button shouldn't be visible
Actual Result:
"Approve" button shows up for the invoice receiver under "Pay". Nothing happens when the button is clicked
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/4a4a9d86-cda7-4348-b517-6cbfcb20c263
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021861529804786671047
Upwork Job ID:<PHONE_NUMBER>786671047
Last Price Increase: 2024-11-26

Issue OwnerCurrent Issue Owner: @brunovjk

Proposal
Please re-state the problem that we are trying to solve in this issue.
Approver button is shown in the SettlementButton dropdown
What is the root cause of that problem?
This line is causing the issue:
https://github.com/Expensify/App/blob/99bf5541f9d49da20952bd7f2592b7e773a6073b/src/libs/actions/IOU.ts#L7123
because in this case the managerID === userAccountID is true.
What changes do you think we should make in order to solve the problem?

I think ouReport?.managerID , should be same as the admins's account id, so considering this it seems like a BE issue.

Another option is that we could ass  policy.role === CONST.POLICY.ROLE.ADMIN;, in the above condition
if this true then show the approve button the dropdown(not sure here, because we may still want to show the approve button for another workflow approver which could not be the admin)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Approver button is shown in the SettlementButton dropdown for "user", which is not the admin
What is the root cause of that problem?
This line is causing the issue:
https://github.com/Expensify/App/blob/99bf5541f9d49da20952bd7f2592b7e773a6073b/src/libs/actions/IOU.ts#L7123
because in this case the managerID === userAccountID is true.
What changes do you think we should make in order to solve the problem?

I think ouReport?.managerID , should be same as the admins's account id, so considering this it seems like a BE issue.

Another option is that we could use  policy.role === CONST.POLICY.ROLE.ADMIN;, in the above condition
if this true then show the approve button the dropdown(not sure here, because we may still want to show the approve button for another workflow approver which could not be the admin)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Approve button shows for invoice report.
What is the root cause of that problem?
This started to happen after https://github.com/Expensify/App/pull/47926. Previously, we check the chat report whether it's a policy expense chat or not. If it's a policy expense chat, then it must be an expense report. But the PR decide to not check the chat report anymore.

The IOU.canApproveIOU method relies on the parent report chat to determine if the report can be approved or not. This is a problem because approvers of expense reports might not necessarily have access to the parent report, or the parent report might not be loaded in local Onyx state, which leads to a bug whereas the approver can't see the approve button.
Luckily we know all the information we need to show the button from the expense report and the policy of the report which the user should have locally.

The issue with that is we assume that the report passed to canApproveIOU is always an expense report. If we see the comment, we only want to show approve if it's an expense report, but we don't check for that.
https://github.com/Expensify/App/blob/9774032c7b9e72c5f8ee0de6adbe843a7efa2c4a/src/libs/actions/IOU.ts#L6726-L6731
What changes do you think we should make in order to solve the problem?

Check for expense report and return false if it's not an expense report.
if (!ReportUtils.isExpenseReport(iouReport) || !isPaidGroupPolicy) {
    return false;
}

reviewed this one once more. adding external

Thank you all for the proposals. @Shahidullah-Muffakir, but I don’t think your RCA is accurate in this case.
I'm leaning toward @bernhardoj’s proposal because it provides a more robust safeguard by validating report types and addressing potential edge cases beyond just invoices. However, before proceeding to assign @bernhardoj, I’d like to clarify one point regarding @NJ-2020’s proposal.
NJ-2020 mentioned: "When the admin sends the invoice to the member, the BE returns managerID equal to the member's account ID." This behavior seems to be expected based on the current logic, but can we confirm if this is intentional?
🎀👀🎀 C+ reviewed

Does it return the managerID always? Or only when "add approvals" is on? Or only when the users are members on the same workspace?

Does it return the managerID always? Or only when "add approvals" is on? Or only when the users are members on the same workspace?

In my tests it seems so. However, I can reproduce the issue only when approvals is enabled and the member belongs to the workspace:
https://github.com/user-attachments/assets/633f86b9-4fda-4bfd-a288-950e43b9a22a

@blimpich apologies for the delay. I tested 4 scenarios:

Both workspace members (Admin and Member) with Add Approval On
Both members with Add Approval Off
Non-workspace member (Admin only) with Add Approval On
Non-member with Add Approval Off

In the admin log, the backend sendInvoice call always returns managerID equal to receiverAccountID. However, on the member's device, the approval button only appears in the dropdown when Both workspace members have Add Approval On:
https://github.com/user-attachments/assets/0eedaf84-d82d-4284-a37b-68bd1352660d
I also noticed another bug where the values are 0.00. I'll check if it’s already been reported.

Hi @blimpich, I think we correctly assigns managerID to receiverAccountID during sendInvoice. The issue seems to be in the canApproveIOU function, missing a check to exclude invoice reports after // Only expense reports can be approved. @NJ-2020 mentioned first, but I'm leaning towards @bernhardoj's proposal. Could you weigh in? Thanks!

Thank you @brunovjk! Sorry for my slow response, was OOO for part of last week. I think based off the investigations in your comment here we can say that it is intentional that the managerID is equal to the recieverAccountID.
And I agree, I think @bernhardoj's proposal is the most ideal.
Also @abekkala it looks like there was an issue in the upwork automation, just FYI.

PR is ready
cc: @brunovjk

Also @abekkala it looks like there was an https://github.com/Expensify/App/issues/52667#issuecomment-2512368516, just FYI.

When we get to the payment stage I'll manually send offers - thanks!

PAYMENT SUMMARY FOR DEC 12

Fix: @bernhardoj [$250, if no regressions] Payment via NewDot
PR Review: @brunovjk [$250, if no regressions]  Offer

BugZero Checklist:

[x] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[x] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[x] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[x] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[x] 3z. Other: Applause - Internal Team

[x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/47926/files#r1879932231

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal
Prerequisite: (as admin)

Go to Workspace settings - More features
Enable "Workflows" and "Invoices"
Go to Workspace settings - Workflows
Enable "Add approvals"
Go to Workspace settings - Members
Add the 2nd user as the new member
Go to the LHN
Open FAB - Send invoice to the new member

Step: (as member)

Open the invoice report
Press the pay button
Verify there is no Approve option

Do we agree 👍 or 👎

@brunovjk payment sent and contract ended - thank you! 🎉

PAYMENT SUMMARY FOR DEC 12

Fix: @bernhardoj [$250, if no regressions] Payment via NewDot
PR Review: @brunovjk [$250, if no regressions] [paid]


Copy from context menu not working

An error is shown in the log when copying via the context menu:

After hitting the context menu item, nothing is written to the clipboard.
The line where the error occurs is in PivotTableUI.js

fix https://github.com/rpbouman/huey/commit/3180f92f3c3f6cc4dda7feb9e7c7d5eb9486bb39


Skeleton for MiniExcel Implementation

Will keep using MiniExcel as the general method prior providing abstract function. Close it for now, and will keep working using #5 Basic Conversion


all.bat fails when %TEMP% has non-latin characters in Windows environment.

In Windows environment, the test procedure of all.bat fails when %TEMP% path has non-latin characters. This is usually the case when people have their Windows account name in their native language.

This bug reports lacks information.
Which version of Go?
Which version of Windows?
How does it fail?

Version of go source: 1.4.2
Version of Windows: Windows 8.1 64 bit ( Language: Korean )
Failure type:
The first test fails with 'path xxx not found' like message.
The error message is broken at the non-Latin word part.
Because of this error, I changed my Windows user name and
I cannot provide the precise error message at this time.
I will follow up with the reproduced message later.

Dup of #3754.
Should be fixed by Go 1.5 where the toolchain is written in Go itself,
which doesn't have the bug.


Cant connect Airtouch 2

Hi Nathan,
I keep getting "No AC units were found" message when I enter the IP, no logs are being produced in HA.
have tried the following:
Power cycling the Airtouch and the AC unit,
uninstall and reinstall HACs component
created a new HassOS VM installed Airtouch 2 add-on
tried 0.5, 0.7 stable and 7.7

Hmm not sure how to help you. Have you tried enabling debug logging for the integration? Can the airtouch2 app connect?


Reaction diffusion contribution: THREE.js + blog

Community Contribution
Link to live project, video, or image:

blog: http://www.michielbraat.nl/blog/reaction-diffusion/  (interactive simulation at the end of the page!)
source: https://github.com/Proinn/reaction_diffusion_three_js
Sharing

[x] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

This looks really good :)


Add support for bulk gem upgrade

Hi olegbl, I first want to say thank you for d2rmm! It's an amazing mod manager that really helps with the longevity of d2r.
I see this PR has been quite stale: https://github.com/olegbl/d2rmm.mods/pull/1, so I'm giving it another shot to add support for bulk upgrading gems.
I am aware that Stackit exists, however it's stack size (which is non configurable) is too small for my liking, plus converting my existing stacks to Stackit stacks will take some work.
I'm not adding rune upgrade support in this PR since it has some complications with gem requirements, and conflict with other mods such as rune easy upgrade.
I'm proposing two changes with this PR:

Change default and max stack size to 256 (from 500 and 1000).
Add cube recipe to bulk upgrade gems 30 -> 10.

1. Changing stack size
I believe this is a bug in the way cube recipes are read, but essentially the qty caps out as 8 bit unsigned int (i.e. 255). E.g. qty=400 will be treated as qty=143 (400 - 257). This means if you have a stack with more than 256 items, you will not be able to unstack it correctly.
You can test this out by purchasing a full stack of arrows (500) and try to unstack it. The expected outcome would be a stack of 499 arrows + a stack of 1 arrow, but actual outcome is a stack of 243 arrows (500 - 257) + a stack of 1 arrow.
I feel it's kinda dangerous to leave default value at 500, since effectively any stacks with more than 256 items will lose 256 items. There is no way to unstack it without resorting to the editor.
The actual max stack size that can be unstacked is 256. Making this change also means we only need roughly half of the recipes for convert on unstack, and bulk upgrade.
2. Adding bulk upgrade recipe
To avoid having a blow up in number of recipes, I only added 30 -> 10 upgrade recipes (any stack with more than 30 items can be used).
I'm using id scroll as a guard to avoid misclicking.
This adds ~6.3k recipes so I'm putting it behind a config flag. However during testing I did not feel any noticeable slowdowns to install mod or game startup.

Looks good! Thanks for the contribution!


gulp --production not minify app.js and vendor.js

Hi @tonimitrevski!
I've pushed commit that should fix the issue. Let me know how it works for you.


Fix top navbar style

I just realized that the display of the top navbar menu is broken (well, not good looking):

It comes from my changes in https://github.com/rust-lang/docs.rs/pull/1717 to allow having a different font size.
Overall, the style for the top navbar is quite the nightmare so I decided to remove the float properties and to use flex instead. The result is quite nice (imo) and fixes some small UI issues:

And it looks like this with bigger font size:

I checked other pages and they work well too.

In my local Chrome, with the light theme, it looks like this:

There are grey rectangles between the menu names. Looking the Dev Tools, it appears to be due to these rules in the light CSS:
::-webkit-scrollbar-thumb {
    background-color: rgba(36,37,39,0.6);
}
::-webkit-scrollbar-track {
    background-color: #ecebeb;
}

Those are getting applied to the <div class="pure-menu pure-menu-horizontal">, but I'm not sure why.

Great catch! I'll check tomorrow what's going on.

Overall, great change! I am really happy to have the items show up in the same HTML order as the visual order on the page.

I tested all of them and they all ended up in bad rendering in firefox. :-/

Which type of bad rendering? The "body text is too narrow" bad rendering? Or "bottom border of menu title is not visible"?

Size of top navbar items becomes chaotic:

For example, sysinfo item even gets its height different from the rest.

I spent some time fiddling with this locally and came up with a solution that I think is tidier, avoids the scrollbars on Chrome, and looks right on both Chrome and Firefox. I sent it as a PR against your branch: https://github.com/GuillaumeGomez/docs.rs/pull/1. Let me know what you think!

Nice, thanks a lot! Will test it locally as soon as possible.

I integrated @jsha's improvements so this should now be ready!

I've manually tested the version on this branch in Firefox and Chrome, with the old version of Fira Sans locally installed. Tests I did:

Scrolled vertically to make sure the navbar stayed in place
Opened and closed menus
Verified that the rustdoc content was not artificially narrow
Verified that the vertical bars separating menu titles went all the way to the top and bottom of the navbar
Verified that menu titles were approximately centered vertically

I also tested with a large font size in firefox, and a large minimum font size. The presentation wasn't perfect but it was good enough. And it didn't interere with the rustdoc content.


Minor typo fixes on note placement

@MikeBazMSFT : Thanks for your contribution! The author, @cherylmc, has been notified to review your proposed change.


Use brand colors in cf-tables

Adds CFPB brand colors as the default variable values for colors in cf-tables.
Testing
In this repo:

check out this branch
run npm run cf-link

In a second local clone of this repo in a different folder:

pull down and check out the gh-pages-rm-overrides branch: git fetch && git checkout gh-pages-rm-overrides
if you haven't already in this second clone, run all the install steps for the project
run npm run cf-link
run npm run build
run npm start
Compare colors on local site:

http://localhost:3000/components/cf-tables/
to the live example here to make sure they match: https://www.consumerfinance.gov/about-us/doing-business-with-us/upcoming-procurement-needs/

Review

@anselmbradford

Screenshots

Notes

Todos

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

The table grays are darker than shown in the screenshot:

@anselmbradford i forgot to push the gray-5 table header changes - PR matches the screenshot now.


Potential collision and risk from indirect dependence "github.com/gotestyourself/gotestyourself"

Background
Repo moov-io/watchman used the old path to import gotestyourself indirectly.
This caused that github.com/gotestyourself/gotestyourself and gotest.tools coexist in this repo：
https://github.com/moov-io/watchman/blob/master/go.mod （Line 13 & 25）
github.com/gotestyourself/gotestyourself v2.2.0+incompatible // indirect
gotest.tools v2.2.0+incompatible // indirect

That’s because the gotestyourself has already renamed it’s import path from "github.com/gotestyourself/gotestyourself" to "gotest.tools". When you use the old path "github.com/gotestyourself/gotestyourself" to import the gotestyourself, will reintroduces gotestyourself through the import statements "import gotest.tools" in the go source file of gotestyourself.
https://github.com/gotestyourself/gotest.tools/blob/v2.2.0/fs/example_test.go#L8
package fs_test
import (
	…
	"gotest.tools/assert"
	"gotest.tools/assert/cmp"
	"gotest.tools/fs"
	"gotest.tools/golden"
)

"github.com/gotestyourself/gotestyourself" and "gotest.tools" are the same repos. This will work in isolation, bring about potential risks and problems.
Solution
Add replace statement in the go.mod file:
replace github.com/gotestyourself/gotestyourself => gotest.tools v2.3.0

Then clean the go.mod.

@adamdecaf  Could you help me review this issue? Thx :p

Sure thing @KateGo520 I think we should update the gotest.tools dependency. I think we had this with another project.

Since that dependency is transitive I ran go get -u ./... and the go.sum seems to be upgraded to their /v3 release. Does that fix your issue?
I pushed a upgrade-deps-2020-08-12 branch. Can you try that?
If all looks good I can merge https://github.com/moov-io/watchman/pull/285

@adamdecaf  Thank you for your reply. I see the commit. I think it looks good. Thank you for your contribution!

Merged. Can you let me know if Watchman isn't working for you after that update?

It seems good for me.@adamdecaf


Customize the toolbar

Hi.
i'm using the last version of symfony 3.2 with form builder.
i try to Customize the toolbar to basic. but it's still showing the full toolbar.
my config.yml:
 ivory_ck_editor:
    configs:
        my_config:
            toolbar: basic

form builder:
 ->add('content', CKEditorType::class, array(
 'config' => array('toolbar' => 'standard'),
 ))

also try like this:
>add('content', CKEditorType::class, [
'autoload' => true,
 'input_sync' => true,
 'attr' => ['rows' => 20],
 'config' => array(
 'toolbar' => 'standard',
 'uiColor' => '#ffffff',
  ),
'label' => 'label.content',
 ])

thanks!

Hey @ben29 !
So, after reading your issue, I realize the DX experience was pretty poor for toolbars...
For your first example, thanks to #268, it now works as expected (your first configuration is now used by default if you don't explicity configure it as the default one with the default_config node).
For your second and third examples, it was indeed documented that it should work but this was not the case... Thanks to #271, this will be fixed soon.

so what i need to change to fix it?
i don't understand

Upgrade your composer.json with:
{
    "require": {
        "egeloen/ckeditor-bundle": "^5.0@dev"
    }
}

Upgrade the deps with:
$ composer update egeloen/ckeditor-bundle

Install the assets:
$ php bin/console assets:install web

Then, all your examples should work.

thanks!


Fix missing @storybook/docs-tools dependency

This PR fixes a missing @storybook/docs-tools dependency, while also widening the version ranges of Storybook core packages to support all of Storybook 8.

📦 Published PR as canary version: 5.0.0--canary.190.0ab0039.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v5.0.0-next.1 :rocket:


Command line options not obeyed

Running 'convoy daemon --drivers devicemapper --driver-opts dm.datadev=/dev/loop5 --driver-opts dm.metadatadev=/dev/loop6' per the initial docs for the first time does not daemonize convoy.
A config file is written to /var/lib/convoy/convoy.cfg. Additional runs using the same command line as above shows the following message:
DEBU[0000] Found existing config. Ignoring command line opts, loading config from /var/lib/convoy  pkg=server

@mklatsky After initialization, "convoy daemon" would start Convoy with previous same configure, and currently you need to delete the /var/lib/convoy and tear down the convoy setup(e.g. dmsetup remove convoy_pool in order to use another setup)
What information you got when you failed to daemonize convoy for the first time?

This was on a brand new install, so there was no previous configuration.. When I ran the above command- convoy did not daemonize. It created the directory  /var/lib/convoy/, and the file /var/lib/convoy/convoy.cfg. When I stopped convoy, and removed the /var/lib/convoy/convoy.cfg file, then started it again- the file was recreated. I am unable to run convoy in a demonized mode.

Probably there is a little confusion here. Daemonized we said means convoy would run as an daemon/server, as docker do. It would still running in foreground as Docker do. You can either use start-stop-daemon to put it in background or start another terminal to execute command.
As long as you see convoy start successfully, you can start issue commands through convoy CLI.

Yes- I just was updating my previous comment to that effect- I misunderstood what "daemon" did. Thank you for your quick update.


onValidPhoneNumber

How do I make sure that the number phone is correct and  not empty in method InternationalPhoneInput ?

onPhoneNumberChange only provides phoneNumber and internationalizedPhoneNumber when the number is valid


lmeep_mpi-default and bg_phanom_2d.bin

Hello,
I am testing your code by "python series_angle.py" and I just want to get the result as yours in "examples". But there are 2 errors:
error1: "/usr/bin/ld: cannot find -lmeep_mpi-default"
error2: "execvp error on file bg_phantom_2d.bin (No such file or directory)"
I have installed meep by "sudo apt-get install libmeep-mpi-default-dev libmeep-mpi-default17".
And I think something stopped the generation of "file bg_phantom_2d.bin", so I can't find it in directory.
Is there any solution？
Thanks a lot！

Hi @ChengxiaoWang,
looks like you are having an issue installing MEEP. Please take a look at the docs https://meep.readthedocs.io/en/latest/Installation/ and ask for help in the MEEP community.


Stop swallowing exception's original message and clarify top-level message

AdminStoreSwapper#invokeFetch() used to take charge of collecting exceptions among sub-threads. It swallowed original exceptions and made customers confused when debugging. Now it maintains all sub-thread exception in an list and throw the first exception in the list.
Also modify the InvalidBootstrapurLException message to make it more clear. It is now:
"Not able to find store (" + storeName +") in this cluster according to the push URL. BnP job is not able to create new stores now." + "Please create new stores through Nuage if you think this is the correct cluster you want to push."

Sidian, I apologize if I made you feel that your coding style is bad. You are doing a good job, but there are few things that can be improved. I made lot more mistakes than you when I started coding :) . Let us talk more about the parallel pushes issue in person. It is little complicated and I did not have a complete understanding until 2 days back, when I investigated an issue. Now I know little more and I will convey my understanding.

Closing, this as it is superceeded by a new pull request.


Fix bug to make it works with wagmi 0.2.x

In my last PR, I updated the connect function for connectAsync this works well, but I didn't see that you were running an older version of wagmi (0.2.28). Since the 0.3.x version has breaking changes (https://wagmi.sh/docs/migrating-to-03), I didn't update wagmi and complied to this version.
I run the code in local, everything works well this time. Sorry for last PR

#8 Great!!


feat(host,region): add disable_no_new_privs option for container

What this PR does / why we need it:

Does this PR need to be backport to the previous release branch?:

/area host region climc


Create Apache1

What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
Please leave your type of PR only
Todos

[x] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?

Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)
Questions:

Does the licenses files need to update?
Is there breaking changes for older versions?
Does this needs documentation?

:question:


Click on checkbox for bulk action doesn't work

Proposed changes

Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues
https://github.com/rancher/rancher/issues/16601

Further comments

@westlywright this doesn't seem like it makes any sense, select all shouldn't friend on things being removable or bulk removable, that may not even be an action the resource has.


Update deploy-vsan-stretched-clusters.md

@jjaygbay1
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Fix "supermarket" missing from PlaceTypes

Fixes #401. This is a breaking change: the type of Google.Places.Types is changed from PlaceType[] to string[].
Advantages:

Works around a bug in Google's SDK, which includes supermarket in the supported types, but does not include it in GMSPlaceType.
Adds resilience against future change to the Google SDK. If a type is added that is not known to the Xamarin wrapper, the wrapper's code will get an unexpected string, which is much easier to deal with than the getter for Places.Types throwing NotSupportedException.

Disadvantages:

When developers update to the new NuGet package, they will get a compile error and have to change their code. This is preferable, however, to their code compiling and the system appearing to work, only to have apps mysteriously crash in the field as users search happen to search for supermarkets.

If the PR is implemented, PlaceType should be removed, as it is no longer uses, and the documentation should be updated to link to the supported types.

Report for bug in Google SDK: No constant for "supermarket" place type

For consistency, if this PR is implemented, In Google.Places.AddressComponent, the property Types should be changed to type string[]. The property Type should be removed: it is already obsolete; a breaking-change transition is a good time to remove it.

@breyed Thanks for your contribution and thanks for linking to the right docs!
Breaking changes are bad for everyone. Let me check the code to see if there's a way to avoid the pain.


refactor: [david] use new status API

This PR updates the API URL for david to use the new status API. The new API will be more reliable going forwards.

Warnings

:warning:
This PR modified service code for david but not its test code. That's okay so long as it's refactoring existing code.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @alanshaw!

  Generated by :no_entry_sign: dangerJS against 19b352469a229fddd75931a83a9e41e506b257ea

Thank you for the PR! I've modified the PR title so that the corresponding tests for this service are executed, and that's showing that the tests are now failing with this change. Have only take a cursory review, but seems that when the type query parameter has a value like optional or dev that the API is returning empty responses. Is this expected?
https://status.david-dm.org/gh/expressjs/express?type=dev
https://github.com/expressjs/express/blob/508936853a6e311099c9985d4c11a4b1b8f6af07/package.json#L62-L80

Oh no! Not that's not expected. I'll get it fixed.

@alanshaw when you have a chance, it would be great if you could pick this up again! We've been holding off on #5966 which in turn is causing regular test failures, I would be keen on getting our David implementation sorted out. 😉

It's been a while, so I'll go ahead and close this pull request for the time being. Feel free to ping us when and if you get a chance to circle back to it again!


Update Condor (2.0) Changelogs

Please update the changelogs for condor ( Node, EE etc)

Changelog updates will be covered in the PRs for the issues that have them. Therefore, closing this issue/ticket.


Content Model Framework = interpret default value of a boolean as true if checkbox is set to be checked

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.5
[ ] ACS AEM Commons Version: latest
[ ] Reproducible on Latest? yes

Expected Behavior
In the content model framework, the default value of a checkbox should be considered true if the options has checked set to have it checked by default.
Actual Behavior
This does not happen, and you are required to set the bool as true AND the checkbox to be checked. That is redundant.

This mostly affects cases where the class is being used outside of an actual form, e.g. in a unit test.  The challenge here is that the form components themselves only operate on the field declarations and not field+object (which means they don't ever have any reason to access the original objects themselves.)
The most appropriate thing to do here is update the API to pass in the actual objects during the init phase and perform the processing there.  Doing this would be a major API increase, so I'm going to park this one for now.  In the meantime I've added a partial fix which uses the default value of the boolean field to determine if the checkbox should be checked by default.  This only works if the declaring class has a public no-parameter constructor, or if the constructor can gracefully handle nulls as inputs without throwing an error.  That's because the only way to read a declared value of a field is to instantiate an object of the declaring class, etc.


Installer uses clear splash screen, but program uses GIF and thus has 'speckling'

Is your feature request related to a problem? Please describe.
Due to the program using GIF files for imagery in the program, the 256 color limit of that format makes the images look speckled.
Describe the solution you'd like
Instead of GIF files, use a 18 million color format like JPG or PNG.
Describe alternatives you've considered
There is no real alternative when sticking to GIF files.
Additional context
Add any other context or screenshots about the feature request here.

This has been fixed.

Smoothed out...


Update Gem

Please, update for compatibility with newer versions of the Gems, example, Gherkin Gem.

Hi,
Can you send more information about your gem versions like gherkin version?

can you send more information about the gem version ?
like gherkin version.


Update for flake8 v3.6

Numerous minor updates for compliance with flake8 v3.6, as discussed in qiime2/qiime2#415
Note: flake8 has been disabled in versioneer.py.
NOTE: Please exercise caution in reviewing, as I was unable to test changes. "make test" fails on my machine in a clean master branch of Shogun, as described below:
ImportError while importing test module '/home/chris/src/qiime2/q2-shogun/q2_shogun/tests/test_shogun.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
q2_shogun/tests/test_shogun.py:14: in    from qiime2.plugins import shogun
E   ImportError: cannot import name 'shogun'

Pull Request Test Coverage Report for Build 16

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.897%

Totals

Change from base Build 14:
0.0%

Covered Lines:
66

Relevant Lines:
74

💛  - Coveralls

LGTM thanks @ChrisKeefe !
Tests pass locally for me.
It looks like the issue you had is because the dependency SHOGUN was not installed correctly. See install instructions here (and feel free to improve!) — SHOGUN needs to be installed separately from the git repo because it is not conda-installable and is not on pypi afaik.


Password prompt when trying to reenter Chroot after reboot

chronos@localhost ~ $ sudo /media/removable/sd/bin/edit-chroot -all
name: xenial
encrypted: no
Entering /media/removable/sd/chroots/xenial...
crouton: version 1-20170619181610~master:980f090f
release: xenial
architecture: amd64
xmethod: xiwi
targets: xiwi,xfce
host: version 9460.67.0 (Official Build) stable-channel squawks
kernel: Linux localhost 4.4.52-08264-gaa3473cb9b04 #1 SMP PREEMPT Thu Jun 22 14:37:29 PDT 2017 x86_64 x86_64 x86_64 GNU/Linux
freon: yes

Unmounting /media/removable/sd/chroots/xenial...

After installing crouton to the SD-card (as seen above /media/removable/sd) I was able to start the xfce4 enviornment just as per usual.
After logging out of the environment and reopening xfce4 it still works as expected BUT
After restarting the chromebook and attempting to start xfce4 again I get a password prompt.
I get the same password prompt when only trying to enter the chroot:
chronos@localhost / $ sudo sh /media/removable/sd/bin/enter-chroot
Entering /media/removable/sd/chroots/xenial...
Password:

Now it does not matter what password I enter it will not get accepted and there should not be a password prompt to begin with!
I tried:
sudo chromeos-setdevpasswd
which had no effect and when I just want to enter sudo su I get no problems either:
chronos@localhost / $ sudo su
localhost / #

Interesting is also the mounting point of the SD-card when checking (device in question is on the last line):
chronos@localhost / $ lsblk
lsblk: dm-0: failed to get device path
lsblk: dm-0: failed to get device path
NAME          MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
loop0           7:0    0   7.3G  0 loop
└─encstateful 253:1    0   7.3G  0 dm   /mnt/stateful_partition/encrypted
loop1           7:1    0 469.7M  1 loop /opt/google/containers/android/rootfs/ro
loop2           7:2    0  48.2M  1 loop /opt/google/containers/android/rootfs/ro
loop3           7:3    0     4K  1 loop /opt/google/containers/arc-removable-med
loop4           7:4    0     4K  1 loop /opt/google/containers/arc-sdcard/mountp
loop5           7:5    0     4K  1 loop /opt/google/containers/arc-obb-mounter/m
zram0         252:0    0   5.5G  0 disk [SWAP]
mmcblk0rpmb   179:48   0     4M  0 disk
mmcblk0boot0  179:16   0     4M  1 disk
mmcblk0boot1  179:32   0     4M  1 disk
mmcblk0       179:0    0  29.1G  0 disk
├─mmcblk0p1   179:1    0    25G  0 part /mnt/stateful_partition
├─mmcblk0p2   179:2    0    16M  0 part
├─mmcblk0p3   179:3    0     2G  0 part
├─mmcblk0p4   179:4         16M  0 part
├─mmcblk0p5   179:5          2G  0 part
├─mmcblk0p6   179:6        512B  0 part
├─mmcblk0p7   179:7        512B  0 part
├─mmcblk0p8   179:8         16M  0 part /usr/share/oem
├─mmcblk0p9   179:9        512B  0 part
├─mmcblk0p10  179:10       512B  0 part
├─mmcblk0p11  179:11         8M  0 part
└─mmcblk0p12  179:12        16M  0 part
mmcblk1       179:64   0  59.5G  0 disk /media/removable/sd/chroots/xenial/var/h

When trying to umount now it only tells me the device is busy.
When running sudo umount -l /dev/mmcblk1 the command runs through but
when running lsblk again I get the same results!
As for reproduction hard to say:
I power washed my chromebook - did NOT enable debugging features -
Downloaded crouton
unmounted the SD-card:
sudo umount /dev/mmcblk1
formated it using mkfs.ext4
sudo mkfs.ext4 -L "sd" /dev/mmcblk1
mounted SD-card again
sudo mount /dev/mmblk1 /media/removable/sd
installed crouton using:
sudo sh -e ~/Downloads/crouton -r xenial -t xiwi,xfce -p /media/removable/sd
Entered the chroot after wards with: sudo sh /media/removable/sd/bin/startxfce4
Left the xfce4 using logout.
Waited for the chroot to shutdown completely and then restarted my chromebook!
Have verified that the problem persists when using trusty instead of xenial.
Regards

@Cnidarias,
If you've enabled debugging features see if this comment helps: https://github.com/dnschneid/crouton/issues/825#issuecomment-280964330
Hope this helps,
-DennisL


GUI: Text surrounded by < and > disappears.

A post such as the following:
<Some example text>
Will just disappear as it did in the screenshot below.

This is expected since text inside <> will be treated as a tag. You can test on github's markdown preview that <Some example text> will not render outside of the backticks. You can escape the < with \<Some example text> and will render just fine.
All markdown can be tested here: https://dart-lang.github.io/markdown/ but notice that flutter-markdown doesn't support inline html.

Seems to be a regression here, this happens for me again.


Add Linux Support

Add support for Arch Linux.

WPF does not have native linux support, which would mean major UI changes would likely have to be made to make this work in Linux.
It would probably be possible, but i'm not especially motivated to do so considering how much work it would be and considering the fact that (iirc) the game doesn't work through proton without manually patching out GameCube controller support
Does running SlimeModManager with Wine work?


Unreconised key in flit.ini propose closes.

like I mistype requires often.
Would be nice to have a did you mean.

Seems reasonable, so long as it doesn't add much complexity. Do you know of a good package that can find the closest word to what you typed from a set of valid words?

python difflib: get_closest_match It does not always works because the implementation is wrong. And I hates it. But it's simple enough.

Good point, I'd forgotten about difflib. I imagine that for single words it can't go that badly wrong. Playing about with it a bit, I think it behaves better with the cutoff increased to 0.7 rather than the default of 0.6. Want to make a PR?

Playing with cffi for now.

:-)

Closed by #37


[avatar] Doesn't seem to have a built in way to handle swapping formats

Currently with Avatar, if you need a different format you are either changing the src supplied manually, or redoing the children entirely as seen here.
<Avatar>
  <picture>
    <source type="image/webp" srcSet="https://example.com/webp.webp"/>
    <img src="http://example.com/png.png"/>
  </picture>
</Avatar>

Which results in the user needing to pass in more props and do additional works to achieve the same end result.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
You (in my current understanding) need to manually swap the format used in the Avatar component if you want to support a "better" or "different" one such as WEBP or AVIF. Or you need to completely redo the children in order to use the <source> swapping.
Expected Behavior 🤔
The component should allow for this https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images#use_modern_image_formats_boldly like behaviour so we can still support old browsers, yet allow for browsers that do support WeBP/AVIF to take advantage of that.
I see this possibly being done by either having a bool flag of some kind or an optional argument that takes a list of "supported" formats which then passes to an internal <picture>``<source setup.
Your Environment 🌎

`npx @material-ui/envinfo`
System:
OS: Windows 10 10.0.21370
Binaries:
Node: 14.16.0 - E:\Program Files\nodejs\node.EXE
Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 7.6.3 - E:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: 90.0.4430.93
Edge: Spartan (44.21370.1.0), Chromium (90.0.818.51)
npmPackages:
@material-ui/core: ^4.11.3-deprecations.0 => 4.11.3
@material-ui/icons: ^4.11.2 => 4.11.2
@material-ui/lab: ^4.0.0-alpha.57 => 4.0.0-alpha.57
@material-ui/styles: ^4.11.3-deprecations.0 => 4.11.3
@material-ui/system:  4.11.3
@material-ui/types:  5.1.0
@material-ui/utils:  4.11.2
@types/react:  17.0.3
react: ^17.0.2 => 17.0.2
react-dom: ^17.0.2 => 17.0.2

@Lagicrus I personally don't see how the current API with picture is wrong. It seems composable, it looks great and simple to abstract for one's specific image infrastructure.

I can see how it is easy enough to just replace the child, as I did in my example, with the picture => source combo.
But as we have so many possible formats that an image can be (and devices that can(not) support), with the upcoming AVIF being a nice example, it might be something to see if adding this picture/source dance into MUI itself might be worth it.
As currently, instead of just passing in an src and calling it a day, you now need a lot more setup such as adding the props in by hand and recreating the classes (img in this example), where it feels like that should be taken care of thanks to MUI.
And whilst yes, I can see how different image infrastructure could complicate this on the MUI side, something similar to passing in an object to the source of content_type=> URL which could be used to build out the source might work.
Unless I am missing a more obvious way of doing this

I have added the waiting for users upvotes tag. I'm closing the issue as we are not sure enough people are looking for such capability. So please upvote this issue if you are. We will prioritize our effort based on the number of upvotes.


[BUG] Fix NaN error for validating param sync

In validating parameter synchronization, comparing the src_tensor with dst_tensor by torch.equal will result in assertion error if NaN values presented. This PR bypasses such error by printing an warning message to the log and comparing the src_tensor with dst_tensor by torch.allclose(.., rtol=0, atol=0, equal_nan=True).

LGTM

Close because the issue has been resolved in commit https://github.com/alibaba/ChatLearn/commit/e07e820df4877b3dc2c042ae6e263bce8228711f from PR https://github.com/alibaba/ChatLearn/pull/126.


feature/118_footer_strip

See #118

I believe this fixes the issue with the excess footer.
A few things:
I tested this with two stage deposit under review. One with the footer and one without the footer.  It appears to work as intended. The implementation is done before html2text parsing, thus using the markup text directly from Figshare.
At a later point when we decide to update the metadata, we should make sure the formatting is identically to what is intended.

I have successfully ran a README.txt construction using footer_check script through as many deposits as possible.
Nearly all README.txt footer stripping happened as expected.
Some notable issues with handling of footer in Summary:
Christopher Frost: 13963886 (two carriage returns instead of three afterwards)
Gilby Jepson: 14298227 (extra carriage return after no other data, possibly due to an extra \n that we don't strip)
Julie Miller: 12020763 (extra carriage return, six total. Most likely an issue with the metadata)
README_footer_check.zip


style: fix font issues and remove preview background

Description

Checklist

[ ] Read the contributing guidelines.
[ ] Each commit follows the Conventional Commit spec format.
[ ] Update the readme (if applicable).
[ ] Update or add any necessary API documentation (if applicable)
[ ] All existing unit tests are still passing (if applicable).

[ ] Add some steps so we can test your bug fix or feature (if applicable).
[ ] Add new passing unit tests to cover the code introduced by your PR (if applicable).
[ ] Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
[ ] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

Current dependencies on/for this PR:

next

PR #164

PR #165   👈

PR #166

This comment was auto-generated by Graphite.


initialize smart-alluxio module

initialize the smart-alluxio module

Codecov Report

Merging #394 into trunk will decrease coverage by 0.27%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##            trunk     #394      +/-   ##
==========================================
- Coverage   55.61%   55.33%   -0.28%
==========================================
  Files         140      144       +4
  Lines        5970     5998      +28
  Branches      877      881       +4
==========================================
- Hits         3320     3319       -1
- Misses       2341     2369      +28
- Partials      309      310       +1

Thanks Taojie for initiating the Alluxio support. This work looks great!


Update demand-response branch to latest development version

This pull will forward NREL/demand-response up to the latest development version used for the demand response study.

@bwbush you can rebase on top of master now.

This is obsolete.


Implement boosting models

GradientBoosting with support for all builtin loss functions and solvers
different weak learners: table, stump, linear, quadratic, decision trees
regularization: VadaBoost-like, shrinkage (?!), subsampling (https://statweb.stanford.edu/~jhf/ftp/stobst.pdf)
importance estimation of the selected features

Still to implement:

merge compatible weak learners & drop features if their importance is too small or negative
new weak learner: product of feature-based units, like terms in a multivariate polynomial
various feature sharing strategies for multi-variate prediction (see https://papers.nips.cc/paper/4213-shareboost-efficient-multiclass-learning-with-feature-sharing.pdf, https://web.mit.edu/torralba/www/cvpr2004.pdf or http://web.mit.edu/torralba/www/extendedCVPR2004.pdf)


Code refactoring

Going to close for now since I'm not sure when, if ever, I will get back to this.


Coordinates of three-dimensional data

@yysijie  Can I use 3D data in this way?And ，when converting to the json format required by GCN, divide the x coordinate of the data by the width of the image. The y coordinate is divided by the height of the image. What does the z coordinate need to do?

Same question, Recently, I want handle 'wild video' by 3D human keypoints detector,  then put the result to feed st-gcn, but I don't know how to define the z coordinate.

I also want to know.


Android app fails

With this message after selecting a second option:
Attempted to finish an input event but the input event receiver has already been disposed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4cfe01b-2f14-16fa-2e67-653c806ee263
Version Independent ID: a1bdb0d6-b428-bb73-b719-da0ff098ac9a
Content: Xamarin.Forms Pop-ups Tutorial - Xamarin
Content Source: docs/get-started/tutorials/pop-ups/index.yml
Product: xamarin
Technology: xamarin-crossplatform
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @BobMolloy
Try running the accompanying sample for this tutorial (https://docs.microsoft.com/samples/xamarin/xamarin-forms-samples/getstarted-tutorials-popupstutorial/) and see if it works for you. It works fine for me.


Recommend using Postgres system DB in production

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2072
Originally created by @DouweM on 2020-05-28 20:42:05

As discussed in https://gitlab.com/meltano/meltano/-/issues/2046#note_351375402

View 5 previous comments from the original issue on GitLab


illegal reflective access

I'm using the very latest version of snappy-java and java 11. Any attempt to write a file using SnappyFramedOutputStream results in the following warnings, which i believe are all due to the "sun direct buffer" mechanism in SnappyFramed. Specifically, the latter references sun.nio.ch.DirectBuffer and sun.misc.Cleaner, and I think the creators of java intend to remove all access to sun.* packages at some point.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.xerial.snappy.SnappyFramed (file:/Users/gordonritter/.m2/repository/org/xerial/snappy/snappy-java/<IP_ADDRESS>/snappy-java-<IP_ADDRESS>.jar) to method sun.nio.ch.DirectBuffer.cleaner()
WARNING: Please consider reporting this to the maintainers of org.xerial.snappy.SnappyFramed
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Fixed by #228


Custom hotwords

There are any other methods to change the custom hotword "ok Google" than snowboy?

yep, sporare, tensorflow, pocketsphinx, julius, ...

how?


An error on expo latest version: Invarian Violation: No callback found with cbID 2 and callID 1 for module . Args: ' [{"app_state": "active"}]'

This on Iphone XR, and on android another one: Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication), i registered module like in docs

Hope you'll fix it)

Thanks for reply, i did that, but nothing changed, i take the RangeSlider component from the module and paste it in my project, and than it works, maybe i should do some specific with expo?

I assume then that it has something to do with my configurations.
What if you remove the app.json file. Does it make a difference?

I assume then that it has something to do with my configurations.
What if you remove the app.json file. Does it make a difference?

No, nothing changed(

Should i do expo eject?

No no. Do not eject just because of the Silder.
Keep using the managed workflow and just take the RangeSlider component from the module and paste it in your project ,

Okey, thank you, let me know, if something change

Closing issue as it isn't repetitive problem


Optimize get_linear_qubit_operator

This is a place where speed is critical. I just wanted to record here some suggestions that came up so they're not lost:

As mentioned at #335 , one of the loops can probably be parallelized
We could use Cython or the Numpy C API or something like that

Both loops can likely be parallelized, but with different strategies.  It's easier to parallelize over the sum between terms, then do a reduce operation, but that has a higher memory overhead and only speeds up QubitOperators with multiple terms.  The inner loop may actually be a bit tricky due to operations touching the same part of memory.

I guess the inner loop is a good candidate for Cython, while the outer one is good for multithreading.

At some point we will want C++, Cython, or other bindings to optimize some of the routines.  The first addition of this will be the major hurdle, because we have to change the CI, build system, testing etc, but once it's there it has the potential to lower the barrier for others.  For any C++ change we make, I think the Python simulator should be left in place so that if the build fails on someone's system it can be defaulted back to.  Projectq worked this way and I think it's a reasonable choice.

Did @sheilaliuxl 's pull requests sufficiently close this issue?

@babbush Inner loop (C(ython)) is still a TODO item, while the outer loop is done in #357.


Possibly add a linting github-workflow

Similar to: https://github.com/nschloe/awesome-scientific-computing/blob/main/.github/workflows/ci.yml

commit e1f3ae384ec9ee2ee76e012af4767940d2b54b08 closes issue


Crash when use more than 8GB data for training

I'm using C API. When the training dataset is too large, the program would just crash when I call 'LGBM_BoosterCreate()'
(As a reference, I found a similar issue #4480 but there is no answer to that.)
With 7.5GB data, it works fine:

[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 830854
[LightGBM] [Info] Number of data points in the train set: 2413300, number of used features: 3273
[LightGBM] [Info] Using requested OpenCL platform 0 device 0
[LightGBM] [Info] Using GPU Device: NVIDIA GeForce RTX 3090, Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 256 bins...
[LightGBM] [Info] GPU programs have been built
[LightGBM] [Info] Size of histogram bin entry: 8
[LightGBM] [Info] 3273 dense feature groups (7539.72 MB) transferred to GPU in 2.319649 secs. 0 sparse feature groups

If I add more data (estimate ~8.9GB), It would crash before the last line:

[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 939820
[LightGBM] [Info] Number of data points in the train set: 2413300, number of used features: 3702
[LightGBM] [Info] Using requested OpenCL platform 0 device 0
[LightGBM] [Info] Using GPU Device: NVIDIA GeForce RTX 3090, Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 256 bins...
[LightGBM] [Info] GPU programs have been built
[LightGBM] [Info] Size of histogram bin entry: 8
>> Crash here. No log any more

And it happens either when I increase number of features or number of data points, as long as the total size is more than ~8GB.
I'm using
LightGbm v3.3.1 C API
CUDA 11.5.56
RTX 3090 with 24GB memory

Thanks for using LightGBM! But you're right, this is a duplicate of #4480. Please don't open new issues just because of lack of discussion on another one.
I'm going to close this, can you please add this detail as a comment on #4480 ?


NPE while updating Lucene-indexed field

v2.2.3
1 Create record with Lucene indexed field == null
2 Update record with field not null
After update, trying to remove old (non-existing) value, OLuceneTxChangesMultiRid.remove calls key.toString() with key == null
com.orientechnologies.orient.core.exception.ODatabaseException: Error on saving record #561:10
DB name="default"
at com.orientechnologies.orient.core.tx.OTransactionOptimistic.addRecord(OTransactionOptimistic.java:526)
at com.orientechnologies.orient.core.tx.OTransactionOptimistic.saveRecord(OTransactionOptimistic.java:367)
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.save(ODatabaseDocumentTx.java:2534)
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.save(ODatabaseDocumentTx.java:101)
at com.orientechnologies.orient.core.record.impl.ODocument.save(ODocument.java:1794)
at com.orientechnologies.orient.core.record.impl.ODocument.save(ODocument.java:1785)
at com.tinkerpop.blueprints.impls.orient.OrientElement.save(OrientElement.java:327)
at com.tinkerpop.blueprints.impls.orient.OrientElement.save(OrientElement.java:309)
at com.tinkerpop.blueprints.impls.orient.OrientElement.setProperty(OrientElement.java:196)
Caused by: java.lang.NullPointerException
at com.orientechnologies.lucene.tx.OLuceneTxChangesMultiRid.remove(OLuceneTxChangesMultiRid.java:58)
at com.orientechnologies.lucene.index.OLuceneIndexNotUnique.remove(OLuceneIndexNotUnique.java:159)
at com.orientechnologies.orient.core.index.OClassIndexManager.removeFromIndex(OClassIndexManager.java:617)
at com.orientechnologies.orient.core.index.OClassIndexManager.deleteIndexKey(OClassIndexManager.java:268)
at com.orientechnologies.orient.core.index.OClassIndexManager.processIndexUpdateFieldAssignment(OClassIndexManager.java:206)
at com.orientechnologies.orient.core.index.OClassIndexManager.processSingleIndexUpdate(OClassIndexManager.java:179)
at com.orientechnologies.orient.core.index.OClassIndexManager.processIndexUpdate(OClassIndexManager.java:456)
at com.orientechnologies.orient.core.index.OClassIndexManager.onRecordAfterUpdate(OClassIndexManager.java:440)
at com.orientechnologies.orient.core.hook.ODocumentHookAbstract.onTrigger(ODocumentHookAbstract.java:260)
at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.callbackHooks(ODatabaseDocumentTx.java:1075)
at com.orientechnologies.orient.core.tx.OTransactionOptimistic.addRecord(OTransactionOptimistic.java:501)

hi @vantonov1
within the same Transaction?

Which is the type of the field indexed?

1No, it is 2 separate transactions
2 LINKLIST. Im trying to index blob (stored as a list of ORecordBytes) by Lucene, not sure it is a right way
For Lucene index, isNullValuesIgnored() is false (really?), but OLuceneTxChangesMultiRid doesnt support removing null value

@vantonov1
that was changed in 2.2.x by default for indexes. I guess yes it OLuceneTxChangesMultiRid does not support removing null values.

I'm not sure you can do that. You can index LinkList of String. How are you going to query a ORecordBytes stored in Lucene?

Well, what I want is to be able to do select .... LUCENE

Ops, select LUCENE some-word-in-the-blob

Yes but against ORecordBytes ( byte[] ) indexed in LUCENE it is not supported.
Only String,  Collection are supported

@vantonov1 Lucene is able to index and search TEXT. One of the first step of any Lucene's analyzer is to tokenize words, I don't think a byte[] can be tokenized in any way.

Ok. If I would collect a unique set of words from the file and index it as a String or Collection of String, in theory it could be up to tens of thousands of unique words. Is it normal to store it directly in field?

I guess, it is a kind of common scenario
1 store some file in orient
2 Do text extraction (using tika for example)
3 Index stored file by text it contains, with stemming and all nice features Lucene provides
It would be nice if you add that scenario here because you have Lucene indexing, you have binary data support, but it is not clear how to combine it

I did it in another life, with orientDB 1.1.0... We used to store text and PDF as binary blobs inside orientdb and analyze them with NLP tools and store results to Lucene Indexes.
Now it could be done with a single data store, OrientDb. But you can't create a Lucene index over  binary data,  you need text. Note that  you can customize analyzers:
http://orientdb.com/docs/last/Full-Text-Index.html

It would be nice to have some sort of custom adapters between record field and index. Now I need to support another field with extracted text for Lucene to index (index could be updated manually as well, but how to use it in SELECT?..)
Ok, I would try to store extracted text as String, but of course anyway NPE should be fixed
Thanks!

Fixed


Sync inventory source through CLI

Don't see an option to sync inventory source through tower-cli

Yeah, docs are not very clear
tower-cli inventory_source update <inventory name / id?>


[4.0] EncodingError/DecodingError bridging fixes and conveniences

What's in this pull request?
Cherry-picks #10685 to swift-4.0-branch.
Explanation:
As laid out in a proposed update to SE-0166 and SE-0167, there are EncodingError/DecodingError updates that we wanted to introduce to the Codable API. This implements the remainder of those updates which had not yet been implemented:

underlyingError exposition on EncodingError and DecodingError
.dataCorrupted conveniences for user code
Fixing error bridging to NSError

Scope: Affects those consuming EncodingError/DecodingError and want to present those to the user in a localized way.
Radars:

rdar://problem/32405015
rdar://problem/32512651
rdar://problem/32381842

Risk: Low
Testing: Manual verification

@swift-ci Please test


Project name change request

This is my favorite library for option parsing, but I am hesitant to use it in any sort of formal work environment because I know some people may find the project name offensive.

The nice thing is that the entire library is represented by a single .rb file - changing the name if you don't like it is a single sed command away - actually looking just now, it's even easier. Change line 8 of trollop.rb and the filename and you're done aside from docstrings.
I am very much against renaming projects for political reasons - developer efficiency, muscle memory, etc are much more important.
Just another POV~

I'm not a fan of the name myself, FWIW, but we inherited it and it 's being used by many projects.  I use the argument from the FAQ that it's "troll option parser", but I readily admit that is pretty weak.
Any ideas on new names?  Would troll_op work for everyone, or should we just pick a completely new name?  I'm curious what others think.

I know this has laid dormant for 5 months, but it's still open so I thought I'd chime in since this actually came up at ${DAYJOB} more than once. I'm  👍 👍 👍  on renaming the project to anything that isn't denigrating (so probably not even the proposed troll_op), but I don't think I have enough skin in the game to suggest alternatives.

@Fryguy I leave this in your court.
Back when this was written, so many gems had "clever" (read: offensive) names.
Fast forward to today and people are just plain fed up with the names. They are juvenile, offensive, and a liability.
But how can one just rename a gem that is downloaded 10's of millions of times and been out for over 10 years?

But how can one just rename a gem that is downloaded 10's of millions of times and been out for over 10 years?

It's happened before: cut a new X release under the new name, and a new Z release under the old name with clear documentation that a project is dead/old/deprecated and new work will be happening under the new name/new repo. What I think would really matter is what folks might encounter on the Rubygems page and what information they received when they run gem install trollop.
I concede that it's not easy and that folks will continue to point at the old name/install the old gem (maybe forever) but it's work worth doing. Since Trollop is an open source project, I don't think it's out of line for users to expect/encounter some small degree of friction. Of course, I also say this without the onus of maintainership so my opinions are just 🙈 🙉 at best.

(BTW thank you to both @Fryguy and @kbrock for the work you've put into maintaining Trollop and updating it. I know I'm pushing pretty hard for a rename being the right thing to do, but you've both done a ton for this project and your work has been appreciated. I'm happy to defer to what you think is best since you're the ones carrying the onus of maintainership here.)

Hi,
I just came here after this started showing up in our Gemfile.lock. I also wanna thank you for your work maintaining this but also ecnourage you to change the name. @mckern drew up a good blueprint on how to do that.
I'd really appreciate the effort to do that and would also volunteer some of my time to help with the name migration. Also, in hopes for a ruby community without offensive gem names :)
Cheers,
Tobi

I don't think the issue is the logistics of renaming the gem, but instead is just coming up with a name.

I actually have a local fork that I'd worked through renaming with; I called it [argybargy](https://www.merriam-webster.com/dictionary/argy-bargy). You're welcome to it if you'd like.

Love this gem, one of the best go-to for me!
Straight forward names are always easy to understand and welcome, but I guess it gets long. Like The Best Option Parser; I'll still use it.
Amazing because it simply is. The name is still available. I say go for it, why not? It's also good to start with the first alphabet.
Unique ones are tricky to adopt because users won't know what it is. Despite, I use lots of Japanese words just like every other tech startup likes to do, LOL. (Granted, mine are private work projects.)

Hikisu (say he-key-sue) is a Japanese word for option values, arguments which is also hasn't been taken yet. Just throw in a cool logo and it's all fine. You'll also get to enjoy the various pronunciations people will come up with. LOL

I'd prefer to have 'opt' or 'option' as part of the name if possible. it makes it a little easier to deduce what's going on from the require. That's english speaker bias though.
Some cheesy thoughts:

optonaut
opt-o-matic
option-easy
optane

too bad optopus was already taken

Being clever shouldn’t be favored at the expense of others feeling marginalized.
-- https://robots.thoughtbot.com/factory_bot

Is there a release planned in the immediate future (I would be keen on the new #ignore_invalid_options behaviour)? I guess the rename could just happen then and there.
Is there anything I could do to help?

I find optane the best and most original pun.  Option parsing library names are so boring usually.  Hopefully we get more "options" and can vote on it.

@jrafanie how about "Mops" for 'more options'

Trollipop. It's similar, but different, and you can sing to it to the Chordettes song. :)

Trollipop actually made me laugh. 😆
Even so, my vote is for optane so far.

heh. yes, that is amusing.
Would prefer to go with a name that is completely leaving the legacy of the slang behind though.

I like optane FWIW

trollop backwards pollort

@Fryguy optane is out - copyright by intel. Optimist?

Naming is hard.  Maybe optionall?

Welp, since it seems everyone is bent on doing this, have acronyms been considered?
ROMAN = Ruby Option MANager
RIOT = Ruby Integrated Option Tracker
SCRAP = Self Contained Ruby Argument Parser
Could even make it sound like an NSA project:
'OPTINT' = Option Parser That Is Not Trollop
Play around with http://acronymcreator.net/

I have to say, Optimist is now my favorite. I wish I'd thought of it myself.

yay. only took 1 year, 7 months to come up with a name :(

Welp, you know how it is. Hardest 2 things are cache invalidation, naming things, and off-by-one errors :D

On Apr 10, 2018, at 2:49 PM, Keenan Brock<EMAIL_ADDRESS>wrote:
yay. only took 1 year, 7 months to come up with a name :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

again, apologies for taking so long on this one. Especially for something I feel is so important.
Thank you all for pushing us to fix this

@ddarbyson please help review https://github.com/ManageIQ/trollop/pull/99 and make sure we do this right.  We need to leave a stable version of trollop up on rubygems.org and make an easy transition to optimist.  Gem renames cause headaches for people so we really need to do some collaboration and testing before we complete it.

Hi @jrafanie seems a bit complicated... Why not just keep Trollop as is and launch Optimist as a new gem at latest version?

@ddarbyson I think we're saying the same thing.  The one caveat that causes people headaches is if Trollop goes away completely in the new gem first version because not only do they have to change their Gemfile/gemspec but they also have to change all of their client code so they can't upgrade right away.  See the PR for discussions around this.  Other renames have occurred before, where the old class/modules names stuck around for a release or two to allow people to use the renamed gem at one point and then replace the deprecated names before upgrading to the release that drops the deprecated constants.

I understand @jrafanie
For the sake of time, can you release the latest set of features which are on master under Trollop and we can work towards renaming for a future release? I'm afraid we might get bogged down and release will take a long time.
Reason being, it's becoming more difficult to manage this gem under Bundler as a :git source as opposed to sourcing directly from rubygems.org

@ddarbyson That is what we did. The latest Trollop code has been released.
Sorry, the Trollop::VERSION has not been updated but the gemspec has been updated.
The optimist naming changes will be in parallel.

This is great.... I must have missed the note somewhere along the lines. I see 2.1.3 - July 11, 2018 (29.5 KB) on rubygems.org now
Looking forward to the new name and will keep an eye on this repository.

Sorry, the Trollop::VERSION has not been updated but the gemspec has been updated.

@kbrock does it make sense to release a new version as trollop with all the latest changes (without renames)  + the VERSION change and that will be the last trollop version (hopefully)?

Reason being, it's becoming more difficult to manage this gem under Bundler as a :git source as opposed to sourcing directly from rubygems.org

yeah, @ddarbyson, I totally agree.  We should release the latest version as trollop so people don't need to use git references. We can then go forward with the rename work.

does it make sense to release a new version as trollop with all the latest changes (without renames) + the VERSION change and that will be the last trollop version (hopefully)?

@jrafanie I'm leaning towards no.
Now if we want to merge a few of the PRs (before we bust them so they can't be merged) then I'd be willing to update the internal VERSION number and the external (gemspec) one.
Having a single file probably seemed like a good idea a dozen years ago, but it does have its limitations (aka non dry ramifications)

Now if we want to merge a few of the PRs (before we bust them so they can't be merged) then I'd be willing to update the internal VERSION number and the external (gemspec) one.

Sure, that's what I meant but didn't describe properly.  👍

Having a single file probably seemed like a good idea a dozen years ago, but it does have its limitations (aka non dry ramifications)

We've had people mention the single file before so we should not make that change in this final patch version before the rename.

Just bumping this issue to let everyone know that optimist has been released as v3.0.0 and trollop is now deprecated (via a v2.9.9 release).  Thanks everyone for your patience, and all the great naming ideas!

Dropping in to say that even though it's Friday night and I'm fixing a broken build pipeline (because the warning message emitted by v2.9.9 broke tests that were expecting a successful command to have no output), I support this change.

Thanks very much Jason, I appreciate this!
Cheers
Mary-Anne
On Sat, 25 Aug 2018 at 06:34, Jason Frey<EMAIL_ADDRESS>wrote:

Just bumping this issue to let everyone know that optimist has been
released as v3.0.0 and trollop is now deprecated (via a v2.9.9 release).
Thanks everyone for your patience, and all the great naming ideas!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/optimist/issues/75#issuecomment-415875112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABC4CAep4UYl8cxo-HbG0TqByiOlfdbbks5uUGNIgaJpZM4KFM_Z
.