SliverMainAxisGroup in a reverse scroll view doesn't work as expected

Steps to reproduce

Copy code sample
Run
Click on items in the last column titled (Reversed with prefix)
Observe the next item below the clicked one being activated

Expected results
The item clicked should be the one to active
Actual results
Items in the "Reversed with prefix" column, are activated out of sync.
Items in "Reversed" column, don't have this problem. Which seems to indicate, whenever there is a sliver preceding a SliverMainAxisGroup, it will affect how the group handles gestures.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MainAxisReverseGroupGestures(),
    );
  }
}

class MainAxisReverseGroupGestures extends StatelessWidget {
  const MainAxisReverseGroupGestures({super.key});

  @override
  Widget build(BuildContext context) {
    final colors = SliverList.list(children: const [
      _Box(color: Colors.pink),
      _Box(color: Colors.green),
      _Box(color: Colors.teal),
    ]);
    const prefix = SliverToBoxAdapter(
      child: ColoredBox(
        color: Colors.grey,
        child: SizedBox(height: 100),
      ),
    );
    Widget current = Row(children: [
      _TestCase(title: 'Regular', reverse: false, slivers: [
        colors,
      ]),
      const SizedBox(width: 2),
      _TestCase(title: 'Regular with prefix', reverse: false, slivers: [
        prefix,
        colors,
      ]),
      const SizedBox(width: 2),
      _TestCase(title: 'Reversed', reverse: true, slivers: [
        colors,
      ]),
      const SizedBox(width: 2),
      // Clicking on items from this list doesn't work as expected
      _TestCase(title: 'Reversed with prefix', reverse: true, slivers: [
        prefix,
        colors,
      ]),
    ]);
    current = Scaffold(
      body: current,
    );
    return current;
  }
}

class _TestCase extends StatelessWidget {
  final bool reverse;
  final String title;
  final List<Widget> slivers;

  const _TestCase({
    required this.slivers,
    required this.reverse,
    required this.title,
  });

  @override
  Widget build(BuildContext context) {
    return Expanded(
      child: Column(children: [
        Text(title),
        Expanded(
          child: CustomScrollView(reverse: reverse, slivers: [
            SliverMainAxisGroup(slivers: slivers),
          ]),
        ),
      ]),
    );
  }
}

class _Box extends StatefulWidget {
  final Color color;

  const _Box({
    required this.color,
  });

  @override
  State<_Box> createState() => _BoxState();
}

class _BoxState extends State<_Box> {
  bool _isSelected = false;
  @override
  Widget build(BuildContext context) {
    return GestureDetector(
      onTap: _toggle,
      child: SizedBox(
        height: 100,
        child: ColoredBox(
          color: _isSelected
              ? Color.lerp(widget.color, Colors.black, .3)!
              : widget.color,
        ),
      ),
    );
  }

  void _toggle() {
    setState(() {
      _isSelected = !_isSelected;
    });
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.4 23E214 darwin-arm64, locale en-SI)
    • Flutter version 3.22.1 on channel stable at /Users/.../Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (3 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

I can reproduce this issue on Flutter stable channel but this issue seems to have been fixed on the latest master channel as I cannot reproduce it there.

Demo
https://github.com/flutter/flutter/assets/104349824/f6ba03e2-26e5-43aa-a936-84b6d70df6d7

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (11 hours ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 125.0.6422.76

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.23.0-8.0.pre.8, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.23.0-8.0.pre.8 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 8fd8e66de4 (3 hours ago), 2024-05-26 21:49:30 -0400
    • Engine revision 469193ef0e
    • Dart version 3.5.0 (build 3.5.0-191.0.dev)
    • DevTools version 2.36.0-dev.10
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.88.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 2B171FDH20084L • android-arm64  • Android 14 (API 34)
    • macOS (desktop)  • macos          • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 125.0.6422.77

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I'll close this issue as fixed on the latest channels. If you still experience this issue, kindly leave a comment below and I will reopen this. Thank you!


ERCOT API More Datasets

Adds more data fetching to the ErcotAPI class
Minor updates to Ercot class to support changes to the API

this is good to merge when you're ready

is this ready for review?

I'm still adding tests. Will let you know when it's ready for review.


updated README

Added link to https://www.npmjs.com/package/filestack-js which displays all the available options.

@speedtreammanga Please fix the conflicts then i guess we can merge.

@speedtreammanga Will you still work in this PR or may I take ownership of it?

you can work on it
On Tue, Nov 6, 2018 at 12:13 PM Tim G<EMAIL_ADDRESS>wrote:

@speedtreammanga https://github.com/speedtreammanga Will you still work
in this PR or may I take ownership of it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/filestack/filestack-react/pull/43#issuecomment-436332807,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJx4zWauQlhNT8KcB08D_UZafb5No233ks5uscM1gaJpZM4SlGjf
.

It looks like changes of README.md file are on master branch already.


Avoid metadata representation element is rendered twice when checking the browse configuration

Description
This is a tiny fix to avoid metadata representation element is rendered twice when checking the browse configuration.
This happens for example in the item page for the author metadata list when the request to /server/api/discover/browses/search/byFields?fields=dc.contributor.author,dc.creator is made. The old implementation did not wait for the remote data to be completed, so it could happen that the author's metadata value was rendered as text and immediately afterwards as a link if browse configuration is found.
Instructions for Reviewers
Go to the page https://demo.dspace.org/entities/publication/12623672-25a9-4df2-ab36-699c4c240c7e and verify the behaviour described before. With this PR it should not happen
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@atarix83  : This has code conflicts.  If you wish to have it still considered for 8.0, please get this PR cleaned up and updated to latest main.  Otherwise, we'll have to reschedule for 9.0. Thanks!

Manually ported to 7.x in #3102


Fix #3550: OCM share fails for json driver

Fixes implementation omission in ocm share json driver in https://github.com/cs3org/reva/pull/3526

Ps. Tested locally. Both sharing and transfers successful.

One remark: I notice you used fmt.Sprintf("%s@%s", userID.OpaqueId, userID.Idp) instead of fmt.Sprintf("%s@%s", userID.OpaqueId, sm.webDAVHost) which may be fine depending on which service is used as the WebDAV server, right?
I guess if you run Reva's ocdav module then userID.Idp works? Does this work with the ocdav module?

Well, originally this was the 'meshProvider' (user.idp), this fix still works for this driver with ocdav. The webDAVHost is not available in the json driver.
Is the ratio behind (sending) this (new) webDAVHost config by the nextcloud driver discussed somewhere? Can't seem to find that.


don't know how to replicate it but sometimes I get this error when trying to download the pdfs on admin dashboard uninitialized constant Reports::FormAnswer::AWARD_TYPE_FULL_NAMES

don't know how to replicate it but sometimes I get this error when trying to download the pdfs on admin dashboard
uninitialized constant Reports::FormAnswer::AWARD_TYPE_FULL_NAMES

I believe that fixed by: https://github.com/bitzesty/qae/commit/a5c827145ed910f9f22ef0eb2bfcbb21e4ebac9b


TCME Deployment Design

The Cert Management Experience will be deployed in two different modes over the course of a single cluster creation command.  The process will run as follows:

Dedicated VM for TCME is created and TCME is installed via cloud config

signing keys are not available at this point

When VM is up, K2 will ssh into the node, create the keys as env vars and start TCME
A DNS entry will be created that points to the internal ip address of this node.
Wait for the cluster to be up and running
Install TCME as a kubernetes service that is only reachable via internal services

e.g. on AWS this would be an ELB that is only visible from inside a VPC

update the DNS entry to point to this new service
delete the standalone TCME VM

Just ran into this: https://github.com/letsencrypt/boulder
Looks like there would be some plumbing work around getting it installed and working, but it's a GO project and it might actually do what we want.


⚠ SkipTheCommericals has degraded performance

In 347f4c7, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 3664 ms

Resolved: SkipTheCommericals performance has improved in 8c53d24.


Unpin glanceclient.

The pinned version was having difficulty in parsing Kilo's glance
output. But the new version defaults to API v2, which does not translate
image names to IDs, so for now use v1 when looking at the cirros image
in our tests.

Well that explains my issues..Thanks Jesse.

retest

retest


Multicalendar configuration shows second calendar starting at 1900

When chooseing multicalendar & solo, the second calendar always starts at 1900, broken in 7.4
const filterDates = [new Date(), new Date()];

<VueDatePicker
    v-model="filterDates"
    :multi-calendars="{ solo: true, count: 2 }"
    range
>
</VueDatePicker>

Actually broken on website too


How I can catch and log errors or crashes in script

My code is this and I want to see the crash on line *ptr = 42 with loguru.
I want to log the crash and error in the line of code.
#define LOGURU_FILENAME_WIDTH  16
#define LOGURU_WITH_STREAMS     1
#define LOGURU_REDEFINE_ASSERT  1
#define LOGURU_USE_FMTLIB       0
#define LOGURU_WITH_FILEABS     0

#include "loguru.cpp"

int main(int argc, char* argv[])
{
	loguru::init(argc, argv);

	loguru::add_file("latest_readable.log", loguru::Truncate, loguru::Verbosity_INFO);
	loguru::add_file("everything.log", loguru::Append, loguru::Verbosity_MAX);
	LOG_F(INFO, "Hello log file!");
	int* ptr = nullptr;
	*ptr = 42;
	LOG_F(INFO, "goes to stderr, but not to file");
	return 0;
}

my output is this:
date       time         ( uptime  ) [ thread name/id ]                   file:line     v|
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:591   INFO| arguments: ./test_log
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:594   INFO| Current dir: Documents/practices/c++/loguru
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:596   INFO| stderr verbosity: 0
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:597   INFO| -----------------------------------
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:755   INFO| Logging to 'everything.log', mode: 'a', verbosity: 9
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]        loguru_test.cpp:7     INFO| Hello log file!
2019-04-16 20:21:57.640 (   0.000s) [main thread     ]             loguru.cpp:471   INFO| atexit

But doesn't catch the error.
It is my Makefile
CXXFLAGS= -fPIC -std=c++11 -O3 -march=native -DGXX_EXPERIMENTAL_CXX0X \
-L/usr/lib64/ \
-I/usr/lib/x86_64-linux-gnu/ \
-L/usr/lib/gcc/x86_64-linux-gnu/5/include/ \
-L/usr/local/lib/

LIB_LINK = -lm -lpthread -ldl -lstdc++

UNAME_M := $(shell uname -m)
ifeq ($(UNAME_M),armv7l)
	CXXFLAGS += -Wa,-mimplicit-it=thumb
endif

CXX = g++
SRC_DIR = ./
OUT_DIR = ./build
BUILD_NAME = test_log

OBJECTS	= loguru_test.o

compile: $(OBJECTS)
	$(CXX)  $(CXXFLAGS) $(OBJECTS) -o $(OUT_DIR)/$(BUILD_NAME) $(LIB_LINK)
	mv $(OBJECTS) $(OUT_DIR)/
loguru_test.o: $(SRC_DIR)/$ loguru_test.cpp
	$(CXX) $(CXXFLAGS) -c $< -o $@

clean:
	rm -rf $(OUT_DIR)/$(OBJECTS) $(OUT_DIR)/$(BUILD_NAME)

Please, help me.

Could be the compiler is smart enough to simply remove the assignment to *nullptr (it is, after all UB). Try without -O3 or a different compiler.


Host should mint NATS user credentials for managed providers

For managed (started as executable files, which could've been downloaded from OCI) providers, the host should mint user credentials for the lattice (if an account seed is available to the host). This is a follow-up to the issue where providers need to get the host data via environment variable #36

As a point of clarification, this issue calls for minting User credentials, not the Service credentials that should be embedded as part of the claims JWT included with the provider, correct?

there's no such thing as "service credentials", there are claims included in the PAR which are claims, not credentials.

So providers will be required, as before, to have embedded account/service claims. The NATS user credentials will be the authentication method to the host lattice, and the host mints them for the provider so that you can't just start your own provider and anonymously authenticate to the host lattice

Not necessarily anonymously, but in a way where you as the provider author don't care what the credentials are.


swift 3 Cannot inherit from non-open class 'DTPhotoCollectionViewCell' outside of its defining module

"In case you want to add more UI elements to each photo, the best way is to create a subclass of DTPhotoCollectionViewCell and then call either one of these methods registerClassPhotoViewer: or registerNibForPhotoViewer:"
Im using cocoapods, hence I cannot subclassed the DTPhotoCollectionViewCell, error above

@jofax : I will make it open class asap. While waiting for the fix, you can use this datasource method as a work around 'photoViewerController(_ photoViewerController: DTPhotoViewerController, configureCell cell: DTPhotoCollectionViewCell, forPhotoAt index: Int)'

thanks @tungvoduc
Question: If I use that data source, I will add a custom cell with Nib, is it doable? I tried to add the scroll and the image via Nib but it did it didn't work. Not sure if I did the right way. Can you advice?
thanks

@jofax : If you want to provide custom DTPhotoCollectionViewCell by nib, then you need to wait for the new release that makes DTPhotoCollectionViewCell open class. I will publish new release in few hours. If you use cell loaded from nib, your custom cell just needs to subclass DTPhotoCollectionViewCell, then add extra elements you want to the cell.

@jofax : I just released new version with updated example, you can see how I add elements to each DTPhotoCollectionViewCell.

wow thats fast, thank you @tungvoduc

@jofax : Would be nice if you can give me a star.

sure! I just added now :)


Japanese doesn't show

Hi, there is a new problem here.
pdf file cannot show Japanese.

I don't know if it is a common problem or not.
ruby:2.7.0
asciidoctor-pdf: 1.5.0.rc.1
asciidoctor-pdf-cjk-0.1.3 installed.
I also download asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1, but had a problem in downloading fonts according to https://github.com/chloerei/asciidoctor-pdf-cjk-kai_gen_gothic.
Any advice?

By default, Asciidoctor PDF only bundles two themes. One theme references a subsetted font (NotoSerif) which only supports Western languages (English and most European languages). It also comes with a theme that references a subsetted font (M+ 1p) that includes a broad set of CJK characters, but not all. So I would start with trying the later theme:
asciidoctor-pdf -a pdf-theme=default-with-fallback-font document.adoc

If that doesn't work, what I recommend is making your own theme that references your own font. It's not difficult to dot that anymore. I don't think the asciidoctor-pdf-cjk-kai_gen_gothic is really necessary. See:

https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc#language-overview
https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc#custom-fonts
https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc#modifying-the-font

Thank you very much for the reply.
I will try your advice and tell you the result. :)

Making my own theme seems to take a lot of time.
There is a time-saving solution.
downgrade to version 1.5.0.alpha.18, then problem solved.
Still don't understand why the new version can not work with Japanese (or CJK).

Still don't understand why the new version can not work with Japanese (or CJK).

This is not a true statement. The current version works the same way with Unicode as the previous version did. Likely there is an incompatibility in the configuration.
Please provide me with a sample document, an example which gems you are using, and a copy of your theme so that I can see what you might be doing wrong.

I'd say it looks pretty great with the default-with-fallback-font theme.
Here's sample input:
Anypoint Security は、多層的アプローチでアプリケーションネットワークを保護します。これらのレイヤは連携し、API へのアクセスを制御したり、ポリシーを適用したり、すべてのインバウンドトラフィックまたはアウトバウンドトラフィックをプロキシしたりして、アプリケーションネットワークとネットワークの個々のノードの両方を保護します。これにより、外部の脅威や攻撃が軽減されます。Anypoint Security には、ネットワーク実装に高い負荷をかけずに攻撃を検出してトラフィックを検証する専用のエンドポイントが用意されています。

== ポリシー

Anypoint Security の特徴として、Runtime Fabric にデプロイされているすべてのノードにポリシーを適用する、パフォーマンス、信頼性、拡張性の高いサービスが挙げられます。その後、Anypoint Security ポリシーは、すべてのトラフィックが通過するデフォルトのファイアウォール/ルータ機能として動作します。

== シークレットマネージャ

Anypoint Security には、デプロイメントで使用される TLS 証明書とキーストアを保存するセキュアコンテナが用意されています。シークレットマネージャを使用すれば、Runtime Fabric へのインバウンドトラフィックを暗号化する TLS コンテキストをセットアップするために必要なシークレットを保存できます。

== トークナイゼーションサービス

Anypoint Security のトークナイゼーションサービスでは、クレジットカード番号などのキー値をトークンに置き換えて機密データの不必要な漏洩を保護します。

Here's how you'd run it:
asciidoctor-pdf -a scripts=cjk -a pdf-theme=default-with-fallback-font jp.adoc

The -a script=cjk is important because it tells the converter to put semantic breaks in lines to accommodate mixing of English and Japanese.
Are you seeing different results?

I also used the KaiGenGothicJP theme from the asciidoctor-pdf-cjk-kai_gen_gothic gem, and it worked decently:
asciidoctor-pdf -r asciidoctor-pdf-cjk-kai_gen_gothic -a pdf-theme=KaiGenGothicJP jp.adoc

Note the absence of the -a scripts=cjk in that case. That's because that theme already adds the semantic breaks.

If you want to install the asciidoctor-pdf-cjk-kai_gen_gothic gem to get the fonts, but then use your own theme. Here's how you'd do it:

Install the gem:
$ gem install asciidoctor-pdf-cjk-kai_gen_gothic

Get the fonts:
$ asciidoctor-pdf-cjk-kai_gen_gothic-install

Create a theme that extends default:
extends: default
font:
  catalog:
    KaiGen Gothic JP:
      normal: KaiGenGothicJP-Regular.ttf
      bold: KaiGenGothicJP-Bold.ttf
      italic: KaiGenGothicJP-Regular-Italic.ttf
      bold_italic: KaiGenGothicJP-Bold-Italic.ttf
    M+ 1mn:
      normal: GEM_FONTS_DIR/mplus1mn-regular-subset.ttf
      bold: GEM_FONTS_DIR/mplus1mn-bold-subset.ttf
      italic: GEM_FONTS_DIR/mplus1mn-italic-subset.ttf
      bold_italic: GEM_FONTS_DIR/mplus1mn-bold_italic-subset.ttf
  fallbacks:
  - KaiGen Gothic JP
base:
  font-family: KaiGen Gothic JP
heading:
  font-family: $base-font-family
abstract:
  title:
    font-family: $heading-font-family
sidebar:
  title:
    font-family: $heading-font-family

Load your theme when running Asciidoctor PDF:
$ asciidoctor-pdf -a scripts=cjk -a pdf-theme=./jp-theme.yml -a pdf-fontsdir=$(dirname $(gem which asciidoctor-pdf-cjk-kai_gen_gothic))/../data/fonts jp.adoc

or
$ asciidoctor-pdf -a scripts=cjk -a pdf-theme=./jp-theme.yml -a pdf-fontsdir=$(ruby -r asciidoctor-pdf-cjk-kai_gen_gothic -e "puts File.expand_path '../fonts', (Gem.datadir 'asciidoctor-pdf-cjk-kai_gen_gothic')") jp.adoc

I'd be happy to add this info the theming guide.

Thank you very much for your concern.
Well, I really want to know what is going on with my situation.
Since I changed my versions some times to solve the problem, I would like to tell you the situation from beginning.
First, I tried the command as you recommend:
asciidoctor-pdf -a pdf-theme=default-with-fallback-font document.adoc
But that does not work. PDF is produced, but Japanese doesn't show as usual.
At that time, ruby2.7 with asciidoctor-1.5.0.rc.1
Then I set another computer with ruby2.5 with asciidoctor-1.5.0.alpha.18, and that works.
I suppose it is a version problem.
To check it, I set a 3rd environment as ruby2.7 and asciidoctor-1.5.0.alpha.18. I get Japanese too, but with little problem. You can see there is a weird space between number725 and Japanese character の.

I will give you an example file later and other informations you asked.

I'm confident that if you install asciidoctor-pdf cleanly on Ruby 2.7, the default-with-fallback-font theme will work. Keep in mind that the document does have to be encoded in UTF-8.
You can fix the large spaces using -a scripts=cjk.

I will try again later.
Thanks !

I've added all this information to the README. https://github.com/asciidoctor/asciidoctor-pdf#support-for-non-latin-languages

I tried to install the asciidoctor-pdf-cjk-kai_gen_gothic gem to get the fonts.
When I did step 2, there comes an error:
[1/20] Downloading KaiGenGothicCN-Bold-Italic.ttf
Traceback (most recent call last):
        25: from C:/Ruby27-x64/bin/asciidoctor-pdf-cjk-kai_gen_gothic-install:23:in `<main>'
        24: from C:/Ruby27-x64/bin/asciidoctor-pdf-cjk-kai_gen_gothic-install:23:in `load'
        23: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:30:in `<top (required)>'
        22: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:30:in `chdir'
        21: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:31:in `block in <top (required)>'
        20: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:31:in `each_with_index'
        19: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:31:in `each'
        18: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:33:in `block (2 levels) in <top (required)>'
        17: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:33:in `open'
        16: from C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/asciidoctor-pdf-cjk-kai_gen_gothic-0.1.1/exe/asciidoctor-pdf-cjk-kai_gen_gothic-install:34:in `block (3 levels) in <top (required)>'
        15: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:50:in `open'
        14: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:744:in `open'
        13: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:174:in `open_uri'
        12: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:233:in `open_loop'
        11: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:233:in `catch'
        10: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:235:in `block in open_loop'
         9: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:764:in `buffer_open'
         8: from C:/Ruby27-x64/lib/ruby/2.7.0/open-uri.rb:346:in `open_http'
         7: from C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:932:in `start'
         6: from C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:943:in `do_start'
         5: from C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:958:in `connect'
         4: from C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:105:in `timeout'
         3: from C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout'
         2: from C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:960:in `block in connect'
         1: from C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:960:in `open'
C:/Ruby27-x64/lib/ruby/2.7.0/net/http.rb:960:in `initialize': A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. - connect(2) for "github-production-release-asset-2e65be.s3.amazonaws.com" port 443 (Errno::ETIMEDOUT)

Is it a ruby problem?

It appears you must be behind some sort of proxy or other network filter that's blocking the download. Or maybe GitHub is throttling the download. I'm not sure.
You can download the fonts directly from here: https://github.com/chloerei/asciidoctor-pdf-cjk-kai_gen_gothic/releases

I still don't think you actually need that theme. The default-with-fallback-font covers most of the common glyphs needed for Japanese. You have yet to provide me with a document that I can test so that I can see if you have characters which are not covered.

Thank you for your reply.
Yes, proxy is the problem.
Just now I set a path environment variable and successfully installed the fonts. ;)

Yeah!

I still don't think you actually need that theme. The default-with-fallback-font covers most of the common glyphs needed for Japanese. You have yet to provide me with a document that I can test so that I can see if you have characters which are not covered.

Understand.
Here is a short version of my document.
= CLP-777インストールガイド
:author: 電子楽器開発部ソフトG
:revnumber: v1.00
:revdate: 2019-09-06
:version-label!:
:description: CLP-725のファームウェアアップデート手順について説明する。
:copyright: © Copyright 2019, Yamaha Corporation All rights reserved.
:lang: ja
:icons: font
:toc2: left
:toc-title: 目次
:toclevels: 1
:pagenums:
:sectnums!:
:title-page:

== はじめに
CLP-777のファームウェアおよび波形データのアップデート手順について説明します。

== アップデート手順

ファームウェアと波形データでインストール方法が異なる。ファームウェアはUSBストレージモードで、波形データはwainモードでアップデートできる。

=== ファームウェアのアップデート(USBストレージモード)

1. アップデータを展開し、フォルダ構成が次の通りであることを確認します。

xxxxx.zip:: ファームウェアのアップデータ

    inst_xxxx\xxxxxxx

2. [PLAY]スイッチを押しながら楽器の電源をOnします。

3. USBストレージモードで起動していることを確認します。
+
USBストレージモードで起動した場合、<REC>LEDが点滅します。

4. 楽器とPCをUSBケーブルで接続します。
+
PCに楽器が外部ストレージとして表示されます。

5. PCから楽器にインストールデータをコピーして、USBケーブルを外します。
+
<PLAY>が点灯します。

6. [PLAY]を押し、プログラムの書き換えを開始します。
+
ファームウェアのアップデートは約1分かかります。

7. アップデートが完了すると、<REC>LEDが点灯します。
+
楽器の電源をOffしてください。

[NOTE]
    アップデートに失敗すると、<REC>LEDが点滅し、手順3に戻ります。

And as you asked before, the gems I have installed are:

the themes I use are (I haven't make my own theme yet)

by the way, fonts I have in 1.5.0.alpha.18 are

Right now, I also installed asciidoctor-pdf-cjk-kai_gen_gothic-install.(only done step2, step 3 not done yet)
ruby2.7.0
And my situation is still with that werid-spaced Japanese-showed pdf file. (I have tried -a scripts=cjk, doesn't work)

I tried it with Asciidoctor PDF 1.5.0.rc.1 and the output looks flawless to me.
$ asciidoctor-pdf -a scripts=cjk -a pdf-theme=default-with-fallback-font jp.adoc

jp.pdf

Hi, I would like to try again.
I upgrade my asciidoctor-pdf to 1.5.0.rc.1. And as usually Japanese doesn't show.
I would like to finish "install the asciidoctor-pdf-cjk-kai_gen_gothic gem to get the fonts".
Sorry for taking you such much time.
Could you tell me in step 4 what kind of address I should use after '-a' ?

If you use the kai_gen_gothic theme, then you'd enter:
asciidoctor-pdf -r asciidoctor-pdf-cjk-kai_gen_gothic -a pdf-theme=KaiGenGothicJP document.adoc

But I can tell you right now that if the default-with-fallback-font doesn't work, the problem is not the font. The problem is with encodings.
Can you run the following commands and report the output:
asciidoctor -v
asciidoctor-pdf -v

You might need to set either your terminal or your Windows to use UTF-8 encoding by default. Windows likes to use non-standard encodings by default, which messes up everything.

If you use the kai_gen_gothic theme, then you'd enter:
asciidoctor-pdf -r asciidoctor-pdf-cjk-kai_gen_gothic -a pdf-theme=KaiGenGothicJP document.adoc

But I can tell you right now that if the default-with-fallback-font doesn't work, the problem is not the font. The problem is with encodings.
Can you run the following commands and report the output:
asciidoctor -v
asciidoctor-pdf -v

Asciidoctor 2.0.10 [https://asciidoctor.org]
Runtime Environment (ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x64-mingw32]) (lc:Windows-31J fs:Windows-31J in:UTF-8 ex:UTF-8)

and
Asciidoctor PDF 1.5.0.rc.1 using Asciidoctor 2.0.10 [https://asciidoctor.org]
Runtime Environment (ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x64-mingw32]) (lc:Windows-31J fs:Windows-31J in:UTF-8 ex:UTF-8)

I already set my Windows to use UTF-8 encoding.
RUBYOPT=-Eutf-8

for the command
asciidoctor-pdf -r asciidoctor-pdf-cjk-kai_gen_gothic -a pdf-theme=KaiGenGothicJP document.adoc

I got
undefined method `/' for nil:NilClass
  Use --trace for backtrace

Can you add the trace flag as it suggests?

Setting RUBYOPT is not the same as setting the system encoding in Windows.
In fact, it could complicate things even further.
Perhaps try without setting RUBYOPT.
Beyond that, I'm really not sure what else to suggest. It's a prerequisite
to be able to work in UTF-8. The strings are being corrupted due to how you
have things configured, and that's largely due to the mixing of the JP
encoding somewhere along the way.
I think what's happening is that the input is identifying as not UTF-8
encoded, and Asciidoctor reencodes to UTF-8, which is than corrupting the
input. So the system is telling Asciidoctor one thing, but in reality it's
another.
This is definitely not a font issue.

The reason for the change from alpha.18 is that the version of Asciidoctor core changed (so, again, nothing to do with Asciidoctor PDF). In Asciidoctor 1.5.x, the processor would force encode the input to UTF-8 (not actually reencode it). In Asciidoctor 2.0.x, the input encoding (at least what it claims to be) is honored and the processor reencodes to UTF-8. So if Ruby is configured with the wrong input encoding, you'll get a corrupt document. I'll be sure to add this information to the documentation.

I think we finally find the true reason.
Because all of these start with the error:
incompatible character encodings: UTF-8 and Windows-31J

Right now, my ruby is 2.7, asciidoctor 2.0.x (which is the true reason), asciidoctor 1.5.0.rc.1,
I deleted RUBYOPT, and I got:

I would like to try the set the system encoding in Windows.
Sorry for directly asking you how, I searched but many pages say it is impossible to change system encoding. (they even say it is impossible to check the encoding right now)

incompatible character encodings: UTF-8 and Windows-31J

Yep, that's the trouble.
I've stated this before. I do not understand why Microsoft insists on using encodings other than UTF-8 by default for Windows. Every other operation system uses UTF-8 by default. And that's why Windows users are always struggling with encodings.
Follow these steps to enable UTF-8 globally:

Open Control Panel (the old school looking one)
Click "Change date, time, or number formats"
Click the "Administrative" tab
Click "Change system locale..."
Check the box "Beta: Use Unicode UTF-8 for worldwide language support"
Click OK

If that doesn't work, I'm not sure how to do it.

Thank you for the your guide.
I tried, Japanese still doesn't show. And worse:

Let me change the subject,
in the situation of ruby 2.5, asciidoctor 2.0.x, asciidoctor 1.5.0.alpha.18 in windows10 version1709
I also got the error:
incompatible character encodings: UTF-8 and Windows-31J

but when I use RUBYOPT=-Eutf-8, I get JP-showed pdf file.
Meanwhile, the situation of ruby 2.7, asciidoctor 2.0.x, asciidoctor 1.5.0.rc.1 in windows10 1909
even when I add RUBYOPT, I cannot get JP-showed pdf file.
If there is nothing wrong with the version of windows and it is only the problem of asciidoctor, then two situation above should have the same results, I suppose.

I have to be honest, I just don't know. I have tried to understand Windows encodings, and even when I try it myself on a Windows machine, I just can't reproduce it. Asciidoctor follows all the rules it's supposed to follow to get encoding correct, and is thoroughly tested for those scenarios. As far as I'm concerned, it's a misconfiguration of Ruby. But I can't provide any more detail than that.

I understand.
Thank you for all your help.
I at least have one right configuration and can produce Japanese pdf file now, so it is OK already.
Maybe some day when I learn more about ruby, I will find out the problem.
I always feel like that you will yell at me, because of your profile. haha
Thanks again.

I always feel like that you will yell at me, because of your profile. haha

:rofl:
Nope, just trying to empower you with the best information I can give you.

Another approach you might try is to use the provided Docker image via Docker for Windows. See:

https://docs.docker.com/docker-for-windows/
https://hub.docker.com/r/asciidoctor/docker-asciidoctor/

That way, you take your Windows problems out of the picture. Linux handles encodings perfectly and you'll never run into these types of problems. (Another route is cygwin, but I'm less familiar with that environment to recommend it).

Thank you very much !!

FYI: https://qiita.com/kuboaki/items/67774c5ebd41467b83e2

Thanks for sharing. There are few outdated things about that article. First, it uses the deprecated pdf-style attribute instead of pdf-theme. It also doesn't use the extend feature for the theme with font catalog merging, which makes it a lot simpler to define and use custom fonts. See https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc#keys-extends

Mr. mojavelinux
Thank you for your help 10 months ago.
Now I already solve Japanese Language problem, of course. ;)
I edited some of my commits recently for personal information.
Hope it doesn't bother you. :)
And I would like to ask you a favor.
Could you please delete the generated 「jp.pdf」 file for me.
Thank you in advance.

I have removed the file at your request.


Add BMP support

Hi,
Thanks for your contribution!
I try to avoid magickload since ImageMagick is dark and full of terrors. Also, I'm pretty sure BMP is dead, so I don't think imgproxy needs its support.
I'll keep this PR open to see if there will be upvotes.

I finally decided to use magickload for certain formats.
Thanks for your contribution!


angular-cli.json file specs

I am looking for angular-cli.json file specs.

See https://github.com/angular/angular-cli/blob/master/packages/angular-cli/lib/config/schema.d.ts


Update plan-for-software-updates.md

Added note to point out that Configuration Manager only expires updates internally.  Typically the term expire relates to expiring updates in WSUS which would help maintain the catalog.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dougeby For your review.

Doug, I'm might very well be wrong here but I'm not quite sure what you added there is correct.  Looking at several environments I manage it does not appear that the WSUS Cleanup Wizard is declining updates that SCCM expires.  When looking at the WSUS console I'm seeing thousands of updates that were superseded years ago.  That's what I was attempting to get at; the Supersedence Rules seem to remove the update from SCCM but not WSUS and its catalog. That seemingly requires running scripts to decline superseded updates in WSUS as described by several MVPs.


Data format of ItemTable

This issue is simply a reminder to update the data format used by the table method of ItemTable to the new dictionary columns format.

@philippjfr Seems this issue is probably outdated now after the recent work on the data API.
Think this issue can be closed now?

ItemTable and the data API are unrelated, so it should probably stay open.

Turns out this indeed could have been closed back in May 2016, oh well.


Use full outline path for journal entries created through org-capture on org nodes

Is your feature request related to a problem? Please describe.
When creating a journal entry through org-capture on an org node, I often would like the complete outline path of the org node to appear as description, not simply the final title. For instance:
* Tasks
** Project X
*** Item 1  <--

is currently captured in the journal as Item 1, and I would like a way to capture it as Tasks/Project X/Item 1, or Project X/Item 1.
Describe the solution you'd like
I'm not knowledgeable enough in org-store-link and org-capture templates, so I can't propose an implementation. What I would like is maybe an option for org-journal which lets me activate the above behaviour, or a function to use in the org-capture templates which I could use instead of %a to get the above behaviour.
In the case of the org-journal option, maybe this could be implemented through a particular handling of links like here?
Describe alternatives you've considered
The two alternatives above are the only ways I see of doing this.

Thank you for your bug report. I believe this is an issue with org-capture, not org journal.


Why minSdkVersion is 15?

As title. Is there any API limit the minSdkVersion?

We got that question multiple times already.
See https://github.com/grandcentrix/tray/issues/93 https://github.com/grandcentrix/tray/pull/94 and https://github.com/grandcentrix/tray/issues/58
We have no interesting to reduce it. But as you can see in the linked issues you can just override the minSdkVersion.

Thanks for quick response!


fix(docs): Correct and clarify description of builder component

Closes #3926

LGTM.

LGTM. This did pass the relevant doc tests in CI, so :shipit:.


Add limit of 1 implements a day to glitch season reward

As part of breakfast, mafia will implement the glitch season reward if enabled.
However, the implementation can only be incremented once a day. Beyond that doesn't appear to do anything.

If we're sure that this is the behaviour, I'm happy. Can you change the verb from implemented to used? There's a vague standard for used for binary daily limit prefs and uses for integer daily limit prefs.

If we're sure that this is the behaviour, I'm happy. Can you change the verb from implemented to used? There's a vague standard for used for binary daily limit prefs and uses for integer daily limit prefs.

Are you sure? This could potentially break expectations and possibly existing scripts. You're referencing to the pref name correct?

Oh I see this is not a new pref. Whoops! You're fine


Fix #63

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

Coverage remained the same at 84.581% when pulling aecdbb91b49f7230c92a611d743d74d875fd82e7 on mirceaulinic:FIX-63 into eb07a5682bffe77a0798780341719fed52b96445 on napalm-automation:develop.

+1


[API RFC] TorchArrow CAST support

Use Case
In feature pre-processing we often needs to cast feature ID from int64 to int32. The cast often needs to recursively done for complex types, such as

List<int64> -> ARRAY<int32>, or even
Struct<list<int64>, array<float32>> -> struct<list<int32>, array<float32>>

It looks a good API to support in TorchArrow directly.
CAST in PyArrow/SQL
In ANSI SQL, CAST over array/row type is also defined to applied recursively into each elements. This is also the behavior of Presto.
Today PyArrow supports cast for PyArrow.Array. It works for List but not Struct. PyArrow developer confirmed it's planned to be supported  . Here is the JIRA ticket: https://issues.apache.org/jira/browse/ARROW-1888 . See also discussion in mailing list
Proposal
TorchArrow supports IColumn.cast, and the cast will be done recursively per element for List/Struct, similar to PyArrow/SQL.
Current API
We currently have IColumn.astype and the current prototype only supports casts between numeric types: https://github.com/facebookresearch/torcharrow/blob/902f177a8002a71189dcddf931b8484c69a06c6d/torcharrow/icolumn.py#L235-L249
Similar API in other libraries:

PyTorch uses Tensor.to : https://pytorch.org/docs/stable/generated/torch.Tensor.to.html
Pandas/NumPy use astype: https://pandas.pydata.org/pandas-docs/version/0.23/generated/pandas.Series.astype.html, https://numpy.org/doc/stable/reference/generated/numpy.ndarray.astype.html

cast seems to be a better name since in TorchArrow, the conversion is closer to PyArrow/SQL semantic and may not be trivial (e.g. it may cast from integer to string, or vice-versa). And cast suggests non-trivial conversion.  The name to and astype seems to hint more trivial conversion (e.g. conversion between integer and float).

astype is now renamed as cast in https://github.com/facebookresearch/torcharrow/pull/43

In PyTorch, there is also Tensor.type_as : https://pytorch.org/docs/stable/generated/torch.Tensor.type_as.html#torch.Tensor.type_as


Files opened externally now opened in new window even if project window already open

After one of the latest Atom updates, files opened from the file system are no longer opened in one of the existing windows, but rather in a window of their own. Can this be disabled somewhere in the preferences to go back to the old behaviour? Unless improvements are made so that opening a new Atom window doesn't take 5+ seconds, it's really detrimental to your work flow if you have to wait that long for opening a single file that you just want to copy some contents from.

Hey @adambuczynski, thanks for opening an issue. Would you mind providing a bit more information? There's a neat guide to help you with that:
https://github.com/atom/atom/blob/master/CONTRIBUTING.md#reporting-bugs
Also, a similar issue was reported and fixed a few days ago. Can you check out https://github.com/atom/atom/issues/9574 and https://github.com/atom/atom/pull/9672 and see if that fits your description? I'm going to close this for now since I think that's the same problem and it was fixed, but let me know I'm wrong. And again, please try to include more helpful information with your reports because it's really hard to provide advice when we don't even know which version of Atom you're on, or which OS you're using. Thanks

Hi @izuzak , it was on Atom 1.2.0 for Mac OS X. I didn't think this information is relevant, as the issue was files being opened in a new window, which I assumed was a non-OS specific design decision from the Atom team.
Before positing I did a search for "new window" in the issues, and did not find a relevant ticket.

@izuzak I think this issue still hasn't been addressed. The issues you linked don't seem to be referring to the same problem.
An additional symptom of this problem is that when having a project window open, and then opening a file from within that project through an external app (e.g. Github Desktop), it still opens a new window for that file, even though a window for that project is already open. This seems like a valid bug.
Atom 1.2.4 on Mac.

Thanks for following up, @adambuczynski. Just to make sure we understand, can you post the exact steps to reproduce the problem and a GIF which follows those steps to demonstrate it? Also, which version of OSX are you on exactly ("on Mac" is not :gem: clear).

OS X 10.10.5

Open Atom
Open a project folder (e.g. ~/Sites/something)
Go to Finder (or any other external app)
Open a file from within the project folder (e.g. ~/Sites/something/somefile.js)
Observe how Atom opens a new window for the file, rather than opening it in the existing project window.

This wasn't a problem until 1.2.x I believe, as Atom would just open files that you opened externally in the same window.

Could you please reopen this issue, it's really bothersome. I've provided steps to reproduce, please let me know if you need more information. Thank you!

This also happens when dragging a file from Finder into an existing Atom window.
Also affects OS X 10.11.1

I've just switched to Atom from Textmate and I missed this feature. I often use the iTerm Cmd-clic to open a file from my terminal and was sad to see them opened (very slowly) in a new window. It would be awesome if it would work again.

This seems to have been fixed now in Atom 1.4.x and above.


fail loudly when you can't reconcile

For types that should be reconcilable (like dataframes & matrices), the Reconciler should fail with an NotImplementedError, NOT return rhs and lhs (which would lull users into a false sense of security).
This should also be a forcing function that guarantees we get to reconciling these types sooner rather than later

@JeffDotPng can you please review since you were recently working on something similar? Curious on your thoughts

These are just placeholders for now for types that should be reconcilable, we just haven't gotten around to it yet correct? Looks good, I definitely agree that it's better to throw an error rather than produce unexpected behavior to the user.


MTL-1288 Fix Race Condition and Debug Mode

Summary and Scope

Fixes MTL-1288

Issue Type

Bugfix Pull Request

Race Condition Fixes
This fixes two race conditions.

Fix the race condition with the pave function. Do not create anything until after the pave function has ran to completion.
Fix the race condition with dmsquash-live, add wait_for_dev to prevent pivoting to root before luksetcd finishes.

Debug Mode
This also fixes debug.
metal.debug was not honoring metal.debug=1 in some cases. Also add metal.debug to every possible file except for module-setup.sh.
Consistent Behavior
This change removes the need to key off metal.no-wipe. Instead if the ephemeral disk is found this module quits, otherwise if luks is enabled and a deployment server is set this module must find a disk. The metal.no-wipe is just a safeguard to ensure wipe functions are not invoked when it's enabled. This makes behavior consistent with dracut-metal-mdsquash.
Consider NVME-Only Systems
Leverage the new disks_exist method to wait for /dev/sd or /dev/nvme devices. This ensures that pure NVME systems can deploy, otherwise only SD systems and mixed (SD + NVME) are compatible.
Misc.

Remove old shim for the metal-lib function since it exists in the right place now.
Add/update License

Prerequisites

[x] I have included documentation in my PR (or it is not required)
[x] I tested this on internal system (x) (if yes, please include results or a description of the test)
[x] I tested rebooting with metal.no-wipe=0
[x] I tested rebooting with metal.no-wipe=1
[x] I tested rebooting with the disk boot loader
[x] I tested the three scenarios above on k8s-masters and k8s-workers

Idempotency

Risks and Mitigations
What is less risky, or more risky now - or if your mod fails is there a new risk?
This mitigates the risk of loosing partitions from forgetting to manually wipe, ensuring that any boot from the PIT node will wipe the nodes.
This does pose some risk in-and-of itself being that this is significantly changes the codebase and that this codebase is hard to test.

I haven't had success yet on a master node.
Workers are happy so far though with https://github.com/Cray-HPE/dracut-metal-dmk8s/pull/19

The worker PR is actually conflicting, it's making dracut wait on worker partitions:
[    8.003590] dracut-pre-udev[983]: +++ str_replace /dev/disk/by-label/CONLIB / '\x2f'
[    8.021072] dracut-pre-udev[983]: +++ local in=/dev/disk/by-label/CONLIB
[    8.037074] dracut-pre-udev[983]: +++ local s=/
[    8.057055] dracut-pre-udev[983]: +++ local 'r=\x2f'
[    8.073053] dracut-pre-udev[983]: +++ local out=
[    8.089054] dracut-pre-udev[983]: +++ strstr /dev/disk/by-label/CONLIB /
[    8.105054] dracut-pre-udev[983]: +++ '[' '' '!=' /dev/disk/by-label/CONLIB ']'
[    8.125054] dracut-pre-udev[983]: +++ chop=
[    8.137058] dracut-pre-udev[983]: +++ out='\x2f'
[    8.153061] dracut-pre-udev[983]: +++ in=dev/disk/by-label/CONLIB
[    8.173055] dracut-pre-udev[983]: +++ strstr dev/disk/by-label/CONLIB /
[    8.189054] dracut-pre-udev[983]: +++ '[' '' '!=' dev/disk/by-label/CONLIB ']'
[    8.205054] dracut-pre-udev[983]: +++ chop=dev
[    8.221053] dracut-pre-udev[983]: +++ out='\x2fdev\x2f'
[    8.237069] dracut-pre-udev[983]: +++ in=disk/by-label/CONLIB
[    8.253090] dracut-pre-udev[983]: +++ strstr disk/by-label/CONLIB /
[    8.269053] dracut-pre-udev[983]: +++ '[' '' '!=' disk/by-label/CONLIB ']'
[    8.285168] dracut-pre-udev[983]: +++ chop=disk
[    8.301168] dracut-pre-udev[983]: +++ out='\x2fdev\x2fdisk\x2f'
[    8.321711] dracut-pre-udev[983]: +++ in=by-label/CONLIB
[    8.341071] dracut-pre-udev[983]: +++ strstr by-label/CONLIB /
[    8.357110] dracut-pre-udev[983]: +++ '[' '' '!=' by-label/CONLIB ']'

This is ready to go.

Done testing. NCNs wipe themselves whenever they're booted with metal.no-wipe=0, otherwise partitions are mounted normally when diskbooted or netbooted with metal.no-wipe=1.


<EMAIL_ADDRESS>and @angular/cli 1.5.0-beta.3 ERROR in TypeError: this.compiler.listLazyRoutes is not a function

Hello there after updating to beta-3 cli i have the following error when i try to build
ng build --aot --prod

ERROR in TypeError: this.compiler.listLazyRoutes is not a function

Full stacktrace
Date: 2017-10-24T13:34:14.826Z
Hash: 627bcc0447c626bbf583
Time: 7639ms
chunk {0} styles.6836259b7c89f232e1e8.bundle.css (styles) 55.5 kB {3} [initial] [rendered]
chunk {1} polyfills.3bc34265385d52184eab.bundle.js (polyfills) 86 bytes {3} [initial] [rendered]
chunk {2} main.e402deade8b026b7d50e.bundle.js (main) 84 bytes [initial] [rendered]
chunk {3} inline.9fb4e836276006143c8d.bundle.js (inline) 1.45 kB [entry] [rendered]

ERROR in TypeError: this.compiler.listLazyRoutes is not a function
    at AngularCompilerProgram.listLazyRoutes (/x/x/x/x/repos/private/store/client/node_modules/@angular/compiler-cli/src/transformers/program.js:157:30)
    at Function.NgTools_InternalApi_NG_2.listLazyRoutes (/x/x/x/x/repos/private/store/client/node_modules/@angular/compiler-cli/src/ngtools_api.js:36:36)
    at AngularCompilerPlugin._getLazyRoutesFromNgtools (/x/x/x/work/repos/private/store/client/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:231:66)
    at Promise.resolve.then (/x/x/x/work/repos/private/store/client/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:483:46)
    at process._tickCallback (internal/process/next_tick.js:109:7)
rampage@rampage-ThinkStation-D20:~/x/x/x/private/store/client$ ^C
rampage@rampage-ThinkStation-D20:~/x/x/x/private/store/client$

Any workarounds ?

I updated to<EMAIL_ADDRESS>everything is wokring now :)
I assume that i need to wait untill full 5 is released and not write such a issues because it is not relevant to the current situation.


Win32 testing

NEEDS TESTING AND FIXES FOR LINUX! READ CAREFULLY.
First set of changes that make the cmakefiles generate a almost working libospray.dll under windows.
Caveats:

one last link error in that libospray.dll doesn't find libospray_embree.lib (even though it does get properly generated!?). All sse-avx,avx2 versions of libembree get generated, though, as well as all ispc files.
makefiles only build the lib itself, not the application(s) (would need glut for that)
only works with intel compiler right now. make sure to switch solution over to icc once it is (re-)generated by cmake.
some functions (getSysTime(), getfullpath() commented out, and replaced by thrown exceptions)
indentation isn't right, plus there's tabs.
a few #ifdef's are a bit nasty. in part, the ones related to M_PI and id_t
currently disabled most warnings in platform.h. it would be better if those warnings got fixed, though...
probably broke some things on linux build (haven't tested yet)

resolved in separate win testing branch.


Quadriga market fixes

Updated the supported markets and moved them to a separate JSON file with an order book
Applied a proper fix for the uppercase currencies vs Quadriga order book format because there was inconsistencies between the Quadriga page using XBT/CAD which has order book btc_cad

@cmroche it is up to you if you want to pull this.  It is a breaking change for anyone with a config using the BTC order book since I changed that to match Quadriga's website.

The top level declaration cleanup is in another pull request that should be accepted first.

Thanks a lot!

It is a breaking change for anyone with a config using the BTC order book since I changed that to match Quadriga's website as XBT.

There will be multiple breaking changes coming soon, I'm not too worried about this right now. This will be reflected in the changelog when we bump the stable release.


Querying for IAM resources appears to be failing

Need to look into querying for IAM roles and policies. Currently not getting back expected IAM roles that exist in a test when using a Query.
Check if it's because they're global resources?

Closed as I'm no longer working at Gruntwork and since the issue was stale enough that it likely need revalidation / may no longer be true.


Notebook: Edit button is visible even if user is not logged in

Environment
Docker
Version
0.14.0
Describe the problem
The backend already uses an admin procedure and blocks any attempts of changing the text when the user is not logged in.
However, on the frontend, the edit/save button is still visible regardless of whether the user is logged in or not.
Logs
Don't think it's necessary, just add a notebook widget, log out, try and edit it and see the errors come up.
Context
No response
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

Thanks for the report, overlooked it. Wasn't a big concern but better experience for the user to fix it indeed.


Add option for custom-check-dir

This PR adds an option to customize the custom-check-dir option.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This can be achieved using the tfsec_args argument, is there something not working with using that?

@owenrumney Nope, we're currently using that. However, it'd be slightly more convenient if there was a dedicated option for this.
Feel free to close out this PR if it is undesirable, the Action works perfectly fine for me right now with the options that are available 😄

Hi @rzhade3  - I'm no longer on the tfsec team so can't interact with this. There is a tfsec channel on aquasec.slack.com where you could ask for feedback.


fix(control-tower): upgrade to latest CW Synthetics version

in order to prevent deprecated canary version from failing, it wont work anymore from end of may on.
fiexes #202
Definition of done (v0.0.1)

[x] Automated integration test
[x] Integrity protection according to ADR-NNNN
[x] Structured Logging and Monitoring for Lambda function according to ADR-NNNN

Green tests


ProcessPool fixes

Fixes pool serialization edge cases:
Handle serialization of types that inherit from "safe" builtins like int that may not themselves be safe to
pickle - e.g. the Boost.Python.enum type was seen to cause pickle failures despite inheriting from int.
Also, don't allow users to schedule tests from the main module in Process pool, since the main
module is different for the workers than in the parent process.

Rename test/ dir to tests/
To avoid a namespace clash with the python3 standard lib "test" package
(https://docs.python.org/3/library/test.html)

Ensure TCP sockets are always cleaned up by ProcessPool
Make the TCPConnectionManager used by the ProcessPool into a Resource that can be started
to create TCP sockets and stopped to clean them up after. This avoids hanging seen in tests due
to lack of resource cleanup.

Small refactor of Pool internals
Split up the large message handling function into seperate functions to handle each message type
expected from workers.

I think this PR has gotten a bit too big and amorphous with various attempts to fix the CI tests. In hindsight renaming test/ -> tests/ was a bigger change than I thought it would be and should be done seperately to the ProcessPool related changes and the other changes related to Travis CI infra.


trigger ci

Codecov Report

Merging #24 into master will decrease coverage by 0.75%.
The diff coverage is 89.26%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   89.97%   89.21%   -0.76%
==========================================
  Files         283      304      +21
  Lines       13772    15516    +1744
==========================================
+ Hits        12391    13843    +1452
- Misses       1013     1263     +250
- Partials      368      410      +42

Flag
Coverage Δ

#integration
?

#unit
89.21% <89.26%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

exporter/signalfxexporter/config.go
90.69% <ø> (ø)

exporter/splunkhecexporter/config.go
80.00% <ø> (ø)

exporter/splunkhecexporter/exporter.go
100.00% <ø> (ø)

processor/groupbytraceprocessor/metrics.go
100.00% <ø> (ø)

processor/groupbytraceprocessor/processor.go
97.50% <ø> (ø)

processor/groupbytraceprocessor/ring_buffer.go
100.00% <ø> (ø)

processor/groupbytraceprocessor/storage_memory.go
90.90% <ø> (ø)

processor/k8sprocessor/options.go
100.00% <ø> (ø)

...resourcedetectionprocessor/internal/aws/ec2/ec2.go
90.00% <ø> (ø)

...resourcedetectionprocessor/internal/gcp/gce/gce.go
100.00% <ø> (ø)

... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3299c...684d6d9. Read the comment docs.


Missing REST API listing for content types

Environment

Nautobot version (Docker tag too if applicable): 1.5.6
Python version: 3.10.9
Database platform, version:
Middleware(s):

Steps to Reproduce

Create a Job with following variable:

content_type = ObjectVar(
    model=ContentType,
)

Navigate to Job run form in UI

Expected Behavior
Able to run the Job

Observed Behavior

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/urls/base.py", line 71, in reverse
    extra, resolver = resolver.namespace_dict[ns]
KeyError: 'contenttypes-api'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/views.py", line 116, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/nautobot/extras/views.py", line 1107, in get
    return render(
  File "/usr/local/lib/python3.10/site-packages/django/shortcuts.py", line 19, in render
    content = loader.render_to_string(template_name, context, request, using=using)
  File "/usr/local/lib/python3.10/site-packages/django/template/loader.py", line 62, in render_to_string
    return template.render(context, request)
  File "/usr/local/lib/python3.10/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 170, in render
    return self._render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 162, in _render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 162, in _render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/loader_tags.py", line 62, in render
    result = block.nodelist.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/defaulttags.py", line 315, in render
    return nodelist.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/library.py", line 234, in render
    return t.render(new_context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 172, in render
    return self._render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 162, in _render
    return self.nodelist.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 938, in render
    bit = node.render_annotated(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 905, in render_annotated
    return self.render(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/defaulttags.py", line 166, in render
    values = self.sequence.resolve(context, ignore_failures=True)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 671, in resolve
    obj = self.var.resolve(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 796, in resolve
    value = self._resolve_lookup(context)
  File "/usr/local/lib/python3.10/site-packages/django/template/base.py", line 858, in _resolve_lookup
    current = current()
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 471, in hidden_fields
    return [field for field in self if field.is_hidden]
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 471, in <listcomp>
    return [field for field in self if field.is_hidden]
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 148, in __iter__
    yield self[name]
  File "/usr/local/lib/python3.10/site-packages/django/forms/forms.py", line 163, in __getitem__
    self._bound_fields_cache[name] = field.get_bound_field(self, name)
  File "/usr/local/lib/python3.10/site-packages/nautobot/utilities/forms/fields.py", line 554, in get_bound_field
    data_url = reverse(route)
  File "/usr/local/lib/python3.10/site-packages/django/urls/base.py", line 82, in reverse
    raise NoReverseMatch("%s is not a registered namespace" % key)
django.urls.exceptions.NoReverseMatch: 'contenttypes-api' is not a registered namespace

Note: The workaround is to have hardcoded content types for the Job, but that is sub-optimal as we have extra filter there to allow only content types of certain custom field  and the content types assigned to this custom field might change in future.

So there actually is a /extras/content-types/ REST API already - looks like something isn't quite right in the wiring here. Changing this to a bug.


Poetry update

Codecov Report

Merging #19 (8b3b1f8) into main (462c256) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   71.79%   71.79%
=======================================
  Files          10       10
  Lines        1124     1124
=======================================
  Hits          807      807
  Misses        317      317

Impacted Files
Coverage Δ

origami/_version.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef80be...8b3b1f8. Read the comment docs.


crypto package clashes with nodes internal crypto package

It seems that the crypto package you use to create md5 hashes clashes with the package which comes with node.js.
Since npm (>= v3.0.0 i think) installs all packages on the highest level possible, there is in the root node_modules directory the crypto package you use.
At least on our dev systems with devPackages installed (gulp-jscpd which usses jscpd) we can't use nodes own crypto package
Is it possible that you can use another package to create the md5 hashes (e.g. md5)
If have no idea how to solve this issue, only to not use the jscpd code checker. Or is there a way to require the node internal package (i didn't found any)?
Regards

Hm, i am not so shure what happens here. But i think it is an node6 issue. sorry to bother you.

(y) np


Fix problem with commit lint

What
There is an intermittent problem with the commitlint configuration that has been reported by @pazbardanl @jmcook1186 and @manushak but does not yet have a diagnosis. It needs diagnoising and fixing to ensure we maintain a good developer experience.
Why
As a developer I want to be able to raise PRs into IF without having to fiddle with commitlint config as it degrdaes the DX.
Context
When developing locally, there are cases where npm test reports 100% passing tests and npm run fix reports no issues, however, when pushing a commit, commitlint errors out due to failing tests. Removing npm test from the commitlint config solves the issue, suggesting that there is some difference between the true state of the local environment and the one commitlint is using to run its tests.
SoW

[ ] diagnose problem with commitlint tests
[ ] fix issue across all IF repositories

Acceptance criteria

[ ] issue is fixed
GIVEN the issue is fixed and my local repository passes npm test and I have run npm run fix
WHEN I push new commits from my remote copy of IF
THEN commitlint should not reject the changes

@jmcook1186 please report the issue that you have experienced when you can't push your commits

@jmcook1186 do you know any steps to reproduce this?

I'm not sure, I'm afraid, it occurs frequently but I haven't yet noticed what the pattern is. At some point during development commits just stop passing commitlint due to test failures. Speculate that maybe it happens after a git pull when there are staged local changes, but not sure that this is true.

@manushak @jmcook1186 please add any context you can when you experience this issue as it is currently not possible for @narekhovhannisyan to replicate

@manushak and @narekhovhannisyan to have sync to identify cause

Closing as it seems to have fixed itself in the interim...!


Check if a json object key exists

It seems like there is no way to check if a json object contains a given key.
The only way, if I'm not mistaken, is to call operator[] and check the returned object for null, however this will not produce the appropriate behavior if the object actually contains a null value for this key (in which case there is not way to verify if the key is present in the json or not).
It would be nice if there was something like a has_key() function ?
Happy to be corrected if I missed something.

I have an example use case if you don't see why a user could possibly need this :
When deserializing the delta values of a c++ object from a json representation (by which I mean, only what has changed), a null value for the key would mean that the value needs to be set to null, and an absence of key would mean that the value is not set. Currently I believe this library doesn't provide a way to differentiate between the two.


Application reminder email includes incomplete service count

https://trello.com/c/AzV9twDI/219-revise-1-week-reminder-email-to-prompt-applicants-with-any-incomplete-draft-services
For DOS4, some suppliers didn't realise they had incomplete services that needed to be submitted. This PR tweaks the reminder script to include a message with the number of incomplete services (unless the supplier hasn't submitted any services, in which case the original 'mark at least one of your services as complete' message is shown).
Other changes:

the script now exits early if the framework is not open (the supplier can't make any changes if the framework is in any other state)
the script is framework-agnostic (the Notify template was previously hardcoded to DOS4). This means formatting the application closing date using our special framework deadline date filter, utctoshorttimelongdateformat
the MESSAGES list is now a dict, for better visibility of what message we want to pick in each case

Changes to the Notify template:

We will need to tweak the first paragraph of the email to take into account suppliers who have technically completed their application, but have some unsubmitted services left over (perhaps intentionally).

Bellissimo!


MDWampClient with auth methods kMDWampAuthMethodCRA not Working

I have an problem with MDWampClient with auth methods kMDWampAuthMethodCRA:
MDWampTransportWebSocket *transport = [[MDWampTransportWebSocket alloc] initWithServer:[NSURL URLWithString:@"ws://gateway.api.monitor.cl:9000"] protocolVersions:@[kMDWampProtocolWamp2json]];
_wamp = [[MDWamp alloc] initWithTransport:transport<EMAIL_ADDRESS>delegate:self];

MDWampClientConfig *conf = [[MDWampClientConfig alloc] init];
conf.authmethods = @[kMDWampAuthMethodCRA];
conf.authid = @"monitor.frontend";
conf.sharedSecret = @"monitor.97";

[_wamp setConfig:conf];

[_wamp connect];

When i call it, the "(void) mdwamp: closedSession: reason: details:" is fired:
2015-07-24 19:02:36.337 WebSockeTest[56163:3712243] -[MDWampTransportWebSocket webSocketDidOpen:] negotiated protocol is wamp.2.json
2015-07-24 19:02:36.340 WebSockeTest[56163:3712243] -[MDWamp transportDidOpenWithSerialization:] websocket connection opened
2015-07-24 19:02:36.340 WebSockeTest[56163:3712243] -[MDWamp sendMessage:] Sending <MDWampHello: 0x7f8b71487990>
2015-07-24 19:02:36.510 WebSockeTest[56163:3712243] #### Closed Code: 0 --- reason:wamp.error.not_authorized ---- details:{
message = "authentication using method 'anonymous' denied by configuration";
}
2015-07-24 19:02:36.693 WebSockeTest[56163:3712243] -[MDWamp transportDidCloseWithError:] DID CLOSE reason The operation couldn’t be completed. Connection reset by peer
It's strange because i not used anonymous method.
Many thanks!

With cristian we tracked down the bug !!! and found it! in file MDWampClientConfig.m in method getHelloDetails the second string in the init of NSDictionary* d is @"authmetods" and should be @"authmethods" (line 65). Seems like the GitHub online version of that file doesn´t has that problem but that the cocoapod version has it!
You set the thing right by the way once you made the MDWamp object configuration with authid, authmethod, and secret then the following exchange of challenge, authenticate, welcome is automated internally in the MDWamp library.

thanks for spotting this I've to update the cocoapods version.

Thanks to you too :).
El 24-08-2015 5:57, "mogui"<EMAIL_ADDRESS>escribió:

thanks for spotting this I've to update the cocoapods version.
—
Reply to this email directly or view it on GitHub
https://github.com/mogui/MDWamp/issues/30#issuecomment-134101570.

Now synced in cocoapods version 2.1.1


Add example image pairs and tests of the algorithm's output on them

#19 adds one example/test image. However, that image contains no transparency, which will have interesting consequences, so I think we still want some more test images. I'm going to call this done and file a separate issue for that.


fix: only check permission for existing chunks

If the dropped flag is set for a chunk the real chunk is dropped but still present in the catalog. This leads to errors in the ChunkPermission rule since it tries to check ACL for a non-existing relation.
Fixes #26

Fix looks good, it would be nice to have a test for it as well.

Intended to add one after #22 was merged.

Building this on #34 so merging now.


Strong name everything

https://github.com/aspnet/dnx/pull/3105
Appveyor/Travis will fail until there's a signed package out for Microsoft.AspNet.Testing. See https://github.com/aspnet/dnx/pull/3105 for details.
cc @davidfowl @muratg @Eilon @moozzyk @pranavkm

Hi @cesarbs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:shipit:


fix(cursor, visual): fix sync mouse selection

Fixes #1450

They are same, but nvim_buf_set_mark is more stable.


Add "Three Legendary Cars" info to Legend cars dealership

Hey, great work on this project.
I believe many of us are using this site to check when one of the 3 legendary cars appear in the Legend cars dealership. Can this info be added and displayed for:
Car
-- |
Ford Mark IV Race Car '67
Jaguar XJ13 '66
Ferrari 330 P4 '67
I can make a PR if you want :)

Good idea, not sure why I didn't think of it myself :)
I'll do this myself now, shouldn't take too long

All done & I've cleaned up how the LCD displays a bit too.
Here's an example of how it looks:

Thanks for the implementation, looks great! Looking forward to see it live :smile:


ADd text to speech tool using OpenAI TTS1

Summary

Fixes #497
Checklist

[x] My code follows the code style of this project and passes make format.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] My change has adequate unit test coverage.

@homanp Thank you for the pull request! Overall, the changes look good. I have a few suggestions:

In the TTS1InputModel class, it would be helpful to add some validation for the voice field. For example, you could use the constr function from the pydantic library to ensure that the value is one of the allowed voices.

In the TTS1 class, it would be good to handle any potential errors that may occur when making the API request. You can use a try-except block to catch any exceptions and handle them appropriately.

Other than that, the code changes look good. Thank you for your contribution! 👍🏼


Update Debug impl to use the value

This updates the Debug implementation of DiplomaticBag to use the actual value inside.

Also, what's your usecase for this library? I wasn't really expecting anyone to use it, as there's often a simpler solution than this!

@Skepfyr I didn't really have a use case as such. I had an idea of using this for syncronising some logging for a webserver.


Cloudwatch alarm with metric math

Hi, iI am a little new to terraform, can you add an example of how to define an alarm with "metric math", how the expression in the field "metric query" should look like?
Thank you :)

Hi,
Apologies for such long delay in response.
I think you are referring to this line:
https://github.com/terraform-aws-modules/terraform-aws-cloudwatch/blob/2ac1b391ad36dccd27831871529e2c1db10b828e/examples/lambda-metric-alarm/main.tf#L71


python310Packages.mmcv: 2.0.0 -> 2.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.mmcv is: A Foundational Library for Computer Vision Research
meta.homepage for python310Packages.mmcv is: https://github.com/open-mmlab/mmcv
meta.changelog for python310Packages.mmcv is: https://github.com/open-mmlab/mmcv/releases/tag/v2.0.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.1 with grep in /nix/store/89yixkgnjjyi7lmglfxb50cw66pw44hl-python3.10-mmcv-2.0.1
found 2.0.1 in filename of file in /nix/store/89yixkgnjjyi7lmglfxb50cw66pw44hl-python3.10-mmcv-2.0.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.mmcv
python311Packages.mmcv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/89yixkgnjjyi7lmglfxb50cw66pw44hl-python3.10-mmcv-2.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.mmcv https://github.com/r-ryantm/nixpkgs/archive/f74226cd709f75da662fbd923ea27c5912f45705.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/89yixkgnjjyi7lmglfxb50cw66pw44hl-python3.10-mmcv-2.0.1
ls -la /nix/store/89yixkgnjjyi7lmglfxb50cw66pw44hl-python3.10-mmcv-2.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.mmcv

1 package built:

python310Packages.mmcv

Maintainer pings
cc @benxiao for testing.

@ofborg build python310Packages.mmcv python310Packages.mmcv.passthru.tests

this will not build now, as there is a protobuf version collision.  and missing buildinputs.

Duplicate of https://github.com/NixOS/nixpkgs/pull/259994

Closing in favor of https://github.com/NixOS/nixpkgs/pull/259994


How do I achieve AR try on with filament.

hello, I want to write an AR try on application with filament.
first input is 3d head vertices, second input is glass model vertices.
I want to put the glass on the head, hidden the 3d face vertice, and hidden the part of the glass which is blocked by head.
how How do I achieve it with filament.


Add static forByteArray(), forString() and forUtf8String() methods to  MountableFile.

CHANGES

Add forByteArray(byte[] content, int mode) to  MountableFile.
Add forByteArray(byte[] content) to  MountableFile.
Add forString(String content, Charset charset, int mode) to  MountableFile.
Add forString(String content, Charset charset) to  MountableFile.
Add forUtf8String(String content, int mode) to  MountableFile.
Add forUtf8String(String content) to  MountableFile.

DESCRIPTION
As a very frequent Testcontainers user, I see the use case that I have to manipulate the content of a file during runtime of the test before using withCopyToContainer().
The current way to do this, is to create a temporary file where I write my desired content to, and than create a MoutableFile for that.
This is boilerplate and can be moved inside the MountableFile class.
EXAMPLE USE CASE
Create a configuration file for a Container during the test-runtime. Sometimes this is needed when some information is only present at a certain stage of the test-runtime. E.g. credentials.

@YannickWeber did you have a chance to read the previous comment?


Correcting array error

When I added string array to the path parameter on use, I accidentally added ErrorRequestHandler array too. It's not removed.

express/express.d.ts
to author(@borisyankov). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?


[404] Page not found: https://nf-co.re/docs/guidelines/graphic_design/overview

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Search "graphic design"

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Browser (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Do you mean this?
https://nf-co.re/docs/guidelines/graphic_design/overview
IT loads for me 🤔


feat(tutorial): complete step 4 Hursley

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

:+1::skin-tone-2: Looks good - I have recorded your completion of this step!


pointing existing tests to local backend

fixes jobs running on local backends

Don't worry too much about getting the ignores and tags 100% here, I'm refactoring a lot of the test generation stuff through a single mechanism in my branch, so I can (hopefully) incorporate these additions into that after you merge

👍

👍


What is StringToByteArray?

StringToByteArray is not a C# function, it is not defined in the docs.
It should be replaced with Convert.FromBase64String(headerValue)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b7960d-6de5-78ee-bc45-d7218239bbc8
Version Independent ID: d2db534b-198a-dc99-5b5a-0525582d39ac
Content: Configure certificate authentication in ASP.NET Core
Content Source: aspnetcore/security/authentication/certauth.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @blowdart
Microsoft Alias: bdorrans

@Damienbod

It's actually required.  Will add it.
´´´
private static byte[] StringToByteArray(string hex)
{
int NumberChars = hex.Length;
byte[] bytes = new byte[NumberChars / 2];
for (int i = 0; i < NumberChars; i += 2)
bytes[i / 2] = Convert.ToByte(hex.Substring(i, 2), 16);
return bytes;
}
´´´
Convert.FromBase64String(headerValue) would not work as it's not a base 64 string.

Added a PR for this.

Fixed by #15608

something wrong with StringToByArray()
For example, this is my sample certificate which Azure set in header:
MIIB8zCCAWCgAwIBAgIQct6X6LxriYxOa3wCiYTikzAJBgUrDgMCHQUAMBgxFjAUBgNVBAMTDXN0ZWFtdWwta2lvc2swHhcNMjAwNDA1MjIwNzUxWhcNMzkxMjMxMjM1OTU5WjARMQ8wDQYDVQQDEwZraW9zazEwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMXbmbvIH8ZN7ZLjD6GyFyoE5lOfI+XjOwViQNdNLkR1cQXCE2HOi+phiULGKgePL3HpOsDsAVnpDi1KDMZotH0R/UIIrG1aHYWP82mCECwFywQjyXmY9EJxNJdoxsn/vnGrnscov1Uu6XIM3rLlkL+joGNuTk2Nr+ydkj2bHdxJAgMBAAGjTTBLMEkGA1UdAQRCMECAEFg+kLWROJ57iepJgKVqnuGhGjAYMRYwFAYDVQQDEw1zdGVhbXVsLWtpb3NrghDO46IgcEhEpEIAiaDdGxCwMAkGBSsOAwIdBQADgYEAUtDT2kleFvN6sx5h11XiUE7CIBO6VKVSA4aPOUXgKcSJEnsAV8Q1bedgS/NoPRNwx8KSwUYhNm3WnXCY1dzWHCKHcQ5gAyRyx0nhdQQyTgDGtmLXGcAWfgdRmNwecu+gNCRcYOJysfnUUORV6l+akpXUv/Sdtu8OqiAwUAaqCSU=
And this is error in this function:
System.FormatException: Could not find any recognizable digits.    at System.ParseNumbers.StringToInt(ReadOnlySpan1 s, Int32 radix, Int32 flags, Int32& currPos)
at System.Convert.ToByte(String value, Int32 fromBase)`

@vit100 depends how the client sends the data. In Azure, type of yes, you don't need any forwarding for Azure to work, this works per default, so  you shouldn't need to configure the forwarding in ASP.NET Core, but yes base64 is used.
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/certauth?view=aspnetcore-3.1#use-certificate-authentication-in-azure-web-apps

Ok. Let me then be more specific in PR which I created for this.
Point is that people most likely will use it with Azure - at least I hope, Azure is first choice -)).

correct, and Azure requires no forwarding so you never need to implement the AddCertificateForwarding if you use Azure

Pls look at this PR
https://github.com/dotnet/AspNetCore.Docs/pull/17657
I mentioned explicitly that Azure does require some config: header -> X-ARR-ClientCert

I will comment on the PR, good?
I think the base64 solution is better, what you suggested because this is more common. But AddCertificateForwarding should not be required either for Azure. It should just work. The example linked above works in Azure.


Update docker-compose.yml

Version 1.26.2 has been tagged but not released yet. When it is released this should be updated.

Closing in favor of #588 which bumps the node version to 1.26.2.


Clicking on hyperlink in field's Description column doesn't open the link

Describe the bug
Clicking on a hyperlink in the "Description" column of a field does not open the hyperlink at all. It only works if you copy paste the link into another tab, or Right Click and do "Open in New Tab".
To Reproduce
You can reproduce this in the Datahub demo site by clicking the link provided in the place_id field of the mobility_report dataset - https://demo.datahubproject.io/dataset/urn:li:dataset:(urn:li:dataPlatform:bigquery,bigq[…]bility.mobility_report,PROD)/Schema?is_lineage_mode=false
Expected behavior
The provided hyperlink to developers.google.com should work.
Desktop (please complete the following information):
Verified on Chrome and Firefox on Windows, Safari on iOS

@shirshanka this is good to close 👍


Add ServiceId [ECR-2953]

Overview

That’s a smallish part of ECR-2953 that can be reviewed. See also the design page.

See: https://jira.bf.local/browse/ECR-2953
Definition of Done

[X] There are no TODOs left in the code
[X] Change is covered by automated tests
[X] The coding guidelines are followed
[X] Public API has Javadoc
[X] Method preconditions are checked and documented in the Javadoc of the method
[X] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage increased (+0.07%) to 85.57% when pulling 2de9a0cb988ac53a7ffac85c15ecdbcc5691f2ae on dmitry-timofeev:dynamic-service-loader-ECR-2953 into 68871c8816268eb7b2a38aa1595ba40968b7be9a on exonum:master.


Varios ipsec + retain ip fixes

Program ipsec channel rules only for instances in Running/Starting
state
service.upgrade - startFirst option can't be used on the service
with retainIp=true
service.reconcile - stop unhealthy instances before starting new ones

https://github.com/rancher/rancher/issues/3458

TF is on the volume tests, seems to be unrelated:
_____________________ test_volume_create_failed_allocation _____________________
[gw0] linux2 -- Python 2.7.6 /scratch/cattle.MQBtW/tests/integration/.tox/py27/bin/python2.7
new_context = <common_fixtures.Context object at 0x7f5b4d935610>

    def test_volume_create_failed_allocation(new_context):
        client, agent_client, host = from_context(new_context)
        storage_pool = add_storage_pool(new_context)
        sp_name = storage_pool.name
        add_storage_pool(new_context)

        v1 = client.wait_success(client.create_volume(name=random_str(),
                                                      driver=sp_name))
        assert v1.state == 'requested'

        # Will fail because new_host is not in the storage_pool that v1 belongs to
        new_host = register_simulated_host(new_context)
        data_volume_mounts = {'/con/path': v1.id}
        with pytest.raises(ClientApiError) as e:
            c = client.create_container(imageUuid=new_context.image_uuid,
                                        requestedHostId=new_host.id,
                                        dataVolumeMounts=data_volume_mounts)
            client.wait_success(c)
        assert e.value.message.startswith('Scheduling failed: valid host')

        # Put two volumes from mutually exclusive storage pools onto a container
        # and it should fail to find placement
        sp2 = add_storage_pool(new_context, [new_host.uuid])
        v2 = client.create_volume(name=random_str(), driver=sp2.name)
        v2 = client.wait_success(v2)
        assert v1.state == 'requested'
        data_volume_mounts['/con/path2'] = v2.id
        with pytest.raises(ClientApiError) as e:
            c = client.create_container(imageUuid=new_context.image_uuid,
                                        dataVolumeMounts=data_volume_mounts)
            client.wait_success(c)
>       assert e.value.message.startswith('Scheduling failed: valid host')
E       assert <built-in method startswith of unicode object at 0x7f5b4d8174e0>('Scheduling failed: valid host')
E        +  where <built-in method startswith of unicode object at 0x7f5b4d8174e0> = 'Scheduling failed: volume [496] have exactly these pool(s):  [189], valid host(s) [153]'.startswith
E        +    where 'Scheduling failed: volume [496] have exactly these pool(s):  [189], valid host(s) [153]' = ClientApiError(u'Scheduling failed: volume [496] have exactly these pool(s):  [189], valid host(s) [153]',).message
E        +      where ClientApiError(u'Scheduling failed: volume [496] have exactly these pool(s):  [189], valid host(s) [153]',) = <ExceptionInfo ClientApiError tblen=2>.value

@ibuildthecloud @cjellick


Fix order price rounding in BrokerageTransactionHandler and EquityPriceVariationModel

Description

Added referencePrice argument to IPriceVariationModel
Updated EquityPriceVariationModel and BrokerageTransactionHandler to use limit/stop order prices instead of current market prices

Related Issue
Closes #3453
Motivation and Context
IB error when submitting limit orders around $1 prices:
110 - The price does not conform to the minimum price variation for this contract

Requires Documentation Change
No.
How Has This Been Tested?
New unit tests included.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Wondering if we should/can take care of backwards compatibility for the interface changes?

Not sure if/how many users have implemented a custom PriceVariationModel:
the existing interface method does not allow price rounding to be performed properly anyway because of the missing order information.

Not sure if/how many users have implemented a custom PriceVariationModel:
the existing interface method does not allow price rounding to be performed properly anyway because of the missing order information.

Right 👍 . I'm thinking since we are already chaning the interface, maybe for future proof we could add an GetMinimumPriceVariationParameters or alike? Like we did in the fill/fee/buyingPower models. And I think it could be a good opportunity to limit the parameters to just what is required, not the entire security instace, the new price reference, the symbol properties, etc?

GetMinimumPriceVariationParameters
Good idea! 👍 Will update the method to take a parameters class


fix: cpu may be negative on windows

fix #559

Sorry for miss your comment.
The old algorithm will lose lots of CPU time when some busy processes exit. This will cause allcpuu and allcpus decline (see image explanation below). Then cause the denominator to be negative.
    cpuu = (procStat.utime - _cpu_old.list[procStat.pid].utime) / (all - _cpu_old.all) * 100; // denominator negative!
    cpus = (procStat.stime - _cpu_old.list[procStat.pid].stime) / (all - _cpu_old.all) * 100; // denominator negative!


OpenSSL::SSL::SSLError when using dist focal in Travis CI

When using dist: focal in Travis CI, I get the following error:
Coveralls encountered an exception:
OpenSSL::SSL::SSLError
SSL_connect returned=1 errno=0 state=error: no protocols available

I have prepared a demo repo and results of each distro can be seen at https://travis-ci.org/github/LocoDelAssembly/coveralls
NOTE: Normally this failure won't cause the build to fail, I added a negated grep to search for 'OpenSSL::SSL::SSLError' to force failure to better visualize which distros are having this problem.
Repo at https://github.com/LocoDelAssembly/coveralls
What can be done to fix this?
Thanks

@LocoDelAssembly I've been having the same issue but in Heroku's CI using their stack running ubuntu 20.
It seems to be down to the way SSL is handled in the gem.
There's a second coveralls gem that's more actively maintained and that solved my issue.
https://github.com/tagliala/coveralls-ruby-reborn

Was the same issue in github actions:

Replacing gem with coveralls_reborn helped. Thanks!

I'm facing this issue again https://github.com/leandromoreira/redlock-rb/actions/runs/5160916661/jobs/9297795798?pr=133
[Coveralls] Submitting to https://coveralls.io/api/v1
Coveralls encountered an exception:
OpenSSL::SSL::SSLError
SSL_connect returned=1 errno=0 peeraddr=<IP_ADDRESS>:443 state=error: no protocols available