ODistributedConfigurationChangedException when using Java API insert in two node scenario

OrientDB Version, operating system, or hardware.

v2.2.7

Operating System

[ ] Linux
[ ] MacOSX
[ ] Windows
[ ] Other Unix
[x] Other: Docker version 1.11.1, build 5604cbe on OS X El Capitan

Expected behavior and actual behavior
Expected: Running a two node scenario with tcp-ip discovery, when using Java document API for inserting document on one of the nodes, the OrientDB server should select a cluster that belongs to that node, and the insert should succeed
Actual: in some cases, the insert fails with the stack trace:
2016-10-04 14:04:48:076 INFO  Local node 'orientdb-lab-node1' is not the master for cluster 'event_3' (it is 'orientdb-lab-node2'). Reloading distributed configuration for database 'test-db' [ODistributedStorage]com.orientechnologies.orient.server.distributed.ODistributedConfigurationChangedException: Local node 'orientdb-lab-node1' is not the master for cluster 'event_3' (it is 'orientdb-lab-node2')
        DB name="test-db"
        DB name="test-db"
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
        at com.orientechnologies.orient.client.binary.OChannelBinaryAsynchClient.throwSerializedException(OChannelBinaryAsynchClient.java:428)
        at com.orientechnologies.orient.client.binary.OChannelBinaryAsynchClient.handleStatus(OChannelBinaryAsynchClient.java:379)
        at com.orientechnologies.orient.client.binary.OChannelBinaryAsynchClient.beginResponse(OChannelBinaryAsynchClient.java:261)
        at com.orientechnologies.orient.client.binary.OChannelBinaryAsynchClient.beginResponse(OChannelBinaryAsynchClient.java:153)
        at com.orientechnologies.orient.client.remote.OStorageRemote.beginResponse(OStorageRemote.java:2133)
        at com.orientechnologies.orient.client.remote.OStorageRemote$6.execute(OStorageRemote.java:543)
        at com.orientechnologies.orient.client.remote.OStorageRemote$6.execute(OStorageRemote.java:537)
        at com.orientechnologies.orient.client.remote.OStorageRemote$1.execute(OStorageRemote.java:166)
        at com.orientechnologies.orient.client.remote.OStorageRemote.baseNetworkOperation(OStorageRemote.java:230)
        at com.orientechnologies.orient.client.remote.OStorageRemote.asyncNetworkOperation(OStorageRemote.java:158)
        at com.orientechnologies.orient.client.remote.OStorageRemote.createRecord(OStorageRemote.java:523)
        at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.executeSaveRecord(ODatabaseDocumentTx.java:2075)
        at com.orientechnologies.orient.core.tx.OTransactionNoTx.saveNew(OTransactionNoTx.java:246)
        at com.orientechnologies.orient.core.tx.OTransactionNoTx.saveRecord(OTransactionNoTx.java:179)
        at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.save(ODatabaseDocumentTx.java:2598)
        at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.save(ODatabaseDocumentTx.java:103)
        at com.orientechnologies.orient.core.record.impl.ODocument.save(ODocument.java:1800)
        at com.orientechnologies.orient.core.record.impl.ODocument.save(ODocument.java:1791)
        at lab.orientdb.OrientDbClient.insert(OrientDbClient.java:19)
        at lab.orientdb.Main.main(Main.java:25)

Steps to reproduce the problem
The issue can be reproduced by running docker-compose setup in this project:
https://github.com/mxns/orientdb-lab
Running this project as described in the README will start two OrientDB nodes in distributed mode, and start doing inserts on both nodes. The error appears as soon as start-up is complete and the program starts doing inserts, and the stack trace is printed to stdout.
Either build the images, or just run the docker-compose.yaml file, in which case the images will download from my repo at DockerHub.
In essence, what the (quite simple) test program does is the following:

Start two OrientDB nodes in distributed mode, node discovery by tcp-ip
Use following Java code to insert document:

    OPartitionedDatabasePool pool = new OPartitionedDatabasePool(dbUrl, user, password);
    ...
    try (ODatabaseDocumentTx ignored = pool.acquire()) {
        ODocument document = new ODocument(className);
        document.fromJSON(recordData.encode());
        document.field("date", timestamp, OType.DATETIME);
        document.save();
    }

Could perhaps be related to #6765, similar stack trace
EDIT: this is not a clear cut case. The error is quite consistent on the system that I am running. However, running on a newer version of Docker does not seem to have the same result. It might be an artifact of this specific (and pretty useless, except for testing) setup.
EDIT2: Doesn't seem to have to do with Docker version after all, but with the number of cores that the host vm is assigned. 1 core -> no problem, 4 cores -> problem.

Hi,
some further info: this behaviour is reproducible on physical machines, so it seems it is not just a docker thing.
The company I work for is pretty invested in OrientDB, and we have a release coming up which will be the first where we have to support ODB in distributed mode. If you can confirm this as a bug, or otherwise, so we can make plans going forward, that would be awesome. Any workaround suggestion also welcome.

Hi @mxns, the problem could rely on the data in recordData variable. Does it contain also the class name? Can you try to remove it?

Hi @lvca thanks for looking into this. In the ´recordData´ is, in my test, just an empty json string, like this: ´{}´. I also tried removing it altogether, with the same result. The classname appears only in the Document constructor.

I cannot reproduce it with last 2.2.x. Could you please try with last snapshot (https://oss.sonatype.org/content/repositories/snapshots/com/orientechnologies/orientdb-community/2.2.12-SNAPSHOT/orientdb-community-2.2.12-20161012.150151-25.zip)?

I tested it with 2.2.11 with the same result. Testing with the zip file is a little bit more setup work to do, but sure I can try that too if there is any reason to think it might have changed since 2.2.11.
Sorry for being a nuisance, but can you confirm that you have multiple clusters  in your test? My database looks like this:
orientdb {db=test-db}> list clusters

CLUSTERS (collections)
+----+-----------+----+---------+-----------------+-----+------------------+--------------------+--------------------+
|#   |NAME       |  ID|CLASS    |CONFLICT-STRATEGY|COUNT|   OWNER_SERVER   |   OTHER_SERVERS    |AUTO_DEPLOY_NEW_NODE|
+----+-----------+----+---------+-----------------+-----+------------------+--------------------+--------------------+
|5   |event      |  17|event    |                 |   15|orientdb-lab-node2|[orientdb-lab-node1]|        true        |
|6   |event_1    |  18|event    |                 |   14|orientdb-lab-node1|[orientdb-lab-node2]|        true        |
|7   |event_2    |  19|event    |                 |   14|orientdb-lab-node1|[orientdb-lab-node2]|        true        |
|8   |event_3    |  20|event    |                 |   13|orientdb-lab-node2|[orientdb-lab-node1]|        true

CONFIGURED SERVERS
+----+------------------+------+-----------+-------------------+------------------+------------------+----------------+-----------------+---------+
|#   |Name              |Status|Connections|StartedOn          |Binary            |HTTP              |UsedMemory      |FreeMemory       |MaxMemory|
+----+------------------+------+-----------+-------------------+------------------+------------------+----------------+-----------------+---------+
|0   |orientdb-lab-node2|ONLINE|4          |2016-10-17 10:55:52|<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|98.09MB (11.17%)|41.41MB (4.71%)  |878.50MB |
|1   |orientdb-lab-node1|ONLINE|4          |2016-10-17 10:55:52|<IP_ADDRESS>:2424|<IP_ADDRESS>:2480|77.36MB (8.81%) |107.64MB (12.25%)|878.50MB |
+----+------------------+------+-----------+-------------------+------------------+------------------+----------------+-----------------+---------+

and the error message implies that node1 is trying to insert at cluster event_3, which it does not own:
com.orientechnologies.orient.server.distributed.ODistributedConfigurationChangedException: Local node 'orientdb-lab-node1' is not the owner for cluster 'event_3' (it is 'orientdb-lab-node2')

Resolved in 2.2.12, nice job @lvca!


chore: switch to true enable exact pod name match

A while back, this enableExactPodNameMatch was made for ACI when they first onboarded to SWIFT
ACI no longer uses kubernetes, so this is not relevant anymore

Won't do this since it would affect current partners, but there is a repair item assigned to TM that is to fix the logic of enableExactMatchPodName


fix append symbol input

fixed with https://github.com/porres/pd-cyclone/commit/3228a9c953cef38f77e206164acaea3acb3030a8


Doppio fails to start on Safari

On Safari, I get a stack trace that looks like this:
SyntaxError: Unexpected token '>'
eval
eval code
eval
(anonymous function)jvm.ts:518
evalNativeModulejvm.ts:569
(anonymous function)jvm.ts:641
(anonymous function)OverlayFS.ts:57
iutil.ts:149

cc @jvilk @hrj

That's odd. Looks like it doesn't like something we're producing during eval.
Will take a look when I have time, hopefully this weekend. Others can feel free to beat me to the punch.

I'm not getting that when I run the unit tester with test-browser, but test 15 seems to hang for no explicable reason.

I cannot reproduce this, Jim. I just ran all of the Safari unit tests w/o a WebWorker and it worked fine. Do you have custom native methods? Maybe you have a bug in them?

I dug a little deeper on this one and discovered the root cause.  I was wrong to blame doppio, sorry, closing.
Details: We were using ES6 in our native method implementation.  Firefox and chrome support ES6 natively, so it "just worked" and so we failed to realize that we weren't transforming our code before deploying.  The ES6 code failed to run in Safari, but the error pointed straight at doppio internals so I failed to notice that it was running user-land code.
Once again, sorry for the noise.

It's cool. Since we eval code, the stack traces often get destroyed, although I believe other browsers typically have more comprehensible stack traces!


Fix a bug in dirt_path.json

The old file causes a bug when the side touches a block, it will cull and make a 16*1 pixel gap.
I do fix it (but this break cull face, it will never cull).
Another choice is removing the extra box. I think a 16*1 pixel dirt texture is better than a 16*1 pixel gap or 16*1 pixel face never cull.

The intended behavior is having the texture go 1 px below the block, to imitate being seamlessly connected. Can you send a screenshot of the bug this PR fixes?


reviews

:white_check_mark: Build AElf <IP_ADDRESS>09 completed (commit https://github.com/AElfProject/AElf/commit/fb82f0d450 by @loning)


Roll Flutter Engine from b6f4f8dd4a56 to 73c9b8713114 (2 revisions)

https://github.com/flutter/engine/compare/b6f4f8dd4a56...73c9b8713114
2022-09-15<EMAIL_ADDRESS>Roll Skia from ce330bb13879 to 962fd1f9abfc (2 revisions) (flutter/engine#36170)
2022-09-15<EMAIL_ADDRESS>[web] Compile tests with sound null safety (flutter/engine#36169)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


tail crashes when our signal is delivered

Don't let the reporting thread start while in the constructor.

My testing was to scope apt-get update and scope apt install -y vim curl in one docker container that has this fix and compare it the same thing in another docker container that does not have this fix.
docker run --rm -it -v /home/ubuntu/jrc/appscope3/:/opt/appscope ubuntu:latest
My concern was that I wanted to ensure that we were able to get out a similar number of events and metrics before and after the fix.  These simple commands spawned hundreds of subprocesses (same number before and after) and had a very similar number of metrics and events.  I understand that there is still discussion in #728, but I think this is a good thing to add to AppScope v1.0.0 independent of the outcome of #728.
I'm going to merge this now before we generate a build for v1.0.0


empty test in strict mode fails for undefined map value

Hello!  Could be a bug, could be noob issue.
(version 3.1.0, strict mode on)
I've got a map in Context called p and I try to pull something out of p that doesn't exist (alt in this case):
{{ p.alt }}

The engine (correctly) complains, because I'm in strict mode.  So I changed the code to the following expecting it to work:
{% if p.alt is not empty %}{{ p.alt }}{% endif %}

However, the if cannot evaluate because it's choking on trying to eval p.alt (see stacktrace below).
Should this work?  If not is there an alternate way?
Thank you for your time and thank you for making pebble!
Caused by: com.mitchellbosecke.pebble.error.PebbleException: Wrong operand(s) type in conditional expression ({% if p.alt is not empty %}{{ p.alt }}{% endif %}:1)
	at com.mitchellbosecke.pebble.node.IfNode.render(IfNode.java:77)
	at com.mitchellbosecke.pebble.node.BodyNode.render(BodyNode.java:43)
	at com.mitchellbosecke.pebble.node.RootNode.render(RootNode.java:30)
	at com.mitchellbosecke.pebble.template.PebbleTemplateImpl.evaluate(PebbleTemplateImpl.java:155)
	at com.mitchellbosecke.pebble.template.PebbleTemplateImpl.evaluate(PebbleTemplateImpl.java:95)
	at com.dotdash.practive.pebble.PebbleMarkupRendererProvider$1.render(PebbleMarkupRendererProvider.java:62)
	at com.dotdash.practive.core.walkers.RenderPhaseComponentWalker.lambda$buildRenderStep$1(RenderPhaseComponentWalker.java:86)
	... 13 common frames omitted
Caused by: com.mitchellbosecke.pebble.error.AttributeNotFoundException: Attribute [alt] of [java.util.Collections$UnmodifiableMap] does not exist or can not be accessed and strict variables is set to true. ({% if p.alt is not empty %}{{ p.alt }}{% endif %}:1)
	at com.mitchellbosecke.pebble.attributes.MapResolver.resolve(MapResolver.java:44)
	at com.mitchellbosecke.pebble.attributes.DefaultAttributeResolver.resolve(DefaultAttributeResolver.java:37)
	at com.mitchellbosecke.pebble.node.expression.GetAttributeExpression.evaluate(GetAttributeExpression.java:82)
	at com.mitchellbosecke.pebble.node.expression.PositiveTestExpression.evaluate(PositiveTestExpression.java:60)
	at com.mitchellbosecke.pebble.node.expression.NegativeTestExpression.evaluate(NegativeTestExpression.java:18)
	at com.mitchellbosecke.pebble.node.IfNode.render(IfNode.java:52)
	... 19 common frames omitted

This isn't supported yet in strict mode. An improvement was made here with and/or operators
https://github.com/PebbleTemplates/pebble/issues/398.

Thanks @ebussieres, no luck with that, unfortunately; throws the same error as above.  Is this something that's intended to work?

Can you submit a test case for it ?

Can do.

As a workaround I tried to flatten my p map directly into the context, and then tried:
{% if alt is not empty %}{{ alt }}{% endif %}

and even this failed (same error).  I also tried null instead of empty and tried without the not.  This seems like base-level functionality, no?  Maybe no one uses strict mode?
Before I create a test case can you let me know the answer to

Is this something that's intended to work?
If the answer is no then I'm happy to help work on a fix, but if the answer is yes then I've gotta move on to another templating engine if there are no real alternatives to what I'm trying to do

I don't think that strict mode is really used and you're not the first to have this kind of request for this particular use case.
I think that a potential fix would be to not check strict variable if within a "if" node. I don't think that it would be feasible however.


be more parsimonious about adding project-wide ssh keys on google cloud

Seeing dozens of opam ssh keys added project-wide, causing us to hit the 32kb metadata limit

If someone knows how to keep control of the I'm all ears; gcloud just creates SSH keys on a need basis; Kubernetes (or the GKE's setup of Kubernetes) also creates random keys.
On AWS SSH-keys are always explicit/manual; and we see that they are needed in various places.


Switch onChange doesn't trigger

I'm see in docs inside SelectionControls an usage example of Switch with label, it's supposed to be used like:
<FormControlLabel
          control={
            <Switch
              checked={this.state.checkedA}
              onChange={(event, checked) => this.setState({ checkedA: checked })}
            />
          }
          label="A"
        />

But my state never changes. To fix it I did:
          <FormControlLabel
                    control={
                        <Switch
                            checked={this.state.enableCache}
                        />
                    }
                    label="Enable cache?"
                    onClick={() => this.setState({ enableCache: !this.state.enableCache })}
                />

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

When clicking it should change state

Current Behavior

State unchanged

Steps to Reproduce (for bugs)

Create a component with just a div
Add a initial state for that component with value true or false
Inside that div copy+paste this:

<FormControlLabel
          control={
            <Switch
              checked={this.state.checkedA}
              onChange={(event, checked) => this.setState({ checkedA: checked })}
            />
          }
          label="A"
        />

Your Environment

Tech
Version

Material-UI
1.0.0-beta.25

React
16.2.0

browser
Google Chrome

etc

This is the same pattern used in this demo: https://material-ui-next.com/demos/app-bar/#app-bar-with-menu. It's most likely a side effect on your side. Given no live reproduction example was provided, I'm closing the issue.

Same issue. Its from my CSS where I had:
height: auto!important;


fix(build): prevent package-lock.json from being committed by semantic-release

PR summary
This PR contains changes to prevent semantic-release from committing the package-lock.json file in the commit that updates the CHANGELOG.md file.  We want to avoid having a package-lock.json file because this is not a Node-based project and it is only created as the result of installing semantic-release and its associated plugins.
By avoiding the package-lock.json file, we should be able to avoid the vulnerability alerts that result from github's automatic scanning of package-lock.json files.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.18.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/26151

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/31541

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44346

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/49118

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/49403

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/54790

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/108680


chore: use latest Rock versions

Description
Use the newer Rock versions:
Bessd 1.0.1
PFCP agent 1.5.0

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[ ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

The upf-bess rock does not have the right version. I opened this PR on the rock to fix it: https://github.com/canonical/sdcore-upf-bess-rock/pull/36

Obsoleted by https://github.com/canonical/sdcore-upf-k8s-operator/pull/435


Storybook 8

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: [ABC-123]
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] This PR includes testing instructions tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.
PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.ca64cb.0@codecademy/gamut@57.3.4-alpha.ca64cb.0@codecademy/gamut-icons@9.32.1-alpha.ca64cb.0@codecademy/gamut-illustrations@0.48.2-alpha.ca64cb.0@codecademy/gamut-kit@0.6.448-alpha.ca64cb.0@codecademy/gamut-patterns@0.9.16-alpha.ca64cb.0@codecademy/gamut-styles@17.1.1-alpha.ca64cb.0@codecademy/gamut-tests@5.1.3-alpha.ca64cb.0@codecademy/macros@3.0.5-alpha.ca64cb.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.07f770.0@codecademy/gamut@57.3.4-alpha.07f770.0@codecademy/gamut-icons@9.32.1-alpha.07f770.0@codecademy/gamut-illustrations@0.48.2-alpha.07f770.0@codecademy/gamut-kit@0.6.448-alpha.07f770.0@codecademy/gamut-patterns@0.9.16-alpha.07f770.0@codecademy/gamut-styles@17.1.1-alpha.07f770.0@codecademy/gamut-tests@5.1.3-alpha.07f770.0@codecademy/macros@3.0.5-alpha.07f770.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.4fe51b.0@codecademy/gamut@57.3.4-alpha.4fe51b.0@codecademy/gamut-icons@9.32.1-alpha.4fe51b.0@codecademy/gamut-illustrations@0.48.2-alpha.4fe51b.0@codecademy/gamut-kit@0.6.448-alpha.4fe51b.0@codecademy/gamut-patterns@0.9.16-alpha.4fe51b.0@codecademy/gamut-styles@17.1.1-alpha.4fe51b.0@codecademy/gamut-tests@5.1.3-alpha.4fe51b.0@codecademy/macros@3.0.5-alpha.4fe51b.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.96b8fd.0@codecademy/gamut@57.4.2-alpha.96b8fd.0@codecademy/gamut-icons@9.32.1-alpha.96b8fd.0@codecademy/gamut-illustrations@0.48.2-alpha.96b8fd.0@codecademy/gamut-kit@0.6.450-alpha.96b8fd.0@codecademy/gamut-patterns@0.9.16-alpha.96b8fd.0@codecademy/gamut-styles@17.1.1-alpha.96b8fd.0@codecademy/gamut-tests@5.1.3-alpha.96b8fd.0@codecademy/macros@3.0.5-alpha.96b8fd.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.41a529.0@codecademy/gamut@57.4.2-alpha.41a529.0@codecademy/gamut-icons@9.32.1-alpha.41a529.0@codecademy/gamut-illustrations@0.48.2-alpha.41a529.0@codecademy/gamut-kit@0.6.450-alpha.41a529.0@codecademy/gamut-patterns@0.9.16-alpha.41a529.0@codecademy/gamut-styles@17.1.1-alpha.41a529.0@codecademy/gamut-tests@5.1.3-alpha.41a529.0@codecademy/macros@3.0.5-alpha.41a529.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.84e57e.0@codecademy/gamut@57.4.2-alpha.84e57e.0@codecademy/gamut-icons@9.32.1-alpha.84e57e.0@codecademy/gamut-illustrations@0.48.2-alpha.84e57e.0@codecademy/gamut-kit@0.6.450-alpha.84e57e.0@codecademy/gamut-patterns@0.9.16-alpha.84e57e.0@codecademy/gamut-styles@17.1.1-alpha.84e57e.0@codecademy/gamut-tests@5.1.3-alpha.84e57e.0@codecademy/macros@3.0.5-alpha.84e57e.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.c19dff.0@codecademy/gamut@57.4.2-alpha.c19dff.0@codecademy/gamut-icons@9.32.1-alpha.c19dff.0@codecademy/gamut-illustrations@0.48.2-alpha.c19dff.0@codecademy/gamut-kit@0.6.450-alpha.c19dff.0@codecademy/gamut-patterns@0.9.16-alpha.c19dff.0@codecademy/gamut-styles@17.1.1-alpha.c19dff.0@codecademy/gamut-tests@5.1.3-alpha.c19dff.0@codecademy/macros@3.0.5-alpha.c19dff.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.b3a29a.0@codecademy/gamut@57.4.2-alpha.b3a29a.0@codecademy/gamut-icons@9.32.1-alpha.b3a29a.0@codecademy/gamut-illustrations@0.48.2-alpha.b3a29a.0@codecademy/gamut-kit@0.6.450-alpha.b3a29a.0@codecademy/gamut-patterns@0.9.16-alpha.b3a29a.0@codecademy/gamut-styles@17.1.1-alpha.b3a29a.0@codecademy/gamut-tests@5.1.3-alpha.b3a29a.0@codecademy/macros@3.0.5-alpha.b3a29a.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.bc8c54.0@codecademy/gamut@57.4.2-alpha.bc8c54.0@codecademy/gamut-icons@9.32.1-alpha.bc8c54.0@codecademy/gamut-illustrations@0.48.2-alpha.bc8c54.0@codecademy/gamut-kit@0.6.450-alpha.bc8c54.0@codecademy/gamut-patterns@0.9.16-alpha.bc8c54.0@codecademy/gamut-styles@17.1.1-alpha.bc8c54.0@codecademy/gamut-tests@5.1.3-alpha.bc8c54.0@codecademy/macros@3.0.5-alpha.bc8c54.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.0483fd.0@codecademy/gamut@57.4.2-alpha.0483fd.0@codecademy/gamut-icons@9.32.1-alpha.0483fd.0@codecademy/gamut-illustrations@0.48.2-alpha.0483fd.0@codecademy/gamut-kit@0.6.450-alpha.0483fd.0@codecademy/gamut-patterns@0.9.16-alpha.0483fd.0@codecademy/gamut-styles@17.1.1-alpha.0483fd.0@codecademy/gamut-tests@5.1.3-alpha.0483fd.0@codecademy/macros@3.0.5-alpha.0483fd.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.17a12a.0@codecademy/gamut@57.4.4-alpha.17a12a.0@codecademy/gamut-icons@9.32.1-alpha.17a12a.0@codecademy/gamut-illustrations@0.49.1-alpha.17a12a.0@codecademy/gamut-kit@0.6.452-alpha.17a12a.0@codecademy/gamut-patterns@0.9.16-alpha.17a12a.0@codecademy/gamut-styles@17.1.1-alpha.17a12a.0@codecademy/gamut-tests@5.1.3-alpha.17a12a.0@codecademy/macros@3.0.5-alpha.17a12a.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.f7ecde.0@codecademy/gamut@57.4.5-alpha.f7ecde.0@codecademy/gamut-icons@9.32.2-alpha.f7ecde.0@codecademy/gamut-illustrations@0.49.2-alpha.f7ecde.0@codecademy/gamut-kit@0.6.453-alpha.f7ecde.0@codecademy/gamut-patterns@0.9.17-alpha.f7ecde.0@codecademy/gamut-styles@17.1.2-alpha.f7ecde.0@codecademy/gamut-tests@5.1.4-alpha.f7ecde.0@codecademy/macros@3.0.5-alpha.f7ecde.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.e17690.0@codecademy/gamut@57.4.5-alpha.e17690.0@codecademy/gamut-icons@9.32.2-alpha.e17690.0@codecademy/gamut-illustrations@0.49.2-alpha.e17690.0@codecademy/gamut-kit@0.6.453-alpha.e17690.0@codecademy/gamut-patterns@0.9.17-alpha.e17690.0@codecademy/gamut-styles@17.1.2-alpha.e17690.0@codecademy/gamut-tests@5.1.4-alpha.e17690.0@codecademy/macros@3.0.5-alpha.e17690.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.c3121d.0@codecademy/gamut@57.5.3-alpha.c3121d.0@codecademy/gamut-icons@9.34.2-alpha.c3121d.0@codecademy/gamut-illustrations@0.49.3-alpha.c3121d.0@codecademy/gamut-kit@0.6.456-alpha.c3121d.0@codecademy/gamut-patterns@0.9.18-alpha.c3121d.0@codecademy/gamut-styles@17.1.3-alpha.c3121d.0@codecademy/gamut-tests@5.1.5-alpha.c3121d.0@codecademy/macros@3.0.5-alpha.c3121d.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://67576944be27292aa883b195--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.3e3f48.0@codecademy/gamut@57.5.3-alpha.3e3f48.0@codecademy/gamut-icons@9.34.2-alpha.3e3f48.0@codecademy/gamut-illustrations@0.49.3-alpha.3e3f48.0@codecademy/gamut-kit@0.6.456-alpha.3e3f48.0@codecademy/gamut-patterns@0.9.18-alpha.3e3f48.0@codecademy/gamut-styles@17.1.3-alpha.3e3f48.0@codecademy/gamut-tests@5.1.5-alpha.3e3f48.0@codecademy/macros@3.0.5-alpha.3e3f48.0@codecademy/styleguide@68.1.4-alpha.3e3f48.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6759bc93f0100a0a33237df9--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.44e7b7.0@codecademy/gamut@57.5.3-alpha.44e7b7.0@codecademy/gamut-icons@9.34.2-alpha.44e7b7.0@codecademy/gamut-illustrations@0.49.3-alpha.44e7b7.0@codecademy/gamut-kit@0.6.456-alpha.44e7b7.0@codecademy/gamut-patterns@0.9.18-alpha.44e7b7.0@codecademy/gamut-styles@17.1.3-alpha.44e7b7.0@codecademy/gamut-tests@5.1.5-alpha.44e7b7.0@codecademy/macros@3.0.5-alpha.44e7b7.0@codecademy/styleguide@68.1.4-alpha.44e7b7.0<EMAIL_ADDRESS>
📬Published Alpha Packages:eslint-plugin-gamut@2.2.1-alpha.db3d4f.0@codecademy/gamut@57.5.3-alpha.db3d4f.0@codecademy/gamut-icons@9.34.2-alpha.db3d4f.0@codecademy/gamut-illustrations@0.49.3-alpha.db3d4f.0@codecademy/gamut-kit@0.6.456-alpha.db3d4f.0@codecademy/gamut-patterns@0.9.18-alpha.db3d4f.0@codecademy/gamut-styles@17.1.3-alpha.db3d4f.0@codecademy/gamut-tests@5.1.5-alpha.db3d4f.0@codecademy/macros@3.0.5-alpha.db3d4f.0@codecademy/styleguide@68.1.4-alpha.db3d4f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://675c47d628119a0a787714ef--gamut-preview.netlify.appDeploy Logs


Duplicate rows after ActiveRecord::link execution

Problem explained at the title. If I link two models multiple times I have duplicated rows on the DB. How can I fix that?

Why do you link it multiple times?

Why not? It is possible that user will create that many-many relation. I think that in the system must be validations/checks for that

Maybe can I fix that and do pull request?

How did you declare your table? normally there should be a duplicate primary key error be thrown in this case...

Yeap, it throws an exception. But how to ignore that exception and redirect (for example) back to previous page?

If I link two models multiple times I have duplicated rows on the DB

This does not sound like an exception ;)
You can use try {} catch {} http://php.net/manual/en/language.exceptions.php


Feat improved testcase readability

Created assertion data object such that we do not have to rely on logs to file anymore
Used the context builder to create better variable names
Repair assertions
Replace try catch for exceptions by proper "rejectedWith" function from chai

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 46.885%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/analysis-javascript/lib/type/discovery/element/ElementVisitor.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

libraries/analysis-javascript/lib/type/discovery/element/ElementVisitor.ts
1
73.26%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1504

Relevant Lines:
2963

💛  - Coveralls


Fix image icon links in index.md

Signed-off-by: VInayak<EMAIL_ADDRESS>
NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:
https://github.com/Kong/docs.konghq.com/blob/master/CONTRIBUTING.md
Summary
SUMMARY_GOES_HERE
Full changelog

[Edited docs to ...]
[Added cool new feature ...]
...

Issues resolved
Fix #XXX

Checklist:

[x] Commit message & atomicity checked
[ ] Documentation
[x] Spellchecked my updates
[ ] Ready to be merged

I'm not clear what problem this solves - the page https://docs.konghq.com/0.9.x/ currently doesn't look broken. Please clarify what problem you are solving (screen shots and URLs are encouraged!)

@coopr When I open the following URL: https://github.com/Kong/docs.konghq.com/blob/master/app/0.9.x/index.md

The above icons are not rendered properly, that's why the fix, which renders them as they are.

@coopr When I open the following URL: https://github.com/Kong/docs.konghq.com/blob/master/app/0.9.x/index.md
The above icons are not rendered properly, that's why the fix, which renders them as they are.

Ah ok - well, that page isn't supposed to correctly render the icons - that page is the source code of a static site that is generated and served. That source page results in https://docs.konghq.com/0.9.x/ which does have the icons correctly rendered.
I'm going to close this issue now as I think this may be the result of some misunderstanding about how this repo/code/website works.


Update local build instructions

Update docfx build instructions based on https://github.com/dotnet/core-docs/issues/849#issuecomment-237763927.
cc: @chenkennt @mairaw

LGTM. Building like this works for you then @svick?

@mairaw Yes, it does.

Thanks @svick. LGTM. I could finally tested this.


Create server client shared structure_family class and pydantic server-only structures

This PR will try to solve inconsistencies that are raised by FastAPI and pydantic when using strucure classes that are dependent of the dataclasses.dataclass package while trying to solve the new write feature on the server side

I hope we can find a solution to the underlying issue in pydantic, and perhaps submit a patch upstream to them, but this is a good workaround to unblock us in the meantime.

This is a good description of the underlying pydantic issue we hit with ArrayStrucutre. https://github.com/samuelcolvin/pydantic/issues/3251
I think the issue with DataFrameStructure is unrelated and could be addressed without changes to pydantic.

This is a good description of the underlying pydantic issue we hit with ArrayStrucutre. https://github.com/samuelcolvin/pydantic/issues/3251
I think the issue with DataFrameStructure is unrelated and could be addressed without changes to pydantic.

This is a good description of the underlying pydantic issue we hit with ArrayStrucutre. https://github.com/samuelcolvin/pydantic/issues/3251
I think the issue with DataFrameStructure is unrelated and could be addressed without changes to pydantic.


Adapt built-in port_env to support OS X Mavericks or newer

Someone with access to OS X Mavericks or newer should adapt the built-in port_env.
cc @jaredmorrow @Vagabond @dizzyd

Fixed in #590


Add support for rack id

Allow to provide rack id for kpro_req_lib:fetch/9 function

Hi @ditas
Thank you for the PR.
I'm not quite familiar with the rack_id feature from Kafka.
Does it imply that you can fetch from any broker in the cluster?
If that's the case, it might not be very useful here because brod_consumer always fetches from the partition leader.

fetch/8 should call fetch/9 (with ?undef as the last arg).


change ExecutorManager to ExecutorManagerAdapter in Flow Trigger

Given ExecutorManager is no longer used in new dispatch logic(https://github.com/azkaban/azkaban/pull/2067), replace it with ExecutorManagerAdapter  in flow trigger-related code.

Pull Request Test Coverage Report for Build 4449

0 of 0   changed or added relevant lines in 0 files are covered.
21 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 37.058%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackRequestMaker.java
21
56.25%

Totals

Change from base Build 4446:
-0.05%

Covered Lines:
10977

Relevant Lines:
29621

💛  - Coveralls


canDeactivate not working with back button

I have a canDeactivate installed on the router, and it works nicely to provide confirmation of leaving the route when navigating using router.navigate(), e.g. when the user clicks on my navigation bar.
However, it does not get called when the user clicks on the browser back button.
Is this an omission?

It won't get called, unless you set forceDeactivate: false in browserPlugin. I've updated the docs as I realised it wasn't documented (http://router5.github.io/docs/history.html).
I don't recommend not forcing deactivation on popstate events: you can't prevent those events, and the history will change anyway, causing synchronisation issues between browser and your application. The browser plugin tries its best to make it work, but it's far far from ideal, and you'll expose yourself to a class of issues.

I tried it, and saw some of the problems you refer to.  So I decided not to use it after all.  ;-)
Thanks for your help.


Raising custom error messages

Basic Info

rails_param Version: 0.10.1
Ruby Version: 2.5.1
Rails Version: 5.2.0

Issue description
Big fan of this gem, reduces a lot of dev effort in validating parameters. One small thing I found out though: custom messages with message option does not work, it still throws up parameter XXX is required
Steps to reproduce
Taking the example in readme, if you do
param! :q, String, required: true, message: "Query not specified"
it still throws up: Parameter q is required instead of Query not specified

Hi @akartik80, thanks for using rails_param and for raising this!
Indeed that functionality was added in the 0.10.1 release so I'll raise this as a bug and look into it as soon as possible.

@akartik80 Please see my update comment above

I see it fixed in https://github.com/nicolasblanco/rails_param/pull/42/files with 0.10.2


Need Export Plugin For Chartjs Graphs in PDF, XLSX, DOC format

I am looking for a plugin which can export my graph data into pdf, xlsx, doc etc format in order to showcase to clients or partners to get more direct insights. There are plugin or api's available for Highcharts, Amcharts, but i can't find anything for ChartJS library. Please help. Urgent !

The only thing we currently support is generating PNG images of the graph.

This is something that should be done on the client side. You can use the data you enter or explore chart objects to see what data they contain and use that to create your export data.

@zachpanz88's answer is correct


Possible to restart or start with new configuration

Description

It should be possible to restart or start bugsnag again with new configuration if any changes.
Describe the solution you'd like

BugSnag.start(configs). It should be always possible.
Describe alternatives you've considered

Additional context

Hi @thuongtv-vn,
Thanks for the suggestion. could you explain a little more about your use case, what would you expect to change?

I'm interested in this as well, following. My use case is when we intentionally change the release stage within the same application, and we want to reload bugsnag (or stop and start it again). AFAICT there is no way to do this in the current javascript API and it sounds like calling start() again won't actually reload it?

Hi @jcstringer, can you explain your workflow in a little more detail.  How do you determine when you need to intentionally change the release stage? Any additional information you can share around your project setup and technologies used would also be helpful.

Hi @jcstringer, I can see that you’ve opened a support request with this question. We can continue this conversation via that ticket

@thuongtv-vn, have you seen the above message? It would be good to understand your use case.

@thuongtv-vn Going to close this out as we would need some additional context to understand the reasons for considering a change like this. Happy to reopen if you can provide this.
At present we do offer the ability to add metadata that you could use  if you need to track specific information or changes that occur.


Support for Contacts

BUSINESS PROBLEM
Our internal rules for TPP require us to use Contacts property while requesting a certificate.
Would it be possible to add Contacts parameter to the venafi_certificate Ansible module and use it in /vedsdk/Certificates/Request endpoint?
CURRENT ALTERNATIVES
None

Hi,
Thanks for your support.
I'm referring to Contacts property we may set through /vedsdk/Certificates/Request POST call.
Unfortunately, in our case we cannot use the one assigned to the policy, since we have one policy and certificates are requested by different teams. Each team is responsible for their own certificates life cycle and, therefore, we need contact persons be assigned to the certificates directly.

Thank you for explaining more about your use case @klewan.  One of the objectives we have for our open source integrations is to help make it easy for customers follow the best practices for our products.  As @rvelaVenafi said, the best practice for TPP is to assign contacts (and permissions) for certificates by policy such that any certificate under the folder has the same "owners".  So the way we intended to support your use case is by extending our Certificate Policy Management feature to allow owners to be specified as part of the policy specification and we'll do so in such a way that owners are specified by user/group name instead of by unfriendly UUIDs.
When we designed our Certificate Policy Management feature we also understood the challenge you described with creating folders for each team in order to follow our best practices.  The good news is that you can still have your user's certificates in a single parent folder because our Certificate Policy Management feature will automatically create any missing folder structure in the zone you specify.  Each team will get their own folder containing the certificates that they own and once we've implemented the enhancement to assign owners by policy those will be set on their folder.


Section numbering gets wrong when sections have the same titles

When there are two sections with the same title, the number for the first one is the same as the one for the second section.
Example markdown cell:
# Title
## Normal
## Duplicated
## Duplicated

The output is:
1. Title
1.1 Normal
1.3 Duplicated
1.3 Duplicated

Note that there is no 1.2 section. Instead, there are two 1.3 sections.
Environment info:

OS: Mac
Python version: 3.6.4
Sphinx version: 1.8.2
nbsphinx 0.3.5

This bug doesn't happen when you create a test .rst file, so it must be something wrong with nbsphinx, not sphinx.

Thanks for the report!
Can you please provide a minimal example project?

@mgeier do you mean sth like that?

Yes, exactly. Plus a minimal Sphinx configuration (conf.py). Plus a description how you ran Sphinx to get your output.
In short, a simple way for me to reproduce your problem.

Thanks, I can reproduce it now!
I assume this is because of this custom nbsphinx transform:
https://github.com/spatialaudio/nbsphinx/blob/345f406e6f98d584fa493c788099e68b218f3a30/src/nbsphinx.py#L1333-L1347
This is needed because otherwise the section anchors in the HTML output wouldn't match the anchors in the Jupyter notebook application.
However, this seems to have this weird effect on section numbering ...
I'll have to look into this.

PR #270 should fix this, but I'm not yet satisfied with the details of it ...


Using on MacOS

Hello,
thanks for building this!
I was wondering if I could compile this in a catkin ws on my linux laptop and then copy the whole catkin ws into the flutter project I'm developing on MacOS. Would that work or would you recommend to develop the ROS flutter app in linux?

That should work. There is nothing in the dart stuff that is Linux specific. Of course building the messages using gendart would be best to do on Linux. You shouldn't need the whole catkin workspace. Just copy synchronize the message packages you need from where they end up in the devel

Cool! And if I understand correctly, this pipeline would be needed for custom messages, but if I only want to pub/sub to any of:

std_msgs
sensor_msgs
rosgraph_msgs
geometry_msgs
actionlib_msgs
then I can just do: dart pub add <msg_pkg>

Yes


[rewrite] onupdate not being called in 1.0.0-rc.6 (works in 1.0.0-rc.5)

Description
1.0.0-rc.5 version - http://jsbin.com/deciyih/9/edit?js,output
1.0.0-rc.6 version - http://jsbin.com/jeharo/3/edit?js,output
Clicking "Increment Counter from Portal" button should call onupdate for the "Portal" component but doesn't in 1.0.0-rc.6 version. Works as expected in 1.0.0-rc.5.

Also failing in current rewrite, haven't dug into why though yet.
https://jsbin.com/yakezoj/1/edit?html,js,output

yeah, adding m.redraw() in the view at Portal make it work heh. Please fix this

Actually looking at this closer I'm a little surprised that clicking that button ever hooked into the auto-redraw system. I don't really think manually-created DOM nodes filled out using m.render should hook into the auto-redraw.
Curious why you're rendering this way instead of making the Portal look something more like this:
https://jsbin.com/foceciharo/1/edit?js,output

I need the vnode.children to be rendered into the 'Portal' div (as opposed to inline) to avoid CSS z-index and overflow issues.
Here's an example to illustrate what I mean:
https://jsbin.com/nififes/10/edit?css,js,output
And here's another with the children being rendered into the 'Portal' div:
https://jsbin.com/xecane/edit?css,js,output

Oh, I see why it stopped working. There was a bug previously that tied m.render to the same redrawService that m.mount/m.route would use.
@lhorie fixed it in this commit by breaking that coupling that shouldn't have existed in the first place.
If you want to continue using them together this way I recommend either adding m.redraw to your code where appropriate or maybe putting the component outside of the parent element if the styling requires that it live outside of it in the DOM.

@lhorie @tivac maybe we could expose the currently private render from api/redraw.js  as m.redraw.render?


Fix SyntaxWarning in test over literal comparison.

The test generates a SyntaxWarning in Python 3.8 over using is to compare literals.
python -Wall tests/test_basic.py
tests/test_basic.py:51: SyntaxWarning: "is" with a literal. Did you mean "=="?
  assert rv is 42

Thank you for the contribution!

Thanks @jab :)


Feature/downtime warning banner

Dismissible like the cookie banner
Only shows up to fixed time (10am 1st August 2020)
Danger alert colour

Can this be downtimeBannerDismissed? :P @bh412

Yes!


Update TextraTypist to latest commit; prepare for next release.

There's a few things this does. First, it makes sure emoji are added to all fonts in the font family, instead of just the main/first one. Next, it updates several .fnt files and the dependency on TextraTypist to a JitPack commit. Lastly, to ensure it actually pulls the right commit and not an old version, it does some Gradle exclusion on Stripe's color-picker. The exclusion probably isn't needed for release versions of TextraTypist, but it is needed for commits.

I might discontinue using TextTooltip entirely and opt for my PopTooltip if it proves to be a problem. This is a great PR! Thanks for this.

I think the tooltip stuff is old, and might still be in this PR because it was in my last one. I tried to direct this to the dev branch, but I might have been out-of-date... A lot more files changed than I thought I had edited.

Apparently that method is used everywhere and the refactor meant a lot of changes. It seemed fine to me though.


Property 'ArrowRuleSet' is misspelled or does not exist.

When I followed the readme to try to enable this plugin, I got this error:

Property 'ArrowRuleSet' is misspelled or does not exist.

The following content is added to my detekt configuration file (detekt-config-overrides.yml):
ArrowRuleSet:
     NoEffectScopeBindableValueAsStatement:
           active: true

ArrowRuleSet a top most option (without any space ahead). The configuration file is used like this:

detekt {
    toolVersion = detektVersion
    autoCorrect = true
    buildUponDefaultConfig = true
    config.from("$rootDir/gradle/detekt-config-overrides.yml")
}

Hey @ffcactus! I tried to reproduce it with the same config here and it didn't reproduce :(
Was the plugin added as detektPlugins("com.wolt.arrow.detekt:rules:*VERSION*")?
Feel free to adjust the said repo if something is missing to reproduce the issue

Closing for now, feel free to reopen/update the repo with example


GIProbe based GI is wrong for intersecting or overlapping geometry

Godot version:
Godot master (#25670)
OS/device including version:
Windows 10
Issue description:
Voxel based GI (with GIProbe) is not computed correctly for intersecting or overlapping geometry.

Minimal reproduction project:
test0 - Kopie.zip

A workaround may be to precompute the geometry (which is not self-intersecting) either at runtime (after the other bug is fixed in master) or in an external tool (Blender, Maya, Cinema 3d, etc)

In 3.2.3 rc3 the project looks like on the screenshot, so it's probably still valid.
The project doesn't work properly in 4.0, but it's likely the issue is fixed there.


Make Lockouts Per-User

Add option to make bans tied to user rather than IP

If you want this please feel free to elaborate a PR. I'll be happy to review.


 Another test should be added to this file to check if the user has changed the value of hello or not.
Bug report source
https://forum.freecodecamp.org/t/remove-whitespace-from-start-and-end-challenge-bug/480586

I would like to work on this issue!

Hey @Nirajn2311 ,
If you allow me then i contribute this issue?

@ieahleen
Thanks!


Wallet fingerprints are different after importing

Wallets do not have fingerprints. So, removed fingerprint from wallet settings.

As per discussion fingerprints are only in keys, they do not exist for wallets and vaults. CC @Raheel1258

Completed


Implement zip_all which does the same as zip without truncating

https://github.com/lstrojny/functional-php/issues/108

I've done something about all your feedback I'm not sure if there are any test cases which would be useful.

Looks good, thank you!


Suggestion: GuessModule middleware

Our project uses Caffeinated/Modules with Laravel Spark. Spark has it's own routes set up that are difficult to modify without overriding/replacing classes etc.
In our case each module defines a subdomain where some (all, no) aspects of Spark will be available in certain subdomains. Or rather, the UI of how to get there is hidden/different per subdomain.
To solve this I made the middleware GuessModule that attempts to guess the module based on the first part of the hosts' domain. It can be added to the web middleware so that all routes use it, but if the IdentifyModule middleware also exists on a route then the session value will be explicitly overridden.
This is more a concept I thought would be good to share and any feedback welcome. This could be extended to also look at the first part of a path if that's how the modules are accessed, perhaps controllable from settings? Thoughts?
<?php

namespace App\Http\Middleware;

use Caffeinated\Modules\Modules;
use Closure;

class GuessModule
{
    /**
     * @var Caffeinated\Modules
     */
    protected $modules;

    /**
     * Create a new GuessModule instance.
     *
     * @param Caffeinated\Modules $module
     */
    public function __construct(Modules $modules)
    {
        $this->modules = $modules;
    }

    /**
     *  Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if ($request->session()->has('module')) {
            return $next($request);
        }

        $module = $this->modules->where('slug', explode(".", $request->server()['HTTP_HOST'], 2)[0]);
        if ($module) {
            $request->session()->flash('module', $module);
        }
        return $next($request);
    }
}

Interesting. Can't say that I would add this to the package itself, but I do see its use case.
I would say that the IdentifyModule middleware could check if the session already has a module key is set and continue to the next request (like you have in your GuessModule middleware). That way you could use your middleware as long as its fired beforehand~

Agreed, more I think of it I don't think this is something to add to the project as it is quite a specific use case. I'll do a gist instead in case anyone has a similar use case. Feel free to close the issue.
Regarding tweaking IdentifyModule... it's not necessary. If GuessModule runs first it populates the session with a possible result, the  IdentifyModule Middleware overrides that guess. If it happens to execute the other way the guess shouldn't override the explicit IdentifyModule middleware. So no changes to your code needed :)

Ah, right, good catch!


vkCmdBindDescriptorSets Must have a dynamic offset

https://github.com/SaschaWillems/Vulkan/blob/master/examples/indirectdraw/indirectdraw.cpp
After looking at your Indirect Draw example project I fond a issue when running it. You declare vkCmdBindDescriptorSets without a dynamic offset which according to the specification is valid, but when the program starts it crashes on that line.
vkCmdBindDescriptorSets(drawCmdBuffers[i], VK_PIPELINE_BIND_POINT_GRAPHICS, pipelineLayout, 0, 1, &descriptorSet, 0, NULL);
There is a way to get the project running, by having the dynamic offset count to 0 and then pointing to a single uint32_t set to 0 for the dynamic offset, but the strange thing is for every draw call it uses that dynamic offset even though we set the count to 0.

That sample runs fine for me (without any validation layer messages) on about half a dozen devices with three different operating systems.
Can you add some info on the device, driver and OS this fails on. Passing nullptr for the dynamic offset is valid and I haven't seen a single implementation fail on that.

OS: Windows 10
CPU: AMD FX 8350 Eight Core
Ram: 64GB DDR3
GPU: GTX 770

Running fine for me on Win10 with a GT 980 and on Android with a Shield TV.
If you don't get any validation errors, this might be a driver and/or gpu combo related bug that you might want to forward to the IHV.
If a perfectly valid sample crashes on a certain device or driver, I don't actually want to add a workaround to one example just because of that.

I will make sure my drivers are up to date and try running it again at a later date.

Any news on this?


Not able to pull image

Team, I'm trying to install redpanda-console helm chart on the Minikube. I've followed this: https://github.com/redpanda-data/helm-charts/tree/main/charts/console
After deploying the helm chart, getting this error:
Failed to load logs: container "console" in pod "red-test-console-858d64b4cb-fnxp9" is waiting to start: trying and failing to pull image
Reason: BadRequest (400)

values.yaml
affinity: {}
annotations: {}
autoscaling:
  enabled: false
  maxReplicas: 100
  minReplicas: 1
  targetCPUUtilizationPercentage: 80
configmap:
  create: true
console:
  config:
    kafka:
      brokers:
      - xyz:9092
      clientId: redpanda-console
      sasl:
        enabled: true
        mechanism: PLAIN
        username: xyz
      tls:
        enabled: true
deployment:
  create: true
extraContainers: []
extraEnv: []
extraEnvFrom: []
extraVolumeMounts: []
extraVolumes: []
fullnameOverride: ""
image:
  pullPolicy: IfNotPresent
  registry: docker.redpanda.com
  repository: redpandadata/console
  tag: ""
imagePullSecrets: []
ingress:
  annotations: {}
  className: ""
  enabled: false
  hosts:
  - host: chart-example.local
    paths:
    - path: /
      pathType: ImplementationSpecific
  tls: []
livenessProbe:
  failureThreshold: 3
  initialDelaySeconds: 0
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 1
nameOverride: ""
nodeSelector: {}
podAnnotations: {}
podLabels: {}
podSecurityContext:
  fsGroup: 99
  runAsUser: 99
priorityClassName: ""
readinessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 1
replicaCount: 1
resources: {}
secret:
  create: true
  enterprise: {}
  kafka:
    saslPassword: xyz
  login:
    github: {}
    google: {}
    jwtSecret: ""
    oidc: {}
    okta: {}
  redpanda:
    adminApi: {}
secretMounts: []
securityContext:
  runAsNonRoot: true
service:
  annotations: {}
  port: 8080
  targetPort: null
  type: ClusterIP
serviceAccount:
  annotations: {}
  create: true
  name: ""
tolerations: []
topologySpreadConstraints: {}

As discussed in slack, this is being blocked by the user's proxy. This documentation for minikube should help: https://minikube.sigs.k8s.io/docs/handbook/vpn_and_proxy/

Looks like this is solved. Closing.


Add missing default I2C Mode to the SSD130x driver

This is a minor regression introduced in #341.  Just adding the missing default I2C Mode where it is now expected.

Good catch. Thanks for the PR!

misclicked the button 😨 ignore the "close"


As a user, I want to see syntax highlighting when writing code for better experience.

The boostnote Android Play Store page show in it's preview images that it has syntax highlighting for code written in the markdown.

Hi @anshulc95 ,
Thanks for your opening issue!
I think so too.
I will create the feature, also PRs are welcome!

@kazup01 cancelled funding, $40, of this issue. Visit this issue on Issuehunt


Are micro-frameworks in PHP still useful?

Title
Are micro-frameworks in PHP still useful?
Brief
Write an opinionated article on the state of micro-frameworks in the PHP space. Do we still need them? Should we use them more? Be honest, brutal, and opinionated.

definitely interested in this, but happy to allow others to claim if someone else wants it.


Certificate Handling broken - Godaddy G2 cert

The zulip iOS client will not log into tulip server using fully signed cert. I have a zulip instance where the hostname zulip.company.com has a GoDaddy cert that matches the hostname, DNS name and reverse lookup name zulip.company.com. When I attempt to connect it never gets past the passing cert stage, I did a packet capture of my iPhone using the rvictl tool but github won't let me attach a pcap, everything looks fine then it just stops and get the "Uh oh, Something happened we didn't expect message" I am stumped what is stopping it from proceeding.

Are you serving the intermediate certificate chain, too?

It looks like it goes and hit’s godaddy for it. I also tried installing the intermediate in profiles on the iPhone. Is there something I should do to munge those certs together. It does not give a cert error in a browser.
Bill

On Oct 9, 2015, at 1:06 PM, Luke Faraone<EMAIL_ADDRESS>wrote:
Are you serving the intermediate certificate chain, too?
—
Reply to this email directly or view it on GitHub https://github.com/zulip/zulip-ios/issues/6#issuecomment-146950070.

I used the gd_bundle-g2-g1.crt from GoDaddy so that should have the whole chain I would think.
Bill

On Oct 9, 2015, at 1:06 PM, Luke Faraone<EMAIL_ADDRESS>wrote:
Are you serving the intermediate certificate chain, too?
—
Reply to this email directly or view it on GitHub https://github.com/zulip/zulip-ios/issues/6#issuecomment-146950070.

Can you verify the chain is being sent? See for example:
https://www.ssllabs.com/ssltest/analyze.html?d=zulip.com&s=<IP_ADDRESS>&latest
"Certification Paths" should go up to something in the trust store.
Checking in the browser isn't in-and-of-itself a great test, because browsers often cache intermediate certs.

Got it to work, had to tinker with the cert and nginx to add all the intermediaries.  Interestingly just combining what is in the go-daddy repository as the intermediary with the cert is not sufficient.
Thanks,
Bill

On Oct 9, 2015, at 3:55 PM, Luke Faraone<EMAIL_ADDRESS>wrote:
Can you verify the chain is being sent? See for example:
https://www.ssllabs.com/ssltest/analyze.html?d=zulip.com&s=<IP_ADDRESS>&latest https://www.ssllabs.com/ssltest/analyze.html?d=zulip.com&s=<IP_ADDRESS>&latest
"Certification Paths" should go up to something in the trust store.
Checking in the browser isn't in-and-of-itself a great test, because browsers often cache intermediate certs.
—
Reply to this email directly or view it on GitHub https://github.com/zulip/zulip-ios/issues/6#issuecomment-146984014.


Exec tachikoma update<PHONE_NUMBER>4708

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 67.647% when pulling 70edb8b2421bc1c92dc0cfc3286eb5d086d2b07b on pazjacket:tachikoma/update-20180619214708 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.

Coverage remained the same at 67.647% when pulling 70edb8b2421bc1c92dc0cfc3286eb5d086d2b07b on pazjacket:tachikoma/update-20180619214708 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.


Update dhall-generic to 0.3.15

Updates us.oyanglul:dhall-generic from 0.2.0 to 0.3.15.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "us.oyanglul", artifactId = "dhall-generic" } ]

labels: library-update, semver-minor

Superseded by #62.


Updated API policy images

This PR is raised to update the API policy page with latest images.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cannot read property 'freezeResults' of null

I used the Vue CLI (v3.2.1) to create a new project; I added Apollo with vue add apollo(tried v3.0.0-beta.30, v3.0.0-beta.11, and a few others) and I started my dev server:
Cannot read property 'freezeResults' of null

Same started to happend with me after I upgraded. I now have the following versions, and cannot load my application anymore:
"vue-cli-plugin-apollo": "^0.20.0",
"vue-apollo": "^3.0.0-beta.30",

It worked back when I overrode the default cache with:
import { InMemoryCache } from 'apollo-cache-inmemory';

const defaultOptions = {
  // ...
  // Override default cache
  cache: new InMemoryCache(),
}

Not sure if this is the right solution, though.

I created a new project and upgraded to the last vue-apollo version, the problem still exists.

I was also able to get it to work with cache: new InMemoryCache({ freezeResults: false }).

It seems you don't need to add any options in new InMemoryCache() as freezeResults is default to false when you create it. (see https://github.com/apollographql/apollo-client/blob/master/packages/apollo-cache-inmemory/src/inMemoryCache.ts)

I was also able to get it to work with cache: new InMemoryCache({ freezeResults: false }).

can you be more specific as for where to enter this code in my project?

@liornoy Check out https://bitbucket.org/briansw/hu-tech-challenge-vue/src/master/src/vue-apollo.js and specifically, line 42. This is the Apollo config – you can get this scaffolding set up in your Vue app by running vue add apollo.

Thanks for the link, it solved it for me.
Adding "cache: new InMemoryCache({ freezeResults: false })" wasn't enough,
I just copy-paste the whole vue-apollo.js and changed:
const httpEndpoint =
process.env.VUE_APP_GRAPHQL_HTTP || 'http://localhost:4002/graphql'
from 4002 to 4000.

I came upon this thread while trying to solve problems with a sample hasura application, vuejs-auth0-graphql at  https://github.com/hasura/graphql-engine/tree/master/community/sample-apps/vuejs-auth0-graphql/app .  In Firefox the error was "TypeError: config is null".  In Chrome it was "Cannot read property 'freezeResults' of null".
After adding import { InMemoryCache } from 'apollo-cache-inmemory'; and cache: new InMemoryCache(), to vue-apollo.js, I get a new error:

GraphQL error: Missing Authorization header in JWT authentication mode

I'm too new to this to know exactly what's happening, but I'm wondering if the JWT is not getting stored properly, or can't be found, as a result of the above edits, because this assignment result is null.

const token = localStorage.getItem('apollo-token')

My project package.json has "vue-apollo": "^3.0.0-beta.11", "vue-cli-plugin-apollo": "^0.19.2", and "vue": "^2.6.2" and vue CLI is 3.8.2.  I don't know if this is the right place to ask this, but I'm grasping at straws as it is.

@fogelfish This is a different issue, but happy to help! Once you've "signed in" or stored the JWT somehow, check local storage to see if it's in there. If it is, then try storing something arbitrary in local storage and retrieving that to ensure you're retrieving successfully.

I'm sorry I didn't update my comment here yesterday. I realized what you've pointed out, @bswank, that I had to login first to see the JWT.  I didn't expect the console to show any errors on first page load and therefore I was stuck on solving a problem that didn't really exist.  In hindsight I see that this is a sample app.  Its purpose is to demonstrate the small piece of the stack and that's all.
I'm curious if in a more fully realized app it would be desirable to log an error in the console before any attempt to log in?  Would it be valid to try to access to the hasura server in case the session was still logged in from earlier?  Or to make use of a refresh token?  I am, as you can see, still just getting to grips with all this.

No worries, @fogelfish! Thanks for the update. The important thing is that you think through what your user might actually want to accomplish and then build for that. So, in the case that you have data stored in your database that should be accessed by a user who is not logged in, you'd want to figure out how to make a request to your server without a JWT and ensure your app allows that. This would be, for instance, if you have data like a blog post.
In the case that all users making server requests should be authenticated, then you would always send the JWT along with the request (except when you're actually authenticating). In that case, when a logged-in user returns to the page, the JWT will still be available in LocalStorage or the user is logged out. Hope that helps!

Duplicate of #630


Figure out how to host with pages

The site needs to be hosted with pages.
https://pages.github.com

This seems easy enough... hosting setup.


BehaviorTreeTests.cs:9: Define list of steps to test all...

The puzzle 8-e88793d8 from #8 has to be resolved:
https://github.com/Stanislau/behavior-tree-for-testing/blob/9ba49d59a521caa5b03d27834fc2965d50d7d8ee/BehaviorTreeForTests/BehaviorTreeForTests.Tests/BehaviorTreeTests.cs#L9-L9
The puzzle was created by @Stanislau on 07-Oct-24.
Estimate: 30 minutes,  role: D.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd the puzzle #30 is still not solved; solved: #11, #12, #13, #14, #4, #5, #6, #8, #9.


Command Blocks not giveable

I can't give command blocks for myself in singleplayer. In a Bukkit Dedicated Server (without forge), with the Essentials plugin, it works fine. Maybe it is a restriction, like permissions and such. So if I right click it gives the uses of the command block, if I left click, it would give the recipe. So it does that if I would be in Recipe mode. But the strange thing is, if it is a restriction, and/or an intended feature, why I can give myself Command Computers and Command Block Minecarts ?
I am using these versions, but I noticed about this everywhere:
CodeChickenCore 1.7.10-<IP_ADDRESS>
NotEnoughItems 1.7.10-<IP_ADDRESS>
I don't really know how could I do screenshots for this. If you want pictures, tell me and I will make a GIF.
If you need anymore info, forge logs, or anything like that, tell me.
Thanks!

I'm pretty sure you have to be in creative, before you can use commands blocks.

It does not work in Creative and Creative+ mods either.


Upgrade okhttp from v3 to v4

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Change travis

I generate the .travis.yml file with the runscript from multi-ghc-travis, just adding the tested-with property into the cabal file, as the multi-ghc-travis suggest.
I also had to change the test, so that they can run in any GHC version.

I'm going to close this PR if we merge #16


About expert capacities: Is there token-dropping during training?

Hi there, thanks for open-sourcing such an amazing LM~
I'm wondering if you limit the maximum expert capacity by dropping some tokens during training like Switch Transformer.
Since training large MoE models is pretty costly, maybe it's necessary to add a hard constraint to ensure faster expert parallelism?
Thanks again and looking forward to hearing from you.

@DeepSeekDDM

DeepSeekMoE 16B does not have a dropping strategy since it does not use expert parallelism. If using expert parallelism, token dropping will be applied to ensure training efficiency.

Thanks for your valuable comments~ I found the relevant contents from the technical report. Thanks again for your response~


hasValidations decorator ES6/TypeScript

I'm trying to use cp-validations within an app using ES6 classes & TypeScript and I'm getting a few errors.
Here is what my component looks like:
import Component from '@ember/component';
import SessionService from 'maestro/pods/session/service';
import { service } from '@ember-decorators/service';
import {
  validator,
  buildValidations,
  hasValidations
} from 'ember-cp-validations';

const Validations = buildValidations({
  identification: [
    validator('presence', true),
    validator('format', { type: 'email' })
  ],

  password: [
    validator('presence', true),
    validator('length', {
      min: 8
    })
  ]
});

@hasValidations(Validations)
export default class LoginForm extends Component.extend({
  // ....
}) {
  @service
  session: SessionService;

  @service
  flashMessages;

  identification: string;
  password: string;
}

The first problem that I get is when running tests for this component, the error I get is:
Error: Assertion Failed: You must call `this._super(...arguments);` when overriding `init` on a framework object. Please update <maestro@component:login-form::ember238> to call `this._super(...arguments);` from `init`.@ 196 ms

This error only appears in tests, but not when running the app.
Note: Using Component.extend does not work, so I have to use the decorator.
Environment

Ember Version:  3.3.1
Ember CLI Version: 3.3.0
Ember CP Validations Version: 4.0.0-beta.2

Steps to Reproduce

@offirgolan I have created a reproduction for this bug: https://github.com/josemarluedke/--ember-cp-validations-repro.
One interesting thing I discovered, is that if I add an action to the component, then I don't have this problem. I don't have an action in my component since I'm using ember-concurrency tasks.


Incorrect error output for mistakes in HTML fragments

Problem
The macro parser doesn't correctly handle errors in HTML fragments.
Steps To Reproduce
Steps to reproduce the behavior:

Put the following into a html! invocation:    html! {
        <key="key" key="key">
            <div>{ "Hello World!" }</div>
        </>
    };

Attempt to compile the code
See that the error you get is "error: unexpected token"

Expected behavior
If you look at the code in yew-macro\src\html_tree\html_list.rs,
https://github.com/yewstack/yew/blob/9aff041c536afda436bf5879b482c1193dbae0d1/yew-macro/src/html_tree/html_list.rs#L148-L156
the intended error message here is clearly meant to be

Only a single key element is allowed on a <></>

Environment:

Yew version: master
Rust version: 1.44

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

My guess is that this happens because something in here says "I'll handle this one" from their peek() calls, but then shouldn't actually have done so.
https://github.com/yewstack/yew/blob/9aff041c536afda436bf5879b482c1193dbae0d1/yew-macro/src/html_tree/mod.rs#L41-L72

Also, while it's only bad for compilation times, due to all the peeking, this code effectively parses everything twice, doesn't it? Plus it may also partially parse things that aren't even the thing in need of parsing.

You're right, unfortunately Yew performs a lot of duplicate parsing. This is something I've thought about a lot and I think our best bet is to get rid of the Peek traits entirely. It should be possible implement this using a few lookaheads to distinguish between multiple variants.
This is a huge endeavour though and as such probably deserves it's own issue.


RFE: get rid of Perl based tools to reduce dependencies

While working on the "Modular Fedora" project, where one of the goals to reduce the size of the installed content, the team realized that there are some tools written in Perl dragging it into the system. I think the most prominent one is the zipl_helper.device-mapper helper script in zipl, but there are few more.

@sharkcz : Could you please provide some more information / links on "Modular Fedora"?
Aren't there thousands of perl programs for Linux. Do you want to eliminate them all?

@oberpar : FYI - since zipl helper explicitly has been mentioned here.

The idea is to start with a rather minimal system and then add content on top of that, you can find more at https://github.com/fedora-modularity/hp and https://fedoraproject.org/wiki/Modularity (and more). As the bootloader is always part of the minimal system (on all arches) to make system usable at all it's now dragging Perl into the package set (on s390x). Similar problem on ppc is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=1463749 There is no problem with Perl in "upper" layers.

Ok, so your goal is that the base-runtime (?) minimal system does not contain Perl.
Currently for RHEL7.4 we have the following Perl programs in s390utils-base:
$ grep -r "usr/bin/perl" *
lib/s390-tools/zipl_helper.device-mapper:#!/usr/bin/perl -w
lib/s390-tools/cpumf_helper:#!/usr/bin/perl -W
sbin/zfcpdbf:#!/usr/bin/perl
usr/sbin/ip_watcher.pl:#!/usr/bin/perl -w
usr/sbin/chmem:#!/usr/bin/perl
usr/sbin/lsmem:#!/usr/bin/perl
usr/sbin/chcpumf:#!/usr/bin/perl -W
usr/sbin/lsluns:#!/usr/bin/perl
usr/bin/lscpumf:#!/usr/bin/perl -W

What should be part of the base-runtime? Only glibc?

Ok, so your goal is that the base-runtime (?) minimal system does not contain Perl.

right, respectively removing Perl, which is not used otherwise, is a way to reach the goal

What should be part of the base-runtime? Only glibc?

AFAIK that's still not fully defined, but I would expect that none toolkit libs will be available directly, some might come via dependencies, but that can't be relied on.
One can imagine the "base runtime" as init (systemd) + ssh + shell + package management.

One can imagine the "base runtime" as init (systemd) + ssh + shell + package management.

Ok thanks, so what exactly is your suggestion? Rewrite the zipl helper in C and remove the remaining Perl tools from s390utils-base?

I would suggest to rewrite the zipl helper in C

In case we agree to that plan, do you expect IBM to do that or will "someone else" do the job?

Good question :-) It could be IBM or RH (or anyone else), depending on time frame, resources, etc. Definitely not the case that we expect only IBM must do it.
BTW the libraries from the util-linux package might be useful for the rewrite.

BTW the libraries from the util-linux package might be useful for the rewrite.

Which are GPL v2, no?

the libs are under LGPLv2+

@sharkcz : We discussed your issue internally an came to the following conclusion:

There are no objections against rewriting the zipl helper in C

If you want IBM to do this, you probably should request this via our official distribution channels.
But since we are "open" now, we would be also glad to accept your first contribution ;-)
Regarding the question about util-linux libraries:
Because of the license issue, I would first try to use our s390-tools internal library, e.g. "libutil/util_path.c" or "util_scandir.c". In case you require more functionality, we could also expand the library.

@r4f4 is looking into it

@sharkcz are there still dependencies to be resolved to address the original issues from your side?
If not, I would consider the whole issue here as being resolved. As far as I can tell, there are still a few
tools left written in perl, but as nothing came in the past, I feel like those tools are no blockers to
the original problem.
What's your stand on the current situation?

The urgent needs were resolved by the introduction of the s390utils-core subpackage (see https://src.fedoraproject.org/rpms/s390utils/blob/master/f/s390utils.spec#_173), so flavours like CoreOS can be installed/used without Perl. But the original problem is still there, the regular installer image contains Perl on s390x, increasing its size and dependency chains, while other arches like x86 or aarch64 don't require Perl in the installer image. The general policy is to reduce the number of language environments, so it still makes sense to try to replace Perl with some other language in the remaining tools in the longer term, at least for our s390utils-base (ip_watcher.pl, lsluns, zfcpdbf). The ziomon related tools would be lower priority.

Alright, thanks for the information. I'll try to address these internally. As far as I understand, this is about the installation
environment. So, there are certainly tools (like lsluns) that could potentially be moved to other subpackages (Like @Benjamin-Block
suggested here already: https://github.com/ibm-s390-tools/s390-tools/pull/22#issuecomment-351709219)
Is this the complete list of the remaining tools that need to be addressed: ip_watcher.pl, lsluns, zfcpdbf ?

I believe many people would like to see Perl deprecated globally :-) and I'm thinking about proposing the rewrites as a project for OpenMainframe Project's Internship programme, if it should help to speed up the process and we will agree the perl removal is a good step.
The complete list is bellow, but the 3 tools are the ones present in base. Some might be easy to convert to eg. a shell script.
[dan@talos s390-tools]$ find . -type f | xargs file | grep Perl
./ip_watcher/ip_watcher.pl:                                             Perl script text executable
./ziomon/ziorep_config:                                                 Perl script text executable
./ziomon/ziomon_fcpconf:                                                Perl script text executable
./zconf/lsluns:                                                         Perl script text executable
./scripts/zfcpdbf:                                                      Perl script text executable
./iucvterm/bin/ts-shell.in:                                             Perl script text executable

Putting the Perl tools into a separate subpackage isn't a good solution in my opinion, because it will bring a consistency issue for example (a minimal one, but still).


Recommended server setup?

What is the recommended way to setup GoCD server and agents? It seems like the agent cookbook here sets up 16? agents by default, which seems like a fair amount for a typical server. Should agents and server run on the same box, or seperate boxes.
For context, we're setting this up on an Openstack cloud, with 4 CPU, 8-GB RAM VMs as standard. Would it be best to have 1 VM for the server and 2-4 VMs for the agents, or would it make sense to install them all on the same VM. And how many agents per CPU?

Also thinking here in terms of how it would be easiest to scale out/up in future.

Hi @michaeloa

It seems like the agent cookbook here sets up 16? agents by default

Where did you got that idea? The cookbook provides a resource for any number of agents you like.
Also you should try asking and searching for this type of problems on gocd user forum. This is just a chef cookbook, less community here and we'd rather keep discussions related to chef operations.
I also doubt there is a rule of thumb, other than keep server separate from agents. You'll want to deploy (and break) agents more often. Size really depends on workload patterns, as you said. E.g. I run 3 flavors of agents.


Description of Normalization Hard fork for discussion and review

[describe in plain English what happens at normalization fork]

@kaykurokawa @lbrynaut which of you is doing this?

currently on it

According to the ICU docs "unpaired surrogates are replaced with U+FFFD" (aka, � ). There is no error thrown. I was thinking I would check for that character and pass the original bytes if it existed. To improve the performance, we could just do the check if the number if incoming bytes is different than the number of bytes after the conversion (but then you run the risk of � showing up in your URL).

I can see where boost::locale does the conversion (in uconv.hpp), but not the implementation of the icu method:
icu_std_converter<char_type> cvt(encoding_);
icu::UnicodeString str=cvt.icu(begin,end);

Bringing in the requirements as posted internally:
Features (after fork):

For determining the winning claim at a given URI, we use a case-insensitive and unicode-normalized comparison. This ensures that similar accent marks compete and that differing case compete.
UTF8 input is supported. Non-conformant input is also supported. Thus mal-formed or partial UTF8 will still get recorded. (And those exact bytes will have to be used to look it up.)
The exact bytes that came in with a claim are preserved. You can see those exact bytes in the original_name field that is returned by these RPC methods: getclaimsintrie, getvalueforname, getclaimsforname, getclaimbyid. We hope these will be rendered as the correct address; we want the consumers to see the exact casing chosen by the publisher.
The name field on the UPDATE op can be used to change casing. The SUPPORT op is no longer case sensitive (but relies heavily on the claimId).
The name field returned in the RPC methods in item 3 above contains the normalized, case-changed name.
The name input field for these RPC methods is not case sensitive: getvalueforname, getclaimsforname, getnameproof.
There is a new RPC command, checknormalization, that returns the normalized, lower-cased form of the input.
Update: after discussions with @grin, the getclaimsintrie results will have a name field added inside the claim object, which will then contain the original name. The outer name field will become normalizedName. This is a breaking change and will happen with the release, not fork height.

@tiger5226 , the RPC changes will necessitate an update to https://github.com/lbryio/chainquery. You will need an additional DB column to store the normalized name, and that name may be needed for various joins. There is no issue at present to track that.

Will the entire UTF-8 character set be available for claims?
Additionally, will @ be available?  We currently treat this as a reserved character on Spee.ch

@skhameneh , the present design does not restrict any data. All possible byte combinations will continue to be available. @ and # are currently allowed in claimnames at any location, and that will be true after the fork. Any valid UTF-8 will be normalized and lower-cased. Anything that is not valid UTF-8 will compete only with those exact bytes.


TableOfContents smooth scrolling poses accessibility issues

Current Behavior
Currently, the TableOfContents component will always scroll smoothly, regardless of whether the user has indicated that they would prefer reduced motion.
Expected Behavior
The behaviour of the scrolling should be exposed, and provided with a sane default of scrolling instantly if the $prefersReducedMotion store (introduced in #1533) is true.
Steps To Reproduce

Turn on prefers-reduced-motion media query
Use the TableOfContents to navigate around a page
Note how it still slides smoothly.

Link to Reproduction / Stackblitz
No response
More Information
I found this while I was investigating some other things that I wanted to change with the ToC;

Exposing the innerHTML permalink 🔗 as a parameter that defaults to 🔗
Boolean flag to wrap the entire  tag in the permalink, rather than appending it
Styling options exposed for the permalink (on hover permalinks are really trendy!)
Expose the block and inline parameters of the scrollIntoView method.
Expose the headingSizeThreshold as a parameter to customise when headings are added to visibleHeadings
If the heading scanned has no innerText then the id will be "". It would be best to extract the logic for creating the ids, even better to expose it as a utility function.

As part of the v2 updates we now have a solution for this. This can now be considered complete:
https://www.skeleton.dev/utilities/table-of-contents#smooth-scrolling


Gradient2Limit fixes

@elandau could you please take a look at this?

hi, bro, did u meet this situtation in issue  #137 ?

@happyomg afaict, drop translates to back-pressure from the downstream service. In that case, using 0.5 as gradient is probably not a bad idea. 0.5 aligns with other limiters like AIMD in this repo. Remember that there is a smoothing factor to absorb any intermittent shocks.

@elandau do you have an estimate on when you would be able to review this? I am waiting on this since 8 days.

@elandau In case you are waiting for the travis failure fix, the failure seems to be a transient one.

This PR doesn't include a description, but I've noticed a change like this seems necessary to avoid some problems with gradient2.
The main problem I've seen is that under modest overload, ex: when the gradient is around .8, the inclusion of a queue will cause the limit to gradually increase indefinitely:

Restricting the queue to only be included when gradient = 1 may not be originally what the queue was intended for, but it somewhat alleviates this problem.


Feature Request: Open Binary Files

It would be great if this extension would open binary files by default, i.e. instead of this message:

You get the hexdump, the way sublime text handles it.

This is currently a limitation of VSCode, but this is being worked on.
On the bright side, next version of VSCode should allow extension to use the Open/Save dialog, which mean you can skip this error message.

Alright, be sure to add it once its feasible :)


prefab methods issues

Detailed description
you can find prefab methods issues in the following link:
https://docs.google.com/spreadsheets/d/1RkmH4ErT9u85uEooVPca_nP7PU_jL_qAKgsbDqf2Ysw/edit#gid=1913967487
Installation information

jumpscale version:
core: 617a7ad5a767f1fd7fb7a2a5d6a8cc9c112009e8
lib: bc1fe0b4e3bf9d3a650cbb3b8e090fbcea523a9f
prefab: 7eab488e38abb629eb230d6e5327eb1b58894eeb

operating system:
Ubuntu 16.04

see https://github.com/threefoldtech/jumpscale_prefab/issues/40


[Bug] Topic - "Stateless Apps" missing in the Search filter

The topic of Stateless Apps is missing from the search filter! Therefore, not able to separately access the term
https://user-images.githubusercontent.com/72245772/160981106-94f8cb89-241c-470b-ba0b-931604e62282.mov

@verma-kunal Thank you for the report!
it is because,
the status of Stateless Apps is Feedback Appreciated

title: Stateless Apps
status: Feedback Appreciated
category: technology

If the document is not completed status, the document is not visible from the sidebar tree and search.
But, Stateful Apps doc includes the link to Stateless Apps so you could access to the document.
I am not sure why the status of Stateless Apps is still Feedback Appreciated.

@CathPag
I think we need to remove the link for Stateless Apps in  Stateful Apps
or change status of Stateless Apps doc to completed.
Please coordinate :)

it is because,
the status of Stateless Apps is Feedback Appreciated

Oh, got it! Thanks for clarifying @seokho-son

@CathPag I think we need to remove the link for Stateless Apps in Stateful Apps
or change status of Stateless Apps doc to completed.

+1

I'm afraid we still haven't been able to get a mergeable definition. See conversation in this PR.  We do need it to go with stateless apps. I'll go ahead and close this issue.


Update FullQualifiedName.java

performance / allocation improvement

Isn't it faster (and maybe less mem consumption?) to calculate the fullQualifiedName once in the constructor instead of calculating it each time when toString() is called?


[libusb] Build error

PLEASE SEE ATTACHED FILES
I have added the export of system information so you will have as full picture as I can think of...
Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs
the following is the screenshot and copy&paste of my console. this is what I did

c:\Work\Github>   git clone https://github.com/Microsoft/vcpkg.git
Cloning into 'vcpkg'...
remote: Enumerating objects: 169071, done.
remote: Total 169071 (delta 0), reused 0 (delta 0), pack-reused 169071
Receiving objects: 100% (169071/169071), 63.36 MiB | 1.24 MiB/s, done.
Resolving deltas: 100% (108931/108931), done.
Updating files: 100% (9511/9511), done.
c:\Work\Github>    cd vcpkg
c:\Work\Github\vcpkg>    .\bootstrap-vcpkg.bat
Downloading https://github.com/microsoft/vcpkg-tool/releases/download/2022-11-10/vcpkg.exe -> C:\Work\Github\vcpkg\vcpkg.exe... done.
Validating signature... done.
Telemetry
vcpkg collects usage data in order to help us improve your experience.
The data collected by Microsoft is anonymous.
You can opt-out of telemetry by re-running the bootstrap-vcpkg script with -disableMetrics,
passing --disable-metrics to vcpkg on the command line,
or by setting the VCPKG_DISABLE_METRICS environment variable.
Read more about vcpkg telemetry at docs/about/privacy.md
c:\Work\Github\vcpkg>    .\vcpkg integrate install
Applied user-wide integration for this vcpkg root.
CMake projects should use: "-DCMAKE_TOOLCHAIN_FILE=C:/Work/Github/vcpkg/scripts/buildsystems/vcpkg.cmake"
All MSBuild C++ projects can now #include any installed libraries. Linking will be handled automatically. Installing new libraries will make them instantly available.
c:\Work\Github\vcpkg>    .\vcpkg install libusb
Computing installation plan...
A suitable version of cmake was not found (required v3.24.0) Downloading portable cmake 3.24.0...
Downloading cmake...
https://github.com/Kitware/CMake/releases/download/v3.24.0/cmake-3.24.0-windows-i386.zip->C:\Work\Github\vcpkg\downloads\cmake-3.24.0-windows-i386.zip
Downloading https://github.com/Kitware/CMake/releases/download/v3.24.0/cmake-3.24.0-windows-i386.zip
Extracting cmake...
The following packages will be built and installed:
libusb[core]:x86-windows -> 1.0.26#2
Detecting compiler hash for triplet x86-windows...
A suitable version of powershell-core was not found (required v7.2.6) Downloading portable powershell-core 7.2.6...
Downloading powershell-core...
https://github.com/PowerShell/PowerShell/releases/download/v7.2.6/PowerShell-7.2.6-win-x86.zip->C:\Work\Github\vcpkg\downloads\PowerShell-7.2.6-win-x86.zip
Downloading https://github.com/PowerShell/PowerShell/releases/download/v7.2.6/PowerShell-7.2.6-win-x86.zip
Extracting powershell-core...
Restored 0 package(s) from C:\Users\boris\AppData\Local\vcpkg\archives in 342 us. Use --debug to see more details.
Installing 1/1 libusb:x86-windows...
Building libusb[core]:x86-windows...
-- Downloading https://github.com/libusb/libusb/archive/4239bc3a50014b8e6a5a2a59df1fff3b7469543b.tar.gz -> libusb-libusb-4239bc3a50014b8e6a5a2a59df1fff3b7469543b.tar.gz...
-- Extracting source C:/Work/Github/vcpkg/downloads/libusb-libusb-4239bc3a50014b8e6a5a2a59df1fff3b7469543b.tar.gz
-- Using source at C:/Work/Github/vcpkg/buildtrees/libusb/src/3b7469543b-a464ae495e.clean
-- Building msvc/libusb_dll_2015.vcxproj for Release
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
Command failed: msbuild C:/Work/Github/vcpkg/buildtrees/libusb/x86-windows-rel/3b7469543b-a464ae495e.clean/msvc/libusb_dll_2015.vcxproj /p:Configuration=Release /t:Rebuild /p:Platform=Win32 /p:PlatformToolset=v143 /p:VCPkgLocalAppDataDisabled=true /p:UseIntelMKL=No /p:WindowsTargetPlatformVersion= /p:VcpkgTriplet=x86-windows /p:VcpkgInstalledDir=C:/Work/Github/vcpkg/installed /p:VcpkgManifestInstall=false /p:UseMultiToolTask=true /p:MultiProcMaxCount=9 /p:EnforceProcessCountAcrossBuilds=true /m:9
Working Directory: C:/Work/Github/vcpkg/buildtrees/libusb/x86-windows-rel/3b7469543b-a464ae495e.clean
Error code: 1
See logs for more information:
C:\Work\Github\vcpkg\buildtrees\libusb\build-x86-windows-rel-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_msbuild.cmake:79 (vcpkg_execute_required_process)
ports/libusb/portfile.cmake:45 (vcpkg_install_msbuild)
scripts/ports.cmake:147 (include)
error: building libusb:x86-windows failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+libusb
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[libusb]+Build+error
Include '[libusb] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-11-10-5fdee72bc1fceca198fb1ab7589837206a8b81ba
vcpkg-scripts version: 6f7ffeb18 2022-11-11 (2 days ago)
Please use the prefilled template from C:\Work\Github\vcpkg\installed\vcpkg\issue_body.md when reporting your issue.
c:\Work\Github\vcpkg>git pull
Already up to date.
c:\Work\Github\vcpkg>vcpkg update
Using local portfile versions. To update the local portfiles, use git pull.
No packages need updating.
c:\Work\Github\vcpkg>

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.
issue_body.md
stdout-x86-windows.log
x86-windows.vcpkg_abi_info.txt
build-x86-windows-rel-err.log
build-x86-windows-rel-out.log
error-logs-x86-windows.txt
extract-err.log
extract-out.log

Please ensure you've installed Windows SDK first.
If the problem is not solved, please provide your vs include path:
Open VS command window and run set include as below:

sorry for the delay
I do have Visual Studio Build tools.

but all I have in include path

does not look right what do I miss ?

wait I might actually do not have windows SDK
Oops

after installing  “Windows 11 SDK (10.0.22621.0)” in the optional components of the Visual Studio 2022 Installer.

and the build went well
thank you for your help!


Update plugin-generator to use done-serve instead of can-serve

Currently, when generating a plugin with the plugin generator, DoneJS 8.0 is failing when you donejs develop, because it is lookign for a can-serve that no longer exists.

Coverage remained the same at 85.377% when pulling 17236ec2ae43eb3ec129a31b20598ad63b649fc1 on can-serve-to-done-serve into c9459e89b902ebe723992c8dee870133c9420e28 on master.

Ah, thanks a lot.


V9 Legacy customiser not working

Issue: We have started to convert our theme, Modena to V9 as we understand it the old LESS based customiser should still work, but all we get is a blank panel, no errors thrown from CCMS and no errors in the console.
How to reproduce: Fresh install of V9.0.0 with a full install of Elemental, Install Modena with demo data, go to customise, either/or from the design menu or the customise option in 'Pages and Themes'.
Are we correct in thinking this should still work?
UPDATE
We have since discovered an invisible button in the design panel, pictured below:

Upon clicking the button we sort of get the customise menu but with a load of parse errors, all the LESS was working fine on V8

Yes – I took a look at your theme and I see what the problems are.

In 8.5.6, if you have a single preset in your theme, we jump you right into customizing that preset, and we don't display its name. However in version 9 we don't do this yet. I could see adding this back in, but it's easy for you to fix in a backward compatible way in the meantime – just add
@preset-name: "Modena";

to the top of your defaults.less file. This probably should be in there anyway, even though I know you probably didn't do this because you only have a single preset. This will put "Modena" in the navigation instead of that empty button you found.

You have some variables in your defaults.less that the customizer doesn't understand. I don't think they need to be there. Try removing this:
@breakpoint-large:     ~"max-width: 64em";
@breakpoint-medium:    ~"max-width: 48em";
@breakpoint-small:     ~"max-width: 34em";
@breakpoint-xsmall:    ~"max-width: 25em";

and moving it into one of your less includes like _grid.less. That should fix the issue. I understand you might have put this in there because the thinking was that the preset could include the grid breakpoint variables – but a) you don't have any other preset and b) this'll fix the error today, which is probably desired.
Hope this helps!

@aembler Awesome, thanks Andrew that sorted it.

Great! Thanks for letting me know


New release?

I was wondering if there could be a new release for the id fixes made in https://github.com/vmg/redcarpet/issues/385. We're hoping to bump and deploy this to GitHub Pages: https://github.com/github/pages-gem/pull/143

Hi @gjtorikian,
Redcarpet version 3.3.0 has been tagged, we just need to wait @vmg to push it to RubyGems. Thanks! :-)

Thanks!

Pushed. Thank you @robin850!