Adds ts typings and removes now unused webpack dev dependencies

this adds some rudimentary types for #4
removes left over webpack deps

I will share a working boilerplate.

I've pushed this repo as a working project: (https://github.com/hirako2000/test-yoffee-ts)
It works fine on my side

and I'm not sure about the issue with commonJS and tsc, but perhaps this config is what does the trick:
{
    "compilerOptions": {
      "rootDir": "src",
      "outDir": "lib",
      "declaration": true,
      "resolveJsonModule": true,
      "strict": true,
      "esModuleInterop": true, // this
      "downlevelIteration": true,
      "pretty": true
    },
    "exclude": [
      "tests"
    ],
    "include": [
        "src",
    ]
  }

As we are on the subject of modules and transpiler issues and the surprising lack of browser support, please note that for user convenience, it is why the rollup changes included building more than what webpack was configured to do which was picking one flavor of distribution of the lib and the hell with developers who dislike that single flavor :)
Instead of pushing the problem to the consumer pipeline in handling a particular type of module system, the build now outputs a default ESM library (because this standard is officially chosen to be natively supported by node and other vendors, hence is winning the long race over commonJS)
But we also output a CommonJS distrib, because many developers still use commonJS, usually for the browser but even on node, they are familiar with it, and still are confused with ESM, and refuse to make the jump, despite the fact bundlers have an easier time doing tree-shacking on ES modules.
We also output an UMD flavour, because it is "universal" and claims to be working fine both on front end stack and back end stack, and I think is also adopted officially. Some say that UMD should be enough, but see it adds some overhead to the bytesize, and I'm not convinced it just works anywhere, yet.
And, we also output a module-less version of it, so any browser out there can interpret it as is. without the need of dependencies or having to do any transpiling to ensure backward compatibilities.
AFAIK AMD isn't that important because asynchronous module loading isn't very commonly used by developers, and those who do certainly know about this whole topic and can figure out their bundling config to easily asynchronously load whatever they bits they want.
It is a sad state of affaire that nearly a decade after module system specs were define and became the new way to articulate javascript code compartments, we still have to consider multiple patterns.
I suggest to document the existence of the several flavors so that consumers may be directed to their flavor of choice.
Back to your issue:
1/ Ensure to tell tsc what to do with ES modules (I think you figured that right) 2/ Make sure to transpile accordingly for browser compatibility, either via ts config, or use babel taking  tsc's output.
Alternatively, for 1/
Don't use the ESM distrib, instead:
a/ require() the CJS flavor.
or
b/ inject the iief as is.
or
c/ try importing the UMD flavor (i have no idea what tsc may do, it may not like it either, but tsc is funny at times)
Alternatively, for all, do what I did, life is too short, just adopt parcel 🦅

Thanks for the example, and for introducing me parcel! it's awesome. Actually the only problem I had is with resolving bare imports, and parcel fixes that by default. I also tried stripping as much to see what was really necessary to work with ts, so here is a fully stripped down version: https://github.com/lefetmeofefet/yoffee-typescript-template

Great job simplifying the boilerplate to bare minimum. I think it should be promoted as demo boilerplate to demonstrate functionalities. we could cover other features of the library like you did on the in browser examples. same but in a boilerplate project :)
parcel and vite are my favorite bundlers today, for web apps. they don't have the config complications of webpack, execute way faster, and produce minimal bytes. rollup is best for building lean libraries.

Vite looks a bit more framework-y but also lean and modern. Interesting.
Actually demos is a really nice way to help the potential community. I think I'll link each demo from the website to a working repo to clone


Improve documentation and guidelines

Summary
This patch aims to improve documentation and guidelines for newcomers.
It also updates issue and PR templates to achieve consistency with LAMBKIN.

Add README.md files for all packages
Update contributing guidelines
Update issue and PR templates
Add top-level gitignore file

This is not intended to be a finished job, but rather an improvement on the current state.
Checklist

[x] Read the contributing guidelines.
[x] Configured pre-commit and ran colcon test locally.
[x] Signed all commits for DCO.
[ ] Added tests (regression tests for bugs, coverage of new code for features).
[x] Updated documentation (as needed).
[x] Checked that CI is passing.

@glpuga Thanks for your review! I think this is ready for another pass.

@glpuga Re-requesting review!


Cannot use asset colocation inside section content

Consider a site with the following directory structure:
└── content/
    ├── about.md
    └── blog/
        ├── _index.md
        ├── blog_header_image.jpg
        ├── post1.md
        └── post2.md

Based on the documentation regarding asset colocation, I would expect to be able to access blog_header_image.jpg with a relative link from _index.md.  Instead, it seems that there is not a way to access blog_header_image.jpg.

Colocation is only for pages currently. No particular reason other than I didn't think it would be that useful

Makes sense.  I guess that puts this in the "feature request" category, then.  I don't think it should be a high priority, but I think there is a use case for it.  I tried to gesture towards one use case with my example above, where a site owner might have images that are specific to a particular section (like a header or background image for a blog).  I don't think this is that big of a deal—asset colocation is a convience feature, and definitly possible to get the same result using the static folder.  But it does seem like a nice-to-have-but-not-need-to-have feature for one day.

I wrote some PR for this. Hopefully it makes sense! :D
Thanks for labeling this issue good first issue. I stumbled upon it but would never have dared to take a look at the code otherwise :)

I'm somewhat in agreement with Keats here... how would asset colocation within a section be useful?  There is no organization within the folder and assets will be jumbled just like in the static folder.
I'm not saying that it's not a nice feature, but I think it will require more thought than just plopping the feature as-is for collections.  e.g., if posts were organized in directories along with their media (or if media was listed in a directory with the same name as the .md post) it would be much more organized and useful IMO.

I'm a bit confused by your comment, @piedoom.  You wrote:

e.g., if posts were organized in directories along with their media … it would be much more organized and useful IMO.

But, unless I'm misunderstanding something (always possible!) this is exactly how things already work with the existing version of Gutenberg, before pull request #364.
For example, consider a site with a homepage, an about page, and a blog section, with three pages in the blog section.  Further assume that they want to co locate assets with the blog pages.  They'd thus have an directory structure like this:
└── content/
    ├── about.md
    └── blog/
        ├── _index.md
        ├── post1/
             ├── index.md
             └── image_for_post1.jpg
        ├── post2/
             ├── index.md
             └── image_for_post2.jpg
        └── post3/
             ├── index.md
             └── image_for_post3.jpg

Isn't' that having "posts organized in directories along with their media"?  If so, that's already supported now.  Or did you have something else in mind?

Or did you have something else in mind?

They were referring to the discussion taking place in #364 (the PR) and more specifically Keats' comment:

This PR loads all non-md files in the same folder as a _index.md file as this section's asset. When you start having a few .md files in a directory like in https://github.com/Keats/vincentprouillet/tree/master/content/blog, the assets files will be spread around the directory based on their filename instead of being neatly co-located with the related _index.md.file
My idea was to use the same system the pages use: if we see a _index.md file, we don't load any assets. However if we find a _index folder in the content directory, we assume that it's equivalent to the _index.md file with the difference it has some co-located assets and load the index.md inside this folder.

Personally, i was arguing for supporting both workflows.
Maybe the conversation can continue here? it's probably more appropriate, sorry for bringing it over there ^^

I was unaware of that feature @codesections, I thought Keats was saying it didn't exist but I misunderstood.  Thanks for pointing it out.
My thought process is that both the markdown file and its assets in the same folder would be recognized as a separate collection but apparently that is not the case.

This is in 0.4.2 (currently being built).


Branch delete phone param

I think can delete the Phone.java and PhoneTest.java too

Seems like there are conflicts to be resolved before merging


PPA repository does not work right now

I'm trying to install youtube-viewer through ubuntu PPA repository, ppa:nilarimogard/webupd8, and it says: Unable to locate package youtube-viewer :-(

I also meet this problem. Ubuntu has no rights to enjoy it these days. 😭😭😭


Gif and sticker is fine but emoji is not working for me

I fixed the issue by replacing collection.dart of  giphy_get with collection.dart from giphy_picker pluging and works fine.

thanks!


ScalieIO Driver Performance Update

⚠ WIP, Depends on https://github.com/emccode/goscaleio/pull/17 Merged ⚠
This set of code changes are designed to improve the scaleIO driver
performance by reducing considerably the number of HTTP API calls made to
the backend storage gateway as outline in the following table.
Driver Init (no change)
2016/08/18 13:12:21 GET: /api/version
2016/08/18 13:12:21 GET: /api/login
2016/08/18 13:12:21 GET: /api/types/System/instances
2016/08/18 13:12:21 GET: /api/types/ProtectionDomain/instances
2016/08/18 13:12:21 GET: /api/types/StoragePool/instances

Volumes: 3-to-1 reduction
Previously took 3 calls, now only one
2016/08/18 08:51:18 GET: /api/types/Volume/instances

VolumeInspect: 3-to-1 reduction
2016/08/18 09:57:12 GET: /api/instances/Volume::a2b7f37f00000002

VolumeCreate: 5-to-2
2016/08/18 08:49:00 POST: /api/types/Volume/instances
2016/08/18 08:49:00 GET: /api/instances/Volume::a2b7f38200000003

VolumeRemove:  2-to-1
2016/08/18 09:01:21 POST: /api/instances/Volume::a2b7f38200000003/action/removeVolume

VolumeAttach: 5-to-2 if force=false
2016/08/18 12:34:52 POST: /api/instances/Volume::a2b7f37f00000002/action/addMappedSdc
2016/08/18 12:34:52 GET: /api/instances/Volume::a2b7f37f00000002

VolumeAttach: 12-to-4 if force=true **
2016/08/18 13:41:46 GET: /api/instances/Volume::a2b7f37f00000002
2016/08/18 13:41:46 POST: /api/instances/Volume::a2b7f37f00000002/action/removeMappedSdc
2016/08/18 13:41:46 POST: /api/instances/Volume::a2b7f37f00000002/action/addMappedSdc
2016/08/18 13:41:46 GET: /api/instances/Volume::a2b7f37f00000002

VolumeDetach: 5-to-2
2016/08/18 12:47:13 POST: /api/instances/Volume::a2b7f37f00000002/action/removeMappedSdc
2016/08/18 12:47:13 GET: /api/instances/Volume::a2b7f37f00000002

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Not sure why build is applying the wrong ref in glide.  The glide file in this PR has the correct ref hash value of 0a0847888970ea577a2b9c96fcd5463dffbf7717, but the build is trying to download an something else:
[ERROR]	Failed to set version on github.com/emccode/goscaleio to 76e031331e2babb894129d8b21dce88922301411: Unable to update checked out version

Anyway to force the build to use what's in the glide file ?

Hi Vlad,
I'll take a look in a bit. FWIW, we don't really want to merge until GoScaleIO merges from your PR there regardless.

Hey, I had an idea. Go to the PR build and clear its cache. I'll take a look myself and rerun the build.

Not a cache issue as it's not enabled on the repo. I did notice your lock file is out of date. Please rerun 'glide up' to make sure the lock file is up to date. 'make glide.lock' may also work.
 Did you push the patch to your fork being referenced here? The commit ID in your GoScaleIO fork I mean?

@akutz thanks for taking a look.  Agreed I don't want this merged until the GoScaleIO is merged, then I will update to point to proper ref.  Yes, my patch to goscaleio, referenced in glide,  is pushed (i triple checked that).  But, I will try your couple prescriptions above to see what happens.  Thanks!!

Hi @vladimirvivien,
The problem is what I said it was above - your glide.lock file is out of date. See this line in the build log:
[WARN]	Lock file may be out of date. Hash check of YAML failed. You may need to run 'update'

Also note that your hashes in the glide.lock (76e031331e2babb894129d8b21dce88922301411 ) and glide.yaml (0a0847888970ea577a2b9c96fcd5463dffbf7717) files do not match.

Please attempt to build locally before submitting a change. If make was used locally it would have caused the glide.lock file to be updated properly.

Current coverage is 26.08% (diff: 100%)

Merging #247 into master will increase coverage by 0.04%

@@             master       #247   diff @@
==========================================
  Files            39         39
  Lines          2419       2419
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            630        631     +1
+ Misses         1721       1720     -1
  Partials         68         68

Powered by Codecov. Last update 3daf75b...6cbe23d

@akutz
I ended up doing a glide update then run make which updated the glide.lock file with the correct hash.  However, as you can see, the build is failing with the same glide error with the old hash value even though the glide.lock file has been updated.

Um, looks good to me :)

Let's get Chris to build with this and validate the changes and then we merge SIO and then this.


[question] Is there an option to pause/resume workflows?

Hey,
I'm very excited about this project and have a glimmer of hope this could help cure my Celery PTSD ;)
While reading the documentation (not yet finished, so forgive me if this is somewhere down the road, but my sense is that it may be not) I started pondering if hatchet's Workflow abstraction could handle a use case where a workflow needs to be halted (for example there is a "manual QA" needed from a real person). Ideally there would be a way to dynamically add something to the context during this QA and resume the workflow.
Is this something you ever considered? Perhaps you have an idea how one could go about trying to implement this with the current version? Is this even feasible at the moment?
All the best, I'm rooting for you folks :)

Damn, I think I spoke too fast, just got to the "Manual Intervention for Workflow Continuation" section of https://docs.hatchet.run/home/features/durable-execution
I think this answers most of my questions... But I guess this will mean I would need to put the workflow in a failed state first, correct?

Hi @tadeoos, you can replay any step at any time and modify the context. No need to fail the workflow first.


refactor: append, build variable and type switch

append chains to the same slice that can be done in a single append call
when predeclared identifiers shadowed in assignments
loops that copy big objects during each iteration
type switches that can benefit from type guard clause with a variable

Blocked till 1.6.0-rc1 is released

Please resolve conflicts and sorry for forgetting to review it

@appleboy conflicts

@lafriks resolved conflicts.

Codecov Report

Merging #4940 into master will decrease coverage by <.01%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##           master    #4940      +/-   ##
==========================================
- Coverage   41.44%   41.44%   -0.01%
==========================================
  Files         442      442
  Lines       59643    59642       -1
==========================================
- Hits        24717    24716       -1
+ Misses      31696    31695       -1
- Partials     3230     3231       +1

Impacted Files
Coverage Δ

routers/user/auth_openid.go
0% <0%> (ø)
:arrow_up:

models/migrations/v64.go
0% <0%> (ø)
:arrow_up:

modules/templates/helper.go
47.48% <0%> (+0.13%)
:arrow_up:

modules/base/tool.go
72.54% <100%> (ø)
:arrow_up:

models/user.go
51.45% <33.33%> (ø)
:arrow_up:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

models/repo_list.go
73.09% <0%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9ed96...391e490. Read the comment docs.


Implement CORS

Hi Falcon Team,
It's my first time using this API, and I'm having a problem with CORS.
I implemented it using a middleware with a process_request:
response.set_header('Access-Control-Allow-Origin', '*')
response.set_header("Access-Control-Expose-Headers: Access-Control-Allow-Origin")
response.set_header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept')

But when an error occurs (an internal server error, like a key beeing accessed not existing in the dict), my custom header (to allow CORS) is not sent with the response error (500).
Am I doing something wrong?
Thanks,
Luan.

@luanalbineli not sure if you already found this but I've been tackling similar and found this:
falcon-cors
With the reference implementation of CORS happening here:
https://github.com/lwcolton/falcon-cors/blob/master/src/falcon_cors/__init__.py#L230
@lwcolton appears to be doing a solid job.

Hi @dgonzo ,
Thanks for your reply.
I think that I did not explain my problem right. I used falcon-cors/custom headers, but the problem is when an error raises in the middle of the request process. For example, when I try to access a key in a dict without check if the key really is there, an error raises, and falcon does not give back the falcon-cors headers/custom headers of the response. Consequently, Chrome (I'm building a Ionic App) gives me a Access-Control-Allow-Origin error.
Resuming, when an unexpected error occurs, falcon does not append my custom header in the response.
Thanks,
Luan.

@luanalbineli I think what @dgonzo meant is that I have released a semi-official falcon-endorsed CORS package to handle CORS.  Before asking for help from me or the falcon framework, you should replace your custom CORS code with the falcon-cors package.  Make sure to read the documentation.  If you are still having a problem afterwords I will be able to help you troubleshoot it.

Hi @lwcolton , thanks for your reply.
As i said, i used falcon-cors, but it gives me the same result: when an unexpected error ocurs, falcon does not append the access-control-allow-origin header in the response.

@luanalbineli this is the common issue for any of the application-level implementations of CORS. Usually it does not make a problem for people since failed XHR request response is useless in the same way as a it is when proper access-control-* headers are missing. Usually people forget that if CORS headers are not added to error response too, it makes a lot harder to debug issues on the browser. I did not look closer at the sources of falcon-cors but I think this could be oversight that way.
This is the reason why people usually manage CORS setup on a higher level of the application stack. If you use nginx or apache in front of your falcon-powered service then you can easily configure vhost to set specific headers even for error responses (at least in newer versions of nginx). There gives of course less a bit less of the flexibility becasue it is harder to manage per-resource settings. Still you can do a lot of things with good web server (nginx ftw!).
Consider using above approach as a solution to your problem because in practice it is works more reliable. Of course if what you want to achieve are the real HTTP error responses in browser logs instead of generic cors-related issue.

@luanalbineli I know this is pretty old but we ran into that issue as well and came up with the following workaround of making your adding your own error_handler which correctly run our middleware and add CORS headers:
@swistakm That works if you're running your own load-balancer but we're using Google Cloud's HTTP L7 load-balancer which just swallows the 500s and return a 502 with Falcon's default 500 behaviour because all it sees is that the backend closed the connection.
def handler(ex, req, resp, params):
    if not isinstance(ex, falcon.HTTPError):
        raise HTTPError(500, str(ex.message))
    else:
        raise ex

api = falcon.API()
api.add_error_handler(Exception, handler)

Before:
HTTP/1.1 500 Internal Server Error
Connection: close
Content-Length: 141
Content-Type: text/html

    <title>Internal Server Error</title>

Internal Server Error

After:
HTTP/1.1 500 Internal Server Error
Connection: keep-alive
Date: Thu, 24 Nov 2016 22:10:06 GMT
Server: gunicorn
access-control-allow-credentials: true
access-control-allow-headers: Origin, Authorization, Content-Type, X-Requested-With
access-control-allow-methods: GET, PUT, POST, DELETE
access-control-allow-origin: *
content-length: 99
content-type: application/json; charset=UTF-8
vary: Accept

{
    "description": "global name 'asd' is not defined",
    "title": "500 Internal Server Error"
}

@luanalbineli @swistakm   Sorry for my inadequate previous response.  It is not falcon-cors swallowing the error here, but falcon framework itself.  falcon-cors middleware processes CORS headers regardless of whether the resource raised an exception.  If an error handler has not been added to the falcon API, falcon will stop processing when an exception which is not an instance of falcon.HTTPError is raised.  Adding an error handler like @admiralobvious suggested will allow processing to continue when non-http exceptions are raised.  I changed one line in that example, to raise HTTPInternalServerError:
def handler(ex, req, resp, params):
    if not isinstance(ex, falcon.HTTPError):
        raise falcon.HTTPInternalServerError(description=repr(ex))  # Changed this to use falcon's error and repr() instead of str()
    else:
        raise ex

In the future you can create cors-related issues on the falcon-cors project:  https://github.com/lwcolton/falcon-cors

@kgriffs Ready to close this


Add musixmatch beta link to the website

Add beta link too, like it'll show the link for the beta site.
This is an easy solution, you just have to replace 'www.musixmatch.com' with 'beta.musixmatch.com'
Though this is not a required feature but some people may look for the beta link, so I think this would be great.

#16
https://spotify-link-to-musixmatch-track-and-albu-git-22ef09-adelhashem.vercel.app/
All good?


CLI File Naming Options

🚀 feature request
Relevant Package
angular CLI
Description
 A clear and concise description of the problem or missing capability...
currently when a component is generated it might be called x.component.ts and a service like y.service.ts
This has a few negative effects in my book:
1 - sorting by name does not group components and services together.
2 - Hungarian-like naming becomes awkward, eg ServiceAnalyticsService. Service is prepended in the hungarian-like system I like, but it also has to be appended to comply with angular convention.
3 - it doesn't seem possible to programmatically or humanly know whether a folder under app refers to a component, service, module...by looking at the folder name when generating a non-flat entity.
Describe the solution you'd like
 If you have a solution in mind, please describe it.
1 - An option to have the files generated with flipped naming like component.x.ts and service.y.ts
2 - A different option to allow type to be added to the folder name without redundancy. So normal mode is x-component/x.component.ts and flipped is component-x/component.x.ts
Describe alternatives you've considered
 Have you considered any alternative solutions or workarounds?
I'm personally OK with the redundant naming but my team isn't. So a key workaround would be having a component called ComponentThingComponent or ServiceSomeService.
ref: https://github.com/angular/angular/issues/32158

Hi, thanks for opening this.
At this point I think that this is outside of the scope of the CLI since the suggested namings don’t conform with the Angular style guide (https://angular.io/guide/styleguide#naming)
An option from your end would be to create custom schematics that extents the Angular schematics.

@alan-agius4 I'd like this re-opened as the style guide only touches on one of the two proposals I mentioned. I've also made a PR to the docs to request that be changed there as well:
https://github.com/angular/angular/pull/32168
Currently, the docs recommend feature.types.ts. Fair enough, although I hope to see it changed.
On the other hand, the docs do not officially recommend --flat=true nor --flat=false. Indeed, their examples in the section near naming assumes it is true, but the CLI also supports false.
So an enhancement request in this regard which is compliant with the existing style guidelines would be to allow the type to also be in the folder but not redundant.
Suppose either implementation:
1 - CLI has a flag --typed-folder=true then ng g c hello --typed-folder=true, with or without possibly implicit --flat=false, creates /hello-component/hello.component.ts.
2 - CLI detects type keyword within generated entity name and automatically dedupes. So ng g c hello-component with --flat=false creates /hello-component/hello.component.ts and not current /hello-component/hello-component.component.ts

meh nvm looks like no support for this

Hi @Vandivier, what you explained in your second point is already possible today.
You can use the below command;
ng generate component foo-component/foo --flat

ah thanks! I didn't realize foo-component/foo was possible
I appreciate your opinion about folders, but of course I disagree or I wouldn't be bringing this up. I could mention a number of benefits but I'll be concise and just mention one: Type information in the folder name allows me to have hero-component as a sibling of hero-service instead of having to make up random names to disambiguate them.
Vertical modularization is irrelevant here. You can still have vertical modularization with both feature and type in the folder name. In fact, module nesting is more transparent with x-module/y-module than it is with x/y. With feature-only naming you are going to ambiguate components, services, modules, and whetever else you might have related to that feature, at least in social conversation, and indeed you add technical complexity during file system operations and so on,.
The idea that removing a feature is easier without type information in the folder name simply isn't true. Remember, I'm advocating "feature and type" folder name, not "type without feature" folder name.


Add unit to dashbaords_generator & mark some yt_dashboards with unit

Added unit parameter to cell for clearer and more intuitive data visualization in Grafana dashboards. Also, marked some already existed dashboards with it.

I have read some code around, and there is a similar implementation for monitoring: SystemFields.Unit tag and method unit in class Taggable
Could we reuse it here? Or at least implement .unit_grafana(...) and .unit_monitoting(...) (since the unit system of grafana and monitoring differ)

Closing in favor of https://github.com/ytsaurus/ytsaurus/pull/924


Fix bazel 0.20's deprecated workspace imports.

Bazel 0.20 released today deprecated a few of the directives we were importing. This fixes that.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,410      Total (=)      2,020,410

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,174,077      Total (<)     11,174,081

 No significant differences in binary sizes

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,410      Total (=)      2,020,410

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,174,077      Total (<)     11,174,079

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences

Could this get cherry-picked into a released version? 1.17.0
It would be nice to be able to continue using grpc from a tagged release with bazel 0.20.


Added tag propperty to query string

Hi,
In order use one bot on multiple websites, I need the bot to know from what site he was called. This way the bot does not need to ask the user this information.
The easiest way I found was to add a "tag" parameter to the URL querystring and have the WebChat UI send the string in this tag to the bot as soon as the connection is made. It is then up to the bot implementation to act upon this first message properly.
I am sending this pull request because I think more users could benefit from this change and the changes are minimal.
Example usage: http://localhost:8000/?s=[bot secret]&tag=makemeasandwhich
Please do let me know if you need more information or want something refactored?
Best regards,
Jhon

Thank you for the excellent suggestion. I am working on a more general-purpose approach for sending messages from the enclosing webpage to the bot, but I very much like the ease-of-use of passing a single message at startup. I am going to close this particular PR, but I will likely incorporate your idea.
For now may I suggest that you use sendPostBack instead of sendMessage as it will send the tag without showing it to the user.


Input width calculation is broken

shadow.width is not a function - line 332
Also occurs on the demo pages
Chrome 46

Hi @sc8696,
Thank you for reporting this issue, this is due to a bug in the last commit.
Going to fix asap.

Check out the new release 0.6.3.


fix: gs import export issue

Description
This PR fixes:

when importing application which contains google sheets datasource with selected sheets scope, the file picker was not getting shown when authoring the datasource.

Add a TL;DR when description is extra long (helps content team)

Fixes #22501
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/ok-to-test sha=0e3bdf5

/build-deploy-preview

/ok-to-test

@prapullc - Why is skip-testPlan label added? Is this not tested functionally?


Version 0.0.17

At the request of @sylvestre and @rivy :)
I suggest we bump the Rust version again after this release, but we can discuss that in a separate issue.

Alright, I believe the failures are unrelated, so here goes :)


Add integration tests and documentation

Signed-off-by: Derek Rushing<EMAIL_ADDRESS>What Are We Doing Here
Adding integration tests and documentation. Also moves the manual_testing.md file in to the development markdown, and adds a new Testing.md file for tracking our testing implementation/expectations.
How to Verify

Stand up a minikube service.
Check out this PR and run ./test-scripts/integration-tests.sh

@wpdrush21 Tests are failing :-(

@lvaughn yeah I have it running locally, but Travis is a different beast, so it'll stay WIP until I get the Travis stuff started.

We should consider if we want our integration suite to remain in bash long term but I'm going to say this is a great start and sets the ground work for better tools in the future if we decide to switch.


SDK exported service class to talk to the admin api endpoint

Added SzAdminService Class
Added search-by-id example
Reverted changes to search-with-prefs
Bumped version from 1.1.0 to 1.2.0 for next release

#114 #115

Issue number: #114


Load by URI

When search was added, loading by URI was removed. Per @michelleif it should still be available. Perhaps on the load tab?

@justinlittman @jermnelson  can we get this into release 3.5 so that we are not releasing something that is missing a feature that used to be there?
I think it should be on the search tab. can you just put it back how it was, above or to the side of the search box. @astridu ?
If it's on the load tab, people might think they are loading in the existing URI to create a "clone". because when you use the load tab, you're creating a new resource.

if necessary we can do this after 3.5

on second thought I moved this to backlog because we have other more pressing things to do. user can always put trellis URI into a browser to see the description


Add version variable for optional import versions in pycompat

It was difficult to do version checks with optional imports so I added variables in pycompat and removed some of the imports I found.

Hello @Illviljan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/core/indexing.py:

Line 5:1: F401 'distutils.version.LooseVersion' imported but unused


docker-compose-up command fails because no oae-rabbitmq service is defined in docker-compose.yml

What happened: I ran the command  sudo docker-compose up --no-start --build oae-cassandra oae-redis oae-elasticsearch oae-hilary as given in the README.md but it fails with the error ERROR: No such service: oae-rabbitmq.
There is no service by the name oae-rabbitmq in docker-compose.yml, hence the issue.
What should have happened: The command should have ran successfully building docker containers.

Hi, sorry I missed this. OAE does not use rabbitmq anymore, now it's just redis. You'll find the right instructions on how to run docker containers in the README. Alternatively, you can run OAE in a single docker now: https://github.com/oaeproject/oae-demo
Hope this helps!


Fix: Not all vscode themes are available in the combo box

Hi!
I've noticed that only few of my vscode themes were available in the combo boxes. I traced down the issue.
Also I've added the alphabetical sort to the available options for ease of search

Looks good, thanks :+1:


Issue in getting subcollection from document in firebase

I have an issue, I can't get subcollection from the document:
I have firestore db with
collection: collectionName
Inside collection documents and inside one document subcollection "items"

collectionName

Document1

Items <- subcollection

Item1
Item2

I use the following code but the items subcollection can't be retrieved from my db....
QuerySnapshot snapshot = await Firestore.instance
.collection('collectionName')
.orderBy("order")
.getDocuments();
then
snapshot.documents.forEach((document) {})
The document doesn't have the items subcollection

Hi @ShabanGomaa
for what I can see the issue is related to a FlutterFire plugin,
please open the issue in the dedicated github.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
thank you


On contract detail page, show specific inactive category

If a contract is inactive, display an alert box on the detail page that explains:

[ ] Expired: "This contract is expired and is not usable anymore."
[ ] Replaced: "This contract has been replaced with {{ link to new contract }}."
[ ] Expired AND replaced: "This contract is expired, and has been replaced with {{ link to new contract }}."
[ ] Manually archived: "This contract has been removed from use."
[ ] Manually archived and replaced: "This contract has been removed from use, and replaced with {{ link to new contract }}."

Replaced

Expired

Can you get rid of the Warning! text? Otherwise, :+1: :+1:


Introduce FlutterEngine

The FlutterEngine holds the FlutterDesktopEngineRef and wraps the associated C-API.
FlutterEngine may relinquish the ownership of FlutterDesktopEngineRef as needed.
it's typical example is creating a FlutterDesktopViewRef.
Because FlutterDesktopViewRef takes the ownership of FlutterDesktopViewRef internally when it is created.

example)
    flutter_view = new ElmFlutterView(box, 720, 400);
    auto engine = FlutterEngine::Create("../res/flutter_assets",
                                        "../res/icudtl.dat", "../lib/libapp.so");
    flutter_view->SetEngine(std::move(engine));
    if (flutter_view->RunEngine()) {
      RegisterPlugins(flutter_view2);
      Evas_Object *evas_image2 = (Evas_Object *)flutter_view->evas_object();
      elm_box_pack_end(box, evas_image2);
    }

@JSUYA Please review again.


Closed Captions?

Would it be possible to have an option for enabling closed captions for VODs that have them?

Hi, thanks for the suggestions! Do you have any VOD with closed captions?


Zooming in Vertical Mode with long strips wont zoom properly

Steps to reproduce

Find A Manga/Manhwa/Manhua with long strips
Change mode to Vertical
Zoom in as far as you can

Expected behavior
Expected: A zoom beyond the strip's width
Actual behavior
Got: Zoom not even close to Strip's Width
Crash logs
No response
Tachiyomi version
0.13.1
Android version
Android 7.1, Android 9
Device
Cph1801, Realme 5
Other details
Version 1.12.3 didn't have this problem. Found this problem cause my phone has low ram and because of that webtoon mode is unusable(Still waiting for pr(the Cutting long strips to smaller pieces) to be done and merged).
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.1.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Full zoom on Solo Leveling chapter 176 from Mangadex

Tachi 0.12.3, same page

Oh god, i posted this issue in sy not in the main branch


Make GroupBy available in classes.py

superseeded by https://github.com/weaviate/weaviate-python-client/pull/565


Fixed editor attempting to save a blank scene with save all scenes

Fix #53668
Bug was caused by checking the scene exists in the same if statement as checking if it is valid to be saved.
Fixed by skipping if the scene doesn't exist as an object.

Cherry-picked for 3.4.


Fix cancel button when submitting a form

The cancel button does not work when a requestor submits the form.

This has been fixed.


Download tool with genome selection is not working

it works with taxon level (id), but not working with user genome group or a-z list.

fixed and available on www.alpha.patricbrc.org


[10.0.0-alpha.4] DOM stability dependent on order of parent/child hook calls

I have a parent component that tracks an array, rendering a child component that renders and allows edits to the array:
const Parent = () => {
  let [items, setItems] = useState([]);
  return html`<${Child} items=${items} setItems=${setItems} />`;
}

In this child component, the existing items are editable and additionally there is a "pending item" input for adding a new item to the array:
const Child = ({items,setItems}) => {
  let [pendingId, setPendingId] = useState(null);
  if (!pendingId) {
    setPendingId(pendingId = Math.random().toFixed(20).slice(2));
  }

  return html`<div class="item-editor">
    ${items.map((item,idx) => html`<input key=${item._id}
      value=${item.val}
      oninput=${evt => {
        let val = evt.target.value,
            _items = [...items];
        _items.splice(idx, 1, {...item,val});
        setItems(_items);
      }}
    />`)}

    <input key=${pendingId} placeholder="type to add an item"
      oninput=${evt => {
        let val = evt.target.value;
            _items = [...items];
        _items.push({_id:pendingId, val});
        setItems(_items);
        setPendingId(null);
      }}
    />
  </div>`;
};

The problem is this: when using the code as written above, the key=${pendingId} input gets completely replaced in the DOM as soon as the user enters one letter.
Because that "pending" identifier is passed along into the new item my expectation was that, on the next render, the focused input should remain in the DOM and get reconciled with the lastmost of the newly rendered key=${item._id} inputs.
But instead, the input ends up getting removed from the DOM and the user's focus is lost!
Workaround
If I take the two setters that together add the pending item into the array and reset the pending id:
setItems(_items);
setPendingId(null);

And simply re-order the calls so that the child's pendingId state gets set before the parent's items state like so:
setPendingId(null);
setItems(_items);

Then the input is reconciled as expected, i.e. the user's focus is retained when the new input is inserted after the one they are using!
To reproduce
This code is available ready-to-run (plus some additional logging) at https://codesandbox.io/s/74jll4q4v1.

Leave the "Set child state before parent state." configuration unchecked.
Start typing in the placeholder text input

Expected results:
Despite a new placeholder getting inserted, the keyboard focus should be retained, and you should be able to keep typing. (And, if you check the "set child state before…" box it works this way!)
Actual results:
When the new placeholder is inserted, keyboard focus is completely lost. Debug logs indicate that the original placeholder input has been removed from the DOM, and both of the inputs now in the DOM are brand new.

@JoviDeCroock I'm not quite sure what you're saying. Since I've been curious and you provided a good start, I fixed up your React sandbox to test its behavior, see https://codesandbox.io/s/62q2nnw9vr.
With React, the order of which state is set (setItems vs. setPendingId) does not matter.

if I render the key=${pendingId} input separately i.e. outside the items.map it never is reconciled, regardless if "Set child state before parent state." is checked or not
if I render the key=${pendingId} input together with the other children (see the .concat in my fork of your sandbox) then it is always reconciled as desired, again regardless of childFirst checkbox.

So I stand by this issue. With React it seems the rules are a bit more clear that children nested together are reconciled together, regardless of how/when hooks are called.
With Preact there is something less predictable and possibly broken going on. It doesn't matter how the children are rendered. Using the .concat trick needed for React has no effect, demo at https://codesandbox.io/s/yqrw433kpj which behaves exactly the same as my initial report.
With Preact for some reason it works fine or breaks completely just depending on which hook I call first. I happened to implement it the "wrong" way first, and stumbled across the "fix" it by swapping the order, but now I'm stuck with code that says // don't touch these two lines lest Preact mysteriously break the UX again.

Thanks for the awesome demo @natevw, it got added to our /demo repo and has effectively helped in solving this issue.
The fix is in PR now!

Excellent, glad the to be of some help and thank you for taking the time to actually track it down and fix it!
Are there existing utilities/patterns in the tests for tracking DOM stability issues like this? As a demo, I could probably share a bit more of the original code since the real UX was a bit more elaborate, removing blank rows and such… but also with things like this and #1481 since they have turned out to be bugs and not just misunderstandings on my part I'd like to help provide regression tests on them.

At this point I am looking to pour it into a test but focus loss is hard to test. I’m trying though :)

@JoviDeCroock The key [no pun intended] in this case I think is to just make sure the DOM element stays the same, I wouldn't worry about the focus specifically. The cause of the focus loss was an element with key X getting removed from the DOM and getting replaced with a new element with key X.
So I imagine the test would be something like:

Set up a suitable virtual DOM
Do the first render into it
Note the object corresponding to the "pending" child
Trigger the formerly-broken ordered calls to setState
Make sure the object of step 3 is still in the DOM

In my original demo it was this bit of code that really confirmed for me what was happening, because it would log false:
var dbgEl = evt.target;
setTimeout(() => {
  console.log("still in DOM?", Boolean(dbgEl.parentNode));
}, 25);

I was using the parentNode as an indicator just for convenience, whereas in a test we could probably just store the vnode or simulated DOM element in a variable after the first render result and do an === check on it compared to the second render result?

@natevw the test to prevent regression is in, thanks again for the detailled and thorough issue report. It helped us close this issue rapidly.


Tunnel to listening port on host computer

Hi,
Does this work when the listening port is in the host computer? I have a file server running on the computer, and I want the phone to connect to it and use those files (instead of the local filesystem), so I start my file server on port 6010, and run "mobiledevice tunnel 6010 6010", and then direct the client (running on the phone) to localhost:6010. But it seems like the tunnel function is listening for connections coming from the computer, not the phone. Is it possible to do a "reverse tunnel"?
Thanks!

I haven't tried for the src_host, but for the dst_port, yes, technically it should be possible.
Instead of creating a server, I would just need to accept connections from the device (like I already do) on src_port, and at the moment connect to dst_port on the host computer.
Would you have any time to work on this?

                                                                                Not right away :( I installed from brew on osx so I'm not set up to compile, I can try during the week                                                                                Sent from my BlackBerry 10 smartphone.                                                                                From: Mário FreitasSent: Sunday, June 12, 2016 2:22 AMTo: imkira/mobiledeviceReply To: imkira/mobiledeviceCc: punto-; AuthorSubject: Re: [imkira/mobiledevice] Tunnel to listening port on host computer (#10)I haven't tried for the src_host, but for the dst_port, yes, technically it should be possible.

Instead of creating a server, I would just need to accept connections from the device (like I already do) on src_port, and at the moment connect to dst_port on the host computer.
Would you have any time to work on this?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Would any of your above thread but useful in tunnelling ALL IP traffic out of an IOS device, as is the case for the 'rvictl -s ' command (Xcode tools)?
I'd be interested in programatically tethering the IOS device to my [mac] desktop, so I could share the desktop's internet connection.
Thanks

@sixman9 I am not saying it is not possible, but that would require more information on reverse engineering which I currently do not possess.


use re.escape() instead of WEIRD_CHARS lookup

Should do the trick.

Oups, I've already done (and released) that. Sorry! :)


Add stack overflow 2

This is another Stackoverflow challenge but for this exploitation, the technique would be different.
I'll add the writeup for this challenge once this PR is merged.

Thanks @mzfr for all the good work on the labs! 👍
I want to add you to the list of contributors for SKF :-)
How do you want to be mentioned there? ^^

Oh great thanks for doing that.
You can just add my GitHub username i.e  mzfr  and maybe link that to my profile :)


Bug in median calculator

Describe the bug

The function is unable to calculate the median due to some bug. I would like work on this issue. Kindly assign this to me under GSSoC.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

Go ahead
Deadline 5 April,2021 11:59 PM IST


Confusing - SID Claim missmatch on Client and Server for Push Notification

On the client 'MobileService.CurrentUser.UserId` is returning the "stable_sid" claim value after authentication.
When we register a user for PushNotifiaction, the "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier" is used as the _UserId tag.
This was confusing for me as I was expecting to use the same sid on both client and servicer. To trouble shoot why I was not able to send Push Notifications to specific users I had to dive deep into the code to finally find the miss match.

@soninaren, can you help answer this question?

If we have an answer that needs to be documented, please add the documentation tag and assign to me after commenting with the answer.  I'll update the docs.

@brisebois https://github.com/Azure/azure-mobile-services/issues/883 has details of this bug and a possible resolution.
@adrianhall WEBSITE_AUTH_HIDE_DEPRECATED_SID isn't documented currently. Check with @brettsam if we are ready for documenting it.


Populate should allow remote links

would be nice if when I refgenie populate something, I could choose to use local links, or remote links with a specific remoteClass.

done. This is how it works:
[mstolarczyk@MichalsMBP refgenie]: echo 'testing refgenie string: refgenie://hg38/fasta' | refgenie populate -c g.yml --remote --remote-class s3
testing refgenie string: s3://awspds.refgenie.databio.org/rg.databio.org/2230c535660fb4774114bfa966a62f823fdb6d21acf138d4/fasta__default/2230c535660fb4774114bfa966a62f823fdb6d21acf138d4.fa

awesome. is the config required?

yes, but I'm currently working on making it not required and realized that it's more complicated than listr and seekr since there's no dedicated populater command. Should we add one? There would be a nice distinction that commands/methods ending with r can be used with no config.

I think that makes sense to me


API key

Is your feature request related to a problem? Please describe.
The key will show as default when on 1080P in browser,
Describe the solution you'd like
For the key to be hidden,
Describe alternatives you've considered
Making the text the same colour as the background would work, however more advance option would be for a click to revel and a click to copy (same type of feature that firefox has when saving password) where the key does not need to be reveled all the time,
Additional context
Add any other context or screenshots about the feature request here.
image added for context

Good idea

thanks for this is perfect


[FE][SYNC-44] Hide article timeline and news recommendation on small screen

Description:

Since the article page currently does not have RWD, the timeline and news recommendation position are not functioning properly right now.

Changes:

Hide both of the sidebars when screen width < 1200px

Thanks for the suggestion, I've removed the class hide-below-xl and added media query to both sync-timeline and recommended-news.

The best solution is use scss mixin in global scss:
@mixin belowDesktop() {
@content;
}
and use
@include belowDesktop(){
display: none;
}


Better error/suggestion when passing options

Operating System: macOS 10.14.4
Node Version: v10.15.3
NPM Version: 6.4.1
webpack Version: 4.27.0
uglifyjs-webpack-plugin Version: 2.1.3

Feature Proposal
Better error message when passing wrong options.
Example:
{
  sourceMaps: true,
}

and I got this error
UglifyJs Plugin Invalid Options

options should NOT have additional properties

ValidationError: UglifyJs Plugin Invalid Options

we could print out the most similar option, same error message with:
Most similar option: `sourceMap`

In older versions, I get this error clarify which option is invalid
UglifyJs Plugin Invalid Options

options['sourceMaps'] is an invalid additional property

ValidationError: UglifyJs Plugin Invalid Options

Feature Use Case
Options
{
  sourceMaps: true,
}

Output
if there is a similar option
UglifyJs Plugin Invalid Options

+`sourceMaps` is invalid option
+ Most similar option: `sourceMap`
-options should NOT have additional properties

ValidationError: UglifyJs Plugin Invalid Options

Output
if there is no similar option
UglifyJs Plugin Invalid Options

+`sourceMaps` is invalid option
-options should NOT have additional properties

ValidationError: UglifyJs Plugin Invalid Options

I can open a PR for that if the suggestion got accepted.

Not related to this plugin, already WIP (https://github.com/webpack/schema-utils), will be shipped in next week, thanks for issue


WebSocket .NET 5.0 connection and publish issues

Describe your question
There are issues with Managed client and WebSockets, it fails (or takes a long time more than 30-60 secs) to connect and publish to a test Mosquitto broker, with .NET 5.0 on Windows 10, and fails on Mac OS X. It does work sometimes if .NET standard framework or Mono is used on Mac OS X or Linux.
I suspect platform specific code issues with the ManagedClient code (messages getting enqueued without actually being published, Task completion or threading issues?). The examples for ManagedClient here: https://dzone.com/articles/mqtt-publishing-and-subscribing-messages-to-mqtt-b and https://github.com/chkr1011/MQTTnet/wiki/ManagedClient were having these issues with dotnet core.
I managed to get the code working only using a Task completion and Task.ContinueWith() approach as shown here (@chkr1011  is this an optimal approach?):
            CancellationTokenSource source = new CancellationTokenSource();
            CancellationToken token = source.Token;

            var mqttClient = new MqttFactory().CreateMqttClient();
            var managedClient = new ManagedMqttClient(mqttClient, new MqttNetLogger());

            try
            {
                var task = Task.Run(async () =>
                {
                    var connected = GetConnectedTask(managedClient);
                    await ConnectMQTTAsync(managedClient, token, m_MQTTUrl, m_MQTTclientId, m_MQTTuser, m_MQTTpassw);
                    await connected;

                });

                task.ContinueWith(antecedent => {
                    if (antecedent.Status == TaskStatus.RanToCompletion)
                    {
                        Task.Run(async () =>
                        {
                            await PublishMQTTAsync(managedClient, token, m_MQTTtopic, serializedJSON);
                            await managedClient.StopAsync();
                        });
                    }
                });

            }

            catch (Exception _Exception)
            {
                Console.WriteLine("Exception caught in process: {0}", _Exception.ToString());
            }

public static async Task ConnectMQTTAsync(ManagedMqttClient mqttClient, CancellationToken token, string mqtturl, string clientId, string mqttuser, string mqttpassw)
        {
            bool mqttSecure = true;

            var messageBuilder = new MqttClientOptionsBuilder()
            .WithClientId(clientId)
            .WithCredentials(mqttuser, mqttpassw)
            .WithCommunicationTimeout(new TimeSpan(0, 0, 5))
            .WithKeepAlivePeriod(TimeSpan.FromSeconds(1200))
            .WithWebSocketServer(mqtturl)
            .WithCleanSession();

            var options = mqttSecure
            ? messageBuilder
                .WithTls()
                .Build()
            : messageBuilder
                .Build();

            var managedOptions = new ManagedMqttClientOptionsBuilder()
              .WithAutoReconnectDelay(TimeSpan.FromSeconds(5))
              .WithClientOptions(options)
              .Build();

            await mqttClient.StartAsync(managedOptions);

        }

        Task GetConnectedTask(ManagedMqttClient managedClient)
        {
            TaskCompletionSource<bool> connected = new TaskCompletionSource<bool>();
            managedClient.ConnectedHandler = new MqttClientConnectedHandlerDelegate(e =>
            {
                managedClient.ConnectedHandler = null;
                connected.SetResult(true);
            });
            return connected.Task;
        }

        public static async Task PublishMQTTAsync(ManagedMqttClient mqttClient, CancellationToken token, string topic, string payload, bool retainFlag = true, int qos = 1)
        {
            if (mqttClient.IsConnected)
            {
                await mqttClient.PublishAsync(new MqttApplicationMessageBuilder()
                 .WithTopic(topic)
                 .WithPayload(payload)
                 .WithQualityOfServiceLevel((MQTTnet.Protocol.MqttQualityOfServiceLevel)qos)
                 .WithRetainFlag(retainFlag)
                 .Build(), token);
            }
        }

Which project is your question related to?

ManagedClient

I am experiencing the same kind of connection issues running a simple .net 5.0 console MQTT client against a mosquitto broker in linux via websockets. I am able to verify the websockets connectivity through a test client like https://hezhii.github.io/mqttjs-client/ , but the .net client would fail (connection time out) in 10 seconds or so. The managed client failed too.
Here is the options for the managed mqtt.net websockets client I use.
var options = new ManagedMqttClientOptionsBuilder()
            .WithAutoReconnectDelay(TimeSpan.FromSeconds(5))
            .WithStorage(default(IManagedMqttClientStorage)) // TODO: need to implement.
            .WithClientOptions(new MQTTnet.Client.Options.MqttClientOptionsBuilder()
                .WithClientId(chatid)
                ////.WithCredentials("Your Secret Here")
                .WithKeepAlivePeriod(TimeSpan.FromHours(24))
                //.WithKeepAliveSendInterval(TimeSpan.FromSeconds(5))
                .WithCleanSession()
                .WithWebSocketServer(mosquittourl)
                .WithTls()
                .Build()
            )
            .WithAutoReconnectDelay(TimeSpan.FromSeconds(5))
            .Build();

My goal is to utilize the very same .NET 5 client code for realtime communications between web clients and desktops. One runs on destop or devices as IoT applications, and the other runs as  a Blazor web app via webassembly in the browser.  Would MQTT.net support this type of inter-operable scenario on the client side?

I have the same bug as fabioGulfMike. I use MQTTnet with Websocket in a Blazor .net5.0 Webassambly app.
Subscribing works without any problems.
But publishing does not work, the queue is getting longer and longer, but no messages are arriving the broker.
When I use the debugger to slowly step through the Publish() code while return back into the Blazor Framework publishing works and the broker receives the messages. So in my opinion there is something wronge with the  TryPublishQueuedMessageAsync.
Maybe its never called or the Task never get compute time in this single thread environment.

@sbroszat, I changed to MQTT client implemented in JavaScript and used the JS.Interop libs to build my project. Faster and more reliable.

I have the same issue and came upon this thread

@mvanhil if you mean Blazor: I changed also to the Paho JS MQTT Client with JS.Interop. Thanks for the hint @iotechFabio. Works without problems.

I'm now using the default library (not the managed client) and all is working perfectly for now (just publishing).


Specify type as "PR" when doing an issue search

I'm trying to search for pull requests and, if I'm not mistaken, they are really issues with the type of pr. It seems the issue search accepts SearchOptions which is general and doesn't allow you to specify a type. I plan to submit a PR to fix this but I wanted to create this issue in the meantime to make sure I'm not missing something. Thanks.

According to https://developer.github.com/v3/search/#search-issues it appears that there are a large number of options that could be added to the q query parameter, and as far as I can tell, it is currently not possible to add them (neither by SearchOptions nor the embedded ListOptions).  @willnorris will be able to state definitively if this is correct.
So a PR to fix this SGTM.

As Glenn notes, these are expected to be part of the query.  So,
client.Search.Issues("foo type:pr")

Ahh I see, thanks for your help.

we could probably stand to better document that fact though, so if you wanted to do a pull request to update the docs, that'd be great.

Alright, I'll see if I can make it clearer.


--platform option with parameters "intel" and "apple" are a bit misleading/confusing

Since --platform intel downloads an app that is actually Universal and works on Apple Silicon, it can lead users to think that the "intel" app download is Intel-only instead of a Universal app that can also be installed on Apple Silicon (reference: https://macadmins.slack.com/archives/C016JHNMP1N/p1642626345010200)
I think it may be more clear to potentially replace the --platform option with maybe --format (or maybe --type is also good) which could have possible parameters of "app" or "ipsw" (or maybe "installer" vs "firmware") and there could be notes in the help info that app's (for Big Sur and newer) are Universal and ipsw's are Apple Silicon only.

Hey @PicoMitchell, I do feel --platform better conveys the difference between the download types (as opposed to --format or --type), so I am proposing the following:

Keep --platform as the option to choose between Universal Installers (.app) and Apple Silicon firmwares (.ipsw).
Change the intel option to universal, and keep apple as-is.
Update the mist list --help and mist download --help output to better communicate the differences between universal and apple.
Bonus: Make intel a legacy alias for universal, to help reduce changes to existing workflows. I'm 50/50 on this one...

When I think --format I think "output format", so I want to avoid replacing --platform with --format.
Same goes for --type, would have get creative with replacing / updating the -t / --temporary-directory option.

Thoughts?

Thanks for thinking about this change and for sharing your thoughts.
I think that changing --platform intel to --platform universal would help alleviate some confusion, but it would also be imprecise in a different way since only the Big Sur and newer apps are Universal and Catalina and older are Intel-only. And, if you were to break the app listings up to only have Big Sur and newer show when --platform universal is specified and then keep --platform intel and only show Catalina and older, I think that would likely lead to more confusion as well as cause backwards compatibility issues.
So, while I think switching to --platform universal is slightly better, it's still not totally accurate.
I think another alternative to the --format/--type idea, would be --kind which has a similar meaning and should be clear as that is the term Finder uses in a files Info window. But, that the short option for that would conflict with the existing --keychain short option, but you could use the capitalized -K for --kind if you wanted (or switch --keychain to capital -K since it may be less used, but changing existing options like that is not great for backwards compatibility).
Personally, I think would move to specifying --kind app and --kind ipsw as I think it's very accurate and specific.
Another option may be to not have any --platform (or --kind) option and to expand the idea used in the mist download options where the --application, --image, etc options exist. You could simply add an --ipsw option for the Apple Silicon IPSW downloads and then add --application and --ipsw options to mist list to replace the --platform functionality.
Overall, I think this is kind of a more complex issue than it appears at first glance. I hope these thoughts help come to decision that you're happy with and that works well for mist and its users.

I think you have won me over with --kind! The first thing that comes to mind is Finder's use of the term, and ultimately that's what we're trying to differentiate, right?
I'll see if I can create aliases for app|installer and ipsw|firmware as options, otherwise I'll have to pick one (whichever "feels nicer")...


ReusableTasks dll not found.

Hi,
After the last commit the module is not working but builds succesfully.
System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> System.IO.FileNotFoundException: Could not load file or assembly 'ReusableTasks, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
That's happening when I try to create a new instance of ClientEngine.
Thanks for help.

If you reference the nuget for monotorrent you should also get an implicit reference to ReusableTasks.
Can you double check ReusableTasks.dll is being copied/deployed with your application?

On a side note, it looks like the sanity check is doing it's job and is forcing the error to surface quickly and reliably if the assembly is missing :) https://github.com/mono/monotorrent/commit/b3227b0237f9aae6e3397203d436d09f96ca1cda

I've cloned monotorrent project from GIT. After I've added the package manually from nuget, the issue was solved.

If you are building from source and your application project is referencing MonoTorrent.csproj, then i would expect ReusableTasks.dll to be copied to the output directory of your executable project too. That's how it works with SampleClient.csproj in monotorrent's own repository.
If you're directly referencing the compiled MonoTorrent.dll binary from the build output directory then you'll have to manually reference the same (or newer) version of the ReusableTasks nuget to make sure it is copied correctly.
A direct reference to the ReusableTask nuget should solve any copy-to-output-directory issues too :)
Glad you have it (mostly) working now though!

My project is referencing to MonoTorrent.csproj, but dll was not copied, even after many cleans/rebuilds.

And there is no such dll inside MonoTorrent project bin directory.

It won't be copied to the output directory of MonoTorrent.csproj, but it will be copied to the output directoy of both MonoTorrent.Tests and SampleClient. It won't be copied to the output directory of DotNetCoreSample because .net core uses a different mechanism to find the ReusabletTasks binary in this scenario.
An explicit dependency on your executable project should solve the problem. The exact treatment of transitive local copies is highly dependent on a number of things, so it's kinda tricky to rely on it's behaviour across project types.
Sorry I can't be of more help. I'm not 100% familiar with the intricacies of how this works.

I think it's enough info to other people to solve a similar problem.
Thank you for help.

i have the same problem,
with a .NET console app, which reference the MonoTorrent library,
after add dependency of reusabletasks to the console app, the issue fixed


Normalize symbol names?

Bitcoin Cash symbol BCH is more widely used than than BCC, can I suggest to follow to https://coinmarketcap.com/ as reference for coin symbols?

I agree that bitcoin cash should probably use BCH.
BCC is the ticker for bitconnect.
I have made a PR fixing this: https://github.com/allienworks/cryptocoins/pull/89


Sonic the Inclusive Hedgehog: Watch theweddingfile.in

Sonic the Inclusive Hedgehog requests the watch of the watch_keyword theweddingfile\.in. See the MS search here and the Stack Exchange search here.

theweddingfile\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.


Tab Bar behaves inconsistently on macOS

VSCode Version: 1.13.0
OS Version: 10.12.5

Steps to Reproduce:

Turn View > Show Tab Bar on
Open a new window: File > New Window

When in "Full Screen" mode, this adds a tab to window, and that tab stays when leaving full screen mode. When not in Full Screen mode, the steps open a new window instead of a new tab, only one of the windows is accessible when going to Full Screen Mode.
Proposed improvement: opening a new window always add a tab to the front window when Tab Bar is on.

That is a OS setting:

I changed it to manually, but that doesn't change its behavior. Only in "always" does it do so. Is there yet another setting involved?


Support OpenID4VCI in OpenIdResolver

Problem:
PR #67 is a prereq for this.
Based on preview feature flags, support OpenID4VCI requests.
Solution:
Add support for OpenID4VCI request in OpenIDResolver and fall back to old flow if Presentation Exchange model is returned.
Validation:
All unit tests pass as expected.
Type of change:

[X] Feature work
[ ] Bug fix
[ ] Documentation
[ ] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk:

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[X] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.
Documentation Links:
Please include here links to any related background documentation for this PR.

Changes look good to me. My only question is if there is a way to log performance and send telemetry for these network calls?

Yes, I have a separate work item for telemetry and logging


Assessment of the difficulty in porting CPU architecture for the uC-OS2 project.

Hello everyone! I am working on implementing a tool to assess the complexity of CPU architecture porting. It primarily focuses on RISC-V architecture porting. As part of my dataset, I have collected the rt-thread project. By using scanning tools, I have determined that the porting complexity is high due to a significant amount of code related to the CPU architecture. It would require a professional team to handle this task. Is this assessment accurate? I look forward to your help and response.

Hello everyone! I am working on implementing a tool to assess the complexity of CPU architecture porting. It primarily focuses on RISC-V architecture porting. As part of my dataset, I have collected the uC-OS2 project. By using scanning tools, I have determined that the porting complexity is high due to a significant amount of code related to the CPU architecture. It would require a professional team to handle this task. Is this assessment accurate? I look forward to your help and response.


powered spawner spawning from invalid nbt

https://github.com/Dmunch04/IndustrialReborn/blob/8e427bda7187dbea63b154cb4bb68028870dc662/src/main/java/me/munchii/industrialreborn/blockentity/PoweredSpawnerBlockEntity.java#L113-L127
getEntityFromNbt is intended to be used for a saved entity in the world or a structure, where it is being recreated from the nbt. Soul vial does not store the entire nbt, only the entity type.
This creates issues with mobs like Orcs from Adventurez, for example.
a better option would be to do a lookup in the registry and spawn using the
create(ServerWorld world, @Nullable NbtCompound itemNbt, @Nullable Consumer<T> afterConsumer, BlockPos pos, SpawnReason reason, boolean alignPosition, boolean invertY)

method call, which calls initialize and other things to ensure the entity is fully set up the way it would have been if spawned naturally.

Thank you for catching this. Wasn't aware this was problematic. Issue should be fixed in efcb74a


[Relay] Improve build error when no lowered funcs are produced

If you accidentally create a module with no lowered funcs via relay.build, interaction with the module down the road segfaults without an error message.  For example, the annotated line in the program below would segfault, because I have accidentally passed params to relay.build, causing the entire program to be const-folded away.
x = relay.var('x', shape=(1, 16, 64, 64), dtype='float32')
conv_expr = relay.nn.conv2d(
        x, relay.var('w'),
        kernel_size=(3, 3),
        padding=(1, 1),
        channels=16)
func = relay.Function(relay.analysis.free_vars(conv_expr), conv_expr)
mod = relay.Module.from_expr(func)

x_data = np.random.uniform(size=(1, 16, 64, 64)).astype('float32')
w_data = np.random.uniform(size=(16, 16, 3, 3)).astype('float32')
params = { 'x': x_data, 'w': w_data }

with tvm.build_config(disable_vectorize=True):
    graph, c_mod, params = relay.build(mod, target="c", params=params)
print(c_mod.get_source())  # <-- crashes here

This PR adds an error message to prevent the generation of modules without lowered funcs.
CC @jroesch @zhiics @tqchen

@weberlo please look into the ci error

I've switched the check in build_module.cc from fatal to a warning, as @zhiics suggested.  @tqchen Do you think modifying the ModuleNode* operator-> methods to include a runtime nullptr check is a good idea?


Cached walls seem to block sight.

Fantastic module!!! Been looking for this for a long time :)
I want to make the sun fall in when you open the door.

so i created this shape

But when i add it to the room it blocks the sight of the tokens

A regional area is in effect also inside the room to dim the light from the global lighting and there is a roof that restrict light. Neither should effect the light.
Don't know if i'm doing anything wrong or if its a bug.
Chrome
V12
D&D 3.3.1.

Anything for this yet? it would be a lifesaver for ppl using levels :)

This is a Levels issue. I don't think I can fix it. Levels should not be treating the cached edge as a wall.


How to login my tabnine account?

I install cmp-tabnine in my macos neovim, but i don't find a step or a cfg request me to login tabnine account.

Check the Readme...


chore(workspace): fix codepen title button

fixes https://github.com/patternfly/patternfly-next/issues/2150

Deploy preview for pf-next ready!
Built with commit bd906c0c9cf56d034cf6b75fc9cd2d404cdc58ac
https://deploy-preview-2151--pf-next.netlify.com

PatternFly-Next preview: https://patternfly-next-pr-2151.surge.sh


Add push access for ataulm

👋 Can I have ~contributor~ push access on this repo please? It'll be easier for me to work on and raise PRs.
Maybe at the same time protect the main branch so that only admins can push to it (I'm not asking for admin).

Closing as this repository is no longer under maintenance and it's about to be archived


Cannot patch flask.g in python 3.8+

I am unable to patch flask.g in python 3.8.  It works fine in 3.7.7.  The python developers are suggesting this is a flask issue, not a mock.patch issue.  In this sample, I expect the first test to pass and the second to fail.
E
E           This typically means that you attempted to use functionality that needed
E           to interface with the current application object in some way. To solve
E           this, set up an application context with app.app_context().
E
E           This typically means that you attempted to use functionality that needed
E           to interface with the current application object in some way. To solve
E           this, set up an application context with app.app_context().  See the
E           documentation for more information.

pyvenv/lib/python3.8/site-packages/flask/globals.py:45: RuntimeError

Environment

Python version: 3.8.3
Flask version: 1.1.2
Werkzeug version: 1.0.1

Additional Reference https://bugs.python.org/issue40805

This appears to be an issue with mock, as it's accessing attributes on the object before patching it. The g object proxies all access to the thread local, and that doesn't work if there's no active app context. That's why you get the RuntimeError. There's nothing Flask can do here, it's up to mock to provide a different way to patch that object.
Patching g doesn't make much sense to me. All it's supposed to do is point to whatever globals object is provided by the app context. There are other things that can be hooked into or patched to affect that object.

Right, so you should patch the globals object, not the proxy pointing at that object.

I think this will impact more than just flask.g when people start moving up to python 3.8.  Their argument is that getattr is supposed to raise an AttributeError but this raises a RuntimeError.  For my purposes, I'm just going to pass the database connection into my resource.  For the few cases that remain where I have to unit test where flask.g is involved, I will properly establish the context in the test.

Yeah I see this also happening when patching the request global
This bug happens because flask overrides getattr. The fix is probably that flask need to ignore getattr calls for func and return an Error instead of trying to start flask magic..
As a workaround set the spec attribute while patching (anything will probably work but using the correct value is best). This prevents triggering the async mock test.
@patch('flask.g', spec={})
def test_some_function(mock_flask_global):
assert some_function()

Thanks for the confirmation of what mock is doing. The solution, as I said above, is to patch the things backing g or request, then the proxies will point to the patched objects.


yank out versioned STB

as a backup to better-known libraries, libsixel vendors a copy of libstb, a header-only c++ image processing library. see #51 for the woes this brings. i think we ought yank it. maaaaaaybe we leave in support for use of STB, but only as a system library for sure.

calling this a bug because, unlike some people, we consider a vendored import an error.

@ctrlcctrlv , any thoughts on this?


fix: ockam_vault requires rustcrypto feature for p256

Related issue & comment: https://github.com/build-trust/ockam/issues/3661#issuecomment-1508089713
Current behavior
ockam_abac fails to build docs.
There's currently a FIXIME for this feature and when default-features=false is enabled or only std is enabled it fails to build the ockam_abac crate.
https://github.com/build-trust/ockam/blob/6d5799608ac5ce2e039db6411e7c2f5280f44df6/implementations/rust/ockam/ockam_vault/Cargo.toml#L66-L67
Proposed changes
enable rustcrypto features for std by default in ockam_vault
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

@etorreborre I believe a better fix should be in place for this feature as right now it will still fail building if you just use default-features=false


Remove integration.GHGistsSpec

Codecov Report

Merging #151 into master will decrease coverage by 0.7%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   87.63%   86.92%   -0.71%
==========================================
  Files          36       36
  Lines         566      566
  Branches        2        2
==========================================
- Hits          496      492       -4
- Misses         70       74       +4

Impacted Files
Coverage Δ

...src/main/scala/github4s/free/algebra/GistOps.scala
0% <0%> (-100%)
:arrow_down:

...cala/github4s/free/interpreters/Interpreters.scala
76.47% <0%> (-2.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd71476...d56d37f. Read the comment docs.


meson: remove obsolete and blocking patch

Motivation for this change
meson is now (in staging) upgraded to 0.48.2 which includes the patch causing the build to
fail.
The patch snuck in when merging https://github.com/NixOS/nixpkgs/pull/46020
cc @jtojnar
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Thanks.


run_all_experiments: fix coverage sync and wrong aggregate coverage gains measure

/gcbrun exp -n d-cov-40 -b comparison -ns 3 -rd

/gcbrun exp -n d-cov-41 -b comparison -ns 3 -rd

Experiment is looking good: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-09-25-645-d-cov-41-comparison/index.html
There is a minor discrepancy because the textcov in the comparison includes some of the harness source code, which makes the number slightly off. I'll fix that in a later PR as we need the benchmark to be around in the workdir -- which would have some separate benefits in and of itself in the form of making the results folder self-contained.


Add more lenient parsing (DM XML scraper workarounds)

DM XML Scraper seems to not understand ref_... tags and puts them verbatim.
To have an easier time to diff clusters, add logic to understand a small common subset of these references inluding list access.
This is still not ideal as scraper not understanding refs means that it does not understand ref strings/octets and does not set sizes correctly as a result (e.g. https://github.com/csa-data-model/projects/issues/368) however overall this should make our life easier when diffing.
Changes:

understand ref types for types
understand ref types for lists using refs
Add additional logic for canonical naming ... still unclear if this is great as we have different rules between attributes and struct members it seems (yikes ... this needs a followup), but at least added some code logic starts.
Unit test covering these code paths.

fast track because basic tooling changes only.


Build check highlights .all-contributorsrc is a hidden file

This is causing a build fail check on PRs


[frontend] detail view, part 2

This completes the detail view by adding information about flavors. (There's stlll a few #TODO notes -- I'd like to merge this nonetheless for now so that all data is finally visible on the site. I'd fix those later.)
Also, I've updated the scheme list on the start page. It now a) shows some basic info (category, description, nist round), b) links to the scheme's detailed view. This includes some code restructuring, mainly using the (now global) SCHEME_TYPES dict that assembles some data we need everywhere (like mapping ct_sig to either ct or sig).

Fixed your remarks.  Hope you can cope with that :)


[BC Idea]: Shopify: Save and expose Product Creation Errors

BC Idea Link
https://experience.dynamics.com/ideas/idea/?ideaid=9f0096c1-f9c4-ee11-92bd-000d3a058698
Description
At the moment, the Shopify Connector for Dynamics 365 Business Central does not have error handling on Product Sync (Creation in BC). As an end user, BC Items may not be created, and the error message is only available using VS Code debugger.
The Shopify Products page should have an Error Message field, like Shopify Orders, so that users are able to handle errors in product creation without being dependent on BC Developers.
The hidden error message is stored in variable ErrMsg: Text in codeunit 30185 "Shpfy Sync Products"
I will provide the implementation for this BC Idea

[X] I will provide the implementation for this BC Idea

@AndreiPanko / @onbuyuka, could you triage this idea, please?

@eivindgiske
I understand your scenario is about converting imported Shopify Product to Item in Business Central. We haven't heard any feedback about that (except number series to run out of numbers).  Would be interesting to learn where do you see errors?
Also there is no action to create item from product (variant), only mapping. So once user sees the error and solves the underlying bloker (changes no series), what is the action for them to take?

Hi @AndreiPanko.
We have implented BC onto an existing Shopify environment, and have used a setup where Shopify (and PIM) are Master for Product information.
Using this setup in BC Shopify Shop, the following business logic will execute.

Sync Item: From Shopify
Auto Create Unknown Items: TRUE

Report _"Shpfy Sync Products" will execute Codeunit "Shpfy Product Import" which in turn will evaluate whether an item exists or not, and execute Codeunit "Shpfy Create Item" if an item is unknown to BC. You are correct, there is no Action on the Page Shopify Products to do this manually, but it runs on the product sync.
There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.
I cannot see why a partial error handling has been implemented, but is not stored on the Shopify Products record, and we urgently need this in place.

There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.

Good point about extensibility. @JesperSchulz  what are the next steps?

We approve this issue and wait for a PR 🙂


Recursion causes trouble

So, uhh, we (#docker-maintainers) did a bad thing: https://botbot.me/freenode/docker-maintainers/msg/34051580/ :angel:
I wasn't sure exactly which repo to report on, but this one seemed the most appropriate for this specific issue of BotBot recursing on its own comments.
See https://github.com/docker/docker/issues/11360 for the issue we used to cause such trouble -- we eventually had to kick the bot, so help getting it to rejoin would be appreciated, and I've changed the title of that naughty issue back (as you can see in the logs on it) to make sure we don't do it again.
Relevant log bits:
19:47:30 +icecrime:> !m gh#11360
19:47:31 +[d__d]:> !m Sorry I gotta test this: https://github.com/docker/docker/issues/11360
19:47:32 +[d__d]:> You're doing good work, gh#11360!
19:47:33 +[d__d]:> You're doing good work, Sorry I gotta test this: https://github.com/docker/docker/issues/11360!
19:47:34 +[d__d]:> !m Sorry I gotta test this: https://github.com/docker/docker/issues/11360
19:47:35 +[d__d]:> You're doing good work, Sorry I gotta test this: https://github.com/docker/docker/issues/11360!
...
19:51:45 @tianon:> !m gh#11360
19:51:45 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:46 +[d__d]:> You're doing good work, gh#11360!
19:51:48 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:48 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:49 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:50 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:51 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:53 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:53 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:54 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:56 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:56 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:51:57 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:58 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:51:59 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:00 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:01 @tianon:> oops ;)
19:52:01 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:02 +duglin:> oh please!
19:52:02 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:04 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:05 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:05 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:06 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:08 +[d__d]:> You're doing good work, Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360!
19:52:08 +[d__d]:> !m Sorry I gotta test this (gh#11360): https://github.com/docker/docker/issues/11360
19:52:09 +duglin:> LOL
19:52:09  <-- tianon has kicked [[d__d]] from #docker-maintainers ([d__d])

Sorry, I just had the urge to try something stupid after a long day, and didn't want to cause any trouble :-(

bug of the year :dancer:

Man, that's neat.
It's late where I am now but I'll help you get your bot back tomorrow and figure out how to get this fixed soon. Ideally BotBot just ignores himself. Have to tackle this ASAP.

@mtrythall cool, thanks; getting our bot back tomorrow is just fine :+1:
Glad you're not mad! :innocent:


api 502 bad gateway

2022-06-01 20:30:37 INFO (MainThread) [custom_components.mila.milacloud] get https://api.milacares.com/mms/appliances/meta
2022-06-01 20:30:39 INFO (MainThread) [custom_components.mila.milacloud] 502, message='Bad Gateway', url=URL('https://api.milacares.com/mms/appliances/meta')

This is a duplicate of #7


[MINOR][SS][DOCS] Update join type in stream static joins code examples

What changes were proposed in this pull request?
Update join type in stream static joins code examples in structured streaming programming guide.

Scala, Java and Python examples have a common issue.
The join keyword is "right_join", it should be "left_outer".
Reasons:
a) This code snippet is an example of "left outer join" as the streaming df is on left and static df is on right. Also, right outer    join between stream df(left) and static df(right) is not supported.
b) The keyword "right_join/left_join" is unsupported and it should be "right_outer/left_outer".

So, all of these code snippets have been updated to "left_outer".

R exmaple is correct, but the example is of "right_outer" with static df (left) and streaming df(right).
It is changed to "left_outer" to make it consistent with other three examples of scala, java and python.

Why are the changes needed?
To fix the mistake in example code of documentation.
Does this PR introduce any user-facing change?
Yes, it is a user-facing change (but documentation update only).
Screenshots 1: Scala/Java/python example (similar issue)
Before:

After:

Screenshots 2: R example (Make it consistent with above change)
Before:

After:

How was this patch tested?
The change was tested locally.

cd docs/
SKIP_API=1 jekyll build
Verify docs/_site/structured-streaming-programming-guide.html file in browser.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #130641 has started for PR 30252 at commit b03f87f.

Test build #130641 has finished for PR 30252 at commit b03f87f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130641/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35251/

Thanks for the contribution! Merged into master, branch-3.0, branch-2.4 respectively.

master: https://github.com/apache/spark/commit/e66201b30bc1f3da7284af14b32e5e6200768dbd
branch-3.0: https://github.com/apache/spark/commit/c43231c6cd2d38fb9e6c6435ca08b735c9aacb61
branch-2.4: https://github.com/apache/spark/commit/868472040a9eb67169086ed0fab0afcbbbd321f9

Please note that the website will be updated separately - the change will be reflected in future releases.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35251/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35251/
Test FAILed.