MetaSeq on non-traditional files that have already been binned?

I have written a new fast medium/diffuse area chip-seq caller in Python. It uses a binning strategy and one of the files it produces contains the island counts:
Chromosome Bin Chip1 Chip2 Input1 Input2
chr1 11550 3 6 1 2
chr1 11600 4 5 0 2
...

I'd love to be able to make it easy to use meta-seq with my chip-seq caller to produce various graphs. With the data above I could regenerate four bed files* so that using meta-seq would be straightforward, but that would be needlessly time-consuming. Therefore I'll look into creating an adapter for data like above.
What I want is a file adapter that iterates over the cols of the dataframe and returns one signal object for each.
What does the genomic_signal objects look like? I imagine it is pretty similar to my table above...
I could not find them in the test suite: https://github.com/daler/metaseq/blob/master/metaseq/test/test.py
I guess I could play around metaseq with for half a day and find out, but I am not used to reading OO code so it would be hard for me. Would love some comments on strategy for/ feasibility of creating genomic_signal objects for data like above, if you find have the time.
*For sample 1 I'd make a bed with the following:
chr1 11550 11600
chr1 11550 11600
chr1 11550 11600
chr1 11550 11600
chr1 11600 11650
...

It seems like there are two readers that it might be possible to use:

the deseq reader or
the dataframe reader.

Can any of these be used as is? If not, what do I need to change about my data to use them?
It seems that I was mistaken about the possibility of creating bed files; my binned files do not contain strand info. It seems like using one of the two readers above or creating my own reader is the most straightforward option.
Better example of my data than the one shown above:
Chromosome	Bin	../data/bed/Exp2_0_Polymerase_II.bed.gz	../data/bed/Exp1_0_Polymerase_II.bed.gz	../data/bed/Exp2_0h_Input.bed.gz	../data/bed/Exp1_0h_Input.bed.gz
chr1	10000	1	3	4	3
chr1	10050	0	2	1	2
chr1	10100	1	4	4	2
chr1	10150	3	2	4	1
chr1	10200	5	2	2	3
chr1	10250	3	0	1	2
chr1	10300	3	1	2	1
chr1	10350	1	4	1	4
chr1	10450	2	4	2	2

It would not surprise me if this is very close to one of the formats metaseq already knows how to parse.

Come to think of it, metaseq would at least need some gene info for producing the heatmaps.
I'm guessing metaseq needs one array per input file per tss. So for example for Sample1 you'd have number_of_tsses arrays where each array is tss_region_length/bin_length long.
If I create a dict like:
{"tss1": [0, 2, 1, 8...],  "tss2": [42, 50, 68, 74...],  "tss3": ...}
per data-column (../data/bed/Exp2_0_Polymerase_II.bed.gz, ../data/bed/Exp1_0_Polymerase_II.bed.gz etc.)
what would I then need to make those nice tss-plots/heatmaps from example 1? I think I'd like to incorporate the creation of those graphs in my chip-seq caller with a --graph option (reminding people to cite your paper of course).
But if meta-seq has code that can work with the type of data shown in the two previous posts that would be even better. It would have to pick out the bins from tss-regions by itself, though.

Hi Endre -
Thanks for taking an interest.
First some background to orient you . . . the main goal of metaseq is to get genomics data into Python data structures (mostly numpy.array and pandas.DataFrame).  In the Example 1 case, the input is a BED file of TSSes containing windows to look within and a BAM file. The genomic_signal object  is initialized simply by pointing to some interval-based genomic data (BAM, BED, bigBed, bigWig; BAM in this example). Its local_coverage function is responsible for accepting an interval and returning a numpy.array representing the values for that interval (linearly interpolated into bins, if they were also specified).  An array is built by querying the genomic data for each interval (here, a TSS provided in the BED file) in parallel.  The specific way in which a genomic_signal object extracts data from the underlying file depends on the filetype_adapter.
So really the question is how to get your data format into a numpy.array.  Or more generally, how to make this format useful for various downstream tools (not just limited to metaseq)?
If you have chrom, start, end fields as the first 3 columns, then you can use bedtools/pybedtools for interval manipulation and pysam with tabix for indexing. You can also create separate bigWig files for each sample (have to go bedGraph -> bigWig with cut -f 1,2,3,4 and cut -f 1,2,3,5 etc).
chr1    10000   10050   1   3   4   3
chr1    10050   10100   0   2   1   2
chr1    10100   10150   1   4   4   2

Option 1: create one bigWig file for each column, and use metaseq and other downstream analysis tools (like deepTools) as-is.
Option 2: A genomic_signal object could be initialized with this data file and bgzipped and tabix-indexed if needed. The object should also store the column you care about. Then, when its local_coverage is provided with an interval, it does the tabix query to extract all lines intersecting that interval. For each line, it extracts the column you care about.
It would be important to call local_coverage with the use_score=True argument to return the score rather than the presence/absence (as is the case when using BAM).
In benchmarks when creating arrays, bigWig is substantially faster when creating arrays from tabixed files. My hunch is that the initial step of bigWig creation will likely be offset by performance gains in downstream processing.
Specifically for a TSS plot, you would have to provide the TSSes to represent each row of the array. It's these intervals that need strand if you want to talk about upstream and downstream. You don't need strand in the underlying data file.
Side note 1: If you end up digging through the code, the perhaps-odd arrangement of the code is for parallel performance -- it was my first heavy use of multiprocessing in a module, and had to organize things this way in order to pickle functions across processes. I'd like to find time to simplify it if possible, but it's low priority at the moment.
Side note 2: I'd love to try out your peak caller (existing ones leave a lot to be desired, esp for broad domains). I can't find it in your repos though!

Thanks for the explanation.
Without reading your paper, just the docs, we got the impression that it was for creating those two very pretty graphs (there are two of us w/different projects looking into using metaseq for those TSS-graphs). I guess there is a lot more to metaseq then and that its main purpose is different/broader. Do I understand it correctly if it is for reading and using genomic data in Python, speedily and easily (with many additional conveniences)?
It seems like creating bigwig-files is the way to go then, especially since that format can then be used with other tools. Hadn't heard about deepseq, but it looks great.
The code looks good to me, but if you are redoing the parallelism, you might want to look into joblib. It has a parallel function with many conveniences, such as sane error messages and cleanup.
I'll send you an e-mail about the ChIP-seq peak caller.

Right, it's for getting genomic data into Python. It's a library of tools to build your own visualizations, rather than a CLI to produce canned plots. Enough people ask about a CLI that I may add one, but deepTools is probably better for that kind of task.
You can just scroll through the figures in the paper for more examples -- they are all unmodified, straight from metaseq. There are more in the supplemental PDF, too.
I agree, joblib is the way to go. Memory.cache is really helpful for working with lots of large numpy arrays on disk, too.

Thanks. Meta is a good name, this is a tad abstract.

Btw, there are a few quirks with 'Memory.cache' that in my view makes it less than ideal for inclusion in software published for others to use:

uses a lot of storage space
cannot delete just parts of the cache
impossible to inspect the cache

Hmm, I haven't hit the space problem yet, and I've only been using it for simple cases. Good to know, thanks.


Not firing renderEnd on lineChart

Issue encountered on Chrome and Firefox using d3 v3.5.17, nvd3 v1.8.4, and react v15.3.2.  Ready and renderStart events fire normally.  RenderEnd simply never fires.

@jayflaherty75 NVD3 render_end event is not consistent across charts. I need to find some time to create a PR against nvd3 repository.

If you can give me some specifics on what needs to happen in NVD3 to get renderEnd() to fire, I may be able to help.
Thanks,
Jason

Same here, i would like to know if there is a fix to know when the render is completed.

@Sharpounet @jayflaherty75 Sorry it's been awhile, I've been pulled in another project. I will take a look today and try to provide a solution.

Thanks a lot @topicus
I will take a look as well

@topicus - Any progress on this in the last 7 days? I need renderEnd to fire for LinePlusBarChart - otherwise I could take a look and provide PR if you wish..

@topicus PR created as a merge commit - my fix enables at least linePlusBarChart to fire the renderEnd event.

It's ok for linePlusBarChart but the problem still exists for lineChart.
I'm wondering if the problem is to call the dispatch on "dispatcher = this.chart.lines.dispatch;" and not "dispatcher = this.chart.dispatch;"... I'm a bit lost.


All groups lost after Firefox crash

Today FF has crashed because of memory overflow, then restarted normaly with all tabs from active group. After couple of hours I noticed that all groups are gone so as all backups. I can see only  backups made today after the crash and they all emty obviousy.
It's really sad to lose the data and the backup at once.

I am sad you lose everything. However, your problem seems coming from
Firefox. The extension is only using the storage provided by Firefox. Back
ups can be removed only manually or when they exceed the max numbers. So,
it seems Firefox wipe off the data.
Are you using other extensions ? Did you lose also data ?
This is the reason there is an alternative back up system that download the
file.
Also, you can export your groups to save them out of Firefox.
Le 30 mars 2018 18:10, "oloendithas"<EMAIL_ADDRESS>a écrit :
Today FF has crashed because of memory overflow, then restarted normaly
with all tabs from active group. After couple of hours I noticed that all
groups are gone so as all backups. I can see only backups made today after
the crash and they all emty obviousy.
It's really sad to lose the data and the backup at once.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Morikko/sync-tab-groups/issues/101, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHeAFMr-WCWpqpGKwcWDMT2oSOZfdy2Gks5tjlkAgaJpZM4TB29E
.

Not sure if other extensions have any data missing of which I would noticed, Gmail Checker ask to press refresh or something so maybe yes, FF lost all local storage.
Regarding backups, maybe it would be better to rename the Local backup to, let's say, History? Because the backup word it's slightly missleading here, since it's stored in same place.
Anyway, thanks again for the great addon.
Cheers

Yes, you are right renaming or adding some information about the storage
location could help.
Also, you might open a bug on bugzilla to help Mozilla to fix Firefox.
Le 30 mars 2018 20:52, "oloendithas"<EMAIL_ADDRESS>a écrit :

Closed #101 https://github.com/Morikko/sync-tab-groups/issues/101.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Morikko/sync-tab-groups/issues/101#event-1550197733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHeAFHAtFO0ncpMBqLxpMaayAfI_viBuks5tjn7kgaJpZM4TB29E
.


Package request: extdlib

Extended C library utility

The extdc core library is made with care and is meant to simplify and improve C development.

It is sort of a extended standard library for core with many "modern" features, like fibres, results, unit tests, etc.
I think it has the potential to greatly improve the usability of C for modern programs and would like to start using it in my personal projects. As I do not have any experience with packaging libraries for Nix I thought I might just open a request.
The project's README puts an emphasis on portability, so I think darwin builds should not be an issue, but I don't have a darwin system, so I am not able to try.
Metadata

homepage URL: https://github.com/cute-engineering/extdlib
source URL: https://github.com/cute-engineering/extdlib
license: mit
platforms:  linux

The project looks too cute.
However I am afraid it doesn't match the criteria for inclusion.
https://github.com/NixOS/nixpkgs/tree/master/pkgs#quick-start-to-adding-a-package

Is the package ready for general use?

The project have only six commits.
The website does not exist yet

Does the project have a clear license statement?

Yes.

How realistic is it that it will be used by other people?

As I have seen, the code is too young.
4 starts, 1 eye, 0 forks.
No issues, no PRs.

Are you willing to maintain the package?

I am interested. However I believe it should be on NUR first.
I will reactivate my personal NUR and include it.

Is the package ready for general use?

* [The project have only six commits](https://github.com/cute-engineering/extdlib/commits/main).

* [The website does not exist yet](https://cute.engineering/)

I see how this might be a deal breaker, but it seems like the code was previously part of the Brutal OS.

Does the project have a clear license statement?

Yes.

How realistic is it that it will be used by other people?

As I have seen, the code is too young. 4 starts, 1 eye, 0 forks. No issues, no PRs.

Yeah that is true, it does not seem to be as mature, as I thought it to be.

Are you willing to maintain the package?

I am interested. However I believe it should be on NUR first. I will reactivate my personal NUR and include it.

It would be great to have it in NUR. I would have created an overlay for it myself, however I have no clue how to package libraries on Nix. I would be very greatful if you could provide the overlay, let me know :)

In a certain sense, package a library is not too different from packaging another piece of software. The problem is how to use it after installed - pkg-config, explicit paths for GCC command line...


Update Z/OS dev terraform

Have 2 variants:

have simplified environment (1 vpc, with vpn, both VSI and cluster in the single vpc)
edge + dev vpcs (current automation)

needs automation
needs terragrunt

I just pushed updates for the zos-dev architecture that simplifies with the Z VSI and cluster in a single vpc (instead of the FS multi-vpc structure).   It’s not quite done yet, but i wanted to get the refactoring to a point that its demonstrable for this week’s demos.
This still needs some cleanup, needs automated testing, and needs to use the solution bom format (which will also generate terragrunt).
https://github.com/IBM/automation-ibmcloud-infra-zos-dev


feat(connector): [Zen] Add Latam Payment Methods

Type of Change

[ ] Bugfix
[X] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Add New Latam Payment Methods :

Boleto
Efecty
PagoEfectivo
Pix
Pse
RedCompra
RedPagos

Additional Changes

[X] This PR modifies the API contract
[X] This PR modifies the database schema
[X] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Curls
https://docs.google.com/spreadsheets/d/1vR2xLoKS_yUNFnpS3Xc9HXI8jzn3Gt2tFGjD26oKEtU/edit#gid=300101300
Checklist

[X] I formatted the code cargo +nightly fmt --all
[X] I addressed lints thrown by cargo clippy
[X] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

@SamraatBansal As discussed voucher should go in to voucher payment method, Please add sample curl for the new payment methods, and add tested scenerios

Please fix the failing CI checks

@SamraatBansal Please add sample curl and UI test in this PR,

@SamraatBansal Please add sample curl, test screen shot and UI test in this PR,

These comments were not yet addressed

Configs changes are still missing in config/config.example.toml, config/docker_compose.toml and loadtest/config/development.toml


How to overwrite the post resource ?

Hello,
As a subject, I do not know how to customize your post resource?
Could you make guidance?

I support it, plus I also have a question about ID, why the next ID is reserved when transferring to Draft, that is, You transfer news from ID 10 to draft and display then the next news will be from ID 12, since the draft took 11 ID for itself


The following message: DEFMSG_COMBAT_ATTACKO (%s is attacking %s!) …

will use the EMOTE_DEF_COLOR setting found in sphere_msgs.scp instead of always use the gray color hue.
Moved methods Skill_Snoop_Check, Skill_Snooping, Skill_Stealing from CCharFight.cpp to CCharSkills.cpp
Moved the code related to the Focus skill from method Stat_Regen (CCharStat.cpp) to new method Skill_Focus (CCharSkills.cpp)

Skill_Focus needs to return an int (like the other Skill_* methods), because it needs to be able to return signed values:
-SKTRIG_QTY = no chance. and not a crime
-SKTRIG_FAIL = no chance and caught.
0-100 = difficulty = percent chance of failure.

If i return -SKTRIG_QTY i return -12 right? If yes, i need to find a different way to implement the function :o

It's just a conventional exit value for the skill function, like
-SKTRIG_ABORT, (they're all negative afair) and it tells that the
method/skill stage ended, in which state and why. You can just test if
Skill_Focus(..) > 0, then sum the return value
Il 26 mag 2018 12:41, "drk84"<EMAIL_ADDRESS>ha scritto:
If i return -SKTRIG_QTY i return -12 right? If yes, i need to find a
different way to implement the function :o
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Sphereserver/Source-experimental/pull/107#issuecomment-392253013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOWhJM6AOQGeDZ2wKSlRaY6sgupRkhUzks5t2TE-gaJpZM4UOTlm
.


docs: move to table of features for leptos

This is a cosmetic change and may be opinionated. I find tables like this to be more readable.
For some it can be hard to parse without visual organization. No issue at all if it does not fall into line with your view for the docs.
I would not mind unifying the other crates if merged
here it is rendered on my local machine without any styles that docs.rs might add.

I like this overall, and thank you for it! I would prefer to keep the original wording about using one of csr, ssr, or hydrate.

Hey! I see your recommendations and you are correct. I'm a little overwhelmed with work at the moment but plan to revisit and correct this when I have the time. Thanks for the feedback.
I am going to move this to a draft for now.


Inserting Bulk Data of a dataframe into SQL Server Quickly

Issue
I have been trying to insert data from a dataframe in Python to a table already created in SQL Server. The data frame has 90K rows and wanted the best possible way to quickly insert data in the table. I only have read,write and delete permissions for the server and I cannot create any table on the server.
Below is the code which is inserting the data but it is very slow. Please advise.
###Code Used as Below
import pandas as pd
import xlsxwriter
import pyodbc
df = pd.read_excel(r"Url path\abc.xlsx")
conn = pyodbc.connect('Driver={ODBC Driver 11 for SQL Server};'
'SERVER=Server Name;'
'Database=Database Name;'
'UID=User ID;'
'PWD=Password;'
'Trusted_Connection=no;')
cursor= conn.cursor()
#Deleting existing data in SQL Table:-
cursor.execute("DELETE FROM datbase.schema.TableName")
conn.commit()
#Inserting data in SQL Table:-
for index,row in df.iterrows():
cursor.execute("INSERT INTO Table Name([A],[B],[C],) values (?,?,?)", row['A'],row['B'],row['C'])
conn.commit()
cursor.close()
conn.close()

This is the (more or less) standard recipe:
import urllib

import pandas as pd
import sqlalchemy as sa

df = pd.read_excel(r"Url path\abc.xlsx")

connection_string = (
    'Driver={ODBC Driver 11 for SQL Server};'
    'SERVER=Server Name;'
    'Database=Database Name;'
    'UID=User ID;'
    'PWD=Password;'
    'Trusted_Connection=no;'
)
connection_uri = f"mssql+pyodbc:///?odbc_connect={urllib.parse.quote_plus(connection_string)}"
engine = sa.create_engine(connection_uri, fast_executemany=True)

# Deleting existing data in SQL Table:-
with engine.begin() as conn:
    conn.execute(sa.text("DELETE FROM datbase.schema.TableName"))

# upload the DataFrame
df.to_sql("TableName", engine, schema="SchemaName", if_exists="append", index=False)

FWIW, I gave a few methods of inserting to SQL Server some testing of my own. I was actually able to get the fastest results by using SQL Server Batches and using pyodbcCursor.execute statements. I did not test pandas dataframe to_sql / sqlalchemy, I wonder how it compares.  Will sqlalchemy send batches or is it executing 1 by 1?
Here's my blog on the testing I did:
http://jonmorisissqlblog.blogspot.com/2021/05/python-pyodbc-and-batch-inserts-to-sql.html

Will sqlalchemy send batches or is it executing 1 by 1?

With fast_executemany=True pyodbc will prepare the SQL statement (sp_prepare) and then use a mechanism called a "parameter array" to assemble the parameter values for multiple rows into a memory structure and send them all at once. SQL Profiler shows the activity as an sp_prepare followed by an sp_exec for each row, but that does not necessarily mean that the values are sent over the network separately for each row.

Will sqlalchemy send batches or is it executing 1 by 1?

With fast_executemany=True pyodbc will prepare the SQL statement (sp_prepare) and then use a mechanism called a "parameter array" to assemble the parameter values for multiple rows into a memory structure and send them all at once. SQL Profiler shows the activity as an sp_prepare followed by an sp_exec for each row, but that does not necessarily mean that the values are sent over the network separately for each row.

SQL Server profiler was showing fast_executemany running prepared statement inserts one by one in my testing.

SQL Server profiler was showing fast_executemany running prepared statement inserts one by one in my testing.

Yes, because that's how prepared statements behave at such a low level. At some point each row has to be inserted. The difference between fast_executemany=True and fast_executemany=False is that

fast_executemany=False will result in individual sp_prepexec calls, resending the SQL command text each time, while
fast_executemany=True will send the SQL command text once (to be prepared with sp_prepare), send the parameter values in a big binary "blob", and let the SQL Server instance process each row as an sp_exec call.

In case you're interested, I did a quick comparison of to_sql() vs. bcp for a DataFrame with 5 columns x 1_000_000 rows:
to_sql() with fast_executemany=True
t0 = perf_counter()
df.to_sql(table_name, remote_engine, index=False, if_exists="append")
print(f"to_sql(): {(perf_counter() - t0):.0f} seconds")
# to_sql(): 259 seconds

bcp
t0 = perf_counter()
csv_file_name = r"C:\__tmp\df_dump.csv"
df.to_csv(csv_file_name, sep="\t", index=False)

uid = "sa"
pwd = "_whatever_"
cmd_args = (
    f"bcp dbo.destination IN {csv_file_name} "
    f"-S <IP_ADDRESS> -U {uid} -P {pwd} -d test -F 2 -c"
)
subprocess.call(cmd_args, shell=True)
print(f"bcp: {(perf_counter() - t0):.0f} seconds")
# bcp: 70 seconds

Pandas provides a function wherein you can execute db query for all rows i.e. executemany
First create a list of values from the dataframe :
records_to_insert = df.values.tolist()

Check the status of DB connection, it must be successful before applying insert query.
And eventually create the insert query function as follows (for e.g. you have two columns of Name and Age ):
def insertion_query(dict_db):
    insert_query = """
    INSERT INTO {0}
    (
    [Name],[Age]
    )
    VALUES
    (?,?)
    """.format(str(dict_db["DB_PythonTransactions_TableName"]))
    return insert_query

After that executemany() can be used in main to insert all the data to database.
executemany(insert_query,records_to_insert)

For Reference : YT Video : DataFrame to DataBase Using Python

In addition to the "standard" method in the comment above (normal to_sql() with fast_executemany=True), users of SQL Server 2016+ can also use the custom to_sql() "method" here
https://gist.github.com/gordthompson/1fb0f1c3f5edbf6192e596de8350f205
e.g.,
    df.to_sql(
        "table_name",
        engine,
        index=False,
        if_exists="append",
        method=mssql_insert_json,
    )

which does not use fast_executemany=True and in some cases can provide even faster performance.

import pandas as pd
from sqlalchemy import create_engine
Define the DataFrame
df = pd.DataFrame({
'column1': [1, 2, 3],
'column2': ['A', 'B', 'C']
})
Define the connection string
server = 'your_server'
database = 'your_database'
username = 'your_username'
password = 'your_password'
connection_string = f'mssql+pyodbc://{username}:{password}@{server}/{database}?driver=ODBC+Driver+17+for+SQL+Server'
Create the SQLAlchemy engine
engine = create_engine(connection_string)
Write DataFrame to SQL Server
df.to_sql('table_name', con=engine, if_exists='replace', index=False)

The if_exists parameter can be set to:
'fail': Raise a ValueError if the table already exists.
'replace': Drop the table before inserting new values.
'append': Insert new values to the existing table.

??? What's the point of replying to a closed 1.5y-old issue?

??? What's the point of replying to a closed 1.5y-old issue?

not your bussiness


Port Addon alignment changes from Master

All changes have been ported and taken from: https://github.com/divio/djangocms-text-ckeditor/commit/a6069096fdac80931fd328055d1d615d168c33df
Changes include:

setup.py and various project files updated inline with other addons
Isort errors fixed and enabled in the test suite
Tests moved out of the package as per recommendations from python packages
Translations updated

Tested locally, looks good!

Thanks @adam-murray Appreciate it.


Xmpp notifications

Uff, again notification stuff...This pull request will introduce the possibility to send notifications to a Jabber/XMPP account. It's is a very basic implementation.
The logging is not optimal because the entries are named after the module that is used to handle the XMPP part. Sorry, right now I don't know how to change that. Perhaps somebody could give me a hint.

Coverage increased (+0.03%) to 75.55% when pulling e34a1902dacfcee14a6800236043d892987d9656 on fabaff:xmpp into dfc50562a16243126effd2b6c97cbb3a536d2769 on balloob:dev.

Coverage remained the same at 75.54% when pulling 76fd70657ad1523eb2ef2797765d37bb97d48c58 on fabaff:xmpp into b6c88b1a6c79f7966b694399d2ee3b2bba0bddd6 on balloob:dev.


Pagination query task

Describe your changes :
I worked on the ..... because ...Table queries pagination issue

[x] Bug fix

fix :  #6239

@07Himank thanks for the PR. Can you please add tests in TableResourceTest https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-service/src/test/java/org/openmetadata/service/resources/databases/TableResourceTest.java#L1286 to test the pagination


Add screenshots + Short description.

It would be a good idea to add some screenshots and a short description for each profile so you can preview or know what to expect before trying it out or whatnot.

Thanks! I might add descriptions and pictures next week.
Meanwhile, feel free to create PRs for your lighting profiles and do the same. I'll be quick about reviews and merging.


Add policy section to docs

In an effort to consolidate knowledge spread out over time in various places on GitHub add a Policy section to CONTRIBUTING.md.
Add initial sections on import statements, errors, rustdocs,attributes, and licensing.

Possible other candidate for inclusion, info on SPDX e.g.,
Files should start with attribution and license information as follows:
// Bitcoin - Written by the rust-bitcoin developers.
// SPDX-License-Identifier: CC0-1.0

Neat! A good start. I'm sure others will chime in with things they think we ought to add.
We should require three ACKs for this PR.

We should require three ACKs for this PR.

If/when bors comes about we should consider if there is some way to flag PRs that require more acks.

I'd like some rules that require more acks based on files changed or so, if we have any critical code or policies. Might be reasonably easy to add.

Canonical license blurb, open under discussion still: https://github.com/rust-bitcoin/rust-bitcoin/pull/1138

Putting on ice until after release of 0.30.0

I'd like some rules that require more acks based on files changed or so, if we have any critical code or policies. Might be reasonably easy to add.

Just flagging that I took this PR off draft but have not actioned this comment of yours @Kixunil, not sure what to do about it?

Our current policy is roughly "if one of the 2 ACKers says that they want a 3rd ACK, then we do it". I wouldn't mind codifying this. But I can't think of a simple mechanical rule that would say "you need 3 ACKs if you touch this file" or something like that.

changes in force push:

added "Attributes" section
fixed typos
Added to #[non_exhaustive] in error:  // Add liberally; if the error type may ever have new variants added.

Soz @sanket1729, the rebase is just to remove leading patch that was from another PR. No other changes.

Will wait for @Kixunil to ACK on this before merging.

Changed to use a dummy FooBar type for rustdocs example.

Regarding parsing errors, I intend to write it down and open a discussion in URLO when I get a bit more time.

I don't know what the status of this PR is, do we want it:

merged?
closed?
left open to be re-visited at a later stage?

Leave it open, hopefully I write it up during weekend.

No sweat, take your time.

Here's the discussion: https://users.rust-lang.org/t/error-design-to-store-the-context-or-to-not/91815

Converting to draft to indicate not-mergable.

Note to self: Add to rustdoc section something about putting important info in the first few words of rustdoc heading.
https://github.com/rust-bitcoin/rust-bitcoin/issues/1920#issuecomment-1638173124

Force push just added import style policy, I'm still to see to review suggestions.

903b2074f8d3117dcd03b4f48a92726d7db0f272 looks good to me except:

I think the Errors section is out of date with what we want (do we still want to "only derive Debug?) but I'm not sure.
The docrs attribute can now be removed :)

Back to draft because this depends on https://github.com/rust-bitcoin/rust-bitcoin/pull/1743

Just removed the mention of check_pub_error instead.

Since @Kixunil is around I'll let him ACK as well before merging.

On ice until next release.

Is it worth adding mention of how silent overflows should be handled (or not handled)? https://github.com/rust-bitcoin/rust-bitcoin/issues/2086

I like the idea of having a project-wide overflow policy. But I have no idea what such a policy should be :). Feerates have different rules from amounts, which have different rules from sizes, etc.

cc @sanket1729 @Kixunil we need a second ack here


会高亮实例化根元素以外的元素。

实例化的时候，传入容器根元素。
错误：划线根元素以外的元素，也会导致高亮。
期望：只应该高亮容器根元素的后代节点。
复现：连接 展示的网站也有此问题。

也许这可能会有所帮助，我修复它的方法是在初始化期间设置 exceptSelectors: [] 选项以排除外部元素我还确保用作容器的 DOM 元素已添加到页面中，因为如果找不到它并且它是 等于 null，荧光笔将使用整个文档作为后备。
Maybe this could help, the way I fixed it is by setting the exceptSelectors: [] option during initialisation to exclude external elements also I made sure the DOM element used as container has been added to the page because if it is not found and it is equal to null, the highlighter will use the whole document as fallback.

传入根元素的HTMLElement但是依然会高亮根元素之外的节点


doc/hooks/aws-c-common: init

Part of #341479
Requesting a review from @r-burns (creator of the hook and package maintainer) and @orivej (package maintainer).

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Oh interesting. Thanks for the backstory ❤ I've made a note about it being a workaround, along with a link to the upstream issue.


"shit" judgement has disappeared

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
i saw that something strange is happened, when I spam, the "shit" judgement won't counting and it's always zero, I went in the option and there wasn't "shit" judgement
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

here is the image

that's because for a shit, you have to hit a note at a window WORSE than the bad window

yeah this is more of a case of stupidity


/money pay doesn't work

the .transfer perm is given to all players - for some reason pay doesn't work at all even in all cases like when in the vault chest or in the inventory! When I do /money pay  Player - it says it has successfully sent 0.0 (My Currency) to them - I do not know why it does this. Has anyone fixed this? Or is it a permission issue?

It should be fixed on latest :) 9912a6a159e771075122fc32e13792f088c17917


logout but logged in is true

I ended up doing "logout" but "logged in" is still true.

One thing, "shield" is beta or release?

See here for the answer. Also, if possible, please send your questions from this section.

Never seen, thank you.

https://github.com/codeigniter4/shield/blob/45f7522e597fee438767f6dfdfab0d440181dcb6/src/Authentication/Authenticators/Session.php#L704-L712
current: the $this->user receives is always null.
to
public function logout(): void
{
    $userId = $this->getSessionKey('id');
    $this->user = $this->provider->findById($userId);

    if ($this->user === null) {
        return;
    }

    ...
}

modify: I think it would be useful to check if there is a session with id.

I confirmed the bug, and sent a PR: #231


App crashes due to network issue

Studies have shown that mobile apps are prone to crashes due to a network issue, mainly because successful network calls return unexpected or no data. And we found that when this app (version 1.0.11)'s network returned data is null or some fields are null (JSON format), the app has crashed. the specific crash information is as follows:

java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:309)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
at java.util.concurrent.FutureTask.run(FutureTask.java:242)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.UnsupportedOperationException: JsonNull
at com.google.gson.JsonElement.c(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.data.SearchResultsBuilder.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.data.SearchResultsBuilder.b(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.Fetch$1.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.Fetch$1.b(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.FetchUrl.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.FetchUrl.doInBackground(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
... 4 more

I think that this bug is caused when the network meets specific conditions. I also hope that the developer can have a look at this issue. Thank you.

The developer has seemed to be inactive for quite some time unfortunately..


Notify the context of instructions that are being erased

Fixes use-after-free error in RemoveDuplicatesPass (#1004)
Removed instructions were being left in the DefUseManager despite having been erased.

Rebased and pushed into master as 0cae89e79e


pkgpanda building on windows

High-level description
Make pkgpanda build packages on Windows. This is done by:

porting a set of bash scripts to powershell
Add global constants for directory paths that vary between windows and other platforms
Copy configuration files that are going to be very different between windows and other platforms
create a windows docker file for building the packages
created a windows variant of the packages directory.
achieved about 80 tox test so far on windows

note This runs build_local.ps1 to completion without problems. What is produces is not finished and will be the subject of future check-ins.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-1899 Build dcos in a windows environment..

Related tickets (optional)
Other tickets related to this change:

none

Checklist for all PRs

[X] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

you commented that we need to get CI set up before you can accept this change. This is a large porting effort that we believe needs a multi-check-in work-flow to achieve. We will not have all tests up and working in one check-in. We are working on enabling a CI, and will hopefully have that in a week or so, but really do not want to block our windows check-in for this.
Mesos, for example, is another instance of a large porting effort. A lot of functionality does not work yet on windows and a lot of tests are commented out. We have many people working on enabling those tests, and fixing the functionality that is missing to achieve that. We believe the DCOS port is similar and we have been working with that way of doing things in mind.
 Not pushing this means our code base falls behind master quickly and it is hard and time consuming to keep rebasing to keep them in line,
We will work through some of the issues that you mentioned above, however for some of the bigger parts we ask that we can generate issues associated with those architecture design questions and work with you on then, while working on getting the current version checked in to allow others on our team to more easily work on getting specific packages and CI work done.

I cannot reply easily to overall review comments.
1, I needed platform specific sections because the python version is different or something and so it does not work. therefore I made it work like this. I have asked for help in this matter and got very little. this is what I was able to get working with the smallest changes possible.
2, this entire thing is a work in progress. we seem to have a difference in what that means.
3, we have talked about the helpers and pointed out numerous times the problems we have with them when using things like rmtree. This solution was the most complete and functional. A great amount of time has been spent getting these right. They do actually work finally, after many iterations, some of which were the os helper libraries. I would prefer to not waste more time trying to go back because this solution works.

We have talked about the helpers and pointed out numerous times the problems we have with them when using things like rmtree.
Then please leave a comment explaining the decision.

great! now we have a merge conflict so we will need to rebase!

Merge conflicts and rebasing are a fact of life when you're contributing large features to actively developed software. Here's the merge conflict you need to resolve, in release/__init__.py:
<<<<<<< dc04e5eac33eaa09295d238c3441fa6916baaf47
from gen.calc import DCOS_VERSION
from pkgpanda.util import logger
=======
from pkgpanda.util import is_windows, logger
>>>>>>> start of windows port of dcos/dcos

dc04e5eac33eaa09295d238c3441fa6916baaf47 adds a new import before the import you modify. All you need to do is tell git that we want the new import and the modified import:
from gen.calc import DCOS_VERSION
from pkgpanda.util import is_windows, logger

yeah, after further investigation at the point we are ready to merge we can fix that up in 'resolve conflicts'. Never used that before!

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple DCOS_OSS-2310

@paulcallen Branden is going to walk me through this PR tomorrow so I can do a 2nd review. Assuming all is in order, we should be wrapping this up very soon. Thanks for you patience on the whole process.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot override-status teamcity/dcos/test/aws/cloudformation/simple DCOS_OSS-2310

@mesosphere-mergebot merge-it

The Enterprise PR associated with this PR is - https://github.com/mesosphere/dcos-enterprise/pull/2535
(We had closed the mergebot created PR, and had the mergebot created branch in a new PR as we were running into some issues with Github and Teamcity CI).


YJAF Repo Access for Javaid Arshad

Use this issue template if you do not feel comfortable raising a PR with the required changes to files in the terraform/ directory.
Please supply all the requested information, so that your request can be processed as quickly as possible.
Which MoJ repository are you requesting access to (e.g. money-to-prisoners)?
yjaf-app-template/
yjaf-assets/
yjaf-auth/
yjaf-bands/
yjaf-bed-unlock/
yjaf-case/
yjaf-cmm/
yjaf-conversions/
yjaf-csppi/
yjaf-dal/
yjaf-documents/
yjaf-gateway/
yjaf-mule-hub-connector/
yjaf-mule-mis-processor/
yjaf-nginx-gateway/
yjaf-nginx-pentaho/
yjaf-placements/
yjaf-refdata/
yjaf-returns/
yjaf-sentences/
yjaf-transfers/
yjaf-utilities/
yjaf-views/
yjaf-workflow/
yjaf-yp/
yjsm-hub/
yjsm-hubadmin/
yjaf-ui/
yjsm-hub-svc/
What is the GitHub username of the person who needs access?
javaidarshadnec
What is their full name?
Javaid Arshad
What is their email address?
<EMAIL_ADDRESS>What company/organisation do they belong to (e.g. "MadeTech", "Department for Education")?
NEC
What level of access should they have?

[x] Read
[ ] Triage
[x] Write
[ ] Maintain
[ ] Admin

Why is this access being requested?
New YJAF Full Stack Developer
Which MoJ team/person is responsible for this request?
Jo Harvey<EMAIL_ADDRESS>Review date
Date after which this collaborator's access should be reviewed. This should be a date in the format: 2021-01-15, no more than one year into the future.
12/12/2022

Hi Jo
I have merged a PR for you, once the below action has finished, access should be granted.
PR: https://github.com/ministryofjustice/github-collaborators/pull/383
Action: https://github.com/ministryofjustice/github-collaborators/actions/runs/1572779147
Let me know if there are any issues,
Ben


Correct "numberical" typo

@greggyb : Thanks for your contribution! The author, @davidiseminger, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/desktop-tooltips.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@tfosmark : Thanks for your contribution! The author, @davidiseminger, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/desktop-tooltips.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Making some changes! (removig v1, typos, etc.)

Removed (v1) from the title.
Lowercase "t" in "troubleshooting" header.
Added the dot to "pxf" in a question header.
Added a dash to "lower-case."
For one of the questions, I replaced "xxxxxxxx" with "a specific" instead.
Under that question, I replaced the typo "avalibility" with "availability" instead.
Under the question, "How do I use this solution in my production deployment environment?" the whole answer was on one bullet. I removed the bullet.
I changed the question, "The scripts fail with permission error XXXX - what do I do next?" to "The scripts fail with a permission error. What do I do next?"
Under the question, "The scripts fail with a permission error. What do I do next?" The first two bullets were embedded accidentally with numbers under the bullets. I removed the bullets (just a numbered list).
On three lines, I'm changing "e.g." to "such as" instead, per MSTP.
Capped "MSI."
Removed the last question and image (per agreement in an email with Frank and Christopher), "How often is this solution updated?"

@EdPrice-MSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/compliance/pci-faq.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Is it a BUG?

Bug Report
Current Behavior
of(10).pipe(   filter(i => i>10),   delay(5000) ).subscribe(   n => console.log("_____ next", n),    e=> {},    ()=>{ console.log("___ complete") });
output delay 5secs then "___complete";
why there is a delay, there shouldnt be any delay after the filter, right?

Rx.from([10, 11]).pipe(
RxOp.filter(i => i!=11),
RxOp.delay(5000)
).subscribe(
n => console.log("_____ next", n), e=> {}, ()=>{ console.log("___ complete") });
but this code only delay once, compare the code to my last comment, it should delay twice? Very confused...

Delay operator delays whole emission including completion.  https://github.com/ReactiveX/rxjs/blob/master/spec/operators/delay-spec.ts#L106


deprecate setting "holdBrowserOpen" (#2730)

Hello will there be a replacement for this setting? I use it heavily for debugging to get better idea where the test ended. I also saw this old topic where the motion to remove this setting was also debated and eventually declined. https://github.com/selenide/selenide/issues/807


bug: failed to resolve field from correct union type when JIT is enabled

Prerequisites

[X] I have checked the existing issues to ensure this is not a duplicate.
[X] I am running the latest version of Tailcall.

Describe the bug
I have a field that returns a Union type. I resolve a sub-field with the @http directive in one of those union types. Tailcall tries to fetch that field on a type that this field does not exist.
Steps to reproduce
config.graphql
schema @server(port: 8080) @upstream(baseURL: "https://example.com/", batch: {delay: 10}) {
  query: Query
}

type Query {
  data: [Foo!]!
    @discriminate(field: "type")
    @expr(
      body: [
        {id: 1, type: "Fizz"}
        {uuid: "hazz-1", type: "Hazz"}
        {uuid: "buzz-1", type: "Buzz", spam: {identifier: 1}}
        {uuid: "buzz-2", type: "Buzz", spam: {identifier: 2}}
        {uuid: "buzz-3", type: "Buzz", spam: {identifier: 3}}
      ]
    )
}

union Foo = Fizz | Buzz | Hazz

type Fizz {
  id: Int!
}

type Hazz {
  uuid: String!
}

type Buzz {
  uuid: String!
  spam: Spam
}

type Spam {
  identifier: Int!
  spam: String! @http(path: "/spam", query: [{key: "identifier", value: "{{.value.identifier}}"}], batchKey: ["identifier"])
}

Expected behavior
When I query:
{
  data {
    ... on Buzz {
      spam {
        spam
      }
    }
  }
}

I expect the spam field to be be queried only from the Buzz subtype and collect the data from the following URL:
https://example.com/spam?identifier=1&identifier=2&identifier=3
Actual behavior
Tailcall tries to get spam field from other union types resulting in the following URL:
https://example.com/spam?identifier&identifier=1&identifier=2&identifier=3
Logs
 INFO File read: demo.graphql ... ok
 INFO N + 1 detected: 0
 INFO 🚀 Tailcall launched at [<IP_ADDRESS>:8030] over HTTP/1.1
 INFO 🌍 Playground: https://tailcall.run/playground/?u=http://<IP_ADDRESS>:8080/graphql&utm_source=tailcall-release&utm_medium=server
 INFO GET https://example.com/spam?identifier&identifier=1&identifier=2&identifier=3  HTTP/1.1

The bug is JIT related. I can replicate it without batching too.
schema @server(port: 8030) @upstream(baseURL: "https://example.com/") {
  query: Query
}

type Query {
  data: [Foo!]!
    @discriminate(field: "type")
    @expr(
      body: [
        {id: 1, type: "Fizz"}
        {uuid: "hazz-1", type: "Hazz"}
        {uuid: "buzz-1", type: "Buzz", spam: {identifier: 1}}
        {uuid: "buzz-2", type: "Buzz", spam: {identifier: 2}}
        {uuid: "buzz-3", type: "Buzz", spam: {identifier: 3}}
      ]
    )
}

union Foo = Fizz | Buzz | Hazz

type Fizz {
  id: Int!
}

type Hazz {
  uuid: String!
}

type Buzz {
  uuid: String!
  spam: Spam
}

type Spam {
  identifier: Int!
  spam: String! @http(path: "/spam", query: [{key: "identifier", value: "{{.value.identifier}}"}])
}

fixed in https://github.com/tailcallhq/tailcall/pull/3000/commits/1fde1b6f84f23be1bdad1a37bf6d5c365e70c9e2

https://github.com/tailcallhq/tailcall/pull/3000 merged


is grafana dashboard UI on localhost:3000?

is grafana dashboard UI on localhost:3000?
No UI on localhost:3000, what I am missing here?
Rams-MacBook-Pro:k8smonitoring ram.dhakne$ sudo kubectl get pods --namespace=monitoring
NAME                                  READY     STATUS    RESTARTS   AGE
alertmanager-64fd9d59f9-vsv9g         1/1       Running   1          40m
grafana-core-5cf6b555cc-x27p9         1/1       Running   1          40m
kube-state-metrics-568457dff4-49blf   1/1       Running   1          40m
kube-state-metrics-568457dff4-dq65c   1/1       Running   1          40m
node-directory-size-metrics-s7zv6     2/2       Running   2          40m
prometheus-core-79648bf5cc-kp4t9      1/1       Running   1          40m
prometheus-node-exporter-9xwm2        1/1       Running   1          40m
...
...
Normal   SuccessfulMountVolume  5m    kubelet, minikube  MountVolume.SetUp succeeded for volume "grafana-persistent-storage"
Normal   SuccessfulMountVolume  5m    kubelet, minikube  MountVolume.SetUp succeeded for volume "default-token-2w6fv"
Normal   SandboxChanged         5m    kubelet, minikube  Pod sandbox changed, it will be killed and re-created.
Normal   Pulled                 5m    kubelet, minikube  Container image "grafana/grafana:4.2.0" already present on machine
Normal   Created                4m    kubelet, minikube  Created container
Normal   Started                4m    kubelet, minikube  Started container
No UI on localhost:3000, what I am missing here?

If you are running it in minkube you have to expose the grafana service (Nodeport type) or run a kubectl proxy

i had run kubectl proxy
when i  visit  http://localhost:8001/api/v1/namespaces/monitoring/services/grafana:3000
i get result
{
	"kind": "Status",
	"apiVersion": "v1",
	"metadata": {},
	"status": "Failure",
	"message": "services \"grafana:3000\" not found",
	"reason": "NotFound",
	"details": {
		"name": "grafana:3000",
		"kind": "services"
	},
	"code": 404
}

how can i visit  grafana dashboard UI ?

@jerrwy you should use this URL for proxy
http://<IP_ADDRESS>:8001/api/v1/namespaces/monitoring/services/http:grafana:/proxy
In that way you are calling service http:grafana and you are asking a proxy on it

If you still have problems another approach is to go directly to pod without proxy
Run
kubectl port-forward $(kubectl get pods --selector=app=grafana -n monitoring --output=jsonpath="{.items..metadata.name}") -n monitoring 9200:3000
and then go to
http://localhost:9200

thx! it worked!

how can i visit prometheus targets in kubectl proxy?
i have try http://<IP_ADDRESS>:8001/api/v1/namespaces/monitoring/services/http:prometheus:/proxy
but return result
{
	"kind": "Status",
	"apiVersion": "v1",
	"metadata": {},
	"status": "Failure",
	"message": "no endpoints available for service \"http:prometheus:\"",
	"reason": "ServiceUnavailable",
	"code": 503
}

thx~ i am use kubectl port-forward command visit prometheus targets now

Yeah, port forward should be the way in case you don't expose it through an ingress resource. Adding this info in the readme


Avoid using getters for constants

The underlying implementation of a constant function invokes the web3 RPC to obtain the value. This is more than an idempotent operation and uses network resources / may block to obtain the reply.
Using getters sends the wrong message to the developers and the debugger:

The debugger for instance happily invokes getters when asked to explore an object which may cause problems/interfere during a debugging session.
Developers may think that the value can be quickly accessible and thus understand they should not cache the returned value.
In solidity, the code shows as a function, so one would expect a function to be exposed in TypeScript, not a getter.
It is odd to await on a getter (return a Promise), since the returned value should be available instantaneously.

Happy to submit a PR to correct this.

As far as i know even getters inside Ethereum Chain are async methods provided by the RPC.
So when you execute get you will not pay for Gas but the server will need to look for this particular block related with contract creation.
You could do something like this
import { GapiController, Type, Public, Query } from '@gapi/core';
import { EthereumCrowdsaleType } from './types/crowdsale-info.type';
import { PhoneumCoinCrowdsale } from '../core/ethereum/contracts/PhoneumCoinCrowdsale';

@GapiController()
export class EthereumQueriesController {

    constructor(
        private phoneumCrowdsale: PhoneumCoinCrowdsale
    ) { }

    @Type(EthereumCrowdsaleType)
    @Public()
    @Query()
    async getCrowdsaleInfo(root, payload, context): Promise<EthereumCrowdsaleType> {
        const crowdsale = await this.phoneumCrowdsale;
        return {
            startTime: (await crowdsale.startTime).toNumber(),
            endTime: (await crowdsale.endTime).toNumber(),
            hasEnded: await crowdsale.hasEnded,
            token: await crowdsale.token,
            weiRaised: (await crowdsale.weiRaised).toNumber(),
            wallet: await crowdsale.wallet,
        };
    }

}

Here is a implementation using @gapi graphQL framework and TypeChain:
https://github.com/Stradivario/gapi-ethereum

The problem with this is not with Ethereum per se, it is that the getter would be doing an RPC call, and its outcome, with all the I/O (HTTP request going to your RPC server and back) and may not be an idempotent operation.

@jpeletier I am gonna close it, in 0.3 version we just generate typings for well-known libraries like truffle or web3-1.0 so it's fixed (or basically out of the scope of Typechain)


Transactions can be viewed on dapp

ViewService foundations are in place now. Se progress in parent issue.


Support RenderTarget in Renderer:readPixels

Is your feature request related to a problem? Please describe.
PR #1275 introduced support for rendering to offscreen targets. Readback of the result from GPU back to CPU is possible by using the underlying driver:
    filament::details::upcast(engine).getDriverApi().readPixels(
            filament::details::upcast(offscreenRenderTarget)->getHwHandle(),
            width, height, format, type, buffer);

Describe the solution you'd like
filament::Renderer provides the public readPixels function, but it only supports readback from the current SwapChain. Add an argument to select for what pixel data we are trying to readback (e.g a specific texture or a rendertarget).
The signature of
    void readPixels(uint32_t xoffset, uint32_t yoffset, uint32_t width, uint32_t height,
            backend::PixelBufferDescriptor&& buffer);

should be something like
    void readPixels(uint32_t xoffset, uint32_t yoffset, uint32_t width, uint32_t height,
            backend::PixelBufferDescriptor&& buffer, filament::Texture *texture);

Describe alternatives you've considered
An alternative solution would be to somehow get raw pixel data from a Texture to copy through the CPU. But it needs to go through the renderer anyways as this will require communication with the GPU.
OS and backend
I've tested that this works as expected with the OpenGL backend

Seems reasonable!  I'll discuss with the team and look into this.  ReadPIxels is super slow -- out of curiosity what are you using it for?

@zefz it's a little tricky because the client application would need to call our top-level render() function in order to resolve the offscreen render target.
We provide ReadPixels for debug purposes only, we don't like it because it stalls the pipeline.  In the long term we might provide an asynchronous PBO-based solutions.
If you have a compelling use case then let us know, it will help us prioritize.

Yes I am aware it's a very slow process, but as far as I know it is the only way to access copy pixel data directly from a rendered view to either feed into a computer vision algorithm (e.g OpenCV) or to store an image to the disk (like taking a screenshot from a view that is not the SwapChain).
This image shows how we develop a stereo vision navigation algorithm using filament to render multiple cameras to a single entity and the main camera observing the scene.

This looks like a cool app!  Here's how to unblock you in the short term.  If you're using offscreen render targets, somewhere in your app you already have something like this:
        if (renderer->beginFrame(window->getSwapChain())) {
            for (filament::View* offscreenView : mOffscreenViews) {
                renderer->render(offscreenView);
            }
            for (auto const& view : mSwapChainViews) {
                renderer->render(view->getView());
            }
            renderer->endFrame();
        }

To use ReadPixels on a particular render target, temporarily substitute the mSwapChainViews with a single view that draws a nonlit quad whose basecolor is the texture that corresponds to the render target of interest.  After that, issue a ReadPixels as you normally would.

Thanks! I will look into it.

Since this is doable with the current API (although admittedly awkward), I'm closing this ticket for now.


Can't find Raw SQL Editor

I am in grafana7.5.7。

I can't find Raw SQL Editor...
I don't know why

which plugin version do you use?
did you select database and table before click "go to query"?

I've encountered this issue too, you can try to switch to time series instead of graph(old), then save the dashboard and reload.

Thanks
Now I've choosen grafana8.0.5 to slove this problem.


wait step doesn't stop pipeline from running steps in parallel

Hi guys,
The agent runs the first and last step simultaneously, despite the explicit wait step which in theory should block the last step "Terraform apply" until all previous steps have completed.
I'm wondering if the issue is related to my conditional block step which supposed to run only in production.
When I remove if statement it works as expected as well as if I remove the whole block step entirely - wait behaves as expected.
As you can see from the screenshot the pipeline recognizes that there is a wait step but doesn't respect it runs both steps at the same time (when not running against production).

This is a simplified code from my pipeline file (I've removed hopefully unrelated code for brevity)
steps:
  - label: ':buildkite: Terraform generate execution plan'
    commands:
      - echo "hello"
  - block: ':rocket: Approval Step'
    if: build.env("ENVIRONMENT_NAME") == "production"

  - wait

  - label: ':buildkite: Terraform apply changes'
    commands:
      - echo "hello 2"

Alternatively, if this is an expecting behaviour could you please provide me with an example of how to introduce a manual block step when deploying to production env while always running steps in sequence (preferably keeping code in a single yaml file)

Just confirming that the apply shouldn't happen without being in the correct env either?
steps:
- id: terraform-plan
  label: ':terraform: create plan'
  commands:
  - '.buildkite/plan.sh'
- block: ":terraform: apply changes"
  if: build.env("ENVIRONMENT_NAME") == "production"
- id: terraform-apply
  if: build.env("ENVIRONMENT_NAME") == "production"
  commands:
  - '.buildkite/apply.sh'

Should work for you to achieve what you're attempting (we have this working for us).

@jufemaiz thanks for the reply, in our case we would like to run terraform apply for any environments, however we want to have a manual approval block step if environment is production and just a normal wait for non production. Basically the workflow should look like this:
Production: terraform plan -> block (manual approval) -> terraform apply
Non Production: terraform plan -> wait for plan to finish -> terraform apply

Just for giggles, try adding your if on the wait for the opposite?
steps:
- id: terraform-plan
  label: ':terraform: create plan'
  commands:
  - '.buildkite/plan.sh'
- wait:
  if: build.env("ENVIRONMENT_NAME") != "production"
- block: ":terraform: apply changes"
  if: build.env("ENVIRONMENT_NAME") == "production"
- id: terraform-apply
  if: build.env("ENVIRONMENT_NAME") == "production"
  commands:
  - '.buildkite/apply.sh'

?

@jufemaiz thanks for your help, I was playing around with the location of wait step and noticed that if I put wait step above my conditional block it works as expected, not sure if that's how it supposed to behave but at least I have a working solution :
env:
  ENVIRONMENT_NAME: uat
steps:
  - label: ':buildkite: Terraform generate execution plan'
    commands:
      - echo "plan"

 - wait

  - block: ':rocket: Approval Step'
    if: build.env("ENVIRONMENT_NAME") == "production"

  - label: ':buildkite: Terraform apply changes'
    commands:
      - echo "apply"

Thanks

Hi @b-b3rn4rd I’m going through old issues and I’m glad to see you’ve got a working implementation now 😄 I’m going to close this but please leave a comment or re-open the issue if you’ve run into any further issues.


Moving rest of the filesystems to Transactional API

This PR is complement of  #41946 and enables Transactional API in remaining Filesystems.

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.


Reward modification in PPO

https://github.com/marload/DeepRL-TensorFlow2/blob/876266d9a5fcf7d8a7c7e3afd8b110085b32b615/PPO/PPO_Discrete.py#L151-L154
https://github.com/marload/DeepRL-TensorFlow2/blob/876266d9a5fcf7d8a7c7e3afd8b110085b32b615/PPO/PPO_Continuous.py#L167-L170
In PPO_Discrete each reward is multiplied by 0.01 and in PPO_Continuous reward is also modified. I don't understand why do these modification, what does these modification do?

same question

乘0.01应该是减小奖励，使其保持在0-1之间（我猜测）


Code style checks

I think that this project would benefit if some Code Style checks would be used. Like KtLint and Detect.
Also, in several classes I noticed that nullable var field could be replaced with non-null lateinit or simple non-null field.
Record class is the main example of it:
    private var timeAtWhichWasPersisted: Long = 0
    private var dataClassName: String? = null
    private var dataCollectionClassName: String? = null
    private var dataKeyMapClassName: String? = null

These fields are changed only in init method.

I have implemented code style checks in PR#21.
The rest of proposal will be implemented as separate PR, because it will be big enough and I don't want it to meddle with simple code style fixes.

Most of those other issues were closed in previous or existing Pull Requests. Closing the issue


Get favicon working across browsers (Safari)

Need to use mask icons plus there seem to be other janky fixes to support across primary browsers

https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7
<link rel="icon" href="/favicon.ico" sizes="48x48">
<link rel="icon" href="/favicon.svg" sizes="any" type="image/svg+xml">

Article has resources for converting to ico


tests: specify "rhc_baseurl" where needed

The role now may perform package checks in some cases, and because of that it needs to make sure that the package manager has usable repositories. Hence, pass the baseurl configured (if any, hence the "omit") for the tests as "rhc_baseurl" parameter in all the "rhc" invocations that are supposed to work (i.e. not fail for expected failing parameters).

[citest]


removed pointer event

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[WIP] Implement cogs

Achievements

[x] Implemented cogs
[x] Fixed bug regarding belts attributions
[x] Created $load and $unload command in order to load and unload cogs

Missing features

[ ] Send private message to the promoted ninja informing about the requirements for the next belt (Solves: #15)

Thanks 🙏🏼
Can I ask a review from @nelsonmestevao as well?


AB#9262 Application Submissions by Sector Pie Chart In the Dashboard

hi @AndreGAot -- this is now ready for another round of review. thanks.


Minor fixes

Add 'test' to ENVIRONMENTS constant
Use constants instead of hardcoded values in logger.js
Allow to provide app name in 'started' canned message

@jleach done


Sort by Chapter Number is broken

Device information

Neko version: 2.7.0
Android phone & version: LG G7 Android 10

Steps to reproduce

Go to Library
Pick "Monster no Goshujin-sama"
Sort by chapter number

Expected behavior

Chapters are sorted according to chapter number.

Actual behavior

Chapters are not sorted accordingly.

Other details

This bug is a regression and does not happen on previous release version of Neko.
It can happen with and without merged manga on multiple manga/webtoons.
I'm not sure if this is a problem too upstream so I decided to open the issue here first. :bread:
May provide other manga/webtoons where the bug can be reproduced upon request.

#752


Flutter 2 compatibility

I started this library with Flutter 1.2 version, unfortunately this affects to developments with Flutter 2 with compatibility issues. Right now in Hacktoberfest, you can contribute with:

Compatibility with Flutter 2
Null safety

Please message me or send me a mail to<EMAIL_ADDRESS>if you want to contribute for assigning this issue to you.

Please assign. Will try migrating to Null safety and Flutter 2. :)

Thanks, Dhiman. I'll assign the issue for you.

Issue closed. Thank you, @Dhi13man.


Automatic PR from RestAPI-PR799

Generated from RestAPI PR: https://github.com/Azure/azure-rest-api-specs/pull/799

Current coverage is 56.64% (diff: 100%)

Merging #919 into master will increase coverage by 0.02%

@@             master       #919   diff @@
==========================================
  Files          1758       1758
  Lines         48711      48735    +24
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          27584      27608    +24
  Misses        21127      21127
  Partials          0          0

Powered by Codecov. Last update f07caf6...39b6b85

Will not release before @begoldsm confirmation, but see no reason to do not merge.


NLopt failed to converge

When I run the exemplary code for "Solve your first optimization problem"
using Optimization, OptimizationNLopt

# Define the problem to optimize
L(u, p) = (p[1] - u[1])^2 + p[2] * (u[2] - u[1]^2)^2

# Define the Optimization Problem
u0 = zeros(2)
p = [1.0, 100.0]
prob = OptimizationProblem(L, u0, p, lb = -1 * ones(2), ub = ones(2))

# Solve the optimization problem
sol = solve(prob, NLopt.LD_LBFGS())

it gave a warning:
Warning: NLopt failed to converge: FORCED_STOP
└ @ OptimizationNLopt ~/.julia/packages/OptimizationNLopt/eAzgn/src/OptimizationNLopt.jl:231

and:
u: 2-element Vector{Float64}:
 NaN
 NaN

I guess the optimization was not successful?
By the way, I am using Julia version 1.9.

Were you looking at some other place than https://docs.sciml.ai/Optimization/stable/getting_started/? Btw you are missing defining an OptimizationFunction with an AD backend and using a derivative based optimizer BFGS. For reference https://docs.sciml.ai/Optimization/stable/getting_started/#Controlling-Gradient-Calculations-(Automatic-Differentiation)

@Vaibhavdixit02  Sorry, I forgot to give the link of the example code I mentioned (Overview of Julia's SciML - Solve your first optimization problem):
https://docs.sciml.ai/Overview/stable/getting_started/first_optimization/ .
Indeed, it's not in the Optimization section.
Thank you very much for your suggestion. I am a newbie and so I'll need to read the reference and figure out what you are talking about 😂.


Allow to call a callback on streaming responses

Title: Allow to call a callback on streaming responses
Description: (optional)
This PR allows to call a user-defined function (null-safe) with the stream content (list of chunks)
Motivation: (optional)
The motivation behind this is that i run a fork of the gateway (i needed to introduce a custom middleware) and to add tracing for the stream responses, i have a working solution (transform the stream without actually changing the format, only adding the same logic i added in this PR) but having this as a native feature of the gateway would improve the overall implementation.
The idea is actually similar to what is done with the getFromCache function.
This is a first (working) proof-of-concept, if the idea of this feature is accepted, i'm more than ready to improve the implementation if needed.
Regarding the impact on performance, i think that if the function is not set the impact is non-existant, and if the function is set, then the performance has to be accepted by those implementing the function.
If accepted, it could also be a first step to have some level of callbacks/hooks for those running forks to extends the open-source gateway.

@unsync we'll make this a part of the upcoming hooks architecture. Thanks for the suggestion, but we're pausing this PR for now. Will incorporate these suggestions in the hooks merge happening soon.


IDVA5-126-sign-out

sign out page

CI: No security warnings found

CI: No security warnings found

CI: No security warnings found


no-op is the object is disposed

This PR fixes #20013
during the document switch, when the view is not results view, it will still be created and then disposed in the onHide event handler, but the scrollable view will call the onDidInsert in a timer function and will cause the error of adding disposable to an already disposed disposableStore.
the fix it to mark it as disposed and no-op if it is disposed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0005%) to 42.132%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/query/browser/gridPanel.ts
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0005%

Covered Lines:
28187

Relevant Lines:
62529

💛  - Coveralls


Update repository after transfer

See https://github.com/senzing-garage/garage-roadmap/issues/3

Pull requests:

https://github.com/senzing-garage/explain/pull/40


feat(output): expose function timeout

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


LaTeX to mathML: semantic whitespace removed

** Overview **
Using this filter to convert LaTeX to mathML, some semantic whitespace inside \begin{equation} environments with \label items is removed
** Sample Input File "label.tex"
\section{Section} \label{section}
\begin{equation}
    y^2 = \omega x^2
    \label{eq:sample}
\end{equation}
This is Equation~\ref{eq:sample}, in Section~\ref{section}.
The following equation doesn't have the same issue:
\begin{equation}
    y^2 = \omega x^2
\end{equation}

** Pandoc command**
pandoc -f latex -t html --mathml --lua-filter ~/querverweis.lua label.tex -o label.html
** Error message **
[WARNING] Could not convert TeX math y^2=\omegax^2, rendering as TeX:
  y^2=\omegax^2
             ^
unexpected control sequence \omegax
expecting "%", "\\label", "\\tag", "\\nonumber", whitespace or "\\allowbreak"

** Other Notes **
I downloaded the file querverweis.lua from the repository and put it in my home directory; I'm not sure if this is the intended way to run the filter, but other than this whitespace issue it seems to give the expected results.

Many thanks a lot for the report and for testing this filter!
The bug should be fixed now.
You can also "install" the filter by moving it to $HOME/.local/share/pandoc/filters. (Or to the "user directory" folder mentioned in the output of pandoc -v). You might have to create that directory.

Side note: I'm also working on another filter to support equation numbering, see rivnjannja, maybe you find that one useful, too.


HL-103, HL-104, HL-105: Frontend to backend logic

Description :sparkles:

mappings in frontend to backend application data model
create application functionality step1
update application functionality step1 and step2

Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:
missing fields:

start_date (custom datepicker is not implemented)
end_date (custom datepicker is not implemented)
applicant and employee language fields
employee email (does not exist in the abstract UI design)
association_has_business_activities (does not exist in the abstract UI design)

Codecov Report

Merging #159 (f94c7fc) into develop (fff8a70) will decrease coverage by 57.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop     #159       +/-   ##
============================================
- Coverage    69.54%   12.53%   -57.01%
============================================
  Files          267       55      -212
  Lines         5444      678     -4766
  Branches       391      126      -265
============================================
- Hits          3786       85     -3701
+ Misses        1595      557     -1038
+ Partials        63       36       -27

Impacted Files
Coverage Δ

...tend/shared/src/components/forms/section/styled.ts
0.00% <0.00%> (ø)

frontend/shared/src/utils/date.utils.ts
0.00% <0.00%> (ø)

frontend/shared/src/utils/string.utils.ts
0.00% <0.00%> (ø)

...companies/migrations/0003_company_eauth_profile.py

backend/benefit/common/exceptions.py

backend/shared/shared/azure_adfs/auth.py

...s/applications/applicationList/ApplicationList.tsx

backend/benefit/users/models.py

frontend/benefit/applicant/src/i18n.ts

backend/kesaseteli/companies/api/v1/views.py

... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff8a70...f94c7fc. Read the comment docs.


Insufficient fix for #1126

Insufficient fix for #1126
The following program sample.go triggers an unexpected result
package main

import (
	"errors"
	"fmt"
	"strings"
)

func main() {
	err := errors.New("hello there")

	switch true {
	case strings.Contains(err.Error(), "hello"):
		fmt.Println("True!")
	default:
		fmt.Println("False!")
	}
}

Expected result
$ go run main.go
// True!

Got
$ yaegi main.go
// False!

Yaegi Version
v0.11.1
Additional Notes
Almost identical to #1126, except that the first condition is always ignored. A temporary fix would be to add a placeholder:
	switch true {
        case false:
	case strings.Contains(err.Error(), "hello"):
		fmt.Println("True!")
	default:
		fmt.Println("False!")
	}

Any news on this? It's a core issue, definitely seems important

This is fixed by the PR #1370, part of v0.11.3


I don't see MA2 inside HA.

What version of Music Assistant has the issue?
2023.6.0b3
The problem
I don't see Music Assistant inside HA. Music installed as server via docker.
HA in https. MA works well and I access via http
How to reproduce
Installing MA Server 2.0 on Docker
installation via HACS of the beta version of MA
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2023.9.2
What type of installation are you running?
Home Assistant Core
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

What do you expect to see? You say the MA works well?

in the left bar, as was the case previously and the MA interface was inside HA.
Now to access MA I have to call it from external http://<IP_ADDRESS>:8095

When you say " the case previously" are you coming from MA1 or a previous beta of MA 2?

Yes, I come from MA1. But I made several attempts to uninstall MA1 and then I installed MA2 server in docker and then MA2 Beta in HA

MA2 has been completely rewritten and for a variety of reasons is no longer a big integration. It is now a standalone addon that can work with HA but does not have to. If you want a more seamless experience then we recommend you use HAOS. If you install via docker as you have done then you have to access it via port 8095 as you have found. Read the FAQs for how to add that to the sidebar.
The integration, which is not yet at the feature level of MA1, allows for scripts and automations to target MA just as was the case before.

Thanks, I'll check the FAQ


add collapsible-card block

Describe your specific features or fixes
Resolves: MWPW-143341
Test URLs:

Pre Migration Link: https://adobe.com/express/create/advertisement/facebook
Before: https://main--express-milo--adobecom.hlx.page/express/create/advertisement/facebook
After: https://MWPW-143341--express-milo--adobecom.hlx.page/express/create/advertisement/facebook

Additional Test URLs:

https://MWPW-143341--express-milo--adobecom.hlx.page/express/create/banner/linkedin
https://MWPW-143341--express-milo--adobecom.hlx.page/nl/express/create/meme

Codecov Report
Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.96%. Comparing base (51241ff) to head (cd975c2).
Report is 12 commits behind head on main.

Files with missing lines
Patch %
Lines

...xpress/blocks/collapsible-card/collapsible-card.js
95.71%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   64.94%   64.96%   +0.02%
==========================================
  Files          38       44       +6
  Lines        5611     6617    +1006
==========================================
+ Hits         3644     4299     +655
- Misses       1967     2318     +351

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TLS arm asm update, bits clear of tid

Why would the low 2 bits of the thread id register value need to be cleared?

Sorry I did not complete the necessary change, on ARM (normally for 64 bits too but I do not have the related hardware yet), the control block is in the first slot.

Still, wouldn't the pointer to the control block suffice? As it is not really the thread ID we're interested in, just something that is unique for the thread and doesn't change over the lifetime of the thread.

That s a good point I must admit, I m being a bit "pedantic" for no added value.


Update HTTPBin certificates in tests

They now expire in April 2019.

Codecov Report

Merging #4357 into master will increase coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
+ Coverage   88.05%   88.42%   +0.37%
==========================================
  Files          46       36      -10
  Lines        5992     5651     -341
==========================================
- Hits         5276     4997     -279
+ Misses        716      654      -62

Impacted Files
Coverage Δ

Tests/Tests/AFSecurityPolicyTests.m
100% <100%> (ø)
:arrow_up:

UIKit+AFNetworking/UIButton+AFNetworking.m
79.54% <0%> (-2.6%)
:arrow_down:

UIKit+AFNetworking/UIRefreshControl+AFNetworking.m
69.23% <0%> (-2.2%)
:arrow_down:

AFNetworking/AFNetworkReachabilityManager.m
76.47% <0%> (-1.31%)
:arrow_down:

AFNetworking/AFHTTPSessionManager.m
89.47% <0%> (-1.28%)
:arrow_down:

AFNetworking/AFURLSessionManager.m
69.63% <0%> (-0.79%)
:arrow_down:

UIKit+AFNetworking/UIWebView+AFNetworking.m
76.19% <0%> (-0.74%)
:arrow_down:

AFNetworking/AFSecurityPolicy.m
94.25% <0%> (-0.7%)
:arrow_down:

...t+AFNetworking/AFNetworkActivityIndicatorManager.m
84.21% <0%> (-0.69%)
:arrow_down:

AFNetworking/AFURLRequestSerialization.m
70.59% <0%> (-0.45%)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5890adc...3517a1d. Read the comment docs.


Incorporating Gradle tasks for automatically installing JEP

What's Done:

Introduced the installJep task to facilitate the automatic installation of JEP from https://github.com/icemachined/jep-distro/.

Centralized and encapsulated the logic for JEP search and installation: all the relevant logic has been relocated to the Gradle task, separating it from the main code. The main code will now simply utilize the JEP stored in the build/jep directory.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check @oxisto

cc @maximiliankaul

Thanks for your contribution! (And signing the CLA ;) Looks like an interesting idea, I will have some time between Christmas and New Years to look at this as well.

Thanks for your contribution! (And signing the CLA ;) Looks like an interesting idea, I will have some time between Christmas and New Years to look at this as well.

Thanks! Happy holidays! Please also approve a workflow (I added 1 commit, trying to fix build with JEP)

Hi @akuleshov7 ,
thanks so much for our PR. I'm a bit undecided whether I like it or not:

The entire JEP installation / configuration process has always been a pain for us and we applaud any effort to improve this situation :+1:
I'm very hesitant to include a dependency to icemachined as this does not seem to be related with the JEP project / it's unclear to me how well this will be maintained.
Your PR does not work on my machine (Linux). Setting the CPG_PYTHON_VIRTUALENV=cpg env variable still results in the Your system architecture, identified as <amd64>, is not supported in icemachined/jep-distro.  error message.
Can you please comment on the following usecases which are important to us:

We are using the CPG in other projects as a dependency. How does this work with your PR?
Your PR / icemachined only supports x86, correct? We do not want do drop ARM support.
We have to fix a Python version in the build process (i.e. on Github) and this version is required on any client using the Github build, correct? We would like to avoid a scenario like this.

We will discuss testing this with some other projects and see if anything breaks. Any improvement in the JEP install logic is very welcome to us.

I'm very hesitant to include a dependency to icemachined as this does not seem to be related with the JEP project / it's unclear to me how well this will be maintained.

@icemachined, Dima, how well do you maintain JEP-distro? 😄

I'm very hesitant to include a dependency to icemachined as this does not seem to be related with the JEP project / it's unclear to me how well this will be maintained.

@icemachined, Dima, how well do you maintain JEP-distro? 😄

I'm not modifying jep I just perform jep build on github and publish it on maven, you can see the code here https://github.com/icemachined/jep-distro. If there will be any issues I can fix it or accept your fix.

  * Your PR / icemachined only supports x86, correct? We do not want do drop ARM support.
  * We have to fix a Python version in the build process (i.e. on Github) and this version is required on any client using the Github build, correct? We would like to avoid a scenario like this.

Is there any update on these two points? @oxisto, if I remember correctly, we can live without the ARM support (although we would like to keep it as some of our team work on ARM machines), but the second point is a deal breaker for us, right?

Your PR / icemachined only supports x86, correct? We do not want do drop ARM support.
We have to fix a Python version in the build process (i.e. on Github) and this version is required on any client using the Github build, correct? We would like to avoid a scenario like this.

Is there any update on these two points? @oxisto, if I remember correctly, we can live without the ARM support (although we would like to keep it as some of our team work on ARM machines), but the second point is a deal breaker for us, right?

Hi @maximiliankaul , jep-distro currently support ARM, latest release have ARM libraries tested on M2. so if you need we can update pr with ARM support

Your PR / icemachined only supports x86, correct? We do not want do drop ARM support.
We have to fix a Python version in the build process (i.e. on Github) and this version is required on any client using the Github build, correct? We would like to avoid a scenario like this.

Is there any update on these two points? @oxisto, if I remember correctly, we can live without the ARM support (although we would like to keep it as some of our team work on ARM machines), but the second point is a deal breaker for us, right?

Hi @maximiliankaul , jep-distro currently support ARM, latest release have ARM libraries tested on M2. so if you need we can update pr with ARM support

That's great to hear :) When we first checked this PR, there was no support / we missed this.
However, as we mentioned above, the deal breaker is fixing the Python version at compile time. Please don't get me wrong: we don't like the current solution and welcome any improvements (and this PR is an improvement in many ways), but we don't want to lose the ability to build the CPG once (e.g. here on Github) and distribute it to machines running different versions of Python. This is not achievable with this PR right now, is it?

That's great to hear :) When we first checked this PR, there was no support / we missed this. However, as we mentioned above, the deal breaker is fixing the Python version at compile time. Please don't get me wrong: we don't like the current solution and welcome any improvements (and this PR is an improvement in many ways), but we don't want to lose the ability to build the CPG once (e.g. here on Github) and distribute it to machines running different versions of Python. This is not achievable with this PR right now, is it?

Yes you are right seems like this is no achievable in this pr. But it is achievable in general because jep-distro contains builds for all architectures and versions of python starting from 3.6 till 3.12. You could include all required versions in distro and unpack one of them in runtime to tmp depending on current version of python.

Hello everyone,
we are cleaning up old PRs and have decided to close this one as it does not really fit our target use case, as discussed above.
Shipping multiple versions of jep and unpacking them at runtime does have some drawbacks to the current approach. As stated above, we are not happy with the current mechanism either and are open to improvements. This PR, however, is too far away from what we want to achieve.
Thank you for contributing!
Best regards,
The CPG Team


Spec Export does not work with Sketch 49

With the update of Sketch to version 49, Spec Export does not work. It will export the html file but when you look at Sketch, the export layers are stuck.

Same issue here.  I've also tried toggling 'Advanced Mode' and 'Export Layer Influence Rect' options with no success.

Same issue here!

I am experiencing the same issue

me too...😢

Plugin doesn't work properly.

fixed~

Thanks @utom
It works now!
We all appreciate

@utom
I'm using sketch v51.3 and export specs is freezing and doesn't progress.
I've tried multiple files with no luck.
Uninstalled Sketch Measure and reinstalled. No luck.
I've restarted.
Nothing is working.
Help?
Thanks!!!

@elizaio I'm having the same issue. Have also troubleshooted with all the same methods. @utom you are truly a saint for creating this plugin, thank you so freaking much. Also... could you help us? :)

I'm having the same problem. It took me a bit to realize it was hanging on a path. I tested it by deleting the first path on the layer where it got hung up, then it would hang again on the next path on the layer. Unfortunately, I can't delete all the paths in the sketch file in order to export the specs... please fix!

I have a potential fix...
Updated to macOS High Sierra Version 10.13.6, the updated to Sketch 52.3.
Exporting specs for individual artboards now works but will still hang if I select multiple artboards.
FWIW, my company doesn't support Mojave yet so I'm hamstrung.

on Sketch v 51.2
nothing seems to work, export stalls and never finish.
tried to reinstall with no success...:-( @


Don't re-force member loading in already-forced class hierarchies

When deserializing a the (named) members of a class hierarchy, we
needn't walk all the way up the hierarchy, just into our superclass.
This will, in turn, walk to its superclass, etc.  This is as opposed to
this work being repeated at each level of the recursive hierarchy.
Should be a small perf win over the last patch.
Resolves rdar://57882571 and SR-11949

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please clean smoke test macOS platform

Looks like there is a test failure:
16:16:06     Swift(macosx-x86_64) :: NameBinding/named_lazy_member_loading_objc_interface.swift

Cool, least we know this fixes source compatibility.

@swift-ci please smoke test

@swift-ci please smoke test

⛵


GPII-3295: Ensure that all lint checks are always run.

See https://issues.gpii.net/browse/GPII-3295 for details.

@sgithens, I have cut a dev release (1.0.5-dev.20180816T091440Z.5243db3) if you want to try this in your own projects.

This pull now also includes support for proper options overriding, see GPII-3317 for details.

@amb26, this should be ready for further review.

@amb26, I add coverage reports and fixed a key branch that wasn't tested (running without expansion).  This should be ready for further review, or at least clarification about your earlier concern.


fuzz elements in array

add fuzzing objects into array

Hi @xalex-zededa, this repo is ported from https://gitlab.com/michenriksen/jdam/ and I don't have the plan to maintenance it. If you are interested in it, please make commit in the original gitlab repo. Thanks!


Cannot build Unity 2019.4

Hi I cannot seem to build this project in Unity 2019.4.1f1 as I get a whole bunch of errors, I am missing something obvious here?

Maybe you are confusing UnityEngine.Windows.WebCam.VideoCapture and HololensCameraStream.VideoCapture? In older Versions of Unity, VideoCapture was in another namespace. Could be that Unity tried to upgrade the scripts and now the wrong namespace (Unity instead of HololensCameraStream) is included

Hi @lapislazinus,
I ran into the same issue and you are right. When importing the unitypackage. Unity will mess with the VideoCapture import and add UnityEngine.Windows.WebCam prefix to everything WebCam-related. Thank you for that hint!

Actually I need to specifically replace UnityEngine.Windows.WebCam with HololensCameraStream. Otherwise Unity will try to 'fix' VideoCapture during every build.

Same situation in Unity2019.3.0f

Try another branch (upgrade_2018_2) please. There is no compile errors.

Actually I need to specifically replace UnityEngine.Windows.WebCam with HololensCameraStream. Otherwise Unity will try to 'fix' VideoCapture during every build.

and how is this done?

Hello.
I have just released a version in my repository that supports the latest Unity and Hololens2. Please try it out.
https://github.com/EnoxSoftware/HoloLensCameraStream


Further fix for BZ 66508

https://bz.apache.org/bugzilla/show_bug.cgi?id=66508
Avoid deadlock for close messages when
WsRemoteEndpointImplServer.endMessage() for a previous message is processed on a container thread
The fix for this involves the thread currently processing a socket effectively yielding the socket lock and processor to another thread. I think that is worthy of closer review before merge.
There are a couple of potential alternatives.
Plan B would be to make handing of the close message async. That is potentially better but will be more complex to implement and may uncover other complexities.
Plan C would be to require useAsyncIO="true" to enable WebSocket.

Sorry. Branch in wrong repo. I'll resubmit.


Split return assignments

This transform addresses https://github.com/Shopify/javascript/issues/104
/cc @lemonmade @GoodForOneFare

I don't understand the change to remove-useless-return-from-test.js.

I think there's something wrong with your git workflow.  Are you creating branches from your previous PR's branch?  It's not a huge deal in a project of this size, but you may get an instant 👎 on a commit history like this in a shopify/shopfiy PR.
Let me or @lemonmade know when you're starting a new PR, and we can work this out together :)

@fandy would you consider adding a pre-push hook to prevent failing code from coming up for review, please?
In your shopify/javascript checkout dir:
echo 'cd packages/shopify-codemod && npm test' > .git/hooks/pre-push

This'll run the codemod tests, every time you try to git push, and back out if the tests fail.

Added a few more test cases. @lemonmade how does it look?

Updated.

@lemonmade is this PR ready to merge?


Return word vector as Numpy array

Currently we return word vector as a list of float value:
>>> import fasttext
>>> model = fasttext.load_model('test/generated_skipgram.bin')
>>> model['king']
[-0.018183724954724312, 0.02656036987900734, 0.011823349632322788, -0.013111250475049019, -0.0075991591438651085, -0.0013710453640669584, 0.053668685257434845, 0.007509157061576843, -0.025004932656884193, 0.018309008330106735]
>>>

We can use Numpy.array for easy computation in the future, no need to convert the vector again.
Feel free to send PR! 😄

Do we need to add a function
for eg.
list_to_narray() in fastText?

@rahulroxx hmm I think it's better to directly return the Numpy array via the C++ interface