github-runner: 2.320.0 -> 2.321.0

remove mentions of Node.js 16 which is not supported anymore see https://github.com/actions/runner/pull/3503
switch to .Net SDK 8 see https://github.com/actions/runner/pull/3500
fix source path discovery in deterministic build: runtime assumes that the root of the project is /_, replace it with actual /build/src so that tests can find their data.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@NixOS/nix-formatting Why did nixfmt check forced me to make this change: https://github.com/NixOS/nixpkgs/compare/23b17df5a709373bd3cfc297994ea54d06506707..19ab04a20aade9f1ae21726c8f4304dff2cc47d5 even though I didn't touch those lines or anything around them? Did some formatting style change since last change to this file? If it did, why is it considered formatted before my commit?

Result of nixpkgs-review pr 356300 run on x86_64-linux 1

1 package built:

github-runner


3.0.5 msvc env path construction problem

Additional paths (possibly extraneous) are being added to the msvc environment path for SCons 3.0.5 as compared to SCons 3.0.4.
The following paths are added to the ENV['PATH'] after the msvc configuration in SCons 3.0.5:
    C:\ProgramData\chocolatey\bin
    C:\msys64
    C:\msys
    C:\cygwin64\bin
    C:\cygwin\bin
    C:\Program Files\Java\jdk1.8.0_172\bin

The following paths are added to the ENV['PATH'] after the msvc configuration in SCons 3.0.4:
    C:\Program Files\Java\jdk1.8.0_172\bin;

When configured from the command line using vcvarsall.bat, the JDK is not added to the path.
If nothing else, this appears to violate The Law of Least Astonishment.
Configuration:

Scons: 3.0.5
Python: 2.7.14 on win32
OS: Windows 7 (32-bit)

scons-users message: https://pairlist4.pair.net/pipermail/scons-users/2019-March/007658.html
The additional SCons added paths cause build failures when user-specified mingw-w64 tools are added to the path using AppendENVPath.  In the test case, the cygwin/bin folder precedes the user desired mingw-w64 path that was manually added.
Due to the additional paths, PrependENVPath would have to be used instead to guarantee the desired tools would likely be invoked.
An annotated comparison of configurations of msvc 2005 and mingw-w64 from the command line, SCons 3.0.4 and SCons 3.0.5 is shown below.   The same holds for all tested versions of MSVC.
Command-line msvs 2005 environment:
    set PATH=C:\Windows\System32
    set INCLUDE=
    set LIB=
    set LIBPATH=
    call vcvarsall.bat

    Path=C:\Program Files\Microsoft Visual Studio 8\Common7\IDE;               <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\VC\BIN;                    <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\Common7\Tools;             <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\bin;         <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\bin;        <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\SDK\v2.0\bin;              <== msvc [ok]
         C:\Windows\Microsoft.NET\Framework\v2.0.50727;                        <== msvc [ok]
         C:\Program Files\Microsoft Visual Studio 8\VC\VCPackages;             <== msvc [ok]
         C:\Windows\System32                                                   <== system [ok]

    LIB=C:\Program Files\Microsoft Visual Studio 8\VC\ATLMFC\LIB;              <== msvc [ok]
        C:\Program Files\Microsoft Visual Studio 8\VC\LIB;                     <== msvc [ok]
        C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\lib;         <== msvc [ok]
        C:\Program Files\Microsoft Visual Studio 8\SDK\v2.0\lib;               <== msvc [ok]

    LIBPATH=C:\Windows\Microsoft.NET\Framework\v2.0.50727;                     <== msvc [ok]
            C:\Program Files\Microsoft Visual Studio 8\VC\ATLMFC\LIB           <== msvc [ok]

    INCLUDE=C:\Program Files\Microsoft Visual Studio 8\VC\ATLMFC\INCLUDE;      <== msvc [ok]
            C:\Program Files\Microsoft Visual Studio 8\VC\INCLUDE;             <== msvc [ok]
            C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSDK\include; <== msvc [ok]
            C:\Program Files\Microsoft Visual Studio 8\SDK\v2.0\include;       <== msvc [ok]

SCons 3.0.4 mingw build ENV{}:
    PATH: C:\\Windows\\System32;                                               <== system [ok]
          C:/Software/MINGW810-V6R0-WIN32SJLJ/mingw32/bin;                     <== user AppendENVPath [ok]
          C:/Software/MSVS141/VC/Tools/MSVC/14.16.27023/bin/HostX86/x86        <== user AppendENVPath [ok]

SCons 3.0.4 msvs 2005 build ENV{}:
    PATH: C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\IDE;          <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN;               <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools;        <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools\\bin;   <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\bin;  <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\bin;        <== msvc [ok]
          C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;                   <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\VCPackages;        <== msvc [ok]
          C:\\Windows\\System32;                                               <== system [ok]
          C:\\Windows\\System32\\Wbem;                                         <== system [ok]
? ==>     C:\\Program Files\\Java\\jdk1.8.0_172\\bin;                          <== SCONS [?]
          C:/Software/MINGW810-V6R0-WIN32SJLJ/mingw32/bin',                    <== user AppendENVPath [ok]

    LIB: C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\LIB;        <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\VC\\LIB;                <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\lib;   <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\lib          <== msvc [ok]

    LIBPATH: C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;                <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\LIB',   <== msvc [ok]

    INCLUDE: C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\INCLUDE;      <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\INCLUDE;              <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\include; <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\include;       <== msvc [ok]
             E:/Local/STK/include/c99_msinttypes;                                    <== user [ok]
             E:/Local/STK/include/c99_stdbool                                        <== user [ok]

SCons 3.0.5 mingw build ENV{}:
    PATH: C:\\Windows\\System32;                                               <== system [ok]
          C:/Software/MINGW810-V6R0-WIN32SJLJ/mingw32/bin;                     <== user AppendENVPath [ok]
          C:/Software/MSVS141/VC/Tools/MSVC/14.16.27023/bin/HostX86/x86        <== user AppendENVPath [ok]

SCons 3.0.5 msvs 2005 build ENV{}:
    PATH: C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\IDE;          <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN;               <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools;        <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools\\bin;   <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\bin;  <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\bin;        <== msvc [ok]
          C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;                   <== msvc [ok]
          C:\\Program Files\\Microsoft Visual Studio 8\\VC\\VCPackages;        <== msvc [ok]
          C:\\Windows\\System32;                                               <== system [ok]
          C:\\Windows\\System32\\Wbem;                                         <== system [ok]
? ==>     C:\\ProgramData\\chocolatey\\bin;                                    <== SCONS [?]
? ==>     C:\\msys64;                                                          <== SCONS [?]
? ==>     C:\\msys;                                                            <== SCONS [?]
? ==>     C:\\cygwin64\\bin;                                                   <== SCONS [?]
? ==>     C:\\cygwin\\bin;                                                     <== SCONS [?]
? ==>     C:/Program Files\\Java\\jdk1.8.0_172\\bin;                           <== SCONS [?]
          C:/Software/MINGW810-V6R0-WIN32SJLJ/mingw32/bin                      <== user AppendENVPath [ok]

    LIB: C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\LIB;        <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\VC\\LIB;                <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\lib;   <== msvc [ok]
         C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\lib          <== msvc [ok]

    LIBPATH: C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;                <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\LIB     <== msvc [ok]

    INCLUDE: C:\\Program Files\\Microsoft Visual Studio 8\\VC\\ATLMFC\\INCLUDE;      <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\INCLUDE;              <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\include; <== msvc [ok]
             C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\include;       <== msvc [ok]
             E:/Local/STK/include/c99_msinttypes;                                    <== user [ok]
             E:/Local/STK/include/c99_stdbool                                        <== user [ok]

Can you add a SConstruct to repro this?

could this be related: https://github.com/SCons/scons/pull/3287

I don't know if this helps, the following SConstruct file:
env = Environment(MSVC_VERSION="8.0", TARGET_ARCH="x86_64")
print env.Dump()

Produces this output:
sample_env.txt
Path (the paths marked do not exist):
           'PATH':
                'C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\IDE;
                 C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN\\x86_amd64;
                 C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN;
                 C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools;
                 C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools\\bin;
                 C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\bin;
                 C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;
                 C:\\Program Files\\Microsoft Visual Studio 8\\VC\\VCPackages;
                 C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\bin;
                 C:\\Windows\\System32;C:\\Windows\\System32\\Wbem;
=>            C:\\ProgramData\\chocolatey\\bin;
=>            C:\\msys64;
=>            C:\\msys;
=>            C:\\cygwin64\\bin;
                 C:\\cygwin\\bin;
                 C:/Program Files\\Java\\jdk1.8.0_172\\bin',

The marked builders are new in 3.0.5 and did not exist in 3.0.4:
  'BUILDERS': {
=>   'CFile': <SCons.Builder.CompositeBuilder object at 0x0236D030>,
        'Zip': <SCons.Builder.BuilderBase object at 0x02357530>,
        'MSVSProject': <SCons.Builder.BuilderBase object at 0x022D3BB0>,
        'RES': <SCons.Builder.BuilderBase object at 0x022D3CD0>,
        'TypeLibrary': <SCons.Builder.BuilderBase object at 0x02309D70>,
        'StaticLibrary': <SCons.Builder.BuilderBase object at 0x02365F30>,
        'PCH': <SCons.Builder.BuilderBase object at 0x022D3BF0>,
        'Program': <SCons.Builder.BuilderBase object at 0x02357930>,
        'ProgramAllAtOnce': <SCons.Builder.BuilderBase object at 0x02357B30>,
=>   'Substfile': <SCons.Builder.BuilderBase object at 0x02357590>,
=>   'CXXFile': <SCons.Builder.CompositeBuilder object at 0x0236D0B0>,
        'Object': <SCons.Builder.CompositeBuilder object at 0x02357C70>,
        'JavaClassDir': <SCons.Builder.BuilderBase object at 0x0236D350>,
        'LoadableModule': <SCons.Builder.BuilderBase object at 0x02357BB0>,
=>   'Textfile': <SCons.Builder.BuilderBase object at 0x02357810>,
        'MSVSSolution': <SCons.Builder.BuilderBase object at 0x022D3BD0>,
        'CopyAs': <SCons.Builder.BuilderBase object at 0x02357B50>,
        'SharedLibrary': <SCons.Builder.BuilderBase object at 0x023578B0>,
        'CopyTo': <SCons.Builder.BuilderBase object at 0x02357AD0>,
        'StaticObject': <SCons.Builder.CompositeBuilder object at 0x02357C70>,
        'SharedObject': <SCons.Builder.CompositeBuilder object at 0x02357D10>,
        'JarFile': <SCons.Builder.BuilderBase object at 0x0236D1F0>,
        'JavaClassFile': <SCons.Builder.BuilderBase object at 0x0236D290>,
        'Library': <SCons.Builder.BuilderBase object at 0x02365F30>,
        'RMIC': <SCons.Builder.BuilderBase object at 0x02326B70>,
        'JavaFile': <SCons.Builder.CompositeBuilder object at 0x0236D2F0>
  },

Perhaps coming from the lex tool?

It's got to come from the stanza in Tool/__init__.py, where it steps through the passed-in paths from a tool (default_paths) and then, if there was a match, doesn't restore the saved PATH, which means that everything that was appended is kept, even the ones which didn't yield a match.
    # If that doesn't work try default location for mingw
    save_path = env['ENV']['PATH']
    for p in default_paths:
        env.AppendENVPath('PATH', p)
    path = env.WhereIs(key_program)
    if not path:
        env['ENV']['PATH'] = save_path
    return path

So a quick guess is this might help:

diff --git a/src/engine/SCons/Tool/__init__.py b/src/engine/SCons/Tool/__init__.py
index 74dba75c..820435b9 100644
--- a/src/engine/SCons/Tool/__init__.py
+++ b/src/engine/SCons/Tool/__init__.py
@@ -1338,8 +1338,9 @@ def find_program_path(env, key_program, default_paths=[]):
     for p in default_paths:
         env.AppendENVPath('PATH', p)
     path = env.WhereIs(key_program)
-    if not path:
-        env['ENV']['PATH'] = save_path
+    env['ENV']['PATH'] = save_path
+    if path:
+        env.AppendENVPath('PATH', path)
     return path

 # Local Variables:

The following SConstruct behaves as expected:
env = Environment(MSVC_VERSION="8.0", TARGET_ARCH="x86_64", tools=['mslink','msvc','mslib','msvs'])
print env.Dump()

Output:
sample_env2.txt
Path:
'PATH':
    'C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\IDE;
     C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN\\x86_amd64;
     C:\\Program Files\\Microsoft Visual Studio 8\\VC\\BIN;
     C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools;
     C:\\Program Files\\Microsoft Visual Studio 8\\Common7\\Tools\\bin;
     C:\\Program Files\\Microsoft Visual Studio 8\\VC\\PlatformSDK\\bin;
     C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727;
     C:\\Program Files\\Microsoft Visual Studio 8\\VC\\VCPackages;
     C:\\Program Files\\Microsoft Visual Studio 8\\SDK\\v2.0\\bin;
     C:\\Windows\\System32;C:\\Windows\\System32\\Wbem',

Explicitly listing the msvc/msvs tools results in the expected path construction.  I'm guessing the reason that the tools were not specified explicitly was that the default construction (up until 3.0.5) was what was expected (with the addition of the JDK).  The JDK addition now makes sense in terms of the default environment.
It appears that I'm the tool in this case.

The default tool set is intended to make things simpler, you don't have to figure out all the tools your project needs (if what you need is included in the defaults).  Bill has concluded that it's quite a bit faster to not use the default set, and just list the ones you want, particularly on windows platforms.  For what it's worth...

The irony is that for my builds the tools are passed for the mingw-w64 builds and explicit folders were being appended to the path for msvc builds.  It was purely an oversight that the tools were not passed for msvc builds. In almost all cases I do not want cygwin silently added to the path.  I learned something valuable moving forward.

If you apply the patch that Mats posted without listing the tools
explicitly, does it fix your issue?
On Wed, Mar 27, 2019 at 11:37 AM jcbrill<EMAIL_ADDRESS>wrote:

The irony is that for my builds the tools are passed for the mingw-w64
builds and explicit folders were being appended to the path for msvc
builds. It was purely an oversight that the tools were not passed for msvc
builds. In almost all cases I do not want cygwin silently added to the
path. I learned something valuable moving forward.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/issues/3336#issuecomment-477296872, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFBNGXOzBuk8VjZqEVbt58a8GzP5puzks5va7pvgaJpZM4cNxvA
.

I will try to apply the patch later today.
The patch will not change the build failure that I experienced.  My build script must be changed to accommodate the default SCons 3.0.5 behavior in one of two ways: (1) explicitly pass the tools for msvc to the environment and use AppendENVPath for dlltool or (2) make no changes to the environment and change AppendENVPath for dlltool to PrependENVTool.  I have elected the first option.
To recap:  there are paths added to the default environment ENV[PATH] that do not exist on my computer.  I suppose that is a bug.  The two line SConstruct file attached above demonstrates and simply reproduces  this behavior.  Any version of MSVC could be passed to the environment (or probably even none at all).  Paths that don't exist really have no effect other that polluting the path.
The build failure that I experienced is because one of the additional paths added to the default environment ENV[PATH] constuction does exist (cygwin/bin).  Cygwin/bin contains flex.exe (which is what I suspect SCons was looking for) and also a variety of gcc/mingw tools.  The path location that I eventually add manually to the end of the ENV[PATH] using AppendENVPath for the desired dlltool executable is meaningless since there is already a dlltool in the path.  This is not a bug but an unintended consequence of the construction of the default environment.
If I understand the patch correctly, paths that do not exist will not be added to the path.  That's all well and good.  However my problem was with an unintended consequence of an added path that does exist conflicting with my expectations of behavior based on SCons 3.0.4 and earlier.  The only solution to my build problem is to change my script as described earlier.
I fear that adding cygwin to the path may break a number of scripts that are using AppendENVPath to explicitly add tools to the default environment.

I will try to apply the patch later today.
The patch will not change the build failure that I experienced.
...
To recap: there are paths added to the default environment ENV[PATH] that do not exist on my computer. I suppose that is a bug.

That was the idea of the tiny patch: right now all the extra "possible places something could be found" are added as they are tried, and as long as the process ended with a "hit", they're kept; instead I try to keep just the "hit".

I just tried the first test.
Good news: folders that don't exist are not added to the path.
Bad news: the fully qualified executable is added to the path as well as the folder to the path:
C:\\cygwin\\bin\\flex.EXE;
C:\\cygwin\\bin;
C:\\Program Files\\Java\\jdk1.8.0_172\\bin\\jar.EXE;
C:\\Program Files\\Java\\jdk1.8.0_172\\bin',

Oh, I was afraid of that, wasn't sure if it came back as a directory or as a full path.  More thinking then - thanks for the quick update!

I don't think you need to add the path when it exists as the calling procedure likely will.  The following seems to work:
Original 3.0.5 code:
    # If that doesn't work try default location for mingw
    save_path = env['ENV']['PATH']
    for p in default_paths:
        env.AppendENVPath('PATH', p)
    path = env.WhereIs(key_program)
    if not path:
        env['ENV']['PATH'] = save_path
    return path

Modified 3.0.5  code:
    # If that doesn't work try default location for mingw
    save_path = env['ENV']['PATH']
    for p in default_paths:
        env.AppendENVPath('PATH', p)
    path = env.WhereIs(key_program)
    env['ENV']['PATH'] = save_path
    return path

The implications of the following excerpt from the 3.0.5 release email now makes a lot more sense:
SCons 3.0.5 Released

FIXES

  - Add default paths for yacc tool on windows to include cygwin, mingw, and chocolatey

Should be resolved in master now.


New version: eza-community.eza version 0.20.6

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/eza-community/eza/releases/download/v0.20.6/eza.exe_x86_64-pc-windows-gnu.zip
Status Code: 200
(Automated message - build 897)


The specific situation is as follows

Hello, I am so glad that you can answer my questions. The specific situation is as follows:
I don't know if this "github.com failed" is related to the lack of vpn, because we are in China. At present, the treep command has failed. We have completed the tick instructions according to the steps, and installed the treep plugin in pycharm. My system is ubuntu20.04.2LTS.
The following file is the problem that occurs when we run the program. I marked it with a screenshot. I hope you can help us answer our doubts. I will really appreciate you.
Doc2.docx

Hi,
I'd suggest you try to clone packages directly from Github instead of using Treep. If it's not working, maybe using VPN helps.


Diagnostic problems are not listed for first save of new php files.

Setup:
Windows 10 64-bit
Steps:

launch brackets
Create new files and select file type as PHP
Type <?php fopen()
Save the file

Result : Diagnostic problems are not shown
Expected: diagnostic problems should be shown
Workaround: make file dirty and save again

Fix is checked in as part of https://github.com/adobe/brackets/pull/14706


Suggestion to change in the installation

Hi, I just compiled the ESIM on my Ubuntu 16.04 machine with ROS Kinetic. I just recently setup my machine so the OS is rather clean. I noticed two problems during the installation:
First, In this line: https://github.com/uzh-rpg/ze_oss/blob/master/ze_cmake/cmake/modules/ze_setup.cmake#L4
The option Werror is turned on so that some warnings in the pyconfig.h will be flagged as errors. With this, I couldn't compile ze_matplotlib
Second, while I was compiling ze_splines, it gives me the following errors:
/usr/lib/x86_64-linux-gnu/libapr-1.so.0: undefined reference to<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
make[2]: *** [/home/dgywork/catkin_ws/devel/lib/ze_splines/viz_splines_test] Error 1
make[1]: *** [CMakeFiles/viz_splines_test.dir/all] Error 2
make: *** [all] Error 2

Turns out the version of libuuid supported by the Ubuntu 16.04 is too old. Since I have a conda on my machine, so I installed libuuid through conda to fix it:
conda install -c conda-forge libuuid

Yuhuang.

Hello,
Thanks for your feedback. I will leave the issue open for now in case anyone else runs into the same problem. I have never seen this problem, although I tested ESIM on the same system (Ubuntu 16.04 + ROS Kinetic). For reference, could you please tell me what version of Python, CMake, and gcc you are using?
Thanks.

I also met with same error by execute catkin_make (http://wiki.ros.org/catkin/Tutorials/workspace_overlaying 2.3Building Your catkin Workspace)
Python version: 2.7.16
CMake: 3.5.1
GCC: 6.5.0
libuuid-perl                                 0.24-1build1
libuuid1:amd64                               2.27.1-6ubuntu3.7

Hi, @charleschen6 are you using the Python supplied by Ubuntu, Virtual environment, or Conda?
In my case, because I link ROS with Conda's Python, so I can use libuuid in Conda.
Otherwise, maybe build the newer library from scratch?
Regards,
Yuhuang.

Python version: 2.7.12
CMake: 3.5.1
GCC: 5.4.0
Ubuntu 16.04 + ROS Kinetic
I also met with same error by execute catkin_make
/usr/lib/x86_64-linux-gnu/libapr-1.so.0: undefined reference to<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/build.make:119: recipe for target '/home/student908/wuda/guanmeng/DRL_Path_Planning/devel/lib/interactive_marker_twist_server/marker_server' failed
make[2]: *** [/home/student908/wuda/guanmeng/DRL_Path_Planning/devel/lib/interactive_marker_twist_server/marker_server] Error 1
CMakeFiles/Makefile2:5350: recipe for target 'interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/all' failed
make[1]: *** [interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/all] Error 2
I'm looking forward to your help,thanks

Python version: 2.7.12
CMake: 3.5.1
GCC: 5.4.0
Ubuntu 16.04 + ROS Kinetic
I also met with same error by execute catkin_make
/usr/lib/x86_64-linux-gnu/libapr-1.so.0: undefined reference to<EMAIL_ADDRESS>collect2: error: ld returned 1 exit status
interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/build.make:119: recipe for target '/home/student908/wuda/guanmeng/DRL_Path_Planning/devel/lib/interactive_marker_twist_server/marker_server' failed
make[2]: *** [/home/student908/wuda/guanmeng/DRL_Path_Planning/devel/lib/interactive_marker_twist_server/marker_server] Error 1
CMakeFiles/Makefile2:5350: recipe for target 'interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/all' failed
make[1]: *** [interactive_marker_twist_server/CMakeFiles/interactive_marker_twist_server.dir/all] Error 2
I'm looking forward to your help,thanks

I have soleved the problem by downloading new flycapture2 to reinstall https://github.com/ErnestDeiven/flycapture2

Possible solution fro libuuid:
It is good to remove the libuuid library file under anaconda2/lib, and finally solved this problem. ls ~/anaconda2/lib/libuuid* mkdir ~/anaconda2/libuuid mv ~/anaconda2/lib/libuuid* ~/anaconda2/libuuid
From here

Possible solution for libuuid:
"It is good to remove the libuuid library file under anaconda2/lib, and finally solved this problem."
ls ~/anaconda2/lib/libuuid*
mkdir ~/anaconda2/libuuid
mv ~/anaconda2/lib/libuuid* ~/anaconda2/libuuid
From here

You saved my day bro!


Feature/add singleton provider in template

Add user repository as singleton provider in opinionated template so it can save and list informations in memory repository without any changes in application.
As it was before, the repositories was reinstanciating at every usecase call, losting the info saved in memory. This could be observed by downloading the opinionated template, calling the CreateUserController and then the FindAllController, that would return an empty array, not the user created.
It is important for users that want to download the opinionated template and start to write new usecases or tests immediately, embrancing TDD methods.

Hi @VitorCaminha the idea is great and we will adopt for sure. However I need some more time to have a deep analysis on this and I will share the full idea with you during this week. We have a bigger problem to resolve other than just assigning singleton binding to a class. This idea will be used for sure for individual classes, however we need to investigate the transient, scope and singleton binding solution more closely. This week I will ping you about this.


Fixing ACPI table dependencies

Fixes build upgrade issues in Windows
Fixes setup failures / hangs in Windows
Windows Setup process is now faster

Changes validated on the following devices:

Cityman ROW (RM-1085/RM-1116)
Talkman ROW (RM-1104)
Hapanero (RX-130 EB2.2/EB2.3)

Changes are not ready for MSM8992 yet, PEP added dependencies seem to cause a "WDF_VIOLATION" issue, most likely because somehow windows inbox driver superseeds ours. Might either revert the PEP dependency changes or remove the CID from the PEP device for 8992.

Changes re-validated on Talkman ROW (RM-1104).
Status: working


Sorting standards not working as expected

https://github.com/strongdm/comply/blob/master/internal/render/controller.go#L82
The sort algorithm in Go library sorting for example:
A1
A11
A111
A2
Instead of:
A1
A2
A11
A111
I think a fix might look something like this: https://softwareengineering.stackexchange.com/questions/127639/why-do-some-sorting-methods-sort-by-1-10-2-3
But not sure, this is low priority, visual only. I am using FISMA NIST 800-53 standards that employ this type of formating: AC-1, AC-1(1), AC-1(2), etc.

An option to disable sorting would be nice as well, I am using the docker container so it's hard to rebuild.


Font Flickering Issue when Hovering Over Setting Categories in VS Code on Linux

Type: Bug
When using Visual Studio Code (VS Code) on Linux, there is an issue with font flickering when hovering over setting categories on the left side of the application. This problem does not occur on Windows 11.
Steps to Reproduce:

Launch VS Code on a Linux machine.
Open the settings menu by clicking on the gear icon located at the bottom left corner of the window.
Observe the setting categories listed on the left-hand side of the settings menu.
Hover the mouse cursor over any of the setting categories.
Notice the font flickering effect while hovering.

Expected Behavior:
The font of the setting categories should remain stable and not flicker when hovering over them, similar to the behavior observed on Windows 11.
Additional Information:

This issue has been tested on multiple Linux distributions with different desktop environments, and the problem persists across all of them.
The issue does not occur on Windows 11, indicating that it is specific to the Linux version of VS Code.

Impact:
The font flickering is visually distracting and may cause discomfort to users when navigating through the settings menu. It could potentially affect the overall user experience for Linux users of VS Code.
Severity:
This issue may not directly impact the functionality of VS Code, but it significantly affects the visual aesthetics and user experience, hence it should be addressed with moderate priority.
Attachment:
https://github.com/microsoft/vscode/assets/32993907/8dce88ea-3432-4a78-a37c-1d48b2a98752
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:25.257Z)
OS version: Linux x64 5.15.0-76-generic
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i5-11320H @ 3.20GHz (8 x 3200)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
15.40GB (10.65GB free)

Process Argv
--unity-launch --crash-reporter-id 1b1713cf-e155-4c2a-8375-fc8c785c348c

Screen Reader
no

VM
0%

DESKTOP_SESSION
cinnamon

XDG_CURRENT_DESKTOP
X-Cinnamon

XDG_SESSION_DESKTOP
cinnamon

XDG_SESSION_TYPE
x11

Extensions (5)

Extension
Author (truncated)
Version

copilot
Git
1.98.275

copilot-chat
Git
0.4.0

python
ms-
2023.12.0

vscode-pylance
ms-
2023.7.30

remote-containers
ms-
0.299.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscaat:30438848
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30779714
pythonidxpt:30784022
pythonnoceb:30776495
e537b577:30795824
dsvsc013:30795093
dsvsc014:30791935

Does the issue still occur when running with the --disable-gpu flag, i.e. code --disable-gpu?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Project Bug - Can't make someone a Manager

"The project is called: "Central Coast & Surrounds - UC California Naturalist Project".
The Admin is Brett Hall and he and I share access to the account via his sign in but I would like to be formally added as a manager. I am currently assistant admin for this project but not via iNaturlist. My iNaturalist username is"samanthaspurlin".
Brett tried to add me as "Manager" under Project Members but we receive the following error message: "Project user cannot be found". And the really odd part is that it seems to take us to a different project called "123" whose admin is floralin92."
When signing in as Brett I was able to replicate this issue.

Not sure what was going on here but I can no longer replicate it.


Hal jsonschema

I've added the tests. Still one problem, while comparing the container variables, but I couldn't find the clue.

rebased main branch into this branch


[Feature request] URL / URI built in validator

At minimum all this would need to do would be to check if the provided string is a url (i.e. urllib's urlparse function doesn't throw an error when trying to parse it).  If we wanted to get fancy, we could expose the parsed components and allow regex against them (ex. to allow both http and https but not anything else ex. ftp as the protocol).
There are workarounds that one could use, i.e. using the regex validator and grabbing one of the many regex's floating around on the internet and hoping that it actually does correctly validate for a valid url, but that feels more sketchy of a solution than it needs to be.

To validate any possible URL without specifying any patterns to help the validator would be a momentous task as there are a myriad of possible URLs/URIs that one could call valid. And if you end up needing to feed patterns to the validator it's very close to using regex anyways. As far as I know, urlparse will never throw an error as long as it receives a string as input.
I would definitely like this feature as well though, so hopefully the maintainers are more creative and optimistic than I am :)

To validate any possible URL without specifying any patterns to help the validator would be a momentous task as there are a myriad of possible URLs/URIs that one could call valid. And if you end up needing to feed patterns to the validator it's very close to using regex anyways.

Yeah, this is a good example of how convoluted it gets

As far as I know, urlparse will never throw an error as long as it receives a string as input.
To help illustrate your point:

>>> [urllib.parse.urlparse(url).hostname for url in ['really', 'anything.com', 'cat://will', 'work+just://fine.?', 'http://notveryhelpful?baz=bar']]
[None, None, 'will', 'fine.', 'notveryhelpful']

So there would definitely need to be constraints/configuration. I think Pydantic does a good job of enumerating what most people might find useful.

I would definitely like this feature as well though, so hopefully the maintainers are more creative and optimistic than I am :)

Right now we're pretty resource constrained but we'll gladly accept pull requests if someone is up to the challenge!


split happy rdev build and deploy steps for explorer and portal

When creating an rdev stack via happy-path, the docker image(s) are built and deployed from the respective repos' GHA workflows. This makes it difficult to create an rdev stack using local happy command, since the docker builds are huge and take time to upload. Other docker build issues may also be encountered, such as trying to build on an alternate, non-Intel architecture (M1 arm64, e.g.).
Simplify the rdev stack creation process by:

Build docker image on GHA for Explorer, for any branch name prefixed withrdev- (same as for Portal)
For Portal, only build the docker image on GHA, but do not deploy the image to rdev stack. This will be done via single-cell-infra happy script, which coordinate the deployment of both Explorer and Portal components.
Support creation of docker images with a shared tag, to simplify creation of happy rdev stack using a single tag name.

shared-infra PR: https://github.com/chanzuckerberg/shared-infra/pull/4271

Manually added (pseudo) secrets to single-cell-explorer repo:
AWS_ROLE_TO_ASSUME=arn:aws:iam::699936264352:role/ci/corpora_github_actions_dev
ECR_REPO=699936264352.dkr.ecr.us-west-2.amazonaws.com/corpora-explorer

Also  invited "cziie" user to repo so rotator can add the AWS_* keys.


UMLS semantic types not being applied

Despite presence of attributes like hasSTY, nodes with corresponding semantic types are not being assigned the corresponding Biolink category.
The STY ontology is being correctly mapped:
id      category        name    description     provided_by
STY:T058        biolink:Activity                        Semantic Types Ontology
STY:T057        biolink:Activity                        Semantic Types Ontology
STY:T056        biolink:Activity                        Semantic Types Ontology
STY:T055        biolink:Behavior                        Semantic Types Ontology
STY:T054        biolink:Behavior                        Semantic Types Ontology
STY:T053        biolink:Behavior                        Semantic Types Ontology
STY:T052        biolink:Activity                        Semantic Types Ontology

Yet these don't end up in the UMLS ontologies:
$ more MEDDRA_20_nodes.tsv
id      category        name    description     provided_by
MEDDRA:10007469 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)
MEDDRA:10007467 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)
MEDDRA:10007468 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)
MEDDRA:10007465 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)
MEDDRA:10007466 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)
MEDDRA:10007463 biolink:OntologyClass                   Medical Dictionary for Regulatory Activities Terminology (MedDRA)

This may be happening because append_new_types() assumes node IDs are not CURIEs, which is fine if we haven't done CURIE remapping, but it's more likely that we'll have them.


Add some minor changes to the “no bold” theme variant

This pull request changes the casing to “No Bold” and add a space before the parenthesis in the theme name.

@jonkri thanks )


Route KeyStore logs to NativeLogger

Also add a lot more KeyStore logs.

r? @keybase/react-hackers cc @patrickxb


The built failed likely due to AndroidX incompatibilities in a plugin.

My local.properties:
sdk.dir=/Users/dwh/Library/Android/sdk
flutter.sdk=/Users/dwh/Desktop/coding/flutter
flutter.buildMode=release
flutter.versionName=1.0.0
flutter.versionCode=1

and in other project, it build succeed
youqiyun git:(master) ✗ flutter build apk --target-platform android-arm,android-arm64 --split-per-abi

FAILURE: Build failed with an exception.

What went wrong:

logs
Execution failed for task ':city_pickers:verifyReleaseResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  Output:  /Users/dwh/Desktop/coding/demos/youqiyun/build/city_pickers/intermediates/res/merged/release/values/values.xml:186: error: resource android:attr/fontVariationSettings not found.
  /Users/dwh/Desktop/coding/demos/youqiyun/build/city_pickers/intermediates/res/merged/release/values/values.xml:187: error: resource android:attr/ttcIndex not found.
  error: failed linking references.

Running Gradle task 'assembleRelease'... Done                      13.7s
The built failed likely due to AndroidX incompatibilities in a plugin. The tool is about to try using
Jetfier to solve the incompatibility.
Building plugin city_pickers...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    1.7s
✓ Built build/app/outputs/repo.
Building plugin fluttertoast...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    1.6s
✓ Built build/app/outputs/repo.
Building plugin image_picker...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    1.1s
✓ Built build/app/outputs/repo.
Building plugin local_auth...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    1.1s
✓ Built build/app/outputs/repo.
Building plugin path_provider...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    0.9s
✓ Built build/app/outputs/repo.
Building plugin screen...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    0.8s

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/dwh/Desktop/coding/flutter/.pub-cache/hosted/pub.flutter-io.cn/screen-0.0.5/android/build.gradle' line: 11

* What went wrong:
A problem occurred evaluating root project 'screen'.
> Flutter SDK not found. Define location with flutter.sdk in the local.properties file.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s

The plugin screen could not be built due to the issue above.

Hi @aboutmydreams
could you please provide your updated  flutter doctor -v
and your flutter build --verbose ?
Also, to better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem
Thank you

I solve it by change the branch(master) to beta

I solve it by change the branch(master) to beta

Could you elaborate what exactly you did??

I solve it by change the branch(master) to beta

Could you elaborate what exactly you did??

Hi @aboutmydreams
could you please provide your updated flutter doctor -v
and your flutter build --verbose ?
Also, to better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem
Thank you

I had a similar problem.Please refer the screenshot below:

When i ran flutter doctor -v I got:

and flutter build --verbose

Please help me

same pronlem help someone or you will die

Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Channel design issue with Homer 3

Hi, I noticed that the .snirf data generated by Lumo cannot be properly read by Homer 3 in terms of the channel layout and channel index.
For instance, when two tiles are placed in separate L and R temporal locations, Homer 3 will present inter-channels connecting the two tiles. This means that a source will be linked to every detector on both tiles, resulting in numerous artificial channels. These channels do not actually exist during the recording in Lumo software. For example, source 4 connected to detector 2, S1 to D6, and so on.

With more tiles added, you can see more and more fake channels are added in the Homer3, causing trouble to find the index of real channels. AtlasViewerGUI will also present channels in this way, so I guess that might also relate to my previous issues about image reconstruction.

When only using a single tile, this problem won't occur.

I checked the functions used in lumomat on channels, it looks like the channel information is loaded right from the layout file. As long as the layout file is correct, I am not sure why the .snirf is not corresponded to .lufr.
Could you help me check this issue? As it really affects us doing by channel analysis and image reconstruction.
Step:

download the testing package: https://gocuhk-my.sharepoint.com/:f:/g/personal/siqigao_cuhk_edu_hk/EiQ5z3eZMU9JrgPzkRW_3VsBXG98dYIlhSwWtNIZnwB58A?e=px5Eb4
set folder 1T, 2T and 12T respectively as the working directory in the matlab cmd and call out the Homer3 immediately to load every snirf file. After Homer3 loads the file, you can see the channels on the right side.

system info:
win 11
software version: Matlab 2023b
Homer3 1.80.2
AtlasViewerGUI 2.44.0
Lumomat 18.0

For instance, when two tiles are placed in separate L and R temporal locations, Homer 3 will present inter-channels connecting the two tiles. This means that a source will be linked to every detector on both tiles,

This is the correct behaviour.
LUMO can record both intra- and inter-tile channels across a cap. As such, we see no error in the data files nor the converted SNIRF files.

For instance, when two tiles are placed in separate L and R temporal locations, Homer 3 will present inter-channels connecting the two tiles. This means that a source will be linked to every detector on both tiles,

This is the correct behaviour.
LUMO can record both intra- and inter-tile channels across a cap. As such, we see no error in the data files nor the converted SNIRF files.

I just got replied from Gowerlab support team. They confirmed that source can be seen by all the detectors but only closely enough will form channels.

In addition, when selecting two tiles on LumoX GUI, it would not indicate any inter channels between those two.
I am wondering why there is divergence between Homer and LumoX. So which one we should refer to? Thank you.
I will also forward this issue to the research support.

I am closing this issue as it does not appear to relate to lumomat.

Is it possible for lumomat to include the intra tiles channels only？
@samuelpowell

No this is not supported as inter-tile channels are required in most conceivable applications.


waitFor throws misleading error on invalid selector

When waitFor(...) or any function using waitFor(...) is called with an invalid CSS selector, it will throw an error saying the timeout exceeded. The expected behavior would be a message saying that the CSS selector is invalid.
I am using<EMAIL_ADDRESS>Code to reproduce:
let browser
async function main () {
  browser = await wendigo.createBrowser({ headless: false })
  await browser.open('https://github.com')
  await browser.waitAndClick('invalid[selector')
}

main()
  .catch(console.error)
  .finally(() => browser && browser.close())

Result:
{ TimeoutError: waiting for selector "invalid[selector" failed: timeout 500ms exceeded
    at new WaitTask (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld._waitForSelectorOrXPath (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/DOMWorld.js:478:22)
    at DOMWorld.waitForSelector (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/DOMWorld.js:432:17)
    at Frame.waitForSelector (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/FrameManager.js:627:47)
    at Frame.<anonymous> (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/helper.js:112:23)
    at Frame.waitFor (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/FrameManager.js:612:19)
    at Page.waitFor (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/Page.js:1116:29)
    at PuppeteerPage.<anonymous> (/workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:102:29)
    at Generator.next (<anonymous>)
    at /workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:8:71
  -- ASYNC --
    at Frame.<anonymous> (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/helper.js:111:15)
    at Frame.waitFor (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/FrameManager.js:612:19)
    at Page.waitFor (/workspace/vuer_oss/node_modules/wendigo/node_modules/puppeteer/lib/Page.js:1116:29)
    at PuppeteerPage.<anonymous> (/workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:102:29)
    at Generator.next (<anonymous>)
    at /workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:4:12)
    at PuppeteerPage.waitFor (/workspace/vuer_oss/node_modules/wendigo/dist/lib/puppeteer_wrapper/puppeteer_page.js:101:16)
    at obj.<anonymous> (/workspace/vuer_oss/node_modules/wendigo/dist/lib/browser/mixins/browser_wait.js:44:34) name: 'TimeoutError' }

Fix:
Here it should not swallow err if err is not a timeout error. The same applies to every function using waitFor(...) (e.g. waitAndClick(...), waitUntilNotVisible(...), etc.)

Good catch!, this probably could be solved with the @OverrideError() decorator I will fix this before the next release

@benjaminlaib
After checking this issue, a few details:
No extra checks on css validity are done by wendigo (the example you provide is actually valid css, at least for document.querySelectorAll, so in the case you expose, the error should still be timeoutError
Feeding an invalid  selector (e.g. p[header=) that throws a DOMException is swallowed by the try...catch as you said, this behaviour can be changed so a queryError is thrown instead. Does this make sense?

@angrykoala
Yes, the CSS selector I wrote in the issue is indeed correct, sorry about that. However when this bug occurred I was using a definitely invalid selector by accident (something along the lines of .some .class[data-hello="world" .otherclass[data-bla="blub"], note the missing closing bracket after .class), which resulted in a SyntaxError in the browser's context.
I took a look at your commit, and there are two things I noticed:

I think instead of swallowing everything that is not a DOMException and assuming they are automatically TimeoutErrors Wendigo should rather check whether err is an instance of TimeoutError, which is exported in puppeteer/lib/Errors.js. I looked in puppeteers source and in theory, that should be the error that gets thrown whenever a wait function times out.

TimeoutError still gets swallowed in all of the other waitFor functions here, here, here, here, here and here.

Thank you for your quick response! I am sorry for just complaining instead of submitting a PR, I will try to send one today that fixes the aforementioned things.

Thanks for the comprehensive review @benjaminlaib, your comment is completely right,I've reopened this issue

Any progress / workarounds for this?

Hi @facusantillo no progress for now, the PR wasn't updated so it was closed due to inactivity and I have not gotten around to fix this yet.
Sadly, I don't think there is a viable workaround without actually fixing this in Wendigo. I'll try to patch it around as soon as possible if this is generating so many problems, but I'm not sure when I'll be able to fix this
PRs are welcome, the closed PR by @benjaminlaib is actually a good starting point

For others running into the same problem: Temporal solution is to add a plugin with this function:
async waitUntil(condition: Function, timeout: number, name?: string) { 		let startTime = new Date().getTime(); 		while (!(await condition())) { 			if (new Date().getTime() - startTime > timeout) throw TimeoutException: condition ${name} didn't solve after ${timeout} seconds; 			await this.browser.wait(500); 		} 	}
Then can use it as follow:
`
await this.waitUntil(async () => (await this.newCampaignPopupElements.startButton()) !== null, 60000, 'Wait for start button');
`

All errors in wait-related messages have been improved to only override timeout errors (following @benjaminlaib recommendation)
This should fix problems with misleading errors in the following methods:

waitFor
waitUntilNotVisible
waitForUrl
waitForNavigation
waitForText
waitAndClick
waitUntilEnabled

These changes will be available on next release (2.13.1)
More work needed in the error handling as it is starting to take a toll in users experience, I'll open a separate issue for that.
For now, I'll close this issue


Work Package wp-bd.csv

I would like to work on this!

Results of Phase 1
wp-bd-result.csv

I completed this work package.


Authorizers: example contract snippet is missing import and V0

Relevant section. I needed:
//SPDX-License-Identifier: MIT
pragma solidity 0.8.9;

import<EMAIL_ADDRESS>
And needed to use IAuthorizerV0 instead of  IAuthorizer i.e.
contract everythingAuthorized is IAuthorizerV0

@martinkolenic - moving to Done as this is already being tested in CI as part of api3dao/airnode#1488. See here:
https://github.com/api3dao/airnode/blob/f2ca933df6bd99d840618ff8a2e884141a2af1a0/packages/airnode-examples/contracts/coingecko-e2e/EverythingAuthorizer.sol


Microsoft.html

Updated by looking more realistic than the previous (My first pull request)

Did you not like your changes ultimately?

I thought I had made a mistake with the code, turns out I had not. I am not going to put up the final version yet because I am still perfecting it.


Update search-howto-index-cosmosdb.md

I've been trying to figure this out for 2 days already and looks like with some of the latest changes the field has to be named id and not doc_id for Cosmos DB with MongoDB API. Only when I set up index like this it started to work normally, otherwise indexer would fail with an error Could not parse document. Document key cannot be missing or empty

@AndrewNikolin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change. @mgottein

Resolved the merge conflict. @mgottein @SnehaGunda - Could you review the proposed update and indicate whether the PR can be merged? Thank you.

Looks like the change may not be totally correct, I don't work on Azure Search docs, but the _id is valid for items in Cosmos DB.  @mgottein on the Search team is validating this further and will make further changes to the doc.

@AndrewNikolin unfortunately our docs weren't good enough here.
If you are using a non-partitioned mongo db collection, the correct field is "id"
If you are using a partitioned mongo db collection, the correct field is "doc_id"
Unfortunately your choice of key field name affects this as well in a confusing way.
We'll update the docs to make this scenario more clear. Apologies for the negative experience

@mattmsft hello! actually I remember that the collection was partitioned because Mongo DB API doesn't allow to create non-partitioned collections as for now. I can recheck all the setup and get back to you if that would help


Create 5.10_Everything_related_to_docker.md

Description 📜
Added everything related to Docker
Fixes #632

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Open  Source

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Thank you so much !


Add Boost.Geometry test category.

Since regression uses explicit-failures-markup.xml from master branch, would it be possible to merge this change into master?

It didn't apply cleanly so I copied the geometry markup from develop to master, hope that's okay.
https://github.com/boostorg/boost/commit/2f984e6c1638d9be276ee5d764e9051360d296f6

Thanks! It works correctly.


TR38 Bosses

Move sets/order may not be correct but frostbite moves should no longer be queued at ends of turns
Added stagnation for Diff4 passive, initial testing looks good

Merged in 07c6b18ef4b372a3a1ea9315e866dddd8c8bae34


EP02-F03-US01 - Have done this subject list

As a user I would like to see which students have done or are doing the selected subject


2.5.4

Added

doc: add examples in json schema

Fixed

fix #835: UnicodeDecodeError when loading json schema files
fix: RecursionError caused by checking root dir incorrectly on Windows

Codecov Report

Merging #839 into master will decrease coverage by 0.45%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
- Coverage    81.7%   81.25%   -0.46%
==========================================
  Files          34       34
  Lines        2509     2507       -2
==========================================
- Hits         2050     2037      -13
- Misses        459      470      +11

Flag
Coverage Δ

#unittests
81.25% <100%> (-0.46%)
:arrow_down:

Impacted Files
Coverage Δ

httprunner/utils.py
78.62% <ø> (-3.66%)
:arrow_down:

httprunner/loader/locate.py
95.55% <100%> (-2.07%)
:arrow_down:

httprunner/loader/check.py
58.67% <100%> (+0.34%)
:arrow_up:

httprunner/api.py
92.8% <0%> (-1.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c37921...2772145. Read the comment docs.


[Event Request] Assembly Header, Procedure SetItemToPlanFilters

Hi,
we want to add filters in the procedure "SetItemToPlanFilters" and therfore we need the following event at the end of this procedure:
  procedure SetItemToPlanFilters(var Item: Record Item; DocumentType: Enum "Assembly Document Type")
   begin
       Reset();
       SetCurrentKey("Document Type", "Item No.", "Variant Code", "Location Code");
       SetRange("Document Type", DocumentType);
       SetRange("Item No.", Item."No.");
       SetFilter("Variant Code", Item.GetFilter("Variant Filter"));
       SetFilter("Location Code", Item.GetFilter("Location Filter"));
       SetFilter("Due Date", Item.GetFilter("Date Filter"));
       SetFilter("Shortcut Dimension 1 Code", Item.GetFilter("Global Dimension 1 Filter"));
       SetFilter("Shortcut Dimension 2 Code", Item.GetFilter("Global Dimension 2 Filter"));
       SetFilter("Remaining Quantity (Base)", '<>0');
       SetFilter("Unit of Measure Code", Item.GetFilter("Unit of Measure Filter"));

       // This new event:
       OnAfterFilterLinesWithItemToPlan(Rec, Item, DocumentType.AsInteger());
   end;

The signature of the event looks like this:
[IntegrationEvent(false,false)]
local procedure OnAfterFilterLinesWithItemToPlan(Rec: Record "Assembly Header"; var Item: Record Item; DocumentType: Option)
begin
end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Act on Dependabot's security -based recommendations

Fixes #28.
I also introduce GitHub Actions -based CI, as opposed to Travis, and remove references to david-dm.org (at the time shown as "no longer available" (maybe you want a different element here?)

For the GitHub action to run, since this is my first contribution and the action's first appearance too, you might have to approve it's use; otherwise you can see results in my fork: https://github.com/paulo-ferraz-oliveira/yaml-lint/actions/runs/2210152735.

Superseded by changes to upstream. Closing...

As discussed in #28, I’ll close this PR due to the updates having been taken care of in v1.3.0 which was release a few minutes ago. Sorry and thank you nevertheless!


Enable/Disable proxy with the "Manually config the proxy" switch

📄 Description
I have only activated the last switch.

In this case, I can not disable the browser proxy.
Please add a feature to enable/disable proxy with the "Manually config the proxy" switch.
✔ Expected Behavior
https://user-images.githubusercontent.com/23485114/153659261-e4dfb659-019b-45f3-bfe9-cba7078832d9.mp4
❌ Actual Behavior
https://user-images.githubusercontent.com/23485114/153659252-9837641e-e867-4a6a-8f10-98d2c4fd7a5a.mp4
https://user-images.githubusercontent.com/23485114/153659256-581b8a8a-84a6-4dbe-9c2b-ed8e08e9135e.mp4

No :(
https://user-images.githubusercontent.com/23485114/153879160-e58aa400-5370-4df6-a3bc-636f5fe62616.mp4

ok

不 ：（
bandicam.2022-02-14.17-36-20-122.mp4

Is that so?
https://user-images.githubusercontent.com/57182600/154075541-7cd35f32-43bb-4bd3-a5ae-be3067cd58f1.mp4

Yes, but the first item should be selected when the switch is activated.

Thanks, this is great.

谢谢，这很棒。

Thanks, this is great.

https://user-images.githubusercontent.com/57182600/154186985-527df30f-424c-4c13-8969-2a3104ea79fc.mp4

Thanks, this is great.

https://user-images.githubusercontent.com/57182600/154186985-527df30f-424c-4c13-8969-2a3104ea79fc.mp4

Thanks, this is great.

2022-02-16.10-36-01.mp4

Thanks, really great.


Improvement: Dockerize Dev Environment

Would be cool to be able to pull up the env without having to have local dependencies (mongo and specific node version) through docker/docker-compose.

That sounds like a good idea! Thanks for the suggestion!


Fix minor issues in JSDoc

This series of commits fixes a few minor issues in the JSDoc, and one more major one, which is to add @private annotations to all of the functions that are not exported publicly.

@kklin just in case you didn't see -- I added a new commit to fix the issue you mentioned and this is good to merge!

@kayousterhout Ethan actually fixed up the param thing already (https://github.com/quilt/quilt/commit/2547bd0b924cb379fb7494518b864494f95d7c5a)
Could you rebase? I'll merge after

@kklin updated!


Missing info about the "nameid" field

I try to understand all the fields in the jwt token,
and I can't found documentation about the "NameId" field,
and it seems like this field is a combination between account id and tenant id.
it will be great if someone could approve that for me, and besides that will add more info about that field to the documentation.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fad76c95-16a4-e946-c015-f79fe72c84c7
Version Independent ID: 0eedd505-3e2f-efa0-6b8c-ac57c08d5206
Content: JwtRegisteredClaimNames.NameId Field (System.IdentityModel.Tokens.Jwt) - Azure for .NET Developers
Content Source: xml/System.IdentityModel.Tokens.Jwt/JwtRegisteredClaimNames.xml
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

This issue is in reference to the System.IdentityModel.Tokens.Jwt package, which is not sourced from this repository.   I've transferred to the Azure Active Directory repository where the package is maintained as issue #1664.


Enable Pydantic v2 using v1 API

Description
As it says. This is a stopgap until we can properly implement Pydantic v2.
there was also a small change in the way cpuinfo does its brand key, its now brand_raw but I changed it to try both.
Part of the larger QCA upgrade
Changelog description
Enable Pydantic v2 support
Status

[ ] Code base linted
[ ] Ready to go

Changes look good, thanks for rolling them out to qcng! How do you come to have conflicts with a new PR?

Huh... I don't know. I'll look into this. Probably something to do with some bad merge somewhere.

So this PR was branched from like right after 0.11 on my local copy. Whoops. This is correctly done in #412.


Update aws-core, http-client-spi, ... to 2.17.16

Updates

software.amazon.awssdk:aws-core
software.amazon.awssdk:http-client-spi
software.amazon.awssdk:netty-nio-client

from 2.17.12 to 2.17.16.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #476.


Proofreading README

Typos and rephrasing needed in README (e.g. Sneak Peek)

Convert HowTo section into Install?

Done as per v1.0.0-full tagged version.


Remove use of pkg/integration in pkg/idtools

This remove a dependency on go-check (and more) when using pkg/idtools. pkg/integration should never be called from any other package then integration 🐮.
This made some dependency like docker/libcompose not build :
---> Making bundle: binary (in .)
vendor/github.com/docker/docker/pkg/integration/cmd/command.go:15:2: cannot find package "github.com/go-check/check" in any of:
        /go/src/github.com/docker/libcompose/vendor/github.com/go-check/check (vendor tree)
        /usr/local/go/src/github.com/go-check/check (from $GOROOT)
        /go/src/github.com/go-check/check (from $GOPATH)

/cc @estesp @justincormack @runcom @thaJeztah
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM

Yes was thinking about that as well. Not sure -where- to put it though.

A little copying is better here.
I doubt this will ever change.

This version LGTM

Still LGTM.

LGTM


Fixed namespace variable not visible and added public apis with Schema.SObject param.

Fixed namespace variable visibility.
Added public instance/static methods to support  Schema.SObjectField param along with String.
Added a method to return Database.QueryLocator.
Added public visibility for objectType.

Thank you for your pull request.
I like the first part of your commits, i.e. adding the Schema.SObjectField as a parameter type. It was something I'd like to do in short.
As for the other parts, there are a few small fixes I'd to request:
To add public visibility to the objectType, I'd recommend using a public method getObjectType or getSObjectType.
Secondly, I'd recommend changing the name of the toQueryLocator method to getQueryLocator, to follow the name conversion in the Database class.
Finally, I'd be much appreciated if you could split these parts into different commits.

Sure.. I will start working on that.

Sorry I was trying to make some changes to your branch, but accidentally close this PR.

#21 and #22 are the related PR, where the commits are under your name, which will still make you a contributor to this repository. Thank you.


[Docs] parameters + data type broken

Hi, since this is already present some time and I could not find a corresponding issue:
The documentation format seems to be broken. Parameter name and data type stick together:

Source: http://xarray.pydata.org/en/stable/generated/xarray.apply_ufunc.html

This is fixed on master. If you change stable to latest in your link, it will look better. We should've backported those fixes to stable...

Thanks @dcherian!


Looking for style guide

I'm working on the nocode project & want to stay in proper conventions.  Where can I find the appropriate style guide?

I'm pretty sure no style guide is a feature, not a bug.

Do Not Indent.


Separators: Implement html chunking strategy.

I actually thought about not including  and  - perhaps they are unnecessary. Thoughts?

@cpursley I can't convince myself that moving (or removing) them would be a definite improvement, so I'm happy with this until somebody comes along with a stronger argument 😄
Thanks so much for this contribution!

You're welcome. Y'all should do a detailed blog post about RAG stuff in Elixir (how you're working with the chunked data, etc)!


'Most recent' logs does not refresh

The 'Logs' tab 'open most recent' is not refreshed when changing to the tab, only on file load.

TODO: could do CTRL+D to input to delete all content .


fix: make PanelOnResize arg prevMixedSizes optional

It is undefined on first render.
Closes #208
Context #209
FWIW, noUncheckedIndexedAccess in tsconfig would. have caught this, but it also catches a whole heck of a lot more.

Thanks!

FWIW, noUncheckedIndexedAccess in tsconfig would. have caught this, but it also catches a whole heck of a lot more.

Not apposed to making this change but probably don't have time/energy to do it myself.


fix: properly decode Attestations from json while decoding BeaconBlock

What was wrong?
When I was trying to decode a block from a CL client through the block endpoint it was failing to decode it as the slot and index fields in the JSON are u64, but encoded as a string.
We handle this higher up in our block decoding code it just seems to be forgotten here, when I added these 2 lines of serde decoding the blocks worked for me
How was it fixed?
By adding the 2 serde lines which are used in other places to decode the u64 strings.

We handle this higher up in our block decoding code it just seems to be forgotten here, when I added these 2 lines of serde decoding the blocks worked for me

Is this other handling redundant now? Can it be removed?

What I meant is #[serde(deserialize_with = "as_u64")] used in all the other structs for decoding consensus types, except here

Can you add a test that deserializes an attestation?

in a bit

@carver ready for another review I added a test

We already have two random SignedBeaconBlock yaml test files for Deneb in test_assets/beacon/deneb/SignedBeaconBlock/ssz_random/ and tests that encode/decode it.
What we can do to cover the use case here is to update the attestation data fields to strings in the yaml file (for example adding quotes here). Then the existing test should catch the string ser/de for those fields.

Done

I added a json test again.


Support for Angular > 13

Hello,
This is a great plugin.
Please when will you add support for angular > 13.0

@layinka Hi thanks for the issue. I can add support for this asap.

@layinka I've just published version v2.0.0 which should work with Angular >=13 <15. Let me know if this works for you. Thanks!


support for managed disks

@sptramer Can you please merge these changes to the master branch! Thanks!
#sign-off

#sign-off


Pylance does not report expected error "Argument missing"

 Environment data

Language Server version: 2021.3.3
OS and version: win32 x64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: undefined
python.analysis.typeCheckingMode: strict

Code Snippet / Additional information

class A:

    def __init__(self, x: str, *, y: str) -> None: ...

class B:

    def __init__(self, a: A) -> None: ...

def C(b: B) -> None: ...

B(A(y = "Y")) # error: Argument missing for parameter "x" Pylance (reportGeneralTypeIssues)

C(B(A(y = "Y"))) # no error

This issue has been fixed in version 2021.3.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202134-31-march-2021


Implement draft RPC API.

Remove obsolete Callback API
Remove FuncCall and RPC
Update README
Rename set_rpc_handler() to set_handler()
Use shared rpc_proxy() function for platform consistency
Improve handling of promise cleanup
Update README with RPC API info.
Panic if webview handler is set after window creation.
Improve rpc_proxy() logic, try to ensure any corresponding promise is always removed.
Remove FuncCall wrapper.

@wusyong, this version has a tidy history. Would appreciate it if we could get this merged :+1:
I tried and failed to fix the MacOS issue and hope you have more success. I tried using OnceCell to get an &'static reference to the RpcHandler but could not as it is not thread safe. It appears that ultimately it boils down to:
= help: within `[closure@src/application/general.rs:370:52: 380:10]`, the trait `Sync` is not implemented for `*mut winit::platform_impl::platform::observer::CFRunLoopSource`

Which is all the stuff inside the WindowProxy -> ApplicationProxy chain which I know very little about. Any idea how we can get the RpcHandler into did_receive() safely?

We probably need to declare another objc class and it's full of hacks. I can take another day to work it. But for now that's just make it work on linux.

Thanks @wusyong, it works on Linux do you have a Windows machine to test on? It might work there too!

Sure. Would you mind I cherry pick this comment to feat/rpc? I wish I could work on it right away.

Sure thing, let's put it in feat/rpc and merge it back into the main branch once we have all three platforms :+1: Let me know if there is anything else I can do to help. Maybe a tracking issue for progress on this feature?

We can keep the discussion on #66.
Currently I am thinking about making Callback in the application module work with rpc.
I will list more in the issue later.

Currently I am thinking about making Callback in the application module work with rpc.

Oh no, we may have misunderstood each other. I have removed Callback as I don't see the benefit it brings to have a separate Rust closure for each Javascript function. The new model is a single Rust closure which tests on the method of RpcRequest.
The benefit of the old callback model was that you could just call a vanilla Javascript function as I understood it. This can now be achieved like this:
function someCallback() {
  return window.rpc.call('someRpcMethod', Array.prototype.slice.call(arguments, 0));
}

someCallback("param").then((res) => console.log(res));

What is still not done is a function that would set these callback aliases automatically. That would be the set_rpc_aliases() function I mentioned before.

I see. I do agree with this and it looks a lot cleaner.
Btw it turns out it's hell of chore to cherry pick 😅. Could you let me just add them manually?

Hi @wusyong, sorry I didn't realize you have been working in the feat/rpc branch. I took a look at the commits and there are lots of conflicts with that I have done here. Particularly with regard to CALLBACKS and Callback.
What I attempted to do was be fully backwards compatible with the first PR that you merged and then when you said that you liked the idea of cleaning up FuncCall and Callback this PR was created that completely removes any concept of callbacks with the exception of Javascript-defined callback functions that wrap the RPC API.
Is it possible for me to take any important changes from your feat/rpc branch and merge them with this PR? Not sure which changes are important. Please advise.

Callback has to be here is because Tauri will need it. But I believe there's a way to build it on top of the RPC handler.
Let me try to merge your branch into feat/rpc and I'll list what should be done afterward in #66
We can remove callback which's fine, but it needs an alternative interface that could accomplish the same functionality.

Sorry I deleted the previous comment thinking it's not good for you to develop further.
I think let's just keep working on this branch and finish all the changes you would like to address (ie. RPC alias).
Forget about feat/rpc, I'll update them afterward once this PR is merged.

Sure @wusyong, I'll do the callback aliases stuff and hope that it works out.
I looked at the tauri code that configures the Callback and all they would need to do is change it to Box<RpcHandler> and call set_handler() when the application is set up. But without knowing the code well it is hard to say how much effort it would be.
Maybe we can get some people working on the main Tauri code to comment on how much this change will affect them?

Yeah we'll have a discussion about this.
Another thing I would like to address is maybe moves the handler to parameters of Applicaton::create_window.
I'm not a fan of requiring the correct order of calling methods (which we suffered a lot from original webview)

I'm not a fan of requiring the correct order of calling methods

Agreed @wusyong . I did add a panic! for out of order calling but it's still a bit rubbish.
So then we remove set_handler() and RpcHandler is passed as the second argument to add_window_with_configs()? Replacing the old Vec<Callback>.

yeah, if that's possible.

Sure thing @wusyong, that's done now and it feels more idiomatic :+1:
However it does mean that for the aliases functionality that they would need to be passed in using the same mechanism so we probably want a wrapper type:
pub struct RpcConfig {
  handler: RpcHandler,
  callbacks: Vec<String>
}

Then we pass Option<RpcConfig> to add_window_with_configs() instead of Option<RpcHandler>; is that ok with you?

Current Option<RpcHandler> is cleaner imho. Let me check with other devs if we can actually replace callbacks first.

Thanks @wusyong, excited to see this land! I have made those small changes you mentioned but I have a couple more points I would like to make:

We throw out the idea of callback aliases and just add documentation on how to do it in Javascript
I read the Tauri code some more and they do async stuff in the existing Callback code and we need to support that use case.

I have a good idea how we can support async flows it it just a small bit of code and some documentation. I will do it now and ask you to take a look, thanks :+1:

Hi @wusyong, I think this can be merged if we can answer the following questions:

Does it work on Windows?
Do we have a clear path to get RpcHandler into did_receive() for MacOS support?

Hoping you are able to work out the MacOS issues! Cheers :+1:

Thanks for all your help @wusyong, shall we get this merged and then over to you for the platform-specific stuff?


Election Trait and Configurable Staking

currently, staking is very much hard-coded to use sp-phragmen. It won't be trivial and will need a lot of code to be moved around, but ideally we should have a staking module which is independent of its underlying election and can be configured. Perhaps some chains would need simpler election mechanisms.
The election trait should contain the bare minimum API, and should represent a multi-winner election:
An elect function will always

accepts a list of candidates (without any stake -- self votes need to be dealt with at call site), a list of voters zipped with their stakes and targets, and a count to elect (this implies deprecating the minimum_validaotr_count).
return a list of winners, and each nominator's stake distribution as a configurable generic PerThing.

This is coming from the current phragmen definition, but as far as I can think of, any sane election should provide at least these two pieces of information as output.
Staking will henceforth only work with Type Election: MultiWinnerElection<...>.
Some of the functionality that will probably be common between phragmen and any other election method that implements the above trait should be moved to primitives/election. This can be all the functions that work around the SupportMap data structure and all the helper functions.
Finally, the elect implementation with its tests can be decoupled from all the above and moved into a separate repo. No more sp-phrgamen will exist within substrate; just some Trait MultiWinnerElection and some helpers around it.
There are lots points of ambiguity here; for example where would the equalise() fit into this model. Before articulating more, I'd like some initial feedback if the main objective:

ideally we should have a staking module which is independent of its underlying election and can be configured

is even worth pursuing.

I will close this since it has been rephrased in https://github.com/paritytech/substrate/issues/6242 and the details explained there are much more realistic.


P46 first sentence

It reads:
In watches there are two points when exceptions can happen: In the watch functions and in the listener functions.
Since you are pointing out where exceptions can happen I think it should be:
In watches there are two points where exceptions can happen: In the watch functions and in the listener functions.

Fixing, thanks


@extend is extending more than it should

When extending a selector with the same name but in a different context, the parser thinks that selector is meant to be extended as well. Making it clear, take this example for instance:
p {
	font-size: 1em;
	font-weight: bold;
	text-transform: uppercase;
}

ul, ol {
	@extend p;
}

.my-other-rule-context {
	margin: 10px;
	p {
		color: red;
	}
}

Outputs:
p, ul, ol, ul .my-other-rule-context, ol .my-other-rule-context   {
	font-size: 1em;
	font-weight: bold;
	text-transform: uppercase;
}

.my-other-rule-context {
	margin: 10px;
}

.my-other-rule-context p {
	color: red;
}

As far as I understand ul .my-other-rule-context, ol .my-other-rule-context shouldn't be created by the parser. Agreed?

I get considerably different output on Sass 3.1.12:
p, ul, ol {
  font-size: 1em;
  font-weight: bold;
  text-transform: uppercase;
}

.my-other-rule-context {
  margin: 10px;
}

.my-other-rule-context p, .my-other-rule-context ul, .my-other-rule-context ol {
  color: red;
}

What version are you using?

Sorry @nex3 my bad, I did the example by hand, just for the sake of proving what I meant. But your example has the same issue for me. Because the rule I extended was only the p rule and not .my-other-rule-context p. I didn't do @extend p .my-other-rule-context (although I know this currently isn't possible).

@hefler That's the intended behavior. @extend means "should be styled as"; if you extend a selector, than all instances of that selector (even as part of other selectors) are modified to match the extending selector as well.


Update CONTRIBUTING.md

Related Issue
Fixes:[#289 ]
Closes:[#289 ]
Description
I have enhanced the document and also added some new sections
Done the following changes :-

Enhanced the project structure
Added star our repository section
Added need help with the basics section
Added the project structure
Modified the pull request process section
Added additional method of contributing through GitHub desktop section
Added help and support section
Added good coding practices section

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[x] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@sanjay-kv I have done the changes. Please kindly check once. If all the changes are fine please kindly merge the PR. Also please attach the gssoc extend and level label.


Fixed the validation of username format so it ensure usernames starts…

… with letters or numbers only
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Improve error message on invalid options

Feature request
For example, when I migrated to 3b1, I missed that for no_extra_blank_lines the useTrait in tokens isn't valid anymore.
However, the only error I got from the tool was:
In AbstractFixer.php line 158:

  [no_extra_blank_lines] Invalid configuration: The option "tokens" with value array is invalid.

In OptionsResolver.php line 990:

  The option "tokens" with value array is invalid.

I.e. it known something is invalid, but doesn't tell what :) What be great if that invalid value could be mentioned
$ ./php-cs-fixer-v2.phar fix --version
PHP CS Fixer 3.0.0-beta.1  by Fabien Potencier and Dariusz Ruminski (22e1a37)

$ ./php-cs-fixer-v2.phar fix --rules='{"no_extra_blank_lines":{"tokens": ["invalid"]}}'
Loaded config default.

In AbstractFixer.php line 158:

  [no_extra_blank_lines] Invalid configuration: The option "tokens" with value array is invalid.

In OptionsResolver.php line 990:

  The option "tokens" with value array is invalid.

fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--stop-on-violation] [--show-progress SHOW-PROGRESS] [--] [<path>...]

(I never though the --rules supporting JSON would be useful, yet here I am 😄 )

would you like to provide a PR for this improvement, @mfn ?

I tried to understand the code but…
This is the part where the decision is made the any of the provided $values is no part of the $this->allowedValues https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2f48a42f8a0edf9a75a7f34e1e494eb355c5dbf2/src/FixerConfiguration/AllowedValueSubset.php#L34-L47
Since this just returns false and no context (e.g. exception with the actual missing value(s)), this isn't easy.
The actual exception is thrown from \Symfony\Component\OptionsResolver\OptionsResolver I learned -> https://github.com/symfony/options-resolver/blob/5d0f633f9bbfcf7ec642a2b5037268e61b0a62ce/OptionsResolver.php#L1076
The dilemma:

the code in php-cs-fixer known the value but not the context (e.g. 'token')
the code in symfony knows the context but not the value

If I would just throw from \PhpCsFixer\FixerConfiguration\AllowedValueSubset::__invoke, the output would become:
Loaded config default from "/Users/user/src/php-cs-fixer/.php_cs.dist".

In AbstractFixer.php line 170:

  [no_extra_blank_lines] Invalid configuration: Unsupported value yolo

In AllowedValueSubset.php line 44:

  Unsupported value yolo

fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--diff-format DIFF-FORMAT] [--format FORMAT] [--stop-on-violation] [--show-progress SHOW-PROGRESS] [--] [<path>...]

but it's missing: "Invalid configuration: The option "tokens" with value array is invalid.
The only idea I've is that symfonys OptionsResolver should be able to catch exception from a callable and attach it to their own. Or so.
No idea, I don't think I've the expertise to provide a fix here. Especially if it requires changing Symfony also, I think I'll pass.
Thanks for the encouragement though :)

Closing, no plans to work on a PR


[CANNOLI-152] Bump ADAM dependency to version 0.26.0

Fixes #152.
An additional commit for 0.26.0-SNAPSHOT → 0.26.0 should be added on the ADAM 0.26.0 release.

Coverage remained the same at 19.242% when pulling a3312c48aac04b4e9b1417250079c6163c2f4020 on heuermh:adam-0.26.0 into f7ad79ca76dbceaca2aeafee5f7fe455fcf9a46e on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/154/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/155/
Test PASSed.


Direct binding

Sometimes when writing applications it's easier to have a direct reference to the localStorage instead of having to keep track of the localStorage key (which makes calls longer in length). Currently with the way localStorage works and the way this library is written the only way to do that is with the following:
var key = "counter"; // This key will change throughout the app
$scope.counter = $localStorage[key] || 42;

$scope.$watch('counter', function() {
    $localStorage.counter = $scope.counter;
});

$scope.$watch(function() {
    return angular.toJson($localStorage);
}, function() {
    $scope.counter = $localStorage.counter;
});

While that is due-able I believe there should be a way to have the localStorage wrapped in a value attribute to allow more of a direct route to it.
Example:
// Accessing the reference to the key
var key = "counter"; // This key will change throughout the app
$scope.counter = $localStorage[key];

// Using
{{counter.value}}

This will shorten calls from: _$storage.$localStorage[_settings.currentSystem] to _currentSettings.value

Hi!
I'm confused. So I'm pretty sure I'm missing the point. Hope you'll excuse me.
You want a direct reference to 'localStorage'? That would be $window.localStorage. If you want the service provided by ngStorage that would be $localStorage.
Do you want ngStorage to know when key has changed?
var key = 'counter';
$scope.counter = $localStorage[key];
// $scope.counter is not a reference to $localStorage.counter

key = 'ohNoes';
// $scope.counter should now be a reference to $localStorage.ohNoes
```

Is this the behaviour your would like?

Sorry about the confusion. I'm confused myself after reading that. I'd like to be able to create a reference to a specific $localStorage key even though the object changes (due to serialization and deserialization) which is why var myData = $localStorage.key; doesn't receive changes.
To circumvent the new object creation with serialization and deserialization all values from localStorage can be stored in an attribute called value. Which would change access from $localStorage.key to $localStorage.key.value. But will allow the following:
var settings = $localStorage.key;
$scope.mySettings = settings;
settings.value = [1,2,3,4,5,6];
//$scope.mySettings,value will be updated to [1,2,3,4,5,6] due to not referencing the localStorage object directly

Example Plunkr that attempts to emulate localStorage the requested behavior: http://plnkr.co/edit/R57HoFng6R4JaEVKaNU2

I do not want to make it so that we will have to use .value to get the values for a key.


Test raising "the property qiskit.circuit.bit.Bit.index is deprecated"

The following tests are raising
DeprecationWarning: The property ``qiskit.circuit.bit.Bit.index`` is deprecated as of qiskit-terra 0.17. It will be removed no earlier than 3 months after the release date. Instead, use `QuantumCircuit.find_bit` to find all the containing registers within a circuit and the index of the bit within the circuit.

[x] test.python.visualization.timeline.test_generators.TestGates.test_gen_sched_gate_with_finite_duration https://github.com/Qiskit/qiskit/pull/10750
[x] test.python.quantum_info.operators.symplectic.test_pauli.TestPauli.test_barrier_delay_sim https://github.com/Qiskit/qiskit/pull/10757
[x] test.python.visualization.timeline.test_generators.TestTimeslot.test_gen_bit_name https://github.com/Qiskit/qiskit/pull/10750
[x] test.python.visualization.timeline.test_layouts.TestBitArrange.test_qreg_creg_descending https://github.com/Qiskit/qiskit/pull/10843
[x] test.python.visualization.test_circuit_latex.TestLatexSourceGenerator https://github.com/Qiskit/qiskit/issues/9880

The deprecation was introduced on April 01, 2021.
Related:

https://github.com/Qiskit/qiskit/issues/10744
https://github.com/Qiskit/qiskit/pull/10733#discussion_r1311610141
https://github.com/Qiskit/qiskit/issues/9880

See also: #9880

Tests are clean (at least wrt this specific warning)!


sr.robot3 not installing on windows (and other os)

"After some digging, it's a bug in poetry. If you specify a dependency as optional without assigning it to an extra, it's not included in a source installation (as expected), but marked as required in a wheel" - Jake
Should add testing to CI to install the package


This is bad ass

Thanks so much!

oh let me know if you are on Twitter so I can follow you.

I'm glad you like the project! Yup, it all runs in the browser, and you could totally use it for your tool! The genTranspile function is a good example of how to do it!