var_spec includes the Comma in the "name" Field.

To determine whether an unnamed node is or isn't interesting, I look at whether it is part of a field. In the case of var_spec, the comma is included in the "name" field, but it isn't interesting in the context of the node. The following is an example:
var a, b, c;

(:SOURCE-FILE ((0 0) (12 0))
 ((:VAR-DECLARATION ((0 0) (11 0))
   ((:VAR ((0 0) (3 0)) NIL)
    (:VAR-SPEC ((4 0) (11 0))
     (((:NAME :IDENTIFIER) ((4 0) (5 0)) NIL) ((:NAME :|,|) ((5 0) (6 0)) NIL)
      ((:NAME :IDENTIFIER) ((7 0) (8 0)) NIL) ((:NAME :|,|) ((8 0) (9 0)) NIL)
      ((:NAME :IDENTIFIER) ((10 0) (11 0)) NIL)
      ((:TYPE :TYPE-IDENTIFIER) ((11 0) (11 0)) NIL)))))
  (:|;| ((11 0) (12 0)) NIL)))

I think the fix might be to change this:
https://github.com/tree-sitter/tree-sitter-go/blob/07d722831382a043b16547b6d9202f3da07f3cb3/grammar.js#L347
to this:
  field_declaration: $ => seq(
      choice(
        seq(
          field('name', $._field_identifier),
          repeat(seq(',', field('name', $._field_identifier))),
          field('type', $._type)
        ),

There's a similar problem in parameter_declaration here:
https://github.com/tree-sitter/tree-sitter-go/blob/07d722831382a043b16547b6d9202f3da07f3cb3/grammar.js#L235
which should be changed to:
    parameter_declaration: $ => seq(
      field('name', $._identifier),
      repeat(seq(',', field('name', $._identifier))),
      field('type', $._type)
    ),


Add support for ESLint feature flags

In ESLint v9.6.0, we added the ability to specify feature flags in ESLint. While there aren't any currently active feature flags, there will be in the coming months. Feature flags only work when using flat config files, and can be specified by passing flags into the ESLint constructor like this:
const eslint = new ESLint({
     flags: ["some_flag"]
});

It would be great to have an option in vscode-eslint that would allow users to specify which flags they'd like to enable.

Makes sense. Just to be sure the type of the flags property is string[].

That's correct.

Actually. It is already supported. There is a eslint.options settings that is already passed into the ESLint class. You can simply add a flags property to it and it should work.
@nzakas let me know if this works for you.

Ah nice! Yup, that should work. Thanks.


Use node-pre-gyp

Any Nodejs/npm module that relies on node-gyp basically means Windows users can't use your project without compiling, which is an incredibly much harder dev track than on OSX and Unix/Linux. However, that problem can be entirely negated by using node-pre-gyp, so I cannot stress enough how important it is to work that into karma=cli, so that webpack-dev-server (which relies on karma-cli) can actually run on Windows, instead of somewhat (hopefully unintentionally, of course!) giving them the finger
A fantastic example is sqlite3 - install that on any OS and instead of compiling it just checks if there is a precompiled version on S3. If so, it downloads that, and done. Especially for windows users, that makes the difference between "I can't use this module" and "everything just works" =)

Thanks for the suggestion, though I think this is the wrong repo to address this. karma-cli itself has no dependencies that require compiling, rather karma itself has some.

cheers, I'll file that on them then!


client-go dependency recorded by go get is v0.0.0-...

I'm very happy about Go module support in v12! However, when I go get<EMAIL_ADDRESS>The dependency gets recorded in go.mod as:
k8s.io/client-go v0.0.0-20190620085101-78d2af792bab

I'm assuming this is because the client-go repository doesn't have the major version in the import path, so it reverts to legacy support behavior.
This is a maintenance headache, because it means that I can't easily go get -u my own package, because all the k8s packages will just sync up to master and (potentially) break everything.
Is there something the client-go repo can do here to make things behave more gracefully, so that downstream dependencies can track client-go by major version?
This is on Go 1.12 and client-go v12.0.0.

I'm assuming this is because the client-go repository doesn't have the major version in the import path, so it reverts to legacy support behavior.

That's correct

Is there something the client-go repo can do here to make things behave more gracefully, so that downstream dependencies can track client-go by major version?

We're experimenting with adding major versions to import paths in https://github.com/kubernetes/publishing-bot/pull/196, but it's not clear whether the impact (making all consumers modify all of their import paths) will be too disruptive yet.

Wonderful to hear!
While I know it's not a vote-based decision, I would greatly encourage moving in that direction. The upgrade between major versions of client-go is already a heavyweight operation, since it might contain breaking changes that require refactoring the consuming code. Running a a sed script to change import paths is a small additional tax on top of that other work (and the one-liner can be included in the release notes), but in return updating to keep up with e.g. security issues in all dependencies becomes a trivial go get -u ., rather than "surgically upgrade around client-go".
Thanks for the insight!

closing in favor of https://github.com/kubernetes/kubernetes/issues/72638 / https://github.com/kubernetes/publishing-bot/pull/196


train_set and test_set

https://github.com/EderSantana/deeplivecoding/blob/master/demo-rehearsal.py
train_set, valid_set, test_set = cPickle.load(file('mnist.pkl', 'r'))
print(len(train_set))
train_x, train_y = train_set
test_x , test_y  = test_set
Please see the code on this link:
https://www.kaggle.com/mattgenkin/digit-recognizer/first-attempts-with-neural-net-in-theano/code
trX = np.array(train.values[:][:, 1:], dtype=np.float32)/256
trY = np.array(train.values[:][:, 0], dtype=int)
teX = np.array(test.values[:], dtype=np.float32)/256
trY_onehot = np.zeros((trY.shape[0], 10), dtype=np.float32)
trY_onehot[np.arange(trY.shape[0]), trY] = 1
Please advise how to define train_set and test_set in this case.
Thanks!

I believe trX is the equivalent to train_x...
But if you are looking for a good way to do deep learning with Python/Theano I recommend you to take a look at Keras. Here is an example on how to train a neural net to classify the MNIST dataset. I've been writing most of my deep learning with that library lately. Check it out!


Hiding backend api containers - proxy_pass does not seem to forward for custom location

Given following scenario:
I have a docker-compose with a few backend api services (e.g. api1.example.com) and a frontend web application (e.g. www.example.com).
My nginx container (following Evert Ramos' example [1]) serves as reverse proxy for the frontend web application and proxy_pass'ing requests to my frontend web application. As I don't want to publish the backend api services, I thought of making them available by a custom location (e.g. www.example.com/api/1).
What have I done?

I created a file "api.conf" within the mapped "conf.d" directory. Within this file I defined my upstreams matching my containers. Example (given, that api1.api is the container name of my api service):

upstream api1.api {
    server api1.api:80;
}

I created a file "www.example.com_location" within the mapped "vhost.d" directory. Within this file I defined my location-specific configuration. Example:

location /api/1/ {
    proxy_pass http://api.api;
    proxy_redirect off;
    proxy_set_header Host $host;
}

I started my containers, logged in at the nginx-container and dumped the nginx config. Config was valid - api.conf and www.example.com_location were included.
But when I call www.example.com/api/1 in my browser, I receive a 404 and NO request is received by my api service.
What am I doing wrong?

[1] https://github.com/evertramos/docker-compose-letsencrypt-nginx-proxy-companion

Unfortunately, I don't know what's going wrong in your setup.  I'd like to keep Github issues for actionable bug reports or feature requests.  Can you ask questions in the Q&A Group.
Thanks!


Support label select expressions for nodes when creating a virtualcluster

What would you like to be added:
Support label select expressions for nodes when creating a virtualcluster
Why is this needed:
Currently only support  key-value label select for nodes. Some scenarios cannot be met，such as select nodes without certain labels. So support label select expressions for nodes when creating a virtualcluster is needed.

/assign


Tests fail to link: ld: error: undefined symbol: tbb::internal::task_scheduler_observer_v3::observe(bool)

Description
c++ -O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -fno-strict-aliasing -fno-omit-frame-pointer   -std=c++1y -D_REENTRANT -Wno-ignored-attributes      -I lib/tbb_2020.3/include    -O3  -I . -I lib/eigen_3.3.9 -I lib/boost_1.78.0 -I lib/sundials_6.1.1/include -I lib/sundials_6.1.1/src/sundials -I lib/benchmark_1.5.1/googletest/googletest/include -I lib/benchmark_1.5.1/googletest/googletest  -fno-omit-frame-pointer    -DBOOST_DISABLE_ASSERTS   -DTBB_INTERFACE_NEW  -DTBB_INTERFACE_NEW      -fstack-protector-strong         -Wl,-L,"/usr/local/lib" -Wl,-rpath,"/usr/local/lib" -Wl,--disable-new-dtags -ltbb    test/unit/math_include_test.o lib/benchmark_1.5.1/googletest/googletest/src/gtest_main.cc lib/benchmark_1.5.1/googletest/googletest/src/gtest-all.o        -Wl,-L,"/usr/local/lib" -Wl,-rpath,"/usr/local/lib" -Wl,--disable-new-dtags -ltbb -o test/unit/math_include_test

ld: error: undefined symbol: tbb::internal::task_scheduler_observer_v3::observe(bool)

>>> referenced by math_include_test.cpp
>>>               test/unit/math_include_test.o:(_GLOBAL__sub_I_math_include_test.cpp)
>>> referenced by math_include_test.cpp
>>>               test/unit/math_include_test.o:(_GLOBAL__sub_I_math_include_test.cpp)

Current Version:
v4.5.0
onetbb-2021.7.0
FreeBSD 13.1

@yurivict, sorry about the delay.
We haven't prioritized linking against pre-installed tbb libraries. The reason is that it's actually really tough to keep the Math library aligned with how packages are installed. For example: compiler flag differences, compiler differences, intel tbb differences, ABI mismatches, etc.
I'll close this issue for now, but if you want dig into it more, please reopen the issue.


[HOLD for payment 2024-01-24] [HOLD for payment 2024-01-22] FAB - Skeleton appears first on Start chat page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.24-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/33055
Action Performed:

Go to staging.new.expensify.com
Click FAB button
Select Send message

Expected Result:
The modal should open smoothly, without showing the skeleton
Actual Result:
Skeleton appears first when open Start chat page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8d3976d9-400e-49d5-89d5-843463937ea0
View all open jobs on GitHub

Select Send message

@lanitochka17 this should read Select Start chat

Given that the fix was only for desktop, can't we make the fix apply only to desktop @dukenv0307?

I think we should only wrap interaction here for native platform

Also, how are you proposing we do this? We would define another file just native, right?

If we only want to apply it on desktop we also can do that by checking getPlatform

But our guidelines advice against this, no?

I guess freeze usually happens on native device so I suggest only apply it on native.

By native what do you mean exactly? Desktop?

Yeah, we do, but either that was a mistake or there was a good reason to skip the guideline, in this case I don't think there's a good reason, so let's follow the guideline.
Can you update the proposal to do this @dukenv0307 ?

Awesome thanks! Assigned to you

CPed and verified this worked https://expensify.slack.com/archives/C07J32337/p1705314001375409

@dukenv0307 can you please accept the job offer I just sent? Thanks!

paid! thanks!

@NicMendonca I reviewed the PR here #34449. Can you please check and send me an offer?

@c3024 can you apply to the job here? https://www.upwork.com/jobs/~010e3553157ff6c282

Applied. thanks. @NicMendonca

paid!


Update the Trophy Updater and show-trophies command to use PrettyTable to make everything look better

This will close #245

Will need to test in multiple servers before merging.

Also updated py-cord to version 2.0.0rc1


Toggle to hide minimap

In the case to record the ghost replay, the minimap seems to be unnecessary.

Closed in #555.


Guides don't cross literal coffeescript comments

I would expect the guide to go past the comment in .litcoffee files, however I realize this is an edge case in a rare file format ;)
Great work on this package, I think it's very helpful!

Hmm... I admit what you say is the correct behavior.  The problem is, it seems hard to implement.
I keep this open and I will implement it sometime or wait for other people's pull request. :)
Thanks for using this package!


Session Hash not working with several instances of REST

The cluster module can be used for testing that the application can scale horizontally for stateless protocols.

Good, thanks!
Can we still use it in production?

The cluster module can be used for testing that the application can scale horizontally for stateless protocols.

Good, thanks!
Can we still use it in production?

I do not think so.
Only to replicate locally and logically the AWS horizontal scaling architecture and ensure there's no issue like that one for stateless services and protocols. It's more like a test bed for devs that want to validate that the code they've done still works properly with HA and horizontal scaling hosting architecture.


soda-dbt not working with dbt 1.8

Running the soda ingest dbt command with dbt 1.8 instead of dbt 1.7 makes the command throw the following exception:
soda ingest dbt -d snowflake -c configuration.yaml --dbt-artifacts /dbt_models/target/dbt_b2c-f763934-2944744/run_results.json
[15:25:30] Soda Library 1.1.27
[15:25:30] Soda Core 3.0.47
cannot import name 'RunResultOutput' from 'dbt.contracts.results' (/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/dbt/contracts/results.py)
Traceback (most recent call last):
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/soda/common/exception_helper.py", line 26, in invoke
    return super().invoke(ctx)
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/soda/telemetry/soda_tracer.py", line 79, in wrapper
    raise e
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/soda/telemetry/soda_tracer.py", line 72, in wrapper
    result = fn(*original_args, **original_kwargs)
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/soda/cli/cli.py", line 624, in ingest
    from soda.cloud.dbt import DbtCloud
  File "/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/soda/cloud/dbt.py", line 20, in <module>
    from dbt.contracts.results import RunResultOutput
ImportError: cannot import name 'RunResultOutput' from 'dbt.contracts.results' (/workspaces/b2c-consumer/.venv/lib/python3.10/site-packages/dbt/contracts/results.py)
``
`
Using `soda-dbt` version `1.1.27`

CLOUD-8548

In version 1.8 of dbt-core there was a PR (#9350) to move the RunResultOutput class into core/dbt/artifacts/run.py. An easy fix for this might be to use a try/except and import from the new location and fall back to the old location if not present.


⚠ Bofrost.de has degraded performance

In c222dc9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 749 ms

Resolved: Bofrost.de performance has improved in ece93e4 after 10 minutes.


Proposed dev-next

If this is really the candidate, you need to add another commit updating the version number, then sign that commit.

thanks @ximinez Fixed. I'm going to wait for CI to finish and then I'll propose this in cpp-important.

Current coverage is 48.87%

Merging #1368 into develop will decrease coverage by -0.01% as of a3c4d90

@@            develop   #1368   diff @@
=======================================
  Files           962     957     -5
  Stmts         66053   66022    -31
  Branches          0       0
  Methods           0       0
=======================================
- Hit           32291   32267    -24
  Partial           0       0
+ Missed        33762   33755     -7

Review entire Coverage Diff as of a3c4d90

Powered by Codecov. Updated on successful CI builds.


metric-tags:

Hi!
Thanks for making this available for use. I'm sure there isn't an issue, more of a documentation helper for me. I've configured my-awesome-metric as follows:
      - name: Deploy duration seconds
        uses: int128/send-datadog-action@v1
        with:
          datadog-api-key: ${{ secrets.GHA_DD_API_KEY }}
          datadog-site: datadoghq.eu
          metric-name: deploy_duration
          metric-type: count
          metric-value: 4
          metric-tags: version:${{ inputs.version }}
                       solution:${{ inputs.solution }}

and i get the following view in dd

where there is only one tag created (version) and the solution tag is appended to the version:VALUE.
Can you add an example including multiple tags please.
Many thanks

I've solved my issue. A syntax error corrected by chatgtp whilst I converted metric-value: from a constant 4 to a calculated field!
      - name: Deploy duration seconds
        uses: int128/send-datadog-action@v1
        with:
          datadog-api-key: ${{ secrets.GHA_DD_API_KEY }}
          datadog-site: datadoghq.eu
          metric-name: deploy_duration
          metric-type: count
          metric-value: ${{ steps.deployment_details.outputs.deploy_duration }}
          metric-tags: |
            version:${{ inputs.version }}
            solution:${{ inputs.solution }}


Fix "go install" url

There's probably a typo

Codecov Report

Merging #51 (d445de7) into main (9b1dd3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   93.25%   93.25%
=======================================
  Files           8        8
  Lines         178      178
=======================================
  Hits          166      166
  Misses          9        9
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1dd3f...d445de7. Read the comment docs.

🤦♂ have to test readme sometimes too
thanks for paying attention and for the fix


if there are no servers do redirect to add a server on the dashboard view

bad idea since one can link their clouds as well


Update dependencies

This will help people (like me!) trying to upgrade ember in their apps

Thanks for the PR @lukemelia! I'm certainly not opposed, but I'm a bit curious (beyond just good maintenance practice) why this is necessary. None of these dependencies should conflict with or prevent upgrading Ember, should they?
And taking a step slightly further back, I'm not sure this plugin is really needed today, at least for the GitHub Actions happy path. All the nonsense it does with setting up ssh-agent and configuring a deploy key was necessary in third party CI services, but in Actions most of the machinery is already in place in the runner to be able to push new commits.
I believe all that's necessary is setting user.name and user.email, which you can either do with https://github.com/marketplace/actions/setup-git-user or by hand via git config (as mentioned in that action's docs).

IIRC, there was a node engine requirement incompatibility somewhere in there.
Great point about github actions setup, though! The project this is used in is on CircleCI. Probably not too hard to deal with it per Circle's docs too though.

The current node requirement includes >= 7.* which, while super outdated, should still accommodate anything newer 🙂

I'll confirm if this is needed or not in my in-progress upgrade


Feature/subscribe app

#200

Coverage increased (+0.01%) to 94.003% when pulling 22007989aec6a81f7646ae28d82f880dd807be24 on feature/subscribe_app into f83928fc5d93ee2f818a847bf9d800dc9c29143b on develop.


Blank page is displayed on Roles page

Affected module
UI
Describe the bug
A blank page is displayed after navigating to Roles page
To Reproduce

Navigate to roles page from settings dropdown

https://user-images.githubusercontent.com/67048554/163469757-145169db-8366-4fc4-9d08-5ee8c8f5942b.mp4
Expected behavior
Roles page should be displayed
Version:

OpenMetadata version: 0.9.0

Additional context
http://localhost:8585/api/v1/roles?fields=policy,users,teams&limit=1000000

@darth-coder00 @Sachin-chaurasiya

Duplicate of #4130


Compute Cluster operation does not work in Machinelearningservices version 2020-04-01

Bug Report

import path of package in question: "github.com/Azure/azure-sdk-for-go/services/machinelearningservices/mgmt/2020-04-01/machinelearningservices"
SDK version: v54.2.0+incompatible
output of go version: 1.16.3

What happened?
Tried to update scale settings of compute cluster -> did not work.
What did you expect or want to happen?
Successful update of scale settings of compute cluster.
How can we reproduce it?
Try updating of compute cluster with Azure SDK for Go.
Anything we should know about your environment.
Blocks my PR for Terraform Azure Provider: https://github.com/terraform-providers/terraform-provider-azurerm/pull/11675
Related to feature request: https://github.com/Azure/azure-sdk-for-go/issues/14666.
I assume updating the version to 2021-04-01 would fix this, as the response sent through the portal has a slightly different structure than what the Go SDK sends.

Unfortunately this schema error comes from the corresponding swagger here: https://github.com/Azure/azure-rest-api-specs/blob/03a759c3b3c86cecc1c6030cc5e4d6940437706a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L3942
Please note this comes from the latest stable api-version 2021-04-01, which means releasing a new api-version cannot solve this.
Therefore I have tagged this issue so that the corresponding service team could take a look and fix their swagger or change their payload format so that the current swagger could work.
In the meantime, we must pause the release of a new api-version 2021-04-01 as requested in this issue

@ArcturusZhang Hmm, the swagger does show double property level, that's the payload that actually works (i.e. the one portal sends in the issue). When I use REST API UI - that payload works with any API version.

@ArcturusZhang Hmm, the swagger does show double property level, that's the payload that actually works (i.e. the one portal sends in the issue). When I use REST API UI - that payload works with any API version.

The swagger does not have the double properties. Please see the comment below
    "ClusterUpdateParameters": {
      "properties": { # This `properties` is a keyword, indicating the following are a map of the properties.
        "properties": { # This is the first property of ClusterUpdateParameters, it happens to have a name `properties`.
          "x-ms-client-flatten": true,
          "$ref": "#/definitions/ClusterUpdateProperties",
          "description": "The properties of the amlCompute."
        }
      },
      "description": "AmlCompute update parameters."
    },

If we want something with double properties in the swagger, we will have to write this:
    "ClusterUpdateParameters": {
      "properties": {
        "properties": {
          "x-ms-client-flatten": true,
          "$ref": "#/definitions/ClusterUpdateParametersProperties",
          "description": "The properties of the amlCompute."
        }
      },
      "description": "AmlCompute update parameters."
    },
    "ClusterUpdateParametersProperties": {
      "properties": {
        "properties": {
          "x-ms-client-flatten": true,
          "$ref": "#/definitions/ClusterUpdateProperties",
          "description": "The properties of the amlCompute."
        }
      },
      "description": "AmlCompute update parameters."
    },

Oh nevermind, I should learn to read swagger in the morning.

Oh nevermind, I should learn to read swagger in the morning. Yep, thank you very much for the detailed explanation. I indeed got confused by the "properties" keyword of swagger itself.

I have written some internal emails to inform the service team about this bug, waiting for their responses now.

@ArcturusZhang Can you update the status on this bug.


api target 25 - not working at all for testTypes

not sure why you put whatever for the name space.

Anything could be used as namespace. (provided it has been declared).
Were you able to make it work?


Email notification body is empty

Describe the bug
All notifications sent to email have an empty body.
To Reproduce
Steps to reproduce the behavior:

Create an incident
An email with an empty body sent to the recipient.

Expected behavior
The email has the information needed for incident participants.
Screenshots

Exception from Sentry

It seems there is no node installed on my system. After manually install node from the server, there is another error:

Did you set the MJML location?
https://hawkins.gitbook.io/dispatch/configuration/app#mjml_path-default-static-dispatch-node_modules-bin

Did you set the MJML location?
https://hawkins.gitbook.io/dispatch/configuration/app#mjml_path-default-static-dispatch-node_modules-bin

I did not set the environment variable, just let it using the default location. I see the mjml command exists in the default location @kevgliss

I did not set the environment variable, just let it using the default location. I see the mjml command exists in the default location @kevgliss

Judging from your sentry output, it looks like node isn't in your path: /usr/bin/env.
Perhaps something like:
export PATH=$PATH:/usr/local/lib/python3.8/site-packages/dispatch/static/node_modules/bin/ might work?

Judging from your sentry output, it looks like node isn't in your path: /usr/bin/env.
Perhaps something like:
export PATH=$PATH:/usr/local/lib/python3.8/site-packages/dispatch/static/node_modules/bin/ might work?

The weird things is I have not node installed on /usr/local/lib/python3.8/site-packages/dispatch/static/node_modules/bin/ or anywhere in the system.
Here is some binary that exists in that directory with prefix node-:

node-fetch
node-forge
node-ipc
node-libs-browser
node-releases

Maybe there is some mistake in the way I built the docker image? I use the same way as @sfc-gh-pkommini to build the docker image as stated in https://github.com/Netflix/dispatch-docker/issues/91#issuecomment-768805782
Anyway, after setting the MJML_PATH to /static/dispatch/node_modules/.bin, I got this error message:
[Errno 2] No such file or directory: '/static/dispatch/node_modules/.bin'

So, I drop the env and use the default value.

The weird things is I have not node installed on /usr/local/lib/python3.8/site-packages/dispatch/static/node_modules/bin/ or anywhere in the system.
Here is some binary that exists in that directory with prefix node-:

node-fetch
node-forge
node-ipc
node-libs-browser
node-releases

Maybe there is some mistake in the way I built the docker image? I use the same way as @sfc-gh-pkommini to build the docker image as stated in https://github.com/Netflix/dispatch-docker/issues/91#issuecomment-768805782
Anyway, after setting the MJML_PATH to /static/dispatch/node_modules/.bin, I got this error message:
[Errno 2] No such file or directory: '/static/dispatch/node_modules/.bin'

So, I drop the env and use the default value.

I tried to install node and npm manually on the system, the error still happens @kevgliss

I tried to install node and npm manually on the system, the error still happens @kevgliss

@sfc-gh-pkommini did you encounter the same issue on your ECS setup?

It is solved by doing the following:

Remove node_modules/ directory and package-lock.jsonon /usr/local/lib/python3.8/site-packages/dispatch/static/dispatch
Manually install node and npm on the server
Run npm install

However, IMHO it is not the best way to make it works. Any idea of how to properly build the frontend assets in the deployment pipeline? Am I miss some env variable that should exist in the build step?

It's hard to say... are you using our docker file? The only real requirement is that you have node (with mjml) in that same path as the dispatch webserver, we do include node in our image because we use it to build the frontend assets. But that build process could be completed outside of your image.
Perhaps, we just need to export node in the correct path here?

@rilutham We didn't use the email plugin and hence didn't receive this error. Sorry I couldn't help on this.

@kevgliss Yes, I used the docker image here. Like I said before, there is no node installed in the system (runtime image). As a workaround, I was adding the following command in the runtime image:
RUN wget "https://nodejs.org/dist/v12.16.2/node-v12.16.2-linux-x64.tar.gz" \
    && tar -xzf "node-v12.16.2-linux-x64.tar.gz" -C /usr/local --strip-components=1 \
    && rm -f "node-v12.16.2-linux-x64.tar.gz" \
    && cd /usr/local/lib/python3.8/site-packages/dispatch/static/dispatch \
    && rm -rf package-lock.json node_modules/ \
    && npm install

@sfc-gh-pkommini no worries, thank you for your response.

Doesn't https://github.com/Netflix/dispatch/blob/master/docker/Dockerfile#L70 add node to /usr/local?

Somehow if you do $ ls /usr/local/bin in the runtime image, there is no node binary there.

Hopefully, #835 fixes the missing binary. Let me know if you still have issues.

By copying the node binary from build image, it will raise the following error:
Step 36/47 : COPY --from=sdist /usr/local/bin/gosu /usr/local/bin/tini /usr/local/bin/node /usr/local/bin/
failed to copy files: failed to copy file: Container ID 166537 cannot be mapped to a host ID

The error will not show up if we add RUN chgrp -R root /usr/local && chown -R root:root /usr/local in the build image, however, the main issue still happens @kevgliss


XML links don't open formatted properly

Azure Data Studio Version: 1.16.0

Steps to Reproduce:

Run a query with an XML link
Click the link

Expected: XML document is formatted
Actual: XML document is not formatted
Note: This is a regression from 1.15.1

@anthonydresser I recall when we last looked at a similar issue it was a race condition in loading the XML extension, or something like that.  I thought the fix we discussed at the time was to preload the XML extension on startup.  Could you please take a look at what happened here since 1.15.1?

Approved label added during shiproom.

Fixed


service-routing update

Change Summary

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[X] Documentation content changes
[ ] Other (please describe):

Related Issue(s)
Fixes #195
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Update and expand service routing data model and templates to account for addition of BGP no equals default.
How to test

Checklist:

[X] My code has been rebased from devel before I start
[X] I have read the CONTRIBUTING document.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[ ] I have updated molecule CI testing accordingly
[ ] All new and existing tests passed (pre-commit, make linting and make sanity-lint).

This will break anyone's automation using service_routing_protocols_model as it is now replaced with service_routing.protocols_model
I am happy to revert that if needed.  It just made more sense if anyone wanted to add additional service routing templates to the module.
I can also add some simple molecule tests as well.

@ryanmerolle thank you for this PR.
From a data model perspective, these are all different section in the CLI, see extract from EOS 4.24.5M:
!
service routing configuration bgp no-equals-default
!
daemon TerminAttr
   exec /usr/bin/TerminAttr -ingestgrpcurl=<IP_ADDRESS>:9910 -cvcompression=gz                                                                                ip -ingestauth=key,telarista -smashexcludes=ale,flexCounter,hardware,kni,pulse,s                                                                                trata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -ingestvrf=MGMT -ta                                                                                illogs
   no shutdown
!
vlan internal order ascending range 1006 1199
!
transceiver qsfp default-mode 4x10G
!
service routing protocols model multi-agent
!
hostname CN-IT-BL1A
ip name-server vrf MGMT <IP_ADDRESS>
ip name-server vrf MGMT <IP_ADDRESS>
dns domain avd-lab.local
!
ntp local-interface vrf MGMT Management1
ntp server vrf MGMT 0.north-america.pool.ntp.org prefer
ntp server vrf MGMT 1.north-america.pool.ntp.org
!
service routing configuration route-map set-operations sequential
service routing configuration route-map no-set-community explicit-members

So I would suggest the following data model for configuration for service routing, with no change to current data model:
service_routing_configuration_bgp:
  bgp_no_equals_default: < true | false >

service_routing_protocols_model: < multi-agent | ribd >

service_routing_configuration_route_map:
  set_operations: < merged | sequential >
  no_set_community: < explicit-members >

Let me know if you have questions!

@carlbuchmann updated based on your feedback.

@carlbuchmann updated based on your feedback.

@ryanmerolle
Please follow the suggested data model, this has also been reviewed and approved by @ClausHolbechArista
Also note, the eos/documentation template should be named: service-routing-configuration-bgp.j2
Update the molecule scenario accordingly:

host_vars: service-routing-configuration-bgp.yaml
update the hosts: https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/hosts
run the eos_cli_config_gen scenario:

$ cd ansible_collections/arista/avd/molecule
$ make converge

@carlbuchmann I have no problem updating as you suggest.  My contributions should get better as I further review the process.  I appreciate the guidance.
I do not see that @ClausHolbechArista offered any suggested data model in this ticket or the linked issue.  If you mean the existing that I change, I thought I reverted that already.
I'll make some updates tomorrow based on the new molecule feedback.  If you guys redirect me to some other suggested model, I will fold in as well.

This should be good to go.
Thanks!

I think all comments are resolved.

Seeing how @carlbuchmann and @titom73 reviewed/approved this.  I think we are good to merge correct?


Release mutex in Node during final optimization

Enables servicing callbacks during the final optimization. This (along with #443 and #468) enables watching in RViz the progress of the final optimization using the offline node.
One question: should the online node also call RunFinalOptimization() in Node::HandleFinishTrajectory, or only at the end (which is handled by FinishAllTrajectories) ? If so, could this be done asynchronously for similar reasons (to avoid stopping callback servicing)?

No new data should arrive then as this is an assumption WaitForAllComputations() makes.

This is ensured by removing the sensor bridge in MapBuilderBridge::FinishTrajectory. Although, if we wanted to insert a new constraint (e.g. landmark), possibly even during the final optimization, this approach will have to be adapted, right?
Fixes #476.

Before merging, please check if this is what you want with respect to the trajectory finalization service (as I explained above - I did not add a call to RunFinalOptimization in HandleFinishTrajectory. If one should be added, I suggest it be done asynchronously.

Damn, you beat me to it :-)

I think this is the right way to do things. You've separated the concept of running the final optimization from finishing trajectories. As you say, the final optimization is run when calling "FinishAllTrajectories." That makes sense. After all, it is a "final" optimization and can only be "final" if it's called once all trajectories are finished.

I see, that makes sense. Although, it now occured to me that there's an asymmetry between the offline and the online node - the offline node still calls the final optimization at the end of each trajectory when it is finished before it goes on to process the next bag (trajectory).

SGTM


List ControllerManagerLeaderMigration feature gate in feature gates page

Fixes: #28787

/lgtm

Thank you for the PR. The bigger issue would be missing feature gate in pkg/feature/kube_features.go
I've already open a PR to fix that. https://github.com/kubernetes/kubernetes/pull/103533

/lgtm

/lgtm

/approve


Is there any way to read env vars from a .env file?

I've noticed #226 but I'm not able to get cargo watch to use my .env file. My setup involves a workspace, so next to placing the .env file in the root of the crate I'm trying to watch I also tried to place it in root of the workspace. But it didn't work in either of the cases...
Tried to search the docs/repo, but other then the one issue I can't seem to find much to go on. Would be really, really nice to be able to use my .env file, as I need quite a few vars to be set.
Thanks!

Not yet!

Wow, your fast 😃 My next question was going to be if you are open for a PR to support it and then I was going try and make some coming weekend... But I guess I don't have to anymore ❤
One additional question after looking at the PR; would it be possible revert the logic using the same style as the --no-dot-ignores and --no-vcs-ignores flags? So on by default if an .env file is in the current working directory. And then maybe keep the --env-file flag for if you want to point to a custom file.
IMHO that would make the PR "feature complete" in terms of .env file support 😊

No, reading the .env by default would be unexpected, I think. Generally that's done by the application in development, not by the process parent. One advantage to doing it in the application is that it's reloaded on each run, whereas this option by necessity only loads it once at instantiation.

That's indeed a fair point! Then indeed the flag you proposed is a good alternative that would work fine for us 👍🏻

Released in 8.3.0

Thank you very much for the quick response and implementation!! Going to try it right away...


Fix bug where await expressions were marked as unused

Fixes #887

feel free to merge after small rename :+1:


Declarative components

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: BelfordZ:white_check_mark: shanejonas:x: zbzb seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Revert to apk installs, alpine-develop now broken

Overview
The containers for taskcat seem to be attempting to use the apt installer instead of apk on alpine and cannot be built locally due to this.
I'm not sure if CI is overriding the FROM container at build - but it would be better to have the plain Dockerfiles be locally buildable if possible.
Testing/Steps taken to ensure quality
Tested the GitLab EKS quickstart which encounters this line: https://github.com/aws-quickstart/quickstart-amazon-eks-cluster-resource-provider/blob/main/Dockerfile#L11
Before this change, that command fails (BuildError The command '/bin/sh -c GOPROXY=direct go mod download' returned a non-zero code: 1) and loading the container and running the go command shows that go is not found.
After this fix, loading the container and running go shows the go command is found fine.
Notes
I tried porting the change to the alpine-develop container but it fails on the more elaborate taskcat install command. Given the problems I've had with the alpine-main, I would suggest that this failure might already be happening independent of my changes.
Testing Instructions

Build the container with this file.
Load the container using bash as the entrypoint
run go and verify that you do not get an error that it is missing.

How to test this PR Start after checking out this branch (bulleted)

Include test case, and expected output

Thanks! Closing in favor of https://github.com/aws-ia/taskcat/pull/750 (it got merged first)


HostsFile-Editor uses outdated notepad-version

Microsoft PowerToys version
0.81.1
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Hosts File Editor
Steps to reproduce

Running PowerToys in AdminMode
Open HostsFile-Editor
Select Open Hosts File to open it in notepad
An old outdated notepad-version appears

✔ Expected Behavior
Should use the actual notepad verson
❌ Actual Behavior
An old outdated notepad-version appears
Other Software
Edition	Windows 11 Enterprise
Version	23H2
Betriebssystembuild	22631.3593

Hi @rka-ppi
I have done a quick test on a Windows 11 machine and I have the new notepad launched.
What the Hosts File Editor is doing here is retrieving from the registry the default command associated to the action of edit a text file.
Can you open a PowerShell, execute the command below and post the output?
Get-Item -Path Registry::HKEY_CLASSES_ROOT\SystemFileAssociations\text\shell\edit\command
/needinfo

retrieving from the registry the default command associated to the action of edit a text file.

@davidegiacometti why not just use (some kind of) ShellExecute command?

`Get-Item -Path Registry::HKEY_CLASSES_ROOT\SystemFileAssociations\text\shell\edit\command
Hive: HKEY_CLASSES_ROOT\SystemFileAssociations\text\shell\edit

Name                           Property

command                        (default) : C:\WINDOWS\system32\NOTEPAD.EXE %1`
Well.... Then it's a bug in the Win11 notepad App update mechanism. Strange.

@davidegiacometti why not just use (some kind of) ShellExecute command?

This won't work since the hosts file doesn't have an extension.

Get-Item -Path Registry::HKEY_CLASSES_ROOT\SystemFileAssociations\text\shell\edit\command

Hive: HKEY_CLASSES_ROOT\SystemFileAssociations\text\shell\edit
Name                           Property
----                           --------
command                        (default) : C:\WINDOWS\system32\NOTEPAD.EXE %1

Well.... Then it's a bug in the Win11 notepad App update mechanism. Strange.

Woow! Can you confirm that C:\WINDOWS\system32\NOTEPAD.EXE is opening the old notepad on your PC?

Yes... 'C:\WINDOWS\system32\NOTEPAD.EXE'  will open the old one.
Taskbar and Explorer Actions will open 'C:\Program Files\WindowsApps\Microsoft.WindowsNotepad_11.2404.10.0_x64__8wekyb3d8bbwe\Notepad'

Can you confirm that if you right click a txt file in Explorer and click "Edit" it opens the old notepad?
That's what the editor is doing.

Yes I can confirm. Edit bring up the "new" notepad

ok well, there are two entrys.
new Win11 menu: Explorer -> edit in editor brings the new one
old Win11 menu: Explorer ->  further options -> edit bring the old one


Create greetings.yaml #26

Added Workflow for automated greeting #26

The task is completed.

Please assign this PR to me.


Digest auth doesn't work

Digest authentication doesn't  work with default features;
to test I wrote simple example:
use isahc::{HttpClient, RequestBuilderExt};
use isahc::auth::{Authentication, Credentials};
use isahc::prelude::Request;

#[tokio::main]
async fn main() -> std::io::Result<()> {
    let request = Request::get("https://httpbin.org/digest-auth/test/log/pass")
        .authentication(Authentication::all())
        .credentials(Credentials::new("log", "pass"))
        .body(())
        .unwrap();

    let response = HttpClient::builder().build().unwrap().send_async(request).await;

    match response {
        Err(err) => println!("err {}", err.to_string()),
        Ok(response) => {
            if response.status() == isahc::http::status::StatusCode::UNAUTHORIZED {
                println!("unauthorized");
            } else {
                println!("{:?}", response.into_body().text_async().await);
            }
        }
    }

    Ok(())
}

If I run it I always get "unauthorized". However if I run it with default features disabled like so:
isahc = { version = "0.8.2", default-features = false }

it works and returns expected output. I haven't found any mention of this in docs. So it might be a bug.
os: Debian 10 buster
rust: 1.39

One of the default features is static which builds a local libcurl instead of using the system one; I'm guessing that this is the difference for some reason. Maybe the local libcurl is configured incorrectly.

Looks like digest auth is being disabled at compile time upstream: https://github.com/alexcrichton/curl-rust/blob/65d360ff46dc2bdede7bb396b382f76a4c3fdfcd/curl-sys/build.rs#L106. I'll work on a fix upstream for this. In the meantime, using the system-wide libcurl (by disabling the static-curl feature) is the correct workaround.

Any updates on this?

No updates yet, sorry. :cry:

I'm still not being able to do digest auth, even though it is working using the curl command.
My Cargo.toml has isahc = { version = "0.9.3", default-features = false, features = ["http2", "text-decoding"] }.
I still get 401 with the following snippet. Do you see anything out of place?
let request = Request::get("https://httpbin.org/digest-auth/test/username/password")
    .authentication(Authentication::all())
    .credentials(Credentials::new("username", "password"))
    .body(())?;

let response = HTTP_CLIENT.send_async(request).await?;

if let false = response.status().is_success() {
    return Err(Error::UnsuccessfulHttpRequest(response));
}

You might not have headers for the system curl installed, in which case the curl crate may use a static build anyway. You can check if this is the case by dumping the result of isahc::version() to see which libcurl is used.

That did solve my problem. Thanks!


In minibatch.py, why need to change channels?Maybe we can remove ' im = im[:,:,::-1]'?

In minibatch.py, I find the following code:
from scipy.misc import imread
for i in range(num_images):
#im = cv2.imread(roidb[i]['image'])
im = imread(roidb[i]['image'])
if len(im.shape) == 2:
im = im[:,:,np.newaxis]
im = np.concatenate((im,im,im), axis=2)
# flip the channel, since the original one using cv2
# rgb -> bgr
im = im[:,:,::-1]
"
Since we don't use cv2, we don't need to change channels,right? Because there's something wrong with colors of the input 'im_data' when I try to visualize them.

Author used caffe weights as pretrain. Caffe used openCV and BGR format of image, so I think if you use scipy for image open, you need to convert RGB to BGR format.
NOTE! In my implementation of this method, i use openCV, and i convert BGR to RGB. Even if i use caffe weights, network can get 74.5% on PascalVOC 2007 with Resnet101 backbone. So, i think this is not very important for network.


replace Serial1 by modemStream

#139

It's still assigned in the constructor:
https://github.com/TheThingsNetwork/arduino-device-lib/blob/6f5bea7febeaa542de5b9e4079a69874f65aded8/src/TheThingsNetwork.cpp#L190
And we've let it up to the user to do begin()


Update docs

Pull Request Test Coverage Report for Build 2579

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 69.101%

Totals

Change from base Build 2575:
0.05%

Covered Lines:
9339

Relevant Lines:
13515

💛  - Coveralls


[PE-D][Tester A] Strict format for module names for addschedule

The format for the event field in addschedule might be too strict when using the module type. I'm unable to add "CS2103T" because of the letter T violates the format.

Labels: type.FeatureFlaw severity.High
original: WinSheng1/ped#15

bro put high for everything i think


Revert the translation 'કેમ છો' back to 'Hello World'

We will have to keep 'Hello World' as it is. At many places in documentation, the code from .js file is directly pulled for code snippets in doc. And if the code in .js file tries to print 'Hello World', we will have update the .js file from src folder. Which we think out of translation scope.
Under this issue we want to revert that ''કેમ છો' translation back to 'Hello World' for the below pages.

[x] Home Page
[x] Hello World
[x] Introducing JSX

There weren't any references to કેમ છો in Home Page. Fixed in the other two.
Fixed in #9


kubernetes-helm: 2.11 -> 2.14.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@markus1189  @teozkr @nlewo @yurrriq, updates helm while still built from source, fixes the version issue raised in #56837

@GrahamcOfBorg build kubernetes-helm

That's a peculiar definition of friday! :D

Nice!
On Wed, Jul 17, 2019, 12:32 Teo Klestrup Röijezon<EMAIL_ADDRESS>wrote:

That's a peculiar definition of friday! :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/64979?email_source=notifications&email_token=AAEQNTY6DQRNYCDNASHLK33P73YMRA5CNFSM4IENRCX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DYRIY#issuecomment-512198819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEQNT2ROU5APFUIMUOJVPDP73YMRANCNFSM4IENRCXQ
.

Any tips on how you got dep init and vgo2nix to work well here? In my experience it would seemingly hang for hours before I gave up.

nox-review builds, binaries execute on macos 10.13.

This would also fix CVE-2019-1000008. And if people using helm thinks it is alright also a backport.


Document on rejectUnsupportedCards

in document
braintree.hostedFields.create({
  client: clientInstance,
  fields: {
    number: {
      selector: '#card-number'
    },
    cvv: {
      selector: '#cvv',
      placeholder: '•••'
    },
    expirationDate: {
      selector: '#expiration-date',
      type: 'month'
    }
  },
  rejectUnsupportedCards: true
}, callback);

But there is no rejectUnsupportedCards for options. It is actually in HostedFieldsField options

Thanks for noticing this. Want to open up a PR? Otherwise, we'll get this fixed up soon.

I will let you guys handle it. thx

:+1:

The fix is out in 3.46.0's documentation.
In addition, we've introduced a new supportedCardBrands object where you explicitly turn on or turn off cards from your merchant configuration.
braintree.hostedFields.create({
  client: clientInstance,
  fields: {
    number: {
      selector: '#card-number',
      supportedCardBrands: {
        visa: false, // prevents Visas from showing up as valid even when the Braintree control panel is configured to allow them
        'diners-club': true // allow Diners Club cards to be valid (processed as Discover cards on the Braintree backend)
      }
    },


Add support for populating components

Took me several hours to try everything and then to find this request and understand, that components cannot be populated!
Please, add this feature.
Also, meanwhile please mention somewhere in the docs that components cannot be populated, it is confusing as of now!

Are there any plans to work on this in the near future? thanks @lukasondrej

Also interested in hearing if we there are any plans to work on this? Particularly adding support for Sketch components :slightly_smiling_face:

Same need here.
The thing is if we are having to trade interactivity (ie. clickable components) for dynamic content, and our actual need is to have both.

As far as I understand it, this is due to a limitation in the XD Api. See #198
Would also love to have that feature. I will need use CSV files until this plugin supports components

we're planning to add this feature to the XD version as soon as it's technically feasible for us to do it in an efficient way.
feel free to support our future development here: https://www.buymeacoffee.com/datapopulator


feat: cosmos defi UI part 1: Cosmos DeFi provider

Description
This adds a new DeFi provider for Cosmos. TODO copy and paste
description from 2233
Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Testing

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2293   👈

PR #2294

PR #2295

This comment was auto-generated by Graphite.


chore: Add codeql to the github workflows

Issue #, if available:
Description of changes:
Check points: (check or cross out if not relevant)

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1644 (c50ba6a) into main (2c57ccc) will decrease coverage by 0.00%.
The diff coverage is 55.46%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   59.18%   59.17%   -0.01%
==========================================
  Files         712      715       +3
  Lines       21639    21761     +122
==========================================
+ Hits        12806    12877      +71
- Misses       8833     8884      +51

Flag
Coverage Δ

API_plugin_unit_test
62.40% <83.33%> (+0.04%)
:arrow_up:

AWSPluginsCore
71.30% <52.00%> (-0.31%)
:arrow_down:

Amplify
46.90% <0.00%> (-0.06%)
:arrow_down:

Analytics_plugin_unit_test
71.76% <ø> (ø)

Auth_plugin_unit_test
78.74% <53.65%> (-0.86%)
:arrow_down:

DataStore_plugin_unit_test
76.18% <100.00%> (+0.09%)
:arrow_up:

Geo_plugin_unit_test
52.12% <ø> (ø)

Predictions_plugin_unit_test
26.81% <ø> (ø)

Storage_plugin_unit_test
58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../Categories/Auth/AuthCategory+ClientBehavior.swift
0.00% <0.00%> (ø)

...Categories/Auth/AuthCategoryBehavior+Combine.swift
0.00% <0.00%> (ø)

...ategories/Auth/Request/AuthDeleteUserRequest.swift
0.00% <0.00%> (ø)

...ns/API/AWSAPICategoryPlugin/AWSAPIPlugin+Log.swift
100.00% <ø> (ø)

...nitoAuthPlugin/HubEvents/AuthHubEventHandler.swift
47.69% <0.00%> (-5.76%)
:arrow_down:

...rvice/AWSMobileClient/AWSMobileClientAdapter.swift
12.90% <0.00%> (-0.22%)
:arrow_down:

...nitoAuthPlugin/Support/Utils/AuthErrorHelper.swift
77.20% <0.00%> (ø)

...Configuration/AmplifyAWSServiceConfiguration.swift
82.60% <ø> (ø)

...endency/AuthenticationProviderAdapter+SignIn.swift
70.87% <8.33%> (-4.42%)
:arrow_down:

...AuthorizationProviderAdapter+SignedInSession.swift
85.91% <10.00%> (-5.76%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993864e...c50ba6a. Read the comment docs.


[Fix] Make gradient pack fn public for iced_graphics::Gradient

Changes:

Moved pack_gradient to a pub method of iced_graphics::Gradient named pack. This allows users to pack gradient data when creating their own Primitive::GradientMesh with GradientVertex2D.

The pack_gradient fn for iced::core::Gradient is unchanged as it's internal.

Looks good! 👍


Master

Hi,
Installed as it, the assets files reference in each html page outputed in _sites points to the post folder instead of the root.
I added a few "/".
Tested and works great now, thanks for this cool gem

Also appears to work for me, merging.


Confusing message in docs for deploying webapp

https://github.com/Microsoft/azure-pipelines-tasks/blob/984ca40b9dd3b9279e91936ebb52f72626e8d0f2/Tasks/AzureRmWebAppDeploymentV4/task.json#L437
The message on this line is confusing. I think a rebrand of Azure DevOps has created a mis-match.. user supplied variables are now called pipeline variables which are not excluded. System (provided) variables are exluded

@PhilPeters304
Based on your conversation with @N-Usha on issue https://github.com/microsoft/azure-pipelines-tasks/pull/10089, I am closing this issue.
Feel free to reopen if you still feel this issue relevant.


Add extra test cases

Motivation
Add some new fixtures with some more uncommonly found syntax to make sure our requests can handle them.

@st0012 that is some unholy piece of code. I'm hoping no one is adding code like that to their codebases 😂. That said, those trick snippets might contain some interesting examples that we can test.


[restbed] Unable to configure simple project

I have tried searching for other restbed related issues as well as across other sites with no luck.  The library seemingly builds fine, however I am not able to configure a simple project using restbed on both my mac and windows development machines.
CMake configuration fails at the find_package(restbed CONFIG REQUIRED) line.  From what i could tell this should be the correct way to find the package.
I have tried searching though the restbed folder in the vcpkg packages folder for some hint at what target to use with no luck.
I have attached a simple project which just tries to build the example in the main readme from the restbed repo as well as the build output from my windows machine.
I apologize if i am missing something obvious here.
vcpkg version:
vcpkg package management program version 2023-02-16-12e657924d99511514c0287ca5ce46882d3657c7
Reproduction Steps:

Download and extract the attached zip file containing a minimal project
Modify the line in CMakeLists.txt to set the toolchain file to the relevant path on your system
Attempt to configure the project and observe the error.

restbed.zip
build_output.txt
CMakeOutput.log

Not sure if the issues are related, but I still get this
  Could not find a package configuration file provided by "restbed" with any
  of the following names:

    restbedConfig.cmake
    restbed-config.cmake

  Add the installation prefix of "restbed" to CMAKE_PREFIX_PATH or set
  "restbed_DIR" to a directory containing one of the above files.  If
  "restbed" provides a separate development package or SDK, be sure it has
  been installed.

With cmake -LAH I see
// The directory containing a CMake configuration file for restbed.
restbed_DIR:PATH=restbed_DIR-NOTFOUND

Could you advice, please ?

@gituliar after pulling in the change, i was able to get the cmake configure step to work on my macOS machine using the following CMake code:
find_package(unofficial-restbed CONFIG REQUIRED)
target_link_libraries(restbed-test PRIVATE unofficial::restbed::restbed-static)

@gituliar Please note that upstream restbed doesn't offer cmake config (find_package(restbed CONFIG)).
In such cases, vcpkg may add config in the unoffcial namespace (find_package(unofficial-restbed CONFIG)).
vcpkg also doesn't modify upstream target names. If you need to cover both static and shared linkage, you would need to use:
find_package(unofficial-restbed CONFIG REQUIRED)
target_link_libraries(main PRIVATE $<IF:$<TARGET_EXISTS:unofficial::restbed::restbed-static>,unofficial::restbed::restbed-static,unofficial::restbed::restbed-shared>)

@dg0yt thank you for the detailed explanation. I wasn't sure exactly why I needed to call find package the way I did, but your explanation makes it very clear.
I appreciate all the time and work that has gone into this issue!

@matthewcpp @dg0yt thanks for the feedback. Eventually, I ended with what usually works when package provides provides no CMake config:
find_path(RESTBED_INCLUDE_DIRS "restbed")
find_library(RESTBED_LIBRARY NAMES "librestbed.a" "restbed.lib")

target_include_directories(main PRIVATE ${RESTBED_INCLUDE_DIRS})
target_link_libraries(main PRIVATE ${RESTBED_LIBRARY})


Improve docstrings for lse_scaled and lse_implicit

Unclear what needed to be improved (unsurprising when I didn't add a description).


Performance Related Test

All Development Performance related story will come under this.
One of the development story is
https://github.com/openbmc/openbmc/issues/295

https://github.com/openbmc/openbmc/issues/409

Need to check the basic performance before and after execution of a given test suite.
As of now targeting test_sensors.robot, test_inventory.robot, test_rest_interfaces.robot, test_warm_reset.robot.

This is still needed, especially whenever there is new kernel / new functions like redfish comes up then this will beuserful.


Time format differs from Linux output

Describe the bug
Time format in match is different than using date on Linux machine (Ubuntu 20.04)
To Reproduce
Configure a forwarder and use this block on the receiver
`
@type forward
port 24224
bind <IP_ADDRESS>
@id input_forward

    @type file
    path /logs/${tag}/%Y%m%d%H

#      timekey 15m
#      timekey_use_utc true
#      timekey_wait 5m
       flush_mode interval
       flush_interval 1m
       flush_at_shutdown true

    append false
`
Expected behavior
using this command date +%Y_%m_%d_%H outputs 2021_11_28_15 but using %Y%m%d%H in fluentd configuration file generates<PHONE_NUMBER>_0.log.
The expected file name is<PHONE_NUMBER>_0.log.
Your Environment
- Fluentd version: 1.13.3
- TD Agent version: 4.2.0
- Operating system: Ubuntu 20.04.3 LTS
- Kernel version: 5.4.0-73-generic

Your Configuration
`<source>
  @type forward
  port 24224
  bind <IP_ADDRESS>
  @id input_forward
</source>

<match pm2.app>
    @type file
    path /logs/${tag}/%Y%m%d%H
    <buffer tag,time>
#      timekey 15m
#      timekey_use_utc true
#      timekey_wait 5m
       flush_mode interval
       flush_interval 1m
       flush_at_shutdown true
    </buffer>
    append false
</match>`

Your Error Log
No error log.

Additional context
No response

Default timekey of out_file plugin is 60 * 60 * 24 [sec]:
https://github.com/fluent/fluentd/blob/438a82aead488a86180cd484bbc4e7e344a9032b/lib/fluent/plugin/out_file.rb#L39
https://github.com/fluent/fluentd/blob/438a82aead488a86180cd484bbc4e7e344a9032b/lib/fluent/plugin/out_file.rb#L64
So that logs are splitted per day.
%H is truncated to 00 due to this.
Above thing doesn't seem documented in https://docs.fluentd.org/output/file
We should describe it.

e.g.) If you set timekey 3600, %H will be correctly formatted.

I've added it to the document: https://docs.fluentd.org/output/file#timekey


fix(driver): make module-name a required argument

Not including the module-name results in the following error:
sh-5.0$ python -m jschema_to_python -s common/json/models/auth.model.json -r Auth -o common/json/auth -f -v
jschema_to_python: JSON schema to Python object model generator, version 1.2.3
Generating Python classes...
Traceback (most recent call last):
  File "/home/mohamed/.conda/envs/python/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/mohamed/.conda/envs/python/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/__main__.py", line 13, in <module>
    sys.exit(_main())
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/driver.py", line 14, in main
    generator.generate()
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/object_model_module_generator.py", line 21, in generate
    self.generate_init_file()
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/object_model_module_generator.py", line 30, in generate_init_file
    init_file_generator.generate()
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/init_file_generator.py", line 20, in generate
    self.write_import_statements()
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/init_file_generator.py", line 23, in write_import_statements
    self.write_import_statement(self.root_class_name)
  File "/home/mohamed/Code/corvum/polaris/.venv/lib/python3.7/site-packages/jschema_to_python/init_file_generator.py", line 40, in write_import_statement
    + class_name
TypeError: can only concatenate str (not "NoneType") to str

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mlaradji sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Widget for iOS not refreshing

The widget on iOS doesn't seem to refresh without having to open NNW -- thereby defeating the whole purpose of having a widget imo. I have set the background refresh on. Does NNW have a background refresh poll setting that I am missing?

Background refresh (and therefore background refresh of our widgets) is controlled by iOS.
The more NetNewsWire is used, the more time iOS will give NetNewsWire in the background...with the knock-on benefit of more widget refreshes.
(We request a background refresh every 15 minutes, but whether or not that happens is out of our control.)

Ah makes sense. I thought I used enough to give it more priority but will have to ratchet it up! Will close this issue.


New autogen DLP library.

@ace-n Behold, the new DLP library.

Coverage remained the same at 100.0% when pulling 0812d87c88bc9506d0e64d3b59355b5f4e57c283 on dlp-2017-10 into 9ecca4113c4a16046f014e87a910df47025cb80b on master.

Coverage remained the same at 100.0% when pulling f31e86c11a381e094a393e74e3d5254fb25aac4d on dlp-2017-10 into 9ecca4113c4a16046f014e87a910df47025cb80b on master.

Moved to nodejs-dlp.


if there can be more fine-grained file lock

Is your feature request related to a problem? Please describe.
I try to use the following command to list file path
alluxio fs ls path
when the file path is being written ,the operation is slow,I can't see the writing details
Describe the solution you'd like
can there be more fine-grained file lock,such as hive lock or hdfs lock?and I can use command to change the lock level

Will close it for now, feel free to reopen it and contact us if this is a strong request.


Add Qwen2Tokenizer

Tried to port the python tokenizer but didn't really know how so I used the BPETokenizer like most of the other models and it seems to work 🤷

Not quite sure how to generate the test resources / if a test is necessary


Register v0.1.4

@JuliaRegistrator register
Release notes:
This patch version fixes the issue with wing coordinates shifting in the spanwise direction on interpolation. This enables VortexLattice.jl to be used in a wing/chord distribution optimization problem.

Error while trying to register: Register Failed
@cibinjoseph, it looks like you are not a publicly listed member/owner in the parent organization (byuflowlab).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@JuliaRegistrator register
Release notes:
This patch version fixes the issue with wing coordinates shifting in the spanwise direction on interpolation. This enables VortexLattice.jl to be used in a wing/chord distribution optimization problem.

Error while trying to register: Version 0.1.3 already exists

@JuliaRegistrator register
Release notes:
This patch version fixes the issue with wing coordinates shifting in the spanwise direction on interpolation. This enables VortexLattice.jl to be used in a wing/chord distribution optimization problem.

Registration pull request created: JuliaRegistries/General/104509
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.4 -m "<description of version>" c2a447272f88fe8b1acded4fe8b3ac9c518f3868
git push origin v0.1.4


Gtkdemo not working

I am getting this error when trying to build the gtkdemo:
/home/user/.cache/neat/git/https___github.com_neat-lang_gtk/v0.0.8/src/gtk.nt:75:
            .case(:none: ""));
                  ~~~~~~~~~ Type is not listed in Either!

Seems like the Neat-lang/gtk repo needs a small update, perhaps?

Augh I swear to god, I keep breaking that.

Fixed: it was already fixed, I just didn't use the current version of neat-gtk.


Make context macros self-contained

With this, the various make_context_X macros never reference names from the local crate without fully qualifying them.  Without this, users of the macros would have to use various swagger traits/macros (or #[macro_use] the crate).

bors delegate+

bors r+


⚠ Bofrost.de has degraded performance

In 475e94e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1373 ms

Resolved: Bofrost.de performance has improved in 0354144 after 6 minutes.


Add cargo fmt to github-actions config

@Atul9 thanks! I rebased the branch for you and did a few adjustments to the CI config.

Thank you @dbrgn I have pushed a commit to fix this build failure - https://github.com/dbrgn/tealdeer/pull/119/checks?check_run_id=1048103561 & its fixed in this build - https://github.com/dbrgn/tealdeer/pull/119/checks?check_run_id=1048163935

Thanks @Atul9. The build fails because rustfmt 1.39 and 1.46 use slightly different rules. (That's why I prefer a fixed version in CI :slightly_smiling_face:)
I will bump the rustfmt rust version, but first I'll raise the version used for clippy in a separate PR.
If it's OK, I'll rebase your branch again once that's merged. If you prefer to do the rebasing / adjustments yourself, just let me know :slightly_smiling_face:

it's ok, you can rebase my branch.

Finally, thanks :slightly_smiling_face:


add WITHOUT_TESTS, fix IdType bugs

Allow to build without tests via WITHOUT_TESTS cmake
Fix bugs in types. Before this commit it was impossible to compile project without fatal errors if you change IdType typedef in IdType.h file

Hi Maxim,
IdType issue is by design. If you change IdType you have to change IdTypeUnsign. We are not going to use 64-bit ids right away, it's not so easy to do, b/c of the alignment problems.

Hi.
Of course I mean IdTypeUnsign too. I'm talking about this change:
-typedef uint32_t IdTypeUnsign;
+typedef int64_t  IdType;
+typedef uint64_t IdTypeUnsign;

And yes, alignment is the second step to use 64bit

Do we really need 64-bit IDs right away? If you introduce 64-bit IDs, you basically need either change the layout of Object, or get rid of dist_t=double, which is not a bad idea anywyas. Otherwise, we will have problems like this one: https://github.com/searchivarius/nmslib/issues/9
Yes, we mostly use our own SIMD implementation, but something may sleep through the cracks, so I basically want to be sure we are compliant in the sense that float* pointers are aligned on 4 bytes and double* pointers are aligned on 8 bytes. Or, we remove all the doubles. Again, this is not such a bad idea, because they are not used. So, maybe it's time to remove them.

I need 64 bit Id's in my project, I'm using some hacks now to not to deal with alignment issues (hack object.h to alignment of data not changed).
I think this commit may become first part of using 64bit sometimes in future, anyway I think it's a bug to use IdType for label variable for example (which is fixed in this commit).
So, it's not for 64-bit ID's "right now", but it fixes some related bugs

Ok, then

I would encourage you to remove all the code related to the label variable. Again, similar to double it wasn't useful at all. Whoever needs to do classification can store id-label relationship somewhere else.
What about Python bindings and the query server? Does 64-bit id break them?

BTW, if we remove label, we would get an 8-byte alignment, so we wan't have problem with doubles.

Ohh, sorry, I got confused a bit. Ok, Label has to go, but no rush.
Well, ok. I used IdTypeUnsign to make the count of the data set size to be in sync with the id size. However, this, probably, not necessary.

64-bit id doesn't mean we will deal with > 2B entries on the same machine.
But if we do, many more changes will be necessary anyway. So, let it be simply (32-bit) unsigned for now.

@searchivarius I need 64-bit id not to store >2^31 entries, I just have 64bit id somewhere and don't want to to store nmslib-id32 <-> my-id64 table.

Yes, I eventually figured this out, no problem.


Consider moving to swaywm GitHub org

I've established the swaywm GitHub org and moved wlroots there. We have discussed maintaining wlroots API wrappers within the swaywm organization - if you'd like, I can add you and we can host it there. Of course, the project would remain yours and you'd still have complete autonomy over it.

Sounds good. I was planning on starting this back up again soon (I'll probably take a look this weekend actually). Feel free to add me whenever, and I'll transfer/clone this repo over when you do.

Thanks!

I don't know rust, but I'm interested in learning. I know wlroots pretty well, so if you make issues, I'll contribute to development of wlroots-rs.

@acrisci Good to hear, I know you've been active in the wlroots work.
Most of the work will be making safe wrappers around the wlroots types (eg safe in terms of memory safety, since Rust strives to be memory safe). This will mean trying to make functions that, while implemented using "unsafe" Rust code will be safe from the library user's perspective (eg, they can't accidentally get a dangling pointer).
When I restart work on this (probably this weekend is when I'll have time) I'll be sure to make issues.


Clarified File MaxSize docs

Resolved https://github.com/Azure/azure-sdk-for-net/issues/41532

API change check
API changes are not detected in this pull request.


Contours are broken when using OpenGL and GPU Renderer mode

Describe the bug
When using the Windows OpenGL exe and displaying Contours on a Model, the Contours move depending on the Camera position.
Steps To Reproduce
Steps to reproduce the behavior:

Load Client 44086
Load SEQ Project
Turn on Contours
Turn on GPU Renderer mode
Move the camera about
Observe that the Contours change position based on the camera

Expected behavior
Contours should remain in a fixed position and not move depending on Camera position.
Desktop (please complete the following information):

Platform: Windows OpenGL
Version: <IP_ADDRESS>086

This is fixed in Client <IP_ADDRESS>308.


Test output units

The concentration output should have units of ppm and emissions should have output of PgC/yr or similar.

@maritsandstad ping on this

Ok, I'm a bit confused, @znicholls. I guess I can merge this and get a test that will fail, but I guess this also means I should actually address the issue... (in the near future)

Yes that's the idea. We can also discuss here more if needed (I was hoping the fix would be easy, but maybe I'm missing something)

Turns out, it's actually not hard, just me misremembering things... I'll merge and fix


@History support with query.asOf(Timestamp)

This is initially being supported in Postgres but will be extended to be supported in other database platforms later.
You annotate entity beans with @History - this implies that there is an associated history table maintained for that entity bean. This enables the support of query.asOf() and shortly query.findVersions().

    // 3 hours ago
    long epochMilli = OffsetDateTime.now().minusHours(3).toInstant().toEpochMilli();
    Timestamp asOf = new Timestamp(epochMilli);

   // find Customer and associated objects as they appeared 3 hours ago

    Customer customer =
        Customer.find.query()
            .asOf(asOf)
            .fetch("billingAddress")
            .where().eq("name", "jim")
            .findUnique();

// Note: lazy loading and secondary queries triggered off the 'origin query'
// also propagate the 'as of' timestamp as you would hope - so yes, the
// 'as of' applies to all parts of the object graph where @History is enabled.

Note: Refer to examples / x-postgres-history ... for examples etc


Video/Audio Previewer/Player

When a video/audio file (for at least the most common formats like .mp4 and .mp3) is opened via the sidebar, the video plays on-screen, similar to how images are currently shown when selected or opened from the sidebar.

/duplicate of #72280


QA from Design Team - Feedback Overall

Details: https://airtable.com/shr5dBxld1AMrQSk8

*I asked about #11 Store Locator because they told us to hide that originally.

@laurengerardi
to confirm, so we should hide the store locator in the next update?
also regarding feedback number 6, they said video cropped and positioned wierd, can you clarify? we do not know how it should look like.

Can you clarify number 12, because we follow the design system in the figma spec for cta button


Specific methods in different plugins

Hi decebals,
I have the following problem:
We have a base structure for a kind of plugin.
In their respective implementations I want them to have specific methods, imagine setThis(args) in Plugin A and setThat(args) in Plugin B.
These methods are not declared within the Interface resembling the ExtentionPoint.
Now the problem is, that I can not access these specific methods when loading these plugin.
How can I achieve this, or is this not possible?
Greetings and thanks in advance,
Lucas

It's very clear for me what you try to achieve. An ExtensionPoint should be an interface or an abstract class.
You can do the plugin a singleton, in this mode you can call a method of plugin from another plugin.
Other variant, without singleton, is to use pluginWrapper.getPluginManager().getPlugin(id).
See if https://github.com/decebals/pf4j/issues/181#issuecomment-347946858 helps you.

Thank you very much for the quick answer, I will look into it.
If I encounter any further problems I'll get back to you, but this might take a few days.

I've looked into it and I think I did not quite get across what I meant. I will try to elaborate further and with more detail:
We have a system for which we are implementing plugins for exporting data into different formats (CSV, Json and so on).
In the interface extending ExtensionPoint we have defined some basic functionality shared by all export plugins, such as writing to a file or loading configuration.
What I now want to do is to have a setter for different types of objects in different implementations of the plugins. So for example in plugin A I want to set List and in plugin B I want to set a DatabaseObject. So the methods could be setList(...) and setDatabase(...). But if I now go ahead and declare these methods in the classes implementing the interface (and marked with @Extension) they are not accessbile when using the plugin (as far as I see only those declared in the interface are).
I currently see two solutions:

Have all these specific methods declared inside the interface but only really implement them in the corresponding plugin implementation and leave them empty in others
Have a very generic method like setObject(Object obj) and then implementing this in the plugins.If I remember correctly this would have me casting (would like to avoid this) to List or DatabaseObject and a not very clear name (worse usability)

Is there any way to do this nicer? What I have in mind is:
interface X extends ExtensionPoint{
methodA(...);
methodB(...);
}
PluginA extends Plugin {
constructorMatchingSuper();
pluginAImplementation implements X{
methodA(...){...}
methodB(...){...}
specificMethodA(...){...}
}
}
PluginB extends Plugin {
constructorMatchingSuper();
pluginBImplementation implements X{
methodA(...){...}
methodB(...){...}
specificMethodB(...){...}
}
}
And thus having access to methodA, methodB and specificMethodA when using an instance of PluginA and methodA, methodB and specificMethodB when using an instance of PluginB.
I hope that I now managed to bring my point and problem clearer across to you.
Thank you in advance!

It seems like I can access the specific methods by Casting the Plugins from an general Exporter to a specific exporter.
It would then look like the following:
Original:
PluginManager manager = new DefaultPluginManager(Paths.get("export"));
manager.loadPlugins();
manager.startPlugin("ExporterA");
Exporter exp = manager.getExtensions(Exporter.class).get(0);
Now:
PluginManager manager = new DefaultPluginManager(Paths.get("export"));
manager.loadPlugins();
manager.startPlugin("ExporterA");
ExporterA.ExporterAImplementation exp = (ExporterA.ExporterAImplementation) manager.getExtensions(Exporter.class).get(0);
This still is not very pretty but the reason is, that the specificMethodA() is simply unknown to the interface Exporter.

If I understand correctly you want a mechanism for plugin (or extension)  configuration. You want to inject some dependencies (like connection to database) in your plugin (or extension) from your core application, after you load and start the plugins. Is it correct?

Yes that's about it.
I have now solved it by adding the generic setAdditional(Object object) method to my interface and then having private methods like setDatabase(..) in the plugin implementation which are then used by setAdditional (of course with proper type checking).

Maybe a good move is to change the issue title with something more appropriate (something like "how to configure the plugins"). Maybe other people can come with solutions if the problem domain is clear and general.
Personally, I will try to use a custom implementations for PluginManager and Plugin, something like AcmePluginManager (extends DefaultPluginManager) and AcmePlugin (extends Plugin).
The AcmePluginManager can contain new helper method like getSetings(): Properties (or Map) or, more directly a getDatabaseConnection(): Connection method.
I will use pool technique instead of push (I will extract the database connection in AcmePlugin from AcmePluginManager and not viceversa, push database connection from AcmePluginManager to AcmePlugin).
If I want something more generic, probably I will use the approach used by me in other personal project, Pippo. In Pippo we have a application.properties file that keeps the all application properties, and a PippoSettings class that allow us to read very easy the value for different properties (as Integer, String, Double, Date, List, ...).
I use an easy property name convention to group properties in application.properties (a property prefix). So, you can use the pluginId as prefix, something like:
plugin_1.jdbc.url=
plugin_1.jdbc.username=
plugin_1.jdbc.password=
plugin_2.propA=
plugin_2.propB=
In AcmePlugin, I will add a new method getSettings (or getConfig) method that will return all the propeties of plugin for application.properties, of course without ("plugin1." prefix) like jdbc.url, jdbc.username, jdbc.password.
Make sense for you?


Add Travis and Appveyor

:+1:

Looks like there are a couple Int32/Int64 mismatches that showed up on win32

Fixing those now.


Use the implicitly defaulted constructor

Defining an empty default constructor is worse than using the compiler generated constructor.
Note that the compiler generated constructor requires that constexpr as well as exception specifiers are correctly considered. See Chapter 15.1 [class.ctor] paragraph 7

I don't know whether constexpr should be removed, but if you do end up removing constexpr, be sure to add a test that constexpr construction is still possible.

I kept the constexpr forthe node_handles and added default initialization for the Charmap

@asoffer The last kokoro run had some failure could you ran that againnow that constexpr is still in place

Here's my grip with = default for class templates. As someone who reads and writes a lot of generic code, a user defined constructor effectively communicates its semantics to the reader. For example:
T() {} means T is default constructible, it may throw, and it is not constexpr.
T() = default; means T may or may not be default constructible. It may or may not throw exceptions. And it may or may not be constexpr.

@EricWF There is indeed a certain ambiguity. However I cannot follow you on

T() = default; means T may or may not be default constructible.

If T would not be default constructible then T() {} would be ill formed?! Is there any possibility that T() = default; does not work whereas T() {} does? I am aware that this is the case for move assignment/constructor (which feels like a deficiency of the standard) but I am quite sure this is not the case for the default constructor.
For the ambiguity on the exception specification and constexpr I understand the frustration but isnt it a strict improvement over T() {}?
If it would be noexcept you would have missed that opportunity to improve performance. I am not deep enough in the standard to fully evaluate the ramifications but I would guess that things like containers of T and aggregate with members of type T might suffer some problems as the (wrong?) exception specification propagates up the class hierarchy
The same on constexpr albeit with constexpr T() = default; I do not see such a problem here. Given the advent of constexpr for std::vector in C++20 it quite possible that absl::flat_hash_set might be used in a compile time context in the future.
Is there any benefit on loosing out on these optimizations.

It is unclear to me what the intent of this change is. Is it for improve performance or readability?
From the previous conversation, it seems that T() {} is easier to read than T() = default.

There are some benefits.

The exception specification is inferred
constexpr is inferred. (or enforced byconstexpr T() = default;)

Consequently writing T(){} is a pessimization that might prevent compiler optimizations.

I don't see strong reasons to either change or not change this. Let me take your patch and run it against our internal code base to see if there is any real impact.

I would also blame Greg Falcon for this:
https://youtu.be/6ZOygaUjzjQ?t=1515

On a second thought, I think I still prefer T() {}  more than T() = default, because T() {} conveys the information very clearly: you don't need to look at the members of T to determine whether T is default constructible, nothrow, or constexpr. Later if we want to add a new data member, it won't accidentally change the API. This is even more important when T is a template type, because it's even harder to see through.
However, I do agree that for simple cases like a trivial class, you should probably just write T() =default so you don't make it not trivially default constructible.

Actually it is the opposite.

T will always be non-trivially constructible albeit it could
T will never be marked as noexcept albeit it could
T will not be constexpr albeit it could

I understand that it is more explicit but at the same time the more explicit version is less correct than the implicit one

For 2 and 3, I would prefer constexpr T() noexcept {}.
For 1, which types are actually "losing" trivial default constructibility now?

For 1 a class with T(){} is not trivially_default_constructible even if the same class with T() = default; would be. See your godbolt example in the corresponding issue
For 2 it is more complex as the exception specification depends on T so you would have to write some elaborate conditionals. In the implicit case the compiler does that for you.
For 3. You can also write constexpr T() = default; which was done for those types where constexpr should be enforced.

My point is, whether you write T() = default  or not is just an implementation technique to achieve the API requirements.  The real question is, for each type you are changing, can it/ should it be trivially default constructible/ noexcept / constexpr? After we agree on the answer to this (design) question,  we can easily figure out the best implementation to achieve that.

@miscco Thank you so much for this proposal and the detailed discussion. Looks like the team did not find enough benefit in the change and therefore we decided not to accept the change. Thank you again and we are looking forward to continued collaboration in the future.


Error 501 when registering for push notifications

I migrated an existing GCM app to Firebase and implemented all methods exactly like the sample code. However, I keep getting an error whenever the app tries to get an instance id. The logged messages are:
2016-07-05 16:41:49.298: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "The operation couldn’t be completed. (com.firebase.iid error 501.)"
2016-07-05 16:42:01.676: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "The operation couldn’t be completed. (com.firebase.iid error 501.)"
2016-07-05 16:42:26.735: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "The operation couldn’t be completed. (com.firebase.iid error 501.)"
2016-07-05 16:43:05.580: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "The operation couldn’t be completed. (com.firebase.iid error 501.)"
2016-07-05 16:44:03.260: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "The operation couldn’t be completed. (com.firebase.iid error 501.)"
2016-07-05 16:44:03.261: <FIRInstanceID/WARNING> Failed to retrieve the default GCM token after 5 retries

Does anyone know why this happens? I contacted Firebase support and they couldn't help.
Knowing that this is an app that was working fine before switching to Firebase, I know that push configurations on the app side are working. And considering that all the configuration on the Firebase Console was imported from my previous Google Project, I would assume that my certificates are all working as well.
Does anyone have any clue what I could do to solve this?

bump

I met this issue early, i found out i didn't upload certificate(.p12 file) in Firebase console.
I solved this issue by going to firebase console, click settings icon in left top corner-> Project settings -> cloud messaging -> update .p12 file, rebuild my app

@luccascorrea is this still an issue for you?

I'm closing this issue, as I believe it has been resolved. Feel free to open a new issue if you are still running into this.

Hi, I am still facing the same issue. Cross verified all the settings. Also uploaded development p12 certificate, but getting same error:
2016-11-17 12:04:49.251: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "(null)"
2016-11-17 12:05:14.662: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "(null)"
2016-11-17 12:05:59.066: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "(null)"
2016-11-17 12:07:03.187: <FIRInstanceID/WARNING> Failed to fetch default token Error Domain=com.firebase.iid Code=501 "(null)"
2016-11-17 12:07:03.187: <FIRInstanceID/WARNING> Failed to retrieve the default GCM token after 5 retries
Surprisingly,  it works fine on simulator, but when I try same on device, giving me error.  I am stuck, any help is appreciated.

I am also facing this issue. Strange thing is I am facing this issue ony on very few devices. Is it something related to iOS version?


Rename 03-mad-hatter.md to 02-mad-hatter.md

This solution should be in the 2nd place according to the challenges dashboard ("localhost:8000/challenges")

Thank you for reviewing and contributing to the project. There is no meaning to the order of the solution and is not compatible with the challenge dashboard.


use maybe_normalized image for calculations

Hi Phil,
Since we're normalizing the image, it'd better to feed the normalized image to calculate x_start and mean.  Please let me know if this is wrong. Thanks!

@juvekaradheesh hmm, actually i thought this normalization is just akin to like the first layer of the network, but maybe the author can correct me on that
i should probably just move it into the model itself as a module

Oh! I understand, I will close the pull request. Thanks you!

@juvekaradheesh i could be wrong! do double check on that and reraise the issue if it isn't so


fix: remove unnecessary escape character

Scope of changes
fix: remove unnecessary escape character
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
fix: remove unnecessary escape character
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #564 (0776bbc) into main (720d163) will decrease coverage by 7.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   45.06%   37.47%   -7.60%
==========================================
  Files         489      152     -337
  Lines       14152     2391   -11761
  Branches     1146      610     -536
==========================================
- Hits         6378      896    -5482
+ Misses       6795     1320    -5475
+ Partials      979      175     -804

Impacted Files
Coverage Δ

...-user-ui/src/components/PasswordStrength/index.tsx

...risacrypto/directory/pkg/gds/store/index/search.go

...ts/CertificateReview/TrisaImplementationReview.tsx

...omponents/TestnetProgress/CertificateStepLabel.tsx

...gds-user-ui/src/components/MemberDetails/index.tsx

...risaImplementation/TrisaImplementation.stories.tsx

...ts/SwitchFormControl/SwitchFormControl.stories.tsx

...ts/CertificateReview/LegalPersonReview.stories.tsx

...er-ui/src/components/StatCard/StatCard.stories.tsx

web/gds-user-ui/src/components/ui/Card.tsx

... and 327 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720d163...0776bbc. Read the comment docs.


[Slideover] Double click is not prevented on mobile

I'm not 100% sure this is a bug, but I'd expect when I double-click on a slideover on mobile, it does not zoom, because after that, the behaviour is broken (touch is delayed, etc.).
Note that my main viewport is:
 <meta
      name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no"
/>

As a workaround, I'm using <USlideover @dblclick.prevent="">.
Thanks!

Would you mind providing a reproduction on StackBlitz for example?

I'm not even sure this is related to nuxt UI so I'm gonna close the issue to let you work on more important stuff.
Will reopen if relevant. Thanks.


Helper programs network isolation

In a pod with two containers, how would you isolate one of the container from the network (except maybe for some whitelist)?
I don't have AppArmor available so I can't set a custom profile to the container and I'm not sure how I could to this with SELinux + iptables.
Going for '--net=none' could be a start but I don't know how to set this in the manifest files.

We do not have an answer here, yet.  We're expecting a proposal for network
plugins $soon, which will give us some ideas on how to implement arbitrary
network insanity, on the low end of which is various forns of isolation.
On Thu, Feb 26, 2015 at 4:11 AM, josselin-c<EMAIL_ADDRESS>wrote:

In a pod with two containers, how would you isolate one of the container
from the network (except maybe for some whitelist)?
I don't have AppArmor available so I can't set a custom profile to the
container and I'm not sure how I could to this with SELinux + iptables.
Going for '--net=none' could be a start but I don't know how to set this
in the manifest files.
--
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4838.