Add tests

Coverage increased (+3.0%) to 77.924% when pulling f9239dbf71a41237f61995e0ce2b5299bd0ed8d7 on add-tests into 9d421cfb39fe513d5235e3eb2209ae2d66edab99 on master.

Codecov Report

Merging #49 into master will increase coverage by 3.24%.
The diff coverage is 85.76%.

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     74.91%   78.15%   +3.24%
+ Complexity     5714     5606     -108
============================================
  Files           331      328       -3
  Lines         11903    11386     -517
============================================
- Hits           8917     8899      -18
+ Misses         2986     2487     -499

Impacted Files
Coverage Δ
Complexity Δ

src/Factory/Device/MobileFactory.php
85.61% <ø> (+3.24%)
533 <0> (+3)
:arrow_up:

src/Factory/Device/Mobile/UmiFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/TwzFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/XoloFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/TbTouchFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/ZenithinkFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/YotaFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Detector.php
0% <0%> (ø)
14 <0> (-4)
:arrow_down:

src/Factory/Device/Mobile/UltrafoneFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

src/Factory/Device/Mobile/VastKingFactory.php
0% <0%> (ø)
3 <1> (ø)
:arrow_down:

... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d421cf...ee445fc. Read the comment docs.

Coverage increased (+3.0%) to 77.924% when pulling cfcdd3e3900d00210fbe9a16b2e673c958ca5340 on add-tests into 9d421cfb39fe513d5235e3eb2209ae2d66edab99 on master.

Coverage increased (+3.0%) to 77.924% when pulling cfcdd3e3900d00210fbe9a16b2e673c958ca5340 on add-tests into 9d421cfb39fe513d5235e3eb2209ae2d66edab99 on master.

Coverage increased (+3.0%) to 77.924% when pulling cfcdd3e3900d00210fbe9a16b2e673c958ca5340 on add-tests into 9d421cfb39fe513d5235e3eb2209ae2d66edab99 on master.


should_set_storage is duplicate of should_set_cookie

hi thanks for the PR and your previous one. have you seen #221 ? this function was included specifically to support that. the logic is arranged quite specifically, we could comment this more potentially..
also f there is something you are looking to do it could do it would be getting the tests working with multiple python versions 😀


One user with multiple identities

Question
Hey,
first of all thanks for all the great work you did with Identity Server 4 and good luck on your future endeavors.
I've got a question: We have users that will be able to select an identity they want to login as, after typing in their credentials. These identities should (in our best case implementation) look totally different to the client, meaning that the client will receive a different "sub" claim if the user logs in as a different identity.
We investigated this issue a bit and came to the conclusion that it is very important that the session you have with Identity Server 4 is containing the correct sub claim in the default identity of the ClaimsPrincipal located at ClaimsPrincipal.Identity.
Changing the subject id in that identity would be generally possible, but would prevent the user from logging into two different clients with different identities at the same time. (Because IdentityServer only checks the default identity regardless of client).
So I just wanted to ask if our analysis is correct, meaning that we currently can't implement something like this, without heavily modifying the code or if there is a reasonable way to do this and what that could look like.
Thanks for your help!

Basically you are asking about multiple concurrent sessions.
This is nothing we have designed for - and yes you are right - this would mean to make some major changes to our code.

Hey thanks for your answer.
Just out of interest: If I were to implement multiple concurrent session for IdentityServer is that something that would have a chance to get upstream (for Duende)? Or is this out of scope for IdentityServer or are the architectural changes so major that it does make little sense if you don't do it yourselves?

I really don't know. It would be a major change, and we haven't looked into all the implications yet.


⚠ ClamAV has degraded performance

In e409e36, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in bbf4b8b.


Tesla implemented API rate limiting, now adapter gets blocked with HTTP/429 "Retry in 51661 seconds"

Describe the bug
See $SUBJECT. See also just every other Tesla API integration, e.g. TeslaMate: https://github.com/teslamate-org/teslamate/issues/3957
To Reproduce
Steps to reproduce the behavior:

Start the adapter
Look at logs, and wait

Expected behavior
Adapter should be able to poll the API the whole day. Instead, requests are rate limited according to https://developer.tesla.com/docs/fleet-api#membership-levels:
Screenshots & Logfiles
tesla-motors.0	2024-06-15 11:41:41.854	error	"Retry in 51499 seconds\n"
tesla-motors.0	2024-06-15 11:41:41.854	error	AxiosError: Request failed with status code 429
tesla-motors.0	2024-06-15 11:41:41.853	error	https://owner-api.teslamotors.com/api/1/vehicles/CENSORED/vehicle_data
tesla-motors.0	2024-06-15 11:41:41.853	error	General error
tesla-motors.0	2024-06-15 11:41:11.828	error	"Retry in 51529 seconds\n"
tesla-motors.0	2024-06-15 11:41:11.827	error	AxiosError: Request failed with status code 429
tesla-motors.0	2024-06-15 11:41:11.827	error	https://owner-api.teslamotors.com/api/1/vehicles/CENSORED/vehicle_data
tesla-motors.0	2024-06-15 11:41:11.827	error	General error

Versions:

Adapter version: 1.3.2
JS-Controller version: 5.0.19
Node version: v18.19.0
Operating system: Raspberry OS 64bit 11.9

Additional context
This may require a significant rewrite to be more conservative with requesting vehicle data. However, I am using tesla-motors information to control solar overflow charging of my vehicle, and this requires the charge state, current, battery etc. to be available in at least 30s to 1min intervals during charging. I also run TeslaMate to collect the rest of my vehicle stats.
Addressing this should be a collaborative effort and I'd be willing to help!

I began to experiment it since yestedar after a long drive. This morning it was working until I started to charge up the car at home, after 3 hours, now Teslamate shows teh error 429.
2024-06-15 13:55:23.957 [info] Starting logger for 'xxxxxx'
2024-06-15 13:55:23.992 [info] MQTT connection has been established
2024-06-15 13:55:24.119 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (57.265 ms)
2024-06-15 13:55:24.119 [warning] TeslaApi.Error / "Retry in 43476 seconds\n"
2024-06-15 13:55:24.119 car_id=1 [error] Error / :unknown
2024-06-15 13:55:54.249 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (51.010 ms)
2024-06-15 13:55:54.250 [warning] TeslaApi.Error / "Retry in 43446 seconds\n"
2024-06-15 13:55:54.250 car_id=1 [error] Error / :unknown
2024-06-15 13:56:24.373 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (48.689 ms)
2024-06-15 13:56:24.374 [warning] TeslaApi.Error / "Retry in 43416 seconds\n"
2024-06-15 13:56:24.374 car_id=1 [error] Error / :unknown
2024-06-15 13:56:54.501 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (49.341 ms)
2024-06-15 13:56:54.501 [warning] TeslaApi.Error / "Retry in 43386 seconds\n"
2024-06-15 13:56:54.502 car_id=1 [error] Error / :unknown
2024-06-15 13:57:22.684 [notice]     :alarm_handler: {:set, {TeslaMate.Vehicles.Vehicle_1_api_error, :fuse_blown}}
2024-06-15 13:57:24.628 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (47.889 ms)
2024-06-15 13:57:24.629 [warning] TeslaApi.Error / "Retry in 43356 seconds\n"
2024-06-15 13:57:24.629 car_id=1 [error] Error / :unknown
2024-06-15 13:57:54.756 [info] GET https://owner-api.teslamotors.com/api/1/vehicles/1492931814800821/vehicle_data -> 429 (49.707 ms)


Cask 'esse' definition is invalid

Hello!
Just reporting this error I got with an up-to-date brew:
❯ brew info esse
Error: Cask 'esse' definition is invalid: 'appcast' stanza failed with: Calling the `appcast` stanza is disabled! Use the `livecheck` stanza instead.
Please report this issue to the melonamin/formulae tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/melonamin/homebrew-formulae/Casks/esse.rb:7

Thanks, fixed


updated the list

Add the guys from new upcoming startups and others. Please review and merge.

Hi @rakesh-sankar some of those are really interesting, thanks for your suggestions, I'll review and add it as soon as possible.

Yelp, tumblr, paypal, shopify and uber have been added to the list. Thanks again for your suggestion!


Make "Refresh on load" for namespace and podname configurable in influxGrafana yaml

Hi All,
Is it possible to make these variables to be environment variables so I can control them in influxdb-grafana-controller.yaml file?
From the code review I see these variable are hardcoded to true or false.

which variable are you talking about?  Also, if they're sink-specific, they'd need to be sink URI parameters

I want to be able to change this parameter(Red circle). Not in the UI but when creating the POD.

In the code I can see: https://github.com/kubernetes/heapster/blob/96d9dbf9ee20c200bb7703a8dff0b5ea7c1d1ba1/grafana/dashboards/pods.json#L977
For example for my case, I need this var to be always true.

Ah, it's a change to Graphana.  Those are mainly just examples, not really part of Heapster.  You can build your own Graphana image pretty easily to make that change.

We'd take a pull request to make it an environment variable, though.

@DirectXMan12  Can you share the pull request?

I think you may be misunderstanding me -- I was suggesting that if you, or someone else, submitted a pull request to make the change, we'd be happy to accept it :-)

It could be done by post-processing text in pods.json during grafana startup. For example, it could be done, using sed from 'run.sh' which is starting up grafana in a container.
Such processing would add some extra complexity in the system, and may break pods.json if sed is not triggered or used in a wrong way. I was wondering if we would like to go ahead with such approach? Or maybe there are different solutions possible?
@piosz any thoughts?

@piosz advised dashboard configuration could be injected into container using ConfigMap. It would externalize dashboard configuration and make it possible to configure "refresh on load" and any other variables from kubernetes level.


Feature Requests:  Group permissions card per module

Hi,
My app has lot of modules. I would like to have something to group permissions by module
For example:  Crm/Contact -> crm.contacts::viewAny ...
Ideally the permissions card will be displayed grouped by module : billing, crm, assets, ...
with search field  that will search into module, resource and permission
Regards

Grouping is because at least in my case I've got  a complete ERP with dozens of modules:
Billing, Crm, Assets, Provisioning, Telephony, Wharehouse, Tickets,  Settings, Common Data, ...
and sometimes resources can have same name in different module.

Grouping is because at least in my case I've got a complete ERP with dozens of modules:
Billing, Crm, Assets, Provisioning, Telephony, Wharehouse, Tickets, Settings, Common Data, ...
and sometimes resources can have same name in different module.

I understand, and while the project is open source, I believe that the project will be better by contributing by adding this feature.


Update Live Publication in Archive on Capture Agent Change

Before I begin, I would like to apologize to whoever will review this, because you're now going to have to deal with this extremely complicated and messy code.
The problem this PR is trying to fix is the following: If someone changes the capture agent for a scheduled live event, the URLs of the live tracks (which usually contain the capture agent name) are updated for search, but not in the archive. This means that the External API still serves the old information, and the live stream cannot be played. Additionally, the URLs in the search service are only up-to-date temporarily, but can revert back to their old state on the next snapshot.
The reasons for this are two-fold:

The live schedule service reads the capture agent name from the episode Dublin Core spatial field, called location in the metadata. (This is IMO very questionable, because we might put other stuff in that metadata field aside from the capture agent id, and would not expect this to impact the live publication, but changing this was out of scope for this PR. One thing at a time...)
When changing the capture agent, the scheduler service actually writes the CA id into that metadata field. This information is then put into the Elasticsearch index and handed over to the live schedule service. It is not, however, actually archived. Which means that on the next snapshot (unless we change metadata in the Admin UI, which will send all fields to the back-end on a change, including the location info from the index), that value is overwritten again.
The second problem is that the live schedule service updates the live tracks for search on a capture agent change, but doesn't actually update the live publication that the asset manager knows about.

So basically what I did here in both cases is to actually tell the asset manager what the hell is going on. Because I had a lot of problems understanding the code and was concerned that I could unintentionally break something, this also contains some refactoring. This is not supposed to change behavior, but simply make things clearer. I'm also fairly certain that there are more bugs in the affected code and that it could be simplified more, but this was out of scope for this work. I hope to be able to revisit this in the future, but for now, this will hopefully make things a little bit better.
Edit: I would also like to add that I still don't completely understand why the code does the things it does, so please don't ask me.

I'm also fairly certain that there are more bugs in the affected code and that it could be simplified more[...]

Did we get bugs in our code, or code in our bugs?

So this looks right to me, but without a way to properly test with a streaming-capable CA it's hard to tell. Is there an easy way to set up a fake streaming CA that you're aware of?

Technically, you don't need to have a capture agent at all to test this. It's enough if Opencast thinks there's a capture agent. I tested this by first configuring live streaming (add publishLive parameter to a workflow and configure some stuff in the LiveScheduleService.cfg) and then registering three fake capture agents via the /capture-admin rest endpoint.
The changes in this PR only affect the live publication in Opencast, so you can just check if it contains the right URLs for its tracks before/after changing the capture agent by asking the asset manager and the search service respectively. No streaming necessary. :)

@KatrinIhler back in previous versions of Opencast, a change to schedule/event metadata would make an archive snapshot prior to publishing the update. Is this not the case anymore with scheduled events? [EDIT] I'm not sure if I'm right, but before just the mediapackage top level and catalog metadata is updated when a live scheduled event updates. And now the updated live publication element in the archived mediapackage is also updated.

That snapshot is still happening. But the live schedule service also needs to take a snapshot when changing the live publication, and the scheduler service forgot to include some information when taking its snapshot.
The data in the search service was always updated successfully.

I have (finally) gotten a test harness working for this, and am confident that it does what it says on the tin.  Happy to merge if @karendolan doesn't have any objections?

Important: This is merged into r/11.x but reverted as part of the merge back to r/12.x.
Can you please submit a new patch for 12?


Out of memory in toolsJS/test virtually every time

Possible track to fix it: http://stackoverflow.com/questions/26094420/fatal-error-call-and-retry-last-allocation-failed-process-out-of-memory

Note that this apparently happens during the Emitter phase. Another possible fix might be to investigate why the Emitter needs so much memory (more than the optimizer!). IIRC it prints everything in one giant string. This could be very bad if the string gets too big.


Make sure assessment tool annotations make it to the output .json

With #285 completed, we need to also make sure that the assessment tool annotations successfully make it into the .json output according to our data dictionary specification: https://neurobagel.org/dictionaries/#assessment-tool

[ ] add assessment tool mappings to the JSONoutput getter in the store
[ ] ensure that the output .json includes the correctly formatted information
[ ] test the new functionality, including with an e2e test

@rmanaem looks good?


Provide transition state through the new Reat Context API

The class changes are great, but in some instances, you may want a more intricate transition and it would be great ot respond to the page transition states from specific components in the page, especially when working with css modules for instance.
While its totally possible to solve my use case using CSS, I think it would be beneficial to have the option of accessing this state, and being able to use JS animations if and when we would like to.

Agreed that it would be nice to be able to have more intricate transitions. Can you provide an outline of the API you're picturing?

Closing due to lack of response. Would be happy to reopen in the future if you have more ideas to share!


Android/Java client SDK : Blocks main thread for login error

I am using below code to login to deepstream
private static void loginToDeepStream() {
	try {
		client = new DeepstreamClient(Const.CONST_CHAT_HOST);
		client.setRuntimeErrorHandler(new DeepstreamRuntimeErrorHandler() {
			@Override
			public void onException(Topic topic, Event event, String s) {
				log("Error : via callback" + s);
				client.close();
			}
		});
		LoginResult result = client.login();
		if (result.loggedIn()) {
			log("realtime server ready");
		} else log("realtime server not ready");
	} catch (DeepstreamException ex) {
		log("error : " + ex.getStackTrace());
	} catch (URISyntaxException ex) {
		log("error : " + ex.getStackTrace());
	}
}

I tried to call this function from main thread and from background thread both, but whenever network goes offline, it calls setRuntimeErrorHandler and shows black screen on device (android). Seems it tries to reconnect again.
How can I force deepstream to make connections on background instead of main thread. Currently even I am calling this method from doInBackground method of AsyncTask class, it blocks UI when setRuntimeErrorHandler gets call .
Please assist me better way if any to perform login and reconnection code without blocking UI thread

Even i am Facing the same issue. is there any solution for this?

Im terribly sorry about this, we have a few issues raised about threading.
We are generally going to do a small rewrite soon to reflect alot of lessons learnt and will introduce async methods to allow users to deal with threading themselves if desired.

@yasserf It would be really good if this handling could be done easily at mobile end as mobile app loses network more frequently and those network exception must be handled internally at deepstream end. Along with that deepstream should also expose method to override the exception behaviour and should notify the activity/service of no network access

Same issue also for me, do you feel we are going to see a solution for this any time soon?

Hey! We are working really hard to getting a new revamped JS and Java client out that addresses these problems. We will be looking at this next week and should have a beta out very soon.

Thanks Yasser, for update.
Let me know if I can help you in anyway.
ᐧ
Irfan Raza
mailTo<EMAIL_ADDRESS>New Delhi, India
On Thu, Nov 2, 2017 at 8:46 PM, Yasser Fadl<EMAIL_ADDRESS>wrote:

Hey! We are working really hard to getting a new revamped JS and Java
client out that addresses these problems. We will be looking at this next
week and should have a beta out very soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/deepstreamIO/deepstream.io/issues/742#issuecomment-341454838,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTJTsY_-nj0qR-yafaJJgC9eUZcEN9Jks5sydzYgaJpZM4OQNGp
.


Autocomplete in Row Editor

When selecting the column for the aggregation of the metric it doesn't provide a autocomplete for the column. This would be nice to have the column selectable.

Does it persist after latest updates?

i'll check this.

this works now perfectly.


WIP: Fixing assorted bugs

Pull Request Test Coverage Report for Build e77d10dfcf77796fe468c5b2fcd3ad2171a712dd-PR-13

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 64.431%

Totals

Change from base Build 9114e5987a36640b4e1d9bb7966874ff756c0b89:
1.3%

Covered Lines:
221

Relevant Lines:
343

💛  - Coveralls


There has been an error running msiexec/i

included a picture if it works (this is what happens when I try and install on windows 10)

Out of curiosity does anyone care? or is this just a pile of crap software? emailed and had not one response and not one person has bothered to respond here

I am also experiencing the same issue. Any troubleshooting steps would be appreciated.

Same issue here, judging by the lack of response to previous posts am going to assume this software isn't supported anymore


Beta theme switches from light to dark mode.

Hi,
Noticed, that when download manager error " There was a problem parsing the package" occurs, then it triggers (not every time) theme change, so theme changes from light to dark. Screenshots added.

I fixed theme bug in 495c0ff574114961a95a96839dd1f7daa827d8b8.
That bug probably fixed in next release.


Raytrace pipeline creation fails only on release build

I am using ash v37, but I don't see much connection between the changelog and this problem so I'm waiting to deal with the breaking changes unless someone can confirm that this is a problem particular to v37.
I have a pretty uncomplicated ray trace pipeline, and my program works fine in its debug build. But if I run the release target, I get a crash with an Access Violation error, and this in the Vulkan validation layer:
    [0] 0x26e4786ee90, type: 1, name: NULL

VUID-VkPipelineShaderStageCreateInfo-sType-sType(ERROR / SPEC): msgNum:<PHONE_NUMBER> - Validation Error: [ VUID-VkPipelineShaderStageCreateInfo-sType-sType ] Object 0: handle = 0x26e58d68060, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x567efb65 | vkCreateRayTracingPipelinesKHR: parameter pCreateInfos[0].pStages[0].sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkPipelineShaderStageCreateInfo-sType-sType)
Objects: 1
[0] 0x26e58d68060, type: 3, name: NULL
VUID-VkPipelineShaderStageCreateInfo-sType-sType(ERROR / SPEC): msgNum:<PHONE_NUMBER> - Validation Error: [ VUID-VkPipelineShaderStageCreateInfo-sType-sType ] Object 0: handle = 0x26e58d68060, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x567efb65 | vkCreateRayTracingPipelinesKHR: parameter pCreateInfos[0].pStages[1].sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkPipelineShaderStageCreateInfo-sType-sType)
Objects: 1
[0] 0x26e58d68060, type: 3, name: NULL
VUID-VkPipelineShaderStageCreateInfo-sType-sType(ERROR / SPEC): msgNum:<PHONE_NUMBER> - Validation Error: [ VUID-VkPipelineShaderStageCreateInfo-sType-sType ] Object 0: handle = 0x26e58d68060, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x567efb65 | vkCreateRayTracingPipelinesKHR: parameter pCreateInfos[0].pStages[2].sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkPipelineShaderStageCreateInfo-sType-sType)
Objects: 1
[0] 0x26e58d68060, type: 3, name: NULL
VUID-VkPipelineShaderStageCreateInfo-pNext-pNext(ERROR / SPEC): msgNum: -768403575 - Validation Error: [ VUID-VkPipelineShaderStageCreateInfo-pNext-pNext ] Object 0: handle = 0x26e58d68060, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xd2331789 | vkCreateRayTracingPipelinesKHR: pCreateInfos[0].pStages[0].pNext chain includes a structure with unknown VkStructureType<PHONE_NUMBER>); Allowed structures are [VkPipelineShaderStageRequiredSubgroupSizeCreateInfo]. This error is based on the Valid Usage documentation for version 204 of the Vulkan header.  It is possible that you are using a struct from a private extension or an extension that was added to a later version of the Vulkan header, in which case the use of pCreateInfos[0].pStages[0].pNext is undefined and may not work correctly with validation enabled The Vulkan spec states: pNext must be NULL or a pointer to a valid instance of VkPipelineShaderStageRequiredSubgroupSizeCreateInfo (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkPipelineShaderStageCreateInfo-pNext-pNext)
Objects: 1
[0] 0x26e58d68060, type: 3, name: NULL
As far as I can trace things, s_type is VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO (what else could it be?) Do you have any insight why this is happening?

@ktmattson-alion this sounds a lot like you're creating memory corruption, such as referring to a stack-local piece of memory that been "deallocated", or overwritten in a loop. Thanks to pointer magic and perhaps accidentally calling .build(), Rust's borrow checker is no longer able to validate that your code is safe (and is one of the reasons why all raw Vulkan calls and pointer dereferences in general are marked unsafe).
This is exactly what the ash 0.38 release is preventing, by removing .build() and no longer allowing users to discard the lifetime of Vulkan structs containing pointers to elsewhere within their Rust program. I strongly urge you to bite the bullet and upgrade, as it will help you point out exactly where this issue is occurring in your code at compile time (assuming you use the builder pattern/API, and not accessing raw fields with pointer coercion or casting).

If that doesn't help, you should share a snippet of all this struct-construction code leading up to vkCreateRayTracingPipelinesKHR() so that we can have a look.

That sounds plausible, and in fact, while I use the deref pattern rather than build() for the most part for this very reason, here I had been calling build on the final struct. Moving that into the deref pattern fixed the issue.
I guess the reason this happens for the release target is that optimizations mess with pointer magic that worked in the debug build.
I appreciate the work you've all put into this latest release, and I will go shave the yak; I just wanted to make sure that I didn't go into that time sink and come out the other end with the same bug 😄 Also, thank you for the quick response.

here I had been calling build on the final struct. Moving that into the deref pattern fixed the issue.

Just curious: did the compiler point out an apparent lifetime issue after changing to Deref?

I guess the reason this happens for the release target is that optimizations mess with pointer magic that worked in the debug build.

Typically the dev profile keeps things alive for longer, which is actually a bit unfortunate here because people generally expect (if there's not too much unsafe around) for their application to work & behave in the exact same way in a release build, which you found out the hard way it doesn't.

Glad you figured it out quickly, and good luck with the migration! Besides extension module renaming, it shouldn't be all too terrible after removing .build() and replacing s/::builder()/::default()/ :+1:

Glad you figured it out quickly, and good luck with the migration! Besides extension module renaming, it shouldn't be all too terrible after removing .build() and replacing s/::builder()/::default()/ and s/::name()/::NAME 👍

I migrated one or two projects and it was a smooth ride.
See https://github.com/adrien-ben/imgui-rs-vulkan-renderer/pull/41/files

Just curious: did the compiler point out an apparent lifetime issue after changing to Deref?

It did in this way, the code that did not work was like so:
             let pipeline_create_info = vk::RayTracingPipelineCreateInfoKHR::builder()                 .stages(&[*rgen_stage_info, *rmiss_stage_info, *rchit_stage_info])                 .groups(&[*rgen_group_info, *rmiss_group_info, *rchit_group_info])                 .layout(pipeline_layout)                 .flags(vk::PipelineCreateFlags::empty())                 .max_pipeline_ray_recursion_depth(2)                 .build();
And in order to use Deref on pipeline_create_info, the stages and groups had to be moved into their own array, or else borrow checker would warn about the temporary reference. In retrospect, that seems like an obvious red flag--all that build() did was paper over the borrow checker's error--but there it is.


Wrote and built the documentation

We should first merge #47 and then re-build the documentation before merging this PR so that the example.ipynb is rendered properly.
In particular, @veerupandey could you please review the docs for your function to make sure that I've understood it correctly? Feel free to add anything you think might help clarify things!
This PR fixes #38.

Ready for review.


Uses patches when modifying the subscription-admin CRB

This uses patches to modify the open-cluster-management:subscription-admin
ClusterRoleBinding instead of kubectl apply in order to avoid collisions
with the GRC Policy Generator BVT test.
Resolves:
https://github.com/stolostron/backlog/issues/20570

/lgtm


How to include resource files in sub projects?

Similar to:
https://github.com/sbt/sbt-assembly/issues/316
https://github.com/sbt/sbt-assembly/issues/337
I have the following for sbt 1.x:
// https://www.scala-sbt.org/1.0/docs/Howto-Project-Metadata.html

lazy val commonSettings = Seq(
    organization := "fmv1992",
    licenses += "GPLv2" -> url("https://www.gnu.org/licenses/gpl-2.0.html"),
    version := IO.readLines(new File("./src/main/resources/.version")).mkString(""),
    scalaVersion := "2.12.8",
    pollInterval := scala.concurrent.duration.FiniteDuration(150L, "ms"),
    // Workaround according to: https://github.com/sbt/sbt/issues/3497
    watchService := (() => new sbt.io.PollingWatchService(pollInterval.value)),
    maxErrors := 100,
    resourceDirectory in Compile := baseDirectory.value / "src" / "main" / "resources",
    // unmanagedResourceDirectories in Compile += { baseDirectory.value / "src" / "main" / "resources"},

    // This final part makes test artifacts being only importable by the test files
    // libraryDependencies += "org.scalatest" %% "scalatest" % "3.0.5" % Test,
    //                                                                   ↑↑↑↑↑
    // Removed on commit 'cd9d482' to enable 'trait ScalaInitiativesTest' define
    // 'namedTest'.
    libraryDependencies += "org.scalatest" %% "scalatest" % "3.0.5",

    logLevel in assembly := Level.Debug,

    scalacOptions ++= Seq("-feature", "-deprecation", "-Xfatal-warnings")
    )

lazy val GOLSettings = Seq(assemblyJarName in assembly := "game_of_life.jar")

lazy val uniqSettings = Seq(assemblyJarName in assembly := "uniq.jar")

// IMPORTANT: The name of the variable is important here. It becomes the name
// of the project on ivy (projectnote01).
//
// However the name of "common" in `file("./common")` is not. Scala seems to be
// agnostic to project layout.
//
// Furthermore this project may be published locally with:
//
// ```
// sbt "clean" "set offline := true" "clean" "update" 'publishLocal'
// ```
//
// But it must be build also locally with:
//
// ```
// sbt "clean" "clean" "update" compile
// ```
//
lazy val util       = (project in file("./src/main/scala/fmv1992/fmv1992_scala_utilities/util")).settings(commonSettings)

lazy val gameOfLife = (project in file("./src/main/scala/fmv1992/fmv1992_scala_utilities/game_of_life")).settings(commonSettings).settings(GOLSettings).dependsOn(util)

lazy val uniq       = (project in file("./src/main/scala/fmv1992/fmv1992_scala_utilities/uniq")).settings(commonSettings).settings(uniqSettings).dependsOn(util)

lazy val cli        = (project in file("./src/main/scala/fmv1992/fmv1992_scala_utilities/cli")).settings(commonSettings).dependsOn(util)

// Root project.
lazy val root = (project in file(".")).settings(commonSettings).aggregate(
    cli,
    gameOfLife,
    uniq,
    util
    )

And a single resource file:
./fmv1992_scala_utilities/src/main/resources/cli_example_01.txt

In the end I have a few jars:
./fmv1992_scala_utilities/target/scala-2.12/root-assembly-0.6.2.jar
./fmv1992_scala_utilities/src/main/scala/fmv1992/fmv1992_scala_utilities/util/target/scala-2.12/util-assembly-0.6.2.jar
./fmv1992_scala_utilities/src/main/scala/fmv1992/fmv1992_scala_utilities/uniq/target/scala-2.12/uniq.jar
./fmv1992_scala_utilities/src/main/scala/fmv1992/fmv1992_scala_utilities/game_of_life/target/scala-2.12/game_of_life.jar
./fmv1992_scala_utilities/src/main/scala/fmv1992/fmv1992_scala_utilities/cli/target/scala-2.12/cli-assembly-0.6.2.jar

But only on one the jars the resource file is included:
./fmv1992_scala_utilities/target/scala-2.12/root-assembly-0.6.2.jar

How can I include it in all of them?

It turns out that my understanding of sbt was the issue. A simple:
    resourceDirectory in Compile := file(".") / "./src/main/resources",
    resourceDirectory in Runtime := file(".") / "./src/main/resources",

in the common settings solved the problem.


Website isn't showing my relay name and pubkey

I edited my .nostr/settings.json file to show my relay's name and pubkey a couple of days ago, but I'm not seeing the changes. Is there somewhere else in my server's directory this file should be? This is the top section of the settings.json file.
root@nymsrelay:~/.nostr# cat settings.json
{
"info": {
"relay_url": "wss://nostr.nymsrelay.com",
"name": "Nym's Relay",
"description": "A nostr relay written in Typescript.",
"pubkey": "bcea2b98506d1d5dd2cc0455a402701e342c76d70f46e38739aadde77ccef3c9",

You need to have the appropriate headers set, or there will be a cors issue. See this nip for info: https://github.com/nostr-protocol/nips/blob/master/11.md

I see that you figured it out, closing


Mails with empty body text not sent

Describe the bug
When creating a new mail, it is (quietly) not sent, when no text is entered for the body (even if attachments exist), using the latest beta from Play Store
To Reproduce
Steps to reproduce the behavior:

Create new mail
Enter recipient and subject
Do not enter a text in the body
Send mail
Email is not sent but no message is shown and mail disappears

Expected behavior
Mail is sent
Environment (please complete the following information):

K-9 Mail version: 5.719
Android version: 10
Device: MI Mix 3
Account type: IMAP/SMTP

Works for me.
Please record a debug log while trying to send such a message. See https://github.com/k9mail/k-9/wiki/LoggingErrors


Invite filter DM & DMed invite modlog

Add configurable user notifications for message filter actions

Booleans added to server configuration, with the exception of the token filter since notification is handled by its own cog
If the filter's "user_notification" is True, a message is DMed to the user on filter action. This falls back to an in-channel mention if the user has DMs disabled
User notification message is configurable in the filter dictionary

Adjust the mod log message to read "via DM" rather than "in <#deleted-channel>" if a filter is triggered in a DM

Closes: #243
Closes: #245

I'm testing this PR and one thing I've noticed is the following:
When you enable the user notification for a filter that has no message specified, the bot will throw the obvious exception:
discord.errors.HTTPException: BAD REQUEST (status code: 400): Cannot send an empty message

This isn't wrong, I think, but as it's anticipated, we may want to handle it. Maybe we can have the bot send this to modlog or mod_alert so it's obvious to the one that decided to turn the feature on that they forgot a crucial step: Setting the actual message to be send to the user.
Except for that, everything works well here, so if we decide against the thing above, I'll approve it directly.

I guess it does make sense to prepopulate them if they're going to be a config option


⚠ Bofrost.be has degraded performance

In d8b2317, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1589 ms

Resolved: Bofrost.be performance has improved in 56a01b6.


Issue with installation

Hi
Can someone please help with following issue.
Thanks
pip3 install cellphonedb
...
Using cached fonttools-4.42.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (4.5 MB)
Using cached kiwisolver-1.4.5-cp310-cp310-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (1.6 MB)
Using cached pyparsing-3.1.1-py3-none-any.whl (103 kB)
Building wheels for collected packages: scikit-learn
Building wheel for scikit-learn (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for scikit-learn (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [796 lines of output]
:17: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
Partial import of sklearn during the build process.
:116: DeprecationWarning:
    `numpy.distutils` is deprecated since NumPy 1.23.0, as a result
    of the deprecation of `distutils` itself. It will be removed for
    Python >= 3.12. For older Python versions it will remain present.
    It is recommended to use `setuptools < 60.0` for those Python versions.
    For more details, see:
      https://numpy.org/devdocs/reference/distutils_status_migration.html

  INFO: C compiler: gcc -pthread -B /home/ec2-user/anaconda3/envs/cpdb/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/ec2-user/anaconda3/envs/cpdb/include -fPIC -O2 -isystem /home/ec2-user/anaconda3/envs/cpdb/include -fPIC

...
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for scikit-learn
Failed to build scikit-learn
ERROR: Could not build wheels for scikit-learn, which is required to install pyproject.toml-based projects
python --version
Python 3.10.13
OS: Red Hat Enterprise Linux with High Availability

Hi hemantgujar,
Are you trying to install CellphoneDB into a clean virtual environment? If not, please see https://cellphonedb.readthedocs.io/en/latest/RESULTS-DOCUMENTATION.html#installation for more information.
Best,
Robert.

yes. thanks. that's ok. i was able to install using github file. for some reason pip3 install cellphonedb was not working for me.


Dynamic component not rendering slot tree

Vue version
2.6.12
Link to minimal reproduction
https://codepen.io/Dimi_0-o/pen/QWPKENG?editors=1010
Steps to reproduce

Open https://codepen.io/Dimi_0-o/pen/QWPKENG?editors=1010 with chrome, full width,
click the "Open Create Modal", the modal with text-field renders properly
Decrease the width of the window so that you hit the mobile media query (max-width: 800px)
the modal is now in fullscreen but label of text-field is not rendered

What is expected?
the label of text-field should be rendered
What is actually happening?
once a dynamic update of the drawer component, the label of text-field (slot) is not rendered
System Info
No response
Any additional comments?
It's the same issue as this one https://github.com/vuejs/vue/issues/6891, however, git history shows that there were fixes to this issue in version 2.5.3, but the bug still appears in 2.6.12

Only open issues with minimal repros (no vuetify)


Query tests migration to new IT framework with TLS

Migrated the old query group tests to the new IT framework.
This PR migrates the following tests -
ITTwitterQueryTest
ITBroadcastJoinQueryTest
ITSqlCancelTest
ITSystemTableQueryTest
ITWikipediaQueryTest
ITJdbcQueryTest
ITUnionQueryTest

To help move this along, can we split the PR into parts? Maybe one or two tests per PR?
To do that, create a new PR with one or two tests. Create another with another one or two. These can be done in parallel if there are no common files (the ideal case), or sequentially if there are shared files.
Once all but two of the tests have been done in their own PR, merge master (with those tests) into this branch, leaving the last couple of tests.
In particular, the security-related tests should be their own PR since they are quite complex by themselves.
For extra credit, revise the docker-compose.yaml files to us the new templating mechanism. If that is too much of an ask, go ahead and do a PR as-is, and I'll convert the files, since I can do so quickly (having written the generator code...)


Workflow trigger?

Could you please explain what initiates the workflow? What is the trigger to run the steps?

Hello ProximaHaiz,
Thank you for asking.
The workflow of the network runs every time the Controller receives data from a sensor of that network. In other words, the trigger is the event of receiving a record with the data from a sensor.
For example, if you have two sensors in the network that send records every 10 minutes, the workflow will run 12 times an hour.
Of course, you can differentiate the sensors and define the steps to run by setting the conditions and the flow of the processes.
Check our Wiki pages for more information. Please, let me know if more explanation is needed.
-SensorOcean Team


Not found

Hi,
I run up both server and client on the same machine, and tried to use the server to transer file to client. But on the client side, it always print "Not found". I believe I've put the file in the right directory, maybe I was wrong.
I run cargo run --manifest-path=tools/atoml --bin quiche-client -- https://<IP_ADDRESS>:4433/file.txt --no-verify on the client side.
And run cargo run --manifest-path=tools/apps/Cargo.toml --bin quiche-server --       --cert tools/apps/src/bin/cert.crt       --key tools/apps/src/bin/cert.key on server side.
And only "Not found" got print on the client side.

Please try to set --root  option in quiche-server to point the right directory.

Thank you very much, it is solved now. Really appreciate!


support obdiag check

Summary

close #31
Solution Description

Supports the use of yaml to write inspection items, and implements inspection of the cluster through rules written in yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.渠磊 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[DO NOT MERGE]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

That PR includes management service APIs for sensitivity labels in managed instance.
Also it adds API to existing version (2017-03-01-preview) for listing recommended labels or current labels (not necessarily both)

Automation for azure-sdk-for-node

@igsiroti please ping me directly when this PR will be ready to review/merge.

Please fix Model Validator error:
Validating "examples" and "x-ms-examples" in  specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/sensitivityLabels.json:
Validating "examples" and "x-ms-examples" in  specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/sensitivityLabels.json:
 error:
operationId: SensitivityLabels_ListByDatabase
scenario: >-
  Gets the current and recommended sensitivity labels of a given database in a
  managed instance
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "SensitivityLabels_ListByDatabase", parameter
    sensitivityLabelSource is required in the swagger spec but is not present in
    the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''

Why was I not included on this review?
Was ManagedDatabaseSensitivityLabels considered for operation name?


开启查询优化器后，小表inner join大表，1.0.0版本性能比0.2.2版本性能差3倍

(you don't have to strictly follow this form)
Bug Report
开启查询优化器后，小表 inner join 大表， 1.0.0版本的性能比0.2.2版本性能差3倍
0.2.2 版本性能: 0.212s
1.0.0 版本性能: 0.677s
How to Reproduce
1、Create Table：
CREATE TABLE if not exists db.test1
(
	did String,
	name String,
    key UInt32,
    value String,
    pt_d Date
)
ENGINE = CnchMergeTree()
PARTITION BY toYYYYMMDD(pt_d)
ORDER BY (did, key);

2、Insert Data
INSERT INTO db.test1 SELECT
    concat('id', toString(rand(now()) % 10000000)),
    concat('name', toString(rand(now() + 1) % 20000000)),
    rand(now() + 2) % 100,
    concat('value', toString((rand(now() + 3) % 50000) + 1)),
    '2024-11-08'
FROM numbers(50000);

INSERT INTO db.test1 SELECT
    concat('id', toString(rand(now()) % 10000000)),
    concat('name', toString(rand(now() + 1) % 20000000)),
    rand(now() + 2) % 100,
    concat('value', toString((rand(now() + 3) % 50000) + 1)),
    '2024-08-23'
FROM numbers(5000000);

3、Query
5万和500万数据 inner join
SELECT uniq(value) AS count
FROM
(
    SELECT t1.value AS value
    FROM
    (
        SELECT value AS value
        FROM db.test1
        WHERE pt_d = '2024-11-08'
    ) AS t1
    INNER JOIN
    (
        SELECT value AS value
        FROM db.test1
        WHERE pt_d = '2024-08-23'
    ) AS t2 ON t1.value = t2.value
);

4、Performance
| t1的结果数量 | t2的结果数量| 0.2.2版本enable_optimizer = 1|0.2.2版本enable_optimizer = 0 |1.0.0版本enable_optimizer = 1| 1.0.0版本enable_optimizer = 0|
| --------- | ---------- | ---------- |-------- |--------- |---------------- |
| 5w |     500w |0.212 sec |0.707 sec  |0.633s  | 0.629s |
| 500w |    5w  |0.123 sec |0.519 secc |0.095 sec | 0.519 sec  |

开启查询优化器,5w和500w inner join的时候1.0.0版本的性能是0.2.2的3倍
The result you expected
开启查询优化器后,5w和500w inner join的时候1.0.0版本的性能优于0.2.2版本
Analysis Cause
1、0.2.2版本的查询计划
┌─explain──────────────────────────────────────────────────────┐
│ Expression ((Projection + Before ORDER BY))                                                                                │
│   Aggregating                                                                                │
│     Expression ((Before GROUP BY + (Projection + Before ORDER BY)))                                           │
│       Join (JOIN)                                                                                │
│         Expression ((Before JOIN + Projection))                                                                                │
│           SettingQuotaAndLimits (Set limits and quota after reading from storage)                           │
│             ReadFromPreparedSource (Read from remote replica)                                                       │
│         Expression ((Joined actions + (Rename joined columns + Projection)))                                  │
│           SettingQuotaAndLimits (Set limits and quota after reading from storage)                           │
│             ReadFromPreparedSource (Read from remote replica)                                                       │
└───────────────────────────────────────────────────────────┘

2、0.2.2版本的关键日志
启动了多个线程执行JoiningTransform算子、AggregatingTransform算子， FillingRightJoinSide耗时0.06s;
2024.12.04 14:08:27.044173 [ 222200 ] {${query_uuid}_1}  PipelineExecutor[767] : Thread finished.


Restricted requesting payments to self and splitting bills with self

@Dal-Papa
Details
Restricted user email or mobile number from search results.
Fixed Issues
$ https://github.com/Expensify/Expensify.cash/issues/3572
Tests | QA Steps
Note: Have an account with an email and mobile number linked to test out all possible cases.
Case 1:  Splitting bills:

Click New
Click Split Bill
Enter your own email/mobile number in the search
Your own email/mobile number will not appear in search results

Case 2: Requesting money:

Click New
Click Request Money
Enter your own email/mobile number in the search
Your own email/mobile number will not appear in search results

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[ ] Android - Kindly test on Android.

Screenshots
Web
Profile

Request

Mobile Web
Profile

Request

Desktop
Profile

Request

iOS
Profile

Request
Email

Mobile Number

I have read the CLA Document and I hereby sign the CLA

recheck

check

recheck


Potted Plant + Atmos Plaque Cleanup

About the PR
Cleans up the atmos plaques and potted plants. removes the custom logic from each and replaces them with entities + spawners.
another pr will come soon doing the same for bar signs.
Screenshots

Changelog
<!--
Here you can fill out a changelog that will automatically be added to the game when your PR is merged
There are 4 icons for changelog entries: add, remove, tweak, fix. I trust you can figure out the rest.

You can put your name after the :cl: symbol to change the name that shows in the changelog (otherwise it takes your GitHub username)
Like so: :cl: PJB

Generally, only put things in changelogs that players actually care about. Stuff like "Refactored X system, no changes should be visible" shouldn't be on a changelog.


Add many_entities_mut function variants to DeferredWorld

Objective
Closes #15038.
Solution
Added:

DeferredWorld::get_many_entities_mut
DeferredWorld::many_entities_mut
DeferredWorld::get_many_entities_dynamic_mut
DeferredWorld::get_many_entities_from_set_mut
UnsafeWorldCell::get_entities (used by the above functions)
UnsafeWorldCell::get_entities_dynamic (used by the above functions)

Changed:

Made equivalent functions on World reuse the newly introduced methods on UnsafeWorldCell for their implementations.
Fixed the safety comment on DeferredWorld::get_entity_mut.

Testing

Added 3 tests for the World functions since they were previously missing.
Added 3 tests for the DeferredWorld functions.

Migration Guide

World::get_many_entities and World::get_many_entities_dynamic now return QueryEntityError instead of Entity in the Err path to match the signatures of their _mut counterparts.

Closed in favor of #15614


Offset bookmarks

Example bookmark table:

description
offset
type
value

Gold
0xF00BA5
int
99999

Name
0xF00B55
string[64]
"ayylmao"

scrapped due to being out of scope


[zh] Update securing-a-cluster.md

Signed-off-by: Gao Qian<EMAIL_ADDRESS>

@windsonsea  Thank you for your help. I will finish revising it as soon as possible

@mengjiao-liu The modification has been completed. Thank you for help。

/lgtm
/approve


Rename package to 'brotlicffi'

Closes #145
Other things:

The brotlipy branch houses the brotlipy package which will only receive a 0.8.0 release.
Once this PR lands I'll rename the GitHub repository to brotlicffi
Will add __version__ to both brotlipy and brotlicffi and release a v0.8.0 of each

As urllib3 1.26.x still depends on brotlipy and the wheel for manylinux cp37 is missing on PyPI, should it be uploaded or a patch should be made to urllib3?

@McSinyx I've uploaded a Python 3.7 manylinux wheel.

Awesome, thanks!


Inconsistent height generation

This seems to happen inconsistently and I have no idea why.

I think this is a side effect of live reloading in dev


Updated for CredHub v0.6.0

I tested this and it worked for me.

Since credhub is still beta software, could these PRs be merged and similar commits to bump credhub go straight to master?

Pulled in as 0.7.0.


Return only relevant master copies

Modifies master copy endpoint
Don't return not L2 MasterCopies on L2 networks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 88.092%

Files with Coverage Reduction
New Missed Lines
%

safe_transaction_service/history/services/collectibles_service.py
2
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
5748

Relevant Lines:
6525

💛  - Coveralls


Use async redis client for local scraper

The synchronous blocking is slowing us down a lot.

#80


Increased funcionalities

Adds new features:

Search filter;
Dependency checking;
Lock/unlock button for remembering always-active modules;

Awesome, thanks ! You're making quite a few people happy with this i think.


Insert BaishanCloud copyright line

based on files changed in PR #3566
Initially, I have add a copyright line into all files those are changed in PR #3566 , I don't know if this follows the rules correctly...

The point of the CLA system is that just the Authors line will be necessary and sufficient; I don't think this is desirable.

Really? Not so exactly as the information I got...

This does seem undesirable from my point of view. We have historically included copyright lines like this where a file has substantially been submitted from a third party and they request it - but not typically with minor amendments. You can imagine the copyright sections would get quite large quite quickly if everyone who ever made a change inserted their own copyright.

But we don’t require copyright transfer, and some companies want their copyright.  So far its not onerous.

If a company wants their copyright listed, we can do it.  We hope they don’t multiple like rabbits ☺  We have already done that for others (intel oracle Nokia etc).

We have already done that for others (intel oracle Nokia etc).

But in those cases the contributions were a significant part of the file - not minor amendments. TBH I haven't actually checked - but were there significant contributions that justify these? I don't recall any.

But in those cases the contributions were a significant part of the file - not minor amendments.

Hmmm, that depends on how 'significant' is measured, say, by lines of code? or by functionality the changes provided?. I agree that not all of these files (8 files) were changed significantly measured by code lines, but some of them are also not 'minor amendments'...

Removed copyright lines in minor amendments files.

Unless it is effectively a major new functionality contribution we haven't done this in the past - nor do I think this should be done in this case or in the future. Basically the contribution recognition is handled elsewhere. And the git history and changelog work to keep this clean.
Given all the work that is going into cleaning up this area (previously lots of different copyright statements in the code) I would be cautious about  going down this path or we will end up with 100s of copyright lines like this which serve no real purpose.

I will close this PR, and add copyright lines to other newly added files in other PR. Please further discuss this over there. Thanks!

#3859 and #3783 are the two PRs those want to insert a copyright line. @mattcaswell @t-j-h


Store fee parameters for created orders

This is so we can later analyze what fee related parameters where used during order creation.
Turned some fee related numbers from U256 into f64 because we were doing the conversion inside the functions anyway and this is clearer and easier to test.
Test Plan
CI

Codecov Report

Merging #1387 (e6be12a) into main (80a7a80) will decrease coverage by 0.13%.
The diff coverage is 34.34%.

:exclamation: Current head e6be12a differs from pull request most recent head 65a8102. Consider uploading reports for the commit 65a8102 to get more accurate results

@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   66.30%   66.17%   -0.14%
==========================================
  Files         146      146
  Lines       30053    30108      +55
==========================================
- Hits        19928    19925       -3
- Misses      10125    10183      +58

Nice, the second step will be to record the gas amount/price used when we index the trade events, right?

Right! We get TX hashes, so technically the data is there, just not convenient ATM.


Add BOOST_COMPUTE_NO_BOOST_CHRONO configuration macro

This adds a "BOOST_COMPUTE_NO_BOOST_CHRONO" which disables
including/using Boost.Chrono from Boost.Compute.

Coverage remained the same at 83.351% when pulling 47f2b8fde830d2f4a1ad5a24da8605a68708b135 on no-boost-chrono-config into e2bca3a14aa8125f21c6fdf6c38a2adda91c5338 on develop.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.12.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


GoogleCloudToolbar extension on VS2017 stopped working

An user have installed the GoogleCloudToolbar extension on VS2017. It was working fine until one day it started throwing the below error. This error pops up as soon as I open VS.
"The 'GoogleCloudExtensionPackage' package did not load correctly.
The problem may have been caused by a configuration change or by the installation of another extension. You can get more information by examining the file 'xxxxxx/ActivityLog.xml'
Restarting Visual Studio could help resolve the issue"
The user uninstalled all other extensions that he downloaded, reinstalled googlecloud ext, resinstalled VS, repaired. Nothing fixed the issue. 'Publish to google cloud' option is disabled. Clicking on any other options like 'Manage Accounts' under GoogleCloud toolbar opens the same error pop up.
The ActivityLog is attached:
ActivityLog.txt

Here's some additional information if needed:

Precise version of Windows
Windows 10 Pro Version 1803

Precise version of Visual Studio,including updates (Help / About screenshot works)
Microsoft Visual Studio Professional 2017
Version 15.8.0
VisualStudio.15.Release/15.8.0+28010.0
Microsoft .NET Framework
Version 4.7.03056

Version of Google Cloud Tools extension
Version <IP_ADDRESS>

Authentication state in the plugin
Unable to check because Manage account option is shown as disabled

Reproduction scenario
Unfortunately I don't know. It was working fine and one day an error started popping up as soon as I open VS. Also when I select any options in the cloud toolbar.

Exact result with screenshots of any error messages
screenshots attached

The VS detailed version information.
VS_Help_About_Info.txt

Thank you so much for including the Activity log.  It looks like, somehow, one of your user accounts has multiple account user account files.
Go to %LOCALAPPDATA%\googlecloudvsextension\accounts and you will find several *.json files. Deleting them all should fix this issue.
At least two of those *.json files have the same "account":"<user-email>" field.

I am opening #1065 to track a fix for the underlying bug.

Thanks. The above fix worked. There were 2 *.json files in the folder and it started working when I deleted both of them.

Glad to hear you are about to use the extension again.


Wrong version of history library in package.json ?

Hello , I checked package.json file of the react-router library and as I see you are using  history library in dependencies like that "history": "^3.0.0". But new version of "history" library completely changed path structured. That's way I got error when using history library by installing react-router. Because history library is coming last version because of defined upgrade version flag "^" ("history": "^3.0.0")  .  After I installed history library by strict version like npm install<EMAIL_ADDRESS>--save then problem solved.

history 3.2.1 should be what's installed with that dependency. While 4.5.1 is the latest, we don't support it in react-router 3.x (yet?). The caret version will install any 3.x.y version, not anything on the 4.x side.
I'm not sure how that would have happened, but it might be an out of date npm version. Not sure, but that's definitely not what happens for me (otherwise our Travis builds would fail)

Hello @timdoor. Actually on mac os I have not seen error about this. But I got this error on windows system.
Thank you for quick response. I will check it again.


[FR] support nontrivial argument y in jax.numpy.cov

Currently, np.cov(x, y) will raise the title error NotImplementedError together with Open a feature request at https://github.com/google/jax/issues !. It would be nice to support this feature.

This feature is supported in Jax now, so we can close this issue.


KBFS issue - no folder structure exists

[On macOS. /keybase files are not available. When doing an ls /keybase, the error I receive is - ls: : Device not configured.]
my log id: bac0e32d8daa7049a4f2191c

Hi @dbldub, I took a quick look at your logs, and everything seems ok. Is it possible you've had a terminal tab open under /keybase for multiple days, and that's where you're seeing the problem?  If so, a cd /keybase would fix it.  The app updates and restarts itself on macOS, which umounts and re-mounts /keybase, so any old tabs would still be cd'd into an old mountpoint.
If that doesn't help, let me know and I'll look more deeply into it.

Hi @strib,
I usually close the terminal application when I'm done with it. I started a new terminal session and tried the lines below.
Last login: Thu Aug 17 15:36:05 on ttys000 Wades-MBP:~ wade$ cd /keybase/ Wades-MBP:keybase wade$ ls . Wades-MBP:keybase wade$ pwd /keybase Wades-MBP:keybase wade$ ls ls: .: Device not configured
The file structure was empty, then I couldn't list again after that.
Thanks.

Ok thanks.  Are you willing to do a keybase log send so I can look at what might be wrong?

I was using my machine today when I noticed that the Keybase application was not running. I started the application, and then the folder structure was there. It seems that the KBFS is working as expected now. I see the files I created on keybase.pub. Restarting the Keybase application the other day did not help. I'm not sure what happened. Is there any other troubleshooting that is possible, or do we close the issue?

I guess if the application got shut down somehow, that would explain things.  If you'd like us to investigate why it might have been shut down (whether a crash or a user action or something else), then please send logs and we'll look.  Otherwise feel free to close this out.

Thanks. I will close the issue.


Gulp4 and Imagemin error

Hi,
I am running a Windows 10 OS and trying to use gulp4 with imagemin to minify some png files. But ran into errors:
Here is my gulpfile:
var gulp = require('gulp4'),
    concat = require('gulp-concat'),
    uglify = require('gulp-uglify'),
    myth = require('gulp-myth'),
    jshint = require('gulp-jshint'),
    imagemin = require('gulp-imagemin');

var paths = {
    js: 'app/js/*.js',
    css: 'app/css/*.css',
    images: 'app/img/*.{JPG,jpg,png,gif}',
};

//Styles Task
gulp.task('styles', function(){
    return gulp.src(paths.css)
               .pipe(concat('all.css'))
               .pipe(myth())
               .pipe(gulp.dest('dist'));
});

//Scripts Task
gulp.task('scripts', function() {
    return gulp.src(paths.js)
               .pipe(jshint())
               .pipe(jshint.reporter('default'))
               .pipe(concat('all.js'))
               .pipe(uglify())
               .pipe(gulp.dest('dist'));
});

//Images Task
gulp.task('images', function(){
    return gulp.src(paths.images)
               .pipe(imagemin())
               .pipe(gulp.dest('dist/img'));
});

//Watch Task
gulp.task('watch', function() {
    gulp.watch(paths.css,gulp.series('styles'));
    gulp.watch(paths.js, gulp.series('scripts'));
    gulp.watch(paths.images,gulp.series('images'));
});

//Default task
gulp.task('default',
gulp.parallel('styles','scripts','images','watch'));

Here is the error:
[10:57:44] Using gulpfile D:\Documents\Working\Gulp\gulp-book\gulpfile.js
[10:57:44] Starting 'default'...
[10:57:44] Starting 'styles'...
[10:57:44] Starting 'scripts'...
[10:57:44] Starting 'images'...
[10:57:44] Starting 'watch'...
[10:57:45] Finished 'styles' after 874 ms
[10:57:45] Finished 'scripts' after 881 ms
[10:57:45] 'images' errored after 913 ms
[10:57:45] Error in plugin "gulp-imagemin"
Message:
    The system cannot find the path specified.

Details:
    errno: ENOENT
    code: ENOENT
    syscall: spawn D:\Documents\Working\Gulp\gulp-book\node_modules\optipng-bin\vendor\optipng.exe
    killed: false
    stdout:
    stderr: The system cannot find the path specified.

    failed: true
    signal: null
    cmd: D:\Documents\Working\Gulp\gulp-book\node_modules\optipng-bin\vendor\optipng.exe -strip all -clobber -fix -o 3 -out C:\Users\abhilk\AppData\Local\Temp\4f2800d8-3bc0-47e1-95a0-2c9e73133c05 C:\Users\abhilk\AppData\Local\Temp\bf26e857-0623-4783-b68a-c76223792cd3
    timedOut: false
    fileName: D:\Documents\Working\Gulp\gulp-book\app\img\gulp.png
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

[10:57:45] 'default' errored after 954 ms
[10:57:45] The following tasks did not complete: watch
[10:57:45] Did you forget to signal async completion?
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>taskrunner: `gulp4`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>taskrunner script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\abhilk\AppData\Roaming\npm-cache\_logs\2018-02-06T05_27_45_442Z-debug.log

package.json file:
  "name": "gulp-book",
  "version": "1.0.0",
  "description": "",
  "main": "gulpfile.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "taskrunner": "gulp4"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "gulp": "^3.9.1",
    "gulp-concat": "^2.6.1",
    "gulp-imagemin": "^4.1.0",
    "gulp-jshint": "^2.1.0",
    "gulp-myth": "^1.1.0",
    "gulp-uglify": "^3.0.0",
    "gulp4": "^4.0.2",
    "imagemin-jpegtran": "^5.0.2",
    "imagemin-pngquant": "^5.0.1",
    "jshint": "^2.9.5",
    "pngquant-bin": "^3.1.1"
  },
  "dependencies": {
    "optipng-bin": "^4.0.0"
  }
}

Please let me how I can resolve this. Thanks :)

I'm using gulp 3 but got the same error with the latest version (4.1.0) of the gulp-imagemin package.
A quick fix that worked for me was to revert back to version 3.4.0 of the gulp-imagemin package.

Yes reverting back to version 3.4.0 worked for me.

The error shows that optipng was missing on your system. Usually removing the local node_modules folder and doing npm i fixes this, otherwise something (like antivirus) is blocking the file.


Using Github's "Releases" functionality

Would it be possible to use Github's "Releases" functionality?
Doing so would make it far easier to find the correct version of the plugin to use for different versions of Koha. If you look at https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink, you can see the .github/workflows are used to automate this process.
Storing a compiled/compressed file in the Git itself is rare, and the Github "Releases" would be a good place to externalize that.

Great idea!  I'm working on setting up some releases that better track the stable versions.

I've done some initial work to get releases set up.  When we've got a little more time, I'm going to work on automating it and I'll get an update to the readme in master soon.  Thanks for this suggestion!  In the meantime I'm going to close the issue since we've got an implementation of this now and a plan going forward to consider automating it.


Adding Waukesha County Technical College

Requesting the addition of Waukesha County Technical College (WCTC)

To clarify, instructors have @wctc.edu emails and students have @my.wctc.edu emails.  So that is why I'm requesting both file locations so that instructors and students have access to teach and learn with JetBrains tools :)

@bschultz43 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host wctc.my.edu not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Include atracker event routing in upgrade test

Description
Currently upgrade test uses examples/observability_archive which does not have atracker event routing logic, better to include toned-down version of examples/observability_at_event_routing in examples/observability_archive and rename it as complete example then either delete examples/observability_at_event_routing or move TestRunEventRoutingExample to other_test.go
Also delete route-2 https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances/blob/f1754c67e86e98669569e325209852de61d50850/examples/observability_at_event_routing/main.tf#L193
New or affected modules
https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances

By submitting this issue, you agree to follow our Code of Conduct

:tada: This issue has been resolved in version 2.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix for create-rcu-schema scripts (issue 1610)

Hi @markxnelson @rjeberhard  @mriccell  @rdas0405,
This PR has fixes for #1610 -

Support for namespace
Fix for image pull secret in rcu yaml
Support for sys and schema passwords
Use output dir for creating rcu.yaml based on the template rather updating existing common/rcu.yaml directly
Use sys user instead of demo user scott which may not be available in all Database for connectivity check.
Update README.md with latest changes.

Please review and approve these changes.
Thanks,
Asha

this needs to be targeted at develop - we do not update things in master like this without comprehensive testing first


id, $id, confusion in general, and since ajv 4 in particular

This is a less an ajv specific and more a "Ids/refs are confusing in Json-schema".
Maybe documentation / example request for something with both internal ids and how to do that under current (6.5.0) ajv?
As always, Ajv is great, and I am glad you are interpreting / understanding the spec so I don't have to!

I have!  I appreciate you taking the time to explain it.
I use the 'schemas' key for instantiation in some projects. Refs within the same file are also confusing.  I realize this is an obscure / advanced use case.
Perhaps I need to look at how one of the 'deref' packages works, and write it out!

Just bear in mind that $ref in JSON schema does not mean de-referencing, it it not the same as copy pasting the referenced schema instead of $ref in general case. There was a long conversation on JSON schema org on the subject and also see https://github.com/epoberezkin/ajv/blob/master/FAQ.md#generating-schemas-with-resolved-references-ref

The closest programming analogy to $ref is a function call (and that's how ajv implements it internally - only the simplest cases are inlined as an optimisation), not a macro as many people seem to think.


not getting the "rbenv: version x.y.z is not installed" warning

I just setup a new computer and after installing rbenv successfully according to the rbenv-doctor script, I am no longer getting warnings when changing into directories that have a .ruby-version file where that version is not installed locally.
I'm on OS X 10.13.4 and rbenv rbenv 1.1.1-30-gc8ba27f.
Any idea why this is happening?

Simply changing into a directory won't result in any error, even if the version is missing. Try running ruby -v in the directory where the .ruby-version file references a Ruby version that isn't installed: you will get an error.
Unlike other version managers, rbenv doesn't auto-execute anything when simpy cding into a new directory.

Quite possible @mislav but I got to my old computer today and saw that in fact I used to at least have this experience.


There is no useful FTP solution

Hi,
VS Code has not FTP solution. I downloaded the ftp-sync and ftp-simple plugins but they are not useful. Notepad++ npp-ftp plugin is very useful for developers. I think every developer wants FTP solution like npp-ftp in VS Code.
Thanks.

Then contribute to these extensions or create an issue there, so they will meet your wishes. :)
But here is definitely not a place for such an issue. thx

@dbaeumer - is this finall decision that this issue is pined to "*extension-candidate" ?
https://github.com/Microsoft/vscode/issues/20861 - depend this issue
Coz we can wait soo long for some good FTP solution that bether is to still use notepad++ ..it's realy curious in this situation that VSC have so big potential for be the main editor and forgot about notepad++

The best FTP solution I found is actually Deploy. It doesn't have ftp in its tags, so you won't find it that way.


Validation-Agreements should be applied and require waiver when Agreements present

Description of the new feature/enhancement
Since the Agreements URL needs to be reviewed by Microsoft, the pipelines should require a waiver before the PR can be accepted. The waivers will also act as a way to ensure the URLs for waivers are of a similar domain when new versions are submitted

[Policy] Area-Validation-Pipeline
[Policy] Area-Bots

This would depend on the waiver system being functional.


Issue 32 create profile page

Change Summary
Created profile page, switched <a> to <Link>
in navbar, created Nav title to display text in main page only, moved nav to layout
Change Form

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[x] The change has tests
[ x] The change has documentation

Other Information
Awaiting for colors PR to be done.

Awesome! Feel free to merge!


How do I Authorise for Android

Hello
I am unsure how to change the  file "unity-googledrive / NativePlugins / Android / GoogleDrivePlugin / src / com / studio272 / googledriveplugin / GoogleDrivePlugin.java"
to modify it so I can Authorise on Android?
Are you able to instruct me on how to change the line?
credential = GoogleAccountCredential.usingOAuth2(activity,
"https://www.googleapis.com/auth/drive.file",
"https://www.googleapis.com/auth/drive.appdata");
Thanking you in advance
Paul

I don't understand what you want clearly.
If you want more permissions, just add the permission strings to that credential = ... line. Or if you want modify the original java source code, modify the code as you want first, compile it to JAR library in Eclipse and replace the generated JAR file to the Unity plugin folder.
Thanks.

Sorry, not great at programming. I’m more of an artist who is not afraid to do some scripting
So before I go any further can I ask a few questions

Inside my Android app , can I authorise connection to the app data folder without choosing an account? So it uses the bundle ID of the app instead as authorisation, without displaying any extra pop-ups?
Can I directly download files bigger than 25MB without the Google drive virus scan?

Thanks for your quick response
Paul
From: Midworld Kim
Sent: Monday, April 10, 2017 8:19 PM
To: midworld/unity-googledrive
Cc: Paul Mitchell ; Author
Subject: Re: [midworld/unity-googledrive] How do I Authorise for Android (#20)
I don't understand what you want clearly.
If you want more permissions, just add the permission strings to that credential = ... line. Or if you want modify the original java source code, modify the code as you want first, compile it to JAR library in Eclipse and replace the generated JAR file to the Unity plugin folder.
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.8012 / Virus Database: 4769/14285 - Release Date: 04/10/17

i am sorry but i did not make this thread i dont know why this thread was
attached to me but i would like to know where this came from and what you
are talking about if you can contact me at this phone number<PHONE_NUMBER>)
if you cant or just dont want to contact me that way just contact me here.
On Mon, Apr 10, 2017 at 9:06 PM, Paul Mitchell<EMAIL_ADDRESS>wrote:

Sorry, not great at programming. I’m more of an artist who is not afraid
to do some scripting
So before I go any further can I ask a few questions

Inside my Android app , can I authorise connection to the app data
folder without choosing an account? So it uses the bundle ID of the app
instead as authorisation, without displaying any extra pop-ups?
Can I directly download files bigger than 25MB without the Google drive
virus scan?

Thanks for your quick response
Paul
From: Midworld Kim
Sent: Monday, April 10, 2017 8:19 PM
To: midworld/unity-googledrive
Cc: Paul Mitchell ; Author
Subject: Re: [midworld/unity-googledrive] How do I Authorise for Android
(#20)
I don't understand what you want clearly.
If you want more permissions, just add the permission strings to that
credential = ... line. Or if you want modify the original java source code,
modify the code as you want first, compile it to JAR library in Eclipse and
replace the generated JAR file to the Unity plugin folder.
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2016.0.8012 / Virus Database: 4769/14285 - Release Date: 04/10/17
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/midworld/unity-googledrive/issues/20#issuecomment-293136967,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZOJCL88my-Nh8YZIswF6HkbXBsO8NT6ks5ruu5CgaJpZM4M4YVK
.

Hi Pual,

if your android phone has multiple accounts in Settings>Accounts>Google, you cannot avoid the popup to select the account. Because the app doesn't know what account the user wants to use.
I've never tried to download files have more than 25MB. And there is no content of virus scanning on Google API doc(https://developers.google.com/drive/v3/web/manage-downloads). I think there is no problem about downloading big files.

I hope it will be helpful.
Thanks.

I am sorry but i asked when my account became part of this thread not what
accounts my android has and I also didn't how many MBs my phone can
download from so please get this tread off my account.
On Tue, Apr 11, 2017 at 1:39 PM, Midworld Kim<EMAIL_ADDRESS>wrote:

Hi Pual,

if your android phone has multiple accounts in
Settings>Accounts>Google, you cannot avoid the popup to select the account.
Because the app doesn't know what account the user wants to use.
I've never tried to download files have more than 25MB. And there
is no content of virus scanning on Google API doc(
https://developers.google.com/drive/v3/web/manage-downloads
https://developers.google.com/drive/v3/web/manage-downloads). I
think there is no problem about downloading big files.

I hope it will be helpful.
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/midworld/unity-googledrive/issues/20#issuecomment-293377624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZOJCIjR4r7hSm_02-GIdrL_XD6EtP6_ks5ru9b1gaJpZM4M4YVK
.

I am not even a github user
On Wed, Apr 12, 2017 at 2:23 PM, Ethan Elliott<EMAIL_ADDRESS>wrote:

I am sorry but i asked when my account became part of this thread not what
accounts my android has and I also didn't how many MBs my phone can
download from so please get this tread off my account.
On Tue, Apr 11, 2017 at 1:39 PM, Midworld Kim<EMAIL_ADDRESS>wrote:

Hi Pual,

if your android phone has multiple accounts in
Settings>Accounts>Google, you cannot avoid the popup to select the account.
Because the app doesn't know what account the user wants to use.
I've never tried to download files have more than 25MB. And there
is no content of virus scanning on Google API doc(
https://developers.google.com/drive/v3/web/manage-downloads
https://developers.google.com/drive/v3/web/manage-downloads). I
think there is no problem about downloading big files.

I hope it will be helpful.
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/midworld/unity-googledrive/issues/20#issuecomment-293377624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZOJCIjR4r7hSm_02-GIdrL_XD6EtP6_ks5ru9b1gaJpZM4M4YVK
.

so now i am deleting these messages from my gmail and i hope not to see
this popup here anymore goodbye
On Wed, Apr 12, 2017 at 2:24 PM, Ethan Elliott<EMAIL_ADDRESS>wrote:

I am not even a github user
On Wed, Apr 12, 2017 at 2:23 PM, Ethan Elliott<EMAIL_ADDRESS>wrote:

I am sorry but i asked when my account became part of this thread not
what accounts my android has and I also didn't how many MBs my phone can
download from so please get this tread off my account.
On Tue, Apr 11, 2017 at 1:39 PM, Midworld Kim<EMAIL_ADDRESS>wrote:

Hi Pual,

if your android phone has multiple accounts in
Settings>Accounts>Google, you cannot avoid the popup to select the account.
Because the app doesn't know what account the user wants to use.
I've never tried to download files have more than 25MB. And there
is no content of virus scanning on Google API doc(
https://developers.google.com/drive/v3/web/manage-downloads
https://developers.google.com/drive/v3/web/manage-downloads). I
think there is no problem about downloading big files.

I hope it will be helpful.
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/midworld/unity-googledrive/issues/20#issuecomment-293377624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZOJCIjR4r7hSm_02-GIdrL_XD6EtP6_ks5ru9b1gaJpZM4M4YVK
.


opposite conclusions

Hello, I have carefully read your paper and compared the DenseTNT metrics between the previous CVPR and the current ECCV experiments. I noticed that these two experiments seem to lead to almost completely opposite conclusions. Could you please explain why this happens and how to interpret this phenomenon?

Thank you for your interest in our work!! Yes your finding is correct. My suspicion is that:

Lack of hyperparameter sweep. Since in our ECCV work, we are now only considering the agents within the BEV perception range, it is theoretically a different experiment setting. But for convenience (and also time pressure), we reused most of the hyperparameters settings from our previous work. Theoretically, it is best to find a set of hyperparameters that show bev > uncertainty > baseline, but as soon as we found a setting such that bev shows a greater improvement %, we just decided to use that directly without any more finetuning.

Another tricky part with DenseTNT is that it was originally designed to use centerlines to sample goals. But in our case, we are using either dividers or boundaries to sample goals (not all the online mapping methods output centerlines). This would actually cause the trajectories to deviate towards the boundaries. This is also why you can see a huge reduction in displacement errors when using MapTRv2-CL. So technically DenseTNT is not really compatible with online mapping in the first place. We chose DenseTNT mainly because it is a classical example of GNN-based model and it has a nice codebase.

Please let me know if you have further questions!


Possible wrong error code shown in Symptoms

Hi,
In section symptoms there are two WinError error codes:
8467 or 8468
there is table under which states:

8467
21C7
ERROR_DS_SPN_VALUE_NOT_UNIQUE_IN_FOREST
The operation failed because SPN value provided for addition/modification is not unique forest-wide.

8648
21C8
ERROR_DS_UPN_VALUE_NOT_UNIQUE_IN_FOREST
The operation failed because UPN value provided for addition/modification is not unique forest-wide.

The error codes should be:
8647 for ERROR_DS_SPN_VALUE_NOT_UNIQUE_IN_FOREST and 8648 for ERROR_DS_UPN_VALUE_NOT_UNIQUE_IN_FOREST.
In the table the second one is correct but the SPN value mismatch error code is wrong.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4936a6c-23d8-fee8-4c3c-7913419d67e9
Version Independent ID: 240f2bff-801c-8310-33fc-28980813fcc6
Content: SPN and UPN uniqueness
Content Source: WindowsServerDocs/identity/ad-ds/manage/component-updates/SPN-and-UPN-uniqueness.md
Product: windows-server
Technology: ad-ds
GitHub Login: @iainfoulds
Microsoft Alias: daveba

opened PR #6170 to fix

Error corrected.


[Event Request] PAG 232 - additional parameters to OnBeforeCalcApplnAmount

Dear BaseApp team,
In our vertical solutions we impose a few limits on application of cust.ledger entries. Because of that, we need to set a filter on AppliedCustLedgEntry in the procedure CalcApplnAmount on page 232.
Easiest way is to expand the existing OnBeforeCalcApplnAmount event with some extra parameters.
Requested code:
procedure CalcApplnAmount()
begin
OnBeforeCalcApplnAmount(Rec, GenJnlLine, SalesHeader, AppliedCustLedgEntry, CalcType, ApplnType); //L365
...
New event signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeCalcApplnAmount(var CustLedgerEntry: Record "Cust. Ledger Entry"; var GenJournalLine: Record "Gen. Journal Line"; SalesHdr: Record "Sales Header"; ; VAR AppliedCLE: Record "Cust. Ledger Entry"; CalculationType: Option; ApplicationType: Option)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Updating pom.xml to consume iotdevicesdk 1.2.10 version from maven ce…

…ntral
Issue #, if available:
Fast follow on consuming iotdevicesdk from maven central
Description of changes:
Updating iotdevicesdk dependency to version 1.2.10
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Checklist:

[ ] Updated the README if applicable
[ ] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] Updated or added new end-to-end tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you use https://www.conventionalcommits.org/en/v1.0.0/ to write the commit message?


New package: Sentinel v0.1.1

Registering package: Sentinel
Repository: https://github.com/mhudecheck/Sentinel.jl
Created by: @mhudecheck
Version: v0.1.1
Commit: 7c8c9452fb7b3e8b0392b17354dab9858b15379d
Git reference: HEAD
Description: This is a Julia library for processing ESA Sentinel 2 satellite data.

Superseded by #49082, I suppose.
@mhudecheck note that if you do not change the version number every time, you update the same pull request instead of opening multiple times that then have to be closed.


Windows Linking Capability

Adding the .lib file produced in the building process it is possible to other python modules (like mine) to compile correctly including a spiceypy dependency.

Hello @TommasoPino! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file get_spice.py:

Line 384:81: E231 missing whitespace after ','

hey @TommasoPino, thanks for the contribution but I am a bit hesitant to merge this. The way spiceypy compiles a shared library is already a bit weird, and if your project wants to link against the static library for cspice you are probably better off directly using the .lib file contained in the cspice distribution (see https://naif.jpl.nasa.gov/pub/naif/toolkit//C/PC_Windows_VisualC_64bit/packages/dscriptn.txt). Plus, I don't know of many projects directly referencing binary files from other projects in this way. I would be willing to hear any detailed arguments supporting this change though.

Hello Andrew,
Actually the inclusion of this particularly .lib is not for a static library inclusion but to handle the dynamic library. I’m writing a python module that use deeply cspice inside c++ code and either from python side.
I correctly compiled my module using only the .lib produce by the .bat of you. And linked the cspice.dll without any effort because it is already inside your distribution (the only trick is to load your module before mine to ensure the presence inside the python pool of the cspice.dll)
I would like to avoid of compile the entire cspice library only to have this really small piece that your module already produce (but it is just ignored)
The entire process linux side is still perfectly working.
I hope to be clear and obviously I understand if you do not want that. I am already thinking some other workaround.
In conclusion I would like to directly thank you for this very useful module.
Have a nice day,
Tommaso

Il giorno 15 lug 2020, alle ore 13:45, Andrew Annex<EMAIL_ADDRESS>ha scritto:

hey @TommasoPino, thanks for the contribution but I am a bit hesitant to merge this. The way spiceypy compiles a shared library is already a bit weird, and if your project wants to link against the static library for cspice you are probably better off directly using the .lib file contained in the cspice distribution (see https://naif.jpl.nasa.gov/pub/naif/toolkit//C/PC_Windows_VisualC_64bit/packages/dscriptn.txt). Plus, I don't know of many projects directly referencing binary files from other projects in this way. I would be willing to hear any detailed arguments supporting this change though.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

hey Tommaso, so I think you are better off compiling/downloading cspice yourself potentially by using the offline installation mode spiceypy has (https://spiceypy.readthedocs.io/en/master/installation.html#offline-installation) which lets you provide a shared library for spiceypy to use at install time. Using that you could replicate the compilation side (the .lib file should be usable from the cspice distribution) but for windows I know it is really annoying to get all the visual studio tools working. That being said if you are already writing c++ code I think you would have everything you need. Alternatively you could also use the github actions/azure functionality to build cspice for you so you don't have to worry about compiling locally.

@TommasoPino I am planning on closing this pull request soon, I know it is relatively easy to support your use case within spiceypy but I don't think it is a good idea to do so in this way, and that your package should just use the offline installation mode so you can handle the compilation of spice yourself.


Feature: Custom Hooks

Custom hooks would be useful for plugin creators looking to extend an already existing plugin's functionality. For example, let's say I wanted to create a plugin that adds to (or modifies) the presets in unplugin-auto-import; I could use the "presets" hook to gain access to the presets map and modify it from there. Since webpack already allows plugins to create their own hooks, we can see some already existing use cases, like how the html-webpack-plugin lets other plugins modify the HTML output in various locations.
Proof of Concept
Here's a rough design of what the custom hooks API could look like.
Creating hooks:
import { createUnplugin, SyncHook } from 'unplugin';

import { SyncHook } from 'unplugin/hooks'; // Maybe even separate hook types into another import

export const unplugin = createUnplugin((options) => {
  return {
    name: 'unplugin-auto-import',

    hooks: {
      presets: SyncHook, // Define the hook
    },

    buildStart() {
      this.hooks.presets(currentPresets); // Run the hook
    },
  };
});

export const hooks = unplugin.hooks

Using hooks:
import { createUnplugin } from 'unplugin';

import UnpluginAutoImportHooks from 'unplugin-auto-import/hooks';

export const unplugin = createUnplugin((options) => {
  return {
    name: 'unplugin-auto-import-presets',

    // Use hook from another unplugin
    [ UnpluginAutoImportHooks.presets /* this is a symbol to ensure uniqueness */ ](presets) {
      presets['my-preset'] = '...';
      delete presets.react;
    },

  };
});

I personally would consider this a bit out-of-scope.
/cc @pi0 do you think this could have a valid use case using bookable?

I think this feature can be easily implemented by creating a hookable instance and register user provided hooks but also seems a nice idea to consider being built-in (can't think of any generic use case). On one hand, simple callback option can be also used for simpler usecases.

One way I think could be more generic is that we implement the Rollups' api props that basically allowing arbitrary objects to pass in, and let plugins define the interface (via bookable or plain values). https://rollupjs.org/guide/en/#inter-plugin-communication

That does seem like a better option, as it more closely follows Rollup's API.

@antfu, I have created a new proposal that includes your suggestions and follows closer to Rollup's API. I also included a method to create new plugin instances (if they do not already exist) (suggested in https://github.com/unjs/unplugin/issues/173).
Closing in favor of https://github.com/unjs/unplugin/issues/174.


Cheapest availability zone incorrect

Thanks for such a timesaving tool.  Being able to find prices across a number of regions is rather useful.  However I did notice that its suggestions on the cheapest zone seem to be incorrect, as per the output below ...
~/Downloads  awespottr p3.8xlarge
Checking spot prices for p3.8xlarge instance type.

AWS Zone                 Hourly Rate
------------------------ ------------
us-west-2b               $3.672000
us-west-2c               $3.672000
us-east-1f               $3.728000
us-east-1b               $3.736400
us-east-1a               $3.782400
eu-west-1a               $3.966000
eu-west-1c               $3.966000
us-east-2b               $5.262000
us-east-2a               $5.519800
ap-northeast-2a          $19.924000
ap-northeast-2c          $19.924000
ap-northeast-1a          $20.972000
ap-northeast-1c          $20.972000

Cheapest hourly rate for p3.8xlarge is $19.924000 in zone ap-northeast-2c

In this case I would have expected it to flag us-west-2b and us-west-2c as the cheapest zones.

@rasathus Thanks for the report. This is now fixed in v0.3.0.
The logic for finding the cheapest rate was doing a text comparison on the prices, so "10" was sorted before "3". This problem was less obvious with prices lower than 1.


solution created for Security Threat Essentials -- DO NOT MERGE AS THIS IS 1P SOLUTION

Change(s):
See guidance below
Reason for Change(s):
This PR is part of template spec solution migration for solution Security Threat Essentials.
See guidance below
Version Updated:
2.0.0
See guidance below
Testing Completed:
The link for test results is
Sentinel Solution Migration Security Threat Essentials
See guidance below
This is an 1P solution.

@v-sabiraj : Please merge it

Hi @v-sabiraj
Can you please get confirmation on this PR merging or closing and act accordingly.
Thanks

@v-sabiraj Please look into this.

Approving and merging as already approved.


Support for millisecond timestamps

Need support for date_field in milliseconds within 411. Able to execute successful searches, but unable to send result to 411 alert index in elasticsearch. Get mapper_parsing_exception and illegal_argument_exception on the alert_date field for Invalid format.

Should be fixed via e4df5965b30c0821a78bd0125c1d774b9a2327da. Define the new date_type attribute in your config file (check config_example.php for details).

Even if the date field in ES does not have a # or @?
I don't see in the changes the date field for the alert index being set to type epoch_millis so I'm confused if it using milliseconds or converting milliseconds to seconds.

Should be all resolved.