Strapi V4 support?

Will v4 be supported as it's the new stable version?

Hello @Lengo46 , yes, of course, in the coming days I will update the plugin, if of course it is needed

I checked the docs and similar plugins but couldn't find any answers. Plus, Strapi v4 itself still looks damp, and I would not recommend using it.
For now, I'll wait for the official documentation from the Strapi team to come out to find out what to do next.

They will be having a session about plugins migration to v4 today, I assume they will soon write about it as well (I hope)
https://twitter.com/strapijs/status/1468864266476441600?s=21

@BogDAAAMN
Yes, the article should definitely come out and I really look forward to it. I also follow the working plugins of other developers, hoping to see the implementation of the transition to version 4 from them.

EditorJS would be a great addition to v4

@philohelp yes, I agree with you.

@philohelp @BogDAAAMN @RicardormDev  @Lengo46
But at the moment I can't dedicate myself to developing a new version of the plugin for Strapi v4.
To be honest, I was close to porting the plugin to the new version, but the guys at Strapi have made their Front-end a little more complicated, which makes the porting process a bit more difficult at the moment.
At the moment I am busy with another project, if you have a desire to help in porting the plugin to a new version, I will be happy to tell you in which direction you should move and what problems I encountered during the port.

I would absolutely love to have this on v4 as well. I'm new to Strapi, but not EditorJS. I've been trying to get this working on v4. I've tried the plugin migration tool (which fails), and also tried following tutorials for other v4 editors, but to no avail. Unfortunately I've never worked with React, and just can't quite seem to figure out how to get this working. I've eventually gone back to Strapi v3 in order to use this, but it seems that Strapi is pushing very hard to move everyone over to v4.

@jaskipper i'm kind of in a similar situation and wondering if there is a guide on how to go back to v3 easily that you used, or will i have to setup a new project from scratch?

@opheliagame - I'm still in the process of setting things up from scratch, so I didn't migrate backwards. I just set up a v3 from scratch. Unfortunately I wouldn't know how to tell you how to migrate backwards.

@melishev - Good news. I've actually been able to migrate this over to version 4... somewhat. I have it working in a way that it is pulling up the interface, and I can add blocks. The Headers aren't styling, the link tool isn't working, and although I can pull up the image dialog, I can't add an image. But it is actually pulling up.
I've gone through the process of migrating the folder structure with the strapi codemods tool, I've updated dependencies, and had to change several things around. At this point, I'm not sure what I've changed and what I haven't. I'll keep fooling with it and will report back. Not sure what I would need to do to share the code back.

@melishev - I've now gotten styling working. At this point, the only items that don't work are the Link plugin and the Image plugin, from what I can tell.
Yes, you can absolutely see/have/edit the code. How would you like for me to share to you?

@melishev - Here's the code that I've been working on.  I'll see what I can do in the next few hours, and I'll be sure to post my results here.

@jaskipper  - How did you manage to solve the problem with headers?

@melishev - Good deal! Thanks!
Strapi v4 resets all styles, so I added the styles in directly to the Wysiwyg/wrapper.js file. I'm also going by examples that I see in other v4 plugins.
I just uploaded a commit that allows the routes to show up in Users & Permissions > Roles.
I think that the problem with the Link & Image plugins are that they are not showing up in the API. Been working on those a little this morning, but haven't found a fix yet.

Well, good news.
It seems that we are starting (or already finishing) work on porting the plugin to version 4 of Strapi.
I have just included the Semantic Release and Commitizen packages in the project, for convenient future management of the plugin publication.
@jaskipper , I got acquainted with your work and it is simply amazing, thanks for your contribution to the development of the project. In order for me to accept it and continue working on it, please follow the instructions below:

Fork or update your existing repository.
Correct your existing commit messages according to the Angular Convention Commits.
Create a PR for the beta branch so that I can accept your changes.

You may not like it all the way, but in the end it will make the package easier for both us developers and its consumers. If you have any questions, please email me.

@melishev - Yes, I'll do as you say and will create a PR for the beta branch so you can accept. I'll need to do that later this evening.
In continued news, I now have the Link tool working, although it's not showing the thumbnail correctly as of yet. I'll see if I can fix that before I finalize and send. So far, the image tool isn't working. I haven't had a chance to look into what the issue is with that though.

@jaskipper , @Lengo46 , @philohelp , @opheliagame , @BogDAAAMN
Well guys, I'm sorry to write you this here, but I have to report this.
I don’t know if you are aware of what is happening between Russia and Ukraine now, but as a resident of Russia I must report that we Russians do not want war, we don’t care at all about what is happening in the Donbass, Putin has driven us to such an ass that we we simply do not have time to solve our own problems and climb into other countries, this is absolutely not what the Russian people want.
I am 21, I was born at a time when Putin was already president. I don't think it's normal in your countries for a president to remain in office for 21 years in a row.
Now I can be forcibly taken into the army and sent to a hot spot.
And the coolest thing about all this is that I can’t even leave this country, because everyone automatically thinks that all Russian assholes, but this is not so.
The main purpose of this message - please do not confuse the Russians with Putin, we ourselves are tired of him.

@melishev - So sorry to hear about this. Thanks for the report, and I'm very sure that most Russians do not want what Putin wants. He absolutely doesn't define you. Yes, this situation is very sad. Praying for the safety of both Russians and those from Ukraine who have been drug into this... and for a quick resolution.

Thank you to share theses thoughts with us. This won't last forever - may the future bring wiser and more rational politicians. But since that moment, please be careful for yourself and the ones you care for.

@jaskipper , @Lengo46 , @philohelp , @opheliagame , @BogDAAAMN
Thank you.
I accepted the changes that NIC made. At the moment they are in the beta branch and we will continue to work on adapting the plugin.
If you are ready to test it, then you can download the beta version of the release using npm or yarn: https://www.npmjs.com/package/strapi-plugin-react-editorjs/v/2.0.0-beta.1
You can also read the beta information from NIC: https://github.com/melishev/strapi-plugin-react-editorjs/releases/tag/v2.0.0-beta.1

@melishev - Thanks. I hope to get some more work in this weekend. Let me know if you have any breakthroughs on the Image tool, as I know that you have a much better idea of what is going on there. I'll keep working on figuring it out. Where should conversations about different parts of the code occur? I use git for all of the development that I do, which is almost always my own work on private BitBucket repositories. However, I'm very new to collaboration. So definitely let me know how I should be doing things.

@jaskipper of course, no problem, you can contact me via Telegram, if you use it of course, this is the most convenient way for me.  We can also use email

@melishev - Ha, sorry! I meant where here on GitHub. Should we just continue the conversation here, should I open up new issues, or should I create pull requests and we discuss there? Just trying to learn the correct way of doing things.

@jaskipper - Well, there are no rules.
The most adequate option, as for me, is to decide on the tasks and draw up an issue for each of them.

@melishev - I just submitted another pull request with a fix for the Image tool. As far as I can tell, everything is working in normal start and develop modes. For some reason, the link tool doesn't work in develop --watch-admin mode. I get no console feedback as to why it isn't working in that mode.

@jaskipper - It already depends on the Strapi developers. As far as I remember, this launch mode did not work correctly before.

@melishev - In pull request #20, I have now completely updated every part of the code and the README instructions. Everything is working well in Strapi v4, and once merged, this can close many open issues, including this one.

#24
#22
#21
#16
#11
#5

This also addresses and adds fixes/features for several closed issues:

#13
#12
#10
#6

@melishev - In pull request #20, I have now completely updated every part of the code and the README instructions. Everything is working well in Strapi v4, and once merged, this can close many open issues, including this one.

Beta - Strapi v4: How to Customize Editor #24
Beta - Strapi v4: Collection of responsive URL's in Image Tool #22
Beta - Strapi v4: README updates #21
Get the size of an Image in Request #16
Strapi V4 support? #11
Image Tool: uploading failed because of ReferenceError: axios is not defined #5

This also addresses and adds fixes/features for several closed issues:

Inline link button is missing #13
Inline Link possible? #12
npm v8 is not supported #10
[Future Request] response not only a link to the original image, but also a collection with modified dimensions using strapi-plugin-responsive-image #6

Hey Jaskipper just wanted to swing by and say well done working on the port over to Strapi v4 :) Was testing this out earlier today and really liking the look and feel of it. Couple of rough edges I see but still very solid.
We have an open feature request (that I opened :laughing: ) about looking at alternatives for our default editor here for those interested in joining the convo: https://github.com/strapi/strapi/issues/12440

@derrickmehaffy - so cool! Love that you've opened that feature request with Strapi! Would love any feedback on what rough edges you are finding. I'm very new to the Strapi world, so this has been a great project to dive in and learn on.

Also, @derrickmehaffy. I don't know if you've realized this or not, but my latest changes have not been incorporated into the beta version. My latest changes are on the beta-v4 branch. Here's how you can use the latest changes.
The way you can use my latest changes would be the following:

If this plugin is already install via yarn or npm, uninstall:

yarn remove strapi-plugin-react-editorjs
# or
npm uninstall strapi-plugin-react-editorjs

Go to the ./src/plugins folder (create it if it doesn't exist) and clone the project:

# If you wish to clone the Master Branch
git clone https://github.com/melishev/strapi-plugin-react-editorjs.git
# If you wish to clone the Beta Branch
git clone --single-branch --branch beta-v4 https://github.com/jaskipper/strapi-plugin-react-editorjs.git

Go into the plugin and install dependencies:

cd strapi-plugin-react-editorjs
yarn install or npm install

In an editor add the following code into the main Strapi v4 ./config/plugins.js file (create the file if it doesn't exist)

module.exports = ({ env }) => ({
  // ...
  'react-editorjs': {
    enabled: true,
    resolve: './src/plugins/strapi-plugin-react-editorjs'
  },
  // ...
})

In order for Strapi to show the Link Tool thumbnails correctly, you will need to edit the 'strapi::security' line in ./config/middlewares.js. Change that line to the following (do this at your own risk).
module.exports = [
  // ...
  {
    name: 'strapi::security',
    config: {
      contentSecurityPolicy: {
        directives: {
          'img-src': ['*'],
        },
      }
    },
  },
  // ...
];

@melishev - Is there any way that we can get #20 merged to avoid all of the issues that users are having?

@jaskipper, @derrickmehaffy - Guys, thank you very much for your attention to the project
@jaskipper - Thank you so much for your contribution, I'm wildly ashamed that I can't get in touch in time.
At the moment I am in the stage of emigration from Russia, I hope you understand me, this is a really difficult process (documents, old work, new work). I promise to pay attention tomorrow, and most likely release a new update based on your code. Thank you for your input, I really appreciate it.

By the way, since my current salary has gone from $2,500 to $1,500, I'm looking for a new job, I'll be glad if you put in a good word for me with your bosses 😄

By the way, since my current salary has gone from $2,500 to $1,500, I'm looking for a new job, I'll be glad if you put in a good word for me with your bosses 😄

Ah sorry to hear about that, Strapi is constantly putting up new postings on our website https://strapi.io/jobs
Your in our hearts and minds 🫂

@melishev - Wow, definitely sorry to hear about that. I'm sure your life is crazy right now. Hope your emigration process goes quickly and smoothly. About the code, it appears that quite a few people are wanting to use it, so merging it tomorrow would be great! Of course, I'm using it personally, and at this point is working great for me... but making it easier for others to use would be awesome.

Yes, of course, my friend, I promise to do it today or tomorrow.  You did a great job, that's awesome.

By the way, since my current salary has gone from $2,500 to $1,500, I'm looking for a new job, I'll be glad if you put in a good word for me with your bosses 😄

Ah sorry to hear about that, Strapi is constantly putting up new postings on our website https://strapi.io/jobs
Your in our hearts and minds 🫂

Yes, that's cool, I looked at your vacancies.  But React is not my main work framework, I'm still more of a Vue developer.  Now I have a lot of work to do in terms of moving, paperwork, learning English (you need to practice speaking English properly), but in any case, it's very cool.  I think later, I can try)

@jaskipper @derrickmehaffy
In any case, I'm glad to hear from you, thank you for your understanding.  The Russian people are not to blame for this, and we ourselves do not want all this.  We have a lot of problems of our own.  It's just a shame that now most countries and people simply hate us because we were born in Russia

Well, as promised, I checked out the changes, most of them are related to styles. I left my answer in PR #20 . I'll take another look tomorrow!

@melishev Good deal. Yes, I've now made all of the requested changes. Let me know if anything else is needed!

@derrickmehaffy , @Lengo46 , @philohelp , @opheliagame
Well guys, the new version⚠ is ready and waiting. Thanks - @jaskipper

Awesome @melishev! Thank you!

💥 Well guys, I've released the beta to the official release.

Congratulations !

@melishev - Awesome!


Do Not Merge: Freebsd sandbox

POC of sandboxing the FreeBSD hvt tender with capsicum. Does not work on unpatched FreeBSD  because of this bug.
See #282

Thanks for this -- it's a good start. At this stage, I would prefer that you don't try and do module-specific sandboxing, i.e. work out the minimal set of calls needed for the "non-debug" case (i.e. core+net+blk) and do only that in hvt_drop_privileges().

@mato I agree - there should be two disjoint PRs, esp. since the drop privilege & chroot can be merged as is, whereas the capsicum bits should only be merged once there's a FreeBSD release where ppoll is capsicum-enabled. I appreciate @sg2342 work on capsicum and solo5-hvt, and will deploy this soon. :D

note: the FreeBSD changes have been MFC'ed https://github.com/freebsd/freebsd/commit/4c4449062f3855ce395a35e5b57636d5d768739e and will be part of the next 12 release (12.1, according to https://www.freebsd.org/releng/ there's not yet a schedule for 12.1)

See #282, this is now out of date (and will be even more soon).


Target only single bone at one time?

The issue I constantly run into is that at certain times more than one bone is being targeted causing the options from all of them to appear.
For example, in this image, a total of 3 bones are targeted - engine, left front wheel, right front wheel

This causes an extensive list of options to appear. Is it possible that in such cases only a single bone would be targeted and only its options displayed? Also noticed that a scrollbar appears when the list options is very long.
Preferably only the table marked red would be visible in this example

Reduce the distance for your options.

Reduce the distance for your options.

Yeah that worked, sorry for not figuring this out myself.
What about the scroll bar? Is this something that could be disabled when the list is long?


Signature attribute

Currently in specification we are missing proof or signature on the data structure so it should be something like:
{
   i: "did:1209u091u9012d/attestation/1234",  // SAI
   ti: "did:1209u091u9012d",
   s:
   [
        id: "attestationID1234", tid: "did:jd892j108jd1029", // attestation id not in namespace of testator
        id: "did:9d9j109j1d902dj19/attestation/3242",  // attestation id in namespace of testator
        id: "did:h78h8d2h8d2h8hd28d/attestation/1234"  // attestation id in namespace of testator
    ],
    x: {}, || SAI
    d:
    {
       k: v,
       k1: SAI,  // ref1
     }, || SAI
     r: {}  || SAI
 },
 signature: "d91j20dj129jd19-j2d-912jd912jd9-1j2-d901j2-0dj120jd120jd0"

We are looking at the proof format and how to attach it.  So yes we need a proof/signature but it shouldn’t be part of the AC/DC but an attachment  the new Waci  JWT effort is informative. We will have some more detail at our next meeting


Need a way to skip ‘.load’ when reset

If code causing stuck is in flash, need to avoid loading code from flash when reset or booting
Solution candidates to avoid loading code in flash

pressing BTN0 for a second after booting
Set some pin to HIGH when booting

The solution should be documented.

OK. Let me think about it

As we discussed, let me implement "pressing BTN0 for a second after booting"


refactor(Hyundai USA): create Hyundai start/stop engine API methods

I've changed the start/stop climate methods to more intuitive start/stop engine methods.
engine_control_action behaves similarly to lock_action - that is, whatever action is passed in is interpreted.
I wrote a test around this and the US Login, and both worked. I still need to test start_climate and stop_climate to ensure no regressions exist.
Vehicle used to test: 2020 Hyundai Santa Fe

Looks like the build failed due to my environment variables. Looking into it

I see that python-tests.yml is configured to use some defined secrets. I don't feel comfortable sharing my secrets here, so I'm commenting on the test for now.

Run black failed for something out of the reach of my code

Start_climate is named the way it is because it is used by EVs but the same endpoint works for ICE.  In both cases it's starting climate.   I do understand the confusion.
As a note the way it currently is created it would be a breaking change for usa since integration using this library expect start_climate to work for ICE and EV.

We could name it something more generic like VehicleManager.start(...) for both types of vehicles

You need climate parameters otherwise it will error out.    This depends on the country though.    If a strong desire to rename I am okay with this if done across the board in a refactor as a breaking change.    Seems like a alot of work considering impacts on others who use this too.  Could do something to keep support if needed.

I haven't forgotten about this PR. My ideal approach was not to introduce breaking changes immediately but rather to deprecate the climate methods and eventually kill them. This would give consumers of the API some time to update their code and not put unneeded stress on developers.

There are a lot of changes that need to be caught up - I'm going to start with a fresh fork.


Markdown support

Currently Atom Beautify displays an error, when opening a markdown file:

Unsupported language for grammar 'GitHub Markdown'.

It would be nice to have Atom Beautify normalize Markdown. That could be done using pandoc as suggested in another repo:
$ pandoc -f markdown -t markdown index.md

If you want to get rid of the pandoc dep, I wrote a markdown beautifier in pure JS: https://github.com/slang800/tidy-markdown (so it can be required via npm)

Awesome! Could you open an issue for this? I'd like to add support for tidy-markdown for Atom Beautify v1.0 :smiley:

gladly! ref: #292


cpu% high

Hi, too many RXComputationalScheduler threads are getting created and my application's cpu% is going high after using hystrix.
I am using this configuration
"groupName": "recsagservice", "threadPoolCoreSize": 5,
"cirBreakErrorThresPerc" : 50, "cirBreakReqVolThres":80, "cirBreakSleepTimeInMilliSec":72000 .
Please guide me what could be wrong here. I am attaching thread dump.
thread_hystrix.txt

The RXComputationalScheduler has nothing to do with Hystrix, it's a RxJava thread, and you will has 1 for each CPU you has in your machine, so you probably has an 8-core machine that's why you get 8 threads.
About your cpu% going high you will need to provide more information about what you are doing because on the thread dump there are only threads waiting, no threads doing particularly nothing and shouldn't consume your cpu as you say.

Hi,
Everytime my client method is called, I am just creating a new HystrixCommand object and calling its execute method.
I have not called any reset method . This client method frequency is  45k times in an hour.
This is how I am using hystrix:
            Setter group =    Setter.withGroupKey(HystrixCommandGroupKey.Factory.asKey("mygroup")).andCommandKey(HystrixCommandKey.Factory.asKey("myCommand")).andThreadPoolKey(                HystrixThreadPoolKey.Factory.asKey("myGroup")).andThreadPoolPropertiesDefaults(HystrixThreadPoolProperties.Setter().withCoreSize(5)).andCommandPropertiesDefaults(                HystrixCommandProperties.Setter().withCircuitBreakerErrorThresholdPercentage(50).withCircuitBreakerRequestVolumeThreshold(20).withCircuitBreakerSleepWindowInMilliseconds( 72000));

            HystrixExternalCommand myHystrixCommand = new HystrixCommand( group  );
             myresponse = myHystrixCommand.execute();

@ssakshi0302 i think you are misinterpreting the percentage value, this % is not the total amount of CPU used overall, it's the total usage from the overall, i think i'm not explaining it clear, i'll try to exemplify:
Let's say your code used 5% of your CPU, and looking at the table there it's saying 38% was spent on this method, so it's 38% from the 5%.
First, check in the General tab and see how the CPU was used, and after if it's really using too much CPU then you could check on the Code section.

Hi ,the average  cpu usage is 89.8%.  As shown in the earlier sceenshot ,
rx.internal.operators are accounting for 38% of this 89.8% and also if
wecalculate the total % by rx packages i.e (rx.internal.operators
,rx.subjects, rx.internal.util.unsafe, rx.observers) it will come around
(38.25 + 14.395 + 7.928 + 2.92 ) i.e  63.4% of 89.8%.
On Sat, Nov 19, 2016 at 1:02 AM, Kennedy Oliveira<EMAIL_ADDRESS>wrote:

@ssakshi0302 https://github.com/ssakshi0302 i think you are
misinterpreting the percentage value, this % is not the total amount of CPU
used overall, it's the total usage from the overall, i think i'm not
explaining it clear, i'll try to exemplify:
Let's say your code used 5% of your CPU, and looking at the table there
it's saying 38% was spent on this method, so it's 38% from the 5%.
First, check in the General tab and see how the CPU was used, and after
if it's really using too much CPU then you could check on the Code section.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/Hystrix/issues/1424#issuecomment-261620857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImAltd8SQzGJbnFZyUZ7jhaSJK40fuGks5q_f1YgaJpZM4K2s_L
.

@ssakshi0302 maybe i'm missing something, but i can't see your cpu average in the screenshot, you should be looking at:

Here it is :)

@ssakshi0302 now i see haha, thanks, this looks trick, what are you hystrix command doing? Executing some i/o task or something else?

Its just a simple microservice call to client . I am wondering if something is wrong with my metrics which is causing so . I am attaching memory screenshot also. You may find it useful.

@kennedyoliveira : Any clue on this?

@ssakshi0302 apologies for the delay, it's look trick to me, i'm not the best person to help with metrics, since i don't know the internals, @mattrjacobs can you help him with his doubt on it?
which hystrix version are you using?

Hey I am using version 1.5.3
On Sun, 20 Nov 2016 at 2:01 AM, Kennedy Oliveira<EMAIL_ADDRESS>wrote:

@ssakshi0302 https://github.com/ssakshi0302 apologies for the delay,
it's look trick to me, i'm not the best person to help with metrics, since
i don't know the internals, @mattrjacobs https://github.com/mattrjacobs
can you help him with his doubt on it?
which hystrix version are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/Hystrix/issues/1424#issuecomment-261737749,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImAlm3wBeD9BbbVEuhJSxhOLtmKzrdgks5q_1yWgaJpZM4K2s_L
.

@ssakshi0302 could you try to update to 1.5.8? I remember some weird problems in an old version, but i'm not sure if was about cpu performance.

@kennedyoliveira : Thanks Oliveira , I will change the version  but I wanted to understand why this could have occured and what does this stack indicate. Was it due to any flaw in  metrics ?

@mattrjacobs : Hi , What does the thread RxComputaionalScheduler do? Can you please help us  out here as we are facing production issues

@ssakshi0302 i don't know if there are flaw in the metrics, because i don't know how the metrics works inside, i mean the implementation details, matt will help you better with that.
About the RxComputationalScheduler, is a fixed size scheduler with total threads equal as total core cpus on your machine, intended to be used for doing computational tasks, it's from RxJava.
In your screenshot from the allocation tab, could you print the stacktrace all the way up? Because it shows the internal operators calls but not who called it, may give a hint.

@kennedyoliveira : Can you mention some email id , so that I can send flight recording itself.  It will help you analyse better.

Rx Computation threads are set up on any JVM which uses RxJava.  Since Hystrix uses RxJava, the threads get set up.  Within Hystrix they are used for metrics collection/aggregation, which happens in the background.  In our internal systems, we've never seen any performance issues from their usage.
In the attached thread dump, none of the RxComputation threads were busy, so that does not indicate over-usage of those threads.
Please attach a FlightRecorder trace to this issue and I can take a look.

stack.txt

That is a stack trace for what is allocation memory to TLABs.  From the rest of the discussion, I thought your concern was around CPU usage?
Can you please attach the entire jfr file?

Hey, I am not able to attach any jfr file in github, I would be able to
share that through email only. And i sent this memory allocation stack in
reponse to kennedy's comment. And yes, the concern here is cpu usage :)
On Mon, Nov 21, 2016 at 11:46 PM, Matt Jacobs<EMAIL_ADDRESS>wrote:

That is a stack trace for what is allocation memory to TLABs. From the
rest of the discussion, I thought your concern was around CPU usage?
Can you please attach the entire jfr file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/Hystrix/issues/1424#issuecomment-262021061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImAll8cgnCqXFmpsM8WKFru9E-0iaxQks5rAd_9gaJpZM4K2s_L
.

flight_recording_3002371128084_6 (copy).txt
@mattrjacobs : Hi ,
I am attaching jfr file as txt file . Please change the extension to jfr and try

@mattrjacobs :  Any update ?

I took a look through the JFR you attached, and it looks as you described.  A couple questions:

How many commands are in your system?
How many thread pools are in your system?
Have you changed any configuration from defaults (specifically around metrics)?

From my initial look, all of these code paths look valid, but it's not clear to me why they're taking as much CPU as they are.  That hasn't been the case for the production system I work on, nor in the jmh tests that ship with Hystrix.
Could you run the jmh tests and take a flight-recorder trace during these?

Closing due to inactivity


NuScenes Dataset

I think it would be valuable to the research community to support the NuScenes dataset (https://www.nuscenes.org/nuscenes). This is a relatively large real world multi camera driving dataset popular in many areas within computer vision. This type of dataset presents many interesting challenges (notably dynamic objects) and exciting applications.
I think it would be relatively straightforward to add a dataparser to support this dataset. I am happy to open a PR if there is interest?
cc @nikmo33

I think that would be a great addition. Feel free to create a PR.


Support providing root client ID via env. variables for testing

For "in memory" use cases allow the user to define the root client ID via environment variables. This is to simplify local testing.
The standalone bootstrap command and on-demand principal creation call paths still generate random IDs and secrets as before.
How Has This Been Tested?
Manual smoke tests.

I recall that @collado-mike and I discussed this as one option when bootstrapping, but I can't remember why we went with the current approach.
For my part, I would ideally like to see as little a difference in the UX of the different metastores as possible.

@eric-maynard :

I would ideally like to see as little a difference in the UX of the different metastores as possible.

Do you mean supporting the same overrides under the bootstrap command? I can certainly add that. WDYT?

[...]  I wonder if we aren't missing a simple and standard way to pass the root credentials to the boostrapping process.

My personal take on that is that the bootstrap command should either take root credentials as a parameters, or output the uniquely generated root credentials. I think we can support both options (e.g. as CLI arguments) and I'm willing to add that to this PR if other developers agree.

A few thoughts here.

For testing, I've found it generally sufficient just to use e.g. --access-token 'principal:root;realm:default-realm', so you shouldn't actually need root credentials in many cases unless you are testing a context resolver.
In general, I feel nervous about allowing the bootstrap process to use non-random credentials (even when supplied by the user). I am not a security expert but this seems insecure.
With respect to the bootstrap command printing the credentials to stdout, this was thought to be insecure. I remember now that this explicitly came up in my previous conversations with @collado-mike

@eric-maynard : thanks for sharing your views on this matter. Re: security of bootstrapping, I did not mean printing credentials to STDOUT. The "output" can be a file at a user-specified location. I think this is quite similar to downloading ssh certificates for a VM from a cloud vendor.
I wonder what options end users currently have for bootstrapping, though :thinking: How will a user be able to discover a generated root credential? (Apologies if I missed this in somewhere in docs).

I agree that we need to proceed carefully since it's a security-related issue.
I'd note, fwiw, that Keycloak allows to bootstrap the root credentials via environment variables.
I don't think we can suspect Keycloak of taking security lightly :-)
In another place of Keycloak docs, we can learn more about how the environment variables are processed:

If the initial administrator already exists and the environment variables are still present at startup, an error message stating the failed creation of the initial administrator is shown in the logs. Keycloak ignores the values and starts up correctly.

Couldn't we do something similar to that?

The "output" can be a file at a user-specified location.

If we go down this route, maybe check that the file permissions are as restrictive as possible.

 You normally don't need the root credentials.

I could use principal:root;realm:default-realm as an access token, but I happen to need to use the client credentials auth flow, which currently uses random values for the root user. Discovering the random credentials currently involves scanning Polaris STDOUT, which is inconvenient. I'd like to have control over the inputs I provide to Polaris.
So this PR proposes to make this an option for the user to define the root credential if the user so chooses. I think it could be convenient for other people too.
As for the general bootstrapping case, the above discussion is interesting, but maybe we can continue that on the dev list or separate PR. As for this PR, do you think the idea of allowing user overrides for root credentials is reasonable give that it only applies to the "test" authentication implementation, which is already not "secret" given the fixed root token?

I see. If you want to test the auth flow and you can't call bootstrapRealms then I can see how the current bootstrap process is not great.
Could you call rotatePrincipalSecrets using the passwordless auth to receive new credentials?
Barring that, I am open to allowing the user to set the credentials using an env variable for the in-memory metastore.

It is a fairly common and accepted practice to generate random secrets during bootstrapping - e.g., terraform has built-in support for this - https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password . Allowing Terraform to randomly generate a password, bootstrap Polaris, and stick the secrets in Vault or k8s secrets is a very secure pattern and something I think we ought to support.

It is a fairly common and accepted practice to generate random secrets during bootstrapping [..]

And I'd note that that is the usual pattern that most Helm charts adopt when bootstrapping things like databases.

SGTM, based on the above discussion, I think I'll extend the env. variables support to the normal bootstrap command too.

I believe that after #438 but without this PR it is not really possible to bootstrap Polaris with EclipseLink... I do not see a way to discover the auto-generated root secret :thinking: ;)

+1 @dimas-b, I think this is a partial fix for that problem. However we probably shouldn't allow bootstrapping without specifying credentials if the intent is that users can retrieve secrets from the metastore but we no longer put them in the metastore.
I still think we can merge this as-is and follow up with that potential restriction.
Other possibilities:

Make EclipseLink boostrap print secrets like in-memory bootstrap does
Make it so that we persist plaintext secrets for primary secrets but not secondary secrets
Hack #438 so that (2) applies only to root's first-time secret, and enforce rotation on root

Any preferences @dimas-b / @collado-mike ?

My preference would be to keep the env. variables for root password bootstrapping, plus add CLI options to the bootstrap command to print the auto-generated password to STDOUT, but only at user's request.
By the way, I'm rebasing this PR to resolve conflicts... will probably squash too.

plus add CLI options to the bootstrap command to print the auto-generated password to STDOUT, but only at user's request.

I like this idea, and I can do this -- but do you think we should fail the bootstrap if

The env variables are not set
credential printing is disabled?

In this case the metastore is pretty much bricked, so I think we should not proceed with the bootstrap.

but do you think we should fail the bootstrap if
The env variables are not set
credential printing is disabled? [...]

SGTM :+1:

@collado-mike : are you ok to merge?


⚠ AVS (kty) has degraded performance

In 9e9babb, AVS (kty) (https://avus.com.br) experienced degraded performance:

HTTP code: 200
Response time: 12357 ms

Resolved: AVS (kty) performance has improved in 788a705.


Capybara 2.5.0 is not supported

Capybara 2.5.0 has just been released with several new features that could be excellent to use with Capybara-webkit. However, this project's Gemspec is locked to '< 2.5.0' which limits adoption of the new Capybara as Bundler cannot manage conflicting dependencies.
(Okay so I'm in real need of one of the 2.5.0 changes to solve an issue I have, so I'll have a go at getting a PR in for the upgrade, but it looks like master has red tests right now so I'm not confident in my changes just yet.)

sorry for 2 PR, the first was from removed branch
I think that we should not introduce max capybara gem version for a latest version of this gem.

Closing in favor of https://github.com/thoughtbot/capybara-webkit/tree/capybara-2.5. We'll release a new gem once the tests pass. Thanks for your PR!

Released capybara-webkit 1.7.0 to address this. Thanks!


Core Schema Typescript Library

Initial work on the core-schema-js library. We can now:

bootstrap a schema — find its @core(using:core) directive, which may be renamed, and find all the specs it references.
extract specified metadata, based on its spec url. This handles all the naming logic.
ask questions like, "is this node in the export schema?" and "what is the parent of this node?"
derive an export schema from a core schema, stripping away all machinery and respecting @core(export:) directives.

I wrote a bit more in the README, which I will paste here too:
Code Overview

__tests__/ has tests (not enough yet)
serde/ contains serializers and deserializers for data in the AST. This converts between AST nodes
and arbitrary TypeScript objects (typically scalars and plain objects though). The SerDe module doesn't
know anything about specs or namespaces, it just knows how to extract data from the AST in a particular
shape.
bind/ contains the data binding layer. This is where we bind specified metadata in the AST
to TypeScript objects. Functions in the bind layer take a spec, and the first thing they do when
queried is to look up the name of that spec within the document and use it to filter their metadata
sources (which are all directives at this point, but not forever). You can see an example of
the binding layer in action in the binding for the core spec.
schema.ts contains bootstrapping logic and fromSource, which quickly generates a pipeline for processing a DocumentNode.
data.ts defines data and derive. These define additional "columns" on AST Nodes (or really, on any JS object whatsoever). We use them frequently to annotate the AST with additional information, including up-tree links (to the parent and document) and parsed metadata. This just creates a symbol and looks it up on the object, but those implementation details are hidden. You can call set(object, someData, value) to set someData on object to value, and get(object, someData) or someData(object) to get the value on the object. You cannot set derived values. They are cached on the object, but are read-only.

Conventions

Deserializers are expected to fail with some frequency. Errors are somewhat expensive to create. Also, it is frequently desirable to process e.g. all items in a list (even after one has failed to deserialize)—this ensures that we discover and surface all document issues, beyond the one failure. Thus, rather than creating Errors for every single validation error, deserializers return Results, which are either Ok<T> or Err. Errs are not Errors—they are small objects, and do not collect a stack on creation. You can call .toError() on an Err to create an actual JS error with a stack trace.
All errors which can occur on the document are declared with ERR. This returns an Err creator
function.
Some types are named like this: type Set_TypeOf<S extends Set> = .... This convention indicates that the type is a "type function" which extracts the TypeOf a Set.

PTAL. I've removed directive forms, which simplifies the directive logic a lot. I've also moved the scanning logic into its own module. The result of scaning a node for a directive is now an array of SpecifiedData, which is a type tagged with the spec URL and directive name, distinguishing different kinds of metadata in a clear and type-friendly way.
I think the separation will make it easier to specify these things using GraphQLDirective, GraphQLInput, etc, though tbh I'm still struggling to see how that'll work or why we want to do it. Anyway, take a look at what's there, and I'll take another crack at changing the definition layer to GraphQLDirective, GraphQLScalar, GraphQLInput, etc. Though honestly, if someone who understands the objection better wanted to take a crack at that, that would be fine too.

I think the separation will make it easier to specify these things using GraphQLDirective, GraphQLInput, etc, though tbh I'm still struggling to see how that'll work or why we want to do it. Anyway, take a look at what's there, and I'll take another crack at changing the definition layer to GraphQLDirective, GraphQLScalar, GraphQLInput, etc. Though honestly, if someone who understands the objection better wanted to take a crack at that, that would be fine too.

I'd love to find a way to help here, but to be honest I still don't fully understand what the current code is doing (and why it is doing that).
My understanding is that the main goal of this library is to extract spec-specific data from parsed ASTNodes. That involves finding relevant DirectiveNodes (based on the local name of the spec in the current document, as specified using @core) and extracting their argument values.
What I'm unsure about is why that requires SerDe and the rest of the binding machinery. This may be naive, but couldn't we just rely on GraphQLDirective (either constructed through code or parsed from SDL) and use graphql-js's getArgumentValues() to extract argument values (which takes care of type checking and makes sure required values are provided)?
We could then write manual TypeScript definitions for the extracted values, which honestly seems like a fine solution (this basically reiterates the point @glasser makes in https://github.com/apollographql/core-schema-js/pull/2#discussion_r575740887).
A missing piece here might be local namespace support, but it seems we could get that by modifying names in GraphQLDirectives based on the spec definitions in the document. Or maybe we need a modified version of getArgumentValues() that is aware of name mappings.
I could very well be simplifying this too much, but if that is the case it would be really helpful to get a better understanding of the additional use cases we're trying to support with this.

Ah, see, I didn't know about getArgumentValues(). "You should use getArgumentValues() here" is actionable feedback that I can implement! Similarly for the Source stuff.
(I went looking for both of these, but I find graphql-js's documentation… pretty hard to navigate)

Ah, see, I didn't know about getArgumentValues(). "You should use getArgumentValues() here" is actionable feedback that I can implement! Similarly for the Source stuff.

Good to hear! I just noticed getArgumentValues() is marked @internal, which doesn't stop you from using it but would require a deep import. The related getDirectiveValues() does seem to be part of the public API, and it calls into getArgumentValues(). If neither works, you could also copy/adapt the code from getArgumentValues(). What is important here I think is that we can treat GraphQLDirective as the source of truth for the directive definition, including the argument typing information.

(I went looking for both of these, but I find graphql-js's documentation… pretty hard to navigate)

Yeah, there is no comprehensive documentation to speak of unfortunately. The stuff at https://graphql.org/graphql-js/ is incomplete and out of date. But the source is pretty well organized, with sensibly named functions and inline documentation. It may require some digging, but I find graphql-js generally has the functions I need or at least shows me a way of approaching something.

Administrative note: This PR is "merged" because the PR that superseded it (#3) was finished, approved and merged in as a true Git merge (not a squash).  Since this PRs ab6c7b6 was included in that PR / its root, this PR is effectively merged even though there was heaps of follow up.
(Fwiw, I might suggest a rebase or a squash in the future given how much of this PR was reverted, but not asking for any change.)

damnit i really thought i'd squashed it
On Mon, Aug 2, 2021 at 8:05 AM Jesse Rosenberger @.***>
wrote:

Administrative note: This PR is "merged" because the PR that superseded it
(#3 https://github.com/apollographql/core-schema-js/pull/3) was
finished, approved and merged in as a true Git merge (not a squash). Since
this PRs ab6c7b6
https://github.com/apollographql/core-schema-js/commit/ab6c7b6d2c84cd9fe5a774f64bf662f508310d18
was included in that PR / its root, this PR is effectively merged even
though there was heaps of follow up.
(Fwiw, I might suggest a rebase or a squash in the future given how much
of this PR was reverted, but not asking for any change.)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/core-schema-js/pull/2#issuecomment-890970433,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3HLTVCAG5UYJ2TCRDHKE3T22CXHANCNFSM4XLY2VWQ
.

@queerviolet All good!  I could conceivably still "fix" that if I move this into the federation repository.)


Update index.js

this.props.style override complete Style

Coverage decreased (-1.1%) to 98.889% when pulling 67a1c9c3ce27a502f67f31e393337cd500b2cd97 on marcelglaeser:patch-1 into 5b9f60cca7ad06936b94d1dd277e91cbbc68a601 on xgfe:master.

I'm sorry I can't approve this radical refactor. What's the point troubling you?

Its make the bundle more customizable.


DNM: Test ipv6 lane

Signed-off-by: Quique Llorente<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Takes more than 7h so it timeouts, let's just skip stuff for now and see if it fits at 7h window.

/test pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6


ci: Split dev version publishing into separate CI job

Closes #59
New job should only be triggered manually to avoid unnecessary build time and potentially conflicting dev package version numbers.
Note: It looks like in order to properly test the manual workflow dispatching, we'll actually have to merge this so the workflow will be available from the Actions tab.

Btw, I've just now tested this, and I'm able to manually trigger the workflow on any given branch now that this has been merged.


Bringing back the Cinnamon Target?

Would it be possible to bring back the Cinnamon Target now that there are stable PPAS for Ubuntu 12.04 and 14.04?
http://www.webupd8.org/2014/06/new-cinnamon-stable-ubuntu-ppas-ubuntu.html
I looked into adding a Cinnamon Target but I don't really know what I'm doing, so wondered if the PPA could just be replaced with Tsvetko's repository in the old Target.
Sorry if this issue has already been covered but I was unable to find any mention of it.

:+1:  for Mint/Cinnamon support!


Expose a function to only get the QRCode with the swiss cross

Greetings !
Could you add the possibility to generate an SVG with the QRCode only ?
I would need to have that to display it in a web page without all the other informations  😊

I have seen other libraries in other programming languages support this, and my personal opinion is that this could have legitimate applications in real life and I think the recognition value as a QR-Bill is still provided by the swiss cross in the center.
But I don't want to add this as a feature, because I am pretty sure that this doesn't comply with the specifications and violates the design guidelines of the QR-Bill.
However, it may already be possible in a hacky way: https://github.com/schoero/SwissQRBill/discussions/374, jsfiddle
Let me know if that works for you.

Thanks for the quick answer !
It's working perfectly 💪


Onclick Row Funtion

Any Onclick row function available in react treegrid ? Please assist how to implement.
This is my treegrid component, but onRowClick is not working
<TreeGrid
data={this.state.data}
options={{
fields,
onRowClick : this.onClickRowDetails,
}}
/>

I made this change in my own fork, sadly I couldnt create branch to make PR for original codebase. Doesnt look owner still working on the project. I'd be happy to merge this change to original master

Let's fork, and continue development. I am thinking of adding resizable columns compatibility


Add option to homogenize pfps

I mean an option in which you can choose all pfps to be circles or to be squares, ending with the current situation with pfp using both styles.

If my experience with Twitter Blue checks is anything to go by, this would be too minor a feature to be worth the effort and subsequent maintenance it would take to handle it everywhere pfps can appear in the app


Fix #52: Build on Windows

This PR removes any implicit type conversions that MSVC warns about and other MSVC specific CRT security warnings. It also uses the new WINDOWS_EXPORT_ALL_SYMBOLS target property for the export of all symbols when building the libraries as DLLs. Global and static data members are exported using the MIRTK_<Module>_EXPORT macro added by the GenerateExportHeader module of CMake BASIS (fixed CMake module which is committed upstream and will be part of CMake 3.6).

Fixes also #17.

Includes new FindTBB module (see #140).

Includes new FindFLANN module (see #141) which is used to look specifically for the static C++ library.


Errors when trying to run

I'm running this on Manjaru Linux.
It appeared to  install correctly.
I got some of the data at the top of the browser screen - account value, portfolio value etc...
But followed by some errors - see below.
Any ideas?
John
ValueError: Wedge sizes 'x' must be non negative values
Traceback:
File "/home/john/.local/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 535, in _run_script
exec(code, module.dict)
File "/JohnsMounts/PDevelopmentB/Trading212API/trading212-portfolio-dashboard/src/dashboard.py", line 107, in
all_pie = pplts.fig_all_pie(positions_df, balances['cash'], balances['current_p_and_l'])
File "/JohnsMounts/PDevelopmentB/Trading212API/trading212-portfolio-dashboard/src/plots/position_plots.py", line 52, in fig_all_pie
_, _, autotexts = plt.pie(final_df['amount_invested'],
File "/home/john/.local/lib/python3.10/site-packages/matplotlib/pyplot.py", line 3543, in pie
return gca().pie(
File "/home/john/.local/lib/python3.10/site-packages/matplotlib/init.py", line 1465, in inner
return func(ax, *map(sanitize_sequence, args), **kwargs)
File "/home/john/.local/lib/python3.10/site-packages/matplotlib/axes/_axes.py", line 3224, in pie
raise ValueError("Wedge sizes 'x' must be non negative values")

Further observation. Could be because my P/L is negative?

Commenting out lines dashboard.py lines 106,107 and 108 and it sort of works.
Observation. Doesn't treat UK stocks the same as US stocks?

Thanks for the comments! I will try to resolve the issues asap

Thanks for getting back to me.
I am happy to test the UK stocks if you suggest a fix.
Kind Regards
John


Export-DbaScript - Invoke .Script() as a workaround while exporting Availability Groups

Type of Change

[x] Bug fix (non-breaking change, fixes #5913 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

I dig it, thank you 👍🏼


Bold timescale values are not always correct and there is no option to turn this functionality off

Lightweight Charts™ Version: 4.1.0
Automatic bold texts are sometimes not working very well on timescale (x axis). If this feature could be disabled, it would be nice.
Good example (month-day):

Bugs (year-month):

We are in GMT+2 timezone, so I am converting datetimes to UTC to pass to the chart, later I use timeFormatter to display them in correct time zone. If I'm not doing this I also have issues with bold texts (HH:mm - 00:00 - not bolded vs 02:00 - bolded). In bugs section on second screenshot you can see that first 2 bold texts are correct, the last one is not. Data is the same for all 3 texts: HH:mm = 00:00.
The best would be an option to turn this functionality off, because it's not always needed.
I saw that you closed this request, but it would be a good feature to disable bold texts to ignore unwanted bugs: https://github.com/tradingview/lightweight-charts/issues/545

Lets break this into 2 separate topics:

Ability to disable bold text on the timescale.
Bug: Incorrect tick mark has been made bold.

1. Option to disable bold text for tick marks in the timescale
This seems like a reasonable request.

2. Incorrect tick mark has been made bold
It would seem that the correct tick mark is being made bold, but the formatted text is incorrect.
Could you please share the data you've used for this example? Or even better, a small reproducible example on a site like jsFiddle / code sandbox?
My initial thought is that the code you are using to handle the GMT+2 timezone difference (the formatter) might have a slight bug in it. Perhaps you are subtracting by a fixed amount of milliseconds instead of using the browser APIs for this. Something as strange as the few leap milliseconds that are added/remove at the end of each year might be causing this problem.

@SlicedSilver thank you for your answer.
You were right, I used date-fns to parse and modify the timestamp and this solution was buggy. I discovered this bug while I was creating JSFiddle to visualize my chart.
Anyway, here is the JSFiddle for others (if anyone experience the same issue): https://jsfiddle.net/egym7w6r/
If you uncomment the marked 2 lines, then you can see the bug.
Now I replaced the parser with native browser API, thanks for pointing out the problem.
For option 1: I think it will be still helpful if we can disable bold text on timescale. So from now, it is a feature request instead of a bug report.

Great. I'll leave the issue open for the bold option feature request.
With regards to the browser APIs, it is often easy to use the setHours method to modify a date to be exactly at midnight (in the current timezone).
const d = new Date();
d.setHours(0, 0, 0);

It works with negative numbers as well, so something like this can go 2 hours backwards:
const d = new Date();
d.setHours(d.getHours() - 2);
// or
d.setMinutes(d.getMinutes() - 120);

@ingria Could you describe which font settings you would like to customise? Is it just the weight of the font used for bold text?

+1 for the option to disable bold font. I was wondered why this "feature" even exists as it just distracts attention

@SlicedSilver in my case customizing just the weight would be enough, but customizable color and size would also be useful.


can't detect Wercker.

Codecov
(version) cd5c049
(url) https://codecov.io
==> No CI detected, using git for branch and commit sha.

Wercker Steps - setup enviroment
http://devcenter.wercker.com/docs/environment-variables/available-env-vars.html
 export CI="true" // not True

codecov-bash
elif [ "$CI" = "True" ] && [ "$WERCKER_GIT_BRANCH" != "" ];
then
  say "==> Wercker CI detected."
  # http://devcenter.wercker.com/articles/steps/variables.html
  query="service=wercker\
         &branch=$WERCKER_GIT_BRANCH\
         &build=$WERCKER_MAIN_PIPELINE_STARTED\
         &slug=$WERCKER_GIT_OWNER/$WERCKER_GIT_REPOSITORY\
         &commit=$WERCKER_GIT_COMMIT"

wercker.yml
 export CI="True" // add this line; working properly
 bash <(curl -s https://codecov.io/bash)

Hey @amondnet thank you for bringing this to my attention. I wonder if they changed the CI value from True to true which threw this off. Thank you :)


Compile check not displaying errors

Even when there are clear errors in the sketch, the return message at the bottom banner still reports that the check was successful from the Arduino IDE.

If you are running ardublockly under windows, are you sure it is pointing to the arduino_debug.exe file and not the arduino.exe?

I know I had the "compiler location" under Edit>Preferences set to the arduino.exe.  I am not sure that is where you meant, but I found in re-running from the ardublockly_run.bat file, I cannot change the compiler location and sketch folder for some reason.  I tried modifying the "ServerCompilerSettings.ini" to the arduion_debug.exe, and now it says "Please select a valid Arduino compiler directory" form within settings.  Did I make a booboo?

Oh, for some reason it was resetting the files to default.
I noticed it was popping up the file window under the ardublockly app when I was trying to set the compiler location.
Now, with the arduino uno still plugged in, it keeps the settings.
The uploading and checking seem to work OK.  The open in arduino IDE was really slow the first time and locked up.  After closing with task manager and restarting, it seems to work.
Too bad arduino IDE takes long to load in general.  I have noticed It adds a lot of lag on older machines, and could give the user the impression your app may be hanging when it is simply waiting on the IDE.
Thanks.

Make sure you are running version 1.5 or higher of the Arduino IDE as well, ideally the latest one available (currently at 1.6.7).
One current issue with selecting the "arduino compiler location" and the "sketch folder" is that the file browser windows sometimes opens in the background and it is not clear that they have been opened. See if that might have been your problem when trying to select a different location using the settings.
As a general note, the ardublockly_run.bat basically executes the ardublockly.exe file within the 'arduexec' folder

Too bad arduino IDE takes long to load in general. I have noticed It adds a lot of lag on older machines, and could give the user the impression your app may be hanging when it is simply waiting on the IDE.

Yes, this is definitely a bit of an issue. Technically, the spinning wheel should indicate that the IDE is still compiling/uploading, but as you said, it can take an excessive amount of time with some machines.
The are currently two possible improvements that can be done, to maintain temporary files between compilations, or to move from the IDE CLI to the more efficient Arduino builder CLI (but with this second route I am not sure what options are available to upload the compiled program).

Looks like this issue can be closed then, however because the "not using the arduino_debug.exe" issue might pop a few time I'll leave this open until I implement a check on the server side.
So what I'll probably do, is if a user selects an "arduino.exe" file for the compiler, it will automatically check if an "arduino_debug.exe" exists on the same directly and use that instead.

Ok. It does seem to work proper now.
You may want to change the instructions you made for setup at:
https://github.com/carlosperate/ardublockly/wiki/Arduino-Compiler-Settings
It was from there that I chose to use the arduino.exe file.  Or, you could just leave the setting as what I was expecting when the field is "Compiler location," where the input is merely the folder, not the file.

Thanks for the letting me know about the instructions, I've updated that line.
 Please feel free to update it if you find any incorrect information or you'd like to help me improve the, rather limited, documentation. Any contribution will be really appreciated!

Oh, and about setting only the IDE directory instead of selecting the file, that's a good idea, although I'll have to look into how it would be done in OS X, as it can be a bit confusing taking in consideration that .app bundles are basically just folders.

When I was running 1.6.5 yesterday it was working, now upgraded to 1.6.7 and it does not appear to receive IDE output again.  I reset the compiler location and have a fresh install of both ardublockly and arduino.  Confirmed I am pointing to the arduino_debug.exe.
My current work around is to either send to the IDE, or revert back to 1.6.5.  Otherwise, ardublockly hangs in a wait without ability to send out again.

I'll try to test this tonight with 1.6.7

I was able to try 1.6.7 with Ardublockly and had no issues under Windows 10 x64, with the zip version of the Arduino IDE. Could you give me a bit more information about the system you are using?

I am running from the windows installer version of 1.6.7 on win 7 64 pro and home.  Both machines have problems.  My pro just hangs "waiting for the IDE output" when checking or sending direct to arduino after it does load the program properly.  My home machine works ok maybe the first time or so, then does the similar thing.  Really has a hard time if there is a problem with the sketch.

Having the issues only after a successful load can be the key here, I'll try again once I get a chance tomorrow night.

Few more results on this issue...
I tried using the non admin arduino zip 1.6.7 and found same results under Win 7 64b pro as with the arduino under windows installation.
Arduino zip 1.6.6 also had same.  Both 1.6.6 and 1.6.7 will open in IDE just fine, check does not return response from IDE, and upload will upload without a final response from IDE as well.
However, 1.6.5 r5 both zip and windows installation work entirely.

This may be further expanding whatever error I am experience with compatibility of the newer arduino IDE.
When using either the standalone or the browser interface of the latest build, arduino 1.6.7 gives the following error when verifying the blink example:
Unexpected exit error code: 255
Loading configuration...
Initializing packages...
java.lang.NullPointerException
at cc.arduino.contributions.packages.ContributionsIndexer.mergeContributions(ContributionsIndexer.java:119)
at cc.arduino.contributions.packages.ContributionsIndexer.parseIndex(ContributionsIndexer.java:91)
at processing.app.BaseNoGui.initPackages(BaseNoGui.java:597)
at processing.app.Base.(Base.java:295)
at processing.app.Base.guardedMain(Base.java:222)
at processing.app.Base.main(Base.java:136)

That kind of looks like an error with the board manager. A long shot, but do you experience this issue only when the system is not connected to the internet?

That is connected to internet, no board connected.  I need to check what board was selected.  May have been the default.
Carlos<EMAIL_ADDRESS>wrote:

That kind of looks like an error with the board manager. A long shot, but do you experience this issue only when the system is not connected to the internet?
—
Reply to this email directly or view it on GitHub.￼

I've been using 1.6.7 last week under Windows 10 x64 and was not really able to replicate this issue.
In the computer where you are seeing this, have you installed any additional boards and/or libraries using the board or the library manager? Even if you have uninstalled, reinstalled, or used the zip Arduino IDE versions.

I was thinking about the libraries, but not the boards.  I have two systems acting the same, one with extra boards installed (adafruit and sparkfun), and one without.
Both systems have started to refuse opening 1.6.7 altogether (splash screen then nothing).  Even outside of ardublockly.  I have seen others with the issue, but not a solution.  It seems it may be related.
As for libraries, I have numerous, some of which are experimental.
As a controlled test, I ran from the zip ide under a vmware virtual machine win764b, and it ran fine.  It created the arduino sketch folder and ran like it should.
I then went back to my regular system, renamed my arduino sketch/library folder, and tried to run.  It created the sketch folder, but never started 1.6.7.  Same for 1.6.6.  When I reverted to 1.6.5r2 it ran fine again.
I do not know what all is rattling the system, but my guess is it is not ardublockly or my libraries.
For fun, I also tried disabling my AVG anti virus, still not luck.

There is a chance it could be caused by a malformed board or library package: http://forum.arduino.cc/index.php?topic=321711.0
The Arduino IDE creates user data folders on the system which it would still grab even if you upgrade, maybe version 1.6.5 doesn't parse some of the data in these folders. It would be worth having a google search to find out where exactly were all of these data files are saved (probably in you user AppData\Local\Arduino15 apart from the Arduino folder in my documents, but there might be more locations), and delete them to see if the problems are still present.

Carlos,
I cleaned out the arduino IDE, and all the arduino15 from my system and have had better with the newer versions, but I am still having trouble with no response  when there is a compile error.  Have you had any luck reproducing this problem on your end?

I haven't seen this issue, but it might be because I haven't been using the loading sketches feature too much.
Is this the same error you were describing before? Is it happening always or is it interminent? Sounds like the main problem you have right now is to do with displaying compile errors (telling you it's compiled correctly)? Could it be relaeted to https://github.com/carlosperate/ardublockly/issues/59 ?
Would you mind opening a new issue indicating the steps and outputs you experience? (also things like Ardublockly version, if running the desktop app or just the python server, operating system, and all that) This github issue is currently open as a reminder for me to add a check for arduino_debug.exe, and if we discuss things here, things will get mixed up, and I accidentaly overlook this.

It seems to be the same issue as before.  And yes, it does seem related to #59.  I have not tried sending the sketch to the board lately, but the problem seems to be persistent when there is a sketch with compile  errors.  When you check a good sketch, it does receive the all clear response and act as expected.
I am running "ardublockly_Windows32_2016-04-09_00.35_master_1ad1e" in win7 64 pro.  Both the desktop and chrome version from the ardublockly.exe or start.exe files.  I have tried running from the python module, but I do not remember if this occurred there as well.
I will get back to this and better spell out the steps in a new issue as soon as I have the chance.
Thanks.

Closing due to inactivity, please feel free to reopen if you'd like to look into this again, but so far seems to be a combination of #59 + a problem with your Arduino IDE installation.


Configure CI pipeline to run Black and isort

[x] Install back and isort libraries
[x] Add configuration into checks.yml
[x] Upgrade pip to avoid errors in the pipeline

Done 😁


Add document that explains the new policies system

Closes #509

@nmasse-itix this might be interesting to you

Thanks for the review @andrewdavidmackenzie . I addressed all your comments.


Listing.get by address

Description:
Currently we only can get information about listing by the index number of where its address is stored in the ListingsRegistry contract. This is a left over of when when we used store all listing data in the ListingsRegistry contract.
We need to allow API users to directly get the Listing data from a listing contract address. This is a much more useful way of getting the listing, and will be the primary way listings are fetched in the future.
This adds an API method origin.listings.get(listingAddress), and the need contract changes to use it.
It also adds a listing created date to the listing, since this is information we'll need to use from listings on the front end.
This should merged in after PR #111.
Checklist:

[x] Code contains relevant tests for the problem you are solving
[x] Ensure all new and existing tests pass
[x] Submit to the develop branch instead of master

Will do later tonight:

[ ] Update any relevant READMEs and docs

Does it make sense to also return addresses instead of ids here?

@micahalcorn that entire method is a stop-gap until we get the indexer (on bridge server) working. That said, now that Listings are contracts (instead of structs) it is possible I think to return all the addresses from a solidity function.

Getting pretty pedantic, but I'd argue in this section that price should be the price in wei, as that is the true un-corruptible price, and we should have priceEth which just a convenience, and has all the problems of floating point numbers. I.e. the shorter name is the more fundamental, the longer name is more processed.
Relevant lines:
      priceWei: contractData[2].toString(),
      price: this.contractService.web3.fromWei(contractData[2], "ether").toNumber(),

I'm thinking that we may want to keep our long term field name as "priceWie", with the currency in the name. This should help avoid confusion as to if it's ETH or USD.
I agree that we do need to do away with the "price" field returning ETH. I was just keeping it in for now for backwards compatibility.

@micahalcorn Yeah, that whole getAllListingIds will be toast once we have the bridge server working and connected through the API.


Use objc_id to handle managing Objective-C objects

I noticed that metal-rs is using its own infrastructure (foreign_obj_type!) for managing Objective-C objects instead of objc_id. I was wondering if there was a particular reason for this and if the metal-rs strategy is better for some reason.
@JohnColanduoni

Metal returns a lot of unretained pointers in hot paths (via ObjC's "get" rule) to avoid unnecessary retain/release cycles and using objc-id for all the types would make this difficult. For example, ToOwned could not be implemented for a Metal type T since objc-id does not implement Borrow<T>.
The foreign_obj_type! is just a convenience wrapper over foreign_type! from the foreign_types crate. It is used in most of the Core* bindings from the Servo team, which was the impetus for using it here.

Seems this has been answered, @jrmuizel can you close it if that makes sense to you?

Yeah, this makes sense.


Error overlay does not open up the properties panel on single click

Describe the bug
When we try to click on the error overlay and open up the properties panel it is not possible  with a single click rather we need to click twice to achieve the output.
Steps to reproduce

Create a BPMN diagram with Camunda Platform 8
Create any two tasks that would produce lint error
Now try to traverse between the lint error overlay of the tasks we could see sometimes on a single click the properties panel is open and the respective error is highlighted while sometimes it needs a double click on the overlay.

https://user-images.githubusercontent.com/85225325/189343200-5ff09fd4-ccdd-4de0-aa1b-8d23d2d5b4a7.mp4
Expected behavior
On clicking the error overlay once the properties panel should be open
Environment

OS: [ Windows 10]
Camunda Modeler Version: [5.3.0]
Execution Platform: [ Camunda Cloud]

Additional context
No response

I spent some time looking into this issue. I cannot reproduce it in https://github.com/philippfromme/linting-playground. The issue occurs only when clicking an overlay focuses a text input in the properties panel. The next click after that doesn't do anything for some reason. I'll need more time to look into this.


Mocking dependencies of pnpm monorepo packages doesn't work as expected

Describe the bug
I'm encountering an issue with mocking dependencies in a pnpm monorepo setup. Specifically, I'm attempting to mock the writeContract function from the wagmi/actions package in order to test the approve function. These tests are running within the app workspace.
Directory structure preview:
monorepo
└── apps/
    └── test-app/
└── packages/
    ├── business-logic/
    └── wallet-conection/

When I implement the approve function within the app workspace itself and write tests for it, mocking wagmi/actions works as expected (apps/test-app/src/service/approve.test.ts). However, when I attempt to move the implementation of the approve function to the business-logic package within the monorepo, the mocks fail and the tests break (apps/test-app/src/service/external-approve.test.ts).
This issue seems to persist regardless of which package I attempt to mock, such as axios. To help diagnose the problem, I've prepared a minimal reproduction scenario on StackBlitz. I've thoroughly investigated potential configuration options but haven't been able to find a solution on my own.
I'd greatly appreciate any assistance or guidance on how to resolve this issue. Thank you!
Reproduction
Stackblitz: https://stackblitz.com/~/github.com/ffilipovicc98/vitest-issue-with-mocks-in-monorepo
Github repo: https://github.com/ffilipovicc98/vitest-issue-with-mocks-in-monorepo
System Info
System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 88.14 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 21.6.1 - ~/.nvm/versions/node/v21.6.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v21.6.1/bin/npm
    pnpm: 8.9.0 - ~/.nvm/versions/node/v21.6.1/bin/pnpm
  Browsers:
    Chrome: 124.0.6367.92
    Safari: 15.2

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It looks like this is due to a dual package of wagmi/actions, so your test-app and business-logic are importing different wagmi packages.
One thing I verified is that adding resolve.dedupe seems to help:
https://stackblitz.com/edit/github-eu6282?file=apps%2Ftest-app%2Fvite.config.ts
export default defineConfig({
  resolve: {
    dedupe: ['wagmi', 'wagmi/chains', 'wagmi/actions', 'wagmi/connectors'],
  },
})

Probably this is due to some intricate pnpm (peer dep?)  resolution difference. I'm not sure if this is something pnpm should deal with better or your package.json is not constraining dependencies properly.
$ ls node_modules/.pnpm | grep wagmi
@rainbow-me+rainbowkit@2.0.0_react-dom@18.2.0_react@18.2.0_viem<EMAIL_ADDRESS>wagmi@2.6.0_@tanstack+react-query@5.0.5_react-dom@18.2.0_react-i18next<EMAIL_ADDRESS>wagmi@2.6.0_@tanstack+react-query@5.0.5_react-i18next@13.5.0_react-native@0.74.0_react@18.2.0_viem<EMAIL_ADDRESS>wagmi@2.6.0_@tanstack+react-query@5.0.5_@types+react@18.3.1_react-dom@18.2.0_react-i18next@13_mo3joycr3hzwa34i3w7spnsol4
@wagmi+cli<EMAIL_ADDRESS>@wagmi+connectors@4.2.0_@types+react@18.3.1_@wagmi+core@2.7.0_react-dom@18.2.0_react-i18next@_53ntc43pgeagayvf5lgyrm6qau
@wagmi+connectors@4.2.0_@wagmi+core@2.7.0_react-dom@18.2.0_react-i18next@13.5.0_react-native@_ziihsyxwsv5dgpqz566z7hsjre
@wagmi+connectors@4.2.0_@wagmi+core@2.7.0_react-i18next@13.5.0_react-native@0.74.0_react@18.2.0_viem<EMAIL_ADDRESS>@wagmi+core@2.7.0_react@18.2.0_typescript@5.3.3_viem<EMAIL_ADDRESS>@wagmi+core@2.7.0_@types+react@18.3.1_react@18.2.0_typescript<EMAIL_ADDRESS>
To see how they are resolved, I ran VITE_NODE_DEBUG_DUMP=1 pnpm -C apps/test-app test external and this is what I saw in .vite-node/dump:
// /home/hiroshi/code/tmp/vitest-issue-with-mocks-in-monorepo/apps/test-app/src/service/external-approve.test.ts
...
const __vi_import_0__ = await __vite_ssr_dynamic_import__("/@fs/home/hiroshi/code/tmp/vitest-issue-with-mocks-in-monorepo/node_modules/.pnpm/wagmi@2.6.0_@tanstack+react-query@5.0.5_@types+react@18.3.1_react-dom<EMAIL_ADDRESS>
// /home/hiroshi/code/tmp/vitest-issue-with-mocks-in-monorepo/packages/business-logic/src/service/approve/approve.ts
const __vite_ssr_import_0__ = await __vite_ssr_import__("/@fs/home/hiroshi/code/tmp/vitest-issue-with-mocks-in-monorepo/node_modules/.pnpm/wagmi@2.6.0_@tanstack+react-query@5.0.5_react-i18next@13.5.0_react-native@0.74.0_react@18.2.0_viem<EMAIL_ADDRESS>{"importedNames":["writeContract"]});
...

@hi-ogawa Your help is much appreciated. It solved the issue I mentioned.
This makes our app safer and gives us more confidence in its accuracy. 🚀


Pin all unofficial github actions

WHY are these changes introduced?
We use quite a lot of open source Github actions, which are inherently vulnerable to supply chain attacks.
WHAT is this pull request doing?

Pin all unofficial Github actions to a specific sha
add a feature test to verify that all unofficial github actions are pinned

How to test your changes?

unpin any OSS github action
run cd packages/features
run FEATURE=features/github-actions.feature pnpm test
you should see this test failing

1) Scenario: All non-official github actions are pinned # features/github-actions.feature:3
   ✔ When I look at the github actions we use # steps/github-actions.steps.ts:6
   ✖ Then I see all non-official actions being pinned # steps/github-actions.steps.ts:11
       AssertionError [ERR_ASSERTION]: The following unofficial github actions have not been pinned:

         - mxschmitt/action-tmate@v3

       Run the bin/pin-github-actions.js script, verify that the action is not doing anything malicious, then commit your changes.
           + expected - actual

           -1
           +0

           at World.<anonymous> (/Users/arkham/src/github.com/Shopify/cli/packages/features/steps/github-actions.steps.ts:28:10)
   ✔ After # steps/environment.steps.ts:38

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

the pin-github-action script also reformatted all our yamls ✨


Socket.io process keeps running despite Unity editor being stopped.

After successfully connecting to a test server with the example client code via the Unity editor in run mode, something peculiar happens after stopping.

For some reason the socket.io process just keeps going, despite the fact I stopped the program.
I tried to add this code, which should kill the socket when the editor stops, but that doesn't seem to be the case:
    private void OnApplicationQuit()
    {
        socket.Disconnect();
    }

Have you tried Disconnecting the socket in the OnDisable or OnDestroy method? I don't know if OnApplicationQuit is the best method to use for the editor play mode.


Option to merge the Channel BTTV and FFZ emotes lists in a single one

Is your feature request related to a problem? Please describe.
Since BetterTTV upped the number of available slots per channel i feel that BTTV and FFZ separated lists are a "waste of screen real estate", so i think a single list would be cleaner. Also this "feature" could be applied to all the other emotes window tabs.
Describe the solution you'd like
I would say that two lists have their use cases so i think the better solution would be a switch in the program preferences
Describe alternatives you've considered
I think it's kind of a binary situation

Having the categories is important to let people know where emotes come from. Some people may not even know that BetterTTV or FrankerFaceZ exists. It also allows users to quickly find the emotes they want if they know from which host they are. Furthermore I don't see the argument of "screen space wasted" if the titles are only 5% of the entire space (since there are so many bttv emotes).
Adding a setting for this is not an option, as there is presumably close to no users that would use it, meaning that more users would be confused by the setting.


When running against kubedock testcontainers test need to factor in pull time in the start timeout

testcontainers will pull the docker image prior to starting the container. This means that when running against docker, test authors need not worry about pull times when specifying the timeout for starting the container.
In the context of kubedock though, of course pulling an image before creating a deployment/job makes no sense so the pull duration ends up ticking during the start timeout.
Not sure if there is anything that can be done here without be too complex, but wanted to raise the issue none the less.
The only idea I have is to implement the image pull via a daemonset that pulls the image on all nodes. This is not guaranteed to work if there is a scale up at the time of pod creation, but that is probably a niche case. This will however be quite wasteful as we will have to pull the image on every single node and will spin n pods for it.
Another option is to use inter-pod affinity. When pulling the image, we start a deployment/job/pod with that image that just sleeps forever. Then we schedule the actual workload we care about, configuring it to collocate with the first one. One it starts, we can clean up the one we used for the image pull. I've never used inter-pod affinities so not sure what are the implications here and if it will work at all.

I was wrong - testcontainers does not pull the images before the start which makes this redundant as an idea.


remove broken Tcp::Options::InstallSignalHandler

(see discussion in #221)
Also remove unreachable shutdown() from examples and add
http_server_shutdown example with signal handling (thanks to 1Hyena).

Codecov Report

Merging #547 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   70.26%   70.27%   +0.01%
==========================================
  Files          49       49
  Lines        6961     6944      -17
==========================================
- Hits         4891     4880      -11
+ Misses       2070     2064       -6

Impacted Files
Coverage Δ

src/server/listener.cc
70.4% <ø> (+2.6%)
:arrow_up:

include/pistache/tcp.h
80% <ø> (-3.34%)
:arrow_down:

src/common/os.cc
54.96% <100%> (-0.88%)
:arrow_down:

src/common/transport.cc
64.72% <0%> (-1.56%)
:arrow_down:

src/client/client.cc
81.29% <0%> (-0.2%)
:arrow_down:

src/common/reactor.cc
80.4% <0%> (+0.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117db02...8af2374. Read the comment docs.

Codecov Report

Merging #547 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   70.26%   70.27%   +0.01%
==========================================
  Files          49       49
  Lines        6961     6944      -17
==========================================
- Hits         4891     4880      -11
+ Misses       2070     2064       -6

Impacted Files
Coverage Δ

src/server/listener.cc
70.4% <ø> (+2.6%)
:arrow_up:

include/pistache/tcp.h
80% <ø> (-3.34%)
:arrow_down:

src/common/os.cc
54.96% <100%> (-0.88%)
:arrow_down:

src/common/transport.cc
64.72% <0%> (-1.56%)
:arrow_down:

src/client/client.cc
81.29% <0%> (-0.2%)
:arrow_down:

src/common/reactor.cc
80.4% <0%> (+0.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117db02...8af2374. Read the comment docs.


[Task]: Update the sql datasource preview data UI

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Update the UI for datasource preview data as per new designs
Convert the above components as common for supporting gsheet preview data UI as well.

@AmanAgarwal041 this needs an estimate


Send and Receive Test SAP Event Mesh

Tutorials: https://developers.sap.com/tutorials/cp-enterprisemessaging-test-queue-sendreceive.html
Doesnt work with trial account. The posting of a message always comes back Unauthorized.

Thank you for your feedback. For this tutorial you need a licence.

Please update the tutorial that it does not work with trial account. Thank you.


Cannot display the correct size

About this repo :https://github.com/Jyouhou/ICDAR2019-ArT-Recognition-Alchemy
I found a strange thing: I  am using this chrome extension to show the repo size which is shows 3.69MB,but that file is 19.1MB.
the repo size:

a one file of the repo:

The size is indeed expressed in kilobytes based on the disk usage of the server-side repository. However, in order to avoid wasting too much space with repositories with a large network, GitHub relies on Git Alternates.
In this configuration, calculating the disk usage against the repository doesn't account for the shared object store and thus returns an "incomplete" value through the API call.


Return more information in smarts.reset

Currently smarts.reset only returns observations_for_ego. It would be helpful for smarts.reset to return all 4 pieces of information observations, rewards, dones, extras that it got in smarts.step(). This is an interface change and env files and some test files need to change how they handle the return value from smarts.reset.
Smarts.py Line 321
        if len(self._agent_manager.ego_agent_ids):
            while len(observations_for_ego) < 1:
                observations_for_ego, _, _, _ = self.step({})

        self._reset_providers()

        return observations_for_ego

Related issue #54

Based off of issue #54

Based off of issue #54

Instead of this we should skip to the next episode and give a warning to conform to gym API.

Instead of this we should skip to the next episode and give a warning to conform to gym API.

Was closed by #397.


Add yank on MouseDragEnd1Pane

This basically expands on some of the removed code from #104 so that:

dragging with the mouse will yank with the current settings
@yank_selection_mouse controls the selection on Linux, defaulting to PRIMARY
setting @yank_with_mouse to off will disable these changes

I would really love to see getting this merged - anything holding it up?

I just stumbled across this PR, I second the desire to get this merged and offer to rebase it to get it merged if @docwhat is still interested.
In the meantime, I have the following workaround to share:
bind-key -T copy-mode-vi MouseDragEnd1Pane send-keys -X 'copy-pipe-and-cancel' 'xclip -selection clipboard'

The above binding was reverse engineered from what this PR does under the hood

Thanks for reminding me.  Merged.


Authenticate on /mqtt/superuser and /mqtt/acl request?

I using emqx-auth-http request to authenticate with API server. As API server should not use session and required to authenticate with username and password on each API request (Or, using JWT in short time period for security).
In document of emqx-auth-http using username/password on /mqtt/auth request only, while on /mqtt/superuser and /mqtt/acl not documentation about that.
So, I need you confirm that is no authenticate on that both request?, otherwise please you suggest to use authentication with EMQ too.
Thanks.

Yes, the document is not concise and easy to understand. In fact, this plugin is used to request auth info or acl info from user's http server, the url and parameters could be configured by yourself. We would add documents later.

Means both /mqtt/super user and /mqtt/acl already request username and password in url parameters to authenticate but it not yet shows in document ?

Yes, but you need to set the parameters in your http request. The /mqtt/super is a little different, using this plugin to request acl info will increase cpu usage and it would be a performance bottlenecks. Using superuser to author authentication will author just one time and later it would not execute check_acl action which would improve the performance.


Move exercises to subdirectory

The problems api (x-api) now supports having exercises collected in a subdirectory
named exercises.
That is to say that instead of having a mix of bin, docs, and individual exercises,
we can have bin, docs, and exercises in the root of the repository, and all
the exercises collected in a subdirectory.
In other words, instead of this:
x{TRACK_ID}/
├── LICENSE
├── README.md
├── bin
│   └── fetch-configlet
├── bowling
│   ├── bowling_test.ext
│   └── example.ext
├── clock
│   ├── clock_test.ext
│   └── example.ext
├── config.json
└── docs
│   ├── ABOUT.md
│   └── img
... etc

we can have something like this:
x{TRACK_ID}/
├── LICENSE
├── README.md
├── bin
│   └── fetch-configlet
├── config.json
├── docs
│   ├── ABOUT.md
│   └── img
├── exercises
│   ├── bowling
│   │   ├── bowling_test.ext
│   │   └── example.ext
│   └── clock
│       ├── clock_test.ext
│       └── example.ext
... etc

This has already been deployed to production, so it's safe to make this change whenever you have time.

:+1:

I'm updating configlet to handle the new requirement (totally forgot about that).

configlet should be good to go.

:tada:

What about Bob?


Make code more easy to read

Describe what this patch does to fix the issue.
When I read the code, I feel something is hard to understand.
So I change it.

I like where you've expanded the code into full if/else statements. However, I'm going to back out the wrapping changes, as they don't really match what this PR is about and aren't really consistent.


Driver doesn't work for ubuntu 18.04

Hello, when I installed this driver in my ubuntu,  System freezes when the adapter is plugged into a USB port. please fix this problem.

What version of the kernel is you using? (uname -r)

4.17.0-kali3-amd64

Error for wireless request "Set Mode" (8B06) :
SET failed on device wlan0 ; Invalid argument.

there is a chance that it will work in the future..?

Hey, can you please check now, with the latest commit on master. Thanks

iwconfig wlan0 mode monitor
Error for wireless request "Set Mode" (8B06) :
SET failed on device wlan0 ; Invalid argument.

uname -a
Linux kali 4.18.0-kali1-amd64 #1 SMP Debian 4.18.6-1kali1 (2018-09-10) x86_64 GNU/Linux
oot@kali:~# iwconfig
eth0      no wireless extensions.
lo        no wireless extensions.
wlan0     unassociated  ESSID:""  Nickname:"WIFI@REALTEK"
Mode:Managed  Frequency=2.412 GHz  Access Point: Not-Associated
Sensitivity:0/0
Retry:off   RTS thr:off   Fragment thr:off
Encryption key:off
Power Management:off
Link Quality:0  Signal level:0  Noise level:0
Rx invalid nwid:0  Rx invalid crypt:0  Rx invalid frag:0
Tx excessive retries:0  Invalid misc:0   Missed beacon:0
root@kali:~# ifconfig wlan0 down
root@kali:~#  iwconfig wlan0 mode monitor
Error for wireless request "Set Mode" (8B06) :
SET failed on device wlan0 ; Invalid argument.

help

This seems to be an Ubuntu 18.04 problem and not proper 4.17 kernel. Im facing same issue and my laptop runs Ubuntu 18.04 with 4.15 kernel. Firts im try with master branch and compile process was ok but system freeze like decribing in Issue # 16. Then im try with kernel4.15 branch but im get compile errors "/include/linux/kernel.h:6:10: fatal error: stdarg.h: No such file or directory
#include <stdarg.h>"

I'm on 18.04 too. Same problem. Is there a work around or fix for this problem?

This seems to be an Ubuntu 18.04 problem and not proper 4.17 kernel. Im facing same issue and my laptop runs Ubuntu 18.04 with 4.15 kernel. Firts im try with master branch and compile process was ok but system freeze like decribing in Issue # 16. Then im try with kernel4.15 branch but im get compile errors "/include/linux/kernel.h:6:10: fatal error: stdarg.h: No such file or directory
#include <stdarg.h>"

Have you solved this yet? Thx


fix premium issues on android release

in dev mode? not showing badge/wrong status on premium page for some.

Correct & already fixed in version 0.0.56.


optimized english subtitle of 41_text-embeddings-&-semantic-search.srt

Some texts are used as function name and variable name, so changed the related texts in subtitle and use the same as it  appeared in video.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

please review this pr for merging modifications on english subtitle files. @xianbaoqian


Pixi 5 Sprite Masks / resolution behaviour

It seems Pixi 5 behaves differently to Pixi 4 concerning the PIXI.Renderer.resolution value when using masks.  I'm not sure if this is a feature or bug, but since I have been unable to find a work around I'm assuming it's a bug?
When PIXI.Renderer.resolution is not 1, the mask will not match the screen size.  I'm not talking about the physical dimensions of the mask sprite in the scene, but the pixels treated on screen.  No matter of adjusting position, scale or matrix has an impact.  So, a resolution of 0.5 means only half the screen actually has the mask act upon it.
A resolution of 2 would mean double the screen size is masked, but since that is beyond the dimensions of the screen nobody is aware of it - other than perhaps slower performance.  I also have some older Android tablets that actually refuse to draw the mask altogether, presumably because the resolution is now beyond the GPU chips capabilities.  These are some of the early retina displays, with approx 2600x1600... I'm guessing if this is now doubled to 5200x3200 it's beyond the GPU chip max texture size, so the mask and masked content vanishes.  This does not happen with my fiddle below as the mask is not large enough, but you can certainly observe the behaviour in action by using resolutions below 1 to help diagnose.
Fiddle: https://jsfiddle.net/fanjules/sb2mzjfk
Set the resolution to 0.5 and you will see the mask is sliced in half!  This does not happen in Pixi4.
It's entirely possible I have misunderstood some changes in PIXI5 however, so any clarification warmly received.  I have also tried using a PIXI.SpriteMaskFilter and manipulating it's matrix or resolution properties, without effect.
Pixi 5.0.2
Chrome 74
Win 10 64bit

Oops.

Agree, both your cases, small resolution and big one are very important. Thank you for closing one more hole that appeared in v5 due a lack of tests.

I've been working on my game for over 2 years and push the Pixi core quite hard... despite this my transition to Pixi5 was painless so I think you guys are doing a great job.  I've found Pixi to be very robust and reliable overall. :)

Most of my PR's to v5 are actual ports of my fork of pixijs, so I understand your situation, we are happy to have you here :)

I have sent you a PM on html5gamedevs :)


Is there ongoing work for a serverless anserini work?

I read this paper https://arxiv.org/pdf/2002.01447.pdf and I felt this by itself could be a huge architecture revolution for the IR infrastructure. I have two questions here:

The paper mentioned that the code repo is https://github.com/castorini/anlessini, but it's empty. I hope I am looking for the right place, and maybe the code will be available soon. But if it's not the case, can @lintool point me to the right repo?

The paper mentioned this mechanism can handle the index with the size of 700MB without problem, but I am wondering if this architecture can scale beyond larger index where a single lambda memory can't fit.

We're working on it... ;)
cc @shaneding

Hey @syang sry bout the late reply, like @lintool mentioned I am currently working on this. Currently, if the actual index without raw documents exceed 700mb, then idt there is a way to scale.


upgrade progress for node pending safety checks

It is now possible to get information about the current partitions that a health check is pending on.

Add the same information to the node page when the node is in disabling.


Fix the seth-tp build issue because of SDK protobuf update

This patch will help the developers continue using the sawtooth-seth, until the Go SDK protobuf whereabouts are finalized.

You may need to add the clippy fixes from #117 to this PR, as both seem to need the other’s fixes to successfully build.

You may need to add the clippy fixes from #117 to this PR, as both seem to need the other’s fixes to successfully build.

Done

There's probably more to fix, there's a cli-go which also needs a fix in the protobuf paths.

Hello everyone!
It appears that the docker-compose up --build to the sawtooth-seth stills does not work.
I even tried to build the sawtooth-seth from this commit (ff897fe), but stills ends up in an error. (image below)
Do you guys have any solution?
Thank you!
@arsulegai @peterschwarz


STATUS11 BatteryUpdate

Added BatteryPercentage announcement to Status11. Supported in current TASMOTA versions

Status11 is identically with the STATUS message. Therefore I did not need to make any changes in TASMOTA. It just show up as default. It also makes totally sense here because this is a Information about current device information and the Battery makes sense here.