Using classes from 3rd party libraries inside components

I came across an issue trying to use Flexbox grid in my project. What I did is make a new folder named libraries inside app/css and put grid css file in there, afterwards, inside main.css I included it like so @import './libraries/grid.css' assuming that these classes will now be available across the project as main.css is included inside App.jsx , however using them like so:
// This is just a random component from my components folder that is included inside HomePage container
import React from 'react'
import { IndexLink, Link } from 'react-router'
import classNames from 'classnames/bind'
import styles from './Header.css'

const cx = classNames.bind(styles)

export default class Header extends React.Component {
  render () {
    return (
      <header className={cx('Header', 'row', 'center-xs')}>
      ...
      </header>
    )
  }
}

It seems like styles from Header.css are including fine, as inside markup the .Header class is displaying fine (Something like: Header__Header___1j2Yj), but row and center-xs don't seem to work unless I actually copy whole code from grid.css inside Header.css which probably means that I am not including it correctly, hence the question how would I make classes like row, col- etc.. from grid.css available to all of my components.

Hey thanks for raising this issue.
There should be a better way to use both libraries and our own css.
Because we're using css?modules in our webpack.config, className changes to being prefixed, unless you specify in your css to have
:global {
  .row-something-something {

   }
}

so you would be able include those classnames. Let me know how that goes!

@choonkending Would you be so kind as to elaborate on this answer? Perhaps I'm just tired, but I'm having trouble understanding what you're getting at.

If I want to use vanilla flexbox-grid, then how do I include that in my app in such a way that the classes are not namespaced, either in the DOM or in the CSS file itself? I would prefer to be able to include the flexbox-grid CSS somewhere in my project without modification.

It seems like it should be a simple process to just use react-flexbox-grid, but the webpack config changes are stumping me. (Surprise surprise, I'm not a webpack expert. :/ )

Perhaps this belongs in another issue ticket, but it would be great if we could add instructions for doing both of these in the reactGo documentation.
(Or does reactGo have another suggested solution for handling grid/layout issues?)

We're cleaning up issues on the project and since this is an old issue we're closing it.
If you still experience this or have an issue, please comment here or open a new one.
flexbox-grid has also changed a few things on their latest version including their build process so it might solve the original issue that was here.


Adjust fs error checking to silence newer TS errors

Newer TS complained about our previous unchecked usage of the code field in Node's error objects.
This updated code squelches those errors, checks more explicitly, and works even if a non-Node Error object should somehow get into the isNoSuchFileOrDirError function (error.code will then yield undefined and the triple-equals will be false)
@do-see @schierla @lieberlois @lenaxus it would be great if you could shortly look over this :)

I'll try to look into it this evening @PatrickLehnerXI 👍

The solution looks fine (though I don't see why your check function is a type guard).
Two alternatives would be to

just use   } catch (error: any) {, then the previous code should still work (but also catches cases where a non-error has a code of ENOENT
use a type guard const isNodeError = (error: Error): error is NodeJS.ErrnoException => error instanceof Error;, and then check (isNodeError(error) && error.code === 'ENOENT') in the catch clauses; this could also be reused for other error codes.

@schierla, thanks for your feedback! I liked your second suggestions, so I adjusted the code accordingly :)
I'll merge it once the build is green.


Update the action to support custom profiles and fail on warnings.

Use the latest docker container.

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     61.63%   61.63%
  Complexity      187      187
=========================================
  Files            37       37
  Lines           709      709
  Branches        311      311
=========================================
  Hits            437      437
  Misses           67       67
  Partials        205      205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9727b66...2940927. Read the comment docs.


Notification resend

…st notification.
To test:

Go to Center Settings -> Notifications
In the Past Notifications column, there will be a Message icon next to the Create/Expired dates.
Click the message icon.
The message will populate the Notification Text textearea in the Send a Notification column.
Complete the notification form (select a date) and click Send.

Verify the Notification is sent with the correct text.
Other tests:
Make sure a pre-populated notification can be edited and sent correctly.
Verify the Reset button functions correctly.
Verify form resets after sending a notification (both created from pre-populate and from manually typing)
@mleeBoeing @lsemesky @rkenyon1969

:+1:
Was able to verify the past notification would copy and send correctly. Form resets as expected afterwards.
Reset button also works as expected.


Revert "XFAIL ReactiveCocoa SR-6485"

Seems to be fixed.
Reverts apple/swift-source-compat-suite#105

@swift-ci Please test

Unrelated (new) failure in Plank (sigh)

Lets try this again.

@swift-ci Please test


Datastore.new API is incredibly confusing

The following code is an abuse of programming concepts, leads to user confusion, and exacerbates the already confusing documentation.
datastore = Google::Cloud::Datastore.new
puts datastore.class    # => "Dataset"

A constructor for the type Datastore should not return a different type!
To make matters worse, all of the documentation uses the variable name datastore to hold an object of type Dataset, making the confusion greater. It's all the more confusing when the docs for the Datastore object have only the #new method, and yet the code examples on the very same page suggest that there exist other methods (e.g., datastore.entity()).
If you want this sort of pattern, please, please change the method name to Datastore.new_dataset or something like that.

This is generally true of other packages as well:
irb(main):002:0> bigquery = Google::Cloud::Bigquery.new
irb(main):003:0> bigquery.class
=> Google::Cloud::Bigquery::Project

I agree it can be confusing to see that the "constructor" for Google::Cloud::Datastore (which btw is a module, not a class) creates an object whose class has a different name. However, I'd also remind the reader that that Ruby types are fundamentally duck types, not class-based types. The actual class of an object (the fact that it is a Dataset or a Bigquery::Project or any other class) is an implementation detail in Ruby code, and it's generally an antipattern to expect or rely on specific classes or class names. The important thing is whether the interface (i.e. which methods an object respond_to?) is clear and documented. If it isn't, we should figure out how to address that.

@dazuma totally agree with the superficials, and if this was C++/C#/Java and Datastore was an interface or abstract class, and there was some implementation called Dataset which implemented that public API, that'd be great.
But that's not what's happening here.

You're right that a) Ruby doesn't actually have "constructors" per se, and b) Datastore is a module. But the choice was made to use the pattern ConstantName.new which is a built-in Ruby paradigm used to create new instances of objects. So whatever the source code says, to a Ruby user it will read as Class.new even if it's actually a module, and a Ruby user will assume that it returns a Datastore object, not some other object (unless that other object is a subclass that is completely interchangeable...which Dataset is absolutely not).

You're right that Ruby is both dynamically typed and duck typed and so it's a faux-pas to care too much about implementation class as long as the "API contract" is upheld.

But there's one critical problem with that from a "Ruby API user knowing what to do" standpoint. Precisely because it is a duck-typed language without any formal construct for "interface", there is no easy way to tell the user what behavior they can actually expect in an implementation-independent way. The set of public methods for Dataset is the API and from the user's perspective, Datastore.new is just a global factory function.
For a Ruby API, the only way to know what methods you can call and what their parameters, side-effects, and error cases are, is for there to be a) a concrete class to look at (since interfaces and abstract classes don't exist in the language), and b) enough documentation to make up for the general wigglyness of the Ruby language (e.g., metaprogramming).
At the end of the day, I'm really asking for a minor, minor change: don't use Datastore.new as the method name. The method is really just a factory method for a different class (Dataset) and should be named appropriately.
The moment you say Datastore.get_dataset or equivalent, I as a user know a) this isn't an object constructor, and b) Datastore is not the object/class/module/whatever I should be looking at.
It doesn't even have to be a breaking change. Just introduce the new method, keep and deprecate the old one, and update the documentation. I'm happy to help with the legwork if that's an issue.

Ah, okay. I'm hearing that when you see Datastore.new, you (rightly) expect that you can find the documentation for the resulting object under the class Datastore, and it's surprising and confusing that you have to look for a different class Dataset for this information.
A different name for the factory method does seem like a reasonable approach. @blowmage What do you think? We were trying to keep the "toplevel client object" paradigm in place while lazy requiring of the files, but it is a good point that from a documentation perspective, users already have to know the actual class of the object (e.g. "Project"). Maybe it's okay for the factory method to make that explicit.

These are great points and I generally agree with them. I can explain the history behind how we got here if you are interested. Unfortunately, however, I am very unlikely to support changing the names at this point in time.
I am sorry that the original naming decision has elicited such a strong negative reaction. Our goal has always been to craft a delightful and productive experience.

Mostly I'm interested in the reasoning behind your standpoint so I can understand. If that includes a history lesson, that's fine with me!
If the names are set in stone, what room is there to improve the documentation? What is auto-generated vs. human-specified?

As I remember the history, these libraries originally exposed their top-level types through module methods such as Google::Cloud.datastore, and they still do. At some point there was a request to provide creation of these types via new, and the method was added.

what room is there to improve the documentation? What is auto-generated vs. human-specified?

We'd love to get your help improving the documentation. The docs source for Datastore.new is here and is not generated. Feel free to open a PR (or just post some changes on this issue if that's easier.)

@ohboyotero Is there anything else to discuss on this issue, or can I close it?


error 0.6.0

Error when updating to version 0.6.0beta but even when downloading the previous version from the www I experience the same problem I can only use another version 0.5.0 to return to the normal state downloaded a long time ago

Yeah it's a codesigning issue because I don't have a paid signing account. Your options are either to sign it yourself (if you know how to do that) or try again in a few days since it's super random (not everyone experiences crashes)

It means that I compile it myself

@kaoskinkae64 the issues might be resolved in the latest release. Please test it if you can and report back:
https://github.com/0xCUB3/About-This-Hack/releases/tag/0.7.0


API tweaks for OpenAPI, errors and endpoints

This is a bit of bundle PR with several smaller things. If you would really like, I could split these up, but... I don't want to 🙈
Changes:

Refactor variable naming slot -> slotIndex
Changing error Sales unavailable/Purchasing unavailable to Persistence is not enabled as that is better descriptive to what is actually going on to the user.
Tweaking the docs/TwoClientTest.md to be working again.
Extending /sales/slots/{slotId} endpoint to include reservation and request as well.
Fixing up openapi.yaml to be accurate again, with extending some validation enums

I like that we're adding more examples, but I wouldn't remove the simple no persistence example, because it adds more unnecessary steps to the flow. We also have the marketplace tutorial, which has a more sophisticated setup outlined.

but I wouldn't remove the simple no persistence example

Actually i think this is a good point, and maybe we could link to the marketplace example from this simple example instead, eg "This basic example explores connecting two client nodes, but a more in depth example with storage providers can be found in the Marketplace example (link)". Or, alternatively, add the "persistent" TwoNodesClient example after the simple example, but it may be a bit redundant with the Marketplace example...

Since @AuHau is away, I'll pull out the tutorial changes and keep the rest so we can get this merged for the release.


some information present in the excel scenario sheets can't be represented with the ontology

Description of the issue
This is just a first list which informations I couldn't find in the ontology. The points have to be further looked at and decided if they should be implemented/ get their own issues.

[ ] Potentials: theoretical, technical, economic, developable (#481)
[ ] Exogen/ endogen data? (#482)
[ ] Sensitivities
[ ] secondary fuels (#390)
[ ] Report document type (#473)
[ ] Population, working population (#479)
[ ] Non-energy sectors: Land use, land-use change and forestry (LULUCF), agriculture, waste (#30)
[ ] Type of sponsorship (#473)
[ ] Economic data: gross domestic product (GDP), Gross value added (GVA) (#454, #455)
[ ] Prices (we have cost, is that enough?) (#331)
[ ] Target/ measure- driven scenario (related to #28 and #444)
[ ] Weather year, typical year, typical periods (#474)
[ ] International transport (#475)
[ ] "Upstream chains outside the territory included?" (#475)
[ ] Energy flows: primary-, final energy (#390)
[x] report (#247)
[x] Nuclear, renewable fuels (part solved in #182 and #397)
[x] Installed capacities (#320)
[x] Air pollutants:

feature/modelfactsheets will add useful properties. I'll revisit this issue after merge.

@akleinau :  I discussed today with @stap-m that it might be good to have separate issues as the list above covers quite a variety of concepts. Could you please create issues for those concepts where is no issue yet?

@l-emele is "type of sponsorship" under "funding institution" sth like if they give money or materials or sth else? Or is it privat/public?

@l-emele non-energy sectors will be covered by the ongoing sector discussion so I'll delete it from here, right?

@l-emele is "type of sponsorship" under "funding institution" sth like if they give money or materials or sth else? Or is it privat/public?

That should be part of #473.

@l-emele non-energy sectors will be covered by the ongoing sector discussion so I'll delete it from here, right?

Yes, exactly. Maybe not delete in the list, but mention #30 in the list.
All issues related to the scenario fact sheet should go into this project: https://github.com/OpenEnergyPlatform/ontology/projects/4

@l-emele I'm not sure about "Sensitivities", should this be included in the ontology? I'm not sure whats meant with that

See https://en.wikipedia.org/wiki/Sensitivity_analysis

then we have issues now for all of them, so close this one?

then we have issues now for all of them, so close this one?

I agree and close the issue now.


feat(apps/prod/jenkins): update ns default node-selector

To avoid pod 5000ms timeout when schedule pod to poor disk I/O performance machine.

/lgtm
/approve


Simple Carousel

Simple Carousel offers "Next" buttons but they don't do anything when clicked.

In Data section list name is not coming to select the "Pictures" library.

Same issue for me with all "gallery" web parts. It's not possible to select an image library. Select box is just empty.

Same issue for me with all "gallery" web parts. It's not possible to select an image library. Select box is just empty.

I am having the same issue. Has anyone found a workaround, fix or substitute? Thanks in advance.


DefaultValue not woking with react-native-masked-text

Description of bug
when i try use defaultValue with react-native-masked-text passing any value to the field is not working. the field value persist blank

To Reproduce
follow this tutorial https://unform.dev/examples/react-native-input-mask
Screenshots

Environment:

OS: Windows 7
"@unform/core": "^2.1.3"
"@unform/mobile": "^2.1.3"
"react-native": "0.63.2"

Hey @nikolasalgoritme, I am going to close this issue because it is not following the guidelines described here.
While contributing or interacting in any way in this project, refrain from using any language other than English.

@jpedroschmitz hi, i'm really sorry about that. i have edited my post. can you open my issue again or i need to create a new one

Hello! For me it worked like this!
In screenshot number 1
change
useEffect(() => {
    inputRef.current.value = defaultValue ;
}, [defaultValue]);

for
useEffect(() => {
inputRef.current.value = defaultValue ;
if (onChangeText)
onChangeText(defaultValue);
}, [defaultValue]);
good luck!!

I did it the same way and it didn't work

does anyone know what happens

I did it, but my field came without the mask


validateOptions .ignore behaviour change

Dear Volkan,
this is related to my previous issue concerning the default value of the .ignore option.
What I meant to say was that your implementation of the validateOptions is perfectly fine and I don't want to override, but rather I just want to control the value of .ignore option.
Please take a look at my change, the idea is to keep the same default behavior (by default it will ignore :hidden) of the method and just enable the possibility to control the .ignore option.
Thank you as always for your time
Bye

@marcobisio $.extend works from left to right, so if you pass something in options, it already uses that, this change won't change anything :)

Ah you're right...you already told me the same thing in a previous issue, but I got your point just now :D
Thank you very much!
Bye


Module not found: Error: Can't resolve 'fs'

I was developing with exceljs to export json to *.xls excel format, but when webpack update via console display this message
Module not found: Error: Can't resolve 'fs'

in multiple react-boilerplate dependencies
I try to update dll file with
$ npm run build:dll

when finished to build it, console displays fs errors in many package dependencies.

Thanks.

It's irrelevant and your project will run perfectly fine without it. fs is for an underlying feature of exceljs and many other nodeJS modules that don't work inside a React.JS App. If you need to make the error go away because you're sick of looking at it...
Go to webpack.base.babel.js inside /internals/webpack ...
And add somewhere close to the bottom... mines directly above devtool: options.devtool ...
node: { fs: 'empty' },
This will cause the webpack to ignore fs dependencies.
i.e.
  resolve: {
    modules: ['app', 'node_modules'],
    extensions: [
      '.js',
      '.jsx',
      '.react.js',
    ],
    mainFields: [
      'browser',
      'jsnext:main',
      'main',
    ],
  },
  node: { fs: 'empty' },
  devtool: options.devtool,
  target: 'web', // Make web variables accessible to webpack, e.g. window
  performance: options.performance || {},
});

You can also find some comments on this topic directly in the ExcelJS repo: https://github.com/guyonroche/exceljs/issues/299 and https://github.com/guyonroche/exceljs/issues/606

Wow, Thank you very much @michaelcuneo & @julienben.
Keep coding.

🤟

I found a way for this issue here that might be useful


Publish 0.6.3 with recent non-breaking macOS fixes

Published changes include #157.

Seems travis is failing on the install script:
if [ $TRAVIS_OS_NAME = osx ]; then
    sh ~/rust-installer/rustup.sh -y --disable-sudo --prefix=/Users/travis/rust \
      --add-target=x86_64-apple-ios
fi

sh: /Users/travis/rust-installer/rustup.sh: No such file or directory

failed and exited with 127 during .

I wonder if something has changed wrt to travis and rustup?
Also, there's a warning printed out at the beginning of the build:
$ rvm use

Warning! PATH is not properly set up, '/Users/travis/.rvm/gems/ruby-2.0.0-p648/bin' is not at first place,
         usually this is caused by shell initialization files - check them for 'PATH=...' entries,
         it might also help to re-add RVM to your dotfiles: 'rvm get stable --auto-dotfiles',
         to fix temporarily in this shell session run: 'rvm use ruby-2.0.0-p648'.

Using /Users/travis/.rvm/gems/ruby-2.0.0-p648

Not sure if this has anything to do with it 😕

Ok, fixed travis' macOS build by switching from rustup.sh to rustup.rs, as it seems travis made the switch two days ago travis-ci/travis-build#993.


Pretty print diagnostics

The output from the Swift compiler can be pretty verbose. This adds better formatting and syntax highlighting to the compiler's output (modeled after the error messages of React).

I also modified the screen-clearing to reset the scrollback so you can easily find the first error without scrolling past it.

Fails

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L50 - Prefer private over fileprivate declarations. (private_over_fileprivate)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L54 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L65 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L69 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L78 - Line should be 100 characters or less: currently 102 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L83 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L85 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L87 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L94 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L106 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L108 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L109 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 66 lines (function_body_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L112 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L113 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L114 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L117 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L133 - Line should be 100 characters or less: currently 123 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L166 - Line should be 100 characters or less: currently 122 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L174 - Line should be 100 characters or less: currently 171 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L175 - Line should be 100 characters or less: currently 117 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L176 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L183 - Line should be 100 characters or less: currently 104 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L56 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L60 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/ProcessRunner.swift#L44 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)

:no_entry_sign:

Sources/carton/Commands/Dev.swift#L63 - Lines should not have trailing whitespace. (trailing_whitespace)

  Generated by :no_entry_sign: Danger Swift against 59d99996b01844312637a8aebef80f30a7649e84

One concern I have is that this might break a certain behavior in VSCode that I constantly rely on. You can cmd-click in current diagnostics output in the integrated terminal to jump to a relevant location, as VSCode parses all strings in file:line format for that to work. That probably won't matter as soon as swiftwasm/swift#1935 is resolved.

Fails

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L51 - Prefer private over fileprivate declarations. (private_over_fileprivate)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L55 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L58 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L62 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L66 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L70 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L79 - Line should be 100 characters or less: currently 102 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L84 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L86 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L88 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L107 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L109 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L110 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 68 lines (function_body_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L113 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L114 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L118 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L134 - Line should be 100 characters or less: currently 123 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L151 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L170 - Line should be 100 characters or less: currently 154 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L178 - Line should be 100 characters or less: currently 183 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L180 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L187 - Line should be 100 characters or less: currently 104 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L56 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/ProcessRunner.swift#L44 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)

:no_entry_sign:

Sources/SwiftToolchain/Toolchain.swift#L229 - Line should be 100 characters or less: currently 101 characters (line_length)

:no_entry_sign:

Sources/carton/Commands/Dev.swift#L63 - Lines should not have trailing whitespace. (trailing_whitespace)

  Generated by :no_entry_sign: Danger Swift against d709600b540e989f694b1a5aa480f14422c847aa

I could put the whole file path in the heading text with the first error's line #. Would that work?

It should work. Let's try that, I hope it doesn't ruin how nice the output looked on your screenshot 😄

And if it does look weird or incoherent if you add full path and a line of first error, I'd be totally fine with hiding this behind a CLI flag. I'd use that flag, while the rest of the users could still enjoy nicely formatted output 😁

Ended up putting the full path next to the filename in gray. Here's the output from VSCode. It's cmd-clickable.

Fails

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L27 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L59 - Prefer private over fileprivate declarations. (private_over_fileprivate)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L63 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L70 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L74 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L78 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L87 - Line should be 100 characters or less: currently 102 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L92 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L94 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L96 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L104 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L116 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L118 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L122 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L123 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L124 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L127 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L142 - Line should be 100 characters or less: currently 128 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L145 - Line should be 100 characters or less: currently 123 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L163 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L183 - Line should be 100 characters or less: currently 154 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L191 - Line should be 100 characters or less: currently 183 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L192 - Line should be 100 characters or less: currently 117 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L200 - Line should be 100 characters or less: currently 104 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L56 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L60 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/ProcessRunner.swift#L44 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)

:no_entry_sign:

Sources/SwiftToolchain/Toolchain.swift#L229 - Line should be 100 characters or less: currently 101 characters (line_length)

:no_entry_sign:

Sources/carton/Commands/Dev.swift#L63 - Lines should not have trailing whitespace. (trailing_whitespace)

  Generated by :no_entry_sign: Danger Swift against 7d54f1a9aa619c773fd8879362cd4ec9c52c0e54

Fails

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L87 - Line should be 100 characters or less: currently 102 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L94 - Force tries should be avoided. (force_try)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L96 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L119 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 57 lines (function_body_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L123 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L142 - Line should be 100 characters or less: currently 128 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L145 - Line should be 100 characters or less: currently 123 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L202 - Line should be 100 characters or less: currently 116 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L206 - Line should be 100 characters or less: currently 175 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L207 - Line should be 100 characters or less: currently 109 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L56 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L60 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/ProcessRunner.swift#L44 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)

:no_entry_sign:

Sources/SwiftToolchain/Toolchain.swift#L229 - Line should be 100 characters or less: currently 101 characters (line_length)

:no_entry_sign:

Sources/carton/Commands/Dev.swift#L77 - Lines should not have trailing whitespace. (trailing_whitespace)

  Generated by :no_entry_sign: Danger Swift against 1a4254567777db87279013b46365996381139619

Fails

:no_entry_sign:

Sources/CartonHelpers/DiagnosticsParser.swift#L235 - Line should be 100 characters or less: currently 151 characters (line_length)

:no_entry_sign:

Sources/CartonHelpers/InteractiveWriter.swift#L56 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Sources/CartonHelpers/ProcessRunner.swift#L44 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)

:no_entry_sign:

Sources/carton/Commands/Dev.swift#L77 - Lines should not have trailing whitespace. (trailing_whitespace)

  Generated by :no_entry_sign: Danger Swift against 6ffe133365a5520c619ef0d61cc33d4e9e667abf

@carson-katri ready for merging 🙂


HuskHouses and Pl3xmap's err

I think we didn't fix it :(
Log: https://paste.ubuntu.com/p/tJHQWdmNYS/

Outdated version of Pl3xMap. Download the absolute latest release.


.11 stable publish

pending pipeline fixes

Some followup issues/communications remain.

@Aniruddh25 discussions post created and pinned: https://github.com/Azure/data-api-builder/discussions/2174


Update reference-connect-version-history.md

The notation needs to be updated to the current correct supported version.

@billmath -

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#assign: @billmath

hi @CelesteDG - temporarily assigning this to you... we aren't able to assign @billmath - likely due to repo restrictions

Thank you, @Jak-MS
Reassigned to @billmath

Fixed.

#please-close


A way to cut unsuccessful branches in PGN Editor

The idea is: Evaluate branches and then cut the ones that are negative. Or under -2 or something specified by the user.
This way the "Play like X when he wins" will actually make sense.

Implemented in v2.3.99


Efficient bulk imports via pq.CopyIn

lib/pq has support for efficiently inserting bulk items using COPY. sqlc currently can not generate code that exposes this functionality.
See this StackOverflow answer for a great overview of the problem space.

Hi @kyleconroy, Any update on this.

Nope, no update as of yet. It's low on my list, as I'm focusing on MySQL / SQLite support right now.

Hi! Any updates on this?

I found a way to do bulk insert and update with sqlc and Postgres:
-- name: CreateAuthors :exec
INSERT INTO authors
SELECT unnest(@ids::bigint[]) AS id,
  unnest(@names::text[]) AS name,
  unnest(@bios::text[]) AS bio;

-- name: UpdateAuthors :exec
UPDATE authors AS a
SET name = tmp.name, bio = tmp.bio
FROM (
  SELECT unnest(@ids::bigint[]) AS id,
  unnest(@names::text[]) AS name,
  unnest(@bios::text[]) AS bio
) AS tmp
WHERE a.id = tmp.id;

It uses arrays to serialize multiple rows into 1 parameter and unnest to deserialize them in Postgres. You can see the generated code in the playground.
It felt a bit hacky, so I made a benchmark to ensure that it is working as expected:
BenchmarkCreateAuthor-6<PHONE_NUMBER>2 ns/op
BenchmarkCreateAuthors10-6<PHONE_NUMBER>0 ns/op
BenchmarkCreateAuthors100-6           74          14967301 ns/op
BenchmarkCreateAuthors1000-6          30          38486604 ns/op
BenchmarkUpdateAuthor-6<PHONE_NUMBER>5 ns/op
BenchmarkUpdateAuthors10-6            94          13677888 ns/op
BenchmarkUpdateAuthors100-6           66          15819271 ns/op
BenchmarkUpdateAuthors1000-6          28          56070949 ns/op

BenchmarkCreateAuthor and BenchmarkUpdateAuthor measure the time it takes to insert or update an author. The BenchmarkCreateAuthorsN and BenchmarkUpdateAuthorsN uses the above code to group N authors into a query.
By looking at BenchmarkCreateAuthor and BenchmarkCreateAuthors1000, we can see that it takes the same amount of time to create 100 authors with an insert and 30000 authors with the above method.
If you want to try it, you can find the code of the benchmark here.

Now that pgx support has landed, we'll also need support their Copy Protocol.

I found a way to do bulk insert and update with sqlc and Postgres:
-- name: CreateAuthors :exec
INSERT INTO authors
SELECT unnest(@ids::bigint[]) AS id,
  unnest(@names::text[]) AS name,
  unnest(@bios::text[]) AS bio;

-- name: UpdateAuthors :exec
UPDATE authors AS a
SET name = tmp.name, bio = tmp.bio
FROM (
  SELECT unnest(@ids::bigint[]) AS id,
  unnest(@names::text[]) AS name,
  unnest(@bios::text[]) AS bio
) AS tmp
WHERE a.id = tmp.id;

It uses arrays to serialize multiple rows into 1 parameter and unnest to deserialize them in Postgres. You can see the generated code in the playground.
It felt a bit hacky, so I made a benchmark to ensure that it is working as expected:
BenchmarkCreateAuthor-6<PHONE_NUMBER>2 ns/op
BenchmarkCreateAuthors10-6<PHONE_NUMBER>0 ns/op
BenchmarkCreateAuthors100-6           74          14967301 ns/op
BenchmarkCreateAuthors1000-6          30          38486604 ns/op
BenchmarkUpdateAuthor-6<PHONE_NUMBER>5 ns/op
BenchmarkUpdateAuthors10-6            94          13677888 ns/op
BenchmarkUpdateAuthors100-6           66          15819271 ns/op
BenchmarkUpdateAuthors1000-6          28          56070949 ns/op

BenchmarkCreateAuthor and BenchmarkUpdateAuthor measure the time it takes to insert or update an author. The BenchmarkCreateAuthorsN and BenchmarkUpdateAuthorsN uses the above code to group N authors into a query.
By looking at BenchmarkCreateAuthor and BenchmarkCreateAuthors1000, we can see that it takes the same amount of time to create 100 authors with an insert and 30000 authors with the above method.
If you want to try it, you can find the code of the benchmark here.

Does this solution also work for fields which are Nullable? Because right now when I am creating my inserts this way I get []int64 for ::bigInt[] but I need to have []*int64 because this field is nullable? Any ideas on how this could work?

https://docs.sqlc.dev/en/latest/howto/insert.html#using-copyfrom has landed, so I think we can close this.

@aitva We have been using the json_populate_recordset function in order to do bulk inserts which does allow for null values. There are other json functions you may want to use like json_to_record. Unfortunately the models generated by sqlc do not work well with these methods as instead of using NullInt64 you would want int64 with omit empty

@Jille @kyleconroy, please consider reopening this issue to support the COPY istruction for bulk inserts with lib/pq, as originally mentioned above.
The documentation says:

The :copyfrom command requires either pgx/v4 or pgx/v5.

Let's make that a new feature request. Would you mind coming that?

Sure, I've just opened a new issue for it: #3264.


LWC tests are failing

LWC tests are failing at the moment. Let's fix them.

fixed by #78

fixed by #78


Fix incorrect Arcade Body delta

This PR

Fixes a bug

Fixes #5204, from #4978.
If you created an Arcade Physics sprite during scene update(), the sprite position was incorrect at the end of the step.

👍

This pull request has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/arcade-physics-body-flickering/3329/8


Bug Report: 17.0 image missing llvmjit.so

cimg/postgres:17.0 is missing llvmjit.so

Describe the bug
cimg/postgres:17.0 does not work with psycopg2 due to missing llvmjit shared object file:
sqlalchemy.exc.OperationalError: (psycopg2.errors.UndefinedFile) could not load library "/usr/lib/postgresql/17/lib/llvmjit.so": libLLVM-14.so.1: cannot open shared object file: No such file or directory

The same config works fine on cimg/postgres:16.4
To Reproduce
Please provide steps to reproduce the behavior, such as a sample job or config file.

I'm having the same issue with cimg/postgres:17.0 when complex queries trigger a JIT compilation in PostgreSQL:
django.db.utils.OperationalError: could not load library "/usr/lib/postgresql/17/lib/llvmjit.so": libLLVM-14.so.1: cannot open shared object file: No such file or directory

The libllvm14 package is missing, which is required for the JIT functionnality.
It seems that the dependency is lost when the newly added build-essential package is purged. I can propose a fix.


[WW-5126] use == instead of .equals in ModelDrivenInterceptor

due to refreshing model regardless of potential overridden Object.equals

Coverage increased (+0.003%) to 49.914% when pulling fe656eae21a7a287b2143fad638234314f858178 on yasserzamani:ww_5126 into 09f969a9bebe31370df64702a61420f14ead6271 on apache:master.


[Bug]: CurrencySettleTake improvements

Describe the bug

needs safe transfer
needs simply specific functions not just generic ones

Expected Behavior

To Reproduce
No response
Additional context
No response

#186


Fix MSVC Libfuzzer coverage reporting

This PR fixes two issues:

First, in MSVC compiled binaries both the LLVM and MSVC symbols are
present, but only the MSVC symbols have correct values. For example:

0:000> cdb: Reading initial command '.scriptload DumpCountersOld.js ; !dumpcounters "cov" ; q'
JavaScript script successfully loaded from 'DumpCountersOld.js'
[+] not disabling sympath
INFO: Seed: 58715679
INFO: Loaded 1 modules   (3968 inline 8-bit counters): 3968 [00007FF70DB4B000, 00007FF70DB4BF80), # XXX Note
xxx.exe: Running 1 inputs 1 time(s) each.
Running: inp
[+] processing xxx.exe
[+] using LLVM 10 symbols - 0x7ff70db72b00:0x7ff70db72b08 # XXX These are wrong

This means the order we search for the coverage symbols is important.

Secondly, this enables support for MSVC 8bit counter coverage.

PR Checklist

[x] Applies to work item: #323
[x] CLA signed
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed
Running any recent MSVC compiled libfuzzer target should fail to actually collect coverage, instead just returning the 8 null bytes described in the linked issue.

Performing integration tests with existing samples.


Bug: client does not disconnect cleanly.

After calling RenetClient::disconnect(), the method RenetClient::is_connecting() returns true.

Can you show a small example that replicates this behavior? I was not able to make a simple reproduction case, for example, this simple case is working:
let mut connection = RenetClient::new(ConnectionConfig::default());
assert!(connection.is_connecting());
connection.disconnect();
assert!(!connection.is_connecting());


Use lib-onyx for common utilities

Currently I have moved and tried to generalize catalog and lifecycle "instrumentation" functions for

[x] core_async
[x] kafka
[x] logging
[ ] sql

[ ] provide SQL migration or at least ensure proper schema using Joplin
[ ] refuse to start the task if the DB cannot be reached.

I hesitate to drag in all of Joplin just for assuring DB schema. If anyone knows of a better way to do this (and still remain DB agnostic) I would gladly substitute that.

Ragtime?

Going to track this in the lib-onyx repo, this is a larger undertaking that I originally assumed.


Unrounded floats causing display issues

Consider rounding everything to 2 decimal places for display purposes?

oh ya i fixed this forgot when


Only one field for each model?

The example in readme shows
python train.py --field total_amount --batch_size 8
and
python predict.py --field total_amount --invoice invoices/1.pdf
So the model is for only one field? or how to specify several fields?

You can train one model for only one field. You'll have to train a new model for every new field you decide to add.


Async user hooks

Why are these changes needed?
Async user hooks create an async version of hooks to work with the event loop through async calls, not to get them confused with sync calls. Any async chats will use async hooks inherently so the user hooks can do async actions.
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

Codecov Report
Attention: Patch coverage is 5.45455% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 13.16%. Comparing base (cd3b5c6) to head (d2293b0).

Files
Patch %
Lines

autogen/agentchat/conversable_agent.py
5.45%
52 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1845       +/-   ##
===========================================
- Coverage   36.03%   13.16%   -22.87%
===========================================
  Files          63       63
  Lines        6608     6661       +53
  Branches     1456     1600      +144
===========================================
- Hits         2381      877     -1504
- Misses       4036     5764     +1728
+ Partials      191       20      -171

Flag
Coverage Δ

unittests
13.16% <5.45%> (-22.87%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@sidhujag it looks like this PR has stalled, do you have an interest or ability to complete?


Addition of dispute game trusted operation

Currently waiting on being merged https://github.com/ajuna-network/Ajuna/pull/60

wrong repo!


Unresolved functions and types might be put into the wrong package

If a function or a type isn't found then a "temporary" symbol is created. But that symbol is put into the same package as where we are parsing. This might not be correct.
We should instead add an extra "resolve" step for functions and types that aren't resolved before the actual bytecode building and optimization is started

We could do the same thing as GoLang (you must add a package prefix for all non-local types and functions), but that should be a last resort.

Another solution would be to disalow circular package dependencies (two packages that import each other).


From Markdown to Asciidoc

The README hsa translate from markdown to Asciidoc with asciidoctor and I don't know if everything is ok. Need to review the new version of README.md to README.adoc

No more needed


bug(DRAG&DROP): The cdkDropList should be accessible when moving an element

I have a kanban board (like Trello) with columns that are collapsable. If a column is collapsed and I hover it when I move a card, I make it uncollaplle. However, at that point the cdkDropListContainer does not allow me to "drop" the card from within.
Initially the cdkDropList element was "masked" with an *ngIf directive, I replaced it with the hidden attribute and then I tested with just a css style to set the size to 0 but none of these solutions worked. The result is always the same.
How is this done? How do I do it?
I use : "@angular/cdk": "^10.0.1".
Thanks

The hidden attribute/class would be the better way to go here versus an ngIf completely destroying/recreating a drop list mid-drag.
I believe there are no out-of-the-box ways to accomplish what you need. So you'll have to call some private APIs to refresh the client rects of the drop container(s) since you changed their dimensions/locations on page.
Perhaps running something like this immediately after the connected drop container has been unhidden:
// cdkDrag is reference to the `CdkDrag` directive currently being dragged
cdkDrag._dragRef._dropContainer._cacheParentPositions();
cdkDrag._dragRef._dropContainer._siblings.forEach(sibling => sibling._cacheParentPositions());

I believe this is covered by https://github.com/angular/components/issues/14703.


The images don't load

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

Does not load any of the images on the MDN website when translated into Spanish and other languages: https://developer.mozilla.org/es/docs/Learn/HTML

Hi @LEIMAG7! This repository (mdn/sprints) isn't really used to track MDN issues any longer. If this is still an issue, please scroll down to the "Found a content problem with this page?" section and use the "Report the content issue" link to report the issue on the appropriate repository (mdn/translated-content) so that the appropriate team can resolve your issue quickly. Thank you in advance!

@Rumyra Should we be archiving or at least locking this repo to new input except from core team?  Confusing to have yet another way to post and track stuff.


@DarkShadowG here you go: https://docs.getutm.app/guides/kali/#black-screen-on-start

    @DarkShadowG here you go: https://docs.getutm.app/guides/kali/#black-screen-on-start

Originally posted by @optikfluffel in https://github.com/utmapp/UTM/issues/4090#issuecomment-1285947004
Adding a serial device seems to work! Thx

sorry


Remove *_RS1.xaml files

Since the WinUI library has RS2 as minimum compatible Windows version, we should get rid of the RS1 files to clean up the project from files that are not needed anymore.
Thanks to @kaiguo for pointing that out over here!

Seems like righteous cleanup. On the other hand we'll be getting rid of all of the per-version stuff with WinUI 3.0 so i don't know if it's worth spending too much time on it now. If it's causing grief then I'm happy for you (or anyone) to contribute such a fix.

#975 tracks getting rid of ALL the version specific Xaml generation once WinUI 3 is available. But we can get rid of the rs1 variants sooner than that if desired.

#975 tracks getting rid of ALL the version specific Xaml generation once WinUI 3 is available. But we can get rid of the rs1 variants sooner than that if desired.

Oh I did not know that.
@kaiguo, @kmahone : Is there any benefit in working on this issue right now/ before WinUI 3.0?

Oh I did not know that.
@kaiguo Kai Guo FTE, @kmahone Keith Mahoney FTE : Is there any benefit in working on this issue right now/ before WinUI 3.0?

I didn't know we had that either...
I don't see much immediate benefit doing it now compare to doing it later when 3.0 is ready. So we should probably just do it altogether after WinUI 3.
Closing the issue since it's covered by #975.


add schema to column_names

Closes #14121

Yes, I tested locally and it worked (even without the patch... 🤷♂ )

It worked fine in acceptance!


Version bump

Summary
We updated the google_drive version requirement but neglected to bump the version number.

@chopraanmol1 Can I get this merged in? When pulling down the gem with spec.add_runtime_dependency "roo-google" I am pulling down a version of the gem without the update to the google-drive gem

@domenickpowers  I'll be publishing a new release by the weekend. Thank you for reminding me regarding this.

@chopraanmol1 Any update here?

@domenickpowers I just realized that I only have access to publish roo gem on rubygems.org as of now. Just hold on for a couple of days.


hybris: use x86-64 for amd64 instead of x86

HYBRIS_LD_LIBRARY_PATH and other vars fail to set properly because it is looking for /system/lib instead of /system/lib64.
This was the root cause of that issue.

Thanks!


infinite loops in console lock entire game

minimal example:
while true do end

i don't have any good ideas yet how to approach this. here is a bad one:
run the code on another thread and await the thread on a timer. by itself, this would prevent use of love primitives and other non-queue-serializable data. to get around this, use an environment table with a metatable that sends any field access back to the other thread through a queue. (logistics???)

addressed but not resolved by https://github.com/HeladoDeBrownie/Nexus/commit/7ba546f33aeb479e3ec6faadc94df385bc36e014

actually i just learned that love used to have a method to stop a thread, but no longer does. so it seems there is no possible way to stop runaway user code other than using a library that specifically implements this functionality

as far as i can tell from research, this issue is intractible without reimplementing an entire lua runtime. dropping this issue


[Fix #719] Allow using arrays, variables and method in receive_message_chain

Array with multiple elements is a valid way to specify a message chain.
Also, in case a variable (or send node) is used, we cannot know if it doesn't evaluate to an array with multiple elements, so we should not report those.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

I don’t see the documentation mention anything about passing an array to receive_messge_chain: https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/message-chains

I didn't find documentation as well, so I've tested manually. receive_messge_chain([:one, :two) works exactly the same as receive_message_chain(:one, :two).
Fixed the example wording


fix(scss): make $theme-color-config writable from user's custom scss file

By adding the !default flag as well as $global-font-family, etc., we allow $theme-color-config to be writable from the user's custom scss file.

@olOwOlo This fix should improve user-friendliness. Could you please check?

@olOwOlo Could you please check?


[BUG] Opensuse Tumbleweed show error on exit after toggle terminal

Pyprland version
2.4.0
Describe the bug
Opensuse Tumbleweed show error on exit after toggle terminal
To Reproduce
Steps to reproduce the behavior:

pipx install pyprland
pypr
pypr toggle term
See error

Expected behavior
exit the toggle terminal without error
Configuration (provide following files/samples when relevant):
Fail to parse version tag "0.41.2"
Traceback (most recent call last):
  File "/home/mjcc/.local/share/pipx/venvs/pyprland/lib64/python3.11/site-packages/pyprland/plugins/pyprland.py", line 39, in init
    self.__set_hyprland_version(version_str[1:], auto_increment)
  File "/home/mjcc/.local/share/pipx/venvs/pyprland/lib64/python3.11/site-packages/pyprland/plugins/pyprland.py", line 95, in __set_hyprland_version
    split_version = [int(i) for i in version_str.split(".")[:3]]
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/mjcc/.local/share/pipx/venvs/pyprland/lib64/python3.11/site-packages/pyprland/plugins/pyprland.py", line 95, in <listcomp>
    split_version = [int(i) for i in version_str.split(".")[:3]]
                     ^^^^^^
ValueError: invalid literal for int() with base 10: ''
Fail to parse version information: {'branch': 'openSUSE', 'commit': '0000000000000000000000000000000000000000', 'dirty': False, 'commit_message': 'Built for x86_64-suse-linux', 'commit_date': 'Thu Jan 01 00:00:00 1970', 'tag': '0.41.2', 'commits': '-1', 'flags': []}

Additional context
openSUSE Tumbleweed
Linux 6.9.9-1-default
zsh 5.9
Hyprland (Wayland)
kitty 0.35.2

Hi! Can you show me the output of hyprctl -j version please?

Hi! For some reason the value for the key "tag" does not include the first letter "v"
>hyprctl -j version
{
    "branch": "openSUSE",
    "commit": "0000000000000000000000000000000000000000",
    "dirty": false,
    "commit_message": "Built for x86_64-suse-linux",
    "commit_date": "Thu Jan 01 00:00:00 1970",
    "tag": "0.41.2",
    "commits": "-1",
    "flags": []
}


[FEAT]: Learning languages / vocabulary with spaced repetition

Hi,
I'm not a native english speaker, but I read a lot of english stuff. To train my vocabulary with spaced repetition it would be nice, to use this plugin.
To describe a possible solution I use the following example sentence, in which I looked up the verb "skimming":
"Learning doesn’t happen from skimming through a book or remembering enough to pass a test."
After looking up the word skimming and the german translation "überfliegen" I could use a new separator, for example ";;;" to indicate that the following word is the translation, which then would look like this:
"Learning doesn’t happen from skimming;;;überfliegen through a book or remembering enough to pass a test."
The flashcard then would insert "überfliegen" at the place of "skimming" and I have to try to recall the right english word for "überfliegen" :)

Hi
Have you tried using the plug-in's "cloze" feature?
It would show the question as:

After pressing "show answer", the following would be displayed:

The text for this is:
Learning doesn’t happen from skimming {{überfliegen}} through a book or remembering enough to pass a test.
Note that in settings you need to enable one of the options:

Cheers
Ronny


None or zero Visitors answer still shows Visitor section complete interstitial

Expected behaviour

Visitors complete interstitial only shown when there are more than 0 visitors.

Actual behaviour

Visitors complete interstitial is shown even when there are 0 visitors or skipping forward and not answering the number of visitors question.

Steps to reproduce the behaviour

Start household questionnaire
Skip the Household and Accommodation via navigation
Complete Household and Accommodation section
Observe that the Visitors complete interstitial is shown incorrectly.

Technical information
Browser
Chrome
Operating System
macOS
Screenshot
N/A

Because the interstitial page lives outside of the vistors repeating group it will always hit the 'You have now completed the visitors section' interstitial page. We don't support a binary repeat rule where you will either not repeat or show once so we cannot solve this problem in the same way the repeating of the visitors section is skipped.
After discussing with @ajmaddaford the possible options are:

Implement a repeat rule which will only show the visitors completed group once when overnight visitors answer is 1 or more or not at all when overnight visitors answer is 0.
Implement skip conditions at the group level so that the visitors sections is skipped when overnight visitors is set to 0

Option 2 seems like it makes sense since that we are simply trying to skip a group

This still occurs if on the first page you jump straight the "Household and Accommodation" section and start filling it in; at the end you see the visitors complete interstitial then are routed back to the Who Lives Here? I'm marking this as P4 as it's not the most likely usage scenario and doesn't break anything.

Actually the same thing occurs if you change the number of visitors; but that really is a P4 (or 5 if we had it!)

Similar for going back and changing your household composition (adding people) if the group was previously completed it still gets a green tick, think we'll accept that behaviour for now.


fix(plugin-chart-handlebars): Update webpack/babel config to fix build/runtime warnings/errors

SUMMARY

This PR is an attempt to fix the Handlebars viz plugin, which currently raises both build and runtime errors, by updating Webpack and Babel config.
Build warning
Webpack would emit the following warning several times during build: require.extensions is not supported by webpack. Use a loader instead..  The source listed was various lines in ./node_modules/handlebars/lib/index.js.  According to the Handlebars GH project, this is due to the package not correctly indicating which build is client-side-compatible.  A fix was merged, but it hasn't made it into an NPM-published release.  A workaround was recommended by this comment and is included in this PR.  This issue doesn't seem to be related to the runtime error and this fix just clears the build warning.
Runtime error
When rendering a Handlebars chart in Explore, the following error appears: ReferenceError: exports is not defined.  An inspection of the console shows that the culprit is the just-handlebars-helpers package's references to exports, as is standard in the CJS module system.  After some digging, I found this comment that makes me think the problem is a CJS/ESM incompatibility: our Babel setup assumes all JS is ESM-style modules and therefore doesn't transpile CJS-style require and module.exports statements into import/export statements, and Webpack assumes Babel output is ESM-style modules and doesn't provide global require/module.exports that you'd find in a CJS environment, causing this error (just-handlebars-helpers seems to be CJS-only).  As suggested by the comment, I changed sourceType to unambiguous so it stops assuming modules are ESM-style and instead makes a guess based on the presence of require/module.exports.  This seems to fix the issue, though I don't have a great sense of what else this might affect.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Run webpack and ensure the aforementioned build warnings are gone.
Try creating a Handlebars chart and ensure the runtime error doesn't show up.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@codyml When I looked into the dependency that Just Handlebars Helpers, it said that A lightweight package with common Handlebars helpers. from the npm registry description. It just provided some shortcuts for the Handlebars, so it's not a core function for the Handlebar. This plugin was introduced from PR.
IMO, I would rather remove the Helper than change the global Bable setting to fit a plugin's configuration.

@codyml When I looked into the dependency that Just Handlebars Helpers, it said that A lightweight package with common Handlebars helpers. from the npm registry description. It just provided some shortcuts for the Handlebars, so it's not a core function for the Handlebar. This plugin was introduced from PR.
IMO, I would rather remove the Helper than change the global Bable setting to fit a plugin's configuration.
What do you think about this? @evans @villebro

I believe there's actually an open PR out there to do exactly this: #21143 (the discussion there is pretty similar to what you're proposing). I think this comes down to whether or not we feel maintaining these helpers ourselves is something we want to do or not. Normally I'd say let's just use the npm package, but if using the upstream package requires us to do hacky workarounds, then I'm not so sure.

Heya @zhaoyongjie / @villebro
It's true, I don't like the idea of copying over all the internals of that helper module into our codebase for a couple of reasons:

It feels "gross" from a copyright/licensing/plagiarism perspective
We would lose the benefit of any updates/expansions that the other project takes on.

So, I'd like to use this just-handlebars-helpers module if possible. I'm also open to competitors, but nothing obvious turns up except for this one which seems unmaintained.
I'll open up an Issue on the just-handlebars-helpers repo to see if they would be willing to create an EJS version. Otherwise, if we can change the babel config for a specific file path, that'd be a little more surgical than this PR currently is.
However, the big question I have is: do we see any realistic risk or downslides to this change in babel config? Maybe we can approve/merge this until the day that just-handlebars-helpers adds EJS (maybe we write a PR there!) at which point we can lock this back down.

@zhaoyongjie @villebro @rusackas If it helps, I just pushed a diff that overrides the Babel sourceType for just the package in question rather than the whole project.

@zhaoyongjie @villebro @rusackas If it helps, I just pushed a diff that overrides the Babel sourceType for just the package in question rather than the whole project!

Thanks! We spent a few minutes looking for a way to do that, but didn't see one!

Total side note: Apologies to Evans, who gets pinged by this project all the time, and is not me ;)

I really wanted to say sorry to Evan, and buy him a drink.

🏷 preset:2022.41


AMD Ryzen chips

AMD Ryzen chips are out and they feature a much higher IPC yet the FAQ still bashes on AMD for having bad IPC and being much slower than Intel, but it's not true for the current gen.

I think the bigger problem here is that the FAQ as a whole is heavily dated and focused more around the 4.0 era of Dolphin, where the emulator was the slowest it had ever been. I imagine CPU requirements for more demanding games have gone down drastically as well, so maybe it'd be worth mentioning more than just top of the line i7s and overclocked i5s from Q2 2013. More recent dual cores CPUs like most of the i3 lineup and the Kaby Lake Pentium chips are able to handle a lot of games very well.


Requirements for Domain Connectivity are not up to date

Hello,
The requirements section of this page needs to be updated. The Azure Virtual Desktop service can be joined directly to Azure Active Directory without the need for AADDS or a Windows AD with AD connect.
I believe this bullet point needs to be updated:
A Windows Server Active Directory in sync with Azure Active Directory. You can configure this using Azure AD Connect (for hybrid organizations) or Azure AD Domain Services (for hybrid or cloud organizations).
A Windows Server AD in sync with Azure Active Directory. User is sourced from Windows Server AD and the Azure Virtual Desktop VM is joined to Windows Server AD domain.
A Windows Server AD in sync with Azure Active Directory. User is sourced from Windows Server AD and the Azure Virtual Desktop VM is joined to Azure AD Domain Services domain.
An Azure AD Domain Services domain. User is sourced from Azure Active Directory, and the Azure Virtual Desktop VM is joined to Azure AD Domain Services domain.
There is no need for a sync between a Windows Server AD and AAD. AAD will be sufficient on its own. Furthermore, from what I understand, registration would allow GPO to be applied using administrative templates.
Could you please look into? Alternatively, could you provide feedback if I have missed something here and am incorrect in what I have said.
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2eeca14-80ef-c0b4-2719-80ceb286ba3d
Version Independent ID: b7d3df23-3158-2807-eecc-73e7230c2033
Content: What is Azure Virtual Desktop? - Azure
Content Source: articles/virtual-desktop/overview.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@arun-mittal
Thanks for your feedback! We will investigate and update as appropriate.

@arun-mittal
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@
Can you please check and add your comments on this doc update request as applicable.

Thanks for the feedback. This information has been updated and reworked into a separate prerequisites article that should be available later today.
#please-close


Add transcritical versions of exisiting subcritical heat pumps

Description of task
The model data base already has a lot of subcritical heat pump processes. The task in this issue is to create more transcritical versions of the existing heat pump models. This mainly concers changing the condenser to a normal heat exchanger and setting the heat output pressure.
Necessary steps

Create copy of existing heat pump model class
Change the setup to allow a transcritical process
Create corresponding input parameter file
Create topologie flow sheet as .svg file for light and dark mode
Add the class to the hp_models dictionairy of variables.py

Issue resolved with PR #17


flutter doctor -v  has error

This is not a bug with flutter doctor, see https://github.com/flutter/flutter/issues/6207 for more info


Local video not working on iOS

Hi,
We are using callComposite without react. The integration was pretty straightforward but after testing on different devices, we realize that the local video is not working on iPhone or iPad. It works fine on Android. How could we fix this?
Thanks,
Rémi

Closing as it is a dupe.


Incorrect dataflow on clamped value

Given the following MLIL:

current_function.medium_level_il.ssa_form[509].get_possible_reg_values('ecx') should result in a value set of 0-0x20, but it instead results in <undetermined>. I've passed the bndb to Brian, and he's pretty sure that it's related the lonely goto.

Any movement on this one?

Yes, it's been assigned.

I'm not sure if this is a change since I filed this issue, but on 1.1.1021-dev, I noticed the following output:
>>> current_mlil.ssa_form[446].get_possible_reg_values('ecx')
<const 0x20>
>>> current_mlil.ssa_form[447].get_possible_reg_values('ecx')
<unsigned ranges: [<range: 0x0 to 0x20>]>
>>> current_mlil.ssa_form[511].get_possible_reg_values('ecx')
<undetermined>

Where 446 corresponds to 444 in the above image, 447 is the lonely MLIL_GOTO, and 510 corresponds to 509 in the image.
I guess it's the 445 @ 00000000 that is messing up dataflow?

Getting close to a solution for this. I'm experimenting with propagating the branch dependence of a synthetic goto which results in the correct behavior.

Ended up adding contextual branch sensitivity for dataflow. Fixed in build 1.1.1072-dev.


Kobo report layers not loading

On both local and deployed instances for Cambodia, kobo form layers are no longer loading after authenticating. The API returns an error. See screenshots captured from this deployment https://prism-khm-internal-demo.surge.sh/

I was able to fix this with a restart of the API. But we should investigate how to avoid this error.
There was some error with a database transaction. Here is the additonal context:
api        | ERROR:app.auth:Can't reconnect until invalid transaction is rolled back. (Background on this error at: https://sqlalche.me/e/14/8s2b)


Making HTTP calls to local InferenceGraph

Hi folks,
I'm following this guide to setup the iris sequence inference graph. My graph is running and I can make requests to its inference services succesfully, but I can't figure out how to make an http request to the graph itself. I am developing locally and would like to just use port forwarding.
The provided guide uses curl http://model-chainer.default.<IP_ADDRESS>.sslip.io -d @./iris-input.json, but I don't have DNS setup. Could someone point me to how to achieve the same using the Ingress gateway with host header?
I tried the below without success.
curl -v -H "Host: ${SERVICE_HOSTNAME}" http://${INGRESS_HOST}:${INGRESS_PORT} -d @./iris-input.json
Many thanks! Appreciate it.

First do port-forwarding like this:
kubectl port-forward --namespace istio-system svc/${INGRESS_GATEWAY_SERVICE} 8080:80
# start another terminal
export INGRESS_HOST=localhost
export INGRESS_PORT=8080```

Then, make a call:
curl -v -H "Host: ${IG_NAME}.${NAMESPACE}.svc.cluster.local" http://localhost:8080/v1/inferencegraphs/${IG_NAME} -d @./input.json -v

Many thanks @rachitchauhan43 ! Didn't see the /v1/inferencegraphs/{name} api documented anywhere so that's super useful!
 I've attached my terminal output below, any idea what it could be?
I'm running kserve installed with quick_start.sh from master, minikube 1.26 (also tried kind, same outcome). Otherwise I'm just using the sequence.yaml file from the guide linked in the previous post.
istion ingress gateway
(base) michal@gala1-G482-Z54-00:~/kservekubectl get svc istio-ingressgateway -n istio-system
NAME                   TYPE           CLUSTER-IP     EXTERNAL-IP   PORT(S)                                      AGE
istio-ingressgateway   LoadBalancer   <IP_ADDRESS>   <pending>     15021:32138/TCP,80:32011/TCP,443:30779/TCP   24m

Status of the inference graph and its isvcs
(base) michal@gala1-G482-Z54-00:~/kserve$ kubectl get pods -n dag
NAME                                                              READY   STATUS    RESTARTS   AGE
model-chainer-00001-deployment-565c94f6df-9mfbl                   2/2     Running   0          11m
sklearn-iris-predictor-default-00001-deployment-cb9656b89-rsmk9   2/2     Running   0          14m
xgboost-iris-predictor-default-00001-deployment-5c544fd775h9s2p   2/2     Running   0          14m

setting env vars
export INGRESS_HOST=localhost
export INGRESS_PORT=8080
export IG_NAME=model-chainer
export NAMESPACE=dag

Posting input to the endpoit
(base) michal@gala1-G482-Z54-00:~/kserve$ curl -v -H "Host: ${IG_NAME}.${NAMESPACE}.svc.cluster.local" http://localhost:8080/v1/inferencegraphs/${IG_NAME} -d @./input.json
*   Trying <IP_ADDRESS>:8080...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
> POST /v1/inferencegraphs/model-chainer HTTP/1.1
> Host: model-chainer.dag.svc.cluster.local
> User-Agent: curl/7.68.0
> Accept: */*
> Content-Length: 86
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 86 out of 86 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< date: Wed, 02 Nov 2022 13:37:04 GMT
< server: istio-envoy
< connection: close
< content-length: 0
<
* Closing connection 0

My other terminal running the port forwarding only logs "Handling connecting for 8080" whenever I try to post to the IG.
Would be grateful for any pointers!

I found a solution, turns out my IG HOSTNAME doesn't use the".svc.cluster.local" domain, but ".example.com".
export IG_HOSTNAME=$(kubectl get ig model-chainer -n dag -o jsonpath='{.status.url}' | cut -d "/" -f 3)
curl -v -H "Host: ${IG_HOSTNAME}" http://${INGRESS_HOST}:${INGRESS_PORT}/v1/inferencegraphs/model-chainer -d @./input.json

This now correctly outputs {"predictions": [1.0, 1.0]}
Thanks for your assistance!

@MichalPitr : Can you close this if this is resolved for you ?

@rachitchauhan43 Yes, closing!


Great work! Do you mind adding sieve-cache hashtag?

Great work! Do you mind adding the sieve-cache hashtag?

Done. Added.


Make the reported luminosity be the luminosity only of the atmosphere

Currently, the   - luminosity = reported under Calculate multi-photometry and plotted in the corner plot (as log(L/LSun)) is the (reddened) photospheric luminosity PLUS the integrated luminosity of the additional blackbody.
I would like to suggest that the much more useful quantity is the atmospheric luminosity only; the (additional) blackbody is usually not an earnest fit that is reliable enough to be integrated, especially if no far-infrared data or so are available.
species already conveniently shows L_disc/L_atm in the corner plot to let the user check the importance of the blackbody, which is very nice. However, the main output of interest is the luminosity of the atmosphere, I would say, especially in the light of comparing the results from different atmospheric models.
The less obvious question is whether to report the de-reddened luminosity and/or the "empirical" one that comes from fitting a reddened atmospheric model. Both are useful: L_bol,empirical for comparing between observations and/or models, and L_bol,deredded for use with evolutionary models (assuming that the extinction is exterior enough to the planet for it not to affect its cooling, which is ok to first order or much better, e.g. for extinction really from the ISM).
Thanks to your help, I do have a script to compute the intrinsic and the de-reddened luminosities :nerd_face: but maybe it would be useful in general :slightly_smiling_face: and if the calculation were done automatically!

(Thanks for adding the label.) This would affect also in a positive way the luminosity that can easily be added to the legend of plot_spectrum through leg_param for an easy overview. I guess luminosity should be renamed to be explicit.
And on a related note, it would be nice to be able to just add e.g. mass or, especially, luminosity to the legend entry, without however having to set all other parameters, especially since they are different for most model families. The current default settings are great and it would be nice to just have the option to add luminosity/mass/Bayesian evidence/… Thanks if this is not too much trouble to implement!

Thanks for the suggestion! I have changed luminosity to log_lum, log_lum_atm, and log_lum_disk. You can use get_parameters() from ReadModel to select the model parameters and then add e.g. mass to create a leg_param list.

Thanks a lot! Are these quantities de-reddened (i.e., the intrinsic total and partial luminosities) or the integrated reddened ones? I am guessing the latter. There would still be some use, especially in the corner plot, for the dereddened atmospheric luminosity especially, which of course by definition is simply L_atm,dereddened = 4 π σ Teff⁴.

These are all intrinsic luminosities!

Closing this issue since it has been resolved


[CTS] Object tracker maps need to be per device

Running CTS dEQP-VK.api.object_management.multithreaded_per_thread_device.device_memory_small (and many other multithread tests), Object tracker is confusing memory allocations and frees on one device with those on another due to VkDeviceMemoryMap being layer global rather than per device. This is probably true for the other global maps as well.  Although this has been the case for some time, we think that changing unique_objects' handle allocation scheme has exacerbated the problem.

This has been addressed through a change to the unique_objects layer.  In the near future, object_tracker will undergo changes to move data into per-device and per-instance incarnations to be consistent with other layers.

This has been implemented.


module 'tika' has no attribute 'initVM' and ImportError: cannot import name 'parser'

I've followed the installation instructions, using pip in a virtual environment:

python3 -m venv venv
source venv/bin/activate
pip install tika
wget -O /tmp/tika-server.jar http://search.maven.org/remotecontent?filepath=org/apache/tika/tika-server/1.23/tika-server-1.23.jar
wget -O /tmp/tika-server.jar.md5 http://search.maven.org/remotecontent?filepath=org/apache/tika/tika-server/1.23/tika-server-1.23.jar.md5

And then setup the environment variables:
TIKA_VERSION=1.23
TIKA_CLIENT_ONLY=True
TIKA_PATH=/tmp/tika-server.jar
TIKA_JAVA=java
PYTHONIOENCODING=utf8

I've also tried to add the jar in the current working directory and use this instead:
TIKA_VERSION=1.23
TIKA_JAVA=java
TIKA_SERVER_JAR="file:////tika-server.jar"
PYTHONIOENCODING=utf8

When using the example script:
import argparse
import tika
tika.initVM()
from tika import parser

ap = argparse.ArgumentParser(prog='extractor',
                        description='Extract Text from PDF programmatically')
ap.add_argument("--input", required = True, help = "Path to the PDF file.")
args = vars(ap.parse_args())
print("WARNING: export PYTHONIOENCODING=utf8")

parsed = parser.from_file(args['input'])
print(parsed["content"])

I get module 'tika' has no attribute 'initVM' and when I remove the tika.initVM() I get ImportError: cannot import name 'parser'.

If you are in a local checkout of tika-python when running it, you will get module import errors. Try cd'ing out of the Git checkout (if you are running this from that dir) and see if that fixes it @agiokas-dbg

Was this issue ever resolved? I am still having this issue if installing with pip

I never managed to solve this.
On Wed, 6 May 2020 at 17:18, aabid<EMAIL_ADDRESS>wrote:

Was this issue ever resolved? I am still having this issue if installing
with pip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chrismattmann/tika-python/issues/277#issuecomment-624746705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANBMA5LU4RSWMDUR42Q6ARTRQGEWHANCNFSM4KHGB2TQ
.

@aabid0193 @agiokas-dbg can you find your $PYTHON site-packages directory and then rm -rf tika* out of there? Try it on a fully fresh Python install. the .initVM() is likely related to the parser module not found. For whatever reason your tika library isn't being loaded or installed correctly.
FWIW, .initVM is no longer needed and only  left in for back compat.


Add datacenter to Consul service discovery logs

Signed-off-by: Conor Evans<EMAIL_ADDRESS>In a federated Prometheus scenario, one may well be scraping the same service in several datacenters. Knowing to which datacenter an error log message refers would be helpful.
I don't see any tests that could be modified.
closes #9667

Can we have in func (d *Discovery) getDatacenter() error { the following instead:
d.logger = log.With(d.logger, "datacenter", dc)

Yeah, that's nicer, thanks @roidelapluie - suggestion applied.

thanks, this now shows up on every log line:
ts=2021-11-08T08:33:28.280Z caller=consul.go:491 level=debug component="discovery manager scrape" discovery=consul datacenter=dc1 msg="Watching service" service=consul tags=


ISSUE-624 : Give executable permissions to bootstrap scripts

I've noticed the following scripts do not have executable permissions.

bin/registry
bin/registry-server-start.sh
bootstrap/bootstrap-storage-initenv.sh
bootstrap/bootstrap-storage.sh

I would be nice to be able to run these files without manually giving executable permissions.

Fixes #624

@suminb thanks for the PR. Can you set the same permissions to /conf/registry-env.sh as well ?

Done. However, I found other *.sh files without executable permissions.
$ find . ! -perm -u+x -name "*.sh"
./docker/images/kafka/kafka-service.sh
./docker/images/registry/start-registry.sh
./docker/kdc-registry.sh
./webservice/target/node/node_modules/npm/test/packages/npm-test-ignore/test.sh
./webservice/target/node/node_modules/npm/test/packages/npm-test-files/test.sh
./webservice/target/node/node_modules/npm/scripts/release.sh
./webservice/src/main/resources/node_modules/react-breadcrumbs/demo/surge.sh
./webservice/src/main/resources/node_modules/react-breadcrumbs/demo/run.sh
./webservice/src/main/resources/node_modules/coa/lib/completion.sh
./webservice/src/main/resources/node_modules/sourcemapped-stacktrace/demo/make.sh
./webservice/src/main/resources/node_modules/JSV/jsdoc-toolkit/jsrun.sh
./webservice/src/main/resources/node_modules/object.assign/test.sh

I would assume packages under node_modules directories are managed by npm so we don't have to worry about them. But should we also give executable permissions on script files under the docker directory?

@suminb Yeah, the docker scripts need the execute permissions. We don't need to set executable permissions for scripts run by npm.

All done.


Can't work with C# WinUI in Desktop projects.

Describe the bug

Can't create new Blank App(WinUi in UWP) in either C# or C++.
Unable to sucessfully open WinUi-3-Demo DemoBuildCs.
Dialog reports:
The expression "[Microsoft.Build.Utilities.ToolLocationHelper]::GetPlatformSDKLocation(",10,0.18362.0)" cannot be evaluated. Parameter "targetPlatformIdentifier" cannot have zero length.

Steps to reproduce the bug
Steps to reproduce the behavior:

Make fresh install of Visual Studio 2019 and 2019 Preview.

Install WinUI.ProjectTemplates.vsix.

Start Visual Studio 2019 Preview.

Select C# WinUi in Desktop project.

Download WinUi-3-Demo

Open DemoBuildCs.

Expected behavior

File Opens normally without errors.
Screenshots

Version Info

NuGet package version:

Unknown, can't seem to get that far.

Windows app type:

UWP
Win32

NO
YES

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)
YES

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
YES

Xbox

Surface Hub

IoT

Additional context

Did you install Universal Windows Platform Development?

Yes, I sure did. With a whole lot of other stuff too.

This is caused by Visual studio version 16.8, it is incompatible with Winui3 preview 2. The solution is to either use VS16.7 (the non preview version) or wait for Winui3 preview 3 which will support it and be here soon TM


Set hadoop ldap search depth(HADOOP-12291)

This PR adds required configuration for HADOOP-12291

LGTM.  Great to have it deployed!


Mismatch between __init__ arg name and matching attribute results in InternalError in 3.10 pattern matching

Environment data

Language Server version: v2022.8.20
OS and version: macOS Monterey 12.4
Python version: 3.10.5

Code Snippet
class Token:
    def __init__(self, type_: str) -> None:
        self.type = type_

t = Token(type_="TEST")

match t:
    case Token(type="TEST"):
        pass
    case _:
        pass

Repro Steps
EDIT: set pylance to strict
Try linting the code snippet.
The original error occurred in Lark library (https://github.com/lark-parser/lark/issues/1180).
Expected behavior
Either a regular typing error or no error at all.
Actual behavior
An internal error that breaks the typing completely, even if I add # type: ignore
Logs
An internal error occurred while type checking file ".../bug_example.py": TypeError: Cannot read properties of undefined (reading 'length')
    at Object.isPrivateName (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/symbolNameUtils.ts:16:17)
    at O._conditionallyReportPrivateUsage (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/checker.ts:3435:47)
    at O.visitName (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/checker.ts:1334:14)
    at O.visitNode (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:261:29)
    at O.walk (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:98:37)
    at O.walk (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/checker.ts:280:19)
    at forEach (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:107:22)
    at Array.forEach (<anonymous>)
    at O.walkMultiple (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:105:15)
    at O.walk (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:100:18)
    at O.walk (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/checker.ts:280:19)
    at forEach (.../.vscode/extensions/ms-python.vscode-pylance-2022.8.20/dist/pyright-internal/src/analyzer/parseTreeWalker.ts:107:22)
    at Array.forEach (<anonymous>)```

Oh, my bad, I've forgotten about setting pylance to strict.
The error should look like that:

Thanks, I'm able to repro. This will be fixed in the next release.

Here are some additional details about this bug for those who are interested.
Python 3.10 introduced the first so-called "soft keywords" to the Python grammar: match and case. These are treated as keywords when they're used in certain contexts but as identifiers in all other situations. Contrast that with "hard keywords" like def and class which are illegal identifiers.
In draft PEP 695, I proposed to add another soft keyword to Python 3.12: type. The latest version of pyright (and therefore pylance, which builds on pyright) includes a prototype of the draft PEP.
This bug was caused by some incorrect logic in pyright's parser when dealing with soft keywords that appear within named arguments for class patterns. You will see the same problem if you use match, case, or type.

This issue has been fixed in version 2022.8.41, which we've just released. You can find the changelog here: CHANGELOG.md


Stuck at yum install some package for lcfs storage driver

Hi,
When i use lcfs as docker storage driver, yum install some package will be stuck. I change devicemapper, start same image, install same package, it can install successfully. Why?  I am not sure lcfs is available and feasible?
# yum install unzip
Loaded plugins: fastestmirror, ovl
Repodata is over 2 weeks old. Install yum-cron? Or run: yum makecache fast
Resolving Dependencies
--> Running transaction check
---> Package unzip.x86_64 0:6.0-19.el7 will be installed

# lsb_release
LSB Version:	:core-4.1-amd64:core-4.1-noarch
Distributor ID:	CentOS
Description:	CentOS Linux release 7.4.1708 (Core)
Release:	7.4.1708
Codename:	Core

# docker info
Containers: 5
 Running: 1
 Paused: 0
 Stopped: 4
Images: 5
Server Version: 18.06.1-ce
Storage Driver: portworx/lcfs
 Build Version: 1.0
 Library Version: 1.0
Logging Driver: json-file
Cgroup Driver: systemd

I test docker commit, first it can commit successfully.  Once commit again, lcfs crash.  As if  lcfs is not stable.
<EMAIL_ADDRESS>~]# time docker commit 4eb83e096571 xzy-test/smallfile:lcfs-3.0
sha256:91abd5dbbfa5d398e93f71f74a629a15c8e2da05957729d2df9dbe84d0eaf4d7

real	0m5.045s
user	0m0.131s
sys	0m0.029s
<EMAIL_ADDRESS>~]# time docker commit 4eb83e096571 xzy-test/smallfile:lcfs-4.0
Error response from daemon: failed to write digest data: open /lcfs/docker-storage/image/portworx/lcfs/imagedb/content/sha256/.tmp-218f0970c816d513d59e72fd1fa7e754c80204667a890052281eafd94bb16b39697688369: no such file or directory

real	0m4.972s
user	0m0.122s
sys	0m0.011s


Parsing bytes-like objects directly

Hi,
I've been experimenting with llmsherpa with a small streamlit app to which I upload PDFs, and I saw that I can't use the uploaded files (which are bytes-like) directly.
I have code to handle that directly, though I wonder if this feature is needed by anyone else... If there's interest I can open a PR.

Hi @moshewe,
That'd be a great addition! Please open a PR.

Thanks for the contribution @moshewe. Closing this PR.


Add tests for UpdateRole

Summary
Ref #3673

Add tests for UpdateRole
Introduce InviteService and RoleService for code separation and easier testing
Rename invite package to invites for consistency

I will add tests for AssignRole and RemoveRole in a later PR to keep the changes smaller.
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.687% (+0.9%) from 52.829%
when pulling 46eaffa30fc966da36c0e9e4a715a386e3fbe049 on eleftherias:3673-role-tests
into e25716e60b96af81388f2661a8bdc62b64499492 on stacklok:main.


Architecture Artifacts

Develop and provide architecture artifacts consisting of:

High level architecture diagrams
Data Flows by transport and format
Data Security and retention policy enforcement components
Zero Trust requirements
criteria (?? clarification needed)

(see RFQ C.6)
Tasks

[x] Create a high-level architecture diagram (see Lucid Architecture for ETOR MVP and the Future)
[x] Create a data flow diagram (including transport mechanisms and data format) - @halprin
[x] Document data security and retention policy enforcement components - @halprin
[x] Document Zero Trust requirements - @halprin
[x] Obtain feedback and buy-in on plan to integration with ReportStream Core - @halprin
[x] Document our needs if we're going to be in a monorepository with ReportStream. - @halprin
[x] Revise and refine the architecture artifacts.
[x] Document options for points of integration with ReportStream Core

Rough draft of the "Create a data flow diagram (including transport mechanisms and data format)" task is done.

Delivered 12-24-2022


comparison of different sequence parallel methods

Hi,
Have you compared multiple sequence parallel methods listed in the project? In terms of memory and training speed. Thank you!

Based on my trial with 8XA100, Ulysses is (around 15%) faster than ring-attn.


Issue #61

Changes made

Allow clicking on activity entries to bring up an editor
Allow for timestamp updating and deletion of activity entries
Allow for different sized modals
Misc: add build artifacts to gitignore
Misc: change activity text to be in proper title case
Misc: fix small slog missing key warning

All your comments looks reasonable to me. I'll work on changes sometime in the next ~24h

Hmm, I actually can't reproduce that. It just lets me set it without error.

If you want to write a follow up issue I'm fine with that, but I'd need more info to diagnose. I've added a little bit of client validation in the meantime, which can be bypassed, but if people really want to break the application like that, I say let them.