Improvements for 1.0

Hi,
Thanks for your work on this Python module.
This pull request proposes a few changes :

it fixes some bugs I have encountered (e.g. when handling Directives at the root of the config file)
it also grabs recent modifications from users rjhornsby and rubentsirunyan
it adds newer features (such as remove_node and add_nested_tags)
it uses a more object-oriented syntax (see the changes on the README) and renames a method to be more self-explicit
...thus, it also breaks the API (but I think it is worth it :-) ). That is why I propose a new major version number (say, 1.0)

Thanks

Hi,
code is working really nice. Parsing is much easier right now.
One point I see (not related exactly to this PR, but still), when "&" exist inside comment string, parsing failed, eg:
# Listen & NameVirtualHost resources in module
error:
File "...\venv37\lib\site-packages\pyparsing.py", line 4182, in parseImpl     raise maxException pyparsing.ParseException: Expected {Group:({"</" W:(ABCD...) ">" LineEnd}) ^ Group:({"<" {{W:(ABCD...) <SP><TAB><CR><LF> W:(ABCD...) <SP><TAB><CR><LF> <= | >= | == | != | < | > | ~ <SP><TAB><CR><LF> W:(ABCD...)} | {W:(ABCD...)}...} ">" LineEnd}) ^ Group:({W:(ABCD...) Suppress:(<SP><TAB><CR><LF>) W:(0123...) LineEnd}) ^ Group:({{"#" {W:(ABCD...)}... LineEnd} ^ {"#" LineEnd}}) ^ Group:(LineEnd)}, found '&'  (at char 9), (line:1, col:10)
Any ideas how to deal with it?


Option to disable delaySendingUntilShutdown in HttpTransport

It would be great to have a config option to disable delaySendingUntilShutdown in HttpTransport because in some scenarios is most reliable to get rid of all this "async" black magic in PHP or just let the developer decide.

Sounds like it'll miss some notifications, we're talking about PHP you know ;)

We are already in the process of fasing that out, see: https://github.com/getsentry/sentry-php/blob/c4359c244b903212d8e2e23755c1087c5f362ff2/src/Transport/HttpTransport.php#L84-L86.
You can use the client builder decorator to register your own transport or set that flag if you need it today.

https://docs.sentry.io/platforms/php/laravel/#decorating-the-client-builder
https://docs.sentry.io/platforms/php/#transport


Clean up non-functional CloudEvents Metrics in Reconciler for Deprecated CloudEvents

Changes
This commit cleans up the CloudEvents Metrics which are no longer functional with the removal of CloudEvents PipelineResources, and also the CloudEvents field of the TaskRun Status API is also deprecated and not moved to v1.
/kind cleanup
fixes: https://github.com/tektoncd/pipeline/issues/6826

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/assign @afrittoli @dibyom @lbernick

/lgtm
I think we could also remove some of the unused cloudevents code: https://github.com/tektoncd/pipeline/blob/f0f5646fffccbcdb836363105b636b294fd51a65/pkg/reconciler/events/cloudevent/cloud_event_controller.go#L38-L52

/lgtm
I think we could also remove some of the unused cloudevents code:
https://github.com/tektoncd/pipeline/blob/f0f5646fffccbcdb836363105b636b294fd51a65/pkg/reconciler/events/cloudevent/cloud_event_controller.go#L38-L52

Agreed! as put at https://github.com/tektoncd/pipeline/issues/6826#issuecomment-1591578643, this current PR is opened to unblock v1 swap and as pointed these could also be removed in a followup PR.

/retest
test: TestExamples/v1/taskruns/steptemplate-env-merge with
Could not get logs for pod steptemplate-env-merge-756np-pod: container "step-foo" in pod "steptemplate-env-merge-756np-pod" is waiting to start: image can't be pulled

 message: 'The step "unnamed-0" in TaskRun "retry-example-lqdlp-hello-world" failed

          to pull the image "". The pod errored with the message: "Back-off pulling image
          "busybox"."'

/test pull-tekton-pipeline-alpha-integration-tests

/test pull-tekton-pipeline-alpha-integration-tests
potential flake: TestExamples/v1/pipelineruns/using-retries-and-retry-count-variables, reached retries count limit which should not be related to the current chagnes.


Receiving an error: "net::ERR_ABORTED 404 (Not Found) on load" with regards to Danse Macabre

Hey mate,
Upon load of Foundry, I am getting the following error:

GET http://localhost:31216/modules/chris-premades/scripts/macros/spells/danseMacabre.js net::ERR_ABORTED 404 (Not Found)

I've tried going through a clone of the github, to see if it has been deleted/moved/misplaced, and I can't seem to find it. Can this be looked at?
Kind regards.

Sorry about that, I forgot I had a reference to this WIP automation when I updated the main macros file.  Should be fixed now.


Schedulers.from

Why do you use in Schedulers.from(threadExecutor) in the base Use Case instead of computation()?
I'm asking this because computation() is backed by a bounded thread-pool with size equal to the number of available processors, that is what you do in the implementation of the ThreadExecutor with the JobExecutor.
Anyway, thank you very much to be sharing all your knowledge and to be one of first guys of speaking about Architecture on Mobility.

@gonzapico thanks for sharing your thoughts, it's great how this repo is evolving 🎉
I think Schedulers.from(threadExecutor) and Schedulers.computation() are both valid. However with Schedulers.from(threadExecutor) you are bit more flexible, because you are creating your own thread pool. Some interesting post I found:

https://stackoverflow.com/q/34997292/401025
http://tomstechnicalblog.blogspot.de/2016/02/rxjava-maximizing-parallelization.html

@ArtworkAD thanks for answering and sharing the article of the parallelization! ;)


Tag Current Version Before Merging Redesign Branches into Main

*** reminder ***
Before merging the redesign branches into main, we should create a tag on the current version to maintain a stable reference point. This will help ensure a smooth transition and allow us to track progress during the Symposium.
Priority:
High — to prepare for the Symposium.

Good suggestion. Will do a v1.0.2 release today and tag it.

Done!
https://pypi.org/project/starsim/1.0.2/


Issue with adding two decimal numbers that should result in an integer sometimes results in a NaN value

You may laugh me out the door after you read this, but I swear this is real. To reproduce the issue, you'll need a 4th generation ipad. I have tested this on a myriad of other ipads and platforms and I am not able to reproduce the issue. I have ensured that we're using latest version of iOS as well (which was 10.1.1 when I opened this issue).
This appears to be at least an issue with bignumber.js v2 and greater. My example is using the latest release.
Summary:
new BigNumber(1111.2).plus(222222.8).toNumber();

Returns NaN instead of 223334 on certain generations of ipads.
Example to reproduce the issue: http://jsbin.com/xamofokeye/edit?js,output
Proof:

ipad models that I used for testing: MD510LL/A and MD514X/A

This works as a workaround (which might help isolate the issue in the code itself):
new BigNumber(1111.2 * 10).plus(222222.8 * 10).dividedBy(10).toNumber()

If there is any issue here, it seems to be with that particular platform and not this library.

#57 seems to be the same issue reported here. The proposed solution in that issue was to open a bug with Apple dev, but this problem still exists after 1 1/2 years and multiple ios versions. Is there a reasonable work-around that can be reached in this library instead?
Also, version 1.5.0 seems to work with the given example. Likely because of this:

Store a BigNumber's coefficient in base 1e14, rather than base 10.

Rolling back versions is 1 option, but I would prefer not being locked out from active versions that are given more features/attention.

@rcoy-v
Thank you for finding #57. I had forgotten about that.
The bug needs to be reported at source. It is a bad bug.
Notwithstanding that, please try replacing the for-loop at line 1856 of bignumber.js with
   for ( a = 0; b; ) {
        a = ( xc[--b] = xc[b] + yc[b] + a ) / BASE | 0;
        xc[b] = xc[b] % BASE;
    }

Please also try
    for ( a = 0; b; ) {
        a = ( xc[--b] = xc[b] + yc[b] + a ) / BASE | 0;
        xc[b] = BASE === xc[b] ? 0 : xc[b] % BASE;
    }

and finally
for ( a = 0; b; ) {
    xc[--b] = xc[b] + yc[b] + a;
    a = xc[b] < BASE ? 0 : 1;
    xc[b] %= BASE;
}

@MikeMcl the second fix work. I have verified this on the device that had the issue. Thank you for helping us!


 But I guess it will do for now, at least until Nick reappears.

They look fine on my (WIndows) monitor, but I agree it's not the best solution. Interestingly, there's no problem with the braces in the code snippet. I think it might only be an issue when a left brace is followed by a character (which is why the diff snippet was actually fine as well).
So I think there's two things that it would be nice to resolve:

How to enter the JSON text with braces so it displays correctly and doesn't break Svelte
How to implement better syntax highlighting. When the diff snippet was text, it was displaying with no highlighting at all, which made it more difficult to interpret. In that sense, I think the image is an improvement.

Anyway, I'm happy to revise again when we have more information.

The big downside to using images is that I can't copy the text out that is needed to insert into the manifest file to fix the Lua Debugger issue. Dagnabbit.

True, but even with text you'd be copying the + signs as well.


Modifying some text on the UI final page

Regarding the UI final step ("Download configuration files for your OSMOSE model") -
Could you please replace the following text:

please contact Philippe Verley<EMAIL_ADDRESS>
with that one:

please contact Nicolas Barrier<EMAIL_ADDRESS>
?
Many thanks.

@agruss2 Contact info changed. Please check.

@FIN-JBarile Checked; many thanks! I can now close this issue.


cheatrie, backhand (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


Print a useful warning if we can't find a directory for temporary files.

This should help cases like: https://github.com/google/jax/issues/11190

Hi @nouiz Can you please resolve conflicts? Thank you!


cloudinfo setup error

Describe the bug

I have uploaded code on the ubuntu server and followed the steps which present in readme file.

Steps to reproduce the issue:

after updating the config.toml file for AWS credential.
We able to build the project below errors are come out

vinod@cloudinfo:/opt/cloudinfo/cmd/cloudinfo$ go run vars.go config.go main.go
{"application":"cloudinfo","environment":"production","level":"warning","msg":"configuration file not found","time":"2020-08-14T14:55:22Z"}
{"application":"cloudinfo","arch":"amd64","build_date":"","commit_hash":"","compiler":"gc","environment":"production","go_version":"go1.14.6","level":"info","msg":"starting application","os":"linux","time":"2020-08-14T14:55:22Z","version":""}
{"application":"cloudinfo","environment":"production","level":"info","msg":"using in-mem cache as product store","time":"2020-08-14T14:55:22Z"}
{"application":"cloudinfo","environment":"production","level":"error","msg":"Config File "services" Not Found in "[/opt/cloudinfo/cmd/cloudinfo/configs]"","time":"2020-08-14T14:55:22Z"}
vinod@cloudinfo:/opt/cloudinfo/cmd/cloudinfo$
Please let me know where I will get these below config parameters. (Does it requires banzaicloud account?)
--config-vault string               enable config Vault
--config-vault-address string       config Vault address
--config-vault-token string         config Vault token
--config-vault-secret-path string   config Vault secret path
--log-level string                  log level (default "info")
--log-format string                 log format (default "json")
--metrics-enabled                   internal metrics are exposed if enabled
Expected behavior

Screenshots

Additional context

Hi @Adilshaikh8003, based on your logs it seems that the configuration file is not found. Please make sure you point the app to the location where you put your configuration file (specify it with the --config argument)
By default you don't need to specify the values you listed; the minimal configuration is only the provider and related credentials. (no Banzai Cloud account is required)


Fix typo in deleteChatPhoto method

Typo in api method

Codecov Report

Merging #271 into develop will decrease coverage by 25.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #271       +/-   ##
===========================================
- Coverage    29.13%   3.65%   -25.48%
===========================================
  Files           21      21
  Lines         1761    1778       +17
===========================================
- Hits           513      65      -448
- Misses        1203    1708      +505
+ Partials        45       5       -40

Impacted Files
Coverage Δ

bot.go
2.36% <ø> (-31.26%)
:arrow_down:

chat.go
0.00% <0.00%> (-100.00%)
:arrow_down:

options.go
0.00% <0.00%> (-77.28%)
:arrow_down:

util.go
4.80% <0.00%> (-39.43%)
:arrow_down:

media.go
0.00% <0.00%> (-37.50%)
:arrow_down:

api.go
12.72% <0.00%> (-31.82%)
:arrow_down:

callbacks.go
0.00% <0.00%> (-31.25%)
:arrow_down:

file.go
23.52% <0.00%> (-23.53%)
:arrow_down:

polls.go
77.77% <0.00%> (-22.23%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f71c2...59d6b0b. Read the comment docs.

Thank you


Make G_REGISTER_OUTPUTS consistent.

Currently some entities have G_REGISTER_OUTPUTS set to true by default, but the clk_i : in std_logic := '0'. This is bad, as in case of the minimal instantiation the entity is locked (it is not functional as there is no clock, but it required to register the outputs).

clk_i : in std_logic := '0' -> clk_i : in std_logic := '-' and added assert

clk_i : in std_logic := '0' -> clk_i : in std_logic := '-' and added assert


Guard against invalid percentiles

@terror Check this out when you have the chance. I wasn't validating percentiles, so this fixes that. Wanted to get it in pronto so I could deploy before bitdevs.


scli: pass python dependencies directly

Motivation for this change
This is the pattern recommended by @jonringer when I added the package, was changed by @dotlambda in a recent update PR and I think it should stay in line with Jon's recommendations.
See:

https://github.com/NixOS/nixpkgs/pull/127797
https://github.com/NixOS/nixpkgs/pull/122315

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

If @jonringer really advised this pattern, I'd like to know his reasoning. I strongly advise against it because it prevents the use of packageOverrides.

Read the original PR for some more context: #122315

I can't find any comment by @jonringer in that thread.

my bad it was in this nimbo PR https://github.com/NixOS/nixpkgs/pull/121633, but as a fellow python package I think it's still relevant

https://github.com/NixOS/nixpkgs/pull/121633#discussion_r625426595

Using pythonXPackages isn't allowed from python-modules as this will mix interpreter versions for a given package. For example, if you were to do python37Packages., but the expression pulled from python3[8]Packages. Python will be mis-importing several libraries, and this will likely cause issues at runtime.
Please refer to Python dependency handling on the best practices for handling dependencies within python-modules. Namely, you should be importing each python package individually, and not refer to another python package set (E.g. python3Packages).

Namely, you should be importing each python package individually

That's true - for the case of a python module.

I'm not personally attached to this pattern or anything, but I spent quite a lot of time getting told I was doing it wrong and this was the setup people seemed to be happy with, if you think it's superior I'll trust you

I spent quite a lot of time getting told I was doing it wrong

You were, because you were trying to use python3Packages in a Python module. But then you turned it into an application. Now it's not wrong but advised against.

Sorry maybe I came off badly, I know I was doing it wrongly. I think I've mixed patterns here and I obviously didn't catch that the direct-import style is only advised for if it's a python module.
Thanks for showing me this it was pretty likely I would have done this on other packages later down the road if I hadn't been shown this, I appreciate it :)

In e.g. https://github.com/NixOS/nixpkgs/blob/1f76c234b9942bff08e009bbe46114e2ee327ee3/pkgs/servers/mautrix-telegram/default.nix, you can see that in order to use a specific version of a Python dependency the argument should be python3. To be prepared for this eventuality it's best to use the pattern right away.


Spotify not working at all

My album cover shows AWD Winterride enhanced cover and I've never heard of it and when I click windows audio player it changes to the normal monstercat grey thing.. I reinstalled ran as admin reinstalled rainmeter and monstercat visualizer including all the dlls and refreshed everything nothings worked.

Duplicate of #27, closed.


QR tweeting.

Use our already existing data-url scheme for dynamic QRs... (according to ... http://blog.marketingv2.com/bid/293392/How-to-Make-a-Tweet-This-Link-to-Pre-Fill-a-Twitter-Status)

http://twitter.com/home?status=Put your message here and include your username ala @marketingV2

Generates static images:

http://qrickit.com/qrickit_apps/qrickit_qrcode_creator_tweet.php

this one straight from the source
http://twitter.com/intent/tweet?text=Can you fly that thing? Not yet...  &hashtags=valueoflearning,bettyedwards

https://dev.twitter.com/web/tweet-button/web-intent


Mini-Sprint: Benchmarks / performance regression in Python

Possible resources:

https://github.com/airspeed-velocity/asv
https://labs.quansight.org/blog/2021/08/github-actions-benchmarks/ (uses asv)

Interested: @MridulS

Sorry, mini-sprint is somewhere else.


Printing Samples fails with security patch KB5008212

Printing in UWP apps fails with security patch KB5008212
Since patch KB5008212 was installed, printing has stopped working in the UWP app I'm developing. It also fails in the official samples here. Uninstalling the patch got it working again until Windows automatically reinstalled it.
To test it, I have used the latest current commit on the main branch (589f33b3d3930083debd21f54761269dc223445f). But I use Windows 10 Build 19043, so I need to change minimum version on the project to 19041 to be able to run it.
I use appPOS58PORTABLE+ printer (https://www.approxtpv.es/es/impresoras-58mm/124-apppos58portable.html) connected by Bluetooth, but it also fails with other portable printers of the same type.
I will describe how the error occurs and the solutions that I have tried and have not worked:
When I try to print something from the UWP app, I get this error notification:

When opening the print queue, you can see that there is a document that is pending to print with an error status:

At the time this error occurs, a "Warning" is logged in the "Event Viewer", in the "Administrative Events" view:

Event content:
Log Name:      System
Source:        Microsoft-Windows-DistributedCOM
Date:          5/24/2022 1:31:47 PM
Event ID:      10016
Task Category: None
Level:         Warning
Keywords:      Classic
User:          DESKTOP-5LRC872\User
Computer:      DESKTOP-5LRC872
Description:
The machine-default permission settings do not grant Local Activation permission for the COM Server application with CLSID
{C2F03A33-21F5-47FA-B4BB-156362A2F239}
and APPID
{316CDED5-E4AE-4B15-9113-7055D84DCC97}
to the user DESKTOP-5LRC872\User SID (S-1-5-21-2115282427-3345914188-1249518056-1002) from address LocalHost (Using LRPC) running in the application container Microsoft.Windows.ShellExperienceHost_10.0.19041.1320_neutral_neutral_cw5n1h2txyewy SID (S-1-15-2-155514346-2573954481-755741238-1654018636-1233331829-3075935687-2861478708). This security permission can be modified using the Component Services administrative tool.
Due to this error that is recorded in the "Event Viewer", I have followed the steps of a forum where a similar case occurred (https://answers.microsoft.com/es-es/windows/forum/all/la-configuraci%C3%B3n-de-permisos-espec%C3%ADfico/d2d7d947-ad76-4069-af19-47d61be8b4ad). After following these steps, it still doesn't work. However the message changes slightly. Now instead of saying "The machine-default permission settings do not grant Local Activation permission for the COM Server application with CLSID..." it says: "The application-specific permission settings do not grant Local Activation permission for the COM Server application with CLSID...".
I am attaching screenshots of how the permissions configuration has been after following these steps:

As you can see, the user "User" that describes the error does have "Local Activation" permission.
Other things I've tried and don't work: https://answers.microsoft.com/es-es/windows/forum/all/no-conecta-impresora-compartida-version-windows/6e36987f-0d1f-4475-b93e-a6de8a906623
I have also tried different settings in the printer properties, like these:

but it doesn't help either
Important: if in the print queue (where the error occurs) we right click and restart on the document that has failed, the problem is "solved" and the document prints correctly. However, doing this causes errors to be logged in "Event Viewer":

In the attached image you can see that after the printing error (the DistributedCOM Warning) that I mentioned before, if you right click and restart, two new errors of source "PrintService" are registered. The first one reports that " No printers were found." and the second that "The system cannot find the file specified." even though the document prints correctly in this case.
Events content:
Log Name:      Microsoft-Windows-PrintService/Admin
Source:        Microsoft-Windows-PrintService
Date:          5/24/2022 1:34:38 PM
Event ID:      372
Task Category: Printing a document
Level:         Error
Keywords:      Classic Spooler Event,Document Print Job
User:          DESKTOP-5LRC872\User
Computer:      DESKTOP-5LRC872
Description:
The document Print Document, owned by User, failed to print on printer appPOS58PORTABLE+. Try to print the document again, or restart the print spooler.
Data type: XPS2GDI. Size of the spool file in bytes: 635092. Number of bytes printed: 0. Total number of pages in the document: 10. Number of pages printed: 0. Client computer: \DESKTOP-5LRC872. Win32 error code returned by the print processor: 3012. No printers were found.
Log Name:      Microsoft-Windows-PrintService/Admin
Source:        Microsoft-Windows-PrintService
Date:          5/24/2022 1:34:40 PM
Event ID:      372
Task Category: Printing a document
Level:         Error
Keywords:      Classic Spooler Event,Document Print Job
User:          DESKTOP-5LRC872\User
Computer:      DESKTOP-5LRC872
Description:
The document Print Document, owned by User, failed to print on printer appPOS58PORTABLE+. Try to print the document again, or restart the print spooler.
Data type: XPS2GDI. Size of the spool file in bytes: 635092. Number of bytes printed: 351623. Total number of pages in the document: 10. Number of pages printed: 0. Client computer: \DESKTOP-5LRC872. Win32 error code returned by the print processor: 2. The system cannot find the file specified.
However, although this way works, it is not a viable solution for me, I need it to work without errors the first time, and not have to restart every time a document is printed from the UWP application.

This is a platform issue, not a samples issue. (From my quick glance at the status of the internal issue tracking this problem, I think the fix went out in the March 2022 update.)

@oldnewthing What update are you referring to? I have all the updates installed, the last one is KB5013942 (May 10, 2022) and the problem keeps happening

You are right, I understand that it is a platform problem. However, if you have any new news about why this happens or how it can be avoided, I would appreciate it if you could tell me. Thank you.

Hi, I need help with printing through microsoft edge. I don't know what menu I pushed by mistake. My printing was working until the menu with right click of Microsoft Edge Tools.   My printer works when I use Google Chrome. Last week I got it to work by using the Escape button. Today I tried but it didn't work. I just get a blank screen like the print screen is hidden. Help!!!

I'm told that the problem has since been fixed in the OS. I don't have specific build number information, but they tell me that the issue is no longer present in the latest build.


fix nullability of parameters with redirecting factory constructors

Fixes #71528

This PR should perhaps be cherry-picked to stable. @pcsosinski WDYT?

This PR should perhaps be cherry-picked to stable. @pcsosinski WDYT?

I meant beta instead of stable.


Create a landing page for events

An event landing page would act as destination for users to go to when the click on attend events. it will follow a similar pattern to our existing landing pages on primary navigation items.
AC

Show events in a tile like display similar to how we show guides on this page
Past events link to old event page.
New events link to existing events page.
Ideally we'd have a component to manage events so it's just controlled by editing some markdown.

@djsauble  any Design thoughts on this?

Only thought is that I'd split the upcoming and past events into separate grids so it's easy to scan and understand what's coming up.


Actions in footer not working

I have noticed that actions in the footer no longer work by clicking them or using keyboard shortcuts (C^t, C^s, etc).
The BINDINGS defined in the CommandBuilder class no longer propagate to the parent Trogon class, where the handlers are defined (e.g., action_focus_command_tree).
Moving the BINDINGS to the Trogon class fixes the problem for me. Moving the handlers down to the CommandBuilder does as well, but I'm not sure which solution is better. Could this be an underlying issue with Textual?
I'm happy to open a PR and move the BINDINGS, just let me know if this is an ok solution.

Is this potentially a duplicate of #82 ?

Ah, yes. Looks like a duplicate. Closing this one, thanks!


[GH-722] Spellcheck our entire code base

I've spell checked our entire code base using aspell and removed a lot of typos.
The PR includes bash scripts for spellchecking the entire code base and spellchecking the difference between the current and master branch. The scripts require that aspell(interactive spell checker) and pcregrep(grep with Perl-compatible regular expressions) is installed.

Can you move the scripts in a scripts folder?


feature request: expose month selected callback

Would be useful to expose when the user selects a new date so we can asynchronously do things depending on the current  month the user is viewing.

I think this is quite doable in v2.x and the new v3.x without explicitly declaring a callback or event handler.  You should be able to wire this up with reactive variables and the existing props (or store in v3).


How  can  i  save the  no_top.h5  of  MobileNet_v2  which  trained in my own datasets ?

Excuse me  ,how  can  i  save the  no_top.h5  of  MobileNet_v2  which  trained in my own datasets ?

Just save it using Keira’s standard save model functions

@JonathanCMitchell Thank you very much .


Add new transit features

Connects to #469
This is still a work in progress, but I wanted to share what I had thus far in case you noticed something already. I was originally going to just move ahead with trying to get it to work with manual sql functions, but now I think it'll actually be easier to transition to a csv for transit as well because the kind isn't being set properly. The logic is the same as with the pois layer, so it should be easy enough to just copy over the relevant csv rows for transit and query those for lines/polygons.
@zerebubuth could you review please?

I transitioned to using the a csv file for transit as well as mentioned in the description and rebased the commits.
Something I just realized is that the score calculation is now only done for the pois layer. Is that something that we'll want to do in the transit layer too? If so, across both line and polygon tables?

CSV is legible, nice work!
I believe we only calculate the score for tile_kind_rank on kind=station features. We might want to extend that in the future to more kinds, but out of scope for this release I think.
We should only ever calculate that for POI layer content (not transit layer content which should just be lines and polygons).

:+1: looks good. :zap: on the macro for the transit SQL - that looks great.


403 Forbidden error for https://catalog-service-sandbox.adobe.io/graphql

Expected Behaviour
I made a small change in the code deployed the search.js and expect PLP to work.
With the original search.js URL everything works.
Actual Behaviour
     I followed the steps to generate a new search.js file. I deployed the search.js file in a CDN, then white list, and changed the default URL but when I open the PLP page I get the following error in the console:

Steps to Reproduce
       1.generate the search.js
       2. store on CDN and change the config.xml and csp_whitelist.xml values with the CDN domain
       3. redeploy ( in my case new build as we are using magento cloud), open the PLP page

Platform and Version
Magento 2.4.7
Sample Code that illustrates the problem
Logs taken while reproducing problem

api key should be "storefront-widgets" for sandbox env.


Only setter and getter should access backing variables

Check that functions and other properties don't directly access another property's backing variable (unless there is a specific reason for doing that).

Not needed. May re-add in the future, if appropriate.


Safari cursor jumps to the end when an input value is set

It might make sense to also apply the controlled input Safari fix 695f2022bfedf4fe8d80f17835e1643de8e11827 when setting normal input values.

Hmmm I rarely add property-specific logic to Laminar, but this does seem like a good idea for the sake of ergonomics.
I'm currently very deep into the 0.15.0 changes, I might be able to address this there, but if not, then I'll deal with it soon after that.
On a side note, is there any specific reason why you're not using controlled? Simply no need, or does something about  not fit your use case?

Thanks a lot for the response. controlled is exactly the workaround I ended up using after discovering that it contains the Safari fix. :)


Codeunit 5772 "Whse.-Purch. Release" FilterWarehouseRequest Event Request

Hi
Please can you add an event to the end of the FilterWarehouseRequest procedure so that we can add our own filters to the standard ones?  Something similar to the below.  Thanks
local procedure FilterWarehouseRequest(var WarehouseRequest: Record "Warehouse Request"; PurchaseHeader: Record "Purchase Header"; DocumentStatus: Option)
begin
with WarehouseRequest do begin
Reset;
SetCurrentkey("Source Type", "Source Subtype", "Source No.");
SetRange(Type, Type);
SetRange("Source Type", Database::"Purchase Line");
SetRange("Source Subtype", PurchaseHeader."Document Type");
SetRange("Source No.", PurchaseHeader."No.");
SetRange("Document Status", DocumentStatus);
        // Start of new code
       OnAfterFilterWarehouseRequest(var WarehouseRequest: Record "Warehouse Request"; PurchaseHeader: Record "Purchase Header"; DocumentStatus: Option);
        // End of new code
    end;
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Ground items bug

I have both "Show highlighted items only" and "Do not hide untradeables" ticked off.
However, the highlighted takes priority over the untradeables, and so longbones, etc. do not show up, as they have a value lower than my set highlight value is.

All that option does is exclude the untradeables from the hide < value checks. They are obviously not highlighted so when showing only highlighted items, untradeables are not supposed to show.


Support Linux

If I put the API library files in target/debug/deps all the examples work, but if I put those in the root folder it cannot find them. Not sure if there is a better way

what files exactly are missing?
I just tried to build an example and encountered:
/usr/bin/ld: cannot find -lfmodstudio: No such file or directory
/usr/bin/ld: cannot find -lfmod: No such file or directory
collect2: error: ld returned 1 exit status

which I presume is the same issue you found. I'm not sure where these should be coming from.
Is this an issue inherited from libfmod? Which files are missing?

@passivedragon just to make sure we are on the same page here, it does work if you follow the following instructions:

Go to https://fmod.com/download#fmodengine and download the Linux one.
Take all the files from api/core/lib/<platform> and api/studio/lib/<platform>
Put them in the target/debug/deps folder of your Bevy project.

The issue is just that it's not very ergonomic to put the library files inside the target folder, as that folder is generated when you build your Bevy project, and deleted when you run something like cargo clean. But indeed I get those same errors when I place the files in the Bevy project root for example.
Not sure yet if it's a libfmod issue, I'm a noob when it comes to linking. I will check if there is a way to contact the author

I had the same issue trying out the project on MacOS.
To my understanding, it's not a libfmod issue. Dynamic libraries in general are linked differently by Rust on Windows, MacOS and Linux.
On Windows, it's sufficient to put the DLLs during development into the root of the repository.
I did some trials with copying the libs during build time, but other issues took priority first.

I got it working by doing the following in my project:

Put the files (see https://github.com/Salzian/bevy_fmod/issues/3#issuecomment-1735908054) in /usr/lib/x86_64-linux-gnu/fmod-api/
Add a build.rs
Add println!("cargo:rustc-link-search=/usr/lib/x86_64-linux-gnu/fmod-api/");
Add println!("cargo:rustc-env=LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/fmod-api/");

There is probably a better way but I think this is method is somewhat in the direction you would take when shipping your game. The only downside is that this breaks the Bevy dynamic_linking feature.

I'm glad to see this working for Linux. I remember looking into a very similar approach for macOS, but the linker (I guess) didn't pick up the added options.
If your approach is a reliable fix for Linux, feel free to open a PR.
Please make sure to test this in a separate application first. I would like to know what the behavior of the build.rs is for dependencies.
Also, can you elaborate how this breaks dynamic_linking? Does the application not find the bevy libs anymore?

I'm not familiar with how dynamic_linking exactly works but I get this error if I enable it:
target/debug/fmod-showcase: error while loading shared libraries: libbevy_dylib-0a701fc45ca5169a.so: cannot open shared object file: No such file or directory

I will open a PR and add a warning about this for the time being.


Allow restricting users to create repositories only on specific namespaces

Currently users can either create repo or not (determined by whether or not they have fs:CreateRepository privileges).
In some cases, admins might want to restrict creation to only allow certain users to create repositories on a pre-determined bucket or prefix.
Suggestion: on repo creation, validaet the fs:CreateRepository permission as well as a new fs:AttachRepositoryNamespace permission where the resource is an ARN containing the storage namespace passed.
In conjunction with patterns/wildcards, it would allow a pretty flexible language to allow subsets of users to create repos on a certain convention of namespaces (bucket-per-team, prefix-of-bucket-name-per-team, paths within a bucket per user, etc)

dup of #2220


Adding developers

Adding:

@bzzitsme
@riliane
@Pldi23
@jeromepochat

Requesting approval from existing members, in this case at least @aneveux

Validation step failed with "needs to log in to Artifactory and Jira".
I'm currently logged in both Artifactory and Jira.
Could you please re-trigger?

Validation step failed with "needs to log in to Artifactory and Jira". I'm currently logged in both Artifactory and Jira. Could you please re-trigger?

re-triggered, seems to have still failed

Should all the added developers need to log in to Artifactory and Jira? or just myself as PR creator?

@jeromepochat I think all users must log in at least once.


Description, Installation Instructions, Usage, etc.

WHEN I enter a description, installation instructions, usage information, contribution guidelines, and test instructions
THEN this information is added to the sections of the README entitled Description, Installation, Usage, Contributing, and Tests

Complete


Add continuous integration

Once we have tests setup (depends on #2) we should considering setting up travis-ci to continuously build the tests.

I actually did consider this!  My concern is that I think you actually have to pay for compute for a lot of continuous integration services (at least by my understanding of it!)  While I am sure this is something we could set up - in the short term I was hoping we could just have people pytest (and pylint) their code locally before going we set up a lab account for AWS or Azure or something :)  Maybe this is something we can revisit though in a few weeks/months when we have a better sense of how often people are committing to the repo/we can chat with Gene and see if he is on board?

Travis and codecov are free
e.g. I have it set-up in my personal packages, like here
It's super straightforward. For a python package, I'll just follow what we did with edgePy.

Great!  I actually was unaware of this free service.  In that case I am all for implementing it!   Thanks for sharing, I think that would be a great addition to the tests you are already implementing.

If its ok with you actually, I might take a stab at setting up a CI over the next few days as well.  Will just set up an automatic check for code style, and once we have some test cases those can be integrated as well! :)

Oo, actually I know you had suggested using travis - but I am leaning towards trying out Github Actions!  I just realized that they are also free for open source projects!! (so many free services!  exciting!).  And it seems like they have an even better direct integration into Github (which perhaps shouldn't be surprising).  (I believe it is also what another open source project I have been working on uses).  Just wanted to check with you first - since you had suggested Travis, would you also be on board with giving Github Actions a try?

Partially resolved by #16 But need to incorporate tests from #14


Enhancement/handle directory changes outside oni

If the directory is changed outside oni, whilst outside oni and theres an attempt to navigate within it in the file explorer an error is thrown that the directory does not exist. Not sure what the correct response should be but I think a potentially valid one would be to move upwards till the first valid directory is found.
Say I create a project then change my mind or rename it Oni should hook into the focus gained command to check whether the active dir is still present in the file system if not it should maybe just navigate upwards the reason I suggest this is because its hopefully less back tracking than say just navigating to the home dir which would be easier but I think a bit annoying as you now have to go searching all the way down for where you were I'd think as a user you probably just want it to back out till the next reasonable location.

@bryphe regarding this issue the simplest possible solution I can see would be checking if the file exists on focusGained in oni but this makes the assumption that this change isn't happening inside oni via a commandline command to move a file or dir.
I was thinking and wanted to run past you the idea of oni having a fileSystem watcher, potentially as a service to stick with the principle of one thing with a single purpose, which could then provide this functionality to areas of the app that would want to know about the status of the file system for example to file explorer the workspace etc. any thoughts?
Re. the implementation I've read around using fs.watch and its associates but have found that it comes with a lot of issues generally a lot of which are macOS specific alot of others more general plus its intensive on the user's CPU, does not recursively watch files and was apparently responsible for Sublime having issue with not watching files properly. Two alternates the first is vscodes solution and seems to be a well established typed solution is chokidar the other is @atom/watcher which is atom's home grown apparently highly performant bleeding edge alternative (side note, tried using this earlier and lead to a node_modules implosion...), I'm happy to proceed in whatever direction would serve oni best.

Thanks for thinking about this and putting together this proposal, @Akin909 .

I was thinking and wanted to run past you the idea of oni having a fileSystem watcher, potentially as a service to stick with the principle of one thing with a single purpose, which could then provide this functionality to areas of the app that would want to know about the status of the file system for example to file explorer the workspace etc. any thoughts?

I think this sounds reasonable. I know I've hit this where I have a folder expanded in the explorer, I save a new file, and I don't see it in the explorer until I collapse/expand the folder. Would be great to have a story for that!

Re. the implementation I've read around using fs.watch and its associates but have found that it comes with a lot of issues generally a lot of which are macOS specific alot of others more general plus its intensive on the user's CPU, does not recursively watch files and was apparently responsible for Sublime having issues with not watching files properly.

Makes sense... we actually have issues like that today with our configuration files. chokidar seems like a robust, proven solution. That sounds like a good one to integrate!
The next piece to think about is what the interface of this Service would look like and how it would interact with the other components. What would its API be? Where would we hook into it with the explorer? On the explorer side, it's pretty simple to dispatch a new REFRESH event in response if we know something updated.

@bryphe re the API I was thinking that what chokidar provides is essentially an event emitter, which informs re status updates to the file system and that a service based on that could essentially be an Oni wrapper around the emissions aka the api would potentially look like
	Oni.editors.activeEditor.fileSystem(nameTBD).fileChanged.subscribe(
		fileChange => oniActionBasedOn(fileChanges)
	)

	Oni.editors.activeEditor.fileSystem(nameTBD).fileDeleted.subscribe(
		fileDeleted => oniActionBasedOn(fileDeleted)
	)

	Oni.editors.activeEditor.fileSystem(nameTBD).folderChanged.subscribe(
		folderChanged => oniActionBasedOn(folderChanged)
	)
	...

so each of the different events could be mapped to a subscription so a consumer can subscribe to the type of events it is interested in, potentially this could be generalised in some way but ideally you wouldn't have to listen to events that didn't relate to what you wanted to know so it might make subscriptions tedious if you want to listen to multiple types of events.
possibly another potential method would be
	Oni.editors.activeEditor.fileSystem(nameTBD).allFileEvents.subscribe(
		objectOfDifferentTypesOfChangesAndEachChange => oniActionBas
edOn(fileChanges)
	)

Thats as far as I've gotten re. how this would work I'm very open to suggestions as I don't have a strong preference or path in mind

Addressed in #2116, closing.


move the canvas with the touchpad as the mouse

What is your role?
Developer Advocate at MuleSoft
What tools do you use today for your use cases?
Studio
How do you see Anypoint Code Builder help you with your day to day work?
I love love love vscode and i hate eclipse :D
General feedback:
In Studio I can move the graphical canvas with the touchpad (i.e., using the two-finger gesture like when scrolling). In ACB this is currently not possible. I can only move it with a mouse-click drag-and-drop.

Hi @alexandramartinez
Thank you for logging this issue with MuleSoft Support.
The graphical canvas is not yet functional in the Beta version. The engineering team is working to provide a better version of the palette.
Regards,
MuleSoft Support


PhpdocAnnotationWithoutDotFixer removes '...' step by step

/**
 * @param string $foo Foo, e. g. "bar", "baz", ...
 */

PhpdocAnnotationWithoutDotFixer removes the '...' one by one. So you have to run the fixer 3 times to remove all dots.

Actually, the ... should not be removed.
People often use ... (3 chars) instead of … (1 char). The later one is handled correctly, the first one is not.
Do you want to send a bugfix for it ?

@keradus We should probably just update this fixer to trim any and all punctuation, zero or more instances of the end.

Why not trim trailing dot if it is not directly preceded by another dot ?

I could send a bugfix next week

What about other variants of punctuation?


px-modal opens on disabled button with fa icon

Hello,
Having some issues using px-modal in my polymer component. Please see attached code below. Clicking on the button does on open the modal, but clicking on the icon itself does. We could implement a workaround with template dom-if but would prefer another solution.
<px-modal btn-modal-positive="Yes"  btn-modal-negative="Cancel" btn-modal-positive-clicked-event-name="onDelete" modal-heading="Remove Form" scrolling-disabled="true">           <button class="btn btn--tertiary btn--icon modal-trigger"></button>
Are you sure?
         </px-modal>

I'm Sorry, I don't quite understand your issue - I understand that the Modal DOES open, but i'm not sure what does and doesn't work for you after that?

Here's a codepen illustrating the issue:
http://codepen.io/randyaskin/pen/vygXBx?&editors=1001
The button has the "disabled" flag, so clicking on the text/body of the button does NOT open the modal (was a typo above), but clicking on the font awesome icon DOES launch the modal.

@tejrajendran I didn't make any changes to px-modal (it doesn't actually care what the triggering element is) but I've updated px-buttons-design so that disabled buttons will not fire any pointer-events. Update to the latest version of buttons and see if you still have this issue with your modal. Thanks!


Should it be I2C_MSG_READ, shouldn't? I didn't understand

The line on this code contains the flag I2C_MSG_WRITE, but in my mind it should be I2C_MSG_READ, right?
https://github.com/zephyrproject-rtos/zephyr/blob/a1c49be42e371a865865d52d0ea5ef83b2a3a9db/samples/drivers/i2c_fujitsu_fram/src/main.c#L61

Yes of course. Read I2c protocol, please.
B.R.

Looks OK as-is. Often i2c devices need a write before a read.


COMP: Fix CMake warning by setting policy 0120 to OLD

We will also have to update VNL after https://github.com/vxl/vxl/pull/833 is merged or otherwise addressed.

+1


Fix SIL mandatory inlining crash that could occur with public override of an internal property

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Radar: rdar://problem/26408353

Can I please get a review from one of:

@bitjammer You worked in this area most recently
@jckarter Benevolent SIL overlord

LGTM.

@swift-ci test linux
@swift-ci smoke test os x platform

@swift-ci test linux

Looks good.


hi，I add some code to enable jadx can decompile apk by file's type, not only by file's extension

hi，I add some code to enable jadx can decompile apk by file's type, not only by file's extension.
I just modified jadx/core/utils/files/FileUtils.java and  jadx/core/utils/files/InputFile.java.
my repo: https://github.com/bigfool/jadx
thanks!

Would this be interesting, to raise a PR for?

@asashour looks like this were already merged


Added functionality to set the listening address.

Added config flag "address" to set the IPv4 address to bind to. Default
is <IP_ADDRESS> (localhost).
Added config flag "address6" to set the IPv6 address to bind to. Default
is ::1 (localhost).
Added config flag "disable6" to disable starting the IPv6 server for
hosts that don't support IPv6 / don't have an IPv6 address.
Fixed typo Hous -> Hour
The program now starts two seperate http.Server's to allow configuring
the addresses independently.

Thanks, I appreciate it 🙏😃


make consumable via npm

also add linting

The repository should be renamed to knockout.datepicker after this is merged.

repo is renamed

:shipit:


Dark area after direction shadow range

If directional shadows range is set smaller than camera view range there is full dark area behind shadows range don't know if this solves and can't try it but i believe setting ShadowBuffer texture edge to white should solve this.
glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_WRAP_S, GL_CLAMP_TO_BORDER);
glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_WRAP_T, GL_CLAMP_TO_BORDER);
float color[] = { 1.0f, 1.0f, 1.0f, 1.0f };
glTexParameterfv(GL_TEXTURE_2D, GL_TEXTURE_BORDER_COLOR, color);

Not sure if this is a bug. I believe the shadow range should be the same as the camera view range, as stated in the shadow mapping tutorial.

It's the same issue as #559, so I'll archive this.


Upgrade client to use the Skyhash protocol

If you're following skytable/skytable#148, Skytable is officially EOL-ing Terrapipe and introducing a new serialization protocol Skyhash. This issue serves to track our progress of upgrading to the Skyhash protocol

All systems go; bugs fixes and added sync API


Move modal styling into webpack

I rule and have completed some work on Case Manager that's ready for review!
Ports over styling around modals out of sprockets and into webpack.
This pull request makes the following changes:

port over modal styling overrides into their own webpack module
delete some unused or ineffective styling that doesn't actually take effect anymore (see comments)

no view changes
It relates to the following issue #s:

Bumps #1854

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

thank you @lomky !


Problem with keyboard on android when exit screen of unity

Hi I'm having a problem on both platforms but is more present on android.
When the user is exiting the view where unity is embedded, and clicks on a input field on flutter the keyboard appears but is not possible to be hidden. This problems happens if you load the unity view and then exit (pop) from this one.
Also this error popups when I exit on android and ios:

Unhandled Exception: MissingPluginException(No implementation found for method dispose on channel unity_view_0)

And when I run this command on flutter on the screen where the input field is present:
MediaQuery.of(context).viewInsets.bottom
the keyboard return 0 height, and some people mention that this error happens if there are very complex widget tree, but this error only happens when I exit from the flutter screen that has the unity view.
So anyone had this error before? and know how to resolve it?

I was having a similar issue. But I found a fixed for that: you have to edit the code inside the plugin, find the line "UnityUtils.getPlayer().quit();" and comment it (to avoid to close the entire app). And replace it for:
activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);         activity.getWindow().addFlags(WindowManager.LayoutParams.FLAG_FORCE_NOT_FULLSCREEN);
When I do that, I remove the full screen and my keyboard starts to work properly. But this remove your app from fullscreen.

The dispose exception is not important, its just because the plugin devs didnt create a implementation for the dispose method call :D

thanks it works.

I was having a similar issue. But I found a fixed for that: you have to edit the code inside the plugin, find the line "UnityUtils.getPlayer().quit();" and comment it (to avoid to close the entire app). And replace it for:
activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN); activity.getWindow().addFlags(WindowManager.LayoutParams.FLAG_FORCE_NOT_FULLSCREEN);
When I do that, I remove the full screen and my keyboard starts to work properly. But this remove your app from fullscreen.

@gabrielchaves7
Thanks for this, but it indeed removes the possibility to go fullscreen on other screens. This is a problem for my app.
I tried to only add this line:
activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
Although that restores the status bar just like I want, Flutter's setSystemUiOverlays is somehow overriden and the statusbar is always automatically restored whenever i try to hide in another screen.
Do you have insight maybe on which flags one can set/remove to deal with this?
Thanks!

I was having a similar issue. But I found a fixed for that: you have to edit the code inside the plugin, find the line "UnityUtils.getPlayer().quit();" and comment it (to avoid to close the entire app). And replace it for:
activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN); activity.getWindow().addFlags(WindowManager.LayoutParams.FLAG_FORCE_NOT_FULLSCREEN);
When I do that, I remove the full screen and my keyboard starts to work properly. But this remove your app from fullscreen.

@gabrielchaves7
Thanks for this, but it indeed removes the possibility to go fullscreen on other screens. This is a problem for my app.
I tried to only add this line:
activity.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
Although that restores the status bar just like I want, Flutter's setSystemUiOverlays is somehow overriden and the statusbar is always automatically restored whenever i try to hide it in another screen.
Do you have insight maybe on which flags one can set/remove to deal with this?
Thanks!

@Gadda27
I think that this problem is related to the way that the plugin work, because they create an activity to show the unity but you cant dispose it, so this will always keep alive inside your app. This is why is only possible change the system overlays when you access the activity directly. You can try to uncomment the line "UnityUtils.getPlayer().quit();" and replace ".quit" for ".pause" maybe change something, but i dont know if will fix your problem.


Plot the velocity and acceleration curves

How can I plot the velocity and acceleration curves when I run TEB on my robot like in your paper?

I really need it !Thank you.

Hello, I am very interested in your algorithm. May I ask what improvements can be made to improve the navigation effect of this algorithm?


pin tornado to 4.5.3

in case tornado 5 is what's causing the recent loss of build output on mybinder.org

This wasn't it. It was an unhleathy node. tornado 5 is fine.

Tornado v5 was also a thing that came up in https://github.com/jupyter/repo2docker/pull/252. Should we make a coordinated move (update r2d and bhub) to v5?

Reopening this one since I think there's a chance that our recent 'event stream lost' uptick was related to the tornado 5 update. It could also be related to issues in our nginx ingress, which is hard to debug since we exclude all of the nginx ingress logs from stackdriver for cost reasons.

I don't think we need to coordinate moves to tornado 5, since these are separate environments and applications where tornado 5 issues may come up. I'm surprised that it's an issue here, and it may still not be, but I want to pin it to at least control for that being a factor.


Wrapping API calls in contextlib.aclosing and breaking out of the generator loop doesn’t work as expected

Many thanks for this project! It’s great.
The advice provided in the README for breaking out of the generator loop is very helpful. I followed the sample code provided in https://github.com/vladkens/twscrape/issues/27#issuecomment-1623395424. The simple examples work as expected, but the sample code that calls twscrape doesn’t.
Here’s my code:
from contextlib import aclosing
from twscrape import API
import asyncio

async def main():
    user_id = 68828618
    recent_tweet_id =<PHONE_NUMBER>706884608

    api = API()
    await api.pool.login_all()

    async with aclosing(api.user_tweets(user_id)) as gen:
        async for tweet in gen:
            if tweet.id < recent_tweet_id:
                break

    print("This should happen second.")

if __name__ == "__main__":
    asyncio.run(main())

I also added print("This should happen first.") just here:
https://github.com/vladkens/twscrape/blob/00a8e07b43c1fbbea95566cc3aae95db76cd4ae3/twscrape/queue_client.py#L80-L81
But when I run, I get the following output:
This should happen second.
This should happen first.

async with aclosing is not ensuring that the lock is released before continuing.
Any advice you can provide would be appreciated!

This queue_client test is very helpful:
https://github.com/vladkens/twscrape/blob/00a8e07b43c1fbbea95566cc3aae95db76cd4ae3/tests/test_queue_client.py#L123-L161
I can modify my example to be more similar to this example, and it works as expected:
from contextlib import aclosing
from twscrape import API
from twscrape.api import OP_UserTweets
from twscrape.models import parse_tweets
import asyncio

async def main():
    user_id = 68828618
    recentish_tweet_id =<PHONE_NUMBER>865909765

    api = API()
    await api.pool.login_all()

    op = OP_UserTweets
    kv = {
        "userId": str(user_id),
        "count": 40,
        "includePromotedContent": True,
        "withQuickPromoteEligibilityTweetFields": True,
        "withVoice": True,
        "withV2Timeline": True,
    }
    limit = 1_000

    done = False
    async with aclosing(api._gql_items(op, kv, limit=limit)) as wrapped_gen:
        async for tweets in wrapped_gen:
            for tweet in parse_tweets(tweets):
                if tweet.id < recentish_tweet_id:
                    done = True
                    break
            if done:
                break

    print("This should happen second.")

if __name__ == "__main__":
    asyncio.run(main())

This outputs:
This should happen first.
This should happen second.

🎉 🎉 🎉


Stop all intervals to stop resource usage growing out of hand

For my personal project I created a 5000x5000 size map. I found that the render and tick kept going after the game was lost.
The render kept making new intervals instead, thereby using a lot of resources.

nice catch :)


Link introduction article?

The article contains interesting/important information on the internals and their limitations. It would be nice if linked in this repo - people will eventually get linked directly here.
A link would fit nicely in the execution section, probably something like:
For more information on intended use and limitations, see the
[introductory article](https://blog.colony.io/code-coverage-for-solidity-eecfa88668c2).

... or include a copy like doc/introduction.html.

Thanks for pointing out there wasn't a link in that direction! Now included in README.


fix: display colors on flutter commands

Previously, colors were disabled because flutter thinks we are not on a terminal session. Now we make the child process share the same stdout and stderr as the parent which was in fact spawned in a terminal session, thus showing colors :^).
Before
https://user-images.githubusercontent.com/7662016/222934909-b3d46479-2f53-45e8-a808-ef94a2352149.mp4
After
https://user-images.githubusercontent.com/7662016/222934912-122c3ddf-d760-4d4d-b549-ac6a865ae2a2.mp4

Previously, colors were disabled because flutter thinks we are not on a terminal session. Now we make the child process share the same stdout and stderr as the parent which was in fact spawned in a terminal session, thus showing colors :^).
Before
https://user-images.githubusercontent.com/7662016/222934909-b3d46479-2f53-45e8-a808-ef94a2352149.mp4
After
https://user-images.githubusercontent.com/7662016/222934912-122c3ddf-d760-4d4d-b549-ac6a865ae2a2.mp4

Thank you for the PR, we need they isCli conditional to support Flutter Sidekick, is that something we can pass through?

Damn, I just noticed that I pretty much did the same in #508 - I'll close that one.

Maybe check what I did with the isCli flag.

@Ascenio let me know if you are able to make this adjustment

@Ascenio Thank you for your PR, but I will have to merge another version, as this breaks some necessary compatibility items. Thank you again for your work, though!


Accessibility (A11y) Improvement: enable the Enter keystroke on the IBM w3ID authentication page

Overview
If a user is logging into Bluemix, and that user should be authenticated with w3ID, they are first shown this page where they have to click Sign in to IBM w3ID in order to initiate the authentication process:

Currently, there is no accessible keyboard shortcut assigned to that button. Ideally, users could just hit Enter. Unfortunately, they must actually use the mouse to click the button. This makes authentication inaccessible to some users (and annoying to others who just want to quickly move past this page).
Feature: {{feature}}
  As a Bluemix console user
  I want to use the Enter key to move beyond the "Sign in with w3ID" page when authenticating
  So that I can authenticate even if I am unable to use a mouse (due to a disability or a technical problem with the mouse) and so that I can move quickly past this often-accessed screen.

Other
Apologies for using IBM-specific terms. I'm sure there are generic carbon component terms for everything above, but I don't know them. Feel free to modify to make more "generic".

Hey @jthurne - while I completely agree with you, we / this repo doesn't have any say over that page unfortunately :(. Not entirely sure who the contact is for that, but I'll ask around

Thanks @chrisdhanaraj. I suspected this wasn't the right place, but I don't really know where to go with it, so I'm 🤞 that you'll learn where I should take this request. :)

@jthurne The user can hit enter on that button but the user must tab to focus on the button first.


Bug: Profile Images broken

Describe the bug
It looks like the Profile Images are broken because they generate a wrong URL.
Closely inspecting the <img> tag shows, that the URL is missing a second slash after https:.
<img alt="User Profile" src="https:/oneuptime.mydomain.io/file/image/825384cf-cc8e-45d5-9042-f1347ba4be67" class="h-8 w-8 rounded-full">

To Reproduce
Steps to reproduce the behavior:

Upload a profile image
The image is not shown in the top right corner

Expected behavior
The image should be shown in the top right corner
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser: Tested in Chrome and Safari

Deployment Type
docker-compose

here I have the same behavior.

Fixed here: https://github.com/OneUptime/oneuptime/pull/1633/commits/6fd43622a321cf01610b501411cab74979e5df3c

This will be released today.


Docs and demo vm are incorrect.

Hello,
your doc is missing some important elements.
A correct GOPATH must be set.
Your VM are referring to a depot that has moved and are failing : http://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/repodata/repomd.xml
the "make demo" never worked for me... /opt/gopath/src is always binded to my homedir instead of my $GOPATH
Trying to fix and provide a patch.

Could you provide more details ? On which VMs you are trying to run this demo ?
netplugin demo , once you do make start fetches two vagrant boxes and inside vagrant box GOPATH is /opt/gopath and your demo runs inside vagrant box.
On your client / laptop :
You checkout the code let us say at / home/tempUser/ then
/home/tempUser is mapped to /opt/gopath inside vagrant box.

@sfoutrel - following works for me without any GOPATH dependency:
$ echo $GOPATH

$ cd $HOME
$ mkdir demo
$ cd demo
$ git clone https://github.com/contiv/netplugin
$ cd netplugin
$ make demo
$ make ssh

Then inside VM
[vagrant@netplugin-node1 netplugin]$ netctl net ls
Tenant  Network  Nw Type  Encap type  Packet tag  Subnet   Gateway
------  -------  -------  ----------  ----------  -------  ------

Can you describe some steps like above on what you did that required you to set GOPATH?

Hello, will retry all within a script instance to give you all errors.
Two main points were a repos unavailable and vagrant mount points that were not mounted in the good place.

Please try again. Let us know if you face any issues.

Ok so cannot make your project work because of virtualbox bugs..
the /etc/resolv.conf of the host is imported into vms and as it's using a <IP_ADDRESS> it can not resolv anything.
Tried some workarounds that did it on a ubuntu created to test but nothing worked in your centos/ubuntu instances.

yeah; this is my fault. I can file a patch, or @jojimt recently fixed it too.

Either way, it'll be patched tomorrow.

did a vagrant destroy -f
put a nameserver <IP_ADDRESS> temporarily in my host /etc/resolv.conf
then make demo
and it finished succesfully..
Can now try the demo :)
By the way could not found a complete install guide.

I've just filed #384 which resolves this issue.

@erikh or @shaleman Can we close this issue now ?

Yep! the PR was merged


on_play is not working

rtmp {     server {         listen 1935; # Listen on standard RTMP port         chunk_size 4000;         notify_method get;         application show {             live on;             on_play http://localhost:80/authenticate;            record all;            record_path /nginx/record/;            record_unique on;            exec_record_done ffmpeg -i $path -f mp4 /nginx/record/$basename.mp4;             # Turn on HLS            hls on;            hls_path /nginx/hls/;            hls_fragment 3;            hls_playlist_length 60;             # disable consuming the stream from nginx as rtmp            #deny play all;         }     } }
`http {
sendfile off;
tcp_nopush on;
aio on;
directio 512;
default_type application/octet-stream;

server {
    listen 80;

    location /authenticate {
      return 404;
    }

    location / {
        # Disable cache
        add_header 'Cache-Control' 'no-cache';

        # CORS setup
        add_header 'Access-Control-Allow-Origin' '*' always;
        add_header 'Access-Control-Expose-Headers' 'Content-Length';

        # allow CORS preflight requests
        if ($request_method = 'OPTIONS') {
            add_header 'Access-Control-Allow-Origin' '*';
            add_header 'Access-Control-Max-Age' 1728000;
            add_header 'Content-Type' 'text/plain charset=UTF-8';
            add_header 'Content-Length' 0;
            return 204;
        }

        types {
            application/dash+xml mpd;
            application/vnd.apple.mpegurl m3u8;
            video/mp2t ts;
        }

        root /nginx/;
    }
}

}`
on_play is not working. These are my nginx blocks. Please check if something is wrong. /authenticate is returning 404 but still i am able to play on VLC.

@rishabhgoel9797 here is an example of how to authenticate hls:
https://github.com/entonbiba/nginx-rtmp-module/wiki/Secure-live-playback-with-php-authentication


Build error

`cmake -DCMAKE_INSTALL_PREFIX=/usr -DPLUGINS_DIRECTORY=/usr/share/zectl/libze_plugin ..
-- The C compiler identification is GNU 10.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
Searching for required ZFS include directories
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.4.2")
Found pkg-config
Found zfs include directories in /usr/include/libzfs;/usr/include/libspl
Searching for ZFS libraries
libzfs library found at: /usr/lib64/libzfs.so
libzpool library found at: /usr/lib64/libzpool.so
libzfs_core library found at: /usr/lib64/libzfs_core.so
libnvpair library found at: /usr/lib64/libnvpair.so
libuutil library found at: /usr/lib64/libuutil.so
PLUGINS_DIRECTORY=/usr/share/zectl/libze_plugin
PLUGINS_DIRECTORY=/usr/share/zectl/libze_plugin
-- Configuring done
-- Generating done
-- Build files have been written to: ~/zectl-0.1.3/build`
The 'make' output:
`Scanning dependencies of target libze
[  4%] Building C object lib/libze/CMakeFiles/libze.dir/libze.c.o
~/zectl-0.1.3/lib/libze/libze.c: In function ‘libze_rename’:
~/zectl-0.1.3/lib/libze/libze.c:2646:5: error: unknown type name ‘renameflags_t’; did you mean ‘recvflags_t’?
2646 |     renameflags_t rnf = {
|     ^~~~~~~~~~~~~
|     recvflags_t
~/zectl-0.1.3/lib/libze/libze.c:2647:13: error: field name not in record or union initializer
2647 |             .recursive = 0,
|             ^
~/zectl-0.1.3/lib/libze/libze.c:2647:13: note: (near initialization for ‘rnf’)
~/zectl-0.1.3/lib/libze/libze.c:2648:13: error: field name not in record or union initializer
2648 |             .nounmount = 1,
|             ^
~/zectl-0.1.3/lib/libze/libze.c:2648:13: note: (near initialization for ‘rnf’)
~/zectl-0.1.3/lib/libze/libze.c:2648:26: warning: excess elements in scalar initializer
2648 |             .nounmount = 1,
|                          ^
~/zectl-0.1.3/lib/libze/libze.c:2648:26: note: (near initialization for ‘rnf’)
~/zectl-0.1.3/lib/libze/libze.c:2649:13: error: field name not in record or union initializer
2649 |             .forceunmount = 0,
|             ^
~/zectl-0.1.3/lib/libze/libze.c:2649:13: note: (near initialization for ‘rnf’)
~/zectl-0.1.3/lib/libze/libze.c:2649:29: warning: excess elements in scalar initializer
2649 |             .forceunmount = 0,
|                             ^
~/zectl-0.1.3/lib/libze/libze.c:2649:29: note: (near initialization for ‘rnf’)
~/zectl-0.1.3/lib/libze/libze.c:2651:9: error: too few arguments to function ‘zfs_rename’
2651 |     if (zfs_rename(be_zh, new_be_ds, rnf) != 0) {
|         ^~~~~~~~~~
In file included from ~/zectl-0.1.3/include/libze/libze.h:9,
from ~/zectl-0.1.3/lib/libze/libze.c:6:
/usr/include/libzfs/libzfs.h:626:12: note: declared here
626 | extern int zfs_rename(zfs_handle_t *, const char *, boolean_t, boolean_t);
|            ^~~~~~~~~~
~/zectl-0.1.3/lib/libze/libze.c:2659:13: error: too few arguments to function ‘zfs_rename’
2659 |         if (zfs_rename(be_bpool_zh, new_be_bpool_ds, rnf) != 0) {
|             ^~~~~~~~~~
In file included from ~/zectl-0.1.3/include/libze/libze.h:9,
from ~/zectl-0.1.3/lib/libze/libze.c:6:
/usr/include/libzfs/libzfs.h:626:12: note: declared here
626 | extern int zfs_rename(zfs_handle_t *, const char *, boolean_t, boolean_t);
|            ^~~~~~~~~~
make[2]: *** [lib/libze/CMakeFiles/libze.dir/build.make:82: lib/libze/CMakeFiles/libze.dir/libze.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:173: lib/libze/CMakeFiles/libze.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
Any suggestion are welcome :+1:

Solved with zfs-2.0.0


Allow everyone with write permission to push to main

This allows everyone with write permission (i.e. everyone in our organization) to write to the main branch. Changes still need to be first pushed to a unprotected branch and reviewed in a pull request, but clicking on the merge button is now possible for everyone aside the admin/maintainer team.
See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#restrict-who-can-push-to-matching-branches for more information on this change.

When status checks are required, the people, teams, and apps that have permission to push to a protected branch will still be prevented from merging into the branch when the required checks fail. People, teams, and apps that have permission to push to a protected branch will still need to create a pull request when pull requests are required.

Signed-off-by: Eduard Itrich<EMAIL_ADDRESS>

Seems that this worked :laughing:


Basic validation of minerid field

During grading the minerid/FactomDigitalID field is not validated at all and even if it's missing (nil) the OPR will be judged valid.
Even though the digital identity is not yet deeply used we should have a minimal validation for it to be non null and non empty string.

from what's been said earlier it should just be alphanumerics along with _ or -?

From what's been said earlier minerid should just be alphanumerics along with _ and/or -?
The miner should panic on startup for anything invalid.

This is indeed the case already: https://github.com/pegnet/pegnet/blob/a5655d68ca35017a952aed9845f5c3fc20f32101/cmd/root.go#L125-L133
At the moment, the minerid field in the OPR is just for internal tracking for miners themselves and has no other relevance until DIDs are implemented.
I'm okay with the possibility of it being nil or empty until then.

Yea, the coinbase is the real identified at the moment imo.

Fair enough. Was just bothering me a tiny bit that we have a field completely unvalidated, but that's fine.


Camera access denied error on Android

Hey, i'm trying to see if my code works by using my android mobile, it works when i use the computer's camera. When I try to open the html file on my mobile this error appears:

Does anyone knows why is this happening and how to solve it?
Thanks!

Try to close your browser and launch again the app. It happens sometimes when you do not give permission to camera to the website, and the browser stores your choice.

Hi DaniAframe,
I figured out that it works on Android and Iphone when you launch your script from a https:// page.

@kencessna hits the point. solved


fix imports from CheckpointConnection to not reference own barrel

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jason Crow seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

What was wrong with the previous PR?

nothing code wise, issue with the cla bot

@jason-crow I think you have your local git setup with a different noreply email than what's associated with the jason-crow  account.  That may be causing these issues. Can you check https://github.com/settings/emails to see what the noreply email is?

@mergifyio backport release/2.14.x

@mergifyio backport release/2.15.x

OK should be good now, thanks @calebmshafer for your help!


Allow alternate rate limit notifications

Allow a callable to be passed to wait_on_rate_limit_notify so that a rate limit notice can trigger actions other than logging a warning.

Oh this is a neat idea!


Feature: Custom package repos

This PR adds custom repo usage instead of "only" github via API.
This PR precedes https://github.com/eclipse-velocitas/cli/pull/128 since it was created from its basis

@dennismeister93 We need to update README.md with the prerequisite that git has to be installed on the system.


Added tests for removal of items in list and dictionary

This PR adds tests for function remove().
According to codecov, removing range of elements in list was not covered by tests:
https://codecov.io/gh/vim/vim/src/95892c27b242cdbc78e622c7a861a4e15aec7a30/src/evalfunc.c#L9508

Codecov Report

Merging #3497 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3497      +/-   ##
==========================================
- Coverage   77.11%    77.1%   -0.01%
==========================================
  Files          99       99
  Lines      139002   139002
==========================================
- Hits       107188   107176      -12
- Misses      31814    31826      +12

Impacted Files
Coverage Δ

src/gui_beval.c
55.02% <0%> (-7.43%)
:arrow_down:

src/window.c
83% <0%> (-0.52%)
:arrow_down:

src/os_unix.c
57.83% <0%> (-0.36%)
:arrow_down:

src/diff.c
77.01% <0%> (-0.28%)
:arrow_down:

src/ex_cmds.c
79.88% <0%> (-0.23%)
:arrow_down:

src/gui_gtk_x11.c
48.06% <0%> (ø)
:arrow_up:

src/syntax.c
78.44% <0%> (+0.02%)
:arrow_up:

src/screen.c
78.71% <0%> (+0.04%)
:arrow_up:

src/ex_cmds2.c
84.52% <0%> (+0.09%)
:arrow_up:

src/if_xcmdsrv.c
84.53% <0%> (+0.35%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b434ae2...5af8759. Read the comment docs.


Bugfixes for initial merge for tuples step one

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
This PR fixes problems introduced by https://github.com/stan-dev/stan/pull/2498, which was a refactor of the Stan compiler.  This PR adds a suite of unit tests for the generator to check variable declarations of primitive, array, container, and specialized types in all program block contexts.
Intended Effect
This pull request adds tests which check the generated code.  The unit tests for block level variables are based on a set of Stan programs.  Each program consists of a single program block which contains one or more variable declarations.  The unit tests check that each section of the generated c++ model contains the correct set validation/declaration/initialization/fill statements.
The minimal stan programs are checked into src/test/test-models/good/parser-generator.
To develop the tests, each program was compiled using this branch and also compiled under the 2.17 release.  The generated hpp files were compared line by line using a side-by-side diff, e.g.:
diff -Bbw -y -W 260 multidim_var_transform_param_ar45_mat23.hpp ~/test3/cmdstan-2.17.1/multidim_var_transform_param_ar45_mat23.hpp
The known bug was that in the generated code, the method constrained_param_names indexed array dimensions in the wrong order, thus the reported parameter names didn't match up with the actual parameters.   Additional bugs found:

scalar double variables were declared with initial value DUMMY_VAR__ which is NaN when they should have been declared with initial value 0
local variables didn't validate all container dimensions

How to Verify
Unit tests which check generated c++ code:

src/test/unit/lang/generator/multi_dim_var_test.cpp
src/test/unit/lang/generator/multi_dim_var_data_test.cpp
src/test/unit/lang/generator/cholesky_factor_cov_var_test.cpp
src/test/unit/lang/generator/prim_var_test.cpp
src/test/unit/lang/generator/local_var_test.cpp
src/test/unit/lang/generator/function_var_test.cpp

Side Effects
generated c++ code will be different, but functionally equivalent.
Documentation
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):  Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

to review this PR,  look at the changed generator files in this diff:
https://github.com/stan-dev/stan/compare/feature%2F2431-lang-tuples-step1...bugfix%2F2431a-tuples-set-one-fixes?diff=split&name=bugfix%2F2431a-tuples-set-one-fixes

I kicked off the performance / regression tests for this branch here: http://d1m1s1b1.stat.columbia.edu:8080/blue/organizations/jenkins/CmdStan Performance Tests/detail/test/7/

@seantalts could you please check why jenkins is hung on upstream tests?

Looks like someone canceled it, not sure what it was doing when it was canceled.

I canceled it - it had been hung for 8 hours on starting the upstream tests.
but when I look at it via this page (Github PR) it's pending, and that's what it says when I click through to Jenkins, so I'm confused.

What did it say when it was hung? I saw that it seemed to have started the
upstream tests, was it hung on deleting the directory?
On Wed, Sep 12, 2018 at 14:06 Mitzi Morris<EMAIL_ADDRESS>wrote:

I canceled it - it had been hung for 8 hours on starting the upstream
tests.
but when I look at it via this page (Github PR) it's pending, and that's
what it says when I click through to Jenkins, so I'm confused.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/stan/pull/2611#issuecomment-420743883, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7KH1kwVzmnxwaCM_WDJOL22k8dRAks5uaU0KgaJpZM4WEdgm
.

--
📲

no, it had gotten past deleting the directory - it was starting the upstream/downstream tests.


Fixed #26526 -- Add note to docs on different ordering for QuerySet.latest

Added a note for https://code.djangoproject.com/ticket/26526

Now that I think about this a bit more, I learn toward having the queryset methods abstract away these database differences by having them filter out null results. Do you have any feelings about this? You could raise it on the django-developers mailing list for further discussion.

I don't have strong feelings about filtering out nulls by default.
Keeping the logic as is:

keeps the code simple
doesn't make assumptions about your data
doesn't break existing code relying on these methods

Adding a default filter does add to the convenience of the method.

@timgraham That seems like a bigger, unnecessary change (admittedly I was convinced by your argument in the original ticket). As you said it seems a bit magical and not necessarily intuitive. I prefer case in which we expose the underlying database discrepancy to the app developer and allow her/him to decide what to do with null values (if they even exist).

I agree with @tobiasmcnulty. If we auto-filter nulls, that's a backwards-incompatible change that is difficult for the app developer to reverse if they relied on the null-sorting behavior of their particular database backend. If we document the issue, then it's easy for anyone to filter nulls who wants to do so (including e.g. the author of an app that is supposed to be cross-database).

merged in e6c5e68acd4bff90e371fd148ed6976e147692ad, thanks!


[New] Add no-pure-component-children rule

Overview
This PR adds a new rule no-pure-component-children which checks that a component extending React.PureComponent does not declare children as a proptype.
Motivation
Consider standard use of children:
<Parent>
  <Child /> // note this is sugar for React.createElement(...)
</Parent>

On every render, <Child /> !== <Child /> so Parent props will fail equality checks even though they appear to be equal. This means that if Parent is a component that extends PureComponent, it will be less performant than if it extended just Component since it will do the extra work to check props which will ultimately always be unequal.
See https://github.com/facebook/react/issues/8669 for more discussion

Specifically, the linked example talks about how ComponentWithChildren is rendered - its actual implementation makes zero difference whatsoever.
This, imo, is not something that is lintable in any reliable way.

Thanks for taking a look!
I agree with you, what the PureComponent renders is irrelevant and passing new children to PureComponent is what would would cause re-renders. The key here is that children are always new unless they're primitives* or cached, so having a children prop on a PureComponent is a smell and could be at least warned on
And yeah, it would be better to check that the calling code doesn't pass new children but I agree that that's probably not lintable. Checking out this search shows there's a ton of PureComponents out there that are basically worthless because of children props
*I can update this to check the types, we shouldn't warn if the children proptype is a number or string

Precisely because children could be memoized or primitives, is why i think this doesn't make sense as a lint rule.

I'll update to allow primitives, which leaves just the possibility of memoized children react elements as your argument against it?
Note also that I didn't add this to the recommended list since I did not expect it to universally apply

The problem is that I think this rule will create confusion, by targeting the wrong thing.
This is a problem that should be solved at runtime by looking for excessive renders - potentially by monkeypatching PureComponent to track when they happen.

Yeah I agree it could be solved that way (though regressions could be an issue)
I think this also makes sense, so I'd like hear what the rest of the community thinks 👍

A PureComponent that receives children would indeed be forced to rerender if the parent rerenders because it will receive new props -- however, if the update is happening because of a state change, it'll still reuse the previous render's props.
It's a big footgun which kinda defeats the shallow equality check on the props, but there are still valid uses... 🤔


code-server 4.0.0 behind nginx reports wrong port

Using the following nginx configuration (fragment) in combination the SSL and code server reports port 80 in code-server instead of 443/https?
    location / {
      proxy_pass http://localhost:8080/;
      proxy_set_header Host $host;
      proxy_set_header Upgrade $http_upgrade;
      proxy_set_header Connection upgrade;
      proxy_set_header Accept-Encoding gzip;
    }

Same problem with my setup. I'm running code-server via JupyterHub as part of a JupyterLab image with Traefik as a reverse proxy.
@code-asher @jsjoeio @bpmct You may check at https://vscode-r.jupyter.b-data.ch.
ℹ I have whitelisted your GitHub accounts for this deployment back in June.

Propably completely independent from the proxy. Can reproduce it with Caddy and Apache ;).

@fritterhoff do you mind posting repro steps for Caddy? I have experience with that so it'd be easier for me to investigate

Well pretty simple and without any magic:

Configure Caddy:

mydomain.com {
  reverse_proxy <IP_ADDRESS>:8080
}

Restart caddy
Start code-server
Open code-server in your browser
Recognize that the port in lower left corner is :80 and service-workers don't work

@code-asher you mention in your last commit "does not work behind reverse proxies unless they send the right headers containing information about the proxied source" which headers would be required?

Forwarded is the best one (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded) followed by X-Forwarded-Proto combined with either X-Forwarded-Host or Host.

There might still be weirdness caused by the code explicitly adding an 80 or 443 to the authority for some reason but I think it will work if forwarding headers are set.

Mhm okay than the current implementation may also have a bug as caddy sets some headers by default:
By default, Caddy passes thru incoming headers to the backend-including the Host header—without modifications, with two exceptions:

    It adds or augments the X-Forwarded-For header field.
    It sets the X-Forwarded-Proto header field.

@code-asher Træfik also sets X-Forwarded-Proto and X-Forwarded-Host (among others) at https://vscode-r.jupyter.b-data.ch.
ℹ  See https://whoami.b-data.ch for all headers set by default by Træfik.

Huh, interesting.  There must be something else wrong with the code.  I am curious as to the problem but I ended up just removing the logic entirely in favor of just setting it to location.host on the frontend so it should just work regardless of headers now.  I might look into it later just to see what went wrong.

I poked into it anyway but it seems like the location headers should work:
> uri = getRemoteAuthority({headers: { "X-Forwarded-Proto": "https", "X-Forwarded-Host": "vscode-r.jupyter.b-data.ch" }})
> `${uri.hostname}:${uri.port || (uri.protocol === 'https:' ? '443' : '80')}`
'vscode-r.jupyter.b-data.ch:443'

And yet it is actually sending "vscode-r.jupyter.b-data.ch:80".
I guess it is academic at this point but quite confusing. :confused:

Ah...the headers appear to be lowercased so they do not match.  Not sure if they always come that way or if Express lowercases them.  :facepalm:

still same problem

As a temporary solution just in case this helps anyone, I've just made sure that X-Forwarded-Host returned the https://<code-server-url>:443 and everything works perfectly.

I fixed this issue in Apache by adding a Forwarded header to my apache config as follows:
RequestHeader set Forwarded "for=%{REMOTE_ADDR}s;host=%{SERVER_NAME}s;proto=https"
Not sure exactly what the syntax is for nginx, but a similar approach should solve it.


windows vm allocating all memory configured in currentMemory at startup

Describe the bug
My windows vm is allocating all memory configured in currentMemory at startup. Changing currentMemory with virsh setmem or virsh qemu-monitor-command instance-00000001 --hmp "balloon 4096"  can successfully change memory status in my windows vms, so the balloon service and balloon driver is working I think. Also checked the balloon driver's tracing events with TraceView.exe.
Any help will be appreciated. Thank you!

To Reproduce
Well, it's always appearing in my env.
Expected behavior
As for linux vms in my env, they use memory much lesser than currentMemory configured in vm's xml (RES value seen with host's top command). When setting memory balloon linux vms RES value seen on host will decrese to which the vm really needs. But windows vms are not working this way. I did a lot of searching and found proxmox wiki on windows vm memory ballooning(https://pve.proxmox.com/wiki/Dynamic_Memory_Management#Requirements_for_Windows_VM), did proxmox changed the mechanism of qemu simulator?

Also found that automatically changing memory balloon (currentMemory)  is never completed on linux-kvm page.
Main concerns are the difference between windows and linux vms  on memory usage shown on host.

Hello,
Is balloon service running? It is mentioned in Proxmox link.

Hello,
Is balloon service running? It is mentioned in Proxmox link.

Yes, blnsvr is installed and process running; Also tried different versions of blnsvr, all the same.
Or maybe I should try older versions?
By the way, does Memory Management Registry affect this behavior,  also tried turning off PAE etc...

What I am missing is the host statistics when Windows VM is running with and without inflated balloon. Otherwise the difference between Linux \Window can be a natural difference between those OSes.
BTW: KSM is a good way to save memory with Windows VMs that are not too active because Windows is actively zeroing unused memory.

What I am missing is the host statistics when Windows VM is running with and without inflated balloon. Otherwise the difference between Linux \Window can be a natural difference between those OSes.
BTW: KSM is a good way to save memory with Windows VMs that are not too active because Windows is actively zeroing unused memory.

Thank you for replying.
I just tried uninstalled blnsvr service and disabled virtio-balloon driver. Then my vm's memory cannot be set by balloon. On the host the memory occupation is always the maximum value, in my case 10GB. It works normal when enabled virtio-balloon driver, without installing blnsvrservice. Wondering what role is blnsvr service playing?
So it's due to the difference between OSes?
Have no idea how proxmox makes windows works just like linux vms. Have been exploring their git repo like pve-qemu, but didn't find any patch may related to this issue.

I am curious if windows zeros out all pages during booting up. Because if it is, then it is reasonable that Linux kernel will eventually allocates all pages.

CurrentMemory should be set the same as MaxMemory unless you known,what really you are doing. Inconsistent values can cause problem like this. I encounterd this problem as well.

I suggest not to rely on Linux host process memory overcommit mechanism due to different OS behaviour and Windows zeroing the memory.