Support callback with a new port

Changes

CumulusCI uses a new port (7788) for the built-in connected app to lessen the chances that the port is in use.
CumulusCI now checks if the port associated with a callback URL/redirect URI is in use during OAuth2 flows, and if so, raises a more friendly error.

@davisagli  - Current behavior in windows is that both commands open a web browser to the expected login page without error.
Also, switching the test to use socket.bind() fails in both osx/windows contexts. It's just that for some reason the httpd_thread() context manager in test_client.py seems to only replicate the issue in non-windows based environments. This seems to confirm what you were suggesting above: that this is really a fix for an issue in non-windows enviornments.
I've gone ahead and fixed the things you noted above, and also moved the opening the tab in the webbrowser to after we start the http daemon process so that if an error is encountered we don't open a new tab for the user.


Error in Twig Template

Hi,
so I forked and build gitlist locally for development.
When I updated my fork to the newest commit (3ad4f03), I'am getting this error:
Twig_Error_Runtime in layout.twig line 6: Neither the property "request" nor one of the methods "request()", "getrequest()"/"isrequest()" or "__call()" exist and have public access in class "GitList\Application".
Did I do something wrong?

Hi @garyee , sorry, I was working on master.
Could you try again either with the restored master? Thank you.
We should define, if we consider "master" as stable or development branch.
@alehaa I guess your like to have "master" as stable and do development in feature branches?

@garyee Ahh, I see now you were trying the current HEAD on master.
Can you give me some quick instructions on how to build GitList into a production environment so that I can reproduce and fix the problem? Thank you!

I see now the README warns:
"Do not download a branch or tag from GitHub, unless you want to use the development version"
So "master" should be considered a development branch.
We may of course change that...

We should define, if we consider "master" as stable or development branch.
@alehaa I guess your like to have "master" as stable and do development in feature branches?

master is, what is currently running and tested. Features will be developed in separated branches (in forks) and send as PR back to this repo, where we will test and merge them. From time to time we will release new versions as tags.

However, this bug seems to be a bug. ;)

It is indeed a bug. I'm on it and have now a development built up and running.
How do I reproduce the above error?

Hi, okay so I have an xampp on windows 7 running with Apache 2.4.x and php 7.1.2.
I just cloned from master HEAD and did composer install.
I did try to find the source of the problem but I'm fairly new to symfony and the dependency-injection stuff, so I did not succeed.

Sorry, I can't reproduce the issue here with PHP 5.5.9 on Linux. "ant" fully works for me.

This is probably due to the BC break overlooked. PR #36 fixes the BC break, where request has been replaced with request_stack. Looking at the original report this is related.


The file position error

Any function that calculate file position and return that value, is having wrong algorithm.
It may get right position for most of cases, however when it reaches to the end the position will be wrong.
There are 2 problems.

We are calculating current position from byte that has been read. Which leads to the wrong value.

Bytes that has been read - high water mark = wrong start position for end of file
Right start position needs to be just counted manually.
positionTracker += this.highWaterMark

Margin calculation would be wrong in end of file. Because processing chunk is we get is not equal to the high water mark.

We need to iterate through processing chunk to get data. Which means size of processing chunk will get smaller and reach to 0.
That's why we have current calculation like:
let margin = chunkLength - this.highWaterMark;
But the last read of file won't be size of the high water mark.
Therefore, just for the end of file we need to margin = chunkLength - (File.length - positionTracker)

no need for new version


Custom theme

I am trying to setup a custom theme in my project, but I am unable to see the different primary color.
As per the docs, I have the following in my theme.less file in src folder:
// -------- import official less file -----------
@import "../node_modules/ng-zorro-antd/src/ng-zorro-antd.less";
@icon-url: "/assets/fonts/iconfont";
@primary-color: #f5f36d;

And in my angular.json file I have:
"projects"       : {
    "abc-web-v2"     : {
      "root"        : "",
      "sourceRoot"  : "src",
      "projectType" : "application",
      "prefix"      : "app",
      "schematics"  : {},
      "architect"   : {
        "build"        : {
          "builder"        : "@angular-devkit/build-angular:browser",
          "options"        : {
            "outputPath" : "dist/abc-web-v2",
            "index"      : "src/index.html",
            "main"       : "src/main.ts",
            "polyfills"  : "src/polyfills.ts",
            "tsConfig"   : "src/tsconfig.app.json",
            "assets"     : [
              "src/favicon.ico",
              "src/assets"
            ],
            "styles"     : [
              "src/theme.css",
              "src/styles.css"
            ],
            "scripts"    : []
          }
        }
      }
    }
  }

In my HTML I have a button, like:
<button nz-button nzType="primary" nzSize="large" [disabled]="!validateForm.valid">
        <span> Log in </span>
        <i class="anticon anticon-login"></i>
</button>

But still I see the default blue color button.
Is there anything else that I am missing over here?

It says on Issue Helper to use it for bug/feature request.
But I have a question related to the usage. Also, it states that:

For usage questions, please use the following resources:
- Read the docs
- Look for / ask questions on StackOverflow or Github

This is what exactly I did. So either open the issue again for an answer or update the issue helper to submit a usage question!

@preraksola If you want to override the default theme, you should create a less file instead of a css file and import default theme file into it.
"src/theme.css",
"src/styles.css"

Hi @wendzhue that was a typing mistake.
It's theme.less in angular.json file.
Also, it would be helpful if you can add a stackblitz example in the docs for custom theme.


Marks persist when switching from lintable to not lintable buffer

Hi
Please find below steps to reproduce persistent marks problem:

Open lintable file which contains marks
From this file switch to not lintable file
You should notice that some letters in not lintable files are highlighted. This happens because Ale does not cleared marks info on buffer switch.

The ale_enabled check is needed, so that shouldn't be removed.
ale_enabled has not been removed. I just added one more condition for clearing matches state in order it happened when current buffer filetype has no associated linter.

Ah sorry, my bad.
I think this is not quite complete, as the same problem might come up when you open another file which is lintable. I'll think about this.

Yes, the problem occurs with files you can lint as well, as I suspected. A little bit of refactoring and an extra call in the existing cleanup function will fix it.

Here is the commit: https://github.com/w0rp/ale/commit/d8dcc56af58d1545cf3a7a9f6160d8ba6ad39923
That should cover this case, and changing to any other file in general.


fix(subscription): allow updating subscription tags and display name with AzApi

Overview/summary
Add the ability to update tags and display name if using azapi to vend a subscription.
This PR fixes/adds/changes/removes
Breaking changes
Testing evidence
Please provide testing evidence to show that your Pull Request works/fixes as described and documented above.

As part of this pull request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Run and make fmt & make docs to format your code and update documentation.
[x] Created unit and deployment tests and provided evidence.
[x] Updated relevant and associated documentation.

LGTM

Hi, can we make it depend on the subscription_display_name variable and not on the alias_subscription_enabled variable. Without an alias we can still change subscription_display_name. We are not able to create an alias in every situation (subscriptions provided by a CSP partner), but we can always change the display name.
Best Regards
Jacek

Hi, can we make it depend on the subscription_display_name variable and not on the alias_subscription_enabled variable. Without an alias we can still change subscription_display_name. We are not able to create an alias in every situation (subscriptions provided by a CSP partner), but we can always change the display name. Best Regards Jacek

Hi @jczerniak
Can you confirm the use case here?
Is it that you want to be able to update an existing subscription's tags and display name using this module?

Thanks for confirming @jczerniak
We are discussing options here and want to propose the following condition. We see a risk in overwriting existing subscription tags and display name as defaults are empty string. Hence proposing a new input bool (var.subscription_update_existing) to control this.
Thoughts?
count = (var.subscription_alias_enabled && var.subscription_use_azapi) || (var.subscription_id != "" && var.subscription_update_existing)

Latest Test after update

I'll fix the test pipeline tomorrow. Sorry Luke. Great work here

@luke-taylor this is now ready. I have updated the tests.
Can you take a look and see if you are happy?

@luke-taylor this is now ready. I have updated the tests.
Can you take a look and see if you are happy?

Good catches on the test updates, LGTM.


Fix false positive in border-zero

What do the changes you have made achieve?
This fixes a false positive when convention is set to the integer 0 (as opposed to the string, which does work), by casting the convention to a string.
Are there any new warning messages?
No
Have you written tests?
No but I've tested it manually
Have you included relevant documentation
Not necessary
Which issues does this resolve?
#861
<DCO 1.1 Signed-off-by: Richard de Wit<EMAIL_ADDRESS>

Coverage remained the same at 97.527% when pulling 51ecc398e697fc14cb3667cda4d0d4c1068282de on richarddewit:patch-1 into b7bcb3a4ec1a9c08d3883eb8c2acb97b6e6513c3 on sasstools:develop.

Closing this for https://github.com/sasstools/sass-lint/pull/913. Thanks again @richarddewit :+1:


Remove nbsp characters.

Due to an accident due to the way I've been typing em-dash characters, a bunch of non-breaking space characters have snuck in to the source here.  I never intended that, and I think having invisible characters that are not normal spaces can be confusing, so I just replaced them with spaces. There's still a few nbsp's where they are needed.

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

oh dear I never know what to do with diffs like that ....
@bors: r=

:pushpin: Commit 9a71c179769b9a4a836bbabec66b43c761c59596 has been approved by ``

@bors: r+

:pushpin: Commit 9a71c179769b9a4a836bbabec66b43c761c59596 has been approved by alexcrichton

:lock: Merge conflict
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.
How do I rebase?
Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout remove-nbsp (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self remove-nbsp --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.
Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.
Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging src/doc/src/reference/unstable.md
CONFLICT (content): Merge conflict in src/doc/src/reference/unstable.md
Automatic merge failed; fix conflicts and then commit the result.

:umbrella: The latest upstream changes (presumably #9750) made this pull request unmergeable. Please resolve the merge conflicts.

@bors r=alexcrichton

:pushpin: Commit 70a607eaa7432d262eccff909493e724edb8082a has been approved by alexcrichton

:hourglass: Testing commit 70a607eaa7432d262eccff909493e724edb8082a with merge d555e49abee3e68036402f89e31f208a793cace1...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing d555e49abee3e68036402f89e31f208a793cace1 to master...


Mixpanel updates to message count and gas refund

Background
Describe the problem that we are trying to solve with this feature.
If a path to a solution is known, feel free to write it down, but have an open mind
In mixpanel, we want to have the total number of messages sent. We already have the total number on the website, but are missing the number of the older contracts.
The gas refund events are correct, but not useful at the moment as they are not shown in USD. To evaluate the network cost across chains for the business, we want to know the cost in USD
Done when

[x] we have the total number of messages in mixpanel (so that the number matches the website).
[ ] The gas_refund events are show in USD instead of MATIC and BNB

remaining task moved to Volume


remove Bookmark.learned boolean as it's redundant with learned_time

normalization!

I have looked at this one and I think it should be ready to merge, though I think it might be better to do after we complete the new topics/elasticsearch v8 migration.
So for now, I will just create a draft PR from the branch, and then we can look at it once we have completed the deployment.


[snowflake] implement most of snowflake dialect and override functions

Go over all functions supported by malloy and ensure we provide overrides for functions that differ from default implementation
Implement some 33 abstract functions required to create a sql query from a given a malloy source file

Todo:
Write tests, ensure basic sql conversion works

Current dependencies on/for this PR:

main

PR #1

PR #2   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 9, 12:34 PM: @pavanka started a stack merge that includes this pull request via Graphite.


disable header background autoplay video

Consider disabling the autoplay background video currently on the site.
Autoplaying background video or animation can trigger various motion-related disorders.
Why iOS 7 is making some users sick
In general I would say any autoplay video whether foreground or background is not a best practice.
Safari in the new Mac High Sierra OS (10.13) will reportedly block autoplay video.
For now I am blocking the background video with Adblock Plus filter: digital.canada.ca##div.page-banner--video

or provide the user with the option to stop or pause it

we've added a pause/play button on the website, we will also remove the video on mobile view as it has a problem on Android. commit for the changes will follow.
thanks so much @TouficS and @scilib

Adding a pause button is a good step forward.


Migration Action throws error when there are non Action files within the actions folder

Environment

PHP Version: 8.1
Database Driver & Version: MySQL
Migration Actions Version: 3.x
Laravel Version: 9.x

Issue description
I have a subfolder within my actions folder that does not contain Action classes.. example:

By Running php artisan migrate:actions I get the following error:
  DragonCode\LaravelActions\Services\Migrator::resolveAction(): Return value must be of type DragonCode\LaravelActions\Action, int returned

I think files that do not extend Action shouldn't be taken into account or files that don't start with xxxx_xx_xx_xxxxx_..... etc...
Steps to reproduce
Create any file within a subfolder inside the actions directory and run php artisan migrate:actions

Yes, in the 3rd version all subfolders are now read.
You gave me an idea: today I will make it possible to set exceptions for folders when searching for files in the settings.

Wouldn't it be easier to have a regular expression excluding any file that doesn't match the pattern? xxxx_xx_xx_xxxxx?

I thought about it, but, unfortunately, not all developers prefer this file format. I have seen projects where files were created manually without a time prefix.
Making an exception for a folder is easy, I will write tests longer :-)
As soon as I get to the computer, I'll do it.

Released in v3.1.0.
Run the composer update console command and update your config file.


Deploy in CustomRegion again to test multi-region capability

Regression from the switch to crowbar_batch

+1

+1 What about other scenarios?

+1

@jsuchome which other scenarios? there is only one (the others are qa)

Yes, I meant QA ones, just in case they need it. But than QA would request it to be tested, so I assume we're fine there.


Current Test Suite is Hard to Maintain

Some tests, such as AlmostE2ETest.java, contains variables that point to local files and database connections that needs to be hosted locally. These variables are not used, but it can create confusion to how the tests actually work.
Many tests, such as PreAnalyzerTest.java, do not contain assertions and instead prints out certain outputs. This is unreliable as the test will always pass, even if the outputs are wrong. Assertions should be used instead of prints.
Some tests, such as RangeAnalyzerTest.java, have unfinished FIXMEs which renders the test useless.

In PreAnalyzerTest.java, I actually added new tests for spatial patterns in this PR: 75. For legacy tests, I think some of them might not be needed anymore (?)
For AlmostE2ETest.java, I guess it is intended for end-to-end test with external database. Maybe we need to modify it to utilize local database (e.g., in CSV format)?
I also want to add an issue with LabelAnalyzerTest.java, I think there is a problem with the JUnit version. The project uses JUnit 4, while the test presumably uses JUnit 5. Consequently, the test could not be run correctly.
For other tests, should we convert them to unit tests (each test correspond to a certain module) or let them be as is and adapt them to utilize assertion, mock, etc. if needed?
cc: @snowgy


Fixed the community name and a link

This pull request was made due to an issue raised!
#277

Changed and updated the community name
Fixed a link

This should have been two pull requests but this is okay for now.


[Bug] Cannot login to the application

There are no instructions in the user guide to register and the log in steps shown on the home screen doesn't seem to work as well.
I tried looking into the generated preferences file, but the admin password is not humanly possible to type and ctrl-v inputs only 1 dot into the command box.
I tried passwordSaltInString as well but it didn't work.
Not sure what else I can do here and I hope you guys can sort this out :)

Okay, I found a sample account from the other threads


Rebalance model to better distribute scores?

Could it make sense to rebalance the base models for better score distribution? Everything on my top list seems to be falling between 3.5 and 5.

Yeah, it'd make sense. I'll see what I can do, but I don't think we'll get anything done before Tuesday.


Dedup assertion in MpiCommunicatorBase.allreduce

msgtype.is_tuple is checked twice

Jenkins, test this please.

LGTM, waiting CI finish.

Jenkins CI test (for commit cc3521c126e5508eab7f06f60c1a5c72a6024ef0, target branch master) succeeded!


Fix broken link in README.md

"TensorFlow Lite Android image classification example" links to a missing tensorflow.org page and returns a 404 error. The intended resource can be found as a markdown file in this repository and the link has been updated.

@googlebot I signed it!

Unsubscribe
Sent from my iPhone

On 23 Dec 2019, at 00:20, MichaelSaffold<EMAIL_ADDRESS>wrote:

@googlebot I signed it!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


WEBAPP-25: Add VERSION define

Indeed, this will help us to identify the current version on https://integreat-1173.firebaseapp.com/

What about merging? 😄

@Schedulaar yee, meh. Footer is now ready right? So we could use this now :P


Log db view

@ticoann, I added logdb.js function and show how to use it in example2.html. Now I think it can be plugged into wmstats page (possibly we need to add overlap CSS elsewhere that this div element will overlay any other html content).


feat(protractor): add e2e tests in CI

close #732

Appveyor
[02:04:45] Starting 'e2e'...
Using ChromeDriver directly...
[launcher] Running 1 instances of WebDriver
Spec started
Started

  App
    ✓ should have a title
.    ✓ should have <nav>
.    ✓ should have correct nav text for Home
.    ✓ should have correct nav text for About
.
  About
    ✗ should have correct feature heading
      - Failed: No element found using locator: By(css selector, sd-app sd-about h2)
F
  Home
    ✓ should have an input
.    ✓ should have a list of computer scientists
.    ✗ should add a name to the list using the form
      - Expected 'Edsger Dijkstra
Donald Knuth
Alan Turing
Grace Hopper' to equal 'Edsger Dijkstra
Donald Knuth
Alan Turing
Grace Hopper
Tim Berners-Lee'.
F

@Shyam-Chen awesome! The build is passing now. Are we ready to merge?

@Shyam-Chen really awesome job! Left some minor comments.

OK

LGMT! @Shyam-Chen ready for merge?

merge


404

I keep getting a 404 when I attempt to open a video file using your server:
<IP_ADDRESS> - - [17/Jul/2017 23:27:54] "GET /library/Movies%2Mv1184_watts_sd.mp4 HTTP/1.1" 404 -
Any ideas?

How do you get that link? Through the browser?

Thats the error that gets thrown on the cli in on the server when I try and click on a video in the browser.

Hey,
I was getting the same error. If you remove the try: except block in @app.route("/library/<path:path>") you can see where it fails if you have debug mode enabled. Then you'll see that the app wants to write to a file in cache/ but gets a No such file or directory error. So just create a directory named cache inside the library directory and you're good.
Maybe @derolf can add an empty folder to the repository so in the future people can just clone the app and start using it.


refactor(utility): use "config.timeout" as the argument of urlopen

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 86.595%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
7616

Relevant Lines:
8795

💛  - Coveralls


Return button functionality and side menu

The implementation of the 'return' button in our app is quite random and not very predictable. NetFlix appear to have a much more sensible implementation of it., which is the one we should follow:

Rule 1: On the home screen, return button opens up the side-nav menu
Rule 2: The return button does not exit the app - only the home button does that
Rule 3: The return button on an item page will return the user back to the home screen.

In our app, the return button exits the app from the home screen which it should not do.
In our app, if you move through the menu sections, and then press the return button, it takes you back through the sections of the menu (but without changing the highlights) that you've just navigated through. This is very confusing.
I think the problems I was experiencing with the nav are related to our use of the return button.
If we copied the simpler rules from Netflix it would make it more usable and simpler.

Jira ticket https://jira.atlassian.roh.org.uk/browse/RD-7535

The correct description of task here:
The implementation of the 'return' button is problematic.
If pressed then it moves the user through the side-navigation.
We should follow the BBC iPlayer approach:
Pressing 'return' when on the main screen opens up the side nav
Pressing 'return' when on the side nav opens up the modal to confirm app exit
The return button should not move the user through the side nav.


Multiselect + Subitems + Deletion problem

Based on your multi select and expandable list example, I'm trying to combine those two - I think I did not change anything relevant.
Showing the data with headers works fine, expanding/collapsing works fine. BUT as soon as I start deleting something, it get's messed up.
Observations

deleting items and not collapsing anything works visually fine

Problem

I select the first sub item and delete it, then I collapse the first header and see, the second one is missing
I select the first two sub items and delete them, then I collapse the first header and see, the second and third header is missing

Afterwards, more problems occur (expanding a header that still exists will show selected items for example, ...)
How I set up my adapter
	mFastAdapter = new FastItemAdapter<>();
	mActionModeHelper = new ActionModeHelper(mFastAdapter, R.menu.menu_folders, new ActionBarCallBack());

	// 2) FastAdapter Setup
	mFastAdapter.withSelectable(true);
	mFastAdapter.withMultiSelect(true);
	mFastAdapter.withSelectOnLongClick(true);
	mFastAdapter.withOnPreClickListener(new FastAdapter.OnClickListener<IItem>() {
		@Override
		public boolean onClick(View v, IAdapter<IItem> adapter, IItem item, int position) {
			//we handle the default onClick behavior for the actionMode. This will return null if it didn't do anything and you can handle a normal onClick
			Boolean res = mActionModeHelper.onClick(item);
			return res != null ? res : false;
		}
	});
	mFastAdapter.withOnPreLongClickListener(new FastAdapter.OnLongClickListener<IItem>() {
		@Override
		public boolean onLongClick(View v, IAdapter<IItem> adapter, IItem item, int position) {
			ActionMode actionMode = mActionModeHelper.onLongClick(mActivity, position);

			if (actionMode != null) {
				//we want color our CAB
				mActivity.findViewById(R.id.action_mode_bar).setBackgroundColor(UIUtils.getThemeColorFromAttrOrRes(mActivity, R.attr.colorPrimary, R.color.material_drawer_primary));
			}

			//if we have no actionMode we do not consume the event
			return actionMode != null;
		}
	});

How I fill my data
	// List of sub items without headers
	List<FolderItem> folders = ...;

	// Test - group items in groups of 10
	List<IItem> items = new ArrayList<>();
	int count = folders.size();
	int headers = (int)Math.ceil((float)folders.size() / 10f);
	for (int i = 0; i < headers; i++)
	{
		FolderItemHeader header = new FolderItemHeader()
				.withHeader("Header " + (i + 1))
				.withName("Header " + (i + 1))
				.withDescription("Description...")
				.withSubItems(folders.subList(i * 10, Math.min(count, i * 10 + 10)))
				// ALL folder items have an id that represents the rowid in the database, so
				// the ids are > 0 AND unique for sure!
				// using ids < 0 will result in no confilcting ids for sure
				.withIdentifier(-1 - i)
				.withIsExpanded(true);
		items.add(header);
	}

	// set data
	FastItemAdapter<IItem> fastAdapter = (FastItemAdapter<IItem>)mBinding.rvData.getAdapter();
	fastAdapter.setNewList(items);

@MFlisar sorry for not yet answering. I am very busy at the moment.
Having collapsables + deleting is a really tricky topic. :/. Will I be able to just copy paste your above code and debug it?

I'll make an example for you tomorrow. Thanks for looking into it

Here's the example:
https://github.com/MFlisar/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/ExpandableMultiselectSampleActivity.java
You can use my repo directly, it can be compiled and I added the new activity to the main activity and you can start it via the drawer
Bug
Expand the "Test 1" row, then select 1 to n sub items of "Test 1". Click delete. Until now, everything is fine. Now collapse the "Test 1" row again and you will see that "Test 2" until "Test [2+n]" are gone after collapsing. If you then expand the "Test 1" row again, you will see that "-- Test 1" until "-- Test [n]" are there again and selected...

@MFlisar thanks for the demo applicaiton.
After testing it. There is a simple answer to this. Deleting subitems via the normal methods is not supported.
Long answer:
To be extrem fast and extrem performant, the FastAdapter has to keep track on which items are selected / not selected. It will also treat sub items not as normal items. They are temporary and will not exist in the normal item level. So if you delete with the deleteAllSelectedItems it goes over the list via the positions removes the items. as subItems are temporary shown there it will delete the elements at these positions. the ui will hide them as the recyclerview just animates them away. but in the background the original items (the one not on a sublevel) are deleted.
I am also not yet really surewhat the most performant solution for this scenario would be. :/
Especially as removing sub items should result in removing the items from the list inside its parent. not inside the main list.
The whole thing add some complexity. That's also why you can't currently notify about sub item changes for sub-sub hirachies.

I would write the algorithm to search for the correct item and remove it from it's parent. One question though - is it enough to remove the item from the parent items sub list and then call notifyAdapterItemRemoved on the adapter? Or is there some other special handling of those temporary items necessary? Looks like it is that easy from your description.
Performance wise I would do following:

sort the selected indizes descending
for each selected item search for the parent - if you find it remove ALL selected children (easy, because selectionindizes are sorted). Parent will be searched based on the highest selected index, looking upwards until the parent is found

I could than make a pull request for it as well, still, where would you like to have this? Maybe in a SubItemUtility class or so?

@MFlisar if sub items change there is the notifyAdapterSubItemsChanged method which needs to be called. It will then take care if items were deleted or added.
But it's true there should be some SubItemUtils class which adds some helpers for sbitems

So the utility class needs to take care of following:

notifyAdapterSubItemsChanged only works for first level children, correctly?
what must happen for sub sub items? notifyAdapterItemRemoved with the total index is fine, isn't it? I won't use sub sub items for now, but I would like to repect them as well

notifyAdapterSubItemsChanged correct. The hope is anyway that this will do also sub, sub, sub ... hirachies.
Sub sub sub hirachies would not really work via all the notify methods. that's the point. sub items are outside of the normal items range, as they should not alter the general list.
(as an alternative I would have been able to do a simple implementation of the "subItems" where the parent would just add those items, and remove them again, and they would be in the normal list, etc... but I think this would have some other ba^d side effects)

So far, it looks quite good already.
I will allow to notify the parent in the util automatically, so that it can update the count (if it is displaying the count of sub items). I experienced, that calling notifyAdapterItemChanged (I call this on the parent only) will collapse it. Is that really necessary?
I solve that with following:
expanded = ((IExpandable)parent).isExpanded();
adapter.notifyAdapterItemChanged(parentIndex);
// expand the item again if it was expanded before calling notifyAdapterItemChanged
if (expanded)
    adapter.expand(parentIndex);

Though shouldn't this be the default behaviour?

Another problem with mutli selection is and expandable items is, selection is lost if you collapse and expand an item..
I am handling the expand/collapse action manually anyways, so I just disable collapsing when you are in the selection mode for now. I am not sure, where this thing should be handled if I don't disallow collapsing.
I had following idea, the utility class could help remembering selected items of collapsed items, but this looks not really beautiful to me. But because you are handling sub items as temporary items, maybe this is the best solution? This will only work if you collapse/expand items manually of course, as you have to handle this events in the utility to add/remove selected sub items ids correctly to a helper class...
Any other ideas?

@MFlisar the selection is only lost in the position based state management, but not if you disable this one and use the identifier based statemanagement

https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L228

The reason for this is, that the position based statemanagement can't keep the selection for an item which is no longer there. The alternative statemanagement can do this as it will keep the identifiers of the items.

I have a working example with expandable headers + multi selection. As soon as I activate the id based state management and start my app, instead of showing all items expanded they are shown collapsed. Expanding the first item and collapsing it again removes all other headers...
I will make a pull request with the index based statement management and add an example to demonstrate this feature (multi selection + expandable items + deletion of items). It's working fine so far.
Maybe you can check what's the problem with the id based state management then? Or have an idea straight away?
PS: additionally I've added a RangeSelectorHelper. It will take care of selecting a range of items via long pressing the first and the last item (QuickPic has this for example). It's a nice feature an can be easily activated with the helper...

An example is online, it shows multi selection + expandable items + deletions + range selection via long pressing first/last item of range. All with position based statement manager. It's working so far.
You can test it, it's here:
https://github.com/MFlisar/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/ExpandableMultiselectDeleteSampleActivity.java
As soon as you enable the id based state management, it breaks. Just uncomment line 60 to test it.

@MFlisar currently at a conference. will have to check later.

There is another problem I'm currently investigating. So wait until I have described this problem here. It's something with notifying items about changes...

I disabled notifyParent for now and added some debugging logs, they show which items my algorithm deleted. And you see, that the algorihm is working fine. Still there is a bug.
Bug description
In some cases it happens, that expanding a header shows wrong (double) items.
Bug reproduction - finally I found a simple reproduction
Start the demo and do following:

select all 5 sub items of "Test1"
delete them
collapse item "Test 3" => this results in expanding the item and suddenly it has all it's sub items twice
collapsing "Test 3" again only removes have of the items...

Ignore the deleteSelectedTEST function... I tried a few other methods to solve the problem but none really worked, I think it's something in the adapter...
Info

my function calls notifyAdapterSubItemsChanged after EVERY update of a parents sub items (sub items are deleted directly from the parents sub items list before calling this)
items without a parent are deleted via the adapter.remove(pos) function

I think that's correct so far...

@MFlisar so if you remove the withIsSelected(true) from your sample, use the (newly added) .expand() method (which will expand all on the root level). and then delete it will work fine.
Perhaps we should just limit this use case to the id based state management as it will cause quite some overhead for the normal state management

@MFlisar ok after some more digging, I was able to detect 2 problems which were causing this issue when deleting. After applying the fixes it works now fine ;)

I shortly tried it in my app, seems to work, thanks. I'll test it a little more though...
One thing though, being forced to use 'adapter.expand()is somehow weird as long as thewithIsExpanded(true)is possible. It should be possible to implement the same logic in thesetList, setNewList, add` functions of the adapter, shouldn't it? I think both cases should behave the same...

ID based state management
You said, the adapter should remember selections if we use the id based state management, it does not work in the example...
I've already submitted my changes to my fork...

@MFlisar are you sure? https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L1279 deselect is not called in this case

I am. The example shows it. I'll check it though and check why this happens. The example shows, that the selection is already resetted here: https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L407
Problem that I found while testing
In my own project I have another problem, my items use their database id as identifier, so I thought I make headers, that start at -1 and decrease the count... I now found out, this breaks your internal logic, because -1 is consider as no id... Any reason for this? Identiefier could be a Long instead of long and no id could be null...
My solution is to start with -2 now instead, still, not very intuitive I think

PS: I think I'm right, you save the selection in the items if the id based state management is used:
https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L818

Ok. I will have to debug this.
The link to the code you sent may be the problem.
we use long as it is better to use primitive types. and you can still use any really high ID near MAX LONG or so.
To honest I am not sure if I never use i < 0

Ok thanks.
Only idea I have so far about sub items and selection is, that the parent could remember which of it's children are selected as an alternative (would even work for both state managements)...
Considering the id, I'm not sure how save MAX_LONG - headerCount would be, the database may create such ids one day as well (although it's very unlikely...)

It will get complicated again when restoring selections with the savedInstanceState when the parent remembers.
Issue with the selections is that we currently do not iterate over the childs. So they stay selected but you do not get them via the method. getSelections()
if you get near MAX_LONG - headerCount you will have a real problem anyway. Also some additional information. RecyclerViews in Android can have at a maximum MAX_INT entries

I'm not talking about having max long items, just the unique id may get there because of constant deletions and additions which will create a new unique id... Not sure what the database will do if it reaches max long, it should not start at 1 again, as relations may still point to this old id... But that's not a problem with this library..
I think it actually should be save to create the ids for the headers as you suggested

so the last "issue" is now getting the selections inside getSelections
I may just need to add a recursively algorithm there

I think there is something else to consider: you can't handle the indizes for the collapsed items in index based selection functions like the one mentionied by me before:
https://github.com/mikepenz/FastAdapter/blob/develop/library/src/main/java/com/mikepenz/fastadapter/FastAdapter.java#L818
Getting selected items works with a recursive function though...

Something else to cinsider: the ActionModeHelper for example works with Set<Integer> getSelections() which can't return selected sub items... This leads to problems. Probably there are more places that have to take that into account.
Allowing to select hidden items, may bring up a few other side effects...

The recursive function is here if you want to test something:
public Set<Item> getSelectedItems(boolean includingCollapsed) {
    if (!includingCollapsed)
        return getSelectedItems();

    Set<Item> selections = new HashSet<>();
    int length = getItemCount();
    List<Item> items = new ArrayList<>();
    for (int i = 0; i < length; i++)
        items.add(getItem(i));
    updateSelectedItemsWithCollapsed(selections, items);
    return selections;
}

private void updateSelectedItemsWithCollapsed(Set<Item> selected, List<Item> items) {
    int length = items.size();
    for (int i = 0; i < length; i++) {
        if (items.get(i).isSelected()) {
            selected.add(items.get(i));
        }
        if (items.get(i) instanceof IExpandable && ((IExpandable)items.get(i)).getSubItems() != null)
            updateSelectedItemsWithCollapsed(selected, ((IExpandable)items.get(i)).getSubItems());
    }
}

Further problems

My SubItemUtil tries to get an items parent with the help of the adapter. This is already slow... But if I don't know, that the parent is in the adapter somewhere above the item, I must search for the parent from upside down, which means I have to search through every top item, check it's children and check the children recursively until I find my item, otherwise I can't find an items parent... Can be optimised, but still it's a little problem...

Alternatively, disabling collapsing items with selected sub items would be a "solution" as well... Although not the perfect one...

@MFlisar that's true. We may need to move the recursive function to the SubItemsUtil which then allows you to get the selections + sub items.
What may also could help is creating a connection between childs and parents. So we will always know which items are sub items, and which items are the main parent. (this will also allow to get ot the parent, because we know that it will be my total position - my position in the sublist)
So having
IItem (id = 1, level 0)
    ISubItem implements IItem (id = 2, parent=1, level 1)
         ISubItem implements IItem (id = 3, parent = 2, level 2)
         ISubItem implements IItem (id = 4, parent = 2, level 2)
         ISubItem implements IItem (id = 5, parent = 2, level 2)
    ISubItem implements IItem (id = 6, parent = 1, level 1)
    ISubItem implements IItem (id = 7, parent = 1, level 1)

getting the positions for the selections will always be a problem, thus it will always just return visible items.
deleting items only allows to delete normal items anyway so child items should be ignored here

I wanted to suggest the two way linking as well, there is no other way to make the slow search functions in the SubItemsUtil faster. This will make most of them as fast as O(1)...
So I would suggest make following:

SubItemsUtil gets a getSelectedItems(adapter) function, that returns a Set of selected items, including all sub items, independent of recursion depth (there won't be a function to get indizes, the one from the adapter will stay the only one and will return visible indizes only)
a new ISubItem interface is added to the core
SubItemsUtil will only work with items that implement ISubItem and/or Expandable
I suggest, SubItemsUtil ignores items that do not implement ISubItem and/or Expandable (if you have to care about such items, the functions get slow again, as you have to search for this items manually again)

I would suggest following interface:
public interface ISubItem<T, Item extends IItem, S extends IExpandable<T, Item>>
{
    S getParent();

    // I would NOT add this, level can be easily calculated via traversing the parents and counting them
    int getLevel();
}

If you don't have any objections, I would make it like that and make the necessary changes...

@MFlisar the above metioned points sound fine.
One more addition. The IExpandable interface has to be changed to be:
public interface IExpandable<T, Item extends IItem & ISubItem > {

The additional question is if it shouldn't be required that the ISubItem has extends IItem as it will always have to be an IItem too

And yes the level can be dropped, as it would only result in problems when not correctly recalculated.
It is ok if you make the necessary changes :)
Afterwards I will have a look and perphaps it is possible to simplify the FastAdapter core code too with the above changes

If we change the IExpandable interface, that's a breaking change though... It's fine for me though and has the positive side effect, that I can be sure that sub items are ISubItems which makes everything safer... But people who use IExpandable already must adopt their items to link them with their parent. But I think it's worth it too.
Then I'll start with the adoptions ;-)
I will adopt the example afterwards and update my fork and inform you here...

@MFlisar I know :) But we will release the next version as v2.0.0 which can have some breaking changes ;)
Oh wait one more second I will merge the PR from @Rainer-Lang first. So you don't run into merge conflicts afterwards

I think if you allow to collapse headers with selected sub items, it makes sense (from a user point of view) to show the selection count of sub items on the parent. Therefore I think it makes sense that the core adapter offers a possibility to listen to selection changes via a interface like:
public interface ISelectionListener {
    /**
     * is called, whenever the provided item is selected or deselected
     * the parent should also contain this sub item in it's sub items list
     *
     * @param item the item who's selection state changed
     * param selected the new selection state of the item
     */
    void onSelectionChanged(IItem item, boolean selected);
}

What do you think about that?

@MFlisar yes that's a really good idea, as selection change must not directly come from the user clicking on a view (which then can also be blocked)
Really good idea. Thanks.

Ok.
I tried following to update the parent of an expanded item:
boolean expanded = ((IExpandable)headerItem).isExpanded();
int pos = fastItemAdapter.getAdapterPosition(headerItem);
fastItemAdapter.notifyAdapterItemChanged(pos);
if (expanded)
    fastItemAdapter.expand(pos, true);

This leads to all sub items losing their selection state on the view. Any ideas why? I thought notifying the the sub items via the true in the fastItemAdapter.expand(pos, true); should do the trick...

EDIT
Following works as it bypasses the FastAdapter's internal functions:
fastItemAdapter.withSelectionListener(new ISelectionListener() {
@Override
public void onSelectionChanged(IItem item, boolean selected) {
if (item instanceof SampleItem) {
IItem headerItem = ((SampleItem)item).getParent();
boolean expanded = ((IExpandable)headerItem).isExpanded();
int pos = fastItemAdapter.getAdapterPosition(headerItem);
fastItemAdapter.notifyItemChanged(pos);
}
}
});
For this use case, that's actually fine, as I really just want to update the view and am sure, that nothing else should be done...

You said, you will look over it and make some improvements in the core anyways, so the state is following:

ISelectionListener is called in a handful of places, currently it may be called multiple times => select/deselect functions would need an additional parameter boolean notifyListener for this I would say
The SubItemUtils have one place, where they work with a FastItemAdapter and not with a plain FastAdapter. I have not worked with wrapped adapters yet, so I'm not sure how this should be changed: https://github.com/MFlisar/FastAdapter/blob/develop/library-extensions/src/main/java/com/mikepenz/fastadapter_extensions/utilities/SubItemUtils.java#L202. This should be adopted... And afterwards the unsafe cast here https://github.com/MFlisar/FastAdapter/blob/develop/library-extensions/src/main/java/com/mikepenz/fastadapter_extensions/ActionModeHelper.java#L190 should be removed

That's it so far, I would say, the example is online and working

One very important thing I just stumbled over in my app is following:
Whenever you update an item in your adapter, you must update parent/children as well. I for example load items in an empty state, display them, then I finish loading them and then I replace the old items with the fully loaded ones.
This brings up the question: shouldn't items that implement IIdentifyable overwrite hashCode and equals so that those are handled as equal in all functions? I'm not sure if something in this direction makes sense...

for the first comment. I have no idea why this happens. expand shouldn't remove the state
the second comment. It is ok if you do this when really just changing general information, for more this will cause issues as the internal methods are not called with it
third comment. yes I have to look at it anyway to make sure things work as expected. preventing multiple calls, yes I have to check this. will take a look, but it shouldn't be the FastItemAdapter
the fourth comment. I don't think this is necessary. at the moment I use the identifier to check if items are equal so this should be fine. no general equals methods used
could you open a pr with the chagnes. will make it easier to check what is changed and to test. with your branch I can't directly see what is different

I'll make a PR soon, have to still do a small change...

@MFlisar ok great.


Update Quality level 2

Codecov Report

:exclamation: No coverage uploaded for pull request base (foxy@f917106). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             foxy     #26   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?       1
  Lines           ?       9
  Branches        ?       2
======================================
  Hits            ?       0
  Misses          ?       9
  Partials        ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f917106...4370184. Read the comment docs.


CRS attribute test failures

In GitLab by @visr on Nov 25, 2019, 16:08
Since<PHONE_NUMBER>40124c673871529719a8081c68d777 (cc @tessodk) quite a few DataArray.identical tests failing. Due to one having the CRS attribute, and not the other.
So it seems not setting crs is better than setting it to None. Is xarray's open_rasterio still setting it to None? Or is there a rasterio CRS object that represents unknown, or should we use np.nan? Would be good to be consistent here, it may be better to have a attribute set to missing than a missing attribute.

In GitLab by @Huite on Dec 9, 2019, 18:54
The primary issue is that None is not accepted by NetCDF (and I think the way the code works, zarr won't accept it either). So not setting it is really the easiest option, which appears to be what open_rasterio does.
Actually, I'm not sure where the None idea came from...


Auth token instead of password?

Would it be possible to use an authorization token instead of password?

lol yeah there is no way I'm giving this my password, although I'd like to use this utility


Use regular expressions to exclude the url

When using the ExcludeUrlFilter, I need to specify the Url to exclude.
public boolean filter(String requestURI) {
    for (String excludeUrl : this.excludeUrlList) {
        if (excludeUrl.equals(requestURI)) {
            return FILTERED;
        }
    }
    return false;
}

pinpoint.config
profiler.tomcat.excludeurl=/exclude/foo.html, /exclude/bar.html, /aa/exclude/foo.html

is it better to use regular expression?
I can use a regular expression as follows:
for (String excludeUrl : this.excludeUrlList) {
    if (Pattern.matches(excludeUrl, requestURI)) {
        return FILTERED;
    }
}

profiler.tomcat.excludeurl=/exclude/(.*), /(.*)/exclude/(.*)

regular expression is too complicated.
I think the Ant-style seems to be easier.

http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/util/AntPathMatcher.html

:+1: agree, the Ant-style is easy to read and use.


Activate bastion for Berkshelf

This PR will enable bastion for Berkshelf, allowing berks upload to work in a bastion setup.

LGTM


Add support for FunctionOrchestrator service

Created orchestrator class that manages a list of functions and will call selected functions based on a openai response.
Test cases are also added in 'test_orchestrator' file.
import json

import openai

from openai_functools import FunctionsOrchestrator

def get_current_weather(location, unit="fahrenheit"):
    weather_info = {
        "location": location,
        "temperature": "72",
        "unit": unit,
        "forecast": ["sunny", "windy"],
    }
    return json.dumps(weather_info)

orchestrator = FunctionsOrchestrator()
orchestrator.register(get_current_weather)

openai.api_key = "sk-<>"
response = openai.ChatCompletion.create(
    model="gpt-3.5-turbo-0613",
    messages=[{"role": "user", "content": "What's the weather like in Boston?"}],
    functions=orchestrator.create_function_descriptions(),
    function_call="auto",
)

if __name__ == "__main__":
    function_results = orchestrator.call_functions(response)
    print(function_results)

for Monday: update to current main to fix actions runner py version. Final touches such as type hints, then LGTM


Try to get Sonatype credentials from system properties and environment variables

In RxScala, we use Travis CI to publish artifact files to Bintray. However, it cannot synchronize to maven central automatically because the Sonatype credentials need to be typed manually.
This PR enables the user can set the Sonatype credentials in system properties or environment variables. Then we can use secure environment variables of Travis CI to set the credentials and make the synchronization automatically.

on, nice! thanks @zsxwing

Any plan to release a new version recently?

I can shoot for this weekend.

Cool. :+1:

done

Thanks a lot!


Use extensions to configure plugin instead of project properties

Remove the need of using command line parameters. Used gradle extensions instead.
Remove also the dependency to github. We can use gitlab or an other git host.

Thanks, I couldn't get extensions working back when I first worked on this, no idea why

I'm tweaking this locally, if you don't object, I may want to merge my modified version in a day or so

Hi,
You can modify it like you want, add camel case or not. It's yours !


Create piy1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

made some changes


Add-on not updating in Zotero

I am still on version 0.03 in Zotero (Windows 10, Zotero 6.0.14-beta.3+ae5de2c2f).
When I try to update in the Zotero Add-ons Manager window, it returns "No updates found".
Is the automatic update possible with this plugin, or does it require manual updates?
If it is not implemented yet, would it be possible to allow updates from Zotero?

I haven't looked into how automatic updates work, so right now I update it entirely by hand


Example

A quick example on how to test if powerline-docker is properly running/installed would be extremely helpful.

Thanks @open4storage, I will include instructions to debug it.


Hardlink instead of rsync

I am not well-versed in that matter, but I had the thought whether hardlinking the files would actually be a better idea.
From what I think I understand, hardlinks are directory entries that point to the same inode already referenced in another directory and/or entry. Inodes have a reference counter, so when deleting a file (path), the corresponding entry is removed and the actual inode is only really deleted if it has no more references. Does this behaviour differ in different file systems?
The only reason to use plain cp or rsync or otherwise creating new inodes with the same content then is to either then modify the independent copy, or when the two locations are on different file systems, right?
In case that all holds true, and if my assumption is correct that we expect the number of cases where /usr/lib/modules/backup/ somehow is a different file system to be negligible, then it would be a much better idea to just hardlink all the files with cp -lr: It doesn't use more space and is much faster because only directory entries are written. Being deleted should not erase the data because of the reference counter and restoring the modules will be the same, just the other way around.

To add to this report: cp(1) is 10x faster than rsync here.
# time cp -alr "/usr/lib/modules/${KVER}" /usr/lib/modules/backup
cp -alr "/usr/lib/modules/${KVER}" /usr/lib/modules/backup  0,26s user 0,26s system 105% cpu 0,497 total
# time rsync -AHXal --delete-after "/usr/lib/modules/${KVER}" /usr/lib/modules/backup/
rsync -AHXal --delete-after "/usr/lib/modules/${KVER}"   1,17s user 0,80s system 41% cpu 4,731 total


Fixes #464

Deny and Allow were in the 'opt-out' line. Code fixes.

@relicmelex Alright it is at it is. But TBH I'm not happy that contributions and credits are gone this way.

@thexmanxyz We're in a phase at the moment to get things done so we can get a release out with a bunch of bug fixes. Then we're going to do add some features, do some refactoring and reorganization, and when that happens not only will it be easier to make contributions but they'll be tracked and kept. I say that because in v4 I'd say a good 80% of this code will change if not more, so don't be too sad because it wouldn't have stayed around like it is for very long anyways.

@relicmelex Nevermind just keep going ;). It is at it is, I'm not sure if there is a proper way to circumvent this so its probably the only way of doing so.


Project in Angular 5 not working in IE11

Versions
Angular CLI: 1.6.3
Node: 6.11.3
OS: win32 x64
Angular: 5.2.0
... common, compiler, compiler-cli, core, forms, http
... language-service, platform-browser, platform-browser-dynamic
... router
@angular/animations: 4.4.6
@angular/cdk: 5.0.4
@angular/cli: 1.6.3
@angular/material: 5.0.4
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.3
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.4.2
webpack-dev-server: 2.9.7
webpack: 3.10.0
Repro steps
Build application
Run app in IE11
Observed behavior
when try to execute this code:
// Execute the module function
 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);

with moduleId ="../../../core/esm5/core.js"
an error is throw: "Unable to get property 'call' of undefined or null reference"
Desired behavior
the application run in IE11
Mention any other details that might be useful (optional)
I already uncomment the polyfill.ts

See #4128

Duplicate of #4128
Closing in favor of the other issue.

hi
thanks you for the suggestion.
I already try this solution. this is my polyfils
`/**

This file includes polyfills needed by Angular and is loaded before the app.
You can add your own extra polyfills to this file.

This file is divided into 2 sections:

Browser polyfills. These are applied before loading ZoneJS and are sorted by browsers.

Application imports. Files imported after ZoneJS that should be loaded before your main

 file.

The current setup is for so-called "evergreen" browsers; the last versions of browsers that
automatically update themselves. This includes Safari >= 10, Chrome >= 55 (including Opera),
Edge >= 13 on the desktop, and iOS 10 and Chrome on mobile.

Learn more in https://angular.io/docs/ts/latest/guide/browser-support.html
*/

/***************************************************************************************************

BROWSER POLYFILLS
*/

/** IE9, IE10 and IE11 requires all of the following polyfills. **/
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';
/** IE10 and IE11 requires the following for NgClass support on SVG elements */
// import 'classlist.js';  // Run npm install --save classlist.js.
/** Evergreen browsers require these. **/
import 'core-js/es6/reflect';
import 'core-js/es7/reflect';
import 'core-js/es7/array';
/**

Required to support Web Animations @angular/animation.
Needed for: All but Chrome, Firefox and Opera. http://caniuse.com/#feat=web-animation
//**/
//import 'web-animations-js';  // Run npm install --save web-animations-js.

/***************************************************************************************************

Zone JS is required by Angular itself.
*/
import 'zone.js/dist/zone';  // Included with Angular CLI.

/***************************************************************************************************

APPLICATION IMPORTS
*/

/**

Date, currency, decimal and percent pipes.
Needed for: All but Chrome, Firefox, Edge, IE11 and Safari 10
/
//import 'intl';  // Run npm install --save intl.
/*
Need to import at least one locale-data with intl.
*/
//import 'intl/locale-data/jsonp/en';
`

My angular 5 project also has the same error even I have uncommented the polyfill for IE, still cannot work in IE browser.

I have a similar issue.  I have no errors, yet IE just will not load.

Same here, following the steps of uncommenting the polyfills. Any suggestion will be much appreciated. Thank you very much!

I actually had a similar issue.  I uncommented the following in polyfills.ts:
import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';
import 'core-js/es7/reflect';
And, instead of ng build --prod, I just ran ng build.
Not perfect, sitll fighting bugs, but I was able to get IE to load.

I have the same issue, not sure why it's closed.

@dannyzhan Its closed because its not a bug see the post by @LeoNdec

@MeltdownZA I have reviewed the post by @LeoNdec and it does not reference any fix. You are recommending we not build with --prod?


Compile errors when loading the addon

When you load the addon from any release package (GitHub, Itch.io or Godot AssetLib), it will not work and instead error.

There are two issues causing this, both relate to including/excluding files/folders from release packages via .gitattributes

addons/godot-playfab/icon.png is excluded, but should not
addons/godot-playfab/tests/ is included, but should be excluded


use ISTIO_CP_AUTH variable in cluster.env to enable/disable mTLS for cp in mesh ex

ref: https://github.com/istio/istio/issues/5833
Currently setupMeshEx.sh create a variable CONTROL_PLANE_AUTH_POLICY in cluster.env to enable/disable control plane mTLS for VM.
...
echo "CONTROL_PLANE_AUTH_POLICY=$CP_AUTH_POLICY" >> cluster.env
...

It should be
...
echo "ISTIO_CP_AUTH=$CP_AUTH_POLICY" >> cluster.env
...

since istio-start.sh https://github.com/istio/istio/blob/26262e8a1d89c4cd17f52db645d91ce9d9918e6e/tools/deb/istio-start.sh#L48 looks for ISTIO_CP_AUTH

You probably want to switch target branch to master

created a new PR for master - https://github.com/istio/istio/pull/5950

/ok-to-test


Implements onnx2string and string2onnx

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (45df692) 78.39% compared to head (4c81c38) 78.44%.

:exclamation: Current head 4c81c38 differs from pull request most recent head 802614a. Consider uploading reports for the commit 802614a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   78.39%   78.44%   +0.05%
==========================================
  Files          35       35
  Lines        3550     3559       +9
==========================================
+ Hits         2783     2792       +9
  Misses        767      767

Files
Coverage Δ

onnx_extended/tools/onnx_io.py
88.37% <100.00%> (+3.07%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


does the settingsPlugin support for EMM providers ?

As per my knowledge most EMM providers support the appconfig standard and in order for the xamarin apps to receive configuration from a EMM provider we need to communicate with the platforms separately.
ios
NSUserDefaults.StandardUserDefaults.DictionaryForKey("com.apple.configuration.managed")
android
register a receiver for the "ActionApplicationRestrictionsChanged" broadcast actions and then read and apply restrictions using RestrictionsManager.ApplicationRestrictions
Is this functionality supported by the settingsPlugin ? If not what is the best way for me to use the settingsplugin and achieve the above functionality ?

We don't support Dictionary on iOS, however do support group names.
For Android there is no support for the RestrcitionManager at all.
This is super easy code to write and manage so I would just do that yourself.


ML 2.10 : Support Vector Machines (V)

Description
📌  Issues for Week 2
Welcome to 'ML' Team, good to see you here
:arrow_forward: This issue will helps readers in acquiring all the knowledge that one needs to know about ----
Support Vector Machines.
:red_circle: To get assigned to this issue, add your Batch Numbers mentioned in the spreadsheet of "Machine Learning", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
✔ Domain : Machine Learning
:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.

"Issue Title" and "PR Title should be the same. Include issue number along with it.

Changes should be made inside the Machine Learning/Machine_Learning/Supervised_Machine_Learning Branch.

Follow Contributing Guidelines & Code of Conduct before start Contributing.

This issue is only for 'GWOC' contributors of 'Machine Learning' domain.

:white_check_mark: To be Mentioned while taking the issue :

Full name
Batch Number
GitHub Profile Link
Which type of Contribution you want to make :

[ ] Video

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎
Domain
Machine Learning
Type of Contribution
Video
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Hello, I am Deepthi M with serial number:198, Batch-2. I would like to do video on this issue.

@deepthi1107 you seem to have more than three issues open currently

Full Name: Mageshkrishna R
Batch No.: ML Batch 4
Github Profile: https://github.com/silicolicious
Discord Username: Mag#2191
Type of Contribution: Video
This would be my first issue in Machine Learning.
Assign it to me.
Thank you.

@silicolicious The issue has been assigned to you. Please work on it and make a PR within 3 days. Happy contributing! 😄

Hello, I am Deepthi M with serial number:198, Batch-2. I would like to do video on this issue.

I would like to contribute for this issue. I request you to assign me the same.
Thanks
Name: Samridhi Kapoor
Batch No.: 3
Github Profile link: https://github.com/samridhikapoor
Type of contribution I want to make: Video (as specified)

I would like to contribute for this issue. I request you to assign me the same.
Thanks
Name : Ankur Das
Batch No. : 2
Github: https://github.com/das-ankur
Type of contribution : Document/Video

@deepthi1107 you can now work on this.


[feature request] File name completion

IPython has file name completion, which is useful with %magic commands, and when you're putting filenames into strings.  Is that a possibility for a future version?
PS - this is a great piece of software.  Using IPython on its own feels primitive without it!  Keep up the incredible work!  And thank you!

This was already implemented a while ago, I'm closing the ticket.


Can't serialize poco class

I'm sening a POCO with a SignalR hub then, it gets sent to my subscribed client, but the data is lost.
The data I'm sending
public class WorkerOrderViewDto
    {
        public int Id { get; set; }
        public string UserName { get; set; } = string.Empty;
        public ICollection<SandwichDto> Sandwiches { get; set; } = new List<SandwichDto>();
        public OrderState State { get; set; }
    }
public enum OrderState
    {
        OrderPlaced,
        InTheOven,
        ToBeDelivered,
        Delivered,
    }

The Hub
public class WorkerViewOrderHub : Hub<IWorkerViewOrderClient>
    {
    }

    public interface IWorkerViewOrderClient
    {
        Task ReceiveOrderAddedAsync(WorkerOrderViewDto orders);
    }

Sending the data
private readonly IHubContext<WorkerViewOrderHub, IWorkerViewOrderClient> _workerViewHub;
public async Task<ActionResult> AddOrderAsync([FromBody] AddOrderDto addOrderDto)
        {
            var userId = _userManager.GetUserId(HttpContext.User) ?? throw new InvalidCommandException();
            addOrderDto.UserId = userId;
            addOrderDto.CustomerId = userId;

            var result = await _serverOrderService.AddOrderAsync(addOrderDto);

            var orderView = (await _serverOrderService.GetPendingOrdersForWorkerAsync()).SingleOrDefault(o => o.Id == result);

            await _workerViewHub.Clients.All.ReceiveOrderAddedAsync(orderView);

            return new OkResult();
        }

SignalR Client
_connection.On<WorkerOrderViewDto>(HubNames.WorkerViewOrderHubNames.ReceiveOrderAddedAsync, OnOrdersModifiedAsync);

            Task OnOrdersModifiedAsync(WorkerOrderViewDto order)
            {
                Orders.Add(order);

                OrdersChanged?.Invoke();

                return Task.CompletedTask;
            }

Chrom debug inspection of the serialized data:
https://imgur.com/gallery/m37ptwF
The client connects, gets the message, OnOrdersMidifiedAsync gets called, but the data is not serialized properly. Any idea what I'm doing wrong?

Temporary workaround: serialize POCO to json before sending, send it as string, the deserialize manually on the client.
Btw Forgot to mention I'm using 1.0.0

Hello,
Idk if ICollection<SandwichDto> is Serializable. I would change it to an array or List<T> and try out.
The most probable cause of your serialization issues is the name casing. The new System.Text.Json is camel case so you probably need to add [JsonPropertyName("...")] on your properties so it can be serialized properly.
It is not a SignalR issue actually so I'm going to close the issue. Let me know if you find any problems with it.
Thanks!

The System.Collections namespaces all can be serialized by System.Text.Json. I solved the problem with putting the JsonPropertyName attribute to all my properties and naming them in camel casing.
Would you consider letting json serializer settings be passed to the client? Something like .WithUrl(..).WithSerializerSettings(jsonSerializerSettings)

If that is an API that is available on the original SignalR client and/or the JavaScript one yeah, we can have that.
The intent of this project is to wrap the JavaScript client and provide as much as possible the .Net API compatibility.

@KuraiAndras I didn't really like the idea of adding the JsonPropertyName attribute to each model used in communication with SignalR ;) so I tried to solve the problem on the server side where "camelCase" serialization occurs:
services
    .AddSignalR()
    .AddJsonProtocol(options => {
        // Configure the serializer to not change the casing of property names, instead of the default "camelCase" names.
        // Default camelCase is not supported by used Blazor.Extensions.SignalR, because it does NOT allow to specify JSON deserialization options - it just uses eg. JsonSerializer.Deserialize<TResult1>(payloads[0]) and there is no option to pass JsonSerializerOptions to System.Text.Json.JsonSerializer.Deserialize():
        // https://github.com/BlazorExtensions/SignalR/blob/v1.0.0/src/Blazor.Extensions.SignalR/HubConnection.cs#L108 + https://github.com/BlazorExtensions/SignalR/issues/64
        // Idea taken from: https://docs.microsoft.com/en-us/aspnet/core/signalr/configuration?view=aspnetcore-3.1&tabs=dotnet#jsonmessagepack-serialization-options
        options.PayloadSerializerOptions.PropertyNamingPolicy = null;
    });

Models in messages incomming to client side are then deserialized without problems (WARN: for outgoing models camelCase is still applied but this is not problem - model are properly deserialized on server side).

I have discovered that JsonPropertyName attribute is still required when using MessagePack otherwise we will encounter following exception on client side:
blazor.webassembly.js:1 Uncaught (in promise) Error: System.Text.Json.JsonException: The JSON value could not be converted to System.Decimal. Path: $.DecimalData | LineNumber: 0 | BytePositionInLine: 47. ---> System.InvalidOperationException: Cannot get the value of a token type 'String' as a number.
  at System.Text.Json.Utf8JsonReader.TryGetDecimal (System.Decimal& value) <0x24d8310 + 0x00018> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.Utf8JsonReader.GetDecimal () <0x24d8240 + 0x00008> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.Serialization.Converters.JsonConverterDecimal.Read (System.Text.Json.Utf8JsonReader& reader, System.Type typeToConvert, System.Text.Json.JsonSerializerOptions options) <0x24d8188 + 0x00004> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.JsonPropertyInfoNotNullable`4[TClass,TDeclaredProperty,TRuntimeProperty,TConverter].OnRead (System.Text.Json.ReadStack& state, System.Text.Json.Utf8JsonReader& reader) <0x24d7f98 + 0x00030> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.JsonPropertyInfo.Read (System.Text.Json.JsonTokenType tokenType, System.Text.Json.ReadStack& state, System.Text.Json.Utf8JsonReader& reader) <0x2097e68 + 0x00078> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.JsonSerializer.HandleValue (System.Text.Json.JsonTokenType tokenType, System.Text.Json.JsonSerializerOptions options, System.Text.Json.Utf8JsonReader& reader, System.Text.Json.ReadStack& state) <0x2097a60 + 0x0009a> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
  at System.Text.Json.JsonSerializer.ReadCore (System.Text.Json.JsonSerializerOptions options, System.Text.Json.Utf8JsonReader& reader, System.Text.Json.ReadStack& readStack) <0x20947c8 + 0x00092> in <90ed82de44024ca1bc6b68be1a1a7e32>:0
   --- End of inner exception stack trace ---
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x1c47900 + 0x000c8> in <bceea5edb42b4ad28e0d8ad9d8e3fe0f>:0
--- End of stack trace from previous location where exception was thrown ---

  at Microsoft.JSInterop.Infrastructure.DotNetDispatcher.InvokeSynchronously (Microsoft.JSInterop.JSRuntime jsRuntime, Microsoft.JSInterop.Infrastructure.DotNetInvocationInfo& callInfo, Microsoft.JSInterop.Infrastructure.IDotNetObjectReference objectReference, System.String argsJson) <0x21badc0 + 0x00164> in <3eedf0ca90ca4e72bf6870618ca98c7c>:0
  at Microsoft.JSInterop.Infrastructure.DotNetDispatcher.BeginInvokeDotNet (Microsoft.JSInterop.JSRuntime jsRuntime, Microsoft.JSInterop.Infrastructure.DotNetInvocationInfo invocationInfo, System.String argsJson) <0x22023f8 + 0x00090> in <3eedf0ca90ca4e72bf6870618ca98c7c>:0
    at Object.endInvokeDotNetFromJS (http://localhost:13425/_framework/blazor.webassembly.js:1:9849)
    at Object.invokeJSFromDotNet (http://localhost:13425/_framework/blazor.webassembly.js:1:9475)
    at _mono_wasm_invoke_js_marshalled (http://localhost:13425/_framework/wasm/mono.js:1:179080)
    at wasm-function[6361]:0x11d724
    at wasm-function[1463]:0x3f118
    at wasm-function[616]:0x1373b
    at wasm-function[616]:0x1eb39
    at wasm-function[616]:0x1eb17
    at wasm-function[616]:0x1eb17
    at wasm-function[616]:0x1eb17


nz-steps 'vertical' and 'nzProgressDot'

html
<nz-steps [(nzCurrent)]="current" nzProgressDot [nzDirection]="'vertical'">
  <nz-step [nzTitle]="'Finished'" [nzDescription]="'This is a description.'"></nz-step>
  <nz-step [nzTitle]="'In Progress'" [nzDescription]="'This is a description.'"></nz-step>
  <nz-step [nzTitle]="'Waiting'" [nzDescription]="'This is a description.'"></nz-step>
</nz-steps>

ts
import {Component, OnInit} from '@angular/core'
import {FormBuilder, FormGroup} from '@angular/forms'

@Component({
  selector: 'app-test',
  templateUrl: './test.component.html',
  styleUrls: ['./test.component.scss'],
})
export class TestComponent implements OnInit {
  current = 1

  constructor(private fb: FormBuilder) {
  }

  ngOnInit() {

  }
}

description
i need a solid vertical nz-step
i use nzProgressDot [nzDirection]="'vertical'"
and i get this

not supported yet.

@vthinkxie Whether this feature conforms the ant design design scope?

@HsuanXyz
We are all working day and night for double 11 these days, this feat need to be confirmed later.

@vthinkxie 辛苦了


api: retry conflicts as a workaround

This is a workaround for comment creation / updates conflicting with the loom service that indexes threads objects concurrently. We will be fixing this properly in the backend, but as a workaround we will retry conflicts for now.

@annesylvie I was too fast, it didn't compile :sweat: -- fixed now!


feature:  国际化词汇规范矫正 (closed #1606)

Codecov Report

Merging #1607 (6469a52) into v2.3.2-dev (a64bb17) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           v2.3.2-dev    #1607      +/-   ##
==============================================
- Coverage       73.42%   73.41%   -0.02%
==============================================
  Files             389      389
  Lines           26244    26244
==============================================
- Hits            19270    19267       -3
- Misses           6974     6977       +3

see 3 files with indirect coverage changes


Changes to fix Travis builds

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


double check whether a release contains API breaking changes

preventative measures taken after OSIDB-854 incident

This can be included (in the post-mortem as well): https://github.com/RedHatProductSecurity/osidb/pull/207

@Elkasitu I merged the postmortem before reading your note... I think it does not matter. The important is that the safeguard is actually in place


Fix sorting

The order of news articles is wrong. There are currently two fields, date and index, that sort the articles. According to how those fields are filled, we would expect the following order:

welcome-to-our-site
and-then-there-were-many
the-journey
the-web-side-of-things
mascot-contest
release-4-4

Front page:

News overview:

This can be done by adding number to the markdown files.
I think he just didn't know.

The problem is that several articles have the same date, which is why index was introduced. I've added that to the sort predicate, played around with it until the order was right (but didn't know what I was doing really). Now the order is scrambled again

Okay. Now I understand what's going on. The markdown content can be numbered.
And the number will be automatically removed for generating.
I made same system for my web framework and I know nuxt content do same.
Let's see if numbering markdown files fix the problem.

#79


Prevent a page definition from being saved if an element name contains spaces or special characters

If an element name contains spaces or special characters then flag it visually:

and prevent the page from being saved until the error is resolved.
The Codegen error you get when this happens is:

Only when you try to build the project in Visual Studio is the cause of the issue apparent:

hi @quockhanh  please help me review this PR https://github.com/rockmelonqa/ide/pull/120

Will be imlemented with #118


Calendar

Is there a way to change the color of each day dynamically? I.E. Oct 1st Red, Oct 2nd Blue...

Hey @jcaruso001 you can use the decorator api. You will need to create one decorator per color and then supply the logic for shouldDecorate()


Error due to invalid import statement

There are 4 places where an import statement tries to import a directory in the latest version (7.9.3). This is not valid and causes errors https://stackoverflow.com/questions/64453859/directory-import-is-not-supported-resolving-es-modules-with-node-js.
This was posted before in issue #58 but was immediately closed without any investigation whatsoever.
The suggested fix from stackoverflow is to append /index.js, which does indeed work. I have created pull request #60 with the fix.

Unfortunately, I am unable to run npm install after checking out the composite-key branch :(
Any idea what 'ts' is that it tries to run?
><EMAIL_ADDRESS>copy-files
> cpy 'generators/**' '!**/*.(js|ts|cjs|mjs|snap)' '!**/__*/*' dist/generators && cpy 'package.json' dist

'ts' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code 255
npm ERR! path C:\src\generator-jhipster-yelhouti
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c npm run build

The log has
1150 verbose stack Error: command failed
1150 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\@npmcli\promise-spawn\index.js:64:27)
1150 verbose stack     at ChildProcess.emit (node:events:526:28)
1150 verbose stack     at maybeClose (node:internal/child_process:1092:16)
1150 verbose stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
1151 verbose pkgid<EMAIL_ADDRESS>1152 verbose cwd C:\src\generator-jhipster-yelhouti
1153 verbose Windows_NT 10.0.19044
1154 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
1155 verbose node v16.14.2
1156 verbose npm  v8.5.0
1157 error code 255
1158 error path C:\src\generator-jhipster-yelhouti
1159 error command failed
1160 error command C:\WINDOWS\system32\cmd.exe /d /s /c npm run build```

I have created an  issue for the npm install problem in jhipster's project

@naris new release 7.9.4 with some small fixes


add .pause() function to onEvery()

stop() already exists, but and pause and resume function would be awesome

Is there an example for how to use stop() with onEvery()? (I don't use CoffeeScript, so it's hard to understand your annotated source. Thanks!)

@frozeman pause and resume methods are in master. Sorry for all this delay.
@jabbett onEvery returns an object containing these methods, here is an example
var interval = ifvisible.onEvery(2, function() {
    // operation
});

// to stop this interval
interval.stop();

// to pause
interval.pause();

// to unpause
interval.resume();

// Resume cannot start a stopped interval.

Hope this helps

One year delay, but great thanks!! :)


Points layer markers "expand" when switching from 2D to 3D view

🐛 Bug
Points added in 2D slice view appear much larger and artefacted when switching to 3d view

To Reproduce
Steps to reproduce the behavior:

open a volume
add a points layer
using 2D view with z slider add a few points and/or crosses at the default size
switch to 3D view

Expected behavior
points retain relative size to voxel size when switching to 3D.
Note that for "Shapes" layers this is handled correctly (rectangles, triangles etc. maintain correct size in 3D view).
Environment
napari, 0.2.5
Qt, 5.13.2
NumPy, 1.17.3
SciPy, 1.3.1
VisPy, 0.6.2
scikit-image, 0.16.2
Platform: Windows-10-10.0.18362-SP0
Python:   3.7.5 (default, Oct 31 2019, 15:18:51) [MSC v.1916 64 bit (AMD64)]
Backend:  PySide2
GL version:  '4.5.0 - Build <IP_ADDRESS>72'
MAX_TEXTURE_SIZE: 16384

I can't reproduce on my machine, in the sense that it actually looks relatively good on yours compared to mine 😂

I can reproduce with this script:
import numpy as np
import napari
from skimage import data

blobs = data.binary_blobs(length=128, n_dim=3)

with napari.gui_qt():
    viewer = napari.view_image(blobs)
    points = viewer.add_points(np.array([[64, 64, 64], [0, 0, 127]]))
    viewer.dims.ndisplay=3

Just adding an observation. In my case the disks keep the same size on the screen when zooming in and out, but their centres change the position on the screen in what appears to be correct. Haven't looked into the code whether the size needs to be explicitly linked to the zoom or how these objects are handled.

@jni @VolkerH - this is likely due to the release of vispy 0.6.2 where the archballcamera default changed to fov=45 instead of fov=0. merging #683 should recover the previous behavior.
if we want to support proper scaling with the new fov then we need to look into some things on the vispy end - see #683 and some linked vispy discussions for more detail, but that will take longer
apologies for not getting this in sooner!

not sure what's happening on @jni machine, if it is the same bug / unrelated / if he changed his vispy along the way

This should now be fixed on master with the merge of #683 - can you confirm @VolkerH and then I will close this issue. Thanks for flagging!

I can confirm that the points now have a reasonable size in the 3D view.  Thanks, i will close the issue.
I noticed some other issue though (probably unrelated so I will open a new one).


Update cloud-provider-aws README

Issue #, if available:
Description of changes:
Modify 1-26 version to v1.26.1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approved


Setup release workflows

[x] Read GitHub Actions docs.
[x] Check what semver tells us about prerelease and PR versions.
[ ] Check the PyPi policy about prereleases and PR versions.
[ ] Generate a PyPi token and set it in GitHub
[ ] Push a PR package when a PR is created (why? I code alone 🤔)
[ ] Push a pre-release package when there's a new commit in the main branch (what if I don't change code?)
[ ] Push a release package when a release is created.

https://peps.python.org/pep-0440/#pre-releases

https://github.com/python-poetry/poetry/issues/1208#issuecomment-1014747211

I'm closing this issue because there is no strong need for it. Hopefully, one day, it will be configured.


3D asset from files

Hi. thank you for this awesome package.
are there any ways to present 3D objects from file system?

Hi, its good to hear that this package could help you,
about the feature you mentioned, right now I only support loading 3D models from assets and url,
but it may be possible to load models from file system, for example create file and passing file path as the model src,
I have not test it it yet, if you have fixed it please share and feel free to create PR to package.


Add slugs

@apu52
Title and Issue number

Title :
BUG: Url have space https://github.com/apu52/Travel_Website/issues/450
Issue No. :
#450
Code Stack :
Added slugs in url
update folders name as slug
Close #450

Video/Screenshots (mandatory)

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

GSSOC'24

@apu52 Now you can merge it there is no conflicts


Pagination obs performance

Fixes #2556

Hit an issue where organization entities in the organization tab, in Cloud foundry section appear to be empty

LGTM


RFC 1009: Write the initial RFC for GROUP BY

I use ORDER BY because I wanted the query output in a particular order for the example, and the ORDER BY makes sure that the model actually produces the output I want. I can drop the ORDER BY, but I don't actually think that would clarify anything.

Would be nice to see a section dedicated to analysis of the SQL GROUP BY along with some conclusions why on how our GROUP BY is different/more powerful/weaker and how our solution is more composable.

Would be nice to see a section dedicated to analysis of the SQL GROUP BY along with some conclusions why on how our GROUP BY is different/more powerful/weaker and how our solution is more composable.

I wrote something up, with some implementation notes

I have swapped the USING and BY clauses, again, and restored essentially my initial proposal for specifying grouping sets, but now in the BY clause instead of USING.

Should I merge it, and then we can restart any future arguing based on that?

Should I merge it

Go ahead.


Add click to copy on Libra short address on home page

@totiz I've merged copy wallet address on commit 4c54f99.

Could you please adjust like this?, I think just add copy icon is enough, and click on the line to copy (Wallet: 0xaabb...eeff [copy icon]).
What do you think?

@totiz I agree, it looks cleaner in UI.

@totiz Merged with commit a64c3d9.

I believe this is a start....however there are still a number of questions your design is asking for....Like exchange with other cryptos and major or local currency were it is adapted....otherwise we shall just have few options of the to currencies and this is not relevant to a local farmer or trader in My country....
Especially the need for other verification log-in and security on ones mobile app version....
And B.V.N and other regulatory and inter-bank transfer conversion for students and the ordinary man.


Added basic HTTP proxy support

Get the proxy address from the HTTPS_PROXY environment and tunnel connection
through that proxy.

Thanks for the patch, and for updating it so quickly!


Feat/meta rehydration (MANUAL TESTING)

Description
This PR implements the rehydration of meta values when switching between pages of a List widget. In addition, changes to default values cause meta widget values to reset to default.
NB: THIS PR IS FOR MANUAL TESTING ONLY, LIST V2 ISN'T IN RELEASE YET.
Fixes #16926 (Adding this for zenhub to link this PR)
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

Note for QA:
This PR includes couple of changes

It retains the interactions with the widgets in each items over page changes. For example if we have an input widget , then if we enter some value in the 2nd or 3rd item and move to the next page and edit some input there. When we come back the to the previous page, the values entered should be present instead of resetting to default.

If we do changes mentioned in point 1 and then we modify the default value then all the similar widgets (in our case the input widget) across all the pages should have the default value.

Observations:

The values in the currency widget is not retaining fully (getting cropped) when we change the page . Not sure if it is a widget problem or related to meta
LOOM
@ohansFavour @ashit-rath

@kamakshibhat-appsmith Is this only with Currency or other input widgets like Phone number behaves the same?

@ashit-rath Only currency widget

Changed the status of all related PRs to InProgress for now. Pls triage and update it to relevant status accordingly

The observation raised by @kamakshibhat-appsmith regarding the currency widget is a "widget" issue rather than a meta-property issue. This behaviour is also replicated in the List widget v2 PR (which doesn't yet have the meta changes).
cc: @ashit-rath

@ohansFavour I verified this issue both in this DP and the List v2 and the problem doesn't seem to be there in the List v2 DP.
I have been testing this in both the DPs and I am unable to re-create this in the List v2 one.
Also it seems that the first dataTree after changing page also has the trimmed down value.
Can you double check this?
Hydration DP - https://appsmith-git-feat-meta-rehydration-get-appsmith.vercel.app/app/untitled-application-102/page4-63c007665ce71c57ed4b1ad1/edit#2bijpzaqyc
List v2 DP - https://appsmith-git-feat-list-widget-v2-get-appsmith.vercel.app/app/untitled-application-102/page4-63c007665ce71c57ed4b1ad1/edit#2bijpzaqyc
Let me know if I'm doing something wrong here.
cc: @kamakshibhat-appsmith

Hey @ashit-rath , here is a loom record of me reproducing this in the listV2 DP

@ohansFavour Can you share the app?

@ohansFavour Can you share the app?

I have shared the App with<EMAIL_ADDRESS>Kindly let me know if this is your mail

@ohansFavour Can you share the url of the app?

https://appsmith-git-feat-list-widget-v2-get-appsmith.vercel.app/app/untitled-application-12/page1-63a0258b3acfb26450eccde1/edit#0a20lu51cx

@ohansFavour Thanks!
@kamakshibhat-appsmith This is indeed a Currency widget issue and not a hydration bug. Please proceed with the verification excluding the Currency widget; we'll fix it separately.

Rest of the things look good . @ohansFavour @ashit-rath


ci: cache playwright browser

Closes #120

It is possible to cache the playwright browser it self, however the browser requires system dependencies, that can not be cached easily. Refer to this run here: https://github.com/shawnyu5/starchart/actions/runs/4093992063
The alternative is to install the browser it self through npx, and system dependencies through the package manager. Which still takes too long. Refer to this run here: https://github.com/shawnyu5/starchart/actions/runs/4093992063
Going to experiment with using a docker container with playwright installed to run the tests

Hmm, using this docker container, that contains playwright to run our CI means we would need to install docker inside the container every time. Which also involves installing stuff, and is no better than installing playwright it self...

Since the CI run can take a little bit of time, a concurrency group is added to cancel previous workflow runs if a new workflow is triggered.
For example, if 2 commits were pushed in close succession. Rather than kicking off 2 separate workflow runs, the first workflow run would be cancelled in favor of the second run. Refer to these 2 workflow runs:
First commit triggering a workflow run, cancelled by the next commit: https://github.com/Seneca-CDOT/star chart/actions/runs/4094766475
Second commit, pushed right after the previous commit. Triggering another workflow run, cancelling the first: https://github.com/Seneca-CDOT/star chart/actions/runs/4094767877

The CI run will attempt to restore playwright browser from cache. If it is successful, it will install system dependencies. If its unsuccessful, it will install playwright browser it self along with its dependencies

The dependencies are system dependencies from what I understand, it's not a single binary, like the browser, or a single directory like node_modules. So I dont think its fully possible to cache those.

If you look at the logs here, the dependencies are being installed through the package manager... I don't know if it's possible to cache those...

Cleaned up some commit history