Use mano param from hamer to SMPLX hand pose

Great work! I'd like to know how to convert the MANO parameters obtained from Hamer into the hand pose of SMPL-X. Directly replacing them results in odd effects.

Can you give examples of what you observe? The pose parameters we regress for HaMeR should be directly compatible with the hand pose parameters that SMPL-X expects as input.
Is the problem happening with both hands or only with the left hand? If it's the second, you might need to mirror the parameters (left-right flipping).

https://github.com/geopavlakos/hamer/assets/63392592/7a2b2643-994d-462b-9a20-c465f88fe22f
Thank you for your reply! It indeed seems to be with problem in the left hand.  so  how should I flip the mano parameters for the left hand?

Actually, the right hand doesn't look correct either. Could you try again by setting the flag flat_hand_mean=True?
Regarding flipping, you can convert the rotation matrices to axis angle and then for each joint rotation, you will need to multiply the second and the third element by -1 (see also how we do it in our code here).

same error, I multiply the second and the third element by -1 with  ['pred_mano_params']['hand_pose'] and copied into SMPLH, but the left hand still with problem.  " convert the rotation matrices to axis angle" is indeed? how can i  flip the mano parameters without the rotation matrices to axis angle?


make the post loading more close to what we are used to from other apps

new posts render when user reaches end of the timeline, every list now uses skeleton loading element that is shown before the actual content loads


Namespace override ignored when resolving temporary (including OCI fetched charts)

Operating system
MacOS
Helmfile Version
v0.145.2
Helm Version
v3.9.0
Bug description
Steps to reproduce

Define an OCI repository in your helmfile
Define a release that includes a valid reference to an OCI managed chart; but do not specify a namespace in the release defintion
Run helmfile sync --namespace my-namespace or helmfile template --namespace my-namespace

Expected behaviour

OCI chart is resolved and sync'd/templated

Actual

Error thrown by helm Error: failed to download "my-oci-repo/my-chart" at version "1.0.2"

Some analysis
This error does not occur if

you do not specify --namespace my-namespace arg to helmfile, or
you specify releases[x].namespace in your helmfile

In the working state, we see the call to helm includes a reference to the temporary folder containing the OCI downloaded chart.  In the broken state we see the chart reference as is (i.e. my-oci-repo/my-chart)
Looking at the code, it seems that namespace and kube context overrides are not being considered when looking up the local/temporarily downloaded.
Workaround
Specify a namespace: {{ .Namespace }} attribute in the release definitions in helmfile.yaml
I will attach a sample PR that highlights the problematic lookup.
Example helmfile.yaml
# helmfile.yaml
repositories:
  - name: my-oci-repo
    url: my-ocirepo.com/charts
    oci: true

releases:
  - name: my-release
    chart: my-oci-repo/my-chart
    version: 1.0.2
    # Note "namespace" not included here.  If we were to add "namespace: {{ .Namespace }}" this works fine.

Run with helmfile --namespace my-namespace template
Error message you've seen (if any)
OCI downloader successfully doing it's thing...
Pulling my-oci-repo/charts/my-chart:1.0.2
Exporting my-oci-repo/charts/my-chart:1.0.2
Pulled: my-oci-repo/charts/my-chart:1.0.2
Digest: sha256:d6cfc9e3f18eb18191132c68515dcc490945a6f19b0b83d12c13a377103e043b

Exporting my-oci-repo/charts/my-chart:1.0.2
Pulled: my-oci-repo/charts/my-chart:1.0.2

-- SNIP ---
Helm barfing...
ARGS:
  0: helm (4 bytes)
  1: template (8 bytes)
  2: my-release (14 bytes)
  3: my-oci-repo/my-chart (26 bytes)
  4: --version (9 bytes)
  5: 1.0.2 (13 bytes)
  6: --namespace (11 bytes)
  7: my-namespace (20 bytes)
  8: --values (8 bytes)
  9: /var/folders/wd/nf72qyt51c99_kyl2lb7vcsc0000gp/T/helmfile338136752/my-namespace-my-release-values-7468884646 (120 bytes)

ERROR:
  exit status 1

EXIT STATUS
  1

STDERR:
  Error: failed to download "my-oci-repo/my-chart" at version "1.0.2"

Steps to reproduce
See above
Working Helmfile Version
N/A
Relevant discussion
No response

@jgchristian Thanks very much. I will check this.

@xiaomudk do you have free time to see this issue? Thanks very much.

@yxxhero ok, let me follow up

@jgchristian Thanks very much. Thanks for works for this issue.

@jgchristian This error doesn't look like a namespace issue.
Can you use --debug and let me see the output, for example:
helmfile --namespace my-namespace2 sync --debug

find this one
processing releases in group 1/1: my-namespace/nginx
Upgrading release=nginx, chart=nginx-stable/nginx-ingress
exec: helm upgrade --install --reset-values nginx nginx-stable/nginx-ingress --version 0.14.0 --create-namespace --namespace my-namespace  --history-max 10

It has something to do with helm oci, let me see it again

@jgchristian  I use oci test and it can be used normally, but in oci mode, there may be problems with the parsing of helm url and version.  See here for details #244. If you don't have a similar problem, please use --debug to let me see the detailed execution process. Thanks!

Hi
I just spent a couple of hours trying to create a simple test harness with the latest versions of helm, helmfile and harbor... plus a much simpler helmfile.yaml and failed to reproduce the issue... so I'm wondering if there is an exotic issue triggered by our specific pipeline and production helmfile configuration.
I'll close this issue for now and monitor in our pipelines.
Thanks for taking a look... apologies if any time was wasted!


[Feature Suggestion] A 'Log' column for gatherables

Would be great to have a 'Log' column for gatherables similar to for fishes. I understand it's a one and done thing, but would be so convenient to have for those trying to knock out their gathering log quickly and find out which timed nodes needs to be targeted.

I second this! GB has been super useful for fishing completion, and would definitely help many get their resplendent tools.

Just go along your gathering log and use the context menu gather.

I was more referring to the timer functionality for timed nodes as in the fishing tab, but yes it would just be convenience. /gather works too.

The problem is mainly that I'd have to first figure out how to get log information about gatherables (wouldn't be hard, but I don't do it yet) and more importantly to keep it up to date (which might very well be a pain). This really doesn't seem worth it for gatherables.


Getting paid infinitely for using a grindstone on items with Curse of Vanishing

*Detailed description of the issue:
I recently found someone exploiting the fact that you get paid infinitely for putting a sword (or anything I assume) into a grindstone that only has curse of vanishing on it.  The curse doesn't go away, and so you can spam it for as long as you wish and get an infinite amount of money doing this.
I solved this by removing getting paid for repairing items, but seems to be a problem that should have an easyish fix.
ERROR (DELETE IF YOU HAVE NO ERROR):
<-- Try to use pastebin.com server if you have long error. -->
####################
## PASTE ERROR HERE ##
####################
```No error

**CONFIG SECTION (DELETE IF NOT RELEVANT):**

#####################################
PASTE RELEVANT CONFIG SECTION HERE
#####################################

---

**Jobs version:**
<IP_ADDRESS>
**Server Type (Spigot/Paper/etc):**
Paper
**Server Version (using `/ver`):**
378
**Relevant plugins (Delete if this isn't needed):**

531b12a6fa91a603ce5b784e7d0168f07e6becf3


[GHSA-x9vc-6hfv-hg8c] Npgsql vulnerable to SQL Injection via Protocol Message Size Overflow

Updates

Affected products

Comments
https://github.com/npgsql/npgsql/releases/tag/v7.0.7 fixed in 7.0.7 too according to this.

Hi there @paul-gerste-sonarsource and @NinoFloris! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Thank you for your submission to the GitHub Advisory Database, this has been closed due to being a duplicate of #4379.


Webview to load HTML file in app

Is there a way i can use webView to load an HTML file that resides in the app.
I have tried calling via localhost and this does not work
Thanks

@cookieguru @mrmccormack Thanks, was able to load it.
The HTML audio in android refuses to play, no matter how much i try, even by passing action in JS

@acefxlabs A WebView does not have access to the bundled assets (any of the files you add to a project).

Closing this issue for now as "works as intended".

@acefxlabs A WebView does not have access to the bundled assets (any of the files you add to a project).

Is this still true? If I run this: let resource = app.getResourceLocation('resources/test.html'); in my test app, a URL is returned: http://my-ip:8080/resources/test.html, which I can load in the webview, but I wonder what is being returned when the app is actually build. I was hoping it to return a local file, then I found this issue with that quote of yours.

@frederikbosch That method works because all resources are loaded over http in develop mode.  You can use this workaround to load local resources


Add Link header for ACL file

Implementation of https://solid.github.io/specification/protocol#auxiliary-resources-wac;
should link to the direct ACL file (regardless of whether it exists).
We should probably use rel=acl (but let's make this configurable so we can do rel=http://www.w3.org/ns/solid/terms#acl later).

Note https://github.com/solid/specification/issues/172#issuecomment-766840145

Note https://github.com/solid/specification/issues/172#issuecomment-766840145


"Călmățuiu de Sus", "Băcălești" and "Ionașcu" are listed in the drop-down menu

Description:
"Călmățuiu de Sus", "Băcălești" and "Ionașcu" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Călmățuiu de Sus" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Călmățuiu de Sus, TELEORMAN (Călmățuiu de Sus)" and "Comuna Călmățuiu de Sus, TELEORMAN".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Ionașcu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Ionașcu, TELEORMAN (Călmățuiu de Sus)".


CSS/JS pipeline issues if URL contains query parameters

Fix looks something like this:
https://github.com/gantry/gantry5/commit/627c070ef6f97b9eff137be28f330e5a0250675c

Which URL is this? The URL of the asset? so:
{% do assets.addCss('theme://css-compiled/nucleus.css?for=bar') %}

???

Yeah, it removes ?foo=bar from assets that are local files. Without this the file cannot be found and is not added into the pipeline, causing it to be silently removed.
Though my fix does not deal with CSS/JS files, which are generated by a script. We may also want to ignore assets which cannot be found from the filesystem instead of just removing them in the pipeline.


Fix the table size when emitting controller metrics

Previously it emitted just one segment size.

Codecov Report

Merging #2637 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2637      +/-   ##
=========================================
- Coverage   69.42%   69.4%   -0.03%
=========================================
  Files         862     862
  Lines       39947   39947
  Branches     5374    5374
=========================================
- Hits        27734   27726       -8
- Misses      10408   10410       +2
- Partials     1805    1811       +6

Impacted Files
Coverage Δ

...not/controller/validation/StorageQuotaChecker.java
95% <100%> (ø)
:arrow_up:

...pinot/core/operator/docidsets/OrBlockDocIdSet.java
84.9% <0%> (-13.21%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
81.81% <0%> (-10.91%)
:arrow_down:

...e/impl/dictionary/LongOnHeapMutableDictionary.java
88.88% <0%> (-6.67%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
68.88% <0%> (-6.67%)
:arrow_down:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
84.48% <0%> (-3.45%)
:arrow_down:

...linkedin/pinot/common/metrics/AbstractMetrics.java
75.39% <0%> (-1.59%)
:arrow_down:

...inot/core/operator/docidsets/AndBlockDocIdSet.java
57.93% <0%> (-1.38%)
:arrow_down:

...lix/core/realtime/PinotRealtimeSegmentManager.java
72.31% <0%> (-1.13%)
:arrow_down:

...pby/NoDictionarySingleColumnGroupKeyGenerator.java
91.91% <0%> (-1.02%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f356425...0728563. Read the comment docs.


tests

The code is mostly untested. We shouldn't really strive for fancy functional tests or 100% unit test coverage, but at minimal the math parts (spectrum calculation, transition time and distance calculations) should be tested to allow for refactoring.

First batch of tests added in 1.0.


[Suggestion] Add creative crafter upgrade

When you have a lot of ordinary crafters or iron/gold/diamond/Netherite crafters (from ExtraStorage) sitting around, it can be a pain to upgrade them to creative crafters, as you have to break them, reorientate them, and put all the patterns back in, which can take a while, especially if you have the aforementioned crafters from Extra Storage, which add more pattern slots, and it also ruins the orginization of the patterns unless you take each one out manually before breaking the crafter.
I think it’d be fantastic if you could add an upgrade item, with which you can right-click on any crafter (including ExtraStorage crafters) to upgrade them to creative crafters. That’d save you the hassle of having to break them, reorientate them, and put all the patterns back into it.


Bug: Uploading list of files via an object fails validation if there's only a single file

Description
If there's some model like the one below and only one file is provided by the client, then the validation fails.
class FileModel(Struct):
    files: list[UploadFile]

This is the same issue as in #2753. That PR, unfortunately, only handled this scenario for data: list[FileUpload] defined directly on the handlers. We'll have to go through all the fields of the FieldDefinition and do that same check that was introduced in that PR. I don't think this has to be done recursively though since complex objects aren't supported.
URL to code causing the issue
No response
MCVE
from __future__ import annotations

from msgspec import Struct

from litestar import post
from litestar.datastructures import UploadFile
from litestar.enums import RequestEncodingType
from litestar.params import Body
from litestar.status_codes import HTTP_201_CREATED
from litestar.testing.helpers import create_test_client

class FileUpload(Struct):
    files: list[UploadFile]

@post(path="/")
async def upload_files_object(data: FileUpload = Body(media_type=RequestEncodingType.MULTI_PART)) -> list[str]:
    return [f.filename for f in data.files]

with create_test_client([upload_files_object], debug=True) as client:
    # Works if more than 1 file is provided.
    # files = [("files", b"1"), ("files", b"2")]

    # Fails if only 1 file is provided.
    files = [("files", b"1")]
    response = client.post("/", files=files)

Steps to reproduce
1. Run the MCVE

Screenshots
No response
Logs
Traceback (most recent call last):
  File "/home/guacs/open-source/litestar/litestar/_signature/model.py", line 189, in parse_values_from_connection_kwargs
    return convert(kwargs, cls, strict=False, dec_hook=deserializer, str_keys=True).to_dict()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
msgspec.ValidationError: Expected `array`, got `UploadFile` - at `$.data.files`

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/guacs/open-source/litestar/litestar/middleware/exceptions/middleware.py", line 191, in __call__
    await self.app(scope, receive, send)
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 82, in handle
    response = await self._get_response_for_request(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 134, in _get_response_for_request
    return await self._call_handler_function(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 154, in _call_handler_function
    response_data, cleanup_group = await self._get_response_data(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 193, in _get_response_data
    parsed_kwargs = route_handler.signature_model.parse_values_from_connection_kwargs(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/_signature/model.py", line 202, in parse_values_from_connection_kwargs
    raise cls._create_exception(messages=messages, connection=connection) from e
litestar.exceptions.http_exceptions.ValidationException: 400: Validation failed for POST http://testserver.local/
Traceback (most recent call last):
  File "/home/guacs/open-source/litestar/litestar/_signature/model.py", line 189, in parse_values_from_connection_kwargs
    return convert(kwargs, cls, strict=False, dec_hook=deserializer, str_keys=True).to_dict()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
msgspec.ValidationError: Expected `array`, got `UploadFile` - at `$.data.files`

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/guacs/open-source/litestar/litestar/middleware/exceptions/middleware.py", line 191, in __call__
    await self.app(scope, receive, send)
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 82, in handle
    response = await self._get_response_for_request(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 134, in _get_response_for_request
    return await self._call_handler_function(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 154, in _call_handler_function
    response_data, cleanup_group = await self._get_response_data(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/routes/http.py", line 193, in _get_response_data
    parsed_kwargs = route_handler.signature_model.parse_values_from_connection_kwargs(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/guacs/open-source/litestar/litestar/_signature/model.py", line 202, in parse_values_from_connection_kwargs
    raise cls._create_exception(messages=messages, connection=connection) from e
litestar.exceptions.http_exceptions.ValidationException: 400: Validation failed for POST http://testserver.local/

Litestar Version
HEAD
Platform

[X] Linux
[ ] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Actually, I don't think this is a bug. This is not what the usage is meant to be I believe. The attributes on the defined model should be the filenames which means a list of files would not be an appropriate annotation. That being said, if this is the case, then the following does not work either:

from __future__ import annotations

from msgspec import Struct

from litestar import post
from litestar.datastructures import UploadFile
from litestar.enums import RequestEncodingType
from litestar.params import Body
from litestar.status_codes import HTTP_201_CREATED
from litestar.testing.helpers import create_test_client

class Form(Struct):
    cv: UploadFile
    diploma: UploadFile

@post(path="/")
async def upload_files_object(data: Form = Body(media_type=RequestEncodingType.MULTI_PART)) -> list[str]:
    return [data.cv.filename, data.diploma.filename]

with create_test_client([upload_files_object]) as client:
    files = [("files", ("cv", b"1")), ("files", ("diploma", b"1"))]
    response = client.post("/", files=files)

    assert response.status_code == HTTP_201_CREATED
    assert response.json() == ["cv", "diploma"]

In the example above, the field name will be files whereas the filenames will be cv and diploma. @litestar-org/members, can someone confirm the following:

whether this issue is a bug or not
whether the example in this comment not working is the actual bug

Thanks for the investigation @guacs!
I don't think this is a bug. I think neither usage is intended to be supported at the moment.
The correct way to annotate the example given would be

class Files(Struct):
    cv: UploadFile
    diploma: UploadFile

class Form(Struct):
    files: Files

@post(path="/")
async def upload_files_object(data: Form = Body(media_type=RequestEncodingType.MULTI_PART)) -> list[str]:
    return [data.files.cv.filename, data.files.diploma.filename]

with create_test_client([upload_files_object]) as client:
    files = [("files", ("cv", b"1")), ("files", ("diploma", b"1"))]
    response = client.post("/", files=files)

to take into account the actual field name as well.
To support this, we'd generally have to support nested data structures for multipart uploads, which is something we could do, but we'd have to change quite a few things for this to work.
Personally, I think the current level of support is "good enough"; Being able to validate filenames like this via the signature validation would be a rather fundamental change.
Closing this for now as it's not a bug. If there's interest, we can reopen this as a feature request in the future.

@provinzkraut so to confirm, you're saying the following example should is not supported:
from __future__ import annotations

from msgspec import Struct

from litestar import post
from litestar.datastructures import UploadFile
from litestar.enums import RequestEncodingType
from litestar.params import Body
from litestar.status_codes import HTTP_201_CREATED
from litestar.testing.helpers import create_test_client

class Form(Struct):
    cv: UploadFile
    diploma: UploadFile

@post(path="/")
async def upload_files_object(data: Form = Body(media_type=RequestEncodingType.MULTI_PART)) -> list[str]:
    return [data.cv.filename, data.diploma.filename]

with create_test_client([upload_files_object]) as client:
    files = [("files", ("cv", b"1")), ("files", ("diploma", b"1"))]
    response = client.post("/", files=files)

    assert response.status_code == HTTP_201_CREATED
    assert response.json() == ["cv", "diploma"]

If so, then I think either we have to add support for it or clarify the documentation regarding it because as per the docs, the above code should work.

Reading the docs again, I think what's expected there as the request data is actually something like
with create_test_client([upload_files_object]) as client:
    files = [("cv", b"1"), ("diploma", b"1")]
    response = client.post("/", files=files)

So you don't have the nested structure, but simply a multipart body with multiple files in it. The line "multiple named files" is misleading I think.

Reading the docs again, I think what's expected there as the request data is actually something like
with create_test_client([upload_files_object]) as client:
    files = [("cv", b"1"), ("diploma", b"1")]
    response = client.post("/", files=files)

So you don't have the nested structure, but simply a multipart body with multiple files in it. The line "multiple named files" is misleading I think.

Aah that make sense to me. Yeah, it was the "multiple named files" that got me confused.

Actually, @provinzkraut why isn't the example shown in the original MCVE supported? It's possible that only a single file is given for a single field name in the multipart form, no? So, I'd argue that the original bug I'd mentioned is actually a bug.


Fix LHN - Click and long pressing a user report with lots of messages opens popover inside report

Details
Do not show the ReportActionContextMenu (popover menu) if OptionRowLHN (left hand sidebar link) has lost focus.
Fixed Issues
$ https://github.com/Expensify/App/issues/25460
$ PROPOSAL: https://github.com/Expensify/App/issues/25460#issuecomment-1688345649

Tests

While the left hand navigation rows are visible, long press one of the rows
Verify pop up shows
Dismiss the pop up by tapping outside
Tap on one of the items and quickly long press on the same item
Verify pop up does not show while on the report screen

[x] Verify that no errors appear in the JS console

Offline tests

Same steps as the Tests section above.
QA Steps

Same steps as the Tests section above.

[x] Verify that no errors appear in the JS console // no error related to the new code

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/carlosalmonte04/Expensify-App/assets/25206487/0d0d2694-53c3-49d9-afb2-b4d5872ae3c4
The right click context menu showing is an issue different from this one at 0:01, 0:06, etc....

Mobile Web - Chrome
https://github.com/carlosalmonte04/Expensify-App/assets/25206487/21b67e63-bd98-41ef-a39d-0946ab31ddc4

Mobile Web - Safari

https://github.com/carlosalmonte04/Expensify-App/assets/25206487/6914c28b-5b08-4aa2-b4a7-cd8c986ff0cc

Desktop

https://github.com/redpanda-bit/Expensify-App/assets/25206487/36dd9d42-2b66-403c-9741-e1237dce2c76

iOS
https://github.com/redpanda-bit/Expensify-App/assets/25206487/c3f4120a-341a-471c-827a-725958f2dcab

Android
https://github.com/redpanda-bit/Expensify-App/assets/25206487/14664c85-d383-481e-86bb-b6645c70c842

I have read the CLA Document and I hereby sign the CLA

recheck

@redpanda-bit, seems like we have unsigned commits!

@Gonals sorry I thought I had configured my git properly. Would I need to force push now that I have the commits signed?

@Gonals sorry I thought I had configured my git properly. Would I need to force push now that I have the commits signed?

Give that a try, yes!

@Gonals done, thanks so much.

There are a couple of lint issues left, regarding conditionally calling hooks!

No way! Thanks a lot for being patient, I'm used to jest and lint running on git hooks.

Fixed the lint errors by moving hooks above conditional renders – there are other rulesdir/no-multiple-onyx-in-file lint errors but the rule was introduced recently, so I'm guessing someone is working on fixing those errors? I can take care of those if you'd like. Please let me know.
Merged main to fix the failing jest unit test.

Moved to https://github.com/Expensify/App/pull/28614 due to various merge issues. Closing


merged history changes (yet again)

The branch history was messed up beyond merging, created new branch, merged changes manually.
So this is the continuation of #78 .

Coverage decreased (-0.8%) to 90.769% when pulling e0e0845ab3e45a0114cd5b02713b3d9c81cc0c57 on ChristianKuehnel:history2 into 15171fa543ee65c3167d0c241521290eb764ae1d on open-homeautomation:master.

Coverage decreased (-0.8%) to 90.769% when pulling e0e0845ab3e45a0114cd5b02713b3d9c81cc0c57 on ChristianKuehnel:history2 into 15171fa543ee65c3167d0c241521290eb764ae1d on open-homeautomation:master.

rebased on master to fix failing build


test_messages: Fix list ordering flake in test_wildcard_mention

lgtm, feel free to merge once CI passes.  Thanks for fixing!


ANL-INL DMDc implementation

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1299
What are the significant changes in functionality due to this change request?
This PR implements the Dynamic Mode Decomposition method with Control

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wanghy-anl The PR is ready....can you take a quick look to check if it is okay?
@idaholab/raven-team I am looking for a reviewer.... Volunteers Volunteers!!

@wanghy-anl The PR is ready....can you take a quick look to check if it is okay?
@idaholab/raven-team I am looking for a reviewer.... Volunteers Volunteers!!

Is it ready? @alfoa I can take a look. By the way, the tests are failing.

Is it ready? @alfoa I can take a look. By the way, the tests are failing.

@alfoa Seems the training data files are missing for "test_DMDC_with_output2.xml" after git pull. There should be a "SES_22_TUYX_Selected_hs2.csv" file at the same folder of this input file.

@alfoa Seems the training data files are missing for "test_DMDC_with_output2.xml" after git pull. There should be a "SES_22_TUYX_Selected_hs2.csv" file at the same folder of this input file.

merging in a local branch to be worked on for readapting it to the new ROM api


Support Priority Fields in Workflow Pods

Our GPU cluster highly depends on priority classes and our custom scheduler. We want to set them per workflow or template.
@alexmt @jessesuen Could you consider merging this change?

@jessesuen I rebased the code and resolved the conflicts with https://github.com/argoproj/argo/pull/1184. Could you review it? Also, may I have your opinion about the field name?

I rebased the PR with the master branch.

@alexmt Could you review this PR. It's a very simple change.


Impl Serialize/Deserialize for !

Serialize is straightforward. As for Deserialize, I guess it would just panic? This is useful for me when serializing and deserializing types like Result<T, !>.

If we do Deserialize for ! it should error, not panic.
Is Result<T, !> the only instance where you need this? Would it make more sense to specialize De/Serialize for Result<T, !> instead of implementing them for !? Result<T, !> is equivalent to T so we might as well serialize it the same way.

The Result<T, !> was actually a simplified example. My actual use case involves an error type where one variant is generic: the actual type being deserialized is Result<T, Error<!>>. Basically, if a user implements a service that can never return an application error, the application error is !, and the framework error is Error<!>.

That being said, it could definitely make sense to specialize the Result<T, !> case as well!


add mysql encoding test

Codecov Report

Merging #1838 (ec69061) into main (d16a03b) will decrease coverage by 0.09%.
The diff coverage is n/a.

:exclamation: Current head ec69061 differs from pull request most recent head 0bce4c0. Consider uploading reports for the commit 0bce4c0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   61.84%   61.74%   -0.10%
==========================================
  Files         135      135
  Lines       23019    23019
==========================================
- Hits        14236    14214      -22
- Misses       7184     7205      +21
- Partials     1599     1600       +1

Impacted Files
Coverage Δ

pkg/fuse/context.go
56.75% <0.00%> (-10.82%)
:arrow_down:

pkg/chunk/cached_store.go
76.59% <0.00%> (-1.65%)
:arrow_down:

pkg/vfs/reader.go
80.29% <0.00%> (-1.28%)
:arrow_down:

pkg/meta/base.go
71.18% <0.00%> (-0.51%)
:arrow_down:

pkg/meta/sql.go
66.96% <0.00%> (-0.11%)
:arrow_down:

pkg/chunk/utils_unix.go
93.33% <0.00%> (+20.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16a03b...0bce4c0. Read the comment docs.


Updating network commands: adding man pages

Updating the commands after running some tests
Questions in text to be answered
Added man pages

Signed-off-by: Mary Anthony<EMAIL_ADDRESS>ping @mavenugo  @dave-tucker see tagged questions in text

@moxiegirl @mavenugo with #17218 the man page and reference page will need updates. If this is merged first, I'll do it :wink:
@tiborvass added 1.9.0 milestone on this one

@vdemeester thanks for the note. :-D  I have changes to make to this material. Either tonight or first thing morning.  If you go first, I have no troubles rebasing.

Also, I think we should standardize on "Network Driver" over "driver" or "plugin".
This terminology would be inline with Volumes AFAICT
https://docs.docker.com/extend/plugins_volume/

Folks, you are welcome to review this but it isn't really ready. I started this early and am updating this weekend. I'll switch the STATUS back to docs review when it is ready.
Apologies for the confusion...I need to add a status for: drafting

@moxiegirl prefix the title of the PR with [WIP], that usually works (but don't forget to remove it when ready for review :-))

Ping @vdemeester @thaJeztah @dave-tucker @mavenugo Ready for review of the commands

@vdemeester Any more comments --- I know you got more. :-D

@moxiegirl was outside biking 🚴 — but yeah had more 😝

@moxiegirl thanks for pulling this together. gave a few comments to the reference docs. I guess they are applicable to the man pages as well.

@moxiegirl I'm looking at this PR "in between other tasks", so comments will arrive in untimely fashion. If you are in a hurry getting this merged, let me know :smile:

@vdemeester @thaJeztah @dave-tucker @mavenugo Thank you all.  I had a couple questions for Madhu but otherwise entered comments by way of response.  Tried only to comment against those I wasn't entering or entering partially.  Except for one comment form @vdemeester which struck me as very @thaJeztah like and made me smile at both of them.

@vdemeester @thaJeztah @mavenugo  Please be prompt with your LGTMs.  I'm very tight up to the release and I want to rebase this change into: https://github.com/docker/docker/pull/17340 today.
Rather than going for perfect, we'll need to settle for works ok.

Merging for RC.  Please go ahead and comment on this if you have outstanding.  I'll touch the all on the other pr I have open.

cp please @tiborvass


Class output doesn't seem to work with RGB function

Hello,
Thank you for this library. I've been trying to get it working using the following setup: CRA v5 and Tailwind 3.3.3.
First of all, it would appear the instructions detailed in the README are out of date – the only way I was able to get it to work without throwing an error is as such:
const { withTV } = require("tailwind-variants/transformer");

const radix = require("windy-radix-palette");

module.exports = withTV({
  content: ["./src/**/*.{js,jsx,ts,tsx}", "./stories/**/*.{js,ts,jsx,tsx}"],
  plugins: [
    radix({opacitySupport: true}),
  ],
});

Either that, or my setup doesn't work with the recommended approach for whatever reason.
This seems to work, in that a bunch of CSS variables are created and added to the :root selector, see here:

From what I gather, the alpha for color functions is defined in the following way (see https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/color):
color(display-p3 1 0.5 0 / .5);

The classes that are generated by this package look like this:

Applying this to any HTML element on the page doesn't actually turn the background red.
Changing the background-color attribute to simply var(--red-9) works fine. So I'm guessing the issue is that variables that use the color function cannot be passed in to the rgb function. I did a bit of Googling but couldn't find any clear answers – wondering whether I'm doing something wrong, or whether this is in fact a bug?
Thank you in advance.

Hey, thanks for reporting your issue -- do you mind sharing which version of the package you are using?

Hi, I've tried to recreate your issue, but I'm not seeing the problems with getting the plugin setup that you are seeing. Take a look at this codesandbox where I've tried to make a minimal repro. I got the plugin working with the instructions in the readme, so I'm not sure what is different about your setup that might cause an error to happen.
I suspect that if we manage to get you using the plugin in the expected way, then your issue with the color opacity might get fixed as a side effect. To me it looks like the part of the plugin that generates the CSS variables thinks that opacity support is disabled, but the part that generates the Tailwind config thinks that it is enabled.

@brattonross – thank you so much for this – I tried using the latest version – the same version that you used in the sandbox, and it started working! Thanks for taking the time to look at it, it is greatly appreciated.


Multiple Hitbox selection and Hitbox priority, draw aimbot fov

Allow us to select multiple hitboxes(ex: head,chest,stomach,pelvis)
and allow us to set hitbox priority(ex: Head, body) (body includes: chest, stomach, pelvis) ( can only be set to either Head, or body)
These features would be very good to have in osiris
and there's also draw aimbot fov which would allow us to customize the fov in more detail.

#2218

hitboxes are not reliable for an aimbot, bone aimbot is better. regarding your request of mulitiple "spots" for aimbot to work with it will eventually lock your crosshair to one "spot", which is the same as "nearest bone" selection.
you could do bone selection in the current osiris without any modification; just set minimum damage to a value that favours your hitboxes and choose nearest bone.
for example if I set minimum damage for AWP to a value above 85, the aimbot will lock my crosshair to any bone but the legs, i.e: head, chest, stomach. (that is of course considering there's a little to no damage drop off).
and so on, do the rest of weapons according to their meta


fix race condition on progress that could cause deadlock

Q
A

🐛 Bug fix?
yes

🚀 New feature?
no

⚠ Deprecations?
no

❌ BC Break
no

🔗 Related issues

❓ Documentation
no

Description
fix race condition on progress that could cause deadlock

LGTM


Where can I get the all tokenColorCustomizations scope strings?

🚨 The issue tracker is not for questions 🚨
Where can I get the all tokenColorCustomizations scope strings?

Developer: Generate Color Theme From Current Settings

Developer: Inspect TM Scopes

Developer: Generate Color Theme From Current Settings

Developer: Inspect TM Scopes

Thank you

Developer: Generate Color Theme From Current Settings

Developer: Inspect TM Scopes

But I saw there has the string "keyword.operator.sizeof.c", but I have not seen in the "Developer: Generate Color Theme From Current Settings" result file


Is not possible to check only a file

There is not a way to verify all function of a single file.

Commit 3c80ebcf2d96b1d4fb52f04228307d4bc1a212df added this feature.


update langchain huggingface embedding

this is causing the no content generation when google/huggingace are used as llm/embedding models

Thanks super important!


Adding a new service

f there's a possibility to integrate Yandex Music (the most popular service in the CIS region) in the future, there exists an unofficial API documented at https://yandex-music.readthedocs.io/en/main/. The service hosts a vast array of tracks in high quality and supports various API implementations in different languages such as OpenAPI, C#, PHP, TypeScript, JavaScript, and Python.

Hello @TAtt04ek666, and thank you very much for the suggestion! I think this is a great idea for the people living in CIS region who want to use the application, but I'm afraid that for now this is going on the long running backlog with the other issues. I'll try to find time for this project in the near future again.


Implement document highlight fallback for search-based intel

Fixes https://github.com/sourcegraph/sourcegraph/issues/35843

@olafurpg Do we want to close and/or transfer the code in this PR to sg/sg?

Closing since we should implement this feature in sg/sg


[XR] Fix binds for composition layer virtuals

As they are called with no arguments I assume the binds were invalid, likely copy-paste error

Fixes: https://github.com/godotengine/godot/issues/90390

Thank you!


Problem with french diacritics

Hello,
I've got problems with the following file http://www.geobib.fr/tmp/IFLA_WikiCP_v0.pdf opened with pdf.js. The é characters aren't displayed correctly, the diacritics which should be dislplayed above the character centered, is shifted to the right.
The PDF works fine with other PDF viewers.

The link is dead and the file cannot be found anymore on Google or the Internet Archive. Closing because this cannot be reproduced anymore. If the problem remains, please provide a new PDF file so we can reopen this.

@timvandermeij the PDF is not on my server anymore but you can find it there : https://hal.inria.fr/hal-01076038/document
I have just tested, ubuntu 16.04, FF 46.0 and the é in the title are displaying as e' with the diacritic not on top of the letter.

This is working as expected for me on Arch Linux, but I'm reopening the issue to track the problem for Ubuntu. Thanks.

Same issue on Debian too.

I can't reproduce on Ubuntu 16.04 w/ Firefox 58. I'll close the issue, but if there are still problems let us know and we'll re-open.

Problem is still here with Firefox 57 and Debian testing (> stretch).
cf. pictures on page 2 with référence (okular)

As @SamyCookie points it, the é are fine on the first page, but on page 2, with FF 56.0 with ubuntu 16.04.3 I have the same issue.

Here is the original PDF file with the same issue without the first page (added by the french HAL platform).
https://iflaparis2014.sciencesconf.org/file/92290

Closing since this is now fixed, most likely by #9340 since I cannot reproduce it anymore now but could a few days ago.

I cannot reproduce this bug either. Thanks for the fix !


Python 3.11 is not supported for torch.compile

add to the readme a disclaimer that torch.compile is not supported with python 3.11
add to the validation a check for python 3.11 and simply warn about this
skip torch.compile if python 3.11

Closing as support was added: https://github.com/pytorch/pytorch/issues/104918


do not use readline when reading the content of a part in the multipart reader

multipart uploads to an aiohttp server with a "large" file containing no new line fails with a ValueError('Line is too long'):
import aiohttp
import aiohttp.web
import asyncio

async def view(request):
	reader = await request.multipart()
	async for part in reader:
		v = await part.read(decode=True)
		print(part, len(v))
	return aiohttp.web.Response(text="OK")

async def server(loop):
	app = aiohttp.web.Application(loop=loop)
	app.router.add_post('/', view)
	handler = app.make_handler()
	await loop.create_server(handler, '<IP_ADDRESS>', 1111)

async def main(loop):
	srv = await server(loop)
	async with aiohttp.post('http://<IP_ADDRESS>:1111', data={'val':b'0' * (2 ** 16 - 100)}) as resp:
		print('--->', resp.status)
	print('--')
	async with aiohttp.post('http://<IP_ADDRESS>:1111', data={'val':b'0' * (2 ** 16 + 1)}) as resp:
		print('--->', resp.status)

loop = asyncio.get_event_loop()
loop.run_until_complete(main(loop))

<aiohttp.multipart.BodyPartReader object at 0x109c10f28> 65436
---> 200
--
Error handling request
Traceback (most recent call last):
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/web_server.py", line 61, in handle_request
    resp = yield from self._handler(request)
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/web.py", line 268, in _handle
    resp = yield from handler(request)
  File "poc.py", line 9, in view
    v = await part.read(decode=True)
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/multipart.py", line 257, in read
    data.extend((yield from self.readline()))
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/multipart.py", line 351, in readline
    line = yield from self._content.readline()
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/streams.py", line 517, in wrapper
    result = yield from func(self, *args, **kw)
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/streams.py", line 587, in readline
    return (yield from super().readline())
  File "/Users/arthur/Documents/reaaad/lib/aiohttp/aiohttp/streams.py", line 251, in readline
    raise ValueError('Line is too long')
ValueError: Line is too long
---> 500

This is because the StreamReader class only accepts lines up to 64KB.
I've updated the MultipartReader class to avoid readline when it doesn't really make sense, and to use read_chunk instead.
As far as I can see, it seems to work, but that might not be the right approach to solve this at all…

@kxepal
you are very popular :)

Current coverage is 98.71% (diff: 100%)

Merging #1535 into master will decrease coverage by 0.20%

@@             master      #1535   diff @@
==========================================
  Files            30         30
  Lines          6987       6981     -6
  Methods           0          0
  Messages          0          0
  Branches       1162       1158     -4
==========================================
- Hits           6911       6891    -20
- Misses           37         53    +16
+ Partials         39         37     -2

Powered by Codecov. Last update 0e7ea65...f8bddd9

@arthurdarcet
Good catch!
@fafhrd91
Ahaha! Indeed. As ours multipart feature (:

what is status of this ticket?

@kxepal ?

@fafhrd91 Sorry, a bit busy times. I have all the tickets you ping me stared in by inbox, will check them in few hours.

thanks!

+1


review tests on Windows

some tests aren't working on Windows, probably never have.

Hi @christian-korneck,
I found 3 issues when running test ong windows. But I'm not sure whether it's a environment or os specific for the first two issues.

I can't found getvalue method on windows
https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/high_level_layer_test.go#L19

I got a PyExc_KeyboardInterrupt which don't match PyExc_TypeError.
https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/errors_test.go#L250

File path is diffrent. This issue can be fixed by trim "/"
https://github.com/go-python/cpy3/blob/8f74340f20d8e1fd67f3820a9732a0fe5bc41859/module_test.go#L110

thanks, would love to see PRs to fix these.


Issue with cleanDna function when trying to add attributes type e.g. eyes#10_pirate.png

Hey everyone, hope you're all doing fine. Due to my basic knowledge in JS I am having difficulties understanding the cleanDna function.
const cleanDna = (_str) => {
  var dna = Number(_str.split(":").shift());
  return dna;
};

Could anyone please explain it and help me figure out how to modify it, to account for a name such as eyes#10_pirate.png
My goal is to be able to limit which attributes can be used together. E.g. I don't want a pirate to have a British uniform for example.
I have changed the code to account for the _pirate which would be my attribute type but I am stuck with the cleanDna function as it now says
"TypeError: Cannot read property 'split' of undefined"
My cleanName function looks like this now:
const cleanName = (_str) => {
  let nameWithoutExtension = _str.slice(0, -4);
  var nameWithoutWeight = nameWithoutExtension.split(rarityDelimiter).shift();
  var nameWithoutTypeAndWeight = nameWithoutWeight.split(typeDelimiter).shift();
  return nameWithoutTypeAndWeight;
};

My getElements looks like this now:
const getElements = (path) => {
  return fs
    .readdirSync(path)
    .filter((item) => !/(^|\/)\.[^\/\.]/g.test(item))
    .map((i, index) => {
      return {
        id: index,
        name: cleanName(i),
        filename: i,
        path: `${path}${i}`,
        weight: getRarityWeight(i),
        type: getNftType(i),
      };
    });
};

And I have added a getNftType function:
const getNftType = (_str) => {
  let nameWithoutExtension = _str.slice(0, -4);
  var nameWithoutType = nameWithoutExtension.split(typeDelimiter).pop();
  if (isNaN(nameWithoutType)) {
    nameWithoutType = 0;
  }
  return nameWithoutType;
};

Other than adding typeDelimiter to module.exports and in const {} in main.js I added the following in config.js:
const typeDelimiter = "#";

I know I have probably already made plenty of mistakes to achieve what I need but am hoping someone can guide me to the correct way.
Thank you so much.

if you want to render pirates and soldiers in the same collection, but they have mutually exclusive layers you have to use the layoutConfigurations array in config.js.
Here is an example:
const layerConfigurations = [
  {
    growEditionSizeTo: 50,
    layersOrder: [
      { name: "Background" },
      { name: "Hat" },
      { name: "Eyes" },
      { name: "Clothes" },
      { name: "Weapon" },
    ],
  },
  {
    growEditionSizeTo: 100,
    layersOrder: [
      { name: "Background" },
      { name: "Hat_pirate" },
      { name: "Eyes_pirate" },
      { name: "Clothes_pirate" },
      { name: "Weapon_pirate" },
    ],
  },
];

Pros:

No code change
Mutually exclusive layers (pirates and soldiers)
All in same collection

Cons:

No weight given to species.
Manually dictate how many pirates and soldiers you will have.

Let me know if you want to discuss how to make mutually exclusive layers without using layerConfigurations. That would be a totally separate approach.

Thank you for your input. I am currently doing it this way although I was worried about the excess amount of attribute filters in the opensea sidebar. I Will post back once I uploaded a test collection, for others that are interested in this approach.
Best regards.


Is FP34 data included?

I have gotten a few questions recently about whether FP34 data is included
I think we should find out for definite (as we don't know for certain) and add to FAQS

I've emailed the BSA to ask.

Response from BSA confirms that FP34 data is included:
"I can confirm that all items claimed for as part of FP34D/PD submissions are included in the English Prescribing Dataset. Please see the English Prescribing Dataset guidance which can be found on the link below, this shows what is and is not included within the data."
https://nhsbsa-opendata.s3-eu-west-2.amazonaws.com/English%20Prescribing%20Dataset%20Release%20Guidance%20v002.odt

https://github.com/ebmdatalab/openprescribing/pull/4031

Approved updates to FAQ wording.


chore(deps): update dependencies for docusaurus

Current dependencies on/for this PR:

main

PR #85   👈

This comment was auto-generated by Graphite.


Remove specific styles in HTMLStructure.module.scss. The article should not have proprietary styles

Done!


Training Throughput in Multi-GPU Training

Hi,
Thanks for developing this very nice NMT toolkit. I have a question about the training throughput reported in the context of multi-GPU training. When we are using multi-GPU, is the throughput number shown by mxnet.callback.Speedometer showing the overall throughput across all the devices?
Thank you.

Yes it's the overall speed. For multi-GPU training gradients are computed for separate subsets of the batch on separate GPUs and then communicated to the master GPU for a synchronous update.


How to enable TLS 1.0 and 1.1 when built with OpenSSL 1.1.1?

Hello, when I build either dev version or stable version from source on Debian 10 with Openssl 1.1.1d, TLS 1.0 and 1.1 clients can't connect. Only those with TLS 1.2 and 1.3 can.
However when I use the official binary (build 9745), it connects in all versions from 1.0 to 1.3. So it must be using 1.1.1 as well.
What should I do to make TLS 1.0 and 1.1 work in my builds?

OpenSSL on Debian 10 is built with TLS 1.0 disabled.
You may build your own separate openssl from source and link it using rpath

Thank you for your quick answer. I will try it.

I managed to get TLS 1.0 working by making a copy of /etc/ssl/openssl.cnf and change the last section like this.
361,362c361,362
< MinProtocol = TLSv1.2
< CipherString = DEFAULT@SECLEVEL=2
---
> MinProtocol = TLSv1
> CipherString = DEFAULT@SECLEVEL=1

Then set the environment by export OPENSSL_CONF=new path to openssl.cnf and run vpnserver again.
There is no need to rebuild the project or OpenSSL. (I actually rebuilt OpenSSL but it didn't work... could be my fault...)
This approach is obviously different from the official binary which does not need exporting. It's definitely not ideal but working.
This might duplicate with #1053 .

I did not mean to rebuild and install in place. Sorry for that.
I meant "install in separate folder ... and make it use separate openssl.cnf" :)
great you've figured it out.
also, there are some hardening in RHEL8 and maybe other modern distro as well.
should we adopt documentation ? or make changes in code ?
what would you suggest based on your experience ?

Apparently Debian 10 and Ubuntu 20.04 have dropped TLS 1.0/1.1.
Since it's been over a year and there is very few complain so far, I assume most users are fine with the change. 🤔
I personally do not need these obsolete versions either. I was just doing some experiment with my app.
So if we change the code and overwrite the system default, the user might not even notice but we are actually introducing risks.
To me a mention in the documentation sounds enough. At least the official binary still supports old versions and ordinary users would be just fine.

I would consider supporting TLS 1.0/1.1 when the system explicitly forbids it a bug.

Thanks for the pointers here, very helpful in fixing my #1525!
Just a quick comment for those running SoftEther as a service with the provided systemd files - I think the recommended way to implement the fix in this case should be to create a duplicate/edited OpenSSL <new cnf file> file as described by domosekai above, and then changing the environment variable at the service level, i.e. editing softether-vpnserver.service and adding the following line before ExecStart:
Environment="OPENSSL_CONF=/etc/ssl/<new cnf file>"


[Readme] "Blockquotes" is using a larger font size, and the distance between rows is too large

Repro:
Test package: https://int.nugettest.org/packages/license-expression-test2
Add this blockquotes into a readme file:
line 1
line 2
line 3
> quote1
>> quote 2
>>> quote 3

> quote 4

line 4
line 5

The package detail page shows:

Could the rendering be better?

@zhhyu , what is your recommedation?
@lyndaidaii , FYI

CSS needs to be polished. The parser just translates the markdown into HTML if I understand correctly.

I don't think this is necessary, but this is nice improvement for display.
Also this is example how github render this would look like:

blockquote font is too large (20px), I think it should not larger then font size of content (16px).

@jamesfancy Thank you for providing your feedback. We will reprioritize this issue.

I use blockquotes to highlight notes and warnings, but the larger text makes it look really weird. Compare the same readme below on GitHub vs NuGet gallery:


Extract hexagon icon from remaining Artifact cards

Let's finish extracting the hexagon icons from the Artifact cards. Please see the existing scripts to help extract hexagon icons and place them onto the appropriate border templates.
Details:

Please base your work off of the main-new-graphics branch.
The script is already set up to do this correctly, but within each age we want the colors ordered as followed: blue, red, green, yellow, purple.
It seems the location of the bottom right icon is a few pixels off (it must be positioned a little different than in the base set). See 004_artifacts.png as an example.
Be sure to give the files a suffix (_artifacts).
Add the artifact icons to the bottom of the existing hexagon spritesheet (rename the script from base_hexagon_icons.sh to hexagon_icons.sh and the image from base_hexagon_spritesheet.png to hexagon_spritesheet.png).

NOTE: Before you begin working on this, please assign this issue to yourself. If you do not do this, then there's the possibility that 2 people will end up doing the same task, which is not a good use of time.

I will take this for now so that I can get enough done to unblock the graphic refresh work and then when I'm done I'll unassign myself and leave a comment describing what work is left.

I ended up just finishing it!


tests for list ordering

fixes #550

@blafond @DavideD there's something I noticed when I was working on this that I apologize for not noticing before: in these tests we have lots of duplicated tests, one for Stage, and one for Mutiny.
We definitely don't need to do this in future. Indeed, it's bad that we have done this (though I left it alone for now).
Look, I know there's a lot of irrational/magical thinking around testing in our industry but objectively:

the more code you have, the harder it is to change your program
therefore, code duplication is bad
tests are code
therefore, duplicated tests are bad QED

It is simply not the case that "more tests" => "better tested code". Nononononono. To have well-tested code you need to think carefully about what sort of things might break and target your tests toward those things, always actually aiming to break your code.
Sure, I can spend hours writing thousands of tests for minor variations of stuff that is very similar to stuff I already have tests for and then walk around telling everyone "ooooh look how well-tested my code is", but I would be a liar, because I wasn't actually trying to break anything. All I've done is make my test suite slow and redundant and difficult to maintain. All I've done is created problems for the future.
I don't need a test suite where 300 tests fail when I break one thing. Actually, I hate it when that happens.

I think I need some time to answer to this.

Sure.
All I'm saying is it's OK to use our insight into how our code is written when deciding which tests to write. We know for sure that StageSession and MutinySession are very trivial wrappers, and so, once we have basic tests for their basic operations, we don't need to duplicate every other test for both of them.

All I'm saying is it's OK to use our insight into how our code is written when deciding which tests to write. We know for sure that StageSession and MutinySession are very trivial wrappers, and so, once we have basic tests for their basic operations, we don't need to duplicate every other test for both of them.

That's not true. If this were your only comment,  I wouldn't have any problem discussing it.
But you are saying that I write tests for the sake of adding code to our code base without thinking about it.
I might be open to discuss the fact that testing both API might not be necessary and we maybe need to rethink the way we write the tests (I know that build time will become a problem, eventually).
But the way you voice your concerns doesn't put me in the best mood to participate to this conversation.

But you are saying that I write tests for the sake of adding code to our code base without thinking about it.

No, I was espousing a general principle. "You" in that comment never refers to you personally. You can read "you" as "one", if you prefer.

i.e.
The middle paragraph can be reworded:

It is simply not the case that "more tests" => "better tested code". Nononononono. To have well-tested code I need to think carefully about what sort of things might break and target my tests toward those things, always actually aiming to break my code.

I sorta agreeing with you both .. bare with me.
My first real reactive issue was to implement support for the complex world of the @ElementCollection. The current suite of tests for each element type cover a wide range of scenarios for editing. The Action's from the Queue are executed for each edit during flush() and the logic for updating the DB via the persisters.  The edits result in recreate, remove, insert, delete and update operations and sometimes a mix of more than one operation.  Re-working the ORM version of these edits hasn't been straight forward... at least for me.  Seems that having tests for each scenario for each type at this point makes sense.
My understanding of the Stage -vs- Mutiny is about testing that the corresponding functions/methods that execute the user functions. I haven't dug into the Mutiny framework yet... but there has yet to be a case where a direct swapping out of methods didn't work.  So I'm in favor of just keeping one set of tests in one element collection type.
This would reduce the # tests for each type from 30 -- > 15

My first real reactive issue was to implement support for the complex world of the @ElementCollection. The current suite of tests for each element type cover a wide range of scenarios for editing.

I mean, for sure there are going to need to be quite a few tests for this. I mean, just to begin with, ReactiveCollectionPersister has five different reactive operations, and we need to be sure these work correctly for List vs Set vs Map vs array, and with variations like @OrderColumn.

Re-working the ORM version of these edits hasn't been straight forward... at least for me.

If it was straightforward we would have already done it. It was a missing feature because we knew it wasn't that easy.

Seems that having tests for each scenario for each type at this point makes sense.

Absolutely.

This would reduce the # tests for each type from 30 -- > 15

Right, that's what I'm talking about.

It seems to me that the main issue is about testing the Session.Mutiny API.
I'm not completely on board with this but I think having a place where discuss it might be more constructive.

It seems to me that the main issue is about testing the Session.Mutiny API.
I'm not completely on board with this but I think having a place where discuss it might be more constructive.

Sorry, I meant to say that I'm going to create an issue about it

No, I was espousing a general principle. "You" in that comment never refers to you personally. You can read "you" as "one", if you prefer.

That might be a general principle but you have written it in a comment addressed to me, in regard to an issue I helped to solve on a project I'm contributing with others.
You didn't write it on your personal twitter account or on your blog.
The context you have decided to share this story and the words you have chosen make it personal.
Even if, maybe, you didn't mean to.


Review API Surface area in Steeltoe.Common

See https://github.com/SteeltoeOSS/Steeltoe/issues/897#issuecomment-1198088843.

Consider adding an extension method to set up IApplicationInstanceInfo. See the conversation at https://github.com/SteeltoeOSS/Samples/pull/331#discussion_r1646201252.

We should be able to close #590 during this review


Trusty is removed from packages.ubuntu.com

https://packages.ubuntu.com/

2019-04-23
Reflect disco release, add eoan, remove trusty.

Do you want to provide a PR maybe?

Oh sorry I forgot, I'll close this issue now


Adding a new JPA work item handler

This is a Pull Request to add the JPA WorkItemHandler to the work item handlers collections. The aim of the JPA WIH is to allow users to perform JPA operations against a persistence unit created in the persistence descriptor. The supported operations are: create, update, delete, get and query. The general instructions to use it are in the JPA WIH javadoc and also in these posts:
http://fxapps.blogspot.com.br/2016/04/a-jbpm-6-jpa-work-item-handler.html
http://fxapps.blogspot.com.br/2016/05/a-crud-using-jbpm.html
If there's any problem, please let me know.

do you mind squashing all commits and create jira for it - use jira number in the commit message so we clearly know what's it about

would be good to add documentation based on your blog posts (+ N&N section so users will know about this)

Hello @mswiderski thanks for the instructions, I will create the JIRA and add all commits to a single one in a new branch tomorrow. I will close this PR for now.


Added current and past users tab on User Management Page

Targets #1787
Description
Added Current and past users tab on User Management Page
Checklist:
[ ] I have performed a self-review of my own code.

I have understood what I have to do now, but having difficulties in making or opening soft deleted users from the database. So please guide me on this

I have understood what I have to do now, but having difficulties in making or opening soft deleted users from the database. So please guide me on this

You can go through this link to figure out the method
https://onlinecode.org/how-to-get-soft-deleted-records-in-laravel/

@P4NK4J   I got stuck in the routes, basically, I am having issues in adding features to the past and current tabs. so please guide me on this.


Double clicking text in the search editor opens the editor that contains the corresponding search result

Found while testing: https://github.com/microsoft/vscode/issues/89396
Issue Type: Bug
Open a search editor
Run a search
Go to any result
Double click on some text in a result
Expected: text to be highlighted
Actual: another editor is opened containing that search result
I realise that this is the behaviour of the search viewlet but the fact that this is the default for search editors seems inconsistent. I think the default should be selectWord for search editors.
VS Code version: Code - Insiders 1.42.0-insider (c4b6a6b537de49a734d0eedea06152ea37dfdb6a, 2020-01-28T05:38:41.922Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (5.58GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

tslint
eg2
1.0.44

vscode-github-releases-updater
joa
0.18.0

vscode-docker
ms-
0.10.0

python
ms-
2020.1.58038

remote-containers
ms-
0.99.2

remote-ssh
ms-
0.48.0

remote-ssh-edit
ms-
0.48.0

remote-wsl
ms-
0.42.1

vscode-remote-extensionpack
ms-
0.19.0

azure-account
ms-
0.8.8

cloudenv-extensions
ms-
1.0.1369

vsonline
ms-
1.0.1507

test-search-rg
rob
0.0.3

@sbatten no difference, besides one can double click using only a mouse or trackpad. In the first release I got a good number of complaints about Ctrl+click being too high-energy for the most-common operation in the search editor.

Closing this out as I haven't received any other similar requests and we do provide the option.


[AMORO-2444] fix the problem that the y-axis content is too long to b…

…e displayed

Why are the changes needed?

Close #2444.
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.79%. Comparing base (f1fbfa1) to head (16212be).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3026      +/-   ##
============================================
- Coverage     32.80%   32.79%   -0.01%
+ Complexity     3827     3826       -1
============================================
  Files           557      557
  Lines         46194    46194
  Branches       6116     6116
============================================
- Hits          15152    15151       -1
  Misses        29845    29845
- Partials       1197     1198       +1

Flag
Coverage Δ

core
32.79% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update Enterprise docs nav sidebar to point to specific versions of Enterprise plugins

The entries in the docs sidebar nav files related to plugins here https://github.com/Kong/docs.konghq.com/tree/master/app/_data currently point to /plugins/ URLs - which now redirect to /hub/ URLs.
The sidebar nav should be updated to point to the correct version of the plugin's docs - for example, the plugins listed in https://github.com/Kong/docs.konghq.com/blob/master/app/_data/docs_nav_ee_0.32-x.yml#L29 should point to 0.32 versions of those plugins.

Not going to fix - the way the nav bar is generated makes updating these URLs impossible (unless we change how the generation work) and the current approach of generated URLs pointing to redirects works well enough.


Add button mixins and styles

In base-css create button mixings and styles by using design tokens. Create following buttons variations based on figma prototype:
https://www.figma.com/file/veQuKQHf8gK5JdFEoMLGRD/UI-Design-kit?node-id=431%3A4658

@adam-little  we have problems with cagov secondary (orange) button. It fails color-contrast check because white text doesn't have good enough color-contrast ratio.

@adam-little  @kmbrlygl  please confirm this is working as expected on https://1-0-1-rc-post-launch-fixes.pr.designsystem.webstandards.ca.gov/ I don't know what this button is referring to so dont know where to check for a color code.

@jaredwyee I think this is good to go.
Re: secondary button ^ we landed on only using showing primary (blue) and disabled buttons for now until we resolve some color palette issues. It looks like it's up to date on the Visual Design Style guide page in this release.
Also, double-checked design tokens and the color matches our UI kit

Cool, thanks


python path bug?

Hi Brad,
I ran the sv pipeline and ran into this issue. Is it a bug in installation or something wrong with mine?
subprocess.CalledProcessError: Command 'set -o pipefail; cat /hive/groups/recon/projs/mus_strain_cactus/ragout/sv/129S1/work/prealign/129S1/129S1.rg.sorted-dedup-callable-callableblocks.bed | grep -v ^track | grep -v ^browser | /hive/groups/recon/projs/mus_strain_cactus/ragout/variant/anaconda/bin/py -x 'bcbio.variation.bedutils.remove_bad(x)' | sort -k1,1 -k2,2n > /hive/groups/recon/projs/mus_strain_cactus/ragout/sv/129S1/work/bedprep/tx/tmp486zGZ/129S1.rg.sorted-dedup-callable-callableblocks.bed
Traceback (most recent call last):
File "", line 1, in
bcbio.variation.bedutils.remove_bad(x)
AttributeError: 'module' object has no attribute 'bedutils'
grep: write error
grep: write error
cat: write error: Broken pipe
' returned non-zero exit status 2

Son;
Sorry about the issue. I'm confused to what is going on with your installation, since the bcbio.variation.bedtools module has been in the code for a while:
https://github.com/chapmanb/bcbio-nextgen/commits/master/bcbio/variation/bedutils.py
Do you have PYTHONPATH or PYTHONHOME or something else set that might be disrupting this? What version of bcbio are you running? Sorry to not have any better ideas but hope this helps some.

Hi @kspham,
Closing this out since it is pretty stale and I think you're all set. If not feel free to reopen. Hope all is well.

Yes, please close
On Nov 14, 2015 7:03 PM, "Rory Kirchner"<EMAIL_ADDRESS>wrote:

Hi @kspham https://github.com/kspham,
Closing this out since it is pretty stale and I think you're all set. If
not feel free to reopen. Hope all is well.
—
Reply to this email directly or view it on GitHub
https://github.com/chapmanb/bcbio-nextgen/issues/897#issuecomment-156774416
.


Timestamps in TFragment

Is there a reason these are Int_t and not UInt_t? It makes other things down the line a little weird. I can cast them otherwise.

I'm actually now realizing how inconsistent our timestamps are throughout the code. We have them as Int_t, long, ULong64_t and  ULong_t. I can overload every one of those versions...or we can just make them consistent. I vote for consistency, but that obviously comes with the dreaded re-sort.

This is becoming an issue again with the new branch #727. Here the timestamps in the fragment are now inherited from TGRSIDetectorHit, and have thus changed from long to ULong_t (which creates warnings in TAnalysisBuilder).
I'm fine with keeping them as ULong_t, it just means we should change the buildwindow in TGRSIRunInfo to unsigned as well (and a few variables in TAnalysisBuilder).

And we should change it to ULong_t everywhere else.

On Jul 18, 2016, at 10:24 AM, Vinzenz Bildstein<EMAIL_ADDRESS>wrote:
This is becoming an issue again with the new branch #727 https://github.com/GRIFFINCollaboration/GRSISort/pull/727. Here the timestamps in the fragment are now inherited from TGRSIDetectorHit, and have thus changed from long to ULong_t (which creates warnings in TAnalysisBuilder).
I'm fine with keeping them as ULong_t, it just means we should change the buildwindow in TGRSIRunInfo to unsigned as well (and a few variables in TAnalysisBuilder).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/708#issuecomment-233343738, or mute the thread https://github.com/notifications/unsubscribe-auth/AFLTwJtytCVmnreN5qMnOS7VytDBPAlYks5qW4ysgaJpZM4I9Ftl.

yes, one of the best parts about the new inheritance scheme is the different data members (charge,timestamp, etc...) will be forced to keep the same type through out the code.

Where are we on this? This problem came up again yesterday.

I think the newfragmetn* branch fixes this - though it is not the main repo
yet.
On Thu, Aug 11, 2016 at 12:56 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

Where are we on this? This problem came up again yesterday.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/708#issuecomment-239222346,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAacI5VI46TmlrFzfoW6bgth4z9QMzrDks5qe1RCgaJpZM4I9Ftl
.

Ok. I was just curious how close this was to being in the main. i.e., should I spend time doing anything to the main for now.
On Aug 11, 2016, at 1:41 PM, pcbend <notifications<EMAIL_ADDRESS>wrote:
I think the newfragmetn* branch fixes this - though it is not the main repo
yet.
On Thu, Aug 11, 2016 at 12:56 PM, Ryan Dunlop <notifications<EMAIL_ADDRESS>wrote:

Where are we on this? This problem came up again yesterday.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/708#issuecomment-239222346,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAacI5VI46TmlrFzfoW6bgth4z9QMzrDks5qe1RCgaJpZM4I9Ftl
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GRIFFINCollaboration/GRSISort/issues/708#issuecomment-239235011, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFLTwJXfWhsMcDxn87VLUTMQM-Isq7Afks5qe17LgaJpZM4I9Ftl.

It will be in the main repo next week.  I have a merge in from your
master.  I am working on updating the options/loops behind the scene
behavior and then plan on proposing it become the main.
On Thu, Aug 11, 2016 at 1:44 PM, Ryan Dunlop<EMAIL_ADDRESS>wrote:

Ok. I was just curious how close this was to being in the main. i.e.,
should I spend time doing anything to the main for now.
On Aug 11, 2016, at 1:41 PM, pcbend<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
I think the newfragmetn* branch fixes this - though it is not the main
repo
yet.
On Thu, Aug 11, 2016 at 12:56 PM, Ryan Dunlop<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:

Where are we on this? This problem came up again yesterday.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/GRIFFINCollaboration/GRSISort/
issues/708#issuecomment-239222346>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAacI5VI46TmlrFzfoW6bgth4z9QMzrDks5qe1RCgaJpZM4I9Ftl>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/
GRIFFINCollaboration/GRSISort/issues/708#issuecomment-239235011>, or mute
the thread<https://github.com/notifications/unsubscribe-auth/
AFLTwJXfWhsMcDxn87VLUTMQM-Isq7Afks5qe17LgaJpZM4I9Ftl>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/708#issuecomment-239235806,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAacIy4T0Pu76x5avHqzc4PB4GA1thNoks5qe19tgaJpZM4I9Ftl
.

This is resolved in v3.0 where the fragments inherit from a GRSIDetectorHit


You're not allowing Paper users to have database

Paper users can't have database but other MC types (forge, spigot) can have 2 databases

solved


Removing max-average pooling, and improving 'cutout scheme'

The max-average pooling 'trick' doesn't have a theoretical basis to give better results that I know of. The reason it might be improving results could be due to the increased number of large crops from the image when using it.
A better solution would be to add the cropping scheme from BigSleep, which adds a bias for larger crops and improves  results coherence significantly.

The max-average pooling 'trick' doesn't have a theoretical basis to give better results that I know of. The reason it might be improving results could be due to the increased number of large crops from the image when using it.
A better solution would be to add the cropping scheme from BigSleep, which adds a bias for larger crops and improves results coherence significantly.

Do you think that we should just remove the current augmentation approach all together and just using BigSleep's crops? Or, do you want to preserve the non-cropping augmentations and only remove the cropping ones? Either way, I strongly support you making a branch featuring these changes.

Do you think that we should just remove the current augmentation approach all together and just using BigSleep's crops? Or, do you want to preserve the non-cropping augmentations and only remove the cropping ones? Either way, I strongly support you making a branch featuring these changes.

We Ideally we should run automated tests for what the best augmentations and hyper parameters are. I think we can and should change the cropping scheme to the big sleep ones. I've made a branch where I removed the average-max pooling and added the bigsleep crops https://github.com/EleutherAI/vqgan-clip/tree/Develop-1

I’m down to merge this into master unless someone has an objection?
@LouisCastricato @crowsonkb @neverix


For valFld and labelFld you can give a object path & inc can be array empty

This is my strucuture object :
{
   "organization":null,
   "nodes":[
      {
         "organization":{
            "shortDescription":"R&D", //label
            "idCompanyOrganization":"13a0d1ce" //id
         },
         "nodes":[
         ]
      },
      {
         "organization":{
            "shortDescription":"Service Clients",
            "idCompanyOrganization":"f8f030bb",
         },
         "nodes":[
         ]
      }
   ]
}

I can do :
$(this.$el)	.select2ToTree({
				treeData: {
					dataArr: this.options,
					valFld: "organization.idCompanyOrganization",
					labelFld: "organization.shortDescription",
					incFld:'nodes'
				}, width: '100%'
			})

👍

Hi Wikola, very sorry, I neglected this pull request (actually I neglected all the pull requests till today). The "inc can be array empty" issue was resolved by another pull request. If you are still interested in the "For valFld and labelFld you can give a object path" part, could you make a new pull request?(currently the pull request conflicts with the latest code). Thank you!

I merged the pull request (with resolving the conflicts), but it's strange that you are not listed as a contributor. I you are interested, I can add you as a  collaborator. Thanks for your contribution!

Thanks, you can but don't worry. Project's life first, glory after ! Thank for merging my (small) contribution


fix: webchat issues

fix: Webchat input bar element should not be tab-able when webwhat is disabled
fix: Webchat: disable upload image button as it isn't currently supported

:tada: This PR is included in version 0.293.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: upstream sync workflow V2

What does this do?

Remove the now deprecated upstream-to-pr.yml workflow.
Add the new sync-with-upstream.yml workflow with the following changes:

Change schedule to run the workflow from Monday to Friday, instead of every day.
Add a new template-version input to the workflow to manually indicate to which upstream version the template needs to be updated.
Update needed permissions of both workflow and Personal Access Token to the minimum, using a fine-grained token.

Backport some of the new features to sync-with-template.yml workflow.
Minor changes to the cli script.

Why did you do this?
To introduce the following new features:

Integrate changes from the latest release by default: The workflow now defaults to integrating changes from the latest stable release instead of pulling from the upstream master branch, which can be unstable.
Integrate changes from a specific release: Enables selecting a specific release version for integration. This allows for incremental upgrades, avoiding large pull requests and facilitating staggered updates. The workflow can be run manually by specifying the desired release in the release field:

Add ignored files and directories: Introduced a feature to exclude specific files and directories during updates. For instance, the ios and android directories can now be ignored, as they are no longer pushed to the repository.

Who/what does this impact?
New and current users of the template. Please read instructions in .github/project-workflows/sync-with-template.yml to setup the new workflow.
How did you test this?
I created a private fork of the template, pushed the new workflow to the master branch (so it can be used) and tested different scenarios.

Do you think a check to validate if the template-version input is a valid version string?

@fernandatoledo I tried with an invalid string ("hello") and the whole workflow just fails saying "fatal: couldn't find remote ref hello", which is what we want. What do you think?


Not working with licensee 1.8

Not working with licensee 1.8
https://github.com/cashapp/licensee/releases/tag/1.8.0
Probably because of "Remove the use of afterEvalute internally. This causes some task names to slightly change and the output folders
to slightly change when used with the Android Gradle plugin."

Gotten started on this - wanted to support both licensee 1.8 and < 1.8. Seems it is quite hard to figure out what version another plugin has. Might end up just supporting 1.8 and above as it stands.
Nice side effect is that I got some tests set up to verify the behavior of the plugin in the process.. :)

Managed to support both. #89


Fix some of the outstanding issues with the card-tricks concept exercise

Fixes #1564
Fixes #1566
Fixes #1567

Already fixed #1564.
In the future, please claim the sprint bugs before starting to work on them so that we do not duplicate efforts. I was specifically holding off on making conflicting changes to these introductions so that I could handle one fix at a time and make these easier to review.


[Feature] Caller to capture own dependencies errors

Reported errors should contain source information about the dependency
Unhandled Errors should be captured by owner

This will be released in version 1.1.13
Adding hook:

onUnhandledDependencyError( )


Migrate from tslint to eslint

Looks like this will first require upgrading node to v18 or 20+
tslint is apparently deprecated in favor of eslint now. Hopefully not much is required / configs are likely quite similar
migration guide: https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration
And then run the linter on the whole repo, e.g. https://stackoverflow.com/questions/41702815/how-to-make-visual-studio-code-check-entire-project-for-errors

Closing, will be addressed in https://github.com/toddmedema/electrify/pull/77


Items file searched by translated name in refName field?

In tackling the localization stuff, it was found that we are looking up the Item's name in the refName column even when our name is in a translated state and the refName fields are all always in english? This was changed in b2cc9fbc4212bf9bb09af74b48e90ed620c15459 where before it was by ITEM_BY_TRANSLATED which is what I would expect it to be, now it is ITEM_BY_REF.
Current:
https://github.com/Kvan7/Exiled-Exchange-2/blob/fd6c194d39f4491ce33d02798b4761e749b743d0/renderer/src/parser/Parser.ts#L211
Before commit b2cc9fbc4212bf9bb09af74b48e90ed620c15459  :
https://github.com/Kvan7/Exiled-Exchange-2/blob/e3ab7ddfa8649bb6023bef8a223f837d64b5e02b/src/parser/Parser.ts#L178
For a Ruby Ring (what I have been testing this against) the items.ndjson of old poe1:
English:
https://github.com/Kvan7/Exiled-Exchange-2/blob/e3ab7ddfa8649bb6023bef8a223f837d64b5e02b/public/data/en/items.ndjson#L2182
{"name":"Ruby Ring","refName":"Ruby Ring","namespace":"ITEM","craftable":{"category":"Ring"},"icon":"https://web.poecdn.com/gen/image/WzI1LDE0LHsiZiI6IjJESXRlbXMvUmluZ3MvUmluZzciLCJ3IjoxLCJoIjoxLCJzY2FsZSI6MX1d/0e04df86a3/Ring7.png"}
Russian:
https://github.com/Kvan7/Exiled-Exchange-2/blob/e3ab7ddfa8649bb6023bef8a223f837d64b5e02b/public/data/ru/items.ndjson#L2182
{"name":"Кольцо с рубином","refName":"Ruby Ring","namespace":"ITEM","craftable":{"category":"Ring"},"icon":"https://web.poecdn.com/gen/image/WzI1LDE0LHsiZiI6IjJESXRlbXMvUmluZ3MvUmluZzciLCJ3IjoxLCJoIjoxLCJzY2FsZSI6MX1d/0e04df86a3/Ring7.png"}

This seems to imply that at 211 in the code, or way before it probably, the "name" of the item is supposed to be in english?

This is blocked (kind of) by #64

So i need to undo commit b2cc9fbc4212bf9bb09af74b48e90ed620c15459 and then redo it later when advanced item desc are added.

Done now, seems to fix the issue overall?


No need to double check the same condition

Currently, it's checking twice for exactly the same condition. Which is redundant and unnecessary.

This repository is read-only as mentioned in the readme.


support inverted PWM on STM32

Facing the problem where I need to build the same codebase for a nordic uC and an stm32f4 uC.
Even though this was merged in recently
https://github.com/zephyrproject-rtos/zephyr/pull/20657/files#diff-722b2739b6d0b69a16ee867da52074d6R58
Looks like for stm32 targets, pwm flag usage is not supported
https://github.com/vestas-wind-systems/zephyr/blob/162a49d963f0b9b94c3e25ef8de75f89f7fb4a71/drivers/pwm/pwm_stm32.c#L87-L90
One could #ifdef the application code to provide 1-period as value for the PWM signal. But Since the mechanism is there, would be nice to harmonize usage across targets.
@erwango
@rsalveti
@idlethread
Is there any plans to support this for stm?

@javier-moreno-tridonic-com There is no plan to update PWM driver to support flags yet, but any contribution to add it would be welcome!

@javier-moreno-tridonic-com I'm closing the point. Please reopen if need be

@erwango are there any plans for merging #24569 after 2.3.0 release? If so, I'd leave this open until the functionality gets merged.

@erwango are there any plans for merging #24569 after 2.3.0 release? If so, I'd leave this open until the functionality gets merged.

@gmarull Sure!


feat: leech pipeline implementation

Initial Dataflow pipeline implementation to ingest logs from GitHub into GCS.
There are a few open TODOs and outside of building the container image there is no way to deploy this yet - will get those in a follow up.

What do you think about making this a subcommand instead of a new binary?

I'm not sure how this would work with the beam runner. I'll see if I can make it work if you think it is the correct approach. I started there and pivoted away when I switch to Dataflow.

The code lgtm but I wonder if we are able to add some unit test of the pipeline part?

Yes. I'm working on tests today.