Use --no-cache with docker build

Description
The docker build command in the Makefile should use the --no-cache option to make sure all the layers are rebuilt. This is to insure that the layer updating the dependencies gets rebuilt to pull the latest versions.
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

[ ] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[ ] I have verified that new and existing unit tests pass locally with my changes
[ ] I have not allowed coverage numbers to degenerate
[ ] I have maintained at least 90% code coverage
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?
This is build related and no functional code has been updated.

@ameer-jabbar: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at<EMAIL_ADDRESS>


croatian/bosnian/serbian language provider

Please add http://www.prijevodi-online.org/ as croatian, bosnian and serbian language provider.

Please help translate subliminal in your language : https://www.transifex.com/subliminal/subliminal/


Write test for docstring of init

I wrote a test script to check if all init method do not have docstrings. And I fixed some classes.
fix #2240

LGTM.


it doesn't generate xml when some tests fail

when a test failed with panic or assert it doesn't generate any xml
i thought it is supposed to generate pass fail for tests.
will it only work if all tests pass?

@tchalamarla published an update, can you try again?

sorry for the delayed response.
it seems to be generating report with proper fail and pass case now


[BUG][Chart Name]Unable to use the saml in opensearch config

*Description
I am trying to add saml as the backend as per the official documentation
it is mounted as such , but when it tries to run during the bootstrapping it give the following error
[2023-11-07T17:49:59,675][ERROR][o.o.s.c.ConfigurationRepository] [opensearch-cluster-master-2] Cannot apply default config (this is maybe not an error!)
java.security.PrivilegedActionException: null
at java.security.AccessController.doPrivileged(AccessController.java:573) ~[?:?]
at org.opensearch.security.support.ConfigHelper.uploadFile(ConfigHelper.java:86) ~[opensearch-security-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at org.opensearch.security.support.ConfigHelper.uploadFile(ConfigHelper.java:65) ~[opensearch-security-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at org.opensearch.security.configuration.ConfigurationRepository.lambda$new$0(ConfigurationRepository.java:146) [opensearch-security-<IP_ADDRESS>.jar:<IP_ADDRESS>]
at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: com.fasterxml.jackson.dataformat.yaml.snakeyaml.error.MarkedYAMLException: while parsing a block mapping
in 'reader', line 32, column 11:
type: saml
^
expected , but found ''
in 'reader', line 42, column 13:
exchange_key: "e2fc20c4cca8f4242 ...
^
at [Source: (FileReader); line: 42, column: 13]
If tried manually it says issue in opensearch security 7 format
ERR: Seems ../../../config/opensearch-security/config.yml is not in OpenSearch Security 7 format: com.fasterxml.jackson.dataformat.yaml.snakeyaml.error.MarkedYAMLException: while parsing a block mapping
in 'reader', line 32, column 11:
type: saml
^
expected , but found ''
in 'reader', line 42, column 13:
exchange_key: "e2fc20c4cca8f4242 ...
^
at [Source: (FileReader); line: 42, column: 13]
To Reproduce
Steps to reproduce the behavior:

Install the opensearch chart with version opensearch-2.14.1
use the following config for authc rest all is default
authc:
saml_auth_domain:
http_enabled: true
transport_enabled: false
order: 1
http_authenticator:
type: saml
challenge: true
config:
idp:
metadata_url: <metadata_url>
Entity_id: <Entity_id>
sp:
entity_id: <entity_id>
kibana_url: <kibana_url>
roles_key: Roles
exchange_key: <exchange_key>
authentication_backend:
type: noop
kerberos_auth_domain:
http_enabled: false
transport_enabled: false
order: 6
http_authenticator:
type: kerberos
challenge: true
config:
# If true a lot of kerberos/security related debugging output will be logged to standard out
krb_debug: false
# If true then the realm will be stripped from the user name
strip_realm_from_principal: true
authentication_backend:
type: noop
basic_internal_auth_domain:
description: "Authenticate via HTTP Basic against internal users database"
http_enabled: true
transport_enabled: true
order: 4
http_authenticator:
type: basic
challenge: true
authentication_backend:
type: intern
proxy_auth_domain:
description: "Authenticate via proxy"
http_enabled: false
transport_enabled: false
order: 3
http_authenticator:
type: proxy
challenge: false
config:
user_header: "x-proxy-user"
roles_header: "x-proxy-roles"
authentication_backend:
type: noop
jwt_auth_domain:
description: "Authenticate via Json Web Token"
http_enabled: false
transport_enabled: false
order: 0
http_authenticator:
type: jwt
challenge: false
config:
signing_key: "base64 encoded HMAC key or public RSA/ECDSA pem key"
jwt_header: "Authorization"
jwt_url_parameter: null
jwt_clock_skew_tolerance_seconds: 30
roles_key: null
subject_key: null
authentication_backend:
type: noop

Expected behavior
Saml config should be uploaded and usable
Chart Name
opensearch-2.14.1
Screenshots
If applicable, add screenshots to help explain your problem.

@tarnjeetsingh This seems more like an issue with yaml parsing. Can you please refer https://github.com/opensearch-project/helm-charts/issues/268 to see sample config.yml and modify your settings according to that and then try?
CC: @prudhvigodithi

Yes it was resolved , actually it was the secret mounts that was creating mess in the security config, figured that out
Thanks for the help


Sidemenu starter with tabs issue

I have an app generate with ionic start myapp sidemenu.
So I have a view that I want use tab, so I just did it:
<ion-view title="Checkin Balada das crianças" class="">
 		<ion-tabs class="tabs-positive">
 			<ion-tab title="Checkin">
 				<ion-content>
 					Line 1

 					Line 2

 					Line 3

 					Line 4

 					Line 5

 					Line 6

 					Line 7

 				</ion-content>
 			</ion-tab>
 		</ion-tabs>
</ion-view>

Result:

Greetings @ag-secret!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!


shiori: 1.5.2 -> 1.5.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-shiori/shiori/releases.
meta.description for shiori is: "Simple bookmark manager built with Go"
meta.homepage for shiori is: "https://github.com/go-shiori/shiori"
meta.changelog for shiori is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.5.3 with grep in /nix/store/b7yqnyimvf6z7dpgcabnsn6x7vibqzac-shiori-1.5.3
found 1.5.3 in filename of file in /nix/store/b7yqnyimvf6z7dpgcabnsn6x7vibqzac-shiori-1.5.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
shiori

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b7yqnyimvf6z7dpgcabnsn6x7vibqzac-shiori-1.5.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A shiori https://github.com/r-ryantm/nixpkgs/archive/451da4603151f8e1f3dad4d50d5565a74ff7c708.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b7yqnyimvf6z7dpgcabnsn6x7vibqzac-shiori-1.5.3
ls -la /nix/store/b7yqnyimvf6z7dpgcabnsn6x7vibqzac-shiori-1.5.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

shiori

Maintainer pings
cc @minijackson for testing.

Result of nixpkgs-review pr 183849 run on x86_64-linux 1

1 package built:

shiori

@onny Merged with failing tests, not good.
This version made it into 22.11, so we shipped a broken release, which was completely avoidable.
Backporting 2.5.4 to resolve this mess.

Oh I‘m sorry I missed that :( Thank you for reverting

Then you also missed that there was no revert, but an upgrade.


Purple background color in interactive mode with 'whiptail'

In some cases when using interactive mode with whiptail the background of the window is displayed in purple (maybe also other colors). This should be explicitly set to a less irritating color, for example blue.

The background color was set to blue.

Revised in version 1.22.4.


Several questions on your backbone implementation(BaseLSSFPN and FusionLSSFPN)

Hello BEVDepth authors, I have the following questions when looking at your backbone implementation:

It looks like the only major difference between FusionLSSFPN and BaseLSSFPN is how we get depth: BaseLSSFPN predicts depth from image features+camera calibration input, while FusionLSSFPN uses lidar gt depth, but instead of directly using it, it's further processed by depth_gt_conv -> depth_conv -> aspp -> depth_pred, https://github.com/Megvii-BaseDetection/BEVDepth/blob/d9d9639794539dcddbf3c1defd3d5f043d4a20e5/bevdepth/layers/backbones/fusion_lss_fpn.py#L64 what's the reason behind this? More generally, using lidar gt depth as input makes the model not camera-only anymore, so what's this backbone used for?
The paper mentions adding a SE-like layer for camera-aware depth prediction, but in BaseLSSFPN it's similarly added to image features as well, https://github.com/Megvii-BaseDetection/BEVDepth/blob/d9d9639794539dcddbf3c1defd3d5f043d4a20e5/bevdepth/layers/backbones/base_lss_fpn.py#L249 what's the benefit of making image features "camera-aware"? I guess it probably doesn't affect the result very much but still good to know if it does have some influence.
Could you elaborate more on the DepthAggregation module? It's not mentioned in the paper so I'd appreciate some reference on why adding this helps.

Look forward to your reply!
p.s. The "Delving into Depth Prediction in Lift-splat" analysis in your paper v2 is super interesting, thanks for making the update!

Hello, thanks for your attention.
For the first question, it is more like a experimental setting. We use fusion exps to see how much performance boost it can bring if we introduce lidar depth prior. It also proves that with little modification, BEVDepth can be transformed from camera-only model to fusion model.
For the second question, it doesn't bring much influence indeed. However, since context and depth will be multiplied in the future, it makes sense to add camera-aware for the context feature.
For the third question, The img_feat_with_depth is not robust enough, so we add some extra layers to further extract features.

S

Hi，have you solved this problem? If  I want to compare the method, which python file should I run? (In fusion? or In mv?)


ENUM - Dropdown list disappears in IE9+

This was originally issue #550.    I do believe it was fixed, but it appears to be broken again.  This may also be related to issue #562.
When using an ENUM Multi-Select component, in IE, whenever the dropdown list appears, and you go to use the scroll bar (when there are hundreds of entries, scrolling is not really an option), the window disappears, and yes it appears that the component does reset itself.

I have the same issue with IE9+ and w2ui-1.4.3.

@ghost please specify version you used. Did you try nightly from dist folder?

Still having on IE 11.
Resolved with this fix:

Removed helper.find('input').on('blur') on line 17188
Added this event to the helper after line 17208:
helper.on('blur', function (event) {               $(obj.el).css('outline', 'none');               $(this).find('input').val('');               obj.refresh();               $(obj.el).triggerHandler('blur');               if (event.stopPropagation) event.stopPropagation(); else event.cancelBubble = true;               if (pholder != null) $(obj.el).attr('placeholder', pholder);           });

@Dazorn96 can you create a fiddle to reproduce the problem?
I can not reproduce the problem(s) described in this issue by using http://w2ui.com/web/demos/#!fields/fields-4 or http://w2ui.com/web/demos/#!fields/fields-3 and IE11

@mpf82 i am using w2ui-1.5.rc1.js.
I have a list type field, containing 400 items. When i want to scroll (with the dialog scrollbar), the input seems to lose focus and the dialog disappear.

@Dazorn96 I already understood that much.
The examples I have linked are also using w2ui-1.5.rc1.js - and specifically this one also has a list field with a scrollbar.
I still can not reproduce the problem you're mentioning in my Win7 with IE11 using the linked example and following the steps you have described.
That's why I asked if you can create and link a jsfiddle to reproduce the problem.

@mpf82 That's my page code:
https://gist.github.com/Dazorn96/10de7fea5a5e12e83f65e39ecd99a40f

Any updates?

@Dazorn96 Nope, I stopped looking into it, since you did not provide a fiddle and I could not reproduce it with the existing demo. Btw, did you try to reproduce it in the demo?

Closing issue: no response, no reproducer


Bunny skips a step in the workflow

In a very simple workflow second step gets ignores, and the output of the first step is returned as a result of the entire workflow:
https://gitlab.com/unduthegun/cwl-test/tree/master/rabix-2-steps

rabix-2-steps/fails.cwl

Creates only root/touch folder
Logs "Job root.cat is completed."
Doesn't log "Running command line: cat"

rabix-2-steps/passes.cwl

Creates both folders and runs both commands

cwltest.zip

When the first step is over, OutputEventHandler triggers and looks for destination variables:
 List<VariableRecord> destinationVariables = variableService.find(link.getDestinationJobId(), link.getDestinationJobPort(), event.getContextId());
In the "fails.cwl" case, this query returns both the input and output type VariableRecord objects for the second step and triggers both InputUpdateEvent and the OutputUpdateEvent with the same value, effectivly skipping the step.


Auto restart and rebuild angular universal on save

I turned my application to angular universal. It's great but I have a problem with developing mode. I need to see my editing result real-time. I need to restart my app on each atrl+s (save) like build --watch and nodmeon.
My server is Eexpressjs and I'm using the command  "npm run build:ssr" after each edit. It takes lots of time!!
How can I do that?

Did you mean to post this under the universal-starter repo?  Those looks like they're the commands for that repo.
Here, dotnet run or start in VS gets this going and sets up live reload functionality.

Could you please help me more clear? I thought this command dotnet run is for ASP.net backend and Im using express. What is this: start in VS gets` ? I appreciated if you let me understand this by an example.
Thanks for respond.


UrlEncoded Body Serialization Aliasing

Based on the source from: https://github.com/paulcbetts/refit/blob/master/Refit/FormValueDictionary.cs it appears that aliasing is supported however many people, including myself, will have annotated our models with JSON.NET. Since you already have JSON.NET as a dependency why not also include JsonProperty reflection to support the aliasing feature on models that are only annotated with JSON.NET attributes.

You mean use the [JsonProperty(Name="Foo")] attribute values if present? We could I guess, but it seems a bit counterintuitive, as they're not being used for JSON.
It would cause problems in the (unlikely) case of someone using the same object to serialize to JSON and submit as a form but wanting different property aliases. I think that could be avoided by allowing the use of both and having [AliasAs("foo")] take precedence.
Thoughts @onovotny?

Well due to the lack of configuration there isn't much else I can do other than request for a fallback. Alternatively extracting the attributes into a separate netstandard1.0 assembly may be beneficial to consumers of the library. I could likely annotate these models if I didn't need to fully depend on the entire Refit project in doing so.


Throw an error for creating file failure

This fixes #1361 .

:( Ummm, I found a way to make it as two steps (Data.write followed by an attribute setting), so we can contain a Foundation error when writing to the disk cache.
I would close this and have another PR later.

I believe #1365 should solve it in a better way.


[Localization] Add missing localization const for 6 langauges

What

Add missing localization const for 6 languages

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3291178
How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Thanks for doing this update Jim! This is a step I missed in my documentation which I have now updated. Thank you for calling this out.


Patch for Lazy wrappers and Xcode 10/Swift 4.2

After updating to Xcode 10 and Swift 4.2, my app started crashing in InstanceWrapper::40, as the instance was nil. Spent a bunch of time trying to figure out what was going on, and below is the breakdown.
In Container::300, the if-check was passing and nil was being returned, which didn't seem right. I assume type checking was somehow changed in the latest version of the compiler, and Service is treated as an optional?
I split the check into two pieces, and everything seems to work as it should. I assume there must be an explanation as to why this is happening, and possibly a better way to patch this up, but I thought I'd post this in case someone else has the same issue.
Note that even the most basic sample from Delayed Injection fails, so it's definitely nothing specific to our app:
struct LazyCounter {
    let integer: Lazy<Int>

    func testPrint() {
        print("printing")
        print(integer.instance)
        print(integer.instance)
        print(integer.instance)
    }
}

let container = Container()

var value = 0;
container.register(Int.self) { _ in
    value += 1;
    print("creating Int")
    return value;
}

container.register(LazyCounter.self) { resolver in
    let lazyInt = resolver.resolve(Lazy<Int>.self)!
    return LazyCounter(integer: lazyInt)
}

let counter = container.resolve(LazyCounter.self)!
counter.testPrint()

Thanks for the PR @ilijapuaca! 👍 Sorry for taking this log to get to it.
I will close this in favor of #371, as it covers your changes and then some.


30 seconds of php code

Hi,
Your project has inspired me a lot to create the same thing in PHP.
So here I did https://github.com/appzcoder/30-seconds-of-php-code
Would you please add this project link to your repo?

Hey @sohelamin. The core team behind 30 seconds of code actively supports only projects that meet our code and explanation quality criteria. I will personally check your project and see if it's high quality enough to be endorsed in our README and website.
Another thing you should know is that the projects we support as a team need to have at least one of our team members added as a collaborator on Github. This is both a safeguard to make sure they don't die out over time and that their quality will remain high, as well as an opportunity for us to help maintain and curate the lists from the inside, so that your team doesn't need to spend that much time on the project if they can't.

Hi @Chalarangelo thanks for your attention. Please do check my project though I'm still adding the gems on it.
And let me know how can I get involved with you.
Thanks

Thanks a lot 👍


Css update

Pull Request
Related Issues

Fixes #157
Checklist

[x] I have tested the changes locally
[ ] Documentation has been updated (if necessary)
[x] Changes are backward-compatible

Screenshots (if applicable)

page before updates

Page after updates

for larger screens, you can increase the width of the component also decrease the width of the add tag button on large screens, it taking half of the width

I will consider the changes required but can you specify how much width you prefer for a large screen @VaibhavArora314 ?

Is this much width okay with you @VaibhavArora314 ?

Is this much width okay with you @VaibhavArora314 ?

Looks good just push the changes, I will merge this


perkeep-generated signer blobs are not importable in gnupg

Perkeep currently generates signer blobs like this:
-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBGAHnVgBCADerM1lth1pgduiuOOhu6vFxnt5PoZbH+PRB/iJflgmBrswryPr
5oyalJrv6k5mnbgHumz46OaZFW6oaOpO5xLHVvcNuPjJceyPV2IeSz5PLm1SAlge
gSgCWGpAdcNsj+FIdftd7d1/mL42S9DQ4xByrkTkY06mAnci8oy5mplNHGa6nnib
sm5iWPcGX6Rvz3YCkm/kdKyYhBzoBJFUh4r13LxCiF6aefHN1NXvJQsleAPjUsTl
aouhfumRpKnEol/tJJuys/LnCC+tkU1D6qiAI+ALnCzWKhbCgfbt2InimxEC3YQZ
MfoyWlkBlLxT9rDBf8rkXuF7qXNKiPA4w571ABEBAAE=
=4ilV
-----END PGP PUBLIC KEY BLOCK-----

These are not compatible with gpg (GnuPG) 2.2.19:
aviau@blueberry:~/git/perkeep$ gpg --import key
gpg: key 0x3080C81B0395EE39: new key but contains no user ID - skipped
gpg: Total number processed: 1
gpg:           w/o user IDs: 1

Or even with the golang stdlib's ReadArmoredKeyRing:
openpgp: invalid data: entity without any identities

The GnuPG team has stated that their implementation won't support importing keys without uids:

https://dev.gnupg.org/T4393#133689

We should stop generating such keys. The added benefit of making the blob smaller is not worth the incompatibility with other libraries and tools. I have ran into this issue while working on perkeepy.

Ah, this is a duplicate of https://github.com/perkeep/perkeep/issues/624


Fix off by one errors in descriptions

Resolves #538

I'm also okay with changing the configuration -+1 if it makes more sense

I didn't want to change how what people already have in their configs works. Maybe this can be done in major versions.


⚠ Pactify has degraded performance

In eebec0e, Pactify (https://www.pactify.fr/) experienced degraded performance:

HTTP code: 200
Response time: 1547 ms

Resolved: Pactify performance has improved in 08a3597 after 1 hour, 49 minutes.


Adding Tandem alarm records

WIP: Do not merge.

 <2> [uploader] [tandem] alarms

Wrong merge target. Replaced with #199


[BUG] Website using old Node.js version (v14.21.3)

Problem subject

[x] Bug

Description
The website seems to be using an old Node.js version (v14.21.3), which has been discontinued already.
Using Gitpod, the website seems to deploy fine on Node.js v18.16.0.
I believe we should update the Node.js version of the project immediately, to ensure compatibility, prevent vulnerabilities/bugs, as well as supporting new versions of multiple frameworks/packages.
Expected behavior/contents
Use Node.js 16.x or higher.
Actual behavior/contents
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Panquesito7, is a fix on this issue still pending, and if so, can I go ahead and create a PR?

Hi @Panquesito7, is a fix on this issue still pending, and if so, can I go ahead and create a PR?

Hey there! Sure, feel free to create a PR to fix this, although I'm not sure if this is still maintained anymore.


[Rendering] Skinned Mesh Rendering

I've hit a roadblock, Not entirely sure whats up but there's something I'm doing wrong in the implementation of this.
If anyone has experience with this I would greatly appreciate the assistance!

Seems like its working properly now :D


Annex should contain clauses not subsections?

@ronaldtse as you know, I dislike renaming elements, because it gets in the way of code reuse. Would rather we keep the subsections generic.

I think we need some more discussion about this -- there is a difference of an Annex vs Appendix in an ISO Standard (see ISO Directives Part 1 which contains both).
ISO Standards specifically require Annexes to contain clauses. This does make sense for any standard because it allows an annex clause to be actually referred to. That said, ISO Standards permit hanging paragraphs in Annexes which are not ideal.
Thoughts?

Rename:

clause/subsection to clause/clause
terms/terms to clause/terms
references/references to clause/references

I remain nervous about renaming subsections to clauses
Looking at standoc, you have StandrdHierarchicalSection/subsection, ClauseSection/subsection, AnnexSection/subsection
the fact that these are clauses rather than subsections in Iso standards is specific to ISO, it is not general to Standoc
Therefore I don't believe they should be renamed in ISOXML

Have changes all terms/terms to clause/terms, references/references to clause/references

Renamed all subsections to subclauses in all grammars.

Renaming all subclauses to clauses. Have added preface and bibliography containers.


Feat thunk 2

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to make scroll position not reset

When I have a modal with scrollview as children... And I change scroll position... when i reopen that modal, scroll position is reset to top position. how to make scroll position back as i last scroll...
Thank you

I am also in search for the answer of this query. Any suggestion would be highly appreciated.

Technically if you hid the modal it was taken off the stack. You would need to store the current scroll position outside of the Modal component and pass it back in upon re-render.

Hi!
I'm closing this issue because it's a question and not a bug report. Please don't take it personally, I'm just trying to make it easier to maintain this project by separating questions from bug reports 🙏.
If you're still looking for feedback/answers, could you please ask your question in a new discussion?
Thank you!


[REQUEST] Initialize Transfer with iv and cp

Expected Behavior
"initial_transfer": 100 and 0.7,
Actual Behavior
"initial_transfer": 100,
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Better solution is: Initial transfer should use the "release_config.json" rules !

@dmateusp maybe something for you?

@clavat agree (y)

I will give it a look :)


[ENH] Add resource monitor flag

Looks good. Want to bump the niworkflows version to 0.2.2? I think that's needed to get VMS stats from the profiler.

Yes, I was already working on that


Simple GUI

Create a new window that is a simpler version of EasyGec (just what P.E. teachers need to run it). Be able to toggle between this 'SimpleGec' and EasyGec.


[Refactor] Add Python API when creating an app through taipy create

Description
Add a question to know if the user wants to use the Python API or Markdown syntax for his application and change the template accordingly.
taipy create --template default
A question should appear to know if the user wants to use the Python API or Markdown syntax.
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
[ ] Ensure any change is well documented.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

I'll be looking into it


About tokenizing test-split captions on own dataset

In preprocess/tokenize_captions.py,
def load_annotations(coco_dir):
    with open(os.path.join(coco_dir, 'annotations', f'captions_train2014.json')) as f:
        annotations = json.load(f)['annotations']

    with open(os.path.join(coco_dir, 'annotations', f'captions_val2014.json')) as f:
        annotations.extend(json.load(f)['annotations'])

    return annotations

It seems that this code was not loading test2014. To avoid this problem, I would like you to modify this code into
def load_annotations(coco_dir):
    with open(os.path.join(coco_dir, 'annotations', f'captions_train2014.json')) as f:
        annotations = json.load(f)['annotations']

    with open(os.path.join(coco_dir, 'annotations', f'captions_val2014.json')) as f:
        annotations.extend(json.load(f)['annotations'])

    with open(os.path.join(coco_dir, 'annotations', f'captions_test2014.json')) as f:
        annotations.extend(json.load(f)['annotations'])

    return annotations

which took me 2 days to figure out this problem, before which hasn't I walked out of suspecting my dataset problem yet:C

This project uses Karpathy splits for train, validation and test splitting. Karpathy splits are defined over MS-COCO train and validation sets only, hence test2014 is not loaded. Why do you need MS-COCO test data?


Application crashes on click item in the sidebar

Description
Application crashed after I clicked on the item in the sidebar.
Steps To Reproduce
Normally there were no problems. The exact conditions for reproduction are not known. What I was doing:

Opened Files
Clicked on the 'Downloads' item in the sidebar
Files closed (Downloads did not open yet)

Expected behavior
Application does not crash.
Files Version
<IP_ADDRESS>
Windows Version
Windows 10 21H1 19043.1237
Relevant Assets
Application Error (Code: 1000) in Event Log:
Logged: 10/8/2021 02:22:16 PM (24H: 08.10.2021 14:22:16)
Faulting application name: Files.exe
Faulting module name: KERNELBASE.dll, version: 10.0.19041.1202
Exception code: 0x00001007
Fault offset: 0x000000000010be3e

debug.log slice in crash time interval:
2021-10-08 14:08:26.9413|INFO|IsRunningOnArm|Running on ARM: False

Here app crashed on 2021-10-08 14:22:16
2021-10-08 14:22:21.1114|INFO|OnLaunched|App launched. Prelaunch: False
2021-10-08 14:22:22.2470|INFO|GetDrivesAsync|Drive added: C:\, Fixed
2021-10-08 14:22:22.3288|INFO|GetDrivesAsync|Drive added: D:\, Fixed
2021-10-08 14:22:22.4854|INFO|GetDrivesAsync|Drive added: F:\, CDRom
2021-10-08 14:22:22.5213|WARN|GetDrivesAsync|Unauthorized: Attempting to add the device, G:\, failed at the StorageFolder initialization step. This device will be ignored.
2021-10-08 14:22:22.6744|INFO|DeviceAdded|Drive added: G:\, Removable
2021-10-08 14:22:33.3115|INFO|IsRunningOnArm|Running on ARM: False

debug_fulltrust.log slice in crash time interval:
2021-10-08 14:08:48.6002|INFO|Connection_RequestReceived|Argument: LoadContextMenu

Here app crashed on 2021-10-08 14:22:16
2021-10-08 14:22:21.8334|INFO|Connection_RequestReceived|Argument: DetectQuickLook
2021-10-08 14:22:22.3876|INFO|CheckQuickLookAvailability|QuickLook detected: False
2021-10-08 14:22:22.4574|INFO|Connection_RequestReceived|Argument: GetOneDriveAccounts
2021-10-08 14:22:22.4634|INFO|Connection_RequestReceived|Argument: GetSharePointSyncLocationsFromOneDrive
2021-10-08 14:22:22.4664|INFO|Connection_RequestReceived|Argument: NetworkDriveOperation
2021-10-08 14:22:22.4933|INFO|Connection_RequestReceived|Argument: GetSelectedIconsFromDLL
2021-10-08 14:22:22.6774|INFO|Connection_RequestReceived|Argument: GetSelectedIconsFromDLL
2021-10-08 14:22:22.9250|INFO|Connection_RequestReceived|Argument: ShellLibrary
2021-10-08 14:22:33.7641|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.8389|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.8469|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.8529|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.8609|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.9028|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:33.9476|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.0304|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.0494|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.1062|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.1222|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.1421|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.1511|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.5577|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.5697|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:34.7106|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:35.8381|INFO|Connection_RequestReceived|Argument: GetIconOverlay
2021-10-08 14:22:50.9548|INFO|Connection_RequestReceived|Argument: LaunchApp
2021-10-08 14:34:50.2183|INFO|Connection_RequestReceived|Argument: RecycleBin
2021-10-08 14:34:52.5247|INFO|Connection_RequestReceived|Argument: FileOperation

Is this still an issue in <IP_ADDRESS>?


Able to generate google-services.xml properly if Application Id is changed right before building.

Based on https://github.com/googlesamples/unity-jar-resolver/issues/365
The user request to be able to generate google-services.xml properly if they try to change application Id right before building.
Ex.
using UnityEditor;

public class Build
{
	[MenuItem("Tools/Build/Debug")]
	public static void BuildDebug()
	{
		PlayerSettings.productName = "debug";
		PlayerSettings.SetApplicationIdentifier(BuildTargetGroup.Android, "com.firebaseExample.debug");
		BuildPipeline.BuildPlayer(new[] { "Assets/Scenes/SampleScene.unity" }, "debug.apk", EditorUserBuildSettings.activeBuildTarget, BuildOptions.None);
	}

	[MenuItem("Tools/Build/Release")]
	public static void BuildRelease()
	{
		PlayerSettings.productName = "release";
		PlayerSettings.SetApplicationIdentifier(BuildTargetGroup.Android, "com.firebaseExample2.release");
		BuildPipeline.BuildPlayer(new[] { "Assets/Scenes/SampleScene.unity" }, "release.apk", EditorUserBuildSettings.activeBuildTarget, BuildOptions.None);
	}
}

Currently GenerateXmlFromGoogleServicesJson.cs (in Firebase.Editor.dll) relies on PlayServicesResolver.BundleIdChanged event to change google-services.xml when application id change.  However, the event only triggered in the next update from the main thread.
https://github.com/googlesamples/unity-jar-resolver/blob/825901fa297065d651709fdc34cc5433410c8869/source/AndroidResolver/src/PlayServicesResolver.cs#L1370
@master-lincoln came up with a workaround to utilize reflection to force trigger this event
Type type = Type.GetType("Firebase.Editor.GenerateXmlFromGoogleServicesJson, Firebase.Editor");
var method = type.GetMethod("OnBundleIdChanged", BindingFlags.Public | BindingFlags.NonPublic| BindingFlags.Static);
method.Invoke(null, new[] {
	(object)null,
	new PlayServicesResolver.BundleIdChangedEventArgs
	{
		BundleId = newAppId,
		PreviousBundleId = oldAppId
	}
});

However, there should be a better way to support such case.

I was changing Application Id from the build script and game-services.xml was not updated properly.
I think I fixed it and my current build looks like this:

Change Application Id (it MUST be done before step 4);
Copy corresponding google-services.json and GoogleService-Info.plist to the Assets folder.
Call AssetDatabase.Refresh(); (I am not sure if this is really needed);
Call GenerateXmlFromGoogleServicesJson.ForceJsonUpdate(false) to regenerate google-services.xml


[gh-11] Add RDS module

Close #11

What happened 👀
Integrate AWS RDS
Insight 📝

Using terraform-aws-modules/rds-aurora/aws module for integration
Using PostgreSQL engine
Adding security group for RDS module
Updating namespace to be hyphen style devops_ic -> devops-ic since the rds cluster doesn't accept dash character

Proof Of Work 📹
Security group created

RDS created

RDS cluster created

Does the environment variable value still contain the app name, ie devops-ic-staging ? Not sure we need app name here if it's in namespace ?

No, I just forgot to update the screenshots, I guess it's all good now


wip: Introduce the concept of a validation intent

This commit adds a new flag to the ec validate command, --intent which is propagated to rego as config value - similarly to how effectiveTime is propagated.
The idea is to provide a mechanism to change the behavior of a policy rule depending on why the user is validating an image.
For example, the
schedule package contains policy rules that are meant to enforce restrictions depending on the day. This is meant to disallow releases on the weekends or on certain days (holidays).
Those policy rules are NOT meant to disallow changes from being merged.
This allows the user to use the same policy config for multiple purposes.
Ok, so why not just have multiple policy configs?
This is certainly a possibility! It does come with its own challenges:

Deviation in what is checked during integration vs release is prone to cause unexpected issues at release time.
Maintenance. Duplicating every policy config sounds like a good way to increase toil for everyone.

The "intent" appraoch does away with the maintenance cost for users, at the expense of making certain policy rules slightly more complex. (I think that's a good trade-off.)
But it only reduces the deviation problem. You'd still get a different result in integration than in release. But... that's what the requested feature is all about so not sure if we can do much about that. This approach does use the same policy config in both cases so at least it removes issues caused by those not being in sync.
Anyways, this is a proof of concept meant to help the conversation.

You can try this out by building EC from this PR and using this policy config:
---
publicKey: |
  -----BEGIN PUBLIC KEY-----
  MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEZP/0htjhVt2y0ohjgtIIgICOtQtA
  naYJRuLprwIv6FDhZ5yFjYUEtsmoNcW7rx2KM6FOXGsCX3BNc7qhHELT+g==
  -----END PUBLIC KEY-----
sources:
  - policy:
      # - /home/lucarval/src/enterprise-contract/ec-policies/policy/lib
      # - /home/lucarval/src/enterprise-contract/ec-policies/policy/release
      - github.com/lcarva/ec-policies//policy/lib?ref=intent-poc
      - github.com/lcarva/ec-policies//policy/release?ref=intent-poc
    ruleData:
      disallowed_weekdays:
        - Sunday
        - Monday
        - Tuesday
        - Wednesday
        - Thursday
        - Friday
        - Saturday
    config:
      include:
        - schedule

# This should work
ec validate image --image quay.io/redhat-appstudio/ec-golden-image:latest --ignore-rekor --policy policy.yaml

# So should this
ec validate image --image quay.io/redhat-appstudio/ec-golden-image:latest --ignore-rekor --policy policy.yaml

# But not this
ec validate image --image quay.io/redhat-appstudio/ec-golden-image:latest --ignore-rekor --policy policy.yaml --intent release

Perhaps we could benefit from having this as a generic mechanism. I'm thinking intent could be one kind of pivot for the rules and there might be other kinds as well. First thought for me was to include the notion of a profile and that the sources within the policy configuration could say they belong to a profile (by default all profiles).
Example:
$ ec validate image --profile release ...

That would include schedule.weekday_restriction via configuration like:
sources:
  - name: Release profile
    policy:
      - github.com/enterprise-contract/ec-policies//policy/lib
      - github.com/enterprise-contract/ec-policies//policy/release
    data:
      - oci::quay.io/redhat-appstudio-tekton-catalog/data-acceptable-bundles:latest
      - github.com/release-engineering/rhtap-ec-policy//data
    profile: release
	include:
      - schedule
  - name: Default
    policy:
      - github.com/enterprise-contract/ec-policies//policy/lib
      - github.com/enterprise-contract/ec-policies//policy/release
    data:
      - oci::quay.io/redhat-appstudio-tekton-catalog/data-acceptable-bundles:latest
      - github.com/release-engineering/rhtap-ec-policy//data
	exclude:
      - schedule

Profiles are an interesting idea. They would get applied for each source group. We don't have to run the schedule rules as a separate source group, but we sure can!
I like that this requires no changes to the policy themselves, so it's a little bit more flexible IMO.
I think the additional source group in the policy config is not too bad. It does duplicate the policy/data sources but I think that's ok. And if ruleData is used, that doesn't have to be duplicated because it's not relevant to the release source group, presumably.

Re the idea of command line influence on the policies, we could make it more even more generic - I'm thinking about the way that ansible-playbook supports -e/--extra-var. Then we could do ec ... -e intent=release for example and it would set data.rule_data.intent or maybe just data.intent to "release" so it's visible to rego rules.

Re the idea of command line influence on the policies, we could make it more even more generic - I'm thinking about the way that ansible-playbook supports -e/--extra-var. Then we could do ec ... -e intent=release for example and it would set data.rule_data.intent or maybe just data.intent to "release" so it's visible to rego rules.

Really like this idea, or some variation of it. We just have to make sure those passed in values are displayed properly in the report to avoid ambiguity on what was used to validate.

I'm gonna close this out as we don't want to merge this as is. I think this poc has served its purpose, which was to kick off the conversation. thanks all.


add a test to link libc++ as static (fails for now)

I'm surprised you don't need to force -stdlib=libc++

@sylvestre test updated and fixed, LGTM now if it it looks good to you


Update scalafmt-core to 3.2.1

Updates org.scalameta:scalafmt-core from 3.1.2 to 3.2.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.1.2).
You might want to review and update them manually.
docs/website/package-lock.json

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains

Codecov Report

Merging #588 (bc1dcf2) into release/next (d27b10b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release/next     #588   +/-   ##
=============================================
  Coverage         58.52%   58.52%
=============================================
  Files                60       60
  Lines              1379     1379
  Branches             54       54
=============================================
  Hits                807      807
  Misses              572      572

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27b10b...bc1dcf2. Read the comment docs.


Component: Header / NavBar

How do I toggle mobile navbar vs the desktop navbar?

@TeddTech you'll likely be using media queries. However, at this point are you just working on the markup structure, or also adding the CSS and JS? @greatislander any thoughts?

@TeddTech Yes, as per @jobara's comment, this PR should only add the markup. CSS and interactivity will be added later.

I have been making separate components for the mobile display. So 2 components for each issue. One for desktop and one for mobile. Is this approach correct? or should I take a different one?

There should be one component that adjusts itself for mobile or desktop as necessary. See: https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Responsive_Design
There will likely be some JavaScript requirements for some of these as well. But each item should be a single component.

Let's discuss this afternoon @TeddTech.

Okay so for now, should my PR just contain the desktop version then?

Yes.


Feature request for Battery input power

Can you please add the following feature or guide me in the direction of coding it myself?
Request: Input/Battery minimum voltage cutout
Reason: Protect cordless tool battery as input power source from dropping below minimum safe voltage to prevent battery damage (Dewalt and Milwaukee batteries rely on the tool for low voltage cutout protection—Ryobi batteries have protection built into the battery)
Specifics: I haven’t done any programming in 30 years so I am more than a bit rusty. I would like to accomplish the following:

add a menu input and variable for “Battery Cutout Voltage” or maybe “input voltage cutout” default=zero
create battery / input voltage protection BVP function with the following basic logic
If v_in_adc <= battery_cutout_voltage
Set v_out and i_out = zero (handle_bvp?)
Display on screen BVP activated at input voltage = battery_cutout_voltage
Check for BVP just like checking for OVP or OCP

Thanks in advance,
Bob

Sorry, this project is abandoned on my part. There was some activity in #249 in November last year so someone might still be developing for it.

I like the idea of having a low voltage cutoff for battery input support.
I will try to add this to my own TODO list, as a fork of this project.


Test-DbaConnection address passing Credential parameter properly

Type of Change

[x] Bug fix (non-breaking change, fixes #5929 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

This command included a call to Invoke-ManagedComputerCommand but was passing a $Credential variable that the command never accepted as a parameter. So I updated the command to now accept that object.
In turn this fixes an issue Test-DbaConnection has because we were not passing in the actual Credential to Get-DbaTcpPort. I updated that call to now pass the Credential properly.

looks great! that was a big ol overlook.


[Feature Request] Add Color bar to the new window level action icon

What feature or change would you like to see made?
The new color bar in the cornerstone3D is a great tool that we should add to the OHIF. It should be abled to get toggled on and off, and should react to the preset changes (it does by design but we should make sure it works as well with other interactions in the color bar)

https://www.cornerstonejs.org/live-examples/colorbar
https://www.cornerstonejs.org/live-examples/advancedcolorbar

Why should we prioritize this feature?

@IbrahimCSAE confirm with @dan-rukas about spacing


Extract validation module from file module

Closes #37.
Also makes lib/file non-executable.

Coverage increased (+0.006%) to 94.67% when pulling fe4dc71ae889d0b5c230ae2dadff206bf688466e on validation into 9a2f85fadfe498b2a8b0a5df78b20f016002661a on master.


Cant download gdx-video-desktop-natives.jar

Hello, i tried the maven build but i can't download the gdx-video-desktop-natives.jar
I can't find it in any of my repos including the one mentioned in read.me
Could you help?

Currently the libgdx build server is not fully configured for ffmpeg yet. Unfortunately, the natives are not available until this is done.
At the moment you'll have to manually build the natives to use gdx-video.
I'll leave this issue open until the build server is working.

Hello thanx for your fast answer!
I tried but i don't know how to launch the compile "com.badlogicgames.gdxvideo:gdx-video-platform:0.0.1:natives-desktop" command
I tried using groovy but there is no such command as compile.
Could you explain how to run the build or for the sake of simplicity send me the compiled jar?
Thanx alot anyway!

I tried to compile \gdx-video\gdx-video-desktop\jni\build.xml with ant but the error states:
.....\gdx-video\gdx-video-desktop\jni\build.xml:20: .....\extensions\gdx-video\gdx-video-desktop\libs\linux32 does not exist.
are you sure you committed everything to git?

I just checked, and it works perfectly here. I cd into the gdx-video-desktop/jni folder and run ant. It compiled for a while, and results in a jar with compiled libs.
Are you building on windows? If this is the case, you may have to change the compilers in the ant files. They are targeted meant for building from linux.
Anyway,  for your convenience, you can find the compiled libs here (built locally on my linux install): http://we.tl/TkUIk5u7n5

Yes im running win7.
Thanx for the download link - saved me a lot of time!

Hi. I have the same issue with build natives as marekhalmo.
Could you please share builded libs while this extension is pending state?
Thanks.

Sorry, I didn't know the wetransfer link would go down so soon.
Anyway, you can find it here (Hopefully more permanent this time...)

Any tips for building on OSX?

I'll update the natives file with macos later today. I've recently got access to a mac. I haven't figured out how to compile ffmpeg for older macosx, so it requires the latest osx currently.
If you want to compile it yourself, have a look at https://github.com/intrigus/gdx-video. I've been discussing with intrigus how to fix the mac build as well. It's a WIP.

The native libraries are updated with the osx libs included. I wasn't able to test them though (I didn't have access to a gdx-video project on that machine, and didn't have time to set one up). I hope it works!

The native libraries... Is that what should download with a properly configured gradle.build file?  Or one of the formerly posted download links?

It's the formerly mentioned URL. The build server is unfortunately still a
work in progress. As it turns out, ffmpeg is quite complicated to build,
and the buildserver is having issues with this. Using Travis is also still
a WIP because of the osx support.

Hello, I have been getting nothing every time I try to generate the .jar files.
I think the error is mine....  Robbiedobbie, would you share with me the .jar file for Linux, Android, Windows and Mac as possible as you can?
Thanks....

Is there an fix planned?

It's been a long time because of time shortage off all people involved. Eventually it will arrive, but not short term. It involves a complicated setup and multiple people.

I'm trying to use this library for my libgdx project and I think it works fine with the compiled library but I get the error "com.badlogic.gdx.backends.lwjgl3.audio.OpenALAudio cannot be cast to com.badlogic.gdx.backends.lwjgl.audio.OpenALAudio" because I'm using lwjgl3 and RawMusic uses lwjgl, could you please send me the compiled library for lwjgl3? because I tried to built it and i get java.lang.NoClassDefFoundError when I try to use it

Since 8cf9ab7995342ffc5fc3153129e53f2ff45afbda natives are included in the gdx-video-desktop artifact

Can gdx-video-desktop.jar be downloaded somewhere (I have an old version but am wondering if there is something newer)? I am not using Gradle, in case it is included there. Would be great to have it also in the "extensions" folder in the nightlies.

Can gdx-video-desktop.jar be downloaded somewhere (I have an old version but am wondering if there is something newer)? I am not using Gradle, in case it is included there. Would be great to have it also in the "extensions" folder in the nightlies.

You can click on the snapshot badge and download the jar from sonatype manually

You can click on the snapshot badge and download the jar from sonatype manually

You can click on the snapshot badge and download the jar from sonatype manually

Sorry I am unable to locate such a badge on github. By looking around a bit I found this link: https://oss.sonatype.org/content/repositories/snapshots, however, it leads to "Directory listing forbidden". Does it require Maven?

You can click on the snapshot badge and download the jar from sonatype manually

Sorry I am unable to locate such a badge on github. By looking around a bit I found this link: https://oss.sonatype.org/content/repositories/snapshots, however, it leads to "Directory listing forbidden". Does it require Maven?

https://oss.sonatype.org/content/repositories/snapshots/com/badlogicgames/

https://oss.sonatype.org/content/repositories/snapshots/com/badlogicgames/


Add example that demonstrates save/load between program being closed and then reopened

This would be helpful to see in action as it is a very common usecase and I don't think any of the examples here do so.

All of the examples allow you to create a save, close the game, re-open the game, and then load the save you had made previously. If you are having trouble reproducing this behavior then you have encountered a bug.
Note that as of 0.8 the examples are the "best case scenario" where entity IDs don't clash.
It is possible to do this in a real game but in all likelyhood you will need to use the other tools exposed by the crate eg Builder and Snapshot manually to achieve the results you want. While that isn't ideal, it still affords you significantly more flexibility than what you get out of the box.
My end goal is to make it so that you can use the simple World::save() and World::load() interface while also having the ability to deal with entity mapping / handle mapping / asset mapping / etc transparently. Unfortunately I have not found a way to make that work yet - of course suggestions are welcome.

i tried reloading in breakout but i got a crash
thread 'Compute Task Pool (3)' panicked at 'called `Result::unwrap()` on an `Err` value: MultipleEntities("bevy_ecs::query::state::QueryState<&mut bevy_transform::components::transform::Transform, bevy_ecs::query::filter::With<breakout::Paddle>>")', examples\breakout.rs:383:38

This issue was introduced by startup systems being automatically reordered in Bevy 0.10.1.
The order of startup systems affects what Entity IDs are being given out.
With the default configuration of bevy_save, this matters and if there is a mismatch there can be duplicate entities.
In this case, it caused a crash.
Related: #10
Closed as completed via #016c36.


TileMaps Broken in Safari (Phaser 2.2.0/1)

TileMaps are very broken in Safari, and it seems to be due to 1 line of code which, if I comment it out, makes everything work fine. I'd create a PR but I do not know exactly how this particular rendering flag is used:
The line is here:
https://github.com/photonstorm/phaser/blob/master/src/tilemap/TilemapLayer.js#L677
In method: Phaser.TilemapLayer.prototype.shiftCanvas
context.globalCompositeOperation = 'copy';

Example:
http://jsfiddle.net/zq8hn23g/6/
This works fine in all browsers except Safari. If you run the example, then click and drag on the canvas, you'll see the tilemap flicker in and out of visibility.
Please let me know if you need any more info.

Hmm I've merged in the latest PR but I now see the following happen in all tilemap examples:
map screengrab
Maybe something didn't merge correctly? This happens in Chrome, FF, etc.

enableScrollDelta = true fixes that in Safari and Chrome

If that's the case it probably needs to be the default setting. Which I'm assuming will bork the optimisation it introduced.

Actually I've just checked and enableScrollDelta is already enabled by default and it still happens in Chrome (on Windows, not tested OS X yet).

Setting it to false fixes the issue. The property was there and set to true as default in 2.2.1 though and didn't exhibit this issue, so it's a regression most likely from the Safari double-copy fix.

@photonstorm Does layer.renderSettings.copyCanvas contain a DOM canvas element?

@photonstorm That is bad - it is caused because the previous area is not cleared, and it "smells" like something got merged bonkers. I'll take a look at it when I get home tonight.
Since it is Chrome on windows, that should be using the "direct" method. Looking at theLayer.renderSettings.copyCanvas will be undefined if it is a direct bitblt.

Yes copyCanvas is undefined, so it's definitely using the bitblt code path. Even so, in Chrome it appears as in the screen shot posted above.
Adding game.device.canvasBitBltShift = false; before creating the layer fixes it. It happens in Canary (41.0.22650.0) and Chrome (39.0.2171.95) both on Windows.

Was going to close this off, as the PR was merged into 2.2.2, but it didn't actually fix it!
Someone on the forum reported that the Examples were still broken in Safari. I checked them out and they're better than before, but still don't work properly. In some of them the map will scroll horizontally perfectly, but as soon as you scroll vertically you get a big black area at the bottom. This is easy to see in the 'csv test' one. The 'raycast' one works fine as its all horizontal.
In SciFly strangely it screws up as soon as you scroll down, but then scrolling to the right brings the display back a little. Performance is shocking though, so not sure what's up there!

Arg grumble grumble.
I've broken down and am getting an "iDevice" this week.
I should be able to resolve the issues in Safari then.
The scrolling-in-one-direction issue sounds like yet another oddity/incompatibility and I can only go "sigh" wrt the performance.

The scrolling-one-direction blackness was in Safari on OS X, so yeah desktop.


Adding more info to ActivityUploader and handling errors

I was trying to upload a tcx.gz file to Strava, but was hitting timeout issues when waiting for the activity to finish processing. However, the initial request actually failed with a 400. This wasn't captured by upload_activity because Strava returned a JSON payload in the format:
{u'errors': [{u'code': u'invalid encoding',
              u'field': u'gzip',
              u'resource': u'upload'}],
 u'message': u'Bad Request',
 }

Both errors and message aren't in the API documentation. Because errors, and not error was returned, upload_activity did not raise an exception.
I also am saving that response info in ActivityUploader instances. This allows a consumer to inspect all of the data returned by Strava.

Ok, these changes look fine to merge, though it wasn't clear form this diff if Client.raise_for_error() would correctly handle a case where there were multiple errors (i.e. it's a list).

@hozn Looking at the code in protocol.py, I don't know why _handle_protocol_error didn't catch this. We should have expected Fault to get thrown, but it never was.

@hozn let me know if you have any more feedback!

@bwalks , sorry, the day job has been crazy.  If you're happy with this code right now, I can merge and we can revisit handling of these errors.  Though it seems like there's a little more work needed there to do this more comprehensively?

@hozn Completely understand. I am happy with it for the time being, and can create an issue to translate the dict to a better error message.


Splunk: extend test coverage by TLS

This is follow-up issue for https://github.com/apache/camel-quarkus/issues/4085
See comment for more information.

I tried to run the splunk https tests by following https://docs.splunk.com/Documentation/Splunk/9.2.0/Security/ConfigTLSCertsS2S
The first task is to configure splunk server to SSL. It is possible by provide necessary config parameters and by restarting afterwards. The config parameter might by added to the configuration file by copying (overwriting following file - /opt/splunk/etc/system/local/server.conf)) (see my POC)
There are several options. (You can validate the the certificates by running openssl s_client -connect localhost:32880 or openssl s_client -connect localhost:32880 -CAfile cacert.pem)
• If certificates are kept as default -> splunk server generates the certificates during the start.
• You can use keytool approach (similar to cxf tests) to generate certificates. Server pem has to be concatenated from private key and certificate. The proper method is to run following commands (but the same result should be also achieved when key and crt files are concatenated (I didn't verify that)
openssl pkcs12 -export -out combined.p12 -inkey localhost-key.pem -in localhost.pem -certfile splunkca.pem
openssl pkcs12 -in combined.p12 -out combined.pem -nodes

• You can generate certificates via annotations -> but in this case, I encountered a problem with self-signed certificate, therefore I left that way.
According to openSsl verification both optoins (1 and 2) shows that server responds with a proper certificate.

The second part of the job is to configure splunk client properly for ssh. The splunk component lacks ssl configuration options (I reported the issue as https://issues.apache.org/jira/browse/CAMEL-20393).
Unfortunately there is no clear way of fixing the issue. The underlying splunk client (..servicemix.bundles.splunk.1.9.5_1 creates sslContext statically from javax.next.sslSSLContext.getInstance("TLS"); with no option to create a custom ssl context.
In my investigation, I was setting the default sslContext during the start of the tests (which is not a nice solution, but should help with the investigation) I tried several different approaches (see my POC)
All my attempts failed on handshake_failure, with no information, what might be wrong. (openSsl client works successfully, so I expect an error in configuration of splunk client and its ssl.
(in the logs from -Djavax.net.debug=sll,handshake,trustmanager I noticed that the client might not contain any common encryption -> but the problem should show a different failure reason)

I'm keeping my POC in the branch https://github.com/JiriOndrusek/camel-quarkus/tree/splunk-ssh-POC
• I copied the TestResource from the specialized module into the project (for easier modification)
• I copied several files from the container, to be able to verify them (see i.e. https://github.com/JiriOndrusek/camel-quarkus/blob/splunk-ssh-POC/integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/SplunkTestResource.java#L126)
• I added several hours wait to the tests (see https://github.com/JiriOndrusek/camel-quarkus/blob/splunk-ssh-POC/integration-tests/splunk/src/test/java/org/apache/camel/quarkus/component/splunk/it/AbstractSplunkTest.java#L53) so I can start the splunk from cmd by running the test and then I can run another test without the server (with hardcoded ports from the log of the first test) (this approach saves a lot of time, because the splunk server starts several minutes)


old testament support

This change is

src/components/files-header/FilesHeader.js, line 42 at r1 (raw file):
Previously, RoyalSix (Sterling (Jay) Scott) wrote…
You might need to include sourceFile.html_url in this array here.

For some reason the linter isn't notifying me of the necessary variables like it use to.

src/components/files-header/FilesHeader.js, line 42 at r1 (raw file):
Previously, klappy (Christopher Klapp) wrote…
For some reason the linter isn't notifying me of the necessary variables like it use to.

Ah, you can place the specific attribute of an object or the parent object itself in here. I put the parent object. I'll update it with the more specific attribute.

src/components/files-header/FilesHeader.js, line 42 at r1 (raw file):
Previously, klappy (Christopher Klapp) wrote…
Ah, you can place the specific attribute of an object or the parent object itself in here. I put the parent object. I'll update it with the more specific attribute.

Done.

src/components/translatable/RowHeader.js, line 40 at r1 (raw file):
Previously, RoyalSix (Sterling (Jay) Scott) wrote…
Does this also need to change on reference.bookId

Done.

src/core/bcv.js, line 9 at r1 (raw file):
Previously, RoyalSix (Sterling (Jay) Scott) wrote…
Might want to add a try catch here

Instead of a try/catch I checked for what would cause it to fail.

src/core/bcv.js, line 9 at r1 (raw file):
Previously, klappy (Christopher Klapp) wrote…
Instead of a try/catch I checked for what would cause it to fail.

Done.

src/core/bcv.js, line 28 at r1 (raw file):
Previously, RoyalSix (Sterling (Jay) Scott) wrote…
Might want to add a try catch here

Instead of a try/catch I checked for what would cause it to fail.

src/core/bcv.js, line 28 at r1 (raw file):
Previously, klappy (Christopher Klapp) wrote…
Instead of a try/catch I checked for what would cause it to fail.

That is in the chaptersInBook should always return an array even if empty which this will return undefined if the bookId or chapter does not exist.

src/core/bcv.js, line 28 at r1 (raw file):
Previously, klappy (Christopher Klapp) wrote…
That is in the chaptersInBook should always return an array even if empty which this will return undefined if the bookId or chapter does not exist.

Done.


fix(paramserver): validates yaml or json data

Description
Validates the JSON or YAML data if the file is not uploaded as a blob before invoking the create_file API.

:tada: This PR is included in version 1.15.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Are lines 305-313 formatted correctly in core.py?

Question
It seems to not be formatted correctly, was wondering if this needs to be changed.

Short answer: no, they are not.
Longer answer: The docstring for PhysicsModule that you are talking about is a really just a barebones documentation placeholder. It should definitely be changed, to better conform to the style of documentation that we are trying to write.

Please open an issue for the PhysicsModule class docstring. Then close this issue.


Restrict nil media characteristic option selection

Nil AVMediaSelectionOption should not be selected because .loaded state for item.asset.statusOfValue(forKey: "availableMediaCharacteristicsWithMediaSelectionOptions") fired before item.asset.loadValuesAsynchronously(forKeys:completionHandler:) completion handler
@aol-public/mobile-sdk-team: Ready for review.
JIRA Issue

Fixed in https://github.com/aol-public/OneMobileSDK-videorenderer-ios/pull/59


I am not seeing the image upload section

Hi,
This is one of the nicest plugins which I have ever used, just I am facing a small issue, when I go to profile, I am unable to upload my image as I am not seeing the image upload input.
plz guide me...
thanks a lot in advance

This is a very old project which I unfortunately have no time to maintain but feel free to send PRs and I will merge them


Typedoc 0.24.x gives TypeError [ERR_INVALID_ARG_TYPE]

Search terms
ERR_INVALID_ARG_TYPE
NodeError
ReflectionSymbolId
Expected Behavior
Be able to create simple project using typedoc API without error.
Actual Behavior
Using version 0.23.28 project runs fine, but gives the following exception with 0.24.x:
TypeError [ERR_INVALID_ARG_TYPE]: The "from" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:120:11)
    at relative (node:path:497:5)
    at ReflectionSymbolId.toObject (C:\Users\alfie\tmp\typedoc-test\node_modules\.pnpm\typedoc@0.24.7_typescript@5.0.4\node_modules\typedoc\dist\lib\models\reflections\ReflectionSymbolId.js:49:66)
    at C:\Users\alfie\tmp\typedoc-test\node_modules\.pnpm\typedoc@0.24.7_typescript@5.0.4\node_modules\typedoc\dist\lib\models\reflections\project.js:214:35
    at Map.forEach (<anonymous>)
    at ProjectReflection.toObject (C:\Users\alfie\tmp\typedoc-test\node_modules\.pnpm\typedoc@0.24.7_typescript@5.0.4\node_modules\typedoc\dist\lib\models\reflections\project.js:213:40)
    at Serializer.toObject (C:\Users\alfie\tmp\typedoc-test\node_modules\.pnpm\typedoc@0.24.7_typescript@5.0.4\node_modules\typedoc\dist\lib\serialization\serializer.js:21:69)
    at file:///C:/Users/alfie/tmp/typedoc-test/typedoc-verify.mjs:25:24
    at ModuleJob.run (node:internal/modules/esm/module_job:197:25) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Steps to reproduce the bug
See https://github.com/jugglingcats/typedoc-test for basic reproduction. Here is the node script that uses the typedoc API:
import {Application, TSConfigReader, TypeDocReader} from "typedoc"

const app = new Application()
app.options.addReader(new TypeDocReader())
app.options.addReader(new TSConfigReader())

app.bootstrap({
    entryPoints: ["./test.ts"],
    tsconfig: "./tsconfig.json",
    skipErrorChecking: true
})

try {
    const project = app.convert()

    if (project) {
        app.serializer.toObject(project)
    } else {
        console.log("No typedoc generated!")
    }
} catch (error) {
    throw error
}

And the input Typescript file:
/**
 * This is a foo.
 */
export const FOO = "bar"

And the tsconfig.json:
{
    "compilerOptions": {
        "noEmit": true,
    },
    "files": [
        "./test.ts"
    ]
}

Environment

Typedoc version: 0.24.0
TypeScript version: 5.0.4
Node.js version: v16.14.2
OS: Windows 11

Should have added that I checked the breaking changes for 0.24.0 but couldn't see anything immediately relevant. Thanks.

skipErrorChecking: true

Does it crash with this turned off? Crashes with it on are out of scope.

Also... pay attention to types! They're important. app.convert() is async as of like 0.22 iirc

skipErrorChecking: true

Does it crash with this turned off? Crashes with it on are out of scope.

Yes it's on, thanks

Also... pay attention to types! They're important. app.convert() is async as of like 0.22 iirc

@Gerrit0 sorry I don't understand the first bit of your message. And app.convert() does not appear to be async...
    const project = app.convert()
    console.log("project=", project)

gives:
$ node typedoc-verify.mjs
project= <ref *1> ProjectReflection {
  flags: ReflectionFlags(0) [ flags: 0 ],
  id: 0,
  parent: undefined,
  name: 'typedoc-test',
  kind: 1,
  variant: 'project',
  symbolToReflectionIdMap: StableKeyMap {
  ...

The problem appears to be in app.serializer.toObject call.

Oops, sorry, looks like I was mixing up a beta branch... I didn't notice that you were using toObject. toObject is intended for serializing children of projects, you want projectToObject instead.
// @ts-check
import { Application, TSConfigReader, TypeDocReader } from "typedoc";

const app = new Application();
app.options.addReader(new TypeDocReader());
app.options.addReader(new TSConfigReader());

app.bootstrap({
  entryPoints: ["./test.ts"],
  tsconfig: "./tsconfig.json",
  skipErrorChecking: true,
});

try {
  const project = app.convert();

  if (project) {
    app.serializer.projectToObject(project, process.cwd());
  } else {
    console.log("No typedoc generated!");
  }
} catch (error) {
  throw error;
}

Thanks @Gerrit0, it's working.


ci: test on Node.js latest

Pull Request Test Coverage Report for Build 169932567

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.0%

Totals

Change from base Build 169874639:
0.0%

Covered Lines:
9

Relevant Lines:
10

💛  - Coveralls


Updates for the hosting pages

I'm adding the notes here from the screen sharing session with Rene and Shreya. These are seem the most useful things to make it easier to update the hosting data.

[x] list the user that belongs to this hosting organisation on the same page, and link to them
[ ] allow comments on the hosting provider page - so we know when they've been updated, or need someone to verify the data
[ ] list when requests to addition IP ranges or ASN were made, and approved
[ ] think how to show data about the ASN on the hosting page (perhaps peering DB) see #74
[ ] add editable preview for contacting hosting provider

Further notes, and requests for updates:

it would be extremely helpful if we had a tickbox where we could say 'checked' or something like that, to show that the entry was checked and still valid. We could use that date and time for selections later, like generate a page where the eldest entries / the ones that went unchecked for the longest time, are shown first.


File browser too wide on iOS/iPhone

Not sure if it's easily fixable, but on iOS 9.2 on my iPhone 5c the file browser http://v4-alpha.getbootstrap.com/components/forms/#file-browser is wider than the viewport.

well the .file input selector got a min-width of 14rem here: https://github.com/twbs/bootstrap/blob/v4-dev/scss/_custom-forms.scss#L182

Got this covered (seems an easy one), bear with me while I figure out PR.

Here: https://github.com/twbs/bootstrap/pull/18716

:+1:

Closed by #18716


Uncaught aggregator error when submitting a bundle with invalid contract address

Steps to Reproduce
Construct a bundle where one of the actions has a contractAddress of 0x.
const bundle = wallet.sign({
    nonce: await wallet.Nonce(),
    actions: [{
      ethValue: ethers.utils.parseEther("1"),
      contractAddress: "0x",
      encodedFunction: "0x",
    }],
  });

Then submit the bundle to an aggregator
Expected Result

Aggregator rejects the bundle for being invalid (HTTP 400) or
Aggregator fails bundle and does not include it

Actual result
Aggregator crashes due to uncaught exception. This persists between restarts

Severity
A malicious or unknowing user could DoS an aggregator instance(s)

Hey @jacque006 can you assign this to me ?

@thearyanag done, let us know if you have any questions or need help working on this. Thanks for picking it up!

@thearyanag done, let us know if you have any questions or need help working on this. Thanks for picking it up!

Sure, thanks for the support!

@jacque006 hey , can you please specify exactly how can I reproduce it. I tried but not clear.

@thearyanag we have a discord server for web3well at https://discord.gg/hGDmAhcRyz , easiest way to get in touch. Can ping me there or in a DM @jacque006#2825

High level overview: https://github.com/web3well/bls-wallet/blob/main/docs/system_overview.md
Local repo/project setup instructions: https://github.com/web3well/bls-wallet/blob/main/docs/local_development.md
Example of how to send a transaction: https://github.com/web3well/bls-wallet/blob/main/docs/use_bls_wallet_clients.md#send-a-transaction
Main thing to reproduce is setting contractAddress: "0x" in an action and submitting to an aggregator. The fix will likely be in aggregator code or in client.

@thearyanag Did you still want to work on this? We are spinning down active work on this project. If not, I will close.


line class

We use the concept of 'line' everywhere but often it is only used with Vector2 pairs which can be confusing.
We could also perhaps looking into making a polygon type- class which consists of multiple line segments.

This is being fixed in roboteam utils.


Add MySQL service to travis.yml

Recently MySQL isn't started by default in Travis and needs to be specified manually.

Coverage remained the same at 97.177% when pulling 743437135b531560d4b6bb4cf25732b798e8893e on jure:patch-2 into 543d879394106ad3741e872d9c4ac6e940114a4c on Vincit:master.

Yeah, this was definitely it, MySQL isn't started by default anymore on Travis.
Node 8 and 9 are failing with an interesting single MySQL failure:
  3654 passing (3m)
  11 pending
  1 failing
  1) integration tests
       mysql
         GraphInsert tests
           many to many relation
             should insert an object using #ref
               should insert an object using #ref:
      AssertionError: expected 1000011 to equal 1000010
      + expected - actual
      -1000011
      +1000010

Otherwise, this seems good to go.

Thank you!


[BUG] torchtext for cuda 11.8 getting pulled while installing for cuda 12.2

Initial issue was observed on torchtext. In further investigation it is found that incorrect cuda build for the package is being pulled for the following packages:

torchtext, torchtext-base
deepspeed
jax
dali-ffmpeg

Resolved this in 1.11.2.
by PRs -
https://github.com/open-ce/torchtext-feedstock/pull/55
https://github.com/open-ce/deepspeed-feedstock/pull/10
https://github.com/open-ce/jax-feedstock/pull/5
https://github.com/open-ce/DALI-feedstock/pull/76


TabLineSel is barely readable

The readability can be improved tremendously if you assign c.pmenu.select instead of c.fg ...
diff --git a/lua/github-theme/theme.lua b/lua/github-theme/theme.lua
index f3f12c2..74c0a9f 100644
--- a/lua/github-theme/theme.lua
+++ b/lua/github-theme/theme.lua
@@ -68,7 +68,7 @@ function M.setup(config)
     StatusLineNC = {fg = c.fg, bg = c.bg}, -- status lines of not-current windows Note: if this is equal to "StatusLine" Vim will use "^^^" in the status line of the current window.
     TabLine = {bg = c.bg, fg = c.fg}, -- tab pages line, not active tab page label
     TabLineFill = {bg = c.bg2}, -- tab pages line, where there are no labels
-    TabLineSel = {fg = c.fg, bg = c.blue}, -- tab pages line, active tab page label
+    TabLineSel = {fg = c.pmenu.select, bg = c.blue}, -- tab pages line, active tab page label
     Title = {fg = c.syntax.variable, style = "bold"}, -- titles for output from ":set all", ":autocmd" etc.
     Visual = {bg = c.bg_visual_selection}, -- Visual mode selection
     VisualNOS = {bg = c.bg_visual_selection}, -- Visual mode selection when vim is "Not Owning the Selection".

Thank you so much!


added script mod updater

a script to update the PVZ mod to the latest version
ps: I will also upload another script to the repository where it calls the mod-updater.ps1 script in the script, mod-update.ps1, whenever you make a new release, modify the script to always have the updated URL, and also, include the new .exe that I will be creating called update.exe where you will have to include it with the new zip whenever there is a new release, today I will make a request.

Hey, I appreciate the effort, but I have a couple of questions.
Why is this a seperate powershell script, and not included as part of the application?
Where is the source for the exe file?
From what I gather, the exe grabs the latest ps1 file from this repo, and launches that?
It would probably be better if the updater grabbed the latest release from /releases/latest, rather than using a hardcoded release tag.
You could grab the contents of "https://api.github.com/repos/CG8516/PvZA11y/releases"
Get the first assets_url, which at the moment is: "https://api.github.com/repos/CG8516/PvZA11y/releases/135767102/assets"
Then download the first 'browser_download_url', which is currently: "https://github.com/CG8516/PvZA11y/releases/download/beta.1.15.4/PvZA11y_Beta1.15.4.zip"
That way you wouldn't need to harcode any values, and it wouldn't need to be manually updated between releases.


[api] Allow change of password through the API

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1257748
@abellotti please review

@miq-bot add-label api

@miq-bot add-label enhancement

with the methods added for post, I think this is enabling adds and deletes (via post action "delete"). If that is not the intent, you can add the disabled: true to the add and delete actions for now in the api.yml.  We we are enabling CRUD for users, we need to make sure the necessary checks are done in API or model, must specify minimum set of attributes for adding, cannot delete self (authenticated API user), probably other checks, need to verify with UI. Thanks.

@miq-bot add-label wip

Thanks, @abellotti. I had wondered why some of those actions were there but effectively disabled. I'll add more tests to verify those scenarios. Shall I go ahead and assume enabling full CRUD for users for this PR, or limit to edits as per the RFE?

Let's discuss with @gtanzillo, there's some things to discuss. I know for adding users we need to be consistent with let's say adding providers where we can specify a zone (by href or id), here we want to do the same with group,  "group" : { "href" : "http://...../api/groups/2" } or "group" : { "id" : 2 }. I'd also change the action to "create" for consistency with v2.0.0.  Thanks.

@imtayadeway, @abellotti Tim and I discussed this and agreed that it would be best to stick to the minimum requirement of just enabling password change.  We can deal with any other requirements on users if and when they come up.

in the admin UI, can a non-admin user A (with user edit permission) change user B's password ?

@abellotti So I created a new Role with a few basic privileges, but enough to access Configuration/Access Control. Can confirm that a new user with this role could change the admin password. Here's a few screens to demonstrate. Hard to see all the product features, but nonetheless:

@imtayadeway @abellotti @gtanzillo What is the status of this PR?

This implementation does not include the ability of a user to change his own password unless he has the privilege to do so. This will be added in another PR


Set AWS lifecycle rule for incomplete multipart uploads

@sanderegg added a lifecycle rule in AWS-master in order to automatically delete incomplete multipart uploads older than 7 days.
NOTE: the rule is assigned to a bucket
according to @mrnicegyu11 this should be adapted in terraform and deployed in all AWS deployments:

import the rule in terraform (or feel free to overwrite it to change the naming if inconvenient)
propagate to all buckets in AWS

taking action here...

Done on

[ ] zmtmaster
[ ] nihstaging
[ ] nihprod
[ ] zmtprod

done


tests: add ginko panic recovery to retry policy e2e

Description:
Cleanup will be skipped and test will exit bypassing cleanup
if a different context goroutine panics or asserts without
deferring the ginkgo recover function.
Related to #3119

Testing done:

Affected area:

Functional Area

Tests
[x]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Codecov Report

Merging #4832 (37854d1) into main (30885c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4832   +/-   ##
=======================================
  Coverage   69.47%   69.48%
=======================================
  Files         218      218
  Lines       15766    15766
=======================================
+ Hits        10954    10955    +1
+ Misses       4760     4759    -1
  Partials       52       52

Flag
Coverage Δ

unittests
69.48% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/certificate/manager.go
77.43% <0.00%> (-1.03%)
:arrow_down:

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30885c9...37854d1. Read the comment docs.


useFetcher return value changes on every render

What version of Remix are you using?
1.10.1
Steps to Reproduce
https://github.com/remix-run/remix/blob/main/packages/remix-react/components.tsx#L1149
As of 1.10, Remix's useFetcher wrapper now returns a new object every time it's called. The means that using it in a hook's dependency array (like useEffect) causes the effect to re-run for every render, even when the fetcher's actual state hasn't changed.
Before 1.10, I could use it in useEffect and check for something like if (fetcher.type === "done") { ... } inside the effect. I was able to rely on the fetcher only causing the effect to re-run if something actually changed with the fetcher. But now, if the callback inside that useEffect does anything to cause a re-render, the useEffect falls into an infinite loop. Upgrading to 1.10 broke many pages on our site due to this. Unfortunately, because there are no success/error callbacks with useFetcher (yet?), I don't know any way other than useEffect to deal with the results of a fetcher.
For now, I can change all of my callbacks (unfortunately there are hundreds of them) to use fetcher.type in the dependency array instead of the whole fetcher object, but it would be nice if useFetcher wrapped its return object in a useMemo. I can send a PR for this if needed, but wanted to make sure there wasn't a specific reason this isn't being done already?
Some other functions (such as useTransition) do wrap their return values in useMemo, and before the upgrade to the new router, Remix returned a useMemo from useFetcher: https://github.com/remix-run/remix/blob/v1.6.4/packages/remix-react/components.tsx#L1389
Expected Behavior
useFetcher should not return a new object every render when nothing related to the fetcher has actually changed.
Actual Behavior
useFetcher returns a new object every render.

This should be available in 1.11.0-pre.1 shortly once CI finishes if you want to confirm it fixes your issue 👍

Released in 1.11.0

After upgrading to 1.11.0 I believe this issue still persists. Something with the fetchers consistent between 1.9.0 and 1.11.0. I'll need to do more investigating.

@krall12 please provide some reproduce case in a new issue 🙏🏼

The issue occurs for me when using fetcher.submit within a useEffect.
I tried reproducing here: https://github.com/nielskrijger/unstable-fetcher
Relevant file: https://github.com/nielskrijger/unstable-fetcher/blob/master/app/routes/index.tsx
Remix version 1.13


Option to create multiple keys in Secrets

Describe the problem/challenge you have
When multiple keys are defined in a Password object, the generated secrets are the same across all keys.
Here is an example:
---
apiVersion: secretgen.k14s.io/v1alpha1
kind: Password
metadata:
  name: postgresql-password
spec:
  secretTemplate:
    type: Opaque
    stringData:
      postgresql-password: $(value)
      postgresql-postgres-password: $(value)
      repmgr-password: $(value)

What is currently generated:
apiVersion: v1
data:
  postgresql-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
  postgresql-postgres-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
  repmgr-password: ZDJ1cjJiZm1keHFpb2F3cnNtZGYxMHN0YTl0Z2J1anB0cWx3aGdjbA==
kind: Secret
  name: postgresql-password
type: Opaque

Describe the solution you'd like
It would be fantastic, if each key in the secret would get a unique password.
Anything else you would like to add:
N/A
Thank you for your hard work!

@erkerb4 that becomes becomes of an issue for generating multiple passwords and combining them into a single secret (via a template). we've considered adding something like SecretTemplate CR (or something similar) which would be able to aggregate contents of one or more secrets Secrets and produce a new one, but have not fully committed to that approach yet.

Will be eagerly awaiting that implementation. Thank you for your response.


Include instructions to compile from source

As a Golang programmer
I want to compile plasma-cli from source
So that I can interact with the OMG Network without downloading scary binaries from the internet

If a user has set their $GOPATH correctly they can execute a go build from the root of this repo directly. We can add a SHA256 on the releases page so users can verify they're using a build we've created.


Fix Default Bank Account Tagging Issue

Details

Resolves the presence of two default marked bank accounts by setting isDefault to false for all other bank accounts in onyx when the AddPersonalBankAccount response is successful.
Fixed Issues

$ https://github.com/Expensify/App/issues/34774
PROPOSAL: $ https://github.com/Expensify/App/issues/34774#issuecomment-1911164240
Tests

Open Expensify App
Log in
Navigate to Settings - Wallet
Add a bank account for example Chasebank
Repeat step 4 with another bank account
Only one Default tagged bank account should exist

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as Tests.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/95647348/fb489c49-416d-4e83-8b30-b598bb07241a

Android: mWeb Chrome

https://github.com/Expensify/App/assets/95647348/48d43f29-ca2c-43f0-aa10-5a6a67da11b5

iOS: Native

https://github.com/Expensify/App/assets/95647348/370ed477-9d99-45ae-a9a7-e2e8c2e1e4f1

iOS: mWeb Safari

https://github.com/Expensify/App/assets/95647348/9d4e631c-3926-4b08-9cc3-53a08610486f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/95647348/caabd9b4-bfba-4891-8786-ac6f5608fbe7

MacOS: Desktop

https://github.com/Expensify/App/assets/95647348/0c3d0dbb-7f8c-42f9-a270-341900736bda

@s77rt I wonder what happens and what should happen when the user deletes a bank account. Using user_good I can register only 2 accounts, but what happens if the user has 3 registered accounts and deletes the account that has the default tag? The tag goes to:
A - the last account added
B - the last account with the default tag (example if the user changes manually)
C - no default tag
With the implementation of this PR I believe that the option C will be the behavior. Maybe we need to change the successData of deletePaymentBankAccount too. What do you think?

Upon testing I found that the BE doesn't always return the new bank as default. In such case this PR would cause a regression where no bank account is marked as default. Also I noticed that now once we complete the bank account flow OpenPaymentsPage is called which fixes the default tag.
I think doing nothing is best here. Or we can fix this in the BE, sending one more bank account in AddPersonalBankAccount response is not much overhead (new bank account + old default bank account in case the new one is set as default)
cc @stitesExpensify
https://github.com/Expensify/App/assets/16493223/1ec00925-3400-4534-aa85-470dc1da91b2

@s77rt You're right, I thought that BE always returns an isDefault value equal to true to the latest added bank account, but really if it doesn't happen we will have a problem. This happens because with this PR we do not achieve the proposition "solution is to set isDefault to false for all other bank accounts in onyx if our response has isDefault as true". I believe it is hard, but not impossible, to do it, since we will only know if isDefault is true after the BE response.
I tried to reproduce it in the latest main and after the OpenPaymentsPage calling the related issue is indeed resolved. But it's still not perfect in my opinion, take a look please:

Showing two default tag before `OpenPaymentsPage` call

https://github.com/Expensify/App/assets/95647348/a898043c-3c93-469f-a0ef-c53b54ffdfbf

Maybe use the logic of this PR from successData to optimisticData? I tested and looks good!

I think doing nothing is best here.

Is an option heheh. We can't forget to ''Handle the double 'PaymentMethods.openWalletPage()' call". Perhaps an intern can raise a PR later.

@brunovjk Using successData or optimisticData does not make much difference. We will still be clearing the default account even in cases where we shouldn't

I see, it makes perfect sense.

Showing two default tag before OpenPaymentsPage call

But do you think there is something we can do to improve this?

Awesome! If works Im fine with that :D

@stitesExpensify Yes!

hello @s77rt,  stitesExpensify is working on the BE solution, I have a thought, more for the sake of learning than actually doing something. Do you think we would manage to "set isDefault to false for all other bank accounts in onyx if and only if our response has isDefault as true."? In other words, wait for BE's response to change the BankList afterwards? Thank's for your time.

Please ignore these commits, I was doing some testing.

hello @s77rt,  stitesExpensify is working on the BE solution, I have a thought, more for the sake of learning than actually doing something. Do you think we would manage to "set isDefault to false for all other bank accounts in onyx if and only if our response has isDefault as true."? In other words, wait for BE's response to change the BankList afterwards? Thank's for your time.

@brunovjk We can achieve that using makeRequestWithSideEffects but this is used only as the last ressort as it's discouraged.

Nice, good to know :D thank you very much @s77rt.