Improved typing for PostProcess constructor

This PR improves the typing for "ratio" parameter of the PostProcess constructor.
I also modified most of the derived classes because they defined the ration as "number" only and not "number | { width: number, height: number }".

This seems wrong to me. Ratio should be number | PostProcessRatio

Ok i can change that if you want but PostProcessRatio should be renamed then in my opinion because its not a "ratio" anymore. Maybe PostProcessSize? Or a general PostProcessOptions for future additions?

options is cool

done


Inline dnt-helper

The dnt-helper utility almost never changes and it currently blocks rendering because of the HTTP request. It is therefore best to uglify and inline directly in the head of the document.

Pull request: https://github.com/mozilla/kuma/pull/4881

Duplicate of https://github.com/mdn/sprints/issues/257


fix: add screenCap to cached props for diffing during render check

Added some checks to see if screenCap differs from last attempt to re-render before actually triggering re-render.
Also adds new spatial dataset to example-datasets
These changes prevent the image download flow from download multiple images when pressed a single time while the spatial feature flag is enabled
#823

@seve can you help putting down a description of the bug, so the reviewers have more context please? Thank you!

@seve PTAL this approach! Would love to see what you think 🙏
https://github.com/chanzuckerberg/single-cell-explorer/compare/thuang-fix-double-download?expand=1
Thank you!


Add cppunit-devel for Bazel 3

Add cppunit-devel for Bazel 3

Sorry. I should have verified each of the Docker images. I only checked Ubuntu 18 and Debian 10.

No worries. It happens. :)
On Sun, Apr 19, 2020 at 10:12 AM Nicholas Nezis<EMAIL_ADDRESS>wrote:

Sorry. I should have verified each of the Docker images. I only checked
Ubuntu 18 and Debian 10.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-heron/pull/3513#issuecomment-616185679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQPBH25IZS7ZG76QIP4UHDRNMWGVANCNFSM4MLSSWHQ
.

@nicknezis No worries at all.  That's what the community is for.

@nicknezis https://github.com/nicknezis We put some streaming in
production and it works fine.
2020년 4월 20일 (월) 오전 9:02, Josh Fischer<EMAIL_ADDRESS>작성:

@nicknezis https://github.com/nicknezis No worries at all. That's what
the community is for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-heron/pull/3513#issuecomment-616247757,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACXLGN7QTDHKNY5YREJFMTRNOGI5ANCNFSM4MLSSWHQ
.


Fix CI

After https://github.com/mongoid/mongoid-slug/pull/260 everything is 🔴

I'll handle it in a week or so as part of getting other PR merged.


[BUILD_FAILED] package bzip2:x64-windows failed

Error: Building package bzip2:x64-windows failed with: BUILD_FAILED

wget http://www.bzip.org/1.0.6/bzip2-1.0.6.tar.gz
Connecting to www.bzip.org (<IP_ADDRESS>:80)
wget: can't open 'bzip2-1.0.6.tar.gz': File exists

browser

Error. Page cannot be displayed. Please contact your service provider for more details. (26)

It is necessary to do something with mirrors on source
Such errors more and more

Commits fixing this were merged on August 8 & 9: https://github.com/Microsoft/vcpkg/commits/master/ports/bzip2
If you git clone the master branch, you should receive those fixes.


Use released ROM gems

ROM 2.0 was released on July 27, 2016. I think it is better to use relased version in default skeleton instead of unreleased version.
I have compared dependency graph before:

and after:

@wafcio how did you generate that graph?

@AMHOL $ bundle viz
I found this possibility today. Read more here: http://bundler.io/v1.1/bundle_viz.html

Thanks, that's cool AF :smile:

Thanks @wafcio :) I'll pull this in now, and maybe add some version specs to make sure people are getting rom >= 2.0.


Update README with information about Tailwind JIT

Inspired by this thread in discussions: https://github.com/spatie/laravel-support-bubble/discussions/1

Thanks!


Pre-Req Step Role Assignment Script Fails

Describe the bug
If you have signed into another subscription in the past OR
If you have MFA enabled OR
If you are signed into the Azure portal in your "not default" browser, Connect-AzAccount fails to retrieve a token
Steps to reproduce

Sign into another Azure Subscription and Tenant, sign out
Run Connect-AzAccount
run get-azcontext

You will end up in the wrong tenant or your login will fail because no MFA auth will popup. There are lots of forum posts about this issue, it seems to be a PS v5 bug/nuance.
https://github.com/Azure/azure-powershell/issues/13530
Resolution
This script worked for me
#Install the AZ Modules
#More info https://docs.microsoft.com/en-us/powershell/azure/install-az-ps?view=azps-5.8.0
#Install-Module -Name Az -Scope CurrentUser -Repository PSGallery -Force -Verbose
Import-Module Az.Accounts

#Subscription Info
$SubscriptionName = 'Free Trial'
$TenantId = 'my tenant ID'

#Set the correct Az-AD Context
Clear-AzContext
Connect-AzAccount -Tenant $TenantId

#Select a subscription to work with
Select-AzSubscription -Subscription $SubscriptionName

Example Error
PS C:\Windows\system32> Connect-AzAccount -Debug

DEBUG: 12:01:34 PM - ConnectAzureRmAccountCommand begin processing with ParameterSet 'UserWithSubscriptionId'.
DEBUG: 12:01:37 PM - Autosave setting from startup session: 'CurrentUser'
DEBUG: 12:01:37 PM - No autosave setting detected in environment variable 'AzContextAutoSave'.
DEBUG: 12:01:37 PM - Using Autosave scope 'CurrentUser'
DEBUG: 12:01:37 PM - [InteractiveUserAuthenticator] Calling InteractiveBrowserCredential.AuthenticateAsync with TenantId:'', Scopes:'https://management.core.windows.net//.default', AuthorityH
ost:'https://login.microsoftonline.com/', RedirectUri:'http://localhost:8400/'
DEBUG: InteractiveBrowserCredential.Authenticate invoked. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:
DEBUG: Request [31a34a14-92b2-4516-9731-4a30a5ea6fdf] POST https://login.microsoftonline.com/organizations/oauth2/v2.0/token
x-client-SKU:REDACTED
x-client-Ver:REDACTED
x-client-CPU:REDACTED
x-client-OS:REDACTED
x-client-current-telemetry:REDACTED
x-client-last-telemetry:REDACTED
x-ms-PKeyAuth:REDACTED
x-ms-lib-capability:REDACTED
client-request-id:REDACTED
return-client-request-id:REDACTED
x-app-name:REDACTED
x-app-ver:REDACTED
Content-Type:application/x-www-form-urlencoded
x-ms-client-request-id:31a34a14-92b2-4516-9731-4a30a5ea6fdf
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.4.0-beta.3 (.NET Framework 4.8.4341.0; Microsoft Windows 10.0.19043 )
client assembly: Azure.Identity
DEBUG: Response [31a34a14-92b2-4516-9731-4a30a5ea6fdf] 200 OK (00.7s)
Pragma:no-cache
Strict-Transport-Security:REDACTED
X-Content-Type-Options:REDACTED
client-request-id:REDACTED
x-ms-request-id:REDACTED
x-ms-ests-server:REDACTED
x-ms-clitelem:REDACTED
Cache-Control:no-store, no-cache
Content-Type:application/json; charset=utf-8
Expires:-1
P3P:REDACTED
Set-Cookie:REDACTED
Date:Tue, 01 Jun 2021 02:01:41 GMT
Content-Length:4647

DEBUG: InteractiveBrowserCredential.Authenticate succeeded. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:  ExpiresOn: 2021-06-01T03:01:41.0000000+00:00
DEBUG: 12:01:42 PM - [MsalAccessToken] Calling InteractiveBrowserCredential.GetTokenAsync - Scopes:'https://management.core.windows.net//.default'
DEBUG: InteractiveBrowserCredential.GetToken invoked. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:
DEBUG: InteractiveBrowserCredential.GetToken succeeded. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:  ExpiresOn: 2021-06-01T03:01:41.0000000+00:00
DEBUG: ============================ HTTP REQUEST ============================

HTTP Method:
GET

Absolute Uri:
https://management.azure.com/tenants?api-version=2019-06-01

Headers:
x-ms-client-request-id        : 8704aa4b-4571-4932-a208-934d82d2a853
accept-language               : en-US

Body:

DEBUG: ============================ HTTP RESPONSE ============================

Status Code:
OK

Headers:
Pragma                        : no-cache
x-ms-ratelimit-remaining-tenant-reads: 11998
x-ms-request-id               : 1d2e5d66-ae1b-493a-a508-f6dec0a619fd
x-ms-correlation-request-id   : 1d2e5d66-ae1b-493a-a508-f6dec0a619fd
x-ms-routing-request-id       : SOUTHEASTASIA:20210601T020143Z:1d2e5d66-ae1b-493a-a508-f6dec0a619fd
Strict-Transport-Security     : max-age=31536000; includeSubDomains
X-Content-Type-Options        : nosniff
Cache-Control                 : no-cache
Date                          : Tue, 01 Jun 2021 02:01:42 GMT

Body:
{
  "value": [
    {
      "id": "/tenants/REDACTED",
      "tenantId": "REDACTED",
      "countryCode": "AU",
      "displayName": "Default Directory",
      "domains": [
        "REDACTED"
      ],
      "tenantCategory": "Home"
    }
  ]
}

DEBUG: 12:01:43 PM - [SilentAuthenticator] Calling SharedTokenCacheCredential.GetTokenAsync - TenantId:'REDACTED', Scopes:'https://management.core.windows.net//.de
fault', AuthorityHost:'https://login.microsoftonline.com/', UserId:'REDACTED'
DEBUG: SharedTokenCacheCredential.GetToken invoked. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:
DEBUG: Request [bb056e66-73d3-4d95-b7ec-2667bda3ce52] POST https://login.microsoftonline.com/REDACTED/oauth2/v2.0/token
x-client-SKU:REDACTED
x-client-Ver:REDACTED
x-client-CPU:REDACTED
x-client-OS:REDACTED
x-client-current-telemetry:REDACTED
x-client-last-telemetry:REDACTED
x-ms-PKeyAuth:REDACTED
x-ms-lib-capability:REDACTED
client-request-id:REDACTED
return-client-request-id:REDACTED
x-app-name:REDACTED
x-app-ver:REDACTED
Content-Type:application/x-www-form-urlencoded
x-ms-client-request-id:bb056e66-73d3-4d95-b7ec-2667bda3ce52
x-ms-return-client-request-id:true
User-Agent:azsdk-net-Identity/1.4.0-beta.3 (.NET Framework 4.8.4341.0; Microsoft Windows 10.0.19043 )
client assembly: Azure.Identity
DEBUG: Error response [bb056e66-73d3-4d95-b7ec-2667bda3ce52] 400 Bad Request (01.1s)
Pragma:no-cache
Strict-Transport-Security:REDACTED
X-Content-Type-Options:REDACTED
client-request-id:REDACTED
x-ms-request-id:REDACTED
x-ms-ests-server:REDACTED
x-ms-clitelem:REDACTED
Cache-Control:no-store, no-cache
Content-Type:application/json; charset=utf-8
Expires:-1
P3P:REDACTED
Set-Cookie:REDACTED
Date:Tue, 01 Jun 2021 02:01:43 GMT
Content-Length:644

DEBUG: SharedTokenCacheCredential.GetToken was unable to retrieve an access token. Scopes: [ https://management.core.windows.net//.default ] ParentRequestId:  Exception: Azure.Identity.Creden
tialUnavailableException (0x80131500): SharedTokenCacheCredential authentication unavailable. Token acquisition failed for user REDACTED. Ensure that you have authentic
ated with a developer tool that supports Azure single sign on.
WARNING: Unable to acquire token for tenant 'REDACTED' with error 'SharedTokenCacheCredential authentication unavailable. Token acquisition failed for user REDACTED.
. Ensure that you have authenticated with a developer tool that supports Azure single sign on.'
DEBUG: 12:01:46 PM - Unable to acquire token for tenant  #'REDACTED' with error 'Azure.Identity.CredentialUnavailableException: SharedTokenCacheCredential authentica
tion unavailable. Token acquisition failed for user REDACTED. Ensure that you have authenticated with a developer tool that supports Azure single sign on.
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Azure.Identity.CredentialDiagnosticScope.FailWrapAndThrow(Exception ex)
   at Azure.Identity.SharedTokenCacheCredential.<GetTokenImplAsync>d__21.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Azure.Identity.SharedTokenCacheCredential.<GetTokenAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.PowerShell.Authenticators.MsalAccessToken.<GetAccessTokenAsync>d__33.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.Azure.Commands.Common.Authentication.Factories.AuthenticationFactory.Authenticate(IAzureAccount account, IAzureEnvironment environment, String tenant, SecureString password, S
tring promptBehavior, Action`1 promptAction, IAzureTokenCache tokenCache, String resourceId)
   at Microsoft.Azure.Commands.ResourceManager.Common.RMProfileClient.Login(IAzureAccount account, IAzureEnvironment environment, String tenantId, String subscriptionId, String subscriptionNa
me, SecureString password, Boolean skipValidation, Action`1 promptAction, String name, Boolean shouldPopulateContextList, Int32 maxContextPopulation)'
WARNING: Unable to set default context 'Microsoft.Azure.Commands.Common.Authentication.Abstractions.AzureContext'.
Connect-AzAccount : Run Connect-AzAccount to login.
At line:1 char:1
+ Connect-AzAccount -Debug
+ ~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : CloseError: (:) [Connect-AzAccount], PSInvalidOperationException
    + FullyQualifiedErrorId : Microsoft.Azure.Commands.Profile.ConnectAzureRmAccountCommand

DEBUG: AzureQoSEvent: CommandName - Connect-AzAccount; IsSuccess - False; Duration - 00:00:12.1143725; Exception - Run Connect-AzAccount to login.;
DEBUG: Finish sending metric.
DEBUG: 12:01:48 PM - ConnectAzureRmAccountCommand end processing.

@simone-bennett is this related to ESLZ or any artifact in this repository that should be updated? If identity has access to multiple tenants it is always recommended to provide tenantId.

It was more because there's no way to submit a suggested edit to the doco directly to say "add the tenantid'
There is a note to create any doco updates as issues so I figured I would to save someone else having to look that up and make the deployment as seamless as possible :)
Simone
e<EMAIL_ADDRESS>m: 0421 019 967
From: Hansjoerg Scherer @.>
Sent: Wednesday, 2 June 2021 4:03 PM
To: Azure/Enterprise-Scale @.>
Cc: Simone @.>; Mention @.>
Subject: Re: [Azure/Enterprise-Scale] Pre-Req Step Role Assignment Script Fails (#600)
@simone-bennetthttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsimone-bennett&data=04|01||ad70c53a0ab849da0b7108d9258c0688|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637582105600202691|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Sm6YDBSu3%2BTdUMRoL2Z3IGMf49E4RK2WhgEd4xOgxzM%3D&reserved=0 is this related to ESLZ or any artifact in this repository that should be updated? If identity has access to multiple tenants it is always recommended to provide tenantId.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FEnterprise-Scale%2Fissues%2F600%23issuecomment-852759701&data=04|01||ad70c53a0ab849da0b7108d9258c0688|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637582105600212680|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xYeP1gjDOML1PLLgpJtZRSKvnU4FX2DHVKDpGxp%2FGKE%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQB6BSDCOJD7EKQIVESNJGDTQXCP5ANCNFSM4532YPZQ&data=04|01||ad70c53a0ab849da0b7108d9258c0688|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637582105600222680|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=DLWfQsAsI5TqRA2E6FVESkOsUjnlLTFN4SxKkpanSGg%3D&reserved=0.

Closing stale issue.


Fix for Issue:268

This fixes the issue when the save actions batch request fails to execute on some files in the directory.
Fix as discussed in https://github.com/dubreuia/intellij-plugin-save-actions/issues/268#issuecomment-540932458

Hey @SabhtarshaMojo thank you for the PR.
LGTM I'll test it soon

Merged


Only update history when Turbo visit is renderable

Follow up to https://github.com/hotwired/turbo/pull/571, which ended up just moving around the scroll bug
Should close https://github.com/hotwired/turbo/issues/387
Context
We've been experiencing some bugs when Turbo visits fail (e.g due to tracked element mismatches or visit-control reload), where Turbo was keeping the previous page scroll position after the page was updated:
https://user-images.githubusercontent.com/11280312/173633018-8bdcb4c6-6441-4ff0-ba5f-6da7e4d41660.mov
Problem
From what I see here, Turbo always manually updates the browser state using visit.changeHistory(). This will update the URL before we navigate to the new page. This is fine when Turbo replaces the body, since Turbo will manage everything for us.
The problem lies when a visit is not possible, causing a turbo:reload event. In this case, Turbo was calling window.location.reload() (after the URL was updated), which works like hitting the refresh button in the browser.
Since the reload was called while the previous page was still loaded and scrolled, reload will try to keep the scroll state after the new page loads, causing the bug.
Proposed solution
Turbo should only update the browser history when it knows that it can handle the request.  Since we don't actually need the new URL until we replace the body, we can wait for renderPageand renderError to know if the request is renderable or not.
If the request is a success and Turbo can visit, it updates the history like before and continues on.
If the request fails for any reason (404, 500, visit control is reload, element mismatch....), Turbo will delegate to the browser to navigate to the new page, which now is done via window.location.href.
Current state
Now, when we click an element that causes a full reload, the browser will either navigate to the top of the new page or to the location of the targeted element. Notice that when hitting the back button, the previous scroll position is preserved, improving navigation.
https://user-images.githubusercontent.com/11280312/173634863-fe620f53-aece-4bb2-8e51-071addd6358f.mov

cc @packagethief


[QScintilla] Moc bug

I have a class derived from QsciScintilla and I am getting Linker error. But if QsciScintilla is a member of a class its okay. It's looks like something wrong witht a MOC. Previously I had no such errors with QSci build manually, so is it VCPKG specific problem or am I doing something wrong?
Vcpkg 2018.11.23-nohash
Qt 5.11.2
QScintilla 2.10-7

Code: LNK 2001
Description: unresolved external symbol "public: static struct QMetaObject const QsciScintilla::staticMetaObject" (?staticMetaObject@QsciScintilla@@2UQMetaObject@@B)
File: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\mocs_compilation.cpp.obj
Line: 1

CMakeLists.txt
cmake_minimum_required(VERSION 3.0)

project(QSciBug)

#Qt specific
set(CMAKE_INCLUDE_CURRENT_DIR ON)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTOUIC ON)
set(CMAKE_AUTORCC ON)

#Qt
find_package(Qt5Widgets CONFIG REQUIRED)
find_package(Qt5Core CONFIG REQUIRED)
find_package(Qt5PrintSupport CONFIG REQUIRED)

set(SOURCES
	Main.cpp
	#Good/TextEditor.hpp
	#Good/TextEditor.cpp
	Bad/TextEditor.hpp
	Bad/TextEditor.cpp
)

# find_package??? create custom???
if(CMAKE_BUILD_TYPE STREQUAL "Debug")
	set(QScintillaLib "D:/tools/vcpkg/packages/qscintilla_x64-windows/debug/lib/qscintilla2.lib")
endif()

add_executable(${PROJECT_NAME} WIN32 ${SOURCES})
target_link_libraries(${PROJECT_NAME}
${QScintillaLib}
Qt5::Widgets
Qt5::Core
Qt5::PrintSupport)

Main.cpp
#include <qapplication.h>
#include <qmainwindow.h>

//#include "Good/TextEditor.hpp"
#include "Bad/TextEditor.hpp"

int main(int argc, char** argv) {
	QApplication app(argc, argv);

	auto window  = new QMainWindow;
	window->setCentralWidget(new TextEditor);
	window->show();

	return QApplication::exec();
}

Good/TextEditor.hpp
#pragma once

#include <Qsci/qsciscintilla.h>

class TextEditor : public QWidget {
	Q_OBJECT
public:
	explicit TextEditor(QWidget* parent = nullptr);

private:
	QsciScintilla* m_sciEditor;
};

Good/TextEditor.cpp
#include "TextEditor.hpp"

#include <qlayout.h>

TextEditor::TextEditor(QWidget *parent) :
	QWidget(parent),
	m_sciEditor(new QsciScintilla(this))
{
	auto layout = new QHBoxLayout;
	layout->addWidget(m_sciEditor);
	setLayout(layout);
}

Bad/TextEditor.hpp
#pragma once

#include <Qsci/qsciscintilla.h>

class TextEditor : public QsciScintilla {
	Q_OBJECT
public:
	explicit TextEditor(QWidget* parent = nullptr);
};

Bad/TextEditor.cpp
#include "TextEditor.hpp"
TextEditor::TextEditor(QWidget *parent) :
	QsciScintilla(parent)
{
}

@VladBolotov
Can you comment out Q_OBJEXT in your class declaration and try to compile again?

@JackBoosY
It worked, but you’ll get "unusable" solution (moc, properties, signals/slots do not work).

@VladBolotov Maybe you should create a issue on here?

@JackBoosY
QScintilla and Scintilla is two different projects. QScintilla is a project from riverbankcomputing and the only option for bug report is mailing list (I couldn’t find any other options). I send an email about my problem (it was Jan 21, 2019) and doesn’t get anything.

@JackBoosY should be closed. Is not a vcpkg issue.

@VladBolotov I think this is a upstream issue, we need to wait for upstream to fix this issue and update to the new version.

Hi @VladBolotov, since QScintilla was updated to 2.11.4, does this issue exists?

I have experienced this error as the default package has dynamic link scope it was necessary to add add_definitions(-DQSCINTILLA_DLL) to my project CMakeLists.txt to switch the library dependency to dynamic linking.

Reopen this issue since it's not resolved completely.

@VladBolotov, does this issue exist since QScintilla has been updated to 2.12.0?

I will close this issue now, please ping me if anyone meet this again.


Improve reporting

Add custom reporting to h5p-php-reporting or enhance reporting by adding feedback to xAPI object description.

Did the latter for now


[FEATURE] PEAR

Hello,
For a project I am building I would need to be able to point to the pear.php file.
Browsing in the webserver container I was unable to locate it.
Am I wrong to look for it or is it just not implemented?
If so, could I have any indication of this?
I think it might be useful to have it for php version 5.4 and 5.6.
Thanks for the amazing work.

Hello @Kasui92
thanks for the compliments. The pear.php is available at /usr/local/lib/php/PEAR.php.
Let me know if this solved your problem.

Found It!
Problem solved.
Thank you for your help and have a good day!


AAU, on the CLI I see a function to list all projects with minimum information

[ ] I opened a merge request on kili on a branch with the same name than the branch of the current pull request and forced security tests.
[ ] I opened a pull request on the Node playground if the changes are breaking.

Note: no branch has been created on the kili Gitlab side as the interactions with the backend have not been touched.


Failure to scale up application after removed primary pod and automatic re-election

Bug Description
The mysql-k8s application fails to scale up after the primary pod is removed. The removal of the primary pod causes the pod to restart and a new unit in the cluster to be re-elected as the primary. The pod comes back up seemingly correctly. However scale up operations after this pod restart fails.
To Reproduce

juju deploy -n 3 ./mysql-k8s_ubuntu-20.04-amd64.charm mysql-k8s`, and wait for application to move to active status
microk8s.kubectl -n <model_name> delete pod mysql-k8s-<primary_number>, and wait for application to stabilize after new pod comes up
juju scale-application mysql-k8s 4

Environment

Juju 2.9.34-ubuntu-amd64
Microk8s 1.21/stable

Relevant log output
unit-mysql-k8s-2: 14:56:06 DEBUG unit.mysql-k8s/2.juju-log Adding instance mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local/mysql-k8s-3 to cluster test_cluster with recovery method auto
...
unit-mysql-k8s-2: 14:59:13 ERROR unit.mysql-k8s/2.juju-log Failed to add instance mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local to cluster test_cluster with recovery method 'aut
o'. Trying method 'clone'
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/src/mysqlsh_helpers.py", line 520, in _run_mysqlsh_script
    stdout, _ = process.wait_output()
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/venv/ops/pebble.py", line 1103, in wait_output
    raise ExecError(self._command, exit_code, out_value, err_value)
ops.pebble.ExecError: non-zero exit code 1 executing ['/usr/bin/mysqlsh', '--no-wizard', '--python', '--verbose=1', '-f', '/tmp/script.py', ';', 'rm', '/tmp/script.py'], stdout='\n\n', stderr="Cannot set
 LC_ALL to locale en_US.UTF-8: No such file or directory\nverbose: 2022-10-12T18:56:06Z: Loading startup files...\nverbose: 2022-10-12T18:56:06Z: Loading plugins...\nverbose: 2022-10-12T18:56:06Z: About
to connect to MySQL at: clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306\nverbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-t
imeout=5000\nverbose: 2022-10-12T18:56:06Z: Group Replication 'group_name' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb\nverbose: 2022-10-12T18:56:06Z: Metadata 'group_name' value: 4eb1f942-4a5e-11ed-bbdd
-a200077615cb\nverbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local?connect-timeout=5000\nverbose: 202
2-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000\nIncremental state recovery was selected because it seems to be safely usab
le.\n\nver" [truncated]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/lib/charms/mysql/v0/mysql.py", line 586, in add_instance_to_cluster
    self._run_mysqlsh_script("\n".join(connect_commands + add_instance_command))
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/src/mysqlsh_helpers.py", line 523, in _run_mysqlsh_script
    raise MySQLClientError(e.stderr)
charms.mysql.v0.mysql.MySQLClientError: Cannot set LC_ALL to locale en_US.UTF-8: No such file or directory
verbose: 2022-10-12T18:56:06Z: Loading startup files...
verbose: 2022-10-12T18:56:06Z: Loading plugins...
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Group Replication 'group_name' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb
verbose: 2022-10-12T18:56:06Z: Metadata 'group_name' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
Incremental state recovery was selected because it seems to be safely usable.

verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: SSL mode used to configure the instance: 'REQUIRED'
Validating instance configuration at mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306...
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Validating account<EMAIL_ADDRESS>
verbose: 2022-10-12T18:56:06Z: clusteradmin user has 1 accounts with wildcard or netmask and 0 without
This instance reports its own address as mysql-k8s-3.mysql-k8s-endpoints:3306
verbose: 2022-10-12T18:56:06Z: Validating InnoDB page size of instance 'mysql-k8s-3.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: Checking if performance_schema is enabled on instance 'mysql-k8s-3.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: Validating configuration of mysql-k8s-3.mysql-k8s-endpoints:3306 (mycnf = )
Instance configuration is suitable.
verbose: 2022-10-12T18:56:06Z: Validating if 'lower_case_table_names' variable has the same value on target instance 'mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306' as it d
oes on the cluster.
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Validating if 'default_table_encryption' variable has the same value on target instance 'mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306' as it
 does on the cluster.
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-timeout=5000
NOTE: Group Replication will communicate with other members using 'mysql-k8s-3.mysql-k8s-endpoints:33061'. Use the localAddress option to override.

verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
A new instance will be added to the InnoDB cluster. Depending on the amount of
data on the cluster this might take from a few seconds to several hours.

verbose: 2022-10-12T18:56:06Z: Using Group Replication local address: mysql-k8s-3.mysql-k8s-endpoints:33061
verbose: 2022-10-12T18:56:06Z: Using Group Replication group seeds: mysql-k8s-1.mysql-k8s-endpoints:33061,mysql-k8s-2.mysql-k8s-endpoints:33061,mysql-k8s-0.mysql-k8s-endpoints:33061
verbose: 2022-10-12T18:56:06Z: Using Group Replication failover consistency: EVENTUAL
verbose: 2022-10-12T18:56:06Z: Using Group Replication expel timeout: 5
Adding instance to the cluster...

verbose: 2022-10-12T18:56:06Z: Validating if 'group_replication_gtid_assignment_block_size' variable has the same value on target instance 'mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.clust
er.local:3306' as it does on the cluster.
verbose: 2022-10-12T18:56:06Z: Installing the clone plugin on instance 'mysql-k8s-3.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Installing the clone plugin on instance 'mysql-k8s-2.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Installing the clone plugin on instance 'mysql-k8s-0.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: Installing the clone plugin on instance 'mysql-k8s-1.mysql-k8s-endpoints:3306'.
verbose: 2022-10-12T18:56:06Z: Creating recovery account 'mysql_innodb_cluster_3454879168'@'%' for instance 'mysql-k8s-3.mysql-k8s-endpoints:3306'
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-2.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:06Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-0.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:07Z: Joining 'mysql-k8s-3.mysql-k8s-endpoints:3306' to cluster using account clusteradmin to peer 'mysql-k8s-1.mysql-k8s-endpoints:3306'.
Monitoring recovery process of the new cluster member. Press ^C to stop monitoring and let it continue in background.
verbose: 2022-10-12T18:56:08Z: Waiting for GR recovery to start for mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306...
verbose: 2022-10-12T18:56:08Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306?connect-timeout=5000
verbose: 2022-10-12T18:56:08Z: mysql-k8s-3.mysql-k8s-endpoints:3306 has started
verbose: 2022-10-12T18:56:09Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local:3306?connect-timeout=5000
Incremental state recovery is now in progress.

* Waiting for distributed recovery to finish...
WARNING: Error in receiver for group_replication_recovery: Got fatal error 1236 from master when reading data from binary log: 'Cannot replicate because the master purged required binary logs. Replicate
the missing transactions from elsewhere, or provision a new slave from backup. Consider increasing the master's binary log expiration period. The GTID set sent by the slave is '', and the missing transac
tions are '4eb1f942-4a5e-11ed-bbdd-a200077615cb:1-63,
4eb1fac9-4a5e-11ed-bbdd-a200077615cb:1-2'' (13114) at 2022-10-12 18:56:09.794508
NOTE: 'mysql-k8s-3.mysql-k8s-endpoints:3306' is being recovered from 'mysql-k8s-0.mysql-k8s-endpoints:3306'
WARNING: Error in receiver for group_replication_recovery: Got fatal error 1236 from master when reading data from binary log: 'Cannot replicate because the master purged required binary logs. Replicate
the missing transactions from elsewhere, or provision a new slave from backup. Consider increasing the master's binary log expiration period. The GTID set sent by the slave is '', and the missing transac
tions are '4eb1f942-4a5e-11ed-bbdd-a200077615cb:1-63,
4eb1fac9-4a5e-11ed-bbdd-a200077615cb:1-2'' (13114) at 2022-10-12 18:57:10.984844
WARNING: Error in receiver for group_replication_recovery: error connecting to master 'mysql_innodb_cluster_3454879168@mysql-k8s-2:3306' - retry-time: 60 retries: 1 message: Unknown MySQL server host 'my
sql-k8s-2' (-2) (2005) at 2022-10-12 18:58:12.037590
WARNING: Error in receiver for group_replication_recovery: Got fatal error 1236 from master when reading data from binary log: 'Cannot replicate because the master purged required binary logs. Replicate
the missing transactions from elsewhere, or provision a new slave from backup. Consider increasing the master's binary log expiration period. The GTID set sent by the slave is '', and the missing transac
tions are '4eb1f942-4a5e-11ed-bbdd-a200077615cb:1-63,
4eb1fac9-4a5e-11ed-bbdd-a200077615cb:1-2'' (13114) at 2022-10-12 18:59:12.326116
ERROR: Recovery error in added instance: MySQL Error 51155: Distributed recovery has failed
Traceback (most recent call last):
  File "<string>", line 3, in <module>
mysqlsh.Error: Shell Error (51155): Cluster.add_instance: Distributed recovery has failed

unit-mysql-k8s-2: 14:59:13 DEBUG unit.mysql-k8s/2.juju-log Adding instance mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local/mysql-k8s-3 to cluster test_cluster with recovery method clone
unit-mysql-k8s-2: 14:59:13 ERROR unit.mysql-k8s/2.juju-log Failed to add instance mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local to cluster test_cluster on mysql-k8s-2.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/src/mysqlsh_helpers.py", line 520, in _run_mysqlsh_script
    stdout, _ = process.wait_output()
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/venv/ops/pebble.py", line 1103, in wait_output
    raise ExecError(self._command, exit_code, out_value, err_value)
ops.pebble.ExecError: non-zero exit code 1 executing ['/usr/bin/mysqlsh', '--no-wizard', '--python', '--verbose=1', '-f', '/tmp/script.py', ';', 'rm', '/tmp/script.py'], stdout='', stderr='Cannot set LC_ALL to locale en_US.UTF-8: No such file or directory\nverbose: 2022-10-12T18:59:13Z: Loading startup files...\nverbose: 2022-10-12T18:59:13Z: Loading plugins...\nverbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306\nverbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-timeout=5000\nverbose: 2022-10-12T18:59:13Z: Group Replication \'group_name\' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb\nverbose: 2022-10-12T18:59:13Z: Metadata \'group_name\' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb\nverbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local?connect-timeout=5000\nTraceback (most recent call last):\n  File "<string>", line 3, in <module>\nRuntimeError: Cluster.add_instance: The instance \'mysql-k8s-3.mysql-k8s-endpoints:3306\' is already part of another Replication Group\n\n'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/lib/charms/mysql/v0/mysql.py", line 586, in add_instance_to_cluster
    self._run_mysqlsh_script("\n".join(connect_commands + add_instance_command))
  File "/var/lib/juju/agents/unit-mysql-k8s-2/charm/src/mysqlsh_helpers.py", line 523, in _run_mysqlsh_script
    raise MySQLClientError(e.stderr)
charms.mysql.v0.mysql.MySQLClientError: Cannot set LC_ALL to locale en_US.UTF-8: No such file or directory
verbose: 2022-10-12T18:59:13Z: Loading startup files...
verbose: 2022-10-12T18:59:13Z: Loading plugins...
verbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306
verbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-1.mysql-k8s-endpoints:3306?connect-timeout=5000
verbose: 2022-10-12T18:59:13Z: Group Replication 'group_name' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb
verbose: 2022-10-12T18:59:13Z: Metadata 'group_name' value: 4eb1f942-4a5e-11ed-bbdd-a200077615cb
verbose: 2022-10-12T18:59:13Z: About to connect to MySQL at: mysql://clusteradmin@mysql-k8s-3.mysql-k8s-endpoints.test-replication-hdv6.svc.cluster.local?connect-timeout=5000
Traceback (most recent call last):
  File "<string>", line 3, in <module>
RuntimeError: Cluster.add_instance: The instance 'mysql-k8s-3.mysql-k8s-endpoints:3306' is already part of another Replication Group

Additional context
No response

Reported internally as https://warthogs.atlassian.net/browse/DPE-1117 to check the next sprint.


Presentation

This PR address the following:

#59 Profiles page
#61 Header and main menu
#63 Teams page
#64 Profile page
#67 Team page
#69 Add and edit forms

Notes:

Bootstrap 4 is included in Webpack task compiling in sass.
Minimum possible of custom css is included aiming further theming to bootstrap variables mostly.
Components css files uses the same naming than components js files, they are postcss, not sass.
Markup resulted is valid HTML5 with proper outline.

Review:

Some bugs noted in #92 to be addressed in other tasks.

Why do we need empty .gitignore files in client/css/components/form and client/css/components/pages?

Aren't glyphicons something we could install with npm instead of storing them in our source?

After build is done, favicon.png and blueMarker.png are corrupted

Could build process save images in build/img folder?

2 of the images we use are renamed to something that looks like hash of their content, the other 4 don't - why is that?

Cancel button on "Add team" screen leads to 404 page

Some general feedback:

the loader screen looks much better without white border
I liked the transparent header much more - it made buttons looked like there were additional map controls, they had more google-maps style
user names in profile list and team names in team list are too big IMO
field labels in profile/team page would look much better if they had the same width
when rendering errors I'd show error message and the field name on the same line, without the BR in between
Logout link is much wider than "My profile", it expands to the very end of the screen, is that on purpose?
open-source and x-team links in the loader are blue, the background is blue as well which makes links not much visible

One small idea:
when I open the app, I just see map. When I click any of the links in the menu the box appears. I have to now go to the very left and click the logo to close the box. Could you add a small X button at the top right of the box? It would be a link to the homepage, but from user perspective it would let users kind of "close the box" and see the whole map again

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

client/css/components/fragments/Header.css, line 6 [r1] (raw file):
I consistently named all ID of unique components the same as the component itself. So the  component in Header.js file uses #Header class on Header.css file (css components folder is mirrored from js components folder). The one is wrong in this standard is the #logo which can be a class. Please let me know if this is ok so I can change here? thanks

client/js/app.js, line 21 [r1] (raw file):
this comment was there from the boilerplate, its valid for both files. setup.scss is needed for bootstrap that uses sass. our custom code is css (uses post css).

client/js/components/fragments/Map.js, line 36 [r1] (raw file):
maybe we should check based on viewport. on my big monitor zoom 3 cuts part of the map, and when I resize to small size, I need zoom 2 or 1 to see bigger part of the map. so this config can result differently depending on viewport size. I think we can set default to 2 (here will have a lot blank space above and below the map), remove the min zoom and check in other task about viewport specifics.

client/js/components/fragments/MiniProfile.js, line 12 [r1] (raw file):
we can include, the aang avatar was just kidding, we need better image. I removed completely because I'm divided if "anonimous avatar" is better or worst than none. but I dont have preferences here.

client/js/components/fragments/ProfileInformations.js, line 19 [r1] (raw file):
this is one part that can be better. I wanted the styles but bootstrap uses "input" in the naming and make stuff dont make sense, although is just styles and works as expected. I want to pimp this part where displays information a little bit in some other moment, if you agree.

client/js/components/pages/HomePage.js, line 6 [r1] (raw file):
this is the homepage, it's special case. :)

client/js/components/pages/ProfilePage.js, line 31 [r1] (raw file):
in the "card" display, this place will be very nice with some bigger image, can be a picture of the person or some landscape instead the avatar, avatar can be in other place in this card. Like what we have in x-team profiles, i.g. http://x-team.com/profile/bernardo-dias/

client/js/components/pages/TeamsPage.js, line 42 [r1] (raw file):
good call. this accessibility enhancements is partially done. i'll make full review on this and microdata attrs. maybe we can skip this for this pr and handle in other task. the markup result in all pages is html5 valid already. :)

client/package.json, line 50 [r1] (raw file):
we need this for bootstrap, I tried to leave jquery out without much success, so I included. currently only being used by accordion effect, but the bootstrap accordion effect is kinds broken, lots of glitches. if we could remove jquery and write custom js behaviours, would be much better. I'll not make changes on this in this PR b/c is time consuming. we can address in other issue.

Comments from the review on Reviewable.io

Why do we need empty .gitignore files in client/css/components/form and client/css/components/pages?

I mirrored the component folder in css from js, this this file is just to git track the folder. even not being used rigth now maybe is good to have as this standard suggests to use it in case custom styles for pages.

Aren't glyphicons something we could install with npm instead of storing them in our source?

No sure, I've included bootstrap files, we can remove these files currently. not using any icon in the presentation so far.

After build is done, favicon.png and blueMarker.png are corrupted
2 of the images we use are renamed to something that looks like hash of their content, the other 4 don't - why is that?

this is very strange... idk, I'll take a look.

Could build process save images in build/img folder?

should be possible. not sure yet.

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

Comments from the review on Reviewable.io

- the loader screen looks much better without white border
- I liked the transparent header much more - it made buttons looked like there were additional map controls, they had more google-maps style
- user names in profile list and team names in team list are too big IMO
- field labels in profile/team page would look much better if they had the same width
- when rendering errors I'd show error message and the field name on the same line, without the BR in between
- Logout link is much wider than "My profile", it expands to the very end of the screen, is that on purpose?
- open-source and x-team links in the loader are blue, the background is blue as well which makes links not much visible

got it. mostly visual changes are overrided by bootstrap defaults. with this move I didn't included any kind of styles that is not strict related to layout. even font-sizeand colors customization was left behind at this moment. I'll work on your feedback above as they are very simple and some is just to look what we had before, but a better work on styles/presentation to make a proper custom theme should be handled in other task. :)

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

Comments from the review on Reviewable.io

Could you add a small X button at the top right of the box?

yes! I've think about that yesterday, very useful, good catch!

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

Comments from the review on Reviewable.io

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

client/js/components/fragments/ProfileInformations.js, line 13 [r1] (raw file):
This part is kind the way structure is built, the block items inside the page are wrapped the same accordion structure, this is the consistency we have to scale (include more blocks of whatever in each page). for humans can be redundant, but a crawler can identify as a section with the "informations" information inside, so if dont need to display, we can include className="sr-only sr-only-focusable" and remove aria attributes that bootstrap uses to apply the js behavior of accordeon.
I'll not change this now, just out of curiosity for next changes.

Comments from the review on Reviewable.io

Review status: 0 of 65 files reviewed at latest revision, 17 unresolved discussions.

client/js/components/fragments/ProfileInformations.js, line 19 [r1] (raw file):
not changing this now, but set fixed width in labels. I think it's looking nice for a while. also, we can consider inline editing for each field individualy instead the page edit. just an idea, can be discarded or included in backlog.

Comments from the review on Reviewable.io

I'll create tickets for those broken images. I'll also start writing down ideas for UI improvements so that we can have a look at it later.

Reviewed 37 of 69 files at r1.
Review status: 24 of 59 files reviewed at latest revision, 13 unresolved discussions.

client/css/components/form/.gitignore, line 0 [r1] (raw file):
Why do we need empty .gitignore file here?

client/css/components/fragments/Header.css, line 6 [r1] (raw file):
Could we stay consistent in how we name elements? Header starts with upper case character, logo with lowercase character

client/css/components/pages/.gitignore, line 0 [r1] (raw file):
Why do we need empty .gitignore file here?

client/js/components/fragments/Map.js, line 36 [r1] (raw file):
I'll create a ticket for that

client/js/components/fragments/MiniProfile.js, line 12 [r1] (raw file):
The reason I like default avatar is that layout does not break. Without that users with and without avatar are aligned differently.

client/fonts/glyphicons-halflings-regular.svg, line 1 [r1] (raw file):
Aren't glyphicons something we could install with npm instead of storing them in our source?

Comments from the review on Reviewable.io

Review status: 24 of 59 files reviewed at latest revision, 12 unresolved discussions.

client/css/components/fragments/Header.css, line 6 [r1] (raw file):
seems my previous comment is hidden somewhere. the convention used is:
/css/components is mirrored folder/files structures of /js/components, Header.css stands for Header.js, and since it's unique component in the page it's using #Header id. All components stuff are using identical naming. Out of curiosity, while we use js and css in different folders, I've saw a lot setups putting files together (.js and .css of same components in the same place/folder). The reason is that the css in Header.css is strictly related to the component Header.js. Shared styles that uses classes (instead IDs, that is unique) are included in /css/base and /css/layout, normal css conventions there.

client/js/components/fragments/MiniProfile.js, line 12 [r1] (raw file):
alright, let's include anonymous avatar. I'll create new ticket for that b/c without time now, maybe in the end of the day I can check this.

client/fonts/glyphicons-halflings-regular.svg, line 1 [r1] (raw file):
I removed this already.

Comments from the review on Reviewable.io

Review status: 24 of 59 files reviewed at latest revision, 12 unresolved discussions.

client/css/components/form/.gitignore, line  [r1] (raw file):
this file is jut for git to track the folder. wanted to keep this folder as /css/components mirror /js/components/, this file can be removed after include any other. (some people uses a file called .gitkeep, which means nothing too).

Comments from the review on Reviewable.io

Review status: 24 of 59 files reviewed at latest revision, 9 unresolved discussions.

client/css/components/form/.gitignore, line  [r1] (raw file):
I know about .gitkeep - and indeed it does nothing. The problem I have with .gitignore is that it does not do nothing, as it's interpreted by git. So I'd switch to .gitkeep or just remove it completely, as we already have files in this folder. Up to you :)

Comments from the review on Reviewable.io


Change authentication method to Bearer token instead of access_token

Hey @Moebits, how are you doing? It's been a while.
I got a bug report from my project https://github.com/rayriffy/pixiv-bookmarks-visualizer/issues/1 having a problem where some tags in illust cannot be found from API response. Upon further investigation I found that by authenticate API with Authentation header has completely different response when comparing to access_token= method.
You can try comparing results between these both response by using following cURL command.

access_token to search params
Authentication header

curl --location 'https://app-api.pixiv.net/v1/user/bookmarks/illust?user_id=12593750&restrict=public&access_token=<your_token>'
curl --location 'https://app-api.pixiv.net/v1/user/bookmarks/illust?user_id=12593750&restrict=public' --header 'Authorization: Bearer <your_token>'

This PR will replace those authentication method to a newer one.

Thanks it was fixed in the new version 0.6.3


Integrate payloadbuilder handler

if the FCU is valid and we have payloadattributes we need to forward them to the payload builder
https://github.com/paradigmxyz/reth/blob/059233327e9ce49490ebf71b6508c7ffc44ff2ec/crates/consensus/beacon/src/engine/mod.rs#L1158-L1163
this functionality is currently missing

@mattsse could you give more info about this issue?

hey @mvares this is a bit more delicate because this is moving quickly.
please let me know if you can't find any interesting good first issue, we can figure something out


Use POST for reset since it has a side-effect

GET requests shouldn't have side-effects and should be idempotent.

@orta Also, surely this action should be behind some kind of authentication? We don't just want anyone resetting this?

Sounds :+1:  to me.
I don't have a particularly strong opinion on authentication, could just add an ENV var. Doesn't really feel like someone would go out of their way to continually reset our counter just so that the stats page shows 0 for the last day.


Use gaCache.matchAny to reduce unnecessary filtering

a minor improvement. If no candidate match the cache pattern, skip GA cache filtering earlier.

LGTM!


Roll Flutter Engine from 3a7aa01b0a7d to 75724687ca54 (2 revisions)

https://github.com/flutter/engine/compare/3a7aa01b0a7d...75724687ca54
2024-01-03<EMAIL_ADDRESS>[Impeller] Allow multiple --runtime-stage-* parameters to impellerc (flutter/engine#49475)
2024-01-03<EMAIL_ADDRESS>Roll Dart SDK from 7e9f7eab80d3 to c5a75ac9057c (1 revision) (flutter/engine#49478)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add support for python 3.12

Replace assertEquals (deprecated) with assertEqual.
Replace self.assert_ with self.assertTrue.
Fix docstrings in cpplint.py that contain invalid escape sequences to be raw strings.

This change is

:lgtm:

Looks like we need either a platform stamp or a forceful hand :wink:


Restore signalling server setup urls for turnserver.zip

Relevant components:

[x] Signalling server
[ ] Frontend library
[ ] Frontend UI library
[ ] Matchmaker
[ ] Platform scripts
[ ] SFU

Problem statement:
The download urls used in the signalling server setup for turnserver.zip are incorrect. https://github.com/EpicGamesExt/PixelStreamingInfrastructure/issues/36
It looks like https://github.com/EpicGamesExt/PixelStreamingInfrastructure/pull/23 replaced all urls with EpicGames to EpicGamesExt, but these releases don't exist in the new repo.
Solution
For now fix the download by using the urls from the old repository, which still work.
Once this repo gets new releases, the urls can point to releases in this repo.
Documentation
N/A
Test Plan and Compatibility
N/A

I just created the following releases:
https://github.com/EpicGamesExt/PixelStreamingInfrastructure/releases/tag/v4.6.2-coturn-mac-x86_64
https://github.com/EpicGamesExt/PixelStreamingInfrastructure/releases/tag/v4.6.2-coturn-mac-arm64
https://github.com/EpicGamesExt/PixelStreamingInfrastructure/releases/tag/v4.5.2-coturn-windows
That should fix the issue, let me know if any further changes are required, but I am closing this one assuming this is all that was needed.


Different behaviour when using addKeyword and keywords in options

We are using ajv, for example, in the middleware, where we don't have access to the ajv instance. The preferred way to configure ajv is via options. There seem to be a difference between using keywords option and ajv.addKeyword. See the runnable examples below.
What version of Ajv are you using? Does the issue happen if you use the latest version?
6.12.6
Ajv options object

const ajv = new Ajv({
  allErrors: true,
  keywords: { typeof: typeofKeyword }
})

OR

const ajv = new Ajv({
  allErrors: true,
})

JSON Schema

{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "foo": {
      "type": "string",
      "minLength": 3,
      "maxLength": 255,
      "typeof": "number"
    }
  },
  "required": ["foo"]
}

Sample data

{ "foo": "aAa" }

Your code
I copied the source of typeof keyword from the ajv-keywords project and used it as an example.
The version with addKeyword
https://runkit.com/ttamminen/ajv-issue
The version with keywords option.
https://runkit.com/ttamminen/ajv-example

Validation result, data AFTER validation, error messages
"meta-schema not available"
[Object {dataPath: ".foo", keyword: "typeof", message: "should pass \"typeof\" keyword validation", …}]

What results did you expect?
As the end results in both ways should be the same, I expected that there will be no "meta-schema not available" error.

This is changed in v7 and won't log the warning. In v6 the default meta-schema is added after user-defined keywords, so their schema cannot be validated against meta-schema. I think the validation results are the same.
Possibly, the log can be removed by explicitly passing draft-7 meta-schema via options.

I see what you mean, in the source code the order is like you described:
if (opts.formats) addInitialFormats(this);
if (opts.keywords) addInitialKeywords(this);
addDefaultMetaSchema(this);

I think this can be closed, as this won't be an issue in the v7 and we can try passing the draft-7 meta-scheme via options.

It may be worth trying to swap the order and see if anything breaks (tests and ajv-keywords). If nothing breaks it can be merged.

In v6 I mean - as it will be around for quite some time


GHA: Clean up tag workflow

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5246  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on  Graphite


⚠ ClamAV has degraded performance

In c7f321b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in dfd5d33.


Distributive health checks for docker containers on workers

@ryane ran into some issues on a built cluster where the following containers weren't running on the host, but Consul showed no errors. We should probably be making sure they're running on our workers!

nginx-consul - all nodes
logstash - all nodes
haproxy - worker nodes

Closed in #959


Optimization in checking that reads are done

In WorkerPool this code should use early return of false rather than accumulate a check:
fun areAllDone(): Boolean {
    var allDone = true
    for (task in runQueue) {
        allDone = allDone and task.isDone
    }
    return allDone
}

Early return here is both more performant, and easier to read and understand.
Also, review awaitCompletion, and also consider early return there.

Bonus: this also raises coverage.


Docs: issue-3501: reorganize updated IoT docs

Type of change
Documentation
Description
Follow on to PR #3447: reorganize new IoT docs
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[X] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Can one of the admins verify this patch?

Local docs build: http://file.rdu.redhat.com/~jmalloy/openshift/#iot-getting-started-messaging-iot-iot

@dejanb, I pushed edits to address your comments. Can you review again/approve? Thanks!


Adding and use another component beside BlazorUI

Hello Dear support team
Is there a way to add and use another component library beside BlazorUI in the  cross platform solution?
For example Antblazor or Radzen.
Where should I add Services
builder.Services.AddRadzenComponents();
Where to add what should be added to App.razor within the < head > element for example this line
<RadzenTheme Theme="material" @rendermode="InteractiveAuto" />
Where to add what should be added to MainLayout.razor for example this line
<RadzenComponents @rendermode="InteractiveAuto" />
Where should I add scripts
Should I add them to the core project ?

@zandiarash thanks for contacting us.
Achieving what you expressed is straightforward and can be done in normal ways available in Blazor projects.
But you can search for the Bit.BlazorUI in the source code and find the places we used references to this library.
for example, you can add builder.Services.AddRadzenComponents() to the IClientCoreServiceCollectionExtensions.cs file in the client core project as we did for services.AddBitBlazorUIServices().
for the other components, I'm not familiar with that specific component and you should follow their own documents.

@zandiarash thanks for contacting us. Achieving what you requested seems straightforward and can be done in normal ways, which are available in Blazor projects. But you can search for the Bit.BlazorUI in the source code and find the places we used references to this library.
for example, you can add builder.Services.AddRadzenComponents() to the IClientCoreServiceCollectionExtensions.cs file in the client core project as we did for services.AddBitBlazorUIServices().
for the other components, I'm not familiar with that specific library and you should follow their own documents.

Thank you @msynk the key was the IClientCoreServiceCollectionExtensions file and since I've added styles and scripts in Index.html files that works well.
Actually Bit.BlazorUI is kind of a mature library but DataGrid has not some features for example does not supports dynamic data support that was the reason I've added Radzen.
By the way thanks for the fast and usable response.

@zandiarash thanks for contacting us. Achieving what you requested seems straightforward and can be done in normal ways, which are available in Blazor projects. But you can search for the Bit.BlazorUI in the source code and find the places we used references to this library.
for example, you can add builder.Services.AddRadzenComponents() to the IClientCoreServiceCollectionExtensions.cs file in the client core project as we did for services.AddBitBlazorUIServices().
for the other components, I'm not familiar with that specific library and you should follow their own documents.

Thank you @msynk the key was the IClientCoreServiceCollectionExtensions file and since I've added styles and scripts in Index.html files that works well.
Actually Bit.BlazorUI is kind of a mature library but DataGrid has not some features for example does not supports dynamic data support that was the reason I've added Radzen.
By the way thanks for the fast and usable response.


feat(linter): add max_len rule

Change it to draft because of not ready yet. 😉

Change it to draft because of not ready yet. 😉

Okay, I'm currently preparing for a job search and I don't have much time. I'm sorry.

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

Thank you very much for your reply. I really want to contribute to the code, so thank you. I closed this PR because I found that the workload involved is quite large, and there are some issues I don't understand and can't find someone to solve, so I want to close it first. When I was implementing the max-len rule, I encountered two problems: 1. The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed. 2. It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

I'm going to check out the issue you mentioned now.

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

If you are busy but still want to contribute to our repo, this issue may more suitable for you than this rule.🤔

Thank you very much for your reply. I really want to contribute to the code, so thank you. I closed this PR because I found that the workload involved is quite large, and there are some issues I don't understand and can't find someone to solve, so I want to close it first. When I was implementing the max-len rule, I encountered two problems:

The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed.
It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

Haven't gotten too far. If you have feel free to finish it!

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

I haven't started yet, so I'll continue researching max len.

I'm going to check out the issue you mentioned now.

Are you working on it now? The author of this rule(@todor-a) is also planning to do it. My bad, I should have confirmed it first.

Haven't gotten too far. If you have feel free to finish it!

I haven't started yet, so I'll continue researching max len.

The fn from_configuration() method that each rule has should merge the default values and the configuration values, but I can't find where it is executed.

Are you looking for this?

https://github.com/oxc-project/oxc/blob/8662f4f61360ccfca403a90d436dbf51bf126bdb/crates/oxc_linter/src/config/mod.rs#L99-L100
https://github.com/oxc-project/oxc/blob/8662f4f61360ccfca403a90d436dbf51bf126bdb/crates/oxc_macros/src/declare_all_lint_rules/mod.rs#L101-L107

It is necessary to use AST to parse the code, such as determining comments. Can I directly use the AST of oxc to scan here?

What's specific problem are you facing?

where this rule receives user option values from.

https://github.com/oxc-project/oxc/blob/63b4741ff3eb3a00a6b5565caddc58f244b4fae6/crates/oxc_linter/src/options.rs#L226
then it call:
https://github.com/oxc-project/oxc/blob/63b4741ff3eb3a00a6b5565caddc58f244b4fae6/crates/oxc_linter/src/config/mod.rs#L99
The config of this rule are in rule_config.config
rule_config.config are parsing from config file:
https://github.com/oxc-project/oxc/blob/63b4741ff3eb3a00a6b5565caddc58f244b4fae6/crates/oxc_linter/src/config/rules.rs#L51

@mysteryven Hi, I have passed all the eslint tests regarding max-len, except for JSX. I'm not sure how to implement it for JSX yet, as the current AST in oxc seems unable to read JSX comments. I need to think about how to approach this. If you have any good suggestions, feel free to advise.

It's a really nice work! I need some time to take a close look at it, will give you feedback tomorrow.

It's a really nice work! I need some time to take a close look at it, will give you feedback tomorrow.

Thank you for your response. If I have some free time in the next few days, I will try to add support for JSX.

You can run just ready in your local to fix the Clippy error.

@mysteryven   I ran the benchmark on the forked repository, is it working properly now?

The CodeSpeed Performance Analysis shows has 6.5% decrease, there is a tool to debug it: https://oxc-project.github.io/docs/contribute/performance.html, good luck to you :)

The CodeSpeed Performance Analysis shows has 6.5% decrease, there is a tool to debug it: https://oxc-project.github.io/docs/contribute/performance.html, good luck to you :)
Everything seems good to me overall! Didn't merge it because it will more convenient to observe the performance.

Okay, I'll look into it after I implement the JSX feature. I'm a Rust beginner, so I don't understand much about performance. I need your help to review it more, thank you.

@mysteryven Hi, JSX support has been added, and all tests have passed. Please help to review the code again.

@mysteryven Are there any other tasks I can work on? If not, I will check if there are any additional rules I can add for ESLint or Prettier.

I will check if there are any additional rules I can add for ESLint or Prettier.

Try a new ESLint rule or any issue you like!

I think we need to solve the performance issue, it decreases a bit large, I'll help to check the reason when I free.(usually at night :<), do you have discord account, you can add me mysteryven, we can discuss it.

I will check if there are any additional rules I can add for ESLint or Prettier.

Try a new ESLint rule or any issue you like!
I think we need to solve the performance issue, it decreases a bit large, I'll help to check the reason when I free.(usually at night :<), do you have discord account, you can add me mysteryven, let's discuss it!

Ok, I have sent a friend request.


Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?

There are warnings on app start:
2018-03-05 21:10:33.505 [warn][tid:main][RCTBridge.m:120] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2018-03-05 21:10:33.505169+0700 AwesomeProject[23617:4551316] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?

Environment
Environment:
  OS: macOS High Sierra 10.13.3
  Node: 9.7.1
  Yarn: 1.5.1
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
  react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
  react-native: 0.54.0 => 0.54.0

Expected Behavior
No warnings.
Actual Behavior
There are warnings.
Steps to Reproduce

react-native init AwesomeProject
Open ios/AwesomeProject.xcodeproj
Run the app and look at the output.
There will be warnings among first several lines.

I've tested several versions back (0.49) and the issue is there as well.

Sample project
https://github.com/vshab/react-native-0.54-run-warning

I'm having the same issue when I upgraded to RN 0.54.

I have this issue too.  If I reload the app in the simulator the warning goes away.

Same as @leejones45, getting this error after upgrading and only on first load.

Same with me
react-native: 0.55.1

Same with me
react-native: 0.55.2

Same here
react-native: 0.55.3

Same here with react-native: 0.55.3. Seems it happens after upgrade react-native to a version > 0.54.

Also seeing this with react-native 0.55.3.

This is a duplicate of #14806
It's a harmless issue and you can ignore it, but quite confusing when you encounter it at first. Sadly it seems that nobody had the time to fix this yet.

Me too in<EMAIL_ADDRESS>

me too

me too

me too

me too

Any update on this issue? I know it's harmless but it still bothers me

The message should be removed if it's really an issue.  Or FB needs to fix the condition that checks for whatever it is this is trying to check for.

Any update on this?
When I want to run on device, I need to have RCTNetwork.xcodeproj and RCTWebSocket.xcodeproj manually linked but when I archive my app I have to delete both and add this code to my pod file and run pod install :
 pod 'React', :path => '../node_modules/react-native', :subspecs => [
    'DevSupport',
    'CxxBridge',
    'RCTNetwork'
 ]

Otherwise I have errors. I also upgrade react-native to 55.3 from 51.

Dear Mr bot,
This occurs with RN 0.55.3 and probably any newer version.

same with me in<EMAIL_ADDRESS>

So what is the solution then ?

@frayhan32 For now it's not the best solution, but to avoid the warning we can ignore it:
import { YellowBox } from 'react-native';
YellowBox.ignoreWarnings(['Class RCTCxxModule']);

I haven't proven my theory but I just started getting this (and the "RCTImageLoader requires main queue setup") and the only change I made was to use YellowBox (as per prev comment) instead of the old console.ignoredYellowBox method.

pod 'React', :path => '../node_modules/react-native', :subspecs => [     'DevSupport',     'CxxBridge',     'CxxModule', #missing it     'RCTNetwork'  ]

@charlot567 Note that same method is used to prevent the "isMounted(...) is deprecated" yellow box appear in
https://github.com/react-navigation/react-navigation/issues/3956
They persist in<EMAIL_ADDRESS>

This is a duplicate of #14806 so I'll close and lock this to avoid spam/useless comments


Response: invalid key supplied

Using knife-push (0.9.0 3875cf2):
$> bundle exec knife job start chef -s 'chef_environment:X AND name:data-i*' --timeout  30000 --quorum 1%
ERROR: The data in your request was invalid
Response: invalid key supplied

Here is the verbose output:
DEBUG: ---- End HTTP Status/Header Data ----
DEBUG: ---- HTTP Response Body ----
DEBUG: {"error":"invalid key supplied"}
DEBUG: ---- End HTTP Response Body -----
DEBUG: ---- HTTP Request Body ----
DEBUG: {"command":"chef","nodes":["data-i-82685544"],"capture_output":false,"quorum":1,"env":{},"run_timeout":30000}
DEBUG: ---- End HTTP Request Body ----
DEBUG: Chef::HTTP calling Chef::HTTP::ValidateContentLength#handle_response
DEBUG: Content-Length validated correctly.
DEBUG: Chef::HTTP calling Chef::HTTP::RemoteRequestID#handle_response
DEBUG: Chef::HTTP calling Chef::HTTP::Authenticator#handle_response
DEBUG: Chef::HTTP calling Chef::HTTP::Decompressor#handle_response
DEBUG: Chef::HTTP calling Chef::HTTP::CookieManager#handle_response
DEBUG: Chef::HTTP calling Chef::HTTP::JSONToModelOutput#handle_response
DEBUG: Expected JSON response, but got content-type ''
DEBUG: Chef::HTTP calling Chef::HTTP::JSONInput#handle_response
INFO: HTTP Request Returned 400 Bad Request: error
/Users/scalp/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http/response.rb:119:in `error!': 400 "Bad Request" (Net::HTTPServerException)
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/http.rb:145:in `request'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/http.rb:126:in `post'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bundler/gems/knife-push-3875cf29c77c/lib/chef/knife/job_helpers.rb:96:in `run_helper'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bundler/gems/knife-push-3875cf29c77c/lib/chef/knife/job_start.rb:106:in `run'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/knife.rb:405:in `block in run_with_pretty_exceptions'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/local_mode.rb:44:in `with_server_connectivity'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/knife.rb:404:in `run_with_pretty_exceptions'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/knife.rb:203:in `run'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/lib/chef/application/knife.rb:142:in `run'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/gems/chef-12.5.1/bin/knife:25:in `<top (required)>'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bin/knife:23:in `load'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bin/knife:23:in `<main>'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bin/ruby_executable_hooks:15:in `eval'
	from /Users/scalp/.rvm/gems/ruby-2.2.1@gzbot/bin/ruby_executable_hooks:15:in `<main>'

Works fine with v0.5.2.
Any idea?

Still happens

anyone solved this ?

Resolution would be great?

In our environment that was caused because of using knife push gem 1.0.0 against older push jobs server version. Downgrading knife-push gem to 0.5.2 solved the issue

List of versions published: https://rubygems.org/gems/knife-push
After running
gem install knife-push -v 0.5.2
knife rehash

now knife job start works with warning
WARN: Chef::REST is deprecated. Please use Chef::ServerAPI, or investigate Ridley or ChefAPI. at chefdk/gem/ruby/2.1.0/gems/knife-push-0.5.2/lib/chef/knife/job_start.rb:84:in `new'

but knife job status fails with:
chefdk/gem/ruby/2.1.0/gems/knife-push-0.5.2/lib/chef/knife/job_status.rb:24:in `run': uninitialized constant Chef::REST (NameError)

How can I diagnose this further?
Thanks

This attached diff fixes the error above for v0.5.2
rest.txt

Reverting back to 0.5.2 with this patch does push jobs working.

I also met this error. I think the problem is invalid keys in the request body.
I just output the job_json hash
{"command"=>"chef-client", "nodes"=>["client"], "capture_output"=>false, "quorum"=>1, "env"=>{}} ERROR: The data in your request was invalid Response: invalid key supplied
Checking the Push Jobs API, the request body only has "command" and "nodes". So what I did was remove "capture_output", "env".

@afiune Would you tag/release v0.5.3 if patch is submitted? Thanks

I just merged a patch to master in #46 to support both 1.0 and 2.0 push jobs servers. I'll be doing a gem release of 1.0.1 shortly.

After upgrading to 1.0.1 , i get this message :
"WARNING: Falling back to Push Jobs v1 mode."
but the jobs run fine. Is there anything else i need to upgrade ??

@anastazya that is correct behaviour when connecting to a 1.0 server.

@thommay - Thank you, and great job with version 1.0.1 . Other that the warning, works great so far .

Thanks for fixing this.
How do you know if you have v1 or v2 push jobs server? My chef server is fully up to date, but I'm still getting the "Falling back to Push Jobs v1 mode" warning.

2.0 hasn't been released yet, so unless you explicitly installed something or built it from source, you have 1.0. At present I'd expect almost everyone to see that warning.


sometestchange

This is a test comment

[test] please ?

[test] please?

[test] please?

[test] This shouldn't work but lets try it!

This is a regular comment that should not cause any tests to run because it doesn't include the test string

[test] that again!

Dont test anything with this comment!

[test] this still shouldn't work!

[test] Lets test this one more time!

What about this?


Effect

Hi, do you have a plan already for modelling Effect? The FFI doesn't mention it yet.
Perhaps you plan to add it to the FFI?
Or else, perhaps you might use a tagged approach where the Effect type is a tagged initial free-monad style thing and then it just returns constructors which a user of dovetail could interpret?
Thanks.

There are a few intersecting issues here that I need to write up: a) effects, b) supporting the core library set, and c) delimited contuinuations. I don't have a concrete plan yet, but I expect I'll probably implement Effect in a separate dovetail-effect library, since there's nothing in the compiler really specific to Effect above the corefn level, so nothing special to support that can't be delegated to a library.
I'm not sure if I want to just keep it simple and offer a barebones do-everything IO monad like PureScript's current Effect, or take the opportunity now that I have an interpreter to revisit the old row-typed effects idea. That would fit nicely with my plan to implement delimited continuations, but would make things more complicated.
I also do want to support purescript-effect along with the other core libraries, so I think the best option is to build this in the context of support for the core libraries, which will be my next big project, and then to add delimited control as FFI primitives separately so that I can build a row-typed effect library on top.

Thanks, I'll keep watching this space.


Unable to build on Indie license due to profiling

The currently latest version https://github.com/awolf/Xamarin-Forms-InAnger/commit/85bc4c07b977927690df50160e269b0d6e091fae
doesn't build on my machine, apparently due to my Indie license not being good enough for the compiler flags :P

I'll have to switch that off and commit the new version. Can you just turn off that option and try to compile?

Yep, works. :)

I have removed the profiling from the iOS project.


Allow boundary_key to be callable

Includes #41. I need to slugify the boundary's name for it to match the division's type_id.

@jamesturk My pulls ain't in progress - they be DONE!


Part on "Model Theory"

The part on model theory has very nice proofs of interpolation/definability and Lindström's theorem, but the earlier sections on basics of model theory have to be expanded significantly, both in terms of coverage and in terms of the presentation of what's already there: much more explanation and motivation.

I am teaching a yearlong master-level sequence in model theory this year ; thus I am teaching the basics as well. I am happy to handle the model theory section, therefore.


Fix code scanning alert - Extracting archives should not lead to zip slip vulnerabilities

Tracking issue for:

[ ] https://github.com/webforj/webforj/security/code-scanning/1

closed through #526


Should we temporarily remove the Sternfahrt feature?

While we probably all agree this is a feature that should be included, right now it has some problems:

long initial dynamic generation
impact on performance
only relevant to berlin

In a short discussion with @ligi we agreed, that we all should probably put some thought in redesigning the feature (different cities, only specific routes, ...). I proposed temporarily removing the feature until this is sorted out, but ligi correctly pointed out that this might confuse users.
So, any thoughts about that?

see #103

i was thinking about adding another fragment for settings. in that fragment we can have a more complex menu structure for enabling or disabling route overlays. this would make it possible to add more ADFC routes or even bicycle highways for example.
one thing that would also significantly improve performance would be thinning out the coordinates to have a minimum distance of ~3 m or so. back then they were waaaaaay to accurate.
what do you think?
are you guys on board with adding another branch on the main repository to get started with this?


Round seconds instead of truncating to int

This adds 2 ops that will be run for every progbar update (int cast and np.round), and doesn't add any clear usability benefits (sub-second accuracy in ETA is not necessary). For performance reasons, we won't merge it.

@fchollet, oops, sorry, this PR got garbled after merging with master. Please reopen it, I've already committed what I actually meant into this branch.
Sub-second accuracy in ETA is not necessary, unless the ETA is subsecond to begin with. For example, if 0.5  < ETA < 1.0. Also, in this case (say 10 steps, 0.1 sec each) , without this PR, ETA (0 sec) will be inconsistent with total time (1 sec).

@fchollet, Performance-wise, the two are indistinguishable and minuscule (I am impressed):
$ python -m timeit '"%d"%0.5'
100000000 loops, best of 3: 0.0104 usec per loop

$ python -m timeit '"%.0f"%0.5'
100000000 loops, best of 3: 0.0104 usec per loop

What, actually, bothers me more is that the standard Python rounding is towards even, while in this case we want to round towards nearest, since we don't care about it being unbiased, and care more about, say 1.5 <= ETA <2.5 rounding to 2. But I wasn't sure is extra complexity of this better rounding would be worth it.

For the reference the 'garbled' PR could have been rewritten like so (there is no need for np.round()):
$ python -m timeit -s 'round(1.5 * (2 - 1))'
100000000 loops, best of 3: 0.0126 usec per loop


DOCS - mixed charts > multiple Y-axis sample not showing

Description

mixed-charts/multiple-yaxis/
sample chart provided in docs aren't generated
console :
Uncaught (in promise) TypeError: i is undefined
    u https://cdn.jsdelivr.net/npm/apexcharts:6
    value https://cdn.jsdelivr.net/npm/apexcharts:6
    value https://cdn.jsdelivr.net/npm/apexcharts:6
    value https://cdn.jsdelivr.net/npm/apexcharts:14
    value https://cdn.jsdelivr.net/npm/apexcharts:6
    value https://cdn.jsdelivr.net/npm/apexcharts:14
    value https://cdn.jsdelivr.net/npm/apexcharts:14
    componentDidMount https://cdn.jsdelivr.net/npm/react-apexcharts@1.3.6/dist/react-apexcharts.iife.min.js:1
    React 11
    anonymous https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.min.js line 3 > Function:158
    run https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.min.js:3
    l https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.min.js:3
    i https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.min.js:3
[apexcharts:6:35466](https://cdn.jsdelivr.net/npm/apexcharts)

Steps to Reproduce
Expected Behavior
Actual Behavior
Screenshots

Reproduction Link

This has been fixed. See #4382


remove the computation of the grid from this repository

close this issue when it will be fully moved to https://github.com/openforis/import-ee

Instead of removing it, I improved it and removed the huge csv file from the repository


Create testing/staging DB

For not fooling around with the original DB we should have a dev version. So we also could link the vercel function during development.

[ ] Should maybe have reset every week (or day) and sync to the original one.
[ ] Should be automated using github actions

This might help https://gist.github.com/fabianmoronzirfas/b331f2869c799d6f41e5bd72ef668a6e

test DB is already running --> can this issue be closed @ff6347 ?

yes. We still don't have a proper way to provision a new DB but this is another thing.


Note that aiohttp.web can be used in production

Users coming from Flask, Django, and Bottle anticipate special
instructions about deployment. Closes #234.

Sorry, no.
aiohttp is not multi-threaded but it is asynchronous.
That means the aiohttp (as well as asyncio) has lightweight tasks, which are executed in parallel by event loop.
Tornado and Twisted does the same (in not so user-friendly manner).
gevent and eventlet have a different way, both uses greenlet technique -- but they are also single-threaded with lightweight threads.

You're right of course. I forgot asyncio used lightweight tasks.

Is your point that aiohttp.web is a webserver itself and does not requires any WSGI proxies?
But for production you are likely need to hide your server under reverse proxy / load balancer umbrella.
So your tip should have a link to "Deployment" chapter (not present for now, but you may create ./docs/deployment.rst for those).

Yes -- that's what I'm trying to get at. You just need a reverse proxy, no WSGI wrapper à la bottle/flask/django. I think we're talking about the same thing.

Deployment chapter is absent.
You are the first person who asked for this.
If you would like to create ./docs/deployment.rst and write Deployment instructions --- your are welcome.
If not -- I'll do it sometimes.
Anyway, thanks for request.

I think we should add paste deploy template

+1
On Wed, Jan 14, 2015 at 6:45 PM, Nikolay Kim<EMAIL_ADDRESS>wrote:

I think we should add paste deploy template
—
Reply to this email directly or view it on GitHub
https://github.com/KeepSafe/aiohttp/pull/237#issuecomment-69947242.

--
Thanks,
Andrew Svetlov

close as stale

Arrived here after having searched for best practices for deploying and running aiohttp in production. Does anyone have any pointers, articles I should read, projects I should look up et c?

@richardolsson: Not real doc, the stuff more closer as production environnement is API-Hour starter kit: https://github.com/Eyepea/cookiecutter-API-Hour
It's API-Hour+aiohttp.web oriented, nevertheless, the config files are interesting for a production usage: https://github.com/Eyepea/cookiecutter-API-Hour/tree/master/{{cookiecutter.app_name}}/etc
Especially init.d script and logrotate config file.

I use gunicorn+pastedeploy with aiohttp.web worker. There are plenty of documentation how to deploy with pastedeploy


[BUG] High memory consumption

Describe the bug
We are using aws opensearch and since upgrading from 2.11 to 2.15, the memory usage increased and it slows down the whole cluser.
The biggest impact is on write operations which started to timeout after the upgrade.
I've seen this issue but I thought that the issue was supposed to be fixed in 2.15.
Upgrade happened on the 10th.
Max memory utilization more than often reaches 100% since then.

There is also an increase in Java Heap memory

Any idea ? Thx !
Related component
Other
To Reproduce

Upgrade to 2.15

Expected behavior
No issue when inserting data and lower memory consumption
Additional Details
No modification on our side on memory settings

@Mavtti by any chance, could you capture class histogram to understand where the heap consumption is coming from? Thank you.

@reta Sorry I never had to do it before, would you mind explaining me how to do it ?
Btw, to mitigate the issue, we changed our instances type from t3 to m7g. It gave us more leeway.
But at the same time, we also saw an issue with an ever increasing memory just like this case.

@reta Sorry I never had to do it before, would you mind explaining me how to do it ?

Thanks @Mavtti , there are multiple ways to do that (we just need to do this on any node that consumes more heap):

using jcmd (https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/tooldescr006.html)

jcmd <pid> GC.class_histogram

using jmap (https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/tooldescr014.html)

jmap  -histo <pid>

Hey since I'm on managed aws opensearch, there is no way for me to run these commands.
And I saw that the jackson issue was supposed to be fixed but we actually are on 2.15 (OpenSearch_2_15_R20240904 to be exact) and still see this issue.

Hey since I'm on managed aws opensearch, there is no way for me to run these commands.

Got it :(

And I saw that the jackson issue was supposed to be fixed but we actually are on 2.15 (OpenSearch_2_15_R20240904 to be exact) and still see this issue.

Correct, the heap consumption might be caused by another issue

So in the end, I can't give you more insight and there's not much you can do without it, correct ?

So in the end, I can't give you more insight and there's not much you can do without it, correct ?

I think the best option we have is to engage with AWS support to ask for these details

Let's close it here. Do post what you find through working with AWS support please for the next person.
[Catch All Triage - 1, 2,  3,  4]


Infra work for bulletproof Apple account usage

Recommendation from Andrew Schwab after confirming Twilio numbers are detected:

Create a Google Group (I'd recommend something like ipfs-apple-id@)
Create an Apple ID with that group email
Document the Apple ID email login and reset question in 1Password in a shared vault
Setup the phones for members of the group for SMS 2FA
Add a note in 1Password indicating whose phones are currently connected

So we need to determine if we need to create new Apple ID or switch existing account @olizilla has created to use the new email alias.
From my previous iOS work, I think it depends on how @olizilla set the account up. A real pain to move stuff between accounts, and accounts have a lot of personal detail and config (at least in the US).

@rafaelramalho19 -- can you please prioritize this over the loading indicator work? Thank you!

I've followed the steps but apparently there was a problem creating the account in the last steps 😕

Followup: looking into solving this using Apple Developer Program for Organizations capabilities.

@andyschwab -- just checking in on what you've learned? Thanks!

@jessicaschilling - identified the solid path forward, but currently on hold until we can use the best account to setup a Developer Program Organization and update permissions accordingly. I'll continue to track this and action as soon as it is unblocked.

Awesome, thanks @andyschwab! I'll move out of our in-progress queue until you tell me otherwise.

I believe this is done, migrated new secrets from Travis to Github Actions.


Avoid launching CLI option on certain cases

When you are using the grunt task, it launches also the cli option
This is because the bin is defined on the package.json
"bin": {
    "git-changelog": "tasks/command.js"
  },

This causes that it executes it 2 times..

Fixed in 0.1.6


Add support for sparse accessors

Opening this as a draft for addressing https://github.com/CesiumGS/cesium/issues/10284
Description
The cx20 gltf-test repo is an invaluable resource for checking the compatibility of glTF viewers with the glTF specification. CesiumJS is among the ones with the larger number of ✅'s. But there is still that SimpleSparseAccessor example, which uses a pretty fundamental glTF concept - namely, sparse accessors - that shows a ❌...
This PR is a DRAFT, and the state is kinda messy, but it already loads that sample:

A summary:
A sparse accessor is an accessor that has a sparse property. The sparse object contains two objects, namely indices and values. These are actually "small accessors": They refer to a bufferView and have a byteOffset, one has a componentType. The type is taken from the containing accessor.
The loadFromBufferView function of GltfVertexBufferLoader checks whether the accessor whose data is supposed to be loaded has the sparse property. If it does, then it calls handleSparseAccessor, which does the main work:

The function calls a new function loadDependencyBufferViewTypedArray which loads the required buffer views for the indices and values
These buffer views are used for creating typed arrays of the indices and values. (This is a bit quirky - see notes below...)
The handleSparseAccessor finally performs the sparse substitution. It just writes the substituted values into the typed array of the original accessor data. The pseudocode for that is just accessorData[indices[i]] = values[i].

TODO:
The functionality for creating typed arrays from buffer views (based on "accessor information") is required elsewhere - namely, for standard index- and attribute accessors After all, the indices and  values from the sparse object basically are just "accessors". For now, I just added some helper functions like GltfIndexBufferLoader.createIndicesTypedArrayFromBufferViewTypedArray for that 🤪 It's not clear what could be the best place for offering these. They could be standalone functions, or maybe 'static' functions in GltfLoader ...?
Beyond that: Tests, tests, tests, comments, comments, comments, ....
Issue number and link
https://github.com/CesiumGS/cesium/issues/10284
Testing plan
Load the SimpleSparseAccessor model (and other models with sparse accessors), and check that they are displayed properly.
Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[ ] I have updated CHANGES.md with a short summary of my change
[ ] I have added or updated unit tests to ensure consistent code coverage
[ ] I have updated the inline documentation, and included code examples where relevant
[ ] I have performed a self-review of my code

After having spent a considerable amount of time trying to wrap my head around what is happening in the GltfLoader, a short "heads up": At https://github.com/CesiumGS/cesium/blob/47b5d295facaca795381bf607b78cc60c643fd85/packages/engine/Source/Scene/GltfLoader.js#L1944 , a possible Draco-compression is detected. This draco object is passed down the whole call chain. At many places of this call chain, the code behaves completely differently, depending on whether that draco object is defined or not. And at several places, the behavior is plainly wrong, including the (several) places where the message

One of options.bufferViewId and options.draco must be defined.

that is emitted (as mentioned in the issue). I'd try to break up a few things here, and along the way, would try to add some documentation. And ... that sparse accessors thing ("Hal changing a light bulb") - I'll try to keep that in mind.

I thinkt that it is not possible to add support for sparse accessors without a considerable refactoring of the glTF loader infrastructure. This means that adding support for sparse accessors is not a that "low-hanging fruit" that I expected it to be, given that they are actually a fairly trivial feature of glTF that, at its core, can be implemented with a few lines of code.


Surprise dependency - Map controls broken without ol.css from v6.2.0 onwards.

Describe the bug
From v6.2.0 onwards Dragging and mouse wheel zooming will no longer work unless ol.css is also loaded.
To Reproduce
Included example works correctly only with stylesheet link included.
<html>
	<head>
		<title>CSS dependency example</title>
		<script src="https://cdn.polyfill.io/v2/polyfill.min.js?features=fetch,requestAnimationFrame,Element.prototype.classList,URL"></script>
		<link rel="stylesheet" href="https://openlayers.org/en/latest/css/ol.css">
		<script                 src="https://openlayers.org/en/latest/build/ol.js"></script>
	</head>
	<body>
		<div id="map" class="map"/>
		<script>
			var centre = ol.proj.fromLonLat([1,51]);
			var map = new ol.Map({
				view: new ol.View({
					center: centre,
					zoom: 10
				}),
				layers: [
					new ol.layer.Tile({
					source: new ol.source.OSM()
					})
				],
				target: 'map'
			});
		</script>
	</body>
</html>

Expected behavior
No dependency on css for basic panning and zooming functionality, as was the case before 6.2.0.
Suggestion
If this hard requirement for paired css is here to stay, can the 6.2.0 release notes / getting started guide / examples reflect this more explicitly please? Current examples such as the Interaction Options example don't reflect this yet.
I'm happy to muck in with documentation edits if desired by the team. Let me know what you think?

This is a valid concern @StereoPythonics. I created #10936 to make these basic interactions work without loading ol.css again.

Looks great, example now works fine with latest without ol.css. Many thanks for your efforts, I look forward to the 6.3.2 release!


Command line cleanup

Cleanups to the invocation of clang-tidy and the static analyzer:

There can be only one resource dir.
Do not add resource dir as include path.
Made the code more compact.

This change is mainly for better signal to noise ratio, so the code is easier to read, the arguments are grouped nicer. I would be surprised if this part of codechecker would be a performance bottleneck. But I did a small benchmark, the difference between extending with a 2 argument list or calling append twice is about 10%.