legal terms not accepted

When trying to run this I get:

azurerm_virtual_machine.PAN_FW_FW: 1 error(s) occurred:

azurerm_virtual_machine.PAN_FW_FW: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ResourcePurchaseValidationFailed" Message="User failed validation to purchase resources. Error message: 'Legal terms have not been accepted for this item on this subscription. To accept legal terms using PowerShell, please use Get-AzureRmMarketplaceTerms and Set-AzureRmMarketplaceTerms API(https://go.microsoft.com/fwlink/?linkid=862451) or deploy via the Azure portal to accept the terms'"

azurerm_virtual_machine_extension.PAN_FW_WEB_EXT_MIN: 1 error(s) occurred:

azurerm_virtual_machine_extension.PAN_FW_WEB_EXT_MIN: azure#WaitForCompletion: context has been cancelled: StatusCode=200 -- Original Error: context deadline exceeded

Seems linked to https://github.com/terraform-providers/terraform-provider-azurerm/issues/1283

Hello @khushil
Yes this is expected. The issue here is that when are trying to spin up a market place entity for the first time on Azure, you will always have to manually deploy and accept the Market Place Terms.  Once you have done that, you don't need to worry about it for all subsequent invocations and usage of the market place item.
Hope this helps.
Thanks,

Hi @vinayvenkat,
could you clarify the approach that you suggested ? I had one firewall instance deployed manually (and I've signed the terms&conditions), and all the consecutives deployments via terraform were still failing with the error that @khushil raised in the beginning. Did you find out some alternative solution to this issue, that would make it work also for very first firewall deployment ?
Thanks in advance for help !
Marcin


Guide on how to use TensorRT-LLM Backend

Feature request
Does any documentation exist, or would it be possible to add documentation, on how to use the TensorRT-LLM backend? #2458 makes mention that the TRT-LLM backend exists, and I can see that there's a Dockerfile for TRT-LLM, but I don't see any guides on how to build/use it.
Motivation
I would like to run TensorRT-LLM models using TGI.
Your contribution
I'm willing to test any builds/processes/pipelines that are available.

Hi @michaelthreet 👋
Very good questions. And indeed we haven't yet documented that well how the new backend design works. Basically the best guide is looking at the info in the dockerfile.
But I'll loop in @mfuntowicz, he can better show you in the right direction and point what are the system requirements 👍

Hi @michaelthreet - thanks for your interest in the TRTLLM backend.
The overall backend is pretty new and might suffer from edge cases not being handled but it should be usable.
I would advise to move to this branch which refactor the backend to avoid all the locks and improve the overall throughput (significantly)
➡ https://github.com/huggingface/text-generation-inference/pull/2357
As I mentioned, the overall backend is still WIP and I would not qualify it as "stable" so we do not offer prebuild images yet.
Still, it should be fairly easy to build the docker container locally from the TGI repository:
docker build -t huggingface/text-generation-inference-trtllm:v2.1.1 -f backends/trtllm/Dockerfile .
Let us know if you encounter any issues for building 😊.
Finally, when you've got the container ready, you should be able to deploy it using the following:
docker run --gpus all --shm-size=16gb -v <host/path/to/engines/folder>:/repository --tokenizer-name <model_id_or_path> /repository
Please let us know if you encounter any blocker, more than happy to help and get your feedback

Awesome to hear it build successfully and cool you were able to figure out the required adaptations 😍.
Effectively, TensorRT-LLM engines are necessary not compatible from one release to another 🤐
You can find the exact TRTLLM version we are building against here: https://github.com/huggingface/text-generation-inference/blob/main/backends/trtllm/cmake/trtllm.cmake#L26 - we should more clearly document this and potentially give a warning if a discrepency is detected when loading the engine to better inform the user - adding to my todo.
The commit a681853d3803ee5893307e812530b5e7004bb6e1 might correspond to TRTLLM 0.12.0.dev2024073000 if I'm not mistaken
Please let me know if you need any additional follow up

I was able to get it to load the model by building a TensorRT-LLM model (Llama 3.1 8B Instruct for reference) using that matched TRTLLM version (0.12.0.dev2024073000) and the TRLLLM llama example.
When I send requests to the /generate endpoint, however, I'm getting some odd behavior. For example:
curl -X 'POST' \
  'http://localhost:3000/generate' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "inputs": "My name is Olivier and I"
}'

{
  "generated_text": " them"
}

Argh, interesting... I'm developping with the same model and haven't got this output
Anyway going to dig tomorrow morning and will report here, sorry for the inconvenience @michaelthreet

No worries! If you could share the model you're using (or commands you used to convert it) that might help as well. It could be that I missed a flag/parameter in the conversion process.

Some (hopefully useful) followup: It looks like the /generate path is only returning the final token in the generated_text field. The same thing also happens when using the /v1/chat/completions path when setting the stream parameter to false instead of true. I've also noticed that finish reason is always set to eos_token even when hitting the max_new_tokens limit.

    }
  ],
  "model": "tgi",
  "stop": null,
  "temperature": 0.01,
  "stream": false
}'

{
  "object": "chat.completion",
  "id": "",
  "created":<PHONE_NUMBER>,
  "model": "/repository/tokenizer",
  "system_fingerprint": "2.2.1-dev0-native",
  "choices": [
    {
      "index": 0,
      "message": {
        "role": "assistant",
        "content": " because"
      },
      "logprobs": null,
      "finish_reason": "eos_token"
    }
  ],
  "usage": {
    "prompt_tokens": 0,
    "completion_tokens": 1,
    "total_tokens": 1
  }
}

Sorry for the delay @michaelthreet, I've got sidetracked by something else.
Going to take a look tomorrow, thanks a ton for the additional inputs.
Reporting here shortly 🤗


Differences in the value of the rand function between Monitor and pipeline execution

Hello team,
I am an Azure Data & AI CSS support engineer.
Regarding the rand function, the value seen in Monitor on ADF Studio is different from the value used in the actual pipeline execution. We would like to add a note about this as a precaution.
My customer feels the same way.
Thank you.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 76e31411-f1a2-710b-94c0-39acf9e7314b
Version Independent ID: d5cefffe-dee0-2d2e-f3cb-8eefd5d40d17
Content: Expression and functions - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/control-flow-expression-language-functions.md
Service: data-factory
Sub-service: orchestration
GitHub Login: @kromerm
Microsoft Alias: makromer

@thirota-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

@thirota-MSFT
I've delegated this to @kromerm , a content author, to review and share their valuable insights.

fixed, merging #please-close


prog: let encoding.go support AUTO for structs

It's quite common for calls in sys/*/tests to rely on default values from descriptions. For example:
https://github.com/google/syzkaller/blob/f757a3234f43deecbf7b1af37101b8ac6dd14cd0/sys/linux/test/btf_id#L17
Parts like {AUTO, AUTO, AUTO, AUTO, 0x0, AUTO, AUTO, AUTO, 0x0} and {AUTO, AUTO, AUTO, AUTO} could well be replaced by just a single AUTO token. Syzkaller could iterate over structure members itself and just AUTO every individual field (recursively).
Currently we only support AUTO for ConstType, LenType and CsumType.
For the beginning, we can at least support it for structs with only primitive types (i.e. fail on pointers, etc.): that is, + StructType and IntType support.

https://github.com/google/syzkaller/pull/4332 should address this.


the hashtag is shown incorrectly when changing the nickname

Describe the bug

A clear and concise description of what the bug is.
Screenshots
If applicable, add screenshots to help explain your problem.

also i have no plugins installed


Add Trezor support

I'm planning on implementing Trezor support but I'm opening an issue for initial discussion and feedback before I begin coding.
This will also depend on an update to the Trezor Connect project which is being tracked by this issue: https://github.com/trezor/connect/issues/127
As far as the actual implementation, I was planning on adding a "Sign in with Trezor" button under the "Sign in with Ledger" one and essentially copying the Ledger functionality.

Hi there,
I'm having difficulty trying to sign a transaction using Trezor model T and Stellar Account Viewer.
Please review my reddit post for more details, thank you.
https://www.reddit.com/r/Stellar/comments/abynfg/send_fails_with_stellar_account_viewer/?utm_source=reddit-android

I get Error:"Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE" when I try to use Sign with BIP Path


Meteor 1.3 Cordova CORS problem with Beta 12

Hi everyone,
having a problem with CORS and Meteor 1.3 Beta 12 on iOS and Android with i18n.
The Error is the following:
iOS:
XMLHttpRequest cannot load https://app.soon.com/tap-i18n/de.json1. Origin http://localhost:12392 is not allowed by Access-Control-Allow-Origin.
Android:
XMLHttpRequest cannot load https://app.soon.com/tap-i18n/de.json1. The 'Access-Control-Allow-Origin' header has a value 'http://meteor.local' that is not equal to the supplied origin. Origin 'http://localhost:12392' is therefore not allowed access.
So both Apps can't download the json from Server. I also have set App.accessRule('*'); in mobile config but no luck.
Hope someone could help me with this problem. Btw. hosting is on Meteor Galaxy.
regards
thomas

I have the same issue. After upgrading to Meteor 1.3 I can't get my apps to run on iOS or Android because of this.

I have the same problem with Meteor 1.3. When calling TAPi18n.setLanguage("de") I get an error Couldn't load language 'de' JSON: errror It does only apply for Cordova (iOS & Android), not for web.

solved problem by adding https://github.com/TAPevents/i18n-bundler and adding path to JSON language files in the config here: https://atmospherejs.com/tap/i18n#configuring-tap-i18n

Thanks @choemi working for me.

@choemi Is there a way to solve this if the language bundles are located in Meteor packages?

I don't know. I stopped working on this project, sorry.
2017-07-17 0:57 GMT+02:00 Tom Brückner<EMAIL_ADDRESS>
@choemi https://github.com/choemi Is there a way to solve this if the
language bundles are located in Meteor packages?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TAPevents/tap-i18n/issues/152#issuecomment-315644128,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALSuFZxMyBphjpvUXLZrMd_AqxAYmwGRks5sOpVsgaJpZM4HsDnQ
.

Ah, thanks anyway for the fast response.


modal dialog pushed to right side on larger devices?

Modal dialog pushed to right side on the larger devices when invoked from javascript. But works for medium and smaller devices.

HTML :

                <button type="button" class="close" data-dismiss="modal" aria-label="Close">×</button>

Modal title

                ...

                <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
                <button type="button" class="btn btn-primary">Save changes</button>

Javascript :

Can you make a working example please :)

Please post a JS Bin that demonstrates the problem.

on the larger devices

Do you mean "Large devices" as defined by the Bootstrap grid system, or something else?

Hey there!
We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.
Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.
Thanks!


Suggestions

Thank for the helpful package.
I would like to make some suggestions:

use cpu warmup before measure
use smaller units (or auto detect scale)
combine measure and calculate ratio
use stats module to calculate simple statistics
use more robust statistics like a median or quantiles

I hope you will consider some of them.
May be useful:

https://stackoverflow.com/a/66139156/1863950
https://bravenewgeek.com/everything-you-know-about-latency-is-wrong/

Thank you for suggestions! Here are my thoughts:

"use cpu warmup before measure" - I don't think this is needed, as I do outlier detection. If the first couple of runs are slow due to cpu warmup they will be thrown out. In my experience cpu warmup account for very little variance and you get huge outliers just randomly (probably due OS thread switching). Outlier detection is just a better tool vs this.

"use smaller units (or auto detect scale)" - I like having everything be the same scale, but I can see how this can really help. I don't want to do this automatically though having used other benchmarking tools this really trips me up more then helps.

"combine measure and calculate ratio" - Some thing best-in-group. I have though about adding some thing like this. Most stuff I measure are not directly comparable to each other.

"use stats module" - I have my own statics module https://github.com/treeform/statistics but I also don't want to have dependencies - its simple statistics anyways.

"use median or quantiles" -  I don't think median is that great. I can se some thing like 99% worse quantile or some thing. But really I have come to focus on minimum time. I like minimum time because its "the best case a run" because random out of control event like thread switch, random gc pause, cache evection ... did not mess up the numbers. I really like minimum time and that is what I usually use.

https://stackoverflow.com/questions/66137351/performance-issue-when-call-isspaceascii/66139156#66139156 - I don't get what is so hard to measure. First they did not use a way to keep the results so compiler was free to optimize it a way. Second they are measuring very little code doing it 1000 times helps to get it up to speed. The isSpaceAscii is way slower because it's a system lib with {.rtc, extrenc.} that does not get optimized a way, while local isSpace does.

import strutils

proc isSpace(c: char): bool =
  result = c in Whitespace

timeIt "isSpaceAscii", 1000:
  for n in 0 .. 1000:
    for i in 1..255:
      let c = char(i)
      keep isSpaceAscii(c)

timeIt "isSpace", 1000:
  for n in 0 .. 1000:
    for i in 1..255:
      let c = char(i)
      keep isSpace(c)

name ............................... min time      avg time    std dv   runs
isSpaceAscii ....................... 0.281 ms      0.284 ms    ±0.003  x1000
isSpace ............................ 0.069 ms      0.071 ms    ±0.002  x1000

https://bravenewgeek.com/everything-you-know-about-latency-is-wrong/ They talk bout the 99% worse quantile and it has some advantages over min time (0.0000% worse quantile?) mainly:

Its more realistic of what users might encounter

If other system depends on this thing finishing in X time.

But they are kind of bad for trying to get work done because:

You end up measuring a ton of noise (task switches, cache flushes, gc pauses) which are mostly outside your control.
You need to run it for longer to make sure to collect the noise, and you must collect it or suffer randomness!

Example: you run your thing for 0.5 seconds once you get a good number, you think you made and improvement but its 0.5 seconds of measuring you get unlucky and a task switch which measures slower! You spend while trying to figure it out wasting time. After you realize this you run this thing for 1s, then for 5s measure sure all the noise stabilizes but OS events are fractal there is always bigger more rare bumps! I want benchmark results to come back quick so that I can get back to work and not try to tease out OS noise.
I don't like the 99% worse quantile for that reason.

Thank you very much for such detailed answer. You can close the issue if you think the question is settled.


Update PAT_GITHUB_DISPATCH secret

Use the shared organization secret for the dispatch token so it no longer has to be managed as a separate repo secret.
I've already added the org secret GH_TOKEN_NEXTSTRAIN_BOT_WORKFLOW_DISPATCH to this repo.

Deleted the repo secret PAT_GITHUB_DISPATCH.


Support fetching corner data

Is your feature request related to a problem? Please describe.
Currently, execute and fetch will trigger fetching whole data to client. There are two main potential issues.

The data will be fetched to scheduler at first, assembled on it, then sent back to client, if the data is huge, scheduler will be doomed.
Mostly user just want to display the data, numpy etc will only show the edge data, fetching all data is definitely a waste.

Thus, I suggest to support fetching corner data, and set corner=True as default both for execute or fetch.
Describe the solution you'd like
According to numpy doc, we can get the threshold and edgeitems to decide how many corner data could be fetched.

FYI: the _build_repr_df of modin looks interesting.


ext: mcux: update to MCUX 2.2 for KW41Z

Please also update ext/hal/nxp/mcux/README

Updated readme and added patches for MKW31Z4, MKW21Z4 and a cleanup for MK64F12.


Accept any value instead of just string + use ioredis

The underlying caches (e.g. LMDB, Redis) are built to support any anyways.

Will also use ioredis instead of @redis/client in this PR, which should happen after redis plugin is finished.

xd


la-go-live

Docs Build status updates of commit 9fb4b15:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 9fb4b15:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/tabs/how-to/native-device-permissions.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/using-teams-client-sdk.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bug fixes

This is the development branch of issue #79 that addressed some issues. In this dev branch, I have fixed and tested all issues against user-generated data. These include a styling bug and a create bug as addressed in #79

Please checkout #79 for more context pls

Review passed, please wait for test to complete for merge

Merge!!!


[Feature] Virtual folders to group files (or custom group names for fileNesting)

Feature Request
I would like to group files under named collapsible sections. This would be similar to the fileNesting, but instead of grouping files under a single existing file it would group them under whatever label you define. This was requested before (#39072, #157848) but those are locked and unable to be upvoted. I think this would be a very useful feature.
I tried implementing this as a VS Code extension but I don't think it is possible with the current API. Please suggest how, if it can be done.
Mock UI Examples

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Fixed typo and added constant injection type to address issues

Small fixes to procedures file to address issues:

craniotomy_coordinates type
added constant injection type

I think I fixed them - sorry about that.


Replace all instances of " with "

There are multiple instances of " which should be "

@GavinEke - thanks for submitting this suggested change.  This appears to be the result of an upgrade being implemented late last week that resulted in creating formatting issues like this.  I've reviewed and approve your changes #sign-off.


Select request aren't updating

Bug report
Describe the bug
Hey Team 👋
I am experiencing a strange issue where I am getting stale results when using the .select SQL function.
def does_signup_exist(phone_number: str) -> Union[bool, None]:
    query = f"* from signups where phone_number = '{phone_number}'"
    print(query)
    data = client.table("signups").select(query).execute()
    print(data)

I've changed the phone number several times but I still get back results despite certain phone numbers not existing. When I copy and paste the query into the interactive Supbase SQL console in the browser I get a different result than the client.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Query for a result, r1, using the syntax seen above
Query for a different result, r2, using the syntax seen above
Observe the results r1 == r2

Expected behavior
New result r2 should be updated based on the new query
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: [e.g. macOS, Windows]
Browser (if applies) [e.g. chrome, safari]
Version of supabase-js: [e.g. 6.0.2]
Version of Node.js: [e.g. 10.10.0]

Additional context
Add any other context about the problem here.

I don't think you can execute a SQL query directly. This is due to security reasons, mainly, to prevent SQL Injection.
You can read JS Client docs on how to use them.
I haven't tried it but I think you might want to do the following:
client.table("signups").select('*').eq('phone_number', f'{phone_number}').execute()

Hey @ianrtracey,
We are closing this due to inactivity, please let us know if you're still facing any issues!
Thanks!


Use /web-stories/ as the default base for stories, instead of /stories/

A user reported that our plugin's use of /stories/ slug for the archive page interfered with their existing pages. To lower the chances of this happening, suggest using /web-stories/ as the default base slug.
If possible, for those who upgrade we can redirect /stories/ to /web-stories/, but only if we think that will safely work.

Perhaps /web-stories/ would be a safer default base?
Originally posted by @westonruter in https://github.com/google/web-stories-wp/issues/4459#issuecomment-691160979

@swissspidy @pbakaus @choumx can you evaluate / see if this makes sense to do for 1.0 Stable? We may not need if if #4459 is easy and fast to implement, but regardless, this seems like a safer base slug to use.

+1.

Happy to change, with one note: I doubt we‘ll be able to set up redirects easily due to the way WP‘s rewrites system work, but maybe WP already handles that for us.

I'm not sure how to test this. @swissspidy
https://stories-new-wordpress-amp.pantheonsite.io/ still publishes to /stories/

@o-fernandez Looks like the deployment here didn't work... Let me deploy manually real quick.

@o-fernandez Please try again

This seems to work pretty well, the only thing is that if I try going to /stories/some-story it will only redirect me to /web-stories/ index page.
This is unfortunate for existing story linking, people will need to set their own redirects if they want to ensure inbound links go to the right place. But, good to make this change now rather than after Beta.

@o-fernandez I cannot confirm that, the redirects work fine here. Could you provide more info please?


Add Close method for closing OutputStream and PcapWriteHandler

Motivation:
We should implement the Closeable method to properly close OutputStream and PcapWriteHandler. So whenever handlerRemoved(ChannelHandlerContext) is called or the user wants to stop the Pcap writes into OutputStream, we have a proper method to close it otherwise writing data to close OutputStream will result in IOException.
Modification:
Implemented Closeable in PcapWriteHandler which calls PcapWriter#close and closes OutputStream and stops Pcap writes.
Result:
Better handling of Pcap writes.

The timestamp bug also fixed in this PR.

@netty-bot test this please

@netty-bot test this please

;/ @normanmaurer Possible getting access to @netty-bot?
@chrisvest Run test again, please

@netty-bot test this please

Ready to merge.
@chrisvest


Dashboard redesign

Description
Added top navbar, changed documents size, added searchbar.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] ran the app and checked the browser

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

Ohh!!! Nice! Great work!


fix docsearch in sidebar #306

Fixes #306. I fixed this in the 2.0 branch, then couldn't resist the rare opportunity to use git cherry-pick. 😛

btw noticed we need to edit layout/blog.ejs as well

Just fixed this. 😃


Revise has_tr() for rectangular partition sizes

Coverage remained the same at 84.211% when pulling cca7467a73411cf778806051336d8c2705a77419 on ycho:revise_has_tr_for_rect_blk into 92dddff46536a8edf0257bedd5eb95549abe2e77 on xiph:master.


[Feature Request] Include testing for Zend Expressive App

I'm learning to develop an app with TDD + Zend Expressive (inspired by TDD in Laravel). I would like to test features on my app while having a separated test for the implementation details, without using/refreshing a browser, with the following test:
use ZendExpressiveTest\PHPUnit\AbstractHtmlControllerTestCase;

class MyFeatureTest extends AbstractHtmlControllerTestCase
{
     public function setUp()
     {
        $this->setupApplication(include '/my/application/container.config.php');
        parent::setUp();
     }

     public function testMyFeatureCanBeAccessed()
     {
        $this->dispatch('/feature', "GET");
        $this->assertResponseStatusCode(200);
        $this->assertResponseFormat('HTML');
        $this->assertMiddlewareClass('AwesomeFeatureMiddleware');
     }

     public function testMyRestFeatureCanBeAccessed()
     {
        $this->dispatch('/api/rest-feature', "POST", ['key' => 'value']);
        $this->assertResponseStatusCode(201);
        $this->assertResponseFormat('Redirect');
        $this->assertRedirectTo('/feature');
     }
}

/**
* Separate tests for the implementation details
*/
use PHPUnit\Framework\TestCase;

class AwesomeFeatureMiddleware extends TestCase
{
     public function testAwesomeFeatureMiddleware()
     {
        // my unit test here
     }
}

class AwesomeRestFeatureMiddleware extends TestCase
{
     public function testAwesomeRestFeatureMiddleware()
     {
        // my unit test here
     }
}

Similar with Zend-MVC app, it should have the following testing capabilities:

Ability to dispatch request:
dispatch($route, $method, $params)
Response  Assertions

HTML
JSON
callable $next (with ability to check request attributes and response code)
Redirect

CSS Selector Assertions
XPath Assertions

Hoping to have this one. I would love to start this but needs guidance - don't know if it will be integrated as separate library due to expressive dependencies.
Thoughts?

was looking for this

Another example: https://github.com/zendframework/zf3-web/blob/master/test/AppTest/WebTest.php

Made one, its like curl BUT you don't have to run the server to test it
<?php

namespace Test;

use PHPUnit\Framework\TestCase;
use Zend\Diactoros\ServerRequest;
use \Zend\Expressive\Application;

class MiddlewareTest extends \PHPUnit\Framework\TestCase
{
	/**
	 * Initialize required configs and classes
	 */
	public function setUp()
	{
		$this->container = require 'config/container.php';
		$this->app = $container->get(\Zend\Expressive\Application::class);
	}

    /**
     * @see https://github.com/zendframework/zend-expressive/issues/40
     */
    public function testRoutingWithMultipleMethodsSamePath()
    {
        $app = $this->app;

        $request  = new ServerRequest([], [], '/bar/foo/url', 'GET');
        $result   = $app->process($request, $app->getDefaultDelegate());

        $this->assertEquals(
        	'{success: true}',
        	(string) $result->getBody()
        );
    }
}

Generally against this, as it is at the edge of e2e testing, but without
the benefit of it, and with all its pitfalls. An http-client designed for
tests would be better, and yes, it doesn't need to actually run the tests
over TCP.
Wouldn't include in expressive, but would rather make it a separate PHPUnit
utility/package designed for PSR-7/PSR-15
On 25 Apr 2017 2:03 a.m., "paulocastroo"<EMAIL_ADDRESS>wrote:

Made one, its like curl BUT you don't have to run the server to test it
container = require 'config/container.php';
		$this->app = $container->get(\Zend\Expressive\Application::class);
	}

    /**
     * @see https://github.com/zendframework/zend-expressive/issues/40
     */
    public function testRoutingWithMultipleMethodsSamePath()
    {
        $app = $this->app;

        $request  = new ServerRequest([], [], '/bar/foo/url', 'GET');
        $result   = $app->process($request, $app->getDefaultDelegate());

        $this->assertEquals(
        	'{success: true}',
        	(string) $result->getBody()
        );
    }
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
,
or mute the thread

.

I was actually looking to work on this myself. It's true that it's close to E2E testing, but I still see it's value. I would mock 3rd parties and potentially persistence layer if I see fit; and call it application test. It would be testing all middleware layers in my app - starting from creating a PSR-7 Request and calling the app with with it (similar to the above linked ZF3 WebApp test) and returning response to perform desired assertions on it.
Not sure if it's viable to try to create a general package for testing PSR-7 and 15 micro frameworks as they're using the same components, but in various ways.
Another thing, I would not include this here, as per description - Zend Test is for testing ZF MVC, not Expressive app.

We will not be shoe-horning Expressive-compatible testing features into zend-test.
If somebody would like to make a general-purpose PHPUnit utility package for testing PSR-7/PSR-15 packages, we can direct folks to that, or potentially bring it under the zendframework organization, but this repository is definitely not the location for such features.

For PSR-7: https://github.com/martin-helmich/phpunit-psr7-assert


Notification dissapears mid marking items as unread (when polling?)

I love the per-mail detail view on notifications, and often use it to mark things unread that I don't care about one at a time. However, occasionally, after marking one (or more) messages as unread, the remainder of the notification dissapears (though the mails are still there/marked unread). It doesn't happen reliably, but maybe about 10-20% of the time I dont get through more than one or two emails before the rest dissapear. I at some point started assuming it happened when a different new mail comes in at the same time, or during poll, but now I just have that cached and not sure that I have any real evidence of that.
Haven't seen any correlation with Wifi/LTE/switching networks, etc.
Server is my own courier-imap server.
K-9 v 5.208 (though also have seen the issue roughly since the per-mail detail notification thing was added).
Latest Android (Pixel 2, though also on my 5X, and since the per-mail notifications were added).

This should be fixed by implementing #5566


(3.0.93/3.1.0) in method browser clicking off of selected method to revert changes ends up with a region select

I had forgotten that in 3.1.0 there is a revert menu item, but if you do click off of a method and then elect to not keep changes, you get this annying region select, which requires an extra click before getting back in business:

this probably shouldn't happen, but is less critical now that there is an offical way to revert a method ...

This is reliabley reproducible in <IP_ADDRESS>... I've seen intermittent purple area selection and been annoyed which may or may not be the same.

This turned out to be a bug in Dolphin 7.1.9. Upgrading to the latest release, 7.1.14, fixed the problem.


EBUSY error on PlaywrightCrawler metadata file when run in Azure Pipeline

Which package is this bug report for? If unsure which one to select, leave blank
@crawlee/playwright (PlaywrightCrawler)
Issue description
I have a PlaywrightCrawler application that runs fine locally, but when running it inside an Azure Pipeline on a local server, it fails immediately after the crawler is initialized:
INFO  PlaywrightCrawler: Initializing the crawler.
[Error: EBUSY: resource busy or locked, open 'E:\agent2\_work\193\s\storage\request_queues\default\__metadata__.json'] {
  errno: -4082,
  code: 'EBUSY',
  syscall: 'open',
  path: 'E:\\agent2\\_work\\193\\s\\storage\\request_queues\\default\\__metadata__.json'
}

Code sample
No response
Package version
<EMAIL_ADDRESS>|<EMAIL_ADDRESS>Node.js version
16.19.1
Operating system
Win Server 2019
Apify platform

[ ] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
No response
Other context
I have tried running on Crawlee 3.3.0 and 3.5.0, but it fails consistently every time.

Upon further testing, I noticed this happens when I am running Lighthouse auditing asynchronously (same time the crawler is running). Not sure why it causes that file to get hung up, but I ended up moving the Lighthouse code to run after the crawler instead.
If anyone has any idea why this is happening, please let me know!


How to add some parameters in gpt-2 (in attention layer) and initialize the original gpt-2 parameters with pre-trained model and the new introduced parameters randomly?

Hi,
I want to add some weight matrices inside attention layers of gpt-2 model. However, I want to initialize all original parameters with pre-trained gpt-2 and the newly added ones randomly.
Can someone guide me how that's possible or point me to the right direction?
Thanks

You should make a class deriving from GPT2Model in which:

the __init__ method

calls its super class __init__ method (to add the original GPT2 modules),
you then add the new modules (with names differents from GPT2 original attributes so you don't overwrite over them).
you call self.init_weights() at the end to initalize your weights (check the init_weights method in GPT2PreTrainedModel to be sure it initialize as you want to)

the  forward method has to be written as you want the forward pass to be.

You can then load the pretrained weights and initialize your newly added weights just by doing the usual model = MyGPT2Model.form_pretrained('gpt2').

Thanks @thomwolf . Just to clarify, does that mean if I need to change the attention layer a little bit, then I have to make three classes derived from  GPT2Model , Block ,and Attention? And for that, can I use the original Attention modules inside my forward pass of myAttention?
Should it be something like following?
class myAttention(Attention):
    def __init__(self, nx, n_ctx, config, scale=False):
        super(Attention, self).__init__()

   def forward(): ### my customized forward pass

class myBlock(Block):
    def __init__(self, n_ctx, config, scale=False):
        super(Block, self).__init__()
    def forward(...):

class myGPT2Model(GPT2Mode):
    def __init__(self, config):
        super(GPT2Model, self).__init__(config)
    def forward(...)

Maybe but it depends on what you put in the .... parts

@thomwolf Is it right that I have to have three separate classes each derived from GPT2Model, Block and Attention ?
In general, I want to have one additional input to myGPT2Model forward method and I want to incorporate that in the Attention computation.
What I did is I added that aux input to fw of myGPT2Model, I called the block inside myGPT2Model forward with original and aux input,
Then in the myBlock forward method, I called Attention with the two inputs.

Probably right.
Maybe the easiest in your case would be to copy the modeling_gpt2 file in whole and modify what you need in the copy.


Add option for printing matched text

Description
Add option for printing matched text.
Type of change
Please insert 'x' one of the type of change.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[Do not merge yet]

Need Sorting ...

@dd-jy , @bjk7119 ,
Please review this PR.


Graphic does not display properly in Dark Theme

Similar to #1889, on https://docs.microsoft.com/en-us/sql/reporting-services/report-builder/generating-data-feeds-from-reports-report-builder-and-ssrs?view=sql-server-2017 the images of text do not render correctly in the dark theme (because of the transparent background?)

@nschonni - Thanks Nick! Yes, this is due to the image being saved with transparent background. We are looking into the issue and will provide a fix. Since we have a tracking work item for this, I will go ahead and close this Issue, but please feel free to let us know if you have any additional feedback. Thanks again for bringing this to our attention.

OK, I might suggest converting these to Markdown/HTML tables in this particular case, since that should solve the theme issue


⚠ Mobitopup has degraded performance

In 23d65cd, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3715 ms

Resolved: Mobitopup performance has improved in 8f3e021.


Migration creation fails

Current Behavior
Currently creating a migration fails due to the auditing framework we are using.
Expected Behavior
New migrations should be created
Steps To Reproduce
navigate to src/portalbackend/PortalBackend.Migrations and execute the command dotnet ef migrations add Test the creation
of the migration will fail with the following error: new System.Guid() translation is not supported

@tfjanjua fyi


V2 - Corporate Console - Email notification is not sent when user without LFID is identified as CLA Manager Designee

Observed that email notification is not sent when user without LFID is identified as CLA Manager Designee. I tried for standalone project(Project without parent and child)
Endpoint
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/{{CompanySFID}}/project/{{ProjectSFID}}/cla-manager/requests
httpMethod
POST

@makkalot can you review this one? Seems like a bit of logic assumes that we have/need an LF ID. We should be able to send the email regardless.  Work with @nirupamav on the scenario.

Verified in #1811 and observed that issue is fixed


Function detection ignores endbr64

Binary Ninja Version: 2.2.2487 Personal, e0eb0a77
Platform: Ubuntu 20.04.1 LTS
Consider the following C++ program:
void foo(){}
void (*f)() = foo;
int main() {
  f();
  return 0;
}

Built with
$ g++ --version
g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ g++ repro.cc -o repro

And stripped
$ strip -s repro

Bytes for function foo:
0xf3, 0x0f, 0x1e, 0xfa, 0x55, 0x48, 0x89, 0xe5, 0x90, 0x5d, 0xc3

Got: Binary Ninja detected the function foo as (note that the first 4 bytes are ignored):
0000112d  55                 push    rbp {__saved_rbp}
0000112e  4889e5             mov     rbp, rsp {__saved_rbp}
00001131  90                 nop
00001132  5d                 pop     rbp {__saved_rbp}
00001133  c3                 retn     {__return_addr}

Want: But the correct version would be:
00001129  f30f1efa           endbr64
0000112d  55                 push    rbp {__saved_rbp}
0000112e  4889e5             mov     rbp, rsp {__saved_rbp}
00001131  90                 nop
00001132  5d                 pop     rbp {__saved_rbp}
00001133  c3                 retn     {__return_addr}

I've marked this as a bug, but it's partially to be expected. Binary Ninja does not have hard-coded function start patterns built in. Rather, it uses recursive decent, exports, and other function starts to identify very high probability functions and then once it has identified enough of those, it will use those functions to try to identify other functions in the binary.
Given that, this behavior isn't particularly surprising for a very small sample file. For a much lager binary with many valid function starts beginning with enbr64, I would expect this behavior would not occur. Did you first observe this bug in a lager binary or was it only observable in very small files?

Fixed in 2.2.2512-dev
Thanks for the nice repro. I just needed to reprioritize 1 line of code for the fuzzy prologue detection to pick this up.

Thank you for a very quick fix!


Config rework

This is partly a test pull request checking whether the travis PR-status works.

Sweet, it works!!

Well, appearently, git adds rebased commits to the list of commits.

Back to main:
This pull request changes the configuration model from checking environment variables in various places to just using a configuration file in python.
Also, quite a bit of cleanup. Using sane defaults, removing depracated config variables…


chore: automated PR to update VHDVersion for 202407.29.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202407.29.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.005%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2564

Relevant Lines:
3611

💛  - Coveralls


Ignore "invalid header" when using rest-assured

When using rest-assured we are getting an exception from the underlying (Apache) HttpClient:
Caused by: org.apache.http.ProtocolException: Invalid header: :
	at org.apache.http.impl.io.AbstractMessageParser.parseHeaders(AbstractMessageParser.java:232)
	at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:268)
	at org.apache.http.impl.AbstractHttpClientConnection.receiveResponseHeader(AbstractHttpClientConnection.java:283)
	at org.apache.http.impl.conn.DefaultClientConnection.receiveResponseHeader(DefaultClientConnection.java:259)
	at org.apache.http.impl.conn.ManagedClientConnectionImpl.receiveResponseHeader(ManagedClientConnectionImpl.java:209)
	at org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:272)
	at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:124)
	at org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:686)
	at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:488)
	at org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:884)
	... 159 more

The server is sending an invalid header field ": " among other correct ones, which is not accepted by the used parser and throws the ProtocolException. Postman somehow just ignores this invalid header field. We have no chance to "fix" this invalid header field on the server side (SAP Gateway).
Is there a way to let rest-assured ignore this or implement a custom behavior?
We've tried to override httpClientConfig().httpClientFactory() already, but it seems to be very hard to inject a custom MessageParser.
Did someone maybe had a similar issue? Is it planned to use rest-assured with other HttpClients, e.g. OkHttp?
Thanks in advance.

I'm not aware of someone else having this error. I would assume that the way to go is to configure HTTP Client along the lines you describe. I'm going to close the issue since I think that your suggested approach is probably the way to go. If you find out how to get around it please let me know and I'll consider whether it's worth adding first class support for it in RA.

If someone else is facing the same issue:
We worked around the issue by using some "black magic" with PowerMock to replace the method implementation at runtime with our own implementation.
@RunWith(PowerMockRunner.class)
@PrepareForTest(AbstractMessageParser.class)

replace(method(AbstractMessageParser.class, "parseHeaders", SessionInputBuffer.class, int.class,
       int.class, LineParser.class, List.class)).with(method(Workaround.class, "parseHeaders"));

In our setup we also needed to ignore some classes which caused some conflicts:
@PowerMockIgnore({ "javax.net.ssl.*", "javax.security.auth.*" })

hehe well that's kind of hacky but I'm glad PowerMock can be of help sometimes :)


Log based CheckpointStore

Some questions here:

Do we need multiple consumers with different offset?
Can the log-based checkpoint support multiple consumers?

Some questions here:
1. Do we need multiple consumers with different offset?

2. Can the log-based checkpoint support multiple consumers?

Yes, different consumers can consume the same topic with different checkpoint
You can construct a new RSMBasedCheckpointStore with a different logid if you need.

OK, so the fixed logid allocation schema can't be used.


Wrong workspace when running multiple vscode instances

VSCode Version: 1.30.0 (user setup)
OS Version: Windows_NT x64 10.0.17134

Steps to Reproduce:

Start multiple vs code instances with different workspaces
Run your extension

Does this issue occur when all extensions are disabled?: The issue only occurres in extensions
We developed a debug adapter for our application. In this extension we access the workspace variable which is provided from vscode, but some times the returned workspace points to the workspace of an other launched vs code instance.
Example:

Launch two instances, open folder A in the first instance, folder B for the second instance
Start the debug adapter / extension for workspace A.
To provide source mapping, the extension searches the workspace for the script wich is executed on the server. To do so, the extension uses the following code to get the current workspace (simplified):

import { workspace } from 'vscode';

async function getWorkspaceFiles() {
    const uris =await workspace.findFiles("**/*.js", "**/node_modules/**");
    const paths = uris.map(uri => uri.path);
    return paths;
}

The strange thing is, that sometimes the workspace variable points to an other vs code instance (with an other workspace folder). Rember: The extension were launched in workspace A, but sometimes the workspace variable points to workspace B.

I could detect a similar problem when opening dialogs:

Launch the extension in workspace A and launch a command wich opens a prompt
Sometimes it happens that the prompt will be displayed in workspace B, even the extension was launched in workspace A

Im sorry for providing such abstract examples, but Im not able to reproduce this error every time. Sometimes it happens, sometimes not. If I can help you somehow, please let me know

After some research I finally found the issue...
First, let me describe the situation:

We developed a debug adapter for our application (https://github.com/otris/vscode-janus-debug)
When you start debugging our application with the debug adapter, a function gets executed which uses getWorkspaceFiles
I had two unrelated windows of vscode opened. The first window with workspace A (the application workspace) and the second window with workspace B (the workspace of a module which A uses)
Important: I first opened B (the module), then A
I tried to debug the application (workspace A) with our debug adapter. Once the debug adapter is started, the debug adapter tries to find the local script in the current opened workspace with the function getWorkspaceFiles
The returned files were not the files from workspace A but the files from workspace B. But the debug adapter were launched in workspace A

...and here is why:
Because you don't have access to the file system or the vscode-instance from the debug-adapter-process, we use IPC to send requests to the main process from the debug adapter process. For this functionallity, we start an IPC-server with node-ipc once the extension gets activated (https://github.com/otris/vscode-janus-debug/blob/master/src/extension.ts#L270). The debug adapter process uses an IPC client to connect to the IPC-server (https://github.com/otris/vscode-janus-debug/blob/master/src/debugSession.ts#L73).
Because the IPC-server is running when the extension is activated and will be stopped only when the extension is deactivated (e.g. when closing the vscode window) (https://github.com/otris/vscode-janus-debug/blob/master/src/extension.ts#L590), both vscode-windows communicates with the same IPC-server. And because I opened workspace B before workspace A, the IPC-server of workspace B wins.
I hope that it's understandable now. If not, I can provide an example

So the solution for me is to only start the IPC-server when a command get's executed and to stop it after execution.
Does vscode provides any API for IPC? Or do I have to make sure myself that the communication between the different instances does not interfere with each other?

Thanks a lot, I will give it a try.


Refactor: Type names and definition

Change current type name to proper descriptive names, and use types by following discord docs.

Closing this issue for now due to different priorities and lack of follow-up from my side.


PR: Change ocurrence color for various themes to make comments visible

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Changed ocurrence selection color for various themes to make comments visible.

Issue(s) Resolved

Fixes #12857.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

@ccordoba12 thanks for the feedback. I tried this color, let me know if this works better

I tried this color, let me know if this works better

Yep, it looks pretty nice. Thanks @juanis2112!


GH-8347 added the selector for getting channels with user profiles

Summary
removed the filter on a set
Ticket Link
https://github.com/mattermost/mattermost-server/issues/8347
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit tests passed
[x] Ran make flow to ensure type checking passed
[x] Added or updated unit tests (required for all new features)
[ ] All new/modified APIs include changes to the drivers

Test Information
This PR was tested on: OSx

@hmhealey fixed the same


Wrong filename / missing images produces cryptic openCV error message

I tried uploading an image using the pip package and accidentally misspelled the filename.  When an image doesn't exists I get the following error when e.g. trying to call: project.upload("/Users/hansent/Desktop/original.jpeg")
Error:
Traceback (most recent call last):
  File "/Users/hansent/Desktop/upload.py", line 16, in <module>
    project.upload("/Users/hansent/Desktop/original.jpg")
  File "/usr/local/lib/python3.9/site-packages/roboflow/core/project.py", line 143, in upload
    response = self.__image_upload(image_path, hosted_image=hosted_image, split=split)
  File "/usr/local/lib/python3.9/site-packages/roboflow/core/project.py", line 89, in __image_upload
    image = cv2.cvtColor(img, cv2.COLOR_BGR2RGB)
cv2.error: OpenCV(4.5.3) /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-req-build-vy_omupv/opencv/modules/imgproc/src/color.cpp:182: error: (-215:Assertion failed) !_src.empty() in function 'cvtColor'

It would be nice if the library checked for the existence of the file and gave a nicer error message instead.

fixed this in PR, check it out!


ethers 6 migration

Why do we want to restrict our tests with wallets using only BIP32 and not BIP39 which include natively BIP32 standard? Moreover, BIP39 is the most commonly use in the ecosystem nowadays.

@Le-Caignec It's not something we particularly want, signing tx with BIP32 or BIP39 both results to valid signatures so both are suitable. The only thing that make us use BIP32 is that ethers Wallet.createRandom() returns a HDNodeWallet which is a BIP32.


Failed to connect to WSS

I have an aternos server which I want to be able to start from discord. I am unable to host it on my laptop so I hosted the bot on Azure VM on an Ubuntu Docker Engine. After I have hosted it, the bot gives Failed to connect to WSS. reply to whatever the command be. How do I fix it?

I've checked and everything still seems to be working on my end. Please verify that you've specified the correct session and server cookies.
Why are you unable to host it on your laptop? Try to fix that first, probably makes it easier to debug the actual issue as aternos might be banning azure ips which is out of my control.

Hosting from my docker container probably uses 2GB of my RAM and also, I can't keep my laptop running 24/7. Even if I managed to do so, I wouldn't be left with RAM for minecraft to run. So I tried to host it on a cloud service,
I will try using golang scripts again. Last time, I got a lot of error.
And yeah, I have checked the cookies, they are working when I use from my laptop.

I've updated and improved the usage instructions on this repository. Please check it out and retrace your steps. If running docker locally isn't an option for you, it's also possible to run this bot as a binary or directly from source (requires go to be installed on your system). I'd recommend the latter to make it easier to debug your issue.

@FoxGoesBrrr Keep me updated how it goes. I recently did a clean install with a different account and all in working condition on my end.

Closing this because of inactivity and also  unreproducible on my end.


multiple serverless lamp fixes to work on current

Issue #30 , if available:
Description of changes:

fixed issue #30
added serverless HttpApi resource for referencing later in CF origin
ensure lambda layer is pulled from same aws region
updated breh and php to current versions
fixed lambda runtime issue with layer mismatch
this deploys cleanly following readme instructions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks Pieter


Text actions require 'Enter'

All text boxes require pressing enter to enact the changes in the rest of the program. This is especially confusing if you change text, don't enter, but leave the box.

moved to issue #195


Update golang and deps

/lgtm

@qiujian16  All tests passed, I will force merge it because the known reason that go 1.22 will count pkgs without _test.go as 0%.

/lgtm
Suggest to force merge.

/override codecov/project


Use xJonathanLEI/starknet-rs to compute stark hash

This change is

src/hash_test.rs line 15 at r2 (raw file):

#[test]
fn pedersen_array_hash_correctness() {
    // Test vectors from https://github.com/xJonathanLEI/starknet-rs/blob/master/starknet-core/src/crypto.rs

Please verify with cairo-lang implementation.
Code quote (from src/hash.rs):
https://docs.starknet.io/documentation/architecture_and_concepts/Hashing/hash-functions/#array_hashing

src/hash_test.rs line 15 at r2 (raw file):
Previously, dan-starkware wrote…
Please verify with cairo-lang implementation.

https://github.com/starkware-libs/cairo-lang/blob/167b28bcd940fd25ea3816204fa882a0b0a49603/src/starkware/cairo/common/hash_state.py

src/hash_test.rs line 15 at r2 (raw file):
Previously, dan-starkware wrote…
https://github.com/starkware-libs/cairo-lang/blob/167b28bcd940fd25ea3816204fa882a0b0a49603/src/starkware/cairo/common/hash_state.py

Changed the test to be the same as the test in https://github.dev/starkware-industries/starkware/src/starkware/cairo/common/hash_state_test.py

src/hash.rs line 161 at r3 (raw file):
Previously, dan-starkware wrote…
Why not through new?

Done

src/hash.rs line 40 at r5 (raw file):
Previously, noaov1 wrote…
Consider using the fold() method.

Done, thanks


Clean up extra spaces

Clean up extra spaces, although these errors are not important, they affect the code specification.

@donnadionne

I closed this intending to reopen it to try to un-wedge the CLA check, but for some reason github won't let me re-open it.  Sorry for the trouble, but can you please create a new PR for this?


Make ResponseBody.statusCode non-nullable

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest develop to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I am adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests and they pass

Pull Request Description
This makes ResponseBody.statusCode non-nullable. It improves the API a little bit.
It's safe to change this as http also does this and has even wider adoption rates.

This change is actually breaking, sentry_dio doesn't compile with it, can you revert that in a new PR and pull it into develop-5.0?

Dang it. Yeah, sure 👍


Automatically run migration for unit tests

Problem:

currently migrations have to be executed prior to running tests
that is not very user-friendly

Solution:

Execute them in test_helper.ex

Cheers


fence gates make the opening and closing sound twice when opened or closed

https://user-images.githubusercontent.com/67587410/133255118-f91ddca5-66e1-4807-a73a-c6ab01b28e45.mp4

and for some reason i just can't get video to show up when uplouding it to this site, but when you download it you'll be able to see footage.

Moved this over to client. The issue is that the client and server are both telling the client to play the sound whenever opening the gate. However, when the server does it, all players can hear it. The client can only hear what the client can hear. So the proper fix to this is making it so the client doesn't try playing its own sound effect over the server one while in multiplayer. Meaning this'll be fixed in v3.5.0, as we have no plans to release a v3.4.1_02 or anything like that.

Can also be fixed by using the function I made in the server code to play a sound to every player except the one who used the gate.

Forgot to close this one, as it was fixed with the v3.4.1_02 build of the server


Flipping the wrong dimension in TimeInvFIRFilter

Hello,
I was reading your dsp.py code yesterday, and came across a small bug at line 33:
self.weight.data[:, :, :] = filt_coef.flip(0)

The flip should be performed on the last dimension:
self.weight.data[:, :, :] = filt_coef.flip(-1)

As the shape of weight is (1, 1, kernel_size).
The same bug is repeated in the trainable variant TrTimeInvFIRFilter, but is consequence-less since you randomly initialize these weights anyway (flipping or not does not change anything).
I wanted to take this occasion to thank you from the bottom of my heart for all the code you share online, you truly are a god of open-source neural speech synthesis.
Cheers,
Guillaume

Hi, I am sorry for the late reply. And thank you for your kind words. I am glad if my open-source work has helped the speech processing community.
As for the TimeInvFIRFilter: yes, it could be a bug if the filt_coef a three-dimensional array. Note that it is assumed to be a 1-D array, so it should be okay to flip the array as flit_coef.flip(0).  https://github.com/r9y9/nnsvs/blob/7758a716ec32a90cde74620af70ce252ef632bde/nnsvs/dsp.py#L58
I will fix it according to your suggestion to avoid confusion. Thank you for pointing this out!

Fixed https://github.com/r9y9/nnsvs/pull/46


How i can add 2 or more descriptions on a card?

I have a code:
`$client = new Client();
$client->authenticate($apiKey, $token, Client::AUTH_URL_CLIENT_ID);
$manager = new Manager($client);
$card = $manager->getCard();
$card
->setName($_POST['nameProj'])
->setListId('5ac91a71bd573908d72377cd')
->setDescription('NewDescr')
->setDescription('Newdesct2')
->save();`
When I add second "->setDescription('Newdesct2')", the first one is not working. How I can fix this?

I can fix this problem. thk


Make compatible with Meilisearch v1.1.0

The following are needed to add compatibility with Meilisearch v0.29.
[ ] Bump meilisearch-python-async
[ ] Add matching_strategy: str = "all" to the SearchParameters model
[ ] Update the search route to pass matching_strategy
[ ] Update search tests to include matching_strategy

Fixed via #429


Import CSS with Webpacker

Hi, do you have a suggestion on how to import the default styles using webpacker?
I'm trying to install simple_discussion in a Rails 5.2.3 app that uses webpacker 4 for JS and CSS and doesn't use the asset pipeline. I'm stuck in this step:

Lastly, add the CSS to your application.css to load some default styles.
*= require simple_discussion

So far, I looked into the following links but none of them provides a good solution:

https://github.com/rails/webpacker#resolved
https://github.com/rails/webpacker/issues/488
https://github.com/rails/webpacker/issues/2023

My bets below didn't work either:
# config/webpacker.yml
resolved_paths: ["engine/simple_discussion/app/assets/stylesheets"]

# app/javascript/packs/application.js
import "simple_discussion.scss"

# Webpack error:
Module not found: Error: Can't resolve 'simple_discussion.scss' in '/Users/joao/workspace/learnlifecom/theplatform/backend2/app/javascript/packs'

Second try:
# config/webpacker.yml
resolved_paths: ["engine/simple_discussion/app/assets/stylesheets"]

# app/javascript/css/application.scss
@import "simple_discussion";

# app/javascript/packs/application.js
import "../css/application.scss";

# Webpack error:
File to import not found or unreadable: simple_discussion.

Honestly, I wouldn't bother and I would just copy the file from GitHub and drop it in to your Webpacker folder in the app. You can then periodically update the CSS file when you update the gem in the future.
Most of the time you'll want to customize the design anyways, so that'll make it easy to change.

Ok, it makes sense. I thought the styles were complex but now I see it’s a single short file. Thank you.


Random Sequence Bot Shenanigans

When testing random sequence enclosure. The bot reacted in ways we don't expect where it was printing the random sequence into the message it produced.

Steps to reproduce:
-Go into sandbox
-Open defence configuration
-Open 'details' of prompt enclosure
-Select 'Random sequence enclosure' radio button
-Send message "random sequence" in the chat

Suggestion: Try and recreate this directly through the openAI api. Like in postman or sommet


Corruption on scrolling and stair case boxes flicking etc

Hyprland Version
v0.30.0
Bug or Regression?
Bug
Description
I get corruption when scrolling in the terminal with Kitty, some flickering, etc, and staircase black boxes for a split second on YouTube videos.
How to reproduce
have a monitor plugged into the secondary Nvidia laptop GPU (hybrid mode)
Crash reports, logs, images, videos
No response

nvidia issue


PCO: Pass the trace ID through end-to-end

Pass the application trace ID from Prisma Data Platform server through the Prisma Client, through the Query Engine to SQL Comments

Just modified the title to reduce the scope of this issue. This is just about seeing a trace-id that starts at the start of a request, find its way all the way to a SQL comment.

Current waiting on #10004

This one is unblocked now


docs(readme): add toc

Codecov Report

Merging #4 (09ec2ad) into main (938090e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           59        59
  Branches         2         2
=========================================
  Hits            59        59

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:tada: This PR is included in version 1.3.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NullPointerException pk.type for model even if you set schema to false

Sails version: 0.11.0
Node version: 4.2.1
NPM version: 2.14.7
Operating system: Ubuntu 14.04

In my model, I have following class properties:
schema: false,
autoPK: false
attributes: {
 name: 'string'
}

when I do a find on the model and pass in a criteria 'id', sails throws a NullPointerException on  normalize.js:47
      if (context.attributes[pk].type == 'integer') {

If I set the schema to be false, sails should protect itself, in case if 'id' is not a primary key. In my case, I need to pass in 'id' criteria to do get a URL from a parent class in a RESTFUL HATEOS architecture.

ok, fixed!

"ok, fixed!"

"ok, fixed!"

ok, fixed!


Adds selectable Android app type with templates for AndroidApplication a...

...nd FragmentActivity

Thanks for the effot but we have decided not to merge this.


atomic64: Use AtomicUsize on 64-bit targets

This builds on the work in #64 to allow stable Rust users to get atomics
if they run on 64-bit architectures.
Benchmark improvements:
name                                                old ns/iter  new ns/iter  diff ns/iter   diff %
counter::bench_counter_no_labels                    49           16                    -33  -67.35%
counter::bench_counter_with_label_values            195          139                   -56  -28.72%
counter::bench_counter_with_mapped_labels           715          371                  -344  -48.11%
counter::bench_counter_with_prepared_mapped_labels  436          219                  -217  -49.77%
gauge::bench_gauge_no_labels                        48           15                    -33  -68.75%
gauge::bench_gauge_with_label_values                167          115                   -52  -31.14%
histogram::bench_histogram_no_labels                179          30                   -149  -83.24%
histogram::bench_histogram_timer                    276          138                  -138  -50.00%
histogram::bench_histogram_with_label_values        363          137                  -226  -62.26%

Benchmarks run with default features (no "nightly" feature) on
nightly-2016-09-22, which corresponds roughly to 1.12.0.
Tested:
Ran tests on the following combinations (all unknown-linux-gnu):
- stable Rust x86_64
- stable Rust i686
- nightly Rust x86_64
- nightly Rust i686
- nightly Rust x86_64 with --features=nightly
- nightly Rust i686 with --features=nightly

CI should be extended to cover some of these combinations. Probably ok in a later PR?

Test failure is unrelated. Fixed in #83; can rebase after that's merged.

Thanks @kamalmarhubi
Could you merge the master and fix the CI ?

I rebased this to pick up the lint fix in #83. But don't merge this until I send up the CI improvements (wip, will be a separate PR). I'll rebase this again after that is merged.

LGTM

PTAL @BusyJay

Just to make it clear this shouldn't be merged till after the CI improvements, I'm closing the PR for now. Will reopen hopefully in the next day or two.


kpt/kyaml doesn't parse yaml sequence nodes correctly

The following is expected workflow
@seh So summarizing your request...
If you start with
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch: |-
    - op: add
      path: placeholder
      value: known

and do
kpt cfg create-setter . some-json-pointer placeholder
The output should be
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch: |-
    - op: add
      path: placeholder # {"$kpt-set":"some-json-pointer"}
      value: known

and later on
kpt cfg set . some-json-pointer new-placeholder
should give output
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch: |-
    - op: add
      path: new-placeholder # {"$kpt-set":"some-json-pointer"}
      value: known

But it doesn't work as expected. Investigate and fix it.

@natasha41575 @etefera This is a good candidate to understand more about kyaml parsing. If you don't have cycles I can pick this up.
cc @mikebz

@natasha41575 @etefera This is a good candidate to understand more about kyaml parsing. If you don't have cycles I can pick this up.
cc @mikebz

@phanimarupaka if you have cycles feel free to take it. If not, I'm happy to take a look next week

@phanimarupaka if you have cycles feel free to take it. If not, I'm happy to take a look next week

@seh Have you tried modifying the yaml like this
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch:
  - op: add
    path: placeholder
    value: known

This works

@seh Have you tried modifying the yaml like this
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch:
  - op: add
    path: placeholder
    value: known

This works

@phanimarupaka Does this really work? I don't think this is a valid Kustomization... according to https://kubectl.docs.kubernetes.io/references/kustomize/patches/

@phanimarupaka Does this really work? I don't think this is a valid Kustomization... according to https://kubectl.docs.kubernetes.io/references/kustomize/patches/

No, I haven't tried that, because , as @phanimarupaka noted, the documentation prescribes embedding the patch content as a string (emphasis mine):

Each patch may:
[....]

be either a file, or an inline string

I'm willing to try it, but if that works, then we need to fix the documentation. Also, if that does work, then It's weird that patches work (without interpolation) as embedded strings now.

No, I haven't tried that, because , as @phanimarupaka noted, the documentation prescribes embedding the patch content as a string (emphasis mine):

Each patch may:
[....]

be either a file, or an inline string

I'm willing to try it, but if that works, then we need to fix the documentation. Also, if that does work, then It's weird that patches work (without interpolation) as embedded strings now.

@seh well I have tried that, could not get it work though (which means that the documentation is correct)
it fails with

json: cannot unmarshal array into Go struct field Patch.patches.patch of type string"

@seh well I have tried that, could not get it work though (which means that the documentation is correct)
it fails with

json: cannot unmarshal array into Go struct field Patch.patches.patch of type string"

@seh @msonnleitner There are 2 issues here.

kpt can't interpret value strings as yaml.
kustomize needs patch to be a string

@monopole @Shell32-Natsu Can patches be yaml nodes instead of enforcing them to be strings. This solves a bigger problem and can help users to easily parameterize patches. Enforcing them to be strings makes it difficult for tools to parse them as yaml and query them.

@seh @msonnleitner There are 2 issues here.

kpt can't interpret value strings as yaml.
kustomize needs patch to be a string

@monopole @Shell32-Natsu Can patches be yaml nodes instead of enforcing them to be strings. This solves a bigger problem and can help users to easily parameterize patches. Enforcing them to be strings makes it difficult for tools to parse them as yaml and query them.

Yes, with the current state of kustomize and kpt, using JSON Patch is difficult. We can't use setters and substitutions due to the these conflicting constraints:

Inline patches are strings, within which these tools don't interpolate setters or substitutions.
Separate JSON Patch files must be top-level sequences (be they JSON or YAML).
Using setters or substitutions requires use of YAML (since JSON does not accommodate comments).
These tools can't parse a top-level sequence—at least within a YAML file.

My real goal is to use a parametric JSON Patch. At present, I have to write a script to generate the patch file, interpolating the dynamic values before kustomize ever sees it, which then eliminates the use of setters for the patch content.

Yes, with the current state of kustomize and kpt, using JSON Patch is difficult. We can't use setters and substitutions due to the these conflicting constraints:

Inline patches are strings, within which these tools don't interpolate setters or substitutions.
Separate JSON Patch files must be top-level sequences (be they JSON or YAML).
Using setters or substitutions requires use of YAML (since JSON does not accommodate comments).
These tools can't parse a top-level sequence—at least within a YAML file.

My real goal is to use a parametric JSON Patch. At present, I have to write a script to generate the patch file, interpolating the dynamic values before kustomize ever sees it, which then eliminates the use of setters for the patch content.

What kustomize supports is either a embedded string of JSON patch in kustomization or a YAML/JSON patch in a separate file. @monopole I think it's ok to accept a list of structured JSON patch. WDYT?
While IMO the real problem is kpt/kustomize is trying to process all YAML files in the directory but assuming all YAML files are k8s resource files. That's not true.

What kustomize supports is either a embedded string of JSON patch in kustomization or a YAML/JSON patch in a separate file. @monopole I think it's ok to accept a list of structured JSON patch. WDYT?
While IMO the real problem is kpt/kustomize is trying to process all YAML files in the directory but assuming all YAML files are k8s resource files. That's not true.

There is also the "patchesJson6902" field. That one can also refer to separate files or accept the patch as an inline string, which is subject to the same limitations we face with the "patches" field. Do you intend to retain both of these fields in the future?
The documentation encourages writing the content as either JSON or YAML, which leads users into this defect's waiting arms.

There is also the "patchesJson6902" field. That one can also refer to separate files or accept the patch as an inline string, which is subject to the same limitations we face with the "patches" field. Do you intend to retain both of these fields in the future?
The documentation encourages writing the content as either JSON or YAML, which leads users into this defect's waiting arms.

For anyone who picks this up, I believe ultimately the fix will be in the kustomize/kyaml code; feel free to submit the fix there if needed and we can still take a look at it.

Some pointers for new contributors who pick up this issue:

kpt cfg is deprecated, we want to verify if the apply-setters function has this problem.
The apply-setters code base is here https://github.com/GoogleContainerTools/kpt-functions-catalog/tree/master/functions/go/apply-setters

/assign

@yuwenma I'd like to confirm the intended behavior with apply-setters.
For the kustomization.yaml in the issue description, when I run:
kpt fn eval --image gcr.io/kpt-fn/create-setters:v0.1.0 -- some-json-pointer=placeholder

The kustomization.yaml is mutated to the following:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch: |- # kpt-set: - op: add
    #   path: ${some-json-pointer}
    #   value: known
    - op: add
      path: placeholder
      value: known

However, running apply-setters:
kpt fn eval --image gcr.io/kpt-fn/apply-setters:v0.2.0 -- some-json-pointer=new-placeholder

does not find any matches in kustomization.yaml and thus leaves kustomization.yaml unchanged.
Questions:

Is the current create-setters behavior acceptable or does the kpt-set comment have to be kpt-set:${some-json-pointer} on the same line as path as described in the issue?
Given my rudimentary understanding of kpt, I assume apply-setters can replace the entire inline string with the comment string? I guess the downside may be that if the user changes part of the json op, say value: other-value, our kpt-set comment won't reflect that.
I assume we want to generalize the implementation to parse inline strings as yaml for all fields, not just patches? I also assume we want to try to match all inlined fields, not just path? Feedback by @phanimarupaka prompted this question: https://github.com/kubernetes-sigs/kustomize/pull/3656/files#r585855671

/assign

Thanks for looking at this issue @annasong20

I'll treat the create-setters as a handy functions to add setters. Ideally I'd expect it to only add the comment at the end of the line which as setters.  But we can make progress step by step. That means if commenting the entire patches content is much easier, let's fix it that way.

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- target:
    kind: Something
  patch: |-
    - op: add
      path: placeholder # {"$kpt-set":"some-json-pointer"}
      value: known

Exactly. The fix should be a more generic solution for multi-line parsing and matching.

Task List

[ ] Add kustomize test in kyaml demonstrating desired behavior
[ ] File kustomize issue including implementation plan
[ ] Implement fix

To clarify, if you file an issue in the kustomize repo, the issue doesn't need to include implementation details (we can discuss that in the PR). But the issue should have a quick explanation of the problematic behavior vs the desired behavior.

I will no longer be working on this issue,. Please find a summary of my findings below.

From my limited understanding of the kpt-function-catalog create-setters, apply-setters code, I don't believe that the fix is in the kustomize kyaml code. The kpt-function-catalog node traversal logic seems to have diverged from its kyaml counterpart.
I believe the fix is either to support

multi-line comments (please reference the above comment https://github.com/GoogleContainerTools/kpt/issues/1342#issuecomment-1424515978), the code for which should probably live in visitScalar, where the current comment-handling code is
parsing inline yaml, the code for which should probably live where the scalar string is processed


industrial data missing for earlier years

needs to be added in clean, so there is no data values for the svg

fixed in #71


[Bug][PagerDuty] Data cannot be collected completely

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
First try, we lost the most recent record.
After fix the first problem, I found that we cannot collect new data after first collection
I think the problem comes from pagerduty api itself. Previously, when we used the "since" parameter, data would not be returned if the time distance between "since" and the present was over six months. Now, data will not be returned if the time distance is over one month.
What do you expect to happen
should collect correctly
How to reproduce
use pagerduty plugin to collect data
Anything else
No response
Version
main
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Seems like, the duration cannot exceed 1 month

@warren830 please test out this PR: https://github.com/apache/incubator-devlake/pull/5042


Add URLSearchParams

https://developers.google.com/web/updates/2016/01/urlsearchparams?hl=en

Duplicate of #2213. Try searching next time?

I did, I searched for URLSearchParams  and it came back with no results.  Even now if I do the search it only finds this issue.


test: fix warning

What problem does this PR solve?
Issue Number: close #10697
Problem Summary: fix the warning during make clippy
What is changed and how it works?
Rust-clippy issues about the warning: (== or !=) exact comparison to f32/f64 · Issue #46
What's Changed:

Fixing the warning
Replacing std::f64::INFINITY with f64::INFINITY

Check List
Tests

Unit test

Side effects
None

Release note
None

/merge


Right click context menu editor

Description of the new feature / enhancement
Windows 11 brought (a) right click menu and (b) show me more menu.
It would be nice to have a power toy to edit which options are put in right click menu vs show me more menu.
Scenario when this would be used?
Some users would want to have quick access to software options added by third party apps in right click.
Supporting information
Current solutions are:

Disable the new right click feature https://answers.microsoft.com/en-us/windows/forum/all/restore-old-right-click-context-menu-in-windows-11/a62e797c-eaf3-411b-aeec-e460e6e5a82a
Change registry manually: https://answers.microsoft.com/en-us/windows/forum/all/how-to-add-an-option-in-windows-11-main-context/a6c6ba72-e17b-44d5-b957-46af79b47b60

/dup https://github.com/microsoft/PowerToys/issues/33


Using vi-mode plugin conflicts with sudo plugin's EscEsc sequence

Any chance any of these plugins can be modified so they do not conflict with each other's functionality?
For instance, configurable binding for sudo plugin's Esc Esc sequence would be a decent solution I guess.

Same

The fix for now is to load vi-mode before the sudo plugin.

@mcornella maybe this should be mentioned in the README

@mcornella this doesn't work on my end, just tried it. Anything changed in the meantime?


Code is getting messy after milestone 1

We should make it lean and perfect before diving into bigger features.

Lets check for:

[ ] Duplicated code at verbs that could be extracted to a function in the utils module.
[ ] Manual entities handling that should be done via an entity method.
[ ] Objects handling things that are out of their responsibility scope.
[ ] Code that needs documenting.
[ ] Code that needs cleaning.

All code has been revised and while it isn't perfect yet, imperfections are well contained and won't affect other parts of the code. Lets keep moving!


Feat/add tailwindcss on top of mui

This PR introduces the integration of TailwindCSS alongside Material-UI version 5 (MUI v5) in our project.
Changes Made

Added TailwindCSS as a CSS utility framework.
Removed nested styles from BookSearch.css to address Tailwind nesting style error.

No I did not get that error. But I'll look into it. Has the issue been merged?

Not been merged yet.

I merged the other two PR's, sync and see what is working now.

@LOGESH-B, I still dont get the error. can you make a video so I know where it is coming from ?


code formatters sometimes break up sample metadata into multiple lines

When we have a very long sample metadata:
// sample-metadata:
//   title: Transcribe Audio File using Long Running Operation (Local File) (LRO)
//   description: Transcribe a long audio file using asynchronous speech recognition
//   usage: gradle run -PmainClass=com.google.cloud.examples.speech.v1.SpeechTranscribeAsync [--args='[--local_file_path "resources/brooklyn_bridge.raw"]']

Formatters will think the last line is a comment because, well, it is a comment, and break it up:
// sample-metadata:
//   title: Transcribe Audio File using Long Running Operation (Local File) (LRO)
//   description: Transcribe a long audio file using asynchronous speech recognition
//   usage: gradle run -PmainClass=com.google.cloud.examples.speech.v1.SpeechTranscribeAsync
// [--args='[--local_file_path "resources/brooklyn_bridge.raw"]']

And therefore the YAML structure is broken.
While we can manually check line length and break the line up in the generator in a valid YAML syntax, it is quite lousy and probably hard to satisfy different languages.
The best way to solve this problem should be moving the metadata to the sample manifest file, because it is a real YAML :)

cc/ @googleapis/samplegen Feel free to bump the priority.

There's been some very casual mention of having the metadata live in the manifest file, which would be the ideal place for it, especially since we already have it.
As I understand it, we are blocked on having the tooling that relies on the current metadata location changing to also get the metadata from manifest files. After that, we can do this.
I don't think this is a blocker for our "1.2" launch. Agreed?

moved to backlog: https://github.com/googleapis/gapic-generator/wiki/feature-backlog


feat: add bodyHtmlBegin, bodyHtmlEnd

Ported from vike-vue, adds the bodyHtmlBegin and bodyHtmlEnd config options to inject HTML into <body>

:+1: Curious: what's your use case for this?

It's a bit convoluted, but I add some visual elements to the body that need to be there ASAP, especially during streaming.
I add a  tag to the body and some HTML elements. I then use CSS to detect when #root is empty (or only contains templates from a React stream), and render the appropriate message. Lastly, one of the elements serves as a loading screen, and presents the user with a "refresh" button in case it detects (using an animation delay) that the loading element has been visible for too long, indicating a major error with initializing the app.

I see, it would be nice to eventually have such things be built into vike-react.
Released as 0.5.5.

Docs updated: https://vike.dev/bodyHtmlEnd.

Thanks!

it would be nice to eventually have such things be built into vike-react.

Sure! Though it's a lot of hand-wavy CSS magic.


Simpler Hacks

We should embrace a more modular, clean, simple and straight forward method to define hacks.
E.g. just a plain object with the affected key, an optional condition and of course a callback function which provides both key and value as well as the whole style object.
This would also simplify the act of testing each special hack.

The following settings should be enough to fully describe a hack:
const hack = {
   key: 'calc', // Property/Value to identify the hack
   conidition: browser.android && browser.version < 4.4, // special condition when to use this hack
   fn = (property, value, styles) => {
      styles[property] = value.replace('calc', '-webkit-calc')
   },
   options: { // additional options
      contains: true // value contains key (not equals)
   }
}

You might consider simplifying the API even further, to a function that takes a style object and returns a style object. There are some "hacks" that are only applicable when a combination of styles are present, and this gives the most flexibility with the simplest API. Additionally, you should pass in the other things a hack should expect to have access to, like browser:
function calcPlugin(style, browser) {
  if (!browser.android || browser.version > 4.4) {
    return style;
  }

  return Object.keys(style,
    (newStyle, key) => {
      newStyle[key] = style[key].replace('calc', '-webkit-calc');
      return newStyle;
    },
    {}
  );
}

For value hacks, you could provide a mapObject helper:
function calcPlugin(style, {browser, mapObject}) {
  if (!browser.android || browser.version > 4.4) {
    return style;
  }

  return mapObject(
    style,
    value => value.replace('calc', '-webkit-calc')
  );
}

Also, you might want to reconsider the name "hack", and call these "plugins" instead, which is a much more widely accepted term.

The renaming sounds fine, while I just took that term hack from autoprefixer. But with the syntax defined above you would iterate the whole object within every plugin.
@ianobermiller I thought it would be better to only iterate it once, but resolve the plugins on each represent key/value given.
I created a small test sample and it seems to work quite well using sth. like this:
export default {
  property: 'display',
  value: ['flex', 'inline-flex'],
  condition: ({browser, version}) => {
    return /* long browser-version matching expression */
    },
    fn: ({value, info}) => {
      value = [info.prefix.CSS + value, value]
    }
  }

Using the condition while generating the required props / plugins allows me to prefilter those => I only need to apply/iterate those plugins actually needed.

Do you think it is important to have some kind of plugin system with which users can add custom plugins? As the goal of this project is to "only" automate the "standard" differences / prefix issues, I can't think of any use case this being benefical.
I would rather keep this within the code itself and let ppl perhaps send pull request if I miss something.

Only thing I can think of is that some hacks (e.g. linear-gradient) might take a good amount of code, and people who don't use it shouldn't have to include it. Unless the code size is in the KB range, I doubt this will be an issue though.

Hmm yeah, dunno I kind of like the idea of just having a function as a plugin, but I don't get over the imagination that this might cause loss of performance with bigger style objects.
If you can counter that I might consider creating such a simple API

So your proposed API, in Flow types (with some slight renames):
export type StyleHack = {
  property: string,
  value: Array<string>,
  isApplicable: (browser: Browser) => bool,
  getValue: (originalValue: string, config: {prefix: string}) => string,
};

Looks fine to me (with more explicit names). But how would you specify, for example, the calc hack?

Well, isApplicable sounds nice, but getValue might not match all the time since I sometimes modify multi values (e.g. flexDirection: column-reverse gets both WebkitBoxOrient: vertical and WebkitBoxDirection: reverse).
According the calc hack:
I thought about leaving the property at all which then leads to adding it as something like a "global" plugin, that must get checked on every value (can't think of any other hack that needs global state by now). Alternatively we could sort out all props supporting the calc, but this might get kind of a big array :D
Maybe I will try some performance tests if this extra iterating even takes in count something noticeable. If not I am totally in with the function idea.

Your proposal in mind I can think of something like this:
Don't know if there is any usecase for config.browser, but
// type Browser => whole browserinfo object as bowser returns it
// also contains prefix (CSS, inline) as well as browser which represents the name used for the caniuse database (chrome, safari, opera, ie, firefox, ios_saf, ie_mob, op_mini, and_chr, and_uc, android)

export type StyleHack = {
  isApplicable: (
     browser: Browser
  ) => bool;

  propertyName: string || Array≤string≥;
  value: string || Array≤string≥;

  apply: (
    originalPropertyName: string,
    originalValue: string,
    browser: Browser
  ) => Object; // key-value pairs as property-value
};

With an object outputed we can easily use Object.assign to apply those and do not need to loop the array once again.
Also I'd like to separate the isApplicable to be able to prefilter all plugins.
Also having just an array of propertyNames and (optional) specific values, will help to keep the code as small as possible, as we only need to parse those once.

Also I'd like to separate the isApplicable to be able to prefilter all plugins

What is the need for prefiltering? I figured the hack would just check the property name or value in isApplicable, which will be just as fast as the core doing it.

Also having just an array of propertyNames and (optional) specific values, will help to keep the code as small as possible, as we only need to parse those once

I don't understand this; which code does it keep as small as possible? Also, why design an API for hacks that wouldn't cover the calc use-case? It's still a common use for prefixing.

Finally I would rename apply to resolve as we do not really apply the styles but only output the extra/modified version

I just chose apply to match isApplicable :). "if it is applicable, apply it"

Passing styles allows us to even resolve/check for multiple properties as mentioned above

Yup, sounds good.

With an object outputed we can easily use Object.assign to apply those and do not need to loop the array once again

Agree, returning an object is the best way to go.

@ianobermiller Hah now I get why its apply :D Also the prefiltering stuff is well, 0,005ms performance perhaps^^ So its just fine to leave that.
I understand that calc issue (as mentioned above I would solve that using some kind of "global" plugins that get checked on every value), but how would you do e.g. the 2012 flexbox standard I showed above with just one propertyName? Would you have a file for each property? Cause this would 'cause much more code in the end.

Yeah I don't think we need any helpers, I like the proposed function that just calls the checks itself. Nice!


Docs for Prefs code hints

[ ]  Update wiki pages on how to define code hints for preferences
[x]  JS Docs for define preference.
[x]  remove data.json
[x]  Find out core preferences that has not used the define preference API and add prefs docs.
[ ]  Update preference WIKI pages.
[ ]  Mail brackets committers/slack channel about the new API. Create entry in release notes for 1.4 for API change.

Update the wikis
https://github.com/adobe/brackets/wiki/Preferences-System and https://github.com/adobe/brackets/wiki/How-to-Use-Brackets#preferences

Find out core preferences that has not used the define preference API and add prefs docs.

I think @MarcelGerber covered this story in #11197.

Yes, but I see that some properties are still left not defined as a preference. But that could go in at a later time.

@abose Which preferences do you still see un-defined?
From what I can tell, every preference is defined, unless you're talking about things that should be preferences but aren't (JS Code Hints comes to mind)

@nethip I remember you mentioned about undefined preferences, Could you specify which ones did you see as udefined?

I don't think there are any undefined preferences, since we suppress defaultExtension pref, so it got excluded from code hints. _windowsScrollFix was excluded intentionally.

@sprintr I am working on this story https://github.com/adobe/brackets/issues/11056 wherein we are going to display default preferences along with brackets.json side by side in the split view. Right now I am regenerating default preferences by looping through all preferences using this call PreferencesManager.getAllPreferences(). While iterating through all preferences, I found that the following preferences do not have description field.
"linting.asyncTimeout": 10000,
"linting.usePreferredOnly": false,
"codehint.TagHints": true,
"codehint.AttrHints": true,
"codehint.SpecialCharHints": true,
"codehint.CssPropHints": true,
"staticserver.port": 0,
"codehint.UrlCodeHints": true,

Those are the exact ones we altered in #11197.

@MarcelGerber Yes I see that these are now going through definePreference, but the description is missing for all the properties.

I see, but #11201 should have fixed that.

@MarcelGerber you are right. I must be working on my branch which might have not this change.Thanks for pointing out the PR.

I believe this can now be closed since all the checklist items are done.

Thanks @sprintr . Closing as done.


Delete managed DNS record

Describe the bug
With a post REST API call I was able to create a dns record, with managed: true. Problem is that I cannot delete it through the GUI or a Delete REST call. Is it possible to make this more rigid against mistakes like this? And is there a way to delete managed records?
Expected result
Error Status 400, cannot create a DNS record with managed: true.
Actual result
Status 201
Code Examples
If really needed I will send some snippets.

Wow - creative :-)
Actually it shouldn't have been possible to create a managed record like this, although obviously nothing kept the API from doing so. I must think a bit about this, but I'm fairly certain the most straightforward solution is to disallow the API from creating managed records directly.
As for the problem of getting rid of the record you created: Have you tried to set it to managed: False using the API and then deleting it? By the way, that's also an operation that is supposed to be forbidden but probably isn't.
If that doesn't work, just determine the ID of the record you created and use nbshell like this (assuming the ID is 42, substitute the one you found for that value):
/opt/netbox/venv/bin/python3 /opt/netbox/netbox/manage.py nbshell
>>> from netbox_dns.models import Record
>>> Record.objects.get(pk=42).delete()
>>> quit()

OK, here's the result:

It is possible to create a managed record via the API
It is not possible to set a record to unmanaged via the API
It is not possible to delete a managed record via the API
It is, however, possible to set an unmanaged record to managed via the API

1 and 4 are definitely bugs and need to be fixed.


[feature] SendMessageBatch

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_SendMessageBatch.html

closed via 7d72854


Fix display depth to maximum of 8bpp?

The current code supports an 8bpp (and 4bpp, if you only use the first 16 colour values!), with a color translation on drawing (palt()), and a mapping to RGB on display (via a configurable 256 entry palette).  This fits with retro games consoles capabilities, and given the default low resolution and retro palettes provided this seems to be the main target for PX8.
However, internally the code currently stores pixels as 32bpp, and some functions seem to be written to support either color indexes or RGB values.
Do you have any strong desire to support more than 8bpp (i.e. 24bpp) in PX8?
I think that if you took the decision to only support up to 8bpp (at least for now) then the code could be simplified and I know could have some good performance improvements (I've already made them!).  As PICO-8 demonstrates, sometimes limitations are a good thing :-)

Yes sure !
I was doing some experiments with the 32bpp, so feel free to delete it, specially if there is an improvement ! Could you keep the palette switching ?

Ok great.  I'll submit a pull request.  It has still got palette switching (which uses an array rather than a HashMap).  I think you'll be pleased with the performance improvement :-)

got it !