Add array_repeat Spark function

This PR copied the existing impl. for repeat Presto function (see link) and made a few changes to align with Spark,.

Allow negative count and returns empty array, like count = 0.
Enlarge max limit for count arg to MAX_INT32 - 15 (see spark code).
Directly fail the execution if invalid count argument is used.

Spark array_repeat doc link.

@rui-mo, please take a review. Thanks!

Hi @mbasmanova, could you spare some time to review this PR? Thanks!

@mbasmanova, could you review further? Thanks!

@PHILO-HE This is a lot of copy-paste of complicated logic. Can we avoid copy-pasting and just refactor existing code to have a flag that allows zero and negative counts?

Allow zero and negative count and return empty array, like count = 0.

This can be a flag.

Enlarge max limit for count arg to MAX_INT32 - 15

This is actually dangerous. We should not create arrays with 2B entries. 10K limit in Presto is much safer.

Directly fail the execution if count argument is invalid.

This is incorrect and I believe is no longer the case.

Hi @mbasmanova, thanks so much for your comment! Yes, I agree with you. A simple flag can be introduced to the existing presto function to support negative count.  And it looks meaningless to enlarge the max limit for count arg, just in order to align with spark's code, as you pointed out that large limit (MAX_INT32 - 15) is not safe.
I just updated the PR. Could you review again? Thanks!

@mbasmanova, could you take a look again? Thanks!

@mbasmanova, thanks for your quite helpful comments! I just updated the pr. Could you help review further?


Fix small issue in ++op:dejs-soft:format when calling ++my:nl

Fixes #444

Seems like this got reversed in 7df058d "Reset %zuse pre 143.". Don't think that was intentional?

Definitely not, sorry!
Sent from my iPhone

On Nov 2, 2017, at 8:56 AM, Fang<EMAIL_ADDRESS>wrote:
Seems like this got reversed in 7df058d "Reset %zuse pre 143.". Don't think that was intentional?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Support 2-Letter Country Codes and States/Provinces for Choropleth Map

Hi, at the moment NeoDash supports choropleth maps using three letter country codes, but for my use case we're using two letter country codes, so if support could be added for that, it would be much appreciated.
Here is the IBAN table with the alpha-2 and alpha-3 codes for countries for your reference
and
Here are some of my country nodes at the moment just for the sake of clarity:

Also, consider allowing the Choropleth Map to show details of the states/provinces within the US, Canada, etc. using the same 3-char/2-char code convention!

Closed on 2.2.1

Great idea :heavy_heart_exclamation: Are 3-letters country codes also supported ?

Hi @adriens !
Yes. It was already supported. This https://github.com/neo4j-labs/neodash/pull/284 PR extended it to alpha-3 and n3 codes too.


Support gpt 4

Problems
go-openai 's function  CreateChatCompletion does not support gpt4，it provides support in 1.5.3 version, please upgrade go-openai to v1.5.3.
	if model != GPT3Dot5Turbo0301 && model != GPT3Dot5Turbo {
		err = ErrChatCompletionInvalidModel
		return
	}

At present, I don't have a gpt4 account, so I can't do any more tests for the time being. When I am qualified for gpt4, I will follow the support here.


Place to store non-python files shipped with OPS

Just to decide where to place additional files

[ ] logging configuration
[ ] css
[ ] example notebooks ?

Clarification: the question here is about where on the user's system these things should be installed, right? (I think example notebooks and logging conf are both reasonably kept in the examples directory of the repo, with logging in examples/resources. This might also be the place for the CSS, in the repo).
As for the user's system, I'm much less certain.


Embedded HAL Traits

This MR builds off of @fpagliughi 's netlink-update branch (https://github.com/mbr/socketcan-rs/pull/20).
I have implemented the following:

Embedded HAL blocking and non-blocking traits for CAN
Added examples for blocking read/write
Moved some code around into dedicated modules
Moved integration tests into tests/ folder

Could probably use some advice on the best way to map the errors.

Hi @nnarain! I have a bunch of questions about this:

Is the goal to make this crate portable to other (non-Linux) systems? Or to make application source code that would be easier to port to other embedded crates?

Would this be possible given the dependence on so many Linux and std crates (nix, etc)

What is the argument for doing this considering that none of the other Embedded Linux crates (gpio-cdev, i2cdev, spidev, etc) support embedded-hal interfaces?

Would we essentially get the embedded-hal compatibility "for free" or would we need to make tradeoffs with full Linux SocketCAN support? Meaning: Would it make implementing the full Linux capabilities more difficult to keep it compatible?

Assuming we do want to merge this, it seems there is a bunch of refactoring in this PR that might make merging a bunch of the older/stale PR's and forks more difficult. Should we try to merge those first and then rebase this? Or what would you suggest?

No this is not really related to cross platform support
The advantage of embedded-hal is being able to build platform agnostic drivers.
a. If I write a embedded-hal i2c IMU driver, for example, I can use that driver on ESP, NRF and STM32 devices that implement embedded-hal
b. It does look like there is a linux implementation in the same github org: https://github.com/rust-embedded/linux-embedded-hal
c. For CAN specifically I've started writing some CANopen related libraries (https://github.com/nnarain/can-rs). That can could work on Linux or embedded devices). Also platform agnostic CAN tools (candump, cansend, etc).
No trade off I'm aware of. The can::Frame trait in implemented on the type. Other socketcan specific data could be stored in the struct if necessary
a. I have a fork of tokio-socketcan for async support https://github.com/nnarain/tokio-socketcan
I'd suggest merging other MRs first and I'd rebase my branch.

I think regarding 2b. the alternative would implementing the can traits  in the linux-embedded-hal crate and reference the socketcan crate for that. I just did that for the current socketcan master branch here in a prototype. It's basically just a wrapper around socketcan, based on the current master branch. That's also the way it's done e.g. for the spi implementation, inverting the crate dependency relationship.
I noticed that on the master branch and latest alpha of embedded-hal 1.0.0-alpha.9 they seem to have moved the CAN module again into a separate crate called embedded-can. But I guess that makes little difference in the end. They also seem to have started splitting the async and blocking part.

That seems like a reasonable approach to me

I just went through your implementation and it looks very good, would you maybe copy those to a PR for the linux-embedded-hal crate or should I do that? I think it's kind of bad timing right now because either you update the linux-embedded-hal crate to  embedded-hal alpha.9 / master which will not work because there seem to be some stuff missing or you implement it for alpha.8 which will never become stable and already changed ;)... In the example I went with alpha.8 because it at least that way it compiles...

@marcelbuesing seems like you've already done the work, so perhaps you can put up a PR? Or is there still something you need to implement on your branch?

@nnarain , this should be a quick/clean rebase over master right now. Can you do that and push it? That way I can get started on the review while we wait for the other stuff.

@nnarain The other big PR for CAN FD is actually branched off of the old v1.x line. So I will drop this into master now and then start working to manually merge that one in. If you have time to answer some of my PR questions, that might help us clean up down the road. But master will be a WIP for a few weeks, so feel free to send in any small PR's to do some cleanup after it has landed.

I'll try to get to addressing the PR comments soon.


Add support for nested menus

The following code will allow for nested menus.

Do you have instructions on how to use it?

The instructions are the standard Hugo ones, having menus with a "Parent" defined. https://gohugo.io/content-management/menus/#nesting
    [[menu.main]]
    name = "Section folder"
    identifier = "sect"
    url = “/section/”

    [[menu.main]]
    name = "Sublevel one"
    identifier = "sub1"
    url = “/section/folder1/”

    [[menu.main]]
    name = "Sublevel two"
    identifier = "sub2"
    url = “/section/folder2/”

Hey @kd7uiy (cc: @appernetic) how would this PR be extended to support arbitrary depth nesting?
This is a great addition but as-is the nesting only seems to allow a single-depth nest, i.e., if I wanted to add another menu at /section/folder1/mycontent it will not render, even if I set the parent correctly.

Will consider it, but I borrowed the code from somewhere else, just figured out how to connect it. I'll add it to my todo list, but that list is rather lengthy at the moment, so...


Temp file in use by another process when opening document

Hey Fernandreu,
Got a problem with the editor that i don't know how to solve. I have reinstalled, uninstalled, rebooted and still get the issue. It says that 'the process cannot access the file (sometmpname.tmp) because it is being used by another process.
Any ideas on how to solve this?

Originally posted by @skorpio07 in https://github.com/fernandreu/office-ribbonx-editor/issues/125#issuecomment-845131879

Hi, will try your solution to see if it works. as for my machine, nothing has changed recently that i am aware of. Even weirder is that it will work with Word files no problem. only seems to be an issue with Excel files, even if excel is not open and i just rebooted.

so nope, still the file locking issue with excel files. should i open up a ticket with microsoft?

Nah, it should not be Excel's fault, and probably not Windows' either.
Just to give a bit more background: the tool creates a copy of your Office document in a temporary folder and keeps using that copy until you close / reload that document. This allows you to keep working with your document in the Office apps. But, for some reason, something else is getting on your way when trying to open that file that was just copied.
Interesting that the problem only occurs with network files (your comment here). My main guess due to that would be: do you have any security policies in that drive? I wonder if Windows is adding some protection which I did not take into account. Do you often see security prompts when opening documents from that drive? Such as "this file came from a network location and cannot be trusted".
I guess another thing to check is: does the issue also occur if you run the tool with admin rights?

Sorry to take so long to get back in touch with you. Running as admin gave
same results. No i don't get security notices as i whitelisted the network
location. for now i am copying the files to my local drive to get around
the issue. let me know what to try next.
On Fri, May 21, 2021 at 4:05 PM Fernando Andreu @.***>
wrote:

Nah, it should not be Excel's fault, and probably not Windows' either.
Just to give a bit more background: the tool creates a copy of your Office
document in a temporary folder and keeps using that copy until you close /
reload that document. This allows you to keep working with your document in
the Office apps. But, for some reason, something else is getting on your
way when trying to open that file that was just copied.
Interesting that the problem only occurs with network files (your comment
here
https://github.com/fernandreu/office-ribbonx-editor/issues/125#issuecomment-846171301).
My main guess due to that would be: do you have any security policies in
that drive? I wonder if Windows is adding some protection which I did not
take into account. Do you often see security prompts when opening documents
from that drive? Such as "this file came from a network location and cannot
be trusted".
I guess another thing to check is: does the issue also occur if you run
the tool with admin rights?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fernandreu/office-ribbonx-editor/issues/161#issuecomment-846224255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIKEIJGDVNKJZ2KRE72PP3TO24IZANCNFSM45HOKESQ
.


Show settings path in --show-settings output

Summary
Create a new struct called PyprojectConfig which holds all the pyproject.toml configuration related information. This includes the discovery strategy used (Fixed or Hierarchical), the settings itself and absolute path to the pyproject.toml file.
Using PyprojectConfig::new will try to resolve the given config path to absolute.
Test Plan
Project structure:
.
├── pyproject.toml
├── src
│   └── ...
└── test
    ├── foo
    │   └── __init__.py
    └── pyproject.toml

Using `--isolated` (no config path):

$ ~/contributing/astral/ruff/target/debug/ruff check --show-settings --isolated . | head -n8
Resolved settings for: "/Users/dhruv/playground/python/ruff-play/src/B031.py"
Settings {
    rules: RuleTable {
        enabled: {
            MixedSpacesAndTabs,
            MultipleImportsOnOneLine,
            ModuleImportNotAtTopOfFile,
            LineTooLong,

Using --config pyproject.toml

$ ~/contributing/astral/ruff/target/debug/ruff check --show-settings --config=pyproject.toml . | head -n8
Resolved settings for: "/Users/dhruv/playground/python/ruff-play/src/B031.py"
Settings path: "/Users/dhruv/playground/python/ruff-play/pyproject.toml"
Settings {
    rules: RuleTable {
        enabled: {
            UnnecessaryCallAroundSorted,
            UnnecessaryCollectionCall,
            UnnecessaryComprehension,

Using --config ../pyproject.toml

$ ~/contributing/astral/ruff/target/debug/ruff check --show-settings --config=../pyproject.toml . | head -n8
Resolved settings for: "/Users/dhruv/playground/python/ruff-play/test/foo/__init__.py"
Settings path: "/Users/dhruv/playground/python/ruff-play/pyproject.toml"
Settings {
    rules: RuleTable {
        enabled: {
            UnnecessaryCallAroundSorted,
            UnnecessaryCollectionCall,
            UnnecessaryComprehension,

Using hierarchical strategy to find config file

$ ~/contributing/astral/ruff/target/debug/ruff check --show-settings . | head -n8
Resolved settings for: "/Users/dhruv/playground/python/ruff-play/src/B031.py"
Settings path: "/Users/dhruv/playground/python/ruff-play/pyproject.toml"
Settings {
    rules: RuleTable {
        enabled: {
            UnnecessaryCallAroundSorted,
            UnnecessaryCollectionCall,
            UnnecessaryComprehension,

No config file (commented out [tool.ruff] section)

$ ~/contributing/astral/ruff/target/debug/ruff check --show-settings . | head -n8
Resolved settings for: "/Users/dhruv/playground/python/ruff-play/src/B031.py"
Settings {
    rules: RuleTable {
        enabled: {
            MixedSpacesAndTabs,
            MultipleImportsOnOneLine,
            ModuleImportNotAtTopOfFile,
            LineTooLong,

resolves: #3202

What's your take on this?

This is a much better idea. At first I thought to add it as an additional element to the tuple itself but I think a struct is a better option for the long term.

Could you add a test plan to the PR summary showing the new output?

Yes, will add it.

I'll make both the changes in the evening.

I've updated the code and PR description :)
I'm getting error: Broken pipe (os error 32) when I'm piping it to the head command. Is it a bug or some problem in my shell?

I'm getting error: Broken pipe (os error 32) when I'm piping it to the head command. Is it a bug or some problem in my shell?

I experienced this in the past too when using less but haven't spent any time investigating why this is happening.

I think this is related: https://github.com/rust-lang/rust/issues/46016


DataFrame index treated inconsistently by array_preview

Sometimes it prints the index, sometimes it doesn't, see screenshot. Can you confirm whether this is a "feature" or a bug?

Sorry for the delay. Yes, this is intentional.
When output as is specified to Excel values, a DataFrame will only output the index if the values of the index column are not numeric (in the case of describe(), or group_by())  OR   if the index name has been set.
Will add this to our dataframes documentation

Thanks Felix! Good point. Follow up with the team, to understand what is going on there.

Thanks! I'd still love to be able to decide myself whether the index is shown or not. If I give my index a name in sheet1.A1, which will have a side effect on what I do in sheet10.Z50, that could be very confusing. I'd argue that the conversion from Python object to values would be much cleaner via Data Type properties (such as A1.arrayPreview that exists today), so you could choose A1.valuesWithIndex or A1.values (which would default to no index).

Adding a comment here. This is expected. If index is explicitly set by users (in this case index = [0,1,2]), we show the index on the UI. By default, pandas dataframe creates auto generated range index if index is not explicitly set by users. We suppress those auto generated index, which explains why you don't see index generated for df1.


getting a grey block with my own data

Hi,
I'm having problems with my data. The unet works with the testdata, but it doesn't work with my data. I only get a block of grey pixels as a prediction. I would like to use this unet for a university project.
Here is my google colab for you to test, feel free to edit: https://colab.research.google.com/drive/13i18jJbHRswCgCg8Nmz79c_M4M8JQFxG
this is my github repo: https://github.com/Machuntox/unet.git
greetings,
stefan

Hi,
Can you help me with creating my own dataset. I have a set of images and the coordinates of the classes need to be segmented. I need to generate the label file for every real image.
Thanks

Hey I'm also getting grey pixels as predicted output for my image of size 800x400. If you have resolved this issue please let me know.

@sudhasubramaniam Are you sure your model is good enough to see good result? At first, I had the same problem as yours but it turned out the metric i used 'accuracy' is not good for monitoring the training. Because even the model is bad, the accuracy is still high.
You should try use other metrics like IoU to evaluate your model.

If your problem is exactly what i said, maybe you had the same problem as this post #133. I also wrote my solution in there.


New features request

Hello I'm very happy with this vpn: setup very easy also for me that I'm a very newbie on linux world.
Could I ask a new other installer script for doing:
a) using a wan (or lan) interface instead to the same: lan at eth0 and wan at wlan or other plugin eth
b) do a lan to lan connection between more raspberry pi, but not all at same time. My dream is more raspberry waiting to connect to me (mine is server side) by select a checkbox I ask them to connect me without man at client side. Also a signal of life (such as red / green mark) could be useful
These request are a beta test for teleservice equipment, so I can pay a little for these features.

@redfast00 ???

I didn't really think this was in scope of PiVPN, but the user offered to pay, so I left it open in case other users wanted to do this. Closing this.


Incompatible w korean patch

landing on the LLL's modded moon with the unofficial korean patch installed causes an error(It appears to be a bug that has occurred since LethalLib 0.14).

korean patch may have little issues because it was developed before Lethal Company's BepInEx was released. Typically, when an asset is replaced, the internal name of the item changes.

It doesn't seem to be a LethalLib issue. sry!


[Feature Request] In-memory database

Hi there, thanks for making this library! I was wondering if it's possible to add an option for the database to be forcibly created in memory:
class ExecutionContext(object):
    # ...
    def __init__(self, path, schema, auto_commit=True):
        source = sqlite3.connect(str(path))
        self.conn = sqlite3.connect(':memory:')
        source.backup(self.conn)
        # ...

I added this snippet to puchikarui.py and it sped up lookups by about 30-40% (7.7 seconds down to ~4 seconds). Of course, ideally the database would be kept outside of the context construction. I'm currently have reuse of contexts enabled.

Hi @Techno-coder thank you for the suggestion. I really appreciate it
I think holding the whole database in memory and query from there directly is a great idea. Can you elaborate on how one may use this feature?
Are we building the DB from source XML files into :memory: before use every time and use it? I'm thinking may be we can also dump the pre-built database into an .sql file and insert it in batch mode. May be that will be faster than importing from XML directly.
How about loading the prebuilt database into memory directly? That feature is available in Python 3.7 backup() function but we may have to do something for earlier versions like 3.5 or 3.6.
Anyway this is great. I'd love to work on this feature. Please let me know what you think.

At the moment I'm loading the prebuilt database from jamdict-data. The main reason I want the whole database in memory is because I am doing a lot of lookups (in the thousands) and the disk I/O time incurs some significant overhead in lookup time. With regards to startup time I imagine that loading the prebuilt database will be faster than building from the XML files.
This answer on StackOverflow dumps the database into a .sql file as you suggest before loading it into memory. It should work on nearly all Python versions.

I use :memory: quite often when I'm testing Jamdict code so the fucntionality is actually already there. Let me try how to make it convenient I'll update you on this soon. Thanks again for suggesting this feature.

Hi @Techno-coder again.
I have added a new data source type into puchikarui based on your suggestion. The actual code change is in on this line https://github.com/letuananh/puchikarui/blob/ec4f445d29373c98de64e51aee2760cb58ab2258/puchikarui/puchikarui.py#L273
This data source is available from puchikarui 0.2a1 on PyPI: https://pypi.org/project/puchikarui/0.2a1/
To use this feature one can just pass in a MemorySource object as path, for example:
from puchikarui import Database, MemorySource

db = Database(MemorySource("source.db"))
ctx = db.open()  # this ctx will operate on :memory:
...

With this, I added a new kwarg memory_mode to Jamdict. When memory_mode=True Jamdict database will be loaded into memory before use. For example:
jam = Jamdict(memory_mode=True)

On my computer this takes about a minute to load. I haven't tested to see how much the query performance is improved.
I'll get back to you on this.
This change will be available on Jamdict >= 0.1a10. I only deployed it to TestPyPI though: https://test.pypi.org/project/jamdict/0.1a10/ You can install this from Github or TestPyPI
# install from (my) Github repo
pip install git+https://github.com/letuananh/jamdict.git

# install from TestPyPI
pip install -i https://test.pypi.org/simple/ jamdict==0.1a10

I'll test this change a little bit more before releasing it to PyPI. Mean while it's best if you can help me to test it out to see how it works on your side. Thank you.

Thank you very much for working on this feature! It looks like it's working as intended on my end.
Without memory_mode enabled:
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
   174423    3.739    0.000    3.739    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
        1    0.523    0.523    0.766    0.766 vocab.pyx:468(from_disk)
   174423    0.444    0.000    5.494    0.000 puchikarui.py:506(execute)
   174423    0.402    0.000    0.630    0.000 puchikarui.py:300(build_select)
   174423    0.395    0.000    0.625    0.000 puchikarui.py:118(<listcomp>)
   174423    0.350    0.000    7.242    0.000 puchikarui.py:446(select_record)
   178597    0.318    0.000    0.318    0.000 {method 'format' of 'str' objects}
   177570    0.228    0.000    0.530    0.000 __init__.py:1284(getLogger)
    10589    0.183    0.000    8.012    0.001 dictionary.py:10(find_definitions)
     3840    0.182    0.000    6.291    0.002 jmdict_sqlite.py:172(get_entry)

With memory_mode enabled:
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
   174423    0.798    0.000    0.798    0.000 {method 'execute' of 'sqlite3.Cursor' objects}
        1    0.522    0.522    0.766    0.766 vocab.pyx:468(from_disk)
        1    0.490    0.490    0.490    0.490 {method 'backup' of 'sqlite3.Connection' objects}
   174423    0.371    0.000    0.584    0.000 puchikarui.py:300(build_select)
   174423    0.359    0.000    2.232    0.000 puchikarui.py:506(execute)
   174423    0.304    0.000    3.652    0.000 puchikarui.py:446(select_record)
   178597    0.235    0.000    0.235    0.000 {method 'format' of 'str' objects}
   174423    0.232    0.000    0.420    0.000 puchikarui.py:118(<listcomp>)
   177571    0.209    0.000    0.460    0.000 __init__.py:1284(getLogger)
    10589    0.175    0.000    4.819    0.000 dictionary.py:10(find_definitions)

The time spent in sqlite3 has been reduced by 80%.
By the way, I had to enable auto_config=False otherwise it would throw this exception:
  File "/Users/z/.local/share/virtualenvs/yomeru-nlp-HqGNwivf/lib/python3.9/site-packages/jamdict/util.py", line 249, in __init__
    self.jmd_xml_file = jmd_xml_file if jmd_xml_file else config.get_file('JMDICT_XML') if auto_config else None
  File "/Users/z/.local/share/virtualenvs/yomeru-nlp-HqGNwivf/lib/python3.9/site-packages/jamdict/config.py", line 130, in get_file
    _config = read_config()
  File "/Users/z/.local/share/virtualenvs/yomeru-nlp-HqGNwivf/lib/python3.9/site-packages/jamdict/config.py", line 98, in read_config
    __app_config.load()
TypeError: load() missing 1 required positional argument: 'file_path'

Not sure why I'm getting this error since it doesn't look like the code's changed between versions. Maybe I've messed up my environment somehow?

Hi again. Thanks for your performance test log. This looks great.
As for the read_config() it was indeed a bug as config file is no longer mandatory with the release of the jamdict-data package. Thanks for spotting it out. I fixed it but somehow I forgot to deploy the patch. I updated the release on Test PyPI (version 0.1a10.post2) and hopefully this will solve the issue you are encountering.
https://test.pypi.org/project/jamdict/0.1a10.post2/

Yep, updating to post2 fixed it :)

Yay, this is great, thanks! I will test it a little bit more, and will deploy it to PyPI soon.


Allow commands to not worry about parsing of flags instead of using double dash

Many commands that can be called by ahoy use their own flags. Currently you need to separate those flags from ahoy flags using a double dash --. Instead allow commands to ignore flag parsing.

Works, just add skipflagparsing: true to the command you want to ignore flags on.


make sound integration system

refactor current bgmsetup to actually return bgm object, and add in new ones for sfx

resolved with #20


genesis: begin reworking genesis to enable deterministic initialization of initial chain state

Today, in order to initialize a validator's initial chain state we need to disseminate a "GenesisConfig" which the validator then attempts to re-perform the entire genesis process from scratch. Unfortunately this process can be non-deterministic if configured to generate accounts without a pre-set address.
This PR changes this process by instead allowing for the genesis ceremony to be performed a single time and then have the resulting state packaged in a Genesis struct, which is then included in a validator's ValidatorConfig. This resulting state can be used to deterministically populate the initial state of the chain. More specifically, when a validator starts up and its storage is empty, it will process the contents of the Genesis struct to populate storage with the initial state of the chain.
This builds off of https://github.com/MystenLabs/sui/pull/1939 and implements the missing piece required for deployment as a validator's ValidatorConfig will have a complete picture of everything a validator will need when starting up.
There is still a bit more work to be done to make the genesis process a bit cleaner. Ideally genesis would be a single Transaction Certificate and this is a step toward that reality.

most of the things commented out were mostly around a "we probably want to do this but so I don't forget i'll comment it out". Which should be fixed on a follow up.


fakejob(engine): refactor fake job based on master/worker framework

What problem does this PR solve?

Issue Number: ref #7225
What is changed and how it works?
Refactor fake job based on master/worker framework
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-engine-integration-test

/run-verify

/run-engine-integration-test

/run-engine-integration-test

/run-engine-integration-test

chaos test passed: https://github.com/pingcap/tiflow/actions/runs/3619330555/jobs/6100245336

/merge

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

/run-verify
/run-engine-integration-test

/run-all-tests

/merge


getfield for Node ptr

This is the same issue/approach as #142
I'm doing some profiling on XLSX.jl and this picks up a nice little win

# master
julia> @btime XLSX.readtable(f, "Sheet1")
  341.240 ms (3018190 allocations: 98.87 MiB

# PR
julia> @btime XLSX.readtable(f, "Sheet1")
  284.024 ms (1940230 allocations: 54.22 MiB)

gentle ping @bicycle1885  - any changes you'd like to see here?

@chris-b1 He does maintain the package in GitHub. You should email him in person and let him know that there is a pull request. I wish we had moved this repository to an organization to let others continue developing the package.

@chris-b1 I appreciate your suggestion. However, I discovered this will be fixed by the improved compiler and what we need to do is just waiting for the next release of Julia (i.e., Julia 1.6). For example, lots of instructions related to getproperty in Julia 1.5.3 are optimized out in the latest nightly build of Julia as follows:
julia> code_native(hasparentnode, (EzXML.Node,))
        .text
; ┌ @ node.jl:616 within `hasparentnode'
; │┌ @ node.jl:398 within `getproperty'
        movq    (%rdi), %rax
; │└
; │┌ @ operators.jl:204 within `!='
; ││┌ @ pointer.jl:155 within `==' @ promotion.jl:410
        cmpq    $0, 40(%rax)
        setne   %al
; │└└
        retq
        nopl    (%rax)
; └

julia> versioninfo()
Julia Version 1.7.0-DEV.6
Commit 5f1b21b357* (2020-12-09 16:06 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: AMD Ryzen 9 3950X 16-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.0 (ORCJIT, znver2)
Environment:
  JULIA_PROJECT = @.

julia> code_native(hasparentnode, (EzXML.Node,))
        .text
; ┌ @ node.jl:615 within `hasparentnode'
        pushq   %r15
        pushq   %r14
        pushq   %rbx
        subq    $48, %rsp
        vxorps  %xmm0, %xmm0, %xmm0
        movq    $0, 32(%rsp)
        movq    %fs:0, %rbx
        leaq    16(%rsp), %rdi
        movq    %rsp, %r14
        movabsq $140301301986384, %rcx  # imm = 0x7F9A71443450
; │ @ node.jl:616 within `hasparentnode'

... and many instructions!

julia> versioninfo()
Julia Version 1.5.3
Commit 788b2c77c1 (2020-11-09 13:37 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: AMD Ryzen 9 3950X 16-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, znver2)
Environment:
  JULIA_EDITOR = "/usr/share/code/code"
  JULIA_NUM_THREADS =

Given that the current performance is not devastating and the suggested change affects many lines, I think it would be better to stay and wait for Julia 1.6.


Convert commonjs code to esm during build

When shipping PRC as esm, we want to ensure there is no commonjs code in the lib-esm directory.  I've fixed one case of this in #2149, but theme-preval is another that is a little tougher to address because it is built as part of the babel build script.  Rather than writing something custom for this one file, I decided to pull in babel-plugin-transform-commonjs which will automatically convert files to esm if commonjs imports/exports are detected.  This affects the following files:

BaseStyles is addressed in #2149 and will drop off the list once that PR is merged
theme and theme-preval are the files we are targeting.  I had to change from a named theme export to just using the default export because of the way preval outputs results.  This change shouldn't have an impact on consumers of the library unless they are reaching all the way into the lib-esm/theme-preval.js file.
The rest are all test/type utility files that have some commonjs code in them, but are not actually intended to be used by consumers

Closes #2148

@dgreif is there a good way to test that this plugin is working correctly and doesn't break anything?

Good question @colebemis, I did do a test where I committed the lib-esm directory and then compared the before/after (which is where the screenshot in the description came from).  The output looked as I expected for theme-preval, and also lead me to the issue in BaseStyles (which is now fixed/merged).  I'd say the next step is to pull this into one of our other projects and give it a try.  I'll try it out in dotcom now.


[python package] added get_ref_chain function to Dataset object, used it in train() to…

… compare if training and validation have common reference ancestors.
Basically, in engine.py, the train() function no longer directly sets the reference of valid_data to be train_set, but rather checks to see if valid_data and train_set are both derived from the same 'ancestor', and only does does the reference setting if not.   In order to do this check I implemented a method for the Dataset object which returns the dataset itself, its reference, the reference of its reference, etc.
This should resolve #714
I built lightgbm with the changes and ran the example code in #714 which showed an error, and with the modifications there were no more errors.  Let me know if there are other checks I should do.

@j-mark-hou,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@j-mark-hou, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@j-mark-hou
you solution is to avoid calling valid_data.set_reference(train_set) .
I think it cannot solve the issue.
I think a better solution is checking the dataset have common reference or not here (https://github.com/Microsoft/LightGBM/blob/master/python-package/lightgbm/basic.py#L1009-L1013) .

Sure, I can go ahead and make that change.  My initial impression was that a function named set_reference should actually force a setting of the reference irrespective of whether or not they already share the same ancestor, but if that's the only way to go I'm happy to move the check in there.

can you fix the pep8 format checking?


Correctly release values in TypedArray's toLocaleString

When the toLocaleString was called on a TypedArray's value
the resulting object's toString/valueOf invocations could
create errors. These error values were not released.
In addition the input element value for the toString operation
was released twice in case of an error.
Fixes: #4148

LGTM (informal)


Adding additional yum repos

Signed-off-by: Patrick Hession<EMAIL_ADDRESS>Problem: yum does not have the ability to find cortx_iso repo files by default
Solution: create the appropriate cortx_iso repo files sop that yum can find the correct files to install

View rendered README.md

Can one of the admins verify this patch?

@hessio Can you please describe in the PR what problems does it solve?
Ideally, that information should be seen in the commit message as well.

Ok I have updated my PR information now @knekrasov


GEODE-5338: Geode client to support Trust and Keystore rotation

A new ssl property 'ssl-use-default-provider' is added to let clients
provide custom implementations to manage keystore and truststore and
custom implementations for KeyManagerFactorySPI and TrustManagerFactorySPI.
Geode expects that the provider is added at the runtime by client applications
before initializing the cache or initiating a connection.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Please find the proposal for this change on Geode WIKI.

@upthewaterspout Thanks for the feedback.
When we initialize a TrustManagerFactory with null, the default implementation is to load and trust all certs available in the trust store shipped with JDK (for eg: /jre/lib/security/cacerts). So more than changing the name or semantics of the parameter I need to address the security concerns of trusting all certs.

I think it might be better if the parameter were more specific - something like ssl-key-management-provider or ssl-use-default-key-management. I'd also prefer not adding specific options for trust-manager and key-manager but just have a single option seeing that they will always go together.

@jdeppe-pivotal @upthewaterspout
I have changed the property to be ssl-use-default-sslcontext which is more appropriate to the intended behavior.  This gives users to choose between whether to use a default SSLContext and let Geode configure with specific settings (stores, managers, protocols and ciphers). So when user sets ssl-user-default-sslcontext, a default SSLContext is used using SSLContext.getDefault().
So in SocketCreator, we can chose between creating default context vs configuring with user provided settings as in:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java

private SSLContext createAndConfigureSSLContext() throws GeneralSecurityException, IOException {

    if (sslConfig.useDefaultSSLContext()) {
      return SSLContext.getDefault();
    }

    SSLContext newSSLContext = getSSLContextInstance();
    KeyManager[] keyManagers = getKeyManagers();
    TrustManager[] trustManagers = getTrustManagers();

    newSSLContext.init(keyManagers, trustManagers, null /* use the default secure random */);
    return newSSLContext;
  }

@pivotal-jbarrett
Looks like we have default values used when not specified by the user.  Specifically for ssl-keystore defaults to {user.home}/.keystore and ssl-truststore defaults to {user.home}/.truststore. So making default context as the normal use-case would break backward compatibility.

@jdeppe-pivotal @upthewaterspout @pivotal-jbarrett @bschuchardt
Could I request a re-review of this PR?
GEODE-5594 is merged to develop and introduced an improvement to enable geode clients to validate hostnames to address the security concerns about trusting the default trust store. With this flag users wanted to use default context or custom security provider can enable hostname validation. Also, using default context is not the default behavior as it would break backward compatibility.
So with this new flag ssl-use-default-context, users have a choice:

Decide whether you want SSL? Enable using 'ssl-enabled-components'
Great. Do you want to use
2.a) default ssl context? use ssl-use-default-context or
2.b) configure ssl context with specific trust and key store types, locations, passwords (by providing ssl-key* and ssl-trust*)
In any case (2.a or 2.b) you have an option to restrict SSL protocols and ciphers (using ssl-protocols, ssl-ciphers)
In any case (2.a or 2.b) you have an option to enable mutual auth (using ssl-require-auth)

Hostname validation is enabled by default and a warning is logged when user is not using default context and he/she can disable it setting to ssl-endpoint-identification=false


optimization and add absen_reminder.py

add better log, and browser window closed exception and absent reminder module (belum di connectkan ke ravioli)

changed fyglet into art library, it also changed the requirements


Newly added people are unable to see previosly added story-snaps

When a person adds my bot, he is not able to see snaps that are already posted on my bot's story.
Snapchat normally doens't function like this. Is there a solution for this?

Set the setting og the account to :

Everebody can see my story

@ricoxor I think that doesn't help though.
I had this issue as well and I'm sure I had that option configured. I think say, I post something to my story, and then someone adds me, they can't see what I posted because it was pre-add. I think this is an intentional feature but I'm just assuming.

What @ricoxor said is correct!


Pip Install does not down load 4.8 version

Hi I am trying to down load the 4.8 version using Pip. For what ever reason I can not get past 4.7. And 4.7 does not work with json data format.
Temporarily I was able to work around copying those files to Site requirements. However can you please suggest how can I get those files.

Need to publish 0.4.8, it has only https://pypi.org/project/robotframework-requests/

I published 0.5.0 now


Display uploadBy on views

Done for Collection.  We don't currently add this to all the members, so it only appears on the Collection formed by submit.  I think this should be okay.  Please re-open, if disagree.


wofi-emoji: unstable-2023-12-22 -> 1.0.0

Description of changes

Update wofi-emoji: unstable-2023-12-22 -> 1.0.0
Changelog: https://github.com/Zeioth/wofi-emoji/compare/2cc95880848134a3bbe0675bcb62a0dae1d0f572...v1.0.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Note to myself: after this is merged, backport this and also the previous commits to fix #308357.

Result of nixpkgs-review pr 308412 run on x86_64-linux 1

1 package built:

wofi-emoji


Embeds OVAL details about test to graph

This PR embeds OVAL details about test to graph. After click on some test display OVAL details about test. Does not implement reference variables.
Fixes: #66

Hello @Honny1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_arf_to_json.py:

Line 109:100: E501 line too long (102 > 99 characters)

/packit copr-build

There is an issue with a file permission-related rule file_permissions_library_dirs:

The OVAL specifies (searches for) objects that have gwrite and owrite set.
The summary indicates that it specifies objects with all permissions unset

Great enhancement! Some issues may pop up, as introduction of OVAL objects is a huge thing, but they can be addressed in subsequent PRs.


Add CI for Rabbit Consumers

Adds a Github workflow for Pylint which only checks the rabbit
consumers.
Adds a template CI for rabbit. This is effectively a no-op until a
future commit adds the testing framework and some unit tests.

Marking this as ready to review, despite the fact Pylint is failing
I don't want this PR to grow unweildly, and some of the changes (exception handling / modernisation) require unit tests which will come with the next PRs in the series


Minimal-Reddit is not working

The Minimal Reddit only works on new.reddit.com

After the update that completely removed new.reddit.com, you have updated the style on 7th September. How can we apply this style now? Trying to apply it on reddit.com/ URLs does not seem to work. Any guidance would be highly appreciated.

Can you send a screenshot of the version you are on? I tried to reproduce the problem but I can't, I tried to remove and install via https://userstyles.world/style/9384/minimal-reddit but it's working and being applied to new.reddit.com

@SEALCOOL13 You can try the previous version, the only thing I changed was identifying the options: https://github.com/zenstorage/Minimal-Reddit/raw/18595ad00e478eb34fea7dd0a3909a185cf95067/minimal_reddit.user.styl

It does not work with either the normal updated version or the version you linked above, I even disabled my adblocker etc. to see if that was causing an interference. Do I need to somehow activate something from the style settings?

I misunderstood. You are using the sh layout and said that new.reddit.com has been completely removed. Unfortunately, userstyle doesn't work with this layout (I will practically have to recreate the userstyle to add/make the options work). Maybe it's some A/B testing. I can still access new.reddit.com with the layout.
Unfortunately, until I make it work in sh, the userstyle won't do anything

Thanks for the clarification, hope you can implement it for the new UI, I really wanted to try it as it looked great and the new rounded Reddit UI is very wasteful of screen real-estate in my opinion. Oh well...

I made a version for the sh interface; it doesn't have all the options yet, but I included the ones I considered most essential: https://github.com/zenstorage/Minimal-Reddit/raw/main/minimal_reddit_3rd.user.styl. Some options do not work because they are isolated with shadowRoot. You will need to install a userscript: https://greasyfork.org/scripts/459799-style-shadowdom.
Currently, the options that only work with the userscript are:
Searchbar:

Border radius
Remove trending
Remove nsfw"


Cleanup datasets and demos

Changes proposed in this pull request:
This PR is intended to clean up the project in two main aspects:

Remove datasets from the project as now they are placed in a dedicated repository: https://github.com/scikit-multiflow/streaming-datasets

All references to dataset file were replaced with generators whenever possible or with the corresponding URL for the dataset in the repository
The file used in functional tests for FileStream and DataStream was replaced with a smaller version exclusive for testing.

Make the demos module private (_demos) as now most of the methods include usage examples in their docstrings. This is the first step in the eventual removal of this submodule.

Checklist
Implementation

[x] Implementation is correct (it performs its intended function).
[x] Code complies with PEP-8 and is consistent with the framework.
[x] Code is properly documented.
[x] PR description covers ALL the changes performed.
[x] Files changed (update, add, delete) are in the PR's scope (no extra files are included).

Tests

[ ] New functionality is tested.
[x] Tests are created for the new functionality or existing tests are updated accordingly.
[x] ALL tests pass with no errors.
[x] CI/CD pipelines run with no errors.
[x] Test Coverage is maintained (coverage may drop by no more than 0.2%).

Thanks for the changes @jacobmontiel. The package size is going to be reduced considerably!
I let some minor comments in some parts of the changed code.

I did a fast search locally and found some references to the (now) outdated datasets folder in:

.gitattributes
docs/user-guide/quick-start.rst (is that one generated with the documentation?)
MANIFEST.in

Should these references be removed from the mentioned files in this PR?

I did a fast search locally and found some references to the (now) outdated datasets folder in:

.gitattributes
docs/user-guide/quick-start.rst (is that one generated with the documentation?)
MANIFEST.in

Should these references be removed from the mentioned files in this PR?

I removed the references from MANIFEST.in and updated the example in quick-start.rst in e8b8f3fd3bb60bd1e6ad657e3fe45da11ac0a8d2.
I am keeping the reference in the .gitattributes since it applies to the repository history that will still have those files for backward compatibility.

Thanks for the last changes @jacobmontiel!

I am keeping the reference in the .gitattributes since it applies to the repository history that will still have those files for backward compatibility.

Nice catch! I believe the PR is ready to be merged. Nonetheless, the CI/CD tests are failing, though the problem does not seem to be related to this PR. Do you have any leads about the source of the problem?


ENH: Add subspace spectral estimation methods to scipy.signal

Need to add subspace spectral estimation methods to scipy such as:

Pseudospectrum using eigenvector method
Pseudospectrum using MUSIC algorithm
Frequency and power content using eigenvector method
Root MUSIC algorithm

no follow-up and not high-prio, so closing.


Deadlock / Loop protection in 2.0 beta

Hi,
I have been working for a while now with ReactiveKit, but a couple of days ago I upgraded my code to work with the new 2.0 beta. Unfortunately I'm running in quite a few crashes due to infinite loops and deadlocks. Caused by looped behaviour and two-way bindings.
Before I understood there was a protection mechanism that prevented these issues, but it seems with 2.0 beta this is not in play anymore. Especially for the two-way bindings this seem to be quite an issue in my project.
Any thoughts on this?

Hi @rsaarloos, thanks for the feedback. All the changes have probably broken few things and that's why I'm still keeping it in beta. I'm currently writing unit tests and fixing any issues I find for next beta release. Hopefully I'll have that in next few days.
If you could pinpoint what exactly is causing problem for you I could fix it faster.
Thanks,
Srdan

Den 12. apr. 2016 kl. 18.32 skrev rsaarloos<EMAIL_ADDRESS>Hi,
I have been working for a while now with ReactiveKit, but a couple of days ago I upgraded my code to work with the new 2.0 beta. Unfortunately I'm running in quite a few crashes due to infinite loops and deadlocks. Caused by looped behaviour and two-way bindings.
Before I understood there was a protection mechanism that prevented these issues, but it seems with 2.0 beta this is not in play anymore. Especially for the two-way bindings this seem to be quite an issue in my project.
Any thoughts on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Hi @srdanrasic I will check what I can do, although my knowledge of the inner workings of ReactiveKit is very limited.
I created an example project here: https://github.com/rsaarloos/reactivekit-two-way-binding-example that provides an example of the two way binding that is used in my project (it will currently crash on any change).

Thanks @rsaarloos, that should ne enough. I'll prioritize that issue.

Hi @rsaarloos, please try v2.0.0-beta3 and check if it solves your issues. Thanks!

Hey @srdanrasic, this fix seems to resolve the issues I was having. Many thanks, really appreciate the quick help here! Will close the issue.

Sure and thank you for pointing this out! If you encounter any more issue feel free to open another ticket/s.


1.18.2-0.6.5 seems incompatible with lithium/radium

Describe the Bug
Attempting to load the game with Flywheel 1.18.2-0.6.5 and Radium 0.7.10 results in a crash
Reproduction Steps

Have Flywheel 1.18.2-0.6.5 and Radium 0.7.10
Start the game
Profit
...

Expected Result
The game to start
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/1riVf0Xm
Operating System
Windows 10
What is your GPU?
AMD 6800XT
Mod Version
0.6.5
Minecraft Version
1.18.1
Loader Version
Forge 40.1.73
Other Mods
See log for full list, but it's reproducible just by flipping the flywheel version back and forth.
Additional Context
Also have Magnesium, rubidium, and starlight but as stated everything is fine with the previous version of Flywheel.

yup, ive got the same crash

dont think this is radium related, you are probably running a create addon not updated for newest flywheel

Try using the Canary mod rather than Radium. It's also a forge port of lithium, but it's more stable in most cases.


Enable purely iteration-based training

What does this PR do?

Fixes #3521
This preserves the existing default of min_epochs=1 if both min_steps and min_epochs aren't specified, and the default behavior of max_epochs=1000 if both max_steps and max_epochs aren't specified.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified
[x] Check that target branch and milestone match!

Did you have fun?
Make sure you had fun coding 🙃

this is the same as #5686 #5687 correct?

this is the same as #5686 #5687 correct?

this is the same as #5686 #5687 correct?

yes that's correct, i'm sorry about the noisy PRs. i made some n00b git errors and it was easier for me to create a new PR than fix the existing ones

one thing i need to check is what happens to the progress bar


[cocoon] AppEngine deploys failing due to cocoon_scheduler not in path

Because cocoon_service depends on cocoon_scheduler from path which doesn't exist (could not find package cocoon_scheduler at "../scheduler"), version solving failed.
The command '/bin/sh -c pub get' returned a non-zero code: 66
ERROR
ERROR: build step 0 "gcr.io/cloud-builders/docker" failed: step exited with non-zero status: 66

https://github.com/flutter/cocoon/pull/1209
We can get around this by making cocoon_scheduler a subproject in app_dart.

Triage: Do we have any update this? Either revert some PRs or a quick fix?

This is blocked on Cocoon CQ failures due to Dart roll breaking app_dart project: https://github.com/flutter/flutter/issues/82705. Once that is fixed, linked pull request can land and unblock deploys


Module 1 exercises [George Senyo Owusu]

Please "drag & drop" exercise 1 file below.

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

WS2_M1E1_Submission.docx
3. If you haven't done so, please go back to Module 1 and make sure to take
the post-training survey.

Thank you for your successful submission to the practice exercise! Please be sure to fill out the post-Module survey.


[REVIEW] Fix docs build to be pydata-sphinx-theme=0.13.0 compatible

This PR fixes kvikio docs build to be compatible with pydata-sphinx-theme=0.13.0 by adding an empty icon_links entry.

/merge


CRIMAPP-875 - Move column 'applicant_self_assessment_tax_bill'

Description of change

As Self Assessment tax bill is an outgoing payment, it must have an entry in outgoings table
Move column applicant_self_assessment_tax_bill from income. applicant_self_assessment_tax_bill to outgoings. applicant_self_assessment_tax_bill

Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAPP-875
Notes for reviewer

[!NOTE]
Initially we were creating outgoings payment of {type: "OutgoingsPayment"} and updating income. applicant_self_assessment_tax_bill, which is wrong.
Outgoing payments should be associated with outgoings

Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature
http://localhost:3000/applications/:id/steps/income/client/self_assessment_client

Is the step / URL still correct even after the change from income to outgoings ? @ripan

@mseedat-moj Although we are dealing with outgoings, this question "Does your client pay a Self Assessment tax bill received in the last 2 years?" is part of income journey. Thats why we decided to keep it under 'income' namespace


Needs update for recent 1.6 patch

Please update for use with recent 1.6 patch.

Yes please, It's actually one of the first mod I ever download because I wish to try let there be flight and it's broken :(
Can we have an update about the situation..?

Let there be flight is the only mod i use.
Since 1.6 its not working. Everything load fine in log but still get script not loaded error when i press play and i dont have the mod menu and when in the car i cant move at all. Keyboard not responding.
I wish i can send you an error log but everything loaded in the log.

Fixed in https://github.com/jackhumbert/mod_settings/commit/b2ba9717bafedfa3c084d7a04c5b986b5efd2e75 / v0.0.3


https://vcenter6-eqx.noc.lan/rest/vcenter/host/{host} is not available

GET /rest/vcenter/host/{host} is currently not implemented.
So there seems to be no way to obtain host information (such as CPU type).
However the corresponding command exists in the other SDKs in Perl or PowerCLI
and the information exists in vSphere.

Getting a single host is currently not implemented through the REST API yet. The information does exist and is available from the SDKs that are backed by the SOAP API. Please do report any inconveniences or issues you run into. It helps us to prioritize. Just out of curiosity, where you exploring with Postman? Were you planning on using one of the SDKs and if so, which one?


Why do you have a .yml file outside of the workflow directory?

That is merged by @tirthbha where there are certain things to be added in the workflow. Not the whole workflow.

Sounds like this is answered, so I'm closing this issue


Can not switch to another configuration after the first initialization (via mParticle)

Hi,
We are using Apptentive iOS via the mParticle kit.
The SDK is initialized a first time with development API keys (ie project A on Apptentive)
We can receive the events and the rating dialog is working.
The problem is if we decide to switch to the production API keys (ie Project B on Apptentive), the SDK is "blocked" with the first API keys. Events are sent to development even if we initialize with the production keys.
Using mParticle we have different projects and configurations per territories for our app. mParticle returns us the correct API keys.
How can we re-initialize the SDK with correct API keys?
We tried to delete the apptentive data directory (iOS simulator files) (LIbrary/Application Support/com.apptentive.feedback) when the app is closed, and it is working.
On the next launch, the app will initialize with the other (correct) API keys.
But we cannot use this (hack) solution on real devices.
Do you have any ideas?

Hi @nic0mic !
Thanks for the thorough details. Happy to help.
Our SDK uses a standard 8 hour caching period, which it sounds like you're running into. When testing on real devices, the best thing to do is to fully uninstall then reinstall the app. This takes a bit of leg work, but it is the best way to ensure a clean testing environment as it forces a fresh manifest (which we use for targeting rules) to be fetched, as well as resetting counts to zero (for example, the Love Dialog is designed to be shown to a single user once per version of the app).
We do have some ways that could expedite testing, but I'd recommend starting with uninstalling + reinstalling in an actual app first -- that way we ensure that everything is working.
Then, if you're testing specific features, let me know specifically what you're trying and I may be able to help with some shortcuts (we have options, but they depend on some other factors like how your app versioning works, or if you are testing a debug build).
Let me know if that works.
Also, can you email us at<EMAIL_ADDRESS>with details on which app you're working on? I'd love to loop in your Customer Success Manager so they can make sure everything is running smoothly for you as well.

@nic0mic taking a look at this with my engineers now. We'll be in touch with next steps as soon as possible.
Thanks!

Hi @nic0mic,
Right now our SDK doesn't support changing the app key/signature after the first call to "register". The app key and signature are only used to create the session for the app (referred to as a "conversation" in the code), and after that the particular app install is pinned to that key/signature.
I'm not sure if it would be a good fit for your workflow, but usually we would recommend creating multiple "apps" on mParticle, and changing the mParticle credentials on a per-territory (and/or per-environment) basis, but not changing the Apptentive credentials once they've been set for that territory and/or environment.
Like you said, the only way to have the app key/signature change take effect is to delete the Apptentive data container.

@nic0mic could you email us at<EMAIL_ADDRESS>with the name of the app you're working on? Then I can loop in your Customer Success Manager and they can assist in setting up a test app dashboard.

Thank you for the quick answer!
@frankus I was afraid of this, we currently have different mParticle workspace like you said.
We will find a solution to be able to test/changing the configuration, it is more a process to follow/be careful about now we know it will be always initialized with the first configuration set.
thank you!


Added source map support

As soon as tapjs/stack-utils#22 is landed and the stack-utils version is bumped this will resolve #329

Hey, this will probably have to be rebased (or completely rewritten) to work on v10.
I've pinged @jamestalmage to see about getting that stuff landed in stack-utils.  This patch looks pretty straightforward, so I'll probably be able to forward port it myself, but I'll let you know if that hits any snags.
Thanks!

@isaacs - Fixed it up for you 👍

Thanks!  Squashed the commits and landed on master.  Care to review 3d89b54bef7cd00bd73df6f2c8c08d19eef55c80 and make sure that it looks right?  Seems very straightforward.


[Python][Packaging] Remove numpy required dependency from pyarrow packaging

Describe the enhancement requested
Once the following is merged:

https://github.com/apache/arrow/issues/25118

As discussed here, we can follow up removing numpy from the required dependencies list so when pyarrow is installed it doesn't pull numpy.
Component(s)
Packaging, Python

Issue resolved by pull request 44148
https://github.com/apache/arrow/pull/44148


vue 1.0 template doesn't support async/await

运行npm run dev 启动开发服务器的时候可以正常启动
但是npm run build项目构建的时候报错,不支持async

Please open the issue in the corresponding repository. Since the vue 2 template does support it, a PR would be better 😄


Tests sometimes not failed even if Expect expression was not passed

Expected Behavior
Tests should fail if Expect expression was not passed
Current Behavior
Tests are continued even if Expect expression was not passed
Failure Information (for bugs)
Using of depricated testing functions can be the cause of this issue
// Testing.T tests.  It is now deprecated and you should use NewWithT() instead.
Failure Logs
https://81881-127937836-gh.circle-artifacts.com/0/home/circleci/project/.tests/cloud_test/azure-1/036-TestVPNNSCRemote-run.log
Test wasn't failed after
time="2019-07-24T19:00:55Z" level=error msg="Timeout waiting for logs pattern NSE: channel has been successfully advertised, waiting for connection from NSM... in vppagent-firewall-nse-1
with
Expect(false).To(BeTrue())

@artem-belov Is this fixed?

@edwarnicke I am not sure. I am keeping tracking circle ci tests for such issues. This issue is not regularly reproducible


Hidden portrait does not reappear in conversation

Describe the bug
Made a bug report on Fungus forums on 5th Dec 2017, but hasn't been resolved.
After hiding a portrait in conversation, showing it doesn't appear again if it has the same position and portrait.
To Reproduce

Go to the scene 'FungusExamples/Conversation/Conversation.unity'
Use the following conversation text:

john bored left: hello!
john hide:
sherlock eyeroll right: hello!
john bored left: hello!

John does not reappear in the final line.
Additional context
The following also causes the same issue:
john bored left: hello!
john hide:
sherlock eyeroll right: hello!
john:
bored left: hello!

but the following works as intended:
john bored left: hello!
john hide:
sherlock eyeroll right: hello!
john bored:
left: hello!

john bored left: hello!
john hide:
sherlock eyeroll right: hello!
john left:
bored: hello!

It's due to the following if condition which doesn't trigger because hiding isn't recognised as a change which triggers a redraw:
https://github.com/snozbot/fungus/blob/403ceddd7ade13a7a3093dd48347042d54348eb5/Assets/Fungus/Scripts/Utils/ConversationManager.cs#L425
Versions & Platform

Unity version: 2019.3.7f1
Fungus Version: v.3.12.0
Editor OS: Arch Linux
Build Platform: Linux

Thanks for the detailed case and contribution.


PlatformLocation injection fails in Angular4 child application

I have been trying to set up a single-spa main application and two angular4 children, one with routing and one without. The bootstrap for the child application is here: https://github.com/yavuztor/single-spa-trial/blob/master/childapp2/app/bootstrap.ts.
 I don't quite understand what I am missing.

I think this might be related to my problem as well, I tried using angular version 5.0.3 and got
Uncaught Error: 'app2' died in status LOADING_SOURCE_CODE: StaticInjectorError[{provide:PlatformLocation, useClass:BrowserPlatformLocation}]: 'deps' required

I already know this is related to this section from angular changelog:
platformXXXX() no longer accepts providers which depend on reflection. Specifically the method signature went from Provider[] to StaticProvider[].

It turns out my issue had nothing to do with single-spa-angular2. I had the wrong versions of @angular/platform-browser, @angular/platform-browser-dynamic, and @angular/core (see my package.json file here). There was a mixture of 5.0.2 and 5.0.3 versions. After I upgraded all to 5.0.3, routing started to work as normal.
If you still have similar problems after making sure the versions match, like I did, this issue created in angular repo might be helpful.
I am closing this issue since it is not caused by single-spa-angular2.

Glad to hear you got it figured out -- tbh I saw this yesterday and was going to dig into it until I saw the stacktrace and then realized it might take a lot of time and was hoping to get back to it today haha.
@xeii did you get your problem solved?

No I didnt. I had problems with angular version 4 and tried running 5. I described my setup in another issue here: https://github.com/CanopyTax/single-spa-angular2/issues/2#issuecomment-347864894
What I am ultimately trying to achieve is what you described here: https://github.com/CanopyTax/single-spa/issues/126#issue-270846851


Module ui.router is not available

I have tried my app on Codio and Digital Ocean and when I run npm start most of the site loads but I get this error, everything works locally.
Uncaught Error: [$injector:modulerr] Failed to instantiate module application due to:
Error: [$injector:modulerr] Failed to instantiate module ui.router due to:
Error: [$injector:nomod] Module 'ui.router' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
http://errors.angularjs.org/1.3.14/$injector/nomod?p0=ui.router
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:655
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:14151
at ensure (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:13406)
at seen (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:13919)
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:29149
at forEach (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:1299)
at loadModules (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:28675)
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:29052
at forEach (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:1299)
at loadModules (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:28675)
http://errors.angularjs.org/1.3.14/$injector/modulerr?p0=ui.router&p1=Error…%2Fnancy-santana.codio.io%3A8080%2Fassets%2Fjs%2Ffoundation.js%3A5%3A28675)
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:655
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:29494
at forEach (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:1299)
at loadModules (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:28675)
at http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:29052
at forEach (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:1299)
at loadModules (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:28675)
at createInjector (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:31932)
at doBootstrap (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:10255)
at bootstrap (http://nancy-santana.codio.io:8080/assets/js/foundation.js:5:10784)
http://errors.angularjs.org/1.3.14/$injector/modulerr?p0=application&p1=Err…%2Fnancy-santana.codio.io%3A8080%2Fassets%2Fjs%2Ffoundation.js%3A5%3A10784)

Could you re-open this on the Foundation for Apps issue tracker and describe your setup and deploy process in more detail? Thanks :)


Initial Database Migration

Why is this marked as done?

Why is this marked as done?

Domain model migrations are done


pm_list: Bot availability status in pm

Changes the bot availability circle to bot icon on
left side bar, pm listing.
Fixes #13149

Testing Plan:
Manual testing
GIFs or Screenshots:

On the discussion of this issue, it was said that if the recipient of the message is a bot, it shouldn't have an availability circle at all. But for me personally, it was kinda odd seeing no icon at all besides the name of the bot, and also I think it would be less confusing if it had some indication that that user is a bot. So, I put a bot icon, but I'm not sure if it is nice or ok. What do you think @timabbott and @rishig ?

Great idea. Another option could be to use the "availability hidden" icon.
If we use the bot icon: we should see how it looks at a smaller size. We'll want it to have visual weight comparable to the availability circles.

Yeah, agreed we should try a smaller version of the bot icon for visual weight reasons.

Ok, I put the bot icon with the same dimensions as the user_circle and I also choose a lighter color (same as the border of an empty circle) so it doesn't seem some main topic as "All messages", rather a subtopic of "Private messages". That's the result:

I couldn't find the "availability hidden" icon though. Also, how should I proceed about the failing test in circleci? It is failing because I added an is_bot attribute in display_message and the expected result doesn't have this attribute.

I think the width of the bot will need to be the same width as the circle (visually). Right now it still looks a little bigger?

That's better?

Agreed, and I we also want to to make sure it's both horizontally and vertically aligned similar to how the circles are once we've sized it correctly.

Actually what do you think of just using a green circle?

I think it will better to just have a green circle too because the bot icons may pollute too much. Should I use the green circle?

yeah, let's try that (unless Tim has other thoughts)

green circle lgtm!

Looks great!  Can you add a unit test to fix the frontend test coverage issue?
https://zulip.readthedocs.io/en/latest/testing/testing-with-node.html has details on the test system.

Sure, I'm adding just now

@timabbott and @rishig finished the test and issue. It is ready for review now :)

This looks great!  I squashed your commits into a single commit to follow our commit guidelines, added a bit more explanation in the commit message and merged this.
Check out the Zulip commit guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html
Thanks for fixing this @clarammdantas!


Adding TokenListController to fetch the token list from token services API

The purpose of the controller is to poll the new token detection API tokens/:chainId at regular intervals to get the list of tokens dynamically instead of getting it from @metamask/contract-metadata.  The controller also calls on the /sync/:chainId API which initiates sync on the token list in the background and  tokens/:chainId?address=<tokenAddress> which returns the metadata of the token whose address is provided.
This controller will be used by detect-token.js(DetectTokensController) from metamask-extension repo and AssetsDetectionController.ts from metamask/controllers repo. AssetsDetectionController.ts is updated as a part of this PR to use the TokeListcontroller as a source of the token list instead of @metamask/contract-metadata.

@NiranjanaBinoy do you still need more input / feedback from Mobile? Thank you!

Should there be a method present on the controller to update the chainId on the this.networkController.on(NETWORK_EVENTS.NETWORK_DID_CHANGE event?

@adonesky1 I thiknk that is setup differently in controllers repo: see these lines
https://github.com/MetaMask/controllers/pull/478/files#diff-c2ec75b01a3b2e2e1284df7c48ad4c80a26ea7f1455167cc8390d91ca865b854R121-R123

@adonesky1 I thiknk that is setup differently in controllers repo: see these lines

Oh weird I had pulled down and was looking at an older version of this PR that didn't contain those lines... LGTM


chore(fmg): fmg documentation

#3623

Reviewers
Functional:
Readability:

Changes

add
remove
modify

QA steps (optional)
Notes for Reviewer

@atarashansky would you mind adding the additional caveat that we do not calculate markers for cell types with <25 cells or blood?
Otherwise looks good to me. Tagging @ambrosejcarr for review as well.

@atarashansky would you mind adding the additional caveat that we do not calculate markers for cell types with <25 cells or blood?
Otherwise looks good to me. Tagging @ambrosejcarr for review as well.

It's already in there, the last bullet point!


How to make word-level prediction

I want to make word-level prediction, and set it in the --train_level=word
The following cuowu was encountered
ValueError: all the input array dimensions for the concatenation axis must match exactly, but along dimension 1, the array at index 0 has size 0 and the array at index 1 has size 1000
How to solve it, please. Thank you very much

How did you prepare the dataset?

How did you prepare the dataset?

The data set is not processed, but only labeled with source. 1 means ok, and 0 means bad. Is there anything to pay attention to or deal with, please

How did you prepare the dataset?

The data set is not processed, but only labeled with source. 1 means ok, and 0 means bad. Is there anything to pay attention to or deal with, please

Can you post the whole error msg?

How did you prepare the dataset?

The data set is not processed, but only labeled with source. 1 means ok, and 0 means bad. Is there anything to pay attention to or deal with, please

Can you post the whole error msg?

# External evaluation, global step 0   done, num sentences 1000, time 22s qe_model.py:1424: UserWarning: loadtxt: Empty input file: "./saved_qe_model_enzh_word/output_dev.sent"   pre = np.loadtxt(pre_file) Traceback (most recent call last):   File "qe_model.py", line 2190, in <module>     tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)   File "/home/lyn19/miniconda3/envs/tf1.12/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 125, in run     _sys.exit(main(argv))   File "qe_model.py", line 2183, in main     run_main(FLAGS, default_hparams, train, inference)   File "qe_model.py", line 2178, in run_main     train_fn(hparams, target_session=target_session)   File "qe_model.py", line 1738, in train     run_external_eval(infer_model, infer_sess, model_dir, hparams, summary_writer)   File "qe_model.py", line 1589, in run_external_eval     avg_ckpts=avg_ckpts)   File "qe_model.py", line 1534, in _external_eval     metrics=hparams.metrics)   File "qe_model.py", line 1510, in decode_and_evaluate     score = evaluate(ref_file, pred_file, metric)   File "qe_model.py", line 1411, in evaluate     evaluation_score = _pearson(ref_file + sent_suffix, pred_file + ".sent")   File "qe_model.py", line 1426, in _pearson     return np.corrcoef(pre, grt)[0, 1]   File "<__array_function__ internals>", line 6, in corrcoef   File "/home/lyn19/miniconda3/envs/tf1.12/lib/python3.6/site-packages/numpy/lib/function_base.py", line 2551, in corrcoef     c = cov(x, y, rowvar)   File "<__array_function__ internals>", line 6, in cov   File "/home/lyn19/miniconda3/envs/tf1.12/lib/python3.6/site-packages/numpy/lib/function_base.py", line 2415, in cov     X = np.concatenate((X, y), axis=0)   File "<__array_function__ internals>", line 6, in concatenate ValueError: all the input array dimensions for the concatenation axis must match exactly, but along dimension 1, the array at index 0 has size 0 and the array at index 1 has size 1000

How did you prepare the dataset?

The data set is not processed, but only labeled with source. 1 means ok, and 0 means bad.

The data set is not processed, but only labeled with source. 1 means ok, and 0 means bad. Is there anything to pay attention to or deal with, please

Can you post the whole error msg?

I see. Thank you. I didn't specify  --metrics


[Feature] common labels for releases

Hi @mumoshu, I've figured a proper structure to apply changes across all clusters and would like to suggest one feature.
I defined helmcharts as follows:
templates:
  autoscaler: &autoscaler
    name: cluster-autoscaler
    namespace: kube-system
    chart: stable/cluster-autoscaler
    version: "7.2.0"
    needs:
    - kube-system/kube2iam
    values: # paths are relative to the helmfile that defines releases
    - ../helm-values/common/{{ .Release.Name }}.yaml
    - ../helm-values/{{ .Release.Labels.customer }}/{{ .Release.Name }}.yaml

And then in helmafile.yaml:
{{ readFile "templates/common.yaml" }}

helmDefaults:
  kubeContext: example

releases:
- <<: *blackbox
- <<: *autoscaler
  labels:
    customer: example
- <<: *kube2iam
  labels:
    customer: example

labels are used in templating to search for proper file name for values. When number or releases per customer grows, I would have to add this block many times:
labels:
    customer: example

Would you be open to defining common labels for releases, I guess something like this, so they would be automatically added to all releases? There is a similar feature in kustomize
helmDefaults:
  commonLabels:
    label1: value
    label2: value

@mlushpenko Sounds greeat! As it isn't strictly a helm arg, I believe it worth a top-level key so that the usage looks like:
commonLabels:
  label1: value
  label2: value

releases:
- ...

WDYT?

Yes, @mumoshu, awesome, it's indeed not a helm argument, so this looks great.

@mlushpenko did you tried to create nested template with customer-specific common values ?
templates:
  _autoscaler: &_autoscaler
    name: cluster-autoscaler
    namespace: kube-system
    chart: stable/cluster-autoscaler
    version: "7.2.0"
    needs:
    - kube-system/kube2iam
    values: # paths are relative to the helmfile that defines releases
    - ../helm-values/common/{{ .Release.Name }}.yaml
    - ../helm-values/{{ .Release.Labels.customer }}/{{ .Release.Name }}.yaml

  autoscaler: &autoscaler
    values: # paths are relative to the helmfile that defines releases
    - ../helm-values/common/{{ .Release.Name }}.yaml
    - ../helm-values/commonLabel1value/{{ .Release.Name }}.yaml
    - ../helm-values/commonLabel2value/{{ .Release.Name }}.yaml

It requires single templates file however ...

@voron I am not sure I understand your example. I guess you meant to create something like this:
templates:
  _autoscaler: &_autoscaler
    name: cluster-autoscaler
    namespace: kube-system
    chart: stable/cluster-autoscaler
    version: "7.2.0"
    needs:
    - kube-system/kube2iam

  autoscalerA: &customerA_autoscaler
    <<: *_autoscaler
    values:
    - ../helm-values/common/{{ .Release.Name }}.yaml
    - ../helm-values/customerA/{{ .Release.Name }}.yaml

  autoscalerB: &customerB_autoscaler
    <<: *_autoscaler
    values:
    - ../helm-values/common/{{ .Release.Name }}.yaml
    - ../helm-values/customerB/{{ .Release.Name }}.yaml

But even if I interpreted your idea correctly, that's not what I would like because this setup would import templates for all customers if I use readFile function and wouldn't be very DRY in general.

hi, @mumoshu, is this a big feature to implement? any chance I can expect it in the near future or is it far down the list of priorities?

@mlushpenko I can't promise anything as I'm working on Helmfile for my spare time(as I don't have any sponsor) but it should be easy/done shortly if it's just about passing some map object to commonLabels in kustomization.yaml :)

Hi, @mumoshu, we rely more and more on helmfile in production, so I would like to give a try adding this feature if you don't have time. I have quite basic Golang skills, but if you could point me in the right direction, would be happy to implement it if I can.

@mlushpenko Will try give you a brief intro towards it!
Anyway - is forking each helm chart and modify helm templates to allow injecting labels to every resource via values.yaml is a viable option for you? I think that's the easiest way to achieve your requirement.

This feature is not about having labels for kubernetes resources, it's about having a clean helmfile without much duplication. .Release.Labels. is helmfile specific feature to manage selection of releases, like Kubernetes selectors but for helmfile releases, right? Remember we talked about that labels should be a sparate field, not part of helmDefaults as it's not realted to the helm itself, but to helmfile templating and selection of releases

@mlushpenko Ah sorry about that! I reread your original description and now understood. What confused me was that kustomize commonLabels is for labeling resources, where this one is indeed for releases.
Re: implementation, you should copy the release labels(r.Labels), and merge HelmState.HelmDefaults.Labels to the copy and use that for the selector match target here: https://github.com/roboll/helmfile/blob/1e260e4a5ecd57a4c84cdbc98f569a52b7735bb2/pkg/state/state.go#L1447-L1455
HelmState is available in the caller here: https://github.com/roboll/helmfile/blob/1e260e4a5ecd57a4c84cdbc98f569a52b7735bb2/pkg/state/state.go#L1429
Please don't forget adding the definition of labels to HelmSpec: https://github.com/roboll/helmfile/blob/1e260e4a5ecd57a4c84cdbc98f569a52b7735bb2/pkg/state/state.go#L55

Thanks a lot, hopefully, I'll get some time this week to give it a try.


is support max physical camera?

hi,wan know gltfruntime support max physical camera?thanks

ok,thaks


Redis zadd scores are not always integer

From redis documentation

Redis sorted sets use a double 64-bit floating point number to represent the score.

Not sure if this is a BC break since the library used to allow anything an automatically cast it.

why not

Yeah this is indeed a good idea. I've pushed a fixed version.

And #87 is somewhat linked to this as the score is always returned as string in redis.

And what about a unit test?

Is it possible to add a test for this behavior? Checking that values 1, 1.1 and "1.1" are ok, but not "this is not a number"?

I've added test

not sure about the version number we should use for this release

@omansour could be considered as bugfix IMHO (and bundled with #87). No new feature, no feature change… previous version has a very tricky/weird behavior with not numeric values, now we throw an exception to prevent this bad usage.

Many thanks 👌


Issues found when analyzed the project's dart code

10 issues found when we analyze the project's dart code using flutter analyze
Basically flutter analyze, Analyzes the project's Dart code.

Issues Found
info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:13:5 •
          deprecated_member_use
   info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:26:5 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/views/login/login_view.dart:159:31 • deprecated_member_use
   info • 'subtitle1' is deprecated and shouldn't be used. Use titleMedium instead. This feature was
          deprecated after v3.1.0-0.0.pre • lib/ui/widgets/dumb_widgets/document_type_card.dart:20:49 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/password_change_dialog_widget.dart:49:27
          • deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/torrent_label_dialog.dart:77:11 •
          deprecated_member_use
  error • The method 'FlatButton' isn't defined for the type '_FloatingBoxBottomSheet' •
         lib/ui/widgets/smart_widgets/bottom_sheets/bottom_sheet_setup.dart:88:19 • undefined_method
  error • The method 'FlatButton' isn't defined for the type 'ConfirmBottomSheetView' •
         lib/ui/widgets/smart_widgets/bottom_sheets/confirm_bottom_sheet/confirm_bottom_sheet_view.dart:
         53:15 • undefined_method
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:77:19 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:110:25 •
          deprecated_member_use

10 issues found. (ran in 2.2s)

Remove references to the deprecated member `toggleableActiveColor` and use the recommended replacement as per the migration guide.
Replace references to the deprecated member primary with `backgroundColor`.
Replace references to the deprecated member subtitle1 with `titleMedium`.
Import the `FlatButto ` method in the relevant files.

Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.
Replace references to the deprecated member primary with backgroundColor.
Replace references to the deprecated member subtitle1 with titleMedium.
Import the FlatButto  method in the relevant files.

Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

Replace references to the deprecated member primary with backgroundColor.

Replace references to the deprecated member subtitle1 with titleMedium.

Import the FlatButton method in the relevant files.

Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

Replace references to the deprecated member primary with backgroundColor.

Replace references to the deprecated member subtitle1 with titleMedium.

Import the FlatButton method in the relevant files.

I had resolved those issues and also made a pr to the develop branch, btw thanks for your suggestions

I have already solved this issue in PR #188

@virajbhartiya  A pr is already made resolving this issue, and if you had gone through the conversations in this issue you could have seen the open pr's which have been referenced to this issue.

About time the issue is closed

What Flutter SDK version did you guys use to build & run the project?

Replace primary with background


Screen is too small

Hey so I've been experimenting with this module. It's honestly great but the screen sharing window is too small. Is their an option to maybe resize it? Make it bigger? Thanks in advance!

Oh awesome. Thanks for answering I'm a big fan of your channel. Also one more thing. I'm building a program that can stream both live webcam footage and live screen sharing. I'm using sockets and in order to get the webcam to work (by using CV2) I need to bind the server with the client. But if I start using vidstream I get an error because I the port is already connected (from sockets and CV2).  So basically I was just wondering if I could bind vidstream with sockets as one so they work as one server. Many thanks in advance!

Oh awesome. Thanks for answering I'm a big fan of your channel. Also one more thing. I'm building a program that can stream both live webcam footage and live screen sharing. I'm using sockets and in order to get the webcam to work (by using CV2) I need to bind the server with the client. But if I start using vidstream I get an error because I the port is already connected (from sockets and CV2).  So basically I was just wondering if I could bind vidstream with sockets as one so they work as one server. Many thanks in advance!

vidstream handles all the camera interaction itself. You can write a script with a client and a server in it or even with two clients. But you cannot access the same camera twice.


Add End User ID

Just wanted to know does this support End user ID?
https://platform.openai.com/docs/guides/safety-best-practices/end-user-ids

It does not @aryan1107 but I am going to get this added 👍🏼


handle redirect

for handle redirect, I modify
q-io\http.js
replace
var HTTPS = require("https"); // node
to
var HTTP = require("follow-redirects").http; // node
npm install follow-redirects

q-http is out of service. It has been consolidated into q-io/http. I recommend filing: Q-IO should expose an HTTP module constructor that accepts the Node.js HTTP module or HTTPS module, or a facsimile thereof, as an argument.


repair hyperlinks

@opoudjis build failed here...

@ronaldtse This doesn't happen on my local build, and I have no idea how to debug it. Who do I escalate this to? @strogonoff ?


Mongolab upgradation to 3.2 & its syntax compatability

After Mongolab upgraded their version to 3.2, the general syntax for find collection is no more working with the library 'mongojs'. When contacted mongolab support, they say 'mongojs' library was not updated in accordance with their upgradation. Its terrible to see that entire system came standstill because of this upgradation issue and has to be sorted out as quickly as possible

Hey @senthamilan, so sorry for this problem.
Can you put a specific example of what is failing for you? I'm trying a couple of finds in a mongolab 3.2 server and it seems to work. I think this might be solved by updating the driver, but I  want to have a clear example of what's going wrong.

Dear Sorribas,
Kindly refer below code which is working before mongolab 3.2 upgradation
"tbl_testcollection" is collection name and while querying object "docs_config" is null and error message in object "err_config"  is something like ""failed to parse: { find:}, projection: {}, slaveok: false }. unrecognized field 'slaveok' "
i didn't updated the driver, will test and let u know once i updated .
/******************************************************/
var mongojs = require('mongojs')
var SSCollections = mongojs('mongodb://username:password@ds012345.mlab.com:12345/db_test', [], { authMechanism : 'ScramSHA1' });
SSCollections.collection("tbl_testcollection").find({ "config_id": "1" },
{}, {}).toArray(function (err_config, docs_config) {
if(docs_config != null && docs_config.length > 0)
var array = docs_config.map(function (item) {
    return item.config;
});

});

Which version of mongojs are you using? Similar queries are working for me with the latest mongojs release (2.4.0).

Dear sorribas,
Its working after updating the driver. It will be useful to send notification for updating the driver whenever third party apps was upgraded and the mongojs driver was updated accordingly.
Thanks

Hey @senthamilan. Glad to hear it works now!
You can subscribe to the RSS feed of mongojs releases
https://github.com/mafintosh/mongojs/releases.atom
Or you can use some kind of RSS to email tool if you want to get notified when new versions of mongojs come out. I'm closing this issue now.


Dynamically create checkboxes and add change handlers for the same : Semantic-ui-react + React

I am trying to create dynamic checkboxes using semantic-ui-react I have object of the following structure. I want the checkbox value should get applied to the particular object in this array. I am unable to do it with the change handler provided below. Can someone help me with this?
Seems like change handler is not working
Sandbox: https://codesandbox.io/s/suspicious-pine-r5dpi

Please use StackOverflow for usage questions: https://stackoverflow.com/questions/tagged/semantic-ui-react
However, as I see, you should take checked from the second param, see controlled example: https://react.semantic-ui.com/modules/checkbox/#usage-remote-control


Replace layout engine with forto

I am working on a layout engine that is tested and decoupled from the DOM called forto This is a big improvement from the engine embedded in react popover and should help greatly simplify the code.

Duplicate of #95


Remove version: Jackett.Jackett version 0.21.718

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.718/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


Nuklear examples do not work

Environment

LWJGL version: 3.2.0
LWJGL build #: X
Java version: 1.8
Platform: Windows
Module: modules/samples/src/test/java/org/lwjgl/demo/nuklear

Description

I have implemented the code from https://github.com/LWJGL/lwjgl3/tree/master/modules/samples/src/test/java/org/lwjgl/demo/nuklear exactly as is, but it is making use of classes and functions that don't exist.
In GLFWDemo.class it is making use of NkColorf, which does not exist in LWJGL 3.2.0 and it is using the function nmemAllocChecked(size) which also does not exist.

Hi, could please add some more information on how you are running the demo and during which step (compile/runtime) it fails?
Since you cannot find NkColorf (which does actually exist) I assume you are building LWJGL from sources. Did you follow the steps in this document to become familiar with how LWJGL is build?

I am sorry, I have the version wrong, the version is actually is 3.1.2 in which the examples won't work.
I did not run it before because the NetBeans couldn't find NkColorf or nmemAllocChecked. I have updated to 3.2.0 to see if that solved the issue and it does fix the compiler errors.
Is there any documentation describing the use of Nuklear for older versions of LWJGL?

You can go back in git history to find an older version of this demo. This revision should work for you: https://github.com/LWJGL/lwjgl3/blob/3.1.2/modules/core/src/test/java/org/lwjgl/demo/nuklear/GLFWDemo.java


Dynamic pricing charging

Hi there, and thanks for creating this awesome blueprint.
Lately I've switched to a dynamic contract, and would love to add the possibility to charge the car when the price is at a certain point.
I'm thinking about adding it to your blueprint, and setting a PR. But I'm not sure if this messes to much with your original intent of this blueprint.
Let me know if your open to this change, or if I can better fork this into my own blueprint.

Thinking about this a bit longer, and it might be easier to create a new automation that:
Trigger: When hourly price changes
Choose 1:
Condition: When price is below or equal to set maximum
Action: Set charge amps to max
Action: toggles the "charge from grid" switch on.
Action: Trigger your script.
Choose 2:
Condition: When price is above to set maximum
Action: toggles the "charge from grid" switch off.

You need price triggers.  Better to be a separate script.  Closing case.


⚠ gorzdrav.org has degraded performance

In 0199898, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 2216 ms

Resolved: gorzdrav.org performance has improved in 5a86e2e.