crash on doc commands

Running
datalad -l 1  catalog-workflow --type new --catalog ./ --dataset /path/to/dataset/  --extractor metalad_core
I get the following traceback:
....
....
....
[Level 5] Finished setup_parser
[DEBUG  ] Parsing known args among ['/home/basile/.local/bin/datalad', '-l', '1', 'catalog-workflow', '--type', 'new', '--catalog', './', '--dataset', '/home/basile/data/tests/cneuromod/', '--extractor', 'metalad_core']
[Level 2] Entered eval_func for <function Workflow.__call__ at 0x70b50ea5f0a0>
[DEBUG  ] Determined class of decorated function: <class 'datalad_catalog.workflow.Workflow'>
[Level 2] Returning generator_func from eval_func for <class 'datalad_catalog.workflow.Workflow'>
[DEBUG  ] Command parameter validation for <class 'datalad_catalog.workflow.Workflow'>
[Level 8] 1 command parameter constraint violation
mode=<no value>
  missing required arguments [main.py:_run_with_exception_handler:190,exec.py:call_from_parser:107,interface_utils.py:_execute_command_:154,parameter.py:__call__:289]
[ERROR  ] 1 command parameter constraint violation
mode=<no value>
  missing required arguments
[Level 5] Exiting

Cannot figure out how --type does not get into the mode variable.
dlad_wtf.txt

Hey @bpinsard. I have no ideas off the top of my head, but I will try and reproduce this locally.

Interim note: I have been able to reproduce the issue locally. I'm running on a mac, python==3.10.12, datalad-next==1.3.0, datalad_catalog==1.1.1. This issue isn't picked up by existing tests, they all run successfully.

@bpinsard It seems like I've found a solution. For some reason that I haven't been able to figure out yet, the mismatch between the python variable mode and the Argparse argument type is causing trouble (see code):
mode=Parameter(
            # cmdline argument definitions, incl aliases
            args=("-m", "--mode"),
            # documentation
            doc="""Which type of workflow to run: one of ['new', 'update']""",
        ),

If I change the argument name to mode, the issue disappears. I am yet to figure out if this is related to some argparse changes or perhaps datalad-next updates...
When I ran the catalog-workflow command after the fix, I encountered a different new issue related to the Dataset class, which I also fixed. After that, the command ran fully (although the output wasn't great because I couldn't clone/install any of the subdatasets in https://github.com/courtois-neuromod/cneuromod).
Both fixes are included in this patch, also displayed below:
diff --git a/datalad_catalog/workflow.py b/datalad_catalog/workflow.py
index e10011a..4828fdc 100644
--- a/datalad_catalog/workflow.py
+++ b/datalad_catalog/workflow.py
@@ -117,7 +117,7 @@ class Workflow(ValidatedInterface):
         ),
         mode=Parameter(
             # cmdline argument definitions, incl aliases
-            args=("-t", "--type"),
+            args=("-m", "--mode"),
             # documentation
             doc="""Which type of workflow to run: one of ['new', 'update']""",
         ),
@@ -244,7 +244,7 @@ class Workflow(ValidatedInterface):
         )
         if mode == "new":
             yield from super_workflow(
-                ds=dataset,
+                ds=dataset.ds,
                 cat=catalog,
                 extractors=extractor,
                 config_file=config_file,
@@ -253,8 +253,8 @@ class Workflow(ValidatedInterface):
             )
         if mode == "update":
             yield from update_workflow(
-                superds=dataset,
-                subds=subdataset,
+                superds=dataset.ds,
+                subds=subdataset.ds,
                 catalog=catalog,
                 extractors=extractor,
                 **res_kwargs,

If you can download and apply that locally with git apply workflow_patch.patch and let me know if this fixes things for you, that would be great.

thanks! I will try that asap and let you know.

It passes the error I had before. However I get 404 on the generated webpage, not sure what I am doing wrong.
If I then add the different datasets to the catalog it shows in the web interface.

It passes the error I had before

Good to hear! I will proceed with a PR to bring this change into main.

However I get 404 on the generated webpage, not sure what I am doing wrong.

With the "generated webpage" do you mean a locally served webpage using datalad catalog-serve on the location of the generated catalog?

If I then add the different datasets to the catalog it shows in the web interface.

So do you get a 404 when navigating to the root of the served location (e.g. http://localhost:8000) but the datasets render successfully when navigating to the specific ID and version (http://localhost:8000/dataset/dsID/dsVERSION)? If that is the case, it seems to me that the homepage of the catalog might not have been set correctly (or at all). Do you encounter all of this after running the exact command you posted in your first comment in this issue, or did you run any other commands?

@bpinsard did you manage to get this resolved or is the issue still a problem?


Added tfsec workflow

@mcleo-d - Do you have any idea why my CLA isn't working anymore? I tried re-signing yesterday, but that didn't change anything.


Padding around a widget

Is there a way to set padding around a widget like ui::Image or ui::Text? I see that examples/image.rs, Text::height is used to set the height in pixels (and, since this was in a column, this results in some padding if the height is larger than the computed height of the text). In the same example, Column::spacing is used to set a constant amount of spacing between the itens of the column (but not before the first and after the last).
Both aren't what I'm looking for; there's also ui::core::Style::padding but I'm unsure how to use this with the current widgets (is it necessary to add a padding method to the widgets, like they have a height method? Shouldn't those methods be added to a trait?).
(ps: since the ui code is being moved to iced perhaps this issue belongs there, but coffee doesn't used iced yet)

It would be useful if ui::core::Style::padding could optionally add different amounts of padding to each side, like css - and have it exposed to each widget (letting the user either set the same amount for all 4 sides, or different amounts)

You can wrap your widget in a Column and use Column::padding.
A different amount of padding per side is simply not supported yet. Styling in Iced will get reworked soon.

For instance, the ui example uses it here: https://github.com/hecrj/coffee/blob/8e2da7b229afb641b9bc99c13863d764dd461f9f/examples/ui.rs#L101

Thanks!


Failed to compile torchvision for ROCm as documented in pytorch.org

🐛 Bug
Failed to compile torchvision for ROCm as documented in pytorch.org/get-started
To Reproduce
Steps to reproduce the behavior:
as in: https://pytorch.org/get-started/locally/

python -m venv ptamd; source ptamd/bin/activate
pip install torch -f https://download.pytorch.org/whl/rocm4.0.1/torch_stable.html
pip install ninja && pip install<EMAIL_ADDRESS>
same with v0.9.0
Error
ptamd/lib/python3.8/site-packages/torch/include/c10/util/complex.h:9:10: fatal error: 'thrust/complex.h' file not found
#include <thrust/complex.h>
^~~~~~~~~~~~~~~~~~
1 error generated when compiling for gfx803.
Environment
PyTorch version: 1.8.1+rocm4.0.1
Is debug build: False
ROCM used to build PyTorch: 4.0.20496-4f163c68

OS: CentOS Linux 8 (x86_64)
GCC version: (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5)   # same on GCC 10

Python version: 3.8 (64-bit runtime)
Is CUDA available: True
GPU models and configuration: Vega 20
HIP runtime version: 3.21.2
MIOpen runtime version: 2.9.0

Versions of relevant libraries:
[pip3] numpy==1.20.2
[pip3] torch==1.8.1+rocm4.0.1

actually, it seems to run fine with the regular vision wheel:
pip install torch torchvision -f https://download.pytorch.org/whl/rocm4.0.1/torch_stable.html
at least, it looks like I can train a CNN without any major issue, but I wonder why the instructions recommend the source build (?)
Thanks for the great work anyway
Cheers

actually, it seems to run fine with the regular vision wheel:
pip install torch torchvision -f https://download.pytorch.org/whl/rocm4.0.1/torch_stable.html
at least, it looks like I can train a CNN without any major issue, but I wonder why the instructions recommend the source build (?)
Thanks for the great work anyway
Cheers

Same for me, the regular vision wheel worked. Package versions and environment are a bit different though.


Don't test render on Windows

render_test.go uses PosixWriter, which is defined in output_posix.go, a file marked with +build !windows
That means any test build would always fail on Windows, as shown in https://travis-ci.org/c-bata/go-prompt/builds/652864849, more precisely https://travis-ci.org/c-bata/go-prompt/jobs/652864854
.\render_test.go:74:9: undefined: PosixWriter

One solution (this PR) is simply to exclude render_test.go from build on Windows.
Another option might be to split it in two, if some part of that test file still warrant a build on Windows (while the part involving PosixWriter clearly does not)

Good catch @VonC !


Cannon Game[New game]:

🎮 Game Request
To Keep score by counting target hits and Vary the effect of gravity. To Apply gravity to the targets and Change the speed of the ball.

Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @shraddha761 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


New Auto Attach options do not work with tsc-watch and inspect-brk flag

VSCode Version: 1.50.1
OS Version: Windows 10 Enterprise Version 1803

Steps to Reproduce:

Have a script that uses tsc-watch (version ^4.2.3) to launch a project in debug mode, e.g.

"start:debug": "tsc-watch --onSuccess \"node -r dotenv/config --inspect-brk dist/index.js\"",

Have launch.json contents:

{
  "version": "0.2.0",
  "configurations": [
    {
      "type": "node",
      "request": "attach",
      "name": "Attach to Node Server",
      "port": 9229,
      "restart": true
    }
  ]
}

Set Auto Attach option to any of available new options: Always/Smart/With Flag Only/Disabled
run the start:debug
Process waits for attach to be done manually

Does this issue occur when all extensions are disabled?: Yes
Clarifications: When Auto Attach was implemented with On/Off options - this was working, process would start, debugger would attach automatically, no explicit configuration changes were needed.
I can still debug using other ways, e.g. using Node.js (preview) or attaching and un-attaching debugger manually, but would really like to make such scripts work like they used to (just launch a script - debuger attaches, Ctrl+C will stop the process and un-attach the debugger)
Thank you! :)

Try running without [--inspect-brk] (see reason). Let me know if you still have issues at that point 🙂
Tagging with needs-more-info to auto close after 7d.

Thanks for the reference!
Unfortunately, removing the --inspect-brk does not work. Tried following script variations with all Auto Attach options:
"start:debug": "tsc-watch --onSuccess \"node -r dotenv/config dist/index.js\"",

"start:debug": "tsc-watch --onSuccess \"node -r dotenv/config --inspect dist/index.js\"",

The app starts normally, but debugger is not attached.

Ok, managed to make it work with --inspect and "Auto Attach: With Flag". The issue was that after enabling Auto Attach - it is now required to restart the terminal (or VScode). This is a one-time action and once auto attach is enabled - this will no longer be required. VScode gives you a warning, but it's easy to miss:

Anyway, I think this is now resolved. Thank you! :)


Check long form templates

Edit and share long-form templates with Rae

@rudietuesdays @dasaderi Let me know if the following HTML-version of the reviewer templates 1 and 2 work for you both. (I used https://word2cleanhtml.com/) I can post them elsewhere instead if that'd be cleaner.
Template 1

    Template 1

    Below is a list of quick questions and suggestions you can use to guide your reading and reviewing of the selected preprint to produce a quick review.

        What is the main question the study attempts to answer?

        What is (are) the hypothesis(es)?

        What techniques/analyses do the researchers adopt to test their hypothesis(es)?

        Why is this study relevant?

        Write here any general comments you might have about the research approach.

        Write here any specific comment you might have about experimental approaches and methods used in the study.

        Write here any specific comment/note about figures in the preprint (this could be related to the way data are displayed and your ability to understand the results just by looking at the figures).

        Write here any additional comment you might have (this includes minor concerns such as typos and structure of the manuscript).

Template 2

    Template 2

    Below is a detailed guide to help you critically and constructively evaluate the selected preprint.

    Overview and take-home message

    Write a short (1 paragraph) summary of what the main findings of the research were and how this work has moved the field forward. This could take the following structure:

“[First author] et al., have made significant advances in [x, y, and z] by showing that… In addition, they have bridged the gap in our knowledge about how [process i interacts with process ii]. Although this work is of [significant] interest in the field, there are some concerns that could be addressed in the next version. These are outlined below.”

    Positive feedback

    As the aim of this PREreview is to support the authors by providing constructive feedback, the PREreviewer(s) should also include positive remarks to encourage future posting of preprints. Remember, the authors are human too!

    To help guide you, here are a few questions you might ask yourself after reading the preprint:

What results did you find the most interesting and why?

What did you learn from the study that really fascinated you?

            Did you learn anything from this preprint that you would include in your future work? Examples could be a new technique, a new way of approaching an idea, a certain way of interpreting the type of data, a good way of summarizing the results, the structure of the manuscript if it is clear and logical, etc.

            What ideas for further research are based on the preprint? [Note: this encourages preprint authors for their early sharing and promotes openness among reviewers as well.]

    Concerns

    Next are your concerns. Remember you are writing to another human being, so be respectful and realistic. Also, if you are unsure about something, be honest and say you are unsure. Don’t feel afraid to admit if you are not confident about your concerns, or part of the work is out of your area of expertise.

    Major concerns

    Here the reviewer(s) should list 2-3 major concerns about the research (if they exist). This may relate to:

Does the title accurately reflect the results?

            Experimental design: were the techniques appropriate for the hypothesis? Were suitable controls included? Were new techniques/mutants/cell lines etc. sufficiently characterized to allow the study to be replicated? Were robust statistical methods used?

            Do the results support the authors’ conclusions and, if not, what additional experiments would you suggest?

            Are there big flaws in the understanding of the current literature and interpretation of the literature that might undermine the interpretation of the current results?

    Minor concerns

    Here the PREreviewer(s) can mention 3-5 minor concerns that are not critical to the understanding and conclusions of the research but would improve the overall flow or clarity of the manuscript. These concerns might include the following questions:

            In general, was the manuscript easy to follow/did it have a logical
            flow? Were there a lot of typos that needed addressing?

            Does the abstract provide a concise summary of the hypotheses and
            main results?

            Were the methods sufficiently detailed to allow the experiments to
            be repeated?

            Were the figures clear and logically arranged? Were the figure
            legends sufficiently detailed to allow the figures to be understood
            without reading the main text?

            Are the figures representative of the data described in the results
            section?

            Did the authors make all their associated data openly available
            (e.g. sequencing data, coding)?

            Did the discussion address how their results move the field
            forwards?

Were the citations thorough or were key references missing?

You can find additional peer review tips in the PLOS Peer Reviewer Center, including their How To Peer Review page that contains 10 Tips for getting started as a reviewer. These resources include checklists, videos, and further information about ethical considerations, etc. They also provide suggested language you can use to address common issues that can arise when reviewing a manuscript.

@rudietuesdays @dasaderi Let me know if the following HTML-version of the reviewer templates 1 and 2 work for you both. (I used https://word2cleanhtml.com/) I can post them elsewhere instead if that'd be cleaner.
Template 1

    Template 1

    Below is a list of quick questions and suggestions you can use to guide your reading and reviewing of the selected preprint to produce a quick review.

        What is the main question the study attempts to answer?

        What is (are) the hypothesis(es)?

        What techniques/analyses do the researchers adopt to test their hypothesis(es)?

        Why is this study relevant?

        Write here any general comments you might have about the research approach.

        Write here any specific comment you might have about experimental approaches and methods used in the study.

        Write here any specific comment/note about figures in the preprint (this could be related to the way data are displayed and your ability to understand the results just by looking at the figures).

        Write here any additional comment you might have (this includes minor concerns such as typos and structure of the manuscript).

Template 2

    Template 2

    Below is a detailed guide to help you critically and constructively evaluate the selected preprint.

    Overview and take-home message

    Write a short (1 paragraph) summary of what the main findings of the research were and how this work has moved the field forward. This could take the following structure:

“[First author] et al., have made significant advances in [x, y, and z] by showing that… In addition, they have bridged the gap in our knowledge about how [process i interacts with process ii]. Although this work is of [significant] interest in the field, there are some concerns that could be addressed in the next version. These are outlined below.”

    Positive feedback

    As the aim of this PREreview is to support the authors by providing constructive feedback, the PREreviewer(s) should also include positive remarks to encourage future posting of preprints. Remember, the authors are human too!

    To help guide you, here are a few questions you might ask yourself after reading the preprint:

What results did you find the most interesting and why?

What did you learn from the study that really fascinated you?

            Did you learn anything from this preprint that you would include in your future work? Examples could be a new technique, a new way of approaching an idea, a certain way of interpreting the type of data, a good way of summarizing the results, the structure of the manuscript if it is clear and logical, etc.

            What ideas for further research are based on the preprint? [Note: this encourages preprint authors for their early sharing and promotes openness among reviewers as well.]

    Concerns

    Next are your concerns. Remember you are writing to another human being, so be respectful and realistic. Also, if you are unsure about something, be honest and say you are unsure. Don’t feel afraid to admit if you are not confident about your concerns, or part of the work is out of your area of expertise.

    Major concerns

    Here the reviewer(s) should list 2-3 major concerns about the research (if they exist). This may relate to:

Does the title accurately reflect the results?

            Experimental design: were the techniques appropriate for the hypothesis? Were suitable controls included? Were new techniques/mutants/cell lines etc. sufficiently characterized to allow the study to be replicated? Were robust statistical methods used?

            Do the results support the authors’ conclusions and, if not, what additional experiments would you suggest?

            Are there big flaws in the understanding of the current literature and interpretation of the literature that might undermine the interpretation of the current results?

    Minor concerns

    Here the PREreviewer(s) can mention 3-5 minor concerns that are not critical to the understanding and conclusions of the research but would improve the overall flow or clarity of the manuscript. These concerns might include the following questions:

            In general, was the manuscript easy to follow/did it have a logical
            flow? Were there a lot of typos that needed addressing?

            Does the abstract provide a concise summary of the hypotheses and
            main results?

            Were the methods sufficiently detailed to allow the experiments to
            be repeated?

            Were the figures clear and logically arranged? Were the figure
            legends sufficiently detailed to allow the figures to be understood
            without reading the main text?

            Are the figures representative of the data described in the results
            section?

            Did the authors make all their associated data openly available
            (e.g. sequencing data, coding)?

            Did the discussion address how their results move the field
            forwards?

Were the citations thorough or were key references missing?

You can find additional peer review tips in the PLOS Peer Reviewer Center, including their How To Peer Review page that contains 10 Tips for getting started as a reviewer. These resources include checklists, videos, and further information about ethical considerations, etc. They also provide suggested language you can use to address common issues that can arise when reviewing a manuscript.

    Template 1

    Below is a list of quick questions and suggestions you can use to guide your reading and reviewing of the selected preprint to produce a quick review.

        What is the main question the study attempts to answer?

        What is (are) the hypothesis(es)?

        What techniques/analyses do the researchers adopt to test their hypothesis(es)?

        Why is this study relevant?

        Write here any general comments you might have about the research approach.

        Write here any specific comment you might have about experimental approaches and methods used in the study.

        Write here any specific comment/note about figures in the preprint (this could be related to the way data are displayed and your ability to understand the results just by looking at the figures).

        Write here any additional comment you might have (this includes minor concerns such as typos and structure of the manuscript).

    Template 2

    Below is a detailed guide to help you critically and constructively evaluate the selected preprint.

    Overview and take-home message

    Write a short (1 paragraph) summary of what the main findings of the research were and how this work has moved the field forward. This could take the following structure:

“[First author] et al., have made significant advances in [x, y, and z] by showing that… In addition, they have bridged the gap in our knowledge about how [process i interacts with process ii]. Although this work is of [significant] interest in the field, there are some concerns that could be addressed in the next version. These are outlined below.”

    Positive feedback

    As the aim of this PREreview is to support the authors by providing constructive feedback, the PREreviewer(s) should also include positive remarks to encourage future posting of preprints. Remember, the authors are human too!

    To help guide you, here are a few questions you might ask yourself after reading the preprint:

What results did you find the most interesting and why?

What did you learn from the study that really fascinated you?

            Did you learn anything from this preprint that you would include in your future work? Examples could be a new technique, a new way of approaching an idea, a certain way of interpreting the type of data, a good way of summarizing the results, the structure of the manuscript if it is clear and logical, etc.

            What ideas for further research are based on the preprint? [Note: this encourages preprint authors for their early sharing and promotes openness among reviewers as well.]

    Concerns

    Next are your concerns. Remember you are writing to another human being, so be respectful and realistic. Also, if you are unsure about something, be honest and say you are unsure. Don’t feel afraid to admit if you are not confident about your concerns, or part of the work is out of your area of expertise.

    Major concerns

    Here the reviewer(s) should list 2-3 major concerns about the research (if they exist). This may relate to:

Does the title accurately reflect the results?

            Experimental design: were the techniques appropriate for the hypothesis? Were suitable controls included? Were new techniques/mutants/cell lines etc. sufficiently characterized to allow the study to be replicated? Were robust statistical methods used?

            Do the results support the authors’ conclusions and, if not, what additional experiments would you suggest?

            Are there big flaws in the understanding of the current literature and interpretation of the literature that might undermine the interpretation of the current results?

    Minor concerns

    Here the PREreviewer(s) can mention 3-5 minor concerns that are not critical to the understanding and conclusions of the research but would improve the overall flow or clarity of the manuscript. These concerns might include the following questions:

            In general, was the manuscript easy to follow/did it have a logical
            flow? Were there a lot of typos that needed addressing?

            Does the abstract provide a concise summary of the hypotheses and
            main results?

            Were the methods sufficiently detailed to allow the experiments to
            be repeated?

            Were the figures clear and logically arranged? Were the figure
            legends sufficiently detailed to allow the figures to be understood
            without reading the main text?

            Are the figures representative of the data described in the results
            section?

            Did the authors make all their associated data openly available
            (e.g. sequencing data, coding)?

            Did the discussion address how their results move the field
            forwards?

Were the citations thorough or were key references missing?

You can find additional peer review tips in the PLOS Peer Reviewer Center, including their How To Peer Review page that contains 10 Tips for getting started as a reviewer. These resources include checklists, videos, and further information about ethical considerations, etc. They also provide suggested language you can use to address common issues that can arise when reviewing a manuscript.

    Template 1

    Below is a list of quick questions and suggestions you can use to guide your reading and reviewing of the selected preprint to produce a quick review.

        What is the main question the study attempts to answer?

        What is (are) the hypothesis(es)?

        What techniques/analyses do the researchers adopt to test their hypothesis(es)?

        Why is this study relevant?

        Write here any general comments you might have about the research approach.

        Write here any specific comment you might have about experimental approaches and methods used in the study.

        Write here any specific comment/note about figures in the preprint (this could be related to the way data are displayed and your ability to understand the results just by looking at the figures).

        Write here any additional comment you might have (this includes minor concerns such as typos and structure of the manuscript).

    Template 2

    Below is a detailed guide to help you critically and constructively evaluate the selected preprint.

    Overview and take-home message

    Write a short (1 paragraph) summary of what the main findings of the research were and how this work has moved the field forward. This could take the following structure:

“[First author] et al., have made significant advances in [x, y, and z] by showing that… In addition, they have bridged the gap in our knowledge about how [process i interacts with process ii]. Although this work is of [significant] interest in the field, there are some concerns that could be addressed in the next version. These are outlined below.”

    Positive feedback

    As the aim of this PREreview is to support the authors by providing constructive feedback, the PREreviewer(s) should also include positive remarks to encourage future posting of preprints. Remember, the authors are human too!

    To help guide you, here are a few questions you might ask yourself after reading the preprint:

What results did you find the most interesting and why?

What did you learn from the study that really fascinated you?

            Did you learn anything from this preprint that you would include in your future work? Examples could be a new technique, a new way of approaching an idea, a certain way of interpreting the type of data, a good way of summarizing the results, the structure of the manuscript if it is clear and logical, etc.

            What ideas for further research are based on the preprint? [Note: this encourages preprint authors for their early sharing and promotes openness among reviewers as well.]

    Concerns

    Next are your concerns. Remember you are writing to another human being, so be respectful and realistic. Also, if you are unsure about something, be honest and say you are unsure. Don’t feel afraid to admit if you are not confident about your concerns, or part of the work is out of your area of expertise.

    Major concerns

    Here the reviewer(s) should list 2-3 major concerns about the research (if they exist). This may relate to:

Does the title accurately reflect the results?

            Experimental design: were the techniques appropriate for the hypothesis? Were suitable controls included? Were new techniques/mutants/cell lines etc. sufficiently characterized to allow the study to be replicated? Were robust statistical methods used?

            Do the results support the authors’ conclusions and, if not, what additional experiments would you suggest?

            Are there big flaws in the understanding of the current literature and interpretation of the literature that might undermine the interpretation of the current results?

    Minor concerns

    Here the PREreviewer(s) can mention 3-5 minor concerns that are not critical to the understanding and conclusions of the research but would improve the overall flow or clarity of the manuscript. These concerns might include the following questions:

            In general, was the manuscript easy to follow/did it have a logical
            flow? Were there a lot of typos that needed addressing?

            Does the abstract provide a concise summary of the hypotheses and
            main results?

            Were the methods sufficiently detailed to allow the experiments to
            be repeated?

            Were the figures clear and logically arranged? Were the figure
            legends sufficiently detailed to allow the figures to be understood
            without reading the main text?

            Are the figures representative of the data described in the results
            section?

            Did the authors make all their associated data openly available
            (e.g. sequencing data, coding)?

            Did the discussion address how their results move the field
            forwards?

Were the citations thorough or were key references missing?

You can find additional peer review tips in the PLOS Peer Reviewer Center, including their How To Peer Review page that contains 10 Tips for getting started as a reviewer. These resources include checklists, videos, and further information about ethical considerations, etc. They also provide suggested language you can use to address common issues that can arise when reviewing a manuscript.

@murkatr what's this issue about? Should we close it as it's potentially a replica of issue #366?


Convert_to_webp_lossless results in strange colors

Converting jpegs to webp changes its color to different. Example here: https://hdrmaps.com/nettle-weed-atlas-1/
As this is a live site I have chanegd background to one matching new image #1f1f1f.
Converted image should have background color: #202020, but it has #1f1f1f
When I turn it off it's ok. I have noticed it on all images.

What do you mean with background color? css?
I can´t see any diff between pagespeed enabled/disabled


Feature requests: \yii\data\DataFilter accept filter in JSON format

Yii REST API filter format is very verbose (and confusing if complex AND/OR logic is required). If you need enter very complex filter, you may exceed HTTP url max length (2048 chars?).
I developped add-on feature that will allow to provide filter also in JSON format. Url params may looks like:
?filter={"productName":{"like":"iPhone"}}
This is not replacement of "standard" filter param system (?filter[productName][like]=iPhone), you can still use it. Both systems can work in parallel.
Implementation is easy, sligtly change / override load() method in \yii\base\Model.
I override it in my custom ActiveDataFilter class this way:
public function load($data, $formName = null)
{
	// if filter attribute is set and is not array, we may expect it's in JSON format
	if (isset($data[$this->filterAttributeName]) && !is_array($data[$this->filterAttributeName])) {
		try{
			// try to decode json
			$data[$this->filterAttributeName] = Json::decode($data[$this->filterAttributeName]);
		} catch (\Exception) {
			// not sure how to properly respond to Json::decode error
			// $this->>addError will not help, later it will be override during validation with error "The format of Filter is invalid".
		}
	}

	// now we have filter in required array format, we can simply pass it to parent class load method
	return parent::load($data, $formName);
}

Looks interesting. Do you want to make it optional?

It's up to your recommendation. I'm not so skilfull with Yii to see all possible consequences of this change.
For example is this feature related to DataFilter class level only or may sense to implement it to "low level" Model class?
Or is there some security risk to implement it as standard behaviour (not optional)? I believe not because validation mechanism should care about it, right?

For example is this feature related to DataFilter class level only or may sense to implement it to "low level" Model class?

That's filter-specific.

Or is there some security risk to implement it as standard behaviour (not optional)? I believe not because validation mechanism should care about it, right?

Should be alright security-wise.

Can you please also implement this change, it's related to the topic:
Currently in filter is not possible to use "standard" operators (=, !=, <, ...) as operator, only the alternate ones (eq, neq, lt, ...).
This expression ?filter[ammount][=]=10 will cause error "Ammount must be integer."
I understand that using standard operators in url can be risky, but for filter in json format is not the issue.
It can be simply achieved by extending DataFilter->filterControls:
Whole code will be:
public $filterControls = [
        '=' => '=',
        '!=' => '!=',
        '<' => '<',
        '>' => '>',
        '<=' => '<=',
        '>=' => '>=',
        'and' => 'AND',
        'and' => 'AND',
        'or' => 'OR',
        'not' => 'NOT',
        'lt' => '<',
        'gt' => '>',
        'lte' => '<=',
        'gte' => '>=',
        'eq' => '=',
        'neq' => '!=',
        'in' => 'IN',
        'nin' => 'NOT IN',
        'like' => 'LIKE',
    ];

I understand that using standard operators in url can be risky, but for filter in json format is not the issue.

It is an issue since at least = in URLs has special meaning.

As for implementing, that's not a high priority so if you need it anytime soon it's better to do it yourself and send us a pull request to review/merge.

And (probably) last idea to this topic:
Operator "like" can only search for string in any position (LIKE %string%).
I'm missing possibilty to search string on beggining (LIKE string%) or end (LIKE %string).
I achieved this functionality defining new condition builder functions:
protected function buildLikeXCondition($operator, $condition, $attribute)
{
	if (isset($this->queryOperatorMap[$operator])) {
		$operator = $this->queryOperatorMap[$operator];
	}
	return ['LIKE', $attribute, $this->filterAttributeValue($attribute, $condition) . '%', false];
}

protected function buildXLikeCondition($operator, $condition, $attribute)
{
	if (isset($this->queryOperatorMap[$operator])) {
		$operator = $this->queryOperatorMap[$operator];
	}
	return ['LIKE', $attribute, '%' . $this->filterAttributeValue($attribute, $condition), false];
}

and put new deifitions into DataFilter properties:
(this code is from __construct() of my custom ActiveDataFIlter class, but )
$this->filterControls['like%'] = 'LIKE%';
$this->filterControls['%like'] = '%LIKE';

$this->operatorTypes['LIKE%'] = [self::TYPE_STRING];
$this->operatorTypes['%LIKE'] = [self::TYPE_STRING];

$this->conditionValidators['LIKE%'] = 'validateOperatorCondition';
$this->conditionValidators['%LIKE'] = 'validateOperatorCondition';

$this->conditionBuilders['LIKE%'] = 'buildLikeXCondition';
$this->conditionBuilders['%LIKE'] = 'buildXLikeCondition';

Now it's possible to use filter
?filter[productName][like%]=Apple


correct vamp-mesosphere version

Hi @tnolet,
there is no latest version (https://registry.hub.docker.com/u/magneticio/vamp-mesosphere/tags/manage/). Compose fails because of this with the following error:
berndzuther@cc-4 ~/development/vamp-docker/docker-compositions/vamp-marathon-mesos (master)$ docker-compose up
Recreating vampmarathonmesos_zk_1...
Recreating vampmarathonmesos_slave1_1...
Recreating vampmarathonmesos_master_1...
Recreating vampmarathonmesos_slave2_1...
Recreating vampmarathonmesos_marathon_1...
Creating vampmarathonmesos_vamp_1...
Pulling image magneticio/vamp-mesosphere:latest...
Pulling repository magneticio/vamp-mesosphere
Traceback (most recent call last):
File "/usr/local/Cellar/fig/1.2.0/libexec/bin/docker-compose", line 9, in
load_entry_point('docker-compose==1.2.0', 'console_scripts', 'docker-compose')()
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/main.py", line 31, in main
command.sys_dispatch()
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/docopt_command.py", line 21, in sys_dispatch
self.dispatch(sys.argv[1:], None)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/command.py", line 27, in dispatch
super(Command, self).dispatch(*args, **kwargs)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/docopt_command.py", line 24, in dispatch
self.perform_command(*self.parse(argv, global_options))
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/command.py", line 59, in perform_command
handler(project, command_options)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/cli/main.py", line 464, in up
do_build=not options['--no-build'],
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/project.py", line 208, in up
do_build=do_build):
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/service.py", line 214, in recreate_containers
**override_options)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/service.py", line 199, in create_container
stream_output(output, sys.stdout)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/progress_stream.py", line 37, in stream_output
print_output_event(event, stream, is_terminal)
File "/usr/local/Cellar/fig/1.2.0/libexec/lib/python2.7/site-packages/compose/progress_stream.py", line 50, in print_output_event
raise StreamOutputError(event['errorDetail']['message'])
compose.progress_stream.StreamOutputError: Tag latest not found in repository magneticio/vamp-mesosphere

@zutherb I guess we forgot to tag 0.7.7 as "latest"! We are automating this stuff ASAP so we wont forget in the future. Let's keep the compose template on :latest. This saves updating the template every time.


radio

connects to #23

Radio has been updated in another branch in a way that corresponds to more component patterns.


Improved filtering for array type fields

What would you like to be added?
Currently the only option I can see when trying to filter based on field that is an array is s empty or is not empty
The example in the screenshot is for tags.

It would be great if array type data fields had the same options as string type fields, like name, i.e., is empty, is not empty, is, is not, contains and does not contain.

Why is this needed?
It's needed because - in my case - tags are one of the easiest way to filter different types of notes, like when building a board that shows user stories it would be much easier to  filter tags contains user-story rather than name contains "User Story" or path contains "User Stories".

Closing in favor of #447.


Yield result

First I just wanted to thank you for this library, it's been super helpful!
I've just run in to a problem, I would like to yield a result instead of returning a result.
This is works fine on my pi pico:
from time import sleep

def count():
    i = 0
    while True:
        i += 1
        yield i

for index in count():
    sleep(1)
    print(index)

However when I try and use belay with:
import belay
from time import sleep

device = belay.Device("COM5")

@device.task
def count():
    i = 0
    while True:
        i += 1
        yield i

for index in count():
    print(index)

I receive the error:
  Type "() -> Generator[Literal[1], None, None]" cannot be assigned to type "((...) -> PythonLiteral) | None"
    Type "() -> Generator[Literal[1], None, None]" cannot be assigned to type "(...) -> PythonLiteral"
      Function return type "Generator[Literal[1], None, None]" is incompatible with type "PythonLiteral"
        Type "Generator[Literal[1], None, None]" cannot be assigned to type "PythonLiteral"
          Type cannot be assigned to type "None"
          "Generator[Literal[1], None, None]" is incompatible with "bool"
          "Generator[Literal[1], None, None]" is incompatible with "bytes"
          "Generator[Literal[1], None, None]" is incompatible with "int"

Thanks!

I agree this would be nice to have,and perfectly fit many belay use cases !

Thanks for the interest! I should have some time in a few days to work on this, hopefully I'll figure out a way to support generators.

@pak-man @BearXP checkout the newly pushed generators branch. I still have to polish it up, but see if it works for your use cases (I added a 10th example using your demo code in this issue). I'm going to try and merge (and do a release) sometime over the next day or two.

Belay v0.5.0 has been released, which includes this generator support. Closing this issue for now. We can re-open/start a new issue if you find this hasn't been fully resolved. Thanks!


Recoverable Items folder operation

“For Exchange mailboxes: The copy is retained in the Recoverable Items folder.”
Requesting an addition of clarifying information: Which subfolder in the Recoverable Items folder is being used and preserved? Or are all items in the Recoverable item’s subfolders preserved?
How does this interact with items preserved by the in-place hold, eDiscovery hold, and litigation holds? Example if you have retention policy and remove a eDiscovery hold normally the following would occur “After a mailbox user is removed from In-Place Hold or Litigation Hold, items in the DiscoveryHold, Purges, and Versions folders are purged by the Managed Folder Assistant.” In this situation does a retention policy preserve the items in these folders?
Reference
https://docs.microsoft.com/en-us/exchange/security-and-compliance/in-place-and-litigation-holds

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c49609d-3a62-b9be-24bf-f8fa6948d390
Version Independent ID: df547c86-fbc7-4f87-e893-49d07b045373
Content: Learn about retention policies & labels to automatically retain or delete content - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/retention.md
Service: o365-seccomp
GitHub Login: @cabailey
Microsoft Alias: cabailey

@Bievens Thank you for your feedback.

If In-Place Hold, Litigation Hold, or a Microsoft 365 or Office 365 retention policy is enabled, The "versions" folder contains the original copy of the item, and also if the item is modified multiple times, a copy of the item before modification is saved.

2)There are no conflicts between retention policies and Hold. In this scenario, the retention policy continues to preserve the items in this folder.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @Bievens Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


isSafeInteger

Is isSafeInteger something Underscore should tackle?
I went down the rabbit hole a bit with the number methods and ended up with isSafeInteger, isInteger, isLength, toInteger, toSafeInteger, toLength, & toNumber.

@jdalton were you proposing that isInteger, isLength, toInteger, toSafeInteger, toLength, & toNumber were also to be supported?

I'm ok with it.

Personally, I think this is the kind of thing that would be more suited for an extension library like Underscore-Contrib.


sbt.ResolveException: unresolved dependency: commons-logging#commons-logging

Any idea why i get this error when running ./sbt test?
smueller@Miami-2 ~/dev/src/commercetools-sunrise-java $ ./sbt test
[info] Loading project definition from /Users/smueller/dev/src/commercetools-sunrise-java/project
[info] Set current project to commercetools-sunrise (in build file:/Users/smueller/dev/src/commercetools-sunrise-java/)
[info] Updating {file:/Users/smueller/dev/src/commercetools-sunrise-java/}common...
[info] Resolving com.typesafe.play#twirl-api_2.11;1.1.1 ...
[info] Compiling 1 Java source to /Users/smueller/dev/src/commercetools-sunrise-java/sbt-tasks/target/scala-2.11/test-classes...
[info] Resolving org.apache.commons#commons-lang3;3.4 ...
[info] Compiling 6 Java sources to /Users/smueller/dev/src/commercetools-sunrise-java/move-to-sdk/target/scala-2.11/test-classes...
[info] Resolving commons-io#commons-io;2.4 ...
[info] Test run started
[info] Test tasks.WebjarsFilesCopierTest.copiesMultipleFiles started
[info] Test run started
[info] Resolving org.assertj#assertj-core;3.0.0 ...
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.emptyWhenNotConfigured started
[info] Test tasks.WebjarsFilesCopierTest.copiesFile started
[info] Test tasks.WebjarsFilesCopierTest.copiesFileFromAJarPackage started
[info] Test tasks.WebjarsFilesCopierTest.failsSilentlyOnInvalidFile started
[info] Test tasks.WebjarsFilesCopierTest.copiesFileWithNonExistingDirectory started
[info] Test tasks.WebjarsFilesCopierTest.copiesFileWithExistingDirectory started
[info] Test run finished: 0 failed, 0 ignored, 6 total, 0.781s
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.discardsWithEmptyCategoryTree started
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.worksWithEmptyFacetOptions started
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.discardsOnMissingLocale started
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.discardsEmptyBranches started
[info] Passed: Total 6, Failed 0, Errors 0, Passed 6
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.keepsOrderFromCategoryTree started
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.inheritsInformationFromLeaves started
[info] Test io.sphere.sdk.facets.CategoryTreeFacetOptionMapperTest.replacesIdForName started
[info] Test run finished: 0 failed, 0 ignored, 8 total, 0.778s
[info] Test run started
[info] Test io.sphere.sdk.facets.SelectFacetTest.optionsListIsTruncatedIfOverLimit started
[info] Test io.sphere.sdk.facets.SelectFacetTest.optionsListIsNotTruncatedIfBelowLimit started
[info] Test io.sphere.sdk.facets.SelectFacetTest.doesNotFilter started
[info] Test io.sphere.sdk.facets.SelectFacetTest.canBeDisplayedIfOverThreshold started
[info] Test io.sphere.sdk.facets.SelectFacetTest.canNotBeDisplayedIfBelowThreshold started
[info] Test io.sphere.sdk.facets.SelectFacetTest.filtersByAnyFilterValues started
[info] Test io.sphere.sdk.facets.SelectFacetTest.throwsExceptionOnWrongThresholdAndLimit started
[info] Test io.sphere.sdk.facets.SelectFacetTest.filtersByAllFilterValues started
[info] Test run finished: 0 failed, 0 ignored, 8 total, 0.049s
[info] Test run started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceWithDifferentSelected started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceWithDifferentChildren started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstance started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceWithDifferentCount started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceWithDifferentValue started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceFromTermStatsWithUnselectedValue started
[info] Test io.sphere.sdk.facets.FacetOptionTest.createsInstanceFromTermStats started
[info] Test run finished: 0 failed, 0 ignored, 7 total, 0.012s
[info] Test run started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.sortsOptionsAsGivenList started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.comparisonEnsuresTransitiveRelation started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.onEmptyListKeepsSameOrder started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.worksWithEmptyFacetOptions started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.comparisonEnsuresSymmetricRelation started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.givenUnsortedFacetOptionsAreNotSorted started
[info] Test io.sphere.sdk.facets.CustomSortedFacetOptionMapperTest.leavesUnknownOptionsAtTheEnd started
[info] Test run finished: 0 failed, 0 ignored, 7 total, 0.011s
[info] Test run started
[info] Test io.sphere.sdk.facets.SelectFacetBuilderTest.mapsOptions started
[info] Test io.sphere.sdk.facets.SelectFacetBuilderTest.createsInstanceWithOptionalValues started
[info] Test io.sphere.sdk.facets.SelectFacetBuilderTest.createsInstance started
[info] Test io.sphere.sdk.facets.SelectFacetBuilderTest.createsInstanceWithDifferentFacetResult started
[info] Resolving oauth.signpost#signpost-commonshttp4;<IP_ADDRESS> ...
[info] Test run finished: 0 failed, 0 ignored, 4 total, 0.235s
[info] Test run started
[info] Test io.sphere.sdk.play.metrics.MetricHttpClientTest.executesRequestWithNoContext started
[info] Test io.sphere.sdk.play.metrics.MetricHttpClientTest.executesRequestWithContext started
[info] Test io.sphere.sdk.play.metrics.MetricHttpClientTest.reportsMetricsWithContext started
[info] Test run finished: 0 failed, 0 ignored, 3 total, 0.026s
[info] Passed: Total 37, Failed 0, Errors 0, Passed 37
[info] Resolving jline#jline;2.12.1 ...
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: commons-logging#commons-logging;1.1.1: configuration not found in commons-logging#commons-logging;1.1.1: 'master(compile)'. Missing configuration: 'compile'. It was required from commons-beanutils#commons-beanutils;1.9.2 compile
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn]  Note: Unresolved dependencies path:
[warn]      commons-logging:commons-logging:1.1.1
[warn]        +- commons-beanutils:commons-beanutils:1.9.2 (/Users/smueller/dev/src/commercetools-sunrise-java/build.sbt#L117)
[warn]        +- common:common_2.11:0.7.0-SNAPSHOT
sbt.ResolveException: unresolved dependency: commons-logging#commons-logging;1.1.1: configuration not found in commons-logging#commons-logging;1.1.1: 'master(compile)'. Missing configuration: 'compile'. It was required from commons-beanutils#commons-beanutils;1.9.2 compile
    at sbt.IvyActions$.sbt$IvyActions$$resolve(IvyActions.scala:313)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:191)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:168)
    at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:156)
    at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:156)
    at sbt.IvySbt$$anonfun$withIvy$1.apply(Ivy.scala:133)
    at sbt.IvySbt.sbt$IvySbt$$action$1(Ivy.scala:57)
    at sbt.IvySbt$$anon$4.call(Ivy.scala:65)
    at xsbt.boot.Locks$GlobalLock.withChannel$1(Locks.scala:93)
    at xsbt.boot.Locks$GlobalLock.xsbt$boot$Locks$GlobalLock$$withChannelRetries$1(Locks.scala:78)
    at xsbt.boot.Locks$GlobalLock$$anonfun$withFileLock$1.apply(Locks.scala:97)
    at xsbt.boot.Using$.withResource(Using.scala:10)
    at xsbt.boot.Using$.apply(Using.scala:9)
    at xsbt.boot.Locks$GlobalLock.ignoringDeadlockAvoided(Locks.scala:58)
    at xsbt.boot.Locks$GlobalLock.withLock(Locks.scala:48)
    at xsbt.boot.Locks$.apply0(Locks.scala:31)
    at xsbt.boot.Locks$.apply(Locks.scala:28)
    at sbt.IvySbt.withDefaultLogger(Ivy.scala:65)
    at sbt.IvySbt.withIvy(Ivy.scala:128)
    at sbt.IvySbt.withIvy(Ivy.scala:125)
    at sbt.IvySbt$Module.withModule(Ivy.scala:156)
    at sbt.IvyActions$.updateEither(IvyActions.scala:168)
    at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1439)
    at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1435)
    at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$90.apply(Defaults.scala:1470)
    at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$90.apply(Defaults.scala:1468)
    at sbt.Tracked$$anonfun$lastOutput$1.apply(Tracked.scala:37)
    at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1473)
    at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1467)
    at sbt.Tracked$$anonfun$inputChanged$1.apply(Tracked.scala:60)
    at sbt.Classpaths$.cachedUpdate(Defaults.scala:1490)
    at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1417)
    at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1369)
    at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
    at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
    at sbt.std.Transform$$anon$4.work(System.scala:63)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
    at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
    at sbt.Execute.work(Execute.scala:237)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
    at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
    at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
[error] (common/*:update) sbt.ResolveException: unresolved dependency: commons-logging#commons-logging;1.1.1: configuration not found in commons-logging#commons-logging;1.1.1: 'master(compile)'. Missing configuration: 'compile'. It was required from commons-beanutils#commons-beanutils;1.9.2 compile
[error] Total time: 5 s, completed 02.05.2016 22:31:28

cannot reproduce.
Sometimes this kind of error happens with corrupt files/configs in ~/.ivy2 or in the public repo.
Deleting ~/.ivy2 folder might help.
If that does not work we could overwrite the logging dependency to a newer version.

Thx, clearing the .ivy2/ folder did indeed help in my case.

My error is not getting resolved after deleting the folder ~/.ivy2.
scalaVersion := "2.11.8"
I have deleted the .ivy2 and rebuild the project using "sbt package". It has re-downloaded all the packages. However the error is still not resolved.
Can someone advise on this pls.
:: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
Exception in thread "main" java.lang.RuntimeException: [unresolved dependency: commons-codec#commons-codec;1.9: not found, unresolved dependency: com.fasterxml.jackson.core#jackson-annotations;2.6.0: not found, download failed: commons-logging#commons-logging;1.1.3!commons-logging.jar]
at org.apache.spark.deploy.SparkSubmitUtils$.resolveMavenCoordinates(SparkSubmit.scala:1204)
at org.apache.spark.deploy.SparkSubmit$.prepareSubmitEnvironment(SparkSubmit.scala:304)
at org.apache.spark.deploy.SparkSubmit$.submit(SparkSubmit.scala:153)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:119)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
Traceback (most recent call last):
File "/usr/hdp/current/spark2-client/python/pyspark/shell.py", line 38, in
SparkContext._ensure_initialized()
File "/usr/hdp/current/spark2-client/python/pyspark/context.py", line 293, in _ensure_initialized
SparkContext._gateway = gateway or launch_gateway(conf)
File "/usr/hdp/current/spark2-client/python/pyspark/java_gateway.py", line 95, in launch_gateway
raise Exception("Java gateway process exited before sending the driver its port number")
Exception: Java gateway process exited before sending the driver its port number

Hey any update about this error. For my case also even a fresh empty project throwing the same error.

I had an unresolved dependency issue with spark so I added this to my build.sbt:
libraryDependencies += "org.apache.commons" % "commons-compress" % "1.18"
After I committed, pushed, and checked TravisCI the tests all passed. Hope this helps someone else.


Optional to empty itemstack(ItemStack.empty())

ArmorEquipable interface has many methods to get/set items in armor slots and hand. These methods return optionals, but there is empty itemstack. Maybe change these methods to return just ItemStack, because api has empty itemstack?
Also, replace every Optional in api to just ItemStack.

For API8 empty Optional means that the Slot does not exist. So replacing all Optional wont work.
E.g. inv.peek(slotIndex) is the same as inv.getSlot(slotIndex).map(Slot::peek)
So in theory I could remove the Optionals on ArmorEquipable.
Will have to check if all implementing it actually have all those Slots.
Also ArmorEquipable should maybe be renamed. Its not only armor but also main and offhand

Good point. Some mod can modify hand types or remove/add some slots in ArmorEquipable. I did not think about that.

So, if you want to talk about ArmorEquipable renaming here, you can just reopen this issue.

I'm actually fine with removing Optional on the ArmorEquipable.
Only stuff that provides all slots implements it.

And what if some mod removes some armor slot?

Then we have a problem anyways. But probably the mod would hide the slot instead.

https://github.com/SpongePowered/SpongeCommon/pull/1946


chromdriver version and headless chrome

We're doing some experimenting with headless chrome in place of phantomjs for our testing.
It seems headless chrome needs a pretty recent version of chromedriver. This package currently only gets chromedriver 2.28, and the "getting started with headless chrome" page recommends at least version 2.32 (latest: 2.33)
Any chance for an update?

Hi @bricas, I don't have time at the moment but it would be great if you could fork the repo, make the change and issue a pull request as part of your experimentation work :)

Hey @john-doherty, I'm closing this ticket. Although I'd still recommend updating the dep version, here's what I've found:

There tends to be a conflict between the chromedriver and electron-chromedriver packages as they both want to put their own chromedriver in the path
The chromium package for alpine linux also has a chromedriver package, so i can remove executable downloaded by npm and my system's chromedriver will be used (which i know will work with the version of chromium installed)
I can create my own driver file (which your package will happily load) and pass the necessary options to get chrome headless to run

All of that to say I've worked around the issues I thought I was having. :)
Cheers.


removeByxxxx was call the select fucntion

My project use the query method that named removeByKey. I think that it will excute the sql just like "delete from tableName where key = ?", but it excute the select sql finally. hope fix this bug.
Create a empty project can reproduce it.

Duplicate of #771


Fix warning in latest version of ansible

I am seeing this warning when using this module with ansible 2.8.0:
[DEPRECATION WARNING]: evaluating users_create_per_user_group as a bare variable, this behaviour will go away and you might need to add |bool to the expression in the
future. Also see CONDITIONAL_BARE_VARS configuration toggle.. This feature will be removed in version 2.12. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.

The change in this pull request stops the warning.

I merged another PR that linted the file you are editing. Can you rebase your PR to address the merge conflicts?
Also, I think that the scope of this deprecation warning is currently being debated on https://github.com/ansible/ansible/issues/53428. As far as I can tell, this is already clearly a boolean value and shouldn't be affected by the behavior change. If you believe it will cause an issue, let me know and I will take another look.


Queries for Server Definitions should return proper JSON

When a GEE server is queried for Server Definitions the response is not valid JSON. It would be better if the returned values were valid JSON so that they can be read by parsers.
To see an example run a query against a server:
http:////query?request=Json

In order to maintain backward compatibility with clients, we'll need to add a new parameter to the query string

This will also need to be implemented separately for Server and for Portable

I'm not sure backward compatibility would be an issue.  I think it would be better to have the data in standard minified JSON when building a database, and not have to have it in two different formats.
Standard JSON is valid Java Script, so any client, such as a browser, that supports Java Script would be compatible with JSON.  Do we have clients that we're supporting that would not support JSON?

@tst-ppenev I definitely think it would make sense to convert the format to JSON. At a minimum for clarity, given much of the codebase uses the word JSON when its actually JavaScript.

This discussion involves some decisions that are beyond just this issue.
I would say, if we want to support custom clients, we should define an API, and, version it, and specify how long versions would be supported, and how transitions would occur.  We would also want to keep some track of what versions of the API are used, and how often.
I don't think we can try to support something unknown for very long. It adds overhead to all of the development that deals with this part of the code, and we have no way of verifying that anything we're supposedly supporting actually works.  The only thing we can do is not change, which is not a very good way to develop, and adds an increasing amount of overhead with time.
It would help to have an idea of what real use problems something is solving to decide what effort is worth spending on it.


Update Composer dependencies (2021-07-22-00-05)

Visual regression test passed!
View the visual regression test report


Spark-application CRD can be managed using role/rolebinding instead of clusterrole/clusterrolebinding?

We want to know if spark-application CRD can be managed using role/rolebinding instead of clusterrole/clusterrolebinding. We were under the impression that if CRD is namespace scoped, then role/rolebinding is sufficient. Here is the reference link.
https://thorsten-hans.com/custom-resource-definitions-with-rbac-for-serviceaccounts#create-the-custom-resource-definition
But we’re facing permission issues when we try to access spark-application CRD using role/rolebinding. Here is the error:
reflector.go:125] github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/factory.go:119: Failed to list *v1beta2.SparkApplication: sparkapplications.sparkoperator.k8s.io is forbidden: User "system:serviceaccount:yarra:yarra-spark-operator" cannot list resource "sparkapplications" in API group "sparkoperator.k8s.io" at the cluster scope

CRD is non-namespaced, i.e., cluster-scoped.

Thanks @liyinan926 for your comment. We see that SparkApplication CRD definition mentions the scope as “Namespaced”. Pasting the snippet of the definition below for reference. Wanted to understand what does it mean?
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
creationTimestamp: null
name: sparkapplications.sparkoperator.k8s.io
spec:
group: sparkoperator.k8s.io
names:
kind: SparkApplication
listKind: SparkApplicationList
plural: sparkapplications
shortNames:
- sparkapp
singular: sparkapplication
scope: Namespaced

The Namespaced scope means custom resource instances of the kind SparkApplication are namespace scoped. But CRDs that define custom resource kinds are always non-namespaced.


KOGITO-1606: Add install option in makefile

We would like to provide an "install" option to Makefile so we can easily make use of the operator in an Openshift instance.
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

@Sgitario thanks for the PR! :)
Please check the requirements and adjust your PR description.

Description updated.

Where's the JIRA's link? :stuck_out_tongue:


[command] nullable boolean options should be-tristate in the web UI

If an options is set to ?bool, then there are actually 3 conditions for calling the CLI

passing the option

passing the no-option

passing nothing
--reset|--no-reset        Delete images csv file before starting

In the user interface, we only have 2 options, because it's a checkbox.  We need all 3, probably as a radio option, e.gg

Should be
() --reset    (*) --no-reset () default (don't pass)

The issue is in CommandFormType.php, it shouldn't be a checkbox, but a choice type

Can you put the radio buttons on the same line?
On Thu, Aug 3, 2023 at 8:01 AM Hryhoruk Anton @.***>
wrote:

[image: image]
https://user-images.githubusercontent.com/28703686/258135416-ca1a2583-d748-48e7-93c8-4bba521b9e48.png
—
Reply to this email directly, view it on GitHub
https://github.com/survos/survos/issues/21#issuecomment-1664039760, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEXIQJWVGFNGAJ5UY7VX2DXTOVMJANCNFSM6AAAAAA3CW3J5E
.
You are receiving this because you authored the thread.Message ID:
@.***>


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4697

Questions ?
Please refer to the Backport tool documentation


import sparseqr error

I have downloaded and installed both SuiteSparse and sparseqr packages, however when I try to import:  ( import sparseqr ), I get the following error:
=== Wrapper module not compiled; compiling...
generating /usr/local/lib/python3.10/dist-packages/sparseqr/_sparseqr.c
setting the current directory to '/usr/local/lib/python3.10/dist-packages'
INFO:root:running build_ext
INFO:root:building 'sparseqr._sparseqr' extension
INFO:root:x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -fPIC -I/usr/include/suitesparse -I/opt/homebrew/include -I/usr/include/python3.10 -c sparseqr/_sparseqr.c -o ./sparseqr/_sparseqr.o
ModuleNotFoundError                       Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/sparseqr/sparseqr.py in
14 try:
---> 15     from ._sparseqr import ffi, lib
16 except ImportError:
ModuleNotFoundError: No module named 'sparseqr._sparseqr'                      <------------------- This is what I am getting.
During handling of the above exception, another exception occurred:
DistutilsExecError                        Traceback (most recent call last)
22 frames
DistutilsExecError: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
During handling of the above exception, another exception occurred:
CompileError                              Traceback (most recent call last)
CompileError: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
During handling of the above exception, another exception occurred:
VerificationError                         Traceback (most recent call last)
/usr/local/lib/python3.10/dist-packages/cffi/ffiplatform.py in _build(tmpdir, ext, compiler_verbose, debug)
52             set_threshold(old_level)
53     except (CompileError, LinkError) as e:
---> 54         raise VerificationError('%s: %s' % (e.class.name, e))
55     #
56     return soname
VerificationError: CompileError: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
Thank you in advance for your help.

The same error was reported here: https://github.com/jwyang/faster-rcnn.pytorch/issues/641. The solution for them was to change some paths. Are you able to try that? For them it was:
export PATH=/usr/local/cuda-8.0/bin${PATH:+:${PATH}}
export CPATH=/usr/local/cuda-8.0/include${CPATH:+:${CPATH}}
export LD_LIBRARY_PATH=/usr/local/cuda-8.0/lib64${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}

Another solution is to move the compilation to setup.py (https://cffi.readthedocs.io/en/latest/cdef.html under "For Setuptools (out-of-line only, but works in ABI or API mode; recommended)") and use cibuildwheel https://github.com/pypa/cibuildwheel to have github do all the compilation in advance.

The link says to change paths in the  make.sh file. But I do not see that file. I only see _sparseqr.c file. Would that be the one?

Those are environment variables. Can you set environment variables for the environment in which your Python is running and importing sparseqr?


clean up python mapping

Docs Build status updates of commit 2986f5e:
:clock10: Full build: the average full build time is 128 min(s) 23 sec(s), this is based on the last 140 build(s) for this repository.

Docs Build status updates of commit 2986f5e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

preview/docs-ref-autogen/azure-core/azure.core.polling.yml
:warning:Warning
View (azure-python-preview)
Details

docs-ref-mapping/reference-preview.yml
:white_check_mark:Succeeded

docs-ref-mapping/reference.yml
:white_check_mark:Succeeded

preview/docs-ref-autogen/azure-core/azure.core.polling.yml

[Warning] Uid(azure.core.polling.async_poller) has already been defined in preview/docs-ref-autogen/azure-core/azure.core.polling.yml.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


opencv: update cuda_opt_flow.patch

Motivation for this change
Closes #126623
Things done
updated the patch
Still compiling, and i dont have nvidia so i cant test more than compiling

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@dsxmachina to test this
nixpkgs.overlays = let
    pkgsMaster = import ( pkgs.fetchFromGitHub {
    owner = "NixOS";
    repo = "nixpkgs";
    rev = "bbca3f88ff5a6d1f7dca6b232514d64546ca9926";
    sha256 = "0swc03w76sb8gq2sq0yazf66qczhazgg19mwqi0dsxmay8p238vc";
    });

    masterOverlay = self: super: {
      master = super.callPackage pkgsMaster { config = super.config; };
    };

  in
  [
    masterOverlay
  ];

and add (master.opencv.override { enableCuda = true; }) to systemPackages

https://github.com/NixOS/nixpkgs/blob/cedcf2565c6b982d703d67455199b09a3d905d86/pkgs/development/libraries/nvidia-optical-flow-sdk/default.nix i'll have to update this too


Fix already refers warnings in Clojure 1.11

Closes #348

Upgrade dependencies to versions where these warnings are solved

com.taoensso/nippy from 3.1.1 to 3.3.0
midje from 1.10.3 to 1.10.9

Codecov Report

Merging #352 (94e65e4) into develop (0f2c7a0) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 94e65e4 differs from pull request most recent head 27b38a1. Consider uploading reports for the commit 27b38a1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff            @@
##           develop      #352   +/-   ##
=========================================
  Coverage   99.839%   99.839%
=========================================
  Files           36        36
  Lines         3118      3118
  Branches         4         4
=========================================
  Hits          3113      3113
  Misses           1         1
  Partials         4         4


Add attribution/credits options to app

suggested by @allaway to possibly add credits to data curator app(s) should have a nod to the fact that all this infrastructure is thanks to the htan grant + people and have a message such as Supported by the Human Tumor Atlas Network (NCI grant number) Powered by Sage Bionetworks
Possible implementations

shinyDashboardPlus has a dashboardFooter
sticky footer https://stackoverflow.com/questions/37113739/shiny-dashboard-sticky-footer-in-dashboardsidebar

A follow on idea would be to add in a configurable field (from config.yml) to allow each community to also mention the community-specific funders (since they are funding us to build the schemas ;) )

Just to follow up on this --
I added a footer to ROCC's version of Data Curator using the following code:
app.R
 42   dashboardSidebar(
 43     width = 260,
 44     tags$style(
 45       ".left-side, .main-sidebar {padding-top: 80px; font-weight: bold; font-size: 1.1em }
 46        footer{position: absolute; padding: 18px; left:0; bottom: 0; width: 100%; background-color: #D0D6DC; color: #465362; font-size: 10px; z-index: 1000;}"
 47     ),
 ...
 ...
 56     HTML('<footer>
 57         Supported by the Human Tumor Atlas Network <br/>
 58         Powered by Sage Bionetworks
 59       </footer>')
 60   ),

Looks like this:

Still learning Shiny so if there is a cleaner way of adding CSS, please edit as you please!

added with #90


Added default method isFolder to Resource interface DAT-15388

Adding a new Resource interface method isFolder with a default implementation.  This will allow the S3Resource implementation to skip over folders that are returned during getAll.
Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

Closing this PR, as the solution can be handled completely in the S3 extension.


test fails after #260 merge

======================================================================
ERROR: test_chunks_bucket_one_reducer_per_object (main.TestPywren)
Traceback (most recent call last):
File "pywren_ibm_cloud/tests.py", line 383, in test_chunks_bucket_one_reducer_per_object
result = pw.get_result(futures)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 399, in get_result
WAIT_DUR_SEC=WAIT_DUR_SEC)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 357, in wait
raise e
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 341, in wait
THREADPOOL_SIZE=THREADPOOL_SIZE, WAIT_DUR_SEC=WAIT_DUR_SEC)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 86, in wait_storage
THREADPOOL_SIZE=THREADPOOL_SIZE)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 255, in _wait_storage
pool.map(get_result, f_to_wait_on)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 288, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 670, in get
raise self._value
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
return list(map(*args))
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 238, in get_result
f.result(throw_except=throw_except, internal_storage=internal_storage)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/future.py", line 241, in result
self.status(throw_except=throw_except, internal_storage=internal_storage)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/future.py", line 186, in status
reraise(*self._exception)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/six.py", line 695, in reraise
raise value.with_traceback(tb)
File "/action/pywren_ibm_cloud/wait/wait_storage.py", line 286, in _future_timeout_checker_thread
TypeError: 'NoneType' object is not subscriptable
======================================================================
ERROR: test_internal_executions (main.TestPywren)
Traceback (most recent call last):
File "pywren_ibm_cloud/tests.py", line 289, in test_internal_executions
result = pw.get_result()
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 399, in get_result
WAIT_DUR_SEC=WAIT_DUR_SEC)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 357, in wait
raise e
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/executor.py", line 341, in wait
THREADPOOL_SIZE=THREADPOOL_SIZE, WAIT_DUR_SEC=WAIT_DUR_SEC)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 86, in wait_storage
THREADPOOL_SIZE=THREADPOOL_SIZE)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 255, in _wait_storage
pool.map(get_result, f_to_wait_on)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 288, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 670, in get
raise self._value
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
return list(map(*args))
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/wait/wait_storage.py", line 238, in get_result
f.result(throw_except=throw_except, internal_storage=internal_storage)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/future.py", line 241, in result
self.status(throw_except=throw_except, internal_storage=internal_storage)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/pywren_ibm_cloud/future.py", line 186, in status
reraise(*self._exception)
File "/Users/gilv/.pyenv/versions/3.6.7/lib/python3.6/site-packages/six.py", line 695, in reraise
raise value.with_traceback(tb)
File "/action/pywren_ibm_cloud/runtime/function_handler/jobrunner.py", line 252, in run
File "pywren_ibm_cloud/tests.py", line 102, in pywren_inside_pywren_map_function
return pw.get_result()
File "/action/pywren_ibm_cloud/executor.py", line 399, in get_result
File "/action/pywren_ibm_cloud/executor.py", line 357, in wait
File "/action/pywren_ibm_cloud/executor.py", line 341, in wait
File "/action/pywren_ibm_cloud/wait/wait_storage.py", line 86, in wait_storage
File "/action/pywren_ibm_cloud/wait/wait_storage.py", line 255, in _wait_storage
File "/usr/local/lib/python3.6/multiprocessing/pool.py", line 266, in map
File "/usr/local/lib/python3.6/multiprocessing/pool.py", line 644, in get
File "/usr/local/lib/python3.6/multiprocessing/pool.py", line 119, in worker
File "/usr/local/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar
File "/action/pywren_ibm_cloud/wait/wait_storage.py", line 238, in get_result
File "/action/pywren_ibm_cloud/future.py", line 241, in result
File "/action/pywren_ibm_cloud/future.py", line 186, in status
File "/usr/local/lib/python3.6/site-packages/six.py", line 702, in reraise
File "/action/pywren_ibm_cloud/wait/wait_storage.py", line 286, in _future_timeout_checker_thread
TypeError: 'NoneType' object is not subscriptable

Ran 14 tests in 228.121s
FAILED (errors=2)
gilv1-mac:pywren-ibm-cloud gilv$
@JosepSampe can you check it please?

@gilv all tests run ok for me.  Did you update runtimes?

@JosepSampe nope...just used new code without update runtimes

@omerb01 we need to update the runtime.

@gilv @JosepSampe which Dockerfile should I need to use?

@omerb01 create new image...Docker file the same

Seems that even having the runtime updated, from sometimes this issue appears in 1 of each 20 pywren executions. #262 Fixes it.


Handle undefined metadata all over the app

Summary
Handle undefined metadata all over the app
This is an extension of https://github.com/mattermost/mattermost-mobile/pull/7243
Ticket Link
Partially fix https://mattermost.atlassian.net/browse/MM-51731
Release Note
Fix crash on markdown table images and prevents image related crashes on other parts of the app

I understand why this is being done, it would avoid a crash but in reality we should be finding the root cause for the metadata not being present.
I'm not a fan of this to be honest

@enahum Also, the root cause for some of these to happen (mainly the ones on markdown images) is mainly that the imagesMetadata exist, but not the imagesMetadata for that particular image. Why the imagesMetadata exist then? For example, the post has an attached image.

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-mobile
 + 492bc7593...b4260e65a amyblais-patch-1 -> upstream/amyblais-patch-1  (forced update)
   61010b836..720ac2207  main             -> upstream/main
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-mobile-#7244-upstream-release-2.3-1680248491
Switched to a new branch 'automated-cherry-pick-of-mattermost-mobile-#7244-upstream-release-2.3-1680248491'
Branch 'automated-cherry-pick-of-mattermost-mobile-#7244-upstream-release-2.3-1680248491' set up to track remote branch 'release-2.3' from 'upstream'.

+++ About to attempt cherry pick of PR #7244 with merge commit 720ac220704a49d878de633ef4a5efc77f44f88d.

*** Please tell me who you are.

Run

  git config --global user.email<EMAIL_ADDRESS>  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'mattermod@mattermod-6595fd9b49-wqnql.(none)')
!!! git cherry-pick failed

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

Cherry picked here: https://github.com/mattermost/mattermost-mobile/pull/7253


Fix Chart Height in mobile view

Description

added custom height for mobile and desktop view
fixed chart precision to avoid decimal places on Y-axis.

Screens

Fixes
This closes #5

@himankpathak Excellent work!


Panoramic view

How to make a panoramic view only?

Hi @Aruseli! Can you specify which maps API are you talking about?

@Aruseli You can do something like this to implement panorama

@mmarkelov great, thank you. That's what I need

@gribnoysup thank you, @mmarkelov gave me the answer

I'll open this one because I think we can add first class support for this API in the library 👍
@mmarkelov thank you as always! 🎉

@Aruseli @gribnoysup I just made example for new react-yandex-maps. I think we could make component for Panorama, but I'm not sure if it needed.
Panorama view v3

@mmarkelov @gribnoysup  That's a good idea. I think this component can be very useful to someone.

Released in v3.1.0, thanks @mmarkelov 🎉


PackageNot FoundError

I just create a simple pptx like this:
ppt = Presentation()
slide = ppt.slides.add_slide(ppt.slide_layouts[0])
ppt.save('test_presentation.pptx')
but appeared  such error:
pptx.exc.PackageNotFoundError: Package not found at 'C:\SoftWare\Python\Lib\site-packages\pptx\templates\default.pptx'
I uninstalled/installed pptx , even created a default.pptx and placed it to this dir  which couldn't resolve the issue. Do you have any idea for that?

I can't solve your problem but would observe you're usually better off basing the presentation off one of your own, rather than the default one.

I used my own one, but similar issue:
source = Presentation(source_ppt)
pptx.exc.PackageNotFoundError: Package not found at 'C:\iCode\iPython\PPTHandler\source.pptx'

That error can only appear when opening a file, not when saving it. So your description is off somehow.
This means the file is not a Zip archive or there is just no file by that name at that path.
This can happen if you try to open a legacy .ppt file which uses a different and incompatible format.

Yes,you are right. My file is not a Zip archive, its extension name is .pptx , though. It is not a valid .pptx. Thanks you comments very much!


bitrise-aws-device-farm-runner 0.0.8

What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @lautarochiarle,
There is step with the same name at https://github.com/bitrise-io/bitrise-steplib/tree/master/steps/aws-device-farm-runner with latest version of 0.0.7
Should this be an update to that step or you intended to create a new step?

hi @adborbas ,
thanks for your reply.
It is an update on that step ( https://github.com/bitrise-io/bitrise-steplib/tree/master/steps/aws-device-farm-runner ), his owner is not maintaining it any more... we can add him to this thread so we are all on the same page. His name is @fadookie

Yes, I asked lautarochiarle to make this new release himself after I merged his PR because I do not have time to maintain this step anymore and have not been able to find a new maintainer yet.

Thanks! We are discussing this change with the team. Will take some more time. 🚀

Hi @lautarochiarle,
We've come to a conclusion. Please reopen the PR as a new version to the original step https://github.com/bitrise-io/bitrise-steplib/tree/master/steps/aws-device-farm-runner.
Merging this PR would effectively create a new step which would lead to confusion as there is no need to create a new step, your intentions were only to change the maintainer of the step.

Hi all,
I've created a new PR:
https://github.com/bitrise-io/bitrise-steplib/pull/2597
Hope it works this time.
Regards,
[image: Flux IT] http://www.fluxit.com.ar/
www.fluxit.com.ar
*Lautaro Chiarle *
Solution Architect
<EMAIL_ADDRESS><EMAIL_ADDRESS>Camino Centenario #2565
La Plata / Buenos Aires / Argentina
(+54)<PHONE_NUMBER>0
El lun., 20 jul. 2020 a las 11:27, Eliot Lash<EMAIL_ADDRESS>escribió:

@fadookie commented on this pull request.
In steps/bitrise-aws-device-farm-runner/0.0.8/step.yml
https://github.com/bitrise-io/bitrise-steplib/pull/2590#discussion_r457436483
:

@@ -0,0 +1,234 @@
+title: Amazon Device Farm Runner
+summary: Amazon Device Farm Runner
+description: Deploys app to device farm and starts a test run. [Please see the wiki

for setup instructions](https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/wiki).
+website: https://github.com/lautarochiarle/bitrise-aws-device-farm-runner
+source_code_url: https://github.com/lautarochiarle/bitrise-aws-device-farm-runner
+support_url: https://github.com/lautarochiarle/bitrise-aws-device-farm-runner/issues
+published_at: 2020-07-15T15:51:27.398703558-03:00
+source:
git: https://github.com/lautarochiarle/bitrise-aws-device-farm-runner.git

sorry i thought i had submitted this review earlier but it was in
"pending" state.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bitrise-io/bitrise-steplib/pull/2590#discussion_r457436483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNZHRNPLIFFOZN4FXUS6ILR4RH4FANCNFSM4O24NM4A
.

Hi @lautarochiarle ,
We can pick up the topic at the new PR. You can go ahead and close this one.


Support advertise address and node address

This makes the engine-api changes to support
https://github.com/docker/docker/pull/24237.
AdvertiseAddr is added to InitRequest and JoinRequest so a node can
specify a different address to advertise than the one it binds to. This
allows scenarios with NAT to be supported, and also allows binding to a
wildcard address.
NodeAddr in Info allows Docker to expose a node's address.

LGTM

LGTM


[WIP] Feat/multiclass metrics

Describe your changes
Setting up model types to enable multiclass classification metric routing.
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have built basic tests for new functionality (particularly new evaluators)
[ ] If new libraries have been added, I have checked that readthedocs API documentation is constructed correctly
[ ] Will this be part of a major product update? If yes, please write one phrase about this update.

Extra-mile Checklist

[ ] I have thought expansively about edge cases and written tests for them

To do:

add multiclass classification metrics to list
Route a multiclass classification model (or dataset?) to the appropriate metrics

find_metrics has a metric_category attribute that we can probably use. We'd need a helper function to go from a list of artifacts -> metric category

better messaging if metrics fail

Questions:

How do we want to deal with models that we can't identify? For instance, if the model is non-sklearn we won't know what kind of classification it is.  Options:

We could update the type based on what we see in the dataset (there is a type_of_target function which could inform things). That may be a nice thing to do!
Classification type routes to binary classification and we have a good warning?

Completed update of MULTICLASS_CLASSIFICATION_FUNCTIONS
Created our own version for TPR, TNR

Merged into  feat/test_expansion 166d214841774c099de816fc4b963becd7cd1e52, we can close this.


Maintaining release versions and backporting fixes

c/f https://github.com/slsa-framework/slsa-verifier/pull/132
Version 1.0.0 required a fix after a Rekor change, and this backported fix needs to be added to older releases.
In order to support backports, we need to:

Create release branches for each release we cut
Determine how verification with tag/branch options will work.

If 2 branches (main and release-v1.0.0) are at the same commit, creating a release from release-v1.0.0 will trigger the workflow on the main branch. During verification, no need for --branch release-v1.0.0 and verification will pass

We can commit a changelog. wdyt?
For the e2e tests:

Possibly we need to enforce a policy that only the highest PATCH version be used in verification. If we do this, then we don't need to do any tag manipulation.

cc @laurentsimon

What do you mean by policy? Something only we would follow or also our users?

Users should also probably not use patch versions that have superseding ones, right? Otherwise we can't guarantee a good result.

Ho I see, you meant PATCH in each old release: yes I think that's a fair assumption. We don't have a good story around how we reach out to users in this case. I suppose our best bet would to create a vulnerability / OSV in this case?


Release Google.Cloud.Metastore.V1 version 2.1.0

Changes in this release:
New features

Added federation API (commit 31c802d)
Added EncryptionConfig field (commit 31c802d)
Added NetworkConfig field (commit 31c802d)
Added DatabaseType field (commit 31c802d)
Added TelemetryConfiguration field (commit 31c802d)

Created release for Google.Cloud.Metastore.V1-2.1.0


IndexError: index 732 is out of bounds for axis 0 with size 512

您好，这个是说训练集的坐标有问题吗？
@princewang1994

@princewang1994 Could you share the ignore.list for TotalText? Seems it missing in the git repository..

@LearnerInGithub, ignore.list is removed in the latest version of this code because I fixed some bugs in the data loading process. Please just set ignore_list=None.


Please upgrade to .net 6

I have problems with this package in all my projects because it requires .net 5

You can use the current 5.0 package and do the following:
In your Program.cs add builder.Services.AddCloudscribePagination();.
And for handling bootstrap 5 add the following to your view:
 cs-pager-link-other-class="page-link" cs-pager-li-other-class="page-item"  cs-pager-link-current-class="page-link" and modified the active item class as follows:  cs-pager-li-current-class="page-item active"

I can run it in .net6 but I have issues when I publish the project with the option "Enbale ReadyToRun Compilation".
If I select this option It also requires .net5 on the server because I used this component. Otherwise it will not run.

Any updates? NET 5 is out of support now.

@simonech @HolyOne @zulq this has been released for .NET 6. Hope this helps!


pipeline=marker

I see that you can select oil and gas infrastructure on the OIM, so that gas pipelines, for example, become visible. Is it possible to display the visible markers on the surface, which are mapped with pipeline=marker, on this layer? There you will also find tags with the references to the pipeline name and operator.

This is a duplicate of #32 - I will get round to it eventually!

@lufticus I agree on displaying marker positions on OIM.
Please note pipeline=marker is now discouraged and replaced by marker=* + utility=*
All the best