Use categoricalarrays 6.0

They released it 2 weeks ago with a number of fixes including the annoying  `T` is deprecated, use `nonmissingtype` instead.; should we start using it?
it seems the issues you had are:

https://github.com/JuliaData/CategoricalArrays.jl/issues/129 --> no longer relevant as per your message
https://github.com/JuliaData/CategoricalArrays.jl/issues/180 --> no longer relevant as per your message?
https://github.com/JuliaData/CategoricalArrays.jl/issues/199 --> maybe still relevant, not sure? if relevant maybe we should provide a PR to speed things up?

Thanks for that.
Yes the first two are resolved but unfortunately the last is not and it is a pretty serious issue (I would say a bug) without a straightforward workaround. @nalimilan has formulated a plan to resolve the issue, but as this looks fairly low-level, I don't think it would be efficient for us to make our own PR.
I agree this is annoying. Apart from the warning, having a cap on the version causes people not familiar with the package manager some pain in updating MLJ.

Sorry, I haven't fixed that yet since an efficient solution requires a bit of work. But maybe we can go with the inefficient solution for now. Can you confirm that this branch fixes the problems you encounter?

@nalimilan Thank you so much for looking into this!
Some things are now working. However, I'm having some issues with valindex behaviour. Probably I shouldn't be using it (ie should regard it as private) but it is convenient to do so. Still, I'm reporting this, in case it really is a bug.
Under CategoricalArrays 0.5.2 the following code throws no error. However, an error is thrown on nl/setindex! branch, unless you do relabelling a <-> b and A <-> B:
using CategoricalArrays

y = categorical(["B", "A"])
b = y[1]
a = y[2]

z = [b, a]

@assert y[1].pool.valindex == z[1].pool.valindex "something unexpected"

OK, good to know. I'll try to add tests and turn this into a proper PR then.
Regarding the valindex issue, indeed there's absolutely no guaranty that the index and valindex fields will match (at least currently, I might drop the levels/index distinction if we no longer need it for e.g. CSV.jl since it confuses many people). You always need to go through order(pool) as noted here. The fact that it worked in 0.5.2 is just due to [b, a] returning an Array in that version.

See https://github.com/JuliaData/CategoricalArrays.jl/pull/211.

Resolved in MLJBase 0.7.0


Add prompt to rollback if pixi add fails

Problem description
pixi add tes
  × failed to solve the conda requirements of 'default' 'linux-64'
  ╰─▶ Cannot solve the request because of: No candidates were found for tes *.

It would be nice to have a prompt at the end asking something like: "Resolution failed, rollback changes to pyproject.toml?: (Y/n)"
As tes = "*" gets added to pyproject.toml even though it was an invalid command. I think in most cases, we don't want to make changes if the add command failed due to typo or incompatibility.
For simple add commands, it may be easy enough to just go edit the file yourself, but adding something like "-f dev --pypi package[opt]" may make the changes more annoying to rollback manually.

Hey @Squirreljetpack, we were just discussing this here: https://github.com/prefix-dev/pixi/issues/2516 Feel free to join in there. I'll close this issue as duplicate.


Update to continue from "new CI/CD flow" in "Continuous deployment improvements"

This page is linked to as the next steps from the Automate publishing for continuous integration and delivery page. However, it seems to only pick up after what is referred to in that page as the "Current CI/CD flow," in which an adf_publish branch is required (and feels a little clunky from a developer experience).
The "new CI/CD flow" described in that page is a huge step towards a healthy DevOps ecosystem. To help DevOps engineers build that system in their own applications, either that page should include steps for a release pipeline or this one should.
Also, this has been mentioned before, but yaml-based deployments are generally considered better practice over classic release pipelines. This is for the same reason that Azure Data Factory has git integration available as a feature: we want to establish source control as the definitive source of truth. This is true for our applications as well as the instructions we use to deliver them.
This a minimalized version of the setup I have and it's working quite well:
build.yml
stages:
  - stage: Build
    jobs:
      - job: export_adf_resources
        pool:
          vmImage: ubuntu-22.04
        variables:
          factoryId: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroupName/providers/Microsoft.DataFactory/factories/factoryName
        steps:
          - task: NodeTool@0
            displayName: Install Node
            inputs:
              versionSpec: 18.x
          - task: Npm@1
            displayName: npm ci
            inputs:
              command: ci
              workingDir: $(Build.SourcesDirectory)
          - task: Npm@1
            displayName: validate
            inputs:
              command: custom
              customCommand: run build validate ./resources/ $(factoryId)
              workingDir: $(Build.SourcesDirectory)
          - task: Npm@1
            displayName: export
            inputs:
              command: custom
              customCommand: run build-preview export ./resources/ $(factoryId) ./export
              workingDir: $(Build.SourcesDirectory)
          - publish: $(Build.SourcesDirectory)/export
            artifact: adf-resources

deploy.yml
parameters:
  environment: ""
  dependsOn: Build
  azureResourceManagerConnection: ""
  resourceGroupName: ""
  factoryName: ""
  subscriptionId: ""
  location: ""

stages:
  - stage: ${{ parameters.environment }}
    dependsOn: ${{ parameters.dependsOn }}
    jobs:
      - deployment: deploy_azure_data_factory
        environment: ${{ parameters.environment }}
        pool:
          vmImage: ubuntu-22.04
        strategy:
          runOnce:
            deploy:
              steps:
                - task: AzurePowerShell@5
                  displayName: ADF pre-deployment
                  inputs:
                    azureSubscription: ${{ parameters.azureResourceManagerConnection }}
                    ScriptType: FilePath
                    ScriptPath: $(Pipeline.Workspace)/adf-resources/PrePostDeploymentScript.ps1
                    ScriptArguments: >
                      -ArmTemplate $(Pipeline.Workspace)/adf-resources/ARMTemplateForFactory.json
                      -ResourceGroupName ${{ parameters.resourceGroupName }}
                      -DataFactoryName ${{ parameters.factoryName }}
                    azurePowerShellVersion: LatestVersion
                - task: AzureResourceManagerTemplateDeployment@3
                  displayName: Deploy ADF Resources
                  inputs:
                    deploymentScope: Resource Group
                    azureResourceManagerConnection: ${{ parameters.azureResourceManagerConnection }}
                    subscriptionId: ${{ parameters.subscriptionId }}
                    action: Create Or Update Resource Group
                    resourceGroupName: ${{ parameters.resourceGroupName }}
                    location: ${{ parameters.location }}
                    templateLocation: Linked artifact
                    csmFile: $(Pipeline.Workspace)/adf-resources/ARMTemplateForFactory.json
                    overrideParameters: >
                      -factoryName ${{ parameters.factoryName }}
                    deploymentMode: Incremental
                - task: AzurePowerShell@5
                  displayName: ADF post-deployment
                  inputs:
                    azureSubscription: ${{ parameters.azureResourceManagerConnection }}
                    ScriptType: FilePath
                    ScriptPath: $(Pipeline.Workspace)/adf-resources/PrePostDeploymentScript.ps1
                    ScriptArguments: >
                      -ArmTemplate $(Pipeline.Workspace)/adf-resources/ARMTemplateForFactory.json
                      -ResourceGroupName ${{ parameters.resourceGroupName }}
                      -DataFactoryName ${{ parameters.factoryName }}
                      -PreDeployment $false
                    azurePowerShellVersion: LatestVersion

ci-cd.yml
trigger:
  - main

stages:
  - template: ./build.yml
  - template: ./deploy.yml
    parameters:
      environment: Test
      azureResourceManagerConnection: Contoso Test (12345678-9012-3456-7890-123456789012)
      resourceGroupName: rg-contoso-test
      factoryName: adf-contoso-test
      subscriptionId: 12345678-9012-3456-7890-123456789012
      location: France Central
  - template: ./deploy.yml
    parameters:
      environment: Production
      dependsOn: Test
      azureResourceManagerConnection: Contoso Production (21098765-4321-0987-6543-210987654321)
      resourceGroupName: rg-contoso-prod
      factoryName: adf-contoso-prod
      subscriptionId: 21098765-4321-0987-6543-210987654321
      location: France Central

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d185ba52-7285-4ba3-abd8-06a76ee8f6dc
Version Independent ID: 6cbe707a-5031-2b63-e950-ea5456d58bb4
Content: Automate continuous integration - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-delivery-automate-azure-pipelines.md
Service: data-factory
Sub-service: ci-cd
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@melody-universe
Thanks for your feedback! We will investigate and update as appropriate.

@melody-universe
I've delegated this to @nabhishek, a content author, to review and share their valuable insights.

Thanks for your question @melody-univerrse. Since this issue is not related directly to the doc itself but regards a specific scenario, I would recommend you create a thread on the forums - Microsoft Q&A or Stack Overflow.
I will close the issue out for now but we can continue the discussion here on this thread if necessary, even after it is closed.
#please-close


Fixes: Transforming a comma only array to an empty array fails

Ok, I realized my mistake on the previous PR (#12), this new code will match modern browser behavior in IE8 by replacing empty array elements with explicit undefined. Using void 0 instead of undefined to guarantee the value doesn't change (Undefined can be reassigned). Handles the case of multiple trailing commas correctly (replace all with undefined except for the last one which is discarded.)
thanks

[,,] is still slightly different from [undefined, undefined] -- in the former, the keys are not set at all (and '0' in arr would be false) and in the latter, they are set to undefined. I'm not going to merge a transformation to undefined but if it's working for you, please continue using it!


Typos: Self intro breakdown does not match original

TLDR: Two small typos on the /self-introduction/ page. Under "Example 1: ..." 30,000 should be changed to 40,000, and under "Example 2: ..." 4 should be changed to 3.
On this page https://www.techinterviewhandbook.org/self-introduction/:
Under "Example 1: Front End Engineer at Meta", the quote above "Mention something about the project which stands out.". The text reads
 "It receives over a million pageviews a month and is used by over 30,000 NUS undergraduates and even some professors."
But in the "Self Introduction" it says:
 "It receives over a million pageviews a month and is used by over 40,000 NUS students and even some professors."
I also something similar under "Example 2: Front End Engineer at Lyft", the text above "Acknowledge that you work with others. ..." reads:
"I built the project with another engineer over the period of 4 months on a React/Redux and Golang stack."
But the "Self Introduction" says:
"I built the project with another engineer over the period of 3 months on a React/Redux and Golang stack."

I have made a PR with your recommended typo updates, #632.


onScroll event propagation

So, since React bubbles all its events, even the ones that the browser doesn't bubble by default, there is some weird behaviour with onScroll event.
Example: https://codesandbox.io/s/httpsgithubcomreactjsrfcsissues175-viizc
onScroll callback on Parent element is fired when Children element is scrolled.
Why this is weird and might lead to unexpected bugs? Imagine following situation:

You have some scrollable component A where you are doing something when onScroll fires
Then somebody introduces another scrollable component B as a children of your component
When B is scrolled your onScroll handler on component A is also fired.
To mitigate this you need to add some checks like this one: e.target === e.currentTarget

Basically it means that you need to add this check every time you add onScroll to any element because you can not be sure that nothing scrollable will be introduced down the tree later.
I think there are more events like this, for example onSubmit, but at least you can't put <form> inside another <form>.
It might be worth to reconsider event bubbling in the future.
Issue discussion https://github.com/facebook/react/issues/15723

If you'd like to file an RFC, please send a pull request.

@O4epegb Yes this is indeed weird behavior. React also bubbles blur and focus, which requires the same mitigation strategy. These are old decisions in the early versions of ReactDOM, which makes it difficult to change the behavior of those event props going forward (as there is no straight-forward way to deprecate the existing behavior for a period of time). It's also difficult to automatically analyze code for dependencies on the non-standard behavior, and most apps will not have automated test coverage to catch UX/a11y regressions if the behavior changes.
Something a few of us (not the core team) have been working on is a new ReactDOM event API that's independent of the existing event props. This allows us to have a fresh start and undo some of these decisions. In the meantime, I think your mitigation strategy (or calling stopPropagation) is a suitable work-around.

There's also media events that all have the same problem.

I would not call it a problem.
You are getting an ability to observe more events, having an ability to understand should you react or not to those events as well.
The only real problem with even bubbling are portals, where user ability to understand a location of the event (one could traverse from target to currentTarget) is broken - https://github.com/facebook/react/issues/14540

It seems like that behaviour gonna be fixed in v 17.
https://github.com/facebook/react/pull/19464
Should we close this issue now?


Update Microsoft.Azure.KeyVault package version

@muratg

:shipit:

Wait wait wait, we'll need this in 1.1.1, so I'm re-opening the bug.


Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window.a…

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[x] Appropriate comments and documentation strings in the code.
[x] Has sufficient logging.
[x] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[x] Test plan is updated as appropriate.
[x] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[x] The wiki is updated with any design decisions/details.

When the user selects a compute instance as a remote jupyter connection and then reloads the window, the user will see the name of the compute instance in the jupyter info toolbar along with the disconnected icon.

Codecov Report

Merging #13600 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13600      +/-   ##
==========================================
+ Coverage   59.73%   59.75%   +0.01%
==========================================
  Files         670      670
  Lines       37434    37513      +79
  Branches     5373     5388      +15
==========================================
+ Hits        22362    22415      +53
- Misses      13908    13929      +21
- Partials     1164     1169       +5

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

...rc/client/datascience/commands/notebookCommands.ts
18.18% <0.00%> (-4.68%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

...ient/datascience/interactive-ipynb/nativeEditor.ts
7.86% <0.00%> (-0.11%)
:arrow_down:

src/client/common/types.ts
100.00% <0.00%> (ø)

src/client/datascience/types.ts
100.00% <0.00%> (ø)

src/client/telemetry/constants.ts
100.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f59b0e...f32d07f. Read the comment docs.


Update firebase hosting deployment.

Addresses https://github.com/GoogleContainerTools/kpt/issues/1489

I want to confirm something. If any step fails in the generation and deployment, the site continue to serve the previous good site, right?

I want to confirm something. If any step fails in the generation and deployment, the site continue to serve the previous good site, right?

That's correct, the previous version of the site stays live if the deployment (or site generation) fails


[UPDATE] Deletion screen

Please update the vault deletion screen to reflect figma. Change Vault Type to Vault Part , so user knows what part he is deleting:

QA done.
@yevhen1sec just a thought, can we cache the balance somewhere that it does not take a lot of time to load after opening screen?

@realpaaao sure, we can do that, let's raise an issue


After finetune, there is an action gap during inference on my own dataset.

Hi,
Thank you for your outstanding work.
As the title suggests, my fine-tuning results are poor. When inferring using the training dataset, there is a significant difference between the results and the action labels. I did not modify the fine-tuning code, and during inference, I adhered to the input format for images and used the same resizing method as the official one. I also mapped the action outputs to the range of actions in my dataset using q01 and q99 for un-normalization. During fine-tuning, I did not use image augmentation, and my action accuracy reached 1. I am quite puzzled about where the problem lies.
here an example ,
infer result: [1.23738531e-03  2.06876544e-03  4.49192716e-03 -4.82013702e-04 -8.72295174e-03  1.81586735e-03  9.98400000e+02]
label: [7.24270521e-03 -2.33919453e-03 -1.92745328e-02 -7.46141002e-03 4.27616847e-04  1.58309005e-02  3.42000000e+02]

Hi @HanwenWangBUPT,
That is indeed strange. If you observe 100% train accuracy and run model inference on training samples, you should observe perfect predictions that match the labels.
It's hard for us to help debug without more information, but as a debugging step, it may help to try overfitting to a single sample (literally one datapoint) and seeing if you can even predict the action tokens correctly for this one sample. Then try it again with five samples. After you pass these tests, you can proceed with your original dataset.

Moo Jin


DioEventProcessor: Append http response body

:scroll: Description

Append http response bodies in DioEventProcessor if allowed by options

:bulb: Motivation and Context

Relates to #624
:green_heart: How did you test it?
Added tests
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

Also pointed this against the release/8.0.0 branch.

Also pointed this against the release/8.0.0 branch.

@denrase this feature is opt-in, no need for being part of v8, or is there any breaking change?


Investigate alternatives to Celery for asyncio support

We've been investigating missing support for asyncio in Celery #21, it would also make sense to investigate alternative projects that provide queues for Python projects.
Celery is very mature, and provides both queues and scheduled tasks, however async support has been long coming. Anomaly has offered to sponsor the development of asyncio support for Celery but the conversation has not progressed.
There are other projects like aiotasks which are inspired by the same design concepts as Celery, they may have made more progress on the async part at the risk of losing features like celery beat

Also see:

https://python-rq.org
https://github.com/Attumm/meesee
https://github.com/alttch/atasker

Possibly irrelevant with Celery confirming 6.0.0 release will have asyncio support and #21 now has a workaround


wire rootmail dns delegation targets asynchronously in pipeline

wire root domain once the nameserver delegation targets are set
this has to done asynchronously since the superwerker setup waits for it
so it cannot be done as part of the pipeline
fixes #64

merging to make pipeline green again


Fix LSN in keepalive messages, if no WAL has been sent yet

When a new connection is established to the safekeeper, the 'end_pos' field is initially set to Lsn::INVALID (i.e 0/0). If there is no WAL to send to the client, we send KeepAlive messages with Lsn::INVALID. That confuses the pageserver: it thinks that safekeeper is lagging very much behind the tip of the branch, and will reconnect to a different safekeeper. Then the same thing happens with the new safekeeper, until some WAL is streamed which sets 'end_pos' to a valid value.
To fix, use 'start_pos' rather than 'end_pos' in the keepalive messages. When the safekeeper has sent all the WAL it has available, they are equal. When the safekeeper has some WAL to send, it will send an XLogData message rather than KeepAlive. If it did send a KeepAlive even when there was some WAL to send too, I think 'start_pos' was a more correct value anyway.
Fixes https://github.com/neondatabase/neon/issues/3972

I had second thoughts on my earlier fix. Using 'start_pos' in the KeepAlive message isn't quite right, if we ever sent a KeepAlive message when start_pos != end_pos. We don't, so we could just add a comment to explain it. But on second thoughts, I think a better fix is to initialize end_pos to the starting position, when the streaming starts. I updated this PR to do that instead. Please take another look.

I think WalSndKeepAlive::sent_ptr is a misleading name, it should be called wal_end, the same as in rust-postgres client.

Agreed. Let's fix that as a separate PR.

This was superseded by PR #4144, closing.


fix(csharp/src/Apache.Arrow.Adbc/C): do not set a default value for table types

DuckDB throws an error if the tableTypes are set. This fix replaces setting the default values and leaving it as null.

Closed as duplicate


[ignition] Delete unused patches.

Deletes unused patches left over from last update.

Please upgrade the port version, thanks.


ci: We don't need ssh for commitish_override anymore

Towards b/371220760

This is trivial, I'm self-merging.


set api called 20+ times if 2 channel names are the same

If you have 2 channels with the same name, the set api will flip flop between the ordering of the 2 channels and call itself many times. It stops after 30 times or so, but will happen each time things are changed.
the 2 names would flip in ordering on each call

Closing, doesn't seem to happen with the new wallet API.


Q5.Image() has problems with a Source Rectangle

Hey Ling,
Absolutely amazing project this is. I've been using Q5 in my own project because it's incredible. When creating a loading bar I ran into a strange issue that seemed related to Q5. Q5.Image() does not (properly) handle the source parameters in the way that P5 does.
The package configuration of my project contains Q5XJS ^0.0.5 and P5 ^1.4.0. I've reproduced this issue with the latest version of this repo too.
The image should load in from left to right. When using this code on Q5XJS it seems to stretch the image instead. I've provided code that you can run within the P5 Web Editor.
let img;
let start = Date.now();

function setup() {
  createCanvas(400, 400);
  img = loadImage('https://i.imgur.com/FjTgVcE.jpeg');
}

function draw() {
  background(220);

  let progress = (Date.now() - start) / 1000.0 % 1;

  let loadingbarPosition = {
     x: 0,
     y: 0
  };

  let loadingbarSize = {
     width: 128,
     height: 128
  }

 if(img) image(
    img,
    loadingbarPosition.x,
    loadingbarPosition.y,
    loadingbarSize.width  * progress,
    loadingbarSize.height,
    0, // sx
    0, // sy
    img.width * progress, // sw
    img.height // sh
  );
}

This issue is due to an unintended (bug?) of Javascript comparisons.
if (!sx){ returns true when 'sx' == 0.
The solution is to simply replace if(!sx) with if(sx == undefined).


Remove all gogoproto extensions

This commit removes the following gogoproto extensions;

gogoproto.nullable
gogoproto.customename
gogoproto.unmarshaller_all
gogoproto.stringer_all
gogoproto.sizer_all
gogoproto.marshaler_all
gogoproto.goproto_unregonized_all
gogoproto.goproto_stringer_all
gogoproto.goproto_getters_all

None of them are supported by Google's toolchain (see #6564).
Signed-off-by: Kazuyoshi Kato<EMAIL_ADDRESS>

#6827 has been merged. Do we need to rerun the protobuild?

The change needs to notify the user who using proxy snapshot about the API change. I added the label


Fix running plugins with bad-er world name

This is a redo of #107, which was reverted in #110.
It now also covers the use case where the worldNames property is not set.

I think there might still be a problem. I see this error:
[GUI] [Wrn] [WorldControl.cc:173] Ignoring topic [/world/simple_cave_01/stats], world name different from []. Fix or remove your <stats_topic> tag.
Topic [/world//stats] is not valid.
[GUI] [Err] [WorldControl.cc:191] Failed to subscribe to [/world//stats]

I see this error:

Thanks, you found the one case that I didn't test :see_no_evil: Fixed: 4bfc316c01a40abb194fed3964f8a441f314bdf8


WOPI App Name is admin configurable, but we hardcoded it

The collaboration service uses the hardcoded strings collabora and onlyoffice to identify the kind of CS3 app provider.
For the app url:
https://github.com/owncloud/ocis/blob/fde6b4cbce3dacae741440b2ea3f6284d06bf719/services/collaboration/pkg/service/grpc/v0/service.go#L163-L166
For the language:
https://github.com/owncloud/ocis/blob/fde6b4cbce3dacae741440b2ea3f6284d06bf719/services/collaboration/pkg/service/grpc/v0/service.go#L251-L255
The type determines the properties returned in the GetFileInfo call:
https://github.com/owncloud/ocis/blob/fde6b4cbce3dacae741440b2ea3f6284d06bf719/services/collaboration/pkg/connector/fileconnector.go#L1150-L1157
We noticed this when reviewing https://github.com/cs3org/reva/pull/4882#pullrequestreview-2369537426
All of these checks will break when the app name has been changed to eg: WebOffice.
The app Name really is a display name that is used by clients. We should introduce a product property on the cs3 api that we can use to handle product specific differences.

cc @micbar

https://github.com/owncloud/ocis/pull/10335 should do for the most part. We still need to send the provider to reva in order to use the templates.
The easiest option might be to send it during app registration (https://github.com/owncloud/ocis/blob/master/services/collaboration/pkg/helpers/registration.go#L64C26-L71), but we'd need to change the cs3apis.
Since the names can change, we'll need to take care of weird chars. Right now, it seems that there is a problem if the App.Name contains a space (web shows the name with the space correctly):
ocis-1           | {"level":"error","service":"gateway","pkg":"rgrpc","traceid":"9d09077404f9a5d7b9439dfa75eea898","user-agent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0","from":"tcp://<IP_ADDRESS>:46954","uri":"/cs3.gateway.v1beta1.GatewayAPI/OpenInApp","start":"17/Oct/2024:09:03:32 +0000","end":"17/Oct/2024:09:03:32 +0000","time_ns":3028322,"code":"Unknown","time":"2024-10-17T09:03:32Z","message":"gateway: error calling findAppProvider: error: not found: app 'Colla%20Bora' not found"}
ocis-1           | {"level":"error","service":"frontend","pkg":"rhttp","traceid":"89ad0050261880f7a41e38115f9390c9","request-id":"ba3dcabb-95c4-46e1-943d-8a7194f64531","error":"rpc error: code = Unknown desc = gateway: error calling findAppProvider: error: not found: app 'Colla%20Bora' not found","time":"2024-10-17T09:03:32Z","message":"Error contacting the requested application, please use a different one or try again later"}
ocis-1           | {"level":"error","service":"frontend","pkg":"rhttp","traceid":"89ad0050261880f7a41e38115f9390c9","host":"<IP_ADDRESS>","method":"POST","uri":"/app/open?file_id=79788a3d-c825-4287-983e-da76f535b8a8%24744811fc-08de-468a-9caf-b25a792faa28%219f5ba531-b6ba-4aa5-93a8-64431614fce5&lang=en&app_name=Colla%2520Bora&view_mode=write","url":"/open?file_id=79788a3d-c825-4287-983e-da76f535b8a8%24744811fc-08de-468a-9caf-b25a792faa28%219f5ba531-b6ba-4aa5-93a8-64431614fce5&lang=en&app_name=Colla%2520Bora&view_mode=write","proto":"HTTP/1.1","status":500,"size":134,"start":"17/Oct/2024:09:03:32 +0000","end":"17/Oct/2024:09:03:32 +0000","time_ns":17015094,"time":"2024-10-17T09:03:32Z","message":"http"}

There could also be problems with the service names (https://github.com/owncloud/ocis/blob/master/services/collaboration/pkg/helpers/registration.go#L69 among others) if the name contains "." or weird chars. We should decide what to do with those.
Finally, this seems a breaking change for Microsoft and OnlyOffice installations (we're using Collabora as default, so they're lucky they won't be hit). If you're using OnlyOffice as app name, Collabora will be used as provider name (assuming you haven't changed it yet), so some features are expected to break. Adding the env variable and restarting the system should be enough to fix the problem though.

Next step: Start PR on the CS3API to add the ProductName Property on the app.

@micbar There are a lot of changes in a go-sc3 https://github.com/cs3org/go-cs3apis/compare/062c4e3046cb..d50e291
Are we still compatible?
Should we bump go-cs3api?

I prepared the cs3api bump for reva https://github.com/cs3org/reva/pull/4906
I don't see any braking changes cs3api.

@micbar @kobergj  The cs3api PR
https://github.com/cs3org/cs3apis/pull/237

PR has been merged #10335

I struggle to use it: https://github.com/owncloud/ocis-charts/pull/799#issuecomment-2461526621


pictures are being duplicated

started using the addon and when i add 1 pircture and it syncs with anki, when i view the answer of X question is shows the same picture twice.

Fixed in 3dfcd5efb42b5894d11991d3cfdb89bbfa183359
Tested add to prevent usecase from recurring.
Test also added to ensure that multiple images are treated correctly


feat(appengine): Move new helloworld sample out of preview

Goals of this PR:

Move new helloworld sample from preview to the main folder.
Move old helloworld sample into a new legacy folder -- we want to preserve this sample for folks who don't want to use Go 1.18 and above.
Explain the difference in a readme. I'm open to suggestions on the wording there.

GCP's docs already point to the appengine_flexible/helloworld folder, so they will immediately point to the new sample once this is in place.

So, after all this work, our team ended up not wanting to do the change this way. I'll send a different PR to re-attempt this. Sorry for the confusion.


Skipping error checks for json.Encoder.Encode or json.MarshalIndent is not safe

$ cat t.go
package main

import (
	"encoding/json"
	"os"
)

type Foo struct {
	X string
}

func main() {
	err := json.NewEncoder(os.Stdout).Encode(Foo{"bar"})
	if err != nil {
		panic("meh")
	}
}
$ ./errchkjson t.go
t.go:13:9: Error return value of `(*encoding/json.Encoder).Encode` is checked but passed argument is safe
$ ./errchkjson -V
errchkjson version 0.2.3
commit: 3aae21891fb6867e0ae247403f8eb67c0573c5d5
built at: 2022-02-08T16:17:38Z
module version: v0.2.3, checksum: h1:97eGTmR/w0paL2SwfRPI1jaAZHaH/fXnxWTw2eEIqE0=
goos: linux
goarch: amd64

json.Encoder.Encode can return an error due to a number of reasons unrelated to the argument's general JSON marshal safety:

https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/stream.go;l=202
https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/stream.go;l=225
https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/stream.go;l=231

The same applies to json.MarshalIndent:

https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/encode.go;l=181

I think errchkjson should not encourage skipping error checks for these functions at all.
(Haven't thought through if there are other messages in errchkjson that should be adjusted due to these considerations, but I suspect there might be some.)

@scop I guess, you are right. I started with json.Marshal only and later extended it to json.MarshalIndent and json.Encoder.Encode. While doing so, I did not properly check for all the potential error cases.
I will have a look at this.

I just looked again at the json.MarshalIndent case and I think it is save to keep this case for the following reason:
While it is true, that json.MarshalIndent might in theory return an error on https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/encode.go;l=181, I don't think, this will ever happen, because json.Indent only returns an error, if the scanning of the passed JSON returns an error. Such an error would imply, that json.Marshal did produce invalid JSON, which would be an error in the JSON encoding of the standard library.

https://cs.opensource.google/go/go/+/refs/tags/go1.17.6:src/encoding/json/scanner.go;l=181;drc=refs%2Ftags%2Fgo1.17.6 is arguably a (pathological) case where scanning the json.Marshal generated, valid JSON could result in an error while indenting. (Caveat: haven't checked if json.Marshal could actually produce such output.)
Ignoring that, I guess the call on this boils down to how much one is ready to rely on the internals of the function in question, and that it won't start to actually return errors -- changes in this area aren't necessarily breaking ones and could conceivably occur within Go 1.x series. Then again, I suppose the same could be said about treating any JSON marshalling operations as safe... but it's good that this part of the linter's functionality is user controllable. And IMHO it's good that suggesting omitting error handling is off by default in golangci-lint, even though it's enabled by default in plain errchkjson.


Not getting refresh_token and "Unsupported grant type: password"

Hi, two things.
I am executing the following curl command:
curl -X POST -u curl-client:client-secret http://localhost:8081/oauth/token -H "Accept: application/json" -d "password=user&username=user&grant_type=client_credentials&scope=read%20write&client_secret=client-secret&client_id=curl-client"
and I am getting the following response without the refresh_token
{"access_token":"c42ee640-44d1-4217-a608-6eaeb1ce9f14","token_type":"bearer","expires_in":4186,"scope":"read write"}
I have changed the client in the admin UI to support password, refresh_token and client_credentials, but the refresh token is not being retrieve. Also, it only works with grant_type=client_credentials, grant_type=password does not work.
Any ideas?

Fixed.

??

Sorry just got around to look at this now. What was the problem? I haven't tried refresh tokens yet.


Ability to set the timeout period or retry count on a DO

Is your feature request related to a problem? Please describe.
I'm sending DO declarations via Big-IQ. If I send DO with a clear and obvious error (incorrect Big-IP password for example), the server side takes at least 15 minutes to stop its retry loop. See below, a retry count of 350+ that decrements every 5 seconds.
Thu, 12 May 2022 10:04:05 GMT - finest: [f5-declarative-onboarding: restWorker.js] tryUntil: got error undefined
Thu, 12 May 2022 10:04:05 GMT - finest: [f5-declarative-onboarding: restWorker.js] typeof err undefined
Thu, 12 May 2022 10:04:05 GMT - finer: [f5-declarative-onboarding: restWorker.js] tryUntil error:  tries left: 352
Thu, 12 May 2022 10:04:05 GMT - finest: [f5-declarative-onboarding: restWorker.js] tryUntil: retryOrReject: numRemaining: 352
Describe the solution you'd like
A clear and concise description of what you want to happen.
I'd like to be able to control either the timeout or retry count in the declaration as waiting 15 minutes for a result is too slow.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None
Additional context
Add any other context, such as the desired tmsh configuration, about the feature request here.
Deploying via Big-IQ

Thank you for your feedback. Unfortunately, making that value configurable by the user would be difficult since it is reused for many DO actions. Some of those actions will require longer retries while DO is waiting for configuration changes to apply on the BIG-IP.
However, we can look into making DO fail faster in the case where the BIG-IP password is incorrect. Would you like me to update your request to match this solution?

Thanks for the reply @dstokesf5  - yes please, that would definitely be a help

I have added AUTOTOOL-337 to our internal product backlog to fail quickly in this case instead of retrying with a bad password.


Default escaping in Fields, attempt 2

Make field output like {{ record.title }} behave like we'd expect:

"semantically pretty" as {{ record.title }} outputs HTML for fields where it makes sense ('html', 'markdown', 'textarea')
Add allow_markup flag to overrule the default behaviour in contenttypes.yml,
use standard |raw and |e methods to Content for fine-grained control in output.
Additionally, the PR adds a new way to preset records to be added, which is convenient for our automated tests.
No hack needed to change the default or current autoescape: false.

See discussion in #351
This PR is less hackish than #353, but does the same thing basically.

"semantically pretty" as {{ record.title }} outputs HTML for fields where it makes sense ('html', 'markdown', 'textarea')

I disagree that textarea should output raw html by default.

Thanks for review, @JarJak 👍


can i use custom swagger-ui?

Hi, can i use custom swagger-ui like on https://github.com/jensoleg/swagger-ui ?
It has better ui than the default

Yes. Any Swagger compatible UI pointing to docsPath (default /docs) will work. We could make the require.resolve('swagger-ui') in https://github.com/feathersjs/feathers-swagger/blob/master/src/index.js#L57 configurable (config.uiPackage defaulting to swagger-ui) so it could work the same as using the default UI.
Pull request welcome!

I'm sorry, i just end up serving static doc using flatdoc,
i realize it more fast to write the doc using markdown than learning the swagger format

We'll leave it at that then.

Could be great to make it configurable to use this Swagger explorer instead of default swagger ui !


Issue/build master investigate test server recompile (#7208)

Pull request opened by the merge tool on behalf of #7208

Merged into branches iso7 in 79127280cf3e18f4f71732afa36fb16aeabf3588


Allow to use beta-version of typescript

This change allow to use tslint in projects, which uses beta-version of typescript

@Strate Our next branch of TSLint is designed for the dev versions of TypeScript! We publish it on NPM as well, you can get the most recent one with npm install tslint@next.

@JKillian from the reader : "The next branch of this repo tracks the latest TypeScript compiler nightly release as a devDependency.". My PR is about peerDependency. Where is mistake, readme or your comment?

README is wrong there, sorry! It is in fact a peerDependency

@JKillian thank you for participation :-)


Exponent limits in the results

Hello,
I would like to thank you for the all your efforts which you invested and still investing in making the program and providing it to all to enjoy it.
I would like to give you a suggestion. It would be nice if a person can set  the limit at which the output to be changed in scientific notation. As example if I set the precision to 4 and the results is between 0.0001 and 0.000000000001 the result is shown as 0. It would be nice if the options is for both positive and negative scientific notations.

Best Regards,
Adriyan

Hi @1andro1,
Thank you for the suggestion!  I have added the option to set upper and lower limits for exponents in settings. They used to default to 12 and -12.
With your example, you can now try setting lower exponent limit to -3 let's say and the results should be:
0.0001 = 1e-4
0.000000000001 = 1e-12

You can now also choose to always use exponential notation by switchin on the Always use exponential notation option in settings.
I have released v3.10.0 with theses updates.  Please give it a try and let me know if this fulfills your request.

Great! Works like charm! Many Thanks!


distributed training crashes with dp (list comprehension issue from torch?)

🐛 Bug
I ran a distributed GPU template and get an error with data parallel and scatter_gather from torch nn parallel in particular.
To Reproduce
Steps to reproduce the behavior:
install packages
git clone from master
run basic example gpu job with distributed

Validation sanity check: 0it [00:00, ?it/s]Traceback (most recent call last):   File "gpu_template.py", line 80, in <module>     main(hyperparams)   File "gpu_template.py", line 41, in main     trainer.fit(model)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 853, in fit     self.dp_train(model)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/distrib_parts.py", line 578, in dp_train     self.run_pretrain_routine(model)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 1001, in run_pretrain_routine     False)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 277, in _evaluate     output = self.evaluation_forward(model, batch, batch_idx, dataloader_idx, test_mode)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 424, in evaluation_forward     output = model(*args)   File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in __call__     result = self.forward(*input, **kwargs)   File "/opt/conda/lib/python3.7/site-packages/pytorch_lightning/overrides/data_parallel.py", line 66, in forward     return self.gather(outputs, self.output_device)   File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py", line 168, in gather     return gather(outputs, output_device, dim=self.dim)   File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/scatter_gather.py", line 68, in gather     res = gather_map(outputs)   File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/scatter_gather.py", line 62, in gather_map     for k in out))   File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/scatter_gather.py", line 62, in <genexpr>     for k in out))   File "/opt/conda/lib/python3.7/site-packages/torch/nn/parallel/scatter_gather.py", line 63, in gather_map     return type(out)(map(gather_map, zip(*outputs))) TypeError: zip argument #1 must support iteration
Code sample
run python3 gpu_template.py --gpus 2 --distributed_backend dp
Expected behavior
should run distributed demo job without errors
Environment

CUDA:
- GPU:
- GeForce RTX 2080 Ti
- GeForce RTX 2080 Ti
- available:         True
- version:           10.2
Packages:
- numpy:             1.18.4
- pyTorch_debug:     False
- pyTorch_version:   1.5.0
- pytorch-lightning: 0.7.6
- tensorboard:       2.2.1
- tqdm:              4.46.0
System:
- OS:                Linux
- architecture:
- 64bit
-
- processor:         x86_64
- python:            3.7.6
- version:           #201812030624 SMP Mon Dec 3 11:25:55 UTC 2018

Additional context
python3 gpu_template.py --gpus 2 --distributed_backend ddp works

I was experiencing this problem the other day. It's somewhat related to PyTorch.
if you look at the function that gathers the outputs from GPU devices, https://github.com/pytorch/pytorch/blob/master/torch/nn/parallel/scatter_gather.py#L47
def gather_map(outputs):
        out = outputs[0]
        if isinstance(out, torch.Tensor):
            return Gather.apply(target_device, dim, *outputs)
        if out is None:
            return None
        if isinstance(out, dict):
            if not all((len(out) == len(d) for d in outputs)):
                raise ValueError('All dicts must have the same number of keys')
            return type(out)(((k, gather_map([d[k] for d in outputs]))
                              for k in out))
        return type(out)(map(gather_map, zip(*outputs)))

You'll see that It only supports tensors or dictionries that contain tensors.
The problem for me was that my training_step function returned something like this:
results = {
    "loss": loss,
    "log": all_logs,
    "progress_bar": progress_logs,
}

progress_logs was a dictionary that contained numbers, since I wanted the progress bar to show the moving average, instead of the exact values. So I came up with a hacky function like below to convert the numbers to tensors and move them to the appropriate device.
def _fix_dp_return_type(self, result, device):
    if isinstance(result, torch.Tensor):
        return result.to(device)
    if isinstance(result, dict):
        return {k:self._fix_dp_return_type(v, device) for k,v in result.items()}
    # Must be a number then
    return torch.Tensor([result]).to(device)

I hope there's a better fix for this :)

hmmm I am just returning loss and log so I have to convert the loss to tensor and feed into the device?

feels like this is something that should be covered in the parallel tools in lightning....

I agree. One way to fix is to override the default gather function in pytorch_lightning.overrides.data_parallel.LightningDataParallel.

@nsarang maybe submit a PR with this patch? @ananyahjha93

@williamFalcon Alright. Are you referring to #1895?
I'm not sure how I can work on an existing PR :)

@nsarang you can override the gather function and create a separate PR for it.

I was experiencing this problem the other day. It's somewhat related to PyTorch.
if you look at the function that gathers the outputs from GPU devices, https://github.com/pytorch/pytorch/blob/master/torch/nn/parallel/scatter_gather.py#L47
def gather_map(outputs):
        out = outputs[0]
        if isinstance(out, torch.Tensor):
            return Gather.apply(target_device, dim, *outputs)
        if out is None:
            return None
        if isinstance(out, dict):
            if not all((len(out) == len(d) for d in outputs)):
                raise ValueError('All dicts must have the same number of keys')
            return type(out)(((k, gather_map([d[k] for d in outputs]))
                              for k in out))
        return type(out)(map(gather_map, zip(*outputs)))

You'll see that It only supports tensors or dictionries that contain tensors.
The problem for me was that my training_step function returned something like this:
results = {
    "loss": loss,
    "log": all_logs,
    "progress_bar": progress_logs,
}

progress_logs was a dictionary that contained numbers, since I wanted the progress bar to show the moving average, instead of the exact values. So I came up with a hacky function like below to convert the numbers to tensors and move them to the appropriate device.
def _fix_dp_return_type(self, result, device):
    if isinstance(result, torch.Tensor):
        return result.to(device)
    if isinstance(result, dict):
        return {k:self._fix_dp_return_type(v, device) for k,v in result.items()}
    # Must be a number then
    return torch.Tensor([result]).to(device)

I hope there's a better fix for this :)

Where do you call  _fix_dp_return_type to fix the issue?

I was experiencing this problem the other day. It's somewhat related to PyTorch.
if you look at the function that gathers the outputs from GPU devices, https://github.com/pytorch/pytorch/blob/master/torch/nn/parallel/scatter_gather.py#L47
def gather_map(outputs):
        out = outputs[0]
        if isinstance(out, torch.Tensor):
            return Gather.apply(target_device, dim, *outputs)
        if out is None:
            return None
        if isinstance(out, dict):
            if not all((len(out) == len(d) for d in outputs)):
                raise ValueError('All dicts must have the same number of keys')
            return type(out)(((k, gather_map([d[k] for d in outputs]))
                              for k in out))
        return type(out)(map(gather_map, zip(*outputs)))

You'll see that It only supports tensors or dictionries that contain tensors.
The problem for me was that my training_step function returned something like this:
results = {
    "loss": loss,
    "log": all_logs,
    "progress_bar": progress_logs,
}

progress_logs was a dictionary that contained numbers, since I wanted the progress bar to show the moving average, instead of the exact values. So I came up with a hacky function like below to convert the numbers to tensors and move them to the appropriate device.
def _fix_dp_return_type(self, result, device):
    if isinstance(result, torch.Tensor):
        return result.to(device)
    if isinstance(result, dict):
        return {k:self._fix_dp_return_type(v, device) for k,v in result.items()}
    # Must be a number then
    return torch.Tensor([result]).to(device)

I hope there's a better fix for this :)

Where do you call  _fix_dp_return_type to fix the issue?

@Skylixia
Are you using an up-to-date version? This is supposed to be fixed now.

@Skylixia
Are you using an up-to-date version? This is supposed to be fixed now.

Yes I am on the latest version.
I don't have any stack trace but seeing this issue I thought it might fix the validation problem I have.
I also have as output "Validation: 0it [00:00, ?it/s]" and used :
results = {
"loss": loss,
"log": all_logs,
"progress_bar": progress_logs,
}
idk what it could be then :/

Yes I am on the latest version.
I don't have any stack trace but seeing this issue I thought it might fix the validation problem I have.
I also have as output "Validation: 0it [00:00, ?it/s]" and used :
results = {
"loss": loss,
"log": all_logs,
"progress_bar": progress_logs,
}
idk what it could be then :/

@Skylixia
I see that you're doing old-style logging.
This might help: https://pytorch-lightning.readthedocs.io/en/latest/logging.html

@Skylixia
I see that you're doing old-style logging.
This might help: https://pytorch-lightning.readthedocs.io/en/latest/logging.html


RSProfileConfig retrieves integer string as scientific notation after RuneLite restart.

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
When storing a large number as string with  net.runelite.client.config.ConfigManager::setRSProfileConfiguration, after rebooting RuneLite, net.runelite.client.config.ConfigManager::getRSProfileConfiguration returns the stored number as string in scientific notation.
To Reproduce
Steps to reproduce the behavior:

Let config denote an instance of ConfigManager
Let s = "1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111"
Store s using config.setRSProfileConfiguration("debug_group", "debug_key", s);
Restart RuneLite
Retrieve s' from config using config.getRSProfileConfiguration("debug_group", "debug_key");
Observe s' = "1.1111111111111111E108"  != s

Expected behavior
Because we stored a string, and not an integer, we would expect the retrieved string to be equal to the input string.
Screenshots
Not applicable.
Environment (please complete the following information):

OS: [e.g. Windows, Ubuntu, macOS]
RuneLite version: 1.8.4
Launcher version: Unknown (observed when debugging with IntelliJ)

Additional context
This issue was encountered when debugging emote-clue-items#33. The plugin allows configuration of all stash fill statuses, and stores the status as a string 108 times 0/1 to represent the fill status of each stash unit ordered by object id.

this is working as expected

In that case, could you add this expected behaviour to the java doc?


Update out-of-tree custom module example

We have this custom module example which needs some improvements.

[ ] Update fedimint
[ ] Include non-trivial module example (not just the dummy module)

[ ] Server implementation
[ ] Client NG implementation

[ ] Add a fedimint-cli crate which includes ^^ client
[ ] Add an example test with fedimint-bin-tests
[ ] Add an example test with integrationtests
[ ] Can spawn mprocs playground

Related to #2359?
Would it make sense to submodule the example into tests?
@jkitman

@garyray-k Thanks for noticing!  I don't see a point in keeping the dummy module as-is, that's why I'm modifying it into a "new dummy" that includes non-trivial examples.
Let's track most of these subtasks in #2359 which I'll have a PR out for soon (including modularized tests).  The only thing I don't intend to do yet is to refactor the "new dummy" module code into fedimint/fedimint-custom-modules-example.  I'd prefer to wait until our module API settles a bit.
The "new dummy" module would also be useful for integration testing other modules, so I'm not sure whether we'd want to refactor it into another repo then depend on it for testing.  But at the same time I'd rather not have to maintain two dummy modules.
Maybe our "example" repo could be an actual account-based module which would be very similar to the "new dummy" module with some minor tweaks.  If it's a useful module it'd be worth maintaining independently.

Oops. I meant git submodule, not fedimint submodule. (modules all the way down)
Ack all else.

https://github.com/fedimint/fedimint/pull/2368 achieved about 2/3 of these

I think this is basically done


Add "open source hardware" icon.

The layout for this icon exists but went missing from the test chip.

Done in PR #29


Devops 578

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
ℹ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

ℹ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [21].
ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12303954342. Examine the logs at this URL for more detail.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Good morning @AndrewAnnex and @Leguark ,
Could you review my PR? I uploaded gempy-engine v2024.2 on conda-forge (feedstock) and rewrited this recipe. Could you approved it ?
Thank you for your works

@SophieCurinier I don't have the availability to review this pr, but if you make a new PR to add yourself as a maintainer to this feedstock I will approve that and then you'd be able to review and merge this PR


Stepwise Regression (Linear and Logistic)

Currently not working on THOR.
Includes Forward, Backward and Bidirectional Stepwise Regression.
@tlhumphrey2 @johnholt

This seems to have caused a mass change to classify.ecl ?

The two files actually exactly same (except SVM portion which was added later).

Did you remember to rebase before submitting the pull request?

I have merged the branch with master.

The blocking bug for the 5.4 THOR is: https://track.hpccsystems.com/browse/HPCC-13985?jql=text ~ "graph result"
Note that this works on the 5.2 version.

The only thing (beyond the blocking bug for THOR) is that this implementation uses the ML.Mat attributes and so is slow for large data.  I entered Jira https://track.hpccsystems.com/browse/ML-274 for this issue.  The pull request should be processed.


False Diamond triggers

There's an issue with the hover detection in the new Diamond slider.

Lots of reports of accidental diamond giving, and with the removal of the confirmation for $5 level this is bound to happen frequently.
attn @superzordon

I just mocked up this concept.... instead of horizontal,  it could go vertical.
You'd move up the list as you wanted to give more diamonds.  This would make it a more deliberate action and have the default as 1 diamond.

Added a gif to show the issue is also present on the other values but then is gone again in a small zone around the border of the box.

I like @seanslater idea of vertical slider.

This may be related to - when I click the diamond button it implies im giving level 3, until the spinner finishes.

Thanks for flagging. Going to reduce the size of the hoverable select box and add a delay to the pop-up. Here's what it will look like:
https://user-images.githubusercontent.com/88362450/129577003-795e4698-b24a-41f4-928a-e6325145d24c.mov

@superzordon

can you show what happens when just clicking the diamond button without moving mouse?

can you try and show the behaviour paul and i demonstrated is resolved by slowing down the mouse movement? Diamond selector should not select any diamonds until mouse cursor is within the popup select box

for info - https://github.com/bitclout/frontend/pull/395

Looking good. Ill check now.

@superzordon Safari on macOs still seems to have the issue

Firefox on macOS looks fine - although animations are sluggish but thats probably firefox.

Another false trigger I noticed was in this post (https://bitclout.com/posts/1a70eb7cac28f70b1ed27c5988547f87a96f558fc4520859220ee01381668aaa?tab=posts)
Whenever you hover your mouse over the user tag (@creatorcapital), the diamond slider pops up.
I accidently diamonded this post while trying to click the user tag

cant replicate it at that URL due to post stats - but scrolling down on the profile here does show it - see gif below.

Thanks for flagging this. This should resolve.

@superzordon perfect - fix just deployed works i think!

@iPaulPro this can probably be closed now?

@iPaulPro this can probably be closed now?

Yes, looks good!


Performance of website open in mobile & Desktop its low speed

Bug Description
Performance of website open in mobile & Desktop its low speed
Steps to Reproduce
Steps to reproduce the behavior:

Copy URL "https://www.thenewboston.com/"
go to "https://developers.google.com/speed/pagespeed/insights/"
paste URL "https://www.thenewboston.com/" in Enter a web page URL

Expected behavior
The speed of website open it must be score 90-100
Actual behavior
In mobile website open speed is 30
and Desktop 40
Screenshots/Recordings
https://prnt.sc/vo6tg9 ->mobile
https://prnt.sc/vo6ttz ->Desktop
OS and Browser

OS:  Windows 10
Browser Chrome

Well, even youtube a Google products sucks at their testers, thats because page insights tests on overall network quality which in the world more percentage have slow internet. If you want to provide the best UX for the website then try to get 100% on GTMetrix or Pingdom Tools.

We should consider SSR for the website, it will increase performance, but we'll also have more abilities for SEO.
But this will be something in a longer-term, right now it's not a priority.

We should consider SSR for the website, it will increase performance, but we'll also have more abilities for SEO.

We can use the PageSpeed Module with Nginx. We will get a bunch of configurations for Server-side Rendering.
https://developers.google.com/speed/pagespeed/module

Hi there,
How about using Cloud Flare Pro? It enhances security and a lot of optimization tools for websites. I've used in one of my websites and it works great.

Attached Screenshots from lightroom report below:

Attached Screenshots from lightroom report below:


Sorting using  with MixItUp and MultiFilter

Hello,
I am adding MixItUp and MultiFilter to a website I am building.
(Warning, I don't really know javascript, so please be gentle)
I have been able to get the MultiFilter portion working without any real problems. However, I wanted to use a SELECT element for the sorting rather than text or buttons (there are a lot of sorting options).
The included demos don't have any sorting using SELECT for filtering.
This is the code that works using BUTTON

<button type="button" class="control control-sort" data-sort="published-date:asc">Newer first</button>
<button type="button" class="control control-sort" data-sort="published-date:desc">Oldest first</button>
<button type="button" class="control control-sort" data-sort="auth-name:asc">Author Name A-Z </button>
<button type="button" class="control control-sort" data-sort="auth-name:desc">Author Name Z-A</button>
<button type="button" class="control control-sort" data-sort="item-name:asc">Item Name A-Z</button>
<button type="button" class="control control-sort" data-sort="item-name:desc">Item Name Z-A</button>

I modified this based what works in the demos for filtering using SELECT to come up with this:

<select>
<option value="published-date:asc">Newer first</option>
<option value="published-date:desc">Oldest first</option>
<option value="auth-name:asc">Author Name A-Z </option>
<option value="auth-name:desc">Author Name Z-A</option>
<option value="item-name:asc">Item Name A-Z</option>
<option value="item-name:desc">Item Name Z-A</option>
</select>

Selecting an option from the pull down does nothing.
These are the items to be filtered and sorted:

ace soundset free item:A auth:A

diva skin free item:X auth:F

hive other commercial  item:C auth:S

hive soundset commercial item:B auth:P

hive soundset free item:S auth:A

diva soundset free item:G auth:A

zebra2 soundset commercial item:J auth:Z

zebra2 other commercial item:M auth:L

And the script included:

Any help getting this to work would be appreciated.

Hi,
Have you seen this demo?
https://demos.kunkalabs.com/mixitup/select-dropdowns/
https://github.com/patrickkunka/mixitup/tree/v3/demos/select-dropdowns
It shows basic sorting with a select drop down and MixItUp core (using a custom JavaScript change handler). As the Multifilter extension isn't concerned with sorting, you should be able to integrate the above directly into a Multifilter project.

I must have missed it - thanks.
I will give it a try and see if I can get it to work.

@patrickkunka
Works perfectly - thanks.

Great


blueprint: sshkey to users in images blueprint conversion

See https://github.com/osbuild/images/pull/928 for reasoning.

go.mod: update osbuild/images to v0.87.0
Update osbuild/images to include:

blueprint: remove the sshkey customization
(https://github.com/osbuild/images/pull/928).
[RHEL-9] Drop RHSM and RHUI-specific config from Azure and EC2 images
(COMPOSER-2308) (https://github.com/osbuild/images/pull/857).

blueprint: sshkey to users in images blueprint conversion
The sshkey customization in osbuild/images has been dropped.  In
osbuild-composer we maintain it for backwards compatibility, converting
each to a user customization, which is a superset of the sshkey.

cloudapi: update expected image type test for gcp-rhui
gce-rhui is now gone from RHEL 9 [1] and the old name simply aliases to
gce.  gcp-rhui in the cloudapi now resolves to 'gce' in RHEL 9 and
'gce-rhui' in RHEL 8.
[1] https://github.com/osbuild/images/pull/857

System doesn't contain the expected image-builder.insights facts (profile-id)

:thinking:

https://github.com/osbuild/osbuild-composer/blob/f58193dbebef99cb53a9562f6740645bdb6825ff/test/cases/api/common/common.sh#L63
It is now called:
image-builder.insights.compliance-profile-id: pci-dss

https://github.com/osbuild/osbuild-composer/blob/f58193dbebef99cb53a9562f6740645bdb6825ff/test/cases/api/common/common.sh#L63
It is now called:
image-builder.insights.compliance-profile-id: pci-dss

Awesome, thanks for looking it up!


TagUI Desktop application support

Hi @kensoh
Thanks for keeping something like tagUI open source :). I am fairly new to tagUI, could you please help me out with some queries related to it:

The browser doesn't end clean after the automation is over, whenever I try to run a different new script it throws the "Restore/Close tabs" pop up in the browser, in my case I have used Google Chrome.

How to identify the address of the local windows applications elements other than visual image option to automate? Other than image as a reference to pass the data is there something we can use?
Suppose, for example: If I am searching for a particular person in "Microsoft Teams", after the search I would like to click on the exact person in order to chat or send him some content.

How to always click the latest unread mail from outlook of specific subject.

That's all for now. I'll get back and update if I have something new.
Regards,
Shravan

Hi Shravan, I see, yes that is a known side-effect because there is no other way of terminating Chrome other than killing its process through the operating system level.

Your understanding is correct, only visual automation is able to interact with the desktop applications. Besides using images, you can try to see if using keyboard combinations can do what you need. Most open-source tools can't interact with desktop applications directly, but you can google for some other tools which can do so to see if it fits your use case better.

Besides recognising by image, you can do x,y coordinates offset or specify x,y coordinates to click. For example, click (400, 600) if you know the latest email is always at the top and the location is always the same. You can use echo mouse_xy() in live mode to check the current mouse position.

Hi Kensoh, Thank you so much for the update. I will try and see how to work out with it.

Sure @shravanvh I'll close the issue for now but do shout out here or reopen if you have more questions!


tf.signal.mfccs_from_log_mel_spectrograms caused internal error in converted TensorFlow Lite model

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: OnePlus A3010
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.0
Python version: 2.7
Bazel version (if compiling from source): 0.26.1
GCC/Compiler version (if compiling from source):  Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: N/A

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Hello everyone,
I have tried to extract MFCC features from audio signal using tf.signal.mfccs_from_log_mel_spectrograms. My python code runs pretty well, but when I converted it to a TensorFlow Lite model, and used it on android phone. I got the following error:
"
...
...
Caused by: java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: tensorflow/lite/kernels/strided_slice.cc ellipsis_mask is not implemented yet.
Node number 20 (STRIDED_SLICE) failed to prepare.
...
...
"
I am pretty sure the error was caused by tf.signal.mfccs_from_log_mel_spectrograms, since I did not directly use "strided_slice" directly in my code, and in the visualized graph of the html file obtained by visualization tool , I can only find the context of strided_slice like:
"
...

161
StatefulPartitionedCall/model_1/lambda/mfccs_from_log_mel_spectrograms_2/dct/strided_slice
COMPLEX64
[]
59
{u'quantized_dimension': 0, u'details_type': u'NONE'}

162
StatefulPartitionedCall/model_1/lambda/mfccs_from_log_mel_spectrograms_2/dct/strided_slice/stack
INT32
[2]
136
{u'quantized_dimension': 0, u'details_type': u'NONE'}

163
StatefulPartitionedCall/model_1/lambda/mfccs_from_log_mel_spectrograms_2/dct/strided_slice/stack_1
INT32
[2]
177
{u'quantized_dimension': 0, u'details_type': u'NONE'}

164
StatefulPartitionedCall/model_1/lambda/mfccs_from_log_mel_spectrograms_2/dct/strided_slice/stack_2
INT32
[2]
63
{u'quantized_dimension': 0, u'details_type': u'NONE'}

...

"

In the same graph file, I also found
"

22
[157, 162, 163, 164]
[161]
{u'begin_mask': 2, u'ellipsis_mask': 1, u'end_mask': 0, u'new_axis_mask': 0, u'shrink_axis_mask': 0}

"

So I think tf.signal.mfccs_from_log_mel_spectrograms trigged a dct, following a strided_slice, whose "ellipsis_mask" was set to 1, which is not implemented in TensorFlow Lite.
But I truly don't know how to avoid that error, actually, I got the same error, when using tf.signal.stft, also tf.signal.frame. They all called "tf.strided_slice" implicitly and set "ellipsis_mask" to 1.
By the way, the dimension of input tensor(log of mel spectrograms) to tf.signal.mfccs_from_log_mel_spectrograms was (None, 64, 20). Please kindly help me!
Regards,
Simon
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

For me it worked, when I saved model in the following matter:
import tensorflow as tf

converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS,
                                       tf.lite.OpsSet.SELECT_TF_OPS]
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)

And then added tensorflow-lite-select-tf-ops nightly build to the dependencies in build.gradle:
dependencies {
    implementation 'org.tensorflow:tensorflow-lite:0.0.0-nightly'
    implementation 'org.tensorflow:tensorflow-lite-select-tf-ops:0.0.0-nightly'
}

@tpeet, thank you for your reply! I was using the same convert scripts, but built a local Tensorflow lite aar by Bazel from source. So did you succeed in using tf.signal.mfccs_from_log_mel_spectrograms, or any mfcc function like audio_ops.mfcc in a Tensorflow lite on android? If so, could you kindly provide more details, like your Tensorflow version, lines of codes using mfcc? Thank you so much!
Regards,
Simon

Hi, we're actively working to add native support for the ellipsis_mask, targeting the next TF 2.2 release in Q1.

@jdduke is ellipsis_mask supported in TF2.2 now? Seems like it's still not working.

@jdduke is ellipsis_mask supported in TF2.2 now? Seems like it's still not working.

Can you try with the nightly build? I don't think our ellipsis_mask fix made it into the 2.2 release. Note that you'll have to re-converter your model.

Right, you need re-export your model.
We handle the ellipsis_mask in the converter.
thanks!

thanks. i end up converting all my usage like [..., 0:1] into something more explicit like [:, :, :, 0:1]. but it's good to know that ellipsis_mask will be supported in next release.

Great.
Our converter basically does that "[..., 0:1] => [:, :, :, 0:1]" for you right now.

@simonchen375,
We are checking to see if you still need help on this issue. We recommend that you upgrade to 2.6 which is latest stable version of TF and let us know if the issue still persists in newer versions. we will get you the right help.Thanks!


decoding fixed

Description
Convention is that if user sets decoding_logging_steps = 0  then we don't decode.
Checklist
Answer each question with "yes", and provide an explanation if the answer isn't what is expected.

Is this PR focused on a single feature without the possibility of being divided into smaller PRs?

Answer: y

Are all variables set with logical defaults that are backward compatible?

Answer: y

Can you provide a link to a Neptune experiment verifying the functionality of this PR?

Answer: na

Have you successfully executed the linter and tests?

Answer: y

Are all functions concise and don't require splitting?

Answer:y

Is there documentation for arguments and complex logic?

Answer: y

Are there no temporary solutions in the code? Should a task be added to Trello to refine the code?

Answer: y

Are all functions placed in appropriate files?

Answer: y

Is the PR name meaningful and descriptive?

Answer: y

Is PR description provided, or unnecessary?

Answer: y

Other questions:

Have you not made changes to the requirements or anything related to the Singularity image? If you have, did you generate and upload a new image to the clusters?

Answer: n

Is the change significant enough to notify all individuals working with this repository?

Answer: n

Is there a need for a second reviewer?

Answer: n

beautiful


bugfix(nested-usage): Fixes nested addon usage by finding the host

Only addons that are immediately included at the root level app actually get access to the app, but addons can also traverse their ancestry to find that root level addon. This adds a function based on the private findHost function in ember-cli itself. While the method is private, other addons such as ember-test-selectors, ember-bootstrap, and plenty of others do use it, and since it's based on the tree structure that addons have it's pretty unlikely that it will break on us soon.
I can confirm that this fixes #337 locally, happy to try to add a test in node-tests as well if needed

Coverage remained the same at 98.512% when pulling 7832d00da7444fa3db3ab82c5bf6477eab36091d on pzuraq:bugfix/ensure-find-host into b006004b350397687ee9bcd8492522cf9e71c4c8 on san650:master.

I'm interested what happens if several addons includes ember-cli-page-object. Is it duplicated in a target app? which one wins?

@pzuraq this fix is released in v1.12.1. Thanks for contributing!


Enhancement: flow wrapper

Many of the NWM recurrence intervals are not represented in the ras model flows.  If we think this is an appropriate extension of ras2fim, a wrapper which takes some form of NWM flows and generates appropriate depth grids has several use cases.
Use cases:

extending validation data: Currently any feature with a depth grid not close enough to a NWM recurrence interval is dropped.  Combined with the features lost in conflation of the ras models, this represents a significant loss of "ideally" available features to validate.
mapping: (this one might be on the vis team to do?)

@JamesColl-NOAA Please add points to this issue.

@JamesColl-NOAA Please add points to this issue.


Link for supported countries for GitHub Sponsors

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/sponsors/receiving-sponsorships-through-github-sponsors/setting-up-github-sponsors-for-your-organization
you can find list of all affected texts at https://github.com/github/docs/search?q=https%3A%2F%2Fgithub.com%2Fsponsors%23countries
What part(s) of the article would you like to see updated?

For a list of supported regions, see GitHub Sponsors.

should be

For a list of supported regions, see GitHub Sponsors.

(note hash part of link changed from countries to regions)
As noted previously, you can find list of all affected texts at https://github.com/github/docs/search?q=https%3A%2F%2Fgithub.com%2Fsponsors%23countries
Additional information
No response

@kospl
Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

Thanks @kospl. I agree that would be an improvement. You or anyone else is welcome to create a PR with that change!

@lecoursen I would love to, but there's another problem with that, after downloading [from GitHub servers] with GitHub desktop client on average speed 3MiB/s:

and hardly estimated number of indexes:

I got some pretty long error message:

I would try to copy it for you though so you can report it internally if you think it's appropriate:
Cloning into '         \GitHub\docs'...
remote: Enumerating objects: 200169, done.
remote: Counting objects: 100% (214/214), done.
remote: Compressing objects: 100% (197/197), done.
remote: Total 200169 (delta 25), reused 204 (delta 16), pack-reused 199955
Receiving objects: 100% (200169/200169), 507.81 MiB | 2.73 MiB/s, done.
Resolving deltas: 100% (142454/142454), done.
error: unable to create file translations/de-DE/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/de-DE/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/de-DE/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/de-DE/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/de-DE/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/es-ES/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/es-ES/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/es-ES/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/es-XL/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/es-XL/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/ja-JP/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/ja-JP/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/ja-JP/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/ja-JP/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/ja-JP/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/ko-KR/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/ko-KR/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/ko-KR/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/pt-BR/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/pt-BR/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/pt-BR/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/pt-BR/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/pt-BR/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/ru-RU/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/ru-RU/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/ru-RU/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/zh-CN/content/admin/configuration/managing-connections-between-github-enterprise-server-and-github-enterprise-cloud/enabling-automatic-user-license-sync-between-github-enterprise-server-and-github-enterprise-cloud.md: Filename too long
error: unable to create file translations/zh-CN/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/zh-CN/content/github/setting-up-and-managing-your-enterprise-account/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
error: unable to create file translations/zh-CN/content/github/setting-up-and-managing-your-enterprise/configuring-identity-and-access-management-for-your-enterprise-account/configuring-saml-single-sign-on-and-scim-for-your-enterprise-account-using-okta.md: Filename too long
error: unable to create file translations/zh-CN/content/github/setting-up-and-managing-your-enterprise/setting-policies-for-organizations-in-your-enterprise-account/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-enterprise-account.md: Filename too long
Updating files: 100% (42180/42180), done.
Filtering content: 100% (60/60), 64.61 MiB | 319.00 KiB/s, done.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

P.S. If you know how to do multiple search/replace in GitHub repo without an local IDE, I'm all ears.

If you know how to do multiple search/replace in GitHub repo without an local IDE, I'm all ears.

@kospl It's funny you should mention this 😀 There's a new feature on GitHub that offers a browser-based development environment built from VSCode that you can access using the . key shortcut. Take a look at the documentation and let us know if that helps!

@kospl that's a currently experienced problem on Windows. See #7620 for more info.


Create blank biopsy form introduce feature toggling and change the habitat use form

Background
Biopsy Form - BMMRO need a biopsy form in the app which will allow them to maintain biopsy records on the boat using the app.  BMMRO take biopsies from animals during an encounter which helps them build a body of research about the animals
Acceptance Criteria
AC1: add Biopsy section and button on Habitat Uses screen
given I am logged in and I am within the context of an encounter
when I am on the "Habitat Uses screen"
then I can see a Biopsies section header and a new biopsy button
AC2: New Biopsy button takes me to a New Biopsy form
given I am logged in and I am within the context of an encounter
when I am on the "Habitat Uses screen" and when I click the New Biopsy button
then a "New Biopsy Form" should appear, with just a header and a cancel button
AC4: cancel button takes us back to the Habitat Use Screen
AC3: Introduce feature toggling
Tech task - introduce feature toggling for the biopsy form.
Wrap the new section on the Habitat Use Form in a feature toggle.
The feature toggle should be set to true in Dev and UAT and false in Prod
Out of Scope

Biopsy user flow for reference


Android: No PIN is required when turning off the Touch ID

@senagbe
Steps to reproduce:

Open the app
Tap on the Profile
Tap on Touch ID
The option will be turned off and there is no PIN request popup displayed at all
PIN verification have to be done before turning off the Touch ID

@senagbe please review it

Do Android issues go here? https://github.com/HTMLCOIN/htmlcoin-android/issues

Again please raise this in the appropriate repo, this is HTMLCOIN Core.


plot_convehull function #28

please check the lintr comments here (goes over the space after the if like i mentioned above):
https://github.com/abhiamishra/ggshakeR/actions/runs/2295762248

@harshkrishna17 the checks are failing because the convex hull test is failing: https://github.com/abhiamishra/ggshakeR/runs/6356949584?check_suite_focus=true
can you please take a look?
(if checks weren't successful, click through on Details to see what's going on)


feat(object.has): enable it on nested objects

Basically, copying the field-search method from object.get, which, I guess, is going to be pretty useful.
Semver: patch

@smusali this appears to be getting stale?  If you're stuck on something, let us know so we can make decisions and move this forward.  Thanks!

@smusali this appears to be getting stale? If you're stuck on something, let us know so we can make decisions and move this forward. Thanks!

Sorry, I have been away for some time - started relooking

@all-contributors please add @smusali  for code


fix "split to @_ is deprecated" warning

On Perl 5.10, perl is incorrectly interpreting any split not assigned to
an array as a split intended to replace @_. Since this behavior was
deprecated, Perl is warning about it. This warning is causing tests in
downstream modules (like my Mercury application) which check for
warnings to fail.
I can't find when this deprecation was added (before 5.6), but the
feature was removed from Perl in 5.12, and the warning fixed to only
apply to split called in void context.
The only syntax that prevents this warning is assigning the result of
split to an array. Disabling the category of this warning ("syntax", as
reported in perldiag) does not seem to prevent this warning, but
disabling all warnings does.

Testing for warnings unconditionally is a very bad idea imo, and definitely not reason enough to add workarounds to Mojolicious. We generally don't specifically optimize for 5.10.1 either, deprecation warnings (even false ones) are a bit of an odd problem, so i'm not sure if the current workaround will stay. I'd hate for this to result in a wave of pull requests with more workarounds for old versions of Perl.


Ci setup

Adding badges

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b6e5b41). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@          Coverage Diff           @@
##             main     #10   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?       1
  Lines           ?       1
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?       1
  Partials        ?       0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


ServiceLocator instead of Container

Hi,
I want to migrate our Application from Zend 2 to Zend 3. At first only the servicemanager.
We want to use the new "build" method for creating objects with options.
The new system always uses the "__invoke" method to call the factory. This is fine by us, but the signature has now the "ContainerInterface" instead of the "ServiceLocatorInterface".
The "ContainerInterface" does not have the "build" method. The "$container->build('Foo')" works (Its always a servicelocator), but the IDE shows a warning.
I think we need an FactoryInterface with the ServiceLocator inside the __invoke method.
Is this possible to implement with the next version.
Greetings Jan

build() is used for plugin managers, primarily, and essentially an internal detail of how the service is created; it is guaranteed to always return a new instance. The ServiceManager and plugin managers use build() to create the instance, but get() then decides whether or not to cache it, based on whether or not the service is marked as shared.
If you want a new instance, you should mark the service as shared => false, and call $container->get() within your factories.
Marking a service as not shared:
[
    'shared' => [
        ServiceName::class => false,
    ]
]


Lifetime only checked when a key is found

This code prints the numbers 1 through 1000:
package main

import (
	"fmt"
	"time"

	lru "github.com/elastic/go-freelru"
)

func hashInt(foo int) uint32 {
	return uint32(foo)
}

func main() {
	cache, err := lru.NewSynced[int, int](1000, hashInt)
	if err != nil {
		panic("uhh")
	}

	for i := 0; i < 1000; i += 1 {
		cache.AddWithLifetime(i, i, time.Second)
		fmt.Printf("%d\n", cache.Len())
		time.Sleep(time.Second)
	}
}

This is because we only do a lifetime check when a key is found. So keys that are never checked again will never be evicted for exceeding their lifetime. They will only be evicted by the LRU policy.

This is on purpose to avoid costly checks. But that doesn't work well in all situations and may cause resource leaks.
I think the main problem with the current approach is described in #43: control over expired items is required by the application code.

@umanwizard Please have look at #49, any feedback appreciated. It works without introducing an internal go routine to regularly check for expired items. The application code can force it by explicitly calling PurgeExpired(), like in
	for i := 0; i < 1000; i += 1 {
		cache.AddWithLifetime(i, i, time.Second)
		fmt.Printf("%d\n", cache.Len())
		time.Sleep(time.Second)
		cache.PurgeExpired()
	}

That seems great to me.


⚠ Jerry Savelle Ministries International Australia has degraded performance

In 2335ba1, Jerry Savelle Ministries International Australia (https://jsmiaustralia.org) experienced degraded performance:

HTTP code: 200
Response time: 7690 ms

Resolved: Jerry Savelle Ministries International Australia performance has improved in d7e90b4 after 18 minutes.