layer.conf: Don't take distro policies in hand

Distro's should decide via bblayers.conf on adding the
layers, BSPs layers should provide for the machine policies
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

I don't understand here. I am not adding new layers on behalf of distro, I am only tweaking BBFILES to selectively include some bbappends based on the list of layers that the user decided to pull into the build.
and i am doing that exactly to provide machine policies, e.g. for gpsd bbappend file. if meta-oe is not included in the build, I cannot provide gpsb bbappend. but if meta-oe is used, then I need gpsd bbappend so that gpsd works on machines defined in meta-qcom.
I would have agreed if you complained that gpsd bbappend modifies SRC_URI regardless of machine, looking at that, i think this is a bug here.. but not what you are reporting.

well I was looking at what it was doing to my BBFILES, anyway using dynamic layers is better option. I have fixed the pull for that.
generic modification to gpsd did not catch my eye before but you are right. this is not a good thing to do. So may be you should either propose it to meta-oe or make this apply using SOC_FAMILY overrides for machines where it matters

d'oh... BBFILES_DYNAMIC is really nice! I didn't know about it ;)
can you please squash both commits? Also why did you create dymamic-layers folder? it's not really needed, or is it a convention that others use generally?

as for the GPSd patch, we are planning to get it merged upstream eventually, it's not the right thing to merge it in meta-oe for now. But I will fix it to use SOC_FAMILY.

@kraj , looking at how I manage SOC_FAMILY.. do you think it's a good idea to create a "qcom:" SOC_FAMILY? or would that be too generic?

d'oh... BBFILES_DYNAMIC is really nice! I didn't know about it ;)
can you please squash both commits? Also why did you create dymamic-layers folder? it's not really needed, or is it a convention that others use generally?

squashed and pushed. Creating dynamic-layers folder is a convention not a need. It does keep all
external tweaks in one place so kind of nice.

@kraj , looking at how I manage SOC_FAMILY.. do you think it's a good idea to create a "qcom:" SOC_FAMILY? or would that be too generic?

we should not create it if this is then used to customize recipes for meta-qcom, but it can be created
if all qcom SOCs share something e.g. same graphics driver or things like that. gpsd example does fit into that category. but it can be abused so my suggestion would be to use other knobs first if possible


Update the README documentation

The README file is missing documentation on how to use Hoff: @bot merge, @bot merge and tag, etc.  It also has a couple of broken links.

PR #112 is ready now and should fix the issues reported here.


router/index.js constructor to accept a lowdb instance also, for being able to use lowdb adapters.

The current constructor accepts two options. Either a path to a file or a javascript object:
//index.js

  if (typeof db === 'string') {
    db = low(new FileSync(db));
  } else if (!_.has(db, '__chain__') || !_.has(db, '__wrapped__')) {
    db = low(new Memory()).setState(db);
  } // Create router

It would be nice to be able to pass lowdb instance on the constructor, in case someone wants to use custom lowdb adapters.
e.g. I'm planning to create a lowdb adapter as a proxy for mysql. Being able to use an adapted instance on json-server could possibly allow restifying mysql server or other data sources.
Example useage:
const jsonServer = require('json-server')
const serverInstance = jsonServer.create()
const low = require('lowdb')
const MysqlAdapter = require('./MysqlAdapter')
//create an adapted lowdbInstance
const lowdbInstance = low(new MysqlAdapter(require('./dbconfig')))
serverInstance.use('/mysqlproxy', [
      ...jsonServer.defaults(),
      jsonServer.router(lowdbInstance)//pass the instance directly to router
    ]);

My bad.
It already accepts a lowdb instance. Actually if (!_.has(db, '__chain__') || !_.has(db, '__wrapped__')) can be translated to if(! isLowDbInstance())


Revert "[flutter_tools] show only supported sub commands"

Reverts flutter/flutter#85125
Failures in https://ci.chromium.org/ui/p/flutter/builders/prod/Mac tool_tests_commands/1431/overview

Landing revert eagerly to green the tree.


[Feature] Prune tables of left/right outer join based on uniqueness

Add  UniquenessBasedTablePruneRule for table pruning.
UniquenessBasedTablePruneRule is dedicated to prune right hand side of left outer join
or left hand side of right outer join based on the fact that join columns of the pruned side
are unique and its columns are used in output columns as the join.
So this rule is not required that foreign key constraint to bridge two tables joined together,
and it can not be apply to inner join and does not have ability of column equivalence inferring.
for an example:
 select l_tax from lineitem l left join orders o on l.l_orderkey = o.o_orderkey

orders have unique key constraint on o_orderkey and only l_tax is used, so orders can be pruned,
so the SQL optimized as follows:
select l_tax from lineitem.

The uniqueness of join columns are not only inferred from uniqueness constraints, but also can be inferred from
the fact group-by columns of group-by aggregation are unique.
for an example:
 select l.l_tax
 from lineitem l left join
 (select l_orderkey from lineitem group by l_orderkey) t on l_orderkey = t.l_orderkey

t.l_orderkey is unique and only l.l_tax is output, so the SQL can be optimized as follows:
 select l_tax from lineitem

What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 275 / 294 (93.54%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
146
161
90.68%
[93, 109, 145, 146, 164, 165, 166, 167, 168, 201, 204, 205, 208, 209, 277]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CPJoinGardener.java
85
88
96.59%
[352, 356, 363]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderCardinalityPreserving.java
34
35
97.14%
[205]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 510 / 533 (95.68%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
144
158
91.14%
[105, 141, 142, 160, 161, 162, 163, 164, 197, 200, 201, 204, 205, 273]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/PrimaryKeyUpdateTableRule.java
92
96
95.83%
[144, 147, 157, 169]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderCardinalityPreserving.java
38
39
97.44%
[283]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CPJoinGardener.java
201
205
98.05%
[197, 345, 474, 489]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
26
26
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/RboTablePruneRule.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 552 / 574 (96.17%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
146
159
91.82%
[102, 138, 139, 157, 158, 159, 160, 161, 194, 197, 198, 201, 202]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/PrimaryKeyUpdateTableRule.java
92
96
95.83%
[144, 147, 157, 169]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
43
45
95.56%
[157, 204]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/join/JoinReorderCardinalityPreserving.java
38
39
97.44%
[283]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CPJoinGardener.java
199
201
99.00%
[479, 494]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
26
26
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/RboTablePruneRule.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 153 / 162 (94.44%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
148
157
94.27%
[102, 138, 139, 168, 194, 199, 200, 204, 205]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 153 / 162 (94.44%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
148
157
94.27%
[102, 138, 139, 168, 194, 199, 200, 204, 205]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/Utils.java
1
1
100.00%
[]

@mergifyio rebase

[FE PR Coverage Check]
:heart_eyes: pass : 152 / 161 (94.41%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/UniquenessBasedTablePruneRule.java
148
157
94.27%
[102, 138, 139, 168, 194, 199, 200, 204, 205]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/pruner/CboTablePruneRule.java
1
1
100.00%
[]

@mergifyio backport branch-3.1


Master leaks memory when multiple log streams are open

Doing development daily with vagrant box master. Usually I end up running about 5 terminal windows with logs tailing from stacks. The master node will become unresponsive and usually eventually docker will restart either master or mongo containers.
Setting master memory to 1024m made the crash later and setting the memory to 1500m gives me a full day of sweet local development (continous stack upgrades, deploy, log tails)

So is it both master AND mongo starting to consume mem with long running log streams?


fix: Update get_template_names documentation

self.steps.current returns a number in string form. get_template_names requires a template (or list containing one template) be returned.

Well, it depends how you define the wizard form list. In the example, as FORMS is a list of tuples, you should get the step as address, paytype, etc. so I think it is correct.


Just me or is impl From<_> for u8x16 missing?

There are impls for all u8x_::from except u8x16.

I'm using merely #![feature(stdsimd)].
But I'm looking to cast each lane of a u16x16 to u8.  For other vectors this seems to be from and not from_bits.  Am I mistaken in thinking I don't want from_bits?

I'm looking to cast each lane of a u16x16 to u8.

Then you need impl From<u16x16> for u8x16 and you are right, all u8x16 and all i8x16 impls are missing.

https://github.com/rust-lang-nursery/stdsimd/pull/421 should fix this.

Closed by #421 .


Using a shortcut with right-click menu prevents menu from closing

After selecting an object (way, node, or area) and right-clicking, if a keyboard shortcut that's available on the right-click menu is used, the right-click menu stays open after clicking away
e.g. select an area and right-click it. While the context menu is still open, press O on the keyboard to circularize. Observe the area has been circularized. Click away. The context menu remains

Hi and welcome, @jgscherber. Thanks for reporting. This looks like a known bug we've fixed on our development branch for a future release of iD. See #7143.


Compilation error

I have installed all linc libs, haxe 3.3.0 (but I also tried 3.2.X), flow alpha-2. But when I run haxelib run flow build in snow directory I get this message:
~/dev/haxe/snow/git /master> haxelib run flow build
flow / 1.0.0-alpha.2 (node.js v0.12.7)
flow / target is mac ( arch 64 )
flow / build only
flow / haxe version 3.3.0 (git build development @ 4688e8f)

flow / build - snow 1.0.0-alpha.2 for mac
flow / build - running haxe ...
/usr/local/lib/haxe/std/haxe/macro/Context.hx:258: characters 9-46 : Type not found 'Main.UserConfig'
snow/types/TypeCreate.hx:45: characters 50-72 : Called from
snow/types/Types.hx:71: characters 12-36 : Called from
Aborted

Probably this is sth trivial but I can't find what it is..

You wouldn't try to build snow, you would build something that uses snow (snow is a library). Try samples/basic and run haxelib run flow build from that folder instead :)

I got back to my old project where I used very old version of snow and I had to build snow first. That's why I tried the same with the new newer version :) I followed your advice but unfortunately I get:
~/dev/haxe/snow/git/samples/basic /master> haxelib run flow build
flow / 1.0.0-alpha.2 (node.js v0.12.7)
flow / target is mac ( arch 64 )
flow / build only
flow / haxe version 3.3.0 (git build development @ 4688e8f)

flow / build - snow.basic 1.0.0 for mac
flow / build - running haxe ...
File "src/typing/typeload.ml", line 102, characters 27-33: Assertion failed

same error for any project from samples.

That's an internal error from the haxe compiler, nothing I can do about that unfortunately!

You were right. With 3.2.1 everything works as expected. Thank you for your help!

No problem. For reference, we test and make sure everything is working on compiler versions during their RC releases, before that time they aren't officially supported (even if I do frequently test or fix things against the new versions, it is not considered a priority).

Is there any particular issue on the haxe repo that we can keep track on?

Keep track on what in particular @kevinresol?

Oh, please ignore me. Because I thought this was a bug of the compiler so there should be a issue tracking the bug. But then I realized that it is not a bug but a breaking change about genericBuild. So, no more worries. Thanks.

Ah I see. Not sure this was specifically genericBuild related, but there are some changes to that that are still not well defined, so we will wait to see what the compiler decides to do and we will adapt when the RC is ready.

There was kinda strange resolution in (https://github.com/HaxeFoundation/haxe/issues/4825#issuecomment-207061028). They decided to implement @:eager meta but didn't reopen the issue.


Enable dbs-interrupt unit test case for aarch64

Currently legacy irq related test is enabled for x86_64 only, it should also be enabled for aarch64 too.

close this since when we move to Kata, it will run dragonball-sandbox ut in aarch64.


chore: add .secrets.baseline

Support codescan tooling

:tada: This PR is included in version 0.17.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ExecJS::RuntimeError on navigating to home page

Hi!
Just downloaded the app, it looks promising. The only thing is that I get this error when I try to navigate to my root_path for my website
CssSyntaxError: /var/lib/gems/2.3.0/gems/helpdesk-0.0.40/app/assets/stylesheets/helpdesk/custom.css:3:34: Missed semicolon
// They will automatically be included in application.css.
// You can use Sass (SCSS) here: http://sass-lang.com/
on
<%= stylesheet_link_tag    'application', media: 'all', 'data-turbolinks-track' => true %>
in the application .html.erb. I have a pretty custom Devise setup where I use 3 different users, one of which is an admin class. I'm wondering what steps I should try to debug this? I'm new to rails, and I can't find anything else on the internet for this

Hi!
This commit https://github.com/wacaw/helpdesk/commit/06820a3ff9ba92df0291ed46799b40b33312e762 should solve this problem.
Try with new 0.0.41 version.

That fixed the error thanks!
But now I've got something new, it says that the template is missing. I get the following error
Missing template helpdesk/tickets/index, helpdesk/application/index, application/index with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :coffee, :jbuilder]}.

don't worry about it, due to how I build my app I don't think this is gunna work. I built my own, but thanks for posting!

Try this: https://github.com/wacaw/helpdesk-demo


Fix key error

I found the error below when recreating my xmltv DB, so I've added some code to check for valid 'season' keys in the dictionary.  This isn't widely tested so please do sanity check it before merging!
The error occurs when the GraceNote collection includes a dictionary with 'totalSeasons: x, totalEpisodes: y' and no season/episode information. Not sure why this creeps in here, maybe the JSON has changed?  I'm using the UK database and the program that causes the error appears to be 'Program: SH013026900000 'Antiques Road Trip''
I used Eclipse to debug so I've also added the pydev exclusions to .gitignore - there's no need to keep these changes if you feel they're unnecessary.
2016-05-22 09:53:13,634 root                                WARNING  Key(s) not processed for Program: awards
Traceback (most recent call last):
File "./sd2xmltv.py", line 362, in
main()
File "./sd2xmltv.py", line 358, in main
app.process()
File "./sd2xmltv.py", line 113, in process
program_lookup = self._sd.get_cached_programs(schedule_list.get_program_ids())
File "/home/hts/sd2xmltv/libschedulesdirect/schedulesdirect.py", line 177, in get_cached_programs
return {program.program_id: program for program in self._cache.get_programs(program_ids)}
File "/home/hts/sd2xmltv/libschedulesdirect/schedulesdirect.py", line 177, in
return {program.program_id: program for program in self._cache.get_programs(program_ids)}
File "/home/hts/sd2xmltv/libschedulesdirect/cache.py", line 130, in get_programs
yield json.loads(item["program_json"], object_hook=Program.from_dict)
File "/usr/lib/python2.7/json/init.py", line 339, in loads
return cls(encoding=encoding, **kw).decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 381, in raw_decode
obj, end = self.scan_once(s, idx)
File "/home/hts/sd2xmltv/libschedulesdirect/common.py", line 1579, in from_dict
program.metadata = ProgramMetadata.from_iterable(dct.pop("metadata"))
File "/home/hts/sd2xmltv/libschedulesdirect/common.py", line 871, in from_iterable
program_metadata.season_episode = SeasonEpisode.from_dict(item.pop("Gracenote"))
File "/home/hts/sd2xmltv/libschedulesdirect/common.py", line 843, in from_dict
season_episode.season = dct.pop("season")

Can you tell me what headend you are using?  I'd like to take a look at the data coming back from Schedules Direct.  If they are sending bogus data I'd like to take the issue up with them.  If this isn't an issue with Schedule Direct's data, then I'd be happy to merge your pull request.

Headend is TVHeadend - Build: 3.4~wheezy on a Raspberry Pi.
I think it may be bogus data; it was fine a few days back when I first installed, but failed recently. Thanks for your active responses - much appreciated!

Sorry, I was referring to the Schedules Direct headend/lineup you are using.  I'll add the same to my account so I can test.

Sorry for the delay:
Manage Account Options:

1. List subscribed lineups
2. Add lineup
3. Remove lineup
4. List lineup channels.

Choose an option or 'x' to exit.
> 1

Subscribed Lineups:

Lineup:	GBR-OTA-HP13
Name:	Local Over the Air Broadcast
Transport:	Antenna
Location:	HP13

I've fixed the issue in the develop branch to now handle the totalSeasons and totalEpisodes attributes.  I didn't merge your pull-request due to some extra changes I made to include these attributes in the xmltv output.  It doesn't appear that I can merge an individual commit for .gitignore so I'll add that in a separate commit.  For the future I'd suggest submitting a pull-request for each unit of functionality (i.e. one for the .gitignore changes and the other for gracenote changes).
Regardless, thanks for submitting the pull-request!

No problems, thanks for the awesome work! The .gitignore was ready for you to ignore anyway - as it's not likely many others will be using Eclips for dev. Thanks again.


Provide a benchmark suitable for showing JRuby slowness

I was pointed to your readme today since it mentions that JRuby is slow due to BigDecimal performance, but I did not see any benchmarks or other means of exercising that behavior. If you can provide a benchmark that shows the JRuby performance issues, we might be able to do something to improve it.
Alternatively, we consider sub-par performance to be an issue, so if someone could file an issue at jruby/jruby with a reproducible benchmark, we'll have a look!

Hey @headius. Yes, that's right it says that on the readme. It was written a while back, and Bloom has since become the maintainer of the repo. I'm not hopeful that we'll find out what the slowness is/was. When we do see it or if someone reports it, I'll circle back here.
Thanks for reaching out -- your dedication to JRuby is amazing!


Require PDepend 2.6

Require PDepend 2.6

I'm thinking isn't this in theory a BC break?

Nope, it can (and not necessarily) be breaking only if the change of version itself is breaking.
For example jumping to PDepend 3.0 means PDepend public API has breaking changes. When doing such upgrade, we have to check what of the public API of PDepend is also impacting the public API of PHPMD, if so then we have to push it in a major version of PHPMD.
You can also consider having PDepend in dependency is like having all the code of PDepend directly in the PHPMD package, and in this case you see than a non-breaking change of PDepend is a non-breaking change of PHPMD (except in case of reflexion or some exposing of PDepend stuff not supposed to be public).
The only difference when it's a dependency is it can prevent users from updating PHPMD (because it would have a PDepend version locked by some other package) which is not actually a breaking change neither and it's up to this other package to unlock its PDepend version when it's ready but not a PHPMD responsibility.

Thanks for the explanation.


Add SuppressionCommentFilter and FileContentsHolder to the checkstyle rule

See https://github.com/GoogleCloudPlatform/java-docs-samples/pull/167

See also https://github.com/GoogleCloudPlatform/java-docs-samples/pull/173


Enable elasticsearch tests and code coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0873b59). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   69.48%
=======================================
  Files           ?      118
  Lines           ?     1999
  Branches        ?      150
=======================================
  Hits            ?     1389
  Misses          ?      610
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update gollum

Description of changes
package gollum

use bundlerApp in preference to stdenv.mkDerivation to build package gollum
bump dependency version numbers (in Gemfile.lock and gemset.nix)
simplify process of update dependencies via update.sh script

nixos

add option 'no-edit'
add option 'user-icons'

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@erictapen @jgillich @nicknovitski, could You please give some feedback on this PR? Should I split it?

Closes https://github.com/NixOS/nixpkgs/pull/132708

Hi @Erictapen, thank you for your reply. Indeed, I forgot to push the deletion of the version number that is not needed when using bundlerApp. I amended the fix and force-pushed the branch on top of current master.
Could you please try again? I do not have any issues so far with the updated branch.

Could you squash the two commits regarding the update script and the two commits regarding the dependencies?

Sure, I force-pushed again.
Thank you very much for your patient support! :heart:

Well, thanks for your contribution :)


⚠ Bofrost.at has degraded performance

In 8e334bc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1153 ms

Resolved: Bofrost.at performance has improved in 25a8647.


phaser-minimum.js games fail to start (error evaluating this.fx.clear)

http://codepen.io/anon/pen/vXYooK
camera.reset or camera.resetFX should probably check camera.fx != null (as when Phaser.Graphics is excluded).
This Issue is about

A bug in the API

Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the dev branch, and attributed the work to you in the README. If you need to tweak the code for whatever reason, please submit a new PR.

Is solved this error?

Like it says above, it's fixed in the dev branch.


Feature: allow to configure attribute knobs

We use theme attribute for Vaadin components, and it accepts one or several values.
Another example would be dir="rtl" - here we only need one value.
Proposed syntax:
<api-viewer attribute-knobs="dir(ltr|rtl),theme[small|filled|reverse],indeterminate?">

? stands for "boolean attribute" (rendered with a checkbox)
() stands for "one of values or empty" (rendered with <select>)
[] stands for "zero or more values" (rendered with checkboxes)
no modificator stands for "any value" (rendered with <input>)

Done by #31 and will be included to the upcoming 0.4.0 release.


Allow patching while game is already running

I need to run the game through Steam for custom Steam Controller presets to activate properly. If I run the game with the patcher, the default desktop preset will be used instead.

I actually found a workaround for this: launch Steam Big Picture mode first and then run the game in patcher. You will get few errors regarding no access to the client but the patch seems to be working just fine.

Is the game itself required to be run elevated for patching? I can workaround this issue by launching the Steam Big Picture mode and then run the game via patcher, but the mouse movement with the controller wont work with this method. I assume this is due to Steam running with normal user-level privileges and it's trying to simulate mouse movement in the game but the lack of access prevents moving the mouse in-game.

Just click "No" on the prompt of "Do you want to close and restart it in offline mode without EAC?". The patcher will use the running instance then. Be aware however that if your game runs online or you forgot to disable EAC that you'll most likely get banned.

I'm not getting such prompt when I have the game already running (eldenring.exe renamed to start_protected_game.exe and launched via Steam).

Don't rename the exe, that alone won't disable EAC.

Alright, now it worked:

Launch Steam Big Picture
Launch the game via "eldenring.exe", not via Steam (the game should load instantly with no EAC loading screen)
Launch the patcher, click "No" when it asks you to close the game and restart it in offline mode
The game should be patched at this point


Added Ramp Career page

Congratulations on making a pull request!
Please make sure you check all the items.

[x] The numbering of the company that you added starts with 1.
[x] You have increased the Total Companies Added count.

Fixed issue :-  Add Ramp #218

hey @Kaustubh-Natuskar , Checkout this PR .............


Parameters not converted properly when using arrays

First off, thanks for this awesome library!
Now, I have the following wrapper function that executes a get method using SwiftHTTP:
class func __get(urlAppendix url: String, headers: [String: String]? = nil, parameters: Dictionary<String, Any> = [:],numberOfItemsPerPage noipp: Any = 15, pageNumber: Int = 1, completion: ((_ response: Response) -> Void)? = nil) {
    let _headers = ["Authorization": Data.accessToken, "Content-Type": "application/vnd.api+json", "Accept": "application/vnd.api+json"]
    HTTP.GET(Data.apiURL+url, parameters: parameters.appending(["per_page": noipp, "page": pageNumber]), headers: headers ?? _headers, completionHandler: completion)
}

I want to pass the following dictionary as get parameter:
["filter[is_preselected]": 1, "filter[categories]": [categoryID]] // categoryID: String

When passing only non-array values, such as ["filter[is_preselected]": 1], it works just fine. But when I pass the array of strings, the parameters are converted to a url as follows:
?filter%5Bcategories%5D%5B%5D=1&page=1&filter%5Bis_preselected%5D=1&per_page=20

...manually making this more legible:
?filter[categories][]=1&page=1&filter[is_preselected]=1&per_page=20

...whereas it obviously should be:
?filter[categories]=[1]&page=1&filter[is_preselected]=1&per_page=20

(note the brackets after filter[categories]).
A similar thing happens when trying to code the string array myself by escaping quote chars and then manually adding the parameters in the URL directly:
let urlAppendix = "?filter[categories]=[\"\(categoryID)\"]&filter[is_preselected]=1"
__get(urlAppendix)

The response will actually not have any data at all: the URL is nil, the text & data is empty...
Any idea why this is not working properly? Do I need to do anything differently?

@daltoniam, any chance for you to review this?


maximum limit of spotify track_id inquiries from spotipy per query

Hello,
Does anyone know what the limit of track id's that can't be sent through spotipy/spotify API?
I have a list of ~150 spotipy track id's that I tried feeding through spotipy, but the error below saying that I've requested too many ids.
Is there a way around this?
Thanks a lot.
C:\Users>python2 spotifyMulti pleTracksFromCSV.py Traceback (most recent call last):   File "spotifyMultipleTracksFromCSV.py", line 29, in <module>     results = spotify.tracks({strOfTrackIds})   File "C:\Python27\lib\site-packages\spotipy\client.py", line 219, in tracks     return self._get('tracks/?ids=' + ','.join(tlist))   File "C:\Python27\lib\site-packages\spotipy\client.py", line 133, in _get     return self._internal_call('GET', url, payload, kwargs)   File "C:\Python27\lib\site-packages\spotipy\client.py", line 111, in _internal _call     -1, '%s:\n %s' % (r.url, r.json()['error']['message'])) spotipy.client.SpotifyException: http status: 400, code:-1 - https://api.spotify .com/v1/tracks/?ids=0aIIMF4tzxil3kucPwc2wK,4Pb1vhZi5DsqBLikqaxFEL,07Tx168RSsUS1H qkDIOZbH,3pqEVPtR5nl71DJ9EiWgmQ,60qnlDxdXkgcDAwBdRoRQP,6VNnM2Qlow95xRDBXfoy50,7t cas5SzlIDMgTepFemx9e,5XNm6WTJxKtcaug3lc8KJF,7EVG8LgkxwLcMskvF6VVZy,7EVG8LgkxwLcM skvF6VVZy,5TklECQ3x2MybRjaeIsTlm,60qnlDxdXkgcDAwBdRoRQP,3HxdXrWAAgK4a53m3lajPA,4 u4t9R8Iky417ZasENaKXX,3FmywdJ21ffovLTqQlY7xr,5XNm6WTJxKtcaug3lc8KJF,6cFqMHDH8BBW UGvghxBSdk,0KVF0f32xUa86fFPaqytwJ,3FmywdJ21ffovLTqQlY7xr,4Pb1vhZi5DsqBLikqaxFEL, 39YIK5rTuhfFlqWN6zMkoC,0aIIMF4tzxil3kucPwc2wK,5Q9MCK4NU3xApjsIkKWegw,1IvPBp0jFds jdi4bbQw719,4WxjlZbzLsAqGwr2i6Sq7E,4nH0DYzmr6rIicg8PnSlnk,3pqEVPtR5nl71DJ9EiWgmQ ,3pqEVPtR5nl71DJ9EiWgmQ,11KJSRSgaDxqydKYiD2Jew,7v7r7iT4INJjDbdHNVEU1c,6lKpgB0mqI 68SXmnjSrEjS,6cFqMHDH8BBWUGvghxBSdk,4GDX3ZlA4VbVHGT75TQ1uW,1lItf5ZXJc1by9SbPeljF d,7juAP7GZBF0Dtm0qqLSWOJ,4GDX3ZlA4VbVHGT75TQ1uW,3JvKfv6T31zO0ini8iNItO,0Uh6KAHee EqBopLbtzRirI,6PaGForx8vjTY0yu9THgzX,6cFqMHDH8BBWUGvghxBSdk,6g6TC8NLcWAuzQP3XSLP ky,6lKpgB0mqI68SXmnjSrEjS,73scFnG9NKXzXyeSJ6WwxF,6PaGForx8vjTY0yu9THgzX,2czeogK7 hI7NElf3bNhsor,7MbiqFLnw44ZrQCbF6fmrW,3HxdXrWAAgK4a53m3lajPA,4nH0DYzmr6rIicg8PnS lnk,60qnlDxdXkgcDAwBdRoRQP,0aIIMF4tzxil3kucPwc2wK,2czeogK7hI7NElf3bNhsor,6lKpgB0 mqI68SXmnjSrEjS,3pqEVPtR5nl71DJ9EiWgmQ,4nH0DYzmr6rIicg8PnSlnk,0aIIMF4tzxil3kucPw c2wK,3HxdXrWAAgK4a53m3lajPA,3folt4d0CndACKo02YNrin,39YIK5rTuhfFlqWN6zMkoC,1tNQEE oJ90f8welgLXPEw4,4WxjlZbzLsAqGwr2i6Sq7E,1B1q0y2reBKW7SKMo73iFF,3pqEVPtR5nl71DJ9E iWgmQ,39YIK5rTuhfFlqWN6zMkoC,1xFpp6uYNRPHfNe2M4gguQ,6Gr0KCTprJAhCpzjAw6xyE,0aIIM F4tzxil3kucPwc2wK,0aIIMF4tzxil3kucPwc2wK,5wQTS8buORezHxMK8cHOoV,1xFpp6uYNRPHfNe2 M4gguQ,4LsfkIMT7DXjzbq4HlKZ4p,5wQTS8buORezHxMK8cHOoV,1xFpp6uYNRPHfNe2M4gguQ,5P4Y rV968ejQHeRf1l8hDE,39YIK5rTuhfFlqWN6zMkoC,7EVG8LgkxwLcMskvF6VVZy,6PaGForx8vjTY0y u9THgzX,6tLu63a1IW4auXuHDGy4n5,6fujklziTHa8uoM5OQSfIo,4Pb1vhZi5DsqBLikqaxFEL,1xF pp6uYNRPHfNe2M4gguQ,3pqEVPtR5nl71DJ9EiWgmQ,3pqEVPtR5nl71DJ9EiWgmQ,5wQTS8buORezHx MK8cHOoV,5vrMJjqybyZcvnY1RNpwiC,5PsyuOkRJ1EjvwjtTGJdvt,4t53p6qK1JK00OIqCYGlxX,4G DX3ZlA4VbVHGT75TQ1uW,1xFpp6uYNRPHfNe2M4gguQ,7MbiqFLnw44ZrQCbF6fmrW,7MbiqFLnw44Zr QCbF6fmrW,38IckGSLq1mQub6NOwsKMP,39YIK5rTuhfFlqWN6zMkoC,6Gr0KCTprJAhCpzjAw6xyE,6 0qnlDxdXkgcDAwBdRoRQP,66iipPIorFQPk2YIM7Xbt2,4B3qvzOMzLQXLeYgPsG3KA,6lKpgB0mqI68 SXmnjSrEjS,7EVG8LgkxwLcMskvF6VVZy,3folt4d0CndACKo02YNrin,3JkJnBHeF7YWq3EW33hWdF, 4GDX3ZlA4VbVHGT75TQ1uW,0aIIMF4tzxil3kucPwc2wK,3HxdXrWAAgK4a53m3lajPA,2czeogK7hI7 NElf3bNhsor,2kWfO7rKJk3qFacoFW26nk,60qnlDxdXkgcDAwBdRoRQP,4nH0DYzmr6rIicg8PnSlnk ,4GDX3ZlA4VbVHGT75TQ1uW,4TDoUr2meaXsfbPFMdrqOE,1xFpp6uYNRPHfNe2M4gguQ,5wQTS8buOR ezHxMK8cHOoV,4nH0DYzmr6rIicg8PnSlnk,39YIK5rTuhfFlqWN6zMkoC,60qnlDxdXkgcDAwBdRoRQ P,3buZNBqLqmrcCZuJZbtRUD,6cFqMHDH8BBWUGvghxBSdk,4w2iAP3X4FkpPb5kjRdIDx,3i01M7jnv BYrhG6YnAqCdC,4Pb1vhZi5DsqBLikqaxFEL,4GDX3ZlA4VbVHGT75TQ1uW,4t53p6qK1JK00OIqCYGl xX,4GDX3ZlA4VbVHGT75TQ1uW,3TObBPe3nHX51mqOIHV84W,4Pb1vhZi5DsqBLikqaxFEL,4nH0DYzm r6rIicg8PnSlnk,4nH0DYzmr6rIicg8PnSlnk,4B3qvzOMzLQXLeYgPsG3KA,0aIIMF4tzxil3kucPwc 2wK,7v7r7iT4INJjDbdHNVEU1c,7v7r7iT4INJjDbdHNVEU1c,1xFpp6uYNRPHfNe2M4gguQ,39YIK5r TuhfFlqWN6zMkoC,2HBlo99yKt2d6WVSVM5UvU,5wQTS8buORezHxMK8cHOoV,0KVF0f32xUa86fFPaq ytwJ,5PsyuOkRJ1EjvwjtTGJdvt,0Uh6KAHeeEqBopLbtzRirI,5wQTS8buORezHxMK8cHOoV,2czeog K7hI7NElf3bNhsor,4GDX3ZlA4VbVHGT75TQ1uW,6lKpgB0mqI68SXmnjSrEjS,4TDoUr2meaXsfbPFM drqOE,5fdzPMOxUqVJYSzTP5cFP7,5MEYDJVJMaGAXfddTo0D6J,66iipPIorFQPk2YIM7Xbt2,7v7r7 iT4INJjDbdHNVEU1c,5PsUB0ISfQxRLhF5DmI5Ks,38IckGSLq1mQub6NOwsKMP,5vrMJjqybyZcvnY1 RNpwiC,3KuZx7FPNcqXG8YFN5Y0OG,4TDoUr2meaXsfbPFMdrqOE,4nH0DYzmr6rIicg8PnSlnk:  too many ids requested

It seems like the track_id limit per spotify API request is 50 tracks.  I broke up my data set (152 track_id's) into 4 smaller data sets and was able to decode the information.
If anyone has any idea on any type of limits with spotify API please let me know.
In addition, if anyone knows a better way around this other than breaking up the data set into smaller groups, please let me know as well.
Thanks.

Doc just updated accordingly.
@CrawFishFiesta  see if this helps https://stackoverflow.com/a/312464/1515819


AutoPr-Kusto-radennis-REST Spec PrNumber 5933

@radennis Closing this PR due to upcoming directory restructuring changes. Please open this PR manually after 06/11 when the restructuring is complete.


Fix fix outer join can not eliminate outer join recursively

when there is multi full outer join or outer join, filter should be able to push down and infer not null recursively
Issue Number: close #39740

run buildall

run buildall

run buildall


how to make the visualization (gif) using the trained model?

I have trained the MADDPG model and I want to visualize the results as you have shown in the repo. Do you have code to do that or can you give me pointers to how to do it from the trained model?

Hi, did you happen to find a solution for this? Wondering the same thing.

Hi @ptirupat, did you happen to find a solution for this? Wondering the same thing.

Use the code in evaluate.py


OJT001 - Maybe too strict?

Hi,
I am not 100% sure, so please double check, but it seems that this rule "OJT001_Object-predefined-type.feature" fails on a file in which both entities and types have the same PredefinedType/ElementType (i.e. it says that when the ElementType attribute of the TypeObject has a value, the PredefinedType on the Entity should be nil).
This may be a problem when using IDS, since, AFAIK, if I have an IFC file with $ as PredefinedType and "PIER" as ElementType on the TypeObject, the IDS checking would "fail" to identify such Entities.
Again, I am not 100% sure, so take this with a grain of salt!

OJT001 was developed to validate Concept Template <IP_ADDRESS> which states in the third paragraph

If the object is typed by an IfcTypeObject, then the PredefinedType at the IfcObject occurrence shall only be used if the PredefinedType at IfcTypeObject is set to NOTDEFINED.

So yes, an IFC model with an entity that is typed "twice" as you described would not be valid.
In terms of IDS checking, could you provide a snippet of an *.ids file or a plain-text description of a specification that would fail to identify entities with blank PredefinedType but typed by IfcObect?  Is the PredefinedType / ElementType part of the Applicability or the Requirement of the Specification? Or both?

Nvm, the rule is fine and does not affect IDS checking: in case on the entity the PredefinedType is $ and on the Type has a value, the value used for the IDS checking is inherited from the type and it works as expected.


How bad is having several inactive interactions at the same time?

Hi all,
Probably this is not the right place to ask, so please pardon me if it is so.
I am rather new to OL, but have had great progress using it in a WebGIS application, it is great! To simplify my code, I have opted to add all needed interactions at the beginning, but inactivate them using setActive(false) until they are needed. In the sample codes, however, I see the interactions are added and remove periodically. I wanted to know how bad this could be? I have maybe 8 to 10 interactions at the same time.
Any advice would be greatly appreciated.

Inactive interactions behave the same as interactions that do not exist, except for the memory resources they need. So don't worry, it is fine to add them at the time you set up your application.
For usage questions like this, Stack Overflow would be the right platform. Make sure to use the openlayers tag.

@ahocevar Thank you very much for your quick reply and advice!


Subject area OMAS should use spring rest client connector

Subject area OMAS client is making use of restTemplate correctly in 'RestCaller.java'.
Instead SA omas should be brought inline with other OMASs and make use of our spring client reset connector (SpringRESTClientConnector.java)
Found in https://github.com/odpi/egeria/pull/3056 (and a workaround implemented) - note this workaround will need to be removed in a future PR

Subject area OMAS client is making use of restTemplate correctly in 'RestCaller.java'.
Instead SA omas should be brought inline with other OMASs and make use of our spring client reset connector (SpringRESTClientConnector.java)
Found in #3056 (and a workaround implemented) - note this workaround will need to be removed in a future PR

Hi @planetf1 and @davidradl ! I can take this task to me and make these changes.

@immmus Sorry I have almost completed these changes.

@immmus Sorry I have almost completed these changes. Thank you very much for the offer.

Oh okay)), nothing wrong)

@immmus I have identified #3156 and #3157 which you could work on if you would like to. Please update those issues if you want to do them and I will assign them to you.


SlidingMenu don't show items in ListFragment.

I try to use slidingmenu as a drawer navigation, with a fragment.
I put a textview and a listview in the drawer's layout, and use arrayadapter to show some items.
Everything is right except items in listview not showing, but listview is there.
And if i do replace the fragment in main_activity layout, items show up now.

Can you paste the code for the menu fragment.

//------------------NavigationFragment.java-----------------------
public class NavigationFragment extends ListFragment {
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState){
    return inflater.inflate(R.layout.fragment_nav, null);
}

@Override
public void onActivityCreated(Bundle savedInstanceState){
    super.onActivityCreated(savedInstanceState);
    ArrayAdapter<String> arrayAdapter = new ArrayAdapter<String>(getActivity(), android.R.layout.simple_list_item_1, new String[]{"item1","item2","item3"});
    setListAdapter(arrayAdapter);
    Log.i("list", "adapter size" + getListAdapter().getCount());
}

}
//------------fragment_nav.xml-----------------

//--------------------------------------------------------------
Thanks for reply.
This is a very simple listfragment, so i wonder why it doesn't work. I also try to use custom list item and get the same result.


How to change FPS?

I've searched the docs but couldn't figure out how to change the framerate of the regl.frame loop. It does mention that it's possible to create my own loop but that regl.frame performs some cleanup operations and to use it whenever possible. In case the only way is via a custom function, can someone provide an example of what such function would look like with all the proper precautions?

why do you want to change the framerate?

Because I use regl to render animations that in the end run at 24fps but regl runs too fast most of the time so it's hard to predict what the final thing will look like.
Even for real time stuff I don't always want it to be at 60fps and using more resources than I can get away with.
I just want to be able to set a hard limit. If I have to do a custom loop that is fine but I think there should be more info on the docs since it mentions it vaguely.

Think you basically have to do something like:
const loop = () => {
  regl.poll()

  regl.clear({
    color: [0, 0, 0, 1],
    depth: true,
  })

  draw() // your draw commands here
}

Then you can choose how often to invoke loop (e.g. setTimeout). Although you're probably better of making the duration of your animation invariant to the framerate (e.g. calculate delta time between frames and use this to determine how far to move / scale something etc.).

Thanks, I'll try that. I'm aware of time delta technique but in my case I really need my animations to be exactly the same frame by frame every time I run because I ultimately render to gifs or videos and also another reason for the hard limit is my computer heats a lot unecessarily while developing when it should be so easy to just make it run slower. I was actually surprised to not see that option as part of the lib. Not complaining though, regl is by far the nicest lib I've worked with.

but in my case I really need my animations to be exactly the same frame by frame every time I run because I ultimately render to gifs or videos

Depending on how you do your animations there is a technique that I've been using, which give's you a guarantee that your gif/video is correct in regards to fps and what every frame displays.
I don't use a render loop at all, but manually progress the animation (e.g. in the case of GSAP using .progress(newProgress)) while doing a simple for-loop. In the following example code it looks like this gifTimeline.progress(currentFrame / numberOfFrames); https://codepen.io/Prinzhorn/pen/GNEmWQ
The benefit is that you don't need your recording to be in sync with the rendering (Screencast will sometimes not be 100% in sync) and you can also render a, say 5 second video, in much less than 5 seconds of actual wall time.

I was actually surprised to not see that option as part of the lib

I think this might be partly because this is not possible to do in a reliable fashion across all browsers. requestAnimationFrame does not give you any guarantees and setTimeout is not accurate enough. requestAnimationFrame the best choice to get smooth animation for the current user. In your case, e.g. rendering gif/video, you might be better of using the technique described above.

@Prinzhorn Thanks. The rendering part isn't as much of an issue as I'm currently using ccapture.js. My problem was really about previewing since it was running way too fast. As far as I'm concerned the issue is solved although an update to the docs with WebSeed's example might be a good idea.

@spredemann nice, thanks for pointing to ccapture.js

Sometimes, I like to have some shaders that I don't run at 60 fps because they are expensive in performance. Like read pixels for instance.
Here is what I do:
// define this somewhere
const slowerFrame = (regl, draw, dividerOfFramerate) {
  let i = 0;
  regl.frame( () => {
    i = (i +1) % dividerOfFramerate;
    if(!i) return;
    draw();
  })
}

// then I use it like that:
slowerFrame(regl, drawCommand, 2); // to divide the framerate of this draw loop by 2.

I only deal with multiple of the framerate, as I didn't find any reliable way to Hope that helps!

    if(!i) return;

should be
    if (i) return;
    // or
    //if (i > 0) return;

to skip most draw calls


Add validation and tests for change user language setting.

Makes sure that the language code sent by the user is one of the available language codes. I couldn't find existing tests for this view, So I added one.

Automated message from Dropbox CLA bot
@ragsagar, it looks like you've already signed the Dropbox CLA. Thanks!

This looks great, merged!  Thanks @ragsagar!


Pool timeout acquiring db connection with Askar and Postgres wallet in Multitenant mode

Intermittently getting pool timeout acquiring db connection with Askar and Postgres wallet.
aca-py version: 0.8.1
Postgres version: 13.1
Below are logs from Aries cloud agent python:
<IP_ADDRESS> [08/Jun/2023:07:32:05 +0000] "GET /status/live HTTP/1.1" 200 191 "-" "ELB-HealthChecker/2.0"
        src/ffi/store.rs:1010 | Closed session SessionHandle(1406)
        src/backend/db_utils.rs:168 | Dropped pool connection
Handler error with exception: Error when fetching storage record
Error handling request
Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/storage/askar.py", line 90, in get_record
    record_type, record_id, for_update=for_update
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_askar/store.py", line 419, in fetch
    self._handle, category, name, for_update
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_askar/bindings/__init__.py", line 224, in session_fetch
    return_type=EntryListHandle,
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_askar/bindings/lib.py", line 359, in invoke_async
    name, argtypes, *args, return_type=return_type
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 327, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 243, in result
    raise self._exception
aries_askar.error.AskarError: Backend error
Caused by: pool timed out while waiting for an open connection

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 173, in ready_middleware
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 210, in debug_middleware
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp_apispec/middlewares.py", line 45, in validation_middleware
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 330, in check_token
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 379, in check_multitenant_authorization
    return await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/admin/server.py", line 398, in setup_context
    self.context, token
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/multitenant/base.py", line 348, in get_profile_for_token
    wallet = await WalletRecord.retrieve_by_id(session, wallet_id)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/messaging/models/base_record.py", line 240, in retrieve_by_id
    cls.RECORD_TYPE, record_id, {"forUpdate": for_update, "retrieveTags": False}
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/storage/askar.py", line 93, in get_record
    raise StorageError("Error when fetching storage record") from err
aries_cloudagent.storage.error.StorageError: Error when fetching storage record

Also getting JSON Decode error intermittently:
`
Error handling request
Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/transport/pack_format.py", line 213, in get_recipient_keys
    message_dict = json.loads(message_body)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/json/init.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/json/decoder.py", line 342, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 1 column 2 (char 1)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/transport/inbound/http.py", line 94, in inbound_message_handler
    inbound = await session.receive(body)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/transport/inbound/session.py", line 218, in receive
    await self.handle_relay_context(payload_enc)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/transport/inbound/session.py", line 166, in handle_relay_context
    payload_enc, self.wire_format
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/multitenant/base.py", line 412, in get_wallets_by_message
    recipient_keys = wire_format.get_recipient_keys(message_body)
  File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aries_cloudagent/transport/pack_format.py", line 220, in get_recipient_keys
    "Error trying to extract recipient keys from JWE", e
aries_cloudagent.transport.error.RecipientKeysError: ('Error trying to extract recipient keys from JWE', JSONDecodeError('Extra data: line 1 column 2 (char 1)',))
`

Sorry this didn't get answered, but presumably you are past this. This does work...not sure what happened in your environment.


How to add continuous output?

Is there a way to modify the color picker so that it continuously outputs a color value as it is changed? Similar to the function onProgressChanged that a seekBar uses.

Of course you can. Just create an interface with one method that returns a ColorPicker object. Implement that same interface in your ColorActivity. Than create a method in the ColorPicker class which will let you set the listener.
This is how I did it with the MultiColorPicker:
MultiColorActivity
onCreate
 multiColorPicker = (MultiColorPicker) findViewById(R.id.multiColorPicker);
        multiColorPicker.setListener(this);

Somewhere
 @Override
    public void colorChanged(MultiColorPicker multiColorPicker) {
        for(LightPointModel lightPointModel : groupLights){
            lightPointModel.setLightColor(multiColorPicker.getColor());
        }

        createLightPointViews();
    }

MultiColorPicker.java
 public void setListener(MultiColorPickerListener listener){
        this.listener = listener;
    }

MultiColor
public interface MultiColorPickerListener {
    void colorChanged(MultiColorPicker multiColorPicker);
}


Sync routing with pagination #38

[x] Controls what have been received through query string on a separate file (Separation of concern)
[x] Lint
[x] Tested with:

[x] No query string
[x] Empty query string
[x] Number query string

Closes #38

Great! Thanks @eliamartani!


Add lint check to stop usage of v preceding version number

Using a v prior to a version number is not needed. Let's prevent this with linting step.
Need a way to ignore for non ROCm references.

Hi @saadrahim, has the issue been addressed?  I can close the ticket if it has been addressed.  Thanks.

This has not been addressed. It is an internal tool.

An internal task ticket has been created to track the progress.


fix segment IsInPreReservedHeapPageAllocator regression

My recent change breaks segment->IsInPreReservedHeapPageAllocator check
(when CFG is enabled). Refactor related SegmentBase/PageAllocatorBase
to move relevant data to super classes so that we can perform the check on
super class similar to before.

@curtisman @satheeshravi @agarwal-sandeep Please help review, thanks

:shipit:

Thanks @curtisman


feat(openai): support for attachments for openai assistants

Related to #1007

Thank you for doing this 👏

❤ ❤ thanks! i will try it and will check the development process to check if i can help with some issues!


Make selenium dependency optional

I'd like to use the PageObject pattern, but not necessarily use Selenium.
The reason for this is, that when I use Django I have the test client available for headless operation. In other words, I do not operate a Web browser but just the Django application instead. That's enough for getting the templates rendered, so that I can evaluate the page content (which speeds up test execution significantly).
You could allow Selenium to be install via extras, as described in the Python Packaging Guide, e.g.
$ python3 -m pip install page-object[selenium]

This, without the "extra features" in square brackets page-object would just install the minimum functionality that I require, e.g.
$ python3 -m pip install page-object

which would, for obvious reasons, speed up test execution in CI pipelines or when using Tox.

I see from the source code that this is hard to do. Because your PageObject is actually a Selenium wrapper.
Do you happen to know an alternative Page Object implementation that is independent from Selenium? Might be nice to explain that fact (and possible alternatives) in the README or the Wiki.


Added Encipher | Decipher

Title and Issue number

Close #2817

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Hey @MohitGupta121 Could you please review this?


Fixed failing golang test: TestAssignDsesToServer

removed ExpectPrepare in test cases to match commit 7030ac28

Can one of the admins verify this patch?


Application Hosted Media Calls Documentation insufficient

Describe the issue
The documentation about initiating an Application Hosted Media Call is insufficient.

The instructions to build a communications client are not usable:
Step 1 states to create an instance of an interface instead of listing the concrete class or classes that can be instantiated,
Step 2 is very difficult to understand and could be made much clearer with one or two lines of code.
Most of the class reference links on the page are broken

Code Snippet
A minimal code sample about how to initiate a call using the Graph Communications SDK should be present.

@zhengni-msft @ananmishr


Fix textFieldProps on AutocompleteElement

Reason: passing lowercase inputProps to the textFieldProps of an AutocompleteElement still doesn't work. E.g., setting a maxLength has no effect.

thanks for your contribution I took a different approach to fix this issue. Its released with 5.3.1


Update data_loader.py to Ensure Reproducibility in Multi-Process Environments with Dataloader Shuffle

What does this PR do?
This pull request addresses an oversight in the current implementation of prepare_data_loader function, related to the assignment of SeedableRandomSampler within nested sampler structures. Specifically, when employing BatchSamplerShard, it is possible for its encapsulated batch_sampler to possess its own sampler. The existing codebase does not account for this potential nesting, failing to apply SeedableRandomSampler to the innermost sampler when it is of type RandomSampler. This adjustment ensures consistent and expected behavior across all sampler layers, promoting enhanced control and predictability in sample selection processes.
Fixes #2574
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case. The 7th comment of this page.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
@muellerzr
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hi @muellerzr ! There seems to be a problem in quality check. I've run the same command on my server and it worked fine. Could you help identify the problem? Thank you!
make quality

ruff check .
ruff format --check .
126 files already formatted
doc-builder style src/accelerate docs/source --max_len 119 --check_only

Be sure you have the right versions installed by doing pip install -e .[quality]
(I’ll give this a review after the weekend :) )

Be sure you have the right versions installed by doing pip install -e .[quality]
(I’ll give this a review after the weekend :) )
also be sure to do both make style; make quality

Oh! Apologies for not realizing it's the weekend. I've executed these cmds and didn't observe any abnormalities. Here is the log:
pip install -e .[quality]

Obtaining file:///storage_fast/user/hurricane/accelerate
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Requirement already satisfied: numpy>=1.17 in /storage/user/miniconda3/lib/python3.12/site-packages (1.26.3)
Requirement already satisfied: packaging>=20.0 in /storage/user/miniconda3/lib/python3.12/site-packages (23.1)
Requirement already satisfied: psutil in /storage/user/miniconda3/lib/python3.12/site-packages (5.9.8)
Requirement already satisfied: pyyaml in /storage/user/miniconda3/lib/python3.12/site-packages (6.0.1)
Requirement already satisfied: torch>=1.10.0 in /storage/user/miniconda3/lib/python3.12/site-packages (2.2.1+cu118)
Requirement already satisfied: huggingface-hub in /storage/user/miniconda3/lib/python3.12/site-packages (0.21.4)
Requirement already satisfied: safetensors>=0.3.1 in /storage/user/miniconda3/lib/python3.12/site-packages (0.4.2)
Requirement already satisfied: black~=23.1 in /storage/user/miniconda3/lib/python3.12/site-packages (23.12.1)
Requirement already satisfied: hf-doc-builder>=0.3.0 in /storage/user/miniconda3/lib/python3.12/site-packages (0.5.0)
Requirement already satisfied: ruff~=0.2.1 in /storage/user/miniconda3/lib/python3.12/site-packages (0.2.2)
Requirement already satisfied: click>=8.0.0 in /storage/user/miniconda3/lib/python3.12/site-packages (from black~=23.1) (8.1.7)
Requirement already satisfied: mypy-extensions>=0.4.3 in /storage/user/miniconda3/lib/python3.12/site-packages (from black~=23.1) (1.0.0)
Requirement already satisfied: pathspec>=0.9.0 in /storage/user/miniconda3/lib/python3.12/site-packages (from black~=23.1) (0.12.1)
Requirement already satisfied: platformdirs>=2 in /storage/user/miniconda3/lib/python3.12/site-packages (from black~=23.1) (3.10.0)
Requirement already satisfied: GitPython in /storage/user/miniconda3/lib/python3.12/site-packages (from hf-doc-builder>=0.3.0) (3.1.42)
Requirement already satisfied: tqdm in /storage/user/miniconda3/lib/python3.12/site-packages (from hf-doc-builder>=0.3.0) (4.65.0)
Requirement already satisfied: nbformat in /storage/user/miniconda3/lib/python3.12/site-packages (from hf-doc-builder>=0.3.0) (5.10.3)
Requirement already satisfied: filelock in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (3.9.0)
Requirement already satisfied: typing-extensions>=4.8.0 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (4.8.0)
Requirement already satisfied: sympy in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (1.12)
Requirement already satisfied: networkx in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (3.2.1)
Requirement already satisfied: jinja2 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (3.1.2)
Requirement already satisfied: fsspec in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (2024.2.0)
Requirement already satisfied: nvidia-cuda-nvrtc-cu11==11.8.89 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (11.8.89)
Requirement already satisfied: nvidia-cuda-runtime-cu11==11.8.89 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (11.8.89)
Requirement already satisfied: nvidia-cuda-cupti-cu11==11.8.87 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (11.8.87)
Requirement already satisfied: nvidia-cudnn-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cublas-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cufft-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-curand-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cusolver-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cusparse-cu11==<IP_ADDRESS> in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-nccl-cu11==2.19.3 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (2.19.3)
Requirement already satisfied: nvidia-nvtx-cu11==11.8.86 in /storage/user/miniconda3/lib/python3.12/site-packages (from torch>=1.10.0) (11.8.86)
Requirement already satisfied: requests in /storage/user/miniconda3/lib/python3.12/site-packages (from huggingface-hub) (2.31.0)
Requirement already satisfied: gitdb<5,>=4.0.1 in /storage/user/miniconda3/lib/python3.12/site-packages (from GitPython->hf-doc-builder>=0.3.0) (4.0.11)
Requirement already satisfied: MarkupSafe>=2.0 in /storage/user/miniconda3/lib/python3.12/site-packages (from jinja2->torch>=1.10.0) (2.1.3)
Requirement already satisfied: fastjsonschema in /storage/user/miniconda3/lib/python3.12/site-packages (from nbformat->hf-doc-builder>=0.3.0) (2.19.1)
Requirement already satisfied: jsonschema>=2.6 in /storage/user/miniconda3/lib/python3.12/site-packages (from nbformat->hf-doc-builder>=0.3.0) (4.21.1)
Requirement already satisfied: jupyter-core in /storage/user/miniconda3/lib/python3.12/site-packages (from nbformat->hf-doc-builder>=0.3.0) (5.7.2)
Requirement already satisfied: traitlets>=5.1 in /storage/user/miniconda3/lib/python3.12/site-packages (from nbformat->hf-doc-builder>=0.3.0) (5.14.2)
Requirement already satisfied: charset-normalizer<4,>=2 in /storage/user/miniconda3/lib/python3.12/site-packages (from requests->huggingface-hub) (2.0.4)
Requirement already satisfied: idna<4,>=2.5 in /storage/user/miniconda3/lib/python3.12/site-packages (from requests->huggingface-hub) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in /storage/user/miniconda3/lib/python3.12/site-packages (from requests->huggingface-hub) (2.1.0)
Requirement already satisfied: certifi>=2017.4.17 in /storage/user/miniconda3/lib/python3.12/site-packages (from requests->huggingface-hub) (2024.2.2)
Requirement already satisfied: mpmath>=0.19 in /storage/user/miniconda3/lib/python3.12/site-packages (from sympy->torch>=1.10.0) (1.3.0)
Requirement already satisfied: smmap<6,>=3.0.1 in /storage/user/miniconda3/lib/python3.12/site-packages (from gitdb<5,>=4.0.1->GitPython->hf-doc-builder>=0.3.0) (5.0.1)
Requirement already satisfied: attrs>=22.2.0 in /storage/user/miniconda3/lib/python3.12/site-packages (from jsonschema>=2.6->nbformat->hf-doc-builder>=0.3.0) (23.2.0)
Requirement already satisfied: jsonschema-specifications>=2023.03.6 in /storage/user/miniconda3/lib/python3.12/site-packages (from jsonschema>=2.6->nbformat->hf-doc-builder>=0.3.0) (2023.12.1)
Requirement already satisfied: referencing>=0.28.4 in /storage/user/miniconda3/lib/python3.12/site-packages (from jsonschema>=2.6->nbformat->hf-doc-builder>=0.3.0) (0.34.0)
Requirement already satisfied: rpds-py>=0.7.1 in /storage/user/miniconda3/lib/python3.12/site-packages (from jsonschema>=2.6->nbformat->hf-doc-builder>=0.3.0) (0.18.0)
Checking if build backend supports build_editable ... done
Building wheels for collected packages: accelerate
  Building editable for accelerate (pyproject.toml) ... done
  Created wheel for accelerate: filename=accelerate-0.29.0.dev0-0.editable-py3-none-any.whl size=12128 sha256=cee4b8816a0be204617fa17494c7067dc3cee5f9ffa015dc45dc5272afe403d0
  Stored in directory: /tmp/pip-ephem-wheel-cache-zq385och/wheels/52/04/f9/8d449e0b508712291b9117bad0c6cdfa25f639c765b9aa730f
Successfully built accelerate
Installing collected packages: accelerate
  Attempting uninstall: accelerate
    Found existing installation: accelerate 0.29.0.dev0
    Uninstalling accelerate-0.29.0.dev0:
      Successfully uninstalled accelerate-0.29.0.dev0
Successfully installed accelerate-0.29.0.dev0

make style; make quality

ruff check . --fix
ruff format .
1 file reformatted, 125 files left unchanged
doc-builder style src/accelerate docs/source --max_len 119
ruff check .
ruff format --check .
126 files already formatted
doc-builder style src/accelerate docs/source --max_len 119 --check_only

Well it says right there that one file was reformatted :)

Well it says right there that one file was reformatted :)

Ah I finally got it. Sorry I am not familiar with this ruff tool. The newly formatted code was committed.

For your convenience, I've prepared this POC code:
import torch
from accelerate import Accelerator, DataLoaderConfiguration
from accelerate.utils import set_seed
from accelerate import notebook_launcher

def main():
    set_seed(42)

    accelerator = Accelerator(
        dataloader_config=DataLoaderConfiguration(use_seedable_sampler=True)
    )
    dataset = range(10)
    dataloader = torch.utils.data.DataLoader(dataset, batch_size=1, shuffle=True)
    dataloader = accelerator.prepare(dataloader)
    print(type(dataloader.batch_sampler.batch_sampler.sampler))

notebook_launcher(main, num_processes=2, use_port='8000')

<class 'torch.utils.data.sampler.RandomSampler'>
<class 'torch.utils.data.sampler.RandomSampler'>

Thanks for providing this patch, nice investigation of the issue. Would it be possible to add a unit test, perhaps based on your provided example?

Hi! Thank you for your prompt response. I've incorporated a unit test as suggested; however, I'm not sure whether this addition aligns with the expected formal coding standards.


Ignore scopes that uses dynamic descriptions

There should be no gutter icons (play button)
test("test my $number") {

}

This is opposite to my expectations. Why can't I add group/test without the "it/describe" prefixes and have them runnable from within the IDE?

@remen I think you misunderstood, group/test will be supported except for scopes that uses a dynamic description e.g. it("my test $someVar") { ... }

Oh, of course. My apologies!


Accelerator.save argument is incompatible with new released transformers save_pretrained

System Info
accelerate==0.24.1
transformers==4.35.0

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
The recently released transformers 4.35 has made safe_serialization=True default (introduced in https://github.com/huggingface/transformers/releases/tag/v4.35.0), this is incompatible with the default argument in accelerate: https://github.com/huggingface/accelerate/blob/2b53a9089c8a688eb561b6655053b301a5bf68ac/src/accelerate/accelerator.py#L2502
This combination may cause unexpected behavior. For example:
https://github.com/huggingface/accelerate/blob/2b53a9089c8a688eb561b6655053b301a5bf68ac/README.md?plain=1#L194
It seems like a good idea to update the default argument in accelerate also to safe_serialization=True.
Expected behavior
I got incompletely saved checkpoints when using DeepSpeed zero-1 and optimizer offload.

It is False by default in save on purpose, as save may not get tensors, so rather than having False everywhere it made more sense to keep it as False as the default, since it also deals with schedulers, optimizers, and non-model-based items that are save-able. This is something that needs to be addressed on the transformers side.
Can you share your code that lead to this error with DeepSpeed? We can look into addressing it from there. cc @LysandreJik @BenjaminBossan

(Note that in certain areas it’s True, such as save_state and save_model)

Sorry, I just realized that I didn't pass the parameter state_dict=accelerator.get_state_dict(model), and it started working correctly after I made the modification.
I hadn't realized this before because it also worked fine before the transformers update defaulted to using safetensors, haha.


QUICHE: roll QUICHE to f54082a0145f.

Description: roll QUICHE external dependency to a more recent version
and make necessary modifications.
Risk Level: Low.
Testing: No new tests. QUICHE is covered by extensive unit tests. No new
functionality is added to Envoy, therefore existing integration tests
should be sufficient.
Docs Changes: n/a.
Release Notes: n/a.

/wait
This change is not ready for review.

/waitany
Waiting for CI, take two.

All checks pass, this change is ready for review.


[RFE] Add support for multiple reboot windows

Current situation
Currently it is only possible to have one reboot window.
Impact
This means I can only schedule reboots for one specific day or every day.
Ideal future situation
It would be great to setup multiple reboot windows, for example:

Mon to Fri from 09:00 to 17:00 o'clock (office hours)

Implementation options
/bin/update-operator \
 --reboot-window-start="Mon, Tue, Wed, Thu, Fri 09:00" \
 --reboot-window-length=8h

Thanks for opening separate issue. More context here: https://github.com/flatcar/flatcar-linux-update-operator/issues/193.
If anyone wants to try implementing it, please go ahead. Existing implementation has plenty of tests, so it should be relatively easy to write new tests and extend it.


Add CLI to support pathfinder outlier elimination feature for AVT in pathfinder based deployment.

Enhancement summary
wlm310(config-profile-afd)#show cli commands | grep -i metric
[no|default] metric order ( loss-rate | latency | jitter | load )

wlm310(config-profile-afd)#show cli commands | grep -i outlier
[no|default] path-selection outlier elimination [ disabled ]
[no|default] path-selection outlier elimination threshold jitter <jitter> milliseconds
[no|default] path-selection outlier elimination threshold latency <latency> milliseconds
[no|default] path-selection outlier elimination threshold load <percentage> percent
[no|default] path-selection outlier elimination threshold loss-rate <percentage> percent

Enable feature ( enabled by default )
evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination

Disable feature
evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination disabled

Configure outlier threshold
evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold ?
  jitter     Configure jitter threshold
  latency    Configure latency threshold
  loss-rate  Configure loss-rate threshold
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold latency ?
  <0-10000>  millisecond

evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold jitter ?
  <0-10000>  millisecond

evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold loss-rate ?
  <0.00-100.00>  percentage

metric-order CLI
evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#metric order ?
  jitter     Prefer paths with lowest jitter
  latency    Prefer paths with lowest latency
  load       Prefer paths with lowest load
  loss-rate  Prefer paths with lowest loss-rate

evpnsfe1(config-profile-voiceAvt)#metric order latency

Which component of AVD is impacted
eos_cli_config_gen
Use case example
needed for pathfinder work
Describe the solution you would like
Implement all cli required for the feature
Describe alternatives you have considered
No response
Additional context
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

metric order ( loss-rate | latency | jitter | load ) :-> Even though the CLI accepts only one keyword right now, it might be extended in future to allow multiple metrics. i.e metric order loss-rate jitter ( Not not, but in future maybe )
As such schema can be a list of strings instead of single string,
Something like
metric_order:
        type: list
        items:
          type: str
          valid_values:
          - loss-rate
          - ...
          description: Metric preferred

On hold as command is not supported yet

@MaheshGSLAB Supported in the latest release already

It was not supported when the comment was added.
Guillaume
On Thu 7 Nov 2024 at 19:12, pmprado @.***> wrote:

@MaheshGSLAB https://github.com/MaheshGSLAB Supported in the latest
release already
—
Reply to this email directly, view it on GitHub
https://github.com/aristanetworks/avd/issues/4240#issuecomment-2462917218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW6HPRRLVNJZ7DDIVFAUNTZ7OUQLAVCNFSM6AAAAABLJ7QKSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSHEYTOMRRHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It was not supported when the comment was added. Guillaume
…
On Thu 7 Nov 2024 at 19:12, pmprado @.> wrote: @MaheshGSLAB https://github.com/MaheshGSLAB Supported in the latest release already — Reply to this email directly, view it on GitHub <#4240 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW6HPRRLVNJZ7DDIVFAUNTZ7OUQLAVCNFSM6AAAAABLJ7QKSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSHEYTOMRRHA . You are receiving this because you are subscribed to this thread.Message ID: @.>

Sure, I didn't mean to say Mahesh was wrong :) Just providing an update to the hold


Support for AEM 6.3?

Is there any planned support for authoring in AEM 6.3?  Current version of bobcat appears to only support up to 6.2.

Hi @user390181,
as mentioned now in our README, the current version of the TouchUI module was used for automating AEM 6.3, although it does not cover it fully.
Right now, we are re-thinking our approach to AEM and how to keep up with new releases. So I'd say there are no concrete plans in place ;).

My project recently upgraded to 6.4. I have been asked to use Bobcat for automation wrapper. Please let me know what all issues could be expected as i guess its not going to support 6.4

@prashant-varma as stated above, there is no concrete plan yet ;). We want to address the issue of supporting AEM, though we don't have any concrete dates in place.
As for the type of issues you might encounter - some selectors used in the current version of TouchUI module might not work in latest AEM, wherever the interface has been updated by Adobe. If you have any customizations in AEM, then you might find our Page Objects hard to extend (which is something we would like to address too). Our project teams have been maintaining their own versions of TouchUI modules due to the above - you can follow in their footsteps and get inspired by Bobcat's codebase :wink: .

We are working on new version of AEM authoring API that will be primarily focusing on AEM 6.4+. Since we also have active projects using it on AEM 6.3, we will try and address the backward compatibility too.


Stop linking to the old gitea

On the first line after the header on the readme their is a link to the gitea repo which has moved to GitHub as I understand

It hasn't moved to github. My github repos are all mirrors. I do all the development on my gitea instance. I do need to update the readme with the new gitea URL, but for now, the link should redirect correctly.


recorder Remove unused variable

The exemption for this file was broken in #3297 but the warning was not fixed.
The code includes an unused variable that seems safe to remove. I have tested the app and it does not seem to break in any way.
The code seems to be written by @gfwilliams, maybe you can check it to be sure?

Thanks - yes, this looks good! Should marginally speed up the rendering of graphs too