Support stack function

Closes #9218
The solution looks tricky so I post it early for some review.
This PR use GpuExpandExec to implement stack, which should be a generator in GpuGenerateExec.
When overriding GenerateExec, this PR will check if there is GpuStackMeta in it.
If so, it will reshape the childExprs of stack together with other childExprs of GenerateExec to the rows and columns we want, as a projections. Then we feed them into a GpuExpandExec.
TODO:

[x] Error handling: Error is handled by Spark.
[x] Test case that GenerateExec contains other thing (like other generator) manually: It is not allowed by spark.
[x] Add more test cases.
[ ] Performance test.

Some tests:
scala> Seq((1,2),(11,22)).toDF("a","b").selectExpr("*", "stack(1, a, b)").show
23/10/13 15:23:43 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(a#7 as string) AS a#21 will run on GPU
      *Expression <Cast> cast(a#7 as string) will run on GPU
    *Expression <Alias> cast(b#8 as string) AS b#22 will run on GPU
      *Expression <Cast> cast(b#8 as string) will run on GPU
    *Expression <Alias> cast(col0#11 as string) AS col0#23 will run on GPU
      *Expression <Cast> cast(col0#11 as string) will run on GPU
    *Expression <Alias> cast(col1#12 as string) AS col1#24 will run on GPU
      *Expression <Cast> cast(col1#12 as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(1, a#7, b#8) will run on GPU
      ! <LocalTableScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.LocalTableScanExec
        @Expression <AttributeReference> a#7 could run on GPU
        @Expression <AttributeReference> b#8 could run on GPU

+---+---+----+----+
|  a|  b|col0|col1|
+---+---+----+----+
|  1|  2|   1|   2|
| 11| 22|  11|  22|
+---+---+----+----+

scala> Seq((1,2),(11,22)).toDF("a","b").selectExpr("*", "stack(1, a)").show
23/10/13 15:23:57 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(a#41 as string) AS a#52 will run on GPU
      *Expression <Cast> cast(a#41 as string) will run on GPU
    *Expression <Alias> cast(b#42 as string) AS b#53 will run on GPU
      *Expression <Cast> cast(b#42 as string) will run on GPU
    *Expression <Alias> cast(col0#45 as string) AS col0#54 will run on GPU
      *Expression <Cast> cast(col0#45 as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(1, a#41) will run on GPU
      ! <LocalTableScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.LocalTableScanExec
        @Expression <AttributeReference> a#41 could run on GPU
        @Expression <AttributeReference> b#42 could run on GPU

+---+---+----+
|  a|  b|col0|
+---+---+----+
|  1|  2|   1|
| 11| 22|  11|
+---+---+----+

scala>  Seq((1,2),(11,22)).toDF("a","b").selectExpr("*", "stack(2, a)").show
23/10/13 15:24:09 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(a#69 as string) AS a#80 will run on GPU
      *Expression <Cast> cast(a#69 as string) will run on GPU
    *Expression <Alias> cast(b#70 as string) AS b#81 will run on GPU
      *Expression <Cast> cast(b#70 as string) will run on GPU
    *Expression <Alias> cast(col0#73 as string) AS col0#82 will run on GPU
      *Expression <Cast> cast(col0#73 as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(2, a#69) will run on GPU
      ! <LocalTableScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.LocalTableScanExec
        @Expression <AttributeReference> a#69 could run on GPU
        @Expression <AttributeReference> b#70 could run on GPU

+---+---+----+
|  a|  b|col0|
+---+---+----+
|  1|  2|   1|
|  1|  2|null|
| 11| 22|  11|
| 11| 22|null|
+---+---+----+

scala> Seq((1,2),(11,22)).toDF("a","b").selectExpr("*", "stack(2, a, b, 5, 6, 7 , 8 ,9)").show
23/10/13 15:24:16 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(a#97 as string) AS a#117 will run on GPU
      *Expression <Cast> cast(a#97 as string) will run on GPU
    *Expression <Alias> cast(b#98 as string) AS b#118 will run on GPU
      *Expression <Cast> cast(b#98 as string) will run on GPU
    *Expression <Alias> cast(col0#101 as string) AS col0#119 will run on GPU
      *Expression <Cast> cast(col0#101 as string) will run on GPU
    *Expression <Alias> cast(col1#102 as string) AS col1#120 will run on GPU
      *Expression <Cast> cast(col1#102 as string) will run on GPU
    *Expression <Alias> cast(col2#103 as string) AS col2#121 will run on GPU
      *Expression <Cast> cast(col2#103 as string) will run on GPU
    *Expression <Alias> cast(col3#104 as string) AS col3#122 will run on GPU
      *Expression <Cast> cast(col3#104 as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(2, a#97, b#98, 5, 6, 7, 8, 9) will run on GPU
      ! <LocalTableScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.LocalTableScanExec
        @Expression <AttributeReference> a#97 could run on GPU
        @Expression <AttributeReference> b#98 could run on GPU

+---+---+----+----+----+----+
|  a|  b|col0|col1|col2|col3|
+---+---+----+----+----+----+
|  1|  2|   1|   2|   5|   6|
|  1|  2|   7|   8|   9|null|
| 11| 22|  11|  22|   5|   6|
| 11| 22|   7|   8|   9|null|
+---+---+----+----+----+----+

scala> Seq((1,2),(11,22)).toDF("a","b").selectExpr("*", "stack(4, a, b)").show
23/10/13 15:24:23 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(a#143 as string) AS a#154 will run on GPU
      *Expression <Cast> cast(a#143 as string) will run on GPU
    *Expression <Alias> cast(b#144 as string) AS b#155 will run on GPU
      *Expression <Cast> cast(b#144 as string) will run on GPU
    *Expression <Alias> cast(col0#147 as string) AS col0#156 will run on GPU
      *Expression <Cast> cast(col0#147 as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(4, a#143, b#144) will run on GPU
      ! <LocalTableScanExec> cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.execution.LocalTableScanExec
        @Expression <AttributeReference> a#143 could run on GPU
        @Expression <AttributeReference> b#144 could run on GPU

+---+---+----+
|  a|  b|col0|
+---+---+----+
|  1|  2|   1|
|  1|  2|   2|
|  1|  2|null|
|  1|  2|null|
| 11| 22|  11|
| 11| 22|  22|
| 11| 22|null|
| 11| 22|null|
+---+---+----+

Better to give a detail description for your solution.

This solution does not guarantee to produce the same output order as Spark does, not sure if it will be an issue.
expandExec turns each row into several rows. The relative positions of such groups of rows in the output are correct, but the different rows of two groups may be interleaved.
An example:
scala> spark.time(spark.range(30L).selectExpr("id", "stack(3, 1L, 2L, 3L, 4L, 5L)").show())
23/10/27 05:44:26 WARN GpuOverrides:
!Exec <CollectLimitExec> cannot run on GPU because the Exec CollectLimitExec has been disabled, and is disabled by default because Collect Limit replacement can be slower on the GPU, if huge number of rows in a batch it could help by limiting the number of rows transferred from GPU to CPU. Set spark.rapids.sql.exec.CollectLimitExec to true if you wish to enable it
  @Partitioning <SinglePartition$> could run on GPU
  *Exec <ProjectExec> will run on GPU
    *Expression <Alias> cast(id#521L as string) AS id#531 will run on GPU
      *Expression <Cast> cast(id#521L as string) will run on GPU
    *Expression <Alias> cast(col0#523L as string) AS col0#532 will run on GPU
      *Expression <Cast> cast(col0#523L as string) will run on GPU
    *Expression <Alias> cast(col1#524L as string) AS col1#533 will run on GPU
      *Expression <Cast> cast(col1#524L as string) will run on GPU
    *Exec <GenerateExec> will run on GPU
      *Expression <Stack> stack(3, 1, 2, 3, 4, 5) will run on GPU
      *Exec <RangeExec> will run on GPU

+---+----+----+
| id|col0|col1|
+---+----+----+
|  0|   1|   2|
|  1|   1|   2|
|  2|   1|   2|
|  0|   3|   4|
|  1|   3|   4|
|  2|   3|   4|
|  0|   5|null|
|  1|   5|null|
|  2|   5|null|
|  3|   1|   2|
|  4|   1|   2|
|  5|   1|   2|
|  6|   1|   2|
|  3|   3|   4|
|  4|   3|   4|
|  5|   3|   4|
|  6|   3|   4|
|  3|   5|null|
|  4|   5|null|
|  5|   5|null|
+---+----+----+
only showing top 20 rows

Time taken: 52 ms

scala> spark.conf.set("spark.rapids.sql.enabled", "false")

scala> spark.time(spark.range(30L).selectExpr("id", "stack(3, 1L, 2L, 3L, 4L, 5L)").show())
+---+----+----+
| id|col0|col1|
+---+----+----+
|  0|   1|   2|
|  0|   3|   4|
|  0|   5|null|
|  1|   1|   2|
|  1|   3|   4|
|  1|   5|null|
|  2|   1|   2|
|  2|   3|   4|
|  2|   5|null|
|  3|   1|   2|
|  3|   3|   4|
|  3|   5|null|
|  4|   1|   2|
|  4|   3|   4|
|  4|   5|null|
|  5|   1|   2|
|  5|   3|   4|
|  5|   5|null|
|  6|   1|   2|
|  6|   3|   4|
+---+----+----+
only showing top 20 rows

Time taken: 63 ms

This solution does not guarantee to produce the same output order as Spark does, not sure if it will be an issue.

The order does not matter. We produce a different output order for join/etc. The only time the order matters is if the Exec indicates that there is a specific output order that it will produce. Like with SortExec.
https://github.com/apache/spark/blob/dc02991fa662c2f760315f190893cf09545e1b83/sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala#L49
There is no output order in GenerateExec.
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala
And the default when there is none, is no ordering
https://github.com/apache/spark/blob/dc02991fa662c2f760315f190893cf09545e1b83/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala#L62
So to match Spark we don't have to provide any specific ordering. And even if we need to change the ordering, that is fine because we can insert sorts as needed to match the ordering requirements of the original plan.

build

Looks good to me.

build

Some simple performance test
Data:<PHONE_NUMBER> length parquet files with schema "a string, b long, c double", generated by BigDataGen.
Code:
spark.time(df.selectExpr("*", query).selectExpr("count(*)").show())

query1 = stack(3, a, b, c, 'a', 1L, 0.5d, 'b', 2L, 1.5d)
query2 = stack(2, a, a, a, a, a, a)
query3 = stack(2, b, c, b, c, b, c, b, c)
query4 = stack(6, 'SUBOAUBSUBOUABOSUBVOAYVOAUBVOSYUVSOUSBOSUBOSHVYSUBVOSUBSOVUSV', 'a', 'a', 'a', 'a', a)
query5 = stack(12, 1, 2, 3, 4, 5, 6, 7, 8, 9)
query6 = stack(1, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25)
query7 = stack(25, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25)

Results:

Query
GPU (ms)
CPU (ms)
Speedup

query1
48537
57580
18.63%

query2
19733
23914
21.19%

query3
27682
38942
40.68%

query4
17670
33206
87.92%

query5
755
38606
51x

query6
524
12854
25x

query7
1215
73401
60x

Looks like when there is any requiredChildOutput, the speedup is not obvious, but if the parameter only contains literals, GPU is much faster than CPU.

The performance looks good enough for me to ship this.  Thanks for doing this @thirtiseven


Add specs for v1alpha1.Darkroom

Pull Request Test Coverage Report for Build 714678882

89 of 105 (84.76%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-17.3%) to 82.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/api/v1alpha1/zz_generated.deepcopy.go
0
16
0.0%

Totals

Change from base Build 714048207:
-17.3%

Covered Lines:
503

Relevant Lines:
608

💛  - Coveralls


Ionic input api issue with value and FormArray

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

If you use Angular 2 FormArray with ionic inputs to interpolate date into the value attribute of an ionic input or ion-textarea it will not work and will make the value undefined.
Expected behavior:

When using FormArray the data interpolated into value should stick and appear in the input box as the initial value.  If the data is interpolated into the actual input and not the value attribute then it will work for ion-input, but nothing works for ion-textarea
Steps to reproduce:

Related code:
  <form [formGroup]="myForm">
    <div formArrayName="formQuestions">
    <ion-list *ngFor="let question of formQuestions.controls; let i = index" [formGroupName]="i">
      <ion-input placeholder="Enter comment" formControlName="Comment1">{{detail.Comment}}</ion-input>

<ion-input placeholder="Enter comment" formControlName="Comment2" value="{{detail.Comment}}"></ion-input>

      <ion-textarea formControlName="Comment3" value="{{detail.Comment}}" placeholder="Enter comments"></ion-textarea>

<ion-textarea formControlName="Comment4" placeholder="Enter comments">{{detail.Comment}}</ion-textarea>

    </ion-list>
    </div>
</form>

Other information:

https://angular.io/docs/ts/latest/guide/reactive-forms.html#!#form-array
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.1.4
Ionic App Lib Version: 2.1.2
Ionic App Scripts Version: 1.0.0
OS: Windows 7 SP1
Node Version: v6.9.1

Hello, thanks for opening an issue with us. We will look into this (:

No problem @jgw96  I am always happy to help out the ionic team.


Rename JSONToMessages to OpenAIToMessages

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[x] other (please add here)

Closes #890. OpenAIToMessages is more recognizable and we can point to an actual reference for their chat completion APIs.
Changelog
What are the changes made in this PR?

Change all instances of JSONToMessages to OpenAIToMessages and "json" to "openai"

Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[x] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[x] run recipe tests via pytest tests -m integration_test
[x] manually run any new or modified recipes with sufficient proof of correctness
[x] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

[ ] I did not change any public API
[x] I have added an example to docs or docstrings

Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.00%. Comparing base (8e5750e) to head (4130f04).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

torchtune/datasets/_chat.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1643       +/-   ##
===========================================
+ Coverage   26.23%   69.00%   +42.77%
===========================================
  Files         295      295
  Lines       15080    15080
===========================================
+ Hits         3956    10406     +6450
+ Misses      11124     4674     -6450

Flag
Coverage Δ

69.00% <75.00%> (+42.77%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Okay, yeah there are two different ways that OpenAI allows inputs:

Just text input:

curl https://api.openai.com/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $OPENAI_API_KEY" \
  -d '{
    "model": "gpt-4o",
    "messages": [
      {
        "role": "system",
        "content": "You are a helpful assistant."
      },
      {
        "role": "user",
        "content": "Hello!"
      }
    ]
  }'

Multimodal input:

curl https://api.openai.com/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $OPENAI_API_KEY" \
  -d '{
    "model": "gpt-4o",
    "messages": [
      {
        "role": "user",
        "content": [
          {
            "type": "text",
            "text": "What'\''s in this image?"
          },
          {
            "type": "image_url",
            "image_url": {
              "url": "https://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Gfp-wisconsin-madison-the-nature-boardwalk.jpg/2560px-Gfp-wisconsin-madison-the-nature-boardwalk.jpg"
            }
          }
        ]
      }
    ],
    "max_tokens": 300
  }'

The current method supports ONLY the first situation.


Translation hook with bedrock-autoloader

What hook should I use to load translation when I use bedrock-autoloader to load my plugin  ?

I'm not sure if you ever got this working as you intended, but the way I use translations is by creating an languages/plugin folder in app that contains my-plugin-name-en_GB.mo and my-plugin-name-en_GB.mo.

Kudos en_US.mo should be implemented as well imho.

Kudos en_US.mo should be implemented as well imho.

I was just using en_GB as an example locale. It will work with others.

@m13kd m13kd.visvisualstudio.com Xbox Live Developer and Community Amassador for the LIVE team throughout all methods using Windows LIVE Sign In for a dynamic chance to provide the framework and allow me to give a opportunity to myself so as i shared the data legally to help you help me find a way to pay day to day expenses I develop securely in Monroe Georgia due to 10 years homelessness and theft and threats against my live FROM #stopcybertheives. Keep In touch when Its completed thanks. Michael C. Duggan ¤MSFT LIVE Rocks. Mike D PC HELP SERVICE, my donation line PayPal ID-<EMAIL_ADDRESS>WordPress is cool.
Sent from my MetroPCS 4G Android device
-------- Original message --------
From: Foxaii<EMAIL_ADDRESS>Date: 04/23/2015  8:34 PM  (GMT-05:00)
To: roots/bedrock<EMAIL_ADDRESS>Cc: "Michael C. Duggan"<EMAIL_ADDRESS>Subject: Re: [bedrock] Translation hook with bedrock-autoloader (#117)
I was just using en_GB as an example locale. It will work with others.
—
Reply to this email directly or view it on GitHub.


Test helpers without dependencies

@stephannv I haven't updated the tests or docs yet, but what do you think of this take on #278? Instead of depending on Capybara or Nokogiri or Rails, we provide basic functionality in Phlex::TestHelpers but you can include Phlex::Capybara::TestHelpers or Phlex::Nokogiri::TestHelpers instead, and can also include Phlex::Rails::TestHelpers.
You would probably combine these in your own view test helper, e.g.
module ViewTestHelpers
  include Phlex::Rails::TestHelpers
  include Phlex::Capybara::TestHelpers
end

I think this provides a bit more flexibility. For example, you could easily use a gem such as RSpec HTML Matchers if you wanted to.

@stephannv I haven't updated the tests or docs yet, but what do you think of this take on #278? Instead of depending on Capybara or Nokogiri or Rails, we provide basic functionality in Phlex::TestHelpers but you can include Phlex::Capybara::TestHelpers or Phlex::Nokogiri::TestHelpers instead, and can also include Phlex::Rails::TestHelpers.
You would probably combine these in your own view test helper, e.g.
module ViewTestHelpers
  include Phlex::Rails::TestHelpers
  include Phlex::Capybara::TestHelpers
end

I think this provides a bit more flexibility. For example, you could easily use a gem such as RSpec HTML Matchers if you wanted to.

This is great, I loved. If you want I can work on this, but I will only have free time on the weekend.


GPII-4141: Fix (again) bigquery api still being enabled error

Seems like Google rolled bigquery.googleapis.com as the new name for bigquery-json.googleapis.com, that’s when we got the first error with BQ/BinAuth (#510, #511, GPII-4141), and now, because it was causing a lot of issues, they rolled it back. And that's why we're seeing:
Error: Error applying plan:

1 error occurred:
    * google_project_services.project: 1 error occurred:
    * google_project_services.project: Error updating services: googleapi: Error 503: The service(s) ["bigquery.googleapis.com"] are still being enabled for project gpii2test-gcp-stg. This isn't a real API error, this is just eventual consistency.

This PR removes bigquery.googleapis.com and should fix the issue (at least until Google decides to roll it out again or smth.).
See relevant https://github.com/terraform-providers/terraform-provider-google/issues/4590.

LGTM


Added Window.OnClosed and sealed HandleClosed.

What does the pull request do?
Window had OnClosing and OnOpened virtual methods but no OnClosed. This PR adds that.
It also includes a change that I'd like feedback on: it seals Window.HandleClosed and HandleResized, because a user inheriting from Window shouldn't be messing with those (and Window is commonly used as a base class). This does leave open the question of whether we should seal those methods in PopupRoot too, and whether we should also seal HandlePaint and HandleScalingChanged? The Handle* methods are kind of internal APIs for communication with the platform impl.
Fixed issues
Fixes #2965

I'd seal the entire PopupRoot class

Sealing popuproot will break AvaloniaEdit. https://github.com/AvaloniaUI/AvaloniaEdit/blob/master/src/AvaloniaEdit/CodeCompletion/CompletionWindowBase.cs
What should be used instead?

Popup!

I am no expert but I thought there would be a reason for using Popuproot instead of Popup. I will try use that

@danwalmsley I tried using Popup instead and it seems to work. Opened pull request

@HendrikMennen
The way you are using internal positioning API here won't work properly with screen edges.
I think we need a way to supply an extra parameter for a placement rectangle inside the placement target that would get applied here: https://github.com/AvaloniaUI/Avalonia/blob/1a6e21518c601b9634064574554594425e307934/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs#L324
That way it would be possible to provide all required information for the positioner.


Change deprecated SessionComponent::setFlash() to FlashComponent

SessionComponent::setFlash() is deprecated since version 2.7.0. We should use Flash to create flash messages.
I have replaced all $this->Flash->set() calls to one of:
$this->Flash->success()
$this->Flash->warning()
depending on the context they are called on (operation done or exception).
I also updated the tests.
References:
https://book.cakephp.org/2.0/en/core-libraries/components/sessions.html#creating-notification-messages
https://book.cakephp.org/2.0/en/appendices/2-7-migration-guide.html#controller

Sent to master by mistake.


With pipenv 2022.11.4 or newer, installing a private package using --skip-lock option fails as it tries to look into the private index to install its dependencies

Similar to #5538, but I'm creating a new issue just in case.
Feel free to close this if it's the same problem.
Issue description
I've found with pipenv 2022.11.4 or newer, installing packages with --skip-lock option fails when Pipfile includes packages in a private repository.
our-private-package in the following Pipfile depends on some packages in the public pypi index, but Pipenv tries to install the dependencies from the jfrog index.
[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[[source]]
name = "jfrog"
url = "https://$JFROG_USER:$JFROG_TOKEN@PATH"
verify_ssl = true

[packages]
our-private-package = {version = "*", index = "jfrog"}

[requires]
python_version = "3.10"

I confirmed pipenv install --skip-lock worked with Pipenv 2022.10.25 but didn't work with 2022.11.4 or newer (the latest 2022.12.19 as well).
Is this a bug or expected behavior?
If it's expected then fine, I'll run pipenv lock beforehand and get rid of the use of --skip-lock option.
Expected result
pipenv install --skip-lock succeeds.
Actual result
Outputs are modified as it contained some internal info.
% pip install pipenv  # Currently this installs v2022.12.19
% pipenv install --skip-lock
ERROR: Could not find a version that satisfies the requirement public-package>=X.Y.Z (from our-private-package) (from versions: none)
ERROR: No matching distribution found for public-package>=X.Y.Z
[pipenv.exceptions.InstallError]: ERROR: Could not find a version that satisfies the requirement public-package>=X.Y.Z (from our-private-package) (from versions: none)
[pipenv.exceptions.InstallError]: ERROR: No matching distribution found for public-package>=X.Y.Z
ERROR: Couldn't install package: CENSORED

Steps to replicate
Written above.

Can't paste pipenv --support output as it contains some internal info.

@ysk24ok You can add install_search_all_sources = true option to your Pipfile in the pipenv section and should resolve the issue for you.  https://pipenv.pypa.io/en/latest/advanced/#specifying-package-indexes

@matteius Thank you for your response!
It did work, but IIUC it means pipenv install --skip-lock scans all indices, which I think is less secure.
So instead of adding the section, I'll stop using --skip-lock and run pipenv lock beforehand as the lock command only scans the pypi index.

That is a good point, because if you are skipping the lock file you don't have has validation, but that has always been true so I've always felt skip lock is bypassing the security benefits.


Fix number literal parsing to match YAML 1.2 spec

This commit fixes several inconsistencies with the implied number literal parsing versus the YAML 1.2 spec:

inf, +Inf, -INF, and so on are not valid values for infinity; the inf string must have a leading decimal point
There is no support in the spec for an 0b prefix for binary numbers (and the existing implementation didn't work anyway)
Octal numbers must be prefixed with 0o, and 077 should be interpreted as decimal 77

The implementation uses regular expressions derived from the spec to match untagged integer and float literals. Test have been expanded and updated accordingly.
Fixes https://github.com/hashicorp/terraform/issues/23770:
$ terraform console
> yamldecode("key: 0ba")
{
  "key" = "0ba"
}
> yamldecode("+.inf")
+Inf
> yamldecode("1.24")
1.24
> yamldecode("0o77")
63
> yamldecode("0xffff_0000")
4294901760

Awesome, thanks!


Benchmarking our Data

...we could use publicly available ADSB data, like suggested by Aviation II lecturer Theo Rindlisbacher: https://doi.org/10.5194/acp-24-725-2024

...this seems like the best option to check coverage:

@michaelweinold @dodedic I reviewed how we could best benchmark our data from the AeroDataBox.
I obtained an Excel table from Flightradar24 for the exact period during which we have our own data from the API. From Flightradar24, I used the data for commercial flights only (commercial passenger flights, cargo flights, charter flights, and some business jet flights). This was because the total flights category includes many other types that are likely not tracked by AeroDataBox, such as gliders, most helicopter flights, most ambulance flights, government flights, some military flights, and drones.
For plotting, I used the 7-day average since it matches the data we get from the AeroDataBox API. When comparing the plots, the overall curves look very similar. The main difference arises from the fact that with the API, we only have data for one week per month, compared to the daily data from Flightradar24. Overall, there seems to be a difference of around 20,000 flights between the two sources, likely because our API "only" tracks 3,144 airports, whereas Flightradar24 covers all active airports
If you have any additional ideas on how we could adjust the graph to better display this, I would love to hear them. (the plot is starting in May due to the Data we got from the API)
yearly_distribution_of_flights.pdf

The fact that the trends match is a good sign I would say.
I just had thought and had a look at the Excel file you mentioned and unfortunately they make no mention of how many of those flights are purely commercial passenger flights.
Do you think we could send an e-mail and ask about that statistic? Then we would have a great way of verfiying the ADB data.

Yes, that's the same problem I noticed when examining the data. I think it could be a good idea to write them! Didn't you already contact them? If so, you could also inquire about this when receiving a response.

@michaelweinold

commercial flights only (commercial passenger flights, cargo flights, charter flights, and some business jet flights)
https://github.com/sustainableaviation/demandmap/issues/11#issuecomment-2114328750

@arebe337, please update the Excel file in figures/benchmarking_data/FlightRadar_data.xlsx. The file must contain information on where the data comes from (in this case, at least a URL of the source). This brings my to another point: What exactly do the filters look like? Is it really just commercial? We could, for instance, discard corporate travel (business jets). But I guess this is what @dodedic already clarified:

and unfortunately they make no mention of how many of those flights are purely commercial passenger flights.
https://github.com/sustainableaviation/demandmap/issues/11#issuecomment-2114787923

Another question:

The main difference arises from the fact that with the API, we only have data for one week per month, compared to the daily data from Flightradar24.
https://github.com/sustainableaviation/demandmap/issues/11#issuecomment-2114328750

What am I missing here, @arebe337 & @dodedic? I though the API gave you coverage of the entire year, if we just query the number of connections (not the type of aircraft)? What does "one week per month" mean?
Finally:

If you have any additional ideas on how we could adjust the graph to better display this, I would love to hear them. (the plot is starting in May due to the Data we got from the API).

I think it will be difficult/impossible to add more resolution (flight category, etc.) to global statistics like the one you have already found from FR24. What I would suggest instead is to look at the our case-study routes in particular. There, we can directly compare FR24 and ADB data! Doing this for eg. 1 week is feasible even without an FR24 API.

@dodedic, benchmarking data is now scattered across different issues and PRs of the repo.
For instance:

California calculations are mentioned in https://github.com/sustainableaviation/demandmap/pull/36#issue-2317258793
Nigeria calculations are mentioned in https://github.com/sustainableaviation/demandmap/issues/30#issue-2298572973

Unfortunately, I won't have the time to go through your matrix generation code in detail (also because the code is currently not documented).
Could you fill in the table below, so I can add it to the poster?

Case Study
3rd Party Source
FR24
ADB (our data)

California

Nigeria.

S.frica

Case Study
3rd Party Source
FR24
ADB (our data)

California
OAG
-
x

Australia
OAG
-
x

Nigeria
OAG
x
x

...ok, maybe I had misunderstood - I thought we would look up benchmarking data for all three case study routes? Can you do a quick FR24-based check for the two remaining routes (California, Australia)?
It would be great to have all the numbers as a comparison for the poster - maybe collect them in an Excel sheet, with your calculation assumptions?

Ah I see the misunderstanding now! I can do that tomorrow, no problem!

@michaelweinold @arebe337
So here is the Excel with the calculations I made.
One major point I have is that we didn't actually benchmark against FR24 in-depth, since they do not give us historical data and ABD-Exchange never answered my request for a data dump on our routes. The only thing I did was a quick sanity check on this issue under "4. Estimate current and future demand of air travel route between both cities", where I looked at the different types of aircraft that fly that route on FR24 and averaged those numbers to compare against our ADB-data. This was just a quick sanity check.
With this not possible with FR24 on a bigger scale, I turned to Sabre/OAG to provide us with their seats/year data and did benchmarking of our ADB-data on our routes against their numbers. You can find the calculations in the Excel sheet.
With the USA route, the numbers match quite well, while for Nigeria and Australia we are off.
We might have to put some more thought into this in the next week...

@dodedic I can't open the excel sheet

Maybe with this one?
Otherwise it's just in the OneDrive folder where the airport data also is!

@michaelweinold @arebe337
I have made some further caculations on the topic of available seats on our routes.
On FR24, if you go to the airports page e.g. https://www.flightradar24.com/data/airports/lax and then look for all the airports we are looking at in our case study you will find the number of flights per week to all destinations just publicly there.

If we look at both directions for each city pair and then divide by seven we get the number of daily flights from FR24. I have added them to the Data Calculations Excel above. Here is what I found:

This suggests that the AAS matrices we made look quite okay, and the problem is in fact with the flights/day metric.
In my opinion the discrepancy comes maybe from the fact that some or all cargo flights are included the FR24/OAG data. I will investigate further...

@michaelweinold @arebe337
So to look further into the benchmarking of the ADB-data I now looked at all scheduled flights that are available on FR24 from all the case study routes to see if that would make a difference and put it in the blue "FR24 Daily" row.

I still got the same numbers as from the airport page (example MEL) and additionally, all flights that are there are PAX flights meaning that it can't be down to FR24 counting cargo flights on those routes.
What I did now is message ADB about this, so perhaps they know why we are encountering this "issue" on only these two routes (forgot to CC you):


add release note

Coverage remained the same at 33.818% when pulling 4fded4cfe3085222f19c289f56118b4d5cae0f62 on binyli/release-note into ce9b957018dae40418eb82ae375ef6d883501678 on master.


PDFs for non-US printing

Hi,
The British Lulu site does not allow you to chose the US Trade (6" x 9") size for the premium paperbacks. Is it possible to get a PDF file in another size, such as A5 or Royal?

Hey @Munksgaard, sorry for the long delay here, but the PDF's I'm sure could be reformatted—I honestly can't remember where I got them from. Good luck!


Disable Firefox welcome screen

Currently Firefox (profile) opens a welcome screen each time a new browser instance is created. This screen is not hosted locally and wastes CPU and bandwidth. To get rid of this we should set:
   profile.set_preference('startup.homepage_welcome_url.additional', '')

in splinter_firefox_profile_preferences().
I can make a PR if there is nothing related to this going on already.

please make a PR

this is done and released in the latest version

Thanks @bubenkoff - had missed your reply. Good work!


[Snyk] Security upgrade node from 20.3-bookworm-slim to 20.11-bookworm-slim

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to node:20.11-bookworm-slim, as this image has only 36 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Proof of Concept

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Proof of Concept

686
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210088
No Known Exploit

786
Incorrect Calculation of Buffer Size SNYK-DEBIAN12-GLIBC-6210099
No Known Exploit

786
Incorrect Calculation of Buffer Size SNYK-DEBIAN12-GLIBC-6210099
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Merged in upstream


Change network delete function

Modify network delete function to retry delete operation when it fails. This will allow the delete operation to be retried even when the ssh connection fails.

/lgtm
feel free to merge


Include latest multiwallet bug fix

Includes fix for https://github.com/OpenBazaar/multiwallet/issues/74

Coverage remained the same at 35.152% when pulling dedebe3acb905fae99c9790a46953fc681670b53 on update-multiwallet into<PHONE_NUMBER>6af5542d86522e86243ba8d4371775 on master.


add chat endpoint to available endpoints

@owainlewis
I've found that chatEndpoints are not available. So here is a fix.

Thanks. Looks good.


[FEA] Encrypted Spill Support

Is your feature request related to a problem? Please describe.
Spark supports encryption of intermediate results spilled to disk, and we will eventually need to support doing the same when GPU buffers are spilled to disk (e.g.: shuffles, broadcast data, etc).
Currently we only support spilling for shuffle.

@krajendrannv can you help clarify the requirements from users for encryption?

This has been implemented in #9454.


feat: add heic-converter

Description
Add a new extension or command, it convert HEIC images to JPEG and PNG
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This extension Image Modification includes this ability

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
As said before, we already have an image conversion extension that includes HEIC format (both ways). Does your extension adds something more that the linked extension doesn't do?

Hi, thank you for bringing this plugin to my attention. It has already encompassed the functionalities I was working on, so I will be closing this pull request.


Using transparent sync on CD

First off, I love Unicorn
This is just a question. And to keep it simple, let's say it is only about /sitecore/templates/my-templates
I would like to use transparent sync on the CD server when I deploy, this way I don't need to do a publish and rollback is simple.
On dev I will have
<include database="master" path="/sitecore/templates/my-templates" name="master-my-templates" />
But since the CD i running on web database, how can I use the unicorn files on CD, what is best practice.
Solution 1.
I could also include:

And then remember to publish from master to web before I commit unicorn files.
This could/will lead to human error :-(
Solution 2.
Copy the Master unicorn files to CD and then config transform the unicorn config, where I will replace the database="master" to database="web"
But is kind of smells like a hack
What is best practice? could use some advice
Kind regards
Christian

This setup would theoretically work, and now that transparent sync has been around for a while I think it could be ok. You're experimenting in new territory here - not to say that it won't work, but that there are no established practices around the technique. It is also likely that Transparent Sync performance is not quite at the same level as SQL based templates (make sure to turn data cache on), and you'll be defeating publishing for templates which might make the link database go out of date in regards to templates.
You'd probably, as you said, wish to transform the config to change the database to web on CD. You'd also want to duplicate the configs on CE and have them point at both master and web.

@cpalm Did you ever go forward with this? If so, what was your experience with it? Are you aware of anyone who has done this?
@kamsar Is this still experimental territory? Are you aware of anyone who has done this? Blog posts about it (my Google fu is failing here)?
I have been thinking about doing something similar to this for templates, renderings and other non-content items to get the benefits cpalm mentions.
Is the link database an order of operations for deployment? If the website was running when the sync of items happened, would the link database get updated?
Are there other things to worry about? Like a template gets deleted for an item that was deleted in master, but the delete didn't get published to web?


created website

NOTE:

Please fill out the template below

Did you read the instructions in the README?

Y

Have you read the instructions in CONTRIBUTING?

Y

Have you written this article by yourself? Have you taken inspiration from anywhere and then written it in your words?

[This website is created by me and megha070]

@Pallavi024 and @megha070 I have specifically mentioned what the site for the project should be. Please follow that. This is just a basic webpage. I want a fully functioning site as seen in the initial comments of the thread.
@shreyateeza , quoting from the CONTRIBUTING.md,

The maintainer will review your PR in an span of 2 days. Do not review other contributor's PR until said so by the maintainer himself.

I have not requested you to review AFAIK. Please don't repeat this

@jinojossy93 feel free to pull a request!

Pinging @Pallavi024 if you want to work at this (Will close this by tomorrow evening)

Yes I want to work on this
On Sun 30 Dec, 2018 10:18 pm Dhruv Apte<EMAIL_ADDRESS>wrote:

Pinging @Pallavi024 https://github.com/Pallavi024 if you want to work
at this (Will close this by tomorrow evening)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/the-ethan-hunt/first-timers-guide/pull/123#issuecomment-450572761,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae3EuqvtesbN-JMgOym-w4T4dxH7YEGeks5u-O5BgaJpZM4VLO5k
.


Absolute paths broken in Angular 12+ for templateUrl and styleUrls

Which @angular/* package(s) are the source of the bug?
compiler
Is this a regression?
Yes
Description
I am using Angular 13, upgraded from Angular 11 but after upgrading to Angular 12, the absolute paths stopped working for templateUrl and styleUrls.
When I was with Angular 11, I had the AOT complier on and it was working.
I'm needing to use absolute paths because I want to avoid having long relative paths and a lot of my components are using shared .scss and .html files for showing delete/restore confirm dialogs etc.
Here's an example of what I currently have in the components for templateUrl and styleUrls which is not working in Angular 12+ but still working in Angular 11.
@Component({
    selector: 'something',
    templateUrl: '/src/app/directory/directory/example.component.html',
    styleUrls: ['/src/app/directory/directory/example.component.scss']
})

If I change the above to use relative path like below then it works but it doesn't look nice to have so many ../../../
@Component({
    selector: 'something',
    templateUrl: '../../../../example.component.html',
    styleUrls: ['../../../../example.component.scss']
})

This is the templateUrl error I'm getting:
Error: path/to/directory/something.component.ts:9:18 - error NG2008: Could not find template file 'path/to/another/directory/example.component.html'.

templateUrl: 'path/to/another/directory/example.component.html',

This is the styleUrls error I'm getting:
Error: Module not found: Error: Can't resolve 'C:/Users/.../path/to/directory/path/to/another/directory/example.component.scss?ngResource' in 'C:\Users\...\frontend'

Error: The loader "C:/Users/.../path/to/directory/path/to/another/directory/example.component.scss" didn't return a string.

I've also tried adding paths like below to my tsconfig but it doesn't affect anything.
 "paths": {
      "@env": [
        "environments/environment"
      ],
      "@shared/*": [
        "app/shared/*"
      ],
      "@core/*": [
        "app/core/*"
      ],
      "~*": [
        "src/*"
      ]
    }

I've seen answers suggesting to use raw-loader but I'm not quite sure how it works and if that's even the right solution here. I think it might be a complier config problem but haven't figured anything out.
Here's what my angular.json looks like
{
    "$schema"<EMAIL_ADDRESS>    "version": 1,
    "newProjectRoot": "projects",
    "projects": {
        "frontend": {
            "projectType": "application",
            "schematics": {
                "@schematics/angular:component": {
                    "style": "scss"
                },
                "@schematics/angular:application": {
                    "strict": true
                }
            },
            "root": "",
            "sourceRoot": "src",
            "prefix": "app",
            "architect": {
                "build": {
                    "builder": "@angular-devkit/build-angular:browser",
                    "options": {
                        "outputPath": "dist/frontend",
                        "index": "src/index.html",
                        "main": "src/main.ts",
                        "polyfills": "src/polyfills.ts",
                        "tsConfig": "tsconfig.app.json",
                        "aot": true,
                        "assets": [
                            "src/favicon.ico",
                            "src/assets"
                        ],
                        "styles": [
                            "node_modules/animate.css/animate.min.css",
                            "src/styles.scss"
                        ],
                        "scripts": [
                            "node_modules/jquery/dist/jquery.min.js",
                            "node_modules/popper.js/dist/umd/popper.min.js",
                            "node_modules/bootstrap/dist/js/bootstrap.min.js"
                        ]
                    },
                    "configurations": {
                        "production": {
                            "fileReplacements": [
                                {
                                    "replace": "src/environments/environment.ts",
                                    "with": "src/environments/environment.prod.ts"
                                }
                            ],
                            "optimization": true,
                            "outputHashing": "all",
                            "sourceMap": false,
                            "namedChunks": false,
                            "extractLicenses": true,
                            "vendorChunk": false,
                            "buildOptimizer": true,
                            "budgets": [
                                {
                                    "type": "initial",
                                    "maximumWarning": "1mb",
                                    "maximumError": "10mb"
                                },
                                {
                                    "type": "anyComponentStyle",
                                    "maximumWarning": "1mb",
                                    "maximumError": "10mb"
                                }
                            ]
                        }
                    }
                },
                "serve": {
                    "builder": "@angular-devkit/build-angular:dev-server",
                    "options": {
                        "browserTarget": "frontend:build"
                    },
                    "configurations": {
                        "production": {
                            "browserTarget": "frontend:build:production"
                        }
                    }
                },
                "extract-i18n": {
                    "builder": "@angular-devkit/build-angular:extract-i18n",
                    "options": {
                        "browserTarget": "frontend:build"
                    }
                },
                "test": {
                    "builder": "@angular-devkit/build-angular:karma",
                    "options": {
                        "main": "src/test.ts",
                        "polyfills": "src/polyfills.ts",
                        "tsConfig": "tsconfig.spec.json",
                        "karmaConfig": "karma.conf.js",
                        "assets": [
                            "src/favicon.ico",
                            "src/assets"
                        ],
                        "styles": [
                            "node_modules/animate.css/animate.min.css",
                            "src/styles.scss"
                        ],
                        "scripts": [
                            "node_modules/jquery/dist/jquery.min.js",
                            "node_modules/popper.js/dist/umd/popper.min.js",
                            "node_modules/bootstrap/dist/js/bootstrap.min.js"
                        ]
                    }
                },
                "lint": {
                    "builder": "@angular-devkit/build-angular:tslint",
                    "options": {
                        "tsConfig": [
                            "tsconfig.app.json",
                            "tsconfig.spec.json",
                            "e2e/tsconfig.json"
                        ],
                        "exclude": [
                            "**/node_modules/**"
                        ]
                    }
                },
                "e2e": {
                    "builder": "@angular-devkit/build-angular:protractor",
                    "options": {
                        "protractorConfig": "e2e/protractor.conf.js",
                        "devServerTarget": "frontend:serve"
                    },
                    "configurations": {
                        "production": {
                            "devServerTarget": "frontend:serve:production"
                        }
                    }
                }
            }
        }
    },
    "defaultProject": "frontend"
}

Here's my tsconfig.json
{
    "compileOnSave": false,
    "compilerOptions": {
        "baseUrl": "./src",
        "outDir": "./dist/out-tsc",
        "forceConsistentCasingInFileNames": true,
        "strict": true,
        "noImplicitReturns": true,
        "noFallthroughCasesInSwitch": true,
        "sourceMap": true,
        "declaration": false,
        "downlevelIteration": true,
        "experimentalDecorators": true,
        "moduleResolution": "node",
        "importHelpers": true,
        "target": "es2015",
        "module": "es2020",
        "lib": [
            "es2018",
            "dom"
        ]
    },
    "angularCompilerOptions": {
        "strictInjectionParameters": true,
        "strictInputAccessModifiers": true,
        "strictTemplates": true
    }
}

And here's my tsconfig.app.json
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "./out-tsc/app",
  },
  "files": [
    "src/main.ts",
    "src/polyfills.ts"
  ],
  "include": [
    "src/**/*.d.ts"
  ]
}

Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
templateUrl error:
Error: path/to/directory/something.component.ts:9:18 - error NG2008: Could not find template file 'path/to/another/directory/example.component.html'.

templateUrl: 'path/to/another/directory/example.component.html',

styleUrls error:
Error: Module not found: Error: Can't resolve 'C:/Users/.../path/to/directory/path/to/another/directory/example.component.scss?ngResource' in 'C:\Users\...\frontend'

Error: The loader "C:/Users/.../path/to/directory/path/to/another/directory/example.component.scss" didn't return a string.

Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 12.2.1
Node: 14.17.0
Package Manager: npm 8.3.0
OS: win32 x64

Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1202.1 (cli-only)
@angular-devkit/core         12.2.1 (cli-only)
@angular-devkit/schematics   12.2.1 (cli-only)
@schematics/angular          12.2.1 (cli-only)

Anything else?
I think it's not finding the root directory because it's adding the absolute path to the end of the current path. See error.

Duplicate of https://github.com/angular/angular-cli/issues/20162

Duplicate of #20162
I don't know why you closed this issue.
As I said in the description it's working in Angular 11 with AOT complier on. It's not working in Angular 12+ with the same configuration.
I already looked into that issue. The error there isn't even the error I'm getting.

@alan-agius4 So what's the solution to avoid having ../../../../../../ ?


Compatibility with Cake 0.18

Hello,
Since yesterday's update of Cake to 0.18 I get the following error when I reference Cake.Json add-in:
Error: The assembly 'Cake.Json, Version=1.0.6059.1381, Culture=neutral, PublicKeyToken=null' is referencing an older version of Cake.Core (0.7.0). This assembly need to reference at least Cake.Core version 0.16.0. Another option is to downgrade Cake to an earlier version.
A temporary workaround is to downgrade Cake's version to 0.17 in tools/packages.config.
Any idea of what the problem can be?

I was able to do the temporary workaround by opening /tools/packages.config, and changing the version to 0.17.  Saved, ran cake again and it seems to be building normally now.

Latest version (<IP_ADDRESS>) is built against Cake 0.17 and this shouldn't be an issue anymore

I'm experiencing the same problem with version 0.22.0.
Any plan to update the package?

I confirm this is happening again with Cake version 0.22.0

To avoid breaking build you should pin cake and also any addins to specific versions. See here. Cake 0.22.0 introduced known breaking changes which requires addins to be recompiled

Thanks for the tip ! This is what I ended up doing.

Actually issue became a little bit more complicated now. Some plugins (like Cake.Npm) are already updated with Cake 0.22.0 support, as the result - they stopped to work with older versions of Cake. Of course you can manipulate with versions and try to workaround it with using specific versions of Cake and its' plugins. However how it works by default - it just unexpectedly started to fail for me on our nightly CI builds.
I took some action and made a PR to update Cake.Json with Cake 0.22.0 support - https://github.com/Redth/Cake.Json/pull/22
Would be good if author reviewed it and approved if everything is OK.

@Aleksanderis Besides pinning Cake you should also pin your addin versions since otherwise they can break your build anytime, or any addin can introduce some incompatibilities with either core Cake or any other addin. If you do this you can wait until all addins you're using are updated to Cake 0.22 and then update Cake / Addins in a controlled way. This is the recommended way to avoid this situation.
If you further want to reduce the risk of having your build break unexpectedly, you should also avoid dependencies on any internet resources (like the Cake website or nuget.org) by eg using a company internal cache for providing the packages.

@pascalberger , I know, everything is fine. It wasn't that something critical was broken. I just mentioned how it might happen "by default".;)


Disable unsupported paratimes

Problem
Currently all ParaTimes are enabled. Missing tooltip on hover for desktop & bottom tooltip on mobile.
Solution

add useGetBoundingClientRect hook, as it was the only way of getting the right measurement of the svg components. getBBox and ResizeObserver were not reliable;
bounding box recalculates on scale change;
add desktop tooltips;
add mobile fixed tooltip;

Links
https://www.loom.com/share/9a5631ad0ff04fbe8d97f2a77046165e

Not sure if I have some local issues, but it looks like graph is re-rendering app. I wonder if this can be a problem or it's related to issues below:

desktop: not able to see Emerald tooltip
mobile: can't see tooltips
mobile: not able to nav to Emerald

TODO: Refactor file structure after review complete


Help with .Net Wrapper!

Hello @ygpark ,
I was trying to use libewf.dll in .Net and then after some searching, I got to know that to use it I need to make a wrapper for it!
So I started searching for that and I found this repository.
All I know from your code that you made 2 projects, One for the Console application and other for the Class Library(which is for ewf.net.dll I guess?)....
I need you help for this!
Can you please tell me how you used libewf in your code? Is that Class Library generating the ewf.net.dll or you built it somehow?

Hi zeeshan.
I am korean. I can speak English just little bit.
Read this file part of visual studio 2019 at th end of file:
https://github.com/ygpark/bingrep/blob/main/GhostYak%2FLibrary%2Fewf.net%2Fsrc%2F컴파일.txt
You can complie or precompiled 3 files at this link:
https://github.com/ygpark/bingrep/tree/main/GhostYak%2FLibrary%2Fewf.net
I was sw developer. Now this is my hobby.
Good luck.
2024년 12월 28일 (토) 오후 4:55, zeeshan @.***>님이 작성:

Hello @ygpark https://github.com/ygpark ,
I was trying to use libewf.dll in .Net and then after some searching, I
got to know that to use it I need to make a wrapper for it!
So I started searching for that and I found this repository.
All I know from your code that you made 2 projects, One for the Console
application and other for the Class Library(which is for ewf.net.dll I
guess?)....
I need you help for this!
Can you please tell me how you used libewf in your code? Is that Class
Library generating the ewf.net.dll or you built it somehow?
—
Reply to this email directly, view it on GitHub
https://github.com/ygpark/bingrep/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGPEVGAW4H4OLEGI7JQ5L2HZKOXAVCNFSM6AAAAABUJSNAI2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DCNRQGY3DAMY
.
You are receiving this because you were mentioned.Message ID:
@.***>

libewf has already ewf.net library.
Following is in my case.
You must compile using msvscpp project with Visual Studio 2019 or newer
version.
(https://github.com/libyal/libewf/tree/main/msvscpp)

When install Visual Studio, You must select 'C++/CLI' option to compile '
ewf.net' project.

libewf msvcpp project contains bzip, zlib, dokan.
you must remove dokan project and ewf_test*** project, ewf***
project, pyewf project.
bzip project output type is dll. you must change dll to lib.

If you face error about some enum. Add 'ewf.net_handle.h' file or refer
to header and correct it.

https://github.com/ygpark/bingrep/blob/main/GhostYak/Library/ewf.net/src/ewf.net_handle.h
uhmm.
Describe your situation me.
2024년 12월 29일 (일) 오후 2:53, zeeshan @.***>님이 작성:

Thank you @ygpark https://github.com/ygpark ,
I compiled and got the libewf-2.dll from libyal/libewf repository, I was
just wondering how you compiled ewf.net.dll...
Because I didn't see anything in libyal/libewf repository about
ewf.net.dll!
Can you please tell me how did you compile it?
It will really help me a lot!
—
Reply to this email directly, view it on GitHub
https://github.com/ygpark/bingrep/issues/1#issuecomment-2564622388, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGPESL5G7DPPAPB7ZDVDD2H6E6RAVCNFSM6AAAAABUJSNAI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGYZDEMZYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


clinical_local_ctnorm issue

Dear all,
When I tried to run the 'CT normalize' module, I got the following error log:
6-Sep-2019 10:44:35 - Running 'CT normalize'
16-Sep-2019 10:44:35 - Failed  'CT normalize'
Undefined function 'clinical_ctnorm_job' for input arguments of type 'struct'.
In file "/Users/INCE/Documents/MATLAB/spm12/toolbox/Clinical-master/tbx_cfg_clinical.m" (???), function "clinical_local_ctnorm" at line 324.
The following modules did not run:
Failed: CT normalize
I've set the origin manually and I'm not using any lesion masking. Any ideas?
Thanks in advance,
Joselisa

Rename the folder
  /Users/INCE/Documents/MATLAB/spm12/toolbox/Clinical-master/

to
/Users/INCE/Documents/MATLAB/spm12/toolbox/Clinical


Null path in file metadata?

Debugging https://jira.niaid.nih.gov/browse/HEDWG2-1063 . It looks like the file level metadata for the referenced image goes like this is a blank object, or an object with null omeXml.
Please confirm it was so. The pipeline run was in QA, and the ID on the pipeline run was S9468.
If it was indeed so, please pass a null/missing metadata instead of that. Storing objects with no payload is a waste of storage.

@sevaa  -
We only provide the ome xml file in cases that it contains useful information.
The ome XML does not currently contain useful information in this workflow it's therefore not provided in this workflow.
So the current response is ..."fileMetadata": {}...
Please let us know if you'd like us to not provide fileMetadata in some other manner.

That's what my suspicion was. Can you please pass null instead, or don't add "fileMetadata" to the enclosing JSON object at all?

Hi @sevaa, can you verify these change in qa branch?

Not sure how.

@sevaa  - the fix is applied to the QA server, you should be able to retest if you like.

 Although this is not an empty object, that's still the opposite of what I'm asking for - a metadata object with no payload. So not fixed, I presume...

#368 doesn't address the issue. Replacing {} with {"omXml":null} is not what I was after. Please reopen this issue, or I'll create another.

The new response should be as follow,

If there is not omeXml, the response should be fileMetadata: null.
If there is omeXml, the response should be fileMetadata: {"omeXml": "/path/ab/c"}.

That's what I was after, yes. That's not the current behavior, as seen in QA - I'm getting {"omeXml": null} instead.

Retested, this time fileMetadata is null.


Version 0.7 for release

Changed version to 0.7, and release date in revision history to December 22, 2022.
What used to be two bullet items was merged into one at some point. Separated it back into two separate bullet items.
Added revision history summary for changes made in version 0.7, and moved revision history to be the first appendix, since we expect it to always be an appendix.

@mariobaldi Hopefully you don't mind if I am making this release without your final approval.  I have made very minor changes to the spec since your last approval a few days ago, preparing it for release of version 0.7, which might be today!


Update azure-stack-update-1807.md

Bug 2830461: PNU telemetry and failure alert does not properly consider auto-remediation

@justinincarnato : Thanks for your contribution! The author, @brenduns, has been notified to review your proposed change.

@justinincarnato @Brenduns adding to the release notes in a different PR. #Please-Close


Feature/manager for sports and underlying

fixed errors with manager not set in event_create_op
added hardfork protection code
removed duplicate code
added GRAPHENE_WITNESS_ACCOUNT as default manager
added reflect for manager member of event_group_obj
changed test accordingly

closing, duplicate


changing JavaWriter to JavaPoet in README.md file

I've noticed that Dagger is using JavaPoet, what can be read from pom.xml file, but information about changed name of this library is not reflected in README.md file. In this PR I'm updating JavaWriter to JavaPoet in README.md file.
I've already signed CLA during my previous contribution to Square's repository.
Regards,
Piotr

So it is! I completely forgot Jesse made that change.


cranelift: Rename iadd_carry/ iadd_cout instructions

👋 Hey,
While implementing iadd_cout for aarch64 I realized that the output of the carry bit depends on signedness of the operation. If we implement it as unsigned we only signal overflow on 0xFF + 1, and if we implement it as signed we signal overflow on 0x7F + 1
Thus  should we rename this operation to sadd_cout to keep consistency with our other operations that depend on signedness (i.e. sdiv/udiv)? The operation seems to be signed based on the existing test suite.
Does the existence of sadd_cout also imply that we should have uadd_cout?
The same question applies for iadd_carry, but not for iadd_cin.

Makes sense. I would have expected iadd_cout to be unsigned. As the name carry is often used for unsigned overflow AFAIK. For example x86 has the carry and overflow flags for unsigned cq signed overflow.

Does the existence of sadd_cout also imply that we should have uadd_cout?

IMO yes there should be.

It looks like we also discussed the naming of the new iadd_overflow_trap instruction last week, and it got renamed to uadd_overflow_trap.
And it looks like folks preferred uadd_overflow_trap instead of uadd_carry_trap, so maybe we should apply the same naming convention here? (I'd be in favor of this.)


vim8 +packages compatibility

Hello @hynek,
Unfortunately, your plugin does not work in my recent vim8 setup anymore.
Here is  a minimal example:
def f(x,
           y):
    """ scriptnames:
    [...]
    114: /usr/share/vim/vim80/indent/python.vim
    115: ~/git/veight/vim/pack/extra/start/vim-python-pep8-indent/indent/python.vim                                                [...]
    >>> set smartindent?
    nosmartindent
    """
    d = {"k1": 1,
                 "k2": 2
            }
    return d

# vim: set ts=8 sts sw=4 sts:

It is installed with vim's native packaging system, located in ~/.vim/pack/*/start
After some investigation, I found out that vims native indent/python.vim gets sourced before the indent file of this plugin (because of vim8s +packages) and sets b:did_indent. I fixed it by changing the guard to b:did_pep8_indent. I know that this fix is somewhat violating vim conventions but for now, it works for me. Could you think of a cleaner solution to integrate in vim8 packages system?
Best Regards,
lgalke

Sadly I can’t since I’m on Spacemacs now for a while and @blueyed is doing all the work. 🤷♂  Which reminds me that I should probably transfer the repo to him…

(Daniel please remove your fork of the repo so I can transfer it to you; there’s no reason for me taking any credit for the work you do.)

So I found the reason here vimtex#645.
When you .vim is a symlink it does get loaded after internal filetype, indent, etc scripts.
Solution: Clone your vim directory directly into ~/.vim..

@hynek
I've deleted my fork now, so you can transfer the ownership.

Transfer initiated.  Thanks and good luck! :)

Thanks! :)

(maybe you should rewrite License and Authorship though, it reads really weird now :))

To complete @lgalke answer, another solution is to add this to your .vimrc:
set runtimepath=$HOME/repos/dotfiles/vim,$VIMRUNTIME

In this case, .vim can stay a symlink.
Link: https://github.com/lervag/vimtex/issues/586


Linker errors when adding door_position_sensor feature  (CON-1339)

There are inconsistencies in the "add" and "create_door_state" functions in the  door_position_state namespace that lead to linker errors.
esp_matter_feature.h
namespace door_position_sensor {

uint32_t get_id();
esp_err_t add(cluster_t *cluster);
} /* door_position_sensor */

esp_matter_feature.c
namespace door_position_sensor {

uint32_t get_id()
{
    return (uint32_t)DoorLock::Feature::kDoorPositionSensor;
}

esp_err_t add(cluster_t *cluster, config_t *config)
{
    if (!cluster) {
        ESP_LOGE(TAG, "Cluster cannot be NULL");
        return ESP_ERR_INVALID_ARG;
    }
    update_feature_map(cluster, get_id());

    /* Attributes not managed internally */
    attribute::create_door_state(cluster, 0);

esp_matter_attribute.h
attribute_t *create_door_state(cluster_t *cluster, uint8_t value);

esp_matter_attribute.c
attribute_t *create_door_state(cluster_t *cluster, nullable<uint8_t> value)

Environment

ESP-Matter Commit Id: b3da7b
ESP-IDF Commit Id: a322e6

@sdrasti Thanks for reporting, will fix this issue. Also, can you please share the data model that you are trying to create, so that we can try to replicate and add some tests around it and this won't happen again.


Demo fails

I am unable to connect to the demo website. Could you help check the website? Thanks!

+1 the same as me.

@zkyntu @rbli-john
sorry, due to the expiration of the domain name, the demo fails, i will fix it in recent weeks.


Unable to resolve existing errors when launching project.

I have tried most solutions - reimporting, deleting scripts and adding manually, used correct assemblies with NuGet Manager, all file names are correct.
Out of the box, this project come's with the attached errors.

I just tested this project with a fresh clone and I don't get these errors.  I think those show up when you don't have the required plugins for those AWS imports.  Check your plugins folder and make sure it has everything that's in the repository.  Are there any other errors above those?  Not sure what's going on here.  Also, what platform are you set to build with or are building on?

Ok great! Well make sure to update us if you end up remembering what the issue was - thanks!

Hey!
Also had the same problem that was resolved by cloning the project.
However when I copied the dll-s from this project to my own I got the same error. Seems like the problem was that the dll-s were imported a native plugins instead of managed. It was resolved after I imported them using rightclick in editor - > Import instead of simply dragging them to Unity. So anyone experiencing this error - check that dll Type is Managed in editor.


LDA+U cannot be used with spin-orbit coupling in Siesta

Dear Xu
In the Siesta examples, you use LDA+U, while I check almost all versions of Siesta in GitLab and
all of them have the following error inside the Src/setup_hamiltonian.F:
'LDA+U cannot be used with spin-orbit coupling.'
Which version of Siesta did you use in TB2J_examples?
Best regards,
Mojtaba

Dear Mojtaba,
Indeed the current public versions of Siesta cannot use LDA+U+SOC.
You can try this branch if you really need it
https://gitlab.com/jjunquer/siesta/-/tree/ldau-so
Otherwise it can wait for this to be merged into the main branch.
Best regards,
HeXu

Thank you.
On Fri, Jul 9, 2021 at 4:20 PM mailhexu @.***> wrote:

Dear Mojtaba,
Indeed the current public versions of Siesta cannot use LDA+U+SOC.
You can try this branch if you really need it
https://gitlab.com/jjunquer/siesta/-/tree/ldau-so
Otherwise it can wait for this to be merged into the main branch.
Best regards,
HeXu
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mailhexu/TB2J_examples/issues/1#issuecomment-877129339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMTVF3KTVVMGKLDONCVGSH3TW3O67ANCNFSM5ACS6YCA
.


Warining messages in logs

Since version 0.106.x i get warinings in HA logs like:
2020-03-09 00:15:46 WARNING (MainThread) [homeassistant.helpers.service] Unable to find referenced entities switch.slave2_shenzhen_neo_electronics_co_ltd_wall_switch_1_channel_switch_5

I am also getting these warnings. I get them on my master instance running 0.109.2. Is this something I need to worry about?

Not sure, probably not. I think home-assistant just keeps tracks of all entities now - and might not know from where the remote entities are coming from. If everything is still working, I wouldn't worry about it.

For some reason I see this in my production instance, but I cannot reproduce it in my development instance. It's a bit annoying as debugging is much harder when running on HassOS.


App cache question

Hello, I have a question.
I have observed that the more songs I play, the larger the cache memory.
What is stored in the cache? Are there perhaps the songs for later playback cached or what is stored there between?

Yes ! The cache is mostly used to store the songs that you play.
The way it works is while you are playing the beginning of the song, the end gets cached, basically.
I just never delete the cache because i think that most phones out there have huge storage but maybe not so huge data plans, and playing back the songs from cache does not require any data, so to me it is a win.
If you are worried about the cache taking up too much space, i could add an option to delete cache in Blade, or to auto-delete oldest entries when the cache is bigger than a certain limit ?

Okay my English is mega bad and I use a translator.
Do I understand correctly that if I play a song once it will be cached and if I play the same song again it will be played from the cache and will not consume any data volume?
A way to limit the cache would be great. There should be an option in the settings to set the cache size to 2,4,6,8,...

Yes, you are right
Yes, i think it will be easy to implement, and it would indeed be a great option

There's nothing going on here.

There's nothing going on here.


policy: add RulesSelect field to SearchContext

RulesSelect specifies whether or not to check whether a rule which is
being analyzed against its SearchContext has already been determined to select
the labels in the To or From fields within the SearchContext. This is used
to avoid using EndpointSelector.Matches() while analyzing rules if possible,
since said function is costly in terms of performance. Currently, this flag
is always false, so no functional change is intended here. In the future, the
list of rules that will be analyzed when generating policy for an endpoint will
only be the list of rules that select the endpoint.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.1%) to 43.992% when pulling 52a6eb3d40baf6f512cce4e0c1ef9240767b5565 on pr/ianvernon/searchcontext-new-field into 0a22a1d453a3887016bc628abe4c179845591abe on master.

test-me-please

@aanm the intention of this PR is to be small / show that there is no breakage when this functionality is added. There is no change in existing behavior because the field is never set to 'True' anywhere in the code base. To get to the point where it will be used is quite involved. I was planning on getting this done over time in a series of PRs to make it easier to merge. I'm not sure how to achieve that goal and to do what you request.
The description illustrates why this will be useful in the future, and it passed tests. I think we should be able to merge code that isn't used yet and doesn't break anything, as this promotes small, easy to review PRs.

@aanm closing this PR and will fold these commits into the PR which consumes them.


Add symfony 7 support

Add support for symfony 7 CSS selector; issue #107

This change is

Can we get this merged and released?
Thanks!


feat: add grpc health interface

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Add GRPC health interface.

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1195 (cfe3981) into main (c6c05f6) will increase coverage by 0.10%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   46.49%   46.59%   +0.10%
==========================================
  Files         133      133
  Lines       10513    10526      +13
==========================================
+ Hits         4888     4905      +17
+ Misses       5070     5067       -3
+ Partials      555      554       -1

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
46.59% <33.33%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/rpcserver/rpcserver.go
38.15% <0.00%> (-0.51%)
:arrow_down:

scheduler/rpcserver/rpcserver.go
25.00% <100.00%> (+3.94%)
:arrow_up:

client/daemon/peer/piece_broker.go
89.74% <0.00%> (-2.57%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
57.69% <0.00%> (-0.54%)
:arrow_down:

...ent/daemon/peer/peertask_piecetask_synchronizer.go
56.70% <0.00%> (+9.75%)
:arrow_up:


Incorrect fullscreen scaling on secondary displays

If a secondary monitor has different aspect ratio to main monitor full screening scaling does not work properly. Videos were taken with a 16:9 main display and 16:10 and 4:3 secondary displays
Videos.zip

Duplicate of #5153


Relative reference in generated .d.ts file in a monorepo

When generating a .d.ts file, typescript is including a relative reference for an import, which is imported as a module.
import { a } from "@ts-bug/a";

export function b(text: string) {
  return a(text);
}

generated a definition file:
/// <reference path="../../a/index.d.ts" />
export declare function b(text: string): import("@ts-bug/a").AText;

In this case it is in a mono-repo which may be confusing things, but the reference should be the same as the import.

TypeScript Version:
3.0.3, but also happens with 3.1.0-dev.20180901

Search Terms:
relative reference paths
generated reference relative
Code
I have created a repo with a simple reproduction here https://github.com/wgcrouch/ts-bug
Expected behavior:
The reference /// <reference types="@ts-bug/a" />
Actual behavior:
The reference generated is /// <reference path="../../a/index.d.ts" />
Related Issues:
https://github.com/Microsoft/TypeScript/issues/26439

Probably a duplicate of the linked related issue

@RyanCavanaugh Yes - but this one has a reproduction repository so it should be easier for somebody to get to the root cause on.

In my case the generated .d.ts file contains syntax errors – is that related to this issue?
/// <reference<EMAIL_ADDRESS>/>

declare const myFunc: () => O<'moduleE'.E<any>>;

The above is invalid, hence definitely a bug.
The file causing this error is as follows:
declare module 'moduleE' {
    export interface E<T> {
…

If I remove the declare module, it's at least generating an @import() around the module name.

@andypillip if you could open up a new issue with a repro, that's be great, it's definitely not (directly) related to the issue in the OP here.


build: fix file path in workflows

:tada: This PR is included in version 0.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No module named diffusers.models.dual_transformer_2d

File: ...\ComfyUI\custom_nodes\ComfyUI-AniPortrait\src\models\unet_2d_blocks.py
Line 9: from diffusers.models.dual_transformer_2d import DualTransformer2DModel
Throw Exception: No module named 'diffusers.models.dual_transformer_2d'
I see this model inside diffusers\models\transformers folder
from diffusers.models.TRANSFORMERS.dual_transformer_2d... - works

Importing DualTransformer2DModel from diffusers.models.dual_transformer_2d is deprecated and this will be removed in a future version. Please use from diffusers.models.transformers.dual_transformer_2d import DualTransformer2DModel

Importing DualTransformer2DModel from diffusers.models.dual_transformer_2d is deprecated and this will be removed in a future version. Please use from diffusers.models.transformers.dual_transformer_2d import DualTransformer2DModel

I did but It also report no module error


Add Docker Compose Usage example to readme

I'm bit unsure about this one. Communication between containers in compose relies heavily on links and is bit different from the pattern dnsdock uses. I don't want to give impression that dnsdock is designed around a compose use case.  This still expects user to manually define the bridge ip to <IP_ADDRESS> and doesn't work with multiple environments(that compose users could expect).
Ideally this could be something like:
    servicea:
        image: username/servicea
        links:
          - dnsdock
        dns: dnsdock

But there needs to be a way to turn dnsdock hostname into the IP defined in /etc/hosts first to make this work.
Maybe create a a wiki page for this instead and add only a link in the readme. A good place would be before the SELinux block.

To get this merged I think we need following updates:

note that this only works with one compose per daemon
moving the new block to less prioritized location, somewhere after setup section.

Not agreed to merge this.
Link between containers shall use docker network


invites todo

[x] texts
[x] invite link landing page url
[ ] what initiate the bounty redemption
[ ] should copying the invite url also include a  text

[ ] card reminder after two weeks wallet wasnt opened (just once)
[x] bounty from user level
[x] native share should include text  with url

@Esfir-E open questions
what initiate the bounty redemption - currently user need to open the invite page to trigger it
new question: what about the new invitee bonus?
options:

after claim invitee triggers bonus redemption for both inviter and invitee
inviter opens invite page and trigger bonus redemption for both

should copying the invite url also include a text - when user press "copy" (on desktop, not native share)

replaced by #2768


Add support for GitHub Merge Queues

When using GitHub Merge Queue to merge a PR, the event name will be merge_group rather than pull_request.

@mars-lan  thanks!
can you help verify that the event properties contain -
    const {pull_request} = context.payload     const base = pull_request?.base.sha     const head = pull_request?.head.sha
base/head sha?
send a link to the docs

There doesn't appear to be pull request details available in a merge group payload -> https://docs.github.com/en/webhooks/webhook-events-and-payloads#merge_group

We need a way to compare two different commits
If you want to add support to that in the code I will merge it

github.event.merge_group.base_sha == github.event.pull_request.base.sha
github.event.merge_group.head_sha == github.event.pull_request.head.sha


install dependencie reactjs-popup

Description
Installing a dependency package for: reactjs-popup
Fixes

What work was done?
npm install reactjs-popup --save
Why was this work done?
after points submission button is clicked a "popup" confirmation will display
What feature / user story is it for?
feature/point/share
Any relevant links or images / screenshots

Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[ ] Not necessary

Checklist

[x] My code follows the style guidelines of this project
[x] My changes generate no new warnings
[x] There are no merge conflicts

In order to keep the dependencies package light and simple we have decided to work with andD components for this popup feature


Tool to manual delete unreferenced content from file

As we get to a point of enabling marking of unreferenced content, we need tools to prove to ourselves that it works correctly.
Using search pipeline for that is too imprecise and slow.
As such, I propose we build workflow (maybe it's a node script, maybe it's some localStorage flag that we can flip in prod) that would delete all unreferenced content in a file, such that we can experience if it works correctly or not.
Combined with some telemetry like handle resolution logging, we could find and address issues faster.

https://github.com/microsoft/FluidFramework/pull/5539 - I am adding a test mode that can currently be enabled via loader flags. In this mode, data stores that are unreferenced are immediately deleted from the container runtime's data store context list. I think its a start and we can build on it.

@vladsud I added a runtimeoption and localStorage flag that can be enabled to delete unreferenced data stores as soon as GC runs. Is there anything else we need to do for this or can I close this one?

Talked to Vlad. The runtime option that we currently have is good enough for this. Closing this out.


NavigationView in 2.6 has extra margin

Describe the bug
In the latest WinUI 2.6 pre-release (2.6.0-prerelease.2104300001) There's seems to be a margin between the NavigationView's Pane and the Frame inside of it
Steps to reproduce the bug

Steps to reproduce the behavior:

Create a NavigationView with a few MenuItems and a Frame like so:

<muxc:NavigationView
    x:Name="SettingsNavView" Grid.Row="1"
    IsPaneToggleButtonVisible="False" IsBackButtonVisible="Collapsed"
    IsSettingsVisible="False" IsPaneOpen="True"
    PaneDisplayMode="Left" OpenPaneLength="150"
    Height="550" Width="520">
    <muxc:NavigationView.Resources>
        <SolidColorBrush x:Key="NavigationViewExpandedPaneBackground" Color="#5000ff00"/>
    </muxc:NavigationView.Resources>
    <muxc:NavigationView.MenuItems>
        <muxc:NavigationViewItem Icon="Play" Content="Menu Item1" Tag="SamplePage1" />
        <muxc:NavigationViewItem Icon="Save" Content="Menu Item2" Tag="SamplePage2" />
        <muxc:NavigationViewItem Icon="Refresh" Content="Menu Item3" Tag="SamplePage3" />
        <muxc:NavigationViewItem Icon="Download" Content="Menu Item4" Tag="SamplePage4" />
    </muxc:NavigationView.MenuItems>
    <Frame x:Name="SettingsFrame" Background="#50ff0000">
    </Frame>
</muxc:NavigationView>

Expected behavior
The child Frame should be adyacent to the NavigationView's pane unless a margin is explicitly stated in the code.
Version Info

NuGet package version: Microsoft.UI.XAML 2.6.0-prerelease.210430001
(I manually added 21H1 version 19043 to the table as it was not in the template)

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2021 Update (19043)
Yes

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

I get the same issue with a horizontal top NavigationView. Content margin is always 48 pixels left, 12 pixels top.

@karenbtlai and @ranjeshj FYI

The content margin you described has been removed. The fix will happen in the next (pre-)release.

The content margin you described has been removed. The fix will happen in the next (pre-)release.

Thanks, good to hear!
I'll close this issue my self 😄


Fixed spelling in README.md

New Seneca user here. I'm about to deploy to production in an enterprise setting over the next few days here. I'm really fired up about the potential, both what Seneca can offer me as a product/devops manager, as well as that of the project and vision as a whole.
Hopefully I can offer a little help here and there in order to polish the project's presentation to provide a more professional and legitimized taste to potential new users poking around. Overall your community should be very proud of what you guys have been able to build!
Cheers!

thank you @jaamison