Drop unused dataplane vars

ref:

https://github.com/openstack-k8s-operators/install_yamls/pull/810
https://github.com/openstack-k8s-operators/openstack-operator/pull/765

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

@fao89 Hi! just a hint: The values touched here are only mock data used to test that the install_yamls logic we have to parse the Makefile defaults works, so those ones are not used to deploy and there is no strict need to make them match the content of main in install_yamls. If for the sake of consistency you want to patch them to match I'm ok with it, but I'd not loose too much time trying to get this patch to work.

recheck

@rebtoor could you please take a look?

/approve


Check if oauth apps are enabled before running any /apps commands

Summary
This check was removed in apps plugin 1.0
This change can wait for a dot release 1.0.1
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-42915

This check was removed in apps plugin 1.0

@mickmister - would help to point to the change/commit that removed it to provide full context here(e.g. - why was it removed?)

Codecov Report

Merging #316 (5568ea9) into master (c6066f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   28.17%   28.17%
=======================================
  Files          76       76
  Lines        4479     4479
=======================================
  Hits         1262     1262
  Misses       3088     3088
  Partials      129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6066f1...5568ea9. Read the comment docs.

@catalintomai Looks like it was a drive-by change in this refactor PR https://github.com/mattermost/mattermost-plugin-apps/pull/251

@DHaussermann Maybe this is something @dipak-demansol can test?

@mickmister I see an issue on this PR that maybe you could try to reproduce.
When Enable OAuth 2.0 Service Provider is set to false the /apps binding no longer appears.
The biding response shows only null

This is different from cases where the binding is occasionally unavailable. The binding remains unavailable after various refreshes and channel changes.
This does not occur when oAuth Apps are enabled.
This does not occur on the marketplace build

@mickmister the issue mentioned above ☝  https://github.com/mattermost/mattermost-plugin-apps/pull/316#issuecomment-1101563210 does not reproduce on the production release. Does it seem likely this PR introduces it?
I can re-test master if needed.

@levb Can you please take a look at the remaining issues for this PR. No worries if you think it can wait

/update-branch

/update-branch

Thanks for testing the PR @javaguirre :+1:


Pods stuck in pending after helm install

Having an issue that seems similar to others posted, but I can't seem to find anything that resolves the problem.
Setup a pretty bare install of microk8s with dns, storage, and helm modules enabled.
After running a helm install the pods needing storage are stuck in pending.
kubectl describe on the pod gives me the "pod has unbound immediate PersistentVolumeClaims" message
kubectl describe no and microk8s.inspect reports attached.
I'm SUPER new to kubernetes. I was able to run this exact helm install with the default minikube installation, but minikube puts storage in /tmp, I can't figure out how to change it, and that makes me itchy.
I appreciate ANY help you can provide!
inspection-report-20190825_221031.tar.gz
kubectl describe no.txt

Bah! Please disregard: my helm configuration yaml was referencing a storageclass name that didn't exist (standard instead of microk8s-hostpath).
Containers are creating or running now, so if there's still a problem it ain't storage. Sorry to be a pest!


[MM-10824] Close permalink on delete of focused post ID

Summary
Close permalink on delete of focused post ID
Ticket Link
Jira ticket: MM-10824
Checklist

[x] Has UI changes

Device Information
This PR was tested on: [iOs simulator and Android emulator]
Screenshots
iOS:

delete of post on permalink view
delete of parent post of a comment's permalink

@saturninoabril is this for 1.9? if so can you please change the base branch?

I missed that. Yup, it's for 1.9.  Done rebase.  Thanks!


Read from multiple shards

On exact requests make use of hashing function (if already available at this point)
On list/search requests, query each shard concurrently or sequentially, aggregate results

Complete, but keep open until released.


Fix: Flaky Transaction Test

#skip-changelog
:scroll: Description

Fix potential cause of flaky test.
:bulb: Motivation and Context

Closes #803
:green_heart: How did you test it?
Run tests.
:pencil: Checklist

[x] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[x] All tests passing
[x] No breaking changes

Codecov Report

Merging #807 (3c78dfa) into main (f3eb151) will increase coverage by 3.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   89.83%   92.92%   +3.09%
==========================================
  Files         114       17      -97
  Lines        3670      608    -3062
==========================================
- Hits         3297      565    -2732
+ Misses        373       43     -330

Impacted Files
Coverage Δ

dart/lib/src/protocol/sentry_device.dart

dart/lib/src/protocol/dsn.dart

dart/lib/src/version.dart

dart/lib/src/protocol/sentry_stack_frame.dart

logging/lib/src/logging_integration.dart

dio/lib/src/sentry_dio_extension.dart

dart/lib/src/protocol/sentry_message.dart

dart/lib/src/sentry_span_context.dart

dart/lib/src/transport/http_transport.dart

dart/lib/src/sentry_stack_trace_factory.dart

... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3eb151...3c78dfa. Read the comment docs.


Service call error

Tried to call the following service:
service: carbu_com.get_lowest_fuel_price_on_route
data:
  fuel_type: diesel
  country: BE
  from_postalcode: '2470'
  to_postalcode: '2490'
  ors_api_key: '123xyz_real_key'

Getting the following errors:
This error originated from a custom integration.

Logger: homeassistant.helpers.script.websocket_api_script
Source: custom_components/carbu_com/utils.py:422
Integration: Carbu.com (documentation, issues)
First occurred: 14:41:48 (2 occurrences)
Last logged: 14:43:08

websocket_api script: Error executing script. Unexpected error for call_service at pos 1:
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 452, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 685, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1849, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1889, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/config/custom_components/carbu_com/__init__.py", line 128, in handle_get_lowest_fuel_price_on_route
    station_info = await hass.async_add_executor_job(lambda: session.getPriceOnRoute(country, fuel_type, from_postalcode, to_postalcode, ors_api_key))
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/carbu_com/__init__.py", line 128, in <lambda>
    station_info = await hass.async_add_executor_job(lambda: session.getPriceOnRoute(country, fuel_type, from_postalcode, to_postalcode, ors_api_key))
  File "/config/custom_components/carbu_com/utils.py", line 422, in getPriceOnRoute
    assert from_location is not None
AssertionError

And
Logger: homeassistant.components.websocket_api.http.connection
Source: custom_components/carbu_com/utils.py:422
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 14:41:48 (2 occurrences)
Last logged: 14:43:08

[546767443936] Error handling message: Unknown error (unknown_error) Jorim Tielemans from <IP_ADDRESS> (Mozilla/5.0 (Linux; Android 13; A063 Build/TKQ1.221220.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/114.0.5735.53 Mobile Safari/537.36 Home Assistant/beta-10008-d81913b7-10008 (Android 13; A063))
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 647, in handle_execute_script
    await script_obj.async_run(msg.get("variables"), context=context)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1533, in async_run
    await asyncio.shield(run.async_run())
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 410, in async_run
    await self._async_step(log_exceptions=False)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 454, in _async_step
    self._handle_exception(
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 477, in _handle_exception
    raise exception
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 452, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 685, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1849, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1889, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/config/custom_components/carbu_com/__init__.py", line 128, in handle_get_lowest_fuel_price_on_route
    station_info = await hass.async_add_executor_job(lambda: session.getPriceOnRoute(country, fuel_type, from_postalcode, to_postalcode, ors_api_key))
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/carbu_com/__init__.py", line 128, in <lambda>
    station_info = await hass.async_add_executor_job(lambda: session.getPriceOnRoute(country, fuel_type, from_postalcode, to_postalcode, ors_api_key))
  File "/config/custom_components/carbu_com/utils.py", line 422, in getPriceOnRoute
    assert from_location is not None
AssertionError

Indeed, it seems the OpenRouteService response is not stable any longer. The convertion of postal codes to city's seems to fail, also for postal codes that used to work in the past.
I already experimented with here api instead of OpenRouteService, but I couldn't get it to work properly neither so far.

please try with new release 4.1.0 with new (experimental) API. Documentation updated too (no more API key required). But only very limited tests executed...

Great, seems to work for me!


Polymer 2 support

This is really great work!
I am very interested in testing your components. Unfortunately my project uses Polymer 2. Do you know whether the components work in Polymer 2 in hybrid mode?

Unfortunately, I didn't test nvd3-elements in Polymer v2.

Ok, I'm going to try it myself and report back.

Thank you. That will be great.
On Sun, May 21, 2017 at 9:29 PM nicolasr75<EMAIL_ADDRESS>wrote:

Ok, I'm going to try it myself and report back.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/saeidzebardast/nvd3-elements/issues/19#issuecomment-302949012,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2tD___TWwlia_eDp7ML1nx54vpURZuks5r8G2DgaJpZM4NgeKe
.

I tested line, pie and discrete-bar in Polymer v2 and so far it works as expected! bower adds a 'resolution' section to map the old polymer version demanded by nvd3-elements to 2.0.0.
The only thing I have not yet been able to get working is make the charts fill 100% of the container. I set the flex-size and auto-resize attributes and omitted explicit height and width attributes. Both line and discrete-bar charts get rendered to big in y-direction.
Assume I have an (empty) container div that fills 100% of the browser window which I simply checked by setting its background-color. As soon as I place a chart with flexSize in it, a y-scrollbar appears because the chart is too big.
Do you have any advice on that? How to correctly use flexSize and viewBoxHeight/Width?

Please create a demo (https://plnkr.co/).

I tried to create a demo but got stuck when trying to create a chart. The Polymer stuff works but I don't know how to correctly import nvd3-elements. Do you know what is missing? Here is the plunker.
Apart from that I noticed that I didn't correctly understand the viewport thing. I found a lot of stackoverflows now about responsive d3 charts but I do not yet understand how to make an nvd3-element chart fill the container. Without specifying height/width/viewPortHeight/viewPortWidth/flexSize the chart is stretched to the full width of the container which is half the way. I guess in the end I will have to set the height in code :-(
Sorry for bothering you with this but I thought in the age of responsiveness it would be a great feature to easily have the chart fill the container. Any more ideas?

You need to set the height for NVD3 Charts. If you check samples on nvd3.org, you will see the height settings. I'll try to make charts more responsive while switching to Polymer 2.0.

Ok, I tried it and was suprised how much time it took until I got it all sorted out :-( In case anyone else has this problem I shortly sketch my solution:
the chart is supposed to always fill the containing element, initially and after window resizing. The containing element is itself either set to height: 100% or part of a flexbox. Initializing must be deferred until the clientHeight property of the element is available! For auto-resizing the window.onresize event can be used but of course should be debounced. As of now there seems to be almost no information and examples about the new Polymer 2.0 debouncing APIs, except this great SO post.
In the attachedCallback I have this for the initialization:
setTimeout(function() {
	this.$.barChart.height = this.clientHeight;
	this.$.barChart.refresh();
}.bind(this), 0);

In the ready callback I have this for auto-resizing:
window.addEventListener('resize', function() {
	this._debouncer = Polymer.Debouncer.debounce(
		this._debouncer,
		Polymer.Async.timeOut.after(200),
		function() {
			this.$.barChart.height = this.clientHeight;
			this.$.barChart.refresh();
		}.bind(this));

}.bind(this));

Hey Guys,
Is there any news on when this will be available?


how to stop these overwhelming message D/eglCodecCommon(10813): setVertexArrayObject: set vao to 7 (7) 32 53

flutter --version
Flutter 1.12.13+hotfix.8 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (5 weeks ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0

How to stop these messages when i run my application on debug mode It's overwhelming and hide my own message and any error
D/eglCodecCommon(10813): setVertexArrayObject: set vao to 7 (7) 32 53

Those messages are not from Flutter.

Those messages are not from Flutter.

where is that from? I get the same messages in a new project

@chinmaygarde you didn't answer the question and your message doesn't help in any ways.

Flutter logs to syslog. So do other applications (including system services) running on the device. My comment was alluding to the fact this particular log was not introduced by the Flutter engine or the framework. Because of this, this isn't actionable.


Supporting nested type?

Is there any plan to supported nested type? https://www.elastic.co/guide/en/elasticsearch/reference/6.3/nested.html

Hello. So far none.
You should not use this anymore. You should use this:
AWS Kinesis


Wrong 1-n relation nullable inference from fluent API

Bug description
Hello there :)
Imagine an DB with users which may have profiles and Profiles which always have a user. But when using prisma client to get a user from a profile via fluent API, the profile is considered as nullable which is incorrect. This exemple use one-to-one relations but one-to-many relations are concerned too
It means this guide is broken :/
How to reproduce

Users MAY have one profile
Profiles HAVE one user

import { PrismaClient, User } from '@prisma/client'

const prisma = new PrismaClient()

async function main() {
  const user: User = await prisma.profile // <-- cannot assign User | null to User
    .findUniqueOrThrow({
      where: { id: 1 },
    })
    .user()
  console.log(user)
}

async function workingMain() {
  const profile = await prisma.profile.findUniqueOrThrow({
    where: { id: 1 },
    select: {
      user: true,
    },
  })
  const user: User = profile.user // <-- no error but don't user fluent API
  console.log(user)
}

main()
  .catch((e: Error) => {
    console.error(e)
    process.exit(1)
  })
  .finally(async () => {
    await prisma.$disconnect()
  })

Expected behavior
Since Profile as a non-nullable User one-to-one prisma.profile.findUniqueOrThrow(/* ... */).user() cannot NOT be null
Prisma information
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlite"
  url      = "file:./dev.db"
}

model User {
  id      Int      @id @default(autoincrement())
  name    String
  profile Profile?
}

model Profile {
  id     Int    @id @default(autoincrement())
  bio    String
  user   User   @relation(fields: [userId], references: [id])
  userId Int    @unique
}

Environment & setup

OS: Windows
Database: SQLite and MySQL
Node.js version: 16.16.0

Prisma Version
prisma                  : 4.1.0
@prisma/client          : 4.1.0
Current platform        : windows
Query Engine (Node-API) : libquery-engine 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Default Engines Hash    : 8d8414deb360336e4698a65aa45a1fbaf1ce13d8
Studio                  : 0.467.0

Ducplicate of https://github.com/prisma/prisma/issues/5715
Sorry for the repost (completly forgotten)


[Migration Tools] Add Neo SDK as Resource Module

Create a separate resources module and include the resources-neo-sdk module there.

Fixed with: https://github.com/SAP/xsk/commit/aef7d81a9ea216e01e6e4724823c25909ce020b5


Stylus support

How could one makes this plugin work with stylus url()?
It is being ignored.

This plugin only supports styling solutions which use webpack for resolving url(..) calls. I've never used stylus, but unfortunately, it looks like they don't use webpack and implemented something on their own. I'll have to check if it is possible to hook into their url resolution. Or do you already know if this is possible and how?

My bad it's totally picked by your plugin 👍


Completed challenge tasks

Hello!
I have completed the challenge. Below are some notes about what I did.
I've added a missing requirement to requirements.txt.
I took the challenge docs at their word about it being images that should be displayed inline (the ultimate format of the image was left in question, so I left this open, imagining that for the purposes of the challenge the client could display any image MIME type).
I was going to add a unit test for the management command but given that there was no precedent in the project, I left this out.
Thanks,
Ross

Closing without merging (as that would make the test redundant for anyone else ;-))


[Feature] Remove HDFS for HDFS_USER_ROOT_PATH config

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Problem Description
No response
Description
set the config var HDFS_USER_ROOT_PATH with a "file://" scheme, and make sure Linkis works
Use case
No response
solutions
No response
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

I will fix this


As a new user, I want to retrieve data from local storage

... so that I can access past data that I have inputed.

Addressed by #111.


wiki: clarify Assembly Policy for crypto

Current Assembly Policy establish general guidelines for inclusion of assembly implementations. However there is some confusion about it application to crypto.
I think we should clarify the following questions:

Are assembly implementations of new (to go) modes/hashes/block-ciphers allowed at all?
If they are allowed, we should have a list of deprecated stuff, that is intended  to be slow e. g. rc4.
Are there any additional requirements for testing crypto asm?
Can I (or anyone without great background in crypto) +2  straightforward cases e. g. https://go-review.googlesource.com/c/go/+/125316  ?
If we are not going to accept new assembly implemntaions, than we must do something with CLs sent before creation of assembly policy, that are still in review, e. g. https://go-review.googlesource.com/c/go/+/109135

/cc @FiloSottile  @aead

/cc @mundaym @Quasilyte

I agree that the assembly policy is a bit vague and think that there should be a bit more guidance about assembly code. So I'll try to answer some questions from the perspective of an external contributor.

Are assembly implementations of new (to go) modes/hashes/block-ciphers allowed at all?

I think prohibiting assembly implementations in general is probably not a good idea. However, the bar for new assembly code should be quite high. Personally I think there should be evidence that:

the primitive is commonly used (e.g. as (important) part of TLS)
the assembly code improves performance significantly
the primitive is often part of a performance-critical path

The primitive should also be standardized as an RFC (or similar).
Additionally if the primitive is not "state-of-the-art" anymore it should be less likely to accept new assembly implementations. No new assembly code should be accepted for a broken primitive - except there is/are very strong arguments to do so.
For existing assembly code I think new code can also be added if:

the amount of assembler code is reduced (and ideally the performance improves, too) (e.g. golang/x/crypto/poly1305
the amount of assembler code is quite small compared to its performance improvements (already mentioned by the AssemblyPolicy)

Again we should not try to optimize "legacy"/out-dated primitives if not really needed.

If they are allowed, we should have a list of deprecated stuff, that is intended to be slow e. g. rc4.

Agree here. There should be a list of packages for which assembly code won't get accepted - e.g. because existing asm code was removed...

Are there any additional requirements for testing crypto asm?

Should it be possible to test all crypto (asm) code against BorringSSL (dev.boringcrypto)? @FiloSottile
IMO there should be (probabilistic) tests against the reference Go implementation additionally to
predefined test vectors.

the amount of assembler code is quite small compared to its performance improvements (already mentioned by the AssemblyPolicy)
The AssemblyPolicy should clarify on how performance gain is small (10% ? 30%?)

The problem is the stdlib doesn't comes with the interfaces (mainly net/http/encoding) for the users to choose the libs them want. If the users wants to improve the performance they have to build up the entire stdlib dependency path all by themselves or just endure the bad performance of stdlib.
IMHO we should at least maintain all the stdlib related (not legacy)  asm code.

The AssemblyPolicy should clarify on how performance gain is small (10% ? 30%?)

Hm, I don't think just defining a minimum improvement is enough - leaving aside I don't know what the concrete number would be. For example it's probably not worth to accept a 20% improvement if this would add 2-3K lines of assembly.  So it's probably more about the ratio of code (complexity) to speed up. However I don't know how this can be formalized.

IMHO we should at least maintain all the stdlib related (not legacy) asm code.

In general agree here. But I don't think it's worth to add new code if the requirements mentioned above aren't fulfilled.

The problem is the stdlib doesn't comes with the interfaces (mainly net/http/encoding) for the users to choose the libs them want.

That sounds like a separate proposal to file.

Current list of open CLs tagged crypto-assembly: https://go-review.googlesource.com/q/hashtag:"crypto-assembly"+(status:open)

Folding into #37168. These are all good questions that I'd like us to provide clear answers for (except maybe an explicit performance ration at which we bring in assembly, because I think it will always be a judgement call based on a number of hard to capture factors).


Catch exception if git reference already exists when creating

This would always throw an error because the tag would be created on PR open/sync and then on merge we would tag the same commit and fail.
Change-type: patch
Signed-off-by: Miguel Casqueira<EMAIL_ADDRESS>

@balena-ci I self-certify!


Crash when scene contains a Bezier curve on 3.2 beta

Describe the bug
I'm using the 3.2 beta and if you simply add a Bezier curve to the scene then export the scene using the gltf exporter with the default configuration, blender will crash. This does not happen with 3.1.2.
To Reproduce
Steps to reproduce the behavior:

Open application
Add a Bezier curve
Export the scene with default settings

Expected behavior
I'm not sure what should happen with the curve, I'd imagine it would just get ignored during the export. Surely, the application shouldn't crash though.
Version

OS: windows
Blender Version: 3.2 beta, the exact build is blender-3.2.0-beta+v32.018acc568893-windows.amd64-release.

Confirmed.
Seems this is from Blender core code, not from this addon, because exporting with Blender 3.1 and addon master --> exports OK.
See https://developer.blender.org/T98237

Seems the original bug is now fixed in Blender.
Waiting until tomorrow to test on a build that includes the fix

Confirmed that problem is now solved on Blender side, so this bug is also fixed.
Note : Curves are not ignored if we choose option to export loose edge and loose vertices. Curve are converted to mesh and exported.

That was quick, thanks!


Support custom grid label format

Adds the parameter labelFormat to the grid layer, so that a custom label format can be specified. E.g.:
{
  "type": "grid",
  "labelFomat": "%1.0f %s",
  ...
}

By default, if the unit is meters no decimals will be shown. If the unit is degree max. 6 decimals are used, and otherwise the original logic which tries to find a "nice" formatting is used.
Closes #332

Looks good for me, thanks :-)


"Format not recognised." for m4a files

When I try to read an m4a file via
import soundfile as sf
data, samplerate = sf.read('test.m4a')

I get the following error:
soundfile.LibsndfileError: Error opening 'songs/test.m4a': Format not recognised.

Is m4a not supported? Or am I doing something wrong? The file plays just fine e.g. in VLC, was encoded by "Lavf60.3.100".

M4A is not supported. Soundfile is based on libsndfile, and libsndfile does not support M4A, as it is encumbered by patents. The last M4A patents will expire in 2028 (base profile) and 2031, so expect support to be added some time after that.

Ah, good to know. Thanks a lot for your answer.


Features new pages

Created page works
Created page About me
Done styles both desktop and mobile

@tsohleDev cant open a new review request as its showing as open on dashboard


Fix return type for IO#read without a length

From the docs:

If length is omitted or is nil, it reads until EOF and the encoding conversion is applied, if applicable. A string is returned even if EOF is encountered before any data is read.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Mb0TPiZEYNRqwR
→ https://go/builds/bui_Mb0TcvRe4BgDkP

This causes about 100 new type errors on Stripe's codebase. I'll look at how easy it is to autocorrect those, but I don't have a gut sense on how long it will take to hear back from me.

Most of them are autocorrectable and the rest are easy to fix manually. Thanks for the change!


Update src README to move develop docs

Per discussions on DMSP meeting, moving developer docs to top-level README and linking to new online TBD github.io page

I like it a lot. My only note would be to flair up the link to the github.io site so it's more noticeable, with emoji or something. I can take a stab if that's helpful.

Not sure the " @jordanpadams " works for the steward line on the readme page (to link to the user). I just change it back to an email barring further testing.

Style and content works. The links won't, presumably, for all the reasons
they didn't work before, but I had a README demo that managed to fix those
problems around somewhere, so they're soluble and we can get them into the
template.
-Anne.
On Tue, Apr 26, 2022 at 1:16 PM Trent Hare @.***> wrote:

Not sure the " @jordanpadams https://github.com/jordanpadams " works
for the steward line on the readme page (to link to the user). I just
change it back to an email barring further testing.
—
Reply to this email directly, view it on GitHub
https://github.com/pds-data-dictionaries/template/pull/29#issuecomment-1110052864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBV2QHY5VNMLQDT5VPNQETVHAQHRANCNFSM5UJHHIGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Show quantitative progress during deisctl install/start

In the process of installing and starting a Deis cluster via deisctl, it would be nice to see a more quantitative progress of how much of the process is left to go as well as quell questions of "is it even doing anything?" when slower components (like builder) are building/deploying.
Some suggestions that have been thrown out include:

showing the deisctl logs for the component that's currently being started (obviously this would be verbose and probably a bit too much for first time users, but it'd be awesome to have for automated tests)
showing a [step N] of [step M] type progress meter
showing a physical progress bar of some sort

SGTM. I also augmented a local branch to add timers to deisctl to show how long each provision sub-step took (including each component's start time). I was thinking that would be an optional debug flag to enable. Let me know if you want that code.

@carmstrong I think we should add that. Maybe even enable by default.

I think we should add that.

Here's some code to play with. Note that the global flag I created isn't being recognized. I never had a chance to go back to this. https://github.com/carmstrong/deis/commit/f51ca65cd8a63b76563c667fc2f3bf1c9e4518bf

This is not something we'll be able to get to for the LTS release (#4776) and deisctl is going away in deis v2 so I'm closing this. Thanks!

Perhaps an enhancement request to helm would be useful?


feat: extend handle info type

Context
handle type needs to be updated to contain more information like images and points on the blockchain where the handle was created.
Proposed Solution
Important Changes Introduced

Let's hold on this until https://github.com/input-output-hk/cardano-js-sdk/pull/750 is merged, as that's the correct sequence for the upgrade.


Halting when uploading 0 bytes files.

When attempting to SFTP upload an empty file (with 0 bytes in size) the upload halts (neither raises an error, no exits the program).
The client machine where the program is executes is Windows the remote one is Amazon Linux 2.
One might wonder what is the use case for such files. Sometime programs create programx.lock files which are used as a persisted on file system boolean switch.

Most likely same issue as #100, see my fix

Many thanks!! This has been resolved in the next release


wip: feat: add support ecmaversion (fixes #110)

please do not merge -- since it's just a WIP. 😄

@Aladdin-ADD Any progress on this one?


Delete Book which not free now

the book 《Ruby on Rails Tutorial 原书第 2 版》 is not free now , So , delete it .

Thanks for this correction!


embedding constraints

Does UMAP currently support specifying any embedding constraints?
In the past I've found it useful when doing dimensionality reduction to specify targets for a few key inputs. For example, if embedding a UMAP of RGB colors on to 2D one can make the output more predictable by specifying that the darkest input go to the left and the lightest to the right. Currently I can get the same effect by rotating and scaling the UMAP embedding after the fact (which can be automated), but a more direct and flexible way would be to introduce an ability in the API to pin specific inputs to target destinations in the embedding.

I don't know any way of doing that with the current code, but I agree that it certainly makes a lot of sense. I'll add this as a feature request, and hopefully I can add it as a feature in the near future.

Thanks Leland - encouraged that this idea is not DOA let me motivate this a bit more providing a sample use case, proposed API, and baseline implementation.
One use case is when there really is an approximate low dimensional embedding lurking in the higher dimensional data. Here one could attempt to make a more canonical view which could be compared across different datasets, etc. For example, suppose the data was approximately a 2D doughnut embedded in 3D space - in my motivating case I'll make this a (noisy) HSV colorwheel within an RGB cube:
		h = np.random.random()
		s = np.random.uniform(0.5, 1.0)
		v = np.random.uniform(0.8, 0.9)
		data[n] = colorsys.hsv_to_rgb(h, s, v)

UMAP generally has no problem recovering the structure of this data:

However, when running it multiple times with different seeds for generating the data the UMAP "view" of the colorwheel slice will be arbitrarily rotated, translated, and even flipped. To save space I'll animate results across 3 runs:

One simple and flexible solution to constraining the embedding would be the ability to specify "pinned data" to UMAP.fit() which constrains certain inputs to be assigned destination locations in the embedded space. In my example I'm going to find the most extreme points on each axis (ie: the index locations for the reddest, greenest, and bluest values) and assign them target points in a simple lookup table:
	pinned_data = [[max_red, [0, 3]], [max_green, [6, 10]], [max_blue, [10, 0]]]

So first here's a plot showing just these three pinned points:

And if we pass these three destinations to UMAP.fit() we can get an embedding is constrained to not move these three selected inputs:
	u = fit.fit_transform(data, pinned_data=pinned_data)

The result is that even when we change the seed to generate three different random datasets, the results are much easier to compare against each other.

You could even imagine aggregating these results across multiple data sources by combining the embedded outputs or even just overlaying the graphs directly with some transparency.

Now my current "implementation" is super brain-dead. All I do is repeatedly force-move each pinned point in the embedded space each epoch before calling the optimize_fn.
    for n in range(n_epochs):
        if pinned_data is not None:
            for p in pinned_data:
                head_embedding[p[0]] = p[1]
        optimize_fn(...

So this version really only works by taking some liberties with n_neighbors, n_epochs and cherry picking a bit. But it communicates the idea - so if we are not put off too much by my API decisions around this and are willing to push this further, I can take a shot making this more general by also having the pinned_data influence the initial embedding which I think would make this more general.

Thanks for the explanation. Your approach is not so fr off from what I had in mind. I was actually thinking of making it a little more general and having a mask (boolean vector) of fixed points.  Thus in the internal optimization we would simply check if a point is fixed or not before updating/moving it. If done right this should be relatively cheap and not slow things down noticeably. This opens up other possibilities as well, such as making the transform a little cleaner (all the training data will simply be declared fixed).
The downside of this approach is that we would still need some level of better front-end API on top of that to facilitate your use case (since setting up an initialization and designated fixed points would be a little much to expect of end users in general).
I would certainly be interested in seeing a PR if you feel you have something semi-ready to go of course.

Great to hear you thinking along similar lines. No, I don't have any better implementation - just was trying to communicate that use case more concretely.
There is another use case I come across frequently: grid layout. Here's a prototypical use case: flag layout by color:

My current codebase for this first generates a 2D umap scatterplot:

But then does a followup Linear Assignment Problem solver step to move points to the nearest grid location.

Assuming umap doesn't currently have a means for doing discrete layouts like this, we could potentially discuss whether this use case would also be a possible form of an allowable embedding constraint.

Embedding constraint-wise that's certainly a little more complicated to implement directly. It certainly isn't impossible, but would require a different approach. I'll certainly keep it in mind however.

I might have a better proposal for how to implement this. Going back to my original toy problem:

embedding a UMAP of RGB colors on to 2D one can make the output more predictable by specifying that the darkest input go to the left and the lightest to the right

Perhaps this could be done with a custom output_metric(a,b) that - in the X direction only - combines the existing output metric (euclidean) with (i think) the dot product of (b-a) and a preferred cardinal direction in the original space (in this example the higher dimension RGB "brightness vector" goes from (0,0,0) to (1,1,1)).
Just saying this out loud for feedback 😅 - if it seems loosely sane I'll try it out and report back.


[ZEPPELIN-777] Math formula support

What is this PR for?
This PR adds support for formatting math formula formatting in %html display system using MathJax library.
What type of PR is it?
Feature
Todos

[x] - Format math formula with MathJax library

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-777
How should this be tested?
try run following codes.
%md
When \\(a \\ne 0\\), there are two solutions to \\(ax^2 + bx + c = 0\\) and they are
$$x = {-b \pm \sqrt{b^2-4ac} \over 2a}.$$

Note MathJax works better with markdown.parser.type property set pegdown, in markdown interpreter. With default markdown4j parser, some formula is not well displayed. (for example, ax^2) I think this will not be a big problem because of we'll remove markdown4j https://github.com/apache/zeppelin/pull/1594
%sh echo -e "%html \$\$a = b\$\$"

%spark println("%html $$b = c$$")

Screenshots (if appropriate)

Questions:

Does the licenses files need update? yes
Is there breaking changes for older versions? no
Does this needs documentation? yes

cc @1ambda @AhyoungRyu

@AhyoungRyu @anthonycorbacho addressed your comments.

Tested and it works well as expected 👍

So cooool! 👍

It works with dev mode (grunt serve) but doesn't work if you build source with mvn.
Attaching screenshot:

@Leemoonsoo awesome work! so happy to see this coming through!
I am running into the same problem as @minahlee Thoughts on why mvn build wouldn't make this come out right?

@minahlee @rawkintrevo I have fixed the problem. Now packaged version works as well.

@Leemoonsoo still not working for me, but it could be on my end- I have a hell of a time with git
Did a fetch /hard reset within the last hour.
$ git fetch leemoonsoo
$ git reset --hard leemoonsoo/zeppelin-777
$ mvn clean package -DskipTests
<build success>
$  bin/zeppelin-daemon.sh start

Cleared browser cache / history / app data.

@rawkintrevo I clean cloned this PR, build and tried with browser cache clean, but couldn't reproduce the problem. Could you see zeppelin-web/dist/jax directory after the build?

lgtm. +1 to merge
again, awesome add @Leemoonsoo

Thanks @rawkintrevo and @minahlee for the review.
Merge to master if there's no further comment.

I build a distribution from source code but it's failed because of missing /jax /extesions/
Did you guys test this case?
How to fix it?
Thanks.

@giaosudau Hi! Thanks for sharing the issue :)
Could you please share your building command line and error log?
I don't know why, but I guess MathJax library wasn't downloaded from bower.

@tae-jun
No error at building source code.
But the error happens when I deploy with ZEPPELIN_SERVER_CONTEXT_PATH is /zeppelin/

@giaosudau Thanks for the prompt response!
So you mean it doesn't happen without ZEPPELIN_SERVER_CONTEXT_PATH?
I've never used that option so I might not be helpful ^^;
But could you please check $ZEPPELIN_HOME/zeppelin-web/bower_components/MathJax/jax directory exists? To ensure that bower downloaded dependencies well 😄

@tae-jun
I checked there is a folder MathJax in the source I use to build but what I mean here is the URL calling jax lib was wrong. You can check the URL of jax in the image above.
=>>> It must be append /zeppelin/jax will be right and I already tested if I change url to this it works.
That mean configuration of this library was wrong and I already have the library included.

@giaosudau You clarified the issue! Would you like to create a JIRA ticket for that? :-) Then other developers will see the issue. Since this PR is already merged, so it seems to be handled on another PR. Thanks.

@tae-jun https://issues.apache.org/jira/browse/ZEPPELIN-1723

@giaosudau Thanks! 👍 I appreciate it 😄


Bump LLVM to 50de659adcc1

llvm-project: 50de659adcc1
mlir-hlo: 8a045602c94dffa19c8367d8feb7c40d8f885b1f
tensorflow: ac02b22cd1cd0f2c7cf01d0f94c3dc0f53550d62

This is #8807 + PDL fixes on top that build for me locally.


Update add-incoming-webhook.md

minor grammatical typo in docs

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
100
0
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/webhooks-and-connectors/how-to/add-incoming-webhook.md
100
0
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


json_build_object instead of concat in battery-health

replaces concat with json_build_object to hopefully always return valid json...
fixes #4220

ty!

Gained a lot of range with this one
Before:

After:


no warning for mtime if it's not supported

closes #2062

Codecov Report

Merging #2063 (ec53a10) into main (436859d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   61.50%   61.49%   -0.02%
==========================================
  Files         137      137
  Lines       23893    23893
==========================================
- Hits        14695    14692       -3
- Misses       7478     7480       +2
- Partials     1720     1721       +1

Impacted Files
Coverage Δ

pkg/sync/sync.go
46.47% <100.00%> (ø)

pkg/meta/sql.go
64.89% <0.00%> (-0.10%)
:arrow_down:

pkg/meta/redis.go
71.57% <0.00%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436859d...ec53a10. Read the comment docs.


Update to new set_memory() API

Accomplished:

[x] Updated all memory setting in reference implementations to new psi4.set_memory() API
[x] Fixed scf_helper init bug in ROHF_libJK.py
[x] Updated printing in MPn.py

User Changes:

[x] New string arguments to psi4.set_memory() available to users.

Status:

[x] Ready

I probably wont pull this in for awhile yet as this change means that everyone has to have an absolutely up to date psi4.

Sure thing. Maybe once the 1.1 release gets nailed down.

We could probably safely pull this in now, since 1.1 is required.

Agreed.


You should file an issue there: https://github.com/Comfy-Org/litegraph.js


Keep/Drop dice

Ability to keep and drop dice in a set.
Keep/Drop Highest and Keep/Drop Lowest.
https://wiki.roll20.net/Dice_Reference#Keep_.2F_Drop_Dice_.28B.2CF.29_khN.2FklN.2FdhN.2FdlN

Very much would like this as well.


Normalize all paths sent to cpptools

This change addresses item #1099
The following changes are proposed:
Normalize relevant paths sent to cpptools.  This should remove the duplicate entries in the browse configuration seen on Windows and macOS.  It also makes the paths sent for SourceFileConfigurationItem objects consistent with the browse path.

Stylistically we decided not to go that route.  Thanks for the review!


V6 docs

Updated the docs to the new syntax and API. Also automated them from the JSDoc comments in the source code rather than having to hand build them.

Coverage increased (+0.2%) to 100.0% when pulling 4d0699bc2fddff6a3cf0015dd869200e5df3be10 on v6Docs into 3f766741a59151728968c9eb5838a850a168eb9c on v6.


Update to latest version of istio.io/pkg

Also fixed some errors in our GitHub templates.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?
Courtesy of your friendly test nag.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-lint-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-lint-master

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-lint-master

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/integ-security-local-presubmit-tests.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid,howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-lint-master

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/integ-security-local-presubmit-tests.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test integ-security-local-presubmit-tests-master

prow/istio-pilot-multicluster-e2e.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-lint-master

/test istio-pilot-multicluster-e2e-master

/test integ-security-local-presubmit-tests-master

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-lint.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-lint-master

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/istio-pilot-multicluster-e2e.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-v1alpha3.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/istio-pilot-multicluster-e2e.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-v1alpha3.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/istio-pilot-multicluster-e2e.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-v1alpha3.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio_auth_sds_e2e-master

prow/racetest.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-racetest-master

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

/test istio_auth_sds_e2e-master

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/codecov.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-codecov-master

prow/e2e-bookInfoTests-v1alpha3.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/racetest.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio-racetest-master

prow/e2e_pilotv2_auth_sds.sh
f1d48950a6c1fc265313410c4de4d27e10c3feff
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


how to plot latent features

Hello,
The work is very interesting!
I am familar with MRI reconstruction, but not with federated learning.
Could you provide me some hints on ploting letent feature distribution from different datasets, as shown in Figure 1 d) and e)
Thanks a lot.
Best Regards,
Kingaza

Hi Kingaza,
I use sklearn.manifold.TSNE. Please find more info at https://scikit-learn.org/stable/modules/generated/sklearn.manifold.TSNE.html.

I actually know TSNE.
But I don't now how to do this dimension reduction from which features to the 2 features...

I see your problem. What I did was simple. I just reshape the each whole image to 1-dimension vector, then stack them together.


In tests: Failed to update ontology Ontology(id=1, name=mondo) from administrative section.  java.io.FileNotFoundException: /tmp/qei1092u9r4ht (Aucun fichier ou dossier de ce type)

This is done on purpose in a test case.


Resources return wrong value after change RootTheme

Describe the bug
Resources return wrong value after change RootTheme
Steps to reproduce the bug
//Root theme is dark when app runs
if (((FrameworkElement)window.Content).Resources.TryGetValue("ApplicationPageBackgroundThemeBrush", out object value))
	var brush = (SolidColorBrush)value; //has dark color

if (window.Content is FrameworkElement rootElement)
	rootElement.RequestedTheme = ElementTheme.Light;

if (((FrameworkElement)window.Content).Resources.TryGetValue("ApplicationPageBackgroundThemeBrush", out object value))
	var brush = (SolidColorBrush)value; // Always will has dark color until restarting app

Expected behavior
When theme changed resources should return color from new theme.
Screenshots
No response
NuGet package version
Windows App SDK 1.2.4: 1.2.230217.4
Packaging type
Packaged (MSIX), Unpackaged
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

Closing as dupe of https://github.com/microsoft/microsoft-ui-xaml/issues/8249, thanks for filing.


Update: CmdPost

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #586   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         182    182
  Lines        1817   1817
=====================================
  Hits         1817   1817

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5205c89...36573df. Read the comment docs.


huge layout work

--Added cookie to hide banner
--Made "flashes" prettier
--Started to do something with tab_sets, but I think I might reverse course.  I was attempting to render as partials.
--Removed a decent amount of code that was only used in a single view from application_helper. Mostly dealing with description links.
--Added 'theater' mode to view an image
--Still have to fix ajax vote bar displaying funky on landscaped images
--Removed tables from a whole bunch of views and replaced with responsive css
--Added top menu bar with account links, a la github style, still need to work on mobile responsiveness
--Adjust gmaps helper in application-helper to allow for responsive maps based on percentage rather than fixed with.
--Cleaned up some of the tests to use more modern methods, i.e. using assert_tag instead of a regex for extracting links.
--Tried to move the _prev_next_pager into a different view, but it can probably be put into a helper
--All the tests pass, but javascripts are still very much broken in some places, but will be easy to fix.

Coverage remained the same at 83.97% when pulling dfe5a819fa0d455b70cb87eb3fd5e69740ee93b2 on raysuelzer:ror4 into d8c9fadb39fc6a962427f28e337ac3f750a7cb9a on MushroomObserver:ror4.

https://drive.google.com/file/d/0B_xUuUwXMGp9UXljMmpwc29rTDA/view?usp=sharing
Just a video of some of how it looks and stuff.
Ray Suelzer
Mobile:<PHONE_NUMBER>
On Sun, Feb 15, 2015 at 9:01 PM, Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/1934322
Coverage remained the same at 83.97% when pulling dfe5a81
https://github.com/MushroomObserver/mushroom-observer/commit/dfe5a819fa0d455b70cb87eb3fd5e69740ee93b2
on raysuelzer:ror4 into d8c9fad
https://github.com/MushroomObserver/mushroom-observer/commit/d8c9fadb39fc6a962427f28e337ac3f750a7cb9a
on MushroomObserver:ror4.
--
Reply to this email directly or view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/83#issuecomment-74460209
.


improve and/or document the way we run CRI-O tests

We currently run a subset of the CRI-O tests from github.com/kubernetes-incubator/cri-o/tests, but there is no documentation of what approach we follow. We also need to find a way to have a more reliable process, since our tests can be outdated at some point.
For reference, this was a previous discussion:
https://github.com/clearcontainers/tests/pull/919#pullrequestreview-97518645

The approach that we will take is that after cloning the github.com/kubernetes-incubator/crio-o/tests, we will run the CTR tests. However, currently only 16 of the 30 are passing so the rest of them will have a skip.


testing: proposal: allow benchmark to use arbitrary units of work per run

When performing a benchmark, we can currently use SetBytes(int64) to set the number of input or output bytes per run, and get a measurement like X MB/s in the output.
It would be nice to be able to set an arbitrary unit instead of "bytes", and to provide multiple scales instead of just "mega" (1e6).
Example 1: pixels per second (px/s): b.SetUnits(1920*1080, "px/s") when benchmarking a full-HD image would print to the output one of the following, depending on the scale of the result:

"X px/s"
"X kpx/s"
"X Mpx/s"
"X Gpx/s"

Example 2: frames per second (fps): b.SetUnits(1, "fps") when benchmarking one frame operation.
The existing implementation of SetBytes(b int64) could just call SetUnits(b, "B/s") for backwards compatibility.

I believe this https://tip.golang.org/pkg/testing/#B.ReportMetric is what you want.

@jpap Thanks for writing this up. Does @agnivade's suggestion work for you?

Thanks @agnivade, it's great that arbitrary units of work are supported in Go 1.13+.
@toothrot, the second part to this issue, auto-scaling the results {_, k, M, G} instead of scaling by 1e6 (M) uniformly as-is done now, still remains and doesn't appear to be already implemented (having just checked tip).

Great, glad to hear the arbitrary units work (#26037) will help! @jpap Let me know if I captured your request correctly in the title.
@aclements Thoughts on this?

@toothrot, it would be great if the unit-scaling applied to all reported metrics in the benchmark data format, not just bytes/sec (MB/s).

/cc @aclements for thoughts

@jpap, just to clarify, custom metrics reported using ReportMetric aren't autoscaled by 1e6 (I'm not sure if that's what you were saying or not). Only SetBytes scales that way.
It's an interesting question whether we could scale other things this way automatically. Our position has been to keep the benchmark output format very machine-readable (while still being reasonably user-friendly), and to depend on downstream tools to present a much more processed view to users. For example, benchstat does scale the units automatically. You almost always need to do some statistical analysis of the benchmark results anyway, so looking at the raw benchmark output can be misleading at best.
I'm also concerned with how this would interact with custom units. For example, the sync/pool benchmarks emit custom tail latency metrics with units like "p95-ns/STW". Automatically putting a metric prefix on that unit would be the wrong thing to do.
Finally, this would be a break from the benchmark format and would thus require changes to many tools that consume that format.
Given all of this, I do not think the testing package should be autoscaling these units. Instead, we should leverage the existing standard format to build tools to better process and present benchmark results.

Based on the discussion above and past discussions about how hard it is to do arbitrary units correctly in general, this seems like a likely decline.
For a truly amazing programming language that fully embraces the idea of getting units right, see https://frinklang.org/.
Leaving open for a week for final comments.

No final comments, so declined.


bug: running test with a filter for a file that is added to a group, it runs duplicate checks

Node.js version
18.12.1
NPM version
8.19.2
@checkly/cli version
0.3.14
Steps to reproduce
Here is a link to a setup that reproduces this. Run npx checkly test one.spec.ts and it will run that file, but also double it as it's created via glob in the group, and via an explicit BrowserCheck construct.
https://codesandbox.io/p/sandbox/strange-bhabha-2gltvq?selection=%5B%7B%22endColumn%[…]A7%2C%22startColumn%22%3A19%2C%22startLineNumber%22%3A7%7D%5D
What is expected?
I expected only the file to run I specifically indicate.
What is actually happening?
It runs the same check, but in two "instances"
Any additional comments?
This was reported by a customer

I'm wondering what the expected behavior should be. Since both checks are associated with one.spec.ts, does it make more sense to run the version created directly by BrowserCheck or the version created from CheckGroup? It seems challenging to pick which one should have priority.
It's worth mentioning that the two versions of the check aren't necessarily the same. The CheckGroup and BrowserCheck constructs might define environmentVariables that configure the behavior of the check (for example, the URL or credentials that are used). In this case, I think that there's a valid use case where users would want to run all of the checks that are associated with one.spec.ts.

@clample , I agree. It seems the current filtering is working OK, picking all checks related with the file. IMHO, the --grep should be used to pick just only the spec.file check.

Decided to keep the current filtering behavior.


this._network.observe is not a function

Hi, in my project I am using

react: 16.2
react-dom: 16.2
react-relay: 1.3

When I use the RelayNetworkLayer I get this error.

This is my code
import { Environment, RecordSource, Store } from 'relay-runtime';
import 'regenerator-runtime/runtime';
import { RelayNetworkLayer, authMiddleware } from 'react-relay-network-modern';

const network = new RelayNetworkLayer([
  authMiddleware({
    token: () => 'My Token',
  }),
  next => async req => {
    req.fetchOpts.url = 'Some url';
    req.fetchOpts.credentials = 'include';

    const res = await next(req);
    return res;
  },
]);

const source = new RecordSource();
const store = new Store(source);

const environment = new Environment({
  network,
  store,
});

export default environment;

The environment created by new Environment(...) has the following shape
RelayModernEnvironment {
  _network {
    fetchFn: (operation, variables, cacheConfig, uploadables)
  }
}

Updated to react-relay 1.5.0 and the error was gone

Thanks for reporting! Also it works under Relay 1.4.0. So if you will have a problem with relay-compiler & recursive max stack trace. Feel free to downgrade react-relay not below 1.4.0.
I checked package.json and it has correct peerDependency:
"peerDependencies": {
    "relay-runtime": ">=1.4.0"
  },


Cake fails on using-statement with space between using and (

Given the following script,
Task("Default")
    .Does(() =>
    {
        using(var succeeds = new MemoryStream()) {}

        // Notice the space
        //   |
        //   v
        using (var fails = new MemoryStream()) {}
    });

Cake fails with the error,
Error: error CS0246: The type or namespace name '(var' could not be found (are you missing a using directive or an assembly reference?)

I cannot reproduce the error in a scriptcs REPL.

Try not to use space between using and (.

@patriksvensson Really? Yeah, how come I didn't think of that? Still, I would expect it to work either way.

It's a Roslyn issue. Sorry about this.


improve commit and buildDate

What this PR does / why we need it:

improve version cmd's commitVersion and buildTime (use debug/buildInfo (add this feature in go 1.18)).
rm make script depending on os.

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

This continues at #419.


Cluster stuck in "updating" state when adding 1 node with "all" roles and 2 worker nodes.

Rancher versions: v2.0 build from master
Steps to reproduce the problem:
Create a cluster using DO machines using the following configuration:

Cluster stuck in "updating" state with following error message -
"[network] Port check for ports: [**:2379, :2380] failed on host: []"
Then node with all roles got to active state , but the worker nodes are stuck in “Registering” state

@sangeethah I tried with the latest master with the same configuration and i can't reproduce, i also tried setting the rancher server in AWS and can't reproduce as well.

Tested with master from March 2nd. Creating a cluster with above configuration was successful.
Creation of pods after cluster creation was ok too.


Grant migration user the R/W permission for the “unassigned” queue

Ensure that the migration user has R/W permission for the “unassigned” queue.

@minjunyang88 does this not happen during the "Group Member" migration?

No. I had to manually assign myself to the "unassigned" queue.

Issue moved to forcedotcom/scmt-server #44 via ZenHub


Bug: The selection changes unexpectedly when changing font family (or anything using inline style)

This Pull Request is related to #5632
Solution:
Handle set focus for the last node

Thanks for the PR!

Can we add a unit test for this?
I believe L440 hints toward a case that is now bugged in a different way, can we please look into this? (video below)

Screen.Recording.2024-02-20.at.2.40.06.PM.mov

Hi @zurfyx, thank for the suggestion. Please help me check the PR again

Closing this PR due to staleness! If there are new updates, please reopen the PR.


Intersect and Multipolygons

The intersects methods does not seem to work every time for multi-polygons,
The following code will return no result :
const multiPoly = {
    "type": "Feature",
    "id": "2855",
    "geometry": {
        "type": "MultiPolygon",
        "coordinates": [[[[-67.188, 18.267], [-67.082, 18.255], [-67.02, 18.195], [-67.024, 18.185], [-67.035, 18.186], [-67.051, 18.174], [-67.072, 18.173], [-67.086, 18.162], [-67.087, 18.152], [-67.16, 18.153], [-67.162, 18.152], [-67.167, 18.155], [-67.166, 18.158], [-67.171, 18.159], [-67.173, 18.162], [-67.181, 18.168], [-67.155, 18.195], [-67.153, 18.203], [-67.158, 18.217], [-67.173, 18.231], [-67.175, 18.248], [-67.188, 18.267], [-67.188, 18.267]]], [[[-67.892, 18.114], [-67.887, 18.113], [-67.876, 18.114], [-67.87, 18.119], [-67.862, 18.122], [-67.848, 18.108], [-67.843, 18.095], [-67.844, 18.085], [-67.845, 18.082], [-67.853, 18.078], [-67.866, 18.065], [-67.871, 18.058], [-67.896, 18.052], [-67.904, 18.059], [-67.919, 18.063], [-67.928, 18.069], [-67.941, 18.08], [-67.934, 18.111], [-67.932, 18.113], [-67.911, 18.12], [-67.892, 18.114]]], [[[-67.95, 18.154], [-67.954, 18.155], [-67.953, 18.158], [-67.95, 18.157], [-67.95, 18.154]]], [[[-67.478, 18.379], [-67.485, 18.382], [-67.489, 18.387], [-67.482, 18.391], [-67.478, 18.391], [-67.472, 18.383], [-67.478, 18.379]]]]
    },
    "properties": {}
};

const select = {
    "type": "Polygon",
    "coordinates": [[[-67.30386007285715, 17.965732406679738], [-66.92345710115437, 18.200715771464914], [-67.39449760402098, 18.486185143882885], [-67.30386007285715, 17.965732406679738]]]
};

const store = new GeoStore({
    store: new Memory(),
    index: new RTree()
});
store.add(multiPoly);
store.intersects(select, function (err, res) {
    console.log(res);
});

Here is a visual of the polygons

GeoStore.add(geojson) is asynchronous, right? Have you tried passing it a callback and executing the intersects() query after the callback? I think the way you have written this the query may sometimes be executing before multiPoly has been added to the store.

Yes indeed my previous code sample was wrong but even with the correct callback the method returns an empty array.
function storeReady(){
    store.intersects(lasso, function (err, res) {
        console.log(res);
    });
}
store.add(multiPoly, storeReady);


request: could you make the scroll bar start lower?

I think it would look nicer if it starts below the blurring top bar. Woz Theme does that.

Fixed by https://github.com/pengx17/logseq-dev-theme/commit/2d48f0151a097242f0199a37fd9b5aaa13b9ca76


[PORT]Add abs and sqrt built-in function

Fixes #3240
Description
Add abs and sqrt prebuilt function.
Example:
abs(3.12134)  -> 3.12134
abs(-3.12134) -> 3.12134
abs(0) -> 0
sqrt(9) -> 3
sqrt(-1)  -> throw error
sqrt(0) ->  0

Pull Request Test Coverage Report for Build 520218437

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 84.651%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/node.ts
10
90.51%

Totals

Change from base Build 519010468:
-0.06%

Covered Lines:
18080

Relevant Lines:
20387

💛  - Coveralls

Pull Request Test Coverage Report for Build 520218437

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 84.651%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/adaptive-expressions/src/triggerTrees/node.ts
10
90.51%

Totals

Change from base Build 519010468:
-0.06%

Covered Lines:
18080

Relevant Lines:
20387

💛  - Coveralls


Translate px to em when compiler parses a fontSize property.

We should eventually be able to configure the babel plugin with the following setting:
{
  baseFontSize: 16,
}

When the compiler parses a fontSize rule, the following transformation should be applied:
fontSize: 16 // translates to 1em
fontSize: 14 // translates to 0.875em

If no baseFontSize setting is found, no translation should happen.

it should probably be REM that we use; looks like this is how facebook does it
source: https://engineering.fb.com/web/facebook-redesign/
specific quote:

By using rems, we can respect user-specified defaults and are able to provide controls for customizing font size without requiring changes to the stylesheet. Designs, however, are usually created using CSS pixel values. Manually converting to rems adds engineering overhead and the potential for bugs, so we have our build tool do this conversion for us.

I'll probably default to rem and have the user define a unit in the babel config if needed.


Single quotes, not triple double quotes in :h undo

In :h undo most of the examples use single quotes when referring to
registers, e.g. '"2P'.
The first example however, uses ""1P", which can make the second double
quote (the one that actually needs to be typed) harder to spot. (As seen in
this reddit post.)
This simple change will make it easier to read, and more consistent
with the other examples.

I'll include it, thanks.


Running a Kubernetes ingress

Create three types of kubernetes resources

Two deployments of nginx which have different messages when we hit their main endpoint
Create two services for each of the deployments
Create a single ingress which redirects to first service on endpoint /first and second endpoint on endpoint /second

So for example for service1
curl http://localhost/first

{"Message" : "This is service 1"}

So for example for service2
curl http://localhost/second

{"Message" : "This is service 2"}

I'd like to try this one, can you assign me plz?

sure please go ahead


Add tests for cover unions of table types

Description:
We need to add more test cases covering unions of the table, table of unions of records, etc.  ATM getting NPE from compiler FE. We need to merge https://github.com/ballerina-platform/ballerina-lang/pull/31205

Added more tests for configurable unions.


Update configurations-on-the-training-platform.md

removing extra "<<<<<<< HEAD"

@hkamel : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hkamel : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 521d381:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/settings/configurations-on-the-training-platform.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


I am trying to launch chrome browser getting issue like java.lang.NoSuchFieldError: INSTANCE

I am using below versions of selenium java and server dependencies.

	<dependency>
		<groupId>org.seleniumhq.selenium</groupId>
		<artifactId>selenium-java</artifactId>
		<version>2.47.1</version>
	</dependency>

	<dependency>
		<groupId>org.seleniumhq.selenium</groupId>
		<artifactId>selenium-server</artifactId>
		<version>2.47.1</version>
	</dependency>

But, If i am using same versions of jar files in ant and trying to launch chrome browser it is working.
If i am using same version of dependencies in maven getting issue for launching chrome browser.
Getting below error for maven:-
java.lang.NoSuchFieldError: INSTANCE
at org.apache.http.impl.io.DefaultHttpRequestWriterFactory.(DefaultHttpRequestWriterFactory.java:52)
at org.apache.http.impl.io.DefaultHttpRequestWriterFactory.(DefaultHttpRequestWriterFactory.java:56)
at org.apache.http.impl.io.DefaultHttpRequestWriterFactory.(DefaultHttpRequestWriterFactory.java:46)
at org.apache.http.impl.conn.ManagedHttpClientConnectionFactory.(ManagedHttpClientConnectionFactory.java:72)
at org.apache.http.impl.conn.ManagedHttpClientConnectionFactory.(ManagedHttpClientConnectionFactory.java:84)
at org.apache.http.impl.conn.ManagedHttpClientConnectionFactory.(ManagedHttpClientConnectionFactory.java:59)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager$InternalConnectionFactory.(PoolingHttpClientConnectionManager.java:487)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.(PoolingHttpClientConnectionManager.java:147)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.(PoolingHttpClientConnectionManager.java:136)
at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.(PoolingHttpClientConnectionManager.java:112)
at org.openqa.selenium.remote.internal.HttpClientFactory.getClientConnectionManager(HttpClientFactory.java:74)
at org.openqa.selenium.remote.internal.HttpClientFactory.(HttpClientFactory.java:57)
at org.openqa.selenium.remote.internal.HttpClientFactory.(HttpClientFactory.java:60)
at org.openqa.selenium.remote.internal.ApacheHttpClient$Factory.getDefaultHttpClientFactory(ApacheHttpClient.java:252)
at org.openqa.selenium.remote.internal.ApacheHttpClient$Factory.(ApacheHttpClient.java:229)
at org.openqa.selenium.remote.HttpCommandExecutor.getDefaultClientFactory(HttpCommandExecutor.java:96)
at org.openqa.selenium.remote.HttpCommandExecutor.(HttpCommandExecutor.java:70)
at org.openqa.selenium.remote.HttpCommandExecutor.(HttpCommandExecutor.java:58)
at org.openqa.selenium.remote.service.DriverCommandExecutor.(DriverCommandExecutor.java:49)
at org.openqa.selenium.chrome.ChromeDriver.(ChromeDriver.java:170)
at org.openqa.selenium.chrome.ChromeDriver.(ChromeDriver.java:138)
at framework.Lib.Common.WebCtrlOperations.GetWebDriver(WebCtrlOperations.java:136)
at defFiles.SalesForce.launchSF(SalesForce.java:45)
at ✽.Given I launch salesforce test portal(D:/D2_FrameWork/Salesforce_Automation/src/test/resources/FeatureFiles/A22B_Product_Name_Family/New_Product_Name_Family_Qualifier_Achievement.feature:5)

As mentioned by a fellow maintainer in the previous similar thread. There could be a number of reasons and without an MVCE we cannot triage.
What I will say here is that cucumber is not a browser automation tool. So your efforts might be better served asking on the selenium issue tracker, but they will also want an MVCE. ideally in the form of a github repo.

I'm closing this since the error is not related to Cucumber

May i know, What purpose of Git hub portal is Available.
As soon as i am posting an issue, People are closing an issue.

@roop152 we only use GitHub issues to track Cucumber bugs and contributions.
Please use the support forums for questions and discussions about Cucumber.
For questions about other tools like Selenium WebDriver we encourage users to use their dedicated forums.


fix: fix swap rate call v4

📝 Description
Fix swap rate call to filter providers.
❓ Context

Impacted projects:

Common
LLD
LLM

Linked resource(s):

[swap] rate requests are sent for all providers instead of those listed by backend https://ledgerhq.atlassian.net/browse/LIVE-4045

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

There are some lines that aren't being tested according to the code checking tool. Can we add those in? @sarneijim

LGTM. I've compared behaviour with prod and this branch and they are displaying the same quotes/behaviour for US and non-US IP addresses. This branch is also correctly only getting the relevant providers, so it's looking correct. I also completed a swap which was successful. Feel free to address the comments if they are relevant @sarneijim


DOCS update for v1.3 & release

[x] update CHANGELOG.md
[x] CONTRIBUTING.md: remove the  spaces for alignment
[x] .github/ISSUE_TEMPLATE: add is:issue to the issue link
Wiki update:

[ ] contributors
[ ] migration

So it looks like we're there already! All features for version 1.3 have been merged in master.
I've set the release date to the 21th in the changelog, which is exactly 2 weeks from now. I'd like to have this time window so people can upgrade and test, before we tag the release. If there should be any issues in the mean time, it should be fairly easy to fix them and after that period I'll merge #101 (feel free to check it out), which updates the docs and I'll tag the release.
It's been crazy 3 months I have to say. A lot of work has been done and a lot of experience has been gained (on my side at least). I'd like to thank all the people who have contributed to this project. It's come a long way since the decision to do a one collaborative effort and I think it has been a very right decision. We now support all the devices for which there were forks and once we support snowboy (and probably do a sox playback_handler), we will eliminate the need for all the forks and everyone can focus on this awesome version. We've also made some drastic changes to the code and it is now much more friendly to the developers, which only helps to catch new people's interest and prevents us from going crazy.
I'd like to draft my vision for the future, mainly v1.4. The main objective there is going to be refactoring the triggering code and the AVS code and to support sox. This is going to have some implications:

With the triggering code refactored, the voice activation is going to be optional (not mandatory as it is now). This is the one feature that Sam's original repo has that we don't. So after this is possible, I'd like to change the note in the repo to recommend all users to switch to our repo. Also, some more aggressive notes / links can be added.

With the AVS refactor, the code should be much cleaner and it should be possible to start integrating the new API in our repo.
With sox we should fix audio issues on Orange Pis with legacy kernel, CHIPs and other boards where vlc doesn't work properly for some reason. Also, this should open the door to OpenWRT, which is gonna be awesome!

And to get an idea what's coming, I'd like to ask:

@lechat What's the status of your logging branch?
@dgonano What's the status of your magicmirror branch? Would you like to see it merged upstream?
@davidm How are you doing on the avs_v2 branch? When the AVS refactor is done, we could try integrating it as mentioned above if you are interested. Obviously we could discuss the details only after we get there and start the work on it to make sure the interface is there. This will require resolving some merge conflicts since there has been quite a few commits here, but it's something we can work together on and it's definitely worth it. Also, I see you're doing it quite modular, which is a good thing!

So this is it from me. What are your thoughts? What are your visions for AlexaPi?

@renekliment I have this latest version master up and running. It's working but I'm having an issue with music/radio playback.
I asked it to "play triple j radio" and it did. While playing I invoked alexa again but it stopped working:
INFO: cmn_live.c(88): Update from < 36.42 13.75 -11.92 -6.39  5.08  0.94 -4.97 -1.15 -1.66 -0.59  0.26  0.61  0.94 >
INFO: cmn_live.c(105): Update to   < 37.69 12.51 -11.97 -4.01  5.57 -1.23 -5.96 -1.26  0.28 -4.09 -0.75  1.11 -0.90 >
INFO: cmn_live.c(88): Update from < 37.69 12.51 -11.97 -4.01  5.57 -1.23 -5.96 -1.26  0.28 -4.09 -0.75  1.11 -0.90 >
INFO: cmn_live.c(105): Update to   < 38.30 11.69 -10.22 -1.03  6.00 -1.43 -5.92 -1.02  1.42 -2.27  0.24  2.13  1.86 >
Player State: State.Stopped
Play_Audio Request for: /opt/AlexaPi/src/resources/alexayes.mp3

The music stopped but it didn't say "yes" and won't accept anymore input. have to crash the program and start again.
I also tried playing a different station, Nova 1069. It says "playing nova 1069 on tunein" but no audio played
Player State: State.Opening
Player State: State.Playing
Player State: State.Ended
TUNE IN URL = http://opml.radiotime.com/Tune.ashx?id=s87120&formats=aac,mp3&partnerId=4JqugguZ&serial=AEOK4VMXAH7UA7B3KRR7GPYG63IA&latlon=40.75,-73.98333

It also stopped responding to any further commands but managed to quit with ctrl-c
Magic Mirror platform:
I'm just working on getting it in a mergable state now. Everything is working but I just want to tidy it up and add some documentation. Is there a good place I can add details about the platform or just at the start of the file for now?
Also, I haven't done anything for the install script so a user can select the new platform. I'm just setting it in the config file at the moment.

@dgonano Put docs in our wiki.
Thanks for catching that bug. That's exactly something we have to fix before the release.

Alright. So the bug found by @dgonano should be fixed by #103. Please test.
By the way, @lechat, you were so right. I see now that the if debug is the worst f****** idea ever. We should definitely switch to sane logging first thing after the release. I don't know, up until now I just ignored it, but it takes up twice the number of rows, sometimes even more because for it to be readable it requires space around and it's useless for "profiling", because it does't  print time ... and I haven't needed filtering yet, so I'm not talking about that ... I guess I've just seen the light :smile:

Testing.
Yeah, logging handlers are great. Allows multiple levels of logging easily in addition to your stuff

Logging w/o timestamps is of course bad idea. I may find some time this week to finish logging branch.

Also, I wanted to do something like Codacy for AlexaPi, but all those apps have this:

This application will be able to read and write all public repository data. This includes the following:
Code
Issues
Pull requests
Wikis
Settings
Webhooks and services
Deploy keys

and I am not gonna authorize that ...
Do you guys know an app that doesn't need this? If I remember correctly, it's a GitHub issue and it has been criticized for it, but that doesn't change the end result.


GitHub action checkout version bump

Current coverage for CombineSchedulers is 5.74%
✅ No files affecting coverage found

Current coverage for ComposableArchitecture is 11.43%
✅ No files affecting coverage found

Current coverage for GitHubAPIClientTests is 97.40%
✅ No files affecting coverage found

Current coverage for NetworkingTests is 86.03%
✅ No files affecting coverage found

Current coverage for Trending.app is 16.38%
✅ No files affecting coverage found

Powered by xcov

  Generated by :no_entry_sign: Danger


Publish 3.0.0-M9 for scala 2.12.3

Thanks!

found it! https://mvnrepository.com/artifact/org.scalameta/paradise_2.12.3/3.0.0-M10


Update README example to use ReactDOM instead of React for render

React.render is deprecated in favor of ReactDOM.render, this reflects that in the tiny example in the README

Whoops, #41 already does this.
Closing


[BUG] errors-in-develop

Describe the bug
there are two languages defined please look at this
To Reproduce
Steps to reproduce the behavior:

Go to 'develop'
Click on 'the app'
Scroll down to 'languages'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

IN THE APP INTEGRATION TEST THERE IS A LANGUAGE.CODE AS AN ERROR

Issues now correct - duplicated language tests removed, CapitalReportTest class name corrected and method names corrected


Add more information to README + Contributing guide

Journey

the idea started in October 2022
initial website launched January 2023

Current Structure

weekly syncs in Google Meet
communication in Discord
code + PRs in GitHub
hosting + deployment in Vercel
notes in Notion

Onboarding

Join Discord
Get added to the weekly meeting
Get comment access to notes in Notion

After first contribution

Add as a contributor in README
Add as a contributor to GitHub Org
Add position under “Volunteering” in LinkedIn profile
Get edit access to notes in Notion

Mission
Latina Dev is an open-source directory of Latina software engineers at the student, IC, and leadership levels.
Our goal is to increase visibility and access to valuable opportunities.
Vision
Amplify opportunities for over 1,000 Latina software engineers by 2025.


feat: Add license and copyright attribution to project (DEV-4347)

feat: Add copyright attribution and license to Project and expose on the api for create and update

Pull Request Checklist
Task Description/Number

Issue Number: DEV-
PR Type

[ ] build/chore: maintenance tasks (no production code change)
[ ] docs: documentation changes (no production code change)
[x] feat: represents new features
[ ] fix: represents bug fixes
[ ] perf: performance improvements
[ ] refactor: represents production code refactoring
[ ] test: adding or refactoring tests (no production code change)
[ ] deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

Does this PR introduce a breaking change?

[ ] Yes

Unfortunately the other PR was merged before I reviewed it, but have general question related to property name, if it would make sense to shorten it to just copyright?

copyright attribution is what we decided to use a the term in the project.


Tickets/preops 1548

Creating pull request to main to capture updates and changes before merging.

See comments from PR #8, specifically https://github.com/lsst-sitcom/sitcomtn-014/pull/8#issuecomment-1431682378.

See comment from previous PR: https://github.com/lsst-sitcom/sitcomtn-014/pull/8#issuecomment-1431682378.

Requested to merge as draft to main.


Always pretty print the settings

I keep my Desktop Dimmer config in git and noticed a difference with regards to how the settings (~/.config/Desktop Dimmer/Settings) are saved to disk.
When changing the settings AND quitting Desktop Dimmer, the settings will be pretty printed, like so:
{
  "currentVersion": "2.5.0",
  "overlays": {
    "21691165392764930": {
      "alpha": 0.75,
      "color": "transparent"
    },
    "17607560531959042": {
      "alpha": 0,
      "color": "transparent"
    }
  },
  "launchOnStartup": true
}

But when changing the settings without quitting Desktop Dimmer, the settings will be saved on a single line, like so:
{"currentVersion":"2.5.0","overlays":{"21691165392764930":{"alpha":0.75,"color":"transparent"},"17607560531959042":{"alpha":0,"color":"transparent"}},"launchOnStartup":true}

Which results, for me, in git telling me there are changes every time I open Desktop Dimmer. Would be great if the settings could always be pretty printed so that doesn't happen.

@romainrichard
Thanks for the report. The issue has been addressed in v2.7.2.. Please re-test if the newest version and comment.

It seemed to be working at first but the issue is still there unfortunately.
Here's what I'm seeing, first I have Desktop Dimmer not running and check the status of my git repo:
$ git status
On branch develop
Your branch is up-to-date with 'origin/develop'.
nothing to commit, working directory clean

Then I start Desktop Dimmer and run the same command:
$ git status
On branch develop
Your branch is up-to-date with 'origin/develop'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   .config/Desktop Dimmer/Settings

no changes added to commit (use "git add" and/or "git commit -a")

Here's what the diff looks like:
$ git diff
diff --git a/.config/Desktop Dimmer/Settings b/.config/Desktop Dimmer/Settings
index fa04d33..8724b09 100644
--- a/.config/Desktop Dimmer/Settings
+++ b/.config/Desktop Dimmer/Settings
@@ -1,14 +1 @@
-{
-  "currentVersion": "2.7.2",
-  "overlays": {
-    "21691165392764930": {
-      "alpha": 0.2,
-      "color": "transparent"
-    },
-    "17607560531959042": {
-      "alpha": 0,
-      "color": "transparent"
-    }
-  },
-  "launchOnStartup": true
-}
+{"currentVersion":"2.7.2","overlays":{"21691165392764930":{"alpha":0.2,"color":"transparent"},"17607560531959042":{"alpha":0,"color":"transparent"}},"launchOnStartup":true}

Then I exit Desktop Dimmer and run git status again:
$ git status
On branch develop
Your branch is up-to-date with 'origin/develop'.
nothing to commit, working directory clean

@romainrichard
Thanks for the re-check. Weird issue. Can you please test whether the newly deployed v7.2.3 resolves it? It's not reproducible in our test VM (Ubuntu 16.10). Cheers, and keep those issue reports coming!

Looks like it works now because it only saves upon quitting Desktop Dimmer, which is fine by me, thanks for the quick update!


Unable to use referenceId, start fields in /reads/search API call

Following the demo instructions, I can query all reads:
$ curl --data '{"readGroupIds":["low-coverage:HG00534.mapped.ILLUMINA.bwa.CHS.low_coverage.20120522"]}' --header 'Content-Type: application/json' http://localhost:8000/v0.5.1/reads/search
(many results!)

If I try to query a particular range, however, I get an error:
$ curl --data '{"readGroupIds":["low-coverage:HG00534.mapped.ILLUMINA.bwa.CHS.low_coverage.20120522"], "referenceId": "1", "start": 129650, "stop": 129670}' --header 'Content-Type: application/json' http://localhost:8000/v0.5.1/reads/search | jq .
{
  "errorCode":<PHONE_NUMBER>,
  "message": "only one of referenceId and referenceName can be specified"
}

This is odd, since I didn't specify referenceName in the request (in fact, it's not even a valid field in SearchReadsRequest). Dropping the referenceId field, I get an even stranger error:
$ curl --data '{"readGroupIds":["low-coverage:HG00534.mapped.ILLUMINA.bwa.CHS.low_coverage.20120522"], "start": 129650, "stop": 129670}' --header 'Content-Type: application/json' http://localhost:8000/v0.5.1/reads/search | jq .
{
  "errorCode":<PHONE_NUMBER>,
  "message": "Internal Server Error"
}

Looking at the server logs, I see this:
  File "pysam/calignmentfile.pyx", line 572, in pysam.calignmentfile.AlignmentFile.getrname (pysam/calignmentfile.c:8026)
ValueError: reference_id 129650 out of range 0<=tid<86

i.e. it looks like the start value is being interpreted as a referenceId!
I'd appreciate some help figuring out why this API endpoint is behaving so oddly. Thanks!

Thanks for finding these issues.  I'll have a PR up to fix this soon.

Fixed in https://github.com/ga4gh/server/releases/tag/v0.1.2
Thanks for the excellent bug report, @danvk !


Icon in Android app not working with @hmscore/react-native-hms-ml

Currently I have an application in production and it works correctly. Speech recognition is being implemented in the app, so the following package was installed:
"@hmscore/react-native-hms-ml": "^3.5.0-301"

The following versions are installed in the application
"react": "17.0.2",
"react-native": "0.67.4"

JDK:
openjdk <IP_ADDRESS> 2022-07-19 LTS
OpenJDK Runtime Environment Zulu11.58+23-CA (build <IP_ADDRESS>+1-LTS)
OpenJDK 64-Bit Server VM Zulu11.58+23-CA (build <IP_ADDRESS>+1-LTS, mixed mode)
It was configured according to the documentation and the voice recognition works, but the application icon no longer recognizes the one it had, but is modified by the default android one when a project is created in react-native

The application previously already has the following packages and has worked correctly
"@hmscore/react-native-hms-availability": "^5.2.0-300",
"@hmscore/react-native-hms-location": "^5.1.0-303",
"@hmscore/react-native-hms-push": "^5.3.0-304",

In addition to this, when generating an apk-release.apk without the package "@hmscore/react-native-hms-ml" the size of the .apk file is 36.8Mb, but when adding this package the apk-release.apk has a size of 177.4Mb

@breeedly We tried the ML Demo. The logo. png in the android/app/src/main/res/mimap hdpi directory should not be set as the application icon.
It is determined according to the configuration in the AndroidManifest file:

Add the following in android/app/src/main/AndroidManifest.xml, but it still doesn't work:

This is how the directory currently looks

Doing npm uninstall of @hmscore/react-native-hms-ml and commenting out the code where hmscore/react-native-hms-ml was set causes the icon to work correctly again.

@breeedly Please provide the demo code for us to locate the problem.

@xuxiapu Sorry for the delay, here is the demo code.
https://github.com/breeedly/DemoProject

@breeedly

The problem of icon change has nothing to do with the HMSCore ML plug-in.
To change the icon, you need to configure the IC_ launcher.xml.

References are as follows:

And configure corresponding pictures, such as:
![image](https://user-images.githubusercontent.com/114389983/201030425-3a29d2c4-a4a4-4f2d-a65a-92070e171f09.png)

@xuxiapu  thanks for the support, the icon works correctly again.