Version 1.5.2 on Rails 6.0.1 causing deprecation warning

Rails 6.0.1
Gem version 1.5.2
In config/application.rb,
require "action_view/component"
Causing:
DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper.

Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.

Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload ActionText::ContentHelper, for example,
the expected changes won't be reflected in that stale Module object.

These autoloaded constants have been unloaded.

Please, check the "Autoloading and Reloading Constants" guide for solutions.
 (called from <main> at /Users/
USER/Projects/rails-app-test/config/environment.rb:5)

at development.log
Which is highly difficult to track
Related issue https://github.com/rails/rails/issues/36546

Version 1.4.0 works ok, though
In config/application.rb,
require "action_view/component/base"

For me, v1.5.3 also works if I change require "action_view/component" to require "action_view/component/base".

require "action_view/component/base" doesn't work with 1.5.3 though -- it's causing something like 'ExampleComponent' is not an ActiveModel-compatible object. It must implement :to_partial_path.
#79

I'm using Rails <IP_ADDRESS> and latest release of AVC and getting the deprecation warning too... Any ideas of how to get rid of it?

@johanandre we've yet to have someone look at reproducing / fixing this issue. Might you be interested in taking a crack at it?

I was able to track it down to this line: https://github.com/github/actionview-component/blob/22068157e0083589cf350407aa80473e85926ecd/lib/railties/lib/rails/components_controller.rb#L3. Based on this documentation , this should be avoided.
I'm taking a shot of fixing this warning, I'll post my progress soon.

Thanks @kinduff! Please let us know what you find, even if it's not a complete fix ❤

@kinduff if I can support you, let me know! Also have this issue in my setup.

This should be fixed in 1.12.0, by @seanpdoyle's https://github.com/github/actionview-component/pull/225. Please re-open if not! ❤


[BUG] A quotation in the file name causes XML Exception instead of a 400 Bad Request

Describe the bug
If you create a Directory or File, with a quotation (") in it, it will throw an XML error because when expecting whitespace. This may not be a bug.
This should throw the 400 - Bad Request, to let the user know it's an error that they should not be naming their Directory or Files with quotation marks.
https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-shares--directories--files--and-metadata
Expected behavior
What is the expected behavior?
Propagate the 400 - Bad Request up, instead of the XML error.
Actual behavior (include Exception or Stack Trace)
What is the actual behavior?
Throws an XML Exception.
 Message:
    System.Xml.XmlException : '"' is an unexpected token. Expecting whitespace. Line 1, position 50.
   The request URL is invalid.

To Reproduce
            string name = GetNewDirectoryName() + char.ConvertFromUtf32(0x90);

            ShareDirectoryClient subdir = InstrumentClient(test.Share.GetDirectoryClient(name));
            await subdir.CreateAsync();

Environment:

Name and version of the Library package used: Azure.Storage.Files.Shares

This was found in reference to https://github.com/Azure/azure-sdk-for-net/issues/13059

@amnguye Are there any update on this issue?
On our side, we do need to detect invalid characters and handle it properly. How do we detect it in the past is v11 SDK gives REST response that it is a bad request and there is no request id. However v12 SDK only throws XMLException without any other information. Therefore we have to handle any XMLException as invalid character case, which is dangerous for us. So we really want it to be fixed sooner.

Related to https://github.com/Azure/azure-sdk-for-net/issues/19501
See https://github.com/Azure/azure-sdk-for-net/issues/19501#issuecomment-805071162


Unable to load JSON saved using to_json

Describe the bug
Datasets stored in the JSON format cannot be loaded using json.load()
Steps to reproduce the bug
import json
from datasets import load_dataset

dataset = load_dataset("squad")
train_dataset, test_dataset = dataset["train"], dataset["validation"]
test_dataset.to_json("full_dataset.json")

# This works
loaded_test = load_dataset("json", data_files="full_dataset.json")

# This fails
loaded_test = json.load(open("full_dataset.json", "r"))

Expected behavior
The JSON should be correctly formatted when writing so that it can be loaded using json.load().
Environment info
Colab: https://colab.research.google.com/drive/1st1iStFUVgu9ZPvnzSzL4vDeYWDwYpUm?usp=sharing

Hi @DarshanDeshpande,
Please note that the default format of the method Dataset.to_json is JSON-Lines: it passes orient="records", lines=True to pandas.DataFrame.to_json. This format is specially useful for large datasets, since unlike regular JSON files, it does not require loading all the data into memory at once, but can be done iteratively by batches.
In order to read this file using the json library, you should parse line by line:
with open("full_dataset.json", "r") as f:
    data = [json.loads(line) for line in f]
len(data)

Maybe we should explain this better in our docs.

Now we explain this better in out docs:

#6895


Not sure how it works.

I'm trying to download this and test it out for work.
I downloaded NancyFx/Nancy and tried to build/run it, but I keep running into errors after errors because I'm missing a laundry list of dependencies.
I'm feeling stumped because it does not give clear instructions on how to use it or which libraries I am required.
I think in your wiki, you should include transparent instructions on what is required in order to use NancyFx, or the developers will be really frustrated with trying to comprehend it. Even I am struggling to infer between lines of why things are missing and when I try to look up the errors, I am directed to download and install a variety of things, which I think could be mentioned in the wiki. The wiki could also mention the workarounds if the users would like to avoid installing the components, or indicate that there are no workarounds to installing the required components.

Our Wiki does have quite extensive documentation

Including an entire section called Introduction which has a section called Creating your first Nancy application the documentation then goes on to describe the majority of the concepts of the framework.
Things aren't missing at all. The repository builds perfectly fine - we build it every day, multiple times.
There is also a pretty extensive file titled How_to_build.txt which explains how you can build Nancy using the RAKE script that is included. Not that it is required, all you need to do it pull down the solution, load it up and compile - not a single build error
I also welcome you to investigate any of the 20 demo projects in our repository or read any of the Blog posts, Video & Audio links that we provide on our Wiki
While you are at it, grab the free e-book
Have fun :smile:


The configured platforms don't match the Docker Engine's OS and architecture

Environment:

Jib version: 3.4.3
Build tool: Gradle 8.5
OS: Arch Linux x86_64, though it happens on Windows aswell

Description of the issue:
When running ./gradlew jibDockerBuild i get this error:
Execution failed for task ':jibDockerBuild'.
> com.google.cloud.tools.jib.plugins.common.BuildStepsExecutionException: The configured platforms don't match the Docker Engine's OS and architecture (/)
Caused by: com.google.cloud.tools.jib.plugins.common.BuildStepsExecutionException: The configured platforms don't match the Docker Engine's OS and architecture (/)
   at com.google.cloud.tools.jib.plugins.common.JibBuildRunner.runBuild(JibBuildRunner.java:285)
   at com.google.cloud.tools.jib.gradle.BuildDockerTask.buildDocker(BuildDockerTask.java:126)
   at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
   at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
   ... 118 more
Caused by: java.lang.IllegalStateException: The configured platforms don't match the Docker Engine's OS and architecture (/)
   at com.google.common.base.Preconditions.checkState(Preconditions.java:512)
   at com.google.cloud.tools.jib.builder.steps.StepsRunner.lambda$loadDocker$18(StepsRunner.java:628)
   at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131)
   at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75)
   at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82)

Expected behavior:
The image should be built and pushed to the local docker daemon
Steps to reproduce:
I don't know how to reproduce this 100%, i've had it work before, and fail the next day, the OS doesn't seem to matter since i've had it happen on both windows and linux.
jib-gradle-plugin Configuration:
jib.to.image = "xirado/bot-template"

Log output: Above

At first i thought this is related to #4265 but the error message seems to suggest the os and architecture from docker info is just empty, though i've myself checked and running it in the terminal returns desired results

I am facing the same issue with version com.google.cloud.tools:jib-maven-plugin:3.4.3. When I downgrade to 3.4.2, everything works normal.
My output of docker info (actually I am running podman 3.4.2) is
host:
  arch: amd64
  os: linux
...
version:
  APIVersion: 3.4.2
  OsArch: linux/amd64
  Version: 3.4.2
``

I can also confirm this.
$ docker info
Client: Docker Engine - Community
 Version:    27.0.3
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.15.1
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.28.1
    Path:     /usr/libexec/docker/cli-plugins/docker-compose

Server:
 Containers: 0
  Running: 0
  Paused: 0
  Stopped: 0
 Images: 0
 Server Version: 27.0.3
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae71819c4f5e67bb4d5ae76a6b735f29cc25774e
 runc version: v1.1.13-0-g58aa920
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.1.0-22-amd64
 Operating System: Debian GNU/Linux 12 (bookworm)
 OSType: linux
 Architecture: x86_64
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

The downgrade to 3.4.2 does also fix this for me as suggested by @giraone

Thanks for filing this issue and apologies for the inconvenience! 3.4.3 explicitly throws an exception when the docker info stats don't match the os/arch of the image jib is trying to build to the local docker daemon. However, this PR should address the failure you are facing: https://github.com/GoogleContainerTools/jib/pull/4268 and will be included in the next release. For now, please continue using 3.4.2 if this is blocking you.

So has this been fixed with release 3.4.4?

jib-maven-plugin 3.4.4 and jib-gradle-plugin 3.4.4 have been released (https://github.com/GoogleContainerTools/jib/releases) to address https://github.com/GoogleContainerTools/jib/issues/4265 and https://github.com/GoogleContainerTools/jib/issues/4265. Please let us know if you're running into any further issues!

jib-maven-plugin 3.4.4 and jib-gradle-plugin 3.4.4 have been released (https://github.com/GoogleContainerTools/jib/releases) to address #4265 and #4265.

The second issue should have probably said https://github.com/GoogleContainerTools/jib/issues/4283. Anyway, thanks for confirming the fix!


Adds to documentation intrinsic functions are not working in external swagger files

Issue #, if available:
Description of changes:
Documentation improvement: stating in the DefinitionUri section that intrinsic functions are not supported in the external Swagger files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #982 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #982   +/-   ##
========================================
  Coverage    94.71%   94.71%
========================================
  Files           69       69
  Lines         3160     3160
  Branches       606      606
========================================
  Hits          2993     2993
  Misses          85       85
  Partials        82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4031297...6c565f4. Read the comment docs.


When opening Ubuntu, how do I set 'startingDirectory' to be home path?

so that I don't input cd ~

/dup #2743


remove endpoint ready check

https://github.com/istio/istio/issues/24938

/test gencheck_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07e9da3e6e0585bf288a245c1f80b66e75044c0f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj @howardjohn
I am removing endpoint ready check  before we set the failurePolicy as FAIL for mutatingwebhookconfigurations in this PR. Can you share your lights whether this is a correct direction?
I think this is safe for us because:

This check is valid when we have a separate galley component. Now since we combined them together into one istiod, this check should be useless.
We will try dryRun first and only if the durRun has no issues we will set the failurePolicy as Fail.

@ayj A ping on this^^

In theory the check isn't entirely useless with istiod. It prevents the controller from attempting the dryRun every second before the endpoint is ready. In practice, if istiod becomes ready soon after deployment we wouldn't see many failed dryRun attempts.

Thanks @ayj  we are monitoring changes for ValidatingWebhookConfiguration and istiod endpoint only in this controller. So I am not clear why it will attempt dryRun every second. Suppose the reconcile will be triggered only if the ValidatingWebhookConfiguration has changes, so this should not be per second request.   Please correct me if I misunderstand.


How to initialize tracking in Objective C project

I've installed WebTrekk iOS sdk via cocoapods
My Podfile has
use_frameworks!
  pod 'Webtrekk'

Imported this in my AppDelegate.m (This auto-completed for me. So it's most likely right. ¯_(ツ)_/¯)
Used the following doc to ensure the import statement is correct:
https://developer.apple.com/library/content/documentation/Swift/Conceptual/BuildingCocoaApps/MixandMatch.html
#import <Webtrekk/Webtrekk-Swift.h>

I'm using WebTrekk usage doc from https://support.webtrekk.com/hc/en-us/articles/115001526005-iOS-Tracking-v4
Swift code to init tracker is try! WebtrekkTracking.initTrack()
I'm unable to call initTrack function in Objective C
[WebtrekkTracking initTrack]
Thoughts?

We don't support Objective-C. So I will close this ticket.


feat(cdk/observers): Choosing CDK MutationObserver properties

Feature Description
Hello, by default in the MutationObserver CDK all three types of changes are detected. It would be nice to be able to choose each of them on true or false for each use case.
https://github.com/angular/components/blob/3dc01c17f9201b2a4dcf1f1dc05c25cc2184f64c/src/cdk/observers/observe-content.ts#L131
greetings!
Use Case
Being able to choose what type of changes you want to observe.

Hi, I know it's web native, but the library hears three default options: characterData, childList and subtree. People may be interested in hearing only certain events and not all, or at least being able to choose. There is also no "attributes" property.
https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/observe#options
observer.observe(element, {
            characterData: true,
            childList: true,
            subtree: true,
          });


[WIP] Improve onboarding

Need to resolve merge conflicts.

Closing this in favor of keeping things in the single checklist template.


Fix typescript import error

Hi, I was trying to use tiny-emitter in a TypeScript 2.4.2 and Rollup project, and I have to import tiny-emitter like this:
import { EventEmitter } from 'tiny-emitter'

But if I do this, when I build my project use Rollup, it give me an error: EventEmitter not exported by tiny-emitter.
So I change the index.d.ts to fit TypeScript and Rollup, and now people can import tiny-emitter like this:
import EventEmitter from 'tiny-emitter'

Since tiny-emitter only have one default export so I think this is more suitable.
Related discussion: #21

This compiles for me but I get the following error at runtime:
TypeError: undefined is not an object (evaluating 'b.prototype')


Faster BasisSetRep

Use dictionary lookup rather than search when building the matrix for BasisSetRep as suggested by @mtsch.
Old:
julia> h = HubbardReal1D(BoseFS((1,2,0,1,1,1,1,1,1,1)))
HubbardReal1D(BoseFS{10,10}((1, 2, 0, 1, 1, 1, 1, 1, 1, 1)); u=1.0, t=1.0)

julia> @time m,v = build_sparse_matrix_from_LO(h);
 19.540310 seconds (277.24 k allocations: 95.071 MiB)

New (without compilation time):
julia>  @time m2,v2= build_sparse_matrix_from_LO(h);
  0.134440 seconds (139 allocations: 90.949 MiB)

julia> 19.540310/0.134440 # speedup
145.34595358524248

This is staggering! For larger Hamiltonians the speedup is even greater.
Thanks @mtsch for the suggestion!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 86.912%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
3161

Relevant Lines:
3637

💛  - Coveralls


Set up an ESP32-C3 project

Set up a basic project structure with the appropriate SDK and add it to the tree.
Ensure that it can be programmed by #4

See https://github.com/espressif/esp32c3-direct-boot-example for a simple project setup

Might fork https://github.com/espressif/esp-at and configure it to our needs?

Or maybe https://github.com/arduino/nina-fw

https://github.com/adafruit/nina-fw

https://github.com/adafruit/WiFiNINA/

Any progress with nina-fw on the ESP32-C3?


Create fr.yml

This adds French translations

Thanks! :)

Oops, looks like I failed to explain it to you ._. I were supposed to tell you the English translations (in the en.yml) were the ones to be translated. These default things and stuff are just for access :P Would you mind changing that? It's okay if you don't want to, cause this is awesome too.

Just the succeed and brushwand messages really, the rest looks good.

Oh oops. nooby me

I think it's good like this, but you'll have to change my edit if it's wrong.

Yeah thats fine

Yeah? Alright :) Thanks a lot!

Yeah it is good


handle android n in the android sdk

fix https://github.com/flutter/flutter/issues/2749
check for and and handle android-N in the android sdk (in addition to android-22, android-23, ...)

LGTM


devicequery segmentation fault

Tied a couple different approaches to running deviceQuery on Jetson TX2.  Segfaults every time.  I'm fairly certain it has to do with mismatches in library versions etc.
Is there a way to build it as part of generating the image?   Can I generate an SDK that will allow me to build it and match the versions?

I have added a recipe to extract the CUDA samples and build a couple of the simple ones (including deviceQuery).  I tested the cross-built sample programs on my Jetson-TX2, and they ran OK.
Hope this helps.

Thanks.  I’ll give it a try and let you know


Long delay when .init runs (debugging in VS code only?)

Eel version
Tried latest 1.x.x and also tried 0.14.0
Describe the bug
When eel.init runs, when I am running through debug in VS code, there is a delay as long as an entire minute before the GUI launches. This does NOT happen when running an exe compiled with pyinstaller
To Reproduce
Steps to reproduce the behavior:
Debug eel.init in vs code?
Expected behavior
GUI loads right away
Desktop (please complete the following information):

OS: [e.g. iOS] win 10
Browser [e.g. chrome, safari] chome or EDGE (tried both)
Version [e.g. 22] various

Additional context
Add any other context about the problem here.

After long hiatus I am looking at making some improvements to Eel, and I will look into this

It turns out in my case this was related to an ICO pack in the folder which
had thousands of files.
On Thu, Jul 22, 2021 at 4:07 AM Chris Knott @.***>
wrote:

After long hiatus I am looking at making some improvements to Eel, and I
will look into this
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ChrisKnott/Eel/issues/466#issuecomment-884797196, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7EOIO4PYVDRDPLWGRKJFLTY7UW7ANCNFSM4ZLPKE3Q
.


Add Polish translations

Translated all of the pages. Please let me know if there is anything left to translate that I missed.

I ran the command and fixed the issues.

Actually, I noticed the listing on the app stores has been recently translated using Weblate. Please don't merge this for a second while I make the terminology more consistent


Documentation migration

Hi,
i've done some work and migrated the documentation from codeplex to github.
You could find it under: https://github.com/ohaucke/HTML-Renderer/wiki
git clone https://github.com/ohaucke/HTML-Renderer.wiki.git
If you need help to merge this, feel free to contact me.

Awesome! I have copied the wiki, thank you so much!

You are welcome.
Maybe you should consider to move this repo to an organization, so it would be easier to manage the permissions and open up another repository for the wiki it self to manage pull request and changes?
E.g.
TheArtOfDev / HTML-Renderer (main code)
TheArtOfDev / HTML-Renderer-Wiki (code for wiki)
In "HTML-Renderer-Wiki" we could maintain all changes for the wiki and even have the abibility for pull requests (which is a shame that github doesn't support it natively) and after a update on this repo happens someone send it to https://github.com/ArthurHub/HTML-Renderer.wiki.git or we could write a webhook to do this automaticly.


Bug-fix: Initial load of website

Fix bug for the initial load of website saying rel="stylesheet” and not loading all other page content right away. This is mainly an issue for poor internet and it not loading quickly

Fixed in PR: https://github.com/Run-MPRC/Run-MPRC.github.io/pull/34
Exact commit hash: https://github.com/Run-MPRC/Run-MPRC.github.io/commit/7b94273d5bfd248c99304791146601782b4ca840


MSGraphClient still in preview?

If MSGraphClient is in preview and should not be used in a production environment, and the "GraphHttpClient has been deprecated and should no longer be used" ... which should be used given SPFx v1.4.1? Is the MSGraphClient really still in preview?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2381d26e-96c9-44de-8e4e-f70edc2db498
Version Independent ID: f81cacee-a1cd-89dd-ee53-c84689c03917
Content: Use the MSGraphClient to connect to Microsoft Graph
Content Source: docs/spfx/use-msgraph.md
Service: unspecified
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Deprecation means that we are not investing in it anymore, but it's still supported. It's true that we are in transition to a new model and we openly want to communicate this direction in the documentation to avoid any surprises. MSGraphClient is still in preview and we'll talk about the updated timelines on that one in Build 2018 and in SPC 2018. We will absolutely update this documentation when the situation changes.

MSGraphClient is officially launched now in November 2018
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-msgraph


go/types, types2: consider interpreting type X [P]T as generic type with missing constraint if P is not declared

See #55961 for back story.

The argument is that it is more likely that
type X[P] <some type literal>

where P is not defined, is a generic type declaration with missing constraint (e.g., any) rather than an array type declaration with missing array length P.

cc: @mdempsky @findleyr for feedback.

This sounds reasonable to me.
One concern is how to handle follow-on errors. E.g., I think ideally go/types would only report "P is undeclared" for the package below, though even today it also reports "cannot index a (variable of type X)". So it seems okay if we instead report a spurious "cannot use X without instantiation" error.
package p

type X [P]int

var a X
var b int = a[0]

Per discussion on the CL, while it's not hard to interpret an array declaration with an undefined length identifier as a generic type declaration with a missing type constraint, the re-interpretation leads to incorrect population of the various type-checker maps used by tools. Instead, opt for a better error message about the invalid array length.


Error margin

It replaces the previous PR. It does not duplicate symbol's tooltip anymore, it shows error / warning at the caret position.

The interesting thing that it shows error and warnings which the tooltip does not:

It is a nice side effect, isn't it?
I still think it is useful to duplicate tooltip information in the margin because:

Tooltip information is useful for non-error cases.
QuickInfo tooltips aren't copyable and controllable. I presume people want this info in a persistent place and the info can be copied to clipboard.

If you worry that the margin is too big, you can display the first line of comments and one-liner signature. For example, long type signature can be shortened to type R with only type names.
@enricosada @OkayX6 @forki @ovatsus Do you have any ideas to chime in?

Yes, the side effect is cool :)
I'm still not sure that tooltip duplication is a good idea:

the margin is constantly updating, which is distracting
what should be shown in case of error? The error? The type info? Both? If both, then it's necessary to make the margin taller to fit at least two lines of text. I'm against it.

Maybe it's better to use a tooltip-like window instead, which would displaying all the info (standard tooltip + warnings + errors)? It must be pops up by a hot key, of course (not by mouse hovering over a symbol).

Yeah, I meant to display both.
So the margin consists of at most 3 lines: one for comments, one for type signatures and one for errors/warnings. Being able to copy everything to clipboard would be cool. Perhaps it's too much for a small margin. I'm still interested in what others think about this.

I need to compile the PR to really test it, but I have never seen this margin used before? To me it is associated to the VsVim plugin??
What is it usually used for?

But, honestly from Vasily's animation, I quite like it.
I like having errors spotted immediately.
But, I also understand that some people can be bothered or distracted. I know people who were refusing to have a dual screen at Microsoft because they would be distracted with 2 screens... A matter of choice.

VsVim and Viasfora both have similar controls.
Here is the context.
We would like to add a feature that provides more information on symbols under cursors. Multiple versions have been requested at:

http://vfpt.uservoice.com/forums/247560-general/suggestions/5737085-add-a-pane-that-constantly-shows-the-tooltip-conte
http://vfpt.uservoice.com/forums/247560-general/suggestions/6143128-show-type-annotation-on-expression

The PR has added error/warning information under the cursor. It's useful, no doubt.
We are debating whether XmlDoc comments and type/function signatures should be added to the panel as well.
Pro: more information --> more useful
Cons: the margin becomes too big --> more distracting to users
What's your thought?

There are two distinct problems with large margin:

it steals too much space from editor window
it updates continuously

If we show errors / warnings only, it's updated very rarely, which is good.

The PR looks good. It would be great if you can add a short doc page for the new feature.

Done all. Feel free to fix the docs English.

I removed that buggy xaml stuff and implement the following double click behavior, right in code:

select all text
copy it to clipboard

The PR is ready for merging.

Cool.
Great jobs with reorganization of general dialog. Why wouldn't we think of the grouping technique before?


feat(mr): enable by default model registry inferenceservice reconcile

Description

Ref: RHOAIENG-15767
Recap:

The inferenceservice controller function has been moved to model registry and just imported here
The controller is enabled by default in the manifests using arg --model-registry-inference-reconcile
A new label has been added: modelregistry.opendatahub.io/name this is the name of the model registry from which we are deploying the model  - this is the name of the service/deployment (should be the same)
An annotation has been added: modelregistry.opendatahub.io/url this is the URL of the model registry where the controller will get/create the ServingEnvironment and the InferenceService, make sure that it is reachable from the controller's pod - in my tests I use the rest route generated from istio

How Has This Been Tested?

Prerequisites:

a model registry created using odh
a model version deployed

Enable image registry in the openshift cluster:

# enable default route for openshift image registry
oc patch configs.imageregistry.operator.openshift.io/cluster --type merge -p '{"spec":{"defaultRoute":true}}'
# get image registry host
export REGISTRY=`oc get route default-route -n openshift-image-registry --template='{{ .spec.host }}'`
# login to openshift registry
docker login -u $(oc whoami) -p $(oc whoami -t) $REGISTRY

Build and push the registry:

docker build . -f ./Containerfile -t ${REGISTRY}/opendatahub/odh-model-controller:latest
docker push ${REGISTRY}/opendatahub/odh-model-controller:latest

Enable devFlags inside the DataScienceCluster:

    kserve:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/Al-Pragliola/odh-model-controller/tarball/feat/enable-inference-mr'

Patch the image in the odh-model-controller's deployment:

oc patch deployment odh-model-controller --patch='{"spec": {"template": {"spec":{"containers": [{"name": "manager", "image": "image-registry.openshift-image-registry.svc:5000/opendatahub/odh-model-controller:latest"}]}}}}'

Get external route of MR

exoprt URL=`echo "https://$(oc get routes -n istio-system -l app.kubernetes.io/name=MODEL-REGISTRY-NAME -o json | jq '.items[].status.ingress[].host | select(contains("-rest"))')" | tr -d '"'`

Add url annotation and name label to the inferenceservice

oc annotate inferenceservices.serving.kserve.io -n inferenceservice-namespace inferenceservice-name modelregistry.opendatahub.io/url=$URL
oc label inferenceservices.serving.kserve.io -n inferenceservice-namespace inferenceservice-name modelregistry.opendatahub.io/name=MODEL-REGISTRY-NAME

Wait or watch odh-model-controller logs and then check the inferenceservice labels, a label called modelregistry.opendatahub.io/inference-service-id should have been added

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Looking at the code itself it looks ok to me, but I would rely on the Model Registry team review, once they give the green lights we can merge :)

/lgtm


Additional Latexes

Possible:

Dark Latex Pup [No Transfur]

Deer has been added

Deer has been added

The spider is OC?

Is the axolotl in the mod already? If not I suggest it

Croc has been added

Mermaid shark and manta rays have been added, but need an armor model.

Blue latex has been added

Done for now

Done for now


update colors for custom notifications

When I got custom notifications on hipchat, I got the wrong color for UP status, so I have modified to get the right color for custom notifications and up status.

Thanks!


Track when a patient becomes 'Ready'.

Track in a timestamp when a patient becomes 'Ready'.  Allow patients to be sorted by this date the Patients Index page.  This will help the study team to put the old 'Ready' patients on the bottom of the list.

Stale request.


Support for exec() at precompile time

Hi!
When I use exec('y = x**n') inside a function which i put a jit decorator before, it tries to jit the function including the exec() function (i. e. it wants to exec at runtime). Instead I'd wish that it does the exec, and then compiles the resulting function... which should be possible if many cases. Example:

n = 3
@jit
def f(x):
    # stuff
    exec(n * 'x = x**2\n')
    # other stuff

which i want to work like

@jit
def f(x):
    x = x**2
    x = x**2
    x = x**2
    return x

At the moment, it will first jit, then exec, instead of first exec and then jit. Lets call it precompile and postcompile exec...
This example is silly, but I have an example where code like "a[2] = c2" etc. could be avoided with the above idea

@mha-py thank you for submitting this. As a workaround, you could use the following exec based construct:
https://github.com/numba/numba/blob/master/numba/tests/test_typedlist.py#L612-L619
This should allow you to generate the function you need and then call it from your @njit decorated function.

I'll try that out, thank you!

@mha-py great, thanks for reporting back! Good luck and do let us know the results.


Switch CLI parsing to use CommandLineParser

The Spectre.Console.Cli parser is a bit too opinionated for my taste, requiring that options only appear after arguments. Switch to CommandLineParser.
As an example, gup fetch .. --dry-run is accepted, but gup fetch --dry-run .. is not.

Funny. I got the code working that ported over to CommandLineParser, only to find that it works exactly the same way.
The only remaining issue is finding a way to get a CancellationToken into the ExecAsync method. There seems to be a couple of plausible workarounds here.


Remove fs-based import from graphql-middleware

:tada: This PR is included in version 3.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use plugin to populate version

So tired of issues asking about __version__. This plugin should solve it once and for all, while allowing us to keep the same work-flow.
https://github.com/tiangolo/poetry-version-plugin

It turns out that the plugin itself is in alpha version at the moment, and relies on a beta version of Poetry 1.2.x - so we'd better wait for these 2 tools to be released in proper versions before using them :slightly_smiling_face:


Elementary OS added to the supported platforms.

Added Elementary OS to supported platforms since it is based in Ubuntu 14.04 and definitely works ok with Mockgoose/mongodb-download and mongodb. Interestingly os.platform() doesn't give "linux" in Elementary OS Freya, so two edits were required to make it work.

thank you


ghostscript: 9.24 -> 9.25

Backport of #47934 from master to release-18.09 (merged with #47903 and #47946). Please backport to 18.03 as well.
Changelog

Highlights in this release include:

This release fixes problems with argument handling, some unintended results of the security fixes to the SAFER file access restrictions (specifically accessing ICC profile files), and some additional security issues over the recent 9.24 release.

CVE-2018-16802
CVE-2018-17183

Note: The ps2epsi utility does not, and cannot call Ghostscript with the -dSAFER command line option. It should never be called with input from untrusted sources.
Security issues have been the primary focus of this release, including solving several (well publicised) real and potential exploits.
PLEASE NOTE: We strongly urge users to upgrade to this latest release to avoid these issues.
As well as Ghostscript itself, jbig2dec has had a significant amount of work improving its robustness in the face of out specification files.
IMPORTANT: We are in the process of forking LittleCMS. LCMS2 is not thread safe, and cannot be made thread safe without breaking the ABI. Our fork will be thread safe, and include performance enhancements (these changes have all be been offered and rejected upstream). We will maintain compatibility between Ghostscript and LCMS2 for a time, but not in perpetuity. Our fork will be available as its own package separately from Ghostscript (and MuPDF).
The usual round of bug fixes, compatibility changes, and incremental improvements.

(cherry picked from commit 5b77b0d2f1eda9a42fe188eafb499230741e7925)
cc @xeji
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test printing

Success on aarch64-linux (full log)
Attempted: tests.printing
Partial log (click to expand)
client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 211.68s
cleaning up
killing server (pid 631)
killing client (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/in8wbxl9rs4yxljwpdhq2jlsj2ikw68g-vm-test-run-printing

Success on x86_64-linux (full log)
Attempted: tests.printing
Partial log (click to expand)
client: running command: sync
client: exit status 0
4 out of 4 tests succeeded
test script finished in 144.52s
cleaning up
killing server (pid 600)
killing client (pid 612)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5s6d0wc6p9m93mqcqrfjxqwangndnk0m-vm-test-run-printing


Missing package.json key leads to errors

Excluding the "plugins": {} key/value from the package.json yields a non-helpful error:
Cannot convert undefined or null to object
Please either catch such a situation with a better error or add instructions to the documentation.

It should not throw in that case, thanks for reporting.

This was actually a bug in the electron-plugins package. Fixed in v0.0.4 of that package.


NEXT-11346 - successful deletion of an product variant - wrong success message

Action: Delete a variant of an article
Result: variant is deleted, but an incorrect "success" message appears
Text message:
Error
The variant has been deleted
Correct would be:
Success
The variant was deleted
meldung.JPG

It's already fixed!

It's already fixed!


emonstrates -> demonstrates

fix typo

@googlebot I signed it!

Awesome, thank you for helping us keep this quickstart polished :smile:


add PrintMessageSubCommand testCase

What is the purpose of the change
add test case for PrintMessageSubCommand.
Brief changelog
add test case.
Verifying this change
add test case
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

refine some code style

Coverage decreased (-0.2%) to 48.792% when pulling e9415a2c413d764b190dedd71d07aafa528ea2cc on linuful:develop into bbb723fb805357d0fb5caf2282c499d89469e994 on apache:develop.


Restore config fails if MA name matches, but ID doesn't. E.g. migrating config between environments

This scenario occurs when the AutoSync configuration is exported on one MIM environment, and is imported on a different environment which may contain a similar but not identical set of MAs.
For example:

Test environment contains 20 MAs, production contains 15.
AutoSync config exported on test environment
AutoSync config imported on production environment

The 5 missing MAs are reported in the log file correctly as:
2017-10-24 09:04:25.9283| WARN|Management agent could not be found. Name: 'Repopulation Test'. ID: 'e9e96f5e-274f-4674-b475-3669fa84e2ce'
However, the import fails with a message
"Could not import the file. An item with the same key has already been added"

On investigation, comparing the exported configuration from both environments, whilst the 15 MAs that they have in common have the same name, not all of them have the same GUID.
By modifying the xml to be imported so that the GUIDs match the values found in the production config, the import completes successfully.
It would be good if the import allowed for a match by MA name, and if one is found, ignores the conflicting ID and applies the configuration as an update rather than treating it as an "additional" MA. This is similar to how the sync engine "Update Management Agent" works when you import an updated config from test -> production. The GUIDs apparently don't need to match in that case.

@saturnreturn thanks for reporting this one. The MA resolver mechanism users ID first to find the MA (to detect renames), and if that fails, uses name. So in principal the use case of porting between environments has been taken care of.
I think there might be a problem with the enumerator of missing management agents. I will try to replicate this situation and repro the problem on my end.

So i've reproduced and fixed this issue, it was actually to do with the partitions, rather than the MA itself. Now that that is working, it's exposed another problem where the AD MA's partition name and ID are different across different domains/environments, and they are not being matched. I've got to have a bit of a think about how to handle this scenario.

Came across another scenario that might be related to this issue.. if you delete (or rename) an MA from the Sync Manager, then create a new one with the same name, then go back to AutoSync and do "reload config", you get the same error, "Item with the same key has already been added". The AutoSync GUI shows the execution monitor, but all of the other items that used to be in the left hand list are gone, so AutoSync can basically not be configured any more. Also at this point, the backup/restore are greyed out, so the previously working config cannot be loaded either! Not sure how to recover from this...

@saturnreturn apologies for this. It is the same root cause - a bug in the partition matching code.
I have fixed this in the code base, but i'm still working on some other issues before I can release it.
Can you work around this by modifying the config.xml file with the new ID?

Hi Ryan,
Thanks for the tip. This did work. It took me a while to work out that it was not just the MA ID, but also the Partition ID that needed to be updated manually in the config.xml, but it's back now, so that's good.
I'd noticed you made a commit that looked like it might have resolved it and tried to build the project myself, but ran in to all sorts of dependency issues. I've resolved most errors, but still having issues getting the AutoSync.Editor project to build. Not sat down properly to work it out, but think I might not have the correct Presentation (or some other lithnet) package from NuGet.
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS1501	No overload for method 'AddItem' takes 5 arguments	Lithnet.Miiserver.AutoSync.Editor	C:\github\miis-autosync\src\Lithnet.Miiserver.Autosync.UI\ViewModels\MainWindowViewModel.cs	65	Active


Add React component to show all short links created by the user

Currently, users can't see all the short links they created.

Add React component with dummy data to show all the linked created by the user after he, she or they signed in.

I'd like to try this if this is still available but I'll probably have lots of questions.

@shade34321 Sounds good. Please feel free to ask question or suggest refactor.

@shade34321 Please join this Slack channel to discuss bugs, dev environment setup, tooling, and coding best practices.

Oh man, I never saw this message. I"ll see if I can work on it later this weekend or next. I'm sorry!

For this task, does the UI need to be in place? In other words, is the expectation that after it is done, whoever works on the backend API for read/write to the database can just populate the component and enable the feature to live?

@JackieYJC Mostly yes. For now, we just populate fake data and turn off the feature toggle. We will have to make small change to our frontend data service to make sure it pulls data from real backend.

@JackieYJC Mostly yes. For now, we just populate fake data and turn off the feature toggle. We will have to make small change to our frontend data service to make sure it pulls data from real backend.

Gotcha, I'm considering using tables from this source: https://material-ui.com/components/tables/

@JackieYJC Prefer building the components ourselves so that we:

easily customize the styles
add new features
learn how the internals work

@byliuyang Yes, I don't intend to copy-and-paste anything. Just learn their tricks and apply it here. A table is a table 😛

@JackieYJC Let's split this issue into few PRs:

The reusable table component
The reusable pagination component
The ShortLinks  component
Fake  ShortLinkService
Integrate ShortLinks  component and ShortLinkService in Home page with feature toggle turned off.

@byliuyang I am wondering if we should fix column width of the tables.

@rohithbalaji123 Let's open an new issue for it!


command-line-slangc-reference.md: fixed  HTML tag

Fixed the broken tag introduced by #5507.
Also, the file seemed to have UTF-16LE encoding unlike other files I checked. Since I was lazy and did the changes through GitHub UI, it automatically converted the changes to UTF-8. Let me know if this is a problem, but UTF-16LE sounds bit unintentional than a "feature" anyway.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This file is generated by running slangc -h, so we shouldn't be changing this file directly. Modifications should be made to source\slang\slang-options.cpp or to the source code that produces this md file.


Fix include/exclude functionality

Here is some fixes,

test is actually doesn't test anything in master, it's better to use  waitsForPromise ->  for promises
I've added glob patterns support and remove expandPath

about expandPath I don't know how to test it or mock it, and it works really slow for me. Can you help me with it ? Any way I would like to see any response if possible.

test is actually doesn't test anything in master, it's better to use waitsForPromise -> for promises

I could have sworn I checked that. I'm not familiar with jasmine but I thought it was working. I'll defer to you here though.

I've added glob patterns support

Yeah. minimatch is much better than the within checking I was doing. :+1:

[...] and remove expandPath

Yeah. I'd love for this to be a thing (as it allows for $HOME/Workspace or similar) but I thought it might cause problems. I'm fine with dropping it. This also means that we can drop the async from filterProjects.

@shemerey I removed the promise on 6f21001

:+1:  thx


{Compute} Bump version for azure-mgmt-compute package

Related command

Description

Bump version for azure-mgmt-compute package: 29.1.0 -> 30.0.0
Upgrade api version for MGMT_COMPUTE resource type: virtual_machine_scale_sets 2022-11-01 -> 2023-03-31
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute

The reason of changing some custom functions from positional to key=value arguments is due to a breaking change of Python SDK, e.g., https://github.com/Azure/azure-sdk-for-python/blob/azure-mgmt-compute_30.0.0/sdk/compute/azure-mgmt-compute/azure/mgmt/compute/v2023_03_01/operations/_operations.py#L6997


bug: wrong code snippet in serverless's doc

https://github.com/apache/incubator-apisix/blob/master/doc/plugins/serverless.md
in the How To Enable section, curl's command is wrong, should be:
curl -i http://<IP_ADDRESS>:9080/apisix/admin/routes/1 -X PUT -d '{
	"uri": "/index.html",
	"plugins": {
		"serverless-pre-function": {
			"phase": "rewrite",
			"functions": ["return function() ngx.log(ngx.ERR, \"serverless pre function\"); end"]
		}
	},
	"upstream": {
		"type": "roundrobin",
		"nodes": {
			"<IP_ADDRESS>:80": 1
		}
	}
}'

it has been fixed, we can close this issue


Implement Writable for the Volume plugin

Volumes now support writing content to files. Resolves #675.
Depends on #773 to ensure writes are immediately visible.

I think this is ready again.


merge polygons

The data structure should make merging of adjacent polygons easy. Can you give me some hints how to implement a merging algorithm? The javascript topojson library does contain this functionalitiy (https://github.com/mbostock/topojson/wiki/API-Reference#wiki-merge) but I want to do it server side and with java.

No answer? Some comment on his would be really helpful.

Hi,
Yes this is more a mergeArcs function, should not be to complex, we have to remove arcs in common between 2 polygons. I have not so much time for now, but for sure I will have a look to it.
Cheers,
Ju

Great to hear that you will have a look at it. Please contact me if you got any news on this or if I can help you in any way.

I don't want to push but do you have any rough estimate on a timetable?


[WIP] Linter for undefined variables

Fixes #639
Fixes #395
Fixes #461
Fixes #475
Fixes #476
Fixes #513
Fixes #734

Walk AST post analysis and use analysis to find out declared variables. Special filtering and handling of comprehensions. Includes #711
Adds support for analysis of comprehensions. Fixes issue when comprehension variables were not declared in scope. Adds handling of tuple expressions in for in loops.
Adds support for lambdas. Enables related tests.

Added settings plumbing to turn linter on/off via existing extension setting.

There are a few false positives, which can be seen in least_angle.py in the scikit-learn repo

Builtin types (str, DeprecationWarning)
Uses of function parameters.
Some builtin functions like print, isinstance, abs.

Any specific for function arguments?

lars_path:

But:
def lars_path(X, y, Xy=None, Gram=None, max_iter=500,
              alpha_min=0, method='lar', copy_X=True,
              eps=np.finfo(np.float).eps,
              copy_Gram=True, verbose=0, return_path=True,
              return_n_iter=False, positive=False):

That seemed to fix many of the cases, but some still seem to be reported, like:

method is still reported (it's also a param), but X and y aren't anymore with that commit. alpha_min, copy_Gram are reported, and drop is too though it's a local variable and not a parameter, defined as drop = False at the topmost level of that function.

Yes, analysis was missing handling of comprehension (list) statements, handling of tuple expressions in for loops as well as handling of lambdas. Basically analysis issues, less of that of the linter. Related #734 which also requires the above.

Working a lot better now, one more thing in scikit-learn's k_means_.py:

Which is caused by a pyx import:

However if I try to make a minimal example where I do from idontexist import foo and use foo, it doesn't warn.

This one seems to be tuple/iterator related as well (hierarchical.py next to k_means_.py):

Speaking of imports @AlexanderSher can comment. I think there are different cases when imported variable was declared as unknown (and hence IS defined technically) vs code didn't even reach state of declarations as, I guess, happens with pyx.
I'll look into the iterator

Which is caused by a pyx import:

Yes, we don't support CPython.

Right, but I think what is weird is that in one case, if the imported module doesn't exist like from idontexist import foo, foo is declared, but when it's idontexist.pyx or similar, then doing the same thing causes foo to not be declared.


Server interceptor test should understand the health checking service

Fixes a breakage when this test is used with health checking enabled

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,388      Total (=)      2,019,388

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,154,191      Total (>)     11,154,183

 No significant differences in binary sizes

Corrupt JSON data (indicates timeout or crash):
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10

[microbenchmarks] No significant performance differences


[FIX] Code injection through "eval()"

Bounty URL: https://www.huntr.dev/bounties/1-npm-cd-messenger
⚙ Description *
A code injection issue existed in the line function due to the usage of eval on user-supplied inputs which could lead to JS/command injection.
💻 Technical Description *
I inserted a check for valid colors in order to match only values containing letters: the colors accepted by chalkline are the ones taken from chalk, which takes the names from https://github.com/Marak/colors.js (see README.md  --> colors and styles!)
🐛 Proof of Concept (PoC) *

Download the package
Make the PoC file:

// poc.js
var a = require("./cd-messenger");
a.line("red(); console.log('JHU'); //");

A red line and the JHU string will be printed

🔥 Proof of Fix (PoF) *
Same steps of above, but an error is displayed and no evaluation happens

👍 User Acceptance Testing (UAT)
The fix checks only if the color passed is composed by only letters, making impossible break anything :smile:

Sorry Mik317, we enjoyed reviewing your fix but it has not been selected this time. If this bounty has not been closed, please feel free to try again with a new pull request!
We appreciate your effort and look forward to reviewing more of your fixes in the future! 🔨😎


Please bump argcomplete dependency to support 3.0.0 or higher

The azure-cli-core component still depends on argcomplete>=2.0,<3.0 while 3.0.0 has been available since March.
Could you bump the version for argcomplete so that we can get the added benefits of full zsh support and various other bug fixes?
Just the same as https://github.com/Azure/azure-cli/issues/23222

Thank you for opening this issue, we will look into it.

Hi @yonzhan thank you so much, it would be greatly appreciated. Then I can resolve some version conflicts!

Fixed in https://github.com/Azure/azure-cli/pull/26684


Slow Graph Export

@amoeba noticed that the graph export is pretty slow. We might be able to speed it up by exporting to N-Triples instead of turtle.

Since the data change rarely, we might also think up a way to just server a static dump in one format or another.
As a data point for the current speed of the /data endpoint, I get an order of magnitude increase in transfer rate (~300KB/s to ~3000KB/s) when dumping the entire graph as a CSV via SPARQL compared to the /data endpoint so there must be a way to make /data faster.

Changing the export type to n-triples I get download speeds of ~2500k, which is a huge improvement over the ttl format performance. I think that this is fast enough for downloading the roughly 2.5 GB of data. This has been deployed on stage and can be tested there.

That's great to hear. I did just try it (https://stage.gnis-ld.org/data) and only got 250k/s. I tried again from an NCEAS host and the request is actually hanging right now. The second issue is kinda weird.

With the image management issues I was having over, this issue should be testable on stage again (sorry for having to test twice). The speed is a little over 1 MB/S on my connection (which is top speeds for my provider).

Looks pretty good here: Varying from 5-10MB/s (average 6MB/s) from campus. Thanks @ThomasThelen. That speed bump makes it much more practical to export everything. I did notice the size of the exported NTriples file is now 5.4G but still 32,949,518 triples. Could we update the text on the home page to match?

Good catch - updated on stage, shown below

Great, thanks.


Json serialization can not process empty string

I found that , when my resource is an empty string, then wakaama process json serialization fails. Any way, string resource can be empty, right?
res = json_escapeString(buffer + head,                                 bufferLen - head,                                 tlvP->value.asBuffer.buffer,                                 tlvP->value.asBuffer.length);
        if (!res) return -1;

I'd recommend changing if (!res) return -1; to if (tlvP->value.asBuffer.length && !res) return -1;. when I get a chance I'll add test cases for empty strings for all formats and fix this on my version. I don't know when I'll be able to get it merged.

I already have fixed this in https://github.com/sbertin-telular/wakaama/tree/lwm2m_1.1. When pull requests start to be merged again I will submit my changes for merging also.

@sbertin-telular possible for you to submit the fix?

If this is urgent, go ahead and submit a fix. I don't remember exactly where that change is and my changes for LWM2M 1.1 tend to build on each other. I can deal with the conflict when I get to my change.

ok, it is not urgent. Just an ambition to reduce the number of open issues (bugs).


Add availability attribute to cli node show specs

Fixes broken CLI specs in master branch.

Broken in #2306 merge after #2678 added a second spec case with separate expected output


[TRANSLATIONS]  malayalam language

[x] Base README.md
[ ] for-teachers.md
[ ] Quizzes
[ ] 1-getting-started-lessons base README

[ ] intro-to-programming-languages README
[ ] intro-to-programming-languages assignment
[ ] github-basics README
[ ] accessibility README
[ ] accessibility assignment

[ ] 2-js-basics base README

[ ] data-types README
[ ] data-types assignment
[ ] functions-methods README
[ ] functions-methods assignment
[ ] making-decisions README
[ ] making-decisions assignment
[ ] arrays-loops README
[ ] arrays-loops assignment

[ ] 3-terrarium base README

[ ] intro-to-html README
[ ] intro-to-html assignment
[ ] intro-to-css README
[ ] intro-to-css assignment
[ ] intro-to-DOM-and-closures README
[ ] intro-to-DOM-and-closures assignment

[ ] 4-typing-game base README

[ ] typing-game README
[ ] typing-game assignment

[ ] 5-browser-extension base README

[ ] about-browsers README
[ ] about-browsers assignment
[ ] forms-browsers-local-storage README
[ ] forms-browsers-local-storage assignment
[ ] background-tasks-and-performance README
[ ] background-tasks-and-performance assignment
[ ] solution base README
[ ] start base README

[ ] 6-space-game base README

[ ] introduction README
[ ] introduction assignment
[ ] drawing-to-canvas README
[ ] drawing-to-canvas  assignment
[ ] moving-elements-around README
[ ] moving-elements-around  assignment
[ ] collision-detection README
[ ] collision-detection assignment
[ ] keeping-score README
[ ] keeping-score assignment
[ ] end-condition README
[ ] end-condition assignment

[ ] 7-bank-project base README

[ ] template-route README
[ ] template-route assignment
[ ] forms README
[ ] forms  assignment
[ ] data README
[ ] data assignment
[ ] state-management README
[ ] state-management  assignment
[ ] solution base README

Hello,
Should my mother tongue definitely be Malayalam to help with translation ? or can I use the google translator or any other translator and get it verified by friends and accquaintances who speak Malayalam ?

hi, It's much preferable that the lead translator be fluent in Malayalam. We discourage use of Google translate in general, thank you however for the offer!


Android PlatformView in Hybrid mode stops rendering when rotating only on certain devices (Tablet)

In Japan we have a tablet (d-02K) that when you have a PlatformView in Hybrid mode rendering a video using ExoPlayer with DRM enabled on that content, and you rotate the device to change orientation, the rendering from that point on fails and a black screen is rendered instead.
This only happens on this device (so far that we know).
This also does not happen without flutter and just a standard kotlin android app.
Android Version: 8.0.0
CPU: Hisilicon Kirin 659
Steps to Reproduce

Create an app with the below code
Run the app (probably only on that or similar device)
A Widevine DRM video will play
Rotate the device so as to cause an orientation change
Observe that rendering has failed (audio still plays)

Sample Code main.dart
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({
    Key key,
    this.title,
  }) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  static const MethodChannel _channel =
      const MethodChannel('com.example/exoflutter');
  static dynamic get _createExoPlayer async {
    final dynamic result = await _channel.invokeMethod('createPlayer');
    return result;
  }

  Key _key;

  @override
  void initState() {
    super.initState();
    // Android Versionを表示する
    _createExoPlayer.then((value) => print(value));
    _key = GlobalKey();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: FutureBuilder(
        future: _createExoPlayer,
        builder: (context, snapshot) {
          if (snapshot.hasData) {
            return PlatformViewLink(
              key: _key,
              viewType: 'com.exoplayer.playerview',
              surfaceFactory: (context, viewController) {
                return AndroidViewSurface(
                  controller: viewController,
                  hitTestBehavior: PlatformViewHitTestBehavior.transparent,
                  gestureRecognizers: const <
                      Factory<OneSequenceGestureRecognizer>>{},
                );
              },
              onCreatePlatformView: (params) {
                return PlatformViewsService.initSurfaceAndroidView(
                  id: params.id,
                  viewType: params.viewType,
                  layoutDirection: Directionality.of(context),
                  creationParams: const <String, dynamic>{},
                  creationParamsCodec: const StandardMessageCodec(),
                )
                  ..addOnPlatformViewCreatedListener(
                      params.onPlatformViewCreated)
                  ..create();
              },
            );
          } else {
            return Center(
              child: Text("Loading"),
            );
          }
        },
      ),
    );
  }
}

Sample Code build.gradle
def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
    compileSdkVersion 29

    sourceSets {
        main.java.srcDirs += 'src/main/kotlin'
    }

    lintOptions {
        disable 'InvalidPackage'
    }

    defaultConfig {
        // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
        applicationId "com.example.exoflutter"
        minSdkVersion 16
        targetSdkVersion 29
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
    }

    buildTypes {
        release {
            // TODO: Add your own signing config for the release build.
            // Signing with the debug keys for now, so `flutter run --release` works.
            signingConfig signingConfigs.debug
        }
    }

    compileOptions {
        targetCompatibility = JavaVersion.VERSION_1_8
        sourceCompatibility = JavaVersion.VERSION_1_8
    }
}

flutter {
    source '../..'
}

dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
    implementation 'com.google.android.exoplayer:exoplayer:2.12.3'
}

MainActivity.kt
package com.example.exoflutter

import android.os.Bundle
import android.util.Log
import com.google.android.exoplayer2.MediaItem
import com.google.android.exoplayer2.SimpleExoPlayer
import com.google.android.exoplayer2.ui.PlayerView
import io.flutter.embedding.android.FlutterActivity
import io.flutter.embedding.engine.FlutterEngine
import io.flutter.embedding.engine.plugins.FlutterPlugin
import io.flutter.plugin.common.MethodCall
import io.flutter.plugin.common.MethodChannel
import io.flutter.plugins.GeneratedPluginRegistrant

class MainActivity: FlutterActivity() {
    companion object {
        private const val CHANNEL_NAME = "com.example/exoflutter"
        private const val METHOD_GET_ANDROID_VERSION = "getPlatformVersion"
        private const val METHOD_CREATE_PLAYER = "createPlayer"
    }

    private lateinit var channel: MethodChannel

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
    }

    override fun onAttachedToWindow() {
        super.onAttachedToWindow()
    }

    override fun configureFlutterEngine(flutterEngine: FlutterEngine) {
        GeneratedPluginRegistrant.registerWith(flutterEngine)

        channel = MethodChannel(flutterEngine.dartExecutor.binaryMessenger, CHANNEL_NAME)

        channel.setMethodCallHandler { methodCall: MethodCall, result: MethodChannel.Result ->
            if (methodCall.method == METHOD_GET_ANDROID_VERSION) {
                result.success("Android ${android.os.Build.VERSION.RELEASE}")
            } else if (methodCall.method == METHOD_CREATE_PLAYER) {
                flutterEngine
                        .platformViewsController
                        .registry
                        .registerViewFactory("com.exoplayer.playerview", NativeViewFactory())
                result.success(true)
            }
            else
                result.notImplemented()
        }
    }

}

NativeViewFactory.kt
package com.example.exoflutter

import android.content.Context
import android.view.View
import io.flutter.plugin.common.StandardMessageCodec
import io.flutter.plugin.platform.PlatformView
import io.flutter.plugin.platform.PlatformViewFactory

class NativeViewFactory : PlatformViewFactory(StandardMessageCodec.INSTANCE) {
    override fun create(context: Context, viewId: Int, args: Any?): PlatformView {
        val creationParams = args as Map<String?, Any?>?
        return NativeView(context, viewId, creationParams)
    }
}

NativeView.kt
package com.example.exoflutter

import android.content.Context
import android.util.Log
import android.view.View
import com.google.android.exoplayer2.C
import com.google.android.exoplayer2.MediaItem
import com.google.android.exoplayer2.SimpleExoPlayer
import com.google.android.exoplayer2.ui.PlayerView
import io.flutter.plugin.platform.PlatformView

internal class NativeView(context: Context, id: Int, creationParams: Map<String?, Any?>?) : PlatformView {
    private var simpleExoPlayer: SimpleExoPlayer? = null
    private lateinit var playerView: PlayerView

    override fun getView(): View {
        return playerView
    }

    override fun dispose() {}

    init {

        simpleExoPlayer = SimpleExoPlayer.Builder(context).build()
        playerView = PlayerView(context)
        playerView.player = simpleExoPlayer
        val mediaItem: MediaItem = MediaItem.Builder()
                .setUri("https://storage.googleapis.com/wvmedia/cenc/h264/tears/tears.mpd")
                .setDrmUuid(C.WIDEVINE_UUID)
                .setDrmLicenseUri("https://proxy.uat.widevine.com/proxy?video_id=GTS_SW_SECURE_CRYPTO&provider=widevine_test")
                .setDrmMultiSession(true)
                .build()

        playerView.player?.setMediaItem(mediaItem)
        playerView.player?.prepare()
        playerView.player?.play()
    }
}

Expected results: The PlatformView area continues to show the video
Actual results: The PlatformView area goes black

Logs
flutter run --verbose
[  +15 ms] E/BufferQueueProducer(19696): [ImageReader-1920x1117f1m3-19696-2] disconnect: not connected (req=1)

This above part is particularily suspicious.
[+3316 ms] I/flutter (19696): true
[ +117 ms] W/Settings(19696): mValues not put! needsGenerationTracker: true currentGeneration: -1 name: accessibility_captioning_enabled value: null
[  +69 ms] I/HwCust  (19696): Constructor found for class android.net.HwCustConnectivityManagerImpl
[        ] D/HwCust  (19696): Create obj success use class android.net.HwCustConnectivityManagerImpl
[  +42 ms] I/ExoPlayerImpl(19696): Init 296f363 [ExoPlayerLib/2.12.3] [d-02K, d-02K, HUAWEI, 26]
[  +59 ms] D/HwGalleryCacheManagerImpl(19696): mIsEffect:false
[ +154 ms] I/zygote64(19696): Do partial code cache collection, code=27KB, data=28KB
[   +1 ms] I/zygote64(19696): After code cache collection, code=27KB, data=28KB
[        ] I/zygote64(19696): Increasing code cache capacity to 128KB
[ +258 ms] W/libEGL  (19696): EGLNativeWindowType 0x73d0f88010 disconnect failed
[        ] D/mali_winsys(19696): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[  +58 ms] D/mali_winsys(19696): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[ +938 ms] I/zygote64(19696): Do partial code cache collection, code=61KB, data=51KB
[   +1 ms] I/zygote64(19696): After code cache collection, code=61KB, data=51KB
[        ] I/zygote64(19696): Increasing code cache capacity to 256KB
[ +100 ms] W/VideoCapabilities(19696): Unrecognized profile/level 1/32 for video/mp4v-es
[        ] I/VideoCapabilities(19696): Unsupported profile 16384 for video/mp4v-es
[   +3 ms] I/VideoCapabilities(19696): Unsupported profile 16384 for video/mp4v-es
[  +13 ms] W/VideoCapabilities(19696): Unsupported mime video/x-pn-realvideo
[   +2 ms] W/VideoCapabilities(19696): Unsupported mime video/mpeg
[   +3 ms] W/VideoCapabilities(19696): Unrecognized profile/level 0/0 for video/mpeg2
[        ] W/VideoCapabilities(19696): Unrecognized profile/level 0/2 for video/mpeg2
[        ] W/VideoCapabilities(19696): Unrecognized profile/level 0/3 for video/mpeg2
[   +7 ms] W/VideoCapabilities(19696): Unrecognized profile/level 32768/2 for video/mp4v-es
[   +6 ms] W/VideoCapabilities(19696): Unsupported mime video/vc1
[   +9 ms] W/VideoCapabilities(19696): Unsupported mime video/x-flv
[  +55 ms] I/VideoCapabilities(19696): Unsupported profile 4 for video/mp4v-es
[+1854 ms] I/OMXClient(19696): Treble IOmx obtained
[ +134 ms] I/ACodec  (19696): In onAllocateComponent create compenent, codec name: OMX.google.aac.decoder
[   +5 ms] W/HwExtendedUtils(19696): hw configLocalPlayBack err = -2147483648
[  +14 ms] I/ACodec  (19696): codec does not support config priority (err -2147483648)
[   +1 ms] I/ACodec  (19696): onStart
[  +45 ms] D/ACodecBufferChannel(19696): setHeap returned mHeapSeqNum=0
[ +177 ms] I/OMXClient(19696): Treble IOmx obtained
[  +65 ms] I/ACodec  (19696): In onAllocateComponent create compenent, codec name: OMX.IMG.MSVDX.Decoder.AVC.secure
[   +2 ms] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason connectToSurface
[        ] I/MediaCodec(19696): [OMX.IMG.MSVDX.Decoder.AVC.secure] setting surface generation to 20168705
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason connectToSurface(reconnect)
[        ] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason connectToSurface(reconnect)
[   +1 ms] W/HwExtendedUtils(19696): hw configLocalPlayBack err = -1010
[        ] E/ACodec  (19696): [OMX.IMG.MSVDX.Decoder.AVC.secure] setPortMode on output to DynamicANWBuffer failed w/ err -1010
[   +1 ms] I/HwExtendedCodec(19696): mime is [video/avc] at setVideoFormat
[        ] I/ACodec  (19696): codec does not support config priority (err -1010)
[  +34 ms] I/ACodec  (19696): onStart
[ +111 ms] D/ACodecBufferChannel(19696): setHeap returned mHeapSeqNum=0
[        ] I/HwExtendedUtils(19696): error setConfig queuesToNativeWindow (err -1010)
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): set up nativeWindow 0x73c8ffb010 for 864x384, color 0x300, rotation 0, usage 0x24006900
[ +408 ms] D/AudioTrack(19696): OFFLOAD 0,mNotificationFrames 0,mStreamType =-1,mOriginalSampleRate 44100,mAfSampleRate 48000,mTransfer 3
[        ] D/AudioTrack(19696): Client defaulted notificationFrames to 3675 for frameCount 11025
[  +13 ms] I/AudioTrack(19696): audioTrack send start state to pg
[  +26 ms] I/zygote64(19696): Do full code cache collection, code=124KB, data=98KB
[        ] I/zygote64(19696): After code cache collection, code=98KB, data=57KB
[ +163 ms] I/HwExtendedUtils(19696): error setConfig queuesToNativeWindow (err -1010)
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): set up nativeWindow 0x73c8ffb010 for 864x384, color 0x300, rotation 0, usage 0x24006900
[ +170 ms] D/android.media.AudioTrack(19696): [HSM] AudioTrace play() uid: 10185, pid: 19696
[+2805 ms] I/zygote64(19696): Do partial code cache collection, code=121KB, data=87KB
[        ] I/zygote64(19696): After code cache collection, code=121KB, data=87KB
[        ] I/zygote64(19696): Increasing code cache capacity to 512KB
[+8130 ms] W/libEGL  (19696): EGLNativeWindowType 0x73d0f0c010 disconnect failed
[        ] D/mali_winsys(19696): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[  +40 ms] D/mali_winsys(19696): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[ +559 ms] E/BufferQueueProducer(19696): [ImageReader-1200x1836f1m3-19696-1] disconnect: not connected (req=1)
[        ] W/libEGL  (19696): EGLNativeWindowType 0x73cacdb010 disconnect failed
[  +29 ms] D/mali_winsys(19696): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[ +185 ms] I/zygote64(19696): NativeAllocBackground concurrent copying GC freed 3124(234KB) AllocSpace objects, 2(136KB) LOS objects, 49% free, 23MB/46MB, paused 2.096ms total 119.092ms
[ +337 ms] I/HwExtendedUtils(19696): error setConfig queuesToNativeWindow (err -1010)
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[   +6 ms] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason setNativeWindowSizeFormatAndUsage
[   +1 ms] D/SurfaceUtils(19696): set up nativeWindow 0x73c8ffb010 for 1280x576, color 0x300, rotation 0, usage 0x24006900
[+9297 ms] D/SurfaceUtils(19696): connecting to surface 0x73e9ead010, reason connectToSurface
[   +1 ms] I/MediaCodec(19696): [OMX.IMG.MSVDX.Decoder.AVC.secure] setting surface generation to 20168706
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73e9ead010, reason connectToSurface(reconnect)
[        ] D/SurfaceUtils(19696): connecting to surface 0x73e9ead010, reason connectToSurface(reconnect)
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73e9ead010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): connecting to surface 0x73e9ead010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(19696): set up nativeWindow 0x73e9ead010 for 1280x576, color 0x300, rotation 0, usage 0x24006900
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason pushBlankBuffersToNativeWindow
[   +2 ms] D/SurfaceUtils(19696): set up nativeWindow 0x73c8ffb010 for 1x1, color 0x2, rotation 0, usage 0x930
[  +20 ms] D/SurfaceUtils(19696): connecting to surface 0x73c8ffb010, reason pushBlankBuffersToNativeWindow(err2)
[        ] D/SurfaceUtils(19696): disconnecting from surface 0x73c8ffb010, reason disconnectFromSurface
[  +41 ms] W/libEGL  (19696): EGLNativeWindowType 0x73d0f0c010 disconnect failed
[ +267 ms] W/IInputConnectionWrapper(19696): beginBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(19696): endBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(19696): beginBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(19696): endBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(19696): beginBatchEdit on inactive InputConnection
[   +1 ms] W/IInputConnectionWrapper(19696): endBatchEdit on inactive InputConnection
[+1171 ms] W/InputMethodManager(19696): startInputReason = 3
[        ] W/InputMethodManager(19696): reStartinput failed, need refresh!
[  +15 ms] E/BufferQueueProducer(19696): [ImageReader-1920x1117f1m3-19696-2] disconnect: not connected (req=1)
[        ] W/libEGL  (19696): EGLNativeWindowType 0x73d0963010 disconnect failed
[ +224 ms] Service protocol connection closed.
[   +1 ms] Lost connection to device.
[   +3 ms] executing: /Users/koji.yamada/Library/Android/sdk/platform-tools/adb -s VMT0118403000310 forward --list
[  +10 ms] Exit code 0 from: /Users/koji.yamada/Library/Android/sdk/platform-tools/adb -s VMT0118403000310 forward --list
[        ] VMT0118403000310 tcp:59108 tcp:41409
[   +1 ms] executing: /Users/koji.yamada/Library/Android/sdk/platform-tools/adb -s VMT0118403000310 forward --remove tcp:59108
[  +13 ms] DevFS: Deleting filesystem on the device (file:///data/user/0/com.example.exoflutter/code_cache/exoflutterRGTEHA/exoflutter/)
[ +261 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +2 ms] executing: /Users/koji.yamada/Library/Android/sdk/platform-tools/adb -s VMT0118403000310 forward --list
[  +10 ms] Exit code 0 from: /Users/koji.yamada/Library/Android/sdk/platform-tools/adb -s VMT0118403000310 forward --list
[   +2 ms] "flutter run" took 69,578ms.
[   +3 ms] ensureAnalyticsSent: 0ms
[        ] Running shutdown hooks
[        ] Shutdown hook priority 4
[   +3 ms] Shutdown hooks complete
[        ] exiting with code 0

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.7 19H114 darwin-x64, locale en-CA)
    • Flutter version 1.22.4 at /Users/xxxx/source/flutter-1.22
    • Framework revision 1aafb3a8b9 (3 months ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/xxxx/source/android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/xxxxx/source/android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

@Moncader
Thanks for providing the detailed code sample. How and where can we put NativeViewFactory.kt and NativeView.kt files in order to use it ?
Also, if possible, can you provide all these details in a github repo and share the link that we can clone and directly run and verify the issue ?
Thanks.

@darshankawar
https://github.com/Moncader/flutter-75698
Here you go!

@Moncader Thanks for the repo. I cloned it and ran on latest stable using Nexus 9 (api 28) emulator tablet (Since I don't have the specific tablet you mentioned). The video played properly in portrait and landscape mode.
https://user-images.githubusercontent.com/67046386/107474829-1451b700-6b99-11eb-84e7-2e73dedc52f3.mov

 code sample
[✓] Flutter (Channel stable, 1.22.6, on Mac OS X 10.15.4 19E2269 darwin-x64, locale
    en-IN)
    • Flutter version 1.22.6 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • SM A260G (mobile) • 5200763ebcfa861f • android-arm • Android 8.1.0 (API 27)

! Doctor found issues in 1 category.

I am keeping this issue open for further investigation.

May be related / similar to https://github.com/flutter/flutter/issues/4899

@darshankawar
This is almost certainly not related to that.
I'm mentioned in the description, though not explicitly I suppose... that this only occurs when using DRM-enabled contents. If you play content other than DRM enabled content (in other words, the underlying SurfaceView is using the secure features of the Surface subsystem), this problem does not occur.
It also only happens with a Hybrid PlatformView, something that didn't even exist when that issue was created.

Thanks for filing. Just to verify the conditions under which this repros are:

Must be playing DRM enabled contents in a PlatformView
This repros on the Docomo dtab Compact d-02K, but not necessarily others.

Looks like it's out of production (生産終了). There are piles of them available on Yahoo Auctions in Japan, though it'll likely be a little tricky to find a seller willing to ship to the team in the US.
@jason-simmons @chinmaygarde we've worked with internal devices in the past whose physical screen orientation doesn't match the default app orientation for which the root surface transform was added in the embedder API. This seems a bit different, but I wonder if for DRM-enabled content where the system is doing direct video without going through the app layers, if we're missing something in our platform view implementation?

Specs: https://www.nttdocomo.co.jp/support/product/d02k/spec.html
Whis appears to be: https://www.mobosdata.com/phone/huawei-dtab-compact-d-02k

/cc @blasten @cyanglaz on the PlatformView side.

@Moncader I recently fixed an issue that was also described as "blank screen" and involved a "keyed" platform view like the one in your example.
Would you mind trying again on Flutter master?
If it's still an issue, is there any relevant logs? Are you able to reproduce it on an emulator running Android 8.0.0?

@blasten
Tried on master and the result is the same.
Here's the logs for master

[   +1 ms] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] Running with unsound null safety
[        ] For more information see https://dart.dev/null-safety/unsound-null-safety
[        ] An Observatory debugger and profiler on d 02K is available at: http://<IP_ADDRESS>:62405/OKxn5lihmg8=/
[ +641 ms] The Flutter DevTools debugger and profiler on d 02K is available at: http://<IP_ADDRESS>:9103?uri=http%3A%2F%2F<IP_ADDRESS>%3A62405%2FOKxn5lihmg8%3D%2F
[+1453 ms] I/flutter (15945): true
[  +99 ms] W/Settings(15945): mValues not put! needsGenerationTracker: true currentGeneration: -1 name: accessibility_captioning_enabled value: null
[  +50 ms] I/HwCust  (15945): Constructor found for class android.net.HwCustConnectivityManagerImpl
[        ] D/HwCust  (15945): Create obj success use class android.net.HwCustConnectivityManagerImpl
[  +32 ms] I/ExoPlayerImpl(15945): Init b92871d [ExoPlayerLib/2.12.3] [d-02K, d-02K, HUAWEI, 26]
[  +42 ms] D/HwGalleryCacheManagerImpl(15945): mIsEffect:false
[  +92 ms] I/zygote64(15945): Do partial code cache collection, code=30KB, data=28KB
[        ] I/zygote64(15945): After code cache collection, code=30KB, data=28KB
[        ] I/zygote64(15945): Increasing code cache capacity to 128KB
[ +147 ms] W/libEGL  (15945): EGLNativeWindowType 0x73d136c010 disconnect failed
[        ] D/mali_winsys(15945): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[  +39 ms] D/mali_winsys(15945): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[ +413 ms] I/zygote64(15945): Do partial code cache collection, code=61KB, data=55KB
[        ] I/zygote64(15945): After code cache collection, code=61KB, data=55KB
[        ] I/zygote64(15945): Increasing code cache capacity to 256KB
[   +9 ms] W/VideoCapabilities(15945): Unrecognized profile/level 1/32 for video/mp4v-es
[        ] I/VideoCapabilities(15945): Unsupported profile 16384 for video/mp4v-es
[   +9 ms] I/VideoCapabilities(15945): Unsupported profile 16384 for video/mp4v-es
[        ] W/VideoCapabilities(15945): Unsupported mime video/x-pn-realvideo
[   +2 ms] W/VideoCapabilities(15945): Unsupported mime video/mpeg
[   +2 ms] W/VideoCapabilities(15945): Unrecognized profile/level 0/0 for video/mpeg2
[        ] W/VideoCapabilities(15945): Unrecognized profile/level 0/2 for video/mpeg2
[        ] W/VideoCapabilities(15945): Unrecognized profile/level 0/3 for video/mpeg2
[   +2 ms] W/VideoCapabilities(15945): Unrecognized profile/level 32768/2 for video/mp4v-es
[   +7 ms] W/VideoCapabilities(15945): Unsupported mime video/vc1
[   +6 ms] W/VideoCapabilities(15945): Unsupported mime video/x-flv
[  +38 ms] I/VideoCapabilities(15945): Unsupported profile 4 for video/mp4v-es
[+1143 ms] I/OMXClient(15945): Treble IOmx obtained
[   +6 ms] I/ACodec  (15945): In onAllocateComponent create compenent, codec name: OMX.IMG.MSVDX.Decoder.AVC.secure
[   +3 ms] D/SurfaceUtils(15945): connecting to surface 0x73ca065010, reason connectToSurface
[        ] I/MediaCodec(15945): [OMX.IMG.MSVDX.Decoder.AVC.secure] setting surface generation to 16327681
[        ] D/SurfaceUtils(15945): disconnecting from surface 0x73ca065010, reason connectToSurface(reconnect)
[        ] D/SurfaceUtils(15945): connecting to surface 0x73ca065010, reason connectToSurface(reconnect)
[   +6 ms] W/HwExtendedUtils(15945): hw configLocalPlayBack err = -1010
[        ] E/ACodec  (15945): [OMX.IMG.MSVDX.Decoder.AVC.secure] setPortMode on output to DynamicANWBuffer failed w/ err -1010
[   +1 ms] I/HwExtendedCodec(15945): mime is [video/avc] at setVideoFormat
[   +8 ms] I/ACodec  (15945): codec does not support config priority (err -1010)
[        ] I/ACodec  (15945): onStart
[  +39 ms] D/ACodecBufferChannel(15945): setHeap returned mHeapSeqNum=0
[        ] I/HwExtendedUtils(15945): error setConfig queuesToNativeWindow (err -1010)
[   +3 ms] D/SurfaceUtils(15945): disconnecting from surface 0x73ca065010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): connecting to surface 0x73ca065010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): set up nativeWindow 0x73ca065010 for 864x384, color 0x300, rotation 0, usage 0x24006900
[ +205 ms] I/OMXClient(15945): Treble IOmx obtained
[  +75 ms] I/ACodec  (15945): In onAllocateComponent create compenent, codec name: OMX.google.aac.decoder
[   +1 ms] W/HwExtendedUtils(15945): hw configLocalPlayBack err = -2147483648
[        ] I/ACodec  (15945): codec does not support config priority (err -2147483648)
[        ] I/ACodec  (15945): onStart
[   +9 ms] D/ACodecBufferChannel(15945): setHeap returned mHeapSeqNum=0
[ +524 ms] I/HwExtendedUtils(15945): error setConfig queuesToNativeWindow (err -1010)
[        ] D/SurfaceUtils(15945): disconnecting from surface 0x73ca065010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): connecting to surface 0x73ca065010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): set up nativeWindow 0x73ca065010 for 864x384, color 0x300, rotation 0, usage 0x24006900
[ +126 ms] I/zygote64(15945): Do full code cache collection, code=123KB, data=98KB
[   +1 ms] I/zygote64(15945): After code cache collection, code=97KB, data=57KB
[ +253 ms] D/AudioTrack(15945): OFFLOAD 0,mNotificationFrames 0,mStreamType =-1,mOriginalSampleRate 44100,mAfSampleRate 48000,mTransfer 3
[        ] D/AudioTrack(15945): Client defaulted notificationFrames to 3675 for frameCount 11025
[  +11 ms] D/android.media.AudioTrack(15945): [HSM] AudioTrace play() uid: 10185, pid: 15945
[  +10 ms] I/AudioTrack(15945): audioTrack send start state to pg
[+2117 ms] I/zygote64(15945): Do partial code cache collection, code=120KB, data=86KB
[   +1 ms] I/zygote64(15945): After code cache collection, code=120KB, data=86KB
[        ] I/zygote64(15945): Increasing code cache capacity to 512KB
[+7590 ms] W/libEGL  (15945): EGLNativeWindowType 0x73d136b010 disconnect failed
[   +6 ms] D/mali_winsys(15945): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[  +35 ms] D/mali_winsys(15945): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[ +303 ms] E/BufferQueueProducer(15945): [ImageReader-1200x1836f1m3-15945-1] disconnect: not connected (req=1)
[        ] W/libEGL  (15945): EGLNativeWindowType 0x73ca549010 disconnect failed
[  +12 ms] D/mali_winsys(15945): EGLint new_window_surface(egl_winsys_display *, void *, EGLSurface, EGLConfig, egl_winsys_surface **, egl_color_buffer_format *, EGLBoolean) returns 0x3000
[+8349 ms] D/SurfaceUtils(15945): connecting to surface 0x73ca515010, reason connectToSurface
[        ] I/MediaCodec(15945): [OMX.IMG.MSVDX.Decoder.AVC.secure] setting surface generation to 16327682
[        ] D/SurfaceUtils(15945): disconnecting from surface 0x73ca515010, reason connectToSurface(reconnect)
[        ] D/SurfaceUtils(15945): connecting to surface 0x73ca515010, reason connectToSurface(reconnect)
[   +1 ms] D/SurfaceUtils(15945): disconnecting from surface 0x73ca515010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): connecting to surface 0x73ca515010, reason setNativeWindowSizeFormatAndUsage
[        ] D/SurfaceUtils(15945): set up nativeWindow 0x73ca515010 for 864x384, color 0x300, rotation 0, usage 0x24006900
[   +2 ms] D/SurfaceUtils(15945): disconnecting from surface 0x73ca065010, reason pushBlankBuffersToNativeWindow
[   +2 ms] D/SurfaceUtils(15945): set up nativeWindow 0x73ca065010 for 1x1, color 0x2, rotation 0, usage 0x930
[  +33 ms] D/SurfaceUtils(15945): connecting to surface 0x73ca065010, reason pushBlankBuffersToNativeWindow(err2)
[        ] D/SurfaceUtils(15945): disconnecting from surface 0x73ca065010, reason disconnectFromSurface
[  +46 ms] W/libEGL  (15945): EGLNativeWindowType 0x73d136b010 disconnect failed
[  +23 ms] W/IInputConnectionWrapper(15945): beginBatchEdit on inactive InputConnection
[   +3 ms] W/IInputConnectionWrapper(15945): endBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(15945): beginBatchEdit on inactive InputConnection
[        ] W/IInputConnectionWrapper(15945): endBatchEdit on inactive InputConnection
[   +2 ms] W/IInputConnectionWrapper(15945): beginBatchEdit on inactive InputConnection
[   +3 ms] W/IInputConnectionWrapper(15945): endBatchEdit on inactive InputConnection
[+1331 ms] W/InputMethodManager(15945): startInputReason = 3
[  +18 ms] W/InputMethodManager(15945): reStartinput failed, need refresh!
[   +2 ms] E/BufferQueueProducer(15945): [ImageReader-1920x1117f1m3-15945-2] disconnect: not connected (req=1)
[        ] W/libEGL  (15945): EGLNativeWindowType 0x73ca47d010 disconnect failed
[        ] E/BpSurfaceComposerClient(15945): Failed to transact (-1)
[        ] E/BpSurfaceComposerClient(15945): Failed to transact (-1)

For me the issue has been a little different. On some of my content, video starts black and only displays after rotating the device.
Device is Xiaomi Mi A3 on Android 11.


Message filter for Box.Name ("_Box.Name") is not supported

The following filter query for box messages is not supported currently.
https:/// __ctl/ReceivedMessage?$filter=_Box.Name eq 'io_personium_demo_app-myboard'
For some apps, it is necessary to display certain messages from a specified box.

This issue is a duplicate of #55.