add game's landing page

Fixes Issue
This PR fixes the following issues :
#example

added landing page for the game, connect the game to the file game-single.html by creating a button maybe index.html will be the home page for demo and about game
Here comes all the changes proposed through this PR

Check List (Check all the boxes which are applicable)

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain copyrighted content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots
Add all the screenshots which support your changes

Will that be detected by Github pages?

Will that be detected by Github pages?


Some minor changes to ease implementation on top of kontiki

This PR contains a bunch of changes I had to make to kontiki in order to implement raptr:

reset timeouts even when they are ignored by current state
store last known leader within follower's state

I also moved tests to more standard test/ directory and reorganized them to use tasty.
I can split this PR in smaller chunks if required.

I'm sorry I completely missed this PR (and it's been  a year... :-/)
I'll go over it right away.

Thanks for the comments, I will address them.


Release shouldn't fail if we can't delete the container

There's a known issue on CircleCI where docker rm doesn't work. The user they set you up with doesn't have permissions for it. It's sort of by design, as the entire VM gets destroyed at the end anyway.  CircleCI docker based build logs are filled with:
Error removing intermediate container 86fdf1139207: Cannot destroy container 86fdf113920797059e66b58c7e195b77e981185cafd9488d2e4d1c2865db75a4: Driver btrfs failed to remove root filesystem 86fdf113920797059e66b58c7e195b77e981185cafd9488d2e4d1c2865db75a4: Failed to destroy btrfs snapshot: operation not permitted

When heroku docker:release tries to delete a container in this scenario, the entire deploy is aborted. It'd be better if we continued with the process here. Failing to remove the image shouldn't be a cause to abandon the deploy (though it will still be logged).

@hunterloftis @friism This solved my issues on Circle -- can we bring this in?

Still  have this issue here while performing a release on my gitlab-ci server, it failed with report:
extracting slug from container...
remove /tmp/slug.tgz: operation not permitted
 !   Error in heroku-docker:
 !   Command failed: docker cp 688949119e686e7831b4a746078257396851bc0ecac4576bf1130d1bca2f3511:/tmp/slug.tgz /tmp
remove /tmp/slug.tgz: operation not permitted

 !   See /home/gitlab-runner/.heroku/error.log for more info.

and from .heroku/error.log
2015/11/21 05:38:30 Error during docker:release
2015/11/21 05:38:30 Error: Command failed: docker cp 688949119e686e7831b4a746078257396851bc0ecac4576bf1130d1bca2f3511:/tmp/slug.tgz /tmp
remove /tmp/slug.tgz: operation not permitted

    at checkExecSyncError (child_process.js:441:13)
    at Object.execSync (child_process.js:481:13)
    at tar (/home/gitlab-runner/.heroku/node_modules/heroku-docker/commands/release.js:127:15)
    at ChildProcess.onBuildExit (/home/gitlab-runner/.heroku/node_modules/heroku-docker/commands/release.js:118:9)

[more details]:

I'm running the gitlab-ci build as user gitlab-runner
group gitlab-runner  => gitlab-runner : gitlab-runner root docker

Any idea how to fixed this?

Can this be merged?

Thanks Damian -- I've emailed you privately to discuss


Show messages from customGas.js in Send Offline page

hi @crptm. Why do you think that?It shows some custom message depending on entered address. You can check this address filling it in To field at Send Offline page for example:0xc9f32ce1127e44c51cbd182d6364f3d707fd0d47Sent from Nylas Mail, the best free email app for work
        On Jun 23 2017, at 4:46 pm, crptm<EMAIL_ADDRESS>wrote:

          @crptm commented on this pull request.

In app/scripts/controllers/offlineTxCtrl.js:

     if (ethFuncs.validateEtherAddress(address)) {

         $scope.notifier.info(globalFuncs.successMsgs[0]);

       for (var i in CustomGasMessages) {

           if ($scope.tx.to.toLowerCase() == CustomGasMessages[i].to.toLowerCase()) {

               $scope.customGasMsg = CustomGasMessages[i].msg != '' ? CustomGasMessages[i].msg : ''

This does nothing
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

@domalak ETH Address, please :)

@domalak ETH Address, please :)

@domalak if value is not an empty string, use it; if value is empty string use empty string. This should always result in same value, right?

Storiqa tokens coin missing later fewday please send me massage


[Editor] Make editors movable in using the keyboard (bug 1845088)

Selected editors can be moved in using the arrows:

up/down/left/right will move the editors of 1 in page unit;
ctrl (or meta)+up/down/left/right will move them of 10 in page unit.

/botio integrationtest

It seems that the must serialize invisible annotations test now fails consistently.

/botio integrationtest


403 forbidden for jupyter-server-proxy cross-origin

Posting an issue to record this for future googlers
This took me a long time to fix: we use jupyter-server-proxy to run Pluto (custom IDE) on binder, which works fine. But for this project all requests need to be done cross-origin (very similar thebe).
By setting the header acess-allow-cross-origin to * on our server, all HTTP requests work (jupyter-server-proxy and binder ingress don't change this header), but a websocket connection still failed, with a 403 response.

The cause was: jupyter-server-proxy uses the tornado package for their websocket forwarding, but tornado 4 got a 'feature' where it only allows websocket connections if the origin and host are the same. (WebSocket connections normally bypass CORS policy, which is a common security issue, which the tornado authors solved.)
This means that the websocket connection (HTTP Upgrade request) never reached our server, and tornado wrote the 403 forbidden response.

Solution
This SO answer is our solution:
https://stackoverflow.com/questions/24800436/under-tornado-v4-websocket-connections-get-refused-with-403
But how do we apply it?
Long version
We need to fork jupyter-server-proxy, and make the code change. The code change is here:
https://github.com/fonsp/jupyter-server-proxy/commit/06cd1d843b7ada31d719272ae76d3c9bb777797a
The next tricky bit is installing this fork of jupyter-server-proxy instead of the pip-registered version in our binder.
My suggestion is: tag your branch with a new, strange version number. In my case, 1.5.1002 instead of 1.5.2. I do that here: https://github.com/fonsp/jupyter-server-proxy/commit/3a58aa5005f942d0c208eab9a480f6ab171142ef
Next, use this exact version as your dependency in binder, that way the build fails if it's not using your fork.
Short version
The fork is here:
https://github.com/fonsp/jupyter-server-proxy
Commit SHA:
3a58aa5005f942d0c208eab9a480f6ab171142ef
You need to update requirements.txt or environment.yml: delete the pip version, add your fork. And ALSO update your setup.py. Final result here, search for every occurance of jupyter-server-proxy
https://github.com/fonsp/pluto-on-binder/tree/c8eb7a8ed1626b18ef2fec8002c1413ef9f75fa0


Need a catch in thali/test/www/jxcore/UnitTest_app.js for the call ThaliMobile.getNetworkStatus()

The key here is that we need to make sure the tests fail when we get that catch. I think all we have to do is emit "console.log('TEST_LOGGER:[PROCESS_ON_EXIT_FAILED]');" and exit.

Closing as #982 contains the fix for this.


Error in downloading preprocessed data

''The datasets that have been preprocessed by BenchTemp are Here.''
I fail to download the preprocessed dataset via this link. Are there any updates in dataset downloading?

Oh, the datasets is hosted on zenodo here now.
You can download it via VPN.

Thanks! The update helps a lot.


Change the contact number under Forgot PIN

Describe the bug
On the login page, the forgot PIN option shows the following generic number to call if a user forgot their PIN: 012-3456-789
To Reproduce
Steps to reproduce the behavior:

Click forgot password

Expected behavior
Be able to replace the phone number
Screenshots

Smartphone (please complete the following information):

All devices

Additional context
I think the simplest fix is to create a translation "for the number."

Hi! I would like to work on this issue.

Sounds good! For implementation you can replace hard-coded phone number with a translated string, you can follow the pattern for the other string on this line.

can you please share the above uploaded screenshots again as I am not able to view those?

re-uploaded, you should be able to see them now!

Hey sorry you can assign this issue to someone else because I  have never worked in android development

This might require some scoping and discussion to determine which method would be most suitable to achieve maximum reconfigurability  @pld

Hey sorry you can assign this issue to someone else because I have never worked in android development

no worries, done!

@sharon2719 Any update on the failing test here ? Aug 5th Sprint Review
CC @ndegwamartin

Reworking them based on @ellykits  comment

@sharon2719 and @ellykits any updates on this PR


App crashes on "View Details" of Send successful modal.

https://github.com/bithyve/bitcoin-keeper/assets/62699947/3e822138-a23e-4659-9039-7dfe9a5a12a4

When we send from Transfer fund to vault UAI app is crashing on "View Details" of Send successful modal.

Verified this issue on keeper app v 1.1.12(303)


[Apple Reminders Beta] ...

Extension
https://www.raycast.com/raycast/reminders
Description
The reminders don't update in menubar.
Steps To Reproduce
Quick Add a random reminder. Wait for it to show up in My Reminders and then check if its in the menubar
Current Behaviour
No response
Expected Behaviour
No response

The menu bar updates every 10 minutes so it may be expected.

Closing it in order to keep the backlog clean. Feel free to reopen the issue.


⚠ Bofrost.de has degraded performance

In d61ce8f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1170 ms

Resolved: Bofrost.de performance has improved in 255e9b5.


feat: handle 'session not found' errors

fixes https://github.com/colopl/laravel-spanner/issues/37
There are a few cases when a 'Session not found' error can
happen:

Scripts that idle too long - for example, a Laravel queue worker
or anything that doesn't call Spanner frequently enough (more than once an hour).
The session is more than 28 days old.
Some random flukes on Google's side.

Hi thanks for the pull request! I have some review feedback. Please check it out.

Thank you for your contribution!

I will release the next version once I fix the Phpstan errors.

Hi @taka-oyama
Thank you.
could you also please create branch v3 from https://github.com/colopl/laravel-spanner/tree/v3.9.3
so it will be possible to backport to older laravel ?

Hi, thanks for the patience.
Yes, I will backport it.
I couldn't find time this week so I will do it on monday.

HI @taka-oyama
I thought to make a backport by self - the my whole endeavor was to get universal solution for Laravel 8.
But any solution will do.

Hi. I released v4.1.0 and 3.10.0 (for laravel 8 or below), please check it out.

Asking google to fix this upstream, so we don't have to do this hack.


Enable monthly dependency updates for UI.

Fixes https://github.com/kubernetes-sigs/testgrid/issues/9

/lgtm
/skip-review

From running the test locally, it seems like sometimes npm test or npm run test will work, but I can reproduce the error reliably with rm -rf node_modules/; npm install && npm test. pnpm test doesn't seem to have the same issue, updating the job in test-infra to try that out.

Ah. Okay, one more fix.

Ah. Okay, one more fix.

we probably want to include pnpm in the dependencies list.

Ah. Okay, one more fix.

we probably want to include pnpm in the dependencies list.

Probably, but we need it globally installed to run on the command line I believe.
Added https://github.com/kubernetes/test-infra/pull/33853

/retest

/lgtm
/pony celebration


[Doc] Step 3 of google as IDP document is not clear with provided screenshots

Doc: https://docs.wso2.com/display/IS540/Configuring+Google
Step 3 of the document does not directly relate to the screenshots provided. It should be restructured with the following points provided below.

Update the screenshot with sample values
Move the google app screenshot under step 2 and make a note to copy google app client and secret
Advice user to provide google app client and secret under section 3

Fixed. Also fixed in older versions as this is not version specific.
https://docs.wso2.com/display/IS570/Configuring+Google


Feature/Fix premature check if contributor is admin [OSF-6848]

Purpose
Fixes node model update_contributor bug.  If you are the only admin, a PATCH request only changing your bibliographic info would fail with a 400 - saying you were the only admin.  Cause was a premature check to see whether or not only admin was removing herself as an admin.
Changes
Moves check of "if admin == user and ADMIN not in permissions" to inside the conditional that checks if permissions have been changed.
Side effects
Does this break anything? This is a node model change.  Probably was only visible from the APIv2, though. QA: Check for any weirdness with contributor modification, especially around admin permissions.
Ticket
https://openscience.atlassian.net/browse/OSF-6848

Looks good. 🎉 🐧 🎉

Thanks for the quick review!


Next flutter stable release

Hi, I would like to ask about around when is planned next stable release of flutter and what version it would be based on?

Hi @RakiFuyumine.
You can see https://github.com/flutter/flutter/wiki/Flutter-build-release-channels for details on Flutter releases.
I hope this helps!
Also, you can see https://flutter.dev/community for resources and ask more questions like this
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Request to add custom providers like Azure, GCP, etc

Also mentioned in #150 #171
I see forks (e.g. https://github.com/deshpandetanmay/git-secrets and https://github.com/msalemcode/git-secrets) adding GCP and Azure patterns, here I just want to confirm whether you are open to custom providers, and we can definitely provide patterns and contribute.

Can this merge?

I agree that including sane defaults for these other platforms would be valuable, especially when they are already implemented in active forks.


[WIP] fix most errors with new django-rest-framework and bug with exclude

I will remove [WIP] flag when I finish this.
For now test will be probably failing.

For now we have to fix those problems:

[ ] TypeError: ListCreateAPIView() received an invalid keyword u'paginate_by'. as_view only accepts arguments that are already attributes of the class.
[ ] AssertionError: Original widget's attribute was not copied: u'DATE_FORMAT' != '%Y-%m-%d'
[ ]  '%Y-%m-%d' != u'DATE_FORMAT'

@galuszkak will we drop the support for django 1.6 and 1.7?

@galuszkak the date format problem is because it is hardcoded by floppyforms: https://github.com/andrewsmedina/django-floppyforms/blob/master/floppyforms/widgets.py#L287
I believe that a way to fix it is change tests.

closing in favor of #431


infrastructure work

Codecov Report

Merging #34 (3663294) into main (415e14f) will increase coverage by 4.66%.
The diff coverage is 97.36%.

Additional details and impacted files


[FEATURE REQ] Feature to have EDM types exposed to clients in Azure.Data.Tables

Library name
Azure.Data.Tables
Please describe the feature.
We are using Microsoft.Azure.Cosmos.Table and as part of the library we get access to EDM types of entities using DynamicTableEntity and we are using the same to have a generic solution that could connect to any storage account and do operations on the tables/entities. Since it's a generic solution, it becomes very important for us to have access to EDM types so that we keep that information intact in entities while doing data manipulations.
Now since Microsoft.Azure.Cosmos.Table is marked for deprecation and we are supposed to upgrade to Azure.Data.Tables. Azure.Data.Tables don't have any replacement for DynamicTableEntity, hence we lose out on that information. Without the library exposing EDM types, we feel we have a risk.
What is needed: A replacement of DynamicTableEntity in Azure.Data.Tables that expose EDM types that clients can use if needed.
The issue is discussed already in https://github.com/Azure/azure-sdk-for-net/issues/31826

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thanks @Sandeep7OnShell - In order to consider this feature, please provide some general scenarios where this EDM data is needed in addition to the type information on the TableEntity Value collection, which already provides type information.
(note: This should include scenarios that would be valuable other than when data is incorrectly persisted to another data store where the type information has been removed, as in the referenced issue.)

@christothes In addition to the type information on the TableEntity Value collection, which already provides type information.
With the new package, I don't see whare is provides the type of information. Can you please guide which property in TableEntity does that?. If we have that information there, could be sufficient for handle the EDM scenario.


Hue iOS app seems to require scenes functionality

When I open the iOS app (the one with the color icon), it finds the emulated bridge, but it immediately asks me to create a "room". Then it stalls forever "saving" the "room", doing requests like
=== 121256
Method: POST
requestedUri: api/api/scenes
URI: scenes
121257
[{"error":{"type":4,"address":"/api/api/","description":"Method not supported for scenes"}}]
121261
=== 121287
Method: POST
requestedUri: api/api/scenes
URI: scenes
121288
[{"error":{"type":4,"address":"/api/api/","description":"Method not supported for scenes"}}]
121292
=== 121317
Method: DELETE
requestedUri: api/api/groups/1
URI: groups/1
121317
=== 123624

Apparently the app insists on each lamp being in a scene now. It used to work entirely without scenes before.
This effectively prevents me from using the iOS app.
The other iOS app (the one with the b/w icon) does not seem to be able to find the emulated bridge at all.

1ad3705 fixes this for me.


stdenv: log build hooks as they run

Description of changes
Hooks are vital to Nixpkgs, and are often the "magic" to make things Just Work, but they're also extremely opaque. Adding something like undmg to a derivation's nativeBuildInputs adds a hook to the unpackPhase to automatically extract DMG sources — this is fantastic, but a beginner would have no way of knowing that adding something as a build input could have such a major effect (undmg gets only a single passing mention in the Nixpkgs manual), and even to Nixpkgs veterans it's far from obvious what the final array of hooks for a build might be, or what order they even run in (a source of confusion if one causes an error!).
This PR changes stdenv's setup.sh to log hooks to stdout as they run, as it does currently with phases. Setup hook files are logged just before they're sourced, and individual build hooks like patchShebangsAuto are also logged just before they're run.
With this PR, now anyone building with --print-build-logs will have transparency into one of the most important aspects of Nixpkgs, to aid heavily in both debugging and learning.

For example, here what it now looks like when building Curlie:

sourcing setup hook '/nix/store/33jvc2jsv20lsx8dp0pwf0rr7xhwwpq9-patchelf-0.15.0/nix-support/setuphook'
sourcing setup hook '/nix/store/qmavq4i2rh012ggwb5fxlvp3pzhxmbkl-update-autotools-gnu-config-scripts-hook/nix-support/setuphook'
sourcing setup hook '/nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh'
sourcing setup hook '/nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh'
sourcing setup hook '/nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh'
sourcing setup hook '/nix/store/5yzw0vhkyszf2d179m0qfkgxmp5wjjx4-move-docs.sh'
sourcing setup hook '/nix/store/fyaryjvghbkpfnsyw97hb3lyb37s1pd6-move-lib64.sh'
sourcing setup hook '/nix/store/kd4xwxjpjxi71jkm6ka0np72if9rm3y0-move-sbin.sh'
sourcing setup hook '/nix/store/pag6l61paj1dc9sv15l7bm5c17xn5kyk-move-systemd-user-units.sh'
sourcing setup hook '/nix/store/jivxp510zxakaaic7qkrb7v1dd2rdbw9-multiple-outputs.sh'
sourcing setup hook '/nix/store/wzdsbnv2ba3nj91aql8jjdddfmkkdh7h-patch-shebangs.sh'
sourcing setup hook '/nix/store/cickvswrvann041nqxb0rxilc46svw1n-prune-libtool-files.sh'
sourcing setup hook '/nix/store/xyff06pkhki3qy1ls77w10s0v79c9il0-reproducible-builds.sh'
sourcing setup hook '/nix/store/ngg1cv31c8c7bcm2n8ww4g06nq7s4zhm-set-source-date-epoch-to-latest.sh'
sourcing setup hook '/nix/store/wmknncrif06fqxa16hpdldhixk95nds0-strip.sh'
sourcing setup hook '/nix/store/w0x01w0vcdzvaj90axjxq6w2p290cp5m-gcc-wrapper-13.2.0/nix-support/setuphook'
sourcing setup hook '/nix/store/1byi00pspg4j6jpvaj4xn2mfkyh28g9g-binutils-wrapper-2.40/nix-support/setuphook'
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/1mmyk26f86cg3cvs9djg0l4cf95hwl7q-source
calling 'unpackCmd' function hook '_defaultUnpack' /nix/store/1mmyk26f86cg3cvs9djg0l4cf95hwl7q-source
source root is source
calling 'postUnpack' function hook '_updateSourceDateEpochFromSourceRoot'
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/2q6i5q3jin7d357dm53hdkancj5wzpaq-bump-golang-x-sys.patch
patching file go.mod
patching file go.sum
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
calling 'preConfigure' function hook '_multioutConfig'
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
Building subPackage .
Building subPackage ./args
Building subPackage ./formatter
@nix { "action": "setPhase", "phase": "checkPhase" }
Running phase: checkPhase
ok  	github.com/rs/curlie/args	0.001s
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: installPhase
@nix { "action": "setPhase", "phase": "fixupPhase" }
Running phase: fixupPhase
calling 'preFixup' function hook '_moveToShare'
calling 'preFixup' function hook '_multioutDocs'
calling 'preFixup' function hook '_multioutDevs'
evaling 'fixupOutput' string hook 'if [ -z "${dontPatchELF-}" ]; then patchELF "$prefix"; fi'
shrinking RPATHs of ELF executables and libraries in /nix/store/crnvz72hxrp3cc0wrfcdaivyymqiy55q-curlie-1.7.2
shrinking /nix/store/crnvz72hxrp3cc0wrfcdaivyymqiy55q-curlie-1.7.2/bin/curlie
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
evaling 'fixupOutput' string hook 'if [[ -z "${noAuditTmpdir-}" && -e "$prefix" ]]; then auditTmpdir "$prefix"; fi'
checking for references to /build/ in /nix/store/crnvz72hxrp3cc0wrfcdaivyymqiy55q-curlie-1.7.2...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
evaling 'fixupOutput' string hook 'if [ -z "${dontGzipMan-}" ]; then compressManPages "$prefix"; fi'
calling 'fixupOutput' function hook '_moveLib64'
calling 'fixupOutput' function hook '_moveSbin'
calling 'fixupOutput' function hook '_moveSystemdUserUnits'
calling 'fixupOutput' function hook 'patchShebangsAuto'
patching script interpreter paths in /nix/store/crnvz72hxrp3cc0wrfcdaivyymqiy55q-curlie-1.7.2
calling 'fixupOutput' function hook '_pruneLibtoolFiles'
calling 'fixupOutput' function hook '_doStrip'
stripping (with command strip and flags -S -p) in  /nix/store/crnvz72hxrp3cc0wrfcdaivyymqiy55q-curlie-1.7.2/bin
calling 'postFixup' function hook '_makeSymlinksRelativeInAllOutputs'
calling 'postFixup' function hook '_multioutPropagateDev'

There are more example output diffs at https://github.com/Qyriad/nixpkgs/compare/before/diag/log-hooks...Qyriad:nixpkgs:after/diag/log-hooks?diff=split&w=.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

This is a mass rebuild and I don't particularly want to turn my computer into a space heater, but I did test all the packages listed in the above diff

[ ] (N/A) Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

Other major stdenv PRs don't seem to have done this, so I haven't, but can if desired
[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is an excellent idea, I like it a lot.

Thanks @fogti! Those are now fixed

OK, I made a version of this PR (https://github.com/philiptaron/nixpkgs/commit/e7e76751fa09945a2ee4a38a6c2c94becfe692e0) that I could grep through the produced build logs and see what it looked like.
After building my entire machine derivation:
$ fd bz2$ /nix/var/log/nix/drvs/ | xargs bzcat | rg https://github.com/NixOS/nixpkgs/pull/290081 | sort | uniq -c
     27 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'fixupOutput' string hook 'fixQmakeLibtool $prefix'
   5516 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'fixupOutput' string hook 'if [ -z "${dontGzipMan-}" ]; then compressManPages "$prefix"; fi'
   5282 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'fixupOutput' string hook 'if [ -z "${dontPatchELF-}" ]; then patchELF "$prefix"; fi'
   5516 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'fixupOutput' string hook 'if [[ -z "${noAuditTmpdir-}" && -e "$prefix" ]]; then auditTmpdir "$prefix"; fi'
     17 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'postFixup' string hook 'if [ -z "${dontAutoPatchelf-}" ]; then\n autoPatchelf -- $(for output in $(getAllOutputNames); do\n [ -e "${!output}" ] || continue\n echo "${!output}"\n done)\n fi'
      1 https://github.com/NixOS/nixpkgs/pull/290081: evaling 'postFixup' string hook 'mkdir -p $out/include'

To me, this suggests that each of these hooks ought to be made to fit under the previous function or sourcing hook logic (probably function)
... and that the cute, complicated loop actually works. Nice, @Qyriad.

Is this ready to be squashed?

i am seeing debug output when invoking nix-shell and i don't think i should see anything.
eg:
$ nix-shell -I nixpkgs=. -p bash
sourcing setup hook '/nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh'
sourcing setup hook '/nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh'
sourcing setup hook '/nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh'
sourcing setup hook '/nix/store/5yzw0vhkyszf2d179m0qfkgxmp5wjjx4-move-docs.sh'
sourcing setup hook '/nix/store/fyaryjvghbkpfnsyw97hb3lyb37s1pd6-move-lib64.sh'
sourcing setup hook '/nix/store/kd4xwxjpjxi71jkm6ka0np72if9rm3y0-move-sbin.sh'
sourcing setup hook '/nix/store/pag6l61paj1dc9sv15l7bm5c17xn5kyk-move-systemd-user-units.sh'
sourcing setup hook '/nix/store/jivxp510zxakaaic7qkrb7v1dd2rdbw9-multiple-outputs.sh'
sourcing setup hook '/nix/store/ilaf1w22bxi6jsi45alhmvvdgy4ly3zs-patch-shebangs.sh'
sourcing setup hook '/nix/store/cickvswrvann041nqxb0rxilc46svw1n-prune-libtool-files.sh'
sourcing setup hook '/nix/store/xyff06pkhki3qy1ls77w10s0v79c9il0-reproducible-builds.sh'
sourcing setup hook '/nix/store/ngg1cv31c8c7bcm2n8ww4g06nq7s4zhm-set-source-date-epoch-to-latest.sh'
sourcing setup hook '/nix/store/wmknncrif06fqxa16hpdldhixk95nds0-strip.sh'
sourcing setup hook '/nix/store/8dylc060lmn314b8wmz9bzm8f1dxv1n6-clang-wrapper-16.0.6/nix-support/setuphook'
sourcing setup hook '/nix/store/z46kig749819lcaz5sdbklnmx0bndlwg-cctools-binutils-darwin-wrapper-16.0.6-973.0.1/nix-support/setuphook'
calling 'envHostHostHook' function hook 'ccWrapper_addCVars' /nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh
calling 'envHostHostHook' function hook 'bintoolsWrapper_addLDVars' /nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh
calling 'envHostHostHook' function hook 'ccWrapper_addCVars' /nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh
calling 'envHostHostHook' function hook 'bintoolsWrapper_addLDVars' /nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh
calling 'envHostHostHook' function hook 'ccWrapper_addCVars' /nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh
calling 'envHostHostHook' function hook 'bintoolsWrapper_addLDVars' /nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh
[...]


Make runTasks dynamic on the SubmitRun task to allow passing cluster configuration from inputs

Feature description

runTask is not dynamic as it's a complex type, but almost all of its child properties are.


minor tweaks

mostly, let you know what command is not available when doozer tries to run something that's not there
@adammhaile any concerns?

@sosiouxme I keep forgetting there's no auto-merge here. Merge when ready.


Update handling for parameterized methods via ConfigProxyFactory

Currently, even if a top level prefix is specified in an @Configuration annotation, parameterized methods in the body will ignore the prefix.
This change updates this behavior to properly acknowledge the prefix annotation.
This is notably breaking, so we keep backward compatibility for users who compensated by having their parameterized methods include the prefix. However, we will be breaking users that did not include the prefix.
Putting this up for review now, but still following up with a few clients to ensure the safety of this change.

Looks good, let's wait for those users' feedback.

I've received confirmation from the users that this change will not affect them (the properties were either unused, or in decommissioned applications)

👍 Let's merge, then. But also, since there's a visible behavior change, let's remember to bump the next release's minor version to 2.6


athena support

@antonpod @sthuck this PR should add support for athena notes to quix-backend.
there are several breaking changes :

/execute/v1/sql was split to /execute/v1/presto and /execute/v1/athena

/api/db/... was split to /api/presto/db/... and /api/athena/db/... (athena db tree is not yet implemented)

.env should have few new keys

MODULES=presto,athena

ATHENA_OUTPUT=
ATHENA_REGION=
ATHENA_DATABASE=

athena credentials are fetched via DefaultAWSCredentialsProviderChain (https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/credentials.html)

@sthuck please change the quixConfig in index.vm to:
window.quixConfig = {
  staticsBaseUrl: '',
  auth: {
    googleClientId: '<google client id>'
  },
  executor: {
    url: '<backend url>'
  },
  modules: [{name: 'presto'}, {name: 'athena'}] // fetch this config from backend
};

@frolovv

added api/db/config that will return today:
{
   "trees" : ["presto"]
}

and once we support athena db tree :
{
   "trees" : ["presto", "athena"]
}

@frolovv please change:

/api/presto/db/ to /api/db/presto
/api/athena/db/ to /api/db/athena

to support this proxy format https://github.com/wix/quix/blob/master/quix-frontend/service/src/modules/proxy-backend/proxy-backend.module.ts#L23


Dependencies?

@hubbs5 Could you provide a list of package dependencies?

Hey,
The dependencies can be found in the setup.py file.
However, here is the list of dependencies copied from that file.
'gym>=0.15.0',
'numpy>=1.16.1',
'scipy>=1.0',
'matplotlib>=3.1',
'networkx>=2.3'


CUDA fails to compile on linux-ppc64le

I still get this error when building libnd4j for CUDA on the machine that we have access to:
/usr/include/string.h: In function ‘void* __mempcpy_inline(void*, const void*, size_t)’:
/usr/include/string.h:652:42: error: ‘memcpy’ was not declared in this scope
   return (char *) memcpy (__dest, __src, __n) + __n;

Looks like CUDA 7.5 doesn't support the libraries used by GCC on that machine...

That's pretty suspicious, because IBM guys have compiled it. And string.h complaint isnt a CUDA include. Can you show full output log?

Yes, a different team have compiled it, but we don't know their config. Full log? It's not relevant, and it's like 70 megs, but let me send that through Google Drive.

Post it to google drive please, i'll read through it, maybe i'll see something viable there, maybe no.

Is this still true?

Yes, doesn't compile on 16.04, only 14.04...

I've also heard some complaints about 16.04 and cuda, for x86 arch. But they were pretty general, and didn't end up as issue


Add Russian translation

Hi @ncase,
I've made a translation of polygons into Russian. Live version can be found here: https://nogoegst.github.io/polygons-ru/
The repo can be found here: https://github.com/nogoegst/polygons-ru
Thanks!

Thank you so much! :D I've added a link to your Russian version on the main polygons page As seen here:


COB-aware autosens

This updates autosens to use the COB and UAM categorization logic from autotune to exclude meal-related deviations from autosens.  The autosens output has been updated to display in oldest to newest order (not backwards, like it previously did) and to display COB-related meal periods in parentheses following the COB amount, and UAM-related meal periods as u().
Example output:
+++-60g(>>>>>>>>>>>>>>>>>>>>>>>>>>>>>)u(>>>)--------30g(>>>>>>>>>>>>>>>>>>>>>)------15g(>>>>>>>>>>>>>>>)-----------++---+60g(>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>17>>>>>>>>>>)----+++-++-+----+-+-+-++++++--++-+---++-----++++++-+++++--+--+---+++++++++-+-++>-++-++-++-+--++-----+---+++--+--+--++>-++-----+++-- 54% of non-meal deviations <= 0 (target 45%-50%) Excess insulin sensitivity detected: ISF adjusted from 51.843 to 56
This will need some testing to determine whether the 45%-50% target is still good, or if that needs adjustment.  I also split out the cob-autosens.json into two files, cob.js and autosens.js, which both need cleaning up to remove code and conditionals that are no longer needed in both.

This also still preserves the 6 mg/dL/5m cutoff for detecting unannounced and unbolused carb rises: we'll want to evaluate whether that threshold should be raised now to reduce false-positives.

Is anyone interested in building any unit tests to cover autosens.js?  I'm pretty happy with the real-world testing I've done so far, and inclined to ignore the coverage % decrease unless someone volunteers to write some tests.

This has been running well for several days and is ready to merge if no objections.

Should the 6mg/dL threshold be configurable? My experience is the kid hormonal rises easily go over this.
Another thing to think about for later is could we somehow support marking down rescue carbs to increase the accuracy of the analysis, without affecting the dosing.

Possibly, or it may be safe to remove it. I am testing the latter in a new branch, and can make a new PR if it works well.
What Dana does for marking rescue carbs is use an IFTTT trigger what both enters carbs and sets a high temporary target to prevent any SMBing (either from the COB, or equally likely from UAM after the COB is expired).


AdBlock for permanently blocking extensions from installing

In a recent update, microsoft has bundled another potentially unwanted (and proprietary) extension into the python extension.
Specifically, they have introduced Pylance as a dependency.
As evidenced by the comments in the python extension page, many users consider Pylance to some form of "adware".
Please, consider adding anti-adware features into vscode, like adding the ability to permanently block certain extensions from being installed, or adding a port from uBlock-Origin, or AdGuard, or something like that.

Another, much well written, complaint about the situation, straight from the folks from r/Pythonr/Python


add native okta docs

Description & motivation
Adds docs for configuring Okta SSO natively in the application
Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please update the base branch to next
[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[x] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

I'm going to merge this as the native Okta integration is now live in dbt Cloud


Update Junhui PPP and Documentations

Pull Request Test Coverage Report for Build 1087

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.113%

Totals

Change from base Build 1080:
0.0%

Covered Lines:
2766

Relevant Lines:
3328

💛  - Coveralls


analysis.getHover returns ///  in the doc text with the new driver

When using the new analysis driver, it looks like analysis.getHover returns leading ///  in the dartdoc text.

Fixed? I re-built the sdk and don't see this anymore.


fix: Page title line wrap

Closes #375

@ftonato, thank you! Will you take a moment to sign-off on your commit? Here are instructions to do so - https://github.com/layer5io/meshery/pull/383/checks?check_run_id=270044528.
You may be familiar with DCO, here's a description in our contribution guide.

@ftonato we'd love to engage you more in the community and with this project. Please join here - http://slack.layer5.io.


Update broken metadata, and test that it is kept up to date

What
The just generate-metadata command updated the "broken" test metadata on main. This PR introduces a test that ensures this is kept up to date, such that updates to this metadata doesn't lag behind the changes that actually introduced them.

Looks like you need to start supplying separate metadata for older versions of PostgreSQL.

Looks like you need to start supplying separate metadata for older versions of PostgreSQL.

.. Or only run this test on the latest Postgres, which is what the adjacent is-the-config-idempotent tests do as well.

If this is because the text field, we can remove that column and do RETURNING "ArtistId" instead.


Update regridding notebook for v0.7.0

Description
For addressing: https://github.com/xCDAT/xcdat/issues/589#issuecomment-2057988462 but focus only on horizontal and vertical regridding notebooks
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Only a few minor changes that makes note books to run. Some changes noted:

notebook setup: I had to include python -m ipykernel install --user --name xcdat_notebook --display-name xc070 to have the xcdat_notebook kernel to show up in Jupyter. Though I don't see this step in other example notebook.
In https://github.com/xCDAT/xcdat/blob/9193509919fe5123f989e2211d2517c266cbe097/docs/examples/regridding-horizontal.ipynb:
Ln 8: created a new warning:/Users/zhang40/mambaforge/envs/xcdat_notebook/lib/python3.12/site-packages/xcdat/regridder/regrid2.py:195: RuntimeWarning: invalid value encountered in divide np.divide(, which I think is resulted by a recent change from @jasonb5, and the result figure seems to be deviated from the results on main (here) based my assessment with naked eyes. Not sure if this is expected.

I don't mind including notebook setup instructions, but I had included the following text in order to avoid repeating the instructions across all notebooks:

Users can install their own instance of xcdat and follow these examples using their own environment (e.g., with vscode, Jupyter, Spyder, iPython) or enable xcdat with existing JupyterHub instances. The conda environment used in this notebook includes xcdat, xesmf, matplotlib, ipython, ipykernel, cartopy, and jupyter:

Only a few minor changes that makes note books to run. Some changes noted:
1. notebook setup: I had to include `python -m ipykernel install --user --name xcdat_notebook --display-name xc070` to have the xcdat_notebook kernel to show up in Jupyter. Though I don't see this step in other example notebook.

I was able to use the Python kernel form the xcdat_notebook environment in Jupyter. This kernel is listed as "Python 3 (ipykernel)", not xcdat_notebook. I don't think it is necessary to call the python -m ipykernel command for this case.
The import xcdat line works fine in the screenshot below:

Commands used:
$ conda create -n xcdat_notebook -c conda-forge xcdat xesmf matplotlib ipython ipykernel cartopy nc-time-axis jupyter
$ conda activate xcdat_notebook
$ jupyter notebook

@tomvothecoder I did not know Python3 (ipykernel) is the one with xcdat. I thought it is just bare-bone python3. I guess python -m ipykernel is not necessary, but when multiple kernels are with the same name, it can cause some confusion. And I'm still fine with registering the xcdat_note book with a specified name at this point.

@tomvothecoder I did not know Python3 (ipykernel) is the one with xcdat. I thought it is just bare-bone python3. I agree python -m ipykernel is not necessary, but when multiple kernels are with the same name, it can cause some confusion. And I'm still fine with registering the xcdat_note book with a specified name at this point.

If Jupyter is invoked from within a conda environment (xcdat_notebook in this case), the Python kernel of that environment is defaulted as "Python 3 (ipykernel)". I don't think there should be any other kernels listed unless the user manually adds them (e.g., python -m ipykernel), since the Jupyter instance is isolated within the conda env (not 100% sure though).
On the other hand, public Jupyter instances would probably have multiple kernels listed (e.g., NERSC Jupyter Hub) since kernels are manually registered to that public instance.
We can either 1) add a note on the notebooks to let the the user know Python3 (ipykernel) is the kernel of xcdat_notebook by default or 2) add the extra step to register the kernel in all of the notebooks.

I don't think there should be any other kernels listed unless the user manually adds them (e.g., python -m ipykernel), since the Jupyter instance is isolated within the conda env (not 100% sure though).

I just confirmed that no other kernels are registered in the Jupyter instance invoked by xcdat_notebook. The only one listed is "Python 3 (ipykernel)", which is the ipykernel of xcdat_notebook.

This is what I see from my end...

We can either 1) add a note on the notebooks to let the the user know Python3 (ipykernel) is the kernel of xcdat_notebook by default or 2) add the extra step to register the kernel in all of the notebooks, which is necessary if the tries to use the notebooks through a Jupyter instance invoked elsewhere and not xcdat_notebook.

I think it is a good solution!

This is what I see from my end...In my Jupyter instance, it includes even my old conda env registered with Jupyter.

Thanks for the screenshot! Yeah I'm not sure why those kernels are registered with the Jupyter instance invoked through xcdat_notebook. Maybe that's how it's supposed to be.
In any case, I will update all the notebooks using both solutions above in a separate PR.

This is what I see from my end...In my Jupyter instance, it includes even my old conda env registered with Jupyter.

Thanks for the screenshot! Yeah I'm not sure why those kernels are registered with the Jupyter instance invoked through xcdat_notebook. Maybe that's how it's supposed to be.
In any case, I will update all the notebooks using both solutions above in a separate PR.

Thank you for implementing it!

@chengzhuzhang @tomvothecoder
The warning /Users/zhang40/mambaforge/envs/xcdat_notebook/lib/python3.12/site-packages/xcdat/regridder/regrid2.py:195: RuntimeWarning: invalid value encountered in divide   np.divide( is fine, it occurs when regridding with a mask and the sum of the input weights for a cell is zero, which is just missing data in that cell.
I do see the visual difference in the last example, this would be expected as I reworked how masking worked. The updated result should be more accurate, it appears to be visually.

@chengzhuzhang @tomvothecoder The warning /Users/zhang40/mambaforge/envs/xcdat_notebook/lib/python3.12/site-packages/xcdat/regridder/regrid2.py:195: RuntimeWarning: invalid value encountered in divide np.divide( is fine, it occurs when regridding with a mask and the sum of the input weights for a cell is zero, which is just missing data in that cell.
I do see the visual difference in the last example, this would be expected as I reworked how masking worked. The updated result should be more accurate, it appears to be visually.

Got it. Thank you for the calcification @jasonb5

@chengzhuzhang @tomvothecoder The warning /Users/zhang40/mambaforge/envs/xcdat_notebook/lib/python3.12/site-packages/xcdat/regridder/regrid2.py:195: RuntimeWarning: invalid value encountered in divide np.divide( is fine, it occurs when regridding with a mask and the sum of the input weights for a cell is zero, which is just missing data in that cell.
I do see the visual difference in the last example, this would be expected as I reworked how masking worked. The updated result should be more accurate, it appears to be visually.

Great! @chengzhuzhang You can merge this PR if you think it is ready.


Fix entity position desync when spawned in an 8 block radius from world center (0,0,0)

This issue happens because the lastSyncedPosition is set to Pos.ZERO when the entity spawns, even though SpawnEntityPacket already synchronizes the entity's position with the clients.
As a result, when the entity is within an 8-block radius of the center, the refreshPosition method detects a change between its last synced position (Pos.ZERO) and its current position, despite the position already being synced. EntityPositionAndRotationPacket is used for movement updates of less than 8 blocks, but it only transmits the delta of the movement rather than the new position itself. Consequently, the client ends up receiving the entity's position twice: once from the SpawnEntityPacket and again from the EntityPositionAndRotationPacket which adds up to it, leading to an incorrect position

Forgot about the tests...
Since the position is immediately synced when the entity spawns, we can immediately expect the velocity to be sent?


Migrating from active_model_serializers to fast_jsonapi

Hello, thanks amazing work on this gem! The performance improvements comparing to AMS are really impressive so we are migrating from it.
To ease our migration we didn't wanted to change the JSON output. However the default JSON structure produced by this gem is something along this:
{
  "data": [
    {
      "id": "1",
      "type": "model_1",
      "attributes": {
        "id": 1,
        "model_att_1": "foo"
        "mode_att_2": "bar"
      },
      "relationships": {
        "model_1_association": {
          "data": [
...

while with AMS the structure was more basic:
{
  "model_1s": [
    {
      "id": 1,
      "model_att_1": "foo",
      "mode_att_2": "bar",
      "model_1_association": [
        {
          "id": 3
...

Is there any way to change the JSON structure to match the AMS one?
Thanks!

This gem serializes data based on the JSON API specs. I think with AMS you are using the attributes adapter? If you change the adapter to json_api you will basically get the same result as fast_jsonapi:
ActiveModelSerializers.config.adapter = :json_api # Default: `:attributes`

+1 to what @devmarwen mentioned. You are probably not using AMS with the json_api adapter.

Ok I understand now. So it is possible to change AMS JSON adapter to be the same as the fast_jsonapi one, but I suppose it is not possible to do the opposite, change the fast_jsonapi adapter to attributes right? given the name of the gem

That's right.
On Wed, Sep 12, 2018, 2:44 PM João Horta<EMAIL_ADDRESS>wrote:

Ok I understand now. So it is possible to change AMS JSON adapter to be
the same as the fast_jsonapi one, but I suppose it is not possible to do
the opposite, change the fast_jsonapi adapter to attributes right? given
the name of the gem
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/fast_jsonapi/issues/316#issuecomment-420573432,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD2OwcyAIAw8jVGlgGBuP-sI76lsokRqks5uaNBzgaJpZM4WjF1g
.


Update datenshi_beatmap_criteria_en.md

Masih belum selesai
Gini aja dulu, gw mau main dulu ntar :P

OkOn Apr 28, 2021 8:28 PM, XDerbyX @.***> wrote:Masih belum selesai
Gini aja dulu, gw mau main dulu ntar :P
You can view, comment on, or merge this pull request online at:
  https://github.com/osu-datenshi/website-docs/pull/10
Commit Summary
Update datenshi_beatmap_criteria_en.md
File Changes
M
en/datenshi_beatmap_criteria_en.md
(35)

Patch Links:
https://github.com/osu-datenshi/website-docs/pull/10.patchhttps://github.com/osu-datenshi/website-docs/pull/10.diff
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.


Port the table component from Wikit back to the Mismatch Finder

With the deprecation of Wikit (and until such a component is available through Codex) we are moving the table component back into the mismatch finder repo.
This PR also includes minor component syntax updates to Vue 3.
NOTE: styles that have it, were replaced with their codex equivalent. otherwise the wikit tokens were replace with discrete values.
Bug: T348271

I know what you mean. We can't call it MismatchesTable since that's the containing component, we can't use WikitTable anymore and it's not a CodexTable... any suggestions?

I know what you mean. We can't call it MismatchesTable since that's the containing component, we can't use WikitTable anymore and it's not a CodexTable... any suggestions?

How about ResultsTable? or TableComponent?

How about ResultsTable? or TableComponent?

Both are good, I think I like TableComponent better for this context


open-ssl0.98 Handshake error

When using open-ssl0.98 you will receive a handshake error when authenticating. Problem is solved when using openssl 1.0.1 or higher.
In the current documentation there is nor remark on which open-ssl version should be used. Maybe it is good to set directly on the front page as a dependency.

Solved in PR 71, will be included in 1.0.2.


Trace Gradle Sync with Skate

Add hooks to trace Gradle sync time with Skate
Sample data:
https://analytics.tinyspeck.com/v3/explore/1000000001280941

Out of curiosity, why do we want to trace here when we have this in develocity too?

I think it'd be nice to compare the data here vs Develocity to see if there's any difference. Another nice extra just brought up by Jason is we can get from this data is when someone skipped sync. I think it'd be a deal breaker if adding tracing makes the IDE performance worse. So far, I think it's been quite fast so I want to go with it and see how the data looks like. Lmk if you have other thoughts


Remove useCache in DefaultArtifactResolutionQuery

Fix https://github.com/gradle/gradle/issues/3579
The inappropriate usage of useCache in DefaultArtifactResolutionQuery might cause dead lock.
This PR remove the usage of useCache.

@bigdaz I think you're the best for this because you're more familiar with DefaultArtifactResolutionQuery

Just a heads-up.
ArtifactResolutionQuery is used by kotlin-dsl to resolve source artifacts for build script dependencies. And since that operation is triggered whenever the user saves the file in the IDE (be it IDEA or Eclipse) it's important that it completes as quickly as possible and, more importantly, that it doesn't cause unnecessary/avoidable network roundtrips.
I have no idea if this PR changes the performance characteristics of ArtifactResolutionQuery but if it does we might have to do something about it on the kotlin-dsl side.

@bamboo this has no effect on performance, it is a leftover we missed when we completely refactored our artifact locking.

@oehme if you're familiar with this change, I'm happy for you to take over the review.


bug: #313 responsive width wrt size

@ASQUAREEE can you include a few screenshots of how this looks?

@ASQUAREEE can you include a few screenshots of how this looks?

sure

This LGTM! I'll give FE folks a chance to chime in

LGTM


Let's say we have an html + text multipart/alternative message.
Let's say we have inline images in the html part.
Using your own tutorials, the resulting structure is this:
1. multipart/alternative
        1.1. text/plain
        1.2. multipart/related
                1.2.1. text/html
                1.2.2. inline image 1
                1.2.3. inline image 2
                1.2.4. ...

That seems logical right? Wrong. In Outlook Express and a bunch of other clients the above structure produces a mess for the text-only version of the email, and it renders a phantom clip icon for attachments, which shouldn't be there for inline images.
Here's the correct structure: http://msdn.microsoft.com/en-us/library/office/aa563064(v=exchg.140).aspx
Now, achieving this structure in the link is god damn impossible in Swift_Mailer, because the Swift_Mime_SimpleMimeEntity's setChildren() method is trying to be "smart" by doing these among other things:

Auto-creating wrapper multipart entities.
Taking the $contentType users pass and just assigning some other content type value. Whatever, right?
Re-ordering the entities, sometimes doing the right thing (like putting text/plain before text/html) and sometimes the wrong thing (putting attachments before the text/html part, although they were added after the text/html part).

The code in this method has a little comment: "// TODO: Try to refactor this logic". Apparently that wasn't done.
Here's what I had to do to gain some control over the MIME part content types and hierarchy:
/**
 * Patching Swift Mailer.
 *
 * Prevents mangling of content-type, reshuffling of children, and appearance of phantom multipart entities.
 */
trait FixSwiftMailerMadness {
    public function setChildren(array $children, $compoundLevel = null) {
        // Setting parent class private properties.
        $set = function ($class, $object, $name, $value) {
            $refl = new \ReflectionProperty($class, $name);
            $refl->setAccessible(true);
            $refl->setValue($object, $value);
        };

        // Calling parent class private methods.
        $call = function ($class, $object, $name, array $args = null) {
            $refl = new \ReflectionMethod($class, $name);
            $refl->setAccessible(true);
            if ($args) return $refl->invokeArgs($object, $args);
            else return $refl->invoke($object);
        };

        $set('Swift_Mime_SimpleMimeEntity', $this, '_immediateChildren', $children);
        $call('Swift_Mime_SimpleMimeEntity', $this, '_fixHeaders');
        return $this;
    }
}

// With this, I'm using "new MimePart()" instead of "\Swift_MimePart::newInstance()".
class MimePart extends \Swift_MimePart {
    use FixSwiftMailerMadness;
}

// With this, I'm using "new Message()" instead of "\Swift_Message::newInstance()".
class Message extends \Swift_Message {
    use FixSwiftMailerMadness;
}

And here's a snippet of me using the above patched classes to reproduce the structure from the MSDN article (which works great):
$message = new Message();

$message
<EMAIL_ADDRESS>'****')
    ->setSubject($messageData['subject'])
    ->setTo($messageData['to']);

/*
 * Assemble the body hierarchy manually.
 */

$htmlBody = new MimePart($messageData['html'], 'text/html');
$textBody = new MimePart($messageData['text'], 'text/plain');

$alternative = new MimePart(null, 'multipart/alternative');
$alternative->setChildren([$textBody, $htmlBody]);

$related = new MimePart(null, 'multipart/related');
$related->setChildren(\array_merge([$alternative], $inlineImages));

$message->setContentType('multipart/mixed');
$message->setChildren([$related]);

$result = $this->mailer->send($message, $failedRecipients);

A note: "$inlineImages" above is an array of Swift_EmbeddedFile instances (for inline images). Since this type of entity has no children, I didn't need to patch that particular class.
Fixing the mess in the original code would require a lot of refactoring, and it should start with cutting setChildren to those two lines I'm emulating above.
So my question is - what's the status among the maintainers, is this going to be refactored, or not.
The entities should be free to assemble without any "magic" going on. The part sorting, wrapping and so on compositing should happen as a separate step in a separate class.
I may be able to help out, if I have your agreement.

Using your own tutorials, the resulting structure is this:

@ghost where are these tutorial that allowed you to create that structure?

I'm closing this issue as it's going to be fixed by Symfony Mailer/Mime, which will replace Swiftmailer eventually.


Support Multiple Clinical Data grids

Summary

Support Multiple Clinical Data grids on a single page
https://jira2.cerner.com/browse/UXPLATFORM-6578
Deployment Link

https://terra-clinical-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-clinical-data-grid

  Generated by :no_entry_sign: dangerJS against 40fc5894076d2ce6e8d76d0472e2eec5efd8e1eb

Related to-
Story Link: https://jira2.cerner.com/browse/UXPLATFORM-6578
Epic Link: https://jira2.cerner.com/browse/UXPLATFORM-8215

@KoushikKalli  Has the selection issue described on the Jira along with tabbing also been tested after the above changes? Also, do you see any console errors on the dev site or have they been fixed.


qt 5.8 build failed

I built qt 5.8 failed as follows under windows 7 sp1 64 chinese edition with cmake 3.8.0 and visual studio 2017. The vcpkg version is 0.0.81-e6a47f5c6a2f6efef3d10fd1e2cbb9e123d5dbe7.
jom 1.1.2 - empower your cores
C:\vcpkg\buildtrees\qt5\src\qt-5.8.0\qtbase\src\corelib\kernel\qobjectdefs.h(0): Note: No relevant classes found. No output generated.
C:\vcpkg\buildtrees\qt5\src\qt-5.8.0\qtbase\src\network\access\qnetworkaccessdebugpipebackend_p.h(0): Note: No relevant classes found. No output generated.
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\src\plugins\generic\tuiotouch\Makefile.Release [.obj\release\qtuiohandler.obj] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\src\plugins\generic\tuiotouch\Makefile [release] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\src\plugins\generic\Makefile [sub-tuiotouch-make_first] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\src\plugins\Makefile [sub-generic-make_first] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\src\Makefile [sub-plugins-make_first] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\qtbase\Makefile [sub-src-make_first] Error 2
jom: C:\vcpkg\buildtrees\qt5\x86-windows-rel\Makefile [module-qtbase-make_first] Error 2

Have you tried invoking the installation again? Sometimes it fails and I'm still not confident what's causing this issue. Would be glad if you could add the other generated log files maybe they show more information.

C:\vcpkg>vcpkg install qt5
The following packages will be built and installed:
qt5:x86-windows
Building package qt5:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/packages/qt5_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/buildtrees/qt5
-- CURRENT_PORT_DIR=C:/vcpkg/ports/qt5/.
-- Using cached C:/vcpkg/downloads/qt-<IP_ADDRESS>z
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch C:/vcpkg/ports/qt5/fix-qalgorithms-vs2017.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/vcpkg/ports/qt5/fix-qalgorithms-vs2017.patch done
-- Applying patch C:/vcpkg/ports/qt5/fix-commandline-overrides.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch C:/vcpkg/ports/qt5/fix-commandline-overrides.patch done
-- Configuring x86-windows-rel
-- Configuring x86-windows-rel done
-- Configuring x86-windows-dbg
-- Configuring x86-windows-dbg done
-- Package x86-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:14 (message):
Command failed: C:/vcpkg/downloads/tools/jom/jom-1.1.2/jom.exe;/J;8
Working Directory: C:/vcpkg/buildtrees/qt5/x86-windows-rel
See logs for more information:
C:\vcpkg\buildtrees\qt5\build-x86-windows-rel-out.log
C:\vcpkg\buildtrees\qt5\build-x86-windows-rel-err.log
Call Stack (most recent call first):
ports/qt5/install_qt.cmake:19 (vcpkg_execute_required_process)
ports/qt5/portfile.cmake:54 (install_qt)
scripts/ports.cmake:73 (include)
Error: Building package qt5:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: qt5:x86-windows
Vcpkg version: 0.0.81-ef149c7c4b8852916cf863598ce17ead9602641b
Additionally, attach any relevant sections from the log files above.
C:\vcpkg>vcpkg install qt5
The following packages will be built and installed:
qt5:x86-windows
Building package qt5:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/vcpkg/packages/qt5_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/vcpkg/buildtrees/qt5
-- CURRENT_PORT_DIR=C:/vcpkg/ports/qt5/.
-- Using cached C:/vcpkg/downloads/qt-<IP_ADDRESS>z
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting source C:/vcpkg/downloads/qt-<IP_ADDRESS>z
-- Extracting done
-- Applying patch C:/vcpkg/ports/qt5/fix-qalgorithms-vs2017.patch
-- Applying patch C:/vcpkg/ports/qt5/fix-qalgorithms-vs2017.patch done
-- Applying patch C:/vcpkg/ports/qt5/fix-commandline-overrides.patch
-- Applying patch C:/vcpkg/ports/qt5/fix-commandline-overrides.patch done
-- Configuring x86-windows-rel
-- Configuring x86-windows-rel done
-- Configuring x86-windows-dbg
-- Configuring x86-windows-dbg done
-- Package x86-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:14 (message):
Command failed: C:/vcpkg/downloads/tools/jom/jom-1.1.2/jom.exe;/J;8
Working Directory: C:/vcpkg/buildtrees/qt5/x86-windows-rel
See logs for more information:
C:\vcpkg\buildtrees\qt5\build-x86-windows-rel-out.log
C:\vcpkg\buildtrees\qt5\build-x86-windows-rel-err.log
Call Stack (most recent call first):
ports/qt5/install_qt.cmake:19 (vcpkg_execute_required_process)
ports/qt5/portfile.cmake:54 (install_qt)
scripts/ports.cmake:73 (include)
Error: Building package qt5:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: qt5:x86-windows
Vcpkg version: 0.0.81-ef149c7c4b8852916cf863598ce17ead9602641b

Could you try adding DISABLE_PARALLEL after this line https://github.com/Microsoft/vcpkg/blob/master/ports/qt5/portfile.cmake#L43 ?
After this change run vcpkg install qt again jom should be run with /J;1 so one process only maybe this brings some trouble. (Note that this could result in very long compilation time.)

I suggest you check C:\vcpkg\buildtrees\qt5\build-x86-windows-rel-out.log to see if it contains error C2001. If so, you may suffer the same issue as mine (#1092).


detox test hangs when starting the Android emulator (Apple Silicon)

Describe the bug
We upgraded our Detox machine to the new M1 Mac mini and ran into this issue. detox build -c android.emu.debug succeeds without problems. detox test -c android.emu.debug starts but then hangs when the emulator window opens. The app does not launch. Here is the printout.
detox test -c android.emu.debug --loglevel trace --record-logs all

detox[21491] INFO:  [test.js] DETOX_CONFIGURATION="android.emu.debug" DETOX_FORCE_ADB_INSTALL=false DETOX_LOGLEVEL="trace" DETOX_READ_ONLY_EMU=false DETOX_RECORD_LOGS="all" DETOX_REPORT_SPECS=true DETOX_START_TIMESTAMP=1620319503548 DETOX_USE_CUSTOM_LOGGER=true jest --config e2e/config.json --testNamePattern '^((?!:ios:).)*$' --maxWorkers 1 e2e
detox[21492] TRACE: [DETOX_CREATE] created a Detox instance with config:
{"artifactsConfig":{"rootDir":"artifacts/android.emu.debug.2021-05-06 16-45-03Z","plugins":{"log":{"enabled":true,"keepOnlyFailedTestsArtifacts":false},"screenshot":{"enabled":true,"shouldTakeAutomaticSnapshots":false,"keepOnlyFailedTestsArtifacts":false},"video":{"enabled":false,"keepOnlyFailedTestsArtifacts":false},"instruments":{"enabled":false,"keepOnlyFailedTestsArtifacts":false},"timeline":{"enabled":false},"uiHierarchy":{"enabled":false,"keepOnlyFailedTestsArtifacts":false}},"pathBuilder":{"_rootDir":"artifacts/android.emu.debug.2021-05-06 16-45-03Z"}},"appsConfig":{"default":{"type":"android.apk","binaryPath":"android/app/build/outputs/apk/dev/debug/app-dev-debug.apk","build":"cd android && ./gradlew assembleDevDebug assembleDevDebugAndroidTest -DtestBuildType=debug && cd .."}},"behaviorConfig":{"init":{"reinstallApp":true,"exposeGlobals":true},"cleanup":{"shutdownDevice":false},"launchApp":"auto"},"cliConfig":{"recordLogs":"all","configuration":"android.emu.debug","forceAdbInstall":"false","loglevel":"trace","useCustomLogger":"true"},"deviceConfig":{"type":"android.emulator","device":{"avdName":"Pixel_4_API_S"}},"runnerConfig":{"testRunner":"jest","runnerConfig":"e2e/config.json","specs":"e2e"},"sessionConfig":{"autoStart":true,"server":"ws://localhost:53897","sessionId":"739c184a-52ba-ed62-53c8-459377c997f9","debugSynchronization":10000},"errorComposer":{"configurationName":"android.emu.debug","filepath":"/Users/fleetback-ci/builds/9J-UT-y5/0/arhs-fleetback/fleetback-app-react/.detoxrc.json","contents":{"testRunner":"jest","runnerConfig":"e2e/config.json","configurations":{"ios.sim.debug":{"binaryPath":"ios/build/Build/Products/Debug-iphonesimulator/Fleetback DEV.app","build":"xcodebuild -workspace ios/FleetbackApp.xcworkspace -scheme FleetbackApp-DEV -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build","type":"ios.simulator","device":{"type":"iPhone 11"}},"ios.sim.release":{"binaryPath":"ios/build/Build/Products/Release-iphonesimulator/Fleetback DEV.app","build":"xcodebuild -workspace ios/FleetbackApp.xcworkspace -scheme FleetbackApp-DEV-release -configuration Release -sdk iphonesimulator -derivedDataPath ios/build","type":"ios.simulator","device":{"type":"iPhone 11"}},"android.emu.debug":{"binaryPath":"android/app/build/outputs/apk/dev/debug/app-dev-debug.apk","build":"cd android && ./gradlew assembleDevDebug assembleDevDebugAndroidTest -DtestBuildType=debug && cd ..","type":"android.emulator","device":{"avdName":"Pixel_4_API_S"}},"android.emu.release":{"binaryPath":"android/app/build/outputs/apk/dev/release/app-dev-release.apk","build":"cd android && ./gradlew assembleDevRelease assembleDevReleaseAndroidTest -DtestBuildType=release && cd ..","type":"android.emulator","device":{"avdName":"Pixel_4_API_S"}}}},"_extends":false}}
detox[21492] DEBUG: [WSS_CREATE] Detox server listening on localhost:53897...
detox[21492] DEBUG: [WSS_CONNECTION, #53898] registered a new connection.
detox[21492] TRACE: [WS_OPEN] opened web socket to: ws://localhost:53897
detox[21492] TRACE: [WS_SEND] {"type":"login","params":{"sessionId":"739c184a-52ba-ed62-53c8-459377c997f9","role":"tester"},"messageId":0}
detox[21492] TRACE: [WSS_GET_FROM, #53898] {"type":"login","params":{"sessionId":"739c184a-52ba-ed62-53c8-459377c997f9","role":"tester"},"messageId":0}
detox[21492] TRACE: [SESSION_CREATED] created session 739c184a-52ba-ed62-53c8-459377c997f9
detox[21492] TRACE: [WSS_SEND_TO, #tester] {"type":"loginSuccess","params":{"testerConnected":true,"appConnected":false},"messageId":0}
detox[21492] TRACE: [SESSION_JOINED] tester joined session 739c184a-52ba-ed62-53c8-459377c997f9
detox[21492] TRACE: [WS_MESSAGE] {"type":"loginSuccess","params":{"testerConnected":true,"appConnected":false},"messageId":0}

detox[21492] DEBUG: [EXEC_CMD, #0] "/Users/fleetback-ci/Library/Android/sdk/emulator/emulator" -list-avds --verbose
detox[21492] TRACE: [EXEC_SUCCESS, #0] Pixel_4_API_25
Pixel_4_API_S

detox[21492] DEBUG: [EXEC_CMD, #1] "/Users/fleetback-ci/Library/Android/sdk/emulator/emulator" -version
detox[21492] ERROR: [EXEC_FAIL, #1] ""/Users/fleetback-ci/Library/Android/sdk/emulator/emulator" -version " failed with error = ChildProcessError: Command failed: "/Users/fleetback-ci/Library/Android/sdk/emulator/emulator" -version
 `"/Users/fleetback-ci/Library/Android/sdk/emulator/emulator" -version ` (exited with error code 255) (code=255), stdout and stderr:

detox[21492] ERROR: [EXEC_FAIL, #1] emulator: Android emulator version <IP_ADDRESS> (build_id 7036990) (CL:N/A)
emulator: ERROR: can't find the emulator executable.

detox[21492] ERROR: [EXEC_FAIL, #1]
detox[21492] DEBUG: [EMU_BIN_VERSION_DETECT] Detected emulator binary version { major: 30, minor: 3, patch: 5, toString: [Function: toString] }
detox[21492] DEBUG: [ALLOCATE_DEVICE] Trying to allocate a device based on "Pixel_4_API_S"
detox[21492] DEBUG: [EXEC_CMD, #2] "/Users/fleetback-ci/Library/Android/sdk/platform-tools/adb"  devices
detox[21492] DEBUG: [EXEC_SUCCESS, #2] List of devices attached

detox[21492] DEBUG: [ALLOCATE_DEVICE] Settled on emulator-17342
detox[21492] DEBUG: [SPAWN_CMD] /Users/fleetback-ci/Library/Android/sdk/emulator/emulator -verbose -no-audio -no-boot-anim -port 17342 @Pixel_4_API_S

 RUNS  e2e/firstTest.e2e.js

Building and running the iOS tests works. Both iOS and Android tests build, run and pass on our Intel MacBooks. I had to patch line 22 of EmulatorVersionResolver.js because the command seems broken but still prints the version so it's easy to workaround.
If you Cmd+Q the emulator, more logs appear. The whole logs are attached to the post.
If you don't have a M1 Mac to reproduce the problem, can you give us some pointers as to why the process can get stuck on the adb command? We can help debug and fix the problem.
Steps To Reproduce

[x] I have tested this issue on the latest Detox release and it still reproduces

create a basic react native project
setup detox
patch EmulatorVersionResolver.js with rawOutput = await (this._emulatorExec.exec(new QueryVersionCommand()).catch(e => e.stdout || e.stderr)) || '';
run detox build -c android.emu.debug && detox test -c android.emu.debug
it hangs

Expected behavior
It should launch the app and run the tests.
Detox Trace-Logs
See attached file detox_bug.txt
Device logs (adb logcat)
It says - waiting for device - and nothing happens. If you need them I can try with Android Studio.
Environment (please complete the following information):

Detox: 18.12.2
React Native: 0.64.1
Node: v14.16.1
Device: Emulated Pixel 4 API 31 arm64
OS: macOS 11.3 on the M1 Mac mini
Test-runner jest-circus

This may be off-topic. If you use gitlab-runner you may get this error when running your tests.
detox[77919] ERROR: [exec.js/EXEC_FAIL, #0] "applesimutils --list --byType "iPhone 11"" failed with code = 127, stdout and stderr:
152detox[77919] ERROR: [exec.js/EXEC_FAIL, #0]
153detox[77919] ERROR: [exec.js/EXEC_FAIL, #0] /bin/sh: applesimutils: command not found
154detox[77919] ERROR: ChildProcessError: Command failed: applesimutils --list --byType "iPhone 11"
155/bin/sh: applesimutils: command not found
156 `applesimutils --list --byType "iPhone 11"` (exited with error code 127)

Note that applesimutils is properly installed with brew. It seems sh cannot follow the simlink. My simple fix is to copy the executable to /usr/local/bin/ like this.
sudo cp /opt/homebrew/Cellar/applesimutils/0.9.2/bin/applesimutils /usr/local/bin/
You should now uninstall it from brew to avoid having multiple applesimutils in your path.
brew uninstall applesimutils

@drash-course I would advise against that. brew should set a symlink in /usr/local/bin for you. Perhaps trying to reinstall would work.

Not sure if this will be useful for others or not, but as of today (July 15, 2021) a procedure that worked for me to get Detox tests working for react-native on an Apple M1 device were:

Get the current Arctic Fox Preview Apple Silicon build (https://developer.android.com/studio/archive - it is 2020.1.3 beta5 for me right now  / https://redirector.gvt1.com/edgedl/android/studio/ide-zips/2<IP_ADDRESS>/android-studio-2<IP_ADDRESS>-mac_arm.zip) - you can now run it as 'Android Studio Preview'
Use SDK Manager to install the emulator package
From Terminal go to $ANDROID_SDK_ROOT/emulator and run ./emulator make sure it updates itself with the emulator preview release etc (https://github.com/google/android-emulator-m1-preview/releases - 0.2 engine-only is what will be downloaded and unpacked). If you run ./emulator -version you should see <IP_ADDRESS> because the arm64 emulator is a custom build and overwrites the SDK Manager package. It will also show the exit code 255 could not find emulator binary executable error as well, which looks dire but may be ignored
Use AVD Manager to make a new AVD - I found if I used Android S / API31 preview networking was broken. API30 works though, both Play and Google APIs flavors. Boot it and test it, you should have a working emulator now
When you run Detox, it will give you a dire message about the exit code 255 mentioned above, but it will carry on :-). Then it hangs and times out because the adb reverse does need to be done manually for some reason. Either as above using Detox config or in Terminal with adb reverse tcp:8081 tcp:8081

I believe most of this is simply confirming the above info, but an important point for me was total emulator network failure on API31 while API30 worked in general but did need the manual reverse port mapping.
Cheers

@mikehardy Thanks!!!
Worth mentioning: adb reverse is only needed when running in debug (dynamic bundle loading) mode.

Oh yes! If you have the bundle packed up in the app (release mode) of course, it doesn't have to go over the port to fetch - good extra detail. This arm64 stuff is still pretty fiddly but at least most things are possible now. Side note: just last week google finally published a .xcframework with arm64 emulator slice for google sign in. Maps still doesn't work AFAIK. So, the whole ecosystem is still fractured after this architecture earthquake. But my detox tests ran! :-). Cheers

whole ecosystem is still fractured after this architecture earthquake. But my detox tests ran! :-)

... which makes it all the more astounding. Kudos!

Hey I'm struggling with this issue myself we get the following message:
detox[85761] INFO:  [test.js] deviceLaunchArgs="-partition-size 8000 -memory 6144 -no-snapshot -wipe-data -skin 800x1280" mocha --opts ./e2e/mocha.opts --configuration android.emu.debug --grep :ios: --invert --take-screenshots failing --use-custom-logger true ./e2e/specs/01_DE/03_DE_account_spec.js
detox[85763] INFO:  [DetoxServer.js] server listening on localhost:54419...
detox[85763] ERROR: [exec.js/EXEC_FAIL, #1] ""/Users/administrator/android-sdk/emulator/emulator" -version " failed with code = 255, stdout and stderr:
detox[85763] ERROR: [exec.js/EXEC_FAIL, #1] emulator: Android emulator version <IP_ADDRESS> (build_id 7036990) (CL:N/A)
emulator: ERROR: can't find the emulator executable.
detox[85763] ERROR: [exec.js/EXEC_FAIL, #1]
detox[85763] ERROR: [EmulatorVersionResolver.js/EMU_BIN_VERSION_DETECT] Could not detect emulator binary version ChildProcessError: Command failed: "/Users/administrator/android-sdk/emulator/emulator" -version
 `"/Users/administrator/android-sdk/emulator/emulator" -version ` (exited with error code 255)
    at callback (/Users/administrator/builds/K9TR58dn/0/developers/mobile-app/node_modules/child-process-promise/lib/index.js:33:27)
    at ChildProcess.exithandler (child_process.js:397:5)
    at ChildProcess.emit (events.js:400:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Socket.<anonymous> (internal/child_process.js:441:11)
    at Socket.emit (events.js:400:28)
    at Pipe.<anonymous> (net.js:675:12) {
  code: 255,
  childProcess: {
    _forkChild: [Function: _forkChild],
    ChildProcess: [Function: ChildProcess],
    exec: [Function: exec],
    execFile: [Function: execFile],
    execFileSync: [Function: execFileSync],
    execSync: [Function: execSync],
    fork: [Function: fork],
    spawn: [Function: spawnWithSignal],
    spawnSync: [Function: spawnSync]
  },
  stdout: 'emulator: Android emulator version <IP_ADDRESS> (build_id 7036990) (CL:N/A)\n' +
    "emulator: ERROR: can't find the emulator executable.\n" +
    '\n',
  stderr: ''
}
detox[85763] WARN:  [AVDValidator.js/AVD_VALIDATION] Emulator version detection failed (See previous logs)
detox[85763] ERROR: [exec.js/EXEC_FAIL, #2] ""/Users/administrator/android-sdk/emulator/emulator" -version " failed with code = 255, stdout and stderr:
detox[85763] ERROR: [exec.js/EXEC_FAIL, #2] emulator: Android emulator version <IP_ADDRESS> (build_id 7036990) (CL:N/A)
emulator: ERROR: can't find the emulator executable.
detox[85763] ERROR: [exec.js/EXEC_FAIL, #2]
detox[85763] ERROR: [EmulatorVersionResolver.js/EMU_BIN_VERSION_DETECT] Could not detect emulator binary version ChildProcessError: Command failed: "/Users/administrator/android-sdk/emulator/emulator" -version
 `"/Users/administrator/android-sdk/emulator/emulator" -version ` (exited with error code 255)
    at callback (/Users/administrator/builds/K9TR58dn/0/developers/mobile-app/node_modules/child-process-promise/lib/index.js:33:27)
    at ChildProcess.exithandler (child_process.js:397:5)
    at ChildProcess.emit (events.js:400:28)
    at maybeClose (internal/child_process.js:1055:16)
    at Socket.<anonymous> (internal/child_process.js:441:11)
    at Socket.emit (events.js:400:28)
    at Pipe.<anonymous> (net.js:675:12) {
  code: 255,
  childProcess: {
    _forkChild: [Function: _forkChild],
    ChildProcess: [Function: ChildProcess],
    exec: [Function: exec],
    execFile: [Function: execFile],
    execFileSync: [Function: execFileSync],
    execSync: [Function: execSync],
    fork: [Function: fork],
    spawn: [Function: spawnWithSignal],
    spawnSync: [Function: spawnSync]
  },
  stdout: 'emulator: Android emulator version <IP_ADDRESS> (build_id 7036990) (CL:N/A)\n' +
    "emulator: ERROR: can't find the emulator executable.\n" +
    '\n',
  stderr: ''
}
detox[85763] WARN:  [EmulatorDriver.js/EMU_SKIN_CFG_PATCH] Failed to detect emulator version! (see previous logs)
This leaves Detox unable to tell if it should automatically apply this patch-fix: https://stackoverflow.com/a/47265664/453052, which seems to be needed in emulator versions < 28.
If you feel this is not needed, you can either ignore this message, or otherwise apply the patch manually.
waitForOnboarding button

but then most of the times it actually continues with the tests. The main issue I have is that it's a bit unreliable and also hangs for 2 minutes before continuing (I think it keeps retrying or something).
I think it would be good to reopen this issue until a stable solution is out there, that would make it easier for folks like me to find a place they can wait for better news.

I have emulator startup to unreliable for android emulators forever, intel macs as well. I use a kill / retry loop for my CI for this reason.
Once booted, this failure to detect emulator problem should only be warning + delay though, I had 100% reliable test execution even with that warning given I already had an emulator successfully booted.

@mikehardy could you share with me your kill/retry loop code?

Check react-native-firebase e2e workflow for android

https://github.com/invertase/react-native-firebase/blob/90b4d7021aff7d5d28140b57eb69283b04712257/.github/workflows/tests_e2e_android.yml#L132-L175

@mikehardy would you not rather let Detox spin up the emulators for ya?

Too flaky in practice. The first restart hits maybe 10% of the time in github actions, second maybe 1% and so on. That's intolerable and I don't think detox has emu restart logic? If it does and I missed it though then sure

I finally cracked it. I was starting the emulator but then detox was also trying to start it and sometimes this caused errors in connection to it. As a solution, I made sure the launch args are identical in both cases (detox and my own launch). The most important one was to add the port option so I ensure that both will try to create it in the same port, otherwise, I could end up with 2 instances (not very often).
@d4vidi I wonder if there's a way to skip the device launch altogether and just skip straight to the install? When trying to connect and failing it will spend 2 mins. If I could skip this step this would improve my tests considerably.

In my experience if Detox detects the emulator/simulator is already up, it will not attempt to boot it, it just installs. So we boot separately (with flaky-restart-logic as above) and detox handles it. But locally (dev machines, where it's faster etc) detox boots things for me the first time in the morning according to the AVD name (android) or simulator profile (iOS) specified in detox config.

@sorodrigo, @mikehardy is right. I don't understand where this emulator boot-up race comes from but it sounds unhealthy. Technically, Detox enables you to preboot the emulator yourself. If it's an instance of the AVD specified in Detox's config of choice, then Detox should choose it for test execution.

@d4vidi maybe then we just need to opt out of patching the emulator? Detox tries to patch it and it takes 2 min to fail and continue with the tests

@sorodrigo what's you execution environment? Strikes me odd that the emulator binary is not found.

We're running the e2e in mac M1 machines using macOS Catalina. Detox version 17, because the latest version fails in M1 and also our testing code does not work well with the new version in other machines.

I am only chiming in quickly to say this is an interesting coincidence! react-native-firebase, which is my M1 detox experience at the moment, is also stuck on Detox 17. I didn't think to mention it before, but anything I mentioned up above about it working on M1 was validated on Detox 17 and if 18 is broken I'm unaware of it and haven't tried yet

@mikehardy that's actually very important input. Obviously, we urge you'd at all times use the latest (and greatest) of Detox (i.e. version 18+).

Indeed - recognizing this is now veering off topic, our being on v17 vs v18 is totally on me/us over at RNFB (though I do have great success on M1 with detox v17). I have moving to current stable as a todo for me and for whatever it's worth we just did a competitive analysis of the various test platforms for our next generation e2e harnesses and we're re-committing to Detox after a brief Cavy dalliance, so rest assured if v18 of Detox has an M1 problem I'll be back here, but hopefully with a PR :-). Cheers

@sorodrigo not sure what parts of Detox you're using but I've updated to Detox v18 now and it works fine on M1, just not on iOS15 (a known issue #2895). I also tested Detox v18 with Android 12 and it appears fine (#2899). As far as I can tell, the only thing not working at the moment is ios15 (noted) and maybe a need for a manual adb reverse for bundler port 8081 - cheers

Indeed - recognizing this is now veering off topic, our being on v17 vs v18 is totally on me/us over at react-native-firebase (though I do have great success on M1 with detox v17). I have moving to current stable as a todo for me and for whatever it's worth we just did a competitive analysis of the various test platforms for our next generation e2e harnesses (to be used in react-native-firebase, react-native-google-ads, notifee, react-native-mlkit, etc) and we're re-committing to Detox after a brief Cavy dalliance, so rest assured if v18 of Detox has an M1 problem I'll be back here, but hopefully with a PR :-). Cheers

Thrilled to know! Looking forward to getting feedback on v18.

why I cant use detox with last version of android studio?

For me as @mikehardy mentioned above, a adb reverse tcp:8081 tcp:8081 made the detox detect the react-native packager & run the tests. So the process is:

Run detox build command
Run react-native packager (npx react-native start)
Open the emulator & run adb reverse tcp:8081 tcp:8081
Run detox test command

""/Users/it062305/Library/Android/sdk/platform-tools/adb" -s emulator-11374 shell "ps | grep "com.eroev.app$""" failed with error = ChildProcessError: Command failed: "/Users/it062305/Library/Android/sdk/platform-tools/adb" -s emulator-11374 shell "ps | grep "com.eroev.app$""
"/Users/it062305/Library/Android/sdk/platform-tools/adb" -s emulator-11374 shell "ps | grep \"com\.eroev\.app$\"" (exited with error code 1) (code=1), stdout and stderr:


Deploy

Codecov Report

Merging #63 (5c99612) into master (53751b6) will decrease coverage by 0.43%.
The diff coverage is 85.71%.

:exclamation: Current head 5c99612 differs from pull request most recent head b0c01a3. Consider uploading reports for the commit b0c01a3 to get more accurate results

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   97.20%   96.77%   -0.44%
==========================================
  Files           7        8       +1
  Lines         358      372      +14
==========================================
+ Hits          348      360      +12
- Misses         10       12       +2

Impacted Files
Coverage Δ

service/config.py
83.33% <83.33%> (ø)

service/__init__.py
83.33% <100.00%> (+0.98%)
:arrow_up:

service/routes.py
100.00% <0.00%> (ø)

service/models.py
98.14% <0.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53751b6...b0c01a3. Read the comment docs.


Change Request to add environmentID for persona configuration.

Android [v2.11.0] - 2023-07-20

Added .environmentId on InquiryTemplateBuilder to create inquiries with a specific environment token.
                    // Environment Id
                    (arguments["environmentId"] as? String)?.let {
                        environmentId = it
                    }

                    environmentId?.let {
                        builder = builder?.environmentId(it)
                    }

iOS [v2.11.0] - 2023-07-20

Added .environmentId on InquiryTemplateBuilder to create inquiries with a specific environment token.
Change InquiryConfiguration
config = InquiryConfiguration(templateVersion: templateVersion,
                                                          accountId: accountId,
                                                          environment: environment,
                                                          fields: fields,
                                                          theme: theme)

To Inquiry builder
An Inquiry builder received by calling Inquiry.from(...)
  _inquiry = Inquiry.from(templateId: templateVersion, delegate: self)
                            .environment(Environment.from(rawValue: environment?.rawValue)).environmentId(environmentId)
                            .build()

`

Closes #34


Add benchmark test

Codecov Report

Merging #40 (bfa32e6) into beta (e72e2f6) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##              beta       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        20
  Lines          588       588
  Branches        80        80
=========================================
  Hits           588       588


Define Charka UI theme

Since we are using Charka UI I think we will have to define a theme for it. One of the first things that we could put there could be the red colour as a primary colour as it was mentioned in wiki:
Use colorScheme='red' for ChakraUI components to match Seneca's red colour theme, see
https://chakra-ui.com/docs/components/button/usage#usage

Charka also provides functionality to override styles of its own components like Button in the theme and in my opinion we should use theming as much as possible in order to keep all or almost all styles in one place.
Read more on Charka UI theming here: https://chakra-ui.com/docs/styled-system/theme

@Myrfion when you make a PR, you need to use "Fixes #34" in the description so it links the PR with the Issue, and auto-closes it.  I think #100 fixed this, correct?  If so, please close this.

Fixed in #100


Review and clean up GT Book

There are quite a lot of todos and incomplete pages in the GT Book.
Please add new tasks here.
To revise

Turn the Slideware pages from the Smalltalk Introductory lecture into dynamic lepiter pages (should not appear in the book)
Merge Ludo Exercise 5 and Ludo Exercise 6

To fix

Building a custom button appearance — review and update the deprecated code
Building the Memory Game graphics directly with the Sparta canvas — incomplete and may hang
Example-driven development by example — the example snippet does not update when the ombu file is loaded

To Expand

Building a custom button appearance — missing section at end
Connector
How to find stuff in GT in 7'
How to work with the file system
Implementing a stack machine (or remove it)
Plotter
Rewrite snippet
SmaCC (also write a tutorial)
Smalltalk
A tour of the environment
TreeMap
Understanding reflection

I think we can close this and open more detailed issues.

ok. Let's close this then.


An error is reported after vue is imported

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.3.1
Electron version
29.1.5
Operating system
macOS 14.3.1
Last known working Electron Forge version
No response
Expected behavior
yarn make can run properly with no error reported：
Actual behavior
yarn run v1.22.19
$ electron-forge package
✔ Checking your system
⠙ Preparing to package application
◼ Running packaging hooks
✔ Preparing to package application
❯ Running packaging hooks
✔ Running generateAssets hook
✔ Preparing to package application
❯ Running packaging hooks
✔ Running generateAssets hook
❯ Running prePackage hook
⠸ [plugin-vite] Building vite bundles
◼ Packaging application
◼ Running postPackage hook
✔ Preparing to package application
✔ Preparing to package application
❯ Running packaging hooks
✔ Running generateAssets hook
❯ Running prePackage hook
✔ Preparing to package application
✔ Running packaging hooks
✔ Running generateAssets hook
✔ Running prePackage hook
✔ [plugin-vite] Building vite bundles
❯ Packaging application
❯ Packaging for arm64 on darwin
✔ Copying files
✔ Preparing native dependencies [0.5s]
✖ Finalizing package
› /var/folders/f3/_c8y2b7575gb8zwp0k3fy4cc0000gn/T/electron-packager/tmp-LAvMjM/Electron.app/Contents/Resources/a…
◼ Running postPackage hook
An unhandled rejection has occurred inside Forge:
Error<EMAIL_ADDRESS>file<EMAIL_ADDRESS>links out of the package
at Filesystem.insertLink (/Users/steven/data/test/my-new-app21/node_modules/@electron/asar/lib/filesystem.js:106:13)
at handleFile (/Users/steven/data/test/my-new-app21/node_modules/@electron/asar/lib/asar.js:132:20)
at next (/Users/steven/data/test/my-new-app21/node_modules/@electron/asar/lib/asar.js:148:11)
at next (/Users/steven/data/test/my-new-app21/node_modules/@electron/asar/lib/asar.js:149:12)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async MacApp.asarApp (/Users/steven/data/test/my-new-app21/node_modules/@electron/packager/src/platform.ts:245:5)
at async MacApp.buildApp (/Users/steven/data/test/my-new-app21/node_modules/@electron/packager/src/platform.ts:150:5)
at async MacApp.initialize (/Users/steven/data/test/my-new-app21/node_modules/@electron/packager/src/platform.ts:141:7)
at async MacApp.create (/Users/steven/data/test/my-new-app21/node_modules/@electron/packager/src/mac.ts:435:5)
at async Promise.all (index 0)
at async packager (/Users/steven/data/test/my-new-app21/node_modules/@electron/packager/src/packager.ts:246:20)
error Command failed with exit code 1.
Steps to reproduce
1、npm init electron-app@latest my-vue-app -- --template=vite
2、npm install vue
3、npm install --save-dev @vitejs/plugin-vue
4、yarn
5、yarn make
Additional information
No response

I seem to be seeing a related issue running electron-forge package --platform darwin while building on macOs.
An unhandled rejection has occurred inside Forge:
Error<EMAIL_ADDRESS>file<EMAIL_ADDRESS>links out of the package
at Filesystem.insertLink (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/asar/lib/filesystem.js:106:13)
at handleFile (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/asar/lib/asar.js:132:20)
at next (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/asar/lib/asar.js:148:11)
at next (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/asar/lib/asar.js:149:12)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async MacApp.asarApp (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/packager/src/platform.ts:245:5)
at async MacApp.buildApp (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/packager/src/platform.ts:150:5)
at async MacApp.initialize (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/packager/src/platform.ts:141:7)
at async MacApp.create (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/packager/src/mac.ts:435:5)
at async Promise.all (index 0)
at async packager (/Users/dietrichstein/deepmojo-electron-vite/node_modules/@electron/packager/src/packager.ts:246:20)
Presumably, this could be reproducible on LuanRoger/electron-shadcn but I have not tried.
I tried several things including (1) a packageAfterPrune() hook trying to delete the file assuming it is being left behind due to a versioning mismatch (2) derefSymlinks: false, (3) vite-plugin-commonjs-externals, (4) optimizeDeps.exclude, (5) externalizeDepsPlugin from electron-vite. No combination of workaround using any them were fruitful for me. Currently looking at what electron-vite really has to offer as an alternative.

Is there a solution?
Now how to operate can make or package normally.
Or do you need to wait for a new release?

I encountered the same issue(links out of the package), and I resolved it by removing yarn.lock and switching to npm i.

I encountered the same issue(links out of the package), and I resolved it by removing yarn.lock and node_modules. Switch to npm:
rm -rf node_modules yarn.lock
npm i

Its worked for me!

After many tests, the problem was found, as long as the vue was introduced and then packaged, the error was reported, and there was no problem when the vue was removed. Is there any feasible solution?

https://www.electronforge.io/guides/framework-integration/vue-3#integrating-vue-3-code
Follow the document
An error occurs after npm install vue.
No problem after npm uninstall vue

God can help with that. Thank you

@Nick22nd @dietrich-stein @anaisbetts