Check DSM-5 Parent/Guardian

Checked with:
https://www.psychiatry.org/getmedia/1e799501-f718-4d06-817e-ce98e35c6bdd/APA-DSM5TR-Level1MeasureParentOrGuardianOfChildAge6To17.pdf

Valid:

Compare to the original in the UI:
https://www.repronim.org/reproschema-ui/#/activities/13?url=https%3A%2F%2Fraw.githubusercontent.com%2Fibevers%2Fdemo-protocol%2Fcheck-activities-before-and-after%2FDemoProtocol%2FDemoProtocol_schema_modified_and_original

Notes for reviewers:

The instructions come after the first question (relationship) on the instrument, so the instructions are an item, not a preamble in the schema.
There are two sections of questions with different scoring and preambles, so the preambles for each section are on every question to make sure it is clear.

New validation passes^^

Based on the pdf you provided, the whole questionnaire asks about the past 2 weeks, but there are some slight variations in the wording

During the past TWO (2) WEEKS, how much (or how often) has your child... this one works for everything from Q1 to Q19
In the past TWO (2) WEEKS, has your child ... this one works for everything from Q20 to Q23
In the past TWO (2) WEEKS, this one works for Q24 & Q25

@yibeichan I see what you mean. There are a few layers of ambiguity here.
For example, In the past TWO (2) WEEKS logically applies to both Q24 and Q25, but it is within the box for Q24, rather than its own box, in contrast to During the past TWO (2) WEEKS, how much (or how often) has your child... and In the past TWO (2) WEEKS, has your child ....
Considering that In the past TWO (2) WEEKS, has your child … comes before Q20 and is the last prompt in its own box, I would assume that it applies to Q20-Q25, if not for the use of the prompt in Q24.
Also, we don't see the use of all caps such as EVER in the text of any question besides Q25, but we do see it in all the prompts, indicating the language up until this word functions like a prompt in the document. It would also surprise me if the form creators only wanted to account for suicide attempts in the most recent two weeks of a child's life. The capitalization and this make me think that the question might be referring to the entirety of the child's life.
Rather than trying to interpret these ambiguities, we should try to maintain them in the ReproSchema version since a person taking the paper version of this questionnaire would also be faced with them.
Satra mentioned that is possible to use two schemas in one activity so that there can be separate preambles. I will update this accordingly, and then which preamble should go with which question item will be a non-issue.

thanks for the details!
based on the pdf link you sent, the overall instruction (on page 2) is

"Instructions (to the parent or guardian of child): The questions below ask about things that might have bothered your child. For each question, circle the number that best describes how much (or how often) your child has been bothered by each problem during the past TWO (2) WEEKS."

so it's okay to assume that all questions in this assessment have a time range—during the past TWO (2) WEEKS

@satra is it possible to render a two-schema activity in the UI as a single activity?

i can't remember if it was implemented. at the very least you can add both schemas to the protocol in sequence.

i can't remember if it was implemented. at the very least you can add both schemas to the protocol in sequence.

@satra done

Using "inputType": "radio" for hacking works well. the situation is that after the first question/item, the instruction comes up as the second question, and usually the UI needs some action (e.g., filling a question) to move to next one. so if we set it as static and there is no other button for us to click "next", we can't move to the next question

@yibeichan - yes, that hack works, but the ui should just be fixed for this. i'll send a PR in a bit if needed.

yes pls, we need to fix the UI :)

Fyi: after your commit, @satra, we are getting an error message in the UI:

example static schema: https://github.com/ReproNim/demo-protocol/blob/tst/static/activities/Activity1/items/static_item
hacked ui branch that works with static: https://github.com/ReproNim/reproschema-ui/tree/fix/static (committish: a2a85beb05e97b96ddd595935c2add5c01a494ff)

example static schema: https://github.com/ReproNim/demo-protocol/blob/tst/static/activities/Activity1/items/static_item hacked ui branch that works with static: https://github.com/ReproNim/reproschema-ui/tree/fix/static (committish: a2a85beb05e97b96ddd595935c2add5c01a494ff)

This isn't being served anywhere yet, is it?

it's supposed to be an item before this "upload Documents" (https://www.repronim.org/demo-protocol/#/activities/0), but it doesn't appear on the website

@ibevers and @yibeichan - i was assuming you knew how to set up a version of reproschema-ui from a specific committish - sorry that didn't hit your radar anywhere.
essentially in the github workflow for a protocol fork you should see a variable called committish. you can change that to point to any commit. that way you can serve any commit from technical any ui repo. (see the demo-protocol github workflow for deployment). similarly there is a place in the config.js to point to any schema. given both you should be able to adjust.

@satra
There is no committish variable in:
https://github.com/ibevers/demo-protocol/blob/check-activities-before-and-after/.github/workflows/build_deploy.yml
There is:
  CHECKSUM:  a2a85beb05e97b96ddd595935c2add5c01a494ff
and
        curl -O -sSL https://github.com/ReproNim/reproschema-ui/archive/${CHECKSUM}.zip
          unzip ${CHECKSUM}.zip
          mv reproschema* ui
          cd ui
          cp -r ../ui-changes/. .
          npm install
          npm run build
          touch dist/.nojekyll

I updated CHECKSUM to your commit, but when I try the UI, there is no observable change.


Yosegi-53 PrimitiveObjectContainer is not used anywhere.

What is the necessity of this update? What is updated?
We discussed in JIRA and got consent.
https://yosegi.atlassian.net/browse/YOSEGI-53
How did you do the test? (Not required for updating documents)

LGTM


[Proposal] Implement SVD Decomposition of OV Circuits, Win, Wout

Proposal
This post (https://www.lesswrong.com/posts/mkbGjzxD8d8XqKHzA/the-singular-value-decompositions-of-transformer-weight#The_consistency_check_prompt_was_) introduces some cool methods for identifying tokens associated with the SVD decomposition of OV circuit heads. It would be cool to implement something like this in transformerlens as a utility.
Motivation
Goes well with attention head detectors added recently. Cool results:

Pitch
Make it easier for people to notice semantic concepts being read from and added to the residual stream.
Alternatives
Lots of non-linear stuff happening in models too which we can't model. Would love something that measured that.
Additional context
Code example from post: https://colab.research.google.com/drive/1G5e5I6zEKZUkuV6DR3yZEhiCoWCTLQdh?usp=sharing
Checklist

[x] I have checked that there is no similar issue in the repo (required)

I am now working on this.

This was much more of a pain than I expected, because I kept running into numerical instability problems...but it turns out that's just how linear dependence works. A PR https://github.com/neelnanda-io/TransformerLens/pull/285 is now up for this. Thanks for the patience.


Improve the Transaction page

Describe the feature
I want to improve the transaction page of the website. As it's UI is not looking good. I can add more contents and elements to it.
Add ScreenShots

By adding this content , in transaction page.
Please assign me this issue under GSSOC'24.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Anushkabh Pls assign this issue to me.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.14.265",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=54abca038e287d3746dd40016514670a7f654c5c"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "54abca038e287d3746dd40016514670a7f654c5c",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.265 by commit 54abca038e287d3746dd40016514670a7f654c5c. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000111


user_profile: Pass correct element to toggle_submit_button.

We should disable the submit button of bot-edit-form after changes have been saved successfully.
This Pull Request fixes a minor typo.
Fixes: CZO
Screenshots and screen captures:
Before:
https://github.com/zulip/zulip/assets/126336384/55876102-288f-49a4-9a75-e148208dc1ef
After:
https://github.com/zulip/zulip/assets/126336384/d1e7837e-35f1-43ae-acf3-e786fb9154c0

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I have no clue why the puppeteer is failing!

I think it's unrelated to this work.  I encountered this kind of failing test a couple of times  and that usually takes care of it.

Merged, thanks @afeefuddin! We do need to figure out that test flake, though, since it does waste time.


💡 [Feature]: Allow to upgrade an app on a specified site collection using a action in the app catalog app list view

🎯 Aim of the feature
Currently we have a few actions available for each app in the app catalog list.
The idea/aim is to add a new action which under the hood will use CLI for Microsoft 365 command:

Upgrade - this will upgrade an app from the specified app catalog in the site. Under the hood it should use m365 spo app upgrade. When clicking on this action we should add prompt for siteUrl which is needed so that we will know to which site we should upgrade the selected app

Tips how to go about it, which should be done similar like already available actions

we should define it as a new app action like this https://github.com/pnp/vscode-viva/blob/59190115e0c676068a3f1a3698e31f3500aee3f6/src/constants/Commands.ts#L56-L62
we should add a new option for it visible in the menu under the app like this https://github.com/pnp/vscode-viva/blob/59190115e0c676068a3f1a3698e31f3500aee3f6/src/panels/CommandPanel.ts#L210-L216
we should handle this new action like this https://github.com/pnp/vscode-viva/blob/59190115e0c676068a3f1a3698e31f3500aee3f6/src/services/actions/CliActions.ts#L54-L56 and add logic for the new method like this https://github.com/pnp/vscode-viva/blob/59190115e0c676068a3f1a3698e31f3500aee3f6/src/services/actions/CliActions.ts#L182
The yes/no prompt may be done similar to this https://github.com/pnp/vscode-viva/blob/59190115e0c676068a3f1a3698e31f3500aee3f6/src/services/actions/CliActions.ts#L539C5-L545C69
we should also update the readme

📷 Images (if possible) with expected result
current state of actions for each app in the app catalog list

🤔 Additional remarks or comments
parent issue #324

Can I take it?

Can I take it?

All yours

PR merged. This will be live as a new pre-release soon.
Thank you once again for helping out in making the best SPFx tooling in the world 🚀


Enabled compilation with AFL instrumentation

Description of changes:
This PR enables AFL instrumentation during compilation. We will need to decide how to set up our CI infrastructure before we enable automatic fuzz testing with AFL, so right now this only allows for manual AFL runs. To run a fuzz test, compile S2N as normal but with the AFL_FUZZ environment variable set. Then in the fuzz test folder, run the following commands, replacing [test] with your target test executable:
mkdir tmpcorpus
LD_LIBRARY_PATH=../../lib:../testlib ../../test-deps/libfuzzer/afl-fuzz -i corpus/[test] -o tmpcorpus -m none ./[test]
AFL will then begin testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2196 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   80.75%   80.74%   -0.02%
==========================================
  Files         248      248
  Lines       18563    18563
==========================================
- Hits        14991    14989       -2
- Misses       3572     3574       +2


Remove unneeded PROTO.browsingContext.findElement

It has been superseded by script.evaluate + document.querySelector*
Replace those occurrences:

https://github.com/GoogleChromeLabs/chromium-bidi/search?q=findElement
https://github.com/GoogleChromeLabs/chromium-bidi/search?q=PROTO

One test is currently failing. Do you know how I can get access to the
 node element from a script.evaluate call? The main issue is that handle = result["result"]["handle"] doesn't exist when using script.evaluate (it used to with PROTO.browsercontext.findElement).
tperrotta@tperrotta-macbookpro ~/Projects/chromium-bidi/tests (git)-[thiagowfx/find-elements]
% python3 -m pytest -v test_script.py -k test_script_callFunctionWithNode_resultReceived
==================================== test session starts =====================================
platform darwin -- Python 3.9.6, pytest-6.1.2, py-1.11.0, pluggy-0.13.1 -- /Library/Developer/CommandLineTools/usr/bin/python3
cachedir: .pytest_cache
rootdir: /Users/tperrotta/Projects/chromium-bidi/tests
plugins: asyncio-0.14.0
collected 21 items / 20 deselected / 1 selected

test_script.py::test_script_callFunctionWithNode_resultReceived FAILED                 [100%]

========================================== FAILURES ==========================================
______________________ test_script_callFunctionWithNode_resultReceived _______________________

websocket = <websockets.client.WebSocketClientProtocol object at 0x1014af8b0>
context_id = '1036F9F9132562F77C8E649B49209191'

    @pytest.mark.asyncio
    async def test_script_callFunctionWithNode_resultReceived(websocket,
          context_id):
        # 1. Get element.
        # 2. Evaluate script on it.
        await goto_url(websocket, context_id,
                       "data:text/html,
test
")

        # 1. Get element.
        result = await execute_command(websocket, {
            "method": "script.evaluate",
            "params": {
                "expression": "document.querySelector('body > h2');",
                "target": {"context": context_id},
                "awaitPromise": True}})

>       handle = result["result"]["handle"]
E       KeyError: 'handle'

test_script.py:531: KeyError
================================== short test summary info ===================================
FAILED test_script.py::test_script_callFunctionWithNode_resultReceived - KeyError: 'handle'
============================== 1 failed, 20 deselected in 0.68s ==============================

Could you help me with the failing test? See comment above


💡 [REQUEST] - Make logo for blogweet site.

[x] I am from GSSoC'23.
[x] I would like to be assigned this task.

Section
Description

Concise Description
To make an logo for this website

Solution Proposed
The current is same as twitter, so make a professional logo

Alternative Solutions
To make a cover page or header image for website

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[x] I follow the Contributing Guidelines of this project.
[x] I have checked the current issues for duplicate problems.
[x] I have read the readme of this repository.

@AKD-01 I have created a pull request for this issue, please verify it, and merge it.


Material Box reloading not working

The following code works when i load the component for the first time. However when i navigate away and come back to the page, it stops working. Clicking the image does nothing. There are no errors in the console as well.
If i reload the page using the browser reload button it works again for the first time. Navigating through the application still causes the problem to occur.

If it matters im using angular-cli

@aaronfdes are you able to check if this is still happening with the latest version?
I tried reproducing, but it seems to work well.

I'll close this issue for now, but if you find that it's till a problem we can reopen.
Thanks.


Performance enhancements

Specifically to alpha_blend and convert_rgb_to_yuyv as per #138
This first draft addresses alpha_blend, reducing run time by a factor of 3-4x simply by separating the function and turning on full compiler optimisation for the machine that we are compiling on (-march=native). This may be a problem if compiling for a different target that doesn't have the same CPU features...

Could you please rebase onto experimental?

Could you please rebase onto experimental?

Odd, I thought this was based on current experimental, it looks like that to me?

Any updates here?

Please try to always rebase on the target branch instead of merging things …


Update node-termination-handler image version

Related issue #13

/assign @vishh @mindprince

Can you also update the Dockerfiles to build off of the new distroless base image? Otherwise a future image push might break your change.

Gentle ping.


Installation via composer doesnt seem to work

Running composer require gentor/olx-api-client results in this error:

[InvalidArgumentException]
Could not find package gentor/olx-api-client at any version for your minimu
m-stability (stable). Check the package spelling or your minimum-stability

Screenshot:

Composer version: 1.3.1
Edit: Cloning the project and running composer install works.

This issue can be resolved by setting the stability level to dev in composer.json:
...
  "minimum-stability": "dev",
  "prefer-stable": true,
...

It allows you to install any package you need (even dev-master), but also will prefer more stable packages over unstable ones.
$ composer require gentor/olx-api-client
Using version dev-master for gentor/olx-api-client
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 17 installs, 0 updates, 0 removals
  - Installing ralouphie/getallheaders (3.0.3): Downloading (100%)
  - Installing psr/http-message (1.0.1): Downloading (100%)
  - Installing guzzlehttp/psr7 (1.6.1): Downloading (100%)
  - Installing guzzlehttp/promises (v1.3.1): Downloading (100%)
  - Installing guzzlehttp/guzzle (6.3.3): Downloading (100%)
  - Installing gentor/olx-api-client (dev-master b68be8e): Cloning b68be8e110 from cache
Writing lock file
Generating autoload files

You can also fork the repo and use your own source instead:
...
  "repositories": [
    {
      "type" : "vcs",
      "url" :  "git@github.com:username/olx-api-client.git"
    }
  ],
...


Adjust n_conn to CONCURRENT_REQUESTS

Fixes https://github.com/scrapy-plugins/scrapy-zyte-api/issues/23
I thought about warning if a custom client is passed with an n_conn different than the one in CONCURRENT_REQUESTS, but since that could be done on purpose and providing a setting to silence that warning seemed overkill, I decided against it.
To do:

[x] Figure out the issue with the 2 failing tests.

Hi @Gallaecio ! Those are some productive improvements! 🎉 I think we can break them down into other PRs as they're out of scope for this PR. Aside from including this commit, +1 on merging this PR to master.

Looks awesome @Gallaecio!
For me the main question is ZYTE_API_KEY handling. Let's say a spider sets a certain ZYTE_API_KEY in settings.py. User wants to use env variable. Is it right that previously it was possible by setting the ZYTE_API_KEY to "", and now it requires setting it to None, which is not possible from the command line?

@kmike , commit https://github.com/scrapy-plugins/scrapy-zyte-api/commit/a255754c1cbd11cdf1cf026eeac026592f7dbb00 seems to be self-documenting enough. LGTM!

Let's say a spider sets a certain ZYTE_API_KEY in settings.py. User wants to use env variable. Is it right that previously it was possible by setting the ZYTE_API_KEY to "", and now it requires setting it to None, which is not possible from the command line?

Do we want to allow API keys to be empty strings?

If we do, setting the ZYTE_API_KEY setting to an empty string should make "" the API key. Maybe we can support a special string in settings that would translate to the key not being set, e.g. NONE or UNSET.
If we do not, then this may be worth handling upstream.

Do we want to allow API keys to be empty strings?

Ideally, yes. But I think that's fine if scrapy-zyte-api doesn't allow them.

If we do, setting the ZYTE_API_KEY setting to an empty string should make "" the API key. Maybe we can support a special string in settings that would translate to the key not being set, e.g. NONE or UNSET.

I'm not sure how to do it for scrapy-zyte-api, if only a string value can be set from cmdline (is it?). In this case, "UNSET" string doesn't look any better than "". If we're not talking about command line, None already works.
EIther way, it looks like a very minor edge case; I'm not against merging any of the implementations.
Testing failure looks like a large issue though, as it could mean tests become unstable; could you please check it?

Nice, thanks @Gallaecio!


Generate SQL migration files always start with create_

GIVEN Developer runs buffalo db g sql add_some_data
AND It completes
THEN the resulting migration files (up and down) are named something like [HASH]_create_add_some_data.sql
BUT it should be [HASH]_add_some_data.sql

Thanks @stanislas-m !


upgrade<EMAIL_ADDRESS>(breaking, changed default), and update csa S…

Changes
Upgrade svelte-hmr to 0.12 in plugin-svelte.
This is a breaking change for the plugin, because the names and defaults of some options have changed.
Namely, following this discussion, preservation of local state has been disabled by default. Similar confusion around preservation of whole local state have arisen multiple times already, so the behaviour has been deemed too confusing. It's better to have "just working" HMR.
Moreover, preservation of local state is not actually all that useful in real life scenarios. For the rare instances where you may want it, a magic // @hmr:keep comment has been added, that allows to preserve the state of variables individually, instead all the variables in the component. This is far easier to understand instinctively than the reverse.
I also hope people might notice that the counter kept running in demos / templates, and come back to them to find why when they need it. Whereas they won't know what to search for when they face the weird behaviours like the one in the discussion.
I have also updated the example Svelte component in the Svelte and Svelte TS create-snowpack-app templates to keep the counter running, and demonstrate the magic HMR comment. The indentation in the TS template was off for some reasons, so I fixed it.
Testing
For both Svelte and Svelte TS:

create an app with csa
install my local @snowpack/svelte-plugin
confirm that the counter is now reset on HMR updates
add the magic @hmr:keep comment
confirm that the counter's state is now preserved across updates

Docs
The goal of this change is in big part to make Svelte HMR a zero-options / no-docs-needed feature. I hesitated to add a note about // @hmr:keep, but I guess demonstrating it with the counter in the template is enough, and probably better.

Nice! I got the dependency updated in a separate cleanup commit, but I think I'm +1 on your reasoning to add this comment to the default CSA template. Will give it an extra day or two to think it over.

Okay, given this some time to think over. I'd actually like to keep the current template as-is, and not add the // @hmr:keep comment by default. Since we have so many templates to balance, our goal has been to keep each one simple and not get into too much functionality/complexity that we have to maintain across 10+ templates.
But, I do want to make this more obvious to a CSA user. Would you be interested in adding an "HMR + Fast Refresh" section to the https://www.npmjs.com/package/@snowpack/plugin-svelte readme? I think it can just be a brief couple of sentences explaining default behavior, but then we can use that to add a link to "learn more" which would help people find this documentation.

Well, sure, I'm happy to do as you see fit.
However I'm not entirely sure we're on the same page here. To be clear: beside changing the templates, this PR was enabling the new default behaviour by jumping the version of svelte-hmr from 0.11 to 0.12. This is considered a breaking change because default options have changed (and some have been renamed).
Old default (0.11) was to preserve the state of every local variable in a component.
New behaviour (0.12) is to not preserve any local state at all, except for variables marked with the magic // @hmr:keep comment.
This means something needs to be done in the Svelte plugin and/or the templates here. We have 3 options:

Override svelte-hmr's new defaults in Snowpack's Svelte plugin to keep the current behaviour.

Remove the counter in the template, because now it won't keep running across updates. Or at least change the text to something to the order of "x seconds since last update" (not the page being open).

Add the // @hmr:keep comment on the counter variable in the template, to keep both the new, more predictable, behaviour, and the counter running.

Option 3 is essentially what this PR is doing.
I'd be very wary of option 1, not aligning with svelte-hmr's new defaults, because preserving all local variables has proven times and again to confuse people. I don't think any docs can fix that -- I believe HMR that requires explanation will mostly be perceived as broken.
Furthermore, even if it makes for flashy demos, I believe preservation of local state is actually mostly irrelevant in real life. What people really want from HMR is speed, and they'll always get better than a full reload. For the remaining edge cases, for people who don't know, I prefer limiting functionalities than risking to harm predictability / confidence in HMR. HMR failures (perceived or real) are a big deal, because they're rarely identified as such immediately, so they can be a big source of frustration when people realize it after messing their code and searching the Internet for hours...


Preserve user's current DPI setting to be applied when disabling activated profile

Hi! Great app, thank you
I use my phone with the setting in Settings -> Display -> Screen Zoom set to minimum. After enabling a SecondScreen profile, and then disabling the profile, this setting is re-set to a default value. I would like my custom setting to be remembered while I use SecondScreen, and restored when I stop, would that be possible?
SecondScreen 2.9.2
Device: Samsung Galaxy S10e, Android 11, OneUI 3.1

I have this issue too. I actually use the default setting, but my phone treats DPI numbers differently. In fact, in my case, it would work wonders if I could simply tell the app NOT to touch the DPI settings and change only resolution (and notch settings, as described in the other issue)


merge develop into master - to publish latest updates

Types of Changes
Prerequisites
Please make sure you can check the following two boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project

Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[ ] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Description
[Place a meaningful description here.]

obsolete due to another PR with correct version number


[BUG] Community creation with status code 400

Describe the bug
When I try to create an community using the appropriated IQ request, it's returning 400 instead of the created community info.
To Reproduce
Steps to reproduce the behavior:

Created a new connection
Closed & used saved credentials to log back in
Copy and paste this code right under "groupCreate"

communityCreate: async (subject: string) => {
  const result = await<EMAIL_ADDRESS>"set", [
    {
      tag: "create",
      attrs: {
        subject,
      },
      content: [
        {
          tag: "description",
          attrs: {
            id: generateMessageTag(),
          },
          content: [
            {
              tag: "body",
              attrs: {},
              content: Buffer.from("The community description", "utf-8"),
            },
          ],
        },
        {
          tag: "parent",
          attrs: {
            default_membership_approval_mode: "request_required",
          },
        },
      ],
    },
  ]);

  console.log(result);

  // return extractGroupMetadata(result)
};

Then inside the "example.ts",  make an request to WA servers using:

const createCommunitResponse = await sock.communityCreate('Community name')

console.log('DEBUG:', createCommunitResponse)

Expected behavior
This code should result into a creation of the community with its respective informations about it. Link, annoucement group Id and more. just like in the example below:
<notification<EMAIL_ADDRESS>type="w:gp2" id="PPPPPPPPP"
<EMAIL_ADDRESS>addressing_mode="pn" notify="Guilherme ي"
    t="TTTTTTTT">
    <create type="new">
        <group subject="V"<EMAIL_ADDRESS><EMAIL_ADDRESS>            id="XXXXXXXXXXXXXXXXXX" creation="YYYYYYYY" s_t="YYYYYYYY" size="1"
            p_v_id="JJJJJJJJJJJJJJJ" a_v_id="JJJJJJJJJJJJJJJ">
            <participant<EMAIL_ADDRESS>type="superadmin" />
            <description<EMAIL_ADDRESS>id="AAAA.AAAAA-AAA"
                t="YYYYYYYY">
                <body>"N"</body>
            </description>
            <parent default_membership_approval_mode="request_required" />
            <member_add_mode>"admin_add"</member_add_mode>
        </group>
    </create>
</notification>

Environment (please complete the following information):

Is this on a server? No. its on my own machine
What do your connectOptions look like?

{
   	// version,
   	logger,
   	printQRInTerminal: true,
   	mobile: useMobile,
   	auth: {
   		creds: state.creds,
   		/** caching makes the store faster to send/recv messages */
   		keys: makeCacheableSignalKeyStore(state.keys, logger),
   	},
   	msgRetryCounterCache,
   	generateHighQualityLinkPreview: true,
   	// ignore all broadcast messages -- to receive the same
   	// comment the line below out
   	// shouldIgnoreJid: jid => isJidBroadcast(jid),
   	// implement to handle retries & poll updates
   	getMessage,
   }

Do you have multiple clients on the same IP? Yes. If my own devices count
Are you using a proxy? No

Additional context
Thanks for reading until here :)

Hi dude! #255 seems to already talk about communities, can you please post your findings there? This is valuable info :D

Any updates about this?
I'm looking forward for community resources in baileys!!!

Any updates about this?
I'm still looking forward for community resources in baileys!!!


Create a new github release

Could you create a new github release so that #29 is included? I'd like to update my docker image.

Done. Version 0.21.2


Install instructions

Love the theme for VS code and want to install it. Do you have any details on how to get it installed? Great work!

Hey @SrWildman! If you just go to https://marketplace.visualstudio.com/items?itemName=MattGleich.theme-blackbird and click the green install button it should open it in vscode and install it. Hopefully, this helps! I'll add some clearer instructions soon.

Thank you!


Refactor internal subcommand API for build tool

Added:

Project struct keeps track of project data and checks file/folder structure for validity
Features struct enables/disables engine features
More doc comments and annotations

Changed:

Replaced cargo::call functions with a cleaner and more Rust-like Cargo struct
match used for execution instead of macros
Updated to clap 2.9 API
Moved useful code out of CLI tool and into shared library (issue #34)

Fixed:

amethyst deploy now works from any project sub-directory
Errors and warnings print now to stderr (issue #30)

Removed:

Removed AmethystCmd and AmethystArgs
Superseded is_amethyst_project() with Project struct
Superseded AmethystModules with Features struct
Removed unused "module.rs" stub

This pull request is not yet complete. The following tasks still remain:

[ ] Eliminate generic Error type
[ ] Move all TOML parsing to src/cargo/manifest.rs
[ ] Write config parsing code in src/config.rs
[ ] Write project validator in src/valid.rs, possibly merge with Project
[ ] Finish writing remaining project commands, possibly merge with Project
[ ] Hook up everything to build tool

For god sake, don't call cargo with a string.

@White-Oak Whoa, calm down there. :smile: Could you please elaborate on your reservations? I'm happy to revert the change if it's not liked.

@ebkalderon well, I thought about it over the time and concluded it's just personal preference.
At first, I was going to say - hey, how are you gonna add different parameters (like different flags) to string, but later understood that its still possible, just a bit harder, than directly pushing to vec.

I guess I should explain myself a little. The reason why I went with a string was because the addition of extra parameters was rarely done (so far, we only tack on a --release or a path value to the end). Taking in a single string looked somewhat "cleaner" to me than building a vector of strings, but I'm perfectly fine with reverting back to the old approach if it's not cool. I hope there are no objections with the other changes made?

@ebkalderon other changes are really cool

@amethyst/tools-devs Requesting comments and feedback on the TODO's I left in features.rs.

@ebkalderon as an alternative you can have two functions for both string argument and vec args.

@White-Oak I was literally just thinking that!

@amethyst/tools-devs I think this is just about ready to merge. I would still like feedback on the TODO's in features.rs before we move any further. As always, please let me know if anything else sticks out as wrong to you.

@LucioFranco I personally don't see a need to route real errors, they are quite uninformative, and in tool, it's better to fail-fast anyway.

@White-Oak I disagree. When you are using a tool that modifies the filesystem you want the errors to be as informative as possible. Just saying Couldn't open Cargo.toml the io error would say You do not have permission which is more helpful. The point of the CmdError enum is to have all the errors route back down the chain and then in the fmt::Display impl have nice error messages.

I think the ci test has to be rerun. Also, why is this PR not merged yet? It's been months since the last commit.

Closing, as we're taking the CLI in a very different direction now.


Support direct generation of grpc method

Support direct generation of grpc method when the package and service names of proto files are different.
The 'method' generated by protoc-gen-micro does not contain 'package', when the proto file contains a package declaration. When the package and service names of proto files are different, and use service discovery, the correct method cannot be accessed.

proto example:
`syntax = "proto3";
option go_package="/hello";
package HelloA;

service HelloA{
....
}`

But the registered service name is Hello.

Use the following way,  the corresponding method cannot be accessed
client := NewHelloAService("Hello", service.Client())

Because the package name is not included when the method is called in the generated proxy.
req := c.c.NewRequest(c.name, "HelloA.XXX", in)
protoc-gen-go-grpc handles this case correctly, so I think support for this should be added.
The code generated by protoc-gen-go-grpc is:
err := c.cc.Invoke(ctx, "/HelloA.HelloA/XXX", in, out, opts...)
After modification, we can:
protoc --go_out=. --micro_out=. --micro_opt=use_grpc=1 xxx.proto
Set the parameter 'use_grpc', regardless of the value, the package name will be added when the method is generated.

closes #2476

@xpunch I have rollbacked two unrelated commits.

@xpunch I have rollbacked two unrelated commits.

You don't need to revert your commits, I would have approved your PR.
Closes #XXX means it'll close target issue once PR was merged.

@xpunch I have rollbacked two unrelated commits.

You don't need to revert your commits, I would have approved your PR. Closes #XXX means it'll close target issue once PR was merged.

Sorry, i will resubmit them.


Support uuid for distributed primary key.

What would you like to be added:
Why is this needed:
Support uuid for distributed primary key.

https://github.com/arana-db/arana/issues/94


DotNetCoreCLIV2 - Custom command, path needs to be absolute

Im having issues with the passing the path of the .dll that i want to run.
based on my testing the only way i can get the dotnet to run is to pass the complete full path of the .dll or dotnet cannot find the file.
is there a work around for this as i dont want full path names in my pipelines.

@kiwidave72 Can you elaborate on your scenario ? Suggested way to run dotnet application is to use dotNetCore task with command build, followed by run command where you can pass path/pattern to your csproj. If you are directly trying to run an existing application dll without any build process then you need to provide absolute path to the dll like dotnet <path_to_dll>

We have a similar issue since version 2.158.0 (shown in header of tasks) with the tests. Before, the parameter "-s" for "dotnet test" points to the solution folder and no longer to the folder where the csproj is located at. With version 2.156.2 it was working.

@kiwidave72 Can you elaborate on your scenario ? Suggested way to run dotnet application is to use dotNetCore task with command build, followed by run command where you can pass path/pattern to your csproj. If you are directly trying to run an existing application dll without any build process then you need to provide absolute path to the dll like dotnet <path_to_dll>

I have a .net 3.0 core console app that i use in the pipeline.
my "Custom command" is something like the following:
C:\Users\buildagentadmin\agent_work\r1\a_Pipeline\Tools\ProductHelper\AzureFileSync.Console\bin\Release\netcoreapp2.1\AzureFileSync.Console.dll
And when i try using variables from the pipeline 'dotnet' errors and cant find the dll.

@kiwidave72 You can use pipeline variables in your custom command. Example: $(System.DefaultWorkingDirectory)<artifact alias><path to dll>. Can you please share the logs for the instance when you tried to use pipeline variables ?

@hbunjes Can you share the debug logs for both successful and failed scenarios ?

Hi @hbunjes , can you shared the logs as asked earlier?

@kiwidave72 @hbunjes
If you are still facing this scenario, feel free to reopen this issue item along with debug logs. To generate debug logs, set this variable "system.debug: true" before executing your pipeline.


Update directory structure so that we use a /src folder

We don't want all our stuff to be at the root level of the project. This change also allows us to use absolute paths for modules in webpack.
Ex:
import { something } from '../../config';
// becomes
import { something } from 'config';

I've already refactored everything to use absolute paths except components since it is sort of tricky to do with a regex. But going forward, we can start using
import { MyComponent } from 'components/MyComponent';
// instead of
import { MyComponents } from '../../MyComponent';

Reviewer: @howardchung
Please try to get this merged before we do other PR's because it's a massive pain in the ass to merge


Doctrine repeatly alters geography-type field

Having configured the bundle:
doctrine:
    dbal:
        types:
            geometry:   CrEOF\Spatial\DBAL\Types\GeometryType
            geography:   CrEOF\Spatial\DBAL\Types\GeographyType

in entity class I defined a field:
    /**
     * @ORM\Column(type="geography", nullable=true)
     */
    protected $geomshape;

then executed bin/console doctrine:generate:entities... and bin/console doctrine:schema:update.
Now in the Postgres DB I have a new geomshape field of geography type but it's comment is DC2Type:geometry.
Problem is that on the next time I use bin/console doctrine:schema:update it wants to alter geomshape field to type Geography again:
ALTER TABLE geo_objects ALTER geomshape TYPE Geography;

And again, every time I use d:s:u. Is this my fault (perhaps misconfiguration) or a bug?

Probably the same as jsor/doctrine-postgis#31

Nope, I tried to use @jsor 's solution with commented: false but to no avail. Then I deleted the field and allowed Doctrine to create it again. Now, the comment was correctly (DC2Type:geography). Then I commented out that commented: false and deleted and created field. Again, the comment was correct. Anyway, once correctly created, the Doctrine doesn't want to alter it again. Solved
Then I remembered that last week I changed the type of this field from geometry to geography. Turns out that Doctrine didn't update the comment. I don't know if it is something on this bundle or Doctrine's side. If you think it is on Doctrine side, please close this issue.


Give some memory to sequential chains

Pulled out of #1240
Working with memory a little bit, it's extremely helpful to attach memory to a sequential chain to pass along unchanging data.  The use case I found was passing along the original text to use as context in each prompt when doing rewrites of text.
It's a lot easier to have a central data store than having to pass along each value as input/output.

I found some more issues with input variable validation on the prompt and
llm that I need to address, should have something soon.
On Mon, Feb 27, 2023 at 10:03 PM Harrison Chase @.***>
wrote:

@.**** commented on this pull request.
nice i like this a lot - very down to get this in. do you want to mark it
ready for review or is there something else you wanted to add?
—
Reply to this email directly, view it on GitHub
https://github.com/hwchase17/langchain/pull/1293#pullrequestreview-1316851616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFMY42WMBD5CF3CQZHNY23WZWIKFANCNFSM6AAAAAAVH7WNMM
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
-Tim

@hwchase17 fixed things up, and added some tests and documentation.    Let me know what you think.

@hwchase17 fixed things up, and added some tests and documentation. Let me know what you think.

am a bit confused why the optional typing is needed, may pull it into a branch and play around with it

@hwchase17 fixed things up, and added some tests and documentation. Let me know what you think.

am a bit confused why the optional typing is needed, may pull it into a branch and play around with it

Otherwise i'd need to pass along an empty dict to return everything, which felt weird to me.  load_memory_variables({}) vs load_memory_variables().


Update Fedora instructions

@jmmv also would be nice if you could do fedpkg retire for kyua-cli and kyua-testers.

W00t! Somebody (you?) packaged repackaged Kyua as a new RPM? Thanks! I opened a bug a long time ago with a preliminary spec but never got a responsive reviewer for it :-(

@jmmv I will add you as admins ;) and don't hesitate to improve it ;)

Done. https://src.fedoraproject.org/rpms/kyua

@googlebot rescan
(Mass-triggering a rescan of all open PRs as I have just configured automated CLA checks but the bot won't go through the backlog on its own.)

@jmmv why do you need CLA? :/

@jmmv why do you need CLA? :/

This is a Google sponsored project, so one needs to sign the Google CLA in order to contribute to it.


Transactions between end date

In models.py, in transactions.between line 450 produces an error: 'Transaction' object has no attribute 'end'. Should that say t.date?

@joplju Thanks, for report, fixed in https://github.com/aldanor/pynab/commit/ccfbb8dc2f562439317e57f93712635b3fd71f5e


Allow creating/applying ruletypes from standard input

Summary
We had added that ability in the initial implementation, but had lost it
once we started skipping files more thoroughly. This recovers that.
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 54.762% (+0.007%) from 54.755%
when pulling 5fb8a5390cecd8a54fcbf0309c8051beef3b72a6 on JAORMX:stdin-ruletype
into c1c035843362bdff1ea1eb7b4d7e63542186a159 on mindersec:main.


Reflecting a class with call() throws in dart2js

Problem:
In dart2js the following throws. This is only an issue with Dart 1.22.0 and works fine in Dart 1.21.1.
Code:
import 'dart:mirrors';

void main() {
  InstanceMirror mirror = reflect(new A());

  mirror.type;
}

class A {
  call() {
    return null;
  }
}

Error:
Uncaught Error: Unsupported operation: Cannot find class for: () => dynamic
    at Object.wrapException (index.dart.js:6266)
    at Object.reflectClassByName (index.dart.js:9814)
    at Object.reflectClassByMangledName (index.dart.js:9789)
    at Object.reflectType (index.dart.js:9778)
    at JsInstanceMirror.dart.JsInstanceMirror.get$type (index.dart.js:10774)
    at StaticClosure.dart.main (index.dart.js:39025)
    at _IsolateContext.eval$1 (index.dart.js:4833)
    at Object.startRootIsolate (index.dart.js:4431)
    at index.dart.js:41128
    at index.dart.js:41129

@johnniwinther  - could this be a regression in some of the recent refactoring changes in the closed world builder?

Bisected:
fdbc6688f1c61a725cad019c98f543db773d01ae is the first bad commit
commit fdbc6688f1c61a725cad019c98f543db773d01ae
Author: Stephen Adams<EMAIL_ADDRESS>Date:   Wed Jan 18 17:41:48 2017 -0800

    dart2js: Make .runtimeType work for tear-off closures

    BUG=
<EMAIL_ADDRESS>
    Review-Url: https://codereview.chromium.org/2639733004 .

Passing on the torch @rakudrama

Fixed by https://github.com/dart-lang/sdk/commit/fc56b59a88d963475af5db1b3fefad3bf6de07ea


Travis-CI builds failure due to Go version.

Go version 1.11 and 1.12 are not supported now.

this PR is to merge into master. skipping this one.


Help wanted

Are you requesting a feature, reporting a bug or ask a question?
Hi.I need some help with your js. Can i some how hide previous and next button, and show next when user click on answer?How i can send results to email address?And can someone help with сreating a countdown from 5000 with step -50 till last question will be answered?Thanks alot.

@N73dp Here is the example with custom navigation, you can have your own navigation. You may need to write code survey.onValueChanged event to show/hide your "Next button".
The second answer is out of the scope our expertise: https://stackoverflow.com/search?q=send+e-mail+in+JavaScript
I do not understand about the last question. Are you talking about this functionality: https://surveyjs.io/Documentation/Library/?id=SurveyModel#maxTimeToFinish
Thank you,
Andrew

In last question i want create a counter that will stop when user answer last question(without time,just an example we have number 5000 and when user start survey counter start subtract 50points per second).
So there is no way to send answers of user to administrator email?Thanks for responding.
And another one question, image-picker work on localhost but not work on hosting. What problem this can be?
http://lp.farm-dok.com/


No logs for a new block

Issue Type

[x] bug report
[ ] feature request

Current Behavior

Sometimes the RPC endpoint at https://mainnet.boba.network returns no logs for block that actually has logs.
For example, for block 716730 we have these logs:
https://blockexplorer.boba.network/tx/0x7275eaae0d3e607b58b4407c4941a6708c14c277f229c3443d66f0705ac5cb5a/logs
however, when making a call to get_logs, the returned list of logs is empty.
We're using Python and web3py and the call to get_logs specifies the starting block, the end block and the address
to filter by.
Expected Behavior

The call to get_logs should return all the logs.
Steps to Reproduce

Poll https://mainnet.boba.network regularly (e.g. every 2s) for new blocks.
As soon as the new block arrives, call get_logs.
Observe the empty result, even though the block has logs. Note: a couple of tries might be needed before hitting this behaviour.

Suggested Fix

This could be a problem with the RPC announcing the new block before the block data and logs are ready.

Hi @istankovic , we will improve our replica nodes' performance in our next maintenance window. We have the proxyd in front of our replica and sequencer nodes. The eth_getLogs is routed to the replica nodes and eth_blockNumber is routed to the sequencer node. The replica node takes about 1 second to sync up the up coming the block data now.

Hi @istankovic , we have reduced the latency. We recommend you to use https://replica.boba.network to query and index events. Another thing you can do is to submit transactions through https://replica.boba.network. Once you receive the response, you should be able to query events on https://replica.boba.network.

@istankovic BTW, the replica endpoint for Rinkeby is https://replica.rinkeby.boba.network. We wrote a script you for testing purpose:
const ethers = require('ethers');

const L2_NODE_WEB3_URL = 'https://replica.rinkeby.boba.network';

const main = async() => {

  const pk = "Private Key";

  const L2Web3 = new ethers.providers.JsonRpcProvider(L2_NODE_WEB3_URL);
  const L2Wallet = new ethers.Wallet(pk).connect(L2Web3);

  const L2BOBA = new ethers.Contract(
    '0xF5B97a4860c1D81A1e915C40EcCB5E4a5E6b8309',
    new ethers.utils.Interface(['function transfer(address,uint256)']),
    L2Wallet
  )

  const tx = await L2BOBA.transfer(L2Wallet.address, ethers.utils.parseEther('0.1'))
  const receipt = await tx.wait()

  console.log(await L2Web3.getLogs(
    '0xF5B97a4860c1D81A1e915C40EcCB5E4a5E6b8309',
    receipt.blockNumber,
    receipt.blockNumber,
  ))
}

main()

@Boyuan-Chen Thanks for the help! https://replica.rinkeby.boba.network seems to be working well.


Use Prometheus 2.35.0

Codecov Report

Merging #231 (d333de3) into main (e151355) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   95.87%   95.87%
=======================================
  Files          66       66
  Lines        4753     4753
=======================================
  Hits         4557     4557
  Misses        150      150
  Partials       46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e151355...d333de3. Read the comment docs.


Add Bencher to track benchmarks in CI

@epage thank you for the mention earlier this week. I wanted to follow up as a lot of progress has been made since we last spoke. Bencher can now create all dimensions on-the-fly, so there is no more need to make them in advance. Further, you can now configure everything, including setting thresholds using the CLI. This should make it possible to use the same template across repos. The only thing to parameterize is the project slug.
Are you still using Divan as your benchmarking harness? @nvzqz mentioned back in June that the JSON output should be coming "soon".
Bencher now also supports tracking compile times and tracking binary size, if either of those are also of interest.

Glad to hear!
Looking over the steps, it sounds like there is still another per-repository step:

Make sure you have created an API token and set it as a Repository secret named BENCHER_API_TOKEN before continuing on! Navigate to Your Repo -> Settings -> Secrets and variables -> Actions -> New repository secret. Name the secret BENCHER_API_TOKEN and set the secret value to your API token.

So I'll still need to deploy a secret to all of my repos or (more ideally) manage a secret per repository, right?

So I'll still need to deploy a secret to all of my repos or (more ideally) manage a secret per repository, right?

Yes, good catch. You will need to set the BENCHER_API_TOKEN. Currently, the API tokens are tied to the user, so the same token should work across all projects that you create. There are plans to add project scoped API tokens in the future: https://github.com/bencherdev/bencher/issues/262

Do you have hyperfine support?

Yep! Check out the shell_hyperfine adapter docs.

I wonder if I could switch projects like https://github.com/rosetta-rs/argparse-rosetta-rs over to this?

You definitely could. However, I will note that bake-off/head-to-head comparisons isn't a use case that I have spent much time optimizing Bencher for. I'll have to add your repo to my benchmark comparison prior art list.

Thanks for the help!
While not a fan of manually managing all of this (having an "app" take care of a lot of this is a big help), I'm giving this a try.
As I work off of a single template, I tried to generalize as much as I could.  I'm seeing a --project flag but no --organization.  I was hoping I could use "${{ github.repository }}" for this but it fails

https://github.com/clap-rs/clap/blob/master/.github/workflows/bench-baseline.yml#L39
https://github.com/clap-rs/clap/actions/runs/11805441897/job/32887903228

Ah, yeah "${{ github.repository }}" fails because the value that is expected there is the project slug or UUID.
My thought was to define a configuration variable for each project.
So your template could stay the same: "${{ vars.BENCHER_PROJECT }}"
And you just plug in the right slug for each project on the backend. Similar to how BENCHER_API_TOKEN is handled, but no need for the project slug to be a secret.

For a given project slug, how does it know what organization that project is in?
Also, per repo settings are a borderline dealbreaker. I'm trying this out for now but I don't think I want to set 30 tokens to get this to work, let alone other variables.

For a given project slug, how does it know what organization that project is in?

Bencher projects are not namespaced. That is their slugs are globally unique.
Note that there can be multiple projects with the same display name, but they will have different slugs.

Also, per repo settings are a borderline dealbreaker. I'm trying this out for now but I don't think I want to set 30 tokens to get this to work, let alone other variables

I appreciate the candid feedback on this point. So far, most users have only had a handful of repos they're integrating with. I can definitely see how the current setup doesn't scale well across dozens of repos.

 Bencher projects are not namespaced. That is their slugs are globally unique.

Note that there can be multiple projects with the same display name, but they will have different slugs.
So what is an "organization"?  And what if I have ambiguous repo names across github organizations?

So what is an "organization"?

An Organization is really just a collection of Projects, similar to GitHub. Currently, the permissions for collaborators are only available at the Organization level. As a user, you can create as many organizations as you like.
Unlike GitHub, all Bencher Organizations are private. You have to have view permissions to see any details.

And what if I have ambiguous repo names across github organizations?

Do you mean what if you have two repos named foo, one under namespace one and the second under namespace two?
What you do here is up to you.
A couple of options:

Name them one/foo and two/foo
with the slugs one-foo and two-foo.
Name the both foo
with the slugs one-foo and two-foo.

If you create a project named foo, and a Project with the slug foo already exists, then, Bencher just slaps a random suffix on the end to make it unique, foo-abcd1234. You can always change the slug for a Project (or any resource for that matter). If you use the API directly you can include a preferred slug in the call to try and avoid such a collision.


The scrolls are not visible enought in default

Can be scroll highlighted when focused are for click/move? Like on image?
I tied many themes but in any of this I have problem to quick find scroll and wate time for this with some confusion.
1 Left is as now, 2 the right proposition, 3 sugested, 4 experiment.
The highlith can be related with statusbar color - eg. in black is blue, so hihgl. is blue.

BTW I think that the "elements" on the right sides should be related with the level of the outline colours and positions, eg. clases, functions, some vars. This can build some view of file based on colours that is more cognitive that this what is now on my img.

Need scroll btn use for tabs card to switch betwen left/right.

Need reapir this in current VSC, cos when exist many tabs then sroll is actvie but blocking click tab. Soo.. the scroll should be uper tabs not under tabs, or sroll for tabs can have option to turn off (scrolling by mouse scroll is enough - not need widget maybe).

@ManPython All the colors applied to the slider are customizable, e.g.:
"workbench.colorCustomizations": {
	"scrollbarSlider.background": "#ff0000"
},

@alexdima thats is some solution but..

Scroll covering tabs

the scroll vertical should be upper tabs or turned off as option

On tabs is highlighted for blue when mouse is focused, on vertical is blue when moving, and focued gray. Thats disonanse little.

There is next disonanse with high upper level of scroll as I discover due that breadcrumbs hide layer when is IDE doc in down

when line is # 4 not # 1 we see "layer" under breadcrumbs (IMHO should be constant visible)

@ManPython
There are multiple colors for the slider. Please use ctrl+space to discover them in settings.json or read about them in our documentation page at https://code.visualstudio.com/api/references/theme-color#scrollbar-control
e.g.
	"workbench.colorCustomizations": {
		"scrollbarSlider.background": "#ff000088",
		"scrollbarSlider.activeBackground": "#00ff0088",
		"scrollbarSlider.hoverBackground": "#0000ff88",
	},

Please edit these colors as you desire. If you don't like the blue, then please choose another color. If you find it is too transparent, then please increase its alpha channel.


Support Svelte's $$Generic type

I'm not sure if this is a bug or a feature but I think svelte-eslint-parser doesn't support Svelte's $$Generic type to type component properties.

Relevant information is probably this: https://github.com/sveltejs/eslint-plugin-svelte3/issues/127

Thank you for posting issue.
The RFC about $$Generic don't seem to have been merged yet.
sveltejs/rfcs#38
I don't want to fully support it yet to avoid a lot of breaking changes.
If you want to support it, we can add it as an experimental feature.
--
Related to https://github.com/ota-meshi/eslint-plugin-svelte/issues/390

I see, so it is on the radar somehow but needs some deeper digging. Thanks a bunch.
Feel free to close this issue or keep it open to keep track of $$Generic.
For anyone stumbling across this: for now I simply workaround by defining $$Generic globally in my eslintrc:
...
        env: {
                ...
        },
        globals: {
		$$Generic: 'readonly'
	},
...

@ota-meshi I'm exploring an alternative syntax for this currently, which would look like this:
<script lang="ts" generics="T, X extends string">
  export let items: T[];
  export let key: X;
</script>

From an implementation-perspective, how hard would it be for svelte-eslint-parser to support this syntax?
(I'm not saying it's decided that we switch to this syntax yet, but I want to have as much feedback as possible before making the decision)

Thank you for letting me know.
Vue team is also exploring generic attribute, so I'm looking into how to support it with the vue-eslint-parser.
(I'm the maintainer of eslint-plugin-vue and vue-eslint-parser.)
The current idea is to insert virtual code like this:
type T = unknown;
type X = string;

In TypeScript, this might generate the wrong type like the following example code, but I anticipate no problem within the scope of the checks used in typescript-eslint.
<script lang="ts" generics="T extends string | number">
  let val: T = 42 // It's a type error in TypeScript.
</script>

↓ Virtual code
type T = string | number
let val: T = 42 // It's not an error. Also, `val` is inferred to be of type number.

@ota-meshi I'm exploring an alternative syntax for this currently, which would look like this:
<script lang="ts" generics="T, X extends string">
  export let items: T[];
  export let key: X;
</script>

From an implementation-perspective, how hard would it be for svelte-eslint-parser to support this syntax?
(I'm not saying it's decided that we switch to this syntax yet, but I want to have as much feedback as possible before making the decision)

It would be nice to keep the $$Generic in inside the script. If you have a lot of generics you can't just write them on one line.
And can you keep the types interactive and highlighted as a generics property?

Why is this not supported?
The now obsolete eslint-plugin-svelte3 had this added a year and 8 months ago.
Defining $$Generic globally in eslintrc gets rid of the undefined error but causes problems later on because it is assigned an "any" type, leading to no-unsafe-member-access errors later on when trying to use the type defined by $$Generic

It's not supported yet because it's still experimental, which is a valid choice.

Would love to update to Svelte 4, but the deprecated eslint-plugin-svelte3 doesn't support it. Was I unknowingly using an experimental feature, or is it just not supported anymore? Are there any plans for when to address it?

@probablykasper Switch to eslint-plugin-svelte.

@theodorejb I would love to, but it sounds like $$Generic is unsupported, without any workaround

Would you be open to a PR to add support for the feature, even if it's still just an RFC? If you are focused on other tasks, which I of course understand, I'd try to look into what I can do to help the feature along. We're using generics in multiple production apps and having this break with the upgrade to svelte-4 is a step back for our project setup...

I think we can add support for Generics to svelte-eslint-parser as an experimental feature. Please consider submitting a PR. However, please allow it to be opted in using something like parserOptions.
However, $$Generic seems to have been discarded from the RFC, so we won't be adding support for it in the future.

It's pretty bad dev experience when the official docs say to use these features but then linting fails out of the box when using these features...

It's pretty bad dev experience when the official docs say to use these features but then linting fails out of the box when using these features...

Yes... I'm looking into writing a PR to add support for it, but I haven't gotten around to it yet since I'm not yet familiar with developing eslint-plugin related things^^

Yeah also ran into this issue. I thought I was doing something wrong but apparently not

Temporary workaround for those people who's T is unknown/generic
// TODO: REMOVE WHEN https://github.com/sveltejs/svelte-eslint-parser/issues/306 IS FIXED
// eslint-disable-next-line no-undef, @typescript-eslint/no-explicit-any
type X = T | any

export let options = X[]

This will get the errors to disappear

@Rich-Harris  will this be fixed in Svelte 5?

$$Generic is deprecated in favor of the generics attribute, which should be supported in this parser at some point. For more info see https://github.com/sveltejs/svelte-eslint-parser/issues/306#issuecomment-1486604484

I see. Is there any issues that need resolving that perhaps I could help work on?

I'll defer to @ota-meshi and @baseballyama for this question

I think if someone works on this implementation, it can be added as an experimental feature.
https://github.com/sveltejs/svelte-eslint-parser/issues/306#issuecomment-1704455018


Autocompletion doesn't work in nvim

Description
I'm using  neovim last version from pacman
Also downloaded ruby package.
Thus,  ruby-lsp last version from  gem
Then added to my config:
lspconfig.ruby_ls.setup({})

My steps next:

Open ruby file with nvim
My LSP-server starts
Do some texting
The completion window just doesn't appear except to require options

Here is a demo:
https://github.com/Shopify/ruby-lsp/assets/60037254/9699f0a1-0996-489f-b157-70c05a0a41f8
Here is LspLog:
[ERROR][2024-03-26 22:54:28] .../vim/lsp/rpc.lua:734	"rpc"	"/home/cheese/.local/share/gem/ruby/3.0.0/bin/ruby-lsp"	"stderr"	"Ruby LSP> Skipping custom bundle setup since /home/cheese/Projects/Ruby/.ruby-lsp/Gemfile.lock already exists and is up to date\n"
[ERROR][2024-03-26 22:54:28] .../vim/lsp/rpc.lua:734	"rpc"	"/home/cheese/.local/share/gem/ruby/3.0.0/bin/ruby-lsp"	"stderr"	"Ruby LSP> Running bundle install for the custom bundle. This may take a while...\nRuby LSP> Command: (bundle check || bundle install) 1>&2\n"
[ERROR][2024-03-26 22:54:28] .../vim/lsp/rpc.lua:734	"rpc"	"/home/cheese/.local/share/gem/ruby/3.0.0/bin/ruby-lsp"	"stderr"	"The Gemfile's dependencies are satisfied\n"
[ERROR][2024-03-26 22:54:28] .../vim/lsp/rpc.lua:734	"rpc"	"/home/cheese/.local/share/gem/ruby/3.0.0/bin/ruby-lsp"	"stderr"	"Starting Ruby LSP v0.14.6...\n"
[ERROR][2024-03-26 22:54:28] .../vim/lsp/rpc.lua:734	"rpc"	"/home/cheese/.local/share/gem/ruby/3.0.0/bin/ruby-lsp"	"stderr"	"Ruby LSP is ready\n"

Thanks for any help

Think I am wrong. This is more of an lspconfig issue, not ruby-lsp.

@Good1Cheese I'm closing this for now as it seems it wasn't related to the Ruby LSP. If you find that's not the case, please re-open.


Refresh jazzy documentation

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #16   +/-   ##
======================================
  Coverage    4.31%   4.31%
======================================
  Files          31      31
  Lines       25041   25041
======================================
  Hits         1080    1080
  Misses      23961   23961

Flag
Coverage Δ

#Ccmark
4.18% <ø> (ø)
:arrow_up:

#KituraMarkdown
4.31% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a53b8...bc6147c. Read the comment docs.

fileExtension - The file extension of files in the views directory that will be rendered by a particular templating engine.
I think this should be "The file extension of files that will be rendered by the KituraMarkdown template engine." Perhaps we should also add "By default Kitura will search for these in the  ./Views/ directory, you can customize this by setting the router.viewsPath property."

Within init() - Create a KituraMarkdown instance needs a full stop on the end.

There is a parameter called options which appears in a couple of places which needs a sentence next to it rather than "markdown options".

Every from parameter (there are 3 references to this parameter) needs a full stop at the end of the associated description.

The pageTemplate parameter has the description "The HTML page template used" which needs a full stop at the end.

There is no difference in the descriptions for:
public static func render(from: String) -> String and public static func render(from: String, pageTemplate: String) -> String I'd like there to be a difference as otherwise why are we passing in pageTemplate?

The API doc for the struct MarkdownOptions could do with some descriptions adding and full stops at the end of sentences and parameter descriptions.

It would be good to add at least one usage example, there is one in the github README for this repo if required.

I've addressed some of the review comments.  Still need:

usage example
some kind of example of how the HTML page template should be overridden (the sole purpose of MarkdownOptions).  This doesn't seem to be covered in any of our guides so I have inferred its usage from the code.

@helenmasters Review comments addressed.  And I've also (hopefully) solved the jazzy-doc mergeability issue.


Add a short description to each cheatcode

On the Cheatcodes reference page, we list all possible cheatcodes. However, to figure out which cheatcode does what, one has to open each link and read their description. This is problematic for new users trying to figure out features of forge.
https://github.com/foundry-rs/starknet-foundry/blob/master/docs/src/appendix/cheatcodes.md
Add a simple description to each link on the cheatcodes.md page.
e.g.

start_prank - change the caller address for a contract

Hi! Can I work on this?

Sure! Assigning you.

still open? can you assign me. thanks.


don't include icons when running on TTY

As far as I understand it, the icons won't work on any non-GUI TTY.
(see also https://forum.manjaro.org/t/replacement-for-ls-lsd-ls-deluxe-icons-problems/74887 )
My suggestion would be to try to detect when lsd is not running in an graphical terminal emulator and the printing of the icons could be suppressed in such a case?

Hi @kaefert ,
It's been a while that I search how to do this and I recently found this tiny piece of code which should do the job. Sadly, at the moment I don't have much time for new features. If you want to make a PR it would be welcomed :)

Issue is fixed.

Hi ! i've also have the same issue icons don't show up in tyy where is the file to put your piece of code pls @Peltoche

Ok i found this cmd : lsd --icon never
so in my .zshrc i put this code :
if [  "$TERM"  =  "linux"  ]; then
alias ls="lsd --icon never"
fi


Backport the fix for broken DefaultDnsRecordDecoder

Motivation:
netty/netty#5923 fixes a critical DNS resolution problem. We should
backport it until a new Netty version is released.
Modifications:

Override the DnsNameResolver.DECODER field with the fixes decoder,
using a reflection hack
Remove the workaround for netty/netty#5657, since the fix is in Netty
4.1.6.Final

Result:
DNS resolution works as expected

Current coverage is 64.55% (diff: 61.11%)

Merging #322 into master will decrease coverage by 0.11%

@@             master       #322   diff @@
==========================================
  Files           318        318
  Lines         12826      12835     +9
  Methods           0          0
  Messages          0          0
  Branches       1916       1916
==========================================
- Hits           8295       8286     -9
- Misses         3647       3664    +17
- Partials        884        885     +1

Powered by Codecov. Last update 71b9534...48fd95d


Update AKKA to the lastest version ,add support http method for Trace…

… Patch and Connect

Codecov Report

Merging #67 into master will decrease coverage by 1.09%.
The diff coverage is 59.61%.

@@             Coverage Diff             @@
##             master      #67     +/-   ##
===========================================
- Coverage     95.28%   94.18%   -1.1%
+ Complexity     1064     1060      -4
===========================================
  Files            83       83
  Lines          3370     3388     +18
  Branches        261      261
===========================================
- Hits           3211     3191     -20
- Misses           63       97     +34
- Partials         96      100      +4

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/parallec/core/resources/HttpMethod.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...ec/core/resources/AsyncHttpClientFactoryEmbed.java
90% <100%> (-1.67%)
5 <0> (ø)

src/main/java/io/parallec/core/ParallelClient.java
84.03% <37.5%> (-12.13%)
26 <1> (ø)

...c/main/java/io/parallec/core/actor/HttpWorker.java
81.53% <72.72%> (-12.01%)
29 <0> (-2)

...rc/main/java/io/parallec/core/actor/UdpWorker.java
90.62% <0%> (-5.47%)
18% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85052a3...da87d16. Read the comment docs.

@tigerqiu712 thanks so much for the nice contribution!
Sorry is busy this week, will definitely take a look on this weekend. In the meantime, could you add some test on the new code to keep the same coverage?
thanks,

@tigerqiu712  thanks so much for adding the test cases!  Could you please help to take a look at the failed test cases and fix the tests?

@tigerqiu712 I saw your local repo https://github.com/tigerqiu712/parallec does not have the latest updates. Could you also pull from the latest code, like https://stackoverflow.com/questions/3903817/pull-new-updates-from-original-github-repository-into-forked-github-repository ?
also squash all of your commits to a single one, and I can rebase based on that.


Translate install_cluster-milvusoperator.md into CN

Is there an existing issue for this?

[X] I have searched the existing issues.

Issue
Translate this new doc into CN.
Suggestion
No response
Anything else?
No response

PR #1135


Usage of rocon packages

Do we want to keep using rocon packages? Might be a good idea to minimise the reliance on outside packages, like rocon_python_comms and so on.

I went through the installation process, and had to install rocon_python_comms, rocon_console and rocon_std_msgs. If I was a random person installing this I'd probably wonder why there were these seemingly random packages required for something which seems like it should be pretty much a standalone thing.
Agreed that this isn't something urgent, though.


Event registering twice with rapid clicks?

{-# LANGUAGE OverloadedStrings, LambdaCase, OverloadedRecordDot #-}
module Main where

import Monomer
import TextShow

data NullModel = Count {term :: Int} deriving (Eq, Show)

data AppEvent
    = Init
    | Increment
    deriving (Eq, Show)

buildUI wenv model = widgetTree where
  widgetTree = box_ [alignCenter, onClick Increment] $ vstack
    [ label "Hello World!"
    , spacer
    , label $ "Click count: " <> showt (term model) ]

nullEventHandler
  :: WidgetEnv NullModel AppEvent
  -> WidgetNode NullModel AppEvent
  -> NullModel
  -> AppEvent
  -> [AppEventResponse NullModel AppEvent]
nullEventHandler wenv node model = \cases
    Init      -> []
    Increment -> [Model (model {term = succ model.term})]

main :: IO ()
main = startApp (Count 0) nullEventHandler buildUI config

config :: [AppConfig AppEvent]
config =
    [ appWindowTitle "Hello World!"
    , appTheme lightTheme
    , appWindowIcon "./assets/images/icon.bmp"
    , appFontDef "Regular" "./assets/fonts/Roboto-Regular.ttf"
    , appInitEvent Init ]

Modified version of your Hello World program. If you click quickly on Windows, using SDL 2.0.22, the button will increment twice.

@liamzee there was an issue in the box widget, that made some strange (and unnecessary) handling of the Release event. For further clarity, this does not happen with the regular example that uses button. You can test the fix by modifying your stack.yaml to point to:
- git: https://github.com/fjvallarino/monomer.git
  commit: 3dac85d785db391fcb41b80c3589407f03650c59

This commit hash will only be valid until the fix is merged to main.

Thanks for resolution!

@liamzee great! The PR has been merged to main. I'll close the issue now.


[vk] Validation layer error when running quad example

Short info header: The following validation layer error shows up when running the quad example with Vulkan:
[2019-11-06T09:22:08Z ERROR gfx_backend_vulkan]
VALIDATION [VUID-vkDestroyFramebuffer-framebuffer-00892 (0)] : Cannot call vkDestroyFramebuffer on Framebuffer 0x2d that is currently in use by a command buffer.
The Vulkan spec states: All submitted commands that refer to framebuffer must have completed execution (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-vkDestroyFramebuffer-framebuffer-00892)
object info: (type: FRAMEBUFFER, hndl: 45)

GFX version: hal-0.4, master (6a6efc42071e326f2f8e5d7213fe018a309be6ef)
OS: Ubuntu 18.04.3 LTS
GPU: Intel HD Graphics 630

This is an issue in the LunarG Validation Layer, see https://github.com/gfx-rs/gfx/issues/3015#issuecomment-531491026


Add a new API that will return markers for a given muni id

Add a new API that will return markers for a given muni id

I'm guessing no one is going to go through that rebase, right?

Closed this one - currently not in use - we will use in future when working on municipalities


Lumen

Any chance this can be converted to a lumen app instead?
Will this work with hhvm?

What's the difference between this repo and the other PHP library repo?

I think that is the server, and the PHP Library is the class to send messages to that server.
Then... you need to send a new issue there.

I don't plan on making this with Lumen but I guess the code is interchangeable if someone wants to branch and make it work. This package is the server itself that runs independantly of your project, and the The PHP Library is required via composer to interact with the server easily.

Do you install the zeroMQ binary the usual way for hhvm?

For HHVM install the lib onto the OS as normal, but you'll need the HHVM version available here:
https://github.com/duxet/hhvm-zmq

Have you tried these?:
https://github.com/yybirdcf/zmq-extension-for-hhvm
https://github.com/no1youknowz/hhvm-zeromq-ext

Neither yet, I'm not going to be on HHVM anymore; waiting it out for PHP7 to grab those tasty static-type features. Do let me know if you find success in one of these libraries; I really want to remove the ZeroMQ requirement but I can't quite see how yet.
I'll include your findings in the documentation with credit if you find success with HHVM

What are the features you need from ZeroMQ. Perhaps I can program it in Golang and wrap it as a PHP extension.
This kind of thing is a lot lot easier to do with Golang.

The loop the Pushman instance runs in, (see Line 53 here, needs to have events injected into it. So the HTTP API uses ZeroMQ to push to that socket so the Pushman loop knows when to execute handleEvent

Can you tell me line by line what each statement does. I definately think I can write something in golang OR at least write a daemon.

Have you thought about this:
https://github.com/cmosguy/laravel-http-pushstream-broadcaster

This package appears to replace the need for Pushman completely.
--
Currently with ZeroMQ:
The WAMPServer is constantly running in the background as a process, it is listening and managing connections; should it close down all clients disconnect; it still runs as a loop though so when a client pushes an event via the API, the code doesn't get executed within the loop.
The event package from the API needs to be injected into that loop, that is what ZeroMQ does.
So from Pushman.php under Console/Commands; we create a loop on 32 and a PushmanHandler on 33. From there were say, whenever ZeroMQ pushes you an event, execute 'handleEvent' WITHIN the loop so we have access to connected clients in context. (Line 35 to 38)
Then build a new public facing server on on the PUSHMAN_PORT, (8080), and start running that loop for incoming web socket connections.

You should probably close this. I looked into creating HHVM PHP extensions and it looked a bit more complicated that I had time for. I think i'll just wait for PHP 7 too.


Hide Trail View Buttons in Version

Is your feature request related to a problem? Please describe.
Buttons and options on top of the trail view in the neww v4 are taking a lot of vertical space.
Describe the solution you'd like
Add an option to hide the whole button area of the trail view. Settings could still be made from the settings menu.
Additional context
I mean the red marked area in the image bellow

Agreed! Thinking about it now, I don't even use the controls on my main vault.
It's still the default behaviour, but there's now a toggle under Settings > Views > Page > Trail > Show Controls to disable this


MIN/MAX_REQUEST_PERIOD_MS vs bc_period_multiple inconsistancy

This will likely require some verification, so I'll try to explain the best I can here.
From the InertialSense API code, it would appear that the call BroadcastBinaryData (InertialSense.cpp:545) takes in a broadcast period in milliseconds (periodMS), although the release notes reveal this is not the case.  Yet, we still see comments and variable names that match the old usage.
(IntertialSense.cpp:565-570)
		{
			// [C COMM INSTRUCTION]  3.) Request a specific data set from the uINS.  "periodMs" specifies the interval
			// between broadcasts and "periodMs=0" will disable broadcasts and transmit one single message.
			comManagerGetData(i, dataId, 0, 0, periodMS);
		}

Okay, not a big deal.  If we look from the com_manager side, we see that it's actually handled as a periodMultiple (com_manager.c:686):
/**
*   @brief Request data
*   This function requests the specified data w/ offset and length
*   for partial reads.
*
*	@param[in] dataId       Data structure ID
*	@param[in] offset   Byte offset into data structure.  0 = data start.
*	@param[in] length   Byte length of data.  0 = entire structure.
*	@param[in] periodMultiple Broadcast period of requested data.  0 = single request.
*
*	@return 0 on successful request.  -1 on failure.
*/
void comManagerGetData(int pHandle, uint32_t dataId, int offset, int size, int periodMultiple)
{
	comManagerGetDataInstance(&g_cm, pHandle, dataId, offset, size, periodMultiple);
}

However, I suspect that it isn't being handled correctly in all places, specifically comManagerGetDataRequest (com_manager.c:1311-1315):
	// Constrain request broadcast period if necessary
	if (req->bc_period_multiple != 0)
	{
		_LIMIT2(req->bc_period_multiple, MIN_REQUEST_PERIOD_MS, MAX_REQUEST_PERIOD_MS);
	}

with
#define MIN_REQUEST_PERIOD_MS       1               // (ms) 1 KHz
#define MAX_REQUEST_PERIOD_MS       100000          // (ms)

Why are we comparing the period multiple with the period?
I'm not sure if this is strongly related, but I thought we were able to get messages faster than 10 Hz before in 1.6 (I could be wrong), but it seems here we are limited to 10 Hz.

I figured out our 10 Hz issue (related to also setting the startupNavDtMs the same way we were doing with 1.6 and before).  Still there is a lot of confusion with the use of period/stepPeriod/periodMultiple.  But I have enough understanding now to get my code working to the way it was before.

@orrinjelo Sorry for not getting back to you sooner. We had several requests by customers to be able to control the rate that data was streamed. Many people were getting data faster than they could handle it. We decided to implement the period multiple to allow users to slow the data rate as needed. Each data set has a base rate and the period multiple allows you receive the data at a slower rate as needed. As you mentioned there are a few configuration variables available to change the base data rate: startupImuDtMs, startupGPSDtMs, and startupNavDtMs.

@orrinjelo Thank you for pointing out the discrepancies in the broadcast period and the periodmultiple. This has been fixed and should be more clear in the next software release.


Can't npm install version 6.0.1

Hello,
https://www.npmjs.com/package/ngx-metafizzy-flickity?activeTab=versions
Max version is 6.0.0 could you do something?
Many thanks in advance

Yes, i can.
Now the current version is 6.0.2

So many thanks @ThRintelen it worked for installation but I have an issue on loading now while it worked before

I'm trying by myself and if I find a solution I will share it.

Hm, i cant see an error if i try it on my machine. Can you create a stackblitz or something like this?

Hello @ThRintelen
Here is new project with the issue. Hope it can help.
ng16-carousel.zip

Can you try version 6.1.3 please?

Hello,
An other error

I will try to figure out but I'm not sure I can do something from my side.

yes, there is no longer a module, please import the directive (standalone) in this version

It works! Many thanks for your help.


Addition of sand gravel and cement gathering

Sorry, @Arkensor I accidentally did the changes on main and wanted to work on some other stuff.
Previous PR was #93 for everyone's context
The discussion was #90
The last comment was from Ark:

But, one of the Sand Piles, for example, is just in a backyard. If we take this approach (of overriding every asset) it may limit where server owners can realistically place their "Glass Processors". If they place it wrong and don't think about the existing assets they could have 10 trucks pulling up at some random house in suburbia to load up on the sand.

I understand, but I think this should be intended. If we have a resource that is practically everywhere on the map then that might not be a good idea for a high-value resource, but something like sand, for example, could just really be where ever you see it. Same as we do with apples right now. One has to keep in mind that if you want to avoid the usage of existing map objects that share the same prefab we could just have server owners remove balance destroying objects with a map utility to place down near it.

Okay, I'm fairly indifferent so what I will do is turn the Gravel & Sand piles into overrides and the Cement pile will be it's own prefab based on a dirt pile with its texture overridden, as it will be a slightly more valuable resource then gravel and sand.

What is the class name of the coca tree? I want to check how many there are and where they are placed.

It's called rosa_canina it looks like there are over 9,400 of them across the map.

Is this ready to go now?

Yup all good to go @Arkensor

Thanks for the review @Arkensor, happy to make the changes. Please see the below:

[ ] ItemPreview is an easy fix

[ ] Hand translation seems to be a harder one? Any ideas here or is this fine?

Player Perspective

Other Perspective

[ ] Move the processor action

I think it can be moved upstairs, I'm fine with that, but I do think it should be placed on a button as it is mechanically operated. I propose the button slightly to the right and above the current red circle.

We can put the interaction point on the controls desk as well sure

About hand translation, well it is generally easy, this is just an attribute as the others. InventoryItemComponent > Item Animation Attributes > Animation Attachments > Hand Additive .... After adjusting the values you must sadly restart workbench every time, but it takes maybe 5-8 attempts to make something half decent. Also if the bricks are too big by default you could consider scaling them down. We need to do our own prefab for this brick to change preview and handhold animation anyway, so might as well tweak that. Up to you :)

@KasperOnPC is this ready to be reviewed again? You can tell me more easily in the future by requesting a review again here:

Yeah sorry @Arkensor I'm not totally sold on my hand rotation but since I won't be able to get around to it for a little bit I think it's pretty good in it's current state.


Fix gelu in PyTorch frontend, tighten numerical checks

Previously, the PyTorch frontend approximated gelu with fastgelu.
To provide a more faithful conversion, we implement gelu instead.
We also tighten the numerical comparisons between PyTorch and TVM-from-PyTorch to 1e-5. The object detection models need an increased tolerance of 1e-4 to pass.
I do both in one go because the new gelu necessitates and is tested by the tightened testing tolerance.
I had to throw in a few fixes for missing conversions (probably due to working with very new PyTorch).

@masahi this is from https://discuss.tvm.ai/t/aspirations-for-conversion-and-unit-tests-in-the-pytorch-frontend/6922

Two of the end-to-end networks seemed to have deviations slightly above 1e-5. I moved those to 1e-4 tolerance.

CI is still not happy. Could be related to CUDA issues.

Yeah, apparently, the end-to-end checks aren't completely deterministic, I bumped them all to 1e-4 tolerance.

Thanks @t-vi


allow setting test port via env var

taken from https://github.com/pld-linux/lighttpd/commit/5f5b97ee73ba4151b4d707dcdd6859edd2e18c1f

In keeping with labels familiar to CGI environment, please consider naming the variable LIGHTTPD_SERVER_PORT instead of LIGHTTPD_TEST_PORT.  Then, LIGHTTPD_BACKEND_PORT could specify the port used by additional server test instances, such as in the proxy tests.
tests/*.conf specifies server.port = 2048, so those would need to be modified to be env.PORT and added to your patch
tests/proxy.conf also specifies server.port = 2050 for the proxy instance and would need to be exported into the test environment to be used in proxy.conf as env.LIGHTTPD_BACKEND_PORT

@glensc: have you had a chance to review my feedback?

@gstrauss yes. i will do it. just not sure when

Going to close this for now.  Please re-open when you have a chance to submit another patch for review and I'll take another look.
$ grep port tests/*.conf
Currently, tests/*.conf use ports 1026, 1048, 2048, 2050, 10000, 20000 for the servers, backend proxies, and other backends (e.g. fastcgi)  (The use of port 1048 in tests/fastcgi-13.conf should probably be changed to the same as port 1026)

This got improved in 1.4.59:

[tests] use ephemeral ports in tests

ref:

https://redmine.lighttpd.net/projects/lighttpd/wiki/Release-1_4_59/


Updated destination device default to iPhone 11

Checklist

[x] I've read and followed the Contribution Guidelines
[x] step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update
Context
Adds support for the default Bitrise CI device.
When Xcode 14.3 and Xcode 15 (beta) is present on the same machine, requiring the latest (this is the default) version of the Simulator runtime, will find iOS 17 (beta). This is undesirable as the beta Simulator can be unstable or at least not officially supported by earlier Xcodes.
In practice Xcode still works with newer runtimes, at least across the same major version (despite this table: https://developer.apple.com/support/xcode/). When there are different major versions, there is some risk of not working right.
Disa
Resolves: https://bitrise.atlassian.net/browse/BE-1124
Changes

Disabled parallel testing, to make test faster (counterintiutive yes)

Investigation details

Decisions

Note: CI passes, except on 14.3.1 edge (there seems some issue). Discussed with @ofalvai that we can merge this.


docs: use significand mask in math/base/special/rempio2

Description

What is the purpose of this pull request?

This pull request:

uses STDLIB_CONSTANT_FLOAT64_HIGH_WORD_SIGNIFICAND_MASK, instead of STDLIB_CONSTANT_FLOAT64_HIGH_WORD_SIGN_MASK, as used in both the javascript implementation and in the FreeBSD reference, in math/base/special/rempio2.
Reference: https://svnweb.freebsd.org/base/release/12.2.0/lib/msun/src/e_rem_pio2.c?revision=367086&view=markup#l69

Related Issues

Does this pull request have any related issues?

None.
Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Good catch!

Thanks @Planeshifter, this was troubling other C implementations. Now as this is caught, we can work on others.


Data serialization: fix dump ITAB_DUPLICATE_KEY

Dear contributors,
Apologize if that may not be the perfect pull request (this is my first one ever).
Here is the problem: the system dumps when I try to create a new online repository where /data/ folder contains data from some customizing tables :

It looks like the issue occurs as soon as one of the tables has a DDIC definition comprizing of "cascading" include structures. Example: WCFC_GIL_COMPROP.

Changing one line of coding solved the problem in my system.
Cheers,
Nick.

مُرسل من بريد Yahoo لجهاز iPhone
بتاريخ الجمعة, مايو 20, 2022, 3:33 م، NicolasBusson @.***> كتب:
Dear contributors,
Apologize if that may not be the perfect pull request (this is my first one ever).
Here is the problem: the system dumps when I try to create a new online repository where /data/ folder contains data from some customizing tables :
It looks like the issue occurs as soon as one of the tables has a DDIC definition comprizing of "cascading" include structures. Example: WCFC_GIL_COMPROP.
Changing one line of coding solved the problem in my system.
Cheers,
Nick.
You can view, comment on, or merge this pull request online at:
https://github.com/abapGit/abapGit/pull/5577
Commit Summary

111c9a1 Data import: fix dump ITAB_DUPLICATE_KEY

File Changes
(1 file)

M src/json/zcl_abapgit_ajson.clas.locals_imp.abap (2)

Patch Links:

https://github.com/abapGit/abapGit/pull/5577.patch
https://github.com/abapGit/abapGit/pull/5577.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hi,
The ajson code is mirrored from https://github.com/sbcgua/ajson into abapGit, via the process described in
https://blogs.sap.com/2021/04/20/automagic-standalone-renaming-of-abap-objects/
so in order to not have the change overwritten, it must be contributed to https://github.com/sbcgua/ajson first, and then its automatically mirrord into abapGit

Tt
مُرسل من بريد Yahoo لجهاز iPhone
بتاريخ الجمعة, مايو 20, 2022, 3:36 م، Lars Hvam @.***> كتب:
Hi,
The ajson code is mirrored from https://github.com/sbcgua/ajson into abapGit, via the process described in
https://blogs.sap.com/2021/04/20/automagic-standalone-renaming-of-abap-objects/
so in order to not have the change overwritten, it must be contributed to https://github.com/sbcgua/ajson first, and then its automatically mirrord into abapGit
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Hello @larshp ,
Thanks a lot for the hint! I created a fork on ajson project and submitted the same pull request :
https://github.com/sbcgua/ajson/pull/103
I'm closing this one then...
Cheers (and thank you so much for everything you do for the community: you rock)
Nick.