C++ exceptions are catched in C-linkage functions with callbacks

XGBoost provides functions with C linkage that take callbacks, such as XGQuantileDMatrixCreateFromCallback, which takes functions reset and next.
If a C++ exception inheriting from std::exception is thrown inside one of those functions supplied as callbacks, the exception will be called inside the call to XGQuantileDMatrixCreateFromCallback instead of propagating to the outside, which is quite unexpected for a function that is offered with C linkage, given that C functions wouldn't catch C++ exceptions.

Uncaught C++ exceptions thrown from functions with C linkage will cause the program to crash. This is why all C API functions have wrappers that catches all C++ exceptions and convert them into an error code. For example:
https://github.com/dmlc/xgboost/blob/252e018275195b5e6a7fc49f069dccb2ec2d8c46/src/c_api/c_api.cc#L243-L256

C functions wouldn't catch C++ exceptions

This is true in general. However, uncaught C++ exceptions will cause undesirable crashes, so for the case of XGBoost, all C linkage functions will catch all C++ exceptions.

It does however result in a rather unintended side effect: if the user wishes to catch a custom C++ exception from outside of the call to e.g. XGDMatrixCreateFromCallback (in order to e.g. trigger something when that custom exception is encountered), then that exception will not be catchable unless it's a class that wouldn't inherit from std::exception.

@trivialfis How does the current DataIterProxy handle errors from the data iterator? Does the data iterator return an error code? Does the proxy check the error code from the data iterator?

@trivialfis How does the current DataIterProxy handle errors from the data iterator? Does the data iterator return an error code? Does the proxy check the error code from the data iterator?

It returns an error code, and will set the .what() of the exception to XGBGetLastError.

We have two alternatives, none of which is quite perfect:

The status quo: exceptions from the data iterator are caught and translated into error codes. Disadvantage: users have to use XGBGetLastError to recover the error message; the expressiveness of C++ exception is lost.
Allow the data iterator to throw C++ exceptions. Disadvantage: uncaught C++ exceptions will cause the whole program to crash. According to the C++ standard, std::terminate will be called when an exception is throw and not caught.

I think the ideal behavior would be that C++ exceptions thrown by the user's callback would be left uncatched, while C++ exceptions like std::bad_alloc generated otherwise during the normal course of the function (not from the user callback) would get catched and translated to error return codes like it currently does, so that it'd behave like a C function.
But I think it might be quite tricky to implement such a system.

C++ exceptions thrown by the user's callback would be left uncatched

There will be the risk of users forgetting to catch custom C++ exceptions leading to crashes. Is this risk acceptable?

There will be the risk of users forgetting to catch custom C++ exceptions leading to crashes. Is this risk acceptable?

I don't think that should be a concern when offering a C interface - that is, C functions are not supposed to be aware of C++ exceptions, so I would guess that a user passing C++ functions should in turn be aware of the need to catch C++ exceptions, whether in an external try-catch, or in an internal one with a corresponding error code return.

This can be done by having users throw a subclass of a pre-defined exception class, e.g. DataIterException.

It's currently possible to throw an object from an arbitrary class not inheriting from std::exception, which is then catchable from outside of the callback. So there's a workaround, even if not the most ideal.
Perhaps a better alternative could be to let the user specify a custom return code in case of failure.

We can revise the exception handling logic to handle data iterator exceptions separately:
Before:
try {
   // ...
} catch (dmlc::Error& e) {
   // Log error and return error code
} catch (std::exception& e) {
   // Log error and return error code
}

After:
try {
  // ...
} catch (xgboost::DataIterException& e) {
 throw e;  // Re-throw
} catch (dmlc::Error& e) {
  // Log error and return error code
} catch (std::exception& e) {
  // Log error and return error code
}

I think @hcho3 is right that C++ exception cannot propagate through a function with C linkage. C++ is a different language than C just like Python is a different language than C. So, imagine you are writing Java/Python instead of C++, the error handling should work the same.
If the next/reset function for the callback has C linkage (as it should), XGBoost can't catch exceptions from it in XGDMatrixCreateFromCallback either, just like XGBoost can't catch java exception.

For the R package, you can probably have a try / catch block to wrap the call to XGDMatrixCreateFromCallback, since we use a C++ compiler to build the glue code for the R package. So it might be okay for the callback function to throw an exception, as long as the R package glue code catches it.

Feel free to reopen if there are further questions.


Removed package name and logo from doc frontpage

As the title says.

Do you think this can be merged?


Liqui fetch_ticker

Using latest ccxt version in python.
When i try to fetch ticker in async branch from Liqui
liqui = ccxt.liqui()
loop = asyncio.get_event_loop()
loop.run_until_complete(liqui.fetch_ticker('ETH/BTC' ))

I get:
  File "/usr/lib/python3.6/asyncio/base_events.py", line 467, in run_until_complete
    return future.result()
  File "/home/marin/fino/.venv/lib/python3.6/site-packages/ccxt/async/exchanges.py", line 12198, in fetch_ticker
    tickers = await self.fetchTickers([id])
TypeError: fetchTickers() takes 1 positional argument but 2 were given

Method fetch tickers in Liqui :
 async def fetch_ticker(self, symbol):
        await self.load_markets()
        market = self.market(symbol)
        id = market['id']
        tickers = await self.fetchTickers([id])
        return tickers[symbol]

Should be changed to
 async def fetch_ticker(self, symbol):
        await self.load_markets()
        market = self.market(symbol)
        id = market['id']
        tickers = await self.fetchTickers()
        return tickers[id]

or...
Cheers friend.

Hello, @marinsokol5 ! As always, good to hear from you! Thanks a lot for your feedback, it's very helpful to us! I'll take a look and fix the issue with Liqui fetchTickers asap.

Hmm... That is strange... I tried the following, and it worked:
mbp:ccxt igorkroitor$ python3
Python 3.6.2 (v3.6.2:5fd33b5926, Jul 16 2017, 20:11:06)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ccxt.async as ccxt
>>> import asyncio
>>> print(asyncio.get_event_loop().run_until_complete(ccxt.liqui().fetch_ticker('ETH/BTC')))
{'timestamp':<PHONE_NUMBER>000, 'datetime': '2017-09-25T19:34:06.000Z', 'high': 0.08141084,
'low': 0.07421783, 'bid': 0.07546336, 'ask': 0.0760007, 'vwap': None, 'open': None, 'close': None,
'first': None, 'last': 0.07558197, 'change': None, 'percentage': None, 'average': 0.077814335,
'baseVolume': 6392.17138498, 'quoteVolume':<PHONE_NUMBER>4543055, 'info': {'high': 0.08141084,
'low': 0.07421783, 'avg': 0.077814335, 'vol':<PHONE_NUMBER>4543055, 'vol_cur': 6392.17138498,
'last': 0.07558197, 'buy': 0.07546336, 'sell': 0.0760007, 'updated':<PHONE_NUMBER>}}
>>> ccxt.__version__
'1.8.14'
>>>

I also added an example here: https://github.com/ccxt-dev/ccxt/blob/master/examples/py/async-fetch-ticker.py
# -*- coding: utf-8 -*-

import asyncio
import os
import sys
import ccxt.async as ccxt  # noqa: E402

print(asyncio.get_event_loop().run_until_complete(ccxt.liqui().fetch_ticker('ETH/BTC')))

Does it still fail to work for you with ccxt 1.8.14+ ?

I found a transpiler bug there... I noticed in your output that it was calling the non-redefined version of fetchTicker, whereas it should have called fetch_ticker as per python PEP8 notation. And I fixed it, the new version 1.8.20+ should work fine. We will be thankful if you report back on this. Thx again!


Support unit test coverage for TypeScript files

Support parsing an LCOV for TypeScript files, similar to the ability of the JavaScript plugin

Hi Pablissimo,
does the coverage work for you? I get a NullPointerException since in TsCoverageSensor.java @line123, since
Measure ncloc = context.getMeasure(resource, CoreMetrics.NCLOC);
returns null. In the SonarQube forum the answer was to not use Sensor but DecoratorContext
http://sonarqube-archive.15.x6.nabble.com/SensorContext-getMeasure-returns-null-td5014664.html
I then commented out the few lines that used the Null reference in the hopes that I would get some results, but it won't show any stats about code coverage. (I created the LCOV file using remapIstanbul with the src maps and the .js LCOV from Istanbul).
I wanted to know what's the latest status on test coverage, so I know where to focus on moving forward
Greetings
Manuel

It certainly did work, albeit... ropily, but I've not re-tested with any more recent version of SQ than I was using back at Christmas. What's the specific setup you've got going?

Various recent fixes should have improved support for coverage information, closing this for now until there's more information about the specific issue.


Turn off caching?

Hi! It says that caching with Redis is optional. How do I turn it off?
(I'm having problems getting Redis to work on my server.)

Hey, to create a QuoteService object that queries the API without caching use:
$quoteService = FastQuoteServiceBuilder::builder()
	->withAlphaVantageGlobalQuoteAPI("your API key")
	->build();

To create it with caching enabled:
$quoteService = FastQuoteServiceBuilder::builder()
	->withAlphaVantageGlobalQuoteAPI("your API key")
	->withRedisCaching(new \Predis\Client(), $minCachingLengthSeconds=300)
	->build();

The demo code should explain how to use the QuoteService object from there.

Thanks!


Make workflow to verify build of both x86_64 and aarch64

relates to https://github.com/Skaginn3x/framework/issues/90

https://github.com/Skaginn3x/vcpkg-registry/pull/2


Build Error: Could not resolve "sst"

When attempting to import the generated Resource interface into a function, I observe the following import error:

During deployment, I also experience the following error (using either sst dev or sst deploy):
Failed to build function: Could not resolve "sst"

I note, in the documentation, it is suggested that an sst-env.d.ts file should have been generated after executing sst init. This does not appear to have happened.
I do, however, see this reference:
/// <reference path="./.sst/platform/config.d.ts" />

in sst.config.ts, which references the generated types.
Have recent changes potentially been made in this area?

Closing issue. I hadn't installed the sst@ion package.


Roles and Permissions (Feature)

User Roles Tab - Which contains collection-wise permissions - Display UI Elements based on permissions
Ex: Collection tab must be visible if user has read access. Create button must be visible if user has write access. etc
Similar to https://docs.strapi.io/user-docs/latest/users-roles-permissions/introduction-to-users-roles-permissions.html

This was previously discussed in https://github.com/pocketbase/pocketbase/discussions/94, https://github.com/pocketbase/pocketbase/discussions/261.
This has 2 nuances depending whether you want to create roles for users or admins.
PocketBase admins act as developer accounts - they can read and modify everyhing. Collection API rules don't apply for them.
At least for v1.0.0, I don't plan adding support for admin roles because it will complicate unnecessary the public API when PocketBase is used as framework.
For user permissions on the other hand, we have Collection API rules and custom fields that you can use to create your own role/team/group access controls.
I agree that user role level permissions are simpler but they also are very limited because you cannot create easily an "ownership" type of relation with just roles (for example, allow read/modify access to a set of projects that are owned by a user/team based on a projectId field).
Role style permissions are more suitable for general content management, while PocketBase try to be a little more "low level" than that.
Please keep in mind that there is an active proposal to merge the existing users and profiles entities into a single one, which is expected to simplify the users management. You can review the proposal and share your feedback here - https://github.com/pocketbase/pocketbase/issues/376


[5.4] Add an --ignore option to the migrator

This option is especially useful for when you're in development and have a table with a large amount of test data, but you need to delete all of your tables. Deleting the large test table will take too long, so you just ignore that the table exists.

--force may have been a better name 🤔

or --savage :D

@JayBizzle doesn't force run in production mode?

@jbrooksuk yeah, think you're right actually.
Ignore just seemed a bit arbitrary. Ignore what?
Useful though, could definitely benefit from this addition.

Ignore the errors 👍

Savage is better for sure. :P Or --yolo.

As a serious suggestion, maybe we should just call it --suppress-errors or something?

Maybe --quiet or --silent? I feel that's more normal.

Those sorts of flags are usually used to describe output verbosity, rather than actually changing the runtime behaviour.

Maybe just suppress then?

I dunno, this feels kinda hacky :smile:

There are times when this really makes a lot of sense to have, unless you mean the implementation is hacky?


Allow overloading on the full name of enum cases

SE-0155 Requirements:

[x] Ban case Foo(), rewrite to case Foo(Void)
[x] Labels in associated value clauses are part of the case name
[x] Case name overloading on distinct full names
[x] Default arguments in associated value clauses
[ ] Consistent pattern matching behavior

Further requirements

[x] Model associated value clause as a parameter list
[ ] Type check default argument expressions and contextualize closures within
[ ] Teach SILGen to emit TupleShuffleExprs into inject_enum_* operands

⛵


Add adjoint state method for adaptive time step solvers

This is first working version of the adjoint state method for adaptive time step solvers. It's not perfect but it does the job.
Some things I'd like to do, probably in subsequent PRs:

[ ]  Merge the classes AdjointFixedAutograd and AdjointAdaptiveAutograd because they are very similar. There's a lot of common code in these two.
[ ]  Compute the gradient in a more precise manner. Right now I'm just evaluating the gradient integral once every dt with the value of y and a computed. However, we also know intermediate values of y and a since they're used for the Runge Kutta integration. So we could improve precision on the gradient, and release the rtol/atol in the tests.
[ ] Either implement the adjoint method for sesolve, or fix the class inheritence. Right now SEDormandPrince inherits from DormandPrince which itself inherits from AdjointAdaptiveSolver. However, it does not support the adjoint method. I don't expect anyone to ever use the adjoint method with sesolve, so may not be worth implementing it. Will depend on how simple this is to do.

Closing in favor of #266


Implement Immersive sounds

with datapack i guess, let's see for the in game music if we use noteblocks
immersive datapack: https://www.curseforge.com/minecraft/customization/immersive-sounding
sounds overhaul: https://youtu.be/UMq8zHyUN8k

A datapack is server side, so in the ressourcepack instead :)
And I don't think using noteblock sounds is a good idea

noteblocks might be the only way to not force 10go of download to the client

Noteblocks song will be much heavier that a resource pack song, a song in a resource pack is encoded using a specialised structure, with noteblock each note is wrapped in a packet

On the big v1 pack there was music for all cities it seems https://www.youtube.com/watch?v=LDiqnvv_8e8 😭

maybe creating a special resource pack for that.
When you login you get the pack and if in you activate the last time you played the /immersive command the you will download the immersive pack every time you login

So you're saying we can enforce multiple server pack ? not sure about that

why not? and if not, remove the first one and erplace it with the new that contain immersive sounds

this can help: minecraft sounds keys

we can't add new songs without replacing vanilla's ones, so we have to replace blocks sound (or anyone that a player can't trigger)

exemple for sounds.json doc here
"example.sound.name": {
    "category": "hostile",
    "sounds": [
      {
        "name": "whatever/path/example_3",
        "volume": 0.5,
        "pitch": 2.5,
        "stream": true,
        "preload" true
      },
      {
        "name": "whatever/path/example_4",
        "volume": 0.2,
        "pitch": 0.8,
        "attenuation_distance": 15
      },
      {
        "name": "whatever/path/example_5",
        "volume": 1.5,
        "pitch": 1.5,
        "weight": 3
      }
    ]
  }


Add build and lint to the CI, fix reported problems

A little smoke test in the CI never hurt anyone. It's easy to add and verify that all the changes from now on at least compile and make sense from the linter point of view.
Here is the CI run on this change itself:

Gentle ping @badouralix


Missing public after creating an application

Hi @sansyrox,
Executing python -m starfyre --create="my-app" misses public in my-app.
https://github.com/sparckles/starfyre/tree/main/test_application has public but that's not the case for
https://github.com/sparckles/create-starfyre-app.
./build.sh
Absolute path of the project = /home/ryutas/packages/wasm/starfyre/tmp/my-app
This is the working directory /home/ryutas/packages/wasm/starfyre/tmp/my-app/pages ../styles/index.css
Compilation successful
File routes populated ['app']
This is the project dir path /home/ryutas/packages/wasm/starfyre/tmp/my-app
These are the file routes ['app']
This is the dist path /home/ryutas/packages/wasm/starfyre/tmp/my-app/dist
This is the store path /home/ryutas/packages/wasm/starfyre/tmp/my-app/dist/store.js
This is the js store path /home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/starfyre/js/store.js
JS file written
Python files written
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/starfyre/__main__.py", line 82, in <module>
    main()
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/starfyre/__main__.py", line 53, in main
    create_dist(file_routes=file_routes, project_dir_path=absolute_path)
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/starfyre/dist_builder.py", line 145, in create_dist
    copy_public_files(project_dir_path)
  File "/home/ryutas/packages/wasm/starfyre/venv/lib/python3.11/site-packages/starfyre/dist_builder.py", line 117, in copy_public_files
    for file in public_dir.iterdir():
  File "/usr/lib/python3.11/pathlib.py", line 931, in iterdir
    for name in os.listdir(self):
                ^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/ryutas/packages/wasm/starfyre/tmp/my-app/public'

Hey @oroppas 👋
It should have been fixed now 😄 Thank you for the reporting the issues, I really appreciate it ✨


works fine in firefox but not in chrome and safari

It works fine in firefox as usual.
But it is not working in chrome  or safari.
But web version of this recorder is working in chrome.

I'm not sure what you mean?  It should work in Firefox, and Chrome on every platform other than iOS.  Any browser on iOS (and Safari on any platform) will not work, because Webkit has not implemented getUserMedia for audio input.

Yes, you are right.
It works fine in both firefox and chrome.
Thanks for your AudioRecorder code.


Add two tasks: Listops and IMDB Review

Adding two tasks of LRA benchmark.

ListOps
Downolad dataset in GitHub page. Unzip the downloaded dataset, and move it to the project folder.
python -m s4.train --dataset listops-classification --model s4 --epochs 100 --bsz 50 --d_model 128 --n_layers 4 --ssm_n 64 --lr 1e-2 --p_dropout 0 --lr_schedule

Training with the previously defined hyper-parameters yields the test accuracy 54.3% on the test set.
IMDB
We used the huggingface datasets for LRA IMDB review task.
python -m s4.train --dataset imdb-classification --model s4 --epochs 100 --bsz 50 --d_model 64 --n_layers 4 --ssm_n 64 --lr 1e-2 --p_dropout 0

Training with the previously defined hyper-parameters yields the test accuracy 80.7% on the test set.

This looks great, but can you make this PR just the new datasets, and not changes to the model or the training?

Here is the training curve for IMDB Review.

Ok, working on ti.

Added some review comments. I think there was a merge failure, so if you can try again to pull.
Also be sure to run make autoformat to check the formatting.

Results of ListOps:


💚 Nightly release

I've noticed the nightly release always skipped and found out it might be related to incorrect workflow setup 🥲
I also opened a pull request for nightly release actions to update the example document, hope things work well now.
Currently, I'll mark this pull request until I verified workflow works properly.

I can confirm those changes makes the nightly release works


Package model-config-tests

Restructured the code into src and test
Add model-config-tests cmd to run pytests under model_config_tests
Added CD: On push to tags build distribution and publish to PyPI (version would need to be updated in pyproject.toml, unless it is made dynamic like payu with versioneer?)
Added CI: Runs local tests, and test building distribution

Note: Test code gets rewritten in #19, so changes under tests/ will get rewritten.
Before merging: Need PRs in access-om2-configs and repro repositories pinning model-config-tests to a previous commit
Closes #3

I've used a bunch more of the example CI/CD actions here (https://github.com/ACCESS-NRI/dev-docs/wiki/Continuous-integration-and-deployment):

adding pre-commit for linting / formatting,
uploading code coverage to codecov,
Running tests with python versions 3.9-3.11

Thanks for the review @CodeGat! Yeah, that've would've been been good to have done it in a separate PR in future.. I think my goal in future is to set up pre-commit from start

I noticed come errors with edits I made to the pyproject.toml file. I thought it would be tidy to have local test settings configured in pyproject.toml but of course they also had an impact on pytests inside the package (that are run by model-config-tests cmd). So I've added a step to CI to test running model-config-tests command.  I've added that to a test that also pip installs model_config_tests from the distribution built for PyPI, so to also check that model-config-tests cmd has no runtime errors with missing dependencies..


Support snippets/matches for array types

For now, we cannot access snippets, matches and indices for array types, like described here :
https://typesense.org/docs/0.23.1/api/search.html#search-parameters
  "highlights": [
    {
      "field": "addresses",
      "indices": [0,2],
      "snippets": [
        "10880 Malibu Point, Malibu, CA 90265",
        "10000 Malibu Point, Malibu, CA 90265"
      ],
      "matched_tokens": [
        ["Malibu", "Malibu"],
        ["Malibu", "Malibu"]
      ]
    }
  ],

This is fixed in #129


DNM - Test CRD Proposal PR

Testing the CRD Proposal PR.
https://github.com/openstack-k8s-operators/dataplane-operator/pull/303
Need to baseline this against a CI environment with both Baremetal and Preprovisioned nodes.

recheck

recheck

Hmm, seems to be using the default repo still:
2023-08-24 06:15:35.325892 | controller |         "DATAPLANE_REPO": "/home/zuul/src/github.com/openstack-k8s-operators/dataplane-operator",

recheck

recheck

Hmm still trying to checkout the OpenStack-k8s-operators version of dataplane-operator which doesn’t have the crd-proposal branch. Weird that the branch part works but the DATAPLANE_REPO env var doesn’t. Must be missing something somewhere here. Possibly in ci-framework rather than install_yamls though.

needs https://github.com/openstack-k8s-operators/openstack-operator/pull/453 to catch up

/override rdoproject.org/github-check


Potential max_input_len Issue/Inconsistency?

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
I expect to see input/output that combines for a token length of less than 8192 after the chat template is applied to be retained in full as valid training data when examining the arrow files in the /last_run_prepared/ data after running python -m axolotl.cli.preprocess instruct-lora-8b.yml
Current behaviour
Training data is being cut off at a max length of 2048.
Steps to reproduce
My yml sets sequence_len: 8192 but the logs keep printing max_input_len as having been set to 2048. Even when I alter the source code in src/axolotl/utils/trainer.py to hard code max_input_len: 7192 and def drop_long_seq(sample, sequence_len=2048, min_sequence_len=2) to def drop_long_seq(sample, sequence_len=7192, min_sequence_len=2), and the log print out confirms at least that max_input_len has been set to 7192 after rebuilding/reinstalling the axolotl, the training data still gets cut off at a length of 2048 tokens. The issue persistently occurs, when using these datasets/chat_template settings:
chat_template: llama3
datasets:
  - path: williambarberjr/L3_8B_Instruct_MarkdownToSummaryConvert
    type: chat_template
    chat_template: llama3
    field_messages: messages
    message_field_role: role
    message_field_content: content
    roles:
      user:
        - user
      assistant:
        - assistant
      system:
        - system

However, when I set my own custom chat template like this:
datasets:
  - path: ./cleanAxolotlTrainingDataL3_8B_Instruct.jsonl
    type: input_output

And have the jsonl data already prepped with all the correct beginning, ending etc. chat template tokens. It doesn't cut the length at a max of 2048. Here's how I'm printing out the prepared data to check if the template looks correct. First I run python -m axolotl.cli.preprocess instruct-lora-8b.yml in the command line then I run this python code:
import json, yaml
from transformers import AutoTokenizer
from datasets import load_from_disk
import os

#find the yml file in the current directory
ymlFile = next(f for f in os.listdir('.') if f.endswith('.yml'))
with open(ymlFile, 'r') as f:
    cfg = yaml.safe_load(f)
model_id = cfg['base_model']
tok = AutoTokenizer.from_pretrained(model_id)
#get the subdirectory under last_run_prepared
subdirToLoad = next(subdir for subdir in os.listdir('last_run_prepared') if os.path.isdir(os.path.join('last_run_prepared', subdir)))
ds = load_from_disk(f'last_run_prepared/{subdirToLoad}')

with open('chatTemplateExample.txt', 'w') as f:
    f.write(tok.decode(ds['input_ids'][0]))

Thoughts on what might be causing this?
Config yaml
base_model: meta-llama/Meta-Llama-3-8B-Instruct
model_type: LlamaForCausalLM
tokenizer_type: AutoTokenizer

load_in_8bit: false
load_in_4bit: false
strict: false

chat_template: llama3
datasets:
  - path: williambarberjr/axolotlTrainingDataL3_8B_Instruct.jsonl
    type: chat_template
    chat_template: llama3
    field_messages: messages
    message_field_role: role
    message_field_content: content
    roles:
      user:
        - user
      assistant:
        - assistant
      system:
        - system

dataset_prepared_path:
val_set_size: 0.1
output_dir: ./lora-out
data_seed: 49
seed: 49

sequence_len: 8192
sample_packing: true
eval_sample_packing: true
pad_to_sequence_len: true

adapter: lora
lora_model_dir:
lora_r: 32
lora_alpha: 16
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
lora_modules_to_save:
  - embed_tokens
  - lm_head

wandb_project: markdownToSummaryLoraAllExamples
wandb_entity: williambarberjr
wandb_watch: gradients
wandb_name: instruct_lora_L3_8B_adamw_all_ex
wandb_log_model: checkpoint

gradient_accumulation_steps: 4
micro_batch_size: 1
num_epochs: 1
optimizer: adamw_8bit
adam_beta1: 0.9
adam_beta2: 0.999
adam_epsilon: .00000001
lr_scheduler: constant
learning_rate: 0.0002
train_on_inputs: false
group_by_length: false
bf16: auto
fp16:
tf32: false

gradient_checkpointing: true
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true
s2_attention:
auto_resume_from_checkpoints: true

warmup_steps: 10
eval_batch_size: 2
eval_max_new_tokens: 128
save_total_limit: 3
save_steps: 100
eval_steps: 100
early_stopping_patience: 3
weight_decay: 0.0
special_tokens:
   bos_token: <|begin_of_text|>
   eos_token: <|eot_id|>
   pad_token: <|eot_id|>

Possible solution
Tried several ideas above including hard coding some variables to no avail. For whatever reason the custom chat template described above doesn't reproduce the same cut off training data issue.
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
Python 3.10.14
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

we had the same issue, it appears that max_length is somehow hardcoded and did not involve the  value input in yml file.
https://github.com/axolotl-ai-cloud/axolotl/blob/78e12f8ca5f2bb8882a17335e230d585b9698890/src/axolotl/prompt_strategies/chat_template.py#L22

@williambarberjr you could probably pass max_length=8192 in the yml file
datasets:
  - path: williambarberjr/L3_8B_Instruct_MarkdownToSummaryConvert
    type: chat_template
    chat_template: llama3
    max_length: 8192
    field_messages: messages
    message_field_role: role
    message_field_content: content
    roles:
      user:
        - user
      assistant:
        - assistant
      system:
        - system

we had the same issue, it appears that max_length is somehow hardcoded and did not involve the  value input in yml file.
https://github.com/axolotl-ai-cloud/axolotl/blob/78e12f8ca5f2bb8882a17335e230d585b9698890/src/axolotl/prompt_strategies/chat_template.py#L22
Changing value allow to resolve the issue.

If I remember correctly, I tried this and it didn't work for me but it's possible I failed to rebuilt the package before retrying. Regardless for my next runs I'm likely going to stick with the script I have that prepares my data in type: input_outpit format going forwards as I know that works and I don't really use the --gradio option to test the model at the end, I've started to default to spinning up vllm. And vllm applies the chat template correctly it seems. So I have a work around but I wanted to put this issue out there so others are aware and maybe eventually we can get it fixed.

Since #1818, the max_length is set to the sequence_len parameter.


chore(DDI-927):change half url to full url

@Radha-Alberta Could we possibly edit the description of this prop as well? To indicate that a full URL is required.

:tada: This PR is included in version 4.0.0-alpha.34 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.90 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.16 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-alpha.6 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to install in Laravel

Version requirements mismatch, anything that can be done about this?
Using version ^4.0 for team-reflex/discord-php
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove laravel/framework v7.27.0
    - Conclusion: don't install laravel/framework v7.27.0
    - team-reflex/discord-php v4.0.0 requires illuminate/support ^4.0|^5.0 -> satisfiable by illuminate/support[4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev].
    - team-reflex/discord-php v4.0.1 requires illuminate/support ^4.0|^5.0 -> satisfiable by illuminate/support[4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev].
    - team-reflex/discord-php v4.0.2 requires illuminate/support ^4.0|^5.0 -> satisfiable by illuminate/support[4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev].
    - team-reflex/discord-php v4.0.3 requires illuminate/support ^4.0|^5.0 -> satisfiable by illuminate/support[4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev].
    - team-reflex/discord-php v4.0.4 requires illuminate/support ^4.0|^5.0 -> satisfiable by illuminate/support[4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.x-dev, 5.8.x-dev].
    - don't install illuminate/support 5.5.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.6.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.7.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.8.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 4.0.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 4.1.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 4.2.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.0.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.1.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.2.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.3.x-dev|don't install laravel/framework v7.27.0
    - don't install illuminate/support 5.4.x-dev|don't install laravel/framework v7.27.0
    - Installation request for laravel/framework (locked at v7.27.0, required as ^7.24) -> satisfiable by laravel/framework[v7.27.0].
    - Installation request for team-reflex/discord-php ^4.0 -> satisfiable by team-reflex/discord-php[v4.0.0, v4.0.1, v4.0.2, v4.0.3, v4.0.4].

rolling back to laravel 5 doesnt help either
Using version ^4.0 for team-reflex/discord-php
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install team-reflex/discord-php v4.0.4
    - Conclusion: don't install team-reflex/discord-php v4.0.3
    - Conclusion: don't install team-reflex/discord-php v4.0.2
    - Conclusion: don't install team-reflex/discord-php v4.0.1
    - Conclusion: remove nesbot/carbon 2.39.0
    - Installation request for team-reflex/discord-php ^4.0 -> satisfiable by team-reflex/discord-php[v4.0.0, v4.0.1, v4.0.2, v4.0.3, v4.0.4].
    - Conclusion: don't install nesbot/carbon 2.39.0
    - team-reflex/discord-php v4.0.0 requires nesbot/carbon ^1.18 -> satisfiable by nesbot/carbon[1.18.0, 1.19.0, 1.20.0, 1.21.0, 1.22.0, 1.22.1, 1.23.0, 1.24.0, 1.24.1, 1.24.2, 1.25.0, 1.25.1, 1.25.3, 1.26.0, 1.26.1, 1.26.2, 1.26.3, 1.26.4, 1.26.5, 1.26.6, 1.27.0, 1.28.0, 1.29.0, 1.29.1, 1.29.2, 1.30.0, 1.31.0, 1.31.1, 1.32.0, 1.33.0, 1.34.0, 1.34.1, 1.34.2, 1.34.3, 1.34.4, 1.35.0, 1.35.1, 1.36.0, 1.36.1, 1.36.2, 1.37.0, 1.37.1, 1.38.0, 1.38.1, 1.38.2, 1.38.3, 1.38.4, 1.39.0, 1.39.1].
    - Can only install one of: nesbot/carbon[1.26.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.5, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.6, 2.39.0].
    - Can only install one of: nesbot/carbon[1.27.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.28.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.30.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.31.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.31.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.32.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.33.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.35.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.35.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.37.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.37.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.39.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.39.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.18.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.19.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.20.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.21.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.22.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.22.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.23.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.2, 2.39.0].
    - Installation request for nesbot/carbon (locked at 2.39.0) -> satisfiable by nesbot/carbon[2.39.0].

Can you try install the develop branch? Run composer require team-reflex/discord-php dev-develop.

Fresh Laravel 7 project:
composer create-project --prefer-dist laravel/laravel .
composer update
composer require team-reflex/discord-php dev-develop

./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for team-reflex/discord-php dev-develop -> satisfiable by team-reflex/discord-php[dev-develop].
    - Conclusion: remove monolog/monolog 2.1.1
    - Conclusion: don't install monolog/monolog 2.1.1
    - team-reflex/discord-php dev-develop requires monolog/monolog ^1.19 -> satisfiable by monolog/monolog[1.19.0, 1.20.0, 1.21.0, 1.22.0, 1.22.1, 1.23.0, 1.24.0, 1.25.0, 1.25.1, 1.25.2, 1.25.3, 1.25.4, 1.25.5, 1.x-dev].
    - Can only install one of: monolog/monolog[1.19.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.20.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.21.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.22.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.22.1, 2.1.1].
    - Can only install one of: monolog/monolog[1.23.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.24.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.0, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.1, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.2, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.3, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.4, 2.1.1].
    - Can only install one of: monolog/monolog[1.25.5, 2.1.1].
    - Can only install one of: monolog/monolog[1.x-dev, 2.1.1].
    - Installation request for monolog/monolog (locked at 2.1.1) -> satisfiable by monolog/monolog[2.1.1].

I just pushed an update to the develop branch that updated monolog. Could you try again?

./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for team-reflex/discord-php dev-develop -> satisfiable by team-reflex/discord-php[dev-develop].
    - Conclusion: remove nesbot/carbon 2.39.0
    - Conclusion: don't install nesbot/carbon 2.39.0
    - team-reflex/discord-php dev-develop requires nesbot/carbon <=2.38 -> satisfiable by nesbot/carbon[1.0.0, 1.0.1, 1.1.0, 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0, 1.15.0, 1.16.0, 1.17.0, 1.18.0, 1.19.0, 1.2.0, 1.20.0, 1.21.0, 1.22.0, 1.22.1, 1.23.0, 1.24.0, 1.24.1, 1.24.2, 1.25.0, 1.25.1, 1.25.3, 1.26.0, 1.26.1, 1.26.2, 1.26.3, 1.26.4, 1.26.5, 1.26.6, 1.27.0, 1.28.0, 1.29.0, 1.29.1, 1.29.2, 1.3.0, 1.30.0, 1.31.0, 1.31.1, 1.32.0, 1.33.0, 1.34.0, 1.34.1, 1.34.2, 1.34.3, 1.34.4, 1.35.0, 1.35.1, 1.36.0, 1.36.1, 1.36.2, 1.37.0, 1.37.1, 1.38.0, 1.38.1, 1.38.2, 1.38.3, 1.38.4, 1.39.0, 1.39.1, 1.4.0, 1.5.0, 1.6.0, 1.7.0, 1.8.0, 1.9.0, 2.0.0, 2.0.0-beta.1, 2.0.0-beta.2, 2.0.0-beta.3, 2.0.0-beta.4, 2.0.0-beta.5, 2.0.0-beta.6, 2.0.1, 2.1.0, 2.1.1, 2.10.0, 2.10.1, 2.11.0, 2.12.0, 2.13.0, 2.14.0, 2.14.1, 2.14.2, 2.15.0, 2.16.0, 2.16.1, 2.16.2, 2.16.3, 2.17.0, 2.17.1, 2.18.0, 2.19.0, 2.19.1, 2.19.2, 2.2.0, 2.2.1, 2.20.0, 2.21.0, 2.21.1, 2.21.2, 2.21.3, 2.22.0, 2.22.0-beta.1, 2.22.0-beta.2, 2.22.0-beta.3, 2.22.1, 2.22.2, 2.22.3, 2.23.0, 2.23.0-beta.1, 2.23.0-beta.2, 2.23.0-beta.3, 2.23.0-beta.4, 2.23.1, 2.24.0, 2.24.0-beta.1, 2.24.0-beta.2, 2.24.0-beta.3, 2.24.0-beta.4, 2.25.0, 2.25.0-beta.1, 2.25.0-beta.2, 2.25.0-beta.3, 2.25.1, 2.25.2, 2.25.3, 2.26.0, 2.27.0, 2.28.0, 2.28.0-beta.1, 2.29.0, 2.29.1, 2.3.0, 2.3.1, 2.30.0, 2.31.0, 2.32.0, 2.32.1, 2.32.2, 2.33.0, 2.34.0, 2.34.1, 2.34.2, 2.35.0, 2.36.0, 2.36.1, 2.37.0, 2.38.0, 2.4.0, 2.4.1, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.6.0, 2.6.1, 2.7.0, 2.8.0, 2.9.0, 2.9.1].
    - Can only install one of: nesbot/carbon[2.17.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.17.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.18.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.19.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.19.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.19.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.20.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.21.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.21.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.21.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.21.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.0-beta.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.0-beta.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.22.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.0-beta.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.0-beta.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.0-beta.4, 2.39.0].
    - Can only install one of: nesbot/carbon[2.23.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.24.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.24.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.24.0-beta.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.24.0-beta.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.24.0-beta.4, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.0-beta.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.0-beta.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.25.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.26.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.27.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.28.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.28.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.29.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.29.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.30.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.31.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.32.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.32.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.32.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.33.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.34.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.34.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.34.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.35.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.36.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.36.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.37.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.38.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.0.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.0.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.1.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.10.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.11.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.12.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.13.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.14.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.15.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.16.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.17.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.18.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.19.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.2.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.20.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.21.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.22.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.22.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.23.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.24.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.25.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.5, 2.39.0].
    - Can only install one of: nesbot/carbon[1.26.6, 2.39.0].
    - Can only install one of: nesbot/carbon[1.27.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.28.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.29.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.3.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.30.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.31.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.31.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.32.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.33.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.34.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.35.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.35.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.36.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.37.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.37.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.2, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.3, 2.39.0].
    - Can only install one of: nesbot/carbon[1.38.4, 2.39.0].
    - Can only install one of: nesbot/carbon[1.39.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.39.1, 2.39.0].
    - Can only install one of: nesbot/carbon[1.4.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.5.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.6.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.7.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.8.0, 2.39.0].
    - Can only install one of: nesbot/carbon[1.9.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.4, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.5, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.0-beta.6, 2.39.0].
    - Can only install one of: nesbot/carbon[2.0.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.1.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.1.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.10.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.10.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.11.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.12.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.13.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.14.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.14.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.14.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.15.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.16.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.16.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.16.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.16.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.2.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.2.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.3.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.3.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.4.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.4.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.5.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.5.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.5.2, 2.39.0].
    - Can only install one of: nesbot/carbon[2.5.3, 2.39.0].
    - Can only install one of: nesbot/carbon[2.5.4, 2.39.0].
    - Can only install one of: nesbot/carbon[2.6.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.6.1, 2.39.0].
    - Can only install one of: nesbot/carbon[2.7.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.8.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.9.0, 2.39.0].
    - Can only install one of: nesbot/carbon[2.9.1, 2.39.0].
    - Installation request for nesbot/carbon (locked at 2.39.0) -> satisfiable by nesbot/carbon[2.39.0].

Installation failed, reverting ./composer.json to its original content.

@davidcole1340 FYI, on a local install I've had no problems with "monolog/monolog": "^1.25|^2.1" and "nesbot/carbon": "^1.21|^2.0" allowing for both "branches" each.

@oliverschloebe  All these attempts have been on completely fresh installs not existing projects so....

Can you try now please?

Awesome :+1:
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 26 installs, 0 updates, 0 removals
  - Installing symfony/options-resolver (v5.1.5): Downloading (100%)
  - Installing mollie/polyfill-libsodium (v1.1.1): Downloading (100%)
  - Installing react/promise (v2.8.0): Downloading (100%)
  - Installing react/event-loop (v1.1.1): Downloading (100%)
  - Installing wyrihaximus/ticking-promise (1.6.3): Downloading (100%)
  - Installing evenement/evenement (v3.0.1): Downloading (100%)
  - Installing react/stream (v1.1.1): Downloading (100%)
  - Installing react/promise-timer (v1.6.0): Downloading (100%)
  - Installing react/cache (v1.0.0): Downloading (100%)
  - Installing react/dns (v1.3.0): Downloading (100%)
  - Installing react/socket (v1.6.0): Downloading (100%)
  - Installing clue/socks-react (v0.8.7): Downloading (100%)
  - Installing ringcentral/psr7 (1.3.0): Downloading (100%)
  - Installing clue/http-proxy-react (v1.5.0): Downloading (100%)
  - Installing react/promise-stream (v1.2.0): Downloading (100%)
  - Installing react/http-client (v0.5.10): Downloading (100%)
  - Installing clue/buzz-react (v2.9.0): Downloading (100%)
  - Installing wyrihaximus/react-guzzle-http-client (4.0.2): Downloading (100%)
  - Installing clue/block-react (v1.4.0): Downloading (100%)
  - Installing wyrihaximus/react-guzzle-psr7 (2.1.2): Downloading (100%)
  - Installing react/datagram (v1.5.0): Downloading (100%)
  - Installing ratchet/rfc6455 (v0.3): Downloading (100%)
  - Installing ratchet/pawl (v0.3.5): Downloading (100%)
  - Installing react/partial (v2.0.2): Downloading (100%)
  - Installing trafficcophp/bytebuffer (v0.3): Downloading (100%)
  - Installing team-reflex/discord-php (dev-develop 8e1c2c9): Cloning 8e1c2c930f from cache
react/event-loop suggests installing ext-event (~1.0 for ExtEventLoop)
react/event-loop suggests installing ext-uv (* for ExtUvLoop)
ratchet/pawl suggests installing reactivex/rxphp (~2.0)
team-reflex/discord-php suggests installing ext-libev (For a faster, and more performant loop)
team-reflex/discord-php suggests installing ext-event (For a faster, and more performant loop)
team-reflex/discord-php suggests installing ext-uv (For a faster, and more performant loop. PHP >=7 only. Preferred.)
team-reflex/discord-php suggests installing ext-libevent (For a faster, and more performant loop. PHP 5 only.)
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Writing lock file
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: fruitcake/laravel-cors
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Package manifest generated successfully.
53 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

Just FYI if you are looking to integrate Discord into a web application you should look at restcord. There is a laravel wrapper for it as well


ptf.Reload() is not working sometimes

after updating, when we do ptf.Reload() it gives some error saying "name 'self' is not defined"

Download the latest version of monk. The issue will be resolved.

ok


Fix remaining kuttl tests "play" fields

These should now be "playbookContents"

Eh, these are the AEE resources we're checking. So it's still play until we fix openstack-ansibleee-operator...


Help with getting portus site to use port 80, and registry port 443 (https)

Hello all,
Can anyone help me (or point me to the right documentation) on how to port forward both the portus site (from 3000 to 80) and the registry (from 5000 to 443), the goal is to have http://dockerhub.domain.com point to the portus site, and https://dockerhub.domain.com point to the registry (for downloading images..etc).
Any help is appreciated,
Fadi
EDIT: At this point of time everything is working fine, however I really don't like it having others to type http://dockerhub.domain.com:3000/ and every time they want to upload/download an image they would have to type dockerhub.domain.com:5000/repo/image .. etc.
EDIT2: My current situation is I have a self signed SSL cert (will that be a problem, I know it'll have to be located in both the registry server and the server where docker engine is installed and trying to download the images from the private registry). But this will change soon so I will have a proper certificate.

I run Portus on 443 and Registry on 5000 -   I put a nginx container in front of the Portus container to handle the 443 to 3000 (and do the SSL termination)

So in my case I would have to run an nginx container infront of the Portus container to handle both 80 to 3000 and 443 to 5000?
I'm still relatively new to nginx and I'm trying to figure out how this can be done. Would it be a bother if I asked you to share your nginx config for your setup? Just so I can see how you've done it and learn/modify it to suit my needs?

@farahfa have a look here https://github.com/SUSE/Portus/issues/667

@farahfa take a look at #667. Thanks @egidijus for stepping in :+1:


Add a minimal 'Minsk.Sdk'

[x] Improved Build/Dev experience

[x] Partial Project System support

[ ] Partial Debugging experience

Depends on #106

#106

This looks cool! Curious where is this going :-)


NETOBSERV-1466 Update eBPF dependency for FLP

Description
See eBPF update https://github.com/netobserv/netobserv-ebpf-agent/pull/275 and followup to remove Duplicate field https://github.com/netobserv/netobserv-ebpf-agent/pull/276
Dependencies
Update go mod once eBPF PR is merged
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[x] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
[x] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[x] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

/lgtm


Add screening outer loop

only a marginal improvement, but it was not very costly to implement.

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   88.31%   88.31%
=======================================
  Files           5        5
  Lines         385      385
  Branches       60       60
=======================================
  Hits          340      340
  Misses         29       29
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca5c90...014f65b. Read the comment docs.


Terminology is not fully compatible with Docusaurus v3

Terminology requires some additional changes to be fully usable with Docusaurus v3

Fully compatible.


Support literal string in structured dtype

Feature request
Details from gitter conversation at https://gitter.im/numba/numba?at=5ee899037c64f31f1163b038
usecase:
import numpy as np
from numba import njit
from numba.types import literal

dt = np.dtype([('attr1', np.float64), ('attr2', np.int64)], align=True)
a = np.zeros(10, dtype=dt)

@njit
def h(a, aname):
    return a[aname]

h(a, literal('attr1'))

traceback:
Invalid use of Function(<built-in function getitem>) with argument(s) of type(s): (array(Record(attr1[type=float64;offset=0],attr2[type=int64;offset=8];16;True), 1d, C), Literalstr)

Numba should expand structured dtype getitem to support literal string.

@sklam there are two compilation passes attempting to convert getitem into static_getitem for structured dtypes. The first one is before inference, so it requires that the index is a constant.
The second pass is after inference, so it should be able to care care of this, but the inference never completes (because getitem fails) and therefore we never reach that compilation pass.
I think @stuartarchibald once told me that the proper solution to all this would be to have constant propagation.
Without that, I guess it could be possible to get getitem to type its return value as a static_getitem if the index is a literal string, in anticipation of the after-inference pass that will make the conversion.


Double quotes to single quotes

Updated double quotes to single quotes in the flashes

Ooops, should have thought about that - thanks for spotting it! The web interface wouldn't find them, so I had to do it by hand and I might have missed some as well...


+       |         |                                |               |
        +       | Krypton |               Kr               |       36      |
        +       |         |                                |               |
        +       | Xenon   |               Xe               |       54      |
        +       |         |                                |               |
        +       | Radon   |               Rn               |       86      |
        +       +---------+--------------------------------+---------------+

        -   Source: Chemistry 101
        +                           Source: Chemistry 101

        +                              The Noble Gases
        +
            The following is a right-aligned table with "full" (but not "all")
            lines between cells.

        @@ -192,7 +199,9 @@
                                                           | Time      |   Mood |
                                                           +-----------+--------+
                                                           | Morning   | Happy! |
        +                                                  |           |        |
                                                           | Afternoon | Happy! |
        +                                                  |           |        |
                                                           | Evening   | Somber |
                                                           +-----------+--------+

        @@ -209,6 +218,14 @@
            Some of the things included in this draft came from Elwyn Davies'
            templates.

        +
        +
        +
        +Smith & Jones             Expires March 5, 2015                 [Page 4]
        +

        +Internet-Draft                 XML Example                September 2014
        +
        +
         9.  References

         9.1.  Normative References
        @@ -218,14 +235,6 @@
                       DOI 10.17487/RFC2119, March 1997,
                       <https://www.rfc-editor.org/info/rfc2119>.

        -
        -
        -
        -Smith & Jones             Expires March 5, 2015                 [Page 4]
        -

        -Internet-Draft                 XML Example                September 2014
        -
        -
         9.2.  Informative References

            [RED]      Floyd, S. and V. Jacobson, "Random Early Detection (RED)

        @@ -234,10 +243,10 @@
                       <http://www.aciri.org/floyd/papers/early.pdf>.

            [RFC6949]  Flanagan, H. and N. Brownlee, "RFC Series Format
        -              Requirements and Future Development", RFC 6949,
        -              DOI 10.17487/RFC6949, May 2013,
        -              <https://www.rfc-editor.org/info/rfc6949>.
        +              Requirements and Future Development", RFC 6949, May 2013.

        +              This is a primary reference work.
        +
         9.3.  URIs

            [1] http://www.ietf.org
        @@ -265,15 +274,6 @@
            Kim Jones

            Email<EMAIL_ADDRESS>        -
        -
        -
        -
        -
        -
        -
        -
        -

      # ./spec/asciidoctor/rfc/v2/text_spec.rb:106:in `block (2 levels) in <top (required)>'
      # ./spec/spec_helper.rb:118:in `block (2 levels) in <top (required)>'

  14) Asciidoctor::RFC::V2::Converter processes draft-iab-html-rfc-bis RFC XML v2 example with equivalent text
      Failure/Error: expect(norm(File.read("spec/examples/draft-iab-html-rfc-bis.xml.orig.txt"))).to eq(norm(File.read("spec/examples/draft-iab-html-rfc-bis.xml.xml.txt")))

        expected: "\n\n\n\n\n\nInternet Architecture Board (IAB)                     J. Hildebrand, Ed.\nRequest for<EMAIL_ADDRESS>& Hoffman          Informational                    [Page 41]\n"
             got: "\n\n\n\n\n\nInternet Architecture Board (IAB)                     J. Hildebrand, Ed.\nRequest for Co...n\n\n\n\n\n\n\n\n\n\n\n\nHildebrand & Hoffman          Informational                    [Page 41]\n"

        (compared using ==)

        Diff:
        @@ -193,8 +193,8 @@
            11.       Introduction
        @@ -1725,7 +1725,7 @@
            <source> element's "anchor" attribute.

            <div class="refInstance" id="RFC5730">
        -   ...
        +     ...
            </div>

        @@ -2174,11 +2174,11 @@

            [RFC7991]  Hoffman, P., "The "xml2rfc" Version 3 Vocabulary",
                       RFC 7991, DOI 10.17487/RFC7991, December 2016,
        -              <https://www.rfc-editor.org/info/rfc7991>.
        +              <http://www.rfc-editor.org/info/rfc7991>.

            [RFC7993]  Flanagan, H., "Cascading Style Sheets (CSS) Requirements
                       for RFCs", RFC 7993, DOI 10.17487/RFC7993, December 2016,
        -              <https://www.rfc-editor.org/info/rfc7993>.
        +              <http://www.rfc-editor.org/info/rfc7993>.

        @@ -2189,17 +2189,17 @@

            [W3C.REC-CSS2-20110607]
        -              Bos, B., A‡elik, T., Hickson, I., and H. Lie,
        -              "Cascading Style Sheets Level 2 Revision 1 (CSS 2.1)
        -              Specification", World Wide Web Consortium Recommendation
        -              REC-CSS2-20110607, June 2011,
        +              Bos, B., Celik, T., Hickson, I., and H. Lie, "Cascading
        +              Style Sheets Level 2 Revision 1 (CSS 2.1) Specification",
        +              World Wide Web Consortium Recommendation REC-
        +              CSS2-20110607, June 2011,
                       <http://www.w3.org/TR/2011/REC-CSS2-20110607>.

            [W3C.REC-html5-20141028]
                       Hickson, I., Berjon, R., Faulkner, S., Leithead, T.,
        -              Navara, E., O'Connor, T., and S. Pfeiffer, "HTML5",
        -              World Wide Web Consortium Recommendation REC-
        -              html5-20141028, October 2014,
        +              Navara, E., O'Connor, T., and S. Pfeiffer, "HTML5", World
        +              Wide Web Consortium Recommendation REC-html5-20141028,
        +              October 2014,
                       <http://www.w3.org/TR/2014/REC-html5-20141028>.

         11.2.  Informative References

        @@ -2218,12 +2218,12 @@

            [RFC7990]  Flanagan, H., "RFC Format Framework", RFC 7990,
                       DOI 10.17487/RFC7990, December 2016,
        -              <https://www.rfc-editor.org/info/rfc7990>.
        +              <http://www.rfc-editor.org/info/rfc7990>.

            [RFC7998]  Hoffman, P. and J. Hildebrand, ""xml2rfc" Version 3
                       Preparation Tool Description", RFC 7998,
                       DOI 10.17487/RFC7998, December 2016,
        -              <https://www.rfc-editor.org/info/rfc7998>.
        +              <http://www.rfc-editor.org/info/rfc7998>.

            [W3C.WD-css3-page-20130314]
                       Grant, M., Etemad, E., Lie, H., and S. Sapin, "CSS Paged
        @@ -2231,7 +2231,7 @@
                       css3-page-20130314, March 2013,
                       <http://www.w3.org/TR/2013/WD-css3-page-20130314>.

        -Appendix A.  Appendix A: IAB Members at the Time of Approval
        +IAB Members at the Time of Approval

            The IAB members at the time this memo was approved were (in
            alphabetical order):

        @@ -2244,34 +2244,22 @@
         RFC 7992                      HTML for RFCs                December 2016

        -   o  Jari Arkko
        +      Jari Arkko
        +      Ralph Droms
        +      Ted Hardie
        +      Joe Hildebrand
        +      Russ Housley
        +      Lee Howard
        +      Erik Nordmark
        +      Robert Sparks
        +      Andrew Sullivan
        +      Dave Thaler
        +      Martin Thomson
        +      Brian Trammell
        +      Suzanne Woolf

        -   o  Ralph Droms
        +Acknowledgments

        -   o  Ted Hardie
        -
        -   o  Joe Hildebrand
        -
        -   o  Russ Housley
        -
        -   o  Lee Howard
        -
        -   o  Erik Nordmark
        -
        -   o  Robert Sparks
        -
        -   o  Andrew Sullivan
        -
        -   o  Dave Thaler
        -
        -   o  Martin Thomson
        -
        -   o  Brian Trammell
        -
        -   o  Suzanne Woolf
        -
        -Appendix B.  Acknowledgments
        -
            Heather Flanangan was an early coauthor of this document and helped
            its formation.  The authors gratefully acknowledge the contributions
            of: Patrick Linskey and the members of the RFC Format Design Team
        @@ -2291,6 +2279,18 @@
            ICANN

            Email<EMAIL_ADDRESS>        +
        +
        +
        +
        +
        +
        +
        +
        +
        +
        +
        +

      # ./spec/asciidoctor/rfc/v2/text_spec.rb:116:in `block (2 levels) in <top (required)>'
      # ./spec/spec_helper.rb:118:in `block (2 levels) in <top (required)>'

Finished in 29.83 seconds (files took 0.46839 seconds to load)
15 examples, 14 failures

Failed examples:

rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:34 # Asciidoctor::RFC::V2::Converter processes RFC 6350 RFC XML v2 example with bibliography preprocessing, with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:39 # Asciidoctor::RFC::V2::Converter processes Davies template with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:44 # Asciidoctor::RFC::V2::Converter processes MIB template with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:49 # Asciidoctor::RFC::V2::Converter processes rfc1149 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:55 # Asciidoctor::RFC::V2::Converter processes rfc2100 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:61 # Asciidoctor::RFC::V2::Converter processes rfc3514 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:67 # Asciidoctor::RFC::V2::Converter processes rfc5841 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:73 # Asciidoctor::RFC::V2::Converter processes rfc748 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:79 # Asciidoctor::RFC::V2::Converter processes rfc7511 from Markdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:85 # Asciidoctor::RFC::V2::Converter processes draft-ietf-core-block-xx from Kramdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:91 # Asciidoctor::RFC::V2::Converter processes skel from Kramdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:97 # Asciidoctor::RFC::V2::Converter processes stupid-s from Kramdown with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:103 # Asciidoctor::RFC::V2::Converter processes Hoffman RFC XML v2 example with equivalent text
rspec ./spec/asciidoctor/rfc/v2/text_spec.rb:113 # Asciidoctor::RFC::V2::Converter processes draft-iab-html-rfc-bis RFC XML v2 example with equivalent text

You're right about leading zero on dates; I was being bloody minded ("it's ISO 8601!"), but of course a separate day attribute is no longer ISO 8601.

We now have a new discrepancy between published RFC documents and the gem: they do not strip out "Working Group" from Working Group names. Could you confirm that we should be stripping it out?  This looks odd:
        Network                                                      S. Bellovin
        Internet-Draft                                        AT&T Labs Research
        Intended status: Informational                             April 1, 2003
        Expires: October 3, 2003

Re dates: in fact, it's the published specs that are inconsistently adding leading zeros on their dates, not the gem.

Done some tweaks to rspec, but a lot of these have resisted patching up.

We should keep the "Working Group", maybe use preprocessing to scrub them before testing equivalence. For example, this one gives out "Network Working Group" (https://tools.ietf.org/id/draft-iab-xml2rfc-04.txt). However, published RFC (not Internet-Draft) does not show the "Working Group" at all, e.g., (https://tools.ietf.org/html/rfc7991).

Dates, perhaps we could also preprocess them away. We don't want to spec the differences between xml2rfc versions.

Maybe we should find a way to patch those specs so that they all pass now, and future changes will alert us of future problems.

"Working Group": I'll issue a warning: "suffix Working Group will be stripped in published RFC".

@opoudjis re: Working Group, I've run into another issue regarding IRTF documents.
Technically, "IRTF" documents should have "submission-type" "IRTF", and "workgroup" the name of an IRTF working group. However, the list of working groups now don't include them.
IRTF Groups can be found here: https://irtf.org/groups .  We should accept abbreviations and also the full names of them.

Mitigated, down to 7 docs with issues from 12.

Awesome. The other part of the failures on Travis stem from:
       No such file or directory @ rb_sysopen - spec/examples/rfc6350.xml.txt.1

I feel that this is because of the lack of xml2rfc installed?

Rspec is now running, which it didn't seem to be doing before the way I was reading it. I think some of the intractable files, I will just have to remove from rspec, but let's leave this ticket open.

I will take 6350 out; it's just more trouble than it's worth in the RSpec context, and the points it was seeking to prove have been proven elsewhere.

Patching the remainder one file at a time, emending their XML to match.

Down to 1

Oh my, you're a magician 😉
The remaining one is interesting regarding the "Appendix" bits. Our gem is doing better than the original which scrambles up the accents!

In retrospect: a lot of these were me insisting on the "right" way of marking them up rather than the way they actually marked them up. The last one actually uses illegal v3 attributes in a v2 context, and I've also had to deal with preambles/postambles, which are impossible in Asciidoc for tables, and idiosyncractic additions of blank lines in definition lists.

The problem appears to be with UTF-8 being mangled on https://xml2rfc.tools.ietf.org/public/rfc/bibxml4/reference.W3C.REC-CSS2-20110607.xml . I can't change the encoding on that page to do anything reasonable with Çelik or Håkon. This needs to be brought to the attention of the IETF: @ronaldtse ?
The fact that the XML output is deliberately in US-ASCII (to force UTF-8 characters to be output as entities) will get in the way of UTF-8 includes; but these are not in UTF-8; they are corrupted out of the box.

In fact (to their shame) the original file dealt with this by simply stripping the diacritics from the reference. I will sidestep this by using a non-canonical anchor for the reference; but this is a bug on the IETF's side, and they need to fix it.

In addition, bug report for xml2rfc: it is not dealing with  the ' in <author initials="T." surname="O'Connor" fullname="Theresa O'Connor"> in https://xml2rfc.tools.ietf.org/public/rfc/bibxml4/reference.W3C.REC-html5-20141028.xml

All rspec issues patched, but waiting on word about the https://xml2rfc.tools.ietf.org/public/rfc/bibxml4/ encoding issues.

@opoudjis agree we should report the BibXML encoding issue to the IETF, but at this point it's not very clear who is actually responsible for them. Let me try to find out.
In our specs, we can temporarily hide this issue using "pending" first, with an issue to re-enable it later?

Spec is hiding it with a patch, but I will put an issue in to reenable.

@opoudjis let's close this then since the specs are passing 👍


Show an error for path data that contains errors

In the property inspector, since you can manually enter path data, show an error when there's a problem parsing the path data

Showing an error when attempting to animate between two incompatible paths would be nice too.

Currently entering an invalid path just reverts back to the previous value. An error state of some kind would be nice.


Please add jar files shaded with all dependencies in the releases section.

I'm tired of maven projects with has errors like this:
[INFO] -------------< com.binance.dex.api:binance-dex-api-client >------------- [INFO] Building binance-dex-api-client 1.1.2 [INFO] --------------------------------[ jar ]--------------------------------- [WARNING] The POM for org.ethereum:ethereumj-core:jar:1.12.0-RELEASE is missing, no dependency information available [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time:  0.845 s [INFO] Finished at: 2021-11-28T07:03:15+01:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal on project binance-dex-api-client: Could not resolve dependencies for project com.binance.dex.api:binance-dex-api-client:jar:1.1.2: org.ethereum:ethereumj-core:jar:1.12.0-RELEAS>[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Adding jar files in the Releases will solve this problem.

We need an update on this. as it stands now, the binance-java sdk is unusable as it won't compile due to the bintray-site where the ethereumj-core jar-file is hosted has been taken permanently down (in May!). Please do something about this.

<repository>
            <id>jcenter</id>
            <url>https://maven.aliyun.com/repository/public</url>
        </repository>

add repository to pom

I add this code where?

In reality this whole thing should be updated to use newer versions?

ok, adding repo seems to have worked, but I jhave my sincere doubts if it's safe.

still no aswner, nice support

oh my bad didn't seen, can you give me the jar files with all depends ?
i'm tired of using maven, i want to add to classpath manually.


Register multiple callback functions

Based on Ben's suggestions this morning, I will volunteer for the task of adding a registerEventCallback and maybe a registerDrawCallback function to VRMain() and then do a pull request with a proposal.

Closed this, it's already added in VRMain.


Remove highchart.js dependancy

highchart.js is the lib that take the most weight on the app. We should change it with an image generated or remove it.

Perhaps with smaller image and always visible like this:

I think its pretty valuable seeing a breakdown of the price charts throughout the week, by removing the dependency and refactoring the chart, we won't see that anymore.


Support additional parameters in the OIDC outbound token request

Is your suggestion related to an experience ? Please describe.
Azure AD B2C V2 APIs have mandated the scope parameter in the token request [1] even though the scope is not even mentioned in the spec [2] for the token request.
Currently, we do add the following parameters only in the token request and there is no option to add any additional parameters. Ref [3].

grant_type
code
redirect_uri

Describe the improvement
It would be great to allow adding additional parameters to the token request as well.
[1] https://docs.microsoft.com/en-us/azure/active-directory-b2c/authorization-code-flow#2-get-an-access-token
[2] https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.3
[3] https://github.com/wso2-extensions/identity-outbound-auth-oidc/blob/86ded4dd136737faa7eb6e39bd269318474a58c5/components/org.wso2.carbon.identity.application.authenticator.oidc/src/main/java/org/wso2/carbon/identity/application/authenticator/oidc/OpenIDConnectAuthenticator.java#L650-L654

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix some typos and wording

Fixed some small typos errors and clarified some wording.

Current coverage is 89.13% (diff: 100%)

Merging #1 into master will not change coverage

@@             master         #1   diff @@
==========================================
  Files             4          4
  Lines            92         92
  Methods           0          0
  Messages          0          0
  Branches         14         14
==========================================
  Hits             82         82
  Misses            5          5
  Partials          5          5

Powered by Codecov. Last update f627ec1...ba72665


Use soundfile for audio input

instead of scipy.io.wavfile (only WAV)
soundfile provides more formats (WAV, FLAC, AAC)
also possibly support MP3, M4A

Ready in 18edb81.

libsoundfile doesn't support MP3 (maybe try sox), M4A is not working as well.


old notebook flashes during load

to reproduce:

run fresh beaker
open the main tutorial
click on JavaScript to open that tutorial
click on logo to return to start page
click on "tutorial" in the list

notice the page returns to the JS tutorial and display that until the main tutorial loads.
this is a regression.

related? https://github.com/twosigma/beaker-notebook/issues/2406

I've checked and it's not related to #2406.


Provides weight support for global fonts.

Provides weight support for global fonts.

Zhou, I appreciate your attention to detail and your commitment to improving this theme.
In my free time, my open-source projects are primarily focused on developing plugins for Obsidian, I'm still open to suggestions for significant improvements to the MagicUser theme.
If you have any ideas for major features, usability enhancements, or critical bug fixes, please feel free to submit them as issues (please one issue per suggestion or bug).
Thank you for your understanding and support.


ISPN-5371 Cache.putAll doesn't work properly when combatibility is

enabled

Added in code for type converter
Added in proper decorator method for remote putAll invocation

https://issues.jboss.org/browse/ISPN-5371

Integrated, thanks Will!
EmbeddedHotRotCacheListenerTest is now fixed, but ExpirationIT looks unrelated.


using cld2-cffi instead of pycld2

Hi,
I've made a few small changes to use cld2-cffi (which seems to be actively maintained) instead pycld2 (last update 2018).

@redsk looks great, love the idea of switching to something that is still (probably?) being maintained. Just one tiny suggestions for you to approve and commit, then I'll merge.


Custom MethodCallConverter expression.Object is null

I want to be able to run a select statement as part of an update trigger, in this case COUNT the number of rows when a change has been made and write this to an audit table. I am attempting to write a MethodCallConverter but I am not having much luck. My structure looks something like this:
public class TypeConfiguration :	IEntityTypeConfiguration<AuditableThing>
{
	public void Configure(EntityTypeBuilder<AuditableThing> builder)
	{
        builder
			.AfterUpdate(trigger => trigger.Action(action => action.Insert((previous, next) =>
				new AuditEntry
				{
					Total = next.Rows.Count(),
                    TotalX = next.Rows.Count(x => x > 1),
				}
			)));
    }
}

public class CountConverter : MethodCallConverter
{
	public override SqlBuilder BuildSql(BaseExpressionProvider provider, MethodCallExpression expression, Dictionary<string, ArgumentType> argumentTypes)
	{
		Debugger.Launch();
		// Generate SQL for arguments, they can be SQL expressions
		var argumentSql = provider.GetMethodCallArgumentsSql(expression, argumentTypes)[0];

		// Generate SQL for this context, it also can be a SQL expression
		var sqlBuilder = provider.GetExpressionSql(expression.Object, argumentTypes);

		// Combine SQL for object and SQL for arguments
		// Output will be like "thisValueSql LIKE 'passedArgumentValueSql'"
		return new(sqlBuilder.AffectedColumns, $"(SELECT COUNT(1) FROM ??? WHERE )");
	}

	public override string MethodName { get; } = nameof(Enumerable.Count);
	public override Type ReflectedType { get; } = typeof(Enumerable);
}

provider.GetMethodCallArgumentsSql(expression, argumentTypes)[0] yields System.ArgumentNullException: 'Value cannot be null. Arg_ParamName_Name' and provider.GetExpressionSql(expression.Object, argumentTypes) yields System.ArgumentNullException: 'Value cannot be null. Arg_ParamName_Name' do you have any advice or pointers on how to implement this?
Many thanks

LINQ expressions support is more complex than described in the documentation of method call converters. I added support of Count and Count with a predicate on the related entity in the latest library version.


PiHole (unbound) + PiVPN breaks DNS

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[x] The issue I am reporting is directly related to the pivpn installer script.
[x] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Describe the bug
PiVPN + PiHole (with unbound) breaks DNS server.
I can SSH into my PI, access my router's dashboard, but not http://pi.hole/.
To Reproduce
Steps to reproduce the behavior:

Setup PiHole with unbound
Run the PiVPN installer
Connect to PiVPN using OpenVPN CLI

Expected behavior
It should use unbound DNS server from the PI. And be able to access http://pi.hole/ without problems.
Solution:
Solved using this post: https://github.com/pivpn/pivpn/issues/721
I just ran the command sudo nmcli connection import type openvpn file your_vpn.ovpn, and connected. After that everything worked!
Desktop (please complete the following information):

OpenVPN 2.5.1
OS: Arch Linux

Additional context
The KDE plasma network applet doesn't like me using OpenVPN CLI, (after some time) it says it can't reach the internet. But I can SSH into my PI, access my router's dashboard etc.. tho.
If I use KDE plasma's network applet to connect, I get the following OpenVPN (on my PI) logs:
Apr 14 14:10:34 raspberrypi ovpn-server[637]: tls-crypt unwrap error: packet too short
Apr 14 14:10:34 raspberrypi ovpn-server[637]: TLS Error: tls-crypt unwrapping failed from [AF_INET] IP:51559

Everything works fine on my (android) phone when using the OpenVPN app.
Note: my (android) phone uses google DNS servers, and I haven't found any way to point it at the PI (yet) without breaking DNS on my phone.

Solved using this post: https://github.com/pivpn/pivpn/issues/721
I just ran the command sudo nmcli connection import type openvpn file your_vpn.ovpn, and connected. After that everything worked!


Update to use renamed kernel name 'jupyterllm' -> 'beaker'

Renaming "jupyter-llm" to "Beaker" to match the external name change.

ill need to do some tests once all the PRs are merged around this name change


Disappearance animation not working

After setting an attributed string of some lines, and calling the start disappearance, it does not do anything, or in some cases it suddenly disappears without animation.
How can I get the same start appearance animation but for the out / aka make start disappearance work :) ?
Thanks! Awesome pod

Depending on which label you are using, not all of them has implementation for disappearance, you can implement your own.

default

Default ZCAnimatedLabel disappearance animation should work fine, can you show snippets of your code?  Let me try to narrow down the issue.


Problem with PDF files

Hi, first - I love the idea for that Plugin - it's really outstanding and life changing. I encountered a problem however when trying to extract the Markdown from PDF - unfortunately it the files don't look good - either from a website saved as PDF or publications downloaded directly from the websites. The text looks weird and us usually unreadable. I would love to use the tool, but either I may need some help to configure it, or maybe there are some bugs. I am attaching files I tried to convert.
g_P_202207.pdf
g_E_202207.pdf

Hi,
I had a quick look at these. I suspect the issue is that they are design-heavy (I had similar issues with other reports). At best what you'll likely get it just text extraction, without even guarantees that blocks of text follow in the right order (PDFs do not indicate reading order).
I plan to do some more testing over the next month, I'll test with these files too and see if anything better can be done with them. In general the plugin will work better with e.g. journal article text (less images, and more importantly, less text design elements).


chef-backend-crashing

Expected Behavior

Current Behavior

My organization has moved to chef HA.  We are running 3 chef backend servers.  They are running on virtual machines.  And this is our development environment.  After a couple of weeks the chef servers crash.  To get them back, we have to recycle all the backend servers.  When we get into this situation, here is the some of the output.
Service        Local Status         Time in State   Distributed Node Status
leaderl        running (pid 22080)  27d 9h 51m 38s  leader: 0; waiting: 3; follower: 0; total: 3
epmd           running (pid 22135)  27d 9h 51m 37s  status: local-only
etcd           running (pid 22137)  27d 9h 51m 37s  health: green; healthy nodes: 3/3
postgresql     down                 0d 0h 10m 27s   error: could not reach pgsql leader for replication stats
elasticsearch  running (pid 5758)   7d 10h 30m 21s  state: green; nodes online: 3/3
System  Local Status                                          Distributed Node Status
disks   /var/log/chef-backend: OK; /var/opt/chef-backend: OK  health: green; healthy nodes: 3/3
And all the servers are waiting someone to become the leader.  We have all followers.
What do I need to fix the issue?  What do I need to do the next time this occurs to gather information?
Steps to Reproduce (for bugs)

It just seems like time for us.  Not sure why.  That is where I need the help.

Your Environment

Chef Server Version: chef-backend-1.4.6-1.el7.x86_64
Total/free RAM and disk space: RAM - 8 GB disk - nothing that looks like it is out of space
Operating System and Version: Oracle Linux Server release 7.3
If upgrading, previous Chef Server version:
Running in a container?

Hi,

To get them back, we have to recycle all the backend servers.

By recycle the leader do you mean that you rebuild them all?  If so, Have you tried chef-backend-ctl force-leader on the previous leader node instead?
In terms of the root cause, your best bet is to open a support ticket when they go down next time.  (This is the bug tracker for open source chef-server. Chef Backend is a commercial product that is supported via Chef Support).
That said, the first step would be to figure out why they are getting into the waiting for leader state.  The log for the leaderl service is in /var/log/chef-backend/leaderl/current.  Unfortunately, this log can be very noisy.
There is also the chef-backend-ctl gather-logs command that will put together a tarball of logs and other data that can help diagnose the issue.
I can tell you hat the main causes we see for failure of chef-backend current is related to disk performance.  etcd, the underlying consensus system seems very sensitive to increased disk latency.  The gather-logs output includes output from the etcd stats endpoint that can help diagnose that as well.

Thank you for the quick response.  I will open the ticket with chef support.  I also appreciate all the information that you gave me.


feat: add pointcloud divider

Description

Added pointcloud_divider
Added block reading to read a fixed number of points from PCD files, instead of reading the whole PCD to the memory. This helps reduce the amount of main memory needed when dividing large PCD files.
Added a custom voxel grid filter, which performs filtering as points keep coming, instead of distributing all points to voxels then computing centroids. Since this filter does not hold points, it reduces the memory consumption.

Tests performed

Input PCD: 5.1GB
Divide (to grids of 20x20m) and downsample (resolution 0.2m)
Divide (to grids of 20x20m), downsample (resolution 0.2m)
Verified that the peak memory is around 3GB (the MapIV pointcloud_divider has the peak memory around 21GB)

Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.
[x] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.
[x] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@anhnv3991 Please add a package.xml file

@YamatoAndo

@anhnv3991 Please add a package.xml file

this package is built by cmake only, so is that package.xml file really necessary?

this package is built by cmake only, so is that package.xml file really necessary?

Yes, please.
It is necessary to specify who the maintainer.

@anhnv3991 Could you please fix errors on pre-commit.ci?

@YamatoAndo @SakodaShintaro I created a new PR to add both pointcloud divider and merger to autoware tools. All problems are addressed in that PR. I will close this PR now since it is no longer necessary.