MDTextField mode='rectangle' bug

Description of the Bug
If u don't wanna read description of the bug or u don't understand me, see this video(https://yadi.sk/i/yhY1Wcz6L90nAw), all bugs were shown in this video
I have a code that located below.
At first, i edited field's text to 'hhh' and pressed on my button, as the result, i got new normal text of my field, however when i clicked on my field, line of field intersected field's hint_text like in 4-th screenshot.
But after that, i had held backspace until field's text is equal to empty string(''), and then i pressed on my button.
And after that i got a strange behavior. See the first and the second screenshots  below.
That's first part of my report.
Second part:
I made all actions from first part and changed field's text from "New text" to "New tex" and pressed on my button, as u can see on the 3th screenshot, i got normal behavior without any bugs, but  after that i pressed on my field and i got strange line of my field that intersects with field's hint text, see screenshot 4
Code and Logs
from kivy.lang import Builder
from kivymd.app import MDApp

KV = '''
Screen:
    MDRaisedButton:
        text: 'update field text'
        pos_hint: {'center_y': .5, 'center_x': .5}
        on_release: app.change()
    MDTextField:
        size_hint: .7, .1
        mode: "rectangle"
        id: field
        text: ''
        hint_text: 'Bug'
        pos_hint: {'center_y': .7, 'center_x': .5}
'''

class Test(MDApp):
    def change(self):
        self.root.ids.field.text = 'New text'

    def build(self):
        return Builder.load_string(KV)

Test().run()

Screenshots

Versions

OS: win10
Python: 3.7
Kivy: last version
KivyMD: master branch

Almost same as #571. Same solution will work.


[Feature Request]

Hello everyone, it is sad but dbt-expectation package does not work with dbt-trino adapater, at least for me. is there anyone who tried to do the data quality tests with dbt-trino and dbt-expectations? Could you please implement that important feature for dbt-trino

Hi, we don't have a way to set up automated testing during CI for trino, so we will not be supporting trino at the moment.

Trino is supported since https://github.com/calogica/dbt-expectations/releases/tag/0.10.3.


issue-forms

Proposed Changes
Add support for issue-form in the leaderboard repository to track feedback and bug reports from other organizations. This involves creating a folder .github/ISSUE_TEMPLATE and adding two types of forms:

Feature Request: feature-request.yml
Technical Visual: technical-visual.yml

Description
This PR addresses the need to streamline the feedback and bug reporting process by implementing issue forms within the repository. By introducing structured templates for different types of issues, such as feature requests and technical visuals issues, we aim to gather comprehensive information from users and stakeholders.
Changes Made

Added .github/ISSUE_TEMPLATE folder.
Included two YAML templates: feature-request.yml and technical-visual.yml.

Resolved Issue
Fixes #433

Also, it'd be great if you could give a more meaningful title for your PRs 😄

https://tailwindui.com/components/marketing/sections/footers


[bug] introduce a new pinocchiodata for finite differencing. maintain the sanctity of the forward pass

In GitLab by @proyan on Nov 2, 2018, 04:47
Currently during backward pass the pinocchioData is being changed because of the finite differences.

In GitLab by @proyan on Nov 2, 2018, 05:17
mentioned in merge request !12

In GitLab by @cmastalli on Nov 15, 2018, 12:26
unassigned @rbudhira

In GitLab by @cmastalli on Nov 15, 2018, 12:31
We need to solve first the #21 task.

In GitLab by @cmastalli on Dec 7, 2018, 21:06
Finite differentiation doesn't needed to affect the values if it's properly done. Furthermore we want to support abstraction for NumDiff. Here you can see an example of NumDiff abstraction for general systems where the last step computes the values in the current state and control (https://gepgitlab.laas.fr/loco-3d/cddp/blob/devel/cddp/dynamics/dynamics.py#L167). With this we don't affect forward passes.
I believe this issue isn't any-more important. I will close it, however feel free to open it.
PD: This NumDiff abstraction is used in few unit-test (see https://gepgitlab.laas.fr/loco-3d/cddp/blob/devel/unittest/dynamics.py)

In GitLab by @cmastalli on Dec 7, 2018, 21:06
closed


docker-compose - first attempt

Steps to reproduce
Cloned repo and tried to use the instructions from here  https://weacast.github.io/weacast/guides/basics.html#installing
Just simply run the docker-compose commands (so avoid any source installation), and have a quick demo on the app.
Expected behavior
Should start the server and mongo docker images and work (based on the doc)
Actual behavior
The API docker container is showing this error:
>> docker logs 88d

><EMAIL_ADDRESS>prod
> cross-env NODE_ENV=production node src/main.js

WARNING: NODE_ENV value of 'production' did not match any deployment config file names.
WARNING: See https://github.com/lorenwest/node-config/wiki/Strict-Mode
info: Logger configured
Warning: connect.session() MemoryStore is not
designed for a production environment, as it will leak
memory, and will not scale past a single process.
(node:25) [MONGODB DRIVER] Warning: Current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.
(Use `node --trace-warnings ...` to show where the warning was created)
info: Initializing weacast-gfs plugin
info: Initializing gfs-world forecast
info: Installing forecast update on gfs-world with interval (s) 900
error: Can not find service 'api/arpege-europe/u-wind'
info: Configuring HTTP server at port 8081
info: Server started listening
/opt/weacast-api/node_modules/@kalisio/feathers-distributed/lib/index.js:292
  if (app.distributionOptions.publishEvents && serviceDescriptor.events.length && !service[EVENT_LISTENER_KEY]) {
                                                                        ^

TypeError: Cannot read properties of undefined (reading 'length')
    at publishService (/opt/weacast-api/node_modules/@kalisio/feathers-distributed/lib/index.js:292:73)
    at /opt/weacast-api/node_modules/@kalisio/feathers-distributed/lib/index.js:316:7
    at Array.forEach (<anonymous>)
    at Timeout._onTimeout (/opt/weacast-api/node_modules/@kalisio/feathers-distributed/lib/index.js:315:46)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)
npm notice
npm notice New minor version of npm available! 8.11.0 -> 8.19.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
npm notice Run `npm install -g<EMAIL_ADDRESS>to update!
npm notice

System configuration
Ubuntu 22.04.1 LTS
Docker Compose version v2.5.1
Docker version 20.10.19, build d85ef84

Hi @jemacchi and thanks for feedback, as we recently moved to a monorepo project and also moved the demo application in a new repository some changes remain to be done in documentation. This section of the documentation actually refers to docker compose files you will find here https://github.com/weacast/weacast-app. I will update the doc accordingly.
However the error you have in the API is still strange, just like if a wrong version of the feathers-distributed dependency has been installed. I will have a look to the docker build.

In the meantime if you still have problems you can try to use the images with the dev tag and related docker compose files, which are current master and seems to work fine on my side.

hi @claustres, thanks for quick response.
Cloning https://github.com/weacast/weacast-app.git and just running the docker-compose up -d command worked (with the latest tag). Thanks ! Great job! I will continue checking updates on project ! (as much as trying to catch up on coding side)


Black screen in main page

I'm using below configuration:
IDE: Android studio 3.5
Branch: latest master branch after commit #https://github.com/simonnorberg/klingar/commit/e5be6bac771f9145a32056a5577e66888a88b40c was merged.
Device: Emulator 6.0

The app always shows blank screen like above screenshot. It seems observer onNext and onError isn't called

Could you help me what should I do to show the content instead?

Is Remote Access enabled in your Plex server?

I see. I don't have my own Plex server. I thought the API itself is provided by the developer(in this case you as the developer), therefore any developers who downloaded or cloned this repo could run and test this app easily. BTW, is there a way to open and give access a Plex server to developers who wants to run and test the app, @simonnorberg ?

No, Klingar is just a client. How you get access to a Plex server is up to you.

Thanks in advance @simonnorberg


isEquals(null, null) throws error

https://github.com/amplitude/experiment-js-client/blob/bf3f5c39f7171fa280b35d1eca9d173b7d426a4f/packages/analyticsConnector/src/util/equals.ts#L2
In my case, Amplitude-Typescript calls this function with null for userId (even though it was initialized with undefined)

Hi @krasnoperov, which version of the analytics SDK are you using?

I think this was already solved here? https://github.com/amplitude/experiment-js-client/issues/41


add Gentoo support

Create default configuration directory /etc/haproxy, gentoo portage does not create it

Sorry about taking so long to get back to you. Thanks for the commit, could you please update the metadata to reflect your change, also could you squash your commits.

Hi There
It would be appreciated if you could do a rebase
Thanks!

closed with  #179. Thanks for the work you put in.


Figure out where to place approveBudgetAndFund() call

I suggest these calls go at the very edges of the current whimsical diagram (i.e. right before USER CLICKS START DOWNLOAD and right before USER SELECTS FILE TO UPLOAD). We don't let the user progress unless the API call resolves successfully. We allow the wallet to handle all of the UI around budgets, explaining the ledger connection to the hub, and so on.
Once this connection has been successfully set up, when we later call createChannel etc (n times), the wallet will be able to virtual fund these channels,.


Strange connection bug when creating from template

While in a demo today, extra connections were made from a template that we didn't expect. We created from the "described grid" template. Ill investigate why that happened.
I believe relationships between components were not removed correctly and so they were set up immediately again when the component was added.

THis was observed in phet-creator-sims > electric-field-hockey project.

I can reproduce this pretty easily by doing this:

Create a new project
Create the "Described Grid" template.
Delete the "Movable Cupcake" and "Movable Object" programs.
Create the "Described Grid" template again.

There will now be two "Bounds" programs and BOTH will have connections to the "Movable Object" program. That is not correct, only the newest "Bounds" program should have any connections.

Fixed in the above commit. Deleting a program actually did not remove components from the CreatorModel components lists. I am actually surprised that this didn't manifest in bigger problems.
Lets add some unit tests for this before closing.

Done and merged into main.


toggle show/hide annotations with biogrid HTP tag

I just noticed that biogrid has tags for HTP/LTP
could we implement the ability to toggle known HTP off? Think that would be appreciated (lots of people moan about it, especially the GI dataset)
eg.
https://thebiogrid.org/278036/summary/schizosaccharomyces-pombe/mms19.html

More or less all the interactions in Chado now have a HTP/LTP flag so we now have this information for all interactions.

could we implement the ability to toggle known HTP off?

Perhaps we could have a filter drop-down like we do for the ontology annotation?
 Filter: [Throughput type...]

or
 Filter: [Throughput type...]   [Evidence...]

That would be very useful! and popular!

Great.  I don't think it will take long to implement.

we should announce this when available, I've had many people say that the more unwieldy lists are annoying

Should we do this soon?  It would take a day or so to implement I think.

Yes please, when you have time.

In the survey comments:
In the publication section separate sections for high throughput and other publications (e.g. some publications show for all genes making it slower to find relevant publications)

Yes please, when you have time.

OK.  I'll have a go in the next week or two.

related user comments

I previously found all of candidate interactors analyzed by LC-MS/MS are listed as "physical interactor". I need a check & correction system (or please clearly show how to correct such unreliable information).

update protein localization (some are incorrect)

[ ] when we announce this we should also let  people know that
i) we can filter HTP GO annotation that is incorrect if people let us know (only 1 dataset)
ii) thresholds for inclusion of physical interaction data can be improved

clear publications of large scale data papers that are present in the reference list for all genes (Hayles, Carpy, Marguerat) and add relevant papers for other organisms

(I don't understand the second part? ,but this will satisfy the first part)

and another from column BQ

Filter out irrelevant physical and genetic interactions

protein localization information needs improve

(this is due  to HTP data which needs removing. I have filtered lots of FP's already)

clear publications of large scale data papers that are present in the reference list for all genes

we sort of have a workaround for this by allowing sorting on number of genes, but maybe this is not clear to everyday users

also...references are references....not a lit review - odd to have a 'filter'?

sorting is fine...

clear publications of large scale data papers that are present in the reference list for all genes

Yes but I by extrapolation that they are more bothered about the individual annotation filter since they clearly know which papers in the reference list they aren't interested in.

I've had a go at adding a high/low through filter for the interactions.  Could you try it out?

Looks good

Is there any point in adding an evidence filter on the interaction sections?  It would be quite quick to implement.

This is what you have done? ;)
But we do want it to be added to other sections now it is working. Could be on phenotype, GO,  & expression

This is what you have done? ;)

I'm confused.  There is only a filter for throughput at the moment not evidence.

But we do want it to be added to other sections now it is working. Could be on phenotype, GO,
& expression

There is an evidence filter for phenotype if you click "Show details ...".
I thought that we decided that filtering by evidence wasn't useful for GO?  It only requires a bit of configuration to add it.

Ah right, I misread.
I don't think filtering on individual evidence is so useful for GO (the users might think it is but it isn't). Filtering  on HTP  vs low throughput could be useful though, if you know you are looking for ' gene specific' studies, it could get rid of a lot of the annotations.
I think all data types a HTP vs LTP experiments would be useful just as a way to reduce the annotation nubmer if you are looking for something specific (users will usually know if the data they are looking for is  HTP or LTP).

I think all data types a HTP vs LTP experiments would be useful just as a way to reduce the
annotation nubmer if you are looking for something specific

So add a HTP/LTP filter for modifications, GO and expression?  Are there other data type where it makes sense?

I think we could have it for phenotypes too. Its a useful way to reduce annotation numbers if you know your phenotype of interest could not be generated via a screen.

I forgot phenotypes.  :-)
I'll have a go at this soon.  There's a small chunk of code that needs adding to enable a throughput filter for ontology annotations.  Once that's added we can add the filter to any ontology annotation section using the config file.

All the ontology annotation sections now have a throughput filter. You need to click on "Show details ..." to see it.

Looks good...


nRF52840 DK: -DOT_BOOTLOADER=USB produces non-bootable image

Hi, I'm busy dusting off the Fanstel port I did quite some time back, and noticed that my code would not boot if I built it with -DOT_BOOTLOADER=USB as is normal practice.  If I omitted this flag, I could run the OpenThread firmware as normal, but not flash the device by any means other than JTAG.
We're using these devices as RCPs, but I suspect the same issue applies to NCP and CLI builds as well.
I've grabbed a standard Nordic dev board, nRF52840 DK (PCA10056), and tried building the current ot-nrf528xx both with and without -DOT_BOOTLOADER=USB.
commit 5a4790347edddb4da95c0894fa6b4c0bafa2d66d (HEAD -> upstream/master, origin/upstream/master, origin/develop, develop)
Author: dependabot[bot]<EMAIL_ADDRESS>Date:   Mon Aug 12 09:51:02 2024 -0700

    submodule: bump openthread from `6771761` to `df757ba` (#864)

    Bumps [openthread](https://github.com/openthread/openthread) from `6771761` to `df757ba`.
    - [Commits](https://github.com/openthread/openthread/compare/67717618b79d609561b5485bd73a273fde2db547...df757ba0cf3405e5d36538f3c774500a08ff366e)

    ---
    updated-dependencies:
    - dependency-name: openthread
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>    Co-authored-by: dependabot[bot]<EMAIL_ADDRESS>
Compiler information
$ arm-none-eabi-gcc --version
arm-none-eabi-gcc (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24)) 12.2.1 20221205
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Hardware set-up:

nRF52840 DK (PCA10056) with both USB interfaces connected to a common USB hub into the workstation
nRF power source set to VDD
nRF ONLY switch set to default
power switch set to ON

Building with USB boot-loader enabled:
Command: ./script/build nrf52840 USB_trans -DOT_BOOTLOADER=USB
⇒ firmware image loads (via nRF Connect) but then on reset, the MCU fails to enumerate as a USB device
Building without a boot-loader
Command: ./script/build nrf52840 USB_trans
⇒ firmware image loads, and a new CDC-ACM device appears
Kernel logs observed on reset:
Aug 15 16:01:20 LPA075 kernel: [23975.752812] usb 3-6.4: new full-speed USB device number 65 using xhci_hcd
Aug 15 16:01:20 LPA075 kernel: [23975.975426] usb 3-6.4: New USB device found, idVendor=1915, idProduct=cafe, bcdDevice= 1.00
Aug 15 16:01:20 LPA075 kernel: [23975.975445] usb 3-6.4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
Aug 15 16:01:20 LPA075 kernel: [23975.975448] usb 3-6.4: Product: nRF528xx OpenThread Device
Aug 15 16:01:20 LPA075 kernel: [23975.975452] usb 3-6.4: Manufacturer: Nordic Semiconductor
Aug 15 16:01:20 LPA075 kernel: [23975.975454] usb 3-6.4: SerialNumber: F40D69648880
Aug 15 16:01:20 LPA075 kernel: [23975.978857] cdc_acm 3-6.4:1.0: ttyACM1: USB ACM device

Not quite sure what I'm doing wrong, but it seems there's a step missing that wasn't needed before.

Hello,
If I understand correctly, what you described is expected behavior.
The OT_BOOTLOADER flag simply instructs the linker where to place the application. The NRF52840 DK does not have a bootloader flashed, so the application does not boot. This option was primarily created for the nRF52840 Dongle, which has a USB bootloader flashed in the factory. If you want to run it on the DK, it is certainly possible, but you need to build and flash the USB bootloader first from our legacy nRF5 SDK using JTAG.

Right, so the OpenThread instructions do not link to any instructions for flashing a boot-loader, and reading the Nordic Semiconductor SDK docs, it isn't clear how one does so.
I expect a nRF52840 IC bought off-the-shelf is unlikely to have such a bootloader flashed into it: that is something that needs to be done after it is soldered onto a PCB.  I'm in the situation of trying to get OpenThread RCP firmware onto a (third-party) nRF52840 dongle that seems to be missing its bootloader.
I'm also observing that the current OpenThread code when flashed onto some Fanstel USB840X dongles, refuses to boot.  My suspicion is that the bootloader on these is an older release that is not compatible with the current OpenThread builds -- replacing this with a later release may fix the problem.
I did find a hexdump for a bootloader in amongst the SDK files, however it uses regions that overlaps with those of the OpenThread build, so they're unable to be flashed together, it's not clear what needs to change.
Is there a particular guide I should be following for an OpenThread-compatible bootloader on the nRF52840?

@sjlongland if you are developing a new product, please note that this repo and nRF5 SDK is in a maintenance mode. Please consider using nRF Connect SDK which has the most recent OpenThread RCP support as well. The USB Bootloader configuration for this repo was mainly to support nRF52840 Dongle which you can find in the documentation. However, i don't see any reason why the Bootloader for the nRF52840 DK might occupy different flash regions (not counting potential different configuration e.g. debug/release).
I would also recommend to create a devzone ticket to get support from our tech support team.

No problems, I think I found the SDK here: https://github.com/nrfconnect/sdk-nrf with docs at https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/installation/updating.html
It's the same chip in the little dongle as in the full dev board, and I think the USB pins are dedicated (can't be re-mapped) so the same code should work on both (LED and pushbutton connections being the sticking point).
I'll check those out and have a close look.  It helps that I'm not digging around in the now obsolete nRF5 SDK. :-)  Many thanks.

Right… so after a few days of tinkering, I finally got something working.
I did have a look at the nRF Connect SDK.  I was able to use this to build an RCP image, and I think with some further tinkering, should be able to get a bootloader running with that, but this requires getting familiar with Zephyr OS's build system.  Definitely worth doing long-term, but more than I wanted to tackle at this stage.
I will revisit this soon.
For this application, basically I needed something that was more-or-less compatible with the existing project, so stuck with the nRF5 SDK despite its maintenance status.  These are the steps I followed to get a working system:

Downloaded nRF5 SDK from https://www.nordicsemi.com/Products/Development-software/nRF5-SDK/Download#infotabs -- I used version 17.1.0
Downloaded and installed the CLI tools from https://www.nordicsemi.com/Products/Development-tools/nRF-Command-Line-Tools/Download
Installed the ARM GNU toolchain (v12 works, with some warnings generated)
Modified components/toolchain/gcc/Makefile.posix with my toolchain's location
Entered the examples/dfu/open_bootloader/pca10059_usb/armgcc directory (or any of the others, in my case the PCA10059 is the closest to the Fanstel USB840X, but one could also use pca10056_usb instead)
Added -Wno-error=array-bounds (look for -Werror) to CFLAGS in the Makefile
Updated examples/dfu/dfu_public_key.c with the public key being used (Fanstel publish this in their documentation, you can just use the existing one and remove the #ifdef/#endif instead… or replace it with yours).
Ran make; the file _build/nrf52840_xxaa.hex was generated
Ran /opt/nrf-command-line-tools/bin/mergehex -o bootloader.hex -m _build/nrf52840_xxaa.hex ../../../../../components/softdevice/s140/hex/s140_nrf52_7.2.0_softdevice.hex to produce the final bootloader.hex

Then I could flash bootloader.hex via the nRF52840 DK to my target.  I was also (by accident) able to flash the nRF52840 with this firmware and have it work.
On reset, the MCU will blink a LED, much like the PCA10059 boards do, and the nRF Connect programmer will let you upload .hex files as required.  The ot-rcp image generated with -DOT_BOOTLOADER=USB works once loaded via nRF Connect.
So in short, the above is where one can get a compatible boot-loader and load it to get something working quickly.  nRF Connect SDK offers a much better option using MCUBoot at the cost of a steeper learning curve, but if all you need is a USB-updateable RCP dongle, this will get people there with minimal fuss.


refactor lib to support other Okta Providers [WIP]

create parralel lib2 that has "clients" and "providers" packages.
clients:

contains the components to interact with Okta
will cache your Okta session for you if a keyring is passed in

providers:

contains the components needed by Okta Providers. Currently this is
only the AWS SAML provider but could contain other providers in the
future.
will cache the session that this provider creates

Other than seperating logic this commit also introduces tests for
clients and providers as a starting point for more comprehensive test
coverage.

hi @nickatsegment I still have some additional work to do on this but I'm hoping it's close and won't need too much change  for the first iteration, I also wanted to give you as much time to review as possible.
I've put [WIP] in the title but any feedback you can give on what is there is greatly appreciated. I'm expecting there will be another (hopefully minor) update Monday so that I'll be able to remove the [WIP].
One change I'd like to make is to drop the lib2 and move client/provider to the top level or to lib/. What do you think?

One change I'd like to make is to drop the lib2 and move client/provider to the top level or to lib/. What do you think?

Yep!

I've tried to address a bunch of your comments with focus on trying to keep the exports to a minimum.
If we can address a few things as followup PRs I think it would help quality overall and provide some time for consideration. This is the list I have:

Update error handling strategy for the client/provider (this will include changes in cmd and lib)
put more structure around profiles
change prompts for MFA and role selection to use an interface that is passed in.
start using a session cache interface for Okta sessions

I'd also like to see the test coverage higher, I think this can be achieved by adding more testing for each new feature/change.
Apologies if I've missed any of your comments or misinterpreted anything, kindly tell me where I went wrong.

If we can address a few things as followup PRs I think it would help quality overall and provide some time for consideration

The trouble is that some of these future changes would require changing the public API in backwards-incompatible ways. This is not the end of the world, considering we're v0, but limits its utility as a library, which was kind of the whole point, right? ;)
I don't think there's any real pressure to get this done immediately from my end, other than the fact that the longer we take, the more drift accumulates in master which will require merging. I'm totally happy extending the time in https://github.com/segmentio/aws-okta/issues/236 for another 2 weeks at least, if you have time.
That said, some specific comments:

Update error handling strategy for the client/provider (this will include changes in cmd and lib)

Yeah, this probably wouldn't break the API (i.e., things would still compile) since any error-branching is runtime anyway. So this can be done later. (Even if we're returning an error now, that error in the future could have more concrete types added later.)

change prompts for MFA and role selection to use an interface that is passed in.

Aren't you going to need to do this to make it consumable as library anyway? You don't want prompts popping up in your server code

I'd also like to see the test coverage higher

Honestly increasing the test coverage is not high priority for me. At the end of the day, if current flows through the CLI work as they do right now, that should be good enough.

It's probably too hard to do now, but a commit history would have made this easier to follow :) It's hard to see what's changed since the last time I reviewed if you keep squashing.
Related: hit that Resolve Conversation button if you think you've fixed the thing.

I've put in another commit with the updates, I'll refrain from the ammend/force workflow.
Please see the latest commit for what I added today, I'll continue tomorrow with anything that is still outstanding.

the failing build is caused by the introduction of typed errors and the us of errors.Is. I will look at fixing this tomorrow.
This introduces four errors:
InvalidCredentialsError = errors.New("Okta credentials are not valid")
InvalidSessionError     = errors.New("Okta session is not valid")
UnexpectedResponseError = errors.New("Okta returned an unexpected response")
NotImplementedError     = errors.New("Not implemented")

This is all shaping up very nicely. :D
The failing build is because we build for both go1.13 and 1.12 (the currently supported versions). errors.Is was introduced in 1.13. We should probably just use https://godoc.org/golang.org/x/xerrors until 1.14 is released (and we can drop support for 1.12)

@switj ping me when you're ready for another review pass :)

@nickatsegment Just pushed a WIP commit for the MFA refactor. Hoping to finish it up tomorrow but it's close, missing code cleanup and more tests.
Interested to hear your thoughts.

@nickatsegment Just pushed a WIP commit for the MFA refactor.

I like where your head's at. It would be nice if the MFA stuff didn't have to care about any Okta stuff, and be nice and self-contained. But I think your interfaces need a second pass (respectfully!). As written, I think they just add indirection rather than encapsulate complexity?

@nickatsegment Just pushed a WIP commit for the MFA refactor.

I like where your head's at. It would be nice if the MFA stuff didn't have to care about any Okta stuff, and be nice and self-contained. But I think your interfaces need a second pass (respectfully!). As written, I think they just add indirection rather than encapsulate complexity?

I appreciate your feedback, I'll review/considering everything carefully. From the first quick look I took it seems like you have some good points that need addressing.
This is the first pass, the plan is to take your feedback and get some additional feedback from others and make improvements to the interface today.

Hey @switj, thanks for taking the feedback graciously :)
Considering all the hard work you've put into this, I was thinking I could send you some swag or something. My email address in on my profile if you're interested.

@nickatsegment ready for another review.

quick update, I now have a duo account and have it linked to our test okta account. I'm going to be testing the different factors to get this working again.
If anyone has experience using duo with okta and could help me it would be much appreciated.
There is an official client that we might be able to use: https://github.com/duosecurity/duo_api_golang

@switj Sorry, I was on vacation last week. Will do another pass sometime this week while you work on the duo stuff.

@nickatsegment from what I can tell the duo mfa implementation is back to where it was before. I'm able to successfully auth using Duo phone1 factor.

@nickatsegment friendly reminder that this PR is still waiting for you to review. If I can do anything to make the review easier or if you're waiting on anything from me please tell me.

@switj Sorry, I've had to back-burner my OSS projects to focus. I'll have a look this week.

I started another review pass and realized it was gonna be a lot of persnickety little things that would drag this on even longer. The bones of this PR are great. Would it be ok if I just took your branch and did the changes on it myself? I'll start a new PR.
Just having a hard time convincing myself that this is going to be identical without writing some of it myself

go for it!

Hey @switj, I spent some time trying to refactor to make it fit, but ultimately I came to the conclusion that the codebase we're working with is so riddled with technical debt and spaghetti code that a near total rewrite is in order.
I've started that here https://github.com/segmentio/aws-okta/issues/271 and would love any feedback you have along the way. Unfortunately, this rewrite may mean the lib API is fairly different.
I've already leveraged a bunch of your work here, and it was a huge help. So thanks for that.

Hey @switj, just wondering if you'd evaluated saml2aws as an alternative to aws-okta. I'm not sure how you're using us, but it looks like saml2aws is nicely structured and is consumable as a lib.


update indent/javascript.vim

this is basically the same in effects, however there is a nice increase to the speed, edge case correctness, and even a few &cino (w,(,:) options are parsed and reproduced.
At the top of the file is a simple "test" to try on files using the shell. if you find anything wrong let me know

I'll include it, thanks.

please include http://pastebin.com/qFXAJdJX instead. Change is on line 363

Thanks.  I'll also update the date in the header.


Weird line chart - line become lasso

Graph is OK (type: area-spline) when there are only few points or many points but the gap is near.
But when it try to render many points and the gap between previous point to next point is far (many null data), line on graph become lasso-like. It is very weird
My options are:
data: { 	columns: [ 		["Max. Signal Bars",2,2,2,2,2,null,2,2,2,2,2,2,2,2,2,2,2,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null,null ,null,null,null,null,null,null,3,2,1,1,2,null,1,2,1,null,1,1,1,2,null,1,null,1,1,2,2,2,1,2,null,2,2,2 ,2,2,1,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,null,null,1,2,1,2,2,2,1,1,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,2,null ,2,2,2,2,2,null,1,2,2,2,2,2,2,2,2,2,2,2,null,null,null,null] 	], 	type: "area-spline", 	empty: { 		label: { 			text: "No Data" 		} 	} }, line: { 	connectNull: true }, axis: { 	x: { 		type: 'category', 		categories: ["31 Jul (23:00 - 23:59)","01  Aug (00:00 - 00:59)","01 Aug (01:00 - 01:59)","01 Aug (02:00 - 02:59)","01 Aug (03:00 - 03:59)","01  Aug (04:00 - 04:59)","01 Aug (05:00 - 05:59)","01 Aug (06:00 - 06:59)","01 Aug (07:00 - 07:59)","01  Aug (08:00 - 08:59)","01 Aug (09:00 - 09:59)","01 Aug (10:00 - 10:59)","01 Aug (11:00 - 11:59)","01  Aug (12:00 - 12:59)","01 Aug (13:00 - 13:59)","01 Aug (14:00 - 14:59)","01 Aug (15:00 - 15:59)","01  Aug (16:00 - 16:59)","01 Aug (17:00 - 17:59)","01 Aug (18:00 - 18:59)","01 Aug (19:00 - 19:59)","01  Aug (20:00 - 20:59)","01 Aug (21:00 - 21:59)","01 Aug (22:00 - 22:59)","01 Aug (23:00 - 23:59)","02  Aug (00:00 - 00:59)","02 Aug (01:00 - 01:59)","02 Aug (02:00 - 02:59)","02 Aug (03:00 - 03:59)","02  Aug (04:00 - 04:59)","02 Aug (05:00 - 05:59)","02 Aug (06:00 - 06:59)","02 Aug (07:00 - 07:59)","02  Aug (08:00 - 08:59)","02 Aug (09:00 - 09:59)","02 Aug (10:00 - 10:59)","02 Aug (11:00 - 11:59)","02  Aug (12:00 - 12:59)","02 Aug (13:00 - 13:59)","02 Aug (14:00 - 14:59)","02 Aug (15:00 - 15:59)","02  Aug (16:00 - 16:59)","02 Aug (17:00 - 17:59)","02 Aug (18:00 - 18:59)","02 Aug (19:00 - 19:59)","02  Aug (20:00 - 20:59)","02 Aug (21:00 - 21:59)","02 Aug (22:00 - 22:59)","02 Aug (23:00 - 23:59)","03  Aug (00:00 - 00:59)","03 Aug (01:00 - 01:59)","03 Aug (02:00 - 02:59)","03 Aug (03:00 - 03:59)","03  Aug (04:00 - 04:59)","03 Aug (05:00 - 05:59)","03 Aug (06:00 - 06:59)","03 Aug (07:00 - 07:59)","03  Aug (08:00 - 08:59)","03 Aug (09:00 - 09:59)","03 Aug (10:00 - 10:59)","03 Aug (11:00 - 11:59)","03  Aug (12:00 - 12:59)","03 Aug (13:00 - 13:59)","03 Aug (14:00 - 14:59)","03 Aug (15:00 - 15:59)","03  Aug (16:00 - 16:59)","03 Aug (17:00 - 17:59)","03 Aug (18:00 - 18:59)","03 Aug (19:00 - 19:59)","03  Aug (20:00 - 20:59)","03 Aug (21:00 - 21:59)","03 Aug (22:00 - 22:59)","03 Aug (23:00 - 23:59)","04  Aug (00:00 - 00:59)","04 Aug (01:00 - 01:59)","04 Aug (02:00 - 02:59)","04 Aug (03:00 - 03:59)","04  Aug (04:00 - 04:59)","04 Aug (05:00 - 05:59)","04 Aug (06:00 - 06:59)","04 Aug (07:00 - 07:59)","04  Aug (08:00 - 08:59)","04 Aug (09:00 - 09:59)","04 Aug (10:00 - 10:59)","04 Aug (11:00 - 11:59)","04  Aug (12:00 - 12:59)","04 Aug (13:00 - 13:59)","04 Aug (14:00 - 14:59)","04 Aug (15:00 - 15:59)","04  Aug (16:00 - 16:59)","04 Aug (17:00 - 17:59)","04 Aug (18:00 - 18:59)","04 Aug (19:00 - 19:59)","04  Aug (20:00 - 20:59)","04 Aug (21:00 - 21:59)","04 Aug (22:00 - 22:59)","04 Aug (23:00 - 23:59)","05  Aug (00:00 - 00:59)","05 Aug (01:00 - 01:59)","05 Aug (02:00 - 02:59)","05 Aug (03:00 - 03:59)","05  Aug (04:00 - 04:59)","05 Aug (05:00 - 05:59)","05 Aug (06:00 - 06:59)","05 Aug (07:00 - 07:59)","05  Aug (08:00 - 08:59)","05 Aug (09:00 - 09:59)","05 Aug (10:00 - 10:59)","05 Aug (11:00 - 11:59)","05  Aug (12:00 - 12:59)","05 Aug (13:00 - 13:59)","05 Aug (14:00 - 14:59)","05 Aug (15:00 - 15:59)","05  Aug (16:00 - 16:59)","05 Aug (17:00 - 17:59)","05 Aug (18:00 - 18:59)","05 Aug (19:00 - 19:59)","05  Aug (20:00 - 20:59)","05 Aug (21:00 - 21:59)","05 Aug (22:00 - 22:59)","05 Aug (23:00 - 23:59)","06  Aug (00:00 - 00:59)","06 Aug (01:00 - 01:59)","06 Aug (02:00 - 02:59)","06 Aug (03:00 - 03:59)","06  Aug (04:00 - 04:59)","06 Aug (05:00 - 05:59)","06 Aug (06:00 - 06:59)","06 Aug (07:00 - 07:59)","06  Aug (08:00 - 08:59)","06 Aug (09:00 - 09:59)","06 Aug (10:00 - 10:59)","06 Aug (11:00 - 11:59)","06  Aug (12:00 - 12:59)","06 Aug (13:00 - 13:59)","06 Aug (14:00 - 14:59)","06 Aug (15:00 - 15:59)","06  Aug (16:00 - 16:59)","06 Aug (17:00 - 17:59)","06 Aug (18:00 - 18:59)","06 Aug (19:00 - 19:59)","06  Aug (20:00 - 20:59)","06 Aug (21:00 - 21:59)","06 Aug (22:00 - 22:59)","06 Aug (23:00 - 23:59)","07  Aug (00:00 - 00:59)","07 Aug (01:00 - 01:59)","07 Aug (02:00 - 02:59)","07 Aug (03:00 - 03:59)","07  Aug (04:00 - 04:59)","07 Aug (05:00 - 05:59)","07 Aug (06:00 - 06:59)","07 Aug (07:00 - 07:59)","07  Aug (08:00 - 08:59)","07 Aug (09:00 - 09:59)","07 Aug (10:00 - 10:59)","07 Aug (11:00 - 11:59)","07  Aug (12:00 - 12:59)","07 Aug (13:00 - 13:59)","07 Aug (14:00 - 14:59)","07 Aug (15:00 - 15:59)","07  Aug (16:00 - 16:59)","07 Aug (17:00 - 17:59)","07 Aug (18:00 - 18:59)","07 Aug (19:00 - 19:59)","07  Aug (20:00 - 20:59)","07 Aug (21:00 - 21:59)","07 Aug (22:00 - 22:59)","07 Aug (23:00 - 23:59)","08  Aug (00:00 - 00:59)","08 Aug (01:00 - 01:59)","08 Aug (02:00 - 02:59)","08 Aug (03:00 - 03:59)","08  Aug (04:00 - 04:59)","08 Aug (05:00 - 05:59)","08 Aug (06:00 - 06:59)","08 Aug (07:00 - 07:59)","08  Aug (08:00 - 08:59)","08 Aug (09:00 - 09:59)","08 Aug (10:00 - 10:59)","08 Aug (11:00 - 11:59)","08  Aug (12:00 - 12:59)","08 Aug (13:00 - 13:59)","08 Aug (14:00 - 14:59)","08 Aug (15:00 - 15:59)","08  Aug (16:00 - 16:59)","08 Aug (17:00 - 17:59)","08 Aug (18:00 - 18:59)","08 Aug (19:00 - 19:59)","08  Aug (20:00 - 20:59)","08 Aug (21:00 - 21:59)","08 Aug (22:00 - 22:59)","08 Aug (23:00 - 23:59)","09  Aug (00:00 - 00:59)","09 Aug (01:00 - 01:59)","09 Aug (02:00 - 02:59)","09 Aug (03:00 - 03:59)","09  Aug (04:00 - 04:59)","09 Aug (05:00 - 05:59)","09 Aug (06:00 - 06:59)","09 Aug (07:00 - 07:59)","09  Aug (08:00 - 08:59)","09 Aug (09:00 - 09:59)","09 Aug (10:00 - 10:59)","09 Aug (11:00 - 11:59)","09  Aug (12:00 - 12:59)","09 Aug (13:00 - 13:59)","09 Aug (14:00 - 14:59)","09 Aug (15:00 - 15:59)","09  Aug (16:00 - 16:59)","09 Aug (17:00 - 17:59)","09 Aug (18:00 - 18:59)","09 Aug (19:00 - 19:59)","09  Aug (20:00 - 20:59)","09 Aug (21:00 - 21:59)","09 Aug (22:00 - 22:59)","09 Aug (23:00 - 23:59)","10  Aug (00:00 - 00:59)","10 Aug (01:00 - 01:59)","10 Aug (02:00 - 02:59)","10 Aug (03:00 - 03:59)","10  Aug (04:00 - 04:59)","10 Aug (05:00 - 05:59)","10 Aug (06:00 - 06:59)","10 Aug (07:00 - 07:59)","10  Aug (08:00 - 08:59)","10 Aug (09:00 - 09:59)","10 Aug (10:00 - 10:59)","10 Aug (11:00 - 11:59)","10  Aug (12:00 - 12:59)","10 Aug (13:00 - 13:59)","10 Aug (14:00 - 14:59)","10 Aug (15:00 - 15:59)","10  Aug (16:00 - 16:59)","10 Aug (17:00 - 17:59)","10 Aug (18:00 - 18:59)","10 Aug (19:00 - 19:59)","10  Aug (20:00 - 20:59)","10 Aug (21:00 - 21:59)","10 Aug (22:00 - 22:59)","10 Aug (23:00 - 23:59)","11  Aug (00:00 - 00:59)","11 Aug (01:00 - 01:59)","11 Aug (02:00 - 02:59)","11 Aug (03:00 - 03:59)","11  Aug (04:00 - 04:59)","11 Aug (05:00 - 05:59)","11 Aug (06:00 - 06:59)","11 Aug (07:00 - 07:59)","11  Aug (08:00 - 08:59)","11 Aug (09:00 - 09:59)","11 Aug (10:00 - 10:59)","11 Aug (11:00 - 11:59)","11  Aug (12:00 - 12:59)","11 Aug (13:00 - 13:59)","11 Aug (14:00 - 14:59)","11 Aug (15:00 - 15:59)","11  Aug (16:00 - 16:59)","11 Aug (17:00 - 17:59)","11 Aug (18:00 - 18:59)","11 Aug (19:00 - 19:59)","11  Aug (20:00 - 20:59)","11 Aug (21:00 - 21:59)","11 Aug (22:00 - 22:59)","11 Aug (23:00 - 23:59)","12  Aug (00:00 - 00:59)","12 Aug (01:00 - 01:59)","12 Aug (02:00 - 02:59)","12 Aug (03:00 - 03:59)","12  Aug (04:00 - 04:59)","12 Aug (05:00 - 05:59)","12 Aug (06:00 - 06:59)","12 Aug (07:00 - 07:59)","12  Aug (08:00 - 08:59)","12 Aug (09:00 - 09:59)","12 Aug (10:00 - 10:59)","12 Aug (11:00 - 11:59)","12  Aug (12:00 - 12:59)","12 Aug (13:00 - 13:59)","12 Aug (14:00 - 14:59)","12 Aug (15:00 - 15:59)","12  Aug (16:00 - 16:59)","12 Aug (17:00 - 17:59)","12 Aug (18:00 - 18:59)","12 Aug (19:00 - 19:59)","12  Aug (20:00 - 20:59)","12 Aug (21:00 - 21:59)","12 Aug (22:00 - 22:59)","12 Aug (23:00 - 23:59)","13  Aug (00:00 - 00:59)","13 Aug (01:00 - 01:59)","13 Aug (02:00 - 02:59)","13 Aug (03:00 - 03:59)","13  Aug (04:00 - 04:59)","13 Aug (05:00 - 05:59)","13 Aug (06:00 - 06:59)","13 Aug (07:00 - 07:59)","13  Aug (08:00 - 08:59)","13 Aug (09:00 - 09:59)","13 Aug (10:00 - 10:59)","13 Aug (11:00 - 11:59)","13  Aug (12:00 - 12:59)","13 Aug (13:00 - 13:59)","13 Aug (14:00 - 14:59)","13 Aug (15:00 - 15:59)","13  Aug (16:00 - 16:59)","13 Aug (17:00 - 17:59)","13 Aug (18:00 - 18:59)","13 Aug (19:00 - 19:59)","13  Aug (20:00 - 20:59)","13 Aug (21:00 - 21:59)","13 Aug (22:00 - 22:59)","13 Aug (23:00 - 23:59)","14  Aug (00:00 - 00:59)","14 Aug (01:00 - 01:59)","14 Aug (02:00 - 02:59)","14 Aug (03:00 - 03:59)","14  Aug (04:00 - 04:59)","14 Aug (05:00 - 05:59)","14 Aug (06:00 - 06:59)","14 Aug (07:00 - 07:59)","14  Aug (08:00 - 08:59)","14 Aug (09:00 - 09:59)","14 Aug (10:00 - 10:59)","14 Aug (11:00 - 11:59)","14  Aug (12:00 - 12:59)","14 Aug (13:00 - 13:59)","14 Aug (14:00 - 14:59)","14 Aug (15:00 - 15:59)","14  Aug (16:00 - 16:59)","14 Aug (17:00 - 17:59)","14 Aug (18:00 - 18:59)","14 Aug (19:00 - 19:59)","14  Aug (20:00 - 20:59)","14 Aug (21:00 - 21:59)","14 Aug (22:00 - 22:59)","14 Aug (23:00 - 23:59)","15  Aug (00:00 - 00:59)","15 Aug (01:00 - 01:59)","15 Aug (02:00 - 02:59)","15 Aug (03:00 - 03:59)","15  Aug (04:00 - 04:59)","15 Aug (05:00 - 05:59)","15 Aug (06:00 - 06:59)","15 Aug (07:00 - 07:59)","15  Aug (08:00 - 08:59)","15 Aug (09:00 - 09:59)","15 Aug (10:00 - 10:59)","15 Aug (11:00 - 11:59)","15  Aug (12:00 - 12:59)","15 Aug (13:00 - 13:59)","15 Aug (14:00 - 14:59)","15 Aug (15:00 - 15:59)","15  Aug (16:00 - 16:59)","15 Aug (17:00 - 17:59)","15 Aug (18:00 - 18:59)","15 Aug (19:00 - 19:59)","15  Aug (20:00 - 20:59)","15 Aug (21:00 - 21:59)","15 Aug (22:00 - 22:59)","15 Aug (23:00 - 23:59)","16  Aug (00:00 - 00:59)","16 Aug (01:00 - 01:59)","16 Aug (02:00 - 02:59)","16 Aug (03:00 - 03:59)","16  Aug (04:00 - 04:59)","16 Aug (05:00 - 05:59)","16 Aug (06:00 - 06:59)","16 Aug (07:00 - 07:59)","16  Aug (08:00 - 08:59)","16 Aug (09:00 - 09:59)","16 Aug (10:00 - 10:59)","16 Aug (11:00 - 11:59)","16  Aug (12:00 - 12:59)","16 Aug (13:00 - 13:59)","16 Aug (14:00 - 14:59)","16 Aug (15:00 - 15:59)","16  Aug (16:00 - 16:59)","16 Aug (17:00 - 17:59)","16 Aug (18:00 - 18:59)","16 Aug (19:00 - 19:59)","16  Aug (20:00 - 20:59)","16 Aug (21:00 - 21:59)","16 Aug (22:00 - 22:59)","16 Aug (23:00 - 23:59)","17  Aug (00:00 - 00:59)","17 Aug (01:00 - 01:59)","17 Aug (02:00 - 02:59)","17 Aug (03:00 - 03:59)","17  Aug (04:00 - 04:59)","17 Aug (05:00 - 05:59)","17 Aug (06:00 - 06:59)","17 Aug (07:00 - 07:59)","17  Aug (08:00 - 08:59)","17 Aug (09:00 - 09:59)","17 Aug (10:00 - 10:59)","17 Aug (11:00 - 11:59)","17  Aug (12:00 - 12:59)","17 Aug (13:00 - 13:59)","17 Aug (14:00 - 14:59)","17 Aug (15:00 - 15:59)","17  Aug (16:00 - 16:59)","17 Aug (17:00 - 17:59)","17 Aug (18:00 - 18:59)","17 Aug (19:00 - 19:59)","17  Aug (20:00 - 20:59)","17 Aug (21:00 - 21:59)","17 Aug (22:00 - 22:59)","17 Aug (23:00 - 23:59)","18  Aug (00:00 - 00:59)","18 Aug (01:00 - 01:59)","18 Aug (02:00 - 02:59)","18 Aug (03:00 - 03:59)","18  Aug (04:00 - 04:59)","18 Aug (05:00 - 05:59)","18 Aug (06:00 - 06:59)","18 Aug (07:00 - 07:59)","18  Aug (08:00 - 08:59)","18 Aug (09:00 - 09:59)","18 Aug (10:00 - 10:59)","18 Aug (11:00 - 11:59)","18  Aug (12:00 - 12:59)","18 Aug (13:00 - 13:59)","18 Aug (14:00 - 14:59)","18 Aug (15:00 - 15:59)","18  Aug (16:00 - 16:59)","18 Aug (17:00 - 17:59)","18 Aug (18:00 - 18:59)","18 Aug (19:00 - 19:59)","18  Aug (20:00 - 20:59)","18 Aug (21:00 - 21:59)","18 Aug (22:00 - 22:59)","18 Aug (23:00 - 23:59)","19  Aug (00:00 - 00:59)","19 Aug (01:00 - 01:59)","19 Aug (02:00 - 02:59)","19 Aug (03:00 - 03:59)","19  Aug (04:00 - 04:59)","19 Aug (05:00 - 05:59)","19 Aug (06:00 - 06:59)","19 Aug (07:00 - 07:59)","19  Aug (08:00 - 08:59)","19 Aug (09:00 - 09:59)","19 Aug (10:00 - 10:59)","19 Aug (11:00 - 11:59)","19  Aug (12:00 - 12:59)","19 Aug (13:00 - 13:59)","19 Aug (14:00 - 14:59)","19 Aug (15:00 - 15:59)","19  Aug (16:00 - 16:59)","19 Aug (17:00 - 17:59)","19 Aug (18:00 - 18:59)","19 Aug (19:00 - 19:59)","19  Aug (20:00 - 20:59)","19 Aug (21:00 - 21:59)","19 Aug (22:00 - 22:59)","19 Aug (23:00 - 23:59)","20  Aug (00:00 - 00:59)","20 Aug (01:00 - 01:59)","20 Aug (02:00 - 02:59)","20 Aug (03:00 - 03:59)","20  Aug (04:00 - 04:59)","20 Aug (05:00 - 05:59)","20 Aug (06:00 - 06:59)","20 Aug (07:00 - 07:59)","20  Aug (08:00 - 08:59)","20 Aug (09:00 - 09:59)","20 Aug (10:00 - 10:59)","20 Aug (11:00 - 11:59)","20  Aug (12:00 - 12:59)","20 Aug (13:00 - 13:59)","20 Aug (14:00 - 14:59)","20 Aug (15:00 - 15:59)","20  Aug (16:00 - 16:59)","20 Aug (17:00 - 17:59)","20 Aug (18:00 - 18:59)","20 Aug (19:00 - 19:59)","20  Aug (20:00 - 20:59)","20 Aug (21:00 - 21:59)","20 Aug (22:00 - 22:59)","20 Aug (23:00 - 23:59)","21  Aug (00:00 - 00:59)","21 Aug (01:00 - 01:59)","21 Aug (02:00 - 02:59)","21 Aug (03:00 - 03:59)","21  Aug (04:00 - 04:59)","21 Aug (05:00 - 05:59)","21 Aug (06:00 - 06:59)","21 Aug (07:00 - 07:59)","21  Aug (08:00 - 08:59)","21 Aug (09:00 - 09:59)","21 Aug (10:00 - 10:59)","21 Aug (11:00 - 11:59)","21  Aug (12:00 - 12:59)","21 Aug (13:00 - 13:59)","21 Aug (14:00 - 14:59)","21 Aug (15:00 - 15:59)","21  Aug (16:00 - 16:59)","21 Aug (17:00 - 17:59)","21 Aug (18:00 - 18:59)","21 Aug (19:00 - 19:59)","21  Aug (20:00 - 20:59)","21 Aug (21:00 - 21:59)","21 Aug (22:00 - 22:59)","21 Aug (23:00 - 23:59)","22  Aug (00:00 - 00:59)","22 Aug (01:00 - 01:59)","22 Aug (02:00 - 02:59)","22 Aug (03:00 - 03:59)","22  Aug (04:00 - 04:59)","22 Aug (05:00 - 05:59)","22 Aug (06:00 - 06:59)","22 Aug (07:00 - 07:59)","22  Aug (08:00 - 08:59)","22 Aug (09:00 - 09:59)","22 Aug (10:00 - 10:59)","22 Aug (11:00 - 11:59)","22  Aug (12:00 - 12:59)","22 Aug (13:00 - 13:59)","22 Aug (14:00 - 14:59)","22 Aug (15:00 - 15:59)","22  Aug (16:00 - 16:59)","22 Aug (17:00 - 17:59)","22 Aug (18:00 - 18:59)","22 Aug (19:00 - 19:59)","22  Aug (20:00 - 20:59)","22 Aug (21:00 - 21:59)","22 Aug (22:00 - 22:59)","22 Aug (23:00 - 23:59)","23  Aug (00:00 - 00:59)","23 Aug (01:00 - 01:59)","23 Aug (02:00 - 02:59)","23 Aug (03:00 - 03:59)","23  Aug (04:00 - 04:59)","23 Aug (05:00 - 05:59)","23 Aug (06:00 - 06:59)","23 Aug (07:00 - 07:59)","23  Aug (08:00 - 08:59)","23 Aug (09:00 - 09:59)","23 Aug (10:00 - 10:59)","23 Aug (11:00 - 11:59)","23  Aug (12:00 - 12:59)","23 Aug (13:00 - 13:59)","23 Aug (14:00 - 14:59)","23 Aug (15:00 - 15:59)","23  Aug (16:00 - 16:59)","23 Aug (17:00 - 17:59)","23 Aug (18:00 - 18:59)","23 Aug (19:00 - 19:59)","23  Aug (20:00 - 20:59)","23 Aug (21:00 - 21:59)","23 Aug (22:00 - 22:59)","23 Aug (23:00 - 23:59)","24  Aug (00:00 - 00:59)","24 Aug (01:00 - 01:59)","24 Aug (02:00 - 02:59)","24 Aug (03:00 - 03:59)","24  Aug (04:00 - 04:59)","24 Aug (05:00 - 05:59)","24 Aug (06:00 - 06:59)","24 Aug (07:00 - 07:59)","24  Aug (08:00 - 08:59)","24 Aug (09:00 - 09:59)","24 Aug (10:00 - 10:59)","24 Aug (11:00 - 11:59)","24  Aug (12:00 - 12:59)","24 Aug (13:00 - 13:59)","24 Aug (14:00 - 14:59)","24 Aug (15:00 - 15:59)","24  Aug (16:00 - 16:59)","24 Aug (17:00 - 17:59)","24 Aug (18:00 - 18:59)","24 Aug (19:00 - 19:59)","24  Aug (20:00 - 20:59)","24 Aug (21:00 - 21:59)","24 Aug (22:00 - 22:59)","24 Aug (23:00 - 23:59)","25  Aug (00:00 - 00:59)","25 Aug (01:00 - 01:59)","25 Aug (02:00 - 02:59)","25 Aug (03:00 - 03:59)","25  Aug (04:00 - 04:59)","25 Aug (05:00 - 05:59)","25 Aug (06:00 - 06:59)","25 Aug (07:00 - 07:59)","25  Aug (08:00 - 08:59)","25 Aug (09:00 - 09:59)","25 Aug (10:00 - 10:59)","25 Aug (11:00 - 11:59)","25  Aug (12:00 - 12:59)","25 Aug (13:00 - 13:59)","25 Aug (14:00 - 14:59)","25 Aug (15:00 - 15:59)","25  Aug (16:00 - 16:59)","25 Aug (17:00 - 17:59)","25 Aug (18:00 - 18:59)","25 Aug (19:00 - 19:59)","25  Aug (20:00 - 20:59)","25 Aug (21:00 - 21:59)","25 Aug (22:00 - 22:59)","25 Aug (23:00 - 23:59)","26  Aug (00:00 - 00:59)","26 Aug (01:00 - 01:59)","26 Aug (02:00 - 02:59)","26 Aug (03:00 - 03:59)","26  Aug (04:00 - 04:59)","26 Aug (05:00 - 05:59)","26 Aug (06:00 - 06:59)","26 Aug (07:00 - 07:59)","26  Aug (08:00 - 08:59)","26 Aug (09:00 - 09:59)","26 Aug (10:00 - 10:59)","26 Aug (11:00 - 11:59)","26  Aug (12:00 - 12:59)","26 Aug (13:00 - 13:59)","26 Aug (14:00 - 14:59)","26 Aug (15:00 - 15:59)","26  Aug (16:00 - 16:59)","26 Aug (17:00 - 17:59)","26 Aug (18:00 - 18:59)","26 Aug (19:00 - 19:59)","26  Aug (20:00 - 20:59)","26 Aug (21:00 - 21:59)","26 Aug (22:00 - 22:59)","26 Aug (23:00 - 23:59)","27  Aug (00:00 - 00:59)","27 Aug (01:00 - 01:59)","27 Aug (02:00 - 02:59)"], 		show:true, 		tick: { 			outer:false, 			culling:{ 				max: 8 			}, 			multiline: true, 			width:80 		} 	}, 	y: { 		show: true, 		tick: { 			outer: false, 			format: function (d) {  				d = Math.round(d * 100) / 100; 				return d; 			} 		}, 		padding: 0 	} },
The graph result are:

Can you fix the "lasso" things? it should be direct line

@indr4winata Not sure how easy that is to fix because of the interpolation with the spline style of chart. If you change it to just a regular area chart, does that fix things?

@aendrew : If I use normal area ( data.type = "area" ), the chart is OK, no "lasso" thing. it only happen with spline (normal spline and area-spline). Don't know about the others, but as far as I check, line and area is works well.

@indr4winata Yeah, it's definitely an interpolation issue with the spline chart. If you've ever used the "pen" tool in Adobe Illustrator, you get that effect by drawing shapes with some space between the points and some curvature on them.
Try this: set spline.interpolation.type to one of basis, cardinal or monotone and see if that improves.

@aendrew : There is no documentation for your spline.interpolation.type. Why don't you put it?
Well, if I use spline.interpolation.type = cardinal or monotone, it still remain the same. But if I set it to basis, it solve the "lasso" problem but give another problem: the line does not adhere with the point. See my image below. My data will always in integer, 1, 2, 3, 4, or 5. the point is right, but the line is not. I use the same data but I zoom in to give clear visualization.

Well, maybe can you update your code with the easiest way (maybe start with the "basis" type)? Or do you have any other things that I should try that have not been in the c3 documentation? :)
Thank you anyway.

@indr4winata There's a lot of the API that's been added and isn't documented. V1 will have extensive inline documentation that will generate the documentation site, which should help that somewhat.
Kind of the issue with splines is more of an upstream D3 issue; I find it's generally better to use lines unless you really have a specific use for a spline. Closing as wontfix.


fix: Add mongodb env variables to ingest-test-fixtures-update-pr.yaml

ingest-test-fixtures-update-pr.yaml was missing mongodb vars. And the workflow was failing.

...and can we make sure in the future it would?

nit: can we not bump the changelog since this doesn't impact the end user?

@ryannikolaidis I believe the Changelog workflow will fail if there are no changes to CHANGELOG and if __version__ does not correspond. So the minimal change to get a mergeable PR is to bump the changelog and update version to match.
At least that's the way it was when I formed that habit months ago :)

nit: can we not bump the changelog since this doesn't impact the end user?

@ryannikolaidis I believe the Changelog workflow will fail if there are no changes to CHANGELOG and if __version__ does not correspond. So the minimal change to get a mergeable PR is to bump the changelog (version number) and update version to match.
At least that's the way it was when I formed that habit months ago :)
Thats what I thought. Looks like CI didn't like it without one.
there is already a commit associated with version 0.13.1.

@potter-potter you need to bump the version number in CHANGELOG and change the version in unstructured/__version__.py to match it. No need for an actual CHANGELOG "line-item" if it doesn't affect the user, but you do need to change the version.
In this case, since Ryan just cut a new release, you need to add a new version block named 0.13.2-dev0 with empty Enhancements, Fixes, etc. blocks underneath it.

Yep! That ☝ exactly.


Prompt the warehouse input when adding location

Currently all locations being inserted are using "TEST1" but should add a new prompt for the user to input the warehouse.

implemented in e33179ed60f10331f3f5984fa85335a739e01e44


Adding an overview visualization on the triples map and how they are connected

Useful to have a quick look at how big is the mapping and how the items are interlinked

Without more information, it's not clear what is it that you have in mind

something like a small diagram with the names of the triplesmap and how they are connected between one another. Thanks to the join conditions and soft joins this shouldn't pose much of an issue


Add, Update & Delete with Batch Support Working.

@jessebenson @jdhuntington @andrewjamconrad @tushardhadiwal
I have implemented Back end with Add, Update & Delete functionality.
Partition ID Support is added.

@tushardhadiwal

@jdhuntington @andrewjamconrad - code review!


Fix observed variable detection

Create a separate method to detect observed sites and apply it everywhere necessary to automatically exclude observed sites.
Fixes #1801

I think my pre-commit configs are out of date, sorry. My version of flake doesn't see anything wrong. I can fix this later.

Still a work in progress, unfortunately, the solution I added doesn't seem to exclude observed variables. I will do a deeper dive some time this year.

I think this should be addressable by removing different procedures for different AutoGuide classes (https://github.com/scverse/scvi-tools/pull/2695).


Better exception handling when env vars are missing for flask CLI

Expected Behavior
As there is the support for lazy loading the app, when running flask CLI without providing the proper environment variables we must see a better warning instead of raw exception.
Tell us what should happen.
we should see a better warning or message pointing to the problem
# there is no FLASK_APP env var
$ flask --help
WARNING: You need to define the app e.g: `export FLASK_APP=app.py`

Actual Behavior
Tell us what happens instead.
we see traceback before the help message
# there is no FLASK_APP env var
$ flask --help                                                               Sat 28 Apr 2018 01:25:50 PM -03
Traceback (most recent call last):
  File "~Projects/personal/flasgger/venv/lib/python3.6/site-packages/flask/cli.py", line 235, in locate_app
    __import__(module_name)
ModuleNotFoundError: No module named 'app'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "~/Projects/personal/flasgger/venv/lib/python3.6/site-packages/flask/cli.py", line 529, in list_commands
    rv.update(info.load_app().cli.list_commands(ctx))
  File "~/Projects/personal/flasgger/venv/lib/python3.6/site-packages/flask/cli.py", line 372, in load_app
    app = locate_app(self, import_name, name)
  File "~/Projects/personal/flasgger/venv/lib/python3.6/site-packages/flask/cli.py", line 246, in locate_app
    'Could not import "{name}".'.format(name=module_name)
flask.cli.NoAppException: Could not import "app".
Usage: flask [OPTIONS] COMMAND [ARGS]...

  A general utility script for Flask applications.

  Provides commands from Flask, extensions, and the application. Loads the
  application defined in the FLASK_APP environment variable, or from a
  wsgi.py file. Setting the FLASK_ENV environment variable to 'development'
  will enable debug mode.

    $ export FLASK_APP=hello.py
    $ export FLASK_ENV=development
    $ flask run

Options:
  --version  Show the flask version
  --help     Show this message and exit.

Commands:
  routes  Show the routes for the app.
  run     Runs a development server.
  shell   Runs a shell in the app context.

The same happens to run
$ flask run                                                          429ms  Sat 28 Apr 2018 01:32:48 PM -03
 * Serving Flask app "app.py"
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: off
Usage: flask run [OPTIONS]

Error: Could not import "app".

The Error: Could not import "app". could include WARNING: You need to define the app e.g: export FLASK_APP=app.py
Suggestion
We could check the existence of FLASK_APP envvar before running any of the commands in the Group Cli, if FLASK_APP does not exist the dispatch of commands never happens.
Environment

Python version: 3.6.0
Flask version: Flask==1.0
Werkzeug version: Werkzeug==0.14.1
Click: click==6.7

I can implement that and send a PR, just want to know if the idea is acceptable

Anything that improves help messages is great.

Looks better in flask 1.0.2, so maybe we can close this?

with a help option

~/flask flask --help
Traceback (most recent call last):
  File "/Users/username/.local/share/virtualenvs/flask-C1e3YqV7/lib/python3.7/site-packages/flask/cli.py", line 529, in list_commands
    rv.update(info.load_app().cli.list_commands(ctx))
  File "/Users/username/.local/share/virtualenvs/flask-C1e3YqV7/lib/python3.7/site-packages/flask/cli.py", line 384, in load_app
    'Could not locate a Flask application. You did not provide '
flask.cli.NoAppException: Could not locate a Flask application. You did not provide the "FLASK_APP" environment variable, and a "wsgi.py" or "app.py" module was not found in the current directory.
Usage: flask [OPTIONS] COMMAND [ARGS]...

  A general utility script for Flask applications.

  Provides commands from Flask, extensions, and the application. Loads the
  application defined in the FLASK_APP environment variable, or from a
  wsgi.py file. Setting the FLASK_ENV environment variable to 'development'
  will enable debug mode.

    $ export FLASK_APP=hello.py
    $ export FLASK_ENV=development
    $ flask run

Options:
  --version  Show the flask version
  --help     Show this message and exit.

Commands:
  routes  Show the routes for the app.
  run     Runs a development server.
  shell   Runs a shell in the app context.

without any options:

 ~/flask flask run
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
  You did not provide the "FLASK_APP" environment variable, and a "wsgi.py" or "app.py" module was not found in the current directory.

Hola que tal.
Estoy obteniendo el siguiente mensaje al efectuar flask run

Environment: production
WARNING: This is a development server. Do not use it in a production deployment.
Use a production WSGI server instead.
Debug mode: off
Traceback (most recent call last):
File "/home/claudio/python/flask_env/bin/flask", line 8, in
sys.exit(main())
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 966, in main
cli.main(prog_name="python -m flask" if as_module else None)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 586, in main
return super(FlaskGroup, self).main(*args, **kwargs)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/decorators.py", line 73, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 848, in run_command
app = DispatchingApp(info.load_app, use_eager_loading=eager_loading)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 305, in init
self._load_unlocked()
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 330, in _load_unlocked
self._app = rv = self.loader()
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 392, in load_app
app = locate_app(self, import_name, None, raise_if_not_found=False)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 257, in locate_app
return find_best_app(script_info, module)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 83, in find_best_app
app = call_factory(script_info, app_factory)
File "/home/claudio/python/flask_env/lib/python3.7/site-packages/flask/cli.py", line 117, in call_factory
return app_factory(script_info)
File "/home/claudio/python/servpc_spa/app/init.py", line 20, in create_app
app.config.from_object(app_config[config_name])
KeyError: <flask.cli.ScriptInfo object at 0x7fd50d307e48>

what made you think we speak Spanish?

I have this problem too when I run flask app I wonder it what the solution

The various exception messages, including when the env var wasn't set and a default wasn't found, have improved over time. That one now reads:

Could not locate a Flask application. You did not provide the "FLASK_APP" environment variable, and a "wsgi.py" or "app.py" module was not found in the current directory.

Tracebacks were added in #2208 to avoid confusion caused by the previous behavior where list_commands() hid errors completely.
After reviewing the code, I think we should show only the error message for NoAppException, while still showing the full traceback for other exceptions. Tracebacks for loading errors are no longer helpful as they only show Flask internals. We still want to show the help text (or other output) because the flask command itself isn't what's failing. I've also noticed that get_command still completely hides the loading error, resulting in only "no command named X", so that can be improved too.


fix(test): vec3.test.mjs

fix typo on lengthSq test
Fixes test on lengthSq.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Ooo, well spotted. 👀


Adv360 z3.2 3

Board/Shield Check-list

[x] This board/shield is tested working on real hardware
[x] Definitions follow the general style of other shields/boards upstream (Reference)
[x] .zmk.yml metadata file added
[x] Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
[x] General consistent formatting of DeviceTree files
[x] Keymaps do not use deprecated key defines (Check using the upgrader tool)
[x] &pro_micro used in favor of &pro_micro_d/a if applicable
[x] If split, no name added for the right/peripheral half
[x] Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
[x] .conf file has optional extra features commented out
[x] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

Thankl you for this, I have a few notes:
1: ZMK doesn't support more than 32 layers, please trim the colour list back to 32 colours
2: Please document somewhere, maybe in a .md file somewhere what the colours are supposed to be
3: Please fix the pre-commit failures

Closing in favour of #18


try using cluster dns to reach apiserver - for #587

untested, based on suggestion in #587 to fix #153

FWIW, you still need to use the environment variable when implementing a custom DNS server...

Do we? I thought that was the whole point to rely on DNS, rather than use the evars.

This passed integration tests on k3s now.

Do we? I thought that was the whole point to rely on DNS, rather than use the evars. Bumped PR.

Yeah, but the DNS server itself needs to have some way to reach the apiserver as well (chicken-and-egg problem :p). Not contesting that this is the correct solution for 99% of applications though.

Ohh, when implementing a DNS server yeah. I get you. Yeah, I guess we need to expose a (probably non-default) way to decide what method to use when using incluster config.

I think kube-rs should just expose a way to completely override apiserver address (after all, it is perfectly valid for a Kubernetes pod to access apiserver from another cluster). And then user can read environment variables, some configs, etc.

I think kube-rs should just expose a way to completely override apiserver address (after all, it is perfectly valid for a Kubernetes pod to access apiserver from another cluster). And then user can read environment variables, some configs, etc.

This is actually supported out of the box already:
let mut cfg = Config::from_cluster_env(); // or Config::infer
cfg.cluster_url = some_uri;

Going to merge this, tested this locally with controller-rs against a cluster running rustls for sanity so going to speculatively close the related issues. If it turns out to be positive, then we can discuss whether to swap out the default for non-rustls.


Bug parsing interval with negative values

Describe the bug
bug parsing interval that contains negative values
To Reproduce
❯ select (interval '1 month -1 second');
+---------------------------------------------------+
| IntervalMonthDayNano("-1000000000")               |
+---------------------------------------------------+
| 0 years -1 mons -1 days 0 hours 0 mins -1.00 secs |
+---------------------------------------------------+
1 row in set. Query took 0.002 seconds.

this is a parsing issue but not a display issue, underline value is incorrect IntervalMonthDayNano("-1000000000")
Expected behavior
0 year 1 mons 0 days 0 hours 0 mins -1 secs
Additional context
https://github.com/apache/arrow-datafusion/blob/406c1087bc16f8d2a49e5a9b05d2a0e1b67f7aa5/datafusion/common/src/parsers.rs#L151-L152
the binary expression for result nanos (which is 128bit long here) is<PHONE_NUMBER>11111......... which make months and days becomes negative
negative factional seconds has display issue #4220

Thanks for finding this, looks like its not only limited to the nanoseconds portion of IntervalMonthDayNano, but its day portion, as well as the day bits of IntervalDayTime as well
I'll raise a PR for this soon

Wow ⏩ @Jefffrey !

thank you @Jefffrey


Hampran

@danbalogh — could you take look at https://dharmalekha.info/texts/INSIDENKHampran? As a reminder, the estampage was shown in https://github.com/erc-dharma/project-documentation/issues/193. Is it necessary to apply the textpart structure also in translation? Do you approve of my use of <milestone>s in textpart 2?
@aditiagunawan @wayanjarrah @zakariyaaminullah @tyassanti @ekobastiawan : could you take a look at the estampage shown in https://github.com/erc-dharma/project-documentation/issues/193 and give me your opinion on whether the aksaras in B5 use the same script as those in zone C? And can anyone get meaningful words out of B5? (I think it would be worth trying to read it as if it is Merapi-Merbabu script, which some of you know better than I do.) As long as I can't read that line, I don't know whether I have correctly assigned kaw-Latn to textpart 2. Has this part of this inscription figured in any of the publications by Abimarda dll. on the "Merapi-Merbabu" dating system with these kinds of diagrams and circles?
@wayanjarrah, @ekobastiawan @tyassanti : you will be interested to look at the details of my encoding (press the Source view button). I have used some elements from our TEI toolbox that we don't often use. You will also be interested to see how the opening of this line of bibliography is generated with a method we have recently introduced defining a "Shorthand" in the Zotero Extra field (see gdoc of ZG, §4.15).

Thanks!
Arlo

Yes, it is necessary to apply the textpart structure in translation. EGD §9.2.5, "if your edition includes boxlike partitions (§3.4), the textpart divisions of your edition must be mandatorily replicated in your translation (with the same attributes and, if applicable,  elements)".
I'm OK with your use of milestones in textpart 2. I've looked up our earlier discussions on this (in issue #193 and my email reply to you on 1 April 2020) and see that your original inclination was to use separate textparts for each of the little bits but you felt that this was discouraged by the EGD. Back then, I had said that in my opinion the EGD does not forbid doing so, and it seems that I had also made a couple of changes in the EGD text to reduce that discouraging. So I can only repeat that now: there is no strict rule for such unusual cases, and the choice is yours. I'm equally happy with milestones in textpart 2 or multiple textparts instead of textpart 2. If I was doing the encoding of this inscription, I would probably do the latter, but my preference is not strong or definite enough to suggest that you now revise your encoding. If you are happy with it, let it stay.

thanks Dan. I await responses from the others.

@arlogriffiths I feel that the aksaras used in zone C are the same as those in B5. Sorry I can't offer anything more helpful for B5.
Thank you for showing us the Shorthand tactic for NBG. Presumably we will want to apply this across the board for this periodical which is very often mentioned in our inscription's bibliographies. I'm happy to get started on adding the field for the NBG list for now.


segfault on assignment of unknown/unregistered property

Situation:
class A { public: A(){} int a; };
L["A"].setClass( kaguya::UserdataMetatable\<A\>()
 .setConstructors<A()>()
.addProperty("a", &A::a ));
L("a = A.new() a.b=5")
The assignment of an unknown property crashes in:
inline int property_newindex_function(lua_State *L) {
 <**snip/**>
 lua_pushvalue(L, key);
 lua_pushvalue(L, value);
 lua_rawset(L, table); // <- here ( or to be more precise, within lua_rawset)
 return 0;
}
I compiled this on

Linux, gcc 5.4.0, gcc 4.8.2
Windows, vc12 (studio 13)

All with c++11 enabled and with kaguya-master, as of Aug., 10th 2017 (should be current), and lua 5.3.4.
I would expect a lua error (assignment of non-existent property), or an enrichment (a.b->5), not a segfault. Am I doing something wrong?
Any hint appreciated.
Thanks for the good work!

I have dug a little deeper. The problem is that in case of a non-existant property, the property_newindex_function tries to rawset a uservalue, which is illegal.
I added a test for nil type on access to the property and bailed out with luaL_error. This behaves as I would expect it, though not sure what the intent was. Please refer to 84acfd3d6416a660ff1b5175f8cad65da2219b7f.

Thank you for your report. I think better to return nil if getting unregistered property.

Yes, returning nil in this case surely is an option. Though sometimes, a kind of symmetry might be what is desired (one cannot add properties to the uservalue <-> one can not get unregistered properties from the uservalue).
Would you be open to have a compile time flag that decides whether the property get is strict (error on access to unregistered property) or more lua-like (return nil on access to unknown property)?
I made a sketch implementation here: 2654c0cc259f0bfb5ef5504a6241b90f50dedf2a.
Please let me know your thoughts on this.

Thanks for adding the change #72.


Make repo structure more user-friendly

Mostly folders/files were moved although a couple were renamed.
Regarding the file additions: These are placeholders for the CS migration content, mostly. We do not need to include them in the merge.
Proposed structure
├── devops
    ├── infrastructure-as-code
    ├── github-actions
├── flows-advanced
    ├── etl
        ├── advanced-flow-on-etl.py
    ├── ml
        ├── advanced-flow-on-ml.py
├── flows-starter
    ├── logging-example.py
    ├── subflow-example.py
├── imgs
├── prefect-v1-legacy
├── LICENSE
├── README.md

Action items:

Take a look at the material you've contributed in case you disagree with where it was placed.
Look over the proposed new repo restructuring with any thoughts for improvement.

This looks great


Get mix without selecting tags

This PR will

Refine the loading variant for buttons. You can pass the loading, loadingText (optional) props as needed
Add limit and page to mix fn as well as shouldFetch state variable
Fix minor bugs about dependencies not being found
Update home page copy to present choosing tags as an option
Update lucide-react icons package to fix dependency warnings

Closes #57

@hackertron @NicoSerranoP This is a draft PR because I don't have enough mix data to test the page limits and if they work.
Instead of adding more content artificially can we set the page limit to be 2/3 for QA/Testing purposes?

@NicoSerranoP Potentially this Closes #67 too?

@NicoSerranoP Potentially this Closes #67 too?

Yes 🥳


Variables with commas in label throw off parametric exports to csv

Describe the bug
Parametric exports to csv misalign columns when there is a comma in the variable title
Expected behavior
Either commas cannot be included in variable labels or checking needs to occur in the export to csv
Screenshots

Operating System and Version

OS: [Windows, macOS, Linux]
Version [e.g. SAM 2020.2.29 r3]

@mjprilliman I think commas should be avoided in variable labels. I will clean up these BOS variables for the PV, HCPV, PV Battery and Fuel Cell cost UI forms, but there may be other instances on other forms.

For fuel cell costs, clean up current

to look like this:

Latest test case

With pull request 767, test case results in exported csv:

Test case attached here:
SAM_670_test.zip


DBZ-4047 Fix commit message action for multi-line commits

https://issues.redhat.com/browse/DBZ-4047

@rk3rn3r, can you take a look and merge? Thx!

LGTM @ani-sha even without that small wording suggestion above. Nice work!


[fix](fe memory) Fix fe schema change high memory usage

Proposed changes
Fix fe schema change high memory usage.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTNM

LGTM


Use gomega matcher in webhook validation testings

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, we re declare the error type in the clusterqueue webhook integration testings and reuse those in most of webhook integration test cases.
https://github.com/kubernetes-sigs/kueue/blob/31c421356d8decd616fd37ac063aa3cf1b82e1e8/test/integration/webhook/core/clusterqueue_test.go#L38-L42
However, we already have dedicated error matcher. So, I remove the redundant error type checkings and reuse the testing utils.
https://github.com/kubernetes-sigs/kueue/blob/31c421356d8decd616fd37ac063aa3cf1b82e1e8/pkg/util/testing/error_matchers.go
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @mbobrovskyi

/lgtm
Awesome thank you so much!


I translate your Readme.md file! (Korean.ver)

Description
I translate your Readme.md file.
follow this Link and confirm it please.
thank you.
https://github.com/Netflix/pollyjs/compare/Netflix:master...rlathgml1004:master

@rlathgml1004 we're unable to officially support Korean officially since we do not speak Korean nor have a translation service setup to maintain changes to the docs going forward.

thak you for confirming my contriburiton.
-----Original Message-----
From: "Jason<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2020-05-28 (목) 14:43:57 (GMT+09:00)
Subject: Re: [Netflix/pollyjs] I translate your Readme.md file! (Korean.ver) (#339)
@rlathgml1004 we're unable to support Korean officially since we do not speak Korean nor have a translation service setup to maintain changes to the docs going forward.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


[Backport][1.37.x] Add kokoro job for xds psm security tests

Backport #26033, #26041, #26046, #26050, #26051

Thanks Sergii! Updated


Problem starting bot on new install

Hi guys,
just done a new install and the bot wont start , this is the error i am getting.
``Traceback (most recent call last):
File "pokecli.py", line 781, in
main()
File "pokecli.py", line 217, in main
report_summary(bot)
File "pokecli.py", line 265, in report_summary
metrics.capture_stats()
File "/home/jonathan/Poke/h/PokemonGo-Bot/pokemongo_bot/metrics.py", line 108, in capture_stats
response_dict = request.call()
File "/home/jonathan/Poke/h/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 223, in call
if not self.can_call():
File "/home/jonathan/Poke/h/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 128, in can_call
raise NotLoggedInException()
pgoapi.exceptions.NotLoggedInException
[2016-08-31 20:01:03] [sentry.errors] [ERROR] Sentry responded with an error: 'module' object has no attribute 'HTTPSHandler' (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
File "/home/jonathan/Poke/h/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
super(ThreadedHTTPTransport, self).send(data, headers)
File "/home/jonathan/Poke/h/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
ca_certs=self.ca_certs,
File "/home/jonathan/Poke/h/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 44, in urlopen
class ValidHTTPSHandler(urllib2.HTTPSHandler):
AttributeError: 'module' object has no attribute 'HTTPSHandler'
[2016-08-31 20:01:03] [sentry.errors.uncaught] [ERROR] [u'NotLoggedInException', u'  File "pokecli.py", line 781, in ', u'  File "pokecli.py", line 217, in main', u'  File "pokecli.py", line 265, in report_summary', u'  File "pokemongo_bot/metrics.py", line 108, in capture_stats', u'  File "pokemongo_bot/api_wrapper.py", line 223, in call', u'  File "pokemongo_bot/api_wrapper.py", line 128, in can_call']
cheers

try with encrypt.dll 32bit

i am using dabian sorry not windows, i should have said


Add key ordering back to python api.

There's no order in the new plot schema.

Wouldn't loading up the plot-schema json with as an ordered dict suffice?

sorta. i think this is still hard to test though, if we made a change in the plot-schema and the new hashes changed the order of the stored json, then loading this new json as an ordered dict would break tests, right? we have to set an order in plot-schema.json before we can start using the OrderedDict ordered_pairs hook. Right?

@theengineear That sounds like another syncing nightmare.
Why would we need to test the order of the plot-schema?
Doesn't validation only care of the existence of the attributes, not their position in the plot-schema?
Are you concerned about the output of the help method?

Testing to_string is nearly impossible without having a predictable order.
Just in case we're not on the same page. As far as updating the python api goes, I really don't care or need the plot schema to have a consistent order. I do some exceedingly simple ordering in the python api so that the to_string test result will pass. But that's all. This is highly :football:-able as far as I'm concerned.
I created an issue because we would ideally like better help and I think there's some documentation-related needs for ordering in the plot schema.
The python api has no intention of testing full ordering, but just a small subset needs to be predictable in order to test the to_string method.
@chriddyp :wind_chime:-ed in on this earlier though and might have more opinions on it.

@theengineear all good :+1:


[BUG] Exception while trying to mass delete a belt place holder

If you place a long line of belts and then attempt to delete the place holder before your drones have built them then you will get an exception in game.

In the second picture if you attempt to mass delete a yellow segment you get the error in the first screen shot.

Alright, nice catch ! I'll look into it :)

I have also encountered this bug, but I do not have CopyInserters enabled. Has this been tried in the vanilla game? May be a vanilla bug.

Qol is offically deprecated : someone did better : https://dsp.thunderstore.io/package/brokenmass/MultiDestruct/


lens becomes unusable with 15,000 pods and 260 nodes

similar to https://github.com/lensapp/lens/issues/5041, but with those numbers lens was somewhat usable despite the hangs.
when scaling 15,000 pods (1 cpu req/limit each) and hitting 260+ nodes, the hangs take 10s+ on m1 pro

once the scale up stops, there are less events (or smth) and then it's usable again

Duplicate of https://github.com/lensapp/lens/issues/2243


Roll Flutter Engine from b531a5ae27fc to e717c991fecd (2 revisions)

https://github.com/flutter/engine/compare/b531a5ae27fc...e717c991fecd
2024-07-13<EMAIL_ADDRESS>Roll Skia from 6041fb033e38 to 2763d99b335e (1 revision) (flutter/engine#53862)
2024-07-13<EMAIL_ADDRESS>Roll Skia from 0257e2adc7a4 to 6041fb033e38 (1 revision) (flutter/engine#53860)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.