Group Display

There should be an option to display group names in alphabetical order. It doesn't look like there is any way to organize them. Also, why do the group names have a number in parenthesis after the name, like (1) or (2)?

Duplicate of #7
Yes, it is planned. I am slowly adding features.
It is the number of tabs inside the group.


Patch to 19-action-to-use-quarto

Hey @AFg6K7h4fhy2, I think this fixes the last bit you need for your PR to work properly.

This PR will be removed once #49 (where most development has occurred) is merged. Thank you again George for your help. This small change to the PR (in addition to adding quotes in one of the lines) is what got the workflow working.


Trim build paths for binaries

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This helps to produce a more uniform output, especially for critest:
[Fail] [k8s.io] Container runtime should support log [BeforeEach] runtime should support reopening container log [Conformance]
github.com/kubernetes-sigs/cri-tools/pkg/framework/util.go:225

Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Trim file paths from `critest` outputs

/lgtm


Default to using service account tokens for DNS.

DO NOT MERGE until the container is finally pushed, after LGTM.
@ArtfulCoder @vishh

Issue? Risk level? Milestone?

This is not viable yet - CA info is not available, and I assumed the service acct token was a kubecfg, but it's not.  I honestly have no idea HOW this is working, but it is.

It turns out that we already default to using service accounts for DNS due to this check: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/client/clientcmd/merged_client_builder.go#L50
ugh...


Feature Request : Add a max number of displayed notification

The idea i suggest is to have a new parameter on configuration who is the max number of notification displayed on the screen. We can imagine that when max number is reach, the oldest notifications are replaced with the new one.

Options added by 1d74f50c41b7fe3ab57534822f1490b9080feaf3


⚠ ClamAV has degraded performance

In d439f37, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in b348351.


⚠ Bofrost.at has degraded performance

In 5596530, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1519 ms

Resolved: Bofrost.at performance has improved in 0e34a94.


make editor take whole height

fixes #95

@kwkr when Sierra is selected in the dropdown we still have a problem

@mazurroman thanks for pointing this out! For some reason, a fixed height was set on the InstructionsTable components. I removed it and now also CASM and Sierra take the full height.  I tested it now with some longer snippet of code (that generates longer Sierra) and the whole space is used now. If there was some specific reason for using the fixed height, please let me know and I will find other way that takes into account the additional context.
Tested with the following code:
fn foo(x: u8, y: u8) {}

fn main() {
    let first_arg = 3;
    let second_arg = 4;
    foo(x: first_arg, y: second_arg);
    let x = 1;
    let y = 2;
    foo(:x, :y)
}

it's working good now @kwkr !
can you also add a comment on #95 so that I can assign that issue to you. It's better to get an issue assigned before working on it to ensure two ppl are not working on the same issue simultaneously.

Okay, sorry, next time I will start with a comment on an issue to keep it more organized.


Using env.json file results in error: "cannot unmarshal object into Go value of type string"

Operating system: Mac OS X Sierra 10.12.1
Apex Version: 0.11.0

I'm attempting to test out setting environment variables using a JSON file as described here. Using the sample env.json file, I try to deploy with the -env-file flag:
$ apex deploy --env-file ./env.json -ldebug
   • loading functions in functions
   • open                      env= function=main
   • inferring runtime         env= function=main
   • inferred runtime          env= function=main runtime=nodejs4.3
   • load env from file "./env.json"
   ⨯ Error: reading env file "./env.json": json: cannot unmarshal object into Go value of type string

Any help is greatly appreciated!

For reference, I'm copying and pasting the env.json file linked above:
{
  "environment": {
    "LOGGLY_TOKEN": "12314212213123"
  }
}

Also, I'm able to set environment variables just fine using the command line -s arguments.

env.json expects the top-level keys to be environment variables (no need for environment key):
{
  "LOGGLY_TOKEN": "12314212213123"
}

I've updated the docs in https://github.com/apex/apex/pull/606

@DenisGorbachev I've confirmed that works, thank you for the info and the doc update!


Remove not requried arial role samentic from button.

This is an overshot here as the button has all semantics and behaviour
in place.
Thanks!

Sorry for the very late response and thanks for the contribution! I'll push your update when I'll make the version for 3.1
Thanks again


Remove GN build rule dependencies in Fuchsia

Action item from postmortem123362 (Flutter-Fuchsia rolls failed for 20 days).
cc @iskakaushik, who owns the item on the postmortem.

flutter_app.gni (source) is the current way to build flutter apps on Fuchsia. Ideally we would use Flutter tool to build apps in the Fuchsia tree. This lets us remove both flutter_app and dart_app gni rules from the Fuchsia tree.

x-ref: https://github.com/flutter/flutter/issues/43836

flutter_app.gni and dart_app.gni have features that would be difficult to replicate in the flutter tool, and which are probably out of scope for the flutter tool.
Additionally, this would require the Fuchsia build to inject different implementations of a few components into the flutter tool as is done for internal builds. I would very much prefer to avoid propagating that model.
I think we should try to zero in a bit more on what the problem we're solving here is, and avoid jumping to a solution.

I was looking at this recently and I really don't understand why Fuchsia needs any build rules at all for Flutter. It seems like components should specify their need for Fuchsia in their CMX manifest. Or are the build rules just for driving the flutter build tool to compile the code? In which case it seems like that shouldn't be something Flutter needs to deal with at all, it's just a Fuchsia tree implementation detail?

Or are the build rules just for driving the flutter build tool to compile the code? In which case it seems like that shouldn't be something Flutter needs to deal with at all, it's just a Fuchsia tree implementation detail?

The Fuchsia build of Flutter apps is driven by the GN rules in flutter_app.gni, and doesn't go through the flutter tool with one exception. It uses an entry point in the Flutter tool for bundling assets: bin/fuchsia_asset_builder.dart
This issue could be about one of two things:

Re-write flutter_app.gni to delegate to the flutter tool for everything, not just asset bundling.
Shift flutter_app.gni to be more self-contained, and move it back to the Fuchsia tree. That is, eliminate the dependency on fuchsia_asset_builder.dart.

I think (1) is not the right approach for reasons stated above. (2) seems more tractable since fuchsia_asset_builder.dart is not a big script.

Can you elaborate on why the flutter tool isn't the right way to build for Fuchsia? Do you just mean for in-tree apps? I'm not sure I follow.

Yeah, I mean just for in-tree apps. The in-tree build rules can do some fancy things that we may or may not want the flutter tool to do, for example packaging multiple flutter and dart "components" into the same Fuchsia package.

IMHO we should consider each of those things and decide whether they're really valuable or not; for those that aren't we should just stop doing them in the fuchsia tree and for those that are we should support them in the tool (and likely on all platforms).

Current behavior is that the Fuchsia tree no longer depends on the engine sources, so we should delete the unused rules from the engine sources. The rules still exist in the topaz tree and deviate slightly from what we get if we use flutter build for a Fuchsia app. I will document these ways so we can make a decision to either move them to the tool or if we should deprecate/delete them from the Fuchsia tree. I will report back with my findings here.
Given that there is no longer a source dependency on the flutter/engine repo in the Fuchsia tree, I will remove the "customer critical" label from the issue. If you disagree, please add it back.

There is an internal proposal about structuring the dependencies between flutter/dart/fuchsia. The agreement reached there will have impact on this project: go/flutter-on-fuchsia-stable-rolls. I will be pushing the milestone of this and un-assigning myself as its unclear if I will be the one working on this.

Closing as obsolete.


New feature idea: Contributors page to include SiG/CoP

It could be cool if people are in a Community of Practice if this was automatically shown on their Contributor page.

yeah so with #4408 we're considering adding an "affiliation" field where people could affiliate themselves with specific organisations, it would definitely be possible to have an organisation that was a CoP and then show all the user's orgs on their page.


Image Captioning Test Error

When I test the model using jupyter notebook. I got the error below
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
/disk/clw/pytorch-tutorial/tutorials/03-advanced/image_captioning/sample.py in <module>()
     95                         help='number of layers in lstm')
     96     args = parser.parse_args()
---> 97     main(args)

/disk/clw/pytorch-tutorial/tutorials/03-advanced/image_captioning/sample.py in main(args)
     59     # Generate caption from image
     60     feature = encoder(image_tensor)
---> 61     sampled_ids = decoder.sample(feature)
     62     sampled_ids = sampled_ids.cpu().data.numpy()
     63

/disk/clw/pytorch-tutorial/tutorials/03-advanced/image_captioning/model.py in sample(self, features, states)
     66             inputs = self.embed(predicted)
     67             inputs = inputs.unsqueeze(1)                         # (batch_size, 1, embed_size)
---> 68         sampled_ids = torch.cat(sampled_ids, 1)                  # (batch_size, 20)
     69         return sampled_ids.squeeze()

RuntimeError: dimension out of range (expected to be in range of [-1, 0], but got 1)

It seems there maybe someting wrong with the torch.cat() method. But When I use torch. stack() method, everything goes well.
So maybe we should use the torch.stack()  instead.

If you are testing a single image, sampled_ids = torch.cat(sampled_ids, 0)  will do the trick. I suggest you to print sampled_ids before and after this operation and see the little change it brings to the table :).

@icfear
I reviewed the code in sample.py. If just testing a single image, then sampled_ids = torch.cat(sampled_ids, 0) will correctly get the captions. But looking at the comments in model.py,  I still think that we should use torch.stack instead.

Sorry for the late reply. This has been fixed in the current version.


how is the GCP service key used?

This is a question.
I noticed that the service key provided as a value to the chart is put into /etc/service_key.
From here, is it automatically used bykubectl, helm and gcloud?

GCP service account is needed if you want to access private GCR registry

Yes I understand that but how is passed to kubctl, helm et all? Like in the code. How does kubectl know the key is in /etc/service_key?

the service account file (which can push to registry, deploy to kubernetes and etc)  gcr_service_account.key gets amounted to: /etc/service_key folder.
The in your Buildkite pipeline you can use it as:
export GOOGLE_APPLICATION_CREDENTIALS=/etc/service_key/gcr_service_account.key

then kubectl, gcloud and will work for you.

Awesome, thanks for clarifying.


How to set the delay time when release on edge for mouse wheel?

I have set the mousewheel to true as well as releaseOnEdge parameter, now I found a small issue, when scrolling to the last slide, the mouse wheel is released to fast and the page scroll down immediately so that the user can't see the last slide.
So is there any method to set the delay time to release the mouse wheel? At least, after scroll to the last slide, then scroll again, just release.
My code is below, I just use Swiper 5.4.5.
var slider = new Swiper ('.slider-container', {
      // Optional parameters
      direction: 'vertical',
      loop: false,
      speed: 1000,
      effect: 'fade',
      mousewheel: {
        releaseOnEdges: true,
        sensitivity: -10000,
        eventsTarget: slider,
        forceToAxis: true
      }
);

Do you want to ask a question? Are you looking for support? Stack Overflow is the best places for getting support

Please, don't use GitHub issues for questions


Can not install in NestJS 9

Normal install

Version 3 install

Any update on this? This is so frustrating. I upgraded to NestJs 10 even, then it does not work with the upgraded rimraf version.


Rio git ssh on custom port trying to connect to port 22 instead of custom port

Describe the bug
When I rio run from git on a custom port (eg 30022), rio is trying to git clone to port 22
To Reproduce

rio run --build-clone-secret gitcredential-ssh git@my.domain:30022/my-repo/my-project.git

Expected behavior
git access to port 30022
Kubernetes version & type (GKE, on-prem): kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T21:03:42Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T20:55:23Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Type:
Rio version: rio info
Rio Version: v0.7.0 (4afd4901)
Rio CLI Version: v0.7.0 (4afd4901)
Cluster Domain: XXX.on-rio.io
Cluster Domain IPs: xxxx
System Namespace: rio-system
Wildcard certificates: XXX.on-rio.io(true)

Additional context
rio ps
output:
Failed to watch git repo: Warning: Permanently added 'my.domain,my.ip' (ECDSA) to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
: exit status 128(Error)

ssh<EMAIL_ADDRESS>-p 30022
output:
PTY allocation request failed on channel 0
Welcome to GitLab, @root!
Connection to my.domain closed.

Does regular "git clone" work with a string like that?  There's no way to differentiate it from a regular user@host:path string where the first path segment happens to be a number.
I don't know if we support it already or not but you'd have to use something like thessh://user@host:port/path form instead.

Yes
git clone ssh://git@my-domain:30022/my-repo/my-project.git
output:
git clone ssh://git@my-domain:30022/my-repo/my-project.git
Cloning into 'my-project'...
remote: Enumerating objects: 7106, done.
remote: Counting objects: 100% (7106/7106), done.
remote: Compressing objects: 100% (2343/2343), done.
remote: Total 7106 (delta 4472), reused 7033 (delta 4405), pack-reused 0
Receiving objects: 100% (7106/7106), 51.27 MiB | 51.67 MiB/s, done.
Resolving deltas: 100% (4472/4472), done.

I tried ssh://user@host:port/path and I get exactly the same problem.
If RIO don't support this format, do you plan to soon ?

Does regular "git clone" work with a string like that? There's no way to differentiate it from a regular user@host:path string where the first path segment happens to be a number.
I don't know if we support it already or not but you'd have to use something like thessh://user@host:port/path form instead.

@vincent99 I think this is not an issue to find the port number because it is between the end of the url and ':' if it exists, otherwise there is no port and no ':'.

After some test, here is the situation.
Using repo: ssh://git@my.domain:30022/my-repo/my-project.git is not connecting on port 30022 but on port 22


Pacific Atlantic Water Flow

There is an m x n rectangular island that borders both the Pacific Ocean and Atlantic Ocean. The Pacific Ocean touches the island's left and top edges, and the Atlantic Ocean touches the island's right and bottom edges.
The island is partitioned into a grid of square cells. You are given an m x n integer matrix heights where heights[r][c] represents the height above sea level of the cell at coordinate (r, c).
The island receives a lot of rain, and the rain water can flow to neighboring cells directly north, south, east, and west if the neighboring cell's height is less than or equal to the current cell's height. Water can flow from any cell adjacent to an ocean into the ocean.
Return a 2D list of grid coordinates result where result[i] = [ri, ci] denotes that rain water can flow from cell (ri, ci) to both the Pacific and Atlantic oceans.
Example 1:

Input: heights = [[1,2,2,3,5],[3,2,3,4,4],[2,4,5,3,1],[6,7,1,4,5],[5,1,1,2,4]]
Output: [[0,4],[1,3],[1,4],[2,2],[3,0],[3,1],[4,0]]
Explanation: The following cells can flow to the Pacific and Atlantic oceans, as shown below:
[0,4]: [0,4] -> Pacific Ocean
[0,4] -> Atlantic Ocean
[1,3]: [1,3] -> [0,3] -> Pacific Ocean
[1,3] -> [1,4] -> Atlantic Ocean
[1,4]: [1,4] -> [1,3] -> [0,3] -> Pacific Ocean
[1,4] -> Atlantic Ocean
[2,2]: [2,2] -> [1,2] -> [0,2] -> Pacific Ocean
[2,2] -> [2,3] -> [2,4] -> Atlantic Ocean
[3,0]: [3,0] -> Pacific Ocean
[3,0] -> [4,0] -> Atlantic Ocean
[3,1]: [3,1] -> [3,0] -> Pacific Ocean
[3,1] -> [4,1] -> Atlantic Ocean
[4,0]: [4,0] -> Pacific Ocean
[4,0] -> Atlantic Ocean
Note that there are other possible paths for these cells to flow to the Pacific and Atlantic oceans.
Example 2:
Input: heights = [[1]]
Output: [[0,0]]
Explanation: The water can flow from the only cell to the Pacific and Atlantic oceans.
Constraints:
m == heights.length
n == heights[r].length
1 <= m, n <= 200
0 <= heights[r][c] <= 105

Rucha Gosavi
I would like to work on this issue


Use commit title instead of initial version for initial spr message

Use the actual commit title instead of [𝘀𝗽𝗿] initial version for the initial spr message. This is useful for instances where you are working in a repository with commit linting.
For example, if the repository requires that the first commit of each code change has a JIRA ticket in the commit message, the lint rule will fail.

@spacedentist Do you see any issues with this PR?


Sync failure after session wake up

After PC wakes up, it makes a successful check only ones, then it stops checking completely.
In the screenshot, you can see that the check duration is set to 1 minute. The last check time is 10:46 which is the time I woke the PC up. Now the time has past 10:47 but it's not checking anymore.
It starts checking properly only after I restart the app.

Hi @XtroTheArctic,
Thanks for reporting this.
Can you tell me if you paused the synchronization before your session goes to sleep mode?

Anyway, I will investigate on this as soon as possible.

No. This is the default behavior and it happens always. I didn't even know I could pause the synchronization.

I have a test finding about this.
While looking at the code, I noticed that you set UI.timer.Enabled to true only when this happens: target.Reason == SessionSwitchReason.SessionUnlock
Then I tried this. Woke the computer up from sleep, checked the last update time to make sure it is suspended.
Locked the computer manually and unlocked it.
Checked the last update and saw that it started working fine after unlocking the computer.
Looks like you need to set UI.timer.Enabled to true when the computer wakes up too because not all users use the lock screen after waking up the computer.

I added this line in Computer.BindPowerMode method in my fork repo and it fixed the problem for me.
				else if (target.Mode == PowerModes.Resume) UI.timer.Enabled = true;

@XtroTheArctic Thanks for investigating.
There are a lot of things to take into consideration, not only the lock screen.
I take the time to investigate.


would you support router macros like rocket？

like title

Hi @Silentdoer, thanks for opening this issue! We currently consider routing macros to be an anti-goal, as it's a different direction than where we're trying to take Tide. But I'd still be keen to learn more why you'd like these macros. Is Tide not doing something you wish it would?

I'm sorry for my bad english, just see the ntex codes and comments:
`use ntex::web::{self, HttpServer, App};
#[ntex::main]
async fn main() -> std::io::Result<()> {
let endpoint = "<IP_ADDRESS>:8080";
println!("Starting server at: {:?}", endpoint);
HttpServer::new(|| {
// this usage is more simply
App::new().service(test)
.route("/test2", web::get().to(test2))
}).bind(endpoint)?
.run()
.await
}
// this declare in other mod, we can clearly know the affect of test(..)
// if not have routing macros, i can't know test is get/post..., and we can set more info in this macro
#[web::get("/test/{name}")]
async fn test(name: web::types::Path) -> String {
format!("test ok {}", name)
}
async fn test2() -> &'static str {
"test2 ok"
}`

@Silentdoer Thanks for clarifying! We used to have a similar mechanism back in 2018/early 2019 but we moved away from it to what we have now. The benefits of what we have now is that routes are defined in a single file, and each endpoint has the same function signature.
There are obvious benefits to the proc-macro approach as well, but we didn't think the benefits outweighed the downsides. Hope that clarifies it somewhat!


Feature Request: Druid Circle of Spores Features

Hi,
Would it be possible to add the features from Circle of Spores subclass for Druid (https://www.dndbeyond.com/classes/druid#CircleofSpores)?
Thanks

This is already in the feature requests on the discord server, we will only be using the discord for regular feature requests from now on.


PMD flags tests with no asserts

I noticed that PMD is flagging tests with no asserts in some of the Apex test classes.  Not a big deal at all, but it's interesting what gets trapped by PMD.
Apex unit test classes should have at least one System.assert() or assertEquals()   or AssertNotEquals() call (rule: Best   Practices-ApexUnitTestClassShouldHaveAsserts)
Classes flagged:
force-app/main/default/classes/dlrs_AccountTest.cls
force-app/main/default/classes/dlrs_AuthorisationTest.cls
force-app/main/default/classes/dlrs_CaseTest.cls
force-app/main/default/classes/dlrs_ContactTest.cls
force-app/main/default/classes/dlrs_Tax_Payer_RegistrationTest.cls
It flags lots of other things that are immaterial, but you may want to consider adding an assert here and there.

Dup of #581


Provide public interface to examine a metric samples

I'm currently developing a helper package to allow developers to easily instrument their code and enforce best practices and internal conventions behind the scenes.
One of my use cases, requires me to be able to have access to the samples set on a metric. However there is no public interface to do so.
MetricWrapperBase does implement a collect() method which returns the information I am looking for but not in a way that is clean to parse. For example, getting a dictionary of the labels set on a sample.
Would it be possible to provide a public interface to get access to a metric's samples?
Thank you!

The collect() method is the interface, and though can go via the registry's collect method instead to be a  bit more general.

So, you would suggest to parse the repr string of the Metric object?

Why would you need to do that? It's a struct.

So obvisouly I don't get what you're suggesting, if you could be more explicit it would greatly help. Thank you

Use the existing APIs, there's an example at https://github.com/prometheus/client_python/blob/master/prometheus_client/bridge/graphite.py
This is a question about existing features, so it makes more sense to ask questions like this on the prometheus-developers mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.

Thanks


gradle fails to find files in the cache

I preserve cache after the successful build and leave it in $GRADLE_USER_HOME/caches.
Then, in VM, this cache directory is restored. However, the build now fails:
$ gradle --offline --build-cache localJar
...
===>  Building for gatk-<IP_ADDRESS>
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'gatk'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not download gradle-download-task.jar (de.undercouch:gradle-download-task:2.1.0): No cached version available for offline mode
   > Could not download shadow.jar (com.github.jengelman.gradle.plugins:shadow:1.2.3): No cached version available for offline mode

GRADLE_USER_HOME is set where caches is located, and these files are in it.
What is wrong? Why can't gradle now can't find gradle-download-task-2.1.0.jar and shadow-1.2.3.jar that are in the cache?
gradle-4.6
FereBSD 11.2 amd64

After some experimentation, I figured out that gradle memorizes the full cache path location in the cache itself. When the package is built, it has to reuse cache built while at another location.
How to use only relative locations in cache?

This has never been solved: https://github.com/gradle/gradle/issues/1338

Duplicate of #1338


AWS Elastic Load Balancer access log

AWS ELB access log has a new format now.
My log looks like this:
2015-08-01T00:00:39.092804Z awseb-e-c-AWSEBLoa-IT1XXX1234124 <IP_ADDRESS>44:18031 <IP_ADDRESS>:80 0.000038 0.543988 0.000071 200 200 0 153373 "GET http://www.site.com:80/api/v2/get HTTP/1.1" "Dalvik/1.6.0 (Linux; U; Android 4.4.2; LG-D605 Build/KOT49I.D60520e)" - -

This is the format as looks like in AWS ELB documentation:
timestamp elb client:port backend:port request_processing_time backend_processing_time response_processing_time elb_status_code backend_status_code received_bytes sent_bytes "request" "user_agent" ssl_cipher ssl_protocol

I tried with
log_format %x %^ %h %^ %^ %T %^ %^ %s %^ %b "%m %U %H" "%u" %^ %^
date_format  %Y-%m-%d

but this doesn't work.
Can anyone help me?
Thanks!
p.s. i opened this issue and commented the old one https://github.com/allinurl/goaccess/issues/73#issuecomment-127257305

The following works (v0.9.2), just make sure you have a valid IP:
log-format: %dT%t.%^ %^ %h:%^ %^ %T %^ %^ %^ %s %^ %b "%r" "%u"
date-format %Y-%m-%d
time-format %H:%M:%S

It works :+1:
Thank you @allinurl

:+1:


⚠ Bofrost.de has degraded performance

In 3f4147d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1791 ms

Resolved: Bofrost.de performance has improved in 680d4a9.


⚠ Web Monitor has degraded performance

In 94c7655, Web Monitor (https://monitor.culturecloud.eu.org) experienced degraded performance:

HTTP code: 502
Response time: 12904 ms

Resolved: Web Monitor performance has improved in 1871056.


Verifier mutation of the jws property

   1. Verifier must check for a Credential Signature Failure due to mutation of the jws property
      ✕ should pass with no mutation (969ms)
      ✓ should fail with with mutation (613ms)

Expected: 200
Received: 400

  171 |             };
  172 |             const res = await help.postJson(endpoint, body);
> 173 |             expect(res.status).toBe(200);
      |                                ^
  174 |             expect(res.body.checks).toEqual(["proof"]);
  175 |           });
  176 |           it("should fail with with mutation", async () => {

This has been fixed as part of https://github.com/w3c-ccg/vc-examples/pull/49.


Possible XSS in issue dependancies

Gitea version (or commit ref): release 1.6.1
Git version: 2.11.0
Operating system: Debian 9.6
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes, at https://try.gitea.io/Simia_/test-repository/issues/1
[ ] No
[ ] Not relevant

Log gist:

Description
When adding an issue with an HTML tag in the title, said HTML doesn't seem to be escaped.
In this example, the <select> tag in the title is displayed as an actual <select>

I can confirm this.

@simia-zaru Can you please email<EMAIL_ADDRESS>

Similarly for milestone descriptions.

Actually there's a flash on the application of a milestone title to an issue whereby it will execute an embedded script.

@simia-zaru thanks for the report. You will be thanked in our release blog post.


Could do with a more detailed usage guide

This looks good an app, but I wouldn't want to install it unless there's a bit more detail on how it's typically used

Any specifics you can point me to on what I can add?

Something like an example workflow as a code snippet, and if there's any advanced options detailing those.


Question: How does this work again?

I might be confused about the inner workings of ICP but it is my understanding that regardless of subnet allowance a canister can be at most 4gb in size . This would seem to imply that you need to dynamically create new canisters no? Is this done here and I missed it?

Hey there.
No, canisters can be more than 4GB in size, because of stable memory. This memory lives outside canister's heap and you can address it with 64-bit pointers, despite the fact that wasm is a 32-bit environment.
This library introduces a custom stable memory allocator, that enables your dapp to easily use this 64-bit pointers, and uses it in order to implement custom data collections, which can hold as many data, as the subnet would allow it to hold.
A single subnet is limited with 300GB of stable memory. So, if your canister is the only one presenting in a subnet it can take over all these 300GB of memory.

It turns out, that none of us was right.
Read this thread to know more https://forum.dfinity.org/t/ic-stable-memory-rust-library/14158/19


Bump boot2docker iso/cli versions to 1.6 in script

Not sure how I missed this big thing lol.
Signed-off-by: Ahmet Alp Balkan<EMAIL_ADDRESS>cc: @tianon @SvenDowideit

LGTM :+1:


Installing WinGet does not work on Windows Server 2022 20348.1850

Describe the bug
Installing programs do not work at least on Windows Server 2022
To Reproduce
(This is as administrator, as required)
On Windows Server 2022 with July 2023 patches, up to date (20348.1850)
Run the script,
say N to installing Chocolatey, (I reran the script with Y to let it install just to see, still did not function with chocolatey.)
select some programs (VC++x86,x64, .NET 3.1, 5, 6 Runtimes are what I selected),
click Install Selection,
Observe it attempting to install winget using the "Alternative Installer" and
Observe "Winget failed to install"
Expected behavior
For it to work
Screenshots

Additional context
This server is a domain controller. Not in production (to ease your nerves.)
P.S. I watched your video about fixing bugs most recently and it occurred to me I have never tried your tool and always ripped out pieces of Windows myself. Figured I would try it on a untouched VM like this one. Immediately bumped into this.

titus will fix the script soon but for now you can use atheroto winget install script it works every time
https://github.com/asheroto/winget-installer

Fixed in commit #917 today
Revamped Winget installation to not use microsoft store at all


docker-machine 0.5.1+ is incompatible with 0.5.0 drivers

It seems that drivers shipped with 0.5.0 export the RPC service as RpcServerDriver and the 0.5.1+ docker-machine try to connect to a RPCServerDriver.
An attempt was made to fix this issue with this commit. Now drivers register on both RpcServerDriver and RPCServerDriver. But that's not enough, docker-machine should try to connect to both names.

Closed with https://github.com/docker/machine/pull/2476


Unable to set result fetch size in 22.2.5

Description
Unable to set result fetch size in 22.2.5

Before it was like:

Maybe there is a setting somewhere but I can't find it - anyway this possibility to set fetch size on the fly is very important and handy to me.
DBeaver Version
CE 22.2.5
Operating System
win 10
Steps to reproduce
Just select on table with more than 200 rows

Hello @DamijanD
What database do you use?

This was tested with oracle (jdbc)

You can use the "Configure" button to go to the preferences.

Yes I can -  but I don't know if this is by design or it is a bug that this option is now removed from status bar. Anyway in my humble opinion this was very useful to have it here where you need it and (if this is by design) I would say that this change is step back

Also for me this change is a step back, i usually change the fetch size many times at once executing query.
I ve to return to the 22.2.3

Agree.
I'm used to changing the number of fetch with one click. Now need to go somewhere else to do this.
Also, I think it's UI bug because of this

please bring back the 'fetch' buttons!

Hello everyone. You can vote with any emoji on the main topic to help us understand - that this feature was essential for you.

I use the FetchAll hundreds of times a day.   I found it nested in the Navigate menu (doesn't seem like navigation..shouldn't it be data? or even 'sql editor')  and that told me the hot-key, but it still seems like a button worth having.  They could just have it be tied to the 'count rows' button that's there.   Clicking it again would fetch the rows it just counted.  ;)

please bring back the 'fetch' buttons!

The disappearance of fetch all is incredibly annoying. definitely going to revert to the previous version until this is addressed.

Thank you for bringing back the button fetch all rows!


Stays white

Hi Brent.
First, thanks a lot for the very helpful components you are building!
I can't get the gradient to work though, the box stays white.
I'm pretty sure I included and compiled everything correctly. And when I set wrong values to the colors attribute I get the correct errors (e.g. not an array, not a color etc)
Any ideas, where I could have gone wrong? I'm using react-native 0.4.2 and iOS SDK 8.3.
Thanks for your help.
Cheers
Georg

I'm completely new to Objective-C and no idea if this is of any relevance, but in BVLinearGradient.m Line 22:23 XCode shows a warning
Incompatible pointer types sending 'CGColorRef' (aka 'struct CGColor *') to parameter of type 'id'

Hey @dvine-multimedia! Can you post the code that you're using? I'll give it a try :)

Hi Brent.
I figured it out. The LinearGradient box inherits the background color from it's paren't and this overrides the gradient. If I manually set it back to "transparent" it works. Maybe the gradient could overrider the background color instead?

Ah, that's a good idea, could you submit a PR for that?

Hey Brent,
Thanks for the demo app and components! I'm having the same issue as @dvine-multimedia but am unable to resolve using the backgroundColor: 'transparent' on the parent component mentioned above. I wonder if the Background Color Propagation update in v0.6.0-rc didn't break something? https://github.com/facebook/react-native/releases/tag/v0.6.0-rc
Thanks,
Zach

scratch v0.6.0-rc being my problem...not using that release

@johnnythecakes - what if you set the style={{backgroundColor: 'transparent'}} directly on the gradient itself? If that fixes it, I'll make that the default behaviour :smile:

@brentvatne last trick works for me, thanks

@brentvatne is this something you have in the works? If not, feel free to assign to me and I'll address this week.


added nic item in n weeks to desc string

Since alex also pushed it, this can be closes i guess

Thanks for jumping on this one anyway :)


Reuse FileEditorInput instead of always creating new

Every click in the explorer or search results in a new FileEditorInput to be created. We should rather use the IResourceInput API instead and have a cache at the layer where the input gets resolved to a EditorInput type.

Fixed via https://github.com/Microsoft/vscode/commit/5ecf0cda9a6c487acc1f0c75a3932954ca9211ef


git clone may be executed during rake clean, rake -T, etc.

It seems like that since #4180.
I hope the processes, including YAML library and lock file loading, are deferred until needed.

This seems to be existing behavior when you didn't ever cloned the mrbgems first time.


Set MaxValue automatically if numStars is set

Thanks for the plugin.
If you set the numStars in constructor to number below 5 and do not set maxValue, the rating is then calculated as it there was 5 stars. It would be nice to set maxValue to the number of stars if this value if number of stars is lower.

Ok it's totally up to you :)
It's just a bit confusing that when you have numStars=3,fulStars=true and choose one, the final rating is 2. When you choose 2, the rating is 3 and when you choose 3,than the rating is 5.
Anyway, it's not a bug, and can be avoided with setting maxValue. Thanks again


Set memory maximum size when checking pool allocation

What it says on the tin.

Was this not working as intended without this change? Or is it something new in the new qasmtime version?

I think it was not working as intended without setting memory size. :disappointed:

Ah, sorry, now I see the linked issue. LGTM!


Store text with emojis using unicode escape.

Summary

not converting unicode results in an error during signature generation.
so, store text with emojis using unicode escape.

"How are you today? 😊🌟🌈 "
=> "How are you today? \U0001f60a\U0001f31f\U0001f308"

normalize text first and then truncate it.

Thank you for review @platfowner! now merging..


Import GLTF with multiple materials that has no BaseColor Texture; unable to set BaseColor at runtime

Relation with #617
As @tpsiaki suggested i set the injection to usage "BaseColor". But now i got this error when converting:
debug: Error: Validating Materials: Validating material: Jsonnet Error: [1]: RUNTIME ERROR: duplicate field name: "BaseColor"

The model has multiple meshes with different materials. Many of them have a baseColor texture others not. All materials with no default baseTexture are set to the injection block in sampler the others to own pipelines. Is that a converter bug?

The method in #617 only works if you don't already have a base color texture defined in your imported gltf, i.e. if the base color doesn't already show up as a sampler in the sfa.  It sounds like this may be what you're running into.
If you do have a baseColor texture in your imported gltf, you should just modify the path to the image file to point at the new image you want to use, leave the rest of the sampler block (pipeline_name, etc...) unchanged.

But what can i do if the sfa file contains multiple materials. Let's say we have two materials in the sfa. One material has a baseColor texture via pipeline from the original object. The other material has no basecolor texture, so the value in the sfa is null. So i can't add a new texture for the second material via injections because of the converter error mentioned above. I also can't modify the pipeline  because i doesn't want to change the original texture from the first material.
I also can't add a baseColor texture to the second material at runtime. Also the way to set a new material is unfortunately not an option, because I want to keep the other values of the material like the metallic or roughness factor.

Are you able to share a model that is reproducing this so we can try to sort this out?  Please feel free to send it to me over email if you'd rather not share it publicly.

You've got a mail

Any updates on this ? I have run into the same problem when importing a .fbx file.
#650
Includes the asset for reproducing the issue.

@Consti10
Not really no. When you import a gltf file at runtime you have full access to all attributes also then when the original model doesn't have a default value. But currently you cannot load fbx at runtime.
I hope we'll get more info at the next update.


Market Interface Enhancements

That's already the case, try going to #/exchange/trade/ABITUSDA_USD for example. About the position, there's not really enough space where you've put them, there is on your screen but on smaller screens there won't be, especially if the user has big balances and the asset names are long.
We could put the buttons up top next to the account selector but that feels awkward too, not sure really. We probably need to make them smaller at least, I'll play around with it but feel free to do so yourself as well.

Most logical place for the Borrow button is next to Buy button - when you are looking to get BitUSD you may want to buy it or borrow it. So I would put Borrow and Buy very close to each other.

I think Borrow button takes too much space when put inside or above the form, in the transaction below I moved it to the top-right corner and changed its style to be less saturated - this is for advanced users anyways so they will find their to this button.

Looks good to me, I added some padding-right to the block because it was behind the scrollbar


useHistory() - Deprecation Warning: "useHistory()" is deprecated. It will be removed in a future version.

I have the following warning:
Deprecation Warning: "useHistory()" is deprecated. It will be removed in a future version.
Currently I have HOC
import {useCurrentRoute, useHistory} from 'react-navi';
import React from 'react';

const withCurrentRoute = (Component) => {
    return function WrapperComponent(props) {
        let route = useCurrentRoute();
        let history = useHistory();

        return <Component {...props} route={route} history={history} />;
    };
};

export default withCurrentRoute;

What should be used in the next version?

Use useNavigation() instead. This returns a navigation object with navigate() and subscribe() methods.
See docs here:

https://frontarm.com/navi/en/reference/react-components-hooks/#usenavigation
https://frontarm.com/navi/en/reference/navigation/

Thanks!


Configure router anti-affinity by default

Description
At present, router affinity is configured manually using StandardInfraConfig. However, since router deployments are unique to each address space, it must be configured after the address space is created, which is awkward.
To make it easier to use, router affinity with 'preferred scheduling' should be be enabled by default. This provides a more reasonable default, and will also cover the HA use case without needing to make any manual configuration.
Design
In address-space-controller, create preffered during scheduling anti-affinity rules on hostname if they are not explicitly specified.

@lulf Quick question on this issue. I was testing enmasse from master and the latest build. I can't see any pod anti-affinity on my broker or router statefulsets. I am wondering if I am doing something wrong, would you be able to check this the next time you have an install from master?

@davidffrench I would need to check this on my own cluster, reopening.

Thanks @lulf

Excellent, thank you @lulf


BSoD on Hook - Xuan-Yuan Sword: The Gate of Firmament (Steam)

Bug:

Remix will hook to the game Xuan-Yuan Sword: The Gate of Firmament then expand and reinitialize the window rapidly.
When the window grows past a certain size, Windows will crash and return a blue-screen.  Until the system or application stops, the application will seemingly behave as normal despite the steady resolution changes.
According to the logs, the window increases in width and height by 50 pixels every change in the affected XYS games.  This can vary depending on the title affected, such as Shadowrun Returns where only the width is affected by an error of 10px.
At points, the window will return to 1280x720 resolution in the original window position before appearing back to the place on the screen where the window had moved, at its increased size.
This behavior has been observed in multiple engines and in games by multiple developers.

Environment:

Build: Bridge Remix 4d6dc56-6, DXVK Remix 72c4d36-90 and fe511a5
GPU: Nvidia Geforce RTX 3080
Drivers: Nvidia Studio Driver 531.41
Known Affected Applications:

Shadowrun Returns - Unity (GOG, current release build) (only grows in width, not height
Xuan-Yuan Sword: The Gate of Firmament - Unity (Steam, current release build) (grows in width and height)
Xuan-Yuan Sword: The Clouds Faraway - RenderWare (Steam, current release build) (grows in width and height)

Logs:

NvRemixBridge.log: NvRemixBridge.log
d3d9.log: d3d9.log
Game log: SWD6E_d3d9.log

Note: These logs are from a session where the application was force-closed before a BSOD could occur.

To Reproduce
Steps to reproduce the behavior:

Set up Bridge and DXVK Remix in the game's EXE folder.
Open the application from Steam (or directly open the EXE, if using the GOG version).
The window initializes successfully at a default resolution of 1280x720, then grows by 50 px in width and height incrementally on repeat until the application or the system crashes.

The log (example from Shadowrun Returns) will report an infinite loop of the following functions:
d3d9_device.cpp:7513: D3D9DeviceEx::ResetSwapChain ->

rtx_resources.cpp:744: Resources::createDownscaledResources(Rc& ctx) ->

rtx_resources.cpp:990: Resources::executeResizeEventList(ResizeEventList& eventList, Rc& ctx, const VkExtent3D& extent)

rtx_resources.cpp:939: Resources::createTargetResources(Rc& ctx) ->

rtx_resources.cpp:990: Resources::executeResizeEventList(ResizeEventList& eventList, Rc& ctx, const VkExtent3D& extent)

D3D9DeviceEx::ResetSwapChain:
  Requested Presentation Parameters
    - Width:              2900
    - Height:             1071
    - Format:             D3D9Format::A8R8G8B8
    - Auto Depth Stencil: false
                ^ Format: D3D9Format::D24S8
    - Windowed:           true

Render resolution changed, recreating rendering resources

Target resolution changed, recreating target resources

D3D9DeviceEx::ResetSwapChain:
  Requested Presentation Parameters
    - Width:              2910
    - Height:             1071
    - Format:             D3D9Format::A8R8G8B8
    - Auto Depth Stencil: false
                ^ Format: D3D9Format::D24S8
    - Windowed:           true

Expected behavior
The window should initialize at the selected resolution (1280x720 default) and maintain this resolution.

This bug can also be reproduced in Shadowrun Returns (GOG).

Also occurs with Unity projects built in 2017.2.5f1

Hello! Will you please test this on the latest release and let us know if the issue persists? Thank you!

@NV-LL I can confirm that with 0.5.0 release this bug still occurs.  To reproduce:

Open an affected game-- the one above will work, any Unity game where the window is not resizable will also work.
Change the resolution in-game.
The window will infinitely expand, though some games eventually stop growing and begin to function again at a higher-than-intended resolution.

For convenience I have also included a video @Kim2091 created of a Kerbal Space Program alpha build where this issue occurs.  This is a much earlier version of Remix and a different title in the engine, but the issue is identical.
https://github.com/NVIDIAGameWorks/rtx-remix/assets/55258193/359e7342-9af7-4eca-96eb-b37c631d29e1

Hi @anchorlightforge , is this issue distinct from issue #499 at this point, or are they duplicates of each other?

REMIX-3160 for tracking

Hi, @anchorlightforge - we believe a recent update may address this issue. Will you please download the latest bridge and dxvk builds and let us know if the issue persists? Thank you!

@NV-LL I cleared some time to test it tomorrow for this and related titles.  Thanks for your patience.

I gave it a test on two affected Unity3D titles.  Both of them are now crashing before the main menu displays, but XYS6 managed to open, play opening movies, etc. without this swapchain bug.  I think this may be resolved but I'll continue testing and close over the weekend if I'm satisfied.  As for the new crashes, I'll compile info and I think it is unrelated.  Shadowrun Returns is a great test case as it includes additional logs that aren't standard with Unity games and points to an access violation.
My time is extremely limited this week so I won't be able to look at it for a while, but I want to follow up with as much info as I can before the weekend is up.

Hi @anchorlightforge - checking in to see if you've had a chance to revisit this issue since your last update. If not, no worries; we just want to make sure the ticket doesn't go stale if you're still working on it. Thanks!

@NV-LL Thank you for your patience.  This issue slipped my mind over the last two weeks as I've been away without a Remix capable PC.  I'm conducting one last test now.  Based on my findings last week:

Some Unity games are crashing immediately, while some crash after 3D rendering begins

XYS 6 is fine while displaying intro movies.  Unity only allows for basic image splash screens, so at this point the engine is fully initialized and going through some basic scene(s).  On the main menu as rendering begins, it will hang.
Shadowrun Returns will fail before displaying anything, and a third-party plugin for debugging creates a dump of the game calling out an access violation.

I've tried to set up Unity 4 and 5 on my PC for further testing, but licensing for these engines is proving to be confusing as the engine providers have removed most public-facing downloads from their website and disabled the licensing server for 4.  I'll keep poking at this to see if any progress can be made.
In the meantime, what I've seen of XYS6 makes me feel confident that the swapchain bug has been fixed.  I'll test the other affected titles on RenderWare and report back today.  I suspect that this ticket will be closed while a new ticket will be opened up for Unity games failing on launch.

#615 is open to investigate the new crashing issue and with that, I'll close this ticket as it's been addressed and fixed.  Thank you for your work in continuing to improve Remix.


Perform a "bootstrap" DevKit build to ensure final DevKit dependencies are built with identical gcc

Fixes https://github.com/adoptium/ci-jenkins-pipelines/issues/1008
Performs an initial DevKit build using the environment gcc, then builds the "final" DevKit using the gcc toolchain from the bootstrap DevKit

Adding this arbitrary comment to see if it triggers code-freeze!!?!

Adding this arbitrary comment to see if it triggers code-freeze!!?!
and yes it does!

/thaw


TurboGears Support

Please consider integrating TurboGears with your IDE.
Reference (Similar request with PyCharm):
Issue PY-2178: TurboGears support
https://youtrack.jetbrains.com/issue/PY-2178
Thanks,
Robert

I'm sorry but we are focused to easy developing scientific code and applications, instead of web apps.
I'll leave this open in case someone else wants to work on this because we're certainly not :-)

Although some part of scientific code and applications may be developed using web apps, truth is that that could only be developed as a plugin (with the upcoming spyder 3.0), besides none of the core devs has used (AFAIK) Turbogears.
I particularly have experience with flask and django and could work (eventually .. .. ..) on it.

We should add a label "plugin wishlist" for these kind of issues.

Yep go for it

Thanks!  I'm tracking IDEs with TurboGears2 support here: http://robertjliguori.blogspot.com/2015/11/python-ides-with-turbogears2-support.html


Devtools Extension

We should investigate a path for building installable devtools for better introspection into queries, viewing/resetting cache, perhaps logging, maybe a graphiql interface.
As a basic MVP, we could build a module to log urql events in the console. Beyond that, a module that is available as an installable chrome/firefox plugin.

Even the simple logger would be super handy. Do you have any special way of integrating a simple logger with urql in mind already? I'm interested in taking this.

v1 now has a simple logger called the "debug exchange". That said @sofiapoh has said she might look into writing a proper PoC devtool

Yep! @kitten I'm hoping to make a POC this weekend! Watch this space? 👀

@sofiapoh watching... ;P

@sofiapoh: @kiraarghy has said that she might take on a first version of this, if you're alright with this? Otherwise we still have other tasks that you could tackle, @kiraarghy :+1:

Friendly ping :)

@corysimmons this is in development right now and we are targeting an initial release very soon! (next few weeks-ish)

Amazing! After Apollo, I'm completely in love with how simple Urql is. Thank you guys for your hard work so much.

This is done and coming soon so I'll close this for now :eyes:


webworkers number in dat gui panel

What is it ?

more web workers that are generating chunk geometries. Terrain will generate faster.
You would change number of workers dynamically

Ok...

For faster renderer ?

no for generate chunk geometries faster.
Rendering faster will be if I add merging chunks

???

generate chunk model easier !?

To improve rendering speed I have to merge all chunk meshes into one mesh to get lower render calls

ok

can u go on discord plz ?

genered chunks are 3d model


Safe validation script for mongodb schema

Is your feature request related to a problem? Please describe.
Database content should always follow a strict guideline. e.g. if there exists a field for one document, there should exist the same field for all others. This is not the case right now.
We also don't have a script to back up the database.
Describe the solution you'd like
Write a script to iterate through each database item and:

return a list and number of invalid documents
run a backup script
ask for confirmation to fix these fields by giving them default values

Additional context
here is the return schema for tournaments:
class Tournament(BaseModel):
    _id: str
    name: str
    profile: str
    decklist: str
    wins: int
    winsSwiss: int
    winsBracket: int
    winRate: float
    winRateSwiss: float
    winRateBracket: float
    draws: int
    losses: int
    lossesSwiss: int
    lossesBracket: int
    standing: int
    colorID: str
    commander: str

@JasonQiu21 bumping priority for this issue. You've been assigned

https://github.com/EDH-Top-16/edhtop16/issues/53
also need to add duplicate detection/deletion


Batches API

Need the ability to figure out which jobs were queued from a reprocessing request.  Since reprocessing is a convenient way to iteratively test for improvements in an algorithm, it would be nice to have a simple api to get results for these multiple runs for comparision.

Two separate pieces here:

Allow the creation of a batch that re-processes exactly the set of recipes that a previous batch re-processed.
Allow the querying of a batch to return exactly the set of products produced by that batch.

The jobs, recipes, and files APIs either provide or will provide the ability to filter on batch. For this issue, I'll create a new v6 version of the batch API:

GET /batches/ - allows filtering on batches, new fields give top level recipe and job status counts, new status field to indicate if recipes are still being created, new fields to link a "chain" of batches together
POST /batches/ - create a new batch, will only support at first creating a batch in a chain (re-doing the same recipes as a previous batch)
POST /batches/validation/ - validates a new batch, will return a diff explaining the changes to the recipe as well as estimated (exact?) number of recipes to be created
GET /batches/{batch-id}/ - get batch details, will contain a recipe graph showing metrics (status counts and durations) for each job name
GET /batches/{batch-id}/comparison/ - returns the detailed metrics per job name for batches in this chain in a format that could be plotted in the UI for comparison

New batch model fields:
recipe_type_rev_id
configuration
is_creation_done
is_superseded
recipes_estimated
root_batch_id
prev_batch_id
superseded


improve 10-bit hevc format handling

Attempting a 10-bit HEVC decode on radv results in some issues, I haven't solved then all yet.
The first one though is the format picking, I think there is one bug in radv, but there's a second bug.
With AMD hw the DPB and decode are distinct, for 10-bit the DPB needs to be in 10-bit, but the output can be 8-bit and the hardware has the ability to handle that.
So radv returns both an 8-bit and 10-bit format for the decode output, but you always pick the 8-bit, and I think you should probably be smarter and scan all returned formats and pick the optimal one?

That's due to this https://github.com/nvpro-samples/vk_video_samples/blob/f4de028870b6936b24d75bc11ecb9da07fdf18e7/common/include/VkVideoCore/VulkanVideoCapabilities.h#L89
I changed this for my WIP CTS tests for 10-bit here: https://github.com/KhronosGroup/VK-GL-CTS/commit/94425ce9aa4d664a1602434657fe802ad8b329bd#diff-d73087a9725d59f7a76bdaf9f683fa4c773a10122bbce3b419b81fceda71ebb2R698
We need something similar (and probably smarter) for the samples app.

Aha, okay. Thank you,   charlie-ht and airlied. Indeed, we'll need a fix for that in the sample app. I'll look into fixing this soon.


Accessibility of the Python Interactive window

Using this extension here:
https://accessibilityinsights.io/en/
Run our different static HTML against it.
Right now I hit 19 issues just on the history pane.

Here's the why:
https://microsoft.sharepoint.com/teams/ceacc/SitePages/Accessibility Plans and Exemption Process.aspx (internal only link)

This one is going to force us to rewrite all of the svgs we get from our designers:
https://www.w3.org/WAI/WCAG21/Techniques/failures/F77
Duplicate ids cannot be in the webpage. All the SVGs we've gotten from the UX team have ids in them.

Here's the results of the test:
AssessmentReport_20190613_ReactApp.zip
Two failures that we can't work around:

Contrast on items provided by Jupyter
Removing CSS breaks the monaco editor. Or at least it's not usable.


Move WebSocket to Webserver & HttpJsonRpc async

1 Tell us something

Both well tested, i don't expect issues

Breaking Change!
WebSocket has now the same port as the webserver, it is no longer reachable at the json port

Pi debian8 passed.


semicolons stripped in React

Is there a setting to avoid stripping semicolons from React code? They're in my examples, but are getting removed.

Hey @ericandrewscott! Thanks for your interest - we're looking into either allowing specifying prettier config or trying to deduce config from code. Right now we don't expose any means to control example formatting

@slees-figma this would be awesome. You could also enforce eslint configs (as well as prettier).


Access multiple local storage keys with an object query

Summary
I notice that there is no current option to access multiple keys with the useLocalStorage hooks.
This pull request includes a sync and no-sync version of accessing multiple storage keys with an object version of writeToLocalStorage. This is a convenient feature to add for quickly changing those values without creating multiple instances of the hook.
I wrote it and exported them as a separate functions as to not interfere with the original idea and organized them similarly to the other hooks.

👋 @fromjaytoz
I have opened yet another PR with my suggested changes at https://github.com/fromjaytoz/react-hook-local-web-storage/pull/2
Let me know what you think 🙂

Hey @bence-toth, I will check it out now.

💯

Perfect, glad to see it on the main project


API token should be fetched later

JabRef uses Java Key Ring to connect to password stores.
org.jabref.preferences.JabRefPreferences#getAiPreferences access that key store when creating the AI Chat tab. This leads to following startup error output:
2024-08-04 10:50:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getAiApiTokenFromKeyring()
WARN: JabRef could not open keyring for retrieving OpenAI API token: com.github.javakeyring.PasswordAccessException: Error code 1168
        at java.keyring@1.0.4/com.github.javakeyring.internal.windows.WinCredentialStoreBackend.getPassword(WinCredentialStoreBackend.java:61)
        at java.keyring@1.0.4/com.github.javakeyring.Keyring.getPassword(Keyring.java:90)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getAiApiTokenFromKeyring(JabRefPreferences.java:2808)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getAiPreferences(JabRefPreferences.java:2773)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.initialize(JabRefGUI.java:159)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.start(JabRefGUI.java:90)
        at javafx.graphics@22.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:839)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:483)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
        at javafx.graphics@22.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
        at javafx.graphics@22.0.2/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at javafx.graphics@22.0.2/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
        at java.base/java.lang.Thread.run(Thread.java:1583)
2024-08-04 10:50:21 [JavaFX Application Thread] org.jabref.gui.StateManager.setActiveDatabase()

When opening preferences, the key is there.

When using Gnome, on startup, one will be asked to open the key store. This is not necessary. It is necessary when interacting with the AI.
Please postpone the call to org.jabref.preferences.JabRefPreferences#getAiApiTokenFromKeyring to the latest point in time (and store the key internally once retrieved). (OK, one also has to take care if they key is changed by the user)

I'm not sure how to code this properly. This will probably break some symmetry and used practice, but yes, the issue is right.
Can I make org.jabref.preferences.JabRefPreferences#getAiPreferences public?

I'm not sure how to code this properly. This will probably break some symmetry and used practice, but yes, the issue is right.

Maybe, the other places need to be changed "accordingly" (e.g., proxy password, ...). I think, however, that it is OK for JabRef users with proxy passwords that JabRef asks for the password right at the start. For API keys, I am not that sure...
With your changes, an example can be shown how it will work.

Can I make org.jabref.preferences.JabRefPreferences#getAiPreferences public?

Yes. This will lead to another method signature in PreferenceServcid, whcih is OK.

Okay, I think I managed to do this in a recent push

No, see output of gradlew run:
$ ./gradlew run

> Configure project :
Project : => 'org.jabref' Java module

> Task :run
WARNING: Using incubator modules: jdk.incubator.vector
Messages are not initialized before accessing key: Display help on command line options
2024-08-06 17:00:16 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.addStylesheetToWatchlist()
INFO: Watching css C:\git-repositories\jabref-all\jabref\build\resources\main\org\jabref\gui\Base.css for live updates
2024-08-06 17:00:16 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Not updating theme because it hasn't changed
2024-08-06 17:00:16 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Theme set to Theme{type=DEFAULT, name=''} with base css StyleSheet{file:/C:/git-repositories/jabref-all/jabref/build/resources/main/org/jabref/gui/Base.css}
2024-08-06 17:00:16 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider()
WARN: JabRef could not open keyring for retrieving OpenAI API token: com.github.javakeyring.PasswordAccessException: Error code 1168
        at java.keyring@1.0.4/com.github.javakeyring.internal.windows.WinCredentialStoreBackend.getPassword(WinCredentialStoreBackend.java:61)
        at java.keyring@1.0.4/com.github.javakeyring.Keyring.getPassword(Keyring.java:90)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider(JabRefPreferences.java:2855)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getAiPreferences(JabRefPreferences.java:2795)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.initialize(JabRefGUI.java:159)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.start(JabRefGUI.java:90)
        at javafx.graphics@22.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:839)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:483)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
        at javafx.graphics@22.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
        at javafx.graphics@22.0.2/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
        at javafx.graphics@22.0.2/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
        at java.base/java.lang.Thread.run(Thread.java:1583)
2024-08-06 17:00:16 [pool-2-thread-1] org.jabref.logic.ai.models.EmbeddingModel.rebuild()
INFO: Downloading embedding model...
Loading:     100% |========================================|
2024-08-06 17:00:16 [pool-2-thread-1] ai.djl.pytorch.jni.LibUtils.downloadPyTorch()
WARN: No matching cuda flavor for win-x86_64 found: cu065.
2024-08-06 17:00:17 [pool-2-thread-1] ai.djl.pytorch.engine.PtEngine.newInstance()
INFO: PyTorch graph executor optimizer is enabled, this may impact your inference latency and throughput. See: https://docs.djl.ai/docs/development/inference_performance_optimization.html#graph-executor-optimization
2024-08-06 17:00:17 [pool-2-thread-1] ai.djl.pytorch.engine.PtEngine.newInstance()
INFO: Number of inter-op threads is 24
2024-08-06 17:00:17 [pool-2-thread-1] ai.djl.pytorch.engine.PtEngine.newInstance()
INFO: Number of intra-op threads is 12
2024-08-06 17:00:17 [pool-2-thread-1] ai.djl.util.Platform.detectPlatform()
INFO: Found matching platform from: jar:file:///C:/Users/koppor/.gradle/caches/modules-2/files-2.1/ai.djl.huggingface/tokenizers/0.29.0/edd38326d16523f2b8c2b1e360b896e7ae48a1fa/tokenizers-0.29.0.jar!/native/lib/tokenizers.properties
2024-08-06 17:00:17 [JavaFX Application Thread] org.jabref.gui.StateManager.setActiveDatabase()
INFO: No open database detected
2024-08-06 17:00:18 [pool-2-thread-2] org.jabref.gui.JabRefDialogService.notify()
INFO: Opening: 'C:\Users\koppor\OneDrive\Projects\JabRef-AI\Chocolate.bib'
2024-08-06 17:00:18 [JavaFX Application Thread] sun.util.logging.internal.LoggingProviderImpl$JULWrapper.log()
WARN: Resource "" not found.
2024-08-06 17:00:19 [JavaFX Application Thread] sun.util.logging.internal.LoggingProviderImpl$JULWrapper.log()
WARN: Resource "" not found.
2024-08-06 17:00:19 [JavaFX Application Thread] org.jabref.logic.ai.models.EmbeddingModel.lambda$startRebuildingTask$0()
INFO: Embedding model was successfully downloaded
2024-08-06 17:00:19 [JavaFX Application Thread] org.apache.lucene.internal.vectorization.PanamaVectorizationProvider.<init>()
INFO: Java vector incubator API enabled; uses preferredBitSize=256; FMA enabled

Are you sure you started JabRef without AI-enabled?

I highlight important terms of my issue description:

I try TL;DR:

AI chat opened: No key -> fetch key from store
Entry editor closed -> NO KEY FETCHED !!!!
Start of op JabRef -> NO KEY FETCHED !!!!

If this is too difficult to implement, we can postpone to the famous week 12.

Ah, I see. I just implemented it for:

User opens preferences
Agrees to AI
Saves preferences

And after that the key will be fetched

As I understand, we should fetch the key ONLY when we start chatting or summarizing?

Note that there is something reading the the AI Preferences - and thus the key:
> Task :run
WARNING: Using incubator modules: jdk.incubator.vector
Messages are not initialized before accessing key: Display help on command line options
2024-08-07 06:27:15 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.addStylesheetToWatchlist()
INFO: Watching css /home/vagrant/jabref/build/resources/main/org/jabref/gui/Base.css for live updates
2024-08-07 06:27:15 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Not updating theme because it hasn't changed
2024-08-07 06:27:15 [JavaFX Application Thread] org.jabref.gui.theme.ThemeManager.updateThemeSettings()
INFO: Theme set to Theme{type=DEFAULT, name=''} with base css StyleSheet{file:/home/vagrant/jabref/build/resources/main/org/jabref/gui/Base.css}
2024-08-07 06:27:15 [JavaFX Application Thread] org.freedesktop.dbus.connections.transports.TransportBuilder.build()
INFO: Using transport dbus-java-transport-native-unixsocket to connect to unix:path=/run/user/1000/bus
2024-08-07 06:27:16 [JavaFX Application Thread] org.freedesktop.secret.handlers.SignalHandler.await()
INFO: Await signal Prompt.Completed(/org/freedesktop/secrets/prompt/u1) within 120 seconds.
2024-08-07 06:27:20 [DBus-Signal-Receiver-1] org.freedesktop.secret.handlers.SignalHandler.handle()
INFO: Received signal Service.CollectionChanged: /org/freedesktop/secrets/collection/login
2024-08-07 06:27:20 [DBus-Signal-Receiver-1] org.freedesktop.secret.handlers.SignalHandler.handle()
INFO: Received signal Prompt.Completed(/org/freedesktop/secrets/prompt/u1): {dismissed: false, result: [[/org/freedesktop/secrets/aliases/default]]}
2024-08-07 06:27:20 [JavaFX Application Thread] org.freedesktop.dbus.connections.transports.TransportBuilder.build()
INFO: Using transport dbus-java-transport-native-unixsocket to connect to unix:path=/run/user/1000/bus
2024-08-07 06:27:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider()
WARN: JabRef could not open keyring for retrieving OpenAI API token: com.github.javakeyring.PasswordAccessException: No stored credentials match org.jabref.ai account: apitoken-MISTRAL_AI
        at java.keyring@1.0.4/com.github.javakeyring.internal.freedesktop.FreedesktopKeyringBackend.throwNoExistingCredentialException(FreedesktopKeyringBackend.java:161)
        at java.keyring@1.0.4/com.github.javakeyring.internal.freedesktop.FreedesktopKeyringBackend.getPassword(FreedesktopKeyringBackend.java:91)
        at java.keyring@1.0.4/com.github.javakeyring.Keyring.getPassword(Keyring.java:90)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider(JabRefPreferences.java:2855)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getAiPreferences(JabRefPreferences.java:2794)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.initialize(JabRefGUI.java:159)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.start(JabRefGUI.java:90)
        at javafx.graphics@22.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:839)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:483)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
        at javafx.graphics@22.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
        at javafx.graphics@22.0.2/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
        at javafx.graphics@22.0.2/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$10(GtkApplication.java:264)
        at java.base/java.lang.Thread.run(Thread.java:1583)
2024-08-07 06:27:20 [JavaFX Application Thread] org.freedesktop.dbus.connections.transports.TransportBuilder.build()
INFO: Using transport dbus-java-transport-native-unixsocket to connect to unix:path=/run/user/1000/bus
2024-08-07 06:27:20 [JavaFX Application Thread] org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider()
WARN: JabRef could not open keyring for retrieving OpenAI API token: com.github.javakeyring.PasswordAccessException: No stored credentials match org.jabref.ai account: apitoken-HUGGING_FACE
        at java.keyring@1.0.4/com.github.javakeyring.internal.freedesktop.FreedesktopKeyringBackend.throwNoExistingCredentialException(FreedesktopKeyringBackend.java:161)
        at java.keyring@1.0.4/com.github.javakeyring.internal.freedesktop.FreedesktopKeyringBackend.getPassword(FreedesktopKeyringBackend.java:91)
        at java.keyring@1.0.4/com.github.javakeyring.Keyring.getPassword(Keyring.java:90)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getApiKeyForAiProvider(JabRefPreferences.java:2855)
        at org.jabref@100.0.0/org.jabref.preferences.JabRefPreferences.getAiPreferences(JabRefPreferences.java:2795)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.initialize(JabRefGUI.java:159)
        at org.jabref@100.0.0/org.jabref.gui.JabRefGUI.start(JabRefGUI.java:90)
        at javafx.graphics@22.0.2/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:839)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:483)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
        at javafx.graphics@22.0.2/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
        at javafx.graphics@22.0.2/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
        at javafx.graphics@22.0.2/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
        at javafx.graphics@22.0.2/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$10(GtkApplication.java:264)
        at java.base/java.lang.Thread.run(Thread.java:1583)
2024-08-07 06:27:21 [pool-2-thread-1] org.jabref.logic.ai.models.EmbeddingModel.rebuild()

See my comment https://github.com/JabRef/jabref/commit/1d4c383ddc31c4d2423949da51f288b5a81e4901 on a possible code-based solution.

Hope I managed to do this in a recent push

I commented at https://github.com/JabRef/jabref/pull/11430#pullrequestreview-2225753481 - please refine the code.

I took this approach: I mark unloaded keys as empty strings. If the string is empty, then it will be retrieved from keyring. I think, this is okay?
(You should see a message "InAnYan referenced this issue", above this comment)
About factoring out fields: I wonder, if it's really needed. Currently I only see one purpose - grouping. If it had more complex logic..

Actually, I understood. It would be better to have a separate class for API keys in case there will be more of them. They should be stored in a Map<AiProvider, String>, or something like that

Actually, I understood. It would be better to have a separate class for API keys in case there will be more of them.

Yes!

They should be stored in a Map<AiProvider, String>, or something like that

Yes. The enum org.jabref.preferences.ai.AiProvider is really good.
The label can directly be used as last part of the item name in the java key store.

I wonder, Oliver, if we can make a separate issue for "Refactor support of multiple AI providers", because not only API key is associated with an AI provider.
For now we have a simple fix.
What if I make that issue and close this one (close this - because API token is fetched later)

Go ahead with creating a new issue and closing this (with a reference to the new isssue)

There still was a call to rebuild reading the API key in org.jabref.logic.ai.models.JabRefChatLanguageModel#JabRefChatLanguageModel. Removed at 400d83e7e82e1b716ccb3b16f64aa9bb.


GovUk minor update

Jira link (if applicable)
This is related to crown logo update.

No needed anymore


Menu localization issue for "Hide Toolbar/Show Toolbar"

For some localizations, the menu item text for "Hide Toolbar" does not toggle to "Show Toolbar" when the toolbar is hidden.
The problem can be encountered for instance in German, French and Italian localizations.
It does not appear in English and Spanish localizations.
Currently, I am at loss…

Curious, validateMenuItem(_:) in MainWindowController is never called for this selector. Let me try something.

A quick fix is to implement validateMenuItem(_:) in a subclass of NSWindow. It seems that the controller never receives this selector. I have yet to figure out how to best use the responder chain, so I will keep this issue open for now.

I think I would indeed prefer to re-introduce an NSWindow subclass and simply override validateMenuItem(_:) there for just this selector. After all, toggleToolbarShown(_:) is an NSWindow method, so it makes more sense to keep the selector validation there too. However, I will keep the NSLocalizedString approach.


Add rewrite rules

Hi,
(Jed pointed me to this project :)
This branch contains some cabal changes I needed for it to build from git (though it built fine from 'cabal unpack'), and some rewrite rules. NB. The rewrite rules are untested, perhaps we can discuss how to test these at fp-syd?
Conrad.

Nice, thanks! Looking forward to meeting you at fpsyd.


Build errors in @types/prettier/index.d.ts

ISSUE
A release of @types/prettier/index.d.ts introduced a breaking change to all Typescript 3.x clients. AWS Solutions Constructs and the AWS CDK are dependent upon this library through a dependency on Jest. Release 2.6.1 introduced this error, applications will encounter it when the build after refreshing their npm libraries. Several errors such as these will occur during the build:
node_modules/@types/prettier/index.d.ts:41:54 - error TS2315: Type 'IsTuple' is not generic.
41 type IndexProperties<T extends { length: number }> = IsTuple<T> extends true
                                                        ~~~~~~~~~~

node_modules/@types/prettier/index.d.ts:53:6 - error TS2456: Type alias 'IsTuple' circularly references itself.
53 type IsTuple<T> = T extends [] ? true : T extends [infer First, ...infer Remain] ? IsTuple<Remain> : false;

node_modules/@types/prettier/index.d.ts:53:65 - error TS2574: A rest element type must be an array type.
53 type IsTuple<T> = T extends [] ? true : T extends [infer First, ...infer Remain] ? IsTuple<Remain> : false;

node_modules/@types/prettier/index.d.ts:53:84 - error TS2315: Type 'IsTuple' is not generic.
53 type IsTuple<T> = T extends [] ? true : T extends [infer First, ...infer Remain] ? IsTuple<Remain> : false;

node_modules/@types/prettier/index.d.ts:96:5 - error TS2589: Type instantiation is excessively deep and possibly infinite.
96     call<

REMEDY
To fix the build, applications must pin the version of @types/prettier to the version prior to the breaking change (2.6.0). To do so, add the following line to devDependencies in the application package.json file:
    "@types/prettier": "2.6.0",

ADDITIONAL INFO
There are several discussions and an issue raised about this matter on the Github repo for the @types library. You can monitor and contribute to these conversations here: Issue, Discussion.

At this point CDK has moved to Typescript 4.x and the latest @types/prettier. This should no longer be an issue.


Compatibility with ExtJS v. 5.1.0

This is a work in progress PR and it is not yet ready for reviewing or merging.
Current state:

[ ] Examples working with either 4.2.1 or 5.1.0

[x] Action
[ ] MVC-App

[ ] uncompiled dev-version
[ ] compiled production version

[x] Geocoder
[x] Feature Grid
[x] LayerOpacitySlider
[x] Legend Panel
[x] Mappanel
[x] Permalink
[x] Popup
[x] Print extent
[x] Print preview
[x] Print page
[x] Print form
[x] Feature Renderer
[x] Stylegrid
[x] Tree
[x] Treelegend
[x] WFS Capabilities
[x] WMS Capabilities
[x] Zoomchooser
[x] Zoomslider

[x] Testsuite passes with either 4.2.1 or 5.1.0 locally

[x] Action
[x] container/LayerLegend
[x] container/UrlLegend
[x] container/WmsLegend
[x] container/VectorLegend
[x] data/AttributeModel
[x] data/AttributeStore
[x] data/FeatureStore
[x] data/LayerStore
[x] data/MapfishPrintProvider
[x] data/PrintPage
[x] data/proxy/Protocol
[x] data/reader/Attribute
[x] data/reader/CswRecords
[x] data/reader/WfsCapabilities
[x] data/reader/Wmc
[x] data/reader/WmsCapabilities
[x] data/reader/WmsDescribeLayer
[x] data/WmsDescribeLayerStore
[x] data/ScaleStore
[x] data/StyleStore
[x] FeatureRenderer
[x] Form
[x] form/action/Search
[x] form/Basic
[x] form/field/GeocoderComboBox
[x] form/Panel
[x] grid/column/Symbolizer
[x] Lang
[x] LegendImage
[x] panel/Map
[x] panel/Legend
[x] panel/PrintMapPanel
[x] plugins/PrintExtent
[x] plugins/PrintPageField
[x] plugins/PrintProviderField
[x] selection/FeatureModel
[x] slider/Zoom
[x] slider/LayerOpacity
[x] state/PermalinkProvider
[x] tree/LayerContainer
[x] tree/LayerLoader
[x] window/Popup
[x] Version

[ ] Testsuite passes in relevant browsers

[x] recent Chrome
[x] recent Firefox
[ ] Internet Explorer 9
[ ] Internet Explorer 10
[ ] Internet Explorer 11

[x] Travis

[x] Use ExtJS 5 also for CI
[x] All tests pass in Travis

Hey bjornharrtell, we could use some help with parts of the data-package.
These are the parts (files) we have some problems with:
data/proxy/Protocol.html
data/reader/Wmc.html
data/reader/WmsCapabilities.html
data/reader/WmsDescribeLayer.html
tree/LayerContainer.html
I think the rest ist done so far.

The tests for panel/PrintMapPanel seem to be broken in all browsers and the LegendImage in Chrome 39

They look fine for me:

Are you on windows and have the latest commits in this branch

Yes @marcjansen , it's on Windows.
The PrintMapPanel test Aspect ratio of the preview map is the same as of the print layout fails. I looked a bit into it. It seems to be a rounding issue. In the class itself in function syncSize the size of the PrintMappanel is set by calling this.setSize(s.width, s.height);. In the test case the calculated height (s.height) which is passed to setSize is<PHONE_NUMBER>090909. If this.getSize() is called afterwards you'll recognize that 200 is returned as height. So ExtJS seems to 'floor' the values. By the reverse calculation in the test the same ratio is used but the "wrong" height, which causes the rounding issue IMHO. Why this does not occur on Linux? I don't know.

Since #338 IE 11 and 9 now is green for me (remember to turn off the compatibility view...)

I am now working on creating a mergeable branch which includes only the flesh of the commits gathered here. I advise every one, to no longer depend on this branch.

Closing this one. See #339.


Wheel not spinning and stopping immediately to result

wheel is not spinning on edge, brave and chrome, i'm not sure on other browsers but it is not spinning now as of submitting this. its working before but suddenly its not

Same happened for me, couple a days a go, just stop working

Same happened for me, couple a days a go, just stop working

did you try on any other browsers?

Only works on FF

Same issue here.

Yeah not spinning anymore

same here. :/

yarn add<EMAIL_ADDRESS>Downgrading the package work as a temporary fix till the issue is fixed

yarn add<EMAIL_ADDRESS>Downgrading the package work as a temporary fix till the issue is fixed

It works for me.

Same here

It's working with 1.4.0 also, and that version is compatible with React 18.0, while 1.3.2 needs to have React 16

I downgrade to 1.4.0 but it's still not working on chrome, but worked on safari

yea it's not working for me either :/...hopefully it's fixed

Same for me, it's not working on Chrome

<EMAIL_ADDRESS>
downgraded to 1.4.0, didnt work, downgraded to 1.3.2 and it worked, hope this helps :)

yarn add<EMAIL_ADDRESS>Downgrading the package work as a temporary fix till the issue is fixed

Worked for me!

I guess maybe an update to chromium broke it? 1.3.2 is the only fix here too. Seems to work fine in react 18.

Same issue happened here 🤦🏻

I had to downgrade to 1.2.0 and it worked for me.

Yes can confirm - 1.3.2 does not work on android chromium browsers (doesn't display at all)
1.2.0 works (but is missing many valuable features such as CursorProps and fontFamily 😢 )

have same issue, latest version doesn't work on android and chrome


DoctrineWriter: fix setting associations

The associations set in loadAssociationObjectsToEntity() method will be overwritten by the original value/foreign key. This will lead to an Doctrine exception, coz Doctrine is expecting an entity object and not a scalar value.

Can you provide a failing test case?

Sorry, what do you mean?

Can you provide a short snippet which shows the error, so i can reproduce your issue.

Sure.
I have a target model Store with an association to a model Industry
CSV source:
Industry
id: 1 name: industry1
Store
id: 1 name: store1 industry: 1
Here is the Error:
Found entity of type on association Shopware\CustomModels\StoreLocator\Store#industry, but expecting Shopware\CustomModels\StoreLocator\Industry in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php on line 783
Stack trace:
#0 vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(679): Doctrine\ORM\UnitOfWork->computeAssociationChanges(Array, 1)
#1 vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(740): Doctrine\ORM\UnitOfWork->computeChangeSet(Object(Doctrine\ORM\Mapping\ClassMetadata), Object(Shopware\CustomModels\StoreLocator\Store))
#2 vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(297): Doctrine\ORM\UnitOfWork->computeChangeSets()
#3 vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php(389): Doctrine\ORM\UnitOfWork->commit(NULL)
#4 Shopware/Plugins/Local/Frontend/NetcomTypo3StoreLocator/vendor/ddeboer/data-import/src/Ddeboer/DataImport/Writer/DoctrineWriter.php(179): Doctrine\ORM\EntityManager->flush()
#5 Shopware/Plugins/Local/Frontend/NetcomTypo3StoreLocator/vendor/ddeboer/data-import/src/Ddeboer/DataImport/Workflow.php(304): Ddeboer\DataImport\Writer\DoctrineWriter->finish()
#6 Shopware/Plugins/Local/Frontend/NetcomTypo3StoreLocator/Controllers/Frontend/StoreImport.php(312): Ddeboer\DataImport\Workflow->process()
#7 Shopware/Plugins/Local/Frontend/NetcomTypo3StoreLocator/Controllers/Frontend/StoreImport.php(52): Shopware_Controllers_Frontend_StoreImport->importStores('m...')
#8 Enlight/Controller/Action.php(159): Shopware_Controllers_Frontend_StoreImport->importAction()
#9 Enlight/Controller/Dispatcher/Default.php(528): Enlight_Controller_Action->dispatch('importAction')
#10 Enlight/Controller/Front.php(228): Enlight_Controller_Dispatcher_Default->dispatch(Object(Enlight_Controller_Request_RequestHttp), Object(Enlight_Controller_Response_ResponseHttp))
#11 Shopware/Kernel.php(141): Enlight_Controller_Front->dispatch()
#12 vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpCache/HttpCache.php(472): Shopware\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#13 Shopware/Components/HttpCache/AppCache.php(256): Symfony\Component\HttpKernel\HttpCache\HttpCache->forward(Object(Symfony\Component\HttpFoundation\Request), true, NULL)
#14 vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpCache/HttpCache.php(429): Shopware\Components\HttpCache\AppCache->forward(Object(Symfony\Component\HttpFoundation\Request), true)
#15 vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpCache/HttpCache.php(329): Symfony\Component\HttpKernel\HttpCache\HttpCache->fetch(Object(Symfony\Component\HttpFoundation\Request), true)
#16 Shopware/Components/HttpCache/AppCache.php(178): Symfony\Component\HttpKernel\HttpCache\HttpCache->lookup(Object(Symfony\Component\HttpFoundation\Request), true)
#17 vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpCache/HttpCache.php(193): Shopware\Components\HttpCache\AppCache->lookup(Object(Symfony\Component\HttpFoundation\Request), true)
#18 Shopware/Components/HttpCache/AppCache.php(113): Symfony\Component\HttpKernel\HttpCache\HttpCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 shopware.php(109): Shopware\Components\HttpCache\AppCache->handle(Object(Symfony\Component\HttpFoundation\Request))
#20 {main}
And here is the xDebug output.

$value should not be "1". It should be an object of type Industry. Actually, all associations were already set in the loadAssociationObjectsToEntity() method, which was called directly before updateEntity() method. So the associations does not have to be set again.

:+1: Fixes https://github.com/ddeboer/data-import/issues/188.

This might fix your issue but as travis reported it completely break the current workflow. I can't really produce your issue. @webdevilopers Maybe you can submit a PR with an testcase which demostrate the bug.

As mentioned in https://github.com/ddeboer/data-import/issues/188#issuecomment-93343799 I was wondering why the fix worked. My issue looked more like a reading - not  writing - issue in https://github.com/ddeboer/data-import/issues/188.
I will try the same import with a new xlsx file from scratch to prevent any formatting that is done by the tool that exported it, @Baachi .

I played around with the xlsx file. I removed some lines and tried again.
After some attempts it looks like my script will break every 20 items.
Is there a number set for this batch action?
Here are the first rows of my xlsx file:

The strange thing is the debug output. While this output relates to the first element with ID 3152
 at ORMInvalidArgumentException ::invalidAssociation (object(ClassMetadata), array(
'fieldName' => 'creditAccount', 'joinColumns' => array(array('name' => 'credit_account_id', 'unique' => false, 'nullable' => true, 'onDelete' => null, 'columnDefinition' => null, 'referencedColumnName' => 'id')), 'cascade' => array(), 'inversedBy' => 'creditAccountJournals',
'targetEntity' => 'AppBundle\Entity\AccountsCode', 'fetch' => '2', 'type' => '2', 'mappedBy' => null, 'isOwningSide' => true, 'sourceEntity' => 'AppBundle\Entity\Journal', 'isCascadeRemove' => false, 'isCascadePersist' => false, 'isCascadeRefresh' => false, 'isCascadeMerge' => false, 'isCascadeDetach' => false, 'sourceToTargetKeyColumns' => array('credit_account_id' => 'id'),
'joinColumnFieldNames' => array('credit_account_id' => 'credit_account_id'), 'targetToSourceKeyColumns' => array('id' => 'credit_account_id'), 'orphanRemoval' => false),
'3152')

in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 844  +
at UnitOfWork ->computeAssociationChanges (array(
'fieldName' => 'creditAccount', 'joinColumns' => array(array('name' => 'credit_account_id', 'unique' => false, 'nullable' => true, 'onDelete' => null, 'columnDefinition' => null, 'referencedColumnName' => 'id')), 'cascade' => array(), 'inversedBy' => 'creditAccountJournals',
'targetEntity' => 'AppBundle\Entity\AccountsCode', 'fetch' => '2', 'type' => '2', 'mappedBy' => null, 'isOwningSide' => true, 'sourceEntity' => AppBundle\Entity\Journal', 'isCascadeRemove' => false, 'isCascadePersist' => false, 'isCascadeRefresh' => false, 'isCascadeMerge' => false, 'isCascadeDetach' => false, 'sourceToTargetKeyColumns' => array('credit_account_id' => 'id'),
'joinColumnFieldNames' => array('credit_account_id' => 'credit_account_id'), 'targetToSourceKeyColumns' => array('id' => 'credit_account_id'), 'orphanRemoval' => false),
'3152')
in vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php at line 741

some outputs later relates to the last item with IDs 9008 and 10130
at DoctrineWriter ->writeItem (array('' => null, 'creditAccount' => '9008', 'debitAccount' => '10130'))
in vendor/ddeboer/data-import/src/Ddeboer/DataImport/Workflow.php at line 261

All the IDs are quoted so I guess they are interpreted as strings.
My Mapping:
        $converter = new MappingItemConverter();
        $converter
            ->addMapping('Belegdat.', 'documentDate')
            ->addMapping('Sollkto', 'creditAccount')
            ->addMapping('Habenkto', 'debitAccount')
        ;
$workflow->addItemConverter($converter);

And my entity mapping:
class Journal
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @ORM\Column(type="date", name="document_date")
     */
    private $documentDate;

    /**
     * @ORM\ManyToOne(targetEntity="AppBundle\Entity\AccountsCode", inversedBy="creditAccountJournals")
     * @ORM\JoinColumn(name="credit_account_id", referencedColumnName="id", nullable=true)
     */
    private $creditAccount;

    /**
     * @ORM\ManyToOne(targetEntity="AppBundle\Entity\AccountsCode", inversedBy="debitAccountJournals")
     * @ORM\JoinColumn(name="debit_account_id", referencedColumnName="id", nullable=true)
     */
    private $debitAccount;
}

Pretty basic.

Ah okay i think your issue is related to the doctrine entity manager clear behaviour. The DoctrineWriter have a batch processor builtin. If the batch of 20 items are reached, the DoctrineWriter will flush the entity manager and remove all objects in the entity manager.
This should solve your problem:
use Ddeboer\DataImport\Writer\DoctrineWriter as BaseDoctrineWriter;

class DoctrineWriter extends BaseDoctrineWriter {
     public function flushAndClear()
     {
              $this->entityManager->flush();
     }
}

I'm currently not working on that project but this looks like the main issue, thanks @Baachi .
Is this behaviour documented anywhere? Is it a real use case regarding my use case?
Should I open a new one or will the BaseDoctrineWriter be updated with a different fix for this original issue by @buddhaCode ?

A fix is difficult because it depends on your needs.
We are working on the documentation.


pull request for e2e test at 11/16/2016 01:56:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Guide For Newbie Dev

Any tutorial for beginner dev ☺

Please see https://docs.pkgx.sh, if you have more specific questions then use our Discord or the GitHub Discussions forum. Best of luck.


Error  build-assets: webpack -p

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'build-assets' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild-assets', 'build-assets', 'postbuild-assets' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prebuild-assets, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/share/npm/bin/node-gyp-bin:/home/pingo/Desktop/sensor2cloud/saleor/node_modules/.bin:/home/pingo/Downloads/google-cloud-sdk/bin:/home/pingo/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/pingo/Desktop/sensor2cloud/saleor
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'webpack -p' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec build-assets script
14 verbose stack Error<EMAIL_ADDRESS>build-assets: webpack -p
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (/usr/share/npm/lib/utils/lifecycle.js:232:16)
14 verbose stack     at emitTwo (events.js:126:13)
14 verbose stack     at EventEmitter.emit (events.js:214:7)
14 verbose stack     at ChildProcess. (/usr/share/npm/lib/utils/spawn.js:24:14)
14 verbose stack     at emitTwo (events.js:126:13)
14 verbose stack     at ChildProcess.emit (events.js:214:7)
14 verbose stack     at maybeClose (internal/child_process.js:925:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /home/pingo/Desktop/sensor2cloud/saleor
17 error Linux 4.15.0-36-generic
18 error argv "/usr/bin/node" "/usr/bin/npm" "run" "build-assets"
19 error node v8.10.0
20 error npm  v3.5.2
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>build-assets: webpack -p
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>build-assets script 'webpack -p'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the saleor package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     webpack -p
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs saleor
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls saleor
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Try updating your node/npm. I'd suggest this be added to the docs, as well.

Could you please upgrade to nodejs 10+ and check how it goes?

@the-bionic I think that all of the docs state, that one should use NodeJS 10 or newer

@Pacu2, alright. I've seen too many of this issue. I fell for it, too.

@the-bionic  you are right.

@karimation Is it resolved?

@Pacu2  yes.

Glad to see this resolved.

Node Js 11 & npm 6 but still facing error while npm run build-assets

@yourtechcare This is just a warning. It should be fine.

Is that RAM (MEMORY) needs to be higher than 2GB while installation ?