HDFS-17121. BPServiceActor to provide new thread to handle FBR

Description of PR
HDFS_17121
AND open this just for test because https://github.com/apache/hadoop/pull/5888/ always report the same oom file hs_err_pid52701.log.
How was this patch tested?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 11s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 25s

trunk passed

-1 :x:
shadedclient
39m  3s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 20s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 20s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 26s

the patch passed

-1 :x:
shadedclient
39m 17s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
241m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

392m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4b992f7cb349 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 141375b3740f9914918374a7d074a1051db1e8f0

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/1/testReport/

Max. process+thread count
2383 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 30s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 25s

trunk passed

-1 :x:
shadedclient
39m 24s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 23s

the patch passed

-1 :x:
shadedclient
39m 52s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
238m 48s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

389m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 83a6a8db4a8c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 39efd66702f9b959b9f19d181a193a5b151901ab

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/2/testReport/

Max. process+thread count
2456 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6005/2/pipeline   report ERROR: Failed to write github status. Token expired or missing repo:status write?
Can someone help me with this error? Or maybe other errors than I am not found？

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
56m 33s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
41m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
41m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
246m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

411m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerLongRunningTasks

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c4e47c2a3aaf 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf75d85ad12c27f63cefb644978d696ca6effaf7

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/3/testReport/

Max. process+thread count
2545 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
9m 59s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
2m  2s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 31s

trunk passed

-1 :x:
mvnsite
1m 37s
/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in trunk failed.

-1 :x:
javadoc
0m 25s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 26s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs in trunk failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
spotbugs
0m 26s
/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in trunk failed.

+1 :green_heart:
shadedclient
5m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 25s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 25s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/buildtool-patch-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
The patch fails to run checkstyle in hadoop-hdfs

-1 :x:
mvnsite
0m 24s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
1m 58s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
4m 47s

the patch passed

-1 :x:
shadedclient
6m 53s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
asflicense
0m 32s
/results-asflicense.txt
The patch generated 20 ASF License warnings.

43m 52s

Reason
Tests

Failed junit tests
hadoop.cli.TestHDFSCLI

hadoop.cli.TestCryptoAdminCLI

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2674aad07972 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d17310ff91da8f9114c2edcc966160d8a867d1fe

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/4/testReport/

Max. process+thread count
80 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/4/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 48s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
40m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 5 new + 264 unchanged - 0 fixed = 269 total (was 264)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
3m 24s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
40m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
243m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

400m  2s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Increment of volatile field org.apache.hadoop.hdfs.server.datanode.BPServiceActor.fbrCount in org.apache.hadoop.hdfs.server.datanode.BPServiceActor.offerService()  At BPServiceActor.java:in org.apache.hadoop.hdfs.server.datanode.BPServiceActor.offerService()  At BPServiceActor.java:[line 774]

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2073ac34d54e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f7057ba32e183b8c910c1fe130b5252f87cc3463

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/6/testReport/

Max. process+thread count
2453 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 22s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 21s

trunk passed

+1 :green_heart:
shadedclient
40m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 264 unchanged - 0 fixed = 268 total (was 264)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
40m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
242m 28s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

397m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.tools.TestHdfsConfigFields

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9bfabad703e3 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d496303580aff16afdbe4247b2633d5dc76bb84e

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/7/testReport/

Max. process+thread count
2286 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
65m 58s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
40m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 264 unchanged - 0 fixed = 268 total (was 264)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
41m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
241m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

415m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 482c27001089 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5fd970d8506390976546cd85fc3d3474d2a2e2f7

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/8/testReport/

Max. process+thread count
2719 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 56s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 11s

trunk passed

+1 :green_heart:
shadedclient
34m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 57s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 264 unchanged - 0 fixed = 268 total (was 264)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
34m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
265m 52s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

418m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6005

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux bca88202f866 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 43b514c36e2ccb5891899a08eb60c17cca67efa7

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/9/testReport/

Max. process+thread count
3071 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6005/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao hello, sir. This is a new clean build. Could you review it？Thanks

@LiuGuH Please keep one PR at https://github.com/apache/hadoop/pull/5888 to re-submit, thus we could trace the discussions. Thanks again.

@LiuGuH Please keep one PR at #5888 to re-submit, thus we could trace the discussions. Thanks again.
Ok ,  reopen it now.

The same PR to https://github.com/apache/hadoop/pull/5888. Close this one.


Text on marble diagrams have some ugly artifacts

Describe the bug
Text on all marble diagrams on the https://rxjs.dev/ website doesn't look very nice as there are some artifacts below most letters.
Example from https://rxjs.dev/api/index/function/takeUntil:

Zoomed in:

Expected behavior
The text should not have these weird artifacts.
Reproduction code
No response
Reproduction URL
No response
Version
7.5.7
Environment
No response
Additional context
No response

Hey @tyilo, thanks for reporting this. We are aware of this issue and we would like to update every marble diagram we have in the repository, but this is something that requires quite a lot of effort. If you have enough time, feel free to open PRs to update these images. We now have a new and better way of creating marble diagram images. For the reference, I'm gonna post a couple of PRs here to check how to do it: #6636 #6742 #6638 #6983
Also, I'm gonna close this issue since GitHub issues are intended to be used for bugs in the library core. If needed, we can open a new discussion where we could write (and track progress) of all marble diagram images that need to be updated.


Access to onPlaybackRateChange event

Hi, first of all, thank you for this great project.
I apologize if I just missed something in the docs about how to do this, but it seems that some of the events from the youtube api are not accessible directly through vue-youtube with an @Event binding in the template. As the subject of this email imples, I'm specifically interested in onPlaybackChange - although onStateChange would be nice too.
I do see that you have access to the addEventListener method of the player, which allows you to add the name of function to call. So, something like, this.player.addEventListener('onPlaybackChange', 'myFunction'). But, as far as I can tell the 'myFunction" needs to live on the global window. Maybe there is a better way to do this, but for now I'm putting a function on "window", which is not ideal.
Once again thanks.

I do not know why in your case the myFuntion should live on the global window.
Here is the example how it works in my project:
export default {
  ...

  computed: {
    player () {
      return this.$refs.youtube.player
    }
  },

  mounted () {
    // Listen Youtube player state changes (buffering, user's play/pause clicks)
    // https://stackoverflow.com/a/17087006/4992248
    this.player.addEventListener('onStateChange', this.youtubeControl)
  },

  methods: {
    youtubeControl (youtubeState) {
      /**
         * Youtube States:
         *  -1 - unstarted
         *  0 - ended
         *  1 - playing
         *  2 - paused
         *  3 - buffering
         *  5 - video cued
         */

      // Current Track stopped\finished playing (reached the end of time)
      if (youtubeState === 0) {

      } else if (youtubeState === 1) {

      } else if (youtubeState === ....) {

      }
    }
  }
}

Yeah, you're right, this definitely works. I was taking the youtube api docs too literally. They ask for a string representation of a listener function, not the function itself. I should have just tried it. Thanks, feel free to close... but maybe in the long term you could support more events at the vue template level.


[BUG]: Devtools might not start working before browser restart

Describe the bug
In some cases, the devtools might not function before a full browser restart, which is something we don't want to force on the user
To Reproduce
Steps to reproduce the behavior:

Install the extension
Open devtools
Try to use extension

Expected behavior
Devtools works as expected
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This should be made more robust in 0.1.8


Implement reitit reloading

Fixes #48 by implementing reloading of routes as recommended by reitit in https://github.com/metosin/reitit/blob/master/doc/advanced/dev_workflow.md
To take advantage of reloading, one has to return a function instead of a vector in his route definition. Check (defmethod ig/init-key :reitit.routes/api as an example.
The solution is backward compatible: it still accepts vectors as a route definition, but in that case no reloading.
The reloading is by default enabled only in :dev profile.
@yogthos , @nikolap please review before merging. I did some testing, but I'm not sure if there is a better/cleaner way to hook it up in integrant.

Once merged, one would also need to update all route definitions, e.g. in modules and docs to take advantage of reloading.
I could not find a way to enable reloading of routes while still keeping route definitions returning vectors,

Moved dev mode check in init-key for :router/core and changed (vec (map ... to (mapv ...

Just pushed up a new template with the changes.

@markokocic Hi I wanted to try this. I didn't read through the Reitit docs on it but couldn't get any re-evaluations I did take effect. Do you need to re-eval the actual handler or does any function down the call chain suffice? (I would guess so)
I created a new project with clj-new.

HI @gerdint , you need to re-evaluate only what you changed in repl, cider, nrepl for your changes to be picked up. Just saving the file does nothing.
You also need ot make sure init-key function for your route returns a fn instead of vector, like for example in api:
(defmethod ig/init-key :reitit.routes/api
  [_ {:keys [base-path]
      :or   {base-path ""}
      :as   opts}]
  (fn [] [base-path route-data (api-routes opts)]))

Hmm, this is exactly what I (thought) I did. Will have another go. It would save a lot of cpu cycles not to have to (reset) all the time.

I forgot to add that you have to be in the devmode for the hot-reloading of routes, for example clj -M:dev:cider
In prod mode, routes are cached.

@markokocic I still haven't managed to get this to work.
For instance, when following the instructions in the guestbook tutorial and changing and re-evaluating kit.guestbook.web.controllers.health/healthcheck! I still get old endpoint when I reload /api/health.
Is there anything else that is needed? Looking at https://github.com/metosin/reitit/blob/master/doc/advanced/dev_workflow.md it seems they refer to the routes as vars or by named routes?
I am starting the app with the :dev profile.

@markokocic So I upgraded metosin/reitit to 0.7.2 and used a var to reference the handler and now I get the updated handler upon re-eval. This makes sense but doesn't rely on the changes in this PR no? The metosin document referenced above doesn't seem to require it?

Hm, looks like reitit added support for vars after this pull request was merged. This means in order to have a reloaded workflow you either have to keep using functions approach, like in PR, or switch to vars.
Not sure if it's possible to combine these two approaches. It may be more of a question for reitit.
I'll try to revisit this sometimes in the future.

Well using vars is more of a temporary solution since it means routes won't be cached in prod right?
Used re-evaluating the router on every request in dev seems to be the way to go and IIUC what this PR is supposed to do, just don't get it to work. I haven't really studied reitit so my understanding may be wrong. But I still think that what I wrote above should be reproducible by just following the guestbook tutorial. If it actually works this workflow should probably be mentioned in the tutorial as well. When starting using Kit I was also new to the reloaded workflow and it wasn't clear from the docs (at the time anyway) how to work most efficiently. Having to do a (reset) on every change is quite slow I think.


Font loading but console error

Hi, I'm using an adobe typekit font with your module. The website is generated static and everything works fine, the font is displayed, although i have this error in console :
GET https://use.typekit.net/[myprojectcode].css/ net::ERR_ABORTED 404
My config settings :
  fontLoader: {     url: 'https://use.typekit.net/[myprojectcode].css/',     prefetch: true,     preconnect: true   },
Do you know why this error pos in my console ?
thanks

Hi, it's hard to say exactly where the problem is without inspecting the code.

My config settings :
fontLoader: { url: 'https://use.typekit.net/[myprojectcode].css/', prefetch: true, preconnect: true },

Double check that the link to the styles is correct. (try to remove / after '...css/')

Well...you solved the issue, it was the slash. I didn't pay attention as Adobe provides the link with it. Thanks a lot !

Np, I'm glad it worked! Cheers!


Include office application name when resolve the WOPI Discovery

I want to decide an icon for file list by WOPI action name and file extension.
So, I hope to include Office App name to "Discovery#resolve".
For example:
wopi_discovery.resolve("view", "csv")
app_name = wopi_discovery.app_name #=> "Excel"
icon_url = "/images/file_icon-#{app_name.downcase}.png" if app_name.present?

I believe that it is a very convenient.

Looks good.


policies: Ensure policy version succeeds

When adding a new policy version, there is a risk of hitting an AWS
limit. We therefore remove all but the default policy version and add
the new one to ensure success.
Fixes https://issues.redhat.com/browse/SDA-6659

@vkareh  Thanks, Victor. looks good to me. Do we need to document this, or is it an implementation detail that customers don't care about?

@vkareh Thanks, Victor. looks good to me. Do we need to document this, or is it an implementation detail that customers don't care about?

Ah good point, I think this would be good to have documented.
/cc @arendej

@vkareh is it possible the non-default policies are still in use be older clusters and deleting them will cause these clusters to break?

It shouldn't. Clusters only access the roles, and the role has the attached policy without a version specified. AWS determines which policy version to use when assuming role based on this.

@vkareh why do we use multiple versions at all then instead of deleting and recreating the policy when we update it?

@tbrisker because AWS does not allow you to delete a policy that is currently attached to a role. You would need to detach the policy (potentially incapacitating the cluster operator briefly), create the new version and re-attach it. Seems dangerous, and AWS provides the policy versioning as a way around that issue.

/lgtm
thanks for the explanation @vkareh!


Add latest banner

This is the new banner  for #49 and #1

The file has some linked images. If these are SVG they should be in the file.  If not, it is possible to add a simple double helix, for example as shown in the images at https://github.com/bioinformatics-hub-ke/BOSS22/pull/49 - line thickness can be increased, colors can alternate between pink #F34A53 and teal #1E4147 or pink #F34A53 and cream #FAE3B4
The text in white should have a background color so it can also be used in the light theme, perhaps gray #808080, black or pink #F34A53 can be used.

Can merge and make some of these changes. Maybe can use Yellowtail font for the top text - it has a permissive license.

@bkmgit it still works fine work without the Text.

Possible modified version

Cursive font is Yellowtail, regular font is Alegreya

It is helpful to convert fonts to paths since the fonts may not be installed on the users computer.

@Fnyasimi Made a pull request to your fork with svg files for the above. Feel free to modify if appropriate.

@bkmgit this has a mix up colour on the logo. Lets use what Mike did its okay without the text

jpg does not scale well on different screen sizes - one would usually have several different resolutions, then serve the appropriate one based on device being used.
Image below shows missing linked figures

Do also ensure that any figures used that are not original are appropriately licensed/credited.
.

@Fnyasimi @LandiMi2 Feel free to change the colors. However, the banner should work on both light and dark backgrounds.  Images from your own research would also be great. As an example have downloaded 6ljb and created a png file using jmol that could be traced to produce an svg file. A list of visualization software for PDB files is available at https://www.rcsb.org/docs/additional-resources/molecular-graphics-software Another such tool is [VESTA](http://jp-minerals.org/vesta/en/

)

Another possible source for an image https://www.researchsquare.com/article/rs-78868/v1

Image of 1pbr part of 16S made using ParaView, which can export a small SVG.

Image of 1bna obtained from VESTA with output traced using [Inkscape](https://inkscape.org/

)

looks better you can give it the green colour theme

@Fnyasimi Let me know if ok. It is 1Mb which is quite big though. Perhaps have a smaller selection of atoms only on the left?

@Fnyasimi @kipkurui Updated banner also in https://github.com/Fnyasimi/BOSS22/pull/1

use our theme colour #404096 code instead of grey. Also you might want to fix bhki logo

Updating to use https://www.rcsb.org/structure/2MK1 from which VESTA can produce an SVG image with a small size

Contrast of 404096 with black is not very good, so have switched it with green.

@bkmgit  this is good put it up on a diff PR

merging this so can update the file.


fix: 🐛 backfill the dataset after finishing the job

I think that it will fix https://github.com/huggingface/datasets-server/issues/1209

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage: 100.00% and project coverage change: +2.22 :tada:

Comparison is base (bb0a5da) 90.12% compared to head (8fb61d4) 92.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   90.12%   92.34%   +2.22%
==========================================
  Files         180       67     -113
  Lines        9981     4076    -5905
==========================================
- Hits         8995     3764    -5231
+ Misses        986      312     -674

Flag
Coverage Δ

jobs_cache_maintenance
?

jobs_mongodb_migration
?

libs_libcommon
?

services_admin
?

services_api
?

services_worker
92.34% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

services/worker/src/worker/job_manager.py
80.00% <ø> (-0.19%)
:arrow_down:

services/worker/src/worker/loop.py
60.60% <100.00%> (+0.40%)
:arrow_up:

services/worker/tests/test_job_manager.py
100.00% <100.00%> (ø)

... and 113 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore(infra): add error variant for file not found on get path

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2169  👈 (View in Graphite)
#2075
#2074
#2073
#2052
#2026
#2020
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/infra_utils/src/path.rs line 40 at r2 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Will be in a different pr.

See: #2210.


Added fall damage detection module

This pull request implements feature #144 for fall detection. The implementation works by detecting instantaneous accelerations above a given threshold. There are options for:

Suppress acceleration/damage caused by the player being launched into the air - for example by jump pads
Detect only damage caused by colliding with the ground, as opposed to colliding with a wall

Hmmm, I'm not sure about this one, it's a bit strange implementing specific game logic into a generic toolkit. I need to think about this and whether there is a more generic approach, this has the danger of implementing all sorts of specifics as people want to detect other forms of impacts.

I moved the fall-detector into an "examples" folder and put an extensive comment explaining that it was an example and that games would most likely need to customize it.


Added peer dependencies to package.json file to work with npm3

Hey @codydaig

I'm not really sure what's this PR trying to solve, can you explain a bit? I'm seeing added packages like paypal, grunt, jasmine-core, what are they added for?
Please squash to one commit.

For npm3 (which is still in beta), it will no longer automatically install peer dependencies. Currently, if your running the latest version of npm, it will spit out a WARN message every time a module has a peer dependency that is not already listed as a dependency in the package.json file.
More info here: http://blog.npmjs.org/post/110924823920/npm-weekly-5
The paypal line change wasn't an addition, it was a spacing inconsistency, but I believe that got resolved in the validator.js pull request that was just merged in.
I'm submitting a new pull request that has the two commits squashed. #658

Cool, closing this one.


Change all mac runners to macos-12

GitHub just upgraded our org to have access to mac M1 runners. This is the new macos-latest in CI, and it causes tests to fail for several reasons of varying complexity. In the meantime, we can specifically request the old macos-12 runners to keep running CI the way it was before.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.67%. Comparing base (10c2555) to head (6b15fb5).

Additional details and impacted files


Change response code to WRITE_PROCESS_REJECT when WAL limitation is triggered

Coverage decreased (-0.003%) to 42.32% when pulling 11ecb2c319ff053d4613241010265f69de32b588 on xingtanzjr/change_response_wal into 37d6cfed32b4aa2858c898dcb012b824f3ab041e on master.


App crashes in Homey V2.0

When tapping a flow card the Homey app crashes. Will there be an update for Homey V2.0?

I installed v1.03 of the app. When trying to edit the "then" flow card, the Homey app crashes. But when a new flow is made with the exact same parameters and saved, I can open it afterwards to edit the flow cards.
So to me it seems to be solved.
Thanks!

1.0.4 is now in the main app store.


Add 'width' Attribute to work with Bootstrap responsive web design

Hi,
This is my first time to request a pull in such a popular project.
I found the current typeahead may not work properly with Bootstrap responsive grid system.  I checked the issues and Internet and found someone asked about the problem but without a good solution.
Recently, I add a width attribute in typeahead json input and work very well to adjust the new width according to Bootstrap grid system (e.g. @ www.geniushire.com).
If you think this is a issue worthy of solving, I will try my best to improve it with your kindly help.
Thank you.
Mingyang from CMU

solved me by also adding this
.tt-menu {     position: relative !important; ... } .


forge support

make contact with the forge demons and add support for that cursed modloader that I don't like but will support anyways for the sake of learning a bit more about abstraction.

Todo:

Get SQLite loading with gradle
Register commands
Config


Resources was updated from DIPS.Mobile.DesignTokens

Here is the latest resources that was generated by DIPS.Mobile.DesignTokens repository

testing


docs(auth): Add detail documentation of authorization directive

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.479%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
172

Relevant Lines:
172

💛  - Coveralls


Why use Ruby for SASS?

I've been working with the node alternative for SASS for a while now and it seems that using the Ruby version is a bit unneeded. The 3.4 additions aren't really major (not for this project anyways) and there are a couple of benefits.

Using the Node-version is much faster (especially on windows)
Its easier to get this project going on Windows as they don't have Ruby installed (you really need to watch out for your Windows users too)
While it may not be on par with Ruby, its stable and deemed production ready by a lot (even though the readme doesn't state this).

You can just include it as a node-module (gulp-sass instead of gulp-ruby-sass) and get it over with. I really like that you won't have an entire dependency before you start and can easily update it too when new versions come out.

So Foundation 6 is released, but Ruby is still a requirement for Foundation for Apps?

@Martinspire It's not. Our starter template for Apps uses Libsass.


Major refactoring done

Pull Request Test Coverage Report for Build 24

310 of 355 (87.32%) changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 84.81%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/api/v1/auth/views.py
30
32
93.75%

app/models/review.py
11
13
84.62%

app/models/loggedinuser.py
11
13
84.62%

app/models/user.py
32
35
91.43%

app/api/v1/reviews/views.py
50
64
78.13%

app/api/v1/businesses/views.py
144
166
86.75%

Totals

Change from base Build 22:
-0.9%

Covered Lines:
402

Relevant Lines:
474

💛  - Coveralls


moment.min returns different results depending on the order

If I try to get the min of two moments, one of which is invalid, then the result I get depends on the order in which I specify the moments:
moment.min(moment(""), moment()).toDate()
// Invalid Date
moment.min(moment(), moment("")).toDate()
// Wed May 06 2015 14:52:20 GMT-0500 (CDT)

I'm not sure what the expected behavior should be, but what I expected is something like this:
function getMin() {
  var dates = Array.prototype.slice.call(arguments);
  dates = dates.filter(function (a) {return a.isValid();});
  // etc.
}

Here's a fiddle: http://jsfiddle.net/4cnm5vod/

Consider:

Moments are compared based on their value.
moment("").valueOf() returns NaN
Math.min(NaN,0) and Math.min(0,NaN) return NaN

Therefore, I would expect any moment compared to an invalid moment to return the invalid moment.

That sounds right to me, not necessarily what I would expect, but certainly logical and predictable.

Well, PRs is welcome :)

Close in favor of #2438
Note that you still have to filter out invalid moments yourself, or you'll get some invalid result (one of the args).


Update dfp_training stage to support ControlMessages or MultiDFPMessages

Description
Closes #1148
This addresses relevant issues with 1148, except for passing in a DataLoader to the fit function; the internal _fit_centralized call only supports pandas dataframes, so without knowing more about the problem we're attempting to solve, it warrants more discussion.
Checklist

[x ] I am familiar with the Contributing Guidelines.
[x ] New or existing tests cover these changes.
[x ] The documentation is up to date with these changes.

/ok to test

/ok to test

/ok to test

/ok to test

/ok to test

Do we have tests that are going to cover these changes? I don't see any tests explicitly for AutoEncoder.

/ok to test

/ok to test

/ok to test

/ok to test

/ok to test

/ok to test

/ok to test

/ok to test

/merge


Xcode: need to select device to create provisioning profile

Feedback from developer:
https://flutter.io/setup-macos/#ios-setup dosen't tell you that you need to select your device in the upper right corner of xcode to create a provisioning profile for it.
/cc @cbracken @xster

As of ~a week ago, it shouldn't be needed anymore on master. The command line flutter tool should be able to create provisioning profiles for you (you still need to sign in in xcode etc).

caveat, we're very unlikely to have a nicer solution using Google certs (can give more details offline)

It seems like this bug can be closed, as per @Xster's comments. Please re-open and clarify if I've read that wrong.


Fix image URL in readme

LGTM

ha - https://github.com/openservicebrokerapi/servicebroker/pull/253 fixed it too but its been lingering... :-(
LGTM

I think we can close this one now that #253 has been merged, however I'm wondering why github isn't complaining about a merge conflict.


Video preview contained in a navigation controller, is it possible?

I am using a navigation controller between my views.
The problem is that the video preview of the barcode scanner ocupes all the container.
I am using the scanInModalAction because the scanInPreviewAction doesn't work well.
Is the above possible, or I need to use the cancel button, wHich I disabled?
Thanks for any clue.

I'll close this issue. You should ask this kind of question on stackoverflow.
To quickly answer to you, you can embedded the QRCodeReader wherever you want. You can either use the the QRCodeReaderController or the QRCodeReaderView.


openimageio: 1.8.8 -> 1.8.9

Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/openimageio/versions.
These checks were done:

built on NixOS
ran /nix/store/p493iy79axka02qddq8zn8ki9qxv89lr-openimageio-1.8.9-bin/bin/iinfo help got 0 exit code
ran /nix/store/p493iy79axka02qddq8zn8ki9qxv89lr-openimageio-1.8.9-bin/bin/maketx -v and found version 1.8.9
ran /nix/store/p493iy79axka02qddq8zn8ki9qxv89lr-openimageio-1.8.9-bin/bin/oiiotool --help got 0 exit code
ran /nix/store/p493iy79axka02qddq8zn8ki9qxv89lr-openimageio-1.8.9-bin/bin/oiiotool --help and found version 1.8.9
found 1.8.9 with grep in /nix/store/p493iy79axka02qddq8zn8ki9qxv89lr-openimageio-1.8.9-bin
directory tree listing: https://gist.github.com/171d660967f6995b3e6107258782e390

cc @cillianderoiste for review

(Hydra shows no success on Darwin & ARM)


FreeBSD: Add support for setting CPU affinity

Neat. Thanks!

I was hoping to be able to generate the same USE_CPU_SET macro on FreeBSD instead of a second #define, but my m4/autotools skills weren't up to it.  Anyway, this seemed ok.
Thanks for merging :-).


NGINX Setup

We should finalize the NGINX setup for both local and production development. Right now the production branch needs to be rebased over master to avoid risk. But we should ensure NGINX works locally and merge the branch into master.


Editor 6.2.1 - search is missing

Hitting CTRL+F does nothing and search / replace menu item is also missing from the menu.
Windows 7 64bit.
Thanks,
Imre

Closed, duplicate of #123


Use Supervisor.child_spec for type

Use the typespec from Elixir, Supervisor.child_spec/0 instead of the Erlang module type.

By submitting this pull request, I confirm that Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms.

dialzyer throws an error on this since hackney_pool implements child_spec as a tuple and not the map, closing since this is very old either way.


Calculate the current server time to be used in a better way to prevent problems

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Motivation and Context
We now use a custom time request which should be more reliable.
We also calculate the current time based on the offset between client and server and not based on a counter using the last synced server time (which is unreliable in background tabs)
Description
The call is invoked at most 5 times per minute.
Note: Even if the student manipulates his system time, the artemis time won't be in sync for max. 2 minutes if online and in an exam.
Steps for Testing

Student: Navigate into an exam with a wrong local computer time / different time zone
The time until the exam end should be displayed correctly

Note: If you change the time locally while being in this view, this will not be discovered

@schultek and I encountered a similar issue. When being in the start screen, after confirming with the name (timer is running) and you change your local time after the start date, you are able to see the exercises.
We could also reproduce the error mentioned by @anditurdiu

@schultek and I encountered a similar issue. When being in the start screen, after confirming with the name (timer is running) and you change your local time after the start date, you are able to see the exercises.

This cannot be prevented with the current approach, but you should have only been able to do this for approx. 2 minutes

It looks like you can still go back and edit your answers after the exam has ended with a bit of time trickery.

With all those time hacks and so on, can you actually store answers on the server?
I would argue that it is sufficient to work with a clock that is incorrect before the exam starts.
A systems time only updates in small intervals (talking ms) from NTP, so sudden time jumps should not be of our concern.
Students who try to get more time by changing their clock can get the UI to work again, as long as the server responds appropriately.

It was indeed saving the changes in the server, but this seems now to be fixed as well.
Another thing: We could use something like this to respond quicker to time changes:

let t = Date.now();
setInterval(() => {
if (Math.abs(Date.now() - t - 1000) > 1000) {
console.log("TIME MODIFIED");
}
t = Date.now();
}, 1000);

I also tested on ts 1 and was able to manipulate the time left in the exam by changing my local laptop time in system preferences. Changes in time also ended the exam and brought me to the final end/print exam page. Changing system time allowed me to go back and start the exam, and then manipulate the time left again.

Are you sure this branch was on the latest version of develop and you really have saved something after startDate + workingTime have been over?

It was indeed saving the changes in the server, but this seems now to be fixed as well. You can still go back, but save requests to the server are rejected.
Another thing: We could use something like this to respond quicker to time changes:
let t = Date.now();
setInterval(() => {
    if (Math.abs(Date.now() - t - 1000) > 1000) {
        console.log("TIME MODIFIED");
    }
    t = Date.now();
}, 1000);

Still no perfect solution though.

we tried something like this (that was actually our first approach), the problem is that the interval time is not guaranteed. If the tab is in the background, the interval might be slower causing issues

The main purpose of this PR is not to prevent local time changes, but to prevent the display of wrong times in case the system time is accidentally wrong or the student is in a different time zone when the exam starts.
Please focus on testing that this does not cause any issues!
Of course, the student should not be able to submit before exam.startDate and after exam.startDate + studentExam.workinTime. Please test this as well, but keep in mind that this check is part of the server

Since this PR is Intended to handle different time zones I also think the following issue falls under the scope of this PR:

When you create an exam, but the student is in a timezone earlier than the one of the exam, the exam is not listed in the exam screen. This screen should also calculate which exams to show using the server time. Screenshots below:

Exams which are running currently:

Exams Overview:

How to reproduce:

Create an exam setup and start an exam
Set your local time to -2 hours for example, or to any time which is before the visible exam time
Navigate to the exams page

Since this PR is intended to handle different time zones I also think the following issue falls under the scope of this PR:

When you create an exam, but the student is in a timezone earlier than the one of the exam, the exam is not listed in the exam screen. This screen should also calculate which exams to show using the server time. Screenshots below:

This screen now also uses the server date

@tiffca Thank you for testing, but these are things that currently cannot be prevented. Here's the main focus of this PR: https://github.com/ls1intum/Artemis/pull/1757#issuecomment-653075489

@filip-gregurevic Thanks, I was testing "the student is in a different time zone when the exam starts". Also, the student was able to submit the exam before the server end time. It already has 2 approvals, so I think it can be merged!


Start to add tests for Ractor

I don't have confident I have understood as correct 🤔
https://github.com/kachick/ruby-ulid/issues/120
https://github.com/ruby/ruby/blob/3cf001811950608908b5d092c673572c5357fbbd/ractor.rb
https://docs.ruby-lang.org/en/3.0/Ractor.html
https://bugs.ruby-lang.org/issues/17273
https://bugs.ruby-lang.org/issues/17397

ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]
Ractor.make_shareable(Time.new)
#=> can not make shareable object for 1970-01-01 00:00:00

On ruby-3.1.2 above code works... 🙄


Add ARM64 support to sofa-rpc and add ARM64 job to Travis-CI

Added ARM64 architecture to .travis.yml with openjdk-8-jdk.
Updated 'netty-tcnative-boringssl-static' dependency's version to 2.0.34.Final for AArch64 support.
Updated 'embedded-consul' version to 2.2.0 and added 'groovy-all' dependency for ARM64 support.
Added 'rocksDB' dependency to registry-sofa's pom.xml for AArch64 support.

Signed-off-by: odidev<EMAIL_ADDRESS>

Codecov Report

Merging #983 into master will decrease coverage by 19.89%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d09c2...28e6f77. Read the comment docs.

Hi Team, can you please review this PR?


refactor: transform obj-shorthand

Modernize Code
Requires prior PRs to be merged in order:  #95, #97, #98, #99

PR closed as parent PR has been invalidated.


chore: exclude corpus files when publishing to crates.io

Description of changes:
This change excludes fuzz test corpus files from the crates published to crates.io. I've also corrected the s2n-codec version to be an exact version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Do this match the files or does it need to be */corpus.tar.gz?

We should probably also exclude the API snap file while we're here

Do this match the files or does it need to be */corpus.tar.gz?
I ran cargo package --list  --manifest-path quic/s2n-quic-core/Cargo.toml and the corpus files are not there

We should probably also exclude the API snap file while we're here
Ah yeah, thats only used by docdiff, which isn't published anyway, right?


CI: reinstall torch versions

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
In case some notebook request a specific torchvision or torchtext version all related packages shall be updated
So if torchvision is updated (it hall automatically reinstall torch) but then also torchtext shall be updated

check if any of these packages were changed
if so check mapping table and adjust remaining packages

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

based on the discussion in #172 these adjustments need to be projected to the pip installation command in the notebook top section as this collision may also happen while running in Colab which already has some pre-instaled versions...


[Foundation] Fallback to presuming 32-bit platforms if we dont explicitly know that it is 64 bit; this allows for better portability

This should resolve rdar://problem/46683060

@swift-ci please smoke test

This seems like a bad idea to me. Most platforms people are trying to port Swift to are 64-bit these days. #else + #error would be a lot safer.

@jrose-apple Is there a more future-proof way to avoid breaking the build?

This seems like one of those "trap early" philosophy things: it is better to break the build at the point where something is unknown, with an explicit message, then to stumble on and fail later when you don't know what's missing.

@swift-ci please smoke test

I really wish we had a #if bits(64) or #if bits(32) or something like that. It would alleviate this type of error.

@swift-ci please smoke test


DEP Update civis dependencies for 1.6.0 release

This PR updates civis and civisml-extensions to match functionality and behavior in the Python 3 notebooks. I'm keeping the version updates minimal, since I'm not confident in what supports Python 2 at this point, but I want to keep the notebooks on the same civis versions. I'm planning to cut a release after this PR, unless there's anything else that should go in.

Tagging multiple people for code review to check for any data science or engineering-specific considerations with cutting this release.

I think it looks fine from the tech side.  I agree with Stephen that it should probably be a patch release if it's just picking up bugfixes from those two packages, but I don't feel strongly either way.

I picked minor version because there's a minor version update for numpy, but I'm fine with making this a bugfix release.

What if we include an update to Ubuntu 18.04 as the FROM image and keep this as a minor version increase?

Ok, this is ready for another look.


IntelliSense feature fail in the Azure CLI's vscode extension

Issue Summary: The IntelliSense feature in the Azure CLI's vscode extension is not working on my Windows 11 machine. Code hints and completions do not appear. I suspect that the issue may be related to a conflict with the copilot extension, which is also installed, but disabling copilot did not resolve the issue.
Steps to Reproduce:

Open vscode on a Windows 11 machine
Install Azure CLI extension
Install copilot extension
Attempt to use IntelliSense feature in Azure CLI extension
Observe that code hints and completions do not appear

Expected Result: IntelliSense feature in Azure CLI extension should provide code hints and completions
Actual Result: Code hints and completions do not appear when using the IntelliSense feature in Azure CLI extension
Notes

Copilot extension has been disabled but it did not resolve the issue

Request for Help I am requesting help to resolve this issue with the IntelliSense feature in the Azure CLI's vscode extension. Any suggestions or solutions would be greatly appreciated.

It works ocasionally but its super flow.


Ensure email is not None

If a user chooses not to share their email via the OpenId login page,
we end up passing through None as the 'email' value, which ends up
raising a "column 'email' cannot be null" error on some databases.
Blank string is fine.

Thanks!


Hide clear label

Hi, how I can hide the clear label. I'm trying this:
signature.ClearLabel.IsVisible = false;
But doesn't work.
Thanks!

signature.ClearText = string.Empty;

Removing the clear label may mean that you are not wanting all the bits. You can check out the SignaturePadCanvasView.
This is basically the real signature pad control, but without all the buttons and labels. You can still use all the features of writing signatures and saving, but it has to be done programmatically.

This is not really a feature that we would implement, unless there is a high demand (which can be shown by voting on the issue).
If you want to control the chrome, you should make use of the chrome-less SignaturePadCanvasView and listen to the events.
SignaturePadView is really a very small layer over the SignaturePadCanvasView, and just listens to the StrokeCompleted event. All the other events and methods are available on the canvas.


ChakraCore Servicing update for 2020.08B

[CVE-2020-1555]

The test AsmJs\params.js is passing locally in my box and in the build machine. Not sure why it is failing.

That one has had occasional timeouts for years. I'd be okay with marking it "slow".


Hotkey improvements

to #2142, see screenshot there

Cleaned design of hotkeys popup
unified css and js for news and hotkeys
chunk_lib=>render_infopanel wrapper for popups
bottom corner hint about hotkeys
hotkey list shows just shortcuts, relevant to current page
minor changes in hotkey descriptions

Sure, try to find some time...


Set enabled to false will show Invalid prop gesture supplied to React.Fragment. on Version "4.0.0-alpha.0"

Describe the bug
This console error will appear if set enabled to false. Everything is still working but this error will keep pop up
To Reproduce
Set enabled to false on web
Expected behavior
Should just disable the drag to scroll functionality
Screenshots

Versions (please complete the following information):

react-native: v0.72.5
react-native-reanimated: v~3.3.0
react-native-reanimated-carousel: v4.0.0-alpha.0
react-native-gesture-handler: v~2.12.0

Additional context
Add any other context about the problem here.

same issue arrive in my app. version 4.0.0

I can verify that the issue persists in version 4.0.0-alpha.0


Get some docs going on

Document basic examples and add a few docstrings, most important thing are examples.

There's a wiki now https://github.com/pcm-ca/vegas-lattice-rs/wiki


Wrong Python executable used when running code using PythonExecutionFactory

Environment data

VS Code version: Insiders
Extension version (available under the Extensions sidebar): Latest (main branch)
OS and version: mac
Python version (& distribution if applicable, e.g. Anaconda): N/A
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: N/A

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Use the python environment provided when creating a PythonExecutionFactory
Actual behaviour
Wrong Python environment is used when creating a PythonExecutionFactory
This should be pretty evident from the following code

    public async create(options: ExecutionFactoryCreationOptions): Promise<IPythonExecutionService> {
        let { pythonPath } = options;
        if (!pythonPath) {
	  		...
        }
        pythonPath = this.configService.getSettings(options.resource).pythonPath;
   		....
        return createPythonService(
            pythonPath,
            processService,
            this.fileSystem,
            undefined,
            await windowsStoreInterpreterCheck(pythonPath),
        );
    }

If you look at the above code, pythonPath is always deafulting to pythonPath defined in settings.json even if a PythonPath has been provided in options
This causes issues in Jupyter extension as its not using the python path provided in options

I'd submit a PR, looks simple enough, but not sure what we were attempting to fix when this code was changed.
The solution looks simple as follows:
        if (!pythonPath) {
	        pythonPath = this.configService.getSettings(options.resource).pythonPath;
        }

Get pythonPath from settings only if its empty.


What should the API look like?

Currently the user needs to provide:

a GADT of well-typed commands
a model
pre-/post-conditions and a model transition function
a generator of untyped commands without references
a shrinker for an untyped command
semantics of well-typed commands
a bunch of common instances for the commands; show, read, eq, ord, functor, etc
a function which identifies which commands return a reference/variable

Given the above, the library gives a sequential and a parallel property back to the user.
While this seems to be quite a minimal set of things we can expect from the user, there are still a couple of problems:

the Functor and Read instances for well-typed commands can't be derived, and Functor requires an unsafeCoerce, see #16. These problems didn't exist before, when commands were untyped, see #9, is it worth the trouble?
the types of the property helper functions (sequentialProperty and parallelProperty) could be simpler, perhaps using classes or records to pack up functionality?

Ideas on how we can fix these problems? Are there other problems? Are there better design choices?

Just to add my current thinking how the api for the user should look like (in the case of multiple references). So the user provides the following three types:
Ix :: *
Cmd :: * -> Maybe Ix -> (ix -> *) -> *
Sem :: Ix -> *

Here Ix is used to distinguish between different reference types, so in the case there is only one reference type Ix ≅ (). The arguments for Cmd resp bind ref is as follow:

resp :: * is the type of the response
bind :: Maybe Ix is Just ix if the Cmd returns a reference of ix :: Ix type, and it is Nothing if no reference is returned
ref :: Ix -> * is the type references.
The Sem type is used to store the "real" references of the system, I'm not happy that this is currently needed, but will come back to it later.

The current running example we have would look like this (with Ix = ()):
data Cmd :: * -> Maybe () -> (() -> *) -> * where
  New :: Cmd () (Just '()) ref
  Read :: ref '() -> Cmd Int Nothing ref
  Write :: ref '() -> Int -> Cmd () Nothing ref
  Inc :: ref '() -> Cmd () Nothing ref

The evaluation would look as follows:
semStep :: Cmd resp m Sem -> IO (FromMaybe () Sem m, resp)

Where
type family FromMaybe (z :: *)(s :: ix -> *)(m : Maybe ix) where
  FromMaybe z s Nothing = z
  FromMaybe z s (Just x) = s x

The StateMachineModel type gets updated to the following:
data StateMachineModel ix model cmd = StateMachineModel
  { precondition :: forall ref m resp. Ord1 ref => model ref -> cmd resp m ref -> Bool
  , postcondition :: forall ref m resp. Ord1 ref => model ref -> cmd resp m ref -> FromMaybe () ref m -> resp -> Property
  , transistion :: forall ref m resp. Ord1 ref => model ref -> cmd resp m ref -> FromMaybe () ref m -> resp -> model ref
  , initialModel :: forall ref. model ref
  }

Current benefits that I see with this is:

Cmd will be a proper Functor (well Functor1) with no unsafeCoerce
We don't treat any of the resp types as special, and don't do special casing and unsafecoerce the semantics, (so postcondition and transitions always get the resp but may also get the ref if the command binds one.

I don't know of the drawbacks yet, since we haven't experimented with this much yet.

A variant of the above was implemented in #33.


Caution remark on not enabling SSPR is unclear

The following remark is not very clear.
"If you do not enable Self-service Password Reset (SSPR) in Azure AD users will have a confusing experience when they reset their password in Azure AD and then attempt to sign in in Active Directory with the new password, as the new password isn’t valid in Active Directory. You should only use this feature when SSPR and Password Writeback is enabled on the tenant."
If SSPR is not enabled, the user will not able to reset his password in Azure AD in the first place. So how can he have a confusing experience?
How is ForcePasswordChangeOnLogOn linked to SSPR functionality? Only the dependency with Password Writeback is clear to me.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c900f942-4456-5238-9f4c-a7a5bd685c04
Version Independent ID: a5d7d971-765f-0977-f531-232ea5924121
Content: Implement password hash synchronization with Azure AD Connect sync
Content Source: articles/active-directory/hybrid/how-to-connect-password-hash-synchronization.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@bartvermeersch Thank you for making us aware of this scenario with our documentation. I will have the content team evaluate this and make an update as appropriate.

#please-close

Sorry @billmath it is stil unclear to me :-/
I understand you need Password Writeback for ForcePasswordChangeOnLogOn to work properly. But why do you need SSPR?
The ForcePasswordChangeOnLogOn switch will sync the temporary password to AAD. So the user will be able to log in with the temporary password. But he will be forced to change his password immediatly after logging in. There is no need to reset it thus SSPR is no prerequisite.
SSPR could be an alternative for ForcePasswordChangeOnLogOn, where a new user is given no temporary password and he has to gain initial access to his account by resetting the password using SSPR (and Password Writeback).


Playlist videos missing default view size

In Kino mode everything is ok:

But in default mode the playlist videos are missing:

The second view is what I'm seeing and I think it's a bug resulting from YouTube changing their code; I'm used to the playlist appearing below the video, not to the right of it.

This should be fixed in the developer version.

Well...

@F43nd1r that looks new. Do you have anything that could conflict with YouTube Center? Also could you please tell me which browser you're using and how you installed YouTube Center (addon or userscript w/ Greasemonkey or Tampermonkey),

I don't think any of my other plugins coul dconflict wiuth it. Anyway, here's a list:AdBlockPlus, Hide Caption Titlebar plus, Instantfox, Tab Mix Plus, Masterpassword Plus
Browser: Firefox
Installed via addon (.xpi from git wiki)

@F43nd1r try to take a look at this issue #1463.

Fixed in dev 481

Note: Not a real Problem, because reloading the page fixes this. Still: When I toggle (no matter whether on or off)  the 'hide footer' settting while in  a playlist tab, this bug arises again.

@F43nd1r It's still a problem even if reloading the page fixes it. The ideal solution is to not having this issue appear at all. So if it's an issue then please create a new issue preferable with a reference to this issue.


MONSTRA 4

Hello Everyone!
We have a good news! MONSTRA 4 in development :)

GENERAL FILES STRUCTURE

SITE FILES STRUCTURE

TASK LIST

[x] New MONSTRA CORE
[x] Unlimited folder/url structure
[x] MARKDOWN Jekyll like pages
[x] Composer for managing php libraries
[x] Doctrine cache
[ ] Multi site development
[ ] Multi language site development
[ ] Default theme build on Twitter Bootstrap 4
[ ] YAML configs for themes, plugins and site.
[ ] Admin panel as an plugin

DONATE
QIWI: +79805359141
PayPal<EMAIL_ADDRESS>Sberbank: 5469 1300 1053 3949

This is very very very good news! Monstra can be the best flat-file CMS! Please add free bootstrap themes from https://bootswatch.com/ to new Monstra.

wow! great news!
look at the Kirby cms panel as example (https://getkirby.com)


Enabling localizability of the Elements for Edge extension

This PR enables the localizability of Elements for Edge extension.
After this PR this extension will have:

Elements UI will be displayed in a supported language, the locale will be autodetected to match VS Code locale.
locale(s) containing the translations can be provided in a json format, qps-ploc is provided in this PR as an example of the file structure and also to test the localizability on the extension.
A "Localization" settings to the extension with three values: Enabled, Disabled and qps-ploc.
A "locale fallback" mechanism, developers can specify which locale(s) and order should be tried before trying the next one.
NOTE: frontend code must support localizability otherwise no visual change will be notable**

What this PR is doing?

Creates the "getStrings" event
Provides a qps-ploc locale file
Adds a string provider, this singleton provider:

Contains the callback that exposes strings to the UI.
Contains the fallback logic

Modifies the messaging layer, so when the host container is ready it will ask for the loaded resources, if resources are provided they will be exposed by the string provided, otherwise it will be a NO-OP.
Some tools in the elements panel are whitelisted through the label, as the label can now be localized we need to whitelist the "translated label" too. This is done in the simpleView.ts polyfill
Modifies utils.ts to load the resources from the specified file (and handles the on/off logic from settings)

@lmitchell @jalissia This is ready for review :)

I have some tests for stringProvider, @jalissia do you prefer me to include them in this PR, or in a different one?

Cleaning out old PRs.  Closing out this PR since it is very dated. We can re-open this PR after updating these changes to work with the tip of branch if some of these changes are still applicable.
FYI @vidorteg


fix: keystone fernet key setup

这个 PR 实现什么功能/修复什么问题:
修正：keystone启动自动设置fernet keys，以及其他bugfix
是否需要 backport 到之前的 release 分支:

release/2.10.0

Codecov Report

Merging #1022 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1022      +/-   ##
=========================================
+ Coverage    7.93%   7.94%   +<.01%
=========================================
  Files         355     355
  Lines       56236   56237       +1
=========================================
+ Hits         4464    4466       +2
  Misses      51379   51379
+ Partials      393     392       -1

Flag
Coverage Δ

#aFlag
7.94% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/policy/policy.go
2.04% <ø> (ø)
:arrow_up:

pkg/cloudcommon/policy/resources.go
0% <ø> (ø)
:arrow_up:

pkg/util/multipart/reader.go
96.66% <ø> (ø)
:arrow_up:

pkg/util/fernetool/fernet.go
27.27% <0%> (-0.86%)
:arrow_down:

pkg/cloudcommon/db/domain.go
0% <0%> (ø)
:arrow_up:

pkg/util/seclib2/seclib.go
95.74% <0%> (+4.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0138135...acbd682. Read the comment docs.


⚠ Bofrost.nl has degraded performance

In 98c45f3, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1276 ms

Resolved: Bofrost.nl performance has improved in 837b098.


Fix some code smells

Fixes up some code smells

[Current coverage][cc-pull] is 98.79%

Merging [#35][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master        #35   diff @@
==========================================
  Files             5          5
  Lines           165        166     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            163        164     +1
  Misses            2          2
  Partials          0          0

Powered by Codecov. Last updated by [4648585...1d0681d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/phalt/beckett/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/phalt/beckett/compare/4648585373c7ac025e5b9cdab8321d3c18be01ca...1d0681d4c1adadf51e45295604e1f75a07f551ae?src=pr
[cc-pull]: https://codecov.io/gh/phalt/beckett/pull/35?src=pr


Add support for monitoring a user's post/comment history

See:  https://www.reddit.com/r/csharp/comments/apg0o7/announcing_the_first_stable_release_of_redditnet/egan9wd/?context=3

Added in 1.1.0.


GFT sensor shows "Geen", day after tomorrow shows GFT

The sensor trash.gft has value "Geen", but the trash_day_after_tomorrow shows "gft"

I see that the friendly name contains a space, maybe that the previous issue with the space is not completely fixed?
friendly_name: 'trash_gft '

This is something you configure yourself and isn't an issue with the component. Check the names used for your images, and maybe check this as a reference:
https://github.com/xirixiz/my-hass-config/blob/master/packages/trash.yaml

But as far as I know, I do not create the sensor and the sensor shows "Geen", but it should show a date?

That's certainly true :). However, Geen is default when no data is retrieved for that sensor. Can you share a postal code and housenumber matching you area? Or maybe you can check yourself:
https://json.mijnafvalwijzer.nl/?method=postcodecheck&postcode=&huisnummer=&toevoeging=&langs=nl
Should match the following....
https://json.mijnafvalwijzer.nl/?method=postcodecheck&postcode=1111AA&huisnummer=11&toevoeging=A&langs=nl
Check what the upcoming GFT pickup says in json.

An example postal code is 6851GJ number 2. I tried your link but the json contains a huge amount of info

I think there's still something going wrong in your code:
When I execute the code manually:
Afvaldienst('mijnafvalwijzer', '6851GJ', '2', '', 'false')

I get the following output:
[{'key': 'pmd', 'days_remaining': 0, 'value': '29-04-2020'}, {'key': 'gft', 'days_remaining': 1, 'value': '30-04-2020'}, {'key': 'papier', 'days_remaining': 5, 'value': '04-05-2020'}, {'key': 'restafval', 'days_remaining': 19, 'value': '
18-05-2020'}]
[{'key': 'first_next_in_days', 'value': 1}]
[{'key': 'today', 'value': 'pmd'}]
[{'key': 'tomorrow', 'value': 'gft'}]
[{'key': 'day_after_tomorrow', 'value': 'None'}]
[{'key': 'first_next_item', 'value': 'gft'}]
[{'key': 'first_next_date', 'value': '30-04-2020'}]
['pmd', 'gft ', 'restafval', 'papier']

Hmm, but when I add it to my hass config, I also get "Geen". I`ll reopen the issue and investigate further.

Found it! See the nasty space after gft...

Great you found the issue! I already expected it had something to do with the space...

Fixed in 4.1.9


Helm chart publish policy on push to master can result on uncontrollable breaking changes

Since https://github.com/seaweedfs/seaweedfs/pull/5035 helm chart are published on push to master, erasing current version.
That may result to breaking changes in the same chart version, for instance with https://github.com/seaweedfs/seaweedfs/pull/5236.
Why not wait for a new release before publish new helm chart ?

Send a PR to fix this?

Yes https://github.com/seaweedfs/seaweedfs/pull/5265


LC-728-search-filters-accessibility

Adding accessibility to search filters in LPG and fixing video mp4 in display-video.htm

Reviewed the code with Vince.


Fix wrong file concats without newline

As issue #9 said, I encountered a file concats error. It is emergency.
Reference @mhrabovcin 's PR, I recode the gover with adding mssing newline. The methods is different with mhrabovcin's, I chioce to stringtify with "\n".
And fix the current work directory error of unit test.
@modocache Please help to review, thank you.

@EdwardStudy please rebase

@aledbf Hi, I just rebase code. Sorry for the late reply.


Promote proto to version 2.1

As milvus 2.1 was released, should update the proto submodule to version 2.1 in the main branch.

/assign


Fixed minor typo during Mail creation

I think you had a very small typo in one of the examples (adding $to instead of the ToCollection $tos).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @joeldixon66!
Did you have any other feedback on the new prototype? We are looking for at least one more thumbs up so that we may begin development.
With Best Regards,
Elmer

No worries @thinkingserious - I'm happy with the new prototype - but I'm new to SendGrid and the php client - so I'm certainly not any authority on the matter. I'm still happy to provide a yes vote if you'd like.

Hi @joeldixon66,
Your feedback is still very valuable. It is good to get an objective opinion from someone outside the SendGrid ecosystem, but that has experience with PHP.
Thanks!
With Best Regards,
Elmer

Hello @joeldixon66,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


shell widget zsh runs in bash

Describe the bug
When executing the "widget" cheatsheet from navi fn welcome in zsh, you get errors apparently from the script executing in bash.
To Reproduce
Steps to reproduce the behavior:

After installing, run navi fn welcome
Scroll down to the "widget" cheatsheet and hit enter.
See error:

bash: line 34: zle: command not found
bash: line 35: bindkey: command not found

Expected behavior
The widget script executes without error.
Screenshots
N/A
Versions:

OS: <IP_ADDRESS>-microsoft-standard-WSL2 Ubuntu 20.04.3 LTS "focal"
Shell Version

    ~  sh --version                                                                            ✔    13:08:26 
sh: 0: Illegal option --

    ~  zsh --version                                                                         2 ✘    13:08:30 
zsh 5.8 (x86_64-pc-linux-gnu)

Additional context
I installed using homebrew.

I was able to reproduce the problem.
Now that I'm thinking about it, I don't think there's a simple solution for that.
Even if I fixed the value for $SHELL, the widget would only be loaded for a subshell which would immediately terminate, which is effectively a no-op.
I think this would only work if navi fn welcome were executed as a widget in the first place, which defeats the purpose.
I'll need to think about this.


Web: change SDK selection when NullSafetyMode.autodetect is working

From @jonahwilliams

[NullSafetyMode.autodetect is when] the user did not pass a null safety flag
so what we should do is look at the SDK version and entrypoint to determine if it is opted in
but that is not implemented so it falls back to unsound on web

We didn't fall back to unsound. So in https://github.com/flutter/flutter/pull/70120 I changed it to actually fall back to the unsound SDK.

Still need to make sure the web asset server knows which mode was selected

FYI - @pcsosinski for beta tracking.

does this block a beta release?

This should be fixed but waiting for another cleanup CL. It should not block a beta