[CARBONDATA-3889] Cleanup code for carbondata-streaming module

Why is this PR needed?
need cleanup code in carbondata-streaming module
What changes were proposed in this PR?
Cleanup code in carbondata-streaming module
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1566/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3303/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1672/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3414/

LGTM


[WIP] feat: Add API for single pull request scan

Pull Request
Description
Current PR includes a new REST API for a single pull request scan.
Also, it contains code refactoring and UT updates.
Fixes #354
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[X] Documentation update
[X] This change requires a documentation update
[ ] CI system update
[X] Test Coverage update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:

Java: v11
LPVS Release: v1.x.x

Checklist:

[x] My code follows the style guidelines of this project
[ ] My code meets the required code coverage for lines (90% and above)
[ ] My code meets the required code coverage for branches (80% and above)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Codecov Report
Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (19e32cc) 91.54% compared to head (cffccee) 89.56%.

Files
Patch %
Lines

...ain/java/com/lpvs/controller/GitHubController.java
0.00%
26 Missing :warning:

src/main/java/com/lpvs/util/LPVSWebhookUtil.java
40.00%
4 Missing and 5 partials :warning:

...a/com/lpvs/entity/enums/LPVSPullRequestAction.java
50.00%
1 Missing and 1 partial :warning:

.../main/java/com/lpvs/service/LPVSGitHubService.java
93.75%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #370      +/-   ##
============================================
- Coverage     91.54%   89.56%   -1.99%
+ Complexity      495      488       -7
============================================
  Files            48       48
  Lines          1703     1734      +31
  Branches        206      208       +2
============================================
- Hits           1559     1553       -6
- Misses           86      117      +31
- Partials         58       64       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[License Pre-Validation Service]  No license issue detected
Detected licenses:
File: src/test/java/com/lpvs/controller/GitHubControllerTest.java
License(s): MIT (permitted)
Component: LPVS (test/java/com/lpvs/controller/GitHubWebhooksControllerTest.java)
Matched Lines: 9-83
Snippet Match: 47%

JaCoCo Test Coverage Summary

Coverage: 92.893%
Branches: 80.272%

LGTM Is it possible to add the job for running the single scan along with Samsung/LPVS/{PR number} to the webhook file for ease of verification?

We already have a plan to implement GitHub action for LPVS: https://github.com/Samsung/LPVS/issues/319
Or did you mean something else?

LGTM Is it possible to add the job for running the single scan along with Samsung/LPVS/{PR number} to the webhook file for ease of verification?

We already have a plan to implement GitHub action for LPVS: #319 Or did you mean something else?

I want to see if the function works well through the workflow for every PR.

I want to see if the function works well through the workflow for every PR.

Current single scan API is implemented for "server mode" of LPVS operation. To check its functionality, we need to run LPVS server somewhere.

[License Pre-Validation Service]  No license issue detected
Detected licenses:
File: src/main/java/com/lpvs/service/LPVSQueueService.java
License(s): MIT (permitted)
Component: LPVS (main/java/com/lpvs/service/LPVSQueueService.java)
Matched Lines: 193-218
Snippet Match: 11%
File: src/test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java
License(s): MIT (permitted)
Component: LPVS (test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java)
Matched Lines: 2-51
Snippet Match: 96%

[License Pre-Validation Service] No license issue detected
Detected licenses:
File: src/main/java/com/lpvs/service/LPVSQueueService.java License(s): MIT (permitted) Component: LPVS (main/java/com/lpvs/service/LPVSQueueService.java) Matched Lines: 193-218 Snippet Match: 11%
File: src/test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java License(s): MIT (permitted) Component: LPVS (test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java) Matched Lines: 2-51 Snippet Match: 96%

Here is a result of single scan execution

[License Pre-Validation Service] No license issue detected
Detected licenses:
File: src/main/java/com/lpvs/service/LPVSQueueService.java License(s): MIT (permitted) Component: LPVS (main/java/com/lpvs/service/LPVSQueueService.java) Matched Lines: 193-218 Snippet Match: 11%
File: src/test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java License(s): MIT (permitted) Component: LPVS (test/java/com/lpvs/entity/enums/LPVSPullRequestActionTest.java) Matched Lines: 2-51 Snippet Match: 96%

Here is a result of single scan execution

Thanks for the hard work. It seems good to merge now!


SSL certificate issue trying tro run Cellpose from Anaconda prompt

Hi all, I have followed the instructions for Cellpose installation and appear to have the right dependencies and Python 3.8. Perhaps you can help.
Here is the error:
(base) C:\Users\matth>python -m cellpose
2021-10-12 13:15:19,742 [INFO] WRITING LOG OUTPUT TO C:\Users\matth.cellpose\run.log
2021-10-12 13:15:19,764 [INFO] Downloading: "https://www.cellpose.org/models/cyto_0" to C:\Users\matth.cellpose\models\cyto_0
Traceback (most recent call last):
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 1317, in do_open
encode_chunked=req.has_header('Transfer-encoding'))
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 1244, in request
self._send_request(method, url, body, headers, encode_chunked)
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 1290, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 1239, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 1026, in _send_output
self.send(msg)
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 966, in send
self.connect()
File "C:\Users\matth\Anaconda3\lib\http\client.py", line 1414, in connect
server_hostname=server_hostname)
File "C:\Users\matth\Anaconda3\lib\ssl.py", line 423, in wrap_socket
session=session
File "C:\Users\matth\Anaconda3\lib\ssl.py", line 870, in _create
self.do_handshake()
File "C:\Users\matth\Anaconda3\lib\ssl.py", line 1139, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1076)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\matth\Anaconda3\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\matth\Anaconda3\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Users\matth\Anaconda3\lib\site-packages\cellpose_main.py", line 8, in
from cellpose import utils, models, io
File "C:\Users\matth\Anaconda3\lib\site-packages\cellpose\models.py", line 58, in
download_model_weights()
File "C:\Users\matth\Anaconda3\lib\site-packages\cellpose\models.py", line 56, in download_model_weights
utils.download_url_to_file(url, cached_file, progress=True)
File "C:\Users\matth\Anaconda3\lib\site-packages\cellpose\utils.py", line 55, in download_url_to_file
u = urlopen(url)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 525, in open
response = self._open(req, data)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 543, in _open
'_open', req)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 503, in _call_chain
result = func(*args)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 1360, in https_open
context=self._context, check_hostname=self._check_hostname)
File "C:\Users\matth\Anaconda3\lib\urllib\request.py", line 1319, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1076)>
Thanks!
Matt

I'm also having the same issue (see below). have you figured out a solution to this issue yet?
(cellpose) C:\Users\User>python -m cellpose
2021-10-20 11:01:54,199 [INFO] WRITING LOG OUTPUT TO C:\Users\User.cellpose\run.log
2021-10-20 11:01:54,215 [INFO] Downloading: "https://www.cellpose.org/models/cyto_0" to C:\Users\User.cellpose\models\cyto_0
Traceback (most recent call last):
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 1354, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 1256, in request
self._send_request(method, url, body, headers, encode_chunked)
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 1302, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 1251, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 1011, in _send_output
self.send(msg)
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 951, in send
self.connect()
File "C:\Users\User\anaconda3\envs\cellpose\lib\http\client.py", line 1425, in connect
self.sock = self._context.wrap_socket(self.sock,
File "C:\Users\User\anaconda3\envs\cellpose\lib\ssl.py", line 500, in wrap_socket
return self.sslsocket_class._create(
File "C:\Users\User\anaconda3\envs\cellpose\lib\ssl.py", line 1040, in _create
self.do_handshake()
File "C:\Users\User\anaconda3\envs\cellpose\lib\ssl.py", line 1309, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\User\anaconda3\envs\cellpose\lib\runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Users\User\anaconda3\envs\cellpose\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Users\User\anaconda3\envs\cellpose\lib\site-packages\cellpose_main.py", line 8, in
from cellpose import utils, models, io
File "C:\Users\User\anaconda3\envs\cellpose\lib\site-packages\cellpose\models.py", line 58, in
download_model_weights()
File "C:\Users\User\anaconda3\envs\cellpose\lib\site-packages\cellpose\models.py", line 56, in download_model_weights
utils.download_url_to_file(url, cached_file, progress=True)
File "C:\Users\User\anaconda3\envs\cellpose\lib\site-packages\cellpose\utils.py", line 55, in download_url_to_file
u = urlopen(url)
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 525, in open
response = self._open(req, data)
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 542, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 502, in _call_chain
result = func(*args)
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 1397, in https_open
return self.do_open(http.client.HTTPSConnection, req,
File "C:\Users\User\anaconda3\envs\cellpose\lib\urllib\request.py", line 1357, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)>

Hi both! I have had the same problem, and I haven't found a way to actually fix the error, but to work around it I installed the models manually. You could probably download them one by one using the URLs (https://www.cellpose.org/models/cyto_0, https://www.cellpose.org/models/cyto_1 etc), but I got all the model files from a colleague who already had it installed and working on his computer. They need to go the .cellpose/models folder. I have put the ones I got from my colleague in a Google folder here.

Open file request.py
After import lines (after import warnings).
Add these line of code.
import ssl ssl._create_default_https_context = ssl._create_unverified_context

I can't reproduce this error, it may be Mac specific? But I've added these lines before the urlopen call, please let me know if it works. You can install the latest version of the code with the command below
pip install git+https://github.com/mouseland/cellpose.git

I can't reproduce this error, it may be Mac specific? But I've added these lines before the urlopen call, please let me know if it works. You can install the latest version of the code with the command below
pip install git+https://github.com/mouseland/cellpose.git

I was having this issue on Windows, but this worked! No longer having issues with SSL certification. Thank you so much!

Oh oops right I should have noticed you were on Windows, I just default to blaming Mac, glad it's working! going to close this issue

Hello there,
this manual command worked for me too (Windows here)
"pip install git+https://github.com/mouseland/cellpose.git"
Despite this, we have a conda env trying to install your package here via KNIME Component (https://kni.me/w/iLCTRXCPDg2EipZJ)
Unfortunately anaconda is not able to install automatically via
"pip install git+https://github.com/mouseland/cellpose.git"
it will install instead from pip via
"pip install cellpose"
We are going to fix this but in the meantime:
Can you please update the pip repository or fix whatever is wrong there?
That would would make the package easy to use for KNIME users.
Drag, drop, configure, execute: no need to do anything on pip or anaconda.

Thanks


Update ASP.NET Core Get Started for 3.0

Tested with 3.0.
Updated the SDK version for the prerequisite
Added a brief explanation for dotnet new command params.

Fixes #10479


feat: use url and navigator history for web deployment

Type: feat
Ionic Version: 2.x
Platform: desktop browser
Ionic2 is awesome and the ability to deploy it to a web-server to let users use it like a web app is super awesome !!!
But there is currently some troubles about web deployment :

no urls : when you refresh the app you loose your state, no deep-linking
no browser history : when you click back button, you quit the app

There is an other tricky thing with states & urls : for some state, they need to come with some "navigation history". For example, in a master/detail context, if you link to an item detail you need to have the back button to come back to the list view even if you don't came from it...
I think this is a pretty much necessary thing to deploy to web...
Is this feature planned ?

Yes it is on our roadmap to work with ng2's router. However, the router is still under development so we haven't hooked it up just yet. But absolutely, we plan on making it easy to also use a router. Thanks

Great !
It's not on the roadmap, do you have any estimate ?

Is there any ETA for this?
This is an extremely important feature for as since we are skipping Cordova and rolling with our own Webview based solution. Not having a working back button is a deal-breaker.
Or as a workaround, would there be a possibility to call the back function from a running eval() code on the page?


panda emitted package poses importing issues

Description

LSP throws importing error with emitPackage: true in panda.config.ts and CommonJS project. However, removing "type": "module" in node_modules/panda/package.json, which is set by default by the generator, does the trick. Better mark type: module as optional by adding a field in config when generating artifact package may address this issue.
Link to Reproduction
none
Steps to reproduce

Add "type": "CommonJS" to project's package.json
Set emitPackage to true in panda.config.ts
Do panda codegen
Wait for TypeScript to index newly generated package

This issue is rather odd (at least for me) so I can't create a reproduction project. Probably related to WebStorm or NextJS though.

JS Framework
React TS
Panda CSS Version
0.29.1
Browser
No response
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information
TypeScript version: 5.3.3
Here's my panda.config.ts, trimmed redundant fields btw:
  prefix: 'arctic',
  jsxFactory: 'arctic',
  logLevel: 'debug',
  optimize: false,
  strictTokens: true,
  strictPropertyValues: true,
  outExtension: 'js',
  forceConsistentTypeExtension: true,
  clean: true,
  emitPackage: true,
  watch: true,
  presets: [
    '@pandacss/preset-base'
  ],
  dependencies: ['src/lib/themes/panda/**.ts'],
  include: ['src/**/*.{ts,tsx}'],
  exclude: ['**/._*'],
  jsxFramework: 'react'

My tsconfig.json as well:
{
  "compilerOptions": {
    "target": "esnext",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext",
      "esnext.string"
    ],
    "skipLibCheck": true,
    "strict": false,
    "forceConsistentCasingInFileNames": true,
    "outDir": "dist",
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "noEmit": true,
    "baseUrl": "src",
    "paths": {
      "modals/*": [
        "components/modals/*"
      ],
      "hooks/*": [
        "lib/hooks/*"
      ],
      "components/*": [
        "components/*",
        "components/ui/*"
      ]
    },
    "allowJs": true,
    "incremental": true,
    "plugins": [
      {
        "name": "next"
      }
    ]
  },
  "include": [
    "next-env.d.ts",
    "avalanche.d.ts",
    "**/*.ts",
    "**/*.tsx",
    "**/*.mts"
  ],
  "exclude": [
    "public",
    "._*",
    "**/._*"
  ]
}

Using "type": "module" in the root project will break TypeScript path mapping, so manually removing "type": "module" in panda/package.json is the last resort. However, this hack is transient and will be overwritten when doing panda codegen again.

Hi @AlphaNecron,
You can solve this with the codegen:done hook we expose, so it's always correct.
import { defineConfig } from '@pandacss/dev'
import { writeFileSync } from 'fs'

export default defineConfig({
  // ...
  emitPackage: true,
  hooks: {
    'codegen:done'() {
      const pkgPath = './node_modules/styled-system/package.json'
      const pkgJson = require(pkgPath)
      delete pkgJson.type
      writeFileSync(pkgPath, JSON.stringify(pkgJson, null, 2), 'utf-8')
    },
  },
})

Thanks! Didn't even know this does exist.


mj-button

@SebastianStehle I'm happy to pick this component up.

I see that you also need values like getShorthandAttrValue ... I am working on this right now.

I see that you also need values like getShorthandAttrValue ... I am working on this right now.

Appreciate that, I've nearly got initial draft complete. Minus the attribute work which I'll update now.

@SebastianStehle Question, what's the best approach to getting the text content of the button? I tried using RenderChildren but it doesn't pick up Text nodes.

Yes, exactly.

I have pushed my changes with mj-images. Have forgotten to create a PR :(

I have pushed my changes with mj-images. Have forgotten to create a PR :(

No problem! It shouldn't affect anything!


Updated shared dirs in laravel 5 recipe

This fixes a bug when laravel tries to get the full path of these directories but returns false because they don't exist.
This is caused in some cases like the view config,  because realpath() is used.
If we don't create each shared folder during the deployment, realpath returns false because the dir doesn't exist and thus laravel tries to write to the root / directory.

Deployer version: master branch
PHP version: all php versions
Deployment target(s) OS: hmm, all

Hmm, does work with standard Laravel?

I think this fix is correct with Laravel 5.1 (LTS version).
Are you test for all laravel version? @dimsav
Ref #392

Nope I tested this only for laravel 5.1.

@dimsav
I think this recipe should support laravel 5.1.x (long term support version) and we should add a note to support other version. Can you create a pull request to deployphp/docs?

After doing a check, this change enables support for both laravel 5.0 and 5.1 versions.
I could help filling the documentation but this is another totally different task :)

Great!!! I think merge? But with docs it will be 200% more cooler!

Any ETA for this? Would be really helpful. Thanks :D

Great!!! I think merge? But with docs it will be 200% more cooler!

The docs is in another git repo.


Notebooks output not working in code spaces

Version: 1.56.0-insider
Commit: 58186680eb97fe979e1d986bcfa983ab0a6228e4
Date: 2021-04-06T10:32:31.104Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36 Edg/89.0.774.68
Relates to #120409
Steps to Reproduce:
1.In code space insider I open the notebook from here
2.run all cell
I get this

While the local insiders
with version
Version: 1.56.0-insider (user setup)
Commit: 845efe5d8e31079cc858131c95c36103d9439e74
Date: 2021-04-09T09:50:06.816Z
Electron: 11.4.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042
produces this

Does this issue occur when all extensions are disabled?: Yes/No

@rebornix I still face same issue with this notebook as I did for issue  #120409

I'll follow up with @joaomoreno on this.

I see the notification and then trust the notebook

Still I get this

Forcing reload the window and disabling cache fixed the issue


Usage of flatlist

Hey, is it poossible to use draggable flatlist for both the upper and lower section, as I am having a requirement to use draggable flatlists along with the option to move the list item to another flatlist

Hi @saikats5! Have you solved this problem?  need to implement the same functionality...


Add functional tests for gRIBI MPLS support.

 * (M) mpls/tests/compliance.go
 * (M) mpls/tests/compliance_test.go
  - Add testing for MPLS support for gRIBI. These tests operate only at
    the gRIBI layer and extend the set of compliance tests that are to
    be implemented. They do not use OTG or ATE.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2069

💛  - Coveralls


mk: Look at CUSTOBJ

CUSTOBJ as used in the mk system might require a cleanup. Look at its use, especially in relation to libec, and make its usage clear.
Once this is done, what we really need is a way to create object (for example, with fatobj.mk) and link them in the final binary.

Okay, looked at. It has been removed as a variable, it is defined now internally.


Adding Docker support for CaffeOnSpark

Hello,
Please test the docker file locally. Steps are documented in docker/README.md.
The docker image is for CPU version of CaffeOnSpark. I will work on a GPU version soon.
I checked the working twice on my local machine.
@anfeng , @mriduljain , Could you guys please let me know if this is okay ? It was a bit tricky getting Hadoop to work on Docker. I had to refer "https://hub.docker.com/r/sequenceiq/hadoop-docker/" to get it working finally.
Also, I found that PATH variables were not set using Dockerfile. I had to set them explicitly by calling a bootstrap.sh script when we start the container for the first time (No need to use it while attaching to an already existing container). bootstrap.sh also makes sure that hadoop dfs and yarn starts with the container.

CLA is valid!

Docker support is a much needed feature which I was looking fwd to. I will
test it early next week. Thanks!
On Thu, Dec 8, 2016 at 11:01 AM, Arun Das<EMAIL_ADDRESS>wrote:

Hello,
Please test the docker file locally. Steps are documented in
docker/README.md.
The docker image is for CPU version of CaffeOnSpark. I will work on a GPU
version soon.
I checked the working twice on my local machine.
@anfeng https://github.com/anfeng , @mriduljain
https://github.com/mriduljain , Could you guys please let me know if
this is okay ? It was a bit tricky getting Hadoop to work on Docker. I had
to refer "https://hub.docker.com/r/sequenceiq/hadoop-docker/" to get it
working finally.
Also, I found that PATH variables were not set using Dockerfile. I had to
set them explicitly by calling a bootstrap.sh script when we start the
container for the first time (No need to use it while attaching to an
already existing container). bootstrap.sh also makes sure that hadoop dfs
and yarn starts with the container.
You can view, comment on, or merge this pull request online at:
https://github.com/yahoo/CaffeOnSpark/pull/208
Commit Summary

Create Dockerfile
Create ssh_config
Rename docker/standalone/cpu/ssh_config to
docker/standalone/cpu/config/ssh_config
Create bootstrap.sh
Create README.md

File Changes

A docker/README.md
https://github.com/yahoo/CaffeOnSpark/pull/208/files#diff-0 (19)
A docker/standalone/cpu/Dockerfile
https://github.com/yahoo/CaffeOnSpark/pull/208/files#diff-1 (155)
A docker/standalone/cpu/config/bootstrap.sh
https://github.com/yahoo/CaffeOnSpark/pull/208/files#diff-2 (27)
A docker/standalone/cpu/config/ssh_config
https://github.com/yahoo/CaffeOnSpark/pull/208/files#diff-3 (5)

Patch Links:

https://github.com/yahoo/CaffeOnSpark/pull/208.patch
https://github.com/yahoo/CaffeOnSpark/pull/208.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yahoo/CaffeOnSpark/pull/208, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCTVQQULYumBzvWq6ELjJ5AdiIj24Blks5rGFP1gaJpZM4LIKoR
.

This is great idea!  Thanks for contributing this!

@javadba , were you able to get it working ? Could you please give it a try ?

@arundasan91 Can you expand this PR with GPU support?

@anfeng , sure can. I was waiting for a reply to make sure that this CPU version is enough. I will add a folder named gpu and a Dockerfile to support NVIDIA GPU's.
I have a doubt on installing the correct version of CUDA based on the GPU's architecture and cuda compute. Will refer caffe's own way of doing it.

@anfeng , Please see the changes. A GPU version of the Dockerfile is added. I tested the same in an NVIDIA K80 environment. Works great.
The only change to note here is to use nvidia-docker instead of docker for GPU builds. I will go ahead and update the README. Also, the host machine should have the proper NVIDIA drivers installed (not cuda).
Please let me know if there is any changes/additions required.

@arundasan91 Good work. Can you add copyright notices to all new source files?
Let's avoid mention your name in the files, to be consistent with all other source codes.
@javadba Have you tried out this PR?

@anfeng , Yes I will. I totally forgot to remove my name from the maintainer tag. Will do.

@anfeng , Just to make it clear, these are the copyright lines right ? Shall I copy the same into every file in the PR ?
# Copyright 2016 Yahoo Inc.
# Licensed under the terms of the Apache 2.0 license.
# Please see LICENSE file in the project root for terms.
#
# This file.......

Thanks.

@anfeng  I have not had a chance to try out the PR. Probably about two
weeks out due to some other fires. But definitely of interest - thanks.
2017-01-19 14:04 GMT-08:00 Arun Das<EMAIL_ADDRESS>
@anfeng https://github.com/anfeng , Just to make it clear, these are
the copyright lines right ? Shall I copy the same into every file in the PR
?
Copyright 2016 Yahoo Inc.
Licensed under the terms of the Apache 2.0 license.
Please see LICENSE file in the project root for terms.

This file.......
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yahoo/CaffeOnSpark/pull/208#issuecomment-273913312,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZEkdyxI6C_-Y0iSzQxv5AEYjvwl279ks5rT933gaJpZM4LIKoR
.

@arundasan91 Yes, for all new files.

@anfeng , I added the copyright to every file.
I added them to the config/ssh_config file too. This file will be copied to the containers' .ssh/config. Since # will be treated as comments, this should be okay.
Could you please take a look at the files and let me know.
Thanks.

+1 @arundasan91 Excellent work.


Inverse for .throw method

I found .throw(reason) is a shorthand for
.then(function() {
   throw reason;
});

I was looking for something like .ignoreError(value) (needs a better name) which would be shorthand for:
.catch(function() {
   return value;
});

So with this you could basically 'invert' the logic
somePromise
  .ignoreError('use this value instead')
  .throw(new Error('the original promise was expected to error'))

Does this pattern already exist? I might be looking over it in the docs

or even .ignoreError(Type, value) for
.catch(Type, function() {
   return value;
});

To be fair - this is something I've had to do a lot, and it'd also be nice for people who don't want possibly unhandled rejections.
I wonder if we can come up with a shorter more concise name.

@benjamingr Yes please find a better name :)

There is .thenReturn, .thenThrow, I propose .catchReturn and .catchThrow for completeness :)

@spion but the aliases are so useful as in .return and in .throw
On Thu, Feb 5, 2015 at 12:59 PM, Gorgi Kosev<EMAIL_ADDRESS>wrote:

There is .thenReturn, .thenThrow, I propose .catchReturn and .catchThrow
for completeness :)
—
Reply to this email directly or view it on GitHub
https://github.com/petkaantonov/bluebird/issues/483#issuecomment-73028844
.

I just realized this wouldn't work, the .throw( would pick up the resolved promise from .ignoreError(
somePromise
  .ignoreError('use this value instead')
  .throw(new Error('the original promise was expected to error'))

If this inversion is a use case maybe there can be an .invert method too?

@petkaantonov  name?

probably gonna be catchThrow and catchReturn, with same signature as catch (accepts predicates)

Would this ease something like:
.catch(predicate, function( e ){
  doLogging();
  throw e;
});

Or would that require another method, something like catchTap?

@tjconcept not going to happen: https://github.com/petkaantonov/bluebird/issues/517

@Janpot well, logging was just an easy example, in my most recent case I'm using it to augment all types of a specific error with more context.

@tjconcept augmenting seems like a valid use case actually

@petkaantonov so is logging (although augmenting is more common for sure) but I wonder if it's worth the extra sugar this requires in the library.

Fixed in 3.0 release


2.2.6 (124) changes Bring-to-Front behavior in way that tempts data loss

Previously, triggering the Bring-to-Front shortcut (correctly) focused the search field. This meant you could trigger nvALT and begin typing your search immediately.
The latest release instead keeps focus inside a note, maintaining whatever text selection was last active. This means when you trigger bring-to-front and start typing your search, you instead type over the content of a note.

I'm seeing this as well and think it's worth fixing. I'll look into it.
-Brett
On 3 Nov 2016, at 12:29, David Gouch wrote:

Previously, triggering the Bring-to-Front shortcut (correctly) focused
the search field. This meant you could trigger nvALT and begin typing
your search immediately.
The latest release instead keeps focus inside a note, maintaining
whatever text selection was last active. This means when you trigger
bring-to-front and start typing your search, you instead type over the
content of your last note.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ttscoff/nv/issues/411

This change is driving me batty.  Reverting to the old behavior would be greatly appreciated.

Such a relief I'm not the only one. Accidentally adding bits of text everywhere and deleting sections of selected text from previous copy/paste.  Def eager for fix or toggle to switch behavior.

Where can I download a previous version of nvALT without this bug?

I reverted to a backup.  This issue makes the current version a non-starter.  I'm frankly surprised that more people aren't commenting here -- the whole point of nvALT in my workflow is to save time by quickly jumping to the appropriate note using bring-to-front then search (keyboard only).  Using the newest I'm forced to use the mouse to reselect the search bar each and every time.

Version 2.2b106 http://abyss.designheresy.com/nvaltb/nvalt2.2b106.zip
The bug you're referring to is already fixed and will be out in an
update today or tomorrow.
On 7 Nov 2016, at 16:16, Robert Barat wrote:

Where can I download a previous version of nvALT without this bug?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ttscoff/nv/issues/411#issuecomment-258980763

Or you can just hit ⌘L.
On 8 Nov 2016, at 13:04, Zortrium wrote:

I reverted to a backup.  This issue makes the current version a
non-starter.  I'm frankly surprised that more people aren't commenting
here -- the whole point of nvALT in my workflow is to save time by
quickly jumping to the appropriate note using bring-to-front then
search (keyboard only).  Using the newest I'm forced to use the mouse
to reselect the search bar each and every time.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/ttscoff/nv/issues/411#issuecomment-259228199

Never bothered to learn that shortcut.  Thanks!

Thank you @ttscoff


Disable text antialiasing

What is your question?
How can i make psych engine texts look smoother? With source code

text.antialiasing = false;

text.antialiasing = false;

Thank you


Home custom layout

Adds support for abHomeLayout stylebale.

The support for the styleable is declared in theming http://actionbarsherlock.com/theming.html docs, but looks like it was never implemented.

Landed in commit 6f43855a387059171c4a23fdec8138b1ebdc663f.

It's actually in 59d837334a082f90e165beccf77778ad137351da. Stupid merging script automatically applied it to master...


Requesting token on every API call.

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description

MSAL requests access token on every backend API call. I have seen similar topics but I couldn't find my answer. I think requesting the token on every API call is not necessary. I assume there is a way to cache it and only request when needed.
I have also checked that the access token is always changing.

Maybe, I am missing some settings part. I hope you guys can help me with this situation.
export const b2cPolicies = {
    names: {
        signUpSignIn: 'B2C_1_SIGN-UP-SIGN-UP-IN-POLICY',
        resetPassword: 'B2C_1_PASSWORD-RESET-POLICY',
        forgotPassword:'B2C_1_PASSWORD-RESET-POLICY'
    },
    authorities: {
        signUpSignIn: {
            authority: 'https://xxx/B2C_1_SIGN-UP-SIGN-UP-IN-POLICY'
        },
        resetPassword: {
            authority: 'https://xxx/B2C_1_PASSWORD-RESET-POLICY'
        },
        forgotPassword: {
            authority: 'https://xxx/B2C_1_PASSWORD-RESET-POLICY'
        }
    },
    authorityDomain: "xxx"
};

export const apiConfig: { scopes: string[]; uri: string } = {
    scopes: ['https://xxx/Scope.Read'],
    uri: environment.baseApiUrl + '/api/'
};

export function loggerCallback(logLevel: LogLevel, message: string) {
    console.log(message);
}

export function MSALInstanceFactory(): IPublicClientApplication {
    return new PublicClientApplication({
        auth: {
            clientId: 'xxx',
            authority: b2cPolicies.authorities.signUpSignIn.authority,
            redirectUri: 'http://localhost:4200',
            postLogoutRedirectUri: 'http://localhost:4200',
            knownAuthorities: [b2cPolicies.authorityDomain]
        },
        cache: {
            cacheLocation: BrowserCacheLocation.LocalStorage,
            storeAuthStateInCookie: isIE,
        },
        system: {
            loggerOptions: {
                loggerCallback,
                logLevel: LogLevel.Info,
                piiLoggingEnabled: false
            }
        }
    });
}

Source

[ ] Internal (Microsoft)
[X] Customer request

I had the same issue. In my case it was with msal version 2.x.
The problem was the scope. The answer had a different scope than that which had been requested.
In this case, no token is found in the cache for the requested scope and a new token is requested.
So check if the response contains a token for your requested scope.

@cagricaymaz Can you share your usage where you make your token and API call? acquireTokenSilent does lookup tokens in the cache first before making a network request. Enabling verbose logs would also be helpful here. Instructions for enabling logs

Hi, @devInterests
My token response's scope is the same as the requested scope.

Hi @tnorling
Seems like in my case, I always have "msal:acquireTokenFromNetworkStart" in the logs. I actually followed the same steps in angular_v11.

@cagricaymaz  As far as I understood, your scope in the example is ''https://xxx/Scope.Read''. But in the response the scope is  "https://..../466". So there is a token in the cache for "https://..../466" but not for ''https://xxx/Scope.Read" scope. But I am not sure about that.
However, what I did was debugging through  msal js lib. I started by acquireTokenSilent call and get inside the call stack. There I saw what was in the cache and what I was requesting.

I have debugged all steps in msal-angular and found my solution I think. There is a system.Options.tokenRenewalOffsetSeconds set for 300seconds.
Where does it come from? Can I change it to 60 seconds?
In my development environment, the access tokens expire in 300 seconds. So in my case, it is always expired. Changed it to 15 minutes and it is working as expected.
...
else if (!cachedAccessToken || TimeUtils.isTokenExpired(cachedAccessToken.expiresOn,this.config.systemOptions.tokenRenewalOffsetSeconds)) {
            // Must refresh due to expired or non-existent access_token
            return true;
        }
...

I have fixed the issue that I am having so I can close the topic. Thank you.


coala

Hey,
we're currently working on a similar project to yours which however aims not only to wrap around existing linters but also to enable people to create analysis routines. To kickstart our project we're looking into wrapping linters similar to what you do. We have worked very hard in the past years to create a very decent user interaction (editor plugins, interactive CLI, JSON, ...) so it can be used well for production and research usecases and I think it's worth it. Right now I have a prototype of a service ready to test on gitmate.com that uses coala to automatically review GitHub Pull Requests.
Would you be interested in joining forces with us? I think we both could win from that. Let me know if you need anything, you can find some information and links on coala-analyzer.org and I'm totally available for any questions you might have.

see also https://github.com/coala-analyzer/coala/issues/897

Hi @sils1297, feel free to reach out to my email. Could you tell me more about what kind of plans you have, advantages of having python bears vs executable bears, how do you plan to normalize the results of several bears/linters (for example many linters already check the spacing but you also have a spacing bear), plans of gitmate (it seems to be like a paid service you want to launch), etc.

sure, just give me your email, write one to me at<EMAIL_ADDRESS>or join https://gitter.im/coala-analyzer/coala


reid models

Congratulations and thanks for your excellent work!
Could you make it clear which 3 reid models you use in the https://drive.google.com/drive/folders/1aCQmTbYQE-mq-07q86NIMLLZRc82mc5t ?
There are multiple models named resnet101_ibn_a_2.pth and no model named resnet101_ibn_a_3.pth.

You can download three models here:
https://drive.google.com/drive/folders/1DXKpvDigCOXqoTiRObI--klRCuVQSsFM


Collectd

Is this WIP, or ready for merge?

This is WIP right now.  Seems to be an odd check about the time and based on some math it shouldn't be able to exceed that but want to be sure.
Fundamentally it comes down to packet.TimeHR is a unit.  However, the first thing we do is divide it by 1 billion and multiplying by 1 million ((uint64 >> 30) * 1000 * 1000)
Here is a playground sample that illustrates that we can never be above an int64 after our calculation, and therefore the check seems completely moot.
http://play.golang.org/p/0NT1XWlVDT

Mostly minor stuff. Otherwise lgtm.

Is there any chance that ListenAndServe will be called more than once to collect data on multiple ports?

My understanding is that we will not fire up more than one end point for collectd, therefore ListenAndServer should only ever be called once.  If that changes in the future this code will need to be revisited.

Thanks for the all the work, @corylanou -- definitely lots learned here, we can apply it further and in more of upcoming code.
+1 for merging now.

@corylanou Two minor nits. Otherwise lgtm. :ship:


Suggestion:Add a sample project ,please.

It's not easy for everyone to understand how to use these controls.Add a sample project maybe a good solution.

All controls should be included in the examples: https://github.com/objorke/PropertyTools/tree/develop/Source/Examples


Generate dashboard for docstring errors

We've implemented a notebook that preprocess the data of docstrings known errors, and plots how many we've got: https://github.com/python-sprints/pandas-mentoring/blob/master/notebooks/docstring_error_frequency.ipynb
This is very useful, but I think it'd be even cooler if we convert that notebook to an interactive dashboard that let us easily identify what docstrings need to be fixed.
I'm thinking for example on have ipywidgets with a dropdown with the list of errors, with a list of pandas components (e.g. Series, DataFrame, others...), and playing with those widgets, be able to select specific docstrings, and be able to see the list of errors to fix, the source code of the docstring (the markdown version) and even a rendered html version.
Not sure how difficult that could be, but I think jupyter has lots of cool stuff for those things nowadays, so I think is doable to get something quite cool.
Much better to do this iteratively, adding one or few things at a time (and may be create other tickets and use this one as the "parent")?

This is a cool idea. I’ll like to give it a shot

I would like to join @sparalic. I will learn about the topic in the next days and discuss my plans with you @sparalic @datapythonista

@dujm we can absolutely team up on this, I’ve done most of my dashboards in R. So it’ll be nice to learn how to do it with Dash or plain old widgets in Jupyter.

if you implement the code as a jupyter notebook, you can use voila to convert it to a dashboard automatically: https://github.com/QuantStack/voila

Just found out there is a gallery of voila dashboards for inspiration: https://voila-gallery.org/services/gallery/

@datapythonista and @dujm  I was a bit busy last week. But I used the examples Marc shared to create the first filter. This first draft show all of the errors associated with the selected pandas class. The next step is to add a dropdown for the error codes which generates a list of the actual errors. I am thinking of using the table generated from this example for the output of the error code dropdown:
https://voila-gallery.org/user/seidlr-voila-in--football-pitch-4g8y2eez/voila/render/Interactive-Football-Pitch.ipynb?token=JD5RnWKTQeeeOo9lKi1iow
@datapythonista and @dujm let me know what you think?

@sparalic Nice work! I think the next step(s) you planned also make sense.
I really like the example you suggested(Interactive plot + sortable table).
I'm just not sure whether it's easy to find a code using a dropdown of error codes (maybe sorting codes alphabetically?). However, since we are learning, it's always nice to try different options.

Thans @sparalic, that looks great.
For the error codes, probably the best is import scripts/validate_docstrings.py and get the list from the constant. In a recent version of Python (>= 3.6) you'll get the dictionary sorted. Alphabetical order also makes sense, but that order starts by the global errors, and then lists them based on the order of the sections in the docstrings. But whatever is the order, getting the data from that file instead of hardcoding the values will  keep things updated if we add new errors to the validation (which can happen).
Having a table like in the football example sounds great. Not sure if once an element in the table is clicked the details of the docstring can be shown, but that would be amazing.
@sparalic feel free to open a PR with whatever you have. Reviewing notebooks it's not great, since it's json, but I'm happy to get whatever you submit merged, so we can see the notebook and play with it.
Thanks for the work on this, will be very useful.

Hi @sparalic, thanks for the update :)  But no stress if you are busy. Because I had time and was playing with the widgets. I should be able to send a PR today. Look forward to discussing with you and getting your input later.

@datapythonista I will continue to play around with what I’ve done. Do you still want me to create a PR for the work I did on this?

Sure. It may make sense later to get into a single dashboard the best of all, but not a problem to have more than a dashboard.

@datapythonista sounds great!! We can both experiment and learn and create a single dashboard that merges elements from both of our experiments.

Here is the binder link of my notebook. You could run the interactive widgets.

@dujm @sparalic Can we close this issue now?

@sara-02 Hey! I closed it. Thanks for reminding.


fix: throw self-defined exception occur error #8

Describe what this PR does / why we need it
Fix bug
Does this pull request fix one issue?
Yes

Fixes #8
Describe how you did it
Describe how to verify it
Special notes for reviews

@Vascal Thank you for fixing the bug. Please check the git email config you used when submitting.

@Vascal The code you submitted is OK. But the name and email may be wrong you used when submitting, please check it. Thanks.

@Vascal The code you submitted is OK. But the name and email may be wrong you used when submitting, please check it. Thanks.

@xcaspar I have updated the email config, please try again.


world spawn

Information

Server version: minecraft 1.16.4

Full output of /mv version -p:

Server log:

Help request
Problem
Don't know how to set a new world as the servers spawn
What I have tried
deleting the spawn world but i said it can't be deleted
Screenshots

if its first spawn world, i.e. when player first join the server only, then just set the firstspawnworld in mv config.yml. If you are referring to always spawning on the same location on join, get a hub plugin or try our test build on join location #2460


triton depends on numpy, but numpy is not specified in dependent packages

I did a fresh new install from source, and import triton raises an error complaining that numpy is not installed. The code in question is:
https://github.com/openai/triton/blob/9a38395c82bc2b86b5dbbc67ba5a1f5f2dde53e1/python/triton/runtime/interpreter.py#L3
Maybe we should move the numpy dependency from tests to install_requires?
https://github.com/openai/triton/blob/9a38395c82bc2b86b5dbbc67ba5a1f5f2dde53e1/python/setup.py#L431-L438

Maybe we should move the numpy dependency from tests to install_requires?

Go for it!

Patch sent in https://github.com/openai/triton/pull/2902 . @jlebar please take the review if you can!

It is only for the interpreter (which is a debug tool) right? do we really want to make the whole triton dependent on numpy?

We can also avoid importing the interpreter if you like. That would require to move the line below to where it is used.
https://github.com/openai/triton/blob/9a38395c82bc2b86b5dbbc67ba5a1f5f2dde53e1/python/triton/runtime/jit.py#L10

ah I see, I had missed that part. Ok sounds needed indeed

ah yeah that's a good idea!


#6: Unnecessary Function Arguments Rule

Initial work on #6: Unnecessary Function Arguments Rule.
This is the naïve implementation of the rule. The ticket should not be closed since there are many more things to consider, like checking for @impl … to skip behaviour callbacks… and other stuff.

(Oh, and I re-ran both CI jobs (push & pr) after Brud's changes got merged, to make sure the API change it made to how ASTs come in didn't break anything)


Validator fails to load HCPCS folder

I have our code_repository folder setup with the structure described in the documentation.  After manually creating a couple of the files, most of it loads correctly... with these exceptions:
If I include the HCPCS folder, the loader fails with:
Failed to load configured vocabulary directory.
org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'HCPCS' is defined
So, either the bean is missing, or I have the wrong name for the folder... which is it?
Also, the Code Systems spreadsheet says that the ICD9CM_DX folder should contain a fixed-length file.  When I tried that, it failed with:
09:49:47,520 INFO  [VocabularyLoadRunner:44] Loading files in : ICD9CM_DX...
09:49:47,522 ERROR [VocabularyLoadRunner:107] Failed to load configured vocabulary directory.
java.lang.StringIndexOutOfBoundsException: String index out of range: 5
I opened the spreadsheet version of the file and saved it as tab-delimited and it loaded correctly.
Thanks

Thanks.
I will make a ticket for this and try to ensure it doesn't take too long to address.
Once the issue is resolved, if there are errors in the documentation, we will update them.

I know this is an old ticket, but after review, there is no loader in the current codebase to load this code system. The team will review this gap and determine if it's a feature to be implemented.

The team has determined that this feature is not critical for certification and will not be implemented at this time.


Circle trimming from top on Tablet

The circle indicator is working very fine upto 6 inches phones. But on tablet, the "Selected" white circle is slightly trimming from the upper edge making it flat from the top.
Any solution ?

Removing the following "rotation" animation from Animator.xml resolved the circle trimming.

Set  layout_height value larger


Add possibility to define weight for nodes in load balancer logic

In current implementation all backends are considered to be equal, and balanser will try to distribute load equally across all of them.
In real production environment it could be possible that some nodes may have to have more resources than other. For such cases we should be able to provide possibility define node weight.
load should work as follows, if node weight is 2 it should be handling twice more request to compare to node with weight 1.

this probably better to define through policy, rather try to fit into current algorithm.

@ksysoev we can close this


Exchange Listing Request

name: Anycoin Direct
url: https://anycoindirect.eu/buy/monero

Added in #856
+merchant
+in progress

+resolved


Cannot convert Polymer 2 starter-kit example successfully

I tried to convert the Polymer 2 stater-kit example to Polymer 3 and it fails to load in the browser. I'm using
polymer --version: 1.7.7
node --version: v8.11.3
npm --version: 6.3.0
bower --version: 1.8.4
Ubuntu 16.04.1
I followed these instructions to create the Polymer 2 start-kit app: https://www.polymer-project.org/2.0/start/toolbox/set-up
mkdir polymer2-3-upgrade-app
cd polymer2-3-upgrade-app
polymer init

I chose polymer-2-starter-kit
When I ran: polymer serve, it worked fine. I was up and running with Polymer 2 successfully.
Then I followed this guide: https://www.polymer-project.org/3.0/docs/upgrade to convert to Polymer 3:
modulizer --out . --npm-version 1.0.0
(Omitted --import-style name as recommended for application projects.)
[1/2] 🌀  Converting Package...
Out directory: /home/dsyrstad/IdeaProjects/polymer2-3-upgrade-app
Failed to read entrypoints of package 'shadycss' because the package does not have a 'bower.json' file.
polymer-starter-kit: Did not find an HTML main in bower.json. A main was not added to package.json, so this package will not be directly importable by name. Manually update main in your bower.json or package.json to fix.
[2/2] 🎉  Conversion Complete!

Then I ran:
npm install
Which told me:
npm WARN deprecated<EMAIL_ADDRESS>This package is unmaintained. Use @sinonjs/formatio instead
npm WARN<EMAIL_ADDRESS>No repository field.

added 65 packages from 482 contributors and audited 575 packages in 4.091s
found 4 vulnerabilities (3 low, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

It appeared the conversion basically worked, so I ran: polymer serve
I opened http://<IP_ADDRESS>:8081 in Chrome.
 None of the node_modules loaded, probably because of imports like this:
import { PolymerElement } from<EMAIL_ADDRESS>
And this line in index.html:
<script<EMAIL_ADDRESS>
Also tried:
polymer serve --npm
polymer serve --npm --module-resolution="node"
polymer serve --npm --module-resolution="none"
polymer serve --module-resolution="none"

All give the same result.
Help? I also commented on issue #459. I cannot get my current Polymer 2 app to convert because of spread operators.

Is there any solution?


GDScript does not properly support string formatting RIDs

Tested versions
v4.2.2.stable.official [15073afe3]
v4.3.dev5.official [89f70e98d]
v4.3.dev.custom_build [2543d192c]
System information
Godot v4.3.dev (2543d192c) - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 2070 SUPER (NVIDIA; <IP_ADDRESS>23) - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)
Issue description
RID is a built-in type, and it's expected that the two usages below has the same effect:
str(RID())
"%s" % RID()

However, they do not. While str() works fine, from what I've gathered, string formatting RIDs is either a parse error, a runtime error or even a crash. The crash can be triggered on latest master (as of writing).
Steps to reproduce

Create a new project.
Make a new scene with Node2D root node.
Attach the following script and run the scene.

extends Node2D

func _ready():
	print_debug(RID())
	print_debug(get_rid())
	print_debug(str(RID()))
	print_debug(str(get_rid()))

	print_debug("RID()=%s" % [RID()])
	print_debug("RID()=%s" % [get_rid()])
	print_debug("RID()=%s" % [get_rid_typed()])

	# v4.2.2.stable.official [15073afe3]: (parse) Invalid operands to operator %, String and RID.
	# v4.3.dev5.official [89f70e98d]: (parse) Invalid operands to operator %, String and RID.
	# v4.3.dev.custom_build [2543d192c]: (parse) Invalid operands to operator %, String and RID.
	# print_debug("RID()=%s" % RID())

	# v4.2.2.stable.official [15073afe3]: (parse) Invalid operands to operator %, String and RID.
	# v4.3.dev5.official [89f70e98d]: (parse) Invalid operands "String" and "RID" for "%" operator.
	# v4.3.dev.custom_build [2543d192c]: (runtime) CRASH
	print_debug("RID()=%s" % get_rid_typed())

	# v4.2.2.stable.official [15073afe3]: (runtime) Invalid operands 'String' and 'RID' in operator '%'.
	# v4.3.dev5.official [89f70e98d]: (runtime) Invalid operands 'String' and 'RID' in operator '%'.
	# v4.3.dev.custom_build [2543d192c]: (runtime) Invalid operands 'String' and 'RID' in operator '%'.
	# print_debug("RID()=%s" % get_rid())

func get_rid_typed() -> RID:
	return RID()

func get_rid():
	return RID()

Minimal reproduction project (MRP)
RID Crash.zip
It also contains a extends MainLoop version of the script above to be run in command line, triggering the same errors and crash.
Command line arguments I used:
godot --headless --quit --script main_standalone.gd

It seems easy to fix; just add the missing register_string_modulo_op(::RID, Variant::RID); to Variant::_register_variant_operators(). I tested locally and it seems to work. No idea why it can crash where it wouldn't before though.


NestedStream: Implement Length, Position

I implemented the documented behavior for Seek: throw if seeking before the start of the stream, but accept seeking beyond the end of the stream.
remainingBytes will be negative when beyond the end of the stream, and the various Read overloads will detect that behavior and just return 0.
I think we covered most cases by now.


Prevent panics when a network does not have IPAMs or subnets

Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>

@kevpar @dcantah fyi

@nagiesek not sure if you're the right person to ping here, but these are the changes we talked about recently if you could take a look :)

LGTM


Losing BT connectivity...but maybe not?

So my watchface is currently showing that it has no BT connectivity, and hasn't for the last 13 minutes.  However, in that time I've received several email and FB notifications, telling me that there is BT connectivity.  Are notifications sent differently than how the Urchin communicates with the phone?

Incidentally, it's happening every 5 mins.  And when  it does, while the other notifications come in, my Urchin doesn't update.  It's giving me anxiety, yo.  =)

Thanks for the report. I suspect this is the same connection issue  mentioned in #21. Are you on iPhone or Android?
The "no BT" icon really means "the phone has not sent back a response to a data request since N minutes ago". I've experienced this intermittently, as well, but only when showing certain data.
My best hypothesis is that the JS interpreter in the iOS Pebble app locks up when processing a lot of data (a memory leak?), so it stops responding to requests. Here are some things I've observed:

It occurs when showing things which use a lot of data (e.g. OpenAPS status line + basal history), but never
Switching to another app and back on the Pebble (which re-initializes the JS) fixes it briefly
Opening or restarting the Pebble app on the phone fixes it for much longer
When I've dumped logs from the phone immediately after noticing the issue (Support > Contact Support > Other > Send email to self), there is no record of the Urchin JS doing anything recently
I've not heard reports of this issue on Android (suggesting it's particular to the JS interpreter on iOS)

Here's my first attempt at a fix:
TODO: increase max app message size, change map/filter magic to for loops, reduce data cached
Can you give that a try? And if you see a suspicious "no BT" indicator, would you mind dumping logs from the Pebble app and emailing them to me?
@StephenBrown2: does this description line up with the connection trouble you mentioned in #21?
@jasoncalabrese: have you ever seen "no BT" while showing OpenAPS status + basals on Android?
Thanks in advance for the help!

Heh, oops, fat-fingered the enter button there. I'm behind the Great Firewall with flaky VPN, so can't verify my fix, nor push to GitHub apparently. I'll be back on Monday and will put up the PR then. Meanwhile would appreciate help diagnosing if you see it again.

I don't have many connection issues with Android, but my wife uses iOS and almost always has the no BT icon.  She also leaves the phone in 1 spot at home so it goes out of range more than mine.  I know the old NS watchfaces had similar issues, but they might try harder to recover.

Right after I posted this, I kinda sorta got fed up and deleted everything Pebble from my phone, and re-set it up from scratch.  That's improved things quite a bit.  Last night I noticed it happened once, but all I did was open the Pebble app, then open the Urchin settings and hit save.  That worked well.
But if it happens often, I'll definitely dump logs and get 'em to you.

Happens for me on Android when the phone is in range but uploader is not updating NS site.

I have the same problem on my android 6.0.1 phone, too.
I think this happens only since one of the last pebble updates, at least I haven't noticed before.
Is there anything I can provide to find the cause of this?

@tanja3981 Have you tried setting it up from scratch?  After the last Pebble update, I did that and it fixed those issues right up.

@spazholio Unfortunately, I did, as I got a new phone a week ago. However, the problem persists. :-(

@mddub Yes, it sounds like it could be what you hypothesize... a memory leak makes sense that would be refreshed on relaunch of the pebble app.

For those still experiencing this issue (which includes me 1-2x/week): Thanks for your patience. In #27, I've added a bunch of small fixes and a big improvement in how loading/error states are displayed. Even if it doesn't fix the issue, it will certainly give more feedback on what's going wrong.
Give the latest release a try and let me know if you see an improvement, or what kind of error messages you see on the watch.
@tanja3981: How exactly does the error manifest for you? Which data are you showing in the status bar? Are you showing bolus/basal history in the graph?

@mddub I'm using 'none' statusbar and showing no bolus nor basal history.
Whenever I'm getting the error, I got a strikethrough bluetooth icon. I just downloaded the new version. When it occurs next I can make a photo of the error in the watch. Shall I collect something else, too?

Only used the latest version briefly today and it can still lose connection (good to see it trying though cheers!). What may be happening is that I go out of range of the phone for a fair while and after a time pebble on the phone kills the phone handler part of Urchin and then when I finally get back in range it just goes into a trying to connect/timeout loop but nothing is listening and the only way to get it going again is to hop in/out of menus on the watch.

After two days watching I can confirm @Pogman threory: The bluetooth connection is missing when leaving the range of the phone (even for a very short) period of time and not reconnecting without interventation.
I did not have any connection problems as long as staying in the phones range.

Thanks for your help with this info, @Pogman and @tanja3981. I just pushed another attempt at a fix: #29.

Please give the latest release a try. If it doesn't work, this would be super helpful:

Next time you notice the problem, would you mind sending me the diagnostic logs from the Pebble app?

In the Pebble app, go to "Support", then "Contact support", then "Other"
Type a message to let me know what problem you were seeing on the watch
When the email window appears, change the recipient from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>

Would also love to know what the watch is showing in the top-left of the graph when it can't connect. Is it always No BT?

Just installed your latest build on my watch and will update our other pebbles soon.

Thanks a lot for your effort!
I just installed the new version and will let you know what I experience!

Sent you that support mail as suggested, I hope it helps!

No BT icon --> Refresh icon --> "timed out" --> loop to no BT with minutes since last connect.
Sent you logs.

A huge improve on my wife's iPhone, since she leaves the phone in place while at home it goes in and out of range a lot, but so far every time we check the watchface has current data.

Thank you so much for these logs @tanja3981 and @Pogman. Super helpful. They both show something interesting which I may need to report to Pebble, since it occurs at a level my app can't fix.
For now, though, there is one last thing I'd like to try. Please install the latest release. To be extra sure you get the latest, rather than your browser's cached version, download directly from here:
https://github.com/mddub/urchin-cgm/raw/d47d82/release/urchin-cgm.pbw
Let me know what you see with this version. If the problem persists and you can send me one more set of logs when it happens, I've got solid data to send to Pebble so they can help debug the issue.
(Details: After Bluetooth successfully reconnects, the watch and phone exchange several messages. One message sent by the watch is to endpoint 49, which is reserved for telling the phone app about "app launch" events. But both your logs show the phone receiving this message and reporting that this endpoint is not registered. Some digging around suggests that this endpoint was deprecated between SDK 2 and 3, but since my last change was to upgrade from SDK 3.7 to 3.14, the watchface shouldn't be sending it. Or if it should, maybe the Pebble Android app shouldn't be dropping it. My own logs show the Pebble iOS app handling it without error. I'm not certain this is the cause of the issue - the problem may be somewhere else, which #31 will clarify.)

@jasoncalabrese that's great to hear! Thanks for the confirmation for iOS.

Cool and thanks for sharing your findings (I'm new to Pebble and Android and would like to mess with dev on both at some point).
Installed the version here and will keep an eye on it.

Sent logs from latest version

It isn't just Urchin on the pebble classic at least.  All the CGM watch faces seem to have BT connectivity issues on the latest Pebble OS.  I downgraded a few days back to 2.9.1 and have not had a single issue since.  Had to go back a few patches in Urchin but it does work

I don't have this problem with other faces. Spark and xDrip face are working fine for me.
However, if possible, I'd prefer urchin as it's much nicer.

forgive my newbishness.... How do I get/use the latest urchin-cgm release?
Any "easy" way?
On Tue, Aug 9, 2016 at 12:37 PM, Tanja<EMAIL_ADDRESS>wrote:

I don't have this problem with other faces. Spark and xDrip face are
working fine for me.
However, if possible, I'd prefer urchin as it's much nicer.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mddub/urchin-cgm/issues/22#issuecomment-238630123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APzPDjP01LvITBThfc07Qjx954FaYCW8ks5qeLrQgaJpZM4JINKJ
.

--
Fight back spam! Download the Blue Frog.
http://www.bluesecurity.com/register/s?user=bWFyazE4MDk%3D

@Thasgolas In the Pebble app on your phone go to settings and enable developer mode. You can then install Urchin via a web browser on your phone using the .pbw file a few posts up in this thread.

Can folks still experiencing this issue share the error message which appears briefly once per minute in the top-left of the graph, and under what circumstances it happens (for example, only when the watch goes out of range of the phone)?
Turns out most of my theories have been wrong (though upgrading to the latest SDK does seem to have fixed a lot of connection issues on iPhone). Based on the response from Pebble, there is an issue with the current firmware, which can bite you when Bluetooth disconnects and reconnects, or if your Bluetooth connection is flaky:
https://forums.pebble.com/t/how-to-recover-from-app-msg-busy-after-bluetooth-reconnects/22948
https://forums.pebble.com/t/app-msg-send-timeout-should-happen-but-never-does/22524
It seems that when there is Bluetooth flakiness, the latest Pebble firmware can cause the AppMessage system to get stuck in an unrecoverable state. For context: the Urchin watchface sends a message to the phone whenever it wants new data, but in this case, those messages are unable to be sent (the phone gets stuck waiting for a (n)ack from the phone). I'm not surprised to hear the xDrip watchface doesn't have this issue, since the xDrip Android app sends data straight to the watch whenever it has new a reading. (Likewise, pancreabble on an OpenAPS rig should work fine.) It's also consistent with reports that closing and reopening the app fixes it.
I could code around the problem, but any fix I introduce would just be a hack. The problem (which manifests as repeated Begin failed, Code 64) is in the firmware, at a level not exposed to application developers.
One hack would be to add a setTimeout to the JavaScript side to ensure that a minimum frequency of message exchange occurs... but this will use more battery on the phone, won't result in a great user experience (the watch will still show it's unable to send a message), and is fragile because PebbleKit JS can be stopped/restarted at any time (which is why the Pebble-recommended best practice is to drive the updates from the watch).
(Another idea was to call app_message_open again in the hope that it would reset the outgoing message state, but that didn't work.)

Is there a known working version of the FW?

On my iPhone, FW 3.14 is stable as long as the phone stays within range. Seems to be a 33%-ish chance that it will end up in Begin failed, Code 64 state if the phone goes out of range. It's possible that the problem was introduced between 3.13 and 3.14, but I haven't tried to confirm that.
What's your experience been?


Tethos Core lib should have factory

Need to have factory in Tethos so that user can write a function that converts object to a mock regardless of mocking framework.

No longer makes sense. It has no real-life usage. Closing.


Supported erlang versions

The wiki quick start ( https://github.com/ChicagoBoss/ChicagoBoss/wiki/Quickstart ) claims support of erlang 15. This is inaccurate due to the need of binary_to_float which is 16 or better.

thanks, updated documentation


Base infra for mocked external services, mocked functional tests.

For functional test isolated from errors of the external services, mocks can be used to simulate external services.
A simple mock framework Dyson is used for mocking (https://github.com/webpro/dyson).
Simple Javascript files can be used to specify the responses, it is easy to create dynamic responses, easy to install and start dyson, so it can be used in CI as well.  One dyson instance can handle many API routes.
I have created two sample API mocks; one for FIO name lookup API (POST), and one for binance explorer transaction query (GET).  They are set up to return data used by platform-api functional tests.  Config files for dyson are located here:   mock/ext-api-dyson.
The external service expoints are exchanged now simply by a duplicated configmock.yml file -- this should be improved, as it creates some undesirable duplication.
Testing:
Install Dyson:
make install-dyson       or         npm install -g dyson

Start dyson with the mocks for external APIs:
make start-mock-dyson            or         dyson  mock/ext-api-dyson

Start platform-api with config for mocked services:
make start-platform-api-mocked            or
go build -o platform-api-bin cmd/platform_api/main.go  && ./platform-api-bin -p 8420 -c configmock.yml

Start functional tests
make go-functional

Other test can be also executed (e.g. postman API tests)

Or the whole thing in one command:
**make go-functional-mocked**

It is a bit hard to pick the suitable mock provider
We already use  github.com/vektra/mockery at Watchmarket.
The main + of it is that we can use Golang structures there. Also it is better when all the environment is with one lang
We need to make a research
I want to remind that there is a Watchmarket project and it is important to have the common tests framework and environment if it is possible
Currently we use:
docker tests for integration tests
mockery for mocking data through unit tests
newman for testing with real endpoints
There is no strict restriction to use specifically these tools, but we need to make a decision for the whole our backend ecosystem

I am not particularly keen on dyson, this was the best choice I found a few weeks ago.  Definitely the more consistent the tooling is, the better.  I will check out mockery as well.
My criteria were/are:

easy to download/install  (if mockery is go-based, should be no problem)
should be easy to specify concrete return values and simple dynamic content, of the form 'if input is A, then response is B, ...'.  Some tools based on api specifications or response files are not suitable for this.
should mock on HTTP API level, run in a separate process.

I have compared some alternatives and sought feedback (in #886 ).  Let's try afresh.

Updated -- criteria for mock tool for external services:

easy to download/install
should mock on HTTP API level, run in a separate process (to avoid mixing of test and product code).
should be easy to specify concrete return values and simple dynamic content, of the form 'if input is A, then response is B, ...'. Some tools based on api specifications or response files are not suitable for this.
should run in a local process, not hosted (paid nor free).  Hosted solutions are convenient, but there's less control (e.g. we need different version for each PR).

The following invocation could be added to the CI build right away (once the PR is accepted):
make newman-mocked test=domain host=http://localhost:8420

It is great solution, hope it will help us to cover all the external APIs soon. That is one of the main issues now


oreilly.com downloading incomplete videos

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
UK
Description
When trying to download from this url: 1.1 Why would I take the Oracle Certified Associate Java Programmer Exam
yt-dlp downloads a version of the video that is cut off after 1 minute while using cookies
I can provide cookies if anyone wants to take a look at this.
 Try with username+password


feat: custom reader and writer for user types

This is an alternative to #784
In this implementation,  you add an "OnSerialize/OnDeserialize"  to your custom types.
Suppose you want to serialize this class:
public struct Quest
{
    public ScriptableQuest scriptableQuest;

    public int progress;
    public bool completed;
    ...
}

You can add a OnSerialize and OnDeserialize method in the ScritpableQuest class:
class ScriptableQuest
{
    ...

    public static void OnSerialize(NetworkWriter writer, ScriptableQuest scriptableQuest) {
         writer.Write(scriptableQuest.Name.GetStableHashCode());
    }

    public static ScriptableQuest OnDeserialize(NetworkReader reader) {
        int hash = reader.ReadInt32();
        return ScriptableQuest.dict[hash];
    }
}

There are pros and cons with #784
Pros

Much simpler code.  Mirror simply looks for OnSerialize and OnDeserialize methods in every type
Much faster weaving.  Mirror does not need to scan assemblies
Works across assemblies <- this is a show stopper for #784

Cons

Cannot define readers and writers for System.* types
Cannot override Mirror readers and writers
Cannot add to NetworkBehaviors,  because they have a OnSerialize and OnDeserialize that are not compatible.

It is enough to solve the serialization issues in ummorpg and Cubica.

Looks good to me. This kinda covers most of my usecases :)

from discord, 2 things to consider:

what if someone uses [syncvar] networkbehaviour
what if someone uses networkbehaviour in cmd

@paulpach how set are you on static onserialize/ondeserialize by the way?
I have been thinking about this a lot. it is a bit weird. the only reason why we need it is for that ScriptableObject lookup, right?
having it non static and moving the serialization to Item.cs would be a more elegant solution imho.
for the same reason that we don't use static OnSerialize/OnDeserialize for NetworkBehaviours either. it would be more weird for ease of use.

@vis2k  there are several issues with non static.

One of the main problems we are trying to solve if the dictionary lookup.  If mirror instantiated the object we would not be able to look up the dictionary instance, defeating the purpose.

Consider this snippet of code taken from SyncObjectInitializer:

            MethodReference readerFunc = Readers.GetReadFunc(itemType);
            if (readerFunc != null)
            {
                serWorker.Append(serWorker.Create(OpCodes.Ldarg_1));
                serWorker.Append(serWorker.Create(OpCodes.Call, readerFunc));
                serWorker.Append(serWorker.Create(OpCodes.Ret));
            }

Similar code exists for syncvars,  and rpcs.   Mirror calls the function with only 1 parameter: the NetworkReader,   and expects the reader to return the object.
If you make the readers non static,  that code will have to change:   It would have to create the instance, and call the OnDeserialize method,   but only if it is a user defined type,  if it is a native time it needs to keep doing what it is doing.   You are afraid of overcomplicating the code?  well,  making the OnDeserialize static is a sure way to make it more complicated.

Similar issues with the writer. Consider this snippet of code from SyncObjectProcessor:

            MethodReference writeFunc = Writers.GetWriteFunc(itemType);
            if (writeFunc != null)
            {
                serWorker.Append(serWorker.Create(OpCodes.Ldarg_1));
                serWorker.Append(serWorker.Create(OpCodes.Ldarg_2));
                serWorker.Append(serWorker.Create(OpCodes.Call, writeFunc));
            }

It gets the writer,  and passes a NetworkWriter and an object as parameters.
If this method is not static, then the first argument would have to be the object (this),  and the second argument would be the NetworkWriter.
We would have to change the SyncObjectProcessor, Rpcs and syncvars to pass the parameters in reverse order,  but only if it is a user defined writer.
As you can see,  making them non static will overcomplicate the code,  and partially defeat the purpose of this PR in the first place.

what I was trying to explain is that we wouldn't need static functions if we move the serialization up by one level in the call stack for ScriptableObjects.
for example:
[Serializable]
public partial struct Quest
{
    public ScriptableQuest quest;

    void OnSerialize(NetworkReader reader)
    {
        int hash = reader.ReadInt32();
        quest = ScriptableQuest.dict[hash];
    }

    void OnDeserialize(NetworkWriter writer)
    {
        writer.Write(quest.name.GetStableHashCode());
    }
}

@vis2k   that might solve issue 1,  but it does not solve issue 2 or 3.
In addition I would not be able to use  SyncSet<ScriptableQuest> or have a ScriptableQuest in a SyncVar.
it also makes it complicated for something like items that have half a dozen other fields that have nothing to do with the hash.   KISS

Closing in favor of #814


Implement the functionality for starting new build.

Hello,
I'm not going to lie, I couldn't help myself and had to dig into #35. I was thinking all the time about somekind database structure upgrade for adding flag, but since I'm not much into Python, I've decided to make it by described and proposed way.
First step is obviously checking, that commit_sha is "0" * 32 and ref is defined. Second step is checkout by defined ref. Third and fourth steps are getting current sha and real ref. The reason for 4th step is fact, that user can insert ref just "develop" and it could be annoying to have many build with "refs/heads/..." and then just "develop". And that's it.
I've also added Enter/Escape listening into input text, because it add more natural feeling and moved Start Build as first item of dropdown - it will be used more times than edit or delete.

Added new commit, that fixes using commit sha as build ref to prevent setting empty ref.

Thanks for the PR. :-)


[SRVKS-216] Add a second manifest that enables v1beta1 APIs.

This adds another manifest to the operator's image so we can easily enable/disable v1beta1 APIs via the --filename argument.

Eh, this is bogus. Sorry for the noise.


Add a websocket API to the integration for event retain

As required by https://github.com/dermotduffy/frigate-hass-card/issues/743

Thanks for the review @NickM-27 !


NumberInput does not play nice with custom icon fonts

A way to set which icon codepoint to use for the chevrons would be needed to fix

number input is not meant to be used with any other font for its buttons other than  iced_fonts::REQUIRED_FONT_BYTES
as this is statically set to use this. I wont be changing this to accept custom icons. if you want this you will need to make the change.

number input is not meant to be used with any other font for its buttons other than  iced_fonts::REQUIRED_FONT_BYTES
as this is statically set to use this. I wont be changing this to accept custom icons. if you want this you will need to make the change.

Which is fine except that there doesn't seem to be a way to specify the icon font if the default is changed in an app

number input is not meant to be used with any other font for its buttons other than  iced_fonts::REQUIRED_FONT_BYTES
as this is statically set to use this. I wont be changing this to accept custom icons. if you want this you will need to make the change.

Which is fine except that there doesn't seem to be a way to use that icon font if the default is changed in an app

Hi
As said previously, the font used in number_input is set statically.
You can create your custom widget with you custom font by changing the line 758 and 793 of the file src/widget/number_input.rs


Make iterators Send

Similar to this commit in imgref, can this be done here with IterColsMut and friends?

const/shared iterators are already Send when T is Sync, and mut iterators are already Send when T is Send :)
I actually think imgref's ImgRefIterator is unsound because it can be sent across threads and return references to something that is not Sync.

Actually, IterColsMut/IterRowsMut specifically may not actually be Send/Sync even though they should be. I'm going to fix this specific case.

Maybe imgref should impl Send/Sync for Img<*const [T]> and Img<*mut [T]>


Add CI just to make sure scripts run

I was thinking maybe we want a GHA to make sure the code all runs without errors here. I don't think we need to check specifically whether that scripts produce the "right" figures/tables, but it might be useful to make sure that code runs in the first place.

After some slack discussion, we're going to change the scope here to add the parsable-r precommit hook: https://lorenzwalthert.github.io/precommit/articles/available-hooks.html


[Feature] A function to open the currently opened position in a new buffer

It would be cool if there'd be an easy way to set up a keybind that "expands" the popup window and opens the displayed location in a new buffer!

This comes up every now and then. You can just take advantage of Neovim's window movement to do so.
In a popup window, hit <C-w>T to make the current popup window become a tab, or <C-w>L to make the popup window become a split to the right.
See: https://github.com/rmagatti/goto-preview/issues/8

ohh, didn't know about that, very nice! Given that it's come up more than once, that might be worth mentioning in your README ^^
otherwise we can close this!

Yeah it is probably worth mentioning. I'll keep this open to track adding that to the readme. I'd be glad to review a PR too if you're up for it 😄


About Licensing

Hey,
thanks for your awesome work here.
Can you please add a license file, so we can use your code?
Best regards

Hi. ok I will add Apache License 2.0.
Thanks.

I just added.


Mask hh24 continues to not work

Can check here http://www.webclub.gr/mask.html

Sorry, It has been fixed.


Updating runner to use database versions and CI comparable to v7

Fixes https://github.com/sequelize/sequelize/issues/16434
This PR overhauls this repo once again.

CI is updated to use Node 10, 18, 20 (oldest v6, oldest v7, latest LTS). It started out as a copy of the CI on the core repo but the install-and-build artifact has been removed and prepare-ci/run SSCCE was added.
The setup folder is renamed to dev, to reflect the core repo. I also copied over the oldest/latest from there. We can update the oldest to the oldest supported v6 versions of the databases but I didn't think that was necessary as we only had one version before.
yarn.lock was added for the cache of GitHub Actions but I'm open to not using that feature and removing it again

In a future PR we should add DB2 support, this PR is already too large as it is.
And we should maybe consider deprecating this repo and updating SSCCE functionality in v6/main branches of the core repo and add a GitHub action that automatically tags a PR that (only) updates the SSCCE. That way we can easily filter out the SSCCE PRs and we don't have to maintain two separate versions.

Looks good, but there is still the issue that tests for v7 try to run on database versions that are unsupported. For example the postgres ones run on 9.5 and 10, but according to sequelize.org/releases only 11 and up is supported.

Good point! We've updated files surrounding that in the sequelize repo for usage in the CI, but haven't updated that here. That shouldn't be why some of these tests are failing but I'll look into that later.

Update; I think it is indeed the postgres and MySQL versions that cause this to break. I'll need to update this with the files from the core repo.

Pretty great to see an update in this repository
We could merge this as-is, but I think we should consider splitting the "oldest" dialects into oldest-v7 and oldest-v6 (latest doesn't need to be split as both versions support the latest version of databases)

Good idea! I'll look into that for the next PR


[post] case study - how we removed 200 static methods in x hours

data

static detector link

amateri PRs screenshots

review from david

tooling

migrify/static-detector
rector - single static replacer + local static
migrify/template-checker

Not prioty ATM


Summarize actions to sentence + icon

Feature request
When visualizing recordings, we would like to collapse each top level action into a one to two sentence description in a systematized way, ideally with an icon (eg prompt for a segment).
Motivation
Understanding recordings, humans and models.

/bounty $100

/attempt #741

@shashank40 from the README, here is a screenshot of the dashboard:

Here is a screenshot of Microsoft's recent updates to PowerAutomate:

Notice the one-sentence action summaries. We would like to implement the same type of thing, i.e. convert an action dict, window dict, and screenshot into a sentence and an icon. You can use the prompt adapter for this, e.g.
summary = prompt_adapter.prompt("Please provide a one sentence summary of the following contents: ...")

I expect the prompt should live in a .j2 file. You will need another prompt to generate an icon.

/attempt #741


Tracking data for ultrasound dataset

Hi!
I found the group 1 data in MNI BITE website: http://nist.mni.mcgill.ca/bite-brain-images-of-tumors-for-evaluation-database/. But there are only 2d/3d ultrasound data without the tracking 4*4 probe coordinate matrixs or the phantom-based calibration matrixs mentioned in the paper.
How can I obtain the complete ultrasound images along with the tracking and calibrated data of the 14 patients  (such as group1_02 provided as a sample in this repo)?
Thank you!

Hi there!
The files are in minc format (e.g. patient #13, sweep "a" will be called 13a.3dus.mnc)
The tracking & calibration info is in the file headers, using the following minc commands:
http://bic-mni.github.io/man-pages/man/mincinfo.html
http://bic-mni.github.io/man-pages/man/voxeltoworld
"All information given by mincinfo is presented as read from the file with no transformation. This means that start and step values, for example, are not in the world coordinate system. To display the start values for a file in world coordinates, use voxeltoworld."

Hi, thank you for the prompt reply!
I used "mincinfo" to read the .mnc file, and got:
file: 2c.2dus.00002sm.mnc
image: unsigned byte 0 to 255
image dimensions: zspace yspace xspace
dimension name         length         step        start
--------------         ------         ----        -----
zspace                      1     0.206099      30.0887
yspace                    480     0.206126       60.319
xspace                    640       0.2061      196.791
But it didn't print out the tracking & calibration matrix. And what's the coordinate system this "start" value under?
Since I failed to compile the minc tool under Ubuntu, I used the tool on Win10 (provided by http://www.bic.mni.mcgill.ca/ServicesSoftware/MINC). The compatibility issues with the executable files stopped me from trying command like "minchead".
I also tried using "nibabel" in Python to read the file:
import nibabel as nib
data = nib.load('./2c.2dus.00002sm.mnc')
print(data)
and I got:

The affine matrix here is nearly the same as yours (the x and z axis seem to be inverting), and it is the tracking matrix without ultrasound to probe calibration. This approach coundn't show the calibration info either.
Do you have any suggestion on it?

Hi there,
I'm attaching code (Perl) I used to extract the pixel-to-world coordinate
transform for each *.mnc file.
You can find the transform for each .mnc file using the mncdump.exe command.
The variable @outString[] is a 4x3 transform matrix mapping 2D pixels to 3D
world coordinates.
if(    @KeyValue[0] =~ "zspace:start" ) { @outString[11] = @Value[0];}
elsif( @KeyValue[0] =~ "yspace:start" ) { @outString[7]  = @Value[0];}
elsif( @KeyValue[0] =~ "xspace:start" ) { @outString[3]  = @Value[0];}
elsif( @KeyValue[0] =~ "xspace:direction_cosines" ) {
@outString[0] = @Numbers[0];
@outString[4] = @Numbers[1];
@outString[ 8] = @Numbers[2];}
elsif( @KeyValue[0] =~ "yspace:direction_cosines" ) {
@outString[1] = @Numbers[0];
@outString[5] = @Numbers[1];
@outString[ 9] = @Numbers[2];}
elsif( @KeyValue[0] =~ "zspace:direction_cosines" ) {
@outString[2] = @Numbers[0];
@outString[6] = @Numbers[1];
@outString[10] = @Numbers[2];}
Note that the mnc files are provided in 3D world coordinates, mm units,
following calibration.
So you can use this info to determine the calibration matrix from 2D pixel
coordinates [x,y,0] to 3D world coordinates.
I used "mincinfo" to read the .mnc file, and got:
file: 2c.2dus.00002sm.mnc
dimension name length step start

zspace 1 0.206099 30.0887
yspace 480 0.206126 60.319
xspace 640 0.2061 196.791
This means that the image 2c.2dus.00002sm.mnc is of size (x,y,z) =
(640,480,1) pixels, a 2D slice since z=1,
the pixel size of (0.2061, 0.2061, 0.2061) mm,
where starting pixel coordinate [0,0,0] corresponds to 3D location
[30.0887, 60.319, 196.791]
and pixel (1,1,0) corresponds to 3D location (30.0887+0.2061,
60.319+0.2061, 196.791)
Good luck!
Matt
On Sat, Aug 28, 2021 at 10:12 PM Leong1230 @.***> wrote:

Hi, thank you for the prompt reply!
I used "mincinfo" to read the .mnc file, and got:
file: 2c.2dus.00002sm.mnc
image: unsigned byte 0 to 255
image dimensions: zspace yspace xspace
dimension name length step start

zspace 1 0.206099 30.0887
yspace 480 0.206126 60.319
xspace 640 0.2061 196.791
But it didn't print out the tracking & calibration matrix. And what's the
coordinate system this "start" value under?
Since I failed to compile the minc tool under Ubuntu, I used the tool on
Win10 (provided by http://www.bic.mni.mcgill.ca/ServicesSoftware/MINC).
The compatibility issues with the executable files stopped me from trying
command like "minchead".
I also tried using "nibabel" in Python to read the file:
import nibabel as nib
data = nib.load('./2c.2dus.00002sm.mnc')
print(data)
and I got:
[image: image]
https://user-images.githubusercontent.com/44676836/131235814-e0491611-1db9-44fc-b134-15d2621001d3.png
The affine matrix here is nearly the same as yours (the x and z axis seem
to be inverting), and it is the tracking matrix without ultrasound to probe
calibration. This approach coundn't show the calibration info either.
Do you have any suggestion on it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mt3000/TMI-2017-Ultrasound-Toews/issues/1#issuecomment-907717434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS3NPUFN2WWJX2NN3PE2GTT7GJSNANCNFSM5CUBY6XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


update from primaryRowIndex to primaryColumnIndex

Fixed an issue in which we were using the field primaryRowIndex and setting that parameter on the importFile endpoint rather than the correct primaryColumnIndex parameter. Renamed the appropriate fields as well for consistency.
Closes #24

Is there no test cases for this scenario which needs updating?

Is there no test cases for this scenario which needs updating?

There is not, actually


Recording training outcomes - iteration 2 entry added

@jesseyuen I made further comments in the Google doc! https://docs.google.com/document/d/1Xei2Cid0Qh_TVvSj0OFOwE0yLb497FzMKR91l2OfOXE/edit#

@jesseyuen I made further comments in the Google doc! https://docs.google.com/document/d/1Xei2Cid0Qh_TVvSj0OFOwE0yLb497FzMKR91l2OfOXE/edit#


minitest: add lite-sata minitest to verify GTP status

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>This PR is to add a LiteX minitest that makes use of liteSATA, which implements the GTP-related tiles

@acomodi - MIght be worth looking at https://github.com/hamsternz/DisplayPort_Verilog

@acomodi - MIght be worth looking at https://github.com/hamsternz/DisplayPort_Verilog

@mithro Sure, that is yet another good candidate for a minitest

@mithro Sure, that is yet another good candidate for a minitest

This minitest needs a README?

Indeed, I forgot to put this as WIP.
I'll need to also fix the litex modules to have a reproducible test and also fix some issues in the Makefile.

This minitest needs a README?

Indeed, I forgot to put this as WIP.
I'll need to also fix the litex modules to have a reproducible test and also fix some issues in the Makefile.


Add mechanism to clear persistent cache.

It would be nice to have an environment variable that can be used to blow all the caches and force a fresh full build. Because async-disk-cache doesn't nest under a single base dir in the os.tmpDir() (I plan to submit a PR over there to do this), we cannot simply do rm -rf /tmp/some/path/here (even if we knew the path).
I would like to do something like:
CLEAR_PERSISTENT_CACHE=true ember build

And have that do something like the following just before the first boot (before this):
  this.processor.clear();

I'm happy to PR this, but wanted to throw it out there before I implemented to make sure there were no major objections...

Yup. But make sure it saves state, so it only clears once per run

@stefanpenner - Confirm, it would have to set a flag so that it only does it one time (for each instance of broccoli-persistent-filter).

Yup

Was this functionality ever implemented?


Save/Load Host, Renter, and Gateway

Plus a minor change to threadedUploadPiece; I figure passing a slice is more idiomatic Go compared to the more C-style approach of passing a pointer. (I mean, they're both pointers under the hood, but you get the point.)

Is it idomatic go to pass around a slice of len 1? If it's always going to be len 1 shouldn't you just use a pointer?

Boy. Second time today I've been wrong about slices.


Docs: cache bust and faster hoverxref

Summary
This PR busts the CSS/JS caches because despite RTD's documentation stating they "bust the cache" every time a new version is submitted, there have been reports of users with the unfortunate experience of having old JS running with newer html.
This PR also replaces the live version of sphinx-hoverxref with a forked version that has been altered to utilize lazy-loaded hoverxref hooks instead of on-page-load, which should dramatically speed up page load times.
Checklist

[x] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[ ] I have formatted the code properly by running task lint
[ ] I have type-checked the code by running task pyright

[ ] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

@bast0006 any status on when the pr to sphinx-hoverxref will be made?

update: the pr has been made: https://github.com/readthedocs/sphinx-hoverxref/pull/227

Due to the cache bust and other general speedups here, I'd like to merge this after #722 unless there is an extended period after this pr is ready and #722 is still not ready.

Due to the cache bust

that only affects select files and shouldn't be relevant to #722, I think.
It might be worth consideration to actually do that for all js files, may be difficult to do with sphinx though.

This PR as it is currently breaks the dark theme toggle.

It's just the cache bust doing it (sigh). Pushing a fix shortly.