[Diet Classifier] ValueError: Number of examples should be the same for all data.

Rasa version: 1.9.2
Rasa SDK version (if used & relevant):
Rasa X version (if used & relevant):
Python version:
3.6
Operating system (windows, osx, ...):
linux
Issue:
When training rasa nlu (i.e. rasa nlu train) there is an error from rasa/utils/tensorflow/model_data.py line 107
Error (including full traceback):
2020-03-27 13:13:06 INFO     rasa.nlu.model  - Starting to train component tokenizer_whitespace
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Finished training component.
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Starting to train component RegexFeaturizer
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Finished training component.
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Starting to train component CountVectorsFeaturizer
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Finished training component.
2020-03-27 13:13:09 INFO     rasa.nlu.model  - Starting to train component DIETClassifier
Traceback (most recent call last):
  File "/home/gunsu/diet/bin/rasa", line 8, in <module>
    sys.exit(main())
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/__main__.py", line 91, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/cli/train.py", line 140, in train_nlu
    persist_nlu_training_data=args.persist_nlu_data,
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/train.py", line 414, in train_nlu
    persist_nlu_training_data,
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/train.py", line 445, in _train_nlu_async
    persist_nlu_training_data=persist_nlu_training_data,
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/train.py", line 474, in _train_nlu_with_validated_data
    persist_nlu_training_data=persist_nlu_training_data,
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/nlu/train.py", line 86, in train
    interpreter = trainer.train(training_data, **kwargs)
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/nlu/model.py", line 191, in train
    updates = component.train(working_data, self.config, **context)
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 622, in train
    model_data = self.preprocess_train_data(training_data)
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 601, in preprocess_train_data
    label_attribute=label_attribute,
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 549, in _create_model_data
    model_data.add_features(LABEL_FEATURES, [Y_sparse, Y_dense])
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/utils/tensorflow/model_data.py", line 145, in add_features
    self.num_examples = self.number_of_examples()
  File "/home/gunsu/diet/lib/python3.6/site-packages/rasa/utils/tensorflow/model_data.py", line 107, in number_of_examples
    f"Number of examples differs for keys '{data.keys()}'. Number of "
ValueError: Number of examples differs for keys 'dict_keys(['text_features', 'label_features'])'. Number of examples should be the same for all data.

Command or request that led to error:
rasa train nlu -c ./bots/lib/config.yml -u ./bots/nlu_train.md --out ./models

Content of configuration file (config.yml) (if relevant):
language: "xx"
pipeline:
  - name: "component.KoreanTokenizer"
  - name: "intent_entity_featurizer_regex"
  - name: "intent_featurizer_count_vectors"
    "token_pattern": '(?u)\b\w+\b' # 1개의 character도 인식하도록 regex 변경
  - name: DIETClassifier
    intent_classification: True
    entity_recognition: False
    use_masked_language_model: False
    BILOU_flag: False
    number_of_transformer_layers: 0
    epochs: 100

Content of domain file (domain.yml) (if relevant):

Thanks for the issue, @rgstephens will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

It looks like some examples don't have intent labels

@Ghostvv
Hi thanks for reply
I had a look at my nlu.md file and didn't find any issues
I trained rasa nlu with the same nlu.md for a lower version of rasa-nlu (0.14.1) and the training was successful, so I don't  think it's got to do with nlu.md

otherwise, it could be that some examples couldn't be featurized for some reason.
0.14.1 version didn't have this check

Any update on that? I'm getting the same issue here, using rasa 1.10.5.

me too! using rasa 1.10.5
File "/Applications/anaconda3/envs/rasa/bin/rasa", line 8, in
sys.exit(main())
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/main.py", line 92, in main
cmdline_arguments.func(cmdline_arguments)
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/cli/train.py", line 140, in train_nlu
persist_nlu_training_data=args.persist_nlu_data,
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/train.py", line 414, in train_nlu
persist_nlu_training_data,
File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/train.py", line 453, in _train_nlu_async
persist_nlu_training_data=persist_nlu_training_data,
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/train.py", line 482, in _train_nlu_with_validated_data
persist_nlu_training_data=persist_nlu_training_data,
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/nlu/train.py", line 90, in train
interpreter = trainer.train(training_data, **kwargs)
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/nlu/model.py", line 191, in train
updates = component.train(working_data, self.config, **context)
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 688, in train
model_data = self.preprocess_train_data(training_data)
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 669, in preprocess_train_data
label_attribute=label_attribute,
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/nlu/classifiers/diet_classifier.py", line 600, in _create_model_data
model_data.add_features(LABEL_FEATURES, [Y_sparse, Y_dense])
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/utils/tensorflow/model_data.py", line 145, in add_features
self.num_examples = self.number_of_examples()
File "/Applications/anaconda3/envs/rasa/lib/python3.6/site-packages/rasa/utils/tensorflow/model_data.py", line 107, in number_of_examples
f"Number of examples differs for keys '{data.keys()}'. Number of "
ValueError: Number of examples differs for keys 'dict_keys(['text_features', 'label_features'])'. Number of examples should be the same for all data.

Hi!
As a temporary solution, I managed to do my bot training by downgrading to rasa 1.10.1. At least here, it issues some warnings, but finishes the training and works correctly.

Hi！
when I use rasa 1.10.1，the result is still reported the same error

@shfshf @JoaoVFelipe Is one of you able to share his NLU data so that I can take a closer look at the problem? Without the data to reproduce the issue it is hard to tell what is going wrong. Thanks.

Hi thanks for reply
my nlu.md maybe like that（Chinese）：
intent:weather_address

告诉我在广州怎么样
告诉我在广州
在辽宁呢
在北京呢
如何厦门
还在武汉呢
在香港呢
在杭州
还在上海
还在宁波
北京里面会不会阴雨
上海什么天气
不好意思可以帮我查香港的天气

intent:weather_date-time

今天台中天气如何
你知道现在外面冷不冷
怎么能下个星期日
还需要昨天
我还要昨天
明天
后天
我还很想一月一号
明天如何
后天如何

The cause of the Chinese error lies in the CountVectorsFeaturizer component！
There are no problems with some corpora, but there are problems with some corpora,
but all corpus annotations are correct！

@robinsongh381 @JoaoVFelipe @tabergma @Ghostvv I am the colleague of @shfshf who provides the custom tokenizer component for his pipeline. And I finally find the there are two root causes of this issue:

The same issue as #1515, I have a very detailed explanation in there and I think it affects all the East Asian language (Chinese, Keras and more)
[May apply to @shfshf 's issue only] out-of-date custom tokenizer: the tokenizer which I provide doesn't compatible with current Rasa (1.10.5). Rasa changed the tokenizer protocol since 1.7.0 (https://github.com/RasaHQ/rasa/releases/tag/1.7.0):

By default all tokenizer add a special token (CLS) to the end of the list of tokens. This token will be used to capture the features of the whole utterance."

Solutions:

Set token_pattern to "(?u)\b\w+\b" for CountVectorsFeaturizer if you are using East Asian language (I will try to make a PR to make it as the default option for East Asian language setting)
Check your tokenizer whether it supports the new tokenizer protocol if you are using a custom tokenizer (if it is not, try to rewrite your custom tokenizer according to one of the  official tokenizers, for example, jieba tokenizer is a good one)

Thanks @howl-anderson for the comment. We actually tackle problem 1 already in https://github.com/RasaHQ/rasa/issues/5905. It is already merged into master.
Just to be sure, if you update your custom tokenizer and solve the token_pattern issue, the problem is gone?

@tabergma It's good to see that the official team already takes action for problem 1. For problem 2,  I am just working on the tokenizer rewriting process, but because when we using jieba as the tokenizer, all problem is gone, so there is definitely something wrong with the custom tokenizer. I will keep you informed whether updating the custom tokenizer works or not.

Thanks @tabergma and @howl-anderson for the help, setting the token_pattern for CountVectorsFeaturizer solved the problem. I actually not training an bot in any Asian language, but some of my training data to recognize out of scope languages has some Chinese, Japanese and Korean characters, and I didn't noticed.
By the way, sorry for not sharing the NLU data before. It is pretty big, and I was instructed to not share it since some of it is enterprise sensitive. Thank you very much.

@tabergma It's proved by @shfshf  that updating the custom tokenizer indeed works! So, I think at least part of @robinsongh381's issue is related to the custom tokenizer too, since his tokenizer works in v0.14.1, but doesn't work in v1.9.2. I hope this message can help him. If @robinsongh381 has trouble rewrite his custom tokenizer, I can try my best to help him.

Thanks @howl-anderson my colleague，
@robinsongh381 @JoaoVFelipe @tabergma，I solved this bug through his solutions successfully，with chinese language the custom tokenizer

Great, glad to hear that it works for you! I will close the issue as there is nothing code wise we can do. If you have trouble rewriting your tokenizers, feel free to ask a question on our forum. We are happy to help.


[North Star Applicant UI] Add styling for upsell/application confirmation page

Ensure that application confirmation page (for standard applications and prescreeners) has updated styling

Changing size estimate from small to medium since the mocks have significant differences from the old page.
For the MVP launch, we might not be able to add "Other programs you may be interested in"

Changing size estimate from small to medium since the mocks have significant differences from the old page.
For the MVP launch, we might not be able to add "Other programs you may be interested in"

@ssandbekkhaug  That section currently exists (assuming there are programs the applicant may qualify for:
The next steps piece would maybe be something for post mvp and the extra information on the "other programs you may qualify for" cards

QA completed and the following design QA issues opened:

#9034
#9033
#9032
#9031

Mobile experience will be tested when #9035 is complete


It simply doesn't work !

The ActiveMQConnectionFactory.createConnection(...) in org.apache.activemq:activemq-client:5.18.0-SNAPSHOT still returns javax.jms.Connection. I wasted my time trying to get it working. I should have known better that if you avoided to provide any source code, it was for a reason.

@nicolasduminil let me take a look. The reason there is no source code, is that this module takes the activemq-client source as-is and renames the javax.jms package to jakarta.jms. There should be no need for any source changes.

@nicolasduminil I think your Maven dependency needs to be adjusted to use this transition client.
The client from Apache 5.18.0 is javax.jms with JMS 2.0 preview support
This client is repackaged for jakarta.jms with JMS 2.0 preview support
<dependency>
  <groupId>io.hyte.activemq</groupId>
  <artifactId>activemq-client-jakarta</artifactId>
  <version>5.18.0.hyte-1</version>
</dependency>

At Apache ActiveMQ, we are working towards an apache release client with jakarta support that will come in 5.18.x or 5.19.x.

see this test class confirming jakarta namespace is correct:
https://github.com/hyteio/activemq-client-jakarta/blob/main/src/test/java/org/apache/activemq/jakarta/JakartaTest.java


return message structure after editing responses

adresses #10

The return types for both REST functions its wrong which inherintly makes this wrong.
Editing webhooks returns a new MessageStructure, this is an error that apparently wasnt noticed until now


Intel DFU not found

I am unable to solve the problem of installing DFU
I install in this way, however I cannot go ahead!!! My system is Ubuntu16.04 LTS and architecture is arm64.
echo 'deb http://realsense-hw-public.s3.amazonaws.com/Debian/apt-repo xenial main' | sudo tee /etc/apt/sources.list.d/realsense-public.list
sudo apt-key adv --keyserver keys.gnupg.net --recv-key 6F3EFCDE
sudo apt-get update
sudo apt-get install intel-realsense-dfu*
dfu command not found any answerss

@jawad-tech , the debians are provided for X86 architecture only.
Note that the DFU is not necessary anymore as you have a much better alternative - #4534

I have solved this problem by:

First I disconnect my camera from arm64 computer and connect it to x86_64 architecture computer.
Then follow the procedure of dfu install and firmware update as mention on Intel website pdf.
Again connect the camera to arm64 pc and the problem is solved.

Thanks.


Add rclrs_test package for unit/integration tests

This package is meant to test behaviors with dependencies that don't
belong in the rclrs crate - namely, msgs
Addresses #237

@nnmm Is this package structure what you envisioned for #237?

Based on previous feedback, I'm wondering about structuring this as

Setup a graph with a couple of nodes, publishers, subscribers, services and clients
Run tests for all the graph.rs stuff

Unfortunately it doesn't look like Rust supports a gtest-like SetUp() and TearDown(), so that means (I think) that this would all go into a single test. Does that make sense to do?

Thanks for tackling this!

@nnmm Is this package structure what you envisioned for #237?

Yep. A few early-stage comments:

We probably want test_msgs rather than std_msg for this package. Though I just compiled it and noticed that we have a bug in rosidl_runtime_rs or rosidl_generator_rs that we need to fix first :/
Returning Result from the tests makes them a little more concise.
You don't need mod tests inside graph_tests.rs. You can just put #[cfg(test)] directly on the modules in lib.rs. Maybe it's even possible to just add a single #![cfg(test)] (with an exclamation mark) to the top lib.rs instead.

Unfortunately it doesn't look like Rust supports a gtest-like SetUp() and TearDown(), so that means (I think) that this would all go into a single test. Does that make sense to do?

I think it would also be fine to have a freestanding setup function that you call in each test. Something like run_with_test_nodes<F>(test_fn: F) perhaps, which spins up the test nodes, runs the provided function, and then cleans up. I'd try that approach, and if spinning up the test nodes is too expensive, we can still group them into fewer tests.

Hrm, looks like adding the test_msgs dependency also pulls lots of other depedencies in... nav_msgs, sensor_msgs, diagnostic_msgs,  and more
error: failed to load source for dependency `diagnostic_msgs`

Caused by:
  Unable to update /workspace/install/diagnostic_msgs/share/diagnostic_msgs/rust

Caused by:
  failed to read `/workspace/install/diagnostic_msgs/share/diagnostic_msgs/rust/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

Not sure what's going on with that....

After rebasing and adding all the msg dependencies, it's building and running now. I'm getting a spurious failure with count_publishers and count_subscribers - after constructing 2 publishers/subscribers, they occasionally return 3 instead. This does not seem to happen when I run a single test individually (e.g. cargo test test_publishers), so seems to be concurrency related. I'd say it's quite likely they're conflicting with test_topic_names_and_types, which creates a single publisher and subscriber. I might just distribute that functionality into test_publishers and test_subscribers

After rebasing and adding all the msg dependencies, it's building and running now. I'm getting a spurious failure with count_publishers and count_subscribers - after constructing 2 publishers/subscribers, they occasionally return 3 instead. This does not seem to happen when I run a single test individually (e.g. cargo test test_publishers), so seems to be concurrency related. I'd say it's quite likely they're conflicting with test_topic_names_and_types, which creates a single publisher and subscriber. I might just distribute that functionality into test_publishers and test_subscribers

Yes, that's annoying. I think it's also fine to run cargo test with --jobs 1 to avoid crosstalk.

Updated to combine everything into a single test - constructing the graph, then calling extracted functions for checking publishers, subscriptions, etc. I know that's a bit of an anti-pattern, but I felt like it was the best way to handle the concurrency issues.
Looks like it still has a compilation failure on GH though, so gonna troubleshoot that later

I can't reproduce that error locally - looks like a problem with the export dependencies of test_msgs? Not sure how to proceed...

@christopherjreid You can try adding a line to the workflow that sources the install directory. Probably
. ${{ steps.build.outputs.ros-workspace-directory-name }}/install/setup.bash

but if that's not the right path, you might need to dig around a bit by adding ls commands etc.

Thanks for the tips! That, and some test changes (apparently Galactic/cyclonedds do not allow publishing to the same topics with different types) got all the tests to pass!
So this is ready for official review now

Looks good in general, I'm just wondering if it's really necessary to group everything in one test because of the interference problem. Would using separate namespaces for each test solve the problem too?

I just added a new commit that creates a new test case for publishers, and one for subscribers. I feel like this is a lot noisier than the previous method, though there is definitely value in having "smaller" (or at least more targeted) test cases like this. What do you think, should I continue on this path for the remaining 3 test cases? (topics, services, and clients)?

I just added a new commit that creates a new test case for publishers, and one for subscribers. I feel like this is a lot noisier than the previous method, though there is definitely value in having "smaller" (or at least more targeted) test cases like this. What do you think, should I continue on this path for the remaining 3 test cases? (topics, services, and clients)?

Hmm, I'd tend towards writing the tests in the most idiomatic way for now and just solve the interference problem by running them sequentially for now (i.e. adding --jobs 1 to CI for this package). Maybe we'll find a better approach for test isolation in the future, involving ROS_DOMAIN_ID or so.
Is that fine with you too @esteve?

Haven't looked at this in a couple days, but noticed CI had a test failure. Running this locally, I notice there's about a 1/15 chance or so that it randomly fails one of the tests, because the publisher/subscription/service/client that -should- exist does not.
Nothing within the test file itself should have concurrency issues anymore - is there some under-the-hood race condition that I'm hitting? Should I sleep for a bit after constructing the graph?

Haven't looked at this in a couple days, but noticed CI had a test failure. Running this locally, I notice there's about a 1/15 chance or so that it randomly fails one of the tests, because the publisher/subscription/service/client that -should- exist does not.
Nothing within the test file itself should have concurrency issues anymore - is there some under-the-hood race condition that I'm hitting? Should I sleep for a bit after constructing the graph?

It seems like nodes won't get immediately notified of other entities (topics, publishers etc.), but only asynchronously.
As far as I can see in https://github.com/ros2/rclcpp/blob/rolling/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpphttps://github.com/ros2/rclcpp/blob/rolling/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp, they use a wait_for_graph_change() function with a timeout. Maybe you can look into porting that function?

Hi @christopherjreid, I've been quiet since I've been on vacation, but please let me know if there's anything I can help you with here :) If you prefer, I could also take a stab at porting wait_for_graph_change().

I would like to do it, just have been very busy (renovating our house). Hopefully I'll have some time this week to take a stab at it!

Okay, great – there's no rush at all.

Not sure why CI is failing. I'm rebased on main...

Not your fault. I just reran CI on another PR, and it failed too. We should report this error in https://github.com/ros-tooling/setup-ros or so, or check if someone already did:
  The following packages have unmet dependencies:
   libignition-math6-dev : Depends: libignition-cmake2-dev (>= 2.13.0) but 2.12.1-2~jammy is to be installed
  W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/ros-latest.list:1 and /etc/apt/sources.list.d/ros2-latest.list:1
  W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/ros-latest.list:1 and /etc/apt/sources.list.d/ros2-latest.list:1
  E: Unable to correct problems, you have held broken packages.

The CI error should now be resolved – but you also need to rebase on main to get clippy fixes that were made necessary by upgrading the Rust compiler.

Ready for merging now, I think!


cargo run fails on OSX 10.12.1

cd libc-test && cargo run fails with:
   Compiling libc-test v0.1.0 (file:///Users/philipp/oss/libc/libc-test)
error: failed to run custom build command for `libc-test v0.1.0 (file:///Users/philipp/oss/libc/libc-test)`
process didn't exit successfully: `/Users/philipp/oss/libc/target/debug/build/libc-test-e4b221826622db1a/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=../src/lib.rs
cargo:rerun-if-changed=../src/dox.rs
cargo:rerun-if-changed=../src/unix/mod.rs
cargo:rerun-if-changed=../src/macros.rs
cargo:rerun-if-changed=../src/unix/bsd/mod.rs
cargo:rerun-if-changed=../src/unix/bsd/apple/mod.rs
cargo:rerun-if-changed=../src/unix/bsd/apple/b64.rs
OPT_LEVEL = Some("0")
PROFILE = Some("debug")
debug=true opt-level=0
HOST = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
CC_x86_64-apple-darwin = None
CC_x86_64_apple_darwin = None
HOST_CC = None
CC = None
HOST = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
CFLAGS_x86_64-apple-darwin = None
CFLAGS_x86_64_apple_darwin = None
HOST_CFLAGS = None
CFLAGS = None
running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-g" "-m64" "-fPIC" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-deprecated-declarations" "-o" "/Users/philipp/oss/libc/target/debug/build/libc-test-a2a81fcd0fdb71cc/out/all.o" "-c" "/Users/philipp/oss/libc/target/debug/build/libc-test-a2a81fcd0fdb71cc/out/all.c"
cargo:warning=/Users/philipp/oss/libc/target/debug/build/libc-test-a2a81fcd0fdb71cc/out/all.c:12680:66: error: use of undeclared identifier 'KERN_KDENABLE_BG_TRACE'
cargo:warning=            static int __test_const_KERN_KDENABLE_BG_TRACE_val = KERN_KDENABLE_BG_TRACE;
cargo:warning=                                                                 ^
cargo:warning=/Users/philipp/oss/libc/target/debug/build/libc-test-a2a81fcd0fdb71cc/out/all.c:12686:67: error: use of undeclared identifier 'KERN_KDDISABLE_BG_TRACE'
cargo:warning=            static int __test_const_KERN_KDDISABLE_BG_TRACE_val = KERN_KDDISABLE_BG_TRACE;
cargo:warning=                                                                  ^
cargo:warning=2 errors generated.
ExitStatus(ExitStatus(256))

command did not execute successfully, got: exit code: 1

--- stderr
thread 'main' panicked at 'explicit panic', /Users/philipp/.cargo/registry/src/github.com-1ecc6299db9ec823/gcc-0.3.35/src/lib.rs:897
stack backtrace:
   1:        0x1079147ba - std::sys::imp::backtrace::tracing::imp::write::hd8952e96bd20f4b7
   2:        0x10791962f - std::panicking::default_hook::{{closure}}::hfd6ba86ea4dd6ba9
   3:        0x1079192d7 - std::panicking::default_hook::h44ade8c78c995294
   4:        0x107919a36 - std::panicking::rust_panic_with_hook::h3e771863e3ed8403
   5:        0x1073b74f3 - std::panicking::begin_panic::h94258923a88c8674
   6:        0x1073d8fba - gcc::fail::h746b5a92c67537cd
   7:        0x1073d8b34 - gcc::run::h1f20c84d1d42308c
   8:        0x1073d017c - gcc::Config::compile_object::h5fb2784c54de727f
   9:        0x1073cfadd - gcc::Config::compile_objects::h037ba06b0cc44c7c
  10:        0x1073cf0b4 - gcc::Config::compile::h7413c285bc5d235e
  11:        0x10739e64a - ctest::TestGenerator::_generate::h8420e1d411a8d88e
  12:        0x10734e55e - ctest::TestGenerator::generate::hee3e8852123ea693
  13:        0x107352809 - build_script_build::main::hb85df0201459ee74
  14:        0x10791a8fa - __rust_maybe_catch_panic
  15:        0x107919dd6 - std::rt::lang_start::hefd96b70277e8a4a
  16:        0x107354d49 - main

if I read the error correctly then it misses KERN_KDENABLE_BG_TRACE and KERN_KDDISABLE_BG_TRACE. These are indeed missing in /usr/include/... in /usr/include/sys/sysctl.h there are some defines such as KERN_KDEBUG but not the two missing ones.
My setup:

OSX 10.12.1
rust: nightly-x86_64-apple-darwin, rustc 1.15.0-nightly (71c06a56a 2016-12-18)

Oh dear! Looks like OSX removed these I suppose? If you want to send a PR updating the "ignore whitelist" in libc-test/build.rs I think that should do the trick!

I tried to build on Travis - and the test runs on i686-apple-darwin and x86_64-apple-darwin.
So I think the problem is on my machine, no?
Is there a place where I can obtain the header files for a given architecture so I could compare Travis' environment to mine?

It's likely that you're running a different version of OSX than Travis, but it doesn't necessarily mean your machine has a problem. I unfortunately don't know of a way to extract header files from Travis.


Added Guss_game.py

What does the program do ?
A Simple number guessing game written in  python.
In what programming language it is written?
Python

This pull request contains conflicts. Please fix it and reopen (it is most likey because you are editing .DS_Store file please remove that change to fix it)


Support for ip_restrictions on function apps

This adds support for setting ip_restriction, so users can restrict access to the UI.
variables.tf
variable "allowed_ip_addresses" {
  type        = list(string)
  description = "A list of allowed ip addresses that can access the ACMEBot UI."
  default     = []
}

main.tf
site_config {
    ftps_state      = "Disabled"
    min_tls_version = "1.2"
    dynamic "ip_restriction" {
      for_each = var.allowed_ip_addresses
      content {
        ip_address = ip_restriction.value
      }
    }
  }

When calling the module:
module "keyvault_acmebot" {
  source  = "shibayan/keyvault-acmebot/azurerm"
  version = "~> 1.0"

  function_app_name     = "func-acmebot-module"
  app_service_plan_name = "plan-acmebot-module"
  storage_account_name  = "stacmebotmodule"
  app_insights_name     = "appi-acmebot-module"
  resource_group_name   = azurerm_resource_group.default.name
  location              = azurerm_resource_group.default.location
  mail_address          = "YOUR-EMAIL-ADDRESS"
  vault_uri             = azurerm_key_vault.default.vault_uri
  allowed_ip_addresses = var.allowed_ip_addresses

  azure_dns = {
    subscription_id = data.azurerm_client_config.current.subscription_id
  }
}

Side note--I notice the CI pipeline isn't running terraform validate, which would be helpful in catching issues besides just running the standard lint check with terraform fmt. Is this something you'd be interested in adding @shibayan ?

@shibayan Also under site_config there needs to be possibility for default action as default is Allow :) ip_restriction_default_action


Bug with the sequential domain reduction

Bug1
In domain_reduction.py, line 105-108:
       for i, entry in enumerate(new_bounds):
            if entry[0] > entry[1]:
                new_bounds[i, 0] = entry[1]
                new_bounds[i, 1] = entry[0]
I guess it aims to swap the values of two entries but it does not work in that way. When new_bounds[i, 0] is rewritten, entry[0] will also be rewritten and new_bounds[i, 1] cannot be designated the appropriate value.
Bug2
new_bounds in the function transform in domain_reduction.py is never trimmed:
line 147: self._trim(new_bounds, self.original_bounds) is doing nothing.
Instead, it should be like: new_bounds = self._trim(new_bounds, self.original_bounds)
These have caused new bounds not within the original bounds.

Hey @bwkong,
thanks for reporting this bug. I think this might be fixed already via #441. We have just not pushed a release since then.

Hey @till-m ,
I faced with the same issue few months ago. Do you have any ideas on when it could be released (since it seems to be fixed more than 1 year ago)?
Thx

Hey @pawlissimo,
my apologies, I know this is annoying. I'm looking into getting this done over the next two weeks (possibly actually today, but no promises).
In the meantime, you can always install directly from github. If you don't know how to do that, let me know how you usually install packages and I can help you.

Hey @pawlissimo @bwkong,
I've pushed release 1.5.0 (big thanks to @Panaetius). Could you download the latest version and let me know if it fixes the problem for you?

Hi @till-m ,
Thanks for so fast reply! I think, you saved a lot of time not only for me;)
Btw, just updated my local conda env and verified that the latest bayesian-optimization=1.5.0 installed. But looks like the main issue still exists or I'm doing something wrong.
In shorts:

I use SequentialDomainReductionTransformer and subscribed JSONLogger to store my results.
Since there is a bounds_transformer (there're no dumps for it in JSONLogger's log), I dump its content as pickle.dump(bounds_transformer, 'path/to/bounds_transformer.log')
At the next day I create new loaded_optimizer and load_logs(loaded_optimizer, logs='path/to/optimizer.log.json) and loaded_bounds_transformer = pickle.load(f).
If I call maximize()  for both original and loaded optimizers, then I see, that last one starts optimization without any care about its own loaded bounds_transformer So, no way to make a "checkpoint" and continue optimization later?.
I've also tried to loaded_bounds_transformer._update(loaded_optimizer.space)

Hope, it makes sense and you could point me out on the mistake in my approach
P.S. I carefully read whole documentation and followed most of examples., but was not able to find the proper way.
P.P.S. I'm so interesting in this fix because each single function evaluation costs approx. 1..5$ and may take up to 1 hour (!!!) And there are ~20 func. args. So, trying to prepare proper framework to continue my optimization after sporadic failures.

Hi @pawlissimo
This sounds like a slightly different problem to me, in all likelihood related to the serialization of the optimizer/transformer. If I am reading correctly, the problem is not related to the trim or clamping logic of the bounds transformer, but the transformer doesn't work at all?
If yes, could you please open a separate issue, ideally with a code snippet that allows us to reproduce the problem?

Hi @till-m ,
looks like I forgot to mention you yesterday in my response.
I've opened a new bug request. Could you pls take a look - https://github.com/bayesian-optimization/BayesianOptimization/issues/486 ?
Thx a lot!

Closing in facor of #468


Expand custom actions to allow for multiple IDs, etc.

Show action/menu in sub-toolbar when have multiple selection.
Will need extra sections in actions.json - e.g. "artists", "albums", "tracks". Support "$MULTI_ID" replacement? Or???
Browse code would then need to store list of multi-id actions and show when appropriate.

Closing, as not something I personally have a use-case for.


CL:1000409 'myocyte of sinoatrial node' vs CL:1000477 'cardiac pacemaker cell of sinoatrial node'

id: CL:1000409
name: myocyte of sinoatrial node
is_a: CL:0002072  ! nodal myocyte

but there is another class:

CL:1000477 'cardiac pacemaker cell of sinoatrial node'

in CL we have
CL:0002072 ! nodal myocyte [SYNONYM: "cardiac pacemaker cell" (exact)]

if we define CL:1000477 in the obvious way it leads to an equivalence axiom

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 20 Feb 2013 at 6:27

My understanding here is that the sinoatrial node contains both “cardiac pacemaker cells” and “transitional myocytes”,

From https://www.ncbi.nlm.nih.gov/books/NBK459238/:
"[SA node myocytes] have the ability to spontaneous (sic) generate an electrical impulse. It is the integrated activity of these so-called pacemaker cells that form the SA node. This electrical impulse is then transmitted by perinodal cells, or transitional (T) cells, to the right atrium... "
A "paranodal area" is also described in PMID:20946278:
"Recent work has shown an extensive “paranodal area” in humans, located within the crista terminalis close to, but not continuous with, the SAN... The paranodal area comprises a mixture of loosely packed nodal and atrial myocytes and has a molecular architecture in some respects distinct and intermediate to the SAN and atrial muscle. Whereas in the SAN there is no Cx43 (connexin43—responsible for electrical coupling between cardiac myocytes) and no atrial natriuretic peptide (ANP), and in the atrial muscle there is both, in the paranodal area there is a heterogeneous mixture of myocytes, some of which express Cx43 and ANP while others do not..."
Perhaps the first point to clarify is whether CL:1000478 'transitional myocyte of the sinoatrial node' is actually part of the SAN or a separate, distinct "paranodal area".


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependabot-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report
Base: 81.20% // Head: 81.15% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (128076e) compared to base (bf33249).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   81.20%   81.15%   -0.06%
==========================================
  Files          41       40       -1
  Lines        1128     1125       -3
==========================================
- Hits          916      913       -3
  Misses        212      212

Flag
Coverage Δ

linux
?

linux-extra_libs
?

windows
81.15% <ø> (ø)

windows-extra_libs
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

oteapi/strategies/parse/application_vnd_sqlite.py
95.55% <ø> (ø)

oteapi/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added the new breakout game by replacing the old one.

Related Issue

To add the breakout game by replacing old one.

Closes: #1164
Describe the changes you've made
Added the brick breaker /breakout game implementwd in javascript with sounds and music in it.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

Please Review.@991rajat

Hey @Shivangi-ch Game looks good, just replace the old gif with new one of yours.
If the gif you create is of more than 1MB you can use static image.

@991rajat I have done the requested changes. Please review

Looks Good. Great Work

Thanks for the contribution.
Keep Contributing.


Define managing the project

Should have answers to the following:

How to add features that can both be both in v0.2.x and v0.1.x
-- add separate feature branch so it can be merged to both branch when done.
How many minimum tickets should be done before bumping the version
-- maybe minimum of 10 (minor) or 3 for major ones?
where is wip for each v0.2.x and v0.1.x
-- v0.2.x_wip - ongoing project's wip
-- wip - current stable release (for master) or v0.1.x at the moment

This documentation should be in a MAINTAINER.md file. This is not set in stone and is a living document.

Only set 2 branches instead of a lot.

master - the latest stable (meaning, at least working no obvious issues found)
wip - currently named v0.1.x_wip, non-stable features can be merged here

Every commit MUST have a ticket.
Every feature/branch/fix MUST be on separate branch. Once it's ready, compress it into one commit for wip. Once stable, merge to master
Milestone MUST be used instead of physical branches as it is easier to manage than having to merge to a lot of branches.


Auth is not working

I tried to do this but is having this error
Error description

This was solved in this commit: 3453kgkh4534khg


aip-142: erroroneous suggested replacement of google.type.Date with google.protobuf.Timestamp

https://google.aip.dev/142 states "Fields representing time should use the common, generally used components (such as google.protobuf.Timestamp or google.type.Date)", but anywhere I use google.type.Date in a proto the linter gives me a suggestion to use Timestamp instead.
To reproduce create a file file.proto with the following content:
syntax = "proto3";

import "google/type/date.proto";

// Test message.
message Test {
  // Test date field.
  google.type.Date date = 1;
}

run the linter and observe the following problem:
$ api-linter file.proto
- file_path: file.proto
  problems:
  - message: Fields representing timestamps should use `google.protobuf.Timestamp`.
    suggestion: google.protobuf.Timestamp
    location:
      start_position:
        line_number: 8
        column_number: 3
      end_position:
        line_number: 8
        column_number: 18
    rule_id: core::0142::time-field-type
    rule_doc_uri: https://linter.aip.dev/142/time-field-type

I can not reproduce this. I see that Date is allowed and a test establishing that. Are you sure you are on a recent version, perhaps?
Closing for now, but feel free to reopen if needed.

I was using /google/bin/releases/api-linter/api-linter.


sh performance and streaming behavior

Introduction
First off, I just want to compliment you on how rad this module is!!!
I really think this concept is transformational to how people use python.
I noticed when I started to use sh that things ran a little slower than a comparable shell job, or even a python script using popen.  I also noticed that each stage in a pipepline created with sh seemed to run fully before passing it's results along (basically didn't handle SIGPIPE).
Here are some examples:
Testing seq into random shuffle
Using python sh
# sh1.py
from sh import seq
from sh import gsort
gsort(seq('100000'), '-R')

time
> time ./sh1.py > /dev/null
> ./sh1.py > /dev/null  8.17s user 0.75s system 111% cpu 8.033 total

Using good ol' bash
# shell1.sh
seq 100000 | gsort -R > /dev/null

time
> time ./shell1.sh > /dev/null
> ./shell1.sh > /dev/null  3.62s user 0.07s system 97% cpu 3.788 total

Using python popen
# popen1.py
from subprocess import Popen
from subprocess import PIPE
seq = Popen(['seq','100000'], stdout=PIPE)
sort = Popen(['gsort','-R'], stdin=seq.stdout)
sort.wait()

time
> time ./popen1.py > /dev/null
> ./popen1.py > /dev/null  3.65s user 0.09s system 97% cpu 3.837 total

Testing seq into awk
Things got pretty bad here...
Using python sh
# sh2.py
from sh import seq
from sh import awk
print awk(seq('100000'), '{print $0 + 1;}')

time
> time ./sh2.py > /dev/null
> ./sh2.py > /dev/null 9.33s user 4.51s system 118% cpu 11.648 total

Using good ol' bash
# shell2.sh
seq 100000 | awk '{print $0 + 1}'

time
> time ./shell2.sh
> ./shell2.sh > /dev/null  0.22s user 0.01s system 130% cpu 0.180 total

Using python popen
# popen2.py
from subprocess import Popen
from subprocess import PIPE
seq = Popen(['seq','100000'], stdout=PIPE)
add = Popen(['awk','{print $0 + 1}'], stdin=seq.stdout)
add.wait()

time
> time ./popen2.py > /dev/null
> ./popen2.py > /dev/null  0.26s user 0.03s system 122% cpu 0.240 total

Finally - Streaming Behavior
Running any of these commands into head, shows whether or not the process is streaming data or if it's computing everything in each step before passing it along
Using python sh
Still takes the same amount of time
time ./sh2.py| head > /dev/null  0.00s user 0.00s system 0% cpu 10.662 total

Using the other 2 returns instantly
time ./popen2.py| head > /dev/null  0.00s user 0.00s system 5% cpu 0.062 total
time ./shell2.sh | head > /dev/null  0.00s user 0.00s system 14% cpu 0.025 total

Summary
As you can see, there's a lot of overhead happening in sh.py compared to bash or using popen.  I'm constantly working with > 1GB files, so that makes sh intractable for me right now.  Are these issues on the roadmap, or is this not really in the scope of sh's concerns?
PS - Have you considered using dot syntax to build up the pipeline in addition to function composition?  Where something like this would work:
cat('hello.txt').sort('-t,', '-k2,2').head()

Just think that'd be cool, and more familiar to bashers...  :)

In this example:
from sh import seq
from sh import gsort
gsort(seq('100000'), '-R')

What's happening under the hood is as follows:

seq executes, all of its output is aggregated together
gsort is called with the aggregated contents of seq

This is not super ideal for two reasons:

The first command must finish before the second can run
Data from the first command is bloating memory

This topic is covered in advanced piping
So the advised solution is...
from sh import seq
from sh import gsort
gsort(seq('100000', _piped=True), '-R')

This tells seq "hey, we're going to use your output to stream into another command as it comes in, so let's set up some machinery to do this."  This keyword argument is necessary because otherwise seq has no idea how it will be used.
However, this still has overhead problems.  For people like you, working with large amounts of data, this data does not need to flow into python at all.  The processes should be able to be connected together at a more fundamental level.  Fortunately there is a lesser known option: _piped="direct".    But this option is what you want:
from sh import seq
from sh import gsort
gsort(seq('100000', _piped="direct"), '-R')

This will set gsort's stdin fd to be seq's stdout fd.  So the overhead should mostly vanish.  Tell me if that works out for you and we can go from there

Thank you for the quick response!
Yes, that made for a huge improvement, but still ~5x slower on the second command:
> time ./sh2.py > /dev/null
./sh2.py > /dev/null  1.13s user 0.17s system 129% cpu 0.998 total

> time ./popen2.py > /dev/null
./popen2.py > /dev/null  0.20s user 0.03s system 119% cpu 0.190 total

Also, piping a command into head on the shell ignores SIGPIPE, still taking the same amount of time to run:
> time ./sh2.py| head > /dev/null
./sh2.py| head > /dev/null  0.00s user 0.00s system 0% cpu 0.989 total

Thanks for the help,
Taylor

Hmm..I will need to dig in a bit to find the performance overhead of direct piping.  Until I figure out what's making it run much slower, that will be as good as it gets :\
I'll also need to dig into the SIGPIPE issue.  Thanks for reporting both of these

Thank you!!!

I've submitted a pull request #243 to document lesser known option: _piped="direct"

I experimented a bit with finding the overhead in direct piping (which is now the default for _piped=True, so _piped="direct" is no longer needed). The overhead exists is mostly due to sh's flexibility, and spending engineering effort to eek out more performance would complicate the code base substantially.  So wrt more performance, it will stay the way it is and I would recommend using subprocess.Popen on code you want to really perform well.
Wrt the piping, I believe that is an issue with Python itself. It is the Python process itself that should handle SIGPIPE, and although child processes (ones launched with sh) would inherit the signal handlers, I can't make sh correctly assume how to handle SIGPIPE globally, as it will effect code that import sh.


add Docker-Compose script

Description
I Added a Docker-Compose script as another option.

Hi, thank you for your contribution. A docker compose example is already in our docs (in another file) - take a look here: https://getdashdot.com/docs/install/docker-compose


chore: fix eslint warn(no-template-shadow)

Description

Linked Issues
Additional context

rt.

Yes, is it necessary for us to extract the RenderInput component into an external file separately to avoid this problem?

In addition, the final results of the following two submissions seem to have done nothing, because I originally wanted to reopen a pr, but because I know little about pr and don't know the rules in it, I am going to resubmit a new pr about interface style after this is closed or merged.

with https://github.com/antfu/regex-doctor/pull/8


Python 3 Compatibility

Hello!
This is a great tool set. Internally we have patched the python 3 incompatible print statements with the proper new syntax, would you like us to contribute back and open an PR with these changes made so it works in py3 environments? We can support backwards compat by importing the future function for print if you'd like. Just let us know.
Python 3 also doesn't like mixing tabs and spaces and we are getting hit with warnings that we have fixed as well, we can patch that as well if you'd like.
Again, great project :) Thanks!

I see the changes are actually on your master branch. I guess there just needs to be a new release made?


Adding information about PowerShell Script

Adding information about the PowerShell script to achieve the same.

Hi @SilviaDoomra, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (sdoomra). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@SilviaDoomra : Thanks for your contribution to the Azure documentation! The author, @SilviaDoomra, has been notified to review your proposed change.

@SilviaDoomra It looks like you're a Microsoft employee. You should be contributing to our private repository, Azure/azure-content-pr. Our guidance wiki has the instructions for getting permissions, etc. The advantages for you are much more validation and error checking before publishing, and content staging so that you can see your changes just by opening a pull request.
Guidance: https://github.com/Azure/azure-content/blob/master/contributor-guide/tools-and-setup.md#permissions-in-github

@curtand @SilviaDoomra Thank you!


Expose tank tick styling

Trying to set style of the Tank tick/markers associated with a custom label, but Tick is not in the tank properties.

Also trying to set the tick label properties.


Fix misspell

Simple, huh?

Thank you @andreyluiz ! Haha no idea why I havn't seen that mistake :)

Great. Cheers. :clap:


Upgrade ECMA Script version

What
Let's upgrade ECMA Script version from ES6 to ES2017 or above.
Why
Now, ONE-vscode is using ES6 for typescript configuration
https://github.com/Samsung/ONE-vscode/blob/be6eb0dfdee037889433181b836d3228ed343f11/tsconfig.json#L1-L8
Since async and await has been introduced in ES2017, upgrading to ES2017 or above will be the choices.
Any opinions will be welcomed. 😄

If current codes have no issues, I agree to upgrade the version :)

It's great if you try updating it on the draft. I hope there is no problem. :)


DB and user name collision

Permit multiple CloudSQL in the same deployment with same database name or same users

This will delete existing resources with  the previous naming scheme.  Probably not a wise move with databases.

Hi,
you are absolutely right but at the moment the "name convention" does not permit multiple databases with the same name in the same deployment
I think that an ordered number in the name solve the problem, but I'm afraid about possible reordering

I've raised this issue/feature request.  If we could abandon the databases then rename them and then acquire them again with the new naming convention that would work better for everyone (an even better solution would be having a way to update the resource names, I guess).

@davidebelloni Thanks for your contribution. Please make sure you are changing the version in the Schema file. ( as @rick-pri pointed out this is a greaking change.) Please also add a note to the Changelog file. I will take a look at the tests.
@rick-pri You are right about the fack this is a breaking change. We are trying to singal this in the schema version, so are users adopt this template with care.

/gcbrun

@ocsig done

/gcbrun

Test fails on a known (unrelated) issue.


from_smirnoff without charge_from_molecules silently assigns all isormophic molecules the same partial charges

Description
User case:
I construct an Interchange object from a Topology with two or more ismorphic Molecules with different partial charges.
In this case the first Molecule has am1bcc charges whilst all the others have gasteiger charges, which differ significantly.
Outcome:
All the Molecules silently get assigned the partial charges from the first Molecule.
Reproduction
from openff.units.openmm import from_openmm
from openmm import NonbondedForce
from openff.toolkit import Molecule, Topology, ForceField
from openff.interchange.components._packmol import solvate_topology_nonwater
from openff.interchange import Interchange
import pytest

solvent = Molecule.from_smiles('c1ccccc1')
solvent.assign_partial_charges(partial_charge_method='gasteiger')
print("solvent charges: ", solvent.partial_charges)

ligand = Molecule.from_smiles('c1ccccc1')
ligand.generate_conformers()
ligand.assign_partial_charges(partial_charge_method='am1bcc')
print("ligand charges: ", ligand.partial_charges)

print("molecules are isomorphic: ", ligand.is_isomorphic_with(solvent))

off_top = Topology.from_molecules(ligand)
solvated_off_top = solvate_topology_nonwater(topology=off_top, solvent=solvent)

ff = ForceField('openff-2.2.0.offxml', 'opc.offxml')
inter = Interchange.from_smirnoff(topology=solvated_off_top, force_field=ff)

for _, c in inter.collections["Electrostatics"].charges.items():
    assert abs(c.m) == pytest.approx(0.13)

# Double check this isn't just the collection, and it goes all the way to an openmm System
system = inter.to_openmm_system()
nonbond = [f for f in system.getForces() if isinstance(f, NonbondedForce)][0]

for idx in range(system.getNumParticles()):
    c, _, _ = nonbond.getParticleParameters(idx)
    assert abs(from_openmm(c).m) == 0.13

print(all(solvated_off_top.molecule(0).partial_charges == ligand.partial_charges))
print(all(solvated_off_top.molecule(1).partial_charges == ligand.partial_charges))
print(all(solvated_off_top.molecule(1).partial_charges == solvent.partial_charges))

Output
solvent charges:  [-0.062268570782092456 -0.062268570782092456 -0.062268570782092456 -0.062268570782092456 -0.062268570782092456 -0.062268570782092456 0.062268570782092456 0.062268570782092456 0.062268570782092456 0.062268570782092456 0.062268570782092456 0.062268570782092456] elementary_charge
ligand charges:  [-0.13 -0.13 -0.13 -0.13 -0.13 -0.13 0.13 0.13 0.13 0.13 0.13 0.13] elementary_charge
molecules are isomorphic:  True
True
False
True

Software versions
Interchange v0.3.29

For better or worse is the intended behavior - whether or not charge_from_molecules is passed through, the charges on the input topology/molecule objects are completely ignored.
In general this is just how the force field works, partial charges are computed by the definition in the force field and particular molecules can be assigned preset charges by matching the list of molecules in charge_from_molecules. I don't think it's possible to assign isomorphic[^1] molecules different charges.
[^1]: Or something like that - I believe the criteria about how similar-looking molecules get the same parameters are baked into Topology.identical_molecule_groups

Ah thanks, that makes sense, I totally didn't think through that this was just the partial charges getting reassigned to am1bcc 🤦🏽♂ !

I don't think it's possible to assign isomorphic molecules different charges

That's unfortunate. There are a few cases that come to mind where manually modifying charges for a single molecule could be useful, but I guess it's also something we could do after we convert the Interchange object to the target engine format.

Yeah, seconding Matt here - this is a known and intentional limitation of our format and ecosystem. We can't assign different charges to isomorphic molecules. If that's the desired behavior then it's up to the user to modify the charges after export to the target engine format.

I agree that this is the intended behavior. Probably the outcome of this is that we should re-check the docs to make sure that this is sufficiently clear in the docs (which I see Matt is working on in #1064 ). However, I'd be opposed to having the toolkit/interchange print something that says it's doing this, because this is the expected behavior.

However, I'd be opposed to having the toolkit/interchange print something that says it's doing this, because this is the expected behavior.

@davidlmobley this runs counter to #1048 - from a user perspective, knowing the provenance of how charges were assigned is rather useful (I think I've made my point in that issue but happy to discuss further).

I'm going to say this is resolved with better documentation of this behavior (#1059, part of 0.4.0). I don't think there's a huge conflict between this and logging (#1053, delayed to 0.4.1) since logging is opt-in.
For figuring out a way to for this to happen, maybe #1075 or a (just to keep things more focused) different issue perhaps?


End to end cross tests trunk:prod

Closes #491
- What I did
Split end_to_end_tests into a prep stage and a parallel set of tests between:

cicd1:trunk cicd2:trunk
cicd3:trunk cicd4:prod
cicd5:prod cicd6:trunk

- How to verify it
GitHub Actions logs should confirm functionality.
- Description for the changelog
End to end cross tests trunk:prod

First pass of cross tests worked, in that we can see @cicd3 testing with @cicd4 and @cicd5 testing with @cicd6
cicd1:cicd2 passed clean
cicd3:cicd4 failed:
command sent: update:ttr:-1:@cicd4:yt@cicd3 john
Response: data:26
update verb response : data:26
command sent: llookup:@cicd4:yt@cicd3
Response: data:john
llookup verb response : data:john
command sent: llookup:cached:@cicd4:yt@cicd3
Response: error:AT0015-key not found : cached:@cicd4:yt@cicd3 does not exist in keystore
llookup verb response : error:AT0015-key not found : cached:@cicd4:yt@cicd3 does not exist in keystore

03:48 +47 -1: test/update_verb_test.dart: update verb by sharing a cached key  [E]
  Expected: contains 'data:john'
    Actual: 'error:AT0015-key not found : cached:@cicd4:yt@cicd3 does not exist in keystore'

  package:test_api                  expect
  test/update_verb_test.dart 190:5  main.<fn>

and cicd5:cicd6 failed very similarly:
command sent: update:ttr:-1:@cicd6:yt@cicd5 john
Response: data:26
update verb response : data:26
command sent: llookup:@cicd6:yt@cicd5
Response: data:john
llookup verb response : data:john
command sent: llookup:cached:@cicd6:yt@cicd5
Response: error:AT0015-key not found : cached:@cicd6:yt@cicd5 does not exist in keystore
llookup verb response : error:AT0015-key not found : cached:@cicd6:yt@cicd5 does not exist in keystore

03:46 +47 -1: test/update_verb_test.dart: update verb by sharing a cached key  [E]
  Expected: contains 'data:john'
    Actual: 'error:AT0015-key not found : cached:@cicd6:yt@cicd5 does not exist in keystore'

  package:test_api                  expect
  test/update_verb_test.dart 190:5  main.<fn>

My hypothesis is that the PR itself is good, and the cross testing is revealing what we want it to - issues between new code and existing production code.


Feature Filter by path

ince https://github.com/AvaloniaUI/Avalonia.NameGenerator/releases/tag/0.2.0-preview the  the generator processes all  classes inheriting from the Avalonia.INamed interface.
Current behavior
the generator processes all  classes inheriting from the Avalonia.INamed interface.
New behavior
When you define AvaloniaNameGeneratorFilterByPath, the generator only processes classes that inherit from the Avalonia.INamed interface with mattch specified glob pattern.
Accepted pattern
It processes all classes with glob pattern
<PropertyGroup>
   <AvaloniaNameGeneratorFilterByPath>Presentation/Views/*View.xaml</AvaloniaNameGeneratorFilterByPath>
</PropertyGroup>

It processes all classes with multiple glob pattern
<PropertyGroup>
   <AvaloniaNameGeneratorFilterByPath>*View.axaml;*Control.axaml</AvaloniaNameGeneratorFilterByPath>
</PropertyGroup>

Just out of curiosity, how the x:Name processing is handled in WPF/WinForms worlds? I don't remember namespace/path exclusions there, their generator just works. Probably we should process only those classes that have the appropriate XAML file with the same name placed nearby without emitting the warnings (and silently skip that file if no XAML file found)? I'd prefer not to overcomplicate such a straightforward thing as x:Name reference generation. Also assuming the additional XAML file existence check is relatively cheap.

I think two criteria would work to only generate name field references when needed:

Only processes XAML (.xaml or .axaml) files when there is a corresponding file of the same name with *.xaml.cs or *.axaml.cs
Only generate name references when the XAML actually contains "Name" or "x:Name" attributes

Hmm also as @rstm-sf noted there is yet another extension we should support — paml https://github.com/AvaloniaUI/Avalonia/search?q=paml

Probably a more robust solution would be to:

Parse XAML files included as <AdditionalFile />s
Skip files that has no x:Class directive at the root node
Resolve the type from the x:Class directive via our MiniCompiler
Perform the codegen

paml extension files are very old from before the project was named Avalonia. It probably should NOT be supported to encourage others to update.
Using x:Class is a great idea I forgot about.

Probably a more robust solution would be to:
1. Parse XAML files included as `AdditionalFile`

2. Skip files that have no `x:Class` directive

3. Resolve the type from the `x:Class` directive via our MiniCompiler, RoslynTypeSystem and XamlX

4. Perform the codegen

This implementation won't suffer from errors like "uh-oh there is no XAML, PAML, or AXAML file nearby" and also won't process irrelevant files. This way we can remove the AXN0001 warning and make the AXN0003 warning an error.

it's a great idea, but xml parsing is expensive, having optional filters that have to limit the scope would improve its effectiveness.

Yeah since we are now parsing x:Class limiting the scope makes sense.

It would be cool to set different generator behavior for different file types
<AvaloniaNameGeneratorFilterByPath Behavior="InitialComponent">View.axaml;Control.axaml</AvaloniaNameGeneratorFilterByPath>
<AvaloniaNameGeneratorFilterByPath Behavior="OnlyProperties">MyView.axaml;MyControl.axaml</AvaloniaNameGeneratorFilterByPath>

Closed by https://github.com/AvaloniaUI/Avalonia.NameGenerator/pull/32, shipped to NuGet as 0.4.1, see also Advanced Usage.


[$500] BA - Unable to confirm on double check Personal info page, error appears

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.51-1
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4418483
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Pre-requisite: the user must be logged in and have created a Workspace.

Go to Workspace > Bank account.
Select Connect manually.
Enter "011401533" and "1111222233331111" for Routing number and Account number.
On Personal info, use "First" and "Last" for first name and last name.
Enter random data on the rest of the fields.
On double check Personal info, try to confirm.

Expected Result:
The user should be able to confirm on double check Personal info page and proceed to Onfido flow.
Actual Result:
The user is not able to confirm on double check Personal info page.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/a8c34176-3694-4853-bc83-5e322cd830b2

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f8390f05597b3838
Upwork Job ID:<PHONE_NUMBER>384727040
Last Price Increase: 2024-03-19
Automatic offers:

s77rt | Reviewer | 0
tienifr | Contributor | 0

@cristipaval FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@kavimuru can you share the console/ networks tab to see what was the error of the API call?
From the logs, it seems like we were not able to verify the name and date of birth and hence it failed Please verify your name and date of birth. If the information is correct
Is this supposed to work for other than the Alberta Bobbeth Charleson names?

I think this can be demoted, but wont do so until its the last blocker

I could reproduce this, and I have similar logs
It's the error stated by @mountiny above. I think we should show a better error message, but I wouldn't block the deploy on this.

Confirmed with @MariaHCD this is expected given if we use different name than Alberta Charleson the checks are being done so in this case it fails.
I agree with Cristi that better error should be shown, not sure if you want to handle that here, I assume we can add this to Wave collect as polish

I'm not able to reproduce this. Anyone able to reproduce on main?

I think we want the errors from Onfido, not our own validation in this case

@garrettmknight I'm ooo until April 08 - I'll be taking back any issues taht are still Open once I return.

CURRENT STATUS:
Issue is still being reviewed and looking for a suitable proposal for fix.

Sorry I missed to re-test this. Turns out this is not reproducible on dev. But I'm able to reproduce on production/staging

@GandalfGwaihir Thanks for the proposal. Unfortunately it aims to achieve something different than the expected behaviour

@tienifr Thanks for the proposal. Your RCA is correct. The solution looks good to me.
🎀 👀 🎀 C+ reviewed
Link to proposal

I'm back from ooo and taking this one back

PR has not been merged yet

Created an internal PR to address this https://github.com/Expensify/Cloudflare-Workers/pull/137/files

@tienifr @s77rt can you please retest now? the backend fix should be out

@mountiny https://sdk.onfido.com was added to the style-src whitelist. It should be script-src

Thanks, waiting for deployment of the update 🤦
Its correct for adhoc builds only, overlooked that the assets.onfido been for style-src as well as script-src

I think we can pay $125 each for your work and help identifying the root cause

$125 to @tienifr and @s77rt

Payments sent and contracts ended! thanks!


Autoplay doesn't work when pauseOnHover & pauseOnFocus are false

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to Vue Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.5.18
Description
In my use case I have a Splide slideshow as only component in my screen.
When pauseOnHover & pauseOnFocus are false then autoplay will never work also not when clicking on the control button.
Reproduction Link
No response
Steps to Reproduce
<template>

    <Splide ref="splide" :options="slideConfig">
      <SplideSlide v-for="slide of slides" :key="slide">

      </SplideSlide>
    </Splide>

      <button class="splide__play">Play</button>
      <button class="splide__pause">Pause</button>

</template>

Expected Behaviour
Splide's autoplay should work when pauseOnHover & pauseOnFocus are disabled

It's working even if both are disabled:
https://codesandbox.io/s/autoplay-xljv65?file=/src/components/BasicExample.vue
(If you see SyntaxError on preview window, press the reload button to transpile the code)


Remove spaces on empty lines in layout.erb

Just like middleman#1504.

Coverage decreased (-0.01%) to 94.93% when pulling 46af9b66d810597cb42a378ad66acdea5bf50eb0 on cllns:remove-whitespace-lines into 1fd21a8f85b1542b0fa3eb3abba683bf4eb16fa2 on middleman:master.


Cannot load HASS when this component is enabled

I have HASS installed per the virtualenv instructions.  I followed the installation instructions as described in the README, and have tried both the websocket branch as well as the master branch.
HASS just gets stuck at startup after the 'Setup of domain recorder' step:
2019-06-19 18:01:50 INFO (Thread-9) [homeassistant.loader] Loaded sensor from homeassistant.components.sensor
2019-06-19 18:01:50 INFO (Thread-4) [homeassistant.loader] Loaded default_config from homeassistant.components.default_config
2019-06-19 18:01:51 INFO (Thread-12) [homeassistant.loader] Loaded homeassistant from homeassistant.components.homeassistant
2019-06-19 18:01:51 INFO (Thread-6) [homeassistant.loader] Loaded group from homeassistant.components.group
2019-06-19 18:01:51 INFO (Thread-9) [homeassistant.loader] Loaded tts from homeassistant.components.tts
2019-06-19 18:01:51 INFO (Thread-21) [homeassistant.loader] Loaded script from homeassistant.components.script
2019-06-19 18:01:51 INFO (Thread-7) [homeassistant.loader] Loaded persistent_notification from homeassistant.components.persistent_notification
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setting up homeassistant
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setup of domain homeassistant took 0.0 seconds.
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setting up persistent_notification
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setup of domain persistent_notification took 0.0 seconds.
2019-06-19 18:01:51 INFO (Thread-14) [homeassistant.loader] Loaded http from homeassistant.components.http
2019-06-19 18:01:51 INFO (Thread-15) [homeassistant.loader] Loaded webhook from homeassistant.components.webhook
2019-06-19 18:01:51 INFO (Thread-5) [homeassistant.loader] Loaded cloud from homeassistant.components.cloud
2019-06-19 18:01:51 INFO (Thread-17) [homeassistant.loader] Loaded config from homeassistant.components.config
2019-06-19 18:01:51 INFO (Thread-10) [homeassistant.loader] Loaded conversation from homeassistant.components.conversation
2019-06-19 18:01:51 INFO (Thread-20) [homeassistant.loader] Loaded frontend from homeassistant.components.frontend
2019-06-19 18:01:51 INFO (Thread-4) [homeassistant.loader] Loaded api from homeassistant.components.api
2019-06-19 18:01:51 INFO (Thread-12) [homeassistant.loader] Loaded auth from homeassistant.components.auth
2019-06-19 18:01:51 INFO (Thread-9) [homeassistant.loader] Loaded lovelace from homeassistant.components.lovelace
2019-06-19 18:01:51 INFO (Thread-7) [homeassistant.loader] Loaded onboarding from homeassistant.components.onboarding
2019-06-19 18:01:51 INFO (Thread-8) [homeassistant.loader] Loaded system_log from homeassistant.components.system_log
2019-06-19 18:01:51 INFO (Thread-2) [homeassistant.loader] Loaded websocket_api from homeassistant.components.websocket_api
2019-06-19 18:01:51 INFO (Thread-5) [homeassistant.loader] Loaded history from homeassistant.components.history
2019-06-19 18:01:51 INFO (Thread-17) [homeassistant.loader] Loaded recorder from homeassistant.components.recorder
2019-06-19 18:01:51 INFO (Thread-10) [homeassistant.loader] Loaded logbook from homeassistant.components.logbook
2019-06-19 18:01:51 INFO (Thread-20) [homeassistant.loader] Loaded map from homeassistant.components.map
2019-06-19 18:01:51 INFO (Thread-4) [homeassistant.loader] Loaded mobile_app from homeassistant.components.mobile_app
2019-06-19 18:01:51 INFO (Thread-12) [homeassistant.loader] Loaded person from homeassistant.components.person
2019-06-19 18:01:51 INFO (Thread-9) [homeassistant.loader] Loaded ssdp from homeassistant.components.ssdp
2019-06-19 18:01:51 INFO (Thread-7) [homeassistant.loader] Loaded sun from homeassistant.components.sun
2019-06-19 18:01:51 INFO (Thread-8) [homeassistant.loader] Loaded system_health from homeassistant.components.system_health
2019-06-19 18:01:51 INFO (Thread-2) [homeassistant.loader] Loaded updater from homeassistant.components.updater
2019-06-19 18:01:51 INFO (Thread-5) [homeassistant.loader] Loaded zeroconf from homeassistant.components.zeroconf
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.bootstrap] Setting up {'system_log'}
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setting up http
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setup of domain http took 0.0 seconds.
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setting up system_log
2019-06-19 18:01:51 INFO (MainThread) [homeassistant.setup] Setup of domain system_log took 0.0 seconds.
2019-06-19 18:01:52 INFO (MainThread) [homeassistant.setup] Setting up recorder
2019-06-19 18:01:53 WARNING (Recorder) [homeassistant.components.recorder] Ended unfinished session (id=12 from 2019-06-19 17:52:57.264986)
2019-06-19 18:01:53 INFO (MainThread) [homeassistant.setup] Setup of domain recorder took 1.0 seconds.

Anyone have any ideas here?  I'll keep digging in the meantime.

Took me a minute, but I figured it out.  Homeassistant was swallowing the error (https://github.com/home-assistant/home-assistant/issues/23965), which I discovered by running hass --script check_config:
  General Errors:
    - module 'websocket' has no attribute 'WebSocketApp'```

Double-checking that `websocket-client` was installed in my python virtualenv was the key. Everything works now.


Fix broken console example.

[x] Make renderer required in ConsolePanel.IOptions.
[x] Use defaultRenderer in console example.
[x] Use correct CSS style priority in console example.

👍


Make more informations available for Tool Plugins about the editor

This PR will add new method to EditorPlugin called get_editor_tool_addons().
This method will return an object which provides api to gain more informations about current state of the editor.
For start such signals are available:
script_changed script_closed scene_changed scene_closed main_screen_changed
Each signal provides parameter with content.
And such methods:
get_open_scenes_list get_open_scripts_list get_edited_scene_root
Example usage:
tool
extends EditorPlugin

func _enter_tree():
	get_editor_tool_addons().connect("script_changed", self, "onScriptChanged");
	get_editor_tool_addons().connect("scene_changed", self, "onSceneChanged");
	get_editor_tool_addons().connect("main_screen_changed", self, "onMainScreenChanged");
	get_editor_tool_addons().connect("script_closed", self, "onScriptClosed");
	get_editor_tool_addons().connect("scene_closed", self,  "onSceneClosed");

func _exit_tree():
	get_editor_tool_addons().disconnect("script_changed", self, "onScriptChanged");
	get_editor_tool_addons().disconnect("scene_changed", self, "onSceneChanged");
	get_editor_tool_addons().disconnect("main_screen_changed", self, "onMainScreenChanged");
	get_editor_tool_addons().disconnect("script_closed", self, "onScriptClosed");
	get_editor_tool_addons().disconnect("scene_closed", self, "onSceneClosed");

func get_name():
	return "Plugin Addons Tester";

func has_main_screen():
	return false;

##################################################################################
#########                       Connected Signals                        #########
##################################################################################
func onScriptChanged(inScript):
	print("Signal: onScriptChanged: ", str(inScript.resource_path));

func onSceneChanged(inRootNode):
	print("Signal: onSceneChanged: ", str(inRootNode.get_filename()));

func onSceneClosed(inSceneFilepath):
	print("Signal: Scene closed: ", inSceneFilepath);

func onScriptClosed(inScript):
	print("Signal: Script is closed: ", str(inScript.resource_path));

func onMainScreenChanged(inNewScreenName):
	print("Signal: onMainScreenChanged: ", inNewScreenName);
	if(inNewScreenName == "3D"):
		print("Currently opened scripts: ", get_editor_tool_addons().get_open_scripts_list());
		print("Currently opened scenes: ", get_editor_tool_addons().get_open_scenes_list());
		print("Currently active scene: ", get_editor_tool_addons().get_edited_scene_root().get_filename());

I need help, not sure what I should do for this new class to be visible in help system

In Monday I will read carefully
http://docs.godotengine.org/en/stable/community/contributing/updating_the_class_reference.html
Hope this is good trace :)

(it was not)

You need to register the class in the ClassDB, most likely inside EditorNode::register_editor_types().

@vnen oh thanks! was looking for this info for some time :)

Do not merge. Changes are needed, I need to move those method and signals between ScriptEditor and EditorPlugin

Do not merge. Changes are needed, I need to move those method and signals between ScriptEditor and EditorPlugin and expose ScriptEditor in EditorPlugin.

@reduz I made requested changes, but there still is one problem. I can't expose ScriptEditor inside EditorNode::register_editor_types() since it does not have default constructor. Should I create new class inside script_editor_plugin especially for plugins called ToolScriptEditor? Or maybe it's possible somehow to register ScriptEditor after all?

you have to register using register_virtual_class
actualy, in that function, there are others that should have it, such as
EditorFileSystem, EditorFileSystemDirectory and EditorSettings

Done, as far as I know it's ready to merge now.

Question. Should it be: get_opened_scenes_list?
What is correct naming convention in Godot?

"Open Scenes" sounds right to me, like "open doors". "Opened doors" would sound like a past thing to me, so the doors may now be already closed, but were opened at least once. But I'm not a native speaker though.

"active" may be a better word may be. "open" is a verb so any form may not clearly define a state but 'active' is defining state and not a verb.

"open" is also an adjective, it's completely fine (and accurate) in this case: https://en.wiktionary.org/wiki/open#Adjective

Guess I will open new pr with small renaming:
get_opened_scripts_list -> get_open_scripts_list
get_opened_scenes_list -> get_open_scenes_list

Oops, I thought it was the proposed API already and that @n-pigeon was asking to add -ed :D

I guess you could name them get_open_scripts and get_open_scenes, in Godot's API it's quite common that get_[something_plural] means that you will get an array.

ok so open scenes and open scripts :)

Getting this error: ERROR: Type ScriptEditor already has signal: script_changed
It turns out that Object has a script_changed signal.

thx, will fix asap, it will be probably editor_script_changed


Adding work experience causes the page to go blank

When entering some data into the work experience field, clicking the "add experience" button causes the entire webpage to go blank. I have to refresh to get back into the app. Sometimes, the data I submitted is saved, sometimes it isn't.
Encountered on Chrome 85.0.4183.121

Indeed, same behavior here.
This is a severe bug as I didnt find any workaround yet...

Pretty sure this is related to #301


Refactor attribute builders from codegen to AttrVisitor

Prerequisites

[X] I have read the documentation and the proposed feature is not implemented.

Description
At the moment vast operations create attributes, however since we have AttrVisitor, we duplicate logic for attribute creation. We should extract all translations of clang::Attributes to be performed only via AttrVisitor. At the moment, this is probably only GlobalLinkageKindAttr.

Minimal example
#define weak __attribute__((__weak__))

extern "C" {
  weak void init();
}

int main() {
    init();
}

vast-front produces
 "hl.func"() ({
  }) {function_type = !core.fn<() -> (!hl.void)>, linkage = 4 : i32, sym_name = "_fini", sym_visibility = "private", weak = #unsup<attr "weak">} : () -> ()

we want to have only linkage attr and omit weak = #unsup<attr "weak">

The duplicit attributes were resolved as part of #411 but the logic wasn't moved to AttrVisitor as linkage requires more information than we can access through an attribute. I'll mark it as backlog for the case we want to revisit this in the future.


Design and security issues

Description
There should be either a character limit for the Link is For field or just display a few initial and final letters and fill the rest with ......

the URL shows linked if I change the id it shows other user's data which indicates a security vulnerability in your application.
Screenshots
No response
Additional information
No response

here is how I changed the contents of some other account just by changing the linked in the URL so I can basically access and update other person's private content

@kadambari68 Yes, it's an issue, you can work on this.
Happy Contributing!

@kadambari68  still working on this issue ??

Yes it only got delayed because I was not able to setup the project and the mentor said he had exams so it took some time I will update you in next 2 days.

@kadambari68 i just made a video on how to setup project you can check out in readme.md section

https://www.youtube.com/watch?v=L5HdDeYaKd0

@kadambari68 update ?

@apoorvaron Assign me  I will look into it and let you know

@Nishitbaria Assigned

@apoorvaron I have started working on this

Okay

@Nishitbaria not before loading , do after load and then check if valid user , if invalid user wants to edit other then redirect him to user panel's home page


Update app-insights-sample-mscrm.md

added some instructions to avoid confusion

Hi @arunvinoth, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

Thanks for the contribution, @arunvinoth!


[QA] Add georeferencing tests on the CHS reference surface

We have MBES data on the CHS reference surface. See how this compares to MBES-lib in unit-tests

One way to do this would be to define a grid on the surface. For each cell, extract a mean depth (which is relative to geoid, if I recall correctly).
Then georef with MBES-lib. Then apply the same grid and extract a mean depth for each cell (which is relative to ellipsoid).
The difference for each cell should then be the geoid separation (with possibly tide variations which can be looked up).

One way to do this would be to define a grid on the surface. For each cell, extract a mean depth (which is relative to geoid, if I recall correctly).
Then georef with MBES-lib. Then apply the same grid and extract a mean depth for each cell (which is relative to ellipsoid).
The difference for each cell should then be the geoid separation (with possibly tide variations which can be looked up).


fix(breacrumbs.ts): Fix implicit 'any' type error

Explicitly annotated the 'route' parameter with the 'RouteRecord' type

Description

Linked Issues
Additional context

Thanks!


fyi alt research from the stan group for benching ppls

Hello! fyi Stan also has a benchmark library we are working on to compare PPL performance across different models. Right now it's focus is Stan, but the tf prob and turing folks are also having a look at it. It feels like the goals are v similar here, may be good to put heads together!
https://github.com/MansMeg/posteriordb

Agreed!! Please check your email for an invite to a discussion on this with other interested folks.


SQL Timeout?

Can you add details to this content regarding the sql query timeout limits.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a9f5843-5ef0-abb8-b539-50d78d1545c8
Version Independent ID: 170e69fb-9cb7-c7e5-6b81-f8572da9217d
Content: Use reference data for lookups in Azure Stream Analytics
Content Source: articles/stream-analytics/stream-analytics-use-reference-data.md
Service: stream-analytics
GitHub Login: @JSeb225
Microsoft Alias: jeanb

Thanks for the feedback! We are currently investigating and will update you shortly.

@karl-howard I am assigning the issue to the author to have a look at the issue.
@JSeb225 Can you please have a look at this one ?

@karl-howard - can you be more specific about the questions you have about SQL query timeouts?

@sidramadoss -
The use case I had was I was trying to add a SQL reference data set and the query was approximately 60 seconds duration from SSMS but from Stream Analytics I was getting a timeout error.
What is the timeout period for the SQL reference data query?  Can this be extended?

@karl-howard - Thank you for your feedback. Azure SQL database doesn't have query timeout limits. Did you experience a timeout error from Stream Analytics?

@karl-howard - thanks for the suggestion. The timeout limit is 60 seconds and it can't be extended. I have submitted a request to update it. You will soon see it reflected in the docs.

#please-close This change has gone live on the docs site.  https://docs.microsoft.com/en-us/azure/stream-analytics/stream-analytics-use-reference-data


Add additional unit tests

Increase code coverage adding additional unit tests

To cleanup the existing unit tests. Have unit tests:

create a folder for each system
populate with blank files with expected kinds of names
programmatically use custom config for unit tests to point at these folders
verify the results

Then we will want to update project build to automatically run unit tests

I believe that every generic class of the application has some testing. The follow-on step is to finish this for all of the example systems and setups.


How to normalise a wav file with PCEN and export it as wav too ?

Hi,
I want to compare PCEN (per channel energy normalisation) to usual normalisation. I found this [example] (https://librosa.org/doc/main/generated/librosa.pcen.html) and now I want to export the normalised signal to a wav file.
y, sr = librosa.load(input_wav_file)

    # We recommend scaling y to the range [-2**31, 2**31[ before applying

    # PCEN's default parameters. Furthermore, we use power=1 to get a

    # magnitude spectrum instead of a power spectrum.

    S = librosa.feature.melspectrogram(y=y, sr=sr, power=1)

    log_S = librosa.amplitude_to_db(S, ref=np.max)

    pcen_S = librosa.pcen(S * (2**31))

   sf.write(log_filename, log_S, sr, format="wav", subtype = 'PCM_24')
   sf.write(log_filename, pcen_S, sr, format="wav", subtype = 'PCM_24')

I tried to sf.write() pcen_S variable (or even log_S) but it is nonsense since it is a spectrogram so I got output format not recognized. I could try to convert the spectrogram to audio but I already tried to convert the original S (before applying the normalisation) and the output was not good (as expected with griffin lin). But there may be a handier way to do this.
So how can I apply PCEN to an input audio wav file and export it to wav ?
Thanks in advance for your advice

You're trying to write a mel-spectrogram to a wave file. That's not going to work. Furthermore, mel-spectrograms are not invertible. You'll have to apply the normalization to your audio data. Ask librosa how to do that.

You're right ! Actually that's where I thought I was😄 ! Obviously too many tabs opened on the browser ! Sorry for this misrouting !


Hello, I cannot set the material of the picture for the cylindrical primitive

Hello, I have encountered a problem, the content is: I want to make the radius of a cylinder change dynamically. I inherited and rewritten the primitive update method, and it succeeded. But a new problem occurred: the picture material I posted on the cylinder could not be displayed normally. I don't know why, please help me find the reason, thank you very much. The code content is as follows:
function changeCylinderPrimitive(options) {
this.length = options.length;
this.topRadius = options.topRadius;
this.bottomRadius = options.bottomRadius;
}
changeCylinderPrimitive.prototype.getGeometry = function () {
return new Cesium.CylinderGeometry({
length: this.length,
topRadius: this.topRadius,
bottomRadius: this.bottomRadius
});
};
changeCylinderPrimitive.prototype.update = function (frameState) {
var geometry = this.getGeometry();
if (!geometry) {
return;
}
this._primitive = new Cesium.Primitive({
geometryInstances: new Cesium.GeometryInstance({
geometry: geometry,
}),
releaseGeometryInstances: false,
modelMatrix: Cesium.Transforms.eastNorthUpToFixedFrame(Cesium.Cartesian3.fromDegrees(-90,20,500)),
appearance: new Cesium.MaterialAppearance({
material: new Cesium.Material({
fabric: {
type: 'Image',
uniforms: {
image: './data/circle.png',
},
}
}),
faceForward: true
})
});
var primitive=this._primitive
primitive.update(frameState);
};
var pr=new changeCylinderPrimitive({
length: 500,
topRadius: 1000,
bottomRadius: 1000
})
viewer.scene.primitives.add(pr)

Hi @kk1625846601, thanks for your question! Since this isn't a bug or feature request, please open a thread on our community forum (https://community.cesium.com/) and continue the discussion there - more users are likely to see your post there and might be able to help.

Hi @kk1625846601, thanks for your question! Since this isn't a bug or feature request, please open a thread on our community forum (https://community.cesium.com/) and continue the discussion there - more users are likely to see your post there and might be able to help.

Thank you very much.I will try it.


Expand Trino docs to include more detailed instructions

It would be great to update the Trino docs to include more precise and detailed setup instructions, including:

launching UC before Trino to make sure we're using port 8080, see #739
including iceberg.rest-catalog.warehouse=unity property, see #740
example workflows similar to Apache Spark guide

take


bug fix: collection.count() with hasMany relationship properly constrained

collection.count() calls were not preserving relations constraints on hasMany relationships.
For example, the following was counting all records from related table, not just those related by foreign key:
Blog.forge({id: someId}).posts().count();

This has been corrected in the src/sync.js class. The constrain function was being called for both Sync#select and Sync#count calls, but was only taking into account through relations.
The constrain function has been removed and the logic within has be separated out into Sync#select and Sync#count as they have slightly different requirements.
Also, some integration tests were updated as they were reporting false positives.
Please refer to issue #126 for more information.

Hey mate, thanks for this. Merging now. :+1:

Woo! Happy to help :)


[Bug] Cannot use copy/paste with mouse into Wallet Connect dialog box

What happened?
Wallet Connect Integration: Add connection feature is not allowing me to paste link * I have to use keyboard short cut and the drop down for Select Keys isn't functioning either.
Version
2.1.4
What platform are you using?
Windows
What ui mode are you using?
GUI
Relevant log output
No response

I'd like to confirm one thing. What do you mean copy/paste by mouse?
Did you expect that right clicking on text inputs shows context menu with copy/paste menu item?

@JE2530 - Did you see the question above? Please provide more detail. Are you trying to use the context menu or are you trying to paste with the middle button under linux?

@ChiaMineJP - There are two separate things reported:

Context menu for paste in text input - Currently we do not  support context menu for paste in any text input so let's hold off on this for now.

Drop down for Select Keys isn't functioning - Can we confirm this? If that is the case we should fix it.

Ok, I'll check 2.

https://github.com/Chia-Network/chia-blockchain-gui/assets/84098616/78f98aa5-ad2f-496d-92c7-236b23e40a63
Select keys seems working fine.
Did you try the latest version(2.4.1)?

JE2530: Can u try with 2.4.2 and leave a video showing the issue if u still have problems?

@JE2530 - We are closing this issue since we have not received more info from you. Based on our investigation:

Select Keys appears to work fine on latest version
Context menu for paste in text input is not going to be added at this point

Thank you

On 07/24/2024 11:08 AM CDT Mark Elrod @.***> wrote:
@JE2530 https://github.com/JE2530 - We are closing this issue since we have not received more info from you. Based on our investigation:

Select Keys appears to work fine on latest version
Context menu for paste in text input is not going to be added at this point

—
Reply to this email directly, view it on GitHub https://github.com/Chia-Network/chia-blockchain-gui/issues/2267#issuecomment-2248399388, or unsubscribe https://github.com/notifications/unsubscribe-auth/BANANXRIYQPG4ZTQ6UTENG3ZN7GOXAVCNFSM6AAAAABC6GKYCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGM4TSMZYHA.
You are receiving this because you were mentioned.Message ID: @.***>


SkSL warmup on add-to-app approach

Flutter Doc for Shader Pre-compilation
https://flutter.dev/docs/perf/rendering/shader#how-to-use-sksl-warmup
I would like to use the SkSl shader pre-compilation in add-to-app approach.
Want to use it with both aar and frameworks.
Is there a way to do it already ?
wasn't able to find in the doc or is that not possible for now ?

There is nothing special about the data from these training runs. The data is just a JSON file. As long as the JSON file from the training run is present in the Flutter assets directory, the engine ought to be able to load the shaders from it at runtime.
@blasten: I am not sure how the AAR is constructed or what is in it. Can you confirm if the flutter_assets directory is packaged as is?

The build command for ios-framework does not have the option to pass in the shader json file

When build flutter only ios app using non-add-to-app approach
flutter build ios --bundle-sksl-path flutter_01.sksl.json
then it works and the following file is added like this in the flutter_assets directory
Runner.app/Frameworks/App.framework/flutter_assets/io.flutter.shader.json
along with this a reference to this path is also there in the CodeResources file as shown in the last attached image

As long as the JSON file from the training run is present in the Flutter assets directory, the engine ought to be able to load the shaders from it at runtime

@chinmaygarde
now the issue is even if we add the generated io.flutter.shader.json file manually to flutter_assets directory after building frameworks it does not help with the improvement of performance which means it not picked up automatically at runtime

@Hixie Do you maybe know if that is possible? I'm currently having the same problem, that the flutter build ios-framework does not accept the sksl flag

@lukaszdebowski I'm not the right person to ping here. However, if you would like to submit a PR, this seems like something that should be relatively easy to implement by analogy with the existing implementations on other platforms.

any updates on this ?

any updates on this ? x2

any updates on this ? x3.

Impeller is now the default rendering engine on iOS re SkSl warmup.  Closing.


Add GHA comment commands for porting

These GHA commands allow us to create comments like:

/backport release/4.0
/forwardport release/5.0
/backport v2.8.next1

Where when it's on a PR you should provide a specific branch on this repo and it will create a new PR based on it targeting the new branch. And when it's an Issue it will create a new issue to track porting it to the tagged rancher release name.

Would be neat to review and merge this one first - then test it on #480 since I want to see that backported to 2.8 too.

Looks like I need to follow up here for 2 issues:

Both workflows triggering resulting in 2 comments.
Workflow cannot parse branches with / in the correctly;

errors about release/v4.0 being parsed as releasev4.0


[BUG]:Comment out duplicate entries in the sample secret.yaml file

The sample secret.yaml file is below. As as user I find it very confusing to include this extra stanza at the bottom:
nasName: "nas-server"

username: "admin"
password: "Password123"
systemID: "2b11bb111111bb1b"
endpoint: "https://<IP_ADDRESS>"
skipCertificateValidation: true
mdm: "<IP_ADDRESS>,<IP_ADDRESS>"

The problem is that all these entries are already present, and uncommented, in the top of the file. If you do not notice that, your CSI install will fail because it adds a non-existent PowerFlex setup. I suggest commenting all entries at the top, which explain what each variable is, and just leaving the bottom stanza. In addition, a comment can be added that if you have multiple systems you can add another stanza.
Username for accessing PowerFlex system.
If authorization is enabled, username will be ignored.

username: "admin"
Password for accessing PowerFlex system.
If authorization is enabled, password will be ignored.
password: "password"
System name/ID of PowerFlex system.
systemID: "1a99aa999999aa9a"
Previous names used in secret of PowerFlex system.
allSystemNames: "pflex-1,pflex-2"
REST API gateway HTTPS endpoint for PowerFlex system.
If authorization is enabled, endpoint should be the HTTPS localhost endpoint that
the authorization sidecar will listen on
endpoint: "https://<IP_ADDRESS>"
Determines if the driver is going to validate certs while connecting to PowerFlex REST API interface.
Allowed values: true or false
Default value: true
skipCertificateValidation: true
indicates if this array is the default array
needed for backwards compatibility
only one array is allowed to have this set to true
Default value: false
isDefault: true
defines the MDM(s) that SDC should register with on start.
Allowed values:  a list of IP addresses or hostnames separated by comma.
Default value: none
mdm: "<IP_ADDRESS>,<IP_ADDRESS>"
NFS is only supported on PowerFlex storage system 4.0.x
nasName: name of NAS server used for NFS volumes
nasName value must be specified in secret for performing NFS (file) operations.
Allowed Values: string
Default Value: "none"
nasName: "nas-server"
username: "admin"
password: "Password123"
systemID: "2b11bb111111bb1b"
endpoint: "https://<IP_ADDRESS>"
skipCertificateValidation: true
mdm: "<IP_ADDRESS>,<IP_ADDRESS>"

/sync

/sync


Make possible preview greet and bye messages with embed codes.

Send them with some command (actually the .greetmsg and .byemsg). It does this, but we receive the embed code without the actual preview.

Use quotes/custom reactions to test them. We need json when previewing to be able to edit.