Ensure VmService instance is disposed after failed direct connection attempt

_attemptServiceConnection in FallbackDiscovery would fail if the root
library URI was not a package URI even if the VM service connection
attempt was successful. This resulted in a VM service connection being
left alive, causing DDS to fail its connection to the VM service.
Updated _attemptServiceConnection to ensure the VM service instance is
disposed after a non-connection related failure and to allow for root
library URIs with a file scheme.
Fixes the failure described in https://github.com/flutter/flutter/pull/65873#issuecomment-694657423 (cc/ @liyuqian).

LGTM to land on red to fix build

@bkonyi : thanks for the quick fix! However, flutter_gallery_sksl_warmup__transition_perf_e2e_ios32 is still failing after this PR with a different error as below. Do you have an iPhone 4s to test it locally?
2020-09-18T15:18:18.148876: run stdout: [+1826 ms] Service protocol connection closed.
2020-09-18T15:18:18.149260: run stdout: [        ] Lost connection to device.
2020-09-18T15:18:18.154159: run stdout: [   +3 ms] "flutter run" took 160,023ms.
2020-09-18T15:18:18.157205: run stdout: [   +4 ms] ensureAnalyticsSent: 0ms
2020-09-18T15:18:18.157932: run stdout: [        ] Running shutdown hooks
2020-09-18T15:18:18.158114: run stdout: [        ] Shutdown hook priority 4
2020-09-18T15:18:18.159052: run stdout: [        ] Shutdown hooks complete
2020-09-18T15:18:18.159783: stderr: [+33504 ms] Unhandled exception:
stderr: [        ] DriverError: Failed to fulfill RequestData due to remote error
2020-09-18T15:18:18.159959: stderr: [        ] Original error: JSON-RPC error -32000: Bad state: The client closed with pending request "ext.flutter.driver".
stderr: [        ] Original stack trace:
2020-09-18T15:18:18.160174: stderr: [        ] package:json_rpc_2/src/client.dart 123:62                       Client.sendRequest
stderr: [        ] package:json_rpc_2/src/peer.dart 98:15                          Peer.sendRequest
2020-09-18T15:18:18.160411: stderr: [        ] package:vm_service_client/src/scope.dart 64:23                  Scope.sendRequestRaw
stderr: [        ] package:vm_service_client/src/isolate.dart 361:19               VMIsolateRef.invokeExtension
2020-09-18T15:18:18.160573: stderr: [        ] package:flutter_driver/src/driver/vmservice_driver.dart 348:63  VMServiceFlutterDriver.sendCommand
stderr: [        ] package:flutter_driver/src/driver/driver.dart 503:45            FlutterDriver.requestData
2020-09-18T15:18:18.160726: stderr: [        ] package:e2e/e2e_driver.dart 73:42                               e2eDriver
2020-09-18T15:18:18.160868: stderr: [        ] ===== asynchronous gap ===========================
2020-09-18T15:18:18.162178: stderr: [        ] test_driver/transitions_perf_e2e_test.dart 7:24                 main
stderr: [        ] dart:isolate-patch/isolate_patch.dart 301:19                    _startIsolate.<fn>
stderr: [        ] dart:isolate-patch/isolate_patch.dart 168:12                    _RawReceivePortImpl._handleMessage
stderr: [        ] #0      VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:359:7)
stderr: [        ] <asynchronous suspension>
stderr: [        ] #1      FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:503:45)
stderr: [        ] #2      e2eDriver (package:e2e/e2e_driver.dart:73:42)
stderr: [        ] <asynchronous suspension>
stderr: [        ] #3      main (file:///Users/flutter/.cocoon/flutter/dev/integration_tests/flutter_gallery/test_driver/transitions_perf_e2e_test.dart:7:24)
stderr: [        ] #4      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:301:19)
2020-09-18T15:18:18.162387: run stdout: [   +2 ms] exiting with code 0
stderr: [        ] #5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)
2020-09-18T15:18:18.177430: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 0
2020-09-18T15:18:18.197895: stdout: [  +35 ms] Leaving the application running.
2020-09-18T15:18:18.207181: stdout: [   +9 ms] "flutter drive" took 38,350ms.
2020-09-18T15:18:18.210885: stderr: [   +3 ms] Driver tests failed: 255
2020-09-18T15:18:18.211303: stderr: [        ]
stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
stderr:            #1      _runTests (package:flutter_tools/src/commands/drive.dart:530:5)
stderr:            <asynchronous suspension>
stderr:            #2      DriveCommand.runCommand (package:flutter_tools/src/commands/drive.dart:324:23)
stderr:            #3      _rootRunUnary (dart:async/zone.dart:1198:47)
stderr:            #4      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
stderr:            #5      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
stderr:            #6      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
stderr:            #7      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
stderr:            #8      Future._completeWithValue (dart:async/future_impl.dart:529:5)
stderr:            #9      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:567:7)
stderr:            #10     _rootRun (dart:async/zone.dart:1190:13)
stderr:            #11     _CustomZone.run (dart:async/zone.dart:1093:19)
stderr:            #12     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
stderr:            #13     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
stderr:            #14     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
stderr:            #15     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
stderr:            #16     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
stderr:            #17     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
stderr:
stderr:
2020-09-18T15:18:18.212539: stdout: [   +1 ms] ensureAnalyticsSent: 0ms
2020-09-18T15:18:18.213784: stdout: [   +1 ms] Running shutdown hooks
2020-09-18T15:18:18.213939: stdout: [        ] Shutdown hooks complete
2020-09-18T15:18:18.214358: stdout: [        ] exiting with code 255
2020-09-18T15:18:18.224387: "/Users/flutter/.cocoon/flutter/bin/flutter" exit code: 255
2020-09-18T15:18:18.230813: Task failed: Executable "/Users/flutter/.cocoon/flutter/bin/flutter" failed with exit code 255.2020-09-18T15:18:18.231085:

flutter_gallery_sksl_warmup__transition_perf_e2e_ios32_e00b153_1.log

@liyuqian no, I don't have an iPhone 4S. I'm guessing this needs to run on a 32-bit device?

Filed https://github.com/flutter/flutter/issues/66162, let's revert this.

Although I guess another test will fail?

The test that this was intended to fix is still failing, and has caused another test to fail, so I think this should be reverted.

The revert didn't help. I have filed an infra ticket here: https://github.com/flutter/flutter/issues/66166


doc: fix possible copy&paste error in cumprod docs

Can one of the admins verify this patch?

I signed it!

Sorry, the docs are auto-generated. Please fix this upstream in tensorflow/python/ops/math_ops.py.


[Feature Request] Support for Autocomplete Tags inside Text Field

Hello @tadashi-aikawa !!!!!!!!
I know that sounds weird, but let me try to explain this FR and how I think this might be feasible
Following what FR #19 means, my FR is to be able to autocomplete tags when using # in the query field inside AQS modal
MY FR
My FR is about be able to trigger the Obsidian autocomplete tag menu context when I type # in text field that is inside the AQS Modal.
📸 AQS Modal

📸 Obsidian Autocomplete Tags Menu Context

Eureka Moment
In my mind, I will never thought that this would be feasible
But I had this Eureka moment when I was using QuickAdd plugin
📹 Look at this ...
https://user-images.githubusercontent.com/85180696/185411337-17007780-55cc-41cd-a4c2-eac109cbbc98.MOV
On QuickAdd is possible to trigger the autocomplete menu from a text field that is inside a Modal 😳😳😳
I don't know if is a bug or not but this behavior gives the idea that we could get the same behavior on AQS 🙏

Thanks for reading this !!!!! I hope you like my suggestion 🙏 🙏 🙏
Let me know if you need more information !!!
Have a great day 🌞

Thank you for your FR, @FelipeRearden :)
I don't know whether or not we can in the case of "Quick switcher", and how many people need it. So let me set the status of this issue, gathering interests.

Hello @tadashi-aikawa !!!!

I don't know whether or not we can in the case of "Quick switcher",

Yeah, I have some doubts too if we can apply the same behavior that I showed to you on AQS Modal :)

and how many people need it. So let me set the status of this issue, gathering interests.

100% agree. Since we a have new version with a lot of new features, lets see how our friends felt about this issue.
Since I have a lot of tags and now I create a new Custom Search where now it estremely easy to search for Notes using ONLY tags (cross reference -> #tag1 #tag2 #tag3) I felt a need to have an autocomplete :)
Thanks again !!! Have a great day!!!!


Remove implicit directory creation when creating a local db

remove Mkdir from NewLocalStore and NewLocalStoreFactory
add specific error messages for directory does not exist and path is not a directory
add tests for missing directory and path not directory

fixes: #3222

Seeing the same tests (TestScalars) fail on master, so assuming this PR doesn't break them. However, I believe this approach may be the wrong one after digging in to the use case a bit - we don't want to prevent this mkdir, but rather the resolver one. Closing.

Did you mean to close this?

Oh duh, sorry didn't read your comment carefully enough.

@aboodman Yeah, I either failed to build correctly or failed to fix the issue at the right place in the stack, figured I'd close it until later when I can verify the fix! Let me know if you'd prefer it to stay open and/or if you'd like to verify on your side! Go is new to me, so mostly working through the build process - the tests and code were easy enough to read though!

Heh - was just missing go install, this is working as expected. Reopening, ready for review.

To @cmasone-attic for review.
When I patch this into my client and do noms ds foo, noms prints a stack trace. Ideally, I would like it to print a nice error message instead with no stack trace.
@cmasone-attic if you can recommend an easy way to do this, let's do it in this patch. Otherwise, this is already a fine improvement.

(thanks @jesseditson!)

Oh, actually this is causing TestNomsCommitDuplicate to fail. You can replicate this by doing:
cd <nomsroot>/cmd/noms
go test ./...

You should also test the entire go tree:
cd <nomsroot>/go
go test ./...

@aboodman Ah cool! Couldn't see the failures on my end, but had a failure locally on both master and this branch, so just assumed it was the same.
Makes sense about the stack trace! I'll move it to a normal panic

I added you to be a collaborator of this project just now. I think that when you accept, you'll be able to see the errors from the bots.
Looking at this code, I think that the right thing to do is that the various noms command should be "catching" this sort of error using d.TryCatch (https://github.com/attic-labs/noms/blob/master/go/d/try.go#L76).
But that would require updating lots of call sites, so I think we should do that in a different patch.

Looks like jenkins is hungry for more permissions, here's what it looks like on my end:

RE: Try/Catch - is the motivation there is to avoid embedding the user-facing message that deep? If the message is ok where it is, it seems like just using panic directly might be a simpler path, but obviously I have very little context.

Hm, I tried pushing some more buttons. What does jenkins say now?
Re: try/catch. panic() won't help -- I may be misunderstanding, but what
I'm trying to do is prevent commands like noms ds <not-a-dir> from
dumping a stack.
Switching d.PanicIfError to panic won't help because panic is what's
causing the stack trace. In order to stop it, we need to either (a) not
panic in the first place (e.g., return the error up the call stack
manually), or else (b) catch the panic high up in the call stack (like in
the noms command) and print out a friendly error instead.
d.TryCatch and d.PanicIfError are designed to be used together to
facilitate solution (b). But the code in the command is not using
d.TryCatch so it's not working with your patch.
Put another way, your patch is a step toward fixing this, but another step
is required: all the noms commands need to wrap their calls to Noms in
d.TryCatch and print out a friendly error message in the Catch function.
But this second step is a lot more work, so I think we should save it for a
separate patch.
On Tue, Feb 28, 2017 at 5:07 PM, Jesse Ditson<EMAIL_ADDRESS>wrote:

Looks like jenkins is hungry for more permissions, here's what it looks
like on my end:
https://camo.githubusercontent.com/9361e4fef6a3e58b0d5979b4bad6e060c94f63ac/687474703a2f2f6f692e707866782e696f2f3378303531793372323030572f496d616765253230323031372d30322d32382532306174253230352e30332e3035253230504d2e706e67
RE: Try/Catch - is the motivation there is to avoid embedding the
user-facing message that deep? If the message is ok where it is, it seems
like just using panic directly might be a simpler path, but obviously I
have very little context.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/attic-labs/noms/pull/3235#issuecomment-283212703, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE6BByri3xW6x52STJAYVN4KYlti4cXks5rhMTZgaJpZM4MO1nr
.

Ah, I must be misunderstanding the purpose of d.Wrap - I assumed that was there purely to add the trace, and that panic would just print and exit. I'm sure the real reason differs.
Totally makes sense now!
Wondering if Jenkins is not letting me see it because this commit was before I had access? I'll push an update in a sec and see if I can see the test results.

Still seeing the two failing tests locally (TestScalars, TestQueryGraphQL), but this latest update should get cmd/noms test back to where they should be!

Unfortunately still can't see test results, so LMK how that goes!

How are you running the tests?
You need to make sure that you do not run the tests under vendor.

I've been running go test ./... - but I also tried go test $(go list ./... | grep -v /vendor/), with the same results!

(this is from inside go - tests inside cmd/noms pass happily now)

Are you sure that TestScalars and TestQueryGraphQL fail without your change? They pass locally for me, and they seem to be passing on the bots.
If they are failing locally, can you please show an example of one failing?

I'll verify!

Still seeing failures on master :(

Here's the trace:
# (prompt)  ~/go/src/github.com/attic-labs/noms/go [master*]
$ go test $(go list ./... | grep -v /vendor/)
ok  	github.com/attic-labs/noms/go/chunks	0.026s
ok  	github.com/attic-labs/noms/go/config	0.040s
?   	github.com/attic-labs/noms/go/constants	[no test files]
ok  	github.com/attic-labs/noms/go/d	0.021s
ok  	github.com/attic-labs/noms/go/datas	0.893s
ok  	github.com/attic-labs/noms/go/diff	0.088s
ok  	github.com/attic-labs/noms/go/hash	0.016s
ok  	github.com/attic-labs/noms/go/marshal	0.034s
ok  	github.com/attic-labs/noms/go/merge	0.059s
ok  	github.com/attic-labs/noms/go/migration	0.096s
ok  	github.com/attic-labs/noms/go/nbs	2.039s
?   	github.com/attic-labs/noms/go/nbs/benchmarks	[no test files]
?   	github.com/attic-labs/noms/go/nbs/benchmarks/cachedrop	[no test files]
?   	github.com/attic-labs/noms/go/nbs/benchmarks/chunker	[no test files]
?   	github.com/attic-labs/noms/go/nbs/benchmarks/gen	[no test files]
?   	github.com/attic-labs/noms/go/nbs/frag	[no test files]
?   	github.com/attic-labs/noms/go/nbs/test	[no test files]
--- FAIL: TestScalars (0.00s)
      Error Trace:    query_test.go:35
  		query_test.go:45
  Error:  	Not equal: "{\"data\":{\"root\":2.147483648e+09}}\n" (expected)
  		        != "{\"data\":{\"root\":2147483648}}\n" (actual)

      Error Trace:    query_test.go:35
  		query_test.go:46
  Error:  	Not equal: "{\"data\":{\"root\":-2.147483648e+09}}\n" (expected)
  		        != "{\"data\":{\"root\":-2147483648}}\n" (actual)

      Error Trace:    query_test.go:35
  		query_test.go:48
  Error:  	Not equal: "{\"data\":{\"root\":1e-08}}\n" (expected)
  		        != "{\"data\":{\"root\":1e-8}}\n" (actual)

--- FAIL: TestQueryGraphQL (0.06s)
FAIL
FAIL	github.com/attic-labs/noms/go/ngql	0.092s
?   	github.com/attic-labs/noms/go/perf/codec-perf-rig	[no test files]
?   	github.com/attic-labs/noms/go/perf/hash-perf-rig	[no test files]
ok  	github.com/attic-labs/noms/go/perf/suite	3.098s
ok  	github.com/attic-labs/noms/go/spec	0.110s
ok  	github.com/attic-labs/noms/go/types	12.730s
ok  	github.com/attic-labs/noms/go/types/perf	0.016s
?   	github.com/attic-labs/noms/go/util/clienttest	[no test files]
ok  	github.com/attic-labs/noms/go/util/datetime	0.022s
?   	github.com/attic-labs/noms/go/util/exit	[no test files]
ok  	github.com/attic-labs/noms/go/util/functions	0.015s
?   	github.com/attic-labs/noms/go/util/integrationtest	[no test files]
ok  	github.com/attic-labs/noms/go/util/jsontonoms	0.026s
?   	github.com/attic-labs/noms/go/util/math	[no test files]
?   	github.com/attic-labs/noms/go/util/outputpager	[no test files]
?   	github.com/attic-labs/noms/go/util/profile	[no test files]
?   	github.com/attic-labs/noms/go/util/progressreader	[no test files]
ok  	github.com/attic-labs/noms/go/util/random	0.025s
ok  	github.com/attic-labs/noms/go/util/sizecache	0.022s
?   	github.com/attic-labs/noms/go/util/status	[no test files]
?   	github.com/attic-labs/noms/go/util/test	[no test files]
?   	github.com/attic-labs/noms/go/util/verbose	[no test files]
ok  	github.com/attic-labs/noms/go/util/writers	0.022s

I can replicate those failures in Go 1.8. Looks like something changed between Go 1.7 and 1.8.

TestCSVImporterFromBlob now fails thusly:
panic(0xb03f00, 0xc4204d8d40)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
testing.tRunner.func1(0xc42008a180)
	/usr/local/go/src/testing/testing.go:579 +0x25d
panic(0xb03f00, 0xc4204d8d40)
	/usr/local/go/src/runtime/panic.go:458 +0x243
github.com/attic-labs/noms/go/d.PanicIfError(0xf14260, 0xc4204e0e40)
	/var/workspace/src/github.com/attic-labs/noms/go/d/try.go:44 +0x74
github.com/attic-labs/noms/go/nbs.newLocalStore(0xc42016d340, 0x19, 0x800000, 0xc420028a00, 0x80, 0xc42003a818)
	/var/workspace/src/github.com/attic-labs/noms/go/nbs/store.go:145 +0x68
github.com/attic-labs/noms/go/nbs.NewLocalStore(0xc42016d340, 0x19, 0x800000, 0xc4204e0e20)
	/var/workspace/src/github.com/attic-labs/noms/go/nbs/store.go:140 +0x70
github.com/attic-labs/noms/samples/go/csv/csv-import.(*testSuite).TestCSVImporterFromBlob.func1.1(0xad7960, 0xc4204e0e20)
	/var/workspace/src/github.com/attic-labs/noms/samples/go/csv/csv-import/importer_test.go:127 +0x40
github.com/attic-labs/noms/samples/go/csv/csv-import.(*testSuite).TestCSVImporterFromBlob.func1(0xb7e6ba, 0x6)
	/var/workspace/src/github.com/attic-labs/noms/samples/go/csv/csv-import/importer_test.go:131 +0xc7
github.com/attic-labs/noms/samples/go/csv/csv-import.(*testSuite).TestCSVImporterFromBlob(0xc4200175c0)
	/var/workspace/src/github.com/attic-labs/noms/samples/go/csv/csv-import/importer_test.go:151 +0x5c
reflect.Value.call(0xc42022b6e0, 0xc420028840, 0x13, 0xb7da73, 0x4, 0xc42044df40, 0x1, 0x1, 0x5b63f8, 0xb792a0, ...)
	/usr/local/go/src/reflect/value.go:434 +0x5c8
reflect.Value.Call(0xc42022b6e0, 0xc420028840, 0x13, 0xc42044df40, 0x1, 0x1, 0xc42002ac00, 0x0, 0xf8)
	/usr/local/go/src/reflect/value.go:302 +0xa4
github.com/attic-labs/noms/vendor/github.com/attic-labs/testify/suite.Run.func2(0xc42008a180)
	/var/workspace/src/github.com/attic-labs/noms/vendor/github.com/attic-labs/testify/suite/suite.go:95 +0x1cb
testing.tRunner(0xc42008a180, 0xc420331ab0)
	/usr/local/go/src/testing/testing.go:610 +0x81
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:646 +0x2ec

So Go 1.8 changed the JSON output. I'll update the tests to not care about the exact output...

@cmasone-attic feedback addressed - also rebased against master! Not sure which tests are failing in CI, let me know if any of those are things I can address!

The failure remains the one I indicated above, with the stack trace above. it's in samples/go/csv/csv-import/importer_test.go

Ah, I understand now! Thought you were responding to Aaron up there. Fixed up that test. Also realized why the recommended test command omits vendor - I had been running go test in the subdirs, not the root. I'll run all the suites when testing from now on!

Codecov Report

Merging #3235 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted Files
Coverage Δ

go/spec/spec.go
82.91% <100%> (+0.1%)
:white_check_mark:

go/nbs/store.go
73.03% <88.88%> (+0.95%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3a972...600e46e. Read the comment docs.

Thanks @jesseditson !

My pleasure! Sorry about the rocky start, but sure was fun getting my hands dirty with some golang. What an enjoyable language.


Load SwiftDate.bundle without specific bundle identifier.

Swift 2.3 version of #246

Fixed in SwiftDate 4. Thanks!


What is Base-8 Hex

Hex means base 16, so base 16 hex makes sense...

Thanks for the heads up! - I must've missed it.


Close jupyter notebook command does not work in notebooks within a book.

The close jupyter notebook command does not work in notebooks within a book.

Azure Data Studio Version:
Version: 1.25.2
Commit: 4d4917d328ab7a7526817a0f0ef03237a79aa54d
Date: 2021-01-20T22:47:41.882Z
VS Code: 1.48.0
Electron: 9.3.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.2.0
Steps to Reproduce:

Open a book, right click "Close Jupyter Notebook".
It doesn't do anything.

Feature request:
Replace command for remove notebook which removes the notebook from the toc.yml.

@barbaravaldez can I assume that this isn't new behavior?

@barbaravaldez can I assume that this isn't new behavior?

@barbaravaldez can I assume that this isn't new behavior?

It's not new.

@barbaravaldez can I assume that this isn't new behavior?

It's not new.


Fix useSwarmUi Test with Mock Timers

Use mock timers in the useSwarmUi test to avoid false test failures
Remove the dependency on waitFor in favor of runAllTimersAsync

Nice!


Typo fixes

@pshenoy-uc please merge this

Merged
On Fri, 19 Aug 2022 at 10:24 PM, akshay-uc @.***> wrote:

@pshenoy-uc https://github.com/pshenoy-uc please merge this
—
Reply to this email directly, view it on GitHub
https://github.com/UniCourt/Analytics-Workshop1/pull/5#issuecomment-1220888950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJDG5CTODQ6M5TKZM2UU2DVZ632XANCNFSM57BKMBSA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks,
Prashanth Shenoy
Director
Mangalore Infotech Solutions (P) Ltd
http://mangaloreinfotech.in
Phone: +91-824-2423240
Cell: +91-9482882520


Question : Warm-up: numpy

When you compute loss, why don't you divide by a batch size to get mean squared error?

You explained it under PyTorch: nn section.


PDF annotation support

Hello, it will be great if you add support for PDF annotation - such that both text & coordinates could be exported.
P.S. Thanks for the wonderful project.

@maiiabocharova You can convert PDF pages to JPGs and import them to LS. Then use OCR template:
https://labelstud.io/templates/optical_character_recognition.html


bring all libraries up to date

no further information

updated all libs from dependabot. other libs will be targeted later


Android: Why fetching 20 addresses?

According to API, recommended is 1-5, but in this packager/api was hard - coded as 20. So may not get proper results ...
package API Code:
List<Address> addresses = geocoder.getFromLocation(position.getDouble("lat"), position.getDouble("lng"), 20);
It should be like
List<Address> addresses = geocoder.getFromLocation(position.getDouble("lat"), position.getDouble("lng"), 2);
OR
Give an option to user, so user can pass that value.
Hope you understood, what i am trying to explain..

Fixed in timwangdev/react-native-geocoder-reborn, now it only fetches 2 results.

@timwangdev Thanks  for update. However, If control is given to user (who uses Geo code) to pass the noOfAddress would be a better idea. If nothing is passed you can default to 2 ..

@sanjeevraolade The iOS equivalent method CLGeocoder reverseGeocodeLocation don’t have simliar option to limit results. While in the most use cases only first object in the list would be used, since it is sorted by relevance by default.
Could you share the cases why number of address would be used?


[SEASK-107] CodeQL Security Scan Pull request build is failing in Starter-Kit-SEA-Modernization repo

The request build fails when calling dotnet test after CodeQL has been initialized.  The same call to dotnet test runs successfully when CodeQL initialization has not been executed.  Since running tests is not really required for a CodeQL scan and the issue seems to be due to an environment/context change that CodeQL makes, I simply made running tests via build.ps1 optional and skip if for CodeQL scans.  All other github action workflows that call build.ps1 still execute tests and do not appear to have any issue.


[pthreads] Build error

Package: pthreads[core]:x64-windows -> 3.0.0#14
Host Environment

Host: x64-windows
Compiler: MSVC 19.29.30148.0
vcpkg-tool version: 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895
vcpkg-scripts version: 662dbb50e 2023-06-02 (10 hours ago)

To Reproduce
vcpkg install pthreads:x64-windows
Failure logs
-- Using cached pthreads4w-code-v3.0.0.zip.
-- Cleaning sources at C:/Users/user/Code/vcpkg/buildtrees/pthreads/src/49e541b66c-a9b0a36b2a.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/user/Code/vcpkg/downloads/pthreads4w-code-v3.0.0.zip
-- Applying patch fix-arm-macro.patch
-- Applying patch fix-arm64-version_rc.patch
-- Applying patch fix-pthread_getname_np.patch
-- Applying patch fix-install.patch
-- Applying patch whitespace_in_path.patch
-- Applying patch use-md.patch
-- Using source at C:/Users/user/Code/vcpkg/buildtrees/pthreads/src/49e541b66c-a9b0a36b2a.clean
-- Found external ninja('1.10.2').
-- Getting CMake variables for x64-windows
-- Building and installing x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: "C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/nmake.exe" /NOLOGO /G /U /F Makefile all install INSTALLDIR=C:\\Users\\user\\Code\\vcpkg\\packages\\pthreads_x64-windows\\debug DESTROOT=C:\\Users\\user\\Code\\vcpkg\\packages\\pthreads_x64-windows\\debug
    Working Directory: C:/Users/user/Code/vcpkg/buildtrees/pthreads/x64-windows-dbg
    See logs for more information:
      C:\Users\user\Code\vcpkg\buildtrees\pthreads\install-x64-windows-dbg-out.log
      C:\Users\user\Code\vcpkg\buildtrees\pthreads\install-x64-windows-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_nmake.cmake:156 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_nmake.cmake:52 (vcpkg_build_nmake)
  ports/pthreads/portfile.cmake:45 (vcpkg_install_nmake)
  scripts/ports.cmake:147 (include)

C:\Users\user\Code\vcpkg\buildtrees\pthreads\install-x64-windows-dbg-out.log
Included: common.mk
	"C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\nmake.exe" /E clean VC-debug

C:\Users\user\Code\vcpkg\buildtrees\pthreads\install-x64-windows-dbg-err.log

Microsoft (R) Program Maintenance Utility Version 14.29.30148.0
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1073: don't know how to make 'clean'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\nmake.exe"' : return code '0x2'
Stop.

Additional context
Might be related to https://github.com/microsoft/vcpkg/issues/30988

@savchenko, we can't repro this issue locally, could you repair visual studio and try again?


Change the tests to use tokio

Description
Change the code to use Tokio.
This allows cucumber to show a step by step execution.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Chore (miscellaneous changes e.g. modifying .gitignore)
[ ] Build (Affect build components like build tool, ci pipeline, dependencies, project version)
[ ] Docs (documentation update)

How Has This Been Tested?
Tested using current binaries.

Don't need all functions to be async? Or do you only need those that have sleep


Problem in executing internals of a class

#I have a scala class, whenever I write in the Jupyter Scala Notebook and execute it, it always shows
defined class class name
It doesn't executes internals of it, there are  a lot of function execution inside it, but it does not show nay output.
Please help.

More a question than an issue... Ask on Gitter maybe?


fix: rewrite of splitAtDelimiters.js -- new fix for #2523

Resolves #2523 as well as other related auto-render problems (mentioned in the comments of the issue).
The text is only parsed once for all delimiters at once (this is presumably faster than the old, sequential way).
Everything works fine now according to my limited testing, but this is not my project so probably requires more testing.

oh yeah, I might need to update the tests. not sure what the semantic stuff is about.

Codecov Report

Merging #2679 (f0b365e) into master (9e91bd0) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
- Coverage   93.85%   93.85%   -0.01%
==========================================
  Files          86       86
  Lines        6172     6168       -4
  Branches     1264     1265       +1
==========================================
- Hits         5793     5789       -4
  Misses        348      348
  Partials       31       31

Impacted Files
Coverage Δ

contrib/auto-render/auto-render.js
72.00% <33.33%> (-3.44%)
:arrow_down:

contrib/auto-render/splitAtDelimiters.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e91bd0...f0b365e. Read the comment docs.

@pzinn the semantic stuff is referring to the formatting of use of semantic-release to help with publishing releases.  It looks for specific strings in the PR title when deciding how to bump the version.  In this case I think prefixing the title with fix:  should resolve it.
Could you sign our Contributor License Agreement?  Please ping me once you've done so (our CLAbot is out-of-order at the moment).

@pzinn thanks for signing the CLA.

thanks for reviewing will take a look soon

done, I think.
if we're going to fully rewrite splitAtDelimiters.js, one could also improve findEndOfMath. It's probably possible to speed it up quite a bit with some tricky regex, though there may be compatibility issues (e.g., Internet Explorer is missing advanced regex features).


Hash: Add hash_immediate to generic hash and FNV hashes.

These hashes should have hash_immediate just like CryptoHash.

[approve ci autest]

[approve ci autest]

Hold off on this a bit - I have a few updates I need to port in to this code.

No one would review it, and it's now replaced by #4481.


[Windows] Error: error net.Listen: listen tcp <IP_ADDRESS>:3306: bind: An attempt was made to access a socket in a way forbidden by its access permissions.

The Windows CLI throws the following error when port 3306 is already in use:
C:\Users\Jan\Documents\throwaway\planetscale<EMAIL_ADDRESS>λ pscale connect fk-test foo
Error: error net.Listen: listen tcp <IP_ADDRESS>:3306: bind: An attempt was made to access a socket in a way forbidden by its access permissions.

You could either have a more descriptive error message, or automatically use a different port that is available.

Thank you @janpio for the issue. We're going to have a look at it.
For the record, we actually try a random port, but only if the port is in use. The operating system returns a custom error that we catch. See: https://github.com/planetscale/cli/blob/1bd7252ab047c9f3029217e210c4b847285b14f5/internal/cmd/connect/connect.go#L197
It looks like the error message you're seeing is different. We don't check for that specific error message.

Ok. I had MySQL 5.7 running on that port via the default install, managed via MySQL Workbench (Where I then could not really stop the process/service and had to kill it manually via a Admin Taskmgr). Maybe that info helps you to pin it down.

Hi @janpio,
Thanks again for the feedback. I opened a PR with a potential fix. You can try it out by checking out my branch and compiling it yourself. Here is one way to use the gh tool. Run the commands from the root of the Git repository:
gh pr checkout 270
cd cmd/pscale
go build

Alternatively, I also compiled it from my branch, if you would like to test it out:
pscale.exe.zip

Still have this tab open, and will get to it sooner or later to reproduce this once again and confirm the fix.


fps of extracted irCSN feature

Hi. Thanks for your good work in AVT. But I have some questions about your extracted irCSN feature. What's the fps of your provided  ''ek100/ig65m_ftEk100_logits_10fps1s/rgb/'data.mdb'' and ''ek55/ig65m_ftEk55train_logits_25fps/rgb/data.mdb''. It looks strange for me...

Hi, thanks for your interest. The EK55 features should be at 25fps, and for EK100 10FPS.


Event Storming Policies

Hey!
I just wanted to say thanks for such a great project. It's really helped me clear up questions that I've had around DDD. I just have one question regarding event storming and policies. Usually you would have the following flow in an event storming scenario.

I'm trying to wrap my head around Policies and where to place the logic.
When a domain event is fired you would have a Notification to wrap that event and a NotificationHandler in the Application layer to handle the event. Where would you place the policy logic? In the NotificationHandler?

Thank you for question @jgozner !
Firstly, let me quote nice explanation what policy is (from https://developer.ibm.com/technologies/java/tutorials/reactive-in-practice-1/):

Reactions (also known as policies) help to model system-initiated commands in response to events happening. For instance, we may want to initiate a command when something else happens. It’s this ‘when, then‘ notation that makes reactions very handy to use in modelling workshops. By convention, reactions are represented using lavender sticky notes. We can insert them between an event or a command, which makes it easy to model policies, with multiple commands being triggered from one event, or to attach the lavender sticky directly to a command, where a policy only has a single command associated with it.

Answering your question, in my opinion: policy logic should be placed in Event Handler when it is simple. When the logic is complex, this logic should be placed in your Domain (for example in Domain Service) and Event Handler should only delegate and coordinate this process.
There is one example of this very easy logic policy in this project:

Given Attendee is added to Meeting
When Fee is not empty
Then create a Meeting Payment

internal class MeetingAttendeeAddedIntegrationEventHandler : INotificationHandler<MeetingAttendeeAddedIntegrationEvent>
{
    private readonly ICommandsScheduler _commandsScheduler;

    internal MeetingAttendeeAddedIntegrationEventHandler(ICommandsScheduler commandsScheduler)
    {
        _commandsScheduler = commandsScheduler;
    }

    public async Task Handle(MeetingAttendeeAddedIntegrationEvent notification, CancellationToken cancellationToken)
    {
        if (notification.FeeValue.HasValue)
        {
            await _commandsScheduler.EnqueueAsync(new CreateMeetingPaymentCommand(
                Guid.NewGuid(),
                new PayerId(notification.AttendeeId),
                new MeetingId(notification.MeetingId),
                notification.FeeValue.Value,
                notification.FeeCurrency));
        }
    }
}

That makes so much sense! Thanks for taking the time to reply and explain that :)


NGINX proxy_pass and html5mode

Hi!
i'm tryng the local prerender server but i have some trouble with the nginx config.
I have a subdomain with angularJS app and HTML5mode enabled (state url without #!)
For fix  the error 404 on realod of page  i have use  try_files $uri $uri/ /x/index.html but now i must enchain prerender proxypass. I have tried this config but seems not works.
location /x {
 try_files $uri $uri/ /x/index.html @prerender;
#OR
# try_files $uri $uri/ @prerender /x/index.html ;
}
location /backend {
 auth_basic "Restricted Content";
 auth_basic_user_file /srv/test.com/x/.htpasswd;
}

location @prerender {
    set $prerender 0;

    if ($http_user_agent ~* "baiduspider|twitterbot|facebookexternalhit|rogerbot|linkedinbot|embedly|quora link preview|showyoubot|outbrain|pinterest|slackbot|vkShare|Slack-ImgProxy|Slackbot-LinkExpanding|Site Analyzer|SiteAnalyzerBot|Viber|Whatsapp|Telegram|W3C_Validat") {
        set $prerender 1;
    }
    if ($args ~ "_escaped_fragment_") {
        set $prerender 1;
    }
    if ($http_user_agent ~ "Prerender") {
        set $prerender 0;
    }
    if ($uri ~ "\.(js|css|xml|less|png|jpg|jpeg|gif|pdf|doc|txt|ico|rss|zip|mp3|rar|exe|wmv|doc|avi|ppt|mpg|mpeg|tif|wav|mov|psd|ai|xls|mp4|m4a|swf|dat|dmg|iso|flv|m4v|torrent|ttf|woff)") {
        set $prerender 0;
    }

    #resolve using Google's DNS server to force DNS resolution and prevent caching of IPs
    resolver <IP_ADDRESS>;
    if ($prerender = 1) {
        #setting prerender as a variable forces DNS resolution since nginx caches IPs and doesnt play well with load balancing
        set $prerender "localhost:8899";
        rewrite .* /$scheme://$host$request_uri? break;
        proxy_pass http://$prerender;
    }
}

On nginx doc i have read that try_files go to next function only when the file is not found... so i think that i must add a check into "prerender" location  like:

    if ($prerender = 0) {
        #something that return 404 and force try_files to go forward in chain
    }

anyone can help me? :)

Hmm, can you copy everything out of the @prerender location and put it above try_files in the location /x ? And remove @prerender from try_files.

This is a middleware configuration issue and not an issue with the open source repo so feel free to email us at<EMAIL_ADDRESS>if you still need help!


Hangs on directory structures with infinite recursion

When building a tool that builds itself, I've set up symlinks from $/node_modules/name to $. This, means that I have infinite recursion in my filesystem. It all works fine and dandy, until I launch node-debug name. I've identified that the problem originates in findAllApplicationScripts, because by modifying that to always take the _noPreload path, the problem goes away (I just changed the if to if (this._noPreload || true)). For some reason, I'm unable to set this flag from the command line (tried --no-preload, --preload=false and others).
Anyways, my point is that the directory scanner should probably make sure that symlinks doesn't point back to a already scanned directory.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8726530-hangs-on-directory-structures-with-infinite-recursion?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

This should have been fixed by https://github.com/node-inspector/node-inspector/pull/551 (released in v0.9.0).
Please reopen if the problem persists in the latest version.


Can't resolve 'bufferutil', 'utf-8-validate'

Describe the bug
Hey 👋🏻, it seems that you have a problem in your dependencies. Whenever I try to include a react component with blocks, as described in the exemples, the application throws a bunch of error that a file is missing in a dependency...
It also seems that NextJS / React try to interpret the custom html tags (the error might comes from here)
To Reproduce
Steps to reproduce the behavior:

Follow the React exemple
Run the dev server
Go on the page with the element
See error

Expected behavior
No error and everything to work.
Errors
Module not found: Can't resolve 'bufferutil' in<EMAIL_ADDRESS>
Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+upload-client<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./app/panel/manage/news/(components)/ImportImageBlock.tsx
./app/panel/manage/news/create/page.tsx

<EMAIL_ADDRESS>

Module not found: Can't resolve 'utf-8-validate' in<EMAIL_ADDRESS>
Import trace for requested module:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+upload-client<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>./app/panel/manage/news/(components)/ImportImageBlock.tsx
./app/panel/manage/news/create/page.tsx

ReferenceError: HTMLElement is not defined
    at eval (webpack-internal:///(sc_client)/./node_modules/.pnpm/@symbiotejs+symbiote@1.11.3/node_modules/@symbiotejs/symbiote/build/symbiote.js:453:22)
    at (sc_client)/./node_modules/.pnpm/@symbiotejs+symbiote<EMAIL_ADDRESS>(.../my-project/.next/server/app/panel/manage/news/create/page.js:7088:1)
    at __webpack_require__ (.../my-project/.next/server/webpack-runtime.js:33:43)
    at eval (webpack-internal:///(sc_client)/./node_modules/.pnpm/@uploadcare+blocks@0.14.3/node_modules/@uploadcare/blocks/index.js:56:78)
    at (sc_client)/./node_modules/.pnpm/@uploadcare+blocks<EMAIL_ADDRESS>(.../my-project/.next/server/app/panel/manage/news/create/page.js:8012:1)
    at __webpack_require__ (.../my-project/.next/server/webpack-runtime.js:33:43)
    at eval (webpack-internal:///(sc_client)/./app/panel/manage/news/(components)/ImportImageBlock.tsx:10:76)
    at (sc_client)/./app/panel/manage/news/(components)/ImportImageBlock.tsx (.../my-project/.next/server/app/panel/manage/news/create/page.js:3017:1)
    at __webpack_require__ (.../my-project/.next/server/webpack-runtime.js:33:43)
    at eval (webpack-internal:///(sc_client)/./app/panel/manage/news/create/page.tsx:19:86)
    at (sc_client)/./app/panel/manage/news/create/page.tsx (.../my-project/.next/server/app/panel/manage/news/create/page.js:3028:1)
    at __webpack_require__ (.../my-project/.next/server/webpack-runtime.js:33:43)
    at .../my-project/node_modules/.pnpm/next@13.1.2_3duxcpitbtplz62feflag7fwby/node_modules/next/dist/compiled/react-server-dom-webpack/client.js:106:27

Desktop (please complete the following information):

OS: MacOS
Browser Safari
Version 16.2 (186<IP_ADDRESS>.5)

Additional context
The application is running NextJS (with appDir). The error occurred in a client component.

Hey @remib18,
We have added a separate bundle for SSR that will work with static import and willn't raise an error on Next.js. Please try updating to v0.21.1.


set_github_release action tests

Added tests for the set_github_release action. Validates both the request body and authentication headers.

Great, thank you @czechboy0 :+1: :rock


expect ip a to show link in up state

Refer to : https://github.com/kata-containers/runtime/issues/1201

See https://github.com/kata-containers/runtime/issues/1201 for comments.


register operation in mapping is treated as comment

Related to #13, but IMO, not the same. See the image below:

Also the highlights for some commands are missing in the above image.

Known issue, I am working on fixing it, should have a fix by today.

Should have been fixed by b37f5ac645d3db1f5ef9c9b07f12d760fadc038d


File reducers not found at index.js of todo example

This line import reducer from './reducers' from index.js is not finding the file reducers.js because don't exist.
What exist is a folder called reducers, not a file.
Error:
Failed to compile ./src/index.js Module not found: Can't resolve './reducers' in 'D:\pai\code\juridico-blog\src' This error occurred during the build time and cannot be dismissed.

I found the solution. It is because inside the reducer folder has a index.js file.


chore: release 1.1.0

:robot: I have created a release *beep* *boop*
1.1.0 (2021-07-05)
Features

switch to streaming upload in case of single files (#184) (e7ebbc9)
add --encrypt to upload (#183) (47ddc94)
add --drop-name to upload (#167) (8fc60be)
track chunk sync progress after upload (#167) (8fc60be)
print stamp after usage (#167) (8fc60be)

Bug Fixes

cashout: set minimum of minimum to 1 (#176) (1db096f)
print trailing slash when uploading single file (#194) (1bfee2b)
reduce spinner interval to avoid flickering on windows (#188) (0eedf7b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-cli/releases/tag/v1.1.0 :sunflower:


Clear credentials from UI after authenticating

When logging in initially, or after changing accounts, until psst is restarted, when the settings panel is opened, the credentials will be visible in plain text. This clears the credentials from the UI after a login attempt, no matter if it's successful or not.
If #342 gets merged then perhaps this should only clear the credentials if authentication was successful?

Hi, thanks a lot for all the PRs, great work!

perhaps this should only clear the credentials if authentication was successful?

I agree.

What do you think about only clearing the password if authentication fails?


[Performance]: Llama 3 70B; vLLM does not scale beyond TP=4

Proposal to improve performance
No response
Report of performance regression
I have a single machine 8xH100 SXM system. I wanted to see how vLLM (0.5.5) compares to other engines with TP=8.
The model I used for testing was fp8 llama 3 70b created using AutoFP8 repo.
I tried several setups:

1x TP=4 (useful baseline)
2x TP=4, running vLLM with --tensor-parallel-size=4 twice on the same 1 machine, load balanced with nginx
1x TP=8, running vLLM with --tensor-parallel-size=8 once on the same 1 machine

One would expect 1x TP=8 to be able to handle the same QPS as 2x TP=4 with equal or better latency metrics. But that is not the case. The latency should be better, as there should be more opportunity for good scheduling and thus bigger batch sizes.
In all cases I used these engine params:
--gpu-memory-utilization=0.95 --tensor-parallel-size=${ENGINE_TP:?} --disable-log-requests --enable-chunked-prefill --max-num-batched-tokens=8192

For TP=8, I also tried different values of --max-num-batched-tokens and --max-num-seqs. Using 16K and 4K for  --max-num-batched-tokens resulted in similarly poor performance. Using 512 lead to much lower throughput and dropping of requests as a result.
The results are as follows:
(1) TP=4 baseline (benchmark target QPS ~3.3)
Requests per second: 3.245471215374879
Average input tokens: 2585.1266666666666
Average output tokens: 79.91166666666666
Average time to first token:<PHONE_NUMBER>666666ms
Average time per token: 65.42530691921237ms
Average total time: 4833.363333333334ms
Average tokens per second: 15.28460540865031
Average output tokens per second: 19.28314247970231
Average max token delay:<PHONE_NUMBER>333333ms

(2) 2x TP=4 load balanced with nginx (benchmark target QPS ~6.6)
Requests per second: 6.3261777234195105
Average input tokens: 2590.305
Average output tokens: 75.67
Average time to first token: 583.955ms
Average time per token: 66.1977724369382ms
Average total time: 4598.23ms
Average tokens per second: 15.106248491255915
Average output tokens per second: 18.82660898680766
Average max token delay: 251.4ms

(3) TP=8 (benchmark target QPS ~6.6) -- does not  reach the target QPS and has much worse latencies
Requests per second: 5.296937487309421
Average input tokens: 2594.345
Average output tokens: 66.69666666666667
Average time to first token: 823.98ms
Average time per token:<PHONE_NUMBER>0085044ms
Average total time: 16957.078333333335ms
Average tokens per second: 3.8632951933032817
Average output tokens per second: 4.179421527191316
Average max token delay:<PHONE_NUMBER>666667ms

As you can see from the results 2x TP=4 scales linearly to 2x the QPS with the same latency metrics. TP=8 on the other hand scales poorly.
Let me know if I am holding it wrong and I should be using different params. For my use cases, I need low latency to first token and low inter token latency (specifically I look at the maximum inter token latency for any given sequence).

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

I would say this is expected. Using unnecessarily large TP size will hurt performance, because the communication overhead is larger.

@youkaichao I am not sure -- I would expect the threshold to be higher for 70B fp8 model. Here's a video on the topic: https://youtu.be/mYRqvB1_gRk?feature=shared&t=341
IIRC, KV cache size for 3000 token long sequence is just under 8GB (8192 dim * 80 layers * 2 kv *2 fp16 * 3000 len).
That means that 4xH100 can fit only ~30 at once (accounting 70GB for the model + some overhead).

vLLM will print some logs like # GPU blocks: 790. Multiply the number by 16 (the block size), and you can get roughly the maximum number of tokens that can be served on the current configuration.

Can you try --tensor-parallel-size 4 --pipeline-parallel-size 2 but I guess it still won't be as fast as the two replicas.

@nivibilla I will try that next time I do the testing. When I last ran the test, it was not possible due to using custom logit post processor function (and PP requires that it needs to picklable).

I am also curious about 2xTP4 vs TP8 problem, though I have not performed thorough benchmarks, I might have some useful suggestions.

TP=8 will not double the computability, so we won't achieve half of the TTFT, although your results seems worse than my naive expectation.
When QPS * workload length > max_num_batched_tokens, the queueing cost will also affect the TTFT. I suspect that your workload encounter this case.
It seems that vLLLM will suffer in large workload scenarios. Maybe you can update to v0.6.0 and try multi step scheduling, which seems to alleviate the large workload penalty.

Also in an ideal scenario vllm should spin up 2 llama 70b servers and auto load balance between them. Deepspeed fast gen gas this model parallel capability


Profile modules and listings should have a PayloadUUID column

The Profile listing (listing/profile/profile) should show the Profile PayloadUUID between the "Profile Name" and the "Payloads" columns. This should only be the root level PayloadUUID, not any of the sub PayloadContent UUIDs.
This will help when distributing an updated profile with the same PayloadIdentifier, but with a new PayloadUUID.
The profile module (module/profile/items) should show the PayloadUUID for each sub PayloadType under PayloadContent, between the "Profile Name" and the "Payload Name" columns.

Working on this, should have a PR open on the module later today or tomorrow.


Server Crashing when Player joins

Hello! In multiplayer the server crashes when a specific player joins, we had fixed the issue by generating a new world, however the issue is now caused by another player.
Here is the crash log from the server.
crash-2021-09-15_22.10.38-server.txt

Hi there,
This is a strange one; hard to diagnose a java.lang.Error. I'm not sure that I can reliably reproduce this issue, so I can't say I'm very confident that I'll be able to resolve this one, especially considering all the possible mod interactions.
If this happens again, I suggest trying to delete the specific player's data file before deleting the world (if you haven't already tried that).
Thanks.

Ah, It appears to be a weird interaction from playerex with Eldritch Mobs mod, mostly caused by the Eldritch mobs mod itself.  I have found this out on the modpack's discord. Thank you for the prompt reply though!


.NET Core 3.0 accessing MVC request context

Hello,
I found problem when I converted app from .NET Core 2.2 into 3.0.
In 3.0 is context.Resource not anymore of type AuthorizationFilterContext, but instead Microsoft.AspNetCore.Routing.RouteEndpoint. Is there anything I'm missing (some changes in configuration or some other place)?
If did really changed, is there any way to redirect from handlers?
Any help is greatly appreciated.
protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, T requirement)
{
    var resource = context.Resource;     // 2.2 - AuthorizationFilterContext
                                         // 3.0 - RouteEndpoint

    if (context.Resource is AuthorizationFilterContext mvcContext) // in 3.0 results into null
    {
    }
}

Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1141d92-adeb-6841-229f-914c808f9a2b
Version Independent ID: 7089b376-949f-c1c6-c37a-5d8cc7ecf104
Content: Policy-based authorization in ASP.NET Core
Content Source: aspnetcore/security/authorization/policies.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

This is the solution: https://github.com/aspnet/AspNetCore/issues/11075

Not exactly, because I need to set RedirectToActionResult to redirect from this handler into specified action. Like
if (context.Resource is AuthorizationFilterContext mvcContext)
{
    mvcContext.Result = new RedirectToActionResult("Action", "Controller", null);
}

@sbwalker your link is broken

@HaoK  should this go in the 2.2 to 3.0 migration guide?

Sorry.. the link was working when I posted it. I found the answer to my question - you now need to access HttpContext through HttpContextAccessor:
    protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, PermissionRequirement requirement)
    {
        var ctx = HttpContextAccessor.HttpContext;
        if (ctx != null && ctx.Request.Query.ContainsKey("entityid"))
        {
            int EntityId = int.Parse(ctx.Request.Query["entityid"]);
            if (UserPermissions.IsAuthorized(context.User, requirement.EntityName, EntityId, requirement.PermissionName))
            {
                context.Succeed(requirement);
            }
        }
        return Task.CompletedTask;
    }

This is a sideeffect of the endpoint routing changes, so maybe it should go with whatever docs are related to that change?

Neither https://github.com/aspnet/AspNetCore/issues/11075 nor @sbwalker's solutions look to work in my case: I need to resolve a service (via HttpContext.RequestServices previously) in a AuthorizationPolicyBuilder.RequireAssertion.
All I have in the assertion is an AuthorizationHandlerContext. I'm in a static extension method.
Do I need to use an IAuthorizationRequirement instead?

Additionally, this page still says , "For example, MVC passes an instance of AuthorizationFilterContext in the Resource property".
I need to access RequestServices from within my RequireAssertion delegate - how can I please?

You can try injecting IHttpContextAccessor into your handler if you can't get access to the http context via the resource being passed in (which is not usually the case)

@HaoK inject it into what, please? I'm using RequireAssertion from a static extension method.
"can't get access to the http context via the resource being passed in"... everything referenced here indicates that the resourced passed in is now always an Endpoint, could I ask what you mean by "not usually the case". Do you say that because most people are using pre-3.0? I'm on 3.0.0.

Require assertion isn't meant for this scenario, you should implement a real handler if you want to access request specific things

“Real handler”...? Am not good at guessing here..

https://docs.microsoft.com/en-us/aspnet/core/security/authorization/dependencyinjection?view=aspnetcore-3.0 is a good example of how you implement a handler that can use things from DI, that would be how you can use context accessor

Thank you, that's solved my use case. FWIW I think the documentation may still have an issue here, where it says AuthorizationFilterContext is passed in - but I'm good to go.

@kierenj  can you suggest an edit?

I can - although I've had the same suggestion in a few places, I'm curious about the policy with this. Typically, I'm asking something coming from a position of ignorance on the relevant area of the library/product. Some answer becomes a little clear, then someone suggests I suggest an edit.
My first thought is that in instances like that I might be close to the worst person to edit official documentation: I'm at one step up the ladder from being completely stumped by some issue. Isn't that dangerous - in this scenario and the others, I don't know what I don't know?

I've had a look into this to see what we can do in 3.0.
I found that the following code inside of an IAuthorizationHandler.HandleAsync implementation allows for getting hold of a ControllerActionDescriptor, which contains info about the controller, action, filters, etc:
if (ctx.Resource is RouteEndpoint routeEndpoint)
{
    var controllerActionDescriptor = routeEndpoint.Metadata
        .OfType<ControllerActionDescriptor>()
        .SingleOrDefault();

	if (controllerActionDescriptor != null)
	{
            // ...
	}
}

It's also possible to get the route values for controller, action, et al from the HttpContext (using IHttpContextAccessor as already noted), so I'm not sure whether it's overly beneficial to grab the ControllerActionDescriptor like this.
@Rick-Anderson I dunno if this approach would actually be recommended by the engineering team, or if maybe it is a recommended approach for those that want to deal with MVC concepts in the handlers. Can we run it by someone on the engineering team? I guess Hao might still be subscribed to this issue...

@HaoK  can you review the preceding suggestion?

Yeah its a better approach to access things via the endpoint metadata as opposed using IHttpContextAccessor, which should typically only used as a last resort

@Rick-Anderson can you clarify what you need from the PU here? Do you need us to write up the changes or just confirm that the approach @serpent5 described is appropriate?

just confirm that the approach @serpent5 described is appropriate?

Yes

Do you need us to write up the changes

If anything needs to be added, let us know.

https://github.com/aspnet/AspNetCore.Docs/pull/15218#issuecomment-546100456 summarises the specifics.

@serpent5  let me know if this should be reopened in the master issue https://github.com/aspnet/AspNetCore.Docs/issues/16191


(client-logger): Enable exactOptionalPropertyTypes

This PR would introduce a breaking change and versions 2.1+ do not permit any breaking changes. We may revisit this PR when breaking changes are allowed.


Make number input type adhere to MD

Number input types add spinners to the textfield which break MD. We can allow the existing textfield to work for number types by simply hiding the spinner elements for each engine.
This will provide proper keyboards on mobile, but otherwise function and look as expected.

@nicolasgarnier could you help take a look at this?


feat(Repository): Use KnownProvenance instead of VcsInfo

In order to allow source artifacts as well as local source code to be scanned, we require a more generallized Repository, which allows any type of KnownProvenance. While we still set the signature of Repository to allow KnownProvenances, this commit focuses on accomidateing RepositoryProvenance as then main input for now.
Therefore we wrap VcsInfo with RepositoryProvenance, whenever it is used as input, and unwrap it, when it is produced as output. This gives us a quick update of the now depreacted code, without the necessity to support all KnownProvenance types from the get go.
We also update any realted tests, mostly the expected OrtResults, but also some Repository definitions and calls.
To avoid having vcs and vcsProcessed appear in the OrtResult output, we change them to be a method (fun) instead of a variable (val). This is still a soft refactor, to keep the widely used vcsProcessed available for now. We might still remove it later.
Signed-off-by: Jens Keim<EMAIL_ADDRESS>Part of: #8803.

Can we have a GitHub issue which describes exactly the goal of this effort? In particular, mention explicitly in which cases we want to support local file provenance. (e.g. analyzer, scanner, scan storages, ...). I'm still worried about the added complexity of this refactoring, compared to the value it will provide, but having the goal clearly statet would at least ensure we are reviewing against the same outlined goal.

Can we have a GitHub issue which describes exactly the goal of this effort?

I have started such an issue at https://github.com/oss-review-toolkit/ort/issues/8803 for people to comment on.

@sschuberth @fviernau I know, you are still considering if this refactoring is the right way, but if you could find the time to review the current changes that would be great.
Since most changes regard code quality and commit messages, it would be great to know if the changes know meet your standards. Not only for this PR, but also for future work.


Backup methods are not considered on SFTP service for Blob Storage on Az Storage Accounts

[Enter feedback here]
I believe msft should mention the backup options for the SFTP service on azure storage accounts.
No information is provided on what methods can be used and currently there is NO POSSIBLE WAY to back up an SFTP blob container natively in azure.
Operational backups do not work when SFTP is enabled on the account.
Azure Backup "Vaulted" backup is not available to configure if the SFTP service is enabled.
Please add this to the documentation and also heads up on working on backup features for this serverless SFTP service.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 572ceed9-5b72-0d7c-d341-e26816993e29
Version Independent ID: 0030a35b-b6cd-f5b9-7c2b-042a55b1e427
Content: Limitations & known issues with SFTP in Azure Blob Storage - Azure Storage
Content Source: articles/storage/blobs/secure-file-transfer-protocol-known-issues.md
Service: storage
GitHub Login: @normesta
Microsoft Alias: normesta

@anesthetiize
Thanks for your feedback! We will investigate and update as appropriate.

@normesta
Can you please check and add your comments on this doc update request as applicable.

@anesthetiize
I'm going to assign this to the document author so they can take a look at it accordingly

Thank you for sharing this @anesthetiize . Looks like the content doesn't make clear enough some of the Blob Storage features not supported when SFTP support is enabled on the account. I've added some clarity there with a link to this article - https://learn.microsoft.com/en-us/azure/storage/blobs/storage-feature-support-in-storage-accounts which describes which features aren't supported. Operational backups depend on support for things like Snapshots, versions and other data protection features that are not yet supported with SFTP. The doc updates will appear live by tomorrow.  Thanks again!
#please-close


rssfeed master->main (latest)

master main splitted of into https://github.com/ioBroker/ioBroker.repositories/pull/3759


Failed to load schema.

I can get into my library but when I try to open a game, I get this error.

Hmm, that would suggest it can't find a file that Steam should be creating.
C:\Program Files (x86)\Steam\appcache\stats
Does this directory exist for you? (if you have Steam installed in a different location, then adjust accordingly).
Are all games failing or just a specific one?

Yes, I have that folder.
All games are failing.
I'll try to reinstall steam, maybe that's the problem.

Do you have any files named similar to UserGameStatsSchema_440.bin in that directory? (not the ones that start with UserGameStats_).
Can you give an example of a game that is failing?

OK, after steam reinstall, it's working, still not sure what was the problem.

That's odd, but glad you were able to solve it.

Hellooo!!! i have the same problem, and im using the program 3 years without problems :(

Guys, mine also had this same problem in all games, I did the following... you download the game you want the achievements and it will appear there, simple. It worked 100% for me, I hope it helped! Stay cool brothers


3-forms_Allocene

homework 3-forms + task with '*' + remade the structure, divided it into logical files

Hey, @Allocene, I've assigned to your pr @vadym-zinchenko-moc as he is stated as your mentor in the doc


Adding Exotel sms Alerter support for alerting

This pull request adds sms support for Exotel sms api(https://www.exotel.in). I have tested it and works well in production

@danielpops can you please merge this.


Dynamic resource limits

Right now, it's possible to specify the resources needed by the Task dynamically. But it's not possible to set the limit dynamically, since it must be fixed in the config file.
In my case, the resources are cuda devices. I'll run the same code in machines with no cuda devices, single cuda devices or many cuda devices. So, I don't know in advance how many I have. Right now, I need to update the config file. I'd like to use torch.cuda.device_count() (an utilitaty method from PyTorch) to set the amount of cuda devices I have.

I'll be happy to review a PR! Feel free to submit! :)

The only non-trivial part is that you're setting a per-scheduler configuration now instead of a perk-task configuration. Should still be doable, probably even easier.

How could it be implemented? Right now, the config files are .cfg. Couldn't luigi support python files as well? I see lots of other projects using python files for configuration. That could add the dynamism we need.
Anyway, here is my current workaround:
I've created a wrapper around luigid as follows:
#!/usr/bin/env python

import os
import torch

if __name__ == "__main__":
    luigi_resources_path = os.path.join("output", "luigi_resources.cfg")

    with open(luigi_resources_path, "w") as f:
        f.write(f"[resources]\ncuda={torch.cuda.device_count()}")

    os.environ["LUIGI_CONFIG_PATH"] = luigi_resources_path

    from luigi.cmdline import luigid
    luigid()


Did webapp security removed in 6.2?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
I want keep my webapp security. Do not show the content before user logined.
I add this to webapp.yml like the older version style.
But it doesn't work.

security:
  user:
    admin:
      password: admin

Bug

Which version of SkyWalking, OS and JRE?
6.2,ubuntu, jdk1.8

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Read the changelog, https://github.com/apache/skywalking/blob/master/CHANGES.md, we removed the login, due to Security vulnerabilities reported. We don't have committers to make sure it works, so removed.

Any plan for bringing back the login back to Skywalking webapp ui?
We don't want the webapp pages are accessible for anonymous visits.

You could build your login easily. Today, no contributor is trying to bring it back in a security way.

We can only build our own secure login method through OAuth2 and other means. Won't skywalking build its own secure login in reverse?

We could accept contributions to make login back. It is removed because have to. Because old one is not security


[MINOR][DOC] updated schema evolution code sample in public docs

screenshots___website_schema_evolution_code_update_H0b3Cq3j.pdf
Change Logs
Made changes to existing Hudi docs schema evolution scala example code. Earlier code was written for 0.11 version compatible with Spark 3.1.2. I made changes to align the example with Hudi 0.13.1 and Spark 3.3.3.
Also added Python equivalent of the code on Hudi 0.13.1 and Spark 3.3.3.
Impact
Updated schema evolution page's code sample for scala and added python sample.
Risk level (write none, low medium or high below)
Low
Documentation Update
The update was to the docs.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Hi @sagarlakshmipathy Thanks for the improvement on the docs!  Files under content/ are automatically changed and should not be in the PR.  Also, could you update website/docs/schema_evolution.md?


[Bug] Indexing with a list.number resutls in an internal consistency error

var A = [1,2,3]
print A[[2].2]
--Registers (4 in use)
r0 temporary [0]
r1 temporary [0]
r2 temporary [0]
r3 unallocated
--End registers
Internal consistency error: Please contact developer. [Explanation: Incorrectly freed registers in compiling argument list.].

compiler_nodetobytecode calls compiler_property which throws an error.
But the error never gets thrown before the compiler_regtop(c)!=reg check that fails and results in the unreachable


Worker is maxed out (100% CPU) for many minutes

The worker process is currently saturated at 100% CPU for at least 20 minutes every hour. This load likely comes from our crawler jobs.
We should find a way to run crawl jobs less frequently, or in smaller batches. When the load is high, first-time-setups are slower as the jobs are put at the end of the queue.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog :^)

It would be great for this kind of cases to have priority queues, so we can make sure important tasks (e.g. new installations, magic link email...) are always processed before less important ones like background sync.
Unfortunately, arq doesn't seem to have this kind of feature out-of-the-box 🤔

Yeah, priority queues would be cool to have! I was thinking now to see if we can horizontally scale the workers, we almost support it out of the box, the only thing missing is some sort of leader election for the cron jobs.

From what I understand of the arq.cron doc, all it does is to enqueue the job, it doesn't execute it directly. Besides, it has a unique option (enabled by default) that prevents multiple workers from enqueuing it several times.
So it should be safe to spawn more processes in our current state.

Oh, perfect!

This issue has been resolved for now (#1086, #1084), I'll close this issue.
We're not doing the work as often, every 12h instead of every 1h, and if we find work to do, we'll delay the work randomly up to 5 minutes. This has removed the sharp peaks in the load, and the smearing of the workload means that we're never at 100% CPU anymore.


Update Composer dependencies (2023-04-04-00-12)

Visual regression test passed!
View the visual regression test report


Set RELEASE_BRANCHED_BUILDS=true in Makefile

Fix $RELEASE_BRANCHED_BUILDS access in called scripts first though.

/cherry-pick release-4.14 release-4.13 release-4.12


New version: StippleUI v0.10.0

Registering package: StippleUI
Repository: https://github.com/GenieFramework/StippleUI.jl
Created by: @essenciary
Version: v0.10.0
Commit: b8100a2d3e1e7b4035ff3791dc0d1c289ceded3d
Reviewed by: @essenciary
Reference: https://github.com/GenieFramework/StippleUI.jl/commit/b8100a2d3e1e7b4035ff3791dc0d1c289ceded3d#commitcomment-59142162
Description: StippleUI is a library of reactive UI elements for Stipple.jl.

@JuliaRegistrator register

Error while trying to register: Register Failed
@essenciary, it looks like you are not a publicly listed member/owner in the parent organization (JuliaRegistries).
If you are a member/owner, you will need to change your membership to public. See GitHub Help


libbcc debian package is architecture-dependent

Cherry-pick upstream change https://github.com/iovisor/bcc/pull/2746 to allow us to build a -dbgsym package for libbcc.
ab-pre-push: http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/2846/console

I think we should sync bcc with upstream instead and verify that bpftrace still works.

Yeah, I agree. We also probably want to have some way of reminding ourselves to regularly check whether we want to pull in upstream changes. I think that those things can be done independently of this though.


Starting VS Code from WSL: env vars sourced after .bashrc not inherited

I observe that environment variables that are sourced at the command
line between opening the WSL shell, and starting code . appear to not
be inherited, and therefore are not available when VS Code needs them.
For example, the Java extensions for VS Code need java and maven to be
in the path.
Stack: Windows 10, WSL, VS Code (insiders from 2019-10-15) with WSL and Java Extensions
Preconditions: verify that VS Code correctly connects to WSL by
observing the WSL: Ubuntu in the status bar.
Steps to reproduce.

Open an Ubuntu WSL shell and verify that the following environment
variables are not set:
export JAVA_HOME="${HOME}/edburns/Downloads/jdk-11.0.3"
export ANT_HOME=${HOME}/edburns/Downloads/apache-ant-1.10.6
export M2_HOME=${HOME}/edburns/Downloads/apache-maven-3.6.1

verify PATH does not have JAVA_HOME, ANT_HOME, or M2_HOME in it.

Make a script containing the following, say env-java11
export JAVA_HOME="${HOME}/edburns/Downloads/jdk-11.0.3"
export ANT_HOME=${HOME}/edburns/Downloads/apache-ant-1.10.6
export M2_HOME=${HOME}/edburns/Downloads/apache-maven-3.6.1
export PATH=${M2_HOME}/bin:${ANT_HOME}/bin:${JAVA_HOME}/bin:${PATH}

Source the script in the Ubuntu WSL shell.
. ./env-java11

Start VS Code code .

Open a bash shell in VS Code

Echo the variables and see they are not defined.

Workaround
If you source the environment variables directly from the ~/.bashrc
you will find the variables are inherited correctly.
If you are internal to Microsoft, I have a video of the problem at
https://msit.microsoftstream.com/video/cbe42ed7-e766-431f-abfc-2c5e818653e5

vscode remote doesn't inherit its environment from the shell its launched from, it always starts with a clean environment.
@aeschli the resolver can technically set environment variables for the remote EH to be initialized  with. I don't know whether vscode will get environment variables out of wsl when launching like this. I kind of doubt it. But I'll leave this to you.


DiT for Text Detection

Is it possible for the model to understand curved text? If so how it is possible, in the document and published paper there is no explanation for it. Is anyone tried using the pre-train model to predict the scene text document?

@senthil-r-10, We do not have curved text in the DiT training, so currently it is not supported. But you may continue train this model to support curved text detection. For scene text, what do you mean by scene text document? Can you give some examples?

You have trained the model for documents, Has anyone tried on curved text datasets like Total-Text Dataset (https://github.com/cs-chan/Total-Text-Dataset/tree/master)? how is the model performance on curved and multi-oriented text instances? I am planning to use this approach for OCR text detection.

I mean Curved text detection only, I plan to use this approach for OCR text detection for documents like Receipts and invoices. Could you update the Data Preparation link in the help document?
https://mmocr.readthedocs.io/en/v0.6.0/datasets/det.html#funsd

@wolfshow I've previously trained a DONUT model to adapt to a new language with synthetic data. Do you think same strategy might be possible with DiT for Text detection in a foreign language?
Secondly, Can't access the model checkpoints or weights listed in /dit/text_detection. Getting PublicAccessNotPermitted error for all links.


Missing timelines

Hi,
I am trying to implement this plugin and its not rendering the timelines when in week or day view. No errors. I have done a jquery solution and it works well.  Kindly assist.

Did you use agendaWeek?  agendaDay for the day view
$scope.uiConfig = {
      calendar: {
        header:{
          left: 'prev,next today',
          center: 'title',
          right: 'month,agendaWeek,agendaDay'
        },


Add dd to transpiler

Summary
Details and comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: itoko:x: Mathlete1000You have signed the CLA already but the status is still pending? Let us recheck it.

@Mathlete1000 When the other PR (#4555) is merged and we are ready to look at this again, we will re-open 👍


Loading local dataset raise requests.exceptions.ConnectTimeout

Load local dataset:
dataset = load_dataset('json', data_files=["../../data/json.json"])
train = dataset["train"]
print(train.features)
train1 = train.map(lambda x: {"labels": 1})
print(train1[:2])

but it raised requests.exceptions.ConnectTimeout:
/Users/littlely/myvirtual/tf2/bin/python3.7 /Users/littlely/projects/python_projects/pytorch_learning/nlp/dataset/transformers_datasets.py
Traceback (most recent call last):
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connection.py", line 160, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/util/connection.py", line 84, in create_connection
    raise err
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/util/connection.py", line 74, in create_connection
    sock.connect(sa)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connectionpool.py", line 677, in urlopen
    chunked=chunked,
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connectionpool.py", line 381, in _make_request
    self._validate_conn(conn)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connectionpool.py", line 978, in _validate_conn
    conn.connect()
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connection.py", line 309, in connect
    conn = self._new_conn()
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connection.py", line 167, in _new_conn
    % (self.host, self.timeout),
urllib3.exceptions.ConnectTimeoutError: (<urllib3.connection.HTTPSConnection object at 0x1181e9940>, 'Connection to s3.amazonaws.com timed out. (connect timeout=10)')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/connectionpool.py", line 727, in urlopen
    method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/urllib3/util/retry.py", line 439, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='s3.amazonaws.com', port=443): Max retries exceeded with url: /datasets.huggingface.co/datasets/datasets/json/json.py (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x1181e9940>, 'Connection to s3.amazonaws.com timed out. (connect timeout=10)'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/littlely/projects/python_projects/pytorch_learning/nlp/dataset/transformers_datasets.py", line 12, in <module>
    dataset = load_dataset('json', data_files=["../../data/json.json"])
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/load.py", line 591, in load_dataset
    path, script_version=script_version, download_config=download_config, download_mode=download_mode, dataset=True
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/load.py", line 263, in prepare_module
    head_hf_s3(path, filename=name, dataset=dataset, max_retries=download_config.max_retries)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/utils/file_utils.py", line 232, in head_hf_s3
    max_retries=max_retries,
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/utils/file_utils.py", line 523, in http_head
    max_retries=max_retries,
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/utils/file_utils.py", line 458, in _request_with_retry
    raise err
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/datasets/utils/file_utils.py", line 454, in _request_with_retry
    response = requests.request(verb.upper(), url, **params)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "/Users/littlely/myvirtual/tf2/lib/python3.7/site-packages/requests/adapters.py", line 504, in send
    raise ConnectTimeout(e, request=request)
requests.exceptions.ConnectTimeout: HTTPSConnectionPool(host='s3.amazonaws.com', port=443): Max retries exceeded with url: /datasets.huggingface.co/datasets/datasets/json/json.py (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x1181e9940>, 'Connection to s3.amazonaws.com timed out. (connect timeout=10)'))

Process finished with exit code 1

Why it want to connect a remote url when I load local datasets, and how can I fix it?

Hi ! Thanks for reporting. This was indeed a bug introduced when we moved the json dataset loader inside the datasets package (before that, the json loader was fetched online, as all the other dataset scripts).
This should be fixed on master now. Feel free to install datasets from source to try it out.
The fix will be available in the next release of datasets in a few days


todo-others returns your own patches

I assume it's just looking at reviews, so returning any of your own patches which you haven't also reviewed. This is a bit counterintuitive.

commit a754cebf26d543822333958dfecc2441429654e5
Author: Daniel P. Berrange<EMAIL_ADDRESS>Date:   Wed Feb 17 11:16:34 2016 +0000
Don't include your own changes in todo lists

The todo lists are for identifying various changes that you
may be interested in reviewing. People don't review their
own changes, so these should all be filtered out.

Fixes bug #25


OAuth Support (THIS IS NOT SSO)

Description
Considering there is authentication now implemented, and there are pull requests for SSO it would be smart to add OAuth to the system as well. Another option would be to allow an OAuth provider to be able to import users into your auth system.
Priority
High (App breaking feature)

Hi, I assume you closed this because of #1618 ?

I didn't close anything, I created this because of it yes. OAUTH is different than SSO. The only reason I mentioned that #1618 should be part of the SSO PR is because it means you wouldn't have to change auth architecture again as Homarr would provide SSO, OAUTH and local users.

Please do not close this!

It would be nice to have authorization to boards based on a roles: admin, owner, or regular user.
It would also be nice to show/hide elements and/or functionally based on role as well.


Feature/multiple sessions tasks dsc 4

So this is an initial merge of the multiple sessions and tasks branch with the DSC 4 update. I've merge major/4 into my old dev branch. It works fine, although there is basically no CSS. Might be a fine starting point though, especially to incorporate into the design of the stepper...

Nice, approved!


Enable two-factor authentication

Please enable two-factor authentication in your GitHub settings. This will add an additional layer of security to your account and make the Financial Times less vulnerable to attacks.
Here is how: https://github.com/blog/1614-two-factor-authentication

[ ] @stuhar
[ ] @syymza
[ ] @vnadgir-ft
[ ] @yolandeleungFT
[ ] @yunhan0
[ ] @Zapadlo
[ ] @moranr77
[ ] @musthemag
[ ] @Nesze
[ ] @next-team
[ ] @noelbuce
[ ] @patrickkettner
[ ] @pauloneillft
[ ] @radiodario
[ ] @RenielR
[ ] @reoneljose
[ ] @rtbaker
[ ] @simonwilliamsFT
[ ] @GeorgeBogdis
[ ] @guyvalerio
[ ] @Jesslipson
[ ] @jonathantneal
[ ] @karinagp
[ ] @kovacshuni
[ ] @Loita123
[ ] @a-rhombus
[ ] @AndrewWatkins
[ ] @bbinto
[ ] @bedemccarthy
[ ] @caridy
[ ] @catalin-ilea
[ ] @cheekymonkat
[ ] @chris-mooney
[ ] @christinetecson
[ ] @clmntnbrn
[ ] @DorothyAngeles
[ ] @ervilletalaoc11
[ ] @freeseus

If you have any questions or need any help, please contact the Security Working Group<EMAIL_ADDRESS>

[x] caridy

Closing this as it is stale and I'm cleaning up my issues.


[Feature][Support Struct] Support read struct type in FE

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Link: #12339
In FE, we do lots of trick work, in order to support struct dot access and make it compatible with the original system.
The root cause of this situation is that in the past, the system determined the col's catalog name, database name, and table name in the Parser, which is not acceptable for struct type.
So we do the following trick methods:

Change StarRocks.g4:

If we do SELECT a from tbl;, a must refer to a column name.
If we do SELECT  a.b from tbl;, a may be a table name(b is col name); a may be a column name(b is struct subfield name). In this situation, we will give them may be wrong values (catalog, db, and table name, here is table name: a, col name: b) in SlotRef, and also store the original QualifiedName[a.b], so we can dereference it in ExpressionAnalyzer based on QualifiedName.

Why do we need to set maybe wrong values for SlotRef? Because SlotRef is heavily used in our system, we do this for compatibility with the origin code.

If we do SELECT a[10].b from tbl;, we know that a[10] must be a struct type, and b is a subfield name, so we can create SubfieldExpr directly.

Record struct subfield access path

SlotRef is used to refer to a column name in the past, so we need to add usedStructFieldPos to record the subfield access path.

Change the expression tree structure in SqlToScalarOperator, because in ExpressionAnalyzer, we can't change the expression tree's logic structure, so do this change in SqlToScalarOperator. If SlotRef's usedStructFieldPos is not empty, we will add a SubfieldOperator on top of ColumnRefOperator.

Example
Table Definition:  [a: INT, b: STRUCT<b1: INT, b2: INT>, c:ARRAY<STRUCT<c1: INT, b2: INT>>]
SELECT a FROM tbl;, following original logic.
SELECT tbl.a FROM tbl;, following original logic.
SELECT b.b1 FROM tbl;: Do trick
[Parser:] SlotRef(table name: b, col name: b1, qualifiedName: b.b1) [table name, col name is a wrong value]
[Analyzer:] SlotRef(table name: tbl, col name: b, usedStructFieldPos: [0]) [Set correct table name and col name]
[Convert to Operator]: SubfieldOperator(fieldname: b1, children: columnRefOperator)
... do normally
SELECT c[10].c1 FROM tbl;
[Parser:] SubfieldExpr(table name: c1, children: ArrayElementExpr(10, children: SlotRef(c)))
... do normally
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] This pr will affect users' behaviors
[x] This pr needs user documentation (for new or modified features or behaviors)
[ ] I have added documentation for my new feature or new function

[FE PR Coverage Check]
:heart_eyes: pass : 275 / 322 (85.40%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%
[937]

:large_blue_circle:
com/starrocks/analysis/SubfieldExpr.java
13
22
59.09%
[32, 33, 34, 46, 47, 56, 57, 58, 62]

:large_blue_circle:
com/starrocks/catalog/StructType.java
21
30
70.00%
[56, 68, 73, 74, 75, 76, 77, 89, 112]

:large_blue_circle:
com/starrocks/connector/ColumnTypeConverter.java
34
47
72.34%
[100, 315, 321, 419, 420, 421, 422, 423, 424, 425, 426, 429, 431]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/SubfieldOperator.java
32
36
88.89%
[39, 81, 92, 96]

:large_blue_circle:
com/starrocks/analysis/SlotRef.java
49
55
89.09%
[110, 111, 112, 154, 155, 373]

:large_blue_circle:
com/starrocks/sql/analyzer/Field.java
40
44
90.91%
[92, 96, 126, 155]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
13
14
92.86%
[214]

:large_blue_circle:
com/starrocks/sql/analyzer/SelectAnalyzer.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
26
26
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/TypeDef.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/ViewDefBuilder.java
13
13
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/QualifiedName.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/StructField.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/Expr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Type.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/OperatorType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
9
9
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 275 / 322 (85.40%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%
[941]

:large_blue_circle:
com/starrocks/analysis/SubfieldExpr.java
13
22
59.09%
[32, 33, 34, 46, 47, 56, 57, 58, 62]

:large_blue_circle:
com/starrocks/catalog/StructType.java
21
30
70.00%
[56, 68, 73, 74, 75, 76, 77, 89, 112]

:large_blue_circle:
com/starrocks/connector/ColumnTypeConverter.java
34
47
72.34%
[100, 315, 321, 419, 420, 421, 422, 423, 424, 425, 426, 429, 431]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/SubfieldOperator.java
32
36
88.89%
[39, 81, 92, 96]

:large_blue_circle:
com/starrocks/analysis/SlotRef.java
49
55
89.09%
[110, 111, 112, 154, 155, 373]

:large_blue_circle:
com/starrocks/sql/analyzer/Field.java
40
44
90.91%
[92, 96, 126, 155]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
13
14
92.86%
[214]

:large_blue_circle:
com/starrocks/sql/analyzer/SelectAnalyzer.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
26
26
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/TypeDef.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/ViewDefBuilder.java
13
13
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/QualifiedName.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/StructField.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/Expr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Type.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/OperatorType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
9
9
100.00%
[]

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 277 / 323 (85.76%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%
[946]

:large_blue_circle:
com/starrocks/analysis/SubfieldExpr.java
13
22
59.09%
[34, 35, 36, 48, 49, 58, 59, 60, 64]

:large_blue_circle:
com/starrocks/connector/ColumnTypeConverter.java
34
47
72.34%
[100, 315, 321, 419, 420, 421, 422, 423, 424, 425, 426, 429, 431]

:large_blue_circle:
com/starrocks/catalog/StructType.java
22
30
73.33%
[56, 68, 73, 74, 75, 76, 77, 112]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/SubfieldOperator.java
32
36
88.89%
[41, 83, 94, 98]

:large_blue_circle:
com/starrocks/analysis/SlotRef.java
49
55
89.09%
[110, 111, 112, 154, 155, 375]

:large_blue_circle:
com/starrocks/sql/analyzer/Field.java
40
44
90.91%
[92, 96, 126, 155]

:large_blue_circle:
com/starrocks/sql/analyzer/ExpressionAnalyzer.java
13
14
92.86%
[214]

:large_blue_circle:
com/starrocks/sql/analyzer/SelectAnalyzer.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
26
26
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/scalar/ScalarOperatorVisitor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/TypeDef.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/ViewDefBuilder.java
13
13
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/QualifiedName.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/StructField.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/analysis/Expr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/ScalarOperatorToExpr.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/OperatorType.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/transformer/SqlToScalarOperatorTranslator.java
12
12
100.00%
[]

run starrocks_admit_test


400 error code on certain filenames

I get an error 400 if I try to upload files with semicolons, backslashes or newlines in the name.
(can ask cslr on IRC)

I believe I fixed this.
@ewhal