Upgrade molo.core and molo.surveys

Fixes surveys bug in character count widget.

https://github.com/praekelt/molo/compare/6.4.3...6.5.0
https://github.com/praekelt/molo.surveys/compare/6.3.2...6.4.5

Lots of changes to molo.surveys.

👍


IPL Chrome Extension

This chrome extension will help to check IPL cricket match status. Stay updated with the latest IPL cricket match status right from your Chrome browser! This extension is a must-have for all cricket enthusiasts.
hey @Sulagna-Dutta-Roy , please assign this issue to me.

This Issue already exists on this repository #58


Appender

Implements the possibility to append a dataframe with some common datatypes to an existing table.

#9 Contributes to this issue

Looks great. Thanks!


chore: add new tool contract

This adds the new tools contract only.
When a tool is located in /usr/local/buildpack/tools/v2/<TOOL>.sh then it is considered a new tool (in terms of contract) and will be installed with the methods defined in the defaults.sh.
When the tool is available in the old and new path, then the new path is preferred.

Shouldn't this be a new feature than a chore?

Yes, should be indeed a feature instead of a chore.
Just because we have no new tools it still could be used as new feature.


YAML speed up

Proposed changes:

fix #7952
fix #7953

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

@alwx Can you please request from @joejuzl ? Looking at the time today and my calandar tomorrow I won't get to it before my vacation.

@alwx How long does loading multiwoz with this take? You can re-use the test from my investigation PR https://github.com/RasaHQ/rasa/pull/7944

The duration of Multiwoz test from @wochinge's PR:
Before changes:
More than 1h and still running :(
After changes:
2059.36s call     tests/shared/importers/test_importer.py::test_profile_training_data_loading
(it's 0:34:24)

Thanks for sharing the reslts @alwx ! Is there a bigger speedup if we don't interpolate env variables or did your resolver fix already address things?

It seems like the biggest speedup is caused by this: https://github.com/RasaHQ/rasa/pull/7968/files#diff-2725ed843eaab36adb512c85fbed96f62150901754e5fcae30c182d54d80fa5eR184 and this one simple line: https://github.com/RasaHQ/rasa/pull/7968/files#diff-d0c59274cb6aad666a5addf9f758510ba9a2ecdcb48b08a16b904f90c980e017R326.
By doing this, we're not adding multiple resolvers, and by doing the first thing we're making the parsing much faster.


Retrying requests using backoff for API/web requests

Is your feature request related to a problem? Please describe.
It may be beneficial for us to use the backoff library to handle retrying failed requests and implement an exponentially increasing wait time between failed requests. I think that the python backoff library may be useful as it provides function decorators that could handle retrying failed Twitch API or SaltyBet state.json requests, with options for  constant/exponentially increasing wait times until successful response is received.
Native
If we wanted to use the requests library natively, this stackoverflow post shows a way we can use HTTPAdapter from requests.adapters to handle retries.
Using backoff library
Uses exponential backoff for retries when request exception occurs, prints to console on each retry, and attempts 10 retries before giving up and raising exception.
def backoff_hdlr(details):
    print ("Backing off {wait:0.1f} seconds after {tries} tries "
           "calling function {target} with args {args} and kwargs "
           "{kwargs}".format(**details))

@backoff.on_exception(backoff.expo,
                      requests.exceptions.RequestException,
                      on_backoff=backoff_hdlr,
                      max_tries=10)
def get_url(url):
    return requests.get(url)

Hey Zappy:
Would you like to work on this for me?  I'd like to use the Native approach you'd listed above if possible.
You don't have to by any means.  I just figured I'd ask because I've turned my attention to a completely different project for the time being.
If not, I'll get around to this eventually.  For now, I have the JSON exception throwing for us so we can catch exactly where it's returning None.

I did some stress tests with the SB website, even requesting content constantly didn't produce any invalid responses.
My thought process with implementing backoff is that I thought that this occasional JSON error might be the result of hitting an API request limit of some sort, or maybe the CDN was blocking our requests temporarily. But it doesn't seem like that's the case from my testing.
I will close this as it seems our 1 second delays between refreshing/requesting session seem sufficient for now.


How to define body param as required?

hi,
in my resources definition I have a POST endpoint to create an entity.
I didn't saw any documentation about body params, but i tried swagger.bodyParam and it worked.
I wonder, how can I define some properties as required and return 404 if they are not sent?
here is my endpoint definition:
createNew: {
    'spec': {
      "description": "Operations about swimmer",
      "path": "/swimmer",
      "notes": "",
      "summary": "Create a new swimmer",
      "method": "POST",
      "parameters": [
        swagger.bodyParam("swimmer", "", "Swimmer")

      ],
      "type": "Swimmer",
      "errorResponses": [swagger.errors.invalid('id'), swagger.errors.notFound('swimmer')],
      "nickname": "createSwimmer",
      produces: ["application/json"]
    },
    'action': function (req, res, next) {
    // do something - don't arrive here is some properties are not sent
      res.sendStatus(200);
    }
  }

Hi, you can make a parameter required, and the UI will not allow you to submit without it being passed.  The server, however, is up to you to throw the 404 (or more appropriately 400) if it's not passed outside of swagger ui.

This is handled in #209  The spec is the source of truth


fix: typo fix in utils.test.ts

emtpy -> empty

Fixes #IssueNumber
Changes proposed:

[ ] Add
[ ] Delete
[x] Fix
[ ] Prepare

My pleasure 🙏🏼


allow feed modification

To modify datafeed, as feeds are bond to adapter hash and aggregator hash it should be all removed and added

@Bisonai/orakl-team Off-chain aggregation does not utilize hash connection between adapter and aggregator. Once off-chain aggregation is deployed, it will be possible to modify feeds by updating orakl-config and restarting orakl node. Closing the issue.


Coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.18%. Comparing base (caa92fd) to head (474ff75).
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   97.19%   97.18%   -0.01%
==========================================
  Files          55       55
  Lines       16905    16746     -159
==========================================
- Hits        16430    16274     -156
+ Misses        475      472       -3

Flag
Coverage Δ

rust
97.18% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updating README.md.

The yum repos were removed from DTK by the ART team. In addition to the
technical reason for that, the logical reason is that DTK should already
include all the dependencies required for building an loading the
drivers (as this is the whole point of DTK to begging with), therefore,
there is no reason to install anything in the exampled described in the
documentation.
Also updated the way to get the driver-toolkit image for OCP release.
The short method can be interpreted differently on different
architectures  and the long version is more explicit.
Signed-off-by: Yoni Bettan<EMAIL_ADDRESS>
We already have some consumers that are hitting this issue as the documentation show how to install packages although the yum repos where already removed from the image.
https://issues.redhat.com/browse/OCPBUGSM-42828

/cc @yevgeny-shnaidman

/lgtm

/lgtm

/test ?

/retest


Index process IDs of progress messages (Part 2)

Requires PostgreSQL 9.5!

Code moved to multiapps-controller.


Homework

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 11
Score: 91.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 10
Score: 83.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 12
Score: 100.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 10
Score: 83.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 11
Score: 91.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 101
Score: 93.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 12
Score: 100.00%

Good Job!!!   @joyrich373
Python homework:

Total questions: 108
Correct answers: 108
Score: 100.00%

Numpy homework:

Total questions: 10
Correct answers: 10
Score: 100.00%

Pandas homework:

Total questions: 12
Correct answers: 12
Score: 100.00%

@joyrich373
还差五个扩展作业题目哈！加油💪🏻


Glossary documentation page "selector" link is broken

The Selector page link in the docs glossary page is being rendered as raw markdown, instead of as a link. This works in the github view at https://github.com/airbnb/enzyme/blob/master/docs/GLOSSARY.md.

Replicable across several browsers on macOS.

In case anyone else was having trouble reproducing, the problem can be observed at this URL: http://airbnb.io/enzyme/GLOSSARY.html#selector
Gitbook has an old open issue related to not parsing Markdown in glossary items:
https://github.com/GitbookIO/gitbook/issues/729 So looks like an upstream fix is needed.
In the meantime, Gitbook glossary items should render HTML (haven't tested this myself), so a workaround could be to change [Selector page](/docs/api/selector.md) to Selector page.


Version assistant nodes

Will mark this ready for review when the base branch is merged
Description

Version the linked assistant when the node is being versioned
Allow only working version pipelines to be linked to an experiment

User Impact

More stable assistant pipelines
Demo

N/A
Docs

N/A

Codecov Report
Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

apps/pipelines/models.py
92.30%
1 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


Dependencies added in build.gradle.kts should override IDE dependencies.

Describe the bug
The dependency added in build.gradle.kts is invalid when it conflicts with IDE internal dependencies, IDE still only recognizes IDEA internal dependencies.
For example:
I added version 1.15.2 of jgroup to build.gradle.kts:
dependencies {
    implementation("org.jsoup:jsoup:1.15.2")
}

IDEA has other version of jgroup, when I use the related API, the IDEA recognizes the built-in version first:

This makes IDEA's behavior in code completion, prompting, etc. inconsistent with expectations.
Such as the following code:
Jsoup.parse(html)
    .body()
    .selectFirst(".content")
    ?.insertChildren(0, Element("div"))

This code will have a warning:

IDEA's suggested code is:
Jsoup.parse(html)
    .body()
    .selectFirst(".content")
    .insertChildren(0, Element("div"))

However, the suggested code may throw a NullPointerException at runtime, which IDEA should recognize as a compilation error:

To Reproduce
Expected behavior
Dependencies added in build.gradle.kts should override IDE dependencies.
Environment:

OS: Windows 11
Gradle IntelliJ Plugin Version 1.7.0
Gradle Version 7.4.2

Additional context
Related iusse and post:
#656
Class Loaders.

It turned out that there's something wrong with Gradle itself. The Gradle IntelliJ Plugin creates custom configurations that hold extra dependencies, like the idea configuration adds com.jetbrains:ideaIC:222-EAP-SNAPSHOT to your classpath.
In Gradle, if you extend one configuration with another using extendsFrom, and there are already more configurations inherited, they’ll be sorted alphabetically.
That means the dependencies they contain will appear in the final configuration in the same order as their containers do.
This is why idea (and IDEA libraries) take precedence over implementation configuration and dependencies you configure in the project.
I have prefixed all custom configurations with z##_ so they'll hit the end of the list, and since now, your libraries will be considered first.
To me, this is clearly a Gradle issue – but finally, I have hunted this behavior down.

It seems the corresponding changes may break compilation.
For example, if you try to use gradle-intellij-plugin 1.8.0 to build IntelliJ Rust plugin using CLion as base IDE, it will fail
It seems it because CLion libs contain some old version of jetbrains-annotations where Nls doesn't have ElementType.TYPE_USE target and in combination with recent changes in classpath ordering, now the compilation tries to use lib from CLion instead of org.jetbrains:annotations:23.0.0 defined by gradle-intellij-plugin
Moreother, if I add implementation("org.jetbrains:annotations:23.0.0") dependency manually to my plugin, it won't help


[Suggestion] Zinc ore piece and cnunks

This ore is present, example, in railcraft mod. By use zinc maybe get brass, which is used in some recipes in another mods. So i think it would be nice add this ore in the mod.

Added in release 0.4.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 444

Questions ?
Please refer to the Backport tool documentation


Update deploy manifests when building operator image

Noticed this while testing https://github.com/GoogleCloudPlatform/prometheus-engine/pull/273, it's a little more convenient when this command updates the deploy manifests too.
So for example, when running the steps in https://github.com/GoogleCloudPlatform/prometheus-engine/blob/v0.4.3/cmd/operator/README.md#run they will work with custom built images (ie when running make operator to build new code)

ping @andysim3d
is this okay to merge? I think it will make local testing easier


Hotfix - #37 - catch also php 7 throwables

Provides tests for #37

Would this not fail on PHP 5.6 because the class Throwable doesn't exist?

@nesl247 PHP < 7 doesn't appear to complain when Throwable is inside of a catch block. See example: http://sandbox.onlinephpfunctions.com/code/66997de5290d58dca15462e867224c9da62e3e14

Very interesting. I really hope this gets merged in soon then.

@nesl247 type-hints are not causing any autoloading, so it would just be ignored ;-)


 However, the RollResult class structure / output doesn't contain that information, just the results after the roll calculation.
I would love an additional property added to the RollResult class that shows the die type used to generate that roll result. ie:
"rolls": [{
"sides": d20, // or even just 20   <-----
"calculationValue": 4,
"initialValue": 4,
"modifierFlags": "",
"modifiers": [],
"type": "result",
"useInTotal": true,
"value": 4
// ... ect
}]
I've tried trying to customize the RollResult class to capture this, but I am having a hard time... Honestly, TypeScript is well out of my wheelhouse... If anyone has a suggestion so I can implement this on my own, I am all ears!
Thanks in advance. Please let me know if you need more info from me :)

Yeah, this is actually what I was trying to get at by asking this question (https://github.com/dice-roller/rpg-dice-roller/issues/241). This would be super useful!

I put together PR #244 as an attempt to get this implemented. Thanks @GreenImp for making this such an easy and pleasant project to work on!

Thanks @erik-jenkins! I'll check out your pull request and see if I can leverage that as well if that's alright with you :) I agree, I would love to see both of what we're asking for implemented in the source itself. Good luck with whatever you're working on!

Just thinking about this, and I'm not sure how feasible it would be, but would it make sense to store the actual Dice object against the Result object, rather than just a string side?

I just put up PR #252 to try that out, it seems to work pretty well! The one thing I haven't tried yet is to see how serialization of the RollResult is affected.

Bumping this - I wanted to use it with a deterministic 3d dice roller, which requires knowing both the results and the die types


Track application lifecycle

We should be tracking the application lifecycle like open/close events

@chrisrecalis when you get a chance can you link to the framework you found that track's these on Android?


Meridio Operator: add ASN and hold-time in Gateway CRD

ASN and hold-time should be runtime configurable
This needs an update in gateway CRD and controller

https://github.com/Nordix/Meridio-Operator/pull/11


Failing AST column recognition attempt 2

I tried to revive the old branch in order to get back to the solution that worked (as per https://github.com/staabm/phpstan-dba/pull/580#issuecomment-1475130801), lets see whether the tests go through

Hey @jakubvojacek, thanks for working on this! I'm looking forward to this fix, as it's a big factor holding me back from enabling SQL AST.
One thing I noticed is that a lot of the existing tests assert the wrong types due to this bug, so we don't actually want them to pass without being modified (to the best of my knowledge). I've documented some of the examples in https://github.com/staabm/phpstan-dba/issues/578.
My apologies if I've commented before you were done with the PR!

Hello @hemberger, I believe this PR is ready.
Which of the tests that are now passing shouldn't be?
I checked with the sample
$stmt = $pdo->query('SELECT avg(freigabe1u1) from ada');

and the expected output in this PR would be PDOStatement<array{avg(freigabe1u1): int<-128, 127>|null, 0: int<-128, 127>|null}> which is correct, right?
Thanks

and the expected output in this PR would be PDOStatement<array{avg(freigabe1u1): int<-128, 127>|null, 0: int<-128, 127>|null}> which is correct, right?

Since avg is not restricted to integer output, the expected type here, to the best of my knowledge, should be:
PDOStatement<array{avg(freigabe1u1): numeric-string|null, 0: numeric-string|null}>

Looking at the max test in its current form:
stmt = $pdo->query('SELECT max(freigabe1u1) as max from ada');
assertType('PDOStatement<array{max: int<-128, 127>|null, 0: int<-128, 127>|null}>', $stmt);

The expected type should be:
PDOStatement<array{max: int<-32768, 32767>|null, 0: int<-32768, 32767>|null}>

because the freigabe1u1 column is a SMALLINT, not a TINYINT.

Which of the tests that are now passing shouldn't be?

I think many of the aggregate functions are still wrong (e.g. avg, sum, min, max). Maybe that means there is a bug somewhere outside this PR, but something somewhere seems not quite right.
I wonder if it would be helpful to test the queries with and without the aliases, as well?
Thanks again for your work here. Can't wait to use it! :)

Maybe that means there is a bug somewhere outside this PR, but something somewhere seems not quite right.

that is most likely it.
This PR only fixed that a column with an alias has same output as without it, eg
-assertType('PDOStatement<array{myemail: int<0, max>|null, 0: int<0, max>|null, count(email): int, 1: int<0, max>|null}>', $stmt);
+assertType('PDOStatement<array{myemail: int<0, max>|null, 0: int<0, max>|null, count(email): int<0, max>|null, 1: int<0, max>|null}>', $stmt);

After this PR, count(email) is same that as key 1
But you're right it seems, freigabe1u1 is a small signed int and the range is incorrect there, right @staabm ?
But that should be addressed by another PR I guess?

@staabm @hemberger  I narrowed the problem down to MysqlTypeMapper (https://github.com/staabm/phpstan-dba/blob/main/src/TypeMapping/MysqlTypeMapper.php#L96)
It resolves the range based on display width (length) which isnt correct apparently. It should be done based on native_type? Below is a sample of the ada table. Columns adaid and freigabe1u1 have same antive_type but different display width. We should disregard the display width completely.
^ array:4 [
  0 => array:7 [
    "native_type" => "SHORT"
    "pdo_type" => 1
    "flags" => array:3 [
      0 => "not_null"
      1 => "primary_key"
      2 => "NUM"
    ]
    "table" => "ada"
    "name" => "adaid"
    "len" => 6
    "precision" => 0
  ]
  1 => array:7 [
    "native_type" => "TINY"
    "pdo_type" => 1
    "flags" => array:2 [
      0 => "not_null"
      1 => "NUM"
    ]
    "table" => "ada"
    "name" => "gesperrt"
    "len" => 1
    "precision" => 0
  ]
  2 => array:7 [
    "native_type" => "VAR_STRING"
    "pdo_type" => 2
    "flags" => array:1 [
      0 => "not_null"
    ]
    "table" => "ada"
    "name" => "email"
    "len" => 400
    "precision" => 0
  ]
  3 => array:7 [
    "native_type" => "SHORT"
    "pdo_type" => 1
    "flags" => array:2 [
      0 => "not_null"
      1 => "NUM"
    ]
    "table" => "ada"
    "name" => "freigabe1u1"
    "len" => 1
    "precision" => 0
  ]
]

https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html

The display width does not constrain the range of values that can be stored in the column.

It resolves the range based on display width (length) which isnt correct apparently.

Please open a new issue with the posted findings

thank you


Does RSA use auxiliary primes compliant with NIST 186-4?

Good Afternoon.
It appears that the auxiliary primes in RSA (p1, p2, q1, q2) are hardcoded at 101-bits.
(These are the values which are the precursors to p and q)
NIST 186-4 indicates in Table B.1, that:

A 2048-bit key would require auxiliary primes > 140-bits; and
A 3072-bit key would require auxiliary primes > 170-bits.

Can anyone please confirm whether or not the auxiliary primes are compliant with NIST 186-4?
Thanks for your time.

The FIPS provider in OpenSSL 3.0 should be compliant with FIPS 186-4 section B.3.6.  It will be once it finishes the validation process but before then it's not possible to know if changes will be required.  If you need FIPS 186-4 compliance this is the only way to guarantee it.
Outside of the FIPS provider, they can be compliant but this hasn't and won't be formally validated.  It is also possible to generate non-compliant keys.
OpenSSL versions before 3.0 are not FIPS 186-4 compliant and never will be.

It appears that the auxiliary primes in RSA (p1, p2, q1, q2) are hardcoded at 101-bits.
(These are the values which are the precursors to p and q)

Could you tell please, where you see this hardcoded 101 bits value? I do not see that in the code. The functions bn_rsa_fips186_5_aux_prime_min_size() and bn_rsa_fips186_5_aux_prime_max_sum_size_for_prob_primes() determine the sizes and they are according to the FIPS 186-5 (which is compatible with FIPS 186-4 values).

The FIPS provider in OpenSSL 3.0 should be compliant with FIPS 186-4 section B.3.6. It will be once it finishes the validation process but before then it's not possible to know if changes will be required. If you need FIPS 186-4 compliance this is the only way to guarantee it.
Outside of the FIPS provider, they can be compliant but this hasn't and won't be formally validated. It is also possible to generate non-compliant keys.
OpenSSL versions before 3.0 are not FIPS 186-4 compliant and never will be.

Thank You.

It appears that the auxiliary primes in RSA (p1, p2, q1, q2) are hardcoded at 101-bits.
(These are the values which are the precursors to p and q)

Could you tell please, where you see this hardcoded 101 bits value? I do not see that in the code. The functions bn_rsa_fips186_5_aux_prime_min_size() and bn_rsa_fips186_5_aux_prime_max_sum_size_for_prob_primes() determine the sizes and they are according to the FIPS 186-5 (which is compatible with FIPS 186-4 values).

Thanks for the reply.
The code I was looking at is /crypto/bn/bn_x931p.c lines 234 and 236.

The code I was looking at is /crypto/bn/bn_x931p.c lines 234 and 236.

That code is not used by the fips provider at all.

Ok thanks.


[Bug] [dolphinscheduler-server] memory leak of logger

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
memory leak of logger , worker not work  after long time run
What you expected to happen
worker run stable
How to reproduce
memory leak of logger , worker not work  after long time run
Anything else
No response
Version
dev
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

branch 2.0.2-prepare


Added our standard python devcontainer

Please merge asap, it can also be adjusted later. It is the same as in the midterm.

@HeshamElsaman @dnxjayPlease review this asap so people can begin their assignments.

Im gonna merge this just so others can use it.


fix 'go mod tidy' failure on backplane-2.0 branch

The related issue: https://github.com/stolostron/backlog/issues/26333
Signed-off-by: Yang Le<EMAIL_ADDRESS>

/lgtm


Enclose path to catalina.jar in quotes

This should fix the issue where we can't add a Tomcat Server that contains spaces in its path.

many thanks


Brian Munene: Student- Bio

Checklists
General Checks

[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[x] is linked to an issue (if it is related)
[x] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

Thank you for the kind feedback @bermarte  and @yildiztugba. I'll go ahead and move the deliverable to the right column on the project board.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Swarnendu Bhandari
Discord Username (if applicable)
No response
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Double enter resets dropdown to the first value

How to reproduce: start from this page,
then select any cell and change its value from 'A' to 'C'.
Then press enter to start editing the cell, and dropdown will appear:

Strangely, while dropdown is aware that correct value is C, and C is in the cell, the 'selected' value is the first one in the list, i.e. 'A'.
When user presses 'enter', it is quite intuitive to expect that cell's value will not change (as with sting input, enter starts editing and enter exits editing, so double enter does not change value). However in case of dropdown value 'A' will be set.

Fixed in 5.1.0


Add ViewsTest.testDocTypes unit test

Add ViewsTest.testDocTypes to test View.documentType feature.
https://github.com/couchbase/couchbase-lite-java-core/issues/872

Once java-core and java-forestdb is merged, this PR can be merged.


Update @typespec/migrate to work with updated semver package

Fix #2195.

@tjprescott, @timotheeguerin: Think it's worth hotfixing this?  I know at least one customer was blocked by it.

I’m still oof today so can’t double check but I don’t think this is blocking when migrating they can always provide the —version=old version to be explicit

I’m still oof today so can’t double check but I don’t think this is blocking when migrating they can always provide the —version=old version to be explicit

If you're talking about the --tspVersion option, I don't think it's a workaround:
$ npx @typespec/migrate --tspVersion 0.46.0
TypeSpec migration tool v0.46.0

Current Typespec version 0.46.0.
TypeError: Invalid Version: 0.38

I would recommend hotfixing this but it's up to the TypeSpec team.

If you pass without the patch —tspVersion 0.38

If you pass without the patch —tspVersion 0.38

$ npx @typespec/migrate --tspVersion 0.38
TypeSpec migration tool v0.46.0

Current Typespec version 0.38.
TypeError: Invalid Version: 0.38

Hhm then I guess probably worthy an hot fix

@timotheeguerin: Should I open an issue to request hotfixing this?  Is there a special process to request hotfixes?

cc @markcowl


Expense - From expense report page tapping app's back button navigated to Workspace chat page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests
Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab - new workspace
Create 2 expenses
Open the expense and navigate to the report page
Tap the app's back button

Expected Result:
From expense report page tapping app's back button user must be navigated to workspace chat page.
Actual Result:
From expense report page tapping app's back button user navigated to LHN instead workspace chat page.
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/1594f7b4-46f4-4e84-bc97-a560a20b76d2
View all open jobs on GitHub

Looooks like the same as https://github.com/Expensify/App/issues/54496

PR Merged & CP'd, waiting on test!

Bug is not reproduced
https://github.com/user-attachments/assets/71b408a4-73a5-4769-b811-cc51b64e62d2

Nice! Fixed, so closing this out


[FR] Assign Bar Code to Part

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

Problem statement
(maybe I was too dumb to find it in InvenTree and it is already possible - my deepest apologies if that is the case)
In my system, I have parts that have serial numbers (and everyone has their own bar code /= stock item) and I have parts that don't have a serial number e.g. cables or adapters. I still want to be able to assign a bar code to these components and ideally, they would all have the same bar code.
Suggested solution
I'd like to be able to assign a bar code to the Part and by scanning an the bar code being referred to the Part instead of concrete Stock Item.
Describe alternatives you've considered
I'd be very happy on input concerning this topic.
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

hi there @Rincewind34
This should be already possible; You can link the part but not the non-serialised stock-item.

Is this what you are looking for?

@matmair Yes, I wasn't running the lastest development version but saw it in the source code. Thanks!

@Rincewind34 you do not need to be; if you have time you could verify on the demo - that is running bleeding edge.

@Rincewind34 this feature will be released to "stable" when 0.9.0 is available :)


Skip with warn for circular symlinks

Skip with warn for circular symlinks, instead of exit with error.
Fix #168

Why does this require a change to warn? Can't you just handle error instead?

Current error means _onError will call destroy and abort the stream.
no more entries, warning or errors are emitted

while my use case is to skip and let the stream continue flowing.
Also, thrown error does not have a code to match it properly.
With this PR it emits a warn event, and indeed with given code someone can use it to abort or not.
// Optionally call stream.destroy() in `warn()` ...


Add a armv6hf crossbuild target

This is mainly from https://github.com/plietar/librespot/pull/202/ with a few changes.
mainly, moved the raspberrypi-tools/ download into the Dockerfile so that it can be cached.

Can anyone else confirm this works? Don't have docker installed/set up to test this. @ComlOnline @awiouy

Running it now.

Side note  --
While this works with libasound2_1.0.25-4, I can't seem to compile successfully with the newer libasound2_1.1.3-5 version. The compiler complains about a missing ld-linux-armhf.so.3
 = note: /pi-tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64/bin/../lib/gcc/arm-linux-gnueabihf/4.8.3/../../../../arm-linux-gnueabihf/bin/ld: warning: ld-linux-armhf.so.3, needed by /pi-tools/arm-bcm2708/arm-bcm2708hardfp-linux-gnueabi/arm-bcm2708hardfp-linux-gnueabi/sysroot/usr/lib/arm-linux-gnueabihf/libasound.so, not found (try using -rpath or -rpath-link)
          /pi-tools/arm-bcm2708/arm-bcm2708hardfp-linux-gnueabi/arm-bcm2708hardfp-linux-gnueabi/sysroot/usr/lib/arm-linux-gnueabihf/libasound.so: undefined reference to<EMAIL_ADDRESS>
This happens even when I link it with ln -s ld-linux.so.3 $SYSROOT/lib/ld-linux-armhf.so.3
Any ideas?

I did a similar cleanup and ended up with https://github.com/kingosticks/librespot/blob/rpi-docker/contrib/docker-build-pi-armv6hf.sh but i like your dkpg -x trick, much neater.
Looks like libasound2_1.0.25-4 requires GLIBC 2.16 but the sysroot has glibc 2.13 to remain compatible with Debian Wheezy.

Will try compiling later.

Also there's a typo @ashthespy you need to run the command docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

I did a similar cleanup and ended up with https://github.com/kingosticks/librespot/blob/rpi-docker/contrib/docker-build-pi-armv6hf.sh but i like your dkpg -x trick, much neater.

Ah - nice! Likewise for the loop ;-) my shell scripting know-how is still neweb level would you mind if mash yours in here as well?

Looks like libasound2_1.0.25-4 requires GLIBC 2.16 but the sysroot has glibc 2.13 to remain compatible with Debian Wheezy (which is desirable).

You mean libasound2_1.1.3-5 requires GLIBC 2.16 right,  1.0.25-4 works fine so far
I didn't really look into alsa's changelog to see if there is any benefit of udating from 1.0.25-4 - don't fix what is not broken policy?

Also there's a typo @ashthespy you need to run the command docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

Oops, sorry!

You mean libasound2_1.1.3-5 requires GLIBC 2.16 right,
Yep! That's exactly what I meant to say. I agree: if it's not broke, don't fix it.

Yup, lets just leave alsa at the current version. If you could push a commit to correct that typo, I'll merge this.

I'm getting a permission denied error when running it at the moment, but I think that could just be my setup. Ill keep digging.

I'm getting a permission denied error when running it at the moment, but I think that could just be my setup. Ill keep digging.

FWIW: I use docker on windows and as it says:
Successfully tagged librespot-cross:latest
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host.
All files and directories added to build context will have '-rwxr-xr-x' permissions.
It is recommended to double check and reset permissions for sensitive files and directories.

Dunno if this is causing issues?

This is the exact error I'm getting
user@docker3-vm:~/gits/librespot$ docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh
docker: Error response from daemon: OCI runtime create failed: container_linux.go:296: starting container process caused "exec: \"contrib/docker-build-pi-armv6hf.sh\": permission denied": unknown.
ERRO[0000] error waiting for container: context canceled

I have a few hours of work to do before I can look again but like I said it could just be my environment.

Oh dang. it should be /src/contrib/docker-build-pi-armv6hf.sh meh.

@ashthespy it shouldn't be /src/contrib/docker-build-pi-armv6hf.sh the complete command would be docker run -v /tmp/librespot-build:/build contrib/librespot-cross docker-build-pi-armv6hf.sh
@ComlOnline thats a problem with your docker environment.

@sashahilton00 I thought as much. More troubleshooting to be done on my end.

@ashthespy it shouldn't be /src/contrib/docker-build-pi-armv6hf.sh the complete command would be docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

Right - glossed over the WORKDIR /src line in the Dockerfile.
Should I revert this? Or close and submit a new pull request with a cleaner tree?

I've got it!
The new file is not executable!

I switch b/w windows and windows sub system for linux -- sorry!

No worries, its happened to me too many times. :( I think I may have undone your previous commit in the process though.

 contrib/docker-build-pi-armv6hf.sh 100644 → 100755

looks good to me?
TBH, I recently changed my git config to git config core.filemode false but will turn it back on now!

Thats what I thought, but notice it says two files modified and the docker command is docker run -v /tmp/librespot-build:/build contrib/librespot-cross docker-build-pi-armv6hf.sh again. With the contrib/ in the wrong place :/

I can fix permissions , squash and force push if you'd like to keep a clean tree?

Squashing it works for me.

Yup squash and once tested will merge.

I am lost - I just pulled my branch from 40d7960 and the file seems to already have the 755 permissions?
I'm guessing the Coml's branch was tracking the old commit that was squashed? Can someone counter check?
PS, I also found git update-index --chmod=+x <file> that will ensure I don't make such a mess again!

Okay, everything looks good from my side - can be merged when tested :-)

@ashthespy the command is still wrong. docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh is what it should be.

Looks good to me. Ill merge it in a few hours unless anyone has a problem. :) Thanks @ashthespy


feat(amplify-function-plugin-interface): template provider runtime info

Issue #, if available:
Description of changes:
Added support for providing runtime info to template providers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3731 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ed3c4...5391474. Read the comment docs.

Happy to merge this change, but can you separate it out so that only the platform changes are in this PR?


Event onclick is not saving in HTML regions

Hi. The error I've seen is that the CMS is not showing the onclick events in an HTML region. I'm saving that HTML directly to the database, when I'm going to edit it on the CMS, the onclick event are not being retrieved, when save changes obviously the onclick event is lost.

I'm not following 100%. If you are meaning that the HTML-editor removes onClick javascript events you've pasted into the editor that might be true as the TinyMCE by default "cleans" the given input before loading & saving it.
If you need to add this kind of stuff in the editor you can customize the editor setup in your installation, take a look here:
http://piranhacms.org/customizing-the-html-editor
The blog post is for the old version of the editor, so you need to get the newest setup from the repo here:
https://github.com/PiranhaCMS/Piranha/blob/master/Core/Piranha/Areas/Manager/Views/Shared/Partial/TinyMCE.cshtml
but apart from that it still applies.
To see how you can customize the editor, please go to the official homepage of TinyMCE:
https://www.tinymce.com/
Regards


Annotate std/file.d to please dlang/dmd#12520

Part of #8076
The https://github.com/dlang/phobos/pull/8107 and this PR are the two remaining Phobos blockers for dlang/dmd#12520.

The error
https://app.circleci.com/pipelines/github/dlang/phobos/4283/workflows/2afbc2b3-25c7-45de-ac15-3651b9e6de90/jobs/13832
doesn't trigger locally for me when doing
make -f posix.mak unittests
locally in phobos root.

Compiles locally now using dlang/dmd#12520. Yay! Removed WIP in title. Ready for review and auto-merge now.

Does anybody know why Ubuntu 16.04 x86 and macOS 10.15 x64 fails? Restart?

I restarted the failing tests. Let's see.


Enhancement - Dynamic input distribution

Current implementation make equal chunks and send for scan. But if one chunk takes more time to complete the job all other machine sits idle. There is an option -d to delete upon completion but this is not helpful if some chunk requires more time.
Instead of making static chunk like lines_count(input_file)/len(fleet), dynamically distributing using a loop by sending few lines for fleet be helpful.

I hope I'm not replying too late
I will spend some time to think abount an implemetation for this problem


ENH: Removing relative header imports from multiple cxx files

Removing relative imports from files in Modules including Filtering, Core, IO, Numerics, Registration, Segmentation.
Four more files remaining under ThirdParty/KWIML/src/itkkwiml/test.

PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)
[X] Added test (or behavior not changed)
[X] Updated API documentation (or API not changed)
[X] Added license to new files (if any)
[X] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[X] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

We should not modify stuff inside Modules/ThirdParty/. Also, stuff inside that directory should not have tests. Most update scripts exclude tests.

Yes, that's why I didn't include those.


RYO Token smart contract - Minime upgradable functionality

The RYO token must be upgradable with new functionality. We should use the minime technology (described here: https://medium.com/giveth/the-minime-token-open-sourced-by-giveth-2710c0210787) to allow us to upgrade the token later.
It is important for us to be the only ones to be able to clone RYO, for rather obvious reasons.

We've written our own upgradable functionality. It's notable in the contracts/Versioned.sol contract. It implicitly uses a few other bits we wrote for this purpose.


Remix 1.16.1 Express Server doesn't load JS interactivity in Prod environment

What version of Remix are you using?
1.16.1
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
// remix.config.js

  serverModuleFormat: "esm",
  future: {
    v2_errorBoundary: true,
    unstable_dev: true,
  },

// node scripts
"dev": "remix dev -c \"node server.js\"",
"remix-build": "remix build",
"remix-start": "cross-env NODE_ENV=production node ./server.js",

Expected Behavior
Prod build should have js interactivity just like dev build
Actual Behavior
There is no issue with npm run dev
For my production build I first run npm run remix-build and then node server.js
The page loads with server rendered react components but none of the interactive parts work ie tooltips, combobox react components do nothing on mouse clicks
I also see this error on production build in browser console for every page I navigate to

This is hard to triage much further without a reproduction, but seems like it might be an issue with some library used by your app that's getting bundled.  Do you have anything calling an install() method?  Can you dig into the source maps a bit and see if you can narrow it down to where it's coming from?  Or start removing portions of the loaders/actions on the page it's happening on to see if you can find the problematic code?

Can confirm that the bug is with upgrade to either 1.16.0 or 1.16.1, because when I comment out unstable_dev: true from remix.config.js, js interactivity is back in production builds

Can you provide a minimal reproduction?  The fact that @remix-run/node code is ending up in your browser confirms that server code is ending up in the client bundle, potentially from something being imported into a loader/action that is unable to be tree shaken out of the client bundle.

I have import { json, redirect } from "@remix-run/node"; in my jsx files but also importing just json in app/routes/api like so:
`
// app/routes/api/get-filters.js
import { json } from "@remix-run/node";
export async function getFilters({}) {
// get filters
return json(filters)
}
// app/view/create-view.jsx
import { json } from "@remix-run/node";
import { getFilters } from "../api/get-filters";
export const loader = async({ request }) => {
const filters = wait getFilters({ request });
// get other pieces of data with api structure similar to above
return json({
filters,
...restOfData
})
}
`
Can this pattern cause @remix-run/node to end up in server code landing in browser?

It's possible - you are basically nesting calls to json at the moment which probably won't work as you expect.  If you want to re-use the getFilters logic I would extract that to a shared location that just returns the filters and then you can use it from both loaders.
I would need a minimal reproduction to debug further though.

sadly am also having this exact issue, @morsmodr were you able to fix it?

i ended up create new remix-app from scratch in remix 1.17.1, then copying all routes and utils files to the new project


[Refactor] Move default_scheduler_interval_millisecond from FeConstants to Config

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：
We would like to customize the default_scheduler_interval_millisecond to enable faster schema changes (ALTER TABLEs).
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

Maybe also add a new config just for Alter, so changing it won't change other components' behavior?

[FE PR Coverage Check]
:heart_eyes: pass : 4 / 4 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/Config.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/load/routineload/RoutineLoadScheduler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/alter/AlterHandler.java
1
1
100.00%
[]


[RTOS] Design startup sequence for admin/normal operation

After the BPS faults due to low voltage, the next boot will automatically trip the system (opening the contactor). If we have a computer plugged in, during startup we should forcefully close the contactor so we can charge the battery to a point where it won't trip.
In the original loop during before anything is checked, there is a start up period that waits for an input from the keyboard to place the system in admin level to forcefully turn on the contactor. In this new rtos implementation, we have the ability to spawn and kill threads as we like. In the main loop instead of spawning all the necessary tasks, we should implement a state machine that spawns all threads for normal operation and spawn certain/different threads for admin operation.

@SijWoo @alekxoo I think it would make sense to do this as part of the initialization task because that is where we do this in the non-RTOS version of the BPS. What do you think?

That makes sense to me! Also I don't think I included this anywhere but we need to also check if the watchdog timer triggered previosuly

After looking at this some more, I think it might make more sense to put this in the critical state thread than in the initialization thread because the critical state thread is what decides to turn on the contactor. I think it makes more sense for the initialization thread to only initialize the fault state sem4, critical state sem4, all of the other threads, and nothing else. What do you think @SijWoo


Installation issues

Readme says install pip2 and then runs using python3 . Which version of python and pip does it require ?
While running it requires ros no installation for ros mentioned?
Please use anaconda or virtualenv based installation in the readme of installation as you dont want to mess up the global environemnt of the user.
Ros requires python 2 , your code requires python 3 please fix the dependency and make it simple to the user

Create a diagram explaining all the dependency required for your system to run. and put in README


feat(meta): Rename ProfileResource to DeviceCommand for V2 API

Close #3119
PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?

Issue Number: #3119
What is the new behavior?
Rename ProfileResource to DeviceCommand for V2 API
Does this PR introduce a breaking change?

[ ] Yes
[x] No

New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

This PR should hold until https://github.com/edgexfoundry/go-mod-core-contracts/pull/482 merge.

Rebased and upgrade go-mod-core-contract lib to v2.0.0-dev.19


[SEDONA-179] Claim OGC compliance.

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-179. The PR name follows the format [SEDONA-179] my subject.

What changes were proposed in this PR?
The most relevant parts of OGC sfs tests for Geometry types and functions are implemented.
Findings: Two functions are not compliant plus some functions are not implemented in Sedona.
Tests for those are ignored with comments.
How was this patch tested?
Test suite.
Did this PR include necessary documentation updates?

No, this PR does not affect any public API so no need to change the docs.

@BarbieQkiller Thanks for this great PR. I have updated SEDONA-179 to reflect the latest progress and I also created a number of tickets to fix these tests.
A few questions:

I didn't see Test 51 here. Is there a particular reason?
I didn't see PostGIS implements PolygonFromWKB for Test 9. Do you know how they handle this case?

Thanks, Jia

Thank you for your kind response!

I simply missed that one, apologies. I will update the PR.
T9 verifies ST_AsBinary the missing PolygonFromWKB shouldn't be a problem.
https://github.com/postgis/postgis/blob/f6def67654c25d812446239036cee44812613748/extras/ogc_test_suite/2_queries.sql#L255

Best regards
/Angela

Added the missing test.
BR,
/Angela


About how to use rotation from anygrasp，and why use points_y.

Thank you very much for such a good open source work. I have a question. Does the rotation obtained by anygrasp need to be multiplied by a matrix before it can be used? And why points_y at link needs to be negative?

Yes, the original anygrap gripper pose is grounded in coordinate frame specified by robot head camera. However, during manipulation every action is grounded in coordinate frame specified by the robot gripper, so rotation is needed. We have already included multiplication of rotation matrix between different coordinate frames in our codes.
Besides the rotation matrix between different coordinate frames, we also noticed that the images taken by robot realsense head camera are rotated by 90 degrees. So when computing depth we also needed some transformations to make sure computed pointcloud (x, y, z) is grounded in correct world frame. -points_y is one step of this transformation

Your response is important to me. Thank you for replying quickly.


Improve install .sh  scripts

WIP

Why did you merge it, it wasn't ready 😩

Why did you merge it, it wasn't ready 😩

reverted.


add introduction doc of resource health bb

@dovydas-an
The path technical/resource-health does not lead anywhere. The prior technical/resource-health.md was to a holding 'coming soon' page.
The expectation is that a dedicated 'Resource Health' doc will be created - that will be linked as a RtD sub-project under the path /projects/resource-health.
For example, - MLOps: /projects/mlops which links to https://eoepca.readthedocs.io/projects/mlops.

@rconway my bad there, did not update the path properly the first time to /projects/resource-health.

@rconway my bad there, did not update the path properly the first time to /projects/resource-health.

@dovydas-an And we need to add your doc as a RtD project


Fix periodic inference during training

Problem: Enabling the generation block crashes the program
Solution: Change the variable names for x and y so that it does not affect downstream code
Testing: Runs as expected with tinyshakespeare

I think this is the problematic part. If the condition is not met, it is not overwritten.


doesn't show thumbnails in firefox

great extension
but doesn't show video thumbnails in firefox

It may require more browser source (like RAM and CPU) and slow-down your browser (even your computer) when you are browsing a folder has a lot of video. However having a option is still good idea, I will add this feature in next version of extension with a potential resource usage warning.

Thank you. it will be wonderful.


Apply a funding fee on rollover

Begins to address https://github.com/get10101/meta/issues/330.
This PR does not address the app's side, which amounts to displaying the next funding rate, seeing paid funding rates, etc.

Superseded by #2584.


docs, tools: add local link checker

Add tools/check_links.py script, that checks that all local links from documentation files are valid
Fix some of the invalid links that we had
Makes travis buildbot check them as well
Move linux kernel specific docs to docs/linux/
Various fixes and improvements

LGTM
I see it was helpful!


Q: Exisiting modules to pass between QubitOperator to Circuits.

Hi all,
Sorry for bothering with this question.
I recently have been working with Cirq and OpenFermion-Cirq and I would like to ask if a module that allows one to go from QubitOperator (or any other OpenFermion object) to a circuit (potentially parametrized) already exist in either Cirq or OpenFermion-Cirq.
Before asking this I dug into the code but I was unable to find any type of serializer/util. However, I found that the PauliString object could be the thing that allows me to go from Pauli strings (as QubitOperators) to a circuit, so does it exist a function to initialize PauliString from QubitOperator?
If not, I have been writing my own functions to do so, and I could commit them. Another question is where do they fit better, Cirq or OpenFermion-Cirq?
Best regards,
Xavi

Hey Xavi. This is a great question. To my knowledge we don't have this yet but it should be very high priority for us to develop that. Sure, open a PR! I would ask @mpharrigan to take a look at it. This is a fairly critical functionality however so @mpharrigan might have a lot of comments.

Hi @babbush ,
Thanks answering the question, if you agree I will close this issue.
I will open a PR with some stuff that I've done on putting QubitOperators to Cirq. I expect to get some feedback/help such that the functionalities are general enough, let's see how it goes.
Best,
Xavi

Great. We'll keep this open to track the issue and can close when the PR is merged

Hi Matthew,
No problem from my side to the issue open.
About the PR, I will probably make it with limited testing as I'm not (yet) familiar on how to test in Cirq. I will be very much grateful for any input you could provide me.
Best,
Xavi

happy to help. briefly, each python module my_module.py should have an associated my_module_test.py file containing functions whose name end in _test() that verifies the code is working via assertions

Did you ever happen to make any progress on this? I whipped together this naive implementation for my personal use:
def qubit_operator_to_pauli_sum(qubit_op):
    psum = cirq.PauliSum()
    for ind_ops, coeff in qubit_op.terms.items():
        if ind_ops == tuple():
            psum += coeff
            continue
        pstring = cirq.PauliString()
        for ind, op in ind_ops:
            if op == 'X':
                op = cirq.X
            elif op == 'Y':
                op = cirq.Y
            elif op == 'Z':
                op = cirq.Z

            pstring *= op(cirq.LineQubit(ind))
        psum += pstring * coeff

    return psum

Hi @mpharrigan ,
I actually do have something, and it is different than what you propose here. My function takes a qubit operator or a list of qubit operators and generates the first Trotter circuit of it.
If you think that it can be useful for other people I can take some time to finish up a decent PR.
Thanks for taking the time to write some code.
Best,
Xavi

Hi Matt,
Just to follow up on the OpenFermion meeting, I think I have much clearer picture of OpenFermion-Cirq.
I will clean up what I had in mind and PR here.
After that I will write code to pass between QubitOperator and PauliString and then we might decide how to move forward on this topic, and eventually extend it to other OpenFermion objects.
Best,
Xavi

Opened https://github.com/quantumlib/OpenFermion-Cirq/issues/372 for that issue

This issue has been resolved in OF.


Add back and barcode only renderMethods.

@wes-smith can you confirm that the PDF417 works for your toolchain? It's the "valid" one we used in the other examples.

@BigBlueHat confirmed


⚠ Bofrost.es has degraded performance

In 0343c4a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1693 ms

Resolved: Bofrost.es performance has improved in 6a39dde after 16 minutes.


On sign_in, devise_token_auth expects the uid to be the same as the email

I am using the rails-api gem,  devise_token_auth (0.1.30) and ng-token-auth "0.0.24".
When I try to log in, this is the dev.log:
Started POST "/api/auth/sign_in" for <IP_ADDRESS> at 2015-05-07 13:44:05 -0500
  ActiveRecord::SchemaMigration Load (0.3ms)  SELECT "schema_migrations".* FROM "schema_migrations"
Processing by DeviseTokenAuth::SessionsController#create as HTML
  Parameters<EMAIL_ADDRESS>"password"=>"[FILTERED]"}
  User Load (2.0ms)  SELECT  "users".* FROM "users"  WHERE<EMAIL_ADDRESS>AND provider='email')  ORDER BY "users"."id" ASC LIMIT 1
Completed 401 Unauthorized in 8ms (Views: 0.2ms | ActiveRecord: 3.8ms)

Here is a shot of the req/res headers:

Does anyone know why it expects the uid to be the email? (quoted from the dev.log) SELECT  "users".* FROM "users"  WHERE<EMAIL_ADDRESS>AND provider='email')
The only way I can get my login to work is by changing my model to self.uid = self.email but I'd rather not have to do that. Any help would be greatly appreciated.

+1

+1

Are you using the confirmable module? I ran into the same (I was changing my uid from the email to a random uuid) and was getting the 401 with the correct email and password but the account had not been confirmed yet. Once I confirmed the account through the email link it no longer attempted to use the uid to search the db, it used the email.

Are you using the confirmable module? I ran into the same issue (I was changing the uid to a random uuid) but after confirming the account (clicking the link in the email) the account works fine (uses email to search db for the email address instead of the uid field).

+1

+1, I've tried to get the uid to be something other than email but it seems that without overriding alot of the built-in functionality this isn't currently possible. It would be great, and I think safer, if we were able to use something more random, like uuid instead of the email. Is this something that's possible?

the uid field is the value that should map directly to the globally unique provider value. I guess the more important question is why are your email and uid values de-sync'd when using email as the provider?

Thanks for the reply, I don't think I understand the role that provider plays... Am I correct in thinking the provider value is the name of the globally unique field to be used?

there's a little more to that because of omniauth integration. For omniauth, the provider value will be something like facebook or google, etc. So in those cases, they're not mapped to local fields.

So would simply changing the provider value to say a newly created local field called "uuid" achieve what we are trying to achieve? I'd like to still use email to validate for login but token validation to happen using the uuid value instead of exposing the email address? I assumed there would be alot of overrides needed especially for other controllers (confirmations, etc) due this change, is there a simpler approach than that? Thanks again for taking time to answer.

Actually stumbled across https://github.com/lynndylanhurley/devise_token_auth/issues/29#issuecomment-56090454 and it doesn't seem like this can be done without a bit of further customization.

Going to go ahead and close this, as SessionsController needs the uid to be the email to support email-based sign-ins, and the current scheme relies on uid to be utilized based on provider context as explained. If we want to change the uid / provider scheme, I think that's a separate discussion.

@mattSpell  Hi this is how I workaround with this problem
class RegistrationsController < Devise::RegistrationsController
  def new
    super do |user|
    end
  end

  def create
    if params["user"]["uid"]==nil and  params["user"]["provider"]==nil
      configure_permitted_parameters
      params["user"]["uid"] = params["user"]["email"]
      params["user"]["provider"] = Rails.application.class.to_s.split("::").first # Application name
    end
    super # continue the dflt creation process
  end

  def update
    super
  end

  protected
    def configure_permitted_parameters
      devise_parameter_sanitizer.for(:sign_up).push(:uid, :provider)
    end
end


Enable Policy Assignment user-assigned identity support

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[x] Include updated management metadata.
[x] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@m-nash anything I need to do to get this in?  The two automation failures are for a missing file for ARC (eng/mgmt/mgmtmetadata/azurearcdata_resource-manager.txt).  I didn't touch anything to do with ARC so not sure what is up with that.

Thx @archerzz for approval.  Anything else I need to do to get this merged?

@calecarter There is a mistake in https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurearcdata/resource-manager/readme.csharp.md
output-folder: $(csharp-sdks-folder)/resources/Microsoft.Azure.Management.AzureArcData/src/Generated
You're generating codes to https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/resources which belongs to Resources SDK. You need to point to the folder which belong to ArcData.

@calecarter There is a mistake in https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurearcdata/resource-manager/readme.csharp.md
output-folder: $(csharp-sdks-folder)/resources/Microsoft.Azure.Management.AzureArcData/src/Generated
You're generating codes to https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/resources which belongs to Resources SDK. You need to point to the folder which belong to ArcData.

Sorry @archerzz but I don't understand.  I am not updating anything to do with ARC and didn't touch that file.  I am updating the resources SDK, and I believe it is pointing to the proper spot.  If there is an error it would be with the last person to touch it, no?

/azp run net - mgmt - ci


Please add RetrieveSubAccounts method

Is your feature request related to a problem? Please describe.
Currently only RetrieveSubAccount and RetrieveSubAccountAsync method provided.
Please add RetrieveSubAccountsAsync that returns list of subAccount
Describe the solution you'd like
Please add RetrieveSubAccounts method that supports pagination.

Hi @hyounoo,
Thanks for pointing that out. Indeed, we do not cover all the features (yet?) for SubAccounts. The main reason is the current implementation is a contribution from a community member.
I'll check where we stand on that in the next couple of days. I'll make sure to get back to you asap.
Obviously, same stuff for https://github.com/Vonage/vonage-dotnet-sdk/issues/421.

Hi @hyounoo,
I'm following up on my previous message. The good news is, with SubAccounts going GA, I will implement these features in my current sprint.
I will be able to work on it next week, followed by a release (6.4.0).
I'll keep you posted.

Hi @hyounoo, I'm following up on my previous message. The good news is, with SubAccounts going GA, I will implement these features in my current sprint. I will be able to work on it next week, followed by a release (6.4.0). I'll keep you posted.

That's good news!
Also I've tried bunch of apis including accountapi, numbersapi, etc
Most of them has some issue with authentication.
Please check that too
Thanks in advance

Hi @hyounoo, I'm following up on my previous message. The good news is, with SubAccounts going GA, I will implement these features in my current sprint. I will be able to work on it next week, followed by a release (6.4.0). I'll keep you posted.

That's good news!
Also I've tried bunch of apis including accountapi, numbersapi, etc Most of them has some issue with authentication. Please check that too
Thanks in advance

Indeed, I noticed a problem with BasicAuth and published a fix last week (v6.3.3). Were you using that version?

Indeed, I noticed a problem with BasicAuth and published a fix last week (v6.3.3). Were you using that version?

Yeah, I was hoping the last release would solve the issue, but it didn't :(

Okay, I'm going to look that up today

Okay, I'm going to look that up today

Let me know if you need specific apis that I've tried and had auth issue

@hyounoo I just tried to create/retrieve a subaccount using v6.3.3, and it's working as expected.

Same goes for NumbersAPI.

Can you confirm?
We've had a case before where an older package version was used from the cache (not saying it's specifically that - just giving a lead).

That could be the case
Thank for informing
I will try clear the cache and retry

@Tr00d
Just confirmed CreateSubAccountAsync and RetrieveSubAccountAsync apis works but with extra apikey param
var response = await _vonageClient.AccountClient.CreateSubAccountAsync(createSubAccountRequest, vonageApiKey);
var response = await _vonageClient.AccountClient.RetrieveSubAccountAsync(subAccountKey, vonageApiKey);

without extra apikey param it would return 404 (Not Found)
Since vonageClient with factoryMethod would inject apiKey and secret, this can be ommited?

Yup, the extra ApiKey param is actually mandatory 🤦
I do not know why it was set up as an optional parameter. In fact, it could have been optional if the ApiKey was taken from the credentials.
https://github.com/Vonage/vonage-dotnet-sdk/blob/da9075af12da2f6953e3fb46bcb7f65cc7eb7616/Vonage/Accounts/AccountClient.cs#L44C1-L50

Yup, the extra ApiKey param is actually mandatory 🤦 I do not know why it was set up as an optional parameter. In fact, it could have been optional if the ApiKey was taken from the credentials.
https://github.com/Vonage/vonage-dotnet-sdk/blob/da9075af12da2f6953e3fb46bcb7f65cc7eb7616/Vonage/Accounts/AccountClient.cs#L44C1-L50

Yep the line 48 should take the creds.apiKey if apiKey = null
public SubAccount CreateSubAccount(CreateSubAccountRequest request, string apiKey = null,
     Credentials creds = null) =>
     new ApiRequest(creds ?? this.Credentials).DoRequestWithJsonContent<SubAccount>(
         HttpMethod.Post,
         ApiRequest.GetBaseUri(ApiRequest.UriType.Api, $"/accounts/{apiKey ?? creds.ApiKey}/subaccounts"),
         request,
         AuthType.Basic
     );

but this again broke when both creds and apiKey are null
If apiKey param is there to distinguish subAccount from mainAccount, I think it is better to check creds presence because main account's apiKey and secret will used for authenticate anyway.
If the method requires authentication, it should assume creds is not null and validate if not provided when called.

It's kinda urgent but I can wait if the sdk can be properly implemented and sort out the mess if there's any.
Thanks for your support.
Appreciated.

Alright, let me see what I can do.

@Tr00d
Just let let you know
The critical method
var response = await _vonageClient.NumbersClient.BuyANumberAsync(numberTransactionRequest);

return response;

returning 401 and preventing further implementation.
If its ok, this method would be the first one I want to see working.
Thank you

I ran a similar piece on my end, which works.
Did you provide an ApiKey/Secret couple in the credentials? Was it from a SubAccount? If so, I don't know if it works and try from the main account.

There was apiKey property in the request model and I provided main account apiKey
I will try without apiKey in the request body
Thanks for confirming

@Tr00d Just tried and it works without subAccount apikey
Thanks for letting me know
Hope subAccount gets buyNumber availability soon too

Well, at least you got it working for now. I'm about to release a new version today with a fix for the SubAccount features (here).
As far as I know, buying a number directly from a SubAccount is impossible. But you can buy one from the main account and then transfer it to a SubAccount. More details here

Well, at least you got it working for now. I'm about to release a new version today with a fix for the SubAccount features (here). As far as I know, buying a number directly from a SubAccount is impossible. But you can buy one from the main account and then transfer it to a SubAccount. More details here

Oh thanks, that's a good news

FYI - v6.4.0 is now available. It fixes the optional ApiKey issue, as we discussed previously.
I'll get back to you regarding the whole SubAccount implementation in the upcoming week.

@Tr00d 👍
Thanks for the quick release!

Hi @hyounoo,
v6.5.0 has been released today. It contains the implementation of all SubAccounts features mentioned in our API Reference.
Please note that they're available on another client: SubAccountsClient instead of AccountsClient. If you'd like to see an example of how to use the client, feel free to take a look at our code snippets.

@Tr00d nice!!!
Can’t wait see it

@Tr00d this Match lamda method is confusing
How should I return the success object of Account here?
var message = response.Match(
            success => $"SubAccount created - {success.ApiKey}",
            failure => $"SubAccount creation failed: {failure.GetFailureMessage()}");

So, the response object is a Result<T>. It's a Monad that can be either a Success or a Failure. When using .Match() to extract (and/or transform) the value, you must provide one operation for each state (or scenario).
What do you want to do if the SubAccount creation fails?
You can find explanations here. There's also a section explaining how to work with them if you don't want to use Monads. TL;DR: a GetSuccessUnsafe method will throw an exception if the Monad is in a Failure state.


feat(navbar): icon based navbar dropdown

Added a navbar dropdown component that uses an icon instead of text.
Fixes #1948

there seems to be a bug never seen on macos runner :/


Not finding modules in other files in .net core

dotnet 1.0.1
ionide 2.25.7
Windows 10
Repository that I'm getting the bug on

I made this repository by running the following:
dotnet new sln
mkdir project1
dotnet new classlib -lang f# -o .\project1\
dotnet sln add .\project1\project1.fsproj

I add a file which references the one already added and add the entry into the fsproj as shown here. I then dotnet restore and dotnet build. It builds fine.
The second file I added however can't find the reference to the first:

It's known bug in underlying tooling we use that's happening due to space in your windows username. The workaround is suggested here https://github.com/ionide/ionide-vscode-fsharp/issues/398#issuecomment-290362515. Hopefully @enricosada will fix it soon.

Thank you. Is there an issue in F# SDK to track this?

@Kurren123 https://github.com/fsharp/FsAutoComplete/issues/152

@enricosada looks like that issue has been fixed now, however this bug is still there

I see now, the changes have been pushed to this repo and will be there on the next release. Thanks!


Not completing discovery

I have multiple projects with hundreds of .stl files. All of the files are scanned and added to the library; however the process that creates the PNG files for each one just stops at some point and will never restart, even if I start a new discovery scan or reboot the container. And to accomplish this, I had to add .stl files to the library folder a little at a time. If they were all in there at first start of the Agent container, discovery would get to some point and just stop. Files aren't added to the library and PNG files are not created.

Hello,
Could you please provide the logs of the agent container during the discovery phase?
Doing that on a fresh installation, meaning an empty data folder ( not library ).
Thank you

So startup with empty data folder and all the stl files in the library folder. Which log and where is it located?

From the logs, you have a single project with a tone of files, right?
The project does show up in the UI right?
Are models missing from the UI?
Are some models present but without the thumbnail?
Can you post a screenshot?
In what hardware are you running the container? CPU RAM and architecture (arm or amd64)?
Sorry for all the questions but I need to understand the problem, from the logs, it discovers the content, looks like the assets are created, they are sent to the processing queue, but there are no errors....

There are 2 projects, one with 511 files and one with 656. Only one project shows in the UI and it does not contain all the models and most of the thumbnails are missing. I am running this on a QNAP NAS with quad core CPU and 32GB RAM. I also tested on my personal PC which has an Intel 13900K and 64GB RAM. Same behavior.

When browsing the SQL Lite database, there are only 314 records in the project_assets table and 1 record in the projects table. This matches what is shown in the UI, but does not match what is in the library folder.

Any ideas?

Hi, I've looked a bit at it, I seems there is a deadlock behaviour during the discovery process.
Given the most recent changes I think it's related to the fronted notifications....
I haven't had a chance to try,  but some combination of starting mmp and going to the Web UI, refreshing to make sure the event channel is connected, avoiding the channel full error messages.
I need to confirm my theory and make a fix...

Thanks. I would be happy to test it when you are ready

I've found the issue.
Currently, the render queue is limited to 256 pending requests and the processing queue limited to 100 requests...
If your library is BIG they fill up and enter a deadlock state...
As a quick and dirty fix, I'm gonna increase the size to 9999999, it should be enough...
I'm currently reprocessing a 17gb library, and it's working...
I'll post back when the bug fix is published


Add travis testing support for python 3.8

Working through adding python3.8 testing support and fixing any broken tests.
Closes #471
Could use advice on tidying up the test matrix in the travis.yml file

Merging this, as it achieves the goal of adding the tests for 3.8. Going to address the Cython failures in a different PR.


Publish ePUB

Hi,
Solid content. I'd like to see an official ePUB generated, for easier reading on offline e-imk devices.

I tried to set this up, and it basically worked. But I hit a problem affecting the HTML version of the book, as described in this commit message where I disabled the ePub generation: https://github.com/nnethercote/perf-book/commit/5d37cf2d83e1583f193007c3dd0fd9314943a0ca
If you know of a workaround that would let me generate the ePub version while also keeping the HTML version URL unchanged, I'd love to hear it.

A couple of other notable things, which make the ePub version inferior to the HTML vrsion.

I viewed the produced epub file in Books on Mac. The output quality is ok, but not great. In particular, some quite excessive amounts of whitespace.
The book has a lot of links, which are hard to view on an e-ink device.

Based on the difficulties mentioned above, I will close this. I'd be happy to reconsider if solutions can be found.

The mdbook behavior is unfortunate.
As a workaround, you could generate the ePUB locally.
Yes, some ePUB generators are awful about extraneous whitespace. I actually wrote a little CLI script to help clean up some common ePUB quirks like that:
https://github.com/mcandre/nile
Yes, links are often hard to view in ebooks and printed books. One solution is to always write URL's in tutorials out in plain long form, without using a shorter name descriptor. Then, every view of the URL is sure to show the full URL. URL simplification be done manually, or automated with some Markdown parser or some awk script.
An ePUB, with or without pretty URL's, is still more useful than no ePUB.

As a workaround, you could generate the ePUB locally.

And commit it to the repository every time the text changes? I'm not willing to do that.
I view the HTML version as by far the most important, and I am willing to have an ePub version only if it doesn't negatively affect the HTML version. The whitespace and URL issues are unfortunate but not showstoppers. Changing the URL for the HTML book is a showstopper, alas.

The URL shouldn't need to be changed.  I'm not familiar with the github actions you are using, but I suspect it just needs to change to something like adding this just before deploy:
      - name: Add ePub
        run: cp book/epub/The\ Rust\ Performance\ Book.epub book/html

and changing the deploy directory to:
          publish_dir: ./book/html


DeploymentNotFound when referencing an output from a conditional deployment module

Bicep version
run bicep --version via the Bicep CLI, az bicep version via the AZ CLI or via VS code by navigating to the extensions tab and searching for Bicep
Describe the bug
A clear and concise description of what the bug is vs what you expected to happen
When deploying a sub-module conditionally with true and also using an output the arm template is happy. when the condition is false it throws a weird error DeploymentNotFound. I would like bicep to give me an error when I output to also make it conditional.
not sure if related to:
https://github.com/Azure/bicep/issues/3750
To Reproduce
Steps to reproduce the behavior:
Additional context
Add any other context about the problem here.

It does some like you are running into the issue that #3750 would have caught. It seems your output is dependent on a module being executed, so when it is not, the deployment fails. You probably need to use the ternary operator to conditionally set the value. In order to know for sure, please include a concise repro of the issue.


Insomnia can't resolve ipv6-only domains

Is there an existing issue for this?

[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Insomnia Version
2021.6.0
What operating system are you using?
Windows
Operating System Version
Windows 10  Pro version 21H1
Installation method
Download from insomnia.net
Last Known Working Insomnia version
No response
Expected Behavior
Request works correclty
Actual Behavior
Insomnia displays "Error: Couldn't resolve host name"
Reproduction Steps

Create new request
Specify: GET ipv6.google.com
Click "Send"
See error

Additional Information
If you are specifying the actual ipv6 as a host and specifying domain to the Host request header, then it works fine.
Example:
GET https://[2a00:1450:4010:c0d::66]:443
Host: ipv6.google.com
That means the problem appears only when domain only has the AAAA record.

Couldn't reproduce this issue on a slightly different Win10 version, Windows 10 Pro 20H2, using Insomnia 2021.6
Insomnia export:
Insomnia_2021-11-03.zip
.0

Insomnia 2021.6.0, Windows 10 Home, reproduces the issue, I've got "Error: Couldn't resolve host name" after requesting ipv6.google.com

Couldn't reproduce this issue on a slightly different Win10 version, Windows 10 Pro 20H2, using Insomnia 2021.6
Update: Also can't reproduce on Windows 10 Pro 21H1, using Insomnia 2021.6
Insomnia export: Insomnia_2021-11-03.zip

I've tried your export file and reproduced it on Ubuntu 20.04.3 LTS (even from another location).

Couldn't reproduce this issue on a slightly different Win10 version, Windows 10 Pro 20H2, using Insomnia 2021.6
Update: Also can't reproduce on Windows 10 Pro 21H1, using Insomnia 2021.6
Insomnia export: Insomnia_2021-11-03.zip

Sorry, it seems that there wasn't any problems: I found that my Windows 10 wasn't configured for IPv6 support. And at the same time my previous example (requesting ipv6 address and passing host header) worked only because of my work VPN I was connected to (which supports ipv6).

@matrozov no worries 👍
Is this also the case for @papajojo ?

Yep, all fine now, thanks!


events-list not clearing on pjax-loaded page

Context
The initial render of the events-list is fine (eventsThisMonth, eventsLastMonth, etc). When navigating away from the page that clndr is loaded and coming back with the back button or menu (using ajax), the list duplicates in all timeframes. I've tried clearing the list on page load through the DOM, but it seems this list is built before render. Also tried setting the eventsThisMonth, etc to null in the defaults
Expected Behavior
events-list should be destroyed before each render
Actual Behavior
events-list appending to container
Possible Fix

Steps to Reproduce

go to napdnb.net/events
click on event link
use back-button, click on 'events' menu item

Your Environment

Version used: CLNDR v1.4.7
Browser Name and version: Chrome/FF (IE hates pjax)
Operating System and version (desktop or mobile): desktop and mobile
Link to your project: napdnb.net

Thanks for the report @enthuzy. However, I think you'll have to either provide something like a JS Fiddle or possibly take it to Stack Overflow. I'm unsure what the bug you're describing is, but at first glance it appears to be application-related.

resolved it. Thanks! (definitely not a bug)


Add TLS in dispatch client

Addition of TLS in dispatch client.
Issue link: https://github.com/apache/pinot/issues/11777

feature

Codecov Report
Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (a4c3286) 61.58% compared to head (d0c13b8) 27.73%.

Files
Patch %
Lines

...e/pinot/query/service/dispatch/DispatchClient.java
0.00%
25 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12269       +/-   ##
=============================================
- Coverage     61.58%   27.73%   -33.85%
+ Complexity      207      201        -6
=============================================
  Files          2416     2416
  Lines        131211   131228       +17
  Branches      20252    20256        +4
=============================================
- Hits          80800    36390    -44410
- Misses        44507    92090    +47583
+ Partials       5904     2748     -3156

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
27.73% <0.00%> (-33.73%)
:arrow_down:

skip-bytebuffers-false
27.73% <0.00%> (-33.84%)
:arrow_down:

skip-bytebuffers-true
?

temurin
27.73% <0.00%> (-33.85%)
:arrow_down:

unittests
27.73% <0.00%> (-33.85%)
:arrow_down:

unittests1
?

unittests2
27.73% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@anandheritage Can you take a look at the conflict?
@zhtaoxiang Can you help take a look?

Updated pull request is here : https://github.com/apache/pinot/pull/13645


Let user set the starting memory address.

When opening a .bin file (in c64 mode) the program reads two first bytes and uses them as load address. That might be ok with a .prg file, but if it's just binary data dumped from arbitrary address, let the user choose where to load it. (one more thing you could just do like ida)

Would it make sense to have two system entries for C64, one with the "use the first two bytes as address" option, one without?  If so, what should the options be called to differentiate them?  Maybe "C64 (.PRG)" and "C64 (plain binary)"?  What should the default address for "plain binary" be?
I'm doing something like this for the Apple IIgs, which has "P8" and "GS/OS" flavors.  I have zero experience with the C64, so I'm not sure what the common practices are for that system.
FWIW, all of this is just a convenience.  You can alter the load address (double-click on the .ORG) and add or remove symbol files after the project is started.  If you use "generic 6502" you won't have any of the extra stuff set.  But it's nice to have common options get set up automatically.
I haven't used Ida, so I don't know how they do things.
My eventual goal is to add "file format recognizers" that can look at the filename and file contents to get a sense for what type of file it is, and react appropriately.  For the time being the options are wired into the system definition list.

FWIW, you can fiddle with the definitions by editing the RuntimeData/SystemDefs.json file.  Delete the lines with "first-word-is-addr".

Default address could be zero, but there should definitely be a dialog in there to select the address if loading just binary data without any special format.
Also there could be a loader for vice memory dump, which includes the whole c64 memory.

I wanted to avoid pestering the user with dialogs when opening the project.  I figure there's three situations:

The value from the system definition is correct.  For some systems (e.g. Atari 2600) there's a high likelihood of just getting it right.  If the binary starts with a load address this is easy, though the problem is then one of identifying that the binary starts with a load address.
The user doesn't actually know, and won't know until they've dug at it a bit.  So asking up front doesn't help.
The default is wrong and the user knows the right answer, and will want to change it immediately.

For situation (3) it's not significantly harder to double-click the .ORG at the top of the project and set it to something else.  My inclination is to avoid putting up a dialog that is often unnecessary or unwanted, and instead just open the project file and let the user go to work.  I think the right answer depends on what percentage of the time we're in situation (3)... if it's more than half, then a dialog (or perhaps a text field on the "new project" screen) could be helpful.
A default address of zero is pretty much always wrong, because that would mean the code runs on zero page and perhaps into the stack.  I'm using a default of $1000, which is probably wrong almost as often, but doesn't treat direct-page variables as if they were part of the executable code.
I was a little worried about making "first-word-is-addr" the default because it actually does three things:

Sets the initial .ORG to the start address.
Adds a .ORG at offset 2, also to the start address.
Formats the starts address as a 16-bit value.

So if the file doesn't start with a 16-bit load address, you have to undo the unwanted bits.  So the question isn't simply "should we ask for a load address", but also "under what circumstances should we do those three things".  Which is why I'm contemplating a separate system definition for files that begin with a load address.  I'm just not sure what C64 people call them.

v1.1.0-dev1 has the separate PRG/BIN system def entries.  Hopefully that'll do for now.


fix: updated precheck.nonce() to handle higher nonce cases

Description:
This PR updates precheck.nonce() to reject requests that have nonces higher than current nonce of the signer
Related issue(s):
Fixes #3271
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

We shouldn’t reject too high because we don’t know how transactions are being asynchronously submitted by users and therefore a transaction with a high nonce at a particular relays precheck could still be correct at the time of network processing.

Yes copy that! Thanks for confirming! Closing this PR as misunderstanding the design.


Add CONTRIBUTING + README #patch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.262%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
99

Relevant Lines:
214

💛  - Coveralls


fixed typo bug in osmosisdnode/Dockerfile

This bug prevents the localnet-start target of Makefile from creating necessary files needed for launch of a local testnet in the proper directory. The reason is that the build directory is mounted on /osmosisd, but the output directory is set to . (current directory) which in the docker file is specified as WORKDIR /omsosisd; therefore by the time testnet command finishes and docker exits the output files will be lost.

Lol, tysm for catching & fixing this

Codecov Report

Merging #482 (412800e) into main (3025a89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   20.15%   20.15%
=======================================
  Files         163      163
  Lines       23349    23349
=======================================
  Hits         4707     4707
  Misses      17884    17884
  Partials      758      758

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3025a89...412800e. Read the comment docs.

My pleasure.


clearer flow when rescanning connectors

probably fixes hyprwm/Hyprland#8508 but author is unresponsive
either way this pr addresses

drm connectors can be hotplugged by usb-c hubs
recheckCRTCs -> scanConnectors -> new connector can be discovered and connected without crtc on second pass

wrong patch oops, should be right now

Tested it, fixes the issue https://github.com/hyprwm/Hyprland/issues/8508. Thank you!


Speedup SequenceMask on GPU

Description
As title. Address #14124.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Customized kernel for GPU

Comments
benchmark results on sample workload from #14124:
forward only: 48.589637756347656 ms -> 0.5544562339782715 ms   87.63x speedup
forward+backward: 97.38378977775574 ms -> 1.224109172821045 ms   79.55x speedup
import mxnet as mx

ctx = mx.gpu(0)

dshape = (8, 512, 768)
seq_length = [18., 35., 34., 100., 110., 194., 512., 10.]
dtype = 'float16'

import random

from mxnet.test_utils import check_speed, rand_ndarray

mx_data = rand_ndarray(dshape).as_in_context(ctx).astype(dtype)
mx_seq_len = mx.nd.array(seq_length).as_in_context(ctx).astype(dtype)

data = mx.sym.Variable("data")
seq_len = mx.sym.Variable("sequence_length")
mx_sym = mx.sym.SequenceMask(data=data, sequence_length=seq_len, use_sequence_length=True, value=0.0, axis=1)

print(check_speed(mx_sym, typ='forward', location={"data": mx_data, "sequence_length": mx_seq_len}, ctx=ctx, N=1000) * 1000)
print(check_speed(mx_sym, typ='whole', location={"data": mx_data, "sequence_length": mx_seq_len}, ctx=ctx, N=1000) * 1000)

@eric-haibin-lin @szha for review.

@mxnet-label-bot add [CUDA, Operator, Performance, pr-awaiting-review]

@eric-haibin-lin @szha ping for review.

@eric-haibin-lin please check