Just only show the Loading... open with the IDEA

Hello preboot,
Thank you for your job, It's helpful for me. But I have one question.
When I follow the steps, I just want to build the dist folder. So, I follow these steps.
npm install  -> ok
npm build -> ok

And then the dist is builded, so I import the project to my IDEA workspace， and I open the index.html using IDEA in the dist folder, but the chrome shows errors,  only the info  " Loading... ".

But, when I use the npm start , and using localhost:8080 , it works.
So If I want to directly open the index.html with the IDEA, how should I do, to avoid these errors?
Thank you!

I'm having the same problems. After running build... the dist folder is created looks like everything is properly injected to index.html but everything is 404. Locally and on live server environments. This is after cloning repo with no modifications.

You need to run the index.html inside of the dist/ folder after running npm build with a HTTP web server. Importing it to an IDEA workspace (or double clicking to open with Chrome) won't work and will result in "Loading..." forever because the server doesn't know where to find the routes /js, /css, etc.
If you are looking to test the built site locally, I would suggest installing and using something like node's http-server. It defaults to port 8080 but you can run http-server -p 8081 to run it on another port easily since this project runs on 8080 by default. Once you run the command, the app should work in your browser.
For production, Apache or nginx works great as a web server, since we're just serving html, css, and js.


Apple Silicon - incorrect reading of brew installed packages

Description
On an Apple Silicon machine with brew installed (using the Homebrew recommended location of /opt/homebrew) - neofetch reports 1 package installed (I have ~ 90).

[X] Does this issue still occur in the master branch? (Required if issue)

Neofetch version
7.1.0 (git current)
Screenshot

Config file
Using the default shipped (no changes).
Verbose log

Run neofetch -vv 2> neofetchlog
Upload the contents of neofetchlog to pastebin, gist or equivalent.

https://pastebin.com/C5JR1bXM
PS: I see that "brew --cellar" gets called.  This is the output from the Apple Silicon machine:
% brew --cellar
/opt/homebrew/Cellar

Fixed in master I believe.


default z-index(es) why are they so high?

See: https://github.com/picturepan2/spectre/blob/master/src/variables.less#L68
These seem to be really high for @z-index-1 and above where things like simplemde assume single digit z-index(s)
See also sparksuite/simplemde-markdown-editor#610

@prologic I choose these z-index values because they are more flexible to add another z-index between any two of those. Sometimes we need to settle new layers with existing ones.
I close this issue and you can reopen it anytime you have a new z-index issue.

Thanks!
James Mills / prologic
E<EMAIL_ADDRESS>W: prologic.shortcircuit.net.au
On Tue, Aug 29, 2017 at 5:22 PM, Yan Zhu<EMAIL_ADDRESS>wrote:

Closed #237 https://github.com/picturepan2/spectre/issues/237.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/picturepan2/spectre/issues/237#event-1226706547, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABOv-mty6W4BnJjAJ_3KjRxjvJxb_Aawks5sdKtXgaJpZM4OY7Ec
.


Compatibility with Global Filter

Would be great if this filter can support:
https://novapackages.com/packages/nemrutco/nova-global-filter
so it will work with
https://novapackages.com/packages/nova-bi/nova-databoards

I need it too !


golden plunger

About the PR

Added a cool new golden version of the plunger for janitor as a loadout reward for 10 hours playtime in janitor.
Why / Balance

Loadout items are cool, I like rewards for playtime also. For balance changes, this one glows slightly (less than a PDA light) and you can throw it and it will stick to people, meaning you can 'embed' a light on them to see them in the dark, I don't know of another item that does this.
It also can be recycled for gold, but I wouldn't be worried about this since when testing I got like 1 gold bar after recycling about 15 of them and they're only currently obtainable through the loadouts system.

Media

https://github.com/space-wizards/space-station-14/assets/68826635/84a197ed-3014-47f1-9a8f-469f096115df

Changelog

add: Added a golden plunger for experienced janitors! Thank you for your hard work keeping the station clean.

we need more than 10 hours
it should feel like a reward, not to be in every janitor's backpack

we need more than 10 hours it should feel like a reward, not to be in every janitor's backpack

There's some back and forth on a previous PR I was working on - https://github.com/space-wizards/space-station-14/pull/27559 about this. I want things to feel rewarding but not be completely restrictively time gated and there are some maintainers who don't want the high time gates on things even that should feel rewarding.
I agree in principle but don't know where the proper balance point it.

God tier PR

oh changelog was broken rip credit


OpenCE 1.7: TF CVEs that could be patched

In OpenCE 1.7.7, we didn't backport fixes for the following vulnerabilities:

CVE-2023-25664 : https://github.com/tensorflow/tensorflow/blob/master/tensorflow/security/advisory/tfsa-2023-010.md
CVE-2023-25668: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/security/advisory/tfsa-2023-002.md
CVE-2023-25661: https://nvd.nist.gov/vuln/detail/CVE-2023-25661 , pointing to https://github.com/tensorflow/tensorflow/commit/948fe6369a5711d4b4568ea9bbf6015c6dfb77e2
CVE-2023-25658: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/security/advisory/tfsa-2023-020.md

The patch for CVE-2023-25658 involves changes in 81 files. We will not fix that one. But the other three vulnerabilities affect 2 files each. Can you please check whether we can include those in OpenCE 1.7.8 ?

Sure @alexlang74 !

ddaac2bdd099bec5d7923dea45276a7558217e5b
7b174a0f2e40ff3f3aa957aecddfd5aaae35eccb -- this is already included
948fe6369a5711d4b4568ea9bbf6015c6dfb77e2
ff459137c2716a2a60f7d441b855fcb466d778cb --- This will not be included.

Cool! So 25668 is already fixed?  That's then missing in our "list of fixed CVEs"...

Cool! So 25668 is already fixed? That's then missing in our "list of fixed CVEs"...

No, we didn't add this fix last time. It was already added by TF community in their r2.9 branch and it is already part of TF 2.9.3. https://github.com/tensorflow/tensorflow/commit/eb92930a0ee264f2f04b7c7069cc4515d79ca6f3. So, ideally twistlock scan should not show this CVE in our 1.7.6 builds too.

It still shows up in the scans. https://nvd.nist.gov/vuln/detail/CVE-2023-25668 says that it got cherry-picked into 2.11.1, but is still exists in 2.9.x...

I'm looking at https://github.com/tensorflow/tensorflow/commit/7b174a0f2e40ff3f3aa957aecddfd5aaae35eccb , and also only see 2.12 and 2.13 branches...

Strange! Exactly same changes from https://github.com/tensorflow/tensorflow/commit/7b174a0f2e40ff3f3aa957aecddfd5aaae35eccb are added in https://github.com/tensorflow/tensorflow/commit/eb92930a0ee264f2f04b7c7069cc4515d79ca6f3 too

Interesting...

Yes, it already had that change.

3 CVE fixes delivered in 1.7.8


Fs 505 fund validation

If eligible than you are redirected to current xgov form runner with our baseline questions.
Otherwise you are taken to a not eligible page.


Legend: rendering text labels resets custom typefaces

https://github.com/ScottPlot/ScottPlot/discussions/3825#discussioncomment-9433290

Hi @lasooch, thanks again for suggesting this feature. It has been added in #4043 and will be available in the next release
SKTypeface customTypeface = SKTypeface.FromFile(ttfFilePath);

plot.Legend.ManualItems.Add(new LegendItem()
{
    LabelText = "Manual Item",
    LabelFontColor = Colors.Blue,
    LabelFontSize = 26,
    LabelTypeface = customTypeface,
});

Thank you very much @swharden.


Added Swapchain functions

[x] Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
[x] Updated documentation to reflect any user-facing changes - in this repository
[ ] Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

Ill do the vulkano-www documentation when this is getting approved/should get changed.

@AustinJ235 What do think of the changes so far? :)

looks alright if you want to pull in the latest master so it has a better chance to build.


Improve performance of .some- bundle methods

[ ] check.someMethod()
[ ] check.someInput()

See also #30.


Use case to use a mirror of CVE contents when the plugin maintains its own ?

My understanding is that the plugin downloads and maintains its own CVE content. And there's an example of manually configuring a mirror of the CVE content explicitly: https://jeremylong.github.io/DependencyCheck/dependency-check-maven/index.html (Example 5):
<project>
    ...
    <build>
        ...
        <plugins>
            ...
            <plugin>
                <groupId>org.owasp</groupId>
                <artifactId>dependency-check-maven</artifactId>
                <version>6.2.2</version>
                <configuration>
                    <cveUrlModified>http://internal-mirror.mycorp.com/nvdcve-1.1-modified.json.gz</cveUrlModified>
                    <cveUrlBase>http://internal-mirror.mycorp.com/nvdcve-1.1-%d.json.gz</cveUrlBase>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>check</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
            ...
        </plugins>
        ...
    </build>
    ...
</project>

My question is why it is (in some case) needed ? Is this to improve performance as it has a local cache ? If so isn't required to be downloaded every run ?

because corporate policies exist to make a developers life harder... eg. "a build server can not connect to the internet"

https://jeremylong.github.io/DependencyCheck/data/index.html

https://jeremylong.github.io/DependencyCheck/data/index.html

thanks.


Release v1.0

Title: Release tracker
Body:
TL;DR: This branch includes planned version updates for our initial game launch.
Planned 🚢 date: April 1, 2020
Features:

[score tracking]

Stretch Features:

[score sharing]

Bug fixes:

[TBD]

Merging Release v1.0 to master with Release Drafter installed!


Have autotune sync to NS nightly after autotune runs

This will keep Nightscout in sync with autotune after the nightly run.

Inspired by @jpcunningh 's additions to the doc with the manual instructions (https://openaps.readthedocs.io/en/latest/docs/While You Wait For Gear/nightscout-setup.html#how-to-automatically-sync-your-profile-from-autotune).
I can't think of any reason why uploading nightly would not be desired behavior, but please chime in if you can think of a use case where that's non-optimal.

I think this should be possible to PR now as the Autotune update issue has been closed and rolled into dev?

I plan to test these changes on my system as soon as I get my install issues resolved.

Have been running this for awhile, and it's working properly.  Ready to merge if no objections.

I’ve been seeing an oddity with this. The uploaded script hasn’t been uploading the autotuned CR, only the pump CR. It also seems to split the last half hour of carb ratio out. Anyone else seen this? (Note that upload currently disabled, hence date in image)

Our uploaded CR record isn’t showing a pump value or multiple CR schedules, but it’s also not updating and is now out of date.

Woudln't it also make sense for the oref0-upload-profile to issue a Profile Switch even to nightscout?

@viq No. If you automatically make a profile switch then you don’t give people the option of not profile switching, which some may wish to have. Profile switch events should either be an option in set-up of profile upload or a separate trigger event.

AFAIK autotune on OpenAPS "just happens", without you getting to review
results first? This would be the same behaviour. And I'm all for adding a
flag to do it, just I think it would make sense for it to be part of same
process. --
viq

Given the way that people are using AndroidAPS is noticeably different from OpenAPS, I’d disagree.
As people have now started to use the automated profile switching capabilities off triggers, automating a profile switch in NightScout when this is going on starts to run into conflict with what people are doing to override a profile. This isn’t something that exists in a OpenAPS world so has never been an issue.
That’s why I’d prefer it to be something that is a deliberate choice for someone wanting to use Autotune. Enough people don’t understand the OpenAPS aspects of AndroidAPS so it would be good to force them to explicitly understand the implications of this.

Sure, let's not make it the default behaviour. But how about a flag "and
also switch to the profile that you just uploaded"?
--
viq

I don’t think that’s unreasonable. Would be worth updating the docs at the same time with a warning that this would override any automated profile switching using glucose triggers.

Updated rounding, and confirmed that a manual run is uploading updated data. Also updated the nightly cron to wait 60s between finishing autotune and uploading profile, to allow cron-every-minute to run ns-loop and update the profile.json. Will let it run on one rig and check it after tonight's autotune run to confirm it gets the new values.

This successfully uploaded our newly autotuned profile this morning at 04:08:50, so I think it's good to merge.

Это успешно загрузило наш недавно настроенный профиль сегодня утром в 04:08:50, так что я думаю, что это хорошо для слияния.

@scottleibrand does not work, if configured authorization with token

If you or anyone would like to volunteer to add tokenauth support, I'd be happy to review a PR. We don't use it, though, so I can't really develop or test that easily.
I also wouldn't want to hold up the 0.7.0 release for missing tokenauth support, unless it causes failures of something other than the new profile upload feature. Have you seen any such side effects?

I understand. No problem with that, this is not essential


Update hierarchy

-merge 'therapeutic treatment' with therapeutic intervention
-Move all of nutrition-related terms to 'nutritional intervention'

Done but forgot to close.


[Feature]: add interval on ai backend request

Checklist

[X] I've searched for similar issues and couldn't find anything matching
[X] I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?
No
Problem Description
No response
Solution Description
add ai backend request interval.
if set, Sends requests to the AI backend server at set intervals, independent of the reconciler loop.
this interval should be equal or higher than reconciliation's requeue interval.
Benefits
More control over ai backend requests.
Potential Drawbacks
No response
Additional Information
No response

@JuHyung-Son I think we should move this to the operator's repo, right ?

oh right i will move this


Pipes and generics

Hi.
I have pipe for connecting data from redux store:
import 'package:angular/angular.dart';
import 'package:redux/redux.dart';

typedef Selector<K> = dynamic Function(K state);

@Pipe('stateRef', pure: false)
class ConnectPipe<K> extends PipeTransform {
  final Store<K> _store;
  final ChangeDetectorRef _detector;
  final NgZone _zone;

  ConnectPipe(this._store, this._detector, this._zone) {
    _store.onChange.listen((K _) => marker());
  }

  Selector<K> _selector;
  dynamic _innerState;

  dynamic transform(Selector<K> selector) {
    _selector = selector;
    return _innerState = selector(_store.state);
  }

  void marker() {
    final dynamic some = _selector(_store.state);
    if (some != _innerState) {
      _zone.run(_detector.markForCheck);
    }
  }
}

When I try use it with template
<simple
  [a]="numConverter | stateRef">
</simple>

UsersConverter - selector
int numConverter(SimpleState state) => 42;

When compile it I've got error:
[error] The argument type '(SimpleState) → int' can't be assigned to the parameter type '(dynamic) → dynamic'.

As I can see angular template cannot infer K as generic - SimpleState and treat this as dynamic.
And I have type mismatch. How to workaround it or how to add generic types to pipes as I can for directiveTypes.

@leonsenft @matanlurey @alorenzen ?

Sorry for the late reply. There's no support in the framework for instantiating pipes with generics yet.
I can think of two potential workarounds.

Specify type arguments using inheritance. This might be the best option if you're going to need few types.

// No pipe annotation.
abstract class ConnectPipe<K> extends PipeTransform {
  ... // unchanged.
}

@Pipe('intStateRef', pure: false)
class IntConnectPipe extends ConnectPipe<int> {
  IntConnectPipe(...) : super(...);
}

Only pass functions with dynamic parameters to your pipe. If you want, you can add an assert or type check inside the function to retain some type safety.

int numConverter(dynamic state) {
  if (state is SimpleState) {
    ...
  }
}


Logger warns about missing NiKom:Log directory

After doing a clean installation of NiKom, there will be lines like this in the shell where you started NikomCon or PreNode:
LOG ERROR! Can't open log file NiKom:Log/Usage.log
The Log directory is not mentioned in doc/Installation.doc or created by InitNiKom. Maybe the logger could create it by itself, like it does with the Usage.log file itself?

That was actually a deliberate decision not to automatically create the directory. Partly to avoid having to check for the directory every time something is logged.
Also, even though the log destination is not configurable right now I had in mind that it may be that later on. Then you could configure the log directory to be e.g. "Foo:" which can not be created.
It should be mentioned in the documentation though.


Provide default descriptions for non-200 status codes

For 200 responses, SpringFox adds "description" : "OK". Could do the same for other, common response code (e.g. 201, 204 etc)?

using @ApiResponses { {@ApiResponse ... }) annotations doesn't bring up descriptions?

I'm sure it does, but would be nice if a default description was generated for 201, 204 etc when no @ApiResponses annotation is present, as it does for 200.

How are u currently describing that your Api produces 203, 204 etc.?

With annotations like @ResponseStatus(HttpStatus.CREATED).

That should work. If not I'll tag it as a bug

Looks like a bug then. The status codes show up in the Swagger spec, but some without a default description.


Update community.html

Description
This PR fixes #1397
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@nakulbh Do not create any PR unless you are assigned to that issue. Please read the contributing guidelines
OR else your PR will not be accepted

Now, will this issue be assigned to someone else? If yes, then I want to work on this issue.

@nakulbh We want to point to the Tutorials section on https://meshery.io/talks-and-presentations page and not the page itself
i.e. https://meshery.io/talks-and-presentations#Tutorials

Done sir

@nakulbh It's important to request assignment before starting work on an issue if there is no assignee.
Please go through the contributing guidelines and code of conduct outlined in the community handbook. Also refer to https://layer5.io/community/handbook/faq to know how to approach working on issues within the community, I hope you'll keep these in mind for future.

Yes sir i will keep this in mind in future


⚠ File access has degraded performance

In 62a922e, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 4321 ms

Resolved: File access performance has improved in 38a9260 after 8 minutes.


Uncaught TypeError: Cannot read property 'updateCursorBlinkSync' of undefined

[Enter steps to reproduce:]

Using Mulesoft API-bench
...

Atom: 1.19.0 x64
Electron: 1.6.9
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'updateCursorBlinkSync' of undefined
At C:\Users\noela\AppData\Local\atom\app-1.19.0\resources\app\src\text-editor-component.js:241

TypeError: Cannot read property 'updateCursorBlinkSync' of undefined
    at TextEditorComponent.updateSync (~/AppData/Local/atom/app-1.19.0/resources/app/src/text-editor-component.js:241:38)
    at etch.getScheduler.updateDocument (~/AppData/Local/atom/app-1.19.0/resources/app/src/text-editor-component.js:220:46)
    at ViewRegistry.module.exports.ViewRegistry.performDocumentUpdate (~/AppData/Local/atom/app-1.19.0/resources/app/src/view-registry.js:187:15)
    at ~/AppData/Local/atom/app-1.19.0/resources/app/src/view-registry.js:3:65

Commands

Non-Core Packages
api-workbench 0.8.46
busy-signal 1.4.3
intentions 1.1.5
linter 2.2.0
linter-ui-default 1.6.3

Thanks for the report - is the error reproducible for you?   If so, I'd suggest reporting this to the api-workbench maintainers since it sounds like the error happens for you specifically when using that package.  It may be that there is still a bug in Atom however and if so, we'll need the api-workbench maintainers to help track that down. You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.


Handle agreement replacement

As of v0.2.0, if an owner makes a mistake when adding a new agreement and quickly replaces it with another new agreement, all wearers who signed the existing agreement will be made ineligible even still within the original grace period.
To resolve this, if a wearer has not signed the latest agreement, we can instead check whether we are still within the grace period of the agreement they have signed, regardless of how many new agreements there have been since the one they signed.
This would involve the following changes:

introducing an Agreement struct enabling tracking of all historical agreements.

struct Agreement {
  string agreement;
  uint256 graceEndsAt;
}

mapping(uint256 id => Agreement agreement) public agreements;

// replaced
// string public currentAgreement;
// uint256 public graceEndsAt;

Setting a new agreement would increment the currentAgreementId but not overwrite the previous agreement or change a global graceEndsAt.

❓ An open question is whether the new grace period should start immediately or not until after the end of the existing grace period.

Wearers would now be eligible if either of the following were true:

a) They have signed the most recent agreement
b) The grace period for the agreement they most recently signed has not ended

Timing
Given the open question above, together with the non-trivial change to the contract interface and indexable data involved in this change, I recommend conducting additional user research before implementing it.

Closed by #8


Leaving out VS Build Tools

Hey, thanks for a very useful tool! Just a quick heads-up.
I'm using it to detect MSVC 2019 Build Tools and your default get_latest*() functions won't detect it (by MS's design, see here)
It works fine by calling find_first(latest=True, products=['*']) though.

In 286cab0cefa07409986aa4306c26f38933df3729 (version 1.3.0) I made it so you can pass arguments like products to the get_latest*() functions. Let me know if that's any easier to use.


ASA and Speech tutorials corrections

Docs Build status updates of commit f28173a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/module2chapter1step13im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-asa-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-asa-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch5.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Iphones - Borders are Flickering while loading and scrolling

Hi,
After implemented in my design i could see the problem that borders are flickering while loading and scrolling in the below URLs  (specifically in iphone6 and above ).What could be the cause for this ?
URL: http://onextondtcdev.evoq-stg-i.com/all-about-acne
http://onextondtcdev.evoq-stg-i.com/how-it-works

This repository is going into very-low-maintenance mode and declaring backlog bankruptcy


Add functionality to ensure generated route arguments also overrides the equality and hashCode Operations.

ISSUE: View route argument objects are not equal, which causes failure when trying to unit test and compare objects, the test will fail.
Current Behaviour: VerifyAccountArguments() == VerifyAccountArguments() = false.
Expected Behaviour: VerifyAccountArguments() == VerifyAccountArguments() = true;
How to tackle issue: Ensure the stacked generator overrides the hashcode and equality operator of each view route argument.

@devRaphe are you going to tackle this?
Please add a bit more details in the description that goes over the following:

What is the output that you expect
What is it now

Yes I am going to tackle it. @FilledStacks.
I will add a description now.

ISSUE: View route argument objects are not equal, which causes failure when trying to unit test and compare objects, the test will fail.
Current Behaviour: VerifyAccountArguments() == VerifyAccountArguments() = false.
Expected  Behaviour: VerifyAccountArguments() == VerifyAccountArguments()  = true;
How to tackle issue: Ensure the  stacked generator overrides the hashcode and equality operator of each view route argument.

@devRaphe we'll get to this soon. The course creation is taking all of our time.

PR has been merged


SB UI KIT PRO Lead-Capture Clone

Description
I want to create the clone of SB UI KIT PRO lead capture page. This page will use bootstrap,  css and a color customizer designed by Javascript.
Kindly assign it to me.
Here is the page link.
https://sb-ui-kit-pro-angular.startbootstrap.com/landings/lead-capture
Code of Conduct

[X] I follow Contributing Guidelines of this project.

Assigned to u @khushimarothi

Thanks!!


Fixing threading-related hang during initialization in urgent mode

This is a modification of https://github.com/firebase/firebase-ios-sdk/pull/10958
Paired on with @wowlocal
Rotating the Installation ID when uploading in Urgent Mode is not necessary, so this modifies the previous PR to skip rotating the Installation ID when we have the conditions for deadlock.
One problem with this seems to be the isMainThread check. Dispatch Queues in the background are not guaranteed to run in a background thread, so I believe the isMainThread check is true even when run on a background dispatch_queue. This seems to over-count cases where this could deadlock.

I resolved the problem that led to the SPM test failure. https://github.com/firebase/firebase-ios-sdk/pull/10958#issuecomment-1532106435

@wowlocal this should be a good way to solve the problem.
Thank you very much for your contribution! I was able to use that unit test to reproduce the issue. After removing the fix the test fails, and now it passes.
Going to merge this once my teammate approves.

Great fix! I'm glad the test was helpful 😃


Error when parsing the json-rpc id when using upstream rust-web3

When bumping our rust-web3 version for #1089, using vanilla upstream at this commit all our json-rpc calls would fail with a deserialization error. On further investigation, it was specifically failing to parse the json-rpc id, which can be numerical or string but was numerical on this case.
I could not reproduce this inside an unit test in rust-web3, even with the exact same input to the exact same function that errors when called from graph-node. Even with all dependencies of serde-json locked to the same versions. This workaround was applied so that things work again. @Jannis and @olibearo observed the same in the past when debugging jsonrpc-core-client issues. We don't have any ideas at the moment for the root cause.

@leoyvens Should we revisit this?

This is fixed in the upstream web3, as long as features = ["arbitrary_precision"] is set in the web3 dependency. We now have other patches in our fork so we can't just switch to upstream anyways.


Chapter rename2

Rename Chapter
devon4net -> .net

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: dolvie1012:x: dolviedolvie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please remember that the documentation is for the Capgemini's devon4net framework, is not for Microsoft's .net framework


systemd startup race

varnish-agent doesn't depend on Varnish, so it can start out of order and error out:
Apr 07 10:04:54 hlzuds3mqs0i.yres.ytech systemd[1]: Started Varnish Agent.
Apr 07 10:04:54 hlzuds3mqs0i.yres.ytech varnish-agent[1876]: Dropping privileges to user varnish
Apr 07 10:04:54 hlzuds3mqs0i.yres.ytech varnish-agent[1876]: ERROR: Cannot get varnish version: No CLI connection available, is varnish running?
Apr 07 10:04:55 hlzuds3mqs0i.yres.ytech varnish-agent[1876]: ERROR: Apr 7 10:04:55 No CLI connection available, is varnish running?

A possible fix from the customer:
[Unit]
Description=Varnish Agent
#After=network-online.target
#Requisite=network-online.target
After=varnish.service
Requisite=varnish.service

https://varnish.zendesk.com/agent/tickets/17459

this should be in https://github.com/varnish/pkg-varnish-plus
It should be fixed with a -t 0 if the agent supports it, of ExecStartPre=varnishadm -t 0 ping if it doesn't

https://github.com/varnish/pkg-varnish-plus/issues/206


[Examples] Add MXNet example

Add MXNet example.

Coverage decreased (-8.7%) to 50.259% when pulling f9cb89f4dde30e06b912a666d9ee39b81e9bd656 on xiongyf/mxnet-example into 6c9a17da105f4663616cd97072ae6bf8ff04e721 on master.


Interactive container hangs when executing from a Java Application

Hi!
I'm trying to execute an interactive container from a Java Application (I'm building an online free Java compiler). But for some reason the termination signal is not received and the Java application thinks that the program continues running (Docker version 1.5.0, build a8a31ef)
The attached code hangs on the process.waitFor(). But if I remove the -i flag the program runs ok
Maybe this issue is related to this other fixed before -> https://github.com/docker/docker/issues/6509
I need the program to run with the -i flag due that I want to execute interactive Java programs inside the docker container. Also I tried with the -t flag but Java does not provide a TTY so it fails to execute.
One thing that I cannot figure out is why the docker command works from the command line but no from the java application, maybe the difference is that I have a TTY when I execute the command from the command line

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;

public class Test {

	public static void main(String[] args) throws Exception {
		Process process = Runtime.getRuntime().exec("sudo docker run -i ubuntu ls");
		int returnCode = process.waitFor();
		System.out.println("returnCode: " + returnCode);
		System.out.println("output: " + output(process.getInputStream()));
	}

	private static String output(InputStream inputStream) throws IOException {
		StringBuilder sb = new StringBuilder();
		BufferedReader br = null;
		try {
			br = new BufferedReader(new InputStreamReader(inputStream));
			String line = null;
			while ((line = br.readLine()) != null) {
				sb.append(line + System.getProperty("line.separator"));
			}
		} finally {
			br.close();
		}
		return sb.toString();
	}
}

Seems like it might be related to #11957 :(

I'm not sure that this is a bug.
When -i is set, the client does a hijack. The hijack will block until we receive an EOF (or any error) from stdin.
https://github.com/docker/docker/blob/master/api/client/hijack.go#L228
When stdin is a TTY the client will not block waiting for stdin: https://github.com/docker/docker/blob/master/api/client/hijack.go#L250-L255
@vdemeester WDYT? I think we can close this.

Actually, I take that back, this is a bug. Let me see how difficult it is to fix.


failed to install because artefact change

Describe the bug
The installation of Conduit failed because the linked artifact changed and the sha256 no longer match.
Instead of use artifact from next, i could be better to use artifact from release ?
In gitlab, by following link, I have found the url of artifact from release of v0.8.0 :
https://gitlab.com/famedly/conduit/-/jobs/7085149318/artifacts/browse
and direct link for x86_64 and arm64 :
https://gitlab.com/famedly/conduit/-/jobs/7085149318/artifacts/raw/aarch64-unknown-linux-musl?inline=false
https://gitlab.com/famedly/conduit/-/jobs/7197089162/artifacts/raw/x86_64-unknown-linux-musl?inline=false
I think it's more appropriate to link to tagged/release version than next.
What do you think ?

You are right, fixed with #41. But it will break the same but less often

fixed


Unable_to_contact_remote_controller

Dear Andres Murillo
Another issue related to the remote controller. When i run the environment as it is ( also tried modifying), but unfortunately unable to connect, I noticed that paper and fran are using ip and port numbers <IP_ADDRESS>:5543 respectively and for the pox in utils.py file, while the ip and port numbers are <IP_ADDRESS>:6633 in the run.py file.
For the "make paper" not only that is not unable to contact the remote controller, but also it pops an error with permission denied.
Kindly find the screenshots attached for both fran and paper terminal.

This is because that topology is supposed to run on an Ubuntu machine but still using a virtual machine for MiniCPS. In this sense, the remoter sits outside of the MiniCPS topology, at an host-only interface (<IP_ADDRESS>).
I'm guessing this is not the setup that you have. You could try changing the controller IP parameter in francisco-topoutils.py to localhost and the port in "run.py". You would also need to modify "controller.sh" to include such port, using the parameter "--port=6633" in the line:
~/pox/pox.py log.level --WARNING dynamic_controller

Dear Andres Murillo
Thank you for clarification. After several attempt and investigation, successfully able to make the fran folder works.
But for the paper folder, it shows an error says  "invalid user mininet:mininet" thisI believe is related to database connection, or since a virtual machine is involved in your experiments, this could also be a the reason.

Hellow Ahamd, sorry for my late response. I had a hectic month. Are you still having the issue?

Hi Andres, keep pushing on on your life.
For the experiment, yes, the issue still exist in my case though stopped attempting to find a solution for the moment.
I come to a conclusion that since you are using a separated Mininet virtual machine this causes my simulation to behave in this way.

@ahmad7bashir Hello, excuse me.  I have met some problems and would like to refer to the code you successfully executed to “make fran”, please? Thank you .


Update/Add [tool name]

Tool name
mono
Tool license
<IP_ADDRESS>
Add or update?

[X] Add
[ ] Update

Desired version
latest
Approximate size
No response
Brief description of tool
No response
URL for tool's homepage
No response
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[X] Azure DevOps
[ ] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[X] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hello @parijatn, we check out the best way to add mono to macOS 13.

@parijatn, we are already working on adding mono in this https://github.com/actions/runner-images/issues/7635 issue. The current one will be closed as a duplicate.


easy-taxonomy error when using GTDB

Thanks for maintaining this great software! I'm having an issue with easy-taxonomy using GTDB (but not NCBI with the same query input), described below. Using a conda install of version 15.6f452.
Thanks for any help!
Expected Behavior
Completing without error
Current Behavior
Fails at aggregatetaxweights with the following:
Missing key 0 in tax result                                       ] 0.00% 1 eta -
Error: aggregatetaxweights died
Error: Search died

Full log here: easy-tax-full-log-error.txt
Steps to Reproduce (for bugs)
Install
mamba create -y -n mmseqs2 -c conda-forge -c bioconda -c defaults mmseqs2==15.6f452
conda activate mmseqs2

DB setup
mmseqs databases GTDB mmseqs2-GTDB-db tmp

Making small test data
wget -O e-coli.fasta.gz https://ftp.ncbi.nlm.nih.gov/genomes/all/GCA/000/005/845/GCA_000005845.2_ASM584v2/GCA_000005845.2_ASM584v2_genomic.fna.gz

gunzip e-coli.fasta.gz

grep -c ">" e-coli.fasta
# there is only one contig, so safe to just pull some lines

printf ">contig_1\n" > contigs.fasta
sed -n '100,1200p' e-coli.fasta >> contigs.fasta
printf ">contig_2\n" >> contigs.fasta
sed -n '20000,20600p' e-coli.fasta >> contigs.fasta
printf ">contig_3\n" >> contigs.fasta
sed -n '26000,26200p' e-coli.fasta >> contigs.fasta
    # that's 3 contigs: 88,000 bps; 48,000 bps; and 16,000 bps

Running the program
mmseqs easy-taxonomy contigs.fasta mmseqs2-GTDB-db GTDB-tax-result tax-tmp \
       --threads 20 --tax-lineage 1 --compressed 1 --remove-tmp-files 0

MMseqs Output (for bugs)
Fails at aggregatetaxweights with the following:
Missing key 0 in tax result                                       ] 0.00% 1 eta -
Error: aggregatetaxweights died
Error: Search died

Full log here: easy-tax-full-log-error.txt
Context
Trying to get taxonomy output via GTDB with lineage info added. Using the NCBI database completes successfully on the same input query.
Your Environment
Include as many relevant details about the environment you experienced the bug in.

mmseqs2 version 15.6f452 installed with conda
working on Ubuntu 20.04.4 LTS
500 GB memory

I am having a very similar error:
Current behaviour
After submitting a mmseqs taxonomy run, this sub command is being executed (and dies):
aggregatetaxweights mmseqs_database/database tmp1/14824571404584235274/orfs_h_swapped tmp1/14824571404584235274/orfs_tax tmp1/14824571404584235274/orfs_tax_aln SWH_IN_taxonomy/SWH_IN --lca-ranks kingdom,phylum,class,order,family,genus,species --tax-lineage 1 --compressed 1 --threads 12 -v 3

MMseqs output
  Missing key 0 in tax result
  tmp1/14824571404584235274/taxpercontig.sh: line 85: 206297 Aborted                 (core dumped) "$MMSEQS" aggregatetaxweights "${TAX_SEQ_DB}" "${TMP_PATH}/orfs_h_swapped" "${TMP_PATH}/orfs_tax" "${TMP_PATH}/orfs_tax_aln" "${RESULTS}" ${AGGREGATETAX_PAR}
  Error: aggregatetaxweights died

Environment

singularity container of mmseqs2 version 15.6f452 (build pl5321h6a68c12_0)
HPC (Linux + slurm)
950 GB RAM

Comment
I know that for mmseqs taxonomy classification with GTDB at least 900 GB RAM are needed, so I am not surprised that your process died @AstrobioMike. And since I seem to have a very similar error (if not the same) maybe even my 950 GB RAM are not enough, I wonder...


Rename core-aborter to aborter

This PR renames the code-aborter package as per the proposal in #3524,

Re-opening PR with name for the package changed to abort-controller


Add a queue / limiter for parallel running commands

Right now, there is no limit or queue for running commands. Meaning it could overwhelm the system if too many are executed together.
Introduce either a queue or a semaphore on the running numbers. Or both if it makes sense.

In case of a new we hook request, simply cancel the previous run.. Or have a limit on how many runs can there be for a single repo running at the same time.


Suppress reboot by default on msiexec based installers

[x] Have you signed the Contributor License Agreement?
[x] Are you working against an Issue?

Issue:

#229

Problem:

Every WinGet installation using msiexec may restart the computer suddenly if any of the affected files are in use.

Solution:

Add '/norestart' flag by default.

Microsoft Reviewers: Open in CodeFlow

/azp run


Search-Function does not work properly

Searching related data does not work properly in n-m-relations

try to set the search_string_transformation setting to 'lower(%s::text)'

did not work

Please try with the most recent version if problem still active. If it is still active, there might be some issue with server side php configuration. It appears to work fine on other machines.

I'd like to raise this up as it doesn't work for me either (no records found in any type of search, including FK). I'm using cyryllic symbols by the way, that may be a catch. On which functions\configuration options of PHP server this project relies? Maybe I can find what's wrong with it.

The searching by typing in the dropdown boxes in the editing forms relies on the search and transliterated out of the box in select2 (currently we rely on 4.0.6-rc.1). I know it performs well at searching characters with/without diacritics), maybe with cyrillic this requires some fiddling with the select2 options.


How to print request objects?

Summary
Unable to print request objects to the console for debugging purposes, e.g. with console.log(JSON.stringify(req)).
Expected Behavior
The request object is emitted to stdout.
Current Behavior
Error about request object presenting infinite loop.
Fairly sure this is happening with Express.js, but could be coming from the NPM request library as well.
Your Environment

software
version

request
2.88.0

node
v10.15.3

npm
6.9.0

Operating System
macOS 10.12 Sierra

Hi @mcandre
I'm not sure, but maybe you can try this to print the request objects.
console.log(req)


Add saml docs

Here we've added separate Plugins section to the docs structure.
Is it make sense to hold all plugins related docs under such section before publishing it to the prod?
@alena-babrova what do you think?

Yes, I agree with you @AmsterGet.
I think Plugins section should include all plugins documentation.
We already have plugins documentation in another place.


Add a nominal request to the kube-apiserver init container

This pod needs a nominal request so that the workload partitioning
kubelet mutation can act upon it.
Signed-off-by: Jim Ramsay<EMAIL_ADDRESS>

/cc @browsell

/test e2e-aws-operator

/retest

/retest

/retest


AWS NLB's health check fails if nodeports are updated

Bug Description
As the issue title explains, if I update the ingress gateway's node
port, then it results in my network load balancer health check failure.
Steps to reproduce:

Install istio using the istio operator
Apply this manifest and wait till the ingress is up

Click to Expand manifest

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
 name: istiocontrolplane
 namespace: istio-system
spec:
 components:
   egressGateways:
   - enabled: true
     k8s:
       hpaSpec:
         maxReplicas: 5
         minReplicas: 2
     name: istio-egressgateway
   ingressGateways:
   - enabled: true
     k8s:
       hpaSpec:
         maxReplicas: 5
         minReplicas: 2
       serviceAnnotations:
         service.beta.kubernetes.io/aws-load-balancer-backend-protocol: tcp
         service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "600"
         service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
         service.beta.kubernetes.io/aws-load-balancer-type: nlb
     name: istio-ingressgateway
   pilot:
     enabled: true
 hub: gcr.io/istio-release
 meshConfig:
   defaultConfig:
     tracing:
       zipkin: null
   enablePrometheusMerge: true
 profile: default
 values:
   global:
     proxy:
       resources:
         limits:
           cpu: 100m
           memory: 100Mi
         requests:
           cpu: 100m
           memory: 100Mi

Wait till the network load balancer and the pods are up. Now update
the above manifest like this to change the node port:

Click to expand manifest
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: istiocontrolplane
  namespace: istio-system
spec:
  components:
    egressGateways:
    - enabled: true
      k8s:
        hpaSpec:
          maxReplicas: 5
          minReplicas: 2
      name: istio-egressgateway
    ingressGateways:
    - enabled: true
      k8s:
        hpaSpec:
          maxReplicas: 5
          minReplicas: 2
        service:
          ports:
          - name: status-port
            nodePort: 30644
            port: 15021
          - name: http2
            nodePort: 32085
            port: 80
          - name: https
            nodePort: 32082
            port: 443
        serviceAnnotations:
          service.beta.kubernetes.io/aws-load-balancer-backend-protocol: tcp
          service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout: "600"
          service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
          service.beta.kubernetes.io/aws-load-balancer-type: nlb
      name: istio-ingressgateway
    pilot:
      enabled: true
  hub: gcr.io/istio-release
  meshConfig:
    defaultConfig:
      tracing:
        zipkin: null
    enablePrometheusMerge: true
  profile: default
  values:
    global:
      proxy:
        resources:
          limits:
            cpu: 100m
            memory: 100Mi
          requests:
            cpu: 100m
            memory: 100Mi

Now go and observe the health of your NLB load balancer  and it will fail for both the https and http port. Snapshot:

Surprisingly for the status-port, the health checks are fine.
Note that if I change the node port of my Nginx controllers (backed by NLB) - they do work fine.
There is also a similar looking issue opened previously but which has been closed stating that it should be fixed in 1.8+ : https://github.com/istio/istio/issues/28856
Version
❯ istioctl version
client version: 1.10.3
control plane version: 1.10.3
data plane version: 1.10.3 (7 proxies)
❯ kubectl version --short
Client Version: v1.19.0
Server Version: v1.19.13-eks-8df270

I don't see how this can be triggered by Istio specifically? I am not an AWS expert though so maybe it would need to be converted into Istio concepts rather than just "NLB health checks" (ie curl reproducer, etc).
But in general Ingress gw doesn't care or know about node ports. It just accepts traffic sent to it.

@howardjohn Note that if I don't specify any specific node port (or remove the explicit node port which causes this issue), the new ingress pods come alive and the NLB turns into an healthy state.
Note that after the NLB goes into an unhealthy state, the ingress doesn't receive any traffic. Also what's suprising is that the node port for status port works as compared to the http2 and https port.
Looking at #28856, I believe this is a similar issue since even that seems to be reproducible when node ports are different. And looking at the recent comment on the issue (https://github.com/istio/istio/issues/28856#issuecomment-913738461), it seems something similar is happening during upgrades too.

#28856 was about the operator unintentionally changing the port. It seems like you are doing it intentionally though?

@howardjohn Yeah, it was an intentional change for some of the use cases we have.

Hi @psibi, I've just tried to export another port on an existing NLB installed via istio operator. After updating the IstioOperator, I see that an AWS target group is created for me with no targets.
To get it working, I did the following:

Manually added targets to the target group
Added target group as listener on NLB
Updated the security group to allow traffic for the newly specified node port (Before doing this, the NLB health checks would fail.)

If you feel this issue or pull request deserves attention, please reopen the issue.

This issue is still present and I don't have enough access to reopen the issue.

hi Same problem here with istio 1.13, adding new ports makes the newly added port to remain in health-check failed state (all original ports are in green)

If you feel this issue or pull request deserves attention, please reopen the issue.

This issue is still present and I don't have enough access to reopen the issue.

If you feel this issue or pull request deserves attention, please reopen the issue.

This issue is still present and I don't have enough access to reopen the issue.


Consider null inputRows and parse errors as unparseable during realtime ingestion.

Consider null inputRows as unparseable during realtime ingestion. Also, harmonize exception handling between the RealtimeIndexTask and the RealtimeManager.
Related to #1350

a simple test to verify the behaviour would be nice.

Agree that a test would be nice, I could do one at some point before the PR is merged. i.e., Soon™
For now though does the general approach seem reasonable? Especially in the context of #1350?

LGTM.

:+1:

Is this covered in a test somewhere?

Added a test.

+1, once travis is green :)

closing/reopening to rebuild, build failure seems unrelated

@gianm I think @cheddar had some comments in #1350 that were related, did those get addressed in here?

@xvrl yes

@xvrl I'm actually not totally sure what @cheddar had in mind

@gianm ok, maybe you and @cheddar can chat, and figure out if #1350 is still relevant or not?


python310Packages.sentry-sdk: 1.11.0 -> 1.11.1, python310Packages.twilio: 7.15.3 -> 7.15.4

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 204600 run on x86_64-linux 1

4 packages failed to build:

gns3-gui
gns3-server
python310Packages.dalle-mini
python39Packages.dalle-mini

26 packages built:

alerta-server
cura
home-assistant-component-tests.sentry
home-assistant-component-tests.twilio
moodle-dl
mozphab
netbox
octoprint
python310Packages.django-rq
python310Packages.sentry-sdk
python310Packages.spacy
python310Packages.spacy-loggers
python310Packages.spacy-transformers
python310Packages.textacy
python310Packages.twilio
python310Packages.wandb
python39Packages.django-rq
python39Packages.sentry-sdk
python39Packages.spacy
python39Packages.spacy-loggers
python39Packages.spacy-transformers
python39Packages.textacy
python39Packages.twilio
python39Packages.wandb
skytemple
tribler


Easy configuration to use in FileSystem.newFileSystem()

AS A user
I WANT to be able to provide configuration setting when creating a new file system. E.g.:

FileSystems.newFileSystem(myuri, Map.of(
    AWS_ACCESS_KEY_PROPERTY, "access-key",
    AWS_SECRET_ACCESS_KEY_PROPERTY, "secret-key",
    S3_SPI_ENDPOINT_PROTOCOL_PROPERTY, "http"
));

SO THAT I can easily provide configuration settings to the file system provider
NOTES

Use S3NioSpiConfigurationBuilder. E.g. :

FileSystems.newFileSystem(myuri, new S3NioSpiConfigurationBuilder()
    .withAccessKey("access-key")
    .withSecretKey("secret-key")
    .withEndpointProtocol("http")
);

for configuration parameter s3.spi.endpoint  no env var/sys prop overriding because not a good pattern with FileSystems where multiple instances of a file system can be created and are supposed to have their own env, while envvars and sysprops are global to the JVM.

Is it OK to close this? I think the mentioned PR includes this.


Add Releases command to github repository search

Description
Add view Releases command to GitHub Repository search extension.
Type of change

Bug fix / improvement for somebody else's extension. Extension author:  @thomaspaulmann

Screencast
https://user-images.githubusercontent.com/4230968/140635776-b5df323c-c319-4213-9fb1-f73bc62dc982.mp4
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I checked that extension's icon has size of 512x512

The CI build failed because the existing icon not match the 512x512 size. (which might be created before the CI setup) Not sure if we want to update the icon in this PR.

Hi @Yukaii 👋
It would be nice if you could update the icon size accordingly, if you're unsure how, please let me know and I'll help you do it 😄

Let's also add an icon to the show release details action

Awesome @Yukaii  - It makes ALOT more sense to swap it, now the search makes a lot more sense 💯
One last thing that I think should be added is a shortcut for "Browse Releases" now that you have added shortcuts to everything else, when its added, then we're ready to merge 💣

@pernielsentikaer Thanks for the review, I've added shortcut Cmd + r to the command. Although it's conflict with the "Reload" command, since that command is development-only, I think it's okay to use the shortcut.

Awesome addition @Yukaii! - Let's mark it as ready to get merged 💎


deposit: removing first date element no longer possible

Go to the deposit page.
Scroll down to Dates field
click the "X" button - no action is visible in the interface, no error raised, no feedback to the user

Expected:
The button should be either disabled (if minimum one date is required - to be verified) or it should remove the first array element after clicking

Cannot reproduce, in the video bellow there is what I tried. Did I understand it correctly?
https://user-images.githubusercontent.com/6756943/213721473-73b746d9-6333-4dcd-94dc-312a39ffe19d.mov

This error is introduced in:

invenio-app-rdm==11.0.0.dev6

The issue comes from the overridable date.

The button should be either disabled (if minimum one date is required - to be verified) or it should remove the first array element after clicking

Is "back to how it was before - not showing an item unless the user clicks add" an option?
I can see we have both cases:

not shown: titles, funding, creators, contributors
shown: alternative identifiers, related works
while I do understand funding, creators, contributors to not be shown by default because it is a modal. Then should we also make titles shown by default? or actually "hide" the identifiers/works and dates too? (this would also minimize the deposit form lenght. And having the "+ Add" button makes it quite clear to me.

The draft PR is hiding the dates field by default.

I think we should make it work the same way as it was before introducing the regression.
I agree there is a lack of consistency between the fields you've listed, however I am hesitating to try to remove the inconsistency, because maybe it was on purpose?
I remember the first element of dates array being shown by default (and empty) but it was possible to remove by clicking "x". I think we want to revert to that.

The showEmptyValue is enforcing that an empty value is always present. See code here where it is always enforcing it.
When I first implemented it ,I had in mind that it has to be required, however I understand now that we should be able to remove the empty value.
Maybe it's worth to differentiate between showEmptyValue that will just prefill the field with an empty object and another attribute (maybe called required) that will not allow to delete the value, to be used when the field is mandataroy.
I think that  setting the value to false, it will just remove the empty value, the fix probably has to be done in https://github.com/inveniosoftware/react-invenio-forms/blob/d66bbf037ad100fdbf6e71d21c622d36a7b6396a/src/lib/forms/ArrayField.js

@jrcastro2 Thanks! That matches the behavior I've seen. I've bootstrapped again app-rdm 11.0.0.dev5 and the date field is not present. So the PR, fixes the regression (hide the field by default). Then the question is @kpsherva: Should we implement the difference between showEmptyValue and required that Javier mentioned?


python3.9 dev image

Hello.
 This turned out to be incredibly useful for me with the library I am developing, as I was able to automate testing of the library on Python3.8 before it was officially released in my CI pipeline.
Mostly wondering if/when you plan to do the same for Python3.9, if at all.
Thanks :-)

Of course! I see there is a release for 3.9.0a1, so I made a PR :smile:

Nice one! Cheers for the speedy response!


XMLHttpRequest cannot load error on accessing MEAN.js API through IONIC app

I am developing an ionic application, trying to access API of MEAN.JS application which is as below which is a link to encoded JSON
https://damp-dawn-2579.herokuapp.com/api/foods
The factory service of my application accesses the above link but gets an error
XMLHttpRequest cannot load http://localhost:3000/api/foods. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8100' is therefore not allowed access.
Factory Service
.factory('Foods', ['$resource',
function($resource) {
return $resource('https://damp-dawn-2579.herokuapp.com/api/foods/:foodId', { foodId: '@_id'
}, {
update: {
method: 'PUT'
}
});
}
])
How do i overcome this? Thank you

You need to enable cors.
https://www.npmjs.com/package/cors


Update 1.4.0 release notes with ID -> Id in inspect

Also, update README with latest release

Added another commit to mention the new podman mailing list in the Contributing file, alongside the IRC channel.

@TomSweeneyRedHat PTAL

LGTM

/lgtm


Add new npm guide

Add a new npm guide and refactor a bit the docker-compose and helm one
A preview environment is available to  see what the guide section looks like

Thanks @lemeurherve for your feedback.
I received positive feedback for this so I am gonna merge it


Level control minLevel/maxLevel handling broken with multiple endpoints

Problem
The Level Control cluster reads minLevel/maxLevel on every endpoint init, but stores them in the same static variables.  This breaks as soon as there are two endpoints with different min/max levels.
Proposed Solution
Store the state per-endpoint instead.
@jmartinez-silabs

Fixed with https://github.com/project-chip/connectedhomeip/pull/13820


Support TruffleRuby

Wouldn't it be more convenient for TruffleRuby to include RSpec into their build?

One reason for this is that we're really capped by the GHA tier, and with the number of Ruby versions we support getting a single build to run takes several minutes.
For rspec-rails, it's even worse - it can be up to half an hour. If other builds in rspec organization are running, they are queuing up.
To ba fair, we're seizing support for older Ruby versions in RSpec 4, but there are still a plenty of versions to support, with Ruby 3.1 and ruby-head missing from that list.
We were thinking of removing JRuby builds and relying on JRuby to test Ruby compatibility on their side, but don't want to do this abruptly.
If there's an incompatibility with TruffleRuby or JRuby, it's a burden for us to fix, and we hope for the cooperation of their core teams to help with the fixes.
Do you think it would be possible to add a job that runs RSpec tests along TruffleRuby builds instead of adding a TruffleRuby job that runs along with RSpec builds?

Thank you for merging this.
I opened an issue to figure what would be needed to officially support TruffleRuby in RSpec: https://github.com/rspec/rspec-metagem/issues/68


samples: Bluetooth: df: Add DF peripheral sample

Add new sample application for direction finding to show
how the functionality works in connected mode for peripheral role.
Signed-off-by: Piotr Pryga<EMAIL_ADDRESS>

The PR has dependency on #41905. It should be merged after the #41905.

Fixed build issues.

@jhedberg @cfriedt @nashif The PR is ready for merge


Replace lists with tuples to improve type-inferrence

I recently submitted a PR to mypy, which improves handling of generic types. This PR, if accepted, would lead to a type-error being reported in your code which was previously not reported.
I described it in detail here in the mypy PR: https://github.com/python/mypy/pull/9994#issuecomment-772497568
Testing plan: I ran mypy, both the current version and the version with my PR against the source code

The workflow failure seems to be related to CircleCI and not caused by my code. Maybe a rerun can fix it. CircleCI won't let the PR author trigger a rerun by themselves though.

You can always rerun by rebasing, but I'm comfortable merging given the nature of the failure.

@freundTech can you explain your reasoning for why you think those objects should be tuples rather than lists?

The main reason those should be tuples is that the contained types are heterogeneous. The first entry is a value (object), the second a description (str).
Lists are homogeneous, therefor all entries are of the same type.
In addition Lists are mutable and therefor invariant. This means that for B subtype of A List[B] is not a subtype of List[A]
Tuples are immutable and therefor contravariant. This means that for B subtype A Tuple[B] is a subtype of Typle[A]
Using a tuple allows mypy to infer the types as Tuple[List[Tuple[str, str, int]], str], Tuple[int, str] and Tuple[bool, str] which are joined to Tuple[object, str]
With a List mypy currently infers List[object] for all three, which are then joined to List[object].
If my PR is accepted by mypy it would instead infer List[Sequence[Sequence[object]] for the first (which is also correct, but more specific) and List[object] for the other two. Because lists are invariant they can't be combined to List[object] (despite Sequence[Sequence[object]] being a subtype of object) and are instead combined to object
This then goes on to cause a type-error in line 2044, because you obviously can't use an index accessor on object

I agree with the reasoning here.  @freundTech Can you re-push to get a clean build?

I believe it’s not correct to replace these lists with tuples, because Python-Markdown needs them to be mutable:
https://github.com/Python-Markdown/markdown/blob/447da662b0c9548941a44a911e45c7cf6ad32861/markdown/extensions/__init__.py

Oh I see. This is a Markdown, not an Extension, so the only user of the self.config dict and the getConfig method is our own code. We should replace the dict with three normal instance variables.

I just rebased this and the CI checks pass now. @andersk's solution looks good too,

@freundTech Thanks for your work here!  I ended up merging the commit from @andersk.  Looking forward to more contributions.


grouping stampit arguments list

Add an option to create stamps in the following way:
var stamp = stampit({
  refs: {},
  methods: {},
  init: function () {}, // or an array of functions
  props: {}
});

We should deprecate the current arg format in favor of this... too much code smell.

:+1:
Absolutely. Named properties only for stamp creation in v2. No more multi-arg support.
We should keep the fluent methods, though. =)

We should keep in mind that we want to have as much compatibility with v1
as possible. Just reminding. :-)
On Mon, 25 May 2015 02:23 Eric Elliott<EMAIL_ADDRESS>wrote:

[image: :+1:]
Absolutely. Named properties only for stamp creation in v2. No more
multi-arg support.
We should keep the fluent methods, though. =)
—
Reply to this email directly or view it on GitHub
https://github.com/ericelliott/stampit/issues/73#issuecomment-105033157.

Agreed, but I think a lot of people are using the fluent methods instead of the arg list, anyway, just because it's a more direct way of building the stamp they want.

Just to clarify, we can't put this off for 2.1 because it's a breaking change. If we do a 2.0 release before this is done, this would have to be 3.0, not 2.1 -- and that's awkward because users may worry that our API is too unstable to rely on.
We need to balance evolving user needs and  API stability. I think the best way to do that is to ship this change with 2.0.

I agree. Even though I used the args list method for all of my stamps... Since upgrading to 2.0 will require a code audit anyway, I'd really like to get any syntax conversions out of the way at the same time.

I don't mind implementing the feature. It would take much time since there are many unit test to adjust.
I'll do that over the weekend. But strict review would be necessary.

It's worth the effort. :)

:+1:

Please review #84. After the merge I'm closing this issue. Cheers :)

Implemented!
Thanks everyone. That was a great journey. :) Get ready for the next episodes.


如何训练定制的spk2info.pt？

如题

train your own sft model, save spk embedding in spk2info.pt

train your own sft model, save spk embedding in spk2info.pt

直接用原厂模型是否可以提取speaker embedding?

train your own sft model, save spk embedding in spk2info.pt

how to get a single spk embedding from spk2embedding.pt when the spk has many utts?

train your own sft model, save spk embedding in spk2info.pt

how to get a single spk embedding from spk2embedding.pt when the spk has many utts?

simple mean, check tools/prepare_embedding.py for detail

train your own sft model, save spk embedding in spk2info.pt

how to get a single spk embedding from spk2embedding.pt when the spk has many utts?

simple mean, check tools/prepare_embedding.py for detail

I cannot find  tools/prepare_embedding.py. I guess the "spk2embedding.pt" should regenerated as a single vector for each spk by average embeddings of the same spk by modifying "tool/extract_embeddings.py"

train your own sft model, save spk embedding in spk2info.pt

how to get a single spk embedding from spk2embedding.pt when the spk has many utts?

simple mean, check tools/prepare_embedding.py for detail

I cannot find tools/prepare_embedding.py. I guess the "spk2embedding.pt" should regenerated as a single vector for each spk by average embeddings of the same spk by modifying "tool/extract_embeddings.py"

look examples/libritts/cosyvoice/run.sh, inference.py


activation ignores system property

iiuc https://search.maven.org/remotecontent?filepath=org/apache/mahout/mahout-core/0.8/mahout-core-0.8.pom suggests the deps should be hadoop-core if there is no system property name provided instead of hadoop-common, hadoop-mapreduce-client-common, and hadoop-mapreduce-client-core
However
java <X> -jar coursier-cli.jar resolve -t org.apache.mahout:mahout-core:0.8

gives the same result regardless whether X is
-Dname=hadoop.version, or -Dhadoop.version, or empty
Result:
└─ org.apache.mahout:mahout-core:0.8
   ├─ com.thoughtworks.xstream:xstream:1.4.4
   │  ├─ xmlpull:xmlpull:<IP_ADDRESS>
   │  └─ xpp3:xpp3_min:1.1.4c
   ├─ commons-io:commons-io:2.4
   ├─ org.apache.commons:commons-lang3:3.1
   ├─ org.apache.commons:commons-math3:3.2
   ├─ org.apache.hadoop:hadoop-common:1.1.2
   ├─ org.apache.hadoop:hadoop-mapreduce-client-common:1.1.2
   ├─ org.apache.hadoop:hadoop-mapreduce-client-core:1.1.2
   ├─ org.apache.lucene:lucene-analyzers-common:4.3.0
   │  └─ org.apache.lucene:lucene-core:4.3.0
   ├─ org.apache.lucene:lucene-core:4.3.0
   ├─ org.apache.mahout:mahout-math:0.8
   │  ├─ com.google.guava:guava:14.0.1
   │  ├─ org.apache.commons:commons-math3:3.2
   │  └─ org.slf4j:slf4j-api:1.7.5
   ├─ org.apache.mahout.commons:commons-cli:2.0-mahout
   ├─ org.apache.mrunit:mrunit:1.0.0
   │  ├─ commons-logging:commons-logging:1.1.1
   │  ├─ junit:junit:4.10
   │  │  └─ org.hamcrest:hamcrest-core:1.1
   │  └─ org.mockito:mockito-all:1.8.5
   ├─ org.codehaus.jackson:jackson-core-asl:1.9.12
   ├─ org.codehaus.jackson:jackson-mapper-asl:1.9.12
   │  └─ org.codehaus.jackson:jackson-core-asl:1.9.12
   └─ org.slf4j:slf4j-api:1.7.5

suspect: https://github.com/coursier/coursier/blob/0b864ddabf4674ebe673bb3a81e7d2c698cca49c/core/shared/src/main/scala/coursier/core/Activation.scala#L20-L33
Currently having the workaround to exclude them then specify what we exactly need. so not blocking.

It would be cool to accept properties that would be taken into account for profile activation, on the command-line. I think I didn't just used the global ones to make resolutions more reproducible… and also to be sure we don't leak anything sensitive from them.

--property should now allow to pass those on the command line (since 1.1.0-M14-3).


#4 Work in progress: Game management endpoint for the host

Coverage decreased (-0.7%) to 92.464% when pulling 6175e3d8feed460b8777e00d6c434f53844d3c15 on feature/manage-game into bb98ce1d27958cbde1bd870175b0ea02005ea467 on master.

Coverage decreased (-1.4%) to 91.714% when pulling ee3c44e36d42e557225536486ca72f8b09abc399 on feature/manage-game into bb98ce1d27958cbde1bd870175b0ea02005ea467 on master.

Coverage increased (+0.3%) to 93.429% when pulling bf1d834baeb02103369351e61657679ccbfc9daf on feature/manage-game into bb98ce1d27958cbde1bd870175b0ea02005ea467 on master.

Coverage increased (+0.3%) to 93.447% when pulling 272472f48f6a855d0f25c4ac4be46cd75de3bad0 on feature/manage-game into bb98ce1d27958cbde1bd870175b0ea02005ea467 on master.


[ci skip] adding user @fhoehle

Hi! This is the friendly automated conda-forge-webservice.
I've added user @fhoehle as instructed in #137.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #137

@roll I'm happy to help with maintaining this feedstock.

Hi @fhoehle,
Great! Thanks!
Sorry I wasn't sure what this PR mean but now I understand


pytest

lhb
Description

Checklist
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR

Changes

pytest修改

utils：device, shortest_path, to_dense_adj
datasets: blogcatalog, dblp, ml, shapenet, webkb, wikipedia_network

datasets: zinc

transforms: vgae_pre

layers/attention: centrality_encoder, edge_encoder(tensorflow), spatial_encoder

layers/conv: compgcn_conv, fusedgat_conv(need dgNN package), iehgcn_conv, mgnni_m_iter

layers/conv: compgcn_conv, fusedgat_conv(need dgNN package), iehgcn_conv, mgnni_m_iter

除了fusedgat_conv

layers/attention: centrality_encoder, edge_encoder(tensorflow), spatial_encoder
doen

transforms: vgae_pre

doen


fix rust parts

either the type should change or the operator should.
It seems the operator should change and document the setting information for future reference
https://rust-lang.github.io/rust-clippy/master/index.html#/absurd_extreme_comparisons

I would really love a proper contributing.md document styleguide and precommit.

I know that cargo clippy --fix --lib -p dolma would fix a lot of them automatically but I assumed that the original developers had a reason to have written the code in the first place so I am looking at each item one by one to avoid any unintended changes.

@rodneykinney can u take a look? thank you!!

I know i've been making more changes since the approval, but unless otherwise stated,
most if not all of the changes are definitely or mostly changes that do not affect behavior and just make the code more idiomatic!
A few that actually change behavior are removing unwrap() as much as possible,
but only when there is a clear and obvious way to address or propagate the error.
As far as I'm concerned they are as suitable for merging as any previous commits, but if there are any that is seen as problematic, let me know.

@chris-ha458 looks great! I've merged in.


add if statement on installation pyutils

because i don't need them

This does not build unfortunately. If you are using the pre-built image, these are already in the image so you don't need to worry about it.  Are you needing to use base.Dockerfile for some reason?

Closing due to lack of response.


Unsupported Device VP18C Compact M2 M/køl

Could it be possible to integrate my Nilan device?
I hope I have included all the necessary data.
Thank you in advance.

Log: 2024-09-30 20:58:53.751 DEBUG (MainThread) [custom_components.nilan.config_flow] Device Type 11 not found in supported devices list

Sure thing. I will add it this week.

Übersetze ins englische: so cool! Ich freue mich tierisch darauf. Vielen vielen Dank 😃

Übersetze ins englische: so cool! Ich freue mich tierisch darauf. Vielen vielen Dank 😃

So cool! I’m really looking forward to it. Thank you so much 😃

Hi @veista, I wanted to ask if you have already added the device?
Regards, DUC

Hi, I am terribly sorry, but I have simply no time right now. I will add this as soon as I can. Thank you for your patience and understanding.

Oh no, that’s not what I meant. I have no intention of rushing someone who develops such great things for the community in their free time. I just wanted to ask if I missed something. It takes as long as it takes. :-)

Hello @veista,
I was a bit impatient and went ahead with the implementation of my device myself. Everything seems to be working fine so far. If you like, you can use the attached file.
device_map.zip
Cheers,
DUC

That is great. If you could do a pull request, that would be perfect.

Never done it before, but there’s always a first time for everything. I’ll give it a try :-)

#151


Handle empty "Access-Control-Request-Headers" header

When "Access-Control-Request-Headers" is empty, return an empty
"Access-Control-Allow-Headers" in the response. This is the same
behaviour as when the "Access-Control-Request-Headers" header is
omitted from the request entirely.
Fixes COUCHDB-3090

+1

I've seen a few users run into this problem. Any chance of getting it merged now we past 2.0?

cc @rnewson @davisp @iilyak

+1

Thanks a lot. Will wee find this in CouchDB v1.7?

@barbalex Yes.


Remove some branches in HtmlHelper.TryParseHtmlTagOpenTag by using bitmask

Eliminate some branches in HtmlHelper.TryParseHtmlTagOpenTag (due to || comparisons) by using a bitmask approach instead.
Further the generated machine code has a test jump-combo, which allows optimizations at cpu-level (macro fusion, etc.).
Other places in that type seem not worthwile, as the count of cmps can't be lowered that the current count is.
Benchmarks
The benchmarks are done on a trimmed-down version of the code, to just test these parts of the code changed.
IsSpaceOrSpecialHtmlChar
|  Method |     Mean |   Error |  StdDev | Ratio | RatioSD | Code Size |
|-------- |---------:|--------:|--------:|------:|--------:|----------:|
| Default | 181.4 ns | 3.48 ns | 3.09 ns |  1.00 |    0.00 |      60 B |
|  Switch | 209.6 ns | 3.65 ns | 3.91 ns |  1.16 |    0.02 |      60 B |
|    Mask | 118.4 ns | 2.40 ns | 3.59 ns |  0.65 |    0.03 |      57 B |

benchmark code
using System.Diagnostics;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;

Bench bench = new();
Console.WriteLine(bench.Default());
Console.WriteLine(bench.Switch());
Console.WriteLine(bench.Mask());

#if !DEBUG
BenchmarkDotNet.Running.BenchmarkRunner.Run<Bench>();
#endif

[DisassemblyDiagnoser]
//[ShortRunJob]
public class Bench
{
    private static readonly char[] s_chars = { ' ', '\n', '"', '\'', '=', '<', '>', '`' };

    public Bench()
    {
        foreach (char c in s_chars)
        {
            Console.WriteLine($"{(int)c}");
        }

        Console.WriteLine();
    }

    [Benchmark(Baseline = true)]
    public int Default()
    {
        int count = 0;

        for (int cc = char.MinValue; cc <= char.MaxValue; ++cc)
        {
            char c = (char)cc;
            if (IsMatch0(c))
            {
                Debug.Assert(s_chars.Contains(c), $"{c} ({(int)c}) shouldn't be true");
                count++;
            }
        }

        Debug.Assert(count == s_chars.Length, $"wrong count, expected {s_chars.Length}, actual: {count}");
        return count;
    }

    //[Benchmark]
    public int Switch()
    {
        int count = 0;

        for (int cc = char.MinValue; cc <= char.MaxValue; ++cc)
        {
            char c = (char)cc;
            if (IsMatch00(c))
            {
                Debug.Assert(s_chars.Contains(c), $"{c} ({(int)c}) shouldn't be true");
                count++;
            }
        }

        Debug.Assert(count == s_chars.Length, $"wrong count, expected {s_chars.Length}, actual: {count}");
        return count;
    }

    [Benchmark]
    public int Mask()
    {
        int count = 0;

        for (int cc = char.MinValue; cc <= char.MaxValue; ++cc)
        {
            char c = (char)cc;
            if (IsMatch1(c))
            {
                Debug.Assert(s_chars.Contains(c), $"{c} ({(int)c}) shouldn't be true");
                count++;
            }
        }

        Debug.Assert(count == s_chars.Length, $"wrong count, expected {s_chars.Length}, actual: {count}");
        return count;
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    private static bool IsMatch0(char c)
    {
        return c == ' ' || c == '\n' || c == '"' || c == '\'' || c == '=' || c == '<' || c == '>' || c == '`';
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    private static bool IsMatch00(char c) => c switch
    {
        ' ' or '\n' or '"' or '\'' or '=' or '<' or '>' or '`' => true,
        _ => false,
    };

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    private static bool IsMatch1(char c)
    {
        if (c > '>')
        {
            return c == '`';
        }

        const long BitMask =
              (1L << ' ')
            | (1L << '\n')
            | (1L << '"')
            | (1L << '\'')
            | (1L << '=')
            | (1L << '<')
            | (1L << '>');

        return (BitMask & (1L << c)) != 0;
    }
}

IsCharToAppend
|  Method |     Mean |   Error |  StdDev | Ratio | RatioSD | Code Size |
|-------- |---------:|--------:|--------:|------:|--------:|----------:|
| Default | 131.0 ns | 2.22 ns | 2.07 ns |  1.00 |    0.00 |      40 B |
|    Mask | 121.6 ns | 1.65 ns | 1.37 ns |  0.93 |    0.02 |      53 B |

benchmark code
using System.Diagnostics;
using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;

Bench bench = new();
Console.WriteLine(bench.Default());
Console.WriteLine(bench.Mask());

#if !DEBUG
BenchmarkDotNet.Running.BenchmarkRunner.Run<Bench>();
#endif

[DisassemblyDiagnoser]
//[ShortRunJob]
public class Bench
{
    private static readonly char[] s_chars = { '_', ':', '.', '-' };

    public Bench()
    {
        foreach (char c in s_chars)
        {
            Console.WriteLine($"{(int)c}");
        }

        Console.WriteLine();
    }

    [Benchmark(Baseline = true)]
    public int Default()
    {
        int count = 0;

        for (int cc = char.MinValue; cc < char.MaxValue; ++cc)
        {
            char c = (char)cc;
            if (IsMatch0(c))
            {
                Debug.Assert(s_chars.Contains(c), $"{c} ({(int)c}) shouldn't be true");
                count++;
            }
        }

        Debug.Assert(count == s_chars.Length, $"wrong count, expected {s_chars.Length}, actual: {count}");
        return count;
    }

    [Benchmark]
    public int Mask()
    {
        int count = 0;

        for (int cc = char.MinValue; cc < char.MaxValue; ++cc)
        {
            char c = (char)cc;
            if (IsMatch1(c))
            {
                Debug.Assert(s_chars.Contains(c), $"{c} ({(int)c}) shouldn't be true");
                count++;
            }
        }

        Debug.Assert(count == s_chars.Length, $"wrong count, expected {s_chars.Length}, actual: {count}");
        return count;
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    private static bool IsMatch0(char c)
    {
        return c == '_' || c == ':' || c == '.' || c == '-';
    }

    [MethodImpl(MethodImplOptions.AggressiveInlining)]
    private static bool IsMatch1(char c)
    {
        if ((uint)(c - '-') > '_' - '-')
        {
            return false;
        }

        const long BitMask =
              (1L << '_')
            | (1L << ':')
            | (1L << '.')
            | (1L << '-');

        return (BitMask & (1L << c)) != 0;
    }
}

PR failing because of coverage upload, will need to investigate this, sorry for the trouble.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 14 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 93.203%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
25839

Relevant Lines:
27094

💛  - Coveralls

Nice optimizations, thanks!


scientific: replace guizmin by its (currently maintained) successor

I'm the author of guizmin/bistro. guizmin is an old name, the current name of the library is bistro.

thanks!


Get-AzureADUser OnPremisesUserPrincipalName

Get-AzureADUser does not retrieve all properties listed on the web interface.  Please update the module to retrieve all properties.
Also update Set-AzureADUser as well.
OnPremisesUserPrincipalName
OnPremisesDistinguishedName
OnPremisesSamAccountName

Hello @Get-SomeCofee, thanks for highlighting this issue. Do you mean return these properties by default.
You can select the properties you want returned by the cmdlet by running:
 Get-AzureADUSer -objectId $UserId | Select onPremisesSamAccountName,onPremisesDistinguishedName,onPremisesDomainName
Let me know if this answers your query.

Hello,
This suggested command doesn't work.  Returns blank properties.
onPremisesSamAccountName onPremisesDistinguishedName onPremisesDomainName

Those are extension properties. They are nested in the extensionproperty attribute. You can see them like:
Get-AzureADUser -ObjectId<EMAIL_ADDRESS>| Select-Object -ExpandProperty extensionproperty | Format-Table

@Mike-Crowley Thanks for the suggestion
Get-AzureADUser -ObjectId<EMAIL_ADDRESS>| Select-Object -ExpandProperty extensionproperty
this command does return the onPremisesDistinguishedName property.
It does not OnPremisesUserPrincipalName or OnPremisesSamAccountName

@mmcla tagging you here to help with this issue. Thanks.

@Get-SomeCofee
The Msonline and Azuread powershell modules use "AZURE AD" Graph, not Microsoft Graph. Azure AD Graph doesn't include those other two attributes. You can test here:
https://graphexplorer.azurewebsites.net/#
Note: Azure AD Graph is deprecated, and Microsoft Graph is the current API. But for this, you need to use the Microsoft Graph SDK module.
attributes returned for a user are listed here:
https://docs.microsoft.com/en-us/previous-versions/azure/ad/graph/api/users-operations#get-users--

so... Get-AzureADUser is abandoned?  great. thanks.

Yes. Here is an article with many of the announcements:
https://techcommunity.microsoft.com/t5/microsoft-entra-azure-ad-blog/azure-ad-change-management-simplified/ba-p/2967456
here is a relevant excerpt:

if you’re using the Azure AD PowerShell or MSOnline PowerShell modules to manage Azure AD, we encourage you to try the Microsoft Graph PowerShell SDK. The Microsoft Graph PowerShell SDK continues to be where all our current and future PowerShell investments are being made. In light of the announcement to not turn off the Azure AD Graph API on June 30th, our goal is to also provide guidance and tools for migrating existing scripts and PowerShell processes, reliant on the Azure AD Graph API and MSOnline module, to the Microsoft Graph PowerShell SDK. This is due to the planned deprecation of the two PowerShell modules (MSOL & AAD) after December 2022.

Thanks @Mike-Crowley for your help with this issue.
@Get-SomeCofee, thanks also for highlighting the issue. For some introductory info in Microsoft Graph PowerShell, see Microsoft Graph PowerShell overview.
I will proceed to close this issue.


[question] Do Collision events groups and category affect engine events?

I wanted to know how exactly engine event act. In docs there is a function:
 Events.on(Engine, "collisionActive", callback)
To listen for collision start, end and when body currently colide but I can't find any information what was checked before providing collision pairs, simply:
Do collision category or group or any other option of body affect collision results in any way ?
or this event just returns all colliding objects and it does not matter if body is sensor or in different collision group/category. Do I have to check it manually?

If the collision filter says two bodies can't collide, there will not be any collision object generated, since those pairs get skipped over before they are checked. So they won't appear in any events, is that what you mean?

Yes, exactly this - thank you for clearing it


Windows SmartScreen alert

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Hello,
I downloaded Chatterino today from the homepage (chatterino.com) and here from github. For both installers, Windows SmartScreen prevents the installation or warns about it?!
Is there an error here or can I ignore it?
Screenshots
No response
OS and Chatterino Version
Chatterino 2.4.6 (commit eb8c7f2) installer - Windows 10 22H2

It started happening after we built the installer exe's via github actions (version 2.4.5 onwards) - we would need someone to go through and debug the building to find what's causing the FP, it also doesn't happen to everyone.
Here's the virustotal for 2.4.5 https://www.virustotal.com/gui/file/60fbcd77d637b529e0a056e7c743c819e1bdb5ab376c0da27b6df3f167ca8767
You can go ahead and upload the 2.4.6 exe as well if you're still worried.

It's about a blue SmartScreen warning, right?
https://learn.microsoft.com/en-us/windows/security/operating-system-security/virus-and-threat-protection/microsoft-defender-smartscreen/

Checking downloaded files against a list of files that are well known and downloaded frequently. If the file isn't on that list, Microsoft Defender SmartScreen shows a warning, advising caution.

Running the 2.4.4 installer will automatically unblock it, but running the 2.4.6 installer will show the SmartScreen warning.
If you disconnect your network and than run the 2.4.4 Installer a SmartScreen warning will appear saying:

"SmartScreen can't be reached right now"

Note: already unblocked installer won't show a SmartScreen warning
Unblock  a file manually: https://www.tenforums.com/tutorials/5357-unblock-file-windows-10-a.html
Additional Information:
https://security.stackexchange.com/a/139520
https://security.stackexchange.com/a/242626

Smartscreen is based on reputation of binary, if enough people runs it it will go away, but nothing we can change in code to make it faster. After installer changed recently, likely we are gaining reputation from 0 because change was big enough.
The only shortcut would be signing all binaries we ship (~$200/y iirc), then smartscreen will use cert for reputation. This should make warning go away slightly faster and hopefully never come back.

kornes explained this problem well, the issue should eventually resolve itself and we already need to pay Apple to fix their version of this that never-goes-away-until-you-pay, so I'll close this and mention it in the FAQ issue.

I'll link https://github.com/ImageMagick/ImageMagick/discussions/6826 for reference, as they're discussing code-signing as well.


commit to test cicd

Signed-off-by: Mike Ng<EMAIL_ADDRESS>No op change to test new CICD integration changes.

/lgtm


Initial checkin of prototype of merged tests

XXX DO NOT MERGE XXX
This currently fails because JpaUnitTestRule doesn't implement the extension
interface yet.

This change is

Thanks Sara, I will take a look. This PR is for the purpose to merge the unit test of DatastoreTransacntionManagerTest and JpaTransactionManagerImplTest into a single code path.

Closing due to inactivity.


Suggestion: Use ViewTransitions

Do you plan to use ViewTransitions https://astro.build/blog/astro-290/?
Or, may be, you will wait until it is not experimental anymore in 3.0?

Yep, I might include it when upgrading AstroPaper to Astro v3, but for now, I'm not planning to use this feature yet.

Is there a reason for card and datetime components are react comps and not astro comps, bc i can't find a way to add transition:name in react components.

Is there a reason for card and datetime components to be react components and not astro components, bc i can't find a way to add transition:name in react components.

@tanishqmanuja
Yes. These components are also used inside search which needs to be React component for interactivity. But in AstroPaper v3, I've tried to solve this issue by separating Astro component and React component with minimal duplicate codes.

Btw if we are not using react-dom, migration to preact will save a lot of bundle size. What's your opinion, could there be any problem that i am unaware of?


Refactor article about comment with ChatGPT

Category
/**
 * @file
 * This file contains the main function for the program.
 */

#include <iostream>

    /**
     * @brief A brief description of the function.
     *
     * This is a detailed description of the function.
     * It can span multiple lines and can include examples,
     * parameter descriptions, and return value descriptions.
     *
     * @param arg1 A description of the first argument.
     * @param arg2 A description of the second argument.
     * @return A description of the return value.
     */
    int myFunction(int arg1, int arg2) {
        // TODO This is a comment tag to add error handling
        return arg1 + arg2;
    }

int main(int argc, char* argv[]) {

    std::cout << "Hello, world!" << std::endl; // This is an inline comment

    // Single-line comment
    std::cout << "This is a single-line comment" << std::endl;

    /*
     * Multi-line comment
     * This is a multi-line comment.
     * It can span multiple lines.
     */

    int var = myFunction();

    return 0;
}

Principle
Clarity: Well-documented code helps developers understand how the code works, its intended functionality, and how to use it correctly. This clarity is essential for maintaining and troubleshooting code, especially in complex projects or when working with legacy code.
Maintainability: Good documentation makes it easier for developers to update, modify, or fix code, even if they are not the original authors. It ensures that the code remains maintainable and can be extended or improved over time, without causing unintended consequences or introducing bugs.
Collaboration: Documentation promotes collaboration among team members, allowing them to understand each other's code, share knowledge, and work together more effectively. It serves as a reference for team members, facilitating communication and coordination in software development projects.
References

Sentenz docs as code article.

// TODO Create a reference in Docs as Code
References

Sentenz comment article.


Warn if benchmarking with debugger attached

BenchmarkDotNet generates the following warning:
// * Warnings *
Environment
  Summary -> Benchmark was executed with attached debugger

@jzabroski I don't know if you have figured this out.
If you go to this link: https://benchmarkdotnet.org/articles/guides/good-practices.html#use-the-release-build-without-an-attached-debugger
They have specified running the program from command line after you build it with Optimize code enabled.
You seem to be running from Visual Studio instead of command line.

This is xunit-performance which is basically a dead project.

Closing prior to archive.

Closing prior to archive.


[Windows Customization] Ability to customize the File Explorer context menu

Suggested new feature or improvement
The context menu in Windows File Explorer is a critical tool for developers working on Windows. It's the gateway to essential actions, providing quick access to file operations, debugging tools, and integration with third-party software. However, the current context menu should do more to meet the evolving and fast-paced needs of developers.
Developers want the ability to customize and adapt their tools to the needs of their workflows and personal preferences – the context menu within File Explorer is no exception to this rule. Lack of single/low-click access to frequent developer tooling & actions, vague icons, and inconsistent UI suggestions are all sources of developer dissatisfaction that we have the ability to fix.
I suggest accomplishing the following goals through Dev Home's upcoming Windows Customization work:

Users can access the context menu customization options within the Advanced Settings in Dev Home.
Users can select from predefined context menu presets (i.e. frequently used shortcuts/items that developers would be likely to use) optimized for common developer workflows.
Users can add new items or actions (including third-party applications/tools) to the modern (Windows 11) context menu to tailor it to their specific needs.
Users can hide context menu items from the modern (Windows 11) context menu that they do not use or want to appear
Users can revert to the default context menu settings if they wish to undo their customizations.
Users can back up their custom context menu settings/customizations to their MSA (achieved via Dev Home’s “Advanced Settings” architecture)

Scenario

Adding or removing built-in presets to the context menu (e.g. "Share", "Add to Favorities"", "Properties")
Controlling app-provided verb visibility in the context menu (e.g. "Open with Visual Studio")

Additional details
No response

xref: https://github.com/microsoft/PowerToys/issues/33


Swipe doesn't work inside modal

Hi. I am having a problem with the carousel inside the react-native-modal Modal component. The project is private but I was able to reproduce a very small example for you to see the issue.
Describe the bug
The carousel doesn't swipe when inside the react-native-modal Modal.
To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/rares-munteanu/carousel-test
yarn && yarn run android
click open modal
Swipe should propagate to carousel

Expected behavior
Swipe should propagate to carousel
Versions (please complete the following information):
"react": "18.2.0",
"react-native": "0.71.2",
"react-native-gesture-handler": "1.10.3",
"react-native-modal": "13.0.1",
"react-native-reanimated": "2.14.4",
"react-native-reanimated-carousel": "3.1.5"
Smartphone (please complete the following information):

Device: Xiaomi Poco F4 GT
OS: MIUI 13.0.8

Already tried the tips from the previous issues related to this matter. It doesn;t work.

Both #243 #168 seem to resolve this issue with gestureHandlerRootHOC. I have been trying to get that to work with no luck though.

@lachierussell I solved it finally by updating the "react-native-gesture-handler" package. Just followed the instructions from docs and it was working. Not sure why it wasn't before updating. It was supposed to 🤷🏻♂.

That worked! Thanks!


Make use of deprecated shared flag an error

This one should be an error IMHO
{"level":"info","template":"microsoft.com.o365.json","time":1708368313,"message":"shared flag is deprecated, use sharedProviderName as well"}

Commit 83576c1714d6b2a6a494322a308c1909cc7ef927 changed the warning to error.


Change version to v0.8.2

In preparation for #770, just changing the release tag in the docs and config.

@jashapiro I just updated this to use all the new scpcaTools containers too.


[Feature Request] Table View for JSON response

Hi @wonderbeyond. Can you provide some more information on this request? More details on "what" this is and "why" it would be useful would be awesome 😄

@gschier
What is "Table View for JSON response"
Take the following data as example:
[
    {
        "_key": "100",
        "title": "Case#100"
    },
    {
        "_key": "101",
        "title": "Case#101"
    }
]

We can display it like this:

_key
title

100
Case#100

101
Case#101

Why it would be useful

More readable
Leverage the horizontal space to display items more compactly

Yes! Something like JSON Data Ninja built in would be incredible...

Since a table view would only work with a very specific data format, I hesitate to include it as a general feature. However, I would be open to adding something like this instead: https://github.com/alexkuz/react-json-tree

@gschier I think that would work just as well! 👍

The above comment is sort of tech savvy. I was requesting in another thread #529 to go for something like the Altova XML Spy provides. This way it's more user friendly (at least you don't have to keep expanding / collapsing the object hierarchy. It'd be really nice if this is available for both request (for editing or previewing raw JSON body section) and response panes.
Reference URL: http://manual.altova.com/xmlspy/spyenterprise/xseditingviews_gridview_tables.htm
or, http://valentin.dasdeck.com/lingo/dml/screenshots/xmlspy_grid_view.png

@ray-qu @gschier
https://github.com/getinsomnia/insomnia/issues/534 may cover this feature. We can add custom templates for rendering json/xml into table view.

Ya. I think the problem is best solved by extending the plugin system to allow for custom content type viewers, which would allow both solutions. I mentioned this over here as well https://github.com/getinsomnia/insomnia/issues/529#issuecomment-339036179