Many bug with Bootstrap Tour since the transition to Bootstrap 3.4.1

Hi, I just updated my site to Bootstrap 3.4.1 and I encounter many bug with Bootstrap Tour.
It's been a year since this program was not updated, is it abandoned?
Before the Bootstrap 3.3.7 update to Bootstrap 3.4.1 the "Tour" worked correctly, now the button is gone.
https://image.noelshack.com/fichiers/2019/08/1/1550519186-capture-d-ecran-de-2019-02-18-20-44-53.png
I added a button to go up but each time I have the same error. I followed several tutorials but all created an error. Acrylic I use this method :
https://markups.io/jquery-back-to-top-button/
https://image.noelshack.com/fichiers/2019/08/1/1550519195-capture-d-ecran-du-2019-02-18-20-11-07.png
(function ($) {
  'use strict';

// Instance the tour
var tour = new Tour({
  steps: [
  {
    element: ".region-navigation-menu-first",
    placement: "bottom",
    title: "Le menu de navigation",
    content: `
Le menu de navigation, permet de naviguer sur le site.

L'icône clignote, lorsque vous pouvez administrer la page actuelle.
`,
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: ".region-navigation-notification-first",
    placement: "bottom",
    title: "Les notifications",
    content: `
Le logo notification, permet d'accéder aux notifications liées à l'activité de votre compte (statut des commandes, message privé, ...), ainsi qu'à celle du site (suivi des groupes, suivi des boutiques, ...).

L'icône clignote, lorsque vous avez un nouveau message.
`,
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: ".region-navigation-logo .logo",
    placement: "bottom",
    title: "Le logo",
    content: "Cliquer sur le logo S1BIOSE pour revenir à la page d'accueil. Vous y trouverez toutes l'activité du site classé par ordres chronologiques.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: ".region-navigation-notification-second",
    placement: "bottom",
    title: "Les paniers",
    content: `
Le logo panier, permet d'accéder à vos paniers d'achats.

L'icône clignote, lorsque vous ajoutez des produits ou des services.
`,
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: ".region-navigation-menu-second",
    placement: "bottom",
    title: "Le menu de recherche",
    content: `
Le menu de recherche, permet de filtrer et trier le contenu d'une page.

L'icône clignote, lorsque vous pouvez filtrer ou trier le contenu de la page actuelle.
`,
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: "#block-boutonplus #dropdown-menu-action",
    placement: "top",
    title: "Le bouton plus",
    content: "Ce bouton vous permet de créer votre compte, mais aussi des groupes, du contenu, des boutiques et des produits.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: "#block-follow .field--name-body",
    placement: "top",
    title: "Trouver de l'aide",
    content: "Nous mettons à votre disposition des guides, des tutoriels, une foire aux question, ... où vous trouverez facilement de l'aide.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: "#block-contact .field--name-body",
    placement: "top",
    title: "Les modes de contact",
    content: "Vous pouvez nous contacter par téléphone, courrier postal et par e-mail.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: "#block-information .field--name-body",
    placement: "top",
    title: "Les informations",
    content: "Ici vous trouverez toutes les informations juridiques concernant notre site.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  },
  {
    element: "#backtotop",
    placement: "top",
    title: "Le bouton retour en haut",
    content: "Ce bouton vous permet de remonter en haut de la page.",
    template: `

      <button class='btn btn-default btn-sm' data-role='prev'>« Précédent</button>
      |
      <button class='btn btn-default btn-sm' data-role='next'>Suivant »</button>

  <button class='btn btn-default btn-xs' data-role='end'>Quitter</button>

`,
    backdrop: true,
    backdropPadding: 0
  }
]});

// Initialize the tour
tour.init();

// Restart the tour
$('#bs-tour-restart-1').click(function () {
  $('#navbar-collapse-first, #navbar-collapse-second').collapse('hide');
  tour.restart();
});

$('#bs-tour-restart-2').click(function () {
  tour.restart();
});

}(jQuery));

BACK TO TOP
(function ($) {

/*--Scroll Back to Top Button Show--*/

$(window).scroll(function(){
    if ($(this).scrollTop() > 100) {
        $('#back-to-top').fadeIn();
    } else {
        $('#back-to-top').fadeOut();
    }
});

//Click event scroll to top button jquery

$('#back-to-top').click(function(){
    $('html, body').animate({scrollTop : 0},600);
    return false;
});

})(jQuery);

Can you put all that in a jsfiddle please, add explain what you're trying to do in detail? You should generally have the template set once globally and not per step.
Also, depending what your#back-to-top element is and the classes set, it'll appear below the tour backdrop and be untouchable. And you probably want to double check the docs on setting element: step option, as you're using jquery selectors.
This project isn't abandoned, the original authors are just too busy to continue at the moment. I've forked this project and added a lot of fixes and features:
https://github.com/IGreatlyDislikeJavascript/bootstrap-tourist
Note I am not an author or owner of bootstrap-tour, I just needed some extra things fixed.

me too

I am also experiencing problems after upgrading bootstrap to 3.4.1.  The prev/next/end tour buttons have disappeared with bootstrap-3.4.1.
Here's a working jsfiddle with bootstrap-3.3.6 where the dialogue shows prev/next/end buttons:

and indeed the HTML is there:

    <button class="btn btn-sm btn-default disabled" data-role="prev">« Prev</button>
    <button class="btn btn-sm btn-default disabled" data-role="next">Next »</button>

  <button class="btn btn-sm btn-default" data-role="end">End tour</button>

Here's a jsfiddle with bootstrap-3.4.1 that does not work as expected. When I start the tour, there are no buttons.  Inspecting the element shows this for the HTML:

and the HTML is missing for the navigation:

Thanks for the great explanation. This problem is caused by the BS sanitizer stripping the non-whitelisted DOM elements from the template.
I've fixed this with a fast release of Bootstrap Tourist, which solves the problem for Tour without affecting the rest of Bootstrap or any other sanitization:
https://github.com/IGreatlyDislikeJavascript/bootstrap-tourist
You can fix your problem by switching to using Bootstrap Tourist. Tourist is a fork of Bootstrap Tour that can be dropped in to your current code with the simple removal of the call to init(). It contains many fixes and additional features. The readme explains why it exists.

Alternatively you can fix the problem by changing the whitelist of the BS popover plugin to include the button DOM element with data-role attribute. You can do this globally to all BS popovers by following the instructions here: https://getbootstrap.com/docs/3.4/javascript/#js-sanitizer . However be extremely careful and make sure you understand your use case, because making global manual changes to the BS sanitizer can create a security issue and XSS attach as per the CVE pedros007 has highlighted.

... or perhaps you could fix the problem by using a instead of button in the template? eg

    « Prev
    Next »

  End tour

Pavarnos, yes that would also work perfectly, and is a direct fix vs switching to my fork. It works because the a element is included in the default bootstrap whitelist.
However the bootstrap sanitizer is a breaking change, and there could conceivably be tours that have steps containing DOM elements, or attributes of elements, that are not in the whitelist. The whitelist could also get changed in future. That will manifest as the elements / attributes missing, stripped from the DOM when the tour step is shown.
One example is the style attribute for an img element.
In those cases, where an alternate permitted element isn't available, either use my fork to add to the whitelist for specific tours only. Or change the global Bootstrap sanitizer default whitelist to include the required elements and attributes. Any whitelist does need careful consideration to avoid XSS flaws etc.

I have the same issue, but I am stuck with the template part as its .popover-navigation does not render as HTML or with .popover-content filled with content.
I think this is because in BS4 popovers (and tooltips) are not rendered as HTML by default (data-html='false') and adding a html: true property does nothing during instantiation of the tour as it is not a tour property. Am I missing something?
I have tried both declaring it as a a data-template attribute (as the docs use a multiline double quote, an HTML thing) or a property of the object ("dictionary item" in Python speak) passed to the Tour constructor with a template literal ("multiline string") or a regular string.
@pavarnos, as your snippet uses double quotes, while the docs uses single quotes I am guessing you have a different template declared compared to the docs, is that so?
@IGreatlyDislikeJavascript, I tried your code, but I got a few errors (below) so want to solve it via the template approach.
jquery-3.3.1.min.js:2 Uncaught TypeError: Cannot read property 'whiteList' of undefined
from the line if($.fn.popover.Constructor.DEFAULTS.whiteList !== undefined), changing 'DEFAULTS' to 'Default', which has the property 'whitelist' gives another error (with tour.init() removed):
[Uncaught Error: TOOLTIP: Option "sanitizeFn" provided type "undefined" but expected type "(null|function)".

@matteoferla I've got this fixed properly now. There were 2 problems in my previous commit.
One was a silly typo ref the sanitizeFn error, which @st8st8 fixed in my repo.
The second was a nightmare problem caused by Bootstrap itself - the CDN bootstrap doesn't properly expose the default.whitelist option. So although my code was working locally using the CDN, when I downloaded BS4 bundle and tried against a local version I got exactly the same issues. So, lesson learned, do not use the CDN because it's not the same as BS4 bundle download.
I've now fixed all these issues, and improved some other parts of the BS4 compatibility, so please do give my fork another try and let me know any bugs (preferably in my repo's forum, to keep clean distinction between the original sorich87 Tour issues).
You will need to specify the framework option, i.e.:
var Tour=new Tour({
				steps: [...your steps...],
				framework: "bootstrap4", // can be string literal "bootstrap3" or "bootstrap4"
});

For reference, you said:

adding a html: true property does nothing during instantiation of the tour as it is not a tour property. Am I missing something?

You're correct that html:true is not a tour property, it's a BS popover property. However Tour/Tourist has this property set by default when creating the popover, so if your HTML isn't rendering then there's another issue.
Note that original Tour doesn't support BS4 fully because a) the template is wrong, b) some BS3 only methods are used in the code, and c) the sanitizer issue that caused this thread. I think I've now fixed all these in Tourist fork, but would appreciate testing etc as I mainly use BS3.

@IGreatlyDislikeJavascript Thank you very much for your time and effort put to correct some bugs from the original bootstrap-tour. You saved my day. It would be great to have your package in NPM repo too. Congrats and thanks again.

Perfect.
So the template option in both vanilla BS-Tour and Tourist works except that BS4 changed the words popover-title to popover-header and popover-content to popover-body —like they did with so much else, damn them (BS4 is much much better though).
I can confirm that Tourist works for me too —although backdrop: true isn't active.
BS4.3 has toast that works, now I have toasts and a tour. Thanks!

A quick update, backdrop: true works.
The BS4 template has a small CSS issue (or feature*) that the buttons as btn-default, which was changed to btn-primary in BS4. But this can be fixed and improved by simply declaring the template template: '

 <button class="btn btn-sm btn-primary" data-role="prev">« Prev</button> <button class="btn btn-sm btn-primary" data-role="next">Next »</button> <button class="btn btn-sm btn-primary" data-role="pause-resume" data-pause-text="Pause" data-resume-text="Resume">Pause</button>
 <button class="btn btn-sm btn-warning" data-role="end">End tour</button>

'.
∗The default primary buttons are obnoxious, so I prefer the outline version...
If anyone wants to try out a tempory CDN of the library use  and <link rel="stylesheet" href="https://www.matteoferla.com/bootstrap-tourist/bootstrap-tourist.css">. It is on a residential server so the speed is bad, so just use it for dev work.
Again, thanks, @IGreatlyDislikeJavascript for saving the day.

@matteoferla thanks for spotting that, I'll update the template accordingly and will probably add another selectable template in the next release using your outline button template. Thanks for hosting a CDN, yes the license etc remains MIT and exactly the same as original Tour.
Next release I'm working on the popper.js / bootstrap4 override issue.

Is it possible to have this issue fixed and release a new version of Bootstrap Tour compatible with the last version Bootstrap from 3.x cycle?

May i know why BootstrapTour is still an active project if no fix has been made since 4 months ?

@acotiuga @AntoineWtrnd the original authors of Tour currently don't have the time to maintain this project, or port it from coffee script to ES6.
Bootstrap Tourist is a fork of Tour which includes many added features and fixes - including a fix for the bootstrap issue reported in this thread.
Tourist is a drop in replacement for Tour. You can find it, see the added features, and read why Tourist was forked from Tour, here:
https://github.com/IGreatlyDislikeJavascript/bootstrap-tourist

Test

Test

As mentioned above, this project is clearly dead as a dodo and you will not get a reply: use the version by IGreatlyDislikeJavaScript. TBH I was put off by his username (IMO JS is unjustly hated, yes the async and this are nightmares, but it is not as annoying as Perl or R) and by the extra line required to state BS version as opposed to using $.fn.tooltip.Constructor.VERSION to check itself. But it works fine so just use that.

Simple solution for those who need to solve fast:
$.fn.tooltip.Constructor.DEFAULTS.whiteList.button = ['data-role'];

But it's recommended to migrate to the @IGreatlyDislikeJavascript fork.
[]'s

i have exactly the same issue and i fix it by using -standalone version ,bootstrap-tour-standalone.min.js and bootstrap-tour-standlone.min.css


Image Size Function Failing Size Test

The test that checks whether the image is compressed to the right size is failing
Probably need to adjust the calculation in the test, but not sure how PNG does compression

Can you post more about the example that you are using for the test?

compressed_img = compress(img_path, 3)
assert image_size(compressed_img) < 4/8 * image_size(img_path)
This line causes the test to fail. The compressed image is bigger than 4/8 of the original.

I think we can increase the error margin a little bit as skimage.io.imsave might be saving some more information along with the image (which I am suspecting to be of a small size). That is why the tests are working on large images but failing on small ones.

Increased margin of error in tests.


How to delete the code-server completely from Termux??

Is there any way to delete this from Termux on Android?
Thank You!!!

You can just rm -r the code-server directory. It depends on where you installed it, but if you used the install script by default it'll be in ~/.local/lib/code-server-<version> and there will also be a binary symlink in ~/.local/bin/code-server you can remove.
If you want to delete settings and data as well you can remove ~/.local/share/code-server and ~/.config/code-server.

If you used yarn or npm to install code-server then you can use them to remove it.


chore(template): added pull request template

Intent

Add template for pull requests.

:tada: This PR is included in version 4.31.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


e2e-pool: Plumb in BASE_DOMAIN

hiveutil still defaults the base domain to new-installer.openshift.com, which is probably what we want since we (hive engineers) are the ones invoking it by hand, using the hive-team cluster as a hub, and will thus prefer less typing.
But now that we're switching to a new AWS account for CI, we want the AWS-based e2e suites to use the new base domain. We recognize and default a $BASE_DOMAIN variable for e2e itself, but weren't yet plumbing it through to e2e-pool. Fix.
HIVE-2259

/lgtm

Well the plumbing is working.
But somehow we're enabling managed DNS, despite explicitly disabling it in the test config.
Actually, now that I look at it, we should be exporting that sucker. Fix on the way...
https://github.com/openshift/release/pull/42172

Of note: it doesn't look like we have a way to make clusterpool clusters use managed DNS. I'm not completely sure there's a use case for that in the first place, but I thought it was interesting.

Actually, now that I look at it, we should be exporting that sucker. Fix on the way...

✓
test e2e-pool

also
/hold cancel

Okay, I'm sick of this -- infra flake on cleanup after the test succeeded.
/override ci/prow/e2e-pool


Error while running supabase db pull

I am getting an error while running npx supabase db pull -
Connecting to remote database...
failed to open dump file: open supabase/migrations/20240314130741_remote_schema.sql: no such file or directory
Try rerunning the command with --debug to troubleshoot the error
System information

Ticket ID: 20f59ba2330e4539947f473eb6eb3001
Version of OS: macOS 14.1.1 (23B81)
Version of CLI: 1.148.6
Version of Docker: v25.0.3
Versions of services:

SERVICE
IMAGE
LOCAL
LINKED

supabase/postgres
<IP_ADDRESS>
<IP_ADDRESS>

supabase/gotrue
v2.144.0
v2.144.0

postgrest/postgrest
v12.0.2
v12.0.2

supabase/realtime
v2.25.66
-

supabase/storage-api
v0.46.4
v0.48.2

supabase/edge-runtime
v1.38.0
-

supabase/studio
20240301-0942bfe
-

supabase/postgres-meta
v0.79.0
-

supabase/logflare
1.4.0
-

bitnami/pgbouncer
1.20.1-debian-11-r39
-

darthsim/imgproxy
v3.8.0
-

This has been addressed in beta release: npx supabase@beta db pull
Stable release will go out next Tuesday.

npx supabase@beta db pull works! Thanks for the quick revert. Looking forward to the stable release next Tuesday.

This has been addressed in beta release: npx supabase@beta db pull
Stable release will go out next Tuesday.

I wander when release the new stable supabase that i can recreate all local dev envirment.


Add eficient hypergeometric

This adds hypergeometric distribution. Both the cdf and ppf are computed numerically. The ppf is off by one, not sure why as all other tests are passing. In the meantime, I am handling the hypergeometric as a special case.
This also updates the find_ppf function to make it work with discrete distributions.

Codecov Report
Attention: Patch coverage is 91.86992% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (f659f65) to head (e949e27).
Report is 11 commits behind head on main.

Files
Patch %
Lines

preliz/distributions/hypergeometric.py
88.76%
10 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   81.14%   81.33%   +0.19%
==========================================
  Files          73       85      +12
  Lines        6448     7066     +618
==========================================
+ Hits         5232     5747     +515
- Misses       1216     1319     +103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create a Node-RED stack

Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[x] Followed the commit message guidelines.

[x] Stack adheres to Appsody stack structure - as far as I can tell, yes, but part of the reason for raising this as a draft PR now is to get some more eyes on to it so we can see what I've missed.

Contributing a new stack:

Describe how application dependencies are managed:

A node-red project consists of a package.json file and the flow configuration file. Any user-defined dependencies are listed in the package.json file and installed as part of the stack build - this follows the same pattern as the existing nodejs stacks.

Explain how Appsody file watcher is utilized:

The watcher watches the flow json file and rebuilds whenever it is changed. In the context of a Node-RED project, the flow json is the 'source code' the user will be changing.

Describe other Appsody environment variables defined by the stack image:

None above and beyond what the sample/nodejs stacks provide.

Describe any limitations and known issues:

Needs some more testing and sanity checking - hence why it is a (currently) a draft PR.
Related Issues:
Closes #427

@knolleary is this read for us to take a look at and review?

@sympatheticmoose I think so... it all works from my perspective.

@knolleary In that case, can we take it off draft?

@Kamran64 done

@Kamran64 thanks for the comments - all fixed.
Will look at the kube side of things as that's a space I've not properly explored with appsody yet.

I noticed you haven't included any .js files in the default template. We usually prefer to give the user a simple application in the template that users will get if they do an init.

Hi @skoh7645
this is a stack for Node-RED, not Node.js. So the default template provides a minimal Node-RED project - which consists of the package.json and flow.json files. For a simple project, there are no JavaScript files for the user to create.

Thanks @skoh7645 - changes pushed to get the version number consistent throughout and remove those unused env vars.

Thanks @knolleary for making the requested changes. Have you considered adding a simple "hello world" (or Node-RED equivalent) application to the default template? The stack is also missing the config/app-deploy.yaml file Appsody uses for deployment that @Kamran64 has mentioned perviously.

Hi @knolleary - Just took a quick look and noted a few things that jumped out at me.
Looks good overall so far though!
Note: We now have the option to deploy to Kubernetes if there is a deployment file called app-deploy.yaml present in the image/config directory. You may want to take a look at how existing node stacks use this (If you choose to add it, that is). E.g. For nodejs

@skoh7645 yes, I do plan to update the default template with a sample app as well as add to the documentation. But that is follow-on work to getting the basic stack structure right which is my primary concern.
I'll look at adding the app-deploy file. I assume it can be much the same as the existing node.js one.

I believe this PR has had all of the changes requested and can be re-reviewed - @Kamran64 @skoh7645

Expanding the content of the simple application template is a follow-on piece of work. I don't plan to do that as part of this PR.

We decided to hold off merging this stack until the application is in as it would be concerning for the user, if the first thing they see when they hit that endpoint is "Not Found".

Hi @skoh7645 - I've now added a default flow to the simple template.

LGTM - @skoh7645, thoughts?

The image built with appsody build fails to run, we think it is a problem with Appmetrics

Your stacktrace includes /project/server.js:58:
app.use(appSettings.httpAdminRoot,RED.httpAdmin);

That doesn't look like a middleware registration, and the error message would suggest that ppSettings.httpAdminRoot is undefined.

Thanks for prompt @sam-github.
I had assumed this was an issue with appmetrics because I'd seen something similar with it in the past, but I've not had the time to dig into it.
But your comment made me spot the issue - you are right that httpAdminRoot is not defined, and by default it isn't expected to be. So this just needed a simple check before trying to mount the admin express app.
I've tested it locally and all is working now.
@skoh7645 thanks for your patience on this - been a busy few weeks.


Roll engine b23138c3598e..7880cc75a53e (2 commits)

https://github.com/flutter/engine/compare/b23138c3598e...7880cc75a53e
git log b23138c3598e..7880cc75a53e --first-parent --oneline
2020-03-15<EMAIL_ADDRESS>Roll src/third_party/skia 7e0a7dbd22e0..9a4ac6e86586 (1 commits) (flutter/engine#17163)
2020-03-15<EMAIL_ADDRESS>Update the Metal backend selection to use iOS 10.0 and A7 as the version floor. (flutter/engine#17162)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


Adding gene annotation without mRNA in gff

I'm trying to add gene annotation to my plot, and I get the following error about missing mRNA:
$ plotsr --sr "UW224.syri.out" --genomes "UW224.manifest" --tracks HG316453.2.tracks -o "UW224.pdf" -H 3 -W 5
track - WARNING - Reading GFF file HG316453.2.gff. Overlapping transcripts would be plotted as such without any filtering.
track - ERROR - In GFF: HG316453.2.gff at line ['HG316453.2', 'EMBL', 'CDS', '202', '1557', '.', '+', '0', 'ID=cds-CDJ54313.1;Parent=gene-SPYH293_00001;Dbxref=NCBI_GP:CDJ54313.1;Name=CDJ54313.1;gbkey=CDS;gene=dnaA;inference=similar', 'to', 'AA', 'sequence:UniProtKB:P05648;locus_tag=SPYH293_00001;product=Chromosomal', 'replication', 'initiator', 'protein', 'DnaA;protein_id=CDJ54313.1;transl_table=11'], CDS feature is before the mRNA feature. Expected mRNA before CDS. Exiting.

Here is the tracks file:
# file	name	tags
HG316453.2.gff	Genes	ft:gff;bw:10000;nc:black;ns:8;nf:DejaVu Sans;lc:blue;lw:4;bc:lightblue;ba:0.5

HG316453.2.gff was downloaded from Genbank and does not include mRNA:
https://eutils.ncbi.nlm.nih.gov/sviewer/viewer.cgi?retmode=text&id=HG316453.2&db=nucleotide&report=gff3
Is it possible to have plotsr add gene annotation without mRNA, or do I need to find a different source for my annotation? Note that the plot works just fine if I don't try to include the annotation track.
Thank you.

I got it to work with the following changes:
--- a/func.py   2022-10-07 18:43:07.732793417 -0500
+++ b/func.py   2022-10-07 18:40:47.295190378 -0500
@@ -645,7 +645,7 @@
         from collections import defaultdict, deque
         import sys
         annos = defaultdict(dict)
-        acceptlist = {'mrna', 'cds'}
+        acceptlist = {'gene', 'cds'}
         featwarn = True
         skipchr = []
         chrs = set(chrlengths[0][1].keys())
@@ -654,6 +654,8 @@
             model = None
             for line in fin:
                 line = line.strip().split()
+                if not line:
+                    continue
                 if line[0] not in chrs:
                     if line[0] not in skipchr:
                         skipchr.append(line[0])
@@ -672,7 +674,7 @@
                         sys.exit()

                     if model is not None:
-                        if t == 'mrna':
+                        if t == 'gene':
                             k = list(model.keys())[0]
                             annos[k[0]][(k[1], k[2])] = model.values()
                             model = defaultdict()
@@ -682,7 +684,7 @@
                             model[cse].append((int(line[3]), int(line[4])))
                     elif model is None:
                         if t == 'cds':
-                            self.logger.error("In GFF: {} at line {}, CDS feature is before the mRNA feature. Expected mRNA before CDS. Exiting.".format(self.f, line))
+                            self.logger.error("In GFF: {} at line {}, CDS feature is before the gene feature. Expected gene before CDS. Exiting.".format(self.f, line))
                             sys.exit()
                         else:
                             model = defaultdict()

I don't know if swapping mRNA for gene is appropriate in all cases, but it works for me.
There is a second fix in that patch -- ignore blank lines.

Hi Jason,
Thanks for checking this out. Indeed, this could work for cases when the GFF file do not have the mRNA field. Alternatively, it is also possible to edit the gff file to substitute gene to 'mRNA`. That might be easier as well.


Submit select climate change details to PSCIS by appending to comments inpscis_tidy.R

can look at the climate change column comments and see if there are key things to move over in this script so they end up in the main pscis submission.
First iteration of this script here without climate change https://github.com/NewGraphEnvironment/fish_passage_fraser_2023_reporting/tree/main/scripts

we are already making changes to comments (ex. add moti culvert ID) there

For now this seems like concatenating all the comments is perhaps too much text.
Currently doing review of each crossing by hand so can add shortened key message from condition_notes, climate_notes and priority_notes to assessment_comments by hand if they key details are not already included (ex. culvert is rusted right through for entire length of both pipes and there is significant erosion at inlet could lead to road failure....)


MAINT: version bounds before 1.8.0rc1

attempt to add upper version bounds
before 1.8.0rc1

@rgommers I usually depend on you to find my mistakes on the version bounds stuff.
For reference, for maintenance/1.7.x last time we did this for the bounds: https://github.com/scipy/scipy/pull/14145

Maybe you can cherry-pick commit b568120126712ca933300e4d2c7a57e43f528ada into this PR as well?

Maybe you can cherry-pick commit b568120 into this PR as well?

I did that, and the other stuff suggested I think (currently with the newer setuptools which is perhaps undecided, mostly because I didn't see the second comment fast enough).

I did that, and the other stuff suggested I think (currently with the newer setuptools which is perhaps undecided, mostly because I didn't see the second comment fast enough).

Okay, let's leave that for now. It doesn't matter for rc1, so it's easy to change after. Actually that setuptools release will come out well before 1.8.0 final.

ok, 1.8.0rc1 wheel builds are running

64-bit Python 3.8 windows failure for wheel build--I'll try restarting, but pasting below as well (this kind of multiprocessing thing seems familiar lately, and we did add something related in https://github.com/MacPython/scipy-wheels/pull/144 to run_scipy_tests.py):
________________ TestDifferentialEvolutionSolver.test_parallel ________________
[gw1] win32 -- Python 3.8.0 C:\Python38-x64\python.exe
C:\Python38-x64\lib\site-packages\scipy\optimize\tests\test__differential_evolution.py:615: in test_parallel
    solver.solve()
        bounds     = [(0.0, 2.0), (0.0, 2.0)]
        p          = <multiprocessing.pool.Pool state=TERMINATE pool_size=2>
        self       = <scipy.optimize.tests.test__differential_evolution.TestDifferentialEvolutionSolver object at 0x00000173AC674EB0>
        solver     = <scipy.optimize._differentialevolution.DifferentialEvolutionSolver object at 0x00000173AC632A30>
C:\Python38-x64\lib\multiprocessing\pool.py:733: in __exit__
    self.terminate()
        exc_tb     = None
        exc_type   = None
        exc_val    = None
        self       = <multiprocessing.pool.Pool state=TERMINATE pool_size=2>
C:\Python38-x64\lib\multiprocessing\pool.py:656: in terminate
    self._terminate()
        self       = <multiprocessing.pool.Pool state=TERMINATE pool_size=2>
C:\Python38-x64\lib\multiprocessing\util.py:201: in __call__
    res = self._callback(*self._args, **self._kwargs)
        _finalizer_registry = {(None, 10): <Finalize object, callback=_close_handles, args=(2128, 2136)>, (None, 11): <Finalize object, callback=_close_handles, args=(2196, 2172)>}
        getpid     = <built-in function getpid>
        self       = <Finalize object, callback=_terminate_pool, args=(<_queue.SimpleQueue object at 0x00000173AC658E00>, <multiprocessing....aemon 944)>, <Thread(Thread-112, stopped daemon 848)>, <Thread(Thread-113, stopped daemon 1688)>, {}), exitpriority=15>
        sub_debug  = <function sub_debug at 0x00000173983E48B0>
        wr         = None
C:\Python38-x64\lib\multiprocessing\pool.py:710: in _terminate_pool
    p.terminate()
        cache      = {}
        change_notifier = <multiprocessing.queues.SimpleQueue object at 0x00000173AC674730>
        cls        = <class 'multiprocessing.pool.Pool'>
        inqueue    = <multiprocessing.queues.SimpleQueue object at 0x00000173AC632880>
        outqueue   = <multiprocessing.queues.SimpleQueue object at 0x00000173ACD24970>
        p          = <SpawnProcess name='SpawnPoolWorker-8' pid=316 parent=1028 stopped exitcode=0 daemon>
        pool       = [<SpawnProcess name='SpawnPoolWorker-7' pid=384 parent=1028 stopped exitcode=-SIGTERM daemon>, <SpawnProcess name='SpawnPoolWorker-8' pid=316 parent=1028 stopped exitcode=0 daemon>]
        result_handler = <Thread(Thread-113, stopped daemon 1688)>
        task_handler = <Thread(Thread-112, stopped daemon 848)>
        taskqueue  = <_queue.SimpleQueue object at 0x00000173AC658E00>
        worker_handler = <Thread(Thread-111, stopped daemon 944)>
C:\Python38-x64\lib\multiprocessing\process.py:133: in terminate
    self._popen.terminate()
        self       = <SpawnProcess name='SpawnPoolWorker-8' pid=316 parent=1028 stopped exitcode=0 daemon>
C:\Python38-x64\lib\multiprocessing\popen_spawn_win32.py:123: in terminate
    _winapi.TerminateProcess(int(self._handle), TERMINATE)
E   PermissionError: [WinError 5] Access is denied
        self       = <multiprocessing.popen_spawn_win32.Popen object at 0x00000173AC663970>
============================== warnings summary ===============================

ok, we lucked out, restarting worked


feat: add ngx-aws-deploy logo

As mentioned here by the ngx-aws-deploy logo.
Thanks @maartentibau

@Jefiozie Thank you! The SVG looks technically good, but can you remove the white margins please? 😎

Hi @fmalcher I removed the big margins around it, is this the resolution you're looking for?

Thanks!! 🙏


https support for the testnet site

Currently, the testnet explorer supports only http.
http://explorer.testnet.symboldev.network/
There are some environments where http sites cannot be displayed.
So it would be better to support also https.
Thanks!

thanks for report this.
@Wayonb if you have time, can look at it :)

thanks for report this.
@Wayonb if you have time, can look at it :)

what's the current status of this ^^

@AnthonyLaw Sorry I missed this. Did you need anything from me?

@Wayonb Nope from now, In early, I was thinking of just install the SSL/TLS on our Explorer web server should be fine, But It may have the CORS issue because our API nodes are not using Https
after some discussion @OlegMakarenko is working on it.

Thank you. Included in the latest version.


[bug]: Safari opens service UIs in new windows instead of new tabs

Prerequisites

[X] I have searched for existing issues that already report this problem.

embassyOS Version
0.3.4~1
Device
Laptop/Desktop
Device OS
MacOS
Device OS Version
13.2.1
Browser
Safari
Browser Version
16.3 (186<IP_ADDRESS>.6)
Current Behavior
When clicking on the link to open a service's UI, the browser opens a new window and loads the UI.
Expected Behavior
I expect the browser to open a new tab in the same window as the Embassy OS UI.
Steps to Reproduce

Log in to Embassy OS
Go to Services
Click on any service's UI link
Observe that the UI is loaded in a new browser window

Anything else?
I tested in Firefox and saw that it opened a new tab for service UIs. I tried multiple services in both Safari and Firefox. Safari consistently opens new windows. Firefox consistently opens new tabs.

We engineer mainly for (and highly recommend) Firefox.  We'll take a look at this and see if it's something we can fix.

The code to govern this is simply target="_blank" which tells the browser to open the link elsewhere. The default for most (if not all browsers) is a new tab. However, I believe you can override this behavior in browser settings, such that links are opened in new windows as opposed to new tabs. In other words, check your Safari settings. Either Safari defaults to opening links in new windows or you changed it to behave that way. Either way, there is nothing we can do in code to change the behavior. It's a browser thing.


Bump brain 0.1.17

Bump brain to v0.1.17 to match new auth-token for Prysm validator

No need to update prysm token finally


Not Working

This plugin does not appear to work using the latest version of babel and the es2016 preset - it appears to silently fail

Same here. Not working using:
    "babel-core": "^6.26.0",
    "babel-loader": "^7.1.3",
    "babel-plugin-autobind-class-methods": "^5.0.1",
    "babel-preset-react": "^6.24.1",
    "webpack": "^3.11.0",
    "webpack-dev-server": "^2.11.1"


chore(4.4): release 1.7.5

:robot: I have created a release beep boop
1.7.5 (2022-08-17)
Bug Fixes

remove cluster role bindings (#466) (ae50dde)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/GluuFederation/cloud-native-edition/releases/tag/v1.7.5 :sunflower:


[ Sugestion ] Map Cleanup

Add a cleanup button , either automaticly clean up the map after X Seconds

I've done the button, you can grab the source if you want.
Tell me if the auto cleaning is something worth doing.


Error: Operation $evaluate-measure on a large population

When trying to submit a GET request with Measure operation $evaluate-measure and practitioner as a parameter on a large population an error appears.
Example-Request:
*GET http://localhost:8000/Measure/ImmunizationStatus/$evaluate-measure?practitioner=ImmunizationStatus-practitioner-1``
        "resourceType": "OperationOutcome",
        "issue": [
                {
                        "severity": "error",
                        "code": "processing",
                        "diagnostics": "HAPI-0389: Failed to call access method: ca.uhn.fhir.context.ConfigurationException: HAPI-0464: Attempt to request all resources from an asynchronous search result.  The SearchParameterMap for this search probably should have been synchronous."
                }
        ]
}

The following POSTman collection, that was tested on the JPA-server-starter project, can be used to reproduce the error. This collection contains one failing request and >1000 test resources, including over 60 test patients.
https://gitlab.com/smilecdr-open-source/immunization-cql-poc/-/blob/main/resources/postman_collection_submission_v1.json
Please note, that you might need to enable cql_enabled=true (for jpa-server-starter in application.yaml).
My hint is that the trouble makers are these LOC / functions:

https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-jpaserver-cql/src/main/java/ca/uhn/fhir/cql/r4/evaluation/MeasureEvaluation.java#L110
https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-jpaserver-cql/src/main/java/ca/uhn/fhir/cql/r4/evaluation/MeasureEvaluation.java#L123

and for some reason the result of those large searches when calling Provider.getAllResources() is empty (or maybe took too long?)

Latest update: This bug has potentially been fixed by this pull request: https://github.com/hapifhir/hapi-fhir/commit/6c0c730ebcf857667a9e810804b50a68c9628468
manual testing with postman collection still pending.

+1

+1

This should be resolved with #4347.

(Please re-open if the issue re-occurs)


[$1000] Default avatar changes after a few seconds of starting a new chat with an existing account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create 2 accounts
Start a conversation from one account with the other using the search

Expected Result:
default avatar should not change
Actual Result:
the default avatar that appeared during the search and the start of the conversation changes to another default avatar after a few seconds
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.45-5
Reproducible in staging?: yes
Reproducible in production?: haven't checked
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/7d41e8ac-bb1a-4d70-b1fd-f080c3aee432
Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689789714639089
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d58542f791b71b70
Upwork Job ID:<PHONE_NUMBER>798455808
Last Price Increase: 2023-07-25

I don't have access to a dev environment so I can't reproduce the bug.

I don't have access to a dev environment so I can't reproduce the bug.

This can be reproduced in staging (and production too I guess)
https://github.com/Expensify/App/assets/87341702/22706a3c-6ea7-4ed5-b388-d475deb9df26

Updated the issue body

Got it. I just tested and saw the wrong colored profile icon for a split second both on the right hand-nav and in the chat. Then it flipped to the correct one.

Oh weird. Should I un-assign myself from this issue TJ? Looks like we are both assigned.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Default avatar changes after a few seconds of starting a new chat with an existing account
What is the root cause of that problem?
After creating the report from the search list, accountID is getting from API response that is returned from command=OpenReport.
This API response contains a newly added personalDetailList item.
But this accountID is different from the request param which was generated from the frontend side.
We are displaying default avatars that are based on accountID (that is getting in UserUtils.getDefaultAvatar).
Because 2 accountIDs are different, default avatars are displayed differently in the search list and report.

What changes do you think we should make in order to solve the problem?
We should fix OpenReport API in order to return the same accountID and avatar URL that is requested from the frontend side.
I don't know backend code but suggest using default variable with the requested accountID.
What alternative solutions did you explore? (Optional)
N/A

I don't think there's solution to fix this as optimistic accountID is different from real accountID and default avatars are generated differently,

This issue is clearly seen in offline mode.
https://github.com/Expensify/App/assets/108292595/b1f03251-2e05-4d71-9bd9-6b5f86b64ed9

@situchan
do you mean there is no way to fix by updating the API?

It's designed logic. Frontend cannot estimate accountID generated by backend.

It's designed logic. Frontend cannot estimate accountID generated by backend.

Yes, so I suggested passing the generated accountID from frontend to backend.
In the API side, we can use received parameter as a default value.
While doing it, we need to validate uniqueness.
If not unique, we need to generate the accountID from backend and update also persistent value in frontend.
This is just my solution for this issue

@railway17 please read following discussions before persisting your proposal.

https://expensify.slack.com/archives/C01GTK53T8Q/p1688995928956959
https://expensify.slack.com/archives/C01GTK53T8Q/p1689452076372489

hmm, thanks for the investigation, I see little to do if the accountID is used to determine the default avatar, specially for the offline case. We could fix it by stop using the accountID in the equation and only consider the display name or email, but I'm not sure if we want that.

@aldo-expensify are you suggesting we hold off on fixing the issue?

@tjferriss nop, I'm just not sure if we can really do something about it.
Do we want to remove the accountID from the calculation of the avatar? This has the downside that if two accounts have the same displayName, and you don't have the login, then you will see the same default avatar. I think this downside is enough to not do it and just live with this changing avatar thing.
thoughts?

@situchan do you have any thoughts on @aldo-expensify comments above?

I also don't like avatar depending on displayName.
If I don't know user's login and that user changes display name, avatar will change dynamically.
Seems like no solid solution yet

Ok, I think we should just close it then, for now it doesn't seem feasible because of the accountID change.
Thanks!


update pystiche dependency

What does this PR do?
This upgrades a couple of things regarding the pystiche dependency:

pystiche==1.0.0 was released and now follows semantic versioning. Thus, It is reasonable to pin it to the current stable release.
pystiche.ops is deprecated in favor of pystiche.loss. Although everything should work as expected as is, without change the code will now emit deprecation warnings. All occurrences of pystiche.ops were replaced.
pystiche's default branch was changed from master to main. A link was updated to reflect this.
pystiche should be written with a lower p. All occurrences in the documentation that did not do this were updated.

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Two problems here:

Some workflows fail, because they can't import stuff from pystiche>=1.0.0 although they never install any version explicitly. This tells me, that they pull in an older version from cache. I'm not in a position to fix that.
JIT tests are failing, because parts of the pystiche.loss.PerceptualLoss are no longer torch.jit.trace'able. This worked before, but only by chance. I'm wondering, why do you test for losses being able to be traced? AFAIK, torch.jit is used for efficient deployment of models for which the loss that they were trained on is irrelevant.

@ethanwharris
Thanks for the input.

It wasn't pystiche getting cached, the error was just cause by the use of pystiche components in the type annotation despite pystiche not being installed

Oh, I see. Wouldn't it make a lot more sense to quote the annotations instead of providing mock modules? That way there is no runtime effect in case pystiche is not available and if it is available mypy treats it the same as an unqouted annotation.

Regarding JIT, we don't try to jit the loss, only the forward. The issue seems to be that JIT.trace first recurses over all callable attributes of the model to see if they have been marked for export. When it hits loss.encoder, that throws a runtime error which is then not caught. I think the Multiple enocder attributes error in pystiche could be replaced with an AttributeError rather than a RuntimeError in order to fix this. For now I have just removed the loss_fn and perceptual_loss attributes before jitting in the test.

That is a valid point. I'll go and fix this there and send a new patch here.


Observation Space Misspecified?

Hello,
Thanks for the repo!
I was trying to set up a simple cartpole (swing up) environment and noticed that the observation space is specified with a range from 0 to 1 here as uint8. However, the actual observations are in the range 0 to 255. Am I misusing the environment wrapper or is this a bug?

Hi, thanks! That's just a bug created by the fact that none of my RL code checks the upper and lower bounds of the observation space and assumes it's always [-inf, inf]. The framestack wrapper also works for state-based observations which are float32. Should be fixed now!

I see - thanks!


feat: port Algebra.ContinuedFractions.Computation.Approximations

todo:

[ ] fib_le_of_continuantsAux_b unknown tactic mono
[ ] abs_sub_convergents_le unknown tactic mono
[ ] in theorem names and parameter names, use get? and nth consistently

I fixed the missing mono tactic manually, adding a porting note: I think we shouldn't wait until the tactic is ported...

All checks have passed, why is this PR marked help-wanted?

I don't know, perhaps because of the

[ ]  in theorem names and parameter names, use get? and nth consistently

Did mono fail to make progress or was it a missing import Mathlib.Tactic.Monotonicity?

I suppose we didn't import mono at the time. I tried it now:
For the first mono it worked somewhat, although tauto and norm_num after it were necessary now and not before.
For the second case mono simplifies to something that is harder to prove than what needs to be done before.

I think the names are fine.

LGTM
maintainer merge


Better Optimization problem

Should be very straightforward to write. Probably ask for an Akaley function:
https://arxiv.org/pdf/1308.4008.pdf

We should add in BlackBoxOptim for global optimization, and constrained optimization by NLopt. JuMP can get a mention but I don't think this is the right audience?

Improved the optimization page. Now just needs solutions


RATIS-1081. Change NettyServerStreamRpc to write data to StateMachine.

See https://issues.apache.org/jira/browse/RATIS-1081

LGTM

LGTM. Just wait CI passed.

@szetszwo Thanks the patch, I have merged it. The failed ut looks unrelated to this pr. @amaliujia Thanks for review.

@runzhiwang and @amaliujia thanks for reviewing this.


Pipe Insulations category not supported

Please consider adding the Pipe Insulations Category to supported categories in the Revit connector.
The same reasoning applies as for Duct Insulations as mentioned here:
https://github.com/specklesystems/speckle-sharp/issues/1233

Apologies, it too us so long! It's in for 2.15.


javascript.options.wasm and uBlock Origin

Thorin reminder

[x] perf tags for WASM, ASM - https://github.com/ghacksuserjs/ghacks-user.js/commit/c1d6d81528917d102dd57eb00c74be6efb49dfc3

Original Post
uBlock Origin use WASM with version 1.17.4 and a official benchmark test exist too: https://raw.githack.com/gorhill/uBlock/master/docs/tests/hnset-benchmark.html
I don't know how much WASM is used, but maybe allow it again?
@gorhill maybe you can say anything about?
For my old system (Intel Q9550, 4GB DDR2 RAM, SATA 2 SSD) i got:

with WASM - creation:
Set-based x 950 ops/sec ±3.19% (56 runs sampled)
Regex-based x 685 ops/sec ±3.34% (47 runs sampled)
Trie-based (1st-gen) x 136 ops/sec ±3.34% (45 runs sampled)
Trie-based (2nd-gen) x 369 ops/sec ±1.91% (62 runs sampled)
Trie-based JS (3rd-gen) x 813 ops/sec ±1.05% (62 runs sampled)
Trie-based WASM (3rd-gen) x 985 ops/sec ±1.60% (61 runs sampled)

with WASM - lookup:

Set-based x 1,023 ops/sec ±1.23% (60 runs sampled)
Regex-based x 1,524 ops/sec ±0.62% (65 runs sampled)
Trie-based (1st-gen) x 4,671 ops/sec ±0.37% (28 runs sampled)
Trie-based JS (2nd-gen) x 3,860 ops/sec ±0.19% (24 runs sampled)
Trie-based WASM (2nd-gen) x 4,732 ops/sec ±0.35% (28 runs sampled)
Trie-based JS (3rd-gen) x 3,592 ops/sec ±0.24% (63 runs sampled)
Trie-based WASM (3rd-gen) x 4,389 ops/sec ±0.15% (26 runs sampled)

without WASM - creation:

Set-based x 962 ops/sec ±3.40% (56 runs sampled)
Regex-based x 692 ops/sec ±4.30% (55 runs sampled)
Trie-based (1st-gen) x 140 ops/sec ±3.31% (47 runs sampled)
Trie-based (2nd-gen) x 359 ops/sec ±2.83% (59 runs sampled)
Trie-based JS (3rd-gen) x 772 ops/sec ±1.61% (60 runs sampled)

without WASM - lookup:

Set-based x 1,040 ops/sec ±1.24% (61 runs sampled)
Regex-based x 1,594 ops/sec ±0.50% (13 runs sampled)
Trie-based (1st-gen) x 4,778 ops/sec ±0.15% (28 runs sampled)
Trie-based JS (2nd-gen) x 3,823 ops/sec ±0.19% (24 runs sampled)
Trie-based JS (3rd-gen) x 3,530 ops/sec ±0.29% (64 runs sampled)

Or is "javascript.options.wasm" only used for websites and not for addons?

Or is "javascript.options.wasm" only used for websites and not for addons?

It also controls WASM for extensions, I disable it when testing that the extension is properly falling back on JS version.
The results for "lookup" are the real important ones, as this is called multiple times for every network requests ("creation" is once when loading filter lists).
You should pretty much mind only the performance relative to the Set() flavor, as Set() is the reference implementation here. Even the JS version of any of the Trie improves a whole lot against the Set() version, which is what matters. WASM improves further, but if disabling wholly WASM is seen as beneficial, the JS version is already a big gain relative to Set().

I'm confused (as usual). On 1.17.4 with wasm disabled

With 1.17.4 and WASM disabled, it's "Trie-based JS (2nd-gen)". It's used to implement the domain= option in static network filters.

You are comparing HNTrie 2nd-gen JS with HNTrie 3rd-gen WASM, that is wrong. You have to compare against HNTrie 2nd-gen WASM -- 3rd-gen is dev build, not in 1.17.4.

sheesh.. now i'm really confused (i see now I mixed up the lines) .. can someone just post the lines to compare - it's doing my head in

2nd-gen does not support WASM for creation, so only lookup matters:
Trie-based JS (2nd-gen) x 3,860 ops/sec ±0.19% (24 runs sampled)
Trie-based WASM (2nd-gen) x 4,732 ops/sec ±0.35% (28 runs sampled)

Thanks. I edited the previous post with the right figures (I hope it did it right)
You're right about the perf from Set() to JS (and we should stress that I guess) .. I'm just trying to quantify OPs question about having wasm on or off. i.e not Set() to wasm, but the diff between JS to wasm because that's the real world diff to him.. and I think I'll stop there :)
beerisgood :beer: you satisfied with all that?

Yeah i think my question is solved now and we can leave wasm support disabled ATM.
Thanks gorhill & Thorin-Oakenpants !
I leave the issue open for further changes but feel free to close it

FYI: https://github.com/EFForg/https-everywhere/issues/17143  @gorhill


django 2.2.12

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Thanks for getting the LTS branch going!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

travis ppc fail was:
docker: write /var/lib/docker/tmp/GetImageBlob432932299: no space left on device.

not sure what to do about this: apparently there's a way to ask for it to be done on azure...

@conda-forge-admin, please restart ci

thanks a lot @bollwyvl :+1:


Resolve internal issue #494: Implement matrix set via fold

oh, this is a nice use of right_assign!


We should use mypy for better reliability and security

Mypy is a static type checker for python. I think we should adopt it in securitas because it will detect a whole category of bugs for us, and thus improve reliability of the app.
Mypy has been used successfully in parts of bodhi, and works best when all the source code adopts it (as opposed to just parts of it). For this reason, I think it's best to introduce it as early as possible.

I'm almost always +1 on static typing, though I think "optional" (gradual) type checkers like mypy come with their own class of problems. Somewhat amusingly, Mypy claims to have a "Powerful type system" on its landing page, yet lacks some of the most basic constructions in all of type theory (such as closed sum types).
Although I love static typing and study type theory, logic, and category theory as a hobby, I'm +0 on this with the following considerations:

If we're okay with using static typing, as you said, I'd want to use it everywhere. If we make exceptions, we immediately lose 100% of the benefits. This means avoiding escape hatches such as the top (⊤) type (Any), type casting (unsound), etc. This takes a lot of social commitment to uphold and is particularly hard in a language like Python where people are not used to working with type systems.

I'd almost suggest that if we are going to do that, we should just look at using a language that was built around types from the ground up (Haskell or Ocaml, for example), rather than using a language which has tacked them on later. The advantage is all sorts of extra safety and type-level features. The disadvantage (and why I didn't write Securitas in Haskell -- my go-to language of choice) is that nobody on the team knows the language.

Basically I won't whine if we decide to use a tacked on static type system, but I will whine if we use a tacked on type system "except for this file" or "except for this function" or "except for this line" or "except for this type-cast". If we do this, I'd want to see us go all in on it. Otherwise it's just theater and cruft.

I think I understand. However using mypy in parts of the bodhi code did discover some bugs that were lurking and not covered by unit tests, so even if it does not provide as much benefit as using it everywhere, it is not entirely useless either, no?
I wonder what the rest of the team thinks, what the experiences are with static typing in python, if the benefits are obvious enough to everyone that we want to commit to this.

System to help detect bugs before they occur. Prob doesn't make sense to after, alot of work - back to code. Could of done this first - lessons learned.


Recogniser doesn't work in other dialogues except "Greeting".

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
What package version of the SDK are you using.
4.15.2
Describe the bug
Give a clear and concise description of what the bug is.
Recogniser is not called for user input in other dialogues than the initial one.
To Reproduce
Steps to reproduce the behaviour:

Clone this repository: https://github.com/Agodak/BFTest.git
Set up Language Understanding
Start the bot
When prompted for name say "Joe"
Bot asks for name again

Expected behaviour
After entering "Joe", Bot should say "Welcome Joe"
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
This happens for RegexRecogniser as well, not just the Luis one.
If you move the prompt for text from "Introduction" to "Greeting", then the bot behaves as expected.
The bot also behaves as expected if using SDK 4.15.0 or older.

Hi @Agodak
Thank you for raising this issue and providing a repro. I'm looking into this and will get back to you soon.

This fix for this has been merged, and will be released with 4.16.0


Adjusted the recipe as per Open-CE

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Part of https://github.com/open-ce/open-ce/issues/178
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

We need a license file in this one.

LICENSE file is there.


Fix #9336

This solves issue #9336. When the destroy method is called on a tooltip, the instance of the tooltip is not fully removed. Instead, it causes console errors and leaves behind tooltip-specific classes and attributes.
This commit:

Corrects a typo (.zf.tootip to .zf.tooltip) that was preventing the event handler from properly being removed from the tooltip
Removes all tooltip-specific classes, including .has-tip, .top, .right, and .left
Removes all tooltip-specific attributes including aria-describedby, aria-haspopup, data-disable-hover, data-resize, data-toggle, data-tooltip, and data-yeti-box

awesome, thank you!


Fix TrackBass not updating current time after seek

Fixes https://github.com/ppy/osu/issues/12541
When seeks are performed in-line, there's a bit of an expectation that the resultant time is updated immediately rather than in the next frame.
This is also an issue with Play() and Stop(), but I'll be making an issue for those to be tackled later - they're a bit involved. (https://github.com/ppy/osu-framework/issues/4396)

I have this really strange hunch that we tried this before and inadvertently broken something which was relying on the current behaviour... but I can't seem to find a paper trail so it may have been a different scenario.
Going to get this in and wait for any potential regressions.


Build Timeout while building a huge software, without errors in the console.

Krita project fails to build because of a timeout, it can go to around 30% and then the systems kills the build.
https://lgtm.com/projects/g/KDE/krita/logs/languages/lang:cpp

Hi @tcanabrava,
Thanks for your post
Unfortunately, the build & analysis servers on LGTM.com have a strict timeout of 3 hours to run the build & queries, and by our best estimate, on the current hardware that's provisioned for LGTM.com, this task will likely take more than 15 hours. (Note that this restriction does not apply to LGTM Enterprise, or to QL itself).
There's a few reasons that we have have this restriction, among which include wanting to have all builds & analyses run in a time that's reasonably fast enough so that it can be done at code review time (so automated code review can be enabled), and to avoid a small number of projects monopolizing resources.
This is something that we're aware of, and also affects other large popular open-source projects such as firefox and chromium. We don't have any plans to change this restriction i the short term however, and are instead focusing our efforts around improving this situation on speeding up QL itself.
If you want to explore the options of using LGTM Enterprise or QL locally for this, please don't hesitate to get in touch via email<EMAIL_ADDRESS>or open up a new discussion thread on our forums. (Issues for this repository are primarily for reporting and tracking False Positives, or problems with QL itself. As this is an LGTM matter and not about QL, it's better located on the forums).
For now I'm going to close this issue, but like I said feel free to reach out if you'd like to continue the conversation further.
Cheers,
Sam.


Evening out branches

Docs Build status updates of commit a54e63c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

DocsLegal/docfx.json
:white_check_mark:Succeeded

[Warning] Use provisioned locale es-MX for docset intune instead of locale en-us in publish configuration
[Warning] No file found, nothing will be generated. Please make sure docfx.json is correctly configured.
[Warning] No content file found. Please make sure the content section of docfx.json is correctly configured.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Mat/Pat - Form Validation and additional logic for parental leave allowance

Parental Leave allowance

Mandatory field
If taking mat leave AND the option selected is not the same as the option in mat leave then
- show form validation error saying Your selection must be the same for both parental and maternity leave
(Update May 5) If "I do not want to claim allowance is selected" then none of the following allowance screens should be shown

Parental leave - top up allowance type, Parental leave - top up allowance dates, Deferred allowance dates

Parental leave allowance info

covered in #912
Add info popup that has instructions for calculating basic pay (updated April 12)

Instructions to calculate gross basic pay
In your paystub, ADD all of the line items present in your pay stub from the following list. It is okay if you do not have all of the line items listed below in your pay stub, just add the ones that are present.

Regular Hours Paid Earnings
Salary Protection
Classification Adjustment
Temporary Market Adjustment (AMA Market Adjustment)

Add info popup that shows screenshot of EI estimation screen to help people find where the estimate is Maternity & Parental leave EI Estimate Popup
~- Add tooltip for additional earnings to be decided~ Not needed, updated Apr 12

Parental Leave Allowance Selection

"Which top-up allowance option will you choose?"

Mandatory field

If an applicant is taking extended leave and their leave length is not the full leave i.e 61 (if taking mat leave) or 63 (if not taking mat leave) then show alert warning (yellow box) saying

Some employees choose standard allowance with extended leave to maximize their earnings during their leave. Learn more in the information box below

Parental Leave Allowance Date Selection

"When do you want to receive your top-up allowance?"

Mandatory fields
Must be valid dates
Start and end dates must be within the start and end dates of the parental leave
After dates are input, the info box should show the type of leave, number of weeks and start & end dates selected.
Form validation for number of weeks

If taking standard leave, number of weeks should not exceed 35 weeks
If taking extended leave, number of weeks should not exceed 61 weeks
Change validation error message according to the leave type You cannot claim more than 35 weeks of allowance

just need popup copy and image to complete.

I will need to connect with Andrew when he returns to discuss more info about this ticket. The logic does not seem to work when we confirm if both the Maternal and Parental leave options are not the same.  Ayush indicated that this test was not a pass either.  Chris

Chris caught that the error is only for deferring allowance and now for consistency across all choices. @fazil-ey do you want a different error message for picking yes receive top up allowance in one leave and picking no top up allowance in the other leave?

Sorry for the late response @Andrew-Vargas-bcgov  It should be consistent for all options!

Iman to connect with Bhumin to continue work - there might be some technical complexity.

@Stella-Archer
This is ready for testing on TEST. The popup issue should be working on the Mat/Pat form.

Tested in TEST environment ✅
Parental leave allowance:
Private Zenhub Image
Parental leave allowance info:
Private Zenhub Image
Parental Leave Allowance Selection:
Private Zenhub Image
Parental Leave Allowance Date Selection:
Private Zenhub Image

This was not implemented, splitting into another ticket #1315

If an applicant is taking extended leave and their leave length is not the full leave i.e 61 (if taking mat leave) or 63 (if not taking mat leave) then show alert warning (yellow box) saying
Some employees choose standard allowance with extended leave to maximize their earnings during their leave. Learn more in the information box below

Allowance popup functionally implemented, but content for EI is not implemented Splitting into #1316

Add info popup that shows screenshot of EI estimation screen to help people find where the estimate is Maternity & Parental leave EI Estimate Popup

We want to add start and end dates of the leave to the allowance dates page as per the v3 designs. so splitting to another ticket


Log entries associated to wrong logName

Hi,
I have a system where I upload bunches of logs in parallel. I am basically following the example from the README and use one shared Logging instance with multiple log = logging.log(logName) Log instances with different logNames.
I am getting cases where overlapping log.write(manyLogEntries) lead to entries uploaded with Log instance named log-A ending up in the logs of Log instance log-B. For validation, I am additionally adding the logName to metadata.labels. The resulting log entries correctly carry the metadata label log-A, but their logName is log-B.
A and B are just examples, it's actually many more instances and the misassociations seem to happen "randomly" between the instances. I was unsuccessful in reproducing this with multiple approaches outside my production system, even though the same code is used. It might be related to the large volume of logs being handled by the production system.
Is anybody aware of such a problem? Are multiple parallel Log instances supported?

@protyposis thank you for reporting. I have been testing this rather extensively, but haven't been able to reproduce. Here's a script I put together to try to create a level of chaos to introduce the error. (Note, it's required to update to @google-cloud/logging v9, released today).
Is there anything else you can think of to add?
const assert = require('assert');
const Logging = require('@google-cloud/logging').Logging;
const v4 = require('uuid').v4;

const TESTS_PREFIX = 'issue-943';
const TIME_TEST_STARTED = new Date().toISOString();

const NUM_LOGS_TO_CREATE = 50;
const NUM_ENTRIES_TO_WRITE = 100000;
const FLUSH_AFTER_NUM_LOGS_FILLED = NUM_LOGS_TO_CREATE / 10;
const NUM_WRITES_TO_MAKE = 50;
const WRITE_CONSISTENCY_DELAY_MS = 10000;

const logging = new Logging();

function generateName() {
  return `${TESTS_PREFIX}-${Date.now()}-${v4().split('-').pop()}`;
}

run();

async function run() {
  const logNamesCreated = [];

  function validateEntriesFromLogCallback(log, callback) {
    let numEntriesReceived = 0;

    setTimeout(pollForMessages, WRITE_CONSISTENCY_DELAY_MS, {
      autoPaginate: false,
      filter: `timestamp > "${TIME_TEST_STARTED}"`,
      pageSize: 1000,
    });

    function pollForMessages(query) {
      log.getEntries(query, (err, entries, nextQuery) => {
        if (err) {
          callback(err);
          return;
        }

        assert(entries.every(e => e.data.originLog === log.name));

        numEntriesReceived += entries.length;
        console.log(`${numEntriesReceived}/${NUM_ENTRIES_TO_WRITE} entries received`);

        if (nextQuery) {
          setTimeout(pollForMessages, WRITE_CONSISTENCY_DELAY_MS, nextQuery);
          return;
        } else {
          if (numEntriesReceived < NUM_ENTRIES_TO_WRITE) {
            callback(new Error(`Not enough entries received`));
            return;
          }
        }

        callback();
      });
    }
  }

  function validateEntriesFromLog(log) {
    return new Promise((res, rej) => {
      validateEntriesFromLogCallback(log, (err, entries) => {
        if (err) {
          rej(err);
          return;
        }
        res(entries);
      });
    });
  }

  const logAndEntrySets = [];

  let numLogsCreated = 0;
  while (numLogsCreated++ < NUM_LOGS_TO_CREATE) {
    const logName = generateName();
    logNamesCreated.push(logName);
    const log = logging.log(logName);
    log.shortName = `log #${numLogsCreated}`;
    logAndEntrySets.push({log, entries: []});
  }

  let numLogsFilled = 0;
  while (numLogsFilled < NUM_LOGS_TO_CREATE) {
    const logAndEntrySetBatch = logAndEntrySets.splice(0, FLUSH_AFTER_NUM_LOGS_FILLED);

    for (const {log, entries} of logAndEntrySetBatch) {
      let numEntriesWritten = 0;
      while (numEntriesWritten++ < NUM_ENTRIES_TO_WRITE) {
        entries.push(log.entry({originLog: log.name}));
      }
    }

    console.log('Flushing logs...');
    await writeLogs(logAndEntrySetBatch);
    numLogsFilled += logAndEntrySetBatch.length;
  }

  async function writeLogs(logAndEntrySets) {
    const numEntriesPerWrite = NUM_ENTRIES_TO_WRITE / NUM_WRITES_TO_MAKE;
    let numWrites = 0;

    while (numWrites < NUM_WRITES_TO_MAKE) {
      const numEntriesWritten = numWrites * numEntriesPerWrite;
      for (const {log, entries} of logAndEntrySets) {
        console.log(
          `${log.shortName} writing ${numEntriesWritten}-${
            numEntriesWritten + numEntriesPerWrite
          }/${NUM_ENTRIES_TO_WRITE} entries`
        );
        await log.write(entries.splice(0, numEntriesPerWrite));
      }
      numWrites++;
    }
  }

  console.log('Validating logs...');
  let logNamesProcessed = 0;
  for (const logName of logNamesCreated) {
    console.log(`Validating log #${++logNamesProcessed}: ${logName}`);
    const log = logging.log(logName);
    await validateEntriesFromLog(log);
  }
}

Thank you for looking into this. I have also attempted to create multiple different repro cases and wasn't able to reproduce artificially, while still being able to reproduce in the production system. Your script does about the same what I did.
Unfortunately I failed to record the exact library version (and the versions of its dependencies) with which we have observed this issue. It was definitely within the range of 8.0.1 - 8.0.9. I tried my repro cases with all these versions and couldn't reproduce with any.
Interestingly, since we updated to 8.1.1 due to issue #947, we weren't able to reproduce this any more. It might be a coincidence because it only happened "randomly" anyway, but there's a chance that it is fixed. Are you aware of any changes in this library or it's dependencies that might have fixes this?
Since it seems our way forward is unclear, and given the chance that this is fixed, I suggest we close this issue and I'll keep monitoring the situation and reopen if it happens again?


TiCDC prints lots of error log

What did you do?
when replicated lots of tables(1w+) and pd schedule region frequency(don't know why). TiCDC prints lots of error log, such as
[ERROR] [client.go:452] ["check tikv version failed"] [error="[CDC:ErrGetAllStoresFailed]rpc error: code = Canceled desc = context canceled"]
which create 300M log file every 5 minute.

What did you expect to see?
a clear error log.
reduce the times of check tikv version, maybe we can cache the store's version. when new stream created. only first check is enough.
What did you see instead?
too many errors [ERROR] [client.go:452] ["check tikv version failed"] [error="[CDC:ErrGetAllStoresFailed]rpc error: code = Canceled desc = context canceled"]
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
N/A

TiCDC version (execute cdc version):
master

This issue does not appear for a long time. Reopen it if the same issue appear again.

/close


[FAB-11334] Adds a function to purge a ledger's transient storage

Type of change

New feature

Description
This introduces a transientstore.Delete(ledgerID) routine to assist with the bookkeeping while unjoining a peer from a channel.  Before removing the transient storage, the store is marked as UNDER_DELETION in a system leveldb, providing an opportunity to recover from a failed deletion at the next peer initialization.
Signed-off-by: Josh Kneubuhl<EMAIL_ADDRESS>Additional details
Related issues

FAB-11334

Resolves #2786

OK.  I think this one is a wrap.  I agree we should look to find a wider grain / common lock to handle "peer is running" concurrently with CLI activities requiring the peer to be shut down.


ZwSetInformationFile  doesn't mention FileDispositionInformationEx

The page for FILE_DISPOSITION_INFORMATION_EX now links to ZwSetInformationFile as expected as noted in issue #352 :
https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/ntddk/ns-ntddk-_file_disposition_information_ex
However, that page doesn't mention FileDispositionInformationEx as one of the possible FileInformationClass values, and it should as far as I can tell.

This is a little interesting - there are actually 2 issues here.
First, the FILE_DISPOSITION_INFORMATION_EX has two links to "ZwSetInformationFile". One actually points to the page for ZwSetInformationFile, while the other wrongly points to the page for NtSetInformationFile.
Second, I didn't realize that we had separate doc pages for ZwSetInformationFile and NtSetInformationFile (and seemingly we do for every Zw/Nt pair, which is really unfortunate IMO), and so @tedhudek and I only added the discussion of FileDispositionInformationEx to the NtSetInformationFile page.
It should be trivial to fix both issues, but it's above my pay grade whether to dedupe the Zw/Nt in general.

Thanks for the internal PR @metathinker.  Results will be live within an hour or so.  Regarding Zw/Nt, this page and children describes the issue more in depth.  The ref docs are built using header reflection, so we're tied for now to the fact that these have separate incarnations in headers.


samples/pop_pop_win: enable difficulty in chrome app

The web version of PPW uses URL fragments to control difficulty. This is not possible in a chrome app
See samples/pop_pop_win/chrome_app/index.html
To test: pub build chrome_app then load the unpackaged app in build/chrome_app in Chrome

This issue was moved to dart-lang/sample-pop_pop_win#38


Why we can't open DXF file with 'DxfDocument.Load'.

When use the 'DxfDocument.Load', we can't open the DXF file and return 'NULL'.
The compressed of DXF file as:
DXF.zip

Besides, the source code  can open of the  file of DXF from downloading in the https://github.com/haplokuon/netDxf, but it cann't be opened when downloading the NuGet  from Visual Studio 2019.

I do not publish anything outside Github. The packages at Nuget are not mine, you will have to contact its actual owner.


add 404/500/400 error pages

The file public/files/static.css is lifted and modified from Accelerated Claims. It is so big because it contains both bold and regular weights of New Transport font encoded in base64. I've added this file to the CodeClimate ignore list, because i) it works, and ii) we have better things to do than track down all the duplications and style transgressions in that file.
Screenshots
This is how they look right now - this copy has been lifted from Accelerated Claims and tweaked a little.
404

500

400

The copy should be easy to update by @joshlow or anyone else... 😄

@axemonkey - not going to overthink these ones. :) Here's the suggested copy. ".. Help with fees homepage..." is the link in each case.
[404]
Page not found
Sorry, this page does not exist.

If you entered a web address, please check it’s correct.
Please go to the Help with fees homepage to find out more or apply.
[500]
Server error
Sorry, something went wrong.

Please return to the Help with fees homepage and try again.
[400]
Bad request
Sorry, an error has occurred.

Please return to the Help with fees homepage and try again.


Increase zoom level before displaying minor lines?

I think map would look less cluttered if you moved minor lines to z10 or 11.
At z9 its just a big blob.

I'm not actually taking minor_line into consideration here, I do it all by voltage. I'm going to bump the minimum zoom level for low/undefined voltages down by one click and we'll see how that improves things. (I don't have any way of clearing the cache at the moment so it'll take a few days to take effect.)

Hi Russss
There is a whole pull request to review regarding this
We also miss transformers, switches, portals...


No intellisense support

I followed the instructions on the website, but I don't get full cake support.
environment

linux ubuntu 20.04
dotnet 6.0.302 (latest)
vscode 1.70.0 (latest)
c# extension 1.25.0 (latest)
cake extension 2.0.0 (latest)

repro

dotnet new console --output /tmp/cake
code /tmp/cake
install c# extension, cake extension
reload
command: "Cake: install to workspace", accept all defaults
command: "Cake: update intellisense support"
reload
open build.cake

result:

no intellisense
red error squiggles under all cake functions, e.g. Setup, Teardown, Task, etc. - shows "The name 'Teardown' does not exist in the current context"
works: tasks in command palette
works: codelens items
works: snippets

logs:

no errors in Cake Workspace
no errors in OmniSharp Log and no messages related to cake, but it does show this when I open build.cake:[warn]: OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService
        No document found. File: /tmp/cake/build.cake.
[info]: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService
        Could not find document for file /tmp/cake/build.cake

notes:

I ran dotnet tool install --global cake.tool
I also uninstalled and reinstalled all the extensions, without success
I didn't change any of the extension's options in .vscode/settings.json
I also tried this in an omnisharp.json file in the workspace root:{
  "cake": {
    "enabled": true,
    "bakeryPath": "~/.vscode/extensions/cake-build.cake-vscode-2.0.0/Cake.Bakery/tools/Cake.Bakery.exe"
  }
}

Another things I noticed is in other issues people refer to something like this;
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/foo/project'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Found 1 Cake files.

But I don't have anything like that. There is no CakeProjectSystem in the log, it's as if omnisharp doesn't know about cake.
I also searched for OmniSharp.Cake.dll as mentioned in the docs but couldn't find it.
I reinstalled the c# extension without success.

While cake-vscode provides some help in setting things up, cake-vscode is not responsible for providing language support (error-detection/compilation, auto-complete, F12-jump-do-definition...) for Cake. This is entirely based on OmniSharp (specifically OmniSharp.Cake) and Cake Bakery.
I'm closing this issue. I have added some explanation in the discussion, as well as the SO-question.


Release for scala 2.13.7

Could you publish a new version because the version of semanticdb used by the release 0.2.5 is not available in 2.13.7. I've seen that Scala-Stewart updated the dependency to .31 which should be fine for scala 2.13.7
Thanks

0.2.6 on its way to Maven Central.
Sorry for the delayed answer.


[e2e]: generic schedule main multi-uses slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6464671698
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Oct 10 04:25:55 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6477919734
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Oct 11 04:25:16 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6491198397
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Oct 12 04:26:21 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6503966929
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Oct 13 04:26:20 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6515521836
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Sat Oct 14 04:25:00 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6521921575
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Sun Oct 15 04:25:31 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6528952964
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Mon Oct 16 04:26:48 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/6542475930
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.schedule.main.multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Oct 17 04:55:42 UTC 2023
Tests are passing now. Closing this issue.


Update scio-core, scio-test to 0.12.3

Updates

com.spotify:scio-core
com.spotify:scio-test

from 0.10.4 to 0.12.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.spotify" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.spotify" }
}]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #241.


I want to add a time variable in output_directory, but I do not know how to add it.

I want to add a time variable in output_directory, but I do not know how to add it.I read all the documents, there is no explanation. Have this function?

What is the output_directory you refer to? Part of a built-in action?

Yes, in the build_app action

You didn't share your fastlane env output, so I can only guess here, that you have a Fastfile. If you do, use the following:
build_app(output_directory: "#{Time.now.to_i}_build/")

which will use "1518445001_build/" as a output directory 👍

Closing this for now as there hasn't been any response and @KrauseFx answer is 💯


[stable/keycloak] add ability to define volumeClaimTemplates on StatefulSet

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
Which chart: stable/keycloak
It's possible to define extraVolumeMounts and extraVolumes to point to an existing PVC.
If you want to scale the StatefulSet then you would need to define volumeClaimTemplates instead of the extraVolumes
spec:
  replicas: 2
  volumeClaimTemplates:
  - metadata:
      name: keycloak-vol
    spec:
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi
      storageClassName: rbd
  template:
      containers:
          volumeMounts:
            - name: keycloak-vol
              mountPath: /opt/jboss/keycloak/standalone/data

replicas won't work with h2 as far as I can tell so moot.


Review ALTER table name in db usage to update new table metadata

From https://openmetadata.slack.com/archives/C02AZGN0WKY/p1680671001230059
Consider the following scenario:

We have a table A with metadata
We run ALTER TABLE A RENAME TO B
In the next ingestion, Table A will be deleted and Table B ingested without A's metadata

In the query Usage we can identify these statements, and update B's metadata from A

Thanks for fast feedbacks!
In addition, I think it will be cool if B contains A's change event histories in above case,
(or it will be sufficient to leave any record in B's history, that tells renamed from A)


Feature: Add IncludeDefinitions functionality to the evaluator tool

This would allow the AI to access definitions you've made in the main kernel so it doesn't need to rewrite the code to generate them in its kernel.

Added in #608


⚠ Bofrost.at has degraded performance

In 3079a19, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1930 ms

Resolved: Bofrost.at performance has improved in 0118ad2.


build: add workaround for cmake on Windows

Fixes #55.
This adds some detection of platform and build target configuration to build.rs in order to workaround an issue with cmake and MSVC.

updated, PTAL @ghedo


Correct replacement of

I have the following definition of a method in generic base controller
public class ControllerBase<T, S> : ControllerBase
        where T : Entity
        where S : IService<T>
{
        /// <summary>
        /// Updates existing <typeparamref name="T"/>
        /// </summary>
        /// <param name="id">Entity id</param>
        /// <param name="value">Entity detailes</param>
        [HttpPut("{id}")]
        [ProducesResponseType(StatusCodes.Status200OK)]
        [ProducesResponseType(StatusCodes.Status400BadRequest)]
        [ProducesResponseType(StatusCodes.Status404NotFound)]
        public async ValueTask<ActionResult> Put(string id, [FromBody] T value)
        {
        }
}

When I look the hint to it, I see T as a link and can navigate to class definition in VS2019
Then I inherit it in the implementation controller, that I use for WebAPI and want swagger replace template type to the  certain implementation type to show it's name in swagger UI.
e.g. I implement controller as
public class EmployeesController : ControllerBase<Employee, IEmployeeService>{}
so I want to see
Updates existing Employee
in the UI

Swashbuckle only supports a basic subset of the XML comments, specifically the ones described here


Deprecate CGLIB proxy factory

It's unmaintained and does not work with JDK 17.
https://github.com/cglib/cglib
Users should use Javassist instead.

Coverage remained the same at 87.224% when pulling 1db126ea93d05359c2bc11e730fe7e5a5a17c2bb on harawata:deprecate-cglib into a3576e62f372e93528ea537df2b8435bdb064194 on mybatis:master.

@hazendaz @kazuki43zoo
Any concern?

@harawata Sounds good.  We may want to consider building support for byte buddy since following cglib notes to use that but given current code support this makes sense.

Thanks!


Add versioning to the Docs

Closes #303
Code Changes

[x] update the docs workflow to maintain versions
[x] ON PROD use mike delete --all --push to give us a clean slate and then mike deploy --push --update-aliases 1.3.1 stable to get us started before merging

Steps to Confirm

[ ] peep ethyca.github.io/fidescls

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
[ ] Documentation Updated

Description Of Changes
This change allows us to maintain multiple versions of our docs, with a primary stable branch that gets updated when we cut releases, a dev branch that gets updated on every push to main, and all of the past versions are kept as well

running into some trouble here because I'm not sure how to test it in a low-impact way...

found some helpful examples here: https://github.com/Azure/iotedge-lorawan-starterkit/tree/docs/main/.github/workflows

@iamkelllly do you want me to go ahead and stop pushing "dirty" versions to docker? i can update the workflow file in this PR so that it will only send actual release version to dockerhub

mirror the changes made in this PR: https://github.com/ethyca/fidescls/pull/24

forgive me 🙏 I had to touch prod for this change so I did it late on a Saturday night. Everything looks good so I'm unilaterally merging since I've already production


Add Initial Setup

From Journal Entry 09

Use FEN?

Should use FEN. But people may not understand it right now. Maybe later?

For now, SetupBoard() should suffice.

Add unit tests, maybe?

Also look at #57


Add Member UI issues

Rancher versions: 2.0 master 1/21
Results:

[x] Take out the "$TYPE" text and replace it with Cluster/Project text

[x] Owner should be on top

[x] Clicking on Save without adding user causes you to get stuck in Saving - make user field required.

[x] Sorting by user is not working

[x] Search is ignoring spaces

Version - 2.0 master 2/1
Verified fixed


🌱 [bundle] ArgoCD

Use argoCD to manage continuous deployment / helm chart installation (and update)
Is your feature request related to a problem? Please describe.

It's a future request
Describe the solution you'd like

I would like to install argoCD as bundle
Describe alternatives you've considered

Use existing fluxCD
Additional context

/

Fixed by https://github.com/kairos-io/community-bundles/pull/71


Surprising "error description" when denying approval

Describe the bug^Wissue
When POSTing to the authorize "endpoint" with an empty scope list (i.e., denying approval), it responds with a redirection to the redirect uri, setting the "error" parameter to "access_denied" (as expected). However, the "error_description" is set to "OAuth 2.0 Parameter: client_id", which does not really reflect the issue and is not helpful while analyzing the any failures.
Expected behavior
A better error_description would be preferable. The (old) spring-security-oauth2 server replied with an error_description "User denied access".
Sample
Any of the sample projects shows this behavior.
Code is in OAuth2AuthorizationCodeRequestAuthenticationProvider.java
Verified with spring-authorization-server 0.2.2
Thanks :)

@bnutzer I agree a better error description would be something like "User denied access", however, the expectation is that the client application would consume the "error" parameter and display its own custom error message.
Alternatively, the returned OAuth 2.0 Error can also be overridden via a custom AuthenticationFailureHandler using this custom configuration:
OAuth2AuthorizationServerConfigurer<HttpSecurity> authorizationServerConfigurer =
		new OAuth2AuthorizationServerConfigurer<>();
authorizationServerConfigurer
		.authorizationEndpoint(authorizationEndpoint ->
				authorizationEndpoint.errorResponseHandler(...)

Also notice that ALL OAuth 2.0 error descriptions generated by OAuth2AuthorizationCodeRequestAuthenticationProvider default to "OAuth 2.0 Parameter: [parameterName]", not just the "access_denied" error flow.
FYI, it's best practice NOT to reveal too much information related to the error as this can provide "hints" to the caller, that may be malicious, and hence allow them to navigate the next call.
I'm going to close this as works-as-designed.