Add support for Qualities - specifically access control qualities

Is this still an issue? What are access control qualities?

@brdandu Various qualities are described in the section 7.7 of the main matter spec (regarding the quality column of attributes)

Access control bits are all supported already, fwiw.

What's missing is for attributes to track whether they can be part of a scene.

That should be accomplished by the Quality column if I understood the spec correctly, so shouldn't the other Quality flags (X, N, F, S,P,C, I and !Q) be supported as well?

X is supported.  N is supported.  What would "supported" mean for F?  P does not do anything in Matter. I does not do anything in Matter, really; it's there in Zigbee for the Basic cluster, which is not part of Matter.  Device types are not really well-represented in the ZAP XML, so !Q has no way to be represented right now.

It seems there was a misunderstanding on my part, I assumed a "quality" field was supposed to be implemented in zap. I agree that currently Scene is the attribute that would need support in the immediate as it should be implemented for matter 1.2.

Trying to connect the pieces together here, I see that the xml has some quality related updates for attributes and struct fields with a scene attribute that is just a boolean. Is there more to this apart from an attribute's scene being true/false? Can anyone point me to an example use case to wrap my head around this?

@lpbeliveau-silabs @bzbarsky-apple can this be resolved with the solution provided in https://github.com/project-chip/zap/issues/980 ?

This has been resolved in https://github.com/project-chip/zap/issues/980


CAM KP does not respond to any of ICEES KG-derived input CURIES

This issue is to report that CAM KP does not respond to any of the ICEES KG-derived CURIES in this sheet and also appended below. Is this expected behavior? Is this a normalization issue? Is this something else?
ICEES input CURIES for MVP2 queries ExposuresProvider/cam-kp-api#81 and ExposuresProvider/cam-kp-api#82 |
ICEES query: What chemicals are associated with primary ciliary dyskinesia? |
[Jupyter notebook](https://colab.research.google.com/drive/1CdO0XtUddVzt5bRzlcTs8tW0SFc2ggkP#scrollTo=ZVvv2zGGsr-4&uniqifier=1)

ENTITIES_OF_INTEREST
'PUBCHEM.COMPOUND:5865',            # Prednisone |
'CHEMBL.COMPOUND:CHEMBL1256818',    # Dextromethorphan hydrobromide |
'PUBCHEM.COMPOUND:165363555',       # Trifacta |
"HMDB:HMDB0252416",                 # Fluticasone |
"PUBCHEM.COMPOUND:123600",          # Levalbuterol |
"HMDB:HMDB0242500",                 # Budesonide |
"CHEBI:5147",                       # Formoterol |
"CHEMBL.COMPOUND:CHEMBL158"         # Aztreonam |
"PUBCHEM.COMPOUND:145068"           # Nitric oxide |
"PUBCHEM.COMPOUND:281",             # Carbon monoxide |

Thanks for this identifiers! I've added these identifiers to the brand new Automat-CAM-KP test suite (https://github.com/ExposuresProvider/cam-pipeline/pull/111), and here are the results I have:

CURIE
Normalized to
How many unique CURIEs is this connected to in Automat-CAM-KP?

PUBCHEM.COMPOUND:5865
Normalized
30

CHEMBL.COMPOUND:CHEMBL1256818
PUBCHEM.COMPOUND:5462351
None

PUBCHEM.COMPOUND:165363555
Normalized
None

HMDB:HMDB0252416
PUBCHEM.COMPOUND:2462
None

PUBCHEM.COMPOUND:123600
Normalized
None

HMDB:HMDB0242500
PUBCHEM.COMPOUND:2462
None

CHEBI:5147
PUBCHEM.COMPOUND:3410
None

CHEMBL.COMPOUND:CHEMBL158
PUBCHEM.COMPOUND:5742832
9

PUBCHEM.COMPOUND:145068
Normalized
258

PUBCHEM.COMPOUND:281
Normalized
64

@balhoff Do you have thoughts on figuring out how to plug in the gaps we see here in node coverage? I'm guessing we need new data sources.

Thanks, @gaurav! While we don't have a 1:1 match between CURIEs, the matches that we do have are representative, with two drugs and two chemical exposures, and will allow us to move this effort along.

This Swagger example query runs successfully, but it returns 0 results. If I replace the input CURIES with PUBCHEM.COMPOUND:5865 from the table above, the query also runs successfully, but it returns 0 results. I think the Automat example queries are standardized and not tailored to the underlying KGs, so perhaps you can send me an example query that returns results from CAM KP? Thanks!
{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "categories": [
            "biolink:ChemicalEntity"
          ],
          "ids": [
            "CHEMBL.COMPOUND:CHEMBL3234626",
            "CHEMBL.COMPOUND:CHEMBL3234633"
          ]
        },
        "n1": {
          "categories": [
            "biolink:GeneOrGeneProduct"
          ],
          "ids": [
            "NCBIGene:2099"
          ]
        }
      },
      "edges": {
        "e01": {
          "subject": "n0",
          "object": "n1",
          "predicates": [
            "biolink:affects"
          ],
          "qualifier_constraints": [
            {
              "qualifier_set": [
                {
                  "qualifier_type_id": "biolink:object_aspect_qualifier",
                  "qualifier_value": "activity"
                },
                {
                  "qualifier_type_id": "biolink:object_direction_qualifier",
                  "qualifier_value": "increased"
                },
                {
                  "qualifier_type_id": "biolink:qualified_predicate",
                  "qualifier_value": "biolink:causes"
                }
              ]
            }
          ]
        }
      }
    }
  },
  "workflow": [
    {
      "id": "lookup"
    }
  ]
}

Hi Kara! Sorry about the confusion: that Swagger example query can't currently be configured for individual platers, so we share a single Swagger with all the platers on Automat. That one isn't relevant to us, and has two main problems:

CAM-KP doesn't currently know about CHEMBL.COMPOUND:CHEMBL3234626 or CHEMBL.COMPOUND:CHEMBL3234633. We'd have to ingest new pathways to provide information on them. We do have information on NCBIGene:2099.
CAM-KP can't handle qualifiers until https://github.com/ExposuresProvider/cam-pipeline/pull/104 has been incorporated, which we're hoping to do really soon!

So the following query will work:
{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "categories": [
            "biolink:ChemicalEntity"
          ]
        },
        "n1": {
          "categories": [
            "biolink:GeneOrGeneProduct"
          ],
          "ids": [
            "NCBIGene:2099"
          ]
        }
      },
      "edges": {
        "e01": {
          "subject": "n0",
          "object": "n1",
          "predicates": [
            "biolink:affects"
          ]
        }
      }
    }
  },
  "workflow": [
    {
      "id": "lookup"
    }
  ]
}

No confusion, I was aware that the Swagger examples aren't really "examples" for most of the Automats, including cam-kp and icees-kp.

This query returns results when sent directly to automat-icees-kg at https://automat.renci.org/#/.
{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "categories": [
            "biolink:DiseaseOrPhenotypicFeature"
          ],
          "ids": [
            "MONDO:0009061"
          ]
        },
        "n1": {
          "categories": [
            "biolink:ChemicalEntity"
          ]
        }
      },
      "edges": {
        "e01": {
          "subject": "n0",
          "object": "n1",
          "predicates": [
            "biolink:correlated_with"
          ]
        }
      }
    }
  },
  "workflow": [
    {
      "id": "lookup"
    }
  ]
}

And this query returns responses when sent directly to automat-cam-kp at https://automat.renci.org/#/.
{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "categories": [
            "biolink:ChemicalEntity"
          ],
          "ids": [
            "PUBCHEM.COMPOUND:5865"
          ]
        },
        "n1": {
          "categories": [
            "biolink:GeneOrGeneProduct"
          ]
        }
      },
      "edges": {
        "e01": {
          "subject": "n0",
          "object": "n1",
          "predicates": [
            "biolink:affects"
          ]
        }
      }
    }
  },
  "workflow": [
    {
      "id": "lookup"
    }
  ]
}

But this query, while able to run successfully, returns an empty response when sent to WFR at https://translator-workflow-runner.renci.org/docs#/trapi/run_workflow_query_post.
{
    "workflow": [
        {
            "id": "lookup"
        },
        {
            "id":"score"
        }
    ],
    "message": {
        "query_graph": {
            "edges": {
                "e0": {
                    "predicates": [
                        "biolink:correlated_with"
                    ],
                    "subject": "n0",
                    "object": "n1",
                    "provided_by": {
                        "allowlist": [
                            "infores:automat-icees-kg"
                        ]
                    }
                },
                "e1": {
                    "subject": "n1",
                    "object": "n2",
                    "predicates": [
                        "biolink:affects"
                    ],
                    "provided_by": {
                        "allowlist": [
                            "infores:automat-cam-kp"
                        ]
                    }
                }
            },
            "nodes": {
                "n0": {
                    "ids": [
                        "MONDO:0009061"
                    ],
                    "is_set": false
                },
                "n1": {
                    "categories": [
                        "biolink:ChemicalEntity"
                    ],
                    "is_set": false
                },
                "n2": {
                    "categories": [
                        "biolink:GeneOrGeneProduct"
                    ],
                    "is_set": false
                }
            }
        }
    }
}

This comes from going through ARAs that have strict kp timeouts vs sending queries directly to kps. I also wasn't able to get any results from the WFR, but sending directly to Aragorn with an extended timeout returns a 16.6MB response. 12k results in total. ICEES-KG took 35 seconds to respond to the first hop (normal timeout is 10s) and returned 106 results, and then CAM-KP took 90 seconds to respond with the 12k results. If you want, I can share entire response.

Thanks, Max.
Given your findings, then the revised query below should run when sent to WFR and return results. However, while it runs successfully, it returns an empty KG.
{
    "workflow": [
        {
            "id": "lookup",
            "runner_parameters": {
                "allowlist": ["infores:aragorn"]
            }
        },
        {
            "id":"score"
        }
    ],
    "message": {
        "query_graph": {
            "edges": {
                "e0": {
                    "predicates": [
                        "biolink:correlated_with"
                    ],
                    "subject": "n0",
                    "object": "n1",
                    "provided_by": {
                        "allowlist": [
                            "infores:automat-icees-kg"
                        ]
                    }
                },
                "e1": {
                    "subject": "n1",
                    "object": "n2",
                    "predicates": [
                        "biolink:affects"
                    ],
                    "provided_by": {
                        "allowlist": [
                            "infores:automat-cam-kp"
                        ]
                    }
                }
            },
            "nodes": {
                "n0": {
                    "ids": [
                        "MONDO:0009061"
                    ],
                    "is_set": false
                },
                "n1": {
                    "categories": [
                        "biolink:ChemicalEntity"
                    ],
                    "is_set": false
                },
                "n2": {
                    "categories": [
                        "biolink:GeneOrGeneProduct"
                    ],
                    "is_set": false
                }
            }
        }
    }
}

Your query doesn't have the extended timeout that I'm able to set directly in Aragorn. So WFR is returning nothing because icees-kg is timed out on the first hop. This is a performance issue, and I'm only able to get results back because I can peek behind the curtain and turn some hidden knobs.

Oh, I see. That makes sense.
In that case, perhaps you can send me the full response?

Just so everyone is clear, the goal of this effort is three-fold:

Team science - more tightly couple icees-kg and cam-kp under Exposures Provider.
Scientific impact - leverage cam-kp to provide mechanistic insights into clinical observations derived from icees-kg (AOPs of scientific interest).
Translator MVP2 queries - contribute to Translator MVP2 queries by leveraging the CQS and targeting the clinical KPs in the first hop.

Also see this GitHub folder and slide 9 in this slide deck.

Per decision on 01.03.2024: Max will rerun the above queries with extended timeouts in ARAGORN and cache the results. Kara will then test.

From Meisha, 01/17/2024:

Title: Peptide Oxidation Leading to Hypertension
Description from the wiki:
Here we present the supporting information on an AOP describing how vascular endothelial peptide oxidation leads to hypertension via perturbation of endothelial nitric oxide (NO) bioavailability.  The molecular initiating event is oxidation of amino acid (AA) residues on critical peptides of the NO pathway, notably protein kinase B (AKT), guanosine triphosphate cyclohydrolase-1 (GTPCH-1), endothelial nitric oxide synthase (eNOS), and also the cellular ROS scavenger; glutathione.  Oxidation of the enzymic components of the pathway lead to reduced expression of the phosphorylated proteins, and protein loss via proteasomal degradation. Oxidation of reduced glutathione to GSSG promotes bonding of GSSG to critical AA residues on eNOS, and the reduced expression of GTPCH-1 reduces bioavailability of tetrahydrobiopterin (BH4), both of which lead to uncoupling of eNOS (reduced NO production, increased superoxide production).  The combination of these molecular events lead to reduced bioavailabilty of NO, which in turn reduces the potential for vasodilation and shifts the balance of vascular tone towards vasoconstriction.  Repeated perturbation of this pathway via chronic exposure to toxicants, ultimately increases vascular resistance and contributes towards the development of hypertension.

From Max, 02/05/2024: cam_kp_integration_response.json


FactBox Page (PageType = CardPart) with ShowAsTree and visible can not collapse

1. Describe the bug
On a FactBox Page (PageType = CardPart) with an Repeater with ShowAsTree = true and using the Visible Property you can not expand and collapse the tree this is always completely expand, can not be collapse.
2. To Reproduce
An example
page 50100 "MyFactBox"
{
    Caption = 'Demo Tree Fact Box';
    Editable = false;
    PageType = CardPart;
    ApplicationArea = All;
    InsertAllowed = false;
    RefreshOnActivate = true;
    ShowFilter = false;
    SourceTable = "Item Category";
    SourceTableView = SORTING("Presentation Order");
    UsageCategory = Administration;

     layout
    {
        area(content)
        {
            repeater(Control1)
            {
                IndentationColumn = Rec.Indentation;
                IndentationControls = "Code";
                ShowAsTree = true;
                ShowCaption = false;
                Visible = ShowControl1;
                field("Code"; Rec.Code)
                {
                     Editable = false;

                    trigger OnValidate()
                    begin
                        CurrPage.Update(false);
                    end;
                }
                field(Description; Rec.Description)
                {

                }
            }
        }

    }

    actions
    {
        area(Processing)
        {
              action(MyDemoSetVisibleTrue)
                    {
                        ApplicationArea = All;
                        Caption = 'Set Visible True';
                        Image = EndingText;
                         trigger OnAction()
                         begin
                            ShowControl1 := true;
                            CurrPage.Update();
                         end;

                    }
                      action(MyDemoSetVisibleFalse)
                    {
                        ApplicationArea = All;
                        Caption = 'Set Visible False';
                        Image = Alerts;
                         trigger OnAction()
                         begin
                            ShowControl1 := false;
                            CurrPage.Update();
                         end;

                    }

        }
    }

   trigger OnOpenPage()
    begin
        ShowControl1 := true;
    end;

    var
        ShowControl1: Boolean;
}

pageextension 50100 MyItemCard extends "Item Card"
{
    layout
    {
          addfirst(FactBoxes)
        {
            part(MyFactBox; MyFactBox)
            {
                ApplicationArea = All;
                ShowFilter = false;
            }
        }
    }
}

3. Expected behavior
The tree should be able to expand and collapse
4. Actual behavior
The tree is complete expand and can not collapse
5. Versions:
AL Language: 11.5.834620
Visual Studio Code: 1.80.1
Business Central: Version: W1 22.3 (Platform 22.0.58692.0 + Application 22.3.58346.58709)
No other extensions were enabled in recreating this issue.
Please remember to do the following:

[X] Search the issue repository to ensure you are reporting a new issue

[X] Reproduce the issue after disabling all extensions except the AL Language extension

[X] Simplify your code around the issue to better isolate the problem

Currently I have not received any feedback on the issue. The problem still exists with BC23 and Runtime 12.
Versions:
AL Language: v12.0.875970
Visual Studio Code: 1.82.2
Business Central: Version: Version: W1 23.0 (Platform 23.0.12789.0 + Application 23.0.12034.12816)
No other extensions were enabled in recreating this issue.

Hi @EmilDamsbo, can you please have a look on this?
I know that this issue is not in the scope of this repo but we dont know a better place and you created internal issues on similar web-client issues.

Thanks @EmilDamsbo !
We Reported this on Yammer but got no reaction from msft :(

Hi again @ChrisBlankDe and @Schnieringer, I spoke with the team responsible for the BC web client and we actually have a dedicated group for such discussion over at https://www.yammer.com/dynamicsnavdev/#/threads/inGroup?type=in_group&feedId=123146436608
I hope you have better luck reporting issues there in future, but you are also encouraged to log a support request for these types of issues.


::selection improvements

::selection improvements

Thanks, but I'd like to keep this style as-is.


[New Feature]: Add delays to the query timer

Checked for duplicates
Yes - I've already checked
Alternatives considered
No - I haven't considered
Related problems
No response
Describe the feature request
Current query timers (HLS & SLC) use the currentTime-60mins to retrieve the data from the DAAC. We want to add delays to start/end date times in query lambdas.

@hhlee445 @chrisjrd How does REVISION_START_DATETIME_MARGIN_MINS sound for the new env var name? This, in mins, will offset the revision start and start time to the left.

Also what should the default value be? 0 or something else?

I don't have a strong opinion on this. However the reasons I chose MARGIN are:

We already use that name pattern for temporal shift: TEMPORAL_START_DATETIME_MARGIN_DAYS
It's not really a delay in time sense. We're not actually delaying our timer execution... we're just modifying the query revision time by shifting it to the left.

@hhlee445 I'll go with whichever you decide.


Networking access to signing CA

Need to note that customers stack's will need network access to CAs used to sign certs. This is a requirement for CRL checks used to validate certificates.

@ppacent : Thanks for your contribution to the Azure documentation! The author, @jeffgilb, has been notified to review your proposed change.

@mattbriggs this one is yours now!


-[RCTRootView cancelTouches] is deprecated and will be deleted soon.

Following deprecation warning appears in RN 0.61.2
-[RCTRootView cancelTouches] is deprecated and will be deleted soon.

Following occurrence of cancelTouches is the only in codebase and can be safely removed:
https://github.com/wix/react-native-interactable/blob/e204490adf6043ef9fe585e70e5fc8d19bdf5590/lib/ios/Interactable/InteractableView.m#L363

Any update on this?

Still getting this warning

I'm getting this too.
I'm not sure if thumbs up-ing the first post is the best way in this repo to get eyes on an issue or not so I'm also commenting. Hope that's ok.

I'm a bit worried about it - any chance to take care of it?

I'm a bit worried about it - any chance to take care of it?

In my case, i need Swipeable, I don't use this library, is replaced with Swipeable of react-native-gesture-handler

I've got much better performance using this library then the Swipeable from react-native-gesture-handler. Sadly this library is still missing a maintainer.


[ISSUE #3949] support Tencent Polaris Registration Center

As for support pushing configuration to Polaris:
#3949 .
And pr.#4410 #4410

[x] Add shenyu-register-client-server/shenyu-register-client-server-polaris module .
[x] Add shenyu-register-client/shenyu-register-client-polaris module .
[x] Add shenyu-register-instance/shenyu-register-instance-polaris module .
[x] Add shenyu-sync-data-center/shenyu-sync-data-polaris module .
[x] Add shenyu-spring-boot-starter/shenyu-spring-boot-starter-sync-data-center/shenyu-spring-boot-starter-sync-data-polaris module .

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4897 (296a821) into master (3d3cafe) will decrease coverage by 0.05%.
The diff coverage is 70.00%.

@@             Coverage Diff              @@
##             master    #4897      +/-   ##
============================================
- Coverage     63.89%   63.85%   -0.05%
- Complexity     8235     8248      +13
============================================
  Files          1169     1173       +4
  Lines         34541    34669     +128
  Branches       3107     3107
============================================
+ Hits          22071    22138      +67
- Misses        10706    10760      +54
- Partials       1764     1771       +7

Files Changed
Coverage Δ

...e/shenyu/common/constant/PolarisPathConstants.java
0.00% <0.00%> (ø)

...try/polaris/PolarisInstanceRegisterRepository.java
56.52% <56.52%> (ø)

...polaris/PolarisClientServerRegisterRepository.java
61.90% <61.90%> (ø)

...lient/polaris/PolarisClientRegisterRepository.java
90.19% <90.19%> (ø)

... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dragon-zhang @mahaitao617 pls review.

pls add license file


loosing cursor when saving a file

Hi, I was wondering if anyone else is experiencing this problem or has a workaround.  Can't seem to find any similar issues.
Problem:
When editing a file, I save the file with ctrl-s, and the cursor which shows up as a block initially disappears.  I can still navigate with vim style navigation, but then i don't see where my cursor really is anymore.  Clicking on the window makes the block come back, so i can see where the cursor is again, but if i save the file again, the cursor reverts to a mode that appears like it's in insert mode, but I'm not really in insert mode.
This wasn't occurring in older versions of the vim plugin.
Packages installed:
/home/eraigosa/.atom/packages (28)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

update:  i've also tried this with all packages disabled, and just enabling vim-mode by itself.  Seems to give me the same behavior.

Can you open the key-binding resolver (Key Binding Resolver: Toggle) and report what it shows when    you are saving the file and the cursor is disappearing? Also, are you using the latest Atom? If not, can you update to the latest Atom and try again?

Using atom 0.172.0 from http://ppa.launchpad.net/webupd8team/atom/ubuntu ppa on trusty
Here is what i see when i hit the toggle key binding
http://goo.gl/BaaYBK
I can probably figure out how to install 0.174.0 but that would require rebuilding atom and dropping the ppa, i was hoping to be able to keep that ppa.  Hoping it's not the ppa thats the issue.
https://launchpad.net/~webupd8team/+archive/ubuntu/atom

So the cursor disappears when you save the file with ctrl-s right? Is that screenshot what you see when you type ctrl-s? It looks from that like you are typing escape there.

@maxbrunsfeld The mouse cursor doesn't disappear.   Here is a short little web clip on what i see.
http://goo.gl/e09cHy
Steps im using

hit i to go into insert mode, type some test
hit escape, open another line, more text
hit ctrl-s , and the file saves, but the blinking cursor does not return.

Here is another screen capture with keybinding toggled on.  http://goo.gl/HFRl8U

It came across a little hard to read on my side... trying it again with resized window http://goo.gl/e9LJAG

I am also having this issue, however it doesn't get triggered on save but rather when I focus another window and go back to atom the block cursor disappears. Clicking with the mouse in the document makes it appear again.

Today i've re-installed my OS , and thus also re-installed atom and all my plugins.   I'm no longer able to reproduce or see this issue using 0.174.0.    Unless someone else can provide some way to reproduce it, I think for me the issue is closed.

Could be related to atom/atom#3622 (@Industrial's issue definitely is). There's also a workaround for vim-mode in that thread.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Issue: 💪

Core Chef Resource Checklist
Before suggesting a resource for inclusion please make sure your suggestion meets these criteria for resources built into Chef:

[x] Automates an operating system component that ships by default on systems such as authentication, raid, disk partitions, firewalls, containers, or virtualization systems.
[x] Does not attempt automate 3rd party applications such as database, web, or application servers, which are best suited for cookbooks due to their fast moving nature.

Describe the resource:

Why should this be included out of the box?:

What operating systems would it run on?

Current cookbook implementation:

Can We Help You Implement This?:


Migrate from istanbul to nyc

When installing the module I get this warning:
warning gulp-istanbul ><EMAIL_ADDRESS>This module is no longer maintained, try this instead:
  npm i nyc
Visit https://istanbul.js.org/integrations for other alternatives.

Indeed, the tools changed since I've created this plugin. Feel free to use something else for coverage.
This library was made for Istanbul and gulp. I do not plan to update to anything else.


load metadata from file

Convenient util function to load metadata from yaml and json files

So this is to prevent us from parsing dates? Why wouldn't we want to parse dates?

we do want to parse them, but as strings. PyYaml reader automatically parses datetime fields as datetime objects

@bendichter the load_metadata_from_file() function will be helpful any time a script might load the user-customized metadata from files (which can cbe yaml or json), for example here, calling the converter from command line

@luiztauffer Can you add tests demonstrating usage, and maybe also  complete the auto-filled PR description or something richer to make a case for the structure, use, design, etc.? Since this would count as a new supported feature altogether
Also, are you using this in a less generalized form on any current projects so that you would be able to point to examples that way?

@luiztauffer I'm still stuck on the date issue. I think we should parse them and represent them as datetimes in memory. Then they should appear on the form with a date selector, not a string. Then if we want to save them again into json or yaml, they should be re-serialized into strings.

@CodyCBakerPhD you’re right, we should have tests for it, I’ll do them. I’ve included one example usage in the PR description.
@bendichter datetime information should be strings in the metadata objects, that’s how it gets validated by json schemas (check here).
The UI forms already work the way you described: they identify (from the schema definitions) if the string is of a datetime format and creates a datetime selector element, not a string field.

@luiztauffer could you extend jsonschema to allow for datetime objects? https://stackoverflow.com/questions/52210425/validate-datetime-value-using-python-jsonschema

so we're good to merge this, right @bendichter ?
it would be important to have it in the coming release


-webhook-fail-on-error can't be configured with the helm chart

There is a pull request addressing this issue (#1685) but nobody has reviewed it.

A workaround for the time being is to use postrender script in Helm that looks like:
yq '. |= (select(.kind == \"Deployment\") | .spec.template.spec.containers[0].args += \"-webhook-fail-on-error=true\")' -

Hi @Dlougach thanks for this fix! Can you describe what the -webhook-fail-on-error=true arg does?
For context, on my deployment it looks like the webhook certs expire after sometime, and after that the spark operator creates invalid driver pods (missing pvc mount), and my driver pods start to fail. the spark-operator pod does not crash though, just logs TLS errors.
rolling the spark-operator deployment seems to resolve the issue. and my solution was to create a simple k8s cronjob that runs kubectl rollout restart but if this argument essentially restarts the pod, that would be way better! LMK!

Can you describe what the -webhook-fail-on-error=true arg does?

It makes sure that if kubernetes API can't reach the webhook, then the pod creation will fail (the default behaviour is that it will run as is - in the configuration it was created with).

Hmmm, that sounds helpful. I guess in my case where the webhook wasn't working and the pods were getting created incorrectly, but I really just need the regen certs script to run in that case. Like I'd hope this could be self healing. Any thoughts?

@domenicbove, if its any help, I had a similar issue, and raising a PR here doesn't seem like it woudl do any goofd. Rather than fork the chart I was able to patch the value into the deployment, as we're using helmfile which has Kustomize support.
The root cause of our operator stopping working was a couple of things.
We had several deployments of the operator in diff namespaces and they were all overwriting the same webhook config. Previously running operators would start fail when deploying new ones. This was fixed by properly setting fullnameOverride so each webhook config was unique.
We also found that the helm hooks were causing issues when we deployed as they would get kicked off but the pod the ordering was indeterminate and the pods weren't rolled. This meant the running operator no longer had the correct certs and would start to fail. We fixed that by changing the hook values for init and cleanup to remove the pre-upgrade step and haven't had any issues since.


ORDER BY in query not being respected in VL with draw order of features

Related to: https://github.com/CartoDB/carto-vl/issues/20
I'm noticing that when there is an ORDER BY in a query, that the features aren't drawing as expected. Is this expected behavior?
For example, in the screenshot below, each symbol is colored and sized by an attribute avg_waiting_time where the query orders by avg_waiting_time desc what I would expect to see (and what I see in Builder) is the smaller points to draw on top of the larger ones. As you can see where the central large red circles are, that isn't being respected as there are several smaller points still drawing underneath the larger ones:

Even if I add
order: width(desc)
It still doesn't change the viz:

Just in case, the full query for the dataset (client project so can't share map in public repo):
SELECT CONNECTION_NAME,
       sum(occupancy) AS occupancy,
       avg(avg_waiting_time) AS avg_waiting_time,
       the_geom,
       the_geom_webmercator,
       row_number() over() AS cartodb_id,
       hour
FROM table
WHERE avg_waiting_time > 0
  AND trip_date >= '2018-07-18'
  AND trip_date < '2018-07-19'
GROUP BY CONNECTION_NAME,
         hour,
         the_geom,
         the_geom_webmercator
ORDER BY avg_waiting_time DESC

I think this is expected behavior due to the way Maps API works.
cc: @Algunenano

Ok, I saw one problem, to use CARTO VL ordering function you should use:
order: desc(width())
Instead of
order: width(desc)
An error is not thrown because https://github.com/CartoDB/carto-vl/issues/675 is not fixed.
If the issue is fixed with this, please, close the issue.

This should throw an error now as #675 is already fixed. Re-open if necessary.


unresolved external symbol error

vcpkg package management program version 2023-06-15-8c254a5fb6c503615834fc66bd0717664a339a2e
Microsoft Visual Studio Community 2022 (64-bit) - CurrentVersion 17.6.4
msvc console project
sqlitecpp 3.3.0
When I install the library using vcpkg and run the test code in VisualStudio, I get the following unresolved external symbol error.
********.obj error LNK2001: The external symbol "int const SQLite::OPEN_READONLY" (?OPEN_READONLY@SQLite@@@3HB) is unresolved
********.exe : fatal error LNK1120: 1 unresolved external reference

How can I resolve this?
If only the sqlite3 library is used from vcpkg, there is no error.

managed to replicate it, seems to be related to SQLiteCppExport.h
Visual Studio shows that is not detecting properly windows

I am not much familiar with CMake, however seems that under CMakeLists.txt
target_compile_definitions(SQLiteCpp PRIVATE "SQLITECPP_DLL_EXPORT")

should be
target_compile_definitions(SQLiteCpp PUBLIC "SQLITECPP_DLL_EXPORT")

managed to run the project using cmake with visual studio generator, I tried to patch it using vcpkg but it did not work
sadly there is nothing else I can think of for vcpkg+visual studio, as a workarround you can set the preprocessor definition  manually for your project like this

I think it could be a good idea to open an Issue in vcpkg to check if they know a way how to set that definition
this is the patch I used in case anyone wants to check it out
diff --git a/CMakeLists.txt b/CMakeLists.txt
index df5693d..0a24924 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -216,7 +216,7 @@ endif (SQLITE_USE_LEGACY_STRUCT)
 if(BUILD_SHARED_LIBS)
     if(WIN32)
         add_definitions("-DSQLITECPP_COMPILE_DLL")
-        target_compile_definitions(SQLiteCpp PRIVATE "SQLITECPP_DLL_EXPORT")
+        target_compile_definitions(SQLiteCpp PUBLIC "SQLITECPP_DLL_EXPORT")
     endif()
 endif()

@@ -295,9 +295,9 @@ else (SQLITECPP_INTERNAL_SQLITE)
             target_link_libraries(SQLiteCpp PRIVATE ${sqlcipher_LIBRARY})
         endif()
     else()
-        find_package (SQLite3 REQUIRED)
+        find_package (unofficial-sqlite3 CONFIG)
         message(STATUS "Link to sqlite3 system library")
-        target_link_libraries(SQLiteCpp PUBLIC SQLite::SQLite3)
+        target_link_libraries(SQLiteCpp PRIVATE unofficial::sqlite3::sqlite3)
         if(SQLite3_VERSION VERSION_LESS "3.19")
             set_target_properties(SQLiteCpp PROPERTIES COMPILE_FLAGS "-DSQLITECPP_HAS_MEM_STRUCT")
         endif()
diff --git a/cmake/SQLiteCppConfig.cmake.in b/cmake/SQLiteCppConfig.cmake.in
index 2b48df4..d0feda9 100644
--- a/cmake/SQLiteCppConfig.cmake.in
+++ b/cmake/SQLiteCppConfig.cmake.in
@@ -1,6 +1,6 @@
 include(CMakeFindDependencyMacro)
 if(NOT @SQLITECPP_INTERNAL_SQLITE@)
-    find_dependency(SQLite3 REQUIRED)
+    find_dependency(unofficial-sqlite3 REQUIRED)
 endif()
 if(@UNIX@)
     set(THREADS_PREFER_PTHREAD_FLAG @THREADS_PREFER_PTHREAD_FLAG@)

@ninjaoflight
Thank you for your detailed explanation.
I am not familiar with C++ and compilation and am not sure if I understand it correctly.
Is the following interpretation correct?

The problem occurs with respect to the output handling of the DLL.

Essentially, this is a problem that should be addressed by modifying "CMakeLists.txt".

By manually adding "SQLITECPP_COMPILE_DLL" to the last line of the "preprocessor definition", the DLL can be output and the project can be executed.

There may be a way to automatically resolve the "preprocessor definition" from vcpkg.

I cannot speak for VCPKG+Visual Studio.
the issue happens because SQLITECPP_COMPILE_DLL is not defined, this definition is used by SQLiteCpp to check if it was compiled as a DLL or a static library, for vcpkg it is compiled as DLL however seems that the definition is not exported to visual studio
so the solution would be to include a patch for vcpkg in its port and test it so it exports correctly the definition, if is an error from the main Cmakelists of this repo it can be changed, if it requires a change for the port it has to be changed on the port.
also I found that in Microsoft/vcpkg#8879 they have a similar issue for this
as an alternative workarround besides the other I mention you can modify the source code that includes SQlitecpp and define SQLITECPP_COMPILE_DLL before the include statement like this
#define SQLITECPP_COMPILE_DLL
#include <SQLiteCpp/SQLiteCpp.h>

it may not be the best solution but will work until someone finds a better solution

@ninjaoflight
Thank you again for your detailed explanation.
I did not fully understand it with my knowledge, but I now have a better understanding.
My project compiled successfully and worked fine with both of the two methods you mentioned above.
If there is nothing to fix in this repository, I am willing to close this issue.
Finally, I would like to thank the developers of this repository and the people who worked on this issue.

I think #434 fixes this as we need SQLITECPP_COMPILE_DLL defined for all users of the library. add_definitions doesn't do this in cmake, it just defines it for SQLiteCpp and nothing else.
Defining this means that users of the library get #define SQLITECPP_API __declspec(dllimport), which is correct as dllexport should only be used when building the library itself:
https://stackoverflow.com/questions/57999/what-is-the-difference-between-dllexport-and-dllimport

I think #434 fixes this as we need SQLITECPP_COMPILE_DLL defined for all users of the library. add_definitions doesn't do this in cmake, it just defines it for SQLiteCpp and nothing else.
Defining this means that users of the library get #define SQLITECPP_API __declspec(dllimport), which is correct as dllexport should only be used when building the library itself:
https://stackoverflow.com/questions/57999/what-is-the-difference-between-dllexport-and-dllimport
I have tested this on our code (we use vcpkg with dynamic libs) and it seems to fix the linker errors.

good insight, I know this change works with cmake+vcpkg works, however I do not know if it works under vsbuild+vcpkg, I think the patch would need an additional command but I am not sure

managed to run the project using cmake with visual studio generator, I tried to patch it using vcpkg but it did not work
sadly there is nothing else I can think of for vcpkg+visual studio, as a workarround you can set the preprocessor definition manually for your project like this

I think it could be a good idea to open an Issue in vcpkg to check if they know a way how to set that definition
this is the patch I used in case anyone wants to check it out
diff --git a/CMakeLists.txt b/CMakeLists.txt
index df5693d..0a24924 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -216,7 +216,7 @@ endif (SQLITE_USE_LEGACY_STRUCT)
 if(BUILD_SHARED_LIBS)
     if(WIN32)
         add_definitions("-DSQLITECPP_COMPILE_DLL")
-        target_compile_definitions(SQLiteCpp PRIVATE "SQLITECPP_DLL_EXPORT")
+        target_compile_definitions(SQLiteCpp PUBLIC "SQLITECPP_DLL_EXPORT")
     endif()
 endif()

@@ -295,9 +295,9 @@ else (SQLITECPP_INTERNAL_SQLITE)
             target_link_libraries(SQLiteCpp PRIVATE ${sqlcipher_LIBRARY})
         endif()
     else()
-        find_package (SQLite3 REQUIRED)
+        find_package (unofficial-sqlite3 CONFIG)
         message(STATUS "Link to sqlite3 system library")
-        target_link_libraries(SQLiteCpp PUBLIC SQLite::SQLite3)
+        target_link_libraries(SQLiteCpp PRIVATE unofficial::sqlite3::sqlite3)
         if(SQLite3_VERSION VERSION_LESS "3.19")
             set_target_properties(SQLiteCpp PROPERTIES COMPILE_FLAGS "-DSQLITECPP_HAS_MEM_STRUCT")
         endif()
diff --git a/cmake/SQLiteCppConfig.cmake.in b/cmake/SQLiteCppConfig.cmake.in
index 2b48df4..d0feda9 100644
--- a/cmake/SQLiteCppConfig.cmake.in
+++ b/cmake/SQLiteCppConfig.cmake.in
@@ -1,6 +1,6 @@
 include(CMakeFindDependencyMacro)
 if(NOT @SQLITECPP_INTERNAL_SQLITE@)
-    find_dependency(SQLite3 REQUIRED)
+    find_dependency(unofficial-sqlite3 REQUIRED)
 endif()
 if(@UNIX@)
     set(THREADS_PREFER_PTHREAD_FLAG @THREADS_PREFER_PTHREAD_FLAG@)

You're a savior!
I wasted 1 hours trying to understand what I was doing wrong. Turns out it was not my fault...
Works fine as a temporary solution, I guess. Thanks!

Vcpkg + Visual studio 17.7. Errors:
error LNK2001: The external symbol "int const SQLite::OPEN_READONLY" (?OPEN_READONLY@SQLite@@@3HB) is unresolved
error LNK2001: The external symbol "int const SQLite::OPEN_READWRITE" (?OPEN_READWRITE@SQLite@@3HB) is unresolved

If I define SQLITECPP_COMPILE_DLL, it gives LNK2001 too.
Why is this issue closed? Is there a solution for it? I didn't understand

Vcpkg + Visual studio 17.7. Errors:
error LNK2001: The external symbol "int const SQLite::OPEN_READONLY" (?OPEN_READONLY@SQLite@@@3HB) is unresolved
error LNK2001: The external symbol "int const SQLite::OPEN_READWRITE" (?OPEN_READWRITE@SQLite@@3HB) is unresolved

If I define SQLITECPP_COMPILE_DLL, it gives LNK2001 too. Why is this issue closed? Is there a solution for it?

can you give a sample code?, SQLITECPP_COMPILE_DLL should be defined at project level or before any #include of the library

@ninjaoflight I figure out that it works for me if I use an old vcpkg commit. So, for now it's fine, if I have more problems I will open an issue or report it to vcpkg as suggested. Thank you for the answer!

Any update on vcpkg issue?
I'm also getting
error LNK2001: The external symbol "int const SQLite::OPEN_READONLY" (?OPEN_READONLY@SQLite@@@3HB) is unresolved
Adding SQLITECPP_COMPILE_DLL define fixes it.

I'm also getting error LNK2001: The external symbol "int const SQLite::OPEN_READONLY" (?OPEN_READONLY@SQLite@@@3HB) is unresolved Adding SQLITECPP_COMPILE_DLL define fixes it.
I can confirm that the issue was fixed when building in visual studio using cmake. The issue was not fixed (i.e. #define SQLITECPP_COMPILE_DLL workaround is still required) when building with msbuild. Can this issue be reopened, or should I create a new one?

I think so far this issue is specific with VCPKG and how it is configured, I am not so familiar with cmake build process but should be good to open one issue here and maybe on vcpkg as in cmake it works without issues.
my suspicion is that vcpkg is not setting the project correctly.


Berserker ring (i) does not give boost at giant mole

🐛 Bug Report
https://i.imgur.com/0gptg9F.png
title basically picture for reference.

This appears to be fixed already in the latest master revision.

fixed in next bot update


Bug/Feature: Filter by Month

I don't know if this is a bug or by design.
I believe the current search should search 1 month from the day, and not categorically just the month itself.
eg) Today I search for a document that I did last month. July 7th, 2017. It doesn't show up in the search because it will only search for documents created in August.

Query when:thismonth - return results for current calendar month.  And you want to receive results for last 30 days, this type of query is not supported as for now. But we have it in plans


Add a CONTRIBUTING.md

What part(s) of the documentation would you like to see updated?
Description
Create Contributors Guideline to help new Contributors get started with this Project.
Additional Details
*Add a CONTRIBUTING.md to allow new users to get started with knowing how to contribute.
*Add Screenshots wherever possible.
*Add the basic information about creating Issues, Pull Requests and Branching.
*Mention tutorials related to Git and Github to help them better understand.
Which Program are you part of?

[x] DCP21
[ ] Any other

Additional information

@Ashish2030 I want to create Contributors Guidelines to help new Contributors get started with this Project.
Do assign me this under DCP'21.

There is already a file as CONTRIBUTING.md. But It will need an update. Make sure you make valid changes in the same file.


System error: exec: "generate-user-databases": executable file not found in $PATH

I'm using v1 because I wasn't able to get v2 to work. When I try to create an account, it fails giving this error: System error: exec: "generate-user-databases": executable file not found in $PATH

➜  docker-mailserver git:(v2) ✗ docker run --rm tvial/docker-mailserver:latest which generate-user-databases
/usr/local/bin/generate-user-databases
➜  docker-mailserver git:(v2) ✗ docker run --rm tvial/docker-mailserver:latest echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/tvial/Applications
```

@t94j0 please provide more information on version used, configuration.
If we're blind, we can't help you.
Thank you.


fix: adding styled components in dependency

rich-markdown requires it. while starting server getting error - https://github.com/outline/rich-markdown-editor/issues/405
This fixes it for me.

Hi @anu1097,
I tried my code with npm and it's ok. It's broken when using yarn. I tested your fix and it works with yarn.
Thanks.


feat: create cli package

moves temporary cli from core into separate package

solves #41

Coverage remained the same at 100.0% when pulling 8e3c9e3003afc7485b011e965e38ed0a1551268e on cli-package into e7bbe10b2b1bac14ddacbee4db1d5975311e5f5b on master.

Coverage decreased (-1.9%) to 98.095% when pulling 8fbb6d1dff78bcc3b97db144f203efe05725b649 on cli-package into e7bbe10b2b1bac14ddacbee4db1d5975311e5f5b on master.

Coverage decreased (-1.0%) to 99.048% when pulling 7d8fdd7e42af1bb29218bad6f0b1b86b764b0d98 on cli-package into e7bbe10b2b1bac14ddacbee4db1d5975311e5f5b on master.

Coverage decreased (-1.0%) to 99.048% when pulling ec55ee9ebfdfe4a82183124ba4ad0db3c0caea7f on cli-package into e7bbe10b2b1bac14ddacbee4db1d5975311e5f5b on master.

Coverage remained the same at 100.0% when pulling 3cb4a71e4e7629dd0e2a5d36bd132dbd66f400b0 on cli-package into e7bbe10b2b1bac14ddacbee4db1d5975311e5f5b on master.


[Bug?]: solid-start can run development server, but cannot "start"

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I use solid-start in my project.
When running the development server by "npm run dev", everything is fine.
When running the actual app with "npm run start" (solid-start start), it reports:
  ➜  API Routes:
     None! 👻

node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: spawn npx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [ 'serve', './dist/public' ]
}

Node.js v18.17.0

Expected behavior 🤔
The non-dev mode should run successfully.
Steps to reproduce 🕹
Steps:

clone https://github.com/NvChad/nvchad.github.io
npm install
npm run dev (works fine)
npm run build (works fine)
npm run start (not working)

Context 🔦
No response
Your environment 🌎
OS: Windows 11
Node: 18.17

After testing it on Windows WSL (unbuntu), it works fine.
This seems to be a Windows-specific issue...


Shouldn't we hide diff for secrets?

Currently, helmfile diff shows diff even for secrets. Is that really an intended behavior?
Similarly to https://github.com/roboll/helmfile/issues/79#issuecomment-415233646, we have a consensus that no credential should be logged. Given secrets being diff'ed may contain just base64 encoded credentials, I believe we shouldn't log it.
To suppress diff for secrets, we can always pass --suppress-secrets to helm diff.
  -q, --suppress-secrets         suppress secrets in the output

@mumoshu Does it work with Vault's secrets?

Yes

Hmm, the secrets are still showing in the logs.
I'm talking about when the new built-in Vault client is used.
E.g.:
extraEnv:
  PASSWORD:        ref+vault://vault-secret-engine-path/data/app-name?address=https://vault.company.com?proto=http#/PASSWORD

Im not sure what you mean by "logs". Could you share the exact helmfile command you're trying to run?

The point of this feature is that it suppresses any secrets from diff output when --suppress-secrets is passed:
$ helmfile --helm-binary helm3 diff --suppress-secrets
Adding repo incubator https://kubernetes-charts-incubator.storage.googleapis.com
"incubator" has been added to your repositories

Updating repo
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "crossover" chart repository
...Successfully got an update from the "cloudflare" chart repository
...Successfully got an update from the "eks" chart repository
...Successfully got an update from the "sp" chart repository
...Successfully got an update from the "fluxcd" chart repository
...Successfully got an update from the "flagger" chart repository
...Successfully got an update from the "appscode" chart repository
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "stable" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "linkerd" chart repository
Update Complete. ⎈ Happy Helming!⎈

Comparing release=raw, chart=incubator/raw
********************

	Release was not present in Helm.  Diff will show entire contents as new.

********************
default, mysecret, Secret (v1) has been added:
+ Changes suppressed on sensitive content of type Secret

@mumoshu That's exactly what was tried. However, the secrets that are got from Vault by helmfile were shown in the diff logs of helmfile.

@Xtigyro Your assumption seems correct. Out of curiosity, where of which kind of k8s resource is the extraEnv.PASSWORD injected into? spec.containers[].env in the pod spec, or data in the secret spec, etc?

@mumoshu
In the pod's - spec.containers[].env.
What will be really nice if helmfile could hide any secret in its comparison logs which is taken from HC Vault.
If it's in the K8s secret spec, it should hide the secrets, right? I think that's how Helm itself does it.

Any update on this?

This looks like a serious issue.


AccessGuard::map?

IIUC, AccessGuard is lazy, and won't actually access the data until .value() is used.
If there was an:
fn map<T, F>(self, f: F) -> AccessGuardMap<T, F> where F: FnOnce(Key) -> T;

it would be possible to implement wrappers, that could return e.g. an access to a single field, or de/serialize the value in flight, etc. preserving the lazy behavior.

Well, probably possible to implement outside all the same.


The submit form button is not aligned on small devices

What happened?
The submit form button on the registration page is not aligned with the rest of the content on small devices.
How can we reproduce this bug?
When I tried to minimize the screen size below 1200px, I saw that the submit form button was not aligned to the left as the rest of the content. I want to fix this bug.
Here is the screenshot for the same.

Please assign me this issue under GSSOC'23
Desktop Information (Optional)
No response
Urgency (Optional)
Medium priority

Too simple issue


update comms_ctx setting to match atmos

mpi comms context specification has diverged from Atmos. We need to follow ClimaAtmos approach here: https://github.com/CliMA/ClimaAtmos.jl/blob/main/src/solver/type_getters.jl#L752)

@juliasloan25 I presume this is outdated?


chore: fix some comments

Purpose

fix some comments
How does the solution address the problem

Changes made

[!CAUTION]
This user is trying performing the first step in a supply chain attack
Trying to rid of "first time contributor" status.
The user has manually added the message "Signed-off-by: vivoxfold3<EMAIL_ADDRESS>To make the commit look more trust worthy. User has opened similar PRs in all these other
repos in within the same hour

https://github.com/radixdlt/babylon-wallet-ios/pull/1321
https://github.com/DeFiCh/ain/pull/3031
https://github.com/beefyfinance/beefy-api/pull/1546
https://github.com/fluencelabs/cli/pull/1022
https://github.com/hoprnet/hoprnet/pull/6482
https://github.com/QuickSwap/interface-v2/pull/1533
https://github.com/ResearchHub/researchhub-web/pull/1825


Ultimaker.Cura version 4.10.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Is there a way to deal with the device driver installation?

@jedieaston in the other PR, I tested and got a "The parameter is incorrect.". I got the same error on this set of manifest files as well. What error were others getting here? I'd like to file an issue on Ultimaker Cura.

cc @denelon: I'm seeing this:

cc @denelon: I'm seeing this:

me too

Not at my machine at the moment, but I got the same thing.

#19798 (comment)

@ItzLevvie Should I close this PR? Or why are you suggesting changes?

It looks like Cura now has a driver as a part of the installation. It might be worth creating an issue on their repository to see if this is something they can get to install silently.

@ItzLevvie Should I close this PR? Or why are you suggesting changes?

For now yes, this PR should be closed as you'll have to contact the application developer to put out a new version because it currently doesn't install fully unattended as there's an interactive driver prompt blocking the install.


[T5A1][W10-B1] Kenneth Tan Xin You

@kennethtxytqw  Please close the PR after reading the comments.

@kennethtxytqw  Please close the PR after reading the comments.


Random errors occuring with code that is not being executed (!!??)

Hi!
I'm experiencing some strange bugs that have me completely flabbergasted. I am writing a relatively simple program that makes use of an external interrupt to reprogram some SPI devices. The software also presents an ASCII based user interface through the serial port. I don't think any of this is out of the ordinary, but typing it just presents the characteristics of the configuration of the neorv32.
The architecture of the software, however, is maybe a little bit complex because I'm using OOP concepts (structs with pointers to functions, vtables, etc), so it's a bit difficult sometimes which function is being called. Now, I'm trying to printf-debug this UART interface because I don't have an available JTAG connection (this is implemented on an iCEBreaker and I don't have external hardware to connect JTAG to the output pins). I have my software running flawlessly, reacting perfectly fine to the interrupts and all is fine, but I want to debug this little function, which is only called when I type a specific command through the serial port. If there's no interaction from my part, the CPU will continue to react to the external stimulii and processing interrupts.
static char *find_reg(const struct bank_manager *bm, int reg_number)
{
        neorv32_uart0_printf("Reg number %d max %d\n", reg_number, bm->bank_desc->n_regs);
        if (reg_number >= bm->bank_desc->n_regs)
                return NULL;

        /* Calculate register position by adding reg_size */
        char *reg = bm->regs;
        int increment = 0;
        for (int i = 0; i < reg_number; i++) {
                if (increment > 0) {
                        reg += increment;
                } else {
                        if (bm->bank_desc->regs_size[i] == 0 && i > 0)
                                increment = bm->bank_desc->regs_size[i - 1];
                        else
                                increment = bm->bank_desc->regs_size[i];
                        reg += increment;
                }
        }

        return reg;
}

So I added that little printf at the beginning of the function. And, when I do that and load that new neorv32_exe.bin file, the CPU spits this out through the serial port without even having been requested find_reg function to be executed:
Booting from 0x00000000...

> ruction access faultMEOUT_ERR]C=0x7494D4B6VAL=0x44444444TAL EXCEPTION] Halting CPU. </RTE>

So, changes in pieces of code that are not being executed produce some kind of error on the CPU. Even the message it spits out is somewhat mangled.
I've been experiencing effects like this for the last couple of days and I've tried almost everything I can think of. This is running on a ice40up5k, which synthesizes with an estimate of 24.81MHz and I've tried running the CPU at just 16MHz and exactly the same thing is happening, so it doesn't seem like a timing issue.
Not being able to run gdb on this is definitely hindering my progress, but my guess is this would probably be a heisenbug which wouldn't show itself when being debugged, as I don't believe this to be a software issue but a hardware (RTL) one.
Any and all kinds of help would be greatly appreciated. Thanks!

Here's another example that shows the CPU behaving strangely. There's this function:
static size_t get_reg_size(const struct bank_manager *bm, int reg_number)
{
        if (reg_number >= bm->bank_desc->n_regs)
                return 0;

        for (int i = 0; i < reg_number; i++) {
                neorv32_uart0_printf("n = %d, %d, %d, %d\n", reg_number, i, bm->bank_desc->regs_size[i], bm->bank_desc->regs_size[i - 1]);
                if (bm->bank_desc->regs_size[i] == 0) {
                        if (i > 0)
                                return bm->bank_desc->regs_size[i - 1];
                        else
                                return 0;
                }
        }

        return bm->bank_desc->regs_size[reg_number];
}

I realized I had a off-by-one error and I just replaced the loop to be for (int i = 0; i <= reg_number; i++) instead of for (int i = 0; i < reg_number; i++). Again, this function is not being executed, as the CPU fails before it can even reach UI code:
Booting from 0x00000000...

> ruction access faultMEOUT_ERR]C=0x7494D4B6VAL=0x44444444TAL EXCEPTION] Halting CPU. </RTE>

Hey @agamez!
I am not sure if this is really caused by a hardware bug... This damaged massage looks like some problem with the stack:

ruction access faultMEOUT_ERR]C=0x7494D4B6VAL=0x44444444TAL EXCEPTION] Halting CPU.

Maybe it is a problem on the software side. Maybe a crash of the stack and the bss segment or some rogue code that overrides parts of the program code.
Anyway, could you provide a minimal example program?

Hi @stnolting !
I've tried to reduce the offending code as much as possible, and I've reached a state that is quite small. I'm observing right now a different error, which isn't triggering a TRAP, but I think you are right and it's got something to do with a stack overflow bug because it's corrupting serial output.
The current code should just print: ART-NG-MCE-1.0 / art_reg_if-v1.0 and keep reading from uart0. However, it prints NG-MCE-1.0rt_reg_if-v1.0 which really looks like data is being overwritten by someone (and it's definitely not me!).
I've tried to make the code even smaller, but right now it doesn't matter what I change, because removing a variable or struct members, or removing a loop, or reducing the number of arguments of the function or whatever always makes it so the proper string is seen on the UART. Even moving the function on the second file to the main one, makes the error disappear.
The only relatively unusual thing there is I believe is the union, but it's not that rare, isn't it? Removing it makes the message turn OK, but also does it any other change, so I'm not sure if that's the culprit.
Anyway, since there are a couple of files I created a repo to store them, although I'm including the files here too for completeness.
neorv32-debug.tar.gz
Thanks a lot!

I just tested the code you have attached to your last comment. I just modified the NEORV32 home folder path in the makefile and executed a simple GHDL simulation using the default testbench (latest version of the core):
$ make USER_FLAGS+=-DUART0_SIM_MODE clean_all sim
art_reg_if.c: In function 'art_reg_if':
art_reg_if.c:12:21: warning: unused variable 'instruction' [-Wunused-variable]
   12 |                 int instruction = neorv32_uart0_getc();
      |                     ^~~~~~~~~~~
../../../sw/lib/source/neorv32_uart.c: In function 'neorv32_uart_setup':
../../../sw/lib/source/neorv32_uart.c:116:2: warning: #warning UART0_SIM_MODE (primary UART) enabled! Sending all UART0.TX data to text.io simulation output instead of real UART0 transmitter. Use this for simulations only! [-Wcpp]
  116 | #warning UART0_SIM_MODE (primary UART) enabled! Sending all UART0.TX data to text.io simulation output instead of real UART0 transmitter. Use this for simulations only!
      |  ^~~~~~~
Memory utilization:
   text    data     bss     dec     hex filename
   3296       0     120    3416     d58 main.elf
Compiling ../../../sw/image_gen/image_gen
Installing application image to ../../../rtl/core/neorv32_application_image.vhd
Simulating neorv32_application_image.vhd...
Tip: Compile application with USER_FLAGS+=-DUART[0/1]_SIM_MODE to auto-enable UART[0/1]'s simulation mode (redirect UART output to simulator console).
../../src/ieee/math_real-body.vhdl:830:14:warning: declaration of "real_vector" hides type "real_vector" [-Whide]
        type REAL_VECTOR is array (NATURAL range <>) of REAL;
             ^
Using simulation runtime args: --stop-time=10ms
../../rtl/core/neorv32_top.vhd:347:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIGURATION: IMEM DMEM I-CACHE D-CACHE WISHBONE OCD + GPIO MTIME UART0 UART1 SPI SDI TWI PWM WDT TRNG CFS NEOLED XIRQ GPTMR XIP ONEWIRE DMA
../../rtl/core/neorv32_top.vhd:380:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Boot configuration = direct boot from memory (processor-internal IMEM).
../../rtl/core/neorv32_top.vhd:392:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Implementing on-chip debugger (OCD).
../../rtl/core/neorv32_cpu.vhd:144:3:@0ms:(assertion note): The NEORV32 RISC-V Processor (Version 0x01080502) - github.com/stnolting/neorv32
../../rtl/core/neorv32_cpu.vhd:148:3:@0ms:(assertion note): NEORV32 CPU CONFIG NOTE: Core ISA ('MARCH') = RV32IMCBU_Zicsr_Zicntr_Zicond_Zifencei_Zfinx_Zihpm_Zxcfu_Sdext_Sdtrig
../../rtl/core/neorv32_cpu.vhd:169:3:@0ms:(assertion warning): NEORV32 CPU WARNING! Assuming this is a simulation.
../../rtl/core/neorv32_cpu.vhd:177:3:@0ms:(assertion note): NEORV32 CPU CONFIG NOTE: Boot from address 0x00000000.
../../rtl/core/neorv32_cpu.vhd:183:3:@0ms:(assertion warning): NEORV32 CPU CONFIG WARNING! Overriding <CPU_IPB_ENTRIES> configuration (setting =2) because C ISA extension is enabled.
../../rtl/core/neorv32_cpu_cp_bitmanip.vhd:173:3:@0ms:(assertion note): NEORV32 CPU: Implementing bit-manipulation (B) sub-extensions Zba Zbb Zbc Zbs
../../rtl/core/neorv32_cpu_cp_cond.vhd:65:3:@0ms:(assertion warning): NEORV32 PROCESSOR CONFIG WARNING: The RISC-V 'Zicond' ISA extension is not ratified yet.
../../rtl/core/neorv32_dcache.vhd:136:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: d-cache uncached memory space 0xf0000000..0xffffffff.
../../rtl/core/mem/neorv32_imem.legacy.vhd:91:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Using legacy HDL style IMEM.
../../rtl/core/mem/neorv32_imem.legacy.vhd:94:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Implementing processor-internal IMEM as ROM (16384 bytes), pre-initialized with application (3296 bytes).
../../rtl/core/mem/neorv32_dmem.legacy.vhd:74:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Using legacy HDL style DMEM.
../../rtl/core/mem/neorv32_dmem.legacy.vhd:77:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Implementing processor-internal DMEM (RAM, 8192 bytes).
../../rtl/core/neorv32_wishbone.vhd:138:3:@0ms:(assertion note): NEORV32 PROCESSOR CONFIG NOTE: Ext. Bus Interface - CLASSIC/STANDARD Wishbone protocol, auto-timeout (256 cycles), LITTLE-endian byte order, registered RX, registered TX
../../rtl/core/neorv32_trng.vhd:144:3:@0ms:(assertion warning): NEORV32 PROCESSOR CONFIG WARNING: TRNG uses SIMULATION mode!
../../rtl/core/neorv32_trng.vhd:408:3:@0ms:(assertion note): << neoTRNG V2 - A Tiny and Platform-Independent True Random Number Generator for any FPGA >>
../../rtl/core/neorv32_trng.vhd:409:3:@0ms:(assertion note): neoTRNG note: Post-processing enabled.
../../rtl/core/neorv32_trng.vhd:410:3:@0ms:(assertion warning): neoTRNG WARNING: Simulation mode (PRNG!) enabled!
../../rtl/core/neorv32_trng.vhd:734:5:@0ms:(assertion warning): neoTRNG WARNING: Implementing simulation-only PRNG (LFSR)!
../../rtl/core/neorv32_trng.vhd:734:5:@0ms:(assertion warning): neoTRNG WARNING: Implementing simulation-only PRNG (LFSR)!
../../rtl/core/neorv32_trng.vhd:734:5:@0ms:(assertion warning): neoTRNG WARNING: Implementing simulation-only PRNG (LFSR)!
ART-NG-MCE-1.0 / art_reg_if-v1.0

The very last console line is the actual UART output, which looks fine, right?
So maybe there is configuration issue (hardware or software) on your side?!

What version of the core are you using?
Did you change the default linker script?
What GCC toolchain / version are you using?
What core configuration do you use (peripherals, ISA extensions, memory sizes, boot configuration)?

Right, here's something strange.
If I simulate with your command line:
make USER_FLAGS+=-DUART0_SIM_MODE clean_all sim
Then my simulation output is exactly as yours: I see the whole string on the console and the message is the full ART-NG-MCE-1.0 / art_reg_if-v1.0
If I simulate without defining DUART0_SIM_MODE:
make clean_all sim
Then I see what I wrote on my post above, the characters one by one and the message that is being output is wrong:
uart_rx.simple.vhd:59:15:@504885ns:(report note): uart0.tx: N
uart_rx.simple.vhd:59:15:@1077765ns:(report note): uart0.tx: G
uart_rx.simple.vhd:59:15:@1650645ns:(report note): uart0.tx: -
uart_rx.simple.vhd:59:15:@2223525ns:(report note): uart0.tx: M
uart_rx.simple.vhd:59:15:@2796405ns:(report note): uart0.tx: C
uart_rx.simple.vhd:59:15:@3369285ns:(report note): uart0.tx: E
uart_rx.simple.vhd:59:15:@3942165ns:(report note): uart0.tx: -
uart_rx.simple.vhd:59:15:@4515045ns:(report note): uart0.tx: 1
uart_rx.simple.vhd:59:15:@5087925ns:(report note): uart0.tx: .
uart_rx.simple.vhd:59:15:@5660805ns:(report note): uart0.tx: 0
uart_rx.simple.vhd:59:15:@6233685ns:(report note): uart0.tx: r
uart_rx.simple.vhd:59:15:@6806565ns:(report note): uart0.tx: t
uart_rx.simple.vhd:59:15:@7379445ns:(report note): uart0.tx: _
uart_rx.simple.vhd:59:15:@7952325ns:(report note): uart0.tx: r
uart_rx.simple.vhd:59:15:@8525205ns:(report note): uart0.tx: e
uart_rx.simple.vhd:59:15:@9098085ns:(report note): uart0.tx: g
uart_rx.simple.vhd:59:15:@9670965ns:(report note): uart0.tx: _

Is this a bug in the UART code then?

Here, address 9d4 is missing. This causes an offset in .rodata. So all the addresses / data there are "off" by 4 bytes.

That definitely explains why a working program wouldn't fail ever but a wrong one would fail even in the region of code that was not being executed. With a little bit of luck, only the strings were misaligned, but code could still execute, otherwise instructions would all be mangled up and the existence of const pointers to functions probably made it easier to spot.

Thank you very much for finding this (heisen-)bug! This is a very interesting corner case you have found! :wink:

Well, my. Thanks to you, definitely. I wouldn't have ever guessed any of that. I truly appreciate your assistance. The quality of your work is more than remarkable!

I have started implementing a fix for this in #626.


[WIP] Fir example

This PR adds an example with a Finite Impulse Response (FIR) model, which is a non-parametric way of fitting the hemodynamic response in fMRI.
Took this opportunity to clean some technical details, like the oversampling factor that should not be 1.

@chrplr I think I ahve addressed your comments

Any more review on this ?

Any other review ?

Will merge tomorrow unless I hear otherwise.
B


Draft content validation

https://matters.news/@hzuomin/364056

duplicate with https://github.com/thematters/matters-server/issues/3153


[drogon] Update to 1.7.3

Describe the pull request

What does your PR fix?
Updates drogon to 1.7.3

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes. All features have been tested on all Windows triplets.

Does your PR follow the maintainer guide?

Yes

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static


No PDF created after printToPDF

I have your Basic Usage demo working with the addition of the necessary autoload and use classes, but nothing happens on printToPDF. No PDF is created. $devtools->page()->printToPDF($ctx, PrintToPDFRequest::make()) returns a PrintToPDFResponse Object with data. I've tried saving that data using file_put_contents but it's not a valid PDF. Am I missing something?

Solved this as follows: The PrintToPDFResponse Object data is base64 encoded (see https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-printToPDF) so all I was missing was to decode it before saving, so for anyone wanting a working example you have this...
First install with composer...
composer require jakubkulhan/chrome-devtools-protocol
Then this saves a PDF...
require_once "vendor/autoload.php";

use ChromeDevtoolsProtocol\Context;
use ChromeDevtoolsProtocol\Instance\Launcher;
use ChromeDevtoolsProtocol\Model\Page\NavigateRequest;
use ChromeDevtoolsProtocol\Model\Page\PrintToPDFRequest;

// context creates deadline for operations
$ctx = Context::withTimeout(Context::background(), 30 /* seconds */);

// launcher starts chrome process ($instance)
$launcher = new Launcher();
$instance = $launcher->launch($ctx);

try {
	// work with new tab
	$tab = $instance->open($ctx);
	$tab->activate($ctx);

	$devtools = $tab->devtools();
	try {
		$devtools->page()->enable($ctx);
		$devtools->page()->navigate($ctx, NavigateRequest::builder()->setUrl("https://www.google.com/")->build());
		$devtools->page()->awaitLoadEventFired($ctx);

		$response = $devtools->page()->printToPDF($ctx, PrintToPDFRequest::make());
		file_put_contents('sample.pdf', base64_decode( $response->data ));

	} finally {
		$devtools->close();
	}

} finally {
	$instance->close();
}

I was using the basic example as well and could not get a screenshot generated with:
$response  = $devtools->page()->captureScreenshot($ctx, CaptureScreenshotRequest::builder()->setFormat("jpg")->setQuality(95)->build());
The response data is an empty string. It should also be base64 encoded. Any suggestions?

The basic sample for screenshot is incorrect you need to use "jpeg" in the setFormat not "jpg"


error: can't find crate for gfx

Hello there,
I'm new to rust and gfx. I'm trying to build one of the examples as an standalone project with gfx dependency, but no success yet.
Output error:
$ cargo run
   Compiling rust-em-all v0.0.1 (file:///Users/endel/Projects/rust-em-all)
   Compiling glfw-sys v3.1.2
   Compiling rustc-serialize v0.3.15
   Compiling advapi32-sys v0.1.2
src/main.rs:17:1: 17:18 error: can't find crate for `gfx`
src/main.rs:17 extern crate gfx;
               ^~~~~~~~~~~~~~~~~
error: aborting due to previous error
   Compiling draw_state v0.1.2
   Compiling xml-rs v0.1.25
   Compiling malloc_buf v0.0.5
   Compiling log v0.3.1
   Compiling gl_common v0.0.4
   Compiling core-foundation v0.1.0
   Compiling shared_library v0.1.0

Here is my Cargo.toml file:
[package]
name = "rust-em-all"
version = "0.0.1"
authors = ["Endel Dreyer<EMAIL_ADDRESS>build = "src/main.rs"

[dependencies]
gfx = "0.6"
gfx_device_gl = "0.4"
gfx_window_glutin = "0.3"
gfx_window_glfw = "0.2"

My src/main.rs file is the same as examples/performance/main.rs
What should I do?

This is your problem:
build = "src/main.rs"

It's treating main.rs as a build script, not a project source. Just remove this line, and it will compile.

Thank you @kvark! As you can see I'm still learning the basics of rust. :)


Update syn to 2.0

Also update Rust version for trybuild to 1.68

CI failure seems to be a serde problem: https://github.com/serde-rs/serde/issues/2409


Added Context::is_context_menu_open()

I encountered a case where I needed to know if an egui context menu was open, even if the mouse cursor was not in an egui area (full details in discord: https://discord.com/channels/900275882684477440/1142659953102966884).
I found that every resource I needed to detect that the context menu was open was either private, or pub(crate).  While it is possible to wrap the Response::context_menu() in code to do state-tracking, it becomes necessary to duplicate that code in every place you call context_menu().
In this commit, I add Context::is_context_menu_open().  Named similarly to Context::is_pointer_over_area(), this method will return true if any context menu is open.  This is possible because the context menu uses a temp var with a fixed Id to store its state.  This method just fetches the state, and interrogates it to see if there is a menu present.
One pub(crate) helper method, BarState::has_root(), was added as all the fields needed to perform the check were private to the menu module.
I've also updated the Context Menu demo to show the result of is_context_menu_open() to verify the code functions as expected.

Video of updated demo; github wouldn't inline it in the description.
https://github.com/emilk/egui/assets/857742/9233bf6e-8ccd-41b8-86ae-fba06e2fa698

And here's the equivalent code needed to track the context_menu state from outside of egui:
        // create an area covering the entire screen that we use to detect
        // right-click to open the context menu.
        egui::Area::new("context_menu_area")
            // set the area as background so 'is_pointer_over_area()' ignores
            // this area when checking the pointer location.
            .order(egui::Order::Background)
            // set the position to (0, 0) to override padding/spacing and cover
            // the entire screen
            .fixed_pos([0.0, 0.0])
            .show(ctx, |ui| {
                // We need to know when the context menu is open so we don't
                // move the tile-selection cursor.  There is no mechanism in
                // egui to do this, so instead we need to manually track it
                // ourselves.
                //
                // Assume the menu is always closed; update it to open when it
                // is drawn.  If the menu state doesn't match the UiState value
                // at the end, update the UiState.
                let mut menu_is_open = false;

                // create a response covering the entire screen to detect click
                // for the context menu
                ui.allocate_response(ui.available_size(), egui::Sense::click())
                    .context_menu(|ui| {
                        let mut close_menu = false;
                        if ui.button("Link to new Chunk").clicked() {
                            close_menu = true;
                        }
                        if ui.button("Link to Existing Chunk").clicked() {
                            close_menu = true;
                        }
                        if ui.button("Link to Existing Tile").clicked() {
                            close_menu = true;
                        }

                        if close_menu {
                            ui.close_menu();
                        } else {
                            menu_is_open = true;
                        }
                    });

                // if the menu state changed, upsdate the ui state
                if menu_is_open != ui_state.context_menu {
                    debug!("context menu state change: {:?}", menu_is_open);
                    world.resource_mut::<UiState>().context_menu = menu_is_open;
                }
            });


Pinecone or other prebuilt embedding support

I have already created my embeddings and uploaded them to Pinecone. These embeddings are quite large, and it would be impractical to recreate them. I am wondering if there is a way to load these prebuilt embeddings into Langflow.

+1 for this question?


Add systemd service file

I wrote up instructions for this at https://www.swissrouting.com/nostr.html#installing-as-a-service
Will send a PR adding it to the official repo.


Fix: ecp_nistz256-armv4.S bad arguments

Fix this error:
crypto/ec/ecp_nistz256-armv4.S:3853: Error: bad arguments to instruction -- orr r11,r10
crypto/ec/ecp_nistz256-armv4.S:3854: Error: bad arguments to instruction -- orr r11,r12
crypto/ec/ecp_nistz256-armv4.S:3855: Error: bad arguments to instruction -- orrs r11,r14
Always use 3-operand form instructions
CLA: trivial
Fixes #12848

The only thing preventing me from approving is that I have no access to an armv4 platform to test this on, and this is going to 1.1.1 as well.
I'd really like if @bernd-edlinger that wrote and tested the new code originally could chime in.
That aside, I agree this would fit the "CLA: trivial" requirements.

I am fairly sure this is OK, although I did not test it either.

I agree this is trivial

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.