Streaming

I am trying to wrap this in a Transform stream as I am dealing with files that are multiple GB in size.
const lzo = require('lzo');
const Transform = require('stream').Transform;

class LzoTransform extends Transform {
    constructor(options) {
        options = options || {};
        super(options);
    }

    _transform(chunk, encoding, callback) {
        this.push(lzo.decompress(chunk));
        setImmediate(callback);
    }
}

const fs = require('fs');
console.info('Starting');
const readStream = fs.createReadStream('file.txt.lzo', { encoding: null });
const writeStream = fs.createWriteStream('file.txt');

writeStream.on('finish', () => {
    console.info('Finished');
    process.exit(0);
});

readStream.pipe(new LzoTransform()).pipe(writeStream);

Error: Decompression failed with code: LZO_E_LOOKBEHIND_OVERRUN
I suspect that this LZO library may not be able to decompress arbitrary chunks of a file and must do the whole thing at once?  Any thoughts?
Thanks!
Chris

Hi Chris,
I'm kinda busy until the end of the week, but I thought I'd let you know that I took notice of your issue.
If you have full control over the side that does the compression you could write your data in chunks, which you then read and decompress separately. Here's a StackOverflow post that I found on the topic.
I hope to get some research done in the next few days. I will get back to you :)
– schroffl

Great to hear.
I have no control over the producing side.
After doing a bit more research there is talk of an LZO function that given a chunk will indicate if that chunk is complete yet. Can't remember where I saw that now.
Shocked there is so little for nodes around lzo compression...

Okay, so I just ran a few tests. If you want I can post the source for that. The program just tries to decompress the compressed data into a buffer, which is increasing in size from 1 byte up, until it is able to get some data out.
The size of the output buffer is the counter: x in the dump below.
user@device ~/minilzo-2.10> gcc minilzo.c test.c && ./a.out
Initial Data: "abcdefghijklmnopqrstuvwxyabcdefghijklmnopqrstuvwxyabcdefghijklmnopqrstuvwxyabcdefghijklmnopqrstuvwxy"
compress_result: OK
compressed size: 50

---------------------------------------------
counter: 25
dec_len: 25
decompress_safe result: OUTPUT_OVERRUN

Decompressed so far: "abcdefghijklmnopqrstuvwxy"

---------------------------------------------
counter: 85
dec_len: 85
decompress_safe result: OUTPUT_OVERRUN

Decompressed so far: "abcdefghijklmnopqrstuvwxyabcdefghijklmnopqrstuvwxyabcdefghijklmnopqrstuvwxyabcdefghij"

As you can see, lzo1x_decompress_safe is eventually able to decompress some of the data (with an output buffer of 25 bytes and 85 bytes – and the final size of 100 bytes, of course).
This looks rather promising. Now we just need to know if we can truncate some of the compressed data at the beginning and feed that back into lzo1x_decompress_safe until we get the next chunk.
However, this is where I don't know how to continue. How many bytes are we supposed to remove at the beginning? We can't just truncate dec_len bytes, because that corresponds to the uncompressed data, not the compressed one.
Do you have any thoughts on this?

So I just tested compressing a 10Gb file with the lzop command line tool. Since that worked fine I assume that there is a way to do this. I'm gonna look through the source code to see if I find anything that helps.

That was how I ended up getting something to work, i.e. lzop
Basically did this:
const readStream = fs.createReadStream('foo.txt.lzo', {encoding: null} );
const writeStream = fs.createWriteStream('foo.txt');
const child = childProcess.spawn('lzop', ['-d'], { shell: true, stdio: 'pipe' });
writeStream.on('finish', () => {
console.info('Finished');
process.exit(0);
});
lzop.stdout.pipe(writeStream);
readStream.pipe(lzop.stdin);
Except in my case the read stream was coming from S3 and the write stream was going back to S3.

So apparently the lzop tool does indeed split the data into chunks (or blocks, as it's called in the code) of 64MB and compresses them. I'm not sure what to make of this... What do you think?

It also has some headers and other things it looks like it prepends to the
file...
I think it would be cool to have something like this as a stream but I at
least have found an alternative for the moment!
On Mon, Oct 19, 2020 at 2:27 PM schroffl<EMAIL_ADDRESS>wrote:

So apparently the lzop tool does indeed split the data into chunks (or
blocks, as it's called in the code) of 64MB and compresses them. I'm not
sure what to make of this... What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/schroffl/node-lzo/issues/16#issuecomment-712452144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALTSYT7VFC5TGS6FAVS42TSLSVK3ANCNFSM4SQB4TTA
.


how about working on remote ftp file

Please consider adding feature on opening remote/ftp  file like Eclipse does.
Thanks!

There are three or four packages that provide opening remote files.  Search
on Atom.io.  I happen to use the aptly-named "remote-edit".
On Sat, Jun 13, 2015 at 7:57 PM, tatarespecia<EMAIL_ADDRESS>wrote:

Please consider adding feature on opening remote/ftp file like Eclipse
does.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/7271.

Thanks for the suggestion! This is a duplicate of https://github.com/atom/atom/issues/7117.
There are already quite a few solid community packages for FTP, so it's unlikely that Atom will be adding that to core.


Records as owned entity types?

Then article makes no mention of the records introduced in C# 9.0.
Can a record be used instead of a class for owned entity types?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d02e6748-42e0-000a-4945-42cd05a0b875
Version Independent ID: e3effbd0-07f2-423d-4032-1722e75adb37
Content: Owned Entity Types - EF Core
Content Source: entity-framework/core/modeling/owned-entities.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @AndriySvyryd
Microsoft Alias: avickers

@vanillajonathan They should work okay for this scenario. Let us know how it goes.

@ajcvickers I would like the article to mention records.


ligolo-ng: 0.4.5 -> 0.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tnpitsecurity/ligolo-ng/releases.
meta.description for ligolo-ng is: A tunneling/pivoting tool that uses a TUN interface
meta.homepage for ligolo-ng is: https://github.com/tnpitsecurity/ligolo-ng
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.1 in filename of file in /nix/store/pbak5qfcpjvbxqxjcxadp0h86bgbl30j-ligolo-ng-0.5.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
ligolo-ng

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pbak5qfcpjvbxqxjcxadp0h86bgbl30j-ligolo-ng-0.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ligolo-ng https://github.com/r-ryantm/nixpkgs/archive/2205eee008d3b255789e9683a39631e7a461a6bb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2205eee008d3b255789e9683a39631e7a461a6bb#ligolo-ng

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pbak5qfcpjvbxqxjcxadp0h86bgbl30j-ligolo-ng-0.5.1
ls -la /nix/store/pbak5qfcpjvbxqxjcxadp0h86bgbl30j-ligolo-ng-0.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ligolo-ng

Maintainer pings
cc @elohmeier for testing.

Done in #278092.


Fix dashboard issues

Pull Request Description

Fix https://github.com/enso-org/cloud-v2/issues/892

Fix listing recent projects (currently errors :warning:)
Fix "update" action in the "duplicate files found when uploading" modal doing nothing, when overwriting a file newly created in the current session
Remove dropzone (very oudated) in favor of dropping directly onto directory rows
Fix various issues with dragging
Fix all spinners not animating on Firefox
Fix column selector disappearing all the way to the right on Firefox
Change auto-generated name of duplicate files from foo (2) to foo 2

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@PabloBuchu heads up on this issue: i've found a few other minor qol improvements. one has been fixed locally, the other i'm still trying to solve. so if you're planning on QAing this one too, it might be better to wait a little while

fix merge conflict and good go merge

tangent: i'm actually quite surprised that tests for both GUI2 and dashboard complete in 2m33s...
... including property based testing and E2E tests for both codebases.


Temp: Remove MathJax

Closes  #185
Closes freeCodeCamp/freeCodeCamp#17647
Closes freeCodeCamp/freeCodeCamp#17633
Closes freeCodeCamp/freeCodeCamp#17641
Closes freeCodeCamp/freeCodeCamp#17620

@raisedadead @QuincyLarson I merged this myself to fix a terrible UI Bug.

@Bouncey Awesome - thanks for figuring out that MathJax was the culprit here!


📃: Plant disease detection

:red_circle: Title : Plant Disease Detection
:red_circle: Aim : To help farmers detect plant disease easily with images
:red_circle: Brief Explanation : We would be training multiple tensorflow models with help of keras and further we can deploy the resultant models onto web or app platform for easy detection of plant disease.
Screenshots 📷

NA

:white_check_mark: To be Mentioned while taking the issue :

Full name : Mayank Sachin Chougale
What is your participant role? GSSOC Ext

Please assign me, this project will be added under deep learning

Please assign me, this project will be added under deep learning

I have assigned it to you


Creating a resource copying a file from iRODs results in an incomplete geographic raster aggregation

The following resource was created using copy from iRODS on the Create Resource page.
https://www.hydroshare.org/resource/abba182072cc48b691ca61509019e9f8/
It holds a geographic raster file.  The .vrt file was created and it was placed in a folder, both steps in automatic aggregation.  However the folder that results does not appear on the UI as an aggregation and aggregation metadata is not displayed in the metadata panel.

I am unable to make this illustrative resource public due to

This is part of the problem of metadata not being set up right.  The resource is shared with HydroShare developers group so if you are a member of that group you should be able to access this.

The inability to make the above resource public may be due to the nedgridb.tif file not having spatial reference information.  But it is still a problem, as it should be possible to add this information using HydroShare if it was converted fully to an aggregation.
The following resource with a different file is public, but does not have the aggregation folder properly formed
https://www.hydroshare.org/resource/2af8df74fc6344f4a13ed9c56c09fa40/

If the create page is bypassed and the file is loaded from iRODS after the resource is created, the aggregation is properly established
Examples with the files above are
https://www.hydroshare.org/resource/ee5ac2b6e529479a97b469d21e681038/
https://www.hydroshare.org/resource/e9da177f87fd42e8922b2e4bb2ceb60d/
This appears to isolate this problem to the iRODS functionality in the Create Resource page, which means that once Create Resource is deprecated with #3242 this will be resolved.

@dtarb The only difference between loading iRODS file to create resource and adding iRODS file to an existing resource from resource landing page is where the resource is stored. In the former, the resource is stored in the user zone, hence the path is absolute that contains iRODS user zone info. I suspect the aggregation code did not account for the federation path properly, hence the folder path were not properly formed.

This is similar to #2970

@hyi that seems like a likely explanation.  But it is a case where iRODS complexity and federation complexity has bitten us and is costing us.  We need to structure and simplify our work to avoid these occurrences.

@dtarb I looked into this resource and confirmed this resource did get migrated from user zone to data zone on beta. You can check it out on beta here: https://beta.hydroshare.org/resource/abba182072cc48b691ca61509019e9f8/
I ran into bad gateway on beta initially and had to restart beta containers to get the server back up, and you can check on the migrated resource on beta above now beta is back up. As you can see, the aggregation is not created for this resource and the resource landing page looks exactly like that on www. This is expected since migration script only migrate resources from user zone to data zone without any extra aggregation checking. However, now that we have removed creating resources from user zone by copy or move action, you would not be able to create such a problematic resource in the first place on the current production server. So I suggest to delete this resource and close this issue unless you see any potential issues in doing so.

@hyi please think from a users perspective.  I am happy to delete and fix this resource.  But there are multiple other resources from other users for whom this may be a problem.  I think that the process of migrating resources to userzone should audit and check all the resources migrated and if there are problems, then address them.
And by the way - this resource is still broken on beta

@dtarb I don't understand why you are getting AttributeError on this resource since it works for me. See the screen capture below

It looks like the AttributeError you run into is related to your login user object being None, but I don't know how you can login in the first place if the user object is None, so I have no idea why you run into this issue but it works for me just fine. Do you run into this Attribute error for other resources on beta?
I could write a separate management command to fix the aggregation issues in composite resources like this one rather than put the logic in the user zone to data zone migration command since this aggregation problem may not be isolated to only resources in the user zone. If you think we need to do this, you can assign this issue to me or close this one and create a new issue for addressing this potential issues in all composite resources.

@hyi before you write a separate management command we need to get to the root of what is going on.  It is curious that this file shows as an aggregation in your display, but on www with me it does not.  I do not have time right now to debug this particular issue, so will need to leave it to you, perhaps interacting with @sblack-usu to try figure out.

@dtarb good observation and it is interesting to see this migrated resource actually shows the geographic raster aggregation and all aggregation metadata also displays correctly on beta. I'll look into it and try to figure out what is going on since apparently fixing file path as a result of resource migration from user zone to data zone fixed this aggregation issue. In the meanwhile, beta user login seems to have a bit of issue which may be related to two workers being active and me manually deploying my code to one active worker, since I ran into csrf cross-site error if I click on this resource link directly on beta without logging in to beta first. However, if I login to beta first, then click on this resource link, the resource appears to display correctly for me. So you may try to login to beta first, then click on this resource link to see whether the resource landing page would show for you without AttributeError.

@dtarb I checked production Django database for this specific resource and verified this resource does have GeoRasterLogicalFile type relation linked to it. This explains why the folder shows as raster aggregation on beta after resource migration from user zone to data zone. I don't know the exact reason why this raster aggregation does not show for this resource on www, but I can confirm the resource data in Django database on www for this resource is correct, so the problem for this resource display on www might be caused by the server side view function which returns aggregation type not handling resources in user zone properly or by the client javascript code that somehow does not parse it properly. In any case, this display problem will be fixed in the next release after resource migration from user zone to data zone. As a result, I will not spend any more time investigating this further.

@hyi I am happy for you proceed with the update that fixes this once you are confident it is right.  Will this be part of a regular code update, or a migrate script that runs separately.

@dtarb My PR including this migration command script has been merged into develop branch, so will be included in the next regular release. The migration script has to be run separately just one time as the last step of the next release and I can help with that if needed. Looping in @sblack-usu @phuongdm @cbcunc to keep them informed of this extra step only for the next release.

@hyi, please add the migration command to the deployment notes when we cut the next release.

@sblack-usu Will do.

@hyi @sblack-usu please consider whether it is best to run this migration command as part of the deploy or separately (e.g. 2 days later not during a deploy).  Our thinking with composite resource migrations has been that they should be separate.  Perhaps the same idea applies here too.  The reason for having them separate is to be able to do checks of resources before and after a deploy and if there are problems to know whether it is the deploy or the migration that has caused the problem.
I think that with this migration we also need a bit of extra manual cross checking that these resources do actually migrate properly, especially sensitive ones like large published resources from our users (Rushforth 100 GB resource).  Please coordinate all this.

@dtarb doing the migration in a couple of days after the deploy may be a good idea. @sblack-usu I'll add migration command in the next release deployment notes and leave it to you when you will run it. I'll check those migrated resources to make sure they look correct after migration is done on production server.

This appears fixed with iRODS and zone changes


[Issue] [Support] Cannot use parenthesis and brackets to embed links

When creating a ticket message, you cannot use those two characters as it thinks you are messing up the { and } brackets for use in mentioning the user. It would be nice if this check was removed to be able to embed links. 🙂

You should now be able to set ticket messages with [ and ] in them


Dll error binding

When I try run my app at WIndows 8.1 RT with opengl-to-directx wrapper, located at System32 or folder with my app, your lib can't find opengl32.dll, but other native(c++) apps can find and use this wrapper.
P.S. Yeah, it's very specific case, Windows RT doesn't support OpenGL and officially don't support run other applications. I can provide some information, if you needed.

What is the specific exception information? What is your platform library? WGL or EGL?
Anyway you can map libraries using your app.config, even just fir experimenting.

I get this error. And I'm use WGL, I think so. What I need to write in app.config for path setting?

The app.config can be created within Visual Studio (search in templates), and you can follow the mono documentation about it.
OpenGL.Net simply uses the "opengl32.dll" string for requesting the library handle; indeed there's something in your system configuration that is confusing the OS loader. The first thing that comes in my mind is the process bitness: are you running on x86 or x64? What is the bitness of your process? The nuget package binary have Any CPU as target, letting the application force the x86 or the x64 JIT. Another thing could be the Windows side-by-side configuration.
At first, have you tried to put your opengl32.dll on the same working directory of your application?

I'm running on ARM32. Yes, I'm tried put opengl32.dll in app folder, but no changes.

Are there any opengl32.dll dependencies unresolved? Use dumpbin or the dependency walker to get this information.

All dependencies resolved. But configuring via app.config helps! Thanks you!


rtl: implemented RTL based on cone shape

This implements very basic RTL behavior using a cone to define the required return altitude (see figure below). Currently the user can define the half-angle of the cone and the cone is centered around the home position. If the vehicle is inside the cone, it will return at the current altitude.
If the vehicle is outside the cone the vehicle will first climb until it either intersects the cone or reaches the parametrized return altitude, whichever is lower.
The vehicle will always at least climb to the parametrized descend altitude.
Cone half angle parameter special cases:
<=0: this will lead to the RTL behavior we currently have. The drone will always climb to the return altitude.
.>= 90: In this case the drone will always return at the current altitude with the only restriction that this altitude must be larger than the RTL descend altitude.
I did some basic testing in SITL but it needs more. Also feel free to comment on the choice of cone parameter and it's default value.

Awesome and great that you included a sketch for Hamish! Please Tag the flight test team for new PRs.

One idea for the parameter is that you could have enums with a few common values (including <=0 and >= 90 cases that you described above) + a few reasonable steps inbetween (30, etc). Then it's more accessible to users that might want to simply preserve the legacy behavior, but also enables selecting advanced and entering whatever you want.

@dagar I implemented something. Is that something along the lines you were talking about?

@PX4/testflights Could you guys please give this a shot? Please make sure to try all RTL cone shapes (RTL_CONE_SHAPE parameter).
I think a good way to test this is to set the return altitude relatively high (e.g. 100m).

Tested on PixRacer V4:

Modes Tested
Position Mode: Good.
Failsafe RTL (Return To Land)

- Procedure
Arm and Take off in position mode, after flying for approximately one minute,  trigger RTL, wait for vehicle to return and land as expected.
- Notes
No issue noted, good flight in general.
Log 1
**Note:**RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 95m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=44a6a8c4-034b-4ab9-9c94-1e4088fbec5f

Log 2
**Note:**RTL_CONE_SHAPE parameter set to 2; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 40m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=47df2c77-d1c0-4303-8017-ee285d0c9295

Log 3
**Note:**RTL_CONE_SHAPE parameter set to 3; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 18m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=ff0fe029-a8a1-4a20-aacb-2d6115898be5

Log 4
**Note:**RTL_CONE_SHAPE parameter set to 4; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 9m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=0b5efc93-0336-438f-843a-688798606962

Tested on Pixhawk 2 Cube V3:

Modes Tested
Position Mode: Good.
Failsafe RTL (Return To Land)

- Procedure
Arm and Take off in position mode, after flying for approximately one minute,  trigger RTL, wait for vehicle to return and land as expected.
- Notes
No issue noted, good flight in general.
Log 1
**Note:**RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 95m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=a274ac68-cf8c-4f58-92bb-2994c21015d0

Log 2
**Note:**RTL_CONE_SHAPE parameter set to 2; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 40m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=0e571036-bf67-4626-a814-cc641aeac61e

Log 3
**Note:**RTL_CONE_SHAPE parameter set to 3; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 18m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=39039abd-3a21-47bc-b6ab-565c58b1288a

Log 4
**Note:**RTL_CONE_SHAPE parameter set to 4; RTL_RETURN_ALT= 100m
40m away from home and 5m above form home; trigger RTL.

Note: Vehicle climbed up to 10m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=62689cfd-0466-4ad0-b030-12189ece7ec1

Tested on Pixhawk4 v5
Modes Tested:

Position Mode: no issue
RTL mode: no issues

Log: #1
RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m
40m away from home and 4m above form home; trigger RTL.

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=63f37f29-1c72-4f95-b595-4b0e47b5114e

log: #2
RTL_CONE_SHAPE parameter set to 2; RTL_RETURN_ALT= 100m
40m away from home and 4m above form home; trigger RTL.

Note: Vehicle climbed up to 45m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=f1017334-a73c-45f9-af9a-8bdef676578f

log: #3
RTL_CONE_SHAPE parameter set to 3; RTL_RETURN_ALT= 100m
40m away from home and 4m above form home; trigger RTL.

Note: Vehicle climbed up to 26m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=e385d74f-a3a5-4e68-ae2d-85af5c5cd761

log: #4
RTL_CONE_SHAPE parameter set to 4; RTL_RETURN_ALT= 100m
40m away from home and 4m above form home; trigger RTL.

Note: Vehicle climbed up to 9.5m, positioned itself above home and started landing.
https://review.px4.io/plot_app?log=2d0ad457-56c2-4baf-a0ab-96ccb550ec35

Tested on Pixhawk 4mini v5
Modes Tested:

Position Mode: Good.
RTL Mode: Good.

Procedure
Arm and takeoff in Position mode, position vehicle 40m away from home and 4m above form home; trigger RTL.
Logs

https://review.px4.io/plot_app?log=fd1f2b62-2b48-4d4c-ae89-0c09edd90785
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=94d70dc2-cc7b-4b3a-a692-b386676bcb6e
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=479ac124-61b8-4f65-9778-20acd8485b69
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=bfa0670d-f230-4037-88e4-c232032d877e
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

Tested on Pixhawk Pro v4
Modes Tested:

Position Mode: Good.
RTL Mode: Good.

Procedure
Arm and takeoff in Position mode, position vehicle 40m away from home and 4m above form home; trigger RTL.
Logs

https://review.px4.io/plot_app?log=2e4736e2-fdb8-4110-a766-eefdafce6081
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=cb60fd65-f7b9-4341-b1a6-3bc6e5413837
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=ab56a776-0dcb-4b8d-82ca-f3df8d7b7de8
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=82d7ae35-a4af-4f39-8630-a9ada27087bd
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

Tested on NXP FMUK66 v3
Modes Tested:

Position Mode: Good.
RTL Mode: Good.

Procedure
Arm and takeoff in Position mode, position vehicle 40m away from home and 4m above form home; trigger RTL.
Logs

https://review.px4.io/plot_app?log=03e7dd26-897a-492e-8ea3-a8f9f7732e60
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=6b3cae5a-cf6e-47e7-bb42-46eceb537ced
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=c9e42a1d-874d-45b4-a957-5ec847df0184
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

https://review.px4.io/plot_app?log=2e875870-ebc7-4d5b-af51-1a3e74e3b9e2
_ RTL_CONE_SHAPE parameter set to 1; RTL_RETURN_ALT= 100m _

Note: Vehicle climbed up to 85m, positioned itself above home and started landing.

@RomanBapst Let's get the changes quickly in (going back to the angle, doing the values as straight angles).

@PX4/testflights Thanks for testing!

@bkueng @julianoes @dagar @LorenzMeier How do we feel about the "RTL_MIN_DIST" parameter.
This one was previously used to decide whether to climb to the RTL altitude or go straight home.
After this PR gets merged the parameter is only used to make a stupid decision regarding which yaw setpoint to choose when close to home.
https://github.com/PX4/Firmware/blob/master/src/modules/navigator/rtl.cpp#L177
So in any case we would need to adjust the description of that parameter.

Can we get rid of the param entirely?

I added back support for RTL min distance to home for legacy reasons.
This should be good to go as soon as CI passes.

@RomanBapst Parameter docs for RTL_RETURN_ALT are no longer correct: "RTL altitude / Comment: Altitude to fly back in RTL in meters"


[JENKINS-26796] Add a configure block to multijob job

https://issues.jenkins-ci.org/browse/JENKINS-26796
This adds support for adding custom configuration to each job config in a MultiJob phase.  This is useful when trying to configure newly released features, or when supporting a patched version of the MultiJob plugin.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Great, please add a test and some documentation including an example.

Thanks! I squashed your commits and merged them manually.


When looking for worksapce root, don't step over CARGO_HOME

See the description of the problem in https://github.com/rust-lang/cargo/pull/4764#issue-277901728.
The gist is that if you invoke cargo inside CARGO_HOME, which is inside a workspace, Cargo should not think that it is inside workspace.
This is the function where I think the fix should be applied: https://github.com/rust-lang/cargo/blob/806e487c0e3b6af6203ef8bebf5d6f49faf8909d/src/cargo/core/workspace.rs#L311
Relevant tests are here: https://github.com/rust-lang/cargo/blob/806e487c0e3b6af6203ef8bebf5d6f49faf8909d/tests/workspaces.rs

AFAIK, the value that holds CARGO_HOME reachable from that code is self.config.home(), but that returns a Filesystem and there is no way to inspect the inner PathBuf from that. Should I implement PartialEq<&Path> for Filesystem?

Yes it should be fine to implement PartialEq for that type, the Filesystem newtype is basically just preventing access when unlocked to help prevent synchronization bugs.

@alexcrichton Will do that then.
As for the test, I guess we should make Cargo itself put a dependency in a custom CARGO_PATH, and for that to happen it needs to be a git dependency with a repository specified as a path. The dependency should then have a build script that invokes $CARGO metadata with CARGO_MANIFEST_PATH. I've looked at the existing tests and that should be pretty straightforward to do.

Each test already has its own CARGO_HOME I believe, so it'd be fine to just throw a crate in there and build it. I believe you can use the Package helper used throughout to do this.


Add .gitignore for cached python files

These got tangled up in my other PR -- never again!!

Ashley, this is great! Happy to merge. Thanks for the contribution :)


find refs, goto definition not working on macOS

extension version: 0.0.174
vs code:
Version: 1.87.2
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:57.520Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.4.0
- find all references only finds ref in the same file

- goto definition tries to open the file, does not find it, even tho it exists

not sure what changed, but now, in aline like
import {IAmmalgamPair} from 'contracts/interfaces/IAmmalgamPair.sol';
clicking on the path opens the correct file, but clicking on the object (IAmmalgamPair) opens a tab with an error, saying cannot find the file whilst running the correct path, which exists

fixed using relative paths


FreshRSS module hard dependent on Nginx

Issue description
With services.freshrss.virtualHost set to null, an nginx virtual host isn't created, but a phpfpm pool is still created, expecting an nginx user. If you then set services.freshrss.pool to anything other than "freshrss" (e.g. ""), the freshrss-config service fails with the following log
Oct 03 20:24:01 chmura systemd[1]: Starting Set up the state directory for FreshRSS before use...
Oct 03 20:24:01 chmura freshrss-config-start[1555183]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/zq0g5j99rd5a12g9s4afnrn4qxj20kzi-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 03 20:24:01 chmura freshrss-config-start[1555183]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/zq0g5j99rd5a12g9s4afnrn4qxj20kzi-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 03 20:24:01 chmura freshrss-config-start[1555183]: FreshRSS deprecation warning: the CLI option(s): base_url, auth_type are deprecated and will be removed in a future release. Use: base-url, auth-type instead
Oct 03 20:24:01 chmura freshrss-config-start[1555183]: Reconfiguring FreshRSS…
Oct 03 20:24:01 chmura freshrss-config-start[1555202]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/zq0g5j99rd5a12g9s4afnrn4qxj20kzi-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 03 20:24:01 chmura freshrss-config-start[1555202]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/zq0g5j99rd5a12g9s4afnrn4qxj20kzi-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 03 20:24:01 chmura freshrss-config-start[1555202]: FreshRSS error: user not found: admin
Oct 03 20:24:01 chmura systemd[1]: freshrss-config.service: Main process exited, code=exited, status=1/FAILURE
Oct 03 20:24:01 chmura systemd[1]: freshrss-config.service: Failed with result 'exit-code'.
Oct 03 20:24:01 chmura systemd[1]: Failed to start Set up the state directory for FreshRSS before use.

There's also no port option making it pretty hard to set up any reverse proxy with this service.
Steps to reproduce
services.freshrss = {
  enable = true;
  baseUrl = "http://freshrss.example.com";
  authType = "none";
  virtualHost = null;
  pool = "";
};

cc: @etu @Stunkymonkey @mattchrist

see #347324 for a possible fix

can't test right now but I'm almost certain the following config on your PR will act the same as the one above does currently
services.freshrss = {
  enable = true;
  baseUrl = "http://freshrss.example.com";
  authType = "none";
  virtualHost = null;
  pool = null; # null is default, could be left out
};

@jacekpoz please try it. from point of view this should work:
services.freshrss = {
  enable = true;
  baseUrl = "http://freshrss.example.com";
  authType = "none";
  virtualHost = null;
  pool = null;
};

I did, that PR changes nothing
Oct 13 22:38:40 chmura systemd[1]: Starting Set up the state directory for FreshRSS before use...
Oct 13 22:38:41 chmura freshrss-config-start[164031]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 22:38:41 chmura freshrss-config-start[164031]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 22:38:41 chmura freshrss-config-start[164031]: FreshRSS deprecation warning: the CLI option(s): default_user, base_url, auth_type are deprecated and will be removed in a future release. Use: default-user, base-url, auth-type instead
Oct 13 22:38:41 chmura freshrss-config-start[164031]: Reconfiguring FreshRSS…
Oct 13 22:38:42 chmura freshrss-config-start[164128]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 22:38:42 chmura freshrss-config-start[164128]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 22:38:42 chmura freshrss-config-start[164128]: FreshRSS error: user not found: admin
Oct 13 22:38:42 chmura systemd[1]: freshrss-config.service: Main process exited, code=exited, status=1/FAILURE
Oct 13 22:38:42 chmura systemd[1]: freshrss-config.service: Failed with result 'exit-code'.
Oct 13 22:38:42 chmura systemd[1]: Failed to start Set up the state directory for FreshRSS before use.

the only issue now is: FreshRSS error: user not found: admin. please make sure you remove /var/lib/freshrss/config.php to reset the "install" process.
The one deprecation warning  is fixed as well.

I just did, almost exact same error
Oct 13 23:36:25 chmura systemd[1]: Starting Set up the state directory for FreshRSS before use...
Oct 13 23:36:26 chmura freshrss-config-start[209422]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 23:36:26 chmura freshrss-config-start[209422]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 23:36:26 chmura freshrss-config-start[209422]: ℹ Remember to re-apply the appropriate access rights, such as:        sudo cli/access-permissions.sh
Oct 13 23:36:26 chmura freshrss-config-start[209456]: Warning: scandir(/nix/store/4j0pgzgk1w07fqrgjk4bcn5mx4xgrc6a-freshrss-extensions/share/freshrss//extensions): Failed to open directory: No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 23:36:26 chmura freshrss-config-start[209456]: Warning: scandir(): (errno 2): No such file or directory in /nix/store/3h4zxqkknnwd4m83zizixyafw7qhdnws-FreshRSS-1.24.3/lib/Minz/ExtensionManager.php on line 127
Oct 13 23:36:26 chmura freshrss-config-start[209456]: FreshRSS seems to be already installed!
Oct 13 23:36:26 chmura freshrss-config-start[209456]: Please use `./cli/reconfigure.php` instead.
Oct 13 23:36:26 chmura systemd[1]: freshrss-config.service: Main process exited, code=exited, status=3/NOTIMPLEMENTED
Oct 13 23:36:26 chmura systemd[1]: freshrss-config.service: Failed with result 'exit-code'.
Oct 13 23:36:26 chmura systemd[1]: Failed to start Set up the state directory for FreshRSS before use.

I removed /var/lib/freshrss, the config service is running now
the issue still stands though, how do I use it without nginx?

at least now no nginx related stuff is configured. But since freshrss requires php-fpm no webserver is running... (which is needed)
services.httpd.* might be used as well. But I have never tested this.
I recommend using nginx. It uses the smallest amount of resources. (If come up with the idea to use it without any "additional" software: that is not possible.)

yes, that's why I created this issue - php-fpm is hardcoded to expect an nginx user and group and I'd like to use freshrss without nginx

caddy

see: https://nixos.wiki/wiki/Caddy#PHP_FastCGI
you will still need services.phpfpm.pools (with different user?).

I think that strategy could work to use Caddy instead of nginx. Another approach would be to reverse-proxy the nginx-provided http server with Caddy.

There's also no port option making it pretty hard to set up any reverse proxy with this service.
The port nginx uses can be configured by adjusting the listeners on the created nginx virtual host.

I don't think it makes sense for the freshrss module to provide configurations for more than one web server. That would add additional maintenance overhead and complexity. There are available workarounds if individuals would like to replace or wrap nginx in their particular configurations. I'm in favor of closing this issue.

@mattchrist i agree. NOT providing multiple web-server (this is not a bug, but more of a personal preference).
But the PR should be merged as well. There were some smaller issues.


Updated minAddress to respect startAt

This bug fix resolves the issue where startAt is not respected (or added after) if IP addresses have already been assigned to pools or IPMI.  This is in references the issue linked below.
https://github.com/tumblr/collins/issues/428#issuecomment-199524123

Awesome fix. Lgtm

[error] error while loading <root>, Error accessing /home/travis/.ivy2/cache/org.apache.hadoop/hadoop-hdfs/jars/hadoop-hdfs-2.6.0.jar

Please re-test when you have a moment.  Thanks!

LGTM

Nice catch! LGTM
@davidblum I know this is a real pain, but I need to ask you to sign this document before we can merge this....
https://github.com/tumblr/collins/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla
Can you post back here or email me once that's done?

@Primer42 Signed and sent to legal.

Thanks @davidblum!


Please update the model weights.

[Only for the MaskRCNN based model] Download MaskRCNN weights* from https://www.dropbox.com/s/n81pagybkj8p5w1/mask_rcnn_coco.h5?dl=0 and move it to /test . Out of work

Thanks for pointing out that the link to the weights is dead. You can use the original link from matterport's implementation (it is the same weights file): https://github.com/matterport/Mask_RCNN/releases/download/v2.0/mask_rcnn_coco.h5
I will also update the readme file accordingly.
Thanks!
-EY


error when adding multiple midea AC

Describe the bug （描述一下问题）
When i am adding more than one AC only the last one is working, rest are no longer avanible.
Screenshots / Logs / Pcap File（屏幕截图/日志/抓包文件）
If applicable, add screenshots or your home-assistant log file or pcap file to help explain your problem.
请提交相关截图，日志，抓包让开发者能够更快的解决问题

Versions (版本信息)

Home Assistant version: 2022.10.4
Midea msmart version: v0.2.3

This is not a bug. Your configuration is wrong. This is how it should be:
climate:
  - platform: midea_ac
    host: <IP_ADDRESS>
    id:<PHONE_NUMBER>12345
  - platform: midea_ac
    host: <IP_ADDRESS>
    id:<PHONE_NUMBER>12345

Ahh sorry, my bad !
Thanks will check that shortly but for sure will work now.
Have a nice week !


Cannot update and upgrade apps after bitwig-studio including

Reporting a bug 🐛
Cannot update and upgrade apps after (alphabetically) bitwig-studio including.
Expected behavior
deb-get update runs successfully and deb-get list shows full list of supported apps
Actual behavior
An error occures after few seconds after deb-get update
  [+] Updating /etc/deb-get/01-main
 -=O#- #   #    #
$   [+] Updating cache of supported apps in the background
  [!] ERROR! Missing required information of website package bitwig-studio:
URL=
VERSION_PUBLISHED=

Steps to reproduce
Add DEBGET_TOKEN and just run deb-get update
System information
Run the following a paste the output below:
/etc/os-release
PRETTY_NAME="Ubuntu 22.04.4 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.4 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

/etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.4 LTS"

deb-get version
0.4.0

Grab the latest deb-get from the repository, it has important fixes pending a new release including, I think, better handling of upstream breaking changes.  Just clone the repo or download and unpack and then

cd deb-get/docs
sudo make install

you could get the definitions of a couple of packages from these PRs and drop them into /etc/deb-get/99-local.d/ until the PRs are merged/ :

#1079
#1080

@philclifford thanks. I did clone repo and install. After deb-get update I run deb-get list and here's my output:
$ deb-get list
1password
activitywatch
agena
alduin
android-messages-desktop
antimicrox
anydesk
appimagelauncher
atom
atomic
atuin
audio-recorder
authme
azure-cli
azuredatastudio
balena-etcher
bat
battery-monitor
beersmith3
bitwarden
  [!] ERROR! Missing required information of website package bitwig-studio:
URL=
VERSION_PUBLISHED=
blanket
blockbench
  [!] ERROR! Missing required information of website package bluejeans-v2:
URL=
VERSION_PUBLISHED=
bottom
brave-browser
brisqi
browsh
caddy
caprine
cawbird
chronograf
code
codium
com.github.tkashkin.gamehub
copyq
cosign
croc
cronopete
crossover
crow-translate
cryptomator
dbeaver-ce
deadbeef-static
deb-get                         [ installed ]
deborah
deltachat-desktop
deskcut
detectiteasy
discord
dive
docker-ce
docker-desktop
doublecmd-gtk
doublecmd-qt
draw.io
dropbox
du-dust
duf
dustracing2d
element-desktop
emby-server
enpass
exifcleaner
expressvpn
fail2ban
fastfetch
fd
ferdium
figma-linux
filezilla-theme-papirus
firefox
firefox-beta
firefox-devedition
firefox-esr
firefox-nightly
flameshot
foliate
franz
frostwire
fsearch
gcm
gh
git-delta
github-desktop
gitkraken
gitter
glab
glow
google-chat-electron
google-chrome-beta
google-chrome-stable
google-chrome-unstable
google-cloud-cli
google-earth-pro-stable
gpu-viewer
grub-customizer
grype
headset
helio-workstation
heroic
homeassistant-supervised
hugo
hyper
hyperfine
i3
  [*] WARNING! Cached file /var/cache/deb-get/igdm.json is empty or missing.

  [!] ERROR!  Cached file /var/cache/deb-get/trivy.json is empty or missing.

  [!] ERROR! Missing required information of github package trivy:
URL=
VERSION_PUBLISHED=
typora
ubuntu-make
ulauncher
urserver
usbimager
vagrant
veracrypt
virtualbox-6.1
virtualbox-7.0
vivaldi-stable
vuescan
waterfox-g-kde
wavebox
waydroid
webex
weechat
weylus
  [!] ERROR! Missing required information of github package whalebird:
URL=
VERSION_PUBLISHED=
  [*] WARNING! Cached file /var/cache/deb-get/whatsapp-for-linux.json is empty or missing.
whatsapp-for-linux
winehq-devel
winehq-stable
winehq-staging
wire-desktop
xemu
  [*] WARNING! Cached file /var/cache/deb-get/youtube-music.json is empty or missing.
youtube-music
yq
  [*] WARNING! Cached file /var/cache/deb-get/zenith.json is empty or missing.
zenith
  [*] WARNING! Cached file /var/cache/deb-get/zettlr.json is empty or missing.
zettlr
zoom
zotero

First it got stuck on line
[!] ERROR! Missing required information of github package igdm:
URL=
VERSION_PUBLISHED=

I hit Enter and it goes further.
It seems that deb-get forgot my installed packages. How to fix that?

UPD. I run deb-get update a few times more. After that deb-get list shows no more errors and warnings. But still deb-get doesn't see my installed packages except itself.

Is you Github token (PAT) current ? All those packages giving errors seem to be from github.
As to the "only deb-get is installed" : I have seen that myself, and with others who have used sudo deb-get, which causes a number of problems.
To correct it you can deb-get install them to get /etc/deb-get/installed and /etc/deb-get/aptrepos back in step.


Add model accuracy test - step 1

Since this is only used in unit tests, maybe we just need to update the pip dep in CI.
Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/data/zhyncs/actions-runner/_work/sglang/sglang/python/sglang/test/runners.py", line 95, in start_model_process
    self.model = AutoModelForCausalLM.from_pretrained(
  File "/data/zhyncs/venv/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 564, in from_pretrained
    return model_class.from_pretrained(
  File "/data/zhyncs/venv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3274, in from_pretrained
    raise ImportError(
ImportError: Using `low_cpu_mem_usage=True` or a `device_map` requires Accelerate: `pip install accelerate`


Using go.k8s.io for pointing to OWNERS docs

As the title says
Release note:
NONE

/assign @rsdcastro

Thanks @rlenferink
/approve
/lgtm


remove query_format argument

this argument is no longer needed, as all queries are persisted in their query string format

not versioning since there is no behavior change, this is purely cleaning up unneeded code (i think that's kosher?)


language-plutus-core: use traversals to cut down on some boilerplate

Since I've learned how to do this, might as well push it a bit.
A few wrinkles have emerged:

transformMOf is very nice, but it doesn't work well where you want to do something based on the current node before recursing, e.g. in the renamer with freshening names. So we need to keep the manual recursion there.

Possibly we could write a hairy function that did this. Maybe something like this ADI stuff.

The traversals are type-preserving, so we can't e.g. change the type of names, so we cant' use this for DeBruijn, which would benefit a lot from it.

I think this is fundamental: using the Traversable instance for TermF we can have the subterms transformed to have a new name type, after which we fiddle with bound names at the current level to make them match. This requires having child nodes at a different type.

Overall it seems nice, though. I'm particularly proud of normalizeTypesInM, which IMO now says exactly what it does. (Although I do wish transformOf was called bottomUp or something).

Before any questions: this is indeed slower than what we previously had, and for that reason I am against it. I'll add criterion output momentarily.

 I don't really think it matters, though. We're doing typechecking in microseconds.

I do! I think a 20% performance regression, especially on code that already works, is not something we want. Such things add up over time.

If the performance is always orders of magnitude faster than it needs to be, then any time we spend on optimizing it is wasted. Some things do grow - we should absolutely be careful about the asymptotics. But I don't think the constant factors are ever likely to matter. And if they do, we know what to do: reduce polymorphism, specialize, look at the core, etc.
Flip it the other way around: I don't think we're at the point where we would want to make the code less clear in exchange for performance. Some might say we are already clearly not serious about performance given that we're using recursion-schemes ;)

Flip it the other way around: I don't think we're at the point where we would want to make the code less clear in exchange for performance.

Sure, but this is not what is happening: this is rewriting working code to make it more clever, while making it measurably worse in terms of performance. If we do not care about benchmark results, why have them in the first place?

any time we spend on optimizing it is wasted.

We are not spending it optimizing, rather, I am suggesting we maintain the status quo. Time has been spent rewriting it.
I will have a look at bigger/more relevant scripts in the meantime - none of the examples here are the same size as generated scripts.

Sure, but this is not what is happening: this is rewriting working code to make it more clever, while making it measurably worse in terms of performance.

We are not spending it optimizing, rather, I am suggesting we maintain the status quo. Time has been spent rewriting it.

My point is that they're the same tradeoff.
Given some change X which is worth it on a cost-benefit basis ignoring performance, we're comparing.

Do nothing: lose the value of X, no change to performance.
Apply X: gain the value of X, performance gets worse.

If X is not worth it ignoring performance then we shouldn't do it anyway. If X is worth it then that's value we lose if we don't do X. So if we're conservative to protect performance, but performance doesn't matter, then we lose out. (Okay, we don't "waste time" we "fail to gain a benefit", but it's the same thing).
(Is this code actually better or is it just "more clever"? Debatable - I think overall it is clearer, since it lets us say more directly what we're doing "look at all the subterms and subtypes of this thing and do this", and it's less code.)

If we do not care about benchmark results, why have them in the first place?

I agree, we should get rid of the benchmarks :imp: In all seriousness, I don't think they provide us with much value.

So if we're conservative to protect performance, but performance doesn't matter, then we lose out.

I don't think so? You are proposing that we modify code that already works. I see no advantage to the proposed changes.

And if they do, we know what to do: reduce polymorphism, specialize, look at the core, etc.

Or we can simply keep the code we already have. Examining core output in order to get performance we already have is absurd.

Is this code actually better or is it just "more clever"? Debatable - I think overall it is clearer, since it lets us say more directly what we're doing "look at all the subterms and subtypes of this thing and do this", and it's less code.

I think that the benefits of rewriting the renamer are very small. We keep the more complicated cases that handle binders the same, but change the easier cases. I do think that what we currently have is boilerplate, but it is safe (just like your version), straightforward, very clear and limited to the core infrastructure of the language that is frequently used by other functions. It does make sense to optimize core infrastructure by inlining some definitions.
So I prefer the current version of the renamer. And I strongly prefer the current version of the type normalizer for reasons I mentioned above.
However the new version of normalizeTypesIn is definitely better than what we had previously, because it replaces the entire function with a single line (unlike the half-new version of the renamer) and performance doesn't really matter there, because this function is not a part of the core infrastructure. Besides, the semantics is now clearer. So, a definite win.
Hence I propose to keep the renamer and especially the normalizer the way they are defined currently. Regardless of performance implications.
Regarding optimizations, termSubtypes is non-recursive and hence can be inlined. When the monad it runs in is concrete, we probably can benefit greatly from inlining. The performance problems we have might be caused by recursion-schemes actually, in terms of which termSubterms is defined. I would redefine termSubterms in the same way as termSubtypes is defined, mark everything as INLINE and see if that helps.
But still, I like the previous versions of the renamer and the normalizer more.
Also, I wonder whether we can replace existing code that uses recursion-schemes by the new machinery.

Also, I wonder whether we can replace existing code that uses recursion-schemes (e.g. Language.PlutusCore.Check.ValueRestriction) by the new machinery.

This should be possible, because there is literally para in Control.Lens.Plated. I guess we can define cata in terms of para?
If we could get rid of base functors, Recursive instances and use an approach that at the same time is more expressive and fits nicely into the lens infrastructure, that would be great. It is also probably more efficient.

And if they do, we know what to do: reduce polymorphism, specialize, look
at the core, etc.
Or we can simply keep the code we already have. Examining core output in
order to get performance we already have is absurd.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/plutus/pull/1049?email_source=notifications&email_token=ACP62HXVBDQXBSMXHIWRX5DPXCQC3A5CNFSM4HPP62I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWG4CNI#issuecomment-495829301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACP62HSSLF44O3ZSVQRMPG3PXCQC3ANCNFSM4HPP62IQ
.

Regarding optimizations, termSubtypes is non-recursive and hence can be inlined. When the monad it runs in is concrete, we probably can benefit greatly from inlining. The performance problems we have might be caused by recursion-schemes actually, in terms of which termSubterms is defined. I would redefine termSubterms in the same way as termSubtypes is defined, mark everything as INLINE and see if that helps.

I totally agree. I think this is likely to give us much bigger wins than other things.

This should be possible, because there is literally para in Control.Lens.Plated. I guess we can define cata in terms of para?

Hm, I need to stare at that a bit more.

Seems like we probably don't want this overall. I'll cut it back to just:

the definitions of the traversals
the change to normalizeTypeM
the stuff in Subst since that's only used by PIR and the quasiquoting stuff (which I should delete as unused anyway)

Examining core output in order to get performance we already have is absurd.

No, I'm suggesting that we would do that to get much better performance. But we're just speculating now. My main argument is just that performance is currently irrelevant, and as and when it becomes irrelevant, we know what to do (including reverting changes in this PR if that helps).
Since I'm going to remove most of the changes in this PR it doesn't matter so much, but I think this is an important thing for us to be on the same page on.

Ready for another look.

Seems the typechecking got a wee bit faster, too :)


Player Model Turns Invisible & Crash when you pick up sword (Iceberg + SitS suspected)

Description of the Issue
Once the sword is pulled out, player model is turned invisible, GUI scale changes automatically (mine was changed from 4 to 1), and the sword itself is invisible. When attempting to look at it in your inventory the game crashes.
With that being said, the latter issues (player model being turned invisible, GUI scaling being messed with) is only present in my modpack. When it's just the mods SitS and Legendary Tooltips (and it's dependency Iceberg) it just crashes when you attempt to look at it.
Environment
Minecraft Version 1.20.1
Forge 47.3.0
Sword In Stone Version 2.0
Relevant Logs
This is the original crash, within a modpack I'm creating
latest.log
crash-2024-07-20_18.27.59-client.txt
Here is a clip of the bug in action, you can see the paperdoll on the right for reference to tell when I'm swinging. If you notice, I lag, gui changes size, and player model goes invisible. Then once I hover over it in my inventory, it crashes.
https://streamable.com/92nkm7
This is just with Iceberg, Item Borders, Legendary Tooltips, Prism, and SitS, which are the mods I suspect
latest.log
crash-2024-07-20_18.05.59-client.txt
I'm not proficient at reading logs or to be able to see what exactly is wrong, but I hope this is enough information to help. This mod seems really cool and I would love to have it in my pack.

I tried all of the mods you mentioned here (Iceberg, Item Borders, Legendary Tooltips, Prism) with Sword In The Stone, but everything worked fine with one small problem. No crash though. If you can figure out which mod causes the crash, I can attempt to fix it.


fixFix npe when the id of base table in mv is lager than Integer.MAX_VALUE

Proposed changes
Fix npe when the id of base table in mv is lager than Integer.MAX_VALUE
This brought by https://github.com/apache/doris/pull/34768
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run p0


Remove semicolons

I got error with sanitize.sass.

I removed semicolons.

Thanks @machida. This will make it into the v4 release that will be completed this weekend.

@jonathantneal Thank you :heart:


Incremental Caching

JSON.stringify blows up on www with an OOM because the string to stringify is too big, see https://github.com/facebook/node-haste/blob/master/src/Cache/index.js#L158
repro on www jest-www --execTestsRelatedTo html/js/ads/powereditor/model/campaign.js --new.
We need to figure out to store less data in the cache and/or make it more incremental or split it up.

Oh, the problem is that we are storing both .source and .cache for Modules in the Cache now.
@davidaurelio can you revert this change? We can't store all this data in the cache because it OOMs :)

“I need all that data” – I need both source and transform result to build a bundle with source map.
Maybe we can store these in an optional second cache for the time being, until we store these on the FS.
Would that work for you?

yeah that would work for now as long as its optional. It's just definitely not going to scale for long – you should check what the memory usage is after the transform. JSON.stringify just completely blows up with an OOM on www.
See https://github.com/facebook/jest/blob/master/src/lib/transform.js#L104-L112 – if you think that file is useful by itself, we can abstract it out into a jest-transform package as part of the jest modularization effort. The first packages will land in Jest soon, so there'll be a guideline for this. See https://github.com/facebook/jest/pull/721

Made it optional in #64. This is fine for now.

thanks for taking care of that!


How can I make the crop area round and scalable?

Hi!
Thanks for your plugin. It's really useful
But I need a crop area with a circle shape that is scalable (you can see an example in attachment). Now I can only scale square shape
Can I do this? Important: I added your plugin locally, so I can change code if needed

Hi!
You should be able to achieve what you want by adjusting the following line:
https://github.com/kekland/croppy/blob/06e84b3597571fa1f8f6818f604d80f376bf44fc/lib/src/widgets/material/handles/material_image_cropper_handles.dart#L67
and the same for Cupertino. Basically, currently handles are only shown if the crop area is aabb (i.e. rectangular). I'll probably tweak this behavior later

Well, I chnged this line to painter: cropShape.type == CropShapeType.ellipse
And set cropPathFn: ellipseCropShapeFn to initialize plugin
I got circle shape for crop area with handles (see picture). Thats cool. But I can't scale it. When I move handles, it doesn't work
So how can I make this crop area scalable?
Thanks in advance

sorry, forgot to mention that you also have to adjust this:
https://github.com/kekland/croppy/blob/06e84b3597571fa1f8f6818f604d80f376bf44fc/lib/src/widgets/common/croppable_image_gesture_detector.dart#L75

Thanks, it works!
But is there any way to disable the zoom/scale for cupertino? I want to see full picture with scalable crop area, but without zoom. Like on picture from the very first message in this topic

So far there's not an easy way to disable zooming completely. It was built for mobiles at first (so that it bevahes just like the native apps). Maybe in the future I'll make it more easy to tweak this

But I added this plugin locally, so I can change the code. Maybe I can change or remove one parameter to disable scaling, or just remove that functionality

@EvgeniyKudashev a lot of the code is tied to the zoom, so it will be hard to remove it


compile_APPR_mex.m appears to be broken out of the box

Apologies, I work mostly with GitLab and don't have a professional github account.
compile_APPR_mex.m appears to have two bad paths, one to the APPR source and one to the matlab matrix source. See lines 18 and 19:
includes=['-I',location,'/ACLcut/APPR/matlab_matrix'];
and
compiles=strcat(location,'/ACLcut/APPR/' {'APPR/APPR','matlab_matrix/full','matlab_matrix/sparse'},'.cpp');
I see that the last commit on the file is "Update some documentation and clean up folder structure". I'm guessing this script was at the top level and was later moved to the ACLcut directory. The "/ACLcut" sub-string can be safely removed from each path.
includes=['-I',location,'/APPR/matlab_matrix'];
and
compiles=strcat(location,'/APPR/', {'APPR/APPR','matlab_matrix/full','matlab_matrix/sparse'},'.cpp');
The above works just fine.
Regards,
Daniel Schaefer

You are right, I moved the script and forgot to update the paths. This is now fixed.
Thank you,
Lucas Jeub


Add a wiki: Bloodborne

Link to origin wiki: https://bloodborne.wiki.fextralife.com/Bloodborne+Wiki
Link to destination (independent) wiki: http://bloodborne.wikidot.com/

Bloodborne also has a fandom wiki that needs to be redirected away from: https://bloodborne.fandom.com/wiki/Bloodborne

The preferred independent wiki would probably be https://www.bloodborne-wiki.com instead, really.

The preferred independent wiki would probably be https://www.bloodborne-wiki.com instead, really.

Since I see page number comparisons appear in prior proposals here, it appears this has more pages than the Wikidot version. 1023 vs 471, respectively (sourced via both sites' sitemap pages). Also apparently updated regularly.

anecdotally, most people seem to think that bloodborne-wiki is the best one (https://gamefaqs.gamespot.com/boards/805577-bloodborne/74742440 https://www.reddit.com/r/bloodborne/comments/glj86g/about_bloodborne_wiki/ etc), but also the wikidot one is locked just like the [https://github.com/KevinPayravi/indie-wiki-buddy/issues/236](dark souls ones). i would vote for bloodborne-wiki myself

https://www.bloodborne-wiki.com doesn't appear to actually be a wiki—it's a Blogger site run by a single person. If you click the "Edit" button on any page, you're taken to the Contact page which says

This small community wiki is, due to its format, solely edited by me (Meph). If you found any error or would like to add anything please contact me by any means included below. Thank you, it is greatly appreciated.

I believe that site fails the first criterion for inclusion.

The wiki should be editable by the public (that's what makes a wiki a wiki!)


fix(emotion): Add cache settings overrides

Overview
There has been a strange error with cache behavior with conditionally rendered components. Style tags are occasionally not present causing an error.  This change will by default remove the styles from being rendered in the DOM post SSR and allow consuming apps to configure their settings in other ways.  This will not affect SSR styles, only subsequent styles. This shouldn't have any visual effect and a slight performance increase in runtime. The node we mount them to will only be used to hydrate the cache on load. (note: we still need to extract the styles to some target in order to get nth-x selectors to render correctly so we need to keep the current SSR strategy in place)
Changes:

Adds the ability to overwrite default cache settings.
Turns on speedy by default (this uses constructed stylesheets and is no longer in the dom)

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-labs@5.5.2-alpha.226adf.0@codecademy/gamut-styles@7.4.7-alpha.226adf.0@codecademy/gamut@17.3.12-alpha.226adf.0@codecademy/markdown-overrides@0.3.15-alpha.226adf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fb815ce00187e0090acf219--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@5.5.2-alpha.f73f4b.0@codecademy/gamut-styles@7.4.7-alpha.f73f4b.0@codecademy/gamut@17.3.12-alpha.f73f4b.0@codecademy/markdown-overrides@0.3.15-alpha.f73f4b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fb81c0252c26b0d6b9979ad--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@5.7.3-alpha.0fded4.0@codecademy/gamut-styles@7.4.7-alpha.0fded4.0@codecademy/gamut@17.4.1-alpha.0fded4.0@codecademy/markdown-overrides@0.3.15-alpha.0fded4.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fbbc3f69e79d3bcfc3901a9--gamut-preview.netlify.appDeploy Logs

Based on your description it sounds like SSR components won't be styled when the page initially loads? Or are we just talking about components that aren't rendered on load

Ah sorry, this was unclear.  This will not affect SSR, only subsequent styles.  This shouldn't have any visual effect and a slight performance increase in runtime.  The node we mount them to will only be used to hydrate the cache on load.  (note: we still need to extract the styles to some target in order to get nth-x selectors to render correctly so we need to keep the current SSR strategy in place)

📬Published Alpha Packages:@codecademy/gamut-labs@5.7.4-alpha.b284b1.0@codecademy/gamut-styles@7.4.7-alpha.b284b1.0@codecademy/gamut@17.4.2-alpha.b284b1.0@codecademy/markdown-overrides@0.3.15-alpha.b284b1.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fbd47e5a151b400f1a20fca--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@6.0.1-alpha.1a9e79.0@codecademy/gamut-styles@7.4.7-alpha.1a9e79.0@codecademy/gamut@17.4.3-alpha.1a9e79.0@codecademy/markdown-overrides@0.3.15-alpha.1a9e79.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fc454c5da660a4a814aa096--gamut-preview.netlify.appDeploy Logs


Write a converter for Redux

When redux is detected, add an admin panel with Kirki's options

We now have an API that allows this to work: https://gist.github.com/aristath/6d91f49357dc7546433f

Hey @aristath sorry fro popping in here.
If I enable Kirki - and have the Redux configuration ( without enabling redux ) Kirki will detect fields automatic and convert?
Thank you very much and again, sorry for hijacking.

@Basilakis hey there!
No, unfortunately this was never properly implemented and was abandoned.
Writing a converter though should be fairly easy... I've done it for a couple of premium themes and works fine, but it's better if it's implemented on a per-use-case basis.


v0.8.0

v0.8.0 release

[x] Closes #15
[x] Closes #21
[x] Closes #46
[x] Resolves #59

🎬 looking forward to trying it.  post-upgrade an error is thrown, so I need to investigate if I broke anything
module.js:440
    throw err;
    ^

Error: Cannot find module '__buttercup/classes/Archive.js'

@NewAlexandria that error is sometime seen if you have a local copy of git-labelmaker that you're developing and you run npm link... it can sometimes get confused about where to look for the credentials. Try to uninstall globally and then re-install and this error should be resolved.

Can you upload an example .json of the custom labels?  I'd like to be sure that I'm using the right format.  Getting
/usr/local/lib/node_modules/git-labelmaker/node_modules/git-label/dist/lib/request.js:28
      resolve(res.body);
                 ^

TypeError: Cannot read property 'body' of undefined

I can file a ticket if you want.  I'm really excited about this tool for teams, and want to help make it robust.

Oh, I just needed to upgrade to npm 3.9.0

@NewAlexandria noted, thanks!


why i can`t run this code :(ls -l tf_logs/run*)

hi , on page 302 there is a code when I run it , anaconda prompt telling me that :
C:\Users\lenovo.DESKTOP-C2FPR7I> ls -l tf_logs/run*
'ls' is not recognized as an internal or external command,
operable program or batch file
please help me and thanks.

Hi @BahaaKattan111,
Thanks for your question. ls works on Linux and MacOSX, and I believe it also works in some Windows shells (like the PowerShell), but I don't use Windows so I'm not 100% sure. The equivalent command on Windows is dir. You must also replace slashes / with backslashes \. So I think the command on Windows is:
dir tf_logs\run*

Note that environment variables like $ML_PATH should also be replaced with %ML_PATH%.
Hope this helps,
Aurélien


Webhooks should have better names

What
When attempting to delete a namespace with subnamespaces, this is rejected by the webhook - which is good. But I think webhooks should be named properly - so a user can understand better what's going on.
$ k delete namespaces erikbo
Error from server (Forbidden): admission webhook "vnamespace.kb.io" denied the request: child namespaces exist

How
Describe how to address the issue.
Checklist

[ ] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

@erikgb
As your feedback, it looks like it should be fixed.
We will fix it.


difference with oracle docker images in success center docker

The image of oracle <IP_ADDRESS> is huge. So' I'm searching for an alternative. What's the difference between the images build here and those images: https://store.docker.com/images/oracle-database-enterprise-edition ?
Can I provide startup scripts (.sql files)?
It seems I can persist the data of a container derived from the image: https://store.docker.com/images/oracle-database-enterprise-edition/plans/08cf8677-bb8f-453c-b667-6b0c24a388d4?tab=instructions

The images up on Docker Store are not quite the same as the one that you get when building it yourself. Those on the store are tuned for size and startup time but come with the downside of limited functionality that is available.
You will see in the Setup Instructions:

Caveats
This Docker image has the following restrictions.
Supports a single instance database.
Dataguard is not supported.
Database options and patching are not supported.

Now if you can live with no options available and no way to ever build a patched image (i.e. you are not using these for production), then you can go ahead with these instead.
Another difference is that the images on GitHub are usually more up to date with general enhancements, such as the startup scripts facility which has been contributed by the community. It also allows for easier extension of the image, if desired.
Unfortunately, the way Docker works, it wastes a lot of space when building images, such as the space required by copying in the installer zip file, the space required by the extracted files, etc. None of this space is claimed back after the files are deleted, even if all the operations are preformed in one RUN instruction. And it doesn't look like Docker is going to bring enhancements in space management anytime soon, either.
However, there is one way that easily let's you cut in half the image size, which is by using the experimental --squash option. That option will create a new image after the build that will only contain one filesystem layer where all the wasted space has been claimed back. I highly recommend using this option to build the image, however, you will have to turn experimental on first.
You can find more about this here: https://geraldonit.com/2017/11/13/how-to-create-small-docker-images/


Update rspec to 3.4 with transpec syntax conversion and manual edits

Convert specs to RSpec 2.99.2 syntax with Transpec
This conversion is done by Transpec 3.1.1 with the following command:
transpec

950 conversions
from: obj.should
to: expect(obj).to

270 conversions
from: == expected
to: eq(expected)

27 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)

18 conversions
from: lambda { }.should
to: expect { }.to

17 conversions
from: be_false
to: be_falsey

12 conversions
from: obj.should_not
to: expect(obj).not_to

10 conversions
from: be_true
to: be_truthy

7 conversions
from: =~ /pattern/
to: match(/pattern/)

6 conversions
from: mock('something')
to: double('something')

5 conversions
from: stub('something')
to: double('something')

2 conversions
from: lambda { }.should_not
to: expect { }.not_to

2 conversions
from: pending 'is an example' { }
to: skip 'is an example' { }

1 conversion
from: it { should ... }
to: it { is_expected.to ... }

1 conversion
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)

1 conversion
from: pending
to: skip

For more details: https://github.com/yujinakayama/transpec#supported-conversions
Additional fix:
http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/
-> Assertion config changes
"For RSpec 3, we've removed expect_with :stdlib and instead
opted for explicit :test_unit and :minitest options:"
:stdlib is no longer a valid option, so changing it to :minitest

Now that master is building green, hopefully this can be rebased and go green too

yep, gonna give it a shot

@yob All checks are green. Engines are go.


Remove Seq.rev

If's awful. We can make it obsolete in the next release and remove in the release after next.

Seconded. The presence of this implies that such an action makes sense for a sequence - I don't think it does. At the very least this should come with some well documented XML doc warnings that it could explode in surprising ways.

:+1: xml document warning only, sometimes it's useful.
It's like other functions who consume the whole input sequence before return output

If you consume entire sequence, convert it to an array first. It's very explicit and safe.

Per CONTRIBUTING.md, please take design change suggestions for the core library through fslang.uservoice.com.
Adding a rule to FSharpLint may be the best first course of action.

Closing as it's a design issue

https://fslang.uservoice.com/forums/245727-f-language/suggestions/11602140-remove-seq-rev-from-fsharp-core-again

I try to think of Seq.rev as a Seq.toArray in disguise. I think that its type signature seq<'T> -> seq<'T> is confusing because people might assume it is not an eager combinator. Perhaps explicitly changing it to seq<'T> -> 'T [] would inform its users of the risks involved.

At the very least this should come with some well documented XML doc warnings that it could explode in surprising ways.

we can add a <remarks>Consume the whole input sequence before yielding the first element</remarks> in src/fsharp/FSharp.Core/seq.fsi xmldoc

Changing it to return an array is still breaking and not really better than https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/FSharp.Core/seq.fs#L1832

Regardless of the decision about the UV - the XML comment change would be a good thing.

easier do it thank discuss :smile:
if there are other similar functions (consume whole input), i can add these in the pr, just comment it

I have a slightly different view on this. Yes, it should be clear that calling rev has to traverse the entire sequence, so comments that warn of this are a good thing. It's unfortunate that going from seq -> seq also means the type system can't help us here. But is removing the method entirely really necessary? Either warnings or going from seq to array explicitly would be a big help whilst still leaving the method there for discoverability.
Flame away...

About adding a FsLint rule or compiler warning, I thinks both ideas are rather strange.

ObsoleteAttribute it's a warning in practice, but we need to wait @dsyme decision
Lint rule and xmldoc can help meanwhile


Update OpenTelemetry to v0.17.0 in metric exporter.

OpenTelemetry updated from 0.16.0 to 0.17.0 and some minor method names changed.

@googlebot I signed it!


Jupyter notebook error , can not use variable explore any more

I usually use jupyter notebook in vscode but suddenly It can not show the Variable explorer and data viewer when I click on it . I think it was crashed or something changed
One more thing that, I see the UI of jupyter notebook changed , is not it ? all the button below the cell change to another place and it seem uncomfortable when using
VS Code version: Code 1.40.1 (8795a98, 2019-11-13T16:47:44.719Z)
OS version: Darwin x64 19.0.0

Extension
Author (truncated)
Version

vscode-django
bat
0.19.0

bracket-pair-colorizer
Coe
1.0.61

prototxt
dmi
0.0.6

python-extension-pack
don
1.6.0

gitlens
eam
10.2.0

prettier-vscode
esb
3.8.0

code-runner
for
0.9.15

gc-excelviewer
Gra
2.1.32

Python-autopep8
him
1.0.2

kite
kit
0.101.0

MagicPython
mag
1.1.0

git-graph
mhu
1.18.0

python
ms-
2019.11.50794

neuron-IPE
neu
1.0.4

swdc-vscode
sof
1.2.5

pdf
tom
0.5.1

errorlens
use
2.7.2

vscodeintellicode
Vis
1.2.0

vscode-icons
vsc
9.5.0

I wasnt able to reproduce the Variable Explorer error. Could you try restarting the kernel and running the cells again or reloading VS Code to see if that fixes the problem?

And yes, we have iterated the Notebook UI based on feedback from our previous UI.

I did it already, but it can not solve the problem..
But I just try another variable like x = 1, it can not show too.
Update: I try to open a new file with small dataset already loaded. It works again and way back to another file with around 2mil records and it can not show again... does it have a limit about display here ???

Thanks for the update, we'll look into your issue

Sorry can't repro this problem. If it repros again can you reopen? Thanks


LSTM in the tracking unit for models 1/2

Also merged Raghav's implementation of scheduled sampling.

Hi @abhirast —sorry for the late response! I am allocating most of this week to other projects, unfortunately, but I have the time to read some code + make comments while mobile. :)
Some probably nitpicky changes above. Also:

Do the basic stack tests still pass?
Could you write a basic functional test for the tracking model as well? I think this would benefit both you and us. See test_stack.py for an example of spoofing a simple stack and testing the feedforward. Nothing too complicated.

Hi @hans, I made sure that the basic stack tests pass. I will add in a test for tracking model as well. I ran it on boolean data for sanity check and it is currently giving reasonable performance on sst as well.


new git client approach has issue with file ownership

When running git on files you don't own the following error is generated:
Git command output "fatal: detected dubious ownership in repository at '/mnt/
To add an exception for this directory, call:
git config --global --add safe.directory /mnt/<projectdir>

This was fixed in b4778f3


Cost percentage incorrect in single-query plan

I saw that there was another bug around multi-query plans, but this one's in a single-query plan:
https://www.brentozar.com/pastetheplan/?id=Hy94Pvdn
The bottom right index seek (Object6.Index6.Object11) shows as 98% in SSMS:

Estimated operator costs were re-worked 1.1 - looks like this fixed it


[Bug] Installation Guide PDF is blank

The current installation guide pdf is blank.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/awslabs/service-workbench-on-aws/blob/mainline/docs/Service_Workbench_Installation_Guide.pdf
The pdf has several pages but is blank both on Chrome and Safari and when downloaded.

Previous releases work correctly:
https://github.com/awslabs/service-workbench-on-aws/blob/d0767904d21fa316c4af9df1a0b78f0e0044d320/docs/Service_Workbench_Installation_Guide.pdf

Thanks for bringing this to our attention! We're making a fix for that now. The code is currently in develop (link), and we'll be merging it into mainline soon.

Latest doc changes have been merged to mainline
https://github.com/awslabs/service-workbench-on-aws/commit/d8aa731d1b4115767e3e2c832cb49ea72841cfce


Fix typo in Code Blocks

code blocks taskref were "Names", supposed to be "names"

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices
[ ] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes

/kind documentation

/ok-to-test


Transactions Sometimes Become Stuck

Rarely, a transaction will become stuck and rebroadcasting the transaction will not work until a restart, after which it will and the transaction can then be mined.

This was likely caused by fee calculation not having taken into account new Lelantus tx sizes.


Doc site: broken links

On these pages, certain links lead to a 404:

http://adaptivecards.io/documentation/#create-GettingStarted Card Schema reference documentation
http://adaptivecards.io/documentation/#display-gettingstarted Implement a renderer
http://adaptivecards.io/documentation/#resources-tools Render2Image sample project
http://adaptivecards.io/documentation/#display-libraries-android And all other platform pages Implement a renderer

I would send a PR, but It's not apparent how to form these internal URLs correctly.

Thanks Dan, I'm working on porting all of our documentation to docs.microsoft.com, the transition should be done this week

This is fixed now


initial project setup

create initial project structure for front end. (React)

We've chosen Javascript (typescript) and Bootstrap for the front end, and Firebase for the back end, as seen in the MVP documentation we created in the meeting (possibly not pushed by Jasper yet). The documentation also provides info on the different pages that we will need to create (look for each step of the Use Case),

Clarification:

Using React to front end
Switching from bootstrap to tailwind

Full feature description:
Feature name: Initial React App Setup
Description: Create react app skeleton so we can start working on sub tasks
Requires: Use npm to init initial repo and get tailwind setup
Due: Milestone 1.
Status: In-progress.
Time Estimation: 2 hours.


Merging of subcommands

This is some idea about #96
Fixes #96
Signed-off-by: zhouhao<EMAIL_ADDRESS>

i think conceptually this SGTM

SGTM. need rebase.

@vbatts @xiekeyang I think this change will be better. PTAL

@q384566678 It seems that log-level is in progress on #46 . In that patch, @stevvooe suggest that we should not use log-level, instead to use debug mode. And you seems not replace fmt.Print by logrus with context. So I think you seems to had better to remove this stuff from this patch.

LGTM
Please follow up on the issues with create / unpack.

LGTM

@q384566678 @vbatts @stevvooe This PR call logrus function, without introduce it to vendor. It  leads build fail on make tool:
$ make tool
go build -o oci-image-tool ./cmd/oci-image-tool
cmd/oci-image-tool/main.go:21:2: cannot find package "github.com/Sirupsen/logrus" in any of:

At least we should import logrus to glide.yaml and then make update-deps, the package can be generated in vendor.
Please take a review, is it Right?


stacked bar category rotated chart example and documentation

Create component to demonstrate and document the stacked bar category rotated chart

dropped support for this chart type


Update buildpacks/pack to v0.24.0

Per chat conversation on Knative deps update. This's a follow-up to bring newer buildpacks/pack as well.
The explicit replace for imgutil is removed as well.
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Changes

:broom:  Update buildpacks/pack to v0.24.0

/cc @lance @matejvasek @lkingland

/lgtm
/hold

/lgtm

@matejvasek @lkingland should we wait for @lance? or is it OK to unhold and proceed with this PR?

/unhold


what about i18n

languages

Thank you for your inquiry about internationalization (i18n) plans for our products. At the moment, we do not have a specific i18n strategy in place. Our current focus is on developing and enhancing our core features and services. However, we recognize the importance of internationalization and it remains an area of interest for future development. We appreciate your interest and will keep our users updated on any changes in this direction. Thank you for your understanding and support.


Cyrillic encoding seems not to work

Hello,
I am trying to print in Bulgarian language, but the encoding seems not to work.
Here is my code:
var commandsArray = [];
commandsArray.push({appendEncoding: StarPRNT.Encoding.Windows1251});
commandsArray.push({appendAlignment: StarPRNT.AlignmentPosition.Center});
commandsArray.push({append: '* ******** *\n'});
commandsArray.push({append: '* Български *\n'});
commandsArray.push({
  appendCutPaper: StarPRNT.CutPaperAction.PartialCutWithFeed,
});

async function print() {
  try {
    var printResult = await StarPRNT.print(
      'StarPRNT',
      commandsArray,
      'BT:00:15:0E:E6:6E:74',
    );
    console.log(printResult); // Success!
  } catch (e) {
    console.error(e);
  }
}

when I print I only get some strange symbols. Anyone else tried to print in Bulgarian/Russian?

Take a look at the official Star documentation to see if you can find the correct encoding

Take a look at the official Star documentation to see if you can find the correct encoding

Code page 866 is missing, and that seems to be the working code page for Cyrillic. Is there any chance to add it?

Take a look at the official Star documentation to see if you can find the correct encoding

Code page 866 is missing, and that seems to be the working code page for Cyrillic. Is there any chance to add it?

Take a look at the official Star documentation to see if you can find the correct encoding

Found the solution, if you want I can create a pull request. Its quite simple actually for some printers (for example mine: SM-S230I) the encoding is really specific in my case for Bulgarian language is CP855 and for Russian is CP866.
So what is needed is to add the encodings in types\index.d.ts like so:
    static Encoding: {
        USASCII: string,
        Windows1252: string,
        ShiftJIS: string,
        Windows1251: string,
        GB2312: string,
        Big5: string,
        UTF8: string,
        CP855: string
    };

and also in RNStarPrntModule.java a little modification to the getEncoding function like so:
        else if (encoding.equals("CP855")) {
            try {
                return Charset.forName("CP855"); // Bulgarian
            }
            catch (UnsupportedCharsetException e) { //not supported using UTF-8 Instead
                return Charset.forName("UTF-8");
            }
        }

Take a look at the official Star documentation to see if you can find the correct encoding

Found the solution, if you want I can create a pull request. Its quite simple actually for some printers (for example mine: SM-S230I) the encoding is really specific in my case for Bulgarian language is CP855 and for Russian is CP866.
So what is needed is to add the encodings in types\index.d.ts like so:
    static Encoding: {
        USASCII: string,
        Windows1252: string,
        ShiftJIS: string,
        Windows1251: string,
        GB2312: string,
        Big5: string,
        UTF8: string,
        CP855: string
    };

and also in RNStarPrntModule.java a little modification to the getEncoding function like so:
        else if (encoding.equals("CP855")) {
            try {
                return Charset.forName("CP855"); // Bulgarian
            }
            catch (UnsupportedCharsetException e) { //not supported using UTF-8 Instead
                return Charset.forName("UTF-8");
            }
        }


Adding fnet.Proxy* for tcp proxying and -P multi flag for cmd line

Start of #160. Also Fixes #205 (less log.Fatalf)
This is to do ingress->svc1->svc2  without closing connections unlike the /fetch/ endpoint does

made istio/fortio:0.8.0-pre2 from this PR
I will run tests with it and if it looks fine will make 0.8.0 once approved
(will also add some more test to raise the coverage lost with combo of more if() instead of log.Fatalf and more code/features)