Amplify CLI lets you pick Singapore but when I try to use it via the console it says it's not available

Specify the AWS Region
? region:
us-east-1
us-east-2
us-west-2
eu-west-1
eu-central-1
ap-northeast-1
>ap-southeast-1
ap-southeast-2
ap-south-1
From the Console:
Region Unsupported
AWS Amplify is not available in Asia Pacific (Singapore). Please select another region.
Supported Regions
EU (London)
EU (Ireland)
Asia Pacific (Sydney)
US East (N. Virginia)
US East (Ohio)
US West (Oregon)

The Amplify Console is currently not available in Singapore. Please create your app in the nearest supported region. Let me know if you face any difficulties.

@tkdtaylor
Thanks pointing this out.
Amplify Framework (the CLI and the Libraries) and the Amplify Console are two independent offerings from the Amplify family. Apparently, there's this discrepancy in the supported regions. I've notified the Amplify Console team about this.

Thanks @swaminator and @UnleashedMind for the feedback, I'll try to get in touch with the Console team to see if they know when the Console will be available in Singapore.


feat: Collect logs from all pods

This patch adds a collector named AllLogs whose purpose is to collect logs from all the pods in given list of namespaces(or if not specified, from all namespaces).
In the collector specification, this will look like -
collectors:
  allLogs:
    collectorName: my-all-pod-collector
    namespaces:
    - default
    - dev
    - prod
    selector:
    - env=dev
    - type=test

Above specification will make troubleshoot collect pod logs from default, dev, prod namespaces with the selectors env=dev & type=test

Yes, for sure. For the time being, I've updated the description for a quick look as well.


Build failed on Mac OS X 10.10.3

I used clang 6.1.0 and gfortran 4.9.2 to build OpenBLAS on Mac OS X 10.10.3, and encountered the following errors:
ld: -rpath can only be used when targeting Mac OS X 10.5 or later
collect2: error: ld returned 1 exit status

Because I have added the compiler option -Wl,-rpath,/opt/packman/gcc/4.9.2/lib. After some digging, I found the cause:
$ grep -r 'MACOS' *
Makefile.system:195:export MACOSX_DEPLOYMENT_TARGET=10.2

As you can see, the Mac OS X target has been hardcoded as 10.2! After I changed it to 10.10, the problem is gone!

Thank you for the feedback. I just changed to 10.6.


Support all symbols

Is your proposal related to a problem?

No, just improvement.
Describe the solution you'd like

The bot is currently only providing FIAT to trade. However, the bot itself can trade different pairs such as BTCBNB/XRPBNB.
The only issue with this feature is setting Max Purchase Amount. For convenience, the bot was simply setting 100 for the Max Purchase Amount. It is working for FIATs; however, it does not work for other pairs.
I did a bit of research and found each symbol has filters called MIN_NOTIONAL, which specifies the minimum order amount. Below is the example of XRPBNB.
{
    "filterType": "MIN_NOTIONAL",
    "minNotional": "0.10000000",
    "applyToMarket": true,
    "avgPriceMins": 5
}

I think the following changes can make this feature working.

Remove Max Purchase Amount from the global configuration.
When adding new coin pair, dynamically calculate Max Purchase Amount based on the minimum notional.

i.e. XRPBNB minimum notional (0.1) * 10 = max purchase amount (1)
i.e. BNBBTC minimum notional (0.0001) * 10 = max purchase amount (0.001)
i.e. BNBUSDT minimum notional (10) * 10 = max purchase amount (100)

If the trader wants to increase max purchase amount, then customise the symbol configuration.

Describe alternatives you've considered

Just keep trading with FIATs only.
Additional context

N/A

will this allow adding alternate pairs.
I want to track doge/btc

Hey @dodavies
It does already with the PR #77


Support Storybook

When I use .useContainer() in a component, Storybook complains that I have not given it a <Container.Provider>.
I have tried wrapping the Story with a Provider, but have had no luck. Have you ran into this issue before?

I don't use Storybook for performance reasons, so I'm not sure how to debug this for you without seeing some code. Mind showing me what you mean?

@liywjl you can use a global decorator to wrap all your stories with that provider.
Check:
https://storybook.js.org/docs/basics/writing-stories/

@liywjl you can use a global decorator to wrap all your stories with that container.
Check:
https://storybook.js.org/docs/basics/writing-stories/


add sc-explorer contribution

sc-explorer is live!

I tried it with this link: https://m.soundcloud.com/discover/sets/charts-top:rbsoul:us
And it didn't work, it said I'd listened to everything.  Any idea why?

I tried it with this link: https://m.soundcloud.com/discover/sets/charts-top:rbsoul:us
And it didn't work, it said I'd listened to everything. Any idea why?

Because the soundcloud widget doesn't work with the top 50 playlist apparently :/
One workaround could be to translate a top 50 into a playlist on the fly

I tried it with this link: https://m.soundcloud.com/discover/sets/charts-top:rbsoul:us
And it didn't work, it said I'd listened to everything. Any idea why?

Because the soundcloud widget doesn't work with the top 50 playlist apparently :/ One workaround could be to translate a top 50 into a playlist on the fly

Also if you notice, when you click share on a playlist on soundcloud web, there is an option to embed a player on a website. This option is not showed when you try to share a top 50 playlist. I think they are kind of "special" so the only solution could be to create a playlist on the fly! Or maybe we could pre-build some playlists as top 50 for all genres, and users could select one in alternative to providing a link to a playlist

Done! Fixed in commit 24c4190

Do you mind editing the links to point to the latest version?

Here you go :)

Awesome! Merging and paying now. It would still be nice to add https since my browser complains about the http security :P

Will do!


String replace issue in vue beautifier when script tag contains "$'"

Description
"$'" is replaced with ""
Problem seems to be the replace function in vue-beautifier.coffee line 53:
result = if beautifiedText then match.replace(replaceText, "\n#{beautifiedText.trim()}\n") else match

It looks like the same problem in https://stackoverflow.com/questions/36441837/bug-in-javascript-string-replace-with-replace-string
Input Before Beautification
This is what the code looked like before:
<template></template>
<script>
let a = '$'
</script>
<style></style>

Expected Output
The beautified code should have looked like this:
<template></template>
<script>
let a = '$'
</script>
<style></style>

Actual Output
The beautified code actually looked like this:
<template></template>
<script>
let a = '$</script>
</script>
<style></style>

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist: https://gist.github.com/Tmjk/e9bc8a66c6e9a7f4a57b0f52a3cad831
Checklist
I have:

[x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
[x] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

Same problem Oct 2018.  How can I get this working?

@sgehrman
This issue has closed, I think you might need to make a new issue if you care.


Minimum cancellation date is always +1 day from what you set it to

# app/models/solidus_subscriptions/subscription.rb

(actionable_date - SolidusSubscriptions.configuration.minimum_cancellation_notice).future?

If your minimum_cancellation_notice is set to one day, I would expect to not be able to cancel on the same day as the actionable_date, but I should be able to cancel the day before. However, because of the above code, I can't cancel on the day the subscription processes or the day before, effectively making the minimum cancellation notice 2 days, even though it's set as one.
(Date.tomorrow - 1.day).future?
# => false

Additionally, if you don't want a minimum_cancellation_notice, you would expect to be able to set it to 0.days. However, that still gives you a one day minimum cancellation notice.
(Date.today - 0.days).future?
# => false

Instead of checking if the date is in the future, it should also return true if the date is today.

Fixed with #178


Make retrospective spec replay

This spec only succeeded by chance—that the secondary set's initialization date took enough time to computer that it registered in as later than the primary's.

Thanks for spotting this - the t lifetime option is only used to setup the initialization date in a  replay context, as seen here. I should probably improve the design of the interface to not have conditional arguments depend on each other like this.

Got it—I thought that to be the case but was somewhat unsure, thanks for clarifying!


mWeb - Login- Continue button is not clickable after login with link and logout

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/19498
Action Performed:

Open NewDot on mWeb (Chrome/Android)
Login to any account using magic link (not code)
Logout
Input any email and click continue

Expected Result:
Continue button should be clickable
Actual Result:
Continue button is not clickable
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/7ecce183-1358-4d08-bea1-eec6ef5ea6da
Expensify/Expensify Issue URL:
Issue reported by: Applause - interna Team
Slack conversation:
View all open jobs on GitHub

asking if this should be separate - https://github.com/Expensify/App/issues/16301#issuecomment-1593510237

following - https://github.com/Expensify/App/issues/16301#issuecomment-1594082149

Tracking - https://github.com/Expensify/App/issues/16301#issuecomment-1594082149

Tracking - https://github.com/Expensify/App/issues/16301#issuecomment-1594082149

asking for an update - https://github.com/Expensify/App/issues/16301#issuecomment-1618926826

following the PR here - https://github.com/Expensify/App/issues/16301#issuecomment-1619447490

Following PR here - https://github.com/Expensify/App/pull/20708

@Christinadobrzyn Could you provide information on what this issue is? Only C+ is assigned to internal issue?

The internal label was auto-added because this issue is 4 weeks old. I was following this https://github.com/Expensify/App/pull/20708 which just went into production and in my testing, it resolved the issue.
Closing!


Bumped Node Version to 10.x. AWS Lambda deprecated its runtime suppor…

…t for Node.js 6.10 on April 30th, 2019[ref], and it has started to support Node.js 8.10.

Thanks @WillDent


[Suggestion] A per thread cache per allocation

Glibc has enabled this powerfull optimisation for their malloc/free.
https://www.phoronix.com/scan.php?page=news_item&px=glibc-malloc-thread-cache
It could be a big performance win if rust adopted something similar.
How would this overlap with the global allocator RFC ?

That article says it’s enabled by default for malloc(), so it looks like there is nothing to do on the Rust side. When std::alloc::System is used and glibc is recent enough, you should get that optimization. https://github.com/rust-lang/rust/issues/36963 is about making System the default. Until then you can force it with:
use std::alloc::System;

#[global_allocator]
static A: System = System;

it looks like there is nothing to do on the Rust side

(Closing for this reason, feel free to reopen or comment if there’s more.)


encode: implement Display for EncodeBuilder

Add implementation of core::fmt::Display for EncodeBuilder which tries
to avoid memory allocations when encoding sensibly small values
(specifically, shorter than 96 bytes).

Friendly ping.

@Nemo157, friendly ping


[WIP] Win32 test speedup

Disabling tool initialization in tests where those tools aren't needed.
Contributor Checklist:

[X] I have created a new test or updated the unit tests to cover the new/changed functionality.
[X] I have updated CHANGES.txt (and read the README.rst)
[X] I have updated the appropriate documentation

Rebasing after #4545 ought to make this go a lot faster - the last recorded run on this one was 34:46. We still want to know how much better the testsuite tweaks here make things.

Rebasing after #4545 ought to make this go a lot faster - the last recorded run on this one was 34:46. We still want to know how much better the testsuite tweaks here make things.

Done.


cloud-nuke: 0.7.3 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/gruntwork-io/cloud-nuke/releases.
meta.description for cloud-nuke is: "A tool for cleaning up your cloud accounts by nuking (deleting) all resources within it"
meta.homepage for cloud-nuke is: "https://github.com/gruntwork-io/cloud-nuke"
meta.changelog for cloud-nuke is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1/bin/cloud-nuke had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.9.1 with grep in /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1
found 0.9.1 in filename of file in /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cloud-nuke

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cloud-nuke https://github.com/r-ryantm/nixpkgs/archive/ea36532b50dd166d80969a99bbead4e0c24fec50.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1
ls -la /nix/store/7h4w3sq47gyl0f40pz4wqkc6bnhnbhl9-cloud-nuke-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cloud-nuke

Maintainer pings
cc @marsam @kalbasit for testing.

@ofborg eval

@ofborg eval


config-client no need @RefreshScope

clould : Finchley.RELEASE
boot : 2.0.2.RELEASE
refreshing configuration files at the receiving end without no need @RefreshScope annotation
this is my public git address ： https://git.imooc.com/wmy/private-error-order.git
contain eureka config-server(config) config-client(order)
demo url in order project http://<IP_ADDRESS>:9002 /girl/print
configuration file use order-dev.yml in https://gitee.com/halfroom/config-repo.git
!!!!!! manually refresh bus address after configuration change
http://<IP_ADDRESS>:9091/actuator/bus-refresh

Configuration properties have never needed the refresh scope annotation.

in Finchley.M2  version need it not?
i have a demo   need  the refresh scope annotation  in   Finchley.M2  version

M2 is a milestone. Try SR3

非常感谢


Unable to setup

Hi, I have followed the instructions to setup via HACS, that all went smoothly but when I try to create the integration, using my API key I get the following error in the log.
I am running home assistant core 2023.12.2
This looks like a great integration but cant work out the error.
Logger: aiohttp.server
Source: /usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py:421
First occurred: 22:34:35 (1 occurrences)
Last logged: 22:34:35
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 233, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 149, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 63, in with_admin
return await func(self, request, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 177, in post
return await super().post(request, flow_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
result = await method(view, request, data, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
result = await self._flow_mgr.async_configure(flow_id, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 293, in async_configure
result = await self._async_handle_step(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 422, in _async_handle_step
result = await self.async_finish_flow(flow, result.copy())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 978, in async_finish_flow
title=result["title"],
~~~~~~^^^^^^^^^
KeyError: 'title'

It looks like there should have been another error logged before that. Can you check your logs again around the same timestamp as this one (22:34:35)?
Also from the TeslaFi API settings screen, confirm that you can click on the link at the bottom and see data for your car, and that the token in the URL matches the API token you're pasting in the config flow (just the token itself, not the rest of the URL)

@tomganleylee anything?

Hi,
thanks for getting back to me, sorry in my slow response.
i tried again after clearing the logs. and generating a new API token. What is strange is we have 2 Tesla's and 2 Teslafi accounts, the 2nd account was added in with no problem. It is just mine. i have attached all the logs that came up when i tried to add it.
I clicked the link and it showed data, I had previously added data from teslafi into home assistant using a rest sensor and that was working fine, however, for some reason, not all the data is there now. I don't know if this is a teslafi issues.
is there another log I should be checking?
Log Details (ERROR)
Logger: aiohttp.server
Source: /usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py:421
First occurred: 23:08:14 (1 occurrences)
Last logged: 23:08:14
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 233, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 149, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 63, in with_admin
return await func(self, request, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 177, in post
return await super().post(request, flow_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
result = await method(view, request, data, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
result = await self._flow_mgr.async_configure(flow_id, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 293, in async_configure
result = await self._async_handle_step(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 422, in _async_handle_step
result = await self.async_finish_flow(flow, result.copy())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 978, in async_finish_flow
title=result["title"],
~~~~~~^^^^^^^^^
KeyError: 'title'

Can you check:

What version of the TeslaFi integration you have installed from HACS?
Try enabling debug logging for the integration (you can enable debug logging from the first car that was added successfully) and then try adding the 2nd car. It should add some additional information to the logs, including API responses.

If that doesn't yield additional info, you could try copying the JSON response you get when you click the link from the TeslaFi API Settings screen (obfuscate if you'd like). I'm interested in trying to reproduce the scenario that would lead to the config flow response having no title.

Sure thank you :

v2.2 (HACS says it is up to date)
it didn't seem to gain any additional info in the logs

Log Details (ERROR)
Logger: aiohttp.server
Source: /usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py:421
First occurred: 23:33:50 (1 occurrences)
Last logged: 23:33:50
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 543, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 233, in auth_middleware
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 149, in handle
result = await handler(request, **request.match_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 63, in with_admin
return await func(self, request, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 177, in post
return await super().post(request, flow_id)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
result = await method(view, request, data, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
result = await self._flow_mgr.async_configure(flow_id, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 293, in async_configure
result = await self._async_handle_step(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 422, in _async_handle_step
result = await self.async_finish_flow(flow, result.copy())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 978, in async_finish_flow
title=result["title"],
~~~~~~^^^^^^^^^
KeyError: 'title'
the link gives this, which is odd as when i read the data from home assiant i get a lot of data, not sure if its different data though>?
{"data_id":351****,"Date":"2023-12-17 23:40:32","calendar_enabled":"502","remote_start_enabled":null,"vehicle_id":null,"display_name":null,"color":null,"fast_charger_brand":null,"notifications_enabled":null,"vin":null,"conn_charge_cable":null,"id":null,"charge_port_cold_weather_mode":null,"id_s":null,"state":"offline","option_codes":null,"user_charge_enable_request":null,"time_to_full_charge":null,"charge_current_request":null,"charge_enable_request":null,"charge_to_max_range":null,"charger_phases":null,"battery_heater_on":null,"managed_charging_start_time":null,"battery_range":null,"charger_power":null,"charge_limit_soc":null,"charger_pilot_current":null,"charge_port_latch":null,"battery_current":null,"charger_actual_current":null,"scheduled_charging_pending":null,"fast_charger_type":null,"usable_battery_level":null,"motorized_charge_port":null,"charge_limit_soc_std":null,"not_enough_power_to_heat":null,"battery_level":null,"charge_energy_added":null,"charge_port_door_open":null,"max_range_charge_counter":null,"charge_limit_soc_max":null,"ideal_battery_range":null,"managed_charging_active":null,"charging_state":null,"fast_charger_present":null,"trip_charging":null,"managed_charging_user_canceled":null,"scheduled_charging_start_time":null,"est_battery_range":null,"charge_rate":null,"charger_voltage":null,"charge_current_request_max":null,"eu_vehicle":null,"charge_miles_added_ideal":null,"charge_limit_soc_min":null,"charge_miles_added_rated":null,"inside_temp":null,"longitude":null,"heading":null,"gps_as_of":null,"latitude":null,"speed":null,"shift_state":null,"seat_heater_rear_right":null,"seat_heater_rear_left_back":null,"seat_heater_left":null,"passenger_temp_setting":null,"is_auto_conditioning_on":null,"driver_temp_setting":null,"outside_temp":null,"seat_heater_rear_center":null,"is_rear_defroster_on":null,"seat_heater_rear_right_back":null,"smart_preconditioning":null,"seat_heater_right":null,"fan_status":null,"is_front_defroster_on":null,"seat_heater_rear_left":null,"gui_charge_rate_units":null,"gui_24_hour_time":null,"gui_temperature_units":null,"gui_range_display":null,"gui_distance_units":null,"sun_roof_installed":null,"rhd":null,"remote_start_supported":null,"homelink_nearby":null,"parsed_calendar_supported":null,"spoiler_type":null,"ft":null,"odometer":null,"remote_start":null,"pr":null,"climate_keeper_mode":null,"roof_color":null,"perf_config":null,"valet_mode":null,"calendar_supported":null,"pf":null,"sun_roof_percent_open":null,"third_row_seats":null,"seat_type":null,"api_version":null,"rear_seat_heaters":null,"rt":null,"exterior_color":null,"df":null,"autopark_state":null,"sun_roof_state":null,"notifications_supported":null,"vehicle_name":null,"dr":null,"autopark_style":null,"car_type":null,"wheel_type":null,"locked":null,"center_display_state":null,"last_autopark_error":null,"car_version":null,"defrost_mode":null,"autopark_state_v2":null,"is_preconditioning":"","inside_tempF":"","driver_temp_settingF":"","outside_tempF":"","battery_heater":"","Notes":"Offline Asleep","odometerF":"","idleNumber":0,"sleepNumber":4016,"driveNumber":0,"chargeNumber":0,"polling":"","idleTime":0,"maxRange":"309.95","left_temp_direction":null,"max_avail_temp":null,"is_climate_on":null,"right_temp_direction":null,"min_avail_temp":null,"is_user_present":null,"in_service":null,"valet_pin_needed":null,"charge_port_led_color":null,"timestamp":null,"power":null,"side_mirror_heaters":null,"wiper_blade_heater":null,"steering_wheel_heater":null,"elevation":"","sentry_mode":"","fd_window":"","fp_window":"","rd_window":"","rp_window":"","measure":"imperial","temperature":"C","currency":"\u00a3","carState":"Sleeping","location":"Home","rangeDisplay":"rated","newVersion":" ","newVersionStatus":""}

One thing i have just noticed is that teslafi, doesn't seem to see what my car's name is and is just blank where the name is on the fleet management page

Working now!!
After seeing noname at all, i went a set the name back., (unsure why the name field was empty, and not what i called the car)
but it is now added!!!
thank you for your help, wouldn't have worked that out alone

Yeah that json doesn't have any data that we need: namely vin and display_name are the bare minimum.
Glad you got it sorted out, but super strange that it behaved this way.
I wonder if maybe something about it being asleep was breaking it 🤔 like maybe what fixed it might have been waking the car. In your json the only actual usable data I can see is that the car state is "Sleeping".


Timeout isn't properly applied to a query in a clone()

Postgres
Knex (latest)
When applying timeout method to the query builder, it appears to get lost in a clone statement. See below:
This code does NOT work
void baseQuery.timeout(5000, { cancel: true });

	// <Array<{ cnt: number }>>
	const count = await baseQuery
		.clone()
		.countDistinct('plant.id as cnt')
		.timeout(5000, { cancel: true })
		.then(([res]) => (res && res.cnt) || 0);

This code works
	// <Array<{ cnt: number }>>
	const count = await baseQuery
		.clone()
		.countDistinct('plant.id as cnt')
.timeout(5000, { cancel: true })
		.then(([res]) => (res && res.cnt) || 0);

Should be a second option to cancel like propagate, so any queries using it as a subquery for example will 'inherit' the highest timeout restriction


Silence clippy::let_underscore_untyped lint

with this PR, the build is fixed and bypass/admin merge is disabled.


Make resources page inaccessible in standalone mode

Fixes https://github.com/dotnet/aspire/issues/1556
Standard alone dashboard displayed an empty resources page. This PR updates the app to take the user directly to the structured logs page. It becomes the new default page.

Server redirects browser directly to structured logs.
Prevent Blazor app from navigating to resources page in browser.

Microsoft Reviewers: Open in CodeFlow

cc @davidfowl I noticed the resource page was still available when testing out https://github.com/dotnet/aspire/pull/2199. Simple fix is to redirect access to it to a telemetry page.


Update index.js

Testing Now + GitHub integration

Moved project to AWS using @probot/serverless-lambda. Closing PR.


[WIP] Configurable Panel Position

Let's make the Bottom panel position configurable to bottom or side-by-side.
Also, integrate it as an editor tab which can be a with tabs carry arranged with tabs when set to side-by-side mode.

@isidorn let's get this done in two iterations.

@AkashGutha thanks for showing interest in this. In order to tackle this we need to come up with a solution that looks good both horizontaly and verticaly. Notice that we currently have tabs on top of the panel - how would those tabs look in reduced vertical space? We would probably need some overflow design.
In your comment you are suggesting that the panel should be treated the same way as any editor with regards to layout. However I think that would only complicate our life and would not provide big benefits to the user. VS Code has limited flexibility when it comes to layouting and I believe the right approach would be to let the Panel be either at the bottom or to the very right.
My proposal is that at the top of the panel we would introduce an action that toggles the dock position (similar to what Chrome dev tools have, but we would only have 2 states to start). That action would just switch a boolean in the layout.ts and depending on that value the layout would either layout the panel horizontally to the bottom or vertically to the side.
If we end up with a solution that does not look or feel good we will have to reject it.
Let me know what you think.
fyi @stevencl @bpasero

@isidorn Yes, definitely like the chrome inspect tab.
is there a specific person that is can to talk about existing implementation of the SashLayout.
And for the reduced horizontal space, how about using a combo box just like the terminal.
The only caveat I see is confusion when using it in terminal mode, where you might end up having two combo boxes sitting next to each other. Having said that, it may be intuitive to most of the devs.

@AkashGutha you can talk to me about the SashLayout and about any other questions you may have. If I do not know something I will find out.
But I think there is already a vertical Sash which you can use. So idealy this would require no changes to the Sash.
As for the reduced horizontal space, I think we should tackle that in step2. But showing some overflow as we do in the activity bar makes sense to me.

Also any changes you make to vscode should be easy to just try out. Just have continues build running and run vscode out of source as described here.

fyi @egamma

integrate it as an editor tab

We should not include this in this change, there is a larger discussion that needs to happen on whether to pull parts of the panel into an editor tab.

similar to what Chrome dev tools have, but we would only have 2 states to start

This :+1:

what about embedding a terminal into an editor tab (after splitting)? seems a bit overkill to have to redo so much of the UI just for this.

@Tyriar @heisian Please don't use editor tabs for this.

seems a bit overkill to have to redo so much of the UI just for this

I don't think so, here is why...
An editor tab is made for editing source files, and only that.
A Terminal has nothing to do with that. A terminal should be differentiated because its usage / life span / side-effects are obviously different. It generally stays alive during the whole session, running external processes and should be easily toggleable for quick access.
Embedding it in an editor tab would make this typical use case very tedious to achieve. I've used Atom a lot, and many extensions use this editor tab pattern. It ends up in a catastrophic user experience where you constantly have to maintain a splitted region where you put all your other stuff. Of course this region is not toggleable, so it basically eats a whole part of the screen for things you only get to access 10% of the time.
It's like mixing apples and oranges.
The current way of presenting the terminal is very good, a toggleable pane. It only needs a way to dock itself to other locations. Lots of editors (including Visual Studio) have done this for decades, for a good reason I believe.

@ngryman good points - was merely suggesting a shortcut to the actual solution & agree it can get pretty problematic. plus anything that brings things closer to the way atom does things (and I loved & used it for years) could be a bad thing :P

It ends up in a catastrophic user experience where you constantly have to maintain a splitted region where you put all your other stuff.

@ngryman this is basically my stance on the topic; it's a lot easier to manage the terminal when there's only a single place for it and all commands act on that single area. This combined with the ability to split a terminal instance inside the panel https://github.com/Microsoft/vscode/issues/7504 is where I would like to see this go.

IMO, that's not really a good enough solution for this.  Sometimes I like to use VSCode in a window that's much wider than it is tall, and it would be really nice if the terminal could be on one of the sides.  This, IMO, is not really usable at all:

It'd be really awesome if the terminal could be in all of that wasted space to the right and not taking up half of my view at the bottom.  Something similar to how kdevelop allows its konsole tab to be placed on either the sides or the bottom would be really nice.

@simoniz0r i'm pretty sure that's exactly what this pull request is about doing.

@heisian @Tyriar I think we all agree on the features of this PR. How could we speed things up? Are there remaining points to clarify?
@AkashGutha Are you still working on this? Do you need some help?

@ngryman I'm quite busy with a few things. it will probably take one or two months before I even get started on this.
If anyone is interested they can take over this. :)

@AkashGutha Alright thanks for the explanation.
@Tyriar @heisian Any pointers in docs/code to help me understand how it's done now and some ideas on how to implement this? I'll be happy to address this but I would need some insights first.

@isidorn will be the main contact on this PR

There are some prerequests before this can be done, namely https://github.com/Microsoft/vscode/issues/31503
Once that is tackled we will invest into this. As for code pointers checkout my initial comment

@ngryman if you check the file changes in this PR. you'll find the exact location of the terminal layout implementation and a starting point on how we can convert the existing Sash into the way we want it to function.
in the repo the file is at this location
src/vs/workbench/browser/layout.ts
Currently the Sash implementation is fixed to have one in Y and on in X.
SashY is used for the file menu/git/find et etc
SashX is used for the terminal.
We have to remove the SashX as a  tight dependecy for the terminal and make it usable by both X and Y.
@isidorn correct me / add to this if we can find any other useful information.

i was poking around in terminal.ts (found in two locations) as well as search.ts to get a sense of how both initialize themselves in their respective locations. still need to put more time into it. also glanced at @AkashGutha 's changes. will take a look at the PR @isidorn mentioned soon.

Thanks guys. So, wrapping up.
To do:

[ ] Add a dock positions action, bottom and right for now.
[ ] Handle tabs overflow like in activity bar.

Questions:

[ ] How do we handle the case when the sidebar is put right? Do we swap the panel left or do we stack it right?

I've started to dive into the code and the layout part could use a refactoring so it's less cryptic. Are you planning to do so?

@ngryman go ahead with the changes. we need those changes desperately.

@ngryman thanks for looking into the code, however I would recommend that you all wait a bit since I am looking into some feature which is a prerequest for this. Once that is done I will dive into this one. Refactoring the layout part that it still has the same functionality but is less cryptic we could accept as a seperate PR. Though before submiting code for that I would recommend you creata a PR where we first discuss what you plan to do.

@isidorn Gotcha, I guess the layout code would need some cleanup before we had more complexity to it. I'll be glad to discuss about it in another PR.

@chryw I am slowly starting to look into this feature. Could you maybe look into the icon for this, as you can see in my comment from above we would need two different icons, one that reprsents moving the panel to the right and one to be bottom. Both for light and dark version.
I have started with RightColumnOfTwoColumns_16x and BottomRowOfTwoRows_16x from the VSicons, but not sure if they fit perfectly. Also there is none for the dark theme

@isidorn Thank you so much to address this one. I personally did have time to dig into this lately, and the time I climb that learning curve, you'll have finished this PR and have 2 kids 😂

@isidorn I think those icons make sense. I attached VS Code version svg files.
PanelPositionIcons_vscode.zip

@chryw awesome, thanks

Closing this in favor of https://github.com/Microsoft/vscode/pull/36827


gnome-disk-utility: fix missing schemas for gnome-disk-image-mounter

Continuation of #28053
gnome-disk-image-mounter from gnome-disk-utility was not wrapped, resulting in an error due to the inability to find gsettings schemas.
This commit replaces the manual wrapping of gnome-disks binary with wrapGAppsHook so that all binaries are wrapped correctly.

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @globin @fpletz @vcunat

This should be also merged to 17.09

This should be also merged to 17.09

Done: fd1b9e357db7241e1bc290f2fb109c8812c77ff2


Getting warnings with Xcode 7.3

Thanks for pointing this out! We'll update for our next release.

@faarwa selector syntax updated. Do merge the request! Thanks! :)

Fixed in 0.5.0


Modifying the dashboard build error

What this PR does / why we need it:
Modifying the dashboard build error
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
@xing-yang @leonwanghui
Release note:

There is no code change in the PR, please take a look.


fix: import lib and code format

fix(style): mr page style modification.
feat: import zustand and a simple example that might be used.
import antd lib
code format by ECMA specification
update README.md

Variables that do not change should be declared using const, and declaring variables using var is not recommended. See: https://javascript.info/var

Modified and added configuration to support pnpm and docker builds.


enable TLS client forwarding

Copys the incoming TLS client certificate to the outgoing
request. The backend can then use this certificate for
client authentication ie. k8s client cert authentication
fixes #1392

Ping @drewwells ?

there were some non-trivial changes to server.go, not sure I will get these conflicts merged correctly.

would it be enough to simply forward the subject of the certificate...
i did a pull request for the underlying proxy library to enable this
https://github.com/vulcand/oxy/pull/68

@timoreimann do you validate this PR finally (even with the conflict)?

Any time frame for merge?

@zyclonite that MR turns off SSL verification

This MR conflicts again, is there any interest in supporting this feature? We have moved on and no longer use Traefik b/c this feature was missing.

@drewwells @samgurtman sorry if it takes some time.  We will merge it for sure, but be patient.

Ping @timoreimann

@emilevauge I approved a few days ago. Your LGTM is still missing. 😀

@timoreimann oops, sorry. Was looking from my mobile phone, and reviews are not visible 😊

Closing & reopening to enable Semaphore CI

Great, thanks!
On Sun, Jun 11, 2017 at 8:24 AM Ludovic Fernandez<EMAIL_ADDRESS>wrote:

Merged #1446 https://github.com/containous/traefik/pull/1446.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containous/traefik/pull/1446#event-1118525252, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOmE85fX_i27sP-B_L0U-pok5EN12yGks5sC-qTgaJpZM4M_P_F
.

Fantastic! Thanks for this! We can fully transition to Traefik now.

I'm trying this on Docker Swarm, but adding the label "traefik.frontend.passTLSCert=true" has no effect. Is this to be expected?

@samgurtman, in fact, @drewwells didn't add any label in this PR. We would love if you could help us on this in a new PR :heart:

Could you point me to an example of an existing label implementation I can base it off of?

@samgurtman you can have a look at traefik.frontend.passHostHeader in  https://github.com/containous/traefik/blob/master/provider/docker/docker.go which should be similar :)

Well originally this was a POC, but it took months to get the code merged. Maybe somebody with write access can add the other labels. Unless you want labels sometime in September :)

Maybe somebody with write access can add the other labels. Unless you want labels sometime in September :)

Maintainers (who have write access) are also making PR and it can take some time to get merged. We are a small team dealing with many contributions. We prefer carefully reviewing every PR than merging on the hoof.
And by the way, you were not that responsive  either !

So I added the label handling for docker, and I can confirm the passTLSCert stuff is being triggered, but I see no effects in the headers passed to my downstream server. Has this been smoke tested, and can someone confirm it is actually working with traefik.toml configuration?

This PR is merged. Please open a new issue or discuss this in :

Stack Overflow using the "traefik" tag
the Traefik community Slack channel

Ok, I guess I won't contribute a PR then...

@samgurtman we just asked you to come discuss we us somewhere else as this PR is closed. If you think there may be an issue on this, we would love to hear you on Slack instead.

I have indeed posted on slack already. I'd love to here from you there.
On 22/06/2017 9:10 PM, "Emile Vauge"<EMAIL_ADDRESS>wrote:

@samgurtman https://github.com/samgurtman we just asked you to come
discuss we us somewhere else as this PR is closed. If you think there may
be an issue on this, we would love to hear you on Slack instead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containous/traefik/pull/1446#issuecomment-310323136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGIKX4mgVQZktgXVM_VOZkYO2ElFExZWks5sGi-SgaJpZM4M_P_F
.

Pretty confused about how I find out if this issue is resolved, or rather, how to implement the resolution, and by traefik documentation in general, tbh.

Thank you for you support !
This is a closed pull request, please open an issue or come on the slack channel to talk with the community.

I'm also confused if this suppose to work.
Google leads me here, so maybe you (eg. @emilevauge) can comment on the current state of the implementation to not confuse others as well.
I'd expect:

the latest version to have that feature included: https://store.docker.com/images/traefik
to set label traefik.frontend.passTLSCert=true on my backend container
is any of that assumptions wrong?

@MichaelSp

this feature will be in the next release (1.4)
the label must be set on the frontend not the backend.

Thanks for your interest in Traefik 😃
This issue is closed. Please open a new issue or discuss this in :

Stack Overflow using the "traefik" tag
the Traefik community Slack channel


Fallback to ADMINS when BASKET_MANAGERS undefined

Coverage increased (+0.03%) to 92.602% when pulling 9b22fc8bd7331670b6d0e93b55318d7928e50979 on johngian:1282809 into 452ea4f49165145de2c8c57452d3218a80924339 on mozilla:master.

@akatsoulas r?

r+wc

Coverage increased (+0.03%) to 92.607% when pulling a96ce721ac58d551a9f847185b34b7a8102b02e8 on johngian:1282809 into 564ad3cad7dd6ba62ed46aa2fca0520c5d33edee on mozilla:master.


Constructing edge index for graph convolution (Undirected vs directed)

❓ Questions & Help

Hello,
Say I were to construct my own edge index to pass into a graph conv layer. If my graph is undirected, then does the edge index need to contain a pair going both ways? Or is one okay?
I will be using the transposed view for my example
Does the edge_index need to be:
edge_index = [[1,2], [2,1]]
or is the following okay?
edge_index = [[1,2]] or edge_index = [[2,1]]

The edge_index needs to contain a pair going both ways.

Thank you!


999 time-lapse images with FDR-AX53

The maximum amount of images for a single time-lapse is 999 with this camcorder (and probably many others too). It would be very useful for my purposes if this could be increased to something like 9999, or even better, unlimited. Maybe change it so that if the user sets the amount to 999, it is instead  set to 9999? For a shorter timelapse one could then just set it to 998 instead.

Hi ! Sorry but how do you installed the timelapse app on AX53 ? I can use the tweaks panel of the program to switch between pal and ntsc mode but when I enable the "enable usb app installer" option I can't install app after. Do you know the way to achieve this ?
Thanks a lot

I was just using the built-in time lapse functionality, I don't know if/how it's possible to install apps on the AX53.


Allows the creation of empty SSE events

Description
Allows an SSE event to be created using no data. Uses a static constant SseEvent.NO_DATA to avoid returning null in getters. Updates serialization code and tests. See issue #9165.

The changes look fine to me, although I do have one question.
I see the writer of the issue cited the SSE spec saying that "empty" events are legal.
I know very little about SSE, but is it in any way a potential problem that the SseEvent data for an empty event would contain this special constant value (as opposed to having no value at all)? For example, does this distort some representation of the event size or length or something like that that could otherwise be used to infer an "empty" event?

The code in SseSink currently checks for that constant and does not serialize anything into the stream. Would that answer your question?

Yes. Thanks.


Enable coveralls in CI

Checking if this works out of the box for open source projects.

LG! I can see coverage here: https://coveralls.io/jobs/109315969
Not sure how to get it to comment on the PR though.

I'm hoping it's just an issue of initial PR not having a baseline to compare to.


fix: create-and-append subprocess(expanded) icon error

Proposed Changes

Checklist
To ensure you provided everything we need to look at your PR:

[x] Brief textual description of the changes present
[ ] Visual demo attached
[ ] Steps to try out present, i.e. using the @bpmn-io/sr tool
[ ] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Thanks for your contribution! I corrected the commit message to adhere to conventional commits https://www.conventionalcommits.org/


Does this work with lazy loaded modules?

I have an Angular 5 + NGRX v4.x app that uses lazy loaded module + the per feature store states.
I can't get it working as it keeps throwing the error The form state must not be undefined!.
Does ngrx-forms work with this combination?

I am doing same and works fine. Can you post snippet of your reducer? Please make sure you are creating default ngrx-form state in your initial reducer state.

reducer:
    'cospace-template',
    new TemplateViewModel()
);

export function reducer(state = initialState, action: editTemplateActions.Actions): FormGroupState<TemplateViewModel> {
    switch (action.type) {

        case editTemplateActions.FETCH_COMPLETE:
            return createFormGroupState<TemplateViewModel>(
                'cospace-template',
                action.payload
            );

        default:
            return state;
    }
}```

export interface State {
templates: TemplateListViewModel[];
meta: TemplateMetaViewModel;
template: FormGroupState;
}
export const reducers = {
templates: fromList.reducer,
meta: fromMeta.reducer,
template: fromEdit.reducer
};
export const getTemplateState = createFeatureSelector('cospace-template');
export const getTemplates = createSelector(getTemplateState, (state) => state.templates);
export const getMeta = createSelector(getTemplateState, (store) => store.meta);
export const getTemplate = createSelector(getTemplateState, (store) => store.template);```

how did you defined your initialState const?

sorry, MD formatting issue. updated snippets

and inside the component:
import { Component } from '@angular/core';
import { Observable } from 'rxjs/Observable';
import { Store } from '@ngrx/store';
import { FormGroupState } from 'ngrx-forms';
import * as templateState from '../../reducers';
import * as editTemplateActions from '../../actions/edit';

export class EditComponent {

    public template$: Observable<FormGroupState<AcanoTemplateViewModel>>;
    public meta$: Observable<AcanoTemplateMetaViewModel>;

    constructor(private store: Store<templateState.State>) { }

    public ngOnInit(): void {
        this.template$ = this.store.select(templateState.getTemplate).distinctUntilChanged();
        this.meta$ = this.store.select(templateState.getMeta).distinctUntilChanged();
    }

....
}

Initial setup looks fine... Are you getting error on initial load or when FETCH_COMPLETE action finishes? Make sure payload has data. Also, can you post TemplateViewModel definition? Btw, you are missing ngrx-form action processing, see formGroupReducer() usage from docs...
export function appReducer(state = initialState, action: Action): AppState {
  const myForm = formGroupReducer(state.myForm, action);
  if (myForm !== state.myForm) {
    state = { ...state, myForm };
  }

  switch (action.type) {
    case 'some action type':
      // modify state
      return state;

    default: {
      return state;
    }
  }
}```

If I comment out the dispatch for FETCH (effect then does a http get and dispatches FETCH_COMPLETE with the model) it still happens.
I've added the formGroupReducer() to no effect like so:
export const initialState = createFormGroupState<TemplateViewModel>(
    'template',
    new TemplateViewModel()
);

export function reducer(state = initialState, action: editTemplateActions.Actions): FormGroupState<TemplateViewModel> {
    const myForm = formGroupReducer(state, action);
    if (myForm !== state) {
        state = { ...state, ...myForm };
    }

    switch (action.type) {

        case editTemplateActions.FETCH_COMPLETE:
            return createFormGroupState<TemplateViewModel>(
                'template',
                action.payload
            );

        default:
            return state;
    }
}

The definition of TemplateViewModel is rather large. I might try swapping to a smaller class.
I wonder if it's because I do new TemplateViewModel() rather than making an object like your examples? ({ foo: 'bar', bar: 'foo' ... })

I was thinking same, in my projects I am not using typescript classes for any of NGRX states, only interfaces and regular functions for object default construction (instead of class constructors). I would just make simple interface with one or two properties and getting that running, and only then, I would start enhancing model slowly with your expected ViewModel's data...

Swapped to:
export class TemplateViewModelSimple {
    public name: string;
    public description: string;
}

and
export const initialState = createFormGroupState<TemplateViewModelSimple>(
    'template',
    {
        name: '',
        description: ''
    } as TemplateViewModelSimple
);

and still the error.

Ah god. I've got it, I had a copy paste issue:
<form #templateForm="ngForm" novalidate class="horizontal-form" [ngrxFormState]="(formState$ | async)">

rather than:
<form #templateForm="ngForm" novalidate class="horizontal-form" [ngrxFormState]="(template$ | async)">

D'oh.

nice ;) was not expecting issue there ;)

@nihique thanks for helping out on this
@philjones88 to catch these issues earlier in the future you can use ahead-of-time compilation which will also check your templates to see if you are referencing any invalid variables. If you are using Visual Studio Code you can also use the Angular Language Service extension that will highlight such issues already when writing the code.


Rise from PEEP to PIP in 100 ms in pressure assist mode

Reuse of the code from pressure control mode.
I assumed that RISE_TIME is not dependent on the ventilator mode, please correct me if I am wrong.

I assumed that RISE_TIME is not dependent on the ventilator mode

That's my assumption as well.


Expand travis coverage, drop jeweler

Hey @oscardelben, I wanted to get your quick opinion on this change. The big change here is dropping jeweler. It's not really appropriate to have Gemfile.lock present in a library gem, since that should be handled by the gemspec. Using jeweler to generate the gemspec from the Gemfile was making it harder to reason about what the library was doing, so I think it's much simpler this way.
This will make it a teensy bit harder for you to deploy new versions, since you'll have to run gem build yourself, but not much harder.
This also drops ruby 1.8.7 from travis while adding a couple newer versions. We need this to merge #66 while keeping tests green, and httpclient is currently breaking the build on 1.8.7. However, 1.8.7 has fallen entirely out of support and probably should be removed anyway.

Hey Vincent,
Please go ahead with this change. Thanks!


Only strings, FileObjects and UploadedFileObjects can be imported

My OS is windows 10,
1、There is an error when running php artisan db:seed,as follow:
dell@DESKTOP-MVU77SM MINGW64 /d/wnmp/www/vuedo
$ php artisan db:seed
Seeded: RolesSeeder
New Admin created. Username<EMAIL_ADDRESS> Password: 123pass
Seeded: UsersSeeder
Seeded: PostsSeeder

  [Spatie\MediaLibrary\Exceptions\FileCannotBeImported]
  Only strings, FileObjects and UploadedFileObjects can be imported

2、ignoring the first error,accessing homepage(http://vuedo.app/) ,there is an error, as follow:
RuntimeException in EncryptionServiceProvider.php line 45:
No supported encrypter found. The cipher and / or key length are invalid.

Did you run php artisan key:generate?


Offline configuration for buildPythonApplication

I use mach-nix.buildPythonApplication to install a python cli utility (called locust) from GitHub. Whenever I enter the nix-shell, the following check is performed by mach-nix:
~/proj $ nix-shell
trace:
 automatically detected requirements of locust:1.4.3 20.03post-git:
gevent>=20.9.0
flask>=1.1.2
Werkzeug>=1.0.1
requests>=2.9.1
msgpack>=0.6.2
pyzmq>=16.0.2
geventhttpclient>=1.4.4
ConfigArgParse>=1.0
psutil>=5.6.7
Flask-BasicAuth>=0.2.0

[nix-shell:~/proj]$

This check happens every time when I enter the nix-shell. If I am disconnected from the internet, then nix-shell fails, because of this check, that evidently requires an internet connection.
Is this a bug, or a misconfiguration of mach-nix on my part?
Here are the relevant nix derivations:
locust/default.nix:
{ buildPythonApplication, fetchFromGitHub, lib }:

buildPythonApplication rec {
  pname = "locust";
  version = "1.4.3";

  src = fetchFromGitHub {
    owner = "locustio";
    repo = "locust";
    rev = "${version}";
    sha256 = "06nxfa20234yyy1m8kyzdqblam2ym05j7hkghhj7ga5awy69cb2z";
  };

  meta = with lib; {
    license = licenses.mit;
    homepage = "https://github.com/locustio/locust";
    description = "";
    maintainers = with maintainers; [ locustio ];
  };
}

mach-nix/default.nix:
{ pkgs, python, fetchFromGitHub }:

let
    version = "3.1.1";

    src = fetchFromGitHub {
        owner = "DavHau";
        repo = "mach-nix";
        rev = "${version}";
        sha256 = "06bxmz7x1fnjx2d0gb63fdm0jci2mcdnpa3isbhjr92z1l2a7hl1";
    };

    mach-nix = import src {
        inherit pkgs;
        inherit python;
    };

in mach-nix

shared.nix:
{ sources ? import ./sources.nix }:
let
  pkgs = import sources.nixpkgs { };

  python = pkgs.python38;
  python_ver = "python38";

  mach-nix = import ./mach-nix/default.nix {
    inherit pkgs;
    inherit (pkgs) fetchFromGitHub;
    python = python_ver;
  };

  locust = import ./locust/default.nix {
    inherit (pkgs) lib fetchFromGitHub;
    inherit (mach-nix) buildPythonApplication;
  };

in
{
  inherit pkgs;

  devTools = {
    inherit python;
    inherit locust;
  };

}

shell.nix:
{ project ? import ./shared { }
}:

project.pkgs.mkShell {
  buildInputs = builtins.attrValues project.devTools;
}

Hey, thanks for reporting this.
With the current stable version of nix, nix evaluations itself are not cached, only store outputs are. nixFlakes fixes that to some degree (https://www.tweag.io/blog/2020-06-25-eval-cache/).
Any other shell.nix will also be re-evaluated when you execute nix-shell. Usually those just don't print anything to stdout, so you might not notice it. Another reason why this might be more noticable with mach-nix is because it does import from derivation, which slows down evaluation.
The expression should not  require online access though, as all your fetching is pure. Which request fails in your case? What is the error?
BTW, if you install direnv + nix-direnv, it will cache the nix evaluations and offline use shouldn't be a problem.

BTW, if you install direnv + nix-direnv, it will cache the nix evaluations and offline use shouldn't be a problem.

Thanks for the tip!

The expression should not require online access though, as all your fetching is pure. Which request fails in your case? What is the error?

I tried to duplicate the error now upon your request, by manually disconnecting from the network...and no error occurred this time. To force the error, I did a nix-collect-garbage followed by nix-shell, and even though this was not the error, it was the same type of error:
warning: unable to download ...

I think the error mentioned something about pypi-deps-db.
I'm sorry for wasting your time. Clearly the error was a misconfiguration on my side (maybe caused by a nix garbage collect). Thanks for your response.


Pantheon uses icons and settings from previous GNOME session

Issue description
I upgraded to 19.03 and switched from GNOME 3 to Pantheon.
I noticed that the elementary icons are not used.

the menu icons are also strange:

and the window decoration is huge for some apps:

With gnome-tweaks you see, that the default gnome theme and icons are used. I can set them to Elementary.

@worldofpeace can you provide a one-liner to reset the settings and add it to the NixOS manual?
Steps to reproduce

use gnome
then use pantheon

Technical details

system: "x86_64-linux"
host os: Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(davidak): ""
channels(root): "nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Pantheon has the exact code hidden that would fix this instantly https://github.com/elementary/switchboard-plug-about/blob/eb81a4a69e4ffde0995f4e64e8089d9aae1dd78b/src/Plug.vala#L306
Simply open Switchboard and go to the About plug and select

The desired effect should be immediate.

Works perfectly. Thanks!


More CI cleanups for common

Find out charts dynamically
Fix examples values to use imageregistry
Move all variable definition into a separate Makefile.vars
Add naked and normal expected.yaml files for examples-kustomize-renderer chart
Add proper naked+normal golang-secrets expected yaml files
Add external-secrets dependency chart to golang-external-secrets
Make sure we fail if helm template errors out
Add global hubClusterDomain to golang-external-secrets values
Remove Makefile.toplevel

Let's hold off on merging this one, until I discussed it in more detail with Andrew

This is basically preparation work so that we can run make tests and make helmlint from outside of common. E.g. https://github.com/mbaldessari/multicloud-gitops/tree/helm-test

/lgtm


Using a texture in 3D always forces a re-import and makes it darker.

Operating system or device - Godot version:
Linux (Ubuntu 17.04), Godot 3.0 (built from master a few days ago)
Issue description:
I noticed something strange going on with importing textures. No matter which settings I choose, as soon as a texture is used in 3D it will get re-imported and suddenly ends up much darker (and it looks as if the colour depth is lower too). Wrong texture colours shouldn't happen in the first place, but this even happens with uncompressed import and with "detect_3d=false".
Steps to reproduce:

Load a texture, use it in 2D (everything's fine).
Then use the texture in 3D, it will get re-imported with wrong colors.
Then re-import it again - 2d view is fine.
Switch back to 3D view, and it gets re-imported again.
repeat from step 3...

It looks like this:

Again, I chose uncompressed texture import, and detect_3d is off. So there might be two issues here: Broken texture import and import settings not applied correctly?

I had the reimporting constantly thing in my attempts to use the May 3 fixnum build, too.

What is detect_3d for?

Similar to #8155

This is kind of by design and not a bug.
It is possible to avoid it, but it won't work in many platforms if so. Basically, if a texture is used for 3D, it becomes a linear texture and it will look darker in 2D. This happens because all 3D rendering in Godot is done in linear colorspace, while 2D is done in gamma.

Okay, got it.
I'm not sure if this is related, but what also seems to happen is that the texture isn't just darker, it loses color depth when used 3D:

(the cube uses an "unshaded" material)

That color depth looks similar to https://github.com/godotengine/godot/issues/8683

The color depth issue is fixed already, so i suppose this can be closed

I can still reproduce this issue on master (3.0.1) using gltf import and changing the textures from .png to .jpg.

Sorry for bumping this ancient issue, but it currently blocks us from importing most DAE meshes because they get too dark. I can reproduce it in the exact same way as OP describes.
What's the correct way to deal with this? It renders all objects too dark and makes them unusable.

Try gltf or the blender-godot-exporter. If the mesh is too dark, try to reimport with different settings.

@and3rson You are certain your textures were created with proper linear workflow?
https://greyscalegorilla.com/tutorials/what-is-linear-workflow-and-how-can-it-help-your-renders-look-better/

2023 and I have this issue. My game is primarily 2d, but has a 3d scene that uses some textures that I'm also using in 2d. This on the fly re-import feature is a show stopper for me.

2023 and I have this issue. My game is primarily 2d, but has a 3d scene that uses some textures that I'm also using in 2d. This on the fly re-import feature is a show stopper for me.

In Godot 3.x, you can create a second copy of the texture to use in 3D, or use a custom shader to display the texture in either 2D or 3D (to undo the sRGB/linear conversion).
This issue is resolved in Godot 4 since sRGB flags were moved from the texture to the material.


UI font face can't be changed

In previous versions of Boxy it was possible to change the UI font face through the hacky method of editing "font.face" attributes in the .tmTheme files. This doesn't seem to be possible any more, though. Is this ability coming back somehow?

Sorry for the regression. I'll add this settings back in the next release.

@toph-allen Done, look at addons.

Nicely done!


Crashes before menu upon adding upscaling mods

I can add pdperfplugin to the game's directory and it loads fine, but as soon as I try to add a DLL for DLSS the game just crashes to desktop while REFramework is initializing.

having the same issue with RE&. you ever get it to work?


Use shape_t instead of tuple

Jenkins, test this please

Jenkins CI test (for commit c7723ad4867e44a5de119c8b04ae8f0e53c5ed5b, target branch master) failed with status FAILURE.

@emcastillo This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

Jenkins, test this please

Jenkins CI test (for commit c7723ad4867e44a5de119c8b04ae8f0e53c5ed5b, target branch master) succeeded!


Remove gemspec from openapi generator

Removed gemspec from openapi generator (ingress-api rake client:generate doesn't overwrite it)
Re-added config gem to gemspec.
TODO: In the near future move all non-generated code out of this gem

@agrare pls :eyes:


Drill init does not generate the zk.connect string correctly

Hi,
The zookeeper_list is not generated correctly; grep clientPort /etc/zookeeper/conf/zoo.cfg | cut -d '=' -f 2 and grep '^server\.' /etc/zookeeper/conf/zoo.cfg | cut -d '=' -f 2 | cut -d ':' -f 1 both return more than one line:
> grep clientPort /etc/zookeeper/conf/zoo.cfg | cut -d '=' -f 2
2181
2181
2181

I am not sure if that is the intended result but the zoo.cfg contains the same configuration options several time:
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

maxClientCnxns=50
# The number of milliseconds of each tick
tickTime=2000
# The number of ticks that the initial
# synchronization phase can take
initLimit=10
# The number of ticks that can pass between
# sending a request and getting an acknowledgement
syncLimit=5
# the directory where the snapshot is stored.
dataDir=/var/lib/zookeeper
# the port at which the clients will connect
clientPort=2181
server.0=drill-test-m:2888:3888
autopurge.purgeInterval=168

# User-supplied properties.
#Fri Feb 22 09:23:40 UTC 2019

# Properties from Zookeeper init action.
tickTime=2000
dataDir=/var/lib/zookeeper
clientPort=2181
initLimit=5
syncLimit=2
server.0=drill-test-m:2888:3888
server.1=drill-test-w-0:2888:3888
server.2=drill-test-w-1:2888:3888

# Properties from Zookeeper init action.
tickTime=2000
dataDir=/var/lib/zookeeper
clientPort=2181
initLimit=5
syncLimit=2
server.0=drill-test-m:2888:3888
server.1=drill-test-w-0:2888:3888
server.2=drill-test-w-1:2888:3888

Piping the result to sort | uniq generates the correct configuration:
# intelligently generate the zookeeper string
  local zookeeper_client_port=$(grep clientPort /etc/zookeeper/conf/zoo.cfg | cut -d '=' -f 2 | sort | uniq )
  local zookeeper_list=$(grep '^server\.' /etc/zookeeper/conf/zoo.cfg \
     | cut -d '=' -f 2 | cut -d ':' -f 1 | sort | uniq | sed "s/$/:${zookeeper_client_port}/" \
     | xargs echo | sed 's/ /,/g')

Looking at the zookeeper.sh I suspect it's a simple "append (>>)  instead of create (>)" typo?
function write_config() {
  cat >> /etc/zookeeper/conf/zoo.cfg <<EOF
# Properties from Zookeeper init action.
tickTime=2000
dataDir=/var/lib/zookeeper
clientPort=2181
initLimit=5
syncLimit=2
server.0=${CLUSTER_NAME}-m:2888:3888
EOF

  if [[ ${WORKER_COUNT} -gt 0 ]]; then
    cat >> /etc/zookeeper/conf/zoo.cfg <<EOF
server.1=${CLUSTER_NAME}-w-0:2888:3888
server.2=${CLUSTER_NAME}-w-1:2888:3888
EOF
  fi
}

Thanks for reporting this issue. We should use tail -n 1 to choose the last configured value of clientPort in the drill init action.
Append in zookeeper.sh is intentional. Only last value in the zoo.cfg file is used by zookeeper server/client.

PR: #467


Standardize Title and Author for NSHipster Blogs

Thanks for the clean up!

Thanks, as always for your great work on this, @daveverwer!


[CELEBORN-1044] Enhance the check of parameter array length

What changes were proposed in this pull request?
We can't get any response from /conf when the master started with default celeborn conf.

Internal Exception
empty.max
java.lang.UnsupportedOperationException: empty.max
	at scala.collection.TraversableOnce.max(TraversableOnce.scala:275)
	at scala.collection.TraversableOnce.max$(TraversableOnce.scala:273)
	at scala.collection.AbstractTraversable.max(Traversable.scala:108)
	at org.apache.celeborn.server.common.HttpService.getConf(HttpService.scala:36)
	at org.apache.celeborn.service.deploy.master.MasterSuite.$anonfun$new$1(MasterSuite.scala:46)

Why are the changes needed?
Bug.
How was this patch tested?
Local

Hi @SteNicholas, help to review, thanks

@xleoken, could you add suite to test whether the enhancement works well?


Use URLPattern instead of homegrown URL matching code

The idea being that a) we don't need to maintain our own URL matching code and b) this will help us get rid of almost all our URL parsing code!
I think I got quite far, but ran out of time, @DmitrySharabin can you take it from here? 🙏🏼

I got a notification for a suggested change but don't see it now, what happened?

I got a notification for a suggested change but don't see it now, what happened?

I was going to suggest replacing all line breaks in the source URL with spaces (so we could handle URL hashes with line breaks correctly) in the matchURL() util method. But then I changed my mind since, for now, we only need it in the Github API backend, and it might be overkill to perform this sort of thing on all URLs.

I believe this PR is ready for your final review, Lea. The URLPattern API is a good thing, I should say. 😊

I believe this PR is ready for your final review, Lea. The URLPattern API is a good thing, I should say. 😊

Well press it then 😁

Well press it then 😁

(it won't let me review it if it's marked as draft)

Oh. Right. 😅 Done!

Haha I still cannot review it because I’m the PR author!! 🤦🏽♀
I was going to write: LGTM. I wish we had a test suite so we can be more confident this is not breaking anything but oh well. Thanks so much for the effort you put into this!

Thanks so much for the effort you put into this!

Thank you for introducing me to this new, cutting-edge technology. Without you, I might never have known about it. I enjoy seeing with my own eyes how Madata becomes even more declarative from one iteration to another. 😍

I wish we had a test suite so we can be more confident this is not breaking anything

I have already started working on tests, but I would love us to decide on the test suit architecture before proceeding. I will file a separate issue for this.
Should we wait to merge this PR until we have the test suite?

Should we wait to merge this PR until we have the test suite?

If you're about to work on it, sure, otherwise no.


Prevent listing workflow approval tasks based on the user scope

Describe your problem(s)
Currently any user with apim:admin scope can view and approve/reject workflow tasks in the admin portal. As an improvement, allow only admin portal users with specific scope to view and approve these tasks

From the above fix, user with these scopes apim:api_workflow_view,apim:api_workflow_approve,apim:tenantInfo,apim:admin_settings can login and do the approvals


I can't find 'setup_training.sh'

Thank you for publishing the code.
I can't find 'setup_training.sh' and 'setup_all.sh'

I added the missing files, thanks!

Thank you!


Fix enum flag values

Summary
Enum values were not in power of 2 but * 2 😆
Fixes dotnet/docs#13508

Whoops. I confused decimal with hex. DOH!


Update connect-salesforce-to-microsoft-cloud-app-security.md

Added an additional permission that is required

@RanMaMCAS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


More specific handle (req, request) and (res, response)

It's helpful for using node req and node res to directly migrate from express to koa, but It's not koa style. We should use request and response wrapped by koa.

Agreed. Stumbled across that when using graphql-koa which seemed to confuse the two (probably just a straight copy-pasta from express-graphql.

+1 to this. Maybe someone could get the extended config examples from the original express-graphql repo as well. Do you plan to keep this repo here updated?

Sure. We will try to follow express-graphql repo, besides the point which koa can do something better than express. Any PRs are also welcome.

For now, we don't expose any req and res stuff in our public api, so I am going to close this issue.


Added Reversing_Circular_LinkedList.java

Description
Addition of Reversing Circular LinkedList
Name of the File - Minimum_Element_Stack.java
Destination Folder - Daily-Coding-DS-ALGO-Practice/Data Structures/
Fixes #762
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@Saurabh4626 @Ayush7614 @Amit366

@Ayush7614 @Amit366 @Saurabh4626


"Criciova", "Cireșu", "Cireșu Mic" and "Jdioara" are listed in the drop-down menu

Description:
"Criciova", "Cireșu", "Cireșu Mic" and "Jdioara" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Criciova" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Criciova, TIMIȘ (Criciova)" and "Comuna Criciova, TIMIȘ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Cireșu Mic" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cireșu Mic, TIMIȘ (Criciova)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.


chore(Cloud Databases): Removed Datastax

PR summary

Remove Datastax from our go-sdk offering as it's no longer offered.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[x] Other (Database removal)

What is the current behavior?
Our go-sdk supports datastax.
What is the new behavior?
Datastax operations no longer exist.
Does this PR introduce a breaking change?

[X] Yes
[ ] No

Customers using Datastax operations must remove them as Datastax is no longer available.
Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: lornakelly:white_check_mark: omaraibrahim:x: semantic-release-botYou have signed the CLA already but the status is still pending? Let us recheck it.


Include location "diameter" or other metric so we can use it for map "zoom"

🚀 Feature Requests
Right now if we want to use this plugin with a map, we can't zoom the map in the right way because we don't know the result location diameter/size. So if we searched for the city it will pinpoint its center. But we don't have a metric to set the zoom in the right way.

Hi @moshe5745, thank you for filing this feature request!
It seems that we can implement this for Android using the Android geocoding API. We can read geometry.viewports or geometry.bounds (https://developers.google.com/maps/documentation/geocoding/requests-geocoding#results).
For iOS, I could not find an API that offers this functionality.


Plugin keeps updating BlazeCommandRunConfigurationHandler breaking run configurations

Hi,
When I open my java project in intellij, the bazel plugin takes several minutes to sync the project. It is quite a large mono repo but that's not the issue.
The problem we have is that all of the run configurations in .ijwb/.idea/runConfigurations are modified by the plugin and are no longer able to run or debug.

The attribute blaze-settings.handler-id changes from BlazeJavaRunConfigurationHandlerProvider to BlazeCommandGenericRunConfigurationHandlerProvider
The attribute kind="java_binary" is removed from blaze-target.

This has been happening for many, many months across many IDE and plugin versions so it is not a recent regression. It also affects all members of my team.
Running:

Ubuntu (several) & MacOs
IntelliJ UE 2020.3.3
Bazel plugin 2<IP_ADDRESS>.2

I have noticed this happens when the java_bin target contains tags = ["manual"]


Add unit test for cmd

Add unit test for cmd/antrea-controller and improve validateNodeIPAMControllerOptions
Signed-off-by: Wenqi Qiu<EMAIL_ADDRESS>

@wenqiq , there are too many commits in this PR, please squash them.

@wenqiq , there are too many commits in this PR, please squash them.

These can be squashed when merging with squash option.

@antoninbas @tnqn @jianjuns @luolanzone Addressed comments and updated. Could you help take a look at this PR again?

/skip-all


⚠ Bofrost.lu has degraded performance

In bc7fb73, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1497 ms

Resolved: Bofrost.lu performance has improved in f23e28e after 26 minutes.