Remove migration code for Plutono and Vali

How to categorize this PR?

/area monitoring
/kind cleanup
What this PR does / why we need it:
#7318 introduced migration code to switch from Grafana to Plutono, and from Loki to Vali.
The commits that introduced these changes can't simply be reverted, so this commit removes the migration code.
Please note that artifacts from control planes which have been broken continuously since gardener v1.71.0 where the migration was introduced may need to be cleaned up manually. These artifacts can include ConfigMaps, Ingresses, PersistentVolumes, PersistentVolumeClaims, Deployments, and StatefulSets. The below commands can be used to clean up these artifacts in a control plane namespace in a seed:
kubectl delete statefulsets loki
kubectl delete persistentvolumeclaims loki-loki-0
kubectl delete deployments grafana
kubectl delete services grafana loki
kubectl delete configmaps -l app=loki
kubectl delete configmaps -l component=grafana
kubectl delete secret shoot-access-promtail
kubectl delete secret -l name=loki-tls
kubectl delete ingresses grafana loki
kubectl delete hvpa loki
kubectl get networkpolicies | grep -E 'loki|grafana' | awk '{print $1}' | xargs kubectl delete networkpolicies

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @istvanballok
Release note:

Migration code for Plutono and Vali is now removed. Consider manual cleanup for longterm broken Shoots as described in the PR to avoid leaking Loki's PV.

Thanks for cleaning up. Do we need to adapt
https://github.com/gardener/gardener/blob/67a049a3f66ce489002a67dd59ac7b95e8d2573b/pkg/component/plutono/plutono.go#L880
as well?

Okay, this is for the extensions. I see that they still use Grafana and loki instead of Plutono and vali.
Then it's fine.

/assign

/lgtm

I will approve after we agree internally how we clean up the leftover loki PVCs for broken Shoots since longtime.

With @rfranzke we agreed to follow-up internally on the cleanup and meanwhile to proceed with this PR.
/approve

/retest


Panicked when processing: insert at index 4 exceeds fixbitset size 2

Describe the bug
This may related to #12818
Error message/log
No response
To Reproduce
CREATE TABLE test1 (c_0 TIMESTAMP, c_1 INT, c_2 FLOAT);
CREATE TABLE test2 (c_0 TIMESTAMP, c_1 INT, c_2 FLOAT);
SELECT max(T1.c_0) OVER(PARTITION BY T2.c_0<>T1.c_0) FROM test1 AS T1 INNER JOIN test2 AS T2 ON T1.c_0>T2.c_0 group by T1.c_0,T2.c_0;

Expected behavior
No response
How did you deploy RisingWave?
Docker
The version of RisingWave
PostgreSQL 9.5-RisingWave-1.2.0 (f27f085e4433eb4b3b9e8df61b3f94406f654d89)
Additional context
No response

duplicate with #10666, already fixed in main


Background Images load too late and with wrong Image Stretch [UE5]

Hello! Super awesome Plugin!
Works fine with my UE 4.27 project, but after porting it to UE 5 the Default Loading Screen images are not loading until the end of the loading process, they are also scaled wrongly. The Startup Loading Screen always displays instantly and scales just fine. If I choose the same image for one of the Default Loading Screen Images as I used for the Startup Loading Screen, that one loads and scales properly.
Could you please take a look? I guess something is changed how Unreal loads/streams in textures in UE5.
Thank you!

i have the same issue

Hi, what I have done in my project is to cache all needed textures in StartupModule function so it will have time to load before showing on the screen :) This is not the most optimal solution as all textures are all the time in the memory but it can be optimized

Hi! Thanks! I've tried to add all my textures to the [Startup Loading Screen] list, but it doesn't work for me. Only the first one in the array is getting loaded. Do you mean something else with the StartupModule?

Hey, did you find out how to fix this? I have the same Issue and have no idea how to fix it

Hello Guys,
What about a temporary fix while the "real" fix is implemented ?
Already 5.0.03 and still not corrected.

Pretty massive issue in that the plugin is functionally useless in UE5 and no sign of it even being acknowledged.

i have the same issue,using ue5.1 @truong-bui

So Laguland is right, the easy and ugly way is to preload background images from FAsyncLoadingScreenModule::StartupModule
So in AsyncLoadingScreen.h, add :
private :
   [...]
UPROPERTY()
	static TArray<UObject*> PreLoadedImages;
};

And in AsyncLoadingScreen.cpp :
[...]
#define LOCTEXT_NAMESPACE "FAsyncLoadingScreenModule"

TArray<UObject*> FAsyncLoadingScreenModule::PreLoadedImages = TArray<UObject*>();

void FAsyncLoadingScreenModule::StartupModule()
{
	// This code will execute after your module is loaded into memory; the exact timing is specified in the .uplugin file per-module

	if (!IsRunningDedicatedServer() && FSlateApplication::IsInitialized())
	{
		const ULoadingScreenSettings* Settings = GetDefault<ULoadingScreenSettings>();

		// Ugly : permanently load ALL the background images.
		{
			auto PreLoad = [](const TArray<FSoftObjectPath>& Images) {
				for (auto& Image : Images) {
					PreLoadedImages.Add(Image.TryLoad());
				}
			};

			PreLoad(Settings->StartupLoadingScreen.Background.Images);
			PreLoad(Settings->DefaultLoadingScreen.Background.Images);
		}

		if (IsMoviePlayerEnabled())
		[...]

For a marketplace engine, you will need to have the plugin in your local project directory Plugins folder.
If you have a lot of background images & levels, each image for a level, a more decent solution would be to pre-load only 2 images : the start-up/main menu one in FAsyncLoadingScreenModule::StartupModule, and the background for the level to be loaded in or before calling UAsyncLoadingScreenLibrary::SetDisplayBackgroundIndex
It's so ugly i can't do a PR, but maybe this can be helpful to some folks.

Note that startup image is not unloaded even with current implementation: https://github.com/truong-bui/AsyncLoadingScreen/issues/57

@dzCx, @xongnox I have added an "bPreloadBackgroundImages" option in this commit 0a9852f2f59626cae96958b659793a53606e1bef

You can remove all the background images from memory by calling "RemovePreloadedBackgroundImages" in the blueprint, then manually load all the background images with "PreloadBackgroundImages" function before calling the "OpenLevel" node

Please update the plugin and test if it works for you. Thanks!

Nice to see you helping here @truong-bui !
I did a bit more investigation on the issue. I found :

Cooked builds (dev/ship/distribution) seems fine without pre-loading, on SSDs and HDDs.
So, it's great.
The issue only appears when lauching Standalone from the editor. And pre-loading the image(s) in C++ only before OpenLevel does not work. Even returning a valid pointer to a valid texture to SBackgroundWidget.cpp does not work : I'm not knowledgeable enough about unreal textures resources and GPU memory management, but it may have to do with it, and not only, as I previously though, concurrent read from .pak files to memory while loading the level.

It seems like the only fix for standalone is to load very early, i.e in StartupModule. Why does it works here ? I don't know but this may have something to do with https://github.com/truong-bui/AsyncLoadingScreen/issues/56#issuecomment-1498608390
Thus I'm going to pre-load all background images in StartupModule with some #if WITH_EDITOR around, because it's a bit triggering when play-testing. Ie as in https://github.com/truong-bui/AsyncLoadingScreen/issues/56#issuecomment-1498257902 but without the unnecessary static but with a WITH_EDITOR.
So from my understanding, no need to bother with Preload / Unload functions, who will do no good. I did not test to pre-load a few seconds before calling OpenLevel (instead of one line before in c++), but i suspect it would not work either.

@truong-bui i see you closed this issue. Did you look at @xongnox comments? Issue seems to appear also in standalone non editor launch.
Any idea on how it definitely can be resolved? It is for sure a critical issue. Images are consistently not loaded at initial load. After that it seems ok.

Yes, I have looked at his comment. As he tested, the cooked/packaged build works fine. So I think no need to do anything since this is mostly caused by how Unreal Engine manages texture data in memory in the editor. The preload options should be used for testing in the editor only.

Are you going to push the preload function to the marketplace version and also on 5.0, 5.1 and 5.2. I confirmed it works in your master branch.

I have pushed it to Marketplace but only for the newest version 5.2

same here in 5.4.2, in editor standalone startup background failed to be loaded and shown, Preload option not helpering.
I just remove using background image on startup

same here in 5.4.2, in editor standalone startup background failed to be loaded and shown, Preload option not helpering. I just remove using background image on startup

The packaged game should work fine. You shouldn't worry about this issue.


Add new and create commands

Purpose
This PR will add new and create command to ballerina cli. also it changes the behavior of the init command to match with packerina v6 specification.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[x] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #16121 into packerina-dev will increase coverage by 0.95%.
The diff coverage is 67.33%.

@@                 Coverage Diff                 @@
##             packerina-dev   #16121      +/-   ##
===================================================
+ Coverage            10.74%    11.7%   +0.95%
- Complexity            3347     3795     +448
===================================================
  Files                 1949     2055     +106
  Lines                90567    95234    +4667
  Branches             12634    13352     +718
===================================================
+ Hits                  9729    11144    +1415
- Misses               78877    81998    +3121
- Partials              1961     2092     +131

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/ballerinalang/packerina/cmd/Constants.java
0% <ø> (ø)
0 <0> (?)

...org/ballerinalang/packerina/cmd/CreateCommand.java
59.54% <59.54%> (ø)
21 <21> (?)

...a/org/ballerinalang/packerina/cmd/InitCommand.java
60.52% <64.51%> (ø)
5 <5> (?)

...va/org/ballerinalang/packerina/cmd/NewCommand.java
68.08% <68.08%> (ø)
7 <7> (?)

...a/org/ballerinalang/packerina/cmd/CommandUtil.java
92.85% <92.85%> (ø)
11 <11> (?)

...pi/execution/query/output/stream/OutputStream.java
21.21% <0%> (ø)
1% <0%> (?)

...i/exception/UnsupportedAttributeTypeException.java
100% <0%> (ø)
1% <0%> (?)

...in/java/org/ballerinalang/packerina/PushUtils.java
0% <0%> (ø)
0% <0%> (?)

...org/ballerinalang/packerina/cmd/SearchCommand.java
0% <0%> (ø)
0% <0%> (?)

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1285d21...fdb8aac. Read the comment docs.


Replace some uuid examples with generic ones

Fixes #80

Hi Prathiba,
Thanks for the comment and observation. Please merge the branch if the fixes correctly solve the issue.
Kind Regards, Ana

Hi @anacabbar , Many thanks for the fixes.


Update configuration.yaml

bumping the Terraform version to 1.4.0

This is the latest current stable version of Terraform.

Thank you for your contribution @oliverlabs. I've created a new PR (#893) to merge your contribution into the component-updates branch we're using to validate changes via the E2E pipeline.


Fix D3D12 debug overlay pipeline creation

In the debug overlays only one RTFormat is used. If the original pipeline has multiple RTFormats, then they need to be set to DXGI_FORMAT_UNKNOWN otherwise the creation fails because ID3D12Device::CreateGraphicsPipelineState returns E_INVALIDARG.

Thanks for this fix! I'm surprised no-one has run into this before now.
It seems quite strange to me that D3D is failing based on values of RTFormats that aren't used due to NumFormats == 1, but I guess that's how it works.


Heatmap label too small

The heat map displaying label on the top edge of the heat map is really not clear.
Since different labels have already been separated by the dash line, can you modify the label display such that each group's label is displayed just once?
Instead of:

Display it as something like this:

Same issue.
Another enhancement is to change the study name (Dataset 1) to be the actually study name.


feat: style tweaks and home logo animation

Added a load animation on the homepage logo
Removed the max width on the main wrapper for the desktop resolutions
Removed the polygon clip on the homepage sections
Small spacing and color tweaks on the homepage
Updated the homepage texts

3eb749ca-e45c-4aaf-880a-b91aa34e2f24.webm

The logo animation is truly marvelous!

@FaberVitale Added Netifly preview to simplify the review process

@gdorsi before merging  we need to fix the 'show all tags' link position on wide viewports.

Overall the changes are great 👍

before merging we need to fix the 'show all tags' link position on wide viewports.

Good catch @FaberVitale!
Fixed the category list page layout as well.


Tiny flaw in openssl 1.0.2 source code

Tiny flaw found in openssl source code.
Cannot find demos/easy_tls/ in latest 1.1 version. Also cannot not find any mention
of it being removed in changelog. If demo removed, feel free to ignore this.
openssl/1.0.2j.6.1.140/src/demos/easy_tls/easy-tls.c#L322:        va_start(args, fmt);
Missing its va_end call, looks like it should be right after #L324.

We did remove many demos in 1.1.0:
commit ec59112a822e16a539bc5dd1b8bed12afbcb82b8
Author: Rich Salz<EMAIL_ADDRESS>Date:   Mon Mar 7 14:55:44 2016 -0500

    Remove really old demo's

    Reviewed-by: Richard Levitte<EMAIL_ADDRESS>
But the bug you found in 1.0.2 we should fix.


Update migration_sdf.md

🦟 Bug fix
Fix broken links for ERB, Server configuration tutorial and GUI configuration tutorial. These links where pointing to the wrong url, change them to point on .md files related.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
➡ Forward port
Port <FROM_BRANCH> to <TO_BRANCH>
Branch comparison: https://github.com/gazebosim//compare/EnzoGhisoni:gz-sim:patch-1
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release
Preparation for <X.Y.Z> release.
Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>
Checklist

[ ] Asked team if this is a good time for a release
[ ] There are no changes to be ported from the previous major version
[ ] No PRs targeted at this major version are close to getting in
[ ] Bumped minor for new features, patch for bug fixes
[ ] Updated changelog
[ ] Updated migration guide (as needed)
[ ] Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Related to issue #1230


Order of type guards in &&-statement changes inferred type

TypeScript Version:  3.5.3, 3.9.2, 4.0.0-beta
Search Terms: type guard, incorrect type
Code
function doSomething(value: unknown): object {

  if (value !== null && typeof value === 'object'){
    return value //value: object | null
  }
  if (typeof value === 'object' && value !== null){
    return value //value: object
  }
  return {}
}

Expected behavior:
The variable "value" is correctly narrowed down to object in both cases
Actual behavior:
The variable is narrowed down to "object | null" in the first case and to only "object" in the second case.
Playground Link: test on playground

Duplicate of #28131. Used search terms: narrow null object


[Bug] Kapacitor Aggregate handler - interval option format

After kapacitor upgrade from 1.3.3 to 1.4 the interval option can't parse time.Duration format from a string.
In 1.3.3 this works fine
agg.yaml
kind: aggregate
options:
   interval: 1m
   topic: alert_log

In 1.4 this wont work
agg yml
topic: agg_topic
id: agg_handler
kind: aggregate
options:
   interval: 1m
   topic: alert_log

I get the error
failed to update handler: failed to decode options into *alert.AggregateHandlerConfig: 1 error(s) decoding:
* 'interval' expected type 'time.Duration', got unconvertible type 'string'

So had to change to
topic: agg_topic
id: agg_handler
kind: aggregate
options:
   interval:<PHONE_NUMBER>0
   topic: alert_log

Still the same in 1.5.4


use cocoapods "no such module PGoA"

Open PGoApi.xcworkspace ,and import framework like this

but ViewControlle.swift import PGoA has error
"no such module PGoA"
can you help me about it

I think you already figured out the problem, it should be PGoApi


Release notes improvements

Fix links
Improve dependency verification entry

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you.


MYNEWT-583; newt - allow use of specific tag/repository revision.

vers field for repository.yml should contain -tag.

Hey marko: I'm going ot look at pulling this in, but first can you correct merge conflict?
Thanks, Sterling


Unused code leads the compilation error

@koute Hi! I've catched a subtle bug when code with warning lead to compilation errors:
Caused by:
  compiler produced invalid json: `{"message":"constant item is never used: `CODE`","code":
{"code":"dead_code","explanation":null},"level":"warning","spans":[{"file_name":"<__js_raw_asm
macros>","byte_start":89,"byte_end":146,"line_start":4,"line_end":4,"column_start":1,"column_end":58,"
is_primary":true,"text":[{"text":"const CODE : & 'static str = concat ! ( $ code , \"\\0\" ) ; $ crate ::
private","highlight_start":1,"highlight_end":58}],"label":null,"suggested_replacement":null,"expansion":
{"span":{"file_name":"<_js_impl macros>","byte_start":8264,"byte_end":8327,"line_start":162,"line_end":162,
"column_start":1,"column_end":64,"is_primary":false,"text":[{"text":"__js_raw_asm ! ( $ code , $
a1_name , $ a2_name , $ a3_name ) ; } ; (","highlight_start":1,"highlight_end":64}],"label":null,
"suggested_replacement":null,"expansion":{"s

To get it try to compile https://github.com/DenisKolodin/wasm-compilation-fail
The interesting thing is it compiles successfully if I use ProtoService::connect function.
The bug could potentially live in the js! macro... or in the compiler. I have no ideas now.

Interesting!
This looks to me like potentially a compiler bug? I've manually ran the rustc command which cargo invoked, and it generated 15 lines of JSON objects, all of which are fine except the 10th (counting from zero), which is.... 4 megabytes long? O_O
Anyhow, this also reproduces if you run this:
$ cargo check --target=asmjs-unknown-emscripten --message-format json


Replace bundle-manifest.mf with __bundle_entry.manifest

Makes it easier to compose a canonical manifest from a set of bundles, as it doesn't require processing the .mf files.
As @yuangu-google suggested.

@yuangu-google everything passes now.


Avoid passing glance DB credentials as arguments

Write a separate MySQL options file with Glance database credentials and
use that instead.

Please review and merge asap.

:+1:

On phone, can't merge. GitHub won't let me.

failling because of misnaming of mysql .cnf file.   pushed commit to fix.  will merge when passes.

@paulczar thank you.

rekicked tests after merging cinder fix.


[MANOPD-81998] Update Installation.md

Description
Please include a summary of the change and describe issue. Please also include relevant motivation and context.

Doc update, added the information about the Unattended-Upgrades package

Test Configuration:

Hardware:
OS: Ubuntu 20.04, 22.04
Inventory:

Steps:

Results:

Before
After

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] Integration CI passed
[ ] Unit tests. If Yes list of new/changed tests with brief description
[ ] There is no merge conflicts

Unit tests
Indicate new or changed unit tests and what they do, if any.

Hi, @koryaga,
The doc review is done.
Thanks!


BufferWindowMemory: returnMessages: true causing invalid conversation context

const memory = new BufferWindowMemory({
        returnMessages: true, //true, the history is returned as an array of message objects. If it's set to false, the history is returned as a single concatenated string
        memoryKey: "history",
        k: 10,
        chatHistory: redisChatMemory,
        inputKey: 'input',
        // outputKey: 'output',
      })

"The following is a friendly conversation between a human and an AI. The AI is talkative and provides lots of specific details from its context. If the AI does not know the answer to a question, it truthfully says it does not know.\n\nCurrent conversation:\n[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]\n

Bug: the conversation memory items are not stringified

Any updates on this bug

You should use MessagesPlaceholder and a ChatPromptTemplate if inserting messages into the prompt instead of just a normal prompt template:
https://js.langchain.com/docs/modules/memory/how_to/buffer_memory_chat

Ok that's cool


The backup taken on the Rancher UI, gets deleted

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Create cluster with 3 nodes - 1 etcd, 1 ctrl plane, 1 worker nodes
Automatic backup occurs after the cluster comes to Active state.
Scale upto 2 etcd nodes.
Take a backup

Expected Result:
Backup should be taken successfully and be shown in the dropdown on the Rancher UI.
Actual result:
Backup is taken, and it is seen on the rancher UI. But it gets deleted from the Rancher UI.
Logs:
2019/03/14 22:36:49 [INFO] Provisioned cluster [c-jt6qk]
2019/03/14 22:37:04 [INFO] Handling backend connection request [c-jt6qk:m-zrfxg]
2019-03-14 22:37:08.768307 I | mvcc: store.index: compact 7611
2019-03-14 22:37:08.769709 I | mvcc: finished scheduled compaction at 7611 (took 717.645µs)
2019/03/14 22:37:18 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:10777
2019/03/14 22:37:18 [INFO] Starting saving snapshot on etcd hosts
2019/03/14 22:37:18 [INFO] [dialer] Setup tunnel for host [ip-address1]
2019/03/14 22:37:18 [INFO] [dialer] Setup tunnel for host [ip-address2]
2019/03/14 22:37:18 [INFO] [dialer] Setup tunnel for host [ip-address3]
2019/03/14 22:37:18 [INFO] [dialer] Setup tunnel for host [ip-address4]
2019/03/14 22:37:18 [INFO] [etcd] Saving snapshot [c-jt6qk-ml-t5sn7] on host [ip-address1]
2019/03/14 22:37:19 [INFO] [etcd] Successfully started [etcd-snapshot-once] container on host [ip-address1]
2019/03/14 22:37:19 [INFO] error in remotedialer server [400]: websocket: close 1006 unexpected EOF
2019/03/14 22:37:19 [INFO] error in remotedialer server [400]: websocket: close 1006 unexpected EOF
2019/03/14 22:37:19 [INFO] [etcd] Saving snapshot [c-jt6qk-ml-t5sn7] on host [ip-address3]
2019/03/14 22:37:20 [INFO] [etcd] Successfully started [etcd-snapshot-once] container on host [ip-address3]
2019/03/14 22:37:20 [INFO] [etcd] Saving snapshot [c-jt6qk-ml-t5sn7] on host [ip-address2]
2019/03/14 22:37:21 [INFO] [etcd] Successfully started [etcd-snapshot-once] container on host [ip-address2]
2019/03/14 22:37:21 [INFO] Finished saving snapshot [c-jt6qk-ml-t5sn7] on all etcd hosts
2019/03/14 22:37:21 [INFO] kontainerdriver rancherkubernetesengine stopped
2019/03/14 22:37:21 [INFO] [etcd-backup] Deleteing backup c-jt6qk-ml-t5sn7
2019-03-14 22:42:08.771759 I | mvcc: store.index: compact 8181
2019-03-14 22:42:08.773465 I | mvcc: finished scheduled compaction at 8181 (took 1.009525ms)

Note: The etcd nodes, have the backup snapshot available even though it is not available on the Rancher UI.
This issue was seen one time on Rancher UI
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancher:master(03/14/2019)
Installation option (single install/HA): single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Do cluster
Kubernetes version (use kubectl version):

v1.13.4

Docker version (use docker version):

18.9.3

Moving out of the release as per @sowmyav27 the issue was seen only once.

This issue occurred on a fresh install of rancher:v2.2.0-rc9.
Steps taken:

Create a cluster - 3 nodes (All roles) AWS cluster on a single node install.
Take a back up snapshot. A message "Snapshot has been initiated " is seen on the UI.
The snapshot is not seen on the UI anymore.
The etcd nodes, have a copy of the snapshot.


Changed base image to slim and dropped 80% in size.

Tested locally, seems to work. Proof:

Signed-off-by: Shay Nehmad<EMAIL_ADDRESS>

Can we know the difference between the regular and the slim base images? Is there a chance some library we use locally will be missing from the slim image?


(PDB-2939) Don't try to store same report twice

There's no reason to, and the attempt causes PDB to wander off into the
long (eventually fruitless) retry process.
We believe that's also what was causing one of the convergence-test
failures.  i.e. if the database connection was slow enough, two syncs
that were scheduled one right after the other could enqueue the same
command twice (in that case the addition of a report), and then the test
would fail (time out) because the second addition never showed up as a
completed command since it was repeatedly rejected as a duplicate.

Test PASSed

Test PASSed

looks good to me


errors with python2.6 on cent-os

Maybe this should not qualify as an issue as it does not list python 2.6 is a version of python that is tested against, but it seems that doit will not work when installed from pip, easy_install or source.
Here is the error message I get when trying to run doit:
[j@hbx ~]$ doit
Traceback (most recent call last):
  File "/usr/bin/doit", line 9, in <module>
    load_entry_point('doit==0.29.dev0', 'console_scripts', 'doit')()
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 299, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2229, in load_entry_point
    return ep.load()
  File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 1948, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/usr/lib/python2.6/site-packages/doit-0.29.dev0-py2.6.egg/doit/__init__.py", line 33, in <module>
    from doit.doit_cmd import get_var
  File "/usr/lib/python2.6/site-packages/doit-0.29.dev0-py2.6.egg/doit/doit_cmd.py", line 11, in <module>
    from .plugin import PluginDict
  File "/usr/lib/python2.6/site-packages/doit-0.29.dev0-py2.6.egg/doit/plugin.py", line 86
    return {k: self.get_plugin(k) for k in self.keys()}
                                    ^

Sorry in advance if this is not an appropriate thing to file an issue on.
Thanks, -JE

@schettino72, maybe you should add some explicit info on ancient Python support, or investigate blocking installs there?
@johnerichumphries Let Python 2.6 die already.

both on package metadata and on written doc it says doit supports py 2.7 and 3.2 to 3.4. If you check the CHANGES file you can see when each release support was added and removed. That's explicit enough for me...

@Kwpolska, I couldn't agree more, centos still ships with 2.6 and the admin will not upgrade.
I use doit on my own machine and really like it, so figured it was worth checking. Back to using make!
Sorry for filing what seems to be an invalid issue and thanks for the help.


fix(package.json): update links to correct URLs for "homepage", "repository.url", "bugs.url"

Updated the package.json files to reflect the move to the monorepo.
Note: I did not update the versions of the package.json files. I presume that would happen immediately before pushing to npm?

Issue being fixed or feature implemented

Helps npm point to the right location

What was done?

Updated links in the package.json files. In each package.json file:

"repository.url" was set to "git+https://github.com/dashpay/platform.git"
"bugs.url" was set to "https://github.com/dashpay/platform/issues"
"homepage" was set to the directory of the package

How Has This Been Tested?

n/a
Breaking Changes

none
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
[ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

Are the homepages supposed to point to the v1.1-dev branch? Not really sure what to do about that.

Are the homepages supposed to point to the v1.1-dev branch? Not really sure what to do about that.

Maybe HEAD, for example https://github.com/dashpay/platform/tree/HEAD/packages/dashpay-contract#readme ?


Updater not working / settings not saving

I'm having issues using my RG353M with ArkOS 2.0 (08112023).
Changes in the options menu are not saved and the updater does not work.
I get the following error message: "There was an error with attempting this update. Did you make sure to enable your wifi and connect to a wifi network? If so, enable remote services in options and try to update again".
Well I am properly connected to my wifi and even after enabling the remote services, I could not update. So I connected via SSH and ran the updater from there, resulting in the following output:
"Checking for updates.  Please wait...mode of '/home/ark/ArkOSUpdate.sh' retained as 0777 (rwxrwxrwx)
tee: /home/ark/esupdate.log: No space left on device
librga:RGA_GET_VERSION:3.02,3.020000
ctx=0x55953e8eb0,ctx->rgaFd=3
Rga built version:version:+2017-09-28 10:12:42
obj=0x55782dffa8, event=12"
Checking my devices, I get:
ark@rg353m:/opt/system$ df
Filesystem     1K-blocks      Used Available Use% Mounted on
udev              995552         0    995552   0% /dev
tmpfs             201684      2316    199368   2% /run
/dev/mmcblk1p4   7255536   6959732         0 100% /
tmpfs            1008408         4   1008404   1% /dev/shm
tmpfs               5120         4      5116   1% /run/lock
tmpfs            1008408         0   1008408   0% /sys/fs/cgroup
/dev/mmcblk1p3    100784     32237     68547  32% /boot
/dev/mmcblk1p5 242737264 185159584  57577680  77% /roms
tmpfs             201680         0    201680   0% /run/user/1002
Anyone else had this problem? Is there a solution?

/dev/mmcblk1p4 7255536 6959732 0 100% /
Your sd card is either to small or you've been installing many applications on the linux partition of the sd card and you've run out of space.

I have a 256G SD Card, flashed ArkOS on it and copied over roms. I don't know how this partiton even filled up to 100%.
Any suggestion on how to fix this? The sd card hast plenty of storage left.

Pretty sure I followed the documented standard installation, but I'm not entirely sure to be honest.
I really want to avoid a complete reinstall/reconfiguring and just expand the partition if it's possible. :/

Check if there’s a /tempthemes folder on the sd card.  If so, that means you did not insert the sd card into the unit first and allow the initialization.  Which would also mean you used a tool like minitool partition wizard to creat and/or expand the EASYROMS partition before the initial boot.

I just checked and there is no such folder.

Ok.   Then unless you've been in there apt installing other programs, I'm not sure why the root partition is full.  You should have at least 2GBs free there.  What else did you do with the system after loading it on to your 256GB card and loading your games into the ROMs partition?

Literally nothing. I just copied over my roms, set up RetroArch and played some games.

Unfortunately, you'll have to reflash the OS to fix the issue.

Reflashed and reconfigured my device. I have 2,4G space left on /dev/mmcblk1p4 and will keep an eye on it.
Thanks for your support.

Strange it happened with the initial flash but happy it’s resolved now👍🏿


Allow loading of pixel overlays in photoshop

Is your feature request related to a problem? Please describe.
The current save_fov_images function in the pixel clustering notebook saves the overlays as float64 images, which can't be loaded into photoshop.
Describe the solution you'd like
Since these are all integers anyway that are getting coerced to floats, we should just save the images as ints

Agree. @alex-l-kong should be an easy fix.


Make plugin compatible with module loaders

Duplicate of #85 by @metaraine — minified version included + some comments.
plz plz merge.
Believe me, many other people need this. We don't have time for browserify-shim, etc. in order to get your plugin working with browserify bundles.

Sorry for the delay on this guys!

No worries, sorry if I came off sounding harsh! Thanks for your work on this, @liabru , it's much appreciated.

This doesn't seem to have been pushed up to NPM?
Where it is most useful ;)

https://www.npmjs.com/package/jquery-match-height

Sorry, the latest version doesn't seem to have. The fix you PR'd.

Ohh, I see! True.. needs a version bump and release, @liabru


Try to help readers of BUILD.md

1> #55 failed: apply: Got temINVALID (The transaction is ill-formed.); Expected tesSUCCESS (The transaction was applied. Only final in a validated ledger.)


feat: bump kotlin version to 1.9.24

Issue #
There were a lot of noisy logs from Gradle / Kotlin, e.g.
java.rmi.ServerError: Error occurred in server thread; nested exception is:
Could not connect to kotlin daemon. Using fallback strategy.
	java.lang.AssertionError: symbolic reference class is not accessible: class sun.nio.ch.FileChannelImpl, from class org.jetbrains.kotlin.com.intellij.util.io.FileChannelUtil (unnamed module @46805db7)
...

This PR should fix all of the noise (at least locally).
See related links:

https://youtrack.jetbrains.com/issue/KT-47152/Incremental-Compilation-with-Kotlin-compile-daemon-and-JDK-17-fails-with-IllegalAccessException
https://kotlinlang.org/docs/whatsnew18.html#updated-jvm-compilation-target
https://stackoverflow.com/questions/77607619/android-studio-kotlin-inconsistent-jvm-target-compatibility-detected-for-task

Description of changes
Corresponding smithy-swift PR: smithy-lang/smithy-swift#717
Bump kotlin version to 1.9.24
Also:

bump dokka version to 1.9.20
target JVM 17 output

New/existing dependencies impact assessment, if applicable
Kotlin and Dokka versions updated to the latest version, and JVM 17 targeted.
Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looks like CI still has noisy log, but at locally they are gone.
> Task :smithy-swift:buildSrc:compileKotlin
Compilation with Kotlin compile daemon was not successful
java.rmi.ServerError: Error occurred in server thread; nested exception is:
	java.lang.AssertionError: symbolic reference class is not accessible: class sun.nio.ch.FileChannelImpl, from class org.jetbrains.kotlin.com.intellij.util.io.FileChannelUtil (unnamed module @46805db7)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:389)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:587)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:8[28](https://github.com/awslabs/aws-sdk-swift/actions/runs/8993521349/job/24705458002?pr=1487#step:10:29))
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:705)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:704)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)


As a admin, I want to hide the reported reviews/comments from a management page that can only accessed by admin

User story
As an admin, I want to hide the reported reviews/comments from a management page that can only be accessed by the admin.
The definition of hidding means that the inappropriate reviews/comments would be hidden from users (except for the review/comment authors)
To those specific authors, all the hidden reviews/comments would be carrying a hidden tag (notifying them the content is inappropriate)
Acceptance criteria
After the reviews and comments being hidden by the admin, the reviews/comments owner can see a tag notifying them the content is inappropriate. Meanwhile, other users could not see the hidden reviews/comments.
Definition of Done
In a production instance, when a review/comment was hidden by the admin, the review/comment author can see the hidden tag but other users couldn't see it.
Frontend:
Backend:

Complete BE hidding function, currently writing tests for it


Android AVD Listing not working.

I've found this issue, but seems a android command line issue, not my plugin's fault.
see https://github.com/ionic-team/ionic/issues/14291
there is a fix script, but i didn't tried yet:
export ANDROID_SDK_ROOT=/Users/[username]/Library/Android/sdk
export PATH=$ANDROID_SDK_ROOT/emulator:$ANDROID_SDK_ROOT/tools:$PATH
Where [username] is the name of your user folder.
But don't just run those commands or the change won't stay. You should add those lines to your ".bashrc" or ".bash_profile" and after that you need to reload the bash, restart the console or source the edited file, e.g.
"me@localhost:~$ source .bashrc"
But keep in mind those are the folders that worked for me, your system might be using different ones, check the folder before you change anything, you should find there the emulator.

The emulator path was changed at some point. Now it should be
/Users/my_user/Library/Android/sdk/emulator/emulator
instead of
/Users/my_user/Library/Android/sdk/tools/emulator

Thx for your info, i've tried new location, it does work. I'll fix it soon.

try this plugin jar first:
https://github.com/beansoftapp/react-native-console/blob/2019.2/react-native-console.jar

try this plugin jar first:
https://github.com/beansoftapp/react-native-console/blob/2019.2/react-native-console.jar

This one is also not working.
The new location is :
/Users/my_user/Library/Android/sdk/emulator
and not
/Users/my_user/Library/Android/sdk/emulator/emulator

try this plugin jar first:
https://github.com/beansoftapp/react-native-console/blob/2019.2/react-native-console.jar

I got this

Crate avd can't be done by simply using command line tools, so please open Androd Studio to create one.

I've already had several AVDs

Nevermind, it is working now, probably an additional IDE restart was required.

Hi. I'm getting "no Android AVD found" error.
OS is Windows 10. I have added all required environment variables for Android SDK, emulator and tools. I can run emulator manually using emulator.exe but plugin still don't see it.
Running Android Studio and AVD manager does not help.
My SDK is placed in E:\AndroidSDK and emulator is in E:\AndroidSDK\emulator
I think that there is something wrong with emulator detection

I found the android sdk with following steps:

find ANDROID_HOME env
or using android/local.properties , there should be a sdk.dir config entry.
Then plus the dir + /emulator.

Can you check your win10 env to see there is a ANDROID_HOME point to the SDK dir?

Added ANDROID_HOME env - nothing changed.
Here are my env variables:
ANDROID_HOME - E:\AndroidSDK
ANDROID_SDK_ROOT - E:\AndroidSDK
PATH - E:\AndroidSDK\emulator;E:\AndroidSDK\tools;E:\AndroidSDK\platform-tools
Maybe it would be easier to configure SDK path from Welcome screen?

Why am I getting this, I already have the AVD?

Please try the latest plugin
https://github.com/beansoftapp/react-native-console/blob/2019.2/react-native-console.jar
I've try to find emulator from PATH env first, then through the config files.
With this version, can fix this by:
sudo ln -s /Users/my_user/Library/Android/sdk/emulator /usr/bin/emulator


File path autocompletion

Hi again @dsifford 👋
I've noticed one more difference between npm completion and yarn completion and decided to share. It is to do with file paths. Here's the use case:
I've got a TypeScript / Node.js project, which stores a few data-processing actions. Folder structure looks like so:
node_modules
src/actions/do-this.ts
src/actions/do-that.ts
src/actions/....ts
src/lib/...
package.json

Every file in src/actions is an entry point, which I could run just as  node src/actions/do-this.js if they were written in pure JavaScript. The most straightforward alternative for TypeScript is to go for ts-node src/actions/do-this.ts, assuming that ts-node is globally installed. However, a local copy of ts-node is better, especially if the project is shared between multiple people.
A pretty handy alternative to typing node_modules/.bin/ts-node src/actions/do-this.ts can be creating simple proxy scripts in package.json:
    "exec": "ts-node",
    "exec:watch": "ts-node-dev --respawn --notify=false",

The commands become shorter:
yarn exec src/actions/do-this.ts
yarn exec:watch src/actions/do-this.ts

In these cases, it'd be great if yarn-completion could hint users with the paths, say after typing yarn exec src/actions/d + tab. This feature is already supported in npm: npm run exec:watch src/ac → npm run exec:watch src/actions/ etc.
WDYT?

Agree.
I added exec yesterday actually. Wasn't sure what it was for so I didn't enable path expansion. All that would need to be done is enabling path expansion in the compgen call for exec.

Re-reading this now and I think I may have misinterpreted your question. Are you saying you'd want to add path expansion to all custom scripts? Or just the new exec command?
If the former, what does npm do in that situation?

Looks like npm does autocompletion in these cases:

npm s → npm src/ (but not just after npm)
npm XYZ s → npm XYZ src/ (but not just after npm run)
npm run XYZ [...XYZ] – always

This behaviour makes sense to me and it looks reasonable for yarn completion too. I don't think we should do path autocompletion after yarn exec only – this is just an arbitrary script name.

BTW I had to update my custom scripts:
    "exec": "ts-node",
    "exec:watch": "ts-node-dev --respawn --notify=false",

↓
    "exe": "ts-node",
    "exe:watch": "ts-node-dev --respawn --notify=false",

It turned out that exec is some deprecated command in yarn, which causes glitches when I omit run. Typing yarn run exec while yarn exec was giving an error (because a special yarn's command was called). Both yarn run exe path/to/file.js and yarn exe path/to/file.js work well and it'd be great to have path autocompletion in them one day! :–)

exec is actually a brand new command that hasn't been documented yet. It was just released (IIRC) on their last minor release.
Adding path completion is on my todo list. Haven't gotten around to it just yet because it'll take about an hour to get finished up. Hopefully gonna sit down and work on that and also the workspace(s) subcommands one of these next coming days.

@kachkaev Give 0.7.0 a shot and let me know how that works for you

Thank you for working on this update 0.7 – I'm really looking forward to using the new features!
It's probably something to do with macOS again, but after grabbing the new version and trying yarn [tab] in a new Terminal, I'm getting:
yarn -bash: compopt: command not found
-bash: compopt: command not found

Urggggggh.  I've found recently that the regular one in Homebrew is not the one people with updated versions of bash should be using..
Can you try installing instead bash-completion@2 (the name might not be exactly that, but it'll turn up when you search for it)
The regular bash-completion is a waaaaaaaay outdated branch that assumes bash 3 is installed.

You're right, I had bash-completion instead of bash-completion@2!

After brew uninstall bash-completion, brew install bash-completion@2 and updating ~/.bash_profile, I started getting this in every new terminal:

So looks like one of my installed completions is not working with @2:

yarn-completion still does not work:

Switched back to bash-completion for now.

@kachkaev declare -A is a bash 4 option. All versions of bash 4 should support it.
So it looks like your login shell might not be bash 4?

You are right, it was not. I had to open Terminal settings and set Command to what I got in which bash (for Homebrew bash):

All works now! 🎉 ❤

Awesome, glad to hear.
For others who might also read this, you can also change your login shell by typing chsh in the terminal itself.

Strangely, chsh did not work for me. After changing Shell: /bin/bash with Shell: /usr/local/bin/bash (i.e. Homebrew's bash) and saving the file with :wq, I got the following error:
chsh: /usr/local/bin/bash: non-standard shell
re-edit the password file?

🤔


Support argument 'name' with /signature_request/remind/[:signature_request_id]

Allow for the argument 'name' to be supported when hitting /signature_request/remind/[:signature_request_id]

Hello,
Could you let me know an expected completion date ?

This has been fixed; Apologies for the long wait.
You can download a new build here: https://github.com/HelloFax/hellosign-dotnet-sdk/releases


When I log into minecraft, a warning about outdated connector_global_mod_aliases appears a configuration file in json format was found

Minecraft version
1.20.1
Describe the bug
Writes that the connector config is outdated
Steps to reproduce

...
Logs
No response
Additional context

Who knows how to disabling notification?

Please read the issue template more carefully. For modpack related issues, use the support channel on our discord server.

Before reporting, please ensure that:

You've installed a minimal set of mods required to reproduce the issue.
Issues with modpacks and excessive amount of mods will not be accepted, as they take a long time to diagnose.
Knowing which mods are causing problems allows us to focus on fixing the issue as soon as possible.
If you're unsure which mods might be at fault, try using binary search - removing half of installed mods
repeatedly until the faulty mod is found.

To upload logs, use an external paste site, such as Github Gist (recommended), Ubuntu Pastebin or Pastebin

the llink: https://sinytra.org/docs/connector/configuration


Fix invalid openapi definition

The current openapi definition results when using the official editor.swagger.io:
Semantic error at security.0
Security requirements must match a security definition
Jump to line 37
Semantic error at paths./real-time.post.security.0
Security requirements must match a security definition
Jump to line 14738

The security requirements are case-sensitive
Fixes: https://github.com/zulip/zulip/issues/22937

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

@cguckes can you fix the test failures?
Also @laurynmm can you take point on reviewing this? I'm not sure whether the OpenAPI specification has a preference for how we spell basic authentication.

@timabbott, I'll try but I have no background in python. Also I can't really name a timeframe. Can you give me some hints on where to start looking?

@cguckes - Thanks for working on this issue and fix!
I looked into why the tests are failing, and it seems like an issue with how we have the tests setting up the 'Authorization' header for the requests. I started a conversation here to get some community feedback on fixing these tests.


Potentially enhanced typings for ProxyHandler traps

Linked issue: https://github.com/microsoft/TypeScript/issues/51514

Proposes a better apply trap handler & narrower types on trap property access.
Change 1: apply
If I'm understanding the Proxy spec correctly here, we should be able to infer that argArray is of type Parameters<T>, since the target object needs an apply method in the first place, therefore should be Function-like.
I don't think we can't use the Parameters type built-in easily here, since we haven't sufficiently narrowed T, so we have our own variant. Open to suggestions here if there's a better way.
Change 2: Type narrowing of property access in following traps:deleteProperty, get, getOwnPropertyDescriptor, has
It seems that we should be able to narrow the type on traps which access symbols on the target object from string | symbol to keyof T. Since a consumer of a proxy object would be interfacing with type T, when we trap these calls, we should be able to infer that callers accessed properties on T.
Follow-ups:

I think there's probably some low-lift enhancement of the construct trap to, seems that argArray and newTarget should be similarly inferable to apply
Happy to write tests if this ends up being a desirable change.

To help with PR housekeeping, I'm going to close this PR while it's still waiting on its bug to be accepted.

To help with PR housekeeping, I'm going to close this PR while it's still waiting on its bug to be accepted.

Understood! If you have a chance, what does the acceptance process on bugs/issues/enhancements typically look like? I assume it's triage via the TS team, not just general support on the issue?

Usually, Awaiting More Feedback means that the TS team isn't sure how much people want/need the feature, how many people want it, and what variety of uses they would have for it. So we leave the issue open for comment to see how much interest it attracts.


DefaultChannelHandlerContext only need to point to the next inbound /…

… next outbound handler and not walk the chain all the time.
Motivation:
At the moment we use a doubly-linked-list in our DefaultChannelPipeline where each DefaultChannelHandlerContext has a prev and next pointer. This means whenever we want to handle an inbound event we will need walk the next pointers until we find an context thand handles inbound events and the same also for outbound events where we need to walk the prev pointers. This introduces some unnessary work and can be made faster by replacing our "doubly-linked-list" by having two linked-list like datastructures. One will be used for inbound and the other for outbound events. This reduce the work needed to find the next handler for either and inbound or outbound event.
This idea was provided by @njhill in https://github.com/netty/netty/pull/8816#issuecomment-459085723.
Modifications:
Change DefaultChannelPipeline to basically use two linked-list like datastructures (one for inbound and one for outbound) to reduce the cost of finding the next context that handles the event.
Result:
Less overhead when looking for the next context that can process the event.

@njhill this implements your suggestion...

@netty-bot test this please

And again this also goes into the category of "I am not sure the gain justifies the complexity".

must likely it does not justify it...

alright let me close this... it was a nice experiment but the gain is just not big enough to justify this 🚀

I did read this, but it was so complex I could not comment on it.  Closing is probably best for now.


Setting the sprite cause image to disappear

Describe the bug
if you change the sprite with the code and the image as a UIEffect the Image will disappear.
To Reproduce
Steps to reproduce the behavior:

Create an image
Add a monobehavior to set another sprite during the update
3 Set a UIEffect
The image will disappear

Environment (please complete the following information):

Platform: Editor Windows
Unity: 2019.1.4.f1
UIEffect:3.1.0

Hi @MoDDiB
Thank you for your reporting!

Did you add a UIEffect component while in play mode?
If so, it is not supported.

Also there's a known unity bug at the moment where if you set the sprite on uiimage components at runtime they dissappear. If you set the overridesprite it still works.

Any resolution for above issue? i am also facing the same problem.!

it seems there is a bug...

Can we expect any release date for above bug fix? if then please let us know :)

@mayura33
I cannot give you an ETA at this time. Sorry.


chore: Update sdks

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#630  👈
#629
#628
#613
#599
#598
#382
#381
#380
#300
#373
#377
#597
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AngelOnFira and the rest of your teammates on  Graphite


Set fee for order trades

In order to have incentive to run a Mostro node we need to set a fee for every order, this should be an small value and can be set on .env file as a percent, i.g.: FEE=0.006 is 0.6%, and this should be splitted and charge 0.3% to each part.

closing it via #79


Default devserver to HTTPS for Chrome 92

Laravel Mix Version: any
Node Version: any
NPM Version: any
OS: any

Description:
Starting in Chrome 92 (slated for release in the end of July), access to resources over private networks must be made via HTTPS, even if the site is on HTTP. This means running things like hot will no longer work, unless the assets are served via HTTPS.
This will mostly affect Mix and not the larger Webpack devserver ecosystem, as most Webpack devserver projects serve both the page and resources from the same domain/port (ie: Vue CLI devserver).
Of course this new Chrome "feature" presents the other big problem - the need for certificates or accepting insecure connections from localhost (or start Chrome with the --allow-insecure-localhost flag, which allows a bad certificate, but doesn't stop the original problem). Not really sure how we can overcome that one, except for big, flashing warnings the people will certainly ignore.
Steps To Reproduce:
Install Chrome Canary and try to run a project with hot. No javascript or css will load. Hot must start with HTTPS.

In Chrome access to localhost from a non-localhost IP already requires HTTPS on the part of the origin domain (but can be disabled) because localhost is currently considered a secure context which is why some things that are "https-only" also work on http://localhost). Are you saying localhost itself will now need a certificate? The Private Network Access doesn't seem to imply that.  Unless I'm misunderstanding, from what I can tell we need to adjust the HMR server to add a header to the appropriate response to OPTIONS: Access-Control-Request-Private-Network: true (and a few other CORS headers) which seems like something webpack-dev-server should do.
The relevant RFC can be found here: https://wicg.github.io/private-network-access/

Ahh you are right. Totally forgot I had my test domain pointing to my NAT for testing on mobile devices. So long as everything is pointing to the same IP, there is no problem. I'm going to close this as it is more an edge case.


I wish /examples/flocker/ i wish this page hadn't been removed so suddently!  It worked last week!

I wish /examples/flocker/ i wish this page hadn't been removed so suddently!  It worked last week!

Sorry for the trouble.
You can still find this in the main github repo.
https://github.com/kubernetes/kubernetes/tree/master/examples/flocker

cc @johndmulhausen

Added link forwarding to 404.md. Should work!


Empty String Fix

OK, merging this; I'll raise an issue to change the CI to GHA and solve the environment


Increment operation and concurrency with CosmosDb patch

How is concurrency handled if multiple writers attempt a patch operation on the same document and path with an increment operation?
Example:

Writer A and B both read a document. The document property /counter is 0.
Writer A issues a patch increment on /counter
Writer B issues a patch increment on /counter

What is the final value of counter? 1 or 2? This is not yet clear in the documentation. Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: baaba7e8-d79c-ca90-e36c-4282dd048bb4
Version Independent ID: 7e8f5647-b1d1-ca7e-5984-811469bf9229
Content: Partial document update in Azure Cosmos DB
Content Source: articles/cosmos-db/partial-document-update.md
Service: cosmos-db
Sub-service: nosql
GitHub Login: @seesharprun
Microsoft Alias: sidandrews

@robtextrequest Thank you for reaching out. We will look into it and update you as appropriate.

@robtextrequest, concurrency control is something you can implement using the SDK of your choice and this is independent of the PATCH operation. We already have a documentation page that walks through how to use the _etag property to prevent overwriting a write from another writer: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/database-transactions-optimistic-concurrency#optimistic-concurrency-control
#please-close

I do not think this is the right answer. The underlying PATCH API endpoints do not take an eTag as an argument. It is not possible to know if the underlying document was modified since last read without CosmosDB having the last known eTag passed as an argument.
Please see the underlying API op here: https://learn.microsoft.com/en-us/rest/api/cosmos-db/patch-a-document
Without the eTag as an argument to a PATCH operation, the only possible outcomes for an increment operation would be last writer wins or locking and increment of the value within CosmosDb.

@robtextrequest, I must have been mistaken. I'll take this to some other colleagues to see what they say.

#please-open

Hello @robtextrequest I got the answer from a person in MS product department.
The worker A or B will result in failure in that case. And the final value of the counter is 1.
When two concurrent operations attempt to update the latest version of an item within a logical partition, one of them will win and the other will fail.
https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/database-transactions-optimistic-concurrency#optimistic-concurrency-control
Cosmos DB will return 449 error to worker A or B in the case above.
https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/conceptual-resilient-sdk-applications#should-my-application-retry-on-errors
@seesharprun If there is something wrong, please tell me that. Thank you!

@shoshii @seesharprun
But in case of Increment patch Operation, we are not reading data from Cosmos DB. We just sending the command  to Cosmos DB to increment the value. So it will read the count value on Cosmos DB and will increment it.
List operations = new ()
{
PatchOperation.Increment("/count", 1),
};
ItemResponse response = await container.PatchItemAsync(
id: "e379aea5-63f5-4623-9a9b-4cd9b33b91d5",
partitionKey: new PartitionKey("road-bikes"),
patchOperations: operations
);


[AMBARI-24434] Cannot deploy HBase without HDFS

What changes were proposed in this pull request?
Allow deployment of HBase without HDFS:

do not require NameNode for hbase.rootdir
do not try to create HDFS directories if HDFS or compatible filesystem is not available (checking fs.defaultFS)
create staging directory on local FS

The dependency specified in service metainfo is not removed, so topology validation needs to be disabled.  This can be relaxed later, if needed.
How was this patch tested?
Tested blueprint deployment with HDFS and with local filesystem (setting hbase.rootdir to file:///...).  Ran HBase service check after deployment.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3511/
Test PASSed.


How to set language server IP + Port?

Can I use it like this:
target/debug/lsp-ws-proxy --listen 3001 -- langserver <IP_ADDRESS>:9901

No, the proxy uses stdio to communicate with the language server. Does your server support option like --stdio? If not, it might be possible to write some wrapper with netcat.
#!/bin/bash
PORT=9901
nc -l -p $PORT <&0 >&1 &
langserver <IP_ADDRESS>:$PORT > /dev/null

For https://github.com/phpactor/phpactor/issues/1301, I believe it uses stdio by default unless you specify the address.
Try
lsp-ws-proxy --listen 3001 -- phpactor language-server

Thank you!


test: use pytest fixture dependency injection

Pytest provides dependency injection for fixtures. When we define a file named conftest.py in tests directory(or other subfoler), pytest will discover the all defined fixtures and inject to the test function which has same signature names like fixture name.
See more details about fixtures and fixtures reference.

Thanks! This makes testing code a lot cleaner!


[DNM] benchmarks against object storage

I'm using this PR as a space to collect some info about running the TPC-H queries against object storage. Goals are to compare

Vortex
Parquet

Against storage backends

S3
S3 Express One Zone
Google Cloud Storage

Changes
This PR creates a new binary that runs every TPC-H query while logging IOs in our objectstore reader, allowing us to examine both request sizes and request counts for each query.
Parquet and Vortex are each selectable, and the bucket is also configurable.
To run the test that uses S3 Express One Zone, you need to set AWS_S3_EXPRESS=true in your .env or directly in your shell environment

Initial results
Attaching two zips, one with TRACE-level logs of executing all TPC-H queries (except q15) using the Vortex Datafusion provider.
s3express_vortex.zip
s3_vortex.zip
Some interesting bits:
Total number of IO's to perform each query:

Total time to execute the query (not including table registration)


fix: always display English name, summary and location for English cases

Describe your changes
APPLICS-912
Always display English name, summary and location for English cases, even when in Welsh mode.
Useful information to review or test
AC:
Given the user has created an english case in BO
And the project has been published
When the user navigates to Project page for the case
And select the welsh toggle
Then the project page is visible in welsh
And the project name, description and location appear in English (As there is no Welsh)
Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


first commit

hey sorry this repo is for python solutions only. feel free to fork it and make one for c solutions! if you want to drop me a link to your fork ill add it to the readme so others can find it


RoundUp overflow changes

Issue https://github.com/microsoft/Power-Fx/issues/1823

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.

✅ No public API change.


feat: add gauge component to dashboard

This PR is for the ticket #2635
Now with these changes, we can able to add a Guage component in the dashboard. Since the gauge is to occupy a full widget, I made a few changes to the component.
Verify:
https://github.com/awslabs/iot-app-kit/assets/139960352/fdf2f382-495d-475a-be4c-23ddb53247cb

it looks great locally! thank you for the work
i noticed a couple of issues:

dragging the widget around the dashboard is pretty buggy/inconsistent. the widget should be draggable from anywhere on the tile and should perform as well as the other widgets. ( i think this is related to the tooltip bug which is fixed so try rebasing from RC branch)

widget title does not appear on widget

properties color does not match gauge color and changing the property color doesnt change gauge color

cant add thresholds

it looks great locally! thank you for the work i noticed a couple of issues:

dragging the widget around the dashboard is pretty buggy/inconsistent. the widget should be draggable from anywhere on the tile and should perform as well as the other widgets. ( i think this is related to the tooltip bug which is fixed so try rebasing from RC branch)
widget title does not appear on widget

3. properties color does not match gauge color and changing the property color doesnt change gauge color

4. cant add thresholds

Rebased from RC.
2,3 & 4 These three are going to be done as part of Customization in the config panel ticket: (https://github.com/awslabs/iot-app-kit/issues/2634)


Feature/add laravel version support

Major rewrite of this plugin to allow for more tasks and differences depending on Laravel version.

Is there any plan to merge this? It looks like a nice contribution.

+1 This would be very useful.

Does this add support for Laravel 5+?

Yes

+1


CI: Update travis Ruby versions

Description
Towards a release supporting 2.7.x, this changes updates the travis builds:

Ruby 2.3.x is EOL as of 2019-03-31,
Ruby 2.7.0 is out as of 2019-12-15.

The other ruby minor versions seem up to date afaict.
Testing
Waiting for a green traivs build.
References

Ruby Maintenance Branches

Looks like the remaining deprecation warnings may be from the mongoid dependency, but it is hard to tell with those stack traces.


For silences bulk expire, handle case where some fail and some succeed

Use Promise.allSettled instead of Promise.all to better handle the case where some of the requests fail and some succeed.

/lgtm

/retest

/retest


Add steps to rollback to kube-dns

Adds instructions to rollback to kube-dns for clusters installed with CoreDNS.

fyi @chrisohaver @fturib

/hold
/assign
@kubernetes/sig-cluster-lifecycle-pr-reviews PTAL

@Bradamant3
is there anything else required to merge this PR?

bump, this would be nice to have as soon as 1.12 is released. :\

I have it on good authority @Bradamant3 will be getting to this tomorrow. 😄

Please hold off merging - CoreDNS-as-default unfortunately is pushed to 1.13 due to a last-minute scalability issue for clusters > ~1000 nodes.

Actually, nevermind, this is discussing kubeadm specifically which is OK.

Per @Bradamant3 's comment:

So I am contemplating the coredns mess that is PRs 10000 and 10012, and I think what I'd like to do is hold off on choosing either one, wait until after the release, and then drop a new and cleaner PR in (closing both these two, but not until we have a better alternative in place)

/close

So I am contemplating the coredns mess that is PRs 10000 and 10012

@zparnold PR 10012?


Feature - Expand Outline Method - "always open"

Need some way to get always opened tree without click on something, like default outline:

Maybe add another one method "always open" to settings:

I added another option cursor-always-open
For this option:

The outline will not expand/collapse automatically when you scroll the editor

The outline will still scroll, following the cursor position

Hope it fits your needs

Yes, that's so good. Thx!


Update aws-java-sdk-bundle to 1.11.965

Updates com.amazonaws:aws-java-sdk-bundle from 1.11.888 to 1.11.965.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

labels: library-update, semver-patch

Superseded by #1185.


quantumCircuit.draw( ) unable to compile latex in jupyter notebook

Environment

Qiskit Terra version: 0.18.3
Python version: 3.9.5
Operating system: Windows 10 Version 1607
Jupyter Notebook: Jupyter-core 4.7.1, ipykernel 5.3.4

What is happening?
The circuit drawer does not compile the latex code but instead throws an error using Jupyter Notebook:
WARNING Unable to compile latex...
...
CalledProcessError: Command '['pdflatex', '-halt-on-error', '-output-directory=C:\Users\USER\AppData\Local\Temp\39\tmpjmga_cb4', 'circuit.tex']' returned non-zero exit status 1.
How can we reproduce the issue?
For any quantumCircuit object use quantumCircuit.draw(output='latex') or quantumCircuit.draw(output='latex_source'), e.g.
from qiskit import QuantumCircuit, QuantumRegister
t = QuantumRegister(1, 't')
qc = QuantumCircuit(t)
qc.draw(output='latex')

What should happen?
When using
t = QuantumRegister(1, 't')
qc = QuantumCircuit(t)
a = qc.draw(output='latex_source')
print(a)

the output is
\documentclass[border=2px]{standalone}

\usepackage[braket, qm]{qcircuit}
\usepackage{graphicx}

\begin{document}
\scalebox{1.0}{
\Qcircuit @C=1.0em @R=1.0em @!R { \\
	 	\nghost{ {t}_{0} :  } & \lstick{ {t}_{0} :  } & \qw & \qw\\
\\ }}
\end{document}

When I delete the "\\" in the 4th to last and 2nd to last line and manually input the code into a latex compiler, everything works fine. I.e. I insert
\documentclass[border=2px]{standalone}

\usepackage[braket, qm]{qcircuit}
\usepackage{graphicx}

\begin{document}
\scalebox{1.0}{
        \Qcircuit @C=1.0em @R=1.0em @!R {
	 	\nghost{ {t}_{0} :  } & \lstick{ {t}_{0} :  } & \qw & \qw\\
        }
}
\end{document}

where I also fixed the indentation.
Any suggestions?
As I understand it, the circuit_drawer( ) in qiskit.visualization.circuit_visualization uses the _generate_latex_source( ) function, where it then uses the imported _latex.QCircuitImage( ) function. I think this last one is imported from latex using the latex-package for python, and I did not find the corresponding repository there. This is why I opened this issue.
A possible bug fix would probably be to manipulate the qcimg string in the _generate_latex_source( ) function and manipulate the string such that the "\\" are deleted. I would try to do it between the following 2 lines, but sadly can not test my idea at the moment.
def _generate_latex_source(circuit, filename=None,
                           scale=0.7, style=None, reverse_bits=False,
                           plot_barriers=True, justify=None, idle_wires=True,
                           with_layout=True, initial_state=False):

        ...

        qcimg = _latex.QCircuitImage(qregs, cregs, ops, scale, style=style,
                                         plot_barriers=plot_barriers,
                                         reverse_bits=reverse_bits, layout=layout,
                                         initial_state=initial_state)
        latex = qcimg.latex()

This sounds likely to be some issue related to your LaTeX installation - for what it's worth, my local install can compile the original LaTeX code fine.  Are you able to share more of the LaTeX error you see?

It's odd that the existing form doesn't work for you, but if removing the redundant line breaks fixes things, I feel like that's something we could teach Terra's visualisation modules to do.
I wonder if your failures are related to your version of qcircuit.sty or xypic.sty in your TeXLive installation - I see you've got TeXLive 2017, but my version of qcircuit.sty is dated 2018-04.  Perhaps an update made it a bit more permissive?  If you've got control over your LaTeX distributions, you might be update to update the package.  I've tried the compile on Linux, Mac and Windows without seeing the failure, but my versions of TeXLive are a bit more recent than yours.


feat: migrate current harness tests to sqlness

Which issue does this PR close?
Closes #397
Rationale for this change
migrate the harness tests to the sqlness.

add a new dependency: sqlness = { git = "https://github.com/CeresDB/sqlness.git", rev = "c077b17d73ab25460c152dc34e8f80f904522a57"}
update tokio version '1.0' to '1.21'

What changes are included in this PR?
the tests dir. I create a new module use sqlness.
Are there any user-facing changes?
none
How does this change test

@dust1 Would you like to do a rebase on the main branch to resolve the conflicts?

@dust1 I find that the harness test in the CI is broken without any information. Maybe you can run the harness test locally to check what is wrong.

🤔the ci is check lock file fail.
< name = "ceresdb-test"
---
> name = "ceresdb-test-sqlness"

i renamed the sqlness build name to ceresdb-test, but it failed

the ci is check lock file fail.
< name = "ceresdb-test"
---
> name = "ceresdb-test-sqlness"

i renamed the sqlness build name to ceresdb-test, but it failed;😥

This failure is caused by the conflicts with the main branch. Maybe you should rebase the main branch and resolve this conflict firstly.

ok

the ci was fail. I found the log is:
System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-111225-utc.log'

in my local, I use cd tests && make run was success.😥

the ci was fail. I found the log is:
System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-111225-utc.log'

in my local, I use cd tests && make run was success.😥

Oh, it seems the disk of the github workflow runner was exhausted.

the ci was fail. I found the log is:
System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-111225-utc.log'

in my local, I use cd tests && make run was success.😥

Oh, it seems the disk of the github workflow runner was exhausted. Let me rerun the ci for a try.

It seems to have failed again😂

I can't see why it failed, and I'll give another try with enabling logging.

I can't see why it failed, and I'll give another try with enabling logging and deleting the large cache file.

I can see the log in Summary.
Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-071420-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at System.Diagnostics.TraceSource.Flush()
   at GitHub.Runner.Common.TraceManager.Dispose(Boolean disposing)
   at GitHub.Runner.Common.TraceManager.Dispose()
   at GitHub.Runner.Common.HostContext.Dispose(Boolean disposing)
   at GitHub.Runner.Common.HostContext.Dispose()
   at GitHub.Runner.Worker.Program.Main(String[] args)
System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-071420-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
   at GitHub.Runner.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
   at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)
System.IO.IOException: No space left on device : '/home/runner/runners/2.299.1/_diag/Worker_20221214-071420-utc.log'
   at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
   at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
   at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
   at System.Diagnostics.TextWriterTraceListener.Flush()
   at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
   at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
   at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
   at GitHub.Runner.Common.Tracing.Error(Exception exception)
   at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)

some case was fail, may I fix it latter

@dust1 https://github.com/CeresDB/sqlness/pull/2 has fixed one issue which may lead to weird output when running sqlness tests. (I guess you may encounter the same problem when running tests locally)

@ShiKaiWi It should be all right now. I previously used git merge main to merge the changes of the main branch into my current branch. Is it possible that I missed something and the case modification of issue397 branch is not merged. small details slip up😂


Two instagram icons in the footer page in Gallery section

There are two instagram icons in the gallery section in the footer.

I can resolve this issue.Can you assign this task to me?

I want to work on this issue. Please Assign me this task.

I can solve it  and also enhance its UI. Please assign it to me.


fix: httpclient timeout value cleanup, use notimeout client for oss

这个 PR 实现什么功能/修复什么问题:
修正：整理httpclient的超时设置项，设置oss的httpclient为notimeoutclient
是否需要 backport 到之前的 release 分支:

release/2.12
release/2.13
release/2.14
release/3.0

/cc @zexi @yousong @wanyaoqi
/area util

Codecov Report

Merging #4527 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #4527      +/-   ##
=========================================
+ Coverage    6.83%   6.83%   +<.01%
=========================================
  Files         522     522
  Lines       88574   88577       +3
=========================================
+ Hits         6050    6051       +1
- Misses      82018   82020       +2
  Partials      506     506

Flag
Coverage Δ

#aFlag
6.83% <75%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/multicloud/ucloud/ufile.go
0% <0%> (ø)
:arrow_up:

pkg/util/httputils/httputils.go
39.83% <81.81%> (-0.09%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22b5b4...d9842e3. Read the comment docs.

/lgtm

/lgtm


Allow pausing alerts

It will behave like Alert object does not existing, without deleting the Alert yaml from cluster.

Fixed


feat(trace): add scheduled time setter

What this PR does / why we need it
We'd like to be able to set scheduled time to have a correct waiting and total time in logs.

JIRA ID: [XX-XX]

Notes for your reviewers

Pull Request Test Coverage Report for Build 988

8 of 23 (34.78%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 65.786%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/call/option.go
0
1
0.0%

internal/call/call.go
4
6
66.67%

pkg/trace/call_option.go
4
16
25.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/trace/call.go
4
81.25%

Totals

Change from base Build 979:
-0.5%

Covered Lines:
1619

Relevant Lines:
2461

💛  - Coveralls

:tada: This PR is included in version 1.31.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


git recipe?

It would be nice if we could have an additional recipe that pulls from git head instead of a full release.
This would allow us to do testing before a new release hits, and give users access to the bleeding edge.
We don't have to provide binary packages, just the ability for users to build locally. (We could also consider periodic "snapshot" packages)
@stuarteberg Is this something that is easily supported in conda-forge at all?

Sorry for the delayed response; I'm slammed this week.

It would be nice if we could have an additional recipe that pulls from git head instead of a full release.

conda-build does support pulling from a git repo instead of a tarball.  You could create a branch of this feedstock with that change (in your own fork).  We shouldn't merge that change to master because conda-forge policies require the use of tarballs.
Something like this would work:
source:
  git_url: https://git.skewed.de/count0/graph-tool
  git_rev: master
  git_depth: 1

We don't have to provide binary packages, just the ability for users to build locally.

Building the linux package locally is not too difficult.  When we discussed this previously, I had some concerns about the CPU_COUNT variable, but I think those issues are now resolved in the conda-forge tooling.  Building for mac is not hard either (but there's no container for it, of course).
In theory, we can do better than local builds.  If our memory limit and/or timeout woes are ever resolved, then building our snapshots directly on conda-forge's infrastructure is now possible.  Although the binary packages created by a PR build are not uploaded to the conda-forge channel, it is now possible to download them from the CI machine for local testing.  To enable those downloads, we have to add a new flag to our feedstock's conda-forge.yml file.  After that, uses can download the binary packages from the PR's Azure build results.
So, you would open a PR here from your special branch, and let the CI run as usual.  If it succeeds, the artifacts will be available for download.  As long as we never merge that PR, we can just rebuild it from time to time to update the snapshot.  (To force the rebuilds, it may be necessary to push trivial changes to the branch, e.g. to the readme or somewhere.)
BTW, I see that you've opened a new PR for graph-tool 2.34.  Hopefully it builds smoothly.  I'm afraid I won't be able to help out much for the next few days.  I will probably have more spare time next week.


Supporting non-official packages as dependencies

Hi there! Awesome docker image, I recently set this up for my personal PKGBUILD repo, it's really cool!
Unfortunately some of my packages are failing to build at the moment using this, as they depend on some AUR packages (and perhaps in the future maybe even packages not in the AUR).
I'm wondering what we might be able to do to expand this to support installation of dependencies first. I was thinking something simple like specifying an environment variable, something like
export aur_deps="homebridge-git another-dep-git"
docker run -v -e aur_deps $(pwd):/pkg whynothugo/makepkg

Then the script would just install each one before running makepkg.

Yeah, that would make sense. The only downside I can see is that I'd need to install an AUR helper first, but I'll try to look into it.

We might not need a helper necessarily, we could just download and makepkg the package, something like this:
# Install any specified AUR dependencies
for package in $aur_deps; do
    git clone https://aur.archlinux.org/$package.git /tmp/$package
    pushd /tmp/$package

    chown -R notroot /tmp/$package
    chmod -R u+rw /tmp/$package
    find /tmp/$package -type d -exec chmod u+x {} \;

    sudo -u notroot makepkg -fs --noconfirm
    pacman -U --noconfirm $package*.pkg.tar.xz
    popd
done

I was playing with this last night but was having trouble getting the docker image to build.
AUR helper might still be nicer however since it would keep the run script a little cleaner, at the cost of a more complicated Dockerfile.
for package in $aur_deps; do
    yaourt -S $package
done

That wouldn't deal with transitive AUR dependencies, regrettably. It might be possible to make it a function, and just run recursively though.

Opened up #5 with a proposed solution


Upgrading to 0.5.0 throws: this.state.newsItems is already bound to a Firebase reference

So I'm probably doing something wrong? In 0.4.0 the code below worked fine when filtering a news list by year but now Reactfire is complaining that newsItems is already bound to a Firebase reference.
componentDidMount: function() { // INITIAL LOAD
    this.getNewsList(this.props.query.year);
},

componentWillReceiveProps: function (newProps) { // FILTERING
    this.getNewsList(newProps.query.year);
},

getNewsList: function(filterYear) {
    var newsItemsRef = this.firebaseRefs["newsItems"] || new Firebase("https://XXXXXXXXXX.firebaseio.com/news");

    if(filterYear) {
        this.bindAsObject(newsItemsRef.orderByChild("_year").equalTo(parseInt(filterYear)), "newsItems");
    }
    else {
        this.bindAsObject(newsItemsRef.orderByPriority(), "newsItems");
    }
}

The two examples you have (Todo and Comments) never refresh/filter an existing array/object (only updating or deleting from it) so I'm wondering if you can point me in the right direction? Am I supposed to unbind the list before refreshing it? (This will make the list flash to empty before it's filled, something I'd like to avoid)
componentWillReceiveProps: function (newProps) { // FILTERING
    this.unbind("newsItems");
    this.getNewsList(newProps.query.year);
},

Interesting. I did make a change which disallowed binding to something which was already bound to (which kind of makes sense to me), but maybe that was the wrong decision. I see what you are saying and your use case makes sense. It'll be a bit tricky since I'll need to clear the existing listeners if they exists, but I'll go ahead and put together a 0.5.1 release which reverts that change and it should fix your issue. I'm about to go on vacation so I can't guarantee it'll happen soon, but I'll try to get to it.

Also, for what its worth, it probably makes sense to just use client-side filtering of the downloaded data stored in this.state.newsItems instead of constantly re-binding via ReactFire. Every time you re-bind, you re-download the data and you'll see the flash you mentioned. The only reason you didn't see that in 0.4.0 is because of a bug which never called off() on the previously bound listeners. I am not going to re-introduce that behavior. So your best bet here is to just download all the data and do the ordering / filtering client-side.

And after thinking about this more, I don't think I really want to change this behavior. Under the hood, I'm going to be unbinding the variable before re-binding, so I think it makes sense to require the caller to do that so they understand the performance implications of what they are about to do. I updated the change log with this breaking change so that future devs don't run into it. Sorry if it's caused you troubles. Thankfully, if you just do client-side filtering with something like lodash, you should see better performance and easier code.

OK, I really liked that bug in 0.4.0. ;)
Client side filtering will work for my particular use case but people wanting to query a very large Firebase structure (or very slow mobile clients or connections) will probably want to get the results filtered from Firebase so you might want to revisit this sometime.

Haha yeah it was a nice bug that was doing bad things under the hood :)
I definitely do see people wanting to change their query parameters, so I will keep this in mind and see how many others run into issues. It may make it's way back in before the 1.0.0 release. Thanks for opening this issue and thanks for the feedback!

Awesome, keeping my fingers crossed for a solution in 1.0.0!
Have a nice vacation!


[0.9.4] Interface exports wrong ores

Issue description:
The interface exports other things then the ones I specified on the GUI
What happens:
I have an interface which i want to export all type of ores. So I put all 8 different types in the interafce export slots, but it exports wrong ores.

From left to right i want copper(IndustrialCraft 2), bauxite(Immersive Engineering), nickel(IE), tin(IC2), iron, lead(IC2), silver(IE), gold, to be exported but for all modded ores it exports something else e.g uranium for all IC2 ores and bauxite for all IE ores.
It doesn't matter if compare NBT is on or off.
Version:

Minecraft: 1.10.2
Forge: 1.10.2 - <IP_ADDRESS>3
Refined Storage: 0.9.4

Does this issue occur on a server? [yes/no]
Did not test the issue on a server.

Not a bug. Click the "compare damage" sidebutton so it says "Yes". These ores are technically the same item, thats why you have to enable damage value compare.

Hi! I realize this issue is closed, but could you add that piece of information to the wiki for the Interface and Exporter? I have spent a significant amount of time today trying to troubleshoot this and stumbled upon this report via serendipitous google searching.

@rishenko This is not needed, already for a while now compare nbt & damage are both set to "yes" by default.