HBASE-27355 Separate meta read requests from master and client

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 20s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
3m 26s
master passed

+1 :green_heart:
checkstyle
1m  1s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 13s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
7m 49s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

34m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4801

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a64ec311f5e5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 748cad655c

Default Java
Temurin-1.8.0_345-b01

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.7.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
1m 15s
master passed

+1 :green_heart:
shadedjars
3m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
4m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  3s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

-1 :x:
unit
203m 14s
hbase-server in the patch failed.

226m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4801

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7a871fb6a117 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 748cad655c

Default Java
Eclipse Adoptium-<IP_ADDRESS>+1

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/testReport/

Max. process+thread count
2291 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 22s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
4m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
4m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 40s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  8s
hbase-client in the patch passed.

-1 :x:
unit
209m  3s
hbase-server in the patch failed.

231m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4801

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ef919bae3b38 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 748cad655c

Default Java
Temurin-1.8.0_345-b01

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4801/1/testReport/

Max. process+thread count
2216 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .


Support register-level access in python generated code

We should probably support lower-level register access in the generated python code. There may be peripherals with edge cases that the value level access can not easily accommodate. Giving access at the register level ensures that the generated code is always usable.
If we do support register level access, the python generated code should use python's builtin getters and setters.

Woops. I misread the example file. Disregard this as it is not accurate.


Added my Outline project link

Edited examples.md file to add my project link with title and details

This isn't source code

What'd you mean by source code? You wanted the website link, right?
Maybe I missed something, here's the source code


Change from Ruby 2.3.1 to 2.3.5 in .travis.yml

This was actually purposely switched back to 2.3.1 😄  See https://github.com/manageiq/manageiq/commit/a215785d5c507c8ae8bde7d487f397e37b872d85#diff-354f30a63fb0907d4ad57269548329e3


menuInsets not working

Hi, we were using the version 1.7.0 of your library in our application. We have updated your library to version 3.0.1 but "menuInsets" property not working correctly this version.
I also tried it on class CalendarViewController in your sample project and encountered the same error. Briefly, I get the same error when I try not only in class CalendarViewController but also in other classes.
I shared the line of code and the screenshot of your application.
pagingViewController.menuInsets = UIEdgeInsets(top: 15, left: 10, bottom: 15, right: 10)

How can I solve this?

I have the same issue. and this is a bug, you can check the bad code below
open class PagingView: UIView {
  public var options: PagingOptions {
    didSet {
      heightConstraint?.constant = options.menuItemSize.height
      collectionView.backgroundColor = options.menuBackgroundColor
    }
  }
...

heightConstraint will be change to options.menuItemSize.height when we set options, it should change to
heightConstraint?.constant = options.menuHeight

which is a calculate property contains itemHeight and insets
public var menuHeight: CGFloat {
    return menuItemSize.height + menuInsets.top + menuInsets.bottom
  }

@diilarakaymak
Maybe you can get the constraint by pagingVC.collectionView.constaints, and change it directly

Thanks @Scyano! I'll look into getting this fixed soon

Thanks for @Scyano my temporary patch
final class MyViewController: PagingViewController {
    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)

        self.menuInsets = UIEdgeInsets(top: 100, left: 0, bottom: 0, right: 0)

        // https://github.com/rechsteiner/Parchment/issues/573
        if let pagingView = self.view as? PagingView {
            if let constraint = pagingView.constraints.first( where: {
                $0.firstItem as? NSObject == pagingView.collectionView
                && $0.firstAttribute == .height
                && $0.relation == .equal
            }) {
                constraint.constant =  menuItemSize.height + menuInsets.top + menuInsets.bottom
                self.view.setNeedsLayout()
            }
        }
    }
}

This should be fixed now #619


Introduce paging on bookshelf term pages

The more books are added, the more lengthy a bookshelf term page becomes.
Paging should solve that issue.

Introduce paging by using a paginator and render 12 items per page.
A solution must be found to keep the topic filter working.

This may be accomplished, by generating a JSON file and using (custom) JavaScript for rendering bookshelf items on-demand.

Instead of using a JSON file, I decided to integrate htmx.
This awesome library is the perfect choice for sites being created with a static site generator like Hugo.
To install a smooth UX between pagination per infinite scroll pattern, the topic filter mechanism needed some adjustments:

"topics" was added as a taxonomy.
A list template was introduced, which renders the book cover lists separated by bookshelf.
htmx was then used and integrated to the Awesomeplete integration to load and swap the content.

Nb.: The pagination is currently not possible on filtered lists. This may become necessary in the future when more items get added to each topic.


error in google chrome

Still facing this issue.

Thanks for reporting!
I think i know why. I pushed another fix, can you please check?
Additionally can you please describe the scenario that results in such error?

Still facing this issue.

We are looking into this and will push a fix soon, meanwhile you can use it through the node package based on chromium.


Don't remove 'Open NuGet Gallery'

New version viewer too little information displayed.
And it should not be displayed in the panel, which is very unfriendly to multi-language developers. The panel should display universal tabs, the most important thing is that the display space is limited. what do you think?

I will add more information about the package on the panel.
Panel can be easily configured and you can switch off tabs that are not needed, however I will consider adding this webview page as an additional option as in the previous version.

我将在面板上添加有关该包的更多信息。
面板可以轻松配置，您可以关闭不需要的选项卡，但是我会考虑像以前的版本一样添加此 webview 页面作为附加选项。
Thank you for your reply. I am looking forward to the release of the new version. In addition, I am surprised that the repositorie  has not changed for many years has been updated recently. Thank you again for your efforts.

I've added package information, let me know if you have any feedback otherwise I will close this issue.

I've added package information, let me know if you have any feedback otherwise I will close this issue.

nice! I see it and it's great and thanks for the effort~
also, how to update packages in all projects

also, how to update packages in all projects

right now it's not possible, but I've added feature request #119  for that and will try to implement it soon

cool~ I close this iss and follw #119
thanks!


[OpenCL] Fixes device name comparison stage_op_test (#85)

Changes the fixed '/device:GPU:0' expected device name string to the
name returned by 'test/gpu_device_name()', as the device name could be
'/device:SYCL:0' or '/device:GPU:0'.

Can one of the admins verify this patch?

@jwlawson can you OK it?

@googlebot @lukeiwanski Ok with me

@jwlawson Can you sign the CLA ? We can't accept changes that you authored without a CLA in place.

We added John to the corporate CLA. Not sure what confuses googlebot.

Possibly the email used in the git commit?
It should be the same one added to the corporate CLA.

I've resubmitted this pull request myself (see #10760). Github was changing my email in the commit when Luke pulled it into his repo, causing the CLA bot to fail.

Closing.


Can't sign in. Redirected to codewars.com

I can't Sign In.
After I try it by github or email:

I am redirected to the main page with proposal to Enlist

Can't Enlist because name is already taken.

OS: [Linux Lite]
Browser [tried chrome, firefox, brave]
Version [latest]

Have you tried in Incognito/Private? I've had a few users report this via email and that worked for them (issue caused by their browser like extensions).
If that doesn't work, can you try looking at the Network tab in Developer tools? You should see something like this:

POST https://www.codewars.com/users/auth/github 302
GET https://github.com/login/oauth/authorize 302
GET https://www.codewars.com/users/auth/github/callback 302
GET https://www.codewars.com/dashboard 200

Yes I tried in Incognito/Private in Chrome and Brave.
I took different name and email and push ENLIST. Then Sign out. Now I can log in via email to my old.
I logged in and deleted account with new name and then I can log in to my old via github.
Thank you very much for your comment and work.

Thanks for reporting back. I still don't know what happened, but I'm glad you got in.

I still can't sign in with my old account. I create a new one and with a new one, I can log in and log out. But the old one still doesn't work. Frankly speaking, it's my second account I can't sign in. Can you help to merge the old accounts username babaloo (I don't remember email) and<EMAIL_ADDRESS>and let me in with my<EMAIL_ADDRESS>account?

Yes this problem is happening to me too. I get redirected from the login back to codewars.com.

I actually fixed this by:

Delete my cookies
Log in not using GitHub.
If you tried using with GitHub, go back to step 1.

For me, the bug lies in attempting to login with GitHub.

I have the same problem. I can't sign up without Github because my email is already taken. Whenever I click login via Github it gets redirected to the home page.

Same problem here, I'm getting redirected to main page after clicking sign in. I'm on version Version 112.0.5615.137 (Official Build) (arm64) of Chrome.

Same issue. Tried all the workarounds listed but none worked. :(

The issue continues, I have tried what they indicate in the comments but I still can't login

Facing the same log in issue. Redirected to the main page.


Integration test for 'istioctl verify-install'

Inspired by the bugs coming in from all the problems with 'verify-istall'.
This work item is to create a test, so that the command doesn't break unnoticed.
These are the motivating bugs:

https://github.com/istio/istio/issues/25848 template nil pointer evaluating interface {}
https://github.com/istio/istio/issues/25830 parsing error, probably due to .Status
https://github.com/istio/istio/issues/25688 'verify-install' can't handle managedFields/time
https://github.com/istio/istio/issues/25247 new parsing (fixed via revert)
https://github.com/istio/istio/issues/26026 duplicate of https://github.com/istio/istio/issues/25688

Closing because fixed by https://github.com/istio/istio/pull/28255


Updated MovieOutput to record audio properly.

This pull request fixes recording audio with video.

Hi there :)
Is this PR to record audio from a movie file ?
Or
Recording audio from the microphone ?

Camera
On Mon, Sep 11, 2017 at 3:50 PM Omar Juarez<EMAIL_ADDRESS>wrote:

Hi there :)
Is this PR to record audio from a movie file ?
Or
Recording audio from the microphone ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BradLarson/GPUImage2/pull/140#issuecomment-328639461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHh1sU_amgUwq9TmKBSCOf9XghWEL5JQks5shY8igaJpZM4Mvo-c
.

oh I see.. thanks :)
Im actually looking for a way to support movie recording WITH AUDIO from the video.. using MovieInput.
But thank you for clarifying and for your PR too.

I'm going to be looking into the same thing I'll let you know if I get it
right. Please do the same.
On Mon, Sep 11, 2017 at 5:04 PM Omar Juarez<EMAIL_ADDRESS>wrote:

oh I see.. thanks :)
Im actually looking for a way to support movie recording WITH AUDIO from
the video.. using MovieInput.
But thank you for clarifying and for your PR too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BradLarson/GPUImage2/pull/140#issuecomment-328658117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHh1sXAtTJd74WUFob-inDmM6ikRxf7qks5shaBygaJpZM4Mvo-c
.

Is your problem solved? I also encountered such a problem, hope some help.@omarojo@justinmiller62


error writing python bytes type

I get an error when trying to write a df with bytes in the column (strings cause no issue):
d = DataFrame([b'abc'], columns=['A'])
feather.write_dataframe(d, '/tmp/x.fth')
=> ValueError: cannot serialize column 0 named A with dtype bytes

Not sure if it's a bug or intentional design. On the python readme, it says a limitation of the project is

Object-type columns with non-homogeneous data

but that doesn't seem to apply here.
Pandas 0.19.2
feather 0.3.1
Python 3.5.2 |Continuum Analytics, Inc.| (default, Jul  2 2016, 17:52:12)
[GCC 4.2.1 Compatible Apple LLVM 4.2 (clang-425.0.28)]

Oddly, adding a null value to the column succeeds in writing (DataFrame([b'abc', np.nan], columns=['A']))

Should be addressed by the pyarrow-based Feather implementation


Added new TC UpdatesBackupOfUserFromAdmin

What this PR does / why we need it:
Added new TC , This testcase is applicable for csi backups and px backups.
UpdatesBackupOfUserFromAdmin - https://portworx.testrail.net/index.php?/cases/view/87568
Which issue(s) this PR fixes (optional)
Closes #PA-1406
Special notes for your reviewer:
This PR doesn't contains 2.5.2 api
logs:
s3:
https://jenkins.pwx.dev.purestorage.com/job/portworx-backup/job/system-tests/job/byoc/job/px-backup-on-demand-system-test-byoc/2406/
NFS:
https://jenkins.pwx.dev.purestorage.com/job/portworx-backup/job/system-tests/job/byoc/job/px-backup-on-demand-system-test-byoc/2408/

@snigdha-px , Thanks for reviewing, Addressed all your comments.

The test runs do not seem to be correct. In S3, the test 'DeleteBackupOfUserNonSharedRBAC' passed, but it failed in NFS. Additionally, the test names are different.

@kphalgun-px , Addressed all your comments, Please re-review it, Thanks.

Thanks for the reviews. These changes are now included in PR https://github.com/portworx/torpedo/pull/1669.


Add options to generated readme

Feature Request
Motivation Behind Feature
If you read Advanced Fastlane, you discover that you can pass parameters into Lanes. This is a great feature for more complex build/deploy situations when you're trying to fit into an existing build sequence, or you have a large number of effectively identical builds and want to reuse lanes.
However, in the generated readme, only the name of the lane is output. It would be good if that example reflected the allowed options
Feature Description
There are two approaches I can think of.
One is to add option such that option option_name, is_required, default would then be used when generating the example. At some point it would also be possible to use this to add behaviour to the lane itself (by failing if required options are missing, setting defaults).
The other approach is to add ex which is handled identically to desc (join multiple by new lines) except that it would be used in the example portion and the existing code would only be used if no ex existed.
I'm not sure which one is best. The first seems to have more long term utility.
Alternatives or Workarounds
The workaround is to simply extend the description (say with a heredoc or just many desc lines) to document these options.

I'm not sure any of this is relevant to the ticket but...
✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.5

Ruby
2.4.2

Bundler?
false

Git
git version 2.15.2 (Apple Git-101.1)

Installation Source
~/.rbenv/versions/2.4.2/bin/fastlane

Host
Mac OS X 10.13.5 (17F77)

Ruby Lib Dir
~/.rbenv/versions/2.4.2/lib

OpenSSL Version
OpenSSL 1.0.2l  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.4.1

System Locale

Variable
Value

LANG
en_CA.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.98.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.1.0

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

terminal-table
1.8.0

public_suffix
2.0.5

addressable
2.5.2

multipart-post
2.0.0

word_wrap
1.0.0

tty-cursor
0.5.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

commander-fastlane
4.4.6

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
1.0.0

bundler
1.16.0

faraday_middleware
0.12.2

naturally
2.1.0

simctl
1.6.4

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.1

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.2.2

jwt
2.1.0

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.2

httpclient
2.8.3

google-api-client
0.21.2

emoji_regex
0.1.1

tty-screen
0.6.4

openssl
2.0.5

highline
1.7.10

io-console
0.4.6

excon
0.62.0

CFPropertyList
3.0.0

mini_portile2
2.3.0

nokogiri
1.8.2

plist
3.4.0

atomos
0.1.2

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.5

xcodeproj
1.5.8

faraday
0.15.1

unf
0.1.4

domain_name
0.5.20180417

fastimage
2.1.3

json
2.1.0

unicode-display_width
1.3.2

generated on: 2018-06-27

If I'm not mistaken, the desc feature accepts markdown so you can definitely get creative with how data is loaded into it when generated.
Personally, I migrated away from complex lane logic.  To me, a lane should be simple and straight forward.  Passing data between them only increases complexity. (That's why there's lane_context)
The way that I solved the documentation problem is two fold:

Migrated all complex functionality to plugins (up to 82 Actions and 15 Helpers as of today)
Copied the Fastlane documentation generator into it's own utility that supports my plugin heavy architecture

Plugins have far more documentation and customization functionality than Lanes.  I can insert 2 descriptions, categories, platform restrictions, example code, default values, and most awesomely... I can execute them from the command line without a Fastfile.
Hacking up the Fastlane doc generator to fit my projects, I was also able to generate markdown files for each custom plugin and have it save to my repository.  When someone pulls one of my codebases, they'll see the sparse Lane readme, but appended to the end is a markdown link to where all the plugin docs are stored.
From my experience Fastlane has 2 main selling points.  1. API/Signing management with Apple.  2. A robust plugin framework.   Leverage #2 and you'll find that the plugin functionality will cover 90% of your needs.  (I'm also very interested to see how Apple's official api impacts Fastlane and its community seeing that it will make the functionality language agnostic).
Just my 2 cents.   I spent a long time trying to wrestle Lanes into how I wanted them to operate.  Once I took some time to re-architect my pipelines into a plugin first system, everything suddenly made sense.

@adamvandenhovenfm Heyyyyy 👋 I totally understand this feature request because I created a similar issue about a few months back for this - #11824
Do you want to move this discussion over there? I don't think this is a highly requested or highly used feature (which is why I haven't put this in yet) but it could provide some nice API / self-documentation level to users running your fastlane setup
This isn't a super complicated feature to add but I doneed to balance if its worth the number of users that will be using this feature 🙃 (which is why I haven't pulled the trigger to do this yet)
My lane description
In the meantime, I've been using lane descriptions like this...
desc "Bumps the version and build number on the project"
desc "The lane to run by developers"
desc "#### Example:"
desc "```\nfastlane ios bump version:2.0.1 build_number:23\n```"
desc "#### Options"
desc " * **`version`**: The version to set in the Info.plist (`CFBundleShortVersionString`)"
desc " * **`build_number`**: The build number to set in the Info.plist (`CFBundleVersion`)"
desc ""
lane :bump do
    # See previous slide for logic
end


Support Linter for Values namespace

The linter stopped working when we added the Values namespace.  Refs #897
Cause: I was duplicating the code that generated the overrides struct that container the final namespaced values. So the code was changed in releaseServer but no in the linter.
Why we did not catch it in tests: The linter test was using non namespaced values plus the  | default  functions which was hiding the problem.
Changes:
1 - Extract the struct generated to a function in chartutils (please let me know if you know a better place), so the linter and release_server uses it.
2 - Add a smoke test in the linter using the nginx template which includes all the new features (Values namespace, partial templates, etc)

closes #897

just wanted to chime in here. Thanks for adding support for the Values namespace @migmartri.
This was my output:
helm [897-values-refactorign]$ bin/helm lint docs/examples/alpine/
[WARNING] templates: templates/alpine-pod.yaml: The following functions are not returning any value [{{.Values.Name}}]

The linter did its job, so I opened up #909 to update the alpine example chart. 🎉

Ok, I'll merge it, We can discuss the timeconv issue in here https://github.com/kubernetes/helm/issues/914
Thanks for your feedback :)


One-off shows with special characters in the name may fail form validation

If submitting a one-off or special show with a special character, such as an &, in the name, the user may see an error that something was wrong with the provided data when they submit the form.
This bug is caused somewhere in the handling of the HTML entities for special characters.

Consider a show named "Rock & Roll", submitted as a one-off show with the name being entered on the submission page instead of being chosen from the list.
The file put into the holding folder is named Presenter-Rock amp Roll XXXXXX.mp3.
The form handler checks for the existence of a show file in the holding folder, but looks for Presenter-Rock Roll XXXXXX.mp3, which doesn't exist, so the process fails.

This might be fixed with 352d537b8198d6a29dc18cd1816517a22df8b510, further testing required.

This might be fixed with 352d537b8198d6a29dc18cd1816517a22df8b510, further testing required.

Nothing has come up since this change was made so seems to all be okay. Closing for now and can re-open if I'm wrong.


docs: Update Exec Summary PowerPoint deck

Overview/Summary
Adding slides to the main WARA powerpoint template to highlight the Advisor process and re-adding the disclaimer slide for CSAs to use if read access has not been granted.
Related Issues/Work Items
https://sirona.visualstudio.com/Solutions/_workitems/edit/729955
-->
As part of this pull request I have

[x ] Read the Contribution Guide and ensured this PR is compliant with the guide
[x ] Checked for duplicate Pull Requests
[x ] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
[ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x ] Ensured PR tests are passing
[x ] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
[x ] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Approved on my end.

@davenewman777 Which is the latest Mandatory - Executive Summary presentation - Template.pptx? There are two files currently, one is in this repo and other one in the IPKIt. The two files are slightly different.
Diffed to repo and IPkit (Framed by green have difference)

@tksh164
The file in the Repo should be the master. The file in the IP can be updated to match this new version. My intent was to primarily add new files to the tail end of the copy in the Repo. Once these changes are approved, I will update the file in the IP kit

Notes:

In this repo - Last update: 2024-06-25
In the IPKit - Last update: 2024-08-05

Other changes coming soon that will impact these changes. Canceling for now and will update again soon


fix empty queue in last read

Fix for corner case produced in the next situation:
async _read (cb) {
   // this._queue.length is 1
    if (this._queue.length === 0) {
      this.push(null)
      return cb(null)
    }

    try {
      while (this._queue.length > 0) {
        const key = this._queue.shift()
        // this.module.has(key) is true
        if (this.modules.has(key)) continue
        const data = await this._addOnce(key)
        this.modules.set(key, data)
        this._pending.delete(key)
        if (this.push(data) === false) break
      }
    } catch (err) {
      return cb(err)
    }

    cb(null)
  }

During the stream read:
    const dependencyStream = new DependencyStream(drive, { entrypoint })
    for await (const dep of dependencyStream) {
    // doesnt do the last read (when queue.length is 0
    }
  }

IMPORTANT: I have been able to repro this issue only in Bare, the same test works for Node,

2.2.4


📌 Remove dependency override for flutter_colorpicker

flutter_colorpicker has gotten the null safety release

@erickzanardo a new year present from @mchome :)


fix: check leader before aborting headcount/afk

closes #255

Smh you caught me as I was about to go to sleep. I'll review this tomorrow morning.


Added npm links and github repos for EVM Explorer and Dspyt DAO

/validate da4c37a1b5b0415572265404cb92de62d09c63c6

/validate da4c37a1b5b0415572265404cb92de62d09c63c6

/validate 52e54255aab49088ab3f0966b4582ac70a47c7ce

Ok, so my understanding is that npm packages should not be duplicated, what about github repos?

Any chance we could add more data on press release, news, testimonials in the schema?

Ok, so my understanding is that npm packages should not be duplicated, what about github repos?

All artifacts can only be owned once -- no duplicates :)

/validate c18108c4423997e7f707ec33345c24b6cfae7fa0


Create Markdownlint job

Could take the basic format as currently done in https://github.com/dotnet/docs/pull/31543 and replace the few repos that have copies of this similar files.

[ ] Create reference job here. In what folder?
[ ] Create problem match file here
[ ] Replace downstream jobs and problem matcher files

[ ] https://github.com/dotnet/runtime/tree/main/.github/workflows
[ ] https://github.com/dotnet/docs/tree/main/.github/workflows

/cc @BillWagner I think this is the repo that I was thinking would be dotnet/workflows

Adding @IEvangelist @gewarren for their thoughts.

Oh, yeah. I like that! I think it makes sense to take that approach, but I'm struggling to find the immediate benefit to doing this. This idea is to push us more towards using this repo as the source for custom GitHub Actions and compositions of composite GitHub Actions, right? What are the direct benefits to this — would the .markdownlint-cli2.jsonc config file be overridable in consuming repositories, or are you thinking it lives in this repository?

I think the .markdownlint-cli2.jsonc would still live in the repos, so that it can be consumed by VSCode through the markdownlint plugin (it's bundled in the Docs Authoring Pack AFAIK).
The main benefit of the job being here is mostly in centralizing the problem matcher and keeping the actions/* dependencies up-to-date in one place. You could potentially control the version of the CLI as an optional config vs the current approach of installing the latest on each run.
An alternate config is having package.json and pinned versions in the repos, but common script packages like https://github.com/mdn/workflows/pull/81. That probably doesn't make sense in this org, unless that's a path you want to take.


Keep toolbar always on top ?

Hello,
First of all, thank you for sharing your work. Also, here is a question, not an issue report.
Is there a possibility to keep the toolbar always visible on top, so that on the hamburger click, the menu drawer slides below the toolbar?

Yes this is possible, just put a toolbar outside the DuoDrawerLayout.
Example:
<LinearLayout>
    <android.support.v7.widget.Toolbar/>
    <nl.psdcompany.duonavigationdrawer.views.DuoDrawerLayout>
        <nl.psdcompany.duonavigationdrawer.views.DuoMenuView/>
        <FrameLayout/>
    </nl.psdcompany.duonavigationdrawer.views.DuoDrawerLayout>
</LinearLayout>


Add Clamp and Group

Clamp falls into the group of responsive web design tools. It works to perform the difficult job of creating a box of known aspect ratio and horizontally and vertically centering it. We can probably revisit and break it up the aspect ratio and centering. The aspect ratio is to the viewport and it'll go outside the viewport if the elements are added above the box (and elements below will be offscreen). More control needs to be afforded either with companion styling or style control through react and matchMedia to change the max-width value in those cases.
Group provides a simple common optimization when paired with immutable data. It only updates if the data changes and it only creates new react elements for data in the passed array that changed.

@MattSurabian When you get a chance, these should be ready to go at their current phase. Batch is pretty well and done. Clamp will definitely get revisited once @wilto and me figure we want people configuring it.
Realized the travis errors were node 4 and npm X complaining about peer dependency mismatch. Its a good thing we included node 4 in our test matrix.

Thanks @mzgoddard  I'll review this before the end of the day!

Changes look good to me. I wish we had a better naming convention for that clamp directory hierarchy but at least what's there is sensible. :+1: Merge when ready @mzgoddard


Error when adding to Ionic 5 project

It's great you've created an up-to-date version of an image viewer plugin for Cordova.
I have tried adding this plugin to my Ionic 5 application but I keep getting errors like these :
[cordova] e: Incompatible classes were found in dependencies. Remove them from the classpath or use '-Xskip-metadata-version-check' to suppress errors
[cordova] e: /Users/maudvd/.gradle/caches/transforms-2/files-2.1/0607a133ebed385262c1e535e01a3690/jetified-kotlin-stdlib-common-1.6.0-RC.jar!/META-INF/kotlin-stdlib-common.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.
[cordova] e: /Users/maudvd/.gradle/caches/transforms-2/files-2.1/2e79364d25f2149bc7dfbafe9903dbe5/jetified-kotlin-stdlib-1.6.0-RC.jar!/META-INF/kotlin-stdlib.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.
[cordova] e: /Users/maudvd/.gradle/caches/transforms-2/files-2.1/598ef7cd263c38322add3a6cc4646fbb/jetified-core-ktx-1.6.0-api.jar!/META-INF/core-ktx_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.5.1, expected version is 1.1.15.
[cordova] e: /Users/maudvd/.gradle/caches/transforms-2/files-2.1/792bdb42138217dd90b233994b65ff19/jetified-kotlin-stdlib-jdk7-1.6.0-RC.jar!/META-INF/kotlin-stdlib-jdk7.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.
[cordova] e: /Users/maudvd/.gradle/caches/transforms-2/files-2.1/7effc3922c7d11639802be346760d6cc/jetified-TouchImageView-3.1.1-api.jar!/META-INF/touchview_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.5.1, expected version is 1.1.15.
[cordova] e: /Users/maudvd/Documents/winkort/platforms/android/app/src/main/kotlin/de/impacgroup/zoomimageview/module/ZoomImageActivity.kt: (33, 13): Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.
[cordova] The class is loaded from /Users/maudvd/.gradle/caches/transforms-2/files-2.1/2e79364d25f2149bc7dfbafe9903dbe5/jetified-kotlin-stdlib-1.6.0-RC.jar!/kotlin/Unit.class
[cordova] e: /Users/maudvd/Documents/winkort/platforms/android/app/src/main/kotlin/de/impacgroup/zoomimageview/module/ZoomImageActivity.kt: (43, 93): Unresolved reference: java
[cordova] e: /Users/maudvd/Documents/winkort/platforms/android/app/src/main/kotlin/de/impacgroup/zoomimageview/module/ZoomImageActivity.kt: (47, 22): Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.

I have added the plugin with this command :
ionic cordova plugin add cordova-plugin-zoomimageview
And I have added these lines to my config.xml file :
<preference name="GradlePluginKotlinEnabled" value="true" />
<preference name="GradlePluginKotlinCodeStyle" value="official" />
<preference name="GradlePluginKotlinVersion" value="1.6.0-RC" />

Is there anything I can do to use this plugin in an Ionic 5 + Cordova project ?

Hi,
do you have any other cordova plugins implemented that use Kotlin?
Can you send use more information about your cordova setup? Which version of cordova and Cordova Android are you using?

Here is my ionic info output :
Ionic:

   Ionic CLI                     : 6.18.1 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.9.1
   @angular-devkit/build-angular : 12.0.5
   @angular-devkit/schematics    : 12.2.13
   @angular/cli                  : 12.0.5
   @ionic/angular-toolkit        : 4.0.0

Cordova:

   Cordova CLI       : 10.0.0
   Cordova Platforms : android 9.1.0, ios 6.2.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 17 other plugins)

Utility:

   cordova-res                          : 0.15.3
   native-run (update available: 1.5.0) : 1.4.1

System:

   ios-sim : 8.0.2
   NodeJS  : v12.18.2 (/usr/local/bin/node)
   npm     : 7.20.0
   OS      : macOS Big Sur
   Xcode   : Xcode 13.0 Build version 13A233

I don't know if my other plugins use Kotlin. But I have never had to add lines like these to my config.xml before :
<preference name="GradlePluginKotlinEnabled" value="true" />
<preference name="GradlePluginKotlinCodeStyle" value="official" />
<preference name="GradlePluginKotlinVersion" value="1.6.0-RC" />

These are the cordova plugins I have installed :
cordova-plugin-actionsheet 2.3.3 "ActionSheet"
cordova-plugin-advanced-http 3.2.2 "Advanced HTTP plugin"
cordova-plugin-androidx-adapter 1.1.3 "cordova-plugin-androidx-adapter"
cordova-plugin-camera 5.0.3 "Camera"
cordova-plugin-datepicker 0.9.3 "DatePicker"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-dialogs 2.0.2 "Notification"
cordova-plugin-file-transfer 1.7.1 "File Transfer"
cordova-plugin-file 6.0.2 "File"
cordova-plugin-filepath 1.6.0 "cordova-plugin-filepath"
cordova-plugin-firebasex 12.1.0 "Google Firebase Plugin"
cordova-plugin-geolocation 4.1.0 "Geolocation"
cordova-plugin-inappbrowser 5.0.0 "InAppBrowser"
cordova-plugin-ionic-keyboard 2.2.0 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 4.2.1 "cordova-plugin-ionic-webview"
cordova-plugin-purchase 10.6.1 "Purchase"
cordova-plugin-request-location-accuracy 2.3.0 "Request Location Accuracy"
cordova-plugin-safariviewcontroller 2.0.0 "SafariViewController"
cordova-plugin-splashscreen 6.0.0 "Splashscreen"
cordova-plugin-statusbar 2.4.3 "StatusBar"
cordova-plugin-whitelist 1.3.5 "Whitelist"
cordova.plugins.diagnostic 6.1.0 "Diagnostic"
uk.co.workingedge.phonegap.plugin.launchnavigator 5.0.6 "Launch Navigator"

As you can see in the documentation the plugins supports cordova-android 10 or above. You are using android 9.1.0 which is not supported. Please upgrade to cordova-android 10.
To check how the plugin is working we've added a small demo project.


make: fix all-homebrew target

This PR fixes No available version of ocaml-base-compiler satisfies the constraints from make all-homebrew.
I've tested it in https://github.com/Homebrew/homebrew-core/pull/67203 and it seems it helped.
Since I'm not familiar with OCaml/opam, I can't verify if this fix is legitimate or is there's a better way to fix this error.
We already use it in several other homebrew formulae like semgrep and corectl, so I hope it's not terribly wrong.
Full error, for a record:
==> make all-homebrew
export OPAMROOT="/var/folders/v5/ly_6fqkn1_l7g5w7lmwm_qlh0000gn/T/tmp.kLZp8QZI"; \
	export OPAMYES="1"; \
	export FLOW_RELEASE="1"; \
	opam init --bare --no-setup --disable-sandboxing && \
	rm -rf _opam && \
	opam switch create . --deps-only && \
	opam exec -- make
[NOTE] Will configure from built-in defaults.
Checking for available remotes: rsync and local, git.
  - you won't be able to use mercurial repositories unless you install the hg command on your system.
  - you won't be able to use darcs repositories unless you install the darcs command on your system.

<><> Fetching repository information ><><><><><><><><><><><><><><><><><><><>  🐫
[default] Initialised
[ERROR] Could not resolve set of base packages:
        Your request can't be satisfied:
          - No available version of ocaml-base-compiler satisfies the constraints

Switch initialisation failed: clean up? ('n' will leave the switch partially installed) [Y/n] y
make: *** [all-homebrew] Error 20

thanks for figuring this out!


Add a first time initalize script that does everything

Prequisites:

user must clone devcontainer
user must cd into devcontainer folder

Script tasks:

[ ] GUARDS

[ ] exit if code repos exist
[ ] exit if data stores exist

[ ] clone the code repos
[ ] startup the container (existing script -- but non-interactive?)
[ ] bundle install inside the container
[ ] write a message to user that in future they should run the startup script only
[ ] leave user in the container

 ISSUE: Add Initialize Script #DevContainer

User doesn't have to run a initialize script for the first time, it integrates into the load_profile, so every time user runs start-devcontainer.sh, it will check whether the repo exists then clone the repo if not, and execute bundle install automatically.


Using Marko as the template engine or...

I was wondering if there is a specific reason for using Handlebars? I have been wanting to try Marko for a long time and this looks like a nice opportunity, what do you think @h2non? Or maybe go further and use Elm for all the front-end? 🤔  I haven't used any of those two yet so I don't know how that would work but looks interesting, though if Handlebars is the final choice is fine to me too.

We were using Handlebars simply because it fits better with the jsdocumentation library, but I don't like Handlebars either, so ideally we can use Jade/Pug. I don't have experience with Marko, but looks like a reasonable solution.
I like Elm, but I don't think we can take much benefits using it in this project, mostly because, at the end, we won't make a huge usage of reactive programming in the browser side. jsdocs site should be simple, beautiful and easy to browse. Logic in the client-side should be minimal.
I would prefer keeping it simple and also invite other developers to help, instead of building cool funny things with it that is hard to understand for most people.

Okay cool! I might switch to Pug then, which is the one I use the most so is faster to get started, I could take a deeper look into Marko some day, though.
Thanks.


DoesNotExist: ForumUserRank matching query does not exist.

View details in Rollbar: https://rollbar.com/vlabs/Venue/items/36/
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.6/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/rest_framework/views.py", line 483, in dispatch
    response = self.handle_exception(exc)
  File "/usr/local/lib/python3.6/site-packages/rest_framework/views.py", line 443, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/usr/local/lib/python3.6/site-packages/rest_framework/views.py", line 480, in dispatch
    response = handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/rest_framework/decorators.py", line 53, in handler
    return func(*args, **kwargs)
  File "./venue/views.py", line 552, in check_profile
    name__iexact=info['position'].strip()
  File "/usr/local/lib/python3.6/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/django/db/models/query.py", line 380, in get
    self.model._meta.object_name
DoesNotExist: ForumUserRank matching query does not exist.

@alexdashkov Please investigate ASAP, thank you.


trinodb integration guide first review

Describe your changes
Added .ipynb notebook for Trino DB integration guide. Kept template similar to PostgreSQL guide, but due to different functionality in JupySQL, had to resort to some changes. For eg, %sqlplot magic command is not supporting --schema option, so specified schema in query itself. Other current issues include not being able to write entire pandas dataframe to Trino for which I have linked Trino's query length configuration properties documentation.
Issue number
Closes #436
Checklist before requesting a review

[x] Performed a self-review of my code
[x] Formatted my code with pkgmt format
[x] Added tests (when necessary).
[x] Added docstring documentation and update the changelog (when needed)

:books: Documentation preview :books:: https://jupysql--516.org.readthedocs.build/en/516/

the linting of your notebook is failing, please fix. more info here: https://ploomber-contributing.readthedocs.io/en/latest/contributing/pr.html?highlight=linting#linting-formatting

Hi @edublancas, I reconfigured my conda env with the contribution guidelines and the tests passed. However, the Read the Docs build fails due to the docker run line:
`docker run -p 8080:8080 --name trino -d trinodb/trino'
Is this because we use the bash magic command?

@TegveerG: ah, yes I forgot about that detail
readthedocs cannot run docker commands, so you need to run it locally, and then tell readthedocs not to run it: https://github.com/ploomber/jupysql/blob/b0c30bf1020a73c0a30d9362c598d99d7ac5a0fe/doc/conf.py#L18

for plotting, what if you pass --table schema.table_name, does it work?

I had tried that and it does not work, I get the following error:
ProgrammingError: (trino.exceptions.TrinoUserError) TrinoUserError(type=USER_ERROR, name=MISSING_SCHEMA_NAME, message="line 1:56: Schema must be specified when session schema is not set", query_id=20230525_205041_00042_qp4h2)
[SQL: SELECT MIN("trip_distance"), MAX("trip_distance") FROM "default.taxi"]


[6.5.x] JBPM-5278: added tests and refactoring done

This PR adds tests for automatic WID import feature.
Next 3 main changes of this PR are:

Injection of services needed to change pom.xml and DD was moved to lower level in the architecture. As consequence of this some interfaces are now more simple.

There is added try-catch block in the JbpmPreprocessingUnit class. This try-catch block ensures that installation of WIDs will continue even if the installation of some WID failed.

There is replaced method deleteAsset with the method deleteAssetFromPath. The method deleteAsset was not working and was returning false as information about not successful deletion. As consequence of the method replacement, the user will not more see the message, that the WorkItem is already installed. Instead of this the old *.wid file will be overwritten withe new one. Also the icon will be overwritten if the new wid references the same icon.

@jomarko I will test this asap and would consider this for master only and because of the changes not for 6.5.x because the preprocessing unit changes are major and could introduce some side effects that the tests do not cover. Please do not hold https://issues.jboss.org/browse/BPMSPL-295 because of this as I do think its good for master atm and would go in into the next release anyways.

@jomarko I don't see pr for this for master branch, am i wrong? if so please add and i will test asap

@tsurdilo thanks for your comments. I created PR for master branch. But I would ask you to keep this PR open. I will omit refactoring for 6.5.x branch. There will remain only tests which are necessary for BPMSPL-295. Thanks.

@tsurdilo the majority of changes is now only in tests. Please take a look when you have a moment. Thanks.

+1

Conflicts resolved, jenkins please retest this.


Allowed commands aren't auto-executed

Which API Provider are you using?
Anthropic
Which Model are you using?
Claude 3.5 Sonnet
What happened?
I cannot get chained commands to auto execute. For instance, I cannot get this one to auto execute: npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error". I have tried adding npm test and Select-String, that doesn't work.
Steps to reproduce

Add npm test and Select-String to approved commands list
Ask Cline to run npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error"
It will still require manual approval

Relevant API REQUEST output
No response
Additional context
No response

@stea9499 we might need to update the list of delimiters - got a sec to take a look?

Are changes auto-pushed? because I'm still encountering the error.
Are there plans to use the releases feature of Github?

Are changes auto-pushed? because I'm still encountering the error. Are there plans to use the releases feature of Github?

Yes these changes should be live in the latest version. Mind sharing the command that isn't working for you?
As for releases, we're still trying to nail down our release process. I assume from your question they would be helpful though?

I realize this is a totally insecure request, but.... could just get auto-approval for everything? Or maybe just a regex match @mrubens ?

Hmm I am still able to repro the original issue with npm test 2>&1 | Select-String -NotMatch "node_modules" | Select-String "FAIL|Error"

auto approve stopped working for me too

Thanks @smallstepman, I hear you. Short term this is the fix for the 2.2.29 bug https://github.com/RooVetGit/Roo-Cline/pull/222

And this should help with the original issue https://github.com/RooVetGit/Roo-Cline/pull/224

Let me know if it’s not fixed!

its fantastic, super rock solid! to the point where I think I'm taking back this

I'd also prefer to have an option to allow everything, but have a list of commands which aren't allowed

the idea with command splitting is just perfect

its fantastic, super rock solid! to the point where I think I'm taking back this

I'd also prefer to have an option to allow everything, but have a list of commands which aren't allowed

the idea with command splitting is just perfect

Great, thanks for letting me know! I was thinking of special-casing * or figuring out to support wildcards - but probably depends on how many people are excited about it.

Great, thanks for letting me know! I was thinking of special-casing * or figuring out to support wildcards - but probably depends on how many people are excited about it.

At the very beginning I thought regex support for command allowance is what's missing, but I kinda learned to live without it - in the end I started to enjoy dead simple "if the beginning matches, it's a go". There is still some intuition-level voice telling me that this approach is shortsighted, but if I spend 5min thinking, and can't think of the reason why.

venturing offtopic now, but I didn't want to spam with another issue/discussion
since all feature requests are on gh discussions, and gh-cli doesn't offer natively ways to query that, I did some rooclining and made two aliases
gh alias set discussion-list 'api graphql -f owner="$1" -f repo="$2" -f query="query($owner: String!, $repo: String!) { repository(owner: $owner, name: $repo) { discussions(first: 100) { nodes { number title author { login } comments { totalCount } } } } }" --jq '"'"'.data.repository.discussions.nodes[] | "#\(.number) \(.title) by @\(.author.login) [\(.comments.totalCount) comments]"'"'"''
gh alias set discussion-view 'api graphql -f owner="$1" -f repo="$2" -F number=$3 -f query="query($owner: String!, $repo: String!, $number: Int!) { repository(owner: $owner, name: $repo) { discussion(number: $number) { title body author { login } comments(first: 100) { nodes { author { login } body createdAt } totalCount } } } }" --jq '"'"'.data.repository.discussion | "Title: \(.title)\n\nAuthor: @\(.author.login)\nTotal Comments: \(.comments.totalCount)\n\nDiscussion:\n\(.body)\n\nComments:\n\(.comments.nodes | map("---\nBy @\(.author.login) on \(.createdAt)\n\n\(.body)") | join("\n\n"))"'"'"''

usage example
❯ gh discussion-list RooVetGit Roo-Cline
#194 multiple api keys for each provider by @tecworks-dev [2 comments]
#179 Add feature to have multiple openai compatible api config by @samhvw8 [1 comments]
#227 Staging phase like "Windsurf"? by @deiangi [0 comments]
#171 Feature request- Ability to remove messages from the chat history by @qpd-v [2 comments]
#218 Auto-Retry after 429 rate limit error by @FawwazIqbal [0 comments]
#144 Feature request: make glob service .gitignore aware by @watzon [1 comments]
#216 Vertex Setup help by @mayurjobanputra [0 comments]
#119 AutoCommits like in Aider by @PierrunoYT [1 comments]
#215 Feature Request: Save Tokens by @yurashiwa [0 comments]
#195 tool tip - enhance prompt - custom instructions (?) by @vic-cieslak [2 comments]
#135 Instead of editing the entire code, can you edit the code in between? Like Cursor? by @timurlenqs [1 comments]
#213 Implement API Key Rotation Mechanism by @mrubens [1 comments]
#170 Dockerized solution for security and safety by @byjlw [1 comments]
#214 Read Tool Enhancements by @mrubens [0 comments]
#182 Add tag based convention that will prevent Roo from updating certain files based on XML tags and attributes. by @dylanturn [0 comments]
#177 Add Feature to summary current conversion and create new task by @samhvw8 [0 comments]
#174 Feature Request: The ability to click a microphone icon/button to SPEAK your input into the text input box by @timesavers [0 comments]
#167 Shared roadmap by @aquabubble [0 comments]
#165 Any chance to run this plugin for PyCharm? by @progressionnetwork [0 comments]
#157 More detail about provider errors by @rickoslyder [0 comments]
#124 Make it so the apply_diff command can apply more than one diff at once by @mrubens [0 comments]
#118 Feature Request: Add Time Stamps To All Messages by @thebobbyboy420 [0 comments]
#109 Add exponential backoff/retry when providers error out by @mrubens [1 comments]

❯ gh discussion-view RooVetGit Roo-Cline 171
Title: Feature request- Ability to remove messages from the chat history

Author: @qpd-v
Total Comments: 2

Discussion:
This will help save on token costs if we can somehow delete messages we don't need from the chats. Especially images!

Comments:
---
By @smallstepman on 2024-12-27T05:22:01Z

Also that would be a great way to help roocline unstuck if it ever executes a command, and the output is too long (currently causing hang, which requires to restart vscode from time to time). With the ability to modify history, the operator will have an option to influence the command roocline is about to execute, e.g. `the logs will be very long, try to tail them or grep them to find what you're looking for`

---
By @jeanesh on 2024-12-27T23:41:46Z

How about computing a summary of the context accumulated upto that point. (key parts of the code, files analysed, current objectives, last x responses) and then pass this into a new task? At least then it might be able to continue in a more graceful way.

Another simpler model could be used to perform the summary.

Other ideas...applying RAG on the accumulated context from the previous task.

maybe they will be useful to you with some prompt that will start doing half of work for you, (bad) example below:
you are working on roocline, you can learn more from @/README.md

use commands `❯ gh discussion-list RooVetGit Roo-Cline` and `❯ gh discussion-view RooVetGit Roo-Cline NUMBER` to see current feature request, then check current open PRs `gh pr list` and then pick a feature request that seems to be the most important and doesnt have PR opened for it

@mrubens found an edge case
sleep 30 && kubectl get pods -n abc && echo "---" && kubectl logs -n abc $(kubectl get pods -n abc -l deployment=thing -o jsonpath='{.items[0].metadata.name}')

tried adding each of the components, and whole cmd too

subshell command is not getting accepted

ah I see
https://github.com/RooVetGit/Roo-Cline/blob/1581ed135b13dc9ce4b2587c6eb9865a3d78d6ae/webview-ui/src/utils/command-validation.ts#L112-L115
would be nice I think to decompose them instead of blocking, and verify if the command inside subshell is part of allowed commands

Makes sense! I’ll take another look soon.


restore stucture of the tutorial using sidebars

updated the links where not working
renamed online editor to chainweaver web
moved files to better reflect the docs site structure
next step: update the content of the editor tutorial page to better reflect how chainweaver works and looks currently

the reason that it's so massive is because the files have been moved in order to make the directory structure reflect the page structure of the tutorial making it easier to maintain


Readme on supermarket is corrupt

The readme on supermarket doesn't look quite right.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Neo-CLI non-interactive mode

How can I start CLI's non-interactive mode ?

Hi, welcome to Neo ecosystem. Are you developing a project on Neo? Please add me on telegram @dnsblg to learn how we can promote your project.

How can I start CLI's non-interactive mode ?

@Abilkk  CLI has not yet supported non-interactive mode.

@Tommo-L Could you please tell if you have any ETA for adding a non-interactive mode? I'm developing a one-click application for Ankr. Due to our infrastructure we are not able to use interactive mode. We would be extremely grateful if you could add this feature in the near future.

Thanks your suggestion, we can add this feature recently.

@Tommo-L Could you please tell if you have any ETA for adding a non-interactive mode? I'm developing a one-click application for Ankr. Due to our infrastructure we are not able to use interactive mode. We would be extremely grateful if you could add this feature in the near future.

I am trying to improve that function, but I didn't know what kind of environment Ankr runs on.
if you need one-click non-interactive application, how about docker images(link):
https://hub.docker.com/repository/docker/neongd/neo-cli
if there is other situation, please let me know more details.

@Abilkk Could you use it? Or we still need non-interactive mode?

@Tommo-L - yes we still need non-interactive mode.
Thanks

Port to neo3.0

neo-cli 3.0 already supports non-interactive mode startup.
https://github.com/neo-project/neo-node/blob/master/Neo.ConsoleService/ConsoleServiceBase.cs#L511-L562
The UserInteractive property reports false for a Windows process or a service like IIS that runs without a user interface. If this property is false, do not display modal dialogs or message boxes because there is no graphical user interface for the user to interact with.
see https://docs.microsoft.com/en-us/dotnet/api/system.environment.userinteractive?redirectedfrom=MSDN&view=netcore-3.1#System_Environment_UserInteractive
I was able to simulate a non-interactive startup using Visual Studio's "attach to process" method and it worked fine.

Fixed by #651


I can't play tetris

Operating system: Mac
This is:

[x ] a bug
[x ] general feedback

website's don't auto-complete when typing the name (Facebook.com doesn't pop up when I press f for instance ) - Not a bug, just something I find usefull with other browsers.
Flash Player doesn't activate when I try to play tetris :(

Hi there, we do have autocomplete so I’m not sure what’s going on there. As
far as Tetris goes, we don’t support plugins like flash. Sorry!
On Sat, May 26, 2018 at 05:06 YngDeeze<EMAIL_ADDRESS>wrote:

Operating system: Mac
This is:

[x ] a bug
[x ] general feedback

website's don't auto-complete when typing the name (Facebook.com doesn't
pop up when I press f for instance ) - Not a bug, just something I find
usefull with other browsers.
Flash Player doesn't activate when I try to play tetris :(
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/beakerbrowser/beaker/issues/1006, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHO8QVioynfBtJ6dhV1AOkGRubyook_hks5t2SkigaJpZM4UO2-5
.

You could use something like this:
`const {app, BrowserWindow} = require('electron');
const path = require('path');
let mainWindow;
app.on('window-all-closed', function() {
if (process.platform != 'darwin')
app.quit();
});
let ppapi_flash_path;
// Specify flash path.
// On Windows, it might be /path/to/pepflashplayer.dll
// On OS X, /path/to/PepperFlashPlayer.plugin
// On Linux, /path/to/libpepflashplayer.so
if(process.platform  == 'win32'){
ppapi_flash_path = path.join(__dirname, 'pepflashplayer.dll');
} else if (process.platform == 'linux') {
ppapi_flash_path = path.join(__dirname, 'libpepflashplayer.so');
} else if (process.platform == 'darwin') {
ppapi_flash_path = path.join(__dirname, 'PepperFlashPlayer.plugin');
}
app.commandLine.appendSwitch('ppapi-flash-path', ppapi_flash_path);
// Specify flash version, for example, v<IP_ADDRESS>
app.commandLine.appendSwitch('ppapi-flash-version', '<IP_ADDRESS>');
app.on('ready', function() {
mainWindow = new BrowserWindow({
'width': 800,
'height': 600,
'webPreferences': {'plugins': true}
});
mainWindow.loadURL('http://www.adobe.com/software/flash/about/');
});`

I believe i can fly !github is a place for memes!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

WHY I AM I DOING THIS I DON't KNOW

sorry that was my friend.

We'll think about adding pepper but so far we're inclined not to, because it's more overhead and it doesn't fit with how we see the Web (an open platform)

Also, Adobe will stop supporting flash in 2 years.

For what it's worth, http://htmltetris.com is pretty neat and doesn't require flash.


Files keeps crashing, no visible error code

Hello!
Yesterday I installed Files on my computer, and after some hours of usage I set it as the default files explorer on win 10 enterprise.
Everything was working fine until a couple of hours had passed, and now Files won't open. It displays the splash screen of the software, holds for about 1 second and then closes automatically

First question (and the most obvious one): Does anyone have any idea on how to fix this?
Leading to the second one: Is there any kind of logs for the app someplace, so I can try to debug or fix this myself, or at least contribute more information on this bug?
Lastly: In case there's no way to fix this without uninstalling, is there any way to revert to the default file explorer without needing to open Files?
EDIT: Already figured the third question, I reverted back to the vanilla windows file explorer using the .reg file included on the documentation

@epullay can you upload the logs? It might be easier to open a new bug report where you can use the template to include relevant information https://github.com/files-community/Files/issues/new?assignees=&labels=bug&template=bug_report.yml.


Simplify string pointers, bool, and nested err checking

Description

I was unsure why the Audit Event struct took in a *string for the TenantID field, so I was wondering if this could/should be replaced by a string, since it is just an ID.
From what I've seen in Go (and its common linters), normally booleans don't receive static constant checks (i.e. if foo == true {) but rather leaving the variables as is (i.e. if foo {).
Error messages (notably those created by errors.New(...) and errors.Wrap(...)) conventionally don't start with an uppercase letter (else, consider the case where the error is returned from a nested call and each message unnecessarily begins with an uppercase letter).
To avoid deeply nested if-else chains, normally you can just check if err != nil and return the error case (example shown in code) rather than deeply-nesting if else == nil behavior. By the end of a function, it's more readable to have a linear stream of if checks (example shown in code) and return the desired result with err set to nil.

Notes

Regarding the generated documentation here, I don't believe any of the fields listed for the Secure Audit Log Event struct are actually required (despite being under the "Required Parameters" header). I was able to post a log earlier today (screenshot below) by only setting the Message field.

@MichaelCombs28 I wanted to add that I tried following the steps to update the documentation in the README.md, but couldn't find the platform/docs/sdk/go_sdk.json referenced. The current docs up on the site don't exactly match the modified implementation (Event.Tenant is no longer a pointer, but says otherwise on the generated docs). Just wanted to make that aware.


feat(day20): implement solutions

PR to confirm build, coverage, and README.

Codecov Report

Merging #16 (1db301c) into main (112ab05) will increase coverage by 0.12%.
The diff coverage is 100.00%.

:exclamation: Current head 1db301c differs from pull request most recent head b931491. Consider uploading reports for the commit b931491 to get more accurate results

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   97.63%   97.76%   +0.12%
==========================================
  Files          37       39       +2
  Lines        3425     3617     +192
==========================================
+ Hits         3344     3536     +192
  Misses         81       81

Impacted Files
Coverage Δ

Sources/Library/Enhance.swift
100.00% <100.00%> (ø)

Tests/LibraryTests/EnhanceTests.swift
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112ab05...b931491. Read the comment docs.


AddEventLog(EventLogSettings) extension XML doc does not properly document the API

The following 1.0.0-rc1-final code copies the XML doc of AddEventLog(this ILoggerFactory factory, LogLevel minLevel) but there is no minLevel, you need to set a filter within EventLogSettings.
/// <summary>
/// Adds an event logger that is enabled for <see cref="T:Microsoft.Extensions.Logging.LogLevel"/>s of minLevel or higher.
///
/// </summary>
/// <param name="factory">The extension method argument.</param><param name="settings">The <see cref="T:Microsoft.Extensions.Logging.EventLog.EventLogSettings"/>.</param>
public static ILoggerFactory AddEventLog(this ILoggerFactory factory, EventLogSettings settings)

@Mertsch care to send a pull request?

@davidfowl yes, will do so within the next 2 days.

@JunTaoLuo you can get the PR in once it's sent.

PR is here https://github.com/aspnet/Logging/pull/306

Merged to dev after minor grammar update. Thanks @Mertsch!


FULLSCREEN option: windowed-fullscreen

Allow a bsp window (or a floating window) to be toggled as fullscreen.
This fullscreen just extends the window to the corners of the display, and toggles ignorance of gaps/bars spacing config to do so.
This way, we can get an alternative to native-fullscreen, which users don't have to script their own gaps/bar toggle respect/ignore keybind to get a bsp window to fullscreen instantly, and it also doesn't require us to write our own toggle for making the window float first and respect the current display dimensions..

yabai -m window --grid 1:1:0:0:1:1

yabai -m window --grid 1:1:0:0:1:1 || yabai -m window --toggle zoom-fullscreen is already in my setup with alt + f.
However, this obeys my bar and window spacing.
What I want is a way to simply toggle a complete fullscreen without the native macOS implementation. This will require changes to yabai itself I am sure, otherwise I can create an advanced bash toggle script to disable all my gaps config and bar spacing temperarily to fullscreen the window, but I don't want that to be for the whole space. I wish I could do this for a single window.
In other words, an instant fullscreen toggle with a command like (yabai -m window --toggle windowed-fullscreen)

Why native fullscreen doesn't suit you then? If you are using iTerm, then you can use native fullscreen in it without making a space (toggles in the settings.

the issue is still here.
I've created a manual fix but it's slow!
I think if yabai could just toggle fullscreen as an alternative to zoom fullscreen we would have this:

Why not use native fullscreen for that?

There should be an option that does NOT use macOS's animations. Native Fullscreen fades out, and moves the window to a completely different space.

I've created a manual fix but it's slow!

This is my second attempt with this.
My first used pheonixwm, before yabai v 7.0.0 and it was like so:

toggle yabai floating window
toggle fullscreen with pheonixwm. (instant)

to go back though, it was messed up.
I wanted a solution that doesn't use other window managers.
All yabai would have to do is:

add a new mode besides zoom fullscreen or native fullscreen, such as: toggle-windowed-fullscreen
make this new fullscreen "mode" ignore yabai window padding and external bar padding.
This would be an instant fix, which would keep in mind the floating back to bsp tiled.

I have a working 3rd attempt.
Leaving open for those who want this. It is a very nice feature that should already be there.

This is the functionality I was expecting:

I have a working 3rd attempt.

@aspauldingcode Where did you publish the attempt? Sorry, couldn't find a link

When a window enters native fullscreen, it changes presentation mode which causes various changes to the window. This behaviour is not something that can be activated by yabai. It is special to the "native fullscreen-space" version.
I have added a command that ignores all configured padding (both padding and external_bar padding). yabai is not able to move the window into the Notch region or below the macOS menubar, so that space will always be reserved.
It makes no sense to let the window extend into the Dock area either.
If Dock is hidden/has autohide enabled, yabai will extend the window across the Dock space.
If the MacOS menubar is hidden/autohide enabled, yabai will attempt to place the window at the topmost coordinate (gated by the notch on newer macbooks).
This works for both managed and unmanaged windows.

I tried reinstalling from HEAD. The man page now includes windowed-fullscreen, but when I try to run it I get -
unknown value 'windowed-fullscreen' given to command '--toggle' for domain 'window'

Is there a way to make sure I'm running the HEAD version?

yabai -m window --toggle windowed-fullscreen

Wow!
I compiled from source and it works.
Thank you for working on this. However, the problem now is I can drag the window around with the mouse modifier.
We still need to implement a way to lock/disable mouse-modifier based on if a window is toggled on for a windowed-fullscreen.
I've done that by using statefiles in my scripts, then setting the at modifier to something ese like fn if I move over the active window. I used sketchybar to check events to calculate this more efficiently.
It would be great (for scripting purposes like this) if you added a new mouse modifier "none" which effectively disables it manually too.
Because right now, dragging a window which is meant to be an instant fullscreen is no longer fullscreen when moved around.
Maybe there could also be a check which sets a window flag to the current window, making sure if a window is-windowed-fullscreen true that the window stays windowed fullscreen until toggled off by the command.

I got it to work too. But it looks just like the zoom-fullscreen feature. i.e. the title-bar is still visible and draggable.

When a window enters native fullscreen, it changes presentation mode which causes various changes to the window. This behaviour is not something that can be activated by yabai. It is special to the "native fullscreen-space" version.

It makes no sense to let the window extend into the Dock area either.

I would say that it does make sense, if the title bar can't be hidden. But if both are technically impossible, that is another matter.

Is this new option appear in the window properties as a new property when we --query, or is it setting the has-fullscreen-zoom? I'm on the version 7.1.2 (via homebrew) and toggling windowed-fullscreen is not reflected in the window properties.

Yes, I use this as a workaround
#!/bin/zsh
window_info=$(yabai -m query --windows --window | jq -r '.["has-fullscreen-zoom"]')

if [ "$window_info" = "false" ]; then
    yabai -m window --toggle zoom-fullscreen
    sleep 0.15
    yabai -m window --toggle windowed-fullscreen
else
    yabai -m window --toggle windowed-fullscreen
    sleep 0.15
    yabai -m window --toggle zoom-fullscreen
fi


Publish web bundle and package.json to a blob container for testing on vscode.dev

Adds steps to the package.yml for:

Publishing bits for testing vscode.dev to a blob container
Generating a URL with a SAS token to the directory for the build
Publishing that SAS as a build artifact, which you can then give to vscode.dev

Some FYIs:

Target storage account and container are defined by a pipeline variable.
The SAS has to be published as a build artifact because Azure pipelines redacts it if you just log it. To use it, you simply open the text file, copy and paste the URL, and then use it with the vscode.dev command to install from a location.
The SAS is only good for 30 days. If you need to test a build for longer you can either:

Generate a SAS on your own using Storage Explorer.
Just use a SAS from a new-build on the URL for the build-you-want-to-test, since the SAS's are good for any blob/directory in the container.

Blob service CORS rules have been configured for the storage account. You can go view those in Storage Explorer if you'd like. I'm allowing any host to make any GET request. Went with any host because I saw a variety of hosts making requests and it didn't seem worth it to try and figure out all of them. If we want to restrict the hosts we should probably just get a list from the VS Code team.
A data lifecycle rule for deleting blobs which have not been modified in 90 days has been configured for the storage account.
The container has been leased to help avoid being deleted.

Example build which is compatible with vscode.dev can be found here: https://dev.azure.com/ms-azuretools/AzCode/_build/results?buildId=58210&view=results

The SAS has to be published as a build artifact because Azure pipelines redacts it if you just log it. To use it, you simply open the text file, copy and paste the URL, and then use it with the vscode.dev command to install from a location.

That's certainly good enough for now. If we want to get fancy later we can have it create a comment on the PR with the SAS Url.


There is no response after clicking "Load More..." for an attached storage account

OS: All
Azure Resource Extension Build Version: 20220505.12 (unified)
Azure Storage Extension Build Version: 20220505.2 (unified)
Regression: Not a regression
Repro Steps:

Expand an attached storage account.
Right click the Blob Containers -> Create a new blob container -> Upload a folder contains 100 files to it.
Expand the folder -> Click "Load More...".
Check whether shows all files.

Expect:
Shows all files.
Actual:
There is no response after clicking "Load More...".
More Info:
This issue doesn't reproduce for unattached storage account.

Verified on the latest main branch build 20220901.11, it still reproduces for now.

This is fixed in RGs so once we release it'll be fixed in Storage.


seek-camera: bump seek sdk version

@AlexKaravaev this bumps the seek thermal sdk version to the latest. Maybe it will help fix the CID issues we have been noticing at jabil. Can you can test this on the orb that is having the CID issues?

since it didn't help, we are closing.


Closes #15 align cdc metadata solution with who

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md under the header # admiralpeds (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiralpeds site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

thanks @zdz2101 and @Pierre-Wallet for resolving all the metadata issues! just catching up post holidays and all looks fine. in the vignettes we can use the rda from the package here but then also explain that if ever a company needs to change any metadata then in the data-raw/ folder all the programs that create these are transparently laid out and they could adapt however they need. looks a nice and clean solution! i only spotted something minor: https://github.com/pharmaverse/admiralpeds/issues/28


violethaze74

Hi @violethaze74 letting you know that you opened an issue with no description or content?

With no title or description, I think I have to close the issue.  PLEASE feel free to open another with some details.


I can't upgrade from 1.5.1 to 1.5.2 release

Hi there
Thanks for the plugin but i have a trouble
when i download the version 1.5.2 with npm install i can't find the form angular validators inside
any help ??
Ionic info :
: 1.9.2
ionic (Ionic CLI) : 3.9.2
global packages:
Cordova CLI : 7.0.1
local packages:
@ionic/app-scripts : 3.0.1
Cordova Platforms  : android 6.2.3
Ionic Framework    : ionic-angular 3.6.0
System:
Node : v6.11.1
npm  : 5.3.0
OS   : Windows 10

Ionic info :
@ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2
global packages:
Cordova CLI : 7.0.1

local packages:
@ionic/app-scripts : 3.0.1
Cordova Platforms  : android 6.2.3
Ionic Framework    : ionic-angular 3.6.0

System:
Node : v6.11.1
npm  : 5.3.0
OS   : Windows 10

I am not sure I am following. The plugin does not have any built in validators support. Could you please elaborate more?

I am closing this due to no response.


Set reduction / minimization

Description
Here is a collection of overlapping sets grouping platforms by their family:
GROUPS = {
    "all_platforms": [
        "aix",
        "cygwin",
        "freebsd",
        "hurd",
        "linux",
        "macos",
        "netbsd",
        "openbsd",
        "solaris",
        "sunos",
        "windows",
        "wsl1",
        "wsl2",
    ],
    "all_windows": [
        "windows",
    ],
    "unix": [
        "aix",
        "cygwin",
        "freebsd",
        "hurd",
        "linux",
        "macos",
        "netbsd",
        "openbsd",
        "solaris",
        "sunos",
        "wsl1",
        "wsl2",
    ],
    "unix_without_macos": [
        "aix",
        "cygwin",
        "freebsd",
        "hurd",
        "linux",
        "netbsd",
        "openbsd",
        "solaris",
        "sunos",
        "wsl1",
        "wsl2",
    ],
    "bsd": [
        "freebsd",
        "macos",
        "netbsd",
        "openbsd",
        "sunos",
    ],
    "bsd_without_macos": [
        "freebsd",
        "netbsd",
        "openbsd",
        "sunos",
    ],
    "all_linux": [
        "linux",
    ],
    "linux_layers": [
        "wsl1",
        "wsl2",
    ],
    "system_v": [
        "aix",
        "solaris",
    ],
    "unix_layers": [
        "cygwin",
    ],
}

Now I want to have a magic function that can take an arbitrary list of platforms, and return the minimal set of families that cover the provided platforms.
And if there is no solution perfectly overlapping the initial set, I want the function to return the best set of families + remaining platforms that cover the provided set. While minimising the total number of items in the solution.
What I Did
In fact, I already implemented this in Click Extra as part of my platform detection utilities.
See for instance:

The sets of OS families and other groups
My reduce() method that does exactly what I describe in the section above.
The test cases demonstrating my implementation results.

My implementation in Click Extra is fancier than the GROUPS dictionary above: platforms and OS families are richer objects.
I simplified the GROUPS example above to make it ready-to-use for eule. Note that family and platform names are unique and do not overlap to simplify the dataset.
I'm pretty sure what I'm trying to do has already been solved and an optimal algorithm has already been written 50 years ago by Donald Knuth or someone else. 😅
My instinct tells me that this is a well-known problem, and that there is a better way to solve it. It probably has a more precise name other than reduce or minimize in the fields of set theory or graphs. 😬
At the end I already have a naive algorithm that works, but rely on heuristics and brute force to find the best solution. I guess I should try to re-implement it using some of the eule helpers. Does eule provides enough primitives to make my method more straightforward?
BTW, are spider set space (desribed in #52) the answer to my use-case?

I ask you to correct me if I cannot understand: we have the dictionary with platforms. The key  all_platforms has union without repetition of all other key values, and may be left over. In this data, we want the minimal set of families, in this case, the keys of the dictionary except for key all_platforms, that cover the provided platforms.
By definition, the method euler on library eule will take your dicionary and find the  non-empty intersections. In case you seek the key for each set, the utilitary is euler_keys. For the boundaries between intersections, you require the utilitary euler_boundaries.

The code below outputs the following results:
# Families
GROUPS_COLUMNS=[k for k in GROUPS.keys() if k != 'all_platforms']
print('GROUPS columns: '+str(GROUPS_COLUMNS))

# Platforms
GROUPS_VALUES=[]
for k, i in GROUPS.items():
    GROUPS_VALUES=GROUPS_VALUES+i

GROUPS_VALUES=list(set(GROUPS_VALUES))
print('GROUPS platforms: '+str(GROUPS_VALUES))

# Has key `all_platforms` overlapping to non-repetitive union of
# values of remaining values
is_overlapping=len(list(set(GROUPS['all_platforms']) - set(GROUPS_VALUES)))==0

print('Is overlapping: '+str(is_overlapping))

families={k: i for k, i in GROUPS.items()  if k != 'all_platforms'}

print('Euler sets: '+str(euler(families)))

Output:
GROUPS columns: ['all_windows', 'unix', 'unix_without_macos', 'bsd', 'bsd_without_macos', 'all_linux', 'linux_layers', 'system_v', 'unix_layers']
GROUPS platforms: ['cygwin', 'netbsd', 'sunos', 'wsl2', 'windows', 'freebsd', 'wsl1', 'openbsd', 'solaris', 'macos', 'linux', 'hurd', 'aix']
Is overlapping: True
Euler sets: {('unix', 'unix_without_macos'): ['hurd'], ('system_v', 'unix', 'unix_without_macos'): ['solaris', 'aix'], ('linux_layers', 'unix', 'unix_without_macos'): ['wsl1', 'wsl2'], ('all_linux', 'unix', 'unix_without_macos'): ['linux'], ('unix', 'unix_layers', 'unix_without_macos'): ['cygwin'], ('bsd', 'bsd_without_macos', 'unix', 'unix_without_macos'): ['openbsd', 'freebsd', 'netbsd', 'sunos'], ('bsd', 'unix'): ['macos'], ('all_windows',): ['windows']}
```

Is it by any case somewhat you look for?

@kdeldycke I will start a time out from now to a week in the future for closing this issue. Do you agree?

Hmmm, I see. Is the deadline anyhow pushy? I can do it, but a general implementation may require some thinking, and simplification. As you mentioned, spider sets may be useful for the method match. You list the following methods for class Euler:

as_dict: convert families on Euler sets dictionary object;
match: seek sets with the provided items (See Remark 1).
remove_region_key: Remove a set key and its items. If there is an exclusive item of this set, it will be removed from Euler set space.
sub_space: Similar to match.

Remark 1: On example with single item {'wsl1'}, your expected result to be an empty set. Why? Do you expect the user to provide the exact items of existent Euler set. It seems less reasonable than find the available families with those desired items, like you later point on method sub_space. What do u think?
Remark 2: Method remove_region_key is equivalent to delete respective key on original set. Is it so?

For the sake of clarity, let us

@kdeldycke Checkout the new release 1.0.2. Sorry, but I am still uncertain about method subspace. :-/
from eule import euler, Euler

# Euler instance
big_space = Euler(families)

print('\n')

# as dictionary
print(big_space.as_dict())

print('\n')

# Dunder method __getitem__
print(big_space['bsd'])

print('\n')

# Method match
print(big_space.match({'openbsd', 'freebsd', 'netbsd', 'sunos'}))
print(big_space.match({'openbsd', 'freebsd', 'netbsd', 'sunos', 'macos'}))
print(big_space.match({'wsl1'}))
print(big_space.match({'wsl1', 'wsl2'}))

print('\n')

# Method remove_region_key
big_space.remove_key('linux_layers')
big_space.as_dict()

@kdeldycke The new release resolves your proposal except for method sub_space. This method requires clarification from my side. Do you mind explaining ir once again?

@kdeldycke I will close this method since I received no further response within two months. Thanks for suggestions though!

Thanks @brunolnetto for the implementation of the Euler class! I'll play with it and see how I can make good use of that one. Will keep you posted on my discoveries.


RATreeNodeController controllerForItem only works for rows that are currently visible

The self.mutablechildControllers property of RATreeNodeController (exposed via the childControllers accessor) only contains the currently visible child nodes, not any "folded" child nodes.
As such, the RATreeView expandRowForItem method will only work if the provided item is currently visible in the tree hierarchy, as the controllerForItem method within RATreeNodeController will  return nil if it can't find the item in the hierarchy.
Is this the intended behaviour? If so, is there any other way of highlighting and displaying the relevant node (and parent nodes) for a given item? (The use case being a split view controller, with the RATreeView being used in the master VC. As  navigation actions may also occur within the detail VC, the RATreeView needs to be updated to remain in sync.)

Hey,
Yes. Sorry for really long response time. This is intended behaviour. Because of the performance reasons I don't want RATreeView to create the whole hierarchy of node controllers if there is no need for that (in order to correctly display tree view).
You can display interesting node by calling expandRowForItem:expandChildren: method. If the row you want expand/modify isn't visible you have to expand its parent (or the whole chain of parents) first. You can do that by calling expandRowForItem:expandChildren: method and using parent (or all parents from the chain of parents) as an argument.
Example:
You want to modify show row for C item. C is a child of B and B is a child of *A(. It can be shown as chain A -> B -> C.
To show C you have to expand A and B. Example of how you can achieve that is presented below.
[self.treeView expandRowForItem:A expandChildren:NO withRowAnimation:];
[self.treeView expandRowForItem:B expandChildren:NO withRowAnimation:];

I hope that it helps.


Fixed typo in ConfigProvider

Solves issue #31

the typo made bug, so it should be pointed to master imo

Please not that https://github.com/zendframework/zend-navigation/pull/35 fixes the same issue but also adds a unit test.


Add apiExample js file to dist

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #7
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Edit script and .npmignore to add toggleDrawer.js to the dist directory
Update labels to auro-drawer

Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🌱 Bump cert-manager in Tiltfile and script

xref: https://github.com/metal3-io/metal3-dev-env/pull/1094#event-7661271690

/test-ubuntu-integration-main