Uncaught Error: This TextEditor has been destroyed

[Enter steps to reproduce below:]

open vim search (/ key)
close tab
type search term and hit enter.

Should either: search on current tab, or pop you out of vim search mode upon tab closure.
Atom Version: 1.4.1
System: Mac OS X 10.11.3
Thrown From: vim-mode package, v0.64.0
Stack Trace
Uncaught Error: This TextEditor has been destroyed
At /Users/marnold/.atom/packages/vim-mode/lib/vim-state.coffee:276

Error: This TextEditor has been destroyed
    at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:790:15)
    at TextEditorMarker.module.exports.TextEditorMarker.getHeadScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:179:33)
    at Cursor.module.exports.Cursor.getScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:73:26)
    at Cursor.module.exports.Cursor.getScreenRange (/Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:685:20)
    at Cursor.module.exports.Cursor.autoscroll (/Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:690:51)
    at Cursor.module.exports.Cursor.changePosition (/Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:675:21)
    at Cursor.module.exports.Cursor.setBufferPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/cursor.js:80:19)
    at SearchBase.moveCursor (/Users/marnold/.atom/packages/vim-mode/lib/motions/search-motion.coffee:23:14)
    at Search.Motion.execute (/Users/marnold/.atom/packages/vim-mode/lib/motions/general-motions.coffee:37:8)
    at VimState.module.exports.VimState.processOpStack (/Users/marnold/.atom/packages/vim-mode/lib/vim-state.coffee:279:23)
    at VimState.module.exports.VimState.processOpStack (/Users/marnold/.atom/packages/vim-mode/lib/vim-state.coffee:271:10)
    at VimState.module.exports.VimState.pushOperations (/Users/marnold/.atom/packages/vim-mode/lib/vim-state.coffee:237:8)
    at SearchViewModel.ViewModel.confirm (/Users/marnold/.atom/packages/vim-mode/lib/view-models/view-model.coffee:11:15)
    at SearchViewModel.module.exports.SearchViewModel.confirm (/Users/marnold/.atom/packages/vim-mode/lib/view-models/search-view-model.coffee:41:5)
    at SearchViewModel.confirm (/Users/marnold/.atom/packages/vim-mode/lib/view-models/search-view-model.coffee:1:1)
    at vim-normal-mode-input.VimNormalModeInputElement.confirm (/Users/marnold/.atom/packages/vim-mode/lib/view-models/vim-normal-mode-input-element.coffee:45:16)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:97:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands
     -0:34.9.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
  3x -0:34.4.0 vim-mode:move-left (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:31 vim-mode:search (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:31 blur (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:29.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  2x -0:29.2.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:27.4.0 vim-mode:change (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:27 vim-mode:move-to-next-word (atom-text-editor.editor.vim-mode.is-focused.operator-pending-mode)
  2x -0:09.7.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:09.1.0 core:save (atom-text-editor.editor.vim-mode.is-focused.insert-mode.autocomplete-active)
     -0:07.7.0 vim-mode:activate-normal-mode (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:06.2.0 vim-mode:search (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:06.1.0 blur (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -0:04.9.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:04.0 core:close (atom-text-editor.editor.mini.is-focused)
     -0:01.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ]
  },
  "vim-mode": {}
}

Installed Packages
# User
language-haskell, v1.5.2
minimap, v4.19.0
pigments, v0.21.0
terminal-plus, v0.14.5
vim-mode, v0.64.0

# Dev
No dev packages

I have same issue

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Allow to Format Only Changed Lines

Problem:
Currently, when I make changes to a document and save it, VSCode formats the entire document. This behavior alters the line blame in Git, attributing more changes to my name than I actually made, which is concerning.
Request:
It would be highly beneficial if VSCode could provide an option to format only the lines that have been changed, rather than the entire document. This would help maintain accurate Git blame history and avoid unnecessary formatting changes across the document.

You can already do that using the "editor.formatOnSaveMode": "modifications" setting.

I didn’t know that
Thanks👍


Editing guide error: Missing "env"

The command to create a conda environment for building the website locally misses the "env". It should be:
conda env create -f env.yml

Oops, I fixed it before I saw you self assign.

Perfect!


Queuing mechanism for txpool

At the moment, txn pool is a channel and can't be re-read to check for consistency / transaction execution during the round validations of PBFT.
Need to add a queue for this, and also attach multiple channels for handoff during errors, ensuring high availability.
cc/ @hixichen

addendum: queue could be stored on / retrieved from disk, maybe using leveldb. opening separate issue for integration of leveldb. #34


Developing versions of filters and AdventOfCode day3-part2 challenge

Thanks for trying this out and having a shot at implementing filters!
For comparison, I think I would like to see how AOC day 3 works with the alternative approach I prototyped in the "generatorAsFilter" test. Do you want to quickly try that as well?
Regarding the implementation in this PR in ir.js, the addition of 'preds' to every expression seems a bit heavy, so if we can do something like deps.filter(isPred) that would look preferable. Filters could be a special kind of variable, or, using the "generatorAsFilter" approach, they are just regular index variables.
As you mentioned, there is also some redundancy in checking predicates. If we treat filters (conceptually) as lookups in 0- or 1-element collections , then we can reuse most of the existing nesting logic from traversals, and perhaps get some additional benefits by hoisting generator that we know are in fact filters.

Thanks for trying this out and having a shot at implementing filters!
For comparison, I think I would like to see how AOC day 3 works with the alternative approach I prototyped in the "generatorAsFilter" test. Do you want to quickly try that as well?
Regarding the implementation in this PR in ir.js, the addition of 'preds' to every expression seems a bit heavy, so if we can do something like deps.filter(isPred) instead that would look preferable. Filters could be a special kind of variable, or, using the "generatorAsFilter" approach, they are just regular index variables.
As you mentioned, there is also some redundancy in checking predicates. If we treat filters (conceptually) as lookups in 0- or 1-element collections , then we can reuse most of the existing nesting logic from traversals, and perhaps get some additional benefits by hoisting generators that we know are in fact filters.

Thanks for trying this out and having a shot at implementing filters!
For comparison, I think I would like to see how AOC day 3 works with the alternative approach I prototyped in the "generatorAsFilter" test. Do you want to quickly try that as well?
Regarding the implementation in this PR in ir.js, the addition of 'preds' to every expression seems a bit heavy, so if we can do something like deps.filter(isPred) instead that would look preferable. Filters could be a special kind of variable, or, using the "generatorAsFilter" approach, they are just regular index variables.
As you mentioned, there is also some redundancy in checking predicates. If we treat filters (conceptually) as lookups in 0- or 1-element collections , then we can reuse most of the existing nesting logic from traversals, and perhaps get some additional benefits by hoisting generators that we know are in fact filters.

Thanks so much for the feedback, I will try the generatorAsFilter test!

This one also seems to be superseded by other work in the meantime.


App Service Environments & Isolated Pricing tier

I followed this article, to deploy my spring boot application on existing web app created in Isolated plan.
It fails with "Invalid pricing tier", does this plugin supports Isolated plans / Plans hosted in App service environments?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c13f5f59-c119-40e6-1396-d6e65b737693
Version Independent ID: eb8a9ad0-44fc-6e06-adb0-29df32aee19a
Content: Create a Java web app on Linux - Azure App Service
Content Source: articles/app-service/containers/quickstart-java.md
Service: app-service-web
GitHub Login: @msangapu
Microsoft Alias: msangapu

@dhananjaypatkar , Thanks for brining this to our attention. We will investigate it further and update you shortly.

@dhananjaypatkar , For AppService Isolated plan is not available in Azure CLI. You can try this command to see the list of available SKU.
az appservice list-locations -h

So instead what you can try doing is

Create an App Service Environment.
Then you can deploy the app to the plan that is associated to your App Service Environment.

Try this and see if it helps you resolve your issue. If not, please feel free to tag me in your reply so we can happily continue this conversation.

@dhananjaypatkar ,  Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and we will gladly continue the discussion


MDaemon Features Wishlist

I would like to add the following features to MDaemon:

update current magnetic field in regular intervals (30s or 1min)
magnetic field logging with graphic interface.

Support X Y Z axes
Control vector magnetic field rotation.


[Suggestion]: More than one item dropped

General Info

[X] I would like to propose new content
[X] I would like to propose changes
[ ] I would like to propose another thing

Suggestion Description
When the panda sneezing is their a way to increase how may items drop?// instead of one per sneezing and also make the Spore Blossom make the panda's sneezing more like a boost in the time it takes for the panda to sneezing

You can change the item by creating a datapack and adjusting the result item

How do I increase the drops cause the datapack only drops 1 item per sneeze


[PE-D][Tester A] UG PDF Formatting

You may want to consider adding page breaks to prevent content from being cut off at weird places when being downloaded as a PDF to make it look neater in a PDF format and improve users' reading experience.
Some examples are:

Labels: severity.Low type.DocumentationBug
original: Fluffykan/ped#2

Duplicate of #234


Is it possible to send data from browser to puppeteer - get function like in php ?

Hello,
i use Puppeteer for scrap.
I managed to transform a page written in javascript into an html page. I was then able to display this html page on my web server with the "createServer" function.
The problem is that the link to the javascipt page is written directly in the puppeteer script.
I would like puppeteer to be able to have a GET function, as in PHP, so that it can retrieve the http link that I send through the browser and then send me the page transformed into html.
For example:
http://myserver.com?link=http://link-to-transform-in-html
In puppeteer:
await page.goto ("http: // link-to-transform-in-html", {waitUntil: "networkidle2"});
is it possible?
thanks

Hello,
I think StackOverflow will be a better source for questions like these; we try to use GitHub issues for feature requests and bug reports. Thanks!


Tabular: Ensure unique model names

Issue #, if available:
Description of changes:

Addressed duplicate model name issue, now when models share the same name, one will have a unique suffix appended to it. This is a pre-req for repeated fit functionality to work smoothly. Prior, the model would overwrite the earlier model it shared a name with, leading to major bugs with stackers having their base models overwritten. This bug did not happen in current usage, but could start to happen if users were allowed to call fit repeatedly.
Removed duplicate stack trace print on model exception, before the stack trace was being printed twice.
Simplified hyperparameters argument in Trainer.train_multi_levels to handle the same input format as users provide in task.fit(hyperparameters), in preparation for repeated fit functionality.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-762-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-762/2/index.html

Job PR-762-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-762/3/index.html


Library Cannot initialized message

Dear Majerle,
Thank you very much for your library work.
I'm testing SMS Send Receive RTOS exampla on windows. I get the following message from the app:
Cannot initialize GSM-AT Library
than application starts and ready for receiving SMS.
I sended a SMS to device. Than  I get the following message from the app:
New SMS received!
Cannot start SMS read procedure!
What I did wrong?
I'm using Visual Stıdio 2019 Community Edtion(v142).
Regards,

I upgrade sim800c firmware and problem solved.


Database coverage on a mobile device is unreadable

The format used to display on a mobile device is the same as for  desktop. As such it is unreadable
e1 U 4 S 9 C5: P19

We can make it scrollable if @Captainkirkdawson you feel that will suffice?

I am not a user of CEN hence cannot comment on whether scrollable would be adequate.
Certainly would make it usable in its current form.
In all other cases we avoided Tables on mobile devices.
The best solution technically is likely a selection of year and country and a a simple display of the one record. Browsing with a 500 entry table is bad news on a mobile

On Google Pizel 3Xl, the table is scrollable, as is the 'details' table.  The two graphs pages are  not scrollable, but viewable in horizontal view.  Agree that a page to select year and county (with resulting page having links to the two graphs) is an improvement.  Graphs will still need to be scrollable for smaller phones. Will create new story for improvement.

I really should learn not to comment on the fly. Yes the current basic table is scrollable hence my comment about it Certainly would make it usable in its current form. is incorrect.
At the same time the original comment about the need for improvement remains. I would never use the current display on a phone

New Records pages work fine on a Pixel XL using DuckDuckGo (have found it impossible to test on Chrome as chrome won't recognise any website it can't crawl, it seems...).


Define an official grammar for documentation and site in Bevy

How can Bevy's documentation be improved?
While reviewing some PRs from Migration Guide and Bevy site in general I saw a lot of fixes which where just converting from "en-GB" to "en-UK". Since Bevy doesn't have stated somewhere (AFAIK) which one is the "official" Bevy one, those can't be considered valid fixes, since both are valid english.
It would be nice if Bevy explicit define somewhere, maybe on CONTRIBUTING.md, which gamar to use while writing docs or any formal communication or even if it allows any "en" variation, and such, we don't consider those conversions to be valid fixes anymore.

Beyond documentation, it would be good to have an official language for code as well. As an Australian, I'd love to write centre, colour, and stabilise (instead of center, color, and stabilize) as an example. But, I operate under the assumption that an en-US style is preferred, despite not seeing anything confirming that assumption.
Perhaps under the CONTRIBUTING.md document in ## How you can help there could be a section such as ### Standards to put things like preferred languages, grammar, etc.?

Yeah, this popped up in https://github.com/bevyengine/bevy-website/pull/1003#discussion_r1493438634 as well. The blog posts used US spelling in the past, but it would be nice to codify it.


Netlify CMS in a monorepo still commits relative to root directory

We have a project that stores the netlify cms codebase in web/ and the netlify cms configs are in web/_content when we view the admin from the site it works just fine because it's loading it relative to netlify.toml's base config (which is web).  When you commit it stores the updated files in <root>/_content instead of web/_content.

We can't store the _content outside of the base directory for obvious scope/access reasons. Errors like Failed to load entry: API_ERROR: "params.folder" must resolve to a path under the configured repository show up.
We can't use file: "web/_content" in our CMS config because it looks for it in web/web/_content

Solution
To add a config parameter for netlify cms admin to use as a "base" directory (similar to netlify's base config in netlify.toml)

Hi @panbanda, can you fill in the missing details from the issue template?
Specifically you CMS configuration and repo structure. I'm not sure I understand the requirement for a base directory configuration, as you should be able to point the CMS to store collections and files anywhere in the repo.

I'll add that in order to solve this issue, in the meanwhile, I have a symlink from ./content to ./apps/cms/content and it works fine.  Ideally that wouldn't need to be there.

Thanks so much for finding this and posting your solution. We have been struggling with this on https://gitlab.com/fedora/websites-apps/fedora-websites/fedora-websites-3.0 and are using your symlink solution for now also. Thank you @panbanda


bevy_reflect: Small refactor and default Reflect methods

Objective
Quick followup to #4712.
While updating some other PRs, I realized the ReflectTraits struct could be improved. The issue with the current implementation is that ReflectTraits::get_xxx_impl(...) returns just the logic to the corresponding Reflect trait method, rather than the entire function.
This makes it slightly more annoying to manage since the variable names need to be consistent across files. For example, get_partial_eq_impl uses a value variable. But the name "value" isn't defined in the get_partial_eq_impl method, it's defined in three other methods in a completely separate file.
It's not likely to cause any bugs if we keep it as it is since differing variable names will probably just result in a compile error (except in very particular cases). But it would be useful to someone who wanted to edit/add/remove a method.
Solution
Made get_hash_impl, get_partial_eq_impl and get_serialize_impl return the entire method implementation for reflect_hash, reflect_partial_eq, and serializable, respectively.
As a result of this, those three Reflect methods were also given default implementations. This was fairly simple to do since all three could just be made to return None.

Changelog

Small cleanup/refactor to ReflectTraits in bevy_reflect_derive
Gave Reflect::reflect_hash, Reflect::reflect_partial_eq, and Reflect::serializable default implementations

The big win here definitely feels like the default methods for Reflect :) Are we manually implementing None anywhere in our codebase for these?

The big win here definitely feels like the default methods for Reflect :)

Yeah maybe I should have focused more on that 😅

Are we manually implementing None anywhere in our codebase for these?

Yeah I found a handful of places that return None. Should I get rid of those?

bors r+


Prepare a presentation

Depends on https://github.com/objectionary/proof/issues/16
In the presentation, explain

[ ] Formal confluence for minimal calculus
[ ] (Optional) Explain the Lean code

Formalization of confluence of minimal φ-calculus in Lean 4.pdf


Google Colab

Has anyone managed to get this project running on colab ?
Here is my code for now:
!git clone https://github.com/ali-vilab/AnyDoor.git

%cd AnyDoor/

!pip install -r requirements.txt

I changed the opencv-contrib-python version to <IP_ADDRESS> as suggested here #31
But still have errors during installation.

Click to expand error log
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed.
This behaviour is the source of the following dependency conflicts.
ipython 7.34.0 requires jedi>=0.16, which is not installed.
lida 0.0.10 requires kaleido, which is not installed.
tensorflow 2.15.0 requires numpy<2.0.0,>=1.23.5, but you have numpy 1.23.1 which is incompatible.
tensorflow-probability 0.22.0 requires typing-extensions<4.6.0, but you have typing-extensions 4.9.0
which is incompatible.
torchaudio 2.1.0+cu121 requires torch==2.1.0, but you have torch 2.0.0 which is incompatible.
torchdata 0.7.0 requires torch==2.1.0, but you have torch 2.0.0 which is incompatible.
torchtext 0.16.0 requires torch==2.1.0, but you have torch 2.0.0 which is incompatible.

For an inference-only Colab, you might refer to my huggingface version at https://huggingface.co/spaces/xichenhku/AnyDoor-online/tree/main


ype

Scope
If you have a usage question, please ask on StackOverflow or Gitter (live chat)
This form is for reporting bugs in or adding enhancements to ng-admin.
Prerequisites

Are you running the latest version of ng-admin?
Did you check the documentation?
Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
[Description of the bug or feature]
Steps to Reproduce
If applicable, demonstrate your bug using a Plunkr live demo. You can fork this ng-admin plunkr: http://plnkr.co/edit/xiRijR1CeETB2qoz8krp

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]

It should be a mistake. Closing it!


Can't find Stylesheet

First web project here, and i'm beating my head against the wall. I can't find the stylesheet - could someone point me in the right direction?

gatsby-starter-netlify-cms/src/components/all.sass  I think

I feel like nothing in all.sass works, at least for me. Changing any property in there does not do squat, even with the dreaded !important

I feel like nothing in all.sass works, at least for me. Changing any property in there does not do squat, even with the dreaded !important

Previously there were build issues with the sass file but we've since updated to make it is working properly. If there are any further issues please feel free to open them on the repository


add: tokens to reflect correctly Chainport's TVL

Hi L2Beat,
Thank you for adding Chainport to the platform!
To reflect Chainport's TVL correctly, we've added a few tokens.

@lucadonnoh  any update with this please?

There is no need to add "formula" field to every config, please only add new tokens, do not modify the current ones

@antooni I've fixed the PR according to your comments.

Hi @antooni
Please let me know if there's anything to edit in the PR, or if it can be merged.
Thank you

@antooni any updates?

@odedNea can you resolve the requested changes?

@antooni @maciekzygmunt
Resolved


What's the best practice for manage more and more VSTS build release definition?

Hi All, we have more and more build/ release definitions.
how to manage them and upgrade task info/version?

not a task issue from this repo.  also an open ended question, not a specific issue


fix infinite loop in Token Cleanup after concurrency exception

#4492

One thing to note is that you don't inspect the type of the conflicted entry and make an assumption that these are all persisted grants.

Yea, as I was working on it I did have that type of check and realized given the nature of what this was being used for I felt it was unnecessary.

@brockallen Any chance for 3.1 release with this? :crossed_fingers:

#4492

@brockallen I am using 4.0.2 and facing same error. Can you help


Use log_softmax in D.Categorical

Use #5215 to improve https://github.com/chainer/chainer/pull/5028#discussion_r205992337

LGTM!

jenkins, test this please.


Pastebin does not work over 512kb

Hello
i tried pastebin and it does not work, i exceeded the quota, i tried my own server where i paste it in .txt file does not work.
any ideas how to proceed?

that s not an issue you did something wrong

i did not, is it possible to load it from local pc instead of pastebin?

Loading locally i still didn t add that i might add it soon

can you upload video tutorial let say on vimeo instead of youtube where it gets deleted?

sorry won t record videos anymore if anybody else of the users want to record one i will link to it

can you at least tell me how to use pastebin my loader.txt has over 1000kb and when i paste it into pastebin i get error that all characters has been used up limited to 512kb?

again that s not an issue pls stop chatting in the issue section   if you just upload the file into any other palce and get raw url it will work

i uploaded it here and it does not work https://kazybot.8u.cz/huh.txt

i m sorry i can t help you  i won t reply anymore  if another reply on the same issue


High Priority -  Firmware versions updated for Phones

To be published today 2/7/2022

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

closing. outdated.


Child builders for properties not generating correct code

I'm having a few issues generating builders on a child List property.
Scenario 1
public class User
{
    public List<Option> Options { get; set; }
}
public class Option
{
    public string Name { get; set; }
}

[AutoGenerateBuilder(typeof(User))]
public partial class MyUserBuilder {}
[AutoGenerateBuilder(typeof(Option))]
public partial class MyOptionBuilder {}

Build error:
...\FluentBuilderGenerator\FluentBuilderGenerator.FluentBuilderSourceGenerator\FluentBuilderSandbox.Option_IListBuilder.g.cs(28,46,28,59): error CS0246: The type or namespace name 'OptionBuilder' could not be found (are you missing a using directive or an assembly reference?)
Scenario 2
Main project
public class User
{
    public List<Option> Options { get; set; }
}
public class Option
{
    public string Name { get; set; }
}

Test project
[AutoGenerateBuilder(typeof(User))]
public partial class UserBuilder { }

[AutoGenerateBuilder(typeof(Option))]
public partial class OptionBuilder { }

Build error:
...\FluentBuilderGenerator\FluentBuilderGenerator.FluentBuilderSourceGenerator\FluentBuilderSandboxTests.UserBuilder.g.cs(31,68,31,86): error CS0234: The type or namespace name 'IListOptionBuilder' does not exist in the namespace 'FluentBuilderSandbox' (are you missing an assembly reference?)

Hello @distantcam, thanks for noticing.
I'll investigate your issue.

@distantcam
Can you please try FluentBuilder.0.7.0-preview-01 on NuGet ?

Sorry, I missed your earlier comment.
Yep I can confirm this is fixed with version 0.7.0-preview-01. Thankyou!

@distantcam Thank you for validating.
A new 0.7.0 will be released on some time.


DeleteProjectBug

Deleting a project works, but there is an unexplainable error in Chrome and in Firefox

I confirmed that this is still a issue in firefox.


Allow users to skip deploying kube-vip load balancer for tinkerbell stack

Description of changes:
Currently, EKS-A for bare-metal deploys kube-vip loadBalancer on the target cluster to expose the Tinkerbell services externally.
This change allows users to skip deploying kube-vip by default as they may want to use a different loadBalancer post cluster creation to expose tinkerbell stack. This is something users will have to do post cluster creation to ensure they have an HA cluster.
A new field skipLoadBalancerDeployment is added to the TinkerbellDatacenterConfig to allow users to achieve this
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: TinkerbellDatacenterConfig
metadata:
  name: abhnvp
spec:
  tinkerbellIP: "<IP_ADDRESS>"
  skipLoadBalancerDeployment: true

The default behavior is still unchanged. When you run the generate command, this field won't show up in the clusterconfig. Instead, users will have to manually add it as a precaution so they don't accidentally set this field unless they absolutely need to.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold
this PR depends on https://github.com/aws/eks-anywhere-build-tooling/pull/1209
The above PRs to be merged and the chart needs to be updated before merging this

linter issues and nits, looks good otherwise

/lgtm

/lgtm

/unhold as the build-tooling PR is merged https://github.com/aws/eks-anywhere-build-tooling/pull/1209

/unhold

/approve


Running 'createTrainingHeader' via grobid-service

This is not an issue but missing in the grobid-service module. Is there any way I could run "createTrainingHeader" as a service? Appreciate any help in this regard. Let it merge all the 4 files that it creates currently into a single file and and respond back.

Hi @dominic-sps, the reason of this functionality is not included in the grobid-service is that at the moment the creation of training data is a separate offline operation from the processing.
What would be the reason/use case for having that directly in the grobid-service?
One solution is that you implement your own service for training data creation and integrate the grobid-core library, in order to have a service for training data generation.

One solution is that you implement your own service for training data creation and integrate the grobid-core library, in order to have a service for training data generation.
This is what I am trying now. I have merged the author and affiliation training XMLs and created my own xml. The reason is, I noted that the training XMLs has more details than the output created by 'processHeaderDocument' which actually ats up lot of content.

Ok, what do you mean with the training XML has more details than the otuptu created by processeHeaderDocument?
The training XML (they are produced also together with a feature list text files) they are meant to be manually corrected by expert users.
Could you be also more specific of what you intend to do with the XMLs? I'm asking because I"m not sure I've understand what you are trying to achieve :-)

Hi Dominic,
createTrainingHeader uses the segmentation model for identifying the header zone, while the current processHeaderDocument does not use it yet. This explain why you see more material with createTrainingHeader at the current time. Using createTrainingHeader is not a reliable solution of course because it's not its purpose to get usable results - simply to get usable training data.
Making the header model up-to-date with the segmentation model is a work in progress, see issue #136. It takes time because it requires to refresh the current training data.
So having createTrainingHeader available as a service for the reason you mention does not make a lot of sense, we just need to improve the normal processHeaderDocument as planed and in progress.

@dominic-sps if you want to have the same material in processHeaderDocument as with createTrainingHeader, you can use the segmentation model in processHeaderDocument by modifying the file GrobidRestProcessFiles.java (under grobid-service/src/main/java/org/grobid/service/process) as follow:
line 81-82 and 88-89 change this
retVal = engine.processHeader(originFile.getAbsolutePath(), consolidate, null);
//retVal = engine.segmentAndProcessHeader(originFile, consolidate, null);

into this:
//retVal = engine.processHeader(originFile.getAbsolutePath(), consolidate, null);
retVal = engine.segmentAndProcessHeader(originFile, consolidate, null);

It should work... but given the current training data for the header model, the accuracy of the header model based on areas identified by the segmentation model is ~3% lower than with heuristics-based identification of header area (which is why I have not switched yet to the new approach for header structuring). This ~3% come from the end-to-end evaluation with 1943 PDF files of PubMedCentral.

@kermitt2 , It does load the segmentation model after the above change but the expected  tag is still missing in the output.

Could you send me maybe an example where createTrainingHeader provides more info than processHeaderDocument after the above mentioned change, so that I can recreate the issue?

Running createTrainingHeader on file Wang_paperAVE2008.pdf

Screen messages
D:\grobid>java -Xmx1024m -jar \grobid\grobid-core\target\grobid-core-0.4.2-SNAPSHOT.one-jar.jar -gH \grobid\grobid-home -gP \grobid\grobid-home\config\grobid.properties -dIn \test\in -dOut \test\out -exe createTrainingHeader
JarClassLoader: Warning: org/apache/lucene/analysis/cn/smart/hhmm/SegTokenFilter.class in lib/lucene-analyzers-smartcn-4.5.1.jar is hidden by lib/wipo-analysers-0.0.1.jar (with different bytecode)
JarClassLoader: Warning: org/w3c/dom/UserDataHandler.class in lib/xom-1.2.5.jar
is hidden by lib/xml-apis-1.4.01.jar (with different bytecode)
Wang_paperAVE2008.pdf
1 files to be processed.
[Wapiti] Loading model: "D:\grobid\grobid-home\models\header\model.wapiti"
Model path: D:\grobid\grobid-home\models\header\model.wapiti
[Wapiti] Loading model: "D:\grobid\grobid-home\models\segmentation\model.wapiti"
Model path: D:\grobid\grobid-home\models\segmentation\model.wapiti
[Wapiti] Loading model: "D:\grobid\grobid-home\models\affiliation-address\model.wapiti"
Model path: D:\grobid\grobid-home\models\affiliation-address\model.wapiti
[Wapiti] Loading model: "D:\grobid\grobid-home\models\name\header\model.wapiti"
Model path: D:\grobid\grobid-home\models\name\header\model.wapiti
[Wapiti] Loading model: "D:\grobid\grobid-home\models\name\citation\model.wapiti"
Model path: D:\grobid\grobid-home\models\name\citation\model.wapiti

Refer the person name tag in Wang_paperAVE2008.authors.tei.xml.txt
<persName>
	<forename>Rui</forename>
	 <surname>Wang</surname>
	 <suffix>Jr</suffix>
	 <marker>1</marker> and
</persName>

Files Created (renamed as txt)
Wang_paperAVE2008.affiliation.tei.xml.txt
Wang_paperAVE2008.authors.tei.xml.txt
Wang_paperAVE2008.header.tei.xml.txt
Wang_paperAVE2008.header.txt

Running service processHeaderDocument . After making your suggested code change I did compile the service and run

curl --form<EMAIL_ADDRESS>-H "Content-Type: multipart/form-data" localhost:8081/processHeaderDocument > output.txt
Server side screen messages
[DEBUG] org.grobid.service.process.GrobidRestProcessFiles: >> org.grobid.service.process.GrobidRestProcessFiles.methodLogIn
[DEBUG] org.grobid.core.utilities.IOUtilities: >> set origin document for stateless service'...
[DEBUG] org.grobid.core.factory.GrobidPoolingFactory: synchronized newPoolInstance
[INFO ] org.grobid.core.factory.GrobidPoolingFactory: Number of Engines in poolactive/max: 1/10
[DEBUG] org.grobid.core.utilities.LanguageUtilities: synchronized getNewInstance
[DEBUG] org.grobid.core.analyzers.GrobidAnalyzer: Get new instance of GrobidAnalyzer
[INFO ] org.grobid.core.jni.WapitiModel: Loading model: D:\grobid\grobid-home\models\header\model.wapiti (size: 36094028)
[Wapiti] Loading model: "D:\grobid\grobid-home\models\header\model.wapiti"
Model path: D:\grobid\grobid-home\models\header\model.wapiti
[DEBUG] org.grobid.core.document.DocumentSource: start pdf2xml
[DEBUG] org.grobid.core.document.DocumentSource: Executing: [D:\grobid\grobid-home\pdf2xml\win-64\pdftoxml_server, -blocks, -noImageInline, -fullFontName, -noImage, -annots, D:\grobid\grobid-home\tmp\origin6806815209628133159.pdf, D:\grobid\grobid-home\tmp\3xStPr6RB5.lxml]
[DEBUG] org.grobid.core.document.DocumentSource: pdf2xml process finished. Timeto process:170ms
[INFO ] org.grobid.core.jni.WapitiModel: Loading model: D:\grobid\grobid-home\models\segmentation\model.wapiti (size: 15755692)
[Wapiti] Loading model: "D:\grobid\grobid-home\models\segmentation\model.wapiti"
Model path: D:\grobid\grobid-home\models\segmentation\model.wapiti
[DEBUG] org.grobid.core.lang.impl.CybozuLanguageDetectorFactory: synchronized getNewInstance
[DEBUG] org.grobid.core.lang.impl.CybozuLanguageDetector: [en:0.9999987071320096]
[INFO ] org.grobid.core.jni.WapitiModel: Loading model: D:\grobid\grobid-home\models\name\header\model.wapiti (size: 2055704)
[Wapiti] Loading model: "D:\grobid\grobid-home\models\name\header\model.wapiti"
Model path: D:\grobid\grobid-home\models\name\header\model.wapiti
[INFO ] org.grobid.core.jni.WapitiModel: Loading model: D:\grobid\grobid-home\models\name\citation\model.wapiti (size: 339957)
[Wapiti] Loading model: "D:\grobid\grobid-home\models\name\citation\model.wapiti"
Model path: D:\grobid\grobid-home\models\name\citation\model.wapiti
[INFO ] org.grobid.core.jni.WapitiModel: Loading model: D:\grobid\grobid-home\models\affiliation-address\model.wapiti (size: 2646298)
[Wapiti] Loading model: "D:\grobid\grobid-home\models\affiliation-address\model.wapiti"
Model path: D:\grobid\grobid-home\models\affiliation-address\model.wapiti
[DEBUG] org.grobid.core.utilities.GrobidProperties: loading GROBID_HOME path
[DEBUG] org.grobid.core.lang.impl.CybozuLanguageDetector: [en:0.999998180987098]
[DEBUG] org.grobid.core.utilities.IOUtilities: Removing D:\grobid\grobid-home\tmp\origin6806815209628133159.pdf
[DEBUG] org.grobid.service.process.GrobidRestProcessFiles: << org.grobid.service.process.GrobidRestProcessFiles.methodLogOut

Output file:
output.txt
Refer the person name tag in the 22.txt file
<persName xmlns="http://www.tei-c.org/ns/1.0"><forename type="first">Rui</forename><surname>Wang</surname></persName>

Many thanks !
There was a bug in the way name suffix were set (nothing to do with the model or training data). It is fixed and works with your example after commit b738f1f862c269582efe0ffe953c0268561130c4.


[SPARK-7758][SQL]Override more configs to avoid failure when connect to a postgre sql

https://issues.apache.org/jira/browse/SPARK-7758
When initializing executionHive, we only masks
javax.jdo.option.ConnectionURL to override metastore location.  However,
other properties that relates to the actual Hive metastore data source are not
masked.  For example, when using Spark SQL with a PostgreSQL backed Hive
metastore, executionHive actually tries to use settings read from
hive-site.xml, which talks about PostgreSQL, to connect to the temporary
Derby metastore, thus causes error.
To fix this, we need to mask all metastore data source properties.
Specifically, according to the code of [Hive ObjectStore.getDataSourceProps()
method] 1, all properties whose name mentions "jdo" and "datanucleus" must be
included.
Have tested using postgre sql as metastore, it worked fine.

Merged build triggered.

Merged build started.

Test build #33228 has started for   PR 6314 at commit 21bf202.

Test build #33228 has finished for   PR 6314 at commit 21bf202.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33228/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #33241 has started for   PR 6314 at commit 21bf202.

Test build #33241 has finished for   PR 6314 at commit 21bf202.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33241/
Test FAILed.

Merged build finished. Test FAILed.

From the failed test cases, it looks like not a good fix. I have no more idea as not a spark-sql expert. Anyone could offer some help?

Yeah, we definitely need the execution hive for Hive to function, but likely what we want to do is filter out any configuration that is telling it to use postgres (it should always use a dummy local derby instance)

Merged build triggered.

Merged build started.

Test build #33318 has started for   PR 6314 at commit e3e683d.

Test build #33318 has finished for   PR 6314 at commit e3e683d.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33318/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #33321 has started for   PR 6314 at commit 92a81fa.

Test build #33321 has finished for   PR 6314 at commit 92a81fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33321/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #33336 has started for   PR 6314 at commit e4f0feb.

Merged build triggered.

Merged build started.

Test build #33337 has started for   PR 6314 at commit 86caf2c.

Test build #33337 has finished for   PR 6314 at commit 86caf2c.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33337/
Test FAILed.

Test build #33336 has finished for   PR 6314 at commit e4f0feb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33336/
Test PASSed.

@marmbrus I overrided more configs in HiveConf (refer to https://github.com/pwendell/hive/blob/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L288) plus datanucleus.rdbms.datastoreAdapterClassName not included in HiveConf.
Have tested using postgre sql as metastore, it worked fine.

@WangTaoTheTonic Seems newTemporaryConfiguration is used by executionHive. Can you explain the reason that your change can fix the problem of metadataHive?

@yhuai We headed to the wrong direction at first. It's not because executionHive can't find proper PostgreSQL configurations. The reason of the failure is that metadataHive only overrides the metastore location without overriding other JDO and Datanucleus properties, thus those properties are read from hive-site.xml and talking about PostgreSQL. This makes metadataHive trying to connect to the temporary Derby metastore with PostgreSQL settings, and causes the error. What @WangTaoTheTonic did is overrides all related properties with Hive default values (gathered from ConfVars). That's why updating executionHive related code path corrects the behavior.

@WangTaoTheTonic Would you mind to help updating the PR description to the following? Thanks!

When initializing executionHive, we only masks javax.jdo.option.ConnectionURL to override metastore location.  However, other properties that relates to the actual Hive metastore data source are not masked.  For example, when using Spark SQL with a PostgreSQL backed Hive metastore, executionHive actually tries to use settings read from hive-site.xml, which talks about PostgreSQL, to connect to the temporary Derby metastore, thus causes error.
To fix this, we need to mask all metastore data source properties.  Specifically, according to the code of [Hive ObjectStore.getDataSourceProps() method] 1, all properties whose name mentions "jdo" and "datanucleus" must be included.

Forgot to say, LGTM, and thanks for fixing this!

@yhuai I think @liancheng explains all clearly. Thanks for your comments and explanation @liancheng.

Merged build triggered.

Merged build started.

Test build #33345 has started for   PR 6314 at commit ca7ae7c.

@WangTaoTheTonic  Can you update your pr description per Cheng?

Test build #33345 has finished for   PR 6314 at commit ca7ae7c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33345/
Test FAILed.

Test build #851 has started for   PR 6314 at commit ca7ae7c.

Test build #851 has finished for   PR 6314 at commit ca7ae7c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks for fixing this!  Merged to master and 1.4.


National roads and train crossings do not show railway crossing with barrier.

National roads and train crossings do not show railway crossing with barrier. Only with one exception when you build a national road towards the rail.
All other national roads show no railway crossing with barriers at all.

Could this be same cause as #149 - the road asset missing level crossing assets?

It would be worth reporting to NeXT 2 team - if you can work out which github is the currently active one.
They are missing junction/crossing assets on their national roads - perhaps intentionally?

This is the same issue as #149. It's not a bug in TMPE but probably a missing asset in NeXT2


[MAINT] Refactor mne.viz.Brain to simplify

So right now mne.viz.Brain is more or less a wrapper around pyvista.mesh with some cool layers and curvatures as well that are really helpful for brains and electrophysiology 3D viewing. The part that I think is overly complicated in the internal representation is the views.
The question is could we just update mne.viz.Brain to be more like matplotlib.pyplot.axes with a mne.viz.BrainFigure? Then, the examples with multiple views can have the user handle two or more brain objects with the equivalent of matplotlib.pyplot.Figure.axes instead of handling them internally with all these complicated views and column and row subplots. That seems like it could be simpler and allow the user more control over which views they want.

Part of the motivation behind the current show_view API is to mimic what's done with PySurfer. But the more important consideration I think is how Brain differs from the general matplotlib case -- Brain is designed so that each "subplot" shows the same information/data (except maybe separate hemis), just from different views. You .add_data and it affects all subplots the same way. matplotlib allows showing completely different data in each subplot/axis, so having an axis-level API for them makes more sense than it does for Brain.
For this reason re-engineering the class to have matplotlib-like individual-subplot access does not make sense to me, but instead we should perhaps just make the view setting simpler for the user. I think view setting is the only place that we really need individual control over things anyway?

FWIW, I recently had to write this helper function in order to set distances (adjacent views were overlapping / getting cut off by the edge of the figure).
def set_brain_view_distance(brain, views, hemi, distance):
    # zoom out so the brains aren't cut off or overlapping
    if hemi == 'split':
        views = np.tile(views, (2, 1)).T
    else:
        views = np.atleast_2d(views).T
    for rix, row in enumerate(views):
        for cix, view in enumerate(row):
            brain.show_view(view, row=rix, col=cix, distance=distance)

I would be quite happy if @alexrockhill's efforts here made it easy to, e.g., set distance on all views at once, without having to loop over rows and columns and re-specify the named view ("lat", "med", etc) and hemi that were already being shown in each cell.  So to my mind the problem is not lack of individual "subplot" access --- I already have that with brain.show_view() --- but rather, a way to affect multiple "subplots" at once.

Sounds reasonable, maybe it's already close to the easiest way to do views, I simplified a bit when I added the focal point that might be good

For this use case (which sounds almost like the opposite of @alexrockhill's initial proposal?) I would add row='all' and col='all' and view=None (meaning: preserve existing unless changed by later kwargs) support. Then you would just have:
brain.show_view(view=None, row='all', col='all', distance=distance)

and ...

I simplified a bit when I added the focal point that might be good

... for this it would be the same just with focalpoint=... at the end.


[Rendering] Use 16bit data types on the GPU where possible

Background
As Hotham's renderer is primarily memory bandwidth bound on the Quest 2, dropping to 16 bit data types will not only improve bandwidth, but in general only use a single instruction, compared to two, when operating on them. This could be a very significant performance increase.
TODO

[ ] Modify Vertex struct
[ ] Modify asset importer to convert to the correct precision
[ ] Modify shaders

Closed in #415


Scrum 4414

Once the code is merged and on stage or the branch is on stage, we will need to update the transition table.
cd agr_literature_service/lit_processing/oneoff_scripts/workflow
python3 transitions_add.py classifications
This adds the new actions needed.


redoing bedrock docs + codeowner change

updated bedrock docs
added new codeowners

Howdy @Cherry, think I've addressed your feedback... but getting an additional review from internal folks to make sure I'm not just making things up :).


refactor: upgrade ethers.js v6

Description
Upgraded the ethers.js dependency to v6 across most apps. To support this upgrade, the dependency was also upgraded in the libs. Related dependencies like Wagmi, Rainbowkit, and Typescript were updated for compatibility. Currently experimenting with downgrading the typescript version to resolve remaining union-type errors.
Related Issue
This PR resolves the issue #366
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

The upgrade was necessary to keep the project up-to-date with the latest ethers.js version and take advantage of new features and bug fixes.
Downgrading the typescript version is an experimental approach to resolve the remaining union-type errors, which may or may not work. You can find the build error here
If the typescript version downgrade doesn't resolve the errors, further investigation and changes may be required.

Thanks @0xjei, I will do the needful promptly.

Thank you very much @0xjei for continuous support. I have completed the requested changes and rebased the branch with dev branch.

As we have discussed

Thank you very much @0xjei for continuous support. I have completed the requested changes and rebased the branch with dev branch.

Thank you so much for your effort @neel-ds. Could you please run yarn prettier:write && yarn lint --fix from the root of the project? Also, check if the tests (yarn test) are passing since CI is failing! Thank you again!


[ANDROID] 10.2.1 implicitly requires compileSdkVersion 29

Bug description:
Android config-related bug:
Version 10.2.1 doesn't compile with compileSdkVersion 28 or lower in root project.
Reason: In the PR #1384 there was added new check for android version Q. That's ok, necessary business logic.
Android SDK of versions 28 and lower has no static field Q in static class Build.VERSION_CODES, which causes build error. This field is required for the PR. Author knew about it and set compileSdkVerion in the gradle.properties file to 29.
But current compileSdkVersion picking algorithm prefers root project's gradle settings. So, in webview's gradle gets lower compileSdkVersion on most current RN projects.
Possible solution
Change build.gradle's compileSdkVersion to gradle.properties' one, if it is secure.
Maybe @Karthz could propose some better solution.
To Reproduce:
Create RN app, set compileSdkVersion to 28, install react-native-webview (10.2.1), run react-native run-android
Environment:

OS: MacOS
OS version: 10.15
react-native version: 0.61.5
react-native-webview version: 10.2.1

This should be "fixed" with a simple PR to the changelog I think that marks it as a breaking change that the semver release bot picks up as a breaking change and an accompanying release note. The change is fine and react-native template itself is at 29 now, it just should have been marked breaking
https://github.com/semantic-release/semantic-release
indicates a PR / commit that starts 'BREAKING CHANGE: ' will do the trick
PR happily accepted I am sure, the policy here is "breaking change is fine, will just be semver major"

@fend25 you're the reporter and the changes should be easy (docs PRs are handled nicely by a web-based workflow in github) - if you post up a PR I can scan it and merge+release I think

Yeah, this should have been marked breaking -- that's my bad. Apologies!


test relative_weights

relative_weights is a new feature without unit testing

closed by https://github.com/rethinkpriorities/squigglepy/commit/4c9562fc0745c431e2b5b9507315cf72df83d2ee


Implement dependsOn processing for config

Summary of the new feature / enhancement
Build execution graph for a config
Proposed technical implementation details (optional)
No response

Using ARM syntax, this appears to be: [resourceId('<type>','<name>')] where <name> could be generated using parameters/variables at runtime.  For now, (since parameters and variables isn't implemented), it'll just be a string, but we'll follow the syntax.

https://github.com/PowerShell/DSC/pull/175


Ensuring that es6 modules are interpreted as es6 modules by today's bundlers/loaders

See jspm/jspm-cli#1793 for the problem that this fixes. Basically, Module objects are not being interpreted as es6 modules by systemjs/builder because they do not define the _esModule property to be true. See code in the builder for why this is the case.
Interested to know of any problems/concerns anyone has with doing this, but I believe that this is a backwards compatible change unless people are depending on Modules not being interpreted as es modules.

Note that the switch from regenerator to regenerator-runtime was necessary because of a commit to regenerator that makes the regenerator/runtime.js file no longer loadable via a script tag.

Also I installed this branch of es6-module-loader into systemjs, built systemjs, and then ran the tests for systemjs and that all the tests passed.

This is actually another level of interop that I've deliberately not implemented.
The reason for this is that real ES modules will not be able to support this, unless we want to start advocating all es modules in SystemJS on a native loader do this same export...
My hope here was always to get transpilers to output a check like module.__esModule || module instanceof Module kind of check that could be fowards-compatible. I tried to rally es discuss to get a solid mechanism for this a couple of times but wasn't able to. There is still a Babel issue at https://phabricator.babeljs.io/T2148 I created here.
So it comes down to:

Land this, and have SystemJS for the next 10 years always put __esModule on every module running in the browser.
Attempt to walk the hard path of interop involving updating transpilers to outputs like the above.

I'm more tempted to add cruft to the transpiler workflows of today, than the module workflows of tomorrow, hence my resistance here.

What I'd suggest is the following:

As soon as the <script type="module"> implementations start landing, it would be worth checking that the import * as module from 'module' detection suggested works in all browsers correctly, and post browser bugs where they don't. This way that detection can be prioritised.
As soon as that detection is known to be reliable, push for implementation of the detection approach in Babel and other transpilers.

If anything goes wrong on the above two steps (eg browser interop breaks for even just one browser hitting a wall), then the above can be implemented. But until then I don't think we should.

All of that makes sense - one question with it though. You recommended that transpilers check module instanceof Module, but Module is wrapped in an iife and thus not globally available to be checked against. Since that is the case, what can transpilers / bundlers do in their interop to check if an object they have is a Module? See the jspm issue linked to in the original post for how SFX builds fail to detect if injected deps are Modules, resulting in a runtime error.

Yes that was as a quick example... the actual detection would be something more like:
function isModule(m) {
  return typeof m == 'object' && (m.__esModule || typeof Symbol != 'undefined' && Symbol.toStringTag && m[Symbol.toStringTag] == 'Module');
}

Sure, I've responded on that issue... let's continue to track there then on this.


fix: Update samples table when datasource changes

SUMMARY
Datta samples table was updated only when filters changed. Now it will also update when datasource changes.
Closes https://github.com/apache/superset/issues/12369
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/15073128/104086223-1ea92a00-5256-11eb-9c13-b4ee96e827f4.mov
TEST PLAN

ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/superset/issues/12369
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

CC: @junlincc @ktmud

Codecov Report

Merging #12378 (ed48d71) into master (1250426) will decrease coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12378      +/-   ##
==========================================
- Coverage   66.87%   63.29%   -3.59%
==========================================
  Files        1014      485     -529
  Lines       49508    29873   -19635
  Branches     5063        0    -5063
==========================================
- Hits        33110    18907   -14203
+ Misses      16268    10966    -5302
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...ed48d71. Read the comment docs.

Codecov Report

Merging #12378 (ed48d71) into master (1250426) will decrease coverage by 3.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12378      +/-   ##
==========================================
- Coverage   66.87%   63.29%   -3.59%
==========================================
  Files        1014      485     -529
  Lines       49508    29873   -19635
  Branches     5063        0    -5063
==========================================
- Hits        33110    18907   -14203
+ Misses      16268    10966    -5302
+ Partials      130        0     -130

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
86.49% <0.00%> (-5.49%)
:arrow_down:

... and 550 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1250426...ed48d71. Read the comment docs.


SQL folding improvements

Code folding must work incrementally (current implementation resets all folds below edit position).
"Collapse/expand all folds" actions should be provided.
(see #1664 for details)

Hi, I am new using you tool. very promising, and already wonderful for my current needs.
I tried your early release (ea), and got this error message.
Gtk-Message: Failed to load module "overlay-scrollbar"
Gtk-Message: Failed to load module "atk-bridge"
Unrecognized option: --add-modules=ALL-SYSTEM
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

(dbeaver:27893): Gtk-WARNING **: Unable to locate theme engine in module_path: "pixmap",

should I build a freshly compiled version from devel/master from now on, if to possibly
avoid those errors? Thanks for your work.

@absnc This is still the same old bug with Java 9: https://bugs.eclipse.org/bugs/show_bug.cgi?id=493761
Adding default parameter (--add-modules=ALL-SYSTEM) in dbeaver.ini still seems to be problematic. Although it shouldn't.
What is your OS and Java version (run java -version in terminal)?
Workaround: remove line --add-modules=ALL-SYSTEM from dbeaver.ini file.
This is a wrong ticket to discuss such things actually :(

Is the folding implemented with custom Eclipse actions? Built-in folding has actions like org.eclipse.ui.edit.text.folding.collapse and expand, and Vrapper maps these to their usual Vim mappings, but they aren't working in DBeaver so I wondered if I can override the command mappings.
By the way, it took me a moment to find the "Folding enabled" checkbox in preferences, it's on the "SQL Completion" page although folding doesn't really have anything to do with completion. I think the "SQL Editor" page would make sense.

The code folding is about as useless as it can be as it is. I'm using the latest version of DBeaver and it will unfold all code when ANY edit is done; regardless if the edit takes place above or below the collapsed code. Is there any hopes that this will actually be fixed? This has been an on-going issue for quite some time now.

Using DBeaver 5.1.4.

I have been using DBeaver for a lot of SQL Coding for about 5 weeks now, and I started using it in my training business too, because it is a nice multi-database editor.
I really like it, but there are 2 crucially important things that I have not been able to get working properly.   I am using the Community Edition.
Code Folding doesn’t work.  I’ve enabled it in the Preferences Panel, but it just doesn’t work.  My current program is over 500 lines of SQL and I really need the ability to hide (“fold”) major blocks of code so that I can jump to different parts of the script fast.  It really slows me down to not have code folding.
Text Compare – I frequently need to compare 2 versions of the same script.
Right now I have to move the code over to Notepad++ to work with large blocks of code or script files, and use either BeyondCompare or Notepad++ to compare two script files to see their differences.
Please help on these points, because folding and file comparisons are functions that I depend upon heavily when coding.

Code folding is not working for me.  I have been using DBeaver for a lot of SQL Coding for 5 weeks.  It is a nice multi-database editor.
There are 2 crucially important things that I have not been able to get working properly in the Community Edition.
Code Folding... it simply doesn’t work.  I’ve enabled it in the Preferences Panel, but it just doesn’t work.  My current program is over 500 lines of SQL and I really need the ability to hide (“fold”) major blocks of code so that I can jump to different parts of the script fast.  It really slows me down to not have code folding.
What are the SQL object types or syntax element triggers that trigger code folding to work?  Where are the "Save Folding" options on the toolbar or menus?
Text Compare – where is this function?  I frequently need to compare 2 versions of the same script.
Right now I have to move the code over to Notepad++ to using code folding or work with large blocks of code or large script files, and use either BeyondCompare or Notepad++ to compare two script files to see their differences.  This is a hassle and requires a few extra steps to bring the code back to DBeaver for execution.
Please help on these points, because code folding and side-by-side file comparisons are functions that I depend upon heavily when coding.  I can do this in NotePad++, Spyder for Python, VScode, and PyCharm.
I’m posting these questions to StackOverflow so that perhaps people in the community can share an answer.  I am pretty sure I am not the only person having trouble getting this to work.

@richdevboston : About "Code Folding", I managed to make it work by also enabling "Toggle Block Selection" from "Edit" menu (ALT+SHIFT+A). You can disable it once the folding items appear (next to BEGIN or DECLARE statements).

Fixed the issues with folding. In the context menu near breakpoints, there is now an option to quickly enable and disable folding, as well as expand or collapse all statements.

folding is enabled/disabled for big scripts (in attach) after reopening only.
Script-348.txt

Fixed the issue described above. Also disabled folding in consoles.

Toggle breakpoint is available for source/ddl tab at object properties page - an error appears in case of choosing the mentioned option

Toggle Breakpoint is also available for usual script and console - has no effect after clicking on it

Works just fine with the latest EA.

verified


Running tests on self-hosted runners

Has anyone been able to run tests on self-hosted runners with firefox and chrome ? I tried to find references in the documentation but most of the examples are Github-Hosted.

Does it make any difference? Is it not working?

There were some issues with finding the browsers, but it was something wrong with out configuration so we fixed it. The issue can be closed. Thanks for the response. :)


Clone Child records not working

Expected behavior and actual behavior.
Clone Parent (Account Plan)- Works Fine
Next step to clone Child records (Account Plan Competitor) not working
I have checked https://github.com/demianrasko/Dynamics-365-Workflow-Tools/blob/master/docs/Clone Children.md to try to ensure I have followed the instructions
Steps to reproduce the problem (screenshots are really usefull)

CRM Version - online/onpremise - WorkflowTools version
D365 Customer Experience Version 1710 (<IP_ADDRESS>24) online
Workflow tools <IP_ADDRESS>

It doesn't look as if the Clone GUID function is receiving a value, and so when then parameter is being passed to the clone child function nothing is happening.
I updated my workflow to write Cloned GUID back to a memo field on the Parent Record to check the value, nothing gets written

So, I an now getting a return from Clone GUID, and I have constructed a URL for the Target URL parameter.  I also populate the constructed
URL to Parent Record from which I want to clone the child records
Clone Children is still not working

The constructed URL updated on the parent opens up the cloned record when passed into a browser, but Clone Children still does nothing.  I am fairly sure all of the parameters required are correct
Constructed URL for Target URL:   https://mycrmorg-crm-dev.crm11.dynamics.com/main.aspx?etc=10232&extraqs=formid%3Ded3dffae-d9f8-4225-a764-650e0eeea1ed&id={46ae259a-3376-e911-a9a0-002248004a4b}&pagetype=entityrecord

I have exact the same issue

I have exact same issue.

I can't reproduce the issue, are you able to share with me a solution with the issue?
thanks!

I am also experiencing the same issue with the child clone and using the clone GUID.
@demianrasko can you please advise on what should go into the "Target Record URL" param?  ie, how to compose the URL with the clone GUID?  Maybe a screen cap of how you are doing it successfully?  Maybe you are using an intermediary step between the Parent Clone and the Child Clone?  Whose output is then used to set the child clone target record url?
Many thanks!

Hi jcfetzer,
Note: The Parent Record URL, is a standard feature of Dynamics CRM, taht contains the full URL of a record. In this URL you have the entity type, and the record GUID. Right now this is the only way we have to pass a "Dynamic" EntityReference (with not hard coding an entity type) to Workflows Activities. If you pass this string URL as a parameter, in the Workflow Activity you can retrieve this entity Reference.

Hi, Any update? I have the same problem with Target Url.

Hi, Im facing the same issue of having the Target Record Url not being a dynamic value.
Ive managed to hardcode the Target Record Url and get it to work, but im looking for a solution where I dont need to update each environment it is deployed to.
https://.crm.dynamics.com/main.aspx?etc=3&id={Cloned Guid(Clone Opportunity)}

Hi,
I have the same question, how do you set the Target Record URL? Where do I get the Target Record URL? Plugging in just the Cloned GUID doesn't work. Thanks in advance.


Pipeline fails when volumes are in root - permission denied

root@telemetrytest:~/root# docker logs ab33864fc5bb
/bin/sh: 1: cmd/idrac-telemetry-receiver.sh: Permission denied

It looks like the root cause is that when you pull the repo idrac-telemetry-receiver.sh is missing execute:
root@telemetrytest:~# ls -al root/idrac-testing/cmd/
total 160
drwxr-xr-x 12 root root  4096 Feb  8 12:35 .
drwxr-xr-x 10 root root  4096 Feb  8 12:35 ..
drwxr-xr-x  2 root root  4096 Feb  8 12:35 configui
drwxr-xr-x  2 root root  4096 Feb  8 12:35 dbdiscauth
drwxr-xr-x  2 root root  4096 Feb  8 12:35 elkpump
-rw-r--r--  1 root root 97146 Jan 13 18:45 highleveldesign.png
-rw-r--r--  1 root root   562 Jan 13 18:45 idrac-telemetry-collector-all.sh
-rw-r--r--  1 root root   347 Feb  8 11:52 idrac-telemetry-receiver.sh
drwxr-xr-x  2 root root  4096 Feb  8 12:35 influxpump
-rw-r--r--  1 root root   187 Jan 13 18:45 initialize_timescaledb.sh
drwxr-xr-x  2 root root  4096 Feb  8 12:35 prometheuspump
-rw-r--r--  1 root root  2482 Feb  8 11:52 README.md
drwxr-xr-x  2 root root  4096 Feb  8 12:35 redfishread
drwxr-xr-x  2 root root  4096 Feb  8 12:35 simpleauth
drwxr-xr-x  2 root root  4096 Feb  8 12:35 simpledisc
drwxr-xr-x  2 root root  4096 Feb  8 12:35 splunkpump
drwxr-xr-x  2 root root  4096 Feb  8 12:35 timescalepump

Possible fixes:

Create a start script that checks prerequisites
Run container as root (bad idea but it does solve the problem)
Custom container with the script built in instead of volume mounted (kinda high maintenance)

Resolved this


x/crypto/ssh: Possible to pass nil publicKeyCallback signer

Go Version
1.8.1 stable
kris-nova:crypto kris$ go version
go version go1.8 darwin/amd64

Environment
Darwin AMD64
What did you do?
While attempting to authenticate with x/crypto/ssh I was able to return an empty slice of ssh.Signers. My code compiled, but upon running recieved a nil pointer dereference as one would expect.
import "golang.org/x/crypto/ssh"
//snip
	publicKeyCallback := func() ([]cssh.Signer, error) {
		var signers []cssh.Signer
		return signers, nil
	})

Expected
I would have expected the library to behave in the same way the open-ssh and other SSH tools handle signing attempts, which is to try attempts in the hopes that one will eventually succeed. I think this is the intent of the library given the note here.
In this exact case, we would have no signing methods to try, and the authentication would immediately run out of possible methods to attempt. Thus returning an error like:
ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

Actual
nil pointer dereference 😞
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x139851a]

goroutine 1 [running]:
github.com/kris-nova/klone/vendor/golang.org/x/crypto/ssh.publicKeyCallback.auth(0x0, 0xc42017cc40, 0x20, 0x20, 0x0, 0x0, 0x1853260, 0xc420441080, 0x184cda0, 0xc420019500, ...)
	/go/src/github.com/kris-nova/klone/vendor/golang.org/x/crypto/ssh/client_auth.go:187 +0x3a

To clarify, is there a problem with the callback returning a nil slice or with the callback function itself being nil? From the traceback it looks like the callback function is nil. Is the expectation that passing a nil callback would be treated as though it is returning a nil slice of ssh.Signer?

we just loop over the return value, https://go.googlesource.com/crypto/+/e1a4589e7d3ea14a3352255d04b6f1a418845e5e/ssh/client_auth.go#192
looks you forgot to set the callback?
https://go.googlesource.com/crypto/+/e1a4589e7d3ea14a3352255d04b6f1a418845e5e/ssh/client_auth.go#187
If not, can you provide a complete example that we could reproduce?


Error opening app on Mac OS + Match items on search isn't be update after delete a translation (for R0.2.3)

Changes :

Fix : Match items on search isn't be update after delete a translation #29
Fix : Error opening app on Mac OS #24

Suppr package-lock.json : prefer use yarn.lock


Handle math in docs

Handle docs rework up to example Chapter04_04.

See also #242, which will require several more rounds...


Register build as task (with additional details over in Output)

Repro: Build a project
Expected: ADS displays task with in progress/success/failure indicators, with text saying details over in Output pane

Reality: No task created in ADS; all details over in Output, somewhat difficult to parse to see what the result of Build was.

Tracked in ADO


Reference the same origin js source in develop and master

We have a weird flow right now where in the develop branch, origin points to github. But in master, origin points to npm.
This is bad practice and requires us to manually revert this change every time we merge develop into master. If someone forgets or doesn't realize this is supposed to happen, things mysteriously don't work. @joshfraser ran into this yesterday.
I am proposing that we simply keep both branches pointing to npm. When a new version of origin is published to npm, we simply update the package.json to point to the new npm version; we do this in the develop branch. Then we test things, make sure everything works, and once we're happy we merge develop into master to create a new release.
As far as concerns about the origin in npm getting out of sync with the develop branch of demo-dapp: this is a non-issue because we are instructing people to run npm run install:dev, which does an npm link and bypasses whatever version is specified in package.json.
In other words:

on master, people will use the origin specified in package.json - this should be the latest npm origin.
on develop, it won't matter what's in package.json. People will be expected to use npm run install:dev/npm link and use the local origin. Thus it will also be safe to specify the latest published npm origin on the develop branch.

Additionally, our current setup actually doesn't add any value. The github origin will never be usable because it does not contain a built package with deployed contracts to test nets, and does not start ganache/truffle locally. There is absolutely no value in having a github reference in any branch.
@wanderingstan How does this sound to you?

Thanks for walking through this @tyleryasaka & I'm in full support of this change.

Agreed! Fixed in: https://github.com/OriginProtocol/demo-dapp/commit/77f3434cdbefcb165754a8e93861bd26bbfa0ba2

BTW - @wanderingstan I think this is a much better solution to the issue we ran into last week re: multiple versions of origin-js in package.json that prompted me to recommend temporarily disabling package-lock.json. Much cleaner and long-term solution.
CC @tyleryasaka 👍


Consider new format for PR ID parsing

We should fix also https://github.com/packit/deployment/blob/main/scripts/changelog.py.


[feature request]: Allow key events on line chart

First of all, amazing project here ❤ .
Feature Request
As a user of LineChart or AreaChart, it would be nice to have the ability to annotate the chart with "key chronological events"
For inspiration, here's a screenshot of Vercel speed insights

Thanks for your submission. There are some things to consider. In the example you posted, the event gets added to the legend. I am not sure if this pattern is generalizable. Let's say you have three different lines and three different types of events? The legends would then have three colors for the lines and three for the different events. How do you distinguish different events? Dotted, dashed, and ?.
Maybe allow one event only?
Would be interested to hear more about your use case for that? Happy to have a call as well.

Current use case (very similar to the screenshot): I'm tracking a metric over time (daily application build times) and I want to be able to correlate any changes in trends with key events (code changes, infra changes, etc.)

In the example you posted, the event gets added to the legend.
Maybe allow one event only?

I think one "type" of event seems reasonable as it would be nice to annotate a chart multiple times with this single "type".
My thinking is:

One legend pattern

This implies there's only 1 event type. (ex. pull request merged)
It's up to the end user to decide what to name this "bucket" of events.

You can add multiple events to the chart. (visually this would be multiple vertical dashed lines)
Would also be nice to have a tooltip show when hovering an event

(Another screenshot displaying multiple events)

Thank you for your thorough follow-up! Will take this into the next discussion.

This is something preventing us from using the library in production.
Annotating event ranges would be amazing:

Thanks @lacymorrow, we are already reworking our charts and plan to integrate such features.

Some "nice-to-haves" would be:

Events marking (single line) or ranges (box/gradient)
Hovering event shows a popover similar to hovering the graph with X details
Clicking an item in the legend toggles the item visibility in the graph
clicking and dragging to "zoom and crop" into the map (example)

Hey @thiskevinwang, Thanks for your idea to add "key chronological events" annotations. While it's a compelling feature, we're cautious about adding complexity to the charting components. The challenge of effectively representing multiple event types and maintaining a clean user interface leads us to hold off on this addition for now. I will keep this marked as a feature → might be picked up in the future. We appreciate your input and encourage you to keep the great suggestions coming!


where are the hmac related functions?

I was looking for the CC_HMAC_* functions but I couldnt find them.

There is a branch for this from several years ago in the repository, but I think I got stuck on something relating to lifetimes and didn't pick it back up.