[BUG] Possible CoC incident on README

Problem subject

[ ] Documentation

Description
Hi folks 👋🏼
The GitHub Algorithm brought me here (YAY! 🎉 ). I was reading your README and found a Code of Conduct incident with it. It might be a bit Nitty-Gritty but wanted to leave this to your consideration. I saw you folks have a Pepe frog meme in your README and though many people would find it funny it might also be considered as a hate symbol after the meme was taken over by white supremacist groups.
I leave a couple of articles for you to review if this breaks you CoC:

Why the Anti-Defamation League just put the Pepe the Frog meme on its hate symbols list
Pepe frog Hate Symbol
Popularly known as the ‘sad frog meme’, Pepe The Frog has become a cultural milestone of the internet – but not for positive reasons.

Expected behavior/contents
NA
Actual behavior/contents
NA
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello, it's great to see you here 🎉
We didn't know about this 😩.
I now removed the Pepe frog meme. Thanks for reporting this to us,

Let's keep this issue open for discussion. Once some weeks pass, we can close this. 🙂

Hey @juanpflores and @Panquesito7 👋 so great to see you two here! I agree with this proposal: we should be considerate in our work, and this issue is a good reminder for future doc writers too

As a side note, there's another Pepe Frog here: https://github.com/dev-protocol/community/blob/main/.github/workflows/invitation.yml#L15. Shall we replace it with the branding materials?

Hey @juanpflores, @vinzvinci and @Panquesito7 👋 so great to see you all here! I agree with this proposal: we should be considerate in our work, and this issue is a good reminder for future doc writers too

Hey there, John 👀 So happy to see you here in Dev Protocol! 😁
I think this was already fixed, it has been removed some weeks ago.

As a side note, there's another Pepe Frog here: https://github.com/dev-protocol/community/blob/main/.github/workflows/invitation.yml#L15. Shall we replace it with the branding materials?

Good catch! We should remove it as well. Thanks for making a PR! :)

OMG hi @poyea so many cool people watching this repository

Hi @poyea 👋
Thank you! I merged your PR :D


detection_delay for volume anomalies tests with month scale

Hello, sorry for the time between my slack message and the reporting of this bug. And I'll take the liberty of replying to my message here.
I wanted to tell you about a little problem I'm having with Elementary that I can't figure out, to see if other people have had the same experience.
My use case is to exclude the actual month of the volume test, to do this, I want to use detection_delay with the following configuration:
# sources.yml
- name: my_table
  tests:
    - elementary.volume_anomalies:
        timestamp_column: calendar_day
        anomaly_direction: both
        anomaly_sensitivity: 2
        detection_delay:
          period: month
          count: 1

But I get the following error:
05:33:50    Compilation Error in test elementary_source_volume_anomalies_landing_zone_my_table_both__2__month__1__day__1__calendar_day (models/sources/sources.yml)
  detection_delay.period value should be one of ['hour', 'day', 'week'], got: month

  > in macro validate_detection_delay (macros/edr/tests/test_configuration/get_detection_delay.sql)
  > called by macro get_detection_delay (macros/edr/tests/test_configuration/get_detection_delay.sql)
  > called by macro get_anomalies_test_configuration (macros/edr/tests/test_configuration/get_anomalies_test_configuration.sql)
  > called by macro test_table_anomalies (macros/edr/tests/test_table_anomalies.sql)
  > called by macro test_volume_anomalies (macros/edr/tests/test_volume_anomalies.sql)
  > called by test elementary_source_volume_anomalies_landing_zone_my_table_both__2__month__1__day__1__calendar_day (models/sources/sources.yml)

I'm a little surprised by this error, because as you can see from the documentation, it's clearly described that this configuration can normally be applied on a monthly basis.
In addition to this, we can see in the comments of this commit, that the modifications made should allow a use of the month.
However, it can be seen that the detection delay values support the hour, day and week in the Elementary code : get_detection_delay.sql
And I've maybe an explanation to my problem, in get_buckets_configuration.sql used in test_table_anomalies > test_volume_anomalie, the developer used the following syntax sugar declaration to dynamically declare a time delta and this function doesn't seem to handle months natively class datetime.timedelta. The case was therefore handled for freshness tests, but not for volume tests.

Hey @Emmanuel2RPA !
I believe you are right and month really isn't supported right now and the docs are wrong (were likely copied from the bucket configuration where we do support month).
We'll make sure to fix the docs, if you'd like by any chance to contribute support for month that will be awesome (as you said though, the implementation with timedelta will not work)


[SPARK-31243][ML][PySpark] Add ANOVATest and FValueTest to PySpark

What changes were proposed in this pull request?
Add ANOVATest and FValueTest to PySpark
Why are the changes needed?
Parity between Scala and Python.
Does this PR introduce any user-facing change?
Yes. Python ANOVATest and FValueTest
How was this patch tested?
doctest

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25024/
Test PASSed.

Test build #120316 has started for PR 28012 at commit bdb5f60.

Test build #120316 has finished for PR 28012 at commit bdb5f60.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ANOVATest(object):
class FValueTest(object):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120316/
Test PASSed.

Merged to master

Thanks!


Build project without deploying

Is your feature request related to a problem? Please describe.
The underlying build process automatically detects which version of nodejs to install. It would be amazing if you guys created a new task that only had this step so I could use the build artifact in a post processing step.
Describe the solution you'd like
Be able to build my angular projects without having to specify the nodejs version.
Describe alternatives you've considered
Specify the nodejs version
Additional context
This picture shows oryx detecting the correct frameworks and figures out which nodejs version to install. It would be a huge benefit to be able to utilize this process so I no longer have to specify the nodejs version in other pipelines that aren't an azure static web app.

Hi, Static Web Apps uses microsoft/oryx under the hood to automate the detection and building of projects. You can use this as well to generate a build artifact to be used later in your pipeline. Here is an example snippet you can add to your GitHub workflow:
jobs:
  container-test-job:
    runs-on: ubuntu-latest
    container:
      image: mcr.microsoft.com/oryx/build:latest
      env:
        NODE_ENV: development
      ports:
        - 80
      volumes:
        - ${{ github.workspace }}:/repo
      options: --cpus 1
    steps:
      - uses: actions/checkout@v3
      - name: Build With Oryx
        run: |
          ls /repo
          oryx build /repo/app --output /repo/output
          ls /repo/output

This snippet tells GitHub to use the mcr.microsoft.com/oryx/build:latest image, mount the repo folder location into the docker container, checkout the repo, and then call the oryx CLI within the container to automatically detect the platform and build a runnable artifact.
You can read more about how to use Oryx here: https://github.com/microsoft/Oryx/blob/main/README.md#supported-platforms
Hope this helps!

The code below is Azure Devops equivalent.
jobs:
- job: container_test_job
  pool:
    vmImage: ubuntu-latest
  container:
    image: mcr.microsoft.com/oryx/build:latest
    env:
      NODE_ENV: development
    ports:
    - 80
  steps:
  - checkout: self
  - task: CmdLine@2
    inputs:
      script: |
        oryx build $(Pipeline.Workspace)/s --output $(Build.ArtifactStagingDirectory)

incorporated as a stage job
pool:
  vmImage: ubuntu-latest

resources:
  containers:
  - container: oryx
    image: 'mcr.microsoft.com/oryx/build:latest'
    env:
      NODE_ENV: development
    ports:
    - 80

stages:
  - stage: Build
    jobs:
    - job: container_test_job
      container: oryx
      steps:
      - checkout: self
      - task: CmdLine@2
        inputs:
          script: |
            oryx build $(Pipeline.Workspace)/s --output $(Build.ArtifactStagingDirectory)
            ls $(Build.ArtifactStagingDirectory)
      - task: PublishBuildArtifacts@1
        displayName: Publish Build Artifact
        inputs:
          PathtoPublish: '$(Build.ArtifactStagingDirectory)/dist'
          ArtifactName: 'drop'
          publishLocation: 'Container'


[Bug] address_algolia and address_google don't work as subfields

Inside the repeatable, you cannot use those two field types as subfields. They're one of the few unsupported fields in the subfields table - so we should just do it and be done with it.

Algoria address will be gone soon.


Populate section headers

Closes #276
Markdown files added for:

[ ] clusters
[ ] metrics
[ ] rechunking

Closes #268

Closes #274


chore: upgrade grpc to v1.26.0

This change is

Do we understand why the vptr change is not needed here? Maybe because we do not define any gRPC servers?

In the bigtable library we use/pass arguments of type grpc::ServerContext* in multiple places. This class directly inherits from grpc_impl::ServerContextBase, which had one method become virtual in the new version, v1.26.0. The ubsan errors observed from the bigtable repo were:
undefined reference to 'typeinfo for grpc_impl::ServerContextBase'

In spanner, we only use grpc::GenericServerContext, once, as part of our testing. grpc::GenericServerContext inherits from grpc::ServerContext

This looks like it is probably obsolete after the recent merge of #1232.


resolve Rhea mapping for 'glycerol-1-phosphate dehydrogenase [NAD(P)+] activity' GO:0050492, 'glycerol-1-phosphate dehydrogenase [NADP+] activity' GO:0106358, 'glycerol-1-phosphate dehydrogenase [NAD+] activity' GO:0106357

dihydroxyacetone phosphate + H(+) + NADH => NAD(+) + sn-glycerol 1-phosphate EquivalentTo METACYC:<IP_ADDRESS>1-RXN	(most probable)	0.75
glycerol-1-phosphate dehydrogenase [NADP+] activity EquivalentTo NADP(+) + sn-glycerol 1-phosphate = dihydroxyacetone phosphate + H(+) + NADPH	(most probable)	0.8
glycerol-1-phosphate dehydrogenase [NAD+] activity ProperSubClassOf NAD(+) + sn-glycerol 1-phosphate = dihydroxyacetone phosphate + H(+) + NADH		0.08
glycerol-1-phosphate dehydrogenase [NAD(P)+] activity EquivalentTo METACYC:<IP_ADDRESS>1-RXN	(most probable)	0.8
NADP(+) + sn-glycerol 1-phosphate = dihydroxyacetone phosphate + H(+) + NADPH ProperSubClassOf EC:<IP_ADDRESS>1		0.1
NAD(+) + sn-glycerol 1-phosphate = dihydroxyacetone phosphate + H(+) + NADH EquivalentTo EC:<IP_ADDRESS>1	(most probable)	0.75
glycerol-1-phosphate dehydrogenase [NAD(P)+] activity EquivalentTo EC:<IP_ADDRESS>1	(most probable)	0.8

Closing; will re-run boomer and open any new issues found.


Add support for values with self-closing tags

Same for https://github.com/databricks/spark-xml/pull/285 but I resolved conflicts here. Should credit to him.
Closes #285
Closes #156
Closes #92
Closes #190
Closes #276

@BioQwer, I am sorry for the late response. It was LGTM. I manually resolved the conflict here. Few differences are I a little bit cleaned up and removed the change about allowing empty attribute prefixes. Maybe, we can do this in another PR.
It's quite core change so it took me a while to double check. Mind taking another look before merging it in?

BTW, let me try to prepare the release only after the current open PRs. It's been delayed again and again.

Codecov Report

Merging #303 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.46%   88.54%   +0.07%
==========================================
  Files          14       14
  Lines         728      733       +5
  Branches       99       93       -6
==========================================
+ Hits          644      649       +5
  Misses         84       84

Impacted Files
Coverage Δ

...cala/com/databricks/spark/xml/XmlInputFormat.scala
94.4% <100%> (+0.18%)
:arrow_up:

...la/com/databricks/spark/xml/util/InferSchema.scala
87.14% <100%> (ø)
:arrow_up:

...m/databricks/spark/xml/parsers/StaxXmlParser.scala
97.08% <100%> (ø)
:arrow_up:

...abricks/spark/xml/parsers/StaxXmlParserUtils.scala
97.87% <100%> (+0.04%)
:arrow_up:

...in/scala/com/databricks/spark/xml/XmlOptions.scala
97.05% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e29c5...382b75b. Read the comment docs.

where can i find the last build, with this fixed?

@oshribr you can get here , build with this fixes.
it's my builds

Hi - Thanks for the great work! What's the timeline for uploading the artifact for build 0.4.2 to maven?

Hi, I still do not see 0.4.2 on maven. Is there any ETA to it?

It's currently blocked by https://github.com/databricks/spark-xml/pull/321
We should fix the tests before the release


Support CNAME in rdns

Rio should support request CNAME record to rdns server so that it can work with EKS. (EKS service loadbalancer will generate elb dns endpoints)

@StrongMonkey I was not able to deploy in EKS cluster using v0.6.0-alpha.1
The installation is just sitting there as not ready:
rio -s ps
NAME           IMAGE                                           ENDPOINT   SCALE     APP            VERSION    WEIGHT    CREATED         DETAIL
buildkitd      moby/buildkit:v0.6.1                                       1         buildkitd      94ac7cc9   0%        7 minutes ago   buildkitd: not ready
cert-manager   rancher/cert-manager-controller:v0.11.0-rio.1              1         cert-manager   94aa04cd   0%        7 minutes ago   cert-manager: not ready
webhook        rancher/gitwatcher:v0.4.1                                  1         webhook        94ad907e   0%        7 minutes ago   webhook: not ready

rio info
FATA[0000] no system information is generated

k get pods -A
NAMESPACE          NAME                                           READY   STATUS      RESTARTS   AGE
cattle-system      cattle-cluster-agent-69d5764fc9-zqd2p          1/1     Running     0          17m
cattle-system      cattle-node-agent-2js2h                        1/1     Running     0          17m
cattle-system      cattle-node-agent-bbgn9                        1/1     Running     0          17m
kube-system        aws-node-572d8                                 1/1     Running     0          17m
kube-system        aws-node-9nzrw                                 1/1     Running     0          17m
kube-system        coredns-6f647f5754-fcvnn                       1/1     Running     0          22m
kube-system        coredns-6f647f5754-wmhbs                       1/1     Running     0          22m
kube-system        kube-proxy-5v4jd                               1/1     Running     0          17m
kube-system        kube-proxy-bp9pq                               1/1     Running     0          17m
linkerd            linkerd-controller-8684c48c57-8gxlm            3/3     Running     0          9m10s
linkerd            linkerd-destination-6c987dd858-8q824           2/2     Running     0          9m10s
linkerd            linkerd-grafana-67497c9986-7bvfc               2/2     Running     0          9m10s
linkerd            linkerd-identity-594fbc795-j8l9c               2/2     Running     0          9m10s
linkerd            linkerd-prometheus-856444d858-rxnjp            2/2     Running     0          9m10s
linkerd            linkerd-proxy-injector-c69d74568-wxr56         2/2     Running     0          9m10s
linkerd            linkerd-sp-validator-6c6fd9f6fc-7jgf5          2/2     Running     0          9m9s
linkerd            linkerd-tap-7f596dfdfd-rdhmc                   2/2     Running     0          9m9s
linkerd            linkerd-web-6489658d75-dppjw                   2/2     Running     0          9m10s
rio-system         gateway-proxy-v2-86896f6489-pmfp6              1/1     Running     0          9m18s
rio-system         gateway-v2-5fdf4545bc-9hxp9                    1/1     Running     0          9m18s
rio-system         gloo-6657cbbb49-8bbkm                          1/1     Running     0          9m18s
rio-system         linkerd-install-shmbf-4g2dl                    0/1     Completed   0          9m19s
rio-system         rio-controller-55d5669597-tlrn9                1/1     Running     1          9m26s
tekton-pipelines   tekton-pipelines-controller-756f4f448f-mldbk   1/1     Running     0          9m15s
tekton-pipelines   tekton-pipelines-webhook-79fcc6c768-pmn2p      1/1     Running     0          9m15s

rio -A logs
+ linkerd linkerd-identity-594fbc795-j8l9c › identity
+ linkerd linkerd-controller-8684c48c57-8gxlm › destination
+ linkerd linkerd-controller-8684c48c57-8gxlm › public-api
+ linkerd linkerd-tap-7f596dfdfd-rdhmc › tap
+ kube-system kube-proxy-bp9pq › kube-proxy
+ kube-system kube-proxy-5v4jd › kube-proxy
+ cattle-system cattle-cluster-agent-69d5764fc9-zqd2p › cluster-register
+ rio-system gloo-6657cbbb49-8bbkm › gloo
+ rio-system gateway-proxy-v2-86896f6489-pmfp6 › gateway-proxy-v2
+ rio-system gateway-v2-5fdf4545bc-9hxp9 › gateway
+ linkerd linkerd-proxy-injector-c69d74568-wxr56 › proxy-injector
+ kube-system coredns-6f647f5754-wmhbs › coredns
+ kube-system aws-node-9nzrw › aws-node
+ cattle-system cattle-node-agent-bbgn9 › agent
+ cattle-system cattle-node-agent-2js2h › agent
+ linkerd linkerd-web-6489658d75-dppjw › web
+ linkerd linkerd-grafana-67497c9986-7bvfc › grafana
+ kube-system coredns-6f647f5754-fcvnn › coredns
+ tekton-pipelines tekton-pipelines-controller-756f4f448f-mldbk › tekton-pipelines-controller
+ tekton-pipelines tekton-pipelines-webhook-79fcc6c768-pmn2p › webhook
+ linkerd linkerd-destination-6c987dd858-8q824 › destination
+ linkerd linkerd-sp-validator-6c6fd9f6fc-7jgf5 › sp-validator
+ kube-system aws-node-572d8 › aws-node
+ rio-system rio-controller-55d5669597-tlrn9 › rio-controller
+ linkerd linkerd-prometheus-856444d858-rxnjp › prometheus
Error opening stream to linkerd/linkerd-controller-8684c48c57-8gxlm: destination
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-identity-594fbc795-j8l9c: identity
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-tap-7f596dfdfd-rdhmc: tap
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-controller-8684c48c57-8gxlm: public-api
: the server could not find the requested resource
Error opening stream to kube-system/kube-proxy-5v4jd: kube-proxy
: the server could not find the requested resource
Error opening stream to cattle-system/cattle-cluster-agent-69d5764fc9-zqd2p: cluster-register
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-proxy-injector-c69d74568-wxr56: proxy-injector
: the server could not find the requested resource
Error opening stream to kube-system/kube-proxy-bp9pq: kube-proxy
: the server could not find the requested resource
Error opening stream to rio-system/gateway-v2-5fdf4545bc-9hxp9: gateway
: the server could not find the requested resource
Error opening stream to rio-system/gloo-6657cbbb49-8bbkm: gloo
: the server could not find the requested resource
Error opening stream to cattle-system/cattle-node-agent-2js2h: agent
: the server could not find the requested resource
Error opening stream to kube-system/aws-node-9nzrw: aws-node
: the server could not find the requested resource
Error opening stream to kube-system/coredns-6f647f5754-wmhbs: coredns
: the server could not find the requested resource
Error opening stream to rio-system/gateway-proxy-v2-86896f6489-pmfp6: gateway-proxy-v2
: the server could not find the requested resource
Error opening stream to cattle-system/cattle-node-agent-bbgn9: agent
: the server could not find the requested resource
Error opening stream to tekton-pipelines/tekton-pipelines-webhook-79fcc6c768-pmn2p: webhook
: the server could not find the requested resource
Error opening stream to tekton-pipelines/tekton-pipelines-controller-756f4f448f-mldbk: tekton-pipelines-controller
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-web-6489658d75-dppjw: web
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-destination-6c987dd858-8q824: destination
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-prometheus-856444d858-rxnjp: prometheus
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-sp-validator-6c6fd9f6fc-7jgf5: sp-validator
: the server could not find the requested resource
Error opening stream to linkerd/linkerd-grafana-67497c9986-7bvfc: grafana
: the server could not find the requested resource
Error opening stream to kube-system/aws-node-572d8: aws-node
: the server could not find the requested resource
Error opening stream to kube-system/coredns-6f647f5754-fcvnn: coredns
: the server could not find the requested resource
Error opening stream to rio-system/rio-controller-55d5669597-tlrn9: rio-controller
: the server could not find the requested resource

Kubernetes version: Kubernetes Version: v1.14.6-eks-5047ed
EKS security group with All Open

This is working now, just be aware there is a > 3 minute load time for entire process. We may follow up with a fix for that, but this ticket can be tested and closed separately.

Verified in v0.6.0-alpha.2


FTP not working with older Windows FTP Servers

First off, thank you for creating this incredible library!
I'm trying to use fsspec to load data from a couple older FTP servers. They don't support the MLSD FTP command and the _mlsd2 functions seems to assume an older UNIX based FTP server.
I suppose for improving it would be to use regular expressions in _mlsd2 to "sniff" for which format it is.
 The trouble is, we only test against the python implementation, so we can't actually put this into CI unless there's some docker or other executable version of this we can run.

@martindurant I have a working solution. I use a regex in _mlsd2 to detect windows FTP server style lines and default to unix. I realize an e2e testing is more ideal, but really this boils down to text processing in _mlsd2, perhaps a unit test on _mlsd2 would suffice?

Yes that sounds fine, please do submit as an PR.

Are you working on this, @awm33 ?

(ping)


Extract gems pending

The code in the gems/pending directory doesn't need to live in the manageiq repo.  Extracting this directory should:

Make tests on every manageiq PR faster (1 less test suite to run)
Improve visability into what code is going into gems/pending and why
Make it easier to extract code from gems/pending
Make clear the gem dependencies of manageiq

@miq-bot add_label refactoring
@miq-bot add_label technical debt
@Fryguy Please review
cc @jrafanie @chessbyte

Wow,  seems like a good idea.  Let's try to review this as a group when @bdunne feels it's ready.  We'll need to coordinate the merge of this.

@jrafanie I'm ready.  I know it needs rebase, but lets discuss before I rebase.

How do you recommend I review this? It's 5068 files changed and locks up my browser :/

@Fryguy the first commit removes all the files in the /gems/pending directory.  The rest of the commits make adjustments after that is removed.  So, I would just review commits 2..n

Ah thanks @chessbyte !

I spoke to @bdunne offline and we went through it and also went through the changes on the gem itself.  All seems good to me with a few minor things.  @bdunne can you enumerate them here?
One thing I remember was that the linux_block_device gem can't be installed on Mac, so it requires this weird hack.  I think it would be trivial to get it to install on Mac and raise an "unsupported method" exception in the method it creates.  That would then get us away from that gem being "special".

Other mentions from the discussion with @Fryguy :

In manageiq-gems-pending gem: clean up LICENSE file 3rd party legal notices
In manageiq-gems-pending gem: drop large_file_linux and win32-process gems since they shouldn't be needed anymore.
Try to share spec custom matchers to avoid duplication

@bdunne @Fryguy large_file_linux is used in gems/pending/disk/modules/MiqLargeFile.rb

@jerryk55 I pulled that out to its own PR https://github.com/ManageIQ/manageiq/pull/11960 I don't believe it's ever used since it's only loaded on 32-bit systems and we only build for x86_64 at this time.  Please comment there if you think this may be a problem.

@bdunne got it that sounds fine.

@bdunne I know there are at least a few gems that the manageiq code relies on that are only required in the gems/pending Gemfile (for example, linux_admin) do we want to try to find those and add them to the manageiq Gemfile?

@carbonin Would it be possible to have the core app not know about admin stuff? Just be focused on our core business functionality and not on managing the app container (pg, rpms, OS)

@kbrock I think that's a good goal, but I'm not sure it would be very easy to do.
For example, I know we allow users to set timeservers from the web UI and @jrafanie just added some memory monitoring stuff here https://github.com/ManageIQ/manageiq/pull/11690

@carbonin Yes, but I'm honestly not too concerned about it.  The goal is that manageiq-gems-pending will be "short-lived" and never released as a full gem on rubygems.org.  I think this will sort itself out naturally.  As we further split manageiq-gems-pending, we'll remove a lot of the indirect dependencies and whatever is left can be re-evaluated and moved to the manageiq Gemfile.

@Fryguy Everything is up to date.  Let me know if you want any other changes


travis-ci enable tests under address sanitizier

No, I don't think we want these messages, at least not for small changes. This is the default for codecov and it needs to be configured.

@dagar does continuous-integration/sitl/pr also run with asan?

@nicolaerosia not yet, but that's the plan (if I can expand the CI resources).

Added to the builds, but allowed to fail for now until the initial issues are resolved.


fix #607, remove plaintext fever password from db

There is another problem, if you submit the form to update another integration settings, the fever token will be reseted.
The Fever token should be updated in the database only if the fever password is not empty.

This is interesting. I didn't think it works this way because there is a separate Update button in each integration section.
Sure I'll fix this, and I think we can use an improvement to submit the relevant form only, but that's another topic.


Reads default pipelinerun timeout value from configmap

we had hardcoded default timeout for pipelinerun to 2h
in code. this patch update it to read from configmap
and if not available in cm then it would use 2h
as default.
Signed-off-by: Shivam Mukhade<EMAIL_ADDRESS>
Changes

Submitter Checklist

[x] ♽  Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behaviour, please make sure to document it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
[ ] 🔎 If there is a flakyness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

/retest


Update scalafmt-core to 3.3.2

Updates org.scalameta:scalafmt-core from 3.0.8 to 3.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-minor, semver-spec-minor

Superseded by #307.


Initial Try It Out input shouldn't fail & failure should have better message

Reported by @frankhaugen
Try it out's initial random row may contain invalid data.
The bugs here is that the error message could be fleshed out to include "expecting X got Y", and that the default suggestion, (based on a random row), should never be able to fail due to a "format exception"

at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at StreamJsonRpc.JsonRpc.d__941.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.ML.ModelBuilder.AutoMLServiceFactory.AutoMLServiceProxy.<PredictMultiClassClassificationAsync>d__16.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.ML.ModelBuilder.TrainSession.<PredictMultiClassClassificationAsync>d__49.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Microsoft.ML.ModelBuilder.ToolWindows.EvaluateTabDataContext.d__143.MoveNext()

This should be an expected exception
Message should be more descriptive, e.g. "expecting X got Y"
Ensure pre-filled value is valid

This is fixed by https://github.com/dotnet/machinelearning-tools/pull/812


feature: highlights specific highlight group for Cursor

Did you check the docs?

[X] I have read all the flash.nvim docs

Is your feature request related to a problem? Please describe.
Using f,F,t,T I cannot see very well my current cursor position.
As far as I can see I would be able to do that only by setting nvim's "Cursor" highlight (which I'd rather not since it affects the colors in other places).
Describe the solution you'd like
A new highlight group (linked to Cursor for backwards compatibility) used here https://github.com/folke/flash.nvim/blob/8a8e74922a383c253b7f92e042b749150140c8d1/lua/flash/highlight.lua#L72
Describe alternatives you've considered
changing hl Cursor, too invasive
Additional context
No response

well if you don't want to change cursor highlight why not change the other ones so they are different from cursor?
can't test this right now since I'm not at my computer but I'm quite sure this is possible

Yeah, that's what I'm going for right now: setting FlashLabel, FlashMatch and FlashCurrent.
But it's kind of a workaround IMHO.

no not at all
you want something to be different from cursor but don't want to change cursor you have to change the other highlights

You mean to change the other highlights of my colorscheme, in general, so that flash.nvim defaults stand out more?
If so, sure it's doable, but I guess it's even more roundabout (for context, I'm using catppucin and I am almost happy by disabling its builtin integration with flash and overriding FlashLabel, FlashMatch and FlashCurrent, but I'd rather just have the extmark use an additional custom hl group.
@folke I could probably start working on a PR to add this feature, would you consider it?

I'm in the same situation and happy to contribute to get this in


Please give a binary or write sth about how to use it

rt.orz.

@NFLSCode A wiki will be created when the program is completed.

You can type "help" in the program to get a little information.


Implement Phoenix EVM and Protocol Upgrades

PR description
This PR implements EVM and Protocol upgrades as outlined in ECIP 1088 https://ecips.ethereumclassic.org/ECIPs/ecip-1088
Fixed Issue(s)

I've updated this, should be all set now.


Extracting physical ports of a switch to a new page

Related to: https://github.com/ManageIQ/manageiq-ui-classic/pull/4141

@miq-bot assign @agrare

It is used here https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/mixins/generic_show_mixin.rb#L74
It happens when we try to access a detail page, this is the same workaround done here https://github.com/ManageIQ/manageiq/blob/master/app/models/guest_device.rb#L20

:+1: thanks @felipedf

Moving this PR to WIP for now since there is still some discussion ongoing on ManageIQ/manageiq-ui-classic#4141

@agrare it is good to go, we might change the way we present the detail page for smaller components in a future, but let's keep with the way it is for now

Not sure why travis didn't start, closing and reopening to kick it


Remote tracks added event is not raised in the callee peer

Describe the bug
Since I upgraded from 1.0 to 2.0 I can only stream from the client to the server. After having connected successfully the signalers, the audio, video and data remote tracks are not added in the callee peer, while in the caller peer they are added successfully. I found that the problem is that the tracks added event are not raised in the callee peer. I am using the C# library
Expected behavior
The call should have video and audio in both directions.
Environment
Both peers:

MR-WebRTC version: C# release 2.0
Platform: Windows Desktop
Architecture: x64
Target device: Windows Desktop

Hi @Zuzzi94,

I can only stream from the client to the server

There's no client nor server, WebRTC is a peer to peer technology. What are you referring to?

the audio, video and data remote tracks are not added in the callee peer

We need to see at least the SDP messages to try to diagnose this. Please use the Bug Report template. The tracks are added if the offer contains some transceiver.

while in the caller peer they are added successfully

I would expect you add the tracks yourself manually in the caller, therefore this sounds expected.
Sorry but we need a lot more info to diagnose this. What is your setup? What transceivers are added to the caller? What's their configuration? What tracks are on it? And on the callee, is there any transceiver added, or just the ones created by the offer? What are the SDP offer and answer messages?


Improve behaviour of AnimationPlayer warnings.

Makes several improvements and fixes to the popup warnings regarding animation:

Fixes the size of the warning box being incorrect after a warning with a larger window.
Fixes the warning about setting loop modes in foreign scenes to properly acknowledge if the animation is part of an imported scene or just a regular scene.
Adds more descriptive instructions on how to change the loop mode depending on the circumstances.

Thanks!


Generate an file COMMIT to store the current commit id when compile distribution

When download zip in github website without .git, error will be reported and compilation will continue.

Hey, there's another solution that using a native maven plugin to generate git.properties file, and read the commit hash directly to the process.
server/pom.xml
<plugin>
                <groupId>pl.project13.maven</groupId>
                <artifactId>git-commit-id-plugin</artifactId>
                <version>4.9.10</version>
                <executions>
                    <execution>
                        <id>get-the-git-infos</id>
                        <goals>
                            <goal>revision</goal>
                        </goals>
                        <phase>initialize</phase>
                    </execution>
                </executions>
                <configuration>
                    <generateGitPropertiesFile>true</generateGitPropertiesFile>
                    <generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
                    <includeOnlyProperties>
                        <includeOnlyProperty>^git.commit.id.abbrev$</includeOnlyProperty>
                        <includeOnlyProperty>^git.dirty$</includeOnlyProperty>
                    </includeOnlyProperties>
                    <commitIdGenerationMode>full</commitIdGenerationMode>
                    <failOnNoGitDirectory>false</failOnNoGitDirectory>
                    <offline>true</offline>
                    <gitDescribe>
                        <dirty>-dev</dirty>
                    </gitDescribe>
                </configuration>
            </plugin>

IoTDBConstant.java
static {
    Properties prop = new Properties();
    String finalBuildInfo = "UNKNOWN";
    try {
      prop.load(IoTDBConstant.class.getResourceAsStream("/git.properties"));
      finalBuildInfo = prop.getProperty("git.commit.id.abbrev", "UNKNOWN");
      String isDirty = prop.getProperty("git.dirty", "false");
      if (isDirty.equalsIgnoreCase("true")) {
        finalBuildInfo += "-dev";
      }
    } catch (Exception e) {
      System.err.println("get git.properties error: " + e.getMessage());
    }
    BUILD_INFO = finalBuildInfo;
  }

  public static final String BUILD_INFO;
  public static final String VERSION_WITH_BUILD = VERSION + " (Build: " + BUILD_INFO + ")";

Then we can not only find the commit info in the dir but also in the iotdb-cli.

@ericpai Good idea! Would you like to submit a PR with your solution?

@ericpai Good idea! Would you like to submit a PR with your solution?

PTAL this https://github.com/apache/iotdb/pull/7365


Align Resource Names Created By SRT

This PR changes the format of all resources created via terraform to be in the form "stratus-red-team-{attack shortname}-{resourceshortname}*". Some resources use random values at the end of the name to guarantee uniqueness, so these are left, but shortened in order to reduce risk of resource name length restrictions.
I have not been able to test this fully as I do not have personal GCP/AWS/Azure Accounts.

Thank you so much for the contribution! Overall it looks great, just suggested a few improvements before we merge :)

closes #170

Updated about half of the names with suggestions. Will continue working through them soon.

@sjhood Thanks again for the PR - let me know if you need support to close the PR, happy to help if needed!

Thanks for the work? Is it ready for a final review/merging?

Thanks for the work? Is it ready for a final review/merging?

I believe so!

Looks great, thanks again for the contribution!

closes #170

Now released as part of Stratus Red Team v2.4.9


Cannot resolve package subpaths in type checking phase

In the mappings config you can do stuff like this:
"https://deno.land/x/my_module/extras": {
  name: "my-module",
  version: "1.0.0",
  subPath: "extras",
}

I tried this today and dnt will even check that my-module even has extras in its exports field. Cool.
But it can never get past the type checking phase:
[dnt] Type checking...
some/path - error TS2307: Cannot find module 'my-module/extras' or its corresponding type declarations.

I know from painful experience that TS does not yet have support for the package.json exports field unless the tsconfig is changed to have module: 'nodenext', moduleResolution: 'nodenext'. Could that have something to do with it?

Related: https://github.com/denoland/dnt/issues/118

I have come up with a truly filthy hack to get around this, after finding the solutions in #118 did not work for me.
Typescript does not know how to resolve using the exports field, but it can resolve paths. So I added this at the end of my build script:
Deno.writeTextFileSync(
    'npm/browser.js',
    `export * from "./esm/src/entries/browser.js";`,
);

Deno.writeTextFileSync(
    'npm/browser.d.ts',
    `export * from './types/src/entries/browser';`,
);

Deno.writeTextFileSync(
    'npm/node.js',
    `export * from "./esm/src/entries/node.js";`,
);

Deno.writeTextFileSync(
    'npm/node.d.ts',
    `export * from './types/src/entries/node';`,
);

Now exports-unaware TS is able to pick up on the now very real subpaths, while stuff that supports it (webpack, rollup, etc) can use it! Going to go take a shower.

Related: #118
This is something that hasn't been implemented in TypeScript ☹

hasn't this been implemented now? why does the issue persist?


Callback error on start

Callback error on start
Describe the bug
Upon starting docz dev an error pops, it goest away but is still showing in the console
To Reproduce

Start a fresh docz 2.0rc
Once localhost starts you get the error

Uncaught TypeError: callback is not a function
    at flushFirstCallback (scheduler.development.js:107)
    at flushWork (scheduler.development.js:219)
    at MessagePort../node_modules/scheduler/cjs/scheduler.development.js.channel.port1.onmessage (scheduler.development.js:611)

Hi @fraincs , just ran into this as well.
According to https://github.com/facebook/react/issues/15647 the fix is to add
"scheduler": "0.14.0" as a dependency. This solved the issue for me. Could you verify? If so, I'll shoot in a PR

@patricksevat That solved this issue for me.

Thx for letting me know @will-stone, I'll leave the implementation of this fix to @pedronauck as the current dev setup of docz v2 errors in my local set-up (probably some windows issue)

I ran into the same error when trying to use React hooks. I'm still on<EMAIL_ADDRESS>and adding<EMAIL_ADDRESS>helped workaround this issue.

@patricksevat That solved this issue for me too.

Just tried and had to apply same fix, since this is a showstopper, meanwhile is needed to launch the project I think it should be added to the getting started guide.

Should be fixed by : https://github.com/pedronauck/docz/commit/84918d8ac4fd11b2f69b065c786ca81217ce8d68
Will update here when the next version is release.

Released as version 2.0.0-rc.5
Please let me know if it fixes this issue for you 👍

Closing this as resolved, feel free to re-open it if the issue happens again.

hmm... started a new project with docz and suddenly (yay) after I've added astroturf package i started getting this error. removing the package did not help.
I'm currently using<EMAIL_ADDRESS>here're the relevant parts of package.json and yarn.lock

package.json

{
  "devDependencies": {
    "astroturf": "^0.9.17",
    "docz": "^2.0.0-rc.40",
    "prop-types": "^15.7.2",
    "react": "^16.9.0",
    "react-dom": "^16.9.0"
  }
}

yarn.lock (irrelevant parts omited)

<EMAIL_ADDRESS><EMAIL_ADDRESS>  version "2.0.0-rc.40"
...
  dependencies:
...
    scheduler "^0.15.0"
...

<EMAIL_ADDRESS>  version "2.3.0"
...
  dependencies:
...
    scheduler "^0.13.2"
...

<EMAIL_ADDRESS>  version "16.9.0"
...
  dependencies:
...
    scheduler "^0.15.0"

<EMAIL_ADDRESS>  version "0.20.4"
...
  dependencies:
...
    scheduler "^0.13.6"

<EMAIL_ADDRESS><EMAIL_ADDRESS>  version "0.13.6"
...

<EMAIL_ADDRESS>  version "0.15.0"
...

yarn why scheduler
$ yarn why scheduler
yarn why v1.17.3
[1/4] 🤔  Why do we have the module "scheduler"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "scheduler"
info Reasons this module exists
   - Hoisted from "docz#gatsby#gatsby-cli#ink#scheduler"
   - Hoisted from "docz#gatsby#gatsby-cli#ink#react-reconciler#scheduler"
info Disk size without dependencies: "128KB"
info Disk size with unique dependencies: "212KB"
info Disk size with transitive dependencies: "236KB"
info Number of shared dependencies: 3
=> Found<EMAIL_ADDRESS>info This module exists because "docz" depends on it.
info Disk size without dependencies: "212KB"
info Disk size with unique dependencies: "296KB"
info Disk size with transitive dependencies: "320KB"
info Number of shared dependencies: 3
=> Found<EMAIL_ADDRESS>info This module exists because "react-dom" depends on it.
info Disk size without dependencies: "212KB"
info Disk size with unique dependencies: "296KB"
info Disk size with transitive dependencies: "320KB"
info Number of shared dependencies: 3

Same issue. Pinning schedular to 0.15.0 resolved foe me too.


Check for undefined selData list

@RackHD/corecommitters @zyoung51

+1

:+1:

:+1: unit test love!!

:+1:

*** BUILD #356 ***


Re-written all the yaml files made missing ones

Rewritten all the yaml files.
Not only were several missing completely but some were just in English because we didn't write out to yaml last time Lucy and I fixed the script.
Now all of this is fixed.
However, merging this will overwrite some of the manual edits that I made recently so I want to carefully check before merging.

frontpage.yml needs investigating.
the python file needs newlines and indents put back in.


Fixing doc generate failure

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind failing-test
/kind enhancement
What does this PR do / why we need it:
Prow unable to sense github action failure. So to avoid merges after failure, i have added the make docs in the prow job so that the failure status will be identified and pr won't merge into the master.

Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes NA
How to test changes / Special notes to the reviewer:
make docs error should be reported in prow job

In test-platform channel I will report this behavior of prow why it does not honor other CI failure even after enabling the branch level protection.

There is an open pr for the fix - https://github.com/kubernetes/test-infra/pull/19520

/approve


nixos/languagetool: fix startup configuration option

The languatetool service uses an erroneous configuration option. This PR corrects it.
Description of changes
Change the option --configuration to --config .
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

ZHF: #199919

@NixOS/nixos-release-managers this PR seems ready to be merged.


Add empty lines to build log to make them easier to navigate

optionally a ================= line
easier to find begin end of some major block

convenience priority level

I added some section separators, they are available in the latest version of the action.  Let me know if they could still benefit from blank lines

I added some section separators, they are available in the latest version of the action.  Let me know if they could still benefit from blank lines


Provide a fully working example of connecting a GKE pod to the private IP of a CloudSQL instance

I recently went through a lot of pain to figure out how to do this, it feels like this should be a fairly common pattern and it would be great to have better documentation and examples on how to do it.
Here's the bug report on google config connector that describes the trouble I had and the eventual solution as a guide.
https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/201

There is already a working example, referenced in the k8s-config-connector issue: https://github.com/paulczar/gcc-cloudsql


jibDockerBuild is not caching base image

Running jibDockerBuild always downloads base image. Jib should be caching the image.

@schmitch I'd say this one is solved now

should be working now, please raise the issue again if you still have problems


Create 1851-Minimum-Interval-to-Include-Each-Query.cs

File(s) Modified: 1851-Minimum-Interval-to-Include-Each-Query.cs
Language(s) Used: csharp
Submission URL: https://leetcode.com/submissions/detail/810995396/

Thanks, @ShrujanKotturi!


[BUG] Error: Bug : uncompressed data size mismatch

Bug Description
uncompressed data size mismatch error is shown in console if upload big data (but uploading process looks like continuing)
Bug Reproduction

select big data. in my case I selected zip file with 1.79GB
click uploading, it will show error (see screenshot)

Bug Impact
No response
Bug Screenshots

Bug References
No response
Bug System Information

OS: [e.g. Windows 10]
Browser: [e.g. Google Chrome, Firefox]

┆Issue is synchronized with this Wrike task by Unito

This seems to be a bug in JSZip library
https://github.com/Stuk/jszip/issues/777


Update tethys-core, tethys-jackson to 0.22.0

Updates

com.tethys-json:tethys-core
com.tethys-json:tethys-jackson

from 0.21.0 to 0.22.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.tethys-json" } ]

labels: library-update, semver-minor

Does this update cause or fix the runtime error mentioned by @REDNBLACK? Should we merge it?


Add chromatic visual tests

Issue: We didn't have visual regression tests for our stories
Note: this is built on https://github.com/storybooks/storybook/pull/2504
What I did
Added chromatic to our CI
How to test
Make a UI change, check out the build at https://chromaticqa.com
NOTE: this is not currently accessible to members of the storybooks org, just sorting out org permissions.
Anyone in the storybooks org on GH should be able to access the project here: https://www.chromaticqa.com/builds?appId=5a375b97f4b14f0020b0cda3

@ndelangen do you have the permission to grant access from the storybooks GH org?

Note that there's an ongoing work on adding visual testing functionality to storyshots: #2413

@Hypnosphi

Note that there's an ongoing work on adding visual testing functionality to storyshots

Yes! I think this is great! I think however for a larger project like this one Chromatic can offer a little more on top of that, namely parallelized / cloud screenshots and an review flow UI. Interested to hear your thoughts.

Oh, that's actually pretty cool. I think there's a value in adding this for all the cra-kitchen-sink stories

I think there's a value in adding this for all the cra-kitchen-sink stories

Yes, I'll get this going once we sort out #2504

Please rebase, so i can better judge this PR, looks all right.

@ndelangen done.

This is ready to merge when the 3.3 release process is complete.

How does it affect release process?

It shouldn't, but @shilman asked me to hold off merging into master until the release is out...

Merge when ready, if you ask me


Create PyPi package

python -m pip install build twine
python -m build
twine upload dist/*  --verbose

Oops.  This was not the pypi stuff.  Going to delete this branch and make PR from the correct one.


On createUser and dropUser integration tests use usersInfo for assertions

Description
Rely on the public API by using usersInfo to verify that createUser and dropUser works as appropriately, rather than calling internal methods using FindOne.
Closes #1496.
Readiness checklist

[ ] I added/updated unit tests (and they pass).
[ ] I added/updated integration/compatibility tests (and they pass).
[ ] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[x] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

I ensured that PR title is good enough for the changelog.

That wasn't done.

(for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.

That wasn't done.
The checklist is there to actually check yourself, not just to check items on autopilot.

Oops, sorry! Fixing now.

The commit landed with the old subject and empty body.

Oops. @AlekSi, would it make sense to create a task to reset auto-merge status if PR title is changed?

Or maybe apply the same rules for PR title validation for the first line of the auto-merge commit?

In general, yes, but I'm not sure when and how


add livenessprobe

I'm very conservative onto failureThreshold to avoid pod restarts. After this PR the generated liveness probe will be
 livenessProbe:
  failureThreshold: 10
  httpGet:
    path: /status
    port: web
    scheme: HTTP
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 10

Fix #303

Please test this

test this please

@mxinden is investigating why tests are not being run, we'll hold off for now and if it turns out we can't fix it quickly I'll test it myself some time tomorrow or the day after.

test this please

Test this please.

Test this please.

@brancz @gianrubio PR trigger works again. Sorry for the troubles.

@mxinden thanks for fixing the builds, saved me a lot of time. LGTM! Thanks a lot @gianrubio


Roll engine 20d3861ac8e1..a263abfba0b3 (28 commits)

https://github.com/flutter/engine/compare/20d3861ac8e1...a263abfba0b3
git log 20d3861ac8e1f8f38c8659b16b699d0e63db01b1..a263abfba0b314dc5602d23d651bfd4f8e1289f7 --no-merges --oneline
a263abfba Roll src/third_party/skia dc57783169c3..e0a001ccf8d5 (1 commits) (flutter/engine#9372)
f75e7228f Roll src/third_party/skia c65edca18491..dc57783169c3 (3 commits) (flutter/engine#9371)
3f7a9f09f Roll src/third_party/skia 48fec763d45d..c65edca18491 (1 commits) (flutter/engine#9369)
c764a7628 Do not remove the DartServiceIsolate status callback during FlutterMain destruction (flutter/engine#9368)
4c9fa4940 request FlutterView focus when setting a platform view text client (flutter/engine#9366)
4a3e69d5d Roll src/third_party/skia 7694b90eb000..48fec763d45d (11 commits) (flutter/engine#9367)
2f36285bc Surrogate binary messenger (flutter/engine#9347)
0ca0a4161 [glfw]  Implement clipboard support from GLFW api (flutter/engine#9361)
66db3d58e Add APIs for querying FlutterView for a FlutterEngine and listening for attachment/detachment (#29114). (flutter/engine#9356)
f2e76a892 Android Embedding Refactor PR32: Clean up logs in new embedding (#33544, #33102). (flutter/engine#9351)
36f18b0ae Android Embedding Refactor PR33: Clean up FlutterJNI (#25533). (flutter/engine#9354)
63591bcd9 Roll src/third_party/skia c6438c0b7f32..7694b90eb000 (12 commits) (flutter/engine#9364)
92cb11d07 Fix test name typo (flutter/engine#9362)
340d958ff Roll src/third_party/skia 07edcfd4dc19..c6438c0b7f32 (9 commits) (flutter/engine#9359)
280fa4551 Roll src/third_party/skia c6628127dc30..07edcfd4dc19 (9 commits) (flutter/engine#9358)
aa4bc1be6 Roll src/third_party/skia e7f8c34384ed..c6628127dc30 (1 commits) (flutter/engine#9357)
48974cac0 Roll src/third_party/skia 9c71e7be1097..e7f8c34384ed (3 commits) (flutter/engine#9355)
04d44a39d Roll src/third_party/skia 4b203ad7ac02..9c71e7be1097 (4 commits) (flutter/engine#9353)
05c034e5b Update component manifests for ambient replace-as-executable (flutter/engine#9350)
66022ce25 Roll src/third_party/skia<PHONE_NUMBER>5c..4b203ad7ac02 (6 commits) (flutter/engine#9352)
fcff2d619 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337)
ea7ca9804 Send the isolate service ID from the engine to the embedder (flutter/engine#9324)
675033fc0 Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322)
e5918d18f Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348)
e00ac47f4 Reorganize darwin for shared ios/macOS (flutter/engine#9255)
9da409c0e Fix crash on Huawei device with AndroidView (flutter/engine#9192)
a0f85546f Removed an unused class definition for iOS code. (flutter/engine#9346)
96a1a843c Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6271808886538240

Commit queue failed; closing this roll.


Correctly transform normals for non-uniform scales

This changes the way normals are transformed in the vertex shader of bevy_pbr. In order to correctly transform normals, the scaling actually has to be applied inversely (see this explanation for details). Otherwise non-uniform scales will produces incorrect normals.
My proposed change comes with the assumption that the Model matrix is orthogonal (i.e. does not contain shearing). This allows for some optimization, I can explain more if needed.
Here's a pancaked version of load_gltf as comparison:

screenshot

Since this is just a minor change I didn't bother creating an issue. Feel free to close if the solution doesn't seem fit.

Three naive questions:

Will this method be called repeatedly? Aka, do we care about optimizing here?
Are there any realistic scenarios where users may want a non-orthogonal model matrix?
Can we include some sort of assert or warning if this assumption is violated without compromising performance?

Three naive questions:

Will this method be called repeatedly? Aka, do we care about optimizing here?
Are there any realistic scenarios where users may want a non-orthogonal model matrix?
Can we include some sort of assert or warning if this assumption is violated without compromising performance?

Kind of? It's executed for all vertices every frame. It's running on the GPU so it's not a huge impact, but using the "optimized" version I went with does maybe save 20-30 or so arithmetic operations.
Alternatively we could also just use the more general transpose(inverse(m)) and take that (minor) performance hit.
Currently I don't think that's even possible in bevy to my knowledge. At least not without major changes from the user. The Transform component only stores position, rotation and scale which makes it impossible to produce shearing.
From what I know, shearing is usually even something developers try to avoid, because it can get tricky to handle when it comes to collision detection / physics, culling, etc.
(see 2.): Not really applicable because it's currently not possible to produce that case.

Great, sounds like a perfectly reasonable optimization then. Thanks for the explanation :)

There's a scenario that I haven't considered, yet, sorry.
I'll keep this as a draft until I tested and verified it.

It would also be worth investigating how other popular engines approach this calculation. It seems like they must be doing it by default, so its probably just a matter of peeking at their shaders. I'm familiar with godot's code, so I can just link to the relevant bit:
https://github.com/godotengine/godot/blob/4a7679e4dd9f68270b3d27797146f88491f182b8/servers/rendering/renderer_rd/shaders/scene_forward_clustered.glsl#L119

@cart thanks for the input and link. I did take a look at the Godot's shader code but to be honest, it doesn't look quite right to me.
As mentioned in my comment above, to my knowledge transpose(inverse(m)) should be the general approach of inverting the scale of a mat3 and keeping everything else. Taking things to the editor seems to confirm this (unless the bitflag of the shader needs to be enabled in-editor somehow):

screenshot

I went for the (non-shearing) optimization because invert(m) is a quite hefty operation. It's not too bad here since it's just a mat3 but I still opted for performance given that shearing can't even happen currently. Godot's approach of branching and passing it as a bitflag is interesting, but I don't have what it takes to bring that into bevy.
Also, I'll likely keep this a draft until some things arount #1755 are cleared up.

Closing, since this is for the old renderer and the new one already does this correctly.


Use set to accelerate netlist building

When querying which connections are sourced at which filters using a set
to store the data is considerably faster than using a list
(not surprisingly...). This results in a 14s speed-up on the build time
for a 256-D circular convolution network on my laptop.

Insert comment about & operator here


More than one input support

Right now only one input is supported. Change this to support n inputs.

This issue is related to "More than one sparkContext".


Getting a RecvError() no matter what I do

I use this library to run a twitter bot, but I must have changed something, and lately every time the cron job actually starts, it stops immediately with a generic error:
2023-11-14T01:00:00.196354Z ERROR tokio_cron_scheduler::job::creator: /home/pi/.cargo/registry/src/index.crates.io-1cd66030c949c28d/tokio-cron-scheduler-0.9.4/src/job/creator.rs: Error running job a67d2389-3be4-4ca8-8b70-8afd7a202170 RecvError(())

and I'm not sure how to debug. I've put the contents of the job into a cron_tweet() fn, and doing something like:
let hour_offset = 1;
scheduler
    .add(
        // 6pm MST is midnight UTC
        Job::new_async(format!("0 0 {} * * *", hour_offset).as_str(), |_, __| {
            Box::pin(async move {
                cron_tweet().await;
            })
        })
        .unwrap(),
    )
    .await
    .unwrap();

has the error, but just:
cron_tweet().await;

works fine.
The start of my cron_tweet() function is:
async fn cron_tweet() -> () {
    info!("Starting cron...");
    let config: Config = get_config().expect("Getting config failed!");
    let dao = match ant_data_farm::connect_config(config.database).await {
        Err(e) => {
            error!("Failed to initialize database: {}", e);
            error!("Ending CRON early!");
            return;
        }
        Ok(dao) => dao,
    };

  ...

where the dao is a database connection. And I actually see the Starting cron... logs:
2023-11-14T00:55:45.953573Z  INFO ant_who_tweets: projects/ant-who-tweets/src/main.rs: Saw 255 seconds until next job, sleeping for 255 seconds!
2023-11-14T01:00:00.148506Z  INFO ant_who_tweets: projects/ant-who-tweets/src/main.rs: Starting cron...
2023-11-14T01:00:00.196354Z ERROR tokio_cron_scheduler::job::creator: /home/pi/.cargo/registry/src/index.crates.io-1cd66030c949c28d/tokio-cron-scheduler-0.9.4/src/job/creator.rs: Error running job a67d2389-3be4-4ca8-8b70-8afd7a202170 RecvError(())

but then immediately the error. The manual way (no scheduler, just calling cron_tweet().await directly, has all the right logging).
What could RecvError() come from? Why does this happen? It doesn't seem like a bad connection to the DB, or my error! logs would appear, but they aren't...

version 0.9.4
tokio version 1.35.1
Just had this happen as well. Been running fine for a week then suddenly today I get this in my logs.  I have error reporting for my own things and had nothing show up there.
its being reported here, line 96:
https://github.com/mvniekerk/tokio-cron-scheduler/blob/da2e31087603661e6b4a7679cb4cde72e0ae130e/src/job/creator.rs#L94-L104
From what I can gather, tokio has three errors with this name:

seems to have something to do with channels?

Yep, I think there must be some kind of race condition within the library. You can see in my Git history link that very minor things change, and this error no longer affects me today.
Really, I added some logging, and things fixed themselves.

me too...
2024-09-10T07:00:00.282823Z  INFO hedon_bot::cron_task: Run go_official_blog 2024-09-11 07:00:00 UTC
2024-09-10T07:00:00.282919Z ERROR tokio_cron_scheduler::job::creator: Error running job 7a8fab45-ab4d-4c5c-b57e-3c77f2dd2b43 RecvError(())
2024-09-10T07:50:00.011838Z  INFO hedon_bot::cron_task: Run redis_official_blog 2024-09-10 08:50:00 UTC
2024-09-10T07:50:00.016983Z ERROR tokio_cron_scheduler::job::creator: Error running job 2d6a8cf1-fb6f-48fb-a483-58c5f950b600 RecvError(())
2024-09-10T10:50:00.381384Z  INFO hedon_bot::cron_task: Run redis_official_blog 2024-09-10 11:50:00 UTC
2024-09-10T10:50:00.381490Z ERROR tokio_cron_scheduler::job::creator: Error running job 2d6a8cf1-fb6f-48fb-a483-58c5f950b600 RecvError(())

me too...
2024-11-13 21:24:00.65259133 [ERROR] [/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/tokio-cron-scheduler-0.10.2/src/job/creator.rs:96] Error running job b60d3076-ce96-4aba-bb9c-8f6715c19665 RecvError(())


Allow vmap(parametrized(fun))

Add a batching rule to the parametrized primitive.

Use case now covered by Batched (https://github.com/JuliusKunze/jaxnet/issues/20).


Lazily load a demo that highlights locally imported WASM modules.

Putting WASM modules in the main demo bloats the build.
We still want to show this is possible though.
Will require #70 though

This is done in the character demo


Audit clone usages

Address some of the clone() usages #10
Introduce WorkloadBuilder in an effort to clean up how Workload is constructed
Simplify byte_to_ip function and added tests

Hi @digitalsanctum. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@digitalsanctum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
bc0d33c4c3c5029207afd206fbcad5d248cb8ea9
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@digitalsanctum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
920d13ade83bd0d5c25be1e6167fad9a7723a8b4
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


docs: Remove periods from Managing deploy keys list

Why:
Closes: https://github.com/github/docs/issues/34522

What's being changed (if available, include any code snippets, screenshots, or gifs):
As per the https://github.com/github/docs/issues/34522

Periods need to be removed from each list line, as each line is not a complete sentence (per our style guide)

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@gonmmarques Thank you so much for opening a PR with this fix! ✨ This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 9/16 🍏 thanks again!


Makefile highlighting doesn't work well if there are variable declarations before the first block

(Original issue 794 created by mitya57 on 2012-07-31T09:22:14.379055+00:00)
Compare these two blocks:
{{{
#!makefile
hello:
gcc hello.c -o hello
}}}
and
{{{
#!makefile
CC=gcc
hello:
$(CC) hello.c -o hello
}}}
First one is highlighted correctly (hello becomes a Name.Function), and the second one is not (hello is not recognized and not highlighted at all).
See http://pygments.org/demo/52994/ and http://pygments.org/demo/52995/.

(Original issue 794 last updated on 2012-08-19T08:33:10.045925+00:00)
(Issue automaticaly closed due to status in Bitbucket: duplicate)

(Original comment by birkenfeld on 2012-08-19T08:33:10.064365+00:00)
Duplicate of #798.

(Original comment by birkenfeld on 2012-08-19T08:33:24.873294+00:00)
Should be fixed with the fix for #798.


fix(table): optimize right-click menu in table-operation-menu(#108)

PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 108
What is the new behavior?
优化table右键菜单当视口过小，菜单展示不全并且无法上下滚动，影响用户体验

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Summary by CodeRabbit

New Features

Enhanced clipboard functionality for copying table content using the Clipboard API.
Improved scrolling behavior for the operation menu when it exceeds the viewport height.

Bug Fixes

Added error handling for clipboard operations to manage potential failures.

Refactor

Optimized the creation of menu items for better performance during DOM manipulation.

@all-contributors please add @jany55555 for code.


Java SDK : Account Transaction - Init Contract

Closed as of of https://github.com/Concordium/concordium-java-sdk/pull/146


Cannot use relative import when importing root schema to use as a fixture for Pytest

Describe the Bug
Attempting to import the root schema into a conftest using a relative path will cause a cryptic strawberry.exceptions.duplicated_type_name.DuplicatedTypeName error. Using a absolute path fixes the problem.
Example
# conftest.py

from .schema import schema as strawberry_schema                       # <-- this breaks!
from api_graphql.schema import schema as strawberry_schema   # <-- this works!

@pytest.fixture
def schema():
    return strawberry_schema

Stack trace
ImportError while loading conftest '/workspace/backend_service/medallion/api_graphql/conftest.py'.
/usr/local/lib/python3.9/site-packages/ddtrace/internal/module.py:220: in _exec_module
    self.loader.exec_module(module)
backend_service/medallion/api_graphql/conftest.py:12: in <module>
    from .schema import schema as strawberry_schema
/usr/local/lib/python3.9/site-packages/ddtrace/internal/module.py:220: in _exec_module
    self.loader.exec_module(module)
backend_service/medallion/api_graphql/schema.py:101: in <module>
    schema = strawberry.Schema(
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema.py:160: in __init__
    raise error.__cause__ from None
/usr/local/lib/python3.9/site-packages/graphql/type/definition.py:808: in fields
    fields = resolve_thunk(self._fields)
/usr/local/lib/python3.9/site-packages/graphql/type/definition.py:300: in resolve_thunk
    return thunk() if callable(thunk) else thunk
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:516: in <lambda>
    fields=lambda: self.get_graphql_fields(object_type),
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:373: in get_graphql_fields
    return _get_thunk_mapping(
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:133: in _get_thunk_mapping
    thunk_mapping[name_converter(field)] = field_converter(
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:314: in from_field
    self.from_maybe_optional(
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:769: in from_maybe_optional
    return GraphQLNonNull(self.from_type(type_))
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:787: in from_type
    return self.from_object(type_.__strawberry_definition__)
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:517: in from_object
    interfaces=list(map(self.from_interface, object_type.interfaces)),
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:426: in from_interface
    self.validate_same_type_definition(interface_name, interface, cached_type)
/usr/local/lib/python3.9/site-packages/strawberry/schema/schema_converter.py:949: in validate_same_type_definition
    raise DuplicatedTypeName(first_origin, second_origin, name)
E   strawberry.exceptions.duplicated_type_name.DuplicatedTypeName: Type UuidBasedTimeStampedInterface is defined multiple times in the schema

System Information

Operating system: macOS
Strawberry version (if applicable): strawberry-graphql 0.199.2, strawberry-graphql-django 0.16.0

Additional Context
This bug was not present in previous versions. Specifically, it was working as expected in: strawberry-graphql 0.133.5, strawberry-graphql-django 0.7

Woow, this is really interesting... Wondering what might be causing that.
Btw, does that only happen for strawberry django schemas, or for strawberry in general?

Good point, I think this might be a strawberry issue rather than a strawberry django issue


Adds RoadNetworkBuilder.

🎉 New feature
Related to #10
Goes on top of https://github.com/maliput/maliput_osm/pull/13
Summary
Adds a basic RoadNetworkBuilder where rules aren't populated.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Branch is updated. No changes added. @agalbachicar


Migration from anytree to bigtree

I would migrate from anytree to bigtree.
With this data
item | parent
H-FUQF | NaN
FUQF.ALB.22.100 | H-FUQF
2999-12353-01- | FUQF.ALB.22.100
221355-090-2 | 2999-12353-01-
2922-01366-01- | 2999-12353-01-

this "anytree" code work fine
from anytree import Node, RenderTree

# create the tree
root = None
nodes = {}
no_parent = {}

for id, parent in zip(df_slim["item"], df_slim["parent"]):
    if type(parent) == float and  np.isnan(parent) :

        node = Node(id)
        root = node
        nodes[id] = node
    else:
        if not parent in nodes:
            node = Node(id)
            no_parent[id] = [node, parent]
        else:
            node = Node(id, nodes[parent])
            nodes[id] = node

for i, np in no_parent.items():
    np[0].parent = nodes[np[1]]
print(RenderTree(root))

Node('/H-FUQF')
└── Node('/H-FUQF/FUQF.ALB.22.100')
    └── Node('/H-FUQF/FUQF.ALB.22.100/2999-12353-01-')
        ├── Node('/H-FUQF/FUQF.ALB.22.100/2999-12353-01-/221355-090-2')
        ├── Node('/H-FUQF/FUQF.ALB.22.100/2999-12353-01-/2922-01366-01-')
        ├── Node('/H-FUQF/FUQF.ALB.22.100/2999-12353-01-/242241-402-1')

Please, how to convert above code to run using bigtree ?
Thank's in advance

Hi, thanks for using bigtree!
If I can break down what you're trying to do - you're trying to convert the dataframe (with parent-child relation) to tree, and then do a print of the tree to console.
This can be done as such,
from bigtree import dataframe_to_tree_by_relation

# Convert dataframe to tree
root = dataframe_to_tree_by_relation(df_slim, child_col="item", parent_col="parent")

# Print tree to console
root.show()

Hope this works!

Yes it work, thank's!


fixed download rule

fixed issue with eutils from NCBI and problem downloading host genome assembly.

gotcha. I've made bunch of tiny tweaks in my current branch adding prototypeSelection, but I will do this from now on.


Documentation broken

As discovered in #663, the documentation target docs is currently broken:
| Copy directory: utils/haddock/haddock-api/resources/html => _build/docs/html
| Run Sphinx Html: docs/users_guide => _build/docs/html/users_guide
Error when running Shake build system:
* docs
* _build/docs/html/index.html
* _build/docs/html/libraries/index.html
* _build/docs/html/haddock-bundle.min.js
Error, rule finished running but did not produce file:
  _build/docs/html/haddock-bundle.min.js

What's weird is that the file in question _build/docs/html/haddock-bundle.min.js does exist! So this looks like some concurrency issue.

Fixed in #665.


Erase temporary buffer in EVP_PKEY_get_bn_param()

Function EVP_PKEY_get_bn_param() uses temporary buffer (on stack or heap allocated) to store serialized bignum, but after deserializing it into BIGNUM*, the buffer is not erased and may contain sensitive data.
This change makes sure the buffer is erased if it was successfully filled before. Unfortunately, it does not distinguish between public and private key components, and will always erase the buffer.
Fixes https://github.com/openssl/openssl/issues/20626

I don't know if we have any way of testing the malloc branch currently since it requires more than 16384 bits of data.

Well, one thing I could try is generate a really large RSA key, with n being slightly bigger than 2048 bytes.  Then, I can add a test that contains my key as hardcoded bignum arrays, import it with EVP_PKEY_fromdata(), then export a large bignum n using EVP_PKET_get_bn_param(). Using hardcoded key is not an issue in this case and I guess import should work much faster than generation, so no problem in adding it to openssl test suite.

I think it is fine as is.

This pull request is ready to merge

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.


Encode zero as the first witness in every circuit

Currently the barretenberg proving system does this implicitly, however we want to remove this and enforce it on the Noir side. This means that we can safely use this in the Noir compiler.

The insert function for merkle tree currently uses this, however it is currently only safe for the version of barretenberg we are using and only for barretenberg.

This has not been fixed as of yet -- its not necessarilly a bug now, it was a bug when we were directly considerign barretenberg.
The solution is to:

Allow the compiler to encode zero and possibly 1 in every program using two arithmetic opcodes.
In barretenerg, no longer use the witness indices directly. Instead form a map so that there is mapping from ACIR indices to barretenberg indices.

For the second point, it means that ACIR could start at witness 0, but barretenberg would map this to witness indice 1 in its own constraint system, because for barretenberg, witness index 0 is reserved. Importantly, it does not need to be for Noir.


Submodule View for Registry

Feature description 💡
Similar to this in tf cloud:

Anything else?
No response

We tried migration today, but because we are using the module registry in Terraform Cloud and we use submodules, we aren't able to migrate completely because Terrakube doesn't support submodules in the registry. The other thing that killed our migration was https://github.com/AzBuilder/terrakube/issues/496

Hello @jcanizalez do you have any idea how this could be implemented in the UI? I remembered you implemented something to download the module from the registry when using the UI but not sure if you have a way to handle folders to handle a dropdown like that? Any idea?

Hi @alfespa17
Yes basically the object hclResult in the Modules view has a property module hclResult[0]?.module
We need to parse this property to extract all the submodules used in the Module and then present the data in the UI.
I think is not complicated I will add this to 2.17.0 milestone
@jderieg only to clarify even if you can't see the submodules in the UI, you should be able to use the modules with submodules in Terrakube

Hi @jcanizalez , we did attempt to access the submodules through the terrakube API, but Terraform didn't seem to be able to see them.

I'll run another test again this morning to make sure, and I'll post any errors I see.

@jcanizalez I was wrong, and you are correct. I am able to successfully call the Terrakube Registry and use submodules within our module using the terrakube-reg URL that Terrakube gave me after I set up the module in the registry. That is great news, thanks for pointing me in the right direction. You guys are awesome!
So yeah, this ticket would just be strictly for the UI to be able to parse the submodules and list them similar to the screenshot I posted at the top.

One additional question about the Private Registry:
After I create a module, in the instructions in the bottom right of the UI, it gives this instruction:

However, we're able to access the Terrakube registry from runners on GitHub that don't have this token specified.
I'm wondering how this is happening?
Is this because of the VCS Provider that is set up providing OAuth to terrakube from our organization? I just want to make sure my Terrakube isn't hosting a module registry that's open to the public.
The Ingress is public, through an AWS LB, but I've got Terrakube using GitHub for auth, and login to the UI, etc, is working properly and protected by login. Not sure how I can verify that the Terrakube Registry is not available publicly. Any ideas?

Hello @jderieg I rememberd that authentication is required for the registry, let me check the code and send an example.

I seem to be able to get to the registry no matter what. Token or no token.

You are correct, this is an issue.
I am testing with my registry in in a test environment in GITPOD and it allows to download modules without the token
But I am not sure what is causing this issue because we have the spring security context setup here

OK, glad to know I'm not crazy, haha! Thanks for looking into it. I've removed my module for now until I hear back.

hi @jderieg
I have included the submodule view, and will be released in the 2.17.0. You can see some screenshots here: documentation So I'm closing this issue


Update UX when status changes

Task/Issue URL: https://app.asana.com/0/488551667048375/1206832754348922/f
Description
See task
Steps to test this PR
See task

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4310  👈
#4307
#4304
#4297
#4291
#4233
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @marcosholgado and the rest of your teammates on  Graphite


Question: Should I resize my images?

I'm just wondering if I should be resizing the provided image to the Resnet expected size?
For example Resnet50 is expecting 224x224 image sizes. Or is that taken care of?

Looks like there's an existing transform for resizing, so it's taken care of.  You may consider cropping your images to equal width and height though - to avoid any distortion.
https://github.com/christiansafka/img2vec/blob/8b63ed677327382b5db56dc9b193ca32fd3a8b9f/img2vec_pytorch/img_to_vec.py#L44

Thank you!


Body Tracking C# Wrapper on Linux (or Alternative)

This may be just as much a question as it is a feature request.
Is your feature request related to a problem? Please describe.

I have run into the same error outlined in #1304 in which the C# wrapper (specifically creating a tracker) is not supported on Linux.
Describe the solution you'd like

First off, I'd like to add my vote for this feature as I feel that there would be tremendous value in the ability to build with the C# wrapper in .NET Core on Linux.
Describe alternatives you've considered

Here is where my question comes in. I am wondering if building a .NET Core application in a docker container would be a potentially viable option for working around this issue? I've seen some issues with accepting the EULA when building a docker container specifically with body tracking, so I have steered away from this so far. That said, I am curious if anyone has gotten this to work. If so, it would be great to document this somewhere as it is great for folks looking to use the C# Wrapper.

Added in v1.1.2


Various enhancements

Three enhancements I've made to the project that don't belong in my GSS tree.  The most important, in my opinion, is the top commit which clarifies how to write tests with the current setup.

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   65.09%   65.09%
=======================================
  Files          13       13
  Lines        1166     1166
=======================================
  Hits          759      759
  Misses        407      407

Impacted Files
Coverage Δ

tests/run.c
84.7% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8046d64...9a93b1d. Read the comment docs.

@npmccallum CI passed (except rawhide, which is having GPG issues).  Ready for review, thanks.


fix/update all fields when updating subscriber email address

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           7      7
  Lines          80     81    +1
=====================================
+ Hits           80     81    +1

Impacted Files
Coverage Δ

lib/ex_campaign_monitor/subscribers.ex
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dffe36...d58c4dc. Read the comment docs.


Add tests for nested array slices

It turns out that nested array slices were broken, i.e. using them
returned the wrong results.
This was reported in https://github.com/Raku/old-issue-tracker/issues/6233
During lizmat++ work to improve array slices it also turned out
that there were no tests in roast for the above reported issue.
This PR rectifies this omission.

Thanks.  But this doesn't test :delete, :exists and combination thereof with :kv, :p, :k and :v and their negations.  :-)   It's quite a few tests that would need to be added, perhaps a more programmatic approach would be better to get all the combinations tested?


Fix: enum serialization

Fixes https://github.com/microsoft/kiota-typescript/issues/1276

Thanks for the contribution! In the issue you were mentioning that you're having issue implementing a unit test. Can you please also include the draft unit test in this pull request?

Hey @baywet
I was debugging existing test and wanted to update its assertion (to remove spread operator)
line 1104 WritesConstructorWithEnumValueAsync in CodeFunctionWriterTests.cs
But seems like we pass enum but it's not recognized as one

@Kindest13 I've just pushed an example unit test. I think the changes are getting us to the right direction but are not enough yet.
There are effectively 3 different enum cases:

single value => we already have what we need in place end to end.
flaggable => I think this is why we originally introduced the spread operator. What I don't know is how anybody would set those properties/if we need to correct the generation for those kinds of properties. I think we'd need to default to an array which will be serialized as CSV since there's no flag or enum set notion in TypeScript
collection of enum values => here we're most likely missing a method in the kiota-typescript SerializationWriter and ParseNode interfaces. If you want you can go ahead and start a pull request over there as well.

Regardless, all methods need to ALSO accept the serialization object so we can map enum members to their serialization representations, which is not implemented today.
Let us know if you have any additional comments or questions.
I'd also like @andrueastman opinion on this one.

flaggable => I think this is why we originally introduced the spread operator. What I don't know is how anybody would set those properties/if we need to correct the generation for those kinds of properties. I think we'd need to default to an array which will be serialized as CSV since there's no flag or enum set notion in TypeScript

I think this also what we were trying to solve with the x-ms-enums-flags extension  with the idea of having also specify the serialization format.
This way a language like TS could specify the enum in both case 2 and 3 as a collection of enum values then the serializer would do the job knowing what to write (csv string or collection of strings) using the type specified.
I agree with making the property default as a collection for now. That requires us to pass extra information to the serializer to differentiate the case 2 and 3. But that is solved with the separate methods for now (once we add the method for collection of enum values).
Similar to GO we could also generate the string conversion function for the enum but that would lead to a bigger footprint in generation.

Thank you for the additional information @andrueastman
The extension itself is for future work, and likely a source breaking change to coordinate across all languages.
If we focused on "this version of the generation across all languages" I believe we could "align" TypeScript with the changes I've described in my previous reply. Anything I might have missed? Or issues? In your opinion.

gentle reminder on the last question @andrueastman

@baywet Do we still deciding on the approach?

Thank you for your patience, I'll try to recap the situation the best I can so the next steps are clear.
Here is what I believe we should have at the generation level:

enum, single value => writeEnumValue, no spread operator
enum, array => probably missing a method in kiota typescript
enum, flaggable => writeEnumValue, spread operator (we had that, but this PR removes it)

At the serialization libraries level, during serialization:

enum, single value: writeEnumValue => this ultimately ends up doing string interpolation This should work since we're ultimately passing the constant at runtime, but we should validate this.
enum, array => I believe we're missing a method here
enum, flaggable: writeEnumValue with spread operator => should work today (assuming the first one works)

At the serialization libraries level, during deserialization:

enum, single value: getEnumValue => should work as is since we're passing the mapping object
enum, array: getEnumCollectionValue => supports my case about a method missing for serialization
enum, flaggable => I believe we're missing a method, or at least the implementation of the collection method should split strings.

With all that in mind, here is how I suggest we proceed:

Add missing methods in the serialization libraries, and test cases that demonstrate the different scenarios.
Update the generation to match the different cases based on the updated in the serialization library.

Let us know if you have any additional comments or questions. And thanks for the nudge here.

This looks good from my end @baywet.

enum, flaggable => I believe we're missing a method, or at least the implementation of the collection method should split strings.

I think for this one we can simply have the implementation split the strings first. Adding another method would probably have something like getCollectionOfFlaggedEnums which would give the notion that we would need something similar on the serializer side. Also, I'd argue this is okat as we would not expect collections of flagged enums so this would be only happening at the first layer/dimension.
In summary we should have something like this.

Enum - No Flags
Enum - With Flags
Enum Collection - No Flags
Enum Collection - With Flags

Serialization
writeEnumValue
writeEnumValue
writeCollectionOfEnumValue (TODO as @baywet highlighted)
N/A(case doesn't make sense more info here)

Deserialization
getEnumValue
getCollectionOfEnumValue (TODO update the implementation to split the node before getting underlying enums)
getCollectionOfEnumValue
N/A(case doesn't make sense more info here)

Thanks for chiming in @andrueastman
@Kindest13 do you want to start sending PRs on kiota typescript?
Let us know if you have any additional comments or questions.


The new highlight behaviour #185 is incorrect for popup menus

It should be optional. #185 only works correctly for dropdowns, and even then a lot of people would not want that for dropdowns either.

That's expected when using customButton.
If you want to have the highlight behavior, you shouldn't use customButton.
Also, you can customize/disable the highlight behavior for dropdowns using ButtonStyleData.overlayColor


Oh..what's this....

I just update version 0.4.3. there have a..um... extra rectangle bar with text "Material Theme - default"... what does this bar use for? And can I remove it?

I updated also show the status bar, I don't like it, I can remove or disabled it ?

Oh you didn't like it? :( okay I will make an option to disable it

after all there is a change theme button on toolbar, so theme state may be unnecessary I think....
another question is that I found there is a option in settings like [use customer wallpaper], what does this wallpaper use for? I haven't found anywhere used this wallpaper

Yeah but the toolbar doesn't show you which theme you are on (even though I know that the color should be enough, I thought it would be a nice decorator)
As for the wallpaper, this is the wallpaper set when there is no files opened.

Wow! it is so nice !!


feat(rust): allocate message handler trait on heap, run function on t…

…hread

@robinbudd the commit here https://github.com/ockam-network/ockam/pull/411/commits/807c8524dc2b47498fecdfe7d642d229235c9a57 has many more things changing than what is reflected in the commit message. Could you break this down into multiple commits to have the commit messages reflect the changes


Add rexchange.begun.ru used on livejournal.com

Hi Danil @sgtpep,
This repo is generative, meaning it combines several Hosts sources into a a variety of consolidated hosts file with duplicates removed.
So changing the generated file doesn't actually work since the next regeneration will lose the changes.
Three options:

Convince one of the host sources to carry the rexchange.begun.ru domain.  This is actually easy to do.

Create a new reliable data source that we can add to our list of sources.

Simply add rexchange.begun.ru to the myhosts file and use one of the Python scripts to generate your own personal file.

I appreciate the pull request, however.  Thank you.
Closing.