Indentation for tuples doesn't work

Enter this code:
(
    ()
)

Hit enter in the second parenthesis. It should end up with this:
(
    (
        // Cursor here
    )
)

I believe this is because the special case code for parenthesis here should be skipped if inside of a tuple:
https://github.com/microsoft/pyright/blob/5b6a1d3b73c34617414624baef50bd326b138e5b/packages/pyright-internal/src/languageService/indentationUtils.ts#L429

This issue has been fixed in prerelease version 2023.5.21, which we've just released. You can find the changelog here: CHANGELOG.md


Error logging in.

I am unable to get tmi.js to work. I keep getting the same error, "error logging in" despite of i've tested my oauth token on the older library, twitch-irc.
As you can see, i am able to use login with the same basic code with twitch-irc but not with the tmi.js
http://i.imgur.com/tWZNKD2.png
Is there anything i can do?

I remember some people having the same issue when switching to websockets and I don't know why to be honest. Most of them fixed this issue by resetting the oauth token. If it still doesn't work, I will leave your ticket open and do my best to investigate.

Yes I was one of them… Try resetting your twitch password first and then get a new oauth token. That seemed to have cleared it up for me.

thanks guys, it is really weird that resetting the token actually work...while the existing token worked for the older IRC protocol.

Agreed, I don't know why it works and how this can be related, but it works -.-


[MISC] Add database field in the provider-side databag

Just adding the database field in the provider side. This is to follow the interface signature change https://github.com/canonical/charm-relation-interfaces/pull/43

Thanks Enrico!


yarn add @salesforce/cli not working as expected

Summary
Trying to use yarn to add dependency @Salesforce/cli dependency, does not register the commands.
Steps To Reproduce:

Git clone this basic yarn repo: https://github.com/nhall97/salesforce-cli-pipeline
$yarn install
$sf help

Expected result
Expect output of help command from Salesforce
Actual result

$ bash: sf: command not found

System Information
Not possible - command not found
Additional information
Feel free to attach a screenshot.

@nhall97 npm and yarn don't install binaries globally whenever you do a local install.
If you want sf to be available globally, you should run npm install -g @salesforce/cli. Otherwise, you'll need to execute sf using yarn, e.g. yarn sf --help
~/salesforce-cli-pipeline [main] : yarn sf --help
yarn run v1.22.5
$ /Users/mdonnalley/salesforce-cli-pipeline/node_modules/.bin/sf --help
sf is in beta.

The Salesforce CLI

VERSION
  @salesforce/cli/0.0.38 darwin-x64 node-v14.15.4

USAGE
  $ sf [COMMAND]

TOPICS
  commandreference  generate the Salesforce CLI command reference guide.
  config            Commands to configure Salesforce CLI.
  deploy            Commands to deploy artifacts to an environment.
  env               Commands to manage your environments, such as orgs.
  login             Commands to log in to an environment.
  logout            Commands to log out of an environment.
  plugins           list installed plugins
  retrieve          Commands to retrieve artifacts from an environment.

COMMANDS
  deploy   Deploy a project interactively to any Salesforce environment.
  help     display help for sf
  login    Log interactively into an environment, such as a Salesforce org.
  logout   Log out of all environments, such as Salesforce orgs and compute environments.
  plugins  list installed plugins


Stop token behavior changes when specifying list of stop tokens

What is the issue?
Setting a stop token of "k=1 was" for this call has no effect, as expected:
$ curl -s http://localhost:11434/api/chat -d '{
>               "model": "mistral","options": {"top_k":1,"stop":["k=1 was"]},
>               "stream": false,
>               "messages":[{"role":"user","content":"Top-k sampling with k=1 returns a definite answer."}]
>             }' | jq .message.content
" Yes, that's correct! Top-k sampling with k=1 is also known as \"taking the top element\" or \"greedy selection.\" It simply selects the highest value (or any other sortable attribute) from a dataset without replacement. Since it only returns one item, it guarantees a definite answer. This method is often used in various machine learning and data analysis applications where you want to focus on the most significant or representative element of your dataset."

Setting a top token of "1" also has the expected effect, of ending after k= in the (constant) output:
$ curl -s http://localhost:11434/api/chat -d '{
>               "model": "mistral","options": {"top_k":1,"stop":["1"]},
>               "stream": false,
>               "messages":[{"role":"user","content":"Top-k sampling with k=1 returns a definite answer."}]
>             }' | jq .message.content
" Yes, that's correct! Top-k sampling with k="

But combining the two results in the generated text ending before the k= tokens:
$ curl -s http://localhost:11434/api/chat -d '{
>               "model": "mistral","options": {"top_k":1,"stop":["k=1 was","1"]},
>               "stream": false,
>               "messages":[{"role":"user","content":"Top-k sampling with k=1 returns a definite answer."}]
>             }' | jq .message.content
" Yes, that's correct! Top-k sampling with"

OS
macOS
GPU
Apple
CPU
Apple
Ollama version
0.1.38, installed with Homebrew

Hi there, this should be fixed now. Thanks for the issue!


Compress payload during shuffle operation

For jobs which process a dataframes with a significant amount of payload columns, shuffle operations can be incredibly memory consuming. Especially due to the multi stage algorithm, multiple copies of the data are in fact intended. Due to the multi stage shuffle we also need to (de)serialize these columns many times. However, for the shuffle itself these columns are effectively dead weight.
This change proposes to serialize (and more importantly compress) the payload columns during the shuffle operation which allows for a significant reduction in memory usage. Not only is the memory usage reduced (less spill to disk), but this also reduces the amount of IO (disk or network depending on the shuffle mode) and the overhead of (de)serializing "garbage". We've seen significant speed ups in runtime when testing this; even with reduced cluster sizes (I don't have proper benchmarks prepared yet but can follow up with some, if desired).
This is not ready to merge since it still fails for multiple environments (especially older pandas versions; The py3.8 job is successful with the exception of a failed doctest) and I will address these build failures if we are willing to accept this contribution.
To compress and serialize the payload, I'm using the distributed.protocol assuming that it is stable, fast, handles compression on the fly and allows for customization if desired (e.g. to use different serializers, arrow/parquet come to my mind but I haven't tested this lately). If there are other options for this format, I'm open for suggestions since atm this would obviously only work if distributed is installed.
The code itself is a bit messier than I would like to. I needed to use the DataFrameGroupy.apply which has the obvious downsides of being slow. I would argue, however, that this slowdown is acceptable, weighing in the performance gains I expect from this change.
On top of this, I observe funny/unstable behaviour of this function (It improves with more recent pandas versions but I consider it still unstable).
If somebody has a suggestion how to express this logic without using apply, I'd appreciate the input.
Thanks @crepererum for this cool idea
For completeness and transparency, we're building this currently into kartothek where we need to deal with fewer edge cases (see https://github.com/JDASoftwareGroup/kartothek/pull/286 ) but we would obviously prefer this to be part of dask itself.

Haven't looked closely yet, but I believe that the rapids folks (@rjzamora and @madsbk, maybe others) have been looking closely at this area too.

cc @jakirkham

@fjetter thank you very much for integrating and polishing my rough idea. It's really good to see it swimming upstream and also how small the actual code change it :+1:
Please note that a similar optimization could be done for the tasks-based Bag.groupby. This can (and should) probably be done in a separate PR, so we can first discuss and decide here if the approach makes sense.
Also as a side note on shuffling: This can of course be improved / tuned further. Shuffling (both for the DF and for the Bag) are basically a (distributed) shuffle with two components K (the key) and V (the passive payload, sometimes K needs to calculated from V or is a part of the payload, but let's keep it simple for now). At the beginning, we start with elements Iterable[Tuple[K, V]] we want to end with Dict[K, Pack[V] (Pack can be a Bag partition, or a concatenated DF, or just a list/iterable; and Dict here is more an iterable where K is unique, but you get the idea). Basically, V is "dead weight" and does not need to be touched during the shuffle. This can be exploited in multiple ways (non-exhaustive list):

cheap (de-)serialize: do not pickle/unpickle, compress/decompress, ... V while in-flight, but use a format that is cheap to move around (bytes for example).
(stronger) compression: since the task is heavily IO-bound, it can makes sense to apply a more expensive but stronger (in terms of ratio) compression before feeding the data through the shuffle network (that's what @fjetter also illustrates in the idea to use Parquet).
out-of-band transmission: in certain extreme scenarios, it can even be helpful to move V out of the cluster (e.g. to disk or to an external storage system like S3 or ABS), because it can be faster to do this pre-shuffle transmission and post-shuffle retrieval (1 send, 1 retrieve, both more expensive then a worker-to-worker transmission) instead of moving the data through the network many times.

The PR implements (1) and (2) for DFs. (3) (or any further options) are out of scope here but interested parties might try it out.

FWIW @fjetter Pandas serialization hasn't been particularly efficient historically ( https://github.com/dask/distributed/issues/614 ). PR ( https://github.com/dask/distributed/pull/3784 ) changed that in 2.17.0 as it now handles out-of-band serialization when pickling (if supported), which works on Pandas objects. I haven't looked into compression in that case, but suspect it may be happening as well. Maybe worth updating to the latest version and exploring workloads if you haven't already. Would be good to have an update on issue ( https://github.com/dask/distributed/issues/614 ) with anything you find. 🙂

@jakirkham Yes, I am aware of your work and am very excited to test this. Unfortunately, we're still stuck on py3.6 for a while which makes it hard to test this at the moment since pickle5 is not supported. Once I get the opportunity to properly test this, I'll leave a note in the ticket.

I haven't looked into compression in that case, but suspect it may be happening as well.

Yes, distributed automatically compresses the frames if it yields favourable compression rates, see https://github.com/dask/distributed/blob/1fe50c24792d74643772268c188decd3c1ab76ee/distributed/protocol/compression.py#L160 This is what I effectively use here as well.

Irrelevant of the performance of the serialization, I believe this PR makes a big difference, assuming the shuffled dataframe has a significant amount of payload data since this PR proposes to (de-)serialize and compress this payload data only once instead of doing it on every submission.
Additionally, the current staged implementation intentionally holds multiple copies of the data on the cluster which is much cheaper if the payload is compressed. This has a significant impact on the memory usage (I'll try to prepare a few measurements to support this claim). So just to make the point very clear, this PR is more concerned with memory compression. The serialisation performance (by doing less) is just the cherry on top imo.
Another note to the argument @crepererum mad above about the K, V split: I currently store the V in the dataframe itself which might not be the most performant solution but it is rather elegant since we don not need to touch much. That could be obviously refined at a later stage since even point 1 and 2 can probably be expressed more efficiently with a more specialized implementation.

Yet another benefit of this approach I want to mention since it falls a bit through the cracks if not looked into closely.
The pack_payload column performs a groupby.apply which effectively eliminates a certain redundancy in the data by reducing the number of rows to the essential, yet again benefiting IO, serialization and memory
Example
In [2]: import pandas as pd
   ...: import dask.dataframe as dd
   ...: from dask.dataframe.shuffle import pack_payload
   ...:
   ...: df = pd.DataFrame({"A": [1, 1] * 2 + [2, 2] * 2 + [3, 3] * 2, "B": range(12)})
   ...: ddf = dd.from_pandas(df, npartitions=2)

In [3]: ddf.partitions[0].compute()
Out[3]:
   A  B
0  1  0
1  1  1
2  1  2
3  1  3
4  2  4
5  2  5

In [4]: pack_payload(ddf, "A").partitions[0].compute()
Out[4]:
   A                               __dask_payload_bytes
0  1  b'\x03\x00\x00\x00\x00\x00\x00\x00)\x00\x00\x0...
1  2  b'\x03\x00\x00\x00\x00\x00\x00\x00)\x00\x00\x0...

No worries. We are looking at the long tail as well ( https://github.com/dask/distributed/issues/2495 ) 🙂

Should add there are similarities to this and @madsbk's PR ( https://github.com/dask/distributed/pull/3624 ) to transmit serialized data. @mrocklin pointed out in that PR that we might benefit from having a MutableMapping that for spilling, which would contain spilled, compressed, in-memory data ( https://github.com/dask/distributed/issues/3656 ). We could then leverage this to transmit this compressed data between workers. Certainly useful for shuffling. Though probably useful for other things as well.

The auto compression MutableMapping would also be interesting but we'd be faced with the problem of having the payload and the group keys be compressed into the same byte string, i.e. every time I want to work with the data I'd have to decompress everything although I'm only interested in the group key. However, with a mutable mapping like this, one could think about splitting the payload and group key into two tasks/data objects... that would probably fit nicely with the idea of #6164

While I was not, yet, able to perform proper benchmarks, what I could observer already is that this general approach presented here will not work since the groupby.apply is too granular and for some data constellations causes major performance issues. In a nutshell, grouping on the group key directly creates too many groups and the apply + compression is too slow and in some edge cases even uses up more memory. This implementation would need to group on the final partition ID (I know the _partition column was recently removed for a lot of shuffle operations) instead since there are much fewer groups... I will try to produce a few numbers to make my point

Closing this since obviously stale and I currently don't have time to update. The idea is still valid if somebody wants to pick this up


model vs teacher/student_model in yaml

Hello,
I was able to reproduce your code with minor adjustments but I'm reporting the error in the current version.
Also, if you could answer some questions that would be great

Is the mimic_runner.py the trainer for distillation training? Could you provide an example?
What is the ext_runner script for?

Bug
input:
pipenv run python src/coco_runner.py --config config/hnd/faster_rcnn-backbone_resnet50-b3ch.yaml

output:
...
Creating model
Traceback (most recent call last):
  File "src/coco_runner.py", line 135, in <module>
    main(parser.parse_args())
  File "src/coco_runner.py", line 117, in main
    model_config = config['model']
KeyError: 'model'

Hello @jsiloto
Thank you for your interest in our work!
src/coco_runner.py is for training original models (from torchvision) and designed to work with config files under config/org/, so it's not a bug.
To use HND and GHND approaches, you'll need run src/mimic_runner.py with a config file under config/hnd/ and config/ghnd/.
src/ext_runner.py is for training and testing a neural filter, designed to filter out images without any objects of interest at mobile device (and terminate the inference before offloading in practice) for reducing inference time. We applied the neural filter to our bottleneck-injected Keypoint R-CNN model.
For details, please refer to Section 5 in the paper (Note the arXiv version will be updated tomorrow).
I will update README with more example commands as soon as possible.

Hello!
Things are clearer now. Thanks for such a speedy response, and kudos for the code, it looks very well written overall.

Glad to hear that! I just updated README to resolve your concerns.
Hope our code and camera-ready paper (the updated one will be available on arXiv tomorrow) help your work.


issue with acc loop gang

SUBROUTINE TOTO(A,B)
IMPLICIT NONE
REAL, INTENT(IN) :: A
REAL, INTENT(INOUT) :: B
!$ACC PARALLEL LOOP GANG &
!$ACC&PRESENT(ZRDG_LCVQ,ZFLU_QSATS,ZRDG_CVGQ) &
!$ACC&PRIVATE (JBLK) &
!$ACC&VECTOR_LENGTH (YDCPG_OPTS%KLON)
END SUBROUTINE TOTO
from loki import *
path="sub.F90"
file=Sourcefile.from_file(path)
routine=file["TOTO"]
print(fgen(routine))
loki removes the "&" after !$ACC PARALLEL LOOP GANG statement.

Hi @ecossevin I can confirm that this is indeed an issue (and wrong). The problem seem to be that the lack of whitespaces in the second pragma line !$ACC& ... seems to defeat the pragma parsers and doesn't register as part of the pragma (!$ACC & ... works). I'll investigate further and hopefully find a fix.


Helm chart command to create ingress controller fails in new AKS internal cluster

The helm chart command results in the following error on a new internal AKS cluster:
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: IngressClass "nginx" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "nginx-ingress-devices"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "ingress-basic"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bf9c2f3-caeb-0fb1-f089-3f7ca4fad729
Version Independent ID: 929253d7-c763-6429-561f-529d39b5284d
Content: Ingress controller on internal network - Azure Kubernetes Service
Content Source: articles/aks/ingress-internal-ip.md
Service: container-service
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

Fixed it by adding --set controller.ingressClassResource.name=nginx2
Looks like they dont want people using nginx as the type anymore, you'll need to update the doc accordingly

@wcom939 Thank you for your feedback! We will review and update as appropriate.

@wcom939 Thanks for sharing the update. I was able to find the explanation behind this error posted by my colleague here : https://github.com/MicrosoftDocs/azure-docs/issues/81858#issuecomment-934244357
It states -
If you run helm install ingress-nginx-new ingress-nginx/ingress-nginx --namespace ingress-basic-new --set controller.ingressClass="nginx-devices" --debug you shall see cluster-scoped resources like Clusterroles and/or Clusterrolebindings which already exist from your earlier NGINX Ingress installation are attempted to be created (not replaced or patched). This is because, by default, rbac.create is set to true [[Reference](https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-helm/)]. In order to avoid this please ensure that the installation does not try to create cluster-scoped resources again. If nginx ingress Clusterroles and/or Clusterrolebindings already exist then for subsequent installations you can pass the argument --set rbac.create=false with the helm install command(s).
Let me know if that helps. Thanks.

Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Add ignore_timestamps_errors argument to OpenEphysRawIO

fixes #1210

Hi @JuliaSprenger
Is it ok if we relax the assertion to a warning in this case? See https://github.com/NeuralEnsemble/python-neo/issues/1210
I can change the failing test accordingly.

Hi @alejoe91 I think a warning might be too relaxed in this case as even for significant pauses this might be missed by the user. What the deviation of timestamps you observed in the test files provided by @ThePuppetShow? Maybe we can make a reasonable estimate of what deviations are acceptable and should only raise a warning?

If I remember correctly, there were a bunch of zeros at the beginning of the timestamps file, but we might need to double check.
On the other hand, the assertion would completely prevent from loading the data in case something is wrong with timestamps. I think that the API should allow to at least load the data, even just to check what is wrong and maybe cut out "good" portions of the recording. No?

Hey, and thanks a lot for looking into this
I got this issue in some but not all my recordings. To my knowledge none of the recordings should not have started with any pauses, so I'm not sure why sometimes the timestamps were not directly from 0. Maybe a lag of sorts?
In one of these sessions the first timestamp was at 1.536 s. I made some plots here https://github.com/NeuralEnsemble/python-neo/issues/1210
Would it be possible to at least allow for the data to be accessed, but give a warning?  Or just automatically scale it if it starts with a slight delay?
Again, thanks a lot for taking the time to look into this : )
Best
J

Hi @alejoe91 I would argue that small deviations could pass with just a warning, but for bigger deviations an error should be raised. For debugging purposes I would propose to add a keyword to the IO that permits to ignore that error and still return the data (with wrong timestamps). This way the user would need to actively decide to load incorrect timestamps and it is not happening silently.

That's fair! :) Something like ignore_timestamps_errors?

@JuliaSprenger should be done

Failing tests are due to #1227 and not related to this PR.


Add Theme

Fix https://github.com/tapaswenipathak/Research-Paper-Publications/issues/11

Addition of theme. Theme repo has got committed as a submodule


Support changing timezone in notification message

 Issue by joyyir
Monday Oct 26, 2020 at 05:07 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/285

Notification message format can be specified using Mustache templates like below.
- Period start: {{ctx.periodStart}}
- Period end: {{ctx.periodEnd}}

Actual message looks like this. It uses UTC+0 time.
- Period start: 2020-10-24T10:56:43.738Z
- Period end: 2020-10-24T10:57:43.738Z

It is possible to misunderstand actual time because the most people live in different timezone.
So I think it will be good if changing timezone is possible.
Thank you.

 Comment by marshell0
Wednesday May 26, 2021 at 09:00 GMT

TriggerExecutionContext.kt
in constructor
change:
monitorRunResult.periodStart
monitorRunResult.periodEnd
to:
monitorRunResult.periodStart.atZone(ZoneId.systemDefault()).toLocalDateTime().toInstant(ZoneOffset.UTC),
monitorRunResult.periodEnd.atZone(ZoneId.systemDefault()).toLocalDateTime().toInstant(ZoneOffset.UTC),
resolve your problem

Hello,
Curious if this was ever resolved. Seams Like I have the same issue.


help wanted

please share ddl also

DDL of what?

Ddl
On Sat, Aug 10, 2024, 5:01 PM SAHIL ALI @.***> wrote:

DDL of what?
—
Reply to this email directly, view it on GitHub
https://github.com/AlixSahil/Oracle-Apex/issues/1#issuecomment-2281328791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWGNLKAM72EKJBI77PIT3NDZQX6LFAVCNFSM6AAAAABMJYGDBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBRGMZDQNZZGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


update  aapt  support  custom attr and  shared Resource

update aapt  support  custom attrs and shared resource

waiting for android M release

testing

done


POST /eth/v1/beacon/blocks for altair

Given the discussion is leaning towards a POST that takes no indicators for which fork the block is, it would be simple to extend the existing POST to also accept altair blocks.
This PR demonstrates the concept for discussion, as an alternative to #141

Using this approach we could remove all other v2 methods right?

/eth/v2/debug/beacon/states/{state_id}: fork can be obtained from the JSON payload at state.slot
/eth/v2/validator/blocks/:slot: same as this PR

Using this approach we could remove all other v2 methods right?

/eth/v2/debug/beacon/states/{state_id}: fork can be obtained from the JSON payload at state.slot. Also the binary version of this route does not include the fork version anyway. Even getting an SSZ serialized payload you can still read the slot only then deserialize.
/eth/v2/validator/blocks/:slot: same as this PR

I was implementing a remote validator create unsigned block yesterday, and it actually was easier in that instance to know it was an altair block, because otherwise the deserializer needed to be aware of the spec, so in that instance the v2 was actually helpful.
I guess the thing with the POST here, is that the old request payload is 100% valid, we're just allowing a new payload to be sent as an alternative.  In a GET, we'd be returning a different structure to the client, and that's a bigger problem in a way - which is why REST apis generally don't make incompatible changes on a http response.


Refactoring ValidatorBase

    public static bool TryGetNonEmptyValue<TKey>(this Dictionary<TKey, FlexMatch> dictionary, TKey key, out FlexMatch value)

Are you sure you require these helpers now? Trying removing them. i.e., any Dictionary instance should resolve to the IDictionary helpers below, I believe.

Refers to: Src/Plugins/Security/Utilities/DictionaryExtensions.cs:12 in 3b14c3c. [](commit_id = 3b14c3c71bd80e6067ec75be3793f0fef620ea11, deletion_comment = False)


Clarify recommended coding conventions for new SS3 modules/projects

Our SS3 coding conventions aren't really a good recommendation anymore for new SS3 modules, as with SS4 we're moving to PSR-1/2 (and probably PSR-4).
I think we need to update https://docs.silverstripe.org/en/3/getting_started/coding_conventions with a link to a page clarifying what  developers of new SS3-based modules and projects should do.
In particular, I think we recommend PSR-1/2 with the following exclusions:

Namespaces are optional, not mandatory, as some parts of SS3 (such as LeftAndMain subclassess and DataObjects) are an awkward fit for SS3, and most of the SS3 code isn't namespaced anyway.
Class and method names don't need to follow upper- and lower-camel case, respectively. A lot of method-name conventions make this impossible.

However, all the other PSR-1/2 conventions should be followed.
We should provide a ruleset.xml file for phpcs.

and/or maybe .php_cs as well?

Note that https://docs.silverstripe.org/en/master/getting_started/coding_conventions has already been rewritten for PSR-1/2

phpcs.xml.dist file with formatting tweaks available in the installer PR silverstripe/silverstripe-installer#174 - there's a couple of questions on that PR that we should consider for this.
Once everything is decided I'll make a PR here for the docs, then we can discuss whether to lint the supported modules with this standard.

Unfortunately, Silverstripe CMS 3 has entered limited support in June 2018. This means we'll only be fixing critical bugs and security issues for Silverstripe CMS 3 going forward.
You can read the Silverstripe CMS Roadmap for more information on our support commitments.


Login before redirect to page content

I want to require the user login before redirect to page content. So how can I set the login first in route, because in route you used the array of route. I cannot manage this router. Please show me the solutions

I am not sure that I understand your question entirely, however, in src/routes.js there is IsAuthenticated function that verifies the user is logged in.
Then you simply wrap the component for the routed with that function.
See const routes definition in the same file.

Oh sorry, I will explain more:
I don't want to show the header or footer or everything in the login page, I mean when redirect to login page, just show the login form. It's a reason why I make a login page independent with the App.
But I have problems:  when I wrap the App with the IsAuthenticated, It's alway has one of the two cases:

It's alway show the login when refresh page if I put the /login route before App
{
path: '/login',
component: Login
},
{
component: IsAuthenticated(App),
routes: [
{ path: '/', exact: true, component: Home },
{ path: '/register', component: Register },
{ component: NotFound }
],
},
It's cannot find the /login if I put login after App
{
component: IsAuthenticated(App),
routes: [
{ path: '/', exact: true, component: Home },
{ path: '/register', component: Register },
{ component: NotFound }
],
},
{
path: '/login',
component: Login
}

@synchu @bertho-zero  Please help me


Adding number guessing game js

Added a Number Guessing Game project made using HTML, CSS and JS for hacktoberfest

Dear Contributor,
Kindly Start ⭐ this repo. After that only your PRs will be accepted. Don't avoid it.
Thank You.


fix(obstacle_avoidance_planner): add guard for too large yaw deviation (backport #2579)

Description
https://github.com/autowarefoundation/autoware.universe/pull/2579 のbackport
debug_dataだとビルドエラーが発生したためdebug_data_ptrに書き換えている箇所あり
Related Links
TIER IV INTERNAL LINK: https://tier4.atlassian.net/browse/T4PB-23301
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

LGTM


BlockSnapshot creator is always empty

Whenever using the getCreator method on a BlockSnapshot, the creator always not present, even if I just placed the block. The BlockSnapshot was retrieved from a transaction from the ChangeBlockEvent.Break. This was tested on SpongeForge build 1655.

@Flibio Can you re-test on latest versions of SF? I'm having some difficulty not getting creator/notifier for block snapshots created for events.

@gabizou: I've retested on the SpongeForge 1686 using a brand new server, but the issue still occurs. The steps taken:

Joined the brand new server
/op Flibio
/gamemode creative
Placed a stone block
Destroyed the stone block
The below code outputted empty Optionals

Here is the code (the only plugin on the server):
@Plugin(id = "test", name = "Test", version = "1.0.0", description = "Test")
public class Main {

    @Listener
    public void onBreak(ChangeBlockEvent.Break event, @First Player player) {
        for (Transaction<BlockSnapshot> transaction : event.getTransactions()) {
            System.out.println("O:" + transaction.getOriginal().getCreator());
            System.out.println("F:" + transaction.getFinal().getCreator());
        }
    }
}

Cannot reproduce in the latest builds.


100% coverage reached and minor fixes

Codecov Report

Merging #3 into feature/dynamic-titles will increase coverage by 9.12%.
The diff coverage is 100.00%.

@@                     Coverage Diff                     @@
##           feature/dynamic-titles        #3      +/-   ##
===========================================================
+ Coverage                   90.87%   100.00%   +9.12%
===========================================================
  Files                           5         7       +2
  Lines                         526       432      -94
===========================================================
- Hits                          478       432      -46
+ Misses                         48         0      -48

Impacted Files
Coverage Δ

conftest.py
100.00% <100.00%> (ø)

i3_workspace_names_daemon.py
100.00% <100.00%> (+25.39%)
:arrow_up:

test_main.py
100.00% <100.00%> (ø)

test_rename.py
100.00% <100.00%> (ø)

test_validate_config.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190169f...1ff301e. Read the comment docs.

@bastidest is this ok?

Wow, excellent work @CastixGitHub . Sorry I did not receive a notification for this PR (as I probably was not tagged).
I just tested it and it works very well. Nice coverage :1st_place_medal:


add codecov badge

What this PR does:
add codecov badge
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #102 (566267f) into main (9c2ad8d) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   39.95%   39.71%   -0.25%
==========================================
  Files          36       36
  Lines        1244     1244
==========================================
- Hits          497      494       -3
- Misses        706      709       +3
  Partials       41       41

Impacted Files
Coverage Δ

.../filter/network/tcpcopy/persistence/persistence.go
62.31% <0.00%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2ad8d...566267f. Read the comment docs.


Resource additions for standalone k8s-nmstate. (#657)

NMState CR.
Add spec.updateStrategy.registryPoll.interval to
CatalogSource.
(Needed for installing standalone k8s-nmstate).

Short description: Need to backport this to 4.10, this would enable us to interact with standalone nmstate
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

Can #661 be closed?

Yes, I think so. Sorry, I did not notice it was open already, and I used this one to test my changes.

!verified


HBASE-25631 Non-daemon threads make regionserver cannot exit completely

Please see more details at HBASE-25631

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.


Adds faceted search

This PR add faceted (filtered) search for packages.
At the same time it changes the layout of the results, from table to ordered list. While the design is not final, the structure of the result items should give hint how this is going to be styled with https://github.com/nixos/nixos-common-styles.
A lot of inspiration was taken from github's search -> https://github.com/search
Fixes #163  #261 #95 #201

@garbas let me know if I can (once I can) help with anything.

I need to fix the query a bit but then I would really welcome the help how to make faceted search easier to use. I need to do a bit of a research in this area.

@garbas let me know if I can (once I can) help with anything.

I need to fix the query a bit but then I would really welcome the help how to make faceted search easier to use. I need to do a bit of a research in this area.

Can we have a description to the PR explaining what is the intent behind the change? So we can validate it works as intended? :)

Can we have a description to the PR explaining what is the intent behind the change? So we can validate it works as intended? :)

Can we have a description to the PR explaining what is the intent behind the change? So we can validate it works as intended? :)

Oh sorry, I thought I opened a draft. Anyway add the description now.

Can we have a description to the PR explaining what is the intent behind the change? So we can validate it works as intended? :)

Oh sorry, I thought I opened a draft. Anyway add the description now.

@samueldr @turboMaCk This is now ready for review.

@samueldr @turboMaCk This is now ready for review.

Changing the Sort criteria affects the URL, but does not change it in the combo box, and does not seem to affect the results. Though, refreshing with the URL affected seems to work. Looks like something isn't causing the refresh of the results to be sent.

[ ] (check when fixed)

The clickable area for a result is... odd...

In green is the clickable area.
Suggestions:

On hover add a background to the whole li.option to make it more obvious it is clickable
Change from margin-bottom: 2em to padding-top: 2em. (You may need to adjust the listing top and bottom margin.)

[ ] (check when fixed)

Platforms listing isn't filtered to useful platforms anymore.
This makes for useless verbosity:

The current search filters platforms for those that are... pragmatically useful? At least those with binary cache coverage.

[ ] (check when fixed)

Package metadata is hard to understand. I guess that it is attribute name, version, for the first elements, then the license, homepage and source links are oddly not link-like.
Two main issues, first is there is no labeling on what the thing is, then there is no way to know that a thing is a link without hovering.
Sadly, I don't really know how to better solve it for being useful at a glance. The table-like layout used previously really is the pragmatic approach, it is hard to misunderstand.

[ ] (check when fixed)

Changing the Sort criteria affects the URL, but does not change it in the combo box, and does not seem to affect the results. Though, refreshing with the URL affected seems to work. Looks like something isn't causing the refresh of the results to be sent.

[ ] (check when fixed)

The clickable area for a result is... odd...

In green is the clickable area.
Suggestions:

On hover add a background to the whole li.option to make it more obvious it is clickable
Change from margin-bottom: 2em to padding-top: 2em. (You may need to adjust the listing top and bottom margin.)

[ ] (check when fixed)

Platforms listing isn't filtered to useful platforms anymore.
This makes for useless verbosity:

The current search filters platforms for those that are... pragmatically useful? At least those with binary cache coverage.

[ ] (check when fixed)

Package metadata is hard to understand. I guess that it is attribute name, version, for the first elements, then the license, homepage and source links are oddly not link-like.
Two main issues, first is there is no labeling on what the thing is, then there is no way to know that a thing is a link without hovering.
Sadly, I don't really know how to better solve it for being useful at a glance. The table-like layout used previously really is the pragmatic approach, it is hard to misunderstand.

[ ] (check when fixed)

The clickable area for a result is... odd...

In green is the clickable area.
Suggestions:

On hover add a background to the whole li.option to make it more obvious it is clickable
Change from margin-bottom: 2em to padding-top: 2em. (You may need to adjust the listing top and bottom margin.)

[ ] (check when fixed)

The clickable area for a result is... odd...

In green is the clickable area.
Suggestions:

On hover add a background to the whole li.option to make it more obvious it is clickable
Change from margin-bottom: 2em to padding-top: 2em. (You may need to adjust the listing top and bottom margin.)

[ ] (check when fixed)

Platforms listing isn't filtered to useful platforms anymore.
This makes for useless verbosity:

The current search filters platforms for those that are... pragmatically useful? At least those with binary cache coverage.

[ ] (check when fixed)

Platforms listing isn't filtered to useful platforms anymore.
This makes for useless verbosity:

The current search filters platforms for those that are... pragmatically useful? At least those with binary cache coverage.

[ ] (check when fixed)

Package metadata is hard to understand. I guess that it is attribute name, version, for the first elements, then the license, homepage and source links are oddly not link-like.
Two main issues, first is there is no labeling on what the thing is, then there is no way to know that a thing is a link without hovering.
Sadly, I don't really know how to better solve it for being useful at a glance. The table-like layout used previously really is the pragmatic approach, it is hard to misunderstand.

[ ] (check when fixed)

Package metadata is hard to understand. I guess that it is attribute name, version, for the first elements, then the license, homepage and source links are oddly not link-like.
Two main issues, first is there is no labeling on what the thing is, then there is no way to know that a thing is a link without hovering.
Sadly, I don't really know how to better solve it for being useful at a glance. The table-like layout used previously really is the pragmatic approach, it is hard to misunderstand.

[ ] (check when fixed)

I assume all narrow-viewport issues are to be looked at with the redesign. It's hard to fix all of this in a narrow layout.
Though, if not prohibitively expensive, it would be nice to have the side bar (with the facets) somehow be a togglable thing when narrow.
(No actual need to fix before merging, but something to keep in mind.)

I assume all narrow-viewport issues are to be looked at with the redesign. It's hard to fix all of this in a narrow layout.
Though, if not prohibitively expensive, it would be nice to have the side bar (with the facets) somehow be a togglable thing when narrow.
(No actual need to fix before merging, but something to keep in mind.)

Having an item opened at the bottom of the page, then changing facets scrolls to the opened item.
I guess that comes from the handling of navigation to a deep URL. I don't know how easy this is going to be to fix. To reproduce:

https://5ffc4a201e18091ff840ec31--nixos-search.netlify.app/packages?channel=unstable&show=rPackages.pcaBootPlot&from=0&size=50&buckets={"package_attr_set"%3A["rPackages"%2C"haskellPackages"]%2C"package_license_set"%3A[]%2C"package_maintainers_set"%3A[]%2C"package_platforms"%3A[]}&sort=relevance&query=boot

Change facets on the left.

[ ] (check when fixed)

Having an item opened at the bottom of the page, then changing facets scrolls to the opened item.
I guess that comes from the handling of navigation to a deep URL. I don't know how easy this is going to be to fix. To reproduce:

https://5ffc4a201e18091ff840ec31--nixos-search.netlify.app/packages?channel=unstable&show=rPackages.pcaBootPlot&from=0&size=50&buckets={"package_attr_set"%3A["rPackages"%2C"haskellPackages"]%2C"package_license_set"%3A[]%2C"package_maintainers_set"%3A[]%2C"package_platforms"%3A[]}&sort=relevance&query=boot

Change facets on the left.

[ ] (check when fixed)

It is basically impossible to select information in an opened item. This is because the selection click, on release, hides the item. Not useful to select those installation instructions!
I guess the solution is somewhat linked to the problematic activation area. It might be necessary to do like the current implementation, and only close when the always present "header" is clicked. To help users, a "useless" "× close" button could be added too.

[ ] (check when fixed)

It is basically impossible to select information in an opened item. This is because the selection click, on release, hides the item. Not useful to select those installation instructions!
I guess the solution is somewhat linked to the problematic activation area. It might be necessary to do like the current implementation, and only close when the always present "header" is clicked. To help users, a "useless" "× close" button could be added too.

[ ] (check when fixed)

Don't let this shower of papercuts discourage you. In reality these are good steps towards improvement.

Don't let this shower of papercuts discourage you. In reality these are good steps towards improvement.

@samueldr Thank you a ton! I really appreciate the deep review. I'll try to address reported issues today or tomorrow. Thank you again.

@samueldr Thank you a ton! I really appreciate the deep review. I'll try to address reported issues today or tomorrow. Thank you again.

First I went through @samueldr's comments so I don't repeat what he said. Just quickly.

[ ] Changing the Sort criteria doesn't work - reproduced [high]
[ ] The clickable area for a result is... odd... (non intuitive) - reproduced [low]
[ ] Platforms listing in a result isn't filtered to useful platforms anymore. - wasn't able to reproduce [unknown]
[ ] Package metadata is hard to understand. - disagree, I think this is fine. [none]
[ ] I assume all narrow-viewport issues are to be looked at with the nixos-styles redesign - agree can waut [low]
[ ] Having an item opened at the bottom of the page, then changing facets scrolls to the opened item. - reproduced but will need some additional definition - worth doing in isolation (own PR) imo - [low]
[ ] It is basically impossible to select information in an opened item. This is because the selection click, on release, hides the item. Not useful to select those installation instructions! - reproduced - [high]

Additional Issues from my own testing:
No packages found usability
When no package is found the filters are not shown. This means that if I select combination that will result in 0 results I endup in "bricked like" state. Clicking Search btn again fixes this but it's really not obvious how to get out. Solution to this will require some thinking but I feel we should probably keep previous filters states during loading.

To reproduce:

search elm term
filter package set: elmPackages
filter maintainers: Lynn Dong

First I went through @samueldr's comments so I don't repeat what he said. Just quickly.

[ ] Changing the Sort criteria doesn't work - reproduced [high]
[ ] The clickable area for a result is... odd... (non intuitive) - reproduced [low]
[ ] Platforms listing in a result isn't filtered to useful platforms anymore. - wasn't able to reproduce [unknown]
[ ] Package metadata is hard to understand. - disagree, I think this is fine. [none]
[ ] I assume all narrow-viewport issues are to be looked at with the nixos-styles redesign - agree can waut [low]
[ ] Having an item opened at the bottom of the page, then changing facets scrolls to the opened item. - reproduced but will need some additional definition - worth doing in isolation (own PR) imo - [low]
[ ] It is basically impossible to select information in an opened item. This is because the selection click, on release, hides the item. Not useful to select those installation instructions! - reproduced - [high]

Additional Issues from my own testing:
No packages found usability
When no package is found the filters are not shown. This means that if I select combination that will result in 0 results I endup in "bricked like" state. Clicking Search btn again fixes this but it's really not obvious how to get out. Solution to this will require some thinking but I feel we should probably keep previous filters states during loading.

To reproduce:

search elm term
filter package set: elmPackages
filter maintainers: Lynn Dong

sorry. I pushed to this branch by mistake - now reset back to where this should be.

sorry. I pushed to this branch by mistake - now reset back to where this should be.

some improvements around clicks within result list. https://github.com/NixOS/nixos-search/pull/262

some improvements around clicks within result list. https://github.com/NixOS/nixos-search/pull/262

RE reported issue. I'm able to reproduce issue with long list of platforms. nginx package is one such example

RE reported issue. I'm able to reproduce issue with long list of platforms. nginx package is one such example

I fixed the issues, at least I think so.
@turboMaCk I haven't yet address any of the elm code style issues. We can do this after this PR is merged.

I fixed the issues, at least I think so.
@turboMaCk I haven't yet address any of the elm code style issues. We can do this after this PR is merged.

@garbas Don't worry these are mostly just notes. I don't want to block merge of this longer than absolutely necessary

@garbas Don't worry these are mostly just notes. I don't want to block merge of this longer than absolutely necessary

Just a tiny cleanup after myself - now only the button (with name) is clickable https://github.com/NixOS/nixos-search/pull/263

Just a tiny cleanup after myself - now only the button (with name) is clickable https://github.com/NixOS/nixos-search/pull/263

There is a regression in options search

The styles meant for "show more" button affects the display of code examples here. CSS selector as they're written now are quite hard to get right. It's not really clear what selector will match what. I think we should use more classes and less styling based on HTML structure.

There is a regression in options search

The styles meant for "show more" button affects the display of code examples here. CSS selector as they're written now are quite hard to get right. It's not really clear what selector will match what. I think we should use more classes and less styling based on HTML structure.

fix for the options displaying incorrectly... We will eventually need to refactor those css though. This was harder to fix than it suppose to be. We can do it as a part of redesign or later. https://github.com/NixOS/nixos-search/pull/264

fix for the options displaying incorrectly... We will eventually need to refactor those css though. This was harder to fix than it suppose to be. We can do it as a part of redesign or later. https://github.com/NixOS/nixos-search/pull/264

Also. Once these 2 PRs are merged it's approve :+1: from my side.

Also. Once these 2 PRs are merged it's approve :+1: from my side.

Before I would merge this I would like to make the mobile version of it a bit more mobile friendly. Kinda following the same ideas as on https://github.com/search
And regarding the keyboard navigation it works as good as github's search, at least as far as I can tell. But yes there is more links you need to tab over.

Before I would merge this I would like to make the mobile version of it a bit more mobile friendly. Kinda following the same ideas as on https://github.com/search
And regarding the keyboard navigation it works as good as github's search, at least as far as I can tell. But yes there is more links you need to tab over.

Another smaller CSS issue which we should preferably solve

Another smaller CSS issue which we should preferably solve

[ ] Another thing which we should add is also "No package set", "No platform", "No licences" and "No mainatainers"  option (this would partially solve https://github.com/NixOS/rfcs/pull/81)

[ ] Another things is we should handle platforms at the import and limit to only platforms we are interested in.

[ ] Another thing which we should add is also "No package set", "No platform", "No licences" and "No mainatainers"  option (this would partially solve https://github.com/NixOS/rfcs/pull/81)

[ ] Another things is we should handle platforms at the import and limit to only platforms we are interested in.

Platform support tiers:

https://github.com/NixOS/rfcs/pull/46

Platform support tiers:

https://github.com/NixOS/rfcs/pull/46

Off-by-one in "showing results" subtitle:
https://6004568634bcdafcc4b348ec--nixos-search.netlify.app/packages?channel=20.09&from=0&size=50&sort=relevance&query=fire

Showing results 0-50 of 164 packages.
Showing results 50-100 of 164 packages.
Showing results 100-150 of 164 packages.
Showing results 150-164 of 164 packages.

Should be:

Showing results 1-50 of 164 packages.
Showing results 51-100 of 164 packages.
Showing results 101-150 of 164 packages.
Showing results 151-164 of 164 packages.

Think about result 50, is it shown on the first and second page? no :)

Off-by-one in "showing results" subtitle:
https://6004568634bcdafcc4b348ec--nixos-search.netlify.app/packages?channel=20.09&from=0&size=50&sort=relevance&query=fire

Showing results 0-50 of 164 packages.
Showing results 50-100 of 164 packages.
Showing results 100-150 of 164 packages.
Showing results 150-164 of 164 packages.

Should be:

Showing results 1-50 of 164 packages.
Showing results 51-100 of 164 packages.
Showing results 101-150 of 164 packages.
Showing results 151-164 of 164 packages.

Think about result 50, is it shown on the first and second page? no :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/marketing-team-meeting-minutes-17-18-19/11092/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/marketing-team-meeting-minutes-17-18-19/11092/1

@hugolgst which browser is it?
This is how it looks for me in FF

@hugolgst which browser is it?
This is how it looks for me in FF

I'm using google-chrome in i3-wm (don't know if this has a role)

I'm using google-chrome in i3-wm (don't know if this has a role)

Another smaller CSS issue which we should preferably solve

This is now fixed

Another smaller CSS issue which we should preferably solve

This is now fixed

Here are my few comments:
* The search icon looks weird for me:
  ![](https://camo.githubusercontent.com/479c76aa4e57992e2fd5b2defbd19d17d3baa4f1bf2e51936630cdb890911e75/68747470733a2f2f692e696d6775722e636f6d2f6557456b4b75542e706e67)

I'm not sure how to do this better without importing additional font. I would leave this for now since I plan to work on redesign next. And there we will make sure this kind of things don't happen.

* I find it confusing that the "Show more detail" text is on the separator:
  ![](https://camo.githubusercontent.com/3ed093b1a385a0546fe4e64fc6d179663aed0503440148906861f30b6036b823/68747470733a2f2f692e696d6775722e636f6d2f3254466c6834432e706e67)

I also find it confusing. But I don't have better idea - at this point - how to solve it. As for the previous item I would table this until the redesign.

* Could be great to underline the items where you can click, otherwise, it won't be obvious:
  ![image](https://user-images.githubusercontent.com/15371828/105384436-80807100-5c12-11eb-8bda-1c6bbed4d48a.png)

This is somehow connected with the previous item since it is about displaying all the fields of a package. When redesigning (implementing the same design as nixos.org) I will look how to improve this.

* After clicking a title, the focus outline stays:
  ![image](https://user-images.githubusercontent.com/15371828/105384561-aa399800-5c12-11eb-8075-828077d7e4d6.png)

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

Here are my few comments:
* The search icon looks weird for me:
  ![](https://camo.githubusercontent.com/479c76aa4e57992e2fd5b2defbd19d17d3baa4f1bf2e51936630cdb890911e75/68747470733a2f2f692e696d6775722e636f6d2f6557456b4b75542e706e67)

I'm not sure how to do this better without importing additional font. I would leave this for now since I plan to work on redesign next. And there we will make sure this kind of things don't happen.

* I find it confusing that the "Show more detail" text is on the separator:
  ![](https://camo.githubusercontent.com/3ed093b1a385a0546fe4e64fc6d179663aed0503440148906861f30b6036b823/68747470733a2f2f692e696d6775722e636f6d2f3254466c6834432e706e67)

I also find it confusing. But I don't have better idea - at this point - how to solve it. As for the previous item I would table this until the redesign.

* Could be great to underline the items where you can click, otherwise, it won't be obvious:
  ![image](https://user-images.githubusercontent.com/15371828/105384436-80807100-5c12-11eb-8bda-1c6bbed4d48a.png)

This is somehow connected with the previous item since it is about displaying all the fields of a package. When redesigning (implementing the same design as nixos.org) I will look how to improve this.

* After clicking a title, the focus outline stays:
  ![image](https://user-images.githubusercontent.com/15371828/105384561-aa399800-5c12-11eb-8075-828077d7e4d6.png)

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

@hugolgst

* After clicking a title, the focus outline stays:
  ![image](https://user-images.githubusercontent.com/15371828/105384561-aa399800-5c12-11eb-8075-828077d7e4d6.png)

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

I just noticed you saif you were using chrome. I can see this being a problem there. let me fix it.

@hugolgst

* After clicking a title, the focus outline stays:
  ![image](https://user-images.githubusercontent.com/15371828/105384561-aa399800-5c12-11eb-8075-828077d7e4d6.png)

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

I just noticed you saif you were using chrome. I can see this being a problem there. let me fix it.

Thanks for the answers @garbas.
For the last point I added to fix it.
outline: none;

Thanks for the answers @garbas.
For the last point I added to fix it.
outline: none;

@hugolgst

Thanks for the answers @garbas.
For the last point I added this CSS property to fix it.
outline: none;

This change is undesirable because outline is needed for keyboard navigation. See https://github.com/NixOS/nixos-search/issues/258

@hugolgst

Thanks for the answers @garbas.
For the last point I added this CSS property to fix it.
outline: none;

This change is undesirable because outline is needed for keyboard navigation. See https://github.com/NixOS/nixos-search/issues/258

Regarding the mobile stuff I will implement them also with the redesign. At the current state it would just take to long to implement this properly. The sooner I merge this the sooner I will start working on redesign.

Regarding the mobile stuff I will implement them also with the redesign. At the current state it would just take to long to implement this properly. The sooner I merge this the sooner I will start working on redesign.

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

This should be reproducible in any chromium based browser which all have default rule for this.

While I agree it doesn't look nice I think we would went into rabbit hole if we would try to fix all these things within the scope of the PR.
I would suggest:

The search icon looks weird for me

It took me a while to figure out what this is about because from screenshot it was not apparent where is this Q thing placed. Anyway I got it.

I think this is yet another regression caused by https://github.com/NixOS/nixos-search/commit/4d505f34022154a1f193f012c11eb08d07c90271 (the font awesome removal). Adding font awesome will make content: "\2315"; work in chrome.

I find it confusing that the "Show more detail" text is on the separator

I personally don't find it confusing but if some does it should be addressed. But I would take it as a consideration for redesign rather than try to design it within this PR

After clicking a title, the focus outline stays

I don't think we should try to solve these small things in scope of this. We need outline for keyboard navigation. I would suggest opening separate issue to improve outline styling just so we don't forget to make sure this is improved in scope of redesign.

I'm also not able to reproduce this outline. I wonder if this is something specific to you. Can you debug it and see which style change would fix it?

This should be reproducible in any chromium based browser which all have default rule for this.

While I agree it doesn't look nice I think we would went into rabbit hole if we would try to fix all these things within the scope of the PR.
I would suggest:

The search icon looks weird for me

It took me a while to figure out what this is about because from screenshot it was not apparent where is this Q thing placed. Anyway I got it.

I think this is yet another regression caused by https://github.com/NixOS/nixos-search/commit/4d505f34022154a1f193f012c11eb08d07c90271 (the font awesome removal). Adding font awesome will make content: "\2315"; work in chrome.

I find it confusing that the "Show more detail" text is on the separator

I personally don't find it confusing but if some does it should be addressed. But I would take it as a consideration for redesign rather than try to design it within this PR

After clicking a title, the focus outline stays

I don't think we should try to solve these small things in scope of this. We need outline for keyboard navigation. I would suggest opening separate issue to improve outline styling just so we don't forget to make sure this is improved in scope of redesign.

I was looking into icon/font-face. It turned out that in FireFox this is using FreeSherif font face. It's GNU licensed font.
adding font-family: FreeSherif to the before element fixes the problem provided this font is available on host system. Full fix though would require us to create webfont (which I already did) and load so we can display this correctly on all systems. However our current build system (webpack) doesn't support that. There are in fact some traces of configuration for static files but other parts of missing. yarn build doesn't include any assets into dist. This means that fixing this would require changes in build configuration which makes this a bit of a scope creep.

I was looking into icon/font-face. It turned out that in FireFox this is using FreeSherif font face. It's GNU licensed font.
adding font-family: FreeSherif to the before element fixes the problem provided this font is available on host system. Full fix though would require us to create webfont (which I already did) and load so we can display this correctly on all systems. However our current build system (webpack) doesn't support that. There are in fact some traces of configuration for static files but other parts of missing. yarn build doesn't include any assets into dist. This means that fixing this would require changes in build configuration which makes this a bit of a scope creep.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/tweag-nix-dev-update-6/11195/1

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/tweag-nix-dev-update-6/11195/1


Add CiteSeer.load

This adds CiteSeer.load for loading that dataset into a StellarGraph object.
The dataset is essentially the same as Cora, in that it's from the same source and has a very similar structure. It thus shares the code. The only differences/new code are:

a different number of features (set by _NUM_FEATURES)
some node IDs are strings (set by _NODES_DTYPES)
there are some dangling edges, where the edges refer to nodes that are not included in the list of feature vectors in the citeseer.content file (these are always ignored)

This PR also uses it in all two of notebooks that use the CiteSeer dataset (stellargraph-attri2vec-citeseer.ipynb, attri2vec-citeseer-node-classification-example.ipynb).
See: #812

Codecov Report

Merging #989 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           develop    #989     +/-   ##
=========================================
+ Coverage     84.7%   84.8%   +0.1%
=========================================
  Files           53      53
  Lines         5279    5296     +17
=========================================
+ Hits          4473    4492     +19
+ Misses         806     804      -2

Impacted Files
Coverage Δ

stellargraph/datasets/datasets.py
82.4% <100%> (+2.2%)
:arrow_up:

stellargraph/core/graph.py
99.3% <0%> (+0.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1468e...2992817. Read the comment docs.


FIX: Emit new line if in_pattern has no body

Example code producing a syntax error after parse->unparse:
case v
in 1
in 2
  true
end

Without the fix it becomes:
case v
in 1in 2 then
  true
end

@palkan Good catch, but I need to add a test in corpus for it before merge. Will get to it later this day, past festivities.

Superseeded by #231.


Simplify conditions in CaseWhenThen blocks

Our normal Expression rewriting logic would make sure that "if then" statements are turned into lambda's so they can be expressed as expressions. This logic, however, was not called on the conditions of CaseWhenThen blocks, so CaseWhenThen blocks with CaseWhenThen blocks in their conditions would fail to render correct C#. This PR makes sure case conditions are simplified. This is done by turning each condition into a lambda that can be called by the conditional blocks. The advantage of turning them into lambdas (instead of normal assignments) is that we delay execution, so the (expensive) conditions of else statements are not evaluated before the cases above them have been.

Not all invalid characters in definition names were escaped correctly, this has now been fixed

Added our normal (SDK) editorconfig settings

Several rewrites as suggested by Rider.

Ok, updated the comment with para, removed SDK-styles from the .editorconfig, renamed private functions to use PascalCase.


Using Mirage in asmdef also requires reference to UniTask asmdef

Please explain the suggested feature in detail.
In order to use Mirage Client or Server you must also have reference to UniTask asmdef. Needing to add Mirage's dependencies to reference to use Mirage is a pain.
How exactly does this keep you from releasing your game right now?
This slows down creating games, causing
Can you suggest a possible solution?
Add Public methods that dont require UniTask
This is a minor issue, but is a pain point while converting projects to mirage

or completely remove UniTasks from Mirage

Client and server methods no longer use UniTask


Fix broken link to dapr tutorial

Fix #90155 to correct broken hyperlink

@timheuer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This change has already been made in the live article. I'll close the PR now. Thank you!


Color definitions for eutrophication status and confidence assessment maps

In https://helcom.fi/wp-content/uploads/2019/12/BSEP156.pdf ex. page 16 the color scheme used for both the status and confidence assessment maps seems to differ from the current ones used in the HEAT.
EQRS_Class_colors <- c("#3BB300", "#99FF66", "#FFCABF", "#FF8066", "#FF0000")
EQRS_Class_limits <- c("High", "Good", "Moderate", "Poor", "Bad")
EQRS_Class_labels <- c(">= 0.8 - 1.0 (High)", ">= 0.6 - 0.8 (Good)", ">= 0.4 - 0.6 (Moderate)", ">= 0.2 - 0.4 (Poor)", ">= 0.0 - 0.2 (Bad)")
C_Class_colors <- c("#3BB300", "#FFCABF", "#FF0000")
C_Class_limits <- c("High", "Moderate", "Low")
C_Class_labels <- c(">= 75 % (High)", "50 - 74 % (Moderate)", "< 50 % (Low)")
I would like the exact color schemes to be used in HOLAS III which possible will be the same as for the HOLAS II report linked to?

Hi,
Colour codes used in HOLAS 2 publication. As far as we know these will be used in 3 but might still change in the process:
ER, 5-scale (RGB colour code: R, G, B)
< 0.5 (119, 184, 143)
0.5-1 (186, 215, 194)
1-1.5 (235, 205, 197)
1.5-2 (216, 161, 151)

2 (199, 122, 112)

ConfidenceHigh (252, 231, 218)
ConfidenceModerate (245, 183, 142)
ConfidenceLow (204, 100, 23)
ER, 2-scale, used for indicator in HELCOM map and data service (R, G, B)
< 1 (98, 141, 126)

1 (162, 88, 95)

Done


Fix typos in docstrings

This PR fixes some typos in the docstrings of a few functions. 😇

Hello @sky-2002! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file umap/parametric_umap.py:

Line 292:89: E501 line too long (92 > 88 characters)

In the file umap/umap_.py:

Line 1301:89: E501 line too long (99 > 88 characters)

Thanks for this!


Extension API for VS Code v1

Description
This is a PR for #1041. It is as simple as possible, basically exporting the VsCodeExtension instance to be usable by other extensions.
This could for example be used to directly communicate with the models (e.g. via model.streamChat etc.) or to communicate with the chat webview, for example:
continueInstance.webviewProtocol.request("userInput", {
  input: "Please do X for me!",
});

I believe it is currently ok to export the VsCodeExtension instance, despite giving full access to internals of continue, in order to figure out what features are actually useful for other extension authors. Later on, the instance property should be deprecated in favor of a better designed external API.
Maybe the author of #803 could make use of this simple API, too, instead of adding the proposed functionality to continue itself.
For a better Typescript experience, the types of the API should also be exposed as an npm package.
Checklist

[x] The base branch of this PR is preview, rather than main

@FunkMonkey I'm going through all of the many PRs that have ended up on the back burner, and I realize now that I completely missed this. The principle I think we're coming to is that it's not best to accept "input" from other extensions. What I mean by this is that you could do something like registering a custom "slash command" or "context provider" (like here), but we don't want to allow arbitrary usage of Continue resources without the user triggering them. Especially when something like OAuth is in place to allow users to access resources from an account, this could pose a potential security risk.
I'm going to close this PR because of this, but I would be curious to hear in the GH issue whether you think that there might be another way of accomplishing what you're looking to do. Hope to hear from you, and hopefully we can make something work!


⚠ Bofrost.lu has degraded performance

In c64959f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1523 ms

Resolved: Bofrost.lu performance has improved in 0ef0cb3 after 6 minutes.


Understanding IPSec

Article checklist
Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

This closes #7058

Also, updated my avatar image for author page

Hey @mercymeave . What's the progress of the review phase?

Would you please go over the article once more and shorten the long paragraphs for readability?

Would you please go over the article once more and shorten the long paragraphs for readability?

Done @mercymeave
Also, I want to update my avatar image. Can you verify whether the file is correct or should I modify it?

Plagiarism check is done

jumping on this one

@kvardhan10

👍 Well done updating your profile image.
Be sure to see your live published article on the site (it should be live within 30 mins).
To give your article a boost in page engagement - share it across your social site (linkedin/twitter) and tag the EngEd program so we can also share it and give it some traction as well!
If you have not done so already, consider adding a skill section to your profile page. This will go a long way for potential future employers.

@hectorkambow I want to add a skills section to my author page. To do that should I update my index.md file from my author folder and create a PR or is there any other way?


rankinfo testing file

a file similar to snowflakes-testing.json needs to be created for testing ranks.

I have a PR in the works that solves this


docs: Get rid of Ranker docs

Codecov Report
Base: 9.13% // Head: 9.13% // No change to project coverage :thumbsup:

Coverage data is based on head (1f0a6c1) compared to base (d108677).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1197   +/-   ##
======================================
  Coverage    9.13%   9.13%
======================================
  Files         107     107
  Lines        8108    8108
  Branches     2011    2011
======================================
  Hits          741     741
  Misses       6185    6185
  Partials     1182    1182

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ranker tag started a new life with new set of docs!


How to send a gif message?

Hi, first of all, this project is amazing, thanks!
I need to send gif messages but I don't know how to set the gifPlayback property to send.
Any idea?

You can't even I tried downloading the Gif that was created by whatsapp themselves and it is in mp4 format. so the only way to do is to send it as an mp4 format. you can format .gif to mp4 BTW

I think it is possible because you can do it from the Whatsapp Web app, I am going to explore.


SBG L2 Train Estimation Application package

SBG trait estimation application package creation
Repo: TBD
Sister implementation: https://github.com/sister-jpl/sister-trait_estimate
Acceptance Criteria:

[ ] algorithm code and required libraries are included in repository environment.yml file
[ ] Application package is built and registered within Docker Hub
[ ] Application package is built and registered within Dock Store
[ ] Application Package CWL is created
[ ] Output Datasets have been defined (to U-DS)
[ ] Example inputs, outputs as expected
[ ] Example deploy and execute commands (unity-py)
[ ] Deployed and tested within WPS-T existing SPS

Output dataset: SBG-L2B_VEGBIOCHEM

Moved this ticket to 24.1.4.


Compile error on arrays of objects with additionalPropertiesOption: strict

At compile-time we see the following when setting additionalPropertiesOption: strict in the config:
Cannot check for instance of erased type: List<Bar.Foo>

For a schema containing an array of objects:
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "bar.schema.json",
  "properties": {
    "foos": {
      "type": "array",
      "items": {
        "id": "foo",
        "type": "object"
      }
    }
  }
}

The offending generated code in Bar.kt:
if (cg_map.containsKey("foos"))
  require(cg_map["foos"] is List<Foo>) { "foos is not the correct type, expecting List<Foo>?" }

This is a blocker for us, since our schema required pattern properties, thus iiuc we need to enable additionalPropertiesOption: strict for the relevant code the generated.
Applying via json-kotlin-gradle plugin 0.102.
@pwall567 Do you have bandwidth to provide a fix? 🙏

And version 0.103 should also fix this problem.
Thank you for your help in identifying these issues.  As you have probably seen, there are a large number of combinations to be tested, and while I hope my tests cover most of them, I suspect there are still issues yet to be unearthed.


remove copyImages task

from both Consumer and hSC documentation project

see aim42/venom-example how this can be done.


Update ports.js - add ptx

I have PTX coin working in Agama on my system with this configuration.

please use dev branch
everything is linked in wiki's guide


Update code snippet yaml formatting

Description
During my recent CKA certification training, I noticed that the formatting of some of the code snippet examples in the Kubernetes documentation (English) were inconsistent across the same object types.
For example, on the following page, the yaml formatting of the Service examples is inconsistent, and this can result in some extra work involved when copying these code snippets during CKA certification exam.
https://kubernetes.io/docs/concepts/services-networking/service/#defining-a-service
In the first code snippet example the ports: section attributes are indented with 2 spaces, whereas in the second code snippet example the attributes are inline and not indented,
First code snippet example:
apiVersion: v1
kind: Service
metadata:
  name: my-service
spec:
  selector:
    app.kubernetes.io/name: MyApp
  ports:
    - protocol: TCP
      port: 80
      targetPort: 9376

Second code snippet example:
...
---
apiVersion: v1
kind: Service
metadata:
  name: nginx-service
spec:
  selector:
    app.kubernetes.io/name: proxy
  ports:
  - name: name-of-service-port
    protocol: TCP
    port: 80
    targetPort: http-web-svc

Where there are indented attributes in the code snippet examples, I've updated the yaml formatting to show the relevant attributes inline across the Kubernetes documentation (English).

@tengqm @sftim @utkarsh-singh1 Thanks for your recent review comments.
As someone who has recently completed the CKA certification exam and for all future students studying for the CKA, CKS, CKAD, etc, the purpose of this change is to apply consistency across all code snippet examples which will help everyone save time, specifically during the certification exams.
Also, as you might not be aware... the kubectl create ... command creates yaml manifests using no indentation for dictionary (array) object types, and many students will very likely use this command extensively during certification exams to create Kubernetes manifest templates. The code snippet examples from the Kubernetes documentation will then be added (copy/paste) within these yaml manifest templates.
$ kubectl create service clusterip service --tcp 80:8080 --dry-run=client -oyaml

apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    app: service
  name: service
spec:
  ports:
  - name: 80-8080
    port: 80
    protocol: TCP
    targetPort: 8080
  selector:
    app: service
  type: ClusterIP
status:
  loadBalancer: {}

The docs are for many audiences including learners, not just exam candidates. I genuinely don't see this as justification for a change here.
Additionally, knowing how to manipulate YAML is a skill that the CKA (and other certifications) expect candidates to have.
/priority awaiting-more-evidence

If the general concensus is to leave the inconsistent code snippet example formatting across the Kubernetes documentation unchanged (whether inline or indented) then I'm happy to close the ticket.


chore(release): 1.6.0-rc.9

Version bump in package.json and package-lock.json for release 1.6.0-rc.9

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Initial commit

This is the initial commit of v. 1.0.0-0 of the Angular persistence framework.  It has been deployed to NPM.  The reason this is still in pre-release status is that there needs to be some tests around caching and attribute binding and the documentation probably needs to be updated.

Commit of the initial drop of the persistence framework.  This is a pre-release v.1.0.0-0 which has already been published in NPM and all tests are passing.  The reason for the pre-release status is that there is some documentation that needs to be updated and some tests that need to written for the caching and attribute binding systems.

Commit of the initial drop of the persistence framework. This is a pre-release v.1.0.0-0 which has already been published in NPM and all tests are passing. The reason for the pre-release status is that there is some documentation that needs to be updated and some tests that need to written for the caching and attribute binding systems.


How do I use this?

Could you please ELI5 how I would go about including this component with my project? Sorry, I am still new to react and not quite sure how to include 3rd party components.
Currently I am using node/express and rendering everything client side.

Please see the example which is included in the repository

I have looked at the examples but I want to be able to require the file as you have it in the readme instructions.

I see this issue is closed, which I think is incorrent. I see very limited overlap between the readme and the examples. For instance, in the examples, I cannot find the same styles as in the readme. Can more instructions be given or examples / readme be updated?


[TEMP] Update to crate-docs-theme==0.34.0.dev1

About
This RTD build gives you the chance to preview and review the documentation, using a pre-release of the modernized crate-docs-theme, based on sphinx-basic-ng/Furo. Please do not merge.
Preview
https://cratedb-guide--99.org.readthedocs.build/
References

https://github.com/crate/crate-docs-theme/pull/390

We are already using 0.34.0.dev3 on this project, as a canary.


You aren't using a compiler supported by lombok, so lombok will not work and has been disabled.

Short description
I didn make any changes, Previously it was working fine but when I take a pull of master branch then my all projet stop working and above error start showing at the time of compilation.
This error shown in buildOutput.
In terminal it shows:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
Expected behavior
It should start working as expected
Version information

IDEA Version: IntelliJ IDEA 2020.3 EAP (Community Edition)
Runtime version: 11.0.8+10-b1098.1 amd64

JDK Version: 1.8.0

**OS Type & Version:**ubuntu1.18.0

Lombok Plugin Version: 1.18.0

Lombok Dependency Version: What version of lombok.jar are you using?

Stacktrace
I am not able to find any solution any where on the net please help me out

duplicate #950
This is issue of lombok project. Please look here: rzwitserloot/lombok#2592 and here https://youtrack.jetbrains.com/issue/IDEA-252069
Unfortunately this can be fixed only in lombok self. So we need to wait for new lombok release.

I have the same issue, I have updated my Lombok dependency and it worked for me.

org.projectlombok
lombok
1.18.16
provided

I had the same nasty problem when I updated today to 2020.3. It is shameful of IDEA to release their update without trying to coordinate with Lombok. Even more nasty is that if you go on idea's download section and click on "Other versions" in order to download the previous version, you get an empty page! Also when the IDE updates a version it would better make a backup of the previous version and offer in the UI an option to rollback to that backup. For who is interested in downloading the previous version (2020.2.4), I downloaded it from here: https://confluence.jetbrains.com/display/IDEADEV/IDEA+2020.2+latest+builds

@valentinbrasov Jetbrains Toolbox provides instant rollback feature for all Jetbrains products if "Keep only latest version" setting is unchecked (this is unchecked by default as far as I remember).

@valentinbrasov Jetbrains Toolbox provides instant rollback feature for all Jetbrains products if "Keep only latest version" setting is unchecked (It's unchecked by default as far as I remember).

This has a workaround in this thread rzwitserloot/lombok#2592 mentioned by @mplushnikov.
The suggestion here fixed it for me: https://github.com/rzwitserloot/lombok/issues/2592#issuecomment-705449860

Yes, add -Djps.track.ap.dependencies=false to the build process options.

This has a workaround in this thread rzwitserloot/lombok#2592 mentioned by @mplushnikov.
The suggestion here fixed it for me: rzwitserloot/lombok#2592 (comment)

Yes, add -Djps.track.ap.dependencies=false to the build process options.

You, Sir, Saved my day. Thank you so very much  :)

This has a workaround in this thread rzwitserloot/lombok#2592 mentioned by @mplushnikov.
The suggestion here fixed it for me: rzwitserloot/lombok#2592 (comment)

Yes, add -Djps.track.ap.dependencies=false to the build process options.

You, Sir, Saved my day. Thank you so very much :)

Saved my day. Thank you! 👍

This has a workaround in this thread rzwitserloot/lombok#2592 mentioned by @mplushnikov.
The suggestion here fixed it for me: rzwitserloot/lombok#2592 (comment)

Yes, add -Djps.track.ap.dependencies=false to the build process options.

Thanks Buddy!... you are life saver.

worked from me 👍

Thanks for the solution !

Does not work for me. Only downgrade to 2020.2 allows me to run application.


vim mode not work

Issue Type: Bug
After reinstall vim extension,
it still doesn't work
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
AMD Ryzen 5 1400 Quad-Core Processor            (8 x 3194)

Memory (System)
15.93GB (9.47GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe C:\embarc_osp12\README.md

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

python
ms-
2018.3.1

cpptools
ms-
0.16.1

veriloghdl
msh
0.2.0

makefiles-support-for-vscode
nae
0.0.3

python
tht
0.2.3

spice
xua
0.0.4

markdown-all-in-one
yzh
1.1.1

Reproduces only with extensions

Please open an issue on the Vim extension repo with more details.


Add styles for "invalid" form inputs

Feature Request
Description

Currently, the '--terra-form-input-error-border' variable does not provide any distinction when the input is in an error state (it remains black).  Other themes, provide a distinction.  We need to come up with something similar.  It would be good to evaluate other form fields in the process (text area, etc.) to see if we're also missing this functionality.

This issue seems to be resolved in this PR.


feat: Add KO_GO_PATH env var

Makes go version used to build image binaries configurable via KO_GO_PATH. Optional, defaults to go resolved from $PATH.
Removes deprecated dep command.
Closes: #926
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

Codecov Report

Merging #930 (e310747) into main (72e2752) will increase coverage by 1.20%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   51.21%   52.42%   +1.20%
==========================================
  Files          44       43       -1
  Lines        3419     3325      -94
==========================================
- Hits         1751     1743       -8
+ Misses       1439     1353      -86
  Partials      229      229

Impacted Files
Coverage Δ

pkg/commands/commands.go
61.53% <ø> (-2.75%)
:arrow_down:

pkg/build/gobuild.go
57.07% <72.72%> (+0.10%)
:arrow_up:

pkg/build/cache.go
41.66% <100.00%> (+0.82%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sorry for complicating this PR by including ko deps' removal in it. I've split that out into https://github.com/ko-build/ko/pull/937

Ah, let me wait until your PR is in and then rebase.

Ready after rebase @imjasonh


「You can use your own Excel file, but the data must be formatted as a table.」What is the reason for this design？

Excel can be imported directly into mendix studio, but not at powerapps.
Why ? What's the rationale for this design ?

文档详细信息
⚠ 请勿编辑此部分。 docs.microsoft.com ➟ GitHub 问题链接必须具有此部分。

ID: 42de6ba6-a4e0-fb79-cd90-b86e9b047e82
Version Independent ID: e4251860-19f2-817b-bd5a-71d4bb50b6b5
Content: 在 Excel 中设置表格式 - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/how-to-excel-tips.md
Service: powerapps
GitHub Login: @yifwang
Microsoft Alias: yifwang

Thank you for reaching out. For product behavior, feature design and changes, please reach out using Power Apps Ideas Forum.


feat: add MacOS print options

Description
Currently, when printing on a MacOS, it defaults to a quite big margin, which does not reflect the side of it when printing on the web. The current code just creates a new NSPrintInfo from the default, which for some reason has a large margin.
This changes so that the default margin is 0 and add the option to change it when printing the webview on MacOs. This is not a field that can be changed by the user on the appkit modal, so it has to be defined before the modal is open.
Other options could be added on top of these ones, but for this initial commit/PR decided to go with adding the margins since it seems to be the one with bigger discrepancy compared to the web version.
Closes #713 (Not sure if should mark this as really close it since it really fixes only the margin part. The difference on the modal doesn't seem to be customisable as far as I understood from the docs).
References:

https://developer.apple.com/documentation/appkit/nsprintinfo

Screenshots:
Using the new print.rs in the examples folder.
Current default print

Default print with these changes

Hi, can you add a changelog (https://github.com/tauri-apps/wry/tree/dev/.changes) and do a cargo fmt?

Hi, can you add a changelog (https://github.com/tauri-apps/wry/tree/dev/.changes) and do a cargo fmt?

Done! ✅
Put it as a minor, but let me know if that was classified incorrectly for the project.
It does fix what I believe to be a bug (the large margins when printing on MacOS), but also adds a new feature (the printing with extra options), so the minor felt more correct.


Make SELinux support on cOS optional

Is your feature request related to a problem? Please describe.
SELinux might not be needed at all in some scenarios.
Describe the solution you'd like
We can make it optional by turning it on/off from the values file
Describe alternatives you've considered
N/A
Additional context
N/A

That was fixed by #330


Convoy

The convoy function where you can drop items off needs to be built.

Core Functionality has been built. Lists can now be cycled through.

Completed


Fix data count query for ComputeClusterCosts

Corrects the "minutes per window" query to account for nodes coming up and down.

Lgtm


#338 - Ajax Loader

Usage:
Activate using this.$store.commit('ui/setLoader', true)

Could you please provide the event for loaders (it's a kind of convention right now to handle all kind of notifications using events for example EventBus.$emit('notification') etc.
So would be great to have event like: EventBus.$emit('notification-progress-start') and EventBus.$emit('notification-progress-stop') for this.
Then, we can add EventBus.$emit('notification-progress-step', { progress: 50, of: 100, message: 'Loading user profile ...' }) in the next step
@BlitZ-UK @collymore

After adding events support - could you please add the notification-progress-start andnotification-progress-stop around:

all fetch() calls you can find in the app
... for sure please add it to: store/modules/user.js - login, password reset etc,
entering Product.vue and Category.vue pages - you probably need to emit notifiation-progress-stop inside fetchData() methods

for example:
import EventBus from 'src/event-bus'
  /**
   * Send password reset link for specific e-mail
   */
  resetPassword (context, { email }) {
    console.log({ email: email })
    EventBus.$emit('notification-progress-start')

    return fetch(config.users.endpoint + '/resetPassword', {
      method: 'POST',
      mode: 'cors',
      headers: {
        'Accept': 'application/json, text/plain, */*',
        'Content-Type': 'application/json'
      },
      body: JSON.stringify({ email: email })
    }).then((response) => {
    EventBus.$emit('notification-progress-stop')
      const contentType = response.headers.get('content-type')
      if (contentType && contentType.includes('application/json')) {
        return response.json()
      } else {
        console.error('Error with response - bad content-type!')
      }

      return response
    })
  },

@BlitZ-UK  notification-progress-start and notification-progress-stop with message under loading bar as notification-progress-start event param (e.g.  $bus.$emit('notification-progress-start', "Loading user profile, please wait")) would be awesome. You can also do it in Vuex store like overlay, both ways are correct ;)

Loader can now contain a message using the format mentioned above :)

Thanks guys, it's cool. But how does it regard the UI design from https://github.com/DivanteLtd/vue-storefront/issues/338 - a top bar. Could you implement the second version of loader regarding the UI designs ?:)
Very simple, linear loader like on Youtube etc.
Would be great to choose the loader by specific parameter of notification / ui store.
If we won't add it like on design, our designer @karolbzik will be back with some issues I belive ;)

@pkarw At the moment the loader is activated via .start/.stop commands, how will we translate this into an animated progress bar ? Until it has percentage base or progress steps it should wait until then. I chose one of the loaders that was from spinkit/from #338 too.
I'd wait off until we wrap the ajax requests around this loader (or alternatively rather than manually going through, why don't we use something like Pace and automatically catch all ajax requests and display the top loader that way (see http://github.hubspot.com/pace/docs/welcome/)).
Thanks

@BlitZ-UK point taken :) Let's leave it as it is.
My initial idea was to use sth like http://github.hubspot.com/pace/docs/welcome/ - it's cool.
Can you integrate the http://github.hubspot.com/pace/docs/welcome/ and check how it works with our resource loading model? I belive it will be jsut fine.
Sorry for this long comments topic I didn't mean to use a negotiation-nibble tactic for this feature ;P

Plus! Could you add the documentation about how to use the - let say 'manual progress bar' - under: https://github.com/DivanteLtd/vue-storefront/tree/master/doc ?

I'm merging this in, however it's still great to have this linear-loader (pace) implemented, could you take care of this guys?

Yeah we'll take care of this and integrate Pace (top loader) with all Ajax requests, we've recently done this with one of our other Vue projects, it takes a little patch that we wrote but after that Pace works fine with it. I'll get the docs updated with how to use the manual loader for now too,
Thanks !


[FJ-57]  recreate existing charts

Recreates existing charts, without tables.

Based on our Slack convo @michael-caktus , would be good to update the docs with instructions to npm install and npm run start from /frontend + ./manage.py from root, and remove stale instructions in docs.

RE: docs,  also would be good to point out the bit about uncommenting lines 10-13 in traffic_stops/settings/local.py.


feat(console): integrate frontend

relates to #31

@peintnermax the pipeline should run, and the generated files are in the console folder. Please have a look at the failures 😁


Hk select specific fields

This tries to adress #90. Most of the commit(s) is noise regarding to the fact that we have no more * in the query by default, but the models specific fields.
How did I go on about this?
There is a macro-defined class method fields on LuckyRecord::Model which returns all the fields defined by the field macro. So when a query is built for a model, the selection method on the QueryBuilder is called with all of those field.
Defining a class method fields means a user can never add a class method fields himself I guess? Also, using .selection([:foo, :bar]) is by no means safe, could easily blow up on execution, right?

Thanks for the review, I like the improvements!

Circle wasn't set up to run forks. I changed that setting and will open/close this so it runs in CI


Collection of minor improvements

Here are some minor improvements I've made since I started using your shell.nix. Let me know which ones you like/don't. :)
Have some larger commits that I'm holding back for now.

My plan is to rebase this on https://github.com/0xB10C/nix-bitcoin-core/pull/6, let the CI run, merge on green and then merge https://github.com/0xB10C/nix-bitcoin-core/pull/6 later (feel free to have a look at it if you want @cbergqvist ).