LXD v2.9.3 won't set container's root disk size (quota) on ZFS filesystem

Hi there,
don't know if this has something to do with the newly introduced storage pools functionality, but before upgrading to v2.9.3 and using v2.8, setting container's root disk size (quota) on ZFS worked like a charm with the following command (example):
lxc config device set archtest root size 2GB
Instantly the container's root disk filesize was changed. Now with 2.9.3, we always get this error:
error: The device doesn't exist
Of course we can manually set the quota using zfs utility, but I'm not sure if LXD doesn't hold the actual filesize of the container's root filesystem somewhere else and doing it this way would probably make it inconsistent between raw zfs filesystem metadata and LXD container's metadata.
So, how can one set it properly using lxc client on v2.9.3? Many thanks!

Well, it seems the root disk device doesn't exist. Can you show:
lxc config show archtest

Aka, what you want to do is:
lxc config device add archtest root disk path=/ pool=<pool-name> size=2GB

or, if you want all containers to have quota:
 lxc profile device set default root size 2GB

I suppose the container won't probably run if it doesn't have a root device, but it's running :)

root@finaltest-ubuntu:~# lxc list
+----------+---------+-------------------+------+------------+-----------+
|   NAME   |  STATE  |       IPV4        | IPV6 |    TYPE    | SNAPSHOTS |
+----------+---------+-------------------+------+------------+-----------+
| archtest | RUNNING | <IP_ADDRESS> (eth0) |      | PERSISTENT | 0         |
+----------+---------+-------------------+------+------------+-----------+

root@finaltest-ubuntu:~# lxc config show archtest
architecture: x86_64
config:
  image.architecture: amd64
  image.description: Archlinux current amd64 (20170225_01:27)
  image.os: Archlinux
  image.release: current
  image.serial: "20170225_01:27"
  limits.cpu: "0"
  limits.memory: 64MB
  volatile.base_image: archlinux
  volatile.eth0.hwaddr: 00:16:3e:f7:cf:c8
  volatile.eth0.name: eth0
  volatile.idmap.base: "0"
  volatile.idmap.next: '[]'
  volatile.last_state.idmap: '[]'
  volatile.last_state.power: RUNNING
devices: {}
ephemeral: false
profiles:
- default

root@finaltest-ubuntu:~# lxc info archtest
Name: archtest
Remote: unix:/var/lib/lxd/unix.socket
Architecture: x86_64
Created: 2017/02/26 01:37 UTC
Status: Running
Type: persistent
Profiles: default
Pid: 28377
Ips:
  eth0: inet    <IP_ADDRESS>      veth9LV3KC
  eth0: inet6   fe80::216:3eff:fef7:cfc8        veth9LV3KC
  lo:   inet    <IP_ADDRESS>
  lo:   inet6   ::1
Resources:
  Processes: 13
  Disk usage:
    root: 9.63MB
  CPU usage:
    CPU usage (in seconds): 6
  Memory usage:
    Memory (current): 22.78MB
    Memory (peak): 23.54MB
  Network usage:
    eth0:
      Bytes received: 732B
      Bytes sent: 1.99kB
      Packets received: 3
      Packets sent: 19
    lo:
      Bytes received: 306B
      Bytes sent: 306B
      Packets received: 3
      Packets sent: 3

The new storage api introduces the pool property for disk devices. The root disk device for the default profile determines where containers are created per default, when no storage pool is explicitly targeted with the -s flag. This works by looking at the  pool property that you can see in the default profile:
lxc profile show default

@audiocricket, no the container doesn't have a local root disk device but it has a root disk device: the profile's root disk device which is the default profile. You can look at:
lxc profile show default

to see the root disk device in there. And as I said you can set the size property there to have all your containers use quota. :)

Okay, so if I understand it correctly:

there's the LXD root pool (the "main" / master)
and every container should have it's own storage under this pool

Right?

Seems to work, thanks!

Well, there's the concept of a storage pool and a storage volume:
The zpool is the storage pool which LXD calls "default". It's on-disk name may however be different like e.g. pool1 or, when using an existing dataset as pool "pool1/vol1".
On this pool each container has it's own storage volume where a storage volume is just another zfs dataset in this case. For example, "pool1/vol1/container/archtest".

Perfect, makes sense. Is this somewhere documented?

And one last question - it seems like LXD v3.x is coming soon - do you expect that this concept of storage pool and storage volume won't drastically change in next major version?

@audiocricket, actually the next version will be 2.10. :) We definitely do not expect this concept to change drastically. Also, keep in mind that the current storage api is just an extension of the storage capabilites LXD had before. The concept of a storage pool and storage volume has been around from the beginning: For each container, image, snapshot, a storage volume or in zfs lingo "dataset" was always created. The storage api just generalizes this idea to different storage types so that you can have a uniform approach in creating and using containers on multiple storage backends simultaneously.

Thank you very much @brauner 👍

I reopened this topic now, because I think my "problem" belongs to this...
I followed all the above information and tried both: adding device to container and also seting the profiles root size.
But my guest-system always shows to much size?!
root@leif ~ # lxc init ubuntu:17.04
Creating the container
Container name is: evolved-javelin
root@leif ~ # lxc config show evolved-javelin
architecture: x86_64
config:
  image.architecture: amd64
  image.description: ubuntu 17.04 amd64 (release) (20170412.1)
  image.label: release
  image.os: ubuntu
  image.release: zesty
  image.serial: "20170412.1"
  image.version: "17.04"
  volatile.apply_template: create
  volatile.base_image: a221591e855f271769b3d780789c25d504b4062475c125f790b97d4afa0539f5
  volatile.eth0.hwaddr: 00:16:3e:77:f1:8f
  volatile.eth0.name: eth0
  volatile.idmap.base: "0"
  volatile.idmap.next: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":65536},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":65536}]'
  volatile.last_state.idmap: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":65536},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":65536}]'
devices: {}
ephemeral: false
profiles:
- default

root@leif ~ # lxc config device set evolved-javelin root disk size=2GB
error: The device doesn't exist
root@leif ~ # lxc config device add evolved-javelin root disk path=/ pool=default size=2GB
Device root added to evolved-javelin

root@leif ~ # lxc config show evolved-javelin
architecture: x86_64
config:
  image.architecture: amd64
  image.description: ubuntu 17.04 amd64 (release) (20170412.1)
  image.label: release
  image.os: ubuntu
  image.release: zesty
  image.serial: "20170412.1"
  image.version: "17.04"
  volatile.apply_template: create
  volatile.base_image: a221591e855f271769b3d780789c25d504b4062475c125f790b97d4afa0539f5
  volatile.eth0.hwaddr: 00:16:3e:77:f1:8f
  volatile.eth0.name: eth0
  volatile.idmap.base: "0"
  volatile.idmap.next: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":65536},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":65536}]'
  volatile.last_state.idmap: '[{"Isuid":true,"Isgid":false,"Hostid":100000,"Nsid":0,"Maprange":65536},{"Isuid":false,"Isgid":true,"Hostid":100000,"Nsid":0,"Maprange":65536}]'
devices:
  root:
    path: /
    pool: default
    size: 2GB
    type: disk
ephemeral: false
profiles:
- default

root@leif ~ # lxc info
config:
  core.https_address: '[::]:8443'
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
api_status: stable
api_version: "1.0"
auth: trusted
public: false
environment:
  addresses:
  - <IP_ADDRESS>:8443
  - '[2a01:4f8:c17:2006::2]:8443'
  - <IP_ADDRESS>:8443
  - '[fd42:afb:d539:e905::1]:8443'
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
    MIIFlDCCA3ygAwIBAgIQd4fBlT+9ygl/FfVpiig6HzANBgkqhkiG9w0BAQsFADBK
    MRwwGgYDVQQKExNsaW51eGNvbnRhaW5lcnMub3JnMSowKAYDVQQDDCFyb290QFVi
    dW50dS0xNzA0LXplc3R5LTY0LW1pbmltYWwwHhcNMTcwNTIzMTY1OTQ1WhcNMjcw
    NTIxMTY1OTQ1WjBKMRwwGgYDVQQKExNsaW51eGNvbnRhaW5lcnMub3JnMSowKAYD
    VQQDDCFyb290QFVidW50dS0xNzA0LXplc3R5LTY0LW1pbmltYWwwggIiMA0GCSqG
    SIb3DQEBAQUAA4ICDwAwggIKAoICAQCo6sJpNgdLN7B2s8K9i9YwZnYkfJaoCpEs
    KG6HzpoYdfIOLrxiNwvzGaYL3g58E7ghQm/JuDQUc6fXxInC1szUhE6vH0dCskz2
    Z2aINxVEBOcD4V2gjw5N8Liq0yCQwoGM+2I0Mpat5ugcVtDB8FfNVlPiPNCG7V2P
    bvSCvCNulWatwBn62ldKEpfbwgnJ7Mm5vWj0Sjk9P9PdSwds/RtCpNrl4f4XoHIA
    EmhRpgrVShjdvPh2GVjBq3dHlXVHUwZyl6LOkcLwnOZ35NOT45b6Y2klJ7bVsmgf
    lcEr8VcXA+hKdleD4MTf2nai3CI6WrrQ/FSmCIk9LK23NhHVM90y+NLnApG+rzA4
    FlALfbipcsKE0i5CjTnp/sLMqBpd4y6DD+IOgQwdx+j08PVdmVi7KBn516zOJVY3
    3CiR6EbovJ4uuf5cZiryMaCYznXQdvr5crW2rQZ/tw2bw2uxNuMxoSt7BvEOW6KU
    6RKQMtL4BUAuDQsP0qk8dOpX7YUYMrsjAl1dItpgFEapE+1cRm+QCSk0tiVqiLFX
    L/kZUkTyLNg0KZ+U5djgPcuQgYia5/H8ENrCiFrRmHT+UzKVOt7ctnmAjqQfaDzN
    2XnD0kaJCklm2HjU2TvfBkN+zp2jpAcpJFXAzVc/D/h7RLHVrEbOaNPL6jazGbOs
    DcOPd6DqXwIDAQABo3YwdDAOBgNVHQ8BAf8EBAMCBaAwEwYDVR0lBAwwCgYIKwYB
    BQUHAwEwDAYDVR0TAQH/BAIwADA/BgNVHREEODA2ghxVYnVudHUtMTcwNC16ZXN0
    eS02NC1taW5pbWFshwSsHwFkhxAqAQT4DBcgBgAAAAAAAAACMA0GCSqGSIb3DQEB
    CwUAA4ICAQCFzMZ83doVSz18PCUUEVpXS7ejGjsvtH5wwftDnji4NixFOR3MyKW1
    UCwT/mhHAwrrDtJKV2+fmiQJLTyjHUkvOKUR6OM11Y+NVlwRZlBvwogBo/OVepPu
    ufA80fzf3yF9fvVceJVVXErKj2pCq+v8O2Zs69u/jaGgFUjwaiacmilZ+WstnNXs
    gWEf2ID76GugZZiziW1jYtS5SXQy+ocx1+nCBIFIf0wMSHD3vcuRnU+8HaoyArMS
    /lx9E/jWEsskGYzobtk3tnLeRYMUKhtkTAde/iz3dYQYkwPideGdk+plGQC8zZt9
    8iE9dd8omMgq5En0kBk7NomHkQZP/y3ArXDAiRLkjXJLQJrc0PxePohSW3Mr+Zw2
    amxvxL4HmS/YzzgH2xviJiaktAQ/yYvFHVzts2H/UoTWxPCweTgVLqD5wx8LbcEG
    h3bgWqWVggLL0ZZyAVHmlt4iUXi/4YRyFUTPPUyvlLyhaSDsi4gyFbdfhBykyg1u
    M32vRRkYkUwlLCw1+QU4RV7PwzjOPjOHEz30ceTyCnPgjiwdhxIu24xsnEg9WueF
    AOl4rWU7bry490CfLwFTmkCp8H2Lce/4IceXt5uaVqNwabAQbFRobHoML2HHEW4d
    JjIPiT2YxguOAWXKzo6A4w/8TuqVcgTNKwzR3oAH8YomWeyajfvEnQ==
    -----END CERTIFICATE-----
  certificate_fingerprint: 1712edeeae11e23ba19c16595451f844f3faad507f2b7ca1aab0fcc243ccf33a
  driver: lxc
  driver_version: 2.0.7
  kernel: Linux
  kernel_architecture: x86_64
  kernel_version: 4.10.0-21-generic
  server: lxd
  server_pid: 14812
  server_version: "2.12"
  storage: zfs
  storage_version: <IP_ADDRESS>-2

root@leif ~ # lxc list
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
|       NAME       |  STATE  |         IPV4          |                     IPV6                     |    TYPE    | SNAPSHOTS |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
| c000326553       | STOPPED |                       |                                              | PERSISTENT | 0         |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
| evolved-javelin  | STOPPED |                       |                                              | PERSISTENT | 0         |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
| from-alias       | RUNNING | <IP_ADDRESS> (eth0) | fd42:afb:d539:e905:216:3eff:fe36:22ef (eth0) | PERSISTENT | 0         |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
| generous-cheetah | RUNNING | <IP_ADDRESS> (eth0)  | fd42:afb:d539:e905:216:3eff:fe0d:4863 (eth0) | PERSISTENT | 0         |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
| pleased-walrus   | RUNNING | <IP_ADDRESS> (eth0) | fd42:afb:d539:e905:216:3eff:fef6:cd58 (eth0) | PERSISTENT | 0         |
+------------------+---------+-----------------------+----------------------------------------------+------------+-----------+
root@leif ~ # lxc start evolved-javelin
root@leif ~ # lxc exec evolved-javelin df
Filesystem                            1K-blocks   Used Available Use% Mounted on
zpool1/lxd/containers/evolved-javelin   2692608 601088   2091520  23% /
none                                        492      0       492   0% /dev
udev                                     485132      0    485132   0% /dev/tty
tmpfs                                       100      0       100   0% /dev/lxd
tmpfs                                       100      0       100   0% /dev/.lxd-mounts
tmpfs                                    506848      0    506848   0% /dev/shm
tmpfs                                    506848   6412    500436   2% /run
tmpfs                                      5120      0      5120   0% /run/lock
tmpfs                                    506848      0    506848   0% /sys/fs/cgroup

Is this correct? and how do I get it really to 2GB?

I'd also need to see the output for the storage pool
lxc storage show <pool-nam>

I suspect that you're using quota and not refquota. When you use refquota the value should be correct. So what you'd need to do is:
lxc config device unset evolved-javelin root disk size
lxc storage set <pool-name> volume.zfs.use_refquota true
lxc config device set evolved-javelin root disk size=2GB

which should do the trick. However, I'm currently unsure where the discrepancy between df and plan quota for zfs comes from.  Because
zfs get quota zfs/dataset

shows the correct value.

hmm. might be - I didn't change anything about quota or refquota - just followed the tutorial by Stephan Graber: https://stgraber.org/2016/03/26/lxd-2-0-resource-control-412/
maybe he should add this info to zfs-setup or resource control...
Ok, but now I tried your commands - first of all:
root@leif ~ # lxc storage show default
config:
  source: zpool1/lxd
  zfs.pool_name: zpool1/lxd
name: default
driver: zfs
used_by:
- /1.0/containers/evolved-javelin
- /1.0/containers/from-alias
- /1.0/containers/generous-cheetah
- /1.0/containers/pleased-walrus
- /1.0/images/2373b6551aca33a1dca54b92b99083064c95dee9c5a845ea02b9be5e62a271a7
- /1.0/images/6978077ac9f8ef1aa8f0fdfe26c7e2d6bad6f597e4476675297ab39919fb8545
- /1.0/images/8fa08537ae51c880966626561987153e72d073cbe19dfe5abc062713d929254d
- /1.0/images/a221591e855f271769b3d780789c25d504b4062475c125f790b97d4afa0539f5
- /1.0/images/e20cb56bb0734d9533ce7f03f17ef1fdddb3a807390663b2d0d1cffa7fe89b9c
- /1.0/images/f06418beae2369211d7d61f326409a55289ba51b3ee27b1de4cc6a541a010596
- /1.0/profiles/default
´´´
don't know if this shows anything about the quota I used?!

but here the three other commands:
´´´
root@leif ~ # lxc config device unset evolved-javelin root disk size
root@leif ~ # lxc storage set default volume.zfs.use_refquota true
root@leif ~ # lxc config device set evolved-javelin root disk size=2GB
error: Invalid device configuration key for disk: disk
´´´
I think the last one should be:
´´´
lxc config device set evolved-javelin root size 2GB
´´´
(that worked)
´´´
root@leif ~ # zfs get quota zpool1/lxd/containers/evolved-javelin
NAME                                   PROPERTY  VALUE  SOURCE
zpool1/lxd/containers/evolved-javelin  quota     2G     local
´´´
so yeah, that shows really 2G
but now, when I try df inside the container it's again to much:
´´´
 lxc exec evolved-javelin df
Filesystem                            1K-blocks   Used Available Use% Mounted on
zpool1/lxd/containers/evolved-javelin   2689920 600832   2089088  23% /
none                                        492      0       492   0% /dev
udev                                     485132      0    485132   0% /dev/tty
tmpfs                                       100      0       100   0% /dev/lxd
tmpfs                                       100      0       100   0% /dev/.lxd-mounts
tmpfs                                    506848      0    506848   0% /dev/shm
tmpfs                                    506848   6464    500384   2% /run
tmpfs                                      5120      0      5120   0% /run/lock
tmpfs                                    506848      0    506848   0% /sys/fs/cgroup
´´´

what I gues is, that this 2GB only counts new data in the contianer... since this is a totally clean fresh created container maybe the MBs of the image itself, doesnt count to the containers quota!?!?

Btw:
I'm NOT using a whole zpool - i created several datasets in my zpool for different usages - and one of it is used for lxd  (called lxd) - with lxd init I said: use zpool1/lxd as storage and lxd then created all the other things:
zpool1/lxd/containers
zpool1/lxd/custom
zpool1/lxd/images
and so on...
but I think that shouldn't matter

LXD by default will use quota on zfs and use refquota when either zfs.use_refquota is set to true on the container's storage volume or when volume.zfs.use_refquota is set to true on the storage pool.

Ok, I think I don't get it working because of the history - I think first quota property must be deleted - only calling lxc config device unset evolved-javelin root disk size didn't remove the quota-property...
I now started from scratch:
root@leif ~ # lxc launch ubuntu:17.04
Creating pleased-skunk
Starting pleased-skunk

root@leif ~ # zfs get quota zpool1/lxd/containers/pleased-skunk
NAME                                 PROPERTY  VALUE  SOURCE
zpool1/lxd/containers/pleased-skunk  quota     none   default

root@leif ~ # lxc storage set default volume.zfs.use_refquota true
root@leif ~ # lxc config device add pleased-skunk root disk path=/ pool=default size=2GB
Device root added to pleased-skunk

root@leif ~ # zfs get quota zpool1/lxd/containers/pleased-skunk
NAME                                 PROPERTY  VALUE  SOURCE
zpool1/lxd/containers/pleased-skunk  quota     none   default

root@leif ~ # zfs get refquota zpool1/lxd/containers/pleased-skunk
NAME                                 PROPERTY  VALUE     SOURCE
zpool1/lxd/containers/pleased-skunk  refquota  2G        local

root@leif ~ # lxc exec pleased-skunk df
Filesystem                          1K-blocks   Used Available Use% Mounted on
zpool1/lxd/containers/pleased-skunk   2097152 600832   1496320  29% /
none                                      492      0       492   0% /dev
udev                                   485132      0    485132   0% /dev/tty
tmpfs                                     100      0       100   0% /dev/lxd
tmpfs                                     100      0       100   0% /dev/.lxd-mounts
tmpfs                                  506848      0    506848   0% /dev/shm
tmpfs                                  506848   6464    500384   2% /run
tmpfs                                    5120      0      5120   0% /run/lock
tmpfs                                  506848      0    506848   0% /sys/fs/cgroup

so now it works
great - thanks...
I think refquota would be a great additional information for St. Grabers Tutorial...
any idea how to fix the quota on the already running containers? how can the wrong quota-property be removed properly?

thanks a lot


Automatically load conda packages from the dependend julia packages

Hello,
I am starting to use PythonCall and CondaPkg more extensively. The setup looks awesomely analogous to how Julia packages are handled with Project.toml files.
However, while Project.toml files are resolved recursively in that the dependencies of the dependencies are also taken into account, CondaPkg does not seem to pick up the CondaPkg.toml from one of my loaded Packages.
Maybe I am just missing something.

EDIT:
my setup is very simple:

MyPackage has a CondaPkg.toml at top-level (with dill added as a dependency)
I am starting julia in the default v1.9 environment and hit using MyPackage, PythonCall; pyimport("dill")

I was now expecting that CondaPkg will load also the information from MyPackage/CondaPkg.toml. Instead I get the error
julia> pyimport("dill")
ERROR: Python: ModuleNotFoundError: No module named 'dill'
Python stacktrace: none
Stacktrace:
 [1] pythrow()
   @ PythonCall ~/.julia/packages/PythonCall/1f5yE/src/err.jl:94
 [2] errcheck
   @ ~/.julia/packages/PythonCall/1f5yE/src/err.jl:10 [inlined]
 [3] pyimport(m::String)
   @ PythonCall ~/.julia/packages/PythonCall/1f5yE/src/concrete/import.jl:11
 [4] top-level scope
   @ REPL[10]:1

CondaPkg only reads the CondaPkg.toml file from packages which actually depend on CondaPkg. So you need to Pkg.add("CondaPkg") in MyPackage.

Indeed I was only depending on PythonCall - awesome that this is already supported!

worked :smiley_cat:


Add vehicle hashes & missing input controls

Ah, i've forgotten to add new GameVersions.

Would you release v2.9.5? We don't have to update SHVDN to fix some issues caused by the last GTA update, but there are some benefit brought by updating ped & vehicle hashes.

Yeah, will do so later.


Release v1.0.0

Includes

https://github.com/burtcorp/omniauth-tiktok-oauth2/pull/10

@kristofferek You are the owner on RubyGems, so I guess you will have to do the actual release.

@stenlarsson Hi quick question, should I change both omniauth-oauth2 and omniauth-tiktok-oauth2 version to the exact same as well ? the url still got redirected into v1.2.
Sorry a newbie to rails here. Thanks


ZMQ server installation problem

Hello Dr White. I have a problem with the installation of ZMQ server. The "make streammq" seems to have a problem. I am sharing the error with you.
cc  -I.              -O3 -DNDEBUG -std=c11   -fPIC -pthread -mavx -mavx2 -mfma -mf16c -msse3   -c ggml.c -o ggml.o g++ -I. -I./examples -O3 -DNDEBUG -std=c++11 -fPIC -pthread -c whisper.cpp -o whisper.o g++ -I. -I./examples -O3 -DNDEBUG -std=c++11 -fPIC -pthread examples/streammq/streammq.cpp -lzmq examples/common.cpp examples/common-sdl.cpp ggml.o whisper.o -o streammq sdl2-config --cflags --libs /bin/sh: 1: sdl2-config: not found In file included from examples/streammq/streammq.cpp:7: ./examples/common-sdl.h:3:10: fatal error: SDL.h: No such file or directory     3 | #include <SDL.h>       |          ^~~~~~~ compilation terminated. In file included from examples/common-sdl.cpp:1: examples/common-sdl.h:3:10: fatal error: SDL.h: No such file or directory     3 | #include <SDL.h>       |          ^~~~~~~ compilation terminated.
Any help would be greatly appreciated. Thank you

You need to install SDL2 and libzmq to compile it - try doing a websearch on those because installing depends on your OS.


Keep Connected feature

Missing feature : checkbox with cookies (login+hash) to auto reconnect on private computers:)

great idea, can you leave a source doc for that?

English isn't my first language, so please excuse any mistakes
It's easy as :
When the user is authenticated, if the "auto login" checkbox is enabled, create two cookie, one with username and one with the DB password hash.
When user return on the website, if cookies are correct (same as db), autologin/create session like the standard process...
Any launch of new security process (change password...) re-ask the password and check the database.
On logout, delete the two cookie (and session...)
Pascal

https://codereview.stackexchange.com/questions/122130/remember-me-automatic-login

https://stackoverflow.com/questions/244882/what-is-the-best-way-to-implement-remember-me-for-a-website
488
down vote
accepted
Improved Persistent Login Cookie Best Practice
You could use this strategy described here as best practice (2006) or an updated strategy described here (2015):
When the user successfully logs in with Remember Me checked, a login cookie is issued in addition to the standard session management cookie.
The login cookie contains a series identifier and a token. The series and token are unguessable random numbers from a suitably large space. Both are stored together in a database table, the token is hashed (sha256 is fine).
When a non-logged-in user visits the site and presents a login cookie, the series identifier is looked up in the database.
    If the series identifier is present and the hash of the token matches the hash for that series identifier, the user is considered authenticated. A new token is generated, a new hash for the token is stored over the old record, and a new login cookie is issued to the user (it's okay to re-use the series identifier).
    If the series is present but the token does not match, a theft is assumed. The user receives a strongly worded warning and all of the user's remembered sessions are deleted.
    If the username and series are not present, the login cookie is ignored.

This approach provides defense-in-depth. If someone manages to leak the database table, it does not give an attacker an open door for impersonating users.

A paranoid implementation is not needed, KISS is better for this simple script.


collectd configuration

Hi! Your plugin looks very useful, but could you provide any documentation how configure it?

+1 3ks


[BUG] Unable to create or change a table without a primary key on migration

After installing django-rest-passwordreset==1.2.0 with django version 3.2 I added the following to my installed apps:
 INSTALLED_APPS = [
    'corsheaders',
    'django.contrib.admin',
    'django.contrib.auth', <------
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'rest_framework', <-----
    'rest_framework_simplejwt.token_blacklist',
    'django_elasticsearch_dsl',
    'django_rest_passwordreset' <---
]

After this I ran python manage.py migrate and I get the following error:
Running migrations:
  Applying django_rest_passwordreset.0001_initial... OK
  Applying django_rest_passwordreset.0002_pk_migration...Traceback (most recent call last):
  .
  .
  .
pymysql.err.OperationalError: (3750, "Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message.
Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting.")

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
 .
 .
 .
django.db.utils.OperationalError: (3750, "Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting.")

Looking at the code makes me think the order is wrong in:
django-rest-passwordreset/django_rest_passwordreset/migrations/0002_pk_migration.py
First add Id field with primary key before removing the existing primary key

I had this issue Yesterday and I have a suggestion that worked for me:
Go to the migrations file of your package, and add the following:
def get_migrations_for_django_21_and_newer():
return [
# this will enable you to change the table without primary keys, only for the migration db session
migrations.RunSQL("SET SESSION sql_require_primary_key=0;"),
# remove primary key information from 'key' field
migrations.AlterField(
model_name='resetpasswordtoken',
name='key’,…….


Update ws to v0.8 to not have build errros on iojs-v3.

I propose to bump to 2.0.1.

May I release this? @maxogden @mafintosh

:+1:

Done as 2.0.2.


IOException when writing to Websocket sink causes writing to fail forever

This change: [https://github.com/square/okhttp/commit/40a6dc7dd5ff6843b82f904516181182d512d0ca] contains these lines in public void sendMessage(RequestBody message):
    BufferedSink sink = Okio.buffer(writer.newMessageSink(formatOpcode));
    message.writeTo(sink);
    sink.close();

Perhaps rephrase as:
    BufferedSink sink = Okio.buffer(writer.newMessageSink(formatOpcode));
    try {
      message.writeTo(sink);
    } finally {
      sink.close();
    }

If an IOException is thrown here the sink will never close yet the websocket will remain in a valid state. This causes subsequent executions of writer.NewMessageSink(formatOpcode) to fail because the writer is still active.

If the IOException comes from writing to the underlying socket, the connection isn't in a good state, and calling close() will throw another IOException. If the IOException comes from obtaining the data (like reading from the FS, calling close() will finalize the incomplete message.
I think in both cases we try to should send a protocol exception to the server and fail the whole connection.


Correction for raw affiliation Ecole Normale Supérieure de Lyon, LADEC, FRE 2002 (CNRS, Lyon 2, ENS de Lyon), France

Correction needed for raw affiliation Ecole Normale Supérieure de Lyon, LADEC, FRE 2002 (CNRS, Lyon 2, ENS de Lyon), France
raw_affiliation_name: Ecole Normale Supérieure de Lyon, LADEC, FRE 2002 (CNRS, Lyon 2, ENS de Lyon), France
new_rors: 02feahw73;04zmssz18;000q6dn27
previous_rors: 02feahw73;04zmssz18
works_examples: W2903677528
contact: aaf05bf860a2da54721de3697d69c472:15eba5c9e384d4612c1b68f41559 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Highlight True and False as normal union types

Although other languages have special language keywords for true and false, Elm implements True and False as plain old union types. Highlighting them differently than (for example) Nothing or Result or Task subtly suggests they play by different rules than other union types, when they actually do not.
This PR makes the formatting consistent across union types by removing the special case for True and False, and also removes special highlighting for otherwise, as otherwise was removed from Core in 3.0.0. :smiley:

Thanks @rtfeldman!


HDFS-16324. fix error log in BlockManagerSafeMode

Description of PR
if recheckInterval was set as invalid value, there will be warning log output, but the message seems not that proper ,we can improve it.
How was this patch tested?
No need test cases, just update warning log.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 26s

trunk passed

+1 :green_heart:
compile
5m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
2m 22s

trunk passed

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 10s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 33s

trunk passed

+1 :green_heart:
shadedclient
21m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s

the patch passed

+1 :green_heart:
compile
5m 12s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 12s

the patch passed

+1 :green_heart:
compile
4m 40s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 34 unchanged - 0 fixed = 167 total (was 34)

+1 :green_heart:
mvnsite
2m  3s

the patch passed

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 50s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 37s

the patch passed

+1 :green_heart:
shadedclient
21m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 25s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
226m  6s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

352m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1500bb72bf63 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 93e21da8e1ee16ce52580927e2c40d2b43c1c271

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/1/testReport/

Max. process+thread count
3382 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut Could you kindly help verify, the test error seems not related with the patch.
[ERROR] testSetRepIncWithUnderReplicatedBlocks(org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks)  Time elapsed: 120.023 s  <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 120000 milliseconds 	at java.lang.Thread.sleep(Native Method) 	at org.apache.hadoop.fs.shell.SetReplication.waitForReplication(SetReplication.java:137) 	at org.apache.hadoop.fs.shell.SetReplication.processArguments(SetReplication.java:78) 	at org.apache.hadoop.fs.shell.FsCommand.processRawArguments(FsCommand.java:121) 	at org.apache.hadoop.fs.shell.Command.run(Command.java:179) 	at org.apache.hadoop.fs.FsShell.run(FsShell.java:327) 	at org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks(TestUnderReplicatedBlocks.java:80) 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 	at java.lang.reflect.Method.invoke(Method.java:498) 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) 	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) 	at java.lang.Thread.run(Thread.java:748)

@tomscut Could you kindly help verify, the test error seems not related with the patch. [ERROR] testSetRepIncWithUnderReplicatedBlocks(org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks) Time elapsed: 120.023 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 120000 milliseconds at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.fs.shell.SetReplication.waitForReplication(SetReplication.java:137) at org.apache.hadoop.fs.shell.SetReplication.processArguments(SetReplication.java:78) at org.apache.hadoop.fs.shell.FsCommand.processRawArguments(FsCommand.java:121) at org.apache.hadoop.fs.shell.Command.run(Command.java:179) at org.apache.hadoop.fs.FsShell.run(FsShell.java:327) at org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks(TestUnderReplicatedBlocks.java:80) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748)

Can you commit an empty commit to trigger the builder again?

@tomscut Could you kindly help verify, the test error seems not related with the patch. [ERROR] testSetRepIncWithUnderReplicatedBlocks(org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks) Time elapsed: 120.023 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 120000 milliseconds at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.fs.shell.SetReplication.waitForReplication(SetReplication.java:137) at org.apache.hadoop.fs.shell.SetReplication.processArguments(SetReplication.java:78) at org.apache.hadoop.fs.shell.FsCommand.processRawArguments(FsCommand.java:121) at org.apache.hadoop.fs.shell.Command.run(Command.java:179) at org.apache.hadoop.fs.FsShell.run(FsShell.java:327) at org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks.testSetRepIncWithUnderReplicatedBlocks(TestUnderReplicatedBlocks.java:80) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748)

Can you commit an empty commit to trigger the builder again?

sure, have just triggered

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 14s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 17s

trunk passed

+1 :green_heart:
compile
5m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m  0s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 25s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 37s

trunk passed

+1 :green_heart:
shadedclient
22m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s

the patch passed

+1 :green_heart:
compile
5m  7s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m  7s

the patch passed

+1 :green_heart:
compile
4m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  4s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 34 unchanged - 0 fixed = 167 total (was 34)

+1 :green_heart:
mvnsite
2m  8s

the patch passed

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  0s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 47s

the patch passed

+1 :green_heart:
shadedclient
21m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 27s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
222m 16s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

351m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 136a20c8307d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1ad22de0fa07253425a921d4478b965132771023

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/2/testReport/

Max. process+thread count
3456 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut  the tests rerun ok 💯   :)

cc @aajisaka @ayushtkn @goiri

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 35s

trunk passed

+1 :green_heart:
compile
6m 17s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 32s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
2m 26s

trunk passed

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 10s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 51s

trunk passed

+1 :green_heart:
shadedclient
23m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
5m 58s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 58s

the patch passed

+1 :green_heart:
compile
5m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 35 unchanged - 0 fixed = 168 total (was 35)

+1 :green_heart:
mvnsite
2m 10s

the patch passed

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 55s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  8s

the patch passed

+1 :green_heart:
shadedclient
22m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
244m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

379m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestReadStripedFileWithDNFailure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 026f667e1b42 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5cd7060fbab3b19ce8fd8599a2cade4023bbd42d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/4/testReport/

Max. process+thread count
3423 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 32s

trunk passed

+1 :green_heart:
compile
5m 49s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 57s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 30s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  8s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 58s

trunk passed

+1 :green_heart:
shadedclient
22m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s

the patch passed

+1 :green_heart:
compile
5m 50s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 50s

the patch passed

+1 :green_heart:
compile
5m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 12s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 35 unchanged - 0 fixed = 168 total (was 35)

+1 :green_heart:
mvnsite
2m 18s

the patch passed

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  1s

the patch passed

+1 :green_heart:
shadedclient
21m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
256m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

390m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestErasureCodingExerciseAPIs

hadoop.hdfs.TestFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f44b5678222b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5cd7060fbab3b19ce8fd8599a2cade4023bbd42d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/3/testReport/

Max. process+thread count
3164 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 15s

trunk passed

+1 :green_heart:
compile
5m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 55s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
2m 26s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 34s

trunk passed

+1 :green_heart:
shadedclient
22m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s

the patch passed

+1 :green_heart:
compile
5m  6s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m  6s

the patch passed

+1 :green_heart:
compile
4m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 35 unchanged - 0 fixed = 168 total (was 35)

+1 :green_heart:
mvnsite
2m  5s

the patch passed

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  2s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 42s

the patch passed

+1 :green_heart:
shadedclient
22m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 27s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
236m 41s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

364m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 31b6adf36406 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3f90c905237f881b79c8690ce7710e703c2d30d3

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/5/testReport/

Max. process+thread count
3380 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ping @aajisaka @ayushtkn any new ideas?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 36s

trunk passed

+1 :green_heart:
compile
5m 18s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 59s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
2m 24s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 39s

trunk passed

+1 :green_heart:
shadedclient
22m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s

the patch passed

+1 :green_heart:
compile
5m  9s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m  9s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 644 unchanged - 1 fixed = 645 total (was 645)

+1 :green_heart:
compile
4m 50s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 50s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 622 unchanged - 1 fixed = 623 total (was 623)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 101 unchanged - 0 fixed = 234 total (was 101)

+1 :green_heart:
mvnsite
2m  8s

the patch passed

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 57s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 43s

the patch passed

+1 :green_heart:
shadedclient
22m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 25s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
230m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

359m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 2314081aa367 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df966ea168cd9a0efa19d38e5ea16249570bf372

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/6/testReport/

Max. process+thread count
3525 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
19m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 29s

trunk passed

+1 :green_heart:
compile
5m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 30s

trunk passed

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 10s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 37s

trunk passed

+1 :green_heart:
shadedclient
22m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
5m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 46s

the patch passed

+1 :green_heart:
compile
4m 58s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 101 unchanged - 0 fixed = 234 total (was 101)

+1 :green_heart:
mvnsite
2m  3s

the patch passed

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 56s

the patch passed

+1 :green_heart:
shadedclient
22m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
228m 10s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

370m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0df3d7815963 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ad6bebf3f2624846cac32dd4c04d479e73e75761

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/7/testReport/

Max. process+thread count
3840 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanx @GuoPhilipse for the fix. have dropped a nit. Will commit once addressed.

Thanks @ayushtkn  for your careful review, have updated the code

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 59s

trunk passed

+1 :green_heart:
compile
5m 18s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 57s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
2m 32s

trunk passed

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 18s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  2s

trunk passed

+1 :green_heart:
shadedclient
22m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s

the patch passed

+1 :green_heart:
compile
5m 37s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 37s

the patch passed

+1 :green_heart:
compile
5m 37s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 10s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 134 new + 270 unchanged - 0 fixed = 404 total (was 270)

+1 :green_heart:
mvnsite
2m 20s

the patch passed

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  4s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  8s

the patch passed

+1 :green_heart:
shadedclient
22m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
238m 23s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

373m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5fbd1c63aaf4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0dfb81147dac3ebdc53b9074308b693ed1ed0cef

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/8/testReport/

Max. process+thread count
3199 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  0s

trunk passed

+1 :green_heart:
compile
6m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 46s

trunk passed

+1 :green_heart:
shadedclient
22m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 30s

the patch passed

+1 :green_heart:
compile
6m  2s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
6m  2s

the patch passed

+1 :green_heart:
compile
5m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 12s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 270 unchanged - 0 fixed = 403 total (was 270)

+1 :green_heart:
mvnsite
2m 13s

the patch passed

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 56s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 54s

the patch passed

+1 :green_heart:
shadedclient
22m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 27s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
237m 10s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

371m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 01fb56fca1b4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 06c21c8af047291a84efe16df89121e747afcbbe

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/9/testReport/

Max. process+thread count
3700 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 29s

trunk passed

+1 :green_heart:
compile
5m 17s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 57s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
2m 25s

trunk passed

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 37s

trunk passed

+1 :green_heart:
shadedclient
22m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  4s

the patch passed

+1 :green_heart:
compile
5m  8s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m  8s

the patch passed

+1 :green_heart:
compile
4m 49s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 270 unchanged - 0 fixed = 403 total (was 270)

+1 :green_heart:
mvnsite
2m  9s

the patch passed

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 55s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 51s

the patch passed

+1 :green_heart:
shadedclient
22m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
232m  2s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

362m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux b9ef98d2de94 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b92b7d63b616f2103b5d550f81a4540dbac42b22

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/10/testReport/

Max. process+thread count
3538 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 46s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m 56s

trunk passed

+1 :green_heart:
compile
5m 43s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
2m 35s

trunk passed

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 24s

trunk passed

+1 :green_heart:
shadedclient
24m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s

the patch passed

+1 :green_heart:
compile
5m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 48s

the patch passed

+1 :green_heart:
compile
5m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 18s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 133 new + 270 unchanged - 0 fixed = 403 total (was 270)

+1 :green_heart:
mvnsite
2m 22s

the patch passed

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 10s

the patch passed

+1 :green_heart:
shadedclient
24m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 29s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
227m  8s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

369m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3661

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5d2e06c05ecf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b92b7d63b616f2103b5d550f81a4540dbac42b22

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/11/testReport/

Max. process+thread count
3354 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3661/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Merged. Thank you @GuoPhilipse for your contribution and thanks @tomscut @ayushtkn for your reviews.


Make View Site button open website on new tab

Small improvement:  Make this link open website on new tab. It is often expected to do so.

Implemented #119


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.14.259",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=5ac3b68b79c9e964dd6f3cf80ff825518e502b79"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "5ac3b68b79c9e964dd6f3cf80ff825518e502b79",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "xen/blkfront: harden blkfront against event channel storms\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.259 by commit 5ac3b68b79c9e964dd6f3cf80ff825518e502b79. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002641


[Component Request] {Dropdown}

Can you please implement dropdowns similar to the Polymer ones?
https://elements.polymer-project.org/elements/paper-dropdown-menu?active=paper-dropdown-menu&view=demo:demo/index.html

Duplicate of select requests.
On Sep 30, 2015 4:40 PM, "onexerxes"<EMAIL_ADDRESS>wrote:

Can you please implement dropdowns similar to the Polymer ones?
https://elements.polymer-project.org/elements/paper-dropdown-menu?active=paper-dropdown-menu&view=demo:demo/index.html
—
Reply to this email directly or view it on GitHub
https://github.com/google/material-design-lite/issues/1671.

See #854


Do not create a slice of rest args when none are given

Artichoke provides a macro mrb_get_args! for native code which implements Ruby methods to retrieve arguments from the mruby VM's stack. mrb_get_args!(mrb, *args) instructs the macro to collect all arguments in a slice ("rest" arguments).
Detailed in #2691, recent nightly includes a new precondition check for std::slice::from_raw_parts which checks for the validity of the pointer and length arguments passed to it. The weekly fuzzer suite run in CI isolated the following Ruby code as triggering the assertion:
p

This code is Kernel#p when called with no args. The assertion emitted by the Rust runtime is:
thread 'main' panicked at library/core/src/panicking.rs:155:5:
unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
stack backtrace:
... snip ...
   5: core::slice::raw::from_raw_parts
             at /rustc/6cc4843512d613f51ec81aba689180c31b0b28b6/library/core/src/slice/raw.rs:98:9
   6: artichoke_backend::extn::core::kernel::mruby::kernel_p
             at ./artichoke-backend/src/extn/core/kernel/mruby.rs:69:16
   7: mrb_vm_exec
             at ./artichoke-backend/vendor/mruby/src/vm.c:1792:18
   8: mrb_vm_run
             at ./artichoke-backend/vendor/mruby/src/vm.c:1282:12
   9: mrb_top_run
             at ./artichoke-backend/vendor/mruby/src/vm.c:3112:12
  10: mrb_load_exec
             at ./artichoke-backend/mrbgems/mruby-compiler/core/parse.y:6918:7
... snip ...

When no arguments are passed, the mruby function mrb_get_args sets the args pointer to NULL and length to 0. The new Rust runtime precondition does not like the NULL being passed to from_raw_parts, so we guard against both conditions and return the constant empty slice.
I audited all other uses of std::slice::from_raw_parts and found them to be local to the string, symbol, and array oxidized MRB_API implementations, which are expected to be unsafe to call and requires the VM to ensure the various pointers are non-NULL.
This fix was validated with the following command:
RUST_BACKTRACE=1 RUSTFLAGS="-Z sanitizer=address" cargo +nightly run --bin artichoke --target x86_64-apple-darwin -- -e 'p'

Regressions will be caught by subsequent runs in the Fuzz CI (which uses nightly) and regular CI, once the current nightly (rustc 1.78.0-nightly (6cc484351 2024-02-10)) hits stable.
Fixes #2691.

It looks like this rustc PR is what flipped this assertion to "on":

https://github.com/rust-lang/rust/pull/120594

The fuzzer / nightly build passed with this merged https://github.com/artichoke/artichoke/actions/runs/7860310665
🎉 😅


Running error

May I ask if the following error occurs when I import kears and torch respectively? How can I solve it? Please help me, which is very important to me

Thank you for your patience. The Keras version is quite slow and not suitable for this complex optimization, while the Torch version is still a work in progress. However, the TensorFlow version has been successfully debugged and is working well. The new version of the QECO algorithm is now available and converges perfectly. QECO
Please give it another try, and feel free to share any feedback or insights you may have. @troubleliu


Add Balanced Accuracy

This adds a "balanced accuracy" metric and uses it to calculate scores for marc-ja and jnli. Specifically, it calculates the accuracy separately by class, then takes the average of those scores, weighted equally. This is important for very imbalanced datasets - mainly marc.
There may be other better metrics, but this is an improvement over the normal accuracy at the very least.

I added some more metrics. Failures are due to linter checks for code not changed in this PR and will need to be cleaned up later.


Change "Table of Contents" text based on language

Hi,
I'd like to write specs in Dutch, and using the include files only gets me so far. The bikeshed/boilerplate.py has some English text hardcoded into it, such as "Table of Contents".
Is there a way I can customize this text without having to fork? I read the Boilerplate sections in the docs but couldn't find an answer.
Thanks!
Bart

Hm, there isn't yet! That's definitely an oversight on my part, I'll go looking for all the hardcoded English in the output and make it customizeable.
(In addition to making them individually customizeable, I'll probably add an opt-in to just specify a language and have them all switch appropriately. Would you mind signing up for a Dutch localization? There shouldn't be more than a handful of phrases.)

Nice, thanks!
And yes, I'd be willing to help with that, no problem.

Okay, still experimenting with this, but it looks like using gettext is the way to go.
I've done a scan over the source and I think these are all the relevant strings that aren't W3C specific, 45 in total. Mind giving them a crack? Lmk if there's more context needed for anything so I can annotate that properly.
#: bikeshed/boilerplate.py:299
msgid "Index"
msgstr ""

#: bikeshed/boilerplate.py:313
msgid "Terms defined by this specification"
msgstr ""

#: bikeshed/boilerplate.py:324
msgid "Unnumbered section"
msgstr ""

#: bikeshed/boilerplate.py:329
#, python-brace-format
msgid "{type} for {forVals}"
msgstr ""

#: bikeshed/boilerplate.py:334
msgid "definition of"
msgstr ""

#: bikeshed/boilerplate.py:356
#, python-brace-format
msgid "in {spec}"
msgstr ""

#: bikeshed/boilerplate.py:358
#, python-brace-format
msgid "for {forVals}"
msgstr ""

#: bikeshed/boilerplate.py:514 bikeshed/boilerplate.py:525
msgid ", in "
msgstr ""

#: bikeshed/boilerplate.py:588
msgid "Terms defined by reference"
msgstr ""

#: bikeshed/boilerplate.py:608
msgid "Property Index"
msgstr ""

#: bikeshed/boilerplate.py:761
msgid "IDL Index"
msgstr ""

#: bikeshed/boilerplate.py:787
msgid "Table of Contents"
msgstr ""

#: bikeshed/boilerplate.py:1097
msgid "(non-normative)"
msgstr ""

#: bikeshed/boilerplate.py:1152
msgid "References"
msgstr ""

#: bikeshed/boilerplate.py:1162
msgid "Normative References"
msgstr ""

#: bikeshed/boilerplate.py:1187
msgid "Informative References"
msgstr ""

#: bikeshed/boilerplate.py:1215
msgid "Issues Index"
msgstr ""

#: bikeshed/boilerplate.py:1228
msgid "Jump to section"
msgstr ""

#: bikeshed/dfnpanels.py:45 bikeshed/dfnpanels.py:115
msgid "Referenced in:"
msgstr ""

#: bikeshed/dfnpanels.py:104
msgid "Unnumbered Section"
msgstr ""

#: bikeshed/metadata.py:75
msgid "Editor"
msgstr ""

#: bikeshed/metadata.py:75
msgid "Editors"
msgstr ""

#: bikeshed/metadata.py:124
msgid "(This is a tracking vector.)"
msgstr ""

#: bikeshed/metadata.py:129
msgid "There is a tracking vector here."

msgstr ""

#: bikeshed/mdn/mdnspeclinks.py:169
msgid "This feature is in all current engines."
msgstr ""

#: bikeshed/mdn/mdnspeclinks.py:320
msgid "In no current engines."
msgstr ""

#: bikeshed/mdn/mdnspeclinks.py:322
msgid "In only one current engine."
msgstr ""

#: bikeshed/mdn/mdnspeclinks.py:324
msgid "In all current engines."
msgstr ""

#: bikeshed/mdn/mdnspeclinks.py:356
msgid "Requires setting a user preference or runtime flag."
msgstr ""

#: bikeshed/wpt/wptElement.py:83
msgid "Test Suite"
msgstr ""

#: bikeshed/wpt/wptElement.py:122
msgid "Tests"
msgstr ""

#: bikeshed/wpt/wptElement.py:175
msgid "(live test)"
msgstr ""

#: bikeshed/wpt/wptElement.py:183 bikeshed/wpt/wptElement.py:195
#: bikeshed/wpt/wptElement.py:214
msgid "(source)"
msgstr ""

Nice! So I provide Dutch translations in the empty string positions in your quote? Here we go:
Translation remarks:

Some terms are very hard to translate correctly, i.e. preserving context and subtleties.  I've tried my best.
Sometimes I've deliberately kept the English term, such as for "Issue", since it seems a term that has a well-defined definition in context (with GitHub, but also another). Same goes for "Tracking vector". This keeps things searchable and language ubiquitous.
Some English words are more common to use in Dutch than their Dutch translation, such as "feature". I kept those.

It's probably not perfect, but hey, it's a start at worst :).
Thanks for picking this up so quickly. Any idea when this might be usable for me?
#: bikeshed/boilerplate.py:299
msgid "Index"
msgstr "Index"

#: bikeshed/boilerplate.py:313
msgid "Terms defined by this specification"
msgstr "Begrippen gedefinieerd door deze specificatie"

#: bikeshed/boilerplate.py:324
msgid "Unnumbered section"
msgstr "Ongenummerde sectie"

#: bikeshed/boilerplate.py:329
#, python-brace-format
msgid "{type} for {forVals}"
msgstr "{type} voor {forVals}"

#: bikeshed/boilerplate.py:334
msgid "definition of"
msgstr "definitie van"

#: bikeshed/boilerplate.py:356
#, python-brace-format
msgid "in {spec}"
msgstr "in {spec}"

#: bikeshed/boilerplate.py:358
#, python-brace-format
msgid "for {forVals}"
msgstr "voor {forVals}"

#: bikeshed/boilerplate.py:514 bikeshed/boilerplate.py:525
msgid ", in "
msgstr ", in "

#: bikeshed/boilerplate.py:588
msgid "Terms defined by reference"
msgstr "Begrippen gedefinieerd door referentie"

#: bikeshed/boilerplate.py:608
msgid "Property Index"
msgstr "Eigenschappenindex"

#: bikeshed/boilerplate.py:761
msgid "IDL Index"
msgstr "IDL index"

#: bikeshed/boilerplate.py:787
msgid "Table of Contents"
msgstr "Inhoudsopgave"

#: bikeshed/boilerplate.py:1097
msgid "(non-normative)"
msgstr "(niet-normatief)"

#: bikeshed/boilerplate.py:1152
msgid "References"
msgstr "Referenties"

#: bikeshed/boilerplate.py:1162
msgid "Normative References"
msgstr "Normatieve Referenties"

#: bikeshed/boilerplate.py:1187
msgid "Informative References"
msgstr "Informatieve Referenties"

#: bikeshed/boilerplate.py:1215
msgid "Issues Index"
msgstr "Issue Index"

#: bikeshed/boilerplate.py:1228
msgid "Jump to section"
msgstr "Ga naar sectie"

#: bikeshed/dfnpanels.py:45 bikeshed/dfnpanels.py:115
msgid "Referenced in:"
msgstr "Genoemd in"

#: bikeshed/dfnpanels.py:104
msgid "Unnumbered Section"
msgstr "Ongenummerde sectie"

#: bikeshed/metadata.py:75
msgid "Editor"
msgstr "Redacteur"

#: bikeshed/metadata.py:75
msgid "Editors"
msgstr "Redacteurs"

#: bikeshed/metadata.py:124
msgid "(This is a tracking vector.)"
msgstr "(Dit is een tracking vector.)"

#: bikeshed/metadata.py:129
msgid "There is a tracking vector here."
msgstr "Er is een tracking vector hier."

msgstr "Deze feature is aanwezig in minder dan twee huidige engines."

#: bikeshed/mdn/mdnspeclinks.py:169
msgid "This feature is in all current engines."
msgstr "Deze feature is aanwezig in alle huidige engines."

#: bikeshed/mdn/mdnspeclinks.py:320
msgid "In no current engines."
msgstr "In geen huidige engines aanwezig."

#: bikeshed/mdn/mdnspeclinks.py:322
msgid "In only one current engine."
msgstr "In slechts één huidige engine aanwezig."

#: bikeshed/mdn/mdnspeclinks.py:324
msgid "In all current engines."
msgstr "In alle huidige engines aanwezig."

#: bikeshed/mdn/mdnspeclinks.py:356
msgid "Requires setting a user preference or runtime flag."
msgstr "Vereist het instellen van een gebruikersvoorkeur of runtime flag."

#: bikeshed/wpt/wptElement.py:83
msgid "Test Suite"
msgstr "Testsuite"

#: bikeshed/wpt/wptElement.py:122
msgid "Tests"
msgstr "Tests"

#: bikeshed/wpt/wptElement.py:175
msgid "(live test)"
msgstr "(live test)"

#: bikeshed/wpt/wptElement.py:183 bikeshed/wpt/wptElement.py:195
#: bikeshed/wpt/wptElement.py:214
msgid "(source)"
msgstr "(bron)"

What is the status of this issue?

I would also love this to become part of the standard customization/configuration would can do.


[Bug]: Custom vector tiles server doesn't work

Mapbox Implementation
Mapbox
Mapbox Version
default
Platform
iOS
@rnmapbox/maps version
10.0.15
Standalone component to reproduce
import React from 'react';
import {View} from 'react-native';
import Mapbox, {MapView, MarkerView} from '@rnmapbox/maps';

Mapbox.setAccessToken('access_token');

const MapScreen = () => {
  return (
    <View>
      <Mapbox.MapView style={{ flex: 1 }} rotateEnabled={false} pitchEnabled={false}>
        <Mapbox.VectorSource id="custom-tiles" url='link-to url' existing={false} >
          <Mapbox.FillLayer id="customSourceFill"
            style={{
              fillColor: '#FF0000',
            }}
          />
        </Mapbox.VectorSource>
        <Mapbox.Camera
          centerCoordinate={[-74.00597, 40.71427]}
          defaultSettings={{
          zoomLevel: 14,
            centerCoordinate: [-74.00597, 40.71427],
          }}
        />
        <Mapbox.UserLocation showsUserHeadingIndicator />
      </Mapbox.MapView>
    </View>
  );
};

export default MapScreen;

Observed behavior and steps to reproduce
I attempted to connect to a custom vector tiles server using the tileJSON format, but encountered a Mapbox error - Mapbox error MapLoad error Failed to load tile: {"level": "error", "message": "MapLoad error Failed to load tile: "} Despite attempting to modify the tile URLs for various resources, I couldn't resolve the issue.
JSON file (it's available by actual link):
{
   "tilejson": "2.2.0",
   "tiles": [
     "https://a.tiles.mapbox.com/v4/mapbox.mapbox-streets-v6/{z}/{x}/{y}.vector.pbf?access_token=MY_TOKEN"
   ],
   "minzoom": 0,
   "maxzoom": 18,
   "name": "Mapbox Streets v8",
   "attribution": "© Mapbox",
   "format": "pbf"
}

Expected behavior
Custom server tiles connected and working as expected
Notes / preliminary analysis
No response
Additional links and references
No response

I've also been unable to get any vector tiles working, I can't find even a single example that works anywhere.

Sorry I cannot run this example, please use concrete url.
https://rnmapbox.github.io/docs/examples/FillRasterLayer/CustomVectorSource
https://rnmapbox.github.io/docs/examples/FillRasterLayer/ChoroplethLayerByZoomLevel

Is there an example that uses the tileUrlTemplates option like tileUrlTemplates={['https://example.com/vector-tiles/{z}/{x}/{y}.pbf']}

See https://rnmapbox.github.io/docs/examples/LineLayer/ThirdPartyVectorSource

Awesome thanks. I was able to figure it out using styling as well from this example


always build all frameworks

@nzain I'm experimenting with building net35 and net45 TFMs on all platforms.  Ideally this would have no negative effect in VS 2017, but I'd appreciate it if you could give this a shot to make sure I didn't break your workflow.
(This is, of course, assuming you still need net35 and net45 assemblies.)

Things have finally changed, we are moving more and more projects to netstandard or 4.7.2 including all DXF related projects. No need to support net35 for me. And I've got a VS2019 license... accidentally. If you want to keep the VS2017 hacks, I can test them if you like - but I'll uninstall it sooner or later.
Thank you for your consideration!

In that case I'll take this change as is, since it kind of gets rid of the VS 2017 specific stuff anyway.
I'll keep the net35 and net45 stuff for a bit longer, but eventually I'll consolidate the TFMs to just netstandard*, since net472 can consume netstandard2.0 and below.


Strapi 5 support?

Any plans for Strapi 5 support? Big fans of your plugin, but it's blocked due to https://github.com/ShahriarKh/strapi-content-type-explorer/blob/main/package.json#L22 currently

Hey! I haven't tried Strapi 5 yet, but I will take a look soon & see what changes are required so the plugin can run. BTW, feel free to open a pull request.


feat: divide

Coverage remained the same at 100.0% when pulling 805267f30806fb00bd1ccaee114481d206713253 on division into faccbb842cc1c50c02e4c3fe9512e4ecbc847524 on master.

Coverage remained the same at 100.0% when pulling 805267f30806fb00bd1ccaee114481d206713253 on division into faccbb842cc1c50c02e4c3fe9512e4ecbc847524 on master.

Coverage remained the same at 100.0% when pulling b04f21d62d0e41ec8be521448bbefe6ae07b2c37 on division into faccbb842cc1c50c02e4c3fe9512e4ecbc847524 on master.