Add --pull-timeout flag to crictl create, run and pull commands

What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows to set a pull context timeout for the supported commands. Runtimes may or may not use the timeout from the RPC for image pulls, but crictl should generally support that feature.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added `--pull-timeout` flag to `crictl` `create`, `run` and `pull` commands.

LGTM

Runtimes may or may not use the timeout from the RPC for image pulls

Should we make it a part of critest? Not sure how we will test the behavior, but at least runtime should stop processing and exit when requested.

Runtimes may or may not use the timeout from the RPC for image pulls

Should we make it a part of critest? Not sure how we will test the behavior, but at least runtime should stop processing and exit when requested.

Yes, I added a critest case for that.


[W7.7][T11-B3] Mobilize

Hi @raisa2010 @eryao95 @tby1994 @tpq95 ,
Friendly reminder, if you want me to review your collated code, remember to tag me in your collated code PR.


Beta release of Harvest API v2 support

Hi @dlo, is there potential to arrange a beta release of the Harvest API v2 python-harvest?
v2_dev currently supports all actions on all entities, the modern authentication paradigm (eg; OAuth2, including refresh tokens in some circumstances), rate limiting and uploading receipts to expenses.
I am using much of the library for an integration but would like to start opening it up to others.
Cheers

Have updated the README.md

An FYI: I'm putting this code into UAT today.

Hey @dlo Is there anything I can do to help get this off the ground?

Sorry about the delay @Brad-eki! Here we go: https://pypi.org/project/python-harvest-redux/5.0.0b0/

Thanks Dan!!!!
Really appreciated.
And also deep gratitude from my accountant :D

:)


Local groups not saved

I recently noticed that the local group settings we make for the inclusion or exclusion of users from the FSLogix processes are being reset back to default after a reboot of the servers.
It does not seem to be an known issue as reported on the FSLogix articles
https://learn.microsoft.com/en-us/fslogix/troubleshooting-known-issues
I was wondering if others have noticed this as well, and if so, what they did to fix it.

FSLogix doesn't control local groups or their members. I would check that some other process or policy isn't removing those members.


Code of Conduct link have been moved.

The old link: https://engineering.twitter.com/opensource/code-of-conduct (can be found from README file)
The new link: https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md

On 06/11/2017 04:17 AM, Elias Ojala wrote:

The old link: https://engineering.twitter.com/opensource/code-of-conduct
(can be found from README file)
The new link:
https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md

Hmmm, I'm not declaring a git repo to be toybox policy. (If they think
it's going to change often enough to need version tracking, I'm dubious.)
I fished the old one out of archive.org and mirrored it on the website
(it's CC with attribution but the link to their git repo at the bottom
should cover that). And move the link to it from the README to the nav bar.
Thanks for the heads up,
Rob

fixed by https://github.com/landley/toybox/commit/bc308973ffb671084328da6e20f146cba1454466 and can be closed.

Closing.


command line test tool

It'd be nice if there was a cli tool that I could pass an URL, and it would dump the extracted microformats.
Goal would be to have tool to quickly debug potential parsing problems.

Just something dirty here, when I have the time I will turn it into something I can commit as a CLI client which gets installed with the gem or something.
#!/usr/bin/env ruby

require 'microformats2'
require 'uri'
require 'net/http'
require 'openssl'
require 'json'

def get_source_html(source_uri)
        uri = URI.parse source_uri
        http = Net::HTTP.new(uri.host, uri.port)
        http.use_ssl = uri.port == 443
        http.verify_mode = OpenSSL::SSL::VERIFY_NONE
        request = Net::HTTP::Get.new(uri.request_uri)
        begin
                return http.request(request).body
        rescue => e
                puts "Webmention error: #{e}"
        end
end

unless ARGV[0].nil?
        html = get_source_html(ARGV[0])
        collection = Microformats2.parse(html)

        puts JSON.pretty_generate(JSON[collection.to_json.to_s])
else
        puts "usage: mf2.rb URL"
end

@jeena When you have time to write up something proper (and write some docs in the README), feel free to push it into master. 👍🏻🚀

Closing this issue as a new command line tool 'microformats' has been added in the latest release.


example: Revert ssh Ignition config change

Users try to use the latest reference example clusters with
a bootcfg v0.3.0 deployment, which did not yet support Ignition
2.0.0. Wait until closer to v0.4.0 to bump Ignition configs.

Closes #192


Settings for old spaces don't show up.

https://snapshot.org/#/uniswap/settings
Seems like settings aren't accessible for spaces that haven't been set up with an ENS domain.
Isn't it possible to migrate those spaces? Maintaining backwards compatibility is probably more work.

@bonustrack can you shed some light on this. I thought we already changes all existing spaces to ENS

@samuveth We don't, to do the migration we need to contact these spaces and show some notice on the UI. I've ever recommended Uniswap to change to ENS without success.

My first thought was that migration should maybe be enforced at some point, with a notice on the UI. "Old space setups are deprecated. Please move to an ENS setup until ....". But then I was struggling to see what benefits it really has. To my understanding signatures for votes and proposals is all it needs from the technical side. Everything else should be focused on providing the best possible user experience. Feels like the ENS approach stands in our way a little bit in that regard.


import JS on component

Hi,
on the example you have on repo, I cannot import a javascript file on component
( component/home.vue ).
component/home.vue in detail :
<script>
import general from '../general.js';

export default {
  data() {
    return {
      title: 'Home',
    }
  },
}
</script>

the error is

Uncaught TypeError: Failed to resolve module specifier "../general.js". Invalid relative url or base scheme isn't hierarchical.

even I use ./general.js and add the file near the component still is not resolved..
any solution ?
[edit]
the same happens with you would like to import a vue sub component as
import CountriesDetail from './CountriesDetail.vue';

v0.2.0 has been released and now supports relative url import.
https://github.com/kianfang/vue-import/pull/4

see
https://github.com/pipiscrew/DBManager

@kianfang v<IP_ADDRESS> fixes some nasty issues


Dockerfile with VOLUME instruction fails to build

buildah version 0.1 (image-spec 1.0.0-rc5, runtime-spec 1.0.0-rc5) from buildah-0.1.0-2.git597d2ab.fc26.x86_64
Dockerfile fails to build:
FROM busybox
RUN echo "a" > /a
VOLUME /b
CMD ["cat", "/a"]

$ buildah --storage-driver overlay2 bud --tag test/03:buildah /home/vrutkovs/src/image-comparison/tests/03
STEP 1: FROM busybox
STEP 2: RUN echo "a" > /a
STEP 3: VOLUME /b
time="2017-06-19T19:40:19+02:00" level=error msg="error building: error building at step {Env:[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:volume Args:[/b] Flags:[] Attrs:map[] Message:VOLUME /b Original:VOLUME /b}: stat /var/lib/containers/storage/overlay2/cf989ed6334eeb5a90874264c960220306577d7a07d0d0a48ff933d8ff272d7d/merged/b: no such file or directory"

Since this patch got merged this issue should be fixed.


Remove providerhub package

This package is now empty as of release 0.40.0 so we can remove it.
Closes https://github.com/Azure/typespec-azure-pr/issues/4039

oh I never pushed that, was left pending in my branch...

/azp run

/azp run

/azp run


Add SwiftyGPIO

A Swift library for hardware projects on Linux/ARM boards with support for GPIOs/SPI/I2C/PWM/UART/1Wire.
Project URL
https://github.com/uraimo/SwiftyGPIO
Category
Other Hardware
Description
A Swift library for hardware projects on Linux/ARM boards with support for GPIOs/SPI/I2C/PWM/UART/1Wire.
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[ ] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@vsouza @dkhamsing @lfarah: Shall we add it awesome-iOS list?
It seems to be not related iOS since it was written for Linux as per my understanding.


How to  Do Gherkin Page Objects Integration

Hi All,
How we can create / do page object integration in Gherkin and how we can work with or create tags in Gherkin. Can you give me a brief how to do these above issues/tasks
Regards,
PraveenMSV

Please use the support forums for questions and discussions. We use GitHub issues to track bugs and contributions exclusively.


Gettin' whalloped by arbitrary GCP Secret replacements

What happened?
Ran Pulumi for the first time in a bit.  Got mostly some workable updates, but ended up getting hit by this once for every secret in my secret manager:
++gcp:secretmanager/secret:Secret: (create-replacement)
        [id=SOMESECRET]
        [urn=urn:pulumi:SOMESECRET]
        [provider: urn:pulumi:whatever::whatever::pulumi:providers:gcp::default_6_67_0::GUID => urn:pulumi:whatever::whatever::pulumi:providers:gcp::default_7_7_0::GUID]
        replication: {
            automatic : true
        }
        secretId   : "SOMESECRET"
    +-gcp:secretmanager/secret:Secret: (replace)
        [id=SOMESECRET]
        [urn=urn:pulumi:whatever::whatever::gcp:secretmanager/secret:Secret::SOMESECRET]
        [provider: urn:pulumi:whatever::whatever::pulumi:providers:gcp::default_6_67_0::GUID => urn:pulumi:whatever::whatever::pulumi:providers:gcp::default_7_7_0::GUID]
        replication: {
            automatic : true
        }
        secretId   : "SOMESECRET"

I also had to set up this boilerplate for my secret instances, or else pulumi would crash with some exception saying that it was missing:
                var secret = new Secret(secretId, new()
                {
                    SecretId = secretId,
                    Replication = new SecretReplicationArgs
                    {
                        Auto = new SecretReplicationAutoArgs(),
                    },
                });

Output of pulumi about
❯ pulumi about
CLI
Version      3.103.1
Go Version   go1.21.5
Go Compiler  gc

Host
OS       fedora
Version  39
Arch     x86_64

Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @atrauzzi. I'm sorry you're seeing this.
I believe that this is a duplicate of https://github.com/pulumi/pulumi-gcp/issues/1488.

@atrauzzi We are working on this problem now. In the mean time, I would recommend pinning the provider to v6.67.0. The issue is caused by upgrading between major versions of gcp.

If you were feeling particularly ambitious, you could edit the version string in your state file (pulumi stack export | edit | pulumi stack import). I'm not 100% sure that it will work, but I think there is a >70% chance.


styling-the-system-bars sections includes code that won't compile: Color.Transparent

Had to update Color.Transparent to val transparentColor = LocalContext.current.resources.getColor(android.R.color.transparent)
https://composeunstyled.com/modal-bottom-sheet/#styling-the-system-bars

there is no mention of Color.Transparent in the link you shared. do you mean Color.TRANSPARENT?

yep. just checked it is indeed Color.TRANSPARENT

ooh. TIL of .toArgb. Thanks!


New release with macos support

It would be great if you can push a new release since #3 introduces macos support

Having a health issue at the moment, and I also don't have a laptop atm.
So I'm afraid it won't be a new release in the near future

Having a health issue at the moment, and I also don't have a laptop atm. So I'm afraid it won't be a new release in the near future

No problem. Take care of yourself.


Space efficient choice dictionary

Update choice dictionary with a space efficient variant.
Add Iterator class to be used to iterate through existing choice dictionaries.

 Can you merge it please.

Should be merged now.

Is it possible to set a bit to "0" in the choice dictionary?
I can only see a .set(idx) function, not something like .unset().


Singleplayer savegames

AFAIK, in Sauerbraten you have to play through missions in one go - there is no savegame.
I don't know about the map format in specific and if there are things that can be modified on the go during gameplay. If we want to offer a nice gaming experience, we should also allow users to save and load games.
What are the technical requirements in regard of inexor flex/tree?
Do we already store the player information somehow, that we could also persist?
How are savegames saved?
Are they attached to the map, or can there be various savegames per map?
What about multiplayer missions, if you want to play together through a map and then save at that point for each individual player to load again later.

I imagine it like that:
You have a multiplayer campaign. (You only have multiplayer campaigns. Sure, one could play them alone on a local server in case you want "single player")
When playing, the state is in the Tree (containing i.e. the "game/"-node and its subnodes like "players" or "mapname").
Savegames are hence only a serialization of the Tree into a file.
How this could be combined with the map informations is indeed pretty interesting. In fact, the map informations are also only a part of the Tree.
So this issue could be related to #200: the map in a specific branch is your "savegame"! E.g. you just load a version of the map with all doors already triggered.
Very interesting idea indeed.


Remove redundant code

This just simplifies the code sample a little bit by removing some unnecessary conditions and an unused native method.

@drewnoakes : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @drewnoakes
Merging per email from @j-martens


FEATURE: DNS Server switch

Would be good if you could switch DNS servers in Napture, which can be good for some "private" dns servers and possibly even alternative dns servers, so there's a option for the main server and a 2nd option to enter a URL (for the alternative server idea, you can even use the /domains endpoint to sync, i did test if you can do this by writing a WebX dns server in python and flask and with requests im synced with the main server)

just noticed issue number 69


Updated URL for PyQ.

We’ve resolved this now, haven’t we? If you agree, let’s scrap the PR.

@StephenTaylor-Kx -- I didn't check after submitting this PR. Looks like you did. Thanks, closing.

Thanks for the catch. Are we there now?
Stephen
Stephen Taylor | Librarian | Kx | +44 7713 400852 |<EMAIL_ADDRESS>On 25 July 2017 at 17:13, Aleks Bunin<EMAIL_ADDRESS>wrote:

@StephenTaylor-Kx https://github.com/stephentaylor-kx It seems you made
the change in the repository, but did not deploy the change to the
code.kx.com. Let's keep this open until you deploy. As a workaround we
added redirect, but in the future, redirect might be removed and I'd like
to avoid 404 errors.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/KxSystems/docs/pull/9#issuecomment-317787575, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT2hgAErDWnEeJh9Hctlbo5OFLGLH1jsks5sRhQ2gaJpZM4N7yp3
.


Calico dynamic routing vs static routes

Hello,
I was wondering what are the drawbacks of using static routes instead of calico.
I mean i've discussed with my collegue of the network team :

we could provisonne several /24 subnets and configure static routes to a given number of nodes.
Let's say we'll never reach 20 nodes on a datacenter.
we'll use the default docker networking.
This solution would be a bit simpler than dynamic routing.

Does it make sense ?
What are the advantages/drawbacks of using calico ?
Regards,
Smana

If you are deploying at low scale then static route provisioning (rather than using BGP) can work fine.  You would obviously lose the ability to move a workload from one location to another one without changing it's IP.  (You might want to do this if for example you want to use Flocker to move database container from one location to another.)
We've done demos of running Calico in static routing mode in the past, and could potentially work with you to get such support added natively into calicoctl.
The advantage of using Calico in such a scenario:

Calico's policy engine can still be used to secure your containers.
You avoid port mapping and NAT involved in Docker's "default" networking mode, which reduces deployment and operational complexity.  (Port mapping is generally considered to be painful once you get above small numbers of containers, and many people would say this is not as straightforward to manage as static or dynamic routing with Calico).
You avoid needing on/off ramp style NAT if you are using Docker's "overlay" networking, which similarly reduces operational complexity.

If you don't care about any of those advantages, then using Docker's default network is a sensible enough thing to consider and we certainly wouldn't advocate you should use Calico if it gives you no advantages for your particular planned deployment and use cases.
Hope that makes sense.  Feel free to ask follow-up questions.

Ok, thank you i'll do benchmarks in order to compare the performances given the overhead caused by the port mapping of the default docker networking.


[New game]:  Guess  The Shape Game

🎮 Game Request
Game logic and basic description:

This project is built on a basic web tech stacks such as HTML, CSS and Javascript.
This is a single-player game.

Point down the features
Game points

Displaying the current score of the player.
Implementing a graphical user interface (GUI) for a more interactive experience.
Adding a background music so that user will not bored from the game as this game is for minded people.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @codewithganeshhh , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#3178

Hey @codewithganeshhh ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @codewithganeshhh !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


CB-11073 Appium tests stability improvements

https://issues.apache.org/jira/browse/CB-11073

This is a re-creation of https://github.com/apache/cordova-plugin-camera/pull/202


jquery.min.js

Hi there -- I am investigating the use of secure-headers on our site but have hit a problem with regards the enabling of CSP.
We see the following:
Refused to apply inline style because it violates the following Content Security Policy directive: "style-src 'self' 'unsafe-inline' 'unsafe-eval' data: https: 'nonce-NmY3M2YwOTQ5MmQyOTEyMg==' 'nonce-MzQ5Y2RmNzhhMDdkNTRmMw==' 'nonce-MzBlMzg0YmZhN2MzNjk5Ng==' fonts.gstatic.com ajax.googleapis.com code.jquery.com googletagmanager.com google-analytics.com s3.eu-west-2.amazonaws.com cdnjs.cloudflare.com ajax.googleapis.com maxcdn.bootstrapcdn.com unpkg.com google.com cdn.jsdelivr.net gitcdn.github.io checkout.stripe.com fonts.googleapis.com code.ionicframework.com data:". Note that 'unsafe-inline' is ignored if either a hash or nonce value is present in the source list.
which points to our self-hosted jquery.min.js file.
We do not face any other issues and CSP works fine for other script and styles.

Would appreciate any help or pointers.
Thanks

This is not related to jquery.min.js.
The error says 'unsafe-inline' was ignored because you had used nonce in your style-src directive.


Update certificate-rotation.md

The '-text' does not output the expire date.
Changed from '-text' to '-noout -enddate'.

@tamram
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@jacobbaek - Thanks for making that fix!
#sign-off


WFCORE-6765 Schema version comparison should require compatible stability level

https://issues.redhat.com/browse/WFCORE-6765
It's become clear to me that schema namespace comparisons should be stability-aware.
See jira for details.

Thanks @pferraro


Fix the issue with the incorrect logic for creating a new branch

Fix the issue that cannot switch to Daily Branch due to incorrect logic for determining the existence of the daily branch and creating a new one.

@YangZeCN Package is Released. https://github.com/NEVSTOP-LAB/SimpleGit-Provider/releases/tag/v2023.12.11


Add JDBC Storage Support

This is the inital work towards ARTEMIS-27, adding Database storage support in Artemis.
This is not yet finished, I'm opening this PR so people can start looking at the solution.
There are still several areas that need to be completed (firstly this patch needs rebasing on top of master), I'll also split this up into functional commits.  This patch currently only adds support for journal persistence in JDBC, Paging and Large Messages still use regular files.
So far, only Derby embedded DB has been tested.  See /home/mtaylor/dev/activemq-artemis/artemis-server/src/test/resources/database-store-config.xml for an example of how to configure the database store.
Also, look at the /home/mtaylor/dev/activemq-artemis/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/persistence tests for lower level examples.

you will have to rebase this,,, there are a lot of conflicts

lol @clebertsuconic pls read the comment above

I have tried to merge this by squashing your committs and I couldn't figure out how to do it.
I will do this after you squash these commits and make this ready to commit.
you should probably also include the JIRA as part of these commits?


[BUG] Commands shouldn't need @BotKube prefix if posted as DM to BotKube user

Describe the bug
It feels kind of weird to add @BotKube prefix in the commands when posting as direct message to BotKube
Expected behavior
BotKube should serve commands with or without @BotKube prefix if posted as DM

Same behaviour observed on Mattermost integration. Reopening the issue

has this actually be solved or do I need to perform additional Slack configuration? it responds to at least ping but most other commands appear ignored.

INFO[2021-04-12T23:25:53Z] Invalid request. Dumping the response. Request: help
INFO[2021-04-12T23:26:42Z] Invalid request. Dumping the response. Request: notifier status
INFO[2021-04-12T23:27:40Z] Invalid request. Dumping the response. Request:  notifier status

I tried with tag: v0.12.0 and also tried on -latest. (I got a friendly warning for doing that too!)


fuzz: HTTP/1 fuzzer corpus and improved coverage.

Also cleanup nit with enum class for HTTP version, correctly handle multiple streams with H1 and
improve debuggability.
The corpus was generated by hand, using coverage and whitebox knowledge of http1/codec_impl.cc to drive test case creation.
Risk level: Low
Testing: codec_impl_fuzz_test and coverage. We have 93.5% coverage of HTTP/1 and 80.7% of HTTP/2 for
the corpus (before any fuzzing happens). HTTP/2 coverage is hampered by metadata.
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

@mattklein123 done. I'm afraid to admit this was just done by sheer manual effort, staring at the code and coverage reports and copying/modifying test cases until the base corpus coverage looked good (> 90%, remaining cases should be catcheable by fuzzers).
Ultimately we could extract some of this from unit tests eventually, or even real traffic, but this seems a reasonably good starting point.


Make JeoMojo accept xslt transformations.

We have to add an ability to add xslt transformations directly to JeoMojo.

This issue is rather questionable since we don't need to pass xslt to the plugin. It might be useful only for tests purposes. So I think, it makes sense to implement this issue only when it will be needed.

We decided that applying xsl transformations is out of the scope of the jeo repository, so I close this issue.


Add local docker-compose deployment

Currently, there is no any way to run BadgerDoc in local environment without k8s.
This task is to create single docker-compose file, which may run BadgerDoc with all dependencies locally
What must be done:

[x] Single configuration file for all microservices  (PR https://github.com/epam/badgerdoc/pull/448)
[x] Single docker-compose file for all microservices and dependensies (PR https://github.com/epam/badgerdoc/pull/448)
[x] Front-end (@khyurri)
[x] Documentation: how to setup local environment

Microservices

[x] Annotation (#701)
[x] Users (PR https://github.com/epam/badgerdoc/pull/448)
[x] Assets (@khyurri )
[x] Convert (@spiridonovfed) PR https://github.com/epam/badgerdoc/pull/699
[x] Processing (@khyurri)
[x] Jobs (@khyurri)
[x] Taxonomy

Postponed

[ ] Pipelines (postponded)
[ ] Scheduler (postponed)
[ ] Models (postponed)
[ ] Search (postponed)

All required services were migrated.


Bump TF to 2024-01-24 nightly

Also bump torch-mlir to 10acea7 to pick up fixes.
#16173

torch-mlir was bumped again hour ago. I'll see what the presubmits say here (image at least updated and uploaded).

I think you probably need to cherry-pick this commit: https://github.com/shark-infra/torch-mlir/commit/65f75ab7124fa000433aab2709553ec91a22fdde
Or wait for torch-mlir repo until they bump llvm and fix the issue.

I'll try picking that one.

I can't push to shark-infra so can't update the LLVM instance to reapply the TOSA change to allow this to pass. Will need someone to push that and give a rev to use. Or just push an update to submodule on this branch.

I dropped the revert and push it to shark-infra.

oh, it looks like I need to help bump torch-mlir submodule as well

I bump torch-mlir to https://github.com/llvm/torch-mlir/commit/28c7051ceb5a49944dfbd0d1fdf1ada4ac2a5b9e which includes a recent local fix in IREE.

unused variables again... I'm not going to fix that in torch-mlir repo. Let's bump to what we have and I will cherry-pick the local fix.
/work/third_party/torch-mlir/lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp:2620:13: error: unused variable 'zeroList' [-Werror,-Wunused-variable]
      Value zeroList = rewriter.create<PrimListConstructOp>(


Click javascript events not firing? dispatchEvent seems to not work

The javascript executor does not seem to launch the click event. But when I run the same javascript directly via dev tools it opens the new page correctly.
I would expect the "test" search results to show, but they do not.
I tried several approaches without success and  started to wonder if its a bug or a limitation with HtmlUnit or the driver not correctly processing the javascript.
Not sure if I should open the issue in or in the webdriver repo, can re-open if it is not in the correct location.
package seleniumHtmlunit;

import org.openqa.selenium.JavascriptExecutor;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.htmlunit.HtmlUnitDriver;

import com.gargoylesoftware.htmlunit.BrowserVersion;
import com.gargoylesoftware.htmlunit.WebClient;
import com.gargoylesoftware.htmlunit.javascript.SilentJavaScriptErrorListener;

public class Test {

	public static void main(String[] args) {

		WebDriver webDriver = new HtmlUnitDriver(BrowserVersion.FIREFOX, true) {
		    @Override
		    protected WebClient modifyWebClient(WebClient client) {
		        final WebClient webClient = super.modifyWebClient(client);
		        webClient.getOptions().setCssEnabled(false);
		        webClient.getOptions().setJavaScriptEnabled(true);
		        webClient.getOptions().setDownloadImages(false);
		        webClient.getOptions().setThrowExceptionOnScriptError(false);
		        webClient.setJavaScriptErrorListener(new SilentJavaScriptErrorListener());

		       return webClient;
		    }
		};

		duckDuckTest(webDriver);
		webDriver.close();

	}

	private static void duckDuckTest(WebDriver webDriver) {
		webDriver.get("https://duckduckgo.com/");
		JavascriptExecutor js = (JavascriptExecutor) webDriver;
		String script = "var search = document.evaluate(\"//input[@id='search_form_input_homepage']\", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;\r\n"
				+ "search.value=\"test\";\r\n"
				+ "\r\n"
				+ "const event = new MouseEvent('click', {\r\n"
				+ "    view: window,\r\n"
				+ "    bubbles: true,\r\n"
				+ "    cancelable: true\r\n"
				+ "  });\r\n"
				+ "var cb = document.evaluate(\"//input[@id='search_button_homepage']\", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;\r\n"
				+ "\r\n"
				+ "cb.dispatchEvent(event)";
		js.executeScript(script);

	}

}

This is the javascript:
var search = document.evaluate("//input[@id='search_form_input_homepage']", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
search.value="test";

const event = new MouseEvent('click', {
    view: window,
    bubbles: true,
    cancelable: true
  });
var cb = document.evaluate("//input[@id='search_button_homepage']", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;

cb.dispatchEvent(event)

You can wait for a condition such as
(new WebDriverWait(webDriver,30)).until(ExpectedConditions.presenceOfElementLocated(By.xpath("//span[normalize-space()='The name test is reserved by the Internet Engineering Task Force in RFC 2606 as a domain name that is not intended to be installed as a top-level domain in the global Domain Name System of the Internet for production use.']")));

and it fails. It never reaches the next page, clicking the search button by firing off the click event.

HtmlUnit works like expected
public static void main(String[] args) throws Exception {
    String url = "https://duckduckgo.com/";

    // no special setup required for this sample
    WebClient webClient = new WebClient(BrowserVersion.FIREFOX);

    // open DuckDuckGo homepage
    HtmlPage page = webClient.getPage(url);

    // dump page content
    // System.out.println("#### ---- ");
    // System.out.println(page.asText());
    // System.out.println("#### ---- ");

    // fill the search field
    HtmlTextInput search = (HtmlTextInput) page.getElementById("search_form_input_homepage");
    search.type("HtmlUnit");

    // press the search button
    page.getElementById("search_button_homepage").click();

    // wait a bit for the js to do the async work
    webClient.waitForBackgroundJavaScript(4_000);

    // the window content (the whole page) gets replaced by js (maybe by setting the location)
    // we have to update our page reference to point to the new page (content)
    page = (HtmlPage) page.getEnclosingWindow().getEnclosedPage();

    // done
    System.out.println("#### ---- ");
    System.out.println(page.asText());
    System.out.println("#### ---- ");
}

Sorry i'm a bit short of time today - you have to do the same with the web driver. From my point of view there is no need to do sophisticated js magic to trigger events.
The key point here (as in many other cases) is the replacement of the page by another one - and your code has to get the current page content from the window.
Please try with HtmlUnit Driver and give me a sign if you need more support.

Thanks for the quick reply. I resorted to this javascript workaround as the page I am accessing, which I can not share, is not responding to Selenium clicks and I need to fire an event to make it work.
This has worked when sideloading a javascript via a proxy and triggering it in Firefox, but could not get it running via HtmlUnit and its web driver.
Do you see a way to make the javascript work, either in HtmlUnit or via its HtmlUnit driver and the selenium js executor?
I will try accessing the webclient directly, but I am afraid that might not work the same way a selenium click does not work. Plus it exposes the low level stuff where ideally one should only need to make calls via the WebDriver to be able to switch browsers later and keep the lower level domain of the browser hidden.
Is there a limitation in the javascript implementation in Rhino that it can't fire dispatchEvent correctly?

Ok, think a found at least one reason for this - will require some days to fix because i fear i have to write a bunch of tests for all our event implementations.

Hi @skyhirider, made the first commits for this problem. If the build  is green, i will build a new snapshot. Please check at twitter.
Some background: The problem here is the line
event = new MouseEvent('click',

The first parameter was ignored and as a result the event dispatcher has not forced the click handling.
So far i have done a bunch of fixes for the MouseEvent impl but i have to fix all the other event classes also.
Will be great if you can test the new snapshot (as soon as it is available :-) and please provide feedback.

I tried including htmlunit 2.45.0-SNAPSHOT and the snapshot driver 2.45 but my duckduckgo test fails still.
Took me a few minutes to set up as the instructions on your sourceforge page (https://htmlunit.sourceforge.io/) reference  which according to what I was able to quickly find is used for building, not when downloading dependencies?  Or can it be used for getting snapshots as well?
I used this to set up a repository so that I could get the library.
	<repositories>
		<repository>
			<id>sonatype-nexus-snapshots</id>
			<url>https://oss.sonatype.org/content/repositories/snapshots</url>
			<releases>
				<enabled>false</enabled>
			</releases>
			<snapshots>
				<enabled>true</enabled>
			</snapshots>
		</repository>
	</repositories>

Strange, this works here
public static void main(String[] args) {

    WebDriver webDriver = new HtmlUnitDriver(BrowserVersion.FIREFOX, true) {
        @Override
        protected WebClient modifyWebClient(WebClient client) {
            final WebClient webClient = super.modifyWebClient(client);
            webClient.getOptions().setCssEnabled(false);
            webClient.getOptions().setJavaScriptEnabled(true);
            webClient.getOptions().setDownloadImages(false);
            webClient.getOptions().setThrowExceptionOnScriptError(false);
            webClient.setJavaScriptErrorListener(new SilentJavaScriptErrorListener());

           return webClient;
        }
    };

    duckDuckTest(webDriver);

    (new WebDriverWait(webDriver,30))
        .until(ExpectedConditions.presenceOfElementLocated(By.xpath("//*[contains(text(),'GUI-Less browser for Java programs')]")));

    System.out.println("++++++++++++++++++");
    System.out.println(webDriver.findElement(By.tagName("body")).getText());
    System.out.println("++++++++++++++++++");

    webDriver.close();

}

private static void duckDuckTest(WebDriver webDriver) {
    webDriver.get("https://duckduckgo.com/");
    JavascriptExecutor js = (JavascriptExecutor) webDriver;
    String script = "var search = document.evaluate(\"//input[@id='search_form_input_homepage']\", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;\r\n"
            + "search.value=\"HtmlUnit\";\r\n"
            + "\r\n"
            + "const event = new MouseEvent('click', {\r\n"
            + "    view: window,\r\n"
            + "    bubbles: true,\r\n"
            + "    cancelable: true\r\n"
            + "  });\r\n"
            + "var cb = document.evaluate(\"//input[@id='search_button_homepage']\", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;\r\n"
            + "\r\n"
            + "cb.dispatchEvent(event)";
    js.executeScript(script);
}

You are right. I was waiting for text that was not showing when running the test via htmlunit, specifically the wikipedia snippet.
You were fast in fixing this.

Great - a new release is planned for the weekend....

I am curious how you implemented this. The private test case is still failing, but when running the javascript directly via a browser it works. And I just finished writing this as you closed it, great timing :)

check for the changes in the MouseEvent class here https://github.com/HtmlUnit/htmlunit/commit/d8ef295a22d1497918b13d68286d86b60e4e3eb9


Cut a new release

Since Wayland window name functionality was just added, which is the only thing keeping me from using Alacritty for everything, I'd like to ask for a release to be cut so it can show up downstream.
PS. Show up on IRC @chrisduerr !

A new release is planned either this weekend or next weekend, depending on how the latest features behave. Since the #2045 PR changed quite a bit of things, I might hold off with a release until next week. Though I will consider your specific issue.
Also note that I should be reachable in #alacritty on freenode 24/7 and I usually am also around in the #rust/#rust-beginners channels on mozilla.

Thanks @chrisduerr!


Simplify client and add ability to request raw http response

My main reason for making changes here is that I wanted the ability to access the raw http response just to confirm that there's no information missing (as the New Twitch API is still under development).
The best way I could see of gaining access to that raw data was to refactor the client so that more of the responsibility for constructing the response in the Response object.
To get access to raw data, add with_raw: true to the Twitch::Client.new() call.
NB: these changes against the dev branch.

This looks useful, I'll review it soon. I do have doubts on whether to keep this permanently, but it might be for the best - I'm also considering making the raw get/post/put methods public as well for this reason..
I'll actually finalize the code for extra endpoints in the dev branch separately from this (the initialize methods for the recent data models)

Ok you can go ahead and rebase/tweak the changes, I'll make it part of the upcoming release.

OK, the pull request is now rebased upon your latest dev branch.

Alright good to go.


Docs mention to use latest node version, but the module does not work on node 19

The docs mention to use the latest node version
Node version 10.x is currently still supported but may be deprected in the future. We highly recommend upgrading to the latest version.

But the module does not work on node 19.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5b5392af-90b9-8dbb-663d-9ea12defe00e
Version Independent ID: 54296020-8b98-ea17-7915-5b918b173793
Content: Automated publishing for continuous integration and delivery - Azure Data Factory
Content Source: articles/data-factory/continuous-integration-delivery-improvements.md
Service: data-factory
Sub-service: ci-cd
GitHub Login: @nabhishek
Microsoft Alias: abnarain

@Willem-J-an
Thanks for your feedback! We will investigate and update as appropriate.

@Willem-J-an
Thanks for your feedback! We have assigned the issue to author and will provide further updates.

@nabhishek
could you please review this and update as appropriate.

Thanks for your dedication to our documentation, @Willem-J-an. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


feat: CO-7212: Webapp - improve Tooltip and Banner accessibility

What:

Why:

How:

Checklist:

[ ] Documentation
[ ] Tests
[ ] Ready to be merged

need QA on webapp repo, post result we can decide whether need this mr or not.

no longer required.


Fastnlight: Watch frn085664

Fastnlight requests the watch of the watch_keyword frn085664. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

frn085664 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


EDGEPOD-372:Context Not found error handling for TAU, Service Request…

This activity involves the following changes:
1.Inclusion of componentDb (to eliminate the use of extern MmeIpcIf*)
2.Handling of UeCtxtNotFound error in DDN, Service Request and TAU
3.Context Manager Crash Fixes

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

retest this please


Dash/plotly webapp skeleton + metadata work

I started a PR with a skeleton of the dash/plotly webapp, and some work on the Metadata tab.
The app is structured as a multi-page app. To execute it, run python app.py and click on the generated URL. The idea is that the tabs (i.e., app pages) reflect the steps in the pipeline (metadata, ROI definition, pose estimation and data visualisation in dashboard).
For the metadata tab, I included a mock project in the 'sample_project' directory, which contains the metadata from 10 wasp videos and a mock project config file. For now, the functionality is quite simple: first the user uploads a config file for the project of interest, which contains the path to the videos (and metadata) directory. Then the metadata (yaml files) in this directory is read and formatted as a table for inspection.
Possible next steps:

adhere to the yaml metadata approach described by @niksirbi here
add a button/other functionality to add metadata for videos in the selected folder which don't have an accompanying metadata file

maybe a button that adds a row for each video without a metadata file, then the user can edit them in the table and save this info as separate metadata.yaml files
potentially also add the option to edit existing metadata entries

draft the ROI definition tab following the Dash Image Annotations guidelines

Codecov Report

Merging #26 (1b880d7) into main (f48a544) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           main     #26   +/-   ##
====================================
  Coverage      0   0.00%
====================================
  Files         0       1    +1
  Lines         0       5    +5
====================================
- Misses        0       5    +5

Impacted Files
Coverage Δ

wazp/__init__.py
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Great job @sfmig ! I am very impressed with how few lines of code are needed for generating this multi-page app.
I took the liberty of adding dependencies and resolving the annoying flake8 and mypy issues that were causing the checks to fail.
In terms of future improvements, I agree that including the ability to manually edit the table would be extremely useful (however not critical for the MVP).
I would recommend merging this PR first (incorporating as many or as few of my suggestions as you want), and opening a separate PR for the ROI drawing tool

tests pending and I guess a few other improvements, but I think enough to have a decent skeleton in main


TokenRenewerAsync not safe

It is undocumented that System.Threading.Timer is used for the token renewal process.  This means any exception thrown while attempting to renew a token will bring down your entire service without a try catch within the renewer delegate.
It would be worth calling this out as we have seen flakiness in MSI which has allowed the initial token retrieval to succeed while the renew failed, bringing down everything with it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3dc128b-0ee5-1344-0034-2fce6960daa4
Version Independent ID: b2499482-1101-4937-7f34-ad7b9fd9fdc4
Content: Authorize access to blobs and queues with Azure Active Directory and managed identities for Azure Resources - Azure Storage
Content Source: articles/storage/common/storage-auth-aad-msi.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@jstutson Thanks for your question. We are checking on this and will respond to you soon.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Further problems with this Timer approach.  User's must be extremely careful to control the number of instances of TokenCredential to the expensive thread and memory cost of Timer().  Why doesn't this just refresh the token reflexively on use rather than constantly having to run as a timer thread in the background.
Furthermore, even if I do try/catch my Timer logic to avoid an full application domain crash what do I return?  I've got to give the TokenCredential class back some value.  What if I'm using a cached singleton of my StorageCredential to avoid too many Timer threads?  Now I need some way to invalidate the cache because the refresh has failed to get a new value.  Or i need to have the timer thread retry indefinitely until it gets a token.  Making this safe just requires a lot of seemingly unnecessary orchestration overhead.

@jstutson - Thanks for your feedback. I have updated this article to use the new Azure Identity client library, together with the Azure Storage v12 client library. Both of these libraries are in preview, but will be generally available soon.
The new library offers a much simpler approach to retrieving a token credential and is the path Microsoft is taking going forward for authorizing requests with an MSI.
There isn't much documentation for it yet, but it should be coming soon. In the meantime, if you want to use the new library and you have any issues with it, contact us here and we'll connect you with the engineering team who's working on it.

#please-close

Thanks for the reply and glad to hear that auth for different Azure resources is moving in a more consolidated direction.
Consumers need complete transparency on token expiration and the renewal process (if this is provided for us.)
Once the BlobContainerClient is created, those credentials are locked in.  It's not clearly documented what the intended lifetimes are of these clients or what their cost of construction is.  If it's expensive, then we're incentivized to keep instances around for longer.  If it's extremely cheap, then I should probably be making a new reference on almost every request to ensure that I always use the latest expiration-aware-cached credential.  That is, unless this new credential object is doing token refresh for me while caching to avoid too many requests to the MSI token provider (and on the watch of the main thread making the blob request).
If BlobContainerClients are expensive and editing their credential object is threadsafe then I could have a singleton StorageCredential which I trigger token refreshes on from a main thread.  But no written guarantees of thread safety there.
I don't think I can make use of preview packages now with our release so near and without this detailed information.  In the meantime, I'll be using TokenCredential without using the auto renew Timer()...  I'll be doing the expiration caching myself, but now my BlobContainerClient lifetimes are much more tied in to the lifetime of the StorageCredential object I construct them with.  :(


[FEATURE] Global Dark Mode Toggle

Is your feature request related to a problem? Please describe.
My feature request isn't related to a problem but more of an additional feature/functionality. I think it would be really cool if the site in general had a dark mode toggle. Either one that works globally across the entire site or across components individually.
Describe the solution you'd like
I would like to contribute if possible by adding a global dark mode toggle at the top right of the site, which looks for any tailwind classes marked with dark: and then if that goes well add dark mode variants to some components..
Describe alternatives you've considered
I was thinking of either Global Dark mode, which can perhaps be placed at the top right of the website, built with a nice slider, which applies it globally across the whole site and also each component, or at a component level where each one can have a dark mode toggle, but would like to know your thoughts on this.
Additional context
Add any other context or screenshots about the feature request here.

Hi, @rohitbulusu thanks for your thoughts on this. Sadly, this is unlikely to make it into HyperUI at the moment due to not all components having a dark mode variant which will cause confusion for users.


Fix edge case bug where grayscale image has an alpha channel, minor rtd fix

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Linked issues

#1312

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 74.262%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ivadomed/loader/segmentation_pair.py
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
4677

Relevant Lines:
6298

💛  - Coveralls

This PR is mostly ready for review, except for a test (and test image?) that we should add to cover line 377 which was the original bug source/fix.

Idk why but it currently feels like a script to me rather than a module.

@kanishk16 not quite sure what you mean by this, is it because multiple steps aren't combined anymore? Personally, I prefer clarity at the cost of a few more lines, but I would really like this PR merged ASAP to help out our user in #1310 start training their data.
Are the changes you suggested mostly style preferences, or do you think they'll impact the performance? If it's the first part, can we push this through so the code becomes functional again now, and then open a new issue to discuss these stylistic details for this block of code?
If this isn't  compromise you're willing to agree to, then I'd suggest we revert all the changes and use my single line bug fix for expediency: https://github.com/ivadomed/ivadomed/pull/1313/commits/340295de00a7c7f17ded6217c4640adaf0efcd06

There's actually a second user currently wanting to do training using these datasets (the other one posted directly to ADS: https://github.com/axondeepseg/axondeepseg/discussions/783), so this PR is fairly high priority to get merged ASAP.

@kanishk16 @joshuacwnewton  I just reverted to my initial solution https://github.com/ivadomed/ivadomed/commit/340295de00a7c7f17ded6217c4640adaf0efcd06, because as I was doing the refactoring requested after @kanishk16 's point-by-point suggestions I noticecd that it simply was just converging back to this old code. The only additional change I maddewas the omission of the pointless "is_batch*.
Let me know if this is good for you

More or less, the assert statements would not be required

Side note: I agree that the assertions definitely weren't required.

 Thoughts on assertions

I like adding assertions as a way of clarifying the internal state of the code to anyone reading it. (Basically, testing the assumptions we're making about internal state. The assertions should be relevant mainly to developers, but generally should never be seen by users.) In other words, the assertions should never fire if our assumptions are correct? But, if our assumptions are incorrect (as they were with grayscale+alpha images), then the code will fail in an unambiguous way to make debugging easier.
As a specific example, over in SCT, we've started using assertions whenever there is a bare else: case:
# Anti-pattern: We assume that argument will be either option_1/2, but what if it isn't?
# Code will continue then probably crash at some unintuitive line of code
if argument == "option_1":
   pass
elif argument == "option_2":
   pass

# Slightly better: All cases are handled thanks to 'else:'
# However, the internal state is now ambiguous -- what is the value of 'argument' inside the 'else:'?
if argument == "option_1":
   pass
else:
   pass

# Preferred by SCT: All cases handled *and* assumptions + internal state are both clear
# If assumptions are correct, assertion statement will do nothing
# If assumptions are false, then the code will fail in a clear/unambiguous way
if argument == "option_1":
   pass
else:
   assert argument == "option_2", f"Unexpected value for argument: {argument}"
   pass

I think it might just be a personal style thing -- when I write code, much like my writing in general, I tend to be pretty verbose? :sweat_smile:

Out of all the comments, maintaining a flat hierarchy is significant as it usually improves performance and in the case of training large data, this could become relevant...

I guess in all this I forgot to ask one important ques, do we want to add the test img to this PR?

I guess in all this I forgot to ask one important ques, do we want to add the test img to this PR?

Yup! Just did in that repo, will restart the tests now to see if there is increased coverage

We'd have to cut a release for it and add the new release tag here:
https://github.com/ivadomed/ivadomed/blob/4c95d013680ccc3cc1d96a88422e023e6027bcb1/ivadomed/scripts/download_data.py#L26
Let me know if you want me to cut a release!

Ah gotcha - right, that's the same workflow we have in ADS. I just did it, let see how the tests go!

Line 357 got hit per the coverage report

Merging - thanks for the help @joshuacwnewton and @kanishk16 !

Thank you @mathieuboudreau, for all the patience while I stalled the PR & @joshuacwnewton for helping along.

I'd learn smthg.

I like adding assertions as a way of clarifying the internal state of the code to anyone reading it. (Basically, testing the assumptions we're making about internal state. The assertions should be relevant mainly to developers, but generally should never be seen by users.) In other words, the assertions should never fire if our assumptions are correct? But, if our assumptions are incorrect (as they were with grayscale+alpha images), then the code will fail in an unambiguous way to make debugging easier.

I completely agree with the above idea regarding assertions, but ... let's tackle it as per the case:
# Anti-pattern: We assume that argument will be either option_1/2, but what if it isn't?
# Code will continue then probably crash at some unintuitive line of code
if argument == "option_1":
   pass
elif argument == "option_2":
   pass

On point! ✔
# Slightly better: All cases are handled thanks to 'else:'
# However, the internal state is now ambiguous -- what is the value of 'argument' inside the 'else:'?
if argument == "option_1":
   pass
else:
   pass

✔
# Preferred by SCT: All cases handled *and* assumptions + internal state are both clear
# If assumptions are correct, assertion statement will do nothing
# If assumptions are false, then the code will fail in a clear/unambiguous way
if argument == "option_1":
   pass
else:
   assert argument == "option_2", f"Unexpected value for argument: {argument}"
   pass

This is where I feel assertion isn't the right way to go... WDYT about this:
if argument == "option_1":
   pass
elif argument == "option_2"
   pass
else:
  raise ValueError(f"Unexpected value for argument: {argument}")

...
# some in-place operations on argument
...
# now use assert to clarify the internal state before using it for some other operations

I think it might just be a personal style thing -- when I write code, much like my writing in general, I tend to be pretty verbose? 😅

Nah, I didn't mean in that sense...  think about it this way... pretty much in ivadomed there were too few comments, and suddenly, there's code along with comments...
I like your writing style, and I'd like to believe being verbose is your strength that brings your thoughts alive ❤


Base image missing the Idris2 api package

To Reproduce

base image does make install here https://github.com/joshuanianji/idris-2-docker/blob/0cd066eaabfdbe6919f779db3c621ba51c4ab951/base.Dockerfile#L44

make install  installs these packages

install: install-idris2 install-support install-libs

https://github.com/idris-lang/Idris2/blob/main/Makefile#L188

building a library such as idris2-python against the base image fails  with

required idris2 any but no matching version is installed

the missing dependency is

depends = idris

https://github.com/madman-bob/idris2-python/blob/main/idris2-python.ipkg#L5

this bug can be resolved by installing the api package

make install-api

Expected behavior
base image should explicitly install api  package

Thank for the detailed issue! I'll add a `make install-api

Hey @kamweti, merged a PR that should fix it. Can you check that ghcr.io/joshuanianji/idris-2-docker/base:latest works for you?

looks good, thanks!
closing the issue now.


Add decoratedText prop to DecoratorComponent

Resolves #140 and #68.
Tested with console.log(this.props.decoratedText) in render method of TokenSpan in entity.html.

Seems okay. :+1: I still have that gut feeling that we should expose the styles somehow but I don't know the best way. I guess we'll wait for a use case!

We could do that at some point, though decorators should really just use this.props.children to render the text contents, including styled ranges. Otherwise they'll risk breaking the expected SelectionState-to-DOM mapping.

@facebook-github-bot import

Yeah, I ran into that last night too when I accidentally rendered the raw text instead of the children.


Amount of lines shown in IE/Firefox is 1 less than clamp prop value

This component is working well for me in Chrome/Safari, but when I test in Firefox (for Mac) or IE11, it is truncating after 1 line instead of 2 when I have a clamp set to 2. In the meantime, I am using browser detection to add 1 to the clamp value when in either of those two browsers, but a fix would be ideal.

@kkwiatkowski #11 did not fix this issue. Do you have any ideas what would cause it? Thanks for adding IE and Firefox support!

@thomasbottonari I also experienced this issue on a project I am working on. It was caused by the line-height not being equal to the height of the block. I would suggest increasing the line-height on the block so that the following is true. line-height * lines = height

@CezaryDanielNowak can we have a new release after #11 ?

+1 IE/Firefox unstable

I caugth it. Dotdotdot work well in one case. I use it in creacct class and it work well. When I included it in simple function it didn't work.

+1 IE/Firefox not work(
@Muskos can you please provide example when Dotdotdot works for you?

@ogirniak I create component  like this.
class Content extends React.Component { 	render() { 	       return ( 			<div> 				<Dotdotdot clamp={2}> 					{content.title} 				</Dotdotdot> 			</div> 		) 	} }

Unfortunately it's not working for me, but maybe the reason is that I'm trying to do it inside ag-grid

I had the same issue. In my case I set the clamp value to 3, but in Edge and FF show only 2 lines. IE 11 and other browsers showed 3 lines. I had my CSS line height set in em. Changed the line height unit to px and all browsers started working fine.

I had the same issue FF and IE show only 1 lines,
{contentTitle}

For me it works only if I add style with line-height on :
const styles = theme => ({
itemLine: {
lineHeight: '22px',
},
})

    some text

For me it works in FF only if I add style with line-height on Dotdotdot:
const styles = theme => ({
  itemLine: {
    lineHeight: '22px',
  },
})

<Dotdotdot clamp={1} className={classes.itemLine}>
  <Typography className={classes.itemLine}>
    some text
  </Typography>
</Dotdotdot>

Any updates on this, guys? I have the same issue as @nikita-zadorin, and it is only fixed with line-height set to 1.

Seems this issue was fixed in version 1.3.1
https://github.com/CezaryDanielNowak/React-dotdotdot#changelog

round line-height value from computed float value - IE11 fix

I don't face this issue anymore.


Build failure: freecad

Steps To Reproduce
Steps to reproduce the behavior:

CD into local copy of nixpkgs
nix build .#freecad

Build log
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'freecad-0.21.2'
         whose name attribute is located at /nix/store/lcf0d86snh87wj5b7f5ij4y6z30kqj99-source/pkgs/stdenv/generic/make-derivation.nix:332:7

       … while evaluating attribute 'buildInputs' of derivation 'freecad-0.21.2'

         at /nix/store/lcf0d86snh87wj5b7f5ij4y6z30kqj99-source/pkgs/stdenv/generic/make-derivation.nix:379:7:

          378|       depsHostHost                = elemAt (elemAt dependencies 1) 0;
          379|       buildInputs                 = elemAt (elemAt dependencies 1) 1;
             |       ^
          380|       depsTargetTarget            = elemAt (elemAt dependencies 2) 0;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: Package ‘shiboken2-5.15.11’ in /nix/store/lcf0d86snh87wj5b7f5ij4y6z30kqj99-source/pkgs/development/python-modules/shiboken2/default.nix:54 is marked as broken, refusing to evaluate.

       a) To temporarily allow broken packages, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_BROKEN=1

          Note: When using `nix shell`, `nix build`, `nix develop`, etc with a flake,
                then pass `--impure` in order to allow use of environment variables.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowBroken = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowBroken = true; }
       to ~/.config/nixpkgs/config.nix.

Additional context
Since shiboken2 is marked as broken for Python 3.12 and above (because distutils was removed), freecad wont build.
shiboken2 was marked as broken with #314968
Notify maintainers
@viric @gebner @AndersonTorres
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.7-zen1, NixOS, 24.11 (Vicuna), 24.11.20240703.9f4128e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.4`
 - nixpkgs: `/nix/store/dk2rpyb6ndvfbf19bkb2plcz5y3k8i5v-source`

Add a :+1: reaction to issues you find important.

Sidenote: This only happens now, because only very recently python3 was updated to default to 3.12 instead of 3.11. So manually making sure to use 3.11 instead should fix this.


Content - Track funded proposals milestones

In the last Town hall there was the question "Is there a website to track the milestones of funded proposals?" and Dor commented that this would be a perfect community contribution ( https://youtu.be/Pjg_u7Oeel0?t=5546 ) and that IdeaScale would gladly feed the data. I was thinking of doing a separate website, but maybe this place is already the perfect place to setup a "funded projects tracker". I would like to help (I am a developer myself) if you guys like the idea.
I think there are several massive advantages to this feature, it would bring massive amounts of transparency, checks to the funded projects, and the internal and external communities could get excited about what is going on in Cardano Catalyst.

This is a part of a bigger plan to track proposal. Something to explore once we are funded.  Thank you for your input.

FrancoAra's idea/proposal is a separate initiative to perform a separate function. Endorsed by IOG  as such (in the linked TH segment). It is not and should not be linked with another proposal intended for a different (limited) purpose.
The "Track funded proposals milestones" should continue as an initiative on its own, not prematurely subsumed under the landing page initiative.
The comment that, "This is part of a bigger plan to track proposal. Something to explore once we are funded"  is misleading (maybe seen as presumptuous at best - empire-building at worst).
Implying, by way of GitHub comment, that the FrancoAra proposal is already fait accompli subsumed into a be-all, do-all functionality under the landing page team (essentially one person's management). That is certainly mission creep.
No, for now this is a separate proposal. Unrelated to the Landing Page f4 or Community website f5 proposals. It is incorrect to suggest otherwise.
If, over time, the community wants to put all information under the control of a very limited group, so be it. But for now, allow each idea, initiative to seek its own identity, personality.
In theory, diversity of ideas and opinions will deliver a better solution than ideas generated by a very small group.
On its own, that landing site proposal has problems which should not encumber FrancoAra's idea.
Some examples may illustrate those problems.
The recent comment refers to a "bigger plan" and "if we are funded."
Whose "Bigger Plan"?
Who are "we"?
If the "Bigger Plan" and "We" refers to a Project Catalyst landing page, the original idea was great! That "landing page" (now a website) was commissioned with the limited imprimatur to provide information relating to "on-boarding" newcomers. The proposal describes the site as
cardanocataly.st Community Page
A central place for new and existing community members of Project Catalyst to find information, make connections, obtain guides."
That's all. Keep it as that limited scope.
Holding general information about Catalyst is one thing. Aggressively concentrating project proposal information becomes a bit like google or facebook with respect to data.
Already there are many potential issues with an external group owning access to community information.
For example.
Ownership of the domain cardanocataly.st is hidden.
Domain Name: cardanocataly.st Registrar: ST Registry Name Server: junade.ns.cloudflare.com
Name Server: martha.ns.cloudflare.com
Status: serverTransferProhibited Updated Date: 2021-04-29
cardanocataly.st
registrant-organization: GDPR protected
registrant-name: GDPR protected (GDPR protected)
registrant-street: GDPR protected
registrant-city: GDPR protected
registrant-state: GDPR protected
registrant-zip: GDPR protected
registrant-country: SE
registrant-phone: GDPR protected
registrant-fax: GDPR protected
registrant-email: GDPR protected
admin-organization: GDPR protected
admin-name: GDPR protected (GDPR protected)
admin-street: GDPR protected
admin-city: GDPR protected
admin-state: GDPR protected
admin-zip: GDPR protected
admin-country: SE
admin-phone: GDPR protected
admin-fax: GDPR protected
admin-email: GDPR protected
tech-organization: GDPR protected
tech-name: GDPR protected (GDPR protected)
tech-street: GDPR protected
tech-city: GDPR protected
tech-state: GDPR protected
tech-zip: GDPR protected
tech-country: SE
tech-phone: GDPR protected
tech-fax: GDPR protected
tech-email: GDPR protected
billing-organization: GDPR protected
billing-name: GDPR protected (GDPR protected)
billing-street: GDPR protected
billing-city: GDPR protected
billing-state: GDPR protected
billing-zip: GDPR protected
billing-country: SE
billing-phone: GDPR protected
billing-fax: GDPR protected
billing-email: GDPR protected
nameserver: junade.ns.cloudflare.com
nameserver: martha.ns.cloudflare.com
If the f4 and f5 proposals are not funded, what will happen to access to the website?  Already there are multiple links to this website, within the official Cardano information resources. Mis-informaation can be injected by "never-cardano" elements, which we know exist.
The f4 proposal was submitted by 4 persons, requesting $10,000. The f5 landing page proposal is submitted by 3 persons. With the Lead developers having left the team, f5 is a team of two technical, one managerial.
Is that team already (or does it plan to become) a corporate entity? If so, in what jurisdiction?
The proposal envisions:'employing a librarian for 3 months," "engaging a team of design consultants" and paying bounties. What happens at the end of 3 months?
Surely there will be a follow on proposal, but not mentioned.
If that proposal is not funded what happens to the admin passwords for the site? Will the site be abandoned? What happens to the domain name ownership? Or is the community locked into supporting the site forever?
The f4 proposal requested $8,000 for bounties and $2000 for work already done by 4 community members (work done initially as volunteers). f5 proposal is asking to fund a manager ($2,000), a librarian ($6,000) and to "engage" a team of design consultants ($3,000). Plus pay bounties ($10,000). For a total of $21,000.
If both proposals are funded are the bounties doubled?
The proposal mentions translators for several languages, is there a cost?
Are "we" (the team requesting funds for the landing page) an entity?
A company? Registered in what jurisdiction?
Who will "employ" the librarian?
In what jurisdiction will the librarian be "employed"? (For matters of compliance such as withholding tax, labor laws, et. al.) Not simple when you drill down.
What formal qualifications must the librarian have to serve in this capacity?
Who "chooses" the librarian?" (Will that person be a related party? A member of the team?)
Who employs the librarian"?
How is the librarian paid?
What are the librarian's authorities and limitations? (The librarian could have significant impact on the community, if empowered to censor.)
To whom is the librarian responsible for his/her actions? Who can override the librarian's actions?
Who can terminate the librarian's employment.
Who will actually distribute (pay) bounties? At what rate? For what purpose?
Salaries and bounties will paid from what jurisdiction? (One team member is domiciled in Russia, one in Estonia and the third in an unidentified EU country.)
A steering committee is mentioned. Seemingly the three persons making the proposal. Are others invited to join the steering committee?
These and other issues are illustrative of reasons why it may not be wise for the community to put all its eggs in one basket.

Thank you Len for your comments. The information is freely available for people and the community to do with as they wish. This informational site is the way think the information can best be presented to the community. I look forward to seeing how others in the community choose to present it.


The following NoSuchMethodError was thrown building Builder: The getter 'uid' was called on null. Receiver: null Tried calling: uid

import 'dart:async';
import 'package:firebase_auth/firebase_auth.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_database/firebase_database.dart';
import 'package:flutter/material.dart';
import 'package:flutter_spinkit/flutter_spinkit.dart';
import 'package:rideboard/models/user.dart';
import 'package:rideboard/services/Navigation%20Settings/User%20Navigation%20Settings/route_generator.dart';
import 'package:rideboard/services/appData.dart';
import 'package:rideboard/ui/Screens/User%20Screens/Login_Screen.dart';
import 'package:rideboard/ui/components/Configmaps.dart';
import 'ui/components/constants.dart';
import 'package:provider/provider.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  currentfirebaseUser = await FirebaseAuth.instance.currentUser;
  runApp(Rideboard());
}

String _fdbUrl1 = "database url";
DatabaseReference usersRef =
    FirebaseDatabase(databaseURL: _fdbUrl1).reference().child("Users");
String _fdbUrl2 = "database url";
DatabaseReference driversRef =
    FirebaseDatabase(databaseURL: _fdbUrl2).reference().child("Drivers");
DatabaseReference newRequestsRef =
    FirebaseDatabase.instance.reference().child("Ride Requests");

DatabaseReference rideRequestsRef =
    driversRef.child(currentfirebaseUser.uid).child('newRide');

class Rideboard extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ChangeNotifierProvider(
      create: (context) => AppData(),
      child: MaterialApp(
        initialRoute: (currentfirebaseUser == null) ? '/Login' : "/Rider",
        onGenerateRoute: RouteGenerator.generateRoute,
        debugShowCheckedModeBanner: false,
        theme: ThemeData(
          scaffoldBackgroundColor: kthemeColor.withOpacity(0.2),
          textTheme: ktextTheme,
        ),
      ),
    );
  }
}

class LoadingScreen extends StatefulWidget {
  @override
  _LoadingScreenState createState() => _LoadingScreenState();
}

class _LoadingScreenState extends State<LoadingScreen> {
  //Initializes the Timer
  @override
  void initState() {
    super.initState();

    Timer(
      Duration(seconds: 10),
      () => Navigator.push(
        context,
        MaterialPageRoute(
          builder: (context) => LoginScreen(),
        ),
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: Stack(
      fit: StackFit.expand,
      children: [
        Container(
          decoration: BoxDecoration(
            image: DecorationImage(
                image: AssetImage(
                  'assets/PATTERN3.png',
                ),
                fit: BoxFit.cover),
          ),
        ),
        Column(
          mainAxisAlignment: MainAxisAlignment.spaceAround,
          children: [
            SizedBox(height: 20),
            Image.asset(
              'assets/logo.png',
              scale: 4.5,
            ),
            Text('Hitch a ride Asap!', style: kSplashScreen),
            SizedBox(height: 30),
            SpinKitWave(
              itemBuilder: (context, index) {
                return DecoratedBox(
                  decoration: BoxDecoration(
                    color: index.isEven ? Color(0xFF0A1768) : Colors.blue,
                  ),
                );
              },
            ),
            SizedBox(
              height: 30,
            ),
            Text('By Kofi Junior Eshun', style: kMyName)
          ],
        )
      ],
    ));
  }
}

Please take a look at my stacktrace too. It points out where the error is but I have tried using stream builder and and if or else statments but still its not working

//══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following NoSuchMethodError was thrown building Builder:
The getter 'uid' was called on null.
Receiver: null
Tried calling: uid

The relevant error-causing widget was:
  MaterialApp file:///D:/App%20Development/Main%20Projects/rideboard/lib/main.dart:39:14

When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:54:5)
#1      new _RiderPageState (package:rideboard/ui/Screens/User%20Screens/Rider_Screen.dart:61:39)
#2      RiderPage.createState (package:rideboard/ui/Screens/User%20Screens/Rider_Screen.dart:38:36)
#3      new StatefulElement (package:flutter/src/widgets/framework.dart:4584:24)
#4      StatefulWidget.createElement (package:flutter/src/widgets/framework.dart:916:38)
...     Normal element mounting (166 frames)
#170    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#171    Element.updateChild (package:flutter/src/widgets/framework.dart:3306:18)
#172    RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:5561:32)
#173    MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6105:17)
#174    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#175    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#176    StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4667:11)
#177    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#178    StatefulElement.update (package:flutter/src/widgets/framework.dart:4699:5)
#179    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#180    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#181    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#182    ProxyElement.update (package:flutter/src/widgets/framework.dart:4843:5)
#183    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#184    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#185    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#186    ProxyElement.update (package:flutter/src/widgets/framework.dart:4843:5)
#187    _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:181:11)
#188    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#189    SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5981:14)
#190    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#191    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#192    StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4667:11)
#193    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#194    StatefulElement.update (package:flutter/src/widgets/framework.dart:4699:5)
#195    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#196    SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5981:14)
#197    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#198    SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5981:14)
#199    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#200    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#201    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#202    ProxyElement.update (package:flutter/src/widgets/framework.dart:4843:5)
#203    Element.updateChild (package:flutter/src/widgets/framework.dart:3293:15)
#204    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4520:16)
#205    StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4667:11)
#206    Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#207    BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2694:33)
#208    WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:873:21)
#209    RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:319:5)
#210    SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1144:15)
#211    SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1082:9)
#212    SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:998:5)
#216    _invoke (dart:ui/hooks.dart:161:10)
#217    PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:253:5)
#218    _drawFrame (dart:ui/hooks.dart:120:31)
(elided 3 frames from dart:async)

@eshun4
From your code below, you are doing:
DatabaseReference rideRequestsRef =
    driversRef.child(currentfirebaseUser.uid).child('newRide');

And seems the firebaseUser is null and hence the error.
You first need to check if the currentfirebaseUser is null or not and then proceed with your further implementation.
Closing this as not a Flutterfire issue but code implementation. You may ask this question on support channels like StackOverflow to get help.
If you disagree, write in comments and I'll reopen it.
Thanks.


Error in impact calculation in simtel event source due to rounding error

Describe the bug
Reading a file directly pointing at zenith, I get the following error when trying to iterate events:
Traceback (most recent call last):
  File "/home/maxnoe/Uni/CTA/pyeventio/read_photon_times.py", line 10, in <module>
    for e in f:
  File "/home/maxnoe/Uni/CTA/ctapipe/ctapipe/io/eventsource.py", line 275, in __iter__
    for event in self._generator():
  File "/home/maxnoe/Uni/CTA/ctapipe/ctapipe/io/simteleventsource.py", line 522, in _generator
    yield from self._generate_events()
  File "/home/maxnoe/Uni/CTA/ctapipe/ctapipe/io/simteleventsource.py", line 573, in _generate_events
    impact_distances = shower_impact_distance(
  File "/home/maxnoe/Uni/CTA/ctapipe/ctapipe/reco/impact_distance.py", line 68, in shower_impact_distance
    sky_direction = altaz_to_righthanded_cartesian(
  File "/home/maxnoe/Uni/CTA/ctapipe/ctapipe/coordinates/__init__.py", line 88, in altaz_to_righthanded_cartesian
    return np.array(spherical_to_cartesian(r=1, lat=alt, lon=-az))
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/funcs.py", line 119, in spherical_to_cartesian
    sph = SphericalRepresentation(distance=r, lat=lat, lon=lon)
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/representation.py", line 1928, in __init__
    super().__init__(lon, lat, distance, copy=copy,
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/representation.py", line 670, in __init__
    super().__init__(*args, **kwargs)
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/representation.py", line 230, in __init__
    attrs = [self.attr_classes[component](attr, copy=copy, subok=True)
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/representation.py", line 230, in <listcomp>
    attrs = [self.attr_classes[component](attr, copy=copy, subok=True)
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/angles.py", line 573, in __new__
    self._validate_angles()
  File "/home/maxnoe/.local/anaconda/envs/cta-dev/lib/python3.9/site-packages/astropy/coordinates/angles.py", line 594, in _validate_angles
    raise ValueError('Latitude angle(s) must be within -90 deg <= angle <= 90 deg, '
ValueError: Latitude angle(s) must be within -90 deg <= angle <= 90 deg, got 90.00000250447816 deg

To Reproduce
with SimTelEventSource('tests/resources/lst_with_photons.simtel.zst', focal_length_choice="EQUIVALENT") as f:

    for e in f:
        pass

This is the file: https://github.com/cta-observatory/pyeventio/blob/master/tests/resources/lst_with_photons.simtel.zst
Expected behavior
Value should be clipped to 90°.

Should we treat altitude > 90° as "looking overhead" ?

The problem is that the closest float32 value to pi/2 is larger than pi/2:

np.float64(np.float32(np.pi/2)) > np.float64(np.pi/2)


[master] save consumer url at asycRpcResult creation and restore it to the callback thread local variable

fix #8602

Codecov Report

Merging #8650 (5b3c7b0) into master (fd80172) will decrease coverage by 0.69%.
The diff coverage is 69.69%.

@@             Coverage Diff              @@
##             master    #8650      +/-   ##
============================================
- Coverage     61.04%   60.35%   -0.70%
+ Complexity      448      447       -1
============================================
  Files          1097     1097
  Lines         44407    44424      +17
  Branches       6470     6474       +4
============================================
- Hits          27109    26812     -297
- Misses        14313    14624     +311
- Partials       2985     2988       +3

Impacted Files
Coverage Δ

.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java
50.00% <0.00%> (-0.67%)
:arrow_down:

...he/dubbo/rpc/protocol/dubbo/DubboCodecSupport.java
64.28% <77.77%> (ø)

...src/main/java/org/apache/dubbo/rpc/RpcContext.java
68.34% <87.50%> (+2.01%)
:arrow_up:

...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java
51.42% <100.00%> (+0.95%)
:arrow_up:

...gcenter/wrapper/CompositeDynamicConfiguration.java
0.00% <0.00%> (-73.34%)
:arrow_down:

...ookeeper/ZookeeperDynamicConfigurationFactory.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...pport/zookeeper/ZookeeperDynamicConfiguration.java
0.00% <0.00%> (-62.86%)
:arrow_down:

...fig/configcenter/TreePathDynamicConfiguration.java
31.42% <0.00%> (-54.29%)
:arrow_down:

.../dubbo/metadata/report/MetadataReportInstance.java
12.50% <0.00%> (-40.63%)
:arrow_down:

.../configcenter/support/zookeeper/CacheListener.java
0.00% <0.00%> (-34.29%)
:arrow_down:

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8a54e...5b3c7b0. Read the comment docs.

wait for multi-instance support

see how this issue's been fixed on 3.x branch. https://github.com/apache/dubbo/pull/9464


Qiao continue part3-updated admin browse image

Please rebase your branch, some latest changes from main don't work.

Event icon
UserProfile
Event poster Signup page.

Please rebase your branch, some latest changes from main don't work.
Event icon
UserProfile
Event poster Signup page.


chore: fix formatting and update to dart 2.10.0

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           40        40
=========================================
  Hits            40        40

Impacted Files
Coverage Δ

lib/formz.dart
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319fc61...0a38e5b. Read the comment docs.


Run7 Chamber

Addition of Run7 small chamber geometry. Chamber is made from plastic material (polyamide PA6) and in the centre of the chamber there is a filing of XAD4 (thickness 6mm).

Can one of the admins verify this patch?

Merged by hand


UAudio Update

I've spent some time looking at UAudioManager and have some changes I'd like to make but thought I'd start this conversation before diving in with a pull request.

Remove UAudioMiniManager.
This looks like a very specific solution to a very specific problem.  It would also prevent (2) from occurring since the MiniAudioEvent directly references scene components (AudioSource).

Author audio events as AudioBank assets.
At present all the events for your application would need to live inside the UAudioManager component.
Changing to a bank style asset based system has the following advantages.

You can load / unload banks at run-time
Your sound engineer does not need the scene to modify events
You can load different banks depending on application settings/events (language, chosen the "Metal" theme etc)
It is easier to transport audio events between projects (you can "Export" the audio bank asset)

Now the above are reasonably straight forward changes, but the question really is should we go deeper on these changes to allow for an extensible system.  i.e. it is impossible to add a new container type without modifying the library source.  Should the system support more external customisation?
Finally, is there any real requirement/desire for this system since it seems that the audio system hasn't really changed over time.

Adding @davidkline-ms

You're absolutely right - the MiniManager's purpose is to author audio content independently from the global UAudioManager. Think DLC content that includes audio. It was needed for a project we worked on, though some of the needs would be solved by...

Been wanting to do this for a while now. I have no idea how many people are using the current version of UAudioManager, so I think maybe there's a conversation about deprecating it for this new extensible version.

I can't really answer the requirement/desire question, though I'd love to know. This manager was created for teams that aren't using some kind of middleware as a simple way to give sound designers a little control in Unity's native audio system. But how many MR developers are using middleware anyway? How many are using custom solutions or other Unity assets? I think if there's a direction to take it that makes it easier or more useful than other solutions, we should just do it.

I'm with @joekellyms.  I would be a huge fan of a version that used banks (skinable audio would be a welcome feature).
Thanks!
David

So I've performed some preliminary investigations and have a modified version of UAudioManager that supports audio bank assets.  This is the minimum set of changes that can support bank assets while maintaining some degree of backwards compatibility.  I think any other changes would get into "Version 2" territory with limited backwards compatibility.
You can look at the branch here
https://github.com/DaveSullivanAtWork/MixedRealityToolkit-Unity/tree/UAudioBank
Highlights:

Moved all the event data to a ScriptableObject.
Added an export to audiobank option if events are present in the UAudioManager component
Added support for unity volume curve to spatial sounds.
Removed Lowpass curve (it was unused).
Removed UAudioMiniManager
Updated the example scene.

Another update to the UAudioBank branch.

Removed the obsolete HRTF parameters and associated audio event properties.

Does the UAudio stuff take advantage of the mixer groups?

Yes, you can set a mixer group in the audio event.

bump
How do things stand with this issue after 7 months? I've just spent the afternoon thinking out something very similar so was pleased to see the work mostly already done! :)
I also have some ill-formed thoughts about adding some kind of bridge to listen in to events from the input system and out (perhaps a subset of) corresponding 'audio events' that could be handled, and independently consumed, by relevant objects in the same manner as the current input events... But that's probably a thing for another Issue/PR :)

Would definitely be interested to hear more. Since my last comment I've put a little system together, more or less as described above but also with its own 'fallback' handler to provide easily configurable, app-wide UI audio, which is serving as a decent stopgap for our team. Having a toolkit solution would be lovely though.

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


changing scrollview style to contentContainerStyle

Renaming scroll view style prop to contentContainerStyle as described in the docs. Style kept throwing an error when passed flex properties

It would be maybe better to create a new prop then remove style prop. It could have been used by someone already ...

I can do that, but putting it in styles would just not do anything. The scrollview Property doesn't take Style, it only takes contentContainerStyle

Where did you find out that ScrollView doesn't work with style prop? Could you send me a link to code? Just curious ...
I can understand it works as the documentation says, but I just don't want to introduce a breaking change ...

https://facebook.github.io/react-native/docs/scrollview.html#contentcontainerstyle
this is the link. When I tried to pass style props it kept giving me a warning that it is not supported and ignored all the styles. I went into node_modules and manually changed it to contentContainerStyle and everything worked normally as it should.
I think its the RN that introduced a breaking change and this minor patch wont break things for existing library users, unless they're using an older version of RN that supported it, which I'm not sure which one did

But it doesn't say that style prop is not supported anymore. It just says that there is a contentContainerStyle which you can use for styling content container - obviously :D But I would say this prop is there since a beginning.

True, it was just annoying to see the yellow box at the bottom of the screen. I'll try and reinstall node_modules and see if it persists

Let me know ;) We can still add contentContainerStyle and you can use it instead of style


Allow "null" and "undefined" in routes

This matches React convention since 0.11 so routes may be specified like this:
    <Route name="landing" path="/" handler={ LandingRoute }>,
    (
      config.env === 'development'
      && <Route name="styleguide" handler={ StyleGuideRoute } />
    ),
    <NotFoundRoute handler={ NotFound } />

In regular React, they'll be rendered as <noscript> but will eventually be skipped altogether. In react-router, they'll simply be ignored during iteration.

This is incomplete — it seems it only breaks when you pass an array of Route elements to Router.run(), and fails deeper in Router/Match when any undefineds get into the routes at all.

react-router won't accept elements === false, which is what my example above will return. The below is supported and works:
    <Route name="landing" path="/" handler={ LandingRoute }>,
    (
      config.env === 'development'
      ? <Route name="styleguide" handler={ StyleGuideRoute } />
      : null
    ),
    <NotFoundRoute handler={ NotFound } />


New term for root tuber

Need to define two terms clearly under 'plant structure' for 'tubers'
http://www.plantontology.org/amigo/go.cgi?xpand=[PO:0004543](http://purl.obolibrary.org/obo/PO_0004543)&search\_constraint=terms&query=[PO:0004543](http://purl.obolibrary.org/obo/PO_0004543)&view=details&show\_associations=list
they should be root tuber and stem/shoot tuber. The current term PO:0004543 : tuber  is suggesting only a shoot/stem tuber only.
Pankaj
Reported by: cwtung
Original Ticket: obo/plant-ontology-po-term-requests/47

Revised hierarchy for tubers to ensure a path to the anatomical structure :
Was:
tuberous root tuber (PO:0025476): A tuber (PO:0004543) that develops from a tuberous root (PO:0025523) and is further radially enlarged.
Revised:
tuberous root tuber (PO:0025476): A root (PO:0009005) that develops from a tuberous root (PO:0025523) and is further radially enlarged for storage.

Maintained the other is_a parent link to tuber for now.

See also Issue #127

Propose renaming tuberous root tuber (PO:0025476):
Currently, shoot axis tuber (PO:0004543) and tuberous root tuber (PO:0025476) are subclasses of tuber (PO:0025522). We propose renaming tuberous root tuber (PO:0025476) to root axis tuber, in an effort to keep the subclasses parallel.

While I agree that this change might appear to be better, there are a couple of important considerations.

The tuberous root tubers arise from special types of roots (tuberous roots), which are either lateral roots or shoot-borne roots, which was why we created the term "tuberous root (PO:0025523).

The name 'tuberous root' is widely used in the literature; for example:  https://scholar.google.com/scholar?q=Tuberous+roots&btnG=&hl=en&as_sdt=0%2C38

root axis is not a PO term, thus it will be confusing to users.  So we will change it to say a root axis tuber develops from a tuberous root? That name not clear because it sounds like it can arise from any kind of root.

Currently the tuberous root tuber (PO:0025476) already has the exact synonyms 'root tuber' and also 'storage root', so it is easily found by anyone looking for that this structure.

We could swap the root tuber synonym and the term name, but I don't think that actually makes that big of a difference, and does not accomplish what you are trying to do.  Not all sibling classes need to be directly parallel to each other.


Postal code validation in hosted card form

General information

SDK version: 3.63.0
Environment: production
Browser and OS: 83.0.4103.116, macOS 10.15.5

Issue description
It is allowed to put special characters (@#~,...) into the hosted postcode field, which then breaks when submitted - results in following error:
Braintree Transaction Failed: Postal code can only contain letters, numbers, spaces, and hyphens.
Right now you check only the min length of the input.
    validationResult = validate(value, {       minLength: this.configuration.fields.postalCode && this.configuration.fields.postalCode.minlength     });
I think you should use some regex like this one:
[a-zA-Z0-9][a-zA-Z0-9\- ]{0,10}[a-zA-Z0-9]

I brought this up with my team and the team responsible for that validation. We've decided it's best to leave that validation up to the Braintree gateway.
If you'd like to include validation yourself for the postal code, you can omit the postal code field from your hosted fields integration, set up your own postal code input, validate it, and send it along as part of the billingAddress.postalCode field when tokenizing: https://braintree.github.io/braintree-web/current/HostedFields.html#tokenize


Provide a DLL insted of a EXE installer [FEATURE]

Can you provide a DLL instead of a EXE installer?
The thing is people are used to work  with VST plugins in a DLL format. However, when the plugin is a EXE installer people gets afraid of virus or unwanted changes in its OS environment.
Thanks!

I'm sorry: no. An .exe installer is the way I'm choosing to provide the plugin.
If you'd like a .dll, you're welcome to build it from source.