Add find command to Developer Guide

Codecov Report
Base: 63.48% // Head: 63.46% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (a8f56be) compared to base (2239dae).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     63.48%   63.46%   -0.02%
  Complexity      849      849
============================================
  Files           155      155
  Lines          3218     3219       +1
  Branches        410      410
============================================
  Hits           2043     2043
- Misses         1006     1007       +1
  Partials        169      169

Impacted Files
Coverage Δ

...odquik/logic/parser/student/FindCommandParser.java
10.34% <0.00%> (-0.37%)
:arrow_down:

...quik/model/student/predicates/ModulePredicate.java
0.00% <0.00%> (ø)

...k/model/student/predicates/StudentIdPredicate.java
0.00% <0.00%> (ø)

...odquik/model/student/predicates/NamePredicate.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[WIP] test unit tests

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-mixer-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-mixer-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-mixer-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-dashboard

prow/daily-e2e-pilot-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-e2e-mixer-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-mixer-no_auth

prow/daily-e2e-dashboard.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-dashboard

prow/daily-e2e-pilot-no_auth.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-pilot-no_auth

prow/daily-e2e-bookinfoTests.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-bookinfoTests

prow/daily-e2e-simpleTests.sh
265949a5f231b2420adc21ed438457ce291b3be2
link
/test daily-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Create university-of-california-berkeley.me

Hi @RichardLitt
I've created UC Berkeley's OSPO page for the map.  Once it's live, I'll revert to them to provide us with more informationn.
@RichardLitt - you also need to add the university to the list: https://github.com/sustainers/academic-map/blob/main/universities.md

Ta


Cloud May Release Notes

https://cockroachlabs.atlassian.net/browse/DOC-3399

This change is

@emily-horing those notes went out April 20 in sync with the connection changes


Added ; to resolve runtime error

Without these semicolons, I was experiencing the red screen of death when trying to run with 2.1.0
FWIW... I'm using RN 0.21.0 and node 5.x / npm 3.x

note: newer versions of babel allow no semi-colon class properties, but you are right we should support all versions possible

@rt2zz - Gotcha.  I guess it's time for me to upgrade babel too.


proposal: affected/package: testing

As a part of checking test stabilities and the number of issues found during execution cycles, we need some mechanism to log failure messages along with stack traces for post-processing. Currently, testing framework just tells about the status of tests using
t.Failed() but we also need some methods which can provide information about assertion message/stack trace (something like, t.Messsage() or t.StackTrace()).
This is similar to TestNG or Junit listeners in java.
Please find below example,
import (
	"fmt"
	"testing"
)

type ICalc interface {
	Add() int
}

type Calc struct {
	no1 int
	no2 int
}

func NewCalc(no1 int, no2 int) *Calc {
	return &Calc{no1: no1, no2: no2}
}

func (c Calc) Add() int {
	return c.no1 + c.no2
}

func AfterTest(t *testing.T) {
	// Need to catch failure reason here
	if t.Failed() {
		fmt.Println("Inside After Test :: " + t.Name())
        // Something similar method
		fmt.Println("Failure reason is :: " + t.Message())
		fmt.Println("Failure Stack trace is :: " + t.StackTrace())
	}
}

func TestCalc_Add1(t *testing.T) {
	defer AfterTest(t)
	got := NewCalc(3, 2).Add()
	if got != 5 {
		t.Errorf("got=%v,expected=5", got)
	}
}

func TestCalc_Add2(t *testing.T) {
	defer AfterTest(t)
	got := NewCalc(3, 3).Add()
	if got != 5 {
		t.Errorf("got=%v,expected=5", got)
	}
}

I would hope most test failures wouldn't need a stack trace to understand them; such would tell me the test should be more precise. But if one is stuck:
if failed {
    buf := make([]byte, 10000)
    n := runtime.Stack(buf, false)
    t.Logf("%s\n", buf[:n])
}

should serve. This is easy enough not to demand adding it to the testing package. I'd like to continue to make the bar just a little high regarding the printing of stacks on testing failures.

Thanks @robpike, for suggesting a way to capture stack trace.
But is it possible to capture the assertion message in case of test failures?

@priyankshah217 you could always write your own wrapper around testing.T with additional behaviour. This would work with existing assertion libraries since they mostly accept interfaces: https://github.com/stretchr/testify/blob/0ab3ce1249292a7221058b9e370472bca8f04813/assert/assertions.go#L28

Thanks, will write custom wrapper around it.

Sounds like there is nothing to do here.  Please comment if you disagree.


fix: #809

use .Capabilities.APIVersions.Has instead of semverCompare

Thank you for fixing this!


Basic ntt

Moving #98 to main repo to enable benchmarking workflow.

@potsrevennil
I would like the configuration of OPT to be as simple as possible. As a user, I don't want to pass a complicated argument as NTT123_4567, but just say whether ASM should be enabled or not. Internally, or for more experienced users, we can also expose a fine-grained option, but I think this should be secondary.
Even when OPT is set, the AArch64 ASM should only be used when we are actually running on an AArch64 system. There should be a system header detecting this once and for all, exporting something like USE_AARCH64_ASM as the combination of running on an AArch64 system and OPT being set. Then, the actual source should cleanly rely on that flag only.
For benchmarking, I would suggest that we set OPT=1 by default, and add new -ref benchmarks which force OPT=0 and thereby fall-back to the reference implementation.
@mkannwischer You may want to chime in here.


Update Dockerfile

Add ld.lld symlink, for use in BOLT testing

Updated file and started test build to check image https://buildkite.com/llvm-project/llvm-main/builds/4240 Will update agents as soon as it will finish.


fix(learn): add missing inline-code block in challenge

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Thank you for your contribution to the project. We are happy to accept these changes and look forward to future contributions.


URL is currently unable to handle this request. HTTP ERROR 500

Steps to Reproduce;

Click 'sign in with steam'
Login

Expected outcome:

You get redirected back to the website, logged in

Actual outcome:

You get redirected back to the website, with an error, not logged in
http://my.name.is.jabbe.rs/4i1tn.png

Status code 500 is for "Internal server error", which is probably caused by a error in your own script. Check your PHP/webserver logs.


RPROMPT on first line in multiline prompt

I don't really know how this can be done, but it would be nice to have IMO...

Hey @pradyunsg !
Thanks for your report. I'll have a look on that later on today.

Fixed in f7cb94689


Remove mentions of outdated materials and add warning about them

Remove mention of the Trello board and add warning about it and other third-party/outdated material.

Good notes for new users. I've suggested a few changes, any objections?

Merged the suggestions.


feat(sqllab): Show sql in the current result

SUMMARY
Following #24329, SQLLab can run a portion of the sql editor without highlighted.
Like other 3rd party sql editor, it will be useful to display the current running sql in the result panel to identify the actual executed query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://github.com/apache/superset/assets/1392866/eda3ac07-3173-469f-9991-0a9587981917
Before:
https://github.com/apache/superset/assets/1392866/158f8a2d-0d8a-473c-982f-1e89c4b18414
TESTING INSTRUCTIONS
Go to sqllab
Run a query and check the result panel
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

I'll leave the design review for @kasiazjc but I think we can truncate the query (add ...) to indicate that we're only showing part of the query.

I'll leave the design review for @kasiazjc but I think we can truncate the query (add ...) to indicate that we're only showing part of the query.

Thanks @michael-s-molina and thanks @justinpark for the PR!
I have a few suggestions:

in other places in the app we actually have a number of rows or the right side of the table and filters/title etc on the left side; I think it would make sense to switch the order in here too, because the sql line acts as a title. Below a screenshot for reference (from explore)

The sql field could have a max width and if the text (first line) doesn't fill that space, the sql input could shrink a little bit
if there is another line, more text that is longer than the max width of the container (as Michael said) there should be a truncation rule with "..." - this is a default truncation behavior we use across the app
and the last one - this is more of a question - I'm wondering if instead of showing a pop up with the sql query, would it be more useful to scroll and highlight the query in the sql query area at the top? Not sure if that would be even possible, but curious to hear your thoughts @michael-s-molina and @justinpark

in other places in the app we actually have a number of rows or the right side of the table and filters/title etc on the left side; I think it would make sense to switch the order in here too, because the sql line acts as a title. Below a screenshot for reference (from explore)

Wow, that's a great suggestion. @justinpark Could we also display the number of rows using the Label (pill) component?

and the last one - this is more of a question - I'm wondering if instead of showing a pop up with the sql query, would it be more useful to scroll and highlight the query in the sql query area at the top? Not sure if that would be even possible, but curious to hear your thoughts @michael-s-molina and @justinpark

@justinpark If this is possible it would be an awesome UX!

and the last one - this is more of a question - I'm wondering if instead of showing a pop up with the sql query, would it be more useful to scroll and highlight the query in the sql query area at the top?

@kasiazjc this is a good idea but it might be broken if a user modify the sql content which is not same from the ran query.

Could we also display the number of rows using the Label (pill) component?

Sure. I'll update accordingly

and the last one - this is more of a question - I'm wondering if instead of showing a pop up with the sql query, would it be more useful to scroll and highlight the query in the sql query area at the top?

@kasiazjc this is a good idea but it might be broken if a user modify the sql content which is not same from the ran query.

True, so I think for now let's keep the modal. Thanks!

I have a few suggestions:

in other places in the app we actually have a number of rows or the right side of the table and filters/title etc on the left side; I think it would make sense to switch the order in here too, because the sql line acts as a title. Below a screenshot for reference (from explore)
image
The sql field could have a max width and if the text (first line) doesn't fill that space, the sql input could shrink a little bit
if there is another line, more text that is longer than the max width of the container (as Michael said) there should be a truncation rule with "..." - this is a default truncation behavior we use across the app

@kasiazjc I updated the layout as you suggested. I also replaces the existing limit message by the tooltip (+ exclamation indicator when exists). Feel free to give any feedback at your convenience.
https://github.com/apache/superset/assets/1392866/80a73d05-0534-48ea-a7f5-2691578275bc

@kasiazjc circle back related to the update

@kasiazjc @michael-s-molina could you help a review again?

/testenv up

@kasiazjc I will remain open until next Tuesday and will merge it if you don't have any concerns.

I filed this cosmetic issue for the yellow banner of the query limit, it looks like the yellow banner is now on the edge of the query filed.
https://github.com/apache/superset/issues/25288


Update fzf minimum requirement

git_commits and git_bcommits does not work with fzf v0.29. Not sure exactly which version will be best, but I set it to latest to be safe

Ty @CowKeyMan but I don’t think we need to update the min requirements for 2 pickers which may be fixed if we really wanted to.


HIP19: mark as approved

Following onto #87
Via Discord discussion, informal polls, the most recent community calls, and private discussions with folks not represented in those other forums, the Helium community have expressed overwhelming support for approving this proposal and moving forward w/ evaluating the two current applicants, Nebra Ltd & SyncroB.it
Addressing the remaining concerns:

Helium Inc have indicated their support and willingness to accept onboarding keys from approved manufacturers, and developing a process by which the issuance of those keys can be made public.
The community & manufacturers have both agreed that it's OK to approve this proposal this system is still being developed
Lastly, it is agreed that adding the ability to revoke existing keys should be addressed in a separate proposal.

On behalf of the DeWi and the Helium community I'm calling this proposal ✅ approved

Great news 👍


About Check for Updates.

VSCode Version: Code 1.17.1 [Unsupported] (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:24:50.851Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

Bookmarks
ale
0.17.0

auto-rename-tag
for
0.0.14

beautify
Hoo
1.1.1

vscode-icons
rob
7.17.0

background
sha
1.1.16

open-in-browser
tec
1.1.0

(1 theme extensions excluded)

Steps to Reproduce:
1.The latest version is 1.17.2, but I can't update, because there is no "check for updates" option
2.I use the zip version,How can I use the check for updates function?

Reproduces without extensions: Yes/No

You are using https://marketplace.visualstudio.com/items?itemName=shalldie.background which modifies VS Code internal files so you lost ability to update automatically.
You can open an issue for that extension, or re-install VS Code.


respect ignore_errors when extracting error messages from event data

Description of your changes

Fixes #328
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Create an ansiblerun with a task that is known to fail but set ignore_errors to true, i.e.
     tasks:
        - ignore_errors: true
          file:
            path: /nonexistent
            state: file

And have that run fail for some other reason (i.e. another task that fails and does not have ignore_errors set).
The failed ansiblerun should have a message about the faile task without ignore_errors, but should not have any messages about the one with ignore_errors

LGTM


Does not seem to work with beta.112+

Hi,
I am currently running the plugin on beta.111 which seems to be the last version that is compatible with this plugin. I assume one of the breaking changes regarding the authentication workflow/config needs to be taken into consideration.
Essentially, I get a redirect to the error page I defined on trying to login using an oauth provider (after being redirected back to my payload instance) - no further error messages are visible in the logs. I saw someone already posted this issue but closed it again, marking it as resolved - I don't think that this is the case.
Unfortunately I can't provide any more debug information since there is none visible. Let me know if I can do anything to change that to contribute to resolving this issue.
Thank you!
edit: typo

Have you tried v114? @MatthiasGrandl just said it is fixed in latest beta 20 hours ago: https://github.com/WilsonLe/payload-oauth2/issues/11#issuecomment-2416470874

Jup I can confirm this sounds like my issue in #11 and it has been fixed upstream. I am running beta v115 currently.

I'm in the midst of writing integration tests with as much oauth providers as I can, sorry if I'm not catching up with payload beta 🥲

I tried with 114 and 115 just now, including cleaning caches and nuking node_modules etc. - I get redirected to my custom auth error page.
Here is my config, maybe something changed meanwhile:
    OAuth2Plugin({
      strategyName: 'oauth2',
      useEmailAsIdentity: false,
      enabled: true,
      serverURL: process.env.NEXT_PUBLIC_URL || 'http://localhost:3000',
      authCollection: Users.slug,
      clientId: process.env.OAUTH_CLIENT_ID || '',
      clientSecret: process.env.OAUTH_CLIENT_SECRET || '',
      tokenEndpoint: 'xxxxxxxx',
      scopes: ['email', 'profile', 'openid'],
      providerAuthorizationUrl: 'xxxxxxxx',
      getUserInfo: async (accessToken) => {
        try {
          const response = await fetch('xxxxxxxx', {
            headers: { Authorization: `Bearer ${accessToken}` },
          });
          const user = await response.json();
          return {
            email: user.email,
            sub: user.sub,
          };
        } catch (error) {
          console.error(error);
          return null;
        }
      },
      successRedirect: () => {
        console.log('Login successful, redirecting to /admin');
        return '/admin';
      },
      failureRedirect: (req, error) => {
        console.error(error);
        return '/oauth-error';
      },
    }),

Anything looking suspicious in the above? But things work right now on beta.111 - so there can't be anything fundamentally wrong.

what's the output of the console.error(error) in your failureRedirect?

Ah - apologies, there's some debug spam in the logs and I didn't catch this at first:
TypeError: Cannot read properties of undefined (reading 'cookies')
      at generatePayloadCookie (webpack-internal:///(rsc)/./node_modules/payload/dist/auth/cookies.js:74:50)
      at Object.handler (webpack-internal:///(rsc)/./node_modules/payload-oauth2/dist/callback-endpoint.js:148:90)
....

Yes this is the same error, which has been fixed in Payload. You probably haven't updated payload properly.

There is not much more that I can do other than nuking node_modules and the lock file and reinstalling dependencies.. but yes, in this case this seems to be not an issue of this plugin then and specific to my environment. Closing.

Does not change anything. Just out of curiosity, if you run this plugin on current beta.115 with a generic oauth provider (gitlab ce in my case), does it work for you, @WilsonLe ?

@genox appologies, it's definitely still broken. guess it was me who didn't prune his cache properly 🤦♂

@genox #13 works for me


Uncaught TypeError: Cannot read property 'ZRPOS' of null

_Uncaught TypeError: Cannot read property 'ZRPOS' of null
at r.Session.Send._consume_header (VM72 zmodem.js:1)
at r.Session.Send._parse_and_consume_header (VM72 zmodem.js:1)
at r.Session.Send.consume_first (VM72 zmodem.js:1)
at r.Session.Send.consume (VM72 zmodem.js:1)
at t.Sentry.consume (VM72 zmodem.js:1)
at WebSocket.handleWSMessage (VM73 zmodem.js:30)
When I use 'rz' to upload a file,I got this.
So what`s the probrom.

You probably have a bug in how you’re calling zmodemjs.
If you can submit a PR with a test that demonstrates that there’s a bug in this library I’ll look though.
Unfortunately, ZMODEM is just a hard protocol to implement.

You probably have a bug in how you’re calling zmodemjs.
If you can submit a PR with a test that demonstrates that there’s a bug in this library I’ll look though.
Unfortunately, ZMODEM is just a hard protocol to implement.

in my project django-webssh and gowebssh,
i use zmodemjs to implement upload and download functions, but this error often occurs, just like @zhinian99

@leffss: Best thing would be a PR with a test that reproduces the problem.
It looks like it’s bugging out here:
var handler = this._next_header_handler[ new_header.NAME ];

Assuming the API is being used as intended, that means there’s a ZRPOS being sent that zmodem.js doesn’t know how to handle.
I suggest adding some debugging statements and seeing if you can further diagnose the problem.

I’ve made a debug branch:
https://github.com/FGasper/zmodemjs/tree/extra_zrpos
It makes the error report a bit “kinder” and turns on debugging. Let me know if that clarifies anything.

@leffss @zhinian99 ^^

I’ve made a debug branch:
https://github.com/FGasper/zmodemjs/tree/extra_zrpos
It makes the error report a bit “kinder” and turns on debugging. Let me know if that clarifies anything.

I used the debug branch https://github.com/FGasper/zmodemjs/tree/extra_zrpos .

As you said: ZMODEM is just a hard protocol to implement, I still don't understand what happened...
And I also found if use rz -O (disable timeout code, wait forever for data) to upload file, it will work well.

@leffss Thank you.
Are you sending just a single file, or multiple files? In the first screenshot it looks like two files are being sent.
I’ve pushed up a few more debugging statements … do you mind retrying?
If you can send me reproduction steps I’ll give it a go on this end.

@leffss Thank you.
Are you sending just a single file, or multiple files? In the first screenshot it looks like two files are being sent.
I’ve pushed up a few more debugging statements … do you mind retrying?
If you can send me reproduction steps I’ll give it a go on this end.

I test it again.

@leffss It looks like these latest screenshots don’t include the additional debugging data … do you mind trying with that?

@leffss It looks like these latest screenshots don’t include the additional debugging data … do you mind trying with that?
Thank you for clarifying that the issue pertains to multiple-file transfer sessions.

Ok， I will test it with the lastest debug branch.

@leffss It looks like these latest screenshots don’t include the additional debugging data … do you mind trying with that?
Thank you for clarifying that the issue pertains to multiple-file transfer sessions.

Latest test results with the lastest debug branch.

@leffss: So, assuming the -O flag is unused, the issue appears sometimes when transferring a single file, but always when transferring multiples?

@leffss Each zmodem packet consists of a type and 4 octets. I’m pushing up another change to the debug branch to expose those 4 octets.
ZRPOS is how ZMODEM implements error-correction; if the sender receives a ZRPOS, it’ll include a file offset in the 4-octet sequence. That file offset is the receiver saying, “start sending from this offset in the file.” So when the receiver gets packets that fail the CRC check, it can ask the sender to start from the last-known “good” location in the file.
Why your rz is sending a second ZRPOS, though, I don’t know. Ordinarily over a reliable connection there’d only be 1 ZRPOS because there’s no chance a CRC check would fail.
I’m curious to know if that ZRPOS represents the current location in the file, or if your rz is actually asking the sender (zmodem.js) to go back for some reason … i.e., is it doing error-correction, or what?
Would you also try running rz with -vvvvvvvvv flags? It’ll be a lot of output, but it should at some level indicate why it’s sending another ZRPOS.

Also, which OS are you running? Is the rz that you’re using a stock build, or did you build it yourself? Have you tried building lrzsz yourself and seeing if that resolves the problem?
Regardless, this is something that zmodem.js should accommodate; I’m just wondering why it happens in the first place.

Try this: in zsession.js, change MAX_CHUNK_LENGTH to 1024.
I’m starting to think this is a bug in your rz. (Of course, that bug may be everywhere!) But over a reliable connection there should be no reason for that extra ZRPOS.

Also, have you tried sending files that consist of pure ASCII?
There are sometimes issues with terminal configuration, which would make it a problem in your implementation.
Try this: create a file that consists of octets 0-255, then transfer that file via zmodem.js: by itself, and alongside a copy of itself. See if anything breaks.

See if your pty has IEXTEN enabled or disabled. This setting affects whether octets 0x0f and 0x16 reach the terminal (and, thus, rz). If those are being blocked then that might explain the problem … though it wouldn’t explain why the timeout flag fixes the issue.

See if your pty has IEXTEN enabled or disabled. This setting affects whether octets 0x0f and 0x16 reach the terminal (and, thus, rz). If those are being blocked then that might explain the problem … though it wouldn’t explain why the timeout flag fixes the issue.

My server os is CentOS Linux release 7.5.1804 (Core).
The original lrzsz version was lrzsz-0.12.20-36.el7.x86_64,
if update to lrzsz-0.12.20-43.el8.x86_64, it also get that error.
When send small files like this:
[root@centos751 test3]# ll -h
total 204K
-rw------- 1 root root   63 Nov  4  2019 admin.py
-rw------- 1 root root   93 Nov  4  2019 apps.py
-rw------- 1 root root 1.9K Apr 15 14:25 deamon.ini
-rw------- 1 root root  120 Dec 24  2019 delete_makemigrations.sh
-rw------- 1 root root  722 Nov 13  2019 Dockerfile
-rw------- 1 root root  258 Aug  4 16:01 docker.sh
-rw------- 1 root root  105 Nov  4  2019 forms.py
-rw------- 1 root root 4.4K Jul 13 17:03 gunicorn.cfg
-rw------- 1 root root 2.7K Apr 13 14:34 init.py
-rw------- 1 root root  696 Apr 13 14:34 layer_group.py
-rw------- 1 root root  691 Apr 13 14:34 layer.py
-rw------- 1 root root   53 Sep 21  2019 makemigrations.sh
-rw------- 1 root root 2.1K Nov  4  2019 make_nginx.sh
-rw------- 1 root root  626 Nov  4  2019 manage.py
-rw------- 1 root root   46 Sep 21  2019 migrate.sh
-rw------- 1 root root   57 Nov  4  2019 models.py
-rw------- 1 root root  10K Jul  6 16:04 nginx.conf
-rw------- 1 root root  19K Aug  4 16:22 README.md
-rw------- 1 root root  779 Jun  1 11:37 requirements.txt
-rw------- 1 root root 1.3K Oct  9  2019 server.crt
-rw------- 1 root root 1.7K Oct  9  2019 server.key
-rw------- 1 root root  649 Nov  2  2019 sources.list
-rw------- 1 root root  560 Dec 24  2019 start_celery_beat_2.py
-rw------- 1 root root  556 Dec 24  2019 start_celery_beat.py
-rw------- 1 root root  638 Dec 24  2019 start_celery.py
-rw------- 1 root root  573 Dec 24  2019 start_daphne.py
-rw------- 1 root root  447 Dec 24  2019 start_docker_fast.py
-rw------- 1 root root  234 Dec  4  2019 start_docker_fast.sh
-rw------- 1 root root  442 Dec 24  2019 start_docker.py
-rw------- 1 root root  280 Dec  4  2019 start_docker.sh
-rw------- 1 root root  569 Apr 15 12:14 start_gunicorn.py
-rw------- 1 root root  15K Apr 27 16:27 telnet.py
-rw------- 1 root root 1.6K Apr 14 13:24 test.py
-rw------- 1 root root   60 Nov  4  2019 tests.py
-rw------- 1 root root  148 Nov  4  2019 urls.py
-rw------- 1 root root 1.7K Nov  6  2019 views.py
-rw------- 1 root root  11K Apr 13 14:46 websocket_layer.py
-rw------- 1 root root 6.5K Nov  4  2019 websocket.py
[root@centos751 test3]#

it work well.
 ZRPOS_HEADER {_bytes4: Array(4)} null
_consume_header @ zsession.js:316
_parse_and_consume_header @ zsession.js:299
_consume_first @ zsession.js:1621
consume @ zsession.js:232
consume @ zsentry.js:228
wsOnMessage @ Console.vue?748d:600
Console.vue?748d:602 Error: Unhandled header: ZRPOS
    at ZmodemSendSession._consume_header (zsession.js:317)
    at ZmodemSendSession._parse_and_consume_header (zsession.js:299)
    at ZmodemSendSession._consume_first (zsession.js:1621)
    at ZmodemSendSession.consume (zsession.js:232)
    at ZmodemSentry.consume (zsentry.js:228)
    at VueComponent.wsOnMessage (Console.vue?748d:600)
zsession.js:308 send SENDING HEADER ZFIN 0,0,0,0
zsession.js:308 send RECEIVED HEADER ZRPOS 0,140,1,0
zsession.js:316 Unhandled header! ZRPOS_HEADER {_bytes4: Array(4)} {ZFIN: ƒ}
_consume_header @ zsession.js:316
_parse_and_consume_header @ zsession.js:299
_consume_first @ zsession.js:1621
consume @ zsession.js:232
consume @ zsentry.js:228
wsOnMessage @ Console.vue?748d:600
Console.vue?748d:602 Error: Unhandled header: ZRPOS
    at ZmodemSendSession._consume_header (zsession.js:317)
    at ZmodemSendSession._parse_and_consume_header (zsession.js:299)
    at ZmodemSendSession._consume_first (zsession.js:1621)
    at ZmodemSendSession.consume (zsession.js:232)
    at ZmodemSentry.consume (zsentry.js:228)
    at VueComponent.wsOnMessage (Console.vue?748d:600)
zsession.js:308 send SENDING HEADER ZFIN 0,0,0,0
zsession.js:308 send RECEIVED HEADER ZRPOS 0,140,1,0
zsession.js:316 Unhandled header! ZRPOS_HEADER {_bytes4: Array(4)} {ZFIN: ƒ}
_consume_header @ zsession.js:316
_parse_and_consume_header @ zsession.js:299
_consume_first @ zsession.js:1621
consume @ zsession.js:232
consume @ zsentry.js:228
wsOnMessage @ Console.vue?748d:600
Console.vue?748d:602 Error: Unhandled header: ZRPOS
    at ZmodemSendSession._consume_header (zsession.js:317)
    at ZmodemSendSession._parse_and_consume_header (zsession.js:299)
    at ZmodemSendSession._consume_first (zsession.js:1621)
    at ZmodemSendSession.consume (zsession.js:232)
    at ZmodemSentry.consume (zsentry.js:228)
    at VueComponent.wsOnMessage (Console.vue?748d:600)
zsession.js:308 send SENDING HEADER ZFIN 0,0,0,0
zsession.js:308 send RECEIVED HEADER ZRPOS 0,140,1,0

**Since my program does not support rz -vvvvvvvvv now, I will test it again after modification.

See if your pty has IEXTEN enabled or disabled. This setting affects whether octets 0x0f and 0x16 reach the terminal (and, thus, rz). If those are being blocked then that might explain the problem … though it wouldn’t explain why the timeout flag fixes the issue.

rz -vvvvvvvvv result:
...
...
...

So, this is what stands out to me:
zrdata: 8192  ZCRCGCalling read: alarm=10  Readnum=8192 Read returned -1 bytes
errno=4:Interrupted system call

Do you mind running strace on that rz process to see what signal is interrupting the read? I’m assuming it’s SIGALRM, in which case there’s a need to determine:

Is the browser not sending data?
Is the server process not forwarding data to rz?

That said, this probably illustrates a use case for making zmodem.js recognize ZRPOS during transmission.

I’ve looked this over. Recognizing ZRPOS will break some assumptions about the interaction between the Session classes and the Zmodem.Browser functions. That’s not the end of the world, but ideally then it’ll need some sort of callback mechanism to alert implementations of the repositioning.
Beyond that, the Transfer object will need to be made smart enough to abstract calls to send() and end() from the actual sending of subpackets. The caller (i.e., Zmodem.Browser) doesn’t expect to have to re-send(); while that contract could change, it seems more expedient to make Transfer handle any discrepancy between “last-added” position and “last-sent”. The only catch is that this will mean either buffering the entire file contents, or switching the subpackets to require the recipient to acknowledge receipt, which will slow things down a bit.
Unfortunately I can’t offer a timeline for when I may be able to do this work. For now I suggest telling your users to use the -O flag to avoid the timeouts. I’d also suggest investigating why rz is timing out; it shouldn’t be the browser, which makes me wonder if it’s your WebSocket server.

@leffss Actually, on further thought this seems much simpler. Give the branch you’ve been using another try.

@leffss Actually, on further thought this seems much simpler. Give the branch you’ve been using another try.

Thanks very much. I think it is the browser that caused the timeout when transferring large files. I'll try to use FileReader to read segmentally, maybe it can solve this problem.

@leffss Would you please, though, give the debug branch a shot with your code as you have it? I’d like to ensure that the ZRPOS is correctly ignored.

Also, are you not using Zmodem.Browser? That implements the browser logic that you probably want.

Also, are you not using Zmodem.Browser? That implements the browser logic that you probably want.

Yes, I use Zmodem.Browser.send_files to upload files. I have modified this function by my logic, and now the problem is solved.

@leffss Would you please run the branch that I’ve made against your unaltered code to verify that ZRPOS is now ignored?
I’ve put a fair bit of time into helping you investigate your problem. Now please help confirm that I’ve solved mine.

@leffss Would you please run the branch that I’ve made against your unaltered code to verify that extra ZRPOS is now ignored?
I’ve put a fair bit of time into helping you investigate your problem. Now please help confirm that I’ve solved mine.

@leffss Thank you! I’ll push a new version that has the updated diagnostics.
Also, do you mind sharing the actual fix for your browser code? I’m curious to see what caused your browser to behave that way … looks like it sent 98,304 bytes then just hung.

@leffss Thank you! I’ll push a new version that has the updated diagnostics.
Also, do you mind sharing the actual fix for your browser code? I’m curious to see what caused your browser to behave that way … looks like it sent 98,304 bytes then just hung.

function send_files(session, files, options) {
	if (!options) options = {};

	//Populate the batch in reverse order to simplify sending
	//the remaining files/bytes components.
	var batch = [];
	var total_size = 0;
	for (var f=files.length - 1; f>=0; f--) {
		var fobj = files[f];
		total_size += fobj.size;
		batch[f] = {
			obj: fobj,
			name: fobj.name,
			size: fobj.size,
			mtime: new Date(fobj.lastModified),
			files_remaining: files.length - f,
			bytes_remaining: total_size,
		};
	}

	var file_idx = 0;
	function promise_callback() {
		var cur_b = batch[file_idx];

		if (!cur_b) {
			return Promise.resolve(); //batch done!
		}

		file_idx++;

		return session.send_offer(cur_b).then( function after_send_offer(xfer) {
			if (options.on_offer_response) {
				options.on_offer_response(cur_b.obj, xfer);
			}

			if (xfer === undefined) {
				return promise_callback();   //skipped
			}

			return new Promise( function(res) {
				var block = 1 * 1024 * 1024;
				var fileSize = cur_b.size;
				var fileLoaded = 0;
				var reader = new FileReader();
				reader.onerror = function reader_onerror(e) {
					console.error('file read error', e);
					throw ('File read error: ' + e);
				}
				function readBlob() {
					var blob;
					if (cur_b.obj.webkitSlice) {
						blob = cur_b.obj.webkitSlice(fileLoaded, fileLoaded + block + 1);
					} else if (cur_b.obj.mozSlice) {
						blob = cur_b.obj.mozSlice(fileLoaded, fileLoaded + block + 1);
					} else if (cur_b.obj.slice) {
						blob = cur_b.obj.slice(fileLoaded, fileLoaded + block + 1);
					} else {
						blob = cur_b.obj;
					}
					reader.readAsArrayBuffer(blob);
				}
				var piece;
				reader.onload = function reader_onload(e) {
					fileLoaded += e.total;
					if (fileLoaded < fileSize) {
						if (e.target.result) {
							piece = new Uint8Array(e.target.result);
							_check_aborted(session);
							xfer.send(piece);
							if (options.on_progress) {
								options.on_progress(cur_b.obj, xfer, piece);
							}
						}
						readBlob();
					} else {
						//
						if (e.target.result) {
							piece = new Uint8Array(e.target.result);
							_check_aborted(session);
							xfer.end(piece).then(function() {
								if (options.on_progress && piece.length) {
									options.on_progress(cur_b.obj, xfer, piece);
								}
								if (options.on_file_complete) {
									options.on_file_complete(cur_b.obj, xfer);
								}
								res(promise_callback());
							})
						}
					}
				}
				readBlob();
			} );
		} );
	}

	return promise_callback();
}

@leffss I just looked this over. It looks like you’re accommodating cases where load fires before the file is fully read; I’m not sure on what browsers that happens, but the standard appears to describe load firing only at the (successful) end.
Anyway, I’m glad your issue is resolved. I’m going to close this issue. Thank you!

@FGasper @leffss I have tried @leffss's send_files function, still same error, even try load the https://github.com/leffss/django-webssh/blob/master/webssh/static/zmodem/zmodem.devel.js, still get the same error, any ideas?

@FGasper I think the root cause could be the send function is not real async, just wondering how to know the sending process is over.

Please take this thread to Gitter. Thank you!

@zxdong262 https://github.com/leffss/gowebssh

@leffss @FGasper I tried https://github.com/leffss/gowebssh, it works, so I think it must be my code's problem.

When I use 'rz' to upload a file,I can not cencel

@panda521119 This is not the forum to use to request help. Please read the docs. Thank you!
I’m unsubscribing from this issue and will not respond further here.


light core question

so in light core you can spawn light if you will but in trying to make the light stay on and use the crossbow bolt how would i keep it on? cause right now it stays on for a few sec like 3 then goes away

Not sure what this means


Consider unique nature of state column in SQL Server event store implementation

If the number of messages exceeds the number of different combinations of the state column and it is unique and they never get removed then there may be an issue.
This may manifest if there's approximately 2,000,000,000 messages (wild guess).

I think this has been addressed with subsequent performance improvements in #122


token3: Initialize account instruction is unergonomic for CPI

Problem
The InitializeAccount instruction expects the owner as an account input when it could be passed via instruction data. When owner is required as an account input, all calling programs must also require that owner account as an input.
Proposed Changes

Move owner to instruction data

I actually ended up needing the owner account into for another token instruction so this didn't end up being an issue. Low priority issue in my opinion


[feat] Add secp256k1 curve

draft PR to track adding secp256k1 curve to gnark-crypto and ECDSA

TODO:

[ ] optimize field arithmetic (no spare bit)
[ ] ECDSA (separate PR)
[ ] secq256k1? (maybe, separate PR)


My password don't work when deploying

Hello guys.
I was trying to deploy my laravel app and it is located at bitbucket. My password has two "$" and I can't deploy cause these symbols turns 20708(and I got an Authentication failed) when rocketeer try to clone my repository. I changed my password and I removed these symbols and now it works fine.
Any reason for this? I like my passwords more secure :D

Sorry for silly question, but did you put your pass in double quotes?

No, I did it with single quotes.

Have you tried adding backslash before every $?

Not yet. I don't have time to try this now so I can try later. Thank you!

Will reopen if that has not fixed the issue but yeah escaping the characters should work


Investigate case where ancestor chain gets reordered

We encountered a case in a complex app where we saw something like the following:
class ExampleClass
  include ExampleModule

  def example_method
    true
  end
  memo_wise :example_method
end

module ExampleModule
  prepend MemoWise
  extend ActiveSupport::Concern

  included do
    def example_method
      false
    end
  end
end

ExampleClass.new.example_method
# => true

And we noticed that if instead we have:
class ExampleClass
  prepend MemoWise # This line added
  include ExampleModule

  ...
end

# Now:
ExampleClass.new.example_method
# => false

but if we move the prepend MemoWise after the include ExampleModule we get the original behavior again. Something about calling prepend MemoWise first modifies the ancestor chain in a way I do not understand.
We should investigate and see if this is expected Ruby behavior, a bug in MemoWise, or a bug in the Ruby interpreter.

hey @JacobEvelyn, which was the ruby version you used?
I tried to simulate that with 2.6.3 and it returned true in both cases.
Either way, I simulated all combinations prepending and not prepending the Memowise module on the module example.
In the scenario where it prepended both in the ExampleClass and ExampleModule, and it is done in the class after the inclusion of ExampleModule the ancestors chain looks exactly like MemoWIse was included on ExampleClass.
I created a repo with the tests I did if you want to check it out https://github.com/LeonardoGodoy/memo_wise_issue_135

Interesting... I simulate that behavior with a non-memorise module and the ancestor's chan was not affected the same way.
Alter that I tested if it was active_support/concern and it was not either.
I will get back to it asap

Hi @LeonardoGodoy! Thanks for digging in here and sorry for the slow response. This was in Ruby 2.6.6. I can spend some time this week digging into our (closed-source, sadly) codebase to see if I can come up with an actual reproducible test case.

I might have encountered the same issue
module TestModule1
  prepend ::MemoWise

  def pika?
    :chu
  end
  memo_wise :pika?
end

class TestClass1
  prepend ::MemoWise
  include TestModule1

  private def pika?
    :pikapika
  end
end

TestClass1.new.send(:pika?) #=> unexpected `:chu` instead of `:pikapika`

TestClass1.ancestors
# Actual: [MemoWise, TestModule1, TestClass1, Object, PP::ObjectMixin, Kernel, BasicObject]
# Expected: [MemoWise, TestClass1, TestModule1, Object, PP::ObjectMixin, Kernel, BasicObject]

This issue seems fixed in ruby-master (using these instructions to build)
I will test more with different branches and update this comment

Thanks for the investigation, @PikachuEXE ! I hadn't finished investigating/reproducing this within our codebase but yes this does seem like the same issue. I'm going to close this issue as it doesn't appear to be related to MemoWise. Feel free to comment if you disagree!

Happy to see https://github.com/ruby/ruby/pull/4711 merged and released in 2.7.5
I have run the test script in irb and confirmed the issue no longer exists in 2.7.5

Awesome! Thanks for the update @PikachuEXE and glad to hear the backport finally merged!


libffi: Add ptest

Purpose of pull request
This PR adds ptest of libffi package.
This ptest executes make check in testsuite directory.
This test requires dejagnu package, so this PR also adds dejagnu recipe based on the following recipe:

base recipe: meta/recipes-devtools/dejagnu/dejagnu_1.6.2.bb
base branch: dunfell
base commit: 3b9c61c5878df208c57c3d61d8b8eaea35e49045

Note
The test of libffi is composed of the following steps:

Compile test code
Run the test binary and check the exit status
Compare the output of step2

These steps are executed in each test case, so cannot separate compilation and execution without some hacks.
In this ptest, step1 is executed in do_compile_ptest task, and step2 and step3 are executed by ptest-runner, by using the following hacks.
In do_compile_ptest, step2 and step3 are prevented by modifying test comments.
example of libffi-3.2.1/testsuite/libffi.call/closure_fn0.c
-/* { dg-do run } */
+/* { dg-do link } */
 #include "ffitest.h"

 static void
 closure_test_fn0(ffi_cif* cif __UNUSED__, void* resp, void** args,
 		 void* userdata)
 {

After compilation, restore the previous change.
And replace gcc command with true command (do nothing, successfully) to pass step1 in target environment.
build/testsuite/site.exp
-set CC_FOR_TARGET "aarch64-deby-linux-gcc  -march=armv8-a+crc -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/meta-sasaki/deby-bsp/build/tmp/work/aarch64-deby-linux/libffi/3.2.1-r0/recipe-sysroot"
-set CXX_FOR_TARGET "aarch64-deby-linux-g++  -march=armv8-a+crc -fstack-protector-strong  -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/meta-sasaki/deby-bsp/build/tmp/work/aarch64-deby-linux/libffi/3.2.1-r0/recipe-sysroot"
+set CC_FOR_TARGET "true"
+set CXX_FOR_TARGET "true"

Test
How to test

Enable ptest and install libffi package

$ . ./repos/poky/oe-init-build-env build
$ bitbake-layers add-layer ../repos/meta-debian/
$ cat << EOS >> conf/local.conf
DISTRO = "deby"
MACHINE = "qemuarm64"
PACKAGE_CLASSES = "package_deb"
DISTRO_FEATURES_append = " ptest"
EXTRA_IMAGE_FEATURES += "ptest-pkgs"
IMAGE_INSTALL_append = " libffi"
EOS

Build core-image-minimal image

$ bitbake core-image-minimal

Run qemu and execute runtest  command (dejagnu) and ptest of libffi

$ runqemu nographic slirp
...(snip)...

# runtest --version
...(snip)...
# ptest-runner -l
...(snip)...
# ptest-runner -t 3600 libffi
...(snip)...

Also, I confirmed that SDK builds succeed with the following settings:

Set DISTRO=deby and run bitbake core-image-minimal -c populate_sdk with meta-debian and poky
Set DISTRO=emlinux and run bitbake core-image-minimal-sdk -c populate_sdk with meta-debian, meta-debian-extended, meta-emlinux and poky

Test result
Run  runtest command (dejagnu)
# runtest --version
[   42.414844] random: mktemp: uninitialized urandom read (6 bytes read)
WARNING: Couldn't find the global config file.
DejaGnu version 1.6.2
Expect version  5.45.4
Tcl version     8.6

Run ptest of libffi
# ptest-runner -l
Available ptests:
busybox /usr/lib/busybox/ptest/run-ptest
libffi  /usr/lib/libffi/ptest/run-ptest
util-linux      /usr/lib/util-linux/ptest/run-ptest
zlib    /usr/lib/zlib/ptest/run-ptest
# ptest-runner -t 3600 libffi
START: ptest-runner
2024-04-23T04:59
BEGIN: /usr/lib/libffi/ptest
make: Entering directory '/usr/lib/libffi/ptest/testsuite'
make  check-DEJAGNU
make[1]: Entering directory '/usr/lib/libffi/ptest/testsuite'
...(snip)...
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O0 (test for excess errors)
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O0 execution test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O0 output pattern test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 (test for excess errors)
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 execution test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 output pattern test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O3 (test for excess errors)
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O3 execution test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O3 output pattern test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -Os (test for excess errors)
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -Os execution test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -Os output pattern test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 -fomit-frame-pointer (test for excess errors)
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 -fomit-frame-pointer execution test
PASS: libffi.call/va_struct3.c -W -Wall -Wno-psabi -O2 -fomit-frame-pointer output pattern test

                === libffi Summary ===

# of expected passes            1870
make[1]: Leaving directory '/usr/lib/libffi/ptest/testsuite'
make: Leaving directory '/usr/lib/libffi/ptest/testsuite'
DURATION: 185
END: /usr/lib/libffi/ptest
2024-04-23T05:02
STOP: ptest-runner

ptest-libffi.log
Test summary

TOTAL: 1870

PASS: 1870
FAIL: 0

I run this ptest 3 times and obtained the same results.
1/3 of these tests (=623) does nothing, and the remaining 2/3 of that (=1246) are the actual execution test.
See "Note" for details.

merged in upstream


Handle 'this' in visible/enabled functions

I am currently using the visible feature to see/hide an option in the menu.
The corresponding method need a little bit more logic than just checking the type of the option.
I need a reference to the component through 'this'.
For example, let's see the following template for the context menu :
<context-menu #withFunctions>
  <template contextMenuItem [visible]="myMethod" (execute)="showMessage('Hi, ' + $event.item.name)">
    Say hi! (visible for Joe)
  </template>
</context-menu>

myMethod reference to the following snippet in the component :
  type = 'typeA';
  minValue = '10';
...
  public myMethod(item: any): boolean {
    //return item.name === 'John';
    return item.data.type === this.type && item.data.value > this.minValue;
  }

As minValue can evolve during the process, I would like to be able to use this as a reference to the component.  Currently this is 'undefined' and myMethod will not answer my needs.
Do you have any idea how to perform such a case ?
Thanks in advance.
Regards,
Julien

You'll need to pass in a function that has this bound to it.
myBoundMethod = this.myMethod.bind(this)
// or
public myBoundMethod(): (item:any) => boolean {
  return this.myMethod.bind(this);
}

[visible]="myBoundMethod"
// or
[visible]="myBoundMethod()"

I can't think of a way to make this automatic for people.  Let me know if this works for you.

I've updated the readme to mention using this technique.

Works like a charm !
Thanks !
Julien


Double Commander (pkgs.doublecmd) will not mount drives when clicked on bar and will not display filetypes icons in folders

Describe the bug
When select/click unmounted (greyed out) drive icon on top mount/drive list will get "Disk is not available" message, also when right click on the icon and select mount, nothing happens.
Also you cannot unmount declaratively mounted drives, only can unmount drives mounted other way like using tray icon "Disk and Devices" in KDE.
Double Commander also isn't using xdg.mime file-types, it's only displaying flew icons like archives.
It does displays question marks on known to system file-types.
Steps To Reproduce
Steps to reproduce the behaviour:

Install NixOS with KDE DE
Add pkgs.doublecmd to environment packages, rebuild
try click/mount usb or internal greyed out, unmounted disk
and for icons, just browse document, different types.

Expected behavior
Drives to mount and file types display as on any other distro.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Someone suggested that the program could be incorrectly packaged.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
~ nix-shell -p nix-info --run "nix-info -m"                                                                                 ✔  100  15:41:24
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.8, NixOS, 23.11 (Tapir), 23.11.2217.d02d818f22c7`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"home-manager-23.11.tar.gz, nixos-23.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

I have a (maybe?) related problem. doublecmd installed from d934204a doesn't even show any drives (like usb sticks) that could be mounted. In investigating I saw that it tries to load libudev.so.1 from different locations but cannot find it:
openat(AT_FDCWD, "/nix/store/xg3ld3c3xip8fx9agx901r1bz3fmnchv-dbus-1.14.10-lib/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/hbdl12ck2ibhn5zsi8nsfa6v471pf0j6-glib-2.78.4/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/ga17mlfsss2fndyvp2s1m0s2rx2b4i9s-libX11-1.8.7/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/prpjym9rnpd17326sk790m21h72fwran-libqt5pas-2.2.2-0/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/cyrrf49i2hm1w7vn2j945ic3rrzgxbqs-glibc-2.38-44/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/f5my15qww10swmf66ns13l24yp6j5dmq-xgcc-13.2.0-libgcc/lib/libudev.so.1", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/xg3ld3c3xip8fx9agx901r1bz3fmnchv-dbus-1.14.10-lib/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/hbdl12ck2ibhn5zsi8nsfa6v471pf0j6-glib-2.78.4/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/ga17mlfsss2fndyvp2s1m0s2rx2b4i9s-libX11-1.8.7/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/prpjym9rnpd17326sk790m21h72fwran-libqt5pas-2.2.2-0/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/cyrrf49i2hm1w7vn2j945ic3rrzgxbqs-glibc-2.38-44/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/f5my15qww10swmf66ns13l24yp6j5dmq-xgcc-13.2.0-libgcc/lib/libudev.so.0", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)

I've tried to add systemd to the buildInputs with an override but that does not seem to make any difference.

Hi @tschan,
I got udisk enabled but that's all. Would you be able to share overlay code? Sorry I'm newbie to NixOS.
Thom

Sure:
let
  luaWithPackages = pkgs.lua5_1.withPackages (ps: with ps; [
    # 'socket' module is needed by plugin
    luasocket
  ]);
in pkgs.doublecmd.overrideAttrs (finalAttrs: previousAttrs: {
  # this will patch rpath of the doublecmd binary to include systemd and
  # lua library paths for loading runtime libraries using dlopen
  # see: https://nixos.org/manual/nixpkgs/stable/#setup-hook-autopatchelfhook
  runtimeDependencies = [
    # liblua.so.5.1
    luaWithPackages
    # libudev.so.1
    pkgs.systemd
    # libudisks2.so.0
    pkgs.udisks
  ];
  # we want to just patch every ELF file in $out with the exception of
  # libunrar.so (because this fails with an error for some reason);
  # to achieve this we first disable autopatching, then do the recursive
  # patching of $out _before_ we copy libunrar.so and finally copy
  # libunrar.so to the appropriate place. if we don't do it this way
  # the autoPatchelf hook seems to get run after the postFixup phase
  # and will try to also patch libunrar.so.
  dontAutoPatchelf = true;
  postFixup = ''
    autoPatchelf $out
  '' +
  # copying libunrar.so into the doublecmd lib folder is a workaround to get
  # extraction of rar archives working. the extraction is done by a plugin
  # ($out/lib/doublecmd/plugins/wcx/unrar/unrar.wcx) which is a compiled
  # binary but apparently doesn't have a rpath patchable by patchElf.
  # because I don't know how to get it to search for libunrar.so in the
  # appropriate directory we can just copy the lib into the doublecmd lib
  # folder where the plugin will look for it as a last resort.
  ''
    cp "${pkgs.unrar}/lib/libunrar.so" "$out/lib/doublecmd/"
  '' +
  # additionally we need to make sure the lua interpreter knows where to look
  # for included modules. we do this by setting the LUA_PATH and LUA_CPATH
  # env vars for the doublecmd process
  ''
    wrapProgram "$out/bin/doublecmd" \
      --prefix LUA_PATH ";" "${luaWithPackages}/share/lua/5.1/?.lua" \
      --prefix LUA_CPATH ";" "${luaWithPackages}/lib/lua/5.1/?.so"
  '';
  # to be able to use runtimeDependencies and wrapProgram we need to include
  # additional build time dependencies
  nativeBuildInputs = previousAttrs.nativeBuildInputs ++ [
    # needed for runtimeDependencies
    pkgs.autoPatchelfHook
    # needed for wrapProgram
    pkgs.makeWrapper
  ];
});

I also enabled gvfs and udisk2:
services.gvfs.enable = true;
services.udisks2.enable = true;

Hi @tschan,
Many thanks for the code, unfortunately I can't figure out how to implement it to my configuration.nix.
I've added to it this  nixpkgs.overlays = [ (import ./overlays/doublecmd.nix) ]; and copied your code to doublecmd.nix like this:
{ config, pkgs, ... }:
your code here
but it when trying to rebuild system complains about last character (error: syntax error, unexpected ';', expecting end of file) with I guess suppose to be there.
Would mind advise what I do wrong? Btw I don't use flakes at the moment, can't grasp concept as yet.


firefox stalling on windows (backslashes in path)

I'm running the seed-element tests on windows 8. Using wct on the command line.
Ran into an issue with Firefox stalling (v33.1 and v34.0.5). Here's the log from wct:
Web server running on port 64901 and serving from E:\Ben\Documents\Projects\GitHub\wct
Selenium server running on port 64902
ie 11.0.9600.17416       Beginning tests via http://localhost:64901/seed-element/test/index.html?cli_browser_id=2
ie 11.0.9600.17416       Tests passed
chrome 39                Beginning tests via http://localhost:64901/seed-element/test/index.html?cli_browser_id=0
chrome 39                Tests passed
firefox 34               Beginning tests via http://localhost:64901/seed-element%5Ctest%5Cindex.html?cli_browser_id=1

IE and Chrome appear to be converting backslashes for the URL, Firefox has encoded them and thus can't find the file.
Would a potential fix be to use node's url.resolve() at this point?
https://github.com/Polymer/web-component-tester/blob/master/runner/browserrunner.js#L95
this.browser.get(require('url').resolve(host, path) + extra, function(error) {

Fixes the issue when I run the tests.

+1
Screenshot below:

:+1:


chore: batch invert ipa round challenges for verify [DO NOT MERGE]

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (32): 68.0 (-33%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 16abb5ae and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,936
867,836
3,449,252

l1_rollup_execution_gas
842,023
3,594,944
22,204,621

l2_block_processing_time_in_ms
2,001 (-1%)
7,517 (-1%)
29,620 (-1%)

note_successful_decrypting_time_in_ms
297
861 (-4%)
3,133 (-4%)

note_trial_decrypting_time_in_ms
99.0 (-2%)
:warning: 68.0 (-33%)
135 (+2%)

l2_block_building_time_in_ms
13,272
52,294
208,960 (-1%)

l2_block_rollup_simulation_time_in_ms
11,912
46,977
187,621 (-1%)

l2_block_public_tx_process_time_in_ms
1,320 (+2%)
5,185
20,847

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
22,125 (+3%)
43,425 (+4%)

note_history_successful_decrypting_time_in_ms
2,020 (+2%)
3,912 (+1%)

note_history_trial_decrypting_time_in_ms
121 (+2%)
144 (+1%)

node_database_size_in_bytes
1,630,035
1,100,147

pxe_database_size_in_bytes
27,188 (-9%)
54,187 (-9%)

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
72.1
61,697
18,841

private-kernel-ordering
43.4
24,233
8,089

base-rollup
1,781 (+1%)
656,309
811

root-rollup
81.8 (+8%)
4,072
1,097

private-kernel-inner
53.0
81,504
18,841

public-kernel-private-input
42.3 (+2%)
41,455
18,841

public-kernel-non-first-iteration
27.3 (+3%)
41,497
18,841

merge-rollup
0.949 (+2%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,723
27,240

@ludamad benchmarked this and there was no noticeable difference, so closing


Enhancement: update host.yml.template file to reflect current OCP 4.9 download locations

The host.yml.template file should be updated to reflect the current version of OCP (which is 4.9.x).

Fixed by: da011436ab76a99683db9e61e70bb00fdee42976


Add configuration of default multiple selection.

This PR enables set default multiple image selction.
close #310

👍

Can we make this merged to repo? I need this feature.

@kzumu Thanks so much for taking the time to improve the picker ! 🏅
PS: Please excuse the fact it took so long to review 🙏

This is now up in https://github.com/Yummypets/YPImagePicker/releases/tag/4.0.0 🚀


All text on the map should be in latin letters

Reason (Why?)
Most users are not able to read the names of locations if they're not written in latin letters.
Solution (What?)
Find out if there is a version of OpenStreetMap that shows all the text in latin characters and embed it.
Out of scope
Anything that is not the map.

Do you have a screenshot of what do you exactly mean?

E.g. these should be in latin letters, so they can be read by all users.


Kartoza Epic 1: User Story 5: Use only OSM Auth

Remove Twitter and Facebook oauth support and ensure any logged in user has done so via their OSM credentials.
child of #992

@timlinux we need to present a message to existing users (twitter, facebook) as they login. The message will explain that they need to establish an OSM account to be able to edit Healthsites

@timlinux I'm getting the following error..
Server Error (500)
Which preferences need to be set?

@markherringer where did you try it?
still on staging : https://staging.healthsites.io/
i'm able to login with osm

Currently we are going to show FB and Twitter too, with some restriction
please see workable ticket : https://github.com/healthsites/healthsites/issues/1126


Implement more metrics

error count of the same job
count of runners_runing

done with https://github.com/whywaita/myshoes/pull/193


[Docs] Streamline default poktrolld configurations

Objective
Make usage of poktrolld simpler by setting default configs (home directory, RPC node, etc...).
Origin Document
This was created as a result of multiple conversations from #947.
To limit the scope of #947 to the supplier cheatsheet, this ticket was created.

Goals

Streamline the usage of poktrolld
Ensure documents are consistent across the board (walkthroughs, cheatsheest, etc...)

Deliverables

[ ] Update the documentation to leverage poktrolld config set client node
[ ] Update the documentation to leverage poktrolld config home
[ ] Ensure the old (POCKET_NODE env variable) & new approaches (configs above) are complimentary and clearly explained to the user
[ ] Make the walkthroughs explain both but have the cheat sheets just leverage one
[ ] Make sure that all walkthroughs and all cheat sheets are consistent
[ ] Cross reference documentation with poktroll-docker-compose-example
[ ] Remove the presence of $NODE_FLAGS when/where appropriate

Non-goals / Non-deliverables

Force everyone to use poktrolld config for all operations
Document poktrolld in detail
[OPTIONAL] Create a new page called poktrolld config

Creator: @Olshansk
Co-Owners: @bryanchriswhite

This is good! Thanks.
New (I assume 0.52) cosmos-sdk will have clientconfig.DefaultClientConfigTemplate which will allow us to create a custom client config. I started working on this in #940 only to realize that functionality is not available on cosmos-sdk version we're using.

Noted @okdas. Moving this to the next iteration.


[11.x] Replace dead link in Security Policy

Seems like a dead link is used in the PGP Key Comment in the Security Policy: https://sela.io/pgp/
So I replaced it with a meaningful comment instead. Please check internally if the PGP Key is still valid for usage.
It would also be possible to simply delete the Comment itself.

Thanks! Ugh, we'll need to update all SECURITY.md files now in every repo 😅

@Jubeki don't want to put you through that but can't stop you if you want that 😅 would be very appreciated 👍
Let's wait first until Taylor merges this one though.

I have no problem with it (doesn't take that long) and I will do that after this is merged. 👍


LogsDeleteButton causes the dashboard to fail to load due to incorrect date format

There is a function formatDate
function formatDate(e) {
    let t = new Date(e);
    return Intl.DateTimeFormat("en-US", {
        month: "short",
        day: "numeric",
        year: "numeric"
    }).format(t)
}

that was given amongst many correct dates an e = "16/01/2024" which caused to throw an error and whole dashboard fails to load (it shows only: "Application error: a client-side exception has occurred (see the browser console for more information).").
After inspecting a call stack it seems the problem lays in a function LogsDeleteButton that converts this date (in a correct format "Tue Jan 16 2024 ...") using t.date.toLocaleDateString() which is later passed to formatDate which causes an error.
I failed to compile it locally (I would be glad for an updated Running Locally section of README), but I assume that changing
Delete logs from {formatDate(logs.date.toLocaleDateString())}?
to Delete logs from {formatDate(logs.date)}?
in components/activity/logs/logs-delete-button.tsx should fix the issue, but I'm unable to confirm.

The formatDate function is supposed to receive a string date as its parameter, therefore formatDate(logs.date.toLocaleDateString()) is intended and is not supposed to throw any errors. logs.date contains a value with a Date type, which is then converted to string using toLocaleDateString(), which is used as a parameter for the formatDate function.
I tried to replicate the issue that you encountered and I can't seem to do it. I tried both in development and production environment, and everything seems to be working as intended.
Can you show a video replicating this issue so I can investigate it further?

Aaa, you are right. Then maybe an overload for formatDate that accepts a Date instead of string so it could be called like Delete logs from {formatDate(logs.date)}?
Here's the video
2024-01-17 14-02-23.mkv.zip

I have merged a fix for the issue you've encountered. See #12 for more info.
Let me know if you're still having problems. If there's none, I'm going to close this issue.

Works like a charm, thanks!


FAQ Page with Accordion Feature

Related Issue
This pull request addresses issue #530
Description
Added an accordion feature to the FAQ page to make it easier to use. Now, users can click to expand or collapse questions and answers, which keeps the page tidy and helps them find information quickly. This is especially useful on mobile devices where space is limited.
Type of PR

[x] Feature enhancement

Screenshots / videos (if applicable)
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/128213933/f0ec019b-fdcc-4cb6-a0ef-8c406749626b
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

I've submitted a pull request with the changes I've made. Please take a look and review it.
Thank you!

Instead of writing just FAQSection on top put proper navbar and footer. Also change the background. Don't write back to home.
instead of a static image you can add a moving image like in https://gssoc.girlscript.tech/. Also u can refer its faq section .

resolve the conflicts

Thank you for your guidance and patience. I will update you once these changes are implemented.


Update Sysmon doc with newest events

This solves #396.

Docs Build status updates of commit 814f3f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/sysmon.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Tutorials] add tensorrt llm manual

Description
Add TRTLLM conversion tutorial manual

Looks good overall, left minor comments.

@rohithkrn addressed comments


Stop autopause from being awoken by bots

Enhancement Type
Improve an existing feature
Describe the enhancement
Honestly I don't really know how this would be done but annoying minecraft server scanners and stuff are waking up the server every time they scan the server. Is there any way to prevent this, or at least reduce the quantity/impact of it?

I appreciate the concern, but this is impossible within the scope of the container startup scripts.
Have you noticed the new logging of remote IP address that woke the server? Have you tried any networking based solutions like firewall whitelisting?

I have now and I guess I can just manually blacklist them on the router. Thanks for the reply!


Deploying on EC2

Updates throughout + instructions in the README to be able to deploy the demo on an ec2 instance.

Nice work Igor.


🐛 dyld[27159]: Library not loaded: @rpath/DeviceKit.framework/DeviceKit

Did you already try Rugby doctor?
Use rugby doctor as a self-diagnostic tool.
Describe the bug
After run pod install && rugby

Hello @anil291987!
Please, add more information about the issue.

Check that Pods project builds successfully without 🏈 Rugby.
Could you attach logs?
Could you attach your Podfile or the whole project?

Sorry, I can't help without additional information.

Also, if you are ready to fix the issue by yourself, feel free to open a pull request.
Perhaps, you can't share private information.

Thanks, It is resolved. I am closing this issues.


Backport to 1.x : Commented out flaky test in favor of known issue to unblock build (#331)

Issue #, if available:
Backport #331 to 1.x
Description of changes:
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #332 (cab9d1d) into 1.x (31c2499) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x     #332      +/-   ##
============================================
- Coverage     78.55%   78.48%   -0.08%
+ Complexity      217      215       -2
============================================
  Files           173      173
  Lines          6975     6975
  Branches        916      916
============================================
- Hits           5479     5474       -5
- Misses         1007     1010       +3
- Partials        489      491       +2

Impacted Files
Coverage Δ

...ation/factory/CustomWebhookDestinationFactory.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...ting/destination/message/CustomWebhookMessage.java
80.00% <0.00%> (-1.54%)
:arrow_down:

...ting/destination/client/DestinationHttpClient.java
86.36% <0.00%> (-1.52%)
:arrow_down:

.../kotlin/org/opensearch/alerting/core/JobSweeper.kt
71.50% <0.00%> (-0.50%)
:arrow_down:

...ain/kotlin/org/opensearch/alerting/AlertService.kt
78.53% <0.00%> (-0.49%)
:arrow_down:

...ing/destination/client/DestinationEmailClient.java
77.50% <0.00%> (+5.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c2499...cab9d1d. Read the comment docs.


Add a sub-code for Zod custom issue

Discussed in https://github.com/colinhacks/zod/discussions/2997
There are many zod standard errors, and just one single custom.
Adding a sub-code to custom errors would allow the users to extend the custom error and have their codes as well.
Like when a model defines a password form (where a user enters a new password twice - see details in the discussion) the custom errors for a password-mismatch is different from password-complexity. Why would these be squeezed into a single custom category?
In the discussion we came to the conclusion that it would be helpfull to have sub-codes in custom errors, in particular for i18n.
Something like that:
export interface ZodCustomIssue extends ZodIssueBase {
  code: typeof ZodIssueCode.custom;
  subCode?: string;          // <<<==== add this
  params?: { [k: string]: any };
}

This seems like a trivial change. I could try a PR if you like the proposal.

@JacobWeisenburger I wanted to take this issue

would be great to have to be able to extend ZodIssueCode


feat: helpful error message about supportInterpreter

Following @Kha's suggestion from #2897.

Time to change the Lake template then?


[BUG] Pyvista backend quiver3d behavior inconsistent

Here is a minimally reproducible example:
import mne
import os.path as op
data_path = mne.datasets.sample.data_path()  # get the sample data path
subjects_dir = op.join(data_path, 'subjects')
brain = mne.viz.Brain(subject_id='sample', hemi='both', surf='pial',
                      subjects_dir=subjects_dir, alpha=0.1)
brain._renderer.quiver3d(0, 0, 0, 0, 0, 10, 'red', 10, 'arrow')  # does nothing
brain._renderer.quiver3d(0, 0, 0, 0, 0, 10, 'red', 10, 'arrow',
                         scale_mode='scalar')  # still does nothing
brain._renderer.quiver3d(0, 0, 0, 0, 0, 10, 'red', 10, 'arrow',
                         scale_mode='scalar', scalars=[1])  # works
brain._renderer.quiver3d(0, 0, 0, 0, 0, 10, 'blue', 20, 'arrow',
                         scalars=[1])  # broken again

What I'm stuck on as far as fixing it is that the call goes to _glyph with scalar=[1] and the key line is 1101:
    if isinstance(scalars, str):
        dataset.active_scalars_name = scalars

Which shouldn't be a string so I have no idea how the one call that works does in fact work... Maybe @larsoner might have just a minute to take a peek.

EDIT: I missed this before
if scalars is not None:
     _point_data(grid)['scalars'] = np.array(scalars)
     scalars = 'scalars'

so it will be a string.
I'm really not sure what the intention was here so I'm going to leave this one for now.

@larsoner do you have a minute to look at this? I can do the PR but if you could just tell me what you were trying to do that would be really helpful.

I won't have time to look until late next week

No worries, whenever you have time, just trying to wrap up loose threads.

@larsoner, just checking on this again, should just take five minutes. I'll go ahead and write a PR to simplify it and I'll try and look and make sure there aren't any use cases that it breaks.


GH3133: Add IncludeNativeLibrariesForSelfExtract and IncludeAllContentForSelfExtract to DotNetCorePublishSettings

Resolves #3133

@augustoproiete your changes have been merged, thanks for your contribution 👍


Dell BIOS Updates, not the latest version

In the CatalogPC.xml, there are more than one entries for BIOS updates for several models.
Example: Latitude 5580 - There is version 1.2.10, 1.7.5 and 1.18.2, the tools downloads the oldest version.
Another example is Precision 3630.
And there's the wrong version downloaded for the Latitude 5591...
======== Dell Latitude 5591 BIOS PROCESSING STARTED ========
Found BIOS URL FOLDER04653804M/1/Latitude_5X80_Precision_3520_1.7.5.exe

Hello,
in fract we have an issue with the firmware version digit.
Automation seems to check only the fist digit avter le major digit.
Exemeple 1.2.1 is minus as 1.18.2 but autmation think it's the reverse

#161 This is the problem... I documented it there


Robustness checks, thread safety

Robustness checks (#981) - Several potential races.
Writing is single threaded. Reading is multi-threaded.
We have some existing tests  (https://github.com/microsoft/Power-Fx/blob/main/src/tests/Microsoft.PowerFx.Core.Tests/ImmutabilityTests.cs) . Expanding that test shows a few suspicious things:

DType.AssociatedDataSources returns mutable value
DType.ExpandInfo returns mutable value  (IExpandInfo.UpdateEntityInfo)
DType.LazyTypeProvider returns mutable value (fixed in #1511)
WrappedDerivedRecordType._renameDriver returns mutable value

We should also ensure these eval/runtime types are ThreadSafe.
ParsedExpression
Core.IR.Nodes.IntermediateNode
ReadOnlySymbolValues
ComposedReadOnlySymbolValues

See #1520 for new test to scan these failures.
Currently, there are about 100 failures, mostly false-positives.  We should manually review determine if it is safe?

Yes, because it's protected under a lock -->  adding ThreadSafeProtectedByLock?

Yes, because the field's type is immutable --> add ThreadSafeImmutable to the type, or add to known immutable list.

Yes, because the member type could use a safer type  --> update , eg Dict --> IReadOnlyDict

Yes, manually confirmed --> can we refactor to make it easy to verify? Eg, make the field readonly?
... if we can't do any of the above ... is it actually safe?


Wrong error message? How come an "unknown error" have an error code?

Tested versions
Reproductible in latest version.
System information
Not OS specific.
Issue description
Hi there, working on a doc translation, I found this:
"p_log->add_text(vformat("[%s]: %s", TTR("Unknown Error"), vformat(TTR("Export failed with error code %d."), p_err)));"
in https://github.com/godotengine/godot/blob/master/editor/export/editor_export_platform.cpp#L156.
If we have the error code, it is not "unknown".
What do you think?
Thanks.
Steps to reproduce
n/a
Minimal reproduction project (MRP)
n/a

The message says "unknown error" because it's an error code that is not specifically handled above. It should generally never occur, so if you find real world occurrences of this happening, a special handler should be added just above.

Ok,  so the message should be "Unhandled error", not "unknown".


native restarts

Describe the solution you'd like
I would like to see method in the server class that allow me to restart server

not only a method but a command too


ArcGIS_LogHarvester.psm1 and log4j

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request

Module Version

3.3.0

Affected Resource(s)

ArcGIS_LogHarvester

Configuration Files

# Copy-paste your DSC JSON configurations here - for large configs,
# please use a service like Dropbox and share a link to the ZIP file.

N/A
Expected Behavior

Actual Behavior
N/A

Steps to Reproduce
N/A

Important Factoids
N/A

References
In the DSC-resource "ArcGIS_LogHarvester" there is a reference to log4j. To my understanding, the ArcGIS-module is as secure as the corresponding ArcGIS-version against the log4shell-vulnerability. Is this assumption correct?
Can you please give us a statement about the log4j-use within the DSC-module and its potential (additional) log4shell-vulnerability?
Thanks in advance!

@niol-esrich and @spitzerr

Hi @scma-esrich,
The DSC resource "ArcGIS_LogHarvestor" in the ArcGIS Module doesn't package log4j, therefore yes your assumption is correct, any mitigation against ArcGIS components should be enough.
Thanks,
Cameron K.


BUG: notebook fixes

Removes fstrings; removes mid-integer unders; adds lifetimes==<IP_ADDRESS> to reqfile to fix importerror; replaces is/notna with is/notnull.

Thanks.
What's the plan for where the materials will be run? The tutorial instructions link to https://github.com/deniederhut/Pandas-Tutorial-SciPyConf-2018 so maybe this PR should be there/

The PR targets the nb-update branch, which you created here.

Removes fstrings; removes mid-integer unders;

Which commits are these in?
FWIW, I'm perfectly happy requiring Python 3.6. I've found that requiring exact versions helps cut down on install issue the day of the tutorial.

adds lifetimes==<IP_ADDRESS>

Got that in https://github.com/deniederhut/Pandas-Tutorial-SciPyConf-2018/pull/4

replaces is/notna with is/notnull

We want the na versions. Pandas hasn't deprecated the null versions yet, but we're documenting na as the preferred way.

Which commits are these in?

BUG: removes 3.6-only syntax

I'm perfectly happy requiring Python 3.6

I'm not sure it's a good idea. An early frustration that students have is with teaching materials that only work with a very specific setup. I don't think we should assume that people attending the tutorials will have enough familiarity with Python to know what bits of syntax were introduced in 3.5 versus 3.6 versus 3.7.

we're documenting na as the preferred way

I'm not sure that isna works under 0.20.

An early frustration that students have is with teaching materials that
only work with a very specific setup. I don't think we should assume that
people attending the tutorials will have enough familiarity with Python to
know what bits of syntax were introduced in 3.5 versus 3.6 versus 3.7.

Agreed with that sentiment, we should avoid newer syntax. But I do think
the instructions should recommend a specific version to avoid install
issues.

I'm not sure that isna works under 0.20.

It was added in 0.21.0.
On Sun, Jul 1, 2018 at 5:50 PM, Dillon Niederhut<EMAIL_ADDRESS>wrote:

Which commits are these in?
BUG: removes 3.6-only syntax
I'm perfectly happy requiring Python 3.6
I'm not sure it's a good idea. An early frustration that students have is
with teaching materials that only work with a very specific setup. I don't
think we should assume that people attending the tutorials will have enough
familiarity with Python to know what bits of syntax were introduced in 3.5
versus 3.6 versus 3.7.
we're documenting na as the preferred way
I'm not sure that isna works under 0.20.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TomAugspurger/pandas-head-to-tail/pull/4#issuecomment-401638735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQHItYF22-LUMcVJ3j2l57OEE2tmns_ks5uCVIigaJpZM4U-J3-
.


breakpointsInverse: true does not work as mobile first

Hello,
When we are using breakpointsInverse: true for mobile first websites, assuming that the larger window width parameters inherit rules from smaller window width parameter. But it does not work as expected.

breakpointsInverse: true,
slidesPerGroup: 1,
slidesPerView: 1,
breakpoints: {
576: {spaceBetween: 20, slidesPerView: 2}
768: {spaceBetween: 40, slidesPerView: 3}
992: {spaceBetween: 60, slidesPerView: 4}
1200: {spaceBetween: 80}
}

For example this code will display only one slide per view for desktops (1200px) but if resize window to mobile width (576px) and then resize it back to desktop resolution the slider will apply 4 slides per view. So it seems during initialisation swiper does not check all breakpoints but only the last one.
Regards

Just add slidesPerView: 1 for 1200 breakpoint

Just add slidesPerView: 1 for 1200 breakpoint

Well, this is EXACTLY the issue i'm pointing on. Please check the issue.


Defining a generator on an interface results in a compile error.

TypeScript Version:
1.8.10
Code
interface Foo {
  *generator(): Iterable<number>;
}

class Bar implements Foo {
  *generator(): Iterable<number> {
    yield 1;
    return 2;
  }
}

Compile with: tsc --noImplicitAny --target ES6 Foo.ts
Expected behavior:
Compiles with no warnings :)
Actual behavior:
Foo.ts(2,3): error TS1131: Property or signature expected.
Foo.ts(2,15): error TS1005: ';' expected.
Foo.ts(2,33): error TS1005: '(' expected.
Foo.ts(3,1): error TS1128: Declaration or statement expected.

A function only needs the * if it contains yield, and this is a property of the implementation of the function, not the declaration. Since functions in interfaces don't have implementations, they don't need the *, so it's not allowed.
A caller of the function only cares that it returns an Iterable, not whether it returns an Iterable using yield 1; or using return { next: () => { done: true, value: 1 } };
It's the same for async functions where the intent is expressed via the return type being a Promise.
So just write it as generator(): Iterable<number>; in the interface.

Ah thanks for that :) sorry for the noise!


Add row in table not copying layout of rows in table.

Jodit Version:  3.3.24
Browser:  Chrome
OS:  Mac Os
On inserting a row in a table, the row is added with default basic styles. It is not including the layout of the selected row in that table

Current behaviour:
On inserting new row below or above selected row, It adding new row without the layout of the selected row.
Expected behaviour
On inserting new row below or above selected row, It should add a new one with the layout of the selected row.

Is there any way to do it with the current version?

Temporarily, I solved this with below code
  function findEnsestorNode(node, cells_count) {
    if (node.previousSibling.cells.length === cells_count) {
      return node.previousSibling;
    } else {
      return findEnsestorNode(node.previousSibling, cells_count);
    }
  }

  Jodit.defaultOptions.popup.table.find(t => t.name === "addrow").exec = (editor, table, control) => {
      const action = control.name.replace("tableaddrow", "");
      const parent = table.querySelector("td[data-jodit-selected-cell='1']").parentNode;
      const node = parent.cloneNode(true);
      const total_cells = table.rows[0].cells.length;
      const selected_row_cells = parent.cells.length;

      if (selected_row_cells === total_cells) {
        /* row with or without rowSpan and have all cells */
        for (let i = 0; i < node.cells.length; i++) {
          if (node.cells[i].rowSpan && node.cells[i].rowSpan > 1) {
            if (action === "after") {
              node.removeChild(node.cells[i]);
              parent.cells[i].rowSpan += 1;
            } else {
              node.cells[i].rowSpan = 1;
            }
          }
        }
      } else {
        const ancestor_node = findEnsestorNode(parent, total_cells);
        if (action === "after" ? parent.nextSibling.cells.length : parent.cells.length === total_cells) {
          /* row have lesser cells and next sibling also has same */
          for (let i = 0; i < ancestor_node.cells.length; i++) {
            if (ancestor_node.cells[i].rowSpan && ancestor_node.cells[i].rowSpan > 1) {
              node.insertCell(i);
              node.cells[i].innerHTML = ancestor_node.cells[i].cloneNode(true).innerHTML;
              node.cells[i].setAttribute("style", ancestor_node.cells[i].getAttribute("style"));
            }
          }
        } else {
          /* row have lesser cells and next sibling has all cells */
          for (const n of ancestor_node.cells) {
            if (n.rowSpan && n.rowSpan > 1) {
              n.rowSpan += 1;
            }
          }
        }
      }

      parent.parentNode.insertBefore(node, action === "after" ? parent.nextSibling : parent);
    };

Can you please do same for split action.


Adding default filters configuration to physical servers

Requisites
run bundle exec rake db:seed
It is dependency for
https://github.com/ManageIQ/manageiq-ui-classic/pull/2338
This PR is able to:

Add some searches for the physical servers filters.

@agrare


Scaling documentation - Add section about knative

https://camel.apache.org/camel-k/latest/scaling/integration.html
This doc covers camel-k scaling, but it does not mention anything about knative

I meant to do this for so long that I forgot about it 😃. Let's do it!


Building core fails (rustc 1.39.0)

Hi,
maybe I’m doing something wrong, maybe not.. but I get :0: error:0:Undefined language item 'non_zero' required when mrustc and minicargo try to build crate core.
Here are the full logs (error at line 451). You can see at line 63 that the commit hash is 01f73e7894119405ab3f92b6191f044e491c9062, aka the latest in branch master.
To ease the debug, I built a GitLab CI at this repo: https://gitlab.com/iemaghni/mrustc-alpine.
Feel free to fork and play with it. You can also spin an Alpine VM on your machine and copy commands from .gitlab-ci.yaml.
Issam.

Same error on Ubuntu: https://gitlab.com/iemaghni/mrustc-ubuntu/-/jobs/1582390368#L881

That error likely means that you're building 1.39 without setting MRUSTC_TARGET_VER=1.39.
See the build-1.39.0.sh script

You’right, thank you!


Add Vscode extension for improved contributor experience

Is your feature request related to a problem? Please describe.
As a contributor I want GitPod to display a contributor guide within VScode so I have all the required information to contribute to this project.
Describe the solution you'd like

[ ] Add custom VSCode extension to display a Contributor guide within GitPod.
[ ] #148

Describe alternatives you've considered
N/A
Additional context
DrupalPod PR for their extension: https://github.com/shaal/DrupalPod/pull/27

It may not be necessary to add my own extension, as it may be possible to use the drupal-mentoring.drupalpod-ext
https://github.com/shaal/DrupalPod/blob/main/.gitpod.yml#L30
https://github.com/shaal/DrupalPod/tree/main/src/vscode-extension/drupalpod-ext


Bugfix for crasher SR-11269.

Fix for: https://bugs.swift.org/browse/SR-11269.
The lesser used else branch was not evaluating the auto-conversion code that shows up under getConvertElementExpr(). Consolidate this logic under buildElementRValue which gets called in both paths.

Hi Slava, Do I need to include the crasher code in my pr here or will it get submitted on its own?

I would prefer if you included the test case from the PR, making your change self-contained. I think a better place for it is test/SILGen/foreach.swift.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 9a8ab6d403e170a377b2b4748dfad9bfd04f816c

Build failed
Swift Test OS X Platform
Git Sha - 9a8ab6d403e170a377b2b4748dfad9bfd04f816c

@swift-ci please test linux

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - f84f1d6d1283c1cdf84ce20214446ae33c089d3d

Build failed
Swift Test Linux Platform
Git Sha - f84f1d6d1283c1cdf84ce20214446ae33c089d3d