Remove endo-related fields from SRS struct

What's been done:
Remove the endo_r & endo_q fields from SRS struct since they are irrelevant.
Reference: #693

This looks great! Can you also update the book to remove endos from the URS here: https://github.com/o1-labs/proof-systems/blob/master/book/src/specs/urs.md#endo-stuff ? I'm guessing that they should be documented next in https://github.com/o1-labs/proof-systems/blob/master/book/src/specs/poly-commitment.md but that's outside the scope of this PR :o

Thanks! @mimoo
Yes, I will try to update the document as recommended.


Update Haskell package set to LTS 14.20 (plus other fixes)

This PR is test-built by Hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. I'll fix up the remaining errors and merge it on Friday, 2020-01-10 20:00 CET. You can watch this live on Twitch: https://www.twitch.tv/peti343. If you'd like to chat with me (and others) during the stream, you're welcome to use the Twitch chat or join the #haskell4nix voice conference.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/cant-build-cachix-0-3-4/5390/2

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/haskellpackages-stm-containers-fails-to-build/5416/2

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/haskellpackages-stm-containers-fails-to-build/5416/4

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/haskellpackages-stm-containers-fails-to-build/5416/5


US40 acceptance tests, also refactored existing tests to include MD ref

US40 acceptance tests, also refactored existing tests to include MD ref

I agree with Nigel's changes.

:+1:

:+1:


Use different service_account_key for interop tests

use a dedicated service account key for interop to prod tests.
Currently a service account key is used which has more privileges than needed for interop tests.
I created a dedicated service account just for interop to prod tests.
Storing in keystore is better than storing in GCS.
Also see internal b/79912536 for more context.

@nicolasnoble  @gnossen  this is now ready to review.

Known failures:
https://github.com/grpc/grpc/issues/18416
https://github.com/grpc/grpc/issues/18608


feat: introduce dunning billing status

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Introduce billing_status on the Subscription model, which will be used to show users a dunning butterbar if a subscription has a payment failed event with dunning enabled. This is done by listening for two separate webhooks from chargebee, one for payment failures and the other for payment successes and updating the billing status accordingly.
How did you test this code?
I used the webhook test feature built by chargebee to get the data format and added three new tests to cover the usecases. One test is a simple organisations list endpoint to ensure that the data is readable by a future JavaScript client.

Codecov Report
Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (99180cd) 95.54% compared to head (339e23a) 95.49%.
Report is 6 commits behind head on main.

:exclamation: Current head 339e23a differs from pull request most recent head 5be9bd8. Consider uploading reports for the commit 5be9bd8 to get more accurate results

Files
Patch %
Lines

api/organisations/views.py
55.35%
25 Missing :warning:

...ns/0008_add_manage_segment_overrides_permission.py
88.23%
2 Missing :warning:

api/app/settings/local.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
- Coverage   95.54%   95.49%   -0.06%
==========================================
  Files        1013     1015       +2
  Lines       29331    29515     +184
==========================================
+ Hits        28025    28185     +160
- Misses       1306     1330      +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


datafusion-proto with NestedLoopJoinExec fails

Describe the bug
This problem was found in Ballista's test: https://github.com/apache/arrow-ballista/actions/runs/5463474289/jobs/9944717531?pr=834
To Reproduce
datafusion = "27.0.0"
See: https://github.com/apache/arrow-ballista/actions/runs/5463474289/jobs/9944717531?pr=834
Expected behavior
No response
Additional context
No response

i am working on this


fix(AvatarGroup/ButtonGroup/MeterGroup): allow deeply partial ui config

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
At #2235, ui prop was made to allow deeply partial config using DeepPartial. But that change is missing on AvatarGroup, ButtonGroup, MeterGroup.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks! 😊


refactor: simplify regex + minor refactoring

This commit refactors a few positions in the code that triggers the GoLand linter.

/lgtm


Bug: Monitor numbering mismatch

I have the monitor config shown and I want to change monitor 1.  Inputting "1" ends up changing monitor 3.  Inputting "2" changes monitor 1.  Maybe Microsoft changed the way numbers are reported at some point?

Also I want to mention I really appreciate this app.  The lack of a proper API for this makes no sense.

Same issue here. Laptop display is 1, but I have to input 3 to change it. Does not change if I set "Make this my main display" to a different display.


feature: Add Sensitive Configfile(close #47)

添加了敏感信息配置文档

Codecov Report

Merging #49 (3cd082a) into V1.0.2rc (343e87f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           V1.0.2rc      #49   +/-   ##
=========================================
  Coverage     53.38%   53.38%
=========================================
  Files           177      177
  Lines          8719     8719
=========================================
  Hits           4655     4655
  Misses         4064     4064

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343e87f...3cd082a. Read the comment docs.


Develop PlotlyView - A generally reusable UIView for displaying Figures

To make the library easier to use on Apple's platforms (i.e. iOS/iPadOS/macOS) devices it makes sense to develop a generally reusable UIView. Such UI component can then be used as a "LEGO block" that displays a chart within a larger app.
PlotlyView should be a subclass of WKWebView and expose it's model as a settable property of type Plotly.Figure. Simply setting the figure object should be everything one needs to display a chart.
Here's an example use:
import Plotly

let trace = Scatter(
    x: [1, 2, 3],
    y: [3, 4, 5]
)

var view = PlotlyView()
view.figure = Figure(data: [trace])

Developing PlotlyView  helps a great deal with building the standalone viewer app per #7. For more details about the motivation and general background check out the discussion in #11.

Here's a few pieces of code that may be helpful to read before getting started:

Extension that uses WebView to display debugging visualization:
Plotly/Extensions/Playground.swift
Xcode playground for macOS that shows a plot in a WebView:
Examples/Playgrounds/

Here's a suggestted task list:

[ ] 1. Convert the playground example to use UIKit instead of AppKit (i.e. iOS/iPadOS instead of macOS). This is needed because we eventually want to use Catalyst to support macOS.

[ ] 2. Start iterating on the design of PlotlyView from the code converted in 1. The Xcode Playgrounds may be a good place to do it.

[ ] 3. Once the design of PlotlyView makes sense from a user's perspective, try to build a sample iOS/iPadOS application that shows a very simple plot. This may eventually end up in the Examples/ folder as a demo.

[ ] 4. Attempt #7 to see how the design works in a larger project. The point of doing this is to reveal missing features and delegate callbacks.


Display inline email attachments

Changes in this PR
Email attachments marked as "inline" are displayed within the email body as expected.
Screenshots of UI changes

 #248 - Display email attachments within email with download links


ios didFinishLaunchingWithOptions build issue

The docs say to modify AppDelegate.m/.swift in ios/Runner, but the current dev environment has didFinishLaunchingWithOptions in the file AppDelegate.swift. When I insert the recommended Swift code I get the following build errors (xxx used for privacy):
/Users/xxx/AndroidStudioProjects/xxx/ios/Runner/AppDelegate.swift:11:5: error: use of unresolved identifier 'GMSPlacesClient'
        GMSPlacesClient.provideAPIKey("xxx")
/Users/xxx/AndroidStudioProjects/xxx/ios/Runner/AppDelegate.swift:12:5: error: use of unresolved identifier 'GMSSServices'
        GMSSServices.provideAPIKey("xxx")

Here is the AppDelegate.swift file content:
import UIKit
import Flutter
@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?
  ) -> Bool {
    GeneratedPluginRegistrant.register(with: self)
    GMSPlacesClient.provideAPIKey("xxx")
    GMSSServices.provideAPIKey("xxx")
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}

flutter doctor
[✓] Flutter (Channel dev, v1.2.1, on Mac OS X 10.14.3 18D109, locale en-US)
    • Flutter version 1.2.1 at /Users/spencernassar/dev/flutter
    • Framework revision 8661d8aecd (4 days ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/spencernassar/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.0.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Connected device (2 available)
    • Android SDK built for x86 • emulator-5554                        • android-x86 • Android 9 (API 28) (emulator)
    • iPhone XR                 • 848A0357-2236-4306-8992-BCE930A2FB65 • ios         • iOS 12.1 (simulator)

• No issues found!

Got a clean build by adding imports to the AppDelegate file and fixing a typo in "GMSSServices" (too many S's). Recommend you address both these in the installation instructions.
import GooglePlaces
import GoogleMaps

Thanks for the suggestion!


METRON-1936: Cypress fails when trying to parse double quotes

Contributor Comments
Double quotes that are used inside the parser list component are causing a parsing issue for Cypress, even if you switch them out with html encoded double quotes.
Testing
You can reliably test against PR https://github.com/apache/metron/pull/1275
Clone the base branch from that PR and run npm run cypress:ci. You will see all the tests fail.
Clone this PR branch, merge into 1275's base branch and again run npm run cypress:ci. This time the tests will pass.
If you want to see the cryptic error message, you can also run ng serve --aot and then npx cypress open and run cypress' tests from its UI. There, you can see the error message in the Cypress tools console.
Future considerations
I didn't see any explanations for this issue in my research, but Cypress is now out of beta, so perhaps this issue has been silently addressed. It's worth looking into as a separate task, but this is a very quick, minimally invasive fix for now.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

I was able to get a passing test in https://github.com/apache/metron/pull/1275 after applying this change.  +1 pending we figure out the travis failure.

I've tried to reproduce this failure but to no avail. It was resolved by simply re-running the Travis build, and I'm pretty confident my changes here wouldn't cause such a failure.

I agree, I don't think that was introduced here.  +1


Error's with rocket after <IP_ADDRESS> update.

The server won't start up properly when using rocket on <IP_ADDRESS>, the console gets spammed by this error:
[10/28/2016 9:45:44 AM] [Error] TypeLoadException: Could not load type 'SDG.Unturned.LevelLighting' from assembly 'Assembly-CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. -
It would appear that the patching of the Assembly-CSharp file for this version has corrupted it in some ways, as the file size is considerably smaller than what the unmodified version of the file is, some 12kb smaller(it's usually no more than a 2-3kb difference in size.).

Looks like I may have gotten some of my files mixed up on my end, loading up build 1033 works fine on my server.


"patternfly" & "c3ChartDefaults" undefined when running Angular Patternfly standalone

Unable to run Angular Patternfly JS as a standalone script reference without including core Patternfly JS because of of multiple references and calls to the global patternfly object and subsequent method call to c3ChartDefaults ...
patternfly.c3ChartDefaults()

Purposing a quick fix within c3-chart-defaults.js similar to...
(function (window, patternfly) {
  'use strict';

  window.patternfly = patternfly || {};
  window.patternfly.c3ChartDefaults = patternfly.c3ChartDefaults || function(){ console.error('patternfly.c3ChartDefaults unavailable.\nhttps://github.com/patternfly/angular-patternfly'); return{} };

  var patternflyDefaults = patternfly.c3ChartDefaults();

:+1:

Sorry, I know I gave this a :+1: earlier, but why is this necessary?  Doesn't a-pf's npm/bower pull in core patternfly?  Doesn't our karma.conf pull in the required pf scripts?

Redirected towards PR #538 ...

@cdcabrera Can we close this or is the issue still standing?

@beanh66 we can close then re-open as necessary


Gemspec: Support rails 5

Hi @look
Removed activesupport dependency constraint to make the gem work with rails 5 alpha.
Please review and merge.
Thanks

Thanks for the submission!

Great thanks @look

I realize this is very old, but considering Rails 5 has been released, is there a chance a version with this change could be released?


Serialisation-improvement

Since collection are counted as instances, these should also be added as known objects during materialisation.

I will provide a new pull request, with a appropriate test


Upgrade PHPUnit version

Test an upgrade of PHPUnit versions

Codecov Report

Merging #2244 into 2.x will decrease coverage by 1.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #2244      +/-   ##
============================================
- Coverage     94.18%   92.96%   -1.22%
+ Complexity     1615     1580      -35
============================================
  Files            53       53
  Lines          4079     4054      -25
============================================
- Hits           3842     3769      -73
- Misses          237      285      +48

Impacted Files
Coverage Δ
Complexity Δ

lib/Site.php
54.28% <0.00%> (-45.72%)
18.00% <0.00%> (ø%)

lib/Cache/Cleaner.php
66.66% <0.00%> (-33.34%)
6.00% <0.00%> (ø%)

lib/Timber.php
86.66% <0.00%> (-5.93%)
40.00% <0.00%> (ø%)

lib/Loader.php
96.15% <0.00%> (-0.50%)
73.00% <0.00%> (-2.00%)

lib/Twig.php
98.75% <0.00%> (-0.11%)
37.00% <0.00%> (-14.00%)

lib/User.php
93.20% <0.00%> (-0.07%)
39.00% <0.00%> (-3.00%)

lib/Comment.php
91.30% <0.00%> (-0.06%)
61.00% <0.00%> (-3.00%)

lib/Term.php
96.29% <0.00%> (-0.05%)
55.00% <0.00%> (-4.00%)

lib/Post.php
96.88% <0.00%> (-0.02%)
196.00% <0.00%> (-4.00%)

lib/Admin.php
44.44% <0.00%> (ø)
3.00% <0.00%> (ø%)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81346e3...49337e3. Read the comment docs.


Does't work on 15inch macbook pro

I'm using a 15inch macbook pro(mid 2015) with OS X 10.11.  And when I launch the screen saver, I just saw a black screen with nothing.  Hope to fix it :)

I have the same issue, only this issue is only present when I do not have a scaled resolution.
I prefer to use a more space resolution, and then the screensaver does not work.
It does work when I put the screen on default resolution.

I just use the default resolution, still not work

I use the hot corner to launch the screen saver. When I launch it, the screen seems to be pure black.  After a short period of time, when I need password to return to the desktop. I clicked 'X' to cancel it and back to the screen saver. Strange thing happened, it just works! And I don't know why. ( poor English :( )

Error on console:
<<<< AVPlayer >>>> -[AVPlayer outputContext]: No figPlayer found, cannot set picker id
<<<< AVPlayer >>>> -[AVPlayer setOutputContext:]: No figPlayer found, cannot set picker id

I have the same issue. I get a black screen when I try to run on a 15 inch MacBook Pro
Here is the error I'm seeing in the system log
Oct 27 12:37:02 selma5 ScreenSaverEngine[17116]: [12:37:02.674] <<<< AVPlayer >>>> -[AVPlayer setOutputContext:]: No figPlayer found, cannot set picker id

I too have a 15 inch MBP and while the preview works, I get a circle with a line though it when the actual screensaver starts.

Mine is working now. I noticed in another thread about Little Snitch blocking it, so I checked and it was blocked. I made a rule to allow it and now it works fine.

I have a mid 2015 15" MacBook Pro running 10.11.1 and am not having any issues at all.

Maybe the network problem cause the issue

If any of you are still having issues, make sure you are running the latest version, try caching the videos and make sure the screen saver isn't being blocked by a firewall or proxy (like Little Snitch for example).


fix #115 for mysql 8.4.0

hi tx for contribution pls run composer cs:fix to fix code style

Any status of this PR or is there some other php 8.4 fixes in the works?

Any status of this PR or is there some other php 8.4 fixes in the works?

My project used this pr in product env.


[BUG] When we ssh to VM, the IP Address disappear on the virtual machine page

Describe the bug

When we ssh to VM, the allocated IP Address from vlan1 network would disappear from Virtual machine
https://github.com/harvester/harvester/assets/29251855/6bedaf28-c8e7-40ad-8e1f-5c394037cb65

To Reproduce
Steps to reproduce the behavior:

Upload a opensuse 15.3 leap no cloud image
Create a vlan1 vlan network on mgmt interface
Create a volume
Create a VM with opensue 15.3 leap image and use vlan1 network
Wait the VM started and display IP address on VM page
ssh to the VM
Check the IP address of VM on VM page and edit config

Expected behavior

After ssh to VM, the IP Address should not disappear on VM page
Support bundle

supportbundle_fc8c5ccb-0eab-4b54-902c-fd4faad9b9fe_2023-05-29T08-54-45Z.zip
Environment

Harvester ISO version: master-35717460-head (05/29)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): Single nodes on local kvm machine

Additional context
Add any other context about the problem here.

After several minutes the IP Address will come back
Currently exist on opensuse leap image

Used image url:
http://download.opensuse.org/repositories/Cloud:/Images:/Leap_15.3/images/openSUSE-Leap-15.3.x86_64-NoCloud.qcow2

@TachunLin I tried this on v1.3.1, and I do not see the issue. (Tried few iterations of same steps)
Can you please confirm if this might be fixed later after you saw the issue ? I do not see much clue from the support bundle collected as well.We might need the vm console logs during the issue state.

@rrajendran17 we have another similar case: https://github.com/harvester/harvester/issues/5251#issuecomment-2273952105
In this report, the cause seems to be the qemu-agent version.

@TachunLin @bk201 I am able to reproduce this issue locally consistently by creating multiple vms at the same time(10 vms).
I see the issue is seen in opensuse-leap-15.3 as well as opensuse-leap-15-6 images(this uses latest qemu-ga 8.2.5 version).
So in this bug the issue is not related to qemu-guest-agent.
I see the vm ips in the GUI flaps for once and then stays intact and did not disappear after that.
So I feel this could be related some interface reconfigured during init.I am debugging this further to find the root cause the issue.

Looks like the issue is due to the sequence of ips which kubevirt sees.
Kubevirt sees the ip from domain(pod ip) first which is given to the harvester UI
interfaces:

infoSource: domain
ipAddress: <IP_ADDRESS>
ipAddresses:

<IP_ADDRESS>
mac: 1a:8e:0d:da:18:d2

and later there is interface information from guest agent without ip address (while ip address was tried for dhcp)
which is updated to harvester UI (ip disappears from UI)

infoSource: domain, guest-agent
interfaceName: eth0
mac: 1a:8e:0d:da:18:d2

and later guest-agent/domain updates the ip address on the interface to kubevirt and again ip address is updated in harvester UI(ip address appears in UI)
interfaces:

infoSource: domain, guest-agent
interfaceName: eth0
ipAddress: <IP_ADDRESS>
ipAddresses:

<IP_ADDRESS>
mac: 1a:8e:0d:da:18:d2

Need to see how harvester UI fetches this info and updates UI, and see if address from just domain could be skipped.
The address should be updated in UI only when interface info(interfaceName) and by guest-agent is available.

Note: Above issue is seen only with mgmt interface and I am not able to reproduce with bridge interface.I tried with both ubuntu and opensuse-leap(15.3,15.6).
@TachunLin can you please confirm if this issue is still seen on vlan vm network ips ?

Above issue is seen only with mgmt interface and I am not able to reproduce with bridge interface.

If it only impacts the management interface then this is a different issue than https://github.com/harvester/harvester/issues/5251#issuecomment-2273952105 as that issue impacts bridge interface IPs as well.

@vwbusguy  yes this issue is completely different from https://github.com/harvester/harvester/issues/5251 not only from bridge interface ip perspective but also this issue happens only during start up (ip disappears  only once during start up and then comes back) and stays intact in UI after that.

Besides SSH, I hit another case that opensuse VM IP will disappear periodically w/o any operations.
And this can be reproduced both on local ipxe-example and baremetal.
Note that the root cause may relates to Linux OS-self behavior cuz we do not observe this on Ubuntu.
supportbundle_restore_new_ip_2024-08-22T07-11-37Z.zip
https://github.com/user-attachments/assets/951777e7-57d5-47ce-8eb4-a592b05a925d

With additional debugs enabled at qemu-ga and libvirt, it shows the interface statuses are retrieved and updated periodically every 120 seconds (2 minutes) by virt-launcher as expected, but after every few seconds after this updation, the harvester node UI loses the ip or the ip disappears in the UI.
2024-08-23 18:18:01.790+0000: 29: debug : qemuAgentCommandFull:1039 : Send command '{"execute":"guest-network-get-interfaces"}' for write, seconds = -1
2024-08-23 18:18:01.791+0000: 82: debug : qemuAgentIOProcessLine:214 : Line [{"return": [{"name": "lo", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "<IP_ADDRESS>", "prefix": 8}, {"ip-address-type": "ipv6", "ip-address": "::1", "prefix": 128}], "statistics": {"tx-packets": 30, "tx-errs": 0, "rx-bytes": 2432, "rx-dropped": 0, "rx-packets": 30, "rx-errs": 0, "tx-bytes": 2432, "tx-dropped": 0}, "hardware-address": "00:00:00:00:00:00"}, {"name": "eth0", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "<IP_ADDRESS>", "prefix": 21}, {"ip-address-type": "ipv6", "ip-address": "fe80::3845:5ff:feb8:838d", "prefix": 64}], "statistics": {"tx-packets": 15287, "tx-errs": 0, "rx-bytes": 53774336, "rx-dropped": 55065, "rx-packets": 337936, "rx-errs": 0, "tx-bytes": 2845439, "tx-dropped": 0}, "hardware-address": "3a:45:05:b8:83:8d"}]}]
2024-08-23 18:18:01.791+0000: 82: debug : qemuAgentIOProcessData:294 : Total used 776 bytes out of 776 available in buffer
2024-08-23 18:20:01.790+0000: 31: debug : qemuAgentCommandFull:1039 : Send command '{"execute":"guest-network-get-interfaces"}' for write, seconds = -1
2024-08-23 18:20:01.791+0000: 82: debug : qemuAgentIOProcessLine:214 : Line [{"return": [{"name": "lo", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "<IP_ADDRESS>", "prefix": 8}, {"ip-address-type": "ipv6", "ip-address": "::1", "prefix": 128}], "statistics": {"tx-packets": 30, "tx-errs": 0, "rx-bytes": 2432, "rx-dropped": 0, "rx-packets": 30, "rx-errs": 0, "tx-bytes": 2432, "tx-dropped": 0}, "hardware-address": "00:00:00:00:00:00"}, {"name": "eth0", "ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "<IP_ADDRESS>", "prefix": 21}, {"ip-address-type": "ipv6", "ip-address": "fe80::3845:5ff:feb8:838d", "prefix": 64}], "statistics": {"tx-packets": 15291, "tx-errs": 0, "rx-bytes": 53817315, "rx-dropped": 55165, "rx-packets": 338497, "rx-errs": 0, "tx-bytes": 2845703, "tx-dropped": 0}, "hardware-address": "3a:45:05:b8:83:8d"}]}]
2024-08-23 18:20:01.791+0000: 82: debug : qemuAgentIOProcessData:294 : Total used 776 bytes out of 776 available in buffer
When manually executed a command "kubectl get vmi  -w -o yaml" to get vmi status, I do not see any explicit qemuAgentCommand in qemu-ga, libvirt logs to fetch the interface statuses information.Need to add more debug logs to virt-launcher pod to understand the issue.

FYI: The qemu agent retured yaml is parsed via
https://github.com/kubevirt/kubevirt/blob/a8f8c2bdc2e2502425fa1bdb5db449ef8cc48d8f/pkg/virt-launcher/virtwrap/agent-poller/agent_parser.go#L264

Could you double check/confirm with following code change: thanks.
var interfaceStatuses []api.InterfaceStatus

		if interfaceStatus != nil {
			domain.Status.Interfaces = interfaceStatus
		}

->
		if interfaceStatus != nil && len(interfaceStatus) != 0 {
			domain.Status.Interfaces = interfaceStatus
		}

From the log, when the interfaceStatus is [], it may also write to upstream ?

Thanks @w13915984028 but I had added a check to confirm is interfaceStatus is nil everytime interfaceStatus is interfaceStatus[] and it prints nil and does not do any copy to domain.Status.Interface. So if the slice is empty, it will be nil, I believe explicit length check of the slice is not mandatory.
Though I can re confirm this once.

@rrajendran17 Thanks. Besides the callback, another known place is the vmi onchange, which will update the net status.
keyword is: updateVMIIfaceStatusWithGuestAgentData

@w13915984028 yes my understanding is also same. virt-launcher event update updates the domain.Status.Interfaces from data retrieved from qemu-ga periodically.And UpdateStatus in virt-handler updates the status into vmi object from domain.Status.Interfaces.
What we see in the output of kubectl get vmi  -o yaml (InfoSource, interfaces...) is from updateVMIIfaceStatusWithGuestAgentData by UpdateStatus from virt-handler

The difference I see between alma-linux9-0507(issue) and alam-linux9-0805(non issue) is that, alma-linux9-0507 has more frequent updates of the filesysteminfo.("guest-get-fsinfo",GET_FILESYSTEM) and alam-linux9-0805 does not have change in fsinfo from qemu-ga.
From below code ,it is evident that, we send agentUpdate whenever there is any change from qemu-ga, so frequent changes to fs-info triggers an update along with sending domainInfo as well during which domain.Status.Interfaces becoming empty though it is not updated during the flow.(cause unknown)
https://github.com/kubevirt/kubevirt/blob/ad71d984f8a56740104da236c03979cd8a0217b7/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go#L84
So the issue could be in kubevirt/virt-launcher along with trigger from underlying guest OS(whenever there is frequent update of fs-info during the agent polling)
The following code also looks incorrect to me as it sends update of domainInfo data in case of any change.Instead I think it should be only for (GET_OSINFO, GET_INTERFACES, GET_FSFREEZE_STATUS).If the aim is to only update domainInfo, then its not necessary to send update for other commands.
Existing code:
func (s *AsyncAgentStore) Store(key AgentCommand, value interface{}) {
oldData, _ := s.store.Load(key)
updated := (oldData == nil) || !equality.Semantic.DeepEqual(oldData, value)

s.store.Store(key, value)

if updated {
	domainInfo := api.DomainGuestInfo{}
	switch key {
	case GET_OSINFO, GET_INTERFACES, GET_FSFREEZE_STATUS:
		domainInfo.OSInfo = s.GetGuestOSInfo()
		domainInfo.Interfaces = s.GetInterfaceStatus()
		domainInfo.FSFreezeStatus = s.GetFSFreezeStatus()
	}

	s.AgentUpdated <- AgentUpdatedEvent{
		DomainInfo: domainInfo,
	}
}

}
Instead is it supposed to do the following
func (s *AsyncAgentStore) Store(key AgentCommand, value interface{}) {
    oldData, _ := s.store.Load(key)

    s.store.Store(key, value)

    switch key {
    case GET_OSINFO, GET_INTERFACES, GET_FSFREEZE_STATUS:
            updated := (oldData == nil) || !equality.Semantic.DeepEqual(oldData, value)
            if updated {
                    domainInfo := api.DomainGuestInfo{}
                    domainInfo.OSInfo = s.GetGuestOSInfo()
                    domainInfo.Interfaces = s.GetInterfaceStatus()
                    domainInfo.FSFreezeStatus = s.GetFSFreezeStatus()
                    s.AgentUpdated <- AgentUpdatedEvent{
                            DomainInfo: domainInfo,
                    }
            }
    }

}

I hit another case that opensuse VM IP will disappear intermittently w/o any operations. And the frequency of occurrence seems decreases over time (more stable over time)
Note that the root cause may relates to guest OS cuz we do not observe this on Ubuntu.
supportbundle_restore_new_ip_2024-08-22T07-11-37Z.zip
vokoscreenNG-2024-08-23_16-28-28-cut.mp4

Update a recent hit with SB.
As you can see, here we have sles15sp6, sles15sp4, ubuntu24 and rhel9, and sles experience similiar behavior as this issue.
supportbundle_UnstableIPShowing_2024-09-03T01-19-40Z.zip

@albinsun I have raised an issue with kubevirt community with analysis and following up with them on this.
https://github.com/kubevirt/kubevirt/issues/12698

The new SB attached by @albinsun provides solid evidence that the `vmi.status.interfaces is missing the related information
sles15sp4 vm:
    labels:
      harvesterhci.io/vmName: sles15sp4-20240903
      kubevirt.io/nodeName: harvester-node-1

    networks:
    - multus:
        networkName: default/ens5-vlan1
      name: default

    interfaces:
    - infoSource: domain, multus-status // IP is missing
      mac: a2:0d:db:c9:13:bd
      name: default
      queueCount: 1

the console log:
...
2024-09-03T01:06:25.408879877Z Welcome to SUSE Linux Enterprise Server 15 SP4  (x86_64) - Kernel 5.14.21-150400.22-default (ttyS0).
2024-09-03T01:06:25.408965276Z
2024-09-03T01:06:25.408977214Z eth0: <IP_ADDRESS> fe80::a00d:dbff:fec9:13bd
...

//////////////////////////
ubuntu vm:

    hostname: ubuntu24-20240903

    networks:
    - multus:
        networkName: default/ens5-vlan1
      name: default

    interfaces:
    - infoSource: domain, guest-agent, multus-status
      interfaceName: enp1s0
      ipAddress: <IP_ADDRESS>
      ipAddresses:
      - <IP_ADDRESS>
      - fe80::309b:6aff:fee9:a014
      mac: 32:9b:6a:e9:a0:14
      name: default
      queueCount: 1

There is an update on this issue from Kubevirt community.
They are working on some change in interface status area.Will post their conclusion soon.

I am taking 3 harvertes together. I've been using it for 2 weeks, it runs very stable. After I turned it off for 2 days, I got the error "server does not display cluster IP", please help. Thank you

@Dung10012003 I feel the issue you saw is not related to this one, do you mind creating another new issue? And please also provide more info: Like how many nodes there are in total, do rke2-server works on all nodes? Thanks.


Allow HA to manage unique IDs

Also from your screenshot this is now adding a suffix to the entity ID?

The place I want to get to is the user specifies a friendly name, and we generate a unique entity ID prefix from that (letting the  user customise it if they want?) and store both in config. https://github.com/nathanmarlor/foxess_modbus/issues/106#issuecomment-1493253114. Then we can go back to the user specifying a free-text name, but we're still in control of the ID.
That's why I didn't think #106 was ready to close yet. #138 was just a stop-gap.

Ah, it's reverting back to the entity name (and stripping chars). I'll have another look at this.

I don't think there's any way for HA to do this automatically -- you simply can't get around the fact that two friendly names might be escaped to the same thing by HA, yet we need them to be unique and we need to know which one maps to which friendly name.

I don't think there's any way for HA to do this automatically -- you simply can't get around the fact that two friendly names might be escaped to the same thing by HA, yet we need them to be unique and we need to know which one maps to which friendly name.

Agreed. Looking through the HA docs they essentially slugify the entity name with retries (appending _1, _2 etc.) on each time. I've mirrored this but I can't decide if it's better or worse :)

That doesn't change to lower case, and I'm not sure what else it might be missing?
It's also bad UX, if we tell them they've for a duplicate friendly name and they entered two different things (which happened to slugify to the same thing)

Some people care about what their entity id is, so I'm not sure that springing it on them after they've finished the config flow is nice?
If we had a powerful enough config flow UI I'd let them enter the name, the generate the entity id on the fly and let them edit it. Maybe we could do the same by having two steps? Although this is starting to conflict with my rework of the config flow in that other PR.

Presumably the HA API must have a way of finding an entity_id from Friendly name (and potentially return more than one) - can you use that when setting up the power dashboard (i.e. build friendly name, then lookup entity_id from that rather than try and deduce entity_id)?

No, HA has no concept of a friendly name.

How about something like this?

So if you leave it blank, we'll try and generate one ourselves by slugifying the friendly name. If we fail...

Superseded by #194


Add effect

Description
Add a mouse effect when moving the mouse. The effect should be rendered effect like a render small food icons.
fix the company logo it is not link.
Fixes:  #652
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@khushi-joshi-05  @sunny0625

check your changes in 😎 Deploy Preview navbar Spoiled and both logo showing in the menu webpage.

@khushi-joshi-05 @sunny0625


BUGFIX: Reuse DBAL connection if parameters are equal

Fixes: #182

BTW: I just realized that this still won't share the Flow connection even if that's set up.. Should we do that?

Not sure. My stomach says no. We'd need too much internals of Flow and then there would probably be weird side effects.

Closing, see https://github.com/neos/Neos.EventSourcing/issues/182#issuecomment-466445540


[question] is it possible to avoid default attributes being applied, when using mjmlToJson?

first of all, thank you all a lot, for your great work on this amazing editor!
to my issue.. I want to convert an existing mjml template to JSON, for using it in the builder.
the template contains a section as simple as this:
<mj-section background-color="#dc0f0f">
but, after converting it to JSON, it gets a lot more attributes:
{
  "type": "section",
  "data": {
    "value": {
      "noWrap": false
    }
  },
  "attributes": {
    "background-repeat": "repeat",
    "background-size": "auto",
    "background-position": "top center",
    "border": "none",
    "direction": "ltr",
    "text-align": "center",
    "background-color": "#dc0f0f",
    "padding": "20px 0px 20px 0px"
  },
  "children": []
}

(this is just an example, I assume the same happens with all other type of elements/blocks)
I believe this happens here, basically:
https://github.com/zalify/easy-email/blob/d0d65382c0e0cc11185db65f3829b78231153378/packages/easy-email-extensions/src/utils/MjmlToJson.ts#L132
due to the default attributes defined on the Block:
https://github.com/zalify/easy-email/blob/d0d65382c0e0cc11185db65f3829b78231153378/packages/easy-email-core/src/blocks/standard/Section/index.tsx#L29-L64
is there a way to prevent all these defaults from being applied?
thank you in advance for any help!

There is currently no such feature, and I don't know why the redundant attributes should be removed, since they can be displayed to the user for viewing.
If you want to add this feature, myabe only need to modify a few lines of code, if you are willing to provide a PR.
const blockData = applyDefaultAttributes ?  block.create(payload) : payload;

thank you for the tip @m-Ryan !
you're right, it probably doesn't make sense as a new "feature".
if all that's doing is adding default attributes, just exactly how mjml would be doing under the hood,
I agree it's better to show them explicitly, for the user to see them.
it was an issue for me, because I was implementing something to have the mj-head's mj-attributes "inlined" on the affected elements, but this would have been happening after the conversion to json, so, I can't tell at that point if the attributes were already in the template, or were mjml's defaults applied during the conversion.
for example:
<mjml>
  <mj-head>
    <mj-attributes>
      <mj-section padding="15px 15px" background-color="blue"/>
    </mj-attributes>
  </mj-head>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text>
          Hello World!
        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

converted to json usnig MjmlToJson, the headAttributes are simply stored on the Page object ($.data.value.headAttributes) and nothing more happens with them I think? (except being editable in the source code box)
then, the section as json, will have

padding: "20px 0px" explicitly set, based on the mjml's defaults - now "overriding" the mj-attribute in head
(background-color : undefined): visually is blue, but attribute is absent from the object, so, the colorpicker is not pre-set with the "default value" provided by the mj-attribute

so, I'm wondering if I'm missing something, or if handling of the mj-attributes could be improved?

it woudn't be better to inline those attributes on the affected elements, during the conversion, to show the backgorund-color colorpicker pre-set with the "blue" value?
or, alternatively, prevent the defaults from being set by the "block initialization", for those attributes that have already an alternative default value in mj-head's attributes?

with the first option all attributes would be explicitly set, I would be fine with that, but maybe someone would prefer to be able to edit the mj-attributes in the source code, and see the changes propagated to all the matching elements.
with the second, based on the example, the inputs for the padding would stay empty to not interfere with the mj-attribute work-ability
what do you think? maybe I can help have something like this implemented..

There are two ways

Parse the data of mj-attributes,  and add blockAttributes to page, like { "section": {"background-color": "blue"} },
Merge when rendering.

{
 type: "page",
 data: {
   value: {
    ...
    blockAttributes: { "section": {"background-color": "blue"} }
   }
 }
}

Parse the data of mj-attributes, like <mj-section padding="15px 15px" background-color="blue"/>, temporarily store it as globalBlockAttributes, and merge the corresponding block in MjmlToJson.

For now, I think the second will be less work

@m-Ryan thank you for these hints, and your support.. eventually I simply went for something like https://github.com/zalify/easy-email/issues/310#issuecomment-1540427896 (it's just a bit more complex than that)
I'm closing this, since I wouldn't really know what is best to do and how to do it
(In the end I kinda like the placeholders idea, but it's also the most work probably, touching parts of the app I've never actually looked at, like obviously the attributes-panel)
If you anyways feel like some improvement is needed in this area, of course don't esitate to open another issue and copy over anything you think is worth porting there


Typo fix: Defualt -> Default

Typo fix: Defualt -> Default

Thanks @NKCSS!

You're welcome @DanielRosenwasser :)
N.B.
I noticed there's quite some difference between the version that's viewable online (http://www.typescriptlang.org/Handbook) and the one here in the git repo; how/when is that updated?


Feature request: Support C/C++ project types

Would it be possible to add support for C/C++ projects? Not sure how difficult this is but it would be very helpful and expand the potential use of this extension.

@fernandoescolar I would be interested in taking this on with some guidance.


Variant Annotation branch - initial API draft

Comments are invited on the initial draft of the variant annotation API
https://github.com/ga4gh/schemas/tree/variation_annotation

Here are my comments.

It looks like there are a few places (like SearchVariantsRequest) where
strings are used but OntologyTerms might be more appropriate.

Should SearchAllelesRequest be modified like SearchVariantsRequest is?
Or, more generally, are Alleles going to be annotated with effects, or only
entire Variants?

Shouldn't AnnotateVariantsRequest take variant IDs as opposed to entire
variant objects? If the idea is that you are sending in new Variants that
don't yet exist on the server, wouldn't you also need to be able to send
the new Alleles that they might reference (since a Variant in graph mode is
no longer required to contain any sequence data itself)?

How compatible is this with the g2p work in #268? It seems like there is
some overlap with respect to annotating the effects of variants.

On Tue, Apr 21, 2015 at 10:05 AM, Sarah Hunt<EMAIL_ADDRESS>wrote:

Comments are invited on the initial draft of the variant annotation API
https://github.com/ga4gh/schemas/tree/variation_annotation
—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/issues/290.

Thanks for the comments!
On 21/04/2015 19:06, adamnovak wrote:

Here are my comments.

It looks like there are a few places (like SearchVariantsRequest) where
strings are used but OntologyTerms might be more appropriate.

Thanks, this is updated now - it was an oversight.

Should SearchAllelesRequest be modified like SearchVariantsRequest is?
Or, more generally, are Alleles going to be annotated with effects, or
only
entire Variants?
Annotation is allele-specific, so we intend to update the
SearchAllelesRequest and Allele records, but I was not sure they were
stable yet.
Shouldn't AnnotateVariantsRequest take variant IDs as opposed to entire
variant objects? If the idea is that you are sending in new Variants that
don't yet exist on the server, wouldn't you also need to be able to send
the new Alleles that they might reference (since a Variant in graph
mode is
no longer required to contain any sequence data itself)?

The idea behind this method is that data extracted from one GA4GH server
can be annotated using a different one, so  yes - an
AnnotateAllelesRequest will be needed.

How compatible is this with the g2p work in #268? It seems like
there is
some overlap with respect to annotating the effects of variants.

Someone from the G2P group may like to comment, but as I see it G2P
seeks to describe previously observed associations between features
(obviously, including variants) and phenotypes, while these changes
describe predicted outcomes when the variants are compared to other
features. G2P FeaturePhenotypeAssociation's will be added the the
Annotation record when they are stable as we will want to report
associations on overlapping/co-located variants.

On Tue, Apr 21, 2015 at 10:05 AM, Sarah Hunt<EMAIL_ADDRESS>wrote:

Comments are invited on the initial draft of the variant annotation API
https://github.com/ga4gh/schemas/tree/variation_annotation
—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/issues/290.

—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/schemas/issues/290#issuecomment-94891569.

I think there are two things to discuss here -- the overall model for how annotations fit into the API, and the details of what fields are in an individual annotation. This comment addresses the first one. As a starting point for discussion, here's my understanding of the model (based on https://github.com/ga4gh/schemas/compare/variation_annotation; if there's a better way to see the substance, please let me know).

introduce a new Annotation object, which contains several fields including new AnalysisResult objects, new Analysis and OntologyTerm objects being proposed elsewhere, and a bunch of strings
introduce a new annotateVariants method that, given an array of Variants,  uses an unspecified algorithm to associate  an array of Annotations with each one. (Which I think implies that every "row" in a VariantSet can contain a single array of annotations.)
add new optional search params to the searchVariantsets method to filter by annotation values (e.g. effects, geneIds, transcriptIds)

Is that right? If so, that seems very parallel to today's VCF-based model, where you can run tools (e.g. Annovar) that add columns to a VCF file. Questions:

how does a client specify what sort of annotation algorithms they want to create? (Since I don't see any relevant parameters to annotateVariants)
how would a client maintain multiple versions/sources of annotation info, so that (e.g.) you could compare results from a new version of Clinvar?
what (if any) other API models were considered, and what were the tradeoffs that led to this proposal?

I'm sure others who are closer to the bio will have followup questions, but let's start by making sure we're all starting on the same page.

@dglazer: The overall understanding of the model is correct.
Question 1: It is true that annotateVariants should have a set of parameters to specify which algorithms to run in the annotation, we should add that. In my opinion, there should be a sensitive default (should this be implementation specific?). For instance, in most cases it makes sense to add at least functional annotations, after all that's the goal of 'annotateVariants'.
Question 2: Some of this is maintained implicitly in AnalysisResult which tracks version numbers. But perhaps what you are asking is for the introduction of a "AnnotationSet" object. Is this correct?
Question 3: One of the goals here was to simplify the old PR #126. In that PR many people contributed interesting ideas but after adding many of them the PR turned out "to big and complex to be accepted". Fortunately many of those ideas are now part of new groups such as g2p, ontologies and genomic-features; so we can just refer to those objects.

:+1: on the content addressable data id field.
A field that was listed as mandatory in the VCF Annotation Format Doc, that @pcingola and others created, that doesn't seem to be present is "Putative_impact". Should this be included in the schema?
Another field that might be useful is a "warning" field that was proposed in that same document. This was listed as an optional field. However, I think the defining difference between a warning field and the other field listed as optional (eg distance to feature) is that it is not computable after the annotator has run. These warning and errors need to be at the level of variant-feature pair as they do not apply to the entire analysis run. Additionally, this field could be useful to identify difficult to annotate variants programatically.
Finally, with respect to @dglazer's question 1, the schema doesn't seem to support an arbitrary key,value map, correct? (Maybe this is the purpose of array?) In any case, should the default set of annotations to produce just be the fields defined in the Annotation schema? Even with an arbitrary mapping field, this still seems like a sensible default sense the schema covers  all the mandatory fields defined in the variant annotation format doc.

DRAFT:
Thanks @pcingola; more inline.

Question 1: It is true that annotateVariants should have a set of parameters to specify which algorithms to run in the annotation, we should add that. In my opinion, there should be a sensitive default (should this be implementation specific?). For instance, in most cases it makes sense to add at least functional annotations, after all that's the goal of 'annotateVariants'.

I think the number of possible annotation algorithms / flavors is huge, so I doubt any pre-defined set of parameters can be close to complete. One option is to let each implementation define their own custom params. Another option is to instead provide a writeAnnotations call, so that people can write annotation clients that use whatever algo they want, and store the output via the GA4GH API. Another option is a different overall data model -- see below.

Question 2: Some of this is maintained implicitly in AnalysisResult which tracks version numbers. But perhaps what you are asking is for the introduction of a "AnnotationSet" object. Is this correct?

Yes, or more precisely, AnnotationSets are one way of addressing the requirements I'm asking about. I think there are always going to be multiple ways to annotate any given variant, and ideally our API would support users who wanted to work with more than one of them, either at a time or over time.
From first principles, I think of one variant being associated with many possible annotations, and with many possible calls; annotations aren't directly associated with individual calls. That model is roughly captured in annotated VCFs by having one row per variant, with a column for each call, and a column for each annotation. I understand why that makes sense in a file-centric world, but it has the problem of needing to re-build and re-distribute the whole VCF, including all the calls, whenever you want to work with new or changed annotations.
In our API-centric world, I think we can do better, by defining a concept like AnnotationSet to manage multiple possible variant-to-annotation mappings, without conflation with the existing variant-to-call mapping. If that model makes sense, we can talk about API details; I believe CH has already shared some initial thoughts elsewhere.

Question 3: One of the goals here was to simplify the old PR #126. In that PR many people contributed interesting ideas but after adding most of them the PR turned out "to big and complex to be accepted". Fortunately those ideas are now part of new groups such as g2p, ontologies and genomic-features; so we can just refer to those objects.

I think this PR differs from #126 in two ways:

the details of what fields are in an annotation: I've looked a lot less closely here, since others are more qualified than me on the bio, but I agree this PR feels noticeably simpler; thank you
the overall model of how annotations fit into the API: that's what I'm focused on in this thread. #126 proposed a single new searchVariantAnnotations method that returned an array of GAAnnotationVariant objects (equivalent to this PR's Annotation objects). I think I prefer that approach, since it better reflects the data model I discuss above.

@dglazer - thanks for the comments - we are clearly seeing this from different angles.
The key use-case we are considering is a set of variants being submitted to an annotation server, results calculated on the fly and returned - in essence, making GA4GH-compliant VEP,  SNPEff, etc servers. Your comments suggest a model of multiple pre-calculated sets of annotation which can be mined, which makes total sense. ( We haven't been able to do this, as we don't know in advance what data will be submitted. Reproducibility is handled by tying specific software versions to specific reference data releases - not currently modelled well here.)
We chose to add the Annotation record to the Variant record ( and later planned to add it to the Allele record) as it keeps the API simple for end users and we don't need to worry about keeping location/path/etc definitiions in sync across two different variant/allele records. As calls are optionally returned, annotation could be optionally returned too.
Having explained how we got here, more details on what you are suggesting would be good.

I've made a few updates based on comments so far.
@andrewjesaitis - thanks for the comments - I've copied 'impact' in from the previous PR and added support for arbitrary key,value pairs. I would hope most information would fit the AnalysisResult format, but guess some will not. Would the warning information you mention fit this structure?
I've grouped the location information in a new allleleLocation record. @pcingola - what do you reckon to this? I'm not sure I like the name, but the concept is tidier.
@dglazer - I've not re-structured the variant<-> annotation relationship, pending further discussion, but I have added a draft annotation to start that debate.
Thanks all!

@sarahhunt , thanks for your comments -- reading them, I realize I might be confused about something pretty fundamental in your model. Earlier I said:

introduce a new annotateVariants method that, given an array of Variants, uses an unspecified algorithm to associate an array of Annotations with each one. (Which I think implies that every "row" in a VariantSet can contain a single array of annotations.)

That implies that annotateVariants actually changes the contents of the VariantSet, with the results being persistently stored by the server, so that future users can retrieve Variants with annotations already in place. Is that right?  When you say:

The key use-case we are considering is a set of variants being submitted to an annotation server, results calculated on the fly and returned

that sounds more like an ephemeral one-time lookup, with nothing being persisted on the server. Which model do you have in mind? (I don't think either is better on all dimensions; I just want to be sure we're discussing the same thing.)
Also -- sorry if I missed this earlier -- is anyone implementing a prototype of these new annotations methods in parallel with them being defined, or are we still in the rough consensus stage, with running code to follow?

@dglazer Are you also performing effect prediction such as with SnpEff?  Could you help me by pointing me to where CH posted something regarding this, since I can't seem to locate it.
Some annotation tools have been implemented with parallelism in mind, just depends on the scale and design in type of parallelism we would like to take.  For instance GATK's VariantAnnotator has this using the -nt argument via the TreeReducible interface:
http://gatkforums.broadinstitute.org/discussion/2266/using-the-gatk-api-to-annotate-my-vcf
https://www.broadinstitute.org/gatk/gatkdocs/org_broadinstitute_gatk_tools_walkers_annotator_VariantAnnotator.php
Also SnpEff from Pablo (@pcingola) provides multithreaded support which can be used with the -t option.
It would be helpful if you could diagram something regarding the design you have in mind.  I think I know what you mean, but you know what they say about assuming things :)
As an aside, maybe it might be helpful having a list with examples somewhere - including the inputs and outputs - of what is currently out there, just as reference, so that we could start from the same point.  Then we can tweak several example code-snippets with the purpose of brainstorming ideas regarding the scalable approach(es) - with the scope of the feature-set - that we would like to ensure for our API to support.
Thanks,
Paul

Sorry @dglazer  - I realise I asked for comments (after a long discussion on the variant annotation call) without giving much explanation which is likely to confuse anyone not on the call!
We at Ensembl and @pcingola provide annotation tools to which people submit variant data which may be novel, so we calculate annotation on the fly and do not store the submitted variants or annotation. This is what motivated the annotateVariants method  - we hoped to make these tools GA4GH compliant. The method was not intended to change any stored data.
@jacmarjorie raised the requirement for searching variant sets which have pre-calculated annotation which prompted the additions to searchVariants.
The idea behind updating the variant record was to group a set of annotation records within each variant ( and later allele) record, so if the response is a batch of a few thousand variants, it is simple to loop through all annotations for each variant at a time, applying filtering logic as required. I quite liked the idea of being able to search for all potentially damaging variants across a gene region and the genotypes of these variants in a trio, but maybe this is better done as seperate calls.
I have a prototype of the new methods - it's pretty rough as I don't want to spend time on optimisation until we have consensus, but it was needed to test the proposal would work.

Looks good to me @sarahhunt.
Yes, I think warnings/errors can easily fit into the key/value store. And it looks like all mandatory annotation fields are now all top level fields and all the optional outputs can fit in info.
Thanks!

A few comments following offline discussion:
After thinking further, I think there are two logical pieces to this PR: (1) defining a variant annotation resource: how they are persisted, how can be queried, how they are grouped e.g. annotationSets and (2) adding a stateless /variants/annotate method which utilizes this resource. (1) is independent. (2) depends on (1).
Variant annotation resource
I think it's really important to get this right independently. My only major concern with the current proposal is around putting annotations directly on the variant. I see that it adds client convenience, but it also adds a good deal of complexity to the already large searchVariants endpoint; implementations will have to support or handle all combinations of annotation and call-specific fields. It also feels like there's some unnecessary conflation with call data. Perhaps this will be cleaner on the allele and genotype resources when those resources are finalized.
The alternative would be to have Annotation as a separate object and refer to the annotated variant by allele/genotype and/or variant id.
/variants/annotate
Right now, I'm wondering whether this should be an application built on top of the GA4GH API, or part of it. I think the trick to adding it as a method will be in striking the balance between specificity of behavior (and usefulness to clients) and feasibility of implementation. I imagine that the true full list of parameters to this method is quite long and complicated. A few comments:

Semantics of the /variants/annotate endpoint differ pretty substantially from those of the existing GA4GH endpoints. It may make sense to split this into an alternate protocol or in some other way distinguish it from the standard variants API.
/variants/annotate needs documentation on its behavior.

What does it do? I guess the description would need to be vague enough to allow for a variety of subjective implementations. As an implementor I would need to have an idea of how to implement the method.
Presumably two identical calls to the same endpoint should always yield the same result; except for the Analysis(?). Is there something in there to allow disambiguation between two runs performed against different versions of the server's implementation (or knowledgebase, even)?
Should state that each variant is annotated independently, i.e. calling annotate([v1]), annotate([v2]) yields the same result as annotate([v1, v2])
If a variant winds up with 0 annotations, is it returned?
Should state that this method has no side-effects, i.e. nothing is mutated.

I also haven't been on the annotation calls, although I think I will start because it sounds interesting.

The key use-case we are considering is a set of variants being submitted to an annotation server, results calculated on the fly and returned - in essence, making GA4GH-compliant VEP, SNPEff, etc servers.

+1!  All I'd like to see is for the schema/protocol to support annotation as a service.
In my mind that means the annotation server acting as a proxy to the data API, streaming variants through it and annotating them as they pass, ie. Annotator pulls variants from data service.  The implication of that is that the request type of the annotation server contains the address of the data server and the data request payload in addition to the annotation-specific fields (database versioning, etc.).  Alternatively it could be defined as a superset of a variants request with the annotation-specific fields added, but I feel like the former is cleaner.
I may be mistaken, but the model being proposed appears to be one where the user uploads data to the annotation service, which then spools it up and returns it, ie. User pushes variants to annotator.  If this is so, I worry about scalability problems.  The "annotator pull" model allows annotators to work like generators and doesn't require them to keep a lot of data in-flight in order to service a request.  Also, in the "user push" model the variant data is using triple the user's bandwidth (and increasing the surface area for attack).

that sounds more like an ephemeral one-time lookup, with nothing being persisted on the server. Which model do you have in mind?

If there's sufficient database versioning in the request/response, what's the difference if it's computed on the fly or if it's cached?  Maybe it hasn't been explicitly stated, but IMHO supporting referential transparency is a critical goal here for both research (reproducibility) and clinical use (liability).

There is no reason not to have both approaches implemented.  So the annotation process can go through multiple phases:

An initial one to map to Annotation data stores/objects that have become more stable.
A secondary, more customized one where the variants are pushed through a service to provide a more comprehensive result including effect prediction, among other things.

@calbach, could you please provide some documentation/diagrams/code-examples on what you have in mind.  Then we can focus through those examples.
@bartgrantham, I understand the concern regarding scalability, but these days those have already been solved in the areas of distributed/parallel algorithms and data-structures.  Once we have some concrete diagrams and logic behind how the different approaches should be implemented - including code examples - then we can adjust accordingly and categorize each approach.
Thanks,
Paul

Just got this right now from the Broad. It's a service for annotating cancer-related variants that draws information from 14 publicly available cancer resources - so this could combine both approaches:
http://www.broadinstitute.org/oncotator/

@calbach - thanks for the comments. After discussions with you and @diekhans, I've moved the variants/annotate to a separate annotateAllelemethods protocol. As there are advantages and disadvantages to both approaches to the variant <-> annotation relationship, I thought it would be worth discussing it with the broader group later today.
@bartgrantham - nice idea to have the annotator pulling variants from a specified data server! We don't expect all variants requiring annotation to exist in public collections, which is why we wanted to support the submission of variant objects, but that doesn't mean we can't allow both models.

@sarahhunt I can't seem to find where annotateAllelemethods is defined.  Could you please point me to the file and the time/place that the discussion will take place?
Thanks,
Paul

@sarahhunt - I actually wasn't thinking about public datasets as much as I was about the GA4GH APIs becoming industry standards.  Some vendors can sell a data management layer, some vendors can sell an annotation layer, etc. with all layers only within a single organization's network.  My mind is really on a clinical use case where a "pluggable layer" approach would be most welcome.
IMHO, the UI (or program) where a user is presented with (or analyzing) the annotation data shouldn't need to juggle querying and collecting the variants, then shuttling them to the annotation servers, then collecting the resulting annotated data.  But the more I think about the separation of concerns WRT parallelization, I'm thinking that ultimately this kind of API layering will need a mechanism for demultiplexing/multiplexing the data streaming between layers.  Probably getting ahead of myself. :)

@bartgrantham - I see what you mean. You're thinking a bit further ahead than I was. I've added a comment about this for now until we try some prototyping.

@sarahhunt I think @bartgrantham might be referring to some of the ideas I posted a month ago at the following link:
https://github.com/ga4gh/schemas/issues/264#issuecomment-90081657
In any case, one step at a time :)  Let go through https://github.com/ga4gh/schemas/pull/302 and hash it out, and then go through the testing of it via server, and after that a scalable proof-of-concept, since there are several approaches in that domain we can try out.
I'm excited - it'll be fun ;)
~p


Refactor showView() to return a Promise

This is in anticipation of having the view rendering functions it invokes also return Promises.
Also contains:

Return a Promise from landingView
Push empty hash check to top of showView
Creates UNKNOWN_USER constant

Coverage increased (+0.003%) to 97.882% when pulling f703f8e71c705a5dfb75ec8be1e1f3619a322d43 on show-view-promise into 274f35e8fc842fa59bc0035c00e6e57ebff32411 on master.


Sample does not work since last pull (master)

just pulled all updates on master. sample does not work anymore.
F:\git\pelite>cargo run --example readme --verbose
       Fresh rand_core v0.4.2
       Fresh derive_pod v0.1.0
   Compiling pelite-macros v0.1.0 (F:\git\pelite\src\proc-macros)
       Fresh lde v0.3.0
       Fresh format_xml v0.1.4
     Running `rustc --edition=2018 --crate-name pelite_macros src\proc-macros\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 -C metadata=151799de88e00789 -C extra-filename=-151799de88e00789 --out-dir F:\git\pelite\target\debug\deps -C incremental=F:\git\pelite\target\debug\incremental -L dependency=F:\git\pelite\target\debug\deps`
       Fresh winapi v0.3.8
       Fresh rand_core v0.3.1
       Fresh dataview v0.1.1
       Fresh rand v0.5.6
warning: Hard linking files in the incremental compilation cache failed. Copying files instead. Consider moving the cache directory to a file system which supports hard linking in session dir `\\?\F:\git\pelite\target\debug\incremental\pelite_macros-2q51qzau2rdk2\s-foffd03rb1-1m2wgq5-working`

error[E0432]: unresolved import `proc_macro`
 --> src\proc-macros\lib.rs:1:5
  |
1 | use proc_macro::*;
  |     ^^^^^^^^^^ use of undeclared type or module `proc_macro`

error[E0412]: cannot find type `TokenStream` in this scope
  --> src\proc-macros\lib.rs:15:33
   |
15 | pub fn pattern_attribute(_args: TokenStream, input: TokenStream) -> TokenStream {
   |                                 ^^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `TokenStream` in this scope
  --> src\proc-macros\lib.rs:15:53
   |
15 | pub fn pattern_attribute(_args: TokenStream, input: TokenStream) -> TokenStream {
   |                                                     ^^^^^^^^^^^ not found in this scope

error[E0412]: cannot find type `TokenStream` in this scope
  --> src\proc-macros\lib.rs:15:69
   |
15 | pub fn pattern_attribute(_args: TokenStream, input: TokenStream) -> TokenStream {
   |                                                                     ^^^^^^^^^^^ not found in this scope

error: aborting due to 4 previous errors

Some errors have detailed explanations: E0412, E0432.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `pelite-macros`.

Caused by:
  process didn't exit successfully: `rustc --edition=2018 --crate-name pelite_macros src\proc-macros\lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C debuginfo=2 -C metadata=151799de88e00789 -C extra-filename=-151799de88e00789 --out-dir F:\git\pelite\target\debug\deps -C incremental=F:\git\pelite\target\debug\incremental -L dependency=F:\git\pelite\target\debug\deps` (exit code: 1)

Hey, thanks for taking interest in pelite!
Unfortunately I cannot reproduce your error. The error itself is odd and comes from being unable to find proc_macros crate in a proc macro. I don't get how this is possible. Perhaps you're using a weird or old version of rustc?
Can you include the output of rustc -vV && cargo -vV? Eg. for me this outputs:
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-pc-windows-msvc
release: 1.44.0
LLVM version: 9.0
cargo 1.44.0 (05d080faa 2020-05-06)
release: 1.44.0
commit-hash: 05d080faa4f2bc1e389ea7c4fd8f30ed2b733a7f
commit-date: 2020-05-06

i really like pelite :)
yeah something was wrong with my local installation. i did rustup and it didnt work with stable and unstable channels. after a complete reinstall everything works again. sorry for bothering u.


When there is no valid fix the messege is not parsed

Today the gps returned the folloing string:
$GPRMC,150449.000,L,4239.5210,N,02318.7727,E,39.75,326.93,040915,,*38
parse function decode this to:
{ raw: '$GPRMC,150449.000,L,4239.5210,N,02318.7727,E,39.75,326.93,040915,,*38',
valid: false }
Although there is no valid GPS fix from the satellite the data still can be parsed and the coordinates set

The state L to mean?. I only know the states A (active) or V (void)

Hm.... I not really sure actually. In the device comunicataion manual it is state that only A and V are returned. May be it is a bug in the device, but I think it would be better for the data to still be parsed and the state to be; Unknow instead of nothing.


[Scala] Test 4 Step 4 : Test is not constistent

Actually, in case of a requake, the test named "notify followers when a followee requacks a message" (https://github.com/DevLyon/mixter/blob/scala/v2.1/domain/src/test/scala/mixter/domain/subscription/handlers/NotifyFollowerOfFolloweeMessageSpec.scala#L31), ask us to notify followers of the author message instead of followers of the requacker message
Potential fix (https://github.com/DevLyon/mixter/blob/scala/v2.1/domain/src/test/scala/mixter/domain/subscription/handlers/NotifyFollowerOfFolloweeMessageSpec.scala#L35) :
--- followerRepository.saveFollower(AuthorId, AFollowerId)
+++ followerRepository.saveFollower(RequackerId, AFollowerId)

done


feat: Add promise based api

All methods return a promise when not passed a callback
Closes #80

After the past discussions about having a promises implementations and the implications that would bring, this seems by far the most elegant solution (as it is almost minimal and only touches the code partially and gives the desired feature).
Before merging, I would like everyone that chimed in on the promises API discussion to give their review (if possible). The discussion happened here https://github.com/ipfs/js-ipfs-api/issues/80 and the people involved are: @VictorBjelkholm, @RichardLitt, @harlantwood, @travisperson and @bcomnes

+100

I really hope this gets merged!

LGTM!

It is time.. :)

whoo

@jbenet You mentioned that you would like to discuss this. Here is the relevant PR for that discussion.


16 Likes. 6K F Yous.

This is a silly issue, but what do you see here?

I see heart, 16, middle finger, 6K. In the US, the middle finger means ... dislike.
Now I realize 6K is really the number of downloads. But just look at it.

Interesting, I never saw it as such- It's a downward pointing arrow, like ⬇
How would you suggest we modify it to look like an arrow?

Don't listen to gitfoxi, that is clearly a down arrow.


Assigning random security groups by default is not ideal behavior.

Version

Karpenter: v0.0.0

Kubernetes: v1.0.0
Expected Behavior

I recognize that the documentation points out that if you use the cluster name tag, it will randomly assign security groups, but I can't imagine a single situation where this would be desired behavior.  Either it needs to be deterministic, or it shouldn't provision nodes at all using that selector.   It's especially bad that choosing that tag is the default if you don't specify it!  This is going to break clusters quite frequently if people just don't specify a different tag.
Actual Behavior

Applying random security groups is fairly unexpected and it makes it extraordinarily difficult to troubleshoot if you aren't expecting it and can have catastrophically bad outcomes for the cluster -- in our case, it was a cluster-wide outage that took out core functionality like coredns.
Steps to Reproduce the Problem

Resource Specs and Logs

Agree that the nondeterministic behavior is a problem. We'd like to address this at the root with the LB controller relaxing their single-sg requirement. In the short term, I think we should probably just alphabetize to ensure deterministic behavior.

Personally, I think I'd prefer that it not be the default setting -- just make it a required field unless you've got a tag that does what one would naturally expect

I could see potentially including all security groups, and leaving it up to the user to define a security group selector that does not violate the LB controller's assumptions.

I recognize that the documentation points out that if you use the cluster name tag, it will randomly assign security groups

Hi @empath-nirvana Can you point me to the part of document you mentioned? I couldn't find one.
@ellistarn I believe we are experiencing the same problem. We have nginx-ingress controller and I believe the AWS LB Controller created a SG for that the associated ELB with the same tag of the default SG that was created of EKS (with pattern: kubernetes.io/cluster/CLUSTER_NAME: owned). And Karpenter just picks this SG for all new created nodes and thus all workloads deployed on the node failed to work since they don't have correct network access.
What can be a workaround in this case (and if we don't want to manually modify AWS resources)?

Coming in 0.5.4


Demo page reports malicious content

The demo page was blocked due to suspected malicious content. It may be hacked.

Thanks for the report! Nothing was hacked, my ssl cert auto update had failed. Fixed now!


Cannot create "hello hello hello" wav file.

I tried colab example as it is and I changed output text "hello world" to "hello hello hello".
But the generated wav file is not "hello hello hello" but "hello world".
How can I generate other sentence likes "hello", "world hello", "world world world"?

https://github.com/enhuiz/vall-e#get-started

Please note that this example overfits a single utterance under the data/test and is not usable.


Update dependency on node-pre-gyp to @mapbox/node-pre-gyp

@mapbox/node-pre-gyp replaces the deprecated node-pre-gyp. The deprecated version is currently flagged because of high severity vulnerabilities, causing npm audit to fail.
@adnanrahic

@adnanrahic For some context, the Promster NPM module for exporting Prometheus metrics recently moved to your fork of node-gcstats because of the dependency updates you made to eliminate vulnerabilities reported by npm audit.
Would you mind clarifying whether you're planning to maintain this fork? If so, are you able to update the node-pre-gyp dependency? Are you open to PRs?

@Ghazgkull @adnanrahic
Are these vulnerability fixes part of NPM yet? We would be interested in using it

@adnanrahic Please review the PR I submitted here: https://github.com/adnanrahic/node-gcstats/pull/4

@Ghazgkull
Are you planning to publish your changes in NPM as a new library in case is not taken care here? We find it useful for us too instead of writing a new one for same purpose.

Hey everyone!
Sorry for not responding sooner. :disappointed:
I was maintaining this fork while working at https://github.com/sematext.
I've moved to work somewhere else recently, so I'm not sure if I have publish permissions to the npm package https://www.npmjs.com/package/@sematext/gc-stats.
Let me merge #4 first so there is an option to use this fork by installing it directly from GitHub.
Thanks a lot for taking the time to create the PR @Ghazgkull! Really great work!

Seems I still have publish access! :rocket: :confetti_ball:
Latest version is now<EMAIL_ADDRESS>Thanks for looking into this and adding a fix. :bow:


RFC: Use Symbols instead of SmallStrings?

Symbol is builtin and String is heap allocated, I guess why you implemented this SmallString for this. I'm wondering if it is better to make use of existing infrastructure.

oh seems dup of #2 sorry.


SocketIOClient serialization

onData in SocketIOClient client, how to serialize and then into redis , we need to use the time and then taken out deserialization

You don't need to serialize SocketIOClient object. Store its id to Redis:
UUID id = SocketIOClient.getSessionId();

and then get it again by id:
SocketIOClient client = SocketIOServer.getClient(id);


The True History of Yakub

About the PR
adds The True History of Yakub to the jukebox
Why / Balance
piras told me to in a ancient vision i had in a dream... im psychic... trust....
Technical details

Media
https://www.youtube.com/watch?v=L53UWqXE8XM
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
:cl:
-add: Adds The True History Of Yakub to the jukebox (not main menu... dont worry..)

RAAAAAA PIRAS UPDATE YOUR PR


killboard entries show wrong date (month-1)

the fetched kills from zkillboard are shown correctly, but with date one month in the past. So for instance I am currently looking at kills from 17h ago (which is correct when you click on a kill), but in the list they are all put into june instead of july.

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: Please reopen/comment this, if you have problems/questions about it.

Auto-generated response


Update AmazonInfo.java

Refactory regarding AWS ADDRESS (PROTOCOL + IP)

Check with Netflix team

Check with Netflix team


support catpture for ovs+dpdk

When use ovs+dpdk. We can't capture in vhu port
We can add kni interface and do mirror to do capture.

does it not work with ovs port capture ? I mean, did you try to start a capture on an OVS port. It will create a tap interface within the bridge and will set mirroring automatically. So that you should be able to see the traffic on the tap ?

We have finished this work.

Addressed by https://github.com/skydive-project/skydive/pull/716


Update to the latest 2023.2

I confirm the version suggested works locally (after ./gradlew build ) and installing plugin "from disk" to IntelliJ 2023.2 (Build #IU-232.8660.185, built on July 26, 2023)

Hi @maosmurf!
Thank you very much for the PR.

I managed to reproduce, however no clue as how to fix, yet.
Next approach would be to learn from other plugins, most of which moved to gradle8. Will invest time next week.

Updated to gradle 8 ( ./gradlew wrapper --gradle-version 8.3 ) , now the plugin builds and runs tests also on my Windows machine.

@maosmurf, now it works, thank you!


Re-establish hardware check reporting for autofill capabilities

Task/Issue URL: https://app.asana.com/0/488551667048375/1206638124888251/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

develop

#4190   👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


CPS-20-deprecated

Added @deprecated decorator.

Codecov Report

Merging #40 into master will decrease coverage by 0.13%.
The diff coverage is 62.5%.

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
- Coverage   93.23%   93.1%   -0.14%
=========================================
  Files          30      30
  Lines        1256    1261       +5
=========================================
+ Hits         1171    1174       +3
- Misses         85      87       +2

Impacted Files
Coverage Δ

connect/resources/base.py
92.22% <ø> (ø)
:arrow_up:

connect/models/exception.py
0% <0%> (ø)
:arrow_up:

connect/resources/fulfillment_automation.py
48.97% <0%> (ø)
:arrow_up:

connect/resources/tier_config_automation.py
97.29% <100%> (ø)
:arrow_up:

connect/exceptions.py
98.18% <100%> (+0.06%)
:arrow_up:

connect/logger/logger.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a87d3a...31dbee9. Read the comment docs.


Add support for .mjs

At the moment, the plugin treats files with the .mjs form as regular files. Files with the .mjs format are JavaScript files

.mjs is in the javascript.yaml file, but commented out along with a couple other unused extensions. Should I also add any of those extensions?

Only need to add .mjs and also .cjs

Got it, should be good now!

@Almighty-Alpaca are there any more I should add?


[Design] Improved workflow for making new tasks

Implemented an improved workflow for creating new tasks. In this workflow the user

Selects a task type (e.g. multiple choice, short answer/paragraph)
Selects an image (whole slide image) that the task is about
Inputs task information and question
Annotates the slide

The user can go back and forth between these two steps.
There are still some highly needed improvements, but pushing this now as we want to get feedback. Some suggested tasks I will put on the To do-list:

Hide radio buttons and style/format/highlight slide cards instead to see which image is selected
If a task is generated from a slide, this slide should already be selected when making a task (the user should still double check and can change their selection if needed)
Figure out whether to have a "previous" button to go back to task type/slide selection when the user has come this far. If the user goes back, the task information and annotations will be lost.

There was an error with the ID's of the forms that made the final form not submit. Seems to be working now

@UteSpiske Are you good with merging these changes? Is user friendliness "good enough" for our workshop/testing or should we fix some of of the aesthetics first?

Nice that is now all working.
I would remove the 'create new task' buttons in the images because they are not working at the moment and can be added in a further step.

Good point! I removed the buttons👍
I also added something that have fallen out - that tasks weren't automatically added to the course they were created from. Should be fixed with dbe4aaf

Etienne noted that filtering options/buttons are clickable in the image selection part of the workflow. But these aren't implemented and break the functionality.
Will remove this from the display for now, and put on the to do-list to add it.

I removed the filtering/search and added a TODO. Do you think it's alright for merging @etiennegaucher?


Could someone be amazing, adding BTC-e support!?

Kudo's for the one!

I could but have suspended account:(

Hi man,
Register new one, on BTC-e you only need name and e-mail, easy peasy registration
oh and besides this might help:  https://github.com/voltsonic/btce-public-v3 https://github.com/voltsonic/btce-public-v3

On 22 Mar 2017, at 13:18, nedievas<EMAIL_ADDRESS>wrote:
I could but have suspended account:(
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/carlos8f/zenbot/issues/127#issuecomment-288381348, or mute the thread https://github.com/notifications/unsubscribe-auth/ASyxqufAjRUe7IKnk4hYFgleY9-mShkfks5roRF5gaJpZM4Mk45O.

I'd like to add BTC-e for Zenbot 4. Maybe for 4.1.


feat: datum by hash

Adds a new reducer and leverages projections

@rvcas Do you think this can be merged relatively soon?

@Vardominator needs some work still. Will finish this week

@rvcas Are you still waiting for approval from @scarmuega ?

this is old and I don't think it's that useful anymore?


[stable/mongodb] Fix Health Check Probes

Signed-off-by: Abhishek Jaisingh<EMAIL_ADDRESS>What this PR does / why we need it:
makes the health-checks (liveness & readiness probes) consistent accross the helm chart
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x ] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @prydonius

@juan131 pushed new commit addressing the review comments :gear:

/ok-to-test
/lgtm


Code duplication on hot reload

Version
2.3.0-25689543.1a154e8
edge
Reproduction link
https://cmty.app
Steps to reproduce
During editing of page sometime hot reload fails and produce double imports in generated code
https://gist.github.com/aldarund/033b51b211d4d764fda12e36ed8ad3d0
https://i.imgur.com/Pzv43Se.png
Seems like a race condition somehwere
What is expected ?
no code dup :)
What is actually happening?
code dup and fail :)

This bug report is available on Nuxt community (#c8088)

@aldarund your png link doesn't work

@AndrewBogdanovTSS it works.. maybe your isp blocking it.

yeah, damn blockers))

For accessibility ☺


Document threading properties of Ifce

Starter questions:

Can multiple goroutines concurrently Read from the same Ifce?
Can multiple goroutines concurrently Write to the same Ifce?
Are there performance bottlenecks that limit Read and Write calls by multiple threads?

Each interface corresponds to a file descriptor, so it probably doesn’t make sense to have multiple threads working on the same interface. If The goal is to have parallel streams to increase throughout, Linux has multiqueue support for TUN/TAP: https://www.kernel.org/doc/Documentation/networking/tuntap.txt

Closing. Feel free to reopen if you have further questions.


Import types instead of import and prepare update to TS5.0

Closes #960

Prepare upgrade to TypeScript 5.0.x
Adds new linter rule to use import type instead of import for imports that are only used for types and not values
Fixed linter issues for the new rule
Adapted langium-cli and generators to reflect those changes
Some styling here and there

Please remove the test project from the package-lock. Also check that clean-up step is inside a finally block

The clean-up step is already in a finally block, not sure why this was added to the package-lock...

Please remove the test project from the package-lock. Also check that clean-up step is inside a finally block

The clean-up step is already in a finally block, not sure why this was added to the package-lock...

Do you have this folder locally? Maybe it is there since you was adding new CLI tests?

@gfontorbe
It is really difficult to track all the changes.
Just hope we have enough tests and enough time to find potential bugs :)
Would be nice if someone else could also look through.


[core] support check partition expire when batch mode or bounded stream

In my company, some paimon user have reported the following issue :
Everyday the batch jobs have a running time lower than config partition.expiration-check-interval, so many partitions that should have expired have not been expired.
Now add a conf, support check partition expire used in case of batch mode or bounded stream.
Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

You can trigger expiration by setting parameter partition.expiration-check-interval = 0

This option (default false) also looks good to me.


better test infrastructure on the multi lnd part

currently we don't dynamically test having one lnd being offline and see how the app reacts. have done some manual testing but we need to automate it.
not straightforward because we need to be able to set an node offline on the fly and restart it, but the test infrastructure is already using 2 different backend, kubernetes and docker-compose.

As the target of the test is the backend code I think having this test run only in the local setup (ie docker-compose) should be enough to ensure the code is working as expected.
I wrote a test framework delmo that addresses exactly this use-case. I used it in the the past to test dynamic re-configuration of database clusters when facing node failure.
The code is unmaintained but probably wouldn't be much work to bring it up-to-date. Or perhaps it is still working as-is.


Match HTTP_HOST in pair with relative URL

For compatibility matching with relative URL
only left as it was before.

I think we should adapt the README.md to mention that we support this.

Changes applied according to comments.
Me personal opinion is that matching system currently quite amateur and should not be over-engineered in the beginning.

Can I anyhow help? 💤

@uzzer Can you rebase your commits into a single one?

@remiprev done

Alright, thanks!