fluxctl list helmrelease problem

Describe the bug
If you have multiple helm releases in a given namespace, the first helm release is displayed multiple times. Maybe this is only a display bug.
logging:helmrelease/kibana is listed 4 times:
phil@cubi001:~$ fluxctl list-workloads -n logging
WORKLOAD                               CONTAINER              IMAGE                                                    RELEASE  POLICY
logging:cronjob/elasticsearch-curator  elasticsearch-curator  bobrik/curator:5.7.6                                     ready
logging:daemonset/fluent-bit           fluent-bit             fluent/fluent-bit:1.1.0                                  ready
logging:deployment/elasticsearch       elasticsearch          docker.elastic.co/elasticsearch/elasticsearch-oss:7.1.0  ready
logging:deployment/kibana              kibana                 docker.elastic.co/kibana/kibana-oss:7.1.0                ready
logging:helmrelease/kibana                                                                                automated
logging:helmrelease/kibana                                                                                automated
logging:helmrelease/kibana                                                                                automated
logging:helmrelease/kibana             chart-image            bobrik/curator:5.7.6                                              automated
phil@cubi001:~$ kubectl get pods -n logging
NAME                                     READY   STATUS      RESTARTS   AGE
elasticsearch-85574b9bf5-pblx4           1/1     Running     0          11d
elasticsearch-curator-1559610000-gs8z7   0/1     Completed   0          2d20h
elasticsearch-curator-1559696400-tkgxb   0/1     Completed   0          44h
elasticsearch-curator-1559782800-m7wrb   0/1     Completed   0          20h
fluent-bit-g2x46                         1/1     Running     0          7d23h
kibana-6776c48b5d-mtv8m                  1/1     Running     1          57m

hass:helmrelease/mosquitto is listed 6 times:
phil@cubi001:~$ fluxctl list-workloads -n hass
WORKLOAD                               CONTAINER                      IMAGE                                             RELEASE  POLICY
hass:deployment/appdaemon              git-sync                       k8s.gcr.io/git-sync:v3.1.1                        ready
                                       appdaemon                      runningman84/alpine-appdaemon:latest
                                       git-sync-init                  k8s.gcr.io/git-sync:v3.1.1
hass:deployment/chronograf-chronograf  chronograf                     docker.io/chronograf:1.7.7-alpine                 ready
hass:deployment/deepstack              deepstack                      deepquestai/deepstack:cpu-3.4                     error
hass:deployment/home-assistant         home-assistant                 runningman84/alpine-homeassistant:latest          ready
                                       configurator                   causticlab/hass-configurator-docker:x86_64-0.3.1
                                       git-sync                       causticlab/hass-configurator-docker:x86_64-0.3.1
hass:deployment/influxdb               influxdb                       influxdb:1.7.3-alpine                             ready
hass:deployment/mosquitto              mosquitto                      eclipse-mosquitto:1.5.5                           ready
                                       mosquitto-prometheus-exporter  sapcc/mosquitto-exporter:0.5.0
hass:helmrelease/mosquitto
hass:helmrelease/mosquitto
hass:helmrelease/mosquitto
hass:helmrelease/mosquitto             chart-image                    runningman84/alpine-homeassistant:latest
hass:helmrelease/mosquitto
hass:helmrelease/mosquitto
phil@cubi001:~$ kubectl get pods -n hass
NAME                                     READY   STATUS    RESTARTS   AGE
appdaemon-b7bd87f47-hbs58                2/2     Running   0          69m
chronograf-chronograf-559c7c98d9-h867m   1/1     Running   1          27d
deepstack-578f7bc989-nflg9               0/1     Pending   0          54m
home-assistant-bf486fc95-cdwzd           2/2     Running   2          26d
influxdb-5cd67cbc96-cbv4x                1/1     Running   1          27d
mosquitto-5dbdf56cdc-pzlw5               2/2     Running   2          31d

Expected behavior
Each release should only be displayed once.
Additional context
Add any other context about the problem here, e.g

Flux version: 1.12.3
Helm Operator version: 0.8.0
Kubernetes version: 1.14
Git provider: github
Container registry provider: dockerhub

this seems to be fixed in the latest version


[BEAM-7443] Create a BoundedSource -> SDF wrapper in Python SDK

Create a wrapper tp wrapping python BoundedSource into SDF in python SDK.
Major components of wrapper included:

SDFBoundedSourceWrapper
SDFBoundedSourceRestrictionTracker
SDFBoundedSourceDoFn

In dataflow_runner and fn_api_runner, if pipeline running with "use_sdf_bounded_source" option, the runner will override Read(BoundedSource) with SDFBoundedSourceWrapper(BoundedSource). No support for other runners for now.
R: @lukecwik @robertwb
CC: @laraschmidt

I'm just commenting on this to get mail updates:)

Please update the thread safety sections with a TODO pointing at BEAM-7473 to remove the thread safety requirements.

All comments have been addressed. Would you like to do another round of review? @lukecwik

All checks have passed :D @lukecwik


Use collapse plugin for the "Show components requiring JavaScript" dropdown

The "Show components requiring JavaScript" dropdown menu currently uses <details> and <summary>. It can easily be converted to the collapse plugin to be consistent with the sidebar.

Thanks for the suggestion, but we rather stick with the details/summary option since it's more semantic for this specific case.

Thanks for the suggestion, but we rather stick with the details/summary option since it's more semantic for this specific case.

It looks mostly the same however and works with older browsers, unlike details/summary.


EPW files without empty line at end of file fail to run

Describe the bug
Weather files from the PVGIS V5 website are in EPW format, but do not have an empty line at the end of the file, and cause SAM simulations to fail.
To Reproduce
Download EPW files from:
http://re.jrc.ec.europa.eu/pvg_tools/en/tools.html#TMY and download an EPW file.
For Details
https://sam.nrel.gov/node/80512

Tested and verified working with 2018.11.11.r1 - fixed in patch branch commit a33dc6 by dguittet


Program still hanging during measurements

Unsure where this is coming from, but upon testing it seems the original append function was fine. I think it's because I was updating the plot in two places?
Need to change it to check which plot is active then refresh that plot only!

See here about getting data from threads and making threads persistent

More on threads

Closed with refactor


Remove data_ from Header

Attempting to address https://github.com/LeonineKing1199/minivec/issues/2

I mentioned it before, but you can make the alignment calculations much simpler by leaning on Rust a little. Is there a reason you chose not to use this approach?
pub struct MiniVec<T> {
    /// Safety: Either null or a valid pointer to the Inner owned by this MiniVec
    ptr: *mut Inner<T>,
}

/// Guarantees that `cap` `T`s have been allocated after this structure.
#[repr(C)]
struct Inner<T> {
    cap: usize,
    // Length of initialized elements in `data`
    len: usize,
    #[allow(unused)]
    data: [T; 0],
}

impl<T> Inner<T> {
    fn as_mut_slice(&mut self) -> &mut [T] {
        let ptr = unsafe {
            // Safety: The data region comes after a single Self allocation.
            // If it is empty, this will only be one byte past the allocation
            // This won't wrap, because self < usize::MAX - size_of::<Self>()
            (self as *mut Inner<T>).add(1) as *mut T
        };
        unsafe {
            // Safety: The data region contains at least self.len elements
            slice::from_raw_parts_mut(ptr, self.len)
        }
    }
}

impl<T> MiniVec<T> {
    /// Checks if the MiniVec's allocation has been created
    fn inner_mut(&mut self) -> Option<&mut Inner<T>> {
        if self.ptr.is_null() {
            None
        } else {
            Some(unsafe {
                /// Safety: ptr is valid so long as it isn't null
                &mut *self.ptr
            })
        }
    }
    /// Extracts a mutable slice of the entire vector.
    fn as_mut_slice(&mut self) -> &mut [T] {
        self.inner_mut().map_or(&mut [], |inner| inner.as_mut_slice())
    }
}

Using this layout removes the need for any of the alignment calculations, letting Rust handle it all instead and making the code way simpler.

Is it safe to cast from *mut Inner<T> to *mut T? In C++, this would most assuredly be UB. Maybe even in C too.
Pointer arithmetic in those langs typically implies some kind of an array object. This seems like a strong jump in types.
The reason *mut u8 was chosen is because byte types are allowed to alias any and all objects.

Raw pointers don't actually have any validity requirements. They can be any usize, you only have to be careful about using them.
The pointer calculation is functionally identical to this:
(self as *mut Inner<T> as *mut u8)
    .add(size_of::<Inner<T>>()) as *mut T

That's good to know.
Being completely honest, I don't really know Rust all that well. MiniVec started out primarily as a learning project and I'm still picking up Rust all the time.
I learned a lot by reading your Rust code but because MiniVec is a low-level component doing low-level things, I want to keep most things "simple". Here simple = the same way C is simple.
/// Guarantees that `cap` `T`s have been allocated after this structure.
#[repr(C)]

I'm not stoked that we need this because it means we're relying on implicit object layout which we can't control. In the ideal case, we'd have exactly control over the layout of everything we touch with regards to the allocation.
#[allow(unused)]
data: [T; 0],

I'm not happy we need the #[allow(unused)] right here. I get why it's there but the way the code works now, it isn't required.
I'm not too sold on the monadic approach via Optional for this either. Imo, the code's already pretty clear but I'd be open to seeing what refactoring more of the current existing code to use Optional would look like.
Fundamentally, a *mut u8 pointer is the most simple construct. We really only have two problems to solve.

making sure the alignment of the allocation works for both T and Header/Inner
finding the location where we write the array to

There's really nothing more to solve in this regard and I'd prefer to keep things explicit instead of implicit because we can easily verify everything. It's also a problem with small-scope so it's an acceptable trade-off of maintenance burden and benefit.

I only proposed the changes because I find them "simpler", which is naturally completely subjective. I suspect people who are used to Rust would also find it easier to understand since they'll already know about the guarantees Rust makes.
As for your concerns, I don't think we actually need that repr(C). I just typically use it when writing pointer code since it's more straightforward than repr(Rust). Allowing lints like unused is just a natural part of unsafe code imo (clippy::cast_ptr_alignment is much harder to verify).
I might make a PR to demonstrate how Option can help. Simply put, it lets you make that guarantee  `cap` `T`s have been allocated after this structure. (and that len of them are initialised) in the type system, and encapsulate the unsafety.

That is to say, I think of *mut u8 as the most complex type. It tells me nothing about the state of the data, and I need to keep track of what it means at a point in time rather than its fundamental properties.

I actually don't disagree.
But also consider this, Inner<T> still doesn't imply that after it there's a [T]. It contains a [T; 0] sure but that only guarantees the alignment of the type itself.
The real thing that's confusing is that we're storing two data structures in this buffer and we use offsets to grab pointers to those objects.
But again, MiniVec is very small in terms of what it's doing here. There's the header and the array and that's it! If we were reimplementing something like a heap, I'd understand more. But for this, there's bigger fish to fry!
For example, if you really wanna be a hero, we need an implementation of DrainFilter. The From impl is also kind of sloppy and needs to be cleaned up as well. We also could add support of ZSTs.
In the ideal case, we'd have all the tests commented in in tests/vec.rs. That's a copy-paste of the actual std::vec::Vec test file ripped from GitHub (which also made licensing kind of funky for that file).
I'd also be interested in seeing if we benefit from making the buf pointer NonNull as well.

I'm going to go ahead and the merge the PR because it accomplishes what it set out to do and I don't wanna be blocked on it.
If we wanna make any other changes, we should just open up a new issue/PR combo and then we can take it from there. I feel like there's already been a good bit of useful discussion here!


Add info about users explicitly added

This article should also mention that if a user is explicitly added here but none of the default permissions are changed, the user will not appear on the list the next time the permissions page is loaded.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f5ce059-ec92-5413-0910-4e28033db034
Version Independent ID: 540610d3-6073-664d-97f8-e7d8e0a21a20
Content: Set Git or TFVC repository permissions - Azure DevOps
Content Source: docs/organizations/security/set-git-tfvc-repository-permissions.md
Product: devops
Technology: devops-security
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@anmason  - Thank you for the correction. I have updated the article to reflect the way permissions operate.


[WIP] Avoid skipping model validations

[x] Use update (or update_attributes, they're the same) rather than update_attribute
[ ] Do something about update_all?
[ ] Do something about touch? (only used in tests, may not be important)

(Marri says some of these (most of these?) are intentional; needs checking over more thoroughly.)


Check if porky restart can be made more elegant

After setting or resetting WLAN info, the device restarts so that it can try to connect to the default (there can be a default in ROM).
This is not a crash - but it might appear as one. There is debug output explaining it will restart but not visible.
=> Maybe we could add something to the UI to let users know it will restart?
=> Maybe there is some USB status/command that can be used to make the restart not appear as a crash?

Windows: I'm not sure what you would call it, but if the complete main Window for an application disappears without notice and does not re-appear with 10 seconds or so I'd call that a Crash? Windows Desktop Alt/Tab does not find any instance of the running app.
Where would I find the related Debug output?


[Bug] Support modrinth version urls without having to hand edit them

Any chance you could add support for modrinth using the version urls from modrinth without having to hand edit them?
Currently, I get an error when pasting in a modrinth version url:
> packwiz mr add https://modrinth.com/mod/fabric-api/version/0.69.0+1.19.2
Failed installing mod: failed to fetch version 0.69.0+1.19.2: invalid character 'I' looking for beginning of value

However if I hand edit the url to include the version id it works:
> packwiz mr add https://modrinth.com/mod/fabric-api/version/25Hm7c3j
Installing fabric-api-0.69.0+1.19.2.jar from version 0.69.0+1.19.2

Duplicate of https://github.com/packwiz/packwiz/issues/103.

Duplicate of https://github.com/packwiz/packwiz/issues/103


Add babel-core in package.json in angular example

I tried with this pr https://github.com/storybooks/storybook/pull/3319
but I did something wrong and git not accepeted.

Let's bring the conversation over to the PR


No update on changing node_modules

Using a mono-repo and editing some sub-deps it seems not to trigger pundle updates until i restart the server itself.
I looked into preset-default and --help for some config options and didn't see anything clear for this specific case.

Pundle by default only watches the root directory. This will be changed to eventually all the required files regardless of where they are but It's gonna take time

While watcher support for individual files is some time away, I've set followSymlinks to true in chokidar (nsfw watcher doesn't support it). So when https://github.com/steelbrain/pundle/commit/f9b5489bf19c26b585097da05308c5b2f866811b is released, you should be able to do --watch.adapter chokidar to fix watcher support for linked modules outside root directory

Update! The change was released. You can append -watch.adapter chokidar to your dev command to fix watching linked directories

Guessing this is no longer issue because chokidar was removed?

nsfw was removed and chokidar was made default, so yes, this shouldn't be an issue in latest release


Linting stdin rather than reading the file again

While filing and trying to fix #33, I noticed that linter-js-standard calls standard with the path to the source file, while it already has that file's contents in a variable. This patch just passes those contents via stdin, just like linter-jshint does. (That being said, it currently doesn't fix the original bug at all.)
After this refactoring, I saw no need for caching args anymore, so I removed the related code. I have to say I don't really understand what the cache is supposed to do though. What's it caching exactly? Is it just trying to avoid array allocations? If so, I can't imagine that outweighing the overhead of creating a new process every time you lint.

Thank you for the PR. I originally wanted to pass the fileContent to stdin but then I gave up on that idea and I don't remember why  :confused:
And thanks for the typo fix bindedLinter to boundLinter :smile:.

I'm cachingit because I don't want to recursively check for package.json, parse it and get the args on each lint, it would take more time to process each lint,

I'm not sure I understand what you're saying about the args, but if it's necessary to keep that feature around, by all means. My main goal was to get stdin into the mix.

When the honorStyleSettings is ticked, it will try to search the nearest package.json to get the project style settings (custom parser, global vars,..).
Something like this:
...
"standard": {
   "parser": "babel-eslint"
}
...

Now this parser needs to be translated to the following cli arg --parser babel-eslint. That is why I'm caching the args when you open a TextEditor (file), so while you are editing with your file it doesn't need to do all that on each file save (assuming you have AtomLinter configured to lint on file save)

That makes a lot of sense. :-)


Remove language specific validation errors

Language specific, punctuation and grammar errors should not be included in validation.

Duplicate of #69

I plan to do this without actually changing how the uw-content-validation package works. There is a cvFilter() function that is used to suppress certain rows. I will add some logic to this function to exclude Spanish punctuation notices.
Probably not a long term fix, since non-Latin scripts may cause even more issues. Which may necessitate an overhaul to how CV works.
@birchamp

I like this as a mid term fix


fixed issue 15599

This is a page I won't mind seeing removed honestly. I mean, why do we need this page? Who is still on the fence about D2 that doesn't know all of the improvements? You can't even download D1 on dlang.org anymore.
IMO the proper "fix" for this issue is to delete the page and any references to it.

IDC. I've just seen the issue when checking what was up since latest hours.

I merged #1211, closing this one.


LazyOperators and UniformScaling

It would be nice if we could use a UniformScaling in our (bi)linear forms. Below is a minimum non-working example.
module mwe
using Bcube
using LinearAlgebra

mesh = one_cell_mesh(:line)
U = TrialFESpace(FunctionSpace(:Lagrange, 1), mesh; size = 2)
V = TestFESpace(U)

p = PhysicalFunction(x -> 1.0) # scalar function

dΩ = Measure(CellDomain(mesh), 1)

l(v) = ∫((p * I) ⊡ ∇(v))dΩ

assemble_linear(l, V)

end

Done in #24


Feature request: pglite dialect

According to the pglite docs:

PGlite is a WASM Postgres build packaged into a TypeScript/JavaScript client library, that enables you to run Postgres in the browser, Node.js and Bun, with no need to install any other dependencies. It's under 3mb Gzipped.

There is discussion on a kysely-pglite dialect here and here.

This should not be part of the core but a separate package instead. Only the most used dialects are maintained here.


update csv with operands sha

ran make get-all-image-sha and added to csv

linter threw this error test/e2e/auditlogging_test.go:21:2: ST1019: package "github.com/operator-framework/operator-sdk/pkg/test" is being imported more than once (stylecheck) so fix added to this pr as well

a new csv will need to be pushed to quay once this is merged

@lauriet-ibm plz review this pr. squads have been told to make this change if our operands are stable

thanks, ill push a new csv to quay

➜  ibm-auditlogging-operator git:(master) ✗ ./common/scripts/push-csv.sh
Enter username quay.io: hbradfield
Enter password quay.io:
Enter Version/Release of operator: 3.6.0
Push package ibm-auditlogging-operator-app into namespace opencloudio
{"status":"ok"}

https://quay.io/application/opencloudio/ibm-auditlogging-operator-app?tab=releases


Implement Automated Task Scheduler for Repetitive Tasks

Script Title -Automated Task Scheduler for Repetitive Tasks
Brief -Objective: To implement an automated task scheduler that can perform repetitive tasks based on predefined intervals or specific triggers. This feature is designed to help users streamline their workflows by automating routine processes and actions, enhancing efficiency.
Expected Outcome:
A script that allows users to define specific tasks they want automated.
Flexibility in scheduling tasks (e.g., daily, weekly, hourly, or custom intervals).
The ability to run background processes that don’t require manual input once set.
Integration of email alerts or other forms of notifications when tasks are executed.
Potential Use Cases:
Automating data backups at regular intervals.
Running periodic system cleanups.
Sending automated reports or reminders.
Handling routine API calls or data sync operations.
Additional Requirements:
The task scheduler should handle errors effectively and have mechanisms to retry failed tasks.
It should provide an intuitive setup interface or configuration file for specifying tasks.
Logs should be maintained for each task execution for review or troubleshooting purposes.
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md (using this template) in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

somebody please assign me this


Additional option codes for a UK Model 3

Just received my final invoice for my UK Model 3 order and spotted a few option codes not present in the API docs.

Thanks!


Optimization issue with corrupted state

We noticed that Linux doesn't boot properly on older QEMU versions (see https://github.com/CharlyCst/miralis/pull/103), most likely because the CPU doesn't have the same features available as more recent QEMU versions.
While we work toward supporting the VisionFive2 board we might run into the same issues on the hardware, therefore this seems worth investigating.

How to reproduce
QEMU can take a -cpu argument to specify which CPU model it should use. I managed to reproduce the same failure as seen on the CI on a more recent QEMU version by passing -cpu sifive-u54 as argument.

In the same setup of issue https://github.com/CharlyCst/miralis/issues/105, after implementing mip CSR emulation, we still got a bug. Linux asks opensbi to set a timer, but the overhead of miralis results in the new value for the next timer event to be already in the past.
Optimization of the code could help to avoid this, (by setting opt-level = 3 in [profile.dev] section of Cargo.toml) but state is then corrupted:
[Info  | miralis] Hello, world!
[Info  | miralis] Platform name: QEMU virt
[Info  | miralis] Hart ID: 0
[Info  | miralis] misa:    0x80000000001411ad
[Info  | miralis] vmisa:   0x8000000000141101
[Info  | miralis] mstatus: 0xa00000000
[Info  | miralis] DTS address: 0x87e00000
[Info  | miralis] Preparing jump into firmware
[Error | miralis] Reached maximum number of exits:<PHONE_NUMBER>
error: Recipe `run` failed on line 47 with exit code 1

After disasembling run_vcpu, I spotted that the manually saved registers (s1, s0, tp and gp) were overwriting some of the ones automatically saved by the compiler (s10, s9, s8 and s7):
    800063a4:   715d                    add     sp,sp,-80
    800063a6:   e4ca                    sd      s2,72(sp)
    800063a8:   e0ce                    sd      s3,64(sp)
    800063aa:   fc52                    sd      s4,56(sp)
    800063ac:   f856                    sd      s5,48(sp)
    800063ae:   f45a                    sd      s6,40(sp)
    800063b0:   f05e                    sd      s7,32(sp)
    800063b2:   ec62                    sd      s8,24(sp)
    800063b4:   e866                    sd      s9,16(sp)
    800063b6:   e46a                    sd      s10,8(sp)
    800063b8:   e06e                    sd      s11,0(sp)
    800063ba:   8faa                    mv      t6,a0
    800063bc:   e40e                    sd      gp,8(sp)
    800063be:   e812                    sd      tp,16(sp)
    800063c0:   ec22                    sd      s0,24(sp)
    800063c2:   f026                    sd      s1,32(sp)
    800063c4:   c7df9f6f                jal     t5,80000040 <_run_vcpu>

A correction of sp allows linux to boot.


Template cover: device class not accepted

Home Assistant release with the issue:  0.92.2

Last working Home Assistant release (if known): unknown
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io in Docker on Ubuntu Server

Component/platform:  Template Cover

Description of problem:
The documentation states I should be able to add a 'device_class' to my template cover. But when validating the configuration, I get this error:
Invalid config for [cover.template]: [device_class] is an invalid option for [cover.template]. Check: cover.template->covers->patiocover->device_class. (See ?, line ?). Please check the docs at https://home-assistant.io/components/cover.template/
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
  - platform: template
    covers:
      patiocover:
        friendly_name: "Terrasscherm"
        position_template: "{{ state_attr('cover.zonnescherm_level', 'current_position') }}"
        device_class: awning
        open_cover:
          - service: cover.close_cover
            entity_id: cover.zonnescherm_level
          - delay:
              milliseconds: 500
          - service: cover.close_cover
            entity_id: cover.zonnescherm_level
          - delay:
              milliseconds: 500
          - service: cover.close_cover
            entity_id: cover.zonnescherm_level
        close_cover:
          - service: cover.open_cover
            entity_id: cover.zonnescherm_level
          - delay:
              milliseconds: 500
          - service: cover.open_cover
            entity_id: cover.zonnescherm_level
          - delay:
              milliseconds: 500
          - service: cover.open_cover
            entity_id: cover.zonnescherm_level
        set_cover_position:
          - service: cover.set_cover_position
            data_template:
              entity_id: cover.zonnescherm_level
              position: "{{ position }}"
          - delay:
              milliseconds: 500
          - service: cover.set_cover_position
            data_template:
              entity_id: cover.zonnescherm_level
              position: "{{ position }}"

Traceback (if applicable):
n/a

Additional information:
According to @fabaff the device_class is still present in the code. I think, there's either a bug that causes it not to validate or the documentation is off and device_class is only possible through customize.yaml.

Support was added in 0.93. you are running older. Please update and try again. Reopen if problem persists.


New standard

Companion change to https://github.com/epics-containers/p46-deployment/pull/2 , see rationale on the other change.
Additionally updates blueapi to the latest version

CI fix required because we should skip checks where the helm templates are from internal helm registries - and p46-nexus has a new name.


issue- navigator.mediadevices not present in your browser

Do you want to request a feature or report a bug?
Yes  Report error

What is the current behavior?
I am browsing the webAr page error on WeChat : issue- navigator.mediadevices not present in your browser
If the current behavior is a bug, please provide the steps to reproduce.
open webAr view  error :issue- navigator.mediadevices not present in your browser

What is the expected behavior?
Expect to open the camera
If this is a feature request, what is motivation or use case for changing the behavior?
Develop webAR
Please mention other relevant information such as the browser version, Operating System and Device Name
iPhone : 11.4.1 version
Browser:  a Apple iPhone running IOS 11.4.1
WeChat ： 6.7.2  version

Hi
not related to AR.js. Please see https://stackoverflow.com/questions/49607086/unable-to-access-camera-feed-in-wechat-browser

@chenyunbbs  Hi, I meet same error ,do you solve this problem? Please tell me,thanks!

Hi, I've just added https:// followed by the URL itself, and it's worked properly.

@hanbi918 Hi, I've just added https:// followed by the URL itself, and it's worked properly.

This actually works!

Hello, I´ve already added the https:// in the url but it sends me a ERR_SSL_ERROR, I don´t know if I have to install a certificate  or something but the first time I did it it works perfectly. Please let me know what I'm missing.

Have you tried to clear your browser's cookies and cache data?

Have you tried to clear your browser's cookies and cache data?

yes I´ve already erased it, I´m using chrome in an android and it keeps me sending the ERR_SSL_ERROR with the https:// and with out the "s" the  webcam Error: issue- navigator.mediaDevices not present in your browser :/

Have you tried to clear your browser's cookies and cache data?

yes I´ve already erased it, I´m using chrome in an android and it keeps me sending the ERR_SSL_ERROR with the https:// and with out the "s" the webcam Error: issue- navigator.mediaDevices not present in your browser :/

A solution to a similar issue was posted here: https://www.gitmemory.com/issue/jeromeetienne/AR.js/463/503552278
Hope it works for you as well.


Draft language server primitives

JSON-RPC client
STDIO connection
Process manager

@aleh-null Thanks for sharing. Let's go one by one.

The graceful shutdown issue was reported in #24, it just never got prioritized. Feel free to pick it up!
2 and 3. Totally agree. I haven't had a proper understanding for how to use context until recently. I'm starting using it more in this PR. I think I'll manage to pass context to the service layer (managers and stuff) but I'm looking for your guidance on how to actually them inside.
How can we avoid this blocking? By putting a global request timeout and using for-select?

The graceful shutdown issue was reported in Graceful shutdown for the service #24, it just never got prioritized. Feel free to pick it up!

I mostly picked up 1, since I think it is a really good mental model of what should happen with all running routines when service shuts down and thus might be related to context and and propagation of context cancellation. I can implement sig handing for now.

2 and 3. Totally agree. I haven't had a proper understanding for how to use context until recently. I'm starting using it more in this PR. I think I'll manage to pass context to the service layer (managers and stuff) but I'm looking for your guidance on how to actually them inside.

I will give you some suggestions in code, also would be good for my own understanding of the service.

How can we avoid this blocking? By putting a global request timeout and using for-select?

Sounds about right I would also wrap it in go routine and return, but this might not be necessary, depends on how mux.Handle() is running the handler. Need to double check.

This PR is becoming too big. I propose we break it down into smaller parts.
Here's part 1 that updates the model #61

Part 2 #62

Part 3 #63

Part 4 #64

Closing this PR now as it's been fully split into other PRs.


Two PRs are created when using link from Git CLI

Description
This bug is a bit annoying, because it is hard to reproduce, but it happened multiple times by now. Steps:

Create a branch with commits.
Push branch to origin via git push -u origin branchname
Use the link provided in the push response to create a PR.
Create the PR from the Web UI.

Sometimes this results in two PRs with the same data (but distinct numbers) being created. I have verified that these are treated as individual PRs by individually changing their meta-data. There is only one branch that both PRs share.
Unfortunately this is hard to reproduce, but it happens to often to ignore (especially since closing the 2nd PR also wants to delete the branch).
Gitea Version
1.16.8
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
Activating debug logs on the prod server creates a log of logging output. I am happy to follow hints on how to get the right logs efficiently.
Screenshots
No response
Git Version
From the Docker image.
Operating System
Docker running on Debian Bullseye.
How are you running Gitea?
We use the Docker image gitea/gitea:1.16.8 and set up our container via Ansible:
  - name: Setup the docker container for gitea
    docker_container:
      name: gitea
      image: "gitea/gitea:1.16.8"
      pull: true
      state: started
      restart_policy: unless-stopped
      detach: yes
      ports:
      - <IP_ADDRESS>:9002:3000
      - 2222:2222
      env:
        APP_NAME="…"
        RUN_MODE="prod"
        SSH_DOMAIN="…"
        SSH_PORT="2222"
        SSH_START_SERVER="false"
        ROOT_URL="https://gitea.…"
        DISABLE_REGISTRATION="true"
        USER_UID=1000
        USER_GID=1000
      volumes:
      - "/srv/docker/gitea:/data:rw"

Database
SQLite

Thanks for the quick response!
This might especially be related to #17254 - I keep an eye on that behavior.

@jolheiser In #17111 rapid/repeated clicking is mentioned, but I have observed the same behavior with one careful single button click. It seems that the event is duplicated somewhere during processing (race condition)?


Code snippets that could be useful

This issue is to document possible code snippets that could be useful.

From a first principles perspective
From a framework perspective

(1) is to show the mechanics of what is going on underneath so that people don't think frameworks are magical.
Vanilla Python code (i.e. no framework):

How to open a PDF and extract text from it - https://github.com/DAGWorks-Inc/hamilton/blob/main/examples/LLM_Workflows/pdf_summarizer/backend/summarization.py#L36-L42

this is cool. How about (2)?

I'll add Burr snippets for (2).


The title of application GUI windows (v. 7.1.207) has no sense text, like corrupted.

more info in support case 136409

more info in case 137150


Add createAssignment function for instructor

Motivation
There is no method for an instructor to upload an assignment
Possible Steps

Use helper functions from firebase/database.py .
Create a new method in the scripts/cm_cli.py for uploading an assignment and create a command for it.

Hey i can work on this issue. can you assign it to me?

Sure, go ahead! ping me if you need any help.

Hi @ChiragAgg5k , are you facing in any difficulty setting up the environment or having any trouble implementing the feature, please do let me know! Maybe we can help!

Hey there. Sorry for being inactive. I am currently busy with University exams. If it's urgent you can pass the issue to someone else. Thanks and sorry again

Ok, no problem, please keep us updated after your exam are over....

Any updates @ChiragAgg5k ?

Unassigned due to inactivity


SECURITY.md

Fixes #XX
[Short description explaining the high-level reason for the pull request]
[If this Pull Request contains any UI changes, provide an image or GIF displaying the changes]

Developer Certificate of Origin Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

I'm going to close this PR because it's not linked to an open issue, because the content of the added file is still half template, and because the PR body and title are not very descriptive.
Please see CONTRIBUTING.md in this repo's root for contributing guidelines, if you'd like to open an issue for this change so we can discuss, please go ahead!


When Debug: Inline Values is set together with Word wrap, breakpoints are not correctly focused

Issue Type: Bug
As the title shows, having word wrap enabled together with Debug: Inline values causes the debugger to focus the editor in the incorrect place when pausing on a breakpoint.
It appears to be because it first focuses on the relevant line, and only then displays the inline values, which then wrap at the line length limit and cause the breakpoint line to move further down.
To reproduce just debug a  long file with values whose repr doesn't fit on a single line, (simple example at the end of the issue), and set a breakpoint on one of the last lines.
Screenshot:

Notice how the debugger viewlet shows that the debugger is paused on line 67, but since each line shows an inline value that takes 2 lines when wrapping, the editor is incorrectly focused on half of that (around line 33).
I don't know if the fix should be to delay focusing the breakpointed line until after the inline values have been displayed, or to ignore the word wrap setting for inline values --- wrapping them usually just makes them hard to read and I usually just toggle word wrap in these cases.
Simple example:
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
breakpoint()
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}
x = {i: x for i, x in enumerate(range(500))}

VS Code version: Code 1.67.2 (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:23:40.286Z)
OS version: Linux x64 5.15.37-1-lts
Restricted Mode: No

System Info

Item
Value

CPUs
AMD Ryzen 7 3700X 8-Core Processor (16 x 4239)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
31.36GB (0.69GB free)

Process Argv
--crash-reporter-id 66ea3ec9-05eb-4edd-8d35-34bbe6c1aba1

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma-i3

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE-i3

XDG_SESSION_TYPE
x11

Extensions (59)

Extension
Author (truncated)
Version

vscode-sqlite
ale
0.14.0

docs-view
bie
0.0.11

path-intellisense
chr
2.8.0

clippy-ai
cli
0.3.2

gitignore
cod
0.7.0

systemd-unit-file
coo
1.0.6

vscode-office
cwe
2.5.4

vscode-markdownlint
Dav
0.47.0

githistory
don
0.6.19

xml
Dot
2.5.1

copilot-nightly
Git
1.22.5959

vscode-pull-request-github
Git
0.42.0

gitkraken-authentication
git
1.0.3

gitignore-templates
has
1.0.1

beautify
Hoo
1.5.0

latex-workshop
Jam
8.26.0

vscode-edit-csv
jan
0.6.9

svg
joc
1.4.18

vscode-map-preview
jum
0.5.9

restructuredtext
lex
189.0.0

bash-ide-vscode
mad
1.13.0

rainbow-csv
mec
2.3.0

gitignore
mic
1.0.1

vscode-docker
ms-
1.22.0

csharp
ms-
1.24.4

black-formatter
ms-
2022.1.11371002

gather
ms-
2022.3.0

python
ms-
2022.6.2

vscode-pylance
ms-
2022.5.2

jupyter
ms-
2022.4.1021342353

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

remote-containers
ms-
0.234.0

remote-ssh
ms-
0.80.0

remote-ssh-edit
ms-
0.80.0

cmake-tools
ms-
1.10.5

cpptools
ms-
1.9.8

hexeditor
ms-
1.9.6

vscode-python-typehint
njq
1.4.1

platformio-ide
pla
2.4.3

show-offset
ram
0.0.4

bash-debug
rog
0.3.9

zsh-debug
rog
0.1.3

jinjahtml
sam
0.17.0

git-merger
sha
0.4.1

wav-preview
suk
2.0.2

cython
tcw
0.1.0

html-preview-vscode
tht
0.2.5

shellcheck
tim
0.19.3

simple-rst
tro
1.5.2

cmake
twx
0.0.17

lorem-ipsum
Tyr
1.3.1

vscodeintellicode
Vis
1.2.21

vscode-icons
vsc
11.11.0

vim
vsc
1.22.2

gitblame
wad
8.2.0

markdown-all-in-one
yzh
3.4.3

json
Zai
2.0.2

grammarly
znc
0.22.0

(7 theme extensions excluded)

Seems that we move the cursor to the right place, but when the wrapped decorations show up, the active line is not revealed. Seems like we would want to keep that in view.
But then in this state, I can't cursorDown at all. Can my my cursor in every other direction.

I am still experiencing this, in both JS and Python. I'm using VSCode 1.77.0, but it's been happening for months. (I do think it's a regression, though, because I've had the same inline values and wrapping settings for years, and this only started happening some time in 2022.)

This bug is slowly driving me nuts. I sometimes have word wrap enabled, and it's jarring to have to adjust my scroll often while I work.

I can verify the focus issue, but I think this is a logical problem of the debugger feature (revealing line and then updating inline values will scroll the line out of view), thus assigning this issue back to @roblourens. I created #186628 for the cursor issue.

@hediet if I understand the code correctly, it's the other way around because when the editor scrolls, we show inline values for whatever the visible range is. So if the inline value decorations will make the editor scroll away, I need to scroll the editor once, then wait for the decorations to update, then scroll it again. That's pretty awkward. Is there some way that I can anchor the scroll position when adding the decorations?

So if the inline value decorations will make the editor scroll away, I need to scroll the editor once, then wait for the decorations to update, then scroll it again.

Until it converges, yes...

I can anchor the scroll position when adding the decorations?

By default it is anchored to the top line in the view port. I don't know if we can anchor it to the cursor. How would the API look like?

I think anchoring it to the cursor makes more sense as a default, if it's in the viewport, isn't that likely where my attention is?
Otherwise, to me it seems like this needs to be part of the call to move the cursor, not the calls to show decorations. I think it makes more sense to say "reveal this line (even if decorations try to push it away)" rather than "show this decoration (and if it causes a scroll, anchor to the cursor)"

@alexdima what do you think? Currently the viewport is anchored by default to the first visible line. Should we change that to the line the cursor is in if the cursor is in the viewport (if not, fall back to the first visible line)?


[BUG] Notes missing from "My Clippings" import

Describe the bug
When I import highlights manually from the "My Clippings" file, not all of my notes are imported successfully. After looking through the original txt file, it seems like notes with a location that does exactly match the start location of a highlight are left out (but I could be wrong).
P.S. Thanks for this plugin!
Method of syncing

[ ] Amazon Kindle Reader
[X] My Clippings file (please attach file that can be used to recreate issue)

To Reproduce
Steps to reproduce the behaviour:

Click the "Sync your Kindle Highlights" button
Click sync
Click "upload my clippings file"
Select the "My Clippings" file from the file browser

Expected behaviour
I expect all notes to be imported.
Metadata

OS: Mac
Plugin version: 1.8.1
Obsidian version: 1.1.9

Hello, I have met the same problem with you and I saw your issue just now. I'd like to share my case.
I found that in some of my books, the notes will be linked to the wrong highlight in the wrong order. Some books simply just don't import my notes, only the highlights.
To ensure the kindle plugin to be blame, I uploaded my clipping.txt to the website my.clippings.io, and it succeeded in exporting all my highlights and notes.

This is really an excellent plugin, but this problem greatly reduces the experience of using it🥲 please the author to fix it as soon as possible! Thank you for your contribution to the convenience of Kindle users!

Hello, I have met the same problem with you and I saw your issue just now. I'd like to share my case.
I found that in some of my books, the notes will be linked to the wrong highlight in the wrong order. Some books simply just don't import my notes, only the highlights.
To ensure the kindle plugin to be blame, I uploaded my clipping.txt to the website my.clippings.io, and it succeeded in exporting all my highlights and notes.

This is really an excellent plugin, but this problem greatly reduces the experience of using it🥲 please the author to fix it as soon as possible! Thank you for your contribution to the convenience of Kindle users!

If necessary, I can offer my "My Clippings.txt" to help you find where the problem lies.

Sorry for being MIA @ProudBenzene. I haven't had a chance to work on the plugin for sometime.
I've just read this issue now 😳. If you can share your a subset of clippings file showing the problem it would help me a lot to make a fix for this. Thanks.

Sorry for being MIA @ProudBenzene. I haven't had a chance to work on the plugin for sometime.
I've just read this issue now 😳. If you can share your a subset of clippings file showing the problem it would help me a lot to make a fix for this. Thanks.

Thank you for your reply! I'll send my clippings.txt to the email address you left on the GitHub page later!

@ProudBenzene thank you so much for sharing with me your clippings.txt file on email.
I've managed to fix the first issue were your notes were not being parsed. The plugin had basic Chinese support, and there was a couple of bugs parsing Chinese book titles and general highlights as I never had examples to use for testing.
This should now be fixed in 1.9.1. Can I ask you to download and confirm it solved the absence of your notes?
In terms of the issue with order... I think I know what the issue is, but it is very had for me to resolve without seeing the original text. From what I can see, there are many highlights on the same page, and their is an issue with positioning.
Can you also confirm if the order issue still exists. And if possible, can you send me a screenshot of the Kindle pages that has several of your highlights that are not ordered correctly by the plugni.

@ProudBenzene thank you so much for sharing with me your clippings.txt file on email. @ProudBenzene 非常感谢您在电子邮件中与我分享您的clippings.txt文件。
I've managed to fix the first issue were your notes were not being parsed. The plugin had basic Chinese support, and there was a couple of bugs parsing Chinese book titles and general highlights as I never had examples to use for testing.我已经设法解决了第一个问题是你的笔记没有被解析。这个插件有基本的中文支持，并且在解析中文书籍标题和一般亮点时有几个bug，因为我从来没有用于测试的例子。
This should now be fixed in 1.9.1. Can I ask you to download and confirm it solved the absence of your notes?现在应该在1.9.1中修复此问题。我可以请你下载并确认它解决了你的笔记缺席？
In terms of the issue with order... I think I know what the issue is, but it is very had for me to resolve without seeing the original text. From what I can see, there are many highlights on the same page, and their is an issue with positioning.关于秩序的问题…我想我知道问题是什么，但它是非常有我解决没有看到原文。从我所看到的，有很多亮点在同一页上，他们的是一个定位的问题。
Can you also confirm if the order issue still exists. And if possible, can you send me a screenshot of the Kindle pages that has several of your highlights that are not ordered correctly by the plugni.您是否也可以确认订单问题是否仍然存在。如果可能的话，你能给我一个Kindle页面的截图，其中有几个你的亮点没有被plugni正确排序。

Hello, thank you for your update! I have been looking forward to the repair of this bug!
Just re-imported my book, as you said, the order problem of highlights has been solved, the first issue has been solved, and my notes in 《飘》(gone with the Wind) have been transferred perfectly with highlights. For the second issue, I just tested it, and the re-imported 《围城》(besieged Fortress) did not reappear the problem that the previous notes did not correspond to the order of highlights. In other words, I feel that this problem have also been fixed. Of course, I'd be happy to provide you with screenshots of misordered notes in Kindle and other help to check this problem before using this version of the plug-in. If still needed, please let me know and I will send it to you by e-mail.
I have a new bug that seems to have appeared. after syncing books, some books generate two markdown files, one of which has a number in the file name. my file naming template is {{title}}-{{authorsLastNames}}, which doesn't contain a number. the content of the two files is exactly the same, only the file names are different. not all books generate two files, only some do. if it's not related to this issue, I can raise another issue about it😁.

Then, by the way, it seems that you forgot to change the version number in manifest.json in your release, which may cause others not to check for updates🤔.
Finally, thank you for your work on this plug-in, and thank you for your efforts to fix this bug!

Thanks for confirming that all the issues you initially experienced have now been resolved @ProudBenzene. I will close this thread on that basis.
With regards to what you've experienced were the plugin creates two markdown files. This is by design. The plugin does not override any existing files (as there is no guarantee that a user has not made their own custom changes that they want to retain). So it opts to create new syncs under a new name by appending a timestamp to the end of the file. I've created #243 to allow a user to customise this behaviour.
And thanks for reminding me about mainfest.json! I haven't updated the plugin in sometime and have already forgotten my workflow.


Add Adaptive Personalized Federated Learning

Adding the APFL algorithm from Adaptive Personalized Federated Learning.

@jaehunro Done! Thank you for the feedback :)


fix: seeking in seconds

#31  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gneiru and the rest of your teammates on  Graphite


Have nodes annotate themselves with machine name.

This will make it easier for the machine-controller to link Machine and Node objects together, even if the names don't match (like if we choose to create-then-delete VMs on updates).

This change is


AvoidDefaultValueForMandatoryParameter : The rule is not be triggered when the value of the parameter 'Mandatory' is an integer

If, for a parameter attribute, the value of the parameter 'Mandatory' is an integer, the rule will not be triggered:
Invoke-ScriptAnalyzer -ScriptDefinition @'
function Test3
{
    [CmdletBinding()]
    [OutputType([String])]
    param(
        # this one has default value
        [Parameter(Mandatory=1)]
        $Param31="String",

        # this parameter has default value but it is not mandatory
        [Parameter(Mandatory=0)]
        $Param32='Test'
    )
    $Param31
    $Param31 = "test"
}
'@

Even if this writing is not a good practice since the runtime allows it, the rule should be triggered.
Unless to create a rule to handle this type of writing :-)
(Get-Module -Name PSScriptAnalyzer).version.tostring()
#1.16.1

$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14409.1012
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0, 5.0, 5.1.14409.1012}
BuildVersion                   10.0.14409.1012
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Good spot. There are many scripts that the PowerShell language parser would accept although it will blow up at runtime. Adding extra validation in PSSA makes sense in my opinion. I think the special case that you pointed out is rather rare but I'm sure PSSA would accept a PR with this improvement and I would be happy to help/assist you as far as I can. In general I'm happy to add new features/improvements to PSSA but I think there are bigger fish to fry at the moment.

The method already exists, GetValue, which manages the three writings.


Pass props into native elements

Some components take only a few props that are required for logic inside their code, they should spread all of the remaining props that was passed into them to the native html element, you should also remove redundant native attributes/event handlers from props type interface and extend it with the one provided by React.
You can see how it should be done inside
src/components/checkbox/Checkbox.tsx
src/components/switch/Switch.tsx
Components to refactor:

[ ] src/components/toggle
[ ] src/components/text (fix types)
[ ] src/components/svgicon (fix types)
[ ] src/components/selectbutton (fix types)
[ ] src/components/message/Message.tsx (fix types)

hey @nowyDEV can I try to do it?

hey @nowyDEV can I try to do it?

Sure, go ahead

hi @nowyDEV, sent a PR, please review https://github.com/nordcloud/GNUI/pull/224


No connection to ATmega4809

I try want to program an atmega4809 on a arduino nano every with an raspberry pi 4B with it's tx/rx pins.(The usb cable is no option)
I wave used the the following command to find the device but there is no response.
$ sudo pymcuprog ping -d atmega4809 -t uart -u  /dev/serial1  Connecting to SerialUPDI
When i quit the command with ^C after a long time of waiting for response i get the following message:
`
^CTraceback (most recent call last):
File "/usr/local/bin/pymcuprog", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/pymcuprog.py", line 292, in main
return pymcuprog_main.pymcuprog(arguments)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/pymcuprog_main.py", line 82, in pymcuprog
status = _start_session(backend, device_selected, args)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/pymcuprog_main.py", line 562, in _start_session
backend.start_session(sessionconfig)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/backend.py", line 376, in start_session
self.programmer.setup_device(
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/programmer.py", line 82, in setup_device
self.device_model = get_nvm_access_provider(self.transport,
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/nvm.py", line 44, in get_nvm_access_provider
accessprovider = NvmAccessProviderSerial(transport, device_info, baud=frequency, options=options)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/nvmserialupdi.py", line 51, in init
self.avr = UpdiApplication(port, baud, self.dut)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/serialupdi/application.py", line 72, in init
self.phy = UpdiPhysical(serialport, baud)
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/serialupdi/physical.py", line 31, in init
self.send([constants.UPDI_BREAK])
File "/usr/local/lib/python3.9/dist-packages/pymcuprog/serialupdi/physical.py", line 100, in send
self.ser.write(command)
File "/usr/lib/python3/dist-packages/serial/serialposix.py", line 622, in write
abort, ready, _ = select.select([self.pipe_abort_write_r], [self.fd], [], None)
KeyboardInterrupt
When i use serial0 i get this massage:
pymcuprog.pymcuprog - ERROR - Operation failed with error: (22, 'Invalid argument')
`
I have connected it like the the following image.
With kind regards.

Stef

Its been a while since I used the native serial on rPi, but it has worked in past (admittedly its not under regression test).
Have you followed the advice on the lower section ("Notes for Linux systems") on pyedbglib? (https://github.com/microchip-pic-avr-tools/pyedbglib)

Just an update,
I have not found the solution yet, because the lag of time for this project at my job.
I want to thank you for your response.
If i find a solution i wil at it to the issue.

@StefMijs I had this same issue on a RPi3 but have things working now.
The issue was that I was using the mini UART instead of the PL011 UART (for why this is an issue look at "Notes for the Raspberry Pi 3.. " https://www.abelectronics.co.uk/kb/article/1035/serial-port-setup-in-raspberry-pi-os)
To fix this I just added dtoverlay=disable-bt  in /boot/config.txt and rebooted.


NEED HELP!

Hi!
today I come across this software and was very interested but found no way to install it and it would be great if you are willing to offer me help.
and hope also I am looking forward to you upgrading this client and adding me features Thanx

There's currently no installer, it's just a standalone executable. You can set it to auto-run on boot in the settings menu by right-clicking on the notification-tray icon, and clicking "Settings".

Hey, I was Wondering if you could help me execute this file and help me to make it run on my device.

Sure, just download the release archive from the Releases page, extract the archive, and run the SaorCon.exe executable found within.


MINOR: catch InvalidStateStoreException in QueryableStateIntegrationTest

A couple of the tests may transiently fail in QueryableStateIntegrationTest as they are not catching InvalidStateStoreException. This exception is expected during rebalance.

@guozhangwang @enothereska just spotted this one

LGTM

@dguy looks like there was an error on queryOnRebalance.

LGTM and merged to trunk.


Expand select bugs with literals in a function call

VSCode Version: 1.15.1
OS Version: win10
I don't know if these 2 scenarios are 2 effects of the same bug, or 2 different bugs.

Javascript file, try to expand select on Math: funcCall(Math.PI, 3,4) The 2nd step will Not select "Math.Pi", but all the parameters. See the gif

Go files: func(var1, var2, 3, "s"). Cursor on var1 or var2, expand will select "var1, var2" instead of just the var. See the gif

Reproduces without extensions: Yes

duplicate of #4795


Update Rust Nightly Version

Fix a new Rust Nightly version

Auto-generated PR

Pull Request Test Coverage Report for Build 762312812

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.024%

Totals

Change from base Build 751399954:
0.0%

Covered Lines:
15692

Relevant Lines:
19131

💛  - Coveralls

 Update Rust Nightly


Updated changelog for ROCm 4.2

Updates changelog for final release of ROCm 4.2. This is a minor change, so I will probably merge with only one approval from @jzuniga-amd.

LGTM.
(This change has to be ported back to develop at some point. What we do in rocSOLVER is to prepare the changelog when we "release" from development to master at feature compete -the end of the development cycle- I suggest we do the same here for future releases to avoid having these "update changelog" commits cascading back...)

Agreed. I forgot to do it this time, but in the future I'll try and keep these changes in the develop branch.


Ii get error in ios

New Version
0.64
Old Version
0.63.3
Build Target(s)
i don`t know
Output of react-native info
System:
OS: macOS 12.6
CPU: (8) x64 Apple M1
Memory: 27.44 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 14.16.1 - ~/Projects/WebstormProjects/ReactNativeProjects/mobilenew/node_modules/.bin/node
Yarn: 1.22.11 - /usr/local/bin/yarn
npm: 7.24.0 - ~/Projects/WebstormProjects/ReactNativeProjects/mobilenew/node_modules/.bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
Languages:
Java: 16.0.1 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.0 => 0.64.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Issue and Reproduction Steps

after upgrading RN version i getting error in ios. I disable hermes and build succesfull in ios. But when simulator connecting to js i getting many errors  com.facebook.react.JavaScript (12)
#0	0x0000000102ce57f5 in facebook::jsc::JSCRuntime::objectRef(facebook::jsi::Object const&) at /Users/ombogdan/Projects/WebstormProjects/ReactNativeProjects/mobilenew/node_modules/react-native/ReactCommon/jsi/JSCRuntime.cpp:1431

0.64

Closing as this version is too old and unsupported.
The versions we support are:
https://github.com/reactwg/react-native-releases/


sap.m.OverflowToolbarButton 1.28.x Feature Request

I like the new OverFlowToolbar/Buttons.
Inside overflow popup, the button text will be shown besides the icon.
It would be cool to be able to enbale automatically set the tooltip from text.
In my code i always have to use something like
icon="sap-icon://forward"
tooltip="{i18n>MyText}"
text="{i18n>MyText}"
so there are quite a lot redundant declarations inside views.
This nice options would make my live easier ;-)
Cheers Holger

Hi Holger,
Tooltips are usually used to have a longer more descriptive text than the actual Button text.
So we modeled it as two separate properties.
Best regards,
Tobias

What about defaulting the tooltip property to the value of the text property? You can still define the tooltip with a more descriptive text if you want to.
I'm not sure if we've done this somewhere before but I think that's what @hschaefer123 ´s idea was.

How would you disable tooltips then? One might expect that setting the empty string "" should be different from setting null or undefined, but we decided at the beginning that "" and null should be the same for properties of type string.
Nevertheless, when always having a tooltip is acceptable, then the fallback to text makes sense.
The commons.TextViewRenderer for example does it that way`:
		if (oTextView.getTooltip_AsString()) {
			rm.writeAttributeEscaped("title", oTextView.getTooltip_AsString());
		} else if (oTextView.getText()) {
			rm.writeAttributeEscaped("title", oTextView.getText());
		}

Yep, that was the way I thought it could be solved. I don't think that someone would not like to have a tooltip.

To me this has a smell to it. It makes a bad practice more convenient. The tooltip should in general not be the same as the text property but convey extra information.


Acceleration of GPU

Environment

Tesseract Version: 4.0.0
Commit Number:
Platform: Unix 18.04

Current Behavior: run smoothly but consume 0.24s for per time
Expected Behavior: We have used GPU, so  we have a GPU version in order to run faster
Suggested Fix: could you offer a version to run on GPU???

Obviously we can't. This is Open Source, so feel free to provide the necessary code.

@RichardHwang163 It would be great if you can share some details about changes in GPU version of tesseract you made to able to work it with GPU.


Weird buttons + Pull Request

On this page Fork, Star etc. and Donate buttons are weird. Here are the exact buttons:

Fork's weird code: (line 539, index.html)

Donate's weird code: (line 956, index.html)

Confirmed this bug? Click me to fix weird looking lines, or click me if  you want to remove maxAge from all lines in this file The problem is not maxAge, problem is maxAge doesn't work on these buttons.

The 89affa4 commit is responsible, as @fordhurley noticed. The backstory is that I implemented three different approaches in parallel to see which one worked best, and I implemented ? detection in two of them. I thought I had already fixed it!


[Event Request] Table 77/9657 - Report Selections/Custom Report Selection - OnBeforeCheckEmailBodyUsage with IsHandled

Dear ALAppExtensions team,
Through this issue we would like to request event OnBeforeCheckEmailBodyUsage to be added to procedure CheckEmailBodyUsage in tables "Report Selections" and "Custom Report Selection".
The signature of the event publisher procedure would be as follows:
    [IntegrationEvent(false, false)]
    local procedure OnBeforeCheckEmailBodyUsage(var Rec: Record "Report Selections"; var IsHandled: Boolean)
    begin
    end;

with VAR-parameters Rec and IsHandled.
Which would be called as follows:
    local procedure CheckEmailBodyUsage()
    var
        ReportSelections: Record "Report Selections";
        ReportLayoutSelection: Record "Report Layout Selection";
        ShowEmailBodyDefinedError: Boolean;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeCheckEmailBodyUsage(Rec, IsHandled);
        if IsHandled then
            exit;

        if "Use for Email Body" then begin
            ReportSelections.SetEmailBodyUsageFilters(Usage);
            ReportSelections.SetFilter(Sequence, '<>%1', Sequence);
            ShowEmailBodyDefinedError := not ReportSelections.IsEmpty();
            OnCheckEmailBodyUsageOnAfterCalcShowEmailBodyDefinedError(Rec, ReportSelections, ShowEmailBodyDefinedError);
            if ShowEmailBodyDefinedError then
                Error(EmailBodyIsAlreadyDefinedErr, Usage);

            if "Email Body Layout Code" = '' then
                if ReportLayoutSelection.GetDefaultType("Report ID") =
                   ReportLayoutSelection.Type::"RDLC (built-in)"
                then
                    Error(CannotBeUsedAsAnEmailBodyErr, "Report ID", ReportLayoutSelection.Type);
        end;
    end;

This allows us to apply additional checks for other e-mail body template implementations added by extensions.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Update intro.md with missing dependencies

Hey polars team 👋 ,
I tried to run the Rust example locally, and I found that Cursor dependency was missed. I added on the quickStart documentation to make easier copy + paste for those trying Polars with Rustlang.

Close this issue on favor #213


Fillable allows insert any data

Laravel Version: 5.5.x
PHP Version: 7.1
Database Driver & Version: N/A

Description:
I was working with few features on my project and noticed that laravel $fillable is not working as expected and allows to input any columns and values.
Steps To Reproduce:

Install new app: laravel new blog

Edit: DatabaseSeeder.php :

        $user = \App\User::create(["test" => "test"]); // First case

        $user = new \App\User();
        $user->fill(["test" => "test"])->save(); // Let's fill first of all and only after that try to save

Note that I do not changed original generated User model contents however to be more specific here its: https://gist.github.com/deividaspetraitis/4c124538bf1f254ce224b3839622cc49

Run: php artisan db:seed

It will produce something like:
[Illuminate\Database\QueryException]
  SQLSTATE[42S02]: Base table or view not found: 1146 Table 'homestead.users' doesn't exist (SQL: insert into `users` (`test`, `updated_at`, `created_at`) values (test, 2017-11-09 11:41:49, 2017-11-09 11:41:49))

It doesn't matter that we don't have table at this case since interested only in query it self and as we can see it is allowing to push test column even it's not defined and whitelisted in our model. Is it a normal behaviour, did I missed something in docs?
Issue is produced only in CLI mode.

How is this error related to $fillable? This repo is for bug tracking so if you need help I advise you to use forums or slack channel.

@Dylan-DPC I believe it related $fillable property. Let me be more specific:
Inserting data:
`  $user = \App\User::create(["test" => "test"]); // test column
Our $fillable property:
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'email', 'password', // we do allow only these?
    ];

And generated query:

insert into users (test, updated_at, created_at) values (test, 2017-11-09 11:41:49, 2017-11-09 11:41:49)

We do have allowed insert values only for these columns:  'name', 'email', 'password' but generated query is trying to insert into test column. Isn't that a bug?

Seeder runs with Model::unguard

@decadence thank you!


Embedding and macro in one project

Hello!
I use file embedding and --macro in one .lime configuration:
<assets path="src/test/assets" rename="assets/config" embed="true" />
<haxeflag name="--macro" value="mcover.MCover.coverage(['modulename'], ['src/main/haxe'], null)" />
These two lines conflict:
Error:Compilation failed
Information:- Running command: haxe -main ApplicationMain ... -D web --macro "mcover.MCover.coverage(['gore'], ['src/main/haxe'], null)" -swf-lib build/utest/flash/obj/assets.swf ... -debug
Error:Could not process argument ['src/main/haxe'],
Information:Class name must start with uppercase character
Argument is correct.
Disabling of embedding (embed="false") helps but I need it.
The thing is that everything works good when there is only one of these lines in .lime.
Also this configuration works correctly in Windows.
The manual executing of built hxml
haxe debug.hxml
works correctly.
Plugin ver. 0.9.4 (IDEA 13 and 14 both),
IDEA 13 (135.1306), 14 (141.1532.4),
Linux Mint 17.2 x64,
Java 1.8.0_25.

I'm sorry for that, it is the result of lime build execution. However, It will be great If the plugin will inform user about this execution.


[FLINK-3021] Fix class loading issue for streaming sources

Streaming sources were directly assigned their InputFormat in the StreamingJobGraphGenerator. As a consequence, the input formats were directly serialized/deserialized by Akka when the JobGraph was sent to the JobManager. In cases where the user provided a custom input format or an input format with custom types, this could lead to a ClassDefNotFoundException, because the system class loader instead of the user code class loader is used by Akka for the deserialization.
The problem was fixed by wrapping the InputFormat into a UserCodeObjectWrapper which is shipped ot the JobManager via the JobVertex's configuration. By instantiating stream sources as InputFormatVertices, the corresponding InputFormat is retrieved from the Configuration in the initializeOnMaster method call.

+1 to merge.

Very neat how you created a test JAR file with the custom InputFormat.
+1 for merging.

Will merge it.


May I give an awkward question

Hi, thanks for great work.
How can I adjust the either 3-view or 2-view training details in the cfg code?
I just started exploring this field, so it might seem awkward to you, but I will be waiting for your reply
thanks

I have another question,
is the number of epochs fixed to 300, regardless of the number of batch size and gpus?

Hi, thanks for your interest.
During training, we select 2, 3, and 4 source views as inputs with respective probabilities of 0.1, 0.8, and 0.1, refer here.
For testing, you can modify the number of input views here.
Yes, the default number of epochs is set to 300 here, and the number of iterations per epoch is 1000 here.

Thanks!


hey having issues figuring out cmake

is there any chance u could add add a make file or build.sh or build.bat

figured it out

Thanks for your interest!
I added a few basic instructions. It's basically the same for every CMake-based project though, and information on the net is plentiful.  CMake can generate build files for various build tools and IDEs, so there's no plan to add any of those to the repository.


Needs of next release.

Thanks for nice library. It saved me.
I found #348 is merged in master branch, but It doesn't included at npm.
Can we release next version?

@Hazealign  yes I am preparing the next release and it should hit npm later this morning. Just working on one final PR, then will update release notes and publish.


[cartservice] Update to .NET 7

Changes
Update target and docker images to .NET7 for cartservice.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[x] CHANGELOG.md updated to document new feature additions
[ ] Appropriate documentation updates in the docs N/A
[  ] Appropriate Helm chart updates in the helm-charts N/A

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@cartersocha, I was able to reproduce. I am not sure how I missed that while testing (probably I have made mistake while building new docker image).
Bug reported under https://github.com/open-telemetry/opentelemetry-dotnet/issues/4600
Locally, I have removed Trimming option. It will increase image size, but it is working correctly.

@cartersocha, trimming was working on .NET 6 by accident (it is producing warnings). There is a plan to make a support for trimming operation in OpenTelemetry .NET for 1.6 version (tentatively scheduled on November).
It should be good to merge for now.


Remove some obsolete config options

See individual commit descriptions for justifications
Note: For Config.reportjoinsperiod, the server doesn't even use it anymore

Feel free to cherry-pick what you want

Cherry-picked.


[#397] Add ZIP 321 URI parser

adds a transaction proposal API for URI strings
Closes #397
Add proposeFulfillingPaymentUri to changelog

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

[x] Self-review your own code in GitHub's web interface[^1]
[ ] Add automated tests as appropriate
[ ] Update the manual tests[^2] as appropriate
[ ] Check the code coverage[^3] report for the automated tests
[ ] Update documentation as appropriate (e.g README.md, Architecture.md, etc.)
[ ] Run the demo app and try the changes
[x] Pull in the latest changes from the main branch and squash your commits before assigning a reviewer[^4]

Reviewer

[ ] Check the code with the Code Review Guidelines checklist
[ ] Perform an ad hoc review[^5]
[ ] Review the automated tests
[ ] Review the manual tests
[ ] Review the documentation, README.md, Architecture.md, etc. as appropriate
[ ] Run the demo app and try the changes[^6]

[^1]: Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[^2]: While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test
something during development of this pull request, write those steps down.
[^3]: While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.
[^4]: Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.
[^5]: In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[^6]: While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are
more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

@HonzaR I rebased the PR

Hi @pacu, can you rebase it one more time, please?

@HonzaR Rebased!

Thanks for the update @pacu. We need to change the FFI implementation, as we got several build errors. See the CI output. Can you take a look into it, please?

@HonzaR what do you want me to do with this error?
> Task :detektAll FAILED
/home/runner/work/zcash-android-wallet-sdk/zcash-android-wallet-sdk/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/TransactionEncoder.kt:11:20: Interface 'TransactionEncoder' with '11' functions detected. Defined threshold inside interfaces is set to '11' [TooManyFunctions]

@HonzaR what do you want me to do with this error?
> Task :detektAll FAILED
/home/runner/work/zcash-android-wallet-sdk/zcash-android-wallet-sdk/sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/transaction/TransactionEncoder.kt:11:20: Interface 'TransactionEncoder' with '11' functions detected. Defined threshold inside interfaces is set to '11' [TooManyFunctions]

I just suppressed it, as there is no quick solution for such a warning. Thank you for rebasing the PR!

@HonzaR  I squashed it


Retrieve an association index

While re-reading documentation, I can't find how to retrieve an association index at both ends in one to one setup. Is it possible?

I guess you are referring to the association identifier. This is only used to identify a particular association on a one-to-many style socket. This field is ignored on a one-to-one style socket, since there is no need to identify a particular association. There is only one...

Yes, but I found this identifier while inspecting packets on the wire and it's an identical thing to my abstraction of connection IDs in the layer on top, so I thought that I could just replace it with one that can be retrieved from SCTP instead of tracking/assigning IDs in custom logic.
Anyway, thanks for clarifying this.


Why some spans don't have the parent root and the number of spans is too large?

A lot of services set the root span to have the same span ID as the trace
ID. This helps from generating another random number.
If there are a lot of spans, it could be because many operations are in the
same trace.
Please prefer stack overflow or https://gitter.im/openzipkin/zipkin for
questions as github issues are for changes to the codebase.
This type of concern is a question, not a change, so please contact on
https://gitter.im/openzipkin/zipkin for questions or troubleshooting
On Mon, Feb 5, 2018 at 5:38 AM, CyberDick<EMAIL_ADDRESS>wrote:

[image: image]
https://user-images.githubusercontent.com/15179117/35788627-6d8259ba-0a71-11e8-945a-0cd708cb9dc8.png
[image: image]
https://user-images.githubusercontent.com/15179117/35788625-6925dfa4-0a71-11e8-82c9-2270aaecc405.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/1905, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611bQjwTFIp_YI7kPCPoM58tojG7hks5tRoW3gaJpZM4R46Md
.


KAFKA-3159: stale high watermark segment offset causes early fetch return

cc @junrao @becketqin @ijuma
This is a follow-up to #688 which fixes the case when there are is only one replica in ISR.

Like @junrao said in #688, I wonder if we should only compare message offset in precedes (as it used to be). And maybe we should rename it to messageOffsetPrecedes to make it unambiguous.
If we do that, then I think we also have to change the following in Partition.maybeIncrementLeaderHW to also check the offsetOnOlderSegment (to restore Becket's fix):
if(oldHighWatermark.precedes(newHighWatermark)) {
It would also be good to add a comment above Jason's change with some of Jun's explanation:
The problem that I am seeing is that when there is only 1 replica in ISR, the only time that we will update HW is when a new message is appended. So, if no new message is appended and we roll a log segment, HW will stay on the old segment. Now, if a new fetch request comes in with log end offset, log.fetch() will return the new segment in LogOffsetMetadata. Then, in DelayedFetch.tryComplete(), since the fetch offset is not on the same segment as HW (even though offset is the same), we will complete the fetch request immediately and therefore incorrectly ignore max wait time.

Finally, a new JIRA for changing it so that HW moves to the new segment.
Thoughts?

@ijuma There's actually only two usages of the precedes() function currently. The first is used in Partition to determine if the high watermark should be updated. Checking the segment base offset makes sense to me in this case since we should update the high watermark when the segment changes.
The other case is in DelayedFetch and the segment base offset check doesn't make as much sense since there is already an explicit prior check to handle differing segment offsets.
So maybe we could revert the precedes() change and just modify the check in maybeIncrementLeaderHW to check the segment base offset explicitly (e.g. with LogOffsetMetadata.offsetOnOlderSegment). What do you think?

@ijuma Haha, I think I suggested the same thing you already proposed. I guess I'll go ahead and make this change.

Sounds good. :)

LGTM

@junrao Thanks for reviewing. I fixed the comment.

Thanks for the patch. LGTM


add coverity scan on self-hosted runner

This can't be compiled without python3-genmsg package https://github.com/tiiuae/px4_ros_com/blame/master/Dockerfile#L3


[hhvm] #1499 - update hhvm service

http://hhvm.h4cc.de... -> https://php-eye.com/api/v1/package...

Warnings

:warning:

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @bkdotcom!

  Generated by :no_entry_sign: dangerJS

Thanks for submitting a PR for this. I'll submit comments for review shortly

I'll create some tests asap when I actually have time to get the environment up and running...   so far the edits were simply done on github.com

@chris48s thanks for the feedback, I believe I've incorporated all of your suggestions

Thanks for contributing, changes look good to me.
Merged!
Thanks for reviewing @chris48s 😄


Fix #534 by implementing name validating widget

What's changed?
This fixes #534, not only invalid character will be blocked in GUI, invalid input from pasting will be cleaned for better UX.
But since Creator App also shares the same widget, it has changed, too.

@davidlatwe That's great work! :) Lovely. 🚀
I wonder however if it should include the reported message (the invalid characters) somewhere on the Widget too so the user is aware of that aside of the "red fade" on the QLineEdit. What do you think? Or would it be overkill?

Thanks @BigRoy  :D
Yeah, I agree that it would be better if we put a message printer in the bottom of that dialog.
Furthermore, should we also check the asset name exists or not ? Like the Creator App did.


bitstamp and kraken imporvements

support to withdraw funds for other cryptocurrencies and implemented ripple deposit address for Bitstamp and bitcoin for kraken

Pavel Niedoba<EMAIL_ADDRESS>於 2018年9月24日 週一 下午5:00 寫道：

@PavelNiedoba commented on this pull request.
In
xchange-bitstamp/src/main/java/org/knowm/xchange/bitstamp/dto/account/BitstampRippleDepositAddress.java
https://github.com/knowm/XChange/pull/2808#discussion_r219768116:

@@ -44,4 +52,23 @@ public String toString() {
? addressAndDt
: String.format("RippleAddress[%s, dt=%s]", address, destinationTag));
}

static class BitstampDepositAddressDeserializer extends JsonDeserializer {

This is done same way as BitcoinDepositAddress. I just took the code from
there and extended it so it supports destination tag for ripple addresses.
Otherwise separate method for ripple address would have to used. Now
requestDepositAddressObject() will work for all currencies, for Ripple it
returns extended version of BitstampDepositAddress which has destination
tag.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/knowm/XChange/pull/2808#discussion_r219768116, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AZ9jtLpbgFI7I_kGlfTq7t8h0_kzFjfiks5ueJ9KgaJpZM4Wxm8i
.


Revert "Follow wireframe visual design 🎨"

Reverts DevKaranJ/recipes#18

Status: Invalid Submission ❌ ❌ ❌
Hi Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not follow the correct PR requirement.

[ ] Kindly, merge all feature branches to the dev and then create your PR from the dev branch to the main. Submit that PR for a review 👍🏽

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Curl converter

Maybe some mention in the docs?

Any ideas where to add this mention? Is ->Request->Debugging a good place?

Either there, or maybe as a section in "backends"? It is kind of a manually invoked backed ;-) And definitely another type of interpreter if we treat backedns as interpreters

I like the way of thinking about toCurl converter as of just another type of request interpreter. But that's not the first thing which comes to mind when you think about requests debugging ;)


Roll engine 2d6631ae5d1c..728ff715e88f (4 commits)

git@github.com:flutter/engine.git/compare/2d6631ae5d1c...728ff715e88f
git log 2d6631ae5d1c..728ff715e88f --no-merges --oneline
2019-08-28<EMAIL_ADDRESS>[fidl][flutter_runner] Port Migrate to new fit::optional compatible APIs (flutter/engine#11636)
2019-08-28<EMAIL_ADDRESS>Update the ui.LineMetrics.height metric to be more useful to external users (flutter/engine#11456)
2019-08-28<EMAIL_ADDRESS>Roll src/third_party/skia b1ade2a4261e..a268dfb74add (5 commits) (flutter/engine#11643)
2019-08-28<EMAIL_ADDRESS>Update CanvasSpy::onDrawEdgeAAQuad for Skia API change (flutter/engine#11638)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


[fr] scroll list horizonal options

What do you mean by this?

I am going to close this issue since there is no response.