Next example doesn't work unless source is built

The next example only seems to work when the source is built locally, and not when it's installed from npm.
Weirdly enough, if I install the source locally and then switch to using the prebuilt npm package, it works :/
Trial 1: Using prebuilt npm package only

Don't build the web-llm repo from source
Set the dependency in package,json to the prebuilt package

...
    "@mlc-ai/web-llm": "^0.2.2",
...

install and run

npm install
npm run dev

Run fails

Trial 2: Using prebuilt npm package after locally installing web-llm

Build the web-llm repo from source
Set the dependency in package,json to the prebuilt package

...
    "@mlc-ai/web-llm": "^0.2.2",
...

install and run

npm install
npm run dev

Run succeeds

Trial 3: Building from source

Build the web-llm repo from source
Set the dependency in package,json to the local package

...
    "@mlc-ai/web-llm": "../..",
...

install and run

npm install
npm run dev

Run succeeds

I'm a bit flummoxed as to why 1 doesn't work but 2 and 3 work. Specially 2 is surprising to me.

Get it.. this is surprising, would be useful to look into the difference. I wonder if it has to do with way things are bundled

getting this error:
This file is being treated as an ES module because it has a '.js' file extension and<EMAIL_ADDRESS>contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3612:76
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3624:7
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3556:5
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3557:3
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3751:2
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {
  digest: undefined
}
- error Error [ReferenceError]: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and<EMAIL_ADDRESS>contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3612:76
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3624:7
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3556:5
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3557:3
    at file:///web-llm/examples/next-simple-chat/node_modules/@mlc-ai/web-llm/lib/index.js:3751:2
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {

Just to confirm, you're seeing that error when using the pre built binary from npm, and not when building from source, correct? if yes, it matches my error as well

yes. Right. Building a source is not possible. If it is required, why not just upload the binaries in a seperate repo?

To clarify a bit
Before #138 it was not possible to use this package with NextJS (by building from source or by using the package from npm).
After #138 it's now possible to build the project from source and then use it with NextJS, but for some reason the pre-built binary with npm is not working.
See instructions to build form source here: https://github.com/mlc-ai/web-llm#build-webllm-package-from-source

Yeah tried it did not work. Spent significant time on this. Overall documentation is very bad I would say.

Would be helpful if you could provide more information about why building from source did not work, and if the issue was with the next integration specifically or you were not able to build from source at all.
I have a working example here which works with next js, complete with a script to build from source on vercel.
https://github.com/narangkay/interactive-resume

Also, I think if your problems are unrelated to the next integration and more about inability to build from source, you might want to create a new issue

well I created the build and it is working in the development. Instead of simplifying process you are putting it on inability to generate.

With any Next.js project, the examples/next-simple-chat project, when the pre-built Web LLM package from the NPM package registry @mlc-ai/web-llm (as of v0.2.8) is installed and used directly, the following ReferenceError is raised:
ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and<EMAIL_ADDRESS>contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.

One way to fix the above ES Module and CommonJS syntax mixing is by leveraging Next.js's support for automatically transpiling dependencies from packages.
With Next.js v13.0.0+, adding the following to next.config.js is all that is needed:
/** @type {import('next').NextConfig} */
const nextConfig = {
  transpilePackages: ['@mlc-ai/web-llm'],
  ...
}

module.exports = nextConfig

So, we could update examples/next-simple-chat/next.config.js with the above line to get rid of the above ReferenceError.
But that results in the following compiler error:
- error<EMAIL_ADDRESS>Module parse failed: Identifier 'Module' has already been declared (6895:20)
|             return async function() {
|                 let Module = arguments.length > 0 && arguments[0] !== void 0 ? arguments[0] : {};
>                 var Module = typeof Module != "undefined" ? Module : {};
|                 var readyPromiseResolve, readyPromiseReject;
|                 Module["ready"] = new Promise(function(resolve, reject) {

Import trace for requested module:
<EMAIL_ADDRESS>./src/utils/chat_component.tsx

Her's the diff of the pre-built mlc-ai/web-llm/lib/index.js (right-side) pushed to the NPM package registry and a fresh source-build (left-side):

The above error is likely because of the redefinition of Module in function EmccWASI().
The rollup.config.js and examples/next-simple-chat/next.config.js doesn't seem to be in sync to produce the same bundle/compiled output.
If the use of CommonJS cannot be avoided in the bundle, a solution to consider is to conditionally export CommonJS for require and ESM for import usages in other projects as dependencies.

Hi @praveen-palanisamy, thank you so much for helping here - I did not have the NextJS expertise necessary to understand what was wrong.
I was able to follow along in your explanation until the following line:
The [rollup.config.js](https://github.com/mlc-ai/web-llm/tree/main/rollup.config.js) and [examples/next-simple-chat/next.config.js](https://github.com/mlc-ai/web-llm/tree/main/examples/next-simple-chat/next.config.js) doesn't seem to be in sync to produce the same bundle/compiled output.

I would love to fix this, since it seems like it would fix the root of the problem. Do you have any ideas on how we can sync the two?

Is there any progress on this issue?

This error should be address in 0.2.36 -- the next-simple-chat example should work out of the box.
For details see https://github.com/mlc-ai/web-llm/pull/397.


Change DHCP server address to link-local

This fixes #857. Using a link-local address reduces the chances
of IP conflict with pod, cluster, or routable networking. Address
is now <IP_ADDRESS>/32. Chosen semi-randomly, as 169.254.'k'.'v'
for KubeVirt.
Tested on os-3.9.0-alpha.4 dev cluster, and vanilla kubernetes. VMs
get DHCP info as before.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

ok to test

Thanks for the contribution!

Crazy eye on the details .k.v


Fix useId not found error when Salt is re-bundled by downstream library

Issue raised when app is using a library re-bundling Salt.

Reference https://github.com/webpack/webpack/issues/14814#issuecomment-1536757985

[ ] Apply same fix to useInsertionEffect

Thanks to @DavieReid suggesting the fix

/release-pr

/release-pr

/release-pr


chore: dependency updates

@pozil Can you take a look at the failing LWC tests? Looks like the update to<EMAIL_ADDRESS>changed something.


add plot metrics

#171

Hi @wxchan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Should I change it to plot_metric since it only plots one metric?

an example in examples/python-guide/plot_example.py:

@wxchan Did this finish?

@guolinke wait a minute.

@guolinke I change one misleading comment. Now finished. You can wait till the check passes.


Which endorsed preprint from BPC are we going to display?

Description
Initially, we want to display just a single article. We need to choose 1 of the endorsed articles that BPC have already created.
DoD

[ ] The DOI of the target article, added to #1

FYI @scottaubrey @will-byrne


Figure out and fix website viewport rescaling

Find a model that the website HTML, CSS and JavaScript code will follow to properly and functionally resize itself depending on the website's viewport changes. At the time of writing, I can't zoom out of the website without it literally looking the same, i.e. if I want to load more content down below, it won't show up. There's a way other websites do it that needs to be figured out.

Resolved so far by previous commits, starting from 06e29e9cc220d170a189f9dda5c492291215c8e5


Added RP2040 Support

And again added RP2040 Support for this Lib

You did a lot of work!  Thanks!

build failed on
/home/runner/Arduino/libraries/MCP4725/examples/MCP4725_wave_generator_RP2040/MCP4725_wave_generator_RP2040.ino:49:7: error: 'class MCP4725' has no member named 'selectWire1'; did you mean '_useWire1'?
   MCP.selectWire1();
       ^~~~~~~~~~~
       _useWire1

If you refactor the begin() the example needs to be rewritten (partially) too.

@Intubun
A good night sleep later I had some thoughts about the RP2040 support. As I do not have a RP2040 I cannot test this myself.
Is it possible to add the Wire or Wire1 instance in the constructor ?
That is already supported in the library, and if it works the PR is overkill.

MCP4725 mcp(addr, &Wire);

Can you give it a try?
The library does not track which Wire is used but is that a problem?

Yeah, it actually works! But some changes are still required for the output multiplexer of the RP2040, since it has some variables for setting the output pins...

And a useage example cant hurt ;-)

I'd like to make mention that this requires Arduino-Pico and not the official Arduino Mbed board library (which doesn't have Wire::setSDA/SCL)
https://arduino-pico.readthedocs.io/en/latest/install.html#installing-via-arduino-boards-manager

Thanks for this info. Will read the link later today if time permits.
Probably true for all I2C libraries?

Not necessarily? I'm not an expert, but I assume that this is just for Arduino IDE Wire-compatible interfaces. I'm sure you can use other libraries to access it.
Part of this is my inexperience with using Arduino IDE with RP2040 (I've only used it with Uno before) but it might be nice to know "hey, you can't just select the default builtin RP2040, you need Arduino-Pico" in the README section.

Thanks, I better reopen this issue as reminder to add the note in the readme.


QR code animations

App store link wasn't included on the QR code dismissing transition https://github.com/rainbow-me/rainbow-button/pull/11/commits/196df8d846b8142ee3e2c973afd88be70f21aa73
Also runned lint --fix

closing because @christianbaroni took care of it on https://github.com/rainbow-me/rainbow-button/pull/14


OpenBSD

Are you planning to support for OpenBSD?

Unfortunately, no.
DBeaver supports all OS that are supported by Eclipse


Remove comments from console project template

Fixes #2305

@saul
We kind of like that the templates point new developers to our good friends at fsharp.org.  Do you think this necessary?

I like this PR. C# does not have such comments in templates, VB does not either.

I think this is good, too.  I think that referencing FSSF in the Tutorial project (which we do) makes the most sense.  The comments in these templates are of no use to anyone once they've created their first project, and they're likely to just view them as an annoying them to delete.

Well ... I don't wish to bikeshed here or be difficult.
However, fsharp.org is an independent source of excellent fsharp information, it is a place that every fsharp developer should know about it.  Pointing it out at the start of creating a new project seems like a fine thing to do.  These have been in the templates since at least VS 2013 and no one has ever mentioned it as a problem.
Not every developer creates the tutorial or reads documentation.  But pretty much every first time F# developer creates a console app and opens the source file.
I am not inclined to remove this comment,   now that the Microsoft and OSS documentation has improved I would be accept a PR to add a link to that page as well, or a PR to improve the text ...
An example of a new .cs tech that provides links to documentation
This is the .cs file for Azure WebJobs ---
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Microsoft.Azure.WebJobs;

namespace WebJob1
{
    // To learn more about Microsoft Azure WebJobs SDK, please see https://go.microsoft.com/fwlink/?LinkID=320976
    class Program
    {
        // Please set the following connection strings in app.config for this WebJob to run:
        // AzureWebJobsDashboard and AzureWebJobsStorage
        static void Main()
        {
            var host = new JobHost();
            // The following code ensures that the WebJob will be running continuously
            host.RunAndBlock();
        }
    }
}

@KevinRansom I'm inclined to agree with @cartermp that the new Tutorial project is far more informative. If we were to keep a link to anything, I think a link to https://docs.microsoft.com/en-us/dotnet/articles/fsharp/ would be best.
It contains links to fsharp.org and useful links to the rest of the F# documentation/beginners guides.

We should keep the comments in some form.
We still have about 1.9 million (or something like that) C# programmers (and more each year). These people have

have never tried F#
never heard of http://fsharp.org
have no friends or colleagues who use F#
have no idea what on earth that "0" is
have no idea where to look for more information on any of this.
will at most spend 30 minutes fiddling in the console project getting annoyed
they always create a console project (that's a problem in itself)
will not create a tutorial project unless guided

For these people, our aim is probably to convert 5-10% of them to continue on their learning path.
We just have to take the chance to point these people at something.  It's the #1 opportunity to give them some information - indeed it's really the on;y chance.  Perhaps http://fsharp.org is not right - perhaps the comments aren't right.  But it is very wrong to optimize this sort of material for ourselves.

@dsyme:

have never tried F#
never heard of http://fsharp.org
have no friends or colleagues who use F#

If you're trying to signpost newcomers to more information about F#, I don't think fsharp.org is the one place we should be referring to. A link to the new F# docs would be far more helpful, and maybe even a direct link to a page that links to "F# for C# programmers" and the tutorial page.

have no idea what on earth that "0" is

By that logic, the [<EntryPoint>] and printfn "%A" lines will also need explaining. Not to mention that "let x y = ..." is a syntax completely unfamiliar to non-functional programmers. I don't think the "0" is the confusing part of the console project, and I'd argue that it's probably the least for anyone who's made a console application already.
I completely agree with what you're saying, and in hindsight I was quick to remove all comments. I think the discussion should revolve around what needs explaining in the console application, and what we should be linking to. After a quick Google search, I found that there is no official "F# for C# programmers" doc which I personally find very useful when learning about new languages.
I'll close this PR and suggest that we continue the discussion on #2305.

@saul Cool, I like that approach

I don't think fsharp.org is the one place we should be referring to.

agreed

A link to the new F# docs would be far more helpful

Agreed - they are just what's needed for Visual Studio users.  We used to link to the old MSDN docs but they became a mess.

maybe even a direct link to a page that links to "F# for C# programmers" and the tutorial page.

That would be great

By that logic, ... also need explaining.

Agreed.  I think the basic logic is sound but the content and links are wrong
See you on #2305


Class leaflet-cluster-anim remains if removing MCG while spiderfied

If a cluster is spiderfied and the MarkerClusterGroup is removed from map, the "leaflet-cluster-anim" remains forever on mapPane.
This makes cluster icons lag behind during zoom in/out once the group is added back to the map. The class may be added a 2nd time later on, but only 1 instance is getting removed.
Demo: http://jsfiddle.net/ve2huzxw/44/

Click on cluster to spiderfy markers.
Remove MCG from map (using the provided button, do not unspiderfy manually).
Re-add MCG to map (using the provided button).
Zoom in/out.

This seems to be due to L.MarkerCluster._animationUnspiderfy() which uses a timeout to call group._animationEnd(), where the class is being removed, but only if the group is still on the map… which is no longer the case since we removed it.
Maybe we could simply use the group._noanimationUnspiderfy() instead to avoid this issue?
Demo: http://jsfiddle.net/ve2huzxw/46/

Yep this fix sounds right.

Fixed with PR #607


di: Provide safe wrappers for LLVM types

Provide Rust wrappers for LLVM metadata and debug info types and aim to wrap LLVM C API functions as methods of these wrappers, therefore try to make the logic of sanitizing the DI as safe as possible.

This change is

src/llvm/ir.rs line 1 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
can you help me understand the separation between this and di.rs? i find it a bit surprising that this imports things from di

I'm trying to keep a similar separation as LLVM does.
Metadata and MDNode are defined in llvm/include/llvm/IR/Metadata.h and they are general IR types - they are not specific just to debug info. All debug info types are (directly or not) inheriting MDNode, but not all MDNodes are debug info types.
https://github.com/llvm/llvm-project/blob/f8742b8d6a3489dc8974f4166d413a66cb8d9c21/llvm/include/llvm/IR/Metadata.h#L950
https://github.com/llvm/llvm-project/blob/f8742b8d6a3489dc8974f4166d413a66cb8d9c21/llvm/include/llvm/IR/Metadata.h#L950
I want to keep DI types in a separate module, like LLVM does it in llvm/include/llvm/IR/DebugInfoMetadata.h, where all types like DIType, DICompositeTypo etc. belong.
I imported things from DI, because I wrote the MetadataKind enum and to_metadata_kind methods which resolve Metadata into a specific type.

src/llvm/ir.rs line 4 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
would be nice to avoid this if it's not too inconvenient

OK, agreed, it shouldn't be too annoying. I actually could also make a separate PR where I remove all * imports all together. The import hygiene is not the best in bpf-linker in general.


Hardfault in CO_LSSslave_process (CO_LSSslave.c)

When my code reaches line 338 in CO_LSSslave.c, it has a hardfault. The line of code is memset(&LSSslave->TXbuff->data[0], 0, sizeof(LSSslave->TXbuff->data));. During debugging, I can see that it is a valid location, but I do not know why it fails.
This is the TXbuff struct:
/* Transmit message object */ typedef struct {     uint32_t ident;     uint8_t DLC;     uint8_t data[8];     volatile bool_t bufferFull;     volatile bool_t syncFlag; } CO_CANtx_t;
I am using an STM32F429ZI MCU.

Ah, I am not using LSSslave even though the default config had it enabled.

Ah, I am not using LSSslave even though default config had it enabled.


Data Race in entry.go:128

https://github.com/sirupsen/logrus/issues/295

The fix is in the issue #703 and pull request #702. Several users have reported this data race condition. Sadly I don't have permissions to merge that pull request. Let's hope some hero hear thou thy people's cry and merge that :)

The referenced pr has been already merged.


Using NullLogger types from Logging.Abstractions

aspnet/Logging#571
@JunTaoLuo @Eilon

Merging to unblock build


Fix test exclusion logic for nnbd plugins

We were skipping tests for all nnbd plugins, see more details in: https://github.com/flutter/flutter/issues/72493
This change should break CI as in the time period we were skipping tests some PRs that break the build landed.
I will land this on red as the tree is actually red (only that we don't see it right now as we're skipping tests)
fixes: https://github.com/flutter/flutter/issues/72493

This seems to be doing the right thing, the master analyze task didn't skip any plugins while the stable one skipped the nnbd packages.
This should land on red (as the tree is actually red right now, this change just makes us see it).
@blasten @bparrishMines I'm going to be OOO for a few weeks, feel free to merge this once it's approved.

@blasten Can we land this?

I pushed a commit to fix the analyzer issues. Once green, this can be landed.


FIND-81:integrate ciim api get

Pull Request
Ticket URL: https://national-archives.atlassian.net/browse/FIND-81
About these changes
As part of the transfer from https://github.com/nationalarchives/ds-wagtail

Add .env for sensitive variables
Adds Client API interface to CIIM
Integrates CIIM get request api from Kong(ds-wagtail) to Rosetta implementation
Adds an initial Record model
Integrates detail page view with initial Record model
Refactors, adds tests - some improvements
Updates Readme, docs

How to check these changes

http://localhost:65533/catalogue/id/C1234/ --> record details page with page title id (iaid) value from ciim
http://localhost:65533/catalogue/id/C1905803/  --> (no data in ciim at this time, available in discovery) 404
http://localhost:65533/catalogue/id/Z123/ --> 404
http://localhost:65532/backend/

Before assigning to reviewer, please make sure you have

Checked things thoroughly before handing over to reviewer
Checked PR title starts with ticket number as per project conventions to help us keep track of changes
Ensured that PR includes only commits relevant to the ticket
Waited for all CI jobs to pass before requesting a review
Added/updated tests and documentation where relevant

@ahosgood , @Firdaussi @JohnHeeryTNA , I've added the new https CLIENT_BASE_URL in the ticket.


Code clean up and timeout support

Hello
We had problems with blocking processes in our project. Emails were sent using celery, and sometimes all workers become unavailable after sending bunch of emails. I tried some basic testing with requests library and it seems like mailgun got no real timeout, so if connection exists it can last for a while. I've added an option to explicitly specify timeout period using requests' timeout kwarg. It can be None or float value. If connection will not be closed after some reasonable time this option will kill it. I think this option should be helpful, and yet it is optional.
Also I've some basic PEP8 and clean up of the code and project, hope you will enjoy it.
Logging in celery:
[2014-06-13 07:23:09,034: INFO/Worker-3] Starting new HTTPS connection (1): api.mailgun.net
[2014-06-13 07:23:09,522: WARNING/Worker-3] HTTPSConnectionPool(host='api.mailgun.net', port=443): Request timed out. (timeout=0.0001)

Apologies, but this has been superseded by other work. However, please do not hesitate to volunteer future code contributions.


Extract path normalization in a separate method

Because the leading slashes path normalization seems to be duplicated, I would like to propose to extract it to a separate method.

Wrong assumption, sorry. The functionality is different and cannot be extract.


CMake: Installing test library headers

Installing the header files of test_helpers, fake- and mock-classes.
This will fix the build failure of cartographer_ros.

@wally-the-cartographer merge

Merge requested by authorized user wohe. Merge queue now has a length of 1.


checking for !isset() does not allow values of NULL to be validated…

same as other commit but for v1 of Eden
pls create a version1 branch based on 22ce4e8d386bb25e1e7e6ce9ca7e10ed91d037c6
git checkout -b version1 22ce4e8d386bb25e1e7e6ce9ca7e10ed91d037c6
and merge this and tag it as 1.0.4

nvm this wont work on inserts as isset is the only way to tell if an array index is set but if its set to null you cant tell the different between !isset() and is_null
so basically unless you create a special edge case for it, model() cant save() a field with NULL, just use updateRows() or insertRow() to set a NULL value in MySQL


flake8Changes

Did some changes to apply pep8 style recommodations. Bigger changes
in the structure of the code where avoided, so no line breaks or similar
inserted.
BTW: Great project, hope to commit in the feature

sad thing that i don't have write access to this repo anymore or i would merge the changes
¯_(ツ)_/¯

Ok, so there is no project administrator at the moment?
The project website seems to be still active, though.

maybe bring it up with @nonword

@OSHistory - if you'd like to do further work, we'll be maintaining a more active repo over here: https://github.com/OpenHistoricalMap/map-vectorizer

@jeffreyameyer Thanks, I'll commit there


Provide a callback if the DB process crashes

Thanks for the excellent project. I've been having issues where the DB process crashes (too much load, linux OOM killer etc..) and the parent java process has no way of knowing it. I do see a ManagedProcess class, which is private to DB. It would be great if

DB exposed a status() API
ConfigBuilder accepted an ExecuteResultHandler (like LoggingExecuteResultHandler) and invoked the appropriate methods onProcessComplete or onProcessFailed

@neeleshs thanks for your kind comment and interest in the project.
I would suggest that your 2 bullet points above are handled in two separate issues / PRs:
Instead of adding status() to DB (what would you want that to return?), how about just adding 2 methods named boolean isAlive() and a int exitValue() which simply delegate to the methods of the same name of the private ManagedProcess instance? This should be relatively easy an straightforward!
For the ExecuteResultHandler idea, as you saw ManagedProcess already has something like that internally, with its LoggingExecuteResultHandler .. I'm open to exposing that more, but NB that org.apache.commons.exec only accepts one of them .. I think the LoggingExecuteResultHandler should always stay, so we would have to come up with a way to call both the standard logging and also a, or perhaps if several, custom ones, if any are registered. It's certainly doable - but probably a little bit more work than the first point above.
I do like both of these ideas, and encourage you to join the project by making two (separate) contributions for both of above - I''d be happy to review them and work with you to get them merged!

@vorburger , Thanks for the comments. I'm working on the second one already - I've worked around the one-org.apache.commons.exec-ResultHandler issue by using a composite. Is it okay to use this ticket for the second bullet, and file another one for the isAlive() / exitValue() APIs? I'll create a PR when the code is ready.

@neeleshs it's fine for me if you use this ticket. Looking forward to your PR! Thanks.

@neeleshs did you ever get around to doing above and proposing PR/s? ;-)

Sorry for the delay on this. Here's the PR https://github.com/vorburger/MariaDB4j/pull/96

I'm cleaning up issue for #165 and it seems to me this one as actually fully done, long ago, via #96, agreed @duttonw and @neeleshs ? Therefore finally closing this now - please re-open with comment what is missing should I have misunderstood.


Circular dependency

I recently came across this problem when I'm writing my computed value. Consider the following example,
In some model,
import { getQueryClient } from 'contexts/StoreContext'

export const SomeModel = SomeModelBase.views((self) => ({
  computeValue(a: number, b: number): number {
    const { rootStore } = getQueryClient(self);
    // do stuff
  },
}));

In 'contexts/StoreContext':
import { createContext } from 'mst-query';
import { QueryClient } from 'mst-query';
import { RootStoreModel } from 'models/storeModels/RootStoreModel';
const env = {};

export const queryClient = new QueryClient({ RootStore: RootStoreModel });
export const { QueryClientProvider, useQueryClient, getQueryClient } =
  createContext(queryClient);

In this function, I want to get the rootStore using the getQueryClient. The queryClient is created in a separate file, which is imported to this file. The RootStoreModel is created using the createRootStore. Now, there is a circular dependency issue, since the SomeModelBase is part of RootStoreModel and SomeModelBase import from the StoreContext file to get the getQueryClient.
Of course, if you define all the models in a single file, it won't be an issue. But for large project with many models this is obviously not ideal.
I currently can get around this issue using the native getEnv like this:
export const SomeModel = SomeModelBase.views((self) => ({
  computeValue(a: number, b: number): number {
    const { rootStore } = getEnv(self).queryClient as QueryClient<IAnyModelType>;
    // do stuff
  },
}));

But doing so I lose typing. Any idea how I can solve this problem?

Yeah, this isn't great. I haven't run into this yet because we only use getQueryClient in external stores. Maybe we can solve it on the type level somehow.

I had a similiar problem today, and it's possible to type the root store with a view.  (Typing the actual query client seems more difficult.)
// RootStore.ts
export const RootStore = createRootStore({
    itemStore: types.optional(createModelStore({ items: types.map(types.late(() => ItemModel)) }), {}),
}).props({
    count: types.number
});

export interface RootStoreType extends Instance<typeof RootStore> {}

// ItemModel.ts
import type { RootStoreType } from './RootStore';

export const ItemModel = types.model('ItemModel', {
    id: types.identifier,
    description: types.string,
    created: types.Date,
    count: types.number,
}).views(self => ({
    get rootStore(): RootStoreType { // typing the return type explictly is what makes this work
        const queryClient = getEnv(self).queryClient;
        return queryClient.rootStore;
    },
    get computeValue(): number { // also need to explictly type values that derive from rootStore
        return this.rootStore.count + self.count;
    }
}));


api minor improvements

api/handler/rpc: unblock all http methods and set Host meta
api/router/static: add debug log

@asim https://github.com/micro/go-micro/pull/1526/files#diff-b3e297584c2a86f2612ea1d663b963acR103
this line changed because with non nil router i can handle post/put/patch requests with api


Better text-breaking of cells

Try to break at spaces, dots (.) and commas (,), before wrapping words.

Thanks for your pull request @AndreKoepke! :+1:
Would you mind quickly undoing the version change in the pom? I don't want to merge directly into master but into develop first.

Oh my bad. I fixed it.


variable-exists always return true

Hi, first of all thanks for this great script to implement sass in php.
Maybe it is not implemented yet but variable-exists always returns true
@if variable-exists($non_existent) {
 $non_existent:5px solid white;
}

Maybe scssphp has another way of checking this.
thanks again

Did you mean this?
@if variable-exists('non_existent') {
 $non_existent:5px solid white;
}

Thank you very much for your help,
If someone sees this (stupid) post of mine notice that the right sentence is like this: (without dollar or quotes)
@if variable-exists(non_existent) {
 $non_existent:5px solid white;
}

If it didn't work with quotes, then it's probably a bug...

I can confirm it works with and without quotes.

Thanks for confirming.


Indeed a great article

Indeed a great article

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a62fb2fc-295c-d837-7d89-0835702a75d9
Version Independent ID: f57c1676-b294-bce7-6b71-e4939371e8bb
Content: C# Tutorials
Content Source: docs/csharp/tutorials/index.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Is this a test issue or real kudos @Banani-Rath?

It is real kudos @mairaw

Ha, awesome! Thanks for letting us know @Banani-Rath!


[General] When pressing Win+G in PT the game bar opens

Microsoft PowerToys version
0.45.0
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
Pressing Win+G in settings window to set it as shortcut or open e.g. ColorPicker with this shortcut.
✔ Expected Behavior
Only PT reacts on shortcut.
❌ Actual Behavior

Other Software
No response

I have seen more issues about that hotkey and Windows still catches the hotkey even if you disable Game Bar and manage to delete all the Xbox apps.  Don't know how to fix, yet.

Some shortcuts are just reserved by the OS and there's not much we can do about it.
I don't think there's a way to fix this.

Some shortcuts are just reserved by the OS and there's not much we can do about it. I don't think there's a way to fix this.

I added the won't fix label


Custom SearchParameter

So the custom search in HAPI 3.3.0 works great, we are using it for Strings and References. However either I, or HAPI can't seem to process nested Search Parameters. Meaning when you want to search for example in a section of a composition.
So this works:
Composition.extension("http://example.com/xxx")
but this creates a really long error message in HAPI:
Composition.section.section.extension("http://example.com/yyy")
It actually breaks the DB so much that any subsequent action (PUT, POST, GET, DELETE) results in another error message. Similar to how HAPI 2.4 reacted to searches with References

Interesting.. Would you be able to provide a example SearchParameter resource demonstrating this, as well as a resource that should be matched by it?

Sorry for the late reply...
I did look into it more, and turn's out that I accessed the wrong endpoint, the server was a 2.4 instance.
However when having the following search parameter (another mistake of mine was not adding the .text at the end of the expression):
{   "resourceType": "SearchParameter",   "id": "34",   "meta": {     "versionId": "1",     "lastUpdated": "2017-12-13T10:06:18.947+01:00"   },   "title": "note as Annotation",   "status": "active",   "code": "note",   "base": [     "Composition"   ],   "type": "string",   "expression": "Composition.section.section.extension('http://example.com/fhir/AnnotationExample').text",   "xpathUsage": "normal" }
And having the following resource:
{   "fullUrl": "http://localhost:12344/baseDstu3/Composition/32",   "resource": { 	"resourceType": "Composition", 	"id": "32", 	"meta": { 	  "versionId": "1", 	  "lastUpdated": "2017-12-13T10:05:51.785+01:00", 	}, 	"status": "final", 	"type": { 	  "coding": [ 		{ 		  "system": "some sytsem", 		  "code": "some code", 		  "display": "some display" 		} 	  ] 	}, 	"date": "2017-05-23T09:15:00+02:00", 	"title": "Example Composition", 	"section": [ 	  { 		"title": "Layer 1", 		"section": [ 		  { 			"title": "Layer 2" 			"extension": [ 			  { 				"url": "http://example.com/fhir/AnnotationExample", 				"valueAnnotation": { 				  "text": "note1" 				} 			  }, 			  { 				"url": "http://example.com/fhir/AnnotationExample", 				"valueAnnotation": { 				  "text": "note2" 				} 			  } 			] 		  } 		] 	  } 	]   }
This search returns the resource:
http://localhost:12344/baseDstu3/Composition?note
But this search returns nothing:
http://localhost:12344/baseDstu3/Composition?note=note1


Needed or important Updates

This appears to a Hacktoberfest PR that violates the rules low quality and Spam PRs and has been marked as such
hacktoberfest.digitalocean.com/faq


fixed wrong error message

about issue #25
sorry not so familiar with github

Thankyou @cgwic !
@buschtoens explicitly moved ember-cli-version-checker to devDependencies.  What's the reason for moving it back?
https://github.com/hhff/ember-infinity/issues/16

@buschtoens - noticed ember-cli-htmlbars has it in dependencies:
https://github.com/ember-cli/ember-cli-htmlbars/blob/master/package.json

@hhff i've got an error in my project, when trying to install last version of ember infinity or my fork of it and get rid of it simply adding  ember-cli-version-checker.
Sorry, i may be wrong, but ember-cli-htmlbars installs ember-cli-version-checker in its own modules folder, so its still unreachable for ember-infinity

Oh yeah got it, I was saying i guess the appropriate place for it is dependencies rather than devDependencies !


FoCI Cache should not persist IdTokens or AccessTokens

Closing as dupe.
See:

https://github.com/AzureAD/ad-accounts-for-android/issues/913
https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/439
https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/440
https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/438


PAW/Restrict Administrators: MD indent correction

Description:
Privileged Access Workstations, section "Restrict Administrators from logging onto lower tier hosts"
(https://docs.microsoft.com/en-us/windows-server/identity/securing-privileged-access/privileged-access-workstations#restrict-administrators-from-logging-onto-lower-tier-hosts)
(https://bit.ly/2msYHyz in case the long URL breaks)
shows several Note sections marked as code to be copied and pasted, instead of having only the list of users/groups marked as code.
Proposed changes:
This PR aims to resolve this MarkDown mix-up issue by standardizing the indents of this section, to keep them within the same grouping.
MarkDown code fences around multi-line lists is also encouraged.
issue ticket closure or reference:
This indent issue is not reported as such, I discovered the issue after reading the ticket #1618 (Can't add DOMAIN\Administrators).

For easier overview of the changes, see the Rich Text Diff view:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/3326/files?short_path=aa9f415#diff-aa9f415f1c42d947c90089334ad0cb77

@MicrosoftGuyJFlo : Are you be available for review of this PR?

Thank you @daveba for merging this PR. Appreciated. 👍


Support uploading files with ISO-8559-1 characters

Hi, I tried to upload a json trace file with a file name containing non ascii characters on ui.perfetto.dev and it crashed:
To assist with debugging please attach or link to the trace you were viewing.

Viewed on: https://ui.perfetto.dev

TypeError: Failed to construct 'Headers': String contains non ISO-8859-1 code point.
TypeError: Failed to construct 'Headers': String contains non ISO-8859-1 code point.
    at cacheTrace (https://ui.perfetto.dev/v35.0-8019b8809/frontend_bundle.js:312215:22)
    at async TraceController.cacheCurrentTrace (https://ui.perfetto.dev/v35.0-8019b8809/frontend_bundle.js:318236:16)
    at async TraceController.loadTrace (https://ui.perfetto.dev/v35.0-8019b8809/frontend_bundle.js:317938:28)

v35.0-8019b8809 8019b8809dfbec51c8e1ca38e83c8b60da626585
UA: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

You can use 测试.json as the file name and it should trigger the issue. It would be nice if Perfetto can support files with characters other than ascii.
Thanks!

Fixed by https://r.android.com/2831350


Enabling Breaks parameters_stacks

It seems when I add the call back default ['lambda'] it then breaks the functionality to have stack json files prefill the runtime parameters. When I comment out the line I see the parameters get filled and it works correctly.
  callbacks do
    # We can't use infrastructure mode currently.
    # top level VPC not defined with a template,
    # so nested templates won't work
    require ['sfn-parameters']
    default ['parameters_stacks']
    require ['sfn-lambda']
    # Comment out the next line and the parameters call back works fine.
    # default ['lambda']
  end

Any thoughts?

Found needed to write this way:
require ['sfn-parameters', 'sfn-lambda']
default ['parameters_stacks', 'lambda']
Not really an issue. Closing out.


WIP: Update linux and mesa

The build of the kernel still fails with sed: no input files, probably in ~postPatch~ postFixup.
Because $dev/lib/modules/6.4.0-asahi/build/vmlinux does not exist.

That last line is new:
  SORTTAB vmlinux
make: Nothing to be done for 'vmlinux'.

The linux build error you are encountering is not related to the changes in this PR, but to nixpkgs https://github.com/NixOS/nixpkgs/pull/245449, the workaround https://github.com/tpwrules/nixos-apple-silicon/commit/c737e26b854af4aaab810c40b3ae6035e73d09ba has to be reverted too

I tried to use this with a commit before https://github.com/NixOS/nixpkgs/pull/245449
   #flakes.nix
    nixpkgs.url = "github:nixos/nixpkgs?rev=1021376e654cd7638633a5142fcf818598e69849";

and got:
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/k9mdaj5a9rbpkc8x9hj9mw3papraamcn-patchelf-0.15.0.drv!*'
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/447hvnlzzi9myri1iq3bijxgx6v6b592-patchelf-0.15.0.tar.bz2
source root is patchelf-0.15.0
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file patchelf-0.15.0/patchelf.spec
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
configure flags: --disable-dependency-tracking --prefix=/nix/store/i9iajqfq27668b4fm9d4gy6i13dnfvrn-patchelf-0.15.0
checking for a BSD-compatible install... /nix/store/frjyqvav0a1jky8g6sr70vdf71hjkcys-bootstrap-tools/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /nix/store/frjyqvav0a1jky8g6sr70vdf71hjkcys-bootstrap-tools/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for strip... strip
checking whether make supports the include directive... yes (GNU style)
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... none
checking whether the compiler supports GNU C++... yes
checking whether g++ accepts -g... yes
checking for g++ option to enable C++11 features... none needed
checking dependency style of g++... none
checking dependency style of gcc... none
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating tests/Makefile
config.status: creating patchelf.spec
config.status: executing depfiles commands
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: -j20 SHELL=/nix/store/frjyqvav0a1jky8g6sr70vdf71hjkcys-bootstrap-tools/bin/bash
Making all in src
make[1]: Entering directory '/build/patchelf-0.15.0/src'
g++ -DPACKAGE_NAME=\"patchelf\" -DPACKAGE_TARNAME=\"patchelf\" -DPACKAGE_VERSION=\"0.15.0\" -DPACKAGE_STRING=\"patchelf\ 0.15.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\">
g++ -Wall -std=c++17 -D_FILE_OFFSET_BITS=64     -g -O2   -o patchelf patchelf.o
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: patchelf.o: in function `__gnu_cxx::__exchange_and_add(int volatile*, int)':
/nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:66: undefined reference to `__aarch64_ldadd4_acq_rel'
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: /nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:66: undefined reference to `_>
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: /nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:66: undefined reference to `_>
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: /nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:66: undefined reference to `_>
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: patchelf.o: in function `__gnu_cxx::__atomic_add(int volatile*, int)':
/nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:71: undefined reference to `__aarch64_ldadd4_acq_rel'
/nix/store/d963146m8sjym81rn2hkvf1mp4zbj25c-binutils-2.40/bin/ld: patchelf.o:/nix/store/c7qmp1dgqf3hh4fjw74y2k662nmaslcy-xgcc-12.3.0/include/c++/12.3.0/ext/atomicity.h:71: more undefined>
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:353: patchelf] Error 1
make[1]: Leaving directory '/build/patchelf-0.15.0/src'
make: *** [Makefile:442: all-recursive] Error 1

@yu-re-ka could you share the main parts of the flake that worked for you?

The latest release contains these changes. Thank you for help identifying some of the build issues.

Upgraded to the latest on M1 Ultra and it works flawlessly. Thanks!


Faster RGB & Depth noise models

Motivation and Context
We noticed that RGB noise models are 7x times slower than whole Habitat step call.
@erikwijmans with @Skylion007  made our RGB noise models 50x faster with following PR.

One minor change is to make GreedyFollower compatible with PyRobot actions. The change makes it possible to build shortest path on the fly with noise actuations.

How Has This Been Tested
Existing HSIM noise tests, HAPI noise tests.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Removed greedy_geodesic_follower change.


Attempt to fix labeler permissions

Test.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6014

Relevant Lines:
6014

💛  - Coveralls


Toggle hours/minutes?

Hello,
Thanks so much for sharing this program! I've created a wrapper script that uses peaclock as a pomodoro timer. With the pomodoro technique, I set timers for at the most 25 minutes and therefore no hours. I was wondering if there was a way to toggle the expression of hours in the digital clock view similar to how you can toggle seconds? Toggling minutes aren't necessary for me, but I figured for general purpose that might be useful to implement as well.

Hey, thanks for using it!
An hour/minute toggle would be pretty straightforward to implement following a similar method to the seconds toggle. I'll see what I can do!

Thank you so much!
On Tue, Sep 15, 2020 at 3:40 AM Brett Robinson<EMAIL_ADDRESS>wrote:

Hey, thanks for using it!
An hour/minute toggle would be pretty straightforward to implement
following a similar method to the seconds toggle. I'll see what I can do!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/octobanana/peaclock/issues/21#issuecomment-692443638,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN2EVSLOJOUAFNVJG6NALVDSF3O25ANCNFSM4QHUU2JQ
.

I'd love to see a full Pomodoro mode. An ASCII tomato being munched away or drained of it's colour :-)


release 7.0.0

should be rebased after https://github.com/voxpupuli/puppet-redis/pull/392 got merged

@ekohl updated it

@ekohl updated it again


Add TSDatasets.__init__ regressors logic

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes
Look #327.
Related Issue
#327.
Closing issues
Closes #327.

It was decided to add all literal to select all columns in df_exog to be regressors.

Codecov Report

Merging #357 (7f02531) into breaking_change/regressors (f0c2bfe) will decrease coverage by 34.90%.
The diff coverage is 80.00%.

@@                       Coverage Diff                       @@
##           breaking_change/regressors     #357       +/-   ##
===============================================================
- Coverage                       87.37%   52.46%   -34.91%
===============================================================
  Files                              96       96
  Lines                            4697     4706        +9
===============================================================
- Hits                             4104     2469     -1635
- Misses                            593     2237     +1644

Impacted Files
Coverage Δ

etna/datasets/tsdataset.py
69.32% <80.00%> (-23.24%)
:arrow_down:

etna/commands/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

etna/commands/backtest_command.py
0.00% <0.00%> (-96.43%)
:arrow_down:

etna/commands/forecast_command.py
0.00% <0.00%> (-92.00%)
:arrow_down:

etna/commands/__main__.py
0.00% <0.00%> (-87.50%)
:arrow_down:

etna/commands/resolvers.py
0.00% <0.00%> (-80.00%)
:arrow_down:

etna/analysis/outliers/density_outliers.py
23.91% <0.00%> (-73.92%)
:arrow_down:

etna/transforms/fourier.py
27.08% <0.00%> (-72.92%)
:arrow_down:

etna/transforms/statistics.py
27.50% <0.00%> (-71.67%)
:arrow_down:

etna/transforms/filter.py
28.57% <0.00%> (-71.43%)
:arrow_down:

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c2bfe...7f02531. Read the comment docs.


Add benchmarks

Given we are trying to optimise things, it makes sense we have benchmarks to measure whether things actually got faster or slower. My best guess would be to synthesise a large number of files (say 500?), use lsp-test, and then fire a representative set of requests/changes at them (e.g. a boat load of hover because that's what emacs does, and a little bit of everything else). The result should be useful to figure out why things like forkOn give performance improvements, as per https://gitlab.haskell.org/ghc/ghc/issues/18224#note_275367. CC @bgamari, @wz1000 and https://github.com/ndmitchell/shake/pull/751

How to prove that they are capturing real workloads? Perhaps use haskell-lsp to record and replay real interactions with vs code, emacs, rather than modelling them with lsp-test

Duplicate of #242


apigee-istio provision failure: "Execution of Generate-JWK failed"

When I run:
apigee-istio provision -u <MY-USER> -p <MY-PASSWORD> -o mattkuzyk-eval -e dev
I get the following error from the tool:
WARNING: Apigee may not be provisioned properly.
Unable to verify proxy endpoint(s). Errors:

GET https://mattkuzyk-eval-test.apigee.net/istio-auth/certs: 500

When I add the --verbose flag, this appears to be the cause:
GET /istio-auth/certs HTTP/1.1

HTTP/1.1 500 Internal Server Error
{"fault":{"faultstring":"Execution of Generate-JWK failed with error: Javascript runtime exceeded limit of 200ms","detail":{"errorcode":"steps.javascript.ScriptExecutionFailed"}}}

I am on an eval account. Could that be preventing me from provisioning Apigee properly? Or is this an actual problem with Apigee itself. Not sure if this ticket belongs on this repo or with Apigee support themselves.

Hmm Could you run again with the force option? Perhaps it was just incomplete.

I think it was an Apigee processing issue. I ran it a couple times and it eventually just worked.


Schraivogel_2020.ipynb is not complete?

hello,
I try to generate the Schraivogel_2020.h5ad according to the following notebook:
https://github.com/theislab/sc-pert/blob/main/datasets/Schraivogel_2020.ipynb
It seems it is not complete:
sc.pp.neighbors(adata)
sc.tl.umap(adata)

Could you help with this problem ?
Thanks !!!

Hi bitcometz,
Thanks for your question - yes, this notebook is not yet complete. We will get back to you ASAP.


UI test improvement

Need to rework UI tests to be able to run them efficiently on CI. First, need to run tests for main screen without starting activity. If tests will still fail, tag them as @LargeTest and will be forced to always run them locally.

 Improve UI tests


Update the spec to talk about v2 sync

Some updates to the 'events' section of the spec to talk about the v2 spec API
instead of the old initialSync/events stuff.

Should we get rid of the initialSync and events api docs? is there a way to link to an old version?

This needs a few more updates, having discussed with Matthew and Mark


Add subscriber to projection

Summary of changes:

Added subscriber in the MyListViewProjection class
Implemented test in the MyListViewProjection class
Added IdSetFunction in the MyListViewRepository class
Implemented TaskEnrichment
Implemented enrichment function

Current coverage is 90.52% (diff: 86.23%)

Merging #8 into master will decrease coverage by 3.49%

@@             master         #8   diff @@
==========================================
  Files            24         25     +1
  Lines          1253       1340    +87
  Methods           0          0
  Messages          0          0
  Branches         42         46     +4
==========================================
+ Hits           1178       1213    +35
- Misses           67        118    +51
- Partials          8          9     +1

Powered by Codecov. Last update 31dec7b...4736376

@armiol please take a look at the updates.

@armiol please take a look at the updates

@armiol please take a look at the updates.

@armiol please take a look at the updates.

@armiol please take a look at the updates.

@armiol please take a look at the updates.

@armiol please take a look at the updates


Provision RDS database for People Depot dev environment

Overview
As a People Depot developer, I'd like an database provisioned on Incubator for the developer environment
Action Items

[ ] Provision PostgresQL RDS
[ ] Give dev credentials to People Depot

Resources/Instructions
https://repost.aws/knowledge-center/ecs-fargate-task-database-connection

Issue needs to be clearer

https://registry.terraform.io/providers/ademariag/postgresql/latest/docs/resources/postgresql_database


Can't generate from schema defined in TS

Describe the bug
I have defined next schema.js file:
require('@babel/register')({ extensions: ['.js', '.ts', '.tsx'] }); // Need to explicitly tell babel/register which extensions to handle until this is completed: https://github.com/babel/babel/issues/8652
require('app-module-path').addPath('./src');

const aSCh = require('server/graphql/schema').default;

module.exports = aSCh;

Schema is valid, when I run this code through node schema.js it executes ok and print's me schema. But when I try to run through graphql-codegen --config gqlcodegen.yml it fails. If I make introspection schema from  'server/graphql/schema', put it into file.json and then run codegen against json file - it works well.
Also, it works quite well when I generate schema from URL

My GraphQL schema:

# confidential

My GraphQL operations:

# Put your operations here

My codegen.yml config file:

overwrite: true
schema: genIntrospectionSchema.js
documents: null
generates:
    src/shared/types/GraphQLSchema.ts:
        plugins:
            - 'typescript'
            - 'typescript-resolvers'
        config:
            typesPrefix: GQL

Expected behavior
Schema is generated well.
Environment:

OS: Windows 10
@graphql-codegen/...: 1.7.0
NodeJS: 10.16.1

@deser any chance for a reproduction in a repo? It would really help if we'll be able to run this locally.

@deser Closing, feel free to re-open if this is still relevant. Also, please share a complete reproduction.


copy sources into container to compile

The Dockerfile was out-of-date with the source directory.
closes #27

I'm going to close this, as we've fixed the underlying issue with a different approach.


OpenEBS components deployment strategy / tracker

This will act as a common placeholder to discuss & debate about deployment, maintenance, upgrade, rollback strategies of various OpenEBS components.
We should have clarity to questions like:

Should OpenEBS components rely on systemd ?
Should OpenEBS components run as containers & managed by some tool similar to kubelet ?
Should OpenEBS components runs as containers or standalone binaries & managed by Nomad ?

Here Nomad is being referred as tool for deployment & management of OpenEBS components

What happens if container runtime require an upgrade ?
Can multiple versions of container runtime (e.g. dockerd, rkt engine) be used across hosts ?
What happens if orchestrator engine requires an upgrade ?
Can multiple versions of orchestrator engine be used across hosts ?

Alternatively:
- Can we just use tried & tested tools like Ansible:
  - https://github.com/openshift/openshift-ansible
  - https://www.ansible.com/tower
  - https://github.com/ansible-semaphore/semaphore
  - https://github.com/purpleidea/mgmt
  - https://github.com/dmsimard/ara

Alternative:
- http://operable.io/

References:

https://www.infoq.com/news/2017/02/common-kubernetes-fail-reasons
Lets find why deployment failed

The initial prototype was done with nomad till 0.3 and post 0.4, the containers are orchestrated with Kubernetes. The upgrade strategies follow the rolling-upgrade in most cases.


Protractor API methods "view code" giving page not found 404 error

Please fix this, when you click on " view code" link in the protractor API doc : http://www.protractortest.org/#/api  for any method, it is giving 404 error.

Duplicate issue #3170 w/ f149bd1e91e749a77e8ee147fdb3881584ae6851. The website does not reflect this change yet.


Supporting ESM files with .js extension

I have verified that this also works with CommonJS in .js files - it's decided by the type property in package.json.

Btw, getDefaultSearchPlaces could also use an update - see https://github.com/cosmiconfig/cosmiconfig/blob/a5a842547c13392ebb89a485b9e56d9f37e3cbd3/src/defaults.ts#L12-L32

Thanks for the PR.
it makes sense to update the default search places in the same PR. Specifically adding support for .mjs extension. Keeping in mind that it would not work in the sync version

Done :)

Apologies for the delay. I still intend to merge this PR and release the changes. I had a medical emergency earlier and have trouble with cognitive tasks currently. I will try to test these changes some time later next week. Specifically there needs to be some testing and test cases done on using lilconfig searching for config files in projects with package.json#type:module and old CJS projects. We also need to compare the output of searching for .mjs files with sync searcher and comparing the behaviour with cosmiconfig. Once we are sure that the behaviour is fairly similar, I think it will be safe to merge this.
Thank you for your patience.

Hi,
no worries, health comes first!

Hi @marekdedic, thank you for your patience. I finally got a chance to look into this feature and it turns out more complex than the initial impression. I have opened another PR #46 with all the documented changes that I will continue to work until it feels like it is ready to be merged. I am going to close this PR. Having said that I do not want you to think that your time was wasted. Thanks to your PR this feature will be soon added to lilconfig and I would like to add your credentials in the commit message and release notes if that is okay with you, let me know. I would appreciate your feedback on #46.
Many thanks for taking your time and pushing this forward!

Hi, thanks for the heads up and further work on this :) I'll be looking forward to #46


Ignore cases related to external_fts

Plan Seq scan on gp_segment_configuration would be replaced by Function Scan on gp_get_segment_configuration when external_fts is on.
Inconsistence between CIs will cause such cases to fail. Ignore these as workaround.
Authored-by: Zhang Mingli<EMAIL_ADDRESS>

closes: #246

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

I think regress has a feature of automatically matches multiple expected file and chose the one generates the shortest diff, we can have two rpt_joins.out named rpt_joins_1.out and rpt_joins_2.out, one for local testing one for CI running. regress could choose between them automatically (this is how we fix xml.out in #206). now that we already fixed log and results uploading in #240 we can directly download CI output and put it as rpt_joins_2.out and everything should works fine again.

I think regress has a feature of automatically matches multiple expected file and choose the one generating the shortest diff, we can have two rpt_joins.out named rpt_joins_1.out and rpt_joins_2.out, one for external_fts=on one for =off.

You are right, and we have a xxx_external_fts.out technique to handle that.
We have a internal discussion, the conclusion are:
xxx_external_fts.out could resolve this, but we only have 2 lines diff and have to copy 2000 lines for a new file.
The root cause is inconsistent GUCs between Github and Release CI, a external_fts CI will be added for Github later.
This is a workaround, we will take such cases back after that CI enabled.

https://github.com/cloudberrydb/cloudberrydb/issues/246


Release 2850 & 3655 to prod-stable

Codecov Report

Merging #36 (1a6598c) into prod-stable (9772e38) will decrease coverage by 0.75%.
The diff coverage is 90.08%.

@@               Coverage Diff               @@
##           prod-stable      #36      +/-   ##
===============================================
- Coverage        96.54%   95.78%   -0.76%
===============================================
  Files               29       32       +3
  Lines              318      427     +109
  Branches            71      110      +39
===============================================
+ Hits               307      409     +102
- Misses              11       15       +4
- Partials             0        3       +3

Impacted Files
Coverage Δ

...components/SubscriptionTable/SubscriptionTable.tsx
86.74% <86.74%> (ø)

src/components/ProductsTable/ProductsTable.tsx
97.80% <91.66%> (+5.11%)
:arrow_up:

...c/components/StatusCountCards/StatusCountCards.tsx
100.00% <100.00%> (ø)

src/hooks/useFeatureFlag.ts
100.00% <100.00%> (ø)

src/hooks/useProducts.ts
92.85% <100.00%> (+0.54%)
:arrow_up:

src/pages/DetailsPage/DetailsPage.tsx
100.00% <100.00%> (ø)

...riptionInventoryPage/SubscriptionInventoryPage.tsx
100.00% <100.00%> (ø)

src/utilities/factories/subscription.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9772e38...1a6598c. Read the comment docs.


Use mediafile instead of beets.mediafile. Fix #22.

The last release of beets is broken on Python 3.8 which is why the tests might fail if you are using those versions.
I tested on Python 3.7 and all were OK.
I also tested on Python 3.9 with beets master and all were OK.
Will close #22 and close #10.

Could you please make a release for this fix?

I manually patched my ./python/site-packages/beetsplug/extrafiles.py file with the diff that was merged here:
https://github.com/Holzhaus/beets-extrafiles/pull/23/files/7e4f0d374d454b31042ba5413f68610f03e75566

@Holzhaus?


await asyncio.sleep(1) hangs

Issue Report Checklist

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[X] Could not reproduce inside jupyter qtconsole (if console-related)
[X] Tried basic troubleshooting (if a bug/error)

[X] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[X] Tried the other applicable steps from the Troubleshooting Guide

[X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
In a fresh install of spyder, awaiting coroutines with asyncio.sleep in them seem to hang.
What steps reproduce the problem?
Open a new IPython console in Spyder, and the following will hang:
In [1]: import asyncio

In [2]: await asyncio.sleep(1)

What is the expected output? What do you see instead?
In the ipython console on the command line, outside of spyder, this works:
(py37_forge) C:\Users>ipython
Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 23:18:50) [MSC v.1900 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.5.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import asyncio

In [2]: await asyncio.sleep(1)

In [3]:

Also in the jupyter qtconsole, this does work fine:
Jupyter QtConsole 4.5.1
Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 23:18:50) [MSC v.1900 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.5.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import asyncio

In [2]: await asyncio.sleep(1)

In [3]:

Versions

Spyder version: 3.3.4
Python version: 3.7.3 64-bit
Qt version: 5.9.7
PyQt version: 5.9.2
Operating System name/version: Windows 10

Dependencies

IPython >=4.0     :  7.5.0 (OK)
cython >=0.21     :  None (NOK)
jedi >=0.9.0      :  0.13.3 (OK)
matplotlib >=2.0.0:  3.1.0 (OK)
nbconvert >=4.0   :  5.5.0 (OK)
numpy >=1.7       :  1.16.3 (OK)
pandas >=0.13.1   :  0.24.2 (OK)
pycodestyle >=2.3 :  2.5.0 (OK)
pyflakes >=0.6.0  :  2.1.1 (OK)
pygments >=2.0    :  2.4.2 (OK)
pylint >=0.25     :  2.3.1 (OK)
qtconsole >=4.2.0 :  4.5.1 (OK)
rope >=0.9.4      :  0.14.0 (OK)
sphinx >=0.6.6    :  2.1.2 (OK)
sympy >=0.7.3     :  1.4 (OK)

Thanks for reporting. We'll take a look at this in Spyder 4.

Any plan for this ticket? IPython supports rather well "await", but a non-functioning asyncio.sleep in Spyder is a real blocker for learning/debugging asyncio. It would be great to have this issue fixed :)

I can't reproduce with the latest 5.x

Thanks for checking this @impact27! I can't reproduce it either on Linux. Probably this was fixed thanks to the new versions of jupyter-client (7.x) and ipykernel (6.x), which have much better support for asyncio.
Since the next Spyder version (5.2.2, to be released next week) will depend on them, I'm going to close this issue.

For what it's worth, the asyncio.sleep(1) will eventually run through, but it takes a solid 15min


Rewrite for Mopidy 3

This PR is almost a complete rewrite. It updates the code for Mopidy v3, as well as updating the frontend code for modern standards.
The Python side of things has been updated to conform to modern Mopidy extension standards. Most things in setup.py have been moved into a setup.cfg file, for example. Most extensions put their static web files into a directory named static, so this was also adjusted. The extension init code uses pathlib, and a redundant method override has been cleaned up.
On the frontend side, Angular has been completely removed. Handlebars is a much more lightweight solution for templating, so this is now used. Bootstrap has been upgraded to v5, which allows us to remove jQuery. The Angular Bootstrap integration is obviously also no longer necessary. Also, Mopidy.js is no longer bundled with Mopidy, so that has been vendored.
Hopefully everything should Just Work(tm) going forward. If you don't feel like maintaining this extension moving forward, it would be great if you could instead follow the request of the Mopidy maintainers to migrate this extension to the Mopidy organisation:
https://github.com/dz0ny/mopidy-api-explorer/pull/5#issuecomment-519294211

This looks really good to me. The style is a bit different but that will just take time to get used to.
I did notice that if you skip to a section/method it scrolls you just a little too far and the heading for the link you just clicked is obscured by the navbar. Without being able to see the heading I wasn't totally sure it had taken taken me to the right place. You can of course scroll up one, or just trust it's done the right thing and then it's not a problem. This is with Firefox 84.0.1 (64-bit) for Ubuntu.

Thanks for the feedback, I appreciate it!
I had noticed the scrolling issue, but it was literally 2am when I submitted this PR and I needed sleep :P I'll see what I can do about it at some point today.

Thanks for the feedback, I appreciate it!
I had noticed the scrolling issue, but it was literally 2am when I submitted this PR and I needed sleep :P I'll see what I can do about it at some point today.

@kingosticks I've just pushed an update and would appreciate it if you could give it a try. It should hopefully resolve the scrolling issue you highlighted.

@kingosticks I've just pushed an update and would appreciate it if you could give it a try. It should hopefully resolve the scrolling issue you highlighted.

Thanks for encouraging me to take a look at this btw, I didn't expect to learn something new about CSS and was expecting to have to fiddle with some weird JS code.

Thanks for encouraging me to take a look at this btw, I didn't expect to learn something new about CSS and was expecting to have to fiddle with some weird JS code.

That works perfectly, awesome!

That works perfectly, awesome!


coc#status() frozen at indexing packages

I have my statusline set to show me the output of coc#status(). After the Julia language server starts, at some point coc#status() says Julia Language Server Indexing packages..., and stays frozen there.
I decide to leave it overnight to see if it will finish, but it hasn't. I suspect the language server isn't actually doing anything, because htop reports 0.0 in the CPU% column for the language server process.
Is this a bug in coc#status?

Not a bug of coc#status. The progress message is came from Julia Language Server, tested with VSCode + Julia LS:
Received request 'window/workDoneProgress/create - (7eb45c41-fd70-4e34-adf5-55397a222856)'.
Params: {
    "token": "e6b544d9-3d17-4d9f-bdb0-44e1568e8072"
}

Received notification '$/progress'.
Params: {
    "token": "e6b544d9-3d17-4d9f-bdb0-44e1568e8072",
    "value": {
        "kind": "begin",
        "title": "Julia Language Server",
        "message": "Indexing packages..."
    }
}

Received notification '$/progress'.
Params: {
    "token": "e6b544d9-3d17-4d9f-bdb0-44e1568e8072",
    "value": {
        "kind": "end"
    }
}

As you see, client has received begin -> end progress message, and client hides the status message.
But in coc + coc-julia:
Received request 'window/workDoneProgress/create - (e7fb66ef-03e2-46e3-9476-736fb904d2d7)'.
Params: {
    "token": "fc23c7c5-f4d8-46ab-abbd-b49897cf11a3"
}

Received notification '$/progress'.
Params: {
    "token": "fc23c7c5-f4d8-46ab-abbd-b49897cf11a3",
    "value": {
        "kind": "begin",
        "title": "Julia Language Server",
        "message": "Indexing packages..."
    }
}

There is no end progress message, the client doesn't hide the status line message.
I'll continue to trace this.

Strange. Thanks for looking into it.

Try coc-julia v0.4.0

I'm seeing this issue again. Can we reopen this, or would you like me to open a new issue?

@carlocab you can open a new issue with more info, such as your coc-julia version, coc version, how to reproduce etc.


Incorrect port in error message

Bug Description
The error message says port 3307, but I have specified port 5432.
The output from sql proxy
Listening on <IP_ADDRESS>:5432
accepted connection from <IP_ADDRESS>:58436
failed to connect to instance: Dial error: failed to dial (connection name = "xxx"): dial tcp x.x.x.x:3307: i/o timeout

Example code (or command)
From my deployment
      - image: gcr.io/cloud-sql-connectors/cloud-sql-proxy:2.3.0
        name: cloud-sql-proxy
        args:
          - "--private-ip"
          - "--structured-logs"
          - "--port=5432"
          - "--credentials-file=/secrets/credentials.json"
          - "xxx"
        securityContext:
          runAsNonRoot: true
        volumeMounts:
          - name: cloudsql-instance-credentials
            mountPath: /secrets/
            readOnly: true

Stacktrace
No response
Steps to reproduce?

Deploy it as a sidecar configured with port 5432, pointing at a server it cannot reach.
Connect to it.
Wait for the timeout
...

Environment
See the example code for the environment
Additional Details
No response

Hi @runephilosof-karnovgroup, thanks for raising an issue on the Cloud SQL Proxy 😄
When you run the proxy and specify the port value (5432 in your case) that is setting the port for the local connection.  (as seen in below diagram)

The Cloud SQL Proxy that you run is the proxy client, it has a server-side companion that automatically runs and is configured alongside a Cloud SQL instance when it is created. The server-side component listens on port 3307 (TCP standard port in diagram above) of your Cloud SQL instance’s IP address for incoming connections from the client.
This is what you are seeing in the error message. The connection to your instance's IP address on port 3307 is timing out. I will discuss with our team and see if this error message can be improved to make this more clear. We are also looking to add a more detailed version of the diagram to our README in hopes that helps as well.
Diagram is from How the Cloud SQL Auth Proxy works

@runephilosof-karnovgroup I have change this issue to track adding a similar "How the Cloud SQL Proxy Works" section from our official Google Cloud docs to our README with the diagram above. I think a lot of people would benefit from this.
Thanks for getting this jump started!
Have a great day - Jack

Hi @jackwotherspoon - hope it's ok to add here; the migration guide states different ports to 3307 (from the "How the Cloud SQL Proxy Works" section).

# v2
# Using automatic database port selection (MySQL 3306, Postgres 5432, SQL Server 1433)
./cloud-sql-proxy <INSTANCE_CONNECTION_NAME>

Does this need updated, or am I miss understanding what it's saying?

Also https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/51cc2c6b4d5b369cb99f1a18fe679610b4f184e8/cmd/root.go#L151 adds to the confusion.
Since 3307 is actually sometimes used for MySQL for the local connection proxy client if you do not specify a port and it detects MySQL (if I understand it correctly).
So maybe the server side proxy component should be using a port number that does not resemble any of the ports normally used by the databases (are the proxy components using ssh, then maybe just 22 or a port number resembling ssh, for instance 2222).


Render multiple login options ("logical" message type) in the correct order

Created by: @dusan-kovacik-profiq Mar 04 2022 at 09:02 CET
Last updated: Mar 24 2022 at 14:29 CET
ClickUp ID: IK-2370
Currently we ignore the order of the options. We only order the action options and OIDC options within their group, but in general we currently always put the login form to the top which is followed by a list of actions and the list of OIDC providers is on the bottom. User should be able to reorganize the order of all components as he/she wants.
This leads to a question how it should look like when e.g. the "Create an account" action would be on the top of the screen, then it should be followed by the Google button, then there would be the login form and the Facebook button would be on the bottom of the list. The biggest question is where to put the "Or continue with" label and horizontal line dividers (I will probably need to ask  about this). And there might be a lot of different combinations.

Commented by: @PouyanHz Mar 07 2022 at 08:47 CET
@dusan-kovacik-profiq We can go through this & observe options & etc.


Rebased Tomdz's short message fix

Reopening #12 which fixes a real bug in the gelf-rb gem.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think I prefer this PR https://github.com/graylog-labs/gelf-rb/pull/50 closing in favor of that one


[WIP] Export UI

Pull Request Test Coverage Report for Build 951108726

15 of 69 (21.74%)  changed or added relevant lines in 17 files are covered.
38 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-5.5%) to 67.546%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ui/modules/downloadJson.ts
0
1
0.0%

src/utilities/sendSettingsToUi.ts
0
3
0.0%

src/utilities/getJson.ts
0
4
0.0%

src/utilities/prepareExport.ts
0
10
0.0%

src/utilities/groupByName.ts
2
15
13.33%

src/tokenTransformer/styleDictionaryTransformer.ts
0
23
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/utilities/getJson.ts
8
0%

src/utilities/settings.ts
30
0%

Totals

Change from base Build 951027973:
-5.5%

Covered Lines:
333

Relevant Lines:
488

💛  - Coveralls


repeated properties in object ctx

I think removing repeated properties in ctx is better.
console.log(ctx.header === ctx.headers)
console.log(ctx.header === ctx.request.header)
console.log(ctx.response.req === ctx.req)
console.log(ctx.response.res === ctx.res)
console.log(ctx.request.req === ctx.req)
console.log(ctx.request.res === ctx.res)
console.log(ctx.request.URL === ctx.URL)
etc

I think this is a better solution.
const { header, URL } = ctx.request;

Aliases  is convenient.

aliases confuse new users.
ctx.body -> ctx.request.body ? ctx.response.body ?
ctx.header -> ctx.accept.header ? ctx.request.header ? ctx.response.header ?
ctx.request -> ctx.app ? ctx.reponse.app ? ctx.request.app ?
etc

so many repeated properties.
some are identical but some are not.
repeated names confuse usages of methods and properties.
why not provide a pure Koa?

I think @rabbitmeow is right. Having repeated properties here and there seem to be OK... but I often asked myself why the naming went down that road.
Fiddling around with ctx.body and ctx.request.body is not straight forward. Having a simple rule like ctx.request.<something from request> and ctx.response.<something from response> is easy to remember and looks good.
My 2 cents

So in practice, async ({ request, response }) => { ... } ...

 I print it out just for looking for the usages of methods and properties. But it has too many repeated properties such that I cannot distinguish which one is what I want.
If I wanna use the aliases, I have got to print out "ctx.properties === ctx.higherProperties.properties" . So I would type the second one rather than the first one.
I think this type of secondary packaging should not be used in a basic framework.

－1


New router

I've been working on a new router for the past month.
It is stable enough to be merged into master branch of cgra_pnr repo.

LGTM!  -steve
also: merry christmas


Doctrine ORM doesn't works if Doctrine DBAL isn't installed

If doctrine ORM is activated without doctrine DBAL, the digex:schema:create doesn't works because it needs doctrine DBAL

works now with composer
doctrine-dbal is uploaded every time


Feature: Configure commit types

standard-version allows for configuring types ie
[
    { "type": "feat", "section": "Features" },
    { "type": "fix", "section": "Bug Fixes" },
    { "type": "chore", "hidden": true },
    { "type": "docs", "hidden": true },
    { "type": "style", "hidden": true },
    { "type": "refactor", "hidden": true },
    { "type": "perf", "hidden": true },
    { "type": "test", "hidden": true }
]

Some projects may prefer to configure how the commit types are used to generate change logs.
This is a lot to have all in the projects.json or even the workspace.json
Perhaps a slimer interface could be used?
Or perhaps the configuration could be read from .versionrc or maybe even commitlint.config.js if type configurations exist there?

This is a must-have! I like the idea of having a .versionrc, that's something we could benefit from in the future.

Hey I love that idea! What is the status for it?

@christophediprima No progress has been made here, definitely need time or contributor help.

@edbzn I got the message and probably have a look soon! :)


breaking(SyncList): keep old OnChange parameters to not break projects

we've had 10 years worth of projects hook into SyncLists for changes with (oldItem, newItem).
narrowing this down to one parameter that is sometimes oldItem, sometimes newItem is going to create too many headaches.

You'll have to obsolete the current and fix all the tests to work for both.
I strongly disagree with this PR.

Better to put Callback back in and not break everyone who has already adapted to OnChange and the new actions


Toothpick is not compatible with AutoFactory

Hi,
I'm getting familiar with Tootpick but I've encountered a problem using it with AutoFactory. Somehow generated factory is not valid.
Sample project is on my repo: https://github.com/AleksanderMielczarek/ToothpickAutoFactoryIssue
Error:
error: Field com.github.aleksandermielczarek.toothpickautofactoryissue.MainActivity#itemFactory is not a valid ItemFactory.
    protected ItemFactory itemFactory;

Activity:
public class MainActivity extends AppCompatActivity {

    @Inject
    protected ItemFactory itemFactory;

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        Scope scope = Toothpick.openScope(this);
        super.onCreate(savedInstanceState);
        Toothpick.inject(this, scope);
    }

    @Override
    protected void onDestroy() {
        Toothpick.closeScope(this);
        super.onDestroy();
    }
}

Item:
@AutoFactory
public class Item {
}

Gradle:
apply plugin: 'com.android.application'
apply plugin: 'android-apt'

android {
    compileSdkVersion 25
    buildToolsVersion "25.0.2"
    defaultConfig {
        applicationId "com.github.aleksandermielczarek.toothpickautofactoryissue"
        minSdkVersion 16
        targetSdkVersion 25
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
        exclude group: 'com.android.support', module: 'support-annotations'
    })
    compile 'com.android.support:appcompat-v7:25.1.0'
    testCompile 'junit:junit:4.12'
    provided 'com.google.auto.factory:auto-factory:1.0-beta3'
    apt 'com.google.auto.factory:auto-factory:1.0-beta3'
    compile 'com.github.stephanenicolas.toothpick:toothpick-runtime:1.0.3'
    apt 'com.github.stephanenicolas.toothpick:toothpick-compiler:1.0.3'
}

Best regards
Aleksander Mielczarek

We never used AutoFactory. I am not sure we have the resources and the
interest to dig this issue. But we would be happy to get a PR merged if you
can fix the issue.
2017-01-08 6:06 GMT-08:00 Aleksander Mielczarek<EMAIL_ADDRESS>
Hi,
I'm getting familiar with Tootpick but I've encountered a problem using it
with AutoFactory. Somehow generated factory is not valid.
Sample project is on my repo: https://github.com/AleksanderMielczarek/
ToothpickAutoFactoryIssue
Error:
error: Field com.github.aleksandermielczarek.toothpickautofactoryissue.MainActivity#itemFactory is not a valid ItemFactory.
protected ItemFactory itemFactory;
Activity:
public class MainActivity extends AppCompatActivity {
@Inject
protected ItemFactory itemFactory;

@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
    Scope scope = Toothpick.openScope(this);
    super.onCreate(savedInstanceState);
    Toothpick.inject(this, scope);
}

@Override
protected void onDestroy() {
    Toothpick.closeScope(this);
    super.onDestroy();
}

}
Item:
@AutoFactorypublic class Item {
}
Gradle:
apply plugin: 'com.android.application'
apply plugin: 'android-apt'
android {
compileSdkVersion 25
buildToolsVersion "25.0.2"
defaultConfig {
applicationId "com.github.aleksandermielczarek.toothpickautofactoryissue"
minSdkVersion 16
targetSdkVersion 25
versionCode 1
versionName "1.0"
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
}
}
}
dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
exclude group: 'com.android.support', module: 'support-annotations'
})
compile 'com.android.support:appcompat-v7:25.1.0'
testCompile 'junit:junit:4.12'
provided 'com.google.auto.factory:auto-factory:1.0-beta3'
apt 'com.google.auto.factory:auto-factory:1.0-beta3'
compile 'com.github.stephanenicolas.toothpick:toothpick-runtime:1.0.3'
apt 'com.github.stephanenicolas.toothpick:toothpick-compiler:1.0.3'
}
Best regards
Aleksander Mielczarek
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stephanenicolas/toothpick/issues/187, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABv33Zbu0O3GE6_L17iEWFfmElU6GWCtks5rQO2BgaJpZM4LdspZ
.

@AleksanderMielczarek if you add:
    provided 'org.glassfish:javax.annotation:3.0.1'

to your build.gradle, and remove TP, then the build is working.
But, if you re-enable TP annotation processor, then it still fails.
This looks much more like a AutoFactory issue. There are no clear instructions for gradle, I don't see anything we can do. We close the issue.

@AleksanderMielczarek I have tried the example project removing Toothpick and it still fails.
It complains about:

import javax.annotation.Generated;

Could you make it work without TP and recheck so we are sure that the problem is coming from there?

@stephanenicolas Gradle instruction for AutoValue: http://ryanharter.com/blog/2016/04/08/autovalue-deep-dive/.
AutoFactory is generating following code, which is compatible with JSR-330. Dagger 2 can inject generated factories.
import javax.annotation.Generated;
import javax.inject.Inject;
@Generated("com.google.auto.factory.processor.AutoFactoryProcessor")
public final class ItemFactory {
  @Inject
  public ItemFactory() {
  }
  public Item create() {
    return new Item();
  }
}

@dlemures It's working when factory isn't injected but created manually.
public class MainActivity extends AppCompatActivity {

    protected ItemFactory itemFactory = new ItemFactory();

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        Scope scope = Toothpick.openScope(this);
        super.onCreate(savedInstanceState);
        Toothpick.inject(this, scope);
    }

    @Override
    protected void onDestroy() {
        Toothpick.closeScope(this);
        super.onDestroy();
    }
}

Probably related to: https://github.com/stephanenicolas/toothpick/issues/158

Yeah, the issue here is that for registries, and for TP in general, we expect only one round of annotations... We need to make sure this is better done in TP2. I will create an issue for this.

A simple fix could actually be to add a flag to generate the registries on the last round of annotation processing. It's bad, but expecting a single round of annotation processing is actually worse as it breaks libs like auto factory and auto value.


Add support for Wireshark TLS packet decryption to aws_tls.c

This change supports writing the CLIENT_RANDOM symmetric session keys to SSLKEYLOGFILE.
SSLKEYLOGFILE is supported by Chrome, Firefox, and Openssl. This file allows Wireshark to decrypt TLS traffic.
You can find instructions on how to enable this feature on Windows here: https://jimshaver.net/2015/02/11/decrypting-tls-browser-traffic-with-wireshark-the-easy-way/
This feature is enabled only when MBEDTLS_DEBUG_C is enabled.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

This will be reworked when: https://github.com/aws/amazon-freertos/pull/394 goes through.


Download JARs in run_codenarc.py script

Now that we no longer rely on requests to download JAR files, we don't need a
separate script to do it either.

@nre-ableton As you may have guessed, I'm interested in reviewing this PR 😄

@ablbot rebase

Please rebase/squash and revert the unnecessary changes in parse_args. Then I'll do another review, thanks!

Done. I had to make a few cleanups to satisfy pylint, though.

@ala-ableton I decided to drop my cleanup commit Cleanup: don't pass sys.argv to parse_args since it was more trouble than it was worth (namely, it would require reworking a bunch of tests). Please have another look!

Re-ping @ala-ableton

@ala-ableton Yes, indeed. :sweat_smile: Fixed!

@ablbot rebase


[KYUUBI #2745] [Subtask] DorisSQLEngine - GetTables Operation

Why are the changes needed?

close https://github.com/apache/incubator-kyuubi/issues/2745#issue-1248428722
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #2776 (ac923a1) into master (49352b5) will increase coverage by 1.23%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##             master    #2776      +/-   ##
============================================
+ Coverage     61.79%   63.02%   +1.23%
+ Complexity      385      219     -166
============================================
  Files           433      481      +48
  Lines         20345    21442    +1097
  Branches       2760     2848      +88
============================================
+ Hits          12572    13514     +942
- Misses         6541     6648     +107
- Partials       1232     1280      +48

Impacted Files
Coverage Δ

...pache/kyuubi/engine/jdbc/dialect/JdbcDialect.scala
43.75% <ø> (ø)

...yuubi/operation/meta/ResultSetSchemaConstant.scala
0.00% <ø> (ø)

...yuubi/engine/jdbc/operation/ExecuteStatement.scala
91.48% <50.00%> (+3.98%)
:arrow_up:

...ache/kyuubi/engine/jdbc/dialect/DorisDialect.scala
58.82% <68.42%> (+15.07%)
:arrow_up:

...e/kyuubi/engine/jdbc/operation/JdbcOperation.scala
48.97% <90.90%> (+12.13%)
:arrow_up:

...i/engine/jdbc/operation/JdbcOperationManager.scala
37.83% <100.00%> (+18.60%)
:arrow_up:

...main/scala/org/apache/kyuubi/util/ClassUtils.scala
71.42% <0.00%> (-16.08%)
:arrow_down:

...g/apache/kyuubi/session/KyuubiSessionManager.scala
85.36% <0.00%> (-9.70%)
:arrow_down:

...thentication/KyuubiHttpAuthenticationFactory.scala
80.00% <0.00%> (-8.00%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
76.92% <0.00%> (-7.70%)
:arrow_down:

... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49352b5...ac923a1. Read the comment docs.

please help me review it. @yaooqinn @pan3793 @ulysses-you

The ci failed because of https://github.com/apache/incubator-kyuubi/pull/2816

The doris container exception don't exist, there is a failure about LADP.

thanks, merging to master


Media Pipe Pose Estimation + Visualization

Description
Implemented Media Pipe pose estimation. Given an image path, will return a PoseSkeleton object with landmarks of each individual in the image.
Related Issue(s)
https://github.com/orgs/sensein/projects/45/views/3?pane=issue&itemId=82951656&issue=sensein|senselab|173
Motivation and Context
This is the initial structure for pose estimation which is a valuable signal for behavior analysis. I will expand to more models and functionality, and with that, this will be more generalized.
How Has This Been Tested?
I tested with different kinds of images and attempts to access invalid properties of the PoseSkeleton object. Unit tests for the new functions + also manually tested for proper visualization.
Screenshots (if appropriate):

Types of changes
Created PoseSkeleton object that contains pose information for individuals in an image. Currently supports MediaPipe pose estimation + visualization functionality.
Checklist:

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My code follows the code style of this project.

Thank you, @brukew, for the updates. I have a few suggestions and points to address based on our previous discussions:

Reorganize Code Structure
Please re-organize your code by separating data structures from functionalities (what we refer to as tasks in Senselab).

The skeleton should be treated as a data structure. It should define the skeleton and optionally include utilities for visualization. Alternatively, visualization can be handled as a standalone task.
Pose estimation should be a task (generating the skeleton as an output). All human pose estimation models (e.g., MediaPipe, AlphaPose) should conform to a consistent data structure.
To encourage generalizability, I suggest integrating a second pose estimation tool, such as YOLO due to its simplicity.

Model Inclusion
The current approach of including a model within the source code (e.g., src/senselab/video/tasks/pose_estimation/models/pose_landmarker.task) makes the package unnecessarily heavy. Instead, please ensure models are downloaded as needed. You can take inspiration from this example.

Documentation
Please add a dedicated documentation page:

Explain human pose estimation as a task, its purpose, and supported models.
For instance, you can reference this documentation for MediaPipe.
Feel free to draw inspiration from the existing audio task documentation (though some sections are incomplete).

Tutorial
Create a Jupyter Notebook tutorial to demonstrate:

How to use the interface.
What functionalities are available.
Add this under a video folder in the tutorial/ directory.

Failing Tests
I noticed two tests are failing:

test_valid_image_single_person

AssertionError: "Input and output image shapes should match."

test_visualization_single_person

ValueError: "Input image must contain three-channel BGR data."
Please double-check these tests to ensure they pass.

Nice, thank you for the feedback @fabiocat93. I will address your comments and ask questions as I go.

hi @brukew , did you have any time to work further on this?

hey @fabiocat93, slowed down on development towards the end of the semester. I will continue this month.