Provide compiler warnings/errors when using method as callback and this context won't be preserved

Search Terms
bind, this, callback
Suggestion
Emit a warning or error when a method meets these conditions:

The method is implemented using standard method syntax.
The method needs this context to be preserved (uses the this keyword).
The method is passed as a callback to another function.

Use Cases
The standard syntax for defining methods is clean, concise, familiar, and (arguably) preferable to everyone. However, methods defined using this common syntax will not preserve the context of this when passed as a callback to another function. This mistake is easy to make, yet perfectly legal!
class Example {
    private _privateVar: any = "Hello World!";

    /**
     * Method syntax is the standard syntax we all know and love.
     * The problem is `this` context won't be preserved if used as a callback.
     */
    public methodSyntax(): any {
        return this._privateVar;
    }

    /**
     * Instance syntax solves the `this` problem, but it comes with other drawbacks/trade offs.
     */
    public instanceSyntax = () => {
        return this._privateVar;
    }
}

function doSomething(func: Function): any {
  return func();
}

let obj = new Example();
let result1 = doSomething(obj.methodSyntax); // undefined (OOPS!)
let result2 = doSomething(() => obj.methodSyntax()); // "Hello World!"
let result3 = doSomething(obj.methodSyntax.bind(obj)); // "Hello World!"
let result4 = doSomething(obj.instanceSyntax); // "Hello World!"

Examples
Using the above example, I'd love to see the compiler offer the suggestions made in this page. Something like this
let obj = new Example();

// Error: Method using `this` context should not be used as callback.
//  Consider:
//  - Refactoring the method as an instance method.
//  - Surrounding the method argument with a local anonymous function.
//  - Using the `bind` function.
let result1 = doSomething(obj.methodSyntax);

let result2 = doSomething(() => obj.methodSyntax()); // OK
let result3 = doSomething(obj.methodSyntax.bind(obj)); // OK
let result4 = doSomething(obj.instanceSyntax); // OK

Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript / JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. new expression-level syntax)

Duplicate of #10288


Fix: Pass api key in headers and detect html error

Summary:

If the API key is passed in the URL, send it in headers
Detech if the response is HTML and return an error
Fix test cases

How to test:

Start your own score API server
Change score API to return HTML
Change test files in test folder, for example vp.ts with the local score API server

Just noticed that this issue may be fixed with https://github.com/snapshot-labs/snapshot.js/pull/957


Chunk download

Hi,
I need to download files from the sftp in chunks and avoid load all stream into the host memory
, my case am reading many huge files 5GB each, if i will wait until get the whole file then will consume the memory and the application will break,
Is there is anyway to get the file in chunks and start process chunk by chunk

This is very probably duplicate of #690 - cross index

@MohammadBMelhem Follow #690 please.

Thanks 😊


make linter detect if enteredView is being used

 Issue by sigmundch
Originally opened as dart-lang/sdk#19629

maybe we can use the analyzer to find declarations of enteredView?

 Comment by sigmundch

Added this to the 1.6 milestone.
Removed Priority-Medium label.
Added Priority-Low label.

 Comment by sigmundch

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

 Comment by sigmundch

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

 Comment by sigmundch

Added PolymerMilestone-Next label.

 Comment by sigmundch

Removed Polymer-Milestone-Next label.

 Comment by sigmundch

Added AssumedStale label.


Consumer failing to claim a partition when messages are published after subscription starts

I am experimenting the problem of a consumer sometimes failing to claim a partition. It seems this almost always happens when a consumer subscribes to a previously non existent topic and later some messages are published to this topic.
The below test program demonstrates this behavior with the current sarama-cluster master.
https://gist.github.com/elakito/8c33dd318def85f6544a3ba799e34c36
I am not sure if this is an issue or there is some property that needs to be set to avoid this problem.
Any advice will be appreciated.
regards, aki

always happens when a consumer subscribes to a previously non existent topic and later some messages are published to this topic
sorry, I don't quite understand this. at the moment the current master doesn't support subscriptions to topics that don't exist (yet). there is a PR to fix this in the future and periodically check for new topics

@dim thanks. Your description answers my question and explains the behavior that I observed. I will be interested in the mentioned PR if that is already in some repo/branch.
regards, aki

sorry, it was mentioned in this issue https://github.com/bsm/sarama-cluster/issues/48. I did some pre-work  but I haven't had time to continue yet


Persist Expanded Rows on reload in Powergrid Please!

This feature was implemented in Datagrid, can we also have it in Powergrid?.. Is this difficult?

Hi wvitpr
Yes this is planned:
https://support.servoy.com/browse/SVY-15197
Thanks,
Sean


[CI] Fix sponsors action

Ref: https://github.com/inventree/InvenTree/pull/5794
Intent is to make a PR to update README.md whenever the project gets a new sponsor

@SchrodingersGat as far as I can see the thing fails because it tries to push to master directly and our branch protection rules forbid that. I might be overcautious but do we want anything pushing to master before a maintainer role-holding person at least skimms through it?
Seems like a security risk - considering we deploy master regularly automated to the demo server and development users just run master.

I can fix it probably pretty fast; I just want to discuss the merits of having it run like this. A flow like with Crowdin makes IMO more sense.

I would vote for creating a PR against master if there are changes on sponsors.

I agree it sho


auto complete for pseudo-selectors?

Hi, I've been testing brackets out and I like the code completion for CSS, but am wondering if it does auto-complete for pesudo selectors? I can type them manually but it's helpful to not have to type out "first-of-type" etc. Is there an extension for this? Thanks.

Hi @petetnt  I would like to work on this. Do I add this to the core? Could you provide some guidance on how to tackle this problem? Thank you!

The CSS code hinting is handled in https://github.com/adobe/brackets/blob/master/src/extensions/default/CSSCodeHints/main.js
The list of autocomplete values come from https://github.com/adobe/brackets/blob/master/src/extensions/default/CSSCodeHints/CSSProperties.json
I think @sprintr and @MarcelGerber have been working with CSSCodeHints the most lately, so they might be able to give out more specific pointers 👍

CSSCodeHints is for property:value; pattern, so pseudo-selectors may not be a good fit there. May want to split pseudo-classes & pseudo-elements off into a new extension similar to how HTMLEntityCodeHints is separate from HTMLCodeHints.

@redmunds you are correct, sounds good to me.

Not sure whether I am late already and @arthur801031 has already started working on this.
I have already done the same as part of Brackets in Dreamweaver and should be forward porting it to Brackets in release 1.9. This release will cover a whole bunch of things in terms of code hints which will be contributions from Abode back to Brackets. FYR , please check the following screenshots which depicts pseudo-selectors/elements and at-rules.

What I would request is to contribute towards things like less variable hinting, saas variable hinting in a project. Brackets is lacking CSS pre-processor workflows in it's current form, if we can invest time and get in some pieces in this area it would be great!

Hi @swmitra @petetnt  I just started today, so no worries. I will find another bug/feature to work on. Thank you very much for your time! :)

@arthur801031 I was late indeed in that case 😄  It's great to see the spirit of all the Brackets contributors, and this is what will keep Brackets growing bigger and better.  A big thumbs up for your last PR ( switching focus between panes ) 👍 , keep them coming.
There are a lot of missing things which all of us could focus for the next release. I will try to compile a section in the release card for 1.9 to mention some hot spots or contribution areas which potentially could take Brackets to the next level.

@arthur801031, how's this coming? In the example above, are you looking at the element as a way to reduce the available pseudo-classes? For instance, if you are defining something like i.test:, would the recommendations remove the link-specific pseudo classes? I'd love to help on this if it's still needed.

Implemented with #13295.
Closing.


If operators.hdf5 file doesn't exist, calculate partials

The saved elastic operator didn't exist so I had to go into command/japan_command.json to turn off loading. Can we just fall back to creating the elastic operator if doesn't exist? Make a big warning message that says "The command file requested loading the elastic operators but the operators cannot be found at FILEPATH_HERE. Recomputing the elastic operators instead." I might even add a similar warning for situations where the elastic operators are reloaded just so users aren't surprised.

Close with https://github.com/brendanjmeade/celeri/commit/906c7fa7ed0fa991c33cd93f88e3c1653825c1f8


the type of response

why do you use *SliceCmd as the response of  HMGet, but do not use *StringSliceCmd.

Because for non-existent keys Redis returns (nil) response which you may need to distinguish from empty string response.


Find cancels the selection

VS Code Version:  1.81.1
OS Version: Windows

Find cancels the current selection. I hate it :-)
Steps to Reproduce:

Open a document
Select a block of text
Press CTRL-F
Write a word to search that is present in the document
The original selection is cancelled. The searched word is selected.

Including a small video: https://github.com/microsoft/vscode/assets/821344/fb0bb0d0-ebb0-4835-9c22-36ea8a7b801c
If you do the same in Visual Studio, the "old" selection will be saved and become a "lighter colored" selection, like with VS Code when you use the Find in Selection button.
The problem here is that the Find in Selection button is on the RIGHT of the textbox for finding text, so the "natural" way of working (left-to-right) is to fill the textbox for finding the text and then clicking on the Find in Selection, but if you try to do it in VS Code, the selection will be cancelled when you digit a single character in the textbox.

interesting, if you set "editor.find.autoFindInSelection": "multiline", this doesn't occur. And that might be what you would prefer anyway.


Add Chromium browser for JavaScript testing to use ChromeHeadless

This adds the chromium-browser package which is used by karma to execute tests in a headless Chrome browser.
Further testing of this image will follow tomorrows .... :zzz:

We might want to consider individual images for Chrome and Firefox or bundle this all together ....
Suggestions? @tboerger @patrickjahns

I'm not sure if we should really put all that together, I would prefer a separate image which gets built from this one.

I would prefer a separate image which gets built from this one.

new repo - or branch in here?
if branch what is the requirement in terms of naming the branch so that it gets publiched? THX

New repository, and the downstream plugin that triggers builds on the new repos, please.

:octocat:


Setting maxHeight and maxWidth on imagePicker increases the selected file size dramatically.

I noticed that the file sizes of images that I upload to firebase storage from my flutter application are way bigger than I expected. I figured out that when I set maxHeight and maxWidth property on the imagePicker plugin, the file size increases to more than what it should be.
Here are some sample image I tried
raw image: 836x675 px and 48,269 bytes
uploaded with maxHeight and maxWidth set to 720: 836x675 px and 144,559 bytes
Okay, so the plugin's maxWidth property isn't working either, but I want to focus on the size increase here.

This here might fix the problem https://github.com/flutter/flutter/issues/40831

I believe that this is fixed via https://github.com/flutter/plugins/pull/2070.
If you're still seeing this issue I encourage you to file a new bug with repro instructions and we'll take a look. Thanks again for filing.


Can't install 2.0.25 or 2.0.13 on Win10 - keeps requesting .NET

Win10 build 19042.1348
Trying to install, get message "To run this app, you must install .NET"
Installed Desktop x86's .NET 5.0.12 Runtime.  Still got msg.  Rebooted.  Still got msg.
Installed Console apps x86.  Still got msg.
What gives?

Try using the x64 version. It worked for me

Win10 build 19042.1348 Trying to install, get message "To run this app, you must install .NET" Installed Desktop x86's .NET 5.0.12 Runtime. Still got msg. Rebooted. Still got msg. Installed Console apps x86. Still got msg.
What gives?

Use the -portable package; it includes all the .NET dependencies so you don't have to actually install them.


Black holes (nostrils)

Dear Patrik,
First of all, amazing project! Thanks so much for sharing!
I am having this issue with 95% of the faces files that I have.
Please let me know what I could be doing wrong.
I know this was already asked here : Black line in isomap extraction #4
std::tie(mesh, rendering_params) = eos::fitting::fit_shape_and_pose(*morphable_model_with_expressions, landmarks, landmark_mapper, frame.cols, frame.rows, edge_topology, ibug_contour, model_contour, 5, eos::cpp17::nullopt, 30.0f);
// Extract the texture from the frame using given mesh and camera parameters:
const Eigen::Matrix<float, 3, 4> affine_from_ortho = eos::fitting::get_3x4_affine_camera_matrix(rendering_params, frame.cols, frame.rows);
isomap = eos::render::extract_texture(mesh, affine_from_ortho, eos::core::from_mat(frame), true);
isomap = eos::render::detail::interpolate_black_line(isomap); <-- doesn't work for the nostrils.

Thank you!!!

Hi,
Thanks!
This looks like it's working as expected. These triangles ("patches of skin") are occluded, they're not in view. There is no data (texture) there in your image of that region. What would you expect to be there?
If you want texture data for occluded regions, you'll have to decide what strategy you want of how to fill it (blend/interpolate, mirror, use per-vertex colour from the model, etc.).

Just thought : isomap = eos::render::detail::interpolate_black_line(isomap); would fill those gaps.
"  What would you expect to be there? "
Ok, sorry for the dumb question, thank you for your time.

No worries!
The eos::render::detail::interpolate_black_line(...) function actually only "fixed" a very specific problem with a vertical line occurring in the centre of the texture map. However as indicated in #4, this was fixed in 6875e08b6678046e9c04fc5860383f39d22edd4f. Actually, since the problem was properly fixed, I could've removed the eos::render::detail::interpolate_black_line(...) function a while ago. It can definitely be removed now and I will do so - I opened #298 to track that. Thank you!

Thank you for the explanation.
May I ask if there is any function in your library, that could fill the occluded patches of skin ?
Thank you once again.

Thank you for the explanation.
May I ask if there is any function in your library, that could fill the occluded patches of skin ?
Thank you once again.

There isn't currently any ready-made function that fills occluded patches.


Working with the entity

@wrathagom I have followed this video https://www.youtube.com/watch?v=tXCYQ4BTjD0&feature=youtu.be for tarining the bot. I have added the entites.  The issue is - for example consider this dialog "I want to book an appoinment on monday at 4pm" in this statement there are two slots one for date and time. If user only says he want to book appoinment on monday without time then ideally the bot should ask the text prompt which i configured in the slots( what time works for you please say AM or PM after time). But it does not ask always. sometimes it fail to ask the question in the text prompt. Why it not always ask the questions for the slot added? this is happening for all slots which is added. I'm attaching the Gdrive video link with this post. Please refer the video. What i'm doing wrong here? Please list the misconfiguration if you have found any. Thank you.
https://drive.google.com/file/d/1lvmEwt-oSGFQumbPrqz_EnSkuwgXXjg4/view
One more issue:
Our application is booking appoinment through the bot. From the screenshot you can see that i'm configured slots for day and time. So when users asks "I want to book appoinment" then bot will ask for the day when user user replies one of the week days(monday, tuesday...) it will accpect. After the day it will ask for the time then sometimes the times  like (4am, 4 am, 4AM, 4 AM) not recognizing but it will accepect the 4 pm or 4PM. What will be the possible issue?
Another issue regarding the time entity is when i'm add "I want to book appointment on monday at 4am" it does not automatically highlight the time entity and also i can't highlight the time entity. This is the reason may be it does not recoganize the time entity(4am, 4 am, 4 AM) when users says. It working for PM only issue in AM. I have attached another video showing that it not highlighting the time enitity.
Please help us to identify the issue.
https://drive.google.com/file/d/1rUsfSdO4WSoPpskmX-W9GSM7EEtK0iK0/view?usp=sharing

Thank you.

@wrathagom @dcalvom it seems @pnija is experiencing two separate issues. The first (one word replies to slot values) requires intent modifiers and the second is a bug I've also seen--where no entities are displayed in the drop-down when the user selects a desired entity from their sample utterance.

Sorry @pnija for the complete oversight here. I can't remember if I was able to help you with this one at all on Gitter or not. Did you get past your issues?


Authenticator code not working

Hi,
I have just noticed that using an authenticator code to log in does not work. It shows a message like:"wrong username and password". Nonsense message because the username and password are checked earlier. Anyway, there is no problems login into the account from the website
Tell me if you need more info.

Hey, it's probably related to #582.
We haven't had the chance to update it, yet.
We'll let you know for sure.
Thanks!

Same issue, let's keep the discussion in #582


Capabilities are little endian

Possible alternatives include requiring little endian for Zcheri_purecap, allowing bi-endian implementations to use an implementation defined endianness, and rules-lawyering the unprivileged ISA byte invariance requirement to only apply to CLEN-bit regions with the tag cleared.  This is the only option that is consistent with the architectural capability representation and how we handle variable XLEN.
Resolves #69.

Or we just take the same approach as XLEN and say you only get CHERI state/instructions/etc in the native endianness, which is little-endian in the base privileged ISA if supported (given that's the well-defined reset state for any system that's not exclusively big-endian). It's not like big-endian RISC-V is a thing anyone actually cares about... (see the lack of any toolchain support beyond some very basic defines of riscv*be in GCC).

I think it seems rasonable to go with the reset endianness - otherwise big endian systems will get confusing (if anyone actually builds one....)

I agree, reset makes more sense and we can reuse the XLEN behavior.

It looks like when this was merged, GitHub automatically replaced the (correct because it was edited) commit message with the (wrong) PR title and text of the original post in the PR. For #131 the commit messages I wrote were lost entirely.
Is this an intentional workflow decision or something that we're otherwise stuck with? I spent a fair amount of effort on atomic commits and meaningful commit messages for several of the other PRs and would rather it not be wasted.

The default is squash and merge in this repository, but if there is more than one commit I make sure to use the rebase and merge option (unless it's a messy history with fixup commits). My workaround so far has generally been to sync the PR message with the commit message so that the GitHub default remains sensible.


fix empty my_id on phone_number login

If set phone to token my_id check prevent from  working.
_set_bot_token wasn't used. I renamed it to a better name _auth_with_token
improved login logic a bit. But I think is better to remove console input requests and provide the way to use it from outside as necessary.

Thank you for the PR.
I've pushed a commit dropping direct support for userbots. Since i can see a lot of bugs introduced in your PR and by the client for further use. Instead you can try implementing your own login logic by starting the client with client.start(login=False) and then handle the authorization updates.


chore(CHANGELOG): update to v0.13.0-alpha.6

Changes

FIX: set $parent when creating zeebe:CalledElement element (#99)
DEPS: update to<EMAIL_ADDRESS>DEPS: update to<EMAIL_ADDRESS>

Required by https://github.com/camunda/camunda-modeler/pull/2861

I forgot to include the properties panel dependencies.

I forgot to include the properties panel dependencies.

Done. ✅

Related to https://github.com/bpmn-io/internal-docs/issues/498#issuecomment-1078867702, does it make sense to mirror the crucial changes incorporated via the dependency bumps in the CHANGELOG?
Assuming here that who reads this wants to get an executive summary on everything that is inside, and not dive into individual component changelogs.

Assuming here that who reads this wants to get an executive summary on everything that is inside, and not dive into individual component changelogs.

Done. Can you have a look?

Looks great :lipstick:

CI is still getting its 💩 together.


Docker Container Fails to Run

I tried to run the docker container after a successful build and ran into this error:
Traceback (most recent call last):
  File "/app/blockchain.py", line 12, in <module>
    class Blockchain:
  File "/app/blockchain.py", line 135, in Blockchain
    def last_block(self) -> Dict[str: Any]:
  File "/usr/local/lib/python3.6/typing.py", line 682, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.6/typing.py", line 1106, in __getitem__
    params = tuple(_type_check(p, msg) for p in params)
  File "/usr/local/lib/python3.6/typing.py", line 1106, in <genexpr>
    params = tuple(_type_check(p, msg) for p in params)
  File "/usr/local/lib/python3.6/typing.py", line 374, in _type_check
    raise TypeError(msg + " Got %.100r." % (arg,))
TypeError: Parameters to generic types must be types. Got slice(<class 'str'>, typing.Any, None).

Please help. TIA

I'm seeing the same error. It is triggered by latest merged PR.

Like the traceback suggests, the error is caused by a typo in line 135. Instead of
def last_block(self) -> Dict[str: Any]:
this line should be
def last_block(self) -> Dict[str, Any]:.
Also, for this fix to work, you have to change the Dockerfile from pulling the GitHub repo to using your local code. So simply comment out this line:
&& git clone https://github.com/dvf/blockchain.git /app \
and insert
COPY blockchain.py Pipfile /app/
before the RUN block.
Then you should be able to build and run the Dockerfile as usual.

Thanks a ton :) It worked like charm!

This could have been fixed already. There is a PR for that issue: https://github.com/dvf/blockchain/pull/30


Fix wrong response_type parsed when missing response_mode

What does this PR do?
The original code incorrectly read configured default respone_mode value into a variable holding response_type value. This causes OAuth2 requests without response_mode passed via URL query parameter to fail, because response_type value will then be filled with illegal value.
Which issue(s) does this PR fix?
There's no issue at this point. I was testing integration with Memos and found this coding typo. Their SSO implementation does not pass response_mode, thus resulting in error.
If this PR affects any API reference documentation, please share the updated endpoint references
There's no API change.

@lakhansamani Please kindly review this PR and release a new version soon, thanks.

Thanks @JokerQyou for the contribution

@JokerQyou released as part of 1.1.52 (https://github.com/authorizerdev/authorizer/releases/tag/1.1.52)


Investigate reducing the size of MastNode to 64 bytes

Originally posted by @bobbinth in https://github.com/0xPolygonMiden/miden-vm/pull/1466#discussion_r1744348232

Using vectors here increases the size of this struct from 40 bytes to 88 bytes. This also means that the size of MastNode enum grows to 96 bytes. Our goal should be to reduce the size of the MastNode to 64 bytes or fewer - but we can probably do it in a separate PR.

This might involve introducing the DecoratorSpan idea mentioned in https://github.com/0xPolygonMiden/miden-vm/issues/1122#issuecomment-2274957299.

@bobbinth @plafer In this comment , there is a proposal to use a Box type.
Benefits of using Box:

A Box would only keep a pointer to the data on the stack (4 bytes or 8 bytes).
It seems it would also result in more intuitive code for developers work on this part of code in the future.
Maintain flexibility of having a Vector of Ids be independent of how the Decorators are actually stored.

Downsides of using Box:

A little more space on the heap (probably negligible).
Some performance overhead to copy the 16 or 24 bytes to heap. (probably negligible since this will happen only once)

If I'm not missing some use case, it would seem using Box would be even more efficient in reducing the size of the struct. What do you think?

Since then we learned that we want neither Box nor Vec - basically nothing that comes with an allocation. The current code (which uses Vec) is slowing down significantly some tests in the compiler (see #1497), and that turned out to be due to the massive amount of allocations/deallocations when using debug symbols.
@bitwalker proposes using an arena in there, but I haven't gotten back to it in a while, and it's still unclear to me the direction we want to go in.

I think there are a couple of things here and we can probably approach them incrementally:

First, we want to get rid of using vectors to hold decorator data in MAST nodes (e.g., before_enter and after_exit fields in the JoinNode etc. and decorators field in the BasicBlockNode). Allocating these vectors has a significant impact on performance (especially during testing). To get rid of this, the simplest approach is probably to introduce DecoratorSpan discussed in various comments.
Then, we could pick off some "low-hanging fruit" for reducing the size of MastNode - e.g., using Box<[OpBatch]> instead of Vec<OpBatch> in the BasicBlockNode. This probably won't get us all the way to 64 bytes per node.
Then, we can try to use a more sophisticated approach (e.g., something like arena) to reduce the memory footprint even further.

In may mind, the first 2 items will probably get us 80% of what we need pretty quickly, and the arena approach could be more of a long-term goal. So, I'd go for these two but maybe in different PRs.

Ok. Makes sense. I can give (1) a try


chore: typing fc

Codecov Report
Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 6.38%. Comparing base (e3753db) to head (e6fbfca).
Report is 1 commits behind head on main.

Files
Patch %
Lines

midealocal/devices/fc/message.py
0.00%
17 Missing :warning:

midealocal/devices/fc/__init__.py
0.00%
10 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #74      +/-   ##
========================================
- Coverage   6.38%   6.38%   -0.01%
========================================
  Files         77      77
  Lines       6605    6608       +3
========================================
  Hits         422     422
- Misses      6183    6186       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


improvement of histrogram estimator

LGTM, thanks @johannaSommer - I'll make some minor tweaks during the merge.


34 refactor scripts

Refactoring scripts so that we have

matching
assigning primary (all primary trips together)

assigning primary feasible zones
assigning primary facilities

assigning secondary feasible zones / facilities (TODO)

@Hussein-Mahfouz: I spotted an issue when I was trying to run script 3, there is an error ImportError: cannot import name 'fill_missing_zones', could you double check if you have refactored the name of the functions in acbm.assigning?

I successfully ran all the scripts now and this looks great following the refactor so looks good to me to merge.


Mentorship: Update Google Form Links

TEST=manual
Buttons on page lead to the right page.
Change-Id: Ie500c088e8d4c14f5ad3043eb4d5d141f73b55d9

Code Review comments can be found at https://gerrithub.io/q/Ie500c088e8d4c14f5ad3043eb4d5d141f73b55d9


When card doesn't change x position onClick event is called

When I swipe only in y position and card doesn't change its x position, onClick event is called on this card.

Try setting the boolean in your listeners to either false or true. This should prevent the events after it happening.

Jonas, can you give me more details, because I don't understand you solution. Is this proper solution or workaround for bug in library?

I don't even know if it will work,
but in your OnTouchListener for the cards there is a return false or return true just see if it helps you out by inverting the value you have now.

I solve this by checking translation
    swipeFlingAdapterView.setOnItemClickListener(new SwipeFlingAdapterView.OnItemClickListener() {
        @Override
        public void onItemClicked(int itemPosition, Object dataObject) {
            if(swipeFlingAdapterView.getSelectedView().getTranslationY() == 0) {
                showProduct();
            };
        }
    });

IMO anyway it's bug in library and should be repaired there.


Add the built-in container registry as an optional feature

Add the built-in container registry as an optional feature

See #114


Is the 'Discovering Service Endpoints' section needed?

Section 6.1 - Discovering Service Endpoints provides an example of "A website may provide service endpoint discovery by embedding JSON-LD in their top-most HTML web page (e.g. at https://example.com/)".
Given that issue #25 was closed due to there not being any actual use cases for it, I propose we remove this section as well.
(If later, use cases for service endpoint discovery come up, we can revisit this topic.)

Discussed on Sep 30, 2021 call.
No objections to removing section (can be layered later as a separate spec).

Addressed by PR #78


feat: port Combinatorics.SimpleGraph.Finsubgraph

[ ] depends on: #4002

@Ruben-VandeVelde I think this is good to go now!

Thanks!

bors merge

Conflicts with #4002 due to the nearby Mathlib.lean change

This PR/issue depends on:

leanprover-community/mathlib4#4002
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#4002
By Dependent Issues (🤖). Happy coding!


Monero syncer: Remove refresh

These might have done more harm than good.
The wallets are anyway generated from a manged height already.

Codecov Report

Merging #238 (0ad5445) into main (b253b3f) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #238   +/-   ##
=====================================
  Coverage   15.2%   15.2%
=====================================
  Files         27      27
  Lines       6172    6166    -6
=====================================
  Hits         939     939
+ Misses      5233    5227    -6

Impacted Files
Coverage Δ

src/syncerd/monero_syncer.rs
0.0% <ø> (ø)

src/lib.rs
9.4% <0.0%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b253b3f...0ad5445. Read the comment docs.


I didnt get activation link

Subject: I didnt get activation link
Description:
Registered
Results:
I should receive activation link
Backend version: develop-b3cee755
Frontend version: develop-b3cee755
User Agent: Mozilla/5.0 (Linux; Android 11; SM-A505FN) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.92 Mobile Safari/537.36
Page: https://couchers.org/login
User:

dupe #3520


Added option for http response headers

Use case was: https://github.com/indexzero/http-server/issues/281
Feel free to close if doesn't seem relevant…
Fixes #174, fixes #334, fixes #644

Hello, I just comment to say it seems totally relevant to me, I would really appreciate if it got merged.

This is super useful. Someone please get it merged and do a publish. I could use this right now

Yeah I think I could use this over what I submitted for #288 :)

Subscribed, I think this would allow me to set AMP-Access-Control-Allow-Source-Origin to develop https://www.ampproject.org projects.

👍 This would also useful for setting/testing Content Security Policy headings.

@indexzero any plan on merging this?

@indexzero gentle reminder. it will be super helpful if you could merge this PR. Also let me know if any changes are required. I'll be happy to help 😄

Only 5 years have passed...

minimist allows the parsing of 1. Objects and 2. Multiple options of the same name.
Thus, this would work with minimal code addition:
http-server --headers.AMP-Access-Control-Allow-Source-Origin<EMAIL_ADDRESS>--headers.Cookie 'test=1'

The argv.headers would be equal to:
{
  'AMP-Access-Control-Allow-Source-Origin'<EMAIL_ADDRESS>  'Cookie': 'test=1'
}

Techically, that's the only thing to pass to the options object, as the httpServer already handles the (undocumented) headers option.

@oncletom you're totally right about minimist supporting object options like that, however, I do like the PR's implementation, which makes an array, a little better because it passes the headers as a single string, which seems more natural to me.

I’m game on providing the requested changes if @hedefalk somewhat cannot manage to do so.

@oncletom would you like to make the requested changes? Otherwise I can take this over

such a simple addition, surprised it's missing, wanted to add Cross-Origin-Resource-Policy to https://developer.chrome.com/blog/enabling-shared-array-buffer/#cross-origin-isolation

Would love to see this added.

is custom response headers supported?

would this allow custom headers for files matching a regex?
-H *.js.gz="Content-Type=text/javascript"

@thornjad would it be possible to get this landed still?

Is this the sign for us to choose another package ?

@josenicomaia @BelgianNoise the best way to help any OSS project is to contribute. In this case, testing this PR, confirming that it works, explaining what you tested, etc. would go along way to helping the core contributors know if this patch is what's needed or if more work remains.
@cwtuan @JulianIsrael if you're curious about specific capabilities, please also take the time to test this branch, find out for yourselves, and provide confirmation here that it does support those things.
Community projects take a community.

@BigBlueHat thanks for confirming that you're still interested in this project. Will you be ale to merge an release https://github.com/http-party/http-server/pull/811 ? (sorry for cross-posting, but that issue seems to be abandoned by maintainers)

To answer @cwtuan that's literally the point of the PR so I don't get the question
To answer @JulianIsrael nope it wouldn't there is nothing in this PR that would do that, but feel free to make a superseeding PR with the feature
As it was established, this PR is still missing a test case and documentation
Nice to know the project is still alive though

helping the core contributors know if this patch is what's needed or if more work remains

a PR being submitted usually implies that the submitter just wants to merge the changes supplied (unless explicitly noted otherwise). Open Source maintainers aren't supposed to be HR managers who sign off on things unknowingly?
as far as the requested changes, here's what I'd add to docs/http-server.1
.TP
.BI \-H ", " \-\-header " " \fIHEADER\fR
Add extra header to all responses, eg. "X-Frame-Options: DENY".

(right after cors):
--- man.1	2022-08-28 17:38:33.244404883 -0400
+++ man-before	2022-08-28 17:36:54.973302056 -0400
@@ -63,10 +63,6 @@
 Optionally provide CORS headers list separated by commas.

 .TP
-.BI \-\-H ", " \-\-header " " \fIHEADER\fR
-Add extra header to all responses, eg. "X-Frame-Options: DENY".
-
-.TP
 .BI \-o " " [\fIPATH\fR]
 Open default browser window after starting the server.
 Optionally provide a URL path to open the browser window to.

and to README.md:
--- README.md	2022-08-28 17:40:21.619418290 -0400
+++ README.md-after	2022-08-28 17:41:32.794771710 -0400
@@ -53,6 +53,7 @@
 |`-e` or `--ext`  |Default file extension if none supplied |`html` |
 |`-s` or `--silent` |Suppress log messages from output  | |
 |`--cors` |Enable CORS via the `Access-Control-Allow-Origin` header  | |
+|`-H` or `--header` |Add extra header to all responses, eg. `X-Frame-Options: DENY`| |
 |`-o [path]` |Open browser window after starting the server. Optionally provide a URL path to open. e.g.: -o /other/dir/ | |
 |`-c` |Set cache time (in seconds) for cache-control max-age header, e.g. `-c10` for 10 seconds. To disable caching, use `-c-1`.|`3600` |
 |`-U` or `--utc` |Use UTC time format in log messages.| |

here are tests:
diff --git a/test/http-server-test.js b/test/http-server-test.js
index d4555b9..d3c7f13 100644
--- a/test/http-server-test.js
+++ b/test/http-server-test.js
@@ -154,5 +154,48 @@ vows.describe('http-server').addBatch({
         assert.ok(res.headers['access-control-allow-headers'].split(/\s*,\s*/g).indexOf('X-Test') >= 0, 204);
       }
     }
+  },
+  'When extra header are provided': {
+    topic: function () {
+      var server = httpServer.createServer({
+        root: root,
+        extraHeaders: ['X-Header:extra']
+      });
+      server.listen(8083);
+      this.callback(null, server);
+    },
+    'and request is issued to server with extra header': {
+      topic: function () {
+        request({
+          method: 'GET',
+          uri: 'http://<IP_ADDRESS>:8083/'
+        }, this.callback);
+      },
+      'response should contain extra header': function (err, res) {
+        assert.equal(res.headers['x-header'], 'extra');
+      }
+    }
+  },
+  'When multiple extra headers are provided': {
+    topic: function () {
+      var server = httpServer.createServer({
+        root: root,
+        extraHeaders: ['X-Header-One:extra-one', 'X-Header-Two:extra-two']
+      });
+      server.listen(8084);
+      this.callback(null, server);
+    },
+    'and request is issued to server with extra headers': {
+      topic: function () {
+        request({
+          method: 'GET',
+          uri: 'http://<IP_ADDRESS>:8084/'
+        }, this.callback);
+      },
+      'response should contain extra headers': function (err, res) {
+        assert.equal(res.headers['x-header-one'], 'extra-one');
+        assert.equal(res.headers['x-header-two'], 'extra-two');
+      }
+    }
   }
 }).export(module);

a PR being submitted usually implies that the submitter just wants to merge the changes supplied (unless explicitly noted otherwise). Open Source maintainers aren't supposed to be HR managers who sign off on things unknowingly?

This PR addresses an open issue, it's not a drive-by PR. The discussion about what the PR should do goes in that issue, and the discussion in the PR itself should be able whether the code addresses the linked issue, and whether it requires changes before it can be merged or not. A PR being submitted does not imply someone "just wants to merge the changes", it implies they took on the task of fixing an issue and they are now submitting the work they believe does that, requiring review and sign-off from the people who actually maintain the project, as it's their responsibility to accept contributions or not.
Also, in terms of comments with diffs: if these are changes to files already in the PR, just use the PR commenting system instead (i.e. find the file and line(s) in the PR you flagged as needing more work, click the comment button next to th(os)e line number(s) and leave a comment with "code suggestion" that the PR owner can then automatically accept into the PR) or if it's a completely new change to a file not already in the PR, hit up their branch, click "edit" on that file, let github do its forking magic if necessary, and then file your own PR against their PR. This can all be done without ever leaving github.

Is there any update for this feature? This seems to be very useful and surprisingly to see it is missing and takes so long to get merged.

Was surprised there was no way to add custom headers to the response of http-server. I need it in order to add "Cross-Origin-Opener-Policy: same-origin" and "Cross-Origin-Embedder-Policy: require-corp" in order to get SharedArrayBuffer to work.

Was surprised there was no way to add custom headers to the response of http-server. I need it in order to add "Cross-Origin-Opener-Policy: same-origin" and "Cross-Origin-Embedder-Policy: require-corp" in order to get SharedArrayBuffer to work.

Exactly the same thing! There's no support yet?

@iliakan if you are still struggling. Just merge the changes of the two files yourself.
ATTENTION: not update safe – but anyway if just want to go on :)
Here is the process I used for PNPM:

find where the bin file is located on your system which http-server
to get your basepath edit bin file nano [your-path]
add this echo to print out your basepath

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
echo $basedir

open the directory with your editor

code [your-basepath]../pnpm-global/5/node_modules/http-server/bin/http-server

copy the changes from files

Install https://www.npmjs.com/package/patch-package and run it on the http-server

For those still waiting on custom headers, I have been rewriting http-server in Rust with support for custom headers: http-server-rs

alternatively, most of my projects just use a copy-past server.js file based on express that just sets the entire project dir as a static dir and redirects / to index.html so that "things just work(tm)".
import express from "express";

const PORT = process.env.PORT ?? 8000;
process.env.PORT = PORT;

const HOSTNAME = process.env.HOSTNAME ?? `localhost`;
process.env.HOSTNAME = HOSTNAME;

const npm = process.platform === `win32` ? `npm.cmd` : `npm`;

// Set up the core server
const app = express();
app.use((req, res, next) => {
  res.setHeader("Surrogate-Control", "no-store");
  res.setHeader(
    "Cache-Control",
    "no-store, no-cache, must-revalidate, proxy-revalidate"
  );
  res.setHeader("Expires", "0");
  next();
});
app.set("etag", false);
app.use((req, res, next) => {
  if (!process.argv.includes(`--test`)) {
    console.log(`[${new Date().toISOString()}] ${req.url}`);
  }
  next();
});

// static routes
app.get(`/`, (req, res) => res.redirect(`/index.html`));
app.use(`/`, express.static(`.`));
app.use((req, res) => res.status(404).send(`${req.url} not found`));

// Run the server
app.listen(PORT, () => {
  const msg = `=   Server running on http://${HOSTNAME}:${PORT}   =`;
  const line = `=`.repeat(msg.length);
  const mid = `=${` `.repeat(msg.length - 2)}=`;
  console.log([``, line, mid, msg, mid, line, ``].join(`\n`));
});

Done, node server anywhere you would have used http-server.

Also https://www.npmjs.com/package/serve is a good replacement for this package.

Closing in favor of #887 / #885

Probably better to leave this open until one of those actually lands, given how little has happened in this project. I'll be happy to see either of those land, but so far the track record has been "that's not happening" =)

Newer PRs are easier to validate and merge, so this seems like reasonable decision to me. This thread you replied on is also a PR; issue #884 tracks this. I recently (today) became a maintainer which hopefully means I'll do a fantastic job at it and bring life back into the PRs - time will tell!

I see! In that case, good luck, good to hear someone's back in the maintainer seat.

Anyone still following this may be interested to participate in discussion #899. Current plan is to include custom headers in the next release, and a PR adding this has been merged.

 Thank you so much! Been using a fork, now I can finally use official again.


Release version 0.0.16

Fixes zero length segment bifurcation angle issue and neuron
plotting in jupyter notebook bug.

Current coverage is 100.00%

Merging #287 into master will not affect coverage as of 5724220

@@            master    #287   diff @@
======================================
  Files           42      42
  Stmts         1830    1830
  Branches         0       0
  Methods
======================================
  Hit           1830    1830
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 5724220

Powered by Codecov. Updated on successful CI builds.


Incompatible with json_serializable >= 3.5.0

Hi, I having issues when running pub get after adding json_serilizable.
This is my output:
` Because json_serializable >=3.5.0 depends on json_annotation >=3.1.0 <3.2.0 and basic_utils >=2.4.4 depends on json_annotation >=2.0.0 <=3.0.1, json_serializable >=3.5.0 is incompatible with basic_utils >=2.4.4.
And because vin_decoder 0.1.2 depends on basic_utils ^2.5.4, json_serializable >=3.5.0 is incompatible with vin_decoder 0.1.2.
And because no versions of vin_decoder match >0.1.2 <0.2.0 and validators 2.0.1 depends on vin_decoder ^0.1.2, json_serializable >=3.5.0 is incompatible with validators 2.0.1.
Because flutter_form_builder >=3.11.6 <4.0.0-alpha.1 depends on validators ^2.0.1 and no versions of validators match >2.0.1 <3.0.0, flutter_form_builder >=3.11.6 <4.0.0-alpha.1 requires validators 2.0.1.
Thus, json_serializable >=3.5.0 is incompatible with flutter_form_builder >=3.11.6 <4.0.0-alpha.1. `
flutter version: 1.22.0-10.0.pre.433 • channel master

flutter version: 1.22.0-10.0.pre.433 • channel master

Please use dependency_overrides to make sure your dependencies play nice with each other.

Thanks please close issue.


breaking(change): This is a continuation of deploying a breaking change.

Updated circleci image. Added .nvmrc for future.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Crash on iOS when running testSendData.js

We have a heisenbug. :(

Got distracted for today because he had to fix a bug in CI about how it was handling merging (it was trying to rebase)

This is a known bug in the iOS framework. It doesn't appear to have a clear work around. Somewhere iOS in the MPCF sets nill in a hash table and you can't do that so it causes a crash. This has apparently being around since 7.

No longer an issue on ios9.


Public studies you are not a contributor on do not display their owner

Example: https://lichess.org/study/P33p6LIH
The information needed can be found in site.analysis.study.members.owner(). All members could be displayed.
This might be an unintentional lichess bug

Fixed by Lichess.


Improve the Documentation

Make the Documentation more clearer to make it easily explainable for the people coming newly to Open Source

Hi @N-45div please assign it to me...
i'll love to contribute to this issue.

Hi @N-45div,
done with the documentation improvement..
committed the changes made...have a look & kindly merge the pull request.


DBZ-4912 Redis Sink - multi sharded support

@gunnarmorling I know it is a bit late but I think we can add this one to the final. LGTM from my PoV.

@gunnarmorling I know it is a bit late but I think we can add this one to the final. LGTM from my PoV.

It's important to merge this for 1.9 as the current state of Redis Sink has a regression comparing 1.8.
Before using batches, streaming change records one by one worked on multi-sharded Redis database as well.
Once we changed it to Transaction (with Mutli), we gained performance improvement, but the sink no longer works on multi-sharded DB. So, changing to Pipeline (also send the data in a buffer of commands, i.e, batches) is the best way to stream the data in terms of performance and multi-sharded support.
Thanks a lot!

Makes sense, thanks for providing that context, @spicy-sauce! Squashed and applied.


Adding Task server backend changes for Hue

This change enables Hue backend server, following hue.ini parameters are needed.
[desktop]
enable_chunked_file_uploader=true
[filebrowser]
max_file_size_upload_limit=-1 # Bytes
[[task_server]]
enabled=True
beat_enabled=True
fetch_result_limit=20000
result_storage='{"BACKEND": "django.core.files.storage.FileSystemStorage", "properties": {"location": "./logs"}}' broker_url="redis://localhost:6379/0"
celery_result_backend="redis://localhost:6379/0"
celeryd_opts='--time-limit=300'
execution_storage='{"BACKEND": "django.core.cache.backends.locmem.LocMemCache", "LOCATION": "celery-hue"}'
Testing Done:
Tested file upload on HDFS, S3, ABFS, Ozone system
What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

Added few review comments, also possible to add few unit tests?

added a unit test.


Add several pages in Japanese to doc

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Thank you for your neat translation!
/approve


How to authenticate when creating a service instance  with the apiaccess plan

Hi team,
I was able to authenticate in case of creating a service instance  with the application plan,
https://github.com/SAP/cloud-security-xsuaa-integration/tree/main/samples/spring-security-xsuaa-usage
but It fails  in case of apiaccess plan.
Please tell me the code for reference.

Spring Boot:2.7.1, xsuaa-spring-boot-starter:2.11.13
Environment: Cloud Foundry
2760424 - API Access to xsuaa Configuration Data: https://launchpad.support.sap.com/#/notes/2760424

Hi @sayortanaka,
the apiaccess plan is not supported by default in the security client libraries. However, it is possible to get it working by providing a custom XsuaaServiceConfiguration bean, where you load manually the service configuration for apiaccess plan. Something like this:
@Bean
public XsuaaServiceConfiguration xsuaaServiceConfiguration(){
    OAuth2ServiceConfiguration conf = CFEnvironment.getInstance().loadForServicePlan(Service.XSUAA, CFConstants.Plan.APIACCESS);
    return new XsuaaServiceConfiguration() {
        @Override
        public String getUaaUrl() {
            return conf.getProperty("url");
        }
        @Override
        public String getAppId() {
            return conf.getProperty(CFConstants.XSUAA.APP_ID);
        }
        @Override
        public String getUaaDomain() {
            return conf.getProperty(CFConstants.XSUAA.UAA_DOMAIN);
        }
        @Nullable
        @Override
        public String getVerificationKey() {
            return conf.getProperty(CFConstants.XSUAA.VERIFICATION_KEY);
        }
        @Override
        public String getClientId() {
            return conf.getClientId();
        }
        @Override
        public String getProperty(String name) {
            return Objects.requireNonNull(conf.getProperty(name));
        }
        @Override
        public String getClientSecret() {
            return conf.getClientSecret();
        }
        @Override
        public ClientIdentity getClientIdentity() {
            ClientIdentity identity = new ClientCertificate(conf.getProperty(CFConstants.CERTIFICATE), conf.getProperty(CFConstants.KEY), getClientId());
            if (!identity.isValid()) {
                identity = new ClientCredentials(getClientId(), getClientSecret());
            }
            return identity;
        }
    };
}

❗ Please upgrade to the latest security client library version which is 2.13.3 it includes important bug fixes!
Kind Regards,
Liga

Hi @liga-oz,
Thank you for your quick response and the upgrade information.
This problem was resolved thanks to your support.
Regards,
Tanaka


Should line not use 'JsonMemInfoMainBlockStart' instead of 'JsonMemInfoBlockStart'

Accidentally stumbled upon this:
https://github.com/ahausladen/JsonDataObjects/blob/72a25adc508387a2797980b5ed963e00f6d1ebc0/Source/JsonDataObjects.pas#L1156
Should that line not use JsonMemInfoMainBlockStart instead of JsonMemInfoBlockStart?

Thanks, but the currently referenced 'fix' points to different commit (which does not show the fix).
It should be: https://github.com/ahausladen/JsonDataObjects/commit/2ddcef634c0a4c070c2cda55d060b7287d029a47

Somehow I committed two "Fixed #56". I never intended to commit the *.dproj file changes. I can't fix this without rewriting the history what will break the git repository for others.

No problem, it's now referenced using my comment ;)


Queue Capture Frame stopped working in 1.14

Description

I have noticed that in version 1.14 the "Queue Capture" checkbox has stopped working. When you mark it and set a few frames, the application crashes and there are no captures in RenderDoc. I'm using RenderDoc to debug OpenGL applications. Capturing with F12 works fine.

There is an error in the log:
Core 15208 07:53:31 core.cpp(770) Error Couldn't find matching frame capturer for device<PHONE_NUMBER>010002 window<PHONE_NUMBER>000000 from 0 device frame capturers and 0 frame capturers

I will attach the whole log file too: RenderDoc_2021.06.08_07.53.05.log
Steps to reproduce

Open RenderDoc
Set the path to your OpenGL executable
Mark the "Queue Capture" checkbox, and set the number of frames (starting from 0)
Click "Launch"
The application crashes and no captures are recorded in RenderDoc.

Environment

RenderDoc version: 1.14
Operating System: Windows 10
Graphics API: OpenGL
GPU: GTX 960M

This was fixed in 6ce0b9a0876b87d3d8903f3393e4e87c7f656fa9. Note that specifically this only happened if you queued capture from frame 0 in an OpenGL application exactly as you describe.


Issue with Forge Coverage

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (6e09b4e 2023-07-24T00:18:14.641174497Z)
What command(s) is the bug in?
forge coverage
Operating System
Linux
Describe the bug
I have a contract, it contains of various functions. After writing certain functions I ran forge coverage, it was showing the contract in the coverage reports. And after that I added another function like below:
function testing() public {

}

And after adding this function which actually does nothing, so at this point when I ran forge coverage, the contract was gone from the coverage reports. So, if we write any empty function in the contract, foundry doesn't consider that contract in the coverage reports.

The issue is that function starts with test which results in contract being recognized as a test contract and excluded from coverage report.
We will consider and implement opt-in/default tests inclusion into gas reports, closing this issue for now


Unable to convert HTC with DCN and multi-scale training model to tensor-rt

Hi,
I'm trying to convert a custom mmdet model that was created based on this pre-trained HTC model available from https://github.com/open-mmlab/mmdetection/tree/master/configs/htc/htc_x101_64x4d_fpn_dconv_c3-c5_mstrain_400_1400_16x1_20e_coco.py
When I try to convert the model, I get the error as "'HybridTaskCascadeRoIHead' object has no attribute 'semantic_head'"
Error log is:
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/models/builder.py:53: UserWarning: train_cfg and test_cfg is deprecated, please specify them in model
'please specify them in model', UserWarning)
load checkpoint from local path: epoch_74.pth
2021-12-16 16:02:15,813 - root - INFO - DeformConv2dPack backbone.layer2.0.conv2 is upgraded to version 2.
2021-12-16 16:02:15,815 - root - INFO - DeformConv2dPack backbone.layer2.1.conv2 is upgraded to version 2.
2021-12-16 16:02:15,817 - root - INFO - DeformConv2dPack backbone.layer2.2.conv2 is upgraded to version 2.
2021-12-16 16:02:15,818 - root - INFO - DeformConv2dPack backbone.layer2.3.conv2 is upgraded to version 2.
2021-12-16 16:02:15,820 - root - INFO - DeformConv2dPack backbone.layer3.0.conv2 is upgraded to version 2.
2021-12-16 16:02:15,823 - root - INFO - DeformConv2dPack backbone.layer3.1.conv2 is upgraded to version 2.
2021-12-16 16:02:15,825 - root - INFO - DeformConv2dPack backbone.layer3.2.conv2 is upgraded to version 2.
2021-12-16 16:02:15,828 - root - INFO - DeformConv2dPack backbone.layer3.3.conv2 is upgraded to version 2.
2021-12-16 16:02:15,830 - root - INFO - DeformConv2dPack backbone.layer3.4.conv2 is upgraded to version 2.
2021-12-16 16:02:15,833 - root - INFO - DeformConv2dPack backbone.layer3.5.conv2 is upgraded to version 2.
2021-12-16 16:02:15,835 - root - INFO - DeformConv2dPack backbone.layer3.6.conv2 is upgraded to version 2.
2021-12-16 16:02:15,837 - root - INFO - DeformConv2dPack backbone.layer3.7.conv2 is upgraded to version 2.
2021-12-16 16:02:15,840 - root - INFO - DeformConv2dPack backbone.layer3.8.conv2 is upgraded to version 2.
2021-12-16 16:02:15,842 - root - INFO - DeformConv2dPack backbone.layer3.9.conv2 is upgraded to version 2.
2021-12-16 16:02:15,844 - root - INFO - DeformConv2dPack backbone.layer3.10.conv2 is upgraded to version 2.
2021-12-16 16:02:15,847 - root - INFO - DeformConv2dPack backbone.layer3.11.conv2 is upgraded to version 2.
2021-12-16 16:02:15,849 - root - INFO - DeformConv2dPack backbone.layer3.12.conv2 is upgraded to version 2.
2021-12-16 16:02:15,852 - root - INFO - DeformConv2dPack backbone.layer3.13.conv2 is upgraded to version 2.
2021-12-16 16:02:15,854 - root - INFO - DeformConv2dPack backbone.layer3.14.conv2 is upgraded to version 2.
2021-12-16 16:02:15,857 - root - INFO - DeformConv2dPack backbone.layer3.15.conv2 is upgraded to version 2.
2021-12-16 16:02:15,859 - root - INFO - DeformConv2dPack backbone.layer3.16.conv2 is upgraded to version 2.
2021-12-16 16:02:15,861 - root - INFO - DeformConv2dPack backbone.layer3.17.conv2 is upgraded to version 2.
2021-12-16 16:02:15,864 - root - INFO - DeformConv2dPack backbone.layer3.18.conv2 is upgraded to version 2.
2021-12-16 16:02:15,866 - root - INFO - DeformConv2dPack backbone.layer3.19.conv2 is upgraded to version 2.
2021-12-16 16:02:15,868 - root - INFO - DeformConv2dPack backbone.layer3.20.conv2 is upgraded to version 2.
2021-12-16 16:02:15,871 - root - INFO - DeformConv2dPack backbone.layer3.21.conv2 is upgraded to version 2.
2021-12-16 16:02:15,873 - root - INFO - DeformConv2dPack backbone.layer3.22.conv2 is upgraded to version 2.
2021-12-16 16:02:15,876 - root - INFO - DeformConv2dPack backbone.layer4.0.conv2 is upgraded to version 2.
2021-12-16 16:02:15,883 - root - INFO - DeformConv2dPack backbone.layer4.1.conv2 is upgraded to version 2.
2021-12-16 16:02:15,888 - root - INFO - DeformConv2dPack backbone.layer4.2.conv2 is upgraded to version 2.
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/apis/inference.py:47: UserWarning: Class names are not saved in the checkpoint's meta data, use COCO classes by default.
warnings.warn('Class names are not saved in the checkpoint's '
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/models/dense_heads/anchor_head.py:123: UserWarning: DeprecationWarning: anchor_generator is deprecated, please use "prior_generator" instead
warnings.warn('DeprecationWarning: anchor_generator is deprecated, '
Traceback (most recent call last):
File "mmtest.py", line 72, in
trt_model = mmdet2trt(config_file, checkpoint_file, opt_shape_param=opt_shape_param, fp16_mode=True, max_workspace_size=max_workspace_size)
File "/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection-to-tensorrt/mmdet2trt/mmdet2trt.py", line 110, in mmdet2trt
torch_model, TwoStageDetectorWraper, wrap_config=wrap_config)
File "/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection-to-tensorrt/mmdet2trt/models/builder.py", line 41, in build_wraper
wrap_model = WRAPER_DICT[model_type](module, **kwargs)
File "/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection-to-tensorrt/mmdet2trt/models/detectors/two_stage.py", line 34, in init
mmdet_roi_head, StandardRoIHeadWraper, wrap_config=wrap_config)
File "/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection-to-tensorrt/mmdet2trt/models/builder.py", line 41, in build_wraper
wrap_model = WRAPER_DICT[model_type](module, **kwargs)
File "/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection-to-tensorrt/mmdet2trt/models/roi_heads/htc_roi_head.py", line 20, in init
if module.semantic_head is not None:
File "/home/monster/.conda/envs/open-mmlab/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1178, in getattr
type(self).name, name))
AttributeError: 'HybridTaskCascadeRoIHead' object has no attribute 'semantic_head'
(open-mmlab) monster@icvmonster:~/Documents/Wenn/Dd/tensorrt/27_11/mmdetection$
===========================================================================
So, I just tried to convert the HTC model (https://github.com/open-mmlab/mmdetection/tree/master/configs/htc/htc_x101_64x4d_fpn_dconv_c3-c5_mstrain_400_1400_16x1_20e_coco.py ) to tensor-rt, I got the error as "Segmentation Fault (Core Dumped)"
The complete log for this is:
load checkpoint from local path: ckpt/htc_x101_64x4d_fpn_dconv_c3-c5_mstrain_400_1400_16x1_20e_coco_20200312-946fd751.pth
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/datasets/utils.py:69: UserWarning: "ImageToTensor" pipeline is replaced by "DefaultFormatBundle" for batch inference. It is recommended to manually replace it in the test data pipeline in your config file.
'data pipeline in your config file.', UserWarning)
load checkpoint from local path: ckpt/htc_x101_64x4d_fpn_dconv_c3-c5_mstrain_400_1400_16x1_20e_coco_20200312-946fd751.pth
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/models/dense_heads/anchor_head.py:123: UserWarning: DeprecationWarning: anchor_generator is deprecated, please use "prior_generator" instead
warnings.warn('DeprecationWarning: anchor_generator is deprecated, '
/home/monster/Documents/Wenn/Dd/tensorrt/27_11/mmdetection/mmdet/core/anchor/anchor_generator.py:370: UserWarning: single_level_grid_anchors would be deprecated soon. Please use single_level_grid_priors
'single_level_grid_anchors would be deprecated soon. '
[12/15/2021-08:45:18] [TRT] [I] [MemUsageChange] Init CUDA: CPU +170, GPU +0, now: CPU 2324, GPU 5821 (MiB)
[12/15/2021-08:45:18] [TRT] [I] [MemUsageSnapshot] Begin constructing builder kernel library: CPU 2324 MiB, GPU 5821 MiB
[12/15/2021-08:45:18] [TRT] [I] [MemUsageSnapshot] End constructing builder kernel library: CPU 2387 MiB, GPU 5821 MiB
unknown interpolate type, use linear instead.
unknown interpolate type, use linear instead.
unknown interpolate type, use linear instead.
unknown interpolate type, use linear instead.
Warning: Encountered known unsupported method torch.Tensor.new_tensor
Warning: Encountered known unsupported method torch.Tensor.new_tensor
[12/15/2021-08:45:21] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1397) [ElementWise]_output and (Unnamed Layer* 1401) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:21] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1406) [ElementWise]_output and (Unnamed Layer* 1410) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:21] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1415) [ElementWise]_output and (Unnamed Layer* 1419) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:21] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1424) [ElementWise]_output and (Unnamed Layer* 1428) [Shuffle]_output: first input has type Float but second input has type Int32.
Warning: Encountered known unsupported method torch.Tensor.new_tensor
Warning: Encountered known unsupported method torch.Tensor.new_tensor
[12/15/2021-08:45:22] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1931) [ElementWise]_output and (Unnamed Layer* 1935) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:22] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1940) [ElementWise]_output and (Unnamed Layer* 1944) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:22] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1949) [ElementWise]_output and (Unnamed Layer* 1953) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:22] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 1958) [ElementWise]_output and (Unnamed Layer* 1962) [Shuffle]_output: first input has type Float but second input has type Int32.
Warning: Encountered known unsupported method torch.Tensor.new_tensor
Warning: Encountered known unsupported method torch.Tensor.new_tensor
[12/15/2021-08:45:23] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 2483) [ElementWise]_output and (Unnamed Layer* 2487) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:23] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 2492) [ElementWise]_output and (Unnamed Layer* 2496) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:23] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 2501) [ElementWise]_output and (Unnamed Layer* 2505) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:23] [TRT] [W] IElementWiseLayer with inputs (Unnamed Layer* 2510) [ElementWise]_output and (Unnamed Layer* 2514) [Shuffle]_output: first input has type Float but second input has type Int32.
[12/15/2021-08:45:24] [TRT] [W] Half2 support requested on hardware without native FP16 support, performance will be negatively affected.
[12/15/2021-08:45:25] [TRT] [W] TensorRT was linked against cuBLAS/cuBLAS LT 11.6.3 but loaded cuBLAS/cuBLAS LT 11.5.1
[12/15/2021-08:45:25] [TRT] [I] [MemUsageChange] Init cuBLAS/cuBLASLt: CPU +0, GPU +8, now: CPU 3221, GPU 2877 (MiB)
[12/15/2021-08:45:25] [TRT] [I] [MemUsageChange] Init cuDNN: CPU +110, GPU +44, now: CPU 3331, GPU 2921 (MiB)
[12/15/2021-08:45:25] [TRT] [I] Local timing cache in use. Profiling results in this builder pass will not be stored.
[12/15/2021-08:45:32] [TRT] [I] Some tactics do not have sufficient workspace memory to run. Increasing workspace size may increase performance, please check verbose output.
[12/15/2021-08:46:39] [TRT] [I] Detected 1 inputs and 4 output network tensors.
[12/15/2021-08:46:40] [TRT] [I] Total Host Persistent Memory: 593904
[12/15/2021-08:46:40] [TRT] [I] Total Device Persistent Memory: 581303296
[12/15/2021-08:46:40] [TRT] [I] Total Scratch Memory: 520224768
[12/15/2021-08:46:40] [TRT] [I] [MemUsageStats] Peak memory usage of TRT CPU/GPU memory allocators: CPU 340 MiB, GPU 1236 MiB
[12/15/2021-08:46:41] [TRT] [I] [BlockAssignment] Algorithm ShiftNTopDown took 1403.19ms to assign 51 blocks to 470 nodes requiring<PHONE_NUMBER> bytes.
[12/15/2021-08:46:41] [TRT] [I] Total Activation Memory:<PHONE_NUMBER>
[12/15/2021-08:46:41] [TRT] [W] TensorRT was linked against cuBLAS/cuBLAS LT 11.6.3 but loaded cuBLAS/cuBLAS LT 11.5.1
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] Init cuBLAS/cuBLASLt: CPU +0, GPU +8, now: CPU 3646, GPU 3759 (MiB)
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] Init cuDNN: CPU +0, GPU +10, now: CPU 3646, GPU 3769 (MiB)
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] TensorRT-managed allocation in building engine: CPU +290, GPU +731, now: CPU 290, GPU 731 (MiB)
[12/15/2021-08:46:41] [TRT] [W] TensorRT was linked against cuBLAS/cuBLAS LT 11.6.3 but loaded cuBLAS/cuBLAS LT 11.5.1
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] Init cuBLAS/cuBLASLt: CPU +1, GPU +8, now: CPU 3645, GPU 3745 (MiB)
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] Init cuDNN: CPU +0, GPU +8, now: CPU 3645, GPU 3753 (MiB)
[12/15/2021-08:46:41] [TRT] [I] [MemUsageChange] TensorRT-managed allocation in IExecutionContext creation: CPU +1, GPU +1592, now: CPU 291, GPU 2323 (MiB)
[12/15/2021-08:46:57] [TRT] [W] TensorRT was linked against cuBLAS/cuBLAS LT 11.6.3 but loaded cuBLAS/cuBLAS LT 11.5.1
[12/15/2021-08:46:57] [TRT] [W] TensorRT was linked against cuBLAS/cuBLAS LT 11.6.3 but loaded cuBLAS/cuBLAS LT 11.5.1
WARNING:root:Can not load dataset from config. Use default CLASSES instead.
Segmentation fault (core dumped)
======================================================
Can you please help me with this?

Please repo you enviroment. You can use this script python tools/collect_env.py


[BUG] Problem with deployment Rollback through the Rancher GUI - Deployment.apps is invalid: spec.template.metadata.labels: Invalid value: map[string]string{}: selector does not match template labels

Rancher Server Setup

Rancher version:
v2.6.8

Installation option (Docker install/Helm Chart):
Docker install

Information about the Cluster

Kubernetes version:
1.21

Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):
Hosted, Imported from EKS

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)
Admin

Describe the bug
When I try to rollback I get the following message:
Deployment.apps “api-notifies-php” is invalid: spec.template.metadata.labels: Invalid value: map[string]string{}: selector does not match template labels
To Reproduce
1. From the Global view, open the project running the workload you want to rollback.
2. Find the workload that you want to rollback and select Vertical ⋮ (... ) > Rollback.
3. Choose the revision that you want to roll back to. Click Rollback.
Result
Error:
Deployment.apps “api-notifies-php” is invalid: spec.template.metadata.labels: Invalid value: map[string]string{}: selector does not match template labels
Expected Result
The expected rollback is successful.
Screenshots
https://ibb.co/kcn3nfC
Additional context
I’ve reviewed the Deployment manifest, adjusted the indentation, made sure the matchLabels selector is the same as the Pod labels in the templates section.
I tried several things, but I couldn’t solve this problem, in order to perform the Deployment Rollback.
Through kubectl the rollback is working correctly.
Here is my deployment manifest:
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  namespace: teste-devops
  labels:
    app: nginx
spec:
  template:
    metadata:
      labels:
        projeto: testando
    spec:
      containers:
      - name: nginx
        image: nginx:1.20.0
        ports:
        - containerPort: 80
  replicas: 2
  selector:
    matchLabels:
      projeto: testando

Docker version(on EC2 instance where Rancher is hosted):

Client: Docker Engine - Community
 Version:           20.10.17
 API version:       1.41
 Go version:        go1.17.11
 Git commit:        100c701
 Built:             Mon Jun  6 23:02:57 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.17
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.11
  Git commit:       a89b842
  Built:            Mon Jun  6 23:01:03 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.6
  GitCommit:        10c12954828e7c7c9b6e0ea9b0c02b01407d3ae1
 runc:
  Version:          1.1.2
  GitCommit:        v1.1.2-0-ga916309
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Details about the Kubernetes nodes inside Rancher Container:
sh-4.4# kubectl get nodes
NAME         STATUS   ROLES                       AGE    VERSION
local-node   Ready    control-plane,etcd,master   132m   v1.24.1+k3s1
sh-4.4#

Same problem here.
Following..

I had the same problem here.
Waiting...


OCPBUGS-11933: Ignore informative annotations upon admission

This PR introduces a list of known informative annotations; pod admission then will ignore any pod mutations that only add these annotations.
The goal is to prevent a pod to be re-admitted and potentially change the SCC under which it gets admitted when a mutation only adds informative annotations, which shouldn't cause SCC changes.
This also fixes a bug in the TestShouldIgnore unit test within pkg/securitycontextconstraints/sccadmission/admission_test.go.

/jira refresh

/hold
contains fixups

/hold
holding until 4.14 stabilized or branched out

please create a proof PR in openshift/kubernetes

/hold cancel
fixups removed
the automation should be capable of merging this when the critical-fixes-only gate is lifted

please create a proof PR in openshift/kubernetes

@stlaz this is the poc PR: https://github.com/openshift/kubernetes/pull/1708

/approve
we may want to ask @deads2k to have a peek but the PR seems ok to me

/lgtm


fix delete approveKey in transfer method

It's in both examples.

Resolved in 0acb503

great, thanks for your remind


update insert scripts

This fixes #11

This needs to be tested if the JSON is correct. Once done, the referencing scripts can be completely deleted.
hi, @sanujsood you have added ids in JSON. Can you show the script that you wrote to do that?
the insert scripts can be made more pythonic by
li.append(
    GitaAuthor(
        name=i["name"],
        id=i["id"],
    )
)

Hi @aahnik  , we had a local instance on which we had already run that long reference script and we just got Json dump of that db , so it is correct in terms of Ids and references


support gettext extracted comments

Extracted comments (see --add-comments part of the gettext doc, or developer comments) can be helpful for developers to hint the translator about the translated string. It would be nice if we support such feature.
/* this is foo */
const foo =  t`pen pineapple apple pen`;

const bar = /* hello world */ngettext(/* this is bar */ msgid`${n} time clicked`, `${n} times clicked`, n);

Could extracts to something like:
#. this is foo
#: some-file
msgid "pen pineapple apple pen"
msgstr ""

#. hello world
#. this is bar
#: some-file
msgid "${ 0 } time clicked"
msgid_plural "${ 0 } times clicked"
msgstr[0] ""
msgstr[1] ""

Agree, this one is already in todo list. Do you think we should extract all comments before translated string or with some special marker like:
/* trans: this is foo */
const foo =  t`pen pineapple apple pen`;

Seems that gettext --add-comments has an optional "tag" argument. When tag is not specified it extracts all comments, and when a tag is specified, it only extracts comments with those tag.

started work on this here - https://github.com/c-3po-org/babel-plugin-c-3po/pull/56

you can try this feature in 0.1.0 version of babel-plugin-c3po

Thank you so much for the rapid response!
I am trying this out and found a small issue. After fixing that it is working pretty well.
I have identified an edge case that is a little bit weird, though, expressed in a pseudo-test case below:
    // in test_extract_developer_comments.js

    it.only('should extract each level of comments', () => {
        const input = dedent(`
        import { t } from 'c-3po';

        // comment4-3
        dispatch( /* comment4-2 */ someAction( /* comment4-1 */ t\`test4\` ))
        `);
        babel.transform(input, options);
        const result = fs.readFileSync(output).toString();
        console.log(result); // What should the result be?
    });

Currently the output of result is:
msgid ""
msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"Plural-Forms: nplurals=2; plural=(n!=1);\n"

#.  comment4-2
msgid "test4"
msgstr ""

I was expecting #. comment4-1. #. comment4-3\n#. comment4-2\n#. comment4-1 may be even better, but it may be hard to achieve this.
When t is put inside a function call, the node received by applyExtractedComments() becomes a CallExpression with the TaggedTemplateExpression as its only argument and someAction being the callee with a leading comment comment4-2.
The current status is a little bit confusing, and I think there might be a number of edge cases (like in the middle of string catenation, inside a template string interpolation) to consider.

I found that supporting #. comment4-1 is not easier than directly supporting #. comment4-3\n#. comment4-2\n#. comment4-1.

Thanks, I have merged your PR because it fixes bug with #. comment4-1 and also who knows maybe someone will find the use case for the recursive comments. Will update doc soon.

I have tried it out in my code. I find recursive comments useful when commenting a group of keys that should be given same comments. Instead of prepending comments before each t(), I did something like:
export const keyToNames = (key) => {
  // t: Action name in page OOO.
  const MAPPING = {
    key1: t`Something`,
    key2: t`Another Thing`,
    key3: t`Yet another thing`,
  };

  return MAPPING[key] ? MAPPING[key] : key;
};

export const OPTIONS = /* t: option names */ fromJS([
  {label: t`option 1`, value: 1}, // ...
])

makes sense


Event Manager Admin Menu

Breakout from #1803
Update menu rules so that anyone with event manager access has an admin menu item with a link to the admin event lister.
If they only manage one event, perhaps we take them directly to the event page itself, rather than a list with a single item? @schback - Any preference?

Under the admin item, there is currently only campaigns showing. So for this story, we need to create an event menu item.

Picking this up

I have added a basic event lister page for #1898 which will have the path Admin/Event/ListAll

@wmay1991 Just checking in to see if you had managed to complete anything for this or if we can open it up again for contributors?


Error on armv7

On armv7, I'm getting the following error.
standard_init_linux.go:211: exec user process caused "exec format error"

Fixed 6c23f8fbcbdf244c839732bad8725f587facf836


missing files

Hello.
I am trying to compile the project but it gives me errors that files are missing
Compiling .pio\build\esp32dev\src\port\hal_esp32_i2c.o
src\port\agenttime_esp.c:19:36: fatal error: ../lwip/apps/sntp/sntp.h: No such file or directory
compilation terminated.
*** [.pio\build\esp32dev\src\port\agenttime_esp.o] Error 1
What is the problem?
Thansk
José

I have fix the problem.
At the agenttime_esp.c file you need to change.
#include "../lwip/apps/sntp/sntp.h"
for  #include "../lwip/lwip/src/include/lwip/apps/sntp.h"
It works.
Thanks

thank you.
I corrected the include path.


First time switching to WINDOWED from FULLSCREEN when set in project settings does not work

Godot version
v4.0.2.stable.official [7a0977c]
System information
Window 10
Issue description
If your project is set to WINDOW_MODE_FULLSCREEN in project settings, the first time you try to switch mode for WINDOWED, it will not switch properly.
Steps to reproduce

Create a new project
Change project settings Display > Window > Mode for FullScreen
Run the following code :

Code that reproduce the issue:
func _ready():
	DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_WINDOWED)
	DisplayServer.window_set_size(Vector2i(800,600))

Workaround
Calling the window_set_mode twice solve the issue...
func _ready():
	DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_WINDOWED)
	DisplayServer.window_set_mode(DisplayServer.WINDOW_MODE_WINDOWED)
	DisplayServer.window_set_size(Vector2i(800,600))

Minimal reproduction project
N/A: reproduction steps are trivial

Related to https://github.com/godotengine/godot/issues/74286.


Suggestion: change this env var to something less generic

Funny. I have the same change in my local environment. you just beat me to it


Rename "IDLE" interceptor ready state to "INACTIVE"

Idle, I'm good and waiting for commands;
Inactive, I'm not good, I was not applied at all.

It's weird when the interceptor fails checkEnvironment and remains in IDLE state. It does not get applied, as expected, but the "IDLE" state is confusing when inspecting the interceptor. It must read "INACTIVE" both before it attempts to apply and if it shouldn't be applied due to the environment check.

Released: v0.19.0 🎉
This has been released in v0.19.0!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


As a user, manage contacts

[ ] UI on 3bot app

[ ] search contacts
[ ] birthdate format (also check other dates )
[ ] edit contact in popover ( same as create new )
[ ] edit popover

[ ] prevent closing form when clicking outside
[ ] country dropdown ( now just text )
[ ] save button more clear ( maybe on the bottom )
[ ] salutation dropdown ( now checkbox ), add text field
[ ] add button repeats with each field. remove it.
[ ] make blocks more separated ( phone, email, address )
[ ] scrollbar is not sexy

[ ] actors

[ ] rework upload contact picture ( big pictures not possible now ) - this needs filestorage package! @jdelrue

moved to threebotapps repository


RenderDoc 1.25 Crashes with Segfault on Ubuntu 22.10 AMD 6950 XT Mesa Vulkan - Hangs and Freezing

Description

Loading a Vulkan app with RenderDoc on Ubuntu 22.10 with an AMD 6950 XT and Mesa drivers (Kisak) causes the Vulkan app to become very choppy and hang for 3 - 5 seconds and a time intermittently and then eventually hang forever (after about 20 seconds). At this point the app must be forced closed. If I attempt to capture a frame prior to the freeze, it appears to load and then after 5 seconds hangs the qrenderdoc interface and crashes RenderDoc with a seqfault error. This is not reproduceable on vkcube but does happen on my app and also the Vulkan-Tutorial example code.
Steps to reproduce

Compile this example and run it through RenderDoc 1.25
https://github.com/Overv/VulkanTutorial/blob/main/code/30_multisampling.cpp
You may need to be on Ubuntu 22.10 and it also an AMD video card on Mesa drivers (I'm not sure about this).
Watch the app loads with strange freezing performance and then eventually hangs forever.
Attempt to save a capture before it freezes.
Double-click the capture and the RenderDoc app crashes with a segfault.

I cannot share the capture because the application crashes prior to allowing saving.
Environment

RenderDoc version: 1.25
Operating System: Ubuntu 22.10
Graphics API: Vulkan

AMD RX 6950 XT
Mesa 22.3.6 - kisak-mesa PPA

Thanks. I did suspect a driver issue at first. I've tried the drivers that come with Ubuntu and the Kisak PPA, which is slightly newer version of Mesa. I did not try the latest from Git as I find they are sometimes unstable, but I can try it as a test. It may also be a 22.10 issue. I have a second Linux box I can try, though it is very similar (Ubuntu 22.10 + 6700 XT). I also have a Windows laptop but I'm almost certain the issue is something on Linux. Give me a few days to test on all my machines to see if that narrows down the problem. Thanks.


ServiceLocator: Fix MvcForm.RenderEndOfFormContent

                HtmlEncoder htmlEncoder = null;
                if (htmlWriter == null)
                {
                    htmlEncoder = _viewContext.HttpContext.RequestServices.GetRequiredService<HtmlEncoder>();
                }

This one was already fixed. See https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/MvcForm.cs#L26
I'm closing it.

/cc @Eilon


attr/top_right_corner_radius (aka com.iamk:attr/top_right_corner_radius) not found.

-RoundKornerLayouts-0.4.0/res/values/values.xml:6:5-261: AAPT: error: resource attr/top_right_corner_radius (aka com.iamk:attr/top_right_corner_radius) not found.

I am having the same issue.

I'm having the same issue

Hi guys, just add this into values/attrs.xml
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <attr format="dimension" name="top_left_corner_radius"/>
    <attr format="dimension" name="top_right_corner_radius"/>
    <attr format="dimension" name="bottom_right_corner_radius"/>
    <attr format="dimension" name="bottom_left_corner_radius"/>
</resources>

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <attr format="dimension" name="top_left_corner_radius"/>
    <attr format="dimension" name="top_right_corner_radius"/>
    <attr format="dimension" name="bottom_right_corner_radius"/>
    <attr format="dimension" name="bottom_left_corner_radius"/>
</resources>

Thanks, it worked

I see the commit when this bug was fixed. How soon it will be applied in new version?

I am having the same issue.

@PrashantShrestha I downloaded previous commit of my project(not the library). Clean gradle build worked fine.


Method chain check

Codecov Report

Merging #14 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #14      +/-   ##
===========================================
+ Coverage     74.83%   74.9%   +0.06%
- Complexity      494     495       +1
===========================================
  Files            44      44
  Lines          1530    1530
  Branches        177     177
===========================================
+ Hits           1145    1146       +1
+ Misses          292     291       -1
  Partials         93      93

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/guru/nidi/graphviz/engine/Graphviz.java
68.57% <100%> (+2.85%)
14 <3> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234c18b...c6205c5. Read the comment docs.

This is valid, but the Rasterizer has also to be adjusted to work when both size and scale is given.
I've done that.


Prepare for backend connector

Improvements to make everything work with the updated node version and the backend connector.

When trying to build I get: error: failed to select a version for bitflags.

I dont know. Maybe you are using a different rust version?

When trying to build I get: error: failed to select a version for bitflags.

I dont know. Maybe you are using a different rust version?

I am using the latest, version rustc 1.55.0. Can you upgrade and check again? I would rather not merge before we understand the issue.


[176] Allow for more granular permissions based on user access control groups

This adds a new concept in the Demographic model which links users and stories through an access control grouping. I'm open to suggestions for the name, but it seems like these will mostly be based on real-world social groupings, such as elders from a certain village or descendants of one individual. The term "demographics" felt like a decent fit. This is a different concept from both user roles and story permissions. The three complementary concepts we'd have after this PR are:
Story permissions - an individual story is marked as either:

:anonymous meaning public, or
:user_only meaning any signed-in user may see it

User roles - an individual user has a single role that's one of:

user basic signed-in user, may view some restricted content
editor same as user, and also may edit story and location content
admin same as editor, and also may edit other users (just added as an option, not yet implemented/enforced)

Demographics - a group of users and stories that defines restricted access levels using the following data (basically describing two new HABTM relations)

name a human-readable plain-language name for the group
users a list of users included in this group
stories a list of stories this group has access to

Punch List

[x] Create the Demographic model
[x] Add relationships between Demographic, User, and Story models
[x] Customize the demographic dashboard in administrate
[x] Filter stories based on Demographics
[x] Remove the direct User-Story access control association
[x] Replace the Story.permission_level field with Story.is_public
[x] Add pundit policies so that editors:

[x] may not modify User models
[x] may not view Demographics they don't belong to
[x] may not add stories to Demographics they don't belong to
[x] can only see appropriate Users and Stories when modifying Demographics
[x] may not add Demographics outside of their permissions to Stories they have access to

[ ] Automatically add the user who creates a Demographic to that Demographic (otherwise only
admins can access it)

[x] add the current user to the demographic
[ ] prevent duplicate records

[x] Do not list Demographics under Stories that when an editor doesn't belong to them
[ ] Prevent limited Demographics scope of editor from deleting existing Demographics when updating Stories

For Discussion
I think we can streamline these concepts a bit, but we probably do want some form of all three. Check out this branch, go to the new Demographics dashboard in the admin and see if creating demographic groups and associating users and stories seems logical. Here are some specific questions I have for the team.

Story permissions is currently a text field at Story.permission_level but I think at this point it only needs to be a boolean indicating whether a story should be shown to the public, something like Story.is_public.
Similarly, should we expect that the combination of user role plus demographics will always result in the correct editing permission for stories. In other words, if a user is an editor, should they have editing access to all stories their demographics allow them to see? Or should there be a distinction between view-only demographics and editor-specific demographics?
Does the admin user role make sense? My expectation would be that members of the ACT who are setting things up (plus maybe a few tech-savvy locals) would be the only admins. Everyone else would go to that group to get elevated editing permissions or to modify demographics for access control.
I also modified the models to allow for direct user-to-story access levels, but I'm curious if this is really needed or if it just adds extra complexity and confusion. The same could be accomplished by creating a demographic group with only one user. If that's a rarity it should be fine; if it's common the number of single-user demographics could become a problem. Note, there's no dashboard UI for setting up these direct user-story relationships yet.

AWESOME!!! :100: :tada:
Thanks for getting this started!
Discussion points:

I think updating that filed to a boolean is_public? makes total sense here, since we only really have that distinction now for Stories.
Editing and viewing to me are distinct. Viewing stories is on a user level, but some users also have the ability to add/update/delete stories. That also means they have access to the /admin backend. There could be an "editor-only" demographic for stories which aren't ready to be published yet, or something.
admin makes sense to me! In the future these would be the users that could add and update custom fields for the models too.
Maybe @rudokemper can help us answer that question, is it more common that stories would be visible to certain groups or usually just individuals?

Thanks for the feedback, @mirandawang! To clarify my second question, I really just mean should an editor be able to edit every story they can view? I think we're agreeing that they should, but I wanted to make sure.

Brilliant stuff Jason!! 👍👍👍

I would agree here.
Yeah, I mean, theoretically there could be a scenario where a community member gets to view stories X, Y, and Z, but only have permission to edit X. Let's say that they are a hunter and story A is a hunting story, whereas Y and Z are stories told by elders which they should be able to hear, but not modify. But I really can't imagine this playing out in reality, certainly not anywhere where we work for instance. Let's just keep it simple.
Fully agreed here and also with @mirandawang's suggestion about adding and custom fields for the models in the future.
My feeling is that the demographic groups (with one-user groups if necessary) are perfectly sufficient, and that having the additional direct-to-user setup could likely result in more confusion.

Cool so, to sum up:

Editors can edit or delete any story that they can view / they have created.
Story permission levels will be based on Demographic groups. For the rare case of individual level permissions, we can model this as a one person group.

@rudokemper @Bootjack @kalimar does that all sound right?

@kalimar In my defense, jQuery was already a part of administrate 😜

Also, some general explanation: Those last few commits (including the jQuery stuff) are in support of honoring pundit policies in the multiple-select widget for Stories/Demographics/Users in the administrate forms. To do that I created a custom field HasManyScopedField that subclasses the normal Field::HasMany from administrate. That felt a little hacky because I had to copypasta two methods from the base class and tweak them.
Even more hacky is that in order to pick up the styles and js from the base field I had to run their rails generator that copied all the assets for all fields and dumped them into our app. I'm sure a more clever dev could have come up with a cleaner way to do that. Eventually, though, I think the in-map editing will supplant this entire administrate interface so I'm not super worried.

lol, nvm. @kalimar 's nerd snipe was successful

You know me too well @bootjack. You know me too well

:eyes:

closing for now; thank you for this work!


build: upgrade go directive in go.mod to 1.17

Description
This PR upgrades the go directive in go.mod file by running go mod tidy -go=1.17 to enable module graph pruning and lazy module loading.
Note 1: This does not prevent users with earlier Go versions from successfully building packages from this module.
Note 2: The additional require directive is used to record indirect dependencies for Go 1.17 or higher, see https://go.dev/ref/mod#go-mod-file-go.
Has your change been tested?
Manually tested with go test -race ./...
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

thanks!


Resistor models don't work.

When creating instance of resistor, NGSPICE complains that resistor model has not been found

Which resistor model, and how are you including the SPICE model libraries?  Please include a repeatable test case.

Hopefully my response on the #analog-design channel in the skywater-pdk slack workspace is what you're looking for?

NGSPICE Log:
ngspice -r "serdes/resisor_issue.raw" serdes/resisor_issue.spice
******
** ngspice-34 : Circuit level simulation program
** The U. C. Berkeley CAD Group
** Copyright 1985-1994, Regents of the University of California.
** Copyright 2001-2020, The ngspice team.
** Please get your ngspice manual from http://ngspice.sourceforge.net/docs.html
** Please file your bug-reports at http://ngspice.sourceforge.net/bugrep.html
** Creation Date: Sat Mar  6 03:53:35 UTC 2021
******

Compatibility modes selected: hs a

Circuit: **.subckt resisor_issue

Error: unknown subckt: xr1 0 net1 sky130_fd_pr__res_generic_m1 w=1 l=1 mult=1 m=1
    Simulation interrupted due to error!

ngspice 1 ->

Netlist (my install path is /opt/pdk_root, other models like transistors work):
**.subckt resisor_issue
V2 net1 GND vdd_volts
XR1 GND net1 sky130_fd_pr__res_generic_m1 W=1 L=1 mult=1 m=1
**** begin user architecture code

.temp 125
.param vdd_volts=1.65
.param vddio_volts=3.0

.control
tran 0.01ns 20ns
write
.endc

.param mc_mm_switch=0

.lib "/opt/pdk_root/sky130A/libs.tech/ngspice/sky130.lib.spice" ss

**** end user architecture code
**.ends
.GLOBAL GND
** flattened .save nodes
.end

Hmm... Maybe it's not a .subckt but resistor model and I need to use RR1 instead of XR1?

Update: The X-> R replacement in SPICE helped, but now it gives mult parameter not found, the netlist is generated from xschem using the XSCHEM symbols from Open_PDKs, they may need to be updated to remove that parameter.

Could you please apply the changes or do I need to report it somewhere else?

Issue has been solved in xschem_sky130 and pushed to upstream. Closing this now. (I am assuming the open_pdks will just install latest xschem_sky130)


Updated a few styles and changed the number in the header

Issue #: /bcgov/entity#6378
Description of changes: Updated a few styles and changed the number in the header
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Looks like this branch needs to be rebased.
Should update the app version.
Since John has left now, Cam or I will need to pick this up.
Since this change is small, Cam or I can probably include this as part of other work.

Thoughts?

Sorry, late on this reply. Will be picking this up as well, updating the shared components versions and whatnot :)

Closed this PR. Work was incorporated into pr: https://github.com/bcgov/business-edit-ui/pull/173