Statistice in prune cmd do not add up.

Output of restic version
0.5
Expected behavior
for the statistics to add up :)
Actual behavior
# restic -r rest:http://qnap.********.**:8000 prune
counting files in repo
building new index for repo
[13:17] 100.00%  15586 / 15586 packs
repository contains 15586 packs (1697307 blobs) with 71.899 GiB bytes
processed 1697307 blobs: 17196 duplicate blobs, 165.663 MiB duplicate
load all snapshots
find data that is still in use for 209 snapshots
[1:06:58] 100.00%  209 / 209 snapshots
found 1548104 of 1697307 data blobs still in use, removing 149203 blobs
will delete 318 packs and rewrite 113 packs, this frees 2.339 GiB
[0:35] 100.00%  113 / 113 packs rewritten
[0:03] 100.00%  318 / 318 packs deleted
counting files in repo
[3:02] 100.00%  15180 / 15180 packs
finding old index files
saved new index as 8117b867
remove 181 old index files
done

please note we start out with 15586 packs, it deletes 318 packs and ends up with 15180 packs. (unexplained difference of 88 packs)
Investigation of the data directory in the repo shows there are indeed only 15180 packs.
Steps to reproduce the behavior
run prune on a repo you haven't pruned in a while (3-4 wks)

Thanks for reporting, those stats need to be looked at again.

I think this is resolved by now, please add a comment should that not be the case. I'm closing the issue for now, thanks!


[question] use cranelift with rust-analyzer

hello
i want to know if i can use cranelift with rust-analyzer, because rust-analyzer messes up my target directory.
how? when i open the editor, rust-analyzer starts building again from scratch. when i close the editor and build in the command line with cargo-clif, the build is done again from the beginning.
so there are different build artfiacts, ofcourse, and that is a problem.

Resolved in https://github.com/rust-lang/rust-analyzer/issues/13878


Community feedback, testing and improvements for Apache2 config docs

From https://forum.mattermost.org/t/websocket-apache-2-2-forwards-to-ws-127-0-0-1-8065-api-v3-users-websocket/3437
Summary
I updated to the latest mattermost (3.10.0). I want to use my Apache 2 (2.22.2) with my own SSL certificates. I use this Apache2 with SSL configuration from your documentation without the "Require all granted" lines, because they are for Apache 2.4.
Because I can't update to Apache 2.4, I had to setup the proxy_wstunnel manually.
All requests in Mattermost are answered properly, but 'https://mm.analyse-konzepte.de/api/v3/users/websocket' gets a 301 to the location: "/ws:/<IP_ADDRESS>:8065/api/v3/users/websocket". When I enter the URL 'mm.analyse-konzepte.de/api/v3/users/websocket' in my browser, it takes me to: mm.analyse-konzepte.de/ws:/<IP_ADDRESS>:8065/api/v3/users/websocket and obviously i get an error.
Expected behavior
I would expect, that https://mm.analyse-konzepte.de/api/v3/users/websocket forwards internally to <IP_ADDRESS>:8065.
Observed behavior

@MikeDaniel18 @funkyfuture
A report from a community member after trying to set up Apahce2 proxy with SSL. Any thoughts or anything you might be able to help with?

sorry, no clue.

I, too, am having the same issue. Any news on this?

@jasonblais could you ask for his apache configs and if he have any .htaccess taking place for those as well? thx

@drcurry2010 Would you be able to provide the information mentioned above?

could you ask for his apache configs and if he have any .htaccess taking place for those as well? thx

I'm getting the dreaded "Please check connection, Mattermost unreachable. If issue persists, ask administrator to check WebSocket port." error after following the unofficial Apache2 docs, including certbot SSL with a redirect to port 443. This is on Apache 2.4 and Ubuntu 16.04 LTS.
These docs don't really say what packages and Apache modules we need to install/enable. I'm wondering if that's the problem. For Apache, I enabled proxy, proxy_http, proxy_wstunnel, and rewrite_module. Should there be others?

@corinroyal hey I contributed to those docs and I agree they're in dire need of which packages need to be installed. My problem is, I did it so long ago now that I'll struggle to remember all of them. I'll have a think and see if I can't figure out what you're missing. The instructions should work fine for you.
@jasonblais Apologies for missing this, it seems I don't get notified by email when I'm mentioned in a comment. This looks odd. I don't think it's a .htaccess issue so I'm thinking it's arising from a difference in the way Apache 2.4 and Apache 2.2 handle the rewrite rules (or other parts) in the .conf. I don't think I'd be qualified to go much further than that - but I'll have a little think and a tinker.

Thanks @MikeDaniel18 and @jasonblais  for your help looking into this.
Here's are pastes of the apache virtual host configurations:
/etc/apache2/sites-available/talk.museapps.online.conf: http://termbin.com/w77v
/etc/apache2/sites-available/talk.museapps.online.conf-le-ssl.conf: http://termbin.com/21m3
I hope it's just a simple mistake on my part. I do have another domain hosted on this VPS. Holler if you want to see that config. Everything works great except for the web sockets, which is where I tend to trip up with Mattermost.

Thanks @corinroyal and @MikeDaniel18!
Wondering @MikeDaniel18 if you'd have any thoughts on the latest note above?

@corinroyal & @jasonblais  Yea this is a little tricky, it's very different from the original issue (which I'm relatively convinced is due to a misconfiguration or a typo somewhere - it's appending the URL rather than redirecting it). However, with this issue, I think its because you seem to have copied the non-ssl config to the ssl config when there are subtle differences. For instance, in the SSL config, try changing this:
RewriteRule .* wss://<IP_ADDRESS>:8065%{REQUEST_URI} [P,QSA,L]
to
RewriteRule .* ws://<IP_ADDRESS>:8065%{REQUEST_URI} [P,QSA,L].
You also seem to have missed these two lines:
RewriteCond %{DOCUMENT_ROOT}/%{REQUEST_FILENAME} !-f
RewriteRule .* http://<IP_ADDRESS>:8065%{REQUEST_URI} [P,QSA,L]

Let me know if this helps.
Mike

Also, @jasonblais thanks for the reminder to respond again. I know sometimes it's hard to ask random people on the internet to follow up on things, but I promise my tardiness isn't because of an unwillingness to help! Keep pestering me until I respond if needed!!

@MikeDaniel18 Thank you! We really appreciate your help here. Many people have used your docs to configure Apache2 proxy so you've made quite an impact here. :)

@jasonblais My pleasure. Let's see if it fixes it first :)

Thank you @MikeDaniel18 and @jasonblais. Unfortunately I'm no longer able to test as I just finished ripping out Apache for Nginx, which fortunately fixed the issue. I suspect your fix would work. Let's hope the next person with the same problem gives it a try.

I ran into the same problem as @jasonblais.
I was able to fix it by installing and enabling the following apache modules mod_rewrite , mod_proxy, mod_proxy_http and mod_proxy_wstunnel. (I am on gentoo so I did this by adding proxy proxy_http proxy_wstunnel rewrite to the APACHE2_MODULES variable in make.conf).
I also added the following lines in my apache configuration (under the <VirtualHost *:443> section):
# Begin mattermost configuration
ProxyPreserveHost On
RewriteEngine On
RewriteCond %{REQUEST_URI} /api/v[0-9]+/(users/)?websocket [NC,OR]
RewriteCond %{HTTP:UPGRADE} ^WebSocket$ [NC,OR]
RewriteCond %{HTTP:CONNECTION} ^Upgrade$ [NC]
RewriteRule .* ws://<IP_ADDRESS>:8065%{REQUEST_URI} [P,QSA,L]

<Location />
        Require all granted
        ProxyPass http://<IP_ADDRESS>:8065/
        ProxyPassReverse http://<IP_ADDRESS>:8065/
        ProxyPassReverseCookieDomain <IP_ADDRESS> mysubdomain.mydomain.com
</Location>
# End mattermost configuration

I did extensive testing and all of the lines above were essential to get the websockets to work.
However, I found the following lines to be obsolete (In fact the obsolete Rewrite lines were harmful to other services running on the same server):
# setup the proxy
# I don't think this can work with apache 2.4
# because the 'Order allow,deny' and 'Allow from all' syntax has been deprecated
<Proxy *>
        Order allow,deny
        Allow from all
</Proxy>
RewriteCond %{DOCUMENT_ROOT}/%{REQUEST_FILENAME} !-f
RewriteRule .* http://<IP_ADDRESS>:8065%{REQUEST_URI} [P,QSA,L]
<LocationMatch "^/api/v(?<apiversion>[0-9]+)/(?<apiusers>users/)?websocket">
        Require all granted
        ProxyPass ws://<IP_ADDRESS>:8065/api/v%{env:MATCH_APIVERSION}/%{env:MATCH_APIUSERS}websocket
        ProxyPassReverse ws://<IP_ADDRESS>:8065/api/v%{env:MATCH_APIVERSION}/%{env:MATCH_APIUSERS}websocket
        ProxyPassReverseCookieDomain <IP_ADDRESS> mysubdomain.mydomain.com
</LocationMatch>

Should I update the documentation accordingly (i.e. add the documentation of which modules are required and remove the obsolete configuration lines)?
I assume the same applies to the non-ssl configuration but I cannot test this in my setup. Should I update the non-ssl documentation anyways?

@thawn Great stuff. We've been meaning to add the modules to the documentation. None of those modules would negatively impact the non-ssl configuration.
Thanks for removing the obsolete code, it was a relic from the very first test a user did.

@MikeDaniel18 glad I could help :) It took me the better part of a day to figure out what was wrong with my setup until I realized that I was simply missing the mod_proxy_wstunnel module - d'oh.
I now also changed the non-ssl configuration accordingly (pull request #2261). If possible, it would be great if someone with a non-ssl apache setup could test the apache configuration although I don't see a reason why it should not work.

If you want to open mattermost inside an iframe you have to add following inside your apache vHost configuration.
Header append Content-Security-Policy "frame-ancestors 'self' https://*.your.domain.local" Header unset Content-Security-Policy Header append X-Frame-Options "ALLOW-FROM 'https://*.your.domain.local'" Header unset X-Frame-Options
An example: https://documentation.kopano.io/kopano_mattermost_manual/first_steps.html#configuration-for-kopano-webapp-deskapp

I successfully set up mattermost alongside my existing apache2 cloud server thanks to your instructions!  I'd suggest two additional notes.
(1) If proxying a new port (e.g., 8443), you may need to add "Listen 8443" on a separate line before the <VirtualHost *:8443> entry in the .conf file.
(2) In the mattermost config.json file, Mattermost docs suggest this: "ListenAddress": ":8065" - which works but leaves mattermost listening to the world directly on that port. To restrict this to the apache proxy, use: "ListenAddress": "localhost:8065". Of course, if your mattermost service is on a different server, that won't work. I'm not sure if you can use the IP address of your apache server in that case, but there's always iptables if you need to restrict access to a port selectively.

@gracion Thank you for the additional notes! Really appreciate it. Would you be open to help with a pull request to add them to the guide?
cc @justinegeffen

I'd love to!  Good chance to experience my first github pull request (I still live happily in the subversion world). Also my first experience with reStructuredText. Trying to setup for this, but my BBEdit rst previewer script gives an error because Pygments cannot be found because<EMAIL_ADDRESS>is not working with python2.7 on Catalina, etc.  Atom editor has an rst package, but I can't see a way to preview with it.
Do you have a suggested way to preview .rst?
Cheers,
--Paul

On Sep 7, 2020, at 7:18 AM, Jason Blais<EMAIL_ADDRESS>wrote:
@gracion https://github.com/gracion Thank you for the additional notes! Really appreciate it. Would you be open to help with a pull request to add them to the guide?
cc @justinegeffen https://github.com/justinegeffen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mattermost/docs/issues/1295#issuecomment-688355348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHFWAOZMZN5D2CKLKZDTWLSETTTFANCNFSM4DQ7TMVA.

Ok, pull request made!  I used a javascript previewer at http://rst.ninjs.org http://rst.ninjs.org/  - Should be no problems, but criticism is welcome.
Thanks,
--Paul

On Sep 7, 2020, at 4:32 PM, Paul Collins<EMAIL_ADDRESS>wrote:
I'd love to!  Good chance to experience my first github pull request (I still live happily in the subversion world). Also my first experience with reStructuredText. Trying to setup for this, but my BBEdit rst previewer script gives an error because Pygments cannot be found because<EMAIL_ADDRESS>is not working with python2.7 on Catalina, etc.  Atom editor has an rst package, but I can't see a way to preview with it.
Do you have a suggested way to preview .rst?
Cheers,
--Paul

On Sep 7, 2020, at 7:18 AM, Jason Blais<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
@gracion https://github.com/gracion Thank you for the additional notes! Really appreciate it. Would you be open to help with a pull request to add them to the guide?
cc @justinegeffen https://github.com/justinegeffen
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mattermost/docs/issues/1295#issuecomment-688355348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHFWAOZMZN5D2CKLKZDTWLSETTTFANCNFSM4DQ7TMVA.

Thank you, @gracion!
In terms of previewing the content, there is a preview server that spins up with every pull request but I see the deployment failed. I made some changes to your PR and committed them as that usually resolves the problem. In this case it didn't so I will have a chat with the DevOps team. It may be related to the PR being from a fork.
In terms of previewing the content locally, could you confirm how you've configured your local environment? In the interim, one way to take a look at the preview content is to display the rich diff in the PR. I've attached a screenshot of what the button looks like (apologies for my shaky circle!). Let me know if that helps. :)

Thank you @gracion! :tada:

Justine,
I found the rich diff button in the PR, nice!  Plus, I realized the file view shows the rendered document with changes applied.
Thanks for asking. My local environment is adequate for docs updates. I'm configured for macOS and iOS application development, which is my actual job. Later, if I rise to the level of executable code PRs, I'll take another look at my environment, but no need to change anything at this point.
Best regards from smoky Oregon, USA
--Paul Collins

On Sep 8, 2020, at 12:01 AM, Justine Geffen<EMAIL_ADDRESS>wrote:
Thank you, @gracion https://github.com/gracion!
In terms of previewing the content, there is a preview server that spins up with every pull request but I see the deployment failed. I made some changes to your PR and committed them as that usually resolves the problem. In this case it didn't so I will have a chat with the DevOps team. It may be related to the PR being from a fork.
In terms of previewing the content locally, could you confirm how you've configured your local environment? In the interim, one way to take a look at the preview content is to display the rich diff in the PR. I've attached a screenshot of what the button looks like (apologies for my shaky circle!). Let me know if that helps. :)
https://user-images.githubusercontent.com/4223530/92443490-d566a200-f1b1-11ea-8fdb-a4c1d334f864.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mattermost/docs/issues/1295#issuecomment-688662249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHFWAJINOGXSHLKHKNNJGTSEXJE7ANCNFSM4DQ7TMVA.

Oh I'm glad that worked! I mainly wanted to find out your local doc environment in case you were having an issue with make html. :D But definitely no need to change anything - especially if the rich diff works. :) Thanks again for the PR!

@thawn
I've been struggling with this problem all day.
I updated httpd to 2.4 and did everything possible, but it didn't work.
I solved it this way, thank you sooooooooooooooo~ much.

@thawn I've been struggling with this problem all day. I updated httpd to 2.4 and did everything possible, but it didn't work. I solved it this way, thank you sooooooooooooooo~ much.

Thanks for letting us know, @tkyoon! I have reopened this issue so that we can ensure the docs are updated appropriately. Would you be open to updating the docs with this content?

@justinegeffen  I just followed as https://docs.mattermost.com/configure/config-proxy-apache2.html.
thanks 😊

I'm trying to install MM using docker-compose behind an apache proxy, but I dont find the config.json that I should  change the "ListenAddress": "localhost:8065" as suggested above. Does that not apply to docker installation?

Also, I am following the same instructions for the apache reverse proxy and created a .conf for port 80,  but is there anything I need to change in the ssl.conf after I run certbot to force https connection (port 443)? I am not sure when I need to make the "ws" to "wss" change.
but I am a bit lost about when to change the "ws" to "wss".


Add a proper full example to using the easy-scpi library to make it "easy"

Your example in the readme is confusing for beginners who don't know about VISA.
What should "<port>" look like in
# Connect to an instrument
inst = scpi.Instrument( <port> )

e.g I have a device I want to talk scpi comms to over tcp/ip on ip address <IP_ADDRESS> port 5025.
Trying these all fail:
inst = scpi.Instrument( "<IP_ADDRESS>:5025" , read_termination='\n', write_termination='\n')
inst = scpi.Instrument("<IP_ADDRESS>", read_termination='\n', write_termination='\n')
inst = scpi.Instrument("TCPIP0::<IP_ADDRESS>::5025::SOCKET", read_termination='\n', write_termination='\n')

What is a concrete example for the value ?
I eventually found that this worked:
inst = scpi.Instrument(read_termination='\n', write_termination='\n')
inst.rid="TCPIP0::<IP_ADDRESS>::5025::SOCKET"

Can you add an explanation to setting the rid in the readme if this is the correct connection method for tcp/ip case or explain the scpi.Instrument( <port> ) better.

Thank you for the suggestion. I'll get around to this when I can, but am quite busy these days so don't know when that will be. If you're up for it, you can create a PR and either add an examples folder or add it into the README.


Allows creation a Multi with an emitter and a buffer size

At the moment, you can create a Multi from an emitter but you can only configure the back pressure strategy. When using "buffer", it uses the default buffer size. We should allow configuring the buffer size.
Now, the question is what happens if the buffer reaches its full capacity:

should the sender be informed (throwing an exception) - the event is dropped
should the downstream be informed, and so no more event would be received
all the above

Going with (1) as with it, the producer can decide what needs to be done (send a failure, completion, wait until there is more requests).

Actually, the async and serialized nature of the emitter does not allow throwing an exception, as it may be thrown from another thread. So, going with 2).
Fortunately, for 1) the caller can check if the amount of request is greater than 0.


Does not gracefully handle nested links

Grab the .md from here: https://raw.githubusercontent.com/daohu527/awesome-self-driving-car/master/README.md
The component will throw an error to console: Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>.
Not sure what's required to fix it, but you have the info :)

Note, if anyone else gets this issue, it can be fixed externally via:
const hasNestedAnchors = (element, depth = 0) => {
  const { tagName, children } = element;

  if (children === undefined || (tagName !== "a" && depth === 0)) {
    return false;
  }

  if (depth > 0 && tagName === "a") {
    return true;
  } else {
    for (const child of children) {
      if (hasNestedAnchors(child, depth + 1)) {
        return true;
      }
    }
    return false;
  }
};

and then pass that into MarkdownPreview like so:
<MarkdownPreview allowElement={element => !hasNestedAnchors(element)} />


Unable to update using deb.goaccess.io - unmet dependency

Hello,
I am getting this error when trying to update:
The following packages have unmet dependencies:
goaccess : Depends: libssl1.0.0 (>= 1.0.0) but it is not installable
E: Unable to correct problems, you have held broken packages.

libssl1.0.2 is installed. There is no libssl1.0.0 available to install to get around this.
Thanks,
Terry

Hi,
same here, on debian stretch
Best regards

Hi,
same here, Debian Stretch (9.4). I have both "libssl1.0.2" and "libssl1.1" packages installed and up to date.

I confirm, "goaccess: Depends on: libssl1.0.0 (> = 1.0.0), but it is not installed"
ii libssl1.0.2: amd64 1.0.2l-2 + deb9u3
ii libssl1.1: amd64 1.1.0f-3 + deb9u2

confirmed. same issue installing from the official Debian goaccess repo.

I can confirm this, I need to build this package again.

confirm
fresh installed debian 9
try to install goaccess with this man
https://goaccess.io/download#official-repo
# aptitude install goaccess
The following NEW packages will be installed:
  geoip-database{a} goaccess{b} libgeoip1{a}
0 packages upgraded, 3 newly installed, 0 to remove and 0 not upgraded.
Need to get 2,544 kB of archives. After unpacking 8,272 kB will be used.
The following packages have unmet dependencies:
 goaccess : Depends: libssl1.0.0 (>= 1.0.0) which is a virtual package and is not provided by any available package

The following actions will resolve these dependencies:

     Keep the following packages at their current version:
1)     goaccess [Not Installed]

# aptitude search libssl1
p   libssl1.0-dev                                                               - Secure Sockets Layer toolkit - development files
i   libssl1.0.2                                                                 - Secure Sockets Layer toolkit - shared libraries
p   libssl1.0.2-dbg                                                             - Secure Sockets Layer toolkit - debug information
i   libssl1.1

This should be resolved. Please give this a shot per this instructions and let me know if that solves the issue from your side. Thanks!

Ok for me, thank you!

Great! Closing this.


upgrade kustomize and other tools

the kustomize 3.8.7 and other tools doesn't support Macbook M1, we need to upgrade them.

goreleaser 1.6.3 need golang 1.17, goreleaser 1.7+ need golang 1.18

controller-gen can only upgrade to 0.6.2, because generated deployment.yaml with version 0.7.0 doesn't have conditions in CR, and can't work well


How to avoid reset after losing focus? [QUESTION]

Hello, and thanks for the great widget.
I have three tabs on a flutter web widget (within a scaffold/tabcontroller). Every tab hosts an HtmlEditor with its onw controller. Whenever I switch between tabs, the context of the editor gets lost and the initial value is restored (the widget is redrawn). Can I save the content and set the initial value on losing focus or is it possible to simply keep the changes cached? I had a look at the callbacks already and the settext methods, but I could not find any solution that suited my needs.
Your help would be greatly appreciated.
Thanks, casysso

Web has been very finnicky to use because of how the editor iframe rendering is handled by Flutter at the moment. Question - are you running your app with the --web-renderer=html flag?

Closing this for now... Please keep following https://github.com/flutter/flutter/issues/80524 for updates on a fix.


Refactor consensus tests

This PR addresses various minor "we should eventually do X" comments that accrued on past PRs affecting the test-consensus tests.
Overview of changes:

The argument record changes eliminate some noise and improve some signatures.
The indentation changes are mostly for legibility and consistency.
I also improve the names of test trees, for example.
I renamed *.Dynamic.* to *.ThreadNet.* -- please suggest a better term if you have one.

@mrBliss Would you like to see that first commit broken up? (It's the raw result of me figuring out where I wanted to end up.) If so, any broader course corrections to address before I do that? Thanks.

bors r+


roles and responsabilities

roles and responsabilities is a subject we also mentioned in the expert-interviews. In the attached google docs is a first summary for oemof.
Many of the roles can be joint but they should be formulated one by one so that it is easier to change the responsability for them or to puzzle them in different ways.
Feel free to comment.
https://docs.google.com/spreadsheets/d/1SMXyg7AzyGClsXqBxuRUm9RtbwOfirLsak6_Btq9V8A/edit?usp=sharing

closing this together with https://github.com/OpenEnergyPlatform/organisation/issues/1


Refactoring

Hello,
I evaluated the most popular image pickers on GitHub and I quite like your QBImagePicker. However, I'm in a context where I can't use a view controller which revealed a design flaw (which all of the other libraries have as well btw): there's way too much logic in the view controllers. A lot of the heavy lifting of requesting and managing the albums and photo details should be done in separate components which are then used by the view controllers. This would lead to a higher modularization and the components would be usable without the view controllers (for example a photo grid view could be simply embedded in another view).
If you agree, I'd be willing to work on a PR. Please let me know what you think asap, as I'm in need of a decision if I should fork or contribute.
Thanks!

I would personally vote for this!


Fix query bug

Task/Issue URL: https://app.asana.com/0/414730916066338/675239971772914
Description:
Fixes issue where queries e.g http://duckduckgo.com?q=test display full url rather than just "test" query part in the omnibar.
Steps to test this PR:
TEST 1:

Submit a query e.g "test" in the app
Ensure that only test appears in the omnibar

TEST 2:

Enter a full (non ddg) url e.g http://www.bbc.co.uk
Ensure the full url is displayed in the omnibar

Internal references:
Software Engineering Expectations
Technical Design Template

Thanks for the review!


chore: Update deploy_build_artifact.yaml permissions and artifact path

Summary by Sourcery
This pull request updates the deploy_build_artifact.yaml workflow by adding a 'workflow_dispatch' trigger, adjusting the artifact path in the 'upload-artifact' step, and modifying the 'publish release' step to include the bundle path in the artifacts.

CI:

Added 'workflow_dispatch' trigger to the deploy_build_artifact.yaml workflow.

Deployment:

Updated artifact path in the 'upload-artifact' step to only include 'dist/*'.
Modified 'publish release' step to include the bundle path in the artifacts.

This is an experiment review for experiment improve_review_guide
Run ID: improve_review_guide/run_2024-08-12T01-25-21_v1-21-0-75-g76dae36a2
The benchmark review for this pull request can be found at https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/19.
This pull request was cloned from https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: false
    enable_security_comments: false
    enable_tests_comments: false
    enable_comment_suggestions: false

    enable_claude_comments: true
    enable_functionality_review: false

    enable_pull_request_summary: false
    enable_review_guide: true

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_area_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      functionality_model: benchmark
      overall_comments_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: llm

# The pull request dataset to run the experiment on
pull_request_dataset:
  # open-source PRs
- https://github.com/sourcery-ai-experiments/gpt-crawler/pull/1
- https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/1
- https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/2
- https://github.com/sourcery-ai-experiments/iptux/pull/5
- https://github.com/sourcery-ai-experiments/iptux/pull/6
- https://github.com/sourcery-ai-experiments/kalima/pull/3
- https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1
- https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/2
- https://github.com/sourcery-ai-experiments/Trenova/pull/11
  # Sourcery PRs
- https://github.com/sourcery-ai/core/pull/4055
- https://github.com/sourcery-ai/core/pull/4263
- https://github.com/sourcery-ai/core/pull/4352
- https://github.com/sourcery-ai/core/pull/4364
- https://github.com/sourcery-ai/core/pull/4366
- https://github.com/sourcery-ai/core/pull/4390
- https://github.com/sourcery-ai/core/pull/4402
- https://github.com/sourcery-ai/core/pull/4445
- https://github.com/sourcery-ai/core/pull/4462
- https://github.com/sourcery-ai/core/pull/4463

review_comment_labels: []

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4463
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/236
- dataset_pull_request: https://github.com/sourcery-ai-experiments/gpt-crawler/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/gpt-crawler/pull/10
- dataset_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/5
  review_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/32
- dataset_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/iptux/pull/33
- dataset_pull_request: https://github.com/sourcery-ai-experiments/kalima/pull/3
  review_pull_request: https://github.com/sourcery-ai-experiments/kalima/pull/17
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4055
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/258
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4263
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/259
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4352
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/260
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4364
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/261
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4366
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/262
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4390
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/263
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4402
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/264
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4445
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/265
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4462
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/266
- dataset_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/23
- dataset_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/graphviz2drawio/pull/24
- dataset_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/19
- dataset_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/2
  review_pull_request: https://github.com/sourcery-ai-experiments/pydantic_tfl_api/pull/20
- dataset_pull_request: https://github.com/sourcery-ai-experiments/Trenova/pull/11
  review_pull_request: https://github.com/sourcery-ai-experiments/Trenova/pull/19


Remove unnecessary args in goveralls

I met this error in travis-ci.
$ $GOPATH/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN
flag needs an argument: -repotoken
...
The command "$GOPATH/bin/goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN" exited with 2.

Resolution
$COVERALLS_TOKEN is not necessary.
c.f. Docs

For a public github repository, it is not necessary to define your repository key (COVERALLS_TOKEN).

In other ways, add = like this.
maybe, it works.

before:	-repotoken $COVERALLS_TOKEN
after:	-repotoken=$COVERALLS_TOKEN

This change is

Coverage remained the same at 59.027% when pulling a1001b999510e0fb617e624c6a281925e6190dfa on yyoshiki41:fix/goveralls into 86c6f29e928613af618cc7e1a47b5172cf0532a1 on grafov:master.

Thanks, and agreed, I don't have this token on my other services either.

@yyoshiki41 thank you for the explanation.

👍


no effect on long clicks on links (mobile)

On Firefox for Android, if you long press a link that should be modified and open in a new tab, the url isn't modified like it should.

Add a listener for 'contextmenu' events.

fixed as of build 1.3


[WIP Y2K-510] Push Prompt as modal

Tested on Android, needs testing on iOS.
cc @keybase/y2ksquad

Ready for another look.


I cant save progress.

I cant save progress if i use for example free chest or shop bypass.
Does anyone know how to fix it? When i am saving it it just keeps on saying backup failed.

thats just the gd servers tends to have more people saving than expected

thats just the gd servers tends to have more people saving than expected

ye but for me its different i can save progres in normal gd but with this mod i can not

Just try to save multiple times until it saves

It works for me

Or you can in the options set textures to medium graphics.

I tested it, its works!


Private Mint shows the same TXID for every mint output

For example, in the following image I have one mint transaction of 78 XZC, with 6 mint outputs - 3x25 and 3x1.

To only show the same txid once, or show output information for each mint, eg.
vout - 0
mint - 25

etc.

Additionally the tooltip and the Detail column shows the wrong number of confirmations (Current block number plus 1)


Crash if Bulwark's Ambry Runs out of space to spawn enemies

Describe the bug
I was playing a fairly slow deck built around duplicating powers and building up poison/modded poison, so I wasn't really killing the elites quick enough.  When there were 3 of the spire spear/shield, the Ambry tried spawning another pair, which fully locked up not just the game, but the monitor the game was running on.

If that doesn't cause the crash, kill only one of them.
If that doesn't work, then use the attached save file and mod list, play it until you have 4 of the act 4 elites, and then don't kill them.  I'm afraid I don't remember the exact order I played cards in.

Expected behavior
The Ambry should just not spawn more elites if it can't, or maybe add a queuing system to spawn extra elites as soon as one dies.
Screenshots

A few hundred or thousand lines above this was a java.lang.StackOverflowError.
Additional context
Windows 10, STS V2.3.4
Mod List
AKDream's More Relics 1.5.1
BaseMod 5.53.2
Bossy Relics 0.9.2
Chimera Cards 1.0.2
Hug You Relics 1.2.42
More Stackable Relics 2.4.4
One Hundred Relics 1.0.0
Relic Stats 1.2.2
Risk of Relics 2.3.6
StSLib 2.11.0
Stackable Relics 1.3.6
Terraria Relics 0.1.1
Shop Mod 1.1.2
Spire Biomes 1.3.0
Aspiration 1.9.5
Bundle of Bundles 5.4.2
Bundle of Content 1.6.2
Bundle of Food 2.1.6
Card Mastery 1.0.1
Energized Spire 1.16.0
Ram Saver 0.2.1
Reliquary 0.5.3
I checked the mts_process_launch.log, then made the mistake of opening the game to get the version numbers, which reset the log.  I've attached the SlayTheSpire.log, but it ends before the crash.  I think the only thing missing is the crash message, which is pretty well represented by the screenshot.
I tried replaying the game to generate a new log, but I beat the Ambry and realized 2 seconds later, "Wait, I was supposed to be not killing it for the crash log."  I've attached the .run file in case it helps.
SlayTheSpire_202401290455_1.log.zip
1706511705.zip

Rats, I thought I had fixed this a while ago. I'll see what I can do.

should be actually fixed now? Thanks for the report!


Ensure email subsciptions use taxon_tree instead of taxons

If using the 'taxons' key when creating email signups, subscribers
will only receive emails tagged to that particular taxon.
What we want instead is that subcribers receive emails tagged to
the specified taxon and all its children
This change uses the 'taxon_tree' tag instead of the 'taxons'
tag so find/create subscriber lists, which will enable this.

Is there another thing to update existing taxon email subscriptions to do this?

Is there another thing to update existing taxon email subscriptions to do this?

No. But that does need to be written - I thought in a new PR. fix this issue first and then the bad data.


NameError: name 'BRICSDecompose' is not defined

Configuration:

RDKit Version: 2<IP_ADDRESS>
Operating system: Mac OS Catalina
Python version (if relevant): 3.7.6
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? rdkit
If you are not using conda: how did you install the RDKit?

Description:

I tried the code from https://www.rdkit.org/docs/source/rdkit.Chem.BRICS.html. When it came to the step: res = list(BRICSDecompose(m)), it gave: NameError: name 'BRICSDecompose' is not defined.

from rdkit import Chem
m = Chem.MolFromSmiles('CCCOCc1cc(c2ncccc2)ccc1')
res = list(BRICSDecompose(m))

That function is defined in the module rdkit.Chem.BRICS, which you need to import

Oh yah! Silly me, thanks! :D


Front Admin - get connected user informations for the "logged user widget"

The logged user widget in the sidebar should display the current logged user informations (firstname - lastname)

this was developped


Add your personal signature to cover letter

Is your feature request related to a problem? Please describe.
Feature suggestion, not a bug:
Maybe this is a personal thing, but I like to write my signature in the cover letter closing. Therefore I tried to integrate it with a \includegraphics of \usepackage{graphicx} in my personal modification of moderncv.
Could look like this:

Describe the solution you'd like
I would be glad if we could discuss the signature feature in the cover letter and if this would be an idea for upstream.
Describe alternatives you've considered
Alternatively I also can leave it in my fork and we do not need to push it upstream - it is just a suggestion.
Additional context
I already tried to create a minimal viable solution in my moderncv fork.
Feel free to have a look at it: https://github.com/LLdaniel/moderncv_mod/tree/feature/signature-coverletter.
I am currently working on my branch to make the signature optional. Maybe I should create a pull request after that change?

An option to load a signature from a image should be fine. I would not consider a PR before that change is implemented.
My reasoning (story time):
The traditional approach (in the days of yore), which I would say is implicit in the current letter, is to print (or type!) the letter and then manually sign (N.B. blue ink in the post-fax machine, pre-color scanner and printer world) the finished product before mailing it off.
With the advent of electronic submission, my general impression has been that the typed format has remained, specifically the space to add a manual signature to a hard copy is preserved.
Optionally overriding that space with a graphic seems like a reasonable option.

That sounds good I also like your story and have to admit: The prettiest solution is a handwritten signature in blue ink. 👍
But for electronic submissions we maybe could use the next best solution and offer the signature as a picture.
I would like to work on that idea and will present a possible solution soon! (Currently it is a good time for me to do so, because I am updating my cv anyway 😅).

Fixed by #157, so probably good to close

Yes, this issue has no pending to dos left after the merge. Therefore I close it.


Can't launch Foobar on Windows if path contains Japanese

Environment

OS version: Windows
Elona Foobar verision: v0.2.5

How to reproduce

Rename the folder's name which contains executable to some Japanese word(or including non-ASCII characters).
Launch ElonaFoobar.exe.

Cause
Maybe, Lua MOD engine cannot handle non-ascii filepath.

As far as I can understand, this isn't possible with stock Lua. luaL_loadfile takes a standard char* and has no awareness of wchar_t, so it simply cannot load filenames encoded with UTF-16. You'd have to apply a patch to get wchar_t support like https://bitbucket.org/doub/electronmeat/src/tip/srcweb/lua-5.1.4/lua-wstring.patch, but I would really like to avoid such a thing if possible.

Here is the same issue with opencv. Once again, the solutions were either to patch the code or use Windows APIs instead of opencv to open and read the file.

I agree with limiting filename of user-created contents such as save folder names, mods and graphic/sound packs.
However, this problem occurs if a user names his account with non-ASCII characters and place Elona Foobar in his/her download folder, i.e., C:\Users\{user name containing non-ascii}\Downloads.
I don't want to make players rename the account, create a new account, or place another folder consisting of ASCII characters.
If there are no solution except for applying patch to Lua itself, we should do that because Elona has been played mainly in Japan, using non-ASCII characters mostly.
Tasks

Apply patch to Lua in order to accept UTF-16 filepath.
Change naming convention of save file. Currently, sav_{player name}.
Delete any filepath containing non-ASCII characters from save data completely. It means we must store all filepath as relative.


Litecoin.conf

Hi @blackmennewstyle Sir:
            Thanks for your support!

In litecoin.conf file there is a portion called daemons which is used to connect the  node like below
"daemons": [
{
"host": "<IP_ADDRESS>",
"port": 9332,
"user": "user",
"password": "password"
}
]
here  user & password is the rpc user & password . But Sir in my litecoin node  password is set for fund transfer. So if pool wants to send LTC reward from pool wallet to miner wallet, pool needs that password. So how  can we set that node password in litecoin.conf file?
Thanks in advance!

@blackmennewstyle Sir:
Any help..

Sorry for the late reply,
Everything is in the code. You should modify that section:
"paymentProcessing": {
        "walletPassword": "password",
        "enabled": true,
        "minimumPayment": 0.5,
        "payoutScheme": "PPLNS",
        "payoutSchemeConfig": {
          "factor": 2.0
        }
      }

Hi @blackmennewstyle  Sir.. many Thanks four support.


Request for Debug to handle missing extension from configuration

I'm developing in a remote .NET dev container. Due to some custom config, I noticed I didn't have the C# extension installed in the container, and when I tried to run my code, I got the error Configured debug type coreclr is not supported.

Upon discussion with @chrmarti, I learned launch.json has a debug configuration that may have been created when the C# extension was installed locally, and that debug configuration requires the C# extension:

Perhaps Debug could handle this case better, such as recommending the right extension based on that identifier.

/fyi @isidorn (since this might otherwise be closed unseen by the feature workflow)

@bamurtaugh debug is not aware of what extension contributes what debug type.
The general solution to this problem could be the following:
When a launch.json is opened if we detect that there is a type "coreclr" we recommend the C# extension to the user to install. Same for python and other languages...
Let me know if you are interested in looking into this and I can provide some code pointers.

@isidorn Thank you for the insight. That solution sounds interesting since the current error prompts users to open launch.json, so recommending the appropriate extension when launch.json is opened could work.
I would be interested in looking into this- if you'd like to follow-up here or offline, any code pointers would be great.

Upon further pondering, here's how I think this could work.
Code pointer https://github.com/microsoft/vscode/blob/1cba068f10d5175c286f43aa6ad33985aee39abd/src/vs/workbench/contrib/debug/browser/debugService.ts#L431
This is the error when the debug type is not supported.
In the showError call you can pass additional actions, and one of the actions which you should pass would be "Install Debug Extension" which would simply open the extensions view and filter by tag:debuggers @sort:installs. Same as "Run > Install Additional Debuggers" does. Code poitner for that action just as inspiration https://github.com/microsoft/vscode/blob/1cba068f10d5175c286f43aa6ad33985aee39abd/src/vs/workbench/contrib/debug/browser/debugCommands.ts#L486
We do not want to hard code an exact list into our source code that coreclr should be handeld by C# extension since then we would have to manage that list. I think the approach that I propose is general enough and might help users.
Let me know what you think, and feel free to create a PR and I can provide more feedback if needed. Thanks

I appreciate the great insights and code pointers @isidorn! I believe a button to prompt users to view and install debug extensions they are missing would be a positive step. It makes sense we wouldn't want to maintain a hard coded list of certain extensions and rather keep it more general.
I have created a PR with your approach in mind, and it would be great to get your feedback: https://github.com/microsoft/vscode/pull/103891.

Adding label verification-needed so we verify this during the endgame.
Thanks!


survey successful completion should redirect to next experiment

give the user choice to redo or save, etc.


API Report - Instantiate / load rotor model

This issue comes from breaking issue #195 in smaller issues.
The class Report from api_report.py should receive a rotor as input. At first, there're two ideas:

instantiate a rotor through rotor_assembly and run the API parse from it;
load a previously saved rotor.

I don't think the attributes of the rotor object should be incorporated into the class Report. They should be kept separated. But this can be discussed to find the best solution.

PR #206 closes this issue


Don't grab input in KOReader by default.

I've added a warning message on install if it detects that Oxide is installed. I tested the logic on device. This doesn't handle showing a warning when Oxide is installed after KOReader though.


[Feature]  add annotations for oap.service (skywalking-kubernetes )

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
add annotations for oap.service  just like ui.service.annotations
Use case
When opa.service.type is set to loadBalancer, you need to customize the loadBalancer by setting annotations, just like ui.service.annotations. It's a bit strange why didn't add annotations support?
oap:
  name: oap
  image:
    tag: 8.9.1
  storageType: elasticsearch
  replicas: 2
  service:
    type: loadBalancer
    annotations:
      service.beta.kubernetes.io/alibaba-cloud-loadbalancer-id: "lb-bp16j1jvwlwxxxxxxx"
      service.beta.kubernetes.io/alibaba-cloud-loadbalancer-force-override-listeners: "true"

Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's a bit strange why didn't add annotations support?

I think you didn't follow how community works. There is nothing like why not. The features only exist if something contributed it. That is all.
So, if you feel something is important, write a pull request with a proposal about the use case.


Customize resizing css

is it possible to customize this ?

okay i get now, im gonna close this one ,sorry for the inconvenient  thanks


Always return single object

I have a db.json like the example below.
I want to run queries like ´´´http://localhost:3000/post?slug=/contact´´´ which always return one object (i.e. I know slug will be unique).
However, by json-server always returns an array with just 1 object in the array.
Is there a way to achieve this?
"post": [
    {
      "post_id": 5,
      "slug": "/",
      "template": "home",
      "content": {},
      "meta": {}
    },
    {
      "post_id": 10,
      "slug": "/contact",
      "template": "contact"
    },
    {
      "post_id": 15,
      "slug": "/training",
      "template": "training"
    }
  ]

Hmm, except if you use the project as a module, there's no way to.
Another way would be to use the id property though:
"post": [
    {
      "post_id": 5,
      "id": "home",
      "template": "home",
      "content": {},
      "meta": {}
    },
    {
      "post_id": 10,
      "id": "contact",
      "template": "contact"
    },
    {
      "post_id": 15,
      "id": "training",
      "template": "training"
    }
  ]

GET /post/home -> { post_id: 5, template: 'home', ... }
GET /post/contact -> { post_id: 10, template: 'contact', ... }
...

Thanks for your response. Let me see if we can work like this.

It's easy enough to work around, but a proper solution would be great.

HI, look at this solution -> https://github.com/typicode/json-server/issues/541


[1349] Show subjects in alphabetical order, one per line

Context
Subjects aren't ordered alphabetically on the course page. They also aren't shown one per line.
Changes proposed in this pull request
Show subjects in alphabetical order, and one per line.
Guidance to review

 Basic details page: tweak how subjects are displayed


Module ngx_pagespeed requires the pagespeed optimization library

Hi @VirtuBox,
Thanks for your awesome Ubuntu Nginx web server guide.
I have issue with pagespeed modules.
Currently I use Ubuntu 16.04 with 6GB ram and 6 CPU core.
root@srv:~# ./nginx-build.sh
EasyEngine installation detected

Welcome to the nginx-ee bash script.

Do you want to compile the latest Nginx Mainline [1] or Stable [2] Release ?
Select an option [1-2]: 2

Do you want Ngx_Pagespeed ? (y/n)
Select an option [y/n]: y

Do you want to build the latest Pagespeed Beta [1] or Stable [2] Release ?
Select an option [1-2]: 2

Do you want NAXSI WAF (still experimental)? (y/n)
Select an option [y/n]: n

Do you want RTMP streaming module ?
Select an option [y/n]: n

       Installing dependencies                [OK]
       Downloading additionals modules        [OK]
       Downloading zlib                       [OK]
       Downloading brotli                     [OK]
       Downloading openssl                    [OK]
       Downloading pagespeed                  [OK]
       Downloading nginx                      [OK]
       Applying nginx patches                 [OK]
        Configuring nginx    [FAIL]           [..]

Please look at /tmp/nginx-ee.log

/tmp/nginx-ee.log
adding module in /usr/local/src/incubator-pagespeed-ngx-latest-stable
mod_pagespeed_dir=/usr/local/src/incubator-pagespeed-ngx-latest-stable/psol/include
build_from_source=false
checking for psol ... not found
./configure: error: module ngx_pagespeed requires the pagespeed optimization library.
Look in /usr/local/src/nginx/objs/autoconf.err for more details.

A new release of nginx-ee is available, issue with pagespeed should be fixed.

Nginx ee was compiled successfully!
Is perfectly working now. Thanks @VirtuBox

Hello,
Some developers said pagespeed  does not work well, and it would be great if you like to share the really performance or your evaluation here or by an article.
Thanks


Make code runnable in docker with hardcoded data

As we are waiting for #3, we should be updating data_collection module so that it can run without mysql dump of original Stack Overflow data.

After running the docker, entering into interactive mode , we can simply run the following command inside 'source' directory:

python3 data_collection.py

It should provide a similar data (exact content may vary, sometimes the output can be empty even).

21-Oct-22 00:37:10 - Started program: data_collection.py
1   'I''ve seen questions like this come up before, and the general consensus is that Jackson is much faster than Gson.
2  Gson
Replace standard Android JSON parser for better performance?
http://www.cowtowncoder.com/blog/archives/2009/12/entry_345.html
https://stackoverflow.com/questions/338586/a-better-java-json-library
Here is one which specifically discusses Android: http://ubikapps.net/?p=525
'
3  I know there're many libs(Gson,Jackson...) can do this, can you give me some instructive ideas on how to write this by myself?


small bug - label frames not working with run.py

Desktop (please complete the following information):
os: windows 11
Describe the bug
When I'm using multiple python files and linking them with 'run.py' when the user opens a different py file through the GUI using 'run.py,' the inside of the label frames change to white from the theme background color. When you run the program directly from the file, the program and GUI run fine.
To Reproduce
No response
Expected behavior
When the user moves from one GUI to another using the run.py function, the GUI should look how it does when you run it directly from the python idle.
Screenshots
No response
Additional context
No response

can you please provide a minimal reproducible example.


pgBackRest stanza not created when first attempt fails

In  be50aa829932c04c1a3886b37099e6d2638fa009 we skipped stanza creation if we are a replica,
however, this means that if the initial stanza was never created, it will never be retried.
We need to recreate the stanza at some point if needed.

This should be fixed with https://github.com/timescale/timescaledb-kubernetes/releases/tag/v0.6.1


Updated: schools.php, school_details.php, css/, images/

The schools.php will now open the school_details.php file in a new tab
The minor additions to the main.css are included in this request
To make sure the images used in schools.php and school_details.php match the code I did a drag and drop of the entire images directory.

Merging changes for schools.php, adding school_details.php, and changes in ./images and ./css

Was intending to create a pull to our fork from my branch, pull to primary not needed at this time.


Adding sputtering yield data

Digitized plot data for sputtering yields of Tungsten (W) by bomburdment of Hydrogen (H), Deuterium (D), Helium (He) and Carbon (C).

Those files are in binary format. Please erase them and upload a normal ASCII .csv

Please stop uploading binary files.

Please add a header with units


Moving the window with title bar tabs is hard

I like the tabs in the title bar. However, the area where I can move the window is too small:

Compare this with Edge/Chrome where the entire area not used for tabs can be used to move the window around:

Yes, this is a major issue for me.

#1375

Duplicate of #564?


Errors while trying to use Eta library

Describe the bug
I was trying to migrate from Squirrelly to Eta, but I can't use this library at all. After following the instalation steps and importing the library I got some errors.
To Reproduce
Steps to reproduce the behavior:

yarn add eta
import * as Eta from 'eta'

Expected behavior
Be able to use the library methods and properties
Screenshots

Package & Environment Details

Environment: ex. Node
Version: ex. v14.18.0

Hello sir! It feels like a webpack error, I had these errors when compiling to browser environment on the past and I solved it just adding this on my webpack config:
module.exports = {
  //...
  resolve: {
    alias: {
      'browser': false,
//   'fs': false // consider adding this if not working also
    },
  },
};

Hello sir! It feels like a webpack error, I had these errors when compiling to browser environment on the past and I solved it just adding this on my webpack config:
module.exports = {
  //...
  resolve: {
    alias: {
      'fs': false,
//   'browser': false // consider adding this if not working also
    },
  },
};

(but consider taking a look at https://stackoverflow.com/questions/43037590/field-browser-doesnt-contain-a-valid-alias-configuration for a normal solution)

Nice thanks @gitBaiano !!! It works like a charm.
I had to add path, fs in the alias field as you suggested.
Thanks!


the GSI non mandatory field is not working in mock

Describe the bug
Please refer to following @model. Please note the 3rd @Key ByBillingStatus. When I try to run a query against the same I get an error that - index not found in mock. Not sure if this is a mock only issue or is this by design and will be a problem in the real DynamoDB. Per the documentation of DynamoDB one can create a GSI on fields that could be null. So I am not sure what is the problem here. Also, I would really like the GSI to be on an enum. But I am not sure if this is possible as GSI needs to a Scalar object. I am new to AppSync so I appreciate any guidance here.
type Tenant @model (subscriptions: null)
    @key(name: "byPublicFriendlyName", fields: ["companyPublicFriendlyName"], queryField: "TenantByPublicFriendlyName")
    @key(name: "byRegisteredName", fields: ["companyRegisteredName"], queryField: "TenantByRegisteredName")
    @key(name: "byBillingStatus", fields: ["billingStatus"], queryField: "TenantByBillingStatus")
    @key(name: "byBillingStatusByCreatedDate", fields: ["billingStatus","createdAt"], queryField: "TenantByBillingStatusByCreatedDate")
    @auth(rules: [{allow: groups, groups: ["SysAdmin", "Sysops","SysSupport"], operations: [create,read,update,delete]},
                  {allow: groups, groupsField: "groupsCanAccess", operations: [read]},
                  {allow: groups, groupsField: "groupsCanEdit", operations: [read,update]},
                  {allow: private, provider: iam, operations: [create,read,update] }
                  ]) {
  id: ID!
  companyPublicFriendlyName: String!
  companyRegisteredName: String!
  dataLocations: [DataLocation] @connection(keyName: "byTenantIDByCreatedDate", fields: ["id"])
  dataLocationKeys: [DataLocationKey] @connection(keyName: "byTenantIDByCreatedDate", fields: ["id"])
  jobDefinitions: [JobDefinition]  @connection(keyName: "byTenantIDByCreatedDate", fields: ["id"])
  billingReference : String
    @auth (rules: [ {allow: groups, groups: ["SysAdmin", "Sysops","SysSupport"], operations: [create,read,update,delete]},
                    {allow: private, provider: iam, operations: [create, update] },
                    {allow: groups, groupsField: "groupsCanAccess", operations: [read]} ])
  ## billingStatus: TenantBillingStatus # The GSI only works with Scalar hence changed to String
  billingStatus : String
    @auth (rules: [ {allow: groups, groups: ["SysAdmin", "Sysops","SysSupport"], operations: [create,read,update,delete]},
                    {allow: private, provider: iam, operations: [create, update] },
                    {allow: groups, groupsField: "groupsCanAccess", operations: [read]} ])
  createdAt : AWSDateTime
  groupsCanEdit : [String]
  groupsCanAccess : [String]
  owner: String
}

Amplify CLI Version
4.13.4
To Reproduce
Just take the above @model and try to run a query on byBillingStatus
Here is the error that I received
Error while executing Local DynamoDB
{
    "version": "2017-02-28",
    "operation": "Query",
    "limit": 10,
    "query": {
        "expression": "#billingStatus = :billingStatus",
        "expressionNames": {
            "#billingStatus": "billingStatus"
        },
        "expressionValues": {
            ":billingStatus": {
                "S": "NOT_CONFIGURED"
            }
        }
    },
    "index": "byBillingStatus",
    "scanIndexForward": true
}
{ ValidationException: The table does not have the specified index: byBillingStatus

Expected behavior
ByBillingStatus query should work. Ideally, I would like the ability to query on the field type enum and not change to String.
Screenshots
Desktop (please complete the following information):

Amazon Linux
Node Version. v10.16.2

Hello @arkllc did you add @key after creating @model initially in mock? If so please view this comment below
https://github.com/aws-amplify/amplify-cli/issues/2210#issuecomment-528568831
Currently there is a draft pr that is up and pending review: https://github.com/aws-amplify/amplify-cli/pull/2301
Closing this issue as a duplicate.


ISPN-3550 Allow overriding the TimeService in child classes

This is a small change, needed for the Cassandra cache store testsuite.

Pushed, thanks


fix Fix not check if the tablet is nullptr (#26015)

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

#26015


Errors for method = "ml"

library(bdfm)
m1 <- dfm(cbind(fdeaths, mdeaths), method = "ml") #multivariate example
#> Error in dfm(cbind(fdeaths, mdeaths), method = "ml"): Mixed freqeuncy models are only supported for Bayesian estimation
m3 <- dfm(fdeaths, method = "ml") #univariate example
#> Error in dfm(fdeaths, method = "ml"): Mixed freqeuncy models are only supported for Bayesian estimation

Created on 2019-03-06 by the reprex package (v0.2.1)

duplicate of #38

Probably not the same, but method = "ml" is not working:
library(bdfm)
dfm(mdeaths, method = 'ml')
#> Error in DSmooth(B, Jb = Jb, q, H, R, Y = Ydm, freq = rep(1, k), LD = rep(0, : Not a matrix.

Created on 2019-06-15 by the reprex package (v0.2.1)

Fixing this and including the test would probably bring test coverage to a satisfying level.

OK... should be fine now. B was being entered as a sparse matrix in DSmooth(), needs to be a dense matrix.


[Bug]:  get embeddings result  sometime work ,sometime error

What happened?
r = collection.get(     where={"timespan": {"$gte":<PHONE_NUMBER>}},     include=[ "embeddings" ]           )
Traceback (most recent call last):
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/api/fastapi.py", line 652, in raise_chroma_error
resp.raise_for_status()
File "/opt/miniconda3/lib/python3.12/site-packages/requests/models.py", line 1021, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:8090/api/v1/collections/183b4fe9-b24a-4136-ad77-0943677de6a5/get
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/zyu/code/repeat/updatetime.py", line 38, in
r = collection.get(
^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/api/models/Collection.py", line 211, in get
get_results = self._client._get(
^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/init.py", line 127, in wrapper
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/api/fastapi.py", line 436, in _get
raise_chroma_error(resp)
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/api/fastapi.py", line 654, in raise_chroma_error
raise (Exception(resp.text))
Exception: {"error":"IndexError('list assignment index out of range')"}
sometime work ,but sometime error
Versions
v0.3.22
Relevant log output
No response

File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/auth/fastapi.py", line 242, in wrapped
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/server/fastapi/init.py", line 563, in get
return self._api._get(
^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/init.py", line 127, in wrapper
if trace_granularity < granularity:
^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/rate_limiting/init.py", line 45, in wrapper
return f(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/api/segment.py", line 538, in _get
vectors = vector_segment.get_vectors(ids=vector_ids)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/init.py", line 127, in wrapper
if trace_granularity < granularity:
^^^^^^^^^^^^^^^^^^
File "/opt/miniconda3/lib/python3.12/site-packages/chromadb/segment/impl/vector/local_persistent_hnsw.py", line 330, in get_vectors
results[id_to_index[id]] = VectorEmbeddingRecord(
~~~~~~~^^^^^^^^^^^^^^^^^
IndexError: list assignment index out of range

Hello @zyu, thank you for reporting the error. I was not able to reproduce it with version 0.3.22. Could you provide more details about the code and the context in which the error occurs? Did you try update to the last version of chroma?
Thanks

@zyu, In the trace I see references to opentelemetry. We've added OTEL only in version 0.4.x. Can you please double check your Chroma version - pip list | grep chromadb. Thank you.

@zyu, the issue affects 0.4.x and is being worked on. We'll have a PR for it soon.


Runtime error: Line 4: fetch is not defined

Add an image from a URL to a workbook, i just copy the code and put in my power automate-run script, it work well when it run from the excel workbook, but when put in power automate-run script, it show 'Runtime error: Line 4: fetch is not defined', why and please help

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 95e77282-9af0-0646-e6ca-15b1615ff5f2
Version Independent ID: 9822a8dd-90ef-2303-aaca-00ff8ceeb519
Content: Add images to a workbook - Office Scripts
Content Source: docs/resources/samples/add-image-to-workbook.md
Product: excel
Technology: scripts
GitHub Login: @o365devx
Microsoft Alias: o365devx

Hi @ireneqir,
Thanks for raising this issue. External calls, such as fetch aren't allowed when run through Power Automate, as documented here: https://learn.microsoft.com/en-us/office/dev/scripts/develop/external-calls#external-calls-from-power-automate.
This could be made clearer in the documentation. I'll leave this issue open until that's addressed.


VISSL & Detectron Installation Instruction Conflict

Minor note, the torch version recommended to install in the VISSL instructions appears to be incompatible with the object detection benchmark dependency Detectron2, which appears to require PyTorch ≥ 1.8, see here.

Hi @ysharma1126,
Indeed, good catch!
I think we could update the PyTorch version to 1.8 and higher (we do work with VISSL on our side with higher versions like 1.8, 1.9 or more). I will delegate this question to @iseessel though, since he is more knowledgable on the packaging / dependencies than me.
Side note: Once thing I am not 100% sure is whether it is a good idea anyway to use the same conda environment for detectron2 and VISSL (since it introduces some coupling of dependency versions). Although we do have a script to run detectron2, I must admit I never played with object detection for now, maybe we could find a better way.
Back on the point @ysharma1126, since @iseessel is off this week, the response might take some time.
Thank you again for raising this :)
Quentin

No worries, no urgency on my end :)

@ysharma1126 Yes you should be able to update the pytorch version to whatever version is compatible with Detectron. Let me know if you need any guidance on how to do this.


Helpful payment request validation error

We noticed that if the billing details Paytrail expects to receive are incomplete (e.g. city is missing), the payment request fails at checkout and WooCommerce webstore will only show a generic error message Error processing checkout. Please try again. to the user.
Looking at the Paytrail logs, we can see the following:
2023-01-04T11:07:33+00:00 ERROR city is empty#0 /var/www/html/wp-content/plugins/paytrail-for-woocommerce/vendor/paytrail/paytrail-php-sdk/src/Client.php(203): Paytrail\SDK\PaytrailClient->validateRequestItem()
2023-01-04T11:07:33+00:00 ERROR FAILURE: Response is NULL or empty

I wonder if it would be possible to explain the error to user in a friendly way, making it possible for the user to understand what is wrong and fix the situation. Thanks.

@mikkosiikaniemi Thanks for reporting, we will add some more details to the error messages if they are available.


MSAA example

Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 .

Added a comment about wgpu sample count limitations (copied from our Msaa config docs). This looks good to me!

bors r+

bors crashed for some reason

bors r+


Fix github action badge

Fix github action badge link

Well, to be honest, I don't really know either 😅
It might be time to change the badge for itemadapter too.

@elacuesta Can we merge this one too?


Bump helm charts minor version

What this PR does / why we need it:
As release-1.21 branch was cut, bump minor version for all the Charts for master branch.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

/cc @brtknr

/approve
/lgtm

/lgtm


[ANDROID] Unsupported Style : line-height

I have this html :

If ignition fails a second time, a warning message will appear on control panel.

And i get error on Android which is :
Error while updating property 'lineHeight' in shadow node of type : RCTVirtualText
TypeError: expected dynamic type `double`, but had type `string`

I did ignore this style for now to avoid any mistake, but that would be great to have support for this.
Thanks for your time.

Hi, which version of the plugin are you running ? I can't reproduce your issue with the latest one. This seems like something I fixed a little while ago.

Any update??

@chixpc123 please try PR #117, I couldn't get a look at it yet.
Please review this change in the PR's thread so @mchudy is kept up to date.

I'll assume this is fixed, please re-open an issue if you encounter this error again.

Failed prop type: Invalid prop lineHeight of type string supplied to Text, expected number.
Bad object: {
"fontSize": 9.1,
"lineHeight": "normal"
}
Having the same issue.


Which windows 10 sdk?

Hello
I'm trying to test out face detection with dlib and javascript. I've cloned this repo and tried running the install script. I installed all other prerequisites except for the "windows 10 sdk". Which one should I use:

I tried looking at https://github.com/felixrieseberg/windows-build-tools, but no clues there as well.
Although I like the package-like management for libraries I tend to stay away from it when it comes to frameworks/sdks/build-engines on windows. Moreover, it's better to have local-only node packages anyway - I've seen it recommended here and there. I guess I'll just go with the highest version w/o extra title(Windows 10 SDK (10.0.14393.0)), but anyone's welcome to bring some more clarity which's the preferable approach?!

Hi,
Regarding to this node-gyp issue, you should only select 10.0.14393.0 and unselect all of the other sdk tools. I think that's what I did on my machine as well.

I decided to go for the latest - 10.0.16299.0, which builds w/o errors. But I'm planning to use it within an electron app, so I may need to downgrade(as the author of the node-gyp issue). Thanks
Cheers,
Kostadin


Adding support for float16 conversion for GPUs

What does this PR do?
This PR adds support for converting model weights from fp32 to fp16 by adding a new Optimization parameter. If the fp16 arg is provided in the OptimizationConfig the weights are converted. I also added a test to make sure the model is not containing any fp32 weights
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


support pre-commit (add a small file called .pre-commit-hooks.yaml)

Is your feature request related to a problem? Please describe.
no
Describe the solution you'd like
add a small file called .pre-commit-hooks.yaml in the root of the project, follow this
Describe alternatives you've considered
using pre-commit running pip-audit globally installed on the system (not ideal for teams)
Additional context
join a massive ecosystem of easy-to-use hooks

hi, I can do this

hi, so would this be good for you? :
- id: pip-audit
  name: pip-audit
  description: "Audits Python environments and dependency trees for known vulnerabilities"
  entry: pip-audit
  language: python

i put it on the main branch in my fork, and it seems to work with a dummy client that uses this config:
repos:
-   repo: https://github.com/tal66/pip-audit
    rev: v2.1.1-3-g03a3d4c
    hooks:
    -   id: pip-audit

id: pip-audit
name: pip-audit
description: "Audits Python environments and dependency trees for known vulnerabilities"
entry: pip-audit
language: python

I think we should also pass pass_filenames: false and have users supply the args. For example:

i put it on the main branch in my fork, and it seems to work with a dummy client that uses this config:
repos:
-   repo: https://github.com/tal66/pip-audit
    rev: v2.1.1-3-g03a3d4c
    hooks:
    -   id: pip-audit

       -   args: ["-r", "requirements.txt"]
      # Or
      -   args: ["."]

Since i tested this I just put up the PR here https://github.com/trailofbits/pip-audit/pull/256. Thanks for starting the work tho!

cooperlees, are you a part of their team?

He's not, but all changes are welcome. Thanks @cooperlees!

FWIW - pre-commit.ci does not like how pip-audit uses pip: https://github.com/pre-commit/pre-commit/issues/2368
Will see if we need to document that it's not supported there or see if it can be fixed.

I feel it will work in my own action. I will do a PR updating docs if needed.


Default value in ResourceGroup different than in global

ResourceGroup and ResourceGroupTemplate pulls in the WLDFSystemResource alias definition, which is also global. There is one field in the definition that has a different default value in the global versus the ResourceGroup and ResourceGroupTemplate. Pretty low in priority, but opening an issue on this. Don't know how to solve this. It would be a pain to replicate the entire json file for this one type. But hey, maybe we should
/ResourceGroup/WLDFSystemResource/WLDFResource/WatchNotification/Watch/ExpressionLanguage                                     Attribute=EL  :  Alias=WLDF

Converted to Jira WDT-295


Display a confirmation modal before undelegation or delegation in KEEP token dashboard

Closes: #1638
This PR displays a confirmation modal before delegation/undelegation.

Tested delegation and undelegation behind these modal upon successful and failed transactions. Worked fine.


README.md still refers to VS2017 and v14.1 toolchain

The new requirements to build the project after #1012 are not documented.
I have problems trying to build with VS2019, but want to be sure I have the correct setup before reporting those issues.

@bitcrazed would be more than happy to fix this. Thanks for the catch!


feat: sort by repo name

:tada: This PR is included in version 1.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support new highlighter options in 5.4

Coming in 5.4 as per https://github.com/elastic/elasticsearch/pull/23431

boundary_scanner (sentence (default)  or word)
max_fragment_length (only for sentence scanner)
no_match_size

Went into v5.4.0 in 7f42f2ce


WIP: Use xi-win-ui in xi-win

The purpose of this PR is to refactor xi-win so that it uses xi-win-ui. (See #49 for more details.) The scope, however, is purposefully limited, as this is a sizable refactor. The tasks are as follows:
Implementing Widget trait for EditView

[x] Painting
[x] Layout
[x] Mouse events
[x] Poke (Kb, Resize, other events?)

Removing WinHandler trait for MainWinHandler and reimplementing

[ ] Menu commands
[x] Core connection
[x] Kb events (presumably dispatched to current EditView)

This PR does not attempt to fully implement multiple EditViews, but could provide preliminary support for further refactoring, such as considerations for how Core is to be managed, so that several EditViews can queue notifications in a thread-safe manner.

I wanted to make this work as transparent as possible to quickly adjust course if something seems amiss.
Let me know if anything seems unclear.

I think it would make sense to rework MainWinState like so:
struct MainWinState {
    current: Id,
    edit_views: HashMap<String, Id>,
}

This would make it easier to access the EditView as a Widget through the UiState, but AFAIK would make it impossible to access the EditView directly (which a lot of the current functionality depends on) - would it make sense to implement said functionality through poke instead?
(See e.g. fn file_save, which accesses the editview to change the filename.)

I haven't dived into the code yet, but I wanted to respond to your comment.
You definitely can't access EditView from main, it's moved into UiState and subsequently owned by that. It is possible to have shared state with something like Rc<RefCell<SharedState>>, but there are limitations, for example it's not possible externally to request an invalidation. That's essentially the whole motivation for poke (when invoked from inside the ui) and send_ext (when invoked from outside); both end up with the poke method of EditView being invoked with the context it needs to request invalidation, send events to its listener, etc.
So your edit_views proposal makes sense. For the String you have in mind view id? This is one of those cases where type ViewId = String would make sense, just to make that clearer.
If the work gets really big, perhaps this could be developed in a branch, with multiple PR's being merged into the branch, but I think by having more moderate scope, iterating within the PR should be fine (the main reason for an explicit branch is when multiple people are committing into it).

That's essentially the whole motivation for poke and send_ext; both end up with the poke method of EditView being invoked with the context it needs for request invalidation, send events to its listener, etc.

Okay, good to know. Do you have any thoughts on what the payload should look like? I'm feeling a little fuzzy on that atm.

For the String you have in mind view id?

Exactly, the view id given by core. Do you think type CoreViewId would be too much?
I'm fine with merging against a separate branch, too. In fact, maybe that would make more sense with work this PR depends on, such as implementing the file open dialog inside the xi-win-ui toolkit. (But I guess that could be implemented in here as well. It just seems a bit messy.)

The payload for a complicated widget like EditView should generally be an enum of all the different actions it might respond to. Some valuable inspiration might be "commands" from Elm.
I'm ok with CoreViewId but feel ViewId is sufficient unless there are more than one kind and they need to be distinguished.
Very good point regarding dependent features. The way I'm most comfortable with is implementing the dependent feature as a separate PR, then rebasing on top of it. In a gerrit-style workflow, rebasing is pretty standard, and just creates a new patchset for the rebased change. In GitHub, I think you have to force push. I don't have strong feelings, whatever is most effective.

@raphlinus, Is there a way to dynamically add widgets to UiState once the app is running?
I have had some trouble trying to figure this out, at least. (Adding EditViews once the core view-id has been submitted, for example, would be difficult without this ability.)

It's a very good question. The plan is to allow pretty full mutation of the widget graph from inside a ListenerCtx. There are some subtleties, but it's doable. Actually allowing adding (and deleting) widgets is not too hard, the main thing that's tricky is also adding listeners. But I think having a queue of added listeners would pretty much take care of that.
It occurs to me this is one way to deal with waiting on the response to new_view - before the view id comes back, you could display a placeholder widget, and swap that out. That way, EditView only has to deal with fully instantiated views, and you don't have to convey the view id response to the EditView. That's not how xi-mac works (it allows an EditView to be in a partially instantiated state before the view id comes back from core), but we don't have to follow that.

Interesting about the LayoutCtx, but would a listener be able to receive input from external events? (Such as xi-core.) I assume external processes would still be handled via send_ext?
My current approach is to add a row to xi-core with no children.
(This row is a placeholder for the SplitPane widget which we've discussed previously on IRC, which eventually will contain several EditViews, if we choose to go in that direction.)
As soon as I receive the view_id from core, I would like to create a new widget and add it to the row. However, I suppose swapping would work just fine, too.
But I don't know how to access the UiState to perform this swapping?
In my opinion, it would be ideal if Flex implemented the Widget poke method, so that one could call send_ext(&handle, row, FlexCommand::AddWidget(edit_view)) - but then there's the problem of getting its Id. So I'm at a standstill atm. 🤷♂

Interesting about the LayoutCtx, but would a listener be able to receive input from external events?

Not directly, but (for example) the widget involved could be an EventForwarder, which would have the same result.

In my opinion, it would be ideal if Flex implemented the Widget poke method, so that one could call send_ext(&handle, row, FlexCommand::AddWidget(edit_view))

The widget doesn't "own" its children, though it might seem that way during building, as the children are added through the ui method during building. But looking more carefully, that really acts primarily on UiState.
After building, while the UI is running, there's no mutable access to UiState, only contexts. Adding widgets dynamically is an important feature, but not done yet and will require some rework (I think I need to change the signature of ui methods to take either a UiState or a LayoutCtx.
The easiest way to make progress right now is to have a static widget tree, and have the EditView change state from having no attached view id to attaching it. The dynamic adding of widgets will be necessary to handle multiple tabs and is also a viable way to handle that state change, but I'm not sure exactly when it's going to get done - probably soonish though because I do need it for the synthesizer.

Your work on #59 looks promising. Once that is ready, I would like to rebase on that. Thanks for your excellent explanations as well. :)
I've gotten as far as I will, I think, without some  guidance. The core refuses to respond to the front-end requests. I've set up some tracing on the commands for my convenience, but we can remove those before the merge. (I would like to be able to toggle them though, tbh.)
If you're interested, the trace looks like this:
dxgi factory pointer = 0x191e5162040
0x191e5169cd0: desc = Some("Intel(R) UHD Graphics 620"), vram = 134217728
0x191e516e650: desc = Some("Microsoft Basic Render Driver"), vram = 0
adapter = 0x191e5169cd0
swap chain res = 0x0, pointer = 0x191e5208850
core->fe: available_languages {"languages":[]}
core->fe: available_themes {"themes":["InspiredGitHub","Solarized (dark)","Solarized (light)","base16-eighties.dark","base16-mocha.dark","base16-ocean.dark","base16-ocean.light"]}
core->fe: available_plugins {"plugins":[],"view_id":"view-id-1"}
core->fe: config_changed {"changes":{"auto_indent":false,"autodetect_whitespace":true,"font_face":"InconsolataGo","font_size":14,"line_ending":"\r\n","plugin_search_path":[],"scroll_past_end":false,"tab_size":4,"translate_tabs_to_spaces":true,"use_tab_stops":true,"word_wrap":false,"wrap_width":0},"view_id":"view-id-1"}
core->fe: language_changed {"language_id":"","view_id":"view-id-1"}
core->fe: update {"update":{"ops":[{"lines":[{"cursor":[0],"styles":[],"text":""}],"n":1,"op":"ins"}],"pristine":true},"view_id":"view-id-1"}
core->fe: scroll_to {"col":0,"line":0,"view_id":"view-id-1"}
fe->core: {"method":"edit","params":{"method":"gesture","params":{"col":0,"line":1,"ty":"point_select"},"view_id":"\"view-id-1\""}}
fe->core: {"method":"edit","params":{"method":"insert_tab","params":[],"view_id":"\"view-id-1\""}}
fe->core: {"method":"edit","params":{"method":"insert_tab","params":[],"view_id":"\"view-id-1\""}}
fe->core: {"method":"edit","params":{"method":"insert","params":{"chars":"T"},"view_id":"\"view-id-1\""}}

Thanks for the feedback.
Currently, this PR is waiting on the druid implementation of file open, file save and file save as.
I think it might be wise to just submit it once those are complete - don't want the PR to get too big. 😄
Then work can start on those once graph mutation is complete.

Looks like good progress! I agree that we should get this PR landed as soon as it's not a major regression, and do other features and refinements as followups.
So it sounds like the plan is for me to add file dialogs, then rebase this PR? I believe it's not waiting on mutation (#59) at this point, though that is in progress.
I can probably bang out the dialogs pretty quickly. I had it working before using unsafe hacks accessing the hwnd, this time around I should wrap them properly and attach them to the correct structs.

So it sounds like the plan is for me to add file dialogs, then rebase this PR? I believe it's not waiting on mutation (#59) at this point, though that is in progress.

Yeah, that seems like a good course of action. I certainly don't think graph mutation is a blocker, no.


volume.fix.replication retries even when there is no error

Describe the bug
Setting the -retry option on volume.fix.replication causes it to retry for the given number of times even when there has been no error.
Expected behavior
It should only retry when there is error
Screenshots

Additional context
It seems that the continue directive here should be break instead.

Thanks for the detail and debugging. Fixed. You are welcome to make a PR.

Thanks, I didn't have a dev environment set up locally when I submitted the issue, and since I could not test if the finding was correct I didn't submit a PR.


v9.3.3 improved mock factories

Current coverage is 76.51%

Merging #171 into master will not affect coverage as of d495305

@@            master    #171   diff @@
======================================
  Files           26      26
  Stmts          379     379
  Branches         0       0
  Methods         83      83
======================================
  Hit            290     290
  Partial          0       0
  Missed          89      89

Review entire Coverage Diff as of d495305

Powered by Codecov. Updated on successful CI builds.


Add new Rails/RedundantForeignKey cop

The foreign key for an association can be overridden with the :foreign_key option. This cop detects when the specified value is the same as the default.
Aside from being unnecessary, setting the foreign key prevents the inverse association from being inferred automatically, which can lead to unnecessary queries.
The default foreign key logic implemented here matches what Rails does internally:
https://github.com/rails/rails/blob/95af87f0a4b6274a43853ed68b17e17c21f804f3/activerecord/lib/active_record/reflection.rb#L659-L667
I don't think this warrants an entry in the Rails Style Guide on its own, but a more general section about ensuring associations have inverses that mentions foreign_key as a gotcha might be useful.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] If this is a new cop, consider making a corresponding update to the Rails Style Guide.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


electrum resolver: broken login

when I run
 rgb create --tapret-key-only "****" --electrum "blockstream.info:110" -n bitcoin my-wallet
Syncing keychain 0 ........... keychain 1 .......... keychain 9 .......... keychain 10 ..........thread 'main' panicked at

~/.cargo/git/checkouts/bp-wallet-997f3c057e1b59f2/5d07f27/src/indexers/electrum.rs:278:52:
broken logic

Since some electrum server implementations do not support verbose, setting the second parameter of blockchain.transaction.get to true (rgb and bp-wallet) will return an error. and results in broken login.

https://github.com/Blockstream/electrs/pull/36

@eauxxs Unfortunately the electrum server forked by Blockstream doesn't provide the functionality that RGB requires to check the TX confirmations.
Therefore I've added a check (https://github.com/RGB-WG/rgb/pull/194) to be sure we warn the user that the provided service is missing that functionality, which is definitely better that panicking.
If you want to use an electrum server for mainnet you can use ssl://electrum.iriswallet.com:50003

thanks your reply！@zoedberg


Watch should accept Path objects as well as strings

Since Python 3.6, all the standard library accepts Path objects as well as strings as per https://docs.python.org/3/whatsnew/3.6.html#whatsnew36-pep519, Ideally, aionotify should as well. I think you just call os.fspath() on the argument.

As I said in the PR I closed, os.fspath was only added in Python 3.6 but this package otherwise supports 3.4 so closing this issue.


create-template package to npm create @tomic/template

We could make a create-template package that allows users to do things like npm create @tomic/template
Since these are just executable scripts we can do things like generate a users ontologies and have some options like what framework to use.
Originally posted by @Polleps in https://github.com/atomicdata-dev/atomic-server/issues/923#issuecomment-2304394809
Goals

Make it easier for devs to start a website using @tomic/lib and @tomic/svelte
Dogfeed our APIs so we make them as easy as possible for our main usecase (Headless CMS)
Test libs in a project in the CI (instead of just relying on unit tests)

TODO

[ ] Template (sveltekit?) project, should be minimal

[ ] Render Articles
[ ] Render a Collection (using some custom view)
[ ] Search bar
[ ] Readme that mentions the CLI and links to docs where needed

[ ] Template ontology (article, menu item)
[ ] cli action that copies a folder
[ ] link to an ontology to create types
[ ] e2e tests (should use pnpm link)
[ ] Publish new NPM package

Can you commit + push + open a draft PR @Polleps? @AlexMikhalev and me would also like to see the progress in this!


Fix return type of methods provided by SoftDeletes

Summary
Fix return type of methods provided by SoftDeletes.
Detail
The SoftDeletes model has three methods available:

withTrashed()
withoutTrashed()
onlyTrashed()

As the linked code shows, they return \Illuminate\Database\Eloquent\Builder, but theide-helper:models command generates the annotation \Illuminate\Database\Query\Builder. I fixed this difference.
Notice
Previously there were no issues, but with the fix for Laravel v9.3.0 , some static analysis tools such as PHPStan now report errors in the traditional ide-helper process.
Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] Existing tests have been adapted and/or new tests have been added
[x] Add a CHANGELOG.md entry
[ ] Update the README.md
[x] Code style has been fixed via composer fix-style

Makes sense I think, not sure why originally it was Query, maybe @max-matiukhin remembers? :)

@barryvdh @mfn Thank you for review and merge!


Update to v2.2.28

To do this, we need to change the source location.

Checklist

[x] Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #44

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [8, 8].

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge/udunits2, this is ready to review.  Feel free to merge it, I just want another pair of eyes on it.


Releases latest source code (tar.gz)  Version number missing

tar xf trealla-2.29.36.tar.gz
make
cc -Isrc -I/usr/local/include -DVERSION='""' -std=gnu99
$ ./tpl
Trealla Prolog (c) Infradig 2020-2023,
?-

Because there is no .git directory in the archive-file and as long as the version-nr is part of the pathname,  I change the GIT_VERSION command for now.
$ head -2 Makefile
# GIT_VERSION := "$(shell git describe --abbrev=4 --dirty --always --tags)"
GIT_VERSION := "$(shell basename `pwd` | awk -F- '{ print "v"$$2 }')"


bugfix Fix create mv using jsonb key cause be crash

Proposed changes
Issue Number: close #xxx
Problem summary
Add supportsTableKey() and supportsComparison() to Type. Forbid type that not supportsTableKey() to be used as mv key.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Support review state

Gerrit tracks which files you have looked at and marks them as reviewed, this feature is sorely missing from the plugin.
I currently have to review a massive change ~4600 files, as gerrit is noticeably slower it is a prime usecase for this plugin.
Unfortunately the plugin doesn't keep track of what files I already reviewed, which is quite important in such a large change.
Furthermore, it would be nice if one could filter the file list to show only the unreviewed files.

I think the plugin should already set the reviewed state - are you sure this doesn't work in your case? See relevant code line: https://github.com/uwolfer/gerrit-intellij-plugin/blob/7a1dddc5f8af17e537772113fb8e591edad9bdd0/src/main/java/com/urswolfer/intellij/plugin/gerrit/ui/diff/CommentsDiffTool.java#L203

@uwolfer you are right the flag is set on gerrit, but it isn't shown in the diff list in Intellij, that is why I was assuming that the plugin didn't support it at all. Furthermore, gerrit allows to set the review state either in the list, or in the diff view, e.g., when you didn't finish reviewing the file.
So I'd clarify that the plugin should display the review state, support filtering by review state to show only unreviewed files and allow to manually toggle it.

@leonard84 Thanks for your feedback. This feature request is tracked in #20.

Ok that issue is from 2013 any chance this can be implemented?

@leonard84: Would be nice if we could get that implemented - as this is an open source project, anybody can contribute. My spare time at the moment is unfortunately quite limited.

@uwolfer I hear you, limit spare time is a common problem.
I'm not against helping, but the code base of this plugin and the gerrit client is quite complex and I couldn't figure out where I could obtain the review state. From what I could see https://github.com/uwolfer/gerrit-intellij-plugin/blob/intellij14/src/main/java/com/urswolfer/intellij/plugin/gerrit/ui/GerritCommentCountChangeNodeDecorator.java is the class responsible to render the changes tree, where I would put the reviewed indication.

@leonard84: Thanks for your offer! I'm happy to support this work.
In order to get a working dev setup, I hope the README should help. If you miss any parts there, please let me know.
GerritCommentCountChangeNodeDecorator seems to be a good entry point. In that class at the very bottom, you can also see some data fetching for draft comments. I've not looked into details yet, but I'd suppose that you can just fetch the review state in a similar way:
gerritApi.changes()
  .id(selectedChange.id)
  .revision(getSelectedRevisionId())
  .reviewed()

Does this already answer your question?

@uwolfer this project still uses gradle 4.4, whereas gradle 6.7 is the latest version. Is there a reason not to update?

@uwolfer this project still uses gradle 4.4, whereas gradle 6.7 is the latest version. Is there a reason not to update?

Good point - I think we can update it.

@uwolfer this project still uses gradle 4.4, whereas gradle 6.7 is the latest version. Is there a reason not to update?

Updated now. Please rebase your PR.