Optimizer hook for Futures API

There are currently X_optimize config options described here for the other main APIs (delayed, dataframe etc). But there doesn't seem to be the same thing for futures.
I would like to request this feature because I'm trying to wire up the graphchain library with dask Futures. Currently graphchain works using the optimize_delayed hook, but without a similar thing for Futures it's not clear how I can proceed.

Thanks for opening this! I think @gjoseph92 and @crusaderky might find this interesting. :)

The key difference between dask collections and Futures is that when you compute a collection you send all of its keys at once to the scheduler, whereas with a Future you send one key at a time.
Optimization is about taking multiple keys and manipulating the graph before they reach the scheduler. Hence, with futures, it is impossible.
Even without optimization, typically delayed objects offer better performance than futures because calling compute() on a collection with 100 keys is a lot faster than calling submit() on 100 futures (as the round-trip time and overhead in comms is 1/100th). May I ask what's missing in delayed that you need?

Right, I thought that might be the case. My motivation is #9164. In that issue I was pointed to graphchain, which cleverly caches delayed results based on the DAG structure, but I was wondering if it were possible to gain the advantages of both caching (which is very important in my work) and also the flexibility of Futures. This isn't a pressing issue because I can and will just use delayed instead, but I'm asking out of curiosity.

@multimeric Based on @crusaderky's comments, I think we can close this issue because this feature request can't be implemented. Please feel free to re-open it if needed. :)


Remove sleeps

This fixes issue #160.
My previous assumption that sleep_us() is implemented with a busy loop turned out to be incorrect. In fact the Pi Pico SDK tries to save power by using the WFE instruction. While the power savings are measureable they are minimal. I have measured a power consumpsion of 21.5 mA without sleep_us() vs. 20 mA with sleep_us().
Whether this PR should be merged should depend on its effect on input latency. Unfortunately, I currently don't have the ability to do latency measurements.

Before we approve/merge, we need to visit if removing the waits does anything positive/negative to our GPIO and I2C rates. I'll test on my input latency tester and have others test on theirs (if anyone has a Mister, that would be awesome)

Here is our current 0.7.0 Pre-Release with sleep, delay, and no add-ons enabled:
polling interval    1.0 min    0.54 max    1.34 average    0.83 stddev    0.24 % no skip    96.05% % skip 1 frame    3.95% % skip 2 frames    0% % skip 3 frames    0%
Here is our current 0.7.0 Pre-Release with no sleep, delay, and no add-ons enabled:
polling interval    1.0 min    0.54 max    1.38 average    0.85 stddev    0.24 % no skip    95.95% % skip 1 frame    4.05% % skip 2 frames    0% % skip 3 frames    0%
Here's 0.6.3:
polling interval    1.0 min    0.54 max    1.38 average    0.86 stddev    0.24 % no skip    95.91% % skip 1 frame    4.09% % skip 2 frames    0% % skip 3 frames    0%
and 0.4.3:
polling interval    1.0 min    0.54 max    1.39 average    0.87 stddev    0.24 % no skip    95.79% % skip 1 frame    4.21% % skip 2 frames    0% % skip 3 frames    0%
removing the delay causes errors/input drops on the input latency tester and most likely calls tinyusb too quickly. I'm closing this one, we can revisit if there's any way to increase USB polling on the clock-rise but we can't remove delays unfortunately.

@arntsonl:
Thank you for checking this out. I'll look into latency myself again once I have a working latency test setup.
You should probably also close #160 as well.


ids: IDS policy fixes

What this PR changes/adds
This PR brings two fixes for IDS policies:

add binding for USE action to ALL_SCOPE (otherwise, policy constraints are never evaluated)
improve resiliency of CustomIdsConstraintDeserializer as it was not properly checking potentially null values before using them.

Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1114 (6af38ea) into main (2a1db74) will increase coverage by 0.01%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##               main    #1114      +/-   ##
============================================
+ Coverage     62.61%   62.62%   +0.01%
- Complexity     2969     2977       +8
============================================
  Files           694      694
  Lines         15416    15424       +8
  Branches       1044     1049       +5
============================================
+ Hits           9652     9660       +8
+ Misses         5334     5333       -1
- Partials        430      431       +1

Impacted Files
Coverage Δ

...e/selector/api/DataplaneSelectorApiController.java
100.00% <ø> (ø)

...aspaceconnector/ids/policy/IdsPolicyExtension.java
0.00% <0.00%> (ø)

...s/core/policy/CustomIdsConstraintDeserializer.java
96.66% <95.23%> (-3.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98038f7...6af38ea. Read the comment docs.

@bscholtes1A I am okay with the deserializer fix/improvement, I am not sure about the scope thing. @ndr-brt Could you tell me what this ids-policy extension is used for?

@juliapampus it was something added to show how to register functions on the policy engine, it hasn't other uses.
In my opinion it can be deleted.

@juliapampus it was something added to show how to register functions on the policy engine, it hasn't other uses. In my opinion it can be deleted.

@ndr-brt Is there any documentation for this? We could add the files inline to a step-for-step guide. I would support deleting unnecessary modules to avoid confusions.

Makes sense, opened an issue #1156 1156

Could be, yes, but we should find a way to make this more explicit.
E.g. probably the name ids-policy and its position (extensions) do not fit well. If they should come out of the box probably the core/policy module would be a better choice.
Probably @jimmarino has an opinion on this


skeleton-esnext utilizes JSPM with Gulp, why not JSPM alone?

Hi,
Why do you use Gulp with JSPM and not JSPM alone in for instance skeleton-esnext project? I didn't find information online about Gulp needs along JSPM so please enlighten me (:
-XDVarpunen

GitHub issues are usually reserved for bugs or feature requests, JSPM is a package manager, not a task runner (which gulp is) so both tools are currently used.  You can replace either with the package manager or build tooling of your choice if it fits your project better.

This question was about skeleton project, there is no documentation why you use Gulp with JSPM. Isn't JSPM enough? (:

No as described above jspm is not a task runner

Okey, maybe I understood it now:

webpack includes task runner / can run certain tasks and utilizes npm as package manager
jspm is package manager and gulp complements the task runner part

Did I get it right? (:

No the webpack skeleton uses npm to run commands not webpack.

Now I got it, thank you very much! (:


Parallel operation

How to create a parallel operation flow chart. i.e one operation to two different operations, then that two operations to one operation.

BUMP!
Yes, I'd like to know how to do this too.

not possible right now...
Feel free to submit a PR if possible.

there is s new parallel component... can you try if that works for your use case?

Hi @adrai
I have tried the parallel component but still, I am not able to draw flowchart for below statements

st=>start: Start|past
e=>end: End|past
op3=>parallel: Stuff1|current
op1=>parallel: My Operation|current
op2=>parallel: Stuff|current
sub1=>subroutine: My Subroutine|current
sub2=>subroutine: My Subroutine1|current
sub3=>subroutine: My op2|current
sub4=>subroutine: My op22|current
st(right)->op1
op1(path1, bottom)->sub1->sub2
op1(path2, right)->op2
op2(path3, bottom)->sub3->sub4
op2(path4, right)->op3
op3(path5, right)->e

I have attached the output image below

but I want below output

please guide me for same

There is only path1, path2 and path3 (no path4 or 5)
try:

st=>start: Start|past
e=>end: End|past
op3=>parallel: Stuff1|current
op1=>parallel: My Operation|current
op2=>parallel: Stuff|current
sub1=>subroutine: My Subroutine|current
sub2=>subroutine: My Subroutine1|current
sub3=>subroutine: My op2|current
sub4=>subroutine: My op22|current

st(right)->op1

op1(path1, bottom)->sub1->sub2
op1(path2, right)->op2

op2(path1, bottom)->sub3->sub4
op2(path2, right)->op3

op3(path2, right)->e

Thanks @adrai for your help


EXT: CCM_DDS::Unlimited bound does not apply

Issue and tracking information
When setting the bounds of a sequence to  CCM_DDS::Constants::Unlimited nothing happens and the bound's constant remains "null". The following exception is received:

Developer's time Estimated effort to fix (hours):
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below

This issue should be fixed now as I've committed a fix for this issue as part of the Issue #368 commit.

I have verified this on my end. Thank you


Added logic to filter vlan and overlay subnets

What this PR does / why we need it:
Fixes issue that prevents CAPX clusters to be deployed inside VPCs. This fix will add logic to determine if a subnet is overlay or not.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A
How Has This Been Tested?:
Manual testing in a VPC
e2e tests:
Ran 14 of 26 Specs in 2769.665 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 12 Skipped
PASS

Special notes for your reviewer:
N/A
Release note:

- Allow CAPX clusters to be deployed inside VPCs

Codecov Report

Merging #230 (b2218e2) into main (f0036fb) will increase coverage by 0.50%.
The diff coverage is 23.80%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff            @@
##            main    #230      +/-   ##
========================================
+ Coverage   2.29%   2.79%   +0.50%
========================================
  Files          3       4       +1
  Lines        916     929      +13
========================================
+ Hits          21      26       +5
- Misses       895     903       +8

Impacted Files
Coverage Δ

controllers/helpers.go
0.00% <0.00%> (ø)

controllers/nutanixcluster_controller.go
7.33% <0.00%> (-0.21%)
:arrow_down:

controllers/nutanixmachine_controller.go
2.29% <0.00%> (-0.03%)
:arrow_down:

controllers/options.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Find First and Last occurance of element in sorted array

Leetcode question No 34
Please assign this to me

@priyanshuhaldar007 kindly Add up your solution with question link on top of the file and push it under leetcode folder

Please assign this to me!

Please assign this to me!

assigned

plz assign it to me

plz assign it to me

sure

Hi
@priyanshuhaldar007 , I am interested to look into this issue. if the issue is not yet resolved , Would you please assign this to me ?

Hi @Saikat2407 , I am interested to look into this issue. if the issue is not yet resolved , Would you please assign this to me ?

sure man!

Please assign me this issue.

Please assign me this issue.

Add up and make a PR.


[METROL-549]: PerformanceMetrics: Plugin added

Copyright scan failure
Commit: 352b2fe077f9edfa7248150da06030359fef4dd5
Report detail: https://gist.github.com/d4deeec6136dd383aa91312e87df82d4

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rdkservices/2772/rdkcentral/rdkservices

Commit: 352b2fe077f9edfa7248150da06030359fef4dd5

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: spurious match

Commit: 352b2fe077f9edfa7248150da06030359fef4dd5

WARNING: A Copyright scan failure has been waived
A prior failure has been upvoted

Upvote reason: Spurious - fixing in the tool

Commit: 352b2fe077f9edfa7248150da06030359fef4dd5

Internal JIRA ticket https://ccp.sys.comcast.net/browse/RDKCOM-3226

PR merged to the main branch - https://github.com/rdkcentral/rdkservices/commit/a9a40aec51e869af725f6ee7b0731eba19e4f619


Fix OR query bug when some indexes are missing

Each clause in an OR query is treated separately.  If an index does not exist to handle a clause in an OR-ed query then the post hoc matcher must handle the query results.  This PR addresses the bug where the post hoc matcher was previously using a subset of the full list of documents to provide the (incorrect) query results.  With the work included here the full list of documents is now used.

@mikerhodes - I also added another test that I meant to include with the field projection work.  It is separated out into its own commit https://github.com/cloudant/sync-android/commit/d5ef75c8b60f222a15863a8b92595efe733646a6.

Looks good, fixup 39fad58 into c771fdb then merge. +1.


feat: port Data.Real.Cardinality

bors r-

I have no idea why the build fails on CI, it works fine on my machine.

I have no idea why the build fails on CI, it works fine on my machine.

It needs #3314 or similar to avoid the kernel panic.

bors r+


dev: Remove dependencies

Hi @jsanc623 I came here from this comment you made here  . Can you give more info on this issue, would love to work on it

Hi @jsanc623 I came here from this comment you made here . Can you give more info on this issue, would love to work on it

Hi @yimikao ! My apologies for just seeing your comment - with this particular issue, I would like to reduce the overall number of external dependencies where possible. If you'd like to tackle other issues that would be welcome as well, or you can contribute whatever code you'd like to the project


expose typescript type definitions

Description

Exposes the typescript type definitions.
Sets the interface-name eslint rule to "never-prefix" so exposed TS interfaces don't have to begin with a prefix of I.
Adds the gmaps property to the Suggest interface (it was being left out before).
Renames Props to GeosuggestProps for clarity.

Checklist

[x] All tests passing
[x] Created tests which fail without the change (if possible)
[x] Extended the README / documentation, if necessary
[x] Commits and PR follow conventions

There were some small changes to the gmaps type in the master branch through another PR (#399), but as this needs to be changed either way I guess it’s adjusted easily.

Closing this due to inactivity. Opened an issue for this: #467


Failed to update environment: invalid character '<' looking for beginning of value

Intermittently getting following errors after upgrading to the golang client sdk version 3.5.0:-
Failed to update environment: invalid character '<' looking for beginning of value
"Failed to update environment: invalid character 'E' looking for beginning of value"
Any help will be highly appreciated
Thanks!

Hi @nishant-shah-social, can you provide a bit more information here please? Where are you seeing this error please?
If you can provide information about your setup, that would be very helpful.
For example, the following details will be necessary for us to investigate this:

How are you running Flagsmith? SaaS or self-hosted?
How are you initialising your SDK? Please provide code examples where possible.

Any other information you can provide that might help us will be very helpful as well. Thanks!

Hi @nishant-shah-social, can you provide a bit more information here please? Where are you seeing this error please?
If you can provide information about your setup, that would be very helpful.
For example, the following details will be necessary for us to investigate this:

How are you running Flagsmith? SaaS or self-hosted?
How are you initialising your SDK? Please provide code examples where possible.

Any other information you can provide that might help us will be very helpful as well. Thanks!

Sure @matthewelwell !
We are using flagsmith self-hosted. The server is at version 2.129.0
We are using local evaluation mode
the code snippet
flagsmithConf := flagsmith.Configuration{
		Environment:                cfg.FlagsmithClient.Environment,
		ApplicationName:            cfg.FlagsmithClient.ApplicationName,
		ServerSideAPIKey:           cfg.FlagsmithClient.ServerSideApiKey,
		ClientSideAPIKey:           cfg.FlagsmithClient.ClientSideApikey,
		BaseURL:                    cfg.FlagsmithClient.BaseURL,
		RequestTimeout:             cfg.FlagsmithClient.RequestTimeout,
		Retries:                    cfg.FlagsmithClient.Retries,
		RetryDelayInterval:         cfg.FlagsmithClient.RetryDelayInterval,
		EnvironmentRefreshInterval: cfg.FlagsmithClient.EnvironmentRefreshInterval,
		EvaluationMode:             flagsmith.EvaluationMode(cfg.FlagsmithClient.EvaluationMode),
		FlagsmithCtx:               flagsmithCtx,
		PrometheusRegisterer:       reg,
		Logger:                     l,
		UserAgent:                  fmt.Sprintf("%s,%s", cfg.FlagsmithClient.ApplicationName, cfg.FlagsmithClient.Environment),
	}

	flagClient, err := flagsmith.NewFlagsmithClient(flagsmithConf)

where NewflagsmithClient() has the logic to set all the options and then initialize flagsmith with something like:-
client := flagsmith.NewClient(apiKey, flagsmithOpts...)

While evaluation, we use following call:-
identityFlags, err := fg.Client.GetIdentityFlags(fg.ctx, idStr, fgTraits)

Thanks,
Nishant Shah
Hope this helps! Let me know if any further info is required

Thanks for the details @nishant-shah-social, we'll take a look into this and update here with any findings.

@gagantrivedi incase you got time to look into it?

@nishant-shah-social The error sounds like your self-hosted Flagsmith is returning HTML instead of JSON. Could you double check that your API URL is something like https://flagsmith.example.com/api/v1/? The trailing slash is needed.

@nishant-shah-social did you have a chance to confirm regarding the outstanding question here?

@rolodato @matthewelwell Sorry for the delayed response. Our API URL does have this trailing slash. I see this error happening intermittently and not always. Further investigations revealed that his error occurs when due to some reason SDK is unable to connect to flagsmith when trying to call update environment. Still I would expect some logical error instead of this

I believe we're not handling this case correctly, where the API responds with a non-JSON 4xx-5xx response: https://github.com/Flagsmith/flagsmith-go-client/blob/ad6f7fe973687722680141f14b7e8dc7b9ebe260/internal/flaghttp/request.go#L150-L152.
There's probably no need to unmarshal JSON at all here and we can just return the status code as an error, which is what we're trying to do here anyway: https://github.com/Flagsmith/flagsmith-go-client/blob/ad6f7fe973687722680141f14b7e8dc7b9ebe260/internal/flaghttp/request.go#L161-L165. We'd appreciate a PR for this if you have the time :)

@nishant-shah-social Are you able to reproduce this same error with the latest 3.6.0? You should be able to see more details now on what's going wrong.


[release-1.5] Use JSON merge to update objects (#21083)

Manual cherry-pick.

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test gencheck_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test integ-istioio-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test gencheck_istio_release-1.5

integ-istioio-k8s-tests_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test integ-telemetry-k8s-tests_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test integ-istioio-k8s-tests_istio_release-1.5

integ-telemetry-k8s-tests_istio_release-1.5
d7490b202d9c42176001c4f3f65b8ec98b33f66c
link
/test integ-telemetry-k8s-tests_istio_release-1.5

gencheck_istio_release-1.5
acb8d46184d5aa17e7240e76846e5ff7407be9b4
link
/test gencheck_istio_release-1.5

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Hubble UI fails to render service map after helm deploy

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I deployed Cilium in AWS (EKS) with helm (using the template from the below command).
helm template cilium cilium/cilium --version 1.11.0 \
  --namespace kube-system \
  --set ipam.mode=cluster-pool \
  --set tunnel=vxlan \
  --set localRedirectPolicy=true \
  --set egressMasqueradeInterfaces=eth+ \
  --set nodeinit.enabled=false \
  --set hubble.tls.auto.method="cronJob" \
  --set hubble.listenAddress=":4244" \
  --set hubble.relay.enabled=true \
  --set hubble.ui.enabled=true \
  --set upgradeCompatibility="1.9" \
  --set encryption.enabled=true \
  --set encryption.nodeEncryption=false \
  --set encryption.type=ipsec \
  --set prometheus.enabled=true \
  --set operator.prometheus.enabled=true \
  --set hubble.metrics.enabled="{dns,drop,tcp,flow,icmp,http}" \
  --set labels="k8s:io.kubernetes.pod.namespace k8s:k8s-app k8s:app k8s:name k8s:spark-role"

The entire cluster is healthy (we're using a private registry, but these are just copies of the images referenced by helm 1.11.0)
❯ cilium status
    /¯¯\
 /¯¯\__/¯¯\    Cilium:         OK
 \__/¯¯\__/    Operator:       OK
 /¯¯\__/¯¯\    Hubble:         OK
 \__/¯¯\__/    ClusterMesh:    disabled
    \__/

DaemonSet         cilium             Desired: 2, Ready: 2/2, Available: 2/2
Deployment        cilium-operator    Desired: 2, Ready: 2/2, Available: 2/2
Deployment        hubble-relay       Desired: 1, Ready: 1/1, Available: 1/1
Deployment        hubble-ui          Desired: 1, Ready: 1/1, Available: 1/1
Containers:       cilium             Running: 2
                  cilium-operator
                  hubble-relay       Running: 1
                  hubble-ui          Running: 1
Cluster Pods:     44/44 managed by Cilium
Image versions    hubble-relay    quay.io/ascendio/hubble-relay:v1.11.0: 1
                  hubble-ui       quay.io/ascendio/hubble-ui:v0.8.3: 1
                  hubble-ui       quay.io/ascendio/hubble-ui-backend:v0.8.3: 1
                  hubble-ui       quay.io/ascendio/envoy:v1.18.4: 1
                  cilium          quay.io/ascendio/cilium:v1.11.0: 2

I run kubectl port-forward -n kube-system hubble-ui-5b7f99fcb6-5qqf2 :8080 and navigate to the output address in my browser and see this error

I see some connection retries in hubble-relay (although they seem to stabilize after single retries). Neither hubble backend, frontend, nor proxy is producing any errors.
Cilium Version
❯ cilium version
cilium-cli: v0.10.0 compiled with go1.17.4 on darwin/amd64
cilium image (default): v1.11.0
cilium image (stable): v1.11.1
cilium image (running): v1.11.0

Kernel Version
Linux version 5.4.156-83.273.amzn2.x86_64 (mockbuild@ip-10-0-39-220) (gcc version 7.3.1 20180712 (Red Hat 7.3.1-13) (GCC)) #1 SMP Sat Oct 30 12:59:07 UTC 2021
Kubernetes Version
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:10:45Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.5-eks-bc4871b", GitCommit:"5236faf39f1b7a7dabea8df12726f25608131aa9", GitTreeState:"clean", BuildDate:"2021-10-29T23:32:16Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}

Sysdump
cilium-sysdump-20220207-230512.zip
Relevant log output
# hubble relay
level=warning msg="Failed to create gRPC client" address="<IP_ADDRESS>:4244" error="connection error: desc = \"transport: error while dialing: dial tcp <IP_ADDRESS>:4244: connect: connection refused\"" hubble-tls=true next-try-in=10s peer=ip-192-168-9-213.ec2.internal subsys=hubble-relay
level=info msg=Connecting address="<IP_ADDRESS>:4244" hubble-tls=true peer=ip-192-168-9-213.ec2.internal subsys=hubble-relay
level=info msg=Connected address="<IP_ADDRESS>:4244" hubble-tls=true peer=ip-192-168-9-213.ec2.internal subsys=hubble-relay

# hubble-ui backend
level=info msg="initialized with TLS disabled\n" subsys=config
level=info msg="listening at: <IP_ADDRESS>:8090\n" subsys=ui-backend

# hubble-ui proxy
❯ kubectl logs -n kube-system hubble-ui-5b7f99fcb6-fx9j7 -c proxy | grep -v info
[2022-01-25 18:51:33.139][1][warning][main] [source/server/server.cc:506] No admin address given, so no admin HTTP server started.
  - name: base
    static_layer:
      {}
  - name: admin
    admin_layer:
      {}
[2022-01-25 18:51:33.151][1][warning][main] [source/server/server.cc:642] there is no configured limit to the number of allowed active connections. Set a limit via the runtime key overload.global_downstream_max_connections

Anything else?
I'm seeing this same issue in EKS, AKS, and GKE, so I'm assuming that it's either a bug or an issue of my config (we're using very similar config in all 3 clouds)
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @thejosephstevens! Could you try to port-forward to :80 port? kubectl port-forward -n kube-system hubble-ui-5b7f99fcb6-5qqf2 :80

Hi @thejosephstevens! Could you try to port-forward to :80 port? kubectl port-forward -n kube-system hubble-ui-5b7f99fcb6-5qqf2 :80

So that doesn't work
❯ kubectl port-forward -n kube-system hubble-ui-5b7f99fcb6-ggfvl :80
Forwarding from <IP_ADDRESS>:49652 -> 80
Forwarding from [::1]:49652 -> 80
Handling connection for 49652
E0208 11:07:30.135684   55786 portforward.go:400] an error occurred forwarding 49652 -> 80: error forwarding port 80 to pod 48e3f8b225b5eb1144574b4063b3dc89ee7d2a44ae11795bd27e3ab9cd621ab2, uid : failed to execute portforward in network namespace "/var/run/netns/cni-7af0be4c-347f-472f-aa2b-be6cd7aa9508": failed to dial 80: dial tcp4 <IP_ADDRESS>:80: connect: connection refused

but I got a response in slack and it turns out that using these commands works
cilium hubble port-forward&
cilium hubble ui
# browser opens to the hubble ui with all the namespaces correctly populated

So this will work fine for us and I'm happy to close the issue, but I guess I should ask, is that expected? Since I have this set up I'm happy to run tests if the original method I was using to port forward to the ui is supposed to work.

So I just took a look at the docs here and it gives the right instructions to use the cilium cli to get to the hubble ui. I also got another note in Slack to use kubectl -n kube-system port-forward svc/hubble-ui 12000:80, which also works. I'll go ahead and close this since this appears to be a clear case of me failing to RTFM. If there's any follow-up questions feel free to ping me.


KAFKA-7811: Avoid unnecessary lock acquire when KafkaConsumer commits offsets

Avoid unnecessary lock acquire when KafkaConsumer commits offsets.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

LGTM.


Update VS versions and xUnit

Updated and sorted VS versions.
Updated VS updater instructions.
Updated xUnit to 2.4.2.

Codecov Report

Merging #114 (db54197) into main (aabe306) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          729       733    +4
=========================================
+ Hits           729       733    +4

Impacted Files
Coverage Δ

src/SlnUp.Core/VersionManager.g.cs
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[HttpPlatformHandler]: Allow retrieving the PID of the process via a DEBUG verb

When we launch a webserver behind httpplatformhandler in VS, VS needs to be able to get the pid so that it can attach the debugger. There are 2 scenarios:

Launching IIS Express
Launching in IIS

The way this works today is that vs sends a request with a DEBUG verb that gets the pid. We might need to support this when running  in a particular mode.
We need to flesh this out

Hosting will automatically handle a request that the application never sees? Hmm. This should only be enabled in Development mode.

Yes

What if this was inverted? Have a option that would make Hosting take some action to inform interested parties that the server was ready. E.g. make an HTTP request to a given url, write to an event log or a named pipe, etc..

We can closes this. The Http platform handler will  allow passing the port to forward to. This means VScan launch the web server with the required port

Nevermind, we still need to do this.

Should we put this in the middleware?

By all means.

The only problem is rhat debugging won't work in vs without it which is a bit insane 😞

Well, start in the middleware and push it down later if it turns out terrible.

On a related note, how can they debug startup errors? The FailSafeLoader will help, but then then Hosting will have to implement the DEBUG logic.
How about server or hosting config issues? I think the debugger would have to attach very early to debug these.

This needs to be fixed a different way: https://github.com/aspnet/dnx/issues/2810


HTML error 500: not sure where to even begin

Describe the bug
I had Bookstack working for several weeks on my Ubuntu 14.04.6 LTS system (yes I realise this is quite old but I am loathed to update). However, today I suddenly received HTTP error 500 when trying to access the website.
Steps To Reproduce

Go to the website.

Expected behavior
The Bookstack was working just fine until recently.
Your Configuration (please complete the following information):

Bookstack version: v0.29.3
PHP Version: 7.3.21
Hosting Method (Nginx/Apache/Docker): Apache (I think)

Additional context
I'm not sure if it's helpful but I'll copy a few lines from the laravel.log file
2020-08-26 00:45:05] production.ERROR: SQLSTATE[HY000] [1045] Access denied for user 'database_username'@'localhost' (using password: YES) (SQL: select * from information_schema.tab$
[stacktrace]
#0 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connection.php(629): Illuminate\\Database\\Connection->runQueryCallback('select $
#1 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connection.php(338): Illuminate\\Database\\Connection->run('select * from i...',$
#2 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Schema/MySqlBuilder.php(18): Illuminate\\Database\\Connection->select('select * $
#3 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Migrations/DatabaseMigrationRepository.php(169): Illuminate\\Database\\Schema\\M$
#4 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php(590): Illuminate\\Database\\Migrations\\DatabaseMigratio$
#5 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Console/Migrations/MigrateCommand.php(91): Illuminate\\Database\\Migrations\\Mig$
#6 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Console/Migrations/MigrateCommand.php(63): Illuminate\\Database\\Console\\Migrat$
#7 [internal function]: Illuminate\\Database\\Console\\Migrations\\MigrateCommand->handle()
#8 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(32): call_user_func_array(Array, Array)
#9 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Container/Util.php(36): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closu$
#10 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(90): Illuminate\\Container\\Util::unwrapIfClosure(Object(Closu$
#11 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(34): Illuminate\\Container\\BoundMethod::callBoundMethod(Objec$
#12 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Container/Container.php(590): Illuminate\\Container\\BoundMethod::call(Object(BookStack\$
#13 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Console/Command.php(134): Illuminate\\Container\\Container->call(Array)
#14 /var/www/mydomain.com/public_html/BookStack/vendor/symfony/console/Command/Command.php(255): Illuminate\\Console\\Command->execute(Object(Symfony\\Component\\Console\\Input$
#15 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Console/Command.php(121): Symfony\\Component\\Console\\Command\\Command->run(Object(Symf$
#16 /var/www/mydomain.com/public_html/BookStack/vendor/symfony/console/Application.php(1001): Illuminate\\Console\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvI$
#17 /var/www/mydomain.com/public_html/BookStack/vendor/symfony/console/Application.php(271): Symfony\\Component\\Console\\Application->doRunCommand(Object(Illuminate\\Database\$
#18 /var/www/mydomain.com/public_html/BookStack/vendor/symfony/console/Application.php(147): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\$
#19 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Console/Application.php(93): Symfony\\Component\\Console\\Application->run(Object(Symfon$
#20 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(131): Illuminate\\Console\\Application->run(Object(Symfony$
#21 /var/www/mydomain.com/public_html/BookStack/artisan(35): Illuminate\\Foundation\\Console\\Kernel->handle(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfo$
#22 {main}

Same issue on Ubuntu 18.04.5 LTS

I examined the issue linked here and it was suggestred by @ssddanbrown to use tail -f /var/log/apache2/error.log.
Upon doing so I get:
[Sun Oct 11 18:02:09.090995 2020] [php7:error] [pid 390] [client <IP_ADDRESS>:54397] PHP Fatal error:  Uncaught PDOException: SQLSTATE[HY000] [2002] No such file or directory in /var/www/mydomain.com/public_html/BookStack/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:27\nStack trace:\n#0 /var/www/mydomain.com/public_html/BookStack/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php(27): PDO->__construct('mysql:host=loca...', 'bookstack', 'mypassword', Array)\n#1 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php(67): Doctrine\\DBAL\\Driver\\PDOConnection->__construct('mysql:host=loca...', 'bookstack', 'mypassword', Array)\n#2 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connectors/Connector.php(46): Illuminate\\Database\\Connectors\\Connector->createPdoConnection('mysql:host=loca...', 'bookstack', 'mypassword', Array)\n#3 /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connectors/MySqlConnector.php(24): Illumin in /var/www/mydomain.com/public_html/BookStack/vendor/laravel/framework/src/Illuminate/Database/Connection.php on line 669, referer: http://www.mydomain.com/

@Vanillabacke
I am not sure what was the issue but reading this thread, I tried the following:
sudo service mysql status
which informed me
mysql stop/waiting
I then did this
sudo /etc/init.d/mysql restart
and it said
stop: Unknown instance:
mysql start/running, process 14768

and now things seem to be working again. Again I am not sure what caused the issue but it is perhaps not a Boosktack issue.

Thanks @ThSGM for confirming you found a solution. Will therefore close this.
@Vanillabacke On Ubunutu 18.04 you might need to instead run sudo systemctl restart mysql. You should be able to see the status of the database with sudo systemctl status mysql. Feel free to open a new issue if the above does not resolve your issue.


Feature Request: Develop Issue Command

Issue Description
Type: feature request
Describe what happened (or what feature you want)
I'm not sure if this is already implemented (I tried looking and couldn't find any documentation or mentions in the discussions/issues about it, but apologies if I just missed it), but I think it would be useful to be able to use the gh issue develop #X --checkout command to turn an issue into a new branch.
Describe what you expected to happen
The GitHub CLI has an option to turn an issue into a branch and then check it out on your local machine (among other options).
https://cli.github.com/manual/gh_issue_develop
I think it would be useful to be able to either: 1) open up the Issue list, open an issue in a buffer, and then use an Octo command to be able to send the above command to develop an issue branch; or 2) use an Octo command to bring up a Telescope viewer where you can select an issue to develop, and then you are given a dropdown to select the extra flags you would like to apply (like using templates for issue creation). Option 2) would be cleaner and faster, in my opinion, but likely also be more work.
I would offer to help, but I'm afraid I am not familiar enough with scripting in Lua and Telescope, so I don't think I'd be of much help.
Thanks for your work putting out a great plugin.
EDIT: Embarrasingly, I've just seen this discussion https://github.com/pwntester/octo.nvim/discussions/392 right near the top, but I think the feature request is still valid as it potentially provides a mechanism through the CLI to implement this? Please close if you feel it is not required.

I think both options would be very useful. I've been playing around with the GitHub CLI commands required here and it seems like there might be some permission issues when trying to create a linked branched to the upstream repo from a fork.

Hi @arnold-c
I have implemented this in #609 . 1 and 2 are both available for telescope. However, I haven't implemented 2 for other pickers


About the code of finetuning on the specific dataset

Thanks for this siginificant and interesting work.
Open-source work is helpful to the developer
In the paper, the authors write "In particular, we use both global semantic context and local fine-grained features by fusing SAM’s mask decoder features with early and late feature maps from its ViT encoder. During training, we freeze the entire pre-trained SAM parameters, while only updating our HQ-Output Token, its associated three-layer MLPs, and a small feature fusion block.". Is there a demo to run the training code or should we reproduce them by ourselves?
Thanks & Regards!
Momo

Hi, thanks for watching HQ-SAM. We are organizing the training/finetuning codes and will release it after it's ready. Please stay tuned!

Cool. Looking forward to the training code.

Hi, thanks for watching HQ-SAM. We are organizing the training/finetuning codes and will release it after it's ready. Please stay tuned!

looking forward~！

looking forward~！

looking forward~！

Thanks, we plan to release it at the beginning of July.

looking forward~

Looking forward, fine-tuning on this powerful tool would be excited!

Thanks. It will be ready this week.

Hi, we released the training codes for SAM tuning.


testnet network support - 90a1joa8n0uztve - validator,rpc,api

@stateb, Your Moniker and validator addresses are required, please update the PR with those details.

@stateb, Your Moniker and validator addresses are required, please update the PR with those details.


Example for using hass.states in transform:

Checklist

[X] I am running the latest version of the card
[X] I checked if there isn't another feature request opened with the same request
[X] I checked that the feature is not already available in the dev branch

Is your feature request related to a problem? Please describe.
I don't manage to understand how to use the hass.states object in the configuration for transform:
Can you please include a config example where the state from another object is used?
Thanks in advance.

To access an entity state (it's the actual state, not the historical state): hass.states['sensor.my_sensor'].state


Installation using script fails with SAN mismatch error

Environmental Info:
K3s Version: NA
Node(s) CPU architecture, OS, and Version:
Linux 5.19.0-46-generic
Cluster Configuration: NA
Describe the bug:
K3S Installation on master node fails with SAN mismatch error:
# curl -fL https://get.k3s.io
curl: (60) SSL: no alternative certificate subject name matches target host name 'get.k3s.io'
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Steps To Reproduce:
Install K3S using the following command:
curl -fL https://get.k3s.io |  sh -

Expected behavior:
Installation must succeed.
Actual behavior:
Installation fails with SAN mismatch error.

I was running it on my home Linux server. I was able to install again this morning. The issue seems to be sporadic. Closing this for now.


Added turkish language pack

[x] This PR actually submits something - don't use this system as a messaging service!
[x] This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
[x] This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
[x] This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
[x] This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
[x] This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description
Added turkish language pack

Optional information
{Type something here}

Okay


Search for content containg comma

Is it possible to search for content, like "Smith, John"?
Right now, it is looking for "Smith" OR "John".
Is there some kind of config to disable "OR" functionality for comma, or change it to another character?

There is no way to do that using configuration.

ok. I've found a workaround for now. If I append (or prepend) a wildcard character, the search is performed. For the above mentioned example, "Smith, John" does not work, but "Smith, John%" works.
I consider it a minor disadvantage comparing to the huge time saving in development. So, just accept my thanks for your effort.

Nice, I didn't think of such workaround. I'm glad you got that to work.
Without a workaround the only way I see to allow commas in the searched string is to use alternate syntax for IN search, which would be not backwards compatible. I could do that in a future release.


Fix negative route params

Fix #1437.
Now you should be able to use negative int and long as url parameters.

Thanks, @KristianJakubik! I made a couple of further tweaks so moving this over to #1474


How to clean after a failed serverpod create attempt ?

I had faced this many times.
1- serverpod create mypod failed, due to some error. Usually due to netstat being absent
2- I remove the mypod folder.
3- I use docker-compose down to stop the containers
4- I (in some cases) use docker rm to remove the containers
5- I fix the error (install netstat if needed)
6- serverpod create mypod again
7- docker-compose up --build --detach
8- dart bin/main.dart Then I get Failed to connect to database.
PostgreSQLSeverity.fatal 28P01: password authentication failed for user "postgres"
9- If I do serverpod create mypod2 it works.
How to solve this issue in step 8 ?

Yes, that is because the volumes that are being used by the same name already exist. You need to clean the volumes too. @mozexty

There may be some other reasons too. But in your case, This is the case as I mentioned.

Thank you @yahu1031.
I removed the volumes and it worked.


Segue from VC to Tab Bar VC

So in my StoryBoard i have the Login screen with the TKSubmitTransition button on it.
The button has a segue which first goes to a CustomNavigationController, then goes to a Custom Tab Bar View Controller. Then the first index to load in the tab bar is another Home View Controller.
Now my question is how i can fade my screen from the Login Screen to the Home View Screen?
In my LoginVC i performSegue and try to do
"destinationViewController.transitioningDelegate = self"
However, destinationVC is showing up as CustomNavVC and none of my UIViewControllerTransitioningDelegate functions in my LoginVC are being called?!
Thanks.

@nadimalam Can I have a screenshot?


[flutter_tools] Throw in flutter test with device

Fixes https://github.com/flutter/flutter/issues/125070

In looking at the failures and the code, I realize this is the wrong change to make, as the --device-id flag can still be parsed when running integration tests. it appears it's specifically the --device-id=chrome that is getting ignored.


Issue with nested compound nodes layout.

I have nested compound nodes but it seems that cose-bilkent failed to layout them properly. Basically in the end all nodes end-up on the same position.
see http://jsbin.com/qacuzalobi/edit?html,console,output

Interestingly in this graph all nodes end-up the same positions. I think that it must be a bug appearing rarely. In this demo ( http://htmlpreview.github.io/?https://github.com/cytoscape/cytoscape.js-cose-bilkent/blob/master/demo-compound.html )  cose-bilkent layout a nested graph successfully.

Apparently it is not related to nested compounds. This more general issue, here is the same behaviour with only one compound node http://jsbin.com/dirurisiti/edit?html,output.

ok, so this happens if node inside compound node has edge to parent node. I simplified previous example.

@aindlq CoSE layout cannot handle such "cyclic" edges and probably just returns without performing layout. If your application allows such edges, simply temporarily remove them before calling cose-bilkent layout.

Thank you for your help! It works if I filter edges before layouting.


Update logback-classic to 1.1.11

Updates ch.qos.logback:logback-classic from 1.1.9 to 1.1.11.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]

labels: semver-patch

Closing and reopen to trigger CI


[STORM-2093] Fix permissions in multi-tenant, secure mode

Heap dumps created on OOM, when served through the logviewer in secure multi-tenant configurations have permissions set such that the logviewer cannot read them.
This change checks permissions in this case before serving and then runs the worker-launcher to enable the logviewer to serve them.
see https://github.com/apache/storm/pull/2032

@revans2 Yes, I tested it manually.

+1

+1
@Ethanlm Could you squash commits into one? Thanks in advance.


Ruby group capstone: set up your Kanban board

Github Project board: https://github.com/AyoubMs/catalog_of_my_things_ruby/projects/1
We are three students in this project,

Team member 1: @Ismailco
Team member 2: @AyoubMs
Team member 3: @OybekKayumov

STATUS: CHANGES REQUIRED ♻ ♻
Hi @Ismailco, @OybekKayumov and @AyoubMs,
Good job so far!
✔ Kanban board has the correct number of columns
✔ Tasks are assigned
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

[ ] Some of your tasks are missing the allocated number of points. Kindly add them.

[ ] The following tasks do not have proper descriptions. Kindly add them.

Image 1
Image 2

Figure 3
Figure 4

[ ] The total number of task points assigned to a team member is required to be less than 5 in comparison to another member. @Ismailco total points are 29pts; @OybekKayumov total points are 33pts; @AyoubMs has 50 points. Kindly re-allocate your points.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Ismailco, @OybekKayumov and @AyoubMs,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Required Changes ♻
Check the comments under the review.

[ ] As requested by the previous reviewer, kindly ensure that all the tasks have the required description. The task in the attachment does not have a description so, kindly add it.

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

**STATUS: APPROVED  🟢 **

Hi team,
Great work on making the changes requested by a previous reviewer 👏🏻
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟

Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.

As described in the Code reviews limits policy you have  limited number of  reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


Validation webhook fails to prevent IST0106 when VirtualService is missing weight attribute during manual editing 'kubectl edit vs'

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We observe that the missing weight attribute in virtualservice can cause IST0106
 istioctl analyze -A | grep Error

Error [IST0106] (VirtualService argocd/vs-demo-pricer-app) Schema validation error: total destination weight = 0
This can lead to very serious problems:

Stale RDS cause weird 503 nc cluster not_found error
even worse, if istio-ingressgateway is restarted manually or due to system patching, lead to stale RDS and lose all porxy configs -- 404 for all api calls

STALE (Never Acknowledged)
This issue is confirmed to affect at least to these 2 versions  -- 1.19.3 and 1.20.2
Version
istioctl version
client version: 1.20.2
control plane version: 1.20.2
data plane version: 1.20.2 (12 proxies)

Additional Information
the istio validation webhook should reject the editing of virtualservice if weight is missing from the manifest

Hi @kelvin-j-li ,
I'd like to clarify a point regarding the request "the istio validation webhook should reject the editing of virtualservice if weight is missing from the manifest".
The webhook should not reject edits to a VirtualService simply because the weight is missing from the VS. Weight is an optional parameter, and its absence makes sense for a VirtualService with only one route.
The error message you're encountering in istioctl analyze likely occurs because you have a VirtualService with multiple routes where the sum of the weights for all destinations is zero (either because the weights are absent in all the routes or because they all have weight: 0).
Anyway, I attempted to reproduce the issue by editing an HTTP bin VirtualService with multiple routes to have a total destination weight of zero. The validation webhook behaved as expected and successfully blocked both the edit and the apply operation.
[leosarra@workstation istio-1.20.2]$ kubectl edit virtualservice httpbin -n istio-system
error: virtualservices.networking.istio.io "httpbin" could not be patched: admission webhook "validation.isto.io" denied the request: configuration is invalid: total destination weight = 0
You can run `kubectl replace -f /tmp/kubectl-edit-44727324.yaml` to try this update again.

To help me troubleshoot further, could you provide a minimal example with steps that reproduces the issue you're facing? This will help me in investigating it further.

hi @leosarra,
Thanks so much for your reply. I think your summary is correct -- the error was due to multiple routes with 0 sum.
I was not able to re-produce the issue on my end, because the offending vs was removed.
You may proceed with closing this issue.
Thanks.

I will close the ticket for now.
If you end up encountering the same issue in the future please let ping me and I will take a look :)


SPFx Ext Field Customizer Hide/Show Based On List/Library "Edit Mode"

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version: N/A
SPFx version: v1.12, v1.13 or v1.14
Node.js version: v14.x or v16.x
etc

Issue description
I'm working on an SPFx extension that needs to render a string in display mode, but when it's in edit mode it should render a dropdown select field. On a library, this would be the "edit in grid view". On a list, it would be "edit" (with the modal form) or with "edit in grid view".
How can you track the state of the list/library, and render the field accordingly?

I did find the import module for display mode. This does capture the display mode effectively, but now the component doesn't render. The "view" mode is showing the text correctly, but the "edit" mode is not showing the dropdown.
import { DisplayMode } from '@microsoft/sp-core-library';

Then it's used in a if function like this...
// not in display read, meaning it's edit mode
if (!DisplayMode.Read) {
 // edit mode component
} else {
// display mode component
}

@jared-leddy unfortunately Field Customizers are not supported in edit mode.


What exactly should servers do when they receive events over federation

The spec is unclear about what exactly needs to be done when receiving pdus via the /send request. Here's what we came up with when developing Conduit:
When receiving an event one needs to:

Skip the PDU if we already know about it
Check the server is in the room
Check signatures, otherwise drop
Check content hash, redact if doesn't match
Fetch any missing auth events doing all checks listed here starting at 1. These are not
timeline events
Reject "due to auth events" if can't get all the auth events or some of the auth events are
also rejected "due to auth events" (TODO: Or should be just drop and ignore bad events?)
Reject "due to auth events" if the event doesn't pass auth based on the auth events
Persist this event as an outlier
If not timeline event: stop
Fetch any missing prev events doing all checks listed here starting at 1. These are timeline
events (TODO: probably queue this up in the background so we don't wait for this)
Fetch missing state and auth chain events by calling /state_ids at backwards extremities
doing all the checks in this list starting at 1. These are not timeline events
Check the auth of the event passes based on the state of the event
Ensure that the state is derived from the previous current state (i.e. we calculated by
doing state res where one of the inputs was a previously trusted set of state, don't just
trust a set of state we got from a remote) (TODO: we do this be always inserting our current room state into stateres, is that right?)
Check if the event passes auth based on the "current state" of the room, if not "soft fail"
it
Use state resolution to find new room state

Check the server is in the room

How to determine that ? I guess a server is in a room if a least one user from this server is a room member ?

Check the auth of the event passes based on the state of the event

server spec specifies that events should/must pass auth rules based on event’s auth events, state at the event (taken from prev_events) and/or current state of the room.

1: Currently Conduit thinks it's in a room once it joined the room once, so it can't leave it
11: The other auth checks are at 6 and 13

What do you mean by :

If not timeline event: stop

Only "timeline events" go through the next steps, non-timeline events will not be processed further.
What is and isn't a timeline event is determined by sentences like "These are (not) timeline
events" (e.g. step 4, 9)

Conduit doesn't do step 5 any longer because it failed too often when joining some rooms

Conduit doesn't do step 5 any longer because it failed too often when joining some rooms

Synapse seem to also prevent joins with rooms where bad auth events are present. Atleast my bot encountered that with atleast 2 rooms now.


Add date filter

We have the published_at column in the courses table. Let's leverage that! It would be awesome to be able to filter the courses by the most recent
Update: I am now ordering the courses by published_at, showing the most recent first. TBH I don't know why would someone choose to order by older courses first, so I'm considering archiving this issue.

Yep, I don't think this is necessary anymore, we are already showing the most recent courses first, so closing this issue for now.


Improving the ThreadManager and TokenRefresher APIs

This is a follow up to #74. It attempts to solve several issues in the current design:

ThreadManager interface returns a ScheduledExecutorService. This makes implementing the ThreadManager API cumbersome, since the default implementation provided in Java (ScheduledThreadPoolExecutor) is not very amenable to configuration.
The different uses of the getExecutor() and getThreadManager() methods are not well defined in the ThreadManager interface. At the moment it is something along the lines of:

getThreadManager(): for RTDB
getExecutor(): for everything else

Proactive token refresher always get started when calling initializeApp() (which starts long-lived threads). But only RTDB requires it in practice. This is not ideal when using the SDK only for auth operations.

To resolve these issue, this PR makes the following changes:

Clearly define the contract of the ThreadManager interface.

getThreadMaanger(): Used to start long-lived threads (including RTDB, token refresher and anything else that would require long-lived threads in the future)
getExecutor(): Used for short-lived tasks.

Return an ExecutorService from ThreadManager, whose default implementation (ThreadPoolExecutor) is much easier to configure.
Invert the control of the proactive token refresher. Instead of always starting it from the app, let RTDB (or any other interested component) start it on demand.

The downside of this change is that we end up using a dedicated executor for proactive token refresher (we can use it for other scheduled tasks that we may add in the future -- but for now it's only used for token refresher). In GAE this will end up occupying a separate background thread. This shouldn't be a problem for those who are only using RTDB, but GAE users who access both RTDB and auth ends up spending another thread.  However, it is possible to provide a custom ThreadManager that uses request-scoped threads for short-lived tasks, which is one way to avoid this drawback.

I did some testing on GAE for this PR. Auto and manual scaling works as before. Basic scaling also works, and idle instance shutdown can be easily enabled with a custom ThreadManager:
static class BasicScalingThreadManager extends ThreadManager {

    @Override
    protected ExecutorService getExecutor(@NonNull FirebaseApp firebaseApp) {
      // Use a single-threaded executor which keeps threads alive for 1 minute.
      return new ThreadPoolExecutor(0, 1,
          60L, TimeUnit.SECONDS, new SynchronousQueue<Runnable>(), getThreadFactory());
    }

    @Override
    protected void releaseExecutor(@NonNull FirebaseApp firebaseApp,
        @NonNull ExecutorService executorService) {
      executorService.shutdownNow();
    }

    @Override
    protected ThreadFactory getThreadFactory() {
      return com.google.appengine.api.ThreadManager.backgroundThreadFactory();
    }
}

My test GAE instance also has a 1 minute idle timeout.  The test is coming up on 24 hours now and seem to be working fine.

Made some of the suggested changes. Responded to all open comments. On to the next round.


Update mix.exs

Update mix.exs poison dependency version.
Seems to be incompatible again with Phoenix 0.13.1
With this little change, it works.

thanks @alexjp


fix(gatsby-nodejs): duplicate Dot in File Ext

Description
Removed extra dot[.] in the extensions.
Related Issues
#455

@moonmeister
Please check the changes now

I don't have time and we have no dedicated folks for working on this
plugin. Are you having trouble testing it?
On Fri, Oct 13, 2023, 20:17 Yash Gupta @.***> wrote:

@.**** commented on this pull request.
In packages/gatsby-source-airtable/gatsby-node.js
https://github.com/gatsby-uc/plugins/pull/457#discussion_r1358989271:

@@ -306,7 +306,7 @@ const localFileCheck = async (key, row, { createNodeId, createNode, store, cache
cache,
createNode,
createNodeId,

     ext: extension ? `.${extension}` : undefined,

Hi @moonmeister https://github.com/moonmeister, Sorry for the delay.
Can you please help to test this on an example site? Or any one from the
team?
—
Reply to this email directly, view it on GitHub
https://github.com/gatsby-uc/plugins/pull/457#discussion_r1358989271,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAU2W54J2MGCWTKLWWWTZTTX7HKZXANCNFSM6AAAAAA5DDO47Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix Nova and model tests

Do we need to mock the Cloudinary image size return? Or should we just remove that test?

@drewroberts The mock for the image size check is working, so this should be good to go.


Organization Create Volunteer Slots (And Limit Them)

As the title suggests, this comes with event creation.
(In which this was actually implemented in #2 )

Completed in #2


Add infrastructure for proper logging

Currently the only logging in the system is about user activity. Any errors or problems that happen are usually only reported to the user that is logged in, who will probably not know what to do with that information and probably don't care.
A system log should be introduced where events can be logged on different levels (ERROR, WARN, INFO, DEBUG etc)

Turns out it's not quite done.. Remove the LOGFILE entry from System.cfg and convert FIDOLOGFILE to new logging as well.


Add support for tooltip

At least on Windows, it is standard for tray icons to have tooltips. Hence, I added an option to set one. (If the user doesn't want that, he can set NULL or an empty string)
I am only able to implement the Windows part though (I realize the check for TRAY_WINAPI isn't really necessary because on the other platforms it simply wouldn't do anything... I merely put it there for emphasis) and don't know what the common behavior on Linux distros and macOS is.

I can say macOS definitely does not have tooltips for menu bar icons and Linux is (as usual) a mixed bag. Some do, some don't.  It will also depend which desktop environment is being used. That being said, I would classify this feature as "Windows only" and therefore should not be part of a cross-platform library.

I find that an odd conclusion - any cross-platform library should only offer the lowest common denominator.
Reminds me of the cross-platform design philosophy of the 1990s - when software developed using such tools was always inferior because the UX simply wasn't adequate on any given platform.

I can see what you are saying.  There are always going to be some sacrifices when using cross-platform utilities such as this.  Usually x-platform applications have a single code base for the functionality and all UI/platform specific features are built on top of that for each platform.
Maybe setting a default tooltip such as the executable name would be a good middle-ground solution.

I appreciate that. :+1:
But... did you by any chance miss the part where I wrote that I made it optional? (If none is supplied then none will be shown)
Because I feel that it should be up to whoever is using this library whether they want to have a tool tip or not, even on Windows. It's not a question about dictating anything but providing the option and of course documenting that the feature is only available on platforms X & Y.

I agree with you that you don't HAVE to sacrifice anything.  A developer can implement as many features as they want.  I think in this case it is a question of expectancy.  Lets say a dev builds an app using Tray on Windows and decides to put some information about the process in the tooltip for users to have a quick look whenever they need to, then builds on macOS and there is no tooltip. Thus needing to re-write certain parts specifically for macOS/*nix to show an additional menu item for that information.
Granted, this wouldn't be difficult but it wouldn't be "expected behavior".  Starting down a road where some platforms have some features that others don't seems outside the scope of this project as it is not presented as a complete UI library.
Really though, we can lay out our POVs until we are dead but at the end of the day it isn't up to us.  It is up to the owner(s) of the project to decide the road ahead.

That's true. You seemed to speak with authority in your first post ("therefore should not be..."), so I assumed that you are an owner. :smile:


:NERDTreeFind fails if it's the first invocation of nerdtree

It would be nice if :NERDTreeFind worked even when nerdtree has not yet been used in the current Vim session. Currently it throws an error:
Error detected while processing function <SNR>41_findAndRevealPath..153:
line    2:
E605: Exception not caught: NERDTree.InvalidArgumentsError: <path>/<filename> should be under <path>

Is there a solution for this issue?


Update Project_doc.md

Added description of Trickaza - e-IPL Auction.

resolve conflicts

The conflict has been resolved.


WYSIWYG - Easier header rows

At the moment, to set a header on a table you have to click into the row > Click the table options in the top toolbar > Row > Row Properties > Change row type to header.
We should look to either make the first row, if more than one row, be a header or make it easier to set a header row.
Might be limited on TinyMCE control, Possibly hook into such an event like this:
https://github.com/tinymce/tinymce/blob/master/src/plugins/table/main/ts/api/Events.ts#L14
Might be tricky.

Confluence solved this by having the first row be a header by default and then adding a dedicated menu row for then a table is currently selected.

Thanks for the input and sharing of hack/workaround @Roemer, this promoted me to put in a solution for the next release.
Within 8f1d8cef9e71a324b599f012622d7be8f8e1f09a the header row toggle is dynamically shown as part of the existing table toolbar, when within the first row. Unlike your hack I havn't added the column header toggle, as I've not really seen much demand for header columns.

Thanks for the input and sharing of hack/workaround @Roemer, this promoted me to put in a solution for the next release. Within 8f1d8ce the header row toggle is dynamically shown as part of the existing table toolbar, when within the first row. Unlike your hack I havn't added the column header toggle, as I've not really seen much demand for header columns.

Hello, column headers would be nice. Seems to me this would just be feature parity. Why have the feature for rows, but not columns? Even if there isn't much demand yet. It's the exact same thing just on a different axis.
If the feature is already written, and exists, why not implement it?

Yes column headers would be nice.
Also, the ability to customise table to create a layout like this would be nice (merging cells, coloured headers, align on page like images) :


Select options that depends on another field value

Hi, lets say I have a collection called Countries and one called States. In the app, you can select a country and then multiple states from that country
And in my simpleschema:
countryId:{
 type: String,
 autoform:{
  type:'selectize',
  options:{
    return Countries.find().map(function (c) {
        return {label: c.name, value: c._id};
    });
  }
 }
},
statesIds:{
 type: [String],
 autoform:{
  type:'selectize',
  multiple:'true',
  options:{
    AutoForm.getFieldValue('countryId');
    return States.find({countryId:countryId).map(function (c) {
        return {label: c.name, value: c._id};
    });
  }
 }
},

The problem is, when an UPDATE autoform is generated (so I already have a country selected), the options of States are not populated until I change the country select field for something else (to call the 'change' event)
Is there a way to solve this?
(I know that this data modeling for countries/states is not the best for no-sql, but this was just an example)

@shactdeveloper do you solved?
I have infinite rerun on statesIds.auotoform.options function

Try using universe-select

Thanks for advice on universe-select. Look nice!
Actually my problem was that in put AutoForm.getFieldValue on a nested schema and from them siblings fields reactivy don´t fire.

This is most likely a problem with selectize plugin not properly implementing option reactivity.


Fix comment

fix #17
However, I cannot solve the delete button state. :pensive::pensive:

Hey thanks for the work !
Could you update your branch with master because I fix the CI ?
Thanks

Sorry, very busy recently, forgot to update

I close due to inactivity


FEATURE: mini.icons support

Did you check the docs?

[X] I have read all the docs.

Is your feature request related to a problem? Please describe.
Icons are displayed correctly when using nvim-web-devicons, buf fallback to a default icon when using mini.icons.
Describe the solution you'd like.
Support mini.icons, as it's reduced complexity is less likely to run into bugs and regressions.
Describe alternatives you've considered.
No response
Additional Context
No response

related: https://github.com/nvim-neo-tree/neo-tree.nvim/pull/1527
So far since it's just mini.icons and nvim-web-devicons maybe we could add a preset for those... will see if adoption for mini.icons keeps increasing and see what to do from there.

Thank you for pinging me @pynappo
closed by #1527


UI: change DPID with Interface ID when editing an EVC

The EVC edit page brings the interface ID of the UNIs as "DPID", which it should be Interface ID.

Additionally, it is a bit confusing the difference between "Interface" and "Port". Looking into the code I could understand that Interface is the OpenFlow value for the name of the interface, while Port will be a try to get the port_name from metadata. I would advise something else: Port Number and Port Name, where port Number is the number returned by OpenFlow; and Port Name will be a composite value from interface.metadata.port_name or interface.name

Finally, I suggest to change from "Node" to "Switch"


Typos abound in CONTRIBUTING, Basic Types, Functions, Interfaces

There's surely dozens of little typo, spelling, and grammar nuggets throughout this documentation. I aim to hunt them down and make them pay. 😎This issue is a task to survey these four arbitrary files because they're the ones I went through first.

Fixed, at least mostly, by #863.


Document that Mio report OOB data in Event::is_readable

Reporting Out-of-band (OOB) as readable it could leave applications open
to DoS attacks. However because Mio uses edge-triggers most applications
won't actually be effected.
Closes #1317.

/cc @piscisaureus


Question on Upload.

As we can see in Upload example it is necessary to have file as byte array for uploading, that is a problem for big file. It would be nice to add upload capabilitiy from InputStream in this SDK:
final String filename = "The Filename.txt";
final InputStream[] inputStream = new SomeInputStream(...); /* Not necessatily from a file on file system */
final IProgressCallback<Item> callback = new IProgressCallback<Item>() {
    public void success(final Item item) {
        Toast.makeText(getActivity(), "Item uploaded", Toast.LENGTH_LONG).show();
    }
    ...
    // Handle progress
    // Handle failure
}

oneDriveClient
    .getDrive()
    .getItems(ItemId)
    .getChildren()
    .byId(filename)
    .getContent()
    .buildRequest()
    .put(inputStream, callback);

That is a great ask, I've been working on a wrapper for using the chunked upload APIs, which I believe to be the more durable path for larger uploads.  When that features has a pull request out I'll make sure to include you for comments/feedback.

Thanks!
There is one more question about synchronous upload call. As I understand, the synchronous upload call looks like:
oneDriveClient
    .getDrive()
    .getItems(ItemId)
    .getChildren()
    .byId(filename)
    .getContent()
    .buildRequest()
    .put(fileContents);

If it is, I can't find the way to set ProgressListener to get an upload progress as it was possible in your package com.microsoft.onedriveaccess  (before onedrive-sdk-android release). Are you going to provide opportunity for setting of ProgressListener in the synchronous upload call?

I don't have plans to include progress callbacks for synchronous methods, if you wanted to perform this action in a synchronous-ish way with a IProgressCallback you could do the following at your own risk:
final AtomicReference<Item> result = new AtomicReference<>();
final SimpleWaiter waiter = new SimpleWaiter();
final IProgressCallback<Item> callback = new IProgressCallback<Item>() {
    @Override
    public void progress(final long current, final long max) {
        // Handle updates
    }

    @Override
    public void success(final Item item) {
        result.set(item);
        waiter.signal();
    }

    @Override
    public void failure(final ClientException ex) {
        // Handle errors
        waiter.signal();
    }
};

oneDriveClient
        .getDrive()
        .getItems(ItemId)
        .getChildren()
        .byId(filename)
        .getContent()
        .buildRequest()
        .put(fileContents, callback);
waiter.waitForSignal();
// Use result.get();

Note: this is the method to how some of the async methods our dependent libraries were unwound to be synchronous

Thanks for clarification. Do we have opportunity to cancel uploading on user request in the SDK?


Windows: Add icon for KBFS mount root

The Windows resource writing library didn't expose any way to add more than 1 icon, so we pulled in some of it. Should it have been forked instead?

@maxtaco @oconnor663

Hi, ping. CircleCI failure is expected?

@zanderz do you have a minute to VC and help me understand what this resource library is doing?

hi

ping @oconnor663 on the review

👍


Update UG (14 of 14)

Codecov Report

Merging #317 (13ceddc) into master (fec29f2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #317   +/-   ##
=========================================
  Coverage     84.51%   84.51%
  Complexity     1652     1652
=========================================
  Files           143      143
  Lines          4326     4326
  Branches        541      541
=========================================
  Hits           3656     3656
  Misses          548      548
  Partials        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec29f2...13ceddc. Read the comment docs.


Nerfed Kap'n Kooma

Broadside now requires Recharge, and adjusted to [4,5] multihit
Sea and Sky's speed bonus reduced from 2 to 1.25x

overnerfed imo


Capitalise service name in documentation menus

Description of changes:
Makes use of the metadata.yaml file in each service repository by changing any reference to the SDK service name to the properly capitalisedshort_name. For instance, sfn will now be Step Functions, sagemaker will be SageMaker, etc.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Scatter layers do not scale canvas instructions properly.

When mode="scatter" is used on layer which has canvas instructions (like Line)  it works ok for translating, but does not work for zooming
example code: line from Dover (England) to Calais (France).

This is because the scatter transform is reset when a new zoom layer of tiles are loaded. See the comments in #13


Update dependencies to latest stable versions

Codecov Report

Merging #2 (664adfa) into main (42cd085) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 664adfa differs from pull request most recent head 90de4fb. Consider uploading reports for the commit 90de4fb to get more accurate results

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   44.89%   44.89%
=======================================
  Files           1        1
  Lines          98       98
=======================================
  Hits           44       44
  Misses         54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cd085...90de4fb. Read the comment docs.


feat: enable search

closes #51

@vpicone the search wasn't working for me when I tried it 😕

Search is only working in FF right now @abbeyhrt I tried looking at it over the weekend but couldn't figure it out. 😢


Dataset.filesystem_idx_location used inconsistently

This method of the Dataset model uses the filesystem_idx_location to check if the Dataset has an associated index file: https://github.com/churchlab/millstone/blob/3c643a23c205ca244f0798d8434f2cb775f6d990/genome_designer/main/models.py#L249
But in the read alignment pipeline the reference is indexed using pipeline.read_alignment_util.ensure_bwa_index: https://github.com/churchlab/millstone/blob/3c643a23c205ca244f0798d8434f2cb775f6d990/genome_designer/pipeline/read_alignment_util.py#L23

Good catch Brian. Needs to be fixed everywhere, or remove this function from Dataset. I recommend the latter :)

I will take a look, but my memory is that there are other indices besides the bwa ban index, and this is the  issue.

It was a good idea, but unfortunately not used consistently. The only place that uses it is:
https://github.com/churchlab/millstone/blob/3c643a23c205ca244f0798d8434f2cb775f6d990/genome_designer/utils/jbrowse_util.py#L364
Since it's not a high priority, it's better to fix it by removing the global thing and having a custom function just for jbrowse. As opposed to make sure you fixed this everywhere.


Error: Failed to fetch plugin

I'm submitting a ...
[ ] question
[x] any problem or bug report
[ ] feature request
plugin version: (check one with "x")
[ ] 1.4.x
[x] 2.0.0-beta3
Current behavior:
Today, when I try to add a plugin, I get:
Error: Failed to fetch plugin https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module

In Ionic Package Cloud build application(where the plugin is installed) success, but in .ipa and .apk www/plugins/cordova-plugin-googlemaps not added and application does not work.

Please ask at the ionic forum. This is ionic crould build
problem.

Local on computer run:
cordova plugin add https://github.com/mapsplugin/cordova-plugin-googlemaps#multiple_maps --variable API_KEY_FOR_ANDROID="my_key" --variable API_KEY_FOR_IOS="my_key"
return this error.

please search the past issues...
https://github.com/mapsplugin/cordova-plugin-googlemaps/search?q=Error%3A+Failed+to+fetch+plugin&type=Issues&utf8=✓

https://forum.ionicframework.com/t/cordova-is-not-a-valid-task-googlemap-native/102693/4

I had the same problem ...
I already had a project on Android developed on Windows 10 and I was now working on Mac for iOS. When I wanted to add the platform (sudo ionic cordova platform add ios) I had this problem ... I tried many things but the problem was that I added "sudo" in the command line. Removing "sudo" gave me permission errors in the platforms / ios directory, so I gave it read / write permissions and ran the command again ...
This was what worked for me, I hope it serves the one who has this problem


Added BuddyString.java

add: BuddyStrings.java
This problem is a Leetcode problem and a very frequently asked DSA problem and I solve it in Java. This will help many students practice and solve DSA problems for cracking the companies.
Review my code and Please merge it.
Thank you

Please assign the tags of hacktoberfest, hacktoberfest-accepted, and hacktoberfest2023 to my PR. It will be helpful.

The repo already have the necessary tags and is already a part of hacktoberfest from last year so it will automatically get accepted.


provision: Set fs.inotify.max_user_watches for inotify.

Fixes #12565.
This PR is probably wrong, in that I think it won't do the right thing for
systems using container-based Vagrant providers like Docker; needs testing.

You forgot to add tools/setup/90-zulip.conf. But, as you suspected, this can’t work in Docker. max_user_watches is shared between the host and all containers and cannot be modified from inside.
root@e1e64cab90e9:~# sysctl fs.inotify.max_user_watches=16384
sysctl: setting key "fs.inotify.max_user_watches": Read-only file system

As it happens, my max_user_watches is already 65536; the default is based on available low memory.
Probably the right plan is to make the problem reproducible enough to verify the pyinotify patch.

I seem to be able to reproduce it the first time I startup run-dev.py after boot on my laptop, so sounds reasonable.

The root cause of this issue for me was that I had Dropbox running, and that was consuming 6000/8192 inotify watches (one per directory in my Dropbox).  After removing some forgotten code that had a lot of directories per unit value (two checkouts of ghost from 2015, apparently), the problem was resolved for me.
Further investigation revealed that the Zulip development environment does use about 5000 inotify watches, out of the 8192, so we're definitely at risk for similar issues more broadly here if we keep adding new files accessed by Django.  But potentially not enough to be worth editing a system-level sysctl during our setup process.

As it happens, my max_user_watches is already 65536;

It turns out this was because nautilus depends tracker-miner-fs which installs
$ cat /usr/lib/sysctl.d/30-tracker.conf
# Increase inotify availability
fs.inotify.max_user_watches = 65536

and my default is otherwise 8192.


Bring back "Search by image" button

https://github.com/bijij/ViewImage
This developer's browser extensions for Firefox and Chrome can bring back both buttons. But I really really want to keep using Safari on Mac. Can you update the Userscripts to restore both "View Image" and "Search by image" buttons?
Thank you very much!

Closing as duplicate of #16


Fix docstring format

Related to #3065

An unrelated test is failing in Travis.

Close and reopen to rerun CI.


Fix malformed typescript exports

When using your module as a ES module like this
import telegramifyMarkdown from 'telegramify-markdown'

the following compile error occurs:
node_modules/telegramify-markdown/types/index.d.ts(12,3):
error TS2666:
Exports and export assignments are not permitted in module augmentations.

The issue is explained here
and it basically says you can't use export = and export  together in one module
because it mixes up commonjs module and ES module syntax.
I found the simple fix is removing the export on UnsupportedTagsStrategy,
because the module will simply continue to work as is.
The autocompletion on the second parameter of convert also continues to work.
While at it you can add to your README somewhere that
import telegramifyMarkdown from 'telegramify-markdown'

is the ES module compatible import.

Thanks a lot for the PR!


Add RGB Riddle Game

🎮 RGB Riddle Game

RGB Riddle is a thrilling game that puts your estimation ability and familiarity with the RGB color scheme to
the test.
Could this issue be assigned to me under GSSoC'23?

Point down the features

In this game, you will be presented with various color swatches, each represented by their RGB values.

Your task is to estimate and select the closest matching color from a set of options provided.

The game has 2 levels, easy and hard.

On picking hard, you will have to choose the closest match out of 6 options to the given RGB coordinates.
On picking easy, you will have to choose the closest match out of 3 options to the given RGB coordinates.

It features stunning visuals and a user-friendly interface, allowing you to immerse yourself in a world of captivating colors.

Screenshot

Already submitted to another repo dont do this again else you will disqualify form gssoc'23


Question/Request: Resizing parent view to subview sizes

I've tried out constraints and it's terrible to work with. I would love the ability to make a parent view resize itself (heigh and/or width) to make itself as big as the subviews it contains.
For example:
  add UILabel, :title_label
  add UIView, :divider_view
  add UIView, :info_container do
    add UIImageView, :used_image
    add UILabel, :used_label
    add UIImageView, :color_image
    add UILabel, :color_label
    add UIImageView, :ruler_image
    add UILabel, :ruler_label
  end

  add ProfileView, :profile_view

:info_container should resize its own height to be as big as all its subviews, so I can position the :profile_view below it like this - below(:info_container).
Does this make sense? Am I going about it in the wrong way?

Hey @holgersindbaek,
Constraints are sometimes a big pain, for sure.
I'd do something like this:
  add UILabel, :title_label
  add UIView, :divider_view
  add UIView, :info_container do
    add UIImageView, :used_image
    add UILabel, :used_label
    add UIImageView, :color_image
    add UILabel, :color_label
    add UIImageView, :ruler_image
    add UILabel, :ruler_label
  end

  add ProfileView, :profile_view

# ...

def info_container_style
  constraints do
    min_bottom.equals(:used_image)
    min_bottom.equals(:used_label)
    min_bottom.equals(:color_image)
    min_bottom.equals(:color_label)
    min_bottom.equals(:ruler_image)
    min_bottom.equals(:ruler_label)
  end
end

I need to go through and exhaustively document all the possible constraint options. This is listed in the docs but we need more examples.

Thanks for the answer @jamonholmgren. I've already implemented the whole view with constraints, but it seems so immensely clumsy. It takes a long time to make things right and you have to write MANY lines of codes to make the constraints work.
I've re-written stuff things, so the views that have a superview, that needs to expands, calls - resize_superview_to_fit_height - which calls a method on the superview that goes through it's subviews and resizes accordingly. It seems to be working quite well, but it's not perfect.
Much simpler and much less code than constraints though. Any change of implementing something like this in MotionKit? Like an option on a superview called - automatic_resize - that will resize the view, each time a subview is added?

I have a love/hate relationship with these things. When it works, it's great, but when it doesn't, you end up in the seventh level of hell. :)
One thing that I have thought about from time to time is if we could use the auto layout text strings in the constraint block?
For example:
  def my_view_style
    constraints do
      horizontal "|-(my_other_view)-|"
      vertical "|-(my_top_view)-(my_other_view)-(my_bottom_view)-|
      # etc
    end
  end

Excuse the rough syntax, but I think you get my point. The my_other_view etc items in the auto layout strings would represent the symbols used to name the views added in the layout method. I sometimes think that having access to that syntax would make more complex layouts easier to work with.
Anyway, I know this stuff is really hard, so I appreciate the effort that goes into it all.
Thanks,
M@

Interestingly, @holgersindbaek, our latest app uses constraints exclusively and the code is really simple. Here's an example of our most complex screen, which is a detail screen (think like Instagram's individual video detail screen): https://gist.github.com/jamonholmgren/dea5986742037bc3a64e
Maybe we just had a simpler use case, but overall it was pretty pleasant. I do agree that it can be really convoluted sometimes. For example, we needed to implement a list of tags that were left-floated and wrapped down a line when there were too many. We ended up just making a web view for that. Don't tell anyone. ;)

Still seems very "complicated"... or at least clumsy. This is my layout file currently - https://gist.github.com/holgersindbaek/91ab2395699ac49d1ab4. The thing that strikes me with constraints, is that you have to basically write 3-4 lines of code for each view, plus the constraints do and end line. Which makes for a LOT of lines and difficulty getting a quick overview of things.

@holgersindbaek Hm, I guess my expectations are a bit different then. :) Certainly frame-based layouts will be fewer lines in most cases, but the tradeoff is worth it, at least to me.
To be entirely honest, if you're not using constraints (plug your ears @colinta) I wouldn't use MotionKit at all. Your stylesheets should port over nicely to @twerth's RMQ stylesheets.

^ :-)

Having the parent view size according to it's child views can be done two ways:

Use constraints
Use layoutSubviews and calculate the size of the current view based on the child views.

I don't think you can accomplish this goal using only frames and resizing masks.


SPFx Extension is not working with BotFramework-WebChat

I am trying to create an extension using SFPx. while i am adding BotFrameWork-WebChat using NPM and package the solution. The packge starts throwing error.
Error:
Uncaught (in promise) Error
    at t [as constructor] (sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:899)
    at new t (sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:1522)
    at Function.e.buildErrorWithVerboseLog (sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:1522)
    at Function.e.buildLoadComponentError (sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:1522)
    at sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:1522

Uncaught (in promise) Error: Failed to create application customizer 'ClientSideExtension.ApplicationCustomizer.5f6a1f7f-7283-4785-800d-06530c14faf9'. Error information is '***Extension failed to load for componentId "5f6a1f7f-7283-4785-800d-06530c14faf9".'.
    at sp-pages-assembly_en-us_f28f24b9fa7e84eb3b531aead69a4f32.js:2354
    at async Promise.all (index 1)

It's working fine with Gulp-Serve
Package.JSON
"dependencies": {
    "@microsoft/decorators": "^1.8.1",
    "@microsoft/sp-application-base": "^1.8.1",
    "@microsoft/sp-core-library": "^1.8.1",
    "@microsoft/sp-dialog": "1.8.0",
    "@microsoft/sp-http": "^1.8.1",
    "@microsoft/sp-loader": "^1.8.1",
    "@microsoft/sp-page-context": "^1.8.1",
    "@pnp/spfx-controls-react": "1.7.0",
    "@types/es6-promise": "0.0.33",
    "@types/jquery": "^3.3.8",
    "@types/memoize-one": "^4.1.1",
    "@types/react": "^16.8.14",
    "@types/react-dom": "16.0.5",
    "@types/webpack-env": "1.13.1",
    "axios": "^0.18.0",
    "botframework-config": "^4.3.4",
    "botframework-directlinejs": "^0.11.4",
    "botframework-webchat": "^4.3.1-master.f68cf3c",
    "date-diff": "^0.2.1",
    "es6-promise": "^4.2.6",
    "jquery": "^3.4.0",
    "memoize-one": "^5.0.4",
    "moment": "^2.24.0",
    "office-ui-fabric-react": "^6.169.0",
    "react": "^16.8.5",
    "react-dom": "16.3.2",
    "react-dropdown": "^1.6.4",
    "react-moment": "^0.9.2",
    "react-timeout": "^1.2.0",
    "sp-client-custom-fields": "^1.3.7",
    "web-speech-cognitive-services": "^4.0.0"
  },
  "devDependencies": {
<EMAIL_ADDRESS>"0.4.0",
<EMAIL_ADDRESS>"0.1.6",
    "@microsoft/sp-build-web": "1.8.0",
    "@microsoft/sp-module-interfaces": "1.8.0",
    "@microsoft/sp-tslint-rules": "1.8.0",
    "@microsoft/sp-webpart-workbench": "1.8.0",
    "@types/chai": "3.4.34",
    "@types/microsoft-ajax": "0.0.33",
    "@types/mocha": "2.2.38",
    "@types/sharepoint": "^2016.1.2",
    "ajv": "~5.2.2",
    "gulp": "~3.9.1"
  }

BotExtension.zip
I am attaching the Source Code of the same. Please help me out or let me know the alternate way to do this

Please let know the update on this issue. Or suggest some alternate way to do this.

Hi @rajivkumarsrivastava I'm looking into this.

@rajivkumarsrivastava Sorry, to clarify; the error you are getting is when you are attempting to package the solution? or after packaging and attempting to impliment?
Can you give the command you are using to package the solution?

After packaging and deployment of SP Package, when i try to access the Extension by installing the App on SharePoint site on SharePoint modern Pages than i got the error in console
Below are the Steps which is use to package

gulp clean
gulp bundle --ship
gulp package-solution --ship

The issue has been resolved with BotFramwork-WebChat version 4.4.1

@anomepani  I didn't check it on IE 11 but on Edge, Chrome and Firefox it's working  fine.

@rajivkumarsrivastava  Can you please check and verify that it is working in IE 11 or not? So that I can not create a separate issue in Repo.

Sorry about the late response. No it's not working on IE 11.  It's working on Edge, Chrome, Fire Fox


[1.1] Suggestion: implement data export in arangosh

I think it would be cool if arangosh could get a command like export() to export data.
cursor = db.users.all();
export ( "myExportFile.json", cursor);

or with statements:
cursor = db._createStatement({ "query" : "for u in users return u" }).execute();
export ( "myExportFile.json", cursor, overwriteswitch, formatswitch);

In this last example I have also passed some other parameters.

overwriteswitch: If export file exists, override or not
formatswitch: this would default to json, but should  include options csv, & tsv.

in combination with #329, this would allow batching of exporting data commands
Sidenote:
if arangosh also would include arangoimp's functionality then all would be in one tool.

JavaScript exception: ReferenceError: SYS_SAVE is not defined
Is there a new way now? @frankmayer syntax looked good to me.

The global functions (including SYS_SAVE) have been moved out of the global scope a few years ago. The write-data-to-file function is now available in the fs module:
var fs = require("fs");
fs.write(filename, contents);

Worked like a charm, thanks!