BuildMyPinnedSite is Unavailable

Hi Team,
When I click the link for the BuildMyPinnedSite (http://www.buildmypinnedsite.com/) I am getting the following error:
Error 403 - This web app is stopped.
The web app you have attempted to reach is currently stopped and does not accept any requests. Please try to reload the page or visit it again soon.
If you are the web app administrator, please find the common 403 error scenarios and resolution here. For further troubleshooting tools and recommendations, please visit Azure Portal.
Can someone fix/update please
Thanks
Nathan

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50ad17a1-3dc3-9d2e-90ae-e6e3d054d4e5
Version Independent ID: 89807489-f29f-7316-6a47-ee64330a4815
Content: Add image for secondary Microsoft Edge tiles (Windows 10)
Content Source: windows/configuration/start-secondary-tiles.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@officedocsbot assign @jvsam

A quick method for getting appropriately sized images for each tile size is to upload your image at BuildMyPinnedSite and then download the resized tile images.

Hi @nathanmaslin thank you for bringing this to our attention. It appears that the service has already been discontinued and the site is no longer live. I will get this over to the Windows content writing team for investigation and if confirmed, to suggest the removal of the link to avoid confusion.
We really appreciate your feedback and thank you for being part of the Microsoft Docs Community and for helping improve the quality of the technical documentation!

I can only confirm that the page/site is not available and that I get the same error code (403). I don't know if it has been discontinued permanently and intentionally, so it would be good to get that part confirmed by MS internal techs.

@illfated this zdnet article gives some interesting context to what happened.

Wow. I was unaware of that fact and how much things can go south if online services get out of hand. Thank you for that information, appreciated.

Hi again @nathanmaslin, thank you for your patience.  The removal of the dead link from this documentation, based on your feedback, has been approved and merged (see #4701). The update will be displayed here at docs.microsoft.com in the next scheduled publishing run. We will now close this issue, however, feel free to re-open if you have other suggestions or ideas to improve the quality of this documentation.
Thank you for your feedback and for being part of the Microsoft Docs community!


Added "WaitFrames" to PromiseTimer in order to wait a specified amount of update calls

Added "WaitFrames" to PromiseTimer in order to wait a specified amount of update calls. Also added unit tests for new addition
(Also added .vs and *.ide to git ignore for visual studio 2017)

The reason I implemented this is because of some odd quirks in Unity when they use Coroutines internally, and will run over 1 frame, or you need to wait a frame to use something again (For example - EventSystem.SetSelectedGameObject). I have just ran into sometimes not wanting to wait for "time" but for a set number of frames. Thanks

Hey, thanks for submitting this! I had a chat with the other developers for C-Sharp-Promise and although your code looks good (apart from random values in tests which could cause flaky tests), we're reluctant to merge this because it encourages writing frame-rate dependant code. Your use case is sound but features like this could encourage other developers to create code that depends on the framerate being constant, which could lead to bugs when the frame rate is not what is expected.
I think that waiting till the next frame, end of frame or fixed update would also solve your problem without the risk of introducing timing issues. However, adding support for the latter two of those would require adding a dependency on Unity which we don't want because not all users of the library are using it in Unity.
That said, we actually already use things like that, as well as methods for wrapping a Unity Coroutine in a promise in our internal code, so perhaps that kind of thing has a place in a separate repo of Unity promise tools.

@RoryDungan Hey, I was thinking about this pull request again, and maybe instead of adding a straight up WaitFrames() method, we included the frame count in the TimeData class so people could use WaitUntil() or something themselves, that way it isn't really encouraging frame-rate dependent code. I'll do the pull request ofcourse, if that sounds fine to you.

I'm actually quite OK with that suggestion. I think it's a neat way of doing it and adds flexibility without compromising the core integrity of the design. A simple change with a simple test. I vote yea.

Yeah I think that sounds like a good idea!


Updating live

Docs Build status updates of commit 157cb60:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/libraries/machine-learning/basic-classification.md
:white_check_mark:Succeeded
View

articles/relnotes/index.md
:white_check_mark:Succeeded
View

articles/tutorials/qft-tutorial.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Default DSP Settings

Librosa has defaults of a 22050 sample rate, and a hop length of 512.
Brian comment that we may eventually use other feature generation / analysis tools that having other defaults, and should consider that.
I feel like we can worry about that when we get there, myself?

There are a few concerns here:

librosa has defaults, and they might not be what we want for any given task.  (For example, it's possible to get more accurate onset detection just by ramping up the sampling rate and decreasing the hop size.)

for any given analysis within librosa, the optimal settings may change.  Overriding the defaults is generally easy, but you do have to be consistent in how you call functions.  So the question is: where do we want to store the dsp parameters for each feature extractor?

We just went through this discussion over here, which lead to the development of the presets package.  This makes it easy to override the defaults in one place without having to remember to dot all the i's for every function call.

a)  Presets is gorgeous, but terrifies me.  Are you sure you're not a Ruby programmer? ; p
b) For the purposes of Amen, we're extracting each feature in its own function.  Would it be too simple to simply change the librosa defaults in a feature extraction function that needs changing?

a) Presets is gorgeous, but terrifies me. Are you sure you're not a Ruby programmer? ; p

:rage4:
Seriously though, It doesn't actually do anything to the module, it just provides quasi-transparent wrappers that clobber defaults with custom settings.

b) For the purposes of Amen, we're extracting each feature in its own function. Would it be too simple to simply change the librosa defaults in a feature extraction function that needs changing?

Not at all.  I'm simply thinking ahead to potential headaches that might arise if we decide to change settings down the line and maybe forget to update a function call.  (This has been known to happen.)

FWIW: in one of my other projects, I'm moving to sr=32768 and hop_length=512 because powers of two give me warm fuzzies inside (and simpllify a lot of downsampling/pooling logic)`

wow, never heard of that sample rate before, and my initial knee-jerk reaction has given way to reading wikipedia about the many different rates ppl actually use. 352800Hz, 5644800Hz, it's a wide world out there


⚠ Bofrost.lu has degraded performance

In e6850eb, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1523 ms

Resolved: Bofrost.lu performance has improved in 3f7c5bc.


Migrating from Keras to a PyTorch Pipeline

Breaking PR

Model changed to the actual implementation of nnU-Net
Classification+Seg nnU-Net implementation
segmentation_models.pytorch 2D models support
Now using torch/catalyst for pipeline
YAML Pipeline

Addresses #7

Support for 2D and 3D!

2D handled as described in #25 and implemented in #28 .

binary tumor segmentation support
per-class foreground sampling
More visualization support; #17

Alrightttt. Looks good enough. Rest can be added in down the line.


Gallery contains false information

The gallery shows the typst instruction of the multi-qubit unitary gate as mqgate($U$, 3). It should be mqgate($U$, n : 3). The code below does not compile.
#import "@preview/quill:0.2.1": *

#quantum-circuit(
    lstick($|0〉$), mqgate($U$, 4), [\ ],
    lstick($|0〉$), 1, [\ ],
    lstick($|0〉$), 1, [\ ],
    lstick($|0〉$), 1, [\ ],
)

Oh, that's right, thanks for reporting!


[bug]: style doesn't work when alias paths updated

Describe the bug
I'm trying to add my folder structure to shadcn, but I'm having trouble with alias paths. I've only checked with the Button component.
Affected component/components
Button
How to reproduce

Init Shadcn in the new Next.js project
Update path alias in the components.json
Add the Button component
Check styles it is working or not

Codesandbox/StackBlitz link
https://stackblitz.com/edit/stackblitz-starters-mfgc9p?file=app%2Fpage.tsx
Logs
No response
System Info
-

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

The problem was about content array in tailwind.config.js. it should be like:
  ***
  content: [
    './pages/**/*.{js,ts,jsx,tsx,mdx}',
    './components/**/*.{js,ts,jsx,tsx,mdx}',
    './app/**/*.{js,ts,jsx,tsx,mdx}',
    './core/**/*.{js,ts,jsx,tsx,mdx}',
  ],
 ***


Streamline how a client wraps an exception with UnprocessedRequestException.

Armeria clients currently manually wraps an exception with UnprocessedRequestException in a limited number of situations. It has inherent limit where it cannot wrap an exception thrown in a decorator even if the request has been terminated without sending anything.
How could we automate this process? Perhaps we could:

Add a boolean flag that is set by Armeria's transport layer when an HTTP header is written.
Wrap any exceptions if the flag is false.

Then, when should we wrap the exceptions? If a decorator throws an exception, should its outer decorator see the exception as it is or in its wrapped form?

With the boolean flag, we might don't actually wrap an exception at all because a user knows whether the request was sent or not from the flag. We could make this change in 2.0.


Find another dataset for guiding use case example

We need to find another dataset for the simple use case that we use as a guiding example in the paper. With 12 element the artists dataset is way too small.
Any suggestions?

We could use OECD data with some time aspect or alternatively this vaccine dataset with US states:
http://www.randalolson.com/2016/03/04/revisiting-the-vaccine-visualizations/

Alex and I decided to use the AIDS dataset from http://aidsinfo.unaids.org/, which we will also take as a guiding example to introduce the concept.
With the different time steps for many of the attributes we also have lots of matrices. For the countries it's also easy to find additional meta-data such as population, size, GDP, etc.
The AIDS dataset itself also contains categorical attributes, such as 'law'.
In the other direction for the timesteps we can add additional categorical meta-data such as self-defined ones like "1980 - 2000 - no medication available" or others that we find in public sources (e.g., http://www.nature.com/nrd/journal/v6/n12/fig_tab/nrd2448_F1.html)
@mijar, can you please try to prepare this dataset as excel/CSV file until tomorrow noon? I know that this is very soon already, but we need this asap for explaining the concept. Once you have it in CSV format, @alexsb will create the JSON file that we can then use to load the data into Taggle.

@mstreit I will collect the data just for the whole population (all age categories), ok?
@alexsb what is the best way for you to store the matrices, with the rest of the attributes in one table or separately and named after the values they store?

yes, all age is fine.

oh, and please put everything in our taggle gdrive folder.

Just as reference - generator script for Phovea Tables:
https://github.com/Caleydo/phovea_json_generator/blob/master/CreatePhoveaJson.ipynb

Tables only though - adding matrix capabilities shouldn't be hard, but matrices are also easy to do by hand.

...I have found a few things, will create issues for them


Small change to vnet documentation

There should be a 2. in front of "Secure the Workspace"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 750a9fd2-b807-0eff-2495-0cbcf3564b03
Version Independent ID: d3be69a7-18d9-9b22-8424-92f0f43ccaa0
Content: Secure training environments with virtual networks - Azure Machine Learning
Content Source: articles/machine-learning/how-to-secure-training-vnet.md
Service: machine-learning
Sub-service: core
GitHub Login: @PeterCLu
Microsoft Alias: peterlu

@oolukoya
I have assigned the issue to the content author for further review and update the doc as appropriate.

Thank @oolukoya for the catch. I'll make a doc update to fix the issue. Once the changes are merged, in you should see the changes live in a few hours.

#please-close


calling Model in a loop would leak memory

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
tf2.13.0
Custom code
Yes
OS platform and distribution
Windows Server 2019
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
there is a transformer model when i try to decode messages, translate input sentence to target sentence i get memory blow up, memory is good when i use transformer.fit(), but in a loop like below it blows up memory, tf.keras.backend.clear_session() does’t help, also accuracy decrease when i use that, gc.collect() doesn’t work also
here is my code
def decode_sequence(input_sentence):
    tokenized_input_sentence = input_vectorization([input_sentence])
    decoded_sentence = START_TOKEN
    for i in tf.range(max_decoded_sentence_length):
        tokenized_target_sentence = output_vectorization([decoded_sentence])#[:, :-1]

        predictions = transformer([tokenized_input_sentence, tokenized_target_sentence])

        sampled_token_index = np.argmax(predictions[0, i, :])
        sampled_token = output_index_lookup[sampled_token_index]
        decoded_sentence += sampled_token

        if sampled_token == END_TOKEN:
            break

    gc.collect()
    return decoded_sentence

from tqdm import tqdm
def overall_accuracy(pairs):
    corrects = 0
    inputs = pairs[2739:]
    iter = tqdm(inputs)
    for i, pair in enumerate(iter):
        input_text = pair[0]
        target = pair[1]
        predicted = decode_sequence(input_text)
        #guess = '✓' if predicted == target else '✗'
        #print('Sample Number : ', i, 'Predicted : ', predicted, 'Real : ', target, guess)
        if predicted == target:
            corrects += 1
        iter.set_postfix(corrects=corrects, accuracy=corrects / (i + 1))

    return corrects / len(inputs)

print("Overall Acurracy : ", overall_accuracy(test_pairs))```

### Standalone code to reproduce the issue

```shell
calling model in a loop

Relevant log output
No response

@alerem18 Could you please provide the complete standalone code to replicate the issue reported?
Thank you!

https://keras.io/examples/nlp/neural_machine_translation_with_transformer/
in decoder_sequence

will there be any solution or i should wait for you to reply once a month?
this is why people prefer pytorch over tensorflow

@alerem18 I tried to replicate the issue on colab. https://keras.io/examples/nlp/neural_machine_translation_with_transformer/ is working fine in colab . Could you please try to use the GPU for this issue and let me know if the memory leak would be there? Thank you!

@alerem18 I tried to replicate the issue on colab. https://keras.io/examples/nlp/neural_machine_translation_with_transformer/ is working fine in colab . Please let me know if i have missed something to replicate the reported error. Have you tried to use the GPU for this issue and let me know if the memory leak would be there? Thank you!

i've not tested it on gpu, but i have memory issues when translating a lot of texts, in a loop

@sachinprasadhs same issue on this
https://www.tensorflow.org/text/tutorials/transformer

is there any damn solution for this or not?


[IOTDB-1566] Do not restrict concurrent write partitions

Cherry-picked from 349656c8159337007d9ead09393331b4e14105c5.
See #3749 for detail.

Coverage decreased (-0.02%) to 67.263% when pulling 441c31145d5423bfde6d1da69e3aeb9cf139cb7c on iotdb-1566 into 87506eb79808b15897a223428f287a5b9dc49915 on master.


Copy source tags

API change check for com.azure:azure-storage-blob
API changes have been detected in com.azure:azure-storage-blob. You can review API changes here


Request: add a limit parameter in configuration

Hi,
I sometimes get invalid readings due to bad focusing of my camera or no new reading following a problem with my camera server.
As a result, it can happen that the next good reading is above the 3 kWh limit of the addon to accept the value.
Would it be possible to let the user define the limit?
Thanks

Totally, yes. It is interesting that when I first introduced that limit is what makes a good parameter and I came to no-good bullet-proof answer so a new parameter makes total sense.

Thanks!

Hey, may I ask you if there is any progress on this? Thanks!

Nope, not yet.


enable configuration option ip_tenant_inheritance_order with inventory import

This PR aims to add the configuration option ip_tenant_inheritance_order with inventory import (check-redfish) as already available with vmware import.

Hi,
thank you for the PR and this idea. Unfortunately I won't be able to just merge it as it will affect recent changes I made to the parsing of config files.
I would highly appreciate it if you could implement it again the feature/improved-config-parsing branch. This branch will be merge soon to next-release and this will become the default.
If you don't care who is doing the integration then I could also add it to the code.
Just let me know what you would prefer.
Thank you

Hi @bb-Ricardo ,
Ok no problem I will take care of it, I will implement the changes against the other branch.
Thanks

awesome, thank you so much.

Hey @zvfvrv,
I just merged the configuration rewrite to development You could just use this branch.
Thank you

I am closing this PR since it is replaced by #281


Binding access when can lead to infinite recursion

When rebinding method onto the same name, livescipt will generate code that leads to infinite recursion. I think it should generate compile error and deserves mention in documentation that binding operator isn't replacement for javascript .bind().
Foo =
   v: 12
   init: !-> @bar = @~bar
   bar: -> @v

foo = Object.create Foo
    ..init!
foo-bar = foo.bar
foo-bar!

var Foo, x$, foo, fooBar;
Foo = {
  v: 12,
  init: function(){
    this.bar = bind$(this, 'bar');
  },
  bar: function(){
    return this.v;
  }
};
x$ = foo = Object.create(Foo);
x$.init();
fooBar = foo.bar;
fooBar();
function bind$(obj, key, target){
  return function(){ return (target || obj)[key].apply(obj, arguments) };
}

Maybe this could be a compiler warning if it's a common enough mistake. It seems to me that the fundamental misunderstanding here is that binding access produces a ‘dynamically’ bound function, which uses the value of obj.bar at invocation time instead of at binding time. If you misunderstand that, you're exposing yourself to more pitfalls using binding access than just this one; conversely, I don't know how many people would make this kind of mistake if they do understand it.

Yes, I have noticed that too, but I don't remember the context.
Moreover, this is not consistent with the behavior of partial application, where the binding is early, not late.
My proposal:
function bind$(obj, key, target){
  var func = (target || obj)[key];
  return function(){ return func.apply(obj, arguments) };
}

Hmm. Well, this behavior has been inherited from Coco (see commit 29face5f9) which means it's been around for as long as LiveScript has been LiveScript. Based on the change made in that commit, I'm inclined to think this is a bug as well—at least, it appears not to have been satyr's intent to make the bind dynamic, since the comment on that commit only describes the change as a simplification. It might, however, be a bug that we're stuck with, since it would be a breaking change to revert.
I could be swayed on this one by enough popular support.

I don't think many people have noticed it, most of the time the effect is the same. Even for myself, I believe I stumbled upon this just by looking at the compiled code, not running it. Although the use case from OP seams plausible.
Regarding breaking changes, it's not like it hasn't done before. From top of my head, there was unary spread (had to change my code for that), bound parentheses functions (almost had to change my code for that), object rest for destructuring, and many more. They're different from case to case, I admit, but in my opinion changing to early binding would be at least harmless.
But for me, the priority for this decision is low.

I've added a clarifying note describing the current state of affairs to the gh-pages-next staging branch. It'll go live with the 1.6 release. Does this seem satisfactory for now? I'm happy to revisit this behavior in the future if there is more activity.

👍 for temporary fix
👍 for revisiting in the future


Slow performance on long files

Linting a file with ~30k lines takes about 6s with eslint, but ~280s with the eslint-plugin-json-es parser. It doesn't appear to spend longer in any specific rule, so maybe some overhead which is causing the slow down?
eslint-plugin-json-es parser:
> TIMING=1 time npx eslint tests/cases/en-big-oldparser/en-big-oldparser.json
Rule                 | Time (ms) | Relative
:--------------------|----------:|--------:
indent               |   639.483 |    54.7%
max-len              |    45.934 |     3.9%
key-spacing          |    42.217 |     3.6%
comma-style          |    39.928 |     3.4%
no-extra-parens      |    34.074 |     2.9%
no-trailing-spaces   |    30.201 |     2.6%
...
Command exited with non-zero status 1
279.81user 1.59system 4:35.25elapsed 102%CPU (0avgtext+0avgdata 300768maxresident)k
0inputs+0outputs (0major+82500minor)pagefaults 0swaps

Regular parser:
Rule               | Time (ms) | Relative
:------------------|----------:|--------:
indent             |   657.560 |    42.5%
quote-props        |   258.444 |    16.7%
quotes             |    98.567 |     6.4%
key-spacing        |    49.780 |     3.2%
max-len            |    45.074 |     2.9%
comma-style        |    44.753 |     2.9%
...
Command exited with non-zero status 1
6.41user 0.33system 0:05.18elapsed 130%CPU (0avgtext+0avgdata 392144maxresident)k
0inputs+0outputs (0major+108247minor)pagefaults 0swaps

That's bad. I will run some performance tests...

That's bad. I will run some performance tests...

Performance problem confirmed
After testing and investigating the issue I found out that the acorn.getLineInfo method call is the problem.
The acorn.getLineInfo is used to fix code location information after parsing and running the rules.
It seams that the performance decrease for larger files is not linear. 🤔
Next step
Replace acorn.getLineInfo method with own implementation.

Performance problem confirmed
After testing and investigating the issue I found out that the acorn.getLineInfo method call is the problem.
The acorn.getLineInfo is used to fix code location information after parsing and running the rules.
It seams that the performance decrease for larger files is not linear. 🤔
Next step
Replace acorn.getLineInfo method with own implementation.

It looks like getLineInfo takes linear time for each token, and the number of tokens is linear to the size of the document, meaning fixTokens is quadratic time.
I think this can be fixed by inline-ing getLineInfo and making it stateful, such that for each subsequent call, it just continues from where it left off for the last computation.

It looks like getLineInfo takes linear time for each token, and the number of tokens is linear to the size of the document, meaning fixTokens is quadratic time.
I think this can be fixed by inline-ing getLineInfo and making it stateful, such that for each subsequent call, it just continues from where it left off for the last computation.

This approach works for fixTokens where the nodes are non-overlapping, but not fixLocation, so only half the problem is fixed.

This approach works for fixTokens where the nodes are non-overlapping, but not fixLocation, so only half the problem is fixed.

So as I understand it, the locations need to be recomputed to account for the ({code}); wrapper, but we know pretty reliably what the effect of this wrapper is:

Anything on the first line has the column shifted by one. We already know what is on the first line as the line result for each token is unaffected by the wrapper, so is still correct.
Anything not on the first line is unaffected.

So as I understand it, the locations need to be recomputed to account for the ({code}); wrapper, but we know pretty reliably what the effect of this wrapper is:

Anything on the first line has the column shifted by one. We already know what is on the first line as the line result for each token is unaffected by the wrapper, so is still correct.
Anything not on the first line is unaffected.

@cschuller I think the fix in #14 is much simpler...

@cschuller I think the fix in #14 is much simpler...

@edg2s
Yes we know the effect of the wrapper. The first intention was to re-use existing acorn code - my bad :-(
I will refactor the code to undo the wrapper loc.
In the meantime I implemented a line info provider that caches the position for a given input (code).
Since the input (code) does not change its pretty fast.
Let me check #14

@edg2s
Yes we know the effect of the wrapper. The first intention was to re-use existing acorn code - my bad :-(
I will refactor the code to undo the wrapper loc.
In the meantime I implemented a line info provider that caches the position for a given input (code).
Since the input (code) does not change its pretty fast.
Let me check #14

@edg2s Tested and merged your PR - Thanks a lot.

@edg2s Tested and merged your PR - Thanks a lot.


Skip subscribers on import if unsubscribed before

Hi,
We have few offline data collection sales points, we get that data on weekly basis in CSV files and upload them into the sendportal to send campaigns.
The issue we are facing is that sometimes there are customers who have unsubscribed from getting emails but if the same email is listed in our CSV files, these are updated automatically and they again start to receive these campaigns.
We had this issue referred to us by those customers.
Is there any way to skip import of emails which are already in the system and are unsubscribed?
Thanks.

Hi,
the ImportSubscriberService class seems to check for existence only from id and email columns, but it doesn't seem to touch the unsubscribed field... Do you see that unsubscribed_at becomes again null?


Strong name everything.

https://github.com/aspnet/dnx/issues/2615
cc @davidfowl @Eilon @muratg @moozzyk @Tratcher

Hi @cesarbs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Guided Joins

Right now joins only allow in order iteration with entities, which works for most use cases. In some use cases, however, you need a sorted way of doing things to make sure the order of operation is correct. (For example, amethysts transform system/scene graph).
So I propose a GuidedIter:
pub struct GuidedIter<I, J> {
    guide: I,
    bitset: J::Mask,
    values: J::Value,
};

impl<I, J> Iterator for GuidedIter<I, J>
    where I: Iterator<Item = usize>,
          J: Join,
{
    type Item = J::Type;
    fn next(&mut self) -> Option<J::Type> {
        while let Some(index) = self.guide.next() {
            if self.bitset.contains(index) {
                return Some(index);
            }
        }
        None
    }
}

Usage:
let list: Vec<usize> = vec![5, 1, 8, 2, 9, 12];
for (comp1, comp2) in (&comp1s, &comp2s).guided_join(list) {
    ...
}

@Aceeri How would you know the order of components in advance?

The order of the components should be the same as the join that is used for the guided if that is what you are asking.

Relevant

As noted by @Object905, if somebody wants this feature they can use specs_guided_join.


How does the knife work?

I am on 1.21 and cannot figure out how the knife works or if it is bugged.
I tried breaking tall grass with a knife, both right and left click. Nothing drops on left click and nothing happens on right click.
I sheared some grass and tried crafting it with the knife in a variety of positions.
Both the CF page and Wiki bot just say the knife is used to get plant fibers. But how is it suppose to work?

instrumentus-1.21.x-2.7.3-neoforge


[tdpl] Multiple alias this

This PR introduces multiple alias this.
The old alias this implemenation doesn't imply alias this conflicts.
All alias this-es in old implementation are serializable: compiler successively applies a, a->aliasthis, a->aliasthis->aliasthis while right expression is not found.
This implementation allows tree of alias this subtypes.
Type can has a direct "alias this"-es and "alias this"-es, inherited from base classes/interfaces. Thus, there can be conflict between several matching "alias this"-es.
In common case compile should raise error if several "alias this"-es have found.
However, in the next situation conflict can be resolved:
struct Test9a
{
    int a;
    alias a this;
}

struct Test9b
{
    int a;
    alias a this;
}

struct Test9
{
    Test9a a;
    Test9b b;
    int c;
    alias a this;
    alias b this;
    alias c this;
}

void test()
{
    Test9 t9;
    int a = t9;
}

When we try to cast Test9 to int we can find several variants: t9.a.a, t9.b.a, t9.c.
However, t9.c is preferred, because Test9 author is explicitly pointed out that Test9 should be converted to int through c field. This magic works only if we have exact match. short a = t9; causes error.
This PR have a one limitation: it doesn't support multiple tuple alias this. It don't clearly understand how them should works.   Multiple tuple alias this can be implemented in future in a separate PR.

What's the state of this? Wasn't the discussion finished and DIP66 accepted?

There seems to be merge conflicts and a failing test.
Ali

Can somebody update this PR to fix the merge conflicts and failing tests? It would be a big pity for this to go to waste.

Hey, I still work on this.
@yebblies Can you help me with this error message (with your d port)?
core.exception.AssertError@magicport/ast.d(779): ast.TemplateType

I'd guess the type matcher can't handle Array<bool> as a function parameter.  I'd suggest defining Bools in arraytypes.h and using that.

@yebblies Now it write Error: ./aliasthis.c(209): Unknown basic type Bools.
I defined Bools in arraytypes.h, added it to arraytype module in magicport.json, added arraytypes import to aliasthis module in magicport.json. What I need to do now?

Add 'Bools' to the 'structTypes' list in the json file.

@yebblies Ok. Now it writes:
core.exception.AssertError@magicport/magicport2.d(279): function atFindMemberScope*Expression*void*Expression**
----------------
0x80bb317 <magicport2.D[immutable(char)[]] magicport2.buildLongMap(ast.Module)+143> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ba634 <_Dmain+3844> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ed09a <_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv+18> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ed010 <void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+24> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ed05f <void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll()+39> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ed010 <void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate())+24> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80ecfa8 <_d_run_main+440> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80c3e3c <main+20> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80b96b7 <_start+167> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x80b9628 <_start+24> at /home/braddr/sandbox/at-client/pull-1569631-FreeBSD_32/dmd/src/magicport/magicport2
0x3 <???+0> at ???

What do I need to add to the json file?

You are declaring the function atfindmember twice, with the exact same arguments.  Easy solution is to change the name of one.

unreferenced: function atFindOpUna
unreferenced: function atFindMember
unreferenced: function atToBoolean
unreferenced: function atFindDotIdCall
unreferenced: struct DoBothCtx
unreferenced: function atFindDotId
unreferenced: function getAliasThisTypes
duplicate: typedef Strings
unreferenced: function findAliasThisSubtypes
unreferenced: function atResolveForeach
unreferenced: function mergeAliasThis
unreferenced: function atFindOpUnaBin
unreferenced: function atFindOpUnaUna
unreferenced: struct FindMemberCtx
unreferenced: function atCastTo
unreferenced: function atFindOpExp2Bin
unreferenced: function resloveAliasThisForBinExp
unreferenced: function atBinExpRvl
unreferenced: function atFindSubtypes
unreferenced: function atCheckErrors
unreferenced: function atBinExpLvl
unreferenced: struct FindDotIdCtx
unreferenced: function iterateAliasThis
unreferenced: function atBinExpBoth
unreferenced: function aliasThisOf
unreferenced: function atFindMember2

Where should I declare those symbols? What should I do with "duplicate: typedef Strings"
The most of those symbols don't represented in header files and used only as .c internal.

Where you put it is good - the same place as in the C++ source.  Don't worry about the "duplicate: typedef Strings".  It's just a warning and allows avoiding a layer-violating import.

Is defining all of those similar functions really necessary?  It would be really nice if they could be collapsed a bit.

The function names are a bit unintuitive.

Wow, is passes.

Where you put it is good - the same place as in the C++ source. Don't worry about the "duplicate: typedef Strings". It's just a warning and allows avoiding a layer-violating import.

I understood, thank you. You magic works :)

Is defining all of those similar functions really necessary? It would be really nice if they could be collapsed a bit.

I already collapsed this part where it was possible. Those functions follows the similar pattern (get alias this variation of e, combine it with some object, check is it ok and If it is ok, save the result), however they represent different situations.
Your commented function, for example, takes a bin expression and its first part, and tries to resolve alias this for the first term and substitute it to the original BinExp. It similar works for assign expression (a = b; => a.aliasthis = b;), or index expression (a[b]; => a.aliasthis[b];), for example. However combining with UnaExp (including CallExp, CastExp et c.), need a bit another logic.
I have no idea, how reduce this part more.

The function names are a bit unintuitive.

Yes, I see this trouble too. Now I want to adapt this PR to DIP66 (there are some rules, which is not implemented here yet) and brush code. After that, I hope, It will be much pretty a bit.

I've finished preparing of the this PR. Now it is ready for review.

@andralex Hey, time to review?

ok, getting into it

I don't much about DMD source code, so I'll let this to the specialists, but the tests cases sound pretty solid, testing both how the feature is supposed to work and not work.
I'd really like to have that in.

I'm curious how the following is handled:
struct S { void foo(void*); foo(int);}
struct T { void foo(long); }
struct U {
    S s;
    T t;
    alias this s;
    alias this t;
}
U u;
u.foo(null); // calls s.foo(void*)
u.foo(6); // error, s.foo(int) or t.foo(long)?

Note that this is how imports work, and the anti-hijacking rules. alias this should work the same way.

I'm curious how the following is handled:

See the Test18:
s.foo(1.0) and s.foo("string") are work correctly, but s.foo(1); raises an error, because there are two variants: s.a.foo(int) and s.b.foo(double).
If you ask, how it works, there no special case in the algorithm (I'm particularly pleased that it worked as it should before I thought about this case). Algorithm collects all acceptable ways to resolve the expression and if there is more then one way, algorithm raises an error.

That is the most sensible thing to do. I don't have much DMD knowledge, but really would like to use this. I thought it was in already.

Please, continue discussion.

This is of terrifying complexity. There's an awful lot of code to implement what should be a rather modest feature. Single alias this is "look it up in alias this, if found, use it". Multiple alias this should be "look it up in each alias this, if it is found exactly once, use it. More than once, issue an error."

The DIP is good as it stands but 2KLOC spread over 18 files seem quite a hit for what seems to be a small feature.
I think this needs closer review - there are a bunch of comments on this but only a couple about the actual implementation. Without being on the compiler team, I can say that 2KLOC for this can't pass muster.
More reviewers please? Suggestions for simpler angles on the implementation?

@andralex @WalterBright
I had planned to do this tomorrow, but I want to say a few words today.

Single alias this is "look it up in alias this, if found, use it".

Yes, the old implementation use method "look it up in alias this, if found, use it, otherwise try to look up alias this of alias this".
We may follow this scheme for the multiple alias this: "look it up in each alias this, if it is found - store it, otherwise, recursively apply the next alias this. Eventually, if there is only one alias this stored, use it, if more then one alias this-es are stored, raise an error."
However, I want to encapsulate all walking algorithm over alias this tree, inside the one module:
if we will change the walking algorithm in future (for example, if we allow to hide subtypes' alias this-es by current type alias this.)
And even if we will create "naive" implementation with dfs, it will not reduce changes size.

The DIP is good as it stands but 2KLOC spread over 18 files seem quite a hit for what seems to be a small feature.

Unfortunately, we can't much reduce the changes size: simply grep ->aliasthis in current dmd repository, and horrified. The current alias this implementation spread "over 18 files" and we should modify each of them.
I'll fix my code, add comments over the next few days and I'll able to justify this implementation more substantively.

@WalterBright

There's a lot of code to implement what should be a rather modest feature. Single alias this is "look it up in alias this, if found, use it". Multiple alias this should be "look it up in each alias this, if it is found exactly once, use it. More than once, issue an error." The implementation here is editing ASTs, has hash tables, I don't see how that follows. What am I missing?

I've partially answer to this early.
Summary:

The implementation here is editing ASTs

I simplified  AST in this PR. Now each expression has only one flag (aliasthislock) instead of type of the alias this of the next type(s) as early.
Type now contains the aliasthislock bit-set field (as early), but number of cases has beed reduced.
The logic of this PR is simple:
interateAliasThis function interates all alias this subtypes of expression.
Only it knows about subtype tree walk logic (it can be easily changed in the future). Hash table need to avoid infinity recursion for circular subtyping case.
Another code use only functions from aliasthis.c. When user code uses interateAliasThis it should pass delegate to it, and unable to recursive alias this lookup in it. E.g.
bool atSubstUna(Scope *sc, Expression *e, void *ctx, Expression **outexpr)
{
    UnaExp *e1 = (UnaExp *)((UnaExp*)ctx)->copy();
    e1->aliasthislock = true; //Now when we do  e1->semantic(), we will not try to resolve alias this.
    e1->e1 = e; //replace op(e1) with op(e1.%aliasthis%)
    Expression *e2 = e1->trySemantic(sc);
    if (e2)
    {
        *outexpr = e2;
        return true;
    }
    return false;
}
...
                if (!aliasthislock) //we don't need the recursion. Recursion done in iterateAliasThis
                {
                    aliasthislock = true;
                    Expressions results;
                    iterateAliasThis(sc, e1, &atSubstUna, (void*)this, &results);

                    if (results.dim == 1)
                    {
                        return results[0];
                    }
                    else if (results.dim > 1)
                    {
                        error("Unable to unambiguously resolve %s Candidates:", toChars());
                        for (size_t j = 0; j < results.dim; ++j)
                        {
                            error("%s", results[j]->toChars());
                        }
                        return new ErrorExp();
                    }
                }
...

I don't allow recursion inside semantic code, because all recursion logic should be incapsulated inside interateAliasThis.
@andralex

The DIP is good as it stands but 2KLOC spread over 18 files seem quite a hit for what seems to be a small feature.

This feature is not small:)
It should handle casting, .member case, .method(args) case including cross-type overloading, with(symbol) case, ton cases for overloaded operators (include assignment, casting, foreach, general unary/binary operators), template argument resolving and other cases.
For example, grep -rnw . -e '>aliasthis' | wc -l for master returns me 68. And we should handle each those cases.  2K is not much for this task, imho.

@WalterBright  @andralex
If you do not go into the fine details, have you fundamental objections aganist this implementation?
I've explained, why I've done so. I have something wrong?

ping

Ping ? I need this. Please @andralex and @WalterBright either merge this or propose actionable items to make this move forward. Right now there is not much to do to have this move forward and that is a problem.

@andralex AFAIR, you planned to merge this until Jul, 8. Four days remaining:)

I agree with @WalterBright and @andralex - there definitely appears to be too much going on, some of which looks like needless noise - such as moving entire functions from expression.c to aliasthis.c with no notable benefit - some of which looks like overcomplicating what should be a modest addition.
When looking around at some of the areas that need changing, I was rather taken aback by the spaghetti code used by the existing alias this implementation.  It must be said that the current design is terrible:
Lagain:
    /* 165 lines of code later after checking all other options to resolve the symbol. */
    if (ad && ad->alilasthis)
    {
        e1 = resolveAliasThis(sc, e1);
        goto Lagain;
    }

My feeling is that we must first untangle this unwieldy flow of code, only then will it become a "modest addition".

@andralex Hello. I was out and will nd I will be absent for some time becauseI'm busy with graduate work at the university and is very busy at the job. I'll return to this work and other D works after a couple of months. Sorry. BTW, I have some ideas about this implementation.

@yebblies @andralex
Hello. Sorry for a long non-availability.
I plan to start revival of this to February.
As I see, D frontend has been moved from cpp to D since the my last activity.
Have you any suggestion, how I may easy move this PR to D using conversion utilite?
What limitation of a frontend code in D?
Can I use foreach, AA or simple dynamic arrays, phobos?

@IgorStepanov Welcome back!
There used to be a script for automatic conversion, but I can't find it anymore. There's also this page on the Wiki about porting PRs to the D version. I guess it's largely no longer relevant now (e.g. magicport.json is gone).
As for which D constructs are allowed: foreach is actually preferred over for, not sure about AAs and dynamic arrays. Phobos however isn't accepted.

Ok. AA may be usefull if it acceptable.
This (C++) version has a magicport staff. I guess, I need to run magicport manually, get .d files and after that, try to merge with current master.
@yebblies can you write command to do magicporting?

The procedure in #4922 should work to convert this, once it's rebased onto the last C++ commit using the procedure from the wiki page.
Phobos and the GC are currently being avoided, while some code has been refactored to use foreach. auto and scope delegates.
I would advise doing a direct conversion before any refactoring.

Thanks. Looks simpler that I expected. Will do it.

How is this going?

Any update on this?

In the State of D survey, this was among the top five missed language features

https://rawgit.com/wilzbach/state-of-d/master/report.html
As this is still based on the C++ frontend, it might take a serious effort to revive it.
Though there's some automation - see https://github.com/dlang/dmd/pull/4922#issuecomment-133776696

This implementation by and large was rejected, as we think that multiple alias this shouldn't be a big change to add support for.
Preliminary PRs may need to be made in order to make the existing alias this support grokable though.  Which is probably why this ended up to unwieldy.

Closing as #8378 superseded this PR.


Automatic 3rd party crate version crawling

Feature
All of the crates currently available have a Bevy support table, it would be great to have a github action that scans these every day or so and creates a pull request or issue to update it for the correct Bevy version.
Implementation
The following steps show how this could be done

Fetch the crate's data with https://crates.io/api/v1/crates/<name>(example)
Get the readme url from the version at index 0

Fetch the readme with the url from the previous fetch (example)
Parse the html for a table where a header  has the value bevy or similar (eg. bevy_kira_audio uses Bevy version)
Figure out which column is for Bevy, most are the first column but some like bevy_hanabi have it swapped
Parse the table and use the latest version when multiple are listed
If the version is a semver range (eg. 0.14 and not 0.14.1) then check the crates.io response from the first request and match the latest one to the semver pattern

Example of bevy_dev

      bevy
      bevy_dev

      0.13.2
      0.3 - 0.3.1

      0.13.0
      0.2

      0.12.1
      0.1 - 0.1.1

One thing to keep in mind is some crates may have multiple support tables like Avian does.

Can take notes from Bevy's CI workflow that uses a custom Rust binary.
https://github.com/bevyengine/bevy/tree/main/tools/ci
https://github.com/bevyengine/bevy/blob/main/.github/workflows/ci.yml


Extensions environments

Extensions environments
It would work like python venv, there would be a button that shows you each environment that you have and you could select one off them. Each environment can have different extensions.
Also it would be great if you could set a folder to a specific environment

/duplicate
Please search for issues with label extensions to find the duplicate


Deprecates all span transports except spring-cloud-sleuth-zipkin2

This deprecates span transports in favor of spring-cloud-sleuth-zipkin2
which:

Supports RabbitMQ and Kafka automatically when adding spring-rabbit or spring-kafka deps
Supports any io.zipkin.reporter2:zipkin-reporter sender, including Amazon X-Ray
Defaults to zipkin v2 format, but can be configured to use zipkin v1 format as needed

This lowers the amount of maintenance on the project, as discussed in various issues
See #727
See #711

Codecov Report

Merging #758 into master will increase coverage by 0.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #758      +/-   ##
============================================
+ Coverage     75.46%   76.12%   +0.65%
+ Complexity     1267     1265       -2
============================================
  Files           182      179       -3
  Lines          4683     4636      -47
  Branches        491      491
============================================
- Hits           3534     3529       -5
+ Misses          866      824      -42
  Partials        283      283

Impacted Files
Coverage Δ
Complexity Δ

...ramework/cloud/sleuth/trace/SpanContextHolder.java
78.94% <0%> (-5.27%)
16% <0%> (-1%)

.../sleuth/zipkin/DiscoveryClientEndpointLocator.java
73.91% <0%> (-4.35%)
6% <0%> (ø)

.../src/main/java/sample/SampleSleuthApplication.java
60% <0%> (ø)
3% <0%> (?)

...mework/cloud/sleuth/stream/StreamSpanReporter.java
82.22% <0%> (+2.22%)
12% <0%> (ø)
:arrow_down:

...k/cloud/sleuth/zipkin2/DefaultEndpointLocator.java
79.48% <0%> (+5.12%)
16% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6c543...1401514. Read the comment docs.


Short solution needed: "Output totals together with resulting table" (clickhouse)

Please help us write most modern and shortest code solution for this issue:
Output totals together with resulting table (technology: clickhouse)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Output totals together with resulting table


Make clear creating a signed app for Mac is not free

I spent sometime configuring the auto updater for Mac apps in my application. And just after that I tried to create my apple certificate.
Maybe if it was described somewhere I didn't have spent time on this.

Distributing Mac apps in any way is not free because of Gatekeeper, you have to have a Developer ID: https://developer.apple.com/support/compare-memberships.

Yeah. I didn't know that. Maybe including it in the docs will help other people avoiding the same mistake.

If you don't care about the warnings created by Gatekeeper, you can just sign your app with a self-authorized certificate, which works with autoUpdater. You also have to add instruction for users on how to ignore the security warning to open your app though, many hobby apps are going this way.
If you are submitting to MAS, you can not use the autoUpdater, the apps are updated in other ways.
Anyway I added a note on the money thing in the docs.

Cool. I think this enough.
Thanks

@zcbenz may be including your comment somewhere in the docs could help a lot. This way people would know that actually is possible use the auto updater with a self authorized certificate.


Updated to build frameworks (including iOS) and to use XCTest

Builds an iOS Framework, needed for Carthage
Shared schema naming conventions for Carthage
Converted all specs to XCTest, eliminating the requirement for Cocoapods since there isn't a third-party testing framework.

Fake pull req to fool Travis into building, Travis noticed but still wouldn't actually start the build so I cancelled it and closed this fake.


TapTree failed roundtrip serialization with hidden branches

TapTree can be build from TaprootBuilder having hidden branches; however PSBT does not provide format for presenting hidden branches. Thus, TapTree psbt serialization is buggy: it will present incorrect representation of trees/descriptors with hidden branches. As a result, TapTree also fails to roundtrip if a hidden branch is present:
    #[test]
    fn taptree_roundtrip() {
        let mut builder = compose_taproot_builder(0x51, [2, 2, 3, 3]);
        builder = builder.add_leaf_with_ver(4, Script::from_hex("b9").unwrap(), LeafVersion::from_consensus(0xC2).unwrap()).unwrap();
        builder = builder.add_hidden(4, sha256::Hash::default()).unwrap();
        let tree = TapTree::from_inner(builder).unwrap();
        let tree_prime = TapTree::deserialize(&tree.serialize()).unwrap();
        assert_eq!(tree, tree_prime);
    }

fails: test result: FAILED. 248 passed; 1 failed

Failure details
fails with
---- util::psbt::serialize::tests::taptree_roundtrip stdout ----
thread 'util::psbt::serialize::tests::taptree_roundtrip' panicked at 'called Result::unwrap() on an Err value: TaprootBuilder { branch: [None, Some(NodeInfo { hash: 6496f0779f38b871013be71ee7dcce8fcdcc02afc4c688acb159fc5de2fba55e, leaves: [LeafInfo { script: Script(OP_PUSHNUM_2), ver: TapScript, merkle_branch: TaprootMerkleBranch([a85b2107f791b26a84e7586c28cec7cb61202ed3d01944d832500f363782d675]) }, LeafInfo { script: Script(OP_PUSHNUM_1), ver: TapScript, merkle_branch: TaprootMerkleBranch([c276fef1386890619b80e10a4a328572d97493add269df1a15a7f89f8ae8ec09]) }] }), Some(NodeInfo { hash: 961070ebeeb6007c20b0af10c2ba10030d0efcef3b31d0e8f56173dd7b247fda, leaves: [LeafInfo { script: Script(OP_PUSHNUM_4), ver: TapScript, merkle_branch: TaprootMerkleBranch([a8199db85e1f94b911a63ffece012bb8afc92131e59a614341db4ed2312a3c48]) }, LeafInfo { script: Script(OP_PUSHNUM_3), ver: TapScript, merkle_branch: TaprootMerkleBranch([65479d810e8dac590c7bfc09abfc02d09613c9cdfbb7755df654cf49ae7e5e2b]) }] }), Some(NodeInfo { hash: 821934ea0490d6e99b82c05ca9603dcf0acf0423095f6a18ac49ea1853b2ebe0, leaves: [LeafInfo { script: Script(OP_NOP10), ver: Future(FutureLeafVersion(194)), merkle_branch: TaprootMerkleBranch([0000000000000000000000000000000000000000000000000000000000000000]) }] })] }', src/util/psbt/serialize.rs:389:49

The proposed solution is to introduce TaprootBuilder::has_hidden_branches and check that in TapTree::from_inner, returning error. I am already working on a PR fixing that.
Related discussion: https://github.com/rust-bitcoin/rust-bitcoin/pull/924#issuecomment-1085387179

Sorry for misunderstanding the error message: this is not a bug since the presence of the hidden branches is checked in TaprootBuilder::is_complete and TapTree::from_inner fails with weird Err(TaprootBuilder) error. Thus, it is not the roundtrip serialization which fails, but the tap tree construction.
PS. I think we should return a error type, not a builder; otherwise this is really confusing.

Converted from "bug" to a "question", which is actually "should we change the return type of TapTree::from_inner to a proper error"

his is not a bug since the presence of the hidden branches is checked in TaprootBuilder::is_complete

We only check whether the tree is complete. We don't check if the tree has no hidden nodes.

The proposed solution is to introduce TaprootBuilder::has_hidden_branches and check that in TapTree::from_inner, returning error. I am already working on a PR fixing that.

Indeed, we should do something like this. I thought I implemented it in my original suggestion, but looks like I forgot to do so :P

From @Kixunil (I don't know why github links are not working)
AFAIK it's a convention in Rust to not destroy data like this. Result<Self, TaprootBuilder> would be better.

Sorry for all the confusion. Yes, the complete tree with hidden branches can be converted into TapTree, which will fail serialization roundtrip. Fixed the test in the error description and test output.

@sanket1729 added fix to the #929

I'm sure achow is sick of us by now, but IMO this seems like a missing feature in PSBT.


Links to MSDN are broken.

Cannot navigate to F# API reference.
For example: Seq.reduce

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 67fae525-473a-3072-b024-6d91d0e033b9
Version Independent ID: 6e162795-52bd-f9df-4105-6919c1c72c88
Content: Sequences - F#
Content Source: docs/fsharp/language-reference/sequences.md
Product: dotnet-fsharp
GitHub Login: @cartermp
Microsoft Alias: phcart

Thanks for letting us know. This is a duplicate of #17557.


Update: Bring golint check back to 100% for goreport

Description
This brings the golint check in https://goreportcard.com/report/go.aporeto.io/trireme-lib#golint back to 100% (unless it is hiding more after this merge)

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1216",
    "commit-sha": "1c3c48fa7dc4791ec576ac02ae99c1295ee64723"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "811",
    "commit-sha": "64077711e071532dffcee5e40c5379861664be4e"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1216",
    "commit-sha": "1c3c48fa7dc4791ec576ac02ae99c1295ee64723"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "811",
    "commit-sha": "64077711e071532dffcee5e40c5379861664be4e"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1216",
    "commit-sha": "f792bfe356c0979414907d2d9eafa9cc9ececdaa"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "811",
    "commit-sha": "64077711e071532dffcee5e40c5379861664be4e"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1216",
    "commit-sha": "f792bfe356c0979414907d2d9eafa9cc9ececdaa"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "811",
    "commit-sha": "64077711e071532dffcee5e40c5379861664be4e"
  }
]

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "811",
    "commit-sha": "64077711e071532dffcee5e40c5379861664be4e"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1216",
    "commit-sha": "e0461e00c4dc40c4be25fd11403e5cf2b86699c3"
  }
]


Respect port from provided endpoint on node login

Coverage remained the same at 66.667% when pulling 04d45f9838b848f3a9f4f21b22672cf37da4cec7 on dan-f/pass-port-to-node-request into 479304cb8274b10e8ca7cb86d86f99435246ae40 on master.


Hackagotchi is bad

Problems:

The market menu still allows for transactions, regardless of whether the user has taken an item off the market or the item has been bought.
Placing an item on the market can cause a harvest.
SetBalance math does not work due to signal latency.

that last one was banker's fault lol
anyway these are all fixed


Fix inconsistent English in $input_errors[]

Some errors use "cannot", others use "can not".  Cannot is probably better here.
So make all $input_errors[] consistent.

I wonder if "cannot/can not" comes across differently in US v. UK English?  In UK English, "can not" in this kind of notification feels awkward and stilted, rather than just formal. "Cannot" feels informative rather than informal.

It's possible. Sometimes I read them exactly the same, other times I read them with more emphasis on the 'not'. They have identical definitions and "cannot" is a contraction, which is informal and something we try to avoid. I don't think it's worth changing.

Apologies for jumping in a random PR, but I do like grammar! In modern English "cannot" is the preferred version of "can not", as @stilez says using "can not" is stilted in most uses. As for it being a contraction, technically maybe (but there is no loss of letters so you could argue otherwise), it's certainly not considered an informal version. "Can't" on the other hand certainly would be and I'd disagree with using that. Nice summary of the opinions of various authoritative bodies (well, OED plus some American ones): http://www.dailywritingtips.com/cannot-or-can-not/

Given the last reference on the page -- "except when you want to be emphatic" (which we do, it's an error), and the "bottom line" section, I'd still leave them alone rather than change them.

Fair enough, but in terms of consistency "can not" appears in just 6 code files, "cannot" appears in 105 so looks to be the more common within the project. In firewall_rules_edit.php it's quite mixed, "cannot" is used 13 times and "can not" 11 times, all within the same type of error messages.

The "emphatic" refers to emphasising the negation - "you can not play until you do your homework", "Flowers can not go on the table". Here we don't really need such emphasis - it's a statement of fact rather than a command , that IPv4 addresses can't go in an IPv6 rule, and so on, and we're informing the user of the point, rather than demanding of them to emphatically avoid the opposite. But it's all semantics!

It's all the same. Too much time wasted arguing over nothing.


windows-2019 image no longer has "powershell.exe"

Description
The "setup-msys2" action I am using is trying to invoke "powershell.exe" directly: https://github.com/msys2/setup-msys2/blob/5d5539587e977c80c75e37b8fe25226a9843d456/main.js#L79
This started failing yesterday.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
https://github.com/stefantalpalaru/transmission-og/actions/runs/4838926725/jobs/8623655631
Is it regression?
https://github.com/stefantalpalaru/transmission-og/actions/runs/4835719292/jobs/8618267800
Expected behavior
"powershell.exe" available in Windows images
Actual behavior
"powershell.exe" not found
Repro steps
Try to use https://github.com/msys2/setup-msys2 which requires "powershell.exe" in PATH.

Hello @stefantalpalaru, I have checked, and "powershell.exe" on its place. Also, it is added to the $env:PATH variable. Finally, I could not reproduce your issue. The "setup-msys2" action works fine with the below code.
Could you please check your setup one more time, and close the issue if the problem no longer exists?
 - uses: msys2/setup-msys2@v2
        with:
          path-type: inherit
          install: base-devel intltool mingw-w64-x86_64-autotools mingw-w64-x86_64-cmake mingw-w64-x86_64-curl mingw-w64-x86_64-dht mingw-w64-x86_64-gtk3 mingw-w64-x86_64-libb64 mingw-w64-x86_64-libevent mingw-w64-x86_64-libnatpmp mingw-w64-x86_64-libnotify mingw-w64-x86_64-libutp mingw-w64-x86_64-miniupnpc mingw-w64-x86_64-openssl mingw-w64-x86_64-qt5-base mingw-w64-x86_64-qt5-tools mingw-w64-x86_64-qt5-winextras mingw-w64-x86_64-toolchain mingw-w64-x86_64-zlib
          msystem: MINGW64
          update: false
          pacboy: false
          release: true
          location: RUNNER_TEMP
          platform-check-severity: fatal

Turns out I was clobbering the PATH variable in an early step: https://github.com/msys2/setup-msys2/issues/300
Sorry about that.


feat: add denoland/deno/denort

denoland/deno/denort: A slim version of deno without tooling, used as the default for deno compile
Test
$ denort
error: No archive found.

This binary should be internal and users do not have to download them theirselves.


Scala Hadoop Enrich: bump Scala Common Enrich version to 0.18.0

Moving this ticket into Ed's release


When i add aspect mode to video view, getting this error "MediaPlayer needs to be of type IVideoView to use this extension"

🐛 Bug Report

When i add aspect mode = AspectFit to video view , getting this error "MediaPlayer needs to be of type IVideoView to use this extension"
Expected behavior
It should not throw any exception
Reproduction steps
Change AspectMode to AspectFit to video view
Configuration
Version: 0.5.3
Platform:

[x] :iphone: iOS
[x] :robot: Android
[x] :monkey: Xamarin.Forms

Exception details are in below attached file
exception.txt

Please use the issue template.

Should be fixed in 0.5.8. Let me know how it goes.

@martijn00  It's working when i added the property In Xaml Page.
But it throws an exception when i inherited video view like below code.
public class TappableVideoView : VideoView
{
public TappableVideoView()
{
AspectMode = MediaManager.Video.VideoAspectMode.AspectFit;
}
}

@SatyaRamprasad is that only on iOS or also Android? Can you post the exception stacktrace?

The Project type was Xamarin Forms, it didn't worked on Android.
I didn't checked on iOS
Message: Object reference not set to an instance of an object.
Source : MediaManager.Forms
stacktrace:
at MediaManager.Forms.VideoView.OnAspectModeChanged (Xamarin.Forms.BindableObject bindable, System.Object oldvalue, System.Object newvalue) [0x00000] in C:\Users\mhvdi\Documents\OpenSource\XamarinMediaManager\MediaManager.Forms\VideoView.cs:45
at Xamarin.Forms.BindableObject.SetValueActual (Xamarin.Forms.BindableProperty property, Xamarin.Forms.BindableObject+BindablePropertyContext context, System.Object value, System.Boolean currentlyApplying, Xamarin.Forms.Internals.SetValueFlags attributes, System.Boolean silent) [0x00120] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:624
at Xamarin.Forms.BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes, Xamarin.Forms.BindableObject+SetValuePrivateFlags privateAttributes) [0x00179] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:422
at Xamarin.Forms.BindableObject.SetValue (Xamarin.Forms.BindableProperty property, System.Object value, System.Boolean fromStyle, System.Boolean checkAccess) [0x0003d] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:572
at Xamarin.Forms.BindableObject.SetValue (Xamarin.Forms.BindableProperty property, System.Object value) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:122
at MediaManager.Forms.VideoView.set_AspectMode (MediaManager.Video.VideoAspectMode value) [0x00000] in C:\Users\mhvdi\Documents\OpenSource\XamarinMediaManager\MediaManager.Forms\VideoView.cs:40
at X.Controls.TappableVideoView..ctor () [0x00009] in D:\X\Mobile\X\X\Controls\TappableVideoView.cs:43

@martijn00
one more exception in aspect mode.
steps:

add AspectMode = AspectFit to video view in Xaml
play a video
go back to previous page
play a video again, throws below exception

Cannot access a disposed object.
Object name: 'MediaManager.Platforms.Android.Video.VideoView'.
at Java.Interop.JniPeerMembers.AssertSelf (Java.Interop.IJavaPeerable self) [0x00029] in <286213b9e14c442ba8d8d94cc9dbec8e>:0
at Java.Interop.JniPeerMembers+JniInstanceMethods.InvokeVirtualVoidMethod (System.String encodedMember, Java.Interop.IJavaPeerable self, Java.Interop.JniArgumentValue* parameters) [0x00000] in <286213b9e14c442ba8d8d94cc9dbec8e>:0
at Com.Google.Android.Exoplayer2.UI.PlayerView.set_ResizeMode (System.Int32 value) [0x00022] in <40678527bed24f2282bcddf562c4fa58>:0
at MediaManager.Platforms.Android.Video.VideoView.set_VideoAspect (MediaManager.Video.VideoAspectMode value) [0x0001c] in C:\Users\mhvdi\Documents\OpenSource\XamarinMediaManager\MediaManager\Platforms\Android\Video\VideoView.cs:57
at MediaManager.Forms.VideoView.OnAspectModeChanged (Xamarin.Forms.BindableObject bindable, System.Object oldvalue, System.Object newvalue) [0x00000] in C:\Users\mhvdi\Documents\OpenSource\XamarinMediaManager\MediaManager.Forms\VideoView.cs:45
at Xamarin.Forms.BindableObject.SetValueActual (Xamarin.Forms.BindableProperty property, Xamarin.Forms.BindableObject+BindablePropertyContext context, System.Object value, System.Boolean currentlyApplying, Xamarin.Forms.Internals.SetValueFlags attributes, System.Boolean silent) [0x00120] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:624
at Xamarin.Forms.BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes, Xamarin.Forms.BindableObject+SetValuePrivateFlags privateAttributes) [0x00179] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:422
at Xamarin.Forms.BindableObject.SetValue (Xamarin.Forms.BindableProperty property, System.Object value, System.Boolean fromStyle, System.Boolean checkAccess) [0x0003d] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:572
at Xamarin.Forms.BindableObject.SetValue (Xamarin.Forms.BindableProperty property, System.Object value) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:122
at X.Views.ExercisePlayerView.InitializeComponent () [0x00012] in D:\Mobile\X\X\obj\Debug\netstandard2.0\Views\Phone\VideoPlayer\PlayerView.xaml.g.cs:22
at X.Views.ExercisePlayerView..ctor () [0x00028] in D:\X\Mobile\X\X\Views\Phone\VideoPlayer\PlayerView.xaml.cs:24

@SatyaRamprasad i've released 0.6.0 with some fixes.

@martijn00 still not working on above two cases

Note that you can't set things in the ctor, as the native component is not ready by then. Please make a PR to the samples to showcase your problem.

Okay. But even setting in xaml page,i am facing this issue
https://github.com/martijn00/XamarinMediaManager/issues/453#issuecomment-493972446
and i will attach a sample project very soon with this issue

Okay. But even setting in xaml page,i am facing this issue
#453 (comment)
and i will attach a sample project very soon with this issue

@martijn00 i replicated the issue and attached, play the video twice or more.please let me know if anything i did wrong.
TVideoPlayer.zip

@SatyaRamprasad i don't use zip. Make a public repo on github and put the code there.


Prepare for a new release

To package new changes and dependencies updates.

Would it be possible to speed up the initial start-up delay, maybe by syncing in the background?

Is there an ETA for the new release?

I don't expect many new features in the new release TBH and not on a rush. Most changes would be dependency updates which are transparent to users.


Editor control has no description.

	$controls[] = array(
		'type'        => 'editor',
		'setting'     => 'projects_html_after',
		'label'       => __( 'Add/Edit Projects - Custom HTML (After)', 'maera-diy' ),
		'description' => __( 'You can use this field to enter any custom HTML that you would like to be displayed after the Add/Edit projects fields in the popup window.', 'maera-diy' ),
		'default'     => '
My Projects
',
		'priority'    => 3,
		'section'     => 'maera_diy_general',
	);

Visual Reference:

Hi
Has support for having html as the default text been removed ?

@stev0n HTML is stripped for security reasons, yes.

Hi
Thanks for your eply.
Is it not possible to just drop out the javascript tags and leave the others ?
regards
steve

On 10 Oct 2015, at 03:13, Aristeides Stathopoulos<EMAIL_ADDRESS>wrote:
@stev0n https://github.com/stev0n HTML is stripped for security reasons, yes.
—
Reply to this email directly or view it on GitHub https://github.com/aristath/kirki/issues/139#issuecomment-147022752.

Fixed.
If you pull a fresh copy it should now be working fine.
Thanks for reporting this!
However, please try to create a new ticket for issues like that so that we may better keep track of them. I almost missed the comments above since this ticket was already closed. :+1:

Hi Aristeides
Thanks, this works. I didn’t realise it was a bug and not a choice for security reasons.
But I had to make a little change.
if('' != $this->help )  —>   if ( ! empty($this->help ))
if help not set in the customiser, you get an error.
also,  I only downloaded this one page (class-kirki-controls-editor-control.php ) , so i had to change
extends Kirki_Customize_Control  —>  extends WP_Customize_Control
I think this project is great.
Recently, i had to write a custom control to handle a group of number fileds, which i wanted stored in the database as key -> pairs.
I did manage this with a little custom js and a modification to the class file so that it could  handle either the default key -> pair array or the serialized / json  (string) which my custom class recieves from the db.
The ability to handle key -> pair data in and out of the db would be a useful enhancement for your other controls. i could provide my scirpts if you are interested.
is there a place where you would like me to post a request for this upgrade ?
keep up the good work
regards
steve

On 11 Oct 2015, at 00:14, Aristeides Stathopoulos<EMAIL_ADDRESS>wrote:
Fixed.
If you pull a fresh copy it should now be working fine.
Thanks for reporting this!
However, please try to create a new ticket for issues like that so that we may better keep track of them. I almost missed the comments above since this ticket was already closed.
—
Reply to this email directly or view it on GitHub https://github.com/aristath/kirki/issues/139#issuecomment-147133887.

This has been resolved, editor controls now have descriptions as expected.


Schematics won't paste

Hello everyone, hopefully someone can help with a problem I am seeing with BuilderTools.  I can load a schematic, and it says it has loaded, but as soon as I try to paste, I get an error saying it isn't loaded.  I am running PocketMine-MP 3.23.1 and BuilderTools 1.2.0.  I have tried multiple schematics.  Are there recommended memory cleanup settings for PocketMine-MP that BuilderTools uses?
Thanks!

Could you please provide more information such as videos with reproducing the bug?

I'm closing this due to no response from author.


Missing information about the need for image pull secrets

As discussed on the WasmCloud#krustlet slack channel, we found out that the tutorials in the krustlet documentation lacked information about the need for image pull secret if the registry is not public. I have added a pull request for this #514

Closed in #514


Client Secret for Archivematica Azure App is expiring soon (31/10/20)

The "client secret" which allows users to sign in using their Wellcome Active Directory identity to Archivematica is due to expire on the 31st of October.
We must update it in Archivematica before then for it to continue to work. It would be nice if we could automate this process, or have a mechanism to remind us this is necessary for next time.
At present only @kenoir can update this secret - another developer should have access in Azure to do so.
This will involve creating a new secret in Azure and updating the correct SecretsManager secret with the new value.

[ ] Create new secret and move Archivematica to use it.
[ ] Look at mechanism to "auto-roll" new secrets / set a reminder that secret is going to expire.
[ ] Allow other developers to update client secrets for apps in Azure.

If we want to do this in Terraform, https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/resources/application_password looks promising.

Link to discussion in Slack, including the relevant part of the Azure portal: https://wellcome.slack.com/archives/CN56BRQ5B/p1602594530015900

Looking at this app again, it looks like I have permissions for<EMAIL_ADDRESS>but that account can no longer log into Azure.


Changed ssl layer to use EVP_KDF API for TLS1_PRF and HKDF.

Changed the ssl layer to use the EVP_KDF API instead of the EVP_PKEY API for the TLS1_PRF and HKDF algorithms.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I will merge this if no-one else is?

I will merge this if no-one else is?

Sure, go ahead

Thanks @davidmakepeace for the KDF goodness.


/web url appears to work and adds nothing to the context

Issue
I have yet do add files, and aider loads normally, adds itself to .gitignore, detects the .git folder, .env. I followed the suggestion to install chomium headless exactly as indicated, and it seems to work. i had to add certificates (Mac specific step).
Upon calling web with a url, the LLM returns a message about what to SEARCH/REPLACE. I asked to share the prompt, and I think the LLM is not getting any content from the /web command, neither is anything displayed in the command line screen. I tried a few urls.
Version and model info
Latest

I fixed itself used aider itself. I put the issue, and it decided to add other features (which not sure are the intended thing or not) but it decided to better parse things, focus on the main content, remove javascript, convert it to markdown for better understanding by the LLM, then paste the head (first few lines) in the command window and and ask if one would like to add that to the context, as opposed to just doing it without asking.

I this real or will this dream drift to some kind of nightmare singularity event?

Very nice. Aider has written 7% of itself.
https://aider.chat/2024/05/24/self-assembly.html

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


settings: Add design changes and fix bugs in profile settings.

This PR aims to improve the settings/profile component by fixing bugs and incorporating small design changes.
For context refer to #21158 and #21342
GIFs or screenshots:

Change description
Before
After

Hidden delete button

Removed "Profile photo" header

"Avatar changes are disabled in this organisation" message moved from tooltip to overlay

Moved user details to right side panel

Responsive textarea

Text placement in Avatar Overlay

Interchange "Role" and "Local time" in Profile Popover

Interchange "Role" and "Joined" in User Profile Modal

Awesome, thanks!
Let's switch role <-> joined date in the full profile to match the updated settings panel (i.e. role before joined date).

Other than that, looks great to me!

@alya I've pushed the required changes 👍

Cool, thanks! Could you please add a screenshot above?

added the screenshots in the PR description, thanks.

This is great, merged, thanks @sayamsamal!


:bug: ensure correct shutdown handlers called

What this PR does / why we need it:
This was a tangent I went on today. This PR both:

allows multiple servers to cleanly register shutdown handlers for interruption
Updates the http server hackery to ensure that previously registered signal handlers are actually invoked when uvicorn overrides all the signal handlers

Special notes for your reviewer:
This is a bit of a departure from how we were explicitly setting signal handlers in main methods before, but this allows us to easily handle uvicorn's insistence on overriding all signal handlers.
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Also, I don't see any unit tests

Yup! Didn't really have the bandwidth here and I couldn't find the gumption to try to patch in mock handlers that I could assert were called, but have them running in a subprocess...


src should be an optional prop for Plausible

I'm not sure I've approached this the right way, but my type checker was throwing an error if I used the <Plausible> component without a src. Since there's a default, I believe this should be an optional prop, and it looks like the previous approach of defining the type as src: string | undefined was not cluing the type checker in on this. Other astro plugins I looked at were using something like the convention I used here, src?: string, so I am proposing that as a change.
I believe that this is the more correct notation for this.

Thanks @nevanscott, makes sense to me!


img src gets mangled on some images

Produced with version 0.4.0-alpha1
Some pages have some of their img src attributes changed by the readibility code, resulting in broken urls that causes error 404 during fetching.
One page where I've noticed this bug is https://blindsquirrel.substack.com/p/etsy-the-power-of-special
Here the first image ("Strong & Competitive Market Position") gets mangled. It's img node is this (it's quite funky and has a data-attrs attribute, but the src url works):
<img src="https://cdn.substack.com/image/fetch/w_1456,c_limit,f_auto,q_auto:good,fl_progressive:steep/https%3A%2F%2Fbucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com%2Fpublic%2Fimages%2F7ba6067a-991d-47a0-b1ea-b24adf135f82_1099x454.png" data-attrs="{"src":"https://bucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com/public/images/7ba6067a-991d-47a0-b1ea-b24adf135f82_1099x454.png","height":454,"width":1099,"resizeWidth":null,"bytes":177952,"alt":null,"title":null,"type":"image/png","href":null}" alt="">

Then somehow during readibility processing src attribute gets changed to this value, appears to be the same as data-attrs attribute value, just url-decoded (the \ escaping is introduced during logging):
{\"src\":\"https://bucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com/public/images/7ba6067a-991d-47a0-b1ea-b24adf135f82_1099x454.png\",\"height\":454,\"width\":1099,\"resizeWidth\":null,\"bytes\":177952,\"alt\":null,\"title\":null,\"type\":\"image/png\",\"href\":null}

As it no longer looks like an absolute url (starts with {"src": "https:// instead of https://), fix_relative_uris will prepend the original base url, https://blindsquirrel.substack.com/p/, resulting in this broken url:
https://blindsquirrel.substack.com/p/%7B%22src%22:%22https://bucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com/public/
images/7ba6067a-991d-47a0-b1ea-b24adf135f82_1099x454.png%22,%22height%22:454,%22width%22:1099,%22resizeWidth%22:null,%22bytes%22:177952,%22alt%22:null,%22title%22:null,%22type%22:%22image/png%22,%22href%22:null%7D, new_url=https://blindsquirrel.substack.com/p/%7B%22src%22:%22https://bucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com/public/images/7ba6067a-991d-47a0-b1ea-b24adf135f82_1099x454.png%22,%22height%22:454,%22width%22:1099,%22resizeWidth%22:null,%22bytes%22:177952,%22alt%22:null,%22title%22:null,%22type%22:%22image/png%22,%22href%22:null%7D

The weird thing is that not all images have this problem. Here's an img node that does not get mangled:
<img src="https://cdn.substack.com/image/fetch/w_1456,c_limit,f_auto,q_auto:good,fl_progressive:steep/https%3A%2F%2Fbucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com%2Fpublic%2Fimages%2F9f4b3eaa-0537-403d-b9c8-a91f88724cc8_959x617.png" data-attrs="{"src":"https://bucketeer-e05bbc84-baa3-437e-9518-adb32be77984.s3.amazonaws.com/public/images/9f4b3eaa-0537-403d-b9c8-a91f88724cc8_959x617.png","height":617,"width":959,"resizeWidth":576,"bytes":null,"alt":"Focus on Marketplace \nin Six Core Geographies \nCore markets have our largest concentrations ofbuyers and \nsellers and present the most significant growth opportunities \nTOP GEOGRAPHIES: \nWe are building local marketplaces globally and deepening \nlocal Etsy communities globally \nLarge and Growing Addressable Market \nEstimated 2018 Total Retail and Online TAM \nSl.7T \neat \n049B \nto ALL \nretail top geqraphies \n-SIOOB \nGER \"ANY \n8.9B \n2018 GLOBAL GMS \nETSY MARKET SHARE ","title":null,"type":null,"href":null}" alt="Focus on Marketplace
in Six Core Geographies
Core markets have our largest concentrations ofbuyers and
sellers and present the most significant growth opportunities
TOP GEOGRAPHIES:
We are building local marketplaces globally and deepening
local Etsy communities globally
Large and Growing Addressable Market
Estimated 2018 Total Retail and Online TAM
Sl.7T
eat
049B
to ALL
retail top geqraphies
-SIOOB
GER "ANY
8.9B
2018 GLOBAL GMS
ETSY MARKET SHARE ">

The only difference I've noticed is that every img node that fails has an alt="" attribute and every good img has a non-empty alt attribute.

I created a reduced testcase for moz_readibility/mod.rs that reproduces the issue.
    #[test]
    fn test_issue_13() {
        macro_rules! check_img_src_prefix {
            ($html:expr, $expected_prefix:expr) => {
                let mut doc = Readability::new($html);
                doc.parse("https://original.url/")
                    .expect("Should parse successfully");
                let img = doc
                    .article_node
                    .unwrap()
                    .select("img")
                    .unwrap()
                    .next()
                    .unwrap();
                let expected_prefix = "https://image.url";
                let attrs = img.attributes.borrow();
                let actual_url = attrs.get("src").unwrap();
                assert!(
                    actual_url.starts_with(expected_prefix),
                    "url should start with {}, url={}",
                    $expected_prefix,
                    actual_url
                );
            };
        }

        // generate an html string with an img tag that has a 'data-attrs' attribute that contains an 'alt' key having the value ALT_TEXT
        macro_rules! alt_text {
            ($ALT_TEXT:expr) => {
                concat!(r#"

                    Text

            "#)
            }
        }

        let expected_prefix = "https://image.url";

        check_img_src_prefix!(alt_text!("STUFF WITH SPACE"), expected_prefix); // OK
        check_img_src_prefix!(alt_text!("STUFF_WITHOUT_SPACES"), expected_prefix); // FAiLS
    }

What I noticed:

data-attrs must contain an src with an url that ends with a recognized image extension, if I change png to pnx both checks pass
If alt contains anything with a space, it passes.

I haven't found the code that does anything with data-attrs yet.


Rfc 0453 take 2

Was https://github.com/hyperledger/aries-cloudagent-python/pull/926

Codecov Report

Merging #930 (000dc65) into master (d3895f6) will increase coverage by 0.07%.
The diff coverage is 99.92%.

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   98.88%   98.95%   +0.07%
==========================================
  Files         298      317      +19
  Lines       16935    18243    +1308
==========================================
+ Hits        16746    18053    +1307
- Misses        189      190       +1

Codecov Report

Merging #930 (000dc65) into master (d3895f6) will increase coverage by 0.07%.
The diff coverage is 99.92%.

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   98.88%   98.95%   +0.07%
==========================================
  Files         298      317      +19
  Lines       16935    18243    +1308
==========================================
+ Hits        16746    18053    +1307
- Misses        189      190       +1

@sklump I'm awaiting on this PR before I release my PR with updates to the alice/faber/performance demo (https://github.com/hyperledger/aries-cloudagent-python/pull/921) so as to not reverse-clobber your demo updates.

@sklump I'm awaiting on this PR before I release my PR with updates to the alice/faber/performance demo (https://github.com/hyperledger/aries-cloudagent-python/pull/921) so as to not reverse-clobber your demo updates.

Apart from the change to the TAA caching I think it looks good

I don't understand:

Apart from the change to the TAA caching I think it looks good

I don't understand - this is what's in master: https://github.com/hyperledger/aries-cloudagent-python/blob/d3895f6394a5f24a895731bcf6fb672e0d84804e/aries_cloudagent/ledger/indy.py#L1052
I have merged it with master and I haven't touched it. How has it ended up in my PR?

Apart from the change to the TAA caching I think it looks good

I don't understand:

Apart from the change to the TAA caching I think it looks good

I don't understand - this is what's in master: https://github.com/hyperledger/aries-cloudagent-python/blob/d3895f6394a5f24a895731bcf6fb672e0d84804e/aries_cloudagent/ledger/indy.py#L1052
I have merged it with master and I haven't touched it. How has it ended up in my PR?

Apart from the change to the TAA caching I think it looks good

To be perfectly clear: you want me to make this look like what's in master?

Apart from the change to the TAA caching I think it looks good

To be perfectly clear: you want me to make this look like what's in master?

Apart from the change to the TAA caching I think it looks good

To be perfectly clear: you want me to make this look like what's in master?

Yes, just reviewing this the code in master is a recent fix to make TAA work for multitenancy

Apart from the change to the TAA caching I think it looks good

To be perfectly clear: you want me to make this look like what's in master?

Yes, just reviewing this the code in master is a recent fix to make TAA work for multitenancy


Graph Editor: connecting separate outputs to combine inputs

Hello, just tried to see how separate and combine are setup and tried to connect separate outputs to combine inputs directly.
I'm not sure if this is supported or how the outputs from the separate node can be accessed / used
created graph:

saved material:
<?xml version="1.0"?>
<materialx version="1.38">
  <separate3 name="separate3_vector3" type="multioutput" xpos="5.050725" ypos="-2.000000">
    <input name="in" type="vector3" nodename="constant_vector3" />
  </separate3>
  <constant name="constant_vector3" type="vector3" xpos="3.405797" ypos="-1.965517" />
  <combine3 name="combine3_vector3" type="vector3" xpos="7.094203" ypos="-2.034483">
    <input name="in1" type="float" value="0" />
    <input name="in2" type="float" nodename="separate3_vector3" />
    <input name="in3" type="float" value="0" />
  </combine3>
</materialx>

loading the saved material:

This is definitely creating the incorrect graph.
Not sure why. It should look like this:
<?xml version="1.0"?>
<materialx version="1.38">
  <separate3 name="separate3_vector3" type="multioutput" xpos="5.050725" ypos="-2.000000">
    <input name="in" type="vector3" nodename="constant_vector3" />
  </separate3>
  <constant name="constant_vector3" type="vector3" xpos="3.405797" ypos="-1.965517" />
  <combine3 name="combine3_vector3" type="vector3" xpos="7.094203" ypos="-2.034483">
    <input name="in1" type="float" nodename="separate3_vector3" output="outy" />
    <input name="in2" type="float" nodename="separate3_vector3" output="outx"/>
    <input name="in3" type="float" nodename="separate3_vector3" output="outz"/>
  </combine3>
</materialx>

For reference, a downstream node which references an upstream node (like separate) with multiple outputs needs to specify both it's upstream node / nodegraph and the name of the output to disambiguate.

Thanks a lot for the quick reply!!

This is a great catch, @marwie, and this issue would be very worthwhile to address!

This is a great catch, @marwie!  I'm CC'ing @lfl-eholthouser for her thoughts and recommendations, and I'd agree this is a worthwhile issue to address.

Thanks for flagging this @marwie, The Graph Editor doesn't currently support nodes with multiple outputs so while the graph is incorrect it's expected in a sense since the implementation is not there. I agree with @jstone-lucasfilm that this is a very valuable issue to address.

It does sound like the UI can support the load / display of the links.
The connection logic is probably just setting incorrect information on the MaterialX document itself.
If that's the case then we can this for now, but seems like just a localized fix is required.

Got it, thanks @kwokcb, and it's sounding like this is just a bug in the step that interprets multioutput graph edits as MaterialX document edits.
This seems like a strong candidate for issues to address in 1.38.8, and if anyone has the bandwidth to take a look, let us know!

I'm taking a quick look: Seems both link breakage and link addition are incorrect.

Thanks @kwokcb!


UI fixes

Added confirmation prompt when removing a member
Added modal styling
Fixed survey detail icons

Kindly resolve merge conflicts first to update to the latest being used @jaredblase


Use dropwizard-dependencies BOM, which removes the need to pull in some dependencies ourselves

(Spotted this while searching for something else)
I think the ignores for dropwizard are in the wrong section of the dependabot.yml file - it should go under the maven section rather than docker?


Number of training epochs

Hello,
I had a question about the number of epochs, compared to other methods (like MeshCNN) your method runs for far more epochs. Like in the case of ModelNet40, 500000 iterations. Is this due to a typo or does MeshWalker need to be trained so much?
Thanks again.

Hi,
I'm glad to have this discussion with you, hope it helps you..
Regarding your question, don't forget MeshWalker is very different from other methods.
Number of iteration is not a typo - it does take many iterations compared to MeshCNN which is super-fast :)
Alon.

Hi Alon, thank you for confirming :)


Implement userlocation details by using Geolocation API and Nominatim API

#168 combining both geolocation api and nominatim api

Closes #168

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @Rohitha-pudu, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@Rohitha-pudu We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣

@Rohitha-pudu We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁 Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇 Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥 Happy Coding! ✨ Will See you soon❣

u forgot to assign? @dishamodi0910

/gssoc24


[TRANSITION OF PAGE ON CLICKING ON THE "MENTAL HEALTH PROBLEMS IN NAVBAR"]

When you click on the "MENTAL HEALTH PROBLEMS" button on the navbar, it will transition directly to the section on the home page with a sudden jerk.
Furthermore, It land on that section such that the heading is not visible.
I want to make the transition like scrolling and make it land such that the heading is visible.
This will improve the user interface.

please assign me this issue


GC US Copy/Erase Textures Bugged

Likely needs to have similar treatment to #442

Fixed by Rika Bravo (1.0.1)


Fixes a typo in months of the year

Hey Mike, this actually needs to be fixed in Crowdin or it will get lost in the next update: https://crowdin.com/translate/grav-core/5/en-de


[Engine] Serializer Todo List

[x] IList
[x] Array - Seems to be handling them pretty well now
[x] IDictionary
[x] String
[x] Bool
[x] Byte
[x] sByte
[x] Int16
[x] Int32
[x] Int64
[x] UInt16
[x] UInt32
[x] UInt64
[x] Float
[x] Double
[x] Decimal
[x] Enum - Serialized as Int32
[x] DateTime - Serialized as Int64
[x] Byte[]
[x] Guid - Serialized as String

Im sure theres more i've missed but this covers most cases


🧑💻: Add Contributors section

Title
Contributors section
Enhancement Aim
I proposed to add a page for the contributors to display their profile and the number of contributions they done so far in the project.
Changes

Create a new page for contributors accessed from the Navbar or from the footer listed items
Simple Javascript script to fetch the data and then display it on the contributors
Ensuring Pagination to load few chunk of data, and call another chunk once user loads to the end of the page

Screenshots 📷

Guidelines

[X] I have read the guidelines
[X] I have the link to my latest merged PR

Full Name
Yash K. Saini
Participant Role
GSSoC-Ext

@vanshchauhan21 can you assign this issue to me with proper labels

@vanshchauhan21 can you assign this issue to me with proper labels

Bro this issue is already assigned and already merged

Sorry My bad, didn't see the button there properly

Sorry My bad, didn't see the button there properly

Np


Adding new platform Hegel for media_player component

Description:
I've developed a new platform for the media player component that can control a Hegel Integrated Amplifier. It controls the amplifier via telnet and supports all the basic media_player actions like volume set, turn on/off, etc.
Related issue (if applicable):
n.a.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8387
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: hegel
    host: <IP_ADDRESS>

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New files were added to .coveragerc.

Hi @ruudverheijden,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I will close this PR. You can open a new PR when the code has been extracted into a new PyPI lib.