BUG: dynamic tabs recipe

I have updated to the latest version but still receive,
  File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1997, in __call__     return self.wsgi_app(environ, start_response)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app     response = self.handle_exception(e)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1540, in handle_exception     reraise(exc_type, exc_value, tb)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise     raise value   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app     response = self.full_dispatch_request()   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request     rv = self.handle_user_exception(e)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception     reraise(exc_type, exc_value, tb)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise     raise value   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request     rv = self.dispatch_request()   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request     return self.view_functions[rule.endpoint](**req.view_args)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/dash/dash.py", line 556, in dispatch     return self.callback_map[target_id]['callback'](*args)   File "/Users/serlucov/anaconda/lib/python3.6/site-packages/dash/dash.py", line 513, in add_context     output_value = func(*args, **kwargs)   File "/Users/serlucov/WorkDocs/Markdown/Dash Master Class/dash_tabs.py", line 25, in display_content     dcc.Tabs( AttributeError: module 'dash_core_components' has no attribute 'Tabs'

see https://github.com/plotly/dash-core-components/pull/74


[keymgr] D2(S) Signoff

Description
Ensure D2(S) signoff criteria are still maintained (this is not a focus area block).

This analysis is work in progress.
Commits since Earlgrey-ES tapeout
git rev-parse HEAD

c73929e4d6e864bad72c456b265a089225a5c8e2
git log Earlgrey-M2.5.2-RC0..HEAD --oneline hw/ip/keymgr

52da8f707d [keymgr] Add missing CM annotation
--> RTL changed but only a CM label added
0d14dd693f [docs] Fix repetitions of the definite article
--> no RTL changed; spelling fixed in spec
56399241e7 Revert "[edn] Move prim_edn_req out of prim"
--> reverts 3b4e36e01c below
c721c51c13 [rtl, prim] Add 'commit' functionality to prim_count
--> RTL changed but no functional difference
e81b5885e5 [keymgr/otp_ctrl] Add support for creator/owner seeds
--> RTL change with functional impact; to be reviewed in detail
61a237e197 [util/reggen] reverse order of substruct generation
--> RTL changed but no functional difference
3b4e36e01c [edn] Move prim_edn_req out of prim
--> reverted by 56399241e7 above
de31bdf1c2 [reggen] Remove the devmode input
--> RTL changed but no functional difference
963a5006cc [doc] Minor tweak to md sanitisation code
--> no RTL changed; spec docs changed but changes should be structural only
975a6eb927 [adc_ctrl,dv] Tidy up access to intr_state in env_cfg files
--> no RTL nor specification changed
1b16ca2122 [reggen] Add mubi support SWAccess that sets/clears a reg
--> RTL changed but no functional difference
59f8142826 [doc] Moved badges over to using hosted images
--> no RTL nor specification changed
8ba7e45f4e [SiVal] Test plan updates for keymgr
--> no RTL nor specification changed
19c05ad821 [doc] keymgr registers and interfaces now use CMDGEN
--> no RTL changed; spec docs changed but changes should be structural only
7688e714e8 [reggen] Add initial support for version and cip_id hjson fields
--> no RTL changed
fbd888eea8 Revert "[reggen] Add CIP_IDs and bump all major versions"
--> reverts commit below
0ba10b3cd3 [reggen] Add CIP_IDs and bump all major versions
--> reverted by commit above
e47df29f3e [misc] Use lc_tx_t testing functions at endpoints
--> RTL changed but no functional difference

Issues closed since the Earlgrey-ES tapeout
Currently open issues
Coverage report from <DD/MM/YYYY>
Summary

@vogelpi: May I ask you for feedback on my analysis and D2 signoff approval if you agree?

Thanks for putting this together @andreaskurth !
To be honest, I am in favor of signing of D2S. This is the state keymgr was before and as you pointed out, no significant changes have gone in since the last sign-off. So there is IMO no need to go back down again. I agree that there are a couple of security hardening changes we want to do for M3. But all of them are minor. We also keep adding security improvements to other blocks after hitting D2S.
D2S just says security countermeasures are implemented and this is the case for keymgr. The things coming in M3 are not about adding new countermeasures but minor improvements to existing things.
So to summarize: signing of at D2 is definitely okay, signing of at D2S would be preferred from my side. It will save us further paper work in M3.

Alright, given that (1) keymgr has been signed off at D2S before and the changes since then don't revert D2S and (2) #8120 is tracked for M3, I agree that we can sign keymgr off at D2S again.


OpenWhisk weather function fails

I'm still trying to run the BluePic app and now I'm hitting a problem with the OpenWhisk weather action.  When I try to post an image within the iOS app I can see some of the OpenWhisk actions run.  There seems to be a problem with the weather action.  It's returning { "weather": "" } and this causes processImage to fail with { "error": "the action did not return a valid result" }.
I can see (in wsk activiation poll) that the weather action is getting a 401 unauthorized.  I think there's a compatibility issue between the InsightsForWeather SDK that Weather.swift is using and the current version of the weather service on BlueMix.  I think the BlueMix weather service recently changed from 'Insights for Weather' to 'Weather Company Data for IBM BlueMix' and the weather SDK doesn't seem to work with the new service.
I tried commenting here, but no response yet:
https://github.com/IBM-Swift/swift-watson-sdk/issues/30

Be sure to take a look at the comments in swift-watson-sdk issue.  Seems like the understand that SDK is unable to talk the the current Bluemix weather service.  For now, I'll just change my copy of the weather OpenWhisk action to return some hardcoded data.  But want to make sure you're aware of this issue, because it causes /processImage whisk action to fail.

@kurtismgit Thanks for this, we are aware of the issue and we are working on a plan to avoid this issue in the future. Unfortunately, it is not completely in our control.

To address this issue, a few different pieces need to be fixed. We have reached out to the corresponding teams. It may be a few weeks before this gets sorted out though.

What do you guys think about the /processImage flow being able to complete even when weather action fails?  Essentially changing BluePic so that everything still works, except you wouldn't have any weather data.

Any updates on this?

BluePic is very resource constrained at the moment… we are in touch with the teams BluePic has external dependencies on. We expect to have fixes for these issues in the next following weeks. In the meantime, yes, there is an issue with the weather service (and related SDK) that impacts the OpenWhisk sequence execution. However, this does not affect the main functionality of the app (e.g. uploading pics, seeing the feed, MCA authentication, etc.).

Quick update. This item is currently being addressed as part of issue #286.

Fix is now in develop branch. Closing issue. We will merge into master early next week.


Create the Python Script in server.py that serves the static vite build

Task :

[ ] Modify the script in package.json and set path of build directory to server.
[ ] Use those static files and serve them within the server.

please assign me this

GO for it! @yash8000

What's the update @yash8000 ?
Are you upto it?

yes


NZ_13V is not part of the genome tree

see: http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62

the logs say
Note: taxon 'NZ_13V_1' is a duplicate of taxon 'Shaanxi_M228_1'.
Note: taxon 'NZ_13V_0' is a duplicate of taxon 'Shaanxi_M228_0'.

I dimly recall that we had a similar case before but can't find it anymore. Maybe the label is just hidden behind "Shaanxi..." ?

Yes, it was a setting in PhyML. I think we might have just changed the phyml version at the time.
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Author" @.>
Sent: Tuesday, August 23, 2022 2:17:45 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
the logs say
Note: taxon 'NZ_13V_1' is a duplicate of taxon 'Shaanxi_M228_1'.
Note: taxon 'NZ_13V_0' is a duplicate of taxon 'Shaanxi_M228_0'.

I dimly recall that we had a similar case before but can't find it anymore. Maybe the label is just hidden behind "Shaanxi..." ?
--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1223988371
You are receiving this because you authored the thread.
Message ID: @.***>

that's right. but i have not changed phyml version ...
but it's a lead i'll track down.
On Tue, 2022-08-23 at 05:31 -0700, fredeBio wrote:

Yes, it was a setting in PhyML. I think we might have just changed
the phyml version at the time.
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Author" @.>
Sent: Tuesday, August 23, 2022 2:17:45 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the
genome tree (Issue #9)
the logs say
Note: taxon 'NZ_13V_1' is a duplicate of taxon 'Shaanxi_M228_1'.
Note: taxon 'NZ_13V_0' is a duplicate of taxon 'Shaanxi_M228_0'.

I dimly recall that we had a similar case before but can't find it
anymore. Maybe the label is just hidden behind "Shaanxi..." ?

I found the old issue over at gitlab (https://gitlab.gwdg.de/mpievolbio-scicomp/repinpop/-/issues/99). Phyml has not changed on the server.

Looked up the phyml documentation, it has a --leave_duplicates option. Maybe that solves the issue?

So we just change the phyml command? That would be a nice and easy fix.
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Author" @.>
Sent: Tuesday, August 23, 2022 2:48:34 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
Looked up the phyml documentation, it has a --leave_duplicates option. Maybe that solves the issue?
--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1224026018
You are receiving this because you authored the thread.
Message ID: @.***>

I reran phyml with --leave_duplicates on the server, @fredeBio can you check the output at http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62 ?

Nz13 is still missing :(
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Tuesday, August 23, 2022 2:56:19 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
I reran phyml with --leave_duplicates on the server, @fredeBio can you check the output at http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62 ?
--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1224036103
You are receiving this because you were mentioned.
Message ID: @.***>

ah i see, you mean the tree in the REPINs tab. that is computed by andi+clustDist, not phyml, correct?
On Tue, 2022-08-23 at 06:02 -0700, fredeBio wrote:

Nz13 is still missing :(
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Tuesday, August 23, 2022 2:56:19 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the
genome tree (Issue #9)
I reran phyml with --leave_duplicates on the server, @fredeBio can
you check the output at
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62 ?

True! So we have double trouble now :D so we need to fix phyml (did you manage to do this?) and andi! but I don't remember andi causing this issue ever.
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Thursday, August 25, 2022 9:09:16 AM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
ah i see, you mean the tree in the REPINs tab. that is computed by andi+clustDist, not phyml, correct?
On Tue, 2022-08-23 at 06:02 -0700, fredeBio wrote:

Nz13 is still missing :(
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Tuesday, August 23, 2022 2:56:19 PM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the
genome tree (Issue #9)
I reran phyml with --leave_duplicates on the server, @fredeBio can
you check the output at
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62 ?

--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1226863814
You are receiving this because you were mentioned.
Message ID: @.***>

i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line encoding. NZ_13V.fas happens to be DOS encoded, the other files are all unix encoded. rewriting NZ_13V.fas to unix solves the issue.

fixed:
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62
On Thu, 2022-08-25 at 09:26 +0200, Carsten Fortmann-Grote wrote:

i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line
encoding. NZ_13V.fas happens to be DOS encoded, the other files are
all unix encoded. rewriting NZ_13V.fas to unix solves the issue.

 But I guess it will never happen again now?
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Thursday, August 25, 2022 9:26:27 AM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line encoding. NZ_13V.fas happens to be DOS encoded, the other files are all unix encoded. rewriting NZ_13V.fas to unix solves the issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1226879939
You are receiving this because you were mentioned.
Message ID: @.***>

Looks good :)
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Thursday, August 25, 2022 9:30:15 AM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the genome tree (Issue #9)
fixed:
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62
On Thu, 2022-08-25 at 09:26 +0200, Carsten Fortmann-Grote wrote:

i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line
encoding. NZ_13V.fas happens to be DOS encoded, the other files are
all unix encoded. rewriting NZ_13V.fas to unix solves the issue.

--
Reply to this email directly or view it on GitHub:
https://github.com/mpievolbio-scicomp/rarefan/issues/9#issuecomment-1226883653
You are receiving this because you were mentioned.
Message ID: @.***>

submitter must have opened the file in some windows app and then saved in dos format. we need to check somewhere that all files are unix encoded and/or convert to unix as needed.
 But I guess it will never happen
again now?
----- Original Message -----
From: "Carsten Fortmann-Grote" @.>
To: "mpievolbio-scicomp/rarefan" @.>
Cc: "Frederic Bertels" @.>, "Mention" @.>
Sent: Thursday, August 25, 2022 9:26:27 AM
Subject: Re: [mpievolbio-scicomp/rarefan] NZ_13V is not part of the
genome tree (Issue #9)
i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line
encoding. NZ_13V.fas happens to be DOS encoded, the other files are
all unix encoded. rewriting NZ_13V.fas to unix solves the issue.

PR #10 addresses this issue. All files are rewritten with explicit unix formatting.

now!
On Thu, 2022-08-25 at 09:30 +0200, Carsten Fortmann-Grote wrote:

no wait, it's still missing ???
On Thu, 2022-08-25 at 09:30 +0200, Carsten Fortmann-Grote wrote:

fixed:
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62
On Thu, 2022-08-25 at 09:26 +0200, Carsten Fortmann-Grote wrote:

i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line
encoding. NZ_13V.fas happens to be DOS encoded, the other files
are
all unix encoded. rewriting NZ_13V.fas to unix solves the issue.

no wait, it's still missing ???
On Thu, 2022-08-25 at 09:30 +0200, Carsten Fortmann-Grote wrote:

fixed:
http://rarefan.evolbio.mpg.de//shiny/analysis/?run_id=3slnqi62
On Thu, 2022-08-25 at 09:26 +0200, Carsten Fortmann-Grote wrote:

i need to test the phyml thing locally first.
andi does not like DOS filetype, in particular the end-of-line
encoding. NZ_13V.fas happens to be DOS encoded, the other files are
all unix encoded. rewriting NZ_13V.fas to unix solves the issue.


[languages] JQuery Datepicker

JQuery Datepicker
Introduction
Datepickers in jQueryUI make it simple for users to input dates graphically. Users can simply change the date formatting and language, limit the date range that may be selected, and add other navigation button options. The Datepicker is commonly used in conjunction with a text box. It can easily shift the specified date from the calendar to the text box.
This article will contain examples of how jQuery Datepicker is implemented. It will also show how to interlock two Datepickers and finally a clear step by step process of adding Datepickers to MVC.
Key takeaways
At the end of this tutorial the reader should be able to understand the following:

How to implement jQuery Datepicker
Interlocking two Datepickers
Add Datepickers in MVC

Article quality
The article will contain unique and original information about jQuery Datepickers. The language I will use will be simple in order to enhance understanding for anyone reading it.

Good afternoon and thank you for submitting your topic to the EngEd program.
After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites and official documentations. We typically refrain from publishing content that is covered widely on the net or other blogs. We're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
But in order to approve the topic it has to serve value to the larger developer community at large. Please feel free to suggest an alternate topic to explore. 🚀
An option and a great way to write this as an in-depth article and make it more add value to the greater developer community at large would be to walk the reader through the USE of methods and functions by building a unique, different, useful project.
If you believe your article is unique enough - please present your case to explain how it will be different from what is currently out there?
https://www.google.com/search?q=JQuery+Datepicker&rlz=1C1CHBF_enUS891US891&sourceid=chrome&ie=UTF-8


boards/qemu_x86: Rename dts.fixup to dts_fixup.h

Use the new naming for DT fixup.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9b87f63). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10479   +/-   ##
=========================================
  Coverage          ?   53.23%
=========================================
  Files             ?      210
  Lines             ?    25800
  Branches          ?     5677
=========================================
  Hits              ?    13735
  Misses            ?     9755
  Partials          ?     2310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b87f63...dbcf875. Read the comment docs.

Needs to be merged ASAP. Is blocking other PR's.


I2C should expose Ack settings for each transfer (like esp-idf does)

Motivations
The I2C hardware can be used to speak SCCB which is a protocol similar to I2C used to speak to cameras.
esp-hal currently abides by embedded-hal::i2c's ack rules but those rules don't apply to all devices, like those that speak SCCB.
Solution
Perhaps each transfer method (write, read, etc.) should take an extra config parameter to configure the ack settings.
Alternatives
Write a 3rd party driver...
Additional context
Not at the moment.

Ah no, I definitely don't want direct SCCB support in the HAL.
I just want to be able to set these and do it myself.

ack_exp: Ack
ack_check_en: bool
ack_value: Ack

Maybe SCCB could be a community crate. (Though the protocol isn't necessarily consistent across all cameras anyway, so maybe not worth doing, idk)


Harden w.clusters.ensure_cluster_running()

Changes

Retry on OperationFailed errors, same as in Java SDK

Tests

[ ] make test run locally
[ ] make fmt applied
[ ] relevant integration tests applied

I think you need to handle the case where the cluster is already running.


formattedMessage cache is obsolete when size > 100

Looking into the performance problems I checked o see what happens when a file has more diagnostics than the cache size allows for (currently 100).
I found that the part:
https://github.com/yoavbls/pretty-ts-errors/blob/2531440478077fd3f3335e3e3d1b92c9679eb1bc/src/extension.ts#L61-L64
does not work as intended, since the first diagnostic that is being checked for will not be part of the cache. Then the newly formattedMessage will replace an entry in the cache, causing the next diagnostic to also be a cache miss.

Example file

const diagnostic_1 = a1;
const diagnostic_2 = a2;
const diagnostic_3 = a3;
const diagnostic_4 = a4;
const diagnostic_5 = a5;
const diagnostic_6 = a6;
const diagnostic_7 = a7;
const diagnostic_8 = a8;
const diagnostic_9 = a9;
const diagnostic_10 = a10;
const diagnostic_11 = a11;
const diagnostic_12 = a12;
const diagnostic_13 = a13;
const diagnostic_14 = a14;
const diagnostic_15 = a15;
const diagnostic_16 = a16;
const diagnostic_17 = a17;
const diagnostic_18 = a18;
const diagnostic_19 = a19;
const diagnostic_20 = a20;
const diagnostic_21 = a21;
const diagnostic_22 = a22;
const diagnostic_23 = a23;
const diagnostic_24 = a24;
const diagnostic_25 = a25;
const diagnostic_26 = a26;
const diagnostic_27 = a27;
const diagnostic_28 = a28;
const diagnostic_29 = a29;
const diagnostic_30 = a30;
const diagnostic_31 = a31;
const diagnostic_32 = a32;
const diagnostic_33 = a33;
const diagnostic_34 = a34;
const diagnostic_35 = a35;
const diagnostic_36 = a36;
const diagnostic_37 = a37;
const diagnostic_38 = a38;
const diagnostic_39 = a39;
const diagnostic_40 = a40;
const diagnostic_41 = a41;
const diagnostic_42 = a42;
const diagnostic_43 = a43;
const diagnostic_44 = a44;
const diagnostic_45 = a45;
const diagnostic_46 = a46;
const diagnostic_47 = a47;
const diagnostic_48 = a48;
const diagnostic_49 = a49;
const diagnostic_50 = a50;
const diagnostic_51 = a51;
const diagnostic_52 = a52;
const diagnostic_53 = a53;
const diagnostic_54 = a54;
const diagnostic_55 = a55;
const diagnostic_56 = a56;
const diagnostic_57 = a57;
const diagnostic_58 = a58;
const diagnostic_59 = a59;
const diagnostic_60 = a60;
const diagnostic_61 = a61;
const diagnostic_62 = a62;
const diagnostic_63 = a63;
const diagnostic_64 = a64;
const diagnostic_65 = a65;
const diagnostic_66 = a66;
const diagnostic_67 = a67;
const diagnostic_68 = a68;
const diagnostic_69 = a69;
const diagnostic_70 = a70;
const diagnostic_71 = a71;
const diagnostic_72 = a72;
const diagnostic_73 = a73;
const diagnostic_74 = a74;
const diagnostic_75 = a75;
const diagnostic_76 = a76;
const diagnostic_77 = a77;
const diagnostic_78 = a78;
const diagnostic_79 = a79;
const diagnostic_80 = a80;
const diagnostic_81 = a81;
const diagnostic_82 = a82;
const diagnostic_83 = a83;
const diagnostic_84 = a84;
const diagnostic_85 = a85;
const diagnostic_86 = a86;
const diagnostic_87 = a87;
const diagnostic_88 = a88;
const diagnostic_89 = a89;
const diagnostic_90 = a90;
const diagnostic_91 = a91;
const diagnostic_92 = a92;
const diagnostic_93 = a93;
const diagnostic_94 = a94;
const diagnostic_95 = a95;
const diagnostic_96 = a96;
const diagnostic_97 = a97;
const diagnostic_98 = a98;
const diagnostic_99 = a99;
const diagnostic_100 = a100;
const diagnostic_101 = a101;
const diagnostic_102 = a102;
const diagnostic_103 = a103;

I doubt this is the cause of the performance issue, but it is definitely not helping. I wonder how much the cache actually helps at all, as far as I can tell the formatting is not expensive so far.

I looked into it a bit more, the cache does help a lot:
[3:41:59 PM] Diagnostics took 1254ms
[3:42:06 PM] Diagnostics took 736ms
[3:42:13 PM] Diagnostics took 315ms
[3:42:20 PM] Diagnostics took 0ms
[3:42:22 PM] Diagnostics took 0ms
[3:42:28 PM] Diagnostics took 1ms
[3:42:30 PM] Diagnostics took 2ms
[3:42:34 PM] Diagnostics took 198ms
[3:42:44 PM] Diagnostics took 188ms
[3:42:53 PM] Diagnostics took 254ms
[3:42:54 PM] Diagnostics took 190ms
[3:42:34 PM] Diagnostics took 198ms
[3:42:44 PM] Diagnostics took 188ms
[3:42:53 PM] Diagnostics took 254ms
[3:42:54 PM] Diagnostics took 190ms
[3:51:35 PM] Diagnostics took 220ms
[3:51:39 PM] Diagnostics took 227ms
[3:51:46 PM] Diagnostics took 161ms
[3:51:57 PM] Diagnostics took 220ms
[3:52:00 PM] Diagnostics took 29ms
[3:52:03 PM] Diagnostics took 1ms

The 2 initial logs are during startup.  When the cache is hit it takes almost no time. If all items get a miss the time it takes will be noticeable.

File used:

const diagnostic_1: 1 = 2
const diagnostic_2: 2 = 3
const diagnostic_3: 3 = 4
const diagnostic_4: 4 = 5
const diagnostic_5: 5 = 6
const diagnostic_6: 6 = 7
const diagnostic_7: 7 = 8
const diagnostic_8: 8 = 9
const diagnostic_9: 9 = 10
const diagnostic_10: 10 = 11
const diagnostic_11: 11 = 12
const diagnostic_12: 12 = 13
const diagnostic_13: 13 = 14
const diagnostic_14: 14 = 15
const diagnostic_15: 15 = 16
const diagnostic_16: 16 = 17
const diagnostic_17: 17 = 18
const diagnostic_18: 18 = 19
const diagnostic_19: 19 = 20
const diagnostic_20: 20 = 21
const diagnostic_21: 21 = 22
const diagnostic_22: 22 = 23
const diagnostic_23: 23 = 24
const diagnostic_24: 24 = 25
const diagnostic_25: 25 = 26
const diagnostic_26: 26 = 27
const diagnostic_27: 27 = 28
const diagnostic_28: 28 = 29
const diagnostic_29: 29 = 30
const diagnostic_30: 30 = 31
const diagnostic_31: 31 = 32
const diagnostic_32: 32 = 33
const diagnostic_33: 33 = 34
const diagnostic_34: 34 = 35
const diagnostic_35: 35 = 36
const diagnostic_36: 36 = 37
const diagnostic_37: 37 = 38
const diagnostic_38: 38 = 39
const diagnostic_39: 39 = 40
const diagnostic_40: 40 = 41
const diagnostic_41: 41 = 42
const diagnostic_42: 42 = 43
const diagnostic_43: 43 = 44
const diagnostic_44: 44 = 45
const diagnostic_45: 45 = 46
const diagnostic_46: 46 = 47
const diagnostic_47: 47 = 48
const diagnostic_48: 48 = 49
const diagnostic_49: 49 = 50
const diagnostic_50: 50 = 51
const diagnostic_51: 51 = 52
const diagnostic_52: 52 = 53
const diagnostic_53: 53 = 54
const diagnostic_54: 54 = 55
const diagnostic_55: 55 = 56
const diagnostic_56: 56 = 57
const diagnostic_57: 57 = 58
const diagnostic_58: 58 = 59
const diagnostic_59: 59 = 60
const diagnostic_60: 60 = 61
const diagnostic_61: 61 = 62
const diagnostic_62: 62 = 63
const diagnostic_63: 63 = 64
const diagnostic_64: 64 = 65
const diagnostic_65: 65 = 66
const diagnostic_66: 66 = 67
const diagnostic_67: 67 = 68
const diagnostic_68: 68 = 69
const diagnostic_69: 69 = 70
const diagnostic_70: 70 = 71
const diagnostic_71: 71 = 72
const diagnostic_72: 72 = 73
const diagnostic_73: 73 = 74
const diagnostic_74: 74 = 75
const diagnostic_75: 75 = 76
const diagnostic_76: 76 = 77
const diagnostic_77: 77 = 78
const diagnostic_78: 78 = 79
const diagnostic_79: 79 = 80
const diagnostic_80: 80 = 81
const diagnostic_81: 81 = 82
const diagnostic_82: 82 = 83
const diagnostic_83: 83 = 84
const diagnostic_84: 84 = 85
const diagnostic_85: 85 = 86
const diagnostic_86: 86 = 87
const diagnostic_87: 87 = 88
const diagnostic_88: 88 = 89
const diagnostic_89: 89 = 90
const diagnostic_90: 90 = 91
const diagnostic_91: 91 = 92
const diagnostic_92: 92 = 93
const diagnostic_93: 93 = 94
const diagnostic_94: 94 = 95
const diagnostic_95: 95 = 96
const diagnostic_96: 96 = 97
const diagnostic_97: 97 = 98
const diagnostic_98: 98 = 99
const diagnostic_99: 99 = 100
const diagnostic_100: 100 = 101
const diagnostic_101: 100 = 102

Do you think we need to make the cache bigger? or change how it's working?

@yoavbls I think it needs to be changed to be smarter about cache hits and misses. Although we could also just increase the cache size and see if people with performance issues notice a change.
onDidChangeDiagnostics seems to fire at least twice on a single change, and even more often when renaming files or symbols. Simple tests with 4 files a rename could trigger 5-10 events with seemingly the same diagnostics. I have no idea why that happens. I can't find any issue on github or StackOverflow that reports having issues with that.
If the order of uri.forEach and diagnostic.forEach are the same for each of those events and the total size of those diagnostics exceeds the cache size, all of those events will perform as if there is no cache. for 5-10 events of 100+ diagnostics that could easily add up to a few seconds of total time.
But if and how the amount of diagnostics exceeds the cache size is not clear to me, it seems odd to have a project where you have  100+ diagnostics from the typescript compiler.


Added journeytolunar.com

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the Cloudflare report
[x] This site is not an ultra minimal site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: journeytolunar.com
  url: https://journeytolunar.com/
  size: 308.85
  last_checked: 2024-09-04

Cloudflare Report:
https://radar.cloudflare.com/scan/eff697e5-73de-4851-958f-5e4872d4e7f1/summary

Thanks!


Auto-indent with loading new question

💬 Questions and Help
I'm not understanding where to configure or change the default behavior currently where loading a new question in vscode uses 4 spaces for auto-indenting. Is that configurable somewhere? When I create my own new file in my workspace it uses my settings for 2 spaces which is what I want to use when working on an lc question in my editor.

definitely need this too


Parsing blog.jh Error

I am following the 12 minute tutorial video and seem to be missing some key concept...
When I try to import the blog.jh file into JDL-Studio, I get the following error:
Expected "/*", "angularSuffix", "dto", "entity", "enum", "microservice", "noFluentMethod", "paginate", "relationship", "search", "service", "skipClient", "skipServer", ['\n'|'\t'|'\r'|' '|
|
], [A-Z_], or end of input but "<" found. -> line: 1
I am new to JDL-Studio, so I expect this is a simple issue?
Thanks

I was trying to grab the file straight from Git, downloading and referencing the .jh from hard disk solved this.


ext_authz config per virtual host

Description:
Need to apply ext_authz filter to only specific virtual hosts. Currently it applies to the whole ingress.
I currently have it as this:
kind: EnvoyFilter
metadata:
  name: authn-filter
  namespace: istio-system
spec:
  workloadSelector:
    labels:
      istio: ingressgateway
  configPatches:
  - applyTo: HTTP_FILTER
    match:
      context: GATEWAY
      listener:
        filterChain:
          filter:
            name: "envoy.http_connection_manager"
            subFilter:
              name: "envoy.router"
    patch:
      operation: INSERT_BEFORE
      value:
        name: envoy.ext_authz
        config:
          http_service:
            server_uri:
              uri: http://authservice.istio-system.svc.cluster.local
              cluster: outbound|8080||authservice.istio-system.svc.cluster.local
              failure_mode_allow: false
              timeout: 10s
            authorization_request:
              allowed_headers:
                patterns:
                - exact: "cookie"
                - exact: "X-Auth-Token"
            authorization_response:
              allowed_upstream_headers:
                patterns:
                - exact: "kubeflow-userid"
          status_on_error:
            code: GatewayTimeout

The problem is that it applies to all virtual hosts under the same ingress. I want to only apply it to specific virtual hosts. Currently I'm excluding some hosts using the following:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: bypass-auth-filter
  namespace: istio-system
spec:
  workloadSelector:
    labels:
      istio: ingressgateway
  configPatches:
  - applyTo: VIRTUAL_HOST
    match:
      routeConfiguration:
        vhost:
          name: a.example.com:80
    patch:
        operation: MERGE
        value:
          per_filter_config:
            envoy.ext_authz:
              disabled: true

However, I would like if I can do it such that I apply the filter on specific virtual hosts rather than having to exclude every hosts that doesn't need auth (more like a whitelist solution rather than a blacklist)
Thus would be great if when defining the ext_authz filter, I can specify which virtual hosts it applies to.

cc @yangminzhu we discussed something like this

cc. @fpliu233


Support CNG certificates

Description
Anything below .Net 4.61 does not have the ability to deal with CNG certificates correctly. This means powershell does not have the ability either. Places with strict security set this to default, so when the cert is created and added it will default to CNG. When trying to set permissions on certificate, powershell can't access private key so it can't set permissions.

When installing a certificate, can now choose to use PFX default provider or override with CNG provider, so you not at the mercy of AD policies
Can read private key of CNG certificates, which allows ACL permissions on private key to be set.
The rewrite of applying ACL permissions will allow things like acl_delete, so ACL permissions can be turned into its own resource.

Issues Resolved
#481
Check List
README has been updated to include new features
Works on my machine badge. But I haven't run all the tests. Hoping for pull request to flesh out any issues.

as I see def cert_script(persist) implementation doesn't changed, and it deletes private key on second run.

We're in the process of converting the certificate resources to use the win32-certstore gem, which will allow us to add a lot of the functionality here without having to get crazy complex in the resources themselves. That first bit of work landed in #558. Take a look and please let us know if there's anything you need that we can add.


Tabstop is being reset

Hi,
I set my tabstop to 4 explicitly in my ~/.vimrc and it works as expected in JS or C++ file BUT if I open python files the tabstop is 8 spaces
Why so?
P.S. See my .vimrc in my gists #

Google python vim indent. First result: https://wiki.python.org/moin/Vim

@s-c-p I'm not sure if tabstop being changed to 8 is the problem but this plugin fixed the indentation of multi-line lists and dictionaries for me: https://github.com/Vimjas/vim-python-pep8-indent


Workflow roles should be able to be Admin Set-specific

The wording here is vague, I admit. We should talk about this soon, @scholarworks @vantuyls @cam156  @hannahfrost. The general use case is that larger installations (such as we will have at Stanford), we will want to use the one-step-mediated-deposit workflow across a bunch of Admin Sets, but we do not want workflow roles shared between Admin Sets. Let's talk first about whether this is a shared need, and then loop in @jcoyne and @jeremyf to talk about implementation ideas.

@mjgiarlo I wonder in @acoburn's work with IDs vs names would solve this.

@acoburn sorry wrong auto correct for @acollier.

@cam156 This work by @scholarworks may be a part of this solution, but before diving into figuring out the right implementation I'd like to verify this is a shared use case.

@mjgiarlo @cam156 - This is quite true. If I have workflows assigned for one admin set and a user that is allowed to submit there, it is likely that they are not allowed to submit to any other (or at least some) admin sets. So the segregation of workflow and admin_set isn't sufficient for those use cases.

@mjgiarlo @vantuyls @cam156 @hannahfrost
As it is currently constructed, there is table for Sipity::Role. These are defined for the entire "site". However, for a Role to be available for a Workflow, there must be an entry in Sipity::WorkflowRole.
People are assigned (via Sipity::WorkflowResponsibility] to the workflow (or to a specific entity in the workflow via Sipity::EntitySpecificWorkflow).
So I believe, the Sipity::Workflow implementation delivers on your requirement.

I think the existing back end could work, I think it's the front end that needs help.  We'd need to switch to using a separate workflow for each admin set, with each workflow having the same states-actions, but with different WorkflowResponsibilities.

Thanks, all.

@mjgiarlo @jcoyne Are more/different tickets needed for this work?

@hannahfrost I wonder if @jcoyne's last comment implies we need to make this "design needed." Also tagging @ggeisler so this is on his radar.

Based on what I see related to workflows in the current code and what we've already done with admin sets, I agree we need some additional consideration of how things interact. Is there some existing documentation with use cases or other concrete description of typical workflows and what steps and roles might be involved? From a UX point of view I'm not really interested in the code underlying things, just need to better understand the details of workflows in a realistic context.

Below are proposed updates that I hope address the goals mentioned in the discussion above. The updates are pretty minor but given we've agreed (on Slack) that it makes sense for the UI to only support a couple of the most basic workflows in the near term, I think this might be a viable approach. That said, I feel slightly in the dark about workflows so I'm happy to iterate on this if I'm missing something.

Remove the Workflows heading from the Configuration section of the Admin sidebar, and remove the associated Roles page. The Configuration > Review page is still viable, but see https://github.com/projecthydra-labs/hyku/issues/634 for the suggestion that it be moved to the Tasks section of the admin sidebar.

Add a Reviewers section to the Participants tab of the Admin Set page. Below is the original mockup with the section that needs to be added outlined in red. The current Participants page implements most of the mockup, just not the Reviewers section.

Add the Reviewer role to the "Select a role..." select menus at the top of the Participants page.

For extra credit (since it's not related to the main goal of this ticket), it would be great to add a conditional for the tables within each Managers, Reviewers, etc. section such that:

If at least one user or group has been added to a section, the table is displayed as in the mockup (and as in the current code)
If there are no users or groups added to a section, instead of the displaying the table, display the text:

No reviewers have been added to this administrative set.

where "reviewers" is obviously the appropriate role for that section. That way in the zero users/groups case we don't show just a table heading with no table content, as we currently do.

Something that occurred to me after posting my previous comment: If an admin set is configured to use a workflow that doesn't require a review step (e.g. the current default workflow), should we still be able to add Reviewers, and do they still have reviewer privileges (remove files from the work, etc.)?
I assume the answer is yes, but if so, we might want to change the wording under the Reviewers section heading to something less workflow-specific, such as:

Reviewers can approve or reject works submitted to this set, edit work metadata, and add to or remove files from a work.

@ggeisler :speech_balloon:

If an admin set is configured to use a workflow that doesn't require a review step (e.g. the current default workflow), should we still be able to add Reviewers, and do they still have reviewer privileges (remove files from the work, etc.)?

Good question. I'm not sure we should, given that Hyrax doesn't have a well-defined role for reviewers outside of the workflow context. For now, until we have time to consider adding a new Hyrax role, I'm inclined to say that if an AS is configured with a workflow that lacks the approving role, the Participants tab should not allow adding Reviewers. (We can still display that block in the UI, with a helpful message about Reviewers not being available with the default (0-step) workflow.)
Tagging @jcoyne, @atz, and @hannahfrost for their thoughts on this too.

@ggeisler Thanks for mocking this up. It looks good to me.  I also agree with @mjgiarlo supposition: it should not be possible to add reviewers if the review workflow has not configured for this admin set.

Okay, @hannahfrost and @mjgiarlo, sounds fine to me. In that case, we can still use the text under the Reviewers section heading in the mockup above for the case when the selected workflow does include a review step.
When the selected workflow does not include a review step, I suggest we show the Reviewers section heading and below it use this text (or something similar) instead of what's in the mockup:

To add reviewers, you must configure this administrative set to use a workflow that includes a review step.

Also, if the configured workflow does not include a review step, the Reviewer role should not be included in the two "Select a role..." select menus at the top of the page.
What happens in this scenario: a review workflow is configured, reviewers are added, and then the workflow is changed to a non-review workflow? Are we okay with just removing any existing reviewers from the Participants page? That might be okay if we assume that people rarely enter more than a few reviewers per admin set. Otherwise, we might want to display a confirmation dialog if the user tries to switch from a review workflow to a non-review workflow ("Any reviewers currently assigned to this administrative will be removed").

@ggeisler 💬

What happens in this scenario: a review workflow is configured, reviewers are added, and then the workflow is changed to a non-review workflow? Are we okay with just removing any existing reviewers from the Participants page? That might be okay if we assume that people rarely enter more than a few reviewers per admin set. Otherwise, we might want to display a confirmation dialog if the user tries to switch from a review workflow to a non-review workflow ("Any reviewers currently assigned to this administrative will be removed").

⬆  @hannahfrost @vantuyls @scholarworks @jeremyf @jcoyne ❓

@ggeisler @mjgiarlo +1 to a confirmation dialog.
I also see this as a good opportunity to kick off a notification ("You have been removed as a reviewer on the Foo collection")

That notification could probably also use a "... because the Foo collection no longer uses a workflow with a review step" clause, so that the recipient doesn't think they've been demoted from some unknown (to them) reason.

:+1:
I will make a ticket for notifications related to user role changes (to be worked on another day).

Let's talk with @jeremyf to make this actionable.

The Current Participants page is a great idea. There are some caveats.
The Current Participants should render a list of all Roles assigned to that Workflow. Then, for each Role, list the associated Person or Group. It then sounds like we need a description for each of those roles; The description could be in the Sipity::WorkflowRole (as it may be the most indicative of the intention of that role).
I suppose it could be a translation, but my experience is that translations based on database entries are going to get frustrating (unless we adopt a DB backend-layer for translations as well).

@jeremyf For now, I believe the group's sense is that the current participants page does not need to change since two of its three roles (depositor, reviewer) map quite neatly to the two roles the current JSON workflow templates define (depositing, approving). The work that needs to be done, though I defer to your Sipity wisdom here, is making sure to treat the JSON files as templates, creating new workflow instances based on the templates for every Admin Set so that roles new not slop over from AS workflow to AS workflow. Perhaps there's a better way to implement this, though. Might you have cycles to help us clarify an approach for this ticket? Or, better yet, to work on this ticket? :)
Cc: @jcoyne

@mjgiarlo I'm reviewing my calendar now.

@jeremyf:

The Current Participants should render a list of all Roles assigned to that Workflow. Then, for each Role, list the associated Person or Group. It then sounds like we need a description for each of those roles

Putting aside the technical details necessary to make it happen, I just want to say that I think the UI mockup or so up is consistent with this. The mockup is based on the assumption we made that in the near-term we're only considering a zero-step workflow or a one-step workflow with only the Reviewer role. So the Reviewer section is added as in the mockup above because this is a one-step workflow with a reviewer role. If instead this was, say, an admin set configured with a two-step workflow with a reviewer and a "metadata approver," then I'd assume we'd show an additional section titled "Metadata Approver," similar to the other sections.
I'm only thinking about the UI so I might be missing something, but from my perspective the UI approach on the Current Participants page is compatible with @jeremyf's comment, just that for now we're limiting our concern to zero- and one-step workflows (and adding a "Managers" section that will be on the Participants page for every Admin Set, independent of the workflow configured).

The problem we need to solve is that workflow_responsibilites need to be per admin set.
One way to accomplish this is to add a relationship from sipity_workflows to admin_set_id.  Thus workflows are not shared between admin sets.
This means that each admin set has many workflows that are selectable, and it has one active workflow.
We would need to break the 1-1 relationship between templates (json files) and workflows (in the db), and load all the templates (when a new admin set is created).
Technically the 0-step workflow could be shared among all admin sets, because it has no roles.  But we don't feel good about this as it's a special case.
Alternatively, we could add join tables on workflow_responsibility to admin_set and a join for workflows to admin_set.

@jcoyne @mjgiarlo When we say AdminSet has_many…that starts crossing odd boundaries. AdminSet is ActiveFedora::Base and Workflows are ActiveRecord::Base.
Do we mean PermissionTemplate has many workflows? I'm asking because we have this item: https://github.com/projecthydra-labs/hyrax/blob/5649762ca9bcd9cb429aaf49f04ec8d280e9a979/app/forms/hyrax/forms/permission_template_form.rb#L47-L49
Also, should there be valiadation between AdminSet and PermissionTemplate? All of this is to say "Aside from two different persistence layers, I don't have a solid grasp of the separation of AdminSet and PermissionTemplate"

@jeremyf The has_many could be conceptual, not necessarily any specific function call.
PermissionTemplate has one active workflow, and many available options to choose from.  The latter is returned by PermissionTemplateForm#workflows
@jeremyf  I'd say the PermissionTemplate is still being worked out a bit.  It's a 1-1 relationship with AdminSet, but it holds behavior related (as opposed to model related) attributes.

@jcoyne Would it be fair to say that a PermissionTemplate has_many workflows as per the Rails ActiveRelation concept? This is a extension (and perhaps stretch) of the idea that the PermissionTemplate holds behavior for an AdminSet.
Thinking through the impact:

AdminSets could have their permission template obliterated, which would mean we lose any concept of what workflows existed.
When an AdminSet is created, do we immediately create a permission template?

@jeremyf I think you correctly understand the cardinality of the PermissionTemplate-Workflow relationship.  I don't understand the need for an AdminSet#workflows method.  I think admin_set.permission_template.workflows is sufficient.

AdminSets could have their permission template obliterated, which would mean we lose any concept of what workflows existed.

Yes, but if the permission template is obliterated, it's likely the workflow is also obliterated. (both live in the database).  Furthermore, In this scenario, we have the correct info in Fedora to preserve the existing data.  (we just don't know the rules for adding new things to the admin set)

When an AdminSet is created, do we immediately create a permission template?

Yes

There are changes in #305 that will be impactful on this commit. I'm bumping up against not wanting to make changes in similar places (and thus force a nasty rebase/diff activity).

I believe this also builds on PR #363

Ongoing work though I discovered when I rebase the following in Sipity::Workflow:
<<<<<<< HEAD
    has_many :permission_templates, dependent: :restrict_with_exception, class_name: 'Hyrax::PermissionTemplate'
=======
    belongs_to :permission_template, class_name: 'Hyrax::PermissionTemplate'
>>>>>>> Adding PermissionTemplate.has_many :workflows

Based on this issue (and conversation with @jcoyne) I believe belongs_to :permission_template,… is the correct relationship.

I strongly encourage that Sipity::Roles are names that are applicable across admin sets (e.g. manager). It the groups/users assigned to those roles for the workflow that vary


Cannot add a anon struct in structs from the design view

 Issue by dilinisg
Saturday Nov 04, 2017 at 05:15 GMT
Originally opened as https://github.com/ballerina-lang/composer/issues/4421

Add a struct
Try to add the following from the design view
struct {int d; int b;}test;

Issue
Cannot add a anon struct in structs from the design view

 Comment by keizer619
Tuesday Nov 21, 2017 at 09:12 GMT

We need to do a complete revamp in the struct view to support this as in following task
https://github.com/ballerinalang/composer/issues/4287

Implementation has differed we no longer show the struct diagram.


TryConvertOwned is private; how to implement TryConvert for custom Rust structs containing collections?

Given the following Rust structs:
use magnus::{prelude::*, Error, TryConvert};

struct Topic {
  title: String,
  posts: Vec<Post>,
}

struct Post {
  body: String,
  author_id: usize,
}

impl TryConvert for Post {
    fn try_convert(val: magnus::Value) -> Result<Self, Error> {
        val.respond_to("body", false)?;
        val.respond_to("author_id", false)?;

        let body = val.funcall("body", ())?;
        let author_id = val.funcall("author_id", ())?;
        Ok(Post{body, author_id})
    }
}

impl TryConvert for Topic {
    fn try_convert(val: magnus::Value) -> Result<Self, Error> {
        val.respond_to("title", false)?;
        val.respond_to("posts", false)?;

        let title : String = val.funcall("title", ())?;
        let posts : Vec<Post> = val.funcall("posts", ())?; # <- Compiler complains here
        Ok(Title{title, posts})
    }
}

it is possible to implement TryConvert for Post as seen above.
But impossible to implement it for Topic, as Vec<Post> only implements it if Post implements TryConvertOwned, resulting in a compiler error.
However, that trait is private within Magnus (to be precise, the try_convert module which contains it is private).
Should this trait maybe be made public?
Or am I 'holding it wrong'?

This was an oversight on my part.
I've pushed a change to the 0.5 current release branch that makes try_convert public, you should be able to use that via a git dependency. I will do a release with this change, but I'm currently on holiday and my time is otherwise occupied, so it might take a week or so until I can do that.

I've put out a 0.5.4 release with the fix for this.
I also (as I missed saying it in my last message) wanted to say thank you for reporting this issue, and thank you for the nice clear example, it really helped.


Allow alternate response code

Allows resources to return a 202 instead of 201 or 200. Useful for when a save is delayed.
Fixes #234

Looks good but I'd prefer to return nil implicitly instead of :default explicitly. We don't want :default to be confused with a valid status code.

Reworked this to allow the resource methods to be either :completed or :deferred, and then the Operation determines the response code. It's more limiting, but the resource shouldn't know about response codes.
The model now no longer needs to implement save if it's not an Active Record model. The resource now checks if the save method is defined before attempting to call it.
During the rework it became obvious that if there are callbacks on the model that cancel the save we weren't accounting for that. It now raises an exception. But I'm not sure I like the flow if a callback cancels the save. It seems that shouldn't make it out as an error in the response, but I'm not sure how we should handle it. There isn't a good way that I see to pass any additional data back from the callback in the model. So right now it returns back an error with a non configurable message.
Any better ideas?

For future reference as this doesn't seem to be documented:
https://github.com/cerebris/jsonapi-resources/blob/7ebba9b096c4d84d351b9c18af2971a36b97129d/lib/jsonapi/resource.rb#L182...L194


cmd/go: conversion from legacy dependency managers puts replacement module path in require section

What version of Go are you using (go version)?

$ go version
go version go1.12.6 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/liuchang/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/liuchang/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build510154135=/tmp/go-build -gno-record-gcc-switches"

What did you do?

run go mod init with a dep project that contains source config.
What did you expect to see?
go.mod should put module's old path in require section.
What did you see instead?
go.mod put module's new path in require section.

@liuchang0812, is this still an issue?

Never mind, spotted an issue in src/cmd/go/testdata/script/mod_init_dep.txt that reproduces it.

CC @jayconrod @oiooj

@bcmills I added a test case in src/cmd/go/internal/modconv/convert_test.go, see https://github.com/golang/go/pull/33343

@liuchang0812, I don't think we even need a new test case. We need to fix the existing mod_init_dep test case as described in CL 126915.

This is no longer needed due to #53327.


Trimmed Wood Blocks

Trimmed Wood Planks
Add trimmed wood planks for each wood type[^1].

Oak
Spruce
Birch
Jungle
Acacia
Dark Oak
Crimson
Warped

[^1]: Trimmed Planks

Added Trimmed Planks for:

Oak
Spruce
Birch
Jungle
Acacia
Dark Oak

Commit: 991ae532f2bb095883c7d043afe7f63b98cb5e06


Make toSQL().toNative() work for Raw to match the API for QueryBuilder

Resolves #3628

Implementation looks good, but it is missing regression test.

And thanks for adding this, it has been a bit painful of not being able to do that with knex.raw 😅

@lorefnon Do you need any help with this?

@elhigu I've added tests for other dialects, but they still seem to return exact same values?.. Is this to be expected?..

@lorefnon @elhigu I've updated tests to use actual dialect-specific clients, now there is a difference. Could you please check if output is what it should be now?


Formatting tags doesnt work

Hello , i m using this library to a project that print some ticket , the printing fucntion is working fine but when i use formatting tags its doesn't work , always print the text in left side of the paper , i check the print specification like printerWidthMM , printerDpi ,the printer's model is SUNMI V1 T2 NT-1880 , please , i hope get  some help as soon view this message , thank you .

Hi, have you got solution for Formatting tags, I am facing same. Hope to get some help

Any update on this??


<area> vs <img usemap> location in tabbing sequence

Issue with dom/query-tabsequence
While Blink and WebKit add <area> elements to the tabbing sequence where they occur in the DOM, Firefox and IE do not. Gecko and Trident remove <area> from the sequence and inject them (possibly multiple times) for every <img usemap> referencing the <map> those <area>s are defined in.
Trident will redirect focus from <img usemap> to the first <area> of the referenced <map>. Firefox does not do this. At this point UA-sniffing seems like the only way to distinguish behavior.

Blink is going to go with the order Gecko and Trident have, leaving WebKit as the odd-man-out for now.


Add Zone ID

This is for #1037.
I think the plan is:

land this
get https://github.com/ngld/OverlayPlugin/pull/138 merged
wait for OverlayPlugin release
switch to using the new event type
add code in raidboss/oopsy to support zoneId
add documentation
switch raidboss/oopsy over to using zoneId
switch various other bits of code using zone names (e.g. lang)
remove use of zoneRegex from cactbot files (but don't remove support)

Any other opinions? Does this name shortening scheme seem reasonable?

Are those Heaven On High instances actually the ten sets of floors plus the roof, as it looks? If so, it might be worth supporting those just because combat can occur there? I guess the same would go for the Diadem, but that's close enough to open-world content that it's probably unnecessary.
On the StartRegexes for fights.js, is there a reason those haven't been updated to use 15/16 log lines rather than the game lines they're currently using? (Or is it "that's where it was and gathering the data isn't always easy"? It also took me a moment to remember why Kefka is special-cased.)
Other than that, I'm happy with the direction chosen here. I think this will be a good step forward for reducing translation burdens.


[$1000] Add translations for State & Country Pickers

Problem
In https://github.com/Expensify/App/pull/14290, we created a CountryPicker component that gives the user the option to select many different countries as their home address. This is useful, but if a user prefers to use the app in Spanish (or any other language in the future), we need to make sure to show full address names in that language.
Similarly, the StatePicker we have does not get translated in to Spanish at the moment and it needs to be.
Solution
Update both components to be able to display state / country names in different languages
As agreed upon in this thread, probably the best solution is to put translations in our language files (en.js and es.js) similar to how we have different pronouns lists in those files
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b4c798f34b03ef03
Upwork Job ID:<PHONE_NUMBER>333895168
Last Price Increase: 2023-02-08

Still on hold

Job added to Upwork: https://www.upwork.com/jobs/~01b4c798f34b03ef03

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new.

@Santhosh-Sellavel thoughts on the proposal?

Thanks for the bump, sound's good.
Questions to @puneetlath or @Beamanator

Are we fine with this, are we using states anywhere else?

we could shift the States array from expensify-common to the Expensify/App repo and the respective locale files. I do not understand why it was originally kept in a separate library.

Why do we define only states in the e-common repo shouldn't we define the Countries List also?

@Prince-Mendiratta
Shouldn't we use the country code also for countries as we do for states?
Can you share implementation detail in a high-level or pseudo code?
We are not only picking countries via picker, we also allow searching using google to autocomplete in that case suggestions may still show country and state names in English. How are we planning to address that?

I'm not sure if I understood this completely, country codes are language independent standard and we are currently using country code for phone numbers.

I'm referring to ISO country codes.

@Santhosh-Sellavel I'm afraid I'm still do not understand the requirement, can you please point me to a place where the country codes are used and would need localisation?

First of all this is not a requirement. Since we already ISO codes for the states why not use ISO codes for countries too?
cc: @Beamanator @puneetlath

@Beamanator @puneetlath bump on this questions

@Prince-Mendiratta

We are already doing this, in the AddressSearch, we pass the language: props.preferredLocale to the component and the Google places API automatically returns the results in the locale specific format. More details here.

That's good, is translations working?

To test it out, I tried the different locales and here are the results

Can you share a video of testing performing the following.

Set language to es.
Go to Profile -> Personal Details -> Address
Pick a country from the picker which show translated list
Now use Address Search to find a address some

Does the value is translated i.e both in options & after selecting the values?

@Santhosh-Sellavel can you clarify:

Are we fine with this, are we using states anywhere else?

Are we fine with what? And yes we're using the state picker in the address search component, probably the address form component too - I think this only is used in two or three places right now but we'll probably add it to more in the not so distant future

Why do we define only states in the e-common repo shouldn't we define the Countries List also?

I see how that looks a bit weird - we define states there because we also use that list in our old website code (OldDot - expensify.com). I don't think we need to add the list of countries to the e-common repo since we don't currently need to use those countries in OldDot.

Since we already ISO codes for the states why not use ISO codes for countries too?

Good question, I might need to do a bit of digging to determine why we need the ISO codes for states - but as far as I know right now we don't care about ISO codes for countries so I'm 🤷 about adding them if we don't need them. @puneetlath do you happen to know what role ISO codes play for states? A.k.a. why we need them? 😅  I can do some digging starting Wednesday, but today & tomorrow I have very limited working hours sorry

Side note @Santhosh-Sellavel : Do you think it makes sense for the proposal here to also try to fix https://github.com/Expensify/App/issues/15014?

we could shift the States array from expensify-common to the Expensify/App repo and the respective locale files. I do not understand why it was originally kept in a separate library.

Are we fine with above , are we using states anywhere else?
I guess not because we still use it as per answer of question 2 here

Side note @Santhosh-Sellavel : Do you think it makes sense for the proposal here to also try to fix https://github.com/Expensify/App/issues/15014?

Definitely yes!

@Santhosh-Sellavel

Are we fine with above , are we using states anywhere else? I guess not because we still use it as per answer of question 2 https://github.com/Expensify/App/issues/14549#issuecomment-1428344084

Exactly - we cannot move the states const to App at the moment because we're using the same list in our OldDot website code.

I can notice that country is not set straight away in the above, which is working now!

Since we already ISO codes for the states why not use ISO codes for countries too?

Good question, I might need to do a bit of digging to determine why we need the ISO codes for states - but as far as I know right now we don't care about ISO codes for countries so I'm 🤷 about adding them if we don't need them. @puneetlath do you happen to know what role ISO codes play for states? A.k.a. why we need them? 😅 I can do some digging starting Wednesday, but today & tomorrow I have very limited working hours sorry

Any thoughts @puneetlath

Tried to get some opinions in Slack here: https://expensify.slack.com/archives/C01GTK53T8Q/p1676895140727779

Ok @Santhosh-Sellavel looks like yes we do want to store country ISOs, and actually we probably want to be storing country ISOs in the database, even though I think currently the AddressPage doesn't work that way 😅 So it would be great if we could solve that here too, unless it expands the scope too much, then it can be a follow-up

Thanks for the follow. up. We should do it then, I believe it's well within the scope!

📣 @Prince-Mendiratta! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Ah they've updated the comments that's why I missed to review. @Prince-Mendiratta Please avoid updating the existing proposals, always submit a updated proposal in the new comment. This will keep  track clear history of proposal progress over the timeline. So Can you post it in a new comment, I'll look into it later today. Thanks!

Yes please, revert and submit the updated proposal in a new comment, thanks!

@Prince-Mendiratta Thanks for the detailed proposal, it looks good at a glance but would like to take some more time to review this one.
cc: @Beamanator

@Prince-Mendiratta Some comments about your proposal:

Thanks for the TL;DR summary to explain the multiple goals of your proposal 👍
Instead of COUNTRY_ISO: { countryISO: COUNTRY_ISO, countryName: COUNTRY_NAME }, what if we just have mappings like COUNTRY_ISO: COUNTRY_NAME? (ex: US: 'United States')

I know you're matching the current format of the states mapping, but I feel like this could be a bit cleaner, let me know what you think

Here, we will be passing the country ISO code from now on so we might have to update the backend to handle that accordingly.

I believe there won't be any backend changes needed, I think the current backend validation will handle these ISO codes just fine. Are you proposing we change something in the backend, or just "make sure it works"?

I've prepared the translated names for countries and states, will need help from someone to review it in the final PR.

Assuming we pick your proposal, you can ask for someone to review the translated names in #expensify-open-source 👍

Lastly, I'd request for this job to be done at a fixed price after factoring the timeline bonus since this will involve changes in the backend as well as reviews from people from the Spanish translation team and we want to ensure that no issues occur due to information mismatch.

Sorry but I'm not quite sure what you're asking here, what do you mean by "I'd request for this job to be done at a fixed price"?

Good find in that bug report! Have you reported it in Slack? If not, please do - and mention that you'll solve it in this issue

@Prince-Mendiratta
I agree with @Beamanator

Instead of COUNTRY_ISO: { countryISO: COUNTRY_ISO, countryName: COUNTRY_NAME }, what if we just have mappings like COUNTRY_ISO: COUNTRY_NAME? (ex: US: 'United States')

I know you're matching the current format of the states mapping, but I feel like this could be a bit cleaner, let me know what you think

Please share you thoughts

I've prepared the translated names for countries and states, will need help from someone to review it in the final PR.

The internal team will help with Spanish copy.

Lastly, I'd request for this job to be done at a fixed price after factoring the timeline bonus since this will involve changes in the backend as well as reviews from people from the Spanish translation team and we want to ensure that no issues occur due to information mismatch.

I think @Prince-Mendiratta requesting not to consider this PR for an efficiency bonus +50% or -50% penalty as they think this could be time-consuming, so just a flat job price. I agree with this as well.
Overall looks good to me. But I noticed a few bugs State picker is not enabled for USA sometimes
https://user-images.githubusercontent.com/85645967/221245906-dbedecbf-5ef3-42d7-84a1-99fec16e3713.mov

I think @Prince-Mendiratta requesting not to consider this PR for an efficiency bonus +50% or -50% penalty as they think this could be time-consuming, so just a flat job price. I agree with this as well.

This is interesting, I'm not aware we're allowing contributors to request "flat job price" - @puneetlath is this something we have a process for? I can see the reasoning, but I haven't dealt with this request before 😅

Responses to @Prince-Mendiratta :

what if we just have mappings like COUNTRY_ISO: COUNTRY_NAME?

I agree, these look much cleaner, I had this like them to match those in STATES. I am in support of use of this data structure, but makes me ask why was that structure chosen for STATES? Since we are working on this issue, might as well work on this thoroughly to have everything consistent. If there wasn't a specific reason why the original data structure was chosen for states, we might as implement this for both states and countries and make changes in the common repo and backend. What do you think?

I see what you mean that consistency is very nice - the slight annoying thing is that refactoring the state code will require updating a few private repos as well, which takes a decent amount of coordination (making sure nothing breaks while we update one repo, then the next, etc etc). So for now I'd say lets only write the country iso code as we like, then we can consider also refactoring the state code (though this will take some time as I mentioned, and I'd argue isn't the most valuable refactor for right now so it won't be prioritized for a while)

I believe there won't be any backend changes needed, I think the current backend validation will handle these ISO codes just fine. Are you proposing we change something in the backend, or just "make sure it works"?

I did try it out and it does work as expected, just wanted to ensure that we have a look once to make sure no changes are required as in the slack thread, it was mentioned that the country names are stored as ISO codes some kind of mapping might be involved and since we won't be sending the country names anymore, we should confirm that nothing breaks haha.

That definitely makes sense - I would say you're good to go 👍  And while testing your changes we should make sure to test even more flows that could be affected by this change.

@Santhosh-Sellavel I think we're good to hire @Prince-Mendiratta , the proposal seems like it's good to go & other details have been ironed out it seems - I'll go ahead and hire now, but let me know if you have other concerns 👍

📣 @Prince-Mendiratta You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

I think @Prince-Mendiratta requesting not to consider this PR for an efficiency bonus +50% or -50% penalty as they think this could be time-consuming, so just a flat job price. I agree with this as well.

I don't think we have ever done this before and I don't think we should do it here. But don't worry, if the delays are due to our side then you won't be penalized.

I think @Prince-Mendiratta requesting not to consider this PR for an efficiency bonus +50% or -50% penalty as they think this could be time-consuming, so just a flat job price. I agree with this as well.

I don't think we have ever done this before and I don't think we should do it here. But don't worry, if the delays are due to our side then you won't be penalized.

@puneetlath
After process changes we had done this one of the issues where I was C+ and I requested it there personally, it was for a feature request. This is more like one such case we are not doing something entirely new, but it's an improvement that has an impact and affects quite a few crucial flows I think additional testing time might be required here, so requesting again to reconsider this if there are any delays. We will be doing our best to wrap this up soon, thanks!
cc: @Beamanator

Yes, I think that's fine. As long as we keep moving forward with urgency, no need to worry about the penalty.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.81-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15507

If no regressions arise, payment will be issued on 2023-03-17. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Ooh yeah great question @Prince-Mendiratta - I think we would prefer showing alphabetically by country name instead of ISO code, great catch!

I think we would prefer showing alphabetically by country name instead of ISO code

Issue reported today: https://github.com/Expensify/App/issues/16060

@Prince-Mendiratta @Santhosh-Sellavel sent you hiring offers.

All paid. Thanks everyone!

@puneetlath Im the external reporter from here https://github.com/Expensify/App/issues/15014 .
Im not paid.

📣 @ashimsharma10! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: upwork.com/freelancers/~018a92cf13e1e88eed

@ashimsharma10 can you link me to the slack thread where you reported the issue?

@puneetlath Im a reporter from https://github.com/Expensify/App/issues/15014 . This problem got solved by this current thread.

Ok got it @ashimsharma10. Can you please apply to the Upwork job: https://www.upwork.com/jobs/~01b4c798f34b03ef03

@puneetlath Applied .

@puneetlath i think this is not eligible for reporting bonus as per https://github.com/Expensify/App/issues/15014#issuecomment-1481397175

My takeaway from this comment from @Beamanator is that it should be eligible: https://github.com/Expensify/App/issues/15014#issuecomment-1428336713
@Beamanator what do you think?

@puneetlath I also don't think this is eligible for reporting bonus, because I believe the fix for that other issue was pretty automatic when implementing the fix for this issue

@Beamanator  I guess there is no concrete rule on whether to pay or not. But, from a reporter's shoes, it doesn't matter if the issue gets fixed by the same thread or a different one.  Anyways, I'm happy that the bug got resolved.

Ok sorry for all the confusion on this one. Thanks for being a part of the community @ashimsharma10! We look forward to continuing to work with you 😄


Relative links are broken in the GitHub documentation

Hey, thank you for this library. I have just started using it and really like the API.
When clicking through the documentation on GitHub I found that clicking on almost any link results in a 404 due to the markdown extension .md not being used in the relative paths of the links.
It is not that big of an issue since the official docs don't have any broken links.

@ReasonableDeveloper thanks for bringing this to my attention, I'll look into it and see if adding .md will accommodate both the official docs and the raw github docs.

Looking more into this, even if we add .md to the relative paths, those specified paths are still absolute to the docs directory which is what docsify depends on and thus still wont work on github. Unfortunately, I dont think this is something we can easily solve 😞.


Update QCoro in ConanCenter

This has initially been contributing by someone else, I should ensure it's updated to Conan2 format and updated to latest release (also in future on releases).
https://github.com/conan-io/conan-center-index/tree/master/recipes/qcoro/all

@danvratil any progress on that? i saw i can't get it with conan, which was kinda sad - cause i wanted to try it.

Someone seems to be working on updating the package to conan2 format, which should also include the latest version: https://github.com/conan-io/conan-center-index/pull/18837
That's where my understanding of conan ends right now...


Remove GLM submodule

We don't make changes to GLM, so there's not much value to maintaining it as a submodule -  copying in the files for the latest release is easier.
This also removes the GLM docs, which are over 10MB by themselves!

Why not use git subtree to ease updating?

He may means docs are hudge? but still prefre subtree.

@lygstate yeah we also considered that - still undecided

Looks like circle just broke on this. Will see if creating a new PR with the same commits fixes it.


Toggle comments stopped working on .pine files

Type: Bug
Create text file ending in .pine for PineScript.
Enter some text.
Press Ctrl / to toggle comments on.
Expected: It adds // at the beginning of the line.
Actual: Nothing happens.
Toggling comments works on .json files and presumably others as well. But not .pine, even though it used to do.
Probably the old behaviour was to add // for file types that are not recognised and the new behaviour is to do nothing. The old way was better.
This behaviour is unchanged if I disbale all extensions.
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:07.651Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 x 2904)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.93GB (16.28GB free)

Process Argv
--crash-reporter-id ac0bf5b3-6d35-4980-8db9-03770624c4d3

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

pinescript
Jey
3.0.1

vscode-icons
vsc
12.4.0

material-theme
zhu
3.16.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30610678
2e4cg342:30602488
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
hideindicator:30785051
pythongtdpath:30769146
i26e3531:30792625
pythonnosm12tcf:30779713
pythonidxpt:30784022
pythonnoceb:30776495
e537b577:30795824
dsvsc013:30795093

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!

Thanks for the tip. As I mentioned, I disabled all extensions and still saw the issue. I ran extension bisect and still saw the issue.

As I mentioned, I disabled all extensions and still saw the issue. I ran extension bisect and still saw the issue.

Extensions provide information on how to comment a line for languages. To my understanding, VS Code doesn't know by default how to comment a line in PineScript.
You can try the following:

Run the command "Developer: Toggle Keyboard Shortcuts Troubleshooting" (you can, for example, run it from the Command Palette).
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.

Press exactly the keybinding you desire

Check what VS Code detects

If you are having trouble understanding the output, please feel free to paste here and we'll be happy to help ☺
You should see
2023-07-24 21:22:10.608 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: MetaLeft, keyCode: 91, key: Meta
2023-07-24 21:22:10.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: MetaLeft, keyCode: 57 ('Meta')
2023-07-24 21:22:10.608 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-07-24 21:22:10.664 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-07-24 21:22:10.664 [info] [KeybindingService]: | Resolving meta+/
2023-07-24 21:22:10.664 [info] [KeybindingService]: \ From 2 keybinding entries, matched editor.action.commentLine, when: editorTextFocus && !editorReadonly, source: built-in.
2023-07-24 21:22:10.665 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: Slash, keyCode: 191, key: /
2023-07-24 21:22:10.665 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: Slash, keyCode: 90 ('/')
2023-07-24 21:22:10.665 [info] [KeybindingService]: | Resolving meta+/
2023-07-24 21:22:10.665 [info] [KeybindingService]: \ From 2 keybinding entries, matched editor.action.commentLine, when: editorTextFocus && !editorReadonly, source: built-in.
2023-07-24 21:22:10.665 [info] [KeybindingService]: + Invoking command editor.action.commentLine.

From 1 keybinding entries, no when clauses matched the context.

It's either that you pressed ctrl+/ not with editor focused or you or some extension must've changed the when clause of the keybindings. Try focusing the editor (cursor blinking in the editor) and then press and see the output.

Oops. Is this better?
2023-07-27 15:49:33.499 [info] [KeybindingService]: | Resolving ctrl+/
2023-07-27 15:49:33.500 [info] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.commentLine, when: editorTextFocus && !editorReadonly, source: user.
2023-07-27 15:49:33.500 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: Slash, keyCode: 191, key: /
2023-07-27 15:49:33.500 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: Slash, keyCode: 90 ('/')
2023-07-27 15:49:33.500 [info] [KeybindingService]: | Resolving ctrl+/
2023-07-27 15:49:33.501 [info] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.commentLine, when: editorTextFocus && !editorReadonly, source: user.
2023-07-27 15:49:33.501 [info] [KeybindingService]: + Invoking command editor.action.commentLine.
2023-07-27 15:49:34.202 [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys.


Second request fails if the first request is GET with body and through the same connection

Description:
The second request sents a HTTP 400 bad request from the API GW when the first request is GET with the payload and through the same connection.
Suggested Labels:
Priority/High
Severity/Critical
Affected Product Version: APIM 1.9.0
Steps to reproduce:
Refer [1] under related issues in order to reproduce the issue.
Related Issues:
https://wso2.org/jira/browse/ESBJAVA-4668

Hi,
Please can you tell us when this issue will be fixed?
We have same issue with Kafka-REST that uses "GET with payload to get topic offset".
Thanks
Youcef HILEM

Hi @shefandarren , @yhilem
This issue is already fixed in never versions of APIM [1] (in 2.x series). Let us know if you have the same issue in later versions of the APIM
https://wso2.org/jira/browse/ESBJAVA-4716
Thanks,
Praminda


Feature/os chmod

Implement handling of os.chmod().
Closes #14

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

20 of 20 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
292

Relevant Lines:
292

💛  - Coveralls


MWPW-159381: Removes 'body' overrides from caas.css

Removes Removes 'body' overrides from CaaS CSS file '/deps/caas.css' used by the MIlo Card block.
Resolves: MWPW-159381
Test URLs:

Before: https://main--cc--adobecom.hlx.page/drafts/ochatham/firefly-april23
After: https://main--cc--adobecom.hlx.page/drafts/ochatham/firefly-april23?milolibs=MWPW-159381

hey @cmiqueo this leads to some issues and will need to be pulled out: https://github.com/adobecom/milo/pull/3139


SAA-864 Log key events - appinsights

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (85dab0d) 85.39% compared to head (033718d) 85.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #519      +/-   ##
============================================
+ Coverage     85.39%   85.43%   +0.03%
  Complexity     2406     2406
============================================
  Files           297      297
  Lines          8724     8747      +23
  Branches        554      554
============================================
+ Hits           7450     7473      +23
  Misses          993      993
  Partials        281      281

Files Changed
Coverage Δ

...esmanagementapi/service/ActivityScheduleService.kt
67.39% <100.00%> (+5.36%)
:arrow_up:

...activitiesmanagementapi/service/ActivityService.kt
77.39% <100.00%> (+0.60%)
:arrow_up:

...ivitiesmanagementapi/service/AllocationsService.kt
84.37% <100.00%> (+0.24%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superseded by saa-864 - CoC events


backupccl: allow for remapping backed up types to existing types

PR: https://github.com/cockroachdb/cockroach/pull/50349
From release notes:

RESTORE now remaps user-defined types within the backup to existing types in the cluster. [#50349][#50349] {% comment %}doc{% endcomment %}

I don't think any docs updates are needed. Closing.


Errors in the tests

I am not sure what changes were made to the tests to make them so poor, but I think it was @saarock  who introduced changes that led to the failures.

@saarock @angeldevildev @Parshuram-Singh

@saarock probably gay