Update guidance on implicit templates for Deploy Button

I re-ordered the explicit vs. implicit sections here and added guidance on not using implicit. I considered removing implicit completely, but felt like someone might choose to consider it knowing the drawbacks? Open to removing it completely though.

@leezen id personally prefer to remove because id be worried about documenting something that we know will exclude a set of users. but maybe im missing something?

@susanev Nope -- I think I was tending toward being conservative, but as I mentioned, pretty open to just ripping it out. Let me push that up.


Assorted linting fixes.

Proposed Changes

Remove ineffective assignments.
Never pass nil contexts ever.

/test pull-knative-operator-upgrade-tests

/retest

/test pull-knative-operator-upgrade-tests

/test pull-knative-operator-upgrade-tests

/test pull-knative-operator-upgrade-tests


Test ci

@MichalMalyska after this passes CI and I merge this, CI should be passing on main, so you should only need to fix things related to your PRs.

My black version was different which was causing the reformatting changes, fixed now! Thank you.


Unpin urllib3

This PR unpins urllib3 and effectively reverts #200. As per psf/requests#5067, requests now works with urlib3 v1.25.

Awesome, thanks a bunch! Will cut a new release with this momentarily.


Unable to create Confirm dialogue with in Confirm Dialogue

Confirm Dialogue is working fine. But I want to Create ask confirm dialogue after the 1st Confirm Dialogue.
Example:  $.confirm({
title: 'Test',
text: 'Are you sure, you want to delete this record?',
confirm: function () {
fnCheckExistance();
},
cancel: function () {
}
});
function fnCheckExistance()
{
//Here i want to get Confirmation Request... which is not firing....
$.confirm({
title: 'Test',
text: 'Final Check, you really want to delete this record?',
confirm: function () {
fnDelete();
},
cancel: function () {
}
});
}

This should have worked, try declaring the fnCheckExistance as global variable
window.fnCheckExistance = function(){ ..


Nedelec bases on prisms and tetrahedra

Hello,
I need to have a discussion about high order Nedelec bases on prisms and tetrahedra.  Mainly so that I'm sure I have a reasonable understanding of the requirements before I make another attempt at implementing ND and RT bases for prisms.
The ND basis functions associated with edges have a clearly defined orientation which is directed along the edge.  Interior basis functions can be defined however we choose.  Basis functions on quadrilateral faces can also borrow their orientation from the bounding edges.  However, the basis functions associated with triangular faces must align with two of the three bounding edges and its important that neighboring elements choose the same pair of edges.
The tetrahedral implementation in MFEM reorders the vertices of each tetrahedron so that the two lowest vertex indices are first.  The ND basis functions on triangular faces are then defined so that they align with the two edges which meet at the vertex with the lowest index on each face.  This effectively determines the basis function orientations for every face in a tetrahedral mesh.  Moreover, face 0 of every tetrahedron in the mesh will choose the same pair of local edges to define its basis functions, and likewise for faces 1, 2, and 3.
I don't believe there's a way to define prisms so that they posses this same convenient behavior.  If we choose the basis functions on the base of the prism in a certain way there are still three possible choices for the orientation of the basis functions on the top of the prism.  In effect this produces three types of prisms in a general mesh.
This is unlike what we see for tetrahedra or hexahedra in MFEM.  At the very least I expect I'll need to introduce more flexibility into how we handle DOF permutations when working with prisms.  What I don't know is just how well I can contain these changes.  Any thoughts on potential solutions or pitfalls would be appreciated.
Thanks!
Mark

I'm not sure I understand the issue. But what comes to mind is the following: Imagine a triangle, maybe share by two tetrehedrons, maybe shared by two prisms, maybe shared by one tetrahedron and one prism. It seems to me that the ND and RT basis functions on the triangle face should be solely determined by the vertices (global node indices) of the triangle face, independent of what type of elements the face is connected too. This means that the two triangular faces of a prism may have basis functions that are in different directions, but not sure why this is a problem.
Anyway if I completely misunderstood the problem, I'm going to need some pictures

You are correct @Dan2997925.  The problem arises in the implementation.  MFEM, like FEMSTER, defines vectors in the reference element for the basis functions to follow.  MFEM stores them "tk" arrays, FEMSTER called them "interpolationVects" but the idea is the same.  There is a one-to-one mapping between these tk vectors and local degrees of freedom.  This mapping is defined the same way for every Tetrahedron (or Hexahedron or Prism) in the mesh.  By convention we sort the vertices of each tetrahedron so that they choose the same two tk vectors on shared faces.  Neighboring elements might choose tk vectors in different order but they will be the same vectors e.g. tet1 may use tk[1] and tk[2] while tet2 may use tk[2] and tk[1] but we can be sure that tet2 will not choose tk[1] and tk[3].
For prisms we cannot ensure that the top and bottom of the prism will both choose the same pair of tk vectors.  In FEMSTER we did make this assumption but I think this was a mistake.   Our prism meshes were typically extruded from 2D meshes so perhaps we never saw a problem.
One solution I can think of is to define different mappings relating the dofs to tk vectors, one for each of the three choices of the upper pair of tk vectors relative to the lower pair.  Each prism element would then need to select one of these mappings.  This would effectively create three different sets of behavior for Nedelec prisms.  I think this could work from the basis function's point of view.  I suspect it would work from the FiniteElementSpace's point of view i.e. for matching dofs from neighboring prisms or tetrahedra.  I'm not so sure that it would work with mesh refinement.  Specifically, I'm concerned about constructing the operators which map grid functions from coarse to fine meshes.
The overarching question here is if I define prism basis functions so that different instantiations of the prism element may behave differently what could break?

I think we should approach this issue in a more general way - the problem stems from the fact that the mapping of the global dofs to element local dofs is not a simple permutation with an optional sign flip. This is what we are assuming now by relying on methods like FiniteElementSpace::GetElementDofs to represent the global-to-local dof mapping.
So far this issue has appeared in the case of high-order Nedelec elements on tet meshes. The issue here is that the set of dofs associated with the interior of a triangle face has to be transformed (when mapping dofs from one side of the face to the other) by a change of basis matrix which is not a simple permutation with optional sign flip. We "fixed" the issue by enforcing special reorientation of the tets (using Mesh::ReorientTetMesh()), so that only simple transition matrices are required. However, this leads to the limitation that we can no longer refine the mesh (locally or globally).
The same problem now arises with prisms/wedges and now we cannot resolve the issue by simply reorienting the prisms.
Similar issue will arise when we consider H1 spaces with orders varying from element to element.
There are two approaches that I can see for resolving this issue in a general way:

Generalize all methods like FiniteElementSpace::GetElementDofs() to (optionally) return the global-to-local mapping as a small local matrix (square or rectangular) which has to be applied to the dofs after extracting a subvector of the global dof vector.
Split faces that require general transform of the dofs between the two adjacent sides into two independent sets of dofs (just the dofs interior to the face) and then enforce the continuity through the conforming prolongation operators - FiniteElementSpace::cP in serial, and ParFiniteElementSpace::P in parallel. In the case of H1 variable order spaces, the edges will need to be split too.

The second approach may be more straightforward to incorporate in the code, while the first one seems a bit more natural to me.
What do you guys think?

I had not considered variable order but you make an excellent point and we should try to prepare for that issue as well, if we can.
I think I see how we could solve the tet and prism issue with approach 1.  It's not so obvious to me how this would solve the variable order issue.  Wouldn't such a GetElementDofs method need to know the orders of the neighboring elements so that it could create an appropriate rectangular mapping operator?

Yes, GetElementDofs() will have access to that information -- it is a method in the FiniteElementSpace where the element orders will be stored.

This issue was discussed internally and will be implemented soon.


Multiple subscription add sample rest API request is incorrect

Description:
In the documentation [1] to add multiple subscriptions to an API, the provided sample request is incorrect.
POST https://localhost:9443/api/am/store/v0.14/subscriptions/multiple
Authorization: Bearer ae4eae22-3f65-387b-a171-d37eaa366fa8

{
    "tier": "Gold",
    "apiIdentifier": "c43a325c-260b-4302-81cb-768eafaa3aed",
    "applicationId": "c30f3a6e-ffa4-4ae7-afce-224d1f820524"
}

The request payload should be changed as follows ( as an array of JSONs ),
POST https://localhost:9443/api/am/store/v0.14/subscriptions/multiple
Authorization: Bearer ae4eae22-3f65-387b-a171-d37eaa366fa8

[{
    "tier": "Gold",
    "apiIdentifier": "c43a325c-260b-4302-81cb-768eafaa3aed",
    "applicationId": "c30f3a6e-ffa4-4ae7-afce-224d1f820524"
}]

Suggested Assignees:
@Mariangela
Affected Product Version:
APIM 2.6.0
[1]https://docs.wso2.com/display/AM260/apidocs/store/index.html#!/operations#SubscriptionMultitple#subscriptionsMultiplePost

This issue is fixed in 3.x docspaces, this needs to be fixed in 2.x only.

@Chamindu36 , please fix this in the 2.6.0 docs.

@Chamindu36 , please fix this in the 2.6.0 docs.


Subroutines

Does this sdk support multi threading? I mean when I try to trace calls in go subroutines, I think I'm losing the context, here's an example of my code:
func sendEventsAsync(items []ItemType, ctx context.Context) {
	wg := new(sync.WaitGroup)
	for _, item := range items {
		wg.Add(1)
		go sendEvent(wg, item, ctx)
	}
	wg.Wait()
}

func sendEvent(wg *sync.WaitGroup, item ItemType, ctx context.Context) {
	defer wg.Done()

	subCtx, subseg := xray.BeginSubsegment(ctx, "send-event")
	defer subseg.Close(nil)

        someHttpRequest(subCtx)
        someSqsRequest(subCtx)

       ...
}

My expectation is that I'd see multiple subsegments of "send-event" (I'm sending 4 items in my example), but for some reason the trace console is showing less than that, as you can see in the picture:

When I do this synchronously (without go subroutines), I can see the tracing for all my iterations (my 4 items) with the same code. However, when I introduce the go subroutines, the issue described is happening.
Again, my believe is that I'm losing the context somehow because of the multi-threaded environment, any suggestions on how I should handle this scenario?

Update:
I've been testing this calling the "invoke function" button in the lambda console, and I noticed that (for example) out of X number of calls, let's say 4, it's always the first invocation that shows the breakdown as in the original post. However, the next invocations always show up the breakdown correctly:

But for some reason, If I wait around 5 minutes until I do a next call, and again, I do like 4 or more invocations, the first one always miss information in the tracing breakdown, whereas the next invocations show up correctly.
What could be the reason for that?

Update:
I realized the first invocation has a initialization segment that the subsequent invocations don't show, I thought all lambda functions were idempotent, but looks like that's not necessarily true?

Update:
I looked up the documentation on the initialization phase lambdas have. That should be why my first invocation doesn't show my tracing correctly, I wonder If there's a way to make it work even for the invocation that includes the initialization.

Hi @cperezortiz ,
I think X-Ray Go SDK does not support tracing async calls. However, you can achieve this manually using X-Ray Go SDK public APIs. You probably have to manually propagate the context in order to see correct representation of your call hierarchy. As per my understanding initialization subsegment means function's initialization code that is run before function handler and it does not have to execute for every invocation so my guess would be that is why you see the initialization subsegment when you first invoke the function and not for the consecutive runs. However, I don't understand what do you mean in this comment - https://github.com/aws/aws-xray-sdk-go/issues/294#issuecomment-813364817 . Can you please explain more about it? Also, small repro code for this function with instructions on how to execute would be easy to understand what is going on here :)


Offset calculation in KtLint deprecated/made private

Expected Behavior
We should probably starting duplicating the code again asap.
Current Behavior
KtLint deprecated/made the methods to calculate offsets we use in formatting private.
Context
https://github.com/pinterest/ktlint/pull/857
https://github.com/detekt/detekt/pull/2760

Hello, I want to contribute to this project as part of the Hacktoberfest event,
Can I take this issue? As far as I understood there are two deprecated methods KtLint.calculateLineColByOffset and KtLint.normalizeText , and we need to copy these methods to Detekt, am I right?


Correct "return" in expressions

Why:
Closes #13615
Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@Arthur-Milchior
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Weird REPL UX with lurk::metrics

lurk::metrics has introduced a small weirdness in the REPL.
When we evaluate something it apparently works normally:
~/dev/rust/lurk-rs λ RUST_LOG=info bin/lurk
    Finished release [optimized] target(s) in 0.10s
     Running `target/release/lurk`
 INFO  lurk::cli::repl > Launching REPL with backend Nova and field Pallas
Lurk REPL welcomes you.
> nil
 INFO  lurk::eval      > Frame: 0
	Expr: nil
	Env: nil
	Cont: Outermost

 INFO  lurk::eval      > Frame: 1
	Expr: nil
	Env: nil
	Cont: Terminal

[1 iteration] => nil
>

But then ~1 second after that, it prints  INFO  lurk::metrics   > evaluation[type=step]: 2 and the user is left with this weird prompt:
...
[1 iteration] => nil
>  INFO  lurk::metrics   > evaluation[type=step]: 2
<caret here, on this empty line>

It feels glitchy.
cc @huitseeker

This works as intended, see #569 for details. The metrics are periodically drained in the log, and arguably your RUST_LOG setting is simply too coarse to not be impacted by this behavior.
Closing as won't fix because I really really, really want folks to learn how to use RUST_LOG properly:
https://docs.rs/env_logger/latest/env_logger/#enabling-logging
Feel free to re-open an issue with a suggested better UX, it's well-understood #569 is just a first step.


Create new client every time, to work around obscure and I/O-level multi-threading issues

Yes, it's true. On OSX, I encountered an obscure bug.
To uncover it, I added print statements that I implemented by decorating breakpoints in IDEA:
This is all in apache's httpcore version 4.4.1. In org.apache.http.protocol.HttpRequestExecutor, I added non-suspending and logging breakpoints as follows:
Line 122: "REQ:  " + System.identityHashCode(conn) + ": " + conn + " => " + request
Line 126: "OK:   " + System.identityHashCode(conn) + ": " + conn + " => " + request
Line 128: "FAIL: " + System.identityHashCode(conn) + ": " + conn + " => " + request + ": " + ex
A typical output, which shows the bug at the end:
REQ:  120493608: CPoolProxy{<IP_ADDRESS>:56553<-><IP_ADDRESS>:8084} => [URL]
REQ:<PHONE_NUMBER>: CPoolProxy{<IP_ADDRESS>:56552<-><IP_ADDRESS>:8084} => [URL]
OK:   120493608: CPoolProxy{<IP_ADDRESS>:56553<-><IP_ADDRESS>:8084} => [URL]
OK:<PHONE_NUMBER>: CPoolProxy{<IP_ADDRESS>:56552<-><IP_ADDRESS>:8084} => [URL]
REQ:<PHONE_NUMBER>: CPoolProxy{<IP_ADDRESS>:56552<-><IP_ADDRESS>:8084} => [URL]
FAIL:<PHONE_NUMBER>: CPoolProxy{0:0:0:0:0:0:9479:984b:56552<-><IP_ADDRESS>:8084} => [URL]: org.apache.http.NoHttpResponseException: The target server failed to respond
(The [URL]'s are request objects I have edited out, for clarity.)
The System.identityHashCodes ensure I am printing the same object. We see object #1848886687 goes from one state at request time, and to a new state after. The new state is that the local address has mysteriously become 0:0:0:0:0:0:9479:984b!
What is that, you say? It is an IPv6 address format. However, it describes the same IPv4 IP address!  You can work out what <IP_ADDRESS>b is in decimal for yourself ...
When does this change occur? When the socket connection flushes the outgoing data. (I.e. the request.) This happens in org.apache.http.impl.io.SessionOutputBufferImpl, line 126:
   this.outstream.write(b, off, len);

Don't ask me how it happens, but before we call write here, the connection is fine. And SOMETIMES, when the call returns, it is screwed, and unable to receive incoming data. (Manifesting as NoHttpResponseException: The target server failed to respond, as above, and the FAIL breakpoint hitting.) Not every time, but pretty often. This is why I suspect multi-threading issues.
I am serious. Do NOT ask me how this happens. Could be an issue with http-core and/or my network setup. I just know the pull request makes the FAILs go away.
PS: Sorry about the whitespace/formatting diff, that's my opinionated IDEA. The change is only creating a new client every time. I can clean that up, but it'll have to be a little later.
PPS: This is NOT an april fool's!

Are you able to write a test that reliably replicates this (on OSX at least)?
I'm a bit concerned about the cost of recreating the client each time, both in terms of the setup cost and the loss of pooled connections. Any thoughts on how that could be mitigated?

I could try, but I don't know if it would succeed. On such a low level, I'm not sure what could be the most likely factors. I don't usually meddle in the socket nether regions. And, after all, this is pretty basic behavior, and I'm sure I'm not the first to use it on OSX.
To mitigate: You could use a thread local HttpClient, of course. Then again, that introduces management of those clients, and potential leaks.
I would be very happy if I could turn on this behavior as a configuration option. HttpClient pooling is unlikely to be the big performance win for my application.

So if you can't reliably reproduce it in a unit test, under what circumstances does the error happen?
How would we be sure that creating a new client each time fixes the problem?

Those are both good questions! Especially since we don't know what the problem is, and it occurs unreliably.
Generally, with third-party code that works on a low level, I would advocate a conservative approach to sharing objects and the state that they represent, as it leaves you less vulnerable to these types of errors. In this case, one conservative approach is a fresh client that is exclusive to its thread. It seems to fix my issue.
For me and others who feel likewise, or who encounter similar weirdness, it would be nice to be able switch to this behavior. Should I add a new configuration option instead, leaving current behavior as the default?

Have you filed a bug report with apache?
It'd be great to get this fixed at source rather than increasing complexity with a workaround.

Nope, sorry. I agree with you, but I have only worked with the WireMock level so far, to analyze and work around it. Not sure how I would proceed to isolate the bug in Apache's code, since it's pretty low-level. The state change occurs during a call to a JDK class, so it could even be in the I/O libraries.
You already pass two primitive parameters to the ProxyResponseRenderer (along with the settings objects), and I agree that adding a third is a slippery slope. If they were wrapped up in a Parameter Object containing those two a new flag (connectionSharing or something - or trustApache!), I don't think complexity would suffer unduly.

I think I'd still like to see if we can get this fixed in the apache client before committing to add a workaround to WireMock.
I appreciate this is frustrating when you're just trying to get your work done, but I think it would set a bad precedent to start adding workarounds for every library bug.

Bit of a long shot, but have you tried bumping the apache client version to the latest?

First of all, thanks for being incredibly responsive yesterday.
I have tried a newer version, but I think I may have messed up the Maven dependencies so the change didn't "take". I will try again.
Lastly, I have limited time to go chasing this bug (it took some time to isolate even on the WireMock level of the stack), and first I need to figure out whether it's actually in the Apache library, or if it is in the JDK. So I'm considering running my forked version until I can get a closer look at it.

No problem,  sorry I couldn't be more help.
Good luck with your upgrade/workaround - hope it solves your problem.
One last question: which OSX version are you running?

I had a quick attempt to replicate this problem under Linux  but with no success. Here is the set up I used - @tomakehurst @kjetilv would either of you be able to run this on your Macs and let me know if you can replicate the problem?

Impressive effort, thank you.
This code does not replicate the bug on my machine either. I've made a similar unit test, which I will push to my forked branch later.
I have been able to reproduce and isolate the behavior, but so far only against a particular proxied server.  (The one that displayed the problem in the first place.) When I run the test against other targets (eg. public websites), the bug does not appear. Something about that server is causing bad IPv6-ness to creep into the I/O level. The server in question is a commercial product running on a Tomcat. (It responds with Apache-Coyote/1.1 - not sure if I am at liberty to reveal the exact product.)
I have done some more research using this case. For instance, the conditions for the bug to arise is simply that a connection is reused. A CPoolProxy (implementation of ManagedHttpClientConnection) receives a CPoolEntry with a LoggingManagedHttpClientConnection where the socketHolder is already set to a socket. This seems to be the case for all connections that encounter the issue. (And they are many.)
I have also pinpointed the state change to happen during a native (!) call to SocketOutputStream. I'm not going to dive into that, so I am trying to understand the conditions that cause the error instead.

As to Tom's question, I am running the latest OSX.

Ah that's interesting. Do you know what version of Tomcat it's running under-the-hood?

I think it might be a Tomcat 4 – I downloaded it and it responds with Apache/Coyote 1.1. But it does not provoke the error, either.

wow that's properly old skool! - could you verify the tomcat version using something like:
java -cp lib/catalina.jar org.apache.catalina.util.ServerInfo

that'd be a big help

I'll have a closer look at it tomorrow. Need to go through some gatekeepers at work.

Turns out it's 6.0.29. Still not reproducible on my machine, even when I run it with the same WAR file that provokes the issue in the field.
Not really that surprising, since I suspect it's an issue on a lower level.

In case anyone is still following this pull request, some updates:

My problem can be solved if WireMock can be changed to call useSystemProperties() on the HttpClientBuilder it uses. This makes the builder respect system properties, which in turns opens up ways of configuration already supported in the HttpClient library. One of these is http.keepAlive, which selects the correct pooling strategy.
Gave up on diagnosing the bug. Life is too short!

Ah ok this is interesting. So - just to be clear - when HttpClient is configured to use http.keepAlive you no longer see the NoHttpResponseException against the application's embedded Tomcat 6.0.29?

That's right. Setting this property makes it select the no-pooling strategy, which doesn't provoke the error.
WireMock just needs to call useSystemProperties() on the HttpClientBuilder, so that it will be respected.

Just so I understand - adding useSystemProperties() would simply allow you to disable pooling via system properties if you wished to?
If so, I'm happy for this to be included. Could you raise a PR?

Raised https://github.com/tomakehurst/wiremock/pull/392

Closing as effectively fixed by #392.


New line at EOF

When saving something, Atom adds a new line at the end of each file. How can I disable/overwrite this 'feature'?

Settings / Packages / whitespace / Settings / Ensure Single Trailing Newline.
(Please, this is not issue, read https://github.com/atom/atom/blob/master/CONTRIBUTING.md)

I know it's not an issue, but I've searched on the internets and wasn't able to find a solution.
Thank you !


Fix PieChartEvent.type on web

Fixes https://github.com/flet-dev/flet/issues/3546
Tried another approach, but the issue is still present.
AI's opinion on the cause of the issue:

When you run your Flutter application on the web, the Dart compiler minifies the code to reduce the size of the JavaScript output. This process often includes renaming classes and variables to shorter names (e.g., aj_) to optimize the code for performance and load times. As a result, PointerHoverEvent might be minified to something like aj_, making it harder to understand directly from the debug output.

What I found strange is the fact that, when testing on web using flutter run -d chrome it works (shows the right types).

Summary by Sourcery
This pull request addresses the issue with PieChartEvent.type on web by mapping Flutter event types to readable event names. It also enhances the event data by adding local position information and introduces an enum for event types in the Python SDK.

Bug Fixes:

Fixed the issue with PieChartEvent.type on web by mapping Flutter event types to readable event names.

Enhancements:

Added localPosition to PieChartEventData to capture the local position of events.
Introduced PieChartEventType enum in Python to standardize event type values.

Can you resolve conflict here please?


No summary.txt file produced

I've managed to get decoil to run with my data and produce all the right files but I am missing the summary.txt file
This file was produced with the test data but not with my own data.
(I used singularity to work with the docker image as a sif file)
The command I used was:
export BAM_INPUT="/path/to/${SAMPLE}_mod_aligned.bam"
export OUTPUT_FOLDER="/path/to/${SAMPLE}T"
export NAME="${SAMPLE}T"
export GENOME="path/to/reference.fa"
export ANNO="path/to/anno.gtf"
singularity run
-B $PWD:$HOME
-B ${BAM_INPUT}:/data/input.bam
-B ${BAM_INPUT}.bai:/data/input.bam.bai
-B ${GENOME}:/annotation/reference.fa
-B ${ANNO}:/annotation/anno.gtf
-B ${OUTPUT_FOLDER}:/output
decoil.sif decoil -f sv-reconstruct
-b /data/input.bam
-r /annotation/reference.fa
-g /annotation/anno.gtf
-o /output -n ${NAME}

Dear @eesiribloom,
Currently Decoil was not tested with singularity. This is something I am working on.
Do you have any error? Are you sure you use absolute paths for $ANNO and $GENOME?
Best,
Madalina

Not that I noticed but here is an example:
INFO:    Converting SIF file to temporary sandbox...
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
5: Setting LC_PAPER failed, using "C"
6: Setting LC_MEASUREMENT failed, using "C"
Found workflowfile at /opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/cli/sv-reconstruct.json
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job          count

all              1
coverage         1
decoil           1
survivor         1
svcalling        1
total            5
Select jobs to execute...
[Thu Mar 14 16:39:37 2024]
rule svcalling:
input: /examples/ecdna1/map.bam
output: /output/sv.sniffles.vcf
log: /output/logs/logs_sniffles
jobid: 1
reason: Forced execution
wildcards: dirname=/output
resources: tmpdir=/tmp
        sniffles -t 4 -m /examples/ecdna1/map.bam             -v /output/sv.sniffles.vcf --min_homo_af 0.7             --min_het_af 0.1 --min_length 50             --cluster --genotype --min_support 4 --report-seq &> /output/logs/logs_sniffles

[Thu Mar 14 16:39:41 2024]
Finished job 1.
1 of 5 steps (20%) done
Select jobs to execute...
[Thu Mar 14 16:39:41 2024]
rule survivor:
input: /output/sv.sniffles.vcf
output: /output/sv.sniffles.bedpe
log: /output/logs/logs_survivor
jobid: 2
reason: Missing output files: /output/sv.sniffles.bedpe; Input files updated by another job: /output/sv.sniffles.vcf
wildcards: dirname=/output
resources: tmpdir=/tmp
        SURVIVOR vcftobed /output/sv.sniffles.vcf -1 -1 /output/sv.sniffles.bedpe &> /output/logs/logs_survivor

[Thu Mar 14 16:39:41 2024]
Finished job 2.
2 of 5 steps (40%) done
Select jobs to execute...
[Thu Mar 14 16:39:41 2024]
rule coverage:
input: /examples/ecdna1/map.bam, /examples/ecdna1/map.bam.bai
output: /output/coverage.bw
log: /output/logs/logs_cov
jobid: 3
reason: Forced execution
wildcards: dirname=/output
resources: tmpdir=/tmp
        bamCoverage --bam /examples/ecdna1/map.bam -o /output/coverage.bw --binSize 50 -p 4 &> /output/logs/logs_cov

[Thu Mar 14 16:40:18 2024]
Finished job 3.
3 of 5 steps (60%) done
Select jobs to execute...
[Thu Mar 14 16:40:18 2024]
rule decoil:
input: /output/sv.sniffles.vcf, /output/coverage.bw, /examples/ecdna1/map.bam.bai
output: /output/summary.txt, /output/reconstruct.ecDNA.filtered.bed, /output/reconstruct.ecDNA.filtered.fasta
log: /output/logs/logs_decoil
jobid: 4
reason: Missing output files: /output/reconstruct.ecDNA.filtered.fasta, /output/summary.txt, /output/reconstruct.ecDNA.filtered.bed; Input files updated by another job: /output/sv.sniffles.vcf, /output/coverage.bw
wildcards: dirname=/output
resources: tmpdir=/tmp
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
5: Setting LC_PAPER failed, using "C"
6: Setting LC_MEASUREMENT failed, using "C"
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Select jobs to execute...
[Thu Mar 14 16:41:19 2024]
Finished job 4.
4 of 5 steps (80%) done
Select jobs to execute...
[Thu Mar 14 16:41:19 2024]
localrule all:
input: /output/sv.sniffles.vcf, /output/sv.sniffles.bedpe, /output/coverage.bw, /output/reconstruct.ecDNA.filtered.bed, /output/reconstruct.ecDNA.filtered.fasta, /output/summary.txt
jobid: 0
reason: Input files updated by another job: /output/sv.sniffles.bedpe, /output/summary.txt, /output/coverage.bw, /output/reconstruct.ecDNA.filtered.bed, /output/reconstruct.ecDNA.filtered.fasta, /output/sv.sniffles.vcf
resources: tmpdir=/tmp
[Thu Mar 14 16:41:19 2024]
Finished job 0.
5 of 5 steps (100%) done
Complete log: .snakemake/log/2024-03-14T163935.290762.snakemake.log
INFO:    Cleaning up image...

It only seems to produce the full set of files when using the test data but with my own data I only get these:
gGnome
clean.vcf
config.json
coverage.bw
fragments_clean_1.bed
fragments_clean_2.bed
fragments_clean_3.bed
fragments_initial.bed
graph.gpickle
logs
metrics_frag_cov_distribution.png
metrics_frag_len_cov_correlation.png
metrics_frag_len_distribution.png
reconstruct.bed
reconstruct.bed_debug
reconstruct.ecDNA.bed
reconstruct.json
reconstruct.links.txt_debug
sv.sniffles.bedpe
sv.sniffles.vcf

Actually yes, when I look at the snakemake log file for a run with my data I get this:
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job          count

all              1
coverage         1
decoil           1
survivor         1
svcalling        1
total            5
Select jobs to execute...
[Tue Feb 20 13:28:38 2024]
rule coverage:
input: /data/input.bam, /data/input.bam.bai
output: /output/coverage.bw
log: /output/logs/logs_cov
jobid: 3
reason: Forced execution
wildcards: dirname=/output
resources: tmpdir=/tmp
        bamCoverage --bam /data/input.bam -o /output/coverage.bw --binSize 50 -p 4 &> /output/logs/logs_cov

[Tue Feb 20 17:45:45 2024]
Finished job 3.
1 of 5 steps (20%) done
Select jobs to execute...
[Tue Feb 20 17:45:45 2024]
rule svcalling:
input: /data/input.bam
output: /output/sv.sniffles.vcf
log: /output/logs/logs_sniffles
jobid: 1
reason: Forced execution
wildcards: dirname=/output
resources: tmpdir=/tmp
        sniffles -t 4 -m /data/input.bam             -v /output/sv.sniffles.vcf --min_homo_af 0.7             --min_het_af 0.1 --min_length 50             --cluster --genotype --min_support 4 --report-seq &> /output/logs/logs_sniffles

[Wed Feb 21 05:59:51 2024]
Finished job 1.
2 of 5 steps (40%) done
Select jobs to execute...
[Wed Feb 21 05:59:51 2024]
rule decoil:
input: /output/sv.sniffles.vcf, /output/coverage.bw, /data/input.bam.bai
output: /output/summary.txt, /output/reconstruct.ecDNA.filtered.bed, /output/reconstruct.ecDNA.filtered.fasta
log: /output/logs/logs_decoil
jobid: 4
reason: Missing output files: /output/reconstruct.ecDNA.filtered.bed, /output/reconstruct.ecDNA.filtered.fasta, /output/summary.txt; Input files updated by another job: /output/sv.sniffles.vcf, /output/coverage.bw
wildcards: dirname=/output
resources: tmpdir=/tmp
Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Complete log: .snakemake/log/2024-02-20T132836.395335.snakemake.log

I dont understand what exactly the error is and why it only occurs with my sample data and not the test data. Could it be to do with using singularity? The incomplete set of files I get output from my own data are:
clean.vcf
config.json
coverage.bw
fragments_clean_1.bed
fragments_clean_2.bed
fragments_clean_3.bed
fragments_initial.bed
graph.gpickle
logs
metrics_frag_cov_distribution.png
metrics_frag_len_cov_correlation.png
metrics_frag_len_distribution.png
reconstruct.bed
reconstruct.bed_debug
reconstruct.ecDNA.bed
reconstruct.json
reconstruct.links.txt_debug
sv.sniffles.bedpe
sv.sniffles.vcf

Dear @eesiribloom,
I have been looking into the issue with singularity. The mount point /examples is not writable in singularity, which is different to docker, where this folder has write permissions. Forsingularity only specialised folders have write permission. One of them being /mnt.
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
5: Setting LC_PAPER failed, using "C"
6: Setting LC_MEASUREMENT failed, using "C"
Found workflowfile at /opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/cli/sv-reconstruct.json
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job          count

all              1
coverage         1
decoil           1
survivor         1
svcalling        1
total            5
Select jobs to execute...
[Mon Mar 25 14:33:22 2024]
rule svcalling:
input: /data/input.bam
output: /mnt/sv.sniffles.vcf
log: /mnt/logs/logs_sniffles
jobid: 1
reason: Missing output files: /mnt/sv.sniffles.vcf
wildcards: dirname=/mnt
resources: tmpdir=/tmp
        sniffles -t 4 -m /data/input.bam             -v /mnt/sv.sniffles.vcf --min_homo_af 0.7             --min_het_af 0.1 --min_length 50             --cluster --genotype --min_support 4 --report-seq &> /mnt/logs/logs_sniffles

[Mon Mar 25 16:45:33 2024]
Finished job 1.
1 of 5 steps (20%) done
Select jobs to execute...
[Mon Mar 25 16:45:33 2024]
rule survivor:
input: /mnt/sv.sniffles.vcf
output: /mnt/sv.sniffles.bedpe
log: /mnt/logs/logs_survivor
jobid: 2
reason: Missing output files: /mnt/sv.sniffles.bedpe; Input files updated by another job: /mnt/sv.sniffles.vcf
wildcards: dirname=/mnt
resources: tmpdir=/tmp
        SURVIVOR vcftobed /mnt/sv.sniffles.vcf -1 -1 /mnt/sv.sniffles.bedpe &> /mnt/logs/logs_survivor

[Mon Mar 25 16:45:34 2024]
Finished job 2.
2 of 5 steps (40%) done
Select jobs to execute...
[Mon Mar 25 16:45:34 2024]
rule coverage:
input: /data/input.bam, /data/input.bam.bai
output: /mnt/coverage.bw
log: /mnt/logs/logs_cov
jobid: 3
reason: Missing output files: /mnt/coverage.bw
wildcards: dirname=/mnt
resources: tmpdir=/tmp
        bamCoverage --bam /data/input.bam -o /mnt/coverage.bw --binSize 50 -p 4 &> /mnt/logs/logs_cov

[Mon Mar 25 17:39:23 2024]
Finished job 3.
3 of 5 steps (60%) done
Select jobs to execute...
[Mon Mar 25 17:39:23 2024]
rule decoil:
input: /mnt/sv.sniffles.vcf, /mnt/coverage.bw, /data/input.bam.bai
output: /mnt/summary.txt, /mnt/reconstruct.ecDNA.filtered.bed, /mnt/reconstruct.ecDNA.filtered.fasta
log: /mnt/logs/logs_decoil
jobid: 4
reason: Missing output files: /mnt/reconstruct.ecDNA.filtered.fasta, /mnt/summary.txt, /mnt/reconstruct.ecDNA.filtered.bed; Input files updated by another job: /mnt/sv.sniffles.vcf, /mnt/coverage.bw
wildcards: dirname=/mnt
resources: tmpdir=/tmp
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
5: Setting LC_PAPER failed, using "C"
6: Setting LC_MEASUREMENT failed, using "C"
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Select jobs to execute...
[Mon Mar 25 17:49:31 2024]
Error in rule decoil:
jobid: 0
input: /mnt/sv.sniffles.vcf, /mnt/coverage.bw, /data/input.bam.bai
output: /mnt/summary.txt, /mnt/reconstruct.ecDNA.filtered.bed, /mnt/reconstruct.ecDNA.filtered.fasta
log: /mnt/logs/logs_decoil (check log file(s) for error details)
RuleException:
KeyError in file /opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/cli/Snakefile, line 63:
'10'
File "/opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/cli/Snakefile", line 63, in __rule_decoil
File "/opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/main.py", line 350, in run_reconstruction
File "/opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/main.py", line 204, in run_save_v2_new
File "/opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/output/parse.py", line 220, in convert_bed2fasta
File "/opt/conda/envs/envdecoil/lib/python3.8/concurrent/futures/thread.py", line 57, in run
Removing output files of failed job decoil since they might be corrupted:
/mnt/reconstruct.ecDNA.filtered.bed
Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Shutting down, this might take some time.
Exiting because a job execution failed. Look above for error message
Complete log: .snakemake/log/2024-03-25T143320.373124.snakemake.log
Traceback (most recent call last):
File "/opt/conda/envs/envdecoil/lib/python3.8/site-packages/decoil-1.1.1-py3.8.egg/decoil/command.py", line 203, in main
raise Exception("Snakemake failed")
Exception: Snakemake failed
INFO:    Cleaning up image...

I think I know this error.
Can you please check if the GENOME matches the reference genome which was used for the alignment?
In one you might have "chr10" in the other "10".

Thanks for your advice, it has worked completely now that I made sure to use the same reference genome.


Added console method of image swapping to docs

Description
We detail how to edit images via make targets, thought we might want to add the console method as well.
Happy to move the screenshot elsewhere in the repo, wasn't sure what the preferred location might be :smile:
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[ ] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[X] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

thanks @nathan-weinberg !
/lgtm
/approve


Ignore  error of type not found in resource

ISSUE TYPE

Feature Pull Request

SUMMARY

After using Botkube for some time, I found a large number of "not found" errors when querying logs for troubleshooting.

Following the code, it turns out that these errors are caused by the Informer cache but are actually normal. Controller-runtime does a similar thing.
https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/interfaces.go
// IgnoreNotFound returns nil on NotFound errors.
// All other values that are not NotFound errors or nil are returned unmodified.
func IgnoreNotFound(err error) error {
	if apierrors.IsNotFound(err) {
		return nil
	}
	return err
}

Awesome! Thank a lot for fixing this @Lion916 :pray:

@PrasadG193 , Will this changes be merged to the mainstream release? It seem only avail in development branch now


Toast alert can't close.when show double component

Ionic version:  (check one with "x")
[x ] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
Related code:
    showToast($event) {
        this.toastController.create({message: 'fuck', position: 'middle'}).present();
    }

###since 3.4.2 after version

Can you show your component code also?

@shenmingxuanyi

'****'

I myself use curse words quite a lot but posting this to public forum is not funny.

Hello, I am a loyal user of your attention to your products, I have for a long time, from the first generation of products, there is a serious problem, I use a button to trigger the toast, click toast to close several times will lead to.

, continuous click several times, resulting in toast cannot be closed.


你好，我使用的是ttfnet_d53_1x.py的配置文件，但是当使用darknet53.pth作为预训练模型训练时，已经训练了7个epoch，但是mAP还是很低（和不用预训练模型差不多），请问这是什么原因？

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Describe the bug
A clear and concise description of what the bug is.
Reproduction

What command or script did you run?

A placeholder for the command.

Did you make any modifications on the code or config? Did you understand what you have modified?
What dataset did you use?

Environment

OS: [e.g., Ubuntu 16.04.6]
GCC [e.g., 5.4.0]
PyTorch version [e.g., 1.1.0]
How you installed PyTorch [e.g., pip, conda, source]
GPU model [e.g., 1080Ti, V100]
CUDA and CUDNN version
[optional] Other information that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

Error traceback
If applicable, paste the error trackback here.
A placeholder for trackback.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

Hi. We have reproduced this problem, and we are working on it.
We find that the downward trend of the heatmap loss is as expected, but not for the regression loss, i.e., losses/ttfnet_loss_wh in the training log. This happens when using 8 GPUs for training.
You may have noticed that the wh_head_conv_num is 2 in ttfnet-34 and ttfnet-53 but 1 in ttfnet-18. This is because we find that larger wh_head_conv_num will lead to slower convergence at the beginning of training, but we can get slightly higher precision for ttfnet-34 and ttfnet-53.
So, the current solution is to set wh_head_conv_num to 1 in ttfnet_d53_1x.py, and we will check the code and update soon.

Thanks, I'll set wh_head_conv_num to 1 in ttfnet_d53_1x.py and train it again

We have adjusted the initial learning rate of the warm-up phase to solve this problem.


chore(deps): update common-dev-assets digest to 9c06440

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
5d1db25 -> 9c06440

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Deployment/Removal error: that.sdk[service] is not a constructor

I get the following error when trying to deploy/remove a stack with the websockets plugin. I haven't tried to do any functionality yet, I just want to see it deployed.
Serverless: Stack removal finished...
  Type Error ---------------------------------------------
  that.sdk[service] is not a constructor
     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

service: skippy-websockets

plugins:
  - serverless-websockets-plugin

provider:
  name: aws
  runtime: nodejs8.10
  region: eu-west-1

functions:
  connectionHandler:
    handler: handler.hello
    events:
      - websocket:
          routeKey: $connect
      - websocket:
          routeKey: $disconnect

  defaultHandler:
    handler: handler.hello
    events:
      - websocket:
          routeKey: $default

  actionHandler:
    handler: handler.hello
    events:
      - websocket:
          routeKey: myAction

'use strict';

module.exports.hello = async (event, context) => {
  return {
    statusCode: 200,
    body: JSON.stringify({
      message: 'Go Serverless v1.0! Your function executed successfully!',
      input: event,
    }),
  };

  // Use this code if you don't use the http event with the LAMBDA-PROXY integration
  // return { message: 'Go Serverless v1.0! Your function executed successfully!', event };
};

Got the same error whilst trying to run example application in example/
     Node Version:           8.12.0
     Serverless Version:     1.34.1

Seems to be resolved by installing 1.35.1


linux platform DTB example

Hello,
We are trying to boot Linux using riscv-vp.
Could you please provide us the correct dts/dtb file for linux-vp.
Thanks

I'm also trying to boot linux with riscv-vp, any solutions?
Thanks.


Provide compilers targeting stable tensorflow releases

I am quite sure there are people around who would prefer to use a stable version of tensorflow with the compiler.
We should branch off a r2.1, r2.2 and r2.3 branch, and revert the small adaptations to tf master, so that it works with the respective version of tensorflow.

I just created a r2,2 and r2.3 branch with working matching CI tensorflow checkout. See https://github.com/cpetig/tflite_micro_compiler/commit/e89116d8448f481784fc8f24d4b5101934234fee and https://github.com/cpetig/tflite_micro_compiler/commit/1cc732b4cbaa4e9d6f3f4bd8137d32362c545fc7


[Feature/Identity] Strategy for Delegated Authority using Tokens

Description
This PR contains documentation for token usage in OpenSearch security today and how the usage can be extended to provide delegated authority for extensions running work asynchronously. This PR also contains sample code for token creation and verification.
This PR adds a docs/ folder in the new sandbox lib which can be a good place to store documents related to feature/identity.
Issues Resolved
Related to: https://github.com/opensearch-project/OpenSearch/issues/3850
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied In my next PR with tokens around internal actions I'll see if I can get the image to render. Its a basic image of a cluster, client and extensions without any more info but I plan to add more to it.

The image you just posted works, shrug


hyprexp: Failed to build.

When i try to add the plugins the hyprexpo plugin failed to build.
Logs
→ Building hyprexpo
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━  3 / 5  Building plugin(s)[v] shell returned:  -> cd /tmp/hyprpm/new && PKG_CONFIG_PATH="/home/spy/.local/share/hyprpm/headersRoot/share/pkgconfig" make -C hyprexpo all
make: Entering directory '/tmp/hyprpm/new'
make: *** hyprexpo: No such file or directory.  Stop.
make: Leaving directory '/tmp/hyprpm/new'
✖ Plugin hyprexpo failed to build.

Same error

you need to be on git


Red fields, test fails.

I cannot seem to get this to connect.
I set up the LLAPI and turned my firewall off for testing, just does not seem to connect.
I have also tried the external IP (ssl encrypted)
Internal: https://<IP_ADDRESS>:8123
Any ideas?
Thank you

Hi,
Yes, I get this:

It fails the check, and does not allow save.
Can confirm, instance IP is correct, and so is the LLAPI key.

What do you get when you try external url?

Same, tried my forwarded port too:

Tried switching internal and external firewall off just in case it was a block, this is behaving like the API is wrong, so I recreated the key but this made no difference.
Not sure what is going wrong here, guessing the letsencrypt cert wouldn't get in the way with the api key?

Can you check out this version?
Download


Search for is:alerted always starts many pages behind the last read message

I like the Alert words a lot for keeping track of important messages, but every time I go to Alerted messages from the search bar (a search for is:alerted appears) I am brought to the same message from Dec '19. I need to scroll many pages down to get to the most recent messages, to see if there's actually a new alerted message.

I tried to reproduce this, but I couldn't.  One possible theory is that I'm on a newer version of Zulip than @wardweistra, but I don't think that's it.
My guess is that this is a symptom of your underlying pointer being really far behind.  If you are caught up on unread messages, I would try clicking on "All Messages" and then scroll all the way to the bottom here, and that might fix things here.  If not, it will at least be a data point.
It's also possible, of course, that something besides the pointer is causing this issue, but I don't have a great theory yet.

Hi @showell, thanks for the pointer. I scrolled all the way down in 'All messages' and now (even when I wasn't fully scrolled down yet) is:alerted now starts at the most recent message again.
I'm pretty sure at least every message in is:alerted was already read by me before, but I guess the general pointer of the oldest message I haven't read influences where I start in is:alerted then?

That is correct.  We have mitigations for that class of issue for most queries, but I think not is:alerted.  The removal of the pointer, coming in the next couple weeks, will eliminate that problem.
https://github.com/zulip/zulip/issues/8994 is the master issue tracking that work.  @amanagr FYI, we should make sure we get that finished for the 2.2 release.


Adding event listeners throws errors

This code used to work
const form = document.getElementById('some-form');
form.addEventListener('keypress', (e) =>
    if (e.keyCode === 13) {
        this.doSomething();
    }
    return;
});

Now I got this error (flow pulled from master):
 90:         form.addEventListener('keypress', (e) => {
             ^ call of method `addEventListener`
 90:         form.addEventListener('keypress', (e) => {
                                               ^ arrow function. This type is incompatible with
 66:     addEventListener(type: string, listener: EventListener, useCapture?: boolean): void;
                                                  ^^^^^^^^^^^^^ union: object type | EventHandler. See: /tmp/flow/flowlib_312e97dd/dom.js:66

Converting to function with bind(this) doesn't help
 90:         form.addEventListener('keypress', function(e)  {
                                               ^ call of method `bind`. This type is incompatible with
 66:     addEventListener(type: string, listener: EventListener, useCapture?: boolean): void;
                                                  ^^^^^^^^^^^^^ union: object type | EventHandler. See: /tmp/flow/flowlib_312e97dd/dom.js:66

Typing e as Event doesn't work
 91:             if (e.keyCode === 13) {
                       ^^^^^^^ property `keyCode`. Property not found in
 91:             if (e.keyCode === 13) {
                     ^ Event

Typing e as KeyboardEvent doesn't work, since EventHandler function wants Event
 61: type EventHandler = (event: Event) => mixed
                                 ^^^^^ Library type error:
 61: type EventHandler = (event: Event) => mixed
                                 ^^^^^ Event. This type is incompatible with
 90:         form.addEventListener('keypress', (e: KeyboardEvent) => {
                                                   ^^^^^^^^^^^^^ KeyboardEvent. See: (the address of the file):90

What I ended up doing is setting it as Event and doing this
const form = document.getElementById('some-form');
form.addEventListener('keypress', (e: Event) =>
    // flow dancing
    if (!(e instanceof KeyboardEvent)) {
        throw new Error("Strange type error.");
    }
    if (e.keyCode === 13) {
        this.doSomething();
    }
    return;
});

...but that's weird, since keypress can only give KeyboardEvent.
I will try to fix that in the library definition but I am writing it here first

Seems like this might be related to https://github.com/facebook/flow/issues/1155

I think this behavior is actually expected. The fact that we allowed if (x.foo === bar) before when x didn't have a property foo was problematic. We changed that behavior, hence the change, but it's intentional.
Your PR looks promising. Thanks for contributing!

Oops—I definitely didn't mean to close that. Sorry!

As I wrote to the PR - originally it fixed the issue back then, but now even with the PR accepted, I see the same error. It seems like the PR had no effect

It looks like the strange errors you were getting have now been fixed. Let me know if you still have issues 👍

Strangly, I'm getting that error again.
Example
const addEventListener = (type: string, listener: EventListener): void => {
  window.addEventListener(type, listener)
}

addEventListener('keyup', (e: Event): void => {
  switch (e.keyCode) {
    case 40: // arrow down
      console.log('hi')
      return
  }
})

Says
Cannot get `e.keyCode` because property `keyCode` is missing in  `Event` [1].

But it should be there!


A first dump of a bunch of things from other places

Purpose/implementation Section
What changes are being implemented in this Pull Request?
I'm setting up a basic outline with blank documents here that will end up having the content that is linked or otherwise described in the README.
Also making sure that this looks Hutch branded with the style set.

The URL check failing is expected because I'm referencing URLs that don't yet exist because I haven't merged this to main yet.

I'm going to do a bad thing and then we can polish this up later. I'm going to merge to main without reviewing this. It's too gnarly of a dump to review all at once. So we are going to YOLO to main and then polish in separate PRs.


Showcase

If you want to showcase a bunch of websites or projects that use your lib in real life, I'll be glad if you mention my website (https://inventory.rawsec.ml/) that heavily rely on TableFilter.

no worries, you will be the first reference in the list the day I add a references page to the website.


Is there a way to create new landmark point definitions?

Hi. I'm trying to implement webcam based facial motion capture with with library.
The current set of face and retina landmarks is quite good, but I'm wondering if it's possible to extend the landmark regions that the PICO process can identify.
Specifically:
Option 1: adding new face landmarks
I'm assuming that new facial landmark locations would require defining new cascade files. Did the paper authors mentioned any recommendations on collecting and tagging example training data, or the training process itself?

Option 2: adding simple paint based landmarks
Perhaps a simpler option would be to somehow define cascades for recognizing simple shapes like dot marks, or cross marks placed in an actor's face where the missing facial landmark points are needed.

Let me know if I missed anything.
Thanks!
Resources
AutoDesk SoftImage - The Motion Capture Process

In order to define new landmark points these needs to be trained by using some kind of neural network. I obtained the cascade files directly from one of the author of the paper. The project is covering only the computer vision part and not the convolutional neural network part. In the papers cited on the Pigo readme page also there is no reference about the process used for training the cascade files and I'm not sure if this information would be available. I contacted Nenad Markus (one of the authors) a few years back and had a conversation with him about a few aspects of the project, but never talked about the neural network training. Eventually I might contact him again for asking some help on the neural network part (because I admit that it would be great to extend the facial landmark zones with more points of interests).
However my future interest is to develop this project into a computer vision library by supporting features and objects detection as it is mentioned in the Readme page. This is quite a big task but I consider doable. For more reference there is separate ticket covering this requirement here https://github.com/esimov/pigo/issues/38.

@esimov got it, makes sense. Should I close this ticket and continue the conversation in #38 then? Thanks!

You should close it. I might reopen it case it will be more progress regarding new feature points.

Got it. Thanks!

Hi @esimov . I kept pondering upon this issue during these last days, and I'd like to run this idea by you.
It looks like the OpenCV project already has some level of tooling available in order to generate training data used to create new Haar cascades:
https://docs.opencv.org/3.4/dc/d88/tutorial_traincascade.html
https://amin-ahmadi.com/cascade-trainer-gui/
Here are some examples of the training process outputs:
https://github.com/opencv/opencv/tree/master/data/haarcascades
So the question is: is there a way to convert an OpenCV XML cascade file into the in-memory format used by Pigo? In other words, is it possible to extend the input cascade file format to read from OpenCV XML files instead of the legacy binary format defined by Nenad Markus?
If this is possible, I think it would be useful to convert XML cascades into the face cascade format since it can be applied to the whole input image.
I realized this when I started creating a Java port for Pigo:
https://github.com/vaccovecrana/kimaris
Let me know what you think.
Thanks!

@jjzazuet I'm not very convinced if this approach should work from various reasons: first because the xml structure is quite different, but that's not the main bottleneck. The main culprit from my perspective is that the algorithm itself has been adapted to the binary tree cascade structure. I found similarities between the OpenCV based XML cascade tree structure and the in-memory, binary based one used by Pigo, but I also found differences. Overall they resembles in many aspects (the leaf nodes are present, there is also a threshold and weakness counter), but I found that the tree depth and the tree codes are missing form the xml cascade files. These are key parts of the algorithm. So in order to adapt the algorithm to the xml based cascade files means that the whole code needs to be rewritten.
I will try to contact Nenad.
Btw: thumbs up for your Java port!


Does this library support Linux?

Doesn't appear to due to the System.Net.Http.WinHttpHandler reference...

It does! That name is somewhat of a misnomer, that's what is in Core, which works on both Linux and Windows.

Thanks for the feedback, yeah that is deceptive!
Any idea on how to solve the issue I am getting?
http://stackoverflow.com/questions/42472536/can-a-library-that-depends-on-system-net-http-winhttphandler-be-deployed-to-linu

I haven't ran the dotnet sdk installer since I was doing a Self-Contained deployment, but if that is my problem I will.

That solves it, disappointing. Thanks!

I answered your SO post, but I was able to get it working with a self-contained deployment.

Copying here: I think it is the "platform": true configuration that causes the issue. I have moved to .CSPROJ project structure, and that is no longer a setting. Not sure where it is now!


ubuntu 22.04 installation, no matches found: qml-module-qtquick*

following ubuntu 22.04 installation steps guide.
getting this:
no matches found: qml-module-qtquick*

can you try running 'sudo apt update' command first?

Ah - hang on, it might be your terminal shell.
can you try this in a 'bash' shell

Or try this (note the quotes around the asterisk):
sudo apt install qml-module-qtquick'*'

sudo apt install qml-module-qtquick'*'
worked.
Will continue with the testing.
thank you !
Keep up the great work.


[Bug] Fix text alignment and enable href in Button

Description
I noticed that the text inside the button was misaligned in some of our demos and our 404 page. This was the case for all buttons that were used as anchor tags, so where href was used.
This has been fixed in the vizro-bootstrap repository here: https://github.com/McK-Private/vizro-bootstrap/pull/36
While fixing this I was actually wondering why we did not enable the href argument for the Button. For me, it functions similarly as our Card, where we have also enabled text and href. This also seems to be a common use-case, so in this PR I would like to add the argument in unless we had good reasons to not do so?
Screenshot
Before

After

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Looks good! I had noticed the bad link alignment on buttons when I added one to ViViVo. ~What is the unminified change to CSS to fix it?~ Oh, I see you linked to it 👍 ~Can my custom CSS on lines 31-35 here be removed now?~ https://github.com/mckinsey/vizro/pull/824/files/a304db5e8797bdb53e6fcb53f9cd78fa3d94e3fb#r1815769534 Judging by the pycafe preview I think the line-height: unset can be removed but the margin-bottom: 12px is still needed?

Ahh, I didn't realise you had added custom CSS. All of this can be removed now - I'll quickly push that change 👍

Ahh, I didn't realise you had added custom CSS. All of this can be removed now - I'll quickly push that change 👍

I think the margin-bottom: 12px will still be needed or the button gets too squashed onto the code snippet.

Will wait for @stichbury approval on the docs changes before merge

Ahh, I didn't realise you had added custom CSS. All of this can be removed now - I'll quickly push that change 👍

I think the margin-bottom: 12px will still be needed or the button gets too squashed onto the code snippet. But yeah, anything to do with positioning of text in the button can hopefully go.

Ahh, i see - it's not related to the the button text


Ephemeral Storage upto 1TiB

Is there a way to setup ephemeral storage in the scripts so that nodes have a higher storage capacity? Our RabbitMQ cluster crashes because of our production workloads. I was wondering if you considered the storage capacity here or could point me in the right direction? Please do the needful.

@rahulraju93 it is already done in new version, please give it a try !


CD/DVD Drive DiskImage.iso path: Could not open, Operation not Permitted

Describe the issue
VM Name:  QemuEmulatedDebian.UTM
Used within UTM.app all the time.
VM Backup Name: QemuEmulatedDebianBackup.UTM
Always used as an offline backup and never used within UTM.app to prevent recreation of VM UUID.
When needed, while UTM.app is closed, QemuEmulatedDebian.UTM is deleted and a new QemuEmulatedDebian.UTM is duplicated from QemuEmulatedDebianBackup.UTM
Steps to Reproduce
While UTM.app is closed, duplicate QemuEmulatedDebian.UTM as QemuEmulatedDebianBackup.UTM within Finder.
When something goes wrong with the QemuEmulatedDebian.UTM, quit UTM.app.
Delete QemuEmulatedDebian.UTM
Duplicate QemuEmulatedDebianBackup.UTM as QemuEmulatedDebian.UTM
Open UTM.app
Start QemuEmulatedDebian.UTM
Error
QEMU exited from an error: qemu-x86_64-softmmu: -drive if=none,media=cdrom,id=driveF177DB5E-953E-4CE1-8829-FEA9EC3C4694,file=/Volumes/data/DiskImage.iso,readonly=on: Could not open '/Volumes/data/DiskImage.iso': Operation not permitted
Fix
Edit QemuEmulatedDebian.UTM
Drives > IDE Drive > Path
Even if you see the DiskImage.iso file in Path Box, Browse... and select DiskImage.iso again.
Start QemuEmulatedDebian.UTM
Configuration

UTM Version: 4.4.0
macOS Version:  14.0 Beta (23A5328b)
Mac Chip (Intel, M1, ...):  M1

It was included in v4.4.1 so you're probably hitting another issue. Also FDA doesn't mean anything in a sandboxed app.

@osy, I was able to work around it using the advice from [https://github.com/utmapp/UTM/discussions/5837 this discussion], but I'll keep an eye out and if it's something reproducible, I'll collect more information for a proper bug report. Thanks!


[Bug] fix broken links

Page link
No response
Description
The CI tests are failing due to broken links:
https://github.com/kyverno/website/actions/runs/12369533545/job/34537971789?pr=1447
### Errors in content/en/blog/general/introducing-kyverno-envoy-plugin/index.md

* [404] [https://github.com/kyverno/kyverno-envoy-plugin/tree/main/demo/standalone-envoy/envoy_iptables](https://github.com/kyverno/kyverno-envoy-plugin/tree/main/demo/standalone-envoy/envoy_iptables) | Failed: Network error: Not Found

### Errors in content/en/docs/writing-policies/mutate.md

Error: R] [file:///home/runner/work/website/website/content/en/docs/installation/platform-notes.md#argocd](file:///home/runner/work/website/website/content/en/docs/installation/platform-notes.md#argocd) | Failed: Cannot find fragment

Error: Process completed with exit code 2.

Expected behavior
No broken links
Slack discussion
No response

/assign


KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

Bug Details:
Mistakenly setting the value serde to the key serde for an internal wrapped serde in the FKJ workflow.
Testing:
Added integration test to use a non-primitive Serde, in this case the JSONSerde that the original bug finder reported using. Expanded integration test to ensure that the default Serdes work for the entire happy path of the FKJ.
Introduces a testing dependency on com.fasterxml.jackson, though this is already the case in other modules so I suspect it won't be a big issue.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

test this please

Updated KTableKTableForeignKeyJoinScenarioTest from (String,String) to (Integer,String). This would have caught this particular bug. Reverted the JSON-related test since it's not essential for our coverage.

Test this please

Thanks, @bellemare ! I'll give it a look today.

Looks like checkstyle failed. I may submit a patch, just to get the tests running.

Ok, since I had a couple of small requests, I won't push a fix for the checkstyle errors. In case they're gone by the time you come back to this, it was:
00:11:48.980 > Task :streams:checkstyleTest
00:11:48.981 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:71: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:48.981 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:72: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:48.981 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:78: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:48.982 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:94: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:48.982 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:95: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.132 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:101: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.132 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:117: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.132 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:118: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:126: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:142: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:143: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:149: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:166: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:167: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.133 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:173: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.134 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:206: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]
00:11:49.134 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java:207: 'lambda arguments' has incorrect indentation level 16, expected level should be 12. [Indentation]

By the way, if you run ./gradlew :streams:test, it includes the checkstyle rules. It takes a while to run the tests, but it's faster than waiting for Jenkins. Often, if I don't want to wait before pushing to the branch, I'll run it on my machine after pushing, just so I'll catch stuff like this.

I swear it ran checkstyle when I compiled it... bah! I guess not. I did run ./gradlew :streams:test it had one unrelated error (I think) so lets see how it does now.

Test this please

Test this please

retest this please

Test this please

Test this please

Test this please

Test this please

Hey @bellemare , Thanks so much for the update! Jenkins has been a bit lazy recently, so I'll probably be pinging it for a while...

Ah, there we go :)

All the test failures were kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles

Thanks John!

Np, Thanks for the fix, @bellemare !

Cherry-picked to 2.6 and 2.5


Qt.py

What do you think of making the name more Python-specific?
I figure this would be the GitHub and PyPI name.
$ git clone https://github.com/mottosso/Qt.py
$ pip install Qt.py

But that we'd still import it as we do now.
import Qt

Actually, I've realized we should change the name to avoid confusion. I keep having to write "Qt module" instead of just "Qt" (or in your suggestion "Qt.py") to avoid having readers thing I refer to the actual Qt.
I'm all for your suggestion. I would even go to such length to propose we might want to call it QtWrap or QtAlias or something. But if you feel strongly about Qt.py,  think that's much better than just Qt.
I also wish to keep import Qt.

Hm. Come to think of it... QtWrap and QtAlias sounds like they could be part of the Qt module:
from Qt import QtAlias

I think Qt.py is great! Go for it.

Done!

Awesome!


[aws-cpp-sdk-s3-crt]: handle s3 meta_request errors in Get/PutObjectAsync

When aws_s3_client_make_meta_request returns NULL, {Get,Put}ObjectAsync hang,
since the response handlers never get invoked.
Handle the case by returning an error instead.
Resolves #2076.
Check all that applies:

[X] Did a review by yourself.
[X] Added proper tests to cover this PR. (If tests are not applicable, explain.)
Tested function via test program that handled the case of a NULL s3 meta_request.
[X] Checked if this PR is a breaking (APIs have been changed) change.
[X] Checked if this PR will not introduce cross-platform inconsistent behavior.
[X] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

[X] Linux
[ ] Windows
[ ] Android
[ ] MacOS
[ ] IOS
[ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes have been absorbed into #2112, please see there.


Add Docker Compose setup

Update Docker setup with LTS Node version, define environment variables and services in docker-compose, and configure web application Dockerfile with multi-stage builds.
I'm not 100% sure if this meets the apps setup but at least it shows the components needed to run this app. It might need some improvements.
I'll create a separate build PR.

Good point!

fixes #7  (partially) and #34


Prod app deploy gets cancelled due to Staging deploy happening at the same time

Slack conversation: https://expensify.slack.com/archives/C07J32337/p1723582974942859?thread_ts=1723582659.792279&cid=C07J32337
Action Performed:
Deployed the standard way (checklist: https://github.com/Expensify/App/issues/47219)
Expected Result:
Staging & Prod deploys should be able to happen concurrently
Actual Result:
Prod deploy canceled itself due to Canceling since a higher priority waiting request for 'Build and deploy android, desktop, iOS, and web clients-release' exists
Solution:
[Manual]

Retry job (had to manually release prod Android app)

[Other]

Fix the cancel-in-progress flag

cc @AndrewGable @roryabraham 🙏

Going to help out with this while @AndrewGable is working on fixing HybridApp builds

this is fixed


'binding_callback_thread_observer.hpp' file not found

pod 'Realm'
pods version 1.4.0.beta.2
get error
'binding_callback_thread_observer.hpp' file not found
in fact,has binding_callback_thread_observer.cpp
good days
Version of Realm and Tooling

Realm framework version: 3.0.2
Realm Object Server version: ?
Xcode version: 9.0
iOS/OSX version: 11/10.13.1
Dependency manager + version: ?

Can you try the CocoaPods troubleshooting instructions at this link, and report back if that doesn't fix your issue?


add WireGuard VPN

The icon I want is:

Name: WireGuard VPN
URL: https://www.wireguard.com/
Link to icon: https://www.wireguard.com/img/wireguard.svg
Official style guide or brand guide: https://www.wireguard.com/trademark-policy/ (The color of the logo is RGB #88171a)

That looks really complex. I think we'll struggle to get it down to 1,023 bytes.

I can imagine that. There's a smaller version on the website (i.e. for the favicon and touch icons). Maybe that's a bit more realistic?

I've had a go at this one, after seeing that 17jiangz1's PR from June had blocking issues.

Closed in #455


Core: Add upstream Generic.Arrays.DisallowShortArraySyntax sniff

Recently a new section has been added to the handbook which forbids the use of short arrays.

Using long array syntax ( array( 1, 2, 3 ) ) for declaring arrays is generally more readable than short array syntax ( [ 1, 2, 3 ] ), particularly for those with vision difficulties. Additionally, it’s much more descriptive for beginners.
Arrays must be declared using long array syntax.

https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#declaring-arrays
This PR add an existing upstream sniff which addresses this.
Includes auto-fixer.
Also see: https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/
Loosely related to #764

I presume to override this, folks can do something like:
<rule ref="Generic.Arrays.DisallowShortArraySyntax">
	<severity>0</severity>
</rule>

...with an optional:
<rule ref="Generic.Arrays.DisallowLongArraySyntax"/>

@GaryJones Correct. Alternatively for the first code snippet, you can use:
<rule ref="WordPresss">
    <exclude name="Generic.Arrays.DisallowShortArraySyntax"/>
</rule>

(within WPCS we use severity to make it clear to people how to re-enable an excluded rule, in a "end-user" custom ruleset you normally would use the above exclude).

Since https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/ explicitly says these changes are only intended for WP core itself:

While reading these changes, it’s important to keep in mind that they only apply to WordPress Core:

I'm wondering whether the addition could have been made to https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist instead of to the standards that all of the community would be using.

@GaryJones I hear you, but I believe that discussion has been had numerous times already and the conclusion was always that the rulesets in WPCS follow the Core rules.


Update index-state to 2020-12-11

Oh, I just saw the message that this is about the NoThunks Void orphan that was introduced in nothunks-0.1.2. I'll push a commit.

bors merge


Make warning on old version of website noticable...

🥲 Today i spend hours thinking why my code had handles and docs don't and rewriting the code... not releasing i started with newer library version and i am now i am reading the docs the older one.
can you make this warning much more clearer? maybe add as banner to every page of the documentation?

maybe it's my own mistake ignoring the giant new button.. not sure..

Oh sorry about that... 🥲
I wonder how you ended up on the old site ?
I set a 56px font. Hopefully this won't fool anyone anymore

Oh sorry about that... 🥲 I wonder how you ended up on the old site ?
I set a 56px font.

I wonder how you ended up on the old site ?

google of-course

obviously...
thx


Let backtrack run without foreground service

[ ] If background location is granted
[ ] Uses override
[ ] No location access
[ ] No GPS
[ ] Always foreground if cell signal is required

Will not be implemented following changes in Android 14