Email or password is incorrect

I'm submitting a ...

[ x] bug report
[ ] feature request
[ ] support request

General information
Addon version used
DailyBuild 0.14.0_20190422
Description
Hello,
I installed the addon correctly. Enter my email and my password.
I can connect to my accounts and my lists when I want to start a video I have the error message "email or password is incorrect" and the video does not start.
Thank you for your help and all the work you have done.
Context (Environment)
I use a raspi 3 B+ with Librelec 9.01
Installation

[X ] I'm using this Netflix Repo
[ ] I'm using other Netflix Repo (Please specify which)
[ ] I'm using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[X ] Linux (ARM)
[ ] Android

Additional informatin on the environment
[Descripe your environment a bit more detailed, are you using LibreElec f.e.]
libreelec 9.01
Debug log
https://pastebin.com/raw/j5nct92v
Other information
[e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, etc.]
Screenshots
[Please add a screenshot if that helps understanding your problem]
[You can erase any parts of this template not applicable to your Issue.]

Hi,
for information my location is France
Thanks a lot

i need the full log with kodi debug infos enabled, no cutted log..

I'm sorry,
i hope this is better  http://ix.io/1HGG
Thanks a lot

unfortunately not here there is no debugging information, you have not activated the kodi debug logging

Sorry, I thought I did it. I'll tick all the boxes and start again.

I hope this is better http://ix.io/1HJh
or  http://ix.io/1HJi
I actived all the option in the system menu of Kodi.
There are 2 paste logs button.
Thanks a lot

This paste might be better (only this day and color...):
https://paste.kodi.tv/keyurezuyu.kodi

from what i can see i don't find much explanation for your problem,
decoding the error data clearly says email or password incorrect
{"internalcode":205007,"messageid":15809443405631,"errorcode":7,"errormsg":"Email or password is incorrect.","timestamp":1556707151}
feedback from other users who have had a similar problem,
have solved by changing passwords from netflix, probably netflix for some reason blocked access
other alternative it is possible that the videos you are trying to see need to have enabled the profile VP9 or else HEVC (do not enable both), you can try enable/disable the profiles in the expert settings of addon

Dumb question : could your password contains a very special char, like a space maybe ?
I remember some software that couldn't handle such case...
(Please do not disclose your full password!)

I have tested VP9 or HEVC but aren't solution.
My email and my pass not contains special char. just upper case and number

What surprises me is that I add to the list of videos and my favorites netflix so my password at this time did not pose a problem.

Same here. Works to login, logout, browse lists, anything... when select something to play, same error... tested account in other place it works everywhere else. So account is not blocked, login is valid and so on... using OSMC.

Sounds like you're not allowed to access the stream itself then.
Would it be possible you're having a 'basic' Netflix account (lowest coast) and trying to access HD streams ?

I haven't a 'basic' Netflix account.
I looked at the options I did not see anything that could be a problem.

can you do this test?
go to the netflix via web browser,
change the language of the profile used to English,
then try play with kodi

That's exactly how I can figure that its not a stream or an account problem... I got a "blank" browser and configured the widevinecdn, connected to netflix with the same account, login, logout, login again, streamed things that won't work on the Kodi / OSMC.
So the user is set to English and I have other profiles in different languages (EN and NL here) all of them behaves exactly in the same way, works everywhere else, but not on the Kodi.
I tested on a set-top box (IPTV kinda thing), chrome browser, mobile, on different computers, multiple login at the same time... it all works fine, but not the Kodi plugin.

as soon as I find time, i'll do a test on librelec 9 too
the last time i installed librelec 9 did not want to know to create a bootable partition... bah...

I have change the language but there is no change.
Sorry

@guicel can you try to rename Userdata/addon_data/plugin.video.netflix/settings.xml to settings.xml.bak, reboot your Pi, and configure the addon again ?
Just set your email and password, and ensure HEVC and VP9 profiles are disabled.
If you still have an error, a new log might be interesting.
Btw, I assume you don't use any VPN to access Netflix right ? If you use one, please try without.

i have rename Userdata/addon_data/plugin.video.netflix/settings.xml to settings.xml.bak
I have configure the addon with my mail and pass without HEVC and VP9.
Appears the message: "Login successful"
I initially leave the ESN automatic and I had the same error.
I put the ESN from my netflix android app (NFANDROID1-PVR-.....)
But I also have the same error.
Here is the log during the last test
https://paste.kodi.tv/apometimok.kodi
I don't use vpn.
There is a week i try with a vpn (with US location) but same error

I just installed Librelec 9.01, on my old pc and netflix works perfectly,
you can always try to do a wipe and reinstall librelec

yeah,,, no..
2019-05-04 18:36:27.071 T:1936929440   ERROR: Previous line repeats 6 times.
2019-05-04 18:36:27.071 T:1936929440  NOTICE: VideoPlayer::OpenFile: plugin://plugin.video.netflix/play/show/80190843/season/80190926/episode/80190581/
2019-05-04 18:36:27.072 T:1442308976  NOTICE: Creating InputStream
2019-05-04 18:36:27.208 T:1442308976   ERROR: GetDirectory - Error getting /usr/lib/kodi/addons/inputstream.adaptive/
2019-05-04 18:36:27.903 T:1512825712   ERROR: [plugin.video.netflix (0)] Full MSL error information:
2019-05-04 18:36:27.904 T:1512825712   ERROR: [plugin.video.netflix (0)] {"entityauthdata": {"authdata": {"pubkeyid": "MSL_TRUSTED_NETWORK_SERVER_KEY", "identity": "Netflix"}, "scheme": "RSA"}, "errordata": "eyJpbnRlcm5hbGNvZGUiOjIwNTAwNywibWVzc2FnZWlkIjoxMTY0MDkyOTU2MTI0NzEwLCJlcnJvcmNvZGUiOjcsImVycm9ybXNnIjoiRW1haWwgb3IgcGFzc3dvcmQgaXMgaW5jb3JyZWN0LiIsInRpbWVzdGFtcCI6MTU1Njk5NDk4N30=", "signature": "J3+QKxeNlexNnS21Is7GJkLc2zAL2CBRsqB+hfA0KmAhT21jQIzEwIcs2jW61h8N4FnRxD/oItNAs2FPGfviuxnt4WQS9R6pvcHJU5ZbtgLbsLLj996Ya5YQSUi+s3o4G7QF3PHanrRNd6imfpnpgxX28KQPzVYnZs8ei75n7qGLYGeRGnnPdidcRTA5vwGMBKtUwCSb+XU0K99aLXe6qXod5yKTN7+XWzZXIDc/bvlppJD+ngUDIwBprQpqmi3d6e4JsT2jnps3G5PlhyHOpH/bIc+cCJ1UcC9+pGGIGc5GhTd22enuN+5qb3iTQPdrwN1cHzYTXl0u5H/VqqDYxw=="}
2019-05-04 18:36:35.843 T:1512825712   ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/http_server.py", line 47, in do_GET
                                                data = self.server.msl_handler.load_manifest(int(params['id'][0]))
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 41, in error_catching_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 237, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 109, in load_manifest
                                                manifest = self._load_manifest(viewable_id, g.get_esn())
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 237, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 195, in _load_manifest
                                                manifest_request_data, esn)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 237, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 246, in _chunked_request
                                                self.request_builder.msl_request(request_data, esn)))
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 237, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 267, in _process_chunked_response
                                                return _raise_if_error(response.json())
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/msl/msl_handler.py", line 291, in _raise_if_error
                                                raise MSLError(_get_error_details(decoded_response))
                                            MSLError: Email or password is incorrect.
2019-05-04 18:36:35.845 T:1442308976   ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 500
2019-05-04 18:36:35.845 T:1442308976   ERROR: CCurlFile::Open failed with code 500 for http://localhost:35683/manifest?id=80190581:
2019-05-04 18:36:35.845 T:1442308976   ERROR: AddOnLog: InputStream Adaptive: Cannot download http://localhost:35683/manifest?id=80190581
2019-05-04 18:36:35.846 T:1442308976   ERROR: AddOnLog: InputStream Adaptive: Could not open / parse mpdURL (http://localhost:35683/manifest?id=80190581)
2019-05-04 18:36:35.846 T:1512825712   ERROR: Traceback (most recent call last):
2019-05-04 18:36:35.847 T:1512825712   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 290, in _handle_request_noblock
2019-05-04 18:36:35.847 T:1512825712   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 318, in process_request
2019-05-04 18:36:35.847 T:1512825712   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 331, in finish_request
2019-05-04 18:36:35.848 T:1512825712   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 654, in __init__
2019-05-04 18:36:35.848 T:1512825712   ERROR:   File "/usr/lib/python2.7/SocketServer.py", line 713, in finish
2019-05-04 18:36:35.848 T:1512825712   ERROR:   File "/usr/lib/python2.7/socket.py", line 283, in close
2019-05-04 18:36:35.848 T:1442308976   ERROR: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.netflix/play/show/80190843/season/80190926/episode/80190581/]
2019-05-04 18:36:35.849 T:1512825712   ERROR:   File "/usr/lib/python2.7/socket.py", line 307, in flush
2019-05-04 18:36:35.849 T:1442308976  NOTICE: CVideoPlayer::OnExit()
2019-05-04 18:36:35.849 T:1512825712   ERROR: error: [Errno 32] Broken pipe
2019-05-04 18:36:35.956 T:1936929440  NOTICE: CVideoPlayer::CloseFile()

On LibreELEC 9.01, using the latest Daily build.
Exactly the same behavior, can login, logout, show everything correctly, but when is going to play, I got the same error. So no OSMC and no LibreELEC.. :(

I use a Pi3 and a Pi2 under LibreELEC 9.0.1 both with Netflix, and I don't have such problem...

Smeulf, have you change ESN in Addon ?

No I haven't change the ESN, but I remember I installed asciidisco's addon first, then upgrade to this version.
I'll try to set up a fresh LE9.0.1 with addon on a different SD card in the evening and set up Netflix again, just to see if I can reproduce the issue or not.
I'll report ASAP.

I have reinstall librelec9.01.
i have to install asciidisco's addon to try.
it did not work because inputstream was not installed but as it did not tell me I updated with the latest daily version of this repository. Afterall installation same error ....
But I was in the libreelec menu and I reset all the settings.
I reinstall inputstream and the daily addon directly. I put my email and my pass without changing the ESN.
It works.
I have to test by reinstalling the rest ...

@guicel nice to see you found a way to make it work!
On my side, I can't find a working micro sd card, so my test is on standby.
I'll run it starting May 13th, 'cause I'll be traveling in the mean time.
I really hope I can find the root cause and solve it definitely.

I think the reset of libreelec setting solve issues. But Why ??

There's too much possible reason...
For the record, LibreELEC soft reset basically removes all hidden directories in /storage
This includes :

.config (where LE configuration is stored)
.kodi (where Kodi conf and temporary files are stored)
.cache

So what I want to do is to reinstall LE, hope to get the same error, backup, soft reset, configure and install again, make it work, backup, and then compare both extracted backups using GIT to determine what's different.
Unless someone find a better idea/way to catch the cause of the error...

@guicel did you enabled firewall (iptable) on your setup ?
Is there some specific setting you set at initial startup ? Something special I should know about your setup to reproduce the issue ?
Thanks.

I have no activate the firewall. I activate french language ssh samba.
nothing special i think.

I now found out that there's a hidden .Kodi folder
before I couldn't find it, otherwise I'd have informed you first
Inside it there is a "cdm" folder with some widevine config files, it is possible that the cause is one of these corrupted files:
.challenge
.init
.response
eliminating them addon should return to work

since you've managed to solve it, I'm closing it

Well, I could not fix this... there is no "hidden" .kodi folder... not files inside a cdm folder (only the lib link to a another location with a different file... nothing like described.)
So yeah well... I don't find a solution for this neither on OSMC or LibreELEC.
AFAIK Netflix on Kodi henceforth is permanently broken here. :(

spectroman have you can test a reset of all setting of libreelec (in libreelec menu) and reinstall addon ?

you can see the hidden folders by browsing the disk with a linux distribution or through a shell, not using osmc sharing system

If the deletion of these files solves the problem, should it not be integrated into the reset of the addon's parameters ?

For now, it's not confirmed this operation solves the problem, unless you could reproduce the error, delete them and solve it again ?
We just know that a LE soft resetting solves it for now.
IMHO proper tests must be run to confirm the root cause and then it can be fixed.

I'm here, tested all the possible combinations on LibreELEC... Incredibly for some unknown reason, the only thing u need to do is to reinstall the plugin over.. don't even need to reset the configuration.
If you install it from scratch, he will login and list everything but he will never play, always with the same error. Just reinstall the ZIP file, makes it work, kinda magically.
There are no detectable differences on the files, in the same way, there are no such files for me, as cited by @CastagnaIT
And I know my way around linux quite well thanks, there are no such files, look:
##############################################
#                 LibreELEC                  #
#            https://libreelec.tv            #
##############################################

LibreELEC (official): 9.0.1 (RPi2.arm)
Acrux:~ # find . -iname .kodi
./.kodi
Acrux:~ # find . -iname cdm
./.kodi/cdm
./.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm
Acrux:~ # ls -lash ./.kodi/cdm
total 12
     4 drwxr-xr-x    2 root     root        4.0K May  8 19:44 .
     4 drwxr-xr-x    8 root     root        4.0K May  8 19:38 ..
     4 lrwxrwxrwx    1 root     root          88 May  8 19:44 libwidevinecdm.so -> /storage/.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm/libwidevinecdm.so
Acrux:~ # ls -lash ./.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm
total 6812
     4 drwxr-xr-x    2 root     root        4.0K May  8 19:44 .
     4 drwxr-xr-x    3 root     root        4.0K May  8 19:44 ..
  6664 -rwxr--r--    1 root     root        6.5M May  8 19:44 libwidevinecdm.so
   140 -rw-r--r--    1 root     root      136.4K May  8 19:44 widevine_config.json
Acrux:/ # find .  -regex ".*cdm.*"
./storage/.kodi/cdm
./storage/.kodi/cdm/libwidevinecdm.so
./storage/.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm
./storage/.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm/libwidevinecdm.so
./storage/.kodi/userdata/addon_data/script.module.inputstreamhelper/cdm/widevine_config.json

There is nothing to delete. After activating it, no new files appear, after resetting no files remain... if he is reinstalled, nothing changes.. but it just works, and only on LibreELEC, it doesn't work on OSMC the same method.
wow.

@spectroman .
On my rp3 with librelec (and the addon works)  I connect to libreelec with ssh.
mount -o remount,rw /flash
cd .kodi
cd cdm
ls
There are the 3 files.

@guicel under LibreELEC, no need to remount /flash to work on /storage/.Kodi
/storage is writable by default
@spectroman there's definitely 'something' different, just need to find out 'what'.
As said, I want to compare both working and not working files using Git to determine if there's a difference.
We'll find out what's wrong, for both LE and OSMC, but it might take some time.
One thing I'm thinking right now is that background services may be running while something is missing, and reinstalling the addon restarts the service. Might be an answer for LE.
Also @spectroman, can you provide a full debug log for the problem under OSMC ? Thanks.

Well, I can't reproduce the issue :/
Here with LE 9.0.1, I have no error message.
Test protocol:

Fresh LibreELEC install on a new sd card
Install and configure InputStream
Install addon from last sources
Wait for background services to start
Logon
Try to play an episode (Lucifer - S02E01) -> prompt for Windevine installation
Reboot
Play same episode : Working

Same result with OSMC, same protocol, I can't reproduce the issue, and everything is working fine here...


Test nllloss

Before
=== 227 failed, 597 passed, 1810 skipped, 2 warnings in 34.87s ===
After
=== 209 failed, 615 passed, 1810 skipped, 2 warnings in 27.66s ===
The implementation is slower than torch.NLLLoss but I had to do the indexing using a mask. Also, I only use NumPy to gather the weights but if that's a problem I could probably find another way.

If it turns things to numpy, it's not valid tinygrad.


Color types have no operators

Impl operator traits for colors in the same way as vectors.

Will be fixed by #165.


Introduce snapshot types for Test, Test.Case, and related types

This makes some of the core types which represent tests and their parameterized test cases serializable, to facilitate integration with tools.
Modifications:

Add the following snapshot types:

Test.Snapshot
Test.Case.Snapshot
Test.Case.Argument.Snapshot

Add direct conformance by Test.ParameterInfo to Equatable and Codable since it is a trivial type.

Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

Resolves rdar://91900185

@swift-ci please test


Possible alias for C++-17 unique_resource

One review suggested a different design for unique_resource, which puts default resource and deleter into template parameters. I've realised this can be easily replicated with an alias and a few helper templates: https://godbolt.org/z/aMToasrG8

Yes, I had a similar idea. This is now implemented in https://github.com/Lastique/scope/commit/d45a6255aae23fa5c2b3241a82d82455f468507f and https://github.com/boostorg/core/pull/161. If the latter doesn't get merged, I can move it here.
I still prefer to have separate templates because this allows for multiple unallocated resource values instead of just one. Windows HANDLEs are one example where this is useful.


Re-make the canonical loc the strictest

Motivation
This makes the canonical loc for a symbol the strictest loc for that symbol.
This is a revert of a revert of a PR from @jez.
Note that since the original PR, Symbol::loc was changed from having the first loc be canonical to having the last one be. So the logic had to be swapped around a bit.
Also note that the original introduced performance regressions due to accidental quadratic-ness, so this one should be tested to make sure the source of those regressions is well and truly gone.
Related: #2873 (the original), #2922 (the revert).
Test plan
Yep.

Also related is #3096 specifically
https://github.com/sorbet/sorbet/pull/3096/files#diff-3bcaf008cecaa72337787c9af545fcd6R1057-R1060
^ we no longer call addLoc for Symbols::root()

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HpQWiqWJMKbxr1

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HxLM3CInCXk58F

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IDq7ibvbixO3VC


Fixes unit tests requiring \r\n to pass

Looks like the change to .gitattributes in #296 ended up breaking these unit tests.
This reverts that change, however we should probably do something else to guarantee that this doesn't happen again.

Hmmmm build failed.  Need to look into how to really "clean" the repo, so that all new files will be checked out (not using the cached ones which are all LF)
I don't know AppVeyor very well.  @domaindrivendev, is that something you know how to do?

Looking at the AppVeyor output:
git config --global core.autocrlf true
git clone -q https://github.com/domaindrivendev/Swashbuckle.AspNetCore.git C:\projects\ahoy
git fetch -q origin +refs/pull/432/merge:
git checkout -qf FETCH_HEAD
I'm wondering if the initial checkout is doing the real work, and the fetch/checkout of the merge doesn't really update the files.
I've tested this locally, and with my own build on AppVeyor, and it seems to have been fixed.
https://ci.appveyor.com/project/cfeilen/swashbuckle-aspnetcore/build/1.0.0-build3


Create packaging Github Action

References #20

[ ] use the github action template for packaging to pyPI
[ ] set up configurations after researching necessary configurations to package the project for pip install
[ ] test the action by creating a release in github and trying to pip install

Attempted to fix some changes with previous yml script (Git Action)
Added a build section to the Git Action
Next planning on linking the build with pyPI so that I can pip install the package

[t:90]

The process for creating a new python package is a bit more tedious then we expected. First we will (or at least someone will) need a pyPI account (test PyPI, an experimental version is okay too).
I managed to walk through a tutorial involving setting up a public pypackage successfully.
I did run into a little bit of trouble with pip that I needed to fix, costing time.

For the future, we will need to change the directory of our project so that it matches up appropriately with the way the package builder expects it to.
I plan to use Test pyPI instead of the actual pyPI.

[t:120]

completed with #38


Feature: Extend ZodObject with modified version of existing element

Hello, is it possible to extend the original shape but check that the keys are taken from origin.
For example i have such shape in module scope:
const SomeData = z.object({
  test: z.string(),
  test1: z.number(),
})

Add i would like to add more rules to this object (the API can be smth different)
function MyForm() {
  const t = useTransition()
  const FormValues = SomeData.deepMerge({ test1: z => z.min(10, { message: t.form.numCheck }) })
  const form = useForm({ resolver: zodResolver(FormValues) })

  return <>{/* do smth with form */}</>
}

And the TS will autocomplete the test1 prop.
The case when it is needed is when you want to use the localization in i.e. React components because usually the translations are available in React context and not in global scope. Technically i can use the translation from some global object and use it when defining SomeData, but the issue will be is that when i change the language the error message will be the same because they are hardcoded and cannot react the translation change.

I've considered something like this for a long time. I'd probably call it .mapKeys or something. For now I haven't implemented it becauase there's a pretty convenient workaround:
const FormValues = SomeData.extend({
  test1: SomeData.shape.test1.min(10, { message: t.form.numCheck })
})

@colinhacks thanks, yes that is pretty good workaround, the one thing that would be nice to have is autocompletion and checking that extended object is compatible with "super" object.


Should flag Example default to True?

https://github.com/UnkindPartition/ansi-terminal/blob/2a4a6d89980801ae353fb573753d6205f90115e7/ansi-terminal/ansi-terminal.cabal#L28-L30
I am getting:
$ cabal run ansi-terminal-example
...
Error: cabal: Cannot run the executable 'ansi-terminal-example' because it is
marked as 'buildable: False' within the 'ansi-terminal.cabal' file (at least
for the current configuration). If you believe it should be buildable then
check the .cabal file to see if the buildable property is conditional on
flags. ...

So I have to type cabal run -f+example ansi-terminal-example.
Would there be any drawback to default flag example to True?
Wouldn't users that have build-depends: ansi-terminal still only get the library as before?

I think the drawback of the flag defaulting to true is that the example executable would be built when it is not wanted, including when ansi-terminal is specified as a dependency. Most people building the package have no need for the executable binary, which acts both as a test of the library and a tutorial (although in the latter case, the source code is more useful than the binary).

example executable would be built when it is not wanted, including when ansi-terminal is specified as a dependency.

Is that so?  My experiment suggests otherwise.
Package BNFC has a library and an executable.  If I build-depends on it, only the library is built.
E.g. this depend-on-bnfc project:
cabal-version: 3.0
name: depend-on-bnfc
version: 0

executable depend-on-bnfc
  main-is: DependOnBNFC.hs
  build-depends:
    , base
    , BNFC

Building it does this:
$ cabal build
Resolving dependencies...
Build profile: -w ghc-8.10.7 -O1
In order, the following will be built (use -v for more details):
 - alex-<IP_ADDRESS> (exe:alex) (requires build)
 - string-qq-0.0.4 (lib) (requires build)
 - BNFC-<IP_ADDRESS> (lib) (requires build)
 - depend-on-bnfc-0 (exe:depend-on-bnfc) (first run)

So it does no build BNFC (exe:bnfc), just the library.
For reproducibility, here also DependOnBNFC.hs:
import BNFC.CF

main :: IO ()
main = putStrLn "Executed DependOnBNFC"

Since you are the stack maintainer, maybe you were thinking in terms of stack build.  So, I extended my experiment to stack with:
echo "resolver: lts-19.33" > stack.yaml
stack build

Indeed, stack also builds the executable:
...
Building executable 'bnfc' for BNFC-2.9.4..
...
BNFC          > Installing library in .../BNFC-2.9.4-...
BNFC          > Installing executable bnfc in /Users/abel/.stack/snapshots/x86_64-osx/49df129ff59db6386b73253188faa0d52d9b6b3cef1403a4dddbb8782f3c0978/9.0.2/bin

Isn't this an error on the side of stack?
If I want the executable, I need to specify build-tool-depends: BNFC:bnfc.
build-depends: BNFC should really only build the library.

I did have in mind Stack. Its online help explains "With dependencies, Stack will always build the library (if present) and all executables (if any), and ignore test suites and benchmarks." and my experimentation suggested that was accurate.
Whether or not that is a 'bug' in Stack, I'll have to investigate further. Stack aims to support Cabal <IP_ADDRESS> and I am concious that build-tool-depends was first introduced with Cabal 2.0. It may be a backwards-compatability thing.

Ok, maybe then this is blocked upstream.  Once stack changes its build strategy and fully embraces build-tool-depends, it can be revisited.

Cabal-<IP_ADDRESS> first shipped with GHC 8.2.1. LTS 10.0 provided GHC 8.2.2 on 2017-12-19, replacing LTS 9.21 (GHC 8.0.2). That means that Stack will fully embrace build-tool-depends from 2024-12-19, given its 'seven years' approach to backwards compatability.

This is not a bug in stack.  cabal-install used to behave the same way until somebody decided to introduce a breaking change. While the new behavior is not bad per se, it broke a lot of code. At that time stack decided to not follow that breaking change.
@mpilgrem of course, you can reevaluate at some point, just be aware that this will affect a lot of people, especially in house projects that use hspec-discover.
Personal opinion: Breaking other peoples code for minor gains is never a nice thing to do.
I think at this point, it's no secret anymore that this "let's randomly break stuff" mentality is one of the contributing factors to Haskell's decline.

I agree that one should err on the conservative side rather than on the progressive.
However, it is also desirable that the Cabal language has just one semantics, not two different ones.
It so happened that build-tool-depends was split off build-depends because the latter was not precise enough (ambiguity between depending on the library or the executable).  Removing this ambiguity is per se a good thing.
Is there a problem with build-tool-depends: hspec-discover?


Use symlinked controllers to provide a distinct prefix in the console

The idea here is that each robot has its own controller, but in the repo they share the same source code.
In theory at least, symlinks are cross platform (ish) having been part of Windows 10 for a number of years now. Obviously it's possible that some users are using older versions of Windows, though hopefully not many.
The main potential issue I see here is whether the symlinks survive being included in the archive which GitHub creates for us. This probably just needs someone to test unzipping the archive of this branch on Windows 10.
I have checked that this works for a robot.py in the default location (for zone 0) and in the zone-1 location.

The ZIP file GitHub generate from this branch doens't work on windows. It places text files containing the relative path rather than symlinks.
We can solve this by building a zip file ourselves which will replaces the symlinks with actual files, but I don't know whether the symlinks work on windows on a plain checkout


Metadata DisplayName LocalizedLabels sometimes null

Hi, we are trying to get attribute display names of certain entities via metadata requests. Sometimes (but not always) the requests doesn't return the LocalizedLabels. We tried multiple ways to get the metadata, for example with the RetrieveMetadataChangesRequest, but the behaviour stays the same. An example request looks like this:
ServiceClient client = new ServiceClient("AuthType=ClientSecret;Url=ZZZ;ClientId=XXX;ClientSecret=YYY");
if (client.IsReady)
{
    client.ResetLocalMetadataCache("contact");
    var attr = client.GetEntityAttributeMetadataForAttribute("contact", "address2_line1");

    RetrieveMetadataChangesRequest retrieveMetadataChangesRequest = new RetrieveMetadataChangesRequest();

    var attrCriteria = new MetadataFilterExpression();
    attrCriteria.Filters.Add(new MetadataFilterExpression()
    {
        Conditions =
        {
            new MetadataConditionExpression("LogicalName", MetadataConditionOperator.Equals, "address2_line1")
        }
    });

    attrCriteria.Filters.Add(new MetadataFilterExpression()
    {
        Conditions =
        {
            new MetadataConditionExpression("IsRetrievable", MetadataConditionOperator.Equals, false)
        }
    });

    retrieveMetadataChangesRequest.Query = new EntityQueryExpression()
    {
        Criteria = new MetadataFilterExpression()
        {
            Conditions =
            {
                new MetadataConditionExpression("LogicalName", MetadataConditionOperator.Equals, "contact")
            }
        },
        AttributeQuery = new AttributeQueryExpression()
        {
            Criteria = attrCriteria,
            Properties = new MetadataPropertiesExpression()
            {
                AllProperties = true
            }
        },
        Properties = new MetadataPropertiesExpression()
        {
            AllProperties = false,
            PropertyNames = { "Attributes" }
        }
    };

    RetrieveMetadataChangesResponse response = client.Execute(retrieveMetadataChangesRequest) as RetrieveMetadataChangesResponse;

    var result = response.EntityMetadata[0];
    var labels = result.Attributes[0].DisplayName.LocalizedLabels; //labels.Count sometimes 0

    //same behaviour as before:
    //RetrieveEntityRequest req = new RetrieveEntityRequest();
    //req.LogicalName = "contact";
    //req.RetrieveAsIfPublished = false;
    //req.EntityFilters = EntityFilters.Attributes;

    //RetrieveEntityResponse response = client.Execute(req) as RetrieveEntityResponse;

    //var attr = response.EntityMetadata.Attributes.Where(a => a.LogicalName=="address2_line1").First();

    //while (attr.DisplayName.LocalizedLabels.Count <= 0)
    //{
    //    RetrieveAttributeRequest request = new()
    //    {
    //        EntityLogicalName = "contact",
    //        LogicalName = "address2_line1"
    //    };
    //    var response2 = (RetrieveAttributeResponse)client.Execute(request);
    //    attr = response2.AttributeMetadata;
    //}
}

Are you seeing this inconsistently for the same entity/attribute in the same environment?
if so, that would be something we would want to have a support ticket opened with a request ID so that the environment itself can be investigated.

Going to close this at this time.
This would need to be taken up with support.


Fails installation on Windows Server

I'm submitting a Installation issue
[X ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Installing according to tutorial

Expected result (what you hoped would happen)
Installed package

Actual result (unexpected outcome)

node-pre-gyp install --fallback-to-build

node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.11/node-v59-win32-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v59 ABI) (falling back to source compile with node-gyp)

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

Looks like the amazonws.com file is not available :

AccessDenied
Access Denied
62691D66225060E0

7VN8x2XXBiSRdOXetAP2rLeo5gXCypHl+LOLonKKXP7aSok6eFvYN0pfroGcorCJ+nlv6/+iynY=

Same problem here on Debian 9:
node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.11/node-v59-linux-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v59 ABI) (falling back to source compile with node-gyp)
wget https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.11/node-v59-linux-x64.tar.gz  also gives a 403.


Docker swarm not working on Microsoft Azure

I'm trying to get Docker Swarm running on Azure and it seems to be "half" working.  By this I mean I can create the swarm, join all the nodes to the swarm, manage/start the swarm, and the IP/ports show up correctly with "swarm list".  However when I do an "info" to the swarm manager port, on the system running the swarm manager, the manager reports no nodes.
I'd try to look in the log files, but I can't seem to find them :-(
Thank in advance.

Mark

Hi @mpilant, both issues (with #1096), look like you are not configuring TLS correctly thus the Manager cannot contact the Swarm Agents and get back informations to list those nodes in docker info.

Hi @abronan. At the moment, I have Docker configured to use TLS, and I can it to remotely interact with the individual nodes without any problems. So I believe it is configured properly. The problems seem to be with trying to set up a swarm. This is one area where the documentation I have found (from Docker, Microsoft, etc.) is really pretty poor. Almost all is really good at describing the commands to use not not very good at describing what the arguments and options of the command are given and what they are supposed to do.  (Same as #1096.)

  I did this mainly to make sure I could in fact deploy a working swarm.  The major difference is my local deployment did not use TLS/certificates for communications where the Azure Docker VM extension does.
Attempting to replicate the deployment, so far, has met with failure.  But, it does appear to be certificate related.  Not with the certificates used to communicate with Docker, but the certificates (or lack thereof) swarm uses.
Still investigating.

Well, some more progress; after a fashion.
I just finished trying to create a swarm on Microsoft Azure using Docker Machine on an Ubuntu 14.04 LTS system.  I created three VMs: a swarm master and two swarm nodes.  (Using the information here: https://github.com/chanezon/azure-linux/blob/master/docker/swarm.md.)  The results were not encouraging.
All of the VMs were created successfully, the swarm was created and only one node was joined to the swarm (doing a ps -a on the swarm manager showed only one swarm join done).  Using "swarm list" showed all three VMs as expected, but doing an "info" on the swarm manager VM (as per the web page) did not show any nodes in the swarm.  This is the same thing I had happen trying to set up a swarm using the Azure CLI.
Given my recent Azure / Docker experiences, I'm assuming "something" has been broken, and will probably be fixed "sometime" in the future.  But for now, unless someone can demonstrate otherwise, my testing seems to indicate Docker Swarm is broken on Microsoft Azure.

@mpilant when using Docker Machine to spin up the swarm did you open 3376 endpoint in Azure manually? Docker Machine does not configure the endpoint for the swarm master - here is my pull request that enables this to happen automatically: https://github.com/docker/machine/pull/1647

@agup006 Yes, I opened port 3376.
I don't think this exclusively a port problem.  I was getting very similar results when I was trying to manually set up a swarm using just the Azure CLI or the Azure portal (create VMs) and Azure CLI (using Docker).

Given a couple of the subtle (unannounced) changes accompanying the new Docker VM Extension which cause me a great deal of grief, it would not at all surprise me if there are other bugs (sorry, undocumented features :-) as well.  Of course they may be completely unrelated.

@mpilant what version of machine are you using, and what Azure Region? I was able to run "docker info" for my Ubuntu 14.04 Docker Swarm with no similar issue
docker info
Containers: 5
Images: 6
Role: primary
Strategy: spread
Filters: affinity, health, constraint, port, dependency
Nodes: 4
 anugup-swarm-01: anugup-swarm-01.cloudapp.net:2376
  └ Containers: 2
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.721 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-36-generic, operatingsystem=Ubuntu 14.04.1 LTS, provider=azure, storagedriver=aufs
 anugup-swarm-02: anugup-swarm-02.cloudapp.net:2376
  └ Containers: 1
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.721 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-36-generic, operatingsystem=Ubuntu 14.04.1 LTS, provider=azure, storagedriver=aufs
 anugup-swarm-03: anugup-swarm-03.cloudapp.net:2376
  └ Containers: 1
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.721 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-36-generic, operatingsystem=Ubuntu 14.04.1 LTS, provider=azure, storagedriver=aufs
 anugup-swarm-04: anugup-swarm-04.cloudapp.net:2376
  └ Containers: 1
  └ Reserved CPUs: 0 / 1
  └ Reserved Memory: 0 B / 1.721 GiB
  └ Labels: executiondriver=native-0.2, kernelversion=3.13.0-36-generic, operatingsystem=Ubuntu 14.04.1 LTS, provider=azure, storagedriver=aufs
CPUs: 4
Total Memory: 6.884 GiB

@agup006 I am trying to run in the East US region.
Docker-machine was downloaded this morning and is  0.4.0-rc2 (c2b5f06).

My problems could very easily be something I am doing incorrectly.  However, from all of the examples I have seen (Azure CLI or docker-machine) I have not been able to spot what I might be doing wrong.

@agup006 Question: is this swarm one you had previously created or was it recently (say the past several days) created?

@mpilant This was a swarm I created yesterday, in the West US Region. I'll give East US Region a try with the version mentioned and see if I can repro.
docker ps -a
CONTAINER ID        IMAGE               COMMAND                CREATED             STATUS              PORTS                                    NAMES
d4b8cf6548c0        swarm:latest        "/swarm join --addr    16 hours ago        Up 16 hours         2375/tcp                                 anugup-swarm-02/swarm-agent
4bbb36bf7e56        swarm:latest        "/swarm join --addr    16 hours ago        Up 16 hours         2375/tcp                                 anugup-swarm-04/swarm-agent
ca9454ea0ede        swarm:latest        "/swarm join --addr    16 hours ago        Up 16 hours         2375/tcp                                 anugup-swarm-03/swarm-agent
6ba69ebeec82        swarm:latest        "/swarm join --addr    16 hours ago        Up 16 hours         2375/tcp                                 anugup-swarm-01/swarm-agent
8311b5abc7ab        swarm:latest        "/swarm manage --tls   16 hours ago        Up 16 hours         2375/tcp, XXX.XXX.XXX.XXX:3376->3376/tcp   anugup-swarm-01/swarm-agent-master

@agup006 Interesting.  If you could put together a list of the commands you used I'll compare it with what I tried to see if I can spot any differences.  I have no problem being proven wrong :-P

@mpilant Sure I'll put together a list of steps and send that out later tonight, hopefully can get this resolved :)

Hi @mpilant  I put together a blog post over docker swarm. Let me know if you find it useful: http://agup.tech/docker-machine-docker-swarm-azure-walkthrough/

Sorry for catching up late on this, thanks for the blog post @agup006! This might help a lot of people running docker on Azure and willing to setup a Swarm.

@agup006 Well, still not working but I did uncover some interesting things.
First, after I cleaned out all the VMs, cloud services, etc. from previous testing (there were no resources listed by the Azure portal for the subscription), when I attempted to create a new VM (using docker-machine), I could not because docker-machine said the name was in use.  So it would appear this information is persisting somewhere other than Azure,  Whether on the local machine or somewhere else on the Internet I do not know.
Second, I created all swarm VMs using the swarm ID from one of my previous tests.  Using "docker-machine ls" reports all of the VMs which have every used that ID.  So it would also appear here this information is persisting somewhere... local or the Internet I don't know.
Third, once all the VMs are part of the swarm, it is a bit (10-15 seconds) before "docker-machine ls" reports the systems as running.
Is the 3376 endpoint still needed?  It isn't mentioned in the blog post.  (I did add it, just in case.)
Because this problem feels like a certificate problem, I recreated the certificate to be uploaded to Azure.  The CN of the certificate was the DNS name of the swarm master.  This didn't seem to help at all.
So I'm going to try and start all over, creating a new swarm to get a new swarm ID, and then try the steps in your post again.  BTW, here are the docker-machine commands I used:
docker-machine create -d azure
--azure-subscription-id "AZURE_SUBSCRIPTION_ID"
--azure-subscription-cert "/home/auser/mycert.pem"
--swarm --swarm-discovery token://SWARM_ID
--swarm-master lmp-swarm-master-a
docker-machine create -d azure
--azure-subscription-id "AZURE_SUBSCRIPTION_ID"
--azure-subscription-cert "/home/auser/mycert.pem"
--swarm --swarm-discovery token://SWARM_ID
lmp-swarm-node-b
docker-machine create -d azure
--azure-subscription-id "AZURE_SUBSCRIPTION_ID"
--azure-subscription-cert "/home/auser/mycert.pem"
--swarm --swarm-discovery token://SWARM_ID
lmp-swarm-node-c
With my Azure subscription ID and swarm ID substituted as appropriate.

@mpilant I accidentally made two Swam Masters and found a similar behavior to what you mentioned. Is it possible the Swarm Token is no longer valid? Definitely try regenerating that token and let me know what you get.
Also definitely forgot 3376 part for the blog, thanks

@mpilant Also as a double check -- in Azure the service and VM were both removed?

"docker-lachine ls" persisting information answer: On my local system, I found a number of directories in ~/.docker/machine/machines/ containing information for test systems I  had previously created and removed.  I just cleaned out all the directories (as well as the files in ~/.docker/machine/certs/) and started to create the swarm again.

Ah, removing hosts with  docker-machine rm is really nice as it will remove the service and VM from Azure.

OK.  Still no joy.  Here is what I did:
export SWARM_ID="NEW_SWARM_ID"
export AZURE_ID="AZURE_SUBSCRIPTION_ID"
openssl req -x509 -nodes -days 365 -newkey rsa:1024 -keyout mycert.pem -out mycert.pem
openssl pkcs12 -export -out mycert.pfx -in mycert.pem -name "My Certificate"
openssl x509 -inform pem -in mycert.pem -outform der -out mycert.cer
docker-machine create -d azure
--azure-subscription-id $AZURE_ID
--azure-subscription-cert /home/auser/mycert.pem
--swarm --swarm-discovery=token://$SWARM_ID
--swarm-master foo-swarm-master
docker-machine create -d azure
--azure-subscription-id $AZURE_ID
--azure-subscription-cert /home/auser/mycert.pem
--swarm --swarm-discovery=token://$SWARM_ID
foo-swarm-node-01
docker-machine create -d azure
--azure-subscription-id $AZURE_ID
--azure-subscription-cert /home/auser/mycert.pem
--swarm --swarm-discovery=token://$SWARM_ID
foo-swarm-node-02
Again, the CN for the cert is foo-swarm-master.cloudapp.net, so I don't think the cert is the problem.
Can you spot anything I've screwed up?  (I've been staring at this for so long, I may be missing something obvious.)

This was done after cleaning out everything from Azure.

Curiously, only one of the two swarm nodes appear to have been joined to the swarm.  In other words, a "docker ps -a" to the swarm master system shown only the "swarm manage" container and a single "swarm join" container.  (When I created a swarm locally, there was one for each swarm node.)

The CN for my cert is blank, but I'm not sure if having a CN set to something else would cause any of this -- as long as the cert is the same one uploaded in the Azure management portal. The commands look good from my point of view, nothing standing out.

@agup006 OK.  The cert was the same one uploaded to the management certificates.  I'll blow away everything... again :-P and try the same thing with a blank CN.

This is really strange.  Yesterday I cleaned out all of the "old" testing from Azure and my host system and started to create a new swarm using a blank CN in the certificate.  Finishing up this morning, I'm getting the same result as earlier: docker-machine ls originally showed the systems as running and now shows them all as "Timeout", docker ps -a on the swarm master VM only shows one of the two created swarm nodes as having joined the swarm, swarm list shows all the systems as expected, and docker info does not show any cluster information.
I think it may be useful to let this all sit for the weekend and try again Monday.  Maybe it will work because the phase of the moon is different :-P

@mpilant We are getting there :ghost:
I'd really suspect a connectivity issue somehow because it seems now that you are doing it right with certs. Make sure that the remote docker daemons are available over TCP, well set up with certs, and that the correct ports are open. Also check ufw or iptables rules.
swarm list only requests the node list from the Token Service or the backend K/V store. Thus, having it list entries does not mean that the manager can contact remote nodes. If docker info does not show any node entry or an incomplete list of nodes: this is very likely that there is a connectivity issue from the Manager to some of the nodes :)

@abronan It is almost certainly a connectivity issue, but where is the big question.  In this case, and others, I can interact directly with the Docker daemon on the VMs.  It is only the swarm manager which appears to be having problems.  In other words, I can do a "docker ps -a" to each of the individual VMs and get back the expected results.  However Docker swarm doesn't work properly.
BTW, this is exactly the same problem I was having when I was creating the swarm manually as opposed to using docker-machine.

Solution: Use a different Azure subscription.  For some reason, it appears my corporate Azure subscription has "limitations".  Using my MSDN Azure subscription I was able to successfully create a swarm using the blog entry from @abronan (thank you very much).
Unfortunately, this is not the first time I have seen this "problem".  So my next task is to find out how to compare the features and capabilities of two different Azure subscriptions.  But that is not for this forum :-)

Super Interesting -- I wonder if there is difference in the provisioning return output from that subscription. Might even be an administrator setting set for that account? I'll keep plugged in as I'm interest myself :).


Update autoFormat to support trailing lambda well

Talked with @knutwannheden about the approach  https://github.com/openrewrite/rewrite-kotlin/pull/253.
we probably don't want to introduce a new Infix marker here.
This is an alternative solution to PR https://github.com/openrewrite/rewrite-kotlin/pull/253 without introducing a new Infix marker.
Currently, there is one test failing (see below), I think it should be covered by parsing improvement, moving the space after the comma in e, -> println(e)  from marker TrailingComma.suffix to the lambda arrow.
    @Test
    void trailingLambdaWithParamTrailingComment() {
        rewriteRun(
          kotlin(
            """
              val x = listOf(1).forEach { e, -> println(e) }
              """
          )
        );
    }

@kunli2 Thanks for this alternative. I will try to see if I can combine the two PRs into one. While adding Infix adds some complexity, I think it is the right thing to do, because an infix function does not have to be an extension function and down the line we may have to keep them separate. So I will try to keep that part from my PR.


Sequencer API impl: mongo & Leaf

What would you like to be added:
Add Sequencer API component: mongo & Leaf
See #108
Why is this needed:

This task will be assigned to @stulzq

ok

ok

Hi @stulzq ,are u still working on it ? Or should I reassign it to others if you don't want to do it?

Hi @stulzq ,are u still working on it ? Or should I reassign it to others if you don't want to do it?

reassign it to others


Ending a line with a semicolon in an @code block results in loss of indentation

This doesn't happen if change @code to @function.
@rynowak @NTaylorMullen @ajaybhargavb

I can reproduce this as well. This is so weird. @NTaylorMullen do we special case functions anywhere in our tooling? Or maybe WTE special cases it?

I wonder if Roslyn special cases it.... @heejaechang - does Roslyn have knowledge or special case formatting logic for @functions?

@NTaylorMullen please follow up on this - as this is most probably external. If we happen to get the fix earlier, that's great!

@NTaylorMullen please follow up on this - as this is most probably external. If we happen to get the fix earlier, that's great!

Yup, already have an email thread where @bhsubra / @ToddGrun are taking a look.

how can I repro this ? which VS should I use?

@heejaechang You'll need VS 16.2 P2 and .NET Core 3.0 Preview 6 (latest public previews of both). See https://blazor.net -> Get Started for full setup instructions.

I've verified @heejaechang's fix for this locally and all works as expected. Talked with @jinujoseph and she mentioned that the change should be merged soon.
Expected delivery of the fix is 16.2-preview4.

@heejaechang and @jinujoseph thank you for the quick turnaround on this!


Support for pulling from private registry

Currently it only supports pulling a name, implemented in #349, but it does not take in the parameters from docker remote api.
https://docs.docker.com/reference/api/docker_remote_api_v1.20/#create-an-image

Closing due to lack of activity. Please reopen if you wish to continue discussing it.


Unable to install chip-io

Would you be able to assist in an issue I'm having installing chip-io? I've completed all of the instructions you have but still get errors. I'm also running the most current version of node and npm. Here is the output...
chip@chip:~/Documents/sandbox/nodetest01$ npm install chip-io
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
\

<EMAIL_ADDRESS>install /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref
node-gyp rebuild

/bin/sh: node: command not found
gyp: Call to 'node -e "require('nan')"' returned exit status 127. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: gyp failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/share/node-gyp/lib/configure.js:344:16)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:809:12)
gyp ERR! System Linux 4.3.0
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref
gyp ERR! node -v v0.10.29
gyp ERR! node-gyp -v v0.12.2
gyp ERR! not ok
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian
npm ERR! Error: ENOENT, utime '/home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ffi/deps/libffi/testsuite/libffi.call/cls_4byte.c'
npm ERR! If you need help, you may report this entire log,
npm ERR! including the npm and node versions, at:
npm ERR!     http://github.com/npm/npm/issues
npm ERR! System Linux 4.3.0
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "chip-io"
npm ERR! cwd /home/chip/Documents/sandbox/nodetest01
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.21
npm ERR! path /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ffi/deps/libffi/testsuite/libffi.call/cls_4byte.c
npm ERR! fstream_path /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ffi/deps/libffi/testsuite/libffi.call/cls_4byte.c
npm ERR! fstream_type File
npm ERR! fstream_class FileWriter
npm ERR! fstream_finish_call utimes
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR! fstream_stack /usr/lib/nodejs/fstream/lib/writer.js:305:19
npm ERR! fstream_stack Object.oncomplete (evalmachine.:107:15)
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the ref package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls ref
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 4.3.0
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "chip-io"
npm ERR! cwd /home/chip/Documents/sandbox/nodetest01
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/chip/Documents/sandbox/nodetest01/npm-debug.log
npm ERR! not ok code 0
chip@chip:~/Documents/sandbox/nodetest01$

I think I know what it is now. I'm going to try adding a symlink of node. Right now I only have nodejs as a command.

That didnt work. Here is my new error log from the terminal...
chip@chip:~/Documents/sandbox/nodetest01$ npm install chip-io
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data

<EMAIL_ADDRESS>install /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref
node-gyp rebuild

make: Entering directory '/home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref/build'
CXX(target) Release/obj.target/binding/src/binding.o
In file included from ../src/binding.cc:7:0:
../node_modules/nan/nan.h:330:47: error: 'REPLACE_INVALID_UTF8' is not a member of 'v8::String'
static const unsigned kReplaceInvalidUtf8 = v8::String::REPLACE_INVALID_UTF8;
^
binding.target.mk:82: recipe for target 'Release/obj.target/binding/src/binding.o' failed
make: *** [Release/obj.target/binding/src/binding.o] Error 1
make: Leaving directory '/home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref/build'
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/share/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:809:12)
gyp ERR! System Linux 4.3.0
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ref
gyp ERR! node -v v0.10.29
gyp ERR! node-gyp -v v0.12.2
gyp ERR! not ok
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

<EMAIL_ADDRESS>install /home/chip/Documents/sandbox/nodetest01/node_modules/chip-io/node_modules/ffi
node-gyp rebuild

gyp ERR!  System Linux 4.3.0
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "rebuild"
/usr/lib/nodejs/graceful-fs/polyfills.js:8
cwd = origCwd.call(process)
^
Error: ENOENT, no such file or directory
at process.cwd (/usr/lib/nodejs/graceful-fs/polyfills.js:8:19)
at errorMessage (/usr/share/node-gyp/bin/node-gyp.js:119:28)
at issueMessage (/usr/share/node-gyp/bin/node-gyp.js:125:3)
at process. (/usr/share/node-gyp/bin/node-gyp.js:109:3)
at process.emit (events.js:95:17)
at process._fatalException (node.js:272:26)
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the ref package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls ref
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 4.3.0
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "chip-io"
npm ERR! cwd /home/chip/Documents/sandbox/nodetest01
npm ERR! node -v v0.10.29
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/chip/Documents/sandbox/nodetest01/npm-debug.log
npm ERR! not ok code 0
chip@chip:~/Documents/sandbox/nodetest01$ node -v
v0.10.29
chip@chip:~/Documents/sandbox/nodetest01$ nodejs -v
v0.10.29

Ok, sorry for any time wasted. I realized that I didn't install the debian nodejs. As soon as I corrected this mishap, I was able to install chip-io and johnny-five successfully. Hopefully my errors help someone else.
Also, thanks very much for taking the time to put together this package!
Ryan

@RyanOC no worries, great to see that you found a solution.
Let me know if the instructions in the read me can be clarified, so others don't run into this.


fix launcher for android

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#1098
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Icon launcher was broken on some devises cause, we were missing a file.
@JGDoh  can you please double check with your phone that this works.
🙈 Screenshots

👯♀ Paired with
"nobody"

OPPO RENO 5

OPPO RENO 5

Thank you Raul (:


Update maven-plugin-annotations to 3.11.0

About this PR
📦 Updates org.apache.maven.plugin-tools:maven-plugin-annotations from 3.9.0 to 3.11.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.maven.plugin-tools", artifactId = "maven-plugin-annotations" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.maven.plugin-tools", artifactId = "maven-plugin-annotations" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #254.


Configurable Drop Cursor

The styles are hard-coded at the moment

Yep. Would also be nice to be able to define where a node can be dropped. And choose matching cursors (droppable <> not droppable here)

Excellent idea @barbalex . The drop cursor renderer can be given the "can drop" boolean to render something different in those cases.

The drop cursor renderer can be given the "can drop" boolean to render something different in those cases.

Is that an idea or can that be done currently? If so: how?

I think tha last missing piece is to know what the dragged node is hovering over.
Only thing I found was isHoveringOverChild. In my case I would need to know if it was hovering over siblings. Or a more general solution: get the hovered node's data.

Makes sense, I'll update this thread when I implement this ticket.

This one: https://github.com/barbalex/capturing
An app to collect data outside of the office, alone or in teams. Universal, offline, deals well with conflicts. Well, that is the basic idea.
I have other apps like https://github.com/barbalex/vermehrung, https://github.com/barbalex/apf2 and https://github.com/barbalex/ae2 that also use navigation-trees.


Background service HOWTO

Subproblems to tackle in order to run a COM server as a background service that is auto-started when Windows boots.
How to start a COM server as a background service
Use the ServiceWrapper project in this repo to start a COM EXE as a Windows service. Instructions can be found in https://github.com/forderud/ComSamples/blob/main/ServiceWrapper/README.md
Might need to tweak settings to run with the desired user.
You also need to ensure that the selected user account has sufficient filesystem access to the executables in question.
How to adjust COM server registration
You still need to register the COM server to register the type libraries.
Read COM elevation to learn how to configure the COM server to start using an explicit user account or in-built accounts by configuring the RunAs registry parameter.
Example approaches:

Either add val RunAs = s 'nt authority\localservice' to AppID.rgs before building the project, or
Run ComRunAs.exe {AF080472-F173-4D9D-8BE7-435776617347} "nt authority\localservice" after registration.

The RunAs user account needs to match the account used to run the service.
How to make the COM server outlive its clients
C++: Call CoAddRefServerProcess to leak a process reference, so that the COM server outlives all clients (already implemented in MyExeServerCpp)
C#:  See sleep call in MyExeServerCs
Relevant documentation

Service Programs - also covers ServiceMain entry-point
Service User Accounts - description of the in-built Windows accounts
Create a user-defined service - also covers the outdated Srvany.exe tool
CAtlServiceModuleT - untested alternative to CAtlExeModuleT for C++-based servers that could eliminate the need for ServiceWrapper.

Closing task as done. The instructions are indexed by GitHub and therefore accessible for later reference.


COM port error

Probably since version 2.0.37, ioSender has a special error when creating a default configuration. After editing App.config to:
COM6:115200,N,8,1
everything works. This may apply to specific Windows language versions ..

Can you try the latest edge version? It looks like there is a superfluous space after the reported com port name messing up.

2.0.41p2 Edge - left picture NOT WORKS
2.0.41p2 XL Edge - right picture - WORKS

Looks like the update somehow went wrong, I have now uploaded a new edge version that should be ok.

You can close this thread, both 2.0.41p3 versions are working now.


Fix minor spelling in ITracer

I noticed a minor spelling that I thought I should fix as an early christmas gift and as a thank you for this package! 🎅

Thanks!


confusing documentation

Q
A

Bug?
no

New Feature?
no

Version
6

it is mentioned at the document of this version (check the link) that Guzzle is no longer depend on cURL, but there are many classes which use cURL functions. may you please update the document ?
link : here

Just one line above the referenced sentence (and the rest of the referenced note) explains the situation perfectly: Guzzle no longer requires cURL (meaning: it's not a hard dependency) to run (compared to past versions) as it has a stream handler now.
When cURL is not available, Guzzle silently falls back to the stream handler. The fact that there is cURL related code doesn't mean that Guzzle won't work without it.
I'm sorry, but there is no wrong information here and honestly I don't find this part confusing. I hope my answer cleared the confusion for you.


Allow the ability to specify which artifactory to download dep from

Motivation
For runtimes where we allow users to install usercode dependencies on the fly(currently only for python), users might want to specify the location of an artifactory to download these dependencies from. This pr allows them to specify that in functionConfig.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.

@srkukarni One point raised by @cckellogg was that one might want to use multiple repositories.
One such example is:

I have my internal dependencies in private repo
I still want to fetch other dependencies from public PyPI

In pip, there are 2 possible URLs to pass:
Package Index Options:
  -i, --index-url <url>       Base URL of Python Package Index (default https://pypi.org/simple). This should point to a repository compliant with PEP 503 (the simple repository API) or a local directory laid out in the same format.
  --extra-index-url <url>     Extra URLs of package indexes to use in addition to --index-url. Should follow the same rules as --index-url.

@merlimat added an extra option to specify the --extra-index-url

rerun integration tests

rerun integration tests

rerun integration tests


Update BLS signature module

What is wrong?
Update it with the latest spec.
How can it be fixed
Currently, the module is here: https://github.com/ethereum/py-evm/blob/master/eth/utils/bls.py

Replace BN128 with BLS-12-381 curve.
Implement and BLSVerify and BLSMultiVerify from spec. Pseudocode:def multi_verify(pubs, msgs, sig):
    len_msgs = len(msgs)
    assert len(pubs) == len_msgs
    o = FQ12(1)
    for m in set(msgs):
        group_pub = G1.zero()
        for i in range(len_msgs):
            if msgs[i] == m:
                group_pub = add(group_pub, pubs[i])
        o *= pairing(group_pub, m, final_exponentiate=False)
    o *= pairing(neg(G1), sig, final_exponentiate=False)
    return o ** ((field_modulus ** 12 - 1) // curve_order) == 1

Plus aggregate_sigs, pseudocode:def aggregate_sigs(sigs):
    o = FQ12(1)
    for s in sigs:
        o *= s
    return o

Replace the current blake hashing function with keccak-256.

closing via #1581


Docs/sphinx

4dd029d Carefully check directives. 😇
For debugging generated contents, GitHub preview is useful because if autoclass:: is not correctly specified, it would not be rendered in the preview.


Licensing and Copyright

Description
License and copyright details for the article.
User Stories
Author

As an author, I want to be able to see the license information for an article so that I can confirm the correct license is being used.

Production staff

As production staff, I want to be able to change the license information for an article so that I can switch the license if required.

But what if . . . ?

At the end of the year the copyright year should be updated if the article is first published in the following year, however, the typesetter has provided the content to Texture and so their auto/validation steps will no longer be applied

Considerations

License information usually consists of the copyright statement (copyright holder, copyright year) and the license paragraph (human readable description of the terms of the license), plus in many cases a URL associated with the license.
However, under Public Domain licenses like CC0, there is no copyright holder or year (these articles are perforce free from copyright restrictions). Only the license paragraph and license link are required.
eLife publishes two licenses, CC-BY-4.0 Creative Commons Attribution License used for most articles and the Creative Commons CC0 public domain dedication used for articles produced by employees of the United States Government (e.g. NIH employees).
Other publishers will need other license options.
In most cases, it is expected that the license text will be boilerplate and not require manual editing. For eLife, this means that while the details for the copyright holder and year will change for each article (CCBY) or not exist at all (CCO), the text for each of the 2 license paragraphs will stay the same.
At eLife, logic is applied to the copyright information during the production process:

One author, remove the et al from the <copyright-holder> text
Two authors remove the et al from the text but add "and" and second author surname.
The author et al text remains stable for papers with 3 or more authors and it's the first author's surname text

Other publishers sometimes simply use 'The Authors' in place of a more specific copyright holder.
ali:free_to_read tagging requires xmlns:ali="http://www.niso.org/schemas/ali/1.0/" namespace in the header XML (https://github.com/elifesciences/TextureRequirements/issues/1)
At Érudit, the URI that points to the license must redirect to the text of the license in the language of the article. Example:
If the article is in french: https://creativecommons.org/licenses/by/4.0/deed.fr
If the article is in english: https://creativecommons.org/licenses/by/4.0/deed.en
PKP and Érudit include a graphic element within license containing the CC-BY button image, e.g. https://mirrors.creativecommons.org/presskit/buttons/88x31/svg/by-sa.svg or http://licensebuttons.net/l/by/4.0/88x31.png. Each button is tied to the license used, so this likely needs to be dealt with in configuration.

XML requirements
There is a JATS4R recommendation for this tagging:
https://jats4r.org/permissions
Captured in article/front/article-meta/permissions
CC-BY-4.0
<permissions>
     <copyright-statement>© 2019, Tobin et al</copyright-statement>
     <copyright-year>2019</copyright-year>
     <copyright-holder>Tobin et al</copyright-holder>
     <ali:free_to_read/>
     <license xlink:href="http://creativecommons.org/licenses/by/4.0/">
          <ali:license_ref>http://creativecommons.org/licenses/by/4.0/</ali:license_ref>
          <license-p>This article is distributed under the terms of the <ext-link ext-link-type="uri" xlink:href="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution License</ext-link>, which permits unrestricted use and redistribution provided that the original author and source are credited.</license-p>
     </license>
</permissions>

CC0 licenses have no copyright, and so should be captured in the following way (or similar).
<permissions>
     <ali:free_to_read/>
     <license xlink:href="http://creativecommons.org/publicdomain/zero/1.0/">
          <ali:license_ref>http://creativecommons.org/publicdomain/zero/1.0/</ali:license_ref>
          <license-p>This is an open-access article, free of all copyright, and may be freely reproduced, distributed, transmitted, modified, built upon, or otherwise used by anyone for any lawful purpose. The work is made available under the <ext-link ext-link-type="uri" xlink:href="http://creativecommons.org/publicdomain/zero/1.0/">Creative Commons CC0 public domain dedication</ext-link>.
          </license-p>
     </license>
</permissions>

In the event that there are separate licenses for different languages, this should be captured using @xml:lang on the license element (@xml:lang is not allowed on license-p) in the permissions.
<permissions>
    <copyright-statement>Text © 2018 by the authors.</copyright-statement>
    <copyright-year>
        2018</copyright-year>
    <license license-type="open-access" xlink:href="http://creativecommons.org/licenses/by-sa/4.0/" xml:lang="de">
        <license-p>
            <inline-graphic xlink:href="http://mirrors.creativecommons.org/presskit/buttons/88x31/svg/by-sa.svg"/>
            Dieses Werk ist unter der Creative-Commons-Lizenz 4.0 (CC BY-SA 4.0)   veröffentlicht.</license-p>
    </license>
    <license license-type="open-access" xlink:href="http://creativecommons.org/licenses/by-sa/4.0/" xml:lang="en">
        <license-p>
            <inline-graphic xlink:href="http://mirrors.creativecommons.org/presskit/buttons/88x31/svg/by-sa.svg"/>
            This book is published under the Creative Commons License 4.0 (CC BY-SA  4.0).</license-p>
    </license>
</permissions>

Érudit examples:
license needs to be optional for Érudit:
<!--  Copyright owned by the authors  -->
<permissions>
  <copyright-statement>Copyright © Helen Fenwick and Gavin Phillipson, 2011</copyright-statement>
  <copyright-year>2011</copyright-year>
  <copyright-holder>Helen Fenwick and Gavin Phillipson</copyright-holder>
</permissions>

<!--  Copyright owned by the journal  -->
<permissions>
  <copyright-statement>Copyright © McGill Law Journal, 2011</copyright-statement>
  <copyright-year>2011</copyright-year>
  <copyright-holder>McGill Law Journal</copyright-holder>
</permissions>

Érudit include the license logo in license-p (where possible):
<!--    Link to the license text and to the license button. Permission with a "license-p" element only    -->
<permissions>
  ...
  ...
  <license xlink:href="https://creativecommons.org/licenses/by/4.0/deed.fr">
    <license-p>
      <media xlink:href="http://licensebuttons.net/l/by/4.0/88x31.png"/>
    </license-p>
 </license>
</permissions>

<!--    Link to the license text and to the license button. Permission with a "ali:license_ref" and a "license-p"    -->
<permissions>
  ...
  ...
  <license>
    <ali:license_ref xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
                https://creativecommons.org/licenses/by/4.0/deed.fr</ali:license_ref>
    <license-p>
      <media  xlink:href="http://licensebuttons.net/l/by/4.0/88x31.png"/>
    </license-p>
  </license>
</permissions>

Mock ups
This is not required, but if you have mock ups of what you would like to see please provide them here.
Proposal
This will be added by the Texture team after the feature request is discussed and agreed.

Note - feedback was not received from SciELO for this ticket.


remove tutorials from the left nav in docs

overview
on 12/04 we should evaluate whether there is significant usage of the tutorials item in the left nav in docs (which sends you to registry) and if there is not we should remove it.

we did not add appropriate tracking for this link until https://github.com/pulumi/pulumi-hugo/pull/827 which merged on 11/04, so ive adjusted the date to evaluate to 12/04

this was done in https://github.com/pulumi/registry/pull/419


Add files via upload

This is to enable the logo on the new supervisor page.

Has now been updated via different PR


missing 1 required positional argument: 'encoder_hidden_states'

hi.
Since today, il get this error :
VanillaTemporalModule.forward() missing 1 required positional argument: 'encoder_hidden_states'
i'm loading the basic json examples you provided, it worked fine 2 days ago (i updated comfyui yesterday)
Do you know could be the issue ?
Thanks !

Had the same problem this morning. Uninstall AnimateDiff by ArtventureX and most important if you have FreeU Advanced installed, uninstall. Worked for me.

thanks ! uninstalling freeU did the trick !

Hey, can you guys link what FreeU extension you guys are using that is causing this issue? I can look into what it's doing and see if I can do anything to make it compatible

Been getting a lot of these reports that end up being FreeU Advanced, so I wanna see what's up haha

I used this one : https://github.com/ChenyangSi/FreeU/tree/main
(Btw, thanks for your awesome custom nodes)

Np. Btw, looking at that repo, where is the node, or is there comfy nodes linked to that? I can't find any comfy nodes there.
Also as a side note, ComfyUI has a FreeU node built into it that appears to be compatible with AD, in the _for_testing section:

After installing FreeU Advanced by WASasquatch through the Manager you get the Advanced Plus.

When we raised the issue on the FreeU advanced -- the reply recd may be important so sharing same here.
""They are editing ComfyUI with patches just like FreeU [advanced] does.
Comfyanonymous isn't putting in patching ability for Input Blocks and Middle Block like I asked, which provide 1000x fold better results then output blocks that just burn and ruin images. You could ask AnimateDiff guys to put in patching for input/output and I could detect theirs, ."" if then can ask WAS on the freeU advanced improvements..
But not sure if the FreeU has any major impact on the resolution or output from K sampler.

Hey, update for you guys - there was an issue with the motion module code that was not setting encoder_hidden_states to None when not provided, FreeU Advanced should work fine now! Let me know if the issue is fixed for you guys now when you attempt to use FreeU Advanced!


incorrect version bound specification

https://github.com/pepkit/pipestat/blob/ef50dff40bf6dfd133377c53542de6fa746af597/requirements/requirements-db-backend.txt#L2
this is not working for me
pip install pydantic>=1.10.7, <2.0.0
bash: 2.0.0: No such file or directory

So I guess maybe that is correct in requirement file without quotes?


Convert billing API perf logs to metrics

What
In #2029 we made paas-metrics query elasticsearch to fetch the timings
of some of the SQL queries that paas-billing's collector makes, so we
could report them to prometheus and track their performance over a
longer time frame.
This commit does the same thing, but for the queries billing API makes.
This gives us more of an insight into the user-facing performance of
billing. As the pages in paas-admin generally only make one API call,
which only makes one slow SQL query these numbers are a good proxy for
how long the pages users see take to load.
As with the other PR, because this queries logit this spans multiple
deployments (so we'll see both prod and prod-lon in production).
In my dev environment this looks like:
 # HELP paas_billing_api_performance_elapsed_seconds
 # TYPE paas_billing_api_performance_elapsed_seconds gauge
 paas_billing_api_performance_elapsed_seconds{deployment="leeporte",message="paas-billing.store.get-billable-event-rows-query",orgGUIDs="",rangeStart="2019-09-16",rangeStop="2019-09-17"} 0.021888704
 paas_billing_api_performance_elapsed_seconds{deployment="miki",message="paas-billing.store.get-billable-event-rows-query",orgGUIDs="",rangeStart="2019-09-16",rangeStop="2019-09-17"} 0.0217637155
 paas_billing_api_performance_elapsed_seconds{deployment="momo",message="paas-billing.store.get-billable-event-rows-query",orgGUIDs="",rangeStart="2019-09-16",rangeStop="2019-09-17"} 0.020462683
 paas_billing_api_performance_elapsed_seconds{deployment="tlwr",message="paas-billing.store.get-billable-event-rows-query",orgGUIDs="",rangeStart="2019-09-16",rangeStop="2019-09-17"} 0.019776676666666666
 paas_billing_api_performance_elapsed_seconds{deployment="towers",message="paas-billing.store.get-billable-event-rows-query",orgGUIDs="fea642e0-a0a9-47c3-ac66-e36d8ea3e92b",rangeStart="2019-09-01",rangeStop="2019-10-01"} 0.032616076

How to review

Code review
cf push it into your dev environment and look at the metrics

Who can review
Not @richardtowers

I didn't run this down my dev env, but I peeked at paas-metrics.towers... and it looks correct
Code review 👍


Tapo authentication not work anymore with tapo c210 and 1.3.9 firmware

Hi,
All is in the title, since firmware update of camera the authentication not work anymore.
I use this in the go2rtc.yaml file:
streams:
  camera.salon:
    -<EMAIL_ADDRESS>    - tapo://<cloud password md5 hash<EMAIL_ADDRESS>
thanks

Factory reset camera / readd to tapo app, there is a bug in camera for some users where it does not properly load the new password hash.

See https://github.com/JurajNyiri/pytapo/issues/80

While above is true, there might be more work needed on go2rtc, see https://github.com/JurajNyiri/pytapo/pull/76 .
Also, use sha256 hash not md5 anymore.

thanks @JurajNyiri, after replace md5 by sha256 it work

same issue here - I tried the sha256 hash and it didnt work for me.

I need remote access to this camera to fix it.

Confirming that I also used the sha256 hash instead of the md5 - stopped the errors and the camera works with sounds - however, the 2 way audio no longer works.
I have 2 of the same Tapo C211 cameras, with the exact same config, but one has Firmware: 1.3.9 Build 231019 (not working) and the other has Firmware: 1.3.7 Build 230823 (working)
I'm willing to help in any way you need.

I have tapo c210 with 1.3.9 firmware un two way audio work.
You need to add microphone in the media setting of webrtc-camera card.
media: video,audio,microphone
the conf of stream in go2rtc.yaml:
streams:
camera.salon:
-<EMAIL_ADDRESS>

So this method worked for you?
streams:
  # cloud password without username
  camera1<EMAIL_ADDRESS>  # admin username and UPPERCASE MD5 cloud-password hash
  camera2<EMAIL_ADDRESS>  # Tapo C210 with firmware 1.3.9+
  camera3<EMAIL_ADDRESS>

yes for me with tapo c210 1.3.9 firmware the method below work:
streams:
camera.salon:
-<EMAIL_ADDRESS>I use homeassistant latest and the webrtc v3.5.0 HACS integretion.
With the custom webrtc-camera card I have no problem(2audio work perfect).
The only limitation is I can't turnoff the microphone directly from homeassistant, I need to go in browser settings to forbiden the microphone for the site. Honestly it is a detail!!!!

can you provide your card code?  2 way is not working for me and i have all these settings exactly.

This is the conf, for ptz I added cam as onvif integration and us that for ptz
- type: custom:webrtc-camera
ui: true
url<EMAIL_ADDRESS>mode: webrtc
mse: false
media: video,audio,microphone
ptz:
service: onvif.ptz
data_left:
entity_id: camera.cam1_onvif_mainstream
pan: LEFT
distance: 0.15
data_right:
entity_id: camera.cam1_onvif_mainstream
pan: RIGHT
distance: 0.15
data_up:
entity_id: camera.cam1_onvif_mainstream
tilt: UP
distance: 0.15
data_down:
entity_id: camera.cam1_onvif_mainstream
tilt: DOWN
distance: 0.15

OK - the audio comes through, but I dont see any way to cut the mic on or off - as soon as it loads, it starts.  How are you working around that?  Also, any idea how I can get this to work with Frigate Card?

For now the only solution for me is using firefox/chrome/edge on android (not the HA app) and from there you can block the microphone or not.

url params in card should be stream name, example camera.salon
Example how to make mic optional right in the webrtc integration docs

what do you mean optional?  Currently, it just starts with the mic open and there's no way to turn it off.  Is there configuration to have the mic off upon the stream load and toggle on/off?  I've tried this with the Frigate card mic button, and for some reason the two way audio doesnt work at all anymore.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.8.3


url in Stripe members/api/create-stripe-checkout-session/ is not handled – publicKey is expected

Issue Summary
When a request to members/api/create-stripe-checkout-session/ is made, the response is an object with a single field: {url: "…"}. Yet, some functions do not handled that well. For example, it's correctly handled here:
https://github.com/TryGhost/Ghost/blob/74d0fee1259476cd29962ecae2181c7e13b3932b/ghost/portal/src/utils/api.js#L385-L387
but not here:
https://github.com/TryGhost/Ghost/blob/74d0fee1259476cd29962ecae2181c7e13b3932b/ghost/portal/src/utils/api.js#L432
Steps to Reproduce

Go to https://news.typeofweb.com
Scroll down a bit
Click on the blue floating "Subskrybuj" button in the bottom right corner.
Continue with a paid subscription PLN 5/month
See error in the console.
Inspect network tab and notice that the endpoint returned {url} instead of {publicKey}

Ghost Version
74d0fee1259476cd29962ecae2181c7e13b3932b
Node.js Version
irrelevant
How did you install Ghost?
irrelevant
Database type
MySQL 5.7
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

@mmiszy can you please update this to include reproduction steps for the bug?
I realise you’ve proposed a fix but that also doesn’t include tests, so whilst I’m sure it’s valid it is not possible for us to verify what problem there is that is being solved.

@ErisDS it's the same problem that was solved here: https://github.com/TryGhost/Ghost/commit/4f54cbc37a5328d80ddd4a7c88b3a2ac1aa6c8ee
It's just that some spots were not updated.

Added steps to reproduce on my live website. Hope that helps!

Could you give steps to reproduce on a local install?

No, I'm afraid I can't.
But I don't quite understand the problem here - it's exactly the bug that was partially fixed ere https://github.com/TryGhost/Ghost/commit/4f54cbc37a5328d80ddd4a7c88b3a2ac1aa6c8ee - just some spots were not updated. It's the same endpoint being called but the expected response is still a public key instead of an URL.
Do you have a trouble reproducing it @allouis ?

@mmiszy I can't reproduce this and your PR adds handling for the url property of the response from a different endpoint to the one mentioned in this issue.
npm install -g ghost && ghost install local is a quick way to get a local ghost install up an running if you do find time to give reproduction steps.

I'm so sorry – I was wrong.
The issue is that Found https://unpkg.com/<EMAIL_ADDRESS>still points to an outdated version – 2.13.2 – but it should to 2.21.0.
The problem is that the latest tag has not been updated after a few last releases – NPM also shows outdated version:

Oooph - good catch, that makes sense why I couldn't reproduce!
Have you updated your config to set the portal URL manually? It should be using the jsDelivr CDN with a version, rather than latest - https://github.com/TryGhost/Ghost/blob/main/ghost/core/core/shared/config/defaults.json#L162-L165
Hoping that fixing your config can get your site working so you're not blocked on this issue

Yes, I've pinned it to a specific version.


ui: Change left and right sidebar scrollbar color

Changes left-sidebar and right-sidebar scrollbar color to hsl(0, 0%,
38%).
fixes: #12532

GIFs or Screenshots:

@timabbott this PR is ready to be merged.

Thanks for working on this @shubhamgupta2956!
Reading the code, it seems like this changes the scrollbars everywhere, with 2 duplicates copies.
Note that the names of the CSS files are just for human usage, and they just all get concatenated together to form the app.

Sorry for the mistake. I had made the changes and tested it also. Previously, I had only compared the changes with the /help page so I could not catch the error.

For now, I had put the code in left-sidebar.scss as I am not sure about putting it into component.scss or zulip.scss.

I think it's better to club this with the one in components.scss simply by using the SCSS & like so:
.simplebar-track {
    .simplebar-scrollbar::before {
        background-color: hsl(0, 0%, 0%);
        box-shadow: 0px 0px 0px 1px hsla(0, 0%, 100%, 0.33);

        .scrolling_list & {
            background-color: hsl(0, 0%, 38%);
        }
    }
}

@shubhamgupta2956 ^

@timabbott this PR is ready for review.

Closing as the original issue https://github.com/zulip/zulip/issues/12532 is no longer planned.


Michael's GitHub action playground

This PR currently has none of the required changelog labels.
Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

You'd need to land the change onto your develop branch here and then open a PR for the additional job to actually be picked up


MethodNotFound exception thrown when i call OpenCvSharp.VideoCapture("udp source")

Summary of your issue
System.MissingMethodException: 'Method not found: 'Void OpenCvSharp.VideoCapture..ctor(System.String, OpenCvSharp.VideoCaptureAPIs)'.'
Environment
Windows
Write your environment.
Windows 10, x86, 64-bit
What did you do when you faced the problem?
I created a OpenCvSharp.VideoCapture("udp://<IP_ADDRESS>:11111", OpenCvSharp.VideoCaptureAPIs.FFMPEG);
I also tried creating as OpenCvSharp.VideoCapture("udp://<IP_ADDRESS>:11111");
//write here
Example code:
OpenCvSharp.VideoCapture("udp://<IP_ADDRESS>:11111", OpenCvSharp.VideoCaptureAPIs.FFMPEG);
OpenCvSharp.VideoCapture("udp://<IP_ADDRESS>:11111");
paste your core code

Output:
paste your output
System.MissingMethodException: 'Method not found: 'Void OpenCvSharp.VideoCapture..ctor(System.String, OpenCvSharp.VideoCaptureAPIs)'.'

## What did you intend to be?

Make sure that all assemblies of your application reference the same version of OpenCvSharp.

This longer occurs with the latest OpenCvSharp4 version.


Dev branch merge

Summary of changes in this PR:

SD Card support via SAF (Android 5.0+).

Improved on-boarding and import experience.

Download Content export via Action Mode.

Additional commit notes for project team:

Zip/Unzip utility with Async support.

Separation of DownloadsFragment into multiple classes.

APK size optimizations via Support Library Vector Drawables and resConfig.

Content URI ready via FileProvider.

Java 8 ready via Jack.

@AVnetWS/admin-team

@codacy-bot Boo! Ignore~


Actually Harvest is treating the flowers from LDShadowLady's Flower Breeding: Replanted as crops.

I am playing with this mod and LDShadowLady's Flower Breeding: Replanted, for 1.20.1. I am unsure if it's Actually Harvest causing this, but if I right click a flower with the other mod's pollen jar, it harvests the flower and gives me exp, instead of adding pollen to the pollen jar from the other mod. I believe if this is true, the two mods conflict.
I have changed the config for Actually Harvest to require a hoe for harvesting, just to see if it is this mod at fault, and it does appear that Actually Harvest is treating the flowers from LDShadowLady's Flower Breeding: Replanted as crops.
Hopefully there can be some compatibility patch in the future, because I did like harvesting my crops with my empty hand.

The problem is that they are implemented as harvestable. I wonder if I just provide mod and block blacklists if that might work? Any feedback is welcome.

@SyntaxError73, the Last comment is for you. I'll be able to resolve this; I just want to think through the approach so it could potentially be a resolution for any other mods with this situation.

@SyntaxError73 I am trying to reproduce this locally, but I can't harvest flowers with right-click. Could you give me some specifics on how to reproduce this?


Readme Update

Create a list of all the projects with their name and link in a list format with proper numbering and subheadings in the readme.

You want this to be updated on the main readme or a separate readme file.

Update the current one, but keep it concise to make it less scrollable. (can be achieved by 3 or 4 projects columns in one row).

So should I only mention the main folder name and not the sub folders ?

Try to make something like this with all the project name and their links which will redirect to the project folder. Make it in alphabetical order.

Got an idea what you exactly want.

Check if this will work or I should use the names of subfolder here. @pranjay-poddar

use the name of the all the sub folders

add one more column to make it four columns

Then there will be more than 50 to 60 projects this will make the readme file so long.

yes, no problem in the long readme. The purpose of this is to showcase all the available projects in this repo.

Ok


Update README-CN.md

Readme word error.
Line: 52

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Cherry pick d3acc6d for 0.62 branch

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[X] I am making a change required for Microsoft usage of react-native

Summary
Cherry pick https://github.com/microsoft/react-native-macos/pull/691 to 0.62 branch. This change made improvements to the keyboarding support for macOS.
Changelog

[CATEGORY] [TYPE] - Message
Test Plan
Tested keyboarding support in RNTester.

Microsoft Reviewers: Open in CodeFlow

Validated that the apple failure is not related to this change as we ran a build without this change and hit the same error. Therefore, pushing this change in as is.

Validated that the apple failure is not related to this change as we ran a build without this change and hit the same error. Therefore, pushing this change in as is.


[FEATURE] Player-less Transmitter

Is your feature request related to a problem? Please describe.
From what I can tell a player must have a transmitter in their inventory in order to play midi as instruments require a switchboard to play midi.
Describe the solution you'd like
Some block or other feature that would allow a transmitter to broadcast a song without the need for an player to hold the transmitter; the transmitter could maybe be placed in a "broadcaster" block.
Describe alternatives you've considered
N/A
Additional context
N/A

Hello and thanks for the feature suggestion! You are correct that in order to play MIDI files from your computer you need to have a transmitter in your inventory. You can play the instruments manually without a transmitter but the transmitter must be in your hand or on your hotbar to play songs.
This idea sounds similar to https://github.com/tofodroid/mimi-mod/issues/58 but I think your idea would be to have it still play files from your computer rather than files that are uploaded to the server. I have a potential idea for how to implement https://github.com/tofodroid/mimi-mod/issues/58 and I think it would solve this request as well. I've got a start on the feature but it's not ready to go yet; hopefully I'll have an alpha version of it up in the next couple of weeks though!

Right now new features are only being released for the 1.19.x version of the mod. I unfortunately just don't have time right now to keep all of the versions in feature-parity and the code is now pretty significantly different in 1.19.x than in 1.16.x. Sorry!

This feature will be available in the next update, 3.0.0, releasing tomorrow!

Closed by #71


Update service broker proto packages.

Fix breaking change from istio/api#334

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
47293323bac0fca74a433c3feda632e05e3b5ce2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ee77dd285c7eda002862cdf73e495672f77724a8
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/lgtm


Add tracing via SystemView

This makes use of new features provided by https://github.com/apache/mynewt-core/pull/1107 and adds option to trace NimBLE LL and PHY events via SystemView. It effectively replaces existing LL logging which was temporary anyway.

Note that with default tracing options (i.e. OS task activity also enabled) this causes connection timeouts on nRF51. Not sure if it would be any better with less logging (did not try it yet) but it could be just that MCU is too slow to handle extra stuff during connection.
On nRF52840 everything works fine with tracing enabled: