MediaLive cannot get Input

I have successfully deployed this demo using Cloud9 as per the instructions given over here
Uploaded Attendees.csv, Moderators.csv, Talents.csv . And got the JSON files with details of joining and access keys
From deployment output

CloudFormation outputs from deployed stack
-------------------------------------------------------------------------------------------------
Outputs
-------------------------------------------------------------------------------------------------
Key                 MediaLiveSecondaryEndpoint
Description         Secondary MediaLive input URL
Value               rtmp://<IP_ADDRESS>:1935/tns-90-ty-jj0-livestream/secondary

Key                 MediaLivePrimaryEndpoint
Description         Primary MediaLive input URL
Value               rtmp://<IP_ADDRESS>:1935/tns-90-ty-jj0-livestream/primary

Key                 ModeratorURL
Description         The URL for accessing the Moderator web app
Value               https://d3m5mjz1jkd2kx.cloudfront.net/moderator

Key                 MessagingWebSocketURI
Description         The Messaging WSS Protocol URI to connect to
Value               wss://c5zjks9fl4.execute-api.us-east-1.amazonaws.com/Prod

Key                 TalentURL
Description         The URL for accessing the Talent web app
Value               https://d3m5mjz1jkd2kx.cloudfront.net/talent

Key                 CustomerImportS3Bucket
Description         The S3 bucket where the moderators, attendees, broadcast and talent data
must be specified
Value               tns-90-ty-jj0-customer-import

Key                 CloudFrontDomainName
Description         The CloudFront distribution domain name which would be aliased by the
actual domain name
Value               d3m5mjz1jkd2kx.cloudfront.net

Key                 CloudFrontMssEnpoint
Description         MSS CloudFront URL
Value
https://d3m5mjz1jkd2kx.cloudfront.net/out/v1/0973a204044a4d518399914abfc1020c/index.ism/Manifest

Key                 MediaLiveChannelId
Description         ID of the MediaLive channel for this stack
Value               3220426

Key                 CloudFrontCmafEnpoint
Description         CMAF CloudFront URL
Value
https://d3m5mjz1jkd2kx.cloudfront.net/out/v1/d3569b6055974da19e43012a6c6ab0ef/tns-90-ty-
jj0-livestream-cmaf-hls/index.m3u8

Key                 CloudFrontDashEnpoint
Description         DASH CloudFront URL
Value
https://d3m5mjz1jkd2kx.cloudfront.net/out/v1/a3c669e88168420cbc1823855383a7d8/index.mpd

Key                 ApiURL
Description         API endpoint URL for Prod environment
Value               https://ax5baeyph0.execute-api.us-east-1.amazonaws.com/Prod/

Key                 HandRaiseWebSocketURI
Description         The HandRaise WSS Protocol URI to connect to
Value               wss://cipdwigyd8.execute-api.us-east-1.amazonaws.com/Prod

Key                 GenerateEventFunction
Description         The generate event lambda function that takes as input data from the
CustomerImportS3Bucket and creates an event
Value               tns-90-ty-jj0-LiveEventCustomerImportCreateEvent-MV4w9uZavNWs

Key                 BroadcastURL
Description         The URL for accessing the Broadcast web app
Value               https://d3m5mjz1jkd2kx.cloudfront.net/broadcast

Key                 AttendeeURL
Description         The URL for accessing the Attendee web app
Value               https://d3m5mjz1jkd2kx.cloudfront.net/attendee

Key                 CloudFrontHlsEnpoint
Description         HLS CloudFront URL
Value
https://d3m5mjz1jkd2kx.cloudfront.net/out/v1/4a9dbf6007e54e66ad1b1e7782175814/index.m3u8
-------------------------------------------------------------------------------------------------

After following "Starting your broadcast" section from tutorial I go to MedialLive panel ther is this error

Please suggest any fix

@itsbeautifullife  Have you completed the steps after this? Im referring to the steps related to BroadcastLambdaFunction?
Let me know. Thanks

Thanks @michhyun1 for your feedback I have again re-deployed the solution on cloud9 and followed these steps
developer-sakthi:~/environment $ cd amazon-chime-live-events/
developer-sakthi:~/environment/amazon-chime-live-events (master) $ cd src/backend/serverless/
developer-sakthi:~/environment/amazon-chime-live-events/src/backend/serverless (master) $ node ./deploy.js -r us-east-1 -b vin-ss-101-f8m9o-bucket -s vin-ss-101-f8m9o-stack

CloudFormation outputs from deployed stack
-------------------------------------------------------------------------------------------------
Outputs
-------------------------------------------------------------------------------------------------
Key                 MediaLiveSecondaryEndpoint
Description         Secondary MediaLive input URL
Value               rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/secondary

Key                 MediaLivePrimaryEndpoint
Description         Primary MediaLive input URL
Value               rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/primary

Key                 ModeratorURL
Description         The URL for accessing the Moderator web app
Value               https://d17bjharjiudqg.cloudfront.net/moderator

Key                 MessagingWebSocketURI
Description         The Messaging WSS Protocol URI to connect to
Value               wss://2xtlk807kd.execute-api.us-east-1.amazonaws.com/Prod

Key                 TalentURL
Description         The URL for accessing the Talent web app
Value               https://d17bjharjiudqg.cloudfront.net/talent

Key                 CustomerImportS3Bucket
Description         The S3 bucket where the moderators, attendees, broadcast and talent data
must be specified
Value               vin-ss-101-f8m9o-stack-customer-import

Key                 CloudFrontDomainName
Description         The CloudFront distribution domain name which would be aliased by the
actual domain name
Value               d17bjharjiudqg.cloudfront.net

Key                 CloudFrontMssEnpoint
Description         MSS CloudFront URL
Value
https://d17bjharjiudqg.cloudfront.net/out/v1/e62cdf5939c04c2f8056c54a8b13297f/index.ism/Manifest

Key                 MediaLiveChannelId
Description         ID of the MediaLive channel for this stack
Value               2516250

Key                 CloudFrontCmafEnpoint
Description         CMAF CloudFront URL
Value
https://d17bjharjiudqg.cloudfront.net/out/v1/9b3f19bdde8b4e73a26daf09eafff65d/vin-
ss-101-f8m9o-stack-livestream-cmaf-hls/index.m3u8

Key                 CloudFrontDashEnpoint
Description         DASH CloudFront URL
Value
https://d17bjharjiudqg.cloudfront.net/out/v1/6e9d3dafa4284ebe96129ad2016accdd/index.mpd

Key                 ApiURL
Description         API endpoint URL for Prod environment
Value               https://tcc7uucbt6.execute-api.us-east-1.amazonaws.com/Prod/

Key                 HandRaiseWebSocketURI
Description         The HandRaise WSS Protocol URI to connect to
Value               wss://5z2lrkstpd.execute-api.us-east-1.amazonaws.com/Prod

Key                 GenerateEventFunction
Description         The generate event lambda function that takes as input data from the
CustomerImportS3Bucket and creates an event
Value               vin-ss-101-f8m9o-stack-LiveEventCustomerImportCrea-AXqPnWQU6wli

Key                 BroadcastURL
Description         The URL for accessing the Broadcast web app
Value               https://d17bjharjiudqg.cloudfront.net/broadcast

Key                 AttendeeURL
Description         The URL for accessing the Attendee web app
Value               https://d17bjharjiudqg.cloudfront.net/attendee

Key                 CloudFrontHlsEnpoint
Description         HLS CloudFront URL
Value
https://d17bjharjiudqg.cloudfront.net/out/v1/c854bf80c8754547986a86307fed8671/index.m3u8
-------------------------------------------------------------------------------------------------

Successfully created/updated stack - vin-ss-101-f8m9o-stack in us-east-1

Then I Uploaded 3 csv file to this  bucket
Key                 CustomerImportS3Bucket
Value               vin-ss-101-f8m9o-stack-customer-import
Attendees.csv
Moderators.csv
Talents.csv
Then executed this lambda function in lambda tester
Key                 GenerateEventFunction
Value               vin-ss-101-f8m9o-stack-LiveEventCustomerImportCrea-AXqPnWQU6wli
with payload
{   "attendeesKey": "Attendees.csv", "moderatorsKey": "Moderators.csv", "talentsKey": "Talents.csv" }
==> result
{   "body": "{\"EventId\":\"LiveEvent-V5Dv\",   \"TalentURL\":\"https://d17bjharjiudqg.cloudfront.net/talent?aId=f58d6732-ec16-4f79-922b-6e930994f68b&eId=LiveEvent-V5Dv&name=Jake\",   \"TalentAccessKey\":\"faiLE2fKleDyV7J3ceoO2FTE\",   \"BroadcasterURL\":\"https://d17bjharjiudqg.cloudfront.net/broadcast?aId=ac10f778-a022-4dbb-b5f0-aa60c226842e&eId=LiveEvent-V5Dv&accessKey=1jHEWnQCuAsqqfHKXY9tPE36&name=%E2%80%B9Broadcaster%E2%80%BA\"}",   "headers": {     "Access-Control-Allow-Origin": "https://d17bjharjiudqg.cloudfront.net"   },   "statusCode": 200 }
new Files I generated in S3
LiveEvent-V5Dv_event_attendees.json.txt
LiveEvent-V5Dv_event_broadcaster.json.txt
LiveEvent-V5Dv_event_moderators.json.txt
LiveEvent-V5Dv_event_talents.json.txt
(renamed extension to .txt to support uploading to Github)
Then I run lambda given by this Key BroadcastLambdaFunction
Key                 BroadcastLambdaFunction
Value              vin-ss-101-f8m9o-stack-broadcast-lambda
with payload
{  "action": "start",   "meetingURL": "https://d17bjharjiudqg.cloudfront.net/broadcast?aId=ac10f778-a022-4dbb-b5f0-aa60c226842e&eId=LiveEvent-V5Dv&accessKey=1jHEWnQCuAsqqfHKXY9tPE36&name=%E2%80%B9Broadcaster%E2%80%BA",   "rtmpEndpoint": "rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/primary" }
==> result
"\"arn:aws:ecs:us-east-1:099481824429:task/ec2-cluster--vin-ss-101-f8m9o-stack-broadcast/63a8f6ba53d440c7b0152373e6021068\""
==>log
START RequestId: 11738abf-f5e2-44c2-8eef-7ca2a785d9e9 Version: $LATEST 2022-01-06T07:40:50.828Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  event {   action: 'start',   meetingURL: 'https://d17bjharjiudqg.cloudfront.net/broadcast?aId=ac10f778-a022-4dbb-b5f0-aa60c226842e&eId=LiveEvent-V5Dv&accessKey=1jHEWnQCuAsqqfHKXY9tPE36&name=%E2%80%B9Broadcaster%E2%80%BA',   rtmpEndpoint: 'rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/primary' } 2022-01-06T07:40:50.843Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  Broadcast Action: start 2022-01-06T07:40:50.843Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  Meeting URL: https://d17bjharjiudqg.cloudfront.net/broadcast?aId=ac10f778-a022-4dbb-b5f0-aa60c226842e&eId=LiveEvent-V5Dv&accessKey=1jHEWnQCuAsqqfHKXY9tPE36&name=‹Broadcaster› 2022-01-06T07:40:50.843Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  RTMP Endpoint: rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/primary 2022-01-06T07:40:50.844Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  ecsRunTaskParams: {"cluster":"arn:aws:ecs:us-east-1:099481824429:cluster/ec2-cluster--vin-ss-101-f8m9o-stack-broadcast","launchType":"EC2","count":1,"overrides":{"containerOverrides":[{"environment":[{"name":"MEETING_URL","value":"https://d17bjharjiudqg.cloudfront.net/broadcast?aId=ac10f778-a022-4dbb-b5f0-aa60c226842e&eId=LiveEvent-V5Dv&accessKey=1jHEWnQCuAsqqfHKXY9tPE36&name=‹Broadcaster›"},{"name":"RTMP_URL","value":"rtmp://<IP_ADDRESS>:1935/vin-ss-101-f8m9o-stack-livestream/primary"}],"name":"container--vin-ss-101-f8m9o-stack-broadcast"}]},"placementConstraints":[{"type":"distinctInstance"}],"taskDefinition":"arn:aws:ecs:us-east-1:099481824429:task-definition/vin-ss-101-f8m9o-stack-broadcast-ECSBroadcastTaskDefinition-wSGUmoLlpNOk:1"} 2022-01-06T07:40:51.305Z  11738abf-f5e2-44c2-8eef-7ca2a785d9e9  INFO  start task succeed {   tasks: [     {       attachments: [],       attributes: [Array],       availabilityZone: 'us-east-1b',       clusterArn: 'arn:aws:ecs:us-east-1:099481824429:cluster/ec2-cluster--vin-ss-101-f8m9o-stack-broadcast',       containerInstanceArn: 'arn:aws:ecs:us-east-1:099481824429:container-instance/ec2-cluster--vin-ss-101-f8m9o-stack-broadcast/57e3e5ae3c364a14b3998529f8d90ef4',       containers: [Array],       cpu: '4096',       createdAt: 2022-01-06T07:40:51.248Z,       desiredStatus: 'RUNNING',       enableExecuteCommand: false,       group: 'family:vin-ss-101-f8m9o-stack-broadcast-ECSBroadcastTaskDefinition-wSGUmoLlpNOk',       lastStatus: 'PENDING',       launchType: 'EC2',       memory: '8192',       overrides: [Object],       tags: [],       taskArn: 'arn:aws:ecs:us-east-1:099481824429:task/ec2-cluster--vin-ss-101-f8m9o-stack-broadcast/63a8f6ba53d440c7b0152373e6021068',       taskDefinitionArn: 'arn:aws:ecs:us-east-1:099481824429:task-definition/vin-ss-101-f8m9o-stack-broadcast-ECSBroadcastTaskDefinition-wSGUmoLlpNOk:1',       version: 1     }   ],   failures: [] } END RequestId: 11738abf-f5e2-44c2-8eef-7ca2a785d9e9 REPORT RequestId: 11738abf-f5e2-44c2-8eef-7ca2a785d9e9  Duration: 501.72 ms Billed Duration: 502 ms Memory Size: 256 MB Max Memory Used: 77 MB  Init Duration: 462.04 ms
But if I check medialive even after 10 minutes it still is Off when i try to manully Start it I get the error I mentioned originally
Is it something to due with ECS container not running firefox scrapper ?
Thanks

@itsbeautifullife Can you check the ecs task to see if there are any errors printed?
Also, perhaps you can try using this option to start the mediaLive channel when the stack is created. Then you can do the transcoding afterwards.
Let me know if either of those things help. Thanks

I think one common problem that I've seen in the past is also related to Docker. Please make sure you have that running

@itsbeautifullife any update?

Closing issue due to inactivity


restore runner build flags

Fixes #899

I've updated this to only build AVX=on by default which should maximize performance vs compatibility (until we add runtime-level checks)

Sorry for my ignorance, i'm new to Github and I try to figure out how this place work duh!
I tried ollama and had this illegal cpu dump error too. I saw that there is a fixe on avx2/avx/fma but how does it works? I saw jmorganca shared a modified file. Should I replace the file? Should I uninstall ollama and install a new version. Some tips would help. Thx all.


Add Azure Batch support

Create Azure Batch Service account with AzureSMR.
Create pool of VMs with AzureSMR.

doAzureParallel does not support custom VM image so this will be held back.


feat!: move layout route inside directory

Any thoughts on implementing something like this?
https://github.com/expo/router/pull/89

There are couple of concerns about the new Expo's router:

It would make possible to have pages/posts.tsx and pages/posts/index.tsx - so would be conflicting/confusing
It would require a sorting/ranking mechanism as _layout.tsx wouldn't be always on top - w/ dynamic routes
It would be less similar to Remix

The only advantage I see is the ability to group the layout file with its related routes.

It would make possible to have pages/posts.tsx and pages/posts/index.tsx - so would be conflicting/confusing

I'd argue that you'd want to support both models where the render order would nest
pages/posts.tsx >  pages/_layout.tsx >  pages/posts/index.tsx
which i guess would basically lead to supporting remixes pathless layouts
Whether you'd ever need both at the sametime I have no idea.

It would require a sorting/ranking mechanism as _layout.tsx wouldn't be always on top - w/ dynamic routes

yeah the sorting thing would be a bit of a pain seeing as _ comes after [ in ascii, i do like how little code this library is compared to pretty much every other one.

It would be less similar to Remix

interesting, I thought you followed next.js more than remix
other notes
it would add a nice convention to replace the built in rule for the _app file.
side note: would a [...all] work for a 404 page?

I'd argue that you'd want to support both models where the render order would nest
pages/_layout.tsx > pages/posts.tsx > pages/posts/_layout.tsx > pages/posts/index.tsx

I thought of adding .layout.tsx to the layout file would keep current keep the current implementation as is and will make it more clear which is the layout file, what do you think?
pages
├── about.tsx
├── index.tsx
├── posts.layout.tsx
└── posts
    ├── [slug].tsx
    └── index.tsx

Basically it would be only to indicate the layout for readability but wouldn't change how it works now. I still find it nice to have the layout file outside of the nested routes.
Thanks for sharing about pathless routes! the first time I hear about it.

It would be less similar to Remix
interesting, I thought you followed next.js more than remix

It's correct, generouted is more inspired by Next.js (before the new router), but because nested layouts were Remix specific initially, I did mention that point ;)

it would add a nice convention to replace the built in rule for the _app file.

You mean renaming _app.tsx to _layout.tsx? It does make sense, specially after the Next.js new router update.

side note: would a [...all] work for a 404 page?

I guess that's how it works now.

A .layout.tsx would be a nice addition.
my issue is potentially that my editor groups folders before files, so any layout file is generally quite a distance from the related files, it's a big reason I prefer the _layout.tsx files idea.
For now I've ended up deviating from using generouted modifying it to work how I want. Haven't done a lot of testing to see what it breaks, although I have also broken it into two files (one to calculate routes and another to integrate with react location) which I think would make it more testable, so maybe I will.
I'll paste it in here later for reference if anyone else is interested

import React, { Fragment } from 'react'
import { LoaderFn, Route } from '@tanstack/react-location'

type Module = { default: () => JSX.Element; loader: LoaderFn }

function getRoutes(ROUTES: { [key: string]: () => Promise<Module> }) {
  return Object.keys(ROUTES).reduce<Route[]>((routes, key) => {
    const module = ROUTES[key];
    const route: Route = {
      element: () => module().then((mod) => (mod?.default ? <mod.default /> : <></>)),
      loader: (...args) => module().then((mod) => mod?.loader?.(...args)),
    }

    const segments = key
        .replace(/\[\.{3}.+\]/, '*')
        .replace(/\[([^\]]+)\]/g, ':$1')
        .split('/')

    segments.reduce((parent, segment, index) => {
      const path = segment.replace(/index|\./g, '/').replace("_", "")
      const root = index === 0 || segment.startsWith('_');
      const leaf = index === segments.length - 1 && segments.length > 1
      const node = !root && !leaf
      const insert = /^\w|\//.test(path) ? 'unshift' : 'push'

      if (root) {
        const dynamic = path.startsWith(':') || path === '*'
        if (dynamic) return parent

        const last = segments.length === 1 || segment.startsWith('_');
        if (last) {
          routes.push({ path, ...route })
          return parent
        }
      }

      if (root || node) {
        const current = root ? routes : parent.children
        const found = current?.find((route) => route.path === path)
        if (found) found.children ??= []
        else current?.[insert]({ path, children: [] })
        return found || (current?.[insert === 'unshift' ? 0 : current.length - 1] as Route)
      }

      if (leaf) {
        const found = parent?.children?.find((route) => route.path === path)
        if(!found) {
          parent?.children?.[insert]({ path, ...route })
        } else {
          Object.assign(found, route);
        }
      }

      return parent
    }, {} as Route)

    return routes
  }, [])
};

// @ts-ignore
let PAGES = import.meta.glob('../pages/**/[_a-z[]*.tsx');

PAGES = Object.fromEntries(
  Object.entries(PAGES).map(([key, value]) =>
    [
      key
        .replace(/..\/pages|\.tsx$/g, '')
        .replace('/_layout', ''),
      value
    ]
  )
)

export default {
  pages: getRoutes(PAGES)
}

Thanks a lot for providing the code. I recently also broke down the source code into core and integrations, now it looks something like that:
src/
├── core.ts
├── react-location.tsx
└── react-router.tsx

Here's the change based on the snippet you provided to support nested _layout.tsx https://github.com/oedotme/generouted/commit/3e0ae764d94cbe23043e18ab63a764904eba2a0c.
The existing layout definition is still there as well, so pages/posts.tsx or pages/posts/_layout.tsx are valid layouts but only one should be used. In case both are present, _layout.tsx will be the layout used.
I'll close this issue once released a new version after some docs updates.


[wip] Implement edit

Still need some tests

I saw editing get removed in a previous commit but FWIW I was hoping to be able to use the feature recently. I settled for removal and re-addition as in my application I didn't want round-robin.
I'd be interested in seeing some form of editing come back.


Modal showing activity bar when it should not (using SystemNavigationBar - edit: using java code produces the same bug)

Description
I'm using SystemNavigationBar to hide my status and activity bars, in order to be able to use the full screen for the app I'm currently developing.

The bug I'm facing (as many others faced already) consists on those same bars appearing when a modal is shown.

This is already a known issue on the package repo, but I could not find any issue regarding this problem on the react-native repo. Ence, I'm creating one.

This issue seems to have appeared before on react-native's repo:
https://github.com/facebook/react-native/commit/f8a4d281e2be5b68fbebf53f930d37d96236829c

Is there any fix?
Thanks in advance for any support and help.
React Native Version
0.71.4
Output of npx react-native info
System:
    OS: Windows 10 10.0.22621
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 3.01 GB / 15.91 GB
  Binaries:
    Node: 18.12.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.6.4 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK:
      AllowAllTrustedApps: Enabled
      Versions: 10.0.19041.0
  IDEs:
    Android Studio: AI-213.7172.25.2113.9123335
    Visual Studio: 16.11.32126.315 (Visual Studio Enterprise 2019)
  Languages:
    Java: 11.0.17
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.4 => 0.71.4
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

Create a screen with a button to open a modal with any content, like a button to close it;
Import SystemNavigationBar, after installing it (npm i react-native-system-navigation-bar)
Place: SystemNavigationBar.fullScreen(true); inside your function
Run the code
Both bars will be hidden
Click on the button to open the modal
When the modal opens, at least the bottom bar becomes visible
Close the modal and both bars are hidden once again.

Snack, code example, screenshot, or link to a repository
App.tsx
import React, {useState} from 'react';
import {Modal, StyleSheet, View} from 'react-native';
import Buttons from './Buttons';
import SystemNavigationBar from 'react-native-system-navigation-bar';

function App(): JSX.Element {
  SystemNavigationBar.fullScreen(true);
  const [visible, setVisible] = useState(false);
  const onclick = () => {
    setVisible(!visible);
  };
  return (
    <View style={styles.content}>
      <Buttons
        press={onclick}
        text={'Open Modal'}
        backgroundColor={'#FFFEFC'}
        borderColor={'#EEEEEE'}
        textColor={'#223631'}
      />
      {visible === true && (
        <Modal transparent={false} visible={visible}>
          <View style={styles.content}>
            <Buttons
              press={onclick}
              text={'Close Modal'}
              backgroundColor={'#FFFEFC'}
              borderColor={'#EEEEEE'}
              textColor={'#223631'}
            />
          </View>
        </Modal>
      )}
    </View>
  );
}

const styles = StyleSheet.create({
  content: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
});

export default App;

Buttons.tsx
import React from 'react';
import {Pressable, Text, View, StyleSheet} from 'react-native';

function Buttons({press, text, backgroundColor, borderColor, textColor}: any) {
  return (
    <Pressable
      style={styles.button}
      onPress={press}
      backgroundColor={backgroundColor}
      borderColor={borderColor}>
      <View style={styles.textFrame}>
        <Text style={styles.textStyle}>
          <Text style={{color: textColor}}>{text}</Text>
        </Text>
      </View>
    </Pressable>
  );
}

const styles = StyleSheet.create({
  button: {
    display: 'flex',
    flexDirection: 'row',
    justifyContent: 'center',
    alignItems: 'center',
    // paddingVertical: 24,
    // paddingHorizontal: 24,
    // alignSelf: 'stretch',
    // flexGrow: 0,
    borderWidth: 4,
    borderRadius: 16,
    height: 88,
    width: 500,
  },
  textFrame: {
    display: 'flex',
    order: 0,
    flexDirection: 'row',
  },
  textStyle: {
    display: 'flex',
    fontFamily: 'OpenSans-SemiBold',
    fontStyle: 'normal',
    fontWeight: '600',
    fontSize: 32,
  },
});

export default Buttons;

Example:
Here, we can see that, at the bottom, after clicking on the open modal button, the bar appears, where it should not.

Update
I tried with java (I made a bridge between java and react native) to test:

Imports needed:

import android.app.Activity;
import android.view.WindowInsets;
import android.view.WindowInsetsController;
import android.view.WindowManager;

Method:

@ReactMethod
    public void hideSystemBars() {
        Activity currentActivity = getCurrentActivity();
        if (currentActivity != null) {
        currentActivity.runOnUiThread(() -> {
            WindowInsetsController controller = currentActivity.getWindow().getDecorView().getWindowInsetsController();
            if (controller != null) {
            controller.hide(WindowInsets.Type.statusBars() | WindowInsets.Type.navigationBars());
            }
            currentActivity.getWindow().addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
        });
        }
    }

And the problem persists.

Problem persist in 0.71.10.

@cortinico Is this a known issue , A PR  has also been raised with the fix,

@cortinico Is this a known issue , A PR has also been raised with the fix,Is this in the pipeline,

Don't you mind following up on the PRs comments that @lunaleaps left then?

@cortinico Is this a known issue , A PR has also been raised with the fix,Is this in the pipeline,

Don't you mind following up on the PRs comments that @lunaleaps left then?

any updates?

This issue is currently making it impossible to use Modal in a fullscreen app (such as a game, for instance) because it breaks the UI. I tried applying the code from https://github.com/facebook/react-native/pull/36854 but I realized that I'd have to build RN from source which I don't know how to do and seems it would really complicate our workflow with the app in question.
Looking forward to any updates here.

A senior of mine made a solution to this, but I did not inspect it yet because I did not have time yet. I don't even know if it is viable to most projects to be honest, I gave a small look to the changes and it looked messy. I'll try to update this as soon as possible

A coworker of the company I was at the time found a solution to this, but I did not inspect it yet because I did not have time to. I don't even know if it is viable to most projects to be honest, I gave a small look to the changes and it looked messy. I'll try to update this as soon as possible.

For anyone looking for a workaround, I've opted to stop using Modal until this has been resolved, and I'm instead using react-native-portal  to "teleport" my modals to the root of my view hierarchy so that I can show the content on top of everything else.

Facing a similar issue by adding in my MainAcitivity.java this code into my onCreate function :
Window w = getWindow();
      // these styles should be under super.onCreate to take effect
      w.setStatusBarColor(Color.TRANSPARENT);
      w.setNavigationBarColor(Color.TRANSPARENT);
      w.setNavigationBarContrastEnforced(false);
      w.getDecorView().setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION | View.SYSTEM_UI_FLAG_LAYOUT_STABLE );

I'm trying to achieve edge-to-edge experience in my app and it's working fine by using statusBarTranslucent  but there is no way to do so for the nav bar.
I guess you can provide something like the statusBarTranslucent that you already supporting, or just fetch whatever settings or flags applied to the root window and reapply it on updateProperties . @cortinico

this is still open


exposition: store histograms as either a List or a LargeList

Add configuration parameters so that the output parquet file stores the
nested lists within histograms as either a regular list (i32-indexed;
limited to 2^31 entries) or a large list (i64-indexed; limited to 2^61
entries). Also, remove summary percentiles, as summaries of free-running
histograms are not particularly useful.

Closing, will fix up internal buffering and row group sizes and then apply.


Question about tautomer InChI strings

Hello,
I understand that in standard InChI, tautomers have identical InChI strings, as discussed here: https://www.inchi-trust.org/technical-faq-2/#6.1.
However, in the ChEBI Annotation Manual, Section 8.2, Molfiles, it is stated that "Tautomer generation for the InChI has been switched on making InChIs generated by tautomers distinguishable."
But in the structures.csv file downloaded from the FTP site, all of the InChIs appear to be standard, and thus the InChIs of pairs of tautomeric compounds are identical. Selected examples:

CHEBI:15570 (D-alanine) / CHEBI:57416 (D-alanine zwitterion)
CHEBI:27760 (L-selenocystathionine) / CHEBI:62226 (L-selenocystathionine zwitterion)
CHEBI:2164 (6-acetamido-3-aminohexanoic acid) / CHEBI:58498 (6-acetamido-3-aminohexanoic acid zwitterion)

Is the Annotation Manual in error, or only referring to internally-accessible InChIs?

The non-standard InChi's are not visible on the ChEBI public website or in the downloadable files. We only use them internally to distinguish between different tautomers when a new structure is submitted via the ChEBI submission tool.

Thank you, that clarifies things.


Allow composition

Description
Allow composition of multiple scripts attached to one node.
Implementation ideas
Make a new orchestration script as a composition of multiple ones. All the graphs and components would be placed inside this new script, inside a colored comment like block with the source scripts name, to visually order the components according to their main script.
Optionally you can decide wether to just copy and paste or link the components (so they will change if the parent changes); I also think there need to be nodes defined for each "source block" individually that are for "exposing" internal values of the block, if the components are linked. So that if the intervals change nothing needs to changed in the api of the linked components (because the internals can not be directly wired only the exposed nodes) unless there is refactoring of types going on.
Long story short: Basically Modules.

So, I think there are many ways you can work with composition.
You can do this in UE through a combination of macro and function libraries.  We're already working on the former, as we think those provide the best prefab reuse features, allowing users to define custom nodes that can be used across multiple Orchestration scripts much the same way you may reuse a .gd script in multiple other script sources.
However, I am concerned about this ideology of attaching multiple scripts to the same node.  I'm concerned that most would use this poorly, leading to poor programming habits and blurring the separation of concerns principle.
Let's put Orchestrator aside for just a moment.
Today, if you wanted to explore composition in Godot, you would have an instanced scene representing some prefab, perhaps a door, a player, etc.  Let's say this door object has multiple concerns like collision and player interactions. You would likely have two child nodes where each would have its own script, and that child node handles that specific concern.  If these two siblings need to interact with one another, you would generally use a blackboard in the parent or provide a way for the child nodes to gain a reference to a sibling component, much like how ECS/Component systems work in Unity.
What exactly would this module concept offer, perhaps a more concrete example would help my understand why such a nested architecture would be needed within the scripting subsystem rather than using the scene tree for this.

Maybe you are right I was just thinking in regular programming terms.


Missing definition nodes of parameters in info tree

Take the following program:
set_option pp.raw true
set_option trace.Elab.info true
example (a : Nat) : a = a := Eq.refl a

In the output, we have definition (isBinder := true) and usage nodes for occurrences of a in the header, but the a in the body uses a different FVarId _uniq.8 with no corresponding definition node. This is an issue for e.g. the find-all-references request (/cc @Garmelon).
[Elab.info] command @ ⟨3, 0⟩-⟨3, 38⟩ @ Lean.Elab.Command.elabDeclaration
  Nat : Type @ ⟨3, 13⟩-⟨3, 16⟩ @ Lean.Elab.Term.elabIdent
    [.] `Nat : some Sort.{?_uniq.1} @ ⟨3, 13⟩-⟨3, 16⟩
    Nat : Type @ ⟨3, 13⟩-⟨3, 16⟩
  _uniq.2 : Nat @ ⟨3, 9⟩-⟨3, 10⟩
  Eq.{1} Nat _uniq.2 _uniq.2 : Prop @ ⟨3, 20⟩-⟨3, 25⟩ @ _aux_Init_Notation___macroRules_«term_=_»_2
    Macro expansion
    («term_=_» `a "=" `a)
    ===>
    (Term.binrel "binrel%"<EMAIL_ADDRESS>`a `a)
      Eq.{1} Nat _uniq.2 _uniq.2 : Prop @ ⟨3, 20⟩†-⟨3, 25⟩ @ Lean.Elab.Term.elabBinRel
        _uniq.2 : Nat @ ⟨3, 20⟩-⟨3, 21⟩ @ Lean.Elab.Term.elabIdent
          _uniq.2 : Nat @ ⟨3, 20⟩-⟨3, 21⟩
        _uniq.2 : Nat @ ⟨3, 24⟩-⟨3, 25⟩ @ Lean.Elab.Term.elabIdent
          _uniq.2 : Nat @ ⟨3, 24⟩-⟨3, 25⟩
  Eq.refl.{1} Nat _uniq.8 : Eq.{1} Nat _uniq.8 _uniq.8 @ ⟨3, 29⟩-⟨3, 38⟩ @ Lean.Elab.Term.elabApp
    [.] `Eq.refl : some Eq.{1} Nat _uniq.8 _uniq.8 @ ⟨3, 29⟩-⟨3, 36⟩
    Eq.refl.{1} : forall {α : Type} (a : α), Eq.{1} α a a @ ⟨3, 29⟩-⟨3, 36⟩
    _uniq.8 : Nat @ ⟨3, 37⟩-⟨3, 38⟩ @ Lean.Elab.Term.elabIdent
      _uniq.8 : Nat @ ⟨3, 37⟩-⟨3, 38⟩
  _example : forall (a : Nat), Eq.{1} Nat a a @ ⟨3, 0⟩-⟨3, 7⟩

I see two solutions here:

We manually add definition nodes for the new FVarIds when re-adding the parameters to the local context before elaborating the body. This will require some more work in the server to identify FVarIds that are "morally" the same, but it should be doable.
We save and restore the original FVarIds when re-adding the parameters. I'm not completely sure it is safe to reuse out-of-scope FVarIds though.

@leodemoura What do you think?

We save and restore the original FVarIds when re-adding the parameters. I'm not completely sure it is safe to reuse out-of-scope FVarIds though.

Even if it works in the current codebase, it may create really nasty bugs in the future.
We have implemented the whole codebase assuming FVarIds are not reused.

We manually add definition nodes for the new FVarIds when re-adding the parameters to the local context before elaborating the body. This will require some more work in the server to identify FVarIds that are "morally" the same, but it should be doable.

I am wondering whether we can avoid this extra work. The issue is created by the following code pattern.
let a <- forallTelescope type fun xs type => ...
... do something ...
let b <- forallTelescope type fun xs type => ...
...

We use this pattern at MutualDef.lean. In this use-case, the first forallTelescope is used to elaborate the type of the definitions and the second their values. I could try to avoid the pattern above by saving the local contexts and avoiding the second forallTelescope. The code will get messier since we create local variables between the two forallTelescopes.
I didn't check how often we use the code pattern above. It is just at MutualDef.lean, then I think it is not too bad, and we will not have to modify the server code.

@Kha If we are using the forallTelescope code pattern above in several places, then I think it is worth implementing support for identifying FVarIds as you suggested.

We manually add definition nodes for the new FVarIds when re-adding the parameters to the local context before elaborating the body. This will require some more work in the server to identify FVarIds that are "morally" the same, but it should be doable.

The forallTelescope pattern is also used to elaborate let rec.


Fixed: Update PR labeller

Updates the PR labeller to run on the PR target, rather than the pull request, to get around a permissions issue running on a fork.
Fixes #766

Tagging @musicEnfanthen as well

Thanks @ahankinson for the PR. Looks good. Indeed, this labelling action seems to be one of the rare use cases where the official recommendation is to use pull_request_target.
BTW: Do we want to run the GH action only on music-encoding or also on all forks (i.e. all the forks get the labels, too). If only the former then we might want to include something like
if: github.repository_owner == 'music-encoding'
at line 22.

As far as I can tell, this will only run on forks if someone is targeting a pull request to that fork... that's what is meant by the 'target'. So I think the github.repository_owner == 'music-encoding' is implied, unless someone is maintaining a parallel MEI repo.

Can we exclude that some forks are working with Pull Requests to their own repos at their covenience? Or to put it the other way round: inserting the if clause would ensure that the gh action is never ever executed outside the organisational main repo. Cf. https://github.com/NixOS/nixpkgs/pull/113077/files#r575748234
(Actually, that is even more urgent for the the deploy.yml)

Added; let me know if it looks ok?

Yes, thank you! (Suggestion to update labeler version to v3)

dear both, thanks for working on this and spotting the problem esp. with the deploy action! Could you submit a PR for that one, too?

this ready to merge?

Good from me.


update repository details to new organisation

[x] I have created tests for any new feature, or added regression tests for bugfixes.
[x] cargo test succeeds
[x] Clippy is happy: cargo +nightly clippy succeeds
[x] Rustfmt is happy: cargo +nightly fmt succeeds
(all checks not needed)

bors r+

(let's see if bors is setup)

bors ping

hi, bors! 👋
bors r+


navigateTo doesn't return promise, thus cannot be awaited

Environment

Operating System: Linux
Node Version:     v18.20.3
Nuxt Version:     2.17.3
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      head, components, bridge, serverHandlers, devServerHandlers, devServer, typescript, nitro, buildModules
Runtime Modules:  -
Build Modules<EMAIL_ADDRESS>
Reproduction
Nuxt Bridge reproduction
https://stackblitz.com/edit/nuxt-bridge-starter-nbqmvf?file=pages%2Findex.vue
Nuxt 3 reproduction
https://stackblitz.com/edit/nuxt-starter-me3k42?file=pages%2Findex.vue
Describe the bug
Utility helper navigateTo does not return a promise, thus cannot be awaited.
The method router.push has the same behaviour. You may notice, that the app crashes on router.push('/').then(() => {}), because there is no .then in undefined
In this Nuxt Bridge reproduction I have tried to add await to the navigateTo, and second alert fires synchronously.
But in Nuxt 3, await makes the difference and second alert fires after navigation complete.

A little bit of code
pages/index.vue
<template>

    <button @click="navigateToTodos">navigateTo</button>

</template>

pages/todos/index.vue
<template>

    Todos

</template>

Additional context
No response
Logs
No response

The following workarounds are available
router.push(path, onCompleted)

In your reproduction environment, you could write
const pushToTodosWithAwait = async () => {
  showRouteName(1);

  router.push(route, () => {
    showRouteName(3);
  });
};

router.push(path, onCompleted)

Yes, we are currently using this workaround in our app.
The downside is that the newer version of vue-router does not have an onComplete callback, if I'm not mistaken. We need to keep this in mind after the migration is complete.


document npm link

At the beginning of the guide book, under chapter 1.2 it states that later in the tutorial, if you don't want to publish to npm ,you can use npm link to run your wasm code. I was wondering if that part just wasn't written yet or it was intentionally left out?
I don't know if it's appropriate to open the issue about the book here since I couldn't find the repository for it anywhere. I only found the rust wasm book.
Also where would I direct general questions about usage that are probably not important enough to be issues?

Hello!
You are right to note that that portion of the docs is missing! You can learn more about npm link here in the npm docs: https://docs.npmjs.com/cli/link
We would welcome a PR that makes this more clear :)
Regarding questions about general usage that you believe are not worthy of issues:

They are worthy of issues! Please don't worry about opening issues like these. We welcome them.
You can reach us on the mozilla IRC #rust-wasm channel or the rust Discord channel #wasm-wg: https://discord.gg/BnxWJD

Feel free to reach out to me personally as @ag_dubs on IRC, Discord, or twitter!

How to use npm link can be found at this link https://rustwasm.github.io/book/game-of-life/hello-world.html under chapter 5.2 at the very bottom above Serving Locally. Would it be fine to reuse that? It seems some of those docs were meant to be part of the wasm-pack guide.

@lazypassion sorry for the delay in response! the working group has plans to deduplicate the documentation, but for the moment I think reusing that is a perfectly fine idea!

Is this still an issue? I think it can be closed:
The only where publishing to npm seems to be mentioned is: https://rustwasm.github.io/docs/book/game-of-life/publishing-to-npm.html?highlight=prere#prerequisites . And it seems like you just not run this step correct? Though npm link is "kind of" mentioned here, in a broken mardown link, but not enough I think to need to add additional documentation: https://github.com/rustwasm/wasm-pack/blob/master/docs/src/prerequisites/npm.md
If we decide this issue it still valid, I wouldn't mind trying to add docs on this. Thanks!

The tutorial now recommends referencing the package using file paths. That's much nicer than "npm link", the latter resulted in a lot of permission issues and did not work together with nvm.
I think this issue can be closed.


[FEATURE] algo::min_value, algo::min_element (2 path one)

Versions of std::min_element

https://github.com/jfalcou/eve/pull/1345


Allow CLI to read from STDIN

Makes the input file optional (defaulting to standard input), and allows - to explicitly represent standard input.
Example invocations:
$ echo '"use\x20strict"' | bin/acorn -
{
  "type": "Program",
  "start": 0,
  "end": 16,
  "body": [
    {
      "type": "ExpressionStatement",
      "start": 0,
      "end": 15,
      "expression": {
        "type": "Literal",
        "start": 0,
        "end": 15,
        "value": "use strict",
        "raw": "\"use\\x20strict\""
      }
    }
  ]
}
$ bin/acorn <<EOF
("use strict")
EOF

Maybe remove a need for special filename at all and if it wasn't passed, just use stdin?

It already does that.
I've merged this as c7428f290c9 and changed the code to use simple async reading from stdin in patch c848999fc180c

@marijnh It does perform extra check for explicit - name - I was talking about removing need for this.

There's no need for - → STDIN, it's just a standard convention.

Maybe, but when we support work without it as well, I don't see a need for introducing extra code just to handle such case. Whatever.


[VSIX] Adjust the native visualizers for VS2015/7

We need to revisit the native visualizer we ship in the language services VSIX.

This was resolved


Fix terminal width detection in the CLI

Since JLine 3.14.0 only one system Terminal can exist at once. When trying to create another system Terminal instance, a dumb terminal will be created instead that reports its width as zero. To avoid that, we create a Terminal instance only once.
Supersedes https://github.com/prestosql/presto/pull/6113
Repro case:
package pl.wendigo.jline;

import java.io.IOException;
import java.io.UncheckedIOException;

import static java.lang.String.format;
import static org.jline.terminal.TerminalBuilder.terminal;

public class Terminal
{
    public static void main(String[] args)
    {
        try {
            System.out.println(format("Terminal width is %d", terminal().getWidth()));
            System.out.println(format("Terminal width is %d", terminal().getWidth()));
        }
        catch (IOException e) {
            throw new UncheckedIOException(e);
        }
    }
}

will result in:
Terminal width is 313
Nov 27, 2020 12:35:49 PM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
Terminal width is 0

This behavior was introduced by https://github.com/jline/jline3/commit/c3317bc8b72a78dbf55d58ee79160ef8649e3f07


Missing links in DesignLabs_Unity_Examples Readme

I assume [[Holobar and bounding box|HoloBar]] and [[Billboarding and tag-a-long]] are supposed to be links.

@atouchet I have updated the missing links. I'll add the link to the App Bar and Bounding Box article once it is published. Thanks!


Kubeless CLI can't parse kubeconfig

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
kubeless CLI errors on any command with the following;
FATA[0000] Can not get kubernetes config: invalid configuration: no configuration has been provided
What you expected to happen:
kubeless CLI should be able to parse bare kubeconfig and run from a controller node against localhost:8080.
How to reproduce it (as minimally and precisely as possible):
Run any kubeless CLI function from a controller node with the kubeconfig below.
Anything else we need to know?:
~/.kube/config;
apiVersion: v1
clusters: []
contexts:

context:
cluster: ""
namespace: kubeless
user: ""
name: kube-system
current-context: kube-system
kind: Config
preferences: {}
users: []

Environment:

Kubernetes version (use kubectl version): v1.14.1
Kubeless version (use kubeless version): v1.0.3
Cloud provider or physical cluster:
Mixed Openstack/Baremetal worker nodes.

Hi @josh-ferrell,
Right now Kubeless needs a valid configuration in order to access the cluster. We are using the same approach than kubectl. Are you able to access your cluster using kubectl?

Yes we are. If no cluster is specified kubectl uses the localhost access on port 8080. It doesn't require authorization or authentication but can only be accessed by the first having access to the host running the apiserver.


Allow non-client-side routes

There are cases in which I'd like a request to go to the server; for instance, I have Passport.js handling social media login (e.g. Facebook) and logout. Prior to using React Router, I'd GET /auth/fb to kick off the login process (and /logout to log out).
For /logout, I could make an AJAX request, but I'm not sure that'll work so well for login. I'd like to be able to have specific requests go to the server rather than being handled client side. Maybe a separate prop on a route, e.g
<Route path="/auth/fb" passToServer />

in which case the history listener will not intercept it.

You should just use an anchor to navigate to URLs outside of your application (even if they are on the same domain).
Login with Facebook

That still throws a warning that Warning: [react-router] Location "/auth/fb" did not match any routes

Ah, I apologize, my app was configured incorrectly; I had the authentication routes commented out. Adding them back in worked.


User interface is not compatible with ultrawide screen resolutions.

A user has reported that some user interface elements appear partially or completely off screen. His resolution is 2560x1080 21:9

A testing tip from the user who reported this issue:
"21 March 2018, 4:50AM
ok, but it doesn't need any additional equipments to test the issue. simply you can adjust your resolution to 1920x816(if you have a FHD monitor) and run the game on windows mode."


Trackevent make crash my App on iOS 9

Anyone have the same problem or have a solution for that?
The strange thing is that only when it's called in some views, not all.
Trackscreen work perfectly.
This is the crash report:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0   libobjc.A.dylib               	0x05ccd4da objc_msgSend + 26 1   libobjc.A.dylib               	0x05cd0059 -[NSObject performSelector:withObject:] + 70 2   it.biotiful.bioapp            	0x00743cf4 __42-[AnalyticsGoogleTrackerProxy trackEvent:]_block_invoke + 51 (AnalyticsGoogleTrackerProxy.m:77)

Can you tell us as to when are you calling the trackEvent method? Have you
tried moving the call and see if that works. Like making it the first line
of code on the JS
On Sunday, February 28, 2016, univers3<EMAIL_ADDRESS>wrote:

Anyone have the same problem or have a solution for that?
The strange thing is that only when it's called in some views, not all.
TrackEvent work perfectly.
This is the crash report:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libobjc.A.dylib 0x05ccd4da objc_msgSend + 26
1 libobjc.A.dylib 0x05cd0059 -[NSObject performSelector:withObject:] + 70
2 it.biotiful.bioapp 0x00743cf4 __42-[AnalyticsGoogleTrackerProxy
trackEvent:]_block_invoke + 51 (AnalyticsGoogleTrackerProxy.m:77)
—
Reply to this email directly or view it on GitHub
https://github.com/Sitata/titanium-google-analytics/issues/54.

In my first attempts I was trying to call them in the last part of the code.
Now I tried in the beginning with the same result (Crashed):
var GoogleA = require("analytics.google");
	var track = GoogleA.getTracker("UA-XXXXXXXX-X");

	track.trackEvent({
	    category: "Settings",
	    action: "Opened"
	});
	track.trackScreen({
    	screenName: "Settings"
	});

If you create a sample application with call to the module only, no other
code, is it working fine after you build? What is the SDK version you are
using to build the application. 5.2.0?
On Sunday, February 28, 2016, univers3<EMAIL_ADDRESS>wrote:

In my first attempts I was trying to call them in the last part of the
code.
Now I tried in the beginning with the same result (Crashed):
var GoogleA = require("analytics.google");
var track = GoogleA.getTracker("UA-XXXXXXXX-X");
track.trackEvent({
    category: "Settings",
    action: "Opened"
});
track.trackScreen({
    screenName: "Settings"
});

—
Reply to this email directly or view it on GitHub
https://github.com/Sitata/titanium-google-analytics/issues/54#issuecomment-189921294
.

Yep, 5.2.0.GA

Ok. Can you check with a sample application
On Sunday, February 28, 2016, univers3<EMAIL_ADDRESS>wrote:

Yep, 5.2.0.GA
—
Reply to this email directly or view it on GitHub
https://github.com/Sitata/titanium-google-analytics/issues/54#issuecomment-189921673
.

The sample app worked flawlessly.
The problem was in my app: a double init of the module. (GetTracker function)
In Android that double call will raise no errors, but in iOS will result in crashes, at least in my case.
Thank you @soumyakantikar for your support and patience.

Great news, that it is resolved. Code strong.
On Monday, February 29, 2016, univers3<EMAIL_ADDRESS>wrote:

The sample app worked flawlessly.
The problem was in my app: a double init of the module. (GetTracker
function)
In Android that double call will raise no errors, but in iOS will result
in crashes, at least in my case.
Thank you @soumyakantikar https://github.com/soumyakantikar for your
support and patience.
—
Reply to this email directly or view it on GitHub
https://github.com/Sitata/titanium-google-analytics/issues/54#issuecomment-190458521
.


Update GitHub Actions Node version

The most recent GitHub Action to setup Terraform requires NodeJS v20.

This is breaking the acceptance workflow: https://github.com/thoughtbot/flightdeck/actions/runs/7250366637/job/19750377076#step:8:12


get request load error

use phone browser to load url ，for example http://<IP_ADDRESS>:8080/index.html ，can load success ，but like this http://<IP_ADDRESS>:8080/index.html？a=1&b=2 load fail ，why？

seems that params be losed

phone browser can not read the params of the url

sorry This is my problem ，


Axios bump to >=0.21.2

Hi there,
is it possible to bump axios again? The required security fix is trivial, see: https://github.com/axios/axios/pull/3980
but it is hard for me to know, whether the accompanying changes would break acme-client...
Or is it not necessary, because in acme-client's usage of axios the vulnerability will never be executed anyway (which is, what I think...)
Thanks for any thoughts!
Michael.

Hey! 👋 Fixed in a93584f and published with v4.1.4.


Would pls add Fever Api Support?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

No issue

Describe the solution you'd like
A clear and concise description of what you want to happen.

Fever API is common support by many self-host RSS server like TT-RSS, miniflux. On MacOS/iOS,  reeder app can sync with it, but on windows, I couldn't find one replacement, it is very helpful if raven reader support this feature.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Recently I did it by myself, realize fever api sync and so on base on raven reader, cause a lot of custom changes, named it Spark Reader(https://github.com/matoung/SparkReader)
Thanks for raven reader and the authors, this issue can be closed.

@matoung Nice work there. Do you mind if I use some of your solution that solves the current problem I am working on? Also, you could have contributed to this repo.

@mrgodhani You can use anything, with pleasure :)


Any Suggestions to Get Best Training Results With Small Datasets?

Hi @MasayaKawamura !
Thanks for sharing your work with the community, really appreciate it.
I gave it a try (single speaker settings) with around 2 hrs of data. Was able to get some results after around 25K steps and kept it running up-to around 75K steps. But, still there are not much improvements (issues like mispronunciation, some background noise).
Moreover, Its able to generate sentences in some of the training set well, but can't on others from training or test set.
Any suggestions in terms of datasets/settings or way to move forward?
Some samples can be found here.
Thanks

Hi @Ahmer-444, I'm sorry to be late...
Thank you for your question
I have some concerns.

Your data set is composed of 2 hours file. However, LJ speech dataset is total length of approximately 24 hours, so there is a big gap. when the model train, did you use data augmentation?
Have you checked if the loss is going down?

Thanks @MasayaKawamura for your response.
I was able to train and fix the above problems and now I'm working with around ~4hrs of the audio dataset. The synthesized voice sounds pretty cool but still has a little robotic undertone. Do you have any suggestions to improve it?
You can listen to the synthesis voice here.
The Attention and Loss graphs looks like this:

If the model used deterministic duration predictor, how about changing it to stochastic duration predictor?
You can change the duration predictor by modifying this line.


Fix #17458

#17458

@indecisivemal : Thanks for your contribution! The author, @mgoedtel, has been notified to review your proposed change.

@indecisivemal - Thanks for taking the time to submit your proposed changes to help improve this article.  After reviewing your contribution, I approve for merging and release #sign-off.

@tysonn : Thanks for your contribution! The author, @mgoedtel, has been notified to review your proposed change.

@tysonn : Thanks for your contribution! The author, @mgoedtel, has been notified to review your proposed change.


[FLINK-20678] Let JobManagerRunnerImpl fail if the JobMasterService fails unexpectedly

What is the purpose of the change
This is a safety net which ensures that the JobManagerRunnerImpl will fail if the
JobMasterService fails unexpectedly.
This PR is based on #14431.
Verifying this change
I added JobManagerRunnerImplTest.testJobMasterServiceTerminatesUnexpectedlyTriggersFailure
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the review @zentol. I've addressed your comments and will now merge the PR.


Intel Aero: Inspect mag interference

It has a big issue with the mag. @jgoppert That explains why LPE is struggling. @lfelipe @lucasdemarchi I checked and we should be using the mag in the GPS. It should not be so influenced by current.

This might be enough to fix it: https://github.com/PX4/Firmware/pull/5979
The proper fix is to use the right priorities in all drivers. But this is the safer, quick option for the release.

I didn't know start order matters. Isn't there a parameter to select primary compass?

It happens on publication (ORB_PRIO_HIGH). I bet that this is inconsistent in one of the drivers, leading to the result.


"month-change-on-scroll" unusable on Macbook trackpad

Describe the bug
When using the month-change-on-scroll feature with the trackpad of my Macbook Pro (16' M1 Max), it's basically unusable, because there is no throttling and the months change incredibly fast. This is because apple does some kind of smooth scrolling magic with it's trackpad. So I would suspect this to also happen with apple's magic mouse or other devices, that do some smooth scrolling magic.
I created a minimal demo:
https://stackblitz.com/edit/vitejs-vite-6ukqj9?file=src%2FApp.vue
(this demo somehow fails in safari, seems to be a stackblitz bug with vite)
To Reproduce
Steps to reproduce the behavior:

Go to my Stackblitz demo (or create your own minimal datepicker instance with :month-change-on-scroll="true")
Scroll through the months on a Macbook Pro, and see the months change at uncontrollable pace

Expected behavior
I would expect an upper and lower bound for how fast months are switched. So some sort of throttling.
Screenshots
Me attempting to scroll the minimal possible distance with the trackpad:
https://github.com/Vuepic/vue-datepicker/assets/45046461/2f38a626-a2dc-4021-bd4c-57bf6131c411
Desktop & mobile (please complete the following information):

Operating system [MacOS]
Browser [chrome, firefox, safari]
Library version ["@vuepic/vue-datepicker": "^7.3.0"]

@Jasenkoo Thanks for adding this so quickly, I really appreciate it and look forward to the next release!


When to support SCSS style？

When to support SCSS style？

this project is dead :-(
you can switch to fomantic-ui


feat: multi-network upgrade handler

Closes: #XXX
What is the purpose of the change
This PR introduces logic to the upgrade handler to work with both osmosis-1 and any other network-id (but specifically for osmo-test-5).
If the network ID matches the mainnet ID, osmo-test-a, or osmo-test-b, we create CL pools for all balancer pools defined in the asset pairs struct. Note, we use osmo-test-a and osmo-test-b for E2E, so we want to use the same upgrade handler that mainnet uses whenever possible.
If the network ID is something else, we create CL pools for all existing balancer pools.
From that point, the logic is shared.
A majority of the logic in the PR was pre-existing, but was extracted from the CreateUpgradeHandler method to make it easier to parse.
I did, however, make a core logic change to the upgrade handler where, instead of expecting the baseAsset to be in the community pool already, we swap 0.1 OSMO for the base asset, which is enough to create a full range position.
Testing and Verifying
The upgrade_test.go file was updated to test both "osmosis-1" and "osmo-test-5" network ID.
Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

devbot add changelog misc allow testing with different chain-id's in E2E testing

devbot merge base;
fix

devbot fix

devbot fix

devbot fix

devbot fix

devbot fix

devbot help

devbot help

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
- `devbot fix`: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
- `devbot merge base`: Merge the base branch into the PR branch.
- `devbot add changelog [misc/feat/api/sec] [message]`: Add a changelog entry to the PR. (e.g. `devbot add changelog feat Added a new feature`)
    - If message is blank, defaults to PR title.
- `devbot re-pr`: Re-PR the PR, useful for external contributors where we have no edit perms.


Awesome books: a complete website with navigation

In this pull

A Navigation bar.
Three content sections:
Books list.
Add book form.
Contact info.

Status: Approved ✔
Hi Oybek & Sentayhu,
Your project is complete! Great job for nailing it right on the first attempt 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟
Good Points 👍

Descriptive Pull Request
Navigation properly implemented
App is running as intended
Good ReadMe
Nice UI design
No linter errors

Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

Thank You


Error package because of receiving data before handshake

Hi there,
I'm trying to run a basic WebSocket server as described in the README.md.
<?php

use Workerman\Worker;

require __DIR__  . '/../../vendor/autoload.php';

// Create a Websocket server
$ws_worker = new Worker('ws://<IP_ADDRESS>:2346');

// Emitted when new connection come
$ws_worker->onConnect = function ($connection) {
    echo "New connection\n";
};

// Emitted when data received
$ws_worker->onMessage = function ($connection, $data) {
    // Send hello $data
    $connection->send('Hello ' . $data);
};

// Emitted when connection closed
$ws_worker->onClose = function ($connection) {
    echo "Connection closed\n";
};

// Run worker
Worker::runAll();

The WebSocket server is started OK.
php cli/workerman/example.php start
Workerman[cli/workerman/example.php] start in DEBUG mode
------------------------------------------- WORKERMAN --------------------------------------------
Workerman version:4.1.14          PHP version:8.3.1           Event-Loop:\Workerman\Events\Select
-------------------------------------------- WORKERS ---------------------------------------------
proto   user            worker          listen               processes    status
tcp     standard        none            ws://<IP_ADDRESS>:2346    1             [OK]
--------------------------------------------------------------------------------------------------
Press Ctrl+C to stop. Start success.

However, it'll throw a package error because of receiving data before the handshake.
php cli/workerman/example.php start
Workerman[cli/workerman/example.php] start in DEBUG mode
------------------------------------------- WORKERMAN --------------------------------------------
Workerman version:4.1.14          PHP version:8.3.1           Event-Loop:\Workerman\Events\Select
-------------------------------------------- WORKERS ---------------------------------------------
proto   user            worker          listen               processes    status
tcp     standard        none            ws://<IP_ADDRESS>:2346    1             [OK]
--------------------------------------------------------------------------------------------------
Press Ctrl+C to stop. Start success.
New connection
recv data before handshake. Buffer:474554202f20485454502f312e310d0a486f73743a203132372e302e302e313a323334360d0a436f6e6e656374696f6e3a20557067726164650d0a507261676d613a206e6f2d63616368650d0a43616368652d436f6e74726f6c3a206e6f2d63616368650d0a557365722d4167656e743a204d6f7a696c6c612f352e3020285831313b204c696e7578207838365f363429204170706c655765624b69742f3533372e333620284b48544d4c2c206c696b65204765636b6f29204368726f6d652f3132302e302e302e30205361666172692f3533372e33360d0a557067726164653a20776562736f636b65740d0a4f726967696e3a2068747470733a2f2f63686573732d7365727665722e646f63732e63686573736c61626c61622e6f72670d0a5365632d576562536f636b65742d56657273696f6e3a2031330d0a4163636570742d456e636f64696e673a20677a69702c206465666c6174652c2062720d0a4163636570742d4c616e67756167653a20656e2d55532c656e3b713d302e390d0a5365632d576562536f636b65742d4b65793a20714c4e545141576e583339676c65477031372f7543513d3d0d0a5365632d576562536f636b65742d457874656e73696f6e733a207065726d6573736167652d6465666c6174653b20636c69656e745f6d61785f77696e646f775f626974730d0a0d0a
Error package. package_length=falseConnection closed

By the way, I'm trying to connect to the WebSocket server through the JavaScript console as shown in the image below.

WebSocket connection to 'ws://<IP_ADDRESS>:2346/' failed:

Any help will be very much appreciated!
Thank you,

Hi Jordi Bassagana
new (‘websocket://<IP_ADDRESS>:2346’);
------------------ Original ------------------
From: Jordi Bassagana @.>
Date: Tue,Jan 30,2024 5:41 PM
To: walkor/workerman @.>
Cc: Subscribed @.***>
Subject: Re: [walkor/workerman] Error package because of receiving data beforehandshake (Issue #1007)
Hi there,
I'm trying to run a basic WebSocket server as described in the README.md.
 <?php use Workerman\Worker; require __DIR__  . '/../../vendor/autoload.php'; // Create a Websocket server $ws_worker = new Worker('ws://<IP_ADDRESS>:2346'); // Emitted when new connection come $ws_worker->onConnect = function ($connection) {     echo "New connection\n"; }; // Emitted when data received $ws_worker->onMessage = function ($connection, $data) {     // Send hello $data     $connection->send('Hello ' . $data); }; // Emitted when connection closed $ws_worker->onClose = function ($connection) {     echo "Connection closed\n"; }; // Run worker Worker::runAll();

The WebSocket server is started OK.
 php cli/workerman/example.php start Workerman[cli/workerman/example.php] start in DEBUG mode ------------------------------------------- WORKERMAN -------------------------------------------- Workerman version:4.1.14          PHP version:8.3.1           Event-Loop:\Workerman\Events\Select -------------------------------------------- WORKERS --------------------------------------------- proto   user            worker          listen               processes    status            tcp     standard        none            ws://<IP_ADDRESS>:2346    1             [OK]             -------------------------------------------------------------------------------------------------- Press Ctrl+C to stop. Start success.
However, it'll throw a package error because of receiving data before the handshake.
 php cli/workerman/example.php start Workerman[cli/workerman/example.php] start in DEBUG mode ------------------------------------------- WORKERMAN -------------------------------------------- Workerman version:4.1.14          PHP version:8.3.1           Event-Loop:\Workerman\Events\Select -------------------------------------------- WORKERS --------------------------------------------- proto   user            worker          listen               processes    status            tcp     standard        none            ws://<IP_ADDRESS>:2346    1             [OK]             -------------------------------------------------------------------------------------------------- Press Ctrl+C to stop. Start success. New connection recv data before handshake. Buffer:474554202f20485454502f312e310d0a486f73743a203132372e302e302e313a323334360d0a436f6e6e656374696f6e3a20557067726164650d0a507261676d613a206e6f2d63616368650d0a43616368652d436f6e74726f6c3a206e6f2d63616368650d0a557365722d4167656e743a204d6f7a696c6c612f352e3020285831313b204c696e7578207838365f363429204170706c655765624b69742f3533372e333620284b48544d4c2c206c696b65204765636b6f29204368726f6d652f3132302e302e302e30205361666172692f3533372e33360d0a557067726164653a20776562736f636b65740d0a4f726967696e3a2068747470733a2f2f63686573732d7365727665722e646f63732e63686573736c61626c61622e6f72670d0a5365632d576562536f636b65742d56657273696f6e3a2031330d0a4163636570742d456e636f64696e673a20677a69702c206465666c6174652c2062720d0a4163636570742d4c616e67756167653a20656e2d55532c656e3b713d302e390d0a5365632d576562536f636b65742d4b65793a20714c4e545141576e583339676c65477031372f7543513d3d0d0a5365632d576562536f636b65742d457874656e73696f6e733a207065726d6573736167652d6465666c6174653b20636c69656e745f6d61785f77696e646f775f626974730d0a0d0a Error package. package_length=falseConnection closed
By the way, I'm trying to connect to the WebSocket server through the JavaScript console as shown in the image below.

Screenshot.2024-01-<IP_ADDRESS>.png (view on web)
 WebSocket connection to 'ws://<IP_ADDRESS>:2346/' failed:
Any help will be very much appreciated!

Thank you,

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>
Thanks for the response,
const ws = new WebSocket('ws://<IP_ADDRESS>:2346');

It seems though as if the websocket protocol can't be used in the JavaScript code.
Uncaught DOMException: Failed to construct 'WebSocket': The URL's scheme must be either 'ws' or 'wss'. 'websocket' is not allowed.
    at <anonymous>:1:12

The URL's scheme must be either ws or wss.

walkor means modify in PHP, not JS.
<?php

use Workerman\Worker;

require_once __DIR__ . '/vendor/autoload.php';

// Create a Websocket server
$ws_worker = new Worker('websocket://<IP_ADDRESS>:2346');

// Emitted when new connection come
$ws_worker->onConnect = function ($connection) {
    echo "New connection\n";
};

// Emitted when data received
$ws_worker->onMessage = function ($connection, $data) {
    // Send hello $data
    $connection->send('Hello ' . $data);
};

// Emitted when connection closed
$ws_worker->onClose = function ($connection) {
    echo "Connection closed\n";
};

// Run worker
Worker::runAll();

let socket = new WebSocket("ws://<IP_ADDRESS>:2346");

socket.onopen = function(e) {
  alert("[open] Connection established");
  alert("Sending to server");
  socket.send("My name is John");
};

socket.onmessage = function(event) {
  alert(`[message] Data received from server: ${event.data}`);
};

socket.onclose = function(event) {
  if (event.wasClean) {
    alert(`[close] Connection closed cleanly, code=${event.code} reason=${event.reason}`);
  } else {
    // 例如服务器进程被杀死或网络中断
    // 在这种情况下，event.code 通常为 1006
    alert('[close] Connection died');
  }
};

socket.onerror = function(error) {
  alert(`[error] ${error.message}`);
};
```


[navigation]feat: update nav category and workspaceAvailability

Description
[Describe what this change achieves]
Before fix

After fix

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

let's update the snapshots, to fix the UT failure

@SuZhou-Joe looks like the unit tests are failing in this PR. Seems like it may just be because of outdated snapshots. E.g.,
yarn run test:jest -u

Could you investigate, and raise a PR to fix?

@SuZhou-Joe looks like the unit tests are failing in this PR. Seems like it may just be because of outdated snapshots. E.g.,
yarn run test:jest -u

Could you investigate, and raise a PR to fix?

Never mind. PR https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/1095 fixes them.


DRAFT: Reflecting on some things...

Checklist

[ ] make test-all (UNIX) passes. CI will also test this
[ ] unit and/or integration tests are included (if applicable)
[ ] documentation is changed or added (if applicable)

Description of change

Experimenting with using reflect to remove some of the verbosity.
Pros:

Lots of hardcoded code removed/replaced with dynamic code

Cons:

Reflect can cause runtime errors, we lose the static typing checks
Reflect is rather difficult to work with/understand (at least to me it is)
Reflect is slower, but in our context, this doesn't matter
As it stands today, goss doesn't have a ton of checks.. so the return on investment might not be worth it

@ripienaar , @pedroMMM I'd love your thoughts on this.
I'm on the fence and have resisted merging in the original small_refactor branch due to the Cons listed above.
Guess it's a fun experiment.. that I'm not sure I want to go ahead with.. but I'm curious on others feedbacks =)

Reflect can cause runtime errors, we lose the static typing checks

As I mentioned on the code we can add some extra checks in there to ensure everything is still ok. It's still a con but it can be mitigated.

Reflect is rather difficult to work with/understand (at least to me it is)

True reflection isn't the easier thing to follow, so it should be used sparsely.

Reflect is slower, but in our context, this doesn't matter

True reflection isn't cheap, so again it should be used sparsely.

As it stands today, goss doesn't have a ton of checks.. so the return on investment might not be worth it

The simpler the code base is, the easier for bigger and more ambitions improvements are to take place.   I understand the redundancy to add reflection but it exists for a reason and sometimes is the correct tool.


Update code to support Python 3 (tested under 3.6).

Coverage increased (+0.3%) to 89.214% when pulling e4b3873a0028bf707dea8da68c865fec91222d75 on python3 into fbced637cbfd478e23ee08973af80a3763eb4b94 on master.


Export Search

Heres a new search it compares the minimum prices of items on multiple servers at once.
This is for people with alts on lots of servers that have many options where to sell an item that they have.  They want to know what servers their items will be worth the most on so we get the minimum prices for a few different items at once.
http://api.saddlebagexchange.com/api/export
api post body
  {
    "home_server": "Famfrit",
    "export_servers": ["Lamia","Seraph"],
    "item_ids": [33275,4745],
    "hq_only": false
  }

result example ( if the price is 0 then it means the item is out of stock)
{
    "33275": {
        "Famfrit": 147000,
        "Lamia": 344400,
        "Seraph": 0
    },
    "4745": {
        "Famfrit": 63,
        "Lamia": 52,
        "Seraph": 73
    }
}

Is there any chance of turning the response into a list which has the itemId as a property in the object?

@cohenaj194
On the sidebar there are going to be lots of buttons under the FF14 section, would it be worth looking over the buttons and grouping them differently?


Improve hyphenation on part pages.

Some part pages (just 1 or 2) have hyphenation that could be improved.
We discussed adding stricter rules for the part page headings.
Possible fallbacks:

Change long titles in the WikiBook
Manually change hyphenation before print

Did you find out anything that helps us solve this issue?
We can set the \hyphenpenalty to restrict or disable hyphenation. In our cases, however, the words in question are Häufungspunkte and Konvergenzkriterien, which are too long to fit into a line. So all we can do is to set the break in the word manually. This can be done using \hyphenation, but it must be done for every word individually.

(we wait until analysis1_final builds again to see if @kulla's renaming of headers already fixed the issue)

Done at https://github.com/kulla/mfnf-analysis1-lmu-print2018

Done for LMU-Print, but still a problem with generated PDFs.
As with #102 I think they should stay open here.


Range slider gets stuck by function call in onValueChange prop

Describe the bug
This issue is related to the original question I asked, https://github.com/Sharcoux/slider/issues/80, but I wasn't able to reproduce it at the time. I've now finally been able to do that. It was working in my code in v6, but stopped working when upgrading to v7, and I wasn't sure what it was. I initially called console.log at steps a) onSlidingStart, b) onValueChanged and c) onSlidingComplete. I noticed that when I called a function (in this case useRef setState) inside onValueChanged, it would never call c, and thus the slider seems to be stuck. I have a temp function I call to update the UI in onValueChanged before finally changing the value in onSlidingComplete, and in upgrading it got stuck.
To Reproduce

Go to this Snack

Expected behavior
Range slider should be scrollable after upgrading to v7 of the plugin
Please complete the following information:

OS: iOS (seems to be Android/web too) while looking at the snack
Browser [e.g. chrome, safari]
@react-native-assets/slider version : latest (but suspect it's from 7 updwards)

The problem is there: range={[13, 21]}
On every render, this generates a new array. This is interpreted as a reassignment of the current slider value, making it "stuck" to its initial location

@Sharcoux - ok thanks, let me investigate a bit more then why the upgrade seems to break it.

The old version had a bug where it was not possible to reassign the slider value from what I remember.

 The docs seem to suggest range={[0, 1]} so just wanted to understand

You misunderstand the problem.
You can solve this with, for instance: const range = React.useMemo(() => [0, 1], [])
Or define the range as a const outside the component render function
Or use const range = React.useRef([0, 1]).current
Anything that will rely on a fix reference.
To understand the problem, you need a good understanding of what we mean by "comparison by value or by reference", and a good comprehension of React hooks render cycle.


vote: v1.1.1

Release
This would mean tagging 8d3b7a22a70a7d0e5e71f4f717ccbb03eb9ae59e as v1.1.1 to release.

[!Note]
This release doesn't include the #379 as this is a patch release.

The commit 8d3b7a22a70a7d0e5e71f4f717ccbb03eb9ae59e was generated by the following steps:

Checked out a new branch: git checkout -b release-1.1 v1.1.0
Cherry-picked all commits from the main branch, excluding #379, starting from<PHONE_NUMBER>aca0f5f811263be091cdd17a26562a and ending with 254dfcde664212784c8116200efb97e17b30683d, totaling 23 commits. Conflicts were also resolved.
Pushed to origin as the release-1.1 branch.

Vote
We need at least 4 approvals from 6 maintainers to release notation-go v1.1.1.

[x] Junjie Gao (@JeyJeyGao)
[ ] Milind Gokarn (@gokarnm)
[x] Patrick Zheng (@Two-Hearts)
[ ] Pritesh Bandi (@priteshbandi)
[ ] Rakesh Gariganti (@rgnote)
[ ] Shiwei Zhang (@shizhMSFT)

Changes
The code changes compared to v1.1.0 include:

fix: update error message by @JeyJeyGao in https://github.com/notaryproject/notation-go/pull/380
bump: bump up oras-go and image-spec by @Two-Hearts in https://github.com/notaryproject/notation-go/pull/381
chore: start using plugin-framework package by @priteshbandi in https://github.com/notaryproject/notation-go/pull/372
build(deps): bump golang.org/x/crypto from 0.18.0 to 0.19.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/383
build(deps): bump github.com/opencontainers/image-spec from 1.1.0-rc6 to 1.1.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/385
build(deps): bump golang.org/x/mod from 0.14.0 to 0.15.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/384
chore: updated/added deprecation message by @priteshbandi in https://github.com/notaryproject/notation-go/pull/382
build(deps): bump golang.org/x/crypto from 0.19.0 to 0.20.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/387
chore: add GitHub action for stale issues and PRs by @yizha1 in https://github.com/notaryproject/notation-go/pull/365
build(deps): bump golang.org/x/crypto from 0.20.0 to 0.21.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/389
build(deps): bump golang.org/x/mod from 0.15.0 to 0.16.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/388
fix: Add contract version to plugin sign request and plugin verify request by @priteshbandi in https://github.com/notaryproject/notation-go/pull/390
bump: bump golang and dependency versions by @Two-Hearts in https://github.com/notaryproject/notation-go/pull/392
build(deps): bump actions/stale from 8 to 9 by @dependabot in https://github.com/notaryproject/notation-go/pull/391
Moved org maintainers to emeritus by @toddysm in https://github.com/notaryproject/notation-go/pull/393
build(deps): bump golang.org/x/mod from 0.16.0 to 0.17.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/397
build(deps): bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.7 by @dependabot in https://github.com/notaryproject/notation-go/pull/395
build(deps): bump github.com/go-ldap/ldap/v3 from 3.4.7 to 3.4.8 by @dependabot in https://github.com/notaryproject/notation-go/pull/399
build(deps): bump golang.org/x/crypto from 0.21.0 to 0.22.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/396
build(deps): bump golang.org/x/crypto from 0.22.0 to 0.23.0 by @dependabot in https://github.com/notaryproject/notation-go/pull/403
test: improve test coverage to 80% by @JeyJeyGao in https://github.com/notaryproject/notation-go/pull/405
fix: error message for dangling reference index by @JeyJeyGao in https://github.com/notaryproject/notation-go/pull/402
bump: bump up notation-core-go v1.0.3 by @JeyJeyGao in https://github.com/notaryproject/notation-go/pull/407

Full Changelog: https://github.com/notaryproject/notation-go/compare/v1.1.0...8d3b7a22a70a7d0e5e71f4f717ccbb03eb9ae59e

LGTM

LGTM

I have concerns about the process of generating the release-1.1 branch since the hashes of all commits after v1.1.0 are changed without proper reviews. Meanwhile, there is no proof that the resulted head of the branch release-1.1 passes all the checks we set for the main branch.
Therefore, I'd like to propose a more compliant way to generate the release-1.1 branch.

Delete the existing release-1.1 branch
Update build.yml, codeql.yml, and license-checker.yml in the main branch to include release-* (see samples)
Set a branch protection rule for release-* with the same settings as main.
Checkout release-1.1 based on main. Send a PR to release-1.1 to revert #379.
Close this issue and create a new issue to vote on the latest commit of the release-1.1 branch

I have concerns about the process of generating the release-1.1 branch since the hashes of all commits after v1.1.0 are changed without proper reviews. Meanwhile, there is no proof that the resulted head of the branch release-1.1 passes all the checks we set for the main branch.
Therefore, I'd like to propose a more compliant way to generate the release-1.1 branch.

Delete the existing release-1.1 branch
Update build.yml, codeql.yml, and license-checker.yml in the main branch to include release-* (see samples)
Set a branch protection rule for release-* with the same settings as main.
Checkout release-1.1 based on main. Send a PR to release-1.1 to revert feat: add support for signing blob #379.
Close this issue and create a new issue to vote on the latest commit of the release-1.1 branch

@priteshbandi How about this: instead of cherry-picking each commit, we just revert #379 in release-1.1 branch?

LGTM


EKF2, FW, VTOL modules don't poll parameter_update

Not the core issue causing EKF time slip with param saves, but helps a bit.
https://github.com/PX4/Firmware/pull/7569

Okay to merge?


Introduce logging with logrus

unify all log messages to begin with capital letter
introduce different log levels

Fix #10

Pull Request Test Coverage Report for Build 231434520

12 of 23 (52.17%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.663%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/front-end/server/users_handlers.go
0
2
0.0%

cmd/front-end/server/games_handlers.go
0
4
0.0%

cmd/api/server/users_handlers.go
1
6
16.67%

Totals

Change from base Build 231427117:
0.0%

Covered Lines:
380

Relevant Lines:
659

💛  - Coveralls


Reorganise Repo to support having both theme and plugin metadata specifications

Reorganised repo and fixed readme files to support the repo containing both plugin and theme specs. For now there is only the plugin specification but themes will be added soon by @antpb
Pull Request
What changed?
We reorganised the GitHub repo and fixed readme files to support the repo containing both plugin and theme specs.
Why did it change?
This allows us to have both specifications in one location
Did you fix any specific issues?
None. For now, there is only the plugin specification but themes will be added soon by @antpb
CERTIFICATION
By opening this pull request, I do agree to abide by
the CODE OF CONDUCT and be bound by the terms
of the Contribution Guidelines in effect on the date and time
of my contribution as proven by the
revision information in GitHub. I also agree that any previous contributions shall be deemed subject to the terms of the
version in effect on the date and time of this pull request, or any future revisions for pull requests I may submit.
Further, I certify that this work is my own, is original, does not violate the intellectual property of any other person
or entity, and I am not violating any license agreements or contracts I have with any person or entity. Finally, I agree
that this code may be licensed under any license deemed appropraite by AspirePress, including but not
limited to open source, closed source, proprietary or custom licenses, and that such license terms neither violate my
rights or my copyright to this code.

Looks good!


Unable to run locally on macOS

Attempting to run vagrant up to run locally.
➜  snowplow-mini git:(master) ✗ vagrant up --provision
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'ubuntu/bionic64' version '20210407.0.0' is up to date...
==> default: Running provisioner: shell...
    default: Running: /var/folders/75/99sb8rv1693c94d4sxxq8pw00000gn/T/vagrant-shell20210409-3549-f1k2ze.bash
    default: Hit:1 http://archive.ubuntu.com/ubuntu bionic InRelease
    default: Hit:2 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
    default: Hit:3 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
    default: Hit:4 http://security.ubuntu.com/ubuntu bionic-security InRelease
    default: Reading package lists...
    default: Reading package lists...
    default: Building dependency tree...
    default:
    default: Reading state information...
    default: E: Version '1.16.0-1ubuntu0.2' for 'python-paramiko' was not found
    default: sudo: pip: command not found
    default: sudo
    default: :
    default: pip: command not found
    default: sudo: pip: command not found
    default: sudo: pip: command not found
    default: /tmp/vagrant-shell: line 24: ansible-playbook: command not found
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

pip is installed and available on my PATH.

I can also replicate this locally, it looks like something has changed the move to ubuntu/bionic64 which is causing this. Will need some more investigation to confirm though.
For a fix/workaround...
Open vagrant/up.bash and update the dependencies section (lines 6 to 12) to look like this:
apt-get update
apt-get install -y language-pack-en python-pip libffi-dev libssl-dev python-dev
sudo pip install --upgrade pip
sudo pip install markupsafe==1.1.1
sudo pip install setuptools==40.8.0
sudo pip install paramiko==1.16.0
sudo sh -c 'echo "ubuntu ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers'

Ensure you run vagrant destroy before running vagrant up again.


Api-versioning and RouteBuilder not working together in Core 2.0

I am upgradin our Core 1.1.2 project to core 2.0 and I am having an issue with Mvc.Versioning
no longer working with RouteBuilder.
I am using RouteBuilder to branch the pipeline for api and swagger.
public void Configure(IApplicationBuilder app, IHostingEnvironment env,
IServiceProvider serviceProvider, ILoggerFactory loggerFactory, IApplicationLifetime appLifetime)
{
  // Branch pipeline for api and swagger
  var routeBuilder = new RouteBuilder(app);
  routeBuilder.MapMiddlewareRoute("api/{*path}", (IApplicationBuilder api) =>
  {
    api.UseCors(builder =>
     builder.AllowAnyOrigin()
       .AllowAnyHeader()
       .AllowAnyMethod());

    api.UseAuthentication();

    api.UseMiddleware<ErrorResponseMiddleware>();

    api.UseMultitenancy<Tenant>();

    api.UseUserResolution<User>();

    api.UseMvc();

  });

  if (enableSwagger)
  {
    routeBuilder.MapMiddlewareRoute("swagger/{*path}", (IApplicationBuilder swag) =>
    {
      swag.UseStaticFiles();

      initializeAutoMapper(serviceProvider);

      swag.UseSwagger(c =>
      {
        c.PreSerializeFilters.Add((swaggerDoc, httpRequest) =>
        {
          swaggerDoc.Host = httpRequest.Host.Value;
        });
      });

      swag.UseSwaggerUI(c =>
      {
        c.SwaggerEndpoint("/swagger/v1/swagger.json", "API v1");
        c.SwaggerEndpoint("/swagger/v2/swagger.json", "API v2");

        if (!enableSwaggerDataSubmit)
          c.SupportedSubmitMethods(new[] { "get", "head" });
      });
    });
  }

  var router = routeBuilder.Build();
  app.UseRouter(router);
}

On ConfigureServices I add versioning:
services.AddApiVersioning(o =>
{
o.AssumeDefaultVersionWhenUnspecified = true;
o.DefaultApiVersion = new Microsoft.AspNetCore.Mvc.ApiVersion(2, 0);
o.ApiVersionReader = new HeaderApiVersionReader("api-version");
});
This code has worked on Core 1.1.2. On Core 2.0 endpoint returns 404 and does not cause any exeptions.
If I remove services.AddApiVersioning the api works.
If I don't use RouteBuilder the api and ApiVersioning works.
Has something changed on declaring ApiVersioning in 2.0 or is this a bug?

It looks like as if the IStartupFilter in the IServiceCollectionExtensions.cs does not register the required routePolicy service (IApiVersionRoutePolicy). In another project I had to manually register this policy due to a custom pipeline architecture. This solved the issue in that case. Right now I am facing the same issue as @jnUser, even manual registration does not apply the route policy.

Update: To workaround this issue I solved it as followed:

In the Configure(...) startup method resolve the versioning route policy manually
Manually add the route policy as new Mvc Route

The following two lines solve the routing issues till we get a fixed version:
            var routePolicy = app.ApplicationServices.GetService<IApiVersionRoutePolicy>();
            app.UseMvc(o => o.Routes.Add(routePolicy));

@jnUser and @jgoelten, did you happen to see/review the known ASP.NET Core routing limitations? I believe for you scenarios, that will get you what you need. A far more extreme solution would be to follow the direction that @jgoelten is suggesting. I provided a detailed explanation of how to setup things up yourself in #194, though I'm not sure you are exactly in the same scenario. That case was rather unique.
If you're not familiar with the background to this issue, there was a change in 1.1+ to fix a different issue that has resulted required configuration changes for some. In short, the ASP.NET Core infrastructure can make multiple controller action selection passes. This results in API versioning not being able to make a final decision during action selection. I've been in discussion with the ASP.NET team. For now, the solution is to inject a catch-all route that can make the final decision based on all collated candidate actions. In order for that to work, it must be the last router in the MVC part of the pipeline. I'm hoping we'll find some way to make a decision and short-circuit upfront as is the case with the vanilla action selector.

@jgoelten thanks for confirming your solution.
@jnUser did any of these suggestions work for you?

I ended up using parts of  your and @jgoelten solution and got it working. I think the solution @jgoelten  gave would have suffixed, but for some reason it did not work in testing, so I ended up mixing your solution in as well. It works now. Thanks.