Tooltip date can be inaccurate when app timezone context overridden

We might need to revert perf optimization in #1330
Seems to not update x values correctly in certain cases with shorter time ranges
EDIT: This seems to only be an issue when timezones are set explicitly locally (which isn’t currently enabled in our header anymore)

If we ever want to support a timezone customization dropdown in Perses app, we need to fix this and bring back changes from this old initial timezone implementation PR #825


Startup mechanism changed for GCC_ARM

Description
Startup mechanism changed for GCC_ARM as it is not suitable for  @DS-5

Currently, it looks like DS-5 is already copying the data into the RAM and there is no need to copy the data section again into the RAM. After this change, the code is going through to the main function and working fine.


Auto open solo folders

If there's a single visible folder (that doesn't represent a category or article) in a directory, Chime will automatically redirect inside of that folder. Includes a test.
Closes #299

Looks like #404 introduced some conflicts here.


feat: improve error handling with exceptions

This will be better for testing the program and report errors when something bad happens.

I'm using exit(1) instruction which makes everything really bad to test and keep track of issues.


Move Design Principles and FAQ to the official documentation

Current README.md is too long. this PR only adds some simple example/installation, and then move all to our official documentation.
I kept the links in README.md.

Codecov Report

Merging #944 into master will decrease coverage by 2.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
- Coverage   94.49%   92.02%   -2.48%
==========================================
  Files          34       34
  Lines        6434     6434
==========================================
- Hits         6080     5921     -159
- Misses        354      513     +159

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
24.54% <0%> (-72.73%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.04% <0%> (-7.32%)
:arrow_down:

databricks/conftest.py
91.48% <0%> (-6.39%)
:arrow_down:

databricks/koalas/frame.py
93.61% <0%> (-2.41%)
:arrow_down:

databricks/koalas/groupby.py
89.34% <0%> (-2.05%)
:arrow_down:

databricks/koalas/namespace.py
85.57% <0%> (-1.26%)
:arrow_down:

databricks/koalas/plot.py
93.33% <0%> (-0.96%)
:arrow_down:

databricks/koalas/utils.py
97.29% <0%> (-0.68%)
:arrow_down:

databricks/koalas/testing/utils.py
77.77% <0%> (-0.62%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a924df6...2ef64fd. Read the comment docs.

Let me merge this. I think we agreed upon this in general.


WIP: use go-containerregistry for promoting new images

This way we open up the path to promoting images without needing to tag them.
/hold
This should work in theory; let's see what the e2e test says...

Closing this in favor of #118 because the e2e test for that just passed.
/close


Is the deployment safe when all credentials are Public

In the npm run build stage Create react app builds all the files including the config.js which has all the credentials like the POOL_ID, client ID etc. We then deploy this to a S3 bucket which is publicly readable. So anyone can get access to these ID's. Is this safe? I am just used to heroku where heroku sets all the config keys and are not a part of the public code. Am I  missing something here? Sorry, I am new to AWS.

@SumayaG The ids are public but the credentials to access them are not. You should be fine as long as you are not exposing your IAM keys.


⚠ Samsung has degraded performance

In 5655c26, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2368 ms

Resolved: Samsung performance has improved in 0a11645.


Issue when compiling: minSdk version should not be declared in the android manifest

I got the error "Error:The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file."

When I moved my code to latest Android P the same issue was happened with me any idea what I can do to resolve this issue.

i change nougat version camera quality low and some error is coming one more image not saving.

The targetSdk version should not be declared in the android manifest file.
but there is no declaration of any sdk version in menifest

The action bar is not supported for this library

I got the error "Error:The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file."

Remove this tag   from AndroidManifest.xml and rebuild the project then resync with Gradle files (Find the Sync project with Gradle files option under file menu.

Is there a way to tell gradle to ignore this? I want to maintain these 2 fields in my AndroidManifest.xml

I got the error "Error:The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file."

Remove this tag uses-sdk android:targetSdkVersion="29" android:minSdkVersion="15" from AndroidManifest.xml and rebuild the project then resync with Gradle files (Find the Sync project with Gradle files option under file menu).

It works for me. I see that Gradle set the values. But these values are with the prefix default. What is a way to configure it properly?

The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.

this is literally all my code on the AndroidManifest.xml:

<application
    android:allowBackup="true"
    android:icon="@mipmap/ic_launcher"
    android:label="@string/app_name"
    android:roundIcon="@mipmap/ic_launcher_round"
    android:supportsRtl="true"
    android:theme="@style/AppTheme">
    <activity android:name=".MainActivity">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />

            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>
</application>

for what I see I don't have any minSdk so I don't get why am I getting the error... can someone help me? I'm trying to use the extendedCalendarView from here: https://github.com/tyczj/ExtendedCalendarView... don't know if this helps someone understanding why I got the issue...

@mayank199812  search for your AndroidManifest.xml file and look for a line same or similar to:
<uses-sdk android:minSdkVersion="17" android:targetSdkVersion="__APILEVEL__" />
Just delete that line and you will be good to go. My app is based on Nativescript and file location is:
C:\MyNativescriptApp\app\App_Resources\Android\src\main\AndroidManifest.xml
I hope this will help you and others. This wasn't a problem on Nativescript below 6 or android version <= 10


Open SSL Error

This gem doesn't require a SSL certificate does it? This error means nothing to me, and a Google search only suggested using a workaround certificate for a different looking issue (which I tried for kicks and giggles, then removed).
Error:
D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `connect': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (OpenSSL::SSL::SSLError)
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `block in connect'
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/timeout.rb:73:in `timeout'
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:923:in `connect'
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:863:in `do_start'
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:852:in `start'
        from D:/Program Files/Ruby22-x64/lib/ruby/2.2.0/net/http.rb:1375:in `request'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/httparty-0.13.7/lib/httparty/request.rb:117:in `perform'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/httparty-0.13.7/lib/httparty.rb:545:in `perform_request'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/httparty-0.13.7/lib/httparty.rb:492:in `post'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/httparty-0.13.7/lib/httparty.rb:587:in `post'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/linode-0.9.0/lib/linode.rb:96:in `post'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/linode-0.9.0/lib/linode.rb:81:in `send_request'
        from D:/Program Files/Ruby22-x64/lib/ruby/gems/2.2.0/gems/linode-0.9.0/lib/linode.rb:15:in `block (2 levels) in has_method'
        from linode.rb:6:in `<main>'

Code:
require 'rubygems'
require 'linode'

api_key = "My API Key that I am not gonna put in here"
l = Linode.new(:api_key => api_key)
puts l.test.echo(:foo => 'bar', :baz => 'xyzzy')

Windows 10, Ruby 2.2.3p173 (2015-08-18 revision 51636) [x64-mingw32], Gem 2.5.1, Linode 0.9.0

Linode disabled SSLv3 awhile ago.
Can you try changing: https://github.com/rick/linode/blob/master/lib/linode.rb#L96 to
HTTParty.post(api_url, :body => data, :ssl_version => :TLSv1).parsed_response

This feels ultimately like something wrong upstream or in the Windows configuration or behavior.

I replaced that line and received the same exact error including the line numbers.

Can you try simply opening this link in IE (yes, IE) and see what happens? If you get an SSL error, then your system is misconfigured. If you get {"ERRORARRAY":[{"ERRORCODE":4,"ERRORMESSAGE":"Authentication failed"}],"DATA":{},"ACTION":""}, then we have more to look into.

@SirCmpwn IE opens (in a text editor) or saves the JSON file. If I change my default program for JSON files to IE and then hit open, it tries to open it in the download manager.
Edge and Chrome both show the connection is encrypted and trusted.

Interesting. That makes me less sure that it's an issue with your system configuration. I don't think I'll be able to provide further assistance until I can get my hands on a Windows machine to reproduce with.

Getting the same on mac.
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http.rb:923:in `block in connect'
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/timeout.rb:74:in `timeout'
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http.rb:923:in `connect'
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http.rb:863:in `do_start'
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http.rb:852:in `start'
	from /Users/erik/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/net/http.rb:1375:in `request'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/httparty-0.13.5/lib/httparty/request.rb:101:in `perform'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/httparty-0.13.5/lib/httparty.rb:522:in `perform_request'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/httparty-0.13.5/lib/httparty.rb:476:in `post'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/httparty-0.13.5/lib/httparty.rb:564:in `post'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/linode-0.9.0/lib/linode.rb:96:in `post'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/linode-0.9.0/lib/linode.rb:81:in `send_request'
	from /Users/erik/.rvm/gems/ruby-2.2.1/gems/linode-0.9.0/lib/linode.rb:15:in `block (2 levels) in has_method'
	from bin/start-spark-cluster.rb:3:in `<main>'```

Just ran `gem install linode` today so it should be latest version.

Seems to be a common error with RVM installations. fix is client side and not an gem error

@danielhickman does @erike's fix work for you?

I don't have RVM. It seems it's not for Windows. Is RVM a requirement?

@danielhickman the linked stackoverflow thread has a lot of different instances of the same error. This was one I found for windows. Try following these steps: http://stackoverflow.com/a/35429863/224732

I tried that one before and a tried it again too.
The only ones that worked were:
Adding this to remove SSL (very bad idea)
require 'openssl'
OpenSSL::SSL::VERIFY_PEER = OpenSSL::SSL::VERIFY_NONE

Installing https://github.com/stevegraham/certified and adding (This method feels kinda hacky)
require 'certified'


Backport 2945 (Testnet4 support) to 0.32

This is an "initial cherry-pick and get it to pass cargo check" run.
Please let me know if you see anything weird I missed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

127 of 142 (89.44%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 83.207%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bitcoin/src/address/mod.rs
3
4
75.0%

bitcoin/src/consensus/params.rs
2
3
66.67%

bitcoin/src/blockdata/constants.rs
46
52
88.46%

bitcoin/src/network.rs
69
76
90.79%

Files with Coverage Reduction
New Missed Lines
%

bitcoin/src/blockdata/constants.rs
1
94.67%

Totals

Change from base Build<PHONE_NUMBER>4:
0.03%

Covered Lines:
18487

Relevant Lines:
22218

💛  - Coveralls

I havent't a clue either, but I would use this or the new bitcoin release to show testnet4 on fbbe.info

Is it working locally for you @junderw? CI on backports is currently borked (I have https://github.com/rust-bitcoin/rust-bitcoin/pull/3418 in progress but have been a bit lazy to date, I'll try get it done).
If its working locally you can poke @apoelstra and he may queue it up on his local CI for you. His CI setup takes precedence over GitHub's.
Really cool to see other folk doing backport work, appreciate it.

Is it working locally for you @junderw?

cargo test works for my locally installed toolchain on my OS (Linux x86_64)
Is there a command I can run that will check everything?

If its working locally you can poke @apoelstra and he may queue it up on his local CI for you. His CI setup takes precedence over GitHub's.

To clarify -- for backports this is true where we know Github is messed up. But going forward we're (almost) at a point where Github won't break anymore, and then neither will take precedence. Both should always pass.
I'll review this and ack conditioned on my local setup passing.
@junderw sadly no, there is no command that will test everything. Our Github CI checks are in the rust-bitcoin-maintainer-tools repo and it doesn't have a nice self-contained "test this whole repo" command (though it'd be cool if it did). Meanwhile my local setup is extremely compute-intensive and also partially tied to my local system (mainly because of the custom bitcoin nodes it spins up for jsonrpc testing, though I should really pull those into the local ci repo..).

I have fixed the issues raised. cargo check and cargo test both passed (with tons of warnings).

Could you rebase again? I think after #3382 CI should pass.

Sorry for the delay. I was on a business trip and wasn't able to check Github for 2 days.

Ok, not quite, but this gets us much closer. There are some new "unused code" lints that we could clear out, and ofc the WASM thing which has broken CI even on master.


chore: Update from _rust/main template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 45.436%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
219

Relevant Lines:
482

💛  - Coveralls


can not run in macOS 12.5.1

os: macOS 12.5.1
About This Hack 0.5.0 Beta
can not run as following

and  General Tab of Security & Privacy no show "Open Anyway"

If I do sudo spctl --master-disable, the same issue happens again

@michelle0812 this is because I am broke and don't have money to pay $99/year to sign the app. For some users, this will appear. To fix the issue, open your terminal and type xattr -cr /Applications/About\ This\ Hack.app

Please let me know if that resolves the issue

The same issue in my hackintosh

@michelle0812 in your Finder, go to About This Hack -> Show Contents -> Contents/MacOS and drag the executable there into the terminal.

@michelle0812 hold on, when I download 0.5.0 I'm getting this too. Try downloading 0.4.0 and then updating when it prompts you too. See if that works.

@michelle0812 if you haven't done the previous step yet, there shouldn't be a need. Try downloading the ZIP file from 0.5.0 again. I put in a new binary that should work.

Yes!!
Thank you.
New 0.5.0 OK..
I also tried 0.4.0 10mins ago but no ok.
Thank you Anyway.

@michelle0812 this is because I don't have the paid developer license. It seems that since my app got a ton of downloads without getting signed by a paid account, apple decided to quarantine it :( . It's never fun to be broke

got it!
Thank you for your hard work

No problem. Closing as completed

Weird it can not run again in different hackintoshes which run macOS 12.5.1.
I tried  with 0.5.0 and 0.4.0 but no works.

@0xCUB3 I use yesterday's hackintosh and can't run 0.5.0 today.

@michelle0812 like I said before, Apple is being mean to me because my app has a lot of downloads and I am not paying for the developer license. I contacted them about this and they said that the only way to resolve this issue is to pay them the $99/year and have the app properly signed. At this point, there is nothing that I can do to fix the issue. As a teenager, I have no way of paying the money, but since the app surpassed 1000 installations, Apple is being more and more restrictive.

@michelle0812 update: this release should fix everything. Let me know if it still doesn't work. Download it from here:
https://github.com/0xCUB3/About-This-Hack/releases/tag/0.6.0


Quirky focus

Description:
The widget takes input the right way, but shows (and keeps showing) focus the wrong way if you focused the wrong box manually.
To reproduce:
Click for example the 3rd box to start typing. The 3rd box will be focused (this should be the 1st). Your input will go to the 1st box, which is ok, but focus will now shift to the 4th box, and so on until the last box stays focused while you finish your input.
The same if you click a random box and use backspace to correct things. This should start at the end.
Expected:
If you click the input boxes, it should take the boxes as one input field and focus either the first box if the input is still empty or the last filled in box.
Maybe it would also help to (optionally) steal focus right away so the user can start typing without first clicking the input.

Quirky focus issue has been fixed from v1.0.2.
User can enter text from any input boxes and it will focus to the last filled area after the key is released. Like the below. Tryout the updated widget here
https://github.com/user-attachments/assets/b70ae552-db2d-47c2-81bf-da5a53011b9a
Focus stealing at the initial load of the page is somehow not working in Mendix page. The reason for it is yet to be found.
Closing this issue as it is resolved. Feel free to re-open if it is not working.


feature/workflow_dispatch to test contributors code

This all allow us to test contributors code changes without exposing or uploading to our services.
https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow

@coderabbitai review


Add Contact in F&F

1.It should be disabled until user selects a contact
2.Currently its enabled and user clicks nothing action happens

Completed


Mermaid Subgraphs are very slow

Environment

Elixir & Erlang/OTP versions (elixir --version): Erlang/OTP 25 [erts-13.0] [source] [64-bit] [smp:24:24] [ds:24:24:10] [async-threads:1] [jit:ns] [x86_64-pc-linux-gnu]
Operating system: Ubuntu 20.04 in WSL2
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): livebook server
Livebook version (use git rev-parse HEAD if running with mix): ?
Browsers that reproduce this bug (the more the merrier): edge/chromium
Include what is logged in the browser console: hx-FvZ4-0QmrUg7IgeB update:  -  {3: {…}}
Include what is logged to the server console: -
(I hope the info above is sufficient, I'm a livebook & elixir beginner so not too sure what some of these are asking)

Note that earlier in the same session I got several errors like this: Multiple IDs detected: flowchart-pointStart. Ensure unique element ids.
I believe this is due some unrelated issue that appeared while updating partial mermaid syntax.
Current behavior
When using a mermaid block in markdown, that includes subgraphs such as this sample from the mermaid website
flowchart TB
    c1-->a2
    subgraph one
    a1-->a2
    end
    subgraph two
    b1-->b2
    end
    subgraph three
    c1-->c2a
    end

flowchart TB
    c1-->a2
    subgraph one
    a1-->a2
    end
    subgraph two
    b1-->b2
    end
    subgraph three
    c1-->c2a
    end

live-editing (typing inside the block) slows down the browser. This is noticeable as the input handling appears to pause after every keystroke.
Expected behavior
The input field stays responsive while re-rendering the output. Even more preferable would of course be faster rendering times, but overall it seems most important that even for complex graphs that will be slow no matter the optimization the input itself stays responsive.

Hey @HurricanKai! When modifying graph definition most time is spent generating the graph SVG, and even though it happens asynchronously, it runs in the same thread as everything else. Consequently, when typing quickly, the browser is busy generating the graph and the UI is a bit jumpy. That's how it looks for me:
https://user-images.githubusercontent.com/17034772/173365299-80bc1212-ed89-477d-8bc1-b55b081530b4.mp4
I get a similar behaviour in https://mermaid.live and it only processes the graph, so I don't think there's much we can do.
For this particular example I'd say it works acceptably for me. If you have a more complex example that causes a larger delay, please verify the performance in https://mermaid.live.

I've retested in a fresh notebook and I think the performance drop was unrelated (possibly something about equally named graphs, not sure), my apologies. I'll raise a different issue if ai can reproduce that.

Sure, no worries :)


[5.7] Added and implemented Arr::deepMerge()

Up until now it was impossible to merge configs which had multi-dimensional arrays in them, at least not to the extent that the "new" keys would be merged too.
This PR aims to fix this so that an application won't crash when a package updates their config and the user doesn't republish their config. (like in: #16991, #21541)
And in the meantime adds an Arr helper to merge multi-dimensional arrays.
$config1 = ['jobs' => ['first'  => 'Programmer']];
$config2 = ['jobs' => ['second' => 'Teacher']];

Before PR:
// Expected result:
$config =  ['jobs' => ['first'  => 'Programmer', 'second' => 'Teacher']];

// Actual result:
$config =  ['jobs' => ['second' => 'Teacher']];

After PR:
// Expected result:
$config =  ['jobs' => ['first'  => 'Programmer', 'second' => 'Teacher']];

// Actual result:
$config =  ['jobs' => ['first'  => 'Programmer', 'second' => 'Teacher']];

No plans on adding to core.

As in, don't want the Arr method (which i can get behind), or as in don't want to make the ServiceProvider merge the config in multi-dimensional arrays?

I would find this very useful! Please consider adding such functionality or merging this pull request.
@taylorotwell Could you elaborate a bit more, why there are no plans to add (this?) to core?


Does not handle comments (No biggie but stumbled upon this)

<EMAIL_ADDRESS>or
<EMAIL_ADDRESS>Both are same as<EMAIL_ADDRESS>Source : https://en.wikipedia.org/wiki/Email_address

thanks for your observations.
will review it when I have some time.
Regards.

@mWaltari,  SMTP doesn't handle comments either in the MAIL FROM or RCPT TO commands.
There are 2 different email address specifications: SMTP and Internet Message Format.
Most people (including wikipedia) confuse the two and think they are the same, but they are not.
Comments may only appear in the From/To/Cc/etc headers of an Internet Message, but may not appear in the addresses used with SMTP.
Email Address Validation is for what? It's not for parsing emails used in a raw Internet Message document. They are for validating user-input in a text field because they will be used with SMTP.
Correct?
Then it stands to reason that an EmailValidator needs to conform to the SMTP specification and not the Internet Message Format specification.
So there's no need to handle comments (because, let's be honest, what user is going to write comments in their email address on a web form? or anywhere else for that matter?)

Maybe there could be preprocessor method to clean all this. And spit out usable address. Justa thought. As said not a big deal. To me.
Also that method could make trivial fixes. Like trim white spaces.
Oh, also would be nice to have error code, so could give some hint to user what is wrong in the address. (And position of error if possible)
But anyways validator is very good as is...

The preprocessor part sounds cool but I don't think it will fit in the original purpose of the library,  validating email addresses as it is without modifying it.
Regarding the specific error message request, that will require a lot of change to the current way the api is structured.
How do we pass the error message from the validate method to the user?
An exception?
That would add an implicit try except block and overhead to the generated code without any crucial benefit.
An out or var parameter to the validate method?
That would require changing the way an already existing api is used which is not always a good thing for backwards compatibility.

Simple CleanEmailAddress function would do.

Return error code (optionally), and then method to convert it to string. If needed. Anyone would need to localize anyways. So some English reference function would do just fine.


melpa-packages: 2019-10-25

The previous update included several errors which broke packages. This
one re-fetched and fixed them.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @adisbladis

Thanks!
Btw, would you mind pinging me on IRC when you have time?

The hashes might have changed again: https://github.com/NixOS/nixpkgs/issues/71948#issuecomment-569382093


Ci integration

:v:

Hi @GabLeRoux this is fantastic work! Thank you for taking the time. I've updated many of these suggestions in recent commits.


Select countries by increasing / decreasing values

Users are presumably interested in seeing which regions are currently 'winning' or 'losing' with respect to covid.
I have, therefore, added buttons and methods which will select all of the regions which are going up or down (with respect to the selectedData).
This is done by checking whether the sum of the slope over that last 4 days is more or less than the sum of the slope in the previous 4 days (where the 4 days is stored in the 'daysOfIncrease' variable).
If you adopt this change, it may be desirable to allow users to change the daysOfIncrease variable (as can currently done with doublingTime). I'm happy to make this change (or others) as might be useful.
Thanks for covidtrends - I appreciate it.

hmmmm a few thoughts about your pull request. At first by selecting the decreasing and increasing countries on a country level you get a not really readable and comprehensive overcrowded graph:

"comparisons" might be difficult in-between countries that way ( you would have to manually deselect x number of countries to narrow down the selection of particular increasing or decreasing countries - which implies maaaanyclicks) and you also have no real visual as well as readable feedback what you have actually selected and seeing right now (was it increasing or decreasing i had selected).

on a regional level it is a little bit more accessible due to the lower number of regions per available country. but it is still a visual overload and in case of zero cases (decreasing) e.g. for china the curves are missing many of the labels cause of the zero cases issue with covidtrends:

and about the decision if a country has increasing or decreasing numbers based on the last 4 days... isnt that interval too short and might give false impressions in each of the direction it might be read? would it be more reasonable to choose at least the 7 days we have for the running average for new confirmed cases on the y axis for normalization? but for the determination of the general trend i would suggest an even higher value? 14 days or even 28 days? so you are able to see that there is a significant overall trend. an example, in case of germany we had a decreasing growth overhere ...

then they started to open up the country step wise which lead to small spikes up for a few days but the general trend was still falling/decreasing.

a few weeks ago superspreader events started at slaughterhouses which lead to a more consistent uprising exponential trend alongside more and more people acting like the pandemic with no social distancing and so forth ( they did that during the time of the small spike as well already):

so a too short interval for the decision if a curve is increasing or decreasing might support and nourish that behavior even more. meaning people take a look at a curve and see hey my country is doing fine according to covidtrends and things are decreasing so i can out and "party"  and the other way around the curve is increasing i better barricade myself at home ;) exaggerated but especially the former could be the way the feature could be read and used in arguments.  ;)
and if the feature is merged i would definitely document in the documentation as well as the website copy on what basis the decreasing/increasing is calculated and the line is drawn in between the two groups. and why only use the two? an idea might be the following, @aatishb once linked an article where they used 4 categories to explain a curve based on covidtrends: exponential growth(steadily rising curve), linear growth ( more or less horizontal curve) , decreasing growth ( decreasing curve) and contained (more or less vertical curve - china is a good example).

Thanks @rpkoller for your feedback. I'm very much open to an alternate or more comprehensive approach to determining whether curves are going up or down. Given the number of people using this site it probably needs a more methodical approach than the one I have suggested. FWIW I chose 4 days because longer time frames (especially out at 7 days) gave false positives / negatives.
I do, however, believe that users would benefit from tools which allow them to quickly see which regions are doing well and which are doing poorly, particularly with each state of the USA, because this does inform policy and behaviour.


Isar Error: Could not initialize IsarCore library

When I run Flutter app on Android 5 emulator, below error is occurred.

Emulator's image is for x86_64, so I think this is running under 64 bit.

Here is dependency definitions and flutter doctor -v.
dependencies:
  isar: 2.2.1
  isar_flutter_libs: 2.2.1

dev_dependencies:
  isar_generator: 2.2.1

[√] Flutter (Channel stable, 2.10.2, on Microsoft Windows [Version 10.0.22000.493], locale ja-JP)
• Flutter version 2.10.2 at D:\Flutter\SDK
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 097d3313d8 (2 weeks ago), 2022-02-18 19:33:08 -0600
• Engine revision a83ed0e5e3
• Dart version 2.16.1
• DevTools version 2.9.2
[√] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at C:\AndroidSDK
• Platform android-31, build-tools 32.1.0-rc1
• ANDROID_HOME = C:\AndroidSDK
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
• All Android licenses accepted.
[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.1.0)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.1.32210.238
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
[√] VS Code (version 1.65.0)
• VS Code at C:\Users\\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.36.0
[√] Connected device (3 available)
• Android SDK built for x86 64 (mobile) • emulator-5554 • android-x64    • Android 5.0.2 (API 21) (emulator)
• Windows (desktop)                     • windows       • windows-x64    • Microsoft Windows [Version 10.0.22000.493]
• Edge (web)                            • edge          • web-javascript • Microsoft Edge 99.0.1150.30
[√] HTTP Host Availability
• All required HTTP hosts are available
I think Isar can run on 64 bit devices, or is there another limitation ?

Here I had the same problem

I believe this is related to https://github.com/isar/isar/issues/187 which is not fixed yet.

Already fixed


RFC: (@urql/exchange-graphcache) Allow using .graphql files for schema awareness

Summary
Currently you have to use a .json file for schema awareness. The schema option should also accept .graphql files. For example, the TypeGraphQL framework can output a schema.graphql file. The JSON requirement for schema awareness requires me to add another step to my code, that could be avoided if .graphql files are accepted.
Proposed Solution
The schema option should accept a JSON object, an imported .graphql file, or a path to a .graphql file.

This is explicitly not supported because it'd mean we'd have to parse the schema (a path / direct import isn't possible since we're dealing with client-side code as well here) and then create a non-executable schema and introspect it.
To be fair, you can already do this and a utility for this exists in @urql/introspection: https://github.com/FormidableLabs/urql/blob/main/packages/introspection/src/getIntrospectedSchema.ts
But since you'd be pulling in more utilities and more from graphql you'd greatly increase your bundle size and add processing time to your app's startup for data that can be computed at compile time.
That being said, Graphcache obviously doesn't care about how the JSON data is derived, which is why for instance it can be generated using GraphQL Code Generator, which we'd assume is a common tool in a frontend app that is typed and which we'll recommend as part of our framework-efforts in the future

I see, thanks for the insight!


Fix 3x +m data commands

Description:
3 of the +m data commands are broken because of a Prisma bug. I have got to the bottom of it, and there's nothing we can do on our end except to rewrite our calls using $queryRawUnsafe()
Changes:
Fixes the follow +m data commands:

Personal Monster KC
Personal Inferno Death Times
Personal Farmed Crops

Other checks:

[x] I have tested all my changes thoroughly.

We could just do user_id::text? But yea not troubled with the unsafe here.

yes that should work, too hehe. I really tried to see if there was a way prisma would work properly, maybe i'll submit a PR over there


Add cupy.positive in API Reference

Fixes #6017 by updating the docs as discussed in the "issue conversations"

Thanks, could you move it to the same position as the NumPy's documentation (linked at the top of each RST file)?

I'm sorry could you elaborate more.

Please check the NumPy links at the top of each files:

NumPy API Reference: Mathematical functions
NumPy API Reference: Universal functions (numpy.ufunc)

.. Hint:: `NumPy API Reference: Mathematical functions <https://numpy.org/doc/stable/reference/routines.math.html>`_
.. Hint:: `NumPy API Reference: Universal functions (numpy.ufunc) <https://numpy.org/doc/stable/reference/ufuncs.html>`_

Thanks for the clarity 👍. Corrected in 01c1ef8 and d450d9a

Thanks, LGTM!


fix cPickle.dump bug

The function cPickle.dump returns None, which incorrectly resets self.parameters to None.

You are right. Thank you!


Support keyboard navigation

Fixes https://github.com/pixie-io/docs.px.dev/issues/186.
Signed-off-by: Cristian Postescu<EMAIL_ADDRESS>

@postescu - could you apply this to our 4 other repos?


Update manifests/t/Tencent/TencentVideo/11.40.3073.0/Tencent.TencentVideo.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels


react/no-multi-comp false positives when declare class property memo keyword

The eslint-plugin-react version I use is 7.12.4

Does this only happen if the function is named memo?

@ljharb with the import name, too.
Actually I was used memo to name memorize-one package. I thought it might be because of the memorize-one so I created that memo function (as above) to test if it really because of the memorize-one

Right, but I mean if you name it something that's not "memo" - because React.memo is a special thing - does the lint rule still warn>?

Ah, if I use other name the warning will gone.

Thanks, in that case the issue is that the code checking for React.memo needs to also ensure memo comes from React.


[RFE] OwnedPodsSection cannot get pods if user only have namespace access

Current situation
Users cannot get filtered pods from a cluster in OwnedPodsSection section. If users only have namespace level access, they cannot get pods in a cluster.
Ideal future situation
Add label and field selectors in each request in apiProxy. The cost is each filter will launch a request. But the benefit is that people with only namespace level access can get pod.

Any news on that? This is stopping many people from using Headlamp. People often only have namespace level access.


False Positive on activemq-broker-5.16.2.jar

False positive on library activemq-broker-5.16.2.jar - reported as cpe:2.3:a:apache:activemq:5.16.2:*:*:*:*:*:*:*
<dependency>
    <groupId>org.apache.activemq</groupId>
    <artifactId>activemq-broker</artifactId>
    <version>5.16.2</version>
</dependency>

https://nvd.nist.gov/vuln/search/results?form_type=Advanced&results_type=overview&search_type=all&cpe_vendor=cpe%3A%2F%3Aapache&cpe_product=cpe%3A%2F%3Aapache%3Aactivemq&cpe_version=cpe%3A%2F%3Aapache%3Aactivemq%3A5.16.2
https://ossindex.sonatype.org/component/pkg:maven/org.apache.activemq/activemq-broker@5.16.2?utm_source=dependency-check&utm_medium=integration&utm_content=6.2.2

Caused by an invalid CPE link at NIST
https://nvd.nist.gov/vuln/detail/CVE-2015-5182#VulnChangeHistorySection
As per the added reference it clearly affects the Redhat A-MQ product that is based on activemq, but the only linked CPE is that of apache activemq in any version: cpe:2.3:a:apache:activemq::::::::
For unknown reasons activemq 5.16.2 is not (yet) present in the CPE list of known versions of activemq:
https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Aapache%3Aactivemq%3A5.16.*
I'll report both the missing activemq version and the incorrect CPE linked to CVE-2015-8152 to the maintainers of the NVD. The FP should be resolved soon after NIST has corrected the NVD to link the correct CPE.
Thanks for reporting this.

The NVD has an updated analysis for CVE-2015-5182
False positive should disappear when your local vulnerability database gets updated from current NIST NVD datafeeeds.

Thank you @aikebah! The issue is gone.


[Bug] export partition not work when DISTRIBUTED BY RANDOM BUCKETS AUTO

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.2
What's Wrong?
when create table by BUCKETS AUTO, An export with partitions exports all of the table's data
What You Expected?
An export with partitions exports only the data in the specified partition
How to Reproduce?
CREATE TABLE kec(timestamp datetime NULL COMMENT "时间" ) ENGINE=OLAP DUPLICATE KEY(timestamp) COMMENT "" PARTITION BY RANGE(timestamp)() DISTRIBUTED BY RANDOM BUCKETS AUTO PROPERTIES   (   "dynamic_partition.enable" = "true",   "dynamic_partition.time_unit" = "HOUR",   "dynamic_partition.end" = "24",   "dynamic_partition.prefix" = "p",   "replication_num" = "2" )
You need to change the time and partition key：
insert into kec values("2023-11-17 16:01:01");  insert into kec values("2023-11-17 17:01:01");
EXPORT TABLE kec PARTITION(p2023111717)  TO "file:///tmp/" PROPERTIES ( "label" = "kec_p2023111717" );
SHOW EXPORT  WHERE LABEL = "kec_p2023111717" ORDER BY StartTime DESC;
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cannot reproduce in lastest 2.0 and master


jit: support global get and set instructions

part of #65

@codefromthecrypt thanks for the detailed reviews! Improved a lot :D


fix: drag and drop functionality

Drop zone need to have both ondragover and ondrop event handler HTML Drag and Drop API.

Thank you for the fix! PR looks good :rocket:.


placeholder color, font-size in  on Firefox , line wrap in

Bug reports:
Full picture

Content
Real - Firefox
H2C - Firefox
H2C - Chrome

Placeholder

String

Decomposing pictures

Content
Real - Firefox
H2C - Firefox
H2C - Chrome

border-style: dashed;

Same with Firefox

Placeholder <Input>

Placeholder <textarea>

Blank
Blank

String <Input>

String <textarea>

Detailed explanation

border-style: dashed; drawing error.

Real - Firefox
H2C - Firefox
H2C - Chrome

Same with Firefox

font-size with <input> drawing error in Firefox.

Real - Firefox
H2C - Firefox

color with <input>::placeholder drawing error.

Real - Firefox
H2C - Firefox
H2C - Chrome

H2C uses string color, not placeholder color. If I modify the text color to red, the placeholder drawn by H2C  is also red.

▼

Placeholder in <textarea> is not draw.

Real - Firefox
H2C - Firefox
H2C - Chrome

Blank
Blank

Line wrap in <textarea> is not drawn.

Real - Firefox
H2C - Firefox
H2C - Chrome

Related pages
https://mapaler.github.io/PADDashFormation/
Specifications:

html2canvas version tested with: v1.0.0-rc.3
Browser & version: Firefox Developer Edition 68.0b10 (64 bit) | Chrome 75.0.3770.90
Operating system: Microsoft Windows 10 1809 [Ver 10.0.17763.557]

Line wrap in textarea is a duplicate of #2008 ?

Yes.
In order to solve this problem, I have now converted  content into  in my program, so I can solve it.
Thank you for your work.
Only the dotted line border I don't know how to do yet.

How can u solve the problem of dotted line border at last?

Dotted borders are now supported https://html2canvas.hertzen.com/results/border-dotted!Chrome_Stable-Chrome-92.0.4515.131.png

hello, I thought of a greate solution just now, you can use the div tag to draw a dashed or dotted line
.dashed {
width: 100%;
overflow: hidden;
margin-top: 10px;
white-space: nowrap;
line-height: 1px;
height: 1px;
font-size: 0;
letter-spacing: 4px;
.line {
display: inline-block;
width: 4px;
height: 1px;
background-color: #999999;
}
}


WebSocket.prototype.addEventListener is not a function in latest Chrome

An error is thrown at line 50 in stream.js.
> WebSocket.prototype.addEventListener
undefined

Chrome version: 50.0.2661.94
According to MDN addEventListener is not a function on WebSocket, although it still works in Chrome Canary, Mozilla and Safari.

Would you like to send a PR to address this?

Will do.

@tothandras thanks!!

Should it use addEventListener by default, or just replace those lines altogether?

We need a solution that works across browsers and in node as well. Once this is achieved, I'm fine.

I've done nothing, but it's there again:
> WebSocket.prototype.addEventListener
function addEventListener() { [native code] }

Same Chrome version...

Weird, can we close then?

I am not sure, the addEventListener  is not part of the WebSocket standard, so it can disappear anytime.

I think you should bring this discussion to the ws module, and we'll follow
what they suggest.
I am against on having feature detection here (unless we have no
alternative).
Il giorno mar 3 mag 2016 alle 13:15 András Tóth<EMAIL_ADDRESS>ha scritto:

I am not sure, the addEventListener is not part of the WebSocket
standard, so it can disappear anytime.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/maxogden/websocket-stream/issues/87#issuecomment-216498559

I agree. Will you contact them?
(Fun fact: one of my coworker still doesn't have WebSocket.prototype.addEventListener.)

Oh, I just reread your message, I will bring it up then. :)

It's there, but I haven't noticed: https://github.com/websockets/ws/blob/master/lib/WebSocket.js#L402-L484. I've updated the PR.


Update license field following SPDX 2.1 license expression standard

The new recommendation is to follow the SPDX 2.1 standard. This allows automatic license verification software to work properly. Reference: https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields

@frisoft If you could rebase this stop current main, that would be great and would fix the failing CI check.

Sure. I'll revise it

@waywardmonkeys, I merged your main into mine. This should be enough to fix the PR.


odo list namespace

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This PR adds odo list namespaces command
Which issue(s) this PR fixes:

Fixes part of #5525
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:

odo list namespace
odo list project
Try the above commands on both OC and K8s cluster.

It seems odo list is now broken

Yup, I'm working on fixing this. Let me know if you can remember a fix for it.

It seems odo list is now broken

Yup, I'm working on fixing this. Let me know if you can remember a fix for it.

I cannot find how to have an optional subcommand.
We could consider namespace as an argument here, not as a subcommand

It seems odo list is now broken

Yup, I'm working on fixing this. Let me know if you can remember a fix for it.

I cannot find how to have an optional subcommand.
We could consider namespace as an argument here, not as a subcommand

I found a solution. We have to modify the listCmd.Run. I'll push it in a minute.

/lgtm

For the documentation part, we are trying to switch to unified format for the command reference, can you separate the doc to a "Description" and a "Running the Command" headlines? Similar to: https://odo.dev/docs/3.0.0/command-reference/dev


added missing req chromadb tiktoken

<!-- Thank you for contributing to LangChain!

Replace this comment with:
added missing req chromadb tiktoken

@baskaryan

why are these required? cc @baskaryan

docs/requirements.txt is only for api reference, don't think we need chroma or tiktoken for that?

I was only able to run the examples in https://python.langchain.com/docs/get_started/quickstart once I installed these two.

I was only able to run the examples in https://python.langchain.com/docs/get_started/quickstart once I installed these two.

ooh interesting, could your provide the code + errors where it failed?


[experiment, maybe fail]  read searchTerm in narrow-editor

as like narrow:scan
TODO

[x] Throttling before start search( maybe this should be separate PR )

Cancelling on-going refresh, search execution.

[x] regex button on control-bar and shortcut
[ ] decide how to make user escape white-spaces

Explicit confirmation set boundary between searchTerm and query( no escape require )
Or Use \  to escape search space included searchTerm, but need \\ to search \ itself.

[x] Make UI natively support useFirstQueryAsSearchTerm, to make scan, search provider code simple.
[ ] searchTerm history support( when it's saved, what the keymap to recall history? ). ctrl-p, ctrl-n conflicts with move-up, move-down commands in non vim-mode-plus user.

Was super hard, I almost given up once, but now started to work.

Canceling is most difficult and mind winding part.
I tried by my own promise cancellation by wrapping promise to convert to cancelablePromise
Also tried bluebirds promise.cancel
Both are fix some issue, but NOT enough
When user search single char like a, it generate lots of items.

In this case, waiting with Promise.all for search promise for multiple-project is too long to wait.
And concatenating, rendering in bluk require huge amount of memory which cause huge GC which locks UI completely.

To reduce memory consumption on huge items, and avoid GC, what I did is to generate/render items multiple times with small-chunk

The unit is when external bufferedProcess's on data event.

So I quit using promise.then chain for more explicit, granular control for timing of getItem/renderItem.

Old: refresh().then  getItem().then renderItem.then preview
New: refresh() getItem fire onDidUpdateItems event(multiple-time) and Ui render items(multiple-time). - Old code base was very simple and easy to handle. But I won't back.

It works flawlessly. Thanks for your work!


Implement support for syncing all settings

Please implement a way to sync settings (Theme, Keyboard bindings, installed extensions etc.) across multiple computers without having to use 3rd party extensions or hacks.

That's an interesting request. I personally have all my settings saved as a couple of Gists in my Github account.
I might be wrong but if Code had to handle this by itself it'd mean that it should be able to handle some kind of authentication system to sync settings. So for instance you'd be able to directly connect your Github account and have settings saved as Gist, or Google Drive / OneDrive. It seems very heavy for just syncing a couple json files.
Another way could be to be able to point Code to an external settings file, saved on your sync method of choice.

@amithegde There is an extension in the market place to sync settings across multiple computers. Have you tried this?

I have tried extensions and gists and dropbox and the like. However, these alternatives won't be considered as the the best way in an office setup where things are closely monitored. If it is provided out of the box, there is nothing better than that!
Alternatively, a way to export all the settings as a json file or something similar would be great too so that it can be checked-in to the repository and whole team can share it; we will be able to define bunch of settings and extensions based on the repo we are working on.

Following are already available in a json format and can be shareable

Settings (include Themes)
Keybindings

Extensions are not yet. Will think about it
Thanks

This is https://github.com/Microsoft/vscode/issues/2743

Would be nice to use MS Account to sync settings (same as other Win 10 settings).

Duplicates #2743


[No QA] Follow-up: Disable default id eslint rule for the large files

Explanation of Change

Follow up for https://github.com/Expensify/App/pull/54117.
Disable default id lint rule for the large files, to then process these files in the dedicated tasks.
src/libs/ReportUtils.ts
src/libs/actions/IOU.ts
src/libs/actions/Report.ts
src/libs/actions/Task.ts

Fixed Issues

$ https://github.com/Expensify/App/issues/50360
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Checkout this branch
Make any change in a file from the list above that has plenty of examples e.g. src/libs/ReportUtils.ts, and commit that file.
Run npm run lint-changed, see that no error were reported.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Performance Optimisation : Investigate replacing CompletableFuture with a custom, optimised Future implementation

Currently simple-react is built on top of a JDK 8 Stream of CompletableFutures. This involves the Stream creating or managing a CompletableFuture for each element in the Stream. On top of this the Stream passes the execution pipeline to each element (via the CompletableFuture interface and methods such as thenApply or thenApplyAsync). CompletableFuture is an immutable functional class, and returns a new instance each time, so we create an additional set of Objects proportional to the number of operations to be applied per element in the Stream. This is ripe for optimisation.
A simple benchmark test shows that throughput measuring the repeated application of the identity function, on a Mac Book Pro, more than halves from 330 million applications per second  to less than half that (137 million application per second) when the process is allowed to run long enough to cause the garbage collector to kick in. A large portion of the Objects that build up in memory are CompletableFuture instances.
The execution pipeline is (logically) shared, it need only be defined once. This change alone could reduce the number of new Objects to 1 per element.
There are a finite number of Future tasks active per Stream at any given point, recycling Future instances via Object pooling would also significantly reduce the number Objects created. For a large Stream of data the number of Objects in total (Futures + elements) would trend towards the number of elements alone (as the number of elements dwarfs the number of reused Future objects).

Implemented on branch see : https://github.com/aol/simple-react/pull/54


Fix bug in xcode task when project argument is specified and workspac…

…e is not used

Looks good to me.


Added Monitoring Studio X as a third-party software exposing Promethe…

@RichiH
Added Monitoring Studio X as a third-party software exposing Prometheus metrics

Thanks @iguitton !
Taking a quick glance, skm_volume_readrate_bytes_per_second is an anti-pattern; is there any chance to expose the raw values like skm_volume_read_bytes_total so users can use rate() and such in PromQL?

@RichiH: Unfortunately, the PATROL Agent does not expose the underlying raw values of its metrics. We tried to reconstruct the raw values from the rates, but it's a resource-intensive task for the agent when there are thousands of metrics to convert.
We're still doing a lot of automatic units conversions (e.g. the FreeSpace metric is originally expressed in MB, and we convert it to bytes, etc.) but this version of the exporter doesn't reconstruct the raw values from the rate metrics. It's still under consideration for a new version, but it will truly depend on the overall performance of the operation.

@RichiH any update?

@bertysentry Rebuilding counters from rates is error-prone. If your upstream were to consider exposing raw values, that would be best.
@iguitton thanks for the poke & PR, merging.


Apc

Travis config change

Coverage decreased (-0.1%) to 88.925% when pulling 9e9760aec0abe2f20279e8fcfd86a18941106e8a on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-0.1%) to 88.925% when pulling 9e9760aec0abe2f20279e8fcfd86a18941106e8a on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-0.1%) to 88.925% when pulling 9e9760aec0abe2f20279e8fcfd86a18941106e8a on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-0.1%) to 88.925% when pulling cf70889415805cc2baa70bd78aa5dfed8fbb56a8 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-2.8%) to 86.23% when pulling 3ec0a6689d1c9f9b8e4fa9a49598b2746aa9fbc6 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-2.8%) to 86.23% when pulling 069ad4d3b584eba3797c81127dda5911df070198 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-4.1%) to 84.918% when pulling dda5c7b46f6fb2312908dc287b068d4ed298d222 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.

Coverage decreased (-3.8%) to 85.246% when pulling 294683bc38bec350ea725a039899e5d255b29447 on sonixlun:apc into 8e660c770428273635a7831fa22fe5f5c61fc22e on eMAGTechLabs:master.


Remove unnecessary branch retrieval loop

The Gitea bug https://github.com/go-gitea/gitea/issues/2088 that was mentioned in the code was fixed years ago. I built the plugin and tested it. It worked but I am not 100% sure in which exact situation this code block was executed.

You should open this PR to upstream. This is only a mirror with some fixes missing upstream. 🤗

Thanks for your reply. I know this is just a fork and of course I will create a PR for this in upstream. But I am afraid it won't be taken care of soon (regarding the past few months).
Right now I use the releases of this fork as Jenkins Plugin since it handles lookup for all branches/tags and thought I could contribute to something I use on a daily basis. 😉

Yep, it does.
I had a closer look at where this is actually been called. Turns out, it's called during a build as one of the first actions to retrieve the actual revision. In my repositories I always use branch patterns like <bug|feature|task>/<summarized-content>. This is exactly the mentioned case in which all branches are fetched to get the only one that is needed.
In my environment this took about 20 seconds, speaking of repositories with more than 400 branches. In Gitea web logs I see that all those branches are retrieved page per page.
With this fix, this part of the build takes only 200ms. 🤗

Should be included in next release.

Thanks. I'll create a PR for the upstream as well. 😃


Remove pointers in two of the optimizers

Minor edit for consistency. The use of a pointer to ptrace.Span and pmetric.Metric raises flags about how these optimizers work, and it appears to be unnecessary. Note that these types are pointers under-the-hood anyway, and the optimizer was not using these as reference types.
Also note: the logs optimizer appears to work differently (slightly), so no change there. (Tangent: why does the logs optimizer use a *ResScope where the two others in-line the flattened thing?)

Minor edit for consistency. The use of a pointer to ptrace.Span and pmetric.Metric raises flags about how these optimizers work, and it appears to be unnecessary. Note that these types are pointers under-the-hood anyway, and the optimizer was not using these as reference types.

Yea, I had the intent at some point to remove this inconsistency (and others) but I forgot... Thanks.

Also note: the logs optimizer appears to work differently (slightly), so no change there. (Tangent: why does the logs optimizer use a *ResScope where the two others in-line the flattened thing?)

Same thing, don't hesitate to add a todo and I will clean that after my vacations.


Added DeprecatedNoticeWatcher that piggy backs off of the Application…

This PR adds a calls the (new DeprecatedNoticeWatcher())->concernsDeprecatedNotice($message) method from within the ApplicationLogWatcher. The deprecated log notices are disabled by default.
Adding
SEND_DEPRECATED_NOTICES_TO_RAY=true in the .env file will enable the notices to go out to ray again.

Thanks for your work on this.
Right now, all messages that contain the word "deprecated", even on the normal channel, will be ignored.
Can you test if a incoming message is coming from the deprecated channel? That way, messages with the word "deprecated" on other channels will still pass.

Unfortunately I cannot find a way to filter down to the channel. The log is written without a context and by the time we are able to listen for it in laravel ray using the MessageLogged event we only have the level and message.
If anyone has any idea on how to handle this, feel free to comment.

A lot of people will start seeing deprecation warnings when upgrading to PHP 8.1, so I've decided to already go with this way of going about things, until we find a better way.
Currently the tests are failing. Could you make them pass in each environment.
When all tests are green, I'll merge this in.
Thanks for your work on this.

So the problem with the tests was the trigger_error method was causing the tests to fail in the GitHub actions. I replaced the trigger_error with Log::warning. This is actually what Laravel does in the handleDeprecation method which is causing the error.

Looks like the RayTest class was importing the incorrect Log (doesn't exist). I imported the Log Facade instead as there are several tests that use it.

Seems like we have failures because of deprecation warnings in Laravel 7. Do you know how to let PHPUnit pass even though there are deprecation warnings?

I doesn't seem possible. I went down the google rabbit hole to find a solution, but no luck. I was finally able to get the failure to happen locally, but I am unable to get the tests to pass.

Could you try adding this line to the setup method of the base test to see if that helps?
error_reporting(E_ALL & ~E_STRICT & ~E_DEPRECATED);

@freekmurze It didn't work. Same error During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Http\Request::offsetExists($offset)

Try adding this: PHPUnit_Framework_Error_Deprecated::$enabled = false; (hat tip to @lukeraymonddowning)

Ok, thanks for trying, I'll just ignore the P8.1 / Laravel 7 combination in the workflow. 👍


CI Implementation for the project

Fix #27
-Added CI for Automapper.EF6
-Secrets needed to be added to run this CI

MYGET_CI_NURL ~ Nuget server URL
MYGET_CI_API_KEY ~ Nuget server key

Testing:
-Tested by publishing on personal NuGet server and then reference it in test app targetting .net core 3.1.

@jbogard We need the settings in the repo.

@mudassir014 The MyGet url is https://www.myget.org/F/automapperdev/api/v3/index.json. We don't need a setting for that one.

The settings are already in the org:

https://myget.org/feed/automapperdev/package/nuget/AutoMapper.EF6
@mudassir014 Thanks!

@lbargaoanu
Thank you for letting me contribute. This is my first contribution and also to a well known repo. Can't express my happiness :)


set position programmatically

Hi Alex thanks for this very nice library
I use your library and I want to set current item programmatically.
for that I use this code:
horizontalViewpager.setCurentitem(horizontalViewpager.getCurentItem()+3);
but it's not working and my app going to not responding page in android.
is there any way to go to a page programmatically?

Hi @mohamadk. If this is issue is actual please share some code so I can help you

Hi alex sorry for response too late.
btn.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
verticalPager.setCurrentItem(verticalPager.getCurrentItem()+3);
}
});
add this code in your view factory then click on button. you will see app going to not responding page. atleast in my case htc desire 200.

@mohamadk You see, this library doesn't have this feature. I can't give you some quick workaround for this because I don't know it. My advice: try to avoid such views as this, it doesn't match to Google guidelines and can be unfrendly to user.
Tip: you can replace this view with simple GridView and arrows. Maybe not the best solution but much predictable and supportable.


chore/splash_revamp

This PR includes:

A revamp on the splash screen to look more pleasing

LGTM!


Delete deviceEKs on deprovision, deprovision on revoke

Adds ForceDeleteAll to delete deviceEKs on deprovision and nukes the LocalChatDb as well. userEKs and teamEKs were already cleared when LocalDb is nuked.  Major change is that if we detect we've been revoked (LogoutAndDeprovisionIfRevoked), we now do the same secret clearing as deprovisioning.
cc @patrickxb @maxtaco

tested keybase deprovision and a manual test hitting the background check


Containerd drops support for golang 1.9.x

See https://github.com/containerd/containerd/pull/2162
They have pulled in a golang 1.10 library.. so now need 1.10 to build.

Let's do the same. :)

Let's close this issue after containerd build in Kubernetes test infra is also switched to golang 1.10.

We can close this now. We've changed Kubernetes test-infra to build cri-containerd with golang 1.10.


Add support for more ANSI codes.

Add support for this codes in SGR section.

Added basic SGR codes (e.g. bold, italic, blink). Some terminals may not support it.


Missing reference links

For example, see section "1.1 Goals" ... the NetCDF and COARDS links are missing.

Fixed in ea6589ab51cafca6a7657bf57015c1fc4a149c10 and 098090af742b4bd40c7079e5efd94d3c8ee5f6d3.


GRAFANA_TOKEN env variable is not passed correctly

When the Grafana class is initialized in grafana.py, there is only a check for the "url" field in the parameters. If the GRAFANA_TOKEN env variable is set, the token is never passed to the GrafanaApi client and therefore results in a GrafanaUnauthorizedError when making requests using grafana_client. A credential field needs to be added to the from_url call to populate the GRAFANA_TOKEN env variable.

Dear @julialau23. Thanks a stack for the report. May we ask if you would have the capacities to submit a patch?

Hi Andreas,
Sure I can do that. Can I get write access to the repo?
On Wed, Jul 3, 2024 at 1:17 PM Andreas Motl @.***>
wrote:

Dear @julialau23 https://github.com/julialau23. Thanks a stack for the
report. May we ask if you would have the capacities to submit a patch?
—
Reply to this email directly, view it on GitHub
https://github.com/grafana-toolbox/grafana-import/issues/16#issuecomment-2207169728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APHZBJWBEYZQLWD3G3LLIMDZKRL7HAVCNFSM6AAAAABJJTPFUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGE3DSNZSHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @julialau23. We just wanted to check if you have been able to come up with a solution for this?

Hi @amotl, apologies for the delay. Pull request has been opened.

Thanks a stack for your contribution per GH-19. I've just merged the improvement with GH-20.

Your improvements have been released per grafana-import v0.3.0, now on PyPI.

I think it will be safe to close this issue. Please re-open otherwise.


increase code coverage

Codecov Report

Merging #233 (e8a5b6f) into main (066564e) will increase coverage by 2.13%.
The diff coverage is 19.77%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   19.83%   21.97%   +2.13%
==========================================
  Files         209      221      +12
  Lines       27303    27114     -189
==========================================
+ Hits         5416     5958     +542
+ Misses      21887    21156     -731

Flag
Coverage Δ

gsagh
21.97% <19.77%> (+2.13%)
:arrow_up:

integration
∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


Photos tab not working

The photos tab below photos doesn't do anything.  Example- http://www.lonelyplanet.com/europe/tours/history-culture/eastern-europe-croatia-balkans

@lemmiestone do you mean photos button? I can click either photos or map:

This looks to be resolved I will close it.


Consider using native StringEncoder when available

There's a native html5 api for string encoding and decoding. Benchmark it and see if it's faster to use it, when possible.

Tried that here — nope. Extremely harmful for performance — with native TextEncoder/TextDecoder, it like 5x slower in Chrome.

Good to know. The API will probably get faster in a few years when the API is used more in the wild and there's a reason to optimize it.
I'll close this issue for now, since we can't afford a 5x perf hit.


The charge is assigned by estimate_amino_acid_charges incorrectly if heteroresidue is bonded to functional group

Hello,
I'd like to report a potential bug. If I assign formal charges to the amino acids in protein 1rcm using the function hydride.estimate_amino_acid_charges(..., ph=10), the charges -1 are also assigned to the sulfur atoms to which the acetic acid (ACY) is bonded and the formal charge should be therefore 0.
I looked into https://github.com/biotite-dev/hydride/blob/main/src/hydride/charge.py and if I understand correctly the case where a hetero-residue is bonded to a functional group is not treated.

Even sulfurs in a disulfide bond have a charge of -1.

If I'm not mistaken, it might be enough to check if the atoms are not involved in an interresidual bond.

Your analysis seems to be totally correct :+1:, thanks for reporting. Would you like to create a fix PR for it?

I can if you want, but not until January. The end of the year is crazy in the academic world. I'll add the selenocysteine and pyrolysine as i mentioned in issue 19.


Installation manual is missing a few steps

Installation manual is missing a few steps, we've figured it out eventually, but it took me a bit, since I'm not that familiar with Laravel.

The "storage" and "bootstrap/cache" directories need at least 770 perms.

Also there was one missing symlink, that should be created by Artisan with the following command:
php artisan storage:link

perhaps a list of minimum requirements of the Apache2 vhost could also shave some time of, since Laravels routing (like most frameworks) heavily depends on mod_rewrite. Like:
RewriteEngine on
Options +FollowSymLinks
AllowOverride All

Please keep going, this app looks really nice 👍

Hi Ariaan,
I rewrited the installation manual.
If there is anything else I can help you with feel free to open a new issue.
Closed.


VQA-CPv2

Hi! I have some questions about the files preprocessed from the dataset VQA-CP v2 and used in your work. Because VQA-CP v2 only has the training and test questions and annotations, how to generate files trainset.pth and valset.pth? Is it based on the 'coco_split' ?

Sorry to bother: How to test VQA-CP v2 ?  Does it share the same test dataset with VQA v2 ? And the results on VQA-CP v2 is 39.54%. Which dataset to be tested on? Should it submit on the website to get results?
Hope for your respond, thanks~

Test datasets are different. You can visit https://www.cc.gatech.edu/~aagrawal307/vqa-cp/ for more details about VQA-CP v2.

Hi @Zzmonica and @nicholasly,
Thanks for your interest!
You can run experiments on VQACPv2 using this command line:
python -m bootstrap.run \
-o murel/options/vqacp2/murel.yaml \
--exp.dir logs/vqacp2/murel

And then you can display a comparison of several experiments with:
python -m murel.compare_vqa_val -d logs/vqacp2/murel logs/vqacp2/murel_exp2

VQACPv2 comes with a train set and a test set (with annotations):
$ ls data/vqa/vqacp2/raw/annotations/
mscoco_train2014_annotations.json  OpenEnded_mscoco_train2014_questions.json  vqacp_v2_test_annotations.json  vqacp_v2_train_annotations.json
mscoco_val2014_annotations.json    OpenEnded_mscoco_val2014_questions.json    vqacp_v2_test_questions.json    vqacp_v2_train_questions.json

As the test set comes with answer annotations (not like in VQA 2.0 dataset), we consider the test set as a val set. See some preprocessing of the data.

@Cadene Thanks for your respond !

Oh I know, the results of VQA-CP v2 is actually testing on the val set (for that it has annotations).

I was also wondering that what type of GPU did you use to train the VQA v2 ? And some details of the training setup?

About the training results: I have the same experiment setup as your repository, didn't change anything, but the results on VQA v2 val dataset is lower than yours, like the overall result is ~0.6% lower than baseline's 65.14%.

Any suggestions?  Hope for your respond, Thanks!

@Zzmonica

I was also wondering that what type of GPU did you use to train the VQA v2 ? And some details of the training setup?
pytorch 0.3 and 1 * Titan X Pascal and 4 * Titan X Pascal for the biggest model (pairwise + n_step=3)

About the training results: I have the same experiment setup as your repository, didn't change anything, but the results on VQA v2 val dataset is lower than yours, like the overall result is ~0.6% lower than baseline's 65.14%. Any suggestions?
Unfortunately, I am not able to reproduce this result on pytorch 1.1 with the current code... It is largely due to an issue with the backward pass. That's a shame and I am working on it right now. I should be able to push a fix and upload pretrained models that reach/surpass 65.14% before the end of this week. I am so sorry for the inconvenience.

For more info about the issue:
https://gist.github.com/Cadene/a00eba2db81f44b4492dc8941f6abe45
(pytorch.0.30) $ python bug_pytorch03.py
1.8359577655792236

(pytorch.1.1) $ python bug_pytorch11_slow.py
3.8738763332366943

(pytorch.1.1) $ python bug_pytorch11_nograd.py
0.9558875560760498

(pytorch.1.1) $ python bug_pytorch11_detach.py
0.955887556076049

@Zzmonica
https://github.com/Cadene/murel.bootstrap.pytorch/commit/7c9eaebfa6b0fe2565d97dac01001ea9e6ddae7b
FIXED!!!!
YEEAAAAAHAHAHDHASHUASDHSYHDS

Thank you very much!!!   I'll try that.

I retrained the murel model, and the results of the modified version is even lower than the past version. So confused.
Have you retrained the new version and what's the performance?

Please ask,where is the run.py? does the run.py of this project is based on the https://github.com/Cadene/block.bootstrap.pytorch  ?
thank you so much

can i get your log ?the result of VQACPV2


Parse a month with the current date higher as the max(date) of the parsed month

If you parse the value "April 2013" when the current date is "31 July 2013" the parser will output the wrong date.
Change your system date to a higher date than 28 and run following plunker:
https://plnkr.co/edit/htRbt2b0JM5H7sQ2RwXe?p=preview

Merged fix


Changing terminology: examples into tests

Closes: #277
Merge together with: Atomkraft #147
Description:

changes terminology: examples are now tests
fixes the way the extra simulation trace was handled: now it remove example0.itf.json

@ivan-gavran this commit history looks strange to me. can you please rebase your branch from the latest dev?


Persistent compilation cache can exceed GCS retry rate

Description
A Cloud TPU user is reporting the following error when using the persistent compilation cache:
tensorflow.python.framework.errors_impl.AbortedError: All 10 retry attempts failed. The last failure: Error executing an HTTP request: HTTP response code 429 with body '{
  "error": {
    "code": 429,
    "message": "The rate of change requests to the object [...] exceeds the rate limit. Please reduce the rate of create, update, and delete requests.",
    "errors": [
      {
        "message": "The rate of change requests to the object [...] exceeds the rate limit. Please reduce the rate of create, updat'
         when resuming upload gs://[...]

Ideas for fixing or mitigating:

Somehow batch requests? Is this possible?
Add an adjustable threshold to only cache larger programs. Small programs benefit less from caching, and maybe this would provide a knob for lowering the GCS request rate.
https://github.com/google/jax/issues/12582
Other ideas?

What jax/jaxlib version are you using?
jax 0.3.17, jaxlib 0.3.15
Which accelerator(s) are you using?
TPU
Additional system info
No response
NVIDIA GPU info
No response

the adjust able threshold seems like a very good idea - from the absl logging output it looks like it's dumping a really huge amount of very tiny programs that are probably not worth reading from / writing to cloud storage


Homepage still says diaperbase.org - -needs to be updated to diaper.app

The homepage (static#index) still says "diaperbase.org" but the new official site is diaper.app
May want to look through the rest of the site for instances of diaperbase.org and update them to diaper.app

Hi @armahillo, i can solve this one o/


Show error when agent is undefined

Works as expected when there is no agent in Local Storage, but when the agent in Local Storage is undefined the app doesn't start...

Agreed that this error should be handled in some better way, but how did this state occur? Was it through UI interaction or through debugging / hard-setting values in devtools? Do you perhaps have reproduction steps?

I'm not sure how this happened exactly, but it wasn't through devtools. If it happens again I can look for reproduction steps.


Agent logrotation

The logrotation configuration file doesn't work for a variety of reasons, security_group logs aren't considered at all.
This PR should fix those issues

In this case it's Ubuntu only, not RPM. Didn't check them yet.
But LGTM for Ubuntu in this case

ACS CI BVT Run
Sumarry:
Build Number 844
Hypervisor xenserver
NetworkType Advanced
Passed=108
Failed=5
Skipped=12
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
Failed tests:

test_routers_network_ops.py

test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 32 runs

test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 32 runs

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 32 runs

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 32 runs

test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@The-Loeki can you fix a JIRA id for this?

https://issues.apache.org/jira/browse/CLOUDSTACK-10011

@The-Loeki thanks, can you squash your changes and include the JIRA id in the git commit message

ACS CI BVT Run
Sumarry:
Build Number 1003
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=8
Skipped=12
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
Failed tests:

test_scale_vm.py

ContextSuite context=TestScaleVm>:setup Failing since 32 runs

test_deploy_vm_iso.py

test_deploy_vm_from_iso Failing since 60 runs

test_vm_life_cycle.py

test_10_attachAndDetach_iso Failing since 60 runs

test_routers_network_ops.py

test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 93 runs

test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 93 runs

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 91 runs

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 91 runs

test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-875

@rhtyd Is there a bug in the PR?  on our KVM server, our logrotate is as below.  isn't @AGENTLOG@  supposed to re replaced with file names?
@AGENTLOG@
/var/log/cloudstack/agent/security_group.log
{
    copytruncate
    daily
    rotate 5
    compress
    missingok
}

@Slair1 yes, I think there was a PR that tries to fix this. Please see latest 4.11, perhaps open a PR if needed, or ping me.


The tenant nodeSelector is not updated correctly

Bug description
When updating the tenant nodeSelector in the tenant manifest, the new selector is just appended in the tenant namespaces instead of substituted.
How to reproduce
Steps to reproduce the behaviour:

Having a tenant manifest with a given node selector

  nodeSelector:
    kubernetes.io/os: linux

as tenant owner, create a namespace

$ kubectl create ns usl1

and check the namespace is correctly labeled

apiVersion: v1
kind: Namespace
metadata:
  name: usl1
  annotations:
    scheduler.alpha.kubernetes.io/node-selector: kubernetes.io/os=linux

as cluster admin, update the tenant above as following:

  nodeSelector:
    kubernetes.io/hostname: cmp

back as tenant owner and check the namespace

apiVersion: v1
kind: Namespace
metadata:
  name: usl1
  annotations:
    scheduler.alpha.kubernetes.io/node-selector: kubernetes.io/hostname=cmp,kubernetes.io/os=linux

Expected behavior
As cluster admin, it should be possible to update correctly the tenant node selector
Logs
Additional context

Capsule version: build for #30
Kubernetes version: irrelevant

Nice finding!
The reason of this resides on the missing full resync upon Tenant reconciliation, can be easily achieved.

The reason of this resides on the missing full resync upon Tenant reconciliation

That was wrong since we already implemented it
https://github.com/clastix/capsule/blob/0ff047ee10530fc03838376c3ac53d8af87419a6/controllers/tenant_controller.go#L512-L548
@bsctl I tried to replicate your issue but I wasn't able, keep in mind I'm using the HEAD 0ff047e (the current origin/master).

@prometherion  not able to reproduce once more ... let's to close it and in case we'll reopen. Thanks


Add example to connect with CausalPy geo-lift?

Lift test is important for MMM model calibration, but it is I'm not sure on how to update prior to the experiment lift test. Recently pymc just released CausalPy, and I think it is a good idea to have an example on how to predict, evaluate, and iterate on the results

Yes, we do plan to add this. Is this something you are interested in contributing?

I'm not sure, I don't know how exactly on a couple things

How to add MMM model to CausalPy, but likely to do with this script template
Not sure on how to iterate model after incremental test

In Lightweight_mmm, they didn't specify how to update their model after incremental testing. This can be seen missing from their flowchart (below)

In Robyn

in Model Calibration section, they have optimize using NRMSE , and decomp.RSSD
robyn_refresh() which will create new model consistent with previous data, and new data
Robyn has the option to extract trend + seasonality from the whole data, (using prophet) while only modeled using small window of media data (e.g. 2 years of data collection, but using only 3 months of media spending, see Model Window section)

In Robyn, I think it is because they use optimization based approach, they can customize, and update with the new data. But for Bayesian in PyMC, other than restart the whole model, I don't see how to update model to be consistent with the incremental testing results

Hi @thipokKub. Would you be able to just expand a bit on your thoughts here? The issue title seems to focus on CausalPy and geolift (there is an example on that in the causalpy docs https://causalpy.readthedocs.io/en/latest/notebooks/geolift1.html), but the main content of the issue seems to focus more on how to incorporate lift test observations into the MMM.

Sorry, I've got a bit off-track. What I was trying to do is finding a repeatable testing, and calibration pipeline for MMM model, which is not exactly what I asked. But from what I've found from this pdf. The model need to be able to perform lift test, then recalibrated from the observed ROAS
I'm thinking that CausalPy can be used in for either synthetic control or difference-in-difference analysis specifically on ROAS/mROAS

I believe the lift test/calibration part of this is best suited for an issue in pymc-marketing.
We have an aspiration that CausalPy and PyMC-Marketing will synergise, and this sounds like it could be a particular example of that. Right now, we are not quite there, but I'm hoping to spend some time soon to ensure that we've got the right abstractions in CausalPy to be used by PyMC-Marketing.
Tagging @cluhmann, @lucianopaz, @ricardoV94 for their thoughts.


Add functionality for printing rules to a rules channel.

This is merely piggybacking on the reset command, it may be possible/preferable to split into another command.
Needless to say, it should be tested, and I didn't add anything to the config template as I don't think I have access to Notswitched.

The main problem is that #rules is a bit different from the other channel so we need to change the message a bit for that channel

and I didn't add anything to the config template as I don't think I have access to Notswitched.

Don't worry ave doesn't have access anymore either hehe

Thanks for your PR, I'll merge it.