Source Install Issues / Panel Status Bug

2 issues in 1 report, fancy!

When a server is installing, for the ACP it shows the status of "installing", however for the regular user, it shows "error". Unsure which is correct information, would be appreciated if that could be in sync.

Source servers do NOT install, wing's stalls at "Pulling image  ... this could take a few minutes." It notes that in the logs however never follows up. No following errors are show, and the server can be deleted as normal (when applying the #421 fix).

Every issue should be in one issue -> not that fancy after all 😜

I found these bugs at the same time, thought about knocking out two birds with one stone.

Can you please provide actual error logs from #2. Preferably from the daemon.

Oh I didn't even try it as a normal user so didn't even see it was an issue

@DaneEveritt Thats the thing, there is no error. It just says its pulling the image and nothing else. If there was more to give, I for sure would but sadly it just stops dead in its tracks.

Can you just provide the output for me so I can follow what is happening?

{"name":"wings","hostname":"REMOVED","pid":2191,"level":30,"msg":"Pulling image ubuntu:16.04 ... this could take a few minutes.","time":"2017-05-03T08:20:05.070Z","v":0}

I mean the output prior to that, like the 10 lines prior.

{"name":"wings","hostname":"<removed>","pid":2191,"server":"06b5ec19-3951-41f6-939e-936a9924e6af","level":40,"msg":"Container was not found. Attempting to recreate it.","time":"2017-05-04T00:53:11.777Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"level":30,"msg":"Checking if we need to update image quay.io/pterodactyl/core:source, if so it will happen now.","time":"2017-05-04T00:53:11.777Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"level":30,"msg":"Pulling image quay.io/pterodactyl/core:source ... this could take a few minutes.","time":"2017-05-04T00:53:12.491Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"server":"06b5ec19-3951-41f6-939e-936a9924e6af","level":30,"msg":"Completed rebuild process for server container.","time":"2017-05-04T00:53:21.169Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"server":"06b5ec19-3951-41f6-939e-936a9924e6af","level":40,"msg":"Server booting is now BLOCKED.","time":"2017-05-04T00:53:21.170Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"server":"06b5ec19-3951-41f6-939e-936a9924e6af","level":30,"msg":"Blocking server boot until option installation process is completed.","time":"2017-05-04T00:53:21.171Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"server":"06b5ec19-3951-41f6-939e-936a9924e6af","level":30,"msg":"Writing output of installation process to file. { file: '/home/daemon/config/servers/06b5ec19-3951-41f6-939e-936a9924e6af/install.log' }","time":"2017-05-04T00:53:21.172Z","v":0} {"name":"wings","hostname":"<removed>","pid":2191,"level":30,"msg":"Pulling image ubuntu:16.04 ... this could take a few minutes.","time":"2017-05-04T00:53:21.857Z","v":0}

Unable to replicate the SRCDS error.
21:20:59.301Z DEBUG wings: New container successfully created with ID 1b18dd3963ac (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.301Z DEBUG wings: Containers successfully rotated, updating stored configuration. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.311Z  INFO wings: Completed rebuild process for server container. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.324Z DEBUG wings: Loaded configuration and initalized server. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.324Z  WARN wings: Server booting is now BLOCKED. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.325Z  INFO wings: Blocking server boot until option installation process is completed. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.326Z DEBUG wings: Contacting remote server to pull scripts to be used. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.326Z DEBUG wings: Contacting panel to determine scripts to run for option processes. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.328Z  INFO wings: Writing output of installation process to file. { file: '/srv/daemon/config/servers/e6da753b-82fb-462a-8ca1-37896588aadf/install.log' } (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.706Z DEBUG wings: Writing temporary file to be handed into the Docker container. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:20:59.706Z DEBUG wings: Pulling ubuntu:16.04 image if it is not already on the system. (server=e6da753b-82fb-462a-8ca1-37896588aadf)
21:21:00.303Z  INFO wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:02.304Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:04.305Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:06.306Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:08.306Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:10.307Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:12.307Z DEBUG wings: Pulling image ubuntu:16.04 ... this could take a few minutes.
21:21:12.468Z DEBUG wings: Running privileged docker container to perform the installation process. (server=e6da753b-82fb-462a-8ca1-37896588aadf)

Oh wait, I see the issue.

So is this issue still closed then?

Officially closed as of https://github.com/Pterodactyl/Panel/commit/ee309b095e819be300a241753c76245b639313ad


Data Hosts Resetting to Not Monitored

Hi Guilhem,
Thanks to your enhancement to allow us to monitor our Splunk estate using the _internal index I enabled 64 of our Splunk servers. Then, when I switched back to Data Sources, there were a load of additional sources that I had deliberately left unmonitored that were now being monitored?!? I have disabled quite a number of these Data Sources and now all of my Splunk estate monitoring has been disabled again!
Is this a behaviour that you would expect? i.e. enabling monitoring on a host enables monitoring of a Data Source?
Cheers,
Mark.

@cidermark
Can you provide some screenshots please?
Host monitoring (Splunk host monitoring) is for data hosts and metric hosts, not data sources.

Hi Guilhem,
Screenshots might be a bit difficult as it would just show an empty screen :)
Is there a search that I could run that will pull
a) the status of all my Data Sources (name, enabled/disabled) and
b) the status of all my Hosts ( name, enabled/disabled)?
If there is, I could get all my Data Sources back to how I want them, run and export the report. Enable all the Splunk estate hosts and run/export the report. Finally, when the Hosts get disabled again, run the report once more. Hopefully that might shed some light.
It might take me a little while to get my Data Sources back into shape so do you want to 'hold' this for a while and I'll get back to you?
Cheers,
Mark.

Hi Mark,
I think you are getting confused.
First, let me clarify:

All Splunk instances, Universal Forwarders or Heavy Forwarders, are supposed to be forwaring the internals to the indexing layer, this is a proper configuration and good practice configuration.

An example is here: (Splunk PS base config apps)
https://drive.google.com/open?id=107qWrfsv17j5bLxc21ymTagjtHG0AobF
So I don't understand really what means "I enabled 64 of our Splunk servers" for example, this is not clear and can mean anything.

There are 3 main concepts in TrackMe:

data sources
data hosts
metric hosts

Each of these have their own definitions for allow list (the indexes you allow TrackMe to be looking at) and the block lists (different options to exclude things you do not want)
There are no interactions between each other.

monitored status true or false

An entity, a data source, host or metric host, can be monitored or not, the fields is in the lookups:

data_monitored_state (for data sources and data hosts)
metric_monitored_state (for metric hosts)

The 3 lookups and other lookups can be accessed easily via the app nav menu.
These KVstore collections, you can perform bulk updates manually in SPL.

Splunk estate monitoring

The new feature does the following:

When enabled and when the allow list and block lists allow it, in data hosts we take into account "index=_internal sourcetype=splunkd"

In metric hosts, and if the allow / block list allow it, we take into account the equivalent of the _internal for the metrics, which were introduced by Splunk some versions ago.

There is nothing related at all with data sources.
I do not understand your issues / context because you mixing these altogether.
--> data sources is NOT where monitoring of the Splunk instances happens
--> data host is where you would see the _internal and splunkd, for example:

So:

Explain more clearly your issues at the lights of these explanations

Review what you expected, review in data sources your allow lists and block lists

Review in data hosts, not data sources, this where you should see your internal data for the Splunk UF/HF etc

In addition in data hosts, along with the _internal there will be all the data that TrackMe is allowed to look at

This is quite simple, what appears in TrackMe is what you give TracMe access to

@cidermark
Please have a look here:
https://trackme.readthedocs.io/en/testing/monitor_forwarders.html
This will answer your questions regarding the monitoring of Splunk instances forwarding.

Hi @cidermark
Any update?
Let me know if you are still running into trouble / confusion.

Hi @guilhemmarchand.
Sorry, I've been off work this week so I've not been able to do anything more on this. I should be back next week so I'll update you then.
Cheers,
Mark.

@cidermark
I am assuming you fixes your issues, let me know otherwise.


cawbird: 1.0.4 -> 1.0.5

Motivation for this change
just a simple version bump, no major changes
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build cawbird

[x]  built on NixOS
[x]  tested basic help messages of all binaries
[x]  checked OfBorg all green

Thanks for reviews.

backport: #84891

I guess I skip the backport to 19.09, as it'll be EOL quite soon and the update doesn't seem to include any important security fixes.

I guess I skip the backport to 19.09, as it'll be EOL quite soon and the update doesn't seem to include any important security fixes.

Yeah, bugfixes and security updates for 19.09 should still be done. But this is really minor.


fixed error capitalization

fixes #637

Actually, before we close #637, we should also fix cli/cmd/cluster-destroy.go and cli/cmd/cluster-apply.go context logger messages, which are not capitalized at the moment.

@invidian do you mean contextLogger.Fatalf messages only ? or do you want to include contextLogger.Println messages as well?

@dev-gaur it seems all Println occurences are already capitalized. I only see 2 lines with not capitalized Fatalf:

error applying cluster
error destroying cluster

@dev-gaur it seems all Println occurences are already capitalized. I only see 2 lines with not capitalized Fatalf:

error applying cluster
error destroying cluster

Aah I see. I thought you wanted to remove capitalization..
I have a confusion:
FatalF messages are technically exiting errors... So why do we want to capitalize them?

FatalF messages are technically exiting errors... So why do we want to capitalize them?

Because those are the messages, which gets printed to the user, so they should be capitalized.

FatalF messages are technically exiting errors... So why do we want to capitalize them?

Because those are the messages, which gets printed to the user, so they should be capitalized.

Thanks for clarifying. Changes made.

even I learnt a bit about error formatting :)
thanks for attending to my PR so promptly


Could not find donor npc

With some mods, the tool doesn't work and cites that it "Could not find donor NPC". The tool often works if the donor npc is from a script heavy mod, but fails with the ESL flagged ones mainly.
I tried removing the ESL flag, and installing some standalone followers without the ESL flag and it still fails to find the donor npc. Any idea on how to fix this?

For anyone else having this issue, remember to have Synthesis loaded last in your load order. Stupid mistake, literally just dragged Synthesis down to the bottom and it worked

Yep, Synthesis ignores whatever is below its own esp. Glad you figured it out!


How to successfully run PowerGenome to create input files for GenX pertaining to only a specific chosen region (in the case below, of WEC_SDGE IPM)

I have been going through the latest PowerGenome README and example notebooks, but, it's still not quite clear to me if I want to generate the inputs for SDGE_IPM region for GenX, how should I proceed. Should I start off from the example_system folder and go inside the test_settings.yml file? I can see over there that the CA_S under region_aggregations is a list that does have the WEC_SDGE as one of the elements. How can I activate only that and not others, so that the input for GenX that I generate (which is the output of PowerGenome) has only data corresponding to WEC-SDGE? Or, is what I am thinking not the right way to proceed? Can you please help me out at your earliest convenience? Thanks a lot !!!!
PS: Latest update: I did the above-mentioned changes (kept only WEC_SDGE within CA_S) and also emptied the CA_N list, as well as commented out the CA_N and WECC_AZ (under model_regions), but, I am getting errors mid-way through, while running the PowerGenome script.
I tried a few different means of eventually getting rid of all the CA_N entries, wherever it appears in the test_settings.yml and keeping only the WEC_SDGE within CA_S and running PowerGenome each time. I get error at this stage:
[    INFO] powergenome.generators:2363 Results technologies are ['Biomass', 'Hydroelectric Pumped Storage', 'Natural Gas Fired Combined Cycle', 'Natural Gas Fired Combustion Turbine', 'Onshore Wind Turbine', 'Small Hydroelectric', 'Solar Photovoltaic', 'Conventional Hydroelectric', 'Conventional Steam Coal', 'Nuclear']
Here's the error that I get:
Traceback (most recent call last):
File "/home/samie/anaconda3/envs/powergenome/bin/run_powergenome_multiple", line 33, in
sys.exit(load_entry_point('powergenome', 'console_scripts', 'run_powergenome_multiple')())
File "/home/samie/code/PGForked/PowerGenome/powergenome/run_powergenome_multiple_outputs_cli.py", line 233, in main
gen_clusters = add_misc_gen_values(gen_clusters, _settings)
File "/home/samie/code/PGForked/PowerGenome/powergenome/GenX.py", line 104, in add_misc_gen_values
] = value
File "/home/samie/anaconda3/envs/powergenome/lib/python3.7/site-packages/pandas/core/indexing.py", line 204, in setitem
indexer = self._get_setitem_indexer(key)
File "/home/samie/anaconda3/envs/powergenome/lib/python3.7/site-packages/pandas/core/indexing.py", line 182, in _get_setitem_indexer
return self._convert_tuple(key, is_setter=True)
File "/home/samie/anaconda3/envs/powergenome/lib/python3.7/site-packages/pandas/core/indexing.py", line 262, in _convert_tuple
idx = self._convert_to_indexer(k, axis=i, is_setter=is_setter)
File "/home/samie/anaconda3/envs/powergenome/lib/python3.7/site-packages/pandas/core/indexing.py", line 1278, in _convert_to_indexer
if com.is_bool_indexer(obj):
File "/home/samie/anaconda3/envs/powergenome/lib/python3.7/site-packages/pandas/core/common.py", line 130, in is_bool_indexer
raise ValueError(na_msg)
ValueError: cannot index with vector containing NA / NaN values

Need to fix the function add_misc_gen_values so that it doesn't look for every resource in the misc_gen_inputs_fn file. Or that it can pass over if the resource doesn't exist.

Figured out the real issue in #60

There is also a bug with demand response resources for a single region. The code currently uses .squeeze to transform a df into a series, but it turns a series with one row into a value. This parameter is used to map maximum capacity of the DR resource, which causes an error when it only finds a value.
Fixed in 5161fc12d794f234982741c0a8acf1719acdedae on the bug_fix branch.

@sambuddhac I fixed the transmission issue, so it doesn't break when no transmission lines exist (51657b4dfb4eb7f93011d9b9d7167eb0d0937523).
I also ran the system with WEC_SDGE as the only model region and no region aggregations, which caused a bunch of errors. For now, be sure to comment out the settings parameter region_aggregations if you are not doing any aggregations or re-naming. The settings key is now accessed (c9c1aed96ad181171a75ade2e3e31c3f717670e4) using
settings.get("region_aggregations", {})

rather than
settings["region_aggregations"]

so it sees an empty dictionary rather than NoneType.

@sambuddhac is there anything about this issue still outstanding? If not I'm going to close it.


Fixes bug in ShearProduction kernel

Fixes a bug observed by @qingli411 on #30
We should come up with some simple analytical tests cases that we can run in order to sleep well at night. The dissipation term is a bit of a bear, but this shear production term is slightly easier. Something like u = 1 + cos(x), etc?
@qingli411 let me know if this looks right.
Resolves #30

@glwagner Sure. I will see if I can get a better closure of the TKE budget with this.
Not sure what would be a good analytical test case, but I think some simple cases will be helpful, such as a pure shear driven turbulence case and a pure convection case, for which we know the dominant terms in the TKE budget.

We might be able to use this example for the purpose you're suggestion:
https://github.com/CliMA/LESbrary.jl/blob/2400eac6b49ec1beed9f5d160b34d255e5cca270/examples/constant_stratification_constant_fluxes.jl
which accepts a momentum flux, buoyancy flux, and stratification at the command line (plus the resolution of the simulation and the run time).


Warnings when running sphinx-build

I installed sphinx and furo theme, and ran the script. There were some warnings:
$ ./sphinx.sh
Running Sphinx v5.3.0
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 2 source files that are out of date
updating environment: [new config] 2 added, 0 changed, 0 removed
reading sources... [100%] index
WARNING: autodoc: failed to import module 'fablib'; the following exception was raised:
No module named 'IPython'
WARNING: autodoc: failed to import class 'FablibManager' from module 'fablib'; the following exception was raised:
No module named 'IPython'
WARNING: autodoc: failed to import module 'slice'; the following exception was raised:
No module named 'pandas'
WARNING: autodoc: failed to import class 'Slice' from module 'slice'; the following exception was raised:
No module named 'pandas'
WARNING: autodoc: failed to import module 'node'; the following exception was raised:
No module named 'paramiko'
WARNING: autodoc: failed to import class 'Node' from module 'node'; the following exception was raised:
No module named 'paramiko'
WARNING: autodoc: failed to import module 'component'; the following exception was raised:
No module named 'tabulate'
WARNING: autodoc: failed to import class 'Component' from module 'component'; the following exception was raised:
No module named 'tabulate'
WARNING: autodoc: failed to import module 'interface'; the following exception was raised:
No module named 'fabrictestbed'
WARNING: autodoc: failed to import class 'Interface' from module 'interface'; the following exception was raised:
No module named 'fabrictestbed'
WARNING: autodoc: failed to import module 'network_service'; the following exception was raised:
No module named 'tabulate'
WARNING: autodoc: failed to import class 'NetworkService' from module 'network_service'; the following exception was raised:
No module named 'tabulate'
WARNING: autodoc: failed to import module 'resources'; the following exception was raised:
No module named 'tabulate'
WARNING: autodoc: failed to import class 'Resources' from module 'resources'; the following exception was raised:
No module named 'tabulate'
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index
generating indices... genindex done
writing additional pages... search done
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done

====================== slowest reading durations =======================
0.192 fablib
0.008 index
build succeeded, 14 warnings.

The HTML pages are in docs/build/html.

So I did a pip install ipython pandas tabulate fabrictestbed paramiko, and ran the script again:
$ ./sphinx.sh
Running Sphinx v5.3.0
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 0 source files that are out of date
updating environment: 0 added, 1 changed, 0 removed
reading sources... [100%] fablib
WARNING: autodoc: failed to import module 'fablib'; the following exception was raised:
No module named 'fabrictestbed_extensions'
WARNING: autodoc: failed to import class 'FablibManager' from module 'fablib'; the following exception was raised:
No module named 'fabrictestbed_extensions'
WARNING: autodoc: failed to import module 'slice'; the following exception was raised:
No module named 'fabrictestbed_extensions'
WARNING: autodoc: failed to import class 'Slice' from module 'slice'; the following exception was raised:
No module named 'fabrictestbed_extensions'
WARNING: autodoc: failed to import module 'node'; the following exception was raised:
No module named 'fabrictestbed_extensions'
WARNING: autodoc: failed to import class 'Node' from module 'node'; the following exception was raised:
No module named 'fabrictestbed_extensions'
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index
generating indices... genindex py-modindex done
writing additional pages... search done
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done

====================== slowest reading durations =======================
2.868 fablib
build succeeded, 6 warnings.

The HTML pages are in docs/build/html.

Did a pip install -e . in the source directory, and ran the script again:
$ ./sphinx.sh
Running Sphinx v5.3.0
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 0 source files that are out of date
updating environment: 0 added, 1 changed, 0 removed
reading sources... [100%] fablib
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/fablib.py:docstring of fablib.FablibManager.get_slices:5: WARNING: Field list ends without a blank line; unexpected unindent.
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py:docstring of slice.Slice.add_node:12: WARNING: Field list ends without a blank line; unexpected unindent.
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py:docstring of slice.Slice.add_node:19: ERROR: Unexpected indentation.
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py:docstring of slice.Slice.add_node:18: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/slice.py:docstring of slice.Slice.list_nodes:1: WARNING: duplicate object description of slice.Slice.list_nodes, other instance in fablib, use :noindex: for one of them
/home/sajith/projects/fabric-testbed/fabrictestbed-extensions/fabrictestbed_extensions/fablib/node.py:docstring of node.Node.execute:19: WARNING: Field list ends without a blank line; unexpected unindent.
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index
generating indices... genindex py-modindex done
writing additional pages... search done
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done

====================== slowest reading durations =======================
4.326 fablib
build succeeded, 6 warnings.

The HTML pages are in docs/build/html.


fix: validate metadata before decide create metadata or not

What this PR does / why we need it:
validate metadata before decide create metadata or not, more error info see #301 #295
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?

NONE

Codecov Report

Merging #308 (a7f4891) into main (db6c952) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   16.10%   16.03%   -0.07%
==========================================
  Files          73       73
  Lines        7657     7690      +33
==========================================
  Hits         1233     1233
- Misses       6301     6334      +33
  Partials      123      123

Impacted Files
Coverage Δ

...ocalvolumemigrate/localvolumemigrate_controller.go
10.00% <0.00%> (-0.72%)
:arrow_down:

pkg/local-storage/member/csi/controller.go
0.00% <0.00%> (ø)

pkg/local-storage/member/node/configer/drbd.go
0.92% <0.00%> (-0.06%)
:arrow_down:

.../local-storage/member/node/storage/executor_lvm.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM


Remove QuerySnapshot.forEach

I am not sure of the purpose of this particular method and think we could remove it to reduce the surface area of the client. A user can always iterate over QuerySnapshot.
using current code
query.get().then(querySnapshot => {
  querySnapshot.forEach(documentSnapshot => {
    console.log(`Document found at path: ${documentSnapshot.ref.path}`);
  });
});

without this code
query.get().then(querySnapshot => {
  for (const doc of querySnapshot.docs) {
    console.log(`Document found at path: ${documentSnapshot.ref.path}`);
  }
});

I will bring this up in our Firestore-internal API meeting.


Improve Editor Plugin GUI

This issue is WIP. Details will be added after an initial analysis phase.
Benefit description
The first contributions came when the plugin was not very documented, and they introduced a number of inconsistencies in the GUI.
Also, some of them came from experience with other engines, and they took a form that catered more to them than Godot.
We must improve the consistency of the plugin interface: inspectors, toolbar, popups, etc.
Solution description
WIP - More will be added
Here is a list of tasks to be performed in the scope of this issue:

[x] Walkable Areas polygon edit button should be moved from the inspector to the toolbar
[x] Refactor and improve the editing button canvas menu:

[x] Clicking a selected gizmo (like InteractionPolygon) should toggle back to the related PopochiuClickable node
[x] The present Baseline and WalkToPoint buttons should not select node helpers, but toggle the visibility of the new gizmos instead (split out of #232 )
[x] General refactor of the code, that can be simplified

[x] Gizmos may be designed on the viewport instead of resorting to elements in engine objects. (Addressed in #232 )
[x] #67 may be in scope for this issue
[x] Consider changing "DialogPos" marker2d to a property of the character, with its own gizmo, to keep things consistent (split in #232)
[x] Fix the bug of popup windows on Linux being too large on the vertical axis at first load
[x] Make sure aseprite command defaults to an empty string in the distributed plugin to avoid errors
[x] When you select an element in a room scene while editing another element's polygon, the polygon don't get hidden, but it should.

Exclusions
TBD
Implications
TBD

Closed by last commit by @drbbgh


Batch Question

As I'm getting used to the new tool, it would be great to be able to batch again. However, I have run into 2 probably very simple issues:

After following the Wiki instructions, I have the file saved to the same folder as the queue.txt file. However, when I execute it as .\batch.rb, it seems to run, but no action is taken. There's also no error message and the queue.txt entry is not deleted. Could someone please let me know where I'm going wrong on this?
Once the batch is working, if I have a regular set of preferred options, for example subtitle language choices, can that be added into the batch script rather than being appended to the .\batch.rb command each time?

Thank you so much.

@platonium What OS platform are you using? That would help greatly in diagnosing what the problem might be.
And, yes, you can edit the batch.rb file to add your preferred options.

Thanks, Don, this is on Windows 10.

@platonium OK, then I'll skip to the next step in diagnostics...
Please add this line to your batch.rb script somewhere after the comment header but before the line containing while true:
puts 'testing'

...and run the script again. I want to find out if your script is actually being called by the Ruby interpreter on Windows. If you execute ./batch.rb again and don't see testing printed to your console then something is wrong with your Ruby configuration.
But if you do see that, then we'll move on to the next step.

Thanks, I put the line after queue_path and before the while true.
The command line spit out the same line as before and added the word testing on a separate line underneath, then a full line, and then the cmd prompt>.
The queue.txt file still has the file location of the first (and only) movie on the list.

@platonium OK, now you can remove that "puts 'testing'" line from your barch.rb script.
Before I move to the next step, though, I need you to clarify this:

The command line spit out the same line as before

I was under the impression from your previous description of the behavior that nothing happened. So please paste in your complete console spew here so I know what you mean.

Sorry for being imprecise: the command prompt returns nothing after the .\batch.rb, just a space for the command prompt.
Command prompt>.\batch.rb
Command promot>

@platonium Ah! Got it. That makes more sense. Thanks. OK, back to the steps...
With the temporary inclusion of that "puts 'testing'" line, we know that your Ruby interpreter on Windows 10 is working correctly in that you can definitely execute non-Gem scripts.
That means we've narrowed the scope of the problem to be something wrong with the way you copied the script from the wiki or something wrong with the contents of your queue.txt file.
Let's assume for now that you copied the script correctly and focus on your queue.txt file.
Is the first line of your queue.txt file a full path to your movie? Because if the first line of your queue.txt file is a blank line then the behaviour you're seeing is what I would expect to happen, i.e. nothing.

Thank you so much, Don. This is what's in queue.txt using copy as path. Have also tried without the quotes. Blank output seems the same.
"C:\Video\SECRET_GARDEN_16X9FF\The Secret Garden (1993).mkv"
or
C:\Video\SECRET_GARDEN_16X9FF\The Secret Garden (1993).mkv

@platonium OK, you should not put quotes around the path names. That definitely won't work.
Next question, does that line end with a carriage return/line feed? If there's no line ending character, then the batch.rb script won't work correctly.
If you're not sure whether there's a line ending character, just add a blank line after the path and try again.

LOL, that did it. So the "delimited by carriage returns" as noted in the wiki was much more important than I realized. Thank you again for your patience. Is it ok to continue with the options question in this issue?

@platonium I'm so glad we solved that together!
And, sure, go ahead with your next question. Do you want an example of how to do that?

Yes, please, if you could just show me how to add one option, I should be able to add the rest. It all works when I copy-paste manually into the CLI.

@platonium OK, here's how I would modify the batch.rb script to always use Nvidia HEVC for video and Dolby Digital Plus for surround audio:
#!/usr/bin/env ruby
#
# batch.rb
#

QUEUE_PATH = 'queue.txt'

while true
  content = File.read(QUEUE_PATH)
  input = content.match(/^.*\R/).to_s.chomp

  break if input.empty?

  queue = File.new(QUEUE_PATH, 'wb')
  queue.print content.sub(/^.*\R/, '')
  queue.close

  options = ['--nvenc', '--hevc', '--eac3'] + ARGV

  break unless system('other-transcode', *options, input)
end

Do you see which lines I changed there?

I see the last two lines were changed so I have modified the last two lines in the batch file also.
options = ['--x265', '--hevc', '--add-audio eng', '--add-audio zho', '--add-audio kor', '--add-audio jpn', '--add-subtitle eng', '--add-subtitle zho', '--crop auto'] + ARGV
break unless system('other-transcode', *options, input)
end
However, I am getting this error using the script, which I don't get when I copy and paste manually to the CLI.
C:/Ruby26-x64/bin/other-transcode: invalid option: --add-audio eng
Try other-transcode --help for more information.

@platonium You are getting that error because each argument on the command line needs to be defined in the options array variable as a separate string. Change that line in your code to this and it should work:
options = ['--x265', '--hevc', '--add-audio', 'eng', '--add-audio', 'zho', '--add-audio', 'kor', '--add-audio', 'jpn', '--add-subtitle', 'eng', '--add-subtitle', 'zho', '--crop', 'auto'] + ARGV

Do you see what I mean?

@platonium BTW, that options variable declaration can be much more readable if defined like this:
  options = [
    '--x265',
    '--hevc',
    '--add-audio', 'eng',
    '--add-audio', 'zho',
    '--add-audio', 'kor',
    '--add-audio', 'jpn',
    '--add-subtitle', 'eng',
    '--add-subtitle', 'zho',
    '--crop', 'auto'
] + ARGV

@platonium Also, I don't recommend using the x265 encoder because it will, frankly, be slower that shit to encode. Use a hardware encoder if one is available.

Thank you  again, Don, for your generosity and patience.

@platonium No problem!


[Snyk] Fix for 3 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

frontend/package.json
frontend/package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

159/1000  Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00109, Social Trends: No, Days since published: 386, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.64, Score Version: V5
Denial of Service (DoS) SNYK-JS-DECODEURICOMPONENT-3149970
Yes
Proof of Concept

45/1000  Why? Confidentiality impact: None, Integrity impact: None, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00071, Social Trends: No, Days since published: 427, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 2.35, Likelihood: 1.89, Score Version: V5
Regular Expression Denial of Service (ReDoS) SNYK-JS-MINIMATCH-3050818
Yes
No Known Exploit

169/1000  Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00091, Social Trends: No, Days since published: 182, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.81, Score Version: V5
Regular Expression Denial of Service (ReDoS) SNYK-JS-SEMVER-3247795
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: node-sass
    The new version differs by 43 commits.

7105b0a 5.0.0 (#3015)
0648b5a chore: Add Node 15 support (#2983)
e2391c2 Add a deprecation message to the readme (#3011)
6a33e53 chore: Don't upload artifacts on PRs
d763506 chore: Only run coverage on main repo
d4ebe72 build(deps): update actions/setup-node requirement to v2.1.2
2bebe05 build(deps-dev): bump rimraf from 2.7.1 to 3.0.2
f877689 chore: Don't double build DependaBot PRs
b48fac4 chore: Add weekly DependaBot updates
91c40a0 Remove deprecated process.sass API
1f6df86 Replace lodash/assign in favor of the native Object.assign
522828a Remove workarounds for old Node.js versions
40e0f00 chore: Remove second NPM badge
ab91bf6 chore: Remove Slack badge
6853a80 chore: Cleanup status badges
fb1109c chore: Bump minimum engine version to v10
d185440 chore: Add basic Node version support policy
db25736 chore: Bump node-gyp to 7.1.0
2c5b110 chore: Bump cross-spawn to v7.0.3
38b9633 chore: Update Istanbul to NYC
d63b5bf chore: Bump mocha to v8.1.3
d0d8865 chore: Skip constructor tests on v14.6+
ee3984d chore: Hoist test ESLint config
feee448 chore: Remove disabled and recommended rules

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Checkmarx One – Scan Summary & Details – f7d56f5c-a704-474b-a917-47e07b4b47a5
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Angular_Client_Stored_DOM_XSS
/frontend/src/app/last-login-ip/last-login-ip.component.ts: 32
Attack Vector

CVE-2015-9235
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2015-9235
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2016-1000223
Npm-jws-0.2.6
Vulnerable Package

CVE-2017-12963
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2017-12964
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2017-18214
Npm-moment-2.0.0
Vulnerable Package

CVE-2018-11499
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2018-11694
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2018-11697
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2018-11698
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2018-19827
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2019-10744
Npm-lodash-2.4.2
Vulnerable Package

CVE-2019-10775
Npm-ecstatic-3.3.2
Vulnerable Package

CVE-2020-15084
Npm-express-jwt-0.1.3
Vulnerable Package

CVE-2020-36048
Npm-engine.io-3.5.0
Vulnerable Package

CVE-2020-7733
Npm-ua-parser-js-0.7.21
Vulnerable Package

CVE-2020-7793
Npm-ua-parser-js-0.7.21
Vulnerable Package

CVE-2020-8203
Npm-lodash-2.4.2
Vulnerable Package

CVE-2021-23337
Npm-lodash-2.4.2
Vulnerable Package

CVE-2021-23449
Npm-vm2-3.9.3
Vulnerable Package

CVE-2021-23555
Npm-vm2-3.9.3
Vulnerable Package

CVE-2021-27292
Npm-ua-parser-js-0.7.21
Vulnerable Package

CVE-2021-32803
Npm-tar-2.2.2
Vulnerable Package

CVE-2021-32804
Npm-tar-2.2.2
Vulnerable Package

CVE-2021-33623
Npm-trim-newlines-1.0.0
Vulnerable Package

CVE-2021-37701
Npm-tar-2.2.2
Vulnerable Package

CVE-2021-37712
Npm-tar-2.2.2
Vulnerable Package

CVE-2021-37713
Npm-tar-2.2.2
Vulnerable Package

CVE-2021-3807
Npm-ansi-regex-4.1.0
Vulnerable Package

CVE-2021-3807
Npm-ansi-regex-2.1.1
Vulnerable Package

CVE-2021-43138
Npm-async-2.6.3
Vulnerable Package

CVE-2021-44906
Npm-minimist-1.2.5
Vulnerable Package

CVE-2021-44906
Npm-minimist-0.2.1
Vulnerable Package

CVE-2022-0355
Npm-simple-get-3.1.0
Vulnerable Package

CVE-2022-1537
Npm-grunt-1.4.1
Vulnerable Package

CVE-2022-21213
Npm-mout-1.2.3
Vulnerable Package

CVE-2022-21227
Npm-sqlite3-5.0.2
Vulnerable Package

CVE-2022-23539
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2022-23539
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2022-23540
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2022-23540
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2022-2421
Npm-socket.io-parser-3.4.1
Vulnerable Package

CVE-2022-2421
Npm-socket.io-parser-3.3.2
Vulnerable Package

CVE-2022-24434
Npm-dicer-0.2.5
Vulnerable Package

CVE-2022-24771
Npm-node-forge-0.10.0
Vulnerable Package

CVE-2022-24772
Npm-node-forge-0.10.0
Vulnerable Package

CVE-2022-24785
Npm-moment-2.29.1
Vulnerable Package

CVE-2022-24785
Npm-moment-2.0.0
Vulnerable Package

CVE-2022-24999
Npm-qs-6.9.6
Vulnerable Package

CVE-2022-25758
Npm-scss-tokenizer-0.2.3
Vulnerable Package

CVE-2022-25858
Npm-terser-5.9.0
Vulnerable Package

CVE-2022-25881
Npm-http-cache-semantics-3.8.1
Vulnerable Package

CVE-2022-25883
Npm-semver-7.3.5
Vulnerable Package

CVE-2022-25883
Npm-semver-6.3.0
Vulnerable Package

CVE-2022-25883
Npm-semver-5.7.1
Vulnerable Package

CVE-2022-25883
Npm-semver-5.3.0
Vulnerable Package

CVE-2022-25887
Npm-sanitize-html-1.4.2
Vulnerable Package

CVE-2022-25893
Npm-vm2-3.9.3
Vulnerable Package

CVE-2022-25927
Npm-ua-parser-js-0.7.21
Vulnerable Package

CVE-2022-26592
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2022-31129
Npm-moment-2.29.1
Vulnerable Package

CVE-2022-3517
Npm-minimatch-3.0.4
Vulnerable Package

CVE-2022-36067
Npm-vm2-3.9.3
Vulnerable Package

CVE-2022-37599
Npm-loader-utils-3.0.0
Vulnerable Package

CVE-2022-37603
Npm-loader-utils-3.0.0
Vulnerable Package

CVE-2022-37616
<EMAIL_ADDRESS>Vulnerable Package

CVE-2022-38900
Npm-decode-uri-component-0.2.2
Vulnerable Package

CVE-2022-38900
Npm-decode-uri-component-0.2.0
Vulnerable Package

CVE-2022-39353
<EMAIL_ADDRESS>Vulnerable Package

CVE-2022-43357
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2022-43358
Npm-node-sass-5.0.0
Vulnerable Package

CVE-2022-43441
Npm-sqlite3-5.0.2
Vulnerable Package

CVE-2022-46175
Npm-json5-2.2.0
Vulnerable Package

CVE-2022-48285
Npm-jszip-3.7.1
Vulnerable Package

CVE-2023-22578
Npm-sequelize-5.22.5
Vulnerable Package

CVE-2023-22579
Npm-sequelize-5.22.5
Vulnerable Package

CVE-2023-22580
Npm-sequelize-5.22.5
Vulnerable Package

CVE-2023-25813
Npm-sequelize-5.22.5
Vulnerable Package

CVE-2023-26115
Npm-word-wrap-1.2.3
Vulnerable Package

CVE-2023-26132
Npm-dottie-2.0.2
Vulnerable Package

CVE-2023-26136
Npm-tough-cookie-4.0.0
Vulnerable Package

CVE-2023-26136
Npm-tough-cookie-2.5.0
Vulnerable Package

CVE-2023-28154
Npm-webpack-5.60.0
Vulnerable Package

CVE-2023-29017
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-29199
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-30547
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-32314
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-32695
Npm-socket.io-parser-3.4.1
Vulnerable Package

CVE-2023-32695
Npm-socket.io-parser-3.3.2
Vulnerable Package

CVE-2023-37466
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-37903
Npm-vm2-3.9.3
Vulnerable Package

CVE-2023-43646
Npm-get-func-name-2.0.0
Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2023-46233
Npm-crypto-js-3.3.0
Vulnerable Package

Code_Injection
/routes/showProductReviews.js: 25
Attack Vector

Code_Injection
/routes/trackOrder.js: 12
Attack Vector

Code_Injection
/routes/trackOrder.js: 12
Attack Vector

Cx0b414307-5d4b
Npm-lodash-2.4.2
Vulnerable Package

Cx347a3da7-ba99
Npm-node-forge-0.10.0
Vulnerable Package

Cx62f5bb1b-fa5e
Npm-moment-2.29.1
Vulnerable Package

Cx89601373-08db
Npm-debug-4.1.1
Vulnerable Package

Cx89601373-08db
Npm-debug-3.2.7
Vulnerable Package

Cx89601373-08db
Npm-debug-3.1.0
Vulnerable Package

Cx89601373-08db
Npm-debug-2.6.9
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-4.3.4
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-4.3.3
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-4.3.1
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-4.1.1
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-3.2.7
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-3.1.0
Vulnerable Package

Cx8bc4df28-fcf5
Npm-debug-2.6.9
Vulnerable Package

Cxb3ca64d2-9cd1
Npm-mocha-8.4.0
Vulnerable Package

Cxb5e411c7-17b4
Npm-moment-timezone-0.5.34
Vulnerable Package

Cxc7705965-e0f0
<EMAIL_ADDRESS>Vulnerable Package

Cxc7705965-e0f0
<EMAIL_ADDRESS>Vulnerable Package

Cxdca8e59f-8bfe
Npm-inflight-1.0.6
Vulnerable Package

Cxdd801a12-8c33
Npm-jsonwebtoken-0.4.0
Vulnerable Package

Cxdd801a12-8c33
Npm-jsonwebtoken-0.1.0
Vulnerable Package

Cxe299c2b0-ccc8
Npm-domutils-1.1.6
Vulnerable Package

Cxf6e7f2c1-dc59
Npm-yauzl-2.10.0
Vulnerable Package

Cxffc79d87-98d9
Npm-jws-0.2.6
Vulnerable Package

Reflected_XSS
/routes/recycles.js: 12
Attack Vector

SQL_Injection
/routes/login.js: 29
Attack Vector

SQL_Injection
/routes/dataExport.js: 14
Attack Vector

SQL_Injection
/routes/dataExport.js: 30
Attack Vector

SQL_Injection
/routes/search.js: 12
Attack Vector

SQL_Injection
/routes/login.js: 29
Attack Vector

SQL_Injection
/routes/orderHistory.js: 11
Attack Vector

Second_Order_SQL_Injection
/data/datacreator.js: 215
Attack Vector

Second_Order_SQL_Injection
/data/datacreator.js: 122
Attack Vector

Stored_XSS
/routes/userProfile.js: 17
Attack Vector

Stored_XSS
/routes/login.js: 30
Attack Vector

Stored_XSS
/routes/login.js: 30
Attack Vector

Stored_XSS
/routes/search.js: 15
Attack Vector

Stored_XSS
/routes/chatbot.js: 30
Attack Vector

Stored_XSS
/routes/chatbot.js: 30
Attack Vector

Stored_XSS
/routes/languages.js: 25
Attack Vector

Stored_XSS
/routes/videoHandler.js: 47
Attack Vector

Stored_XSS
/routes/videoHandler.js: 78
Attack Vector

More results are available on AST platform


thread main panicked at called Option::unwrap() on a None value, src\site_generator.rs:298:26

Hello,
thank you for giving the doctave project a new home and a future!
I ran into some issues trying to migrate my doctave project to docgen:

Is it possible to get a more detailed error message? This leaves me clueless what i did wrong.
Kind Regards :)

@CleanCodeDeveloper I completely missed this issue, sorry about that! Are you still having this problem?
I do want to remind you that this project is still quite unstable & not documented at all. All the changes I made to it are only documented in the release notes.


Allow to pass a function for custom html rendering / templating

This pull request allows to pass a synchronous function to generate the templateContent.
Might also fix #7

This only fixes #7 insofar as you can do all the templating yourself using your own template engine instance (could be anything you like, not just blueimp). I'd still like a better fix for #7, but this is useful functionality in its own right.


low fps

I get lower fps, but I'm not sure why, I don't use any necessary fastflags.

Let me see your FastFlag configuration just to be sure.

max fps: 120
lightning technology: chosen by game
escape menu: default
hide GUIs: on
old materials: off
rendering mode: direct3D 11
21 graphics quality selector: off

What's your average framerate with and without?

90-120

but i dont know why i get lower fps when lauching the game from the browser

Answer the question, I want to get an idea of how much performance you're actually losing, and if it's even caused by Bloxstrap which I doubt it is.

Answer the question, I want to get an idea of how much performance you're actually losing, and if it's even caused by Bloxstrap which I doubt it is.

okay, 5 mins

when i have these all of 'em off then i get 140-200 fps on 5 graphic bar and 130-150 with full graphic quality.
and with direct3d 11 i get 90-140

Only happens when you change your rendering mode to Direct3D?

idrk, i issued that camera delay bug so now idk if this causes, but yes, mostly it takes my fps down

Roblox should always be using Direct3D 11 by default if your rendering mode is set to automatic. Set it to automatic again, launch Roblox, and send me the latest log file from %localappdata%\Roblox\logs.

0.586.0.5860000_20230722T121235Z_Player_F5876_last.log

And you're absolutely sure there's a difference in framerates between force-enabling Direct3D 11 and having it automatically chosen?

yes, but idk why but now i have 60-80

does the fullscreen optimizations give more fps after enabling that in?

i'll try the force again

Anyway, I'll close this since it's clear by now that this isn't a problem with Bloxstrap.

it fixed, it was because roblox didnt closed


Flows destruction

Now it is possible to delete resources created by flow replica

This change is

@istalker2 PTAL

Answered to some of your comments. PTAL

I did my best to address all of the issues pointed above. PTAL

As for the tests - I'm working on it. But I planned to do this in separate PRs. So there are 3 options:

Not to merge this PR now and instead wait for PRs with tests and then review them together
Approve this PR since it is in separate branch but do not merge the branch with master until there are tests
Leave this PR as is and then, later, to add tests to this PR. The problem with this approach is that it is not always clear which tests belong to which PR and there were already number of PRs without tests merged. So if I put tests here there are going to be tests that are not directly related to this PR. Also this will further increase the complexity of PR
So my suggestion is to go with option 2 and if you have any questions I'll be more than happy to answer


Roadmap

[x] eslint-config-airbnb
[x] bump dependencies
rewrite package.js using promise
upgrade to electron-packager v5.x and --all (synchronous, more slow)
[x] tests with babel-register (#29)
[x] simplify webpack configs
[x] use electron-prebuilt version for packaging (#33)
yeoman generator (clone from github instead)
[x] babel-plugin-react-transform (#44)
[x] react, react-dom v0.14
[x] react-router v1.0 (waiting for release)
[x] redux?
[x] E2E test case
[x] 0.35.x change
[x] use es2015 syntax which enabled in node 4
[x] remove chrome devtools in production
[ ] auto updater - see https://github.com/atom/electron/issues/1479
[x] babel 6 (wait https://github.com/gaearon/babel-plugin-react-transform/pull/50)
[x] react-router 2
[x] Advanced electron-packager settings
[x] babel-react-optimize (#238)
[x] electron-builder

Wait Upstream

[x] support react devtools when atom/electron#915 fixed
[x] change target when https://github.com/webpack/webpack/pull/1467 ship in new release (now only in webpack 2.x).

Investigate

[ ] webpack2
[ ] electron-updater
[ ] electron-compile
electron-dl

Redux.

redux +1

Add E2E test cases? :D
Refer using-selenium-and-webdriver.md, and this commit (released by 0.33.7), so we can start main process by chromedriver.
These work well in my private projects.

@jhen0409 definitely have interest in this. I will add some redux stuffs after React 0.14-compatible react-redux and react-devtools released. Are you willing to make a PR at that moment?

@chentsulin yes, I will. :)

redux +1

redux +1

redux is done, but babel 6 not.

babel is done by now :)

@chentsulin can we release 0.11.0?

Sure. And we should document significant changes between 0.10 and 0.11 in CHANGELOG.

Closing this in favor of https://github.com/chentsulin/electron-react-boilerplate/issues/504


⚠ Unifi Controller has degraded performance

In a964377, Unifi Controller (https://unifi.vflits.com/) experienced degraded performance:

HTTP code: 200
Response time: 2890 ms

Resolved: Unifi Controller performance has improved in 8dcaf6d after 22 minutes.


Improve retrieval of sub in JWT token issuance

Describe the issue:
When the JWT token type is configured for the OAuth SP, several repetitive queries are made to IDP tables, specifically the queries below.

SELECT A.NAME, B.NAME, B.DISPLAY_NAME FROM IDP A JOIN IDP_AUTHENTICATOR B ON A.ID = B.IDP_ID WHERE B.ID =? AND ((A.TENANT_ID =? AND B.TENANT_ID =?) OR  (A.TENANT_ID=? AND A.NAME LIKE 'SHARED_%' AND B.TENANT_ID=?))
SELECT IS_FEDERATION_HUB FROM IDP WHERE NAME = ? AND TENANT_ID = ?

This happens when the service provider object is retrieved to build the sub [1][2]. During the process,

IDP information of all the IDPs configured for the step will be retrieved [3], which includes executing the query (1) separately for all the authenticators.
All the IDP objects will be created, which includes executing the query (2) above separately for each IDP.

This impacts the performance when there are multiple IDPs configured for each SP when the cache is expired.
Hence, this should be fixed to retrieve the subject without retrieving the whole service provider object.
How to reproduce:

Configure an OAuth SP with JWT token type.
Observe the method invocations in the client credentials grant type (and should be fixed for other applicable grant types).

[1] https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/master/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/JWTTokenIssuer.java#L474
[2] https://github.com/wso2/carbon-identity-framework/blob/v5.17.5/components/application-mgt/org.wso2.carbon.identity.application.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/CacheBackedApplicationDAO.java#L88
[3] https://github.com/wso2-support/carbon-identity-framework/blob/support-5.17.5.x-full/components/application-mgt/org.wso2.carbon.identity.application.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java#L2643

For client credentials grant type, the correct fix is simple.
The 'sub' should be the client_id of the application :)
@SujanSanjula96 has fixed this in https://github.com/wso2/product-is/issues/14771. But this would mean a behaviour change too (So it's done with a configuration to preserve the backward compatibility. But ideally its not necessary).


HDDS-7995. Support incremental snapshot on OM

What changes were proposed in this pull request?
Since the original PR is mixed with both OM and SCM, this is split from https://issues.apache.org/jira/browse/HDDS-6510 for better review.

Unify the RDB snapshot provider for both OM and SCM
Support the incremental snapshot/checkpoint
(could support Recon in the future, since Recon delta download which gets updates from WAL is also not stable)

The design doc:
https://docs.google.com/document/d/1tcZA4p8u0I52IpN80XIlABZrSmn9dRiGw4fpEBhi2pg/edit#heading=h.lwha5swobgc3
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7995
How was this patch tested?
UT

Looks like a great to have to improve performance and potentially improve stability.
@duongkame have you noticed rocksdb snapshot installation issue when you did the scale test?
Maybe also worth noting that we recently removed the unecessary compression for rocksdb snapshot so hopefully that reduces transmission overhead. (https://issues.apache.org/jira/browse/HDDS-7625)

@prashantpogde @smengcl This PR of @Xushaohong 's appears to do most of the work necessary to support the incremental bootstrapping of OmSnapshots .
It only requires about another 375 lines of changes, (excluding tests), to add incremental omSnapshots:
https://github.com/Xushaohong/ozone/compare/HDDS-7995...GeorgeJahad:ozone:incrementalBootstrap?w=1
Note, I've left my tests out of that branch so you can see how little needs to be added to get our functionality.  My new tests are here:  https://github.com/GeorgeJahad/ozone/pull/16/files  I need to clean those up and and add  more, but I've done enough to convince myself that my changes on top of this PR provide a solid solution for our needs.
Thus my recommendation is that we use this PR as the basis for the incremental snapshots.  Then I'll add mine on top of it to add our functionality along with more tests.

How hard would it be to add a doPost ?  (I ask because with the my omSnapshot changes, the exclude list might get too large to be a url parameter.)

How hard would it be to add a doPost ? (I ask because with the my omSnapshot changes, the exclude list might get too large to be a url parameter.)

The work is not hard. I think it is better to make POST become a second PR which is more concise and helps the reviewer understand.
Will do it after this.

@Xushaohong , thanks for working on this.  The overall logic looks good.

Thanks @ChenSammi for the review. I have fixed the comments with the new commit. PTAL

Thanks @Xushaohong , the last patch LGTM, +1.

Thx @ChenSammi and @GeorgeJahad  for the review!


Revert "Set graffiti to max 32 characters"

Reverts dappnode/DAppNodePackage-lighthouse#17

But why?

But why?

It's a network wide limit and the container will fail and go into s restart loop if it's exceeded so we have to limit it. The limit was first set in a bypasssble way a long time ago. Then support cases roll in or people with looping clients and all were graffiti being over the limit. Truncated it and it works.


Invocable icons

This PR adds an SVG Icon and sets it use as the icon when one of the invocable methods are used in the Flow Builder canvas.
Example:

Will do, would have had to redo anyway 😅


JSON text/plain

Seems that "Post JSON" don't work. Because if body is string (and JSON is actually a string) polyfill sets header 'content-type' to 'text/plain;charset=UTF-8'
But in docs:
fetch('/users', {
  method: 'POST',
  headers: {
    'Accept': 'application/json',
    'Content-Type': 'application/json'
  },
  body: JSON.stringify({
    name: 'Hubot',
    login: 'hubot',
  })
})

@shapkarin What exactly about posting JSON doesn't work? Our example suggests that you need to explicitly state content-type via header, because as you've noticed, the default content-type will not be correct for JSON.
If you're using our example code exactly as written, then please post the browser and the exception that you're getting. If you are experiencing failures in your own code, then please post example of that code.

Hello , Same here the server didn't get the json body
fetch('/main/newuser',{             method:'post',             headers: {                 'Accept': 'application/json',                 'Content-Type': 'application/json',             },             body:JSON.stringify({username:'test',password:'test'})         }).then((response)=>{             if(response.status >= 200 && response.status < 300){                 return response;             }else{                 var error = new Error(response.statusText);                 error.response = response;                 throw error;             }         }).then((response)=>{             return response.json();         }).then((data)=>{             /* Process data */         }).catch((error)=>{             /* Catch Error */         });

code
const options = {
  mode: 'no-cors', // just adds that
  method: 'POST',
  headers: {
    'Accept': 'application/json',
    'Content-Type': 'application/json'
  },
  body: JSON.stringify(post_body),
};

const test = async () => {
  let resp = await fetch(__url_guest, options);
  console.log(resp);
};
test();

console says
POST http://bmp.megafon.tv/api/v1/auth/register/guest 415 (Unsupported Media Type)

headers in request
content-type:text/plain;charset=UTF-8

You seem to be sending a POST to another domain. Please familiarize yourself with CORS to learn what's blocking you from changing the Content-Type of the request.

@mislav sorry, that was a server configuration problem. Fetch is great  :-)


Change behaviour of Storage.Move to overwrite existing by default

Coming from https://github.com/ppy/osu/actions/runs/5948760882/job/16133189924, the only way I can see this happening is if the underlying File.Move logic is less atomic than we expect it to be.
In the process of looking into this, I noticed there's an overwrite flag available for File.Move which tends to prefer a rename operation internally on unix, rather than link.
On windows (the failcase in question) it likely won't help at the end of the day.
Anyway, personally I think having it overwrite by default is what we prefer from our API. If that isn't agreed on then closing this without further consideration is fine.

I weakly agree with this. The other option is to do as .NET does and add an overload.


[SPARK-42489][BUILD] Upgrdae scala-parser-combinators from 2.1.1 to 2.2.0

What changes were proposed in this pull request?
This pr aims upgrade scala-parser-combinators from from 2.1.1 to 2.2.0.
Why are the changes needed?
https://github.com/scala/scala-parser-combinators/pull/496 add NoSuccess.I to helps users avoid exhaustiveness warnings in their pattern matches, especially on Scala 2.13 and 3. The full release note as follows:

https://github.com/scala/scala-parser-combinators/releases/tag/v2.2.0

Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

test first

Merged to master


updated ftd version in cargo

updated ftd version at which comments functionality are removed for body and caption

We don't need this anymore. ftd is updated to latest version.


Free lyrics

📦 Extension name
No response
📝 Provide a description of the new feature
So spotify started making so only premium users could use lyrics.
I hate that they did this. may u add lyrics to it please?
➕ Additional Information
No response

duplicate of https://github.com/rxri/spicetify-extensions/issues/1


Implement cfg-based target-specific dependencies

This commit is an implementation of [RFC 1361][rfc] which is an extension of
Cargo's target section in Cargo.toml to allow the use of #[cfg]-like
expressions for target-specific dependencies. Now that the compiler has been
extended with --print cfg each invocation of Cargo will scrape this output and
learn about the relevant #[cfg] directives in play for the target being
compiled. Cargo will then use these directives to decide whether a dependency
should be activated or not.
This should allow definition of dependencies along the lines of:
[target.'cfg(unix)'.dependencies]
[target.'cfg(target_os = "linux")'.dependencies]
[target.'cfg(windows)'.dependencies]

Which is much more ergonomic and robust than listing all the triples out!

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

Note that this will require https://github.com/rust-lang/rust/pull/31278 to land first to get the CI/tests to pass, but I figured I'd at least put this up for review?
r? @brson or @wycats

This will be great. Maybe we can knock winapi off the most popular crates list!

This only supports a subset of Rust's attribute syntax. In particular, it doesn't support the 'list' meta item type, instead hardcoding 'all', 'not', and 'any'. ISTM that we should keep them at parity and support the same grammar in both places.

Ah that's because right now Rust doesn't actually allow #[cfg] directives defined by the platform to take the form of list meta items. I believe the syntax accepted here is the same as any valid #[cfg] attribute in Rust.
Would you prefer that the grammar itself is represented the same way, though, and then there's a pass afterwards to make sure it's a valid meta item by parsing but error'ing on strings like foo(bar)?

:umbrella: The latest upstream changes (presumably #2370) made this pull request unmergeable. Please resolve the merge conflicts.

Two more notes I have since realized:

When using a newer Cargo with an older Compiler, we won't be able to learn about --print cfg, so these new kinds of target-specific dependencies won't work. Cargo will just always return false indicating that the dependencies are not applicable, but there's also in theory room to do something like emit a warning.
Various #[cfg] lines sometimes get out of hand and are split across multiple lines, but the syntax here does not support that. TOML only allows keys to be defined on one line.

:umbrella: The latest upstream changes (presumably #2387) made this pull request unmergeable. Please resolve the merge conflicts.

@bors r+

:pushpin: Commit f5d786e has been approved by brson

:hourglass: Testing commit f5d786e with merge 4739ba1...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64

Would of been nice if this syntax was supported on all of the options...
Example:
[workspace.'cfg(target_os = "linux")']
#...

# Example for the Cargo.toml present in the Rust source "rust/src/Cargo.toml"
[profile.release.'cfg(windows)']
opt-level = 2

[dependencies.'cfg(windows)']
winapi = "0.2"

[dev-dependencies.'cfg(target_os = "linux")']
libfuzzer-sys = { git = "https://github.com/rust-fuzz/libfuzzer-sys.git" }


feat(runtime): add setup option for agnostic runtime support

By moving the runtime to a config option which is set during setup the
runtime parameter is not necessary anymore for each LSP cmd.
Closes #84
Also rename the global configuration variable to something plugin
related to make it obvious which plugin is responsible for that variable
and to avoid possible name collisions.

Should the networking mode be also contained as an setup variable? When we then create the docker/podman command the network parameter could just be a boolean to switch between none and the mode passed during setup.

To be included in #92


Configure proxy support through BundleDeployment

This issue is to mimic the behaviour of OLM v0 in OCP. In OLM v0, admins can override the proxy settings for an operator inherited from cluster through "Subscription" API. OLMv1 needs to allow the same, through BundleDeployments.
More info on how it works in v0: https://docs.openshift.com/container-platform/4.9/operators/admin/olm-configuring-proxy-support.html#olm-overriding-proxy-settings_olm-configuring-proxy-support

We will most likely solve this with templating and the ability to retrieve data from in-cluster objects for use in templates.


Koa: Improvements

Fix: Router method Promise should be returned so Koa middleware pipeline can properly await it.

Codecov Report

Merging #194 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   89.34%   89.34%
=======================================
  Files          57       57
  Lines        2459     2459
  Branches      304      304
=======================================
  Hits         2197     2197
  Misses        260      260
  Partials        2        2

Impacted Files
Coverage Δ

packages/koa/src/index.ts
91.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fa4e2...f81e3b0. Read the comment docs.


change README to point at our new repo

Signed-off-by: Gregory Meno<EMAIL_ADDRESS>@dmick @ktdreyer

LGTM

so, there's no value in the removed text, even in some secondary file pointed to by readme?...


[Feature] 是否可以实现多个Tracing链路信息合成

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
OpenTracing中最大单位是单个链路,但是像一些工作流或状态机这类的操作往往都是多个链路组合,如果想组合起来观测这种流转状态,除了在链路上标记业务的key,还有别的实现将多个tracing组合成简单直观数据流的方式吗?类似工作流中的办理日志这类,不过是办理链路的日志这样
Use case
No response
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

If you need Chinese discussion, go to slack CN channel.


[Unity][CI] setup CI (do not upstream to main)

Set up CI to run Relax tests.

@YuchenJin because you're always launching the instances and then exitting, you'd incur the minimum charge of 60 seconds for the instances you're running even if you don't use any of the compute - might be better to turn off the builds in github somewhere?

@YuchenJin because you're always launching the instances and then exiting, you'd incur the minimum charge of 60 seconds for the instances you're running even if you don't use any of the compute - might be better to turn off the builds in github somewhere?

Thanks for the suggestion! The main reason for adding exit 0 to a bunch of scripts is to avoid the complication when rebasing against the main branch, and we don't need to modify the jenkins while reusing the current tvm jenkins ci setting.
Would love to hear others' thoughts: @driazati @areusch

Thanks for the suggestions. https://github.com/apache/tvm/pull/13910 should achieve the asks that leverages a customized jenkins setup and skip most of the existing pipelines without starting a stage

#13910 should achieve the asks that leverages a customized jenkins setup and skip most of the existing pipelines without starting a stage

Thanks!


A Small Typo

Fixed a little typo in the preface.
'they should be be entitled' -> 'they should be entitled'

Thanks!


Cannot upgrade BC140 C\AL database to AL BC150 due to destructive changes

We have converted our solution (with lots of changes in standard NAV objects) from C\AL to AL.
We then merged the converted objects with the new BC150 base application objects and resolved all errors. We have successfully build the new base application app.
We followed the guide  to upgrade our BC140 database but stranded on Task 6: Synchronize the tenant.
When running step 2, Synchronize the tenant with the application database, we get the error Sync-NAVTenant : The schema synchronization may result in deleted data. The following destructive changes were detected:
and then a list of all tables!
How can we resolve this?

AL Extension Version: 4.0.199169
Server Version: 15.0.36117

This repository is dedicated to bug reports for the latest preview version of the AL compiler and developer tools.
To get help for your question please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group

Hi Alexandru,
This is clearly an upgrade problem caused by Microsoft.
Doesn’t the upgrade fall under the developers tools?
Kind regards,
Robert de Roos
Developer/Consultant
[K3 Business Technologies logo for email signature]
m +31 628 200 721
t +31 152 516 555
www.k3btg.comhttp://www.k3btg.com/
From: Alexandru Toader<EMAIL_ADDRESS>Sent: dinsdag 3 december 2019 19:46
To: microsoft/AL<EMAIL_ADDRESS>Cc: Robert de Roos<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/AL] Cannot upgrade BC140 C\AL database to AL BC150 due to destructive changes (#5519)
This repository is dedicated to bug reports for the latest preview version of the AL compiler and developer tools.
To get help for your question please use one of the following resources:
Business Central Communityhttps://community.dynamics.com/business/f/758
mibuso forumhttps://forum.mibuso.com/categories/nav-three-tier
Dynamics User Grouphttps://dynamicsuser.net/nav/f/developers
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/AL/issues/5519?email_source=notifications&email_token=AMK2GDB65TWM6LBK5B2TC23QW2SPLA5CNFSM4JU2GXPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2M27Y#issuecomment-561302911, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMK2GDAD4VKSZH5U5PBSYTTQW2SPLANCNFSM4JU2GXPA.
Click herehttp://www.k3btg.com/privacy-policy/ to view our privacy policy.


[2.0.1-Request] Add image support in quote sections

Adding support for images inside the quote sections would help display different styles of content.
Thanks

Hmm, I've never used an image in a blockquote. Perhaps you're thinking of using something more akin to a figure? In either case, we leave it up to you to expand the base styles to support additional types of content within those elements.


i have triedto load app on my firebase realtime db but it's showing someone else database

I was trying to generate app for personal use, i have successfully copy pasted json file but its creating new user in somewhere else's database, and can't connect my db to this project

Obviously, only the owner of the app will have access to the app's database.

sorry firebase jason file was not pasted properly, there was new and old
both files were combined that's why it was making issue
On Fri, 3 Dec 2021 at 07:27, Udit Bhaskar @.***> wrote:

Obviously, only the owner of the app will have access to the app's
database.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/uditbhaskar/Whizzz-The-ChatApp/issues/11#issuecomment-985150361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATLS5XKONBQMVCA5XQZOQXLUPAPZBANCNFSM5HRBLJEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


php->pcre->preg_replace function added.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

php preg_replace function added


Fix docker files and env to work with podman-compose in rootless mode

Hi,
This is small fixes to let people use podman-compose instead of docker... This should be compatible with Docker also... I haven't tested it though...
Regards,
David.

I jus ttested now on Docker and it worked fine for both prd and dev. I'll merge this in. Thanks !

No problem ;-)


How do handle slider inside the ng-repeat with undefined or null values?

Hi
I am a beginner in AngularJS and trying to implement the Range slider for a scenario in my application and I am facing the following scenario shown in the below fiddle.
http://jsfiddle.net/Karthik9836/ed7cvfwc/
The API response returned as a collection, would give me the all the MIN, MAX, FLOOR, CEIL values for each and every range slider. How do I handle scenarios where the API response for MIN, FLOOR values returned from API as either undefined or null cases. I can't change the API response, I need to handle at the my UI end.
Thanks in advance.

Undefined and null values are invalid for this slider, you need to sanitize the values before remdering them as sliders.
The library set default values to floor and ceil when they are null: floor is set to 0 and ceil is set to the max value between model and high attributes.

Okay. Thank you for the quick response. Let me sanitize my response.


Updated TFL to current API link.

The Transport for London API link was pointing to a legacy page - I updated to the current valid page.

Thank u for update!


Remove workarounds for missing jackson dependency in core

With #2354 we finally have jackson available in core so we can get rid of a few warts like GraphHopperConfigMixIn or JSON handling in GraphHopperManaged

This is somewhat 'sketchy territory', because often it leads to the question what the core module really is about. For example should parsing config.yml (GraphHopperConfigMixIn) be part of the core? Or is this a feature of the 'webapp' (web-bundle)? Is the GraphHopper class an application in and of itself or is there only really one (web) application/server (which uses Dropwizard and config.yml as configuration?).
I think I will start with this JsonFeatureCollection constructor parameter, because this is very similar to what we need for custom areas.

Thanks! Just want to say I appreciate both you going forward and your level of architectural caution here. ,-)

Yes, I think core should be 'allowed' to use Jackson to read GeoJSON (just generally), but e.g. the GraphHopperConfigMixIn that is solely used to read the GraphHopperConfig from config.yml is rather not a part of core.

Of course, most of that discussion would be conveniently over if the JRE just had JSON internally.


[Bug]: currency field on alpaca.broker.journal.Journal object should be Optional

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When we fetch journals from the API via get_journal_by_id, parsing them into Journal objects fails with a ValidationError
1 validation error for Journal
currency
  field required (type=value_error.missing)

Expected Behavior
currency should be optional or it should default to USD, which is what the docs indicate None represents.
SDK Version I encountered this issue in
0.8.1
Steps To Reproduce
Fetch a journal and parse it into a `Journal` object

Filled out the Steps to Reproduce section?

[X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?
No response

Closed due to no further response from user


Enhance select component keyboard guidance

Suggestion from a recent Accessibility Audit.
Add content to explain how a select should operate via keyboard and with a screenreader.
Dig suggestion from discussion: "Some users may expand the select, some may use keyboard arrows in collapsed state. Sometimes select can erroneously submit if user presses an arrow key to change the value, it should not." (Look into this, particularly for filters).

Done some investigation and I'm not sure we should add further guidance on exactly how a select should work via keyboard, since the behaviour is based on the device's operating system and the select is a native input – it works differently on different devices/OS.
A good overview: https://www.24a11y.com/2019/select-your-poison/


Istio fails to come up in a windows cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Have a cluster - with 1 Ubuntu 18.04 Linux node - all roles and Windows 2019 worker node
Enable Istio

Expected Result:
Istio should get deployed successfully
Actual result:
Istio fails to come up.
Error - 0/2 nodes are available: 1 Insufficient cpu, 1 node(s) didn't match node selector.

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancher:master
Installation option (single install/HA): single

Our experience shown us it was not yes possible to get Istio working fine with bare metal mixed nodes k8s. But as soon we were removing our Windows nodes everything was getting setup correctly.
Moverover, Istio proxy, Envoy, doesn't fully support windows yet (see one of the latest reply to envoy issue 129)
So in summary it has nothing to do with Rancher

There is a typo in the PR; I left a comment in the PR.

Version: master-head (v2.3) (8/29/19)
There is now a simple message in the UI when you visit the Istio config page:

I also checked Pipelines (I saw this in the PR):

I did not identify any issues while testing.


test-recorder-callback

:tada: This PR is included in version 5.12.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: [245] Update user signup success and error messages

after a suer signs up successfully, they will see a toast  and message on the login page they are navigated to saying to check their email.
to test:

go to the sign up page
sign up
see the toast and message on the login page when redirected

This works, something else that could improve the user flow is disabling the sign up button after it is clicked and adding some sort of indictor (ex: verifying, signing up, etc)


Animate BT Net's swaying

https://github.com/pixequil/oso-game-1/assets/49569238/3706c238-1e56-49b5-ad09-eaa0cccca765
Fixes #97

seems a bit too gentle? what do other people think?

seems a bit too gentle

well, yes, it's swaying. It shouldn't be too extreme because it will be too weird.

that makes sense. i mostly brought this up because I thought of it as an equivalent to the violent bouncing that Security Cameron does when speaking. since it feels a little weird that in the game's opening scene, only one of the characters animates while speaking.

Oh yeah, actually, I can animate him talking too.

https://github.com/pixequil/oso-game-1/assets/49569238/a2743308-6b25-4e37-b378-4c0844477671

i don't think all of the mouthless characters should use this same animation. which is why i proposed swaying in the place of this, since this is a character whose object is known for being moved in an arc

Ahh, okay

https://github.com/pixequil/oso-game-1/assets/49569238/e80995a0-5173-42b9-b72a-082d9c946700

well now that it's like this, i feel like the inactive sway needs to either be way gentler or be gone, otherwise it's like btnet started talking while posty was talking


Responsive behavior of filter chips

Revisit how filter chips in the second row of a toolbar should respond when the viewport shrinks. In the current React implementation, ChipGroups will just wrap below the toolbar. While this approach works, would be good to identify an approach that uses less vertical space.
Design investigation needed.

@rachael-phillips @LHinson I opened this following a review of DataToolbar behavior with @nicolethoen We agreed that this is something that should be refined in a future release. Can we get this into the next milestone (or soon after)? I don't see this as a large effort.

@mcarrano I'll put it on the list to discuss for planning

This document includes an analysis of current differences between core and React implementations and a proposed path forward: https://docs.google.com/document/d/1sJrXtLaFtazsfQ1uhmBakP6mCFjCnjFTka589DiEe0Y/edit?usp=sharing

There is a PR up here that includes these changes: https://github.com/patternfly/patternfly-next/pull/2342


Add quality control

I've been thinking about this for a while. It would be nice to have a minimal app to quickly do quality control on single segmented image or more importantly for lengthy folders. I remember using SCT's quality control script a year ago, which implemented a browser-based solution if I recall correctly. This is ideal from a cross-platform point of view.
This also ties in with previous discussions where we concluded that it could be interesting to offer an alternative to fsleyes as a GUI, so if it works well, it could be used for a graphical interface to ADS as well.
My suggestion is to implement a browser-based solution. The user would call a axondeepseg_qc script which would start a server, then prompt to open a localhost:portno in the browser.
I've been researching this a bit and I think web-assembly (WASM) would be a great candidate. WASM was conceived to complete javascript's functionalities in an attempt to bring high-performance applications to the web. The concept is that you write your code in a low-level language (like C/C++ or, more interestingly, in Rust) and chose wasm as a compilation target. The browser acts as a level of abstraction over the operating system, but the application runs at native speeds. Nowadays, wasm is supported by practically all browsers. The fact that it allows for high-performance web apps is what makes me think it could also work as an alternative for ADS (also, browsers can use GPUs).
I will do some testing on my side to check how easy it would be to implement and interface with python code. One question I have is this: for maintainability, would it cause a problem to use another language than python for this? I will say I have my eyes on Rust (pretty much the fastest growing language out there right now), but maybe C++ would be preferable for students in the future. For Rust, the yew project (https://yew.rs/) grabbed my attention. You write your application in Rust and then compile it for WASM. I'm not exactly sure but I think we could essentially release a wasm binary executable, then call it through a python script like the other scripts. This executable would work across every OS since its executed by the browser.
edit: Also, on another note, the "most maintainable" solution for this would be to hire a computer science student with frontend experience to build some kind of pretty electron app, because unfortunately, the JavaScript ecosystem is much more mature for this sort of stuff. Also, folks in génie logiciel/info at poly learn that stuff pretty early on if I recall correctly.

related to https://github.com/axondeepseg/axondeepseg/issues/404

I tried yew.rs and its pretty good but it's not production ready. We'll see how it goes.
Obviously, for QC alone (not ADS GUI), the simpler way would be a script producing a html file, just like SCT: https://spinalcordtoolbox.com/overview/concepts/inspecting-results-qc-fsleyes.html. We could have a new axondeepseg_qc  script to generate an interactive html file from the current directory. It makes sense to me to have a separate interface for these kinds of "reports", although it would be nice to have it consolidated with the ADS GUI. Also, much simpler to implement.

Would be great if the QC listed potential outliers to be cleaned up, likely from the morphometrics (eg too small myelin or axon area, non-realistic g-ratio, etc), and/or "incomplete" axons (when there's areas within the closed boundary of the myelin that isn't labeled as axon.

Generating a mask of these potential outliers might make it quicker to "clean up" the images (i.e. could remove potential outliers, and then just subtract the mask from the full segmentation.

This issue is close to #760 and it's PR #781, however I think it's distinct being that the idea would  be to generate a report for many images, correct? Somewhat like what is done with SCT. I'll leave this open, but rename to specify report


Module not found: Error: Cannot resolve module 'net' in /../../node_modules/ip-range-generator

I don't see 'net' package added in package.json. It's complaining for 'module not found'

There are no external dependencies, net is a built-in module in node. Are you using a module bundler like webpack or browserify ? Webpack requires some configuration in order to work with node modules.

Yes, I am using a module bundler 'webpack'.
It is still complaining about
Module not found: Error: Cannot resolve module 'net' in /<uesr_dir>/<product_dir>/node_modules/ip-range-generator

Actually webpack doesn't have any polyfill for the net module. I changed for a regex-based validation of IPs, now it should bundle without problems.

Great!
Thanks. I will re-install it.


chore(autorest): bump to 3.7.1

Description
Bump autorest in generator to 3.7.1, since azure-sdk-for-net is already using 3.7.1 in CI.
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Preview PR: https://github.com/Azure/azure-sdk-for-net/pull/41660
There is no code change.


[Dart 2.0] dart2js compiled Angular app does not report strong-mode type error

Summary
A Dart 2.0.0-dev.8.0 dartdevc compiled Angular app raises a type error when an int is assigned to a(n implicitly) String typed field. The same app compiled with dart2js runs fine without any type errors being reported.
I'm unsure if this is due to a problem with Angular, dart2js and/or the dartdevc. I think it might be due to dart2js, so I'll start by opening the issue here.
Details
The issue occurs for the Angular two-way binding example (live example, description). The example's root app class contains the following field declaration:
  var /*String|int*/ fontSizePx = '16';

This field is used in the app template as follows:
  <my-sizer [(size)]="fontSizePx" #mySizer></my-sizer>

In the two-way binding [(size)]="fontSizePx", when size changes inside my-sizer, the updated int value gets assigned to fontSizePx.
Under Dart 1.x non-strong mode, this didn't cause any problems because fontSizePx was interpreted as dynamic.
It is my understanding that under Dart 2.0, fontSizePx has static type String (so I will need to change the declaration from var to dynamic if the app is to run properly under strong mode). But my point is that the ddc-compiled app reports the type error, but the dart2js-compiled app does not.
I'm assuming that apps compiled with one or the other should have the same behavior.
Repro

Download a zip of the site-webdev project from the 5-dev branch@7381e7792c
Unzip
cd to the repo root.
cd examples/ng/doc/template-syntax
pub get

To see the type error:

pub serve --web-compiler=dartdevc
Open Chrome at localhost:8080/#two-way
In Chrome, open the JS console.
Click either the [+] or [-] buttons just below the "Two-way Binding" heading.

You should see the following in the console:
EXCEPTION: Type 'int' is not a subtype of type 'String' in strong mode

with a reference to this line of code:
[_handle_sizeChange_381_0]($event) {
  this.ctx.fontSizePx = core.String._check($event);
}

Repeat the steps above but for pub serve and no error will be reported.
cc @matanlurey @kwalrath @kevmoo

Btw, @nshahan, this is the same example app for which pub build --mode=debug sometimes hangs (https://github.com/dart-lang/angular_components/issues/198). I was going to fix the field type declaration to see if that solved the hanging build problem, but I can't get it to hang anymore :-/.

There is no strong mode in Dart2JS yet, which is why you don't get any errors.
Only DDC will give you those errors. I'm closing because I don't think there is any other action here other than using a different compiler to get errors and waiting for Dart 2.0 to release.

There is no strong mode in Dart2JS yet ...

Oh! For some reason I thought that there was.

I'm closing because I don't think there is any other action here other than using a different compiler to get errors and waiting for Dart 2.0 to release.

Yes, that makes sense; I'll use the ddc to debug strong mode errors.

Only DDC will give you those errors.

@kevmoo, @matanlurey: so, under Dart 2-dev, should we only test AngularDart example apps using the DDC? Said another way: is there any reason to run all tests twice (once using dart2js and once using DDC) given that dart2js doesn't implement strong mode?


Sum of dedicated time of a tracker type in the project

Hello, on ticket # 64 I have seen how to add all the dedicated hours of project tickets, but this is for all types of tickets:
time_entries.sum (: hours) .round (2)
Is there a way to do it with only one type of ticket?
Many thanks for the help

Hi. What is a type of ticket?

Tracker

time_entries.includes(:issue).where(issues: { tracker_id: YOUR_TRACKER_ID }).sum(:hours).round(2)

Ouuuuuyeaaaa!! Thanks!!!

Extensive information for the result to be in time format:
hours = time_entries.includes(:issue).where(issues:{YOUR_TRACKER_ID}).sum(:hours).round(2)
hours_part = hours.truncate
minutes = ((hours - hours_part) * 60).round
result = hours_part.to_s + ":" + minutes.to_s


Add Unit Tests and Update Notice Generation for MQTT Connector's Azure Function

This PR closes #25

This PR closes #16


Common Username Patterns?

I've been using the SecLists repository for a while now, and I think it's amazing.  Thank you to all the contributors for compiling this amazing resource into one place.
One thing that I have considered is that, with the Usernames directory, there's nothing on common usernames using common names/common username patterns for corporate email addresses and login details.
I have written a program that ingests the files in Usernames/Names and converts them into text files which contain each of the common username pattents (e.g. first+last, first+"."+last).
The resulting output from this program is a 161MB directory containing 2,000,000 text files (one for each name combination).
I'm unsure whether it is better to contribute the code to do this (written in Python 3.8) or the resulting export, as the data export is very large.

Feel free to open up a pull request.
Either all or say the top x amount.

How can i hack an Instagram account

How can i hack an Instagram account

Wrong place man


feat(share/byzantine): handle additional cases in befp validation

Overview
Extend a BEFP validation.
Related to https://github.com/celestiaorg/celestia-node/issues/2377
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2383 (b7a7ca0) into main (403eb61) will increase coverage by 0.20%.
The diff coverage is 54.43%.

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
+ Coverage   50.44%   50.64%   +0.20%
==========================================
  Files         155      156       +1
  Lines        9826     9876      +50
==========================================
+ Hits         4957     5002      +45
+ Misses       4433     4432       -1
- Partials      436      442       +6

Impacted Files
Coverage Δ

nodebuilder/node.go
58.57% <ø> (ø)

share/eds/byzantine/bad_encoding.go
34.40% <35.00%> (+1.37%)
:arrow_up:

libs/pidstore/pidstore.go
60.00% <60.00%> (ø)

cmd/celestia/rpc.go
16.16% <62.06%> (+6.16%)
:arrow_up:

... and 4 files with indirect coverage changes

These cases are possible with out-of-order shares. But we can't generate them for now

Moving this PR to draft until we can test these conditions


Export 'useId' (imported as 'React') was not found in 'react'

export 'useId' (imported as 'React') was not found in 'react'
when building app, webpack gives an error that there is no export useId in the module 'react'
here is bug in WebPack, from contributors material UI
in webpack issues 14814
in this comment trying gto fix them.

See #24, this library, and by extension react-konva, requires React 18 as a peer dependency.


What about docs?

Things to work on the documentation task:

[ ] #8
[ ] #7
[ ] #9
[ ] Decide if something more complex is required

Things to do:

[ ] Create a 'docs' folder
[ ] Create a new index.md document
[ ] Turn on GitHub Pages
[ ] Decide if something more complex is required

Created Issues for the first 3 things to do.


glib-networking: bump to 2.66.0

Changes

The openssl implementation on glib-networking has been rewritten. It now
depends on the OpenSSL TLS1.3 API, which is not fully implemented on libressl
yet. This leaves us only the choice to use GnuTLS for building glib-networking.
The dependency file is updated accordingly.

Installed manifest of package
(kiss manifest <pkg>)
/var/db/kiss/installed/glib-networking/version
/var/db/kiss/installed/glib-networking/sources
/var/db/kiss/installed/glib-networking/manifest
/var/db/kiss/installed/glib-networking/depends
/var/db/kiss/installed/glib-networking/checksums
/var/db/kiss/installed/glib-networking/build
/var/db/kiss/installed/glib-networking/
/var/db/kiss/installed/
/var/db/kiss/
/var/db/
/var/
/usr/lib/gio/modules/libgiognutls.so
/usr/lib/gio/modules/
/usr/lib/gio/
/usr/lib/
/usr/

Existing package

[x] I am the maintainer of this package.

Will merge but we should swap back to libressl when possible (client/server side tls 1.3 is done, only thing missing is openssl API for it).