Are we happy with FromHex usage of  Err?

Our FromHex trait has a trait method from_hex which has an associated error type Err. We used Err instead of Error, IIRC, because from_hex is close to from_str and FromStr uses Err.
I opened up the file today and was surprised to see Err not Error - thought I'd just check that, a few months on, we still think this was the correct decision? Not something we want to change after a 1.0 release.

I prefer Error. One specific advantage is editors will correctly highlight it.

I could go either way. Looks like serde uses Error so maybe we ought to copy them.

One bloke surprised, one with a preference, and one on the fence, that sounds like rough consensus to me, Error it is :)


UX/UI: inclusive design

It's important to respect that:
https://www.microsoft.com/design/inclusive/
Is it the correct link, @jdubois ?

Yes it is!
And currently the application isn't even responsive (doesn't work on my mobile), so there is probably some good work to do.
Have a look at what @roryp does, he's our top expert at Microsoft (and he's in my team!!). Maybe an opportunity to collaborate on accessibility?

Maybe you're interested about this issue @ascelineboullen

Closing in favor ofhttps://github.com/jhipster/jhipster-lite/issues/10576


Configurable white-list for 'non-climbable blocks' for spiders.

It would be very much apprecciated if other blocks (when configured to) could be not climbable.

added a fabrication:include_in_item_inventory_check block tag


Davidberenstein1957 batch support

https://hacktoberfest.com/participation/#pr-mr-details could you add your repo to Hacktoberfest please🤓

I can also create functions completely separate to facilitate batching and individual requests, but I felt this might be a bit invasive, given the current project structure.

@Lucaterre I updated the fork and added the feature issue. Could you add the "hacktoberfest"-label?

Is there anything I can do to help further?

Is there anything I can do to help further?

For now, could you document with an example your implementation of .pipe() in the readme and examine the tests that failed with this PR? I'll get back to you as soon as I have more time to review

It's really a great feature (which saves a lot of time on large batches) that I want to integrate into the future release! Can you review the minor code reviews I added? once that is done, it will be ready to merge this PR.

Everything seems OK to me for the review. Just before merging, in the Readme: 1) Can you just add a little description of the batch_size parameter in Batching example section and 2) an entry in the table of contents for the Batching example section (markdown link)...

Thank you again I will be able to upgrade to the new release now :+1:


dts: arm: Add #address-cells to nvic nodes

dtc v1.6.1 produces an error without specifying #address-cells on all interrupt-controller nodes. This commit only fixes this for nvic nodes in ARM architectures.
Fixes #36495
Signed-off-by: Eric Johnson<EMAIL_ADDRESS>

I read through the issue description but I still don't understand why we're going with 0 here, since the binding uses 1 in its example:
https://github.com/torvalds/linux/blob/4a09d388f2ab382f217a764e6a152b3f614246f6/Documentation/devicetree/bindings/interrupt-controller/arm%2Cnvic.txt#L27

I read through the issue description but I still don't understand why we're going with 0 here, since the binding uses 1 in its example:
https://github.com/torvalds/linux/blob/4a09d388f2ab382f217a764e6a152b3f614246f6/Documentation/devicetree/bindings/interrupt-controller/arm%2Cnvic.txt#L27

I used 0 because I did not see any occurrences of nvic nodes having children and to the best of my knowledge didn't know of a usage for child nodes with nvic. I think it is better to follow the example though and I can make that change.
Additionally there's a lot of interrupt-controllers that don't define #address-cells. Should that work be contained in a separate PR?

Additionally there's a lot of interrupt-controllers that don't define #address-cells. Should that work be contained in a separate PR?

I think so.


[$250] mWeb -Finder -User not scrolled to top of chats list when scrolling down and deleting search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5068088&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause - Internal Team
Action Performed:

Open the staging.new.expensify.com website
Log in to an account with a large list of chats
Tap on the search icon on the top right corner
Write a few letters to trigger some results
Scroll down to the middle of the results
Select all the content in the search input and delete it
Verify the chats list is updated and the user is navigated to the top of it

Expected Result:
After deleting the content in search input, the chats list should be updated and the user should be navigated to the top of it
Actual Result:
When writing a few letters to trigger a search, scrolling down to the middle of the results, selecting all the content on search input and deleting it, the chats list updated but the user is not redirected to the top. The list stays in the middle
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/bf95d924-c9f2-49e4-99eb-c0e986073338
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021846215092993792827
Upwork Job ID:<PHONE_NUMBER>993792827
Last Price Increase: 2024-10-15

Issue OwnerCurrent Issue Owner: @allgandalf

@CortneyOfstad  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Didn't realize this was Android — so having Stevie do some testing for me!

Confirmed that this was reproducible so getting eyes on it! S/O to @slafortune for her help!

Proposal
Please re-state the problem that we are trying to solve in this issue.
User not scrolled to top of chats list when scrolling down and deleting search
What is the root cause of that problem?
After deleting the search, scrolling to the top is not possible because newSelectedIndex returns -1 when textInputValue === '' (which occurs after the previous search is cleared).
https://github.com/Expensify/App/blob/7fca65bcd7d91dd2f77cfee0818d6bd3729639ce/src/components/SelectionList/BaseSelectionList.tsx#L568-L574
The function updateAndScrollToFocusedIndex receives this -1 and passes it to scrollToIndex. Inside scrollToIndex, there's a condition that checks if the index is -1. If true, it returns without performing the scroll, causing the issue
https://github.com/Expensify/App/blob/7fca65bcd7d91dd2f77cfee0818d6bd3729639ce/src/components/SelectionList/BaseSelectionList.tsx#L252-L254
What changes do you think we should make in order to solve the problem?
To resolve this issue, we need to check if textInputValue is empty after the search text is removed. If it is, we need to return to index === 0 to enable scrolling to the top.
- const newSelectedIndex =
-            textInputValue === '' || (flattenedSections.selectedOptions.length !== prevSelectedOptionsLength && prevAllOptionsLength === flattenedSections.allOptions.length) ? -1 : 0;
+ const newSelectedIndex =
+            (textInputValue === '' && !prevTextInputValue) || (flattenedSections.selectedOptions.length !== prevSelectedOptionsLength && prevAllOptionsLength === flattenedSections.allOptions.length) ? -1 : 0;

POC
https://github.com/user-attachments/assets/b5d5fa82-ed23-4885-94d8-59b1fefc7f82

I've tested the previous issue, and this condition still works well after the update

POC
https://github.com/user-attachments/assets/2d8dcd87-cbc4-40aa-a9e7-63b7d25a188f

Hey @stephanieelliott! I am heading OoO shortly (until 10/23) so reassigning to keep an eye on this! Thanks!

@allgandalf Could you please review my proposal? My solution simplifies the process by updating the condition to check if the index is 0 after the text search is cleared.

Back from OoO — thanks @stephanieelliott for holding down the fort while I was OoO!
@allgandalf looks like there was a response to your clarifying question here — any feedback?

Sounds good — thanks @allgandalf!

@allgandalf I checked the latest main chat-finder and it has been changed to search. I think this issue is outdated.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Scrolling down and deleting a search in mWeb-Finder no longer causes the user to remain at the top of the chats list.
What is the root cause of that problem?
This issue not only occurred on search but also on all components that use BaseSelectionList.
In this code
https://github.com/Expensify/App/blob/0647baf7b70967a707df6eae6cb4c3f5a260a8f5/src/components/SelectionList/BaseSelectionList.tsx#L575-L576
We remove scroll focus when the search input is empty.
What changes do you think we should make in order to solve the problem?
The original issue is no longer reproducible https://github.com/Expensify/App/issues/35665 even without that empty check
We can remove that empty check

        const newSelectedIndex = (flattenedSections.selectedOptions.length !== prevSelectedOptionsLength && prevAllOptionsLength === flattenedSections.allOptions.length) ? -1 : 0;

Or add isEmpty(prevTextInputValue)  if we need that in the initial render

        const newSelectedIndex =
            (isEmpty(prevTextInputValue) && textInputValue === '') || (flattenedSections.selectedOptions.length !== prevSelectedOptionsLength && prevAllOptionsLength === flattenedSections.allOptions.length) ? -1 : 0;

What alternative solutions did you explore? (Optional)
N/A

@allgandalf any updates on the proposals above?

Proposal Updated

Add result video and add new chat case
Add barnch
Implement similar change to SearchRouter

cc: @allgandalf

@allgandalf The PR is ready https://github.com/Expensify/App/pull/52606/ Thanks!

Thanks @Kicu! I see that the PR for this issue is already merged. I think we can make changes to the solution if needed though.

solution changed here: https://github.com/Expensify/App/pull/52568/files#diff-f8e8e46965e7e099296f3ec791faf7d61b208fb68dfff52e20e8d98483479a89R225
I included an android video showing that the bug is still fixed on my code

@allgandalf can you please complete the checklist at your earliest convenience?

Please note that I am going to be OoO on 11/29 due to Thanksgiving in the US, but I will get this paid as soon as I am back on Monday. Most of the team will be out, so I apologize for the delay!

Payment Summary
@wildan-m — paid $250 via Upwork
@allgandalf — paid $250 via Upwork
Regression Test
https://github.com/Expensify/Expensify/issues/449517


extdisco failed

ERROR fatal (in read loop): extdisco failed

This happens when the XMPP server does not support extdisco (used for discovering the details of the STUN/TURN server[s] for the Jitsi Meet instance).
We have already improved compatibility with such servers in latest master. Please check out the git repository and run from there. (e.g. git clone https://github.com/avstack/gst-meet; cd gst-meet; cargo run --release -- --web-socket-url=...)

This happens when the XMPP server does not support extdisco (used for discovering the details of the STUN/TURN server[s] for the Jitsi Meet instance).
We have already improved compatibility with such servers in latest master. Please check out the git repository and run from there. (e.g. git clone https://github.com/avstack/gst-meet; cd gst-meet; cargo run --release -- --web-socket-url=...)

Sorry, I didn't understand what you mean.
I compiled it very hard, using j WSL2.0 (Ubuntu18.04), what do your compilation parameters mean? Can you give me a little more guidance?

I think you used cargo install, which installs a released version (currently 0.2.2). However, this released version is not compatible with XMPP servers that do not support extdisco (like yours). Support for such XMPP servers has been added, but there has not been a new release made yet. Therefore, you should use the pre-release code directly from this Git repository. You can run it directly using the commands I gave above (add the rest of your gst-meet command line instead of ...).

yes, cargo install it.
I haven't been able to compile it successfully. Still dealing with various errors. Now these are

The error tells you clearly what the issue is (one of the last lines) — your gstreamer version is too old.

how to compile it easier with which one os ?
ubuntu?
centos?
debian?
redhat?
or?

how to compile it easier with which os ?
ubuntu?
centos?
debian?
redhat?
or?

It makes no difference which distribution of Linux you are using, because none of them package the prerelease gstreamer version used by our current development code yet. Once GStreamer 1.20 is released (should be a matter of weeks) there will be some binary packages available.
If you use nix, you can use our shell.nix which will build GStreamer for you.

is this nix?

You don't have to install the whole NixOS, only the tool Nix. You can use it on any Linux, or on Mac. Maybe on Windows too.
FYI we are working on a Dockerfile today

I want to send rtmp to jitsi, does it work with docker?

You don't have to install the whole NixOS, only the tool Nix. You can use it on any Linux, or on Mac. Maybe on Windows too.
FYI we are working on a Dockerfile today
What time zone are you in and are always online when asked.

Sure, RTMP is just a TCP socket, you can use Docker's networking features to get the traffic in and out as needed. You can learn how to use Docker features in the documentation.

nix-shell --pure can not compile it also.
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Configuring gstpluginsbaseversion.h using configuration
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Looking for a fallback subproject for the dependency (anonymous)
Automatic wrap-based subproject downloading is disabled
Subproject  gl-headers is buildable: NO (disabling)
Dependency (anonymous) from subproject gl-headers found: NO (subproject failed to configure)
Run-time dependency opengl found: YES 4.5
Run-time dependency glx found: YES 1.4
Run-time dependency glesv2 found: YES 1.3.4
Has header "GLES3/gl3.h" with dependency glesv2: YES
Has header "GLES3/gl3ext.h" with dependency glesv2: YES
Run-time dependency egl found: YES 1.3.4
Has header "EGL/egl.h" with dependency egl: YES
Has header "EGL/eglext.h" with dependency egl: YES
Has header "libdrm/drm_fourcc.h" : NO
Run-time dependency wayland-client found: YES 1.19.0
Run-time dependency wayland-cursor found: YES 1.19.0
Run-time dependency wayland-egl found: YES 18.1.0
Run-time dependency wayland-protocols found: YES 1.23
Program wayland-scanner found: YES (/nix/store/aqccrhr8yl2b4784illdwwl6dndwmn7x-wayland-1.19.0-bin/bin/wayland-scanner)
Run-time dependency x11-xcb found: YES 1.7.2
Checking for function "glXMakeCurrent" with dependency glx: YES
Library nvbuf_utils found: NO
Has header "nvbuf_utils.h" : NO
Checking for type "GLeglImageOES" with dependencies glesv2, opengl: YES
Checking for type "GLchar" with dependencies glesv2, opengl: YES
Checking for type "GLsizeiptr" with dependencies glesv2, opengl: YES
Checking for type "GLintptr" with dependencies glesv2, opengl: YES
Checking for type "GLsync" with dependencies glesv2, opengl: YES
Checking for type "GLuint64" with dependencies glesv2, opengl: YES
Checking for type "GLint64" with dependencies glesv2, opengl: YES
Checking for type "EGLAttrib" with dependencies glesv2, opengl, egl: YES
Checking for type "EGLuint64KHR" with dependencies glesv2, opengl, egl: YES
Configuring gstglconfig.h using configuration
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program gl_mkenum.py found: YES (/nix/store/5bh6rpya1ar6l49vrhx1rg58dsa42906-python3-3.9.6/bin/python3.9 /build/gst-plugins-base-1.19.3/gst-libs/gst/gl/gl_mkenum.py)
gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".
A full log can be found at /build/gst-plugins-base-1.19.3/build/meson-logs/meson-log.txt
builder for '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv' failed with exit code 1
error: build of '/nix/store/42wzrvdvpl5khjgi93c1ivbxqblj0i4f-libnice-0.1.18.drv', '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv', '/nix/store/a0dkanvf6xnvlzvxh8gigdybndfbkab3-gst-plugins-good-1.19.3.drv', '/nix/store/wsclrfp8xi6qy2bz4szk6d65hjhwhsyf-gst-plugins-bad-1.19.3.drv' failed
[nixos@nixos:~/gst-meet]$

gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".

Are you on Windows? We've never tested any of this on Windows, so I guess some changes would be needed to shell.nix. If you can get it to work please send a PR.

Sure, RTMP is just a TCP socket, you can use Docker's networking features to get the traffic in and out as needed. You can learn how to use Docker features in the documentation.

yes ,I know.
but the gst-meet don't have the command param demo it.

It's not the job of gst-meet documentation to teach the use of other tools like Docker. You can use the same commands as in the gst-meet examples, just run them within Docker.

gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".

Are you on Windows? We've never tested any of this on Windows, so I guess some changes would be needed to shell.nix. If you can get it to work please send a PR.

no, not the windows.
I  download the nix ios file, and run it directly by the vmware.  it's a new nixos.

hecking for function "glXMakeCurrent" with dependency glx: YES
Library nvbuf_utils found: NO
Has header "nvbuf_utils.h" : NO
Checking for type "GLeglImageOES" with dependencies glesv2, opengl: YES
Checking for type "GLchar" with dependencies glesv2, opengl: YES
Checking for type "GLsizeiptr" with dependencies glesv2, opengl: YES
Checking for type "GLintptr" with dependencies glesv2, opengl: YES
Checking for type "GLsync" with dependencies glesv2, opengl: YES
Checking for type "GLuint64" with dependencies glesv2, opengl: YES
Checking for type "GLint64" with dependencies glesv2, opengl: YES
Checking for type "EGLAttrib" with dependencies glesv2, opengl, egl: YES
Checking for type "EGLuint64KHR" with dependencies glesv2, opengl, egl: YES
Configuring gstglconfig.h using configuration
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program gl_mkenum.py found: YES (/nix/store/5bh6rpya1ar6l49vrhx1rg58dsa42906-python3-3.9.6/bin/python3.9 /build/gst-plugins-base-1.19.3/gst-libs/gst/gl/gl_mkenum.py)
gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".
A full log can be found at /build/gst-plugins-base-1.19.3/build/meson-logs/meson-log.txt
builder for '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv' failed with exit code 1
error: build of '/nix/store/42wzrvdvpl5khjgi93c1ivbxqblj0i4f-libnice-0.1.18.drv', '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv', '/nix/store/a0dkanvf6xnvlzvxh8gigdybndfbkab3-gst-plugins-good-1.19.3.drv', '/nix/store/wsclrfp8xi6qy2bz4szk6d65hjhwhsyf-gst-plugins-bad-1.19.3.drv' failed
[nixos@nixos:~/gst-meet]$ uname -a
Linux nixos 5.10.81 #1-NixOS SMP Sun Nov 21 12:46:37 UTC 2021 x86_64 GNU/Linux
[nixos@nixos:~/gst-meet]$

OK, sure. nix-shell --pure is working here. Please provide the whole output including the exact command you ran. Please use correct Markdown formatting to format it as code (i.e. ``` on a line before and after the output).

git clone ....
cd gst-meet
nix-shell --pure
just above

Please provide the whole output including the exact command you ran.

`[nixos@nixos:~/gst-meet]$ df -h
Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        800M     0  800M   0% /dev
tmpfs           7.9G     0  7.9G   0% /dev/shm
tmpfs           4.0G   11M  3.9G   1% /run
tmpfs           7.9G  456K  7.9G   1% /run/wrappers
tmpfs           7.9G   48M  7.8G   1% /
/dev/root       2.0G  2.0G     0 100% /iso
tmpfs           7.9G  1.1G  6.8G  14% /nix/.rw-store
overlay         7.9G  1.1G  6.8G  14% /nix/store
tmpfs           1.6G   72K  1.6G   1% /run/user/1000
[nixos@nixos:~/gst-meet]$ ls
Cargo.lock  Cargo.toml  deny.toml  Dockerfile  gst-meet  lib-gst-meet  lib-gst-meet-c  LICENSE-APACHE  LICENSE-MIT  nice-gst-meet  nice-gst-meet-sys  README.md  rustfmt.toml  shell.nix  xmpp-parsers
[nixos@nixos:~/gst-meet]$ nix-shell --pure
these derivations will be built:
/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv
/nix/store/42wzrvdvpl5khjgi93c1ivbxqblj0i4f-libnice-0.1.18.drv
/nix/store/a0dkanvf6xnvlzvxh8gigdybndfbkab3-gst-plugins-good-1.19.3.drv
/nix/store/wsclrfp8xi6qy2bz4szk6d65hjhwhsyf-gst-plugins-bad-1.19.3.drv
building '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv'...
unpacking sources
unpacking source archive /nix/store/c7hpgi06j8v4rvmamvx9wmmql6sa3h0c-gst-plugins-base-1.19.3.tar.xz
source root is gst-plugins-base-1.19.3
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file gst-plugins-base-1.19.3/po/gst-plugins-base-1.0.pot
patching sources
patching script interpreter paths in common/scangobj-merge.py scripts/extract-release-date-from-doap-file.py
find: 'common/scangobj-merge.py': No such file or directory
scripts/extract-release-date-from-doap-file.py: interpreter directive changed from "#!/usr/bin/env python3" to "/nix/store/5bh6rpya1ar6l49vrhx1rg58dsa42906-python3-3.9.6/bin/python3"
configuring
meson flags: --buildtype=plain         --libdir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/lib --libexecdir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/libexec         --bindir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/bin --sbindir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/sbin         --includedir=/nix/store/hhan2fkla9g485dx29wrliyckrfzamqx-gst-plugins-base-1.19.3-dev/include         --mandir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/share/man --infodir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/share/info         --localedir=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/gf28jz40mnqdpxpvwrba90ydndc5js56-gst-plugins-base-1.19.3 -Dexamples=disabled -Ddoc=disabled -Dgl-graphene=disabled -Dgl_winsys=x11,wayland -Dorc=disabled
The Meson build system
Version: 0.59.4
Source dir: /build/gst-plugins-base-1.19.3
Build dir: /build/gst-plugins-base-1.19.3/build
Build type: native build
Project name: gst-plugins-base
Project version: 1.19.3
C compiler for the host machine: gcc (gcc 10.3.0 "gcc (GCC) 10.3.0")
C linker for the host machine: gcc ld.bfd 2.35.2
Host machine cpu family: x86_64
Host machine cpu: x86_64
C++ compiler for the host machine: g++ (gcc 10.3.0 "g++ (GCC) 10.3.0")
C++ linker for the host machine: g++ ld.bfd 2.35.2
Compiler for C supports link arguments -Wl,-Bsymbolic-functions: YES
Compiler for C supports arguments -fvisibility=hidden: YES
Compiler for C supports arguments -fno-strict-aliasing: YES
Message: Disabling deprecated GLib API
Has header "dlfcn.h" : YES
Has header "emmintrin.h" : YES
Has header "inttypes.h" : YES
Has header "memory.h" : YES
Has header "netinet/in.h" : YES
Has header "netinet/tcp.h" : YES
Has header "process.h" : NO
Has header "smmintrin.h" : YES
Has header "stdint.h" : YES
Has header "strings.h" : YES
Has header "string.h" : YES
Has header "sys/socket.h" : YES
Has header "sys/stat.h" : YES
Has header "sys/types.h" : YES
Has header "sys/wait.h" : YES
Has header "unistd.h" : YES
Has header "winsock2.h" : NO
Has header "xmmintrin.h" : YES
Has header "linux/dma-buf.h" : YES
Library m found: YES
Checking for function "dcgettext" with dependency -lm: YES
Checking for function "gmtime_r" with dependency -lm: YES
Checking for function "localtime_r" with dependency -lm: YES
Checking for function "lrintf" with dependency -lm: YES
Checking for function "mmap" with dependency -lm: YES
Checking for function "log2" with dependency -lm: YES
Checking for size of "char" : 1
Checking for size of "int" : 4
Checking for size of "long" : 8
Checking for size of "short" : 2
Checking for size of "void*" : 8
Compiler for C++ supports arguments -Waggregate-return: YES
Compiler for C supports arguments -Wmissing-declarations: YES
Compiler for C++ supports arguments -Wmissing-declarations: YES
Compiler for C supports arguments -Wredundant-decls: YES
Compiler for C++ supports arguments -Wredundant-decls: YES
Compiler for C supports arguments -Wundef: YES
Compiler for C++ supports arguments -Wundef: YES
Compiler for C supports arguments -Wwrite-strings: YES
Compiler for C++ supports arguments -Wwrite-strings: YES
Compiler for C supports arguments -Wformat: YES
Compiler for C++ supports arguments -Wformat: YES
Compiler for C supports arguments -Wformat-nonliteral: YES
Compiler for C++ supports arguments -Wformat-nonliteral: YES
Compiler for C supports arguments -Wformat-security: YES
Compiler for C++ supports arguments -Wformat-security: YES
Compiler for C supports arguments -Winit-self: YES
Compiler for C++ supports arguments -Winit-self: YES
Compiler for C supports arguments -Wmissing-include-dirs: YES
Compiler for C++ supports arguments -Wmissing-include-dirs: YES
Compiler for C supports arguments -Waddress: YES
Compiler for C++ supports arguments -Waddress: YES
Compiler for C supports arguments -Wno-multichar: YES
Compiler for C++ supports arguments -Wno-multichar: YES
Compiler for C supports arguments -Wvla: YES
Compiler for C++ supports arguments -Wvla: YES
Compiler for C supports arguments -Wpointer-arith: YES
Compiler for C++ supports arguments -Wpointer-arith: YES
Compiler for C supports arguments -Wmissing-prototypes: YES
Compiler for C supports arguments -Wdeclaration-after-statement: YES
Found pkg-config: /nix/store/zm7d9fw403racbfyprb4hqlwbwz8544n-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
Run-time dependency x11 found: YES 1.7.2
Run-time dependency glib-2.0 found: YES 2.70.1
Run-time dependency gobject-2.0 found: YES 2.70.1
Run-time dependency gio-2.0 found: YES 2.70.1
Run-time dependency gio-unix-2.0 found: YES 2.70.1
Run-time dependency gmodule-no-export-2.0 found: YES 2.70.1
Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
Dependency gtk+-3.0 skipped: feature examples disabled
Dependency gtk+-x11-3.0 skipped: feature examples disabled
Run-time dependency gstreamer-1.0 found: YES 1.19.3
Run-time dependency gstreamer-base-1.0 found: YES 1.19.3
Run-time dependency gstreamer-net-1.0 found: YES 1.19.3
Run-time dependency gstreamer-check-1.0 found: YES 1.19.3
Run-time dependency gstreamer-controller-1.0 found: YES 1.19.3
Dependency orc-0.4 skipped: feature orc disabled
Program orcc skipped: feature orc disabled
Message: Orc Compiler not found or disabled, will use backup C code
Compiler for C supports arguments -msse: YES
Compiler for C supports arguments -msse2: YES
Compiler for C supports arguments -msse4.1: YES
Message: GStreamer debug system is enabled
Checking whether type "struct tcp_info" has member "__tcpi_reordering" : NO
Checking whether type "struct tcp_info" has member "tcpi_reordering" : YES
Program g-ir-scanner found: YES (/nix/store/5njndanmnlsxkgl5yyrmkfs8a4909cxa-gobject-introspection-1.70.0-dev/bin/g-ir-scanner)
Program scripts/meson-pkg-config-file-fixup.py found: YES (/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py)
Program python3 found: YES (/nix/store/5bh6rpya1ar6l49vrhx1rg58dsa42906-python3-3.9.6/bin/python3.9)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Run-time dependency iso-codes found: YES 4.6.0
Run-time dependency zlib found: YES 1.2.11
Run-time dependency gobject-introspection-1.0 found: YES 1.70.0
Dependency gobject-introspection-1.0 found: YES 1.70.0 (cached)
Program g-ir-scanner found: YES (/nix/store/5njndanmnlsxkgl5yyrmkfs8a4909cxa-gobject-introspection-1.70.0-dev/bin/g-ir-scanner)
Dependency gobject-introspection-1.0 found: YES 1.70.0 (cached)
Program g-ir-compiler found: YES (/nix/store/5njndanmnlsxkgl5yyrmkfs8a4909cxa-gobject-introspection-1.70.0-dev/bin/g-ir-compiler)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Configuring gstpluginsbaseversion.h using configuration
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Looking for a fallback subproject for the dependency (anonymous)
Automatic wrap-based subproject downloading is disabled
Subproject  gl-headers is buildable: NO (disabling)
Dependency (anonymous) from subproject gl-headers found: NO (subproject failed to configure)
Run-time dependency opengl found: YES 4.5
Run-time dependency glx found: YES 1.4
Run-time dependency glesv2 found: YES 1.3.4
Has header "GLES3/gl3.h" with dependency glesv2: YES
Has header "GLES3/gl3ext.h" with dependency glesv2: YES
Run-time dependency egl found: YES 1.3.4
Has header "EGL/egl.h" with dependency egl: YES
Has header "EGL/eglext.h" with dependency egl: YES
Has header "libdrm/drm_fourcc.h" : NO
Run-time dependency wayland-client found: YES 1.19.0
Run-time dependency wayland-cursor found: YES 1.19.0
Run-time dependency wayland-egl found: YES 18.1.0
Run-time dependency wayland-protocols found: YES 1.23
Program wayland-scanner found: YES (/nix/store/aqccrhr8yl2b4784illdwwl6dndwmn7x-wayland-1.19.0-bin/bin/wayland-scanner)
Run-time dependency x11-xcb found: YES 1.7.2
Checking for function "glXMakeCurrent" with dependency glx: YES
Library nvbuf_utils found: NO
Has header "nvbuf_utils.h" : NO
Checking for type "GLeglImageOES" with dependencies glesv2, opengl: YES
Checking for type "GLchar" with dependencies glesv2, opengl: YES
Checking for type "GLsizeiptr" with dependencies glesv2, opengl: YES
Checking for type "GLintptr" with dependencies glesv2, opengl: YES
Checking for type "GLsync" with dependencies glesv2, opengl: YES
Checking for type "GLuint64" with dependencies glesv2, opengl: YES
Checking for type "GLint64" with dependencies glesv2, opengl: YES
Checking for type "EGLAttrib" with dependencies glesv2, opengl, egl: YES
Checking for type "EGLuint64KHR" with dependencies glesv2, opengl, egl: YES
Configuring gstglconfig.h using configuration
Program glib-mkenums found: YES (/nix/store/5idik4vmd83cnx5z4shg44s53l4n2whj-glib-2.70.1-dev/bin/glib-mkenums)
Program gl_mkenum.py found: YES (/nix/store/5bh6rpya1ar6l49vrhx1rg58dsa42906-python3-3.9.6/bin/python3.9 /build/gst-plugins-base-1.19.3/gst-libs/gst/gl/gl_mkenum.py)
gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".
A full log can be found at /build/gst-plugins-base-1.19.3/build/meson-logs/meson-log.txt
builder for '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv' failed with exit code 1
error: build of '/nix/store/42wzrvdvpl5khjgi93c1ivbxqblj0i4f-libnice-0.1.18.drv', '/nix/store/7bapxpzfz36szwlkiyvi5iqg6j940ywc-gst-plugins-base-1.19.3.drv', '/nix/store/a0dkanvf6xnvlzvxh8gigdybndfbkab3-gst-plugins-good-1.19.3.drv', '/nix/store/wsclrfp8xi6qy2bz4szk6d65hjhwhsyf-gst-plugins-bad-1.19.3.drv' failed
`

Can you upload /build/gst-plugins-base-1.19.3/build/meson-logs/meson-log.txt somewhere?

can't open this file when I try to accessit . it is because no this file gen.
may be the nix os is livecd

I can mkdir /build
but there is no other file /folder be created in it

No idea. Probably /build is a local path inside a chroot or container being used for the build. I've never actually used NixOS, we just use the nix tool for reproducible build environments. The logs you've provided don't give enough info to understand why gstreamer doesn't build.

`Program g-ir-compiler found: YES (/nix/store/mqbify3fap3rv1iz4s8z3jxpb5p57x7s-gobject-introspection-1.70.0-dev/bin/g-ir-compiler)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Configuring gstpluginsbaseversion.h using configuration
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Looking for a fallback subproject for the dependency (anonymous)
Automatic wrap-based subproject downloading is disabled
Subproject  gl-headers is buildable: NO (disabling)
Dependency (anonymous) from subproject gl-headers found: NO (subproject failed to configure)
Run-time dependency opengl found: YES 4.5
Run-time dependency glx found: YES 1.4
Run-time dependency glesv2 found: YES 1.3.4
Has header "GLES3/gl3.h" with dependency glesv2: YES
Has header "GLES3/gl3ext.h" with dependency glesv2: YES
Run-time dependency egl found: YES 1.3.4
Has header "EGL/egl.h" with dependency egl: YES
Has header "EGL/eglext.h" with dependency egl: YES
Has header "libdrm/drm_fourcc.h" : NO
Run-time dependency wayland-client found: YES 1.19.0
Run-time dependency wayland-cursor found: YES 1.19.0
Run-time dependency wayland-egl found: YES 18.1.0
Run-time dependency wayland-protocols found: YES 1.23
Program wayland-scanner found: YES (/nix/store/212lgksf9abhjm9xm098mvmpi7rrskj0-wayland-1.19.0-bin/bin/wayland-scanner)
Run-time dependency x11-xcb found: YES 1.7.2
Checking for function "glXMakeCurrent" with dependency glx: YES
Library nvbuf_utils found: NO
Has header "nvbuf_utils.h" : NO
Checking for type "GLeglImageOES" with dependencies glesv2, opengl: YES
Checking for type "GLchar" with dependencies glesv2, opengl: YES
Checking for type "GLsizeiptr" with dependencies glesv2, opengl: YES
Checking for type "GLintptr" with dependencies glesv2, opengl: YES
Checking for type "GLsync" with dependencies glesv2, opengl: YES
Checking for type "GLuint64" with dependencies glesv2, opengl: YES
Checking for type "GLint64" with dependencies glesv2, opengl: YES
Checking for type "EGLAttrib" with dependencies glesv2, opengl, egl: YES
Checking for type "EGLuint64KHR" with dependencies glesv2, opengl, egl: YES
Configuring gstglconfig.h using configuration
Program glib-mkenums found: YES (/nix/store/xx643xl761fryig8f2pljhhnhdn27k4p-glib-2.70.1-dev/bin/glib-mkenums)
Program gl_mkenum.py found: YES (/nix/store/k0z9n599k02hab8qjjp3ljw065iwjcvg-python3-3.9.6/bin/python3.9 /build/gst-plugins-base-1.19.3/gst-libs/gst/gl/gl_mkenum.py)
gst-libs/gst/gl/meson.build:1076:2: ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".
A full log can be found at /build/gst-plugins-base-1.19.3/build/meson-logs/meson-log.txt
error: builder for '/nix/store/i0bkwdd9gjap5w4mhqvllc91za1zcxsj-gst-plugins-base-1.19.3.drv' failed with exit code 1
error: build of '/nix/store/66w69mgvnan313gaww90whwzrwvq4brw-gst-plugins-good-1.19.3.drv', '/nix/store/gyfiqr0nibn9qmizr3iznl0znlg5c2r2-libnice-0.1.18.drv', '/nix/store/i0bkwdd9gjap5w4mhqvllc91za1zcxsj-gst-plugins-base-1.19.3.drv', '/nix/store/pbq3hlk4ql464vy2k0ifa81cr106vnyw-gst-plugins-bad-1.19.3.drv' failed
user1@user1-ProLiant-DL388-Gen10:/data/gst-meet/gst-meet$
`

This is an Ubuntu 20.04;
I just installed nix and passed:
curl -L https://nixos.org/nix/install | sh
It installed and ran normally.
When compiling, it still reported an error.
At the same time, I couldn't find the log file that reported the error, because this file didn't exist at all.

I think your code configure have some erro.
ERROR: Could not execute command "/build/gst-plugins-base-1.19.3/scripts/meson-pkg-config-file-fixup.py gstreamer-gl-1.0 gl_platforms gl_winsys gl_apis".

Please don't just paste the same log over and over.
We will test with nix on Ubuntu 20.04 and report back. But with nix-shell --pure the host OS should not matter much.

I think your code configure have some erro.

This is not our code, it's gstreamer. As previously mentioned, it's a prerelease version, so it may well have some errors, but this issue is more likely related to environment.

Please don't just paste the same log over and over.
We will test with nix on Ubuntu 20.04 and report back. But with nix-shell --pure the host OS should not matter much.

The two log from different os.
The firest one from livecd of nix.
The second from ubuntu 20.04 with nix tool.

nix-shell --pure
what the kind of os type you used? I want to have a try again with your os type and version.

We have tested previously on latest Ubuntu, Debian testing, Arch Linux, Alpine and macOS. But the purpose of using Nix is that the host OS does not matter.

I tried to use nix to compile it under the same system, all with the same error result.

Just for clarity, what you are doing here is compiling GStreamer (from the rules in shell.nix), not gst-meet. Compiling gst-meet would be the next step, once you get a nix shell open with the dependencies available.
This log is identical to the previous logs, it doesn't contain enough information to understand the issue. I suspect it's caused by the gl-headers error but am not sure without more info.

waiting for your docker.

Will update #23 when the Dockerfile is updated


Ziti edge service helper

Create the configs, service, and service policies for an endpoint using one cli command.
Example usages
Create dial and bind setup for localhost:1280 using tcp, the service is called myservice, with an endpoint at myservice.ziti (defaulted to servicename.ziti)
ziti edge secure myservice tcp:localhost:1280
Create dial and bind setup for localhost:1280 using tcp, the service is called myervice, with a custom endpoint at myendpoint.ziti
ziti edge secure myservice tcp:localhost:1280 --endpoint myendpoint.ziti
Create dial and bind setup for <IP_ADDRESS>:1280 using "tcp,udp" protocols, the service is called myservice, with an endpoint at myservice.ziti. When not provided, allowed protocols defaults to both tcp and udp, and the assumed address is <IP_ADDRESS>. At a minimum, port must always be provided.
ziti edge secure myservice 1280

closing the pr for now


SwipeCollectionViewCell indexPath nil

open class SwipeCollectionViewCell: UICollectionViewCell {
....
var indexPath: IndexPath? {
return collectionView?.indexPath(for: self)
}
}
indexPath sometime return nil when cell was reused, and no action will be performed

From the UICollectionView docs
Return Value
The cell object at the corresponding index path or nil if the cell is not visible or indexPath is out of range.
At last I solved by force reload section:
func collectionView(_ collectionView: UICollectionView, editActionsForItemAt indexPath: IndexPath, for orientation: SwipeActionsOrientation) -> [SwipeAction]? {
    guard orientation == .right  else { return nil }

    let deleteAction = SwipeAction(style: .destructive, title: "Delete") { action, indexPath in

        self.dataSource.remove(at: indexPath.item-1)
        self.collectionView.deleteItems(at: [indexPath])

        //
        // important: fix cellForItemAt not called
        //
        DispatchQueue.main.asyncAfter(deadline: .now()+0.25, execute: {
            UIView.performWithoutAnimation {
                self.collectionView.reloadSections(IndexSet.init(integer: 0))
            }
        })


Milestone 17: Improvements

Improvements
This branch includes:

[x] Update README.md file
[x] Add previous menus for navigation

Thank you 👍


⚠ Bofrost.de has degraded performance

In b512a28, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1433 ms

Resolved: Bofrost.de performance has improved in 8b7b2e1 after 29 minutes.


Update index.md

Adding missing space before level 3 headers
What changes were proposed in this pull request?
Missing space added to use header format
How was this patch tested?
I just wanted to quickly fix this typo(s) through github. If this is not conform with the contribution method please delete this PR

Thanks!

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/567/
Test FAILed.
Test FAILured.


Chem colors

About the PR

Changed the colors of many boring gray chemicals. Mostly based off of CPK Coloring

ChemicalBeforeAfter
Hydrogen
#808080

#cccccc

Fluorine
#808080

#ba85cc

Oxygen
#808080

#c4f5ff

Nitrogen
#808080

#a1e1ff

NitrousOxide
#808080

#5d88c9

Phosphorus
#ede4e4

#f5da9a

Lithium
#c6c8cc

#d6c0a7

Sodium
#c6c8cc

#a7b3d6

Why / Balance

Pretty colors :)
Makes it slightly easier to distinguish colors in a chem dispenser.
Most of these chemicals you will rarely see, and even if you do, won't care about, in a spill. The colors are purely cosmetic for the dispenser (/ chem master coming soon i swear ooooooo), so this will not affect gameplay. I left potassium unchanged because janitors actively look out for it, so if it was no longer white that may throw them off.
Technical details

YAML or something.
Media

Breaking changes

Changelog

:cl:

tweak: Some chemicals have been made more colorful and child-friendly.

chlorine and fluorine are too similar now

That could be easily changed, but why is that something to worry about? Before the changes there were like four chemicals with the same medium gray color.

That could be easily changed, but why is that something to worry about? Before the changes there were like four chemicals with the same medium gray color.

it's iconic, and doesn't contrast well for CLF3 especially; where the chemical reaction only requires two colours

This makes no sense why they would use arbitrary colors meant for molecular model instead of their actual real life colors. This doesn't just affect chem ui but puddles as well. Oxygen should be light blue and nitrogen should be clear, for example. Nitrogen having the color of oxygen would be very confusing.

Okay, I can see Oxygen being an issue (and I was iffy about that when making the PR), but for literally any chemical you dont see in real life, the colors picked are completely arbitrarily or based on what feels right.
I can see your concerns around fluorine too. Would changing fluorine to a light purple/pink and oxygen to light blue work? I would like to keep Nitrogen as light blue because I just kinda hate using '#808080' to represent colorlessness.

Wondering if it would be worthwhile to add separate color and uiColor properties.

Yeah so many chems being the same color was an issue! I always get confused if two are on the floor.

yeah i'd go with tayrtahn's suggestion for this one. Include a secondary color that can be used to override the color in the UI and just use the basic one if none is specified. The color for chems is very obviously implied to be the physical color so a lot of this doesn't make much sense.

I mean, I think that giving chems somewhat distinct colors can't hurt, just so not absolutely everything is #808080. For example, ClF3 is light pink even though really it should be colorless like 99% of other chemicals.  Why would nitrogen and hydrogen have to stick to their real life colors of, uh, no color?
Having a different color in the UI of the dispenser also brings other complications, because the color of the jugs is based on the entire solution of the jug, which could be any mix of chems. Having a special-case color for certain chemicals is already kind of unintuitive, but what, you would have to mix the uiColor's of all the chemicals in the solution? It's certainly possible but I don't think it's as clean of a solution as you guys were thinking. It's just way easier and simpler to just represent the color of the solution.
Also my main goal with these changes was to just have chems be distinguishable, having half the jugs be a shade of medium-gray frankly just isn't cool. Making the colors in the chem dispenser be distinguishable only solves half the problem IMO.

I'm all for realism, I just don't see why we should follow realism when realism tells us that 90% of the chemicals should be colorless or white. And if we keep it "realistic" for oxygen, we would be making exceptions for chemicals like radium which I hope we can agree makes sense to keep green.

Maybe jugs could be colorable, and the ui would use that color instead of the chem color? This would also help distinguish jugs outside of the chem dispenser.

these are fine changes, i dont agree with standardizing in the other direction, theres not really any benefit to making chems realistic colors

I honestly didn't expect this PR to be at all controversial; I thought it was pretty clear that a bunch of chems being colored '#808080' was an oversight or placeholder.


Attempt to index nil code action response

Info

Operating System: Arch Linux
Shell: Fish
Terminal: Wezterm
nvim --version: v0.10.0-dev-1792+g999e167a5
fzf --version: 0.44.1

[ ] The issue is reproducible with mini.sh

fzf-lua configuration

require('fzf-lua').setup({
  lsp = {
    code_actions = {
      previewer = 'codeaction_native',
      preview_pager = "delta --side-by-side --width=$FZF_PREVIEW_COLUMNS --hunk-header-style='omit' --file-style='omit'",
    },
  }
})

Description
I cannot pinpoint exactly when it happens, but sometimes when requesting code actions with FzfLua lsp_code_actions (using the above configuration), I obtain the following error message.
Error executing vim.schedule lua callback: ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeactio
n.lua:166: attempt to index local 'res' (a nil value)
stack traceback:
        ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:166: in function 'preview_act
ion_tuple'
        ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:232: in function 'fn'
        ...los/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:107: in function 'fn'
        ...los/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:71: in function <...los/.loca
l/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:70>
Error executing vim.schedule lua callback: ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeactio
n.lua:166: attempt to index local 'res' (a nil value)
stack traceback:
        ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:166: in function 'preview_act
ion_tuple'
        ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:232: in function 'fn'
        ...los/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:107: in function 'fn'
        ...los/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:71: in function <...los/.loca
l/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:70>

So far I've seen it happen with TypeScript's "Move to a new file" code action.

So far I've seen it happen with TypeScript's "Move to a new file" code action.

It seems the result from code action resolve request comes back nil from the LSP without a specific error, I can easily work around that by checking for nil but I’d like to see why the code action resolving fails even though the LSP indicates it supports resolving.
Can you let me know which LSP do I need to install and perhaps a code sample where I can have the same code action so I can test this?

Of course! I use typescript-tools for my TypeScript LSP setup.
This is the plugin's config:
-- "Native" TSServer client.
return {
    {
        'pmizio/typescript-tools.nvim',
        event = { 'BufReadPre *.ts,*.tsx,*.js,*.jsx', 'BufNewFile *.ts,*.tsx,*.js,*.jsx' },
        dependencies = { 'nvim-lua/plenary.nvim', 'nvim-lspconfig' },
        opts = {
            settings = {
                tsserver_file_preferences = {
                    includeInlayParameterNameHints = 'literals',
                    includeInlayVariableTypeHints = true,
                    includeInlayFunctionLikeReturnTypeHints = true,
                },
            },
        },
    },
}

And this is my code action command:
   if client.supports_method(methods.textDocument_codeAction) then
        keymap('<leader>ca', function()
            require('fzf-lua').lsp_code_actions {
                winopts = {
                    relative = 'cursor',
                    width = 0.6,
                    height = 0.6,
                    row = 1,
                    preview = { vertical = 'up:70%' },
                },
            }
        end, 'Code actions', { 'n', 'v' })
    end

You can then run npm i typescript and the code action is offered with every snippet of TypeScript code, so something as simple as function foo() { return 0; } should work.

Ty @MariaSolOs, I will attempt your setup.
In the meantime I improved the error handling of failed resolve queries, can you please update to https://github.com/ibhagwan/fzf-lua/commit/adc3dc23aff10bfca5495af57f7e22af28acf1e5 and lmk what the preview window displays on the (previously) failed actions?
If this still fails (very possible since the res object is nil) - Can you try running :FzfLua lsp_code_actions previewer=codeaction? Since the LSP request is async the error handling is a bit different perhaps the error returns a more meaningful message this way.

I can already see a potential issue, I already had installed typescript-language-server which typescript-tools.nvim is a replacement for, the default implementation doesn't appear to support the resolveProvider LSP capability (which attempts resolving code actions that aren't already defined as "edit").
I suspect typescript-tools.nvim acts as if it does support  resolveProvider  but then fails when it queries typescript-language-server, I will install typescript-tools.nvim and see if this is indeed the issue.

@MariaSolOs, can you try https://github.com/ibhagwan/fzf-lua/commit/372b643e42f3f4ed3dd66f88b9d8f9b3fed5d53e - I think it should solve the issue, it should display a similar message (from typescript-language-server):

@ibhagwan commits tested and they work! It's a bit strange though because depending on the location the preview might be shown, but that's definitely an issue with TSServer and not fzf-lua.
As always, thank you for the impressibly fast fix <3

Also sorry for the slightly complex setup! I will try to provide proper minimal reproduction environments in the future.

depending on the location the preview might be shown, but that's definitely an issue with TSServer and not fzf-lua

Neovim uses make_positional_params which then correspond to the cursor location when the request is invoked, not much I can do about that indeed.

Also sorry for the slightly complex setup! I will try to provide proper minimal reproduction environments in the future.

No worries, LSP setup in neovim can be quite involved.

Hello, could you please provide some guidance on resolving or mitigating this error?
It operates smoothly during the initial activation of codeAction, but on the second attempt, it results in an error.
My configuration closely resembles Maria's. I'm sharing a video example along with the accompanying error that occurred.
Thank you!
Error:
Error executing vim.schedule lua callback: ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:129: attempt to index local 'action' (a nil value)
stack traceback:
  ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:129: in function 'preview_action_tuple'
  ...e/nvim/lazy/fzf-lua/lua/fzf-lua/previewer/codeaction.lua:283: in function 'fn'
  ...wrx/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:117: in function 'fn'
  ...wrx/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:76: in function <...wrx/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:75>

Video:
https://github.com/ibhagwan/fzf-lua/assets/3436517/42507c4a-60e2-431c-a37a-5bd11861788e

Hello, could you please provide some guidance on resolving or mitigating this error?
It operates smoothly during the initial activation of codeAction, but on the second attempt, it results in an error.
My configuration closely resembles Maria's. I'm sharing a video example along with the accompanying error that occurred.
Thank you!

@yavorski, this seems like it might be a new issue from recent changes related to #1057, there is a chance you may have been caught in bwteeen commits, can you please update to the latest commit and if the issue still persists open a new issue and we’ll tackle it there?

Hi, Thanks a lot for your response! I've double-checked, and can confirm that I'm using the latest version. The issue seems to be sticking around quite consistently. Any insights or help would be awesome!
d68d1cf chore(tabs): move encoded tab_cwd to start of line (#1064) (2 days ago)

@yavorski , update to https://github.com/ibhagwan/fzf-lua/commit/404e7522d1cd8c57b305f0acf46647d8e0660ef3 - this commit validates the action returned from the LSP server is valid and works around the error.
However, the cause of this error is not fzf-lua but typescript-tools.nvim, I was able to reproduce this issue by installing typescript-tools.nvim and using the same setup found in your dotfiles (may or may not be relevant):
https://github.com/yavorski/dotfiles/blob/61c59ccf45252ad9b1b73d1f63fe4b2b22b07e8c/nvim/init.lua#L1538-L1573
In order to display the diff for the code action preview, if the action doesn't contain the workspace edit section, fzf-lua will send a codeAction/resolve request to the LSP server, the first call works (as you found out) but any subsequent call is bugged (and returns nil) with typescript-tools.nvim.
If fzf-lua sends a synchrounous request with:
:FzfLua lsp_code_actions previewer=codeaction_native

typescript-tools.nvim returns a nil action, with the latest commit, fzf-lua will fallback to the original unresolved action and display this message (no error but also no diff):

If using the neovim builtin (non-native) previewer, fzf-lau will send an async LSP request and waits for a callback which never returns, e.g.:
:FzfLua lsp_code_actions previewer=codeaction

Resulting in:

Hopefully this is enough information for you to open an upstream issue with typescript-tools.nvim.

@ibhagwan, my apologies for the delayed response. Just tested with latest commit https://github.com/ibhagwan/fzf-lua/issues/949 and it is working great now! Huge thanks for your awesome work!

@ibhagwan, my apologies for the delayed response. Just tested with latest commit #949 and it is working great now! Huge thanks for your awesome work!

It's working, but not "great" yet :-)
There's a bug in typescript-tools.nvim causing the 2nd call onward to not display the diff.

There is already an existing issue at https://github.com/pmizio/typescript-tools.nvim/issues/231. I've forwarded your comment, and I'm happy to note that codeActions have significantly improved; at least they do not constantly throw errors now. Thank you once again for your assistance!

There is already an existing issue at pmizio/typescript-tools.nvim#231. I've forwarded your comment, and I'm happy to note that codeActions have significantly improved; at least they do not constantly throw errors now. Thank you once again for your assistance!

I see, added my 2 cents on that issue as well.


Move to Next.js

Description
Move some components to next.js implementation and remove them from Jekyll
Proposed Changes

Create remaining components for general guidelines
Create remaining components for buttons
Create components for cards
Create components for colors

Potential Breaking Changes
None
Acceptance Criteria

[x] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[x] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1152 into feature-replace-jeyll-with-nextjs will not change coverage.
The diff coverage is n/a.

@@                        Coverage Diff                         @@
##           feature-replace-jeyll-with-nextjs    #1152   +/-   ##
==================================================================
  Coverage                              99.74%   99.74%
==================================================================
  Files                                    350      350
  Lines                                   8525     8525
  Branches                                2024     2024
==================================================================
  Hits                                    8503     8503
  Misses                                    22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3eb65...1d1ce16. Read the comment docs.


SRS Use of "SI Units" even when units are not SI

In the Table of Units there is an "SI" column, and the text claims that SI is used throughout.

Also in the GDs and DDs there is a row heading "SI Units".

Angstroms are not SI units, so in this case I think these heading names should be changed to not specify "SI".

Fixed in fbc963389063b7078eb552416922cc54027961e4


Controller onunload firing multiple times after inital e.preventDefault() then later approval

Possible scenario is this:

Imagine a multi-page form that is partially filled out. A user a few pages into the form forgets what they entered in a field on a prior page, so they click a link to go back to that page.
This would normally unload the current page of the form, but if they haven't saved their data, we want to ask "Are you sure?" before they leave.
If they decide to finish the page after all we call e.preventDefault() to stop unloading the module.
If for some reason this happened 2 or 3 times in a row, when the module IS finally unloaded, the onunload function is fired as many times as they hit cancel! Those calls seem to just stack up.

Here is a jsbin demonstrating the problem:
http://jsbin.com/guqodajeju/1/

When running the jsbin, navigate from home (default) to page 1, then page 2, clicking 'OK' each time (note the log shows when the modules are unloaded.)
When on page 2, click home, then 'Cancel' the change. Click 'Page 1', then 'Cancel' again.
Repeat several times if you want.
Then, finally, click 'Page 1' one last time, followed by 'OK' and you will see multiple log entries appear for the one confirmed unload.

One case where this could potentially be problematic is if an ajax call was part of the onunload, as it might fire multiple requests off to the server.

Nevermind, bad test code. I HATE it when I do that.


Simple ng-show not working

Hello, I'm making a very simple application:
I want to load an array via ajax call, then display it. During the loading time, I want an animated gif.
<!DOCTYPE html>

                            {{loading}}

                        {{t.brand.name}}
                        {{t.stock}}
                        {{t.threshold}}

With that controller :
thresholdApp = angular.module "thresholdApp", []

thresholdApp.controller "thresholdCtrl", ($scope, webService) ->

	$scope.loading = false

	webService.post "stock/threshold/check", {}, (result) ->
		$scope.thresholds = result.stockThresholds
		$scope.loading = false

It works well, the table is filled with the ajax response as expected but the tr with the ng-show directive don't work. The weird thing is that in the other hand, {{loading}} is well updated and is replace by false.
Any idea ?

Shouldn't you set it to true somewhere? Like in:
$scope.loading = true

webService
     .post("stock/threshold/check", {})
     .then(result => {
          $scope.thresholds = result.stockThresholds
     })
     .finally(_ => $scope.loading = false)

@valentincocaud please direct support questions to an appropriate support channel: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question
Thnx!

@ericmdantas Yes, it's a copy mistake. I found that the problem is that css classes (like ng-hide) are not set. Loading the angular-csp.css file fix the issue but I don't use ng-csp directive.


Radiology entity

restructured test_data folder (renamed to test_data_e2e, archived previous NGS dataset)
added new dataset with Radiology data and updated config files accordingly
added README inside the folder to explain test data update workflow, including validation
added a script to automatically generate sha1sum files

TODO:

[x] detailed test data description
[ ] current changes are in sync with branch master of python_csr2transmart. it would be good to make a new official release of that on PyPI (and updating the requirements.txt here accordingly) before merging this branch.

Just a suggestion - you added a lot of commits in this PR, ideally the number of commits would be closer to the number of changes you listed in the PR description (4). It is good to squash some commits together sometimes, so the repository history stays clean and easy to browse through.

Just a suggestion - you added a lot of commits in this PR, ideally the number of commits would be closer to the number of changes you listed in the PR description (4). It is good to squash some commits together sometimes, so the repository history stays clean and easy to browse through.

Guess it's a matter of style? :P I generally go for smaller commits, to allow for more specific commit messages. Maybe I've learned from the wrong sources, I honestly thought that was good practice. If in this repo you have been consistently using more "chunky" commits, I can try to keep the number down in future contributions. I can try to squash some of these together, I'm looking up safe ways to do this..

Just a suggestion - you added a lot of commits in this PR, ideally the number of commits would be closer to the number of changes you listed in the PR description (4). It is good to squash some commits together sometimes, so the repository history stays clean and easy to browse through.

Guess it's a matter of style? :P I generally go for smaller commits, to allow for more specific commit messages. Maybe I've learned from the wrong sources, I honestly thought that was good practice. If in this repo you have been consistently using more "chunky" commits, I can try to keep the number down in future contributions. I can try to squash some of these together, I'm looking up safe ways to do this..

Small, single-purpose commits are good and your commit messages are really clear. What I meant is more that as long as you're the only one working on a branch and it's not merged yet, you can squash and force-push the branch as you want. E.g. if you have one commit that adds a documentation and then next one that adds a small update to this documentation, you can just add the updates as part of the previous commit (using e.g. git commit --amend).
But I'm fine with keeping the commits here, they are clear and indeed it would be just a few of them that could be squashed. It was just a remark, because I often check a PR commit by commit and here it was a bit more challenging :P


”Chilieni”, ”Coșeni” are listed in the drop-down menu

Description:
When user writes ”Chilieni”, ”Coșeni” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Chilieni"

Expected results
The location appears in the drop-down menu as "Sat Chilieni, COVASNA (SFÂNTU GHEORGHE)".

Step 1
Write in the search bar "Coșeni"

Expected results
The location appears in the drop-down menu as "Sat Coșeni, COVASNA (SFÂNTU GHEORGHE)".


[iOS] [Fixed] - Fixed code and reason arguments ignored on iOS when listening to WebSocket.onclose

Summary

Websocket ignores code and reason from onclose listener.
Some work was done in #24950 to send them to close, but onclose always returns 1001 and Stream end encountered:
https://github.com/facebook/react-native/blob/master/Libraries/WebSocket/RCTSRWebSocket.m#L1391
This PR calls didCloseWithCode at the end of closeWithCode and Websocket.onclose now works.
Changelog

[iOS] [Fixed] - Fixed code and reason arguments ignored on iOS when listening to WebSocket.onclose
Test Plan

Run integration tests.

I tried patching the code from @diegolmello to my project, but it return with code: 1000 and null reason
So I wrote more lines and it works, but I'm not good at objective-c.
Can someone check if I'm doing right?
diff --git a/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m b/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m
index 8ce6edc..01a5948 100644
--- a/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m
+++ b/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m
@@ -594,6 +594,7 @@ - (void)closeWithCode:(NSInteger)code reason:(NSString *)reason
       }
     }

+    [self.delegate webSocket:self didCloseWithCode:code reason:reason wasClean:YES];
     [self _sendFrameWithOpcode:RCTSROpCodeConnectionClose data:payload];
   });
 }
@@ -764,7 +765,9 @@ - (void)handleCloseWithData:(NSData *)data

   [self assertOnWorkQueue];

-  if (self.readyState == RCTSR_OPEN) {
+  if (_closeCode) {
+    [self closeWithCode:_closeCode reason:_closeReason];
+  } else if (self.readyState == RCTSR_OPEN) {
     [self closeWithCode:1000 reason:nil];
   }
   dispatch_async(_workQueue, ^{


Drag and release point selection

As of now, the start and end point are selected using just a press of E. Instead, maybe it should rely on a drag and release, where the first "pick point" is selected by pressing and holding the E key, and the second "pick point" is selected by releasing the E key, and then the actual start or end point is calculated as the center between those two "pick points". If you just press E, then this would work exactly the same as it currently does.

Implemented in 5d79a752bca1b719eb12835ff0adac8da7a93dcf


Special treatment for net.IP?

Hey!
net.IP is a bit annoying because:

it gets printed on several lines
it can uses two different representations

For the second point, net.ParseIP() will provide something like 0,0,0,0,0,0,0,0,0,0,255,255,192,0,2,12 (this is the IPv4-mapped IPv6 address). But one can also just get 192,0,2,12.
For me, it would be convenient if pretty could have a special case for IP by using its string representation. Of course, this would make an horrible special-case and maybe you don't want something like that.
Setting PrintStringers would defeat much of my use of the pretty printer since the string value is incomplete for most of my types. Maybe provide a list of types that should call String() if available?

Yes, I have run into this myself as well.  My vague plan to solve it was to have a whitelist StringifyType map[reflect.Value]bool in addition to (and overriding, in either case) PrintStringers.  I haven't implemented it yet, though, so if you want to take a crack at it, and don't mind signing the Google CLA, feel free :).  Otherwise, let me know if that solution sounds good to you, and I may be able to find time to bang it out.

Yes, that would fit my need too. As for the CLA, for some reason, despite my regular email being registered as an alternate address, the CLA app insists on only using my GMail address that I don't use anywhere.


fix: update side-input readme

Kindly explain what this PR does.

we have to merge https://github.com/numaproj/helm-charts/pull/14 first because we release the examples since it is for 1.3/0.8 release.


.glTF models don't show in the editor window

I noticed that the GLTF example scenes don't actually show the GLTF meshes in the editor window.
Is this a difficult technical problem? Wouldn't it be very useful to be able to see the models in the editor window not just at play time?

I'm attempting to do this as well, and gltf models to not show up in the editor at design time, nor can I drag and drop them into the scene or hierarchy. The only way to get models to show up is to type in the relative path to the asset in the StreamingAssets folder, and then Play the scene, making the models show at runtime. I've tried this on 2017.1.4f1, 2017.2.f1, and 2017.3.f1.
Is there a specific version of VS we need to be building this on?

Hi,
I just wanted to find out if this issue can be addressed in the next release.
Thanks!

Fixed in latest release


03/27/2018 17:18 : Create Pull Request for branch prTesting_2018032717 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature Enhancements: Add Prometheus counters to report packages and vulnerabilities reported per SBOM analyzer and vulnerability scanners

Is your feature request related to a problem? Please describe.
It will be useful to add counters that can spit metrics for packages and vulnerabilities reported per analyzers and scanners.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

.


add a function to rewrite all public keys on admin request

Rewrite all ssh keys again in .ssh/authorized_key.
ps - sorry for extra change in language file, it was my emacs hook to remove space and empty lines in save.
refs #763

It's been late, but still, thanks a lot!


Update README.md

Bug/issue #, if applicable:
Summary
Update outdated issue links in README.md.
Currently, the links will direct into an empty issue template after #268 .

@swift-ci please test


DBZ-5622 Support READ ONLY/ENCRYPTION options for alter database statment

https://issues.redhat.com/browse/DBZ-5622

Applied changes in upstream PR https://github.com/antlr/grammars-v4/pull/2831, thanks @harveyyue

Applied to main (=2.0).


Add ARKKit

#L1252

Project URL
https://github.com/sleepdefic1t/ARKKit
Description
iOS/macOS API Framework for interacting with the Ark Cryptocurrency Ecosystem, written purely in Swift 4.0
Why it should be included to awesome-ios (optional)
I think it might be useful to others looking at Swift 4.0 or wondering about the world of cryptocurrencies. This Framework also has no external dependencies, so it's very easy to integrate.
Checklist

[X] Only one project/change is in this pull request
[X] Addition in chronological order (bottom of category)
[X] Supports iOS 9 / tvOS 10 or later
[X] Supports Swift 3 or later
[X] Has a commit from less than 2 years ago
[X] Has a clear README in English

          1 Warning

:warning:
Found 8 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

844
502
https://github.com/Minitour/AZImagePreview

918
502
https://github.com/pokeb/asi-http-request

1538
502
https://github.com/Lickability/PinpointKit

1561
404
https://github.com/mancunianetz/iCheckbox

1706
502
https://github.com/alsedi/RippleEffectView

2069
502
https://github.com/yannickl/SnappingStepper

2569
502
https://github.com/travisjeffery/ClangFormat-Xcode

2649
301
http://www.tutorialspoint.com/ios/ redirects tohttps://www.tutorialspoint.com/ios/

  Generated by :no_entry_sign: Danger

Any thoughts?

Hey @sleepdefic1t, don't worry. We'll fix these issues to merge your PR.

No worries 😄
Keep up the great work, @miguelarauj1o !


Add podsecuritypolicy for Tiller

This PR adds a clusterrole, clusterrolebinding and a podsecuritypolicy for Tiller.
My Go experience is relatively limited (especially so when using client_go) so please expect to have to point me in the right direction - I wouldn't expect this to be the finished article. It is currently untested as I wanted to get a first-pass from someone with more knowledge than myself.
Provided the resources are created correctly, Tiller should continue to work fine with the PSP in place. It currently runs as nobody/nogroup and only requires access to secrets.

superseded by a newer PR which actually works


Integration with SDKMan

I know the SDKMan folks really wanted to become a potential deployment mechanism for the binaries - http://sdkman.io/ - much discussion etc would be required.

I can see that everyone moved to slack. Is it possible to get a summary on how this is going?

Even I would like to know whether this would be done anytime soon as I also want to move away from zulu

Adopt has been available on sdkman for ages, and is kept up to date by the sdkman community.

I just did a sdk ls java & I see adoptopenjdk distribution aswell there. Thanks

We have both hs and j9 variants.

Can you close this issue in that case. Thanks!


MySQL 8.0 Support?

big fan of this operator! is there a roadmap for mysql 8.0 support?

It appears to be coming in the next release. See the last option
https://github.com/presslabs/mysql-operator/blob/master/Changelog.md#added

It appears to be coming in the next release. See the last option
https://github.com/presslabs/mysql-operator/blob/master/Changelog.md#added

@AMecea When do you think a new release is to be expected or how we can use the unreleased mysql 8 support?


REFPLTV-1400 DisplaySettings - resolutionPreChange event is not gett…

…ing triggered on changing the current resolution Reason for change :RdK Plugin requeirement. Affected Area: Resolution change scenario Features to test: Sanity on Resolution change related scenaos Analysis: On setCurrentResolution call the preChangeNotification was not called

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing older PRs. Pls rebase and create new PR on latest sprint/main branch if still required.


[5.1] Fix: lists() method ambiguous error on innerjoin

if lists method is used inside a inner-join and both table has same supplied column it will through a ambiguous error

You should use a ->select() call if you are joining to a table with the same column names.

Yeah, But it would be a lot nicer if we could use it for select-box filling, I used lists() for most of my {{Form::select ...
Anyway thanks for the suggestion :)


chore(demo): avoid relying on FormlyForm::ng-content

@aitboudad I actually never placed something inside the formly form tag and always wondered what it was good for. did it have any special meaning/functionality?

@juristr it was useful before https://github.com/ngx-formly/ngx-formly/pull/93 (which move form tag outside formly-form) but since then I don't see any relevant use-case.

ah I see, makes sense. in fact assumed it had to do with such scenario 👍


Support for service configs in C-core

This will require:

add support for max send message size
add new fields to client config
change client channel filter to save client config in the call stack
apply data from client config when processing calls

CC @dgquintas

y-zeng@ FYI

Full speed ahead!

Thanks, @dgquintas!


Error when trying to run /api and /admin

HI mikeyk, thank you so much for sharing this out, I fresh with the Django and other language in here.
After I finish setup, I was able to run the homepage.
But when I try to inspect the network using google chrome, I saw that "/api/places/by_neighborhood" giving out Error 502.
For the admin site, at first I had forgot to generate htpasswd it given some error when trying to login.
So i had to generate an htpasswd formatted file, and use "sudo docker-compose down" and "sudo docker-compose up -d" to update the changes.
When I try login after that, no matter what the username or password I key in, it come out Error 500.
The only step I not following is the "generate certificates using letsencrypt".
Any clue why this happening?
Besides that, I want to ask about the docker-compose.yml and docker-compose.prod.yml
What the different between docker-compose.yml and docker-compose.prod.yml?
When we run docker-compose up -d, which of the following file will be trigger?
If we want to publish to live, which of the following yml file should we run?
And for the db in "https://github.com/mikeyk/saveourfaves-server/blob/master/db/docker-compose.yml", I found out that the postgres-data folder is missing inside the db folder.
Thank you.

Hello @derwinwolf
Can you please help me to to setup this project ...
I am getting this error
psycopg2.OperationalError: could not connect to server: Connection refused
psycopg2.OperationalError: could not connect to server: Connection refused
Is the server running on host "<IP_ADDRESS>" and accepting
TCP/IP connections on port 5432?


upgrade to fastify 4.x

This works on my latest project on windows but haven't bothered to setup tests/commit hooks as I don't have the time to fix the setup

Sorry i have seen this a week ago but I am very busy with my life rn.
I'll merge and check this weekend, I'll create a release very soon.
Sorry again and thanks for the PR

i think @fastify/error should be installed as dependencies instead of devDependencies or whoever doesn't have it installed will fails

merged, released as<EMAIL_ADDRESS>sorry for delay


bug: java.lang.StringIndexOutOfBoundsException: begin 0, end 28, length 26

Cody Version
5.5.10
IDE Information
latest idea
Describe the bug
crash
Expected behavior
no crash
Additional context
Stacktrace:
java.lang.StringIndexOutOfBoundsException: begin 0, end 28, length 26
 at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4606)
 at java.base/java.lang.String.substring(String.java:2709)
 at com.sourcegraph.cody.autocomplete.CodyAutocompleteManager.displayAgentAutocomplete(CodyAutocompleteManager.kt:392)
 at com.sourcegraph.cody.autocomplete.CodyAutocompleteManager.processAutocompleteResult$lambda$16$lambda$15(CodyAutocompleteManager.kt:336)
 at com.intellij.openapi.command.WriteCommandAction.lambda$runWriteCommandAction$4(WriteCommandAction.java:338)
 at com.intellij.openapi.command.WriteCommandAction$BuilderImpl.lambda$doRunWriteCommandAction$1(WriteCommandAction.java:144)
 at com.intellij.openapi.application.impl.RwLockHolder.runWriteAction(RwLockHolder.kt:344)
 at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:883)
 at com.intellij.openapi.command.WriteCommandAction$BuilderImpl.lambda$doRunWriteCommandAction$2(WriteCommandAction.java:142)
 at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:225)
 at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:187)
 at com.intellij.openapi.command.WriteCommandAction$BuilderImpl.doRunWriteCommandAction(WriteCommandAction.java:151)
 at com.intellij.openapi.command.WriteCommandAction$BuilderImpl.run(WriteCommandAction.java:118)
 at com.intellij.openapi.command.WriteCommandAction.runWriteCommandAction(WriteCommandAction.java:338)
 at com.intellij.openapi.command.WriteCommandAction.runWriteCommandAction(WriteCommandAction.java:326)
 at com.sourcegraph.cody.autocomplete.CodyAutocompleteManager.processAutocompleteResult$lambda$16(CodyAutocompleteManager.kt:335)
 at com.intellij.openapi.application.TransactionGuardImpl.runWithWritingAllowed(TransactionGuardImpl.java:209)
 at com.intellij.openapi.application.TransactionGuardImpl.access$100(TransactionGuardImpl.java:22)
 at com.intellij.openapi.application.TransactionGuardImpl$1.run(TransactionGuardImpl.java:191)
 at com.intellij.openapi.application.impl.RwLockHolder.runIntendedWriteActionOnCurrentThread(RwLockHolder.kt:204)
 at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:830)
 at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:419)
 at com.intellij.openapi.application.impl.RwLockHolder.runWithEnabledImplicitRead(RwLockHolder.kt:138)
 at com.intellij.openapi.application.impl.RwLockHolder.runWithImplicitRead(RwLockHolder.kt:129)
 at com.intellij.openapi.application.impl.ApplicationImpl.runWithImplicitRead(ApplicationImpl.java:1152)
 at com.intellij.openapi.application.impl.FlushQueue.doRun(FlushQueue.java:81)
 at com.intellij.openapi.application.impl.FlushQueue.runNextEvent(FlushQueue.java:123)
 at com.intellij.openapi.application.impl.FlushQueue.flushNow(FlushQueue.java:43)
 at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
 at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:792)
 at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:739)
 at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:733)
 at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
 at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
 at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:761)
 at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.kt:699)
 at com.intellij.ide.IdeEventQueue._dispatchEvent$lambda$12(IdeEventQueue.kt:593)
 at com.intellij.openapi.application.impl.RwLockHolder.runWithoutImplicitRead(RwLockHolder.kt:105)
 at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.kt:593)
 at com.intellij.ide.IdeEventQueue.access$_dispatchEvent(IdeEventQueue.kt:77)
 at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:362)
 at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1$1.compute(IdeEventQueue.kt:361)
 at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:843)
 at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:361)
 at com.intellij.ide.IdeEventQueue$dispatchEvent$processEventRunnable$1$1.invoke(IdeEventQueue.kt:356)
 at com.intellij.ide.IdeEventQueueKt.performActivity$lambda$1(IdeEventQueue.kt:1022)
 at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:106)
 at com.intellij.ide.IdeEventQueueKt.performActivity(IdeEventQueue.kt:1022)
 at com.intellij.ide.IdeEventQueue.dispatchEvent$lambda$7(IdeEventQueue.kt:356)
 at com.intellij.openapi.application.impl.RwLockHolder.runIntendedWriteActionOnCurrentThread(RwLockHolder.kt:209)
 at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:830)
 at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.kt:398)
 at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
 at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
 at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
 at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
 at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
 at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)

Hi @Nopik 👋 I noticed you opened a few reports referencing the same issue. Can you please be more cautious and avoid opening the duplicates? It saves everybody's time and allows us to fix the problems more efficiently 🙏
Btw, what are the specific steps to reproduce this one?
Closing in favor of https://github.com/sourcegraph/jetbrains/issues/1519 - feel free to track and bump there.

@mkondratek
a) it happens randomly during the day when I work in IDE, no idea what is triggering it, have nothing to add
b) when your product is crashing 20+ times per day on me, I'm not going to invest time to compare all the stacktraces of code I do not know at all. Surely, maybe 1st line of stacktrace looks familiar, but that does not mean the whole stacktrace is meaningless. It is annoying enough that you've made the process of bug reporting having so many steps. I've reported maybe 10% of all crashes, when I was annoyed enough to survive your bug report form filing. In many cases when I click 'report bug' Idea opens like 15+ tabs for various bug reports from your plugin and I just gave up filling in all the meaningless fields, especially that I do not know what specifically triggered those, so I have nothing to add. Overall the unstability of the plugin makes usage of your product quite frustrating.

Thanks for more details. This is very interesting - I have not encountered this issue (yet).

Can you please update the plugin to the latest version which is 6.0.3?
Can you tell what feature are you using most frequently? If it happens so frequently to you, and refers strings & ranges I'd assume this is a problem with autocompletion. Maybe there is something specific to your setup?

Just realised - I am happy to inform you that this issue is fixed in the latest version 😃 it has been fixed soon after being reported by https://github.com/sourcegraph/jetbrains/pull/1506 - pls try to keep it up to date 😉

Yes, I've installed it yesterday. So far no crashes, which is a good sign. The new 'edit code' feature didn't worked on first try, though - I tested it on a fairly big file (70kb) and it was spinning forever. When I tried to cancel after like 5 minutes, it did not canceled, the cancel button was pretty unresponsive. I tried to issue another prompt on another file, but it said something like 'cody is starting' and refused to work. I was forced to restart IDE. Afterwards I tested with smaller data, and it worked.
The feature is extremely slow, though, I would strongly recommend adding some progress bar, if you can. The prompt editor is extremely weird as well. Editing long prompt I cant jump to beginning of line, it feels like a big wrapped line, so it jumps to the begining of prompt.

I.e. while I'm in my IDE and I'm editing multi-line text, muscle memory kicks in. If some dialog does not follow keybindings from the rest of IDE, it will always feel very strange.

Good to read it fixed this issue.
We are aware about the problems with big files - we are working on it (https://github.com/sourcegraph/jetbrains/issues/1721). Sorry for the inconvenience.
Thanks for the feedback on prompt text area - this is a good point too.


Min Max months start at 0 for January

$('.datepicker').pickadate({   min: [2015,3,20],   max: [2015,7,14] })
is actually min: [2015, April, 20], max: [2015, August, 14].

If you have tickets for pickadate, please post them on https://github.com/amsul/pickadate.js. This repo is just a Rails wrapper for pickadate, not the library itself.


does not work on iphone

parallax doesn't work for me on iphone? both in safari and chrome, but on android and computer everything is fine?

I understood the reason, if the photo is in the position absolute, then the parallax does not work on the iPhone and apple, but I still don’t know how to solve it

It's not the iPhone, it's a Safari issue ( transform: translate3d(0px, 514px, 0px) not changing). Only when the element is in absolute position.

Do you have a reproduction so i can check? The website is working fine on both Safari desktop and mobile.


IP is forbidden.

The request filed because of IP range changed.
(
    [code] => wp_die
    [message] => リクエストが不正なIPから行われています: <IP_ADDRESS>
    [data] => stdClass Object
        (
            [status] => 403
        )

    [additional_errors] => Array
        (
        )
)

Github IP range is listed here.
https://api.github.com/meta


Is debounce supported?

Hello!, is debounce supported?, tryed to implement it with lodash but it seems that is tight coupled with the component.

@nschurmann  Thank you for opening this issue!
Not currently, but we should add support for that 👍 I'll put that on my todo list. Feel free to submit a PR if you are interested.

Now is supported, please @kenny-hibino check my pull request.


NaN in text report

If a file with no type at all, flow-coverage-report returns this result line:
src/url.js                          │   NaN % │     7 │       0 │         7

I first thought it was a division by 0, but then realised that's the other way around.
Maybe unrelated, but when I then try to generate an html report, I get:
(node:54292) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Missing percent in coverageData
(node:54292) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

For reference, here is the content of the src/url.js file:
// @flow

const url: any = window.URL || window.webkitURL || window.mozURL

export default url

A fix for this issue has been merged in #61 and release on npm in the new version 0.4.0
Feel free to re-open if you are still experiencing this issue.


[featrue] supply alibaba cloud  database  for redis

What problem are you facing?
supply alibaba cloud  database  for redis
How could Crossplane help solve your problem?

/assign

Refer to #67

@xiqiu618 @zzxwill
I see the task is pending for lacking of test cases, is this enhancement still in progress  ?

@hzlml The PR is merged.
Could anyone help close this issue? Thanks.

closing as it's supported now


Bug in parsing or emitting Extract function

Hi,
I have a SQL statement that contains
GROUP BY EXTRACT(MONTH FROM issue_date)
After parsing this statement and writing the AST using String() on the root node, it returns an invalid function call section:
GROUP BY extract('month', issue_date)

Looks like extract could become a special node type in tree pkg
https://www.postgresqltutorial.com/postgresql-date-functions/postgresql-extract/

as a workaround, I am patching the AST to replace the func argument with instance of this
type ExtractArg struct {
	Field *tree.StrVal
	From  tree.Expr
}

func (e *ExtractArg) Walk(v tree.Visitor) tree.Expr {
	field, fieldChanged := tree.WalkExpr(v, e.Field)
	from, fromChanged := tree.WalkExpr(v, e.From)
	if fieldChanged || fromChanged {
		exprCopy := *e
		exprCopy.Field = field.(*tree.StrVal) //assume type not changing
		exprCopy.From = from
		return &exprCopy
	}
	return e
}
func (e *ExtractArg) TypeCheck(ctx *tree.SemaContext, desired *types.T) (tree.TypedExpr, error) {
	// assume field that extracts numbers
	nr := tree.NewNumVal(constant.MakeInt64(0), strconv.Itoa(0), false)
	return nr.TypeCheck(ctx, desired)
}
func (e *ExtractArg) String() string {
	return fmt.Sprintf("extract(%v from %v)", e.Field, e.From)
}
func (e *ExtractArg) Format(ctx *tree.FmtCtx) {
	ctx.WriteString(strings.ToUpper(e.Field.RawString()))
	ctx.WriteString(" FROM ")
	ctx.FormatNode(e.From)
}

As the whole parser is mostly part of cockroachdb parser, cockroachdb treats EXTRACT(<part> FROM <value>) equal as function extract("<part>", <value>).
Your workaround is excellent. Could you please submit a Pull Request for this patch?
https://www.cockroachlabs.com/docs/stable/functions-and-operators.html#special-syntax-forms


Module 2 exercises [KUULARA PAAPA WILLIAMS]

WS2_M2E2_Submission.docx

Well done, Kuulara. You clearly grasped the material outlined in Module 2 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


Added JSON support to all modes

Also fixed #68

Pull Request Test Coverage Report for Build 147

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
2192 unchanged lines in 36 files lost coverage.
Overall coverage decreased (-4.07%) to 73.507%

Files with Coverage Reduction
New Missed Lines
%

block_preds.rs
4
100.0%

file_writer.rs
5
59.68%

cli_check.rs
7
46.43%

file_reader.rs
8
81.67%

file_error.rs
8
24.24%

cli_show.rs
8
45.45%

integer_utils.rs
9
56.25%

general_error.rs
13
65.0%

main.rs
15
90.63%

cli_decode.rs
16
96.88%

Totals

Change from base Build 145:
-4.07%

Covered Lines:
2855

Relevant Lines:
3884

💛  - Coveralls

Codecov Report

Merging #70 into master will decrease coverage by 3.86%.
The diff coverage is 49.44%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   77.57%   73.71%   -3.87%
==========================================
  Files          40       42       +2
  Lines        3550     3884     +334
==========================================
+ Hits         2754     2863     +109
- Misses        796     1021     +225

Impacted Files
Coverage Δ

src/misc_utils.rs
63.57% <0%> (-22.14%)
:arrow_down:

src/check_core.rs
0% <0%> (ø)
:arrow_up:

src/show_core.rs
0% <0%> (ø)
:arrow_up:

src/json_utils.rs
0% <0%> (ø)

src/main.rs
90.62% <0%> (ø)
:arrow_up:

src/rescue_core.rs
82.85% <100%> (+1.46%)
:arrow_up:

src/cli_show.rs
45.45% <11.11%> (+0.29%)
:arrow_up:

src/cli_check.rs
46.42% <12.5%> (+0.27%)
:arrow_up:

src/json_printer.rs
27.45% <27.45%> (ø)

src/cli_utils.rs
75.67% <28.57%> (-11%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3587821...e4af4d9. Read the comment docs.


Can I use this as a directive?

I am trying to build a functional components and using this package as a directive for that functional components. Can I?

Sure. I haven't had the time to update this yet. Vue 3 came out a couple of months ago and seems to have different loading strategies, so I wouldn't advise you to base anything you'd want to support Vue 3 on my current package.


test: update ethereumjs util to v7

Pull Request Test Coverage Report for Build 108434997

5 of 6 (83.33%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 83.087%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/thirdparty.ts
3
4
75.0%

Files with Coverage Reduction
New Missed Lines
%

src/index.ts
1
86.62%

Totals

Change from base Build 108434241:
-0.4%

Covered Lines:
263

Relevant Lines:
304

💛  - Coveralls


Work in browser

It's necessary for correct work in browser:

Rewrite all code to ES5 or use Babel for transpiling code to ES5
Add loader for browsers (that don't provide module.exports)

Can you create PR for it?


add availabilityProfile for 2017-01-31 and 2016-09-30

This change is

I ended up changed more files than i need. That is because currently the make ci is broken. I corrected some test files.

@acs-bot test this please