[Improvement][*] Refactor code to fix code smell and vulnerability

What is the purpose of the pull request
This pull request fixes some of the code smell and vulnerability reported by sonar
Fixes #3325
Brief change log

Refactor files to fix code smell and vulnerability reported by sonar

Verify this pull request
This pull request is code cleanup without any test coverage.

Hi, has this function been completed? If completed, please let me know, and I will start review.thx

Yeah, still working on it. Will make it ready for review as soon as I'm done which should be very soon

Hi @CalvinKirs, @dailidong, @djkevincr, this PR is ready for review

Hi @CalvinKirs, @dailidong, @djkevincr, this PR is ready for review

deeply thanks you  for your contribution, but there are some conflicting files you need to deal with

Hi @CalvinKirs, @dailidong, @djkevincr, this PR is ready for review

deeply thanks you  for your contribution, but there are some conflicting files you need to deal with

Hi @CalvinKirs, I have resolved the conflict but a test is failing, "testGenExcelFileByCheckDir()" method of the ExelUtilsTest file from the alert project. Is that normal? as I don't think it's failing because of the refactoring I did

Hi @CalvinKirs, I have resolved the conflict but a test is failing, "testGenExcelFileByCheckDir()" method of the ExelUtilsTest file from the alert project. Is that normal? as I don't think it's failing because of the refactoring I did

Codecov Report

Merging #4299 (7cd433c) into dev (46443a6) will decrease coverage by 0.34%.
The diff coverage is 30.17%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46443a6...7cd433c. Read the comment docs.

Codecov Report

Merging #4299 (7cd433c) into dev (46443a6) will decrease coverage by 0.34%.
The diff coverage is 30.17%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46443a6...7cd433c. Read the comment docs.

Hi @CalvinKirs, I have updated the codebase to fix the conflict

Hi @CalvinKirs, I have updated the codebase to fix the conflict

hi, very good, but I noticed that Sonar check fail, it shows the presence of 5 Bugs ,
50 Vulnerabilities(B),
23 Code Smells(A).
Can you fix it first?

hi, very good, but I noticed that Sonar check fail, it shows the presence of 5 Bugs ,
50 Vulnerabilities(B),
23 Code Smells(A).
Can you fix it first?

Yes, I'll do that

Yes, I'll do that

Hi @CalvinKirs, the 3 remaining bugs are from the DAG file in the common project. Three fields are declared with the volatile keyword and they are what sonarcloud tags as bugs. Can I remove the volatile keyword or is there a better way to make it work?
I'm also trying to increase the code coverage to get it over 33% but there are some tests that are ignored are not letting the codes I added to get covered. Please advice about what to do here.
The 53 vulnerabilities are from files I refactored to fix code vulnerabilities previously reported by sonar. It stills complain about them even though I have fixed them. Is there a way for me to fix this?
I'll really appreciate your guidance here. Thanks.

Hi @CalvinKirs, the 3 remaining bugs are from the DAG file in the common project. Three fields are declared with the volatile keyword and they are what sonarcloud tags as bugs. Can I remove the volatile keyword or is there a better way to make it work?
I'm also trying to increase the code coverage to get it over 33% but there are some tests that are ignored are not letting the codes I added to get covered. Please advice about what to do here.
The 53 vulnerabilities are from files I refactored to fix code vulnerabilities previously reported by sonar. It stills complain about them even though I have fixed them. Is there a way for me to fix this?
I'll really appreciate your guidance here. Thanks.

Hi @CalvinKirs, the 3 remaining bugs are from the DAG file in the common project. Three fields are declared with the volatile keyword and they are what sonarcloud tags as bugs. Can I remove the volatile keyword or is there a better way to make it work?
I'm also trying to increase the code coverage to get it over 33% but there are some tests that are ignored are not letting the codes I added to get covered. Please advice about what to do here.
The 53 vulnerabilities are from files I refactored to fix code vulnerabilities previously reported by sonar. It stills complain about them even though I have fixed them. Is there a way for me to fix this?
I'll really appreciate your guidance here. Thanks.

If it is convenient, it is recommended to split into multiple PRs for submission.

Hi @CalvinKirs, the 3 remaining bugs are from the DAG file in the common project. Three fields are declared with the volatile keyword and they are what sonarcloud tags as bugs. Can I remove the volatile keyword or is there a better way to make it work?
I'm also trying to increase the code coverage to get it over 33% but there are some tests that are ignored are not letting the codes I added to get covered. Please advice about what to do here.
The 53 vulnerabilities are from files I refactored to fix code vulnerabilities previously reported by sonar. It stills complain about them even though I have fixed them. Is there a way for me to fix this?
I'll really appreciate your guidance here. Thanks.

If it is convenient, it is recommended to split into multiple PRs for submission.

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

hi, @Segun-Ogundipe , good job,  it will better to split this PR  to multi prs,  don't change so many files in one PR , it's better not to exceed 20 files in one PR , so I will close this PR , please submit new PRs, thx
By the way,  I'm sorry for deleting AlertGroupController.java by mistake when I  review these files.

hi, @Segun-Ogundipe , good job,  it will better to split this PR  to multi prs,  don't change so many files in one PR , it's better not to exceed 20 files in one PR , so I will close this PR , please submit new PRs, thx
By the way,  I'm sorry for deleting AlertGroupController.java by mistake when I  review these files.

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

you can split it according the module, like dolphinscheduler-alert、dolphinscheduler-api and so on.  just remember don't includes too many files in one PR. because review these files will be difficult

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

you can split it according the module, like dolphinscheduler-alert、dolphinscheduler-api and so on.  just remember don't includes too many files in one PR. because review these files will be difficult

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

you can split it according the module, like dolphinscheduler-alert、dolphinscheduler-api and so on. just remember don't includes too many files in one PR. because review these files will be difficult
please contact me<EMAIL_ADDRESS>when meeting any problem

Thanks for the explanation. I'll get right on it

What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?

you can split it according the module, like dolphinscheduler-alert、dolphinscheduler-api and so on. just remember don't includes too many files in one PR. because review these files will be difficult
please contact me<EMAIL_ADDRESS>when meeting any problem

Thanks for the explanation. I'll get right on it


Colors

This is not a bug but how can we change the colors or icons and slider ?

Sorry i only see this now, i could create a version where the color come from the configuration, icons and sliders only ?

Can confirm, i only have 2 colors still displaying out of 4, will look into it this week-end, sorry everyone for the long period without updates/fixes. i mostly use gitlab now so i did not see all the notifications

Fixed in the next release


Install Kaoto README has missing file and typo

https://raw.githubusercontent.com/KaotoIO/kaoto-operator/main/kubernetes/kaoto.yaml - File does not exist
kubect should be kubectl

Thanks for reporting this @victorchapman , we'll take a look :)


Code hash error when attempting to generate full address from private key.

Error: '0x00' is not a valid code hash
    at toAddressPayload (/home/username/testing/node_modules/@nervosnetwork/ckb-sdk-utils/lib/address/index.js:57:15)
    at bech32Address (/home/username/testing/node_modules/@nervosnetwork/ckb-sdk-utils/lib/address/index.js:69:210)
    at pubkeyToAddress (/home/username/testing/node_modules/@nervosnetwork/ckb-sdk-utils/lib/address/index.js:75:38)
    at privateKeyToAddress (/home/username/testing/node_modules/@nervosnetwork/ckb-sdk-utils/lib/index.js:55:84)
    at Object.<anonymous> (/home/username/testing/index.js:5:57)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)

index.ts:
import {AddressPrefix, AddressType, privateKeyToAddress} from '@nervosnetwork/ckb-sdk-utils';

const PRIVATE_KEY = '0xcd708059624d8301382972808b3e504b5ea3d94e210edf229f48cadcb8fe0989';

const address = privateKeyToAddress(PRIVATE_KEY, {prefix: AddressPrefix.Testnet, type: AddressType.FullVersion});

console.log(address);

How to run contents of test.zip:
npm i
npx tsc
nodejs index.js

test.zip

Thanks @jordanmack , the bug is located and will be fixed today.

Fix was committed in https://github.com/nervosnetwork/ckb-sdk-js/pull/587

Released with v0.103.0


How to erase the temporary windows iso?

Hi everyone! Im testing windows 7 and works with no problems, but when i run 'docker compose down' and 'docker system prune --all' it is erase containers and images, but no erase the downloaded windows iso and its occuping 10Gb on my ssd and i have no idea where find this iso, someone can help me?
Im using ubuntu 22.04 and docker 24.0.6
this is my docker compose
version: "3"
services:
  windows:
    image: dockurr/windows
    container_name: windows
    environment:
      VERSION: "win7"
    devices:
      - /dev/kvm
    cap_add:
      - NET_ADMIN
    ports:
      - 8006:8006
      - 3389:3389/tcp
      - 3389:3389/udp
    stop_grace_period: 2m
    restart: on-failure

@kroese Thank you very a lot! Solve my problem!


'DATA_CASE' not found in parameters.yaml

I am trying to execute this sequence of commands to change the parameters in the parameters.yaml file as described in this tutorial https://seisflows.readthedocs.io/en/latest/2D_example_walkthrough.html.
I got this error for 'DATA_CASE' parameter. I am wondering if I am using an older version of the software. It worked for the other parameters.
seisflows par ntask 3  # set the number of sources/events to use
seisflows par materials elastic  # update Vp and Vs during inversion
seisflows par end 2  # final iteration -- we will only run 1
seisflows par data_case synthetic  # synthetic-synthetic means we need both INIT and TRUE models
seisflows par components Y  # this default example creates Y-component seismograms
seisflows par step_count_max 5  # limit the number of steps in the line search

(myseisflows) ANayak-M13:practise_seisflows anayak$ seisflows par data_case synthetic
'DATA_CASE' not found in parameters.yaml

Hi @avinash07guddu, this may be related to my response in #183, can you try out the master branch first and see if the problem persists?

Hello, v3.0.0 version, use the "seisflows init" command to create parameters.yaml, and "'DATA_CASE' not found in parameters.yaml" still appears, how can I solve it?

@DEnan13132 I have responded to you in #201
@avinash07guddu I think you mentioned in an email that this solved your problem, is it alright if we close this issue?

Closing for inactivity, please open a new issue if you are still having trouble here!


 Should be at least DEBUG1

done
@alubennikova FYI

@arssher some PR for this ? can I see how to set log level for compute ?

It is so trivial that I pushed directly:
https://github.com/zenithdb/postgres/commit/eded7571a30fd901dac85daccda789337d5be668
That changes log level for this concrete place. Generally you change guc log_min_messages, as usual.


Fixing the PTB data set 404 issue

PyTorch had to remove the PTB data set from their repo which broke our getdata.sh script. I'm now downloading it directly from Mikolov's website, and doing some book-keeping on top.

LGTM :)


added viewMode and minViewMode options

added viewMode and minViewMode options in code and also added html in demo.html file

Please help me to remove "revert" or omit it. Only use "update" commit.

now the feature is the same here https://eonasdan.github.io/bootstrap-datetimepicker/#min-view-mode

now the feature is the same here https://eonasdan.github.io/bootstrap-datetimepicker/#min-view-mode

Please only use first commit, omit Revert. Sorry i'm not pro in git.


chore(docs): Rename user password doc

Since we now urge users to change their password if they install Bazzite without a physical keyboard, the name of this documentation is misleading.  This is strictly if the user forgets their password.

Redoing this GRRRRRRRRRR


Fixing issueno21

scrollLeft and scrollTop passed from template are now respected. relevant test is added. upgraded to ember 2.16.

@imanhodjaev we are ready for 0.1.17 after this is merged. we have fixed #21 and after this merge; we can reject #16 pull request. The reason is we can take scrollLeft and scrollTop from outside and we now dispatch new scroll positions with scrolling events thanks to #20 pull request. Pull request #16 was trying to make a 2-way-binding with "scrollLeft" and "scrollTop" properties. Instead of that; we preffered one-way-binding (via taking initial values) and dispatching events; that is in fact "Data Down Action Up" motto  in action.


docs: add missing quote

Not sure why one of the tests is failing, seems unrelated to this PR.

Not sure why one of the tests is failing, seems unrelated to this PR.

Yes, you're correct. The hooks tests are a bit flakey on CI specifically right now. A few contributors have been trying to fix them (including me) with limited success


Send version along with handshake response

I think, we should internally have protocol version, rather than reuse Rbkit version for this. That way, Rbkit version can be independently changed as long as protocol version remains the same.

Lets think of it like, no matter which nginx version I am running as long as it can speak http1.1 the browser can display the content.


Update marked to v1.0.0

There is an stable version:
https://github.com/markedjs/marked/releases/tag/v1.0.0

Thanks for letting me know! Will test it and update as part of next release.

Done by 97e8f10


Firebase integration

Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

I created a new class for Firebase Real Time Database and Firestore as I mentioned on https://github.com/google/boardgame.io/issues/6#issuecomment-397820990. It is basically same as MongoDB.
The problem is I have so little experience (practically not at all) with testing. Because of this I was not able to keep up with the test coverage percentage. Like I did on Firebase class, I basically copy the work done for MongoDB tests for RTDB and Firestore. I really appreciate some help about tests.

Coverage decreased (-0.2%) to 99.84% when pulling 5919fa1629797e3fb846e3593601a4b1ffe4e633 on bennygenel:fb-integration into 10abff09875324e5faa21be7f262ccc8a86dc483 on google:master.

Thanks @bennygenel! I can definitely help with the tests.
db.js looks a bit crowded now. Do you think it makes sense to now split it into the following?
src/server/db/memory.js
src/server/db/mongo.js
src/server/db/firebase.js

Thanks for the help @nicolodavis
I agree since tests are getting crowded too and separating them too might help.
Quick question;
What do you think on adding support for MySQL, Postgres and SQLite with sequelize since all of them support JSON data types?
I know it might not be ideal to store complete JSONs in fields but since we get/set complete state from database, separating fields might not be that important.

Adding support for MySQL / Postgres etc. is a good idea. That should give people more options for hosting.

How do you suggest on doing that then? Same as Firebase and Mongo perhaps?
Another question @nicolodavis;
Is my last commit ok? I added Firebase to packages/server.js but I'm not sure if I should have.

@bennygenel About SQL, yeah, let's follow a similar pattern to firebase / mongo.

Should SQL integration be a different PR or should I continue here?

@bennygenel Let's do SQL in a separate PR. Thanks so much for volunteering to do this!

I'll take another look at this sometime this weekend. Thanks for the PR again.

@nicoladavis no problem. I started SQL integration too. I'll finish it up this weekend too.

I don't know if I'm doing this wrong or not, but I got this problem:
FirebaseError: [code=invalid-argument]: Function DocumentReference.set() called with invalid data. Nested arrays are not supported
I found it in the terminal window that I used to run the server for the multiplayer of my game, and I'm trying to integrate my Firebase project with my game so when I deploy it, everyone's stats and data will be synced to Firebase (I'm also thinking about adding in a system for tracking wins too).


OSError: 401 insufficient permissions (not registered)c

OSError: 401 insufficient permissions (not registered)
can seem to connect even after i registered and the access token stored in the store

Have the same problem after regitration pattern

Can you please elaborate? What is the environment: TV model, web os version, python version, library version, minimal+verifiable code to reproduce the issue? Have you tried removing all previous registrations and tried re-registering?  Factory reset? Can you control the TV via LG's app?

Hello !
Thank you for answering, LGC2, webOs Version To check (Soory), Python 3.7.5, Library to check (Sorry x2).
Already reset all systems, control from LG App si ok.
My question is more than, how do you connect to TV with registration? For exemple on aiowebostv lib, I found:
client = WebOsClient(HOST, CLIENT_KEY)
It generate a connection with a Key. On PyWebOSTV, I didn't found this type of pattern (Examples, snippets). So I'm not sure I haven't forgotten something on documentation or during code reading.
My registration Function working (Key is stored):
`client = WebOSClient(HOST)
client.connect()
if key == "":
key = {}
logging.info("No Key Found - Registering")
for status in client.register(key):
print(status)
if status == WebOSClient.PROMPTED:
logging.info(f"Waiting Acceptation from User")
    elif status == WebOSClient.REGISTERED:
        logging.info(f"Registration successful: {key}")
        with open(Key_file, 'w') as f:
            json.dump(key, f)
    else:
        logging.info("Error in Registration")

else:
key = json.loads(key)
logging.info("Key Founded")`

Thank you for help

I just looked at aiopylgtv repository. The registration payload seems to be identical. Actually, this repo has a superset of fields than that one. Can you confirm if aiopylgtv repo works? If that one works, and this repo doesn't then it's definitely a bug which we need to fit.

Thanks for answer.
On aiopylgtv I use generated key by PyWebOSTV to do my tests.
This aiopylgtv snippet works I retreive Powerstate and all infos:
"""Subscribe State Updates Example."""
client = WebOsClient(HOST, CLIENT_KEY)
await client.register_state_update_callback(on_state_change)
await client.connect()

# Store this key for future use
print(f"Client key: {client.client_key}")

# Change something using the remote during sleep period to get updates
#await asyncio.sleep(10)
await client.disconnect()

It calls:
async def on_state_change(client):
"""State changed callback."""
print("State changed:")
print(f"System info: {client.system_info}")
print(f"Software info: {client.software_info}")
print(f"Hello info: {client.hello_info}")
print(f"Channel info: {client.channel_info}")
print(f"Apps: {client.apps}")
print(f"Inputs: {client.inputs}")
print(f"Powered on: {client.power_state}")
print(f"App Id: {client.current_app_id}")
print(f"Channels: {client.channels}")
print(f"Current channel: {client.current_channel}")
print(f"Muted: {client.muted}")
print(f"Volume: {client.volume}")
print(f"Sound output: {client.sound_output}")
On PyWebOSTV -> client = WebOSClient(HOST, CLIENT_KEY) Return python error "3 args given, for 2 attended"
If i can help you don't hesitate

I can try a code snippet if you want give one, like a register a connection and a system test message

client = WebOSClient(HOST)
client.connect()
if key == "":
key = {}
logging.info("No Key Found - Registering")
for status in client.register(key):
print(status)
if status == WebOSClient.PROMPTED:
logging.info(f"Waiting Acceptation from User")
    elif status == WebOSClient.REGISTERED:
        logging.info(f"Registration successful: {key}")
        with open(Key_file, 'w') as f:
            json.dump(key, f)
    else:
        logging.info("Error in Registration")

else:
key = json.loads(key)

Sorry, I missed going through this snippet. There's a problem here. client.register needs to be called everytime, even if you already have the key from the previous registration. Please go through the README. Please modify the sample code to  work with your custom storage which in this case is json.load(..), and json.dump(..).

Hi, i've the same issue. I don't know what i'm doing wrong...
I have 2 method for 1st registering, then to connect to the already registered equipment. (It's a LG WebOS TV 43UM7050PLF)
Following the registering method:
def register(name:str, ip:str="") -> WebOSClient:
    api:APIObject = APIObject(name, ip)
    if ip != "":
        client = WebOSClient(ip, secure=True)
    else:
        client = WebOSClient().discover()[0] # take first, sould improve it to get a list of equipment, then choose the right one

    store = {}
    client.connect() # start the connection

    for status in client.register(store):
        if status == WebOSClient.PROMPTED: # requested to valid the connection on the equipment
            print(f"Please accept the connection on the '{name}' equipment")
        elif status == WebOSClient.REGISTERED: # registered
            api.api_key = store["client_key"]
            print(f"New equipment '{name}' just registered")

    return client

The connect method:
def connect(api_obj:APIObject) -> WebOSClient:
    if api_obj is None or not api_obj.registered:
        return None # unable to connect to the equipment

    client:WebOSClient = None
    print(api_obj.api_key)
    store={"client_key": api_obj.api_key}

    try:
        client = WebOSClient(api_obj.ip, secure=True)
        client.connect()
        client.register(store)
    except:
        print("Can't connect to the equipment")
        print(store)
    return client

My APIObject is just a class which allows me to easily read/write into my storage file, it looks like:
{
    "name": "TV",
    "ip": "<IP_ADDRESS>",
    "api_key": "613738960ad2334e45c3a4c801e10dd7"
}

The registering method is perfect, the issue is the 'connect' method which doesn't accept to register to the equipment with the api_key value.
when I try to start a 'notify' control with the 'connect' method, I have the 401 issue.
If I directly try to 'notiify' on my TV screen, directly after a 'register' method, it correctly works.
So I think the issue is inside the 'connect' one. but I can't see any mistake I could do...
Sorry, but I'm actually blocked now...

I found, but why i need to browse the status in the register function even if i don't need to wait for the equipment validation ?


Fix a bug that cause maximum/minimum validation bad error message, refs #81

When we have the following schema:
"x":{
"type":"integer",
"minimum": 0
}
when we need to validate json like x:-1, it will raise the error like x: Must be greater than %min%".
Maximum also has the same bug.
Issue#81 also logged this bug.

Hi xeipuuv,
Thanks for your quick response.
I also found another bug: https://github.com/xeipuuv/gojsonschema/issues/86.
Because according to
http://json-schema.org/latest/json-schema-validation.html#anchor21, If
exclusiveMinimum is absent, that equals to "exclusiveMinimum: false".
And I tried to fix it here: https://github.com/xeipuuv/gojsonschema/pull/88
So could help me review it again, please?
Thanks,
Lyle Xu
2015-11-18 17:59 GMT+08:00 xeipuuv<EMAIL_ADDRESS>
Merged #85 https://github.com/xeipuuv/gojsonschema/pull/85.
—
Reply to this email directly or view it on GitHub
https://github.com/xeipuuv/gojsonschema/pull/85#event-467749664.


Registry types inconsistency

Encoder generate_latest (for example) accepts registry of CollectorRegistry type but it doesn't accept registry of RestrictedRegistry type so it is not consistent. I guess RestrictedRegistry class should inherit CollectorRegistry class because instance of it can be passed to encoders (maybe not only encoders).
Another option is to inherit RestrictedRegistry class from Collector class because CollectorRegistry is inherited from this class, but then anything that accepts CollectorRegistry type should be changed to accept Collector type.

Yes, we should improve the type consistency here. Probably everything should be changed to the Collector type, which would ideally be a Protocol rather than enforcing inheritance. The problem with using a Protocol is that older versions of python would need to depend on typing-extensions and this client currently has no dependencies. Perhaps typing-extensions is widespread enough that would be ok though?


Does this still work? I really would like to use it, or pick up the dev myself!

Last I checked, over a year ago ago, I saw the auth needed attention, emailed support and got a reply saying this API wasn't an officially supported integration but should still work. Not tested it further yet. I was testing with curl:
curl -sX POST 'https://api.nirvanahq.com/?api=rest' -d "method=auth.new&u=USERNAME&p=MD5_OF_PASSWORD"

but got auth failures. Would love to get this working - currently the only way I can integrate (in my case with with Obsidian.md) is by export to JSON/XML - not great.
If the auth can be fixed this would probably be viable still. The support email mentioned they had some heuristics to block potential attacks, I was looking at debugging the network traffic used by the webapp. If you have get anywhere with it please do post here!
Happy hacking,
T

any progress on this ?


LDAP require certificate error

Hi,
I am having trouble making my app work with LDAP. When I set LDAP_REQUIRE_CERT' and  LDAP_CERT_PATH' ... I get the following error when running the app:
Traceback (most recent call last):
  File "app.py", line 27, in <module>
    ldap = LDAP(app)
  File "/opt/conda/envs/flask/lib/python3.6/site-packages/flask_simpleldap/__init__.py", line 27, in __init__
    self.init_app(app)
  File "/opt/conda/envs/flask/lib/python3.6/site-packages/flask_simpleldap/__init__.py", line 73, in init_app
    current_app.config['LDAP_CERT_PATH'])
  File "/opt/conda/envs/flask/lib/python3.6/site-packages/werkzeug/local.py", line 347, in __getattr__
    return getattr(self._get_current_object(), name)
  File "/opt/conda/envs/flask/lib/python3.6/site-packages/werkzeug/local.py", line 306, in _get_current_object
    return self.__local()
  File "/opt/conda/envs/flask/lib/python3.6/site-packages/flask/globals.py", line 51, in _find_app
    raise RuntimeError(_app_ctx_err_msg)
RuntimeError: Working outside of application context.

Do you know how I can solve the problem?
I am using Python 3.6 and flask-simpleldap 1.1.2

Hi,
Which version of Flask are you using? Does it work if you don't pass those two options?

Hi,
I am using Flask v0.12.2. If I don't pass those options I don't get the error, but I think it was still not working. I will check again later this week without those options and let you know.

Hi,
Could this be reopened?
I am seeing the same error.
Have a working setup using ldap.
When I try and switch to ldaps using:
app.config['LDAP_SCHEMA'] = 'ldaps'
app.config['LDAP_PORT'] = '636'
app.config['LDAP_USE_SSL'] = 'True'
app.config['LDAP_REQUIRE_CERT'] = 'True'
app.config['LDAP_CERT_PATH'] = 'ca.crt'
I get the error
RuntimeError: Working outside of application context.
This typically means that you attempted to use functionality that needed
to interface with the current application object in some way. To solve
this, set up an application context with app.app_context().  See the
documentation for more information.
I'm using
Python 3.8
Flask 1.1.1
Flask-SimpleLDAP 1.4.0

Exactly the same for me. But using Python 3.6


Feature - Button "Clone View"

Really needs for speed up work

@AleksandrSokolov  This has just been implemented in the most recent release from today - i think you just missed it.  do a npm install -g<EMAIL_ADDRESS>--unsafe to install

@glutamate Thanks!!!


Workflow Manager - Life cycle

[ ] Investigate and Design - Figure out how to create orchestration workflow in Jenkins, how can multiple independent jobs be stitched under one id (and individual job ids), how can orchestration framework provide inputs for each jobs and trigger them, etc.
[ ] Coordinate with build automation team to define Manifest .
[ ] Build the orchestration layer that stitches together multiple independent jenkins jobs like integration, performance, upgrade testing. Publish logs to investigate failure scenarios

Updated w/ below sub-tasks

[ ] Investigate and Design - Figure out how to create orchestration workflow in Jenkins, how can multiple independent jobs be stitched under one id (and individual job ids), how can orchestration framework provide inputs for each jobs and trigger them, etc.
[ ] Coordinate with build automation team to define Manifest .
[ ] Build the orchestration layer that stitches together multiple independent jenkins jobs like integration, performance, upgrade testing. Publish logs to investigate failure scenarios

What do we do with this issue @saratvemulapalli?

Good question, @setiah I see most of these pieces are done except reporting the results and we have other issues to take care of that.
Do you have anything else to cover here or could we close this down?

@saratvemulapalli Are you still working on this issue, or has this been rolled up into another change?

This is rolled up to #262 and #263.
Will close this, thanks guys!


Ensure there are no races in ThreadDeathWatcher, related to [#6062]

Motivation:
We used a MPSC queue in ThreadDeathWatcher and checked if it empty via isEmpty() from multiple threads if very unlucky. Depending on the implementation this is not safe and may even produce things like live-locks.
Modification:

Change to use a MPSP queue
Some simplifications

Result:
No more risk to run into issues when multiple threads call watch(...) / unwatch(...) concurrently.

@Scottmitch FYI... I was thinking how to improve the awaitInactivity to be less racy but could not come up with anything good.

let me close this for now and come-up with something better once I have time


ci: release to Prod stable on prod push

Push to prod stable as well as Prod beta

Failure not related, merging so we are ready :+1:


refactor Remove deprecated statistics related codes

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.07 seconds
load time: 448 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221204032822_clickbench_pr_57330.html


toolbar image cleanup - my co tags

replaced toolbar image with font icons
changed actions to buttons

@miq-bot add_label ui, enhancement


Dataflow Violation

https://github.com/hhu-propra2/abschlussprojekt-mopse/blob/89355abed003d99f74059d0080d8743421c65f9a/src/main/java/mops/presentation/FileController.java#L102
Isn't that a dataflow violation. Wouldn't
Directory dir;

do the trick?

Yes - if I remember correctly there are warnings when using a "not-initialized" variable, which is why we default set it to null.


Migrate Angola holidays to holiday groups

Proposed change

Migrate Angola holidays to holiday groups
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

coverage: 99.991%. remained the same when pulling<PHONE_NUMBER>12d4dfd5a3fdfb4cce8d082a3a1485 on kasya:angola-holiday-groups into 3512c9b66b41a4652953c361c668d7bd6323de01 on dr-prodigy:beta.

It has been merged into beta. Thank you for the contribution! 👍


Browsersupport -> Readme

Nice lib. Will try it out when i know browser-support. Did you test it?
Thank you.
K

Hope you like RE:DOM! If you have any questions, I'm happy to answer 😉


Allow users to authenticate with Google OAuth

We currently support a limited GitHub OAuth for logging in and unlocking some features (e.g., sharing, being able to invoke certain API functions on CloudFlare, etc).  It would be good to also allow users to use their Google account.

I wanna try this one.

@WangGithub0 excellent.  I'm not 100% sure what's involved with doing this.  I suspect that @tarasglek is going to need to set up some kind of "app" with Google, which configured the accepted URL endpoints.
Probably the first step for you is to add a list of all the steps we need to do in this issue.

Let me know what I need to help with here. I think anyone can setup auth with google using own token and it's easy to migrate to other people's tokens.

I'll start by integrating Google Sign-In into chatcraft according to google's doc, I plan to proceed as follows:

Create authorization credentials, this step need some developer contact info, @tarasglek could you help me set this step and provide app's client ID for me?
write a functions/google.ts and refer to github.ts
write functions/google.test.ts
add google login in functions/api/login.ts
add login test

This sounds good @WangGithub0.  A few more thoughts:

I would break this into pieces.  For example, we can begin with the CloudFlare bits, but not connect them in the UI.  Follow-up PRs can integrate things.  You could also write the implementation of the function and test separate.  More, smaller, PRs are better.
Our UI will eventually need to evolve to include different sign-in options:

We might change that menu item to "Sign In..." and have it open a modal dialog with different options for GitHub, Google, etc.  Doesn't have to be done that way, just thinking out loud.


Hua wei p6 force close does not work (Android 4.2.2)

yes,  there are many devices do not suppot still, such as Samsung
6.0,Huawei P6 and some of Xiaomi
2016-03-18 14:57 GMT+08:00 jiashu.ge<EMAIL_ADDRESS>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Marswin/MarsDaemon/issues/2


Adapt diagnostic script to new version of iris

Description

Closes #2401
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[ ] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[ ] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[ ] 🧪 Recipe runs successfully
[x] 🧪 Recipe is well documented
[x] 🧪 Figure(s) and data look as expected from literature
[x] 🛠 Provenance information has been added

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

Ok, I'll test it, thanks!

Runs without error, but the first panel of the plot looks strange (see https://docs.esmvaltool.org/en/latest/recipes/recipe_flato13ipcc.html for comparison).

Thanks again, @katjaweigel, good catch. The reason is that iris.plot now plots latitude automatically in y-direction, which is not fitting for the rest of the setup of the figure. I have changed that now and I also took the opportunity to address some deprecation warnings and automatic formatting.
Could you please give it another spin?

@zklaus thanks a lot! I'll run it again.

@zklaus works now, thanks!


Storing Empty list in TempData cookies results in a Jarray object when read

I have code that may store an empty list object in the tempdata property of the controller.
When using the default tempdata provider (cookies) after I redirect to the MVC action that consumes the data it will be read as a Jarray instead of the intended type List

@Tarig0, can you please share a sample code to repro the issue?

Just had a thought, could we add generics so we can get an empty list.
TempData<List<Int>>("Test");

Key Exists
Value
Result

No
null
Throw key not found

Yes
null
null

Yes
[]
Empty List

Yes
["Hello","World"]
Throw cast error

Yes
[1,2,3,4]
List with values

The problem is any change to the interface ITempDataDictionary would be a breaking change and we wouldn't be able to make it until the next major release. But yes, perhaps the idea that you'd pass in the type of the the value to the dictionary would be to make the type support more complex types among other things.


Add Volunteer's history

Issue #663 needs to be complete before this issue is picked up
On a users Volunteer Profile we need to have an area that shows all the events they have participated in.

 Add Volunteer's history #664


Add script to fix alt contig MD5 sums in CRAM header

Makes cpg_workflows' CRAMs compatible with WARP CRAMs.
Context: https://centrepopgen.slack.com/archives/C030X7WGFCL/p1669180382708679
TODO:

[x] Add a script that applies samtools reheader to each CRAM in a dataset (success: https://batch.hail.populationgenomics.org.au/batches/381398/jobs/1)
[x] Pass unmasked reference to the samtools merge in the Align workflow's stage
[ ] Reheader all post-NAGIM datasets

Run that script on all NAGIM datasets

Did you mean all non-NAGIM datasets, as the NAGIM CRAMs already point to the unmasked reference?

Add samtools reheader into the Align workflow stage.

Should we instead change the samtools merge call (https://cs.github.com/populationgenomics/production-pipelines/blob/a823b6e1aea91818fbb86d0c3642525c9ca435a4/cpg_workflows/jobs/align.py) to pass the unmasked reference (--reference), similar to the WARP pipeline (https://github.com/broadinstitute/warp/blob/a3b438422691f447032038be52c74639dafe914f/tasks/broad/DragmapAlignment.wdl#L70)?

@lgruen, you are correct, I meant post-NAGIM.
Re samtools merge - I haven't tested if that actually would work, was going to :)

Relevant Discussion: https://github.com/populationgenomics/production-pipelines/issues/208


npm does not export any methods?

my code:
import WebSlides from 'webslides';

// use:
const ws = new WebSlides();

but report an error:
Uncaught TypeError: webslides__WEBPACK_IMPORTED_MODULE_17___default.a is not a constructor
    at preview (handoutVideo.tsx:70)

and:
console.log(WebSlides)

// print a object:
{}

version: 1.5.0

The environment is up to date create-react-app

file: WebSlides/src/js/full.js
import WebSlides from './modules/webslides';
require('../scss/full.scss');

window.WebSlides = WebSlides;

not any export ?

I’ll look into this ASAP


C#: Do not print errors about missing references to intentionally ignored members

Fixes https://github.com/godotengine/godot/issues/74447

~Makes that error a verbose print only, like the other cases in this method where a referenced method cannot be found.~
Added a list of members that were intentionally not emitted for some reason (currently only methods with pointer parameters/return) and then when references to these members are missing, no warning is printed.

I think we wanted the error to be always printed (not just when verbose) to make sure we don't miss errors that could be caused by a bug. For example, if the bindings generator didn't find the method maybe we forgot to bind it, or maybe there's a bug in the bindings generator.
Note that when other members aren't found we also use ERR_PRINT:
https://github.com/godotengine/godot/blob/095e98a42591ebb7b0d9db6c021c05b37000f258/modules/mono/editor/bindings_generator.cpp#L568-L569
So if we change it for methods we should likely change it for the other members too.

Thanks!

Cherry-picked for 4.0.2.


cherry-pick to v4.8: [Storage] fix snapshot resources

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

!verified


Add hideHexInput prop to TwitterPicker

I have implemented and written tests for a new prop, hideHexInput, to TwitterPicker which hides the input.
Can someone create a branch for me that I can push into and make a PR?

Can you fork the repo and make your changes there? Github will let you submit a pull request back to this origin repo that way.

Thanks! There we go: https://github.com/casesandberg/react-color/pull/719


Migrate to using cargo fix --idioms

This'll be a new flag being added to Cargo to help transitioning to the idioms
of the 2018 edition.
At the same time this removes the +nightly invocations from Cargo commands,
removes --all-targets as it's the default, and finally removes
--all-features as the default of --all-targets should be enough.

DON'T MERGE YET!
This PR is awaiting the stuff mentioned above to be merged into Cargo.
@alexcrichton will ping back on this PR once that is done and this is ready to be merged.

Ah yes, sorry! This is blocked on https://github.com/rust-lang/cargo/pull/5843 making its way into nightlies.

Note to self: Once this is merged, #19 should be rendered moot so we can close that then.

Everything is now landed in rust-lang/rust and a nightly is one the way out, so merging!


'folly/portability/Config.h' file not found

Description
RNDemo project created through npx react-native init RNDemo, it can run in the simulator. But if I add pod 'WeexSDK', '~> 0.30.0', and after re-installing pod, I will get the error 'folly/portability/Config.h' file not found when compiling with the simulator.
Error information: ~/RNDemo/ios/Pods/Flipper-Folly/folly/portability/Stdlib.h:21:10: 'folly/portability/Config.h' file not found

Pofile configuration: Podfile.txt
Background description：WeexSDK is referenced in existing projects, and now we want to introduce ReactNative, transform the Weex page into an RN page, and finally remove WeexSDK, so WeexSDK and ReactNative need to be dependent on both in the early stage.
Steps to reproduce
1、Use the terminal, execute npx react-native init RNDemo.
2、Open the folder RNDemo/ios and replace the configuration of Podfile-Podfile.txt.
3、Use the terminal to enter the ios folder and execute pod install.
4、Open RNDemo/ios/RNDemo.xcworkspace, run it in the  simulator.
React Native Version
0.72.0 and 0.73.2
Affected Platforms
Runtime - iOS
Output of npx react-native info
System:
  OS: macOS 14.3
  CPU: (6) x64 Intel(R) Core(TM) i5-8600 CPU @ 3.10GHz
  Memory: 1.92 GB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 21.6.1
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.21
    path: /usr/local/bin/yarn
  npm:
    version: 10.2.4
    path: /usr/local/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.11.3
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
  Xcode:
    version: 15.0.1/15A507
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: ^18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs
no stacktrace

Reproducer
RNDemo: https://github.com/zhengmiaokai/RNDemo-Reproducer
Screenshots and Videos
No response

⚠	Newer Version of React Native is Available!
ℹ	You are on a supported minor version, but it looks like there's a newer patch available - 0.72.11. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

⚠	Newer Version of React Native is Available!
ℹ	You are on a supported minor version, but it looks like there's a newer patch available - 0.72.11. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

⚠	Newer Version of React Native is Available!
ℹ	You are on a supported minor version, but it looks like there's a newer patch available - 0.72.11. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

This problem can also be reproduced using version 0.73.2

⚠	Newer Version of React Native is Available!
ℹ	You are on a supported minor version, but it looks like there's a newer patch available - 0.72.11. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

This problem can also be reproduced using version 0.73.2

@zhengmiaokai, thanks for the issue.
I see that WeexSDK is trying to use a file folly/portability/Config.h.
Let's check what's happening:

Does your library use anything from Folly directly?
In your Pods/RCTFolly/folly/portability folder, do you have the Config.h file?
Does the error persist if you remove the WeexSDK library?
In your WeexSDK.podspec file, can you add here:

 s.pod_target_xcconfig = { 'USER_HEADER_SEARCH_PATHS' => '${PODS_TARGET_SRCROOT}/weex_core/Source/ ${PROJECT_DIR}/../../../weex_core/Source',
    'GCC_PREPROCESSOR_DEFINITIONS' => 'OS_IOS=1',
+   "HEADER_SEARCH_PATHS" => \"$(PODS_ROOT)/RCT-Folly\",
}

This should fix the issue.

@cipolleschi , thanks for your reply.
Answer to the four questions above：

My Library don't use anything from Folly directly.
In my Pods/RCT-Folly/folly/portability folder, It have the Config.h file.
If I remove the WeexSDK library, the error don't occurred.
I add "HEADER_SEARCH_PATHS" => \"$(PODS_ROOT)/RCT-Folly\" in my WeexSDK.podspec file, But the error occurred.

There must be some transitive dependency in your SDK that makes it depends on Folly, and the podspec can't find the right paths.
In React Native there are some other pods that depends on Folly.
Can you try to add:

These lines to get the folly flags
add these compiler_flags (Only the folly ones, not the boost ones, for now).
Keep the RCT-Folly entry in the HEADER_SEARCH_PATHas shown here

Still i am getting this error having RN 0.72.3
'folly/folly-config.h' file not found

@Ahsanali012 can you provide a reproducer using this template?
Meanwhile, try to:

bundle exec pod deintegrate
bundle exec pod install
Open the xcworkspace and not the xcodeproj file
Build

Helped for me:
post_install do |installer|
  system("chmod -R u+w Pods/RCT-Folly")
  Dir.glob("Pods/RCT-Folly/folly/Portability.h").each do |file|
    text = File.read(file)
    new_contents = text.gsub('#define FOLLY_HAS_COROUTINES 1', '#define FOLLY_HAS_COROUTINES 0')
    File.open(file, "w") { |file| file.puts new_contents }
  end
end

Taken from: https://github.com/facebook/folly/issues/2297


added GitHub flavored checklist(task list) markdown

added GitHub flavored checklist markdown (https://help.github.com/articles/basic-writing-and-formatting-syntax/#task-lists)
added unit tests.

@mdiep  Could you please help me to check travis settings.  Somehow it fails there. Thank you.

The project needs to be upgraded to a more recent Xcode in the .travis.yml file.


add progress hook function property

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Make sure you are merging your commits to dev branch.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

#1776


Victor VosMottor: Watch chjahan.website

Victor VosMottor requests the watch of the watch_keyword chjahan\.website. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

chjahan\.website has been seen in 1 true positive, 0 false positives, and 1 NAA.

Approved by Ryan M in Charcoal HQ


Windows: add generic Visual Studio target

Specifying VS version and arch in a target (e.g. vs15_64) is good for testing on Appveyor, but for other uses there should be a generic vs target that doesn't do anything if cl.exe is already in PATH and detects installed VS version and host arch and uses that otherwise. See https://github.com/keplerproject/luarocks/blob/0ddc39af72f608f8d386f5e79a86417da16c4b21/install.bat#L427-L536

Done on master branch.


Notebooks 2.0 // Backend // CRUD Workspaces API

@thesuperzapper can you please assign this one to me?

PR with create, restore and delete -> https://github.com/kubeflow/notebooks/pull/65
/cc @thesuperzapper

Done https://github.com/kubeflow/notebooks/pull/66/commits


Make the parameter to _withUnsafeMutableBufferPointer be an UnsafeMut…

There were type checker bugs blocking this in the past, but they appear
to be resolved since it now works.
Resolves rdar://problem/21933004.

@swift-ci Please smoke test

Okay, a type checker issue that I thought I could not reproduce is actually reproducing here. I'll have to take another look at this.


Assignment

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

You have unfortunately made a pull request to the wrong repo. This is not a complete submission for the assignment. Please make a pull request to your own forked shell repo. Detailed instructions are available in the onboarding Assignment Submission Guide.

Hi Simeon,
I understand the error. Unfortunately, last week I purchased a new computer
at Best Buy for this program and it has been problematic from day 1 so I've
finally returned it just a few short minutes ago now. I am now in the
process of acquiring a new machine and will have to download everything
once more. Please see proof of the transaction attached with today's date
and time. I do apologize for the error in my assignment.
I would like to ask whether it's possible inasmuch as I've received all
green check marks for the rest of the assignment could it be accepted as
is, given my circumstance. I do apologize for any inconvenience this may
cause while I source a new machine and get set up again.
Looking forward to hearing back from you.
Thanks.
On Mon, Nov 25, 2024, 10:43 a.m. Simeon Wong @.***>
wrote:

You have unfortunately made a pull request to the wrong repo. This is not
a complete submission for the assignment. Please make a pull request to
your own forked shell repo. Detailed instructions are available in the
onboarding Assignment Submission Guide
https://github.com/UofT-DSI/onboarding/blob/main/onboarding_documents/submissions.md
.
—
Reply to this email directly, view it on GitHub
https://github.com/UofT-DSI/shell/pull/167#issuecomment-2498369909, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BM5D3VXKP4MLSPL4YWWJKHT2CNAQ7AVCNFSM6AAAAABSLFWR4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGM3DSOJQHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Oh dear. I am not sure if I will get the credit for the one that was forked
to my own repo since it's not the correct one. The latest one that was
incorrectly forked to the UofTDSI would be the most accurate. Again, my
apologies. I assure you I am aware of how to perform the operation, this
was simply an error on my part at the end forking to the wrong repo.
So will it still be considered incomplete in that case?
On Mon, Nov 25, 2024, 12:25 p.m. Simeon Wong @.***>
wrote:

This current PR was made incorrectly to the UofT-DSI repo.
But it also looks like you have a correctly made one to your own fork of
the repo (ceejay868#1 https://github.com/ceejay868/shell/pull/1), and
that one will be graded sometime this week!
—
Reply to this email directly, view it on GitHub
https://github.com/UofT-DSI/shell/pull/167#issuecomment-2498615677, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BM5D3VU3JFJIX3X4EHMD6DT2CNMO7AVCNFSM6AAAAABSLFWR4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGYYTKNRXG4
.

Also, GitHub pull requests update automatically as you add more commits to the source branch. So even if you created the assignment PR with an earlier version of the assignment, when you added more commits and pushed them to your assignment branch, the PR will update and the grader will run again.
In other words, this PR and the correct PR essentially contain the same code.


STCN uniformity issue and slow retrieval

While performing a search of the word "almanac", instead of getting this output:
Performing query: almanac
I get the following output:
Performing query: prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix schema: <http://schema.org/>
prefix owl: <http://www.w3.org/2002/07/owl#>
select ?s ?name where
{
  ?s ?p ?o .
  ?s <http://schema.org/name> ?name .
  ?s schema:mainEntityOfPage/schema:isPartOf <http://data.bibliotheken.nl/id/dataset/stcn> .
  FILTER (regex(?o, "almanac","i"))
}
order by ?s

I still get the list of results right afterwards, but it takes too long.

STCN is very slow indeed, too slow. This has to do with the regex filter in the SPARQL query.
There might be two solutions:

Find an alternative to the regex filter, or find a way to make it quicker. @jgonggrijp : do you know if this is possible?
Use the alternative REST API, which provides faster search but offers output in raw marc21 and JSON: https://data.cerl.org/stcn/_api#/default/get_stcn__search

Find an alternative to the regex filter, or find a way to make it quicker. @jgonggrijp : do you know if this is possible?

Probably not, but please do give me pointer to the code in question. I might come up with an idea when I see it.


backlog list

Sometimes tasks cannot be done at this sprint. It's a good idea to write it into backlog to get it into one of the following sprints.

The undone task should be moved to the next sprint (#100) or canceled (#87). Implementing full featuring backlog list doesn't cost efforts.


Update screenshots

Hey Can you assign this issue to me ? I would like to contribute

Done, @Mudit-Jxin7 !
Thanks for the contribution, man!

hey @felipebueno I am not able to find the light mode toggle button in the mobile application

Yeah, we don't have that yet. The light mode is pretty ugly for now so I defaulted it to dark.


你们用这套代码跑MLQE数据集了吗？

作者你好，刚刚看了你的论文，感觉深受启发。我打算接着你们的工作继续往下做，是在MLQE数据集上的。不过如果你们也在做的话，那我就不做啦，省得和你们工作冲突。
祝好。

感谢您的评论。我们的共产党领导很强大。我们会赢
MLQE是什么意思？

MLQE is another dataset for Machine Translation Quality Estimation, the link is here:
https://github.com/facebookresearch/mlqe
I want to continue your job on that dataset, but I wonder are you also experimenting on that dataset? If you are, then I guess I'd better change my research direction, in case that we did the same work.
Best wishes.

Hello, thank you for letting us know. Please continue. We are not on it at the moment. Please get in touch with us if you face any problems or get interesting results.
Kind regards. 祝你周末愉快。


Install androguard as user with pip fails

If you want to install androguard via pip as a non-root user it fails:
Exception:
Traceback (most recent call last):
  File "/home/reox/.local/lib/python2.7/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/home/reox/.local/lib/python2.7/site-packages/pip/commands/install.py", line 342, in run
    prefix=options.prefix_path,
  File "/home/reox/.local/lib/python2.7/site-packages/pip/req/req_set.py", line 778, in install
    requirement.uninstall(auto_confirm=True)
  File "/home/reox/.local/lib/python2.7/site-packages/pip/req/req_install.py", line 754, in uninstall
    paths_to_remove.remove(auto_confirm)
  File "/home/reox/.local/lib/python2.7/site-packages/pip/req/req_uninstall.py", line 115, in remove
    renames(path, new_path)
  File "/home/reox/.local/lib/python2.7/site-packages/pip/utils/__init__.py", line 267, in renames
    shutil.move(old, new)
  File "/usr/lib/python2.7/shutil.py", line 317, in move
    os.unlink(src)
OSError: [Errno 13] Keine Berechtigung: '/usr/share/androguard/androguard.ico'

Probably we need to adopt the path then?

this should be fixed now


Move objective from allocation_optim.jl to allocation_init.jl (refactor)

Currently the objective function for optimization problems in allocation is generated from scratch each time with the function set_objective_priority!.
https://github.com/Deltares/Ribasim/blob/4c04d05cfabc850a6322fa8cf768a5ef0015d24f/core/src/allocation_optim.jl#L621-L626
As the comment at the function call indicates, this is now only done because the quadratic objective functions do not support modification. As we are getting rid of these, we could move to only initializing the objecting function once and modifying coefficients when needed. This I think makes the code cleaner and maybe for large models also more performant.

I think this is only still relevant if we decide to go for #1494.

We cannot do this, because we stick to a quadratic objective function which can not be done in initialization, can only be done every iteration


Do not strip parenthesis

Trimming parenthesis leads to bugs with distributed query evaluation because Prometheus does not properly stringify subquery expressions when they are not wrapped.
For example, the query max_over_time((bar/bar)[30s:15s]) gets transformed into max_over_time(bar/bar[30s:15s]).

Hm, this seems to break explicit assertions now, like timestamp((bar)).


Tests pass but FFDC still taken

Running on QEMU...
tox -e qemu -- tests/test_rest_interfaces.robot
The very first test passed but it still produced the FFDC prints.  Is that right?  the test teardown calls 'FFDC On Test Case Fail'   but it didn't fail.  Is there a variable not getting initialized?

hmm this could be qemu thing.. the base env it would need is the IP OPENBMC_HOST:xx.xx.xx.xx  to work..

We have fix thing in those areas. FFDC is called on all test exits and ONLY collects FFDC if failed unless explicitly called to collect.


sample_tls sample fixed number of units per cluster

Add argument to allow sampling of fixed number of units per cluster.
Ensure compatibility of target_n_clusters, target_n_tls and new n_units_cluster argument.

Should be resolved in 8483149


File mounting allow list

Is your feature request related to a problem? Please describe.
This is to avoid messing with files/folders accidentally when using mounts.
Describe the solution you'd like
Would like to see a file shares allow list where you can add directories that a container are allowed to mount. If a folder you trying to mount is not in that list the container should fail to start. This is similar to virtual file shares permission in Docker Desktop (see the screenshot)
Describe alternatives you've considered
None
Additional context
This is what the file shares permission looks like in docker desktop

Duplicate of #169 (but it's very unlikely that it'll apply to containers, at least at the beginning—only machines)


Import Filter

Laravel Version: 6.10
Adldap2-Laravel Version: 6.0
PHP Version: 7.2
LDAP Type: AD

Description:
Is there any way to filter down users by properties when performing an import.
Our AD (imo) has been badly managed and has accounts returning that are not actually employee accounts (service accounts, IP phones in Conference Rooms etc).  I'd like to filter on a few properties that I know only HUMANS should have, such as
employeeid, employeenumber, manager.

Steps To Reproduce:

NVM, realized this is basic LDAP filter query strings, just had to find a tool that echo'd out the strings for me as I'm not the AD admin.


[QUESTION] Short sentences in en

Hello, I have found this case that seems strange for the input string "I am the begt spell cherken!":
int maxEd = 2;
suggestionItems = symSpellCheck.lookupCompound("I am the begt spell cherken!", maxEd);
    for (SuggestionItem elem : suggestionItems) {
      System.out.println("compound : " + elem.getTerm().trim());
    }

I'm getting compound : a am the best spell cher ken
My setup is the default one:
    SpellCheckSettings spellCheckSettings = SpellCheckSettings.builder().countThreshold(1).deletionWeight(1f)
        .insertionWeight(1f).replaceWeight(1f).maxEditDistance(2).transpositionWeight(1f).topK(5).prefixLength(10)
        .verbosity(Verbosity.ALL).build();

    dataHolder = new InMemoryDataHolder(spellCheckSettings, new Murmur3HashFunction());

// weighted Damerau-Levenshtein
    weightedDamerauLevenshteinDistance = new WeightedDamerauLevenshteinDistance(spellCheckSettings.getDeletionWeight(),
        spellCheckSettings.getInsertionWeight(), spellCheckSettings.getReplaceWeight(),
        spellCheckSettings.getTranspositionWeight(), null);

    symSpellCheck = new SymSpellCheck(dataHolder, weightedDamerauLevenshteinDistance, spellCheckSettings);

I to a conversion is happening due to the casing issue, which I have fixed in the PR.
Also for cherken to 'cher ken'  is happening due to lookup compound algo.
Currently, the spell correction works mainly on the term frequency of the words, and it mainly doesn't include the previous word meaningful context. the top word suggested from the symspell at the time of lookup is itself not checker, it's chicken so hence it's giving such output,
I am currently working to add noisy channel with the current algo for spell checker to add much meaningful context.

@MighTguY thank you. I will try to build the latest PR thank.
Regarding context based spelling, I was discussing about it with @wolfgarbe in https://github.com/wolfgarbe/SymSpell/issues/61
where he suggests this approach: https://blog.usejournal.com/a-simple-spell-checker-built-from-word-vectors-9f28452b6f26?gi=5df44b8031b6
Jupyter code with common mistakes here: https://github.com/er214/spellchecker
Other interesting ngram based approach may be used in

LanguageTool, Java, http://wiki.languagetool.org/tips-and-tricks#toc2
JamSpell, C++


Float bencher update

@StevenLove even though the first two calls to eval-pol print out numbers in a given precision:
399.999999999585
even though the correct answer as input by the program and correctly passed was:<PHONE_NUMBER>9958527
λ⸨⚙ ⸩ → ./bench.slosh
slosh 0.10.0 (test-new-floats:cee5608+, debug build, macos [aarch64], Feb 28 2024, 05:16:07 UTC [rustc 1.76.0 (07dca489a 2024-02-04)])
Using default slshrc written to "~/.config/slosh/init.slosh".
Edit this file to remove this message and customize your shell
(eval-pol 100 0.5) =>
399.999999999585
passed: true
(eval-pol 1000 0.05) =>
2105.263157892448
passed: true
(eval-pol 10000 0.2) =>
24999.999999998603
passed: true

is the printing working properly? Proof of issue is essentially

prints

399.999999999585```
2 but
```(equal? (eval-pol 100 0.5)<PHONE_NUMBER>99585)```
is false

I am still wrapping my head around the different layers. I'm able to load the eval-pol script into slosh and run it to see the behavior you described:
λ > (equal? (eval-pol 100 0.5)<PHONE_NUMBER>99585)
false
λ > (equal? (eval-pol 100 0.5)<PHONE_NUMBER>9958527)
true

I did some testing in Rust and found that the custom Display trait for F56 has a bug in it; it displays up to 12 digits after the decimal rather than up to 12 digits of precision total. Once fixed, those values with ~10 repeated nines should look much nicer.


Update Safari 13 MediaRecorder

MediaRecorder is still behind an experimental feature flag in Safari 13

Confirmed, thanks!


disable-apps-for-eks

towards https://github.com/giantswarm/roadmap/issues/2609
disable specific apps for EKS as they could not run there or it does not make sense for them to run

These are default apps. I'd expose values in default-apps-aws to be able to disable the apps we don't want. It sounds more explicit to me than messing with cluster-apps-operator. What do you think?

the issue I have with that is the user need to remember that he needs to set the values for EKS to disable the apps which is horrible UX, AFAIK the new kubectl gs template cluster will be provider agnostic and you need to provide yaml values for it. There won't be any provider-specific config

closing in favor of using separate app repo for EKS
https://github.com/giantswarm/default-apps-eks


[otbn,dv] Pick up extreme offset addresses for bne and be

Following additions/ changes have been made in this commit:

Added a new variable called mode to assign equal weightage to all
possible address ranges.
Edited the randomization logic to pick up offset address.

Fixes #8078
Signed-off-by: Prajwala Puttappa<EMAIL_ADDRESS>

@ctopal: The <= is to allow fall-through if, for example mode is zero and min_addr > -4.

Oh that is really cool!


Invalid template metadata labels generated

Description of the bug:
Consider the following cdk8s code:

import { Construct } from 'constructs';
import * as kplus from 'cdk8s-plus-22';
import { Chart, ChartProps } from 'cdk8s';

export const PodLabels = {
  'custom-label-1': 'value1',
  'custom-label-2': 'value2',
  'custom-label-3': 'value3',
};

export class TestChart extends Chart {
  constructor(scope: Construct, id: string, props: ChartProps = { }) {
    super(scope, id, props);

    const deployment1 = new kplus.Deployment(this, 'deployment1', {
      metadata: {
        name: `${id}-deployment1`,
        namespace: 'testns',
      },
      podMetadata: {
        labels: PodLabels,
      }
    });
    deployment1.addContainer({
      image: 'paulbouwer/hello-kubernetes',
      port: 8080
    });

    const deployment2 = new kplus.Deployment(this, 'deployment2', {
      metadata: {
        name: `${id}-deployment2`,
        namespace: 'testns',
      },
      podMetadata: {
        labels: PodLabels,
      }
    });
    deployment2.addContainer({
      image: 'paulbouwer/hello-kubernetes',
      port: 8080
    });
  }
}

The following template is generated where there's invalid label         cdk8s.deployment: testchart-deployment2-c87e348b under the deployment 1.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: testchart-deployment1
  namespace: testns
spec:
  replicas: 1
  selector:
    matchLabels:
      cdk8s.deployment: testchart-deployment1-c87d5b0d
  template:
    metadata:
      labels:
        cdk8s.deployment: testchart-deployment2-c87e348b
        custom-label-1: value1
        custom-label-2: value2
        custom-label-3: value3
    spec:
      containers:
        - env: []
          image: paulbouwer/hello-kubernetes
          imagePullPolicy: Always
          name: main
          ports:
            - containerPort: 8080
          volumeMounts: []
      volumes: []
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: testchart-deployment2
  namespace: testns
spec:
  replicas: 1
  selector:
    matchLabels:
      cdk8s.deployment: testchart-deployment2-c87e348b
  template:
    metadata:
      labels:
        cdk8s.deployment: testchart-deployment2-c87e348b
        custom-label-1: value1
        custom-label-2: value2
        custom-label-3: value3
    spec:
      containers:
        - env: []
          image: paulbouwer/hello-kubernetes
          imagePullPolicy: Always
          name: main
          ports:
            - containerPort: 8080
          volumeMounts: []
      volumes: []

Reproduction Steps:

Error Log:

Environment:

Framework Version:
"cdk8s": "^1.2.11",
"cdk8s-plus-22": "^1.0.0-beta.62",
OS: macOS

Other:

This is :bug: Bug Report

Yep, this looks like a bug! The label on the pod for the first Deployment should be testchart-deployment1-c87d5b0d, not testchart-deployment2-c87e348b. 👍
For anyone that runs into this issue, a workaround for this is to fix the label using an escape hatch:
ApiObject.of(deployment1).addJsonPatch(
  JsonPatch.replace('/spec/template/metadata/labels/cdk8s.deployment', 'cdk8s-testing-deployment1-c84bf64d')
);

@Chriscbr can you reopen the ticket or do I have to file a new one?
Thanks,
Markus

@Chriscbr any estimate when this would be fixed?

@markusl I'm not actively working on cdk8s at the moment, so I don't think I can help. @iliapolo might be able to answer, otherwise I'd try asking on the cdk.dev slack. 🙏

Hello :)
Is this issue still relevant and/or available ?
I would love to contribute ^^

Oh this is nasty one. Happens because the common PodLabels are passed by reference, and get mutated by deployment2 after being used in deployment1.
A workaround for this that doesn't require an escape hatch would be:
podMetadata: {
  labels: { ...PodLabels }, // creating a copy.
}

@SoniaisMad appreciate the offer, but upon further investigation, turns out this issue is a bit more severe than initially thought. So for speediness, I went ahead and already created a PR to fix it. If you're interested in contributing elsewhere, you're welcome to have a look at other issues in the repo(s) and ping me if something catches your eye :)
Thanks!

No problem ! I will keep an eye on the other issues then !
Thanks :)


If use h265,will throw error

If use h265 , will throw error,
When h265, below code will found no RtspMediaTrackInfo in function GetTracksToSetup().
and next will throw error:
RtspClientSharp.Rtsp.RtspClientException: 'Any suitable track is not found'
private IEnumerable GetTracksToSetup(IEnumerable tracks)
{
foreach (RtspMediaTrackInfo track in tracks.OfType())
{
if (track.Codec is VideoCodecInfo && (_connectionParameters.RequiredTracks & RequiredTracks.Video) != 0)
yield return track;
else if (track.Codec is AudioCodecInfo &&
(_connectionParameters.RequiredTracks & RequiredTracks.Audio) != 0)
yield return track;
}
}

H265 is not supported.
duplicate https://github.com/BogdanovKirill/RtspClientSharp/issues/17


Webstorm debug?

how do i debug a spec? can i use webstorm to do it? how?
thanks!

@Agamennon - can you elaborate more as to what you did to be able to debug tests using jasmine-node from webstorm?

This is our configuration in Webstorm. Works fine.

We use grunt-jasmine-node and therefore grab the jasmine-node file from there.

thanks @4kochi . that worked for me!  Do you have a way of running one test at a time?

In Jasmine itself you can use iit() instead of it() to run just that test. The same works with describe(). But i don't know if jasmine-node supports that. Maybe @tebriel can give us a hint.


[Update llm_server_hybrid.py ] modifying the call_puyu function

modifying the call_puyu function following the latest internlm2 API document in https://internlm.intern-ai.org.cn/api/document

Already merged in #285


pages respond with 500 status if missing action

For the home page of my site I only want to support GET requests, but if a bot comes along and does a drive-by POST request, then I end up with a 500 status response being returned and a stacktrace in my logs. This adds noise and false positives to monitoring which makes it harder to detect real issues. The 500 status code should be reserved for unexpected errors, and in the case of a POST request to / I intend to not support that method.
For the first approach I tried adding an action function the returned a simple response with a 405 (Method Not Allowed) status
export let action: ActionFunction = async () => {
  return new Response(undefined, {
    status: 405,
    headers: {
      Allow: "GET"
    }
  })
}

But when I make the POST request, the result is a 500 internal server error and the log error is:
Error! Failed to complete request to /: Error: socket hang up
Unhandled rejection: Error: You made a POST request to http://localhost:3000/ but did not return a redirect. Please `return redirect(newUrl)` from your `action` function to avoid reposts when users click the back button.

This makes lots of sense for a form, but for a page where I expect to never recieve a POST, PUT, etc I don't think it applies.
For my next approach I tried what feels like a bit of a 🐒 🔧 monkey patch as it uses remix internals. In the server/index.js file I've set up a handler to wrap the remix handler which checks if there's a route match (I think I did this wrong) and if there is, checks if there's an action for the route. If there's no action it then sends a 405 response. Otherwise it falls back to the remix handler. ⚠ This code ends up always returning 405s though, and not 404s because it doesn't detect route matching correctly.
server/index.js:
const { createRequestHandler } = require("@remix-run/vercel");
const { matchServerRoutes } = require("@remix-run/node/routeMatching");
const { createRoutes } = require("@remix-run/node/routes");

const build = require("./build");

const remixHandler = createRequestHandler({
  build: build,
});

const routes = createRoutes(build.routes);

/** @type {import("@remix-run/vercel").RequestHandler} */
const handler = async (req, res) => {
  let method = req.method.toUpperCase();
  // Everything except GET
  if (["HEAD", "OPTIONS", "POST", "PUT", "PATCH", "DELETE"].includes(method)) {
    let matches = matchServerRoutes(routes, req.url);
    // If there's no match for this route, the remix handler will return 404,
    // which is good. This is just to hand the case where the route matches, but
    // there's no action handler defined.
    if (matches || matches.length < 1) {
      let routeMatch = matches[matches.length - 1];
      console.log("matches: " + routeMatch.pathname);
      if (!routeMatch.route.module.action) {
        // Log an error for visibility. This is better than the default
        // behaviour of crashing the lambda which results in a future cold start
        console.error(
          `No action defined for ${req.method} request to ${req.url}`
        );
        // Method Not Allowed
        res.status(405);
        // This list is the inverse of above
        res.setHeader("Allow", "GET, HEAD");
        res.send();
        return;
      }
    }
  }

  await remixHandler(req, res);
};

module.exports = handler;

Maybe it would be helpful to have an option for a default action handler?
To restate my goal here: I would like to not see responses with a status code of 500 unless there's a real error in my code that I need to investigate. This is important for monitoring the health of a site.
Thanks for your time reading this post!

You raise a valid concern, as it differs from the way a classical HTTP server would handle this.
I'm wondering what way the fix would go:

align with classical web servers: make handleDataRequest treat POST|PUT|PATCH|DELETE as a GET when there's no action() exported
change the 500 to a 405 (Method Not Allowed) and document this behavior

we should change it to 405, and then consider some generic way to handle this in the future.

PR for this: https://github.com/remix-run/remix/pull/2342

Fixed in #2342


I combined it with pygame to read the ps3 controller as input to drive the virtual gamepad but i got an error

I use float data from ps3 controller with pygame as vgamepad input, but I have an error so I can't.
does anyone want to try my code?
import pygame
import sys
from pygame.locals import *
from math import trunc
import vgamepad as vg
import time

gamepad = vg.VDS4Gamepad()
pygame.init()
joysticks = []
clock = pygame.time.Clock()
keepPlaying = True
motion = [0,0]
print("tes")
pygame.joystick.init()
joysticks = [pygame.joystick.Joystick(1) for i in range(pygame.joystick.get_count())]
for i in range(0, pygame.joystick.get_count()):
    # create an Joystick object in our list
    joysticks.append(pygame.joystick.Joystick(i))
    # initialize them all (-1 means loop forever)
    joysticks[1].init()
    print(joysticks[-1])
    # print a statement telling what the name of the controller is
    #print ("Detected joystick "),joysticks[0].get_name(),"'"
    #print(joysticks[-1].get_name())

while True:
    for event in pygame.event.get():
        if event.type == JOYAXISMOTION:
            print(event.axis)
            if event.axis < 2:

                motion[event.axis] = event.value
                xvalue =  motion[0]
                yvalue = motion[1]
                yc = float(yvalue)
                print("X",xvalue,"Y",yc)
                gamepad.left_joystick_float(x_value_float=xvalue, y_value_float=0.0)
                gamepad.update()

https://pastebin.com/upNV3CCu

Hello, can you paste the traceback of the error you get, please?

I have resolved the error but a bug appears, the virtual gamepad is read by pygame so looping occurs

Haha I see. You need a way to find out which one is the virtual gamepad so as to ignore it in pygame I guess.

The get_guid() and get_name() methods in pygame might help you here. Or maybe simpler : try creating the Joystick object in pygame before creating the virtual gamepad.

ok i try


get current selectedButton()

I'm not able to get current selected button. I'm trying to get it in IBAction on save button.
Any suggestions? Thanks

@dneykov  Are you using the following snippet
var currentButton = radioButtonController.selectedButton()
Did you add it RadioButtonController first?

this is how I'm trying to get current button:
@IBAction func saveInspection(sender: AnyObject) {
var currentButton = radioButtonController.selectedButton()
println(currentButton)
}
and this is my viewDidLoad:
radioButtonController.setButtonsArray([buttonAA!,buttonA!,buttonB!,buttonC,buttonD])
for the currentButton I get always nil.
Thanks

@dneykov Just pushed a code. It's working all right now.
Let me know.

It is working now.
Thanks.

currentSelectedButton now returns nil always.
i have used a buttonOutletCollection.
radioButtonGroup.setButtonsArray(bloodGroupButton)
func didButtonGroupSelected(sender: UIButton) {
var control = radioButtonGroup.selectedButton()
print(control) //prints nil
}


utube command name clash with omer73364's utube

Inspiration
This project was inspired by uTube

Both projects provide utube command, so no straightforward way to install both globally

Thank you for bringing this to our attention. I understand the concern regarding both projects' conflicting utube commands. I will fix it soon by replacing the utube command with the pyutube command, ensuring that users can utilize both tools globally without conflicts.
Please make sure to watch the repository so that you can stay updated on any changes. If you have any more questions or concerns, please don't hesitate to let me know. Your feedback is valuable in improving the project experience for everyone.
Thank you for your understanding and support. 😊

New release 😁
Change the endpoint into pyutube. see the readme.md for more information 👍

New release 😁
Change the endpoint into pyutube. see the readme.md for more information 👍


merge: dev to master

Adds first implementation from DEV to MASTER

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Snyk] Upgrade @zendeskgarden/react-forms from 8.53.1 to 8.53.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @zendeskgarden/react-forms from 8.53.1 to 8.53.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2022-07-07.

Release notes

Package name: @zendeskgarden/react-forms

8.53.2 - 2022-07-07v8.53.2 (2022-07-07)
🐛 Bug Fix

breadcrumbs, dropdowns, modals, pagination, tabs

#1378 fix(breadcrumbs,dropdowns,modals,pagination,tabs): improved a11y with upgraded react-containers (@ jzempel)

grid

#1380 fix(grid): address splitter button design and interaction issues (@ jzempel)

Committers: 1

Jonathan Zempel (@ jzempel)

8.53.1 - 2022-06-28v8.53.1 (2022-06-28)
🐛 Bug Fix

modals

#1377 fix(modals): typo in nodeRef (@ JamesSingleton)

Committers: 1

James Singleton (@ JamesSingleton)

    from @zendeskgarden/react-forms GitHub release notes

Commit messages

Package name: @zendeskgarden/react-forms

b4ef84e chore(release): publish
9655973 fix(breadcrumbs,dropdowns,modals,pagination,tabs): improved a11y with upgraded react-containers (#1378)
ad23e56 fix(grid): address splitter button design and interaction issues (#1380)
6298f3c chore(changelog): add v8.53.1 [skip ci]

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closing as an existing branch will remove this as a dependency.
I expect this branch to get merged shortly.


Issue 1532 :: Fixing NPE thrown RepositoryHostedIndexCreatorTest

Pull Request Description
This pull request closes #1532
Acceptance Test

[x] Building the code with mvn clean install -Dintegration.tests still works.
[x] Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
[x] Building the code and running the strongbox-distribution from a zip or tar.gz still works.
[x] The tests in the strongbox-web-integration-tests still run properly.

Questions

Does this pull request break backward compatibility?

[ ] Yes
[x] No

Does this pull request require other pull requests to be merged first?

[ ] Yes, please see #...
[x] No

Does this require an update of the documentation?

[ ] Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
[x] No

Thanks, @anki2189 ! :)


create.sh fails when the DC name contains a hyphen.

The generated CQL is invalid - I'm not sure whether its missing quoting, or just unusable.
Example output:
system_traces  system_schema  system_auth  system  system_distributed

Generating the schema for the keyspace jaeger_v1_DC1-K8Demo and datacenter DC1-K8Demo
Using template file /cassandra-schema/v001.cql.tmpl with parameters:
    mode = prod
    datacenter = DC1-K8Demo
    keyspace = jaeger_v1_DC1-K8Demo
    replication = {'class': 'NetworkTopologyStrategy', 'DC1-K8Demo': '2' }
    trace_ttl = 172800
    dependencies_ttl = 0
<stdin>:3:SyntaxException: line 1:43 mismatched input '-' expecting K_WITH (... KEYSPACE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:13:SyntaxException: line 1:39 mismatched input '-' expecting '(' (... TYPE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:18:SyntaxException: line 1:39 mismatched input '-' expecting '(' (... TYPE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:24:SyntaxException: line 1:39 mismatched input '-' expecting '(' (... TYPE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:29:SyntaxException: line 1:39 mismatched input '-' expecting '(' (... TYPE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:54:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:68:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:83:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:100:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:117:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:136:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:156:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:162:SyntaxException: line 1:39 mismatched input '-' expecting '(' (... TYPE IF NOT EXISTS jaeger_v1_DC1[-]K8Demo...)
<stdin>:175:SyntaxException: line 1:40 no viable alternative at input '-' (CREATE TABLE IF NOT EXISTS [jaeger_v1_DC1]-...)
<stdin>:179:SyntaxException: line 1:36 no viable alternative at input '-' (CREATE CUSTOM INDEX ON [jaeger_v1_DC1]-...)

I think - is invalid character for the keyspace name

Its definitely valid for datacentre names; sounds like create should mangle it to _ if its invalid.

(or perhaps "/cassandra-schema/docker.sh" should?)

It fails because Datacenter name is used in keyspace name.
https://docs.datastax.com/en/cql/3.1/cql/cql_reference/ref-lexical-valid-chars.html
/cassandra-schema/docker.sh is just a wrapper for create.sh.

@pavolloffay yes indeed - but thats my point: the code in docker.sh presumes that the datacentre name is a valid keyspace name component.

hey ! I want to work on this , how can CQL be generated ?

@dexter816 hi, you can run something like this MODE=test sh plugin/storage/cassandra/schema/create.sh


Inline and auth-user-pass revamp

: we accept and preserve anything between:

"\n" and ' '*""
Leading whitespace and comments are not removed

auth-user-pass payload has a very simple format which can be described
by the following regular expression:
(.+)\n(.+)($|\n.*)
The first line contains the username, and the second line is the
password. The rest is ignored and Anything Is Allowed™.

The existing has the following comment:
(* To protect against a client passing a maliciously  formed  user‐
   name  or  password string, the username string must consist only
   of these characters: alphanumeric, underbar ('_'),  dash  ('-'),
   dot  ('.'), or at ('@').  The password string can consist of any
   printable characters except for CR or LF.  Any  illegal  charac‐
   ters in either the username or password string will be converted
   to underbar ('_').*)

This text originates from openvpn/doc/man-sections/script-options.rst. I believe this applies only for scripts. So it is fine, if not too useful, to allow "exotic" characters in usernames and passwords - the server will just replace those characters with _.