calDidDisconnect does not include UUID object

After finishing call there should be callDidDisconnect(_ call: TVOCall) delegate method called with TVOCall object having UUID children object.
This is not happening though, since there is no UUID attribute returned. Maybe its a backend bug since this SDK was working couple days ago.
I am creating new call as: performStartCallAction(uuid: UUID(), handle: "VoIP Demo")
Attributes of callbacking TVOCall object look like this:

Thanks!

This is my start call method for callkit
func performStartCallAction(uuid: UUID, handle: String) {
        let callHandle = CXHandle(type: .generic, value: handle)
        let startCallAction = CXStartCallAction(call: uuid, handle: callHandle)
        let transaction = CXTransaction(action: startCallAction)
        callKitCallController.request(transaction)  { error in
            if let error = error {
                NSLog("StartCallAction transaction request failed: \(error.localizedDescription)")
                return
            }
            let callUpdate = CXCallUpdate()
            callUpdate.remoteHandle = callHandle
            ... other call Update setup
            self.callKitProvider.reportCall(with: uuid, updated: callUpdate)
        }
    }

also attaching error stack:
libswiftFoundation.dylib`static Foundation.UUID._unconditionallyBridgeFromObjectiveC (Swift.Optional<__ObjC.NSUUID>) -> Foundation.UUID:
    0x10263c168 <+0>:  sub    sp, sp, #0x40             ; =0x40
    0x10263c16c <+4>:  stp    x20, x19, [sp, #0x20]
    0x10263c170 <+8>:  stp    x29, x30, [sp, #0x30]
    0x10263c174 <+12>: add    x29, sp, #0x30            ; =0x30
    0x10263c178 <+16>: mov    x20, x0
    0x10263c17c <+20>: mov    x19, x8
    0x10263c180 <+24>: cbz    x20, 0x10263c1c4          ; <+92>
    0x10263c184 <+28>: stp    xzr, xzr, [sp, #0x10]
    0x10263c188 <+32>: nop
    0x10263c18c <+36>: ldr    x1, #0x773fc              ; "getUUIDBytes:"
    0x10263c190 <+40>: add    x2, sp, #0x10             ; =0x10
    0x10263c194 <+44>: mov    x0, x20
    0x10263c198 <+48>: bl     0x102693ff0               ; symbol stub for: objc_msgSend
    0x10263c19c <+52>: ldr    q0, [sp, #0x10]
    0x10263c1a0 <+56>: str    q0, [sp]
    0x10263c1a4 <+60>: mov    x0, x20
    0x10263c1a8 <+64>: bl     0x102694008               ; symbol stub for: objc_release
    0x10263c1ac <+68>: ldr    q0, [sp]
    0x10263c1b0 <+72>: str    q0, [x19]
    0x10263c1b4 <+76>: ldp    x29, x30, [sp, #0x30]
    0x10263c1b8 <+80>: ldp    x20, x19, [sp, #0x20]
    0x10263c1bc <+84>: add    sp, sp, #0x40             ; =0x40
    0x10263c1c0 <+88>: ret
->  0x10263c1c4 <+92>: brk    #0x1

Hi @marecektn
Could you share more details about the steps you are doing so we can also try to reproduce the issue you are having? I've tried the Swift CallKit quickstart myself (with beta8 SDK) but was able to get the callDidDisconnect: callback and uuid of the TVOCall object is valid. Steps:

Launch the app and register for push
Make an call from another Twilio (JS, browser) client
Accept the incoming call from system call UI
Hang up the call on the mobile app
po call.uuid when callDidDisconnect: is called

Are you getting crash or you are just unable to see UUID in the TVOCall object?
The debug description of the TVOCall object you are seeing from the console was implemented before we added the CallKitIntegration category to the TVOCall class thus it's missing the uuid property. Sorry for the confusion and we'll add it back.
-bobie

Hello @bchen-twilio
thank you for your quick reply.
I tried to go through your steps and I managed to get the UUID object with no problem.
I went through all possible combinations of calling / accepting and hanging up and my observations are (both clients are registered for push). Clients A (iOS 10.1) and B (iOS 10.3)
call init A - A hangs up: crash
call init A - B hangs up: crash
call init B - A hangs up: OK
call init B - B hangs up: OK
call inits A - B declines: crash
call inits B - A declines: callback not called (which is ok since there is no call on receiving part)
I am bit confused, it might be versions of iOS. since everytime call is inited by client B (iOS 10.3) UUID is there and valid..
anytime it is inited by client A, there is no UUID and crash occurs
Please let me know if you need further info, I can share you my backend (it is making accessTokens for devices by their name which might be the problem)
everytime I need accessToken, I am calling this endpoint:
@app.route('/accessToken/<clientName>')
def token(clientName):
  account_sid = os.environ.get("ACCOUNT_SID", ACCOUNT_SID)
  api_key = os.environ.get("API_KEY", API_KEY)
  api_key_secret = os.environ.get("API_KEY_SECRET", API_KEY_SECRET)
  push_credential_sid = os.environ.get("PUSH_CREDENTIAL_SID", PUSH_CREDENTIAL_SID)
  app_sid = os.environ.get("APP_SID", APP_SID)

  grant = VoiceGrant(
    push_credential_sid=push_credential_sid,
    outgoing_application_sid=app_sid
  )

  #let's register client
  token = AccessToken(account_sid, api_key, api_key_secret, clientName)
  token.add_grant(grant)

  return str(token)

any kind of help is much appreciated.. thanks a lot :)

Hi @marecektn
Thanks for the experiments 👍
I have a hunch but am not sure - could you help me check if the clients A (or B) is getting multiple push notifications for incoming call invite or cancellation? this could somehow mess up the UUID value of the call(-invite) object but usually this won't happen for end users in the wild since their apps will and should only be using the production Push Credential SID. However if you install the production app on the device that was used for development and the sandbox Push Credential SID was used for registration, it's possible that you get multiple push notifications for one incoming call/cancellation event.
To clarify, you are getting this crash:

on client A device?
when trying to call call.uuid in the Swift code?

Thanks
-bobie

to answer your push notification question:
I am obtaining 2 push messages - 1 before call starts to ring, 1 after I accept the call (both are type of PKPushType.voIP)
But I obtain no push message about canceling the call. Is that ok?
Crash is because I am trying to call.uuid in Swift code.
I am continuing on the investigation, seems like the end of call notification is missing. Will try to run it with your quickstart app.
Thanks for help 👍

next steps:
I create two instances of quickstart app that use my backend and tried all the combinations.. It worked ok. So backend bug is out of scope.
What I've notice is that you are not using iOS10 callkit for call ending.. and on my application the standard UI with Call Failed occurs everytime I hang out call (from any client)

so I am using pretty much the same code as in demo of yours for hanging call up:
if (self.call != nil && self.call?.state == .connected) {
            self.call?.disconnect()
        }

but everytime I hang call there is iOS10 UI showing Call Failed.. that is suspicious

Hi @marecektn
We do have CallKit example and it is included in this quickstart. You can either use Cocoapods to set up the workspace, which will include both the regular and the CallKit quickstart projects in it, or just use the CallKit xcodeproject.
When the app/SDK failed to end the call, what is the error you are seeing? is it from CallKit or is it from the SDK? one of the CallKit FAQ of the Voice SDK is that developers get com.apple.CallKit.error.requesttransaction error 4. error when trying to send the end-call-action to CallKit. It would be great if you could also try the CallKit Swift quickstart we provide and see if you are seeing the same error on your device and environment.
Thanks!
By the way, I should explain a bit about the push notifications - currently the Twilio Voice service will send two kinds of push notifications, call & cancel. The push notification you are getting after accepting the call is exactly the cancel notification and it's because currently Twilio Voice service allows same identity to be registered on multiple clients and once a call is answered/rejected or canceled, the service will send cancel notifications to all of the clients registered with that identity, including the client who answered the call.
About the call.uuid crash, it's very odd. I am wondering if this is specific to that device or iOS version. Would it be too much trouble for you to try to grab call.uuid using our CallKit quickstart on your device?
cheers
-bobie

hi @bchen-twilio
thanks for reply, I am experiencing crash on uuid which is not optional and therefore app crashes.
what I am trying to do now is to implement your callkit demo viewcontroller into my app (which seems to work ok)..
therefore I assume I am doing something wrong on my abstraction layers in app.
I am closing this defect for now since your demo works and will let you know what I was missing.
thanks for help!

👍  Awesome @marecektn!
Absolutely happy to know your findings and hopefully other SDK users can potentially benefit from it.
Cheers
-bobie

@bchen-twilio ok, time to show the cards.. after couple of debugging hours I found out I was missing most important line of them all – setting call uuid in make in CXStartCallAction
since I had to put both iOS9 and iOS10 support in one framework, I created CallManager that creates its own interface for iOS version respectively. By moving all logic from view controller into couple of abstraction layers, I forgot to make assignment of call?.uuid = uuid in makeCall method.
I was wrongly assuming that UUID created in call performStartCallAction(uuid: UUID(), handle: "VoIP Demo") will be handled with the call instance itself.
But I was assigning uuid correctly in acceptCall method which brings light into my former debug observations when half of the cases were success.
Thank you very much for your support, I appreciate it very much. 👏

Thanks for sharing your findings with us @marecektn and please feel free to let us know if you have any suggestion or you run into any problem in the future.
Looking forward to seeing your awesome voice app!
cheers
-bobie

Hey guys, i have a question, which handle could i use in the example says let handle = "Voice Bot", but this would be used then? @bchen-twilio @marecektn

Hi @RnyG
Sorry I don't think I am following your question.
Are you trying to make an outgoing call to a specific name (handle) or are you trying to report the name to the system for displaying the incoming call?


Terminal stuck at converting uNet

The conversion process has been stuck at converting uNet for hours now.

In activity monitor, I can see ANECompilerService using CPU, and Python 3.8 and ANECompilerService using RAM. However, Terminal does not use any Energy, leading me to assume the process got frozen or killed.
What can I do to resolve this? Wouldn't it be easier to be able to download an already converted coreML model?
MacBook Pro, M1 Pro, 16GB RAM

In my experience, this part, after the 4 bars, takes a really long time. Too bad it does not have it's own progress bar.
There are CoreML models available on hugging face

In my experience, this part, after the 4 bars, takes a really long time. Too bad it does not have it's own progress bar.
There are CoreML models available on hugging face

ok, thank you. the pre-converted v1-5 is working for me. v2 returns with RuntimeError: {NSLocalizedDescription = "Error computing NN outputs.", which is part of the FAQ and could be caused by insufficient memory (although I thought 16GB should be sufficient)


Test testTransactionAgainstFilter matches the same transaction as Core

@antouhou @Cofresi do we need to cover more cases or outputs and inputs are enough?


Expose FRI states through ros2_controller

#31 for galactic branch

there appears to be an issue with launching the controller_manager node in galactic

closed in favor for #41


Clickable tree nodes

Is your feature request related to a problem? Please describe.
I'd like to be able to keep the tree element interactive - taking over the terminal input and let user to expand/collapse nodes while the tree is active. Some trees could be enormous, so letting a user to click on a node and load more data just for that node could be a better UX.
Describe the solution you'd like

Provide a flag to allow the tree to enter the interactive mode, a.k.a. do not exist the program until a control sequence is sent, e.g. ctrl + C.
Provide a click/button press event which we could subscribe to to perform an additional logic.
Provide a way to re-render the tree in place.

Describe alternatives you've considered
I don't know of any alternatives.

@iSeiryu I'm sorry, but we don't want to add that kind of interactivity to Spectre.Console. If you're looking for interactive applications in the terminal, I can recommend the excellent Gui.CS project.

This library is the closest we have in dotnet to Golang's https://github.com/charmbracelet/bubbletea.
They support keyboard and mouse events.
https://github.com/gui-cs/Terminal.Gui is a completely different way of building the terminal UI which does not always fit the need of a CLI app. It'd be nice if I could only use their TreeView component within a Spectre based app but it seems like I would need to build the whole app using their library.
BubbleTea has a separate components repo https://github.com/charmbracelet/bubbles
Maybe, Spectre.Console could create a repo for some extra components which the community could contribute to? The events would probably need to belong to the core package though.


Handle twilio error 21610 (Customer replied with "STOP")

When someone text "STOP" to the apps twilio number they are added  to the "blacklisted" numbers meaning this app may no longer send them texts. Any subsequent texts to the blacklisted number will result in a twilio error with code 21610. The changes in this pull request aim to handle that error.
Migrations
Added phone_number_id to recordings to create the relationship and make it easier to determine which number a recording came from.
Added blacklisted to phone_numbers and friends
Blacklisted Models
Both PhoneNumber and Friend have a new method named markBlacklisted that when called will set the value of blacklisted to true and fire a {$classname}WasBlacklisted event.
This pull request does not implement any handlers for these events, they are fired to allow handlers to be attached so the user can be notified
The "verified" query scope on both models now specifies that blacklisted should equal false.
The models were also given a "status" appended attribute to make it easier to display the status and icon to the user.
Blacklisted Icon
The phone-number icon now has a separate icon when the "blacklisted" class is present, this works well with the status attribute.

TwilioRequest
The routes that interact with twilio now require a twilio request which provides the phoneNumber method which finds the PhoneNumber based on the incoming reqest data.
The authorize method needs to be updated to verify that the request is actually coming from twilio
Jobs
To reduce the number of places that the error could occur I merged the separate jobs for verifying and notifying user and friends.

SendNewRecordingNotifications takes the place of

NotifyFriendsOfRecording
NotifyOwnerOfRecording

VerifyPhoneNumber takes the place of

VerifyPhoneNumberFriendship
VerifyPhoneNumberOwnership

When sending a text to either a phone number or a friend results in a blacklisted exception the markBlacklisted method is called on the offending model.

@mattstauffer This should take care of the errors, there are a few more tasks to handle to polish this off:

make some event handlers for the blacklisted events
add an incoming text message route to handle when a number removes itself from the blacklist
add twilio verification to the TwilioRequest class to make sure the request is legit

@RDelorier uhhhh how did i not see this?
Also, why closed? Is it wrong now?

@mattstauffer I kinda assumed you didn't want it and figured I'd save myself the embarrassment, I can never tell if I'm doing too much. Imposter syndrome ftw!

Not true at all! I completely missed this. Apologies and thanks for doing
the hard work!! I'll try to take a look at it tonight. :)
On Sat, Apr 9, 2016 at 2:16 PM Richard Delorier<EMAIL_ADDRESS>wrote:

@mattstauffer https://github.com/mattstauffer I kinda assumed you
didn't want it and figured I'd save myself the embarrassment, I can never
tell if I'm doing too much. Imposter syndrome ftw!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/mattstauffer/pulledover/pull/30#issuecomment-207824228

Here you go, looking forward to your feedback!

@RDelorier OK, back in the saddle after moving. Looking at this--FINALLY--now!

@RDelorier sorry it took me so long to get to this. There's a lot of great work here--thanks for contributing!!

@mattstauffer Welcome back! Hope the move went well 😄

@RDelorier :) It did--thanks man! Glad to be back in the swing of things.

Thanks for your time and feedback today. I made some more changes and left a few questions on your comments, I'm sure you have plenty of other stuff to catch up on so no rush 😴 😸

I've restarted this from scratch because I think I got to carried away. Seems silly to make so many changes for such a small feature :/.
On the plus side, I have come up with a much more proactive approach which reacts when the person actually sends the stop/start message that blacklists them in the first place.
@mattstauffer Thanks for all the feedback on these changes, you definitely helped give some insight on the good/bad and hopefully that will show in the other branch I'm working on right now for this.

@RDelorier Nice. :) Let me know how I can help! Sorry if it feels like wasted effort.. excited to see where you go!

I'll be working on it here. No effort is wasted when you learning new stuff 😄 .


Prepublish Checklist: Minor style tweaks

Context
1.5 Prepublish Checklist designs have updated spacing and minor design changes.
Summary
I know this PR is small and doesn't cover everything, but I wanted to get the update for checking if helper text exists before the text updates come through.
Relevant Technical Choices

Update space on ppc
conditionally render check helper text to prep for text updates
move list styling up a level

To-do

disable ability to toggle accordions for high priority and recommended
handle color updates for icon

User-facing changes
Just some spacing updates.

Testing Instructions

QA
If prepublish checklist renders as expected, we're good here. No changes.

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #7137

Verified in QA


Regs3k fix svg namespace parsing

This PR fixes Regulations 3000 problems with parsing the svgs used in the inline interpretations expandable. These problems included styling errors, rendering errors, and 500 errors being generated by the Python-Markdown library failing to strip namespaces that were being introduced by ElementTree when including our inline interpretation template in the rendered markdown.

@niqjohnson @ajbush Should the interp content (i.e. the 1. Application for credit paragraph above) be indented? I think the original designs called for it to be flush with the expandable header?

Looks like inline interpretation paragraphs were indented before all the expandables updates, so this indentation isn't a regression or anything. Ideally, yes, the paragraphs would be flush left, but I'm fine if we want to make that a separate PR and keep this one to just the SVG changes.

Alrighty I modified the indentation code, the interps now look like this:


Update the Docker Quickstart to include Spark 3.5 and Delta Lake 3.0

With the release of Delta Lake 3.0 and the improvements made across the board to both the delta protocol, the addition of the Delta kernel, and the significant improvements to Spark 3.5. We should update the quickstart to enable folks to get up and running quickly.
Selfishly. This also enables us to reuse the quickstart base image for the Delta Lake Definitive Guide. :)

I can pick this up as well. Just getting started.


Make default sidecar scope services merge consistent with sidecar

Please provide a description of this PR:
Now we merge services that are from SE and in same namespace.
And k8s service takes priority, we donot merge k8s services' ports before and after.
I am not sure of any regression by this, open for feedback first

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test unit-tests-arm64

lint_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test unit-tests-arm64

lint_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test lint

unit-tests_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali Hope you have a chance to take a look

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
b842ebe07d1317e35e67fef6357d3af5a190e897
link
true
/test unit-tests

lint_istio
90e45daf42aa81d54fac33f5248cd4b4dcf3a440
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Another Helper Entity for Start and End-times?

Hey there,
thanks for the addon. i really like the idea and i think it could actually save me a lot of hassle for what i want to do. Though i am not 100% sure if i am able to archive what i want to do with this addon or if i need to think about it differently anyway.
So here it is: i have a simple and dumb home but now with smartmeter and power delivery paid by the hour. i would like to physically display when the next period for the cheapest prices would be. (ESP, MQTT, a nice display. That thing will live on top of my washing machine :) ) i never really found a straight forward way to display the upcoming TIME for the cheapest price.
Your addon makes this possible but only has a binary sensor for internal automations, but i don't think i have any possibility to display the actual TIME when the binary sensor will be set to ON.
Is there a simple way to pull this data from your sensor, or could you maybe add another entity which always displays the next time and date for the cheapest prices?
thanks so much!

Could this be a solution for you?
https://community.home-assistant.io/t/epex-spot-and-awattar-electricity-prices/519151/88

Any update on this? Did you had a look at the solution in the link?

Hi Mampfes,
sorry i haven't had time to implement my ideas yet. i looked into it and on a first glance it looks promising. I keep you updated if not. thanks ;)

@Jxhannes Not sure if I got your point. Did you check the solution in the link above? It describes a way to create a sensor which tells you the next turn-on-time.


The sheduled taask wont delete the local files

If i delete the file in my seedbox, it wont delete the Local file even though the remote file is not there

https://lftp.yar.ru/lftp-man.html

add it to the sync command option
https://userdocs.github.io/LFTP4WIN-CORE/#/commands?id=lftpsync-setup

Thanks for the quick reply, It worked 👍 :)


Update MD file on new branch 2017-14-02_14-11-38

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTest.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: Handle Proxy WS upgrade manually for WS handshakes

Hey, I just made a Pull Request!
Handle Proxy WS upgrade manually for WS handshakes.
Closes #19813
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@freben or @camilaibs are you OK with the yarn.lock change?

Oh one more thought. You're doing ?. on the call. Ie it'll fail entirely silently if the method isn't there right? In my ! case it'll at least lead to a 500 so the caller gets notified that something went wrong with the upgrade. Maybe this is a non-issue in practice, but just mentioning. You could have a check that throws, if you wanted to be ultra thorough.

@freben  My bad, I thought it would break the typings in other places, tried and it doesn't so I'm applying your suggestion on the RequestHandler interface.


Add total data to address interface

Codecov Report
Patch coverage: 56.52% and project coverage change: -0.14 :warning:

Comparison is base (b3c0bb1) 55.64% compared to head (848a3a3) 55.51%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #358      +/-   ##
==========================================
- Coverage   55.64%   55.51%   -0.14%
==========================================
  Files          33       33
  Lines        5163     5188      +25
==========================================
+ Hits         2873     2880       +7
- Misses       2290     2308      +18

Impacted Files
Coverage Δ

zingocli/tests/integration_tests.rs
80.88% <ø> (ø)

zingolib/src/commands.rs
0.00% <0.00%> (ø)

zingolib/src/lightclient.rs
60.28% <75.00%> (+0.12%)
:arrow_up:

zingolib/src/wallet/data.rs
52.02% <100.00%> (+0.25%)
:arrow_up:

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cloning?

Is there a way to clone pokemon in this emulator? I know the timing on a physical GBC but can't seem to replicate it on this device

gameplaycolor is using https://github.com/taisel/GameBoy-Online, so asking there is probably a better idea.


Make the buttons center aligned and enhance the css

Try to make the buttons in the center and add enhance the styling of the buttons

Try to make the buttons in the center and add enhance the styling of the buttons

Hey, I've just forked this repository and made certain changes to center the buttons. Below is a preview of it. If you it's alright with you I'd love to make a PR or if any changes need to be made let me know 🙂🙂

Alignment is ok just try to decrease the height of the buttons and make the corners more rounded
Then make a PR

Alignment is ok just try to decrease the height of the buttons and make the corners more rounded Then make a PR

I've made the necessary changes and have opened up a PR https://github.com/Pritam0077/Meme-Generator-App/pull/16


Bump bugsnag-cocoa to v6.28.0

Looks like this requires a change to the end-to-end tests. @kstenerud, can you amend?

Looks fine to me.


holder name is not validated

There seems to be a bug concerning the validation of the card holder name.
In Encryption.prototype.encrypt the validationObject does not contain the holderName key.
Is that correct?
Thanks for your feedback.

Any feedback here?

Sorry Sven for getting back to you so late.
You are completely correct. I now have added this field and also updated the unit tests.
There are some more changes upcoming so I will not yet release just for this issue.
Kind regards,
Arnoud


Suppress compiler warnings

Is there a way (if not, should/can there be a way) to surpress certain compiler issues akin Build tab in old project properties?
http://puu.sh/hCNDe/6314b5a5ef.png
I don't believe anything in the project.json schema currently supports this?

We need to add support for this

Workaround for time being would be to #pragma warning disable ### / #pragma warning restore ###.
Not sure if easier/better workarounds available?

@smudge202 Can you file an issue for this on dnx

Issue raised here: aspnet/dnx#2042


Remove ZooKeeper dependency

Hi
First and foremost, congratulations for this tool. It's great being able to measure these metrics on kafka from a client side.
This issue is in fact a question. Do you plan to remove the dependency with zookeeper? some of our clusters run on AWS and zookeeper is not accessible so I can't use kafka-monitor to conduct this kind of end-to-end testing. I've followed the implementation and I think kafka admin API covers most of the things we get from zookeeper. Moreover, once KIP-500 is merged, zookeeper will be gone.
Maybe there is some way to not use zookeeper in the current version, but I have not found it.
Best regards.

Hi @jmcristobal the concern raised in this particular issue is in progress and ongoing. Thanks for bringing it up.

Hello,
Have you got some news about implementation of this feature ?
Thanks

@waewoo: looks like PR #175 did it.

@waewoo: looks like PR #175 did it.

But https://github.com/linkedin/kafka-monitor/blob/c42ea7debc15ed2e6e3847eb17b15ec23e00708a/src/main/java/com/linkedin/xinfra/monitor/services/MultiClusterTopicManagementService.java#L408 still depends on Zookeeper.


On scroll element also moves up and down?So can this feature not be used in a long page?

By element I mean draggable element

Please provide explanation, example and screenshot

See my draggable component gets attached to screen and remains there only as  I scroll through the page ...for eg if I have element at centre of screen then it remains there only ..it doesn't get attached to page

Currently you can't.
We are working on it

The problem is actual for me too
Very sad...

I was about to open this very issue, when I found that someone else ran into the same problem.

Source of this issue
The issue is with line 163 in draggable.ts, where the element’s position is set to fixed.
Recommendation

This line of code should probably replace fixed with absolute.  I think most web developers assume this would be the default kind of positioning for draggable-type functionality.

Perhaps an arg parameter for the directive’s binding could allow client code to “opt-in” to the current behavior (via something like v-draggable:fixed) to declare a component should have the current “scroll-ignoring” positioning.

Or better;
[draggable-state]{
    position: absolute !important;
}

Hi guys,
first of all thanks for your ideas, they are always welcomed.
I already started to work about the solution, 'absolute' positioning is problematic with bounding-rectangle feature.

When can solve this issues?

it will take a while

@IsraelZablianov I congratulate you on the pack you created. Please fix this function.

I've ended with a solution without modifying the directive, assuming multiple boxes to drag, bounding to a container.
1） Set each box a class
.drag-box {
  position: absolute !important;
}

Each box's initialPosition is set relative to container, e.g. { left: 0, top: 0 }

in onDragStart, change the box's position to 'fixed' and make sure top & left are wrt to the viewport

    onDragStart: function(positionDiff, absolutePosition, event) {
      let box = event && event.target && event.target.closest('[draggable-state]')
      if (box) {
        // Get the model
        const id = box.id
        let found = this.boxes.find(b => b.id === id)

        if (found && !found.firstTouched) {
          // On the first touch, the directive's initialPosition, startDragPosition, currentDragPosition needs to be set wrt to the viewport
          const container = this.$refs.container.getBoundingClientRect()
          const top = absolutePosition.top + container.top
          const left = absolutePosition.left + container.left
          box.style.top = top + 'px'
          box.style.left = left + 'px'

          let draggableState = JSON.parse(box.getAttribute('draggable-state')) || {}
          draggableState.initialPosition = { left, top }
          draggableState.startDragPosition = { left, top }
          draggableState.currentDragPosition = { left, top }
          box.setAttribute('draggable-state', JSON.stringify(draggableState))

          // Record in model that the box has been touched
          found.firstTouched = true
        } else {
          box.style.top = absolutePosition.top + 'px'
          box.style.left = absolutePosition.left + 'px'
        }
        // Remove the class
        box.classList.remove('drag-box')
      }
    }

in onDragEnd, change the box's position to 'absolute' and make sure top & left are wrt to the container

    onDragEnd: function(positionDiff, absolutePosition, event) {
      let box = event && event.target && event.target.closest('[draggable-state]')
      if (box) {
        const container = this.$refs.container.getBoundingClientRect()
        const top = absolutePosition.top - container.top
        const left = absolutePosition.left - container.left
        box.style.top = top + 'px'
        box.style.left = left + 'px'

        // Add the class again
        box.classList.add('drag-box')
      }
    }

A remaining problem is if the page scrolled, the directive's initialPosition, startDragPosition, currentDragPosition are not updated and the first touch of the box will suddenly move the box to somewhere else. But after the first touch, everything is fine again.


Remove checked in docs build, ignore build output directory

This will cause problems when Travis autobuilds our docs. See the deploy_docs.sh (which is run by Travis) and make deploy_docs commands.
Travis commits the docs/ folder, does a git subtree split on it, then pushes the html files to the gh-pages branch of this repo. With docs/_build in the gitignore, Travis won't be able to find those changes.

There's no need to commit the docs in order to have Travis upload them.  See e.g.
https://github.com/scikit-image/scikit-image/blob/master/.travis.yml#L60

I'm going to hold off on merging until @SamLau95 confirms that he has figured out how to deploy the docs in this new way.

Yup, makes sense, happy to help with that.

Here goes nothing!


added support for bitfield command.

added support for bitfield command.

 2022-12-15 20:20:27 WARNING there is a difference between specified test-commands in the yaml (name=memtier_benchmark-1key-100MB-string-bitfield) and the ones we've detected ['get']!=['get', 'bitfield']
2022-12-15 20:20:27 WARNING there is a difference between specified test-groups in the yaml (name=memtier_benchmark-1key-100MB-string-bitfield) and the ones we've detected ['string']!=['bitmap']

@slice4e please correct the groups of test :)

I believe I fixed it. and pushed a new commit

I believe I fixed it. and pushed a new commit

Confirmed fixed in https://github.com/redis/redis-benchmarks-specification/actions/runs/3707733491/jobs/6284499636
Merging. Thank you @slice4e !


Support http://nscreen.info/

Are you planning to add support for http://nscreen.info/ ?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The site doesn't exist anymore


Fix document and code typo

@jxd134  Do you mind split this pull into 2, one focus on Document improvement.
I find that you delete all space at the end of each line, but somewhere we left 2 space for line break.

@jxd134  Do you mind split this pull into 2, one focus on Document improvement.
I find that you delete all space at the end of each line, but somewhere we left 2 space for line break.

@jxd134 Do you mind split this pull into 2, one focus on Document improvement. I find that you delete all space at the end of each line, but somewhere we left 2 space for line break.

The remove of end-of-line spaces may be caused by automated formatting.
I will close this pr and create a new pr later.

@jxd134 Do you mind split this pull into 2, one focus on Document improvement. I find that you delete all space at the end of each line, but somewhere we left 2 space for line break.

The remove of end-of-line spaces may be caused by automated formatting.
I will close this pr and create a new pr later.


"international" no longer set to "true" by default

I noticed, that all numbers are converted back to non-international numbers if you just add type="tel" without any configuration. The problem is, that the field validation expects an international number and marks the field as invalid.
When adding international="true" to the input it works the same as the previous versions.

Thx!
I'll look into it in the beginning of next week.


Automatic Cluster Upgrades

User Story

As a Giant Swarm Customer, I would like my clusters to be up to date so I can benefit from all new features and security patches

As a Giant Swarm Admin, I would like the cluster upgrades to be automated, so I can reduce the manual efforts when upgrading lots of clusters

Acceptance Criteria

[ ] Be able to define a schedule when clusters will be rolled automatically (staging Mondays, prod Fridays)
[ ] It should work with and without Gitops. In the case of GitOps, a PR is automatically raised (in the customer repo)

(More requirements in the RFC)
Context
Some work that has been done in the past on the topic:

This RFC
PR with latest CAPI discoveries

Progress status as of Nov 22nd, 2022:
this is an x-team between KaaS and RelEng. There is no capacity to work on this atm in most KaaS and RelEng teams. Rocket will do some steps towards its implementation (as there is some interest in doing this from a customer), consulting Honeybadger about possible solutions and ways to move forward (to keep the consistency of different use cases on the product)

added to horizon and roadmap repo + x-team label as agreed cc @puja108

@gawertm can you add some sub-issues here to create an overview of what Rocket is working on or planning to?

thats what we still need to refine. discussions are pending for the final as well as intermediate solution. once done, I will refine :)

I have added some details to the RFC noted after our meeting. IMO we should use this RFC to discuss and drive our decissions

@puja108 please write down the general direction we want to take with upgrades from a product point of view.

Similarly to this comment, the "Release channels and staged deployments" RFC is related to this.
As I commented in the other comment linked above, I will add shorter RFC overview, address and reply to comments there, clarify more, etc, and then I'll also post an update here, but a quick  TL;DR here for how the RFC relates to automated cluster upgrades (it doesn't care about the cluster being WC or MC, it's for all):

There are multiple release channels, Test, Staging, Production (few different Production release channels, Edge/Current/LTS, but not getting into the details here)
Every new app version goes though all release channels, it starts in Test, then it gets promoted to Staging, then to production.

The promotion is a fully automated process.

For every cluster it's specified which release channel it is using.
In the happy path, as soon as there is a new app/k8s version in the release channel, the cluster gets that new version automatically. This delivery is fully automated process.

This happy path can be overridden (so app/k8s upgrade is postponed/deferred). This part is still not described in the RFC.
But important, automated upgrades are the default, and you have to explicitly postpone the upgrade.


[Feature Request]: use managed identity in Python bot

Scenario
According to this doc, the Python version of the Bot Framework SDK supports multi-tenant and single-tenant bots. Since Teams-ai depends on Bot Framework SDK, Python bots here do not support managed identity either.
Solution
Please let Python bots support managed identity.
Additional Context
No response

@BMS-geodev

test comment

here is an example of using cert based authentication via @azure/identity with BF https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/javascript_nodejs/84.bot-authentication-certificate. Since we wrap bot framework any auth enhancements would need to take place in their SDK for us to utilize.


Added tests for checkSystem

This closes #8 and #18. This depends on #17 so that should be merged first.
Changes:

(feature) pulled in tape to test and tap-min to minimally print test results
(feature) added tests for the checkSystem module
(feature) added a simple .travis.yml so that we can enable CI
(feature) added a utility called MockFile that helps with testing different engine objects

I ignored writing tests for the validatorRules module since it seemed pretty simple and didn't have too much logic.
Once the travis file is in, follow the steps here to enable travis for the main repo. Step 3 is already done. It will automatically build for any commits or PRs to any branch on the repo and email the author if failed.
The current status of the Travis build for this branch can be checked here.

Something also seems weird too, cause changes from PR #2  are showing up here as changes.  Maybe just GitHub thing?

Awesome on CI and Travis

Alright, removed dependency on the file system and started using proxyquire instead.


Update tempest configuration file for gate environments

There are changes to tempest configuration file so as to run all tempest tests on the gate environments. One of the restrictions is to boot only from volume in addition to other configurations

please test this

This PR is depends on jiocloud/puppet-tempest#11

please test this

please test this


Link options to already existing frames

Make a way so the option will not lead to a new frame, but will link to an existing one instead. Useful when the dialog has a main window in which are questions and you want users to be able to read them all.
Visual (the red line is my enhancement idea):

Branch started for this issue, see https://github.com/esoadamo/dialog-tree-creator/tree/issue-3


Understanding code problem

I was trying to grasp how the CircuitVerse app is implemented, like understanding the code and so, and I’m facing a few problems.
First I see objects being used but I can’t see where they are defined example is the ‘simulationArea’  (public/js/) used In many files,
Same goes for some functions and variables like for example ‘errorDetected’, ‘updateCanvas’ ,’updateSimulation’, 'update()' , etc. (public/js/listeners.js)
Second is that I see functions defined but never see them being used like ‘add’ , ‘swap’, ‘pop’ ,. Etc. (public/js/eventQueue.js)
I know these are a lot of questions so I would appreciate if anyone can answer them or at least direct me to the correct path to finding out by myself

You can ask the specific questions in gittter channel. Also it will be great if you can help us by documenting them in the project wiki

I would be more than happy to help with this, but i'm not so familiar with github so can you elaborate a little bit more how do you want me to help with the docs?

You can add code related documentations here https://github.com/CircuitVerse/CircuitVerse/wiki

so  i should add a page called ' source code explanation' and add code related stuff to it. right?


Error handling while loading a new report

#345 shows, that the error handling for the loading of a report is clearly problematic. If the app cannot parse the json, there is no error message whatsoever. Instead, we should clearly state that there is a problem, and ideally state the nature of the problem.

can we sum up what are the required error scenarios?

[ ] remote fetch

[ ] 401 (wrong or no creds) https://github.com/dbsystel/trivy-vulnerability-explorer/blob/main/src/components/ReportUrlFetcher.vue#L135

[ ] parser

[ ] invalid json

… ⁉


Dispatch a delayed job to redis

Laravel Version: 5.3.31
PHP Version: 7.0.17

Description:
We're experiencing a bug:
when dispatching a delayed job (thus, after calling delay method on a job object), and we use redis driver to enqueue jobs, the job is not passed (or written) to the Redis database.
Using database driver for queues makes it work as expected.
Steps To Reproduce:

Enable Redis
Configure Laravel in order to use Redis as queue driver
Create a delayed job and call dispatch method to pass it to the queue manager
You won't find the record in Redis database

5.3 is not supported anymore, please upgrade to 5.4 and test again.

@themsaid are you saying that laravel 5.3 doesn't support delayed jobs on a redis queue?


Include timestamp tlv in Child ID Response only when it is necessary

This does not help to pass any certification test, just to make this part specification compliant.

Current coverage is 73.32% (diff: 100%)

Merging #794 into master will decrease coverage by 1.86%

@@             master       #794   diff @@
==========================================
  Files           107        107
  Lines         15007      16001   +994
  Methods        2057       2180   +123
  Messages          0          0
  Branches       1782       1903   +121
==========================================
+ Hits          11284      11733   +449
- Misses         3153       3646   +493
- Partials        570        622    +52

Powered by Codecov. Last update 80d3a3b...6237de1

This PR is ready for merge, please help to review.
(I forgot to increase mRequestTlvs array size in the previous commit which caused travis check failures)

LGTM 👍


new camera light feature

For #2833

Change List

add camera light class
get projected camera position in rendering pipeline
tests

Coverage increased (+0.3%) to 62.071% when pulling 2f8a911215450e2097c57a3a70c7784088fdf4c7 on camera-light into 2fc418d6505f300ad74d818f3b445fea99541cdf on master.

This discussion is getting rather detailed but once the dust settles, might be worth a quick audit of the proposed API changes/logic?
Viewport and project systems are a complex part of deck, and also lighting is an area that is still under active development in both luma and deck, so it is probably worth giving this the extra thought.
Also, have we considered pushing the camera light feature to 7.1? At some point a project needs to accept that certain features missed the "train" and wait on the platform for another 4-5 weeks for the next train.
Perhaps this class can be done application-side if some app cannot wait? While we take the time to audit this and do it right?

Don't forget to add documentation.

Don't forget to add documentation.

Document will be a different PR, postpone that cause I want to make sure team agrees on the solution.

This discussion is getting rather detailed but once the dust settles, might be worth a quick audit of the proposed API changes/logic?
Viewport and project systems are a complex part of deck, and also lighting is an area that is still under active development in both luma and deck, so it is probably worth giving this the extra thought.
Also, have we considered pushing the camera light feature to 7.1? At some point a project needs to accept that certain features missed the "train" and wait on the platform for another 4-5 weeks for the next train.
Perhaps this class can be done application-side if some app cannot wait? While we take the time to audit this and do it right?

Did API audit in jam meeting, as the conclusion we make CameraLight as experimental.


Cycle Verification Diagnostics

Adds a call graph field to the QsCompilation type. The ICallGraphEdge, ICallGraphNode, and ICallGraph interfaces are added. Uses the cycle verification to raise diagnostics.

Closed in favor of #621.


[SPARK-30722][DOCS][FOLLOW-UP] Explicitly mention the same entire input/output length restriction of Series Iterator UDF

What changes were proposed in this pull request?
This PR explicitly mention that the requirement of Iterator of Series to Iterator of Series and Iterator of Multiple Series to Iterator of Series (previously Scalar Iterator pandas UDF).
The actual limitation of this UDF is the same length of the entire input and output, instead of each series's length. Namely you can do something as below:
from typing import Iterator, Tuple
import pandas as pd
from pyspark.sql.functions import pandas_udf

@pandas_udf("long")
def func(
        iterator: Iterator[pd.Series]) -> Iterator[pd.Series]:
    return iter([pd.concat(iterator)])

spark.range(100).select(func("id")).show()

This characteristic allows you to prefetch the data from the iterator to speed up, compared to the regular Scalar to Scalar (previously Scalar pandas UDF).
Why are the changes needed?
To document the correct restriction and characteristics of a feature.
Does this PR introduce any user-facing change?
Yes in the documentation but only in unreleased branches.
How was this patch tested?
Github Actions should test the documentation build

Test build #120998 has started for PR 28160 at commit df340b8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25689/
Test PASSed.

Test build #120998 has finished for PR 28160 at commit df340b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120998/
Test PASSed.

Test build #121007 has started for PR 28160 at commit 9123927.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25699/
Test PASSed.

Test build #121007 has finished for PR 28160 at commit 9123927.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121007/
Test PASSed.

That said, it only requires that the length of entire output is the same of the entire input. But the number of Series and the length of output in each Series don't need to be the same as the input. Is it correct?

@viirya Yes!

Thanks guys, merged to master and branch-3.0.

Thank you so much @BryanCutler.


Stopped working today, anyone else?

Was working fine yesterday and earlier today, then it stopped working.
Here’s what I get when I try to tune in:
Trying to tune to tlc...
Traceback (most recent call last):
File "piptv.py", line 180, in
main()
File "piptv.py", line 176, in main
stb.tune_to_channel(command)
File "piptv.py", line 126, in tune_to_channel
self.player.set_mrl(hotlink)
File "/home/still/.local/lib/python3.5/site-packages/vlc.py", line 3331, in set_mrl
m = self.get_instance().media_new(mrl, *options)
File "/home/still/.local/lib/python3.5/site-packages/vlc.py", line 1908, in media_new
if ':' in mrl and mrl.index(':') > 1:
TypeError: argument of type 'NoneType' is not iterable

When did you download it last?

Still works for me on a fresh clone. Let me know when you're available and I will give you instructions to troubleshoot

When you're back, do the following for me:
open a python shell
type the following:
import requests
import pprint
pprint.pprint(requests.get("http://ustvgo.tv/nfl-network-live-free").text)

Paste the output of that here for me. I have a feeling they may be blocking your IP address range from cloudflare. It happened to another person. If they're blocking your IP, it will explicitly say so in the response. The code above will show us what data is being returned from a request to the site. If the output is huge, and doesn't say anything about blocking your IP, we will move on and try something else. Thank you!

@schwifty42069
Sorry for not getting back to you earlier.
I re-clonned the repo. today right after it stopped working, just in case I missed with the script or something.
I tried the commands you provided, and looks like I'm getting a valid response, as in a wall of HTML code, and nothing indicates that am being blocked, plus I can access the website and stream off it just fine.
Let me know what else I should try.
Thanks!

Hmmm. Alright, let's try and narrow down on where the issue is.
in a python shell try this for me
import requests
from bs4 import BeautifulSoup as Soup

bsoup = Soup(requests.get("http://ustvgo.tv/nfl-network-live-free").text, 'html.parser')
for s in bsoup.findAll("script"):
    if "player.setup" in str(s):
        print(s.next_element.split(" file: ")[1].split(',')[0].strip("\'"))

This is basically just the core scraping logic from the script, if we get back a hotlink, then the problem is likely the python bindings for vlc, which have proven to be a bit of a pain

Looks like they added DDOS protection through cloudflare, which is defeating the script. I am working on a way to patch it... Really disappointing

Yesterday it refused to work at all throwing the above mentioned error, I even suspected the VM itself and gave it a try on a remote DO. VPS of mine. Well, same exact thing.
Today it worked out of the blue and still working to this second! So weird, as like I mentioned before, I'm not blocked by CloudFlare or anything.
And yea, I wasn't trying to stream through VLC (was just trying to get/print the streaming URL), and even tried your 'pmg' script, and same thing, wasn't working yesterday, but started working today.
If you need a hand testing/debugging anything, just let know. I have Windows, Mac, and Linux machines at hand.

I just wrote a patch. it adds a dependency cfscrape, you will also need to have nodejs installed, but I just tested it and it worked for me, give it a try for me?

Wait whattt? Haha that is so weird.  I would love some help debugging for MacOS. I will leave this issue open for you to respond, then I will close. Will need some real contact info from you haha

Got the same issue today with the exact same error I posted earlier, with both the old script and the new one, and in both cases just to eliminate the VLC side of things I just comment out 'self.run()' line, and add 'print(hotlink)' in the 'tune_to_channel' function.
Let me know how to proceed with this issue, and also with debugging on MacOS.
You can reach me on mhany (a t) stillcode.com


Indent Type Support

Are there any plans to allow users to set indent size? Personally, I prefer tabs to spaces and the extension doesn't seem to inherit the file's preferred spacing method.

@HowdyMcGee
You can set indent size from vscode options.

Tab support will introduce with next minor release or update.
You can also format blade files programatically by blade-formatter. It already supports tabs.


[PR] The proj files have been updated to enable SourceLink

CSProj files have been updated to enable SourceLink in your nuget
[This pull request was created with an automated workflow]
I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.
We have to take 2 steps:

Please approve this pull request and make .NET a better place for .NET developers and their debugging.
Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink
https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx
If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater
If you notice any flaws, please comment and I will try to make fixes manually

Thanks, I applied the change in a slighly different way, using embedded PDB instead of snupkg.

Sorry about that, a lot of mismatches in git repo search...

No problem. You’re doing a great thing. Thanks!


24 hrs format not working properly

Hi,
24 hrs format not working properly in end hours (55 mins like that)
For Ex : current time is 5:55 PM
show  time picker 18:55 like that

Can you show me the steps to reproduce this issue?

Hi,
Please change the system time (For Ex : 10:50 PM)
http://rajeshwarpatlolla.github.io/TimePickerForIonicFramework/demo/#/tab/timepicker
see below image
System time is 10:46 PM
Open your demo time picker and see the time in 24 format (show 23:45 this wrong  ---> correct time is 22:45)

Hi,
Fixed above issues in 24 hrs format
added parseInt, see below code
function o(i, e) {
r.time.hours =parseInt(i / 3600);
var t = i % 3600;
12 == e && (r.time.hours > 12 ? (r.time.hours -= 12, r.time.meridian = "PM") : r.time.meridian = "AM"), r.time.minutes = t / 60, r.time.hours = r.time.hours.toFixed(0), r.time.minutes = r.time.minutes.toFixed(0), 1 == r.time.hours.toString().length && (r.time.hours = "0" + r.time.hours), 1 == r.time.minutes.toString().length && (r.time.minutes = "0" + r.time.minutes), r.time.format = r.mainObj.format
}

Hi,
I am also facing the same issue. 24 hrs format not working properly in end hours like after 30 minutes it shows 1 hour more in time picker.

Hi,
I fixed this issue
On Wed, Dec 28, 2016 at 6:14 PM, jyotigupta007<EMAIL_ADDRESS>wrote:

Hi,
I am also facing the same issue. 24 hrs format not working properly in end
hours like after 30 minutes it shows 1 hour more in time picker.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rajeshwarpatlolla/ionic-timepicker/issues/101#issuecomment-269472316,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE19_N5k55Ey0TIB_Cdt05Crx1RK67TMks5rMlmugaJpZM4KP5ES
.

--
Regards
A.ILAHIR RAHMAN ALI
Mobile No : +91<PHONE_NUMBER>

Hi Ilahir,
I have changed in min file as you have mentioned in your above comment.
Thanks for your help.


Documentation: supplement setup guide with AWS CLI examples

In addition to screenshots we could append CLI example to each step, for example for Redshift cluster:
aws redshift create-cluster --node-type dw.hs1.xlarge --number-of-nodes 1 --cluster-identifier snowplow --db-name pbz --master-username admin --master-user-password TopSecret1

So it will be more readable and less chances to be outdated.

Putting some commands here so we could take it from one place when we'll have a time for documentation.
Setting up Clojure Collector:
aws elasticbeanstalk create-application --application-name analytics

aws elasticbeanstalk create-application-version
    --application-name analytics
    --version-label clojure-collector
    --cli-input-json "{\"SourceBundle\":{\"S3Bucket\":\"snowplow-hosted-assets\",\"S3Key\":\"2-collectors/clojure-collector/clojure-collector-1.1.0-standalone.war\"}}"

aws elasticbeanstalk create-environment
    --application-name analytics
    --environment-name collector
    --solution-stack-name "64bit Amazon Linux 2015.09 v2.0.4 running Tomcat 8 Java 8"
    --version-label clojure-collector

Still need to enable S3 log rotation in AWS Console.

Thanks @chuwy !

Leaving here everything I collected so far.
This tutorial assumes it's your first installation and you probably want just to checkout platform,
thus many steps describe low-performance and unsecure installation. On real-world you may want to fix that.
Prepare your system
Before get started you need to have:

Account on Amazon Web Services
Installed AWS CLI
IAM user, first one need to be created in AWS Console
IAM user need to have attached AdministratorAccess (permissions tab)
Configured credentials on your local machine. you can use aws configure for it
For some steps you may want to install jq. It's optional, but handy.

Everything else can be done from CLI.
Setting up EC2 instance for EmrEtlRunner/StorageLoader
In the end of this step you'll have an AWS EC2 instance, SSH access to it and key on local-machine. Nothing snowplow-specific though.
1. Find your Default VPC ID
We will refer to it as {{ VPC_ID }}
$ aws ec2 describe-vpcs | jq -r ".Vpcs[0].VpcId"

2. Create Security Group for SSH access
TODO: For demo purpose probably would be better to create a single SG for all full-access (SSH, Redshift, etc). Also, investigate something more strict..
On output you'll get GroupId, we will refer to it as {{ SSH_SG }}.
$ aws ec2 create-security-group
    --group-name "EC2 SSH full access"
    --description "Unsafe. Use for demonstration only"
    --vpc-id {{ VPC_ID }} \
    | jq -r '.GroupId'

3. Add rule allowing SSH access from anywhere
$ aws ec2 authorize-security-group-ingress
    --group-id {{ SSH_SG }}
    --protocol tcp
    --port 22
    --cidr <IP_ADDRESS>/0

4. Create SSH key-pair named snowplow-ec2 on local machine:
$ aws ec2 create-key-pair --key-name snowplow-ec2 \
    | jq -r ".KeyMaterial" > ~/.ssh/snowplow-ec2.pem
$ chmod go-rwx ~/.ssh/snowplow-ec2.pem

5. Run t2.small instance with Amazon Linux AMI with previously created SSH-key:
On output you will get your instance id, we will refer to it as {{ INSTANCE_ID }}
$ aws ec2 run-instances
    --image-id ami-60b6c60a
    --count 1
    --instance-type t2.small
    --key-name snowplow-ec2 \
    | jq -r '.Instances[0].InstanceId'

6. Attach security group to Instance
$ aws ec2 modify-instance-attribute
    --instance-id {{ INSTANCE_ID }}
    --groups {{ SSH_SG }}

7. Check public IP-address of newly created Instance:
Further we will refer to it as {{ PUBLIC_IP }}
$ aws ec2 describe-instances
    --instance-ids {{ INSTANCE_ID }}
    --profile prsn
    --region us-east-1 \
    | jq '.Reservations[0].Instances[0].PublicDnsName'

8. Log-in
Fill-in {{ PUBLIC_IP }} from previous step.
$ ssh -i ~/.ssh/aws-ec2.pem ec2-user@{{ PUBLIC_IP }}

Create Redshift cluster
In the end of this step you'll have running Redshift cluster. Your next step will be to create tables for your data and run StorageLoader.
1. Create Redshift cluster
$ aws redshift create-cluster
    --node-type dc1.large
    --cluster-type single-node
    --cluster-identifier snowplow
    --db-name pbz
    --master-username admin
    --master-user-password TopSecret1

This command may take some time, if you'll get some errors on further steps, that probably because cluster isn't running yet.
2. Create security group
On output you'll get GroupId, we'll refer to it as {{ REDSHIFT_SG }}.
aws ec2 create-security-group
    --group-name "Redshift unimited access"
    --description "Unsafe. Use for demonstration only"
    --vpc-id {{ VPC_ID }} \
    | jq -r '.GroupId'

3. Add access rules to new security group
aws ec2 authorize-security-group-ingress
    --group-id {{ REDSHIFT_SG }}
    --protocol tcp
    --port 5439
    --cidr <IP_ADDRESS>/0

4. Tie previously created security to our cluster
On output you'll get cluster address, we'll refer to it as {{ REDSHIFT_ADDRESS }}
aws redshift modify-cluster
    --cluster-id snowplow
    --vpc-security-group-ids {{ REDSHIFT_SG }} \
    | jq -r '.Cluster.Endpoint.Address'

5. Connect
$ psql -h {{ REDSHIFT_ADDRESS }} -U admin -d pbz -p 5439

Thanks for capturing all this @chuwy !

Hi @chuwy, thanks for writing this! I just used it to set up a clojure collector on elastic beanstalk.
As time has passed unfortunately Amazon have changed the elasticbeanstalk setup UI to the point where it no longer matches up with the guide here https://github.com/snowplow/snowplow/wiki/Setting-up-the-Clojure-collector. So having the CLI instructions has really helped as they seem to change less.
I had to make a small alteration to get it to work as of today :-
 aws elasticbeanstalk create-environment \
    --application-name analytics \
    --environment-name collector \
    --solution-stack-name "64bit Amazon Linux 2015.09 v2.0.4 running Tomcat 8 Java 8" \
    --version-label clojure-collector \
    | jq -r '.EnvironmentId'

returned
A client error (InvalidParameterValue) occurred when calling the CreateEnvironment operation: No Solution Stack named '64bit Amazon Linux 2015.09 v2.0.4 running Tomcat 8 Java 8' found.

So using
aws elasticbeanstalk list-available-solution-stacks
I could see it's been updated to 64bit Amazon Linux 2015.09 v2.0.6 running Tomcat 8 Java 8
replacing the solution-stack-name with this fixed it, however it didn't return the environment id. I found this by looking it up on the AWS web UI.
Everything else worked fine (I hope!). Thanks!

Hey @ninjabear! I glad it helped someone and extremely appreciate your addition (since I haven't chance to test it meticulously). Hope someday it will evolve to full setup tutorial.
As for stack name, I'm pretty surprised they do not allow it. I'll need to update that most recent stack can be fetched with following:
$ aws elasticbeanstalk list-available-solution-stacks \
    | jq -r '.SolutionStacks[]' \
    | grep "Tomcat 8 Java 8" \
    | head -n 1

I think at least in terms of the clojure collector it could become a one-stop setup script - the instructions could be something like "run this" - curl http://<something>/clojure-elasticbeanstalk.sh | bash.
Aside from saving the user a bit of time and possible headscratching it also gives the bonus of making the instructions provably correct - we can put them under test by running the script and quizzing aws afterwards. That would mean we don't need to play catchup with AWS quite so much.

Augmenting the setup guide with aws cli commands is a great idea - assigning to @ihortom ...

@alexanderdean / @chuwy - I added AWS CLI instructions to the relevant pages. Additionally, I created a new page (and set references to it) describing how to set up EC2 instance. All the instructions (with ocasional amendment) are taken from this issue page.

Awesome - pushed! Thanks so much @ihortom


12345678910 in this pattern (0,0.[000000000]) corrupts value

12345678910 in this pattern (0,0.[000000000]) corrupts value
result is 12,345,678,910.000001907

This is a floating point error, but not something this library aims to fix at this time.


[v1.0.0] TypeError: list indices must be integers or slices, not str

Hi,
We are using XGBoost 0.9 with a custom script that load datasets from HDF5 and train or test an XGBClassifier with the ability to tune parameters and evaluate results. We are using it in production and we did not have any issue until now.
When we upgraded to v1.0.0, the same script gives this error when fit() function is called:
Traceback (most recent call last):
  File "iris.py", line 12, in <module>
    model.fit(train_x, train_y, verbose=True, eval_set=[(train_x, train_y), (test_x, test_y)], early_stopping_rounds=20, eval_metric=['merror', 'mlogloss'])
  File "/home/bartoli/.virtualenvs/xgb/lib/python3.6/site-packages/xgboost/sklearn.py", line 823, in fit
    callbacks=callbacks)
  File "/home/bartoli/.virtualenvs/xgb/lib/python3.6/site-packages/xgboost/training.py", line 209, in train
    xgb_model=xgb_model, callbacks=callbacks)
  File "/home/bartoli/.virtualenvs/xgb/lib/python3.6/site-packages/xgboost/training.py", line 42, in _train_internal
    'num_parallel_tree'] is not None:
TypeError: list indices must be integers or slices, not str

It seems that the error is raised by XGBoost when we use two metrics in eval_metric parameters in the fit() function as we did before. We wrote a small script to test this behaviour:
import xgboost as xgb
from h5py import File
from sklearn.model_selection import train_test_split

db = File('iris.h5', 'r')
train_x, test_x, train_y, test_y = train_test_split(db['data'][:], db['target'][:], test_size=0.2)
model = xgb.XGBClassifier(objective='multi:softmax', n_jobs=-1, n_estimators=100,
                          max_depth=5, learning_rate=0.1, subsample=0.8, colsample_bytree=0.9)

# This call works
model.fit(train_x, train_y, verbose=True, eval_set=[(train_x, train_y), (test_x, test_y)], early_stopping_rounds=20)

# This call does not work
model.fit(train_x, train_y, verbose=True, eval_set=[(train_x, train_y), (test_x, test_y)], early_stopping_rounds=20, eval_metric=['merror', 'mlogloss'])

This is the example dataset to test it out, can you reproduce this bug?
iris.zip

Yes.  It's fixed in 1.0.2 pending as a patch release: https://github.com/dmlc/xgboost/issues/5342

@GuidoBartoli We just release 1.0.2.

@GuidoBartoli We just released 1.0.2.

That’s really a good news, I’ll update and try again, thanks!


Add encrypted RBD storage class during deployment

Add a new encrypted RBD storage class during cluster deployment, if the customer asked for PV encryption.
URL: https://issues.redhat.com/browse/RHSTOR-2269

This change is LGTM
cc: @umangachapagain, @jarrpa requesting for further reviews.

 - ClusterWide and StorageClass are the two different flags to intimate the OCS operator to which type of encryption the user wants to enable.
  - ClusterWide is an OSD level encryption and StorageClass is a PV level encryption.
  - When KMS is enabled,
        For ClusterWide encryption, KMS connection details are passed into CephCluster CR as well as Noobaa CR for the OSD encryption and RGW encryption. (KMS is optional for ClusterWide encryption).
        For StorageClass encryption, the OCS operator will create one extra StorageClass with encryption enabled. All PVCs which is created using this encrypted StorageClass on openshift-storage namespace are encrypted automatically. to create encrypted PVCs on other namespaces user has to create a tenant token on the corresponding namespace [https://github.com/openshift/ceph-csi/blob/release-4.7/docs/design/proposals/encryption-with-vault-tokens.md#configuration-stored-in-the-tenants-kubernetes-namespace](URL).

/test red-hat-storage-ocs-ci-e2e-aws

/test red-hat-storage-ocs-ci-e2e-aws

This will not work for users upgrading from 4.9 to 4.10.
In OCS 4.9
Enable: true
ClusterWide: false (or nil)
StorageClass: false (or nil)

which means Encryption is enabled.
When upgraded to OCS 4.10, we ignore enabled and other fields are false which means encryption is disabled.

We are taking that in account as well, in the follow up PR (https://github.com/red-hat-storage/ocs-operator/pull/1417)
PTAL: https://github.com/red-hat-storage/ocs-operator/pull/1417/commits/fbbf5f5d47eb02aea4d9604b73fd522546dfc813#r773616046

/test red-hat-storage-ocs-ci-e2e-aws


chore(deps): bump https://github.com/jenkins-x/jx-cli to 3.0.168

Update jenkins-x/jx-cli to 3.0.168
Command run was ./promote/main

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
978c7ff4e4ead4e48912cf385dfd564bc37e0eda
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Complete Japanese translation

Because the Japanese translation was not completed, I added remaining parts.

Build is completed successfully in my local environment!


Fix minikube image 'project:hello-minikube-zero-install' has been suspended.

See #20530, the description for pull image 'project:hello-minikube-zero-install' seems wrong, and this PR is going to fix this.

/assign @zacharysarah

Can confirm this new url fixes the issue.

/assign

Lou-lan thank you for your contribution. Can you make this echoserver:1.4 so it matches what is on https://minikube.sigs.k8s.io/docs/start/
Also you need break this up into multiple PRs where you have one per language. In general it causes problems later if we have a single PR crossing over multiple languages.

Thanks for the suggestion, I will modify it and decompose it into multiple PRs.

@lou-lan are you still working on this?


Using a number to define element ids doesn't work with CSS

I'm inserting Framer into some other web content, and the way that div ids are defined is problematic for detection within css.
I've fixed this on my own copy of framer.js with just changing how the id is defined by adding "framer-" to the beginning. I've also added a function to define to get and set the id and the element id to the supplied value:
View.define("viewId", {
      get: function() {
        return this.id;
      },
      set: function(value) {
        this.id = value;
        this._element.id = value;
        return this._element.setAttribute("id", this.id);
      }
    });

I would add this to source and push it to my fork, but I am having some whitespace issues and just coffeescript in general, plus, I'm not sure what the effects of this down the line might be, thought I'd post it here before doing anything like that.

Aaaaand it's fixed.


Out of bounds error in csg_reupdate

https://github.com/votca/csg/blob/dd97ff3601c415706cd7468983f379105fd550cb/src/tools/csg_reupdate.cc#L691-L699

@symashayak can you have a look please?

My guess is that, this is what was meant:
 for (int i = dist.size() - 2; i > 0; i--) {
     if (dist.y(i) < 1.0e-4) {
         new_min = dist.x(i + 1);
         break;
      }
  }

@symashayak ping

Not sure what is the error. Original loop bounds look good to me. Where are you seeing this error?

The first iteration was calling
dist.x(dist.size)
which is an out of bounds error.

Ok. I understand. This would happen when RDF (dist) is zero very close to
the cut-off distance.Wouldn't it be unrealistic to have an RDF value ~zero
close to the cut-off distance? In any case, to avoid this out of bounds
error, your solution of changing loop begin bound from  i = dist.size() - 1
to  i = dist.size() - 2 should work. However, in such rare case, even if we
avoid out of bounds error, I believe, relative entropy minimization
iteration might not proceed due to numerical instability in Hessian.
On Sun, Jun 30, 2019 at 8:28 AM Joshua S Brown<EMAIL_ADDRESS>wrote:

The first iteration was calling
dist.x(dist.size)
which is an out of bounds error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/votca/csg/issues/382?email_source=notifications&email_token=AA53KNR74TKE2KE2VLK4IMDP5DGKPA5CNFSM4H3AJQL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4OLNY#issuecomment-507045303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA53KNWCKLFGFZDC2ILBC4LP5DGKPANCNFSM4H3AJQLQ
.

@symashayak thanks for the clarification, I just needed to know that the code fix I was proposing wasn't going to break anything.

Fixed in 75a2ad62744893bb07f1fa4538cd8df85a93433d


Reusing orbit-db instance or ipfs repo / data/blockstore between tabs on the same browser

I've been playing around with js-ipfs and orbit-db for a bit, and I came across a particular use-case that I can't get working easily. Forgive me if I seem terribly confused, this is quite new to me.
Everything is working as expected for my test app: In order to persist orbit-db instances locally I am using the same unchanging repo-name for my js-ipfs node. And after I found that orbit-db instances only sync after the first new message is received from any newly discovered nodes I've implemented a basic "introduction" routine for cold-syncing newly re/initialized db instances.
But what I really need for my use-case is for these orbit-db instances to not only sync across different browsers but also on the same browser when opened in different tabs, while also having persistent data.
Pubsub doesn't work if a js-ipfs repo-name is shared on the same browser. Not only can they not communicate between themselves, only one of these orbit-db instances sync with instances on other browsers. So right now I am resorting to offsetting my base repo-name with an index for every new js-ipfs node after the first for my one app. That way, it behaves like a "foreign" instance with a distinct repo id and all.
But doing so duplicates a lot of data on the IndexDB, especially the 'blocks'. A lot of data that I feel like shouldn't need to be duplicated as they're replicated across all of the orbit-db instances anyway even on the browser-local siblings tabs stored under the same domain in IDB, just a on a differently named IDB object.
Is there no way to reuse the existing repo from the first loaded tab on the same browser and same domain on every other newly loaded tabs while also being able to pubsub between them? If not the repo then can we not at least reuse the datastore or blockstore (whichever is relevant,) to the same effect?
I suspect that this may be more of a question for js-ipfs than orbit-db, but the use-case feels closer to orbit-db's concerns, so I decided to create this issue here first.

Today I learned that it's possible to define a custom peer-id for js-ipfs nodes via config. I tried setting a random peer-id for every new node in my app while still using the same repo-name, and it pubsub still worked! The orbit-db instances persist locally and can sync within sibling tabs (as well the usual foreign tabs.)
I noticed that overriding a js-ipfs node's peer-id also stores that new peer-id to the repo, but since every new node has a distinct peer-id set manually instead of the one loaded from IDB it still works out.
I don't know if this will have undesirable repercussions yet, but my use-case now works! Will keep looking for signs of trouble, or if a better / more official solutions comes along.


feat: Add getCommunicationInfo method and new prop to SafeInfo

What it solves
Resolves https://github.com/gnosis/safe-apps-sdk/issues/301, resolves https://github.com/gnosis/safe-react-apps/issues/374
How this PR fixes it
We are doing 2 different things here:

Adding a new method getCommunicationInfo() used by returning some info about the communicator. By now we are returning the origin as we need it in the walletConnect app and is difficult to get it inside an iframe (Current approach ancestorOrigins is not supported on Firefox

We are including a new property isReadOnly on the SafeInfo object allowing as to know safe apps if the safe-web is on READ-ONLY mode

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 34.865%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Apps/components/AppFrame.tsx
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/safe/components/Apps/components/AppFrame.tsx
2
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
3375

Relevant Lines:
8772

💛  - Coveralls


steps 3 and 4 and duplicate

[Enter feedback here]
steps 3 and 4 and duplicate

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7a456d5b-3cff-be3f-f227-3533bc46c765
Version Independent ID: f2ea1560-6787-7618-312d-78031ed5a73b
Content: Configure CI/CD with Azure Pipelines - Azure App Service
Content Source: articles/app-service/deploy-azure-pipelines.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: jukullam

@jivjotlotey-phsa
Thanks for your feedback! We will investigate and update as appropriate.


Update PUDL to new major versions of key dependencies

Several of our key dependencies have released or are about to release major versions that probably include breaking changes. The dust probably won't settle between them until 2023Q2, so we can wait until then to update PUDL.
- [ ] #2383
- [ ] #2394
- [ ] #2395
- [ ] https://github.com/catalyst-cooperative/pudl/issues/2842
- [ ] #2854

Can we close this issue?

Yes, we're on to other dependencies now :)


Support global subscribe rate limit policy on topic #13347

Is your enhancement request related to a problem? Please describe.
For a topic on Pulsar, if there are multiple consumers, is there a good way to limit the global consumption rate at the topic level ?
In other words, We hope to control the total amount of consumer traffic for this topic, no matter how many consumers there are downstream.
Pulsar can only set subscribe rate limit for every consumer by using command set-subscribe-rate on namespaces or topic.
Describe the solution you'd like
Support global rate limit on a topic, no matter how many consumers.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@zbye
I think this feature fit you.
https://github.com/apache/pulsar/issues/13444

@mattisonchao   I'm sorry. We want to control the subscribe rate for a specific topic in a pulsar cluster.  The command "set-dispatch-rate" is "Set subscribe-rate per consumer for a namespace or topic", we can only control every consumer.
For example, we set subscribe-rate 10 msg/s for a topic, when there is 5 consumers, the whole consumption rate is 10*5. If we have a way to set a global rate control on a topic,  no matter how many consumer deployed，the max whole consumption rate  is below 10 msg/s.
https://pulsar.apache.org/docs/en/pulsar-admin/#set-subscribe-rate

ohhh, i see.

@zbye
I see,
So, how do you want to config this?
could you give me a example, i think i can work on this.

For example, we can use "set-global-dispatch-rate" to control the total rate limits for a namespace or topic (from a different dimension).  This is different from "set-dispatch-rate", which used to set rate limits for each consumers.  thanks a lot.

Current "global policy" refers to topic policies across clusters.
"dispatch-rate" is topic level rate limiter, it limits all the consumer for a non-partitioned topic.
"subscription-dispatch-rate" is subscription level rate limiter.

@Jason918 that is, "pulsar-admin set-dispatch-rate" has already meet  the need ?

@Jason918 that is, "pulsar-admin set-dispatch-rate" has already meet the need ?

I think so, you can try it out for yourself.
Notice that there is a config dispatchThrottlingOnNonBacklogConsumerEnabled about the throttling.


backup branch when backup not exists

I want to move to use github instead of hard coded version, like the example below:
pinax = { git = "https://github.com/pinax/pinax.git", ref = "<branch_name>" }
in there a way to use repo default branch in case the branch on exsits?
if this case failed:
pinax = { git = "https://github.com/pinax/pinax.git", ref = "branch_name" }
i would like to to use:
pinax = { git = "https://github.com/pinax/pinax.git", ref = "main" }

There is not currently a way to do this.


Add file in error message

Problem
For these lines:
https://github.com/michael-ciniawsky/postcss-load-config/blob/348fb5b62fcd01f93cfc768859a82458e093d035/index.js#L63-L67
We won't know what postcss config file it's loading when some error is thrown by either loadPlugins  or loadOptions. So it's very hard to debug...
Solution
Add file info in error message

Good idea I started working on a new major (only dropping theoretical node >= 0.12 support and a few minor changes) and will include this, but it can take a while since I'm mostly busy with work atm. postcss-load-plugins #42 you opened a while ago will also be included there then


Annotation Result Array Index

I am doing batch annotation for Vision API and it works fine. But how do I know which annotation result is for which input image? Output array keys are always 0 and does not consider if custom index value is provided for array.
images[17] = get_image()
images[20] = get_image()
$annotation = $vision->annotateBatch($images);

Would array_values on the images array work for you? That should give you an input you can correspond to the annotation.

As per my observation the annotation result array always has index starting from 0 and not the array key value I set for the input images array.
In my CMS each image has an ID value(auto incremented) and I do some operation based on the annotation result. So I need a way to match the annotation result to an ID.
Hope I am making sense.

I think I understand your problem. Let me try to explain my idea of using array_values to solve it.
First, we have a set of image with non-standard indexes. Let's say we're using running a couple images on Cloud Storage through Cloud Vision:
$images = [];
$image['foo'] = new Google\Cloud\Vision\Image($storageObject1, ['FACE_DETECTION']);
$image['bar'] = new Google\Cloud\Vision\Image($storageObject2, ['FACE_DETECTION']);

$annotations = $cloud->vision()->annotateBatch($images);

$annotations will come back as type Annotation[] (an array of Annotations. Lets use array_values to print the image and some info about the faces.
After we run array_values, our input should line up with the output.
$zeroIndexedInput = array_values($images);

foreach ($zeroIndexedInput as $index => $image) {
    echo 'Cloud Storage Filename: $image->requestObject()['source']['gcsImageUri'];
    echo PHP_EOL;
    echo 'The first face in the resultset is ';
    echo ($annotations[$index]->faces()[0]->isAngry())
              ? 'angry'
              : 'not angry';
}

Hope this makes sense. If I'm unfortunately missing the point of your question, perhaps a bit of code would help illustrate!

This is exactly I am looking for. What I was not sure is the order of the result.
Thanks for the help.


list of TXT records with different TTL's?

Does OctoDNS support having a list of TXT records with different TTLs?
Currently I am not able to do something like:
---
? ''
: - octodns:
      cloudflare:
        proxied: false
    ttl: 1
    type: A
    values:
    - <IP_ADDRESS>
    - <IP_ADDRESS>
    - <IP_ADDRESS>
  - ttl: 1
    type: MX
    values:
    - exchange: mail1.mydomain.com.
      preference: 10
    - exchange: mail2.mydomain.com.
      preference: 15
  - ttl: 7200
    type: TXT
    values:
    - MS=ms11111111
    - v=spf1 include:_spf.mydomain.com include:servers.mcsv.net -all
  - ttl: 3600
    type: TXT
    values:
    - THING1=thing1
    - THING2=thing2

When doing the above I get:
Traceback (most recent call last):
  File "/srv/dns/env/bin/octodns-sync", line 11, in <module>
    sys.exit(main())
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/cmds/sync.py", line 39, in main
    dry_run=not args.doit, force=args.force)
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/manager.py", line 301, in sync
    plans = [p for f in futures for p in f.result()]
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/manager.py", line 56, in result
    return self.func(*self.args, **self.kwargs)
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/manager.py", line 224, in _populate_and_plan
    source.populate(zone)
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/provider/yaml.py", line 77, in populate
    self._populate_from_file(filename, zone, lenient)
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/provider/yaml.py", line 62, in _populate_from_file
    zone.add_record(record, lenient=lenient)
  File "/srv/dns/env/lib/python2.7/site-packages/octodns/zone.py", line 84, in add_record
    record._type))
octodns.zone.DuplicateRecordException: Duplicate record mydomain.com., type TXT

Does OctoDNS support having a list of TXT records with different TTLs?

Not currently and tbh the schema/semantics wouldn't really support it very easily. I'm pretty sure that (at least) some providers wouldn't support it either. Many of them seem to accept a single object with a TTL and a list of values. Are you currently running things this way with a DNS provider currently? Which one(s)?

Currently with Cloudflare. It's only come up one time so it's likely not a big problem. We were able to manually add the record.

A resource record set (the set of records which share an owner name, class, and type) must have identical TTLs on all records of the set, so I think this is not an issue.


Remove the hard coded TaggableManager  name

Ref issue #2

Thanks for adding this. I'll try to take a look tomorrow.

Thanks @leesolway! This is available on PyPI as 0.2.0 now.


Which file should I run ?

Can you describe more details about the file's usage ? Thx

My apology to you, I've just opened this repository and got no time to write an introduction. I am handling with the experiments about this model recently, and there still are some places needed to be fixed. Maybe I could finish this in the month. Sorry again...

My apology to you, I've just opened this repository and got no time to write an introduction. I am handling with the experiments about this model recently, and there still are some places needed to be fixed. Maybe I could finish this in the month. Sorry again...


variables, functions and classes names

The names of the functions, variables and classes currently doesn't follow any standard (some are in English, other in Portuguese, some are separated by underline, other no, etc.). A standard should be defined and all of the names should be coherent.

a nice standard that could be used:
https://github.com/RobotLocomotion/drake/wiki/Code-Style-Guide


Fix duplicated groups being added via addstudent command

closes #245

Test using addstudent -n john -i e1111111 -g R01A -g R01A
Added a test for this duplicate group behaviour too

Codecov Report

Merging #255 (5f50204) into master (1f4216f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master     #255   +/-   ##
=========================================
  Coverage     66.19%   66.19%
  Complexity      797      797
=========================================
  Files           106      106
  Lines          2846     2849    +3
  Branches        378      379    +1
=========================================
+ Hits           1884     1886    +2
  Misses          860      860
- Partials        102      103    +1

Impacted Files
Coverage Δ

...a/seedu/address/logic/parser/AddCommandParser.java
94.11% <66.66%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4216f...5f50204. Read the comment docs.


Add Survey to DrawerMenu

Issue

close #551

Overview (Required)

Adds external link to Google Forms

Screenshot

Thanks 👍 LGTM 💯


test for @schema_prefix for 2 tables

This test fails.

We are not going to do it cross schema because it is not guarantee to work. We are going to use it only for from and you are the one responsible for keeping it together.

This is idea to have schema. To work with tables from one or more schemes.
Not happy at all with this model.
I can't join hr.persons and main.cities
I will wait for more users to ask for this.
Thanks.