Export APIs to implement custom benchmark runner

Motivation

benchmark module is designed to be able to run arbitrary Runner implementation, not only built-in DecatonRunner
But currently, running custom Runner implementation cannot be done without modifying decaton repository itself since benchmark module is not published
This PR exports small subset of benchmark module as benchmark-api, rather than publishing entire benchmark module which includes various classes not necessary for implementing custom Runner

Changes
add benchmark-api module

along with brief guide of how to implement custom Runner
regarding this change, Runner#init interface has changed a bit to receive ProcessCallback rather than entire Recording not to expose Recording's implementation details

communicate ForkingExecution <-> benchmarker via RMI

change interprocess communication to RMI
currently, interprocess communication is done through stdout

but this forces custom runner not to output any information to stdout (and it isn't documented anywhere)
we shouldn't restrict use of stdout since we usually output debug information to stdout

example repository: https://github.com/ocadaruma/decaton-benchmark-comparison

Before start reviewing this PR I'd like to ask few questions about the motivation.

But currently, running custom Runner implementation cannot be done without modifying decaton repository itself since benchmark module is not published

What's the actual problem here?
I thought first publish benchmark module locally and develop a Runner with adding dependency to that, build a .jar containing Runner implementation and run debm.sh with classpath pointing to that jar file just works.
Since we don't expect many users to write a benchmark based on our benchmark module, this way just works for decaton devs.

communicate ForkingExecution <-> benchmarker via RMI

I think this is a separate one from the above. and yeah.. I can understand that.
I think as a common protocol in unix systems, such debug information should go to stderr rather than stdout since stdout is expected to be used for I/O of essential data rather than random messages for users.
However in reality its usage differs among different commands and in fact I've had struggled to troubleshoot malfunctioning benchmark by stdout output issued by profiler.sh .. so I can agree with pursuing an alternative approach for communicating with child processes.
Do you think we have some possible alternatives to  RMI? how about creating a pipe manually?

At least we have to disable noPublish even for local publish I think? (refs https://docs.gradle.org/current/userguide/publishing_maven.html#publishing_maven:install)

there's no need of modifying decaton repository

So, options here are:

disable noPublish and publish to maven central as well as other modules
or, introduce a mechanism to just publishing to maven-local (not to maven central)

I prefer former one because I think it's important to make benchmark reproduction in same condition easy as much as possible for everyone (not only Decaton dev), for reliability of benchmark-comparison (which is the main purpose of pluggable Runner).
If we see a benchmark code which depends on benchmark module published locally on benchmark executor's local machine, isn't it difficult to confirm it's valid and reproduce it in same condition?

What's the actual problem here?

Then, why I separated benchmark-api rather than just publishing benchmark is just to avoid redistribution of many libs (we shade benchmark module entirely, so if we publish it doesn't it cause a lot of redistributions)
Yeah there are other options but I think RMI is appropriate this time as below reasons:

I/F can be type-safe and easy-to understand (rather than bringing another I/F layer such like Stage should be serialized as String for name() and each message should be delimited by newline)
OS-agnostic
Code is simple enough I think?

Means named pipe? I'm not sure we do that in Java in simple while non OS dependent way (though our main target is *nix, isn't good to make it OS agnostic basically?)

creating pipe manually

At least we have to disable noPublish even for local publish I think?

Ah... I see missed that point.

I think it's important to make benchmark reproduction in same condition easy as much as possible for everyone (not only Decaton dev), for reliability of benchmark-comparison (which is the main purpose of pluggable Runner).
If we see a benchmark code which depends on benchmark module published locally on benchmark executor's local machine, isn't it difficult to confirm it's valid and reproduce it in same condition?

I think it's important to make benchmark reproduction in same condition easy as much as possible for everyone (not only Decaton dev),

Agree.

If we see a benchmark code which depends on benchmark module published locally on benchmark executor's local machine, isn't it difficult to confirm it's valid and reproduce it in same condition?

but I'm not sure about this.
The compiled class file should be the same as long as the source code is the same, and I don't see how published artifact contributes to keep environment consistent among different people's machines.
I think people rather needs to be careful for aligning javac version, JVM version and machine setup to make reproducible results which is out of our control. (so reproducible benchmark is really not an easy problem in the first place)
Even though we publish benchmark-api artifact, people still needs to build benchmark.jar manually running build in this repository to get runtime because we don't want to ship shadow jar that includes all binaries of dependencies, which makes us need to list them all in regards to their license as you said.
So while I don't see any major downsides of publishing artifact in maven central (maybe we need to clarify that we don't care about it's API compatibility or stability?), I don't see any benefits of doing it either.
Do you see any benefits besides the reproducibility?

RMI

I see. Actually what I had in my mind is future stability of RMI since recently I never saw any applications using it for practical purpose TBH...
I saw https://openjdk.java.net/jeps/385 this kind of thing and bit concerned, but according to @ykubota there's no topic about deprecation of RMI itself so it should be fine.

unix pipe

another idea would be to use object input/output stream if we have to listen to a port anyway, but well no much difference.

Hm that's right, then it sounds no much difference in terms of benchmark reproducibility.

Even though we publish benchmark-api artifact, people still needs to build benchmark.jar manually

Then, benefit here will be just a gradle script matter I think?
If we don't publish it to maven central, we have to add a mechanism to allow only local publish somehow (which shouldn't be so hard but sounds bit tricky isn't it?)
I see. Thanks for confirming.

but according to @ykubota there's no topic about deprecation of RMI itself so it should be fine

Ah, or just exclude by publish.sh (anyway it sounds bit awkward)

we have to add a mechanism to allow only local publish somehow

we have to add a mechanism to allow only local publish somehow

It seems not so difficult with few more flags added?
https://docs.gradle.org/current/userguide/publishing_customization.html#sec:publishing_maven:conditional_publishing
anyway if you're strong about that, I can agree with proceeding as-is. It doesn't make sense to me, but still isn't a big deal :)

Hm, I tested locally and confirmed controlling by onlyIf just simply worked.. (and running a test by depending on local-published shadowed benchmark also worked)
Then it seems fine with current repository structure. (maybe I'm too paranoid to minimize dependency which is exposed to custom runner project..)
So I'll change this PR goal to

change IPC to RMI
make benchmark project to published locally

Sounds fine?

Ya, that sounds reasonable :)

Thanks, then ready to review

Checking if there's extra overhead with RMI:

I ran RMI-version of benchmark jar several times with --profile, but I couldn't find RMI related stack. (stage callback will be invoked only 3 times per benchmark, so async-profiler didn't catch that? (because of sampling))


Fix SortableSortEvent.{over,overContainer}

fixes #256

Can we somehow merge this little fix without writing extra tests?

@fdietze If you have tested this and know it works, I can merge it


Support for locking for multiple resource groups

It seems that one Jenkins build can only get a resource lock on one resource group. I'd like to get a lock on multiple resource groups.
RASPBERRIES (label): RP_1, RP_2, RP_3
TABLES (label): GALAXY_1, GALAXY_2, GALAXY_3
My build has a place where I can specify that I'd like a lockable resoirce from RASPBERRIES but I cannot get a lock on one RP_X and one GALAXY_X

This has been available for pipeline jobs for quite some time. I don't consider building the same for legacy jobs worthwhile. I would, however, consider merging a well-written & tested pull requests adding such a feature.


Vector field iruby notebook

I made an iruby notebook of a vector field, and a vector field with coloured arrows.

Wow, nice example! Thank you!
By the way I already implemented support for gnuplotrb in iRuby, so you can use just
vec_field

instead of
vec_field.to_pngcairo('vec_field.png')
File.open('vec_field.png')

and plot will be attached to notebook as svg image.


Remove scrollbar in Firefox from ScrollArea

I have a problem with hiding the scroll bar in Firefox. Everything works correctly in other browsers.

I have found a possible solution, and it works for me. https://stackoverflow.com/a/53787170/16523571
[data-radix-scroll-area-viewport] {
   scrollbar-width: none;
}

Hey @MellKam ! Can you check of this case happened for RadixUI?
we have webkit-scrollbar set to display none, and it should be hidden in Firefox too.

From radix-ui:
https://github.com/radix-ui/primitives/blob/ea6376900d54af536dbb7b71b4fefd6ec2ce9dc0/packages/react/scroll-area/src/ScrollArea.tsx#L152
[data-radix-scroll-area-viewport]{
	scrollbar-width:none;
	-ms-overflow-style:none;
	-webkit-overflow-scrolling:touch;
}

[data-radix-scroll-area-viewport]::-webkit-scrollbar{
	display:none
}

Icic.. We missed out the scrollbar-width:none; as you've mentioned! Thanks for catching that @MellKam !
Can I assign the ticket to you? 😁

Icic.. We missed out the scrollbar-width:none; as you've mentioned! Thanks for catching that @MellKam !
Can I assign the ticket to you? 😁

Yes, sure 👌


OpenGL 4.1 creation on El Capitan

Very similar to https://github.com/glfw/glfw/issues/87 but occuring on OS X 10.11 El Capitan.
I have the following example program that is failing:
#include <cassert>
#include <iostream>

#include <GLFW/glfw3.h>

int main(int argument_count, char *arguments[]) {
  assert(glfwInit());

  glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 4);
  glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 1);
  glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);
  glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);

  GLFWwindow *window = glfwCreateWindow(1024, 768, "test", nullptr, nullptr);
  assert(window);

  glfwMakeContextCurrent(window);

  std::cout << glGetString(GL_VERSION) << std::endl;

  glClearColor(1., 1., 1., 1.);

  while (!glfwWindowShouldClose(window)) {
    glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

    glfwSwapBuffers(window);
    glfwPollEvents();
  }

  glfwTerminate();
  return 0;
}

which results in:
Assertion failed: (window), function main, file wheels/wheels.cpp, line 15.

while commenting out forward compatibility and core profile hints:
#include <cassert>
#include <iostream>

#include <GLFW/glfw3.h>

int main(int argument_count, char *arguments[]) {
  assert(glfwInit());

  glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 4);
  glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 1);
  // glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);
  // glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);

  GLFWwindow *window = glfwCreateWindow(1024, 768, "test", nullptr, nullptr);
  assert(window);

  glfwMakeContextCurrent(window);

  std::cout << glGetString(GL_VERSION) << std::endl;

  glClearColor(1., 1., 1., 1.);

  while (!glfwWindowShouldClose(window)) {
    glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

    glfwSwapBuffers(window);
    glfwPollEvents();
  }

  glfwTerminate();
  return 0;
}

results in a working application with the following reported OpenGL context version:
2.1 NVIDIA-10.8.14 310.42.15f01

However, version 4.1 was requested. Any ideas?

What version of OS X El Capitan do you have? Is it 10.11.2?
What video card do you have? Does it support 4.1?
What happens if you try requesting OpenGL 3.2 instead of 4.1?
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 2);
glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE);

I have a NVIDIA GeForce GT 650M card, with El Capitan 10.11.2 (15C50).
However, I notice that normally the Intel HD Graphics 4000 1536 MB card is active.
When requesting 3.2 in the window hints, it has the same behavior in both cases.

Further information: disabling "Automatic Graphics Switching" under "Energy Saver" in system preferences and rebooting now shows the NVIDIA card as active, yet the above examples behave exactly the same in both cases.

That hardware should definitely support 3.2 and maybe even 4.1.
Which GLFW version are you using? Latest master branch or 3.1.2?

The 3.1.2 source download zip https://github.com/glfw/glfw/releases/download/3.1.2/glfw-3.1.2.zip compiled with cmake/clang. I also tested with the homebrew version 3.1.2.

I could reproduce... which was very odd since similar programs worked fine for me, and I have a very similar setup. I could not find the issue until I did this:
static void error_callback(int error, const char* description)
{
    fprintf(stderr, "Error: %s\n", description);
}

glfwSetErrorCallback(error_callback);

Then it was immediately obvious where the problem was. You have a copy/paste error in these lines of your program:
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 4);
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 1);

Both lines are setting major version, instead of major and minor.

Ah, oh wow. Of course, how did I miss that. Sorry for the time wasted.


2.7.0 release notes

I was wondering if the release notes of 2.7.0 could be posted? Currently, this page is empty:
https://github.com/Alex-D/Trumbowyg/releases/tag/v2.7.0

Done!
Sorry, I had forgot that step ^^

Thanks!


Fix for https://github.com/aarontrank/gulp-jest/issues/61

Issue fixed by https://github.com/aarontrank/gulp-jest/pull/66


Jitter fix not working, leads to audio desynchs

I have trouble with both jitter fixes. The CapFPS option doesn't really work. 2D menus stick to 40 fps instead of 30 and many 3D scenes, such as the carussel intro in the beginning are using much higher frame rates. Otherwise the game sticks to 30 fps, but the sound in cutscenes is always out of synch by several seconds.
With the AltFix option the audio desynchs less and sometimes even runs in synch, but since I can't maintain a stable 60 fps, the game runs slower in parts where I only get half the framerate. Additionally, it causes the game to run much slower than with the other fix. I get 20 fps in areas where I'd get way more without any fix or with CapFPS.
Running the game without the fixes keeps the audio in synch.
Windows 10 Enterprise
Nvidia GTX 260
3840x2160@28Hz
sh3proxy 0.8.3

Desync issues should be fixed in 0.9.
It seems that the stuttering is caused by camera code. Namely, if I move the character along a straight line, framerate is stably 60, but if the character is standing still and the camera is quickly rotated, the framerate drops immediately.


Update Flame - without Docker

Hi.
I followed your Guide "Installation without Docker".
How do I update this kind of Installation.
An other option would to give an export option for my configuration (Apps, Bookmarks,...) :-)
Regards Stephan

You just pull new code with git pull and start it as before.

Ok. Needed to do some research to understand.
"git fetch --all && git reset --hard origin/master" solved my problem.
The ".env" file should be saved and restored afterwards.
Maybe you could add a hint to the installation guide.
Regards and thx for the great work!!


Fix: model id and model dir check order

What this PR does / why we need it:
Fix the condition check order, we should always check if model_id is None first as model_dir can be always specified.
Default --model_dir to /mnt/models, so user does have to add this additional argument on inference service yaml.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Special notes for your reviewer:

This depends on https://github.com/kserve/kserve/pull/3679 which should be merged first

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[X] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/lgtm


MPDD support sets for a fair comparision

Can you please share the support set that you used for your MPDD results so that we can have a fair comparison between your method and others?
I created a support set for MPDD by randomly selecting some images but it is giving lower results than mentioned in your paper. Therefore if you can share the support set for MPDD that you used like you did for MVTec it will be helpful for other researchers.
Thank you

Could you please tell me how to create the support set?

I'm also in this question, can you tell me how to create a support set

Could you please tell me how to create the support set?

请问您知道了怎么生成support set了吗，如果可以的话是否可以提示我一下，我也想要生成support set，十分感谢。

I'm also in this question, can you tell me how to create a support set

请问您知道了怎么生成support set了吗，如果可以的话是否可以提示我一下，我也想要生成support set，十分感谢。


T8A3 feedback

User stories
Mark done, edit, undo etc should be high priority since they're must-have features.
Use cases
Nice to see comprehensive extensions! Note that UI details (e.g. colored circle for add priority tags, how a user adds event to group activity, input format) should not be included. Use cases come before UI design.
NFRs
Point 3 sounds like a functional requirement. Also, in case you missed it, our module handbook specifies a number of project constraints (e.g. No Relational Databases). At least hyperlink to that document.
Product survey
Good job with the analysis:) Very detailed!

@kychua Thanks for the feedback.


Fix and Centralize IAM Roles on Website

Story
In the setup page of forsetisecurity.org, the IAM role for security reviewer is incorrect.
incorrect: roles/securityReviewer
correct: roles/iam.securityReviewer
Solution

Correct IAM role is listed.
Centralize the content of the IAM roles with the ones described here.

PR Pending - moving to next sprint


Add helpful exception class and message for no packages in APK

Hey @mmcloughlin just wondering if you had a chance to review this yet. Thanks!


Remove legacy query engine and promises

Everything has been chunkified. Remove re_query, remove promises.

Fixes https://github.com/rerun-io/rerun/issues/6813
Fixes https://github.com/rerun-io/rerun/issues/6814
Fixes https://github.com/rerun-io/rerun/issues/4810
Fixes https://github.com/rerun-io/rerun/issues/5607
DNM: requires https://github.com/rerun-io/rerun/pull/7032

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check

@rerun-bot full-check


Zadorozhnii/refactor enzyme tests

Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @khudym!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
:warning: We can't start reviewing your pull request until you've submitted a     signed contributor agreement     or indicated your institutional affiliation. Please see the CONTRIBUTING     file for more information.     If you've signed an agreement in the past, you may need to re-sign.  See     The New Home of the Open edX Codebase     for details.
Once you've signed the CLA, please allow 1 business day for it to be processed.  After this time, you can re-run the     CLA check by editing the PR title.  If the problem persists, you can tag the @openedx/cla-problems team in a     comment on your PR for further assistance.

@khudym Great job! I think I've been reviewing this forever 😄 Left minor comments, please review them.

@khudym 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

:tada: This PR is included in version 21.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0-alpha.11 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add "optional requirements" to package.yaml

It would be nice if rez's package files supported the concept of "optional requirements" (i'm sure we can come up with a less oxymoronic name).  These packages would be loaded if found successfully, but otherwise would not result in an error.
my current scenario is that I'm using rez to build MtoA (the Maya to Arnold translator), which has an optional plugin for shave and a haircut.  We have shave for maya 2012 installed, but we don't yet have it for maya 2014.  it would be nice if in the mtoa package.yaml file I could effectively say "load shave if you can", then in the build script (in this case it's scons) handle the logic if it is or is not there.
This feature is a nice analog to cmake's find_package, without the REQUIRED flag.

I'd like to revive this (ancient!) topic on optional requirements, with a few more usecases.
Cosmetic packages
In the simplest case, users can choose to enable a themed experience for their Maya.
package.py
name = "maya"
requires = [
  "maya_base<=1,<2",
  "?maya_alita_theme>=1,<2"
]

In this case, maya_alita_theme doesn't have to exist on the Rez search path, but if it does, it's picked up and included in the resolve.
Overrides
More practically, and related less-so to software versioning and more-so to project configurations, which I realise isn't Rez's primary target use.
In this case, I'd have something along the lines of:
package.py
name = "maya"
version = "2019.0.1"
requires = [
  "?maya_override",
]

Whereby, if maya_override is available on the Rez search path, it'd get picked up. If not, no worries.
Where it could come in handy is if overrides are provided on a per-project, per-asset, per-task, per-whatever level, for example.
$ export REZ_PACKAGES_PATH=/packages
$ rez env maya

Here, the global maya package is picked up, and that's about it. However:
$ export REZ_PACKAGES_PATH=/packages:/projects/alita/rez
$ rez env maya

At the rez/ directory, a maya_override package is available, resulting in an environment tailored to Alita. In effect, Alita will have overridden the original (vanilla) Maya environment.
Overrides could then be had at various levels, given generic placeholder packages like project, asset and task for example.
$ export REZ_PACKAGES_PATH=/packages
$ export REZ_PACKAGES_PATH=$REZ_PACKAGES_PATH:/projects/alita/rez
$ export REZ_PACKAGES_PATH=$REZ_PACKAGES_PATH:/projects/alita/rez/assets/vector
$ export REZ_PACKAGES_PATH=$REZ_PACKAGES_PATH:/projects/alita/rez/assets/vector/rigging
$ rez env project asset maya

At which point, overrides can explicitly be included or excluded, given the project and asset entries. One could go on to wrap the command in a GUI - like an application launcher - with tick-boxes for each level of (available) override, powered by Rez for versioning and environment resolves under the hood.
I'm happy to implement this if you think it's a good idea; I'm also sensitive to the Rez mandate of being clear and un-fuzzy, and can see how this idea is counter to that. However, I would argue that if a user wishes to shoot himself in the foot, he should be allowed to do so, so long as it doesn't shoot others in their feet. And considering this would be an entirely separate syntax, there is little risk of affecting (infecting?) existing users and could - if anything - help those interested in optional requirements discover for themselves why it isn't that great of an idea.


ModuleNotFoundError: No module named 'GraphReasoning'

Running the SciAgents_ScienceDiscovery_GraphReasoning_non-automated.ipynb notebook, got this error on this cell
from ScienceDiscovery import *
make_dir_if_needed(data_dir_output)

Did you install the graphresoning from the provided source?

Why were those lines not added to the notebooks?

the author has mentioned that: pip install git+https://github.com/lamm-mit/GraphReasoning


Simplify bin example in README

The title says all.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to use it with vee-validate?

Hi!!
I'm trying to use vue-tabs component in my form, but to validate the form I'm using vee-validate. But when I change the tab, the input are not hidden in the screen and fails to valid :/
There is a way to not destroy the input, but just make it hidden? Via css?

Can you please show the code you used?
For forms maybe https://github.com/cristijora/vue-form-wizard is better suited since it has validation functions and other features. (e.g Element UI validation -> https://jsfiddle.net/bt5dhqtf/409/)  Tabs are usually used for informational purposes.
Feel free to post the code anyway so I can understand better the issue

Hi, I created a gist: https://gist.github.com/afucher/411e73a8ee962b4969dd2763ec20bbfb
I'm using Tabs because my form have a lot of information, so to make it easier to the user I'm separating the info. In this gist I just put a few fields to be more easier to explain.
If I'm in the tab "Address Info" and click to Save, the validateAll don't return error, because the others inputs doesn't exists...

Ok. The issue is that vue-tabs doesn't support async validations yet. I will probably add that soon.
If you think Form Wizard can be an option for you (https://jsfiddle.net/bt5dhqtf/430/) you can try with it, otherwise, async validations will be implemented on vue-tabs only tomorrow

This is great @cristijora !
But Form Wizard don't let me go to another tab without validate a field, right?

Yes, that's right. You can go back by clicking a tab but you can't go forward until it's validated in form-wizard.
If that doesn't suit your use-case, I will implement async validations for vue-tabs also in a very simillar way to what form-wizard has now.

I want to validate all the data, just when the user click to save the register, not while he is editing it.

Well that's handled by VeeValidate. You have to set it up so it validates only on form validate

Yes, but if you hide the panel with v-if, VeeValidate don't find the input to valid... that is my problem...


Karma 6.4.4 Depends on "Vulnerable" inflight Library

<EMAIL_ADDRESS>depends on a deprecated version of the 'glob' package.
Need to update the version of glob to 9 or higher to fix the following vulnerabilities
https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
<EMAIL_ADDRESS>C:\Myfolders\Myfiles\2_proj\demo\06-ng\ng-demo
└─┬<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

I can propose to use https://www.npmjs.com/package/karma-up  my fork which updated all deps

body-parser 1.20.3 should be included in the package.json updates as well. Fixes a High vulnerability reported by Mend.

"body-parser": "^1.20.2", it is not have the fixed version usages so that mean you can use body-parser 1.20.3 as well

Hi all,
Any updates on when the deprecated packages are due to be updated in Karma?


question

When will godmode be released?

I don't know yet, I don't have much time at the moment

Understood


Add carousel effect in Type of Services section

Website link : https://rko0211.github.io/Canteen-Website/
Kindly review my PR under apertre24.

Can you please reduce the size of carousel it's too big for Desktop version ok size for mobile & also add some automation where  after atleast 2 sec it slide  to another slide  automatically

Can you please reduce the size of carousel it's too big for Desktop version ok size for mobile & also add some automation where after atleast 2 sec it slide to another slide automatically

Ok i do so..


feat: update mimir mixins and add the autoscaling parts

This PR

updates the mimir mixins from upstream

Checklist

[x] Update changelog in CHANGELOG.md in an end-user friendly language.

This was tested on grizzly, no major changes imo


framework almost the same as another one

The framework appears to have no major difference from "FROZEN TRANSFORMERS IN LANGUAGE MODELS ARE EFFECTIVE VISUAL ENCODER LAYERS". Even the pseudo-code seems identical. And the conclusion seems highly similar. I mean, is there anything new to be found?

The framework appears to have no major difference from "FROZEN TRANSFORMERS IN LANGUAGE MODELS ARE EFFECTIVE VISUAL ENCODER LAYERS". Even the pseudo-code seems identical. And the conclusion seems highly similar. I mean, is there anything new to be found?

Thanks for the attention! LM4VisualEncoding alongside the paper Frozen Transformers in Language Models are Effective Visual Encoder Layers have been pivotal in shaping our approach. Drawing upon their insights, we adapted and expanded upon the 2D image classification framework to accommodate both 2D and 3D medical imaging data, experimenting with various configurations of residual blocks to enhance the model's performance on the medical image dataset. This repo mainly focuses on medical image applications.

Thanks for the attention! LM4VisualEncoding alongside the paper Frozen Transformers in Language Models are Effective Visual Encoder Layers have been pivotal in shaping our approach. Drawing upon their insights, we adapted and expanded upon the 2D image classification framework to accommodate both 2D and 3D medical imaging data, experimenting with various configurations of residual blocks to enhance the model's performance on the medical image dataset. This repo mainly focuses on medical image applications.


Data process

Thank you for your nice work! I might missed something so I met an issue with the data process:
First case: I use --data_format colmap to load my own data (colmap):
Second case: I first run your torch-ngp python scripts/colmap2nerf.py to generate transform_train/val/test.json. Then, I use --data_format nerf to load my own data.
The two cases lead to different results: the first one gets 18 in PSNR while the latter produces 22: the visualizations also reflect such a performance gap.
May I know your suggestion on this? Thanks.

@Simon4Yan Hi, many factors can influence the result, I guess first the default data split is different for these two settings. Also, the bound and scale parameter can affect performance. I recommend to use --vis_pose to verify the sparse points and cameras for colmap dataset so you can adjust bound and scale.

Thanks for your reply.

many factors can influence the result, I guess first the default data split is different for these two settings

Two settings have different data splits; I already made them the same.

the bound and scale parameter can affect performance

For both settings, I used the same bound and scale (--scale 0.8 --bound 2.0)
Moreover, for the second case (--data_format nerf), I created transform_train/val/test.json so that the code will use blender mode. I will check the pose ('--vis_pose'). Do you have any other suggestions on the potential differences?
Thank you again for your help.

To perfectly align the two formats, you also need --enable_cam_center, and do not use --enable_cam_near_far for colmap format. You can check the visualization for sure.

when adding --enable_cam_center, the result is much worse (18-->9). I will check the visualization.


Is it possible to support vscode extension?

Would you have plan to build a vscode extension?

Sure, there would be one after<EMAIL_ADDRESS>is released.

Markmap for VSCode is now released: https://marketplace.visualstudio.com/items?itemName=gera2ld.markmap-vscode


remove lint checks temporarily

Codecov Report

Merging #23 (dc6645b) into main (a32a340) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   75.38%   75.38%
=======================================
  Files          15       15
  Lines         321      321
  Branches       13       13
=======================================
  Hits          242      242
  Misses         79       79

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update error INVALID_ZSYNC_MTIME

Select your issue type: (check at least one)

[x] Bug
[ ] Question
[ ] Suggestion
[ ] Other (please describe):

Describe your issue:
Trying to update my AppImage with the example application or the API results in the INVALID_ZSYNC_MTIME error. I'm creating the AppImage with linuxdeployqt.
Ways to Reproduce the issue (optional):
# build SimpleUpdate
cd AppImageUpdaterBridge/examples/SimpleUpdate
qmake && make

# grab updateable AppImage
wget https://releases.openclonk.org/snapshots/2019-02-03T18:14:53Z-master-918c4139e/OpenClonk-x86_64.AppImage

# update fails with SimpleUpdate:
./SimpleUpdate OpenClonk-x86_64.AppImage
# SimpleUpdate , A Simple Updater using AppImageUpdaterBridge.
# Copyright (C) 2018 , Antony Jr.
# [                          ###                              ]      Revising New Version at 0.0   error::  AppImageUpdaterBridge::errorCode(INVALID_ZSYNC_MTIME)

# update works with appimageupdatetool:
wget https://github.com/AppImage/AppImageUpdate/releases/download/continuous/appimageupdatetool-x86_64.AppImage
chmod +x appimageupdatetool-x86_64.AppImage
./appimageupdatetool-x86_64.AppImage OpenClonk-x86_64.AppImage
# Checking for updates...
# ... done!
# Starting update...
# [...]
# Update successful. New file created: OpenClonk-x86_64.AppImage

@lluchs I will check on it ASAP , Possible that the zsync control file is corrupted or uses a new standard.

@lluchs Seems to work on my side , I got a Qt internal error though but I think I'm doing something tedious on direct zsync transport I will look into it. Are you sure that you are using the latest version ?
SimpleUpdate , A Simple Updater using AppImageUpdaterBridge.
Copyright (C) 2018 , Antony Jr.
QNetworkReplyHttpImplPrivate::_q_startOperation was called more than once

QUrl("https://releases.openclonk.org/snapshots/latest-master/OpenClonk-x86_64.AppImage.zsync")

[##########                       ] 63% Revising New Version at 456 kB/s.

More information can be helpful , like what version of the library are you using and what version of Qt?

I'm on Fedora 29. I think it's a locale issue. Try setting LC_TIME=de_DE.UTF-8. It works on my side if I set LC_TIME=en_US.UTF-8.

@lluchs Still a major bug exists , which should be fixed when refactor is merged. The current version thinks that your update server does not support range requests and thus it does not use the delta update. This is because the update server does not send the 'Accept-Ranges' header when partial content is requested but this has been fixed in the other branch. I will look into the locale.

@lluchs fixed this on https://github.com/antony-jr/AppImageUpdaterBridge/commit/79e92ddecdaf182d8dc0abae557997c70b315f88 , will be closed after merge.

@lluchs it should work fine with your AppImage. I have tested it already. Do report bugs in the future. Checkout the documentation (use private window if you see the old site because of browser cache.) for more information.

@lluchs is the library working on your side ?

@lluchs you can try updating any appimage using this qt application which uses this library to do the update , https://github.com/antony-jr/AppImageUpdater ( Already tested with this and your appimage update was smooth.) (Run from terminal to see log messages which can give you insight on how the update process is done.)

Thanks, I think it is working now with the example application. I was last stuck building the integration with our in-game UI and hope to continue next week.

@lluchs glad to hear that , by the way , played your game , its awesome.


daemon/cups-browsed.service: add system-cups.slice

See https://github.com/OpenPrinting/cups/pull/1035 for rationale and an explanation.
The system-cups.slice file included in the aforementioned PR is not required; the system-cups slice will be automatically created if the file is missing.

Thank you very much, @tomodachi94 !


Backport "Correctly prettify names in coverage info" to LTS

Backports #18542 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-19605.
Reference


Add a path.clean function for #8885

Add path.clean function as mentioned in #8885.
I'd love to write a more full test suite, but I'm not 100% sure how to emulate windows filepaths effectively. Any tips are appreciated! :D

It puzzles me how that test can fail ... Oh, well, thanks for this.

Happy to help! I will look at some other issues and see what I can do to help out :D


edits to reflect mapping from dGen tracts to project counties

Please review these files, thanks!

@daniel-thom hopefully your comments are addressed now? let me know if I missed something. Sorry I didnt see your comments earlier.


Unhandled TDS_ORDERBY token causes driver crash with ordered selects

We came across an issue where the driver was crashing when executing SQL with Order By statements.  The exceptions varied, but here is one example:
System.InvalidOperationException : "Operation is not valid due to the current state of the object."

at AdoNetCore.AseClient.Internal.ReadablePartialStream.Read(Byte[] buffer, Int32 offset, Int32 count) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\ReadablePartialStream.cs:line 44
   at AdoNetCore.AseClient.Internal.StreamReadExtensions.ReadInt(Stream stream) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\StreamReadExtensions.cs:line 31
   at AdoNetCore.AseClient.Internal.FormatItem.ReadTypeInfo(FormatItem format, Stream stream, Encoding enc) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\FormatItem.cs:line 137
   at AdoNetCore.AseClient.Internal.FormatItem.ReadForParameter(Stream stream, Encoding enc, TokenType srcTokenType) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\FormatItem.cs:line 128
   at AdoNetCore.AseClient.Token.ParameterFormatCommonToken.Read(Stream stream, DbEnvironment env, IFormatToken previousFormatToken) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Token\ParameterFormatCommonToken.cs:line 64
   at AdoNetCore.AseClient.Token.ParameterFormat2Token.Create(Stream stream, DbEnvironment env, IFormatToken previous) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Token\ParameterFormat2Token.cs:line 15
   at AdoNetCore.AseClient.Internal.TokenParser.ParseInternal(Stream stream, DbEnvironment env)+MoveNext() in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\TokenParser.cs:line 26
   at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
   at AdoNetCore.AseClient.Internal.TokenParser.Parse(Stream stream, DbEnvironment env) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\TokenParser.cs:line 14
   at AdoNetCore.AseClient.Internal.RegularSocket.ReceiveTokens(DbEnvironment env) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\RegularSocket.cs:line 127
   at AdoNetCore.AseClient.Internal.InternalConnection.ReceiveTokens(ITokenHandler[] handlers) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\InternalConnection.cs:line 95
   at AdoNetCore.AseClient.Internal.InternalConnection.InternalExecuteAsync(AseCommand command, AseTransaction transaction, TaskCompletionSource`1 rowsAffectedSource, TaskCompletionSource`1 readerSource, CommandBehavior behavior) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\InternalConnection.cs:line 221
--- End of stack trace from previous location where exception was thrown ---
   at AdoNetCore.AseClient.Internal.InternalConnection.ExecuteReader(CommandBehavior behavior, AseCommand command, AseTransaction transaction) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\Internal\InternalConnection.cs:line 287
   at AdoNetCore.AseClient.AseCommand.ExecuteReader(CommandBehavior behavior) in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\AseCommand.cs:line 183
   at AdoNetCore.AseClient.AseCommand.ExecuteReader() in C:\git-repos\AdoNetCore.AseClient\src\AdoNetCore.AseClient\AseCommand.cs:line 197
   at SybaseDriverTest.Program.Main(String[] args) in C:\git-repos\AdoNetCore.AseClient\src\SybaseDriverTest\Program.cs:line 22```

The crash is reproducible using the the following sql:
select *,* from master..syscolumns where 1 = 2 order by 31, 32, 33

After building a local copy of the driver and enabling logging - the following was noticed:
!!! Hit unknown token type TDS_ORDERBY !!!
!!! Hit unknown token type 31 !!!

Looking at the TDS spec it states:
TDS_ORDERBY, # Columns, column #
# Columns : This is the number of columns in the order-by clause. This argument is a two-byte, unsigned integer.
Current the code handles this token in the CatchAllToken class, reading a single byte as the length field, corrupting the reading of the TDS stream ( which causes the varying crashes ).
I will submit a PR with a test and proposed fix for this issue

Sections 5.2.1/5.2.2/5.2.3 of the spec talk about what the token's type indicates about the token's length. It looks like I completely misinterpreted it when implementing CalculateRemainingLength in the catch-all token.
Talk more in the PR

I have tested the fix for #107 locally and it addresses the issue we were having


Strange behaviour with filters containing escaped backslashes

What happened?
Hi,
thanks for your work on insta.
It looks like maybe the input is escaped before being replaced with the filters, leading to a single backslash getting replaced twice, or something like that?
I hit this issue while trying to figure out why lines in the snapshot test output were quoted on Windows CI. I think it's caused by the same issue (filter (r"\\\\", "/") on r"src\main\java" results in "src/main/java" instead of the expected src/main/java, I guess in hindsight needing four backslashes in the filter for it to work was odd already).
Reproduction steps
With the project
# Cargo.toml
[package]
name = "issue"
version = "0.1.0"
edition = "2021"

[dependencies]
insta = { version = "1.28.0", features = ["yaml", "filters"] }

// src/lib.rs
#[test]
fn test() {
    insta::with_settings!({filters => vec![
        (r"\\", "replacement"),
    ]}, {
        insta::assert_yaml_snapshot!(vec![
            r"\",
        ]);
    })
}

running cargo insta test results in
---
source: src/lib.rs
expression: "vec![r\"\\\",]"
---
- "replacementreplacement"

Insta Version
1.28.0
rustc Version
rustc 1.67.1 (d5a82bbd2 2023-02-07)
What did you expect?
---
source: src/lib.rs
expression: "vec![r\"\\\",]"
---
- replacement

The filter is run on the serialized output. Since your ['\\'] is serialized as - \\ in YAML, it has to show up as replacementreplacement. There is really no way around this due to how filter works. Maybe the redaction feature works better for your use case.

Got it, the behaviour I've been seeing makes sense now, thanks. With the backslash issue sorted, I opted to deal with the extra quotes by just removing them all by adding ("\"", "") to the filters. I gave up on redactions due to keys getting extra quotes around them too, so changing only the values wasn't enough.


Add research intervention issue template

This PR ...
Adds a new issue template for research tasks.
Test Steps:

Include steps to test these changes

Changes

adds research-user-intervention.md

Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[x] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#issue - List GitHub issues this PR fixes

To Be Done
Create GitHub issues to track the work remaining, if any

#4409

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
33
1h 43m
16

carlosfelix2
29
1h 26m
58

cwinters-usds
22
2h 26m
6

jimduff-usds
18
4h 31m
17

TomNUSDS
14
1h 1m
12

kevinhaube
13
1h 25m
0

whytheplatypus
11
1h 28m
17

jbiskie
10
1h 2m
0

oslynn
8
54m
3

brick-green-agile6
8
1h
0

ahay-agile6
6
1h 50m
5

JosiahSiegel
5
1h 48m
2

sethdarragile6
5
37m
0

jorg3lopez
4
46m
2

rhood23699
4
45m
0

RickHawesUSDS
3
39m
1

jeremy-page
2
8m
0

sean-usds
2
1h 53m
0

clediggins-usds
2
8h 59m
1

acoushawk
1
16h 10m
0

meckila
1
9h 33m
2

snesm
1
16m
0

jh765
1
2h 54m
0

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
53
1h 24m
28

carlosfelix2
29
11h 50m
64

jimduff-usds
17
11h 32m
19

cwinters-usds
17
3h 55m
6

TomNUSDS
13
1h 25m
27

whytheplatypus
12
1h 48m
18

jbiskie
11
1h 11m
0

kevinhaube
10
53m
0

oslynn
10
1h 5m
5

ahay-agile6
9
3h 54m
5

brick-green-agile6
7
49m
0

sethdarragile6
6
47m
0

JosiahSiegel
5
1h 19m
2

rhood23699
5
47m
0

RickHawesUSDS
4
41m
1

jorg3lopez
3
1h 13m
2

meckila
3
3h 14m
4

jeremy-page
2
8m
0

clediggins-usds
2
8h 59m
1

bgantick
1
1d 19h 37m
1

TurkeyFried
1
3h 41m
0

acoushawk
1
16h 10m
0

snesm
1
16m
0

jh765
1
2h 54m
0

@jeremy-page or @cwinters-usds I fixed a typo Jeremy flagged (thanks!), are y'all able to approve this?


Use Github packages for container registry

Use Github packages instead of dockerhub for the app
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

@bradmccoydev I am getting permission_denied error. You can have a look at it below:
oem@meha:~/keptn-flux-integration$ docker push ghcr.io/keptn-sandbox/keptn-flux-integration:latest
The push refers to repository [ghcr.io/keptn-sandbox/keptn-flux-integration]
a92bd616edce: Preparing
2271483f44f4: Preparing
24302eb7d908: Preparing
denied: permission_denied: create_package


fix: user lands on previous attachment

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52415
PROPOSAL: https://github.com/Expensify/App/issues/52415#issuecomment-2472701165
Tests

Open the Expensify app
Open any chat that contains at least an image or video attachment on it
Tap on the "+" button and select "Add Attachment"
Tap on "Choose File" and select any image to upload
Tap on "Send"
Once redirected to chat, tap quickly on the just sent image
Verify that: Preview of the just sent image should load correctly and the user should remain on it when opened

[x] Verify that no errors appear in the JS console

Offline tests

same as above
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/1b0c72c1-7274-4717-8ca9-a315b205085f

Android: mWeb Chrome

https://github.com/user-attachments/assets/c7d3782c-0f64-499e-8229-12f79fe6b006

iOS: Native

https://github.com/user-attachments/assets/154f05fe-2bb2-497f-b9e0-267051d6b87e

iOS: mWeb Safari

https://github.com/user-attachments/assets/24fdd160-5ffc-456e-be29-666fefb74a40

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b0f0ad5d-1388-4e3c-b675-d8c16bf68a54

MacOS: Desktop

https://github.com/user-attachments/assets/b370cc84-3745-4c0f-ac2a-ce99eb1b7000

@akinwale friendly bump

Reviewing this today.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/65443d33-d557-4c01-806a-ceb54eb54edd

MacOS: Desktop

@nkdengineer Upon further testing, I discovered this warning when opening the attachment preview in a public channel on iOS native. Could you please check this?

https://github.com/user-attachments/assets/904adfbd-8396-4e1d-9ccf-0b5df6ac6c11
@akinwale i can see the warning when opening the attachment preview in main

@nkdengineer The warning you posted is not the same as the one encountered on this branch. Please check the details of the warning. The warning text states:
Encountered two children with the same key, $reportActionID-undefined.

@akinwale  i fixed, please check again

@srikarparsi Everything looks good now. This is ready for your review.

Cool this looks good, @nkdengineer or @akinwale, could we also check the test steps here to make sure we don't cause a regression?

@srikarparsi I do not have access to the report where the source message (from https://github.com/Expensify/App/issues/50006) as indicated in the test steps were copied from. Is there possibly a public room instead where I can copy this message from?

Hm, I'm not actually sure, @suneox or @ishpaul777 do you know?

It looks like if you paste this into a report, the gif will show up:

Awesome, sounds great!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


reaver-wps-t6x

Motivation for this change
reaver-wps has been forked with some bugfix, and the fork supports pixiewps (faster and offline wps cracking).
I added both the packages, but the original version of reaver-wps is still present.
@viric Let me know what do you think

Sorry wrong commit, fixing pixiewps right now


[fix] import_node and pages navi

#1395

Coverage decreased (-0.005%) to 83.453% when pulling 0ec526ed40f01190c0969ba8d0f961dbac233946 on itowtips:fix-import-page into 77c36691b9f6c03d62a090e54616e434072912a2 on shirasagi:master.


Filter out non-existent variations

A note on implementation - with those lines:
var tmp = variation.join('');
var tmp1 = variation.slice(0).reverse().join('');
given a variation of "1,3", it'll only check for 1_3 and 3_1 in variation data array. Since there might be more then 2 options, a more generic approach is to check all permutations of a variation(so for "1,2,3", check 1_2_3, 1_3_2, 3_2_1, 2_3_1,etc..) to account for different ordering of keys, but not sure it's that useful, there are very few setups with more then 2 options and ordering in variationData is rarely inconsistent(although it can be).

And I don't think we should hide options when they aren't available, because they still might need to be referenced.

Hmm... it's just seems weird to show the non-existing variations - suppose you have a product-type attribute and a bunch of sizes, so you have variations based on those. Showing all attributes instead of only the ones that exist means you can see those in frontend, which might be a totally nonsensical combination - certain sizes should only go to a certain product type... This is an example:
https://ariakaysboutique.com/products/baseball-babe-set

In the example above, showing all sizes would also mean a huge number of options in the  "Size" selector with only a handful of them selectable per each product type.

A more common example - suppose you have sizes: 1,2,3,4,5,6,7,8,9 for "red",  same sizes for "green", but for "blue" you only have 10 and 11 - so if the customer selects "blue", how does it make sense to have the customer click through 1 to 9 sizes to understand that they are out of stock? Wouldn't it make much more sense to just remove them from the selector?

I understand your example, but customers wouldn't click through each size - they would pick the size they are looking for and see it is out of stock. But in being able to pick it, they would be able to potentially see an image of that combination and a price, and effectively be shown that the product would normally be available. They then might enquire or come back later to order, whereas if you hide the option you give the impression that the combination never exists.
With your example and baseball babe set, personally I wouldn't be grouping products like that, the products seem to be different kinds of things, rather than minor variations - I'd create seperate products for them.

With your example and baseball babe set, personally I wouldn't be grouping products like that, the products seem to be different kinds of things, rather than minor variations - I'd create seperate products for them.

It wasn't my choice, but the customers - and I think it's a legit use-case here, it would be weird to create 6 products out of what is essentially a single product.

But in being able to pick it, they would be able to potentially see an image of that combination and a price, and effectively be shown that the product would normally be available

But that's a VERY wrong consideration in the above! What kind of "image" and "price" would they see on NONEXISTENT variation? Note I am not talking about the out of stock ones - those should be displayed.

The point is that it should be possible to distinguish cases when the variation is out of stock and when it doesn't exist -> it's an invalid combination of options, in which case it's better to not show it at all.

That I agree with, I can see cases where you really wouldn't want a particular combination offered.
But I'd say that that's more of an exception to the rule, and it's more likely that you would want to show that combo.
In the example your client has configured, I'd say that's actually just setting up a product wrong.
A bow is not a variation on a shirt, for example. A variation is taking the base product and changing it slightly, either something like a colour/size combo or changing some inclusion, not changing it completely to a different product altogether. Here's a good example: https://www.versalifthome.com/versa-lift/versa-lifttm-model-32

That I agree with, I can see cases where you really wouldn't want a particular combination offered.

Ok, but then - the system already allows you to represent both cases on the database schema level - if a variation is defined per a certain combination of options, it exists as a variation, and if it doesn't exist in the variation table, it's an invalid combination of options. So why not just make the UI match this?

I'm not disagreeing with you, we can certainly work towards this, but we have to be able continue to support the current behaviour and not change it. We need to add some sort of option to hide variations that we don't want to ever offer.

We need to add some sort of option to hide variations that we don't want to ever offer.

But that's weird - adding an option to hide a variation would imply this variation exists. You would normally place this option on variation itself, and if it doesn't exist, then there is nowhere to place it to.

but we have to be able continue to support the current behavior and not change it

Hmm, but how does it change the current behavior? You can't order do anything to a variation that doesn't exist in the database.

You would normally place this option on variation itself, and if it doesn't exist, then there is nowhere to place it to.

I mean, the most natural way to represent that is how it's already represented in the database - a variation doesn't exist if there is no entry in the variation-table.

That's not quite how variations work in terms of the database. Variations are automatically created from every combination of option that is included in variations.  If you have two options in variations, one with 3 values and the other with 2, you'll have 6 variations in total.  A variation exists due to a combination of option, not because of an entry in a database table.
At present, all you can do is mark a variation as out of stock, and this is reflected on the front end when you pick the combination for that variation.  What you're suggesting is that you would then be able to for that particular combination check something that say 'this doesn't actually exist'. The interface would then prevent you from selecting it completely.

That's not quite how variations work in terms of the database.

Hmm, that's where the difference is then - with POS integration that we're using, I'm just writing the individual variations that exist in POS - it wouldn't make sense to create all variations.

Hmm, but then I would say that such implementation is a little bit weird and not in line with how it works in other systems. In Magento, for instance, you can create a child product for a combination of options, but you can also remove the variations that do not make any sense / should not exist.

Since it's just a child product in Magento, removing a variation means deleting that child product. But it seems to me that what I suggested above is still a most natural way to implement it. A variation represents a physical product with a combination of options - like color and size. If such physical product cannot exist, the variation should not exist in the database as well.

I again don't disagree with you, and  I understand why you might be doing that, you're right in that it doesn't make sense to write data that you don't have.
But as it currently stands you're effectively writing to the database what Community Store would consider incomplete database records. There's no way to create what you are doing manually with the database via the the interface.  If you import a product this way, and then go in and save it, Community Store will then go and create the missing variation records in the database.
It really comes down to how Community Store's variations just don't work quite the same way as Magento's child products, they're generated a differently/automatically.
So I think we need to find some way to exclude variations. This could be via the interface as a switch, but also due to the variation record being absent. But again, that needs to be a layer on top of what we already have. And a further challenge is handling what happens if a save via the interface is performed, ensuring that absent variations aren't created (or are at least automatically flagged as excluded).
The code you submitted and I removed isn't lost, it'll still be available to reference in github, we just might need to find a different way to utilise it.

No necessarily, as often products are initially added and then configured with options at a later time, or a new option value is added into the mix.  But I get your point about effectively locking the variations, I'll give it some thought.


GetSheetIndex description issue

Description
There is a mismatch in GetSheetIndex description here and here.
The first one claims the function returns "0" for a non-existing sheet, in the second one it is "-1". As far as I can conclude from testing it myself, the correct one is "0"
Output of go version:
go version go1.14.2 windows/amd64

Excelize version or commit ID:
2.1.0

Thanks for your feedback, the correct one is "0". I will fix it.


dayjs-format usage

README states that the dayjs-format usage is:
{{dayjs-format <date> [outputFormat=dayjs.defaultFormat]}}

... and the example is given as:
{{dayjs-format '12-1995-25' 'MM/DD/YYYY'}} {{!-- 25/12/1995 --}}

However, this did not work for me. I had to add the outputFormat keyword argument.
Without outputFormat keyword argument:
{{dayjs-format "2021-12-31" "DD/MM/YYYY"}}  {{! 2021-12-31T00:00:00+08:00 }}

With outputFormat keyword argument:
{{dayjs-format "2021-12-31" outputFormat="DD/MM/YYYY"}}  {{! 31/12/2021 }}

I used to use the former one with ember-moment.
Am I missing something?

You are right @vst I must have missed this.
I'll fix ASAP. If you see any other inconsistencies please report.
Thanks.

No problem. Thanks for this addon and your effort!

I've released 0.4.0 @vst It should be fixed now.
Could you please try?
Thanks.

Thanks a lot, @sinankeskin. I will, but I need 1 or 2 days.

@sinankeskin Sorry for the delay.
It works as expected. Thanks! :+1:


Ensure the network is connected.

This PR ensures the auto-connection service (nn::ac) is connected before any network operation is done. This avoid spurious network errors if the plugin runs a synchronization task too early during boot, while the Wii U is still connecting to the access point.

Thank you so much!


Nmstate should ignore  change request on eth1 because state: unknown

Hello @ihuguet
Please review my changes for issue #2452
I made some changes to base_iface file and also iface.rs, but the info message didn't show in the output as expected. I have gone through the code base looking out for how to make this work but I am not sure how to go from here. pls help
am doing wrong.

and about the patch I would think we are changing the  deserialization logic of the BaseInterface rust struct to accept unknown state and the handle it appropriately
cc @cathay4t @ihuguet @ffmancera

Also @EjiroLaurelD  it would be good practise  for the PR name to be a little more descriptive more less like the issue title.

there are some commits that creeped in, they are affecting  the readability.
can you clean the commit please

Oh my!... I will clean the commit. Thank you

The reason why it doesn't work is that you have to map "unknown" to Ignore, not to Unknown (yes, it is quite confusing but the term unknown means something different internally).
And yes, please clean up and leave only the related commits so we can review more.

The reason why it doesn't work is that you have to map "unknown" to Ignore, not to Unknown (yes, it is quite confusing but the term unknown means something different internally). And yes, please clean up and leave only the related commits so we can review more.

ohhh I see... I was confused and couldn't figure out what i was doing wrong. I have cleaned up the commits after struggling with the process a bit. It is exciting that i am also learning so much more about git through the process.
I will make the new changes and squash the commits into one once I am done. Thank you so much

It doesn't build because of a typographic error. Even if you fix that, it won't do what we have requested: you have to map the string "unknown" to InterfaceState::Ignore, not the string "ignore" to InterfaceState::Unknown.
Please, it is OK if the PRs are not perfect and it is OK to ask if you have doubts of you are stalled. But you MUST try to compile and test that it does what it's supposed to do before requesting a review.

It doesn't build because of a typographic error. Even if you fix that, it won't do what we have requested: you have to map the string "unknown" to InterfaceState::Ignore, not the string "ignore" to InterfaceState::Unknown.
Please, it is OK if the PRs are not perfect and it is OK to ask if you have doubts if you are stalled. But you MUST try to compile and test that it does what it's supposed to do before requesting a review.

Thank you so much for your patience and guidance.
I would carefully review all the comments on this issue again and work it out from there.

This has been stale for a while. If you still want to work on it, please reply with comment indicate plan.

Closing due to stale and proposed patch is wrong(not possible to amend).


add a wrapper to gdb which adds gcc (or other paths) as safe path

This fixes #10427. Though I'm not sure if defaulting to adding gcc is the right way to do it.

I think this would make gdb manpages not show up in the Nix profile path.

you're right, I thought the propagatedBuildInput would magically do the trick when in fact we need propagatedUserEnvPkgs and then you also have to run the default builder...
Anyway, now it seems to work. Alternatively, we could also create a symlink tree with buildEnv

hm, travis seems only to fail because 'no space left on device'. Not sure why it rebuilds so much, maybe a lot of qt/kde depends on gdb.
So, this works for me now, but thinking a little more about it I think it would be better to add some hook that adds all (or some?) packages of the current build environment to the safe gdb path. The problem is that, afaik gdb doesn't read any environment variables to add safe paths. So we have to add a "-x initscript" flag to the gdb call which this wrapper does, but I don't see how we can do this depending on hooks. An alternative might be to patch gdb to include an init script that reads the safe paths from some environment variable and then just change them in the hook. I'm also not sure how this works in the "nix-env -iA gdb"/environment.systemPackages=[gdb] case.
I'm also not completely sure of the security implications of adding all buildInputs to the safe paths, but I think you trust your buildInputs anyway.
Any comments?

(triage) @fkz any update?

Just ran into #10427 again, this still needs fixing.

A quick hack if you trust your nix store would be:
# ~/.gdbinit
set auto-load safe-path /nix

Are there plans to merge this? I can reproduce #10427 in 18.09, stable at aabc61049c011b40ef15c354d7d84c840d6b6a6d.

Any update on this pull request?

Closing due to lack of activity, feel free to reopen this if needed.

Superseded by https://github.com/NixOS/nixpkgs/pull/73574.


update version

Was this released? I think a npm version patch would also update the package-lock.json

I think a npm version patch would also update the package-lock.json so might want to double check that.

@pleek91 great suggestion. I also decided to use this PR to do some other housekeeping in preparation for the first "real release"

updated readme
moved internal stuff into utilities, not exporting from index
added has and clear methods to mapper
updated register to accept a single profile in addition to array of profiles
wrote a test for that ^

Nice! Next up vitepress docs?

I was thinking about it lol.


Fix MiqServer WorkerManager Process with Non Rails workers

We only added logic to set non-rails workers to started/stopped for kubernetes and systemd worker manager subclasses.  This meant if you ran rake evm:start locally with a non-rails worker it wouldn't ever be marked as started.
Also updated the systemd side to be consistent with kubernetes in not returning a worker that was just marked as started.


Fix for missing assimp zip file when building dependancies.

Hi,
Really cool project guys. I was getting started on this and had trouble building on Mac as i believe the URL for the assimp library has recently changed.  Fix is included.  Please let me know if ok.
Thanks,
PJ

Well I rather think it was a timeout as both links bring me to exactly the same page..

Yeah in the browser it does but in xcode using curl it failed for me.

Let me just repo it with original url and i will post the error i got :)

Ok, my bad, must have been timeouts. Cant see that error now. Will close.


fix: verifier overflow checks

Checks for overflows in the range verifier.
Partially addresses #60.

Still trying to figure out how to to type exceptions on the lint. The listed configuration option seems to have no effect.


Breaking changes after 5.2.4 -> 5.3.0 update

I was unable to find info if pixi is sticking to semantic versioning or not.
Anyway if it is not please feel free to close this issue
Expected Behavior
Minor version bump does not introduce breaking changes
Current Behavior
Minor version bump introduced breaking changes
Possible Solution
Don't introduce breaking change with minor version bump
Steps to Reproduce
Examples:
1.
https://github.com/pixijs/pixi.js/blob/v5.2.4/types/loader.d.ts#L28 contains on/once/off methods
https://github.com/pixijs/pixi.js/blob/v5.3.0/types/loader.d.ts does not contain on/once/off methods
2.
https://github.com/pixijs/pixi.js/blob/v5.2.4/packages/core/src/Renderer.js#L63 has forceFXAA prop
https://github.com/pixijs/pixi.js/blob/v5.3.0/packages/core/src/Renderer.ts does not have forceFXAA
3.
not easly trackable error with BitmapText:
TS2345: Argument of type 'TPIXIBitmapTextConstructorStyle' is not assignable to parameter of type '{ fontName: string; fontSize?: number | undefined; align?: string | undefined; tint?: number | undefined; letterSpacing?: number | undefined; maxWidth?: number | undefined; }'.

I can create repo with code that will compile under 5.2.4 but will break with 5.3.0 if that helps
btw  first two errors seems to be easy fix, IDK about 3
Environment

pixi.js version: 5.2.4 -> 5.3.0
Browser & Version: Does not apply
OS & Version: Does not apply
Running Example: If deemed necessary

This is intentional. We never properly deprecated events on Loader and it was challenging to convert to TypeScript because of the EventEmitter mixin. Any code that was previous build using events should continue to work runtime, but rebuilding you'll need to update to use the signals instead of events. I'll add a note about this on the release, thanks for pointing out.

The option forceFXAA was never used. This was a hold over from v3 or v4 that never got removed. Please discard if you were using this in your code.

We need more information on this. Can you just provide a reproduces just this issue?

Basically, we are in the process of upgrading our typings to be more specific. In the future we should consider type changes more carefully. In general, we've only been concerned about breaking runtime changes, not build-time changes. I imagine this will start to change in our next major release.


Testdriver: retry if cluster provisioning fails

The cluster termination could fail for a variety of reasons as it uses volatile infrastructure of various cloud providers. We should consider a way to let the T2 testdriver retry the cluster termination a configurable number of times before really giving up.

No longer an issue


docs: update scripts:registry hook example

docs: update script:registry hook example
🔗 Linked issue
Resolves #267
❓ Type of change

[x] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
The example in the docs on how to extend registry scripts via scripts:registry is not working. I updated it with a working example.
see #267

Thank you!


Failed to assign tasks correctly

Hi, I wrote a small piece of python code on a macbook which has 10 + 1 tasks. 10 similar sleeping task and 1 joint task. I am running it by 4 processes and found that sometime Jug cannot assign task correctly. It happens like one process does all tasks along and, at the same time, another 3 share the 11 tasks.

If I'm understanding your issue, correctly (and I may not), this is actually not a bug as it is outside of control of jug. Jug makes no attempt at "fairly" distributing tasks.
The distribution of tasks depends only on the scheduling of processes by the operating system, which can be very stochastic. If there are processes that are idle for a long time, this may be a jug issue, but what you describe seems like the expected behaviour.

I see what you mean, but the problem is the 11 tasks are executed twice. It's reasonable that tasks are assigned stochastically.

Ah, then it is a big problem.
Please post some code with more information.

I see. I changed the argument "start_time" to a fixed number and the problem is fixed. Thanks!


Send an empty response body to HEAD request

Description
HTTP HEAD requests MUST NOT return a response body
Motivation and Context
Tide currently returns a response body, in violation of the spec, as reported in linked issue
Closes #623
How Has This Been Tested?
Re-added the test mentioned in #623 and updated it for current tide api.
Upstream changes:
This depends on http-rs/http-types#190
Implementation concerns:
I'm not sure if this should be implemented as a default middleware and initially implemented it as one, but I cannot think of a situation in which tide users would want to break spec.

Closing because async-h1 hangs indefinitely, so this needs to be addressed there


Set up $LOAD_PATH (and possibly Bundler) from Java.

Converting lib/embulk/command/embulk_bundle.rb to Java. It's to be merged after #706.
What do you think? @muga

@muga Thanks. Jfyi, fixed bin/embulk to catch up with this change.
For testing, can we consider after all related changes are merged, or before releasing 0.8.28? That is because :

This part mainly manipulates the "global" JRuby instance. Testing that will be complicated.
These parts are going to be changed again and again before releasing 0.8.28, such as #543 and more. If we add tests with this PR, the test may need to catch up every time.

Can you consider about adding tests for this feature?

@dmikurube Sorry to your confused. The testing that I wanted to say is not for this feature. I wanted you to suggest integration tests for avoiding regression. Because you've been changing these parts a lot. Simple test is fine for me. The test scenario is based on how Embulk is used. like 1) install plugins by bundler 2) execute Embulk 3) confirm that ingested data is correct or not. How about this?

@muga Ah, got it. I do the similar processes in my local environments, but I agree that they should be finally automated, of course.
But, I think it's not the time yet. There are 3-4 more changes are expected around CLI and the bootstrap. Such tests would be added for the final state -- what do you think about this plan?

@dmikurube I see. It's good for me. LGTM.

Thanks! Merging.


Use a single tab field separator in keywords.txt

Each field of keywords.txt is separated by a single true tab. When you use multiple tabs it causes the field to be interpreted as empty. On Arduino IDE 1.6.5 and newer an empty KEYWORD_TOKENTYPE causes the default editor.function.style highlighting  to be used (as with KEYWORD2, KEYWORD3, LITERAL2). On Arduino IDE 1.6.4 and older it causes the keyword to not be recognized for any special highlighting.
Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords

Duplicate of pull request #238, maybe close one of them?

Sorry about that. I had intended to submit this PR to a hard fork of the library but accidentally submitted it to the parent instead.


ServiceEntry deletion - trigger endpoint shard update when some endpoints are remaining

…ints are remaining
Please provide a description of this PR:

Hi @ivpr. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes #43853

/ok-to-test

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
14033648f4e4809bc5428c6cc4cfbdce3c25cc42
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
74c4c159905a277535c8d5079f427cbcf501b3db
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu & @ramaraochavali I've added the test cases for this
The test case scenario was already present but we were not doing any assertions on edscache events. I've added the assertions for eds cache in all places and verified the tests to running
Below is the assertion failing without the code fix
https://github.com/istio/istio/pull/43852/files#diff-db93d0d3aef31b582e2969e9b40dcdce6b5f7d23172876ffec7f2c6285c81519R414
Please review

Can you fix lint?

@ivpr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test lint

gencheck_istio
8b6c539975fa3f0ac8bb79923b59bbb65a3b2e44
link
true
/test gencheck

release-notes_istio
a344358c64e78bfbf79ffd91a99916ec15733359
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6450ea871f1285e65cb3710508dfbf00486dd3f6
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali Fixed the lint errors. Had to amend and force push the commits to fix the author email for CLA. Please check

LGTM. Please add release notes also

@ivpr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
e555a49540cd79b1c3fe23867743855ff76236fc
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc