Custom script execution failing

Hi,
following template deployment throws an exception while executing a custom script extension while provisioning a VM, are you able to tell me what is trying to connect to please?
Enable failed: processing file downloads failed: failed to download file[0]: failed to download file: http request failed: Get [REDACTED] dial tcp <IP_ADDRESS>:443
Command executed:
$template_base_uri="https://raw.githubusercontent.com/elastic/azure-marketplace"
$template_version="7.3.1"
az group deployment create --resource-group "dev-elk"  --template-uri $template_base_uri/$template_version/src/mainTemplate.json  --parameters _artifactsLocation=$template_base_uri/$template_version/src/ esVersion=7.3.1 esClusterName=elasticsearch vmDataDiskCount=1 dataNodesAreMasterEligible=Yes adminUsername=kaiser adminPassword=********** securityBootstrapPassword=securityAdminPassword= securityKibanaPassword=******* securityLogstashPassword=********** securityBeatsPassword=****** securityApmPassword=********* securityRemoteMonitoringPassword=*********** vmDataNodeCount=2 xpackPlugins=No logstash=Yes vmLogstashCount=2 loadBalancerType=internal loadBalancerInternalSku=Standard --vNetName elk-vnet --debug

Can you provide more detail @dsiluri please? Some details that would be useful

The error message / log file from the failed deployment
Logs from the VMs

Hi
I'm receiving the same error when deploying with script. Only on data nodes. tried a lot deployments-redeployment. Logged in to data node - looks that VM do not have internet access. That why script execution is failing on data nodes. Logstash and Kibana nodes do have access, data nodes don't.
The cause of this issue is "loadBalancerInternalSku". If  "Standard" then fails if "Basic" then passes.
Different tier load balancer differently routes outgoing traffic from nodes.
There is a nice comparison of load balancers tiers https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-overview#skus
To make it working with Standard tier maybe require to create some outbound rules.

The cause of this issue is "loadBalancerInternalSku". If "Standard" then fails if "Basic" then passes.
Different tier load balancer differently routes outgoing traffic from nodes.

There's an integration test that deploys a cluster with Standard SKU internal and external load balancers. It can be run with
npm run release -- --test 1d-0m-1c-ext-slb-kp

If you want to keep the resource group around after the tests have run, add the --nodestroy flag to the end.
The test passes successfully:
[14:56:13] Working directory changed to ~\source\azure-marketplace\build
[14:56:14] Using gulpfile ~\source\azure-marketplace\build\gulpfile.js
[14:56:14] Starting 'release'...
[14:56:14] Starting 'default'...
[14:56:14] Starting 'sanity-checks'...
[14:56:14] Finished 'sanity-checks' after 20 ms
[14:56:14] Starting 'patch'...
[14:56:14] Finished 'patch' after 16 ms
[14:56:14] Starting '<anonymous>'...
[14:56:14] Finished '<anonymous>' after 261 ms
[14:56:14] Finished 'default' after 301 ms
[14:56:14] Starting 'deploy'...
[14:56:14] Starting 'clean'...
[14:56:14] Starting 'create-log-folder'...
[14:56:14] Finished 'create-log-folder' after 1.84 ms
[14:56:14] Starting '<anonymous>'...
[14:56:14] Finished '<anonymous>' after 1.84 ms
[14:56:14] Finished 'clean' after 6.57 ms
[14:56:14] Starting '<anonymous>'...
[14:56:14] Using version 7.5.0 for tests
[14:56:14] Using template: https://raw.githubusercontent.com/elastic/azure-marketplace/7.5/src/mainTemplate.json
[14:56:18] Using azure-cli 2.0.77
[14:56:18] logging into azure cli tooling
[14:56:21] start validating 1 arm test scenarios
[14:56:21] creating resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[14:56:29] validating 1d-0m-1c-ext-slb-kp in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[14:56:40] all 1 arm test scenarios validated
[14:56:40] start deploying 1 valid arm test scenarios
[14:56:40] deploying 1d-0m-1c-ext-slb-kp in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:20] checking external loadbalancer http://lb-<random>.westeurope.cloudapp.azure.com:9200 in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:20] checking kibana at http://kb-<random>.westeurope.cloudapp.azure.com:5601 in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:21] [PASS] expecting license in resource group test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST to be: trial and found: trial
[15:05:21] [PASS] kibana is running in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST with state: green
[15:05:21] checking kibana monitoring endpoint for rg: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:22] [PASS] cluster is up and running in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:22] [PASS] expecting 2 total nodes in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST and found: 2
[15:05:22] [PASS] expecting 1 data nodes in resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST and found: 1
[15:05:22] all 1 valid arm test scenarios deployed
[15:05:22] deleting 1 resource groups
[15:05:22] deleting resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:29] deleted resource group: test-xtreme-1d-0m-1c-ext-slb-kp-20191211-145614-EST
[15:05:29] logging out of azure cli tooling
[15:05:30] ============================================
[15:05:30] Integration test results
[15:05:30] ============================================
[15:05:30] PASS : 5
[15:05:30] FAIL : 0
[15:05:30] TOTAL: 5
[15:05:30] ============================================
[15:05:30] deleting temporary parameter files
[15:05:30] Finished '<anonymous>' after 9.25 min
[15:05:30] Finished 'deploy' after 9.25 min
[15:05:30] Starting '<anonymous>'...
[15:05:30] Finished '<anonymous>' after 16 ms
[15:05:30] Finished 'release' after 9.27 min

and ssh'ing into the data node, it has internet access. I've infrequently seen intermittent issues with Azure DNS, whereby resolution fails to resolve the artifacts URIs to download packages to bootstrap the cluster, but it doesn't happen too often.

To make it working with Standard tier maybe require to create some outbound rules.

There's an NSG configured to allow traffic from the external LB to the VMs when the Standard SKU is used, but this isn't needed for the internal LB according to the docs.
We’re closing this issue due to inactivity; if you’re still in need of resolution, feel free to re-open with the additional details and we'd be glad to help you out 👍

My mistake, I can replicate it when only a Standard internal LB is deployed and loadBalancerType is internal. Will look to fix this for the next release, 7.5.0


Fix react bootstrap version

react-bootstrap is breaking CI. For more information: https://github.com/react-bootstrap/react-bootstrap/issues/3231

 Urgent bug: Project dashboard isn't loading - GC unusable


scrape: make le and quantile normalization configurable

Proposal
This is a sister proposal for #12934. It's dealing with the same problem, but in a different way, which is not necessarily mutually exclusive, but if we implement the one, the need for the other might diminish.
Problem
The le label of a classic histogram and the quantile label of a summary contain values that are representing float numbers (although they are, as it is always the case, technically strings). While PromQL sometimes parses them back as floats (namely in the histogram_quantile function), it generally treats them as strings and matches them on strings. This creates problems because one and the same float number can be represented as many different strings (see #12934 for more details). Here are the practically relevant issues:

In Prom 1.x, all these label values were normalized (whether they came in via text format or protobuf format), using the usual Go formatting (%g). While I assume this can still yield unstable results in specific cases with many decimal places, this generally worked fine.
Prom 2.x stopped normalizing these label values, and also dropped protobuf scraping. All these label values were taken "as is", i.e. as exposed by the instrumented target, thereby effectively importing the formatting convention of the language the target was written in. This created confusion when moving from Prom1 to Prom2 because histograms and summaries coming from Java or Python suddenly showed up differently in Prometheus.
OpenMetrics tried to unify the formatting. While not ruling out all ambiguities for floats with many decimal places (see above), it mostly settled on a Python like formatting. This created confusion for Go binaries when switching them to OM.
Prom 2.40 brought us native histograms and – as a byproduct – resurrected the protobuf scraping. Protobuf has to normalize because the le and quantile values are actual float numbers in the format, rather than strings. To stay consistent with OM, the new protobuf parser uses OM-style formatting. This created confusion when you have Go binaries that were not yet using the OM mode of prometheus/client_golang (which is a huge number, e.g. all of K8s, Prometheus itself and many other binaries from the Prometheus ecosystem, …) and switch to native histograms. The intent was to scrape classic histograms as before, but now all the le labels are OM formatted.

At the dev summit in September 2023 we decided to always normalize the values of le and quantile labels, presumably in OM style. While that will unify things for the future, we still have the problem at hand that a migration from classic to native histograms cannot be really smooth because the le labels will change once you set the native histogram feature flag.
Proposal
In short, make the normalization of the le and quantile label values configurable in the scrape config.
The setting needs a good name. normalize_histogram_and_quantile_labels is probably too long, but you know what I mean…
This new scrape config setting should apply to scrapes in all formats, thereby fulfilling the dev-summit feature demand. However, by keeping things configurable, users can migrate (or not migrate) from one format to another under their own control.
The settings could be classic to normalize in the "classic" Prometheus style, i.e. vanilla Go %g formatting, and openmetrics to normalize in OpenMetrics style, and none to take the values as they are from the text format.
The default value of the setting would be to none for now, i.e. keep everything as is. In Prom 3.x, we could set the default to openmetrics.
There is a little wrinkle for protobuf because there is no none. Protobuf always normalizes for the reasons explained above. So the default behavior with protobuf format would effectively be openmetrics (if we keep things as they are now). However, the setting would still help, because you could set it to classic for Go targets to ease the migration. (Since we cannot know what the exposition would have looked like in text format if we scrape with protobuf, there is no easy way to automatically "do the right thing".)
Alternatives
We could also provide a relabel action to normalize labels in one way or the other. It could also be applied to other labels that happen to be numbers. While the relabel action could also allow for smooth migration, it would be very tedious to manually identify all classic histograms and summaries and relabel them. Arguably, a scrape config and a relabel action could both exist for different use cases.

@roidelapluie @matthiasr @krajorama This might be interesting for you.

Looking at from user perspective, currently enabling "native-histograms" is a breaking change, because suddenly series get renamed (le=1 to le=1.0). However it only happens for GO, not for Java, since java already exposes the boundaries as proper floats:
With client_java 1.0.0 (also with older):
# HELP histogram_seconds histogram
# TYPE histogram_seconds histogram
histogram_seconds_bucket{le="0.005"} 0
histogram_seconds_bucket{le="0.01"} 0
histogram_seconds_bucket{le="0.025"} 0
histogram_seconds_bucket{le="0.05"} 0
histogram_seconds_bucket{le="0.1"} 0
histogram_seconds_bucket{le="0.25"} 0
histogram_seconds_bucket{le="0.5"} 0
histogram_seconds_bucket{le="1.0"} 1
histogram_seconds_bucket{le="2.5"} 1
histogram_seconds_bucket{le="5.0"} 1
histogram_seconds_bucket{le="10.0"} 1
histogram_seconds_bucket{le="+Inf"} 1
histogram_seconds_count 1
histogram_seconds_sum 1.0

So it means to not break the user experience you'd have to decide per target/metric what to do. Also it means we have no way of automatically deciding what to do. If the scrape config involves discovery, targets can be GO or Java.
We already have relabel config:
    metric_relabel_configs:
      - source_labels:
        - le
        regex: (.*)[.]0+
        replacement: $1
        target_label: le

I feel like this is one of those things that we just have to live with until 3.0 where we should normalize "le" to OpenMetrics. Which will mean the same breaking change that we experience now, so I'd just document what happens now with native histograms, offer the above relabel config as workaround (which will work forever pretty much), but avoid introducing a new configuration parameter that we'd have to support forever.

Hmm I thought we would make normalization unconditional (modulo a feature flag for 2.x). Per target configurability seems like we add a lot of complexity only to allow dragging the issue around forever, when I would rather set a goal and timeline to get it over with. We've had this inconsistency for a long time and it's escalating now; I think we should squash it for good (make the behavior consistent) rather than building better support for keeping it inconsistent.
@krajorama 🤯 I didn't even realize that you could do this with metric relabeling, that's actually really neat. I think we can come up with the inverse rule as well, off the top of my head it would be something like
metric_relabel_configs:
- source_labels:
  - le
  regex: ".+"
  target_label: __tmp_normalize_le_format
  replacement: true
- source_labels:
  - le
  regex: ".*[.].*"
  target_label: __tmp_normalize_le_format
  replacement: false
- source_labels:
  - __tmp_normalize_le_format
  - le
  regex: "true;(.*)"
  target_label: le
  replacement: "$1.0"

So functionally, this is configurable on a per-scrape-config basis today. This offers a path (which we can and should document) for users who really want to roll this out on a per-target basis. Those who have completed that rollout, or who are OK with doing it all in one step, can enable the feature flag to get the future behavior now. Those who upgrade to 3.0 get normalization, period.
cc @jaredjenkins

Agreed with @matthiasr. It would be ideal to just normalize it openmetrics. Ideally we could enable it earlier if we want to via a feature flag in Prometheus 2.x so that folks can address now as they start experiment with Native Histograms.

By the way, if we had the text representation of native histograms, we wouldn't have to force this issue until 3.0, would we?

Yes that would still allow the inconsistency in classic histograms and summaries, but only if we default to the text representation (which I suspect won't be very efficient).
The number format issue is older than NH, as @beorn7 laid out. It only shows up more now because native histograms give users an incentive to face it. I am mildly against allowing users to get the good stuff (native histograms) without dealing with the mildly breaking stuff (number normalization). I think the pull of native histograms is a good opportunity to get everyone into a place where this number format is predictable.

I would still like us to stage

Prometheus will always normalize le and quantile label values itself, no matter what protocol is used for scraping and no matter if the target correctly implements OpenMetrics formatting.

behind a feature flag now, or document how to get the future behavior using relabeling. I believe we should give at least as much weight to "how to get to the future" as we give to "how to stay in current state".


RadioGroup onBlur event prop

Provide a general summary of the feature here
The RadioGroup component has an onChange event prop but no onBlur event prop, which makes validation rather tricky for this component.
🤔 Expected Behavior?
Provide an onBlur event prop for RadioGroup and call the handler with the event bubbled from the focussed Radio input when the native blur event is dispatched.
😯 Current Behavior
No blur event is bubbled from the Radio component
💁 Possible Solution
I have been able to work around this by using DOM selection techniques from the Radio component's onBlur handler, but this is awkward, messy and likely to break over time if the RadioGroup or Radio components DOM structure changes in the future. e.g.
const value = (parentNode?.parentNode?.parentNode.querySelector('input:checked') as HTMLInputElement)?.value ?? null;

🔦 Context
In my use case I need to validate form fields as the user tabs through the form even if no change has been made, therefore I'm relying on onBlur being available in RadioGroup like it is with other top-level form field components.
💻 Examples
No response
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Seems like a reasonable request, especially since we have this in other form components.

Also, our next release will include support for native form validation, so you may want to see if that helps your use case: https://github.com/adobe/react-spectrum/pull/5313 https://github.com/adobe/react-spectrum/pull/5288

@reidbarber Ah, I've gone my own way with form-level validation for numerous reasons. Nonetheless, it's useful to know that it will be available soon - so thanks for mentioning. I'll be keen to see how this ticket progresses as I'd like to remove the hacky workaround


Diagnose non_runtime_protocol

Diagnose on usage of ObjC protocols when their metadata are required, but the protocol actually have the non_runtime_protocol attribute, which removes the metadata on the ObjC side.
The patch is based on the discussion with John McCall and Manman Ren.

@swift-ci please test

@swift-ci please test macOS platform

@swift-ci please test

@rjmccall could you please take a look? Thanks!


[LW-10808] Update HW dependencies

This PR introduces:

Updated @cardano-foundation/ledgerjs-hw-app-cardano to version 7.1.3
Updated @trezor/connect to version 9.3.0
Fix delegation / staking while using Ledger HW device

Testing Checklist

Slack QA thread
[ ] HW Ledger and Trezor regression testing

QA Note: If you want to test it on preview, please use https://github.com/input-output-hk/daedalus/tree/todelete/lw-10808-cardano-node-9-with-hw-updates. It is a temp branch until we have the Michals update merged https://github.com/input-output-hk/daedalus/pull/3212

Review Checklist
Basics

[ ] PR assigned to the PR author(s)
[ ] input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
[ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
[ ] PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
[ ] PR link is added to a Jira ticket, ticket moved to In Review
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR contains screenshots (in case of UI changes)
[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with typescript types
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Update Slack QA thread by marking it with a green checkmark

Awesome! 🎉
The "tests" check is failing, though:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=18". Got "14.21.3"

Are we really using Node.js 14? I don’t think so 😕 Especially since Buildkite passed?

Thanks @michalrus that is something I wanted to ask as well.
I see nodev18.12.1. To be honest, I think we are good

Re: Netlify – given that:

Netlify forces running yarn install as the very first step,
Which fails because their machine doesn’t include libudev.h (sudo apt-get install libudev-dev),
And you cannot run anything before their call to yarn install,
And they don’t allow to run commands with sudo,
And in our preinstall, the node_modules aren’t populated, so it's too early to unpack libudev-dev manually,
And in our postinstall, it’s too late because yarn install already failed with missing libudev.h

… I really don’t know how to fix this.
Maybe a separate package.json which only builds storybook? Though they force yarn install from the root anyways, so it won’t work.
It feels like a really bad design decision on Netlify’s part, or I'm not seeing something.

Netlify fixed in 4ce5d1f6628842a5f1af156a84dccc8985b8faa6 – had to use Homebrew :)


ElementGlobal, more generic ElementH2

This is related to #39 and #23 .
It already replaces the existing ElementH2.
My personal need is calculating higher order derivatives.
Fixes #39 .

I'm now looking into Bogner-Fox-Schmidt.

Alright, it seems to be working fine. Noticed one issue in how boundary conditions are set in test_convergence_h2, going to fix that later.


pull request for e2e test at 01/11/2017 12:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


MyQ getting constant timeouts

Home Assistant release with the issue:

.99.3
Last working Home Assistant release (if known):
.99.3
Operating environment (Hass.io/Docker/Windows/etc.):

Docker on Ubuntu
Integration:

Description of problem:
I recently opened https://github.com/home-assistant/home-assistant/issues/25727 because of myQ issues. I'm having a similar problem but a different error. I can connect to myQ using the app and can open/close the door. However, when using HA (via an automation), I get the following error:
Getting device states failed: 17:37:33.014320 Constant timeouts while requesting data from api/v4/UserDeviceDetails/Get
I understand that there's a PR that's been in development, but I'm thinking it might need to happen sooner than later.
https://github.com/arraylabs/pymyq/pull/23
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
platform: myq
username: !secret myq_username
password: !secret myq_password
type: chamberlain

Traceback (if applicable):
Getting device states failed: 17:37:33.014320 Constant timeouts while requesting data from api/v4/UserDeviceDetails/Get

Additional information:

Same...
https://i.imgur.com/sXG25YH.png

MyQ seems to have made some changes today. I can't login via V4 or V5 endpoints.
V4 response:

V5 response:

Is the integration still working for anyone else?

Component is not working on my end.

Need to switch to MyQ V5 API. https://github.com/arraylabs/pymyq/issues/22#issuecomment-518861064

Do we have an instruction to patch it temporary?

Not that I know of, integration is completely borked now.

That's it, I knew this day was coming, I am getting a new ZWave linear gocontrol device for my garage door.

Hi all – FYI, we're working furiously to get the underlying library updated (https://github.com/arraylabs/pymyq/pull/23). More to come.

Thank you. I'm running after updating Home Assistant.  The updated myq component registers a new entity.
(just curious what are the constraints for uniqueness with entity registration, could I ask for a breadcrumb to this point in the Home Assistant Code base?)


feat(segmenter): add location for SpacySentencizer

I have read the CLA Document and I hereby sign the CLA

Thank you very much for the contribution!


Remove private flag to prevent packaging issues in Yarn

This PR drops private: true from the package.json file, since this appears to cause a known issue in Yarn 4 (a widely-used alternative to NPM) where new checksums are generated periodically, rather than being reproducible.

Hi @SamuelMS ,
We set private: true originally as there was no intention to publish the content of this repository as an npm package (see my response on the other issue). That said, I do not suspect it should be problematic to drop this flag. I will check with the team to confirm.

This has been resolved here: https://github.com/frontapp/front-chat-sdk/pull/16


build(lint): migrate to ESLint v9 with flat config

Issue or need
ESLint v9 has been around for a while. It's time to update. However, it will require a bit of work as configuration files format have changed. New format is known as flat config. So a migration will be needed in there.
This means also upgrading to Typescript ESLint v8.

Proposed changes
Similar process as done in https://github.com/davidlj95/website/pull/825
TL;DR: remove linting system and configurations. Add it back with ng add @angular-eslint/schematics. Configure things back again.
New configuration system for ESLint doesn't support looking for closest ESLint config file to add rule overrides. So everything is now in main ESLint config.
Notable linting rules changed:

(Readonly)Array -> (readonly) []

Additional changes:

Added stylistic rules for Jest

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#1035  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Form styling

Addresses field-width comments from @fofr in https://github.com/alphagov/policy-publisher/pull/3
Also adds a page title to the new policy form page.

Looks good to me :+1:


doc: update Lighthouse Bot to Lighthouse CI

Pull Request Test Coverage Report for Build 1320

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1318:
0.0%

Covered Lines:
44

Relevant Lines:
44

💛  - Coveralls


Is having a separate admin and normal account actually helpful?

[based on a conversation we had in person some months ago, and then promptly forgot about]
Having separate admin and normal accounts is good advice on Windows, but Microsoft has invested a great deal of effort in this part of Windows and the Windows ecosystem has followed suit.
I've seen little evidence that making normal accounts work as a security boundary has the same priority for Apple or for Mac software vendors, and enough breakage that I suspect that they're mostly designed and tested to make it harder for kids to mess up a family computer:

When I used a Mac that was configured with separate admin and normal accounts (through El Capitan in late 2015) many of my installed-from-the-Internet apps would not update properly. The level of frustration was pretty much steady between late 2009, when I started running with reduced privileges, and late 2015, when I retired that Mac. I would be surprised if this has gotten better.
My instinct is that apps largely work fine if you have an admin user logging in regularly, less so in the case where the admin user never logs in interactively like this guide suggests.

macOS has privilege escalation vulnerabilities discovered regularly and historically receives fixes for them more slowly than iOS does.

The local intrusion prevention software in this guide, like BlockBlock, seem to mostly target actions that could only be performed by an attacker already running code as an admin user.

I don't see anything else in this guide that will detect local privilege escalation that is not immediately exploited, either from a known or an unknown source. (The audit logs might, but I don't feel like I've learned how to see such an attack from reading this guide.)

Does anyone have thoughts? / data on the effectiveness of this advice on the Mac? / ideas on how to catch privilege escalations when the system doesn't?

I am not sure I understand what you are saying. The fact of the matter is that running with an admin account exposes you to flaws in programs that you execute with elevated privileges, like sudo and Apple’s security framework. There was a bug in this framework in Yosemite’s time that allowed an attacker to gain elevated privileges due to the mere fact that the user was already authorised as an admin. Until Sierra, sudo was also configured insecurely (it arguably still is) as it allowed any program to obtain root privileges during the timeout window. There are many little flaws like these that make this a worthwhile consideration, as it reduces potential attack vectors.
I am also not sure why you had so many bad experiences, because I have had none of those. OS X is still a multi-user system at its heart and correctly installed software works for each user in the same way. Applications bundles in /Applications and binary images in /bin, /sbin and so forth are accessible to all users. I have been running with two accounts for a while and never had to log in using the GUI login window at all. Everything is done with prompts and the command line and the interaction with the admin account is kept at a minimum this way.

Separate admin and user accounts are preferable. You can also set up brew under the admin account, so it  cannot be directly run without being logged in as the other admin. Then you can also lock down the standard user account ever further. Or, you could even set up a completely separate user for brew alone and only allow brew tasks. Privilege segmentation is preferable, but it may impact usability for noobs.

This is what MacPorts does as well. It has its own user account.

Never had any of the issues updating my apps from the internet, always had to authenticate during the update process.
+1 to the prior comments on separate admins. Never used an admin account for anything other than updating and making system changes, ever.
I don't consider macOS to be flawless with its security posture so I'm not surprised there were (and potentially still are) privilege escalation vulnerabilities...
It's all about minimizing risks, really.

And I'm highly dubious towards BlockBlock, or anything from Objective-See for that matter.

Out of genuine curiosity: would you care to elaborate on that, @marcus-cr?

Oh, don't get it started again :-)

@rawtaz problem is I have no idea what I would start? I surmise from your comment there is some long standing quarrel? Having just recently been pointed towards the Objective-See apps and feeling a bit unsure what to think of them, I would be glad for pointers.

@kopischke: #90

It's not fair to always bash objective-see apps.
All are very useful, if you doubt just check what's sent over internet.
Patrick Wardle is now involved in several projects to enhance privacy.
If I had to embrace similar career, I would also try to get my first job in 'official' rat-nest, to learn as much as possible.
If you are really paranoiac, check the oldest vpn...
If I was nssa, I would create a cheap, high level security vpn, so I can directly track all users.
I'm very far for most experts here, but I think all this should be divided in different goals: stay hidden few days for journalists/activists, stay away from all advertisers/insurances blood suckers, stay away of malware.

Not bashin', just sayin'. I'm sure their apps are useful. @kopischke: the best intro would be Eitot's comment with #90

Also relevant to this discussion: SIP
This provides some of the mitigation effect previously offered by non-administrative accounts.

Added a link to this discussion under caveats.


fix: process.env inacessible in browser tests

PR for #177

@dignifiedquire All the node tests have the full env available exposed to them anyway so I don't see a reason to limit the accesible env vars in the browser.

I think using the proposed solution from here should work without requiring another plugin

I can also copy-and-paste the 10 line plugin into the aegir codebase, but is that a good idea?

The webpack solution does not work (or I'm doing something wrong):
diff --git a/src/config/webpack/index.js b/src/config/webpack/index.js
index 62b135e..d98fa3f 100644
--- a/src/config/webpack/index.js
+++ b/src/config/webpack/index.js
@@ -24,7 +24,13 @@ function webpackConfig () {
         path: utils.getPathToDist()
       },
       plugins: [
-        new webpack.DefinePlugin(utils.getEnv('production').stringified)
+        new webpack.DefinePlugin(utils.getEnv('production').stringified),
+        new webpack.DefinePlugin({
+          'process.env': Object.keys(process.env).reduce((res, key) => {
+            res[key] = JSON.stringify(process.env[key])
+            return res
+          }, {})
+        })
       ]
     }, userConfig)
   })

Lets do this for now

Didn't work in webworkers, fix is in #187


Add max length limit to string values

Motivation:
Recently, we run into issues where bad data is getting indexed into Pinot.
The length of one single string value is more than 1M, and cause the
dictionary size to be huge (>2G) and also cause int overflow and then crash
the server. In most of the cases, super long string is not even queriable,
and trying to index them is usually caused by client code bug. So we decide
to add a configurable limit to the length of string columns. If the value
for the column goes over the limit, the value will be trimmed to be the
length limit.
Added "maxLength" into FieldSpec, so each field (column) can have different
length limit.
The default limit is 512 (number of characters but not decoded bytes length).
NOTE: for string with null character, the part after the first null character
will be truncated because null character is reserved as padding character

Codecov Report

Merging #3445 into master will decrease coverage by 0.04%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master    #3445      +/-   ##
============================================
- Coverage     70.59%   70.54%   -0.05%
  Complexity        4        4
============================================
  Files           998      998
  Lines         45634    45642       +8
  Branches       6108     6110       +2
============================================
- Hits          32216    32200      -16
- Misses        11311    11324      +13
- Partials       2107     2118      +11

Impacted Files
Coverage Δ
Complexity Δ

.../data/recordtransformer/SanitationTransformer.java
100% <100%> (+8.69%)
0 <0> (ø)
:arrow_down:

...va/com/linkedin/pinot/common/utils/StringUtil.java
72.22% <100%> (+1.63%)
0 <0> (ø)
:arrow_down:

...java/com/linkedin/pinot/common/data/FieldSpec.java
75.6% <82.35%> (-0.34%)
0 <0> (ø)

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
0% <0%> (ø)

...egation/function/customobject/MinMaxRangePair.java
75.86% <0%> (-24.14%)
0% <0%> (ø)

...lix/EmptyBrokerOnlineOfflineStateModelFactory.java
86.66% <0%> (-13.34%)
0% <0%> (ø)

...kedin/pinot/core/util/SortedRangeIntersection.java
83.82% <0%> (-7.36%)
0% <0%> (ø)

.../predicate/NotEqualsPredicateEvaluatorFactory.java
84.74% <0%> (-6.78%)
0% <0%> (ø)

...e/impl/dictionary/LongOnHeapMutableDictionary.java
82.22% <0%> (-6.67%)
0% <0%> (ø)

...e/operator/dociditerators/SortedDocIdIterator.java
59.45% <0%> (-5.41%)
0% <0%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16559dc...3dc4543. Read the comment docs.


Balance industry to craftsmen/clerks pops

IrishB_CubedScheming
I am curious, for a lot of countries in the 1946 version, you have all these craftsmen pops but no factories, was this by design?
simsulla
Japan, Germany, yes. For the rest there may be some excess or deficit, but not overtly much.
permalinkembedsaveparenteditdisable inbox repliesdeletereply
IrishB_CubedScheming
Started as Ireland and there are tens of thousands of craftsmen with no jobs, seems weird to have the pops to work in factories but no industry.

Not a bug.. some nations have an educated population and workers but not yet developed industries. Ireland would such an example.


failing to reload file (maybe bug?)

Hi, I am getting some unexpected issue when trying to do the following, in steps.

obs = load model skill track observation (from a dataframe, let's be original and call it df)
mod = modelskill.Modelresult(file.dfsu) # must be an area dfsu
cc = modelskill.match(obs,mod)
comparer_list = append (cc) #just store in a list
so far so good, no issues. Now I happen to have another track during the ~same time span,  from a different provider, so I have it in another csv, and what I am trying to do is to attach it to the comparer list to convert later to a comparer collection, but cannot reach that step, since it fails before when I do the following steps:
obs = load model skill track observation #(the OTHER observation, this works)
mod = modelskill.Modelresult(file.dfsu) # Here I call the same dfsu as before.
cc = modelskill.match(obs,mod) # CRASH, I get error Exception: Could not load file .....file.dfsu  (Error code 2003)
so I cannot reach the point to the comparer collection.

I tried removing the second mod = ... line since it is the same dfsu so kind of pointless to re-define the ModelResult, and if I do, I get the same error.
I feel like after the first cc.match mikecore is failing to flush/close the Dfsu file, and if I try to pair it later to another observation, it cannot be opened because it is 'already' open.

Can you provide the stack trace?

let me make a failing notebook


feat(devops): add mkcert package

Add mkcert package.

Hi! The latest release is two years old, and already packaged in a lot of debian based distros (https://repology.org/project/mkcert/versions). Can you give me a little bit more context about why you think it would be nice to add mkcert to wakemeops?

Oh sorry, I tested on a raspberry pi and couldn't find the package, I think it's best not to add it actually.
(The use case was to manage trusted self-signed certificates to work on a kubernetes operator inside kind)


Add 2 users as admin of openshift-client-plugin

Repository URL
https://github.com/jenkinsci/openshift-client-plugin
New Repository Name
https://github.com/jenkinsci/openshift-client-plugin
Description
Could you please add the following users as commiters of the project
GitHub users to have commit permission
@akram
@mbharatk
@divyansh42
@jkhelil
Jenkins project users to have release permission
akram
divyanshu42
mbharatk
Issue tracker
GitHub issues

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that the security team was notified about the request and will soon participate in this issue to assist.
The team is usually starting by a quick superficial audit and if it's not sufficient, they are planning a deeper audit.
Commands
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-required => the superficial audit was not sufficient, a deeper look is necessary :mag:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/audit-review => the findings from the audits were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message)

Hey,
if you want to update the release permission of your repository, please file a PR against this repository, where you modify the entries of your permission file: https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-openshift-client.yml#L8
Everyone listed as developer has release permission. You can add the two new users yourself :)
To modify GH permissions, please file a helpdesk issue.
Issues on this repository are solely for new hosting requests.

/audit-skip


Add support for nested map property names in errors.

For the following JSON where the value property is limited to 2048 chars:
{
  "data": {
    "gameType": {
      "value": "Something longer than 2048chars...",
    },
  }
}

Example error before change:

value in body should be at most 2048 chars long.

Example error after change:

data.gameType.value in body should be at most 2048 chars long.

Fixes #2684

I have no idea why the circleci build is failing... it seems unrelated to this change.

FYI @casualjim, this is essentially building on #2684.

I believe I forgot to verify the tests last time around.  I'll try to take a look at them tomorrow.

I fixed the build on master, if you update your base branch the tests should be passing


Run against pre-compiled executable

For complex builds where a simple go run is insufficient, it would be good to be able to run debugger directly against the executable, ala delve's exec command.

this is a good idea, can you take a look and suggest an approach to do that?


Type error diffing across type mismatches with aliases

I saw an example where there was a type mismatch between a Result and [Ok ..., Err ...] and it expanded things in an unhelpful way...lots more should have been elided with ellipses!

This is written up in more detail in https://github.com/roc-lang/roc/issues/5944 . Closing this issue in favor of that one.


Getting crash due to StringIndexOutOfBoundsException inside RecyclerView

I'm using ReadMoreTextView in RecyclerView.
Getting crash due to StringIndexOutOfBoundsException so many times inside RecyclerView.
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.waspito, PID: 17585
    java.lang.StringIndexOutOfBoundsException: length=35; index=241
        at java.lang.String.getChars(String.java:788)
        at android.text.TextUtils.getChars(TextUtils.java:148)
        at android.text.SpannableStringBuilder.<init>(SpannableStringBuilder.java:68)
        at com.borjabravo.readmoretextview.ReadMoreTextView.updateCollapsedText(ReadMoreTextView.java:137)
        at com.borjabravo.readmoretextview.ReadMoreTextView.getTrimmedText(ReadMoreTextView.java:114)
        at com.borjabravo.readmoretextview.ReadMoreTextView.getDisplayableText(ReadMoreTextView.java:90)
        at com.borjabravo.readmoretextview.ReadMoreTextView.setText(ReadMoreTextView.java:84)
        at com.borjabravo.readmoretextview.ReadMoreTextView.access$200(ReadMoreTextView.java:33)
        at com.borjabravo.readmoretextview.ReadMoreTextView$1.onGlobalLayout(ReadMoreTextView.java:206)
        at android.view.ViewTreeObserver.dispatchOnGlobalLayout(ViewTreeObserver.java:1056)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2629)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1722)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7605)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1029)
        at android.view.Choreographer.doCallbacks(Choreographer.java:852)
        at android.view.Choreographer.doFrame(Choreographer.java:787)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1014)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7397)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)

same

I think not only in recyclerview

have solve it ?

hmm i think need. to change to other lib

I've tried debugging this and I found that this part right here is causing it.
On this method of ReadMoreTextView.java
private CharSequence updateCollapsedText() {
        int trimEndIndex = text.length();
        switch (trimMode) {
            case TRIM_MODE_LINES:
                trimEndIndex = lineEndIndex - (ELLIPSIZE.length() + trimCollapsedText.length() + 1);
                if (trimEndIndex < 0) {
                    trimEndIndex = trimLength + 1;
                }
                break;
            case TRIM_MODE_LENGTH:
                trimEndIndex = trimLength + 1;
                break;
        }
        SpannableStringBuilder s = new SpannableStringBuilder(text, 0, trimEndIndex)
                .append(ELLIPSIZE)
                .append(trimCollapsedText);
        return addClickableSpan(s, trimCollapsedText);
    }

When you set the mode to TRIM_MODE_LINES, that case will execute and there are times that the value of trimEndIndex is negative so the if statement below it will execute and when trimLength is greater than the actual text length, this will cause the SpannableStringBuilder to throw and index out of bounds error.
ps. the trimLength have a default value of 240

I found out that one of the reasons for this is old data is still there, because of the recycling mechanism of recyclerview. What I mean is the old text is still there and it was used to calculate other variables within the ReadMoreTextView to initialize it, so by the time that the new text is passed into it will used the precomputed values from the old data. In this case the length of the old text is used to initialize the SpannableStringBuilder which caused the index out of bounds.
I added a setting to recyclerview to disable the recycling mechanism to avoid this issue. Altho it solved it, but it beats the purpose of the recyclerview and it obviously affected the performance. Have to find another way for this. Maybe put a handler inside the ReadMoreTextView to update the data effectively or wait for the recyclerview to finally load the new data first, but don't know how yet. Hope this will help others to figure out this problem once and for all.

i do not have much time to solve the library problem, so i using this lib : https://github.com/devendroid/ReadMoreOption

I have a possible solution. I'll work on this.

ok buddy, if u want to make it easy
i think it will better using this layout and toggle hide/show instead of readmore
LinearLayout vertical
LinearLayout vertical
[TRIM_TEXT]
LinearLayout vertical
[FULL_TEXT]
LinearLayout vertical

Is anyone still working on this lib? No pull requests, no commits, is there maybe an updated repo with this issues fixed?


Don't let Window width too small

Describe the bug
The Window width is set as a % of the screen width, if is changed to a very small value (ex:5%) the window is deformed.
Maybe calculate the minimum width needed to accommodate the icons?
Of course the user can fix this making the % bigger  and that's all.
How To Reproduce
Versions

GNOME Shell 42.0
GCH   Version: 13
org.gnome.shell.extensions.clipboard-history cache-only-favorites false
org.gnome.shell.extensions.clipboard-history cache-size 100
org.gnome.shell.extensions.clipboard-history clear-history @as []
org.gnome.shell.extensions.clipboard-history confirm-clear true
org.gnome.shell.extensions.clipboard-history disable-down-arrow true
org.gnome.shell.extensions.clipboard-history display-mode 0
org.gnome.shell.extensions.clipboard-history enable-keybindings true
org.gnome.shell.extensions.clipboard-history history-size 1000
org.gnome.shell.extensions.clipboard-history move-item-first true
org.gnome.shell.extensions.clipboard-history next-entry @as []
org.gnome.shell.extensions.clipboard-history notify-on-copy true
org.gnome.shell.extensions.clipboard-history paste-on-selection false
org.gnome.shell.extensions.clipboard-history prev-entry @as []
org.gnome.shell.extensions.clipboard-history private-mode false
org.gnome.shell.extensions.clipboard-history process-primary-selection false
org.gnome.shell.extensions.clipboard-history strip-text false
org.gnome.shell.extensions.clipboard-history toggle-menu ['V']
org.gnome.shell.extensions.clipboard-history toggle-private-mode ['P']
org.gnome.shell.extensions.clipboard-history topbar-preview-size 10
org.gnome.shell.extensions.clipboard-history window-width-percentage 20
Steps to repro
Set a small Window width  value.
Additional context (if a crash, provide stack trace)

I decided to not impose any limits because what if someone has an absolutely shmassive monitor?  Oh well. :)


something goes wrong when I set "editor.formatOnSave": true

If I set "editor.formatOnSave": true in VS Code, when I save my .sass file after modify, vscode-sass-format plugin will reset my file before excute sass-format.

Hello PickerLee, thanks for reporting this issue. Please update extension to the latest version and let me know if everything works as expected. Thanks.

It works! thx

Thanks.


Simplified qbatch usage

In an older version of qbatch there was a much more simple usage:
qbatch [options] <command_file> <chunk_size> <walltime>

This syntactic sugar was good for quick and dirty submissions when you knew the defaults are good. Should we support this? I'm not convinced but I thought I'd toss it out there as an option.

This feels like special casing like sge_batch
I'm more in favour of presenting a consistent (with unix principles) interface like we have.

Andrew Jankie mentions:
qbatch --logfile blah.log -- do_something_args.pl *.mnc

This might be a nice way to do it.

I think this is a very nice way to do it.

I think you guys are talking about what is described in issue #35.
This issue is about providing a short cut for submitting a file of commands.

But I agree, using the -- is fine way of separating qbatch arguments from the single command and its arguments.

Oops, yes this discussion should be at #35

We shouldn't support this.


ImportError when running redshift-upload-copy.py utility

Hello,
I'm getting this trace when I attempt to run the utility:
[root@host UnloadCopyUtility]# python redshift-unload-copy.py config.json us-west-2
Traceback (most recent call last):
File "redshift-unload-copy.py", line 24, in
import pg
File "/usr/lib64/python2.6/site-packages/pg.py", line 31, in
from _pg import *
ImportError: /usr/lib64/python2.6/site-packages/_pg.so: undefined symbol: PQescapeIdentifier
Not sure what this entails, I verified my configuration's JSON looks correct. Anyone who's familar with this might be able to tell me what I'm missing?

Looks as tho it was a library issue since I was using postgreSQL8.x libraries. I've updated them but I'm getting a different error now:
Traceback (most recent call last):
File "redshift-unload-copy.py", line 28, in
from boto import kms, s3
ImportError: cannot import name kms

Looks like boto needs an update. Can you please run pip install --upgrade boto and see if that resolves the issue?
Ian

Hi,
I'm getting the exact same error when running the analyze compression utility.  I've run 'pip install --upgrade boto' but still get the same issue.
Jon

This utility requires pg which in turn requires libraries installed as part of the Postgres client, version 9.0 or higher. Namely PQescapeIdentifier appeared in 9.0. Judging from your library path /usr/lib64/python2.6/site-packages/pg.py I see that your version of Python is 2.6, so I'm going to hazard a guess that you are running CentOS 6.x, which includes Postgres 8.x in the updates repo, or another distribution that displays similar behaviour.
Can either @580farm or @jws1987 check your version of Postgres client and update this issue?


⚠ Bofrost.lu has degraded performance

In ffba1ae, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1918 ms

Resolved: Bofrost.lu performance has improved in 9a560a3 after 22 minutes.


Menu bar doesn't follow dark/light theme on Windows

The window title bar follows dark/light them on Windows nicely but not the menu bar.
Is it possible to do or a limitation of win32 api?

I saw the linked PR was merged, but I wasn't sure if the feature was added to to v1.* or if this is to be included in v2. I'm currently working in v1 now, and I'm finding that on Windows, even with both my OS and my window theme set to dark mode, while the title bar theme seems to behave correctly, my menu bar is consistently showing up in light mode colors.
If someone could point me to any configs I might have missed or if this feature is available in v1 at all or if there's a solid workaround in v1, I'd greatly appreciate it.

That's for v2, v1 will stay as is

Is it included in the beta release of V2 that was announced earlier this month?

yeah, it is included


IOS: You must override the supportedEvents method  Error thrown when supportedEvents is implemented in super class

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
Environment:
OS: macOS High Sierra 10.13.2
Node: 9.11.1
Yarn: Not Found
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.2 => 0.55.2
Description
RCTEventEmitter has a check implemented in class initializer to check that the Implementation being created implements 'supportedEvents' method. this is achieved here
But the RCTClassOverridesInstanceMethod method defined here uses class_copyMethodList obj-C Runtime method to get instance methods and iterate over them to see if required method is implemented.
as per Apple Docs class_copyMethodList does NOT return instance methods implemented by super classes.
This causes the app to crash in Dev mode (because of RCTAssert?) if the app has its own hierarchy of RCTEventEmitters, in which case the supportedEvents is implemented by an intermediate superclass between the current class and RCTEventEmitter.
IMO, the implementation should walk the inheritance hierarchy till RCTEventEmitter to make the correct assertion.
Reproducible Demo
Create a Native Module with One BaseEmitter which extends from RCTEventEmitter implement all the required functionalities also the supportedEvents method. Now create another class MainEmitter which extends from BaseEmitter, do not implement the supportedEvents method in MyEmitter to re-use implementation from BaseEmitter
App will crash on first use of MainEmitter

@react-native-bot Yes, I can reproduce this issue in latest version as well.

Can you update your original issue accordingly?


ADFS is not waiting for Authenticator request

Normally the ADFS having MFA enabled will redirect the ADFS login page to the authenticator prompt confirmation page. But this code is not waiting for that and return in response with MFA page.

It's been a while, but for anyone interested - I've created another package aws-saml-session-mfa, which supersedes this one and adds more features like handling MFA or supporting different kinds of identity providers. Please give it a try!


port MergeIntervalLists (not as a walker)

the requirement is to port the code and change the interface from a readwalker and implement tests.

not for 4.0


Handle data storage

Figure out and configure a data storage solution.

We have some solutions:

Json file
SQLite
Postgres
Mongodb

We can implement a DAL that will let us change our way later.


Formal polynomials.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#836
#835  👈
#834
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Alon-Ti and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 73.22835% with 68 lines in your changes missing coverage. Please review.

Project coverage is 92.18%. Comparing base (5cea2f8) to head (300bc79).

Files with missing lines
Patch %
Lines

crates/prover/src/constraint_framework/poly.rs
73.22%
61 Missing and 7 partials :warning:

Additional details and impacted files
@@                     Coverage Diff                     @@
##           alont/evalfw-copy2clone     #835      +/-   ##
===========================================================
- Coverage                    92.58%   92.18%   -0.41%
===========================================================
  Files                           89       90       +1
  Lines                        12018    12272     +254
  Branches                     12018    12272     +254
===========================================================
+ Hits                         11127    11313     +186
- Misses                         781      842      +61
- Partials                       110      117       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix Android + CPP build

This allows building the CPP bindings in Android and avoids the Linux/Posix/Android preprocessor macros conflicts.
Ran the C tests.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

LGTM. @nicolasnoble , can you also take a look?

This is ok to test.

So, I'd rather see something in port_platform.h that does the right thing instead.

Basically, changing https://github.com/grpc/grpc/blob/master/include/grpc/impl/codegen/port_platform.h#L158 and https://github.com/grpc/grpc/blob/master/include/grpc/impl/codegen/port_platform.h#L170


Fixed open/closed interval definitions

Fixes #231

Codecov Report

Merging #232 (7a8133a) into main (0cadc67) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           24        24
  Lines          820       820
  Branches       172       172
=========================================
  Hits           820       820

Impacted Files
Coverage Δ

src/phantom/interval.py
100.00% <100.00%> (ø)

src/phantom/predicates/interval.py
100.00% <100.00%> (ø)

src/phantom/sized.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @g-as, thanks for putting in the time to address is!
I'm again pondering the issue of backwards compatibility. I'm now thinking it would make sense to rename the predicate functions and the types to use terms "inclusive" and "exclusive". In my opinion those names are more intuitive, but it would also solve the issue of backwards compatibility.
Just to clarify a bit about my reasoning here, I'll expand a little bit. In releasing a version 1.0, I'm not too worried about removing a function or a class. If someone fails to read the release notes, it's still a change that should be easily discovered by a test suite and probably in 99% of usages this will break at import-time. OTH, renaming closed -> open and vice versa requires a much more disciplined test suite to discover and I'm worried it will sail under the radar into production code before discovered.
What do you think? If you agree it's a good idea, please feel free to go ahead and make those changes on this PR.
Thanks again for the work thus far! 🙏

Agreed that breakage is the best way to avoid behaviour change without the user's knowledge. So renaming with appropriate names, and arguably better/more explicit names is the best way to go.
Changes incoming asap.

Thank you so much for the help, and again for making aware of this 🍰

My pleasure.
Keep up the good work.


(maint) Enable version module if it's not already loaded

The apache version module must be loaded to use the
syntax. On debian 7 and ubuntu 14.04, the module is static, and it is
an error to try to enable it. On ubuntu 12.04, the module is not static,
and must be explicitly enabled, see RE-4465.
This commit enables the version module only if it is not already
loaded.

:+1:

LGTM.

Should we wait for travis and such to finish?

CLA signed by all contributors.


Code coverage via coveralls.io

Take a look at coveralls.io and use it for code coverage if it is suitable enough.

Code coverage will be done via nosetests, coverage.py and either a local runner or travis-ci for now.


Improve Style/FrozenStringLiteralComment message

We've had a bunch of developers confused by the previous message; I think this one is more clear.
Specifically, unless the user knows about this specific cop being enabled, the annotation "Missing frozen string literal comment" on a line like require 'test_helper' doesn't really educate them on how to proceed.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists). (N/A)
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests. (N/A)
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.  (N/A)
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop). (N/A)

Noticed CI was red because of too-long lines. Fixed, sorry!

Thanks! 👍


feat(kubernetes): allow service account auth

allow usage of ServiceAccount for Kubernetes provider.
Summary of changes:

add support for ServiceAccount authentication
remove need to specify data[].property: if not specified it will return the json-encoded value of secret.Data
implement GetAllSecrets()

fetch by tags: use labelSelector to find secrets in the targetNamespace
fetch by name/regexp: list all secrets in targetNamespace and filter by secret.Name

Implements #961 for k8s provider
Fixes #1187

[x] implement service account auth
[x] e2e tests
[x] docs
[x] GetAllSecrets: find by tags/regexp

I implemented e2e tests that verify the behavior within a given namespace using service account authentication. I did some manual testing as well, these manifests :point_down: will helm you to get something started. They match the ones in the docs/.

Here are some manifests for testing purposes
apiVersion: v1
kind: ServiceAccount
metadata:
  name: my-store
  namespace: default
secrets:
- name: my-store-token-hdbt2
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: eso-store-role
  namespace: default
rules:
- apiGroups:
  - ""
  resources:
  - secrets
  verbs:
  - get
  - list
  - watch
- apiGroups:
  - authorization.k8s.io
  resources:
  - selfsubjectaccessreviews
  - selfsubjectrulesreviews
  verbs:
  - create
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: my-store
  namespace: default
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: eso-store-role
subjects:
- kind: ServiceAccount
  name: my-store
  namespace: default
---
apiVersion: v1
data:
  foo: ZXhhbXBsZQ==
kind: Secret
metadata:
  labels:
    mai: foo
  name: foobar
  namespace: default
type: Opaque
---
apiVersion: external-secrets.io/v1beta1
kind: ClusterSecretStore
metadata:
  name: kubernetes
spec:
  provider:
    kubernetes:
      remoteNamespace: default
      server:
        caProvider:
          type: ConfigMap
          namespace: default
          name: kube-root-ca.crt
          key: ca.crt
      auth:
        serviceAccount:
          name: "my-store"
          namespace: "default"
---
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: example-kubernetes
spec:
  refreshInterval: 1m
  secretStoreRef:
    kind: ClusterSecretStore
    name: kubernetes
  target:
    name: secret-to-be-created
    deletionPolicy: Delete
  dataFrom:
  - find:
      name:
        regexp: ".*token.*"
  - find:
      tags:
        mai: "foo"
  - extract:
      key: foobar
      property: foo
  data:
  - secretKey: foo
    remoteRef:
      key: foobar
      property: foo

Hey, this is ready for review, PTAL.

/approve

Sorry, took me a while :)


wip: meeting minutes (2th Oct 2019)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

7775dcd docs: setup meeting minutes (2th Oct 2019)

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

7775dcd docs: setup meeting minutes (2th Oct 2019)
e79d6ab update: meeting minutes office hours (02 oct 2019)

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LGTM label has been added.  Git tree hash: 22ab2906128c27e51ad19938216433e1d94a2d1a

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


add libcheck port

Hi
Just a small PR to add libcheck port.
Thanks

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: simon-p-r sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR! I adjusted the port to use our new functions vcpkg_from_github() and vcpkg_fixup_cmake_targets() :)


test coverage

Here is the output from running unit tests with coverage report. This code base has all unit tests that pass.

Looks good to me.  I created an issue to structure our unit tests going forward.


Project Information

Updated readme file and added information about the project and how to get started contributing to it

Fixes Issue  #35

Changes proposed
Explained about project goal
addition to project information in the readme file so first timers can go to the page repos and clone with ease

[x] - Readme.md;

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the ReadmeFile.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

You're welcome 😇


Clarify the handling of minor versions of a protocol

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>This is in response to an interop issue between Aries Framework JavaScript and Aries Cloud Agent Python, where ACA-Py is not properly handling the messages sent.  The Aca-Py issue is here.

In last WG call I was surprised that the minimum minor version an agent can support for a given protocol could be different from 0, as I had understood (in concordance with what you said in the ACA-Py issue referenced) that minor versions of a protocol could only add some optional features in such a way that there would always be a way to negotiate communication for two agents that support the same major version of it (e.g. an agent that supports OOB 1.1 and another that only supports OOB 1.0).
Reading a bit more the same RFC, I found a few sentences in Recipient Rules that I think are the reason of my confusion:

"For major version >= 1, recipients should also accept messages that differ only in that the message's minor version is earlier than their own preference. "
"Message types that differ in only in minor version are guaranteed to be compatible for the feature set of the earlier version. "

So this gives me the idea that if I support OOB 1.4, it should be enough to send that single version when disclosing my features, at it implicitly means that I accept OOB 1.0, 1.1, 1.2, 1.3 and 1.4 messages (provided the protocol version history has followed the convention stated in this RFC). If the other agent implemented OOB 1.7, it will simply expect from me to send 1.4 messages and should be fine with that (and I'll accept its 1.7 messages as well, ignoring the features I don't support).
What happens if an agent is willing to do an interaction using a specific version of the protocol? For instance, suppose that OOB 1.4 adds an optional field called "imageUrl" and that particular field is very important for it. In such case, if it interacts with another agent that only supports 1.3,  it would like to abandon the flow. Is that possible or it's something forbidden? As the first sentence I quoted uses the term 'should', it makes me think that such behaviour is not allowed.

Discussed on the Aries Working Group Call 2022.10.19-- ready to merge, needs an approval, no one against merging.
Can we please get a editor/maintainer to approve this PR?

@TelegramSam -- can we have a brief discussion about this one on the Aries Working Group call tomorrow? There is one more topic to talk about with it.


Remove ToastPresentation usage and use toaster to display toasts

Added iTwinUI toaster to display the toasts.
Returned old implementation on message components to get rid of ToastPresentation and marked them as deprecated.
Added new function to register ref to animate iTwinUI toasts to.
Added few deprecated tags as suggestions to some of managers. If we agree to all these deprecations (there might be more), I'd like to also add text in jsdoc about using toaster to display toasts where relevant.

Vykintas, this does not hook the toaster into the MessageManager -- MessageManager.outputMessage does not open any toasts. Is that still in progress or just broken?

Vykintas, this does not hook the toaster into the MessageManager -- MessageManager.outputMessage does not open any toasts. Is that still in progress or just broken?

Where have you found it's broken?
outputMessage has this 'ifs' carousel, which changes types or shows some other messages:

and then at the end it is calling 'addMessagewhich has thetoaster` hooked up:

Unless I misunderstood here something..?

Where have you found it's broken?

I pulled and built the branch and ran ui-test-app. The messages get logged in the message center, but no toast message show up, except activity messages.

Good progress, that should cover most cases where toasts/messages are displayed.
As discussed, we need to ensure that ActivityMessage (and other message components) are not used internally (replaced with itwinui toaster for UI consistency). I.e. we probably want to use itwinui toaster in: ActivityMessagePopup, StatusMessagesContainer.
Also, specifically for ActivityMessage we need a component with equivalent layout that's rendered via the itwinui toaster.

Good progress, that should cover most cases where toasts/messages are displayed.
As discussed, we need to ensure that ActivityMessage (and other message components) are not used internally (replaced with itwinui toaster for UI consistency). I.e. we probably want to use itwinui toaster in: ActivityMessagePopup, StatusMessagesContainer.
Also, specifically for ActivityMessage we need a component with equivalent layout that's rendered via the itwinui toaster.

@NancyMcCallB @GerardasB Would you mind checking again? I have fully replaced all toasts and added new custom activity message.
In component examples toasts are not visible, because iui-toast-wrapper is having too low z-index (edit that through console to see them).
THere is already new iTwinUI version with z-index fix, I just need to update here. Will creae a separate PR for this, I think.

git merge master, rush clean, rush purge, rush update, rush build, rush extract-api

This helped! Thanks!
All of this should be in documentation, IMO.

I have updated itwinui version, so now issue with z-index is fixed and messages are visible in components examples too.


Bugfix: SetBody empty array

If a response body is an empty array, it should be serialized to JSON as an empty array as well.

Coverage decreased (-1.1%) to 97.717% when pulling 2764b4a3d1651db1a0e02c14c2efaf07a545f3c4 on imbusy:master into 81dd588b317aeebab2282bf58ce83c34258cb151 on SEEK-Jobs:master.

Coverage decreased (-1.1%) to 97.717% when pulling 357650f3c253951bf1d1d9cda8cd58814c3b8fd4 on imbusy:master into 81dd588b317aeebab2282bf58ce83c34258cb151 on SEEK-Jobs:master.

Coverage decreased (-1.1%) to 97.717% when pulling a2e716bb2edfa86610708055c50c90b0f53c0de8 on imbusy:master into 81dd588b317aeebab2282bf58ce83c34258cb151 on SEEK-Jobs:master.

Closing this since I will be forking this code completely to modify the producer API.


Fix libmysql on arm64-osx (compiler checks)

FIxes #35876

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

8.0.34#1 is declared with 20cb416a4659c1f3d6cbf08fef69ebf51eb8e15c, but the local port has a different SHA 167e024cc411a99094f62e58913991caca22237f.
Please update the port's version fields and then run:
vcpkg x-add-version libmysql --overwrite-version
git add .
git commit -m "Update version database"

to add the new version.

@Cheney-W done, thanks. The 8.0.34#1 was not released yet. I updated the database during the checks in the previous commit, but the hash diverged somehow.


Redis: Whitelist more commands (and arguments) for metadata

Follow-up to #34.
This will give us slightly more useful metadata in Redis spans in our application. I compiled the list of commands to add by grepping the Sidekiq source code. 😉
I also added the capability to mark all arguments of a command as safe with an asterisk, for use with trivial commands or those with variable lists of arguments that are all safe.

Very nice, thanks!

Released in v1.12.1. 🎉


[Feature request] Get not labeled pull requests

Hi!
I want to use the api to take all pull requests with no labels.
As I see there is no such possibility at the moment.
In the github UI there is such functionality.
Maybe 0 can be interpreted as no label and this will be used to create filter for the sql query.
I am not very familiar with the frontend part so I don't have idea how would be implemented this part.
Thanks

We need to join two tables. And you could also interate all the pull quests and filter yourself.


Create separate files testing-related utils and non-testing utils

`types/utils.go` seems like a wrong place if `GetRandomValidatorSet` and `GetRandomValidatorSetWithPrivKey` are used for testing purpose?

Originally posted by @gupadhyaya in https://github.com/rollkit/rollkit/pull/1301#discussion_r1395287406

Hi sir @Manav-Aggarwal, can I take this issue?


tags system? different Search system?

I want to create a better tags system, or a better searching system for content posted/uploaded to the server, and eventually make it more fuzzy.
for tags:
the first idea i have for tags is to store them as an array with a delimiter (eg, tag1|tag2|tag3)
for search:
ive done this before and it seemed to work well, a column in the database called "search" that just takes all other columns and puts the text in 1, so i can search for a song, or just an artist or both and actually get the song, songs from that artist, or that exact song with some varients to the song if there are several files that somehow match the parameters (live version/album version)

I do want more ideas, i dont think either of these are the best way of doing either of them, just the first ideas that came to mind.
Search would also include tags, and the examples used, wouldnt be specific to any form of media, tags for the music example in search could be genre.
And search could be book title + author + any other datapoints included in that database entry


feat: add readthedocs javascript search

This PR adds a custom readthedocs search extension using javascript. I found the default doxygen search is quite terrible, and doesn't seem to actually search any markdown files (or barely searches them)... which is not great when you have user documentation.
I am working on this for my own projects (here: https://github.com/LizardByte/doxyconfig/pull/4), and figured I could share it back here for others to benefit from. A live preview is available here: https://lizardbyte--4.org.readthedocs.build/projects/doxyconfig/4/search.html?query=doxygen ... once merged it will be available here: https://docs.lizardbyte.dev/projects/doxyconfig/latest/search.html?query=doxygen
This is what it looks like.

Old version

The styling is somewhat based on Furo, this is how that looks in one of my projects.

TODO:

[x] improve the appearance/layout of the anchor urls
[ ] possibly add live searching

I've marked this as draft, as I still have a few items to improve... but feel free to review it if you want. I'm open to suggestions before I mark it ready for review.

A user of mine reported there is an issue with the search results page on mobile. I don't think it's anything related to my code, but possibly a doxygen bug?
When the user clicks the search bar, the keyboard pops up, but then immediately closes... and there is no way to enter a search term. I know doxygen generates search pages slightly differently depending on the variable search config options. Seems to work perfectly fine on desktop though.

When starting the search with the readthedocs addon widget at the bottom right, a really nice popover with live search is opened. IMO that's a really nice user experience! Do you think it would be possible to use the searchbar in the upper right just as a link that opens this popover?

I'm not sure I fully understand the ask, but if you're just asking if the live search will work (search as you type)... it's possible, I just don't know how to implement it.


Unexpected type error when extending similar interfaces with optional fields

TypeScript Version:  3.1.1 & 3.2.0-dev.20180929

Search Terms:
cannot simultaneously extend types
Code
(you might appreciate this example, as the actual use case was using the typescript programmatic API)
import * as ts from 'typescript'
interface BaseHost extends ts.ParseConfigHost, ts.FormatDiagnosticsHost, ts.ModuleResolutionHost {}

Expected behavior:
No error.
Actual behavior:
[ts]
Interface 'BaseHost' cannot simultaneously extend types 'FormatDiagnosticsHost' and 'ModuleResolutionHost'.
  Named property 'getCurrentDirectory' of types 'FormatDiagnosticsHost' and 'ModuleResolutionHost' are not identical.

That's because getCurrentDirectory is optional on ModuleResolutionHost, but not the other hosts.
Is there a reason to not make the field in question required on BaseHost instead of throwing an error?
Type-wise, would this not yield correct behavior? Meaning any BaseHost is indeed compatible as the three TypeScript interfaces it extends.
Playground Link:
http://www.typescriptlang.org/play/#src=interface A {
    someField%3A string
}

interface B {
    someField%3F%3A string
}

interface C extends A%2C B {

}

Playground example is a much simpler use case.
Related Issues:
https://github.com/Microsoft/TypeScript/issues/16936 - one could say this is a subset of that suggestion. the scope here is just optional fields

I should also note that using:
type BaseHost = ts.ParseConfigHost & ts.FormatDiagnosticsHost & ts.ModuleResolutionHost

simply destroyed any type inference for object method parameters:
function someFunc(): BaseHost {
    return {
        ...,
        readFile(path) {}
    }
}

(inferred type of path is lost. no longer string by default)

Going from the example
interface A {
    someField: string
}

interface B {
    someField?: string
}

interface C extends A, B {

}

Is this code legal?
const c: C = { someField: "" };
c.someField = undefined;

Argument 1: It has to be, because that's a legal operation on a B and C claims to be substitutable for B
Argument 2: It can't be, because A claims to always have a non-undefined someField, and C violates that

There's not a principled way to choose one over the other, so we defer the question to the C author to resolve the dispute.

Never mind, I realized I can simply:
interface IBaseHost extends ts.ParseConfigHost, ts.FormatDiagnosticsHost, ts.ModuleResolutionHost {
    getCurrentDirectory(): string
}

and I also guess that's what you meant by saying the decision is deferred to me. :+1:
Taking your original explanation into consideration, I'm no longer sure how this is any more consistent. :) Because the following now passes type checking, and the author of run might not be
declare const aaa: BaseHost
function run(host: ts.ModuleResolutionHost) {
    host.getCurrentDirectory = undefined
}
run(aaa)

Closing, as my original issue is mostly solved. Although I ended up seeing more holes in the system :)

Thanks for the kind explanation again. I guess you guys get these kind of tickets a lot from people like me not always seeing the delicate nature between usability and safety of the type system. The use case of run() made me question myself again, thinking this might be a usability intended decision.

Never mind, I realized I can simply:

I really should have included that in my example!


feature: 流程服务国际化方案

Codecov Report

Merging #1105 (19a009d) into v2.6.x_develop (9a34e74) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@                Coverage Diff                 @@
##           v2.6.x_develop    #1105      +/-   ##
==================================================
- Coverage           38.73%   38.72%   -0.01%
==================================================
  Files                 290      290
  Lines               19316    19322       +6
==================================================
+ Hits                 7482     7483       +1
- Misses              11834    11839       +5

Impacted Files
Coverage Δ

itsm/ticket/models/ticket.py
20.58% <0.00%> (-0.03%)
:arrow_down:

itsm/ticket/serializers/field.py
63.93% <22.22%> (-1.59%)
:arrow_down:


Add btfs

Mmm... The CI checks have failed, but it doesn't seem btfs' formula's fault

Sorry for the delay here! If you rebase this against an up-to-date master branch it should pass this time, hopefully.

Done, failed again, still not btfs's fault

Merged in https://github.com/Homebrew/homebrew-fuse/commit/5f654d3ec0bec90d4cc8c7c8b601429b70b32cab. Thank you for your contribution to Homebrew @cprecioso; we appreciate it! :smiley_cat:


Desktop Release 1.8.10 refering to 1.7.20 and no new features available

This issue pertains to the following package(s):

[ ] GraphQL Playground - Electron App
[ ] GraphQL Playground HTML
[x] GraphQL Playground
[ ] GraphQL Playground Express Middleware
[ ] GraphQL Playground Hapi Middleware
[ ] GraphQL Playground Koa Middleware
[ ] GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?
Linux  4.9.0-9-amd64 #1 SMP Debian 4.9.168-1+deb9u3 (2019-06-16) x86_64 GNU/Linux
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.8.10
What is the expected behavior?
I would expect to have the new version 1.8.10 with all new features
What is the actual behavior?
I downloaded the release 1.8.10 as snap, appimage and .deb file and installed everything properly.
I don't see any new features, like sharing and workspaces and I always see the version 1.7.20 in the settings
What steps may we take to reproduce the behavior?
Please provide a gif or image of the issue for a quicker response/fix.

Hi @ckruczek, Would you tell me how you've checked which version of GraphQL Playground Electron have been installed? I guess you've installed the version of 1.8.10 of GraphQL Playground Electron, which uses the version of 1.7.20 of GraphQL Playground React as a dependency.

Sure. I clicked on 'Download Desktop app' in your readme file and downloaded the latest 1.8.10. Then I clicked on 'settings' in the app and found out it's 1.7.20. If this number is refering the depedency then this is kind of confusing. Anyway I am missing all the features like 'share playground' and 'workspaces'. Maybe these are just features for other versions of this app?

@ckruczek The version showed in the settings is the one of GraphQL Playground React. Currently, you cannot use the feature of sharing playground with GraphQL Playground Electron. On the other hand, you can use the feature of workspaces although you need to use .graphqlconfig.

Ok thanks for your quick answer. Now it makes sense.
Maybe I missed a list or it doesn't exist, but is there anything I can check what features are implemented in which product? Currently its kind of confusing to find it.

@ckruczek There isn't a list at the moment that tells you what features are implemented in each product. We need to update the ReadMe so that we figure it out easily.


Fix Java toolchain requirement.

We don't need (or want) JDK 8, we just need the output to be compatible with JRE 8 (though even that's debatable and we should figure out what a reasonable minimum Java version is these days).
Fixes https://github.com/google/prefab/issues/166.

Ugh, I had pulled before doing this but apparently pulled from the wrong remote because I never really set up this project. Will update later.

From something newer than the first public commit as a base (ugh), the fix is actually a lot simpler. The problem was just mistaking the Java toolchain version for the bytecode version.


Chore/upgrade chai

Upgrade chai to v5 and switch to esm output. This PR superceeds #55
This was a pretty horrible upgrade but it all boilds down to chai (and in the future other dependencies) no longer supporting commonjs modules. The logic of this PR is therefore something like:

chai no longer supports commonjs modules so we need to change the module type by adding "type": "module" to package.json
we also have to change the tsconfig to output in native module format so use ESNext
node when importing native esm modules needs to refer to an exact file path (no directories or names without extensions). Because tsc won't mangle import names this necessitates adding .js extensions to all local imports (yes typescript understands what this means)
When executing tests with mocha or using nodemon we need to now tell it how to load modules. Usually this involves adding --loader ts-node/esm to any node invocations but this now generates a warning in node asking us to switch to the vastly more horrible --import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'. Reading arround this seems to be where node is heading so 🤦♂
Because we're using native node import rather than require at runtime we can no longer load json without generating an experimental warning so I've changed that to read the swagger file manually

hm... as far as I remember this was a bit weird that we need to import from build rather than .ts and specify index file

Yes I need to have another look at the knex commands. I think these are the only places I now have issues

https://github.com/knex/knex/issues/4793 does not look good

I've managed to fix this using:
{
  "db:cmd": "node --import='data:text/javascript,import { register } from \"node:module\"; import { pathToFileURL } from \"node:url\"; register(\"ts-node/esm\", pathToFileURL(\"./\"));' ./node_modules/.bin/knex",
  "db:migrate": "npm run db:cmd -- migrate:latest --knexfile src/lib/db/knexfile.ts",
  "db:rollback": "npm run db:cmd -- migrate:rollback --knexfile src/lib/db/knexfile.ts"
}

Broadly speaking I dislike all the horribleness especially needing to wrap all node commands in essentially:
--import='data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("ts-node/esm", pathToFileURL("./"));'

This is basically caused by ts-node being massively behind the curve https://github.com/TypeStrong/ts-node/issues/1997. As they don't seem to be responding it might be worth looking for a ts-node alternative and the two best options I've seen are:

tsx https://github.com/privatenumber/tsx
tsimp https://github.com/tapjs/tsimp

I'm not sure I want to do this switch right now, but we can consider it

closing in favour of #66


[WFLY-7027] - add dep on javax.api to common-beans'

https://issues.jboss.org/browse/WFLY-7027

Needs a 7.x variant.

Can't edit labels :8ball:


add post-norm configuration with deepnet init

https://arxiv.org/abs/2203.00555

just need the init(retro) function now https://github.com/lucidrains/RETRO-pytorch/commit/1c57013fd377d01781f35321f4825f763ca25255

made the residual scaling customizable because with the cross attention in RETRO being every 3rd layer, it may end up being different than what is in the paper

done

Hey @lucidrains,
I'm trying to replicate RETRO in Jax, and it isn't going well.
How crucial was the deepnet init to convergence?
Because right now, my model can't even solve a very simple task.
(The task is reversing a string that is encrypted using a simple cypher, where the cypher is given as the neighbor tokens, so a model without cca can't solve it).


Couldn't build the Android app on CodeMagic

Issue
Not able to build the app through CodeMagic. It fails on Android stage.
Expected results:
Needs the app to be built without any error.

Logs

== Building for Android ==

> /usr/local/bin/flutter build appbundle --release -t lib/main_prod.dart --build-name=1.2.188 --build-number=188 --flavor prod
Running Gradle task 'bundleProdRelease'...
Note: /Users/builder/programs/flutter/.pub-cache/hosted/pub.dartlang.org/cloud_firestore-0.13.6/android/src/main/java/io/flutter/plugins/firebase/cloudfirestore/CloudFirestorePlugin.java uses unchecked or unsafe operations.

Note: Recompile with -Xlint:unchecked for details.

Note: /Users/builder/programs/flutter/.pub-cache/hosted/pub.dartlang.org/firebase_remote_config-0.3.1/android/src/main/java/io/flutter/plugins/firebase/firebaseremoteconfig/MethodCallHandlerImpl.java uses or overrides a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

Note: /Users/builder/programs/flutter/.pub-cache/hosted/pub.dartlang.org/in_app_purchase-0.3.4/android/src/main/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java uses unchecked or unsafe operations.

Note: Recompile with -Xlint:unchecked for details.

Note: /Users/builder/programs/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.10/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java uses or overrides a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

Note: /Users/builder/programs/flutter/.pub-cache/hosted/pub.dartlang.org/video_player-0.10.11+1/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java uses or overrides a deprecated API.

Note: Recompile with -Xlint:deprecation for details.

AAPT2 aapt2-3.5.3-5435860-osx Daemon #1: Unexpected error output: Done

FAILURE: Build failed with an exception.

* What went wrong:

Execution failed for task ':app:mergeProdReleaseResources'.

> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade

   > AAPT2 aapt2-3.5.3-5435860-osx Daemon #1: Compile '/Users/builder/clone/android/app/src/main/res/drawable-xxxhdpi/splash.png' timed out, attempting to stop daemon.

     This should not happen under normal circumstances, please file an issue if it does.

* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9m 59s
Running Gradle task 'bundleProdRelease'...                        601.4s (!)
The built failed likely due to AndroidX incompatibilities in a plugin. The tool is about to try using Jetfier to solve the incompatibility.
Building plugin apple_sign_in...
Running Gradle task 'assembleAarRelease'...                        45.0s
✓ Built build/app/outputs/repo.
Building plugin cloud_firestore...
Running Gradle task 'assembleAarRelease'...
The plugin cloud_firestore could not be built due to the issue above.

Build failed :|
Failed to build for Android

sai@Sais-MacBook-Pro% flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.0, on macOS 11.0 20A5374i, locale en-IN)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
[✓] Android Studio (version 3.6)
[✓] Connected device (1 available)

• No issues found!

Hi @saigkl
This is related to Codemagic CI/CD
I recommend you to ask for support directly on their Slack
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments and I will reopen it.
Thank you


flake documentai quickstart ProcessDocument internal error

98/99 Test #736: documentai_quickstart ..............***Failed    3.36 sec
CMake Error at /workspace/cmake/quickstart-runner.cmake:90 (message):
  Non-zero exit status (1) running
  /workspace/cmake-out/google/cloud/documentai/documentai_quickstart

  google::cloud::Status thrown: INTERNAL: Error in non-idempotent operation
  ProcessDocument: Internal error encountered.

https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/746667a1f8ac00c80ac6caa4dfeda9317086c736/fedora-37-cmake-quickstart-production/log-7de67bf7-988b-4064-9b95-612edf77b3e4.txt

Not exactly a dup, but can be fixed with the ideas in #10325.


Add support for ACL

Hello,
I want to use this library as part of our codebase internally, however while looking at it i noticed there is no ACL support. Doing a bit more documentation i noticed that off the 3 supported stores only ETCD didn't support the usage of ACL, however they seem to be integrating this feature in 2.1.  Internally we use zookeeper and we rely heavily on ACL's to secure access to sensible keys.
Are you considering adding support anytime soon?
Thank you,
Cosmin

Hi @cosminilie, Yes this is definitely something we'd consider to include, although we don't know when this will happen. We are looking closely to the changes made to etcd and their new API v3 but ACLs does not seem to be part of the Go client yet (ACLs are only supported for Consul and Zookeeper Go clients). Hopefully we'll see evolution on this side in the next few weeks, months.

The new etcd client now includes support for ACLs, so this might be included after migrating to the new client (tracked by #53).

Great, looking forward to this.

+1

Digging this one up; it's been at least a year since this was last touched. Any updates?

+1 Our consul cluster is protected with ACL so we can't use this lib

Bump

@abronan I wanted to check on the status of this. I see that etcd migration you did (#53) was a success and completed in October 2015 (#75). I don't claim deep familiarity with etcd but I know that it has supported users and roles since etcd 2.1 (link to etcd documentation).
This work to add users and roles looks to part of issues: coreos/etcd#2242, coreos/etcd#2384, and coreos/etcd#2654.
Is the current user / role system of etcd satisfactory to do an ACL overlay in libkv or are things still missing?
Thanks,
code-ape

+1