fix: render other md log formats("gfm", "commonmark", "markua")

Updates

updated location of temporary files for md
updated name of log to end in <filename>_log_<md type>.md
used options for create_outputs format argument

Steps
library(whirl)
options(whirl.out_formats = c("html", "gfm", "commonmark", "markua"))
options::opt("out_formats", env = "whirl")
result <- run("inst/examples/simple/prg1.R")

Expected files output at the same location as code

Follow-up - potential tickets/issues

Do we want to track this files in the summary html? and/or
Do we need different formats for the summary?

I just tried the branch - and it works good :)
For the two questions:

We don't track the html log today, so I don't think we need to add them
I am in doubt. In a way it would be nice, but not sure they will be useful. But should probably be controlled in the argument to run() anyway, and not through an option.


OffsetDateTimeTypeHandler or ZonedDateTimeTypeHandler loses time zone information

Hello,
I would assume that people using your implementation of a "ZonedDateTimeTypeHandler" expect it to convert dates with timezone information in their database to EQUIVALENT Java objects, which it does not (really).
It merely converts them to objects that, technically point to the same moment in time, however with the zone or offset information completely lost. All the ZonedDateTime or OffsetDateTime objects that the handlers create always refer to the system default time zone, never to the one of the actual entry!
Instead of only using the getTimestamp() method of the ResultSet (which can only return a java.sql.Timestamp with the zone information already lost) it would be cool if you could at least offer an alternative implementation that tries to retain the offset/timezone information by using the getString() method instead.
An example for the OffsetDateTimeTypeHandler could be:
@Override
public OffsetDateTime getNullableResult(ResultSet rs, String columnName) throws SQLException {
  String dateString = rs.getString(columnName)
  if(dateString == null) {
    return null;
  }
  OffsetDateTime offsetDateTime = OffsetDateTime.parse(dateString, DateTimeFormatter.ISO_OFFSET_DATE_TIME);
  return offsetDateTime;
}

I found the idea here. Of course, this would assume that the String representation of the databases for those "timestamp with time zone" datatypes comply with the ISO format. Instead of guessing users could hand over the format-mask to a method that converts to the String representation of that column in the select statement. E.g. in Oracle that could be:
SELECT to_char(table0.MY_DATE_COLUMN, 'YYYY-MM-DD"T"HH24:MI:SSFFTZH:TZM') as MY_DATE_COLUMN). Such a remark could be added in the class documentation of the type handler, for example.
Even if you do not want to add such handlers, you should at least mention in your documentation (class documentation and README.MD) that the handlers you provide do NOT retain the information of the original timezone or the original offset but do always convert them to the system's default.
Cheers!
Note
This issue moved from mybatis/typehandlers-jsr310#39.

I agree. These cases are not well covered at the moment. Not sure if TypeHandlers support parameters, but I like the idea you proposed.
JDBC 4.2 (Java 8 only) does support TIME_WITH_TIMEZONE and TIMESTAMP_WITH_TIMEZONE JDBC Types. It maps them to java.time.OffsetTime and java.time.OffsetDateTime. Maybe that is something to look into as well.
There is no support for java.time.ZonedDateTime which is unfortunate but reasonable. Timezones can change (dropping daylight savings time for example) explicit offsets do not. Maybe it was a bad idea to provide a type handler for java.time.ZonedDateTime to begin with.
AFAIK if you need to support clients in different timezones there is no way around storing all time related data types in UTC and have the clients do the proper conversion to their local time.

Sorry for the late reply but here is some feedback from me:
I think the OffsetDateTimeTypeHandler and the ZonedDateTimeTypeHandler are definitely broken. They silently will map your TIMESTAMP result to a OffsetDateTime object but simply apply the offset of the current system's default. That might completely change the data and there is not even a warning about this!!
Also, the current JUnit test "covering" this type handler does not have a fixed date that is being converted but simply uses the current date (and time zone) from the computer that is executing the JUnit test. Of course it will work then!
The test input should be completely fixed (like a fixed point in time) and not being machine-dependent. If we changed this, the test would fail.
So at the very least we should:

update the documentation of these type handlers to explicitly state its shortcomings and "warn" the users any information about time zone offsets is lost if they use this type handler.
provide alternative implementations that do retain the offset information and perhaps not put them in the TypeHandlerRegistry but let the users chose them explicitly and maybe replace the default type handler later.

Here are the two alternative implementations I would suggest:

The one that makes use of JDBC 4.2 and uses getObject() / setObject() as you suggested it.
The one that uses the "workaround" of formatting the column to a ISO String first, then retrieving it via getString() and parsing it eventually in the type handler back to a OffsetDateTime object. I am currently using that in production and it works fine.

What do you think? I can create a pull request for the second one and maybe you for the first one?

I agree with OffsetDateTimeTypeHandler and the ZonedDateTimeTypeHandler being broken.
In my opinion the best approach in storing both Temporals as String columns in the database: most portable and straight forward. In the TypeHandler one should use ZonedDateTime.parse() and OffsetDateTime.parse to convert from the stored characters representation to the Temporal object.
YearMonthTypeHandler use this strategy, too.
Since this change could break applications it is probably a fix for a MyBatis 3.5.x release.

Currently working w/h MSSQL 2017 here and I can confirm that the JDBC 4.2 getObject() / setObject() implementation works fine. In fact, I'm using a custom handler to solve the timezones problem discussed here.
I tend to agree with @Treppenhouse's comment and I'd like to add that IMHO the OffsetDateTimeTypeHandler  and ZonedDateTimeTypeHandler should be revised to work with getObject() / setObject(). The old handler implementations should be renamed to something with a suffix, like Legacy, and the additional String columns implementation could be added as additional handlers.
I know this could be a breaking change, but it seems to me the most logical. Again, that being said as a humble user opinion.

Just for reference. New JDBC 4.2 supported types as documented in:

PostgreSQL
MSSQL
MySQL

It might be faster to proceed step by step. :)

OffsetDateTimeTypeHandler should be rewritten using getObject() / setObject().

Reading the comments, you all agreed on this one, I believe.
@raupachz , Could you rebase the branch and send it as a PR, please?

Hi @harawata oh wow I almost forgot about this branch. Yes, I will rebase and send a PR. Thanks!

@raupachz ,
Thank you!
I'll review it as soon as I find the time.
@petarov ,
Could you post your OffsetDateTimeTypeHandler to Gist or somewhere?
I'm testing it with a simple JDBC app and although setObject() seems to be working, getObject(columnIndex, OffsetDateTime.class) results in an error.
Exception in thread "main" com.microsoft.sqlserver.jdbc.SQLServerException: The conversion to class java.time.OffsetDateTime is unsupported.
        at com.microsoft.sqlserver.jdbc@7.1.1.jre10-preview/com.microsoft.sqlserver.jdbc.SQLServerResultSet.getObject(SQLServerResultSet.java:2428)

My environment:

SQL Server 2017 Express Edition (14.00.1000)
mssql-jdbc 7.1.1.jre10-preview
Column datatype is DATETIMEOFFSET
openjdk version "11" 2018-09-25

@harawata @raupachz No need to provide a gist, because the exception you posted is totally real! I need to apologise for my misleading comment above. I checked my logs yesterday and I did see the same exception, but I only got to review what's going on today.
So as it turns out, MSSQL JDBC did in fact implement the setObject() call for OffsetDateTime, but they did not implement anything like that for getObject(). That returns an microsoft.sql.DateTimeOffset type instead, which I had to convert to java.time.OffsetDateTime in my custom TypeHandler. 😞
Needless to say, this defeats the purpose of a uniform setObject() / getObject() TimeTypeHandler implementation. I think this brings the topic back to @raupachz's comment about Temporals as String columns.

For anyone that is more interested in the topic this is what I found.

@petarov Thanks for the detailed investigation! I always thought with JDBC 4.2 this should be easily done. Guess, not. Maybe, we better close the PR. Doesn't make sense to add a feature if only half of the db vendors implement the spec.
Side note: I checked the source of MariaDB Connector/J they implement getObject / setObject.

@petarov ,
Thank you for the clarification!
I have added my test result on #1368 .
PostgreSQL does support these methods, but the value is stored in UTC, it seems (i.e. offset is lost).
And I'm pretty sure mssql-jdbc will support ResultSet#getObject() in the future.
@raupachz ,
Good catch! I have just checked mariadb and it seems to be working with both 'DATETIME' and 'TIMESTAMP' columns.
I'm going to test PreparedStatement#setString() and ResultSet#getString() next.

but you guys think that OffsetDateTimeTypeHandler should map the object to text columns?

I personally see this as a separate handler, something like OffsetDateTimeTypeAsStringHandler. I think the OffsetDateTimeTypeHandler should either use getObject() / setObject() as you suggest or be deprecated in order to not mislead developers that timezones save would always work.
I'm also not sure what's to be done with ZonedDateTimeTypeHandler. From what I've read so far java.time.ZoneDateTime isn't supported at all in JDBC (except with MariaDB's Connector, are there others?), but maybe it's possible to convert that to java.time.OffsetDateTime and then still use getObject() / setObject(). 🤔
Btw, big thanks for your test results in #1368. This is awesome! 🍺

Adding another type handler that maps OffsetDateTime to string columns sounds OK.
I would wait until someone actually requests it, though.
Please let me know if any of you is already in need of such type handler.
This is just my personal view, but type handlers for these classes (i.e. OffsetDateTime, OffsetTime and ZonedDateTime) are useful only when the database supports the corresponding data types (in that sense, they are similar to SqlXmlTypeHandler ( #1221 ) which works only with a DB that supports SQLXML data type).
And if/when these data types are supported, setObject() / getObject() are the standard (or de-facto standard?) way to access them with the current JDBC.
By this logic, I think it's right to use setObject()/getObject() in ZonedDateTimeTypeHandler or OffsetTimeTypeHandler even if they work with few (or no) DBs right now.
As this is just my personal opinion and may be impractical, I would like to wait for other committers' comment before we proceed.
Good thing about type handler is that it's fairly easy to write/use a custom type handler. :)

Btw, big thanks for your test results in #1368. This is awesome! 🍺

You're very welcome. I learned a lot from this discussion, too. =)
FYI, I noticed that there is a bug in mssql-jdbc's PreparedStatement#setObject() that occurs when the passed OffsetDateTime has a different time zone than the default one and sent a fix.
I also sent another PR that adds OffsetDateTime support to ResultSet#getObject().
Not sure when or if they're accepted, though.

@harawata Nice! I hope they pull it in. It would save me from using a custom handler. It's currently all over my mappers. 😉
Btw, this was my routine to convert from dto to odt.
	private OffsetDateTime toOffsetDateTime(DateTimeOffset dto) {
		if (dto != null) {
			return OffsetDateTime.ofInstant(dto.getTimestamp().toInstant(),
			        ZoneOffset.ofHours(dto.getMinutesOffset() / 60));
		}
		return null;
	}

That's my plan B if they don't like me modifying DateTimeOffset.
ZoneOffset.ofHoursMinutes(dto.getMinutesOffset()) might be safer as there seems to be a timezone like '+08:45' in the world. 🌎

It's currently all over my mappers.

It might not be what you meant, but instead of specifying typeHandler in each mapper, you can register the custom type handler in the global config.

I just upgraded to mybatis 3.5.0 and the ZonedDateTimeTypeHandler is not working.
As a mater of fact, with the previous verion, 3.4.6, I include the jar
org.mybatis:mybatis-typehandlers-jsr310
and it has been working great. Somehow, my code got rearranged, and got the typehandler class from mybatis .jar instead of from the mybatis-typehandlers .jar and even though the java package is the same, the code is different.
The mybatis-typehandlers  works fine, mybatis 5.0 typehandler does not work.


Fix disposing a modal after hiding error

Description
Checking if the focus property has been set before reading it.
Motivation & Context
When you dispose a modal after hiding it, it throws an error.
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

Related issues
Fixes #37409.

Thank you @ernestob for this effort. As I wrote at #37409 there is not an issue, instead is the default way all the js components work. They provide the events in order to be able to act on them. Maybe you could provide a promise on each async method, but this is another discussion


Add vscode launch setting for bikes service

Looks good to me! Please let me know once you double-validated the behavior, and I'll merge the PR. :)


Remove console log

Removes unnecessary console log

Thanks @geriux for the PR! I'll get it merged and released.


Can not push images ,  deploy harbor in kubernetes (insecureRegistry)

UI log
2018-04-03T12:33:20Z [DEBUG] [security.go:153]: got user information via basic auth
2018-04-03T12:33:20Z [DEBUG] [user.go:304]: Check if user admin is super user
2018-04-03T12:33:20Z [DEBUG] [authenticator.go:96]: Current AUTH_MODE is db_auth
2018-04-03T12:33:20Z [DEBUG] [security.go:214]: using local database project manager
2018-04-03T12:33:20Z [DEBUG] [security.go:216]: creating local database security context...
2018-04-03T12:33:20Z [DEBUG] [token.go:35]: URL for token request: /service/token?account=admin&client_id=docker&offline_token=true&service=harbor-registry
2018-04-03T12:33:20Z [DEBUG] [creator.go:200]: scopes: []
2018-04-03T12:33:20Z [DEBUG] [authutils.go:47]: scopes: []
2018-04-03T13:12:46Z [DEBUG] [security.go:153]: got user information via basic auth
[MySQL] 2018/04/03 13:12:47 packets.go:32: EOF
[MySQL] 2018/04/03 13:12:47 packets.go:118: write tcp <IP_ADDRESS>:41494-><IP_ADDRESS>:3306: write: broken pipe
[MySQL] 2018/04/03 13:12:47 packets.go:32: EOF
[MySQL] 2018/04/03 13:12:47 packets.go:118: write tcp <IP_ADDRESS>:41496-><IP_ADDRESS>:3306: write: broken pipe
2018-04-03T13:12:47Z [DEBUG] [user.go:304]: Check if user admin is super user
2018-04-03T13:12:47Z [DEBUG] [authenticator.go:96]: Current AUTH_MODE is db_auth
2018-04-03T13:12:47Z [DEBUG] [security.go:214]: using local database project manager
2018-04-03T13:12:47Z [DEBUG] [security.go:216]: creating local database security context...
2018-04-03T13:12:47Z [DEBUG] [token.go:35]: URL for token request: /service/token?account=admin&client_id=docker&offline_token=true&service=harbor-registry
2018-04-03T13:12:47Z [DEBUG] [creator.go:200]: scopes: []
2018-04-03T13:12:47Z [DEBUG] [authutils.go:47]: scopes: []
2018-04-03T13:24:57Z [DEBUG] [security.go:153]: got user information via basic auth
[MySQL] 2018/04/03 13:24:57 packets.go:32: EOF
[MySQL] 2018/04/03 13:24:57 packets.go:118: write tcp <IP_ADDRESS>:48816-><IP_ADDRESS>:3306: write: broken pipe
2018-04-03T13:24:57Z [DEBUG] [user.go:304]: Check if user admin is super user
2018-04-03T13:24:57Z [DEBUG] [authenticator.go:96]: Current AUTH_MODE is db_auth
2018-04-03T13:24:57Z [DEBUG] [security.go:214]: using local database project manager
2018-04-03T13:24:57Z [DEBUG] [security.go:216]: creating local database security context...
2018-04-03T13:24:57Z [DEBUG] [token.go:35]: URL for token request: /service/token?account=admin&client_id=docker&offline_token=true&service=harbor-registry
2018-04-03T13:24:57Z [DEBUG] [creator.go:200]: scopes: []
2018-04-03T13:24:57Z [DEBUG] [authutils.go:47]: scopes: []

mysql.log
2018-04-03 12:03:13<PHONE_NUMBER>31104 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 12:03:13<PHONE_NUMBER>31104 [Note]  - <IP_ADDRESS>
2018-04-03 12:03:13<PHONE_NUMBER>43520 [Warning] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' does not resolve to '<IP_ADDRESS>'.
2018-04-03 12:03:13<PHONE_NUMBER>43520 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 12:03:13<PHONE_NUMBER>43520 [Note]  - <IP_ADDRESS>
2018-04-03 12:08:13<PHONE_NUMBER>37312 [Warning] Aborted connection 12 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:23:18<PHONE_NUMBER>40416 [Warning] Aborted connection 9 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:23:18<PHONE_NUMBER>34208 [Warning] Aborted connection 15 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:23:18<PHONE_NUMBER>43520 [Warning] Aborted connection 17 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:32:36<PHONE_NUMBER>43520 [Warning] IP address '<IP_ADDRESS>' could not be resolved: Name or service not known
2018-04-03 12:32:36<PHONE_NUMBER>40416 [Warning] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' does not resolve to '<IP_ADDRESS>'.
2018-04-03 12:32:36<PHONE_NUMBER>40416 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 12:32:36<PHONE_NUMBER>40416 [Note]  - <IP_ADDRESS>
2018-04-03 12:32:36<PHONE_NUMBER>34208 [Warning] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' does not resolve to '<IP_ADDRESS>'.
2018-04-03 12:32:36<PHONE_NUMBER>34208 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 12:32:36<PHONE_NUMBER>34208 [Note]  - <IP_ADDRESS>
2018-04-03 12:43:20<PHONE_NUMBER>43520 [Warning] Aborted connection 19 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:43:20<PHONE_NUMBER>34208 [Warning] Aborted connection 20 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 12:43:20<PHONE_NUMBER>40416 [Warning] Aborted connection 21 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 13:12:47<PHONE_NUMBER>40416 [Warning] IP address '<IP_ADDRESS>' could not be resolved: Name or service not known
2018-04-03 13:12:47<PHONE_NUMBER>34208 [Warning] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' does not resolve to '<IP_ADDRESS>'.
2018-04-03 13:12:47<PHONE_NUMBER>34208 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 13:12:47<PHONE_NUMBER>34208 [Note]  - <IP_ADDRESS>
2018-04-03 13:17:57<PHONE_NUMBER>43520 [Warning] Access denied for user 'root'@'localhost' (using password: NO)
2018-04-03 13:18:11<PHONE_NUMBER>43520 [Warning] Access denied for user 'root'@'localhost' (using password: YES)
2018-04-03 13:22:47<PHONE_NUMBER>40416 [Warning] Aborted connection 22 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 13:22:47<PHONE_NUMBER>34208 [Warning] Aborted connection 23 to db: 'registry' user: 'root' host: '<IP_ADDRESS>' (Got timeout reading communication packets)
2018-04-03 13:24:57<PHONE_NUMBER>40416 [Warning] IP address '<IP_ADDRESS>' could not be resolved: Name or service not known
2018-04-03 13:24:57<PHONE_NUMBER>34208 [Warning] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' does not resolve to '<IP_ADDRESS>'.
2018-04-03 13:24:57<PHONE_NUMBER>34208 [Note] Hostname 'zookeeper-0.zookeeper-headless.default.svc.cluster.local' has the following IP addresses:
2018-04-03 13:24:57<PHONE_NUMBER>34208 [Note]  - <IP_ADDRESS>

i do not understand the log  in mysql, maybe  i should try a clean namespace?

finally, i got the answer. refer to  the document test an insecure registry，
With insecure registries enabled, Docker goes through the following steps:

First, try using HTTPS.
If HTTPS is available but the certificate is invalid, ignore the error about the certificate.
If HTTPS is not available, fall back to HTTP.

the ingress https should always enable tls，because without it， the ingress default backend return a 404 response。


⚠ Bofrost.be has degraded performance

In 640ce06, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 827 ms

Resolved: Bofrost.be performance has improved in c235e9d.


Fix folder structure

I try to use project-layout to change folder structure, have a look!

Thanks for sharing this - I am quite new to Go so I am learning it atm. This is very useful - I'll review the PR


ttps://flutter.dev/docs/resources/bug-reports

Oops; flutter has exited unexpectedly: "Invalid argument(s): Cannot find executable for C:\chandu\New folder\MY PROJECTS\Flutter\sample\android\gradlew.bat.".
A crash report has been written to C:\chandu\New folder\MY PROJECTS\Flutter\sample\flutter_02.log.
and
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit visit
https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.

Hi @chandupolu
does it persist after https://github.com/flutter/flutter/issues/51712#issuecomment-600394582?
could you attach the file C:\chandu\New folder\MY PROJECTS\Flutter\sample\flutter_02.log?


Rename uses of "Callback"

A lot of the UI code uses the term Callback when referring to Signal (or in some cases, preferably SignalSource objects, see #853). This is confusing. A SignalSource object is meant to manage a collection of event handler callbacks, but is not itself a callback. We should rename uses of this term to increase precision, and decrease the potential for misunderstanding with the UI code.
I would recommend handling #853 first, as it has the potential for merge conflicts. Plus, by making the type more accurate first, that may lead to a more precise name.
It may be reasonable to replace the term Callback with the term SignalSource, as that is the type being referred to. Though it's not normally great practice to encode a type name into a variable name, so maybe there is another way to handle this.
Internally, variables such as mCallback should become something like mSignal (a Signal object), while accessor methods should change the ...Callback return type alias to instead be ...SignalSource (a SignalSource reference).

A strongly related problem is the confusing naming of accessor methods that return references to SignalSource objects. These are named after the event, and allow for confusion with the event handler method itself. Rather these are an accessor method to get access to the SignalSource object, which may then be used to connect/disconnect from the event.
As an example, in the Button class:
ClickCallback& click() { return mCallback; }

Where the return type is defined as:
using ClickCallback = NAS2D::Signal<>;

A more accurate method name would be something like getClickEventSource or getClickSignalSource:
NAS2D::SignalSource<>& getClickSignalSource() { return mClickSignal; }

We still need to put some thought into clear SignalSource accessor names. @ldicker83: Any ideas?
I feel like getClickSignalSource() is a bit too wordy. Using just the signal name such as click() seems a bit too brief, and may be mistaken for the signal handler.

To keep the discussion focused, I've opened #875 where we can discuss just the naming convention for SignalSource accessor methods. No need to complicate the discussion with other aspects such as the now complete rename of "Callback".
Closing this issue.


New button to shield all funds.

We need to include a new button to do that.

Hi. I created a PR in regards to this issue:
https://github.com/zingolabs/zingo-pc/pull/67

@elijahhampton
First of all, I'm going to explain to you the idea of this shield functionality... @zancas Please, if I say something wrong or not accurate, please feel free to correct me.
We want the possibility of shield each pool (sapling or transparent) separately... not 'all'.
I mean, two buttons are needed, one for sapling and one for transparent. you can use instead all -> sapling or transparent (you can take a look to zingolib command shield for being sure).

No problem. I will refactor and correct.

@juanky201271 , @elijahhampton , in addition to the buttons to "Shield Funds" from the "Receive" tab, do you plan to add a button on the Dashboard or header?

@elijahhampton How's going? Let me know if you have any questions or something... Thanks.

@elijahhampton How's it going...? Let me know if you have any questions or something... Thanks.

@juanky201271 Sure. A few questions. Do you have a discord or chat channel I can jump into?

@elijahhampton How's it going...? Let me know if you have any questions or something... Thanks.

@juanky201271 Sure. A few questions. Do you have a discord or chat channel I can jump into?

@zancas Can you help @elijahhampton to access to the appropriate chat for discussing about zingo-pc? Thanks in advance.

Hi @elijahhampton join this discourse forum:
https://forum.zcashcommunity.com/
You can PM me there.  I am "zancas".

@elijahhampton
First of all, I'm going to explain to you the idea of this shield functionality... @zancas Please, if I say something wrong or not accurate, please feel free to correct me.
We want the possibility of shield each pool (sapling or transparent) separately... not 'all'.
I mean, two buttons are needed, one for sapling and one for transparent. you can use instead all -> sapling or transparent (you can take a look to zingolib command shield for being sure).

@juanky201271
Sorry this comment confused me a little because as I understand sapling funds are already shielded.
So you are requesting the following modification:

Shield transparent -> sapling
Shield sapling -> unified (Basically sending sapling funds to the users unified address)

I'm sorry... you are right, sapling funds are already shielded.
But the idea is the same:

promote sapling funds to orchard.
shield transparent funds to orchard.

The user can want to choose those funds separately.

@juanky201271 , @elijahhampton , in addition to the buttons to "Shield Funds" from the "Receive" tab, do you plan to add a button on the Dashboard or header?

I was thinking about this, and honestly I don't see this clearly... Can you elaborate more your proposal of putting another button in the dashboard????


Fix theme property descriptions in the Inspector

Fixes a regression from https://github.com/godotengine/godot/pull/51119. I didn't notice that we used the old prefix to display the documentation in the inspector.

Thanks!


ESP-IDF V4.4 make errors

make -j -C ports/esp32 BOARD=GENERIC_S3_SPIRAM USER_C_MODULES=~/esp/lv_micropython/lib/lv_bindings/bindings.cmake
The error message is as follows,How to solve it?
CMake Error at /home/le/esp/lv_micropython/lib/lv_bindings/bindings.cmake:6 (include):
include could not find requested file:
/home/le/esp/lv_micropython/lib/lv_bindings/lvgl/CMakeLists.txt

Call Stack (most recent call first):
/home/le/esp/lv_micropython/py/usermod.cmake:42 (include)
main/CMakeLists.txt:14 (include)
CMake Error at /home/le/esp/lv_micropython/lib/lv_bindings/mkrules.cmake:39 (target_compile_options):
target_compile_options called with incorrect number of arguments
Call Stack (most recent call first):
/home/le/esp/lv_micropython/lib/lv_bindings/mkrules.cmake:98 (lv_bindings)
/home/le/esp/lv_micropython/lib/lv_bindings/bindings.cmake:20 (all_lv_bindings)
/home/le/esp/lv_micropython/py/usermod.cmake:42 (include)
main/CMakeLists.txt:14 (include)
CMake Error at /home/le/esp/lv_micropython/lib/lv_bindings/mkrules.cmake:39 (target_compile_options):
target_compile_options called with incorrect number of arguments
Call Stack (most recent call first):
/home/le/esp/lv_micropython/lib/lv_bindings/mkrules.cmake:131 (lv_bindings)
/home/le/esp/lv_micropython/lib/lv_bindings/bindings.cmake:20 (all_lv_bindings)
/home/le/esp/lv_micropython/py/usermod.cmake:42 (include)
main/CMakeLists.txt:14 (include)
CMake Error at /home/le/esp/lv_micropython/py/usermod.cmake:9 (get_target_property):
get_target_property() called with non-existent target "lvgl_interface".
Call Stack (most recent call first):
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:47 (usermod_gather_sources)
main/CMakeLists.txt:14 (include)
CMake Error at /home/le/esp/lv_micropython/py/usermod.cmake:15 (get_target_property):
get_target_property() called with non-existent target "lvgl_interface".
Call Stack (most recent call first):
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:47 (usermod_gather_sources)
main/CMakeLists.txt:14 (include)
CMake Error at /home/le/esp/lv_micropython/py/usermod.cmake:21 (get_target_property):
get_target_property() called with non-existent target "lvgl_interface".
Call Stack (most recent call first):
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:24 (usermod_gather_sources)
/home/le/esp/lv_micropython/py/usermod.cmake:47 (usermod_gather_sources)
main/CMakeLists.txt:14 (include)

Hello!
Current MicroPython-LVGL binding version (MP: v1.20, LVGL: v9) does not support ESP32-S3, but I'm going to upgrade to latest MicroPython version (1.22.x), it just needs time.
Btw there is an another repo with MicroPython v1.22 & LVGL v9 you can check: https://github.com/kdschlosser/lvgl_micropython
The main difference is that there the LVGL is added to MicroPython as a separate user module.

Hello! Current MicroPython-LVGL binding version (MP: v1.20, LVGL: v9) does not support ESP32-S3, but I'm going to upgrade to latest MicroPython version (1.22.x), it just needs time.
Btw there is an another repo with MicroPython v1.22 & LVGL v9 you can check: https://github.com/kdschlosser/lvgl_micropython The main difference is that there the LVGL is added to MicroPython as a separate user module.

Thank you for your reply.


Refresh Token for GitLab

Authentication via GitLab does not use refresh tokens even though GitLab supports using them (https://docs.gitlab.com/ee/api/oauth2.html). As a result, whenever I refresh the page, I have to login again.
Expected Behavior

After logging in via GitLab, then refreshing the page, the user does not need to authenticate.
Current Behavior
After logging in and refreshing, the user must authenticate.

Possible Solution
Request an access/refresh token from GitLab

Steps to Reproduce

Login via GitLab
Refresh the page

Context
Want to be able to stay logged in after authenticating with GitLab once.

 If not I can add a few more labels to the ticket.

@stefanalund No, I'm not comfortable enough with the code. You can add the labels.

@sandstroms no worries -- thanks for reporting! Let's hope someone else steps up to the challenge 😄

Hi @sandstroms, I'd love to take a stab at this! May I claim this issue?

All yours @rishibarad 💯

@rishibarad are you still working on this ? I would like to give an hand on this.

Hi @paolomainardi, I'm making progress on this. Would you want to collaborate?

@rishibarad How are things going? Need any help?

I wonder if it's covered by https://github.com/backstage/backstage/pull/5702 . The issue description claims that we don't use refresh tokens for this provider at all, but I haven't investigated whether that's the case.

The GitLab auth provider does set disableRefresh: true for OAuth, though I'm not sure why since the passport-gitlab2 package says that refresh tokens are optionally supported 🤔

@Rugvip do you remember?

@freben The disableRefresh: true was part of the initial PR to add GitLab auth, so I would imagine it was copied from the GitHub implementation by mistake. Most likely isn't supposed to be there.

Any solution?. I tried to keep single provider only Gitlab, am experiencing the same issue after refreshing the page it asks to sign in again.

@satrox28 I'd expect the solution to be to remove the disableRefresh: true option, but there might be more to it. I believe the frontend is trying to refresh because from its point of view GitLab supports refresh

@Rugvip removing disableRefresh:true, didn't solve the issue. After removing it, am unable to authenticate via Gitlab, getting below error.
Missing refresh token

Alright, needs a bit more work then. I guess you're on it @OrkoHunter? :grin:

Since I already created a branch - will find time this week 😄

@satrox28 Based on our Discord chat, wondering if you're still up for working on this and if I should assign this to you? Happy to support nevertheless. 🙂

@OrkoHunter I didn't get to check on it had modified my auth to Google where I don't see the issue.


engagement on /jira_finding_mappings endpoint is always null

Bug description
When querying GET'ing the /jira_finding_mappings, the engagement value is always null.
{
      "id": 69,
      "jira_id": "244117",
      "jira_key": "DOJOSBX-17",
      "finding": 36940,
      "engagement": null
}

This makes it hard to build a list of findings that have a jira issue associated.
fyi @Apipia ;-)

😆Yeah the "engagement" logic with JIRA has a bunch of holes in it. Saw a lot of commented out code and things in that regard. Definitely something I can look into.

The engagement field is only populated if the jira issue is the epic mapped to an engagement. In that case the finding field is null/none. So a jira_issue record either belongs to a finding XOR to an engagement.
If you need the engagement value you can go `finding.test.engagment' or do another API call :-)


loop over keyservers (resolving issue #87)

Closes #87

My current opinion of this is expressed in https://github.com/docker-library/cassandra/pull/131#issuecomment-358444537.
Related issues: https://github.com/docker-library/mysql/issues/263#issuecomment-354025886 and https://github.com/docker-library/httpd/issues/66#issuecomment-316832441

Alright. I do get it. Although the whole keyserver thing is not as stable as we all would like it to be, I do get the point that building in the loop in all images might be too much. And actually the keyserver pool should work properly so we don't have to fix it in an ugly way.
So close the PR?

Sure, seems sane. Thank you for your understanding.

No worries. The best solution is always best ;)


Issue #1895: Bugfix for string_to_arrow timestamp[ns] support

Should resolve https://github.com/huggingface/datasets/issues/1895
The main part of this PR adds additional parsing in string_to_arrow to convert the timestamp dtypes that result from str(pa_type) back into the pa.DataType TimestampType.
While adding unit-testing, I noticed that support for the double/float types also don't invert correctly, so I added them, which I believe would hypothetically make this section of Value redundant:
    def __post_init__(self):
        if self.dtype == "double":  # fix inferred type
            self.dtype = "float64"
        if self.dtype == "float":  # fix inferred type
            self.dtype = "float32"

However, since I think Value.dtype is part of the public interface, removing that would result in a backward-incompatible change, so I didn't muck with that.
The rest of the PR consists of docstrings that I added while developing locally so I could keep track of which functions were supposed to be inverses of each other, and thought I'd include them initially in case you want to keep them around, but I'm happy to delete or remove any of them at your request!

OK! Thank you for the review - I will follow up with a separate PR for the comments here (https://github.com/huggingface/datasets/pull/1900#discussion_r578319725)!


No launch.json created after selecting 'Node' as the target

open a workspace on an empty folder
press F5
quick pick shows 'Node' as an option
select 'Node'

Nothing happens and no launch.json is created for node debugging.

In this scenario since we can not detect the entry file we should create a launch.json.
Might be an issue due to refactoring on my side also

This is happening for me as well in a workspace folder in which a Node project (with a top-level app.js) already exists.
In my case, I had a .vscode folder with a tasks.json but no launch.json. Node is shown as an option but nothing happens and no launch.json is created. Windows 10, VS Code 1.13.1.

I have a fix but not for June because we are already at the end of the endgame.


upload a list of locations

as an administrator I want to upload a list of locations to the site.
the feature should be available from /admin
This feature has been developed by @ismailsunni and includes a report
Please see other tickets:
#309
#210
#200
#149
#432
#204

@markherringer
is it related with : http://staging.healthsites.io/upload-form ?
because t is already done.
where should i put link in page?
(note, i will make restriction if user is admin)

Hi @meomancer thank you for this. The idea for this feature is to allow trusted users like The ICRC to upload lists them selves. We need the ICRC user to do this so that the provenance is established.The process will work like this:

The user will contact us
we will help prepare the list for upload and terst on staging
Once the list is ready we will assign the list upload permissions to the ICRC user so that they can upload it themselves


[Feature Request] Tap anywhere on description area to expand or collapse

Why/User Benefit/User Problem
(explain why this feature should be added)
Cases where the description is super long.
Makes it easier instead of finding the expand/collapse button
So it doesn't look like this

What/Requirements
(explain how this feature would behave)
Like how it is in stable

Why is that description cancer...


80 check boozer routines

@marjohma you will have to do a git pull --rebase in this branch since I rebased this on the latest main.


TiFlash can't gc completely for CHbenCHmark scenario

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

mysql> select TIFLASH_INSTANCE,tidb_table, total_size,total_stable_size_on_disk from information_schema.tiflash_tables where tidb_database='tpcc' and total_size !=0 or total_stable_size_on_disk !=0 order by tidb_table;
+---------------------------------------------------------------------------------------+------------+------------+---------------------------+
| TIFLASH_INSTANCE                                                                      | tidb_table | total_size | total_stable_size_on_disk |
+---------------------------------------------------------------------------------------+------------+------------+---------------------------+
| tc-tiflash-0.tc-tiflash-peer.endless-htap-ch-mutiple-disks-tps-1290764-1-284.svc:3930 | new_order  |   16645768 |                   9491563 |
| tc-tiflash-3.tc-tiflash-peer.endless-htap-ch-mutiple-disks-tps-1290764-1-284.svc:3930 | order_line |   97287435 |                  39894332 |
+---------------------------------------------------------------------------------------+------------+------------+---------------------------+

2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)
6.3 ca8f97df64b12b326ae2282b992785da1f7ebac0

We use delete range to clear the data in the old range, when region range is changed during ApplySnapshot:
                    auto old_key_range = DM::RowKeyRange::fromRegionRange(
                        old_region->getRange(),
                        table_id,
                        storage->isCommonHandle(),
                        storage->getRowKeyColumnSize());
                    if (old_key_range != new_key_range)
                    {
                        LOG_FMT_INFO(log, "clear region {} old range {} before apply snapshot of new range {}", region_id, old_key_range.toDebugString(), new_key_range.toDebugString());
                        dm_storage->deleteRange(old_key_range, context.getSettingsRef());
                    }

(introduced in https://github.com/pingcap/tiflash/issues/4414 as a bug fix).
However, the delete range is not flushed, so that it will not be counted in the GC process (due to https://github.com/pingcap/tiflash/issues/6045), leaving some data not reclaimed.
Previously this case is very rare, because we always flush the segment in the ingestSnapshot process and the segment is usually the same one even when region range is changed.
However, now we use logical split when ingesting snapshots (introduced in https://github.com/pingcap/tiflash/issues/5237), so that the segment for the old region range is very likely to be different than the segment for the new region range. This case becomes more easily to cause problems now.


Multiple input tex files

Hi,
Thank you for the awesome tool. I'm wondering how/whether it supports multiple input tex files? For example, I have a main.tex where it pulls content from other tex files, e.g. \input{chapter1.tex}. Will content from chapter1.tex be automatically included?

Sounds good. I guess I can work on a PR if I have some time. Basically, I can add a list of patterns to match, e.g., \input{} and \include{}, and then recursive expand the command to its actual content before parsing the keys. What do you think?

Yep, sounds perfect!

This has been implemented in PR #3 and is available in version 0.1.


I think there is a way to reduce the amount of ram used when using cosine_similarity function

Original Code:

Test Code:

import numpy as np
from sklearn.metrics.pairwise import cosine_similarity

a = np.random.randn(1524,192)
b = np.random.randn(4864,192)
c = np.expand_dims(b[0], 0).repeat(len(a),axis=0)
d = np.expand_dims(b[0],0)

score = cosine_similarity(d,a)
score_test = cosine_similarity(c,a)

print(score.shape)
print(score_test.shape)
print(len(score_test.tolist()))

print(score.tolist()[0])
print(score_test.tolist()[0])

Test code output:

If eroll_features.shape() = (n,m),trials_features.shape() = (k,m),then the score of the original code would be a matrix of (n,n) before executing .tolist()[0], taking up a peak ram of n^2 * 8 bytes(FP64). In the test code it would only take up a peak ram of n * 8 bytes
There is a slight difference between the output of two methods. I'm not sure why, but it shouldn't be affecting greatly on the outcome.

验证有效


certificate verify failed

What version of fleet are you using (fleet version --full)?
fleet - version 2.6.0
What operating system are you using?
Ubuntu 16.04
What did you do?
Connecting osqeuryd with fleet, both fleet and osquery are on same machine followed this guide
https://github.com/kolide/fleet/blob/master/docs/infrastructure/README.md
sudo /usr/bin/osqueryd
--enroll_secret_path=/var/osquery/enroll_secret
--tls_server_certs=/var/osquery/server.pem   (this file is downloaded from web page of fleet)
--tls_hostname=<IP_ADDRESS>:8080
--host_identifier=hostname
--enroll_tls_endpoint=/api/v1/osquery/enroll
--config_plugin=tls
--config_tls_endpoint=/api/v1/osquery/config
--config_refresh=10
--disable_distributed=false
--distributed_plugin=tls
--distributed_interval=3
--distributed_tls_max_attempts=3
--distributed_tls_read_endpoint=/api/v1/osquery/distributed/read
--distributed_tls_write_endpoint=/api/v1/osquery/distributed/write
--logger_plugin=tls
--logger_tls_endpoint=/api/v1/osquery/log
--logger_tls_period=10
What did you expect to see?
N/A
What did you see instead?
My Client Window

My Server Window

Results from
curl -v -X POST https://kolideserver:port/api/v1/osquery/enroll

Please see https://github.com/kolide/fleet/blob/master/docs/infrastructure/faq.md#why-arent-my-osquery-agents-connecting-to-fleet and use #kolide in the osquery Slack for troubleshooting.


Added better error reporting to help debug issues with mapper files

Wrapped some SQL exceptions with more information about where the problem exists.   I'd end up putting breakpoints in the code to find out what column MyBatis was working on.
This code really makes debugging the issue so easy as all the context is in the exception.

Thank you!


Modes Page Reverts Color

When I open the second pane on the webpage for mode selection, it always reverts back to RGB 128,128,128.  The brightness and speed sliders don't match what is currently running on the strip but they don't "hijack" what is already running at least.  But, for example, I initiate a group of settings from another source.  Now i want to go in and dim them more, i can't do that since the slider is only on the 2nd page and I'll lose my color setting.  Any assistance you could give me would be greatly appreciated.  Removing
if (pane == "pane2") {
			setMainColor();
		}

from the html file seems to solve the problem.

I see a lot of movement on the project.  Anything on this?

Not yet, creating a complete new UI takes time (I also have to learn a new framework). Expect more weeks than days for the first results.

@ryancasler PLease have a look here: https://github.com/toblum/McLightingUI/
Regards
Tobias

Will do when I'm back home this weekend.

Very confused.  All I have to do is upload the index2.html file?  And then what?  Do I delete the old one?

You can enter http:///index2.html and check if that version works. I can confirm it does! If you are satisfied, delete both files on the SPIFFs and rename index2.html on your computer to index.html and upload it.

Hi debsahu,
can you tell me how to delete files in the SPIFFs?
Thanks and best regards

@chkbln Using Arduino IDE, goto Tools -> Erase Flash -> All flash contents and flash McLighting.

In sketch you can do;
SPIFFS.format();

I was hoping to delete files via Edit


An unexpected error has occurred

Describe the bug
I downloaded the latest installer (1.16.116) and tried to run it.
but this error always occurs

An unexpected error has occurred. please run the setup program again.
if problems continue, see the microsoft hardware web site for software updates and additional product information to help you troubleshoot the issue.

To Reproduce

Download the setup file
Try to run it

System details
Windows 10 pro 1903 (1836.2.720)

Why not use WiX toolset for the installer creation? I guess it would solve most of the installer based problems, and remove a dependency on a closed-source software?

More and more tempted to do after wondering why such a fairly simple project appears to cause such headaches 🤔 Advanced Installer is awfully more convenient than WiX though, hands down.

There is also Inno Setup though. Not as advanced as WiX but maybe this project doesn't require anything more sophisticated...

Setup has been WiX-ified 😅


Applies To is ambiguous

Hi Team
Heading for this article says "Network Security: Configure encryption types allowed for Kerberos Win7 only" however "Applies to" section of the document says "Windows 10".
In the whole document, there is discussion for Kerberos encryption for Win7 & Win 2k8.
Is this anyhow related to Win 10?
Regards
Hussain

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d05d447-1cc1-1eeb-3c4d-74591874f4e1
Version Independent ID: 020b4d09-5ce9-e636-0545-1ce27029a921
Content: Network security Configure encryption types allowed for Kerberos Win7 only (Windows 10)
Content Source: windows/security/threat-protection/security-policy-settings/network-security-configure-encryption-types-allowed-for-kerberos.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@wmhussain. Those policies are included In windows 10  in gpo under.
Computer Configuration\ Windows Settings\ Security Settings\ Local Policies\ Security Options
screenshot. From my side  windows 10  definitely  supported

@officedocsbot assign @mypil

@wmhussain - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hi @mypil  the PR #4309 solved this issue ! Please Review and Merge !

@wmhussain - From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


New OptiMod Metro map

Issue #139
For a new Mod contribution, please include the issue number for the Mod proposal and check through the list below.

Implementation:

[x] Implementation of the Mod in the gurobi_optimods installable package
[x] Tests for the Mod implementation in tests/
[x] Docstrings for public API, correctly linked using sphinx-autodoc

Documentation page:

[x] Background and problem specification
[x] Example of the input data format (use gurobi_optimods.datasets for loading data)
[x] Runnable code example
[x] Presentation of solutions
[x] Included in the mod gallery and toctree

This is so cool!
Looks like I need to finally add a WLS license for the tests to run, I'll work on that. It would be nice if all the examples in the docs could be solved only using the free trial license, but the s-bahn is too good to leave out :-)
I wonder if it's possible to embed the plotly graph directly into the doc so that it's zoomable and clickable?

@torressa could you please review this? Ignore the CI test fails, I need to sort out #63 first.

Amazing! Thanks Marika! Super cool mod, well done! 🚀
Tests are failing due to numpy 2.0. I guess Simon can fix this in another PR

I added functionality for skipping doctests that need a full license to the main branch and applied it in 0c189c6aaae2ac8b23a38cb069c6d00ed265b788.
As discussed, it would be better to have the first example on the page be one that is runnable with a size-limited license. The two larger examples (the full sbahn and the combined example with line planning) should still be included, but I suggest a note in the docs to say "running this larger example requires a full gurobi license'.

I think I included all the required changes.
I do not know why the tests are suddenly failing, it is in the min_cut optimod.

Simon fixed this in #149 🚀

It looks like I messed something up, and my changes are not directly pushed to this PR.
I am only able to create a new PR?  Is there something else I can do?


Separate all classes into their own files.

One example is DremioCredentials and DremioConnectionManager.

Discussion with @jlarue26 and @ravjotbrar led us to allow multiple classes per module. Provided they meet the following guidelines (taken from https://softwareengineering.stackexchange.com/questions/209982/is-it-considered-pythonic-to-have-multiple-classes-defined-in-the-same-file):

Size

Excessively large files can be ugly, but that's hardly the case here. Ugliness is probably a good enough reason to split a file, but developing that aesthetic sense is largely a matter of experience, so it doesn't help you figure out what to do a priori

Separation of Concerns

If your concrete implementations have very different internal concerns, your single file accumulates all those concerns. For example, implementations with non-overlapping dependencies make your single file depend on the union of all those dependencies.
So, it might sometimes be reasonable to consider the sub-classes' coupling to their dependencies outweighs their coupling to the interface (or conversely, the concern of implementing an interface is weaker than the concerns internal to that implementation).
As a specific example, take a generic database interface. Concrete implementations using an in-memory DB, an SQL RDBMS and a web query respectively may have nothing in common apart from the interface, and forcing everyone who wants the lightweight in-memory version to also import an SQL library is nasty.

Encapsulation

Although you can write well-encapsulated classes in the same module, it could encourage unnecessary coupling just because you have access to implementation details that wouldn't otherwise be exported outside the module.
This is just poor style I think, but you could enforce better discipline by splitting the module if you really can't break the habit.


Poll for compile variant hex files in parallel

One benefit of the new compile service is that it can now execute compile jobs in parallel. This PR takes advantage of that feature and makes it so that when hitting the compile service for micro:bit, we request the compiling of both the V1 and V2 hexes at the same time.
In other words, it should cut the CPP compile time in half (but only for micro:bit, since it's the only "fat hex" target).
I'm planning on doing the same thing with our CLI builds in the near future, which should speed up pxt buildtarget significantly for targets with multiple compile variants.

Clever change.


Point column is always "dirty" after creating a record

Hi, thank you for your work on this package.
I've tested it with Laravel 10.39.0 and 10.46.0 with your package version 3.2.2 and 4.1.0.
If you are creating a new record or a factory record the column, which includes the point, is always dirty.
Here is an example:
<?php

// Model

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use MatanYadaev\EloquentSpatial\Objects\Point;
use MatanYadaev\EloquentSpatial\Traits\HasSpatial;

class Estate extends Model
{
    use HasFactory;
    use HasSpatial;

    protected $fillable = [
        'name',
        'coordinates',
    ];

    protected $casts = [
        'coordinates' => Point::class,
    ];
}

<?php

// Factory

namespace Database\Factories;

use Illuminate\Database\Eloquent\Factories\Factory;
use MatanYadaev\EloquentSpatial\Objects\Point;

/**
 * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\Estate>
 */
class EstateFactory extends Factory
{
    /**
     * Define the model's default state.
     *
     * @return array<string, mixed>
     */
    public function definition(): array
    {
        return [
            'name' => fake()->word(),
            'coordinates' => new Point(51.5032973, -0.1217424),
        ];
    }
}

<?php

// Test

use App\Models\Estate;
use MatanYadaev\EloquentSpatial\Objects\Point;

test('coordinates have to be not dirty on factory create', function () {
    $estate = Estate::factory()
        ->create();

    expect($estate->isDirty('name'))->toBeFalse();

    expect($estate->isDirty('coordinates'))->toBeFalse(); // Failed
});

test('coordinates have to be not dirty on create', function () {
    $estate = Estate::create([
        'name' => 'Foo',
        'coordinates' => new Point(51.5032973, -0.1217424),
    ]);

    expect($estate->isDirty('name'))->toBeFalse();

    expect($estate->isDirty('coordinates'))->toBeFalse(); // Failed
});

I've created a demo repository: https://github.com/poldixd/laravel-eloquent-spatial-issue
You can run the test with ./vendor/bin/pest tests/Feature/LaravelEloquentSpatialTest.php

Please test #115 and let me know if it fixes the issue for you.

Perfect. Thank you. The tests are now successful and everything works.


DEX-1311: Progress completion bug

:warning: THIS DRAFT WILL LIKELY GET DELETED.   NEW PR FORTHCOMING.

Pull Request Overview

Specify a list of summary items that this PR is accomplishing
Specify any database updates

Review Notes

Specify a list of any items, notes, or qualifiers that need to be known in order to efficiently review this PR

Model Updates [OPTIONAL]
ExampleModel

guid
example_attribute

Database Updates [OPTIONAL]
Specify any new/modified/removed database tables
REST API Updates [OPTIONAL]
A new example POST API is defined with its expected parameters, if needed to be specified for a thorough review
[POST] /api/v1/module/endpoint/
{
    'example_attribute': 'example',
}

Invoke CLI Updates [OPTIONAL]
Here is an example invoke that shows the new functionality
$ invoke app.module.task
<copy relevant terminal output>

This PR is being replaced by #757


add more information about resolution

motivation: additional debug information for resolution errors with overrides
changes: include package location on resolution information log

@swift-ci please smoke test


default query gets sent to fleet server instead of the entered one.

What version of fleet are you using (fleet version --full)?
11:07:38 gcox@nyc01util12:~$ ./fleet version --full
fleet - version 1.0.5-26-ga08d540
branch: 	master
revision: 	a08d540333462730996cf9c50abd326a128df4a2
build date: 	2017-11-14T09:42:54Z
build user: 	gjvc
go version: 	go1.9.1
I have a feeling it wasn't there in the version I originally tried, 1.0.5 / baeb80f3b58f4c8c5c92f94f935674d3926907e1
What operating system are you using?
CentOS Linux release 7.3.1611 (Core)
What did you do?
Entered a query on the main page.
What did you expect to see?
Results of the same query I entered.
What did you see instead?
Results of the default query which was there in the box as an example.

See #1540 and #798 for similar issues. I am able to repro this locally, and I see that the default query text is provided in the body of the POST.

AFAICT this is caused by https://github.com/kolide/fleet/pull/1550/files#diff-54f599f639017abfc676c50e9b48e84aR105. I believe deleting that line fixes both this case and the case that PR was trying to fix (in which a saved query is run without modification).

Am on ```# /usr/bin/kolide version --full

version 1.0.5-32-g607b914
branch:       barn-kolide-bug-reporting
revision:     607b9141eadddb98aeca1690bee9ed64abcf33c9
build date:   2017-11-16T00:34:43Z
build user:   barn
go version:   go1.9.2``` and still seeing this...

I1115 18:17:31.157094 14290944 distributed.cpp:133] Executing distributed query: kolide_distributed_query_566: SELECT * FROM users u JOIN groups g WHERE u.gid = g.gid

When running an entirely different query.

can you try the build I just pasted in slack> i wonder if your deps are not compiling right.


[Request - Product] OpenVPN

Full and short name of product
OpenVPN
Does this product have LTS versions? What are the intervals between each LTS version?
No LTS afaict
What is the website for the product and for its version information?
project - https://openvpn.net/
code/releases/issues - https://github.com/OpenVPN/openvpn
version info - https://community.openvpn.net/openvpn/wiki/SupportedVersions
Additional context
OpenVPN is a widely used virtual private networking system.
OpenVPN Community Edition aka OpenVPN is a GPLv2 server and client.
OpenVPN Access Server (OpenVPN-AS) provides additional paid and proprietary features.
There is a strict dependency on OpenSSL which is defined at the bottom their version table page.

I have created a merge request to add this product.


go/adbc/driver/flightsql: Handshake for bearer tokens

When a basic (username + password) authentication strategy is used, an explicit Handshake is currently performed:
https://github.com/apache/arrow-adbc/blob/c8ec427db7d3ee9435f3407aaab339b65ce0ecbd/go/adbc/driver/flightsql/flightsql_database.go#L377-L382
As part of this handshake the initial username/password is exchange for a new session-bound authorization header which is replayed by the client in follow-up requests.
In my case, I'd like to accomplish the same but using a bearer token (E.g.: API key) during the initial authorization. I see one can already pass an authorization header (#387) and it is already replayed by the client (#594).  However, no handshake is performed in this scenario.
I see there is a test case that handles the authorization header using a middleware pattern:
https://github.com/apache/arrow-adbc/blob/d82ff04a39d588c1410fe00ae667bc1657c15ce9/go/adbc/driver/flightsql/flightsql_adbc_server_test.go#L206-L212
However, while it is easy to distinguish between a mock Bearer initial and Bearer final, a real scenario would require some heuristic to distinguish between the initial and session header. Doing an explicit handshake, similar to the basic auth scenario, would seem preferential.
I'd like to know if it would be sensible to add support for this scenario or if there is (already) a better way to configure this.

Wouldn't your middleware be able to parse the header and determine the type/whether to send a new header back?

It is feasible. However, it would be distinguishing between Bearer xxx for initial auth and Bearer 123 for the session-bound auth. While feasible, it would seem less error prone to make the difference explicit by handling the initial auth in the handshake call.
Technically the same is true for Basic auth. You could use a middleware to detect the basic auth token and handle it accordingly. I think it makes sense to handle that explicitly, so why not use the handshake or all 'initial authentication' needs.

After some digging I found the argumentation in apache/arrow#23836 against the handshake. I'll move the auth to a middleware and session state to the ticket as influxdb does.

Thanks for digging that up, I was trying to remember where all this was.


[Bug]: Error in data type handling

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I add a text 123-test in the input widget and reference it in an API body, it gets evaluated as "123-test" and not 123-test.

Steps To Reproduce

Create a new app and add an input widget on the canvas
Type 123-test in the input widget
Reference it in the API body

Public Sample App
No response
Issue video log
No response
Version
Cloud - 1.8.11

This is a smart substitution problem. We're looking at the value, gathering that it is a string without immediate quotes around it and adding the quotes ourselves. Data type handling allowed us to correctly recognize the value as a string and that's all. Do we want to solve for this within smart substitution? If yes, then I'd say this is a feature request to understand context around the binding.

Yes, I think the way this works has always been with immediate surroundings. That's the reason the value of the second property bitlink_id evaluates correctly. We've always suggested to users that they absorb the other part of the string into the JS binding as well, as {{ "bit.ly/"  + Input1.text }}

This issue is similar to the one reported here.

Closing this instead of one reported here.


Fork, Commit, Merge - Medium Issue (Java)

Fork, Commit, Merge - Medium Issue (Java)
Create a Calculator in Java
Note: You don't have ask permission to start solving the issue or get assigned, since these issues are supposed to be always open for new contributors. The actions-user bot will reset the file back to previous state for the next contributor after your commit is merged. So you can just simply start working with the issue right away!
Navigate to the tasks/java/medium directory from the root of your project.
Then open a file called Calculator.java and start implementing the Calculator class!
Description:
Create a simple calculator class in Java that performs basic operations: addition, subtraction, multiplication, and division.
Requirements:

The calculator class should have methods called add, subtract, multiply and divide.
The calculator should be able to handle both integers and floating-point numbers.

Don't modify the code in the main method! It contains bunch of tests that will run when the program is executed.
How to run:
Make sure you are in the right directory:
cd tasks/java/medium

Compile the program:
javac Calculator.java

Run the compiled program:
java Calculator.java

Expected output:
Addition: 8.0
Subtraction: 2.0
Multiplication: 15.0
Division: 1.6666666666666667

If the program works as requested in the task, you are ready to make a pull request!

To work with this issue, you need to have Java installed to your local machine.
Check out README.md for more instructions of installing Java and how to make a pull request.
Feel free to ask any questions here if you have some problems!
Also, kindly give this project a star to enhance its visibility for new developers!

I am working on it

I am working on it

Sure! No need to inform that you are working with the issues since these will always be open for new contributors. Multiple people can work with same issues.


where do I put my backend link

I'm hosting it on GitHub pages where in the nettleweb source do I put my backend link? my backend link is https://snowdev9099.github.io/Nettleweb-backend-mirror-/

how do i even make a backend server?


Infer the exposed key from the key of the field?

This is probably a feature request.
Is it possible to infer the exposed key from the key of the field? So instead of this:
const ApplicationObjectType = builder.objectRef<Application>('Application').implement({
  fields: (t) => ({
    applicationFormConfigId: t.exposeID('applicationFormConfigId', {}),
    clientId: t.exposeID('clientId', {}),
    comments: t.expose('comments', { type: 'GraphQLJSON' }),
    destinations: t.exposeStringList('destinations', {}),
...

It'd be this
const ApplicationObjectType = builder.objectRef<Application>('Application').implement({
  fields: (t) => ({
    applicationFormConfigId: t.exposeID(), // inferred as `applicationFormConfigId`
    clientId: t.exposeID(), // inferred as `clientId`
    comments: t.expose({ type: 'GraphQLJSON' }),
    destinations: t.exposeStringList(),
...

Unfortunately this is not possible due to limitations with typescripts inference.  I spent a lot of time looking at this when first building out GiraphQL. Current API is at least explicit and makes it easy to do aliasing.

Long term, what I may do is add an API like Prisma where you don't need to return the fields in an object.
define: t => { t.exposeID('clientID', options) }.  Core of GiraphQL already has most of the pieces to make this work.  I would probably initially add this as a Plugin.  The need to return fields at all is a bit vestigial from early versions that worked more like the simple objects plugin.  It allowed some cool stuff around interfaces, but keeping the types correct without getting in the way too much proved to be too complicated.
Long story short, I agree the current flow isn't perfect, and I have a few ideas on API changes that might help, but they are non-trivial and might be a long way out.

Totally understand where you're coming from. I actually like returning the object because it's easier to read instead of scanning the code for what comes after t.*(.

going to close this since there isn't really anything actionable here in the short term.


pre-processing of pose dataset

@nihaomiao please guide how do you get clean_unseen_video_dict.json and clean_video_dict.json ? I have tried to extract the key-points using openpose but it seems bit different from the json that you have provided under dataset folder.

Hi, @hacker009-sudo, thanks for your interest in our work! I don't remember the details very clearly right now. But I first used OpenPose to generate the video_dict.json files and then I manually checked the pose estimation results of each video frame and deleted those bad results to produce the clean version.

Thanks


Authors tab

Resolves #113 to implement authors form (without ORCID lookup). Until ORCID lookup is implemented, you can enter author data in all of the fields.
Note that I used "Role type" and "Role" instead of "Role term type" and "Role term" for simplicity. This can be changed if you prefer "term" in there, @astridu  and @amyehodge.
https://github.com/user-attachments/assets/33e0427f-2969-4d22-ae81-2f58d555b95c

Will need to be squashed before merging.

This looks really good! I am ok with dropping 'term', but will defer to Amy in case there is a specific reason to keep it.
My only comment is on the trash icon next to the 'Contact email' text field. Could we move it closer and align with with the text field? TY!


Added solution of a python issue

Added a program to implement sieve of Eratosthenes using a python program.

@sachin-duhan26 Sir, Kindly review and merge my PR
#5


Swappable element cloning bug

When using the swappable example, it is possible to produce some unexpected behaviour. Check out the video for example:
https://drive.google.com/file/d/0B19eJag7Bq_FUDk3NGREdUZuSVE/view

Swap an element to container B and back to container A
Move the element through the container A
Container B's element magically updates to clone the last switched element within A

Thanks for your feedback! Should be fixe with https://github.com/Shopify/draggable/pull/12


Avoid draw while in a favorable position

Andoma constantly makes the final move of a threefold repetition resulting in a draw, even when it has a massive advantage.
This PR solves this issue by assigning draw a neutral value of zero, and checking if the opponent can claim a draw.

Neat find @chitty 🚀


Clean up ReadMe

Done when each sprint has its own diagrams

30 min: going through revision history to find old diagrams


WIP: trying to test custom logical-types

So far unsuccessful. Can't generate correct Avro classes using provided gradle structure(s).

Current Gradle configuration does NOT allow to generate Specific Records with custom-logicalTypes.


Adding github repo in the footer

Hey @akshitagupta15june I want to add the GitHub repo in the footer. Please assign me this issue. Thank you!

this is a good suggestion, we are still finalising the content of the footer, once we do that we can assign you the issue to implement it.  My two cents would be along with the repo url , you can add stars and forks count too.
Pl wait till we get few things streamlined.

assigning u

Hey @akshitagupta15june is @ankitjt woking on this issue?

No you can add the features as suggested too.


Update SQLite3MultipleCiphers to 1.9.0

Closes #126

Blocked until https://github.com/xerial/sqlite-jdbc/issues/1204 is resolved and sqlite-jdbc <IP_ADDRESS> can be released.

Blocked until xerial/sqlite-jdbc#1204 is resolved and sqlite-jdbc <IP_ADDRESS> can be released.

Maintainer unwilling to fix (very odd hill to die on over logging?). bdad09f adds a patch removing all logging references.


Routes are separated and the relevant endpoints json file updated.

The current routes.js file contains all the routes in a single file. Hence, routes are logically separated and the related endpoint json file is updated to new endpoints.

@nihalmpatel can you fix the conflicting files?

I'm working on this.

Conflicts have been resolved. Kindly review the PR.


bug: tmp variable redeclared in generated code

Hey :wave:, if we try to generate code from the following definitions:
struct Fruit {
        uint64 ID;
        string Name;
}

struct Basket {
        Fruit Apples;
        Fruit Oranges;
        Fruit Mangos;
}

we get the following:
        tmp := (bbp.Apples)
        at += tmp.Size()
        bbp.Oranges, err = MakeFruitFromBytes(buf[at:])
        if err != nil {
                return err
        }
        tmp := (bbp.Oranges)
        at += tmp.Size()

where tmp is redeclared each time a struct is referenced.
I think I can fix this one either by checking that tmp is declared only once or by encapsulating tmp usage inside a { block } which does not require additional state keeping but produces uglier code.
Where would be a nice place to put a unit test for this?
Cheers,
Mirza

That's a fairly basic input that I'm surprised isn't covered by existing tests; what version or commit hash are you on, to verify? I have time to patch this, I suspect.

This was tested with bebopc-go v0.5.0

https://github.com/200sc/bebop/pull/45 adds blocking around the variables; I'm open to a prettier solution, i.e. tracking if tmp needs a := or = per function, but that might require a more significant overhaul of code generation to add some state tracking to a few functions.

@mirza-s If you'd like to take a stab at outputting some nicer code, and are happy to wait (or use 0.4.0 instead which shouldn't present this problem), I can hold off on merging that branch; what do you think?

Thanks for the quick fix. The current solution fine by me :+1:


Failed to import mqtt module after upgrading react-scripts to 0.4.1

I was using mqtt module with react-scripts v0.2.3 to build some sort of IoT web app. Everything was fine until I upgraded the react-scripts to v0.4.1. There was an error from the developer console:
Uncaught Error: process.binding is not supported from browser.js at line 173.
Removing the import mqtt from 'mqtt' or require('mqtt') solve the issue, but that's not what I wanted. Any help would be appreciated. Thanks in advance!

I can’t reproduce this on master.
I’m going to release 0.4.2 today.
If you still have issues with it, please provide a project reproducing it.

Ok then, I'll re-open this issue if I still have the same problem with 0.4.2. Thanks!

I still have the same issue with 0.4.2, here's the project repo: https://github.com/alwint3r/reweather. You can checkout to 0.4.2 branch on that repo to check the error, since the master branch uses 0.3.1 and everything works fine.
The file that causes the error is src/lib/mqttredux.js.

I can't reproduce this on the 0.4.2 branch of that repo.

I also can’t reproduce this on 0.6.0 branch of that repo.
If it doesn’t work, please delete node_modules and run npm install.
Maybe some dependency is stale for some reason.
Thanks!

I did remove the node_modules and reinstall the dependencies but nothing changed. I still see nothing on the screen but the same error on the browser console.
By the way, I am going to try another alternatives, since mqtt module is not my only option.
Thank you for your effort on this awesome tool!

I had the same problems with npm@2. The problem disappears with npm@3.

@aronwoost I also have npm v3 installed. What version of node are you using?

node: v4.5.0
npm 3.10.6

Try clearing npm cache before running npm install again.
rm -rf node_modules
rm -rf ~/.npm
npm cache clear
npm install

@aronwoost mine is exactly the same as yours.
@gaearon I did clear the cache but nothing changed.

This is super weird.
Can you tell me more about this message:
Uncaught Error: process.binding is not supported from browser.js at line 173.

Does it have a stack trace?

 And as far as I know, mqtt is not built with C/C++ code.
The stacktrace points to a file where I included mqtt module with import { connect } from 'mqtt' on the first line in src/lib/mqttredux.js

browser.js is here: https://github.com/defunctzombie/node-process

Also last comment here: https://github.com/webpack/webpack/issues/798
But it all made no sense to me...

I noticed the same problem with my colleague, that uses Ubuntu, node 6.6.0 and npm 3.10.7. On windows this app runs without any problems.
He tried to run app and got this exact error (process.binding), but he discovered that the problem lied with this package: superagent-xml2jsparser, which uses xml2js. Once he removed it, the app runs now.
Apparently it needs browserify.

Oh yes, I'm also using ubuntu 14.04 with node v4.5.0 and npm 3.10.6.
Thank you for the hint @themre! I'll get back to this issue ASAP.

Hi! Sorry for late response. I can not find both superagent-xml2jsparser and xml2js. However I managed to solve the problem by running my app inside docker container. I still have no idea why the app does not work on my host machine. But I think I am happy with my current solution, so I'm gonna close this issue now. Thank you and keep up the good work!

I'm having the same problem. Clean fresh create-react-app app and just import mqtt, I'm not even using it.

This is the same issue as https://github.com/facebookincubator/create-react-app/issues/1023 and https://github.com/facebookincubator/create-react-app/issues/815.
It was fixed by https://github.com/facebookincubator/create-react-app/pull/1194 and 0.8.2 contains this fix.

Great! I had no idea why this issue happens because there was no compile error. Thank you for your effort! You people are awesome!

Yea, sorry it was confusing.
Confused the hell out of us too, it took a month to get to the cause.

I didn't realize that there was no NODE_PATH inside the docker container. Now I know why it worked back then.
I'm glad that this issue is finally closed.


How do i pass options to the map object?

I have tried to add it to the amgCoreModule, but it isn't assignable.
I also tried adding it as a directive, but this doesn't seem to work either.
How do you pass options?

@aske-cph Please follow the getting started guide. You pass the options via inputs. If you have further questions, please use the gitter chat room. thanks


Slice32 improvements

Codecov Report

Merging #139 (aa431ce) into master (89a66dc) will decrease coverage by 0.2%.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master    #139     +/-   ##
========================================
- Coverage    73.3%   73.1%   -0.2%
========================================
  Files          33      33
  Lines        5504    5516     +12
========================================
  Hits         4033    4033
- Misses       1471    1483     +12

Impacted Files
Coverage Δ

src/slice32.rs
56.7% <0.0%> (-6.3%)
:arrow_down:

src/lib.rs
13.7% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a66dc...aa431ce. Read the comment docs.


nix profile install .#libzip  fails because there is no folder matching the "dev" output

Describe the bug
on nixpkgs b10adca6c87b78f2c6b2324474259087c3361cc1 with nix 2.7.0
nix profile install .#libzip
error: opening directory '/nix/store/3cxqmjp211rj1qyr7ys87cyli9fx21n6-libzip-1.8.0-dev': No such file or directory

because pkgs/development/libraries/libzip/default.nix contains  outputs = [ "out" "dev" "man" ]; and the dev folder doesn't exist.
If I remove the "dev" output then it works again. I can send a PR for that but I wonder if we shouldn't add some systematic check or workaround to avoid having the warning/

I started seeing these with my upgrade to nix 2.7.0 as well, lots of "error: opening directory" for outputs similar to but not part of my profile (-debug, -man, -dev) and as workaround just did nix-store -r $PATH for each :/.
I'm not sure of the cause, I was guessing something now expects these outputs as part of my profile.  Haven't confirmed happened with 2.7.0 vs not, if you're still experiencing this that might be good to check.
My guess/hunch was maybe it was packages I installed before adding keep-outputs to my nix.conf, which are now causing problems?
Anyway I'd guess it's a nix bug, but we'll see.
I wouldn't think changing outputs will help here, I'm not sure how it helped you.  As I remember it, the paths missing were outputs for paths already in my profile (not replacements/additions).  And that path above (the libzip one) didn't exist when you were doing your nix profile install, but it sure does in general for builders of libzip--it's available via binary cache with nix-store -r /nix/store/3cxqmjp211rj1qyr7ys87cyli9fx21n6-libzip-1.8.0-dev (and is non-empty).  So if the path exists, what is expecting it to exist (nix, presumably) and is that correct, and if it should exist then why doesn't it exist (failed to be realized?),
Sorry for some lack of clarity in the reporting above, I was trying not to debug this immediately :grin:.  But since you're encountering something similar, want to at least get a +1 to see if others are too.

I do think this is a bug in Nix itself, specifically related to how flakes are parsing the output parameter. I ran nix profile install on several packages with the outputs defined and got the same error, but don't get the error on any other packages.

should be closed by https://github.com/NixOS/nix/pull/6328 IIUC


Vehicles entering crossing only when previous one left is not matching reality

Is it intended behavior, temporary state or intended as permanent?
Because it result in drastic reduction of throughput on crossings, especially large ones.

Temporary bug. You could try running with the flag --disable_block_the_box. There's also a way to override it for individual intersections in allow_block_the_box.
I did some work yesterday to make vehicles ignore red lights if they start a sequence of turns through a group of adjacent traffic signals. This helps quite a bit with this general problem. I still need to update this to handle the "don't start a turn unless there's room" checks to better handle the short roads case.

note to self and others: cd game; RUST_BACKTRACE=1 cargo run --release -- --disable_block_the_box ("All the arguments following the two dashes (--) are passed to the binary to run.")

Consolidating gridlock bugs in #114


update developer guide to correct file path

What this PR does / why we need it:
Seems the sample file docs/samples/tensorflow.yaml in developer guide has been removed by PR #118 , the PR is to correct file path to point the tensorflow folder sample so that the developer guide is performable. Thanks.

This change is

/assgin @ellis-bigelow

Thanks for fixing!
/lgtm
/approve


Phase3 methods

New Client Methods:

GetNetworkDevices and GetNetworkDevicesAsync
GetNetworkDeviceTypes and GetNetworkDeviceTypesAsync
GetObjects and GetObjectsAsync

New Class:

MetasysObject - holds basic information about a Metasys object

Fixes:

Method headers
GetObjectIdentifier to use JToken to eliminate need for char trimming

GetObjects needs to be updated to recursively get and return all children. Need advice on what fields to include in MetasysObject.

The MSSDA bulletin specified that if no value for the item reference (in TraditionalClient's case the GUID) that the top level device should be used as the parent. I do not see an easy way of implementing this given the current API.

@SavannahEvans sorry I didn't provide more guidance on this. Probably the best way to handle devices and objects is to implement a fetch process which grabs all the pages of objects or devices for a particular device. This may be rather long running so we may want to cache it locally on the file system. A customer would only need to do a new fetch if/when they add/delete objects/devices.
This is probably the best we can do until 11.0 or 11.1 when there is a plan to add more query parameters to /objects /devices

@SavannahEvans, based on what I can see from the Metasys Launcher we could get the site root ID using a canonical FQR prefixed with the host, e.g. WIN2016-VM2:WIN2016-VM2/$site.  You can see below an example of the site object. @mgwelch, please we need confirmation if this is the preferred and reliable way to fetch the root.

@buldrinie It depends on what you consider the root. The root device is WIN2016-VM2:WIN2016-VM2.
What you referenced is the "site object", which contains some global site information. But it's not the root of the all item tree. The $ means it's a hidden object. We don't typically expose it directly to users

My idea was to expose the entire objects tree as in the navigator, but according to @mgwelch comments I think that makes sense to filter out only objects that are usable/relevant for the API. Fetching the NetworkDevices we have a starting point without knowledge of the specific GUID/FQR.

Issue #30 is for caching GetObjectIdentifier results. Since it is a smaller task I will focus on it for now. Once this is working I can implement caching for these calls as well.

Issue #30 is for caching GetObjectIdentifier results. Since it is a smaller task I will focus on it for now. Once this is working I can implement caching for these calls as well.

This is fine, but thru the API we really wanted to encourage users to always use the object identifier (not the FQR) to uniquely identify things. So for an Excel app user, for example, they should be able to lookup object identifiers at design time and then hard code the object ids into their apps so that they never need to fetch object identifiers again, and therefore you wouldn't need a cache.
Why do we want to encourage the use of object ids? Because once the work is complete they will be the only truly immutable unique ids in the system.
Now it'll probably be years before we achieve that vision in Metasys so relying on FQRs will be a requirement for a while. But we wanted to start getting people thinking in terms of GUIDs


add error coloring and fix some redundant vars

added memory monitoring
same as #545  but added WriteInColor

Too many changed files (Don't change everything to use new method, only the things where I used it in the code already are enough)
Keep 1 feature per PR (add memory in a separate PR, but i don't think we really need it)


Add Google login to comment section sample

This adds Google login to the comment section sample.
I added the client_id to run the project locally, this will need to be changed to the production before submitting.

@sebastianbenz I mentioned it in the docs and I also created new keys that will work on production.

@sebastianbenz Done, thanks!


[@sigma/node-image] Add crossOrigin to TextureManagerOptions

Pull request type
Check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Currently Sigma harcode the cross origin policy of the images rendered by node-image. Because of that it is currently impossible to fetch images that require authentification. I personally had to completly fork the node-image package just to change that one hardcoded attribute.
Issue Number: #1403
Related PR: #1393
What is the new behavior?
A crossOrigin attribute has been added to the TextureManagerOptions . This attribute is then passed to the functions that load images to set the crossOrigin attribute.
Other information
Another PR (#1393 ) is opened for the same feature but it's quite old and precede the creation of the TextureManagerOptions

I manually rebased and merged this PR, and GitHub didn't catch it. So, I'll close it manually.
I added one commit to make some minor adjustments on your modifications:
https://github.com/jacomyal/sigma.js/commit/93b83709ba4d9540230dd5793bd6b63fcd36b23e
Thanks for your contribution! It is deployed in<EMAIL_ADDRESS>


[Bug] Items cannot be dragged from one sheet to another

Items on our sheets lack the appropriate drag start handlers to provide the drag event with data on the dragged item. Dropping them onto a sheet therefore does nothing.
Dragging items from the sidebar or a compendium pack works, so the drop handlers are functioning appropriately.

As a note, a side effect of this issue is that we also cannot drag items from a sheet to the macro bar. These issues will be fixed by the same solution.


Implement starting equipment for base Artificer

The Ringmail armor in the starting equipment is heavy, which artificers aren't proficient with.

True, will change to medium and use a different name.

done


Tab Navigator nested in Drawer Navigator - Transition to tab navigation flow chunks

When I go from Map or Shuttle screens to the Main in my Tab Navigator the Drawer chunks as it is animating away.
Any potential causes of this behavior?
Thanks!
Dan
Code below:
`const tabScene = TabNavigator({
Main: {
screen: StackNavigator({
home: { screen: HomePage },
party: { screen: PartyPage }
})
},
Bands: { screen: BandPage },
Events: { screen: EventsPage },
CheckInPage: { screen: CheckIn },
},
{
initialRouteName: 'Main',
tabBarOptions: {
labelStyle: { fontSize: 12 }
},
navigationOptions: {
tabBarVisible: true
},
lazyLoad: false,
});
const MyApp = DrawerNavigator({
Wrapper: { screen: tabScene },
Map: { screen: MapPage },
Shuttle: { screen: ShuttleMap },
},
{
contentComponent: SideMenu,
});`

can you check in debugger how may actions are being triggered at that time?
you may use React-Native-Debugger for the same.

Going to close this since it's been stale for a few months now.


Version getters

This is an implementation for #501.
It is mostly a copy/paste adaptation of increment_build_number and increment_version_number to output the same variables.
Maybe this can be factorized a bit but I don't know how this can be done here.
First Ruby code contribution, so any feedback welcomed :smiley:

Looks good, thanks for the pull request. Could you also add some tests to the newly added actions?

I do not fully understand how this works yet :wink:
So, I need some hints on how to add tests.
Where should I look ?

@KrauseFx I may have found how to add tests :smiley:

Looks great, thanks for the pull request @Liquidsoul :+1:


Android emulator tests failing when run on machines without kvm support

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux linux_android_emulator_tests/2438/overview
07:59:38.837418<PHONE_NUMBER>05088 VERBOSE main-common.c:1359                 | CPU Acceleration: DISABLED
07:59:38.837438<PHONE_NUMBER>05088 VERBOSE main-common.c:1360                 | CPU Acceleration status: KVM requires a CPU that supports vmx or svm
07:59:38.837444<PHONE_NUMBER>05088 VERBOSE main-common.c:1373                 | handleCpuAcceleration: feature check for hvf07:59:38.837465<PHONE_NUMBER>05088 ERROR   main-common.c:1398                 | x86_64 emulation currently requires hardware acceleration!
CPU acceleration status: KVM requires a CPU that supports vmx or svm

This issue is sporadically closing the engine tree, so marking P0

cc @keyonghan

Deduping this to https://github.com/flutter/flutter/issues/136329


feat: info route

Before submitting

[x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Add info route as explained in issues 366. Tests were included.

Looking good @lorenzomassimiani! added few minor comments.

thanks to you, it's a pleasure to contribute to the project! @aniketmaurya


Would it be possible to tag a new minor version?

It's been quite some time since the last commit in the repository, and there are some useful changes since the last release that would be useful to have tagged. Would it be possible to just tag v0.6.2?, so that I can make other projects depend on a numbered version instead of a commit hash?

yeah, is a good idea.
https://github.com/gotk3/gotk3/releases/tag/v0.6.2

Great, thank you!


Adding Compatibility For Home Theater Channel Map Sets

Adding Compatibility For Home Theater Channel Map Sets
Description
Only stereo ChannelMapSets are parsed when pulling information from the zone group topology. This change enhances the parsing behavior to account for home theater setups as well.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you add tests for added code.

💔 Thank you!

Deepsource doesn't seem to like my use of any, though I was just following the established pattern of its usage. I can update this if needed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 81.363%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
1654

Relevant Lines:
1989

💛  - Coveralls

Deepsource doesn't seem to like my use of any, though I was just following the established pattern of its usage. I can update this if needed.

I was just trying out deepsource. Not sure if I want it turned on or if those issues matter. A lot of deepsource issues are on ignore anyway.
I’ll be checking your PR tomorrow, but at first glance everything looks alright to me.

You only forgot this:
@all-contributors add @jkossis for code

@jkossis do the satellite players also need some controls? Or are they only controlled by the main player? Can you change the name of such a player through the original app or is that not possible and are they seen as one player in the system?
Do you think changing sets in this library would be a feature you would use? Or is that something where you just have to get the official app for?

@svrooij to answer your first question, satellites are indeed controlled by the main player(coordinator). They are seen as one player when in a home theater setup.
I'm not sure I understand your second question ... what do you mean by changing sets?

I mean setting up the home theater configuration. Start with a playbar, speaker x should be back left, this should be the subwoofer.
Or would you always do those configs in the official app, since you only have to do it once?

@svrooij ah, gotcha. Yeah, my gut feeling is that functionality is probably best left up to the official app. I am not aware of the protocol/handshaking required to setup/maintain those relationships.

I think this change was more to enhance/fix the existing functionality that provides that channel set info. In my use case, I only want to show sub configuration in my app if the coordinator has a sub connected.

All looking good to me!


sct_create_mask: size should be in mm (currently in vox, but advertised as mm)

I believe this was handled by a1cfa5ce858deba9b27134e8c51eac8178e76703. Closing.


Packages still listed when running changeset, even if they are marked as private

When running npx changeset, I get a list of all packages, even ones that have private: true.
Looking at the docs, they advise against using the "ignore" field, however this is the only way to actually remove them from the CLI.
Is this the intended behaviour? If so, would it be possible for the ignore field to support globs? I have a bunch of internal testing and example packages which I don't want to version bump.

I think this is intended, still good to write changesets for packages only used internally

I also came across this. We don't version our internal packages. All other workspaces always depend on the current version.
Using the ignore field also does not work, as I have other workspaces depending on the ignored package.


[release/1.2.z][TC-1812]+[TC-1813] fix: dashboard/barchart fix rendering (#1772)

Backport of https://github.com/trustification/trustification/pull/1772

Merging it as it is a tested backport