Illegal class names

From documentation on CREATE CLASS:

<class> Defines the name of the class you want to create. You must use a letter for the first character, for all other characters you can use alphanumeric characters, underscores and dashes.

orientdb {db=test}> CREATE CLASS $
Class created successfully.

orientdb {db=test}> CREATE CLASS _
Class created successfully.

OrientDB version: 2.1.9-SNAPSHOT

Hi @sinfex
$ and _ are considered valid characters for an identifier, so it's not a bug.
I'm updating the docs right now.
Thanks for reporting
Luigi

@luigidellaquila out of curiosity, is it also fine if the class name starts with $?

No, $ is the prefix of variables.

@lvca then how come $ is a legal class name as demonstrated in the initial issue post and pointed out by @luigidellaquila?

Hi guys,
actually $ is a valid character for identifiers (and you can define variables in LET without $ if you want).
Let's talk about this, I can change it in 2.2
Thanks
Luigi


Add spacewalk assets to nova wallet

Note: This PR is only for internal review and not intended to be merged.
Closes Tasks/#257.
CurrencyIdScale can be obtained by forming any extrinsic call that contains CurrencyId in Polkadot.js, which shows the encoding details of the call.

About priceId, I was wrong since I thought it was regarding the chain where the price originates.
The fact is that, by looking at other registered assets and comparing, each one of them has it's own id. For instance, Polkadot registered in different chains will have the same priceId which is 'polkadot'. For this I would propose we use spacewalk-{asset_name} for the spacewalk assets that do not exists. The only id we can reuse seems to be usd-coin.
About the icons, they should all be completely white right?

@gianfra-t the icons should much visually the ones we have in  here

For this I would propose we use spacewalk-{asset_name} for the spacewalk assets that do not exists.

Okay thanks, yes let's go for that 👍
@annatekl have a look at any svg in this folder and you'll see how the assets are supposed to look like.

@gianfra-t here is the link with the icons

@annatekl the last link for the icons has color/black ones. I don't believe they will accept the PR unless they are in white format, like here.

Thanks! Yes to me they are correct. hopefully they will accept it.

I closed this as the PR for the upstream repo was created.


uninformative error message when wrong type is passed for citations list

In hindsight this is obvious, but took me a few mins to figure out.
If accidentally providing a citation, rather than a list of citations, when registering plugins or actions, the error message is uninformative. For example
plugin = Plugin(
    name="dwq2",
    version=__version__,
    website="https://cap-lab.bio/developing-with-qiime2/",
    package="q2_dwq2",
    description=description,
    short_description="Developing with QIIME 2 demo plugin.",
    # the following should be citations=[citations['DWQ2']]
    citations=citations['DWQ2']
)

$ qiime dwq2 --citations
Traceback (most recent call last):
  File "/Users/jgc/miniconda3/envs/dwq2/bin/qiime", line 11, in <module>
    sys.exit(qiime())
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 1686, in invoke
    sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 943, in make_context
    self.parse_args(ctx, args)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/q2cli/click/command.py", line 43, in parse_args
    return super().parse_args(ctx, args)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 1644, in parse_args
    rest = super().parse_args(ctx, args)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 1408, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 2400, in handle_parse_result
    value = self.process_value(ctx, value)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/click/core.py", line 2362, in process_value
    value = self.callback(ctx, self, value)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/q2cli/util.py", line 229, in callback
    citations.save(fh)
  File "/Users/jgc/miniconda3/envs/dwq2/lib/python3.8/site-packages/qiime2/core/cite.py", line 54, in save
    entry = citation.fields.copy()
AttributeError: 'str' object has no attribute 'fields'

It would be nice to either allow the former (so you can just pass one citation if you only have one), or have a more informative error message in this case.

Hey @gregcaporaso,
Good idea, and I think we can even do better, let's just support an individual CitationRecord in Plugin, *register_function, register_view/format, and register_transformer.


Add integration testing with OpenSearch

Is your feature request related to a problem? Please describe.
In a conversation here we said that security plugin relies on unit tests. Given how tightly coupled security is with many other plugins we may want to bring in some integration testing into the project and cover any dependencies.
Describe the solution you'd like
Integration testing run as part of CI.

Thanks @dblock closing this issue in favor of https://github.com/opensearch-project/security/issues/1761


Fine Tuning using the ESM model

Hi!
Thanks for making this model public! I have had a good amount of success using it to predict function similar to how your example colab showed. I was wondering if you had any insight for how I could use the model as is to fine tune on more specific data? I think I could pretty reasonably set up a masking function by setting some values to 0 and using the logits and softmax to get predictions, but if I wanted to do next sequence predicting would I have to add a lot to the current model or is there an output I could use? Eg If a sequence is MYA i want to only use the information before the predicted AA and not the entire sequence. EG to predict M i would use only the fact that its after a start codon, then to predict Y i would use the previous hidden state that knows there is a start codon and M etc for the whole sequence.

HI @wward97, glad to hear that you've found a good amount of success using ESM!
Am I understanding correctly that you'd like to use ESM to generate new sequences? One way is to perform several forward passes through the model. Concretely, to predict MYA, you could evaluate:

<bos><mask><mask><mask> -> predict position 1, corresponding to M
<bos>M<mask><mask> -> predict position 2, corresponding to Y
<bos>MY<mask> -> predict position 3, corresponding to A
In this setup, the model only has access to earlier amino acids in the sequence.

That said, while this setup would technically work, it's hard to say how strong the results would be, as this still an open research question. An alternative approach is to sample from the model using Gibbs Sampling. See Wang & Cho 2019 for a discussion of sampling from masked language model.
By the way, you mentioned that you'd set up a masking function by setting values to zero. You'll probably getter better results if you replace the input with alphabet.mask_idx, because that's the masking token we used for pre-training.

Thank you that is very helpful! Good point ill use the prebuilt masking method. Thanks for the quick response and the help!


Checked checkboxes rendered as unchecked

Gitea Version
1.16.0
Git Version
2.34.1.windows.1
Operating System
Windows 10 x64
How are you running Gitea?
I downloaded gitea .exe file from gitea website. Running it in console window.
Database
MSSQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
After upgrading from gitea 1.15.10 to 1.16.0 cheched checkboxes in issues rendered as unchecked
Screenshots
No response

It seems to happen only in MS Edge

Ufter updating to latest version of edge problem has gone

So this issue can be considered fixed?

If the glitch in Edge 82 is not important, then yes


Whitelist of Prometheus cAdvisor metrics

Following cAdvisor metrics are now whitelisted:

container_last_seen
container_fs_usage_bytes
container_fs_inodes_total
container_fs_limit_bytes
container_network_receive_bytes_total
container_network_transmit_bytes_total
container_cpu_cfs_periods_total
container_cpu_usage_seconds_total
container_memory_usage_bytes
container_memory_working_set_bytes

Other metrics will be drop when ingested by Prometheus.
Bumped version of Prometheus to 2.3.2
What this PR does / why we need it: Greatly reduces memory usage in Prometheus by dropping unused metrics
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Prometheus collects less metrics from cAdvisor

removed the dropping of terraform pods for the shoot's Prometheus

@mvladev still consuming way too much memory:
prometheus-0                              2/2       Running     134        18h

...
  containerStatuses:
  - containerID: docker://6ab28008c28035599615d8f18fd7d847407574066f69ee7ad20f3e2fca23db9c
    image: prom/prometheus:latest
    imageID: docker-pullable://prom/prometheus@sha256:7d99455a045a6c89c0dbee6e1fe659eb83bd3a19e171606bc0fd10eb0e34a7dc
    lastState:
      terminated:
        containerID: docker://18c48166e06996ddf594574e39fefb0427c92e448194425149be0d403a64c622
        exitCode: 137
        finishedAt: 2018-08-01T08:32:31Z
        reason: OOMKilled
        startedAt: 2018-08-01T08:25:35Z
    name: prometheus
    ready: false
    restartCount: 134
    state:
      running:
        startedAt: 2018-08-01T08:33:56Z


Warn the user if embeded links doesnt match text

I would like to have a warning if the embeded link is not the same as the text.
For example:
Text: google.com/search..
Url: example.com
in md format: google.com/search
=> warning  to the user that the urls doesnt match the texts "advertised" url.

I am not sure if it still should warn the user if the text is NOT a url for example here is the example

Maybe we could support a redirect page like what YouTube does?

What does youtube do? I don't think I'm familiar with what you mean.


Check if reports for current or previous month are not undefined

Coverage increased (+0.05%) to 90.947% when pulling d815e006a095ee051ce84c3a31251ecfb69f94e8 on SAP:fix_smoke_test into ddac2a0a0eddf435eaccb903370b017433be8e1b on cloudfoundry-incubator:master.


⚠ Bofrost.fr has degraded performance

In 5af09c7, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1490 ms

Resolved: Bofrost.fr performance has improved in 89f58fe after 6 minutes.


All my channels got removed because of tdlib

Hi, I tried to use Tdlib API for private purposes which is filtering & sorting data on my private channels(only for private usage).
So I was using WTelegramClient(C#/.NET) WTelegramClient | GitHub to get all chats(as a test request) and after this request I tried to send a second request but I got an exception message that says "400 PHONE_NUMBER_BANNED". I didn't flood nor spam anyone with this API and didn't do anything that is considered illegal in Telegram Terms of service.
I emailed the Telegram recover team, they didn't respond to me but the ban from my account was removed, when I logged in I realized that ALL my private channels where I was admin/owner disappeared. Then I checked on another account where I was a subscriber on those channels. It also disappeared from there. It should be a bug, owner's channels should not be removed when the account gets "deleted"(it was like this when the ban was applied).

WTelegramClient is unrelated to TDLib.
Account bans are also unrelated to TDLib. You need to follow up with the Telegram recover team about restoring access to the channels.

@levlam hi, but WTelegramClient uses Telegram API which is not tdlib? Maybe I got this wrong...
Anyway what I should do if Telegram recovery team don't reply to me few days? Wait more? Seems like they don't care :(

Yeah, I'm sorry I used Telegram API instead of TDlib, can I find it on GitHub?

TDLib is a library using Telegram API internally, so they aren't the same thing.
The Telegram recovery team is available only through email.

I emailed them yesterday, on my first message they replied in 8 hours, but on this new email related to channels they don't reply for a third day.
Sorry to bring this here but may be you know how much it takes usually to get a reply from them?

I emailed them yesterday again, on my first message they replied in 8 hours(which was on Sunday related to account unban), but on this new email related to channels they don't reply for a third day. Sorry to bring this here but may be you know how much it takes usually to get a reply from them?

How is this going? My account was banned recently also. If you got some response?

I emailed them yesterday again, on my first message they replied in 8 hours(which was on Sunday related to account unban), but on this new email related to channels they don't reply for a third day. Sorry to bring this here but may be you know how much it takes usually to get a reply from them?

How is this going? My account was banned recently also. If you got some response?

Hi, they unbanned my account and said that my channels were recovered, but it seems like channels were just recreated without any messages and all my info is lost, I hope they are still working on it.

Looks like Telegram don't want to fix it. No response... Nothing... :(

@bobacCurry did they respond to you?

No! I have not received a response yet , it's vary sad. I have test this some days, I found that they trend to ban some accounts  register recently.

No! I have not received a response yet , it's vary sad. I have test this some days, I found that they trend to ban some accounts register recently.

@bobacCurry did they respond to you?

No! I have not received a response yet , it's vary sad. I have test this some days, I found that they trend to ban some accounts register recently.


add custom rules and refactoring

User Story
As a user Using kubeeye in a production environment, we not only uses OPA rule validation, we also used

check nodes ssh conntecion
kubernetes certexpire
check Component startup configuration consistency，such as kubelet command line parameter --root-dir.

and so on.
While meeting the above, we also hope to extend it with out of tree.
Detailed Description
Based on the above points, we extend kubeeye and refactor the code.
Feature Description
We have added the following features
custom command
Expand kubeeye's command line
Embed Rules

Embedded rules, package the rules into kubeeye for easy use

OPA rules
Function rules

Function check rules provide more customized rule checks. For example, by using a shell and calling a third-party interface, you can enclose the function and return the output according to the agreed format, which can be displayed uniformly in the report.
Why
custom command
On the one hand, kubeeye can be programmed into subcommands of other command-line tools. On the other hand, other command-line tools can also become kubeeye tools.
Embed Rules
Checklist are different in different environments and different businesses, But they have something in common, If it is maintained only through an external directory, it will lead to redundancy of the checklist. Therefore, we can package it as a whole and control the start and stop of the business checklist through the configuration file later such as
apiVersion: v1
kind: ConfigMap
metadata:
  name: kubeeye-<xxxx>-rules
  namespace: kube-system
data:
  version: "v1"
  regorules: |
    enable:
      - name: allowPrivilegeEscalationRule
      - name: canImpersonateUserRoleRule
    disable:
      - name: "*"
  funcrules: |
    enable:
      - name: nodeSSHConnection
    disable:
      - name: xxxxStatus

Configuration file feature is still in progress.
How
custom command
A kubeeyecommand is defined using the builder pattern, You can assemble it with any command, regorule and funcrule，Finally, a cobra command line is returned.
Embed Rules

The OPA rule uses go1.16 embedded, It can package files into code compilation. Whether default rules or additional rules,You must use a variable to package OPA rules.
Function rule is much simpler, Because it is go code itself, it can be packaged and compiled directly through import.

Refactor Description
In order to better add new features, we have adjusted the code structure.

Added directory funcrules, regorules, register
Funcrules: Storing default function rules
Regorules: Storing default regorules rules
Register: rules register

Use go channel mode, Fan In to connect pipeline in series, The main entrance is audit.Run

Use fs.FS abstracts local file and embedded file operations

Simplifies the function of output

Some channels have been merged

Anything else you would like to add:
https://github.com/leonharetd/kubeeye is refactor kubeeye code
https://github.com/leonharetd/kubeeye_sample is kubeeye sample
These are some of my practices. Welcome to communicate. Thank you very much🙏.

Looking good to me. Hi @pixiake @ruiyaoOps , please help to give feedback on this user story and extension.

Yes, Custom rules are a good idea, and we will verify as soon as possible.
And it is necessary to check the environment, whether  k8s or Docker or kernel settings, and we will implement it later.
About managing checklist files through ConfigMap, I don't think so. After the audit, we should reduce the residue on k8s. It may not be the best way now, but we will keep trying to find it.

👌，Configmap is not necessary, but I want to have a configuration to control the checklist, or provide a checklist command, such as kubeeye checklist, and then the subcommand kubeeye checklist disable / enable？

We plan to use the UI to implement the function of the management rules and display the results, but it has not yet been implemented.

Good, there is no checklist config in this version. What else can I do? I'm glad to help

Need to wait until January, it's busy now

hello @leonharetd
I reviewed the code, and thanks for your help and support in optimizing the code structure. It was one of the tasks, I will incorporate it into the code as appropriate.
Regarding the check of the expiration time of the certification file, in the code, I marked that it will be recorded, because the current check method is wrong, and I will rewrite it next.
About the cobra, I found that you have rewritten cmd. Can you tell me why we should do this?

I think it is a good way to improve the flexibility of KubeEye. I think you can submit a pr.


[BUG]  1.12.2 doesn't work.   Nothing from Cleanse shows up in the latest.log, either.

Hi there. I have Cleanse 1.12.2 - <IP_ADDRESS>.
[Cleanse]: Reenabled adding new chat lines never shows up in the latest.log file. In fact, I don't see Cleanse doing anything in the latest log at all.
I would happily pay you for your time to see if you can get this working! This is the only mod of its kind out there.

Huh, I am assuming you did put the jar in the client mods folder with forge installed.
Does cleanse show up at all in latest.log?
Would appreciate if you just send it also (ugh I did not set up issue templates for cleanse where I ask to attach the file)

Yes, it is of course in the mods folder.
latest.log
Cleanse does show up. It does the version check, but nothing beyond that.

Ok im looking into is, takes a while to fight gradle to setup the 1.12 workspace
Meanwhile if this is a public modpack can you share the name, or DM me (in discord) an archive, because hopefully I didn't put out a version that plain does not work :) I always check at least if the line shows up in logs, but don't remember if I did so for 1.12 lul

So I just tested a small "modpack" with Cleanse, and a few mods that I know paste their text on worldjoin.
However, cleanse worked in this example perfectly. Nothing showed in the latest.log, however, except the versioncheck.
So, I don't think the 1.12.2 version adds anything to the latest.log, but it still functions in a small modpack.
That means, there is something in this modpack of mine that is preventing Cleanse from working? Not sure why that would be the case. I've set the ticks to 25 seconds (500 ticks) and it always shows the text on join.
What's your discord? I'll see about sending a copy of the modpack.
Here's a trailer: https://www.youtube.com/watch?v=X8EpwHdR62k&ab_channel=Finecraft%3AEnhancedSurvival
Here's the Wiki: https://github.com/roccscout/Finecraft/wiki

Ok after spending a lot of time I've came to the conclusion that it's impossible to run 1.12 on NixOS, omg
Or at least pretty hard, ugh
I actually have an idea of what may cause this - you must have a mod that changes the main menu?
I can see how that can potentially break cleanse (I detect the main-menu -> world transition to start the timer and anything -> main menu to reset it)
The discord is this, you can also ask for help (about my mods anyway) from people there :)

It was indeed caused by Custom Main Menu mod, closed in 5cc9bac


Autorest doesn't support list of list in XML

That was never supported, and being that doesn't exist yet, making this a low-priority bug.
But still create it for honesty :)

Will just re-open if one day this becomes a real thing


feat: Add NoAtoms instances for product measures

The instance exists for Measure.pi, see MeasureTheory.Measure.pi_noAtoms',  but not for Measure.prod.

Thanks!
bors r+
maintainer merge


Unknown identifier HOST_TO_BE16

Try to build for target beckhoff CX9010, twincat 2.11.2303

You need the "TwinCAT TCP/IP Connection Server" / "TcpIp.Lib"

You need the "TwinCAT TCP/IP Connection Server" / "TcpIp.Lib"

I have it.

I added TcUtilities.lib and problem was solved.


support fro leptos 0.5.x betas

This change just happened: https://github.com/leptos-rs/leptos/pull/918

If you want to switch to leptos 0.5.0-beta you can use this branch: https://github.com/Baptistemontan/leptos_i18n/tree/leptos_0.5_beta
I will close this issue with a PR merging this branch to main when leptos stabilize 0.5.x

I've created a branch with leptos v0.5.0-beta2 and with the changes comming in v0.2.
Those changes being:

The removal of i18n.json, the configuration is now in the cargo manifest.
Plurals are now declared in a sequence instead of a map in the json file.

Any feedback on those changes would be appreciated!


upgrade runtime to 1.9.0.-rc.1 and add pluggable comp crd

Signed-off-by: Pravin Pushkar<EMAIL_ADDRESS>Description
Upgrade runtime to 1.9.0-rc.1
Changes the CLI config tests to mimic the output due to the following PRs:
https://github.com/dapr/dapr/pull/4999
https://github.com/dapr/dapr/commit/d0ba330815d79e1bfbc740b7ad509ed30501844e
Changed annotator.go to get PatchOperation from correct package -> https://github.com/dapr/dapr/pull/5084
Changed api logging format : made CLI test more resilient to changes in log https://github.com/dapr/dapr/pull/5247

This needs to be merged and go-sdk rc released for unblocking CLI release https://github.com/dapr/go-sdk/issues/291


Add overload method for validate which accepts reader

Method for convenience
Such that a reader of choice can be passed (e.g. a buffered string reader) instead of the whole xml as a string.

Nice!


Copy rect crashes?

it appears that attempting to use the copy-rect PLOT call with out-of-bounds positioning can cause crashes
this should be verified, and code put in place inside vdp-gl to ensure that calling canvas->copyRect does not crash
behaviour for the PLOT call should be ensured to work the same as on Acorn systems

genericCopyRect inside vdp-gl's displaycontroller.h, which implements this functionality, does have code in it that attempts to ensure that clipping is respected - however this logic only applies for destination coordinates, and not the source.  it is therefore possible to set source coordinates that are out of bounds (i.e. not within the current frame buffer), which will cause a crash

this has been addressed via #245
the solution in that PR is to ensure that the call to canvas->copyRect will only ever use source coordinates, and rectangle size, that are within the screen bounds.
arguably genericCopyRect inside vdp-gl should also be updated so that ensures source locations stay within the screen coordinates, but it's simpler to just address this inside this repo 😁


Add CSS components

So that curves can be applied at css level without having to call the getCurve() method.

Added two sets of classes - one set for setting easing (transition-timing-function) and one set for setting transition-duration rules. Please try and let me know if this works.


current_user.can? helpers

After setting up pundit, I found it inconvenient to use the default 'policy' helper in views as I would often be testing for authorizations against different models than the one loaded by the controller. I like the current_user.can_xxx? syntax used in many authorization libraries so I came up with a simple concern to add these helpers to a user model.
It can be cleaned up a bit but is this something that might be accepted into the library if I put together a pull request?
module PunditUser

  extend ActiveSupport::Concern

  def method_missing(meth, *args)
    if meth.to_s =~ /^can_(.+)$/
      Pundit.policy!(self, *args).send(meth.to_s.sub(/^can_/,''))
    else
      super
    end
  end

end

Sorry to resurrect an old thread, but I've just started using Pundit, and I was inspired by this idea.
I've simply defined a can? method on my User model, as follows:
def can?(action, object)
  begin
    policy_method = "#{action.to_s}?"
    Pundit.policy!(self, object).send(policy_method)
  rescue NoMethodError => e
    policy_name = "#{object.name.to_s}Policy"
    logger.debug "Undefined Pundit policy method: #{policy_name}##{policy_method}, returned false by default"
    false
  end
end

This gives me about as much magic as I need, because the goal was to be able to do the following in the view when I'm trying to render items for a global navigation menu:
<% if current_user.can?(:search, User) %>
  <%= link_to "Users", users_path %>
<% else %>
  Users
<% end %>

Thanks for a great gem @jnicklas, the lack of magic is helpful to my understanding of it so far.


feat: remove cli-ux

What does this PR do?
Removes cli-ux in favor of the ux methods on SfCommand
What issues does this PR fix or reference?
@W-10487585@

QA
✅ sf env list shows correct output
✅ sf env list --json shows correct output
✅ sf env display shows correct output
✅ sf env display --json shows correct output


[Feature] Profile Improvements

We need to do some small changes to the profile to improve UX.

[x] Add disclaimer when Editing User Profile:
We had the assumption from user bug reports that some users were editing their profiles to change their credentials, so we're adding a disclaimer to the profile page that editing their profiles will not change their credentials

[x] On edit mode, replace "nickname" to "Full name"
Currently, users can't edit their full names on profile, but are allowed to edit "nicknames" that don't display anywhere. We want to use the field to now show and allow editing of their Full Names.

[x] Show login method in User profile
To help users remember how they created their wallets, we are adding a component to the profile which shows their login methods.

[x] Replace FaceID image for icon
On the profile, we're using people's uploaded image as an icon for their FaceID. That is incorrect, and also displaying square. We want to replace it for an icon, round in shape.

Figma for all changes above: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-💵?type=design&node-id=9799-42332&mode=design&t=uIGGsZjdGb7TN3HW-0

@L03TJ3 @patpedrosa Do we want to keep this "note" on the "My Profile" page and on the "Edit profile" page? According to the design the note should be displayed on the Edit profile page
Also, the Login method is missing

NOTE: Also, to see the login method you should logout, do a hard reset and clear the cache, then login (do it 2-4 times to see that)

@patpedrosa @decentralauren
I forgot to share this..
Basically we never really stored anywhere someone's used login-method. it was just saved as 'torus' (which says nothing to the user).
So in order for the login-method to show I needed to add a new flow during login/sign-up where this get stored/saved.
Meaning, that login-method would not show anything for an already logged-in user up until they re-login
(I will look into vlad's reported bug)
How to handle this? Should we just hide the whole block when we don't know the login-method (yet) ?

we are saving the login method in our user database via the backend
(goodserver)

reading from database is made a separate issue here: https://github.com/GoodDollar/GoodDAPP/issues/4169
Rejected points from UAT:

[ ] - save button looks disabled (but is usable) when editing phone/email
[ ] - don't show full-name on main profile view (only show in edit mode)

@vldkhh this can be retested on dev

it should now show a verify button for the phone/email fields
save button (next to avatar message) only shown when full-name is editted

@L03TJ3 @vldkhh I keep getting stuck at the OTP (it keeps timing out and not sending). Happy to test once pushed to prod if it works well for everyone else!
Yay :)

OK I found 3 issues:

[ ] Display issues in "View" mode on my device (iphone 12 mini - same issue that was present prior)
[ ]  Verify button appears if user re-enters same email or phone number, however does not allow user to proceed.
[ ] after re-verifying email, I was brought back to the "View" mode rather than to the "Edit" mode displaying my updated verified email

(I have slacked a video describing these items to @vldkhh and @L03TJ3 as it has PII)

@decentralauren above points got discussed or fixed and is already released. so is this feature review done and we can move this ticket?

@L03TJ3 Yes! Please close this ticket and thanks for following up.


Update documentation and one import, to use the consistent name of Vector2

This PR (delete as applicable)

Updates the Documentation

Describe the changes below:
Update documentation and one import, to use the consistent name of Vector2
There were examples that used Vec2, which wouldn't work. For example An array of Point or Vector2 objects: [new Phaser.Math.Vec2(x1, y1), ...] was not copy and pastable.

👍


Black screen on all headsets

Thank you for this.
Issue: Native Vulkan OpenXR (SteamVR/Oculus) as well as WMR via OpenXR-Vk-D3D12 give black screen.
 I opened issue with the developer of OpenXR-Vk-D3D12. He tested it with a Quest 2 and a native SteamVR head set, both of which support native OpenXR Vulkan. He too got black screen.
His conclusion was that the issue seems to be with VRScreenCap?
OpenXR-Vk-D3D12 Issue Thread here
Full reply from developer:
_Hello,
I have downloaded v0.1.0 of this application from here: https://github.com/artumino/VRScreenCap/releases/tag/0.1.0
I have tested it with:
Oculus Quest 2
SteamVR OpenXR runtime

Both of these OpenXR runtimes natively support Vulkan (ie: can be trusted). I get black screen for both.
As far as I can tell, the issue is not with OpenXR-Vk-D3D12, since the app is giving me a black screen with 2 fully qualified OpenXR runtimes.
Please contact the developer of that application._

Hi, right now if no geo-11 game is running when VRScreenCap is launched nothing will be shown on the screen.
Have you tried closing VRScreenCap, launching the game, and then relaunching VRScreenCap?
There should be an output.log file near the executable with some information on what's happening.

output.log
Please find attached. Game is running and works fine with katanga.

Update: It works!
I clean installed the game, the fix, geo-11; then made manual changes to the .ini files to the point where a TaB image shows in screen as when Katanga works. I can't pinpoint the exact cause of earlier failure.
Only problem now is that the screen is very washed out - blacks are very light gray?
If I exit VRScreenCap and open Katanga instead, colours re perfect.
Suggestions appreciated, thank you.

It's probably a difference in colorspace that I'm not accounting for, can you attach the log of a working instance again?
Also what game is it?

output.log
Game = Visage.
Thank you for your work.

I can confirm I was doing the color space calculations wrong, should be fixed in the next release

Just published version 0.2.0, it should fix the issue

Thank you - one of our cummunity members reports it as working... and wishes for a way to centre the screen... but that is another issue completely.
We're greatly looking forward to seeing more development of this app if you have the time - thank you :)

Thanks for the report!
In theory, the recentering logic should be handled by the OpenXR runtime, although I've noticed that in SteamVR the "Recenter Seated Position" has been moved to a menu only accessible from the desktop. I'll surely consider adding an in-app recentering mechanism.


Update CONTRIBUTORS.csv

[X] Accept the Ockam Contributor License Agreement by adding your Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate new pull request to the build-trust/ockam repository.

@FreemRL We'll merge this shortly.
Thank you for accepting the CLA and taking time to contribute!!
Welcome to the Ockam Community 🥳
If you have questions, as you explore, join us on the contributors discord channel https://discord.gg/bewvnm6zqS


Add YAML support

Add YAML support.

Oh yeah! No one does it better than @muhang! @muhang does it better than anyone, yeah! Yeah! On balance, off balance, doesn't matter. He's better than you are, yeah and I'm talking everyone in the World Wrestling Federation. And I'm even talking to President Jack Tunney, yeah. @muhang is on his way to the top and nothing is gonna stop him. Nothing's gonna stop him. Yeah. Cream of the crop!

 The sky's the limit, and space is the place, and NO MAN ASSIGNS THE MACHO MAN SUPPORT TICKETS, @bww!


Make USE_MLAS macro conditional on cmake flag for consistency with other options and make it ON by default. It was already enabled by default today.

So, you want to have the ability to turn it off? Is it the main reason of this change?

So, you want to have the ability to turn it off? Is it the main reason of this change?

2 reasons: consistency with how other options are enabled/disabled and second yes, i would like to keep the option of turning it off open.


Review methods names improving fluent interface

Migrate some remaining getX() methods throughout the code (keeping them deprecated) to the x() form. They read much more more like a "lite" Java, ruby-inspired, and read better as fluent interface.

We should also avoid prefixing accessors with get or is, or prefixing mutators with set.
Accessor and mutator methods for boolean values should read as verbs in passive voice (or adjectives). Examples:
public boolean frozen();
public boolean modified();
public boolean saved();
public boolean valid();
public boolean paused();
public void paused(boolean paused); // mutator

Accessor and mutator methods for non-boolean values should read as substantives/nouns. Examples:
protected Map<String, Object> attributes();
public String query();
public long time();
public String message();
public void message(String message); // mutator

@ericbn I would suggest that we add these (need to review each one), but also provide standard methods, such as isFrozen, with "get" and "set". Consider two versions of the same synonyms.
My logic is as follows. I personally prefer simple ones as you know. However, this is strange for most Java developers. Another positive that comes from having getters and setters is autocomplete. IDEs offer a list of all methods that are mutators or accessors if you type model.get an type Ctrl+Space.

there are quite a few synonyms like in JavaLite, but there was never a systematic approach to them.

@ipolevoy, I don't think we should have two versions of each method, for that would mean LOTS of duplicate code. I think that would go against the idea of a light and simple framework.
Even a simple class will be affected forever:
public class QueryExecutionEvent {
    private final String query;
    private final long time;

    public QueryExecutionEvent(String query, long time) {
        this.query = query;
        this.time = time;
    }

    public String getQuery() {
        return query;
    }
    public String query() {
        return query;
    }
    public long getTime() {
        return time;
    }
    public long time() {
        return time;
    }

}
But I agree completely -- and that was the idea behind this issue -- that we need a systematic approach. We have a if (Util.blank(str)) on one hand and if (model.isFrozen()) on the other. It would be good to stick to one approach and use it everywhere -- and I mean 100% of the code by that.
I think it is up to you to decide which one must be followed.

@ericbn , you do not need to replicate code:

    public String getQuery() {
        return query;
    }
    public String query() {
        return getQuery();
    }

We do have some of this code in the framework already. I'm split which way it needs to go, as both approaches have pros and cons.

Also, removing methods is something that you want to  do, but that will force people using the framework to make code changes. For many, that will be an annoyance and unnecessary superficial changes. When Play rolled a new release v 2.0, many abandoned using it for that same exact reason.

@ipolevoy, I call replacing an API by a better one "evolution". That's how products get better over time... Most major version changes imply a different API.

@ericbn , this is more like spinning the wheels, since the best way to make the project  better is to place it into hands of more developers. This is where we need to channel the energy :)


(MAINT) bump ruby version

FYI - I'm fully expecting the tests to be a sea of red here.
This PR is one step in a series of clean up PRs.


Auto Updater isn't working

logs
[PriconneReTL AutoUpdaterApp version: <IP_ADDRESS>]
[Log file created at: 11/3/2023 9:50:53 PM]
[11/3/2023 9:50:54 PM] - Found new version! Starting update...
[11/3/2023 9:50:58 PM] - Downloading compressed patch files...
[11/3/2023 9:50:58 PM] - ERROR: Error downloading patch files: An invalid request URI was provided. The request URI must either be an absolute URI or BaseAddress must be set.
[11/3/2023 9:50:58 PM] - ERROR: Update failed!

LogOutput.log (i'm not sure if this file got replaced with new one, because i just update it manually using PriconneReTL-Installer 1.3.0)
i'm trying to update from Pricone UI EN DMM v20231024 to the latest version

Thanks.
Yeah this file gets replaced on every game start and as you don't have the autoupdater anymore, this doesn't have what I was looking for anymore unfortunately. + updated to the latest version, so reproducing the error would require some manual modification of the tl patch. (I can tell you how if you wanna try again)
I'll try to improve the logging in the aautoupdater and maybe you can try it again (worst case the next time a new tl patch version is released.)
Sorry for the inconvenience, the code of the autoupdater is based on the installer, so I wonder what could've gone wrong there.

Maybe i can reproduce the error in PriconneTL next update.

LogOutput.log
this is the new BeplnEx log when i'm trying to use auto updater

Aaah god I have totally not considered paths that have spaces in them.
I'll fix these soon.
Thanks!

I released 1.0.1 of the dll file:
https://github.com/tynave/PriconneReTL-AutoUpdater/releases/tag/1.0.1
Can you please test it and let me know? Thanks!

It's good now, the patch installed successfully!

Glad to hear!
This issue is closed then. Let me know if you run into any more trouble, hopefully not ;)


3D shape volume calculator not working

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
Issue - When we select any shape , there no functionality further. So i want to modify this to work properly . Also improve UI
Screenshots
https://github.com/Rakesh9100/CalcDiverse/assets/126979961/446eec6b-353e-4f3f-b4ec-03858dfed7c0
Code of Conduct

[X] I follow Contributing Guidelines of this project.

@sanketshinde3001 Proceed!!

It was just a minor issue in script tag in the file. Pls work on other good issues @sanketshinde3001


Error while testing on Windows 10

When I run the code
python run.py --prototxt mobilenet_ssd/MobileNetSSD_deploy.prototxt --model mobilenet_ssd/MobileNetSSD_deploy.caffemodel --input videos/example_01.mp4
It starts the video, but as soon the person gets to the line, everything crashes with error:

[INFO] Starting the video..
Traceback (most recent call last):
File "run.py", line 345, in
run()
File "run.py", line 160, in run
rect = dlib.rectangle(startX, startY, endX, endY)
Boost.Python.ArgumentError: Python argument types in
rectangle.init(rectangle, numpy.int32, numpy.int32, numpy.int32, numpy.int32)
did not match C++ signature:
init(struct _object * __ptr64, long left, long top, long right, long bottom)
init(struct _object * __ptr64)

Thinking that could be a problem with dlib installation. Did you install /build it with pip install dlib? I believe you also need cmake and visual studio to build it on Windows.

Yes, I had problems with dlib. So I downloaded some older version.
I had visual studio and cmake installed on my computer, but it still didn't work.

What is your dlib version and how did you install it? Mine is 19.18.0.

19.5.1

Ok, let's do a reinstall with `pip install dlib', can you let me know if any errors? Make sure to uninstall the existing dlib version first.

It works now. I updated the visual studio too. Thanks

Great, thanks.


Add .Move() overload that takes a Range

I'll look into this 😊

@viceroypenguin,
Would you like the tests in a separate file to MoveTests.cs? Also, should it be unreleased or released for all targets?

The tests should be in MoveTests.cs, below the existing tests; since the Move() overload will be in Move.cs below the existing overload of Move. The new APIs should be unshipped, since they're brand new. They get moved to shipped when I do the 5.4.0 release. Good questions, thanks!


Can I use normal icons?

For the icons it asks for a path, but I'm just using the default icons that flutter has. Is there a way to change them into a path?

I also have this question.

Sorry for the delay. I used first SVG to be able to have more complex animation (SVG animation paths) but for now it's not possible due to an issue in the library.
So yes I think, I can add a way to use normal icons.

I just added this feature please have a look at pr #21

The PR #21 has been merged and published to pub.dev, enjoy!
Thanks to @umaqs


Homebrew package

I do not really know how to build from source this software… for non-experts like I am, it would be great to have a Homebrew package for this utility

how to install this JXLook indeed, i have no clue
please explain in the .readme

you can download an old (non M1) version here: https://github.com/yllan/JXLook/releases/download/v0.1.1/JXLook.app.zip
found it on: https://www.reddit.com/r/jpegxl/comments/l4jlr8/jxlook_minimal_jpegxl_viewer_on_macos/


Service other tunnels

I made a little differenciation between access=private + access=no (same rendering) and service=driveway.


Refactored settings code.

Added a utility function (setSettingsString) to avoid repetitive logic.

Great idea - but this coding pattern exists in other locations as well. I think we should add a setStringIfNotNull(String), setIntIfNotNull(Integer), and setBooleanIfNotNull(Boolean) to the Settings class.
Thoughts?
Jeremy

Sure...  Centralizing this logic into Settings sounds wise.

Please see PR #402.  This PR is now obsolete.


DF Scene Enhancements: Navigate from Journal causes all Journal links to ignore permissions

Module
DF Scene Enhancement and v3.3.2
Describe the issue
When the Navigate when a Scene reference is clicked in a Journal option toggled on, links from one Journal to another bypass journal permission checks.
This is a pretty serious issue with my workflow, as players were able to access GM only notes accidentally when clicking on a link included in a Journal that I shared with them.
To Reproduce
Steps to reproduce the behavior:

Install FoundryVTT 0.7.9
Install and activate DF Scene Enhancement v3.3.2
Create a player to test with, and log in using a private window
As the GM, create two journals (journal 1 and journal 2)
Edit journal 1
From the Journal Entries side bar, drag journal 2 into the contents of journal 1.
Save journal 1
Click Show Players
As the player, you should now see journal 1 with a link to journal 2
Click journal 2

Expected behavior
When you click journal 2 you should receive an error: "You do not have permission to view this JournalEntry sheet."
To see the correct behavior, go to the module settings and uncheck the first option.
Screenshots
As the GM

As the player, showing Entry 2 after having clicked it from Entry 1. The Player does not have access to either of these Journals and was only able to see Entry 1 because I clicked Show Players.

No errors were in the console.

Thank you for reporting this issue. I'll have to take a look and get it fixed. Unfortunately this week is a bit busy for me, so I may not be able to get a fix in until the weekend.

I just pushed out v3.3.3 that should have this fixed. Please try it out and let me know if you have any more issues 👍🏽

@flamewave000, sorry for the delay. I wasn't able to test until today. It looks great! Thanks!


text and styling updates for widget drawer

Description of changes:

Change font sizes
Make option cards stretch to align
Update texts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1929 (cc05403) into main (273ab78) will decrease coverage by 7.23%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

:exclamation: Current head cc05403 differs from pull request most recent head e3cd5c0. Consider uploading reports for the commit e3cd5c0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   69.74%   62.52%   -7.23%
==========================================
  Files         439      281     -158
  Lines       13351     7181    -6170
  Branches      986      986
==========================================
- Hits         9312     4490    -4822
+ Misses       3861     2513    -1348
  Partials      178      178

Flag
Coverage Δ

metapi
?

metweb
62.52% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ement/form/EngagementWidgets/WidgetOptionCards.tsx
100.00% <ø> (ø)

...EngagementWidgets/Documents/DocumentOptionCard.tsx
88.88% <100.00%> (ø)

...form/EngagementWidgets/Events/EventsOptionCard.tsx
86.48% <100.00%> (ø)

...ement/form/EngagementWidgets/Map/MapOptionCard.tsx
86.48% <100.00%> (ø)

...form/EngagementWidgets/Phases/PhasesOptionCard.tsx
88.88% <100.00%> (ø)

...ngagementWidgets/Subscribe/SubscribeOptionCard.tsx
59.45% <100.00%> (ø)

...t/form/EngagementWidgets/Video/VideoOptionCard.tsx
59.45% <100.00%> (ø)

...idgets/WhoIsListening/WhoIsListeningOptionCard.tsx
88.88% <100.00%> (ø)

...nts/engagement/form/EngagementWidgets/constants.ts
100.00% <100.00%> (ø)

... and 159 files with indirect coverage changes


[WIP] Added non default arg warning for start_offset_samples & …

…stop_offset_samples in create_fixed_length_windows. Set default arguments to None. #269

So now we want:

window_stride_samples and window_size_samples and drop_last_window should be None by default
in case window_stride_samples and window_size_samplesare not None , but  drop_last_window is none raise an error and inform the user he should set drop_last_window.
if all three are None, assume each window should span the entire recording
if all three are None, but recordings are of different length, give a warning to the user that these different-length windows will not be aggregatable into a batch
Finally restore argument order as before and keep warning for start_offset_samples / stop_offset_samples which are not None

if all three are None, but recordings are of different length, give a warning to the user that these different-length windows will not be aggregatable into a batch

This check is independent of drop_last_window=None. Raise the warning whenever we observe different length windows.


Double barrelled surnames can be found

Situation 10 Dec 2020
Search for CHANDOS finds Reginald W CHANDOS PELE (and his family, and others with this name, also CHANDOS-POLE and plain CHANDOS)
Search for PELE finds the CHANDOS PELEs
Search for  POLE in Staffordshire 1861 finds Reginald CHANDOS-POLE (at Repton, DBY).
Is there any other test needed or can this be closed?


Resolve #157 use array in plot

Closes #157

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 4 (25.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.695%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pygef/plot_utils.py
1
4
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1345

Relevant Lines:
1483

💛  - Coveralls

You still need to apply black formatting.

Yes, can we add that in the Makefile.
Or use the cemsdev.
Building super-linter is not the most easy thing to run locally without the environment variables in a config file.


Feature request: Parse all URLs or links that may be assets

One issue that I'm running into is the following:
My source markdown looks like this:
![vimtutor](./videos/vimtutor.webm){ width=100% loop="true" autoplay="true" }

And the following gets generated from the above markdown:
<video src="./videos/vimtutor.webm" loop autoplay style="width:100.0%" controls>vimtutor</video>

When running it through this svelte-preprocess-import-assets, the following gets generated:
<video src="{___ASSET___0}" loop autoplay style="width:100.0%" controls>vimtutor</video>

Ideally, it would become
<video src="{___ASSET___0}" loop autoplay style="width:100.0%" controls>vimtutor</video>

More generally, right now if I have the following markdown source:
This is a [link to an image](./images/example.png)

![rendered image](./images/example.png)

i.e. the following HTML source

This is a link to an image

rendered image

When running through this svelte-preprocess-import-assets, the following gets generated:

This is a link to an image

rendered image

This results in the link not working even though the image is rendered correctly.
It would be nice if all links to the same asset are replaced with the imported asset.
Feel free to close if you think this is out of scope for this plugin.

This one's tricky since the preprocessor currently doesn't check a tag at all as it may contain any link that's not necessarily an asset. If we do want to check the a tag, we would have to keep a list of known asset extensions and go from there, but yes I think this is going out of scope of the preprocessor.
For now, you should be able to still get it working with a custom source like:
{
  sources: (defaultSources) => {
    return [
      ...defaultSources,
      {
        tag: 'a',
        srcAttributes: ['href'],
        filter: ({ value }) => /\.(png|jpg|gif|webm)$/.test(value)
      },
    ]
  },
}

Closing this as intended behaviour for now


Create MoM-2023-03-14.md

@bigludo7 I integrated your minutes. Please review and we are ready to merge. Thanks!


Tagging Strategy

Docker doesn’t have wildcards like in composer or gradle but they can move the tags so, more less we can accomplish the same. An example: https://hub.docker.com/r/library/postgres/
When we publish the v1.0.0 we must create 3 tags: 1, 1.0 and 1.0.0. And if we creates a v1.0.1 we create the tag 1.0.1 and we move the tags 1  and 1.0 to point that image. This way if someone say dstacademy/server:1 he is going to get all the improvement we’ll make in the v1.X but if he want the tag 1.0.0 he is not going to get any automatic update dsta update. But he is going to get images updates because we are going to update the image with the last version of dst.
Other thing, I didn’t see any official image tag with the vso we can remove it. For me seems cooler with it but…
I think that once we are agree we must write down how to tag the images, because it’s not so trivial as it seems.

True. Here are my additional thought.s

I really like the v prefix for tags on Github, but we should create Docker tags without v prefix.
The Docker latest tag should correspond to the latest commit on the master branch.
Create a new Docker tag next which corresponds to the latest commit on the develop branch.

A new release major.minor.fix should create one new Docker tag and update four existing tags, as you've already mentioned - e.g. v1.2.4 builds/updates these Docker images:

1.2.4
1.2
1
latest
next

I agree: Git tags with v docker tags without. I like your idea about latest and next. Is next any kind of convention? Is there any convention? May I propouse snapshot?

Not sure if there's a convention, but next fits nicely to latest I thought. snapshot doesn't really tell what snapshot it is. Is it a nightly snapshot? A snapshot of a specific date? latest is a convention in the Docker ecosystem and I've read it should point to the latest stable release - if that's true, we're doing it wrong at the moment. It also makes sense to point to the latest stable release if you use the image dstacademy/server without tag. You should opt in to pre-releases explicitely, and dstacademy/server:next seems appropriate.

Sure, latest the las stable. And it have sense latest and next. We are doing wrong because we don't have a stable version yet: 0.

latest is just a synonym for last released (newest) version and next is a synonym for the last commit.


process.env.NODE_ENV unavailable in browser

When attempting to use this package in a browser, I run into the error of process being undefined when it's called from the makeImmutable function.  It seems like there should be a check for whether or not process exists before checking the env, since it won't exist in a browser.  This would also mean having an alternate means of putting seamless-immutable into production mode when running in a browser.

+1

Hi @ryanfields and @bholloway,
You want to use either the development build or the production build - the source build, which has process in it, should not be used in the browser.
Sorry if that was unclear! :smile:

Thanks @ryanfields. I was using in JSBin so that should solve my issue.
However there might be a problem in the bower.json in that case, since it points to the src file. I would say it 99% of cases a Bower package goes straight to Web, rather than being used/built in a Node-like environment.
I am happy give you a PR for that fix and some clarification in the Docs but if you are opposed, or it is quicker for you to change yourself, then just let me know.

A PR would be great!


Domino-jackson-pocessor use the package of bean to generate DeserializerImpl/SerializerImpl.

In case of Java objects, it causes the Java compilation error (package exists in another module: java.base)

The second issue such classes do not processed by GWT because they are located outside client/shared folders.
Better to allows user specify base package for generated staff.

The issue here is not that we generate in the wrong package but the fact that (de)serialization of the java.time.Instance is not supported so it deals with it as if it was a normal bean, the solution to this is to add a feature that allows you add your own custom (de)serializers then if you can can write those for something like javatime.Instance and include them to be used by the processor.
If  you would like to report this as a feature request -it might be reported before - we might take a look at the possibilities.

I will check


Infographics

What do you need?
Guidance on infographics.

https://github.com/govau/content-guide/issues/60


Multiplayer bug?

Hi there,
There seems to be an issue with multiplayer. The items only appear for the host. My friends and I have tried several fixes and nothing seems to help.

Same issue here on V49. I have yet to try disabling all other mods and just keeping LethalThings.

also had this issue last night.


SSE4.2 implementation of aabbox3d

One more thing, because this is nice and new clean API... the files should be in include/irr/namespace/...
In the case of Axis Aligned Bounding Boxes, they should be in include/irr/core/math

@Przemog1 , btw you need to add IRR_FORCE_EBO to all classes which are "empty" (don't have members) otherwise their sizes will be messed up
like this
https://github.com/buildaworldnet/IrrlichtBAW/blob/08269e8af602b0622b2b48cad785d0997f0b4551/include/irr/core/BaseClasses.h#L21
Its a very interesting MSVC bug regarding Empty Base Optimization that you can read about ;)

now all I need to do is better algorithm for box intersection test

Also to finish this task I will need operator<, operator>, unpackLo and unpackHi functions for SIMD vectors

auto pseudoMin = core::unpacklo(internalRep,other.internalRep);
auto pseudoMax = core::unpackhi(internalRep,other.internalRep);
if (FLOATING_TYPE) // min <= max implies max-min >= 0
   return _mm_movemask_ps((pseudoMax+pseudoMin).getAsRegister())==0x0u;
else
   return pseudoMin<=pseudoMax;

are we done?

If everything is alright then yes.
Need to add few comments and I think its time to suspend this task until SIMD vector classes rework.


Speaker Diarization - Speaker Tag in C#

I know, speakerDiarization is not being advertised for C#, but i really need to implement it. Can you guys please guide me how to get the speakerTag in the response object ? I have been successfully been able to use the beta nuget package, but am clueless about speakerTag, Thanks

I'm not sure which package you're using - you need to use Google.Cloud.Speech.V1P1Beta1. There's then a WordInfo.SpeakerTag property.

I am using Google.Cloud.Speech.V1P1Beta1 version 1.0. There is no such property

Yes, because it looks like your account has problems again, and I can't help you with that. I suggest you contact the regular support lines to find out what's going on with your account and why it won't allow you to authenticate. I will close this issue now as I believe the specific question has been answered.

{{ "alternatives": [ { "transcript": "good morning Law Offices homemade Rector call a good morning is Mr Brown available", "confidence": 0.7976806 } ], "languageCode": "en-us" }} -> this is the response I am getting, there is no words in alternative object.

From the code that you have provided, the response always returns 0 as the speaker tag, No matter how many speakers are there in the audio. Is this an issue ?
Below is the code im using:
var longOperation = speech.LongRunningRecognize(new RecognitionConfig()
               {
                   Encoding = RecognitionConfig.Types.AudioEncoding.Linear16,
                   DiarizationSpeakerCount = 2,
                   EnableSpeakerDiarization = true,
                   SampleRateHertz = 16000,
                   LanguageCode = "en",
               }, RecognitionAudio.FromFile("testRecording.wav"));

               longOperation = longOperation.PollUntilCompleted();
               var response = longOperation.Result;
               Console.WriteLine("Response received successfully.");

               foreach (var result in response.Results)
               {
                   foreach (var alternative in result.Alternatives)
                   {
                       foreach (var word in alternative.Words)
                       {
                           Console.WriteLine($"{word.Word}: {word.SpeakerTag}");
                       }
                   }
               }

One more thing that i noticed is it works fine for short audios.

I'm afraid this isn't something I'd know about - it's about the API itself rather than the library access to it. I suggest you ask on the Google Group for the API which is more likely to include the engineers who work on the server-side implementation.


docs(*): migrate to typed form

这是 PR #8018 的第二部分
为了使示例代码的表单类型更为清晰，我为它们显式编写了类型，这会使代码量增加。
实际上表单类型可以通过类型推导自动得出：
const validateForm = fb.group({ field: [''] });
        // ^? `FormGroup<{ field: FormControl<string | null> }>`

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https:github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

此PR是 #8018 的第二部分，我们还需要合并 #8018 @simplejason


ADDED : JavaScript: Understanding the Weird Parts

Hey @SincerelyBrittany !
Congrats on submitting your pull request and from what I can infer, this was your first pull request towards an open-source project. Thank you for giving this repository the opportunity to help you guide in your first contribution. On behalf of everyone here, I'd like to welcome you to the open-source community!
You PR has been merged and the changes will be reflected on the website in a few minutes,.
Do leave a star, if you liked the repo ;)
Happy hacking ! 🎊


DRAFT: Tesla rewrite

This is a WIP branch for a Home Assistant Rewrite where we move all Home Assistant related code directly into this library.
This will make development of the Component simpler, and allow us to have a quicker development cycle for new features from Tesla.
I've made an effort to keep the same unique ids, so entities behave the same, but there are some extra attribute changes as I removed duplication.
Also, this has introduced some new entities such as the update entity, and number entities to make better use of Home Assistants new entity types.
This is well and truly a breaking change, and using this branch should be done with caution.
Things still do be done:

Create media_player entity
write tests for All code.
Clean up code comments and documentation.
Clean-up and review services.py
re-create app-like functionality, where the climate is enabled before heated seats are enabled.

Thanks for starting this. I'm a python newb but I have worked on some Home Assistant integrations so I can maybe help. I'm mostly interested in implementing Tesla solar stuff. I'm not sure what the best way to handle both cars and solar systems would be perhaps make TeslaBaseEntity a bit more generic and create two classes that inherit it, TeslaCar (basically what you already have but just move car specific stuff in there) and TeslaEnergy that covers all energy specific stuff (solar systems, solar roofs, power walls)?
Additionally, a lot of the class names could probably be renamed to add Car somewhere in their name since there's some commonality with energy devices like batteries. For example, TeslaBattery could perhaps be TeslaCarBattery?
Anyways, more than happy to help where I can. The energy site stuff should be fairly easy to implement. I've already made a pull request to teslajsonpy to add it so I'm familiar with how the "API" works.

So I've started working on this since I have some free time this week. What I've done so far is:

Move car specific code out of TeslaBaseEntity to a newly created TeslaCarEntity.
Created a new TeslaEnergyEntity which also inherits from TeslaBaseEntity.
Creating TeslaEnergySolarPowerSensor, TeslaEnergyLoadPowerSensor, TeslaEnergyGridPowerSensorandTeslaEnergyBatteryPowerSensor`
Changes to teslajsonpy Controller which should support both the current integration and re-write. However, I'm assuming we'll probably want to clean up teslajsonpy once this re-write is done.

So far this seems to be working, although that's not saying much 😆 as I'm definitely not a developer by any means, just a part-time hobbyist who has worked with a couple HA integrations and libraries.
@alandtse What's the best way to start submitting PRs? Just make a fork of the fork/branch @Megabytemb created and submit a PR on his branch? I'm just not sure if he will have time to merge them so I was thinking if we can maybe create a branch in your repo, merge his changes, then we could just fork that and all submit changes to there?

Ah okay, makes sense.
Yeah, I was looking at TeslaPy but realized it wasn't async... started thinking about maybe we should just help rewrite that to be async but that's probably not an easy task (well beyond my knowledge).
I think teslajsonpy, with a little modification, will still allow us to re-write this integration to do as you mentioned. My thought was once we get that done, we can then clean up teslajsonpy to make it more generic which will probably require some updates to the integration as well. I would like to also setup the config flow in HA so you can use your username and password, and the integration automatically grabs the refresh token (or is there a reason it's not like that already). Anyways, I'll work on what I can and submit a PR here.

Closing as integrated with #250


[Misc] Add a wrapper for torch.inference_mode

torch.inference_mode is not supported by some hardware backends such as TPU. To address this, this PR introduces a wrapper class that falls back to torch.no_grad for the unsupported backends.

is it possible to put it into https://github.com/vllm-project/vllm/tree/main/vllm/platforms ?
e.g.
class CudaPlatform(Platform):
    inference_mode = torch.inference_mode

class TpuPlatform(Platform):
    inference_mode = torch.no_grad

@youkaichao Sorry I don't get your point. What will the API look like in your proposal?
Orthogonally, torch.inference_mode and torch.no_grad are slightly different. For example, inference_mode has mode: bool =True input arg while no_grad doesn't take any input arg. They need a wrapper class to cover this difference.

The usage will be a unified decorator:
from vllm.platforms import current_platform

class ModelRunner:

    @current_platform.inference_mode
    def execute_model(

it dispatches to torch.inference_mode in GPU or torch.no_grad in TPU.
we don't need to mimic full functionality of torch.inference_mode, i.e. we don't need to have a mode argument.
this is how we unify the heterogeneity of hardware platforms.

@youkaichao Got it. Thanks for the explanation.

we don't need to mimic full functionality of torch.inference_mode, i.e. we don't need to have a mode argument.

You're right. I simplified the code based on your suggestion. PTAL.

@current_platform.inference_mode

I also agree that this could be a better idea. However, because inference_mode is used in worker_base and mode_runner_base, your approach will require registering all hardware platforms (CPU, openvino, neuron, tpu, gaudi, xpu, etc.) to current_platform. While we should do this eventually, I'd like to defer it until the hardware backends are more settled. For now, I think it makes sense to put inference_mode under utils, so that this does not block other PRs.

your approach will require registering all hardware platforms (CPU, openvino, neuron, tpu, gaudi, xpu, etc.)

not necessary. we are doing it step by step. for example, I only implemented get_device_capability in cuda and rocm platforms, without touching the rest of the code.
for the problem you mentioned, we can have another platform called UnspecifiedPlatform, to hold inference_mode with the default value of torch.inference_mode. Then CPU, openvino, neuron, gaudi, xpu can all benefit from it. And only TPU needs to have a specialized code path to dispatch to torch.no_grad .
https://github.com/vllm-project/vllm/blob/b6df37f9431b44e3e8802448c95cbc6989c3716e/vllm/platforms/__init__.py#L16
I can do it in a followup PR, if you don't have bandwidth.
I think starting the code in a unified way is better than we gather around code later.

@youkaichao I see. Update the PR. PTAL.

@youkaichao Thanks for your feedback! Let me merge the PR as it passes the tests.


python310Packages.jupyterlab-lsp: 4.2.0 -> 4.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.jupyterlab-lsp is: Language Server Protocol integration for Jupyter(Lab)
meta.homepage for python310Packages.jupyterlab-lsp is: https://github.com/jupyter-lsp/jupyterlab-lsp
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.3.0 with grep in /nix/store/x88iq8wlj68j1brhysbyrb1k5wffdxid-python3.10-jupyterlab-lsp-4.3.0
found 4.3.0 in filename of file in /nix/store/x88iq8wlj68j1brhysbyrb1k5wffdxid-python3.10-jupyterlab-lsp-4.3.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.jupyterlab-lsp
python311Packages.jupyterlab-lsp

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x88iq8wlj68j1brhysbyrb1k5wffdxid-python3.10-jupyterlab-lsp-4.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.jupyterlab-lsp https://github.com/r-ryantm/nixpkgs/archive/5644d3d0033f47b90d65f7e1a5da1965fbaff414.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5644d3d0033f47b90d65f7e1a5da1965fbaff414#python310Packages.jupyterlab-lsp

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x88iq8wlj68j1brhysbyrb1k5wffdxid-python3.10-jupyterlab-lsp-4.3.0
ls -la /nix/store/x88iq8wlj68j1brhysbyrb1k5wffdxid-python3.10-jupyterlab-lsp-4.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

python310Packages.jupyterlab-lsp
python311Packages.jupyterlab-lsp

Maintainer pings

2 packages marked as broken and skipped

😞

This is the second release candidate of v5.0.0, providing support for JupyterLab 4.0. There are no know major bugs at this point - if you see any issues, please report on https://github.com/jupyter-lsp/jupyterlab-lsp/issues. A final release is expected in the upcoming week.
https://github.com/jupyter-lsp/jupyterlab-lsp/releases/tag/v5.0.0rc1

We should wait for the v5.0.0.


USB mass storage not working as expected

I'm trying to debug some problems we have with usb mass storage devices in ps2sdk and OPL. I was hoping to use your driver with PCSX2's debug feature, but I'm running into some issues.
On ubuntu I've created a copy of a usb stick (sudo dd if=/dev/sdd of=usb.img bs=1M). When using this usb.img it does seem to work to some extend. The FAT32 file system is detected, and some read operations seem to work. But a lot of read operations don't work.
I know this is not enough information to debug or find any problems, but perhaps this is a known problem I'm running into. So before spending hours trying to find out exactly what SCSI command is returning what data right/wrong I thought I'd ask here if the driver has even been used with ps2sdk's usb mass storage modules (or OPL).
I hope it's no problem if I ask in this same issue report for a feature I think would be very usefull:
Make the driver work with linux devices. In linux, my USB stick is for instance /dev/sdd. It's already possible to select /dev/sdd as the file to use as a mass storage device if the user is added to a specific group ('disk' I think it is). But then the file size is interpreted wrong, so the disk shows up as being 0b in size. So the only thing that would need to be changed is the way the size of the file/device is detected.

Personally not much tested, just that ulaunchELF opens simple txt file and Gran Turismo 4 can save its photos.
Could be qemu part, msd part or even PCSX2 itself maybe.


Importing @material-ui/core into jest unit test in codesandbox breaks that test

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
After importing library (whatever component), tests fail with some weird error message.
This prevents me from constructing example for another bug, which I want to submit.

Expected Behavior 🤔
Tests pass!

Steps to Reproduce 🕹
https://codesandbox.io/s/create-react-app-with-typescript-drm3c

Go into tests/Test... file.
Comment out line which imports @material-ui/core and line which uses Button -> test passes
Uncomment the lines -> tests fail

Context 🔦

Your Environment 🌎
Codesandbox! :)

Tech
Version

Material-UI
v4.?.?

React

Browser

TypeScript

etc.

(I will not provide these - just look into package.json of provided example.

@mpodlasin Yeap, It seems to be an issue coming from JSS sources. We have the following
const hasCSSTOMSupport = typeof CSS !== 'undefined' && CSS && 'number' in CSS

// jss.hasCSSTOMSupport === true
// CSS !== undefined
// window.CSS === undefined

var px = jss.hasCSSTOMSupport ? window.CSS.px : 'px'; // THROW

This prevents me from constructing example for another bug, which I want to submit.

What is it?


[0.7.x] BZ1333277: Upgrade of XStream library to 1.4.9 causing exceptions during Project navigation

See https://github.com/uberfire/uberfire/pull/360
(cherry picked from commit 344444375ceb94a2409e43420c250315ca8fe6c5)
This is the corollary for 0.7.x.

+1. Merged as https://github.com/uberfire/uberfire/commit/257dd9810c47682fce93ed144f976619326e8442.


[MM-47604] Modal exit focus for all modals

Summary
When opening a modal from the create channel button (see screenshot), we were unable to refocus to the correct element when the modal is closed because the sub menu was no longer in the DOM.

Now when the modal is closed the focus goes to create channel button.
I decided to address all the other models in the webapp in order to keep consistency. The modal controller has a default returnFocus event when the modal closes, you can also pass in a returnFocus prop in order to override it and there is also another prop called returnFocusOnExit which defaults to true but if you give it a value of false you can handle the return focus directly in each modal.
Modals that needed to be handled manually:

Product menu in the top left

User groups
About modal

Profile button top right

Custom status
Profile settings menu
Custom DND

Team name button

Add group to team
Invite people
Team settings
Manage members
Leave team

Find channel
Category dropdown
Channels

Create category
Add members

Create DM modal
Invite members
Channel header

Notification preferences
Add members
Edit channel header
Edit channel purpose
Rename channel
Convert
Channel actions

Add member to this channel button

Ticket Link
https://mattermost.atlassian.net/browse/MM-47604
Release Note

Fixing focus after closing modals

I wonder if we could do this automatically somehow by instead adding an optional returnFocusOnClose prop to the openModal action and making the ModalController in charge of this somehow? If we create a new subcomponent of ModalController that returns this section, have it store whatever document.activeElement is in a ref when it's first mounted, and then when it injects the onExited  prop into the modal, it could add the extra handling based on if returnFocusOnClose was passed into openModal.
Does that sound like it'd work? That'd prevent us having to duplicate this logic through those 4 modals and let us use it elsewhere more easily as well.

@hmhealey

I wonder if we could do this automatically somehow by instead adding an optional returnFocusOnClose prop to the openModal action and making the ModalController in charge of this somehow? If we create a new subcomponent of ModalController that returns this section, have it store whatever document.activeElement is in a ref when it's first mounted, and then when it injects the onExited prop into the modal, it could add the extra handling based on if returnFocusOnClose was passed into openModal.
Does that sound like it'd work? That'd prevent us having to duplicate this logic through those 4 modals and let us use it elsewhere more easily as well.

I think this would would help with modal behaviour throughout the app, or we could add the behaviour to whatever parent modal component is being used, such as GenericModal. However, there are still cases where we would want to pass a custom returnFocus handler to the modal. In particular, if the active element that triggered the modal to open no longer exists when the modal opens, then using document.activeElement would no longer be correct and we have to manually determine which element to focus when the modal closes. That's the case for the four modals in this PR, where the modals are being opened via buttons in the sub-menu, so they disappear when the modal opens. It's logical to focus the plus button that opens the submenu, instead.

Thanks for input from both of you!
React-bootstrap already has a prop to return focus after close and it works for elements that still exist in the DOM like Cyril said. I don't think we can make this work by using document.activeElement in a subcomponent of modalcontroller but I can do something else to simplify my existing approach.
Instead of adding an optional returnFocusOnClose prop to the openModal I could create an optional prop (fallbackFocusElement?) that takes document.activeElement from the component opening the modal. We can handle the below code in modal_controller using the new optional prop:
document.dispatchEvent(new CustomEvent<A11yFocusEventDetail>(
            A11yCustomEventTypes.FOCUS, {
                detail: {
                    target: fallbackFocus as HTMLElement,
                    keyboardOnly: true,
                },
            },
        ));

Then when it injects the onExited prop into the modal, it could add the extra handling based on if a return Element was passed into the modal openModal. The key is that the component that opens the modal can control exactly where the focus goes after close. What do you think @cyrilzhang-mm & @hmhealey?

That makes sense to me @BenCookie95! A few things though:

I think it makes more sense to inject this behaviour into onHide, not onExited, so that the user doesn't have to wait until the animation finishes for the focus to show up. However I was having some problems using onHide with modals before, so I'm not sure if this is doable.

React-bootstrap already has a prop to return focus after close and it works for elements that still exist in the DOM

It does work but the a11y-controller doesn't visibly show the focus, so it's not very good for accessibility.

That makes sense to me @BenCookie95! A few things though:

I think it makes more sense to inject this behaviour into onHide, not onExited, so that the user doesn't have to wait until the animation finishes for the focus to show up. However I was having some problems using onHide with modals before, so I'm not sure if this is doable.

React-bootstrap already has a prop to return focus after close and it works for elements that still exist in the DOM

It does work but the a11y-controller doesn't visibly show the focus, so it's not very good for accessibility.

@cyrilzhang-mm good points!

I think it makes more sense to inject this behaviour into onHide, not onExited, so that the user doesn't have to wait until the animation finishes for the focus to show up. However I was having some problems using onHide with modals before, so I'm not sure if this is doable.

I was also having some issues/random behaviours happening with onHide but I'll see if it's possible

It does work but the a11y-controller doesn't visibly show the focus, so it's not very good for accessibility.

I didn't think of that, good point. Would be nice if I could include that

In particular, if the active element that triggered the modal to open no longer exists when the modal opens, then using document.activeElement would no longer be correct and we have to manually determine which element to focus when the modal closes.

Oh, I see. I forgot React Bootstrap did that for us most of the time.

Instead of adding an optional returnFocusOnClose prop to the openModal I could create an optional prop (fallbackFocusElement?) that takes document.activeElement from the component opening the modal.

I think that's a good idea in general, but, to nitpick about the name a bit, I don't think we need the "fallback" part of that name if we're just overriding what React Bootstrap would normally do here. I like the idea of having ModalController being responsible for that, but I'm not sure I understand why we'd need to get A11yController involved here as opposed to just calling .focus() on the element that's passed in.

I think it makes more sense to inject this behaviour into onHide, not onExited, so that the user doesn't have to wait until the animation finishes for the focus to show up. However I was having some problems using onHide with modals before, so I'm not sure if this is doable.

I wouldn't be surprised if it needs to wait until onExited since React Bootstrap may still be trying to trap the focus while the modal is at all visible.

2. > React-bootstrap already has a prop to return focus after close and it works for elements that still exist in the DOM
It does work but the a11y-controller doesn't visibly show the focus, so it's not very good for accessibility.

Does it show it when the UI is already in focus-visible mode (ie when the user was using the keyboard to navigate), or do we lose that focus-visible mode when going to a modal? I'd rather not tough the default mode where focus isn't visible at the moment since that may cause issues with how widespread that could be. For better or worse, the current system seems to be something most people are happy with even if it's not perfect.

@hmhealey

I'm not sure I understand why we'd need to get A11yController involved here as opposed to just calling .focus() on the element that's passed in.

Does it show it when the UI is already in focus-visible mode (ie when the user was using the keyboard to navigate), or do we lose that focus-visible mode when going to a modal?

The A11yController will only show a visible focus on a focus change if the user is literally holding down a key on the keyboard at that moment. So, calling focus() on elements doesn't usually show a visible focus, even when the UI is in focus-visible mode, because usually it's called in a callback such as when a modal closes, and the user is not holding down any keys. This is a behaviour that was introduced in https://github.com/mattermost/mattermost-webapp/pull/3922.
I didn't want to revert the change in that PR because it would change the behaviour all across the app, so I added a custom event for the A11yController in https://github.com/mattermost/mattermost-webapp/pull/11530 which can be dispatched whenever we want to explicitly focus on elements for accessibility purposes. This event ensures that there is a visible focus when the UI is in focus-visible mode, and there is no visible focus if the UI is not in focus-visible mode.

For better or worse, the current system seems to be something most people are happy with even if it's not perfect.

True - but I do think it's jarring when the focus disappears as I am trying to navigate the app with the keyboard. It is confusing because I no longer have any idea where I am in the app.

Oh, I see. So, if I have everything correct here:

Calling .focus() outside of a key handler disables the focus-visible mode, and that's why we have the custom focus event to ensure it stays in the focus-visible mode if that's enabled.
Using the custom focus event doesn't enable focus-visible mode if it's not already enabled

Is that about right?
I know that I still don't entirely understand the  A11yController class, but hopefully I've got a better idea now. If that's the case, that'd also make sense why React Bootstrap would break focus-visible mode since it's presumably just using .focus() when closing modals instead of anything custom that we've added.

@hmhealey @cyrilzhang-mm
I added a default focus function to the modal_controller with the option to override it with a prop. There are cases where modals still need to handle the exit themselves. For example if you submit a form and redirect the page, the focus action will be different if you submit the form vs escape the modal. In order to work around it in the new channel and DM modals I've done the following:
openModal({
            modalId: ModalIdentifiers.NEW_CHANNEL_MODAL,
            dialogType: NewChannelModal,
            dialogProps: {
                     // We want the New Channel modal to handle the return focus itself
                     handleReturnFocus: returnFocus,
                     returnFocus: undefined,
            },
})

returnFocus is the modal controller prop, passing undefined means we can handle the focus ourselves in the modal.
Adding the default focus function to the modal_controller just means I'll need to look at every modal in the webapp and determine if they need to manually handle their own focus after exiting because it will lead to unexpected focus issues in some cases. I don't mind looking through all the modals and seeing what needs fixing but just letting you know

I'm not sure I understand the difference between the returnFocus and handleReturnFocus props. Wouldn't someone using this code just be able to pass their custom handler into returnFocus instead of handleReturnFocus and have it work more or less the same way?

@BenCookie95 I think I understand what you are saying. The returnFocus prop is automatically called by the modal controller whenever the modal exits, whereas handleReturnFocus is simply passed to the modal component itself and the modal component decides when to call it. Is that correct?
This makes sense to me but I think we could rethink the prop names so that it's clearer.
What if we leave returnFocus as-is but instead of having handleReturnFocus we pass a boolean returnFocusOnExit which defaults to true. If it's true, the modal controller will automatically call returnFocus. If this boolean is false, the modal controller doesn't do that and instead passes returnFocus to the modal component.

@cyrilzhang-mm

I think I understand what you are saying. The returnFocus prop is automatically called by the modal controller whenever the modal exits, whereas handleReturnFocus is simply passed to the modal component itself and the modal component decides when to call it. Is that correct?

Correct.

What if we leave returnFocus as-is but instead of having handleReturnFocus we pass a boolean returnFocusOnExit which defaults to true. If it's true, the modal controller will automatically call returnFocus. If this boolean is false, the modal controller doesn't do that and instead passes returnFocus to the modal component.

I like that idea but not 100% sure on the name but I can't think of a better one right now.
Thanks Cyril!

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.
If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.


soc: nxp: s32k: make the SoC SEGGER RTT capable

SEGGER RTT is supported for NXP S32K1 and S32K3 devices.
Fixes #74702

reopened in #81369 because the mailmap settings make the check compliance fail for my personal contributions..


setup web server

See the html code here
https://projects.raspberrypi.org/en/projects/get-started-pico-w/4

works but with bad indexing
start 16 end 29
message sgcqkd0fnr/
led on

The web server is up and running. This issue is closed.


Improve compressed materials

Adresses https://github.com/wiremod/wire/issues/2926
Also converts materials that dont use alpha from DTX5 to DTX1 to save more space

Before:

After:

Not anymore, and also this one is about 50% smaller.  Please don't merge yet though, I'm gonna PR a few of the "objectively good" changes from #2927 into this PR so we don't lose them.

Check new PR mentioned above (#2931), it builds on this one and addresses some issues with it (eg. cog.vtf being broken again in this PR)


macho/load_commands: support LC_ATOM_INFO

Fixes #609

In this case I used cctools: https://github.com/apple-oss-distributions/cctools/blob/7a5450708479bbff61527d5e0c32a3f7b7e4c1d0/include/mach-o/loader.h#L345.
There's also a change coming in macOS 15 that we'll want to support (but not sure if a compiler can output this yet): https://github.com/apple-oss-distributions/cctools/blob/7a5450708479bbff61527d5e0c32a3f7b7e4c1d0/include/mach-o/loader.h#L708-L727


add texts to READ ME

I'm a newbie and here is my first contribution;
Enjoy coding;

Hi @chhyriden! Thank you for stopping by. I cannot accept this of course, but have a nice day. :smiley:

Hello @doficia. Thank for your response though. I appreciate that. Have a great day. :)


Images don't show up anymore

Probably linked with this "fix" https://github.com/assemblee-virtuelle/semapps/commit/680ed9bd7537ecdd8bf7bff641a1dab193f4c1aa

Fixed here e082d6b


[style]: adding bullet points

Adding bullet points to each step of the exercise instructions would enhance readability.

Can I work on this ?

Can I work on this ?

all yours

Made the PR #162 , kindly review it

Made the PR #162 , kindly review it

I requested a small change, could you take a look at it?


Errors When Run "flutter run -d windows"

Exception: Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string: [
{
"instanceId": "426d3b2b",
"installDate": "2022-05-13T14:44:17Z",
"installationName": "VisualStudio/17.2.0+32505.173",
"installationPath": "D:\VS2022\Community",
"installationVersion": "17.2.32505.173",
"productId": "Microsoft.VisualStudio.Product.Community",
"productPath": "D:\VS2022\Community\Common7\IDE\devenv.exe",
"state":<PHONE_NUMBER>,
"isComplete": true,
"isLaunchable": true,
"isPrerelease": false,
"isRebootRequired": false,
"displayName": "Visual Studio Community 2022",
"description": "����ǿ��� IDE����ѧ��������Դ��������ߺ͸������ʹ��",
"channelId": "VisualStudio.17.Release",
"channelUri": "https://aka.ms/vs/17/release/channel",
"enginePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service",
"installedChannelUri": "https://aka.ms/vs/17/release/channel",
"releaseNotes": "https://docs.microsoft.com/en-us/visualstudio/releases/2022/release-notes-v17.2#17.2.0",
"thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=661288",
"updateDate": "2022-05-13T14:44:17.3403451Z",
"catalog": {
"buildBranch": "d17.2",
"buildVersion": "17.2.32505.173",
"id": "VisualStudio/17.2.0+32505.173",
"localBuild": "build-lab",
"manifestName": "VisualStudio",
"manifestType": "installer",
"productDisplayVersion": "17.2.0",
"productLine": "Dev17",
"productLineVersion": "2022",
"productMilestone": "RTW",
"productMilestoneIsPreRelease": "False",
"productName": "Visual Studio",
"productPatchVersion": "0",
"productPreReleaseMilestoneSuffix": "7.0",
"productSemanticVersion": "17.2.0+32505.173",
"requiredEngineVersion": "3.2.2146.50370"
},
"properties": {
"campaignId": "2030",
"channelManifestId": "VisualStudio.17.Release/17.2.0+32505.173",
"nickname": "",
"setupEngineFilePath": "C:\Program Files (x86)\Microsoft Visual Studio\Installer\setup.exe"
}
}
]
.


Challenge renewal: Connection refused

Hi icing,
I am currrently facing the following issue in testsetup with the the letsencrypt staging env:
When requesting the challenge verification(tls-alpn-01) it can happen that the host is not reachable from the letsencrypt staging
Resulting in an error:
ACME server authz: challenge 'invalid' for ***domain*** at https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/id . Exact response was: {"identifier":{"type":"dns","value":"***domain***"},"status":"invalid","expires":"2021-10-15T15:48:53Z","challenges":[{"type":"tls-alpn-01","status":"invalid","error":{"type":"urn:ietf:params:acme:error:connection","detail":"Connection refused","status":400},"url":"https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/id/tCNB2g","token":"HIrAlkWbO-MVwsF-pp92geBF2iXlOt8KE0ZUgtyzG5Ut6w","validationRecord":[{"hostname":"***domain***","port":"443","addressesResolved":["ip"],"addressUsed":"ip"}],"validated":"2021-10-08T15:48:55Z"}]}
Mod md than starts a retry with the same challenge some minutes later ending in the exact same error message again.
Any ideas why? Might it be related to the boulder retry limitation "Boulder does not implement the ability to retry challenges or the Retry-After header"(https://github.com/letsencrypt/boulder/blob/master/docs/acme-divergences.md#section-82)

I read this as lets encrypt is unable to open a connection to your host on port 443.
Apache will retry with increasing delays. Have you verified that your domain is reachable on that port from the public internet?

Sorry took a bit longer. It solves my problem, but maybe introduces a potential new one:
Through the new order the error counter is reset as well as the timing:
Example log "encountered error for the 1. time, next run in 2 seconds"
This will lead to a high risk spamming the CA with tons of request before e.g. fixing the connection issue.
Would it be possible to start a new "throttled order"?


Can't find the "Solution Tool Window" in VS Code

In the "Create the initial database schema using EF's migration feature" section I'm instructed to "In the Solution Tool Window, right-click the RazorPagesMovie project, and then select Open in Terminal."
There is as far as I can tell no Solution Tool Window in VS Code. Is this perhaps a reference to a window in Visual Studio?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Part 2, add a model
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

yes

Ok... Will you update the documentation so that it's correct?

Thanks @MartinNr5 for pointing this out, very appreciated. I will get it fixed in the doc.  Looks like it was accidentally moved around from the Visual Studio content.

@wadepickett - You're welcome.


The SOS button can be optimized

hello ,
After observing and interacting with the site i have found that  normally a user might not be able to get the context of the SOS button provided at the bottom right corner,
The user might not be able to see that button or might not get the context of that .
Solution :- adding a hover animation  which makes the SOS box bigger and better visible when the user hovers over it , and also change the SOS to "Report Animal Abuse"  ,  doing so might increase user attention to the button
If possible assign this issue to me as a GSSoC 2023 Contributor .
Thank you .

I would like to work on this issue as a GSSOC contributor.

It is currently not needed in website


unstick?

how to unstick ellement ?
or get it to work only in the parent ?

style error. my fault


Editor component possible race condition

I was wondering if there could be a race condition.
Suppose I try to edit an article, Editor component si being mounted and EDITOR_PAGE_LOADED event is dispatched.
The request is sent to server, but the server didn't respond yet. (1)
Now I go back to homepage, editor component is unmounted, EDITOR_PAGE_UNLOADED is dispatched, the state related to editor component is cleared.
Now I try to edit another article, Editor component is mounted, EDITOR_PAGE_LOADED is dispatched for another article.
The request is sent to server, and server responds instantly. (2)
Reducer for EDITOR_PAGE_LOADED action triggered by second request is called. Everything cool still.
Now, the first request (1) is full-filled, and reducer for EDITOR_PAGE_LOADED action is called, with information from first request, and in the editor I will see the contents for first article I tried to edit, instead of the second one.
Hm?

Fair point. Will put in a fix tomorrow

@nvartolomei what do you think about https://github.com/GoThinkster/redux-review/pull/8?

Not sure if I like this one, page change makes all requests made through promise middleware obsolete. This is too much, imho. Let's say I have a header that stays the same on all pages, an action from header will be killed in middleware if editor is unloaded?

You're right, hadn't quite thought of that. Have any other ideas? I'll do some research and see if I can come up with something better today.

@nvartolomei see what you think of https://github.com/GoThinkster/redux-review/pull/9 . Slightly different approach based on explicitly cancelling all tracked promises when a route unloads.

@vkarpov15 looks good to me.


Think of HTML and Element as the same thing

They have only a little difference between HTML and Element.
The Element has no links, base_url, absolute_links.
In most cases the Element also needs the three properties, because we usually only need to follow a part of links of a HTML page.
So then the Element class and the HTML class are the same.

i experimented with having both use a baseclass, but ran into some problems. will experiment some more.

having success with it now