[SP-2081] - Backport of PDI-13353 - When having duplicate DB Connection names (difference in capitals) PDI defaults to the first (5.4 Suite)

handle NULL returned from the dialog
trim connection's names
add tests
(cherry picked from commit bba8ff7)

@mattyb149, @brosander, review it please. This is a backport of #1907

@dkincade are we merging into <IP_ADDRESS>?

Build Commands:
Build:

rm -r ~/.kettle; rm -r ~/.pentaho; ant -f ui/build.xml clean-all resolve jacoco checkstyle

Cleanup:
rm -r ~/.ivy2/local || echo "no publish local to remove"
Changed files:
ui/src/org/pentaho/di/ui/repository/repositoryexplorer/controllers/ConnectionsController.java
ui/test-src/org/pentaho/di/ui/repository/repositoryexplorer/controllers/ConnectionsControllerTest.java
Checkstyle violations:
No errors found
License header violations:
No violations found
Unit test coverage change:
org.pentaho.di.ui.repository.repositoryexplorer.controllers.ConnectionsController:

instructionPercentCoverageChange : +0.72%
branchPercentCoverageChange : +2.35%
linePercentCoverageChange : +1.57%
complexityPercentCoverageChange : +0.94%


feat: add external links to navbar

Closes #26
Signed commits

[x] Yes, I signed my commits.

Hey @35C4n0r Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

Good work, @35C4n0r 🙌


[d3d9] Texture rendering issues. GTA:SA(MP)

Texture rendering issues. Game gta sa, with mod multiplayer - samp. There are no other problems. It should be:

How displayed:

gta_sa_d3d9.log

I need an apitrace to fix that.

I tried to run it through apitrace for several hours and didn’t give any result, either I didn’t understand how to use it, or it doesn’t work on GTA sa, I checked everything works on other games, and when I try to start GTA sa, nothing happens at all, please help how it's right to do it for gta sa

The issue you linked was fixed. I've had people make GTA SA apitraces in the past. Just copy the 32bit d3d9.dll in the folder where the gta sa exe is, run the game, do what you need to do to show what would be broken with DXVK. Then upload the .trace file that was created on your desktop.

How do you even open that inventory in GTA San Andreas, i didnt even know the game has an inventory.

The fact is that this is not just gta sa, but with a mod for multiplayer, and this inventory is a server thing made on textdrives, I tried to use build of maste : https://github.com/doitsujin/dxvk/actions/runs/2034097211  the same error is there. When I just throw d3d9.dll (apitrace) into the root folder with the game, it does not start

How can you use both dxvk and apitrace at the same time if they are both d3d9.dll

How can you use both dxvk and apitrace at the same time if they are both d3d9.dll

You don't. I don't need you to use apitrace with DXVK, apitrace with normal Windows d3d9 is fine too and will allow me to see the issue when replaying the apitrace file.

https://drive.google.com/file/d/16-pYYrX0kJ98ADJJeEgwgW0WX6mM82xT/view?usp=sharing

Should be fixed now.


feat(es-dev-server): enable compression

affects: es-dev-server
closes #723

note this uses the koa-compress default threshold of 1kb, but can be configured by passing a koa-compress options object instead of true as the compress config item.
createConfig({ compress: { threshold: 1 } });

Do you think turning this on by default will speed things up locally?

Not necessarily, but as mentioned in the issue, since it's best practice, and cheap to enable, (and for other reasons cited there) we might as well.

@LarsDenBakker please check and give 👍  or 👎  for using compress by default

Lets do compression by default


[QA] CUDA out of memory in training

Describe the question.
I follow the steps in usage to finetune the model. But I can not load the model with 8 RTX3090 (24G). I have tried to set zero1 in parallel config as [-1, 8].
The environment is the same to install.

It seems that 24G memory is not large enough for training. We will try some other methods to reduce the GPU memory consumption later.


Use owner as the primary key for settings table

** Which Category is your question related to? **
Appsync + Backend files
** What AWS Services are you utilizing? **
Cognito, AWS AppSync, Api, Auth
** Provide additional details e.g. code snippets **
I would like to make the owner the primary key, here is the code for my @model
type User
	@model(
		queries: { get: "getUser" },
		mutations: { create: "createUser", update: "updateUser" }
	)
	@key(fields: ["owner"])
	@auth(rules: [
		{ allow: owner },
		{ allow: private, operations: [read] }
	]) {
		owner: String!
		email: String!
		phoneNumber: String
		image: String
		noviaties: [NoviatyUser] @connection(keyName: "byUser", fields: ["owner"])
		status: Status
}

If I go into my Appsync api, I can update
input CreateUserInput {
	owner: String!
	email: String!
	phoneNumber: String
	image: String
	status: Status
}

to:
input CreateUserInput {
	email: String!
	phoneNumber: String
	image: String
	status: Status
}

and go into the resolver and comment out the following:
## [Start] Set the primary @key. **
#set( $modelObjectKey = {
  "owner": $util.dynamodb.toDynamoDB($ctx.args.input.owner)
} )
## [End] Set the primary @key. **

It works as should, however every time I run amplify push I have to update this. I was wondering how I can make the owner the primary key and how can I add/view/update my resolvers in my files?

@jarkin13 The CLI doesn't overwrite self-specified types. So if you have your input type defined in the schema, the transformer won't overwrite it. Also, the transformer supports custom resolvers, for which you can take a look out here - https://aws-amplify.github.io/docs/cli-toolchain/graphql#custom-resolvers

@jarkin13 I had the same issue and I fixed it by replacing
owner: String!

with
owner: String

(removed the !)


Attributes description

For review ONLY – do not merge
This Pull Request proposes the way to describe Resource, Action and arbitrary message-body attributes in a reusable way. It also proposes the introduction of "data dictionary" to API Blueprint. In addition changes in this PR suggest that, if a message-body data structure is fully described using the attributes description, an explicit example asset (e.g. a JSON blob) is not needed and can be omitted from a blueprint.
Please read (and review) following examples:

Attributes
Advanced Attributes
Data Structures

Also, in particular, read (and review) following sections of API Blueprint Specification

Attributes section
Data Structures section

Update
Added description of Attributes section in

Resource section
Action section

This PR closes #25

This is really useful, any update on this PR?

@MichielDeMey We are hashing a few other details for this PR. Hopefully we will merge it soon.


No native function to lock and unlock the device with PIN

I am working on a mobile app that works only on physical devices for security reasons.
Also, the SDK that I used keeps user's data in secure storage and access to it is possible only if the user's device has PIN authentication set up. The SDK blocks access to the storage if the device has been unlocked for more than 5 minutes. In that case, the user needs to lock the device and unlock it again (with the PIN code).
Now, I need to write an automated test that:

locks the device
unlocks the device with a PIN code (it should work both on Android and iOS)
performs the actual tests

In the Patrol documentation I couldn't find any function that would allow for the lock and unlock operation.
Also - ideally - I would like to run the tests in Firebase Test Labs and for this reason I need a set of physical devices that are PIN-locked.
Is that all achievable or it's way beyond what Patrol and Firebase Test Labs offer?

Hi @lukasz8888 – thanks for creating this issue and sharing your use case. Sounds quite niche.

locks the device

Normal apps cannot do this, and Patrol doesn't have any built-in functionality to do this. Looks like it could be possible by making an app a device admin, but then I'm pretty sure it won't run on devicelabs.

unlocks the device with a PIN code (it should work both on Android and iOS)

This should work, given that the automation was running before the screen was locked. I performed a native view hierarchy dump on my Android emulator and (as I expected) the UI has added accessibility labels, so it should be possible to tap on them like this:
await $.native.tap(Selector(text: "1"));

I would like to run the tests in Firebase Test Labs and for this reason I need a set of physical devices that are PIN-locked.

I'm pretty sure FTL doesn't support it.

Closing to clean up the backlog. We don't plan to add such features.


data augmentation and weight decay

Hi,
In data augmentation, do you use random crop or random resized crop?
Thanks,
Yifan

The model that I released are trained by random crop + random horizontal flip.
I've tried resized crop + RGB Jitter + image distortion + random horizontal flip, but it didn't worked very well. There might be something wrong in my data augmentation codes.

Hi,
I also noticed that in your protobuf log, some module's learnable  parameter's weight decay factor was set to 0 while it's lr is non-zero. Could you elaborate on which kind of parameter needs weight decay and which do not? Thanks!

It's a standard protocol for Caffe that some lr & wd of BN & Scale layers should be set to 0. Nothing special.

@miaow1988  Do you mean the scale and bias factor in BN (in Pytorch that is affine=True) should not be included in weight decay?

Thank you for the clarification. It helps a lot!


supplement cpp syntax coloring

believe me, it will looks great

@Demonese : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Demonese : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Upload CSV to partner portal

Summary

Add a script, like the device repository, to sync the contents of this repo to Airtable so it can be used with the Partner Portal.
Changes

Add a script that converts all the templates into a csv
Update workflow to automate syncing to airtable

Notes for Reviewers

@benolayinka let me know if this seems correct.
Checklist

[ ] Scope: The referenced issue is addressed, there are no unrelated changes.
[ ] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[x] Testing: The changes are tested.
[ ] Documentation: Relevant documentation is added or updated.

I have manually tested it with the airtable Sync API, and all the fields look correct.


Add scFoundation/CellPLM

Is your feature request related to a problem? Please describe.
I intend to implement the functions of using scFoundation and CellPLM for batch integration, evaluated in the embeddings level.
Describe the solution you'd like
I intend to implement the functions of using scFoundation and CellPLM for batch integration, evaluated in the embeddings level.
Describe alternatives you've considered
After reveiwing the implementation of Geneformer and scGPT, I believe that the zero-shot version is enough.
Additional context
N/A.

Hi @HelloWorldLTY
Adding one or both of these models would be great. It should like you have already looked at the code for some of the methods but you can find more information about how to contribute components here https://openproblems.bio/documentation/. We also have a weekly co-working meeting where some of the core developers will be available to answer questions https://openproblems.bio/events/weekly_coworking/.

Hi thanks, I will join the weekly meeting. I have tested the codes in cloud and they work well. I also have some problems in running the 1.1.0  version openproblems codes. If I use openproblems/1.0.4, I will meet an error known as no module: openproblems. I will try to figure them out.

Great! If you use one of our prepared Docker images all the Open Problems code should already in included and you just need to add packages for the method you are adding.


 Alive actors are not recreated on error, but stick around and don't have to load data again. We can also choose to not restart failed actors, continuing training with fewer actors.
Depends on #21.

@amogkam can you review first?
also, the test is timing out. I think we should also put a time limit (10 minutes or something) on GHA :)

Yep, I'll try to fix the test today and will introduce the timeout

It seems some resources are not cleaned up properly. I noticed that with the queue actor before, maybe it affects the event driver, too. I'll look into this.

This should be ready for review @amogkam

Thanks I'll review it today

Thanks a bunch for the thorough review. I addressed all your comments and tried to answer your questions!

I’ll review this PR later tonight!
On Fri, Dec 11, 2020 at 9:11 AM Amog Kamsetty<EMAIL_ADDRESS>wrote:

@amogkam commented on this pull request.
In xgboost_ray/main.py
https://github.com/ray-project/xgboost_ray/pull/23#discussion_r541097819
:

                   **kwargs)

               result_dict.update({

                   "bst": bst,

                   "evals_result": evals_result,

                   "train_n": self._local_n

               })

       except XGBoostError:

           # Silent fail, will be raised as RayXGBoostTrainingStopped

           return

   thread = threading.Thread(target=_train)

   thread.daemon = True

   thread.start()

   while thread.is_alive():

       thread.join(timeout=0)

       if self._stop_event.is_set():

Got it, makes sense! Do you think you can add this ^ as a comment in the
code?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ray-project/xgboost_ray/pull/23#discussion_r541097819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCRZZI42L7RWJA3DD3IHSTSUJHCZANCNFSM4UQURGRA
.

Actually, 1 question I have is --
when you have 4 actors on 4 nodes, and 1 of the nodes die, where do you check the number of cluster resources to resume with only 3 workers?

Since we re-use the existing actors, we currently don't check the cluster resources at all - we just invoke the local train() function on the remaining actors.
Thanks a  lot for the review by the way! I addressed the comments and just added a bunch of in-code documentation for better understanding of the code.

Unfortunately, my cluster yaml (and snapshot) no longer works. One last comment/question about actor recovery -- I keep re-reading the recovery code and it seems like the actors are always restarted. Can you help explain the purpose/code flow of _failed_actor_ranks?

I'll run a couple of tests on a cluster later and post the results here.

Re: _failed_actor_ranks: This set collects the ranks of failed actors. These are restarted on a call to _train. Note that we have the same information in the _actors list, as we could just filter for None values - however, the difference here is that we want to be able to deliberately alter the _failed_actor_ranks in order to re-start only specific nodes.
For instance, for elastic training we currently clear the set, so no actors will be restarted. In future failure handling modes we could only start actors that have resources available. With this object we can thus specify exactly which ranks we want to start and which not.
In the train() function the set is called start_actor_ranks, as it semantically describes which ranks will be started by _train(). In _train() though it is called _failed_actor_ranks as, after starting actors, it collects the ranks of failed actors. Would it be more clear if we renamed _failed_actor_ranks to _start_actor_ranks in _train() as well?
I can also add more comments to this - e.g. annotate the internal variables passed to _train().

Works fine in my tests. Here is the results log for killing 2 nodes:
base) root@ip-172-31-18-125:/release_tests# python benchmark_cpu_gpu.py 10 100 200
2020-12-14 10:42:37,239 INFO worker.py:651 -- Connecting to existing Ray cluster at address: <IP_ADDRESS>:6379
2020-12-14 10:42:37,992 INFO main.py:620 -- [RayXGBoost] Created 10 new actors (10 total actors).
2020-12-14 10:42:40,938 INFO main.py:638 -- [RayXGBoost] Starting XGBoost training.
(pid=4107, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140004211236752 got new rank 2
(pid=4038, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140546107764624 got new rank 5
(pid=4005, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140103861936592 got new rank 4
(pid=4006, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140411510034704 got new rank 7
(pid=4037, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:139927338557264 got new rank 0
(pid=3993, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140255472527504 got new rank 3
(pid=4074, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140038723952528 got new rank 6
(pid=3939, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140290278254992 got new rank 9
(pid=4107, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140133743529872 got new rank 8
(pid=4011, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140660999946128 got new rank 1
E1214 10:42:53.648838  3040  3055 task_manager.cc:323] Task failed: IOError: 2: user code caused exit: Type=ACTOR_TASK, Language=PYTHON, Resources: {}
, function_descriptor={type=PythonFunctionDescriptor, module_name=xgboost_ray.main, class_name=RayXGBoostActor, function_name=train, function_hash=},
task_id=019554c512c2b9b51bd49a5609000000, task_name=RayXGBoostActor.train(), job_id=09000000, num_args=10, num_returns=2, actor_task_spec={actor_id=1b
d49a5609000000, actor_caller_id=ffffffffffffffffffffffff09000000, actor_counter=4}
E1214 10:42:53.650756  3040  3055 task_manager.cc:323] Task failed: IOError: cancelling all pending tasks of dead actor: Type=ACTOR_TASK, Language=PYT
HON, Resources: {}, function_descriptor={type=PythonFunctionDescriptor, module_name=xgboost_ray.main, class_name=RayXGBoostActor, function_name=pid, f
unction_hash=}, task_id=b9fed017052010151bd49a5609000000, task_name=RayXGBoostActor.pid(), job_id=09000000, num_args=0, num_returns=2, actor_task_spec
={actor_id=1bd49a5609000000, actor_caller_id=ffffffffffffffffffffffff09000000, actor_counter=5}
2020-12-14 10:42:53,729 INFO main.py:489 -- Actor status: 9 alive, 1 dead (10 total)
2020-12-14 10:42:53,729 WARNING main.py:851 -- A Ray actor died during training. Trying to restart and continue training from last checkpoint (restart
 1 of 2). This will use 9 existing actors and start 0 new actors.Sleeping for 10 seconds for cleanup.
2020-12-14 10:43:03,750 INFO main.py:620 -- [RayXGBoost] Created 0 new actors (9 total actors).
2020-12-14 10:43:03,758 INFO main.py:638 -- [RayXGBoost] Starting XGBoost training.
(pid=4107, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140004211236752 got new rank 2
(pid=4038, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140546107764624 got new rank 5
(pid=4011, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140660999946128 got new rank 1
(pid=4037, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:139927338557264 got new rank 0
(pid=4006, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140411510034704 got new rank 6
(pid=3993, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140255472527504 got new rank 3
(pid=4005, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140103861936592 got new rank 4
(pid=4107, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140133743529872 got new rank 7
(pid=3939, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140290278254992 got new rank 8
E1214 10:43:15.269685  3040  3055 task_manager.cc:323] Task failed: IOError: 2: user code caused exit: Type=ACTOR_TASK, Language=PYTHON, Resources: {}
, function_descriptor={type=PythonFunctionDescriptor, module_name=xgboost_ray.main, class_name=RayXGBoostActor, function_name=train, function_hash=},
task_id=aff64b4aedc094a1f90e593909000000, task_name=RayXGBoostActor.train(), job_id=09000000, num_args=12, num_returns=2, actor_task_spec={actor_id=f9
0e593909000000, actor_caller_id=ffffffffffffffffffffffff09000000, actor_counter=10}
E1214 10:43:15.271399  3040  3055 task_manager.cc:323] Task failed: IOError: cancelling all pending tasks of dead actor: Type=ACTOR_TASK, Language=PYT
HON, Resources: {}, function_descriptor={type=PythonFunctionDescriptor, module_name=xgboost_ray.main, class_name=RayXGBoostActor, function_name=pid, f
unction_hash=}, task_id=b55dd8e99d574a31f90e593909000000, task_name=RayXGBoostActor.pid(), job_id=09000000, num_args=0, num_returns=2, actor_task_spec
={actor_id=f90e593909000000, actor_caller_id=ffffffffffffffffffffffff09000000, actor_counter=11}
2020-12-14 10:43:15,367 INFO main.py:489 -- Actor status: 8 alive, 2 dead (10 total)
2020-12-14 10:43:15,367 WARNING main.py:851 -- A Ray actor died during training. Trying to restart and continue training from last checkpoint (restart
 2 of 2). This will use 8 existing actors and start 0 new actors.Sleeping for 10 seconds for cleanup.
2020-12-14 10:43:25,388 INFO main.py:620 -- [RayXGBoost] Created 0 new actors (8 total actors).
2020-12-14 10:43:25,394 INFO main.py:638 -- [RayXGBoost] Starting XGBoost training.
(pid=4006, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140411510034704 got new rank 5
(pid=3993, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140255472527504 got new rank 2
(pid=4005, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140103861936592 got new rank 3
(pid=3939, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140290278254992 got new rank 7
(pid=4107, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140133743529872 got new rank 6
(pid=4037, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:139927338557264 got new rank 0
(pid=4011, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140660999946128 got new rank 1
(pid=4038, ip=<IP_ADDRESS>) [10:43:25] task [xgboost.ray]:140546107764624 got new rank 4
(pid=4074, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140038723952528 got new rank 6
(pid=4074, ip=<IP_ADDRESS>) 2020-12-14 10:42:53,643    ERROR worker.py:384 -- SystemExit was raised from the worker
(pid=4074, ip=<IP_ADDRESS>) Traceback (most recent call last):
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 551, in ray._raylet.task_execution_handler
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 438, in ray._raylet.execute_task
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 477, in ray._raylet.execute_task
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 481, in ray._raylet.execute_task
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 482, in ray._raylet.execute_task
(pid=4074, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 436, in ray._raylet.execute_task.function_executor
(pid=4074, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/ray/function_manager.py", line 553, in actor_method_executor
(pid=4074, ip=<IP_ADDRESS>)     return method(actor, *args, **kwargs)
(pid=4074, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/xgboost_ray/main.py", line 390, in train
(pid=4074, ip=<IP_ADDRESS>)     time.sleep(0.1)
(pid=4074, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/ray/worker.py", line 381, in sigterm_handler
(pid=4074, ip=<IP_ADDRESS>)     sys.exit(1)
(pid=4074, ip=<IP_ADDRESS>) SystemExit: 1
(pid=4107, ip=<IP_ADDRESS>) [10:42:40] task [xgboost.ray]:140004211236752 got new rank 2
(pid=4107, ip=<IP_ADDRESS>) [10:43:03] task [xgboost.ray]:140004211236752 got new rank 2
(pid=4107, ip=<IP_ADDRESS>) 2020-12-14 10:43:15,245    ERROR worker.py:384 -- SystemExit was raised from the worker
(pid=4107, ip=<IP_ADDRESS>) Traceback (most recent call last):
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 551, in ray._raylet.task_execution_handler
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 438, in ray._raylet.execute_task
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 477, in ray._raylet.execute_task
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 481, in ray._raylet.execute_task
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 482, in ray._raylet.execute_task
(pid=4107, ip=<IP_ADDRESS>)   File "python/ray/_raylet.pyx", line 436, in ray._raylet.execute_task.function_executor
(pid=4107, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/ray/function_manager.py", line 553, in actor_method_executor
(pid=4107, ip=<IP_ADDRESS>)     return method(actor, *args, **kwargs)
(pid=4107, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/xgboost_ray/main.py", line 390, in train
(pid=4107, ip=<IP_ADDRESS>)     time.sleep(0.1)
(pid=4107, ip=<IP_ADDRESS>)   File "/root/anaconda3/lib/python3.7/site-packages/ray/worker.py", line 381, in sigterm_handler
(pid=4107, ip=<IP_ADDRESS>)     sys.exit(1)
(pid=4107, ip=<IP_ADDRESS>) SystemExit: 1
2020-12-14 10:45:12,824 INFO main.py:731 -- [RayXGBoost] Finished XGBoost training on training data with total N=160,000,000.
TRAIN TIME TAKEN: 155.57 seconds
Final training error: 0.4951
TOTAL TIME TAKEN: 155.58 seconds (0.03 for init)
(base) root@ip-172-31-18-125:/release_tests#

Note that the last two errors are sent to the driver some time after the nodes died.
I'll push some cosmetic changes, but other than I think we should be ready to merge.

nice!


ace compatibility for "demanufacture garage"

demanufacture garage works with ace-repair, now. no need for building a repair vehicle.

Changed to the variable (maybe someone don't use the default building)
Thanks :)


Fix uclibc build

Without sys/types.h the build breaks with errors like this:
parse_file.h:28:5: error: unknown type name ‘off_t’
off_t *map;
^

Doh... Thanks for taking the time to fix this!

Coverage remained the same at 85.099% when pulling 0301cb4ffbf4705316ba017516745a535d66d552 on bkuhls:uclibc into 9c97483865fcd267b004e4dafc63d3176f51b638 on fhunleth:master.

And thanks for bumping the fwup version on Buildroot!


Y24-039 Addition of sample "RETENTION INSTRUCTION" field in automated manifests (used by ToL)

User story
As an SSR, I want sample destruction/retention instructions for all samples to be recorded when samples are receieved through the ToL automated manifest messages  to allow for correct audit tracking.
This data ensures samples are not destroyed by mistake and allows effective sample return to the sample custodians. This is an essential function that allows teams to follow the SeqOps sample retention & destruction policy.
Who are the primary contacts for this story
Nathalie S., Alice
Who is the nominated tester for UAT
Alice

To confirm she can see retention instructions for plates/samples received by automated manifest - this could be done by the team if we know where she is looking

Acceptance criteria
To be considered successful the solution must allow:

[ ]  All messages received on the current message schema version are treated as implicitly specifying "Return to customer after 2 years" for the retention field
[ ]  We create a new version of the message schema that includes a new required parameter “retention_instruction” for each plate/tube submitted.
[ ]  Documentation to describe the both message schema versions is updated and shared with stakehoders.
[ ]  Our message consumers are updated to support both message schema versions.

This will allow ToL to continue to submit samples without changing their systems, until they need to vary the retention instruction.
References
This story has a non-blocking relationship with:
https://rt.sanger.ac.uk/Ticket/Display.html?id=799922
Additional context

4 stories:

update the schema
update ToL lab share
update traction service
update unified warehouse

Stories:

https://github.com/sanger/General-Backlog-Items/issues/412
https://github.com/sanger/tol-lab-share/issues/121
https://github.com/sanger/traction-service/issues/1349
https://github.com/sanger/unified_warehouse/issues/633


E-mail notifications for chain frontend

@timstokman can you give a description on what you mean by this?


[ SD ] Fix Generation for several requests

CVS-157577

Please, manually port to 2025.0

Please, manually port to 2025.0

Had ported to master. Please review https://github.com/openvinotoolkit/openvino.genai/pull/1171

Please, manually port to 2025.0

Had ported to master. Please review #1171

that PR contains more fixes.
I would merge step by step..


Doubt about Multilingual Screen Capture

Hello,
If I am going to take screenshot of multilingual website (utf-8), then the screenshot appears with rectangular boxes instead of characters. (Please refer attached screenshot of Arabic Website)
Q. PhantomJS screen capture library worked with multilingual website screenshots or not?

Hello,
The squares appear because you probably don't have the required fonts installed. You need to install:
FontConfig - apt-get/yum install fontconfig
FreeType - apt-get/yum install freetype*


ci: Remove needs-triage auto-add

Fixes #910
Description
The bot should now auto-add this label with: https://github.com/kubernetes/test-infra/blob/63c23493ceefcfdedc7571fa42504b0ba94d7a5b/config/prow/plugins.yaml#L831
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 78.859%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
8352

Relevant Lines:
10591

💛  - Coveralls

/lgtm

/lgtm


10 February 2023

Task Lists

[ ] #698
[ ] #701
[ ] #734
[ ] [Python3] Add Python3 Solution for Problem Of The Day
[ ] [C] Add C Solution for Problem Of The Day (optional)
[ ] [C#] Add C# Solution for Problem Of The Day (optional)
[ ] [JavaScript] Add JavaScript Solution for Problem Of The Day (optional)

FAQ
How do I get assigned to these issues?
You must leave a comment with the issues you want assigned.
Is there any limit to the number of issues that can be assigned?
Yes, one person can only be assigned two issues per day from the four (README, C++, Java, and Python 3).
Can I be assigned to multiple issues on different days by commenting once?
Yes, you can be assigned to multiple issues on different days by commenting once. However, you must be assigned to the contributor role in order to do so. If you already have access to the contributor role, simply list the issue in a comment that you want to be assigned to.
Example:
01 January 2023 - Java & Python
04 January 2023 - README.md & Java
12 January 2023 - C++
19 January 2023 - README.md

How do I get access to the Contributor role?
You must contribute 2-3 times before being granted access to the contributor role.
Can I be assigned to issues that are optional?
If [C], [C#], or [JavaScript] are available for the problem of the day, you can be assigned to it on the day of the problem.

Assigning someone, merging pull requests, and so on may take some time on this issue because I'll be busy all day!


Change error code to 422 when redirectBackBase is not whitelisted

https://github.com/rancher/rancher/issues/16533

LGTM


Credential Usage and Expiration

Hello,
I think it would be helpful to know what actually happens when you run NuGet CLI commands after the CredentialProvider.vss.exe is put in its proper place. If you are logged into Windows Active Directory that's linked to Azure Active Directory, then it seems to use that as your user for the commands. If you are logged in with a user without that, then a browser window appears asking you to log into a Microsoft account. It then stores those credentials somewhere. It would be nice to know where those credentials are stored since we first feared that they might be stored within the exe itself, which we thought would be too insecure for our purposes. It would be nice to know where they are in case we need to remove/reset them for any reason. Also, it would be nice to know if the username/password credentials stored expire at some point and how long that might be.
EDIT 2018-05-10 10:58 AM: It would also be nice to know if when you first run a command using AD credentials, then does it store those credentials as well? Never mind. It looks like it doesn't from our testing.
Thanks for your time,
Steve

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab0a3735-a9b0-2ed7-f08f-5321f55f8c90
Version Independent ID: 2153f6c0-def7-eed1-286d-5e61c9fcbec4
Content: Use NuGet with VSTS feeds
Content Source: docs/package/nuget/nuget-exe.md
Service: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

In my case it asked for credentials once. I was able to push then but now I get access denied and I don't know where to go to fix the credentials.

Adding @alexmullans to knock out some of these questions, looks like it has gotten quite some momentum from the community. Alex, maybe we should think about adding an "Authentication" concepts doc or something?

I solved my issue, but it is strange behaviour  https://stackoverflow.com/questions/52798199/access-is-denied-error-pushing-package-into-my-azure-devops-artifacts-nuget-feed

Closing per Issue creators latest update.


Auto-Exchange feature expansion

Would be really nice if I could set auto-exchange only to certain coins. There doesn't seem to be any consistency to when I click the arrow in the direction of 'credited' as to whether a coin is simply credited to me or automatically goes to the exchange. I have now shut off the auto-exchange option, but would really like to be able to have only some coins auto-exchange. If there was a way to, maybe, exempt some coins from auto-exchange, that would be fine, too. Maybe, for example, only have auto-exchange active if I don't have a wallet withdrawal address entered? But if I do have a wallet withdrawal address entered, always credit my local wallet until my withdraw amounts are reached.

I am not sure what you are referring too. MPOS allows and should enforce an auto transfer for mined coins for each user. Leaving coins on the pool is a bad thing and should be avoided at all times. If you enter your personal wallet address as the destination, that's where coins are sent to. If you add an exchange address, it will be sent to an exchange.
Maybe you are confusing MPOS with a customized version running on a pool you access? MPOS supports multiple pools with one authentication backend but doesn't support multicoin in a single backend.

I think you did confuse a pool feature running someplace with a basic MPOS feature. There is no auto-exchange option in MPOS. Only a coin limit that will trigger a wallet transfer to the configured address for each user.


⚠ AGEG website (prod) has degraded performance

In 7016f5e, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2204 ms

Resolved: AGEG website (prod) performance has improved in 1169ca5.


Fix to tb -h problem at issue #46

Actually a fix was done before but issue is now  again occurring. Fixed the cli.js for that.

Screenshot is here,

duplicate https://github.com/klauscfhq/taskbook/pull/14/files

Wait, what? Sorry I thought the the fix was applied and then got removed.. Now I notice that the earlier PR didn't merge in the first place.

It's a pretty simple fix, I don't know why the owner won't merge it. As he didn't merge it 3 days back, the consequence was that another guy issued a new issue which i read and created the fix again. After all of that has happened, we are still on square one.

Fixed on #14.
Thank you for taking the time to submit the pull request : )


integrations for ceph and migrating to the new charmcraft.yaml

This PR additionally merges our yaml files into charmcraft.yaml.
Issue

Ceph, among other solutions, require embedding of panels and anonymous access.
Solution

Allow anonymous access and embedding of dashboard panels. Configured through juju config, which defaults to disabled.
Context

Testing Instructions

Enable the configs and try to access Grafana.
Make a dashboard embeddable and try embedding it somewhere.

Upgrade Notes

N/A

LGTM.
Shouldn't we have an integration test that checks you can access a dashboard with anonymous access?

To me, that feels a little bit like testing the workload, to be honest.


Travis ci config

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6b5fe60). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   52.31%
=========================================
  Files             ?        6
  Lines             ?      302
  Branches          ?        0
=========================================
  Hits              ?      158
  Misses            ?      144
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5fe60...71e6b8d. Read the comment docs.


lazy init of PxerApp

This PR included the following fixes and optimizations

Fixed a issue where a recent change in Pixiv caused worksNum for bookmark_new pages failed to be read.
Added a init stage for pxer and moved the init of PxerApp.worksNum to an asynchronous init method for the sake of user experience and prepare for more async init procedures in the future.

记得同步单元测试

好的 我这两天另开一个pr补全缺少的测试


Image refererence in pbviz file

Hi, I need to find out the best way provide images in Power BI custom visuals to generate textures on for instance a 3d model. Is it possible to package these images up within the custom visual? Currently the pbiviz.json file has an “assets” reference where the icon.png is stored.  Can I do the same with other images and reference this in the code?  If so, I need to know how I reference this. Alternatively a URL reference approach may work.

I want to do the same thing but can not found any related document or example.

See https://github.com/Microsoft/PowerBI-visuals/issues/41
To my understanding, currently there are two options:

Deploy the images on a CDN server and load the images from there.
Embed the images as data-uri strings in your own JavaScript code or CSS files.

We solved concatenating our css in just one style/visual.less file and converting the images to base64.
https://www.base64-image.de/

Images might be embedded into CSS by using data-uri function of LESS CSS.

Hmm. So what is that assets directory for anyway?

Assets directory is for an icon. This is the main purpose.
Anyway, you can store any files in this directory but they will not be included in pbiviz package automatically.

Well, I guess I can hard-code an image (I am working in R and it is not too hard), but seems ugly and rather bloated. I tried to download it from an external server with RCurl, but it wouldn't connect. I suppose they won't let me out of the sandbox, right?

@ignatvilesov can you please help with the documentation or any example of embedding image/icon on power bi custom visual

@uve Could you please help @grajamanickam ?

@grajamanickam tools uses base64-inline-loader of webpack.
You can import images as base64 string:
const icon = require("../assets/icon.png");

or specify another loader for the file:
https://github.com/microsoft/PowerBI-visuals-tools/issues/303#issuecomment-601401473

@ignatvilesov, @zBritva I really appreciate your help.  Sorry iam a newbie to the custom visual development.  Do you have a sample .ts code?

@grajamanickam you find here: https://github.com/zBritva/powerbi-visuals-webpack-loader-test/blob/master/src/visual.ts#L41
But in the sample, csv file and custom loader is used.

thanks @zBritva !
I just ended up using the below code
I ended up using the below code
this.svg
.append("svg:image")
.attr("xlink:href","https://.../512.png")
.attr("x", "50%")
.attr("y", "30%")
.attr("width", "130")
.attr("height", "130");


Build on nightly failed

Probably not important, but easy to fix.
Build on nightly failed (1.62.0-nightly (f4ec0e7cf 2022-04-22))
cargo +nightly c
    Checking twitch-tui v2.0.0-alpha.3 (/home/balrog/src/twitch-tui)
error[E0283]: type annotations needed
  --> src/ui/mod.rs:62:35

Possible fix:
diff --git a/src/ui/mod.rs b/src/ui/mod.rs
index f32f5b7..681b8e3 100644
--- a/src/ui/mod.rs
+++ b/src/ui/mod.rs
@@ -51,7 +51,7 @@ pub fn draw_ui<T: Backend>(frame: &mut Frame<T>, app: &mut App, config: &Complet
     let vertical_chunks = Layout::default()
         .direction(Direction::Vertical)
         .margin(margin)
-        .constraints(vertical_chunk_constraints.as_ref())
+        .constraints(vertical_chunk_constraints.as_slice())
         .split(frame.size());

What are your thoughts on moving this project to nightly builds?
I am unsure myself, as I don't run nightly.

It's only a proposal for the future or limitation of tui.
Nightly builds are unstable, I don't think the project or users win from this . Each iteration of the compiler gains a little bit of speed (around 1-2% what I saw), not so many. For myself, I just change the default linker and that's all.
Feel free to close this issue if you want.

I don't think we need to focus on nightly at this current time, but I'll definitely think about this for the future.
Thanks for bringing it up!


Warning: could not find bison/Error: Missing requirements

Hi
I am trying to install GVM on windows via gitbash.  When running the curl command, it says that it successfully installs GVM.
When I close the terminal and open a new one, I try running GVM and it says command not found.
I then run  source ~/.gvm/scripts/gvm to try and locate it, and when I use the command GVM after that I get this error:
$ gvm
WARNING:
Could not find bison

  linux: apt-get install bison

ERROR: Missing requirements.

Does this mean I need to install bison in order to use GVM? I tried installing flex-bison via chocolatey for windows, but I'm guessing it's not recognizing it as bison.
Any suggestions?

Try to use WSL2 on Windows to run an distro linux and install gvm inside of your distro.


Have any plans to support coc.nvim?

Coc-snippets is good enough to use LSP snippets, but it has a fatal flaw that it cannot detect press holder changes.
Is it possible to make user-defined snippets of LuaSnip work with Coc.nvim completion?

Tbh no, hadn't thought about that yet. Could be trivial if they have some setting where users can provide their own functions for lsp-snippet expansion.
If no, do you have ideas on where to look for snippet expansion in coc?

Here's a quote from F.A.Q

Q: Some ultisnips snippet not works as expected.
A: Reformat after change of placeholder feature can't be supported for now, andsome regex pattern can't be converted to javascript regex pattern, so the snippet can be failed to load.

I don't think it is necessary to support LSP snippets. It is enough to be able to pass user-defined snippets to coc as a completion source.
I'm sorry if my English was not good enough to understand your intentions.

Ahh, so you'd like to have Luasnips' snippets show up in (and expand from) cocs' completion menu?

Yes! Sorry for the confusion.

Np, I also misunderstood your first message😅
I'll focus on built-in lsp and improving Luasnip in general right now, but I'll keep coc in mind and come back to your suggestion at a later date.

How does one achieve this?

Basically do what cmp_luasnip does (complete and execute-functions here), but for coc.nvim.
I don't know at all how their sources work though :/

Hmmm....
Might be above my paygrade haha. I surrendered for now and switched to coc-snippets since my main issue was input lag with ultisnips.
For coc and ultisnips, I installed "Coc-Ultisnips" and that automatically adds snippets as a completion source, perhaps it could be just as easy to do with LuaSnips:
https://github.com/neoclide/coc-sources/blob/master/packages/ultisnips/index.js

Oh right, coc uses javascript... lua can be called through the api though, maybe one could even repurpose parts of cmp_luasnip (is there a general cmp-to-coc-source converter? Does not look impossible to implement)

I tried to create coc-luasnip.

Oh sick! 🎉🎉
I guess there's some shared functionality with cmp_luasnip, do you think it would make sense to include some of it in luasnip?

Yes, the lua portion is much covered since it looks like this.

code
local util = require("vim.lsp.util")

local M = {}

local snip_cache = {}
local doc_cache = {}

local function get_documentation(snip, ft)
	if doc_cache[ft] and doc_cache[ft][snip.id] then
		return doc_cache[ft][snip.id]
	end

	local header = (snip.name or "") .. " _ `[" .. ft .. "]`\n"
	local docstring = { "", "```" .. vim.bo.filetype, snip:get_docstring(), "```" }
	local documentation = { header .. "---", (snip.dscr or ""), docstring }
	documentation = util.convert_input_to_markdown_lines(documentation)
	documentation = table.concat(documentation, "\n")

	doc_cache[ft] = doc_cache[ft] or {}
	doc_cache[ft][snip.id] = documentation

	return documentation
end

function M.getCompletionItems()
	local filetypes = require("luasnip.util.util").get_snippet_filetypes()
	local items = {}

	for i = 1, #filetypes do
		local ft = filetypes[i]
		if not snip_cache[ft] then
			-- ft not yet in cache.
			local ft_items = {}
			local ft_table = require("luasnip").get_snippets(ft, { type = "snippets" })
			if ft_table then
				for _, snip in pairs(ft_table) do
					if not snip.hidden then
						table.insert(ft_items, {
							word = snip.trigger,
							info = get_documentation(snip, ft),
							menu = "[LuaSnip]",
							isSnippet = true,
						})
					end
				end
			end
			snip_cache[ft] = ft_items
		end
		vim.list_extend(items, snip_cache[ft])
	end

	return items
end

return M

The problem is that I am a cmp user and just created this on a whim, so I am not sure if I can maintain it. I'll give it all away so someone can be the maintainer.

The problem is that I am a cmp user and just created this on a whim, so I am not sure if I can maintain it. I'll give it all away so someone can be the maintainer.

That's understandable, what do you say @dseeni? :P

Okay, was worth a shot :D

I guess I'm a bit late to the party, but I just tried to use LuaSnip and after a little trouble adapting to lua and stuff it worked. But I use coc.nvim for Python, C/C++, JS/TS etc. So I tried adding this this to my configuration, and it works. But when I'm using coc.nvim's autocompletion, it overrides entries that were introduced by nvim-cmp. And when I tried to fix it with this plugin, it just did nothing (nothing was showing up).
So I would like some help with my problem, if someone knows any solution (or maybe I should open a new issue). Thanks.

Ah, there's no support for coc-nvim except coc-luasnip (which is not maintained), sorry :/
You could try getting coc-luasnip up-to-date, I think you could basically start out with cmp-luasnip and just adapt it to coc-nvim (or look for some kind of compatibility-layer)

Ok, I guess, this is my homework now... Thank you.
P.S. If I achieve some progress on this integration, then I'll post about it here.

It is not maintained, but was working at the time it was created. Minimal functionality, though.
So I think it would be a good way to fix coc-luasnip. I don't use coc anymore, so it's hard for me to help.

Understandable. If I will have time and motivation - I'll try and make it work.


Lenovo Drivers Catalogv2 version'

It appears the downloading fails when the model download link in the xml Catalog contains <SCCM version="*">. From the logs, it seems the Script knows about the download path and assumes the .EXE that should have been downloaded. Manual browser download works, placing the file in the correct directory and then running DAT over again, sees the file and does the next steps.
Get-Item : Cannot find path '\<path\to>\Driver Cab\tc_m900z_w1064_201602.exe' because it does not exist.
At line:16985 char:81

... e size:  $((Get-Item -Path $($DownloadRoot + $Model + '\Driver Cab'  ...

            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (\<path\to>\Dr...1064_201602.exe:String) [Get-Item], ItemNotFoundException
FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetItemCommand

Browser Duplicated Issue post


Starscream's socket.isConnected is always returning false

I'm developing an iOS application using Swift that connects to an Android device via sockets. I've implemented Starscream and was able to connect to the other device. My issue is that when I print something on the websocketDidConnect delegate method, it does not print. Also when I print socket.isConnected, it prints false. Kindly help me. Also, thanks for creating this library.
`import Starscream
class SettingsViewController: UIViewController, UITextFieldDelegate, WebSocketDelegate{
override func viewDidLoad() {
        super.viewDidLoad()

    let socket = WebSocket(url: NSURL(string: "ws://\(ipAddressTextField.text!):4000/")!)
    socket.connect()

    print("socket.isConnected \(socket.isConnected)") //this one is false

    socket.onConnect = {
        print("Connected...") // does not print
    }

    socket.onDisconnect = { (error: NSError?) in
        print("websocket is disconnected: \(error?.localizedDescription)") // this one prints when I turn the wifi off
    }

    socket.onData = { (data: NSData) in
        print("got some data: \(data.length)")

    }

}

func websocketDidConnect(ws: WebSocket) {
print("websocket is connected")
}
func websocketDidDisconnect(ws: WebSocket, error: NSError?) {
if let e = error {
print("websocket is disconnected: (e.localizedDescription)")
} else {
print("websocket disconnected")
}
}
func websocketDidReceiveMessage(ws: WebSocket, text: String) {
print("Received text: (text)")
}
func websocketDidReceiveData(ws: WebSocket, data: NSData) {
print("Received data: (data.length)")
}
}`

That socket is always going to be released at the end of viewDidLoad it needs to be a property

I also never see where you're setting the websocket delegate.

@nuclearace thanks for responding to this. @nuclearace is correct, you need to make the socket variable a property so it won't get released. See this example application for more information:
https://github.com/daltoniam/Starscream/blob/master/examples/SimpleTest/SimpleTest/ViewController.swift

same issue , i set socket as a property but always i am getting socket.isConnected is always returning false


Feature/url queries

Link the filters panel to the router and create deeplink functionality to load the filters from the URL on first load.

Merging due to no further comments


[YUNIKORN-204][App CRD] Implement basic controller logic

@wilfred-s , @yangwwei , @TaoYang526 Can you please check this one when you have some time?

Travis tests have failed
Hey @kingamarton,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2

golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint

     make lint

running golangci-lint
pkg/rmproxy/rmproxy.go:127: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
	if len(event.RejectedApplications) == 0 && len(event.AcceptedApplications) == 0  && len(event.UpdatedApplications) == 0 {
pkg/cache/application_info.go:23: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
	"github.com/apache/incubator-yunikorn-core/pkg/handler"
	"github.com/apache/incubator-yunikorn-core/pkg/rmproxy/rmevent"
	"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
pkg/cache/application_info.go:65:38: func parameter `rmId` should be `rmID` (golint)
	eventHandler handler.EventHandlers, rmId string) *ApplicationInfo {
	                                    ^
pkg/cache/application_state.go:103:16: Error return value is not checked (errcheck)
				appInfo := event.Args[0].(*ApplicationInfo)
				           ^
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1

TravisBuddy Request Identifier: a4658110-dbc4-11ea-9ba8-b569b15b137c

Travis tests have failed
Hey @kingamarton,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2

golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint

     make lint

running golangci-lint
pkg/rmproxy/rmproxy.go:127: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
	if len(event.RejectedApplications) == 0 && len(event.AcceptedApplications) == 0  && len(event.UpdatedApplications) == 0 {
pkg/cache/application_info.go:139: File is not `goimports`-ed with -local github.com/apache/incubator-yunikorn (goimports)
		ApplicationID: ai.ApplicationID,
		State:         ai.stateMachine.Current(),
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1

TravisBuddy Request Identifier: 93e2e920-dbd5-11ea-9ba8-b569b15b137c

Hey @kingamarton,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 3ded97e0-dcd4-11ea-b6e2-493429cddfc3

Hey @kingamarton,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: f7188320-dd37-11ea-b6e2-493429cddfc3

Looks good. I think we need to relax the codecov/patch, otherwise it is too easy to fail.
I will merge this PR shortly. Thanks @kingamarton


TOC proposal

Just realized that making a PR would require actually moving all of the files around, creating new ones, deleting old ones and what not. Not a problem, but since no no. 1 attempt is good, better to first shake out the TOC proposal in an issue and then just do the work once we are settled.
Several notes:

This covers only the .NET Core and Getting started content not the scenarios, as agreed in #152
The C# tutorials have been condensed from @stevehoag's issues since some things come naturally together (for instance, delegates and events)
The "packaging" part has been merged with deployment, since after some thought I've come to realize it is pretty much the same (i.e. you have to package your application somehow to be able to deploy it)
The absence of web apps is intentional, since no scenarios are in this proposal
I keep thinking that the "installing" bit should just point to http://dotnet.github.io/getting-started and not replicate content that we will have to change in numerous places

With that, I give you the new proposal:

Getting started

What is the .NET Platform?
Installing .NET Core

Installing .NET Core on Linux
Installing .NET Core on OS X
Installing .NET Core on Windows

Setting up your development environment

Developlment using VS Code
Developlment using Visual Studio
Developlment using vim
Developlment using Sumblime Text

Writing your first console application on .NET Core

Learn C#

Syntax
Features at a glance
C# Type system
Iterators
Delegates & events
Generics
Language Integrated Query (LINQ)
Asynchronous programming
Paralell programming
Native interoperability
Reflection & code generation
Documenting your code

Understanding the .NET Core Platform

What is .NET Core? Overview of the platform
.NET Primer
Programming languages on .NET Platfrom

.NET - a multilanguage platform
The main trio: C#, F# and VB.NET

Writing console applications

Overview and moving pieces
Console applications paradigm
Creating single binaries with native compilation

Writing libraries on .NET Core

Overview
Creating a class library

Understanding package management on .NET

Introducing NuGet
Working with Nuget Packages
Creating NuGet Packages
Publishing NuGet Packages

Packaging & Deploying applications

Deploying applications overview
Deploying to a shared runtime
Deploying self-contained applications
Deploying single binaries
Deploying NuGet packages
Deploying ASP.NET web applications

Porting applications between editions of .NET Platform

Overview
Tooling for helping the porting
Porting your applications
Porting your libraries
Porting NuGet packages

.NET Command Line Interface reference

Overview of the .NET Core Command Line Interface (dotnet CLI)
dotnet
dotnet-compile
dotnet-publish
dotnet-run
...

API reference

Link to the ref docs

/cc @BethMassi @mairaw @stevehoag @cartermp @ghogen

LGTM

LGTM :shipit:

Overall, LGTM. A couple of points (some are picky I know):

I think we should have the installing docs here too, since I'd imagine that would be a more comprehensive article showing the different ways you can install, etc.
I understand that we don't want to cover the web scenarios in detail here but maybe we should have a topic (or a section in an existing topic) that explains the different scenarios you'll use .NET Core (console, libraries, web, etc.) and link to the ASP.NET site docs and the other sections on this TOC.
The .NET Primer seems a bit lost there and I still don't like that title (I can't imagine anyone searching for that term for example)
I also think that some of the titles should be more descriptive. For example, instead of just "overview" under each section, I'd say "Porting applications overview". We want to think of SEO as well when we design this TOC, right?
How are we capitalizing the titles? Do we have a pattern? I see "Working with Nuget Packages" and "Deploying NuGet packages"

@mairaw some replies, in the order of questions asked:

I don't follow?
We will have that, and those will be in its own separate scenario heading. I just want to get this off the ground since we didn't finish the scenario dicussion in the other issue.
:)
Well, an overview usually has a different title. You can see the actual PR on #175
Fixed this in #175 to be consistent.

Thanks!

@blackdwarf:
1 - maybe I misunderstood what you meant by "I keep thinking that the "installing" bit should just point to http://dotnet.github.io/getting-started and not replicate content that we will have to change in numerous places". I thought you were saying you didn't want the installing topics.
2 - sounds great!
3 - sorry, I still don't have suggestions for a better name :-)
4,5 - ok, thanks!
It will be easier to discuss this further once we merge the new TOC. Thanks!

@mairaw:

Nope, meant that the docs just point to the URL. :) I loathe having to edit content in 3 different places.
Good.
Then we are stuck with "Primer" until we do have a better name.

Do comment on #175 as well before I merge today.

If it makes sense, I'm fine with that. But for example, the steps for Windows on the getting-started page is completely different from the topic.
I prefer something like "Lap around .NET" or "Key .NET Concepts". My 2 cents, of course!

I'll take a more closer look again at #175 right now.

Let's try the mail thing see if it works.
The docs need to change to reflect the new reality that is on the Core site. What is on the site is the new true way to install bits. I was meaning to change these as soon as the TOC is merged. :))
Thanks,
Z
Sent from my tricorder
On Tue, Dec 1, 2015 at 10:48 AM -0800, "Maira Wenzel" <notifications<EMAIL_ADDRESS>wrote:

If it makes sense, I'm fine with that. But for example, the steps for Windows on the getting-started page is completely different from the topic.
I prefer something like "Lap around .NET" or "Key .NET Concepts". My 2 cents, of course!

I'll take a more closer look again at #175https://github.com/dotnet/core-docs/pull/175 right now.

Reply to this email directly or view it on GitHubhttps://github.com/dotnet/core-docs/issues/173#issuecomment-161060175.

It did work! Did you clean it up the e-mail to reply? Because when @stevehoag replied using the e-mail, all the rest of the earlier convo was there too.
Ah ok, I didn't know the main page was already updated to the new way. Sounds good!

Never mind, the rest of the convo is there too when you expand the ...

Are we going to cover testing as a topic? I have not seen any mention of it and not sure if it is even within the scope of the core-docs.

@matthewreily good question.  What I've been doing this far is incorporating Xunit into the relevant article(s).  I'm almost tempted to say that we could just link directly to the testing frameworks available.  I haven't used Nunit, but Xunit's documentation is really good, so I think we'd want to point people there if at all possible.

Sounds good to me and I agree that Xunit's documentation is really good.  I'll start incorporating it in as well where relevant.  Maybe we could start adding some unit tests to the samples we produce as well.  I think adding by adding some simple tests to our samples, we would help those wanting to learn how to get started.


Override input and output

Currently, the source in package.json takes precedence over the input option. Additionally, it seems the output option is ignored entirely. Can we please change this, so that input/output can be overriden?

Absolutely! Let me have a look

This should be fixed in 1.1.0. Let me know if that works for you!


tag 5.0.2

Hi there, could you please tag 5.0.2? The arch linux package pulls git tags instead of pulling from pypi. Thanks in advance.

Done!

Thank you!


t.etags is undefined / m.etags is undefined

Describe the bug
when i try to put file (currently i am trying to save a json file) using storage.putFile with below options
contentType: 'application/json',
encrypt:false,
dangerouslyIgnoreEtag:true
i got 2 errors t.etags is undefined / m.etags is undefined in the browser
What version of Blockstack.js are you using?
19.2.5
Is the bug present in the Blockstack CLI, Gaia hub, Connect or Blockstack Browser?
Blockstack Browser
Expected behavior
file should be stored in user's Gaia storage
Desktop (please complete the following information):

OS: [e.g. Windows]
Browser [e.g. firefox]
Version [e.g. 91.0.1]

How is your project being built, I don't think anyone else has ran into this issue

@appsdevpk please provide more details so we can troubleshooting. closing this until we have more details.


:skip_render option still renders an empty _embedded key with an empty array in HAL

Hi there, sorry to keep bothering you about these HAL rendering issues!  On the latest 1.0.3 I'm still having the following issue:
Roar::VERSION
=> "1.0.3"

class PersonRepresenter < Roar::Decorator
  include Roar::JSON::HAL

  property :id, :skip_render => true
  property :name

  collection :favorite_foods,
             :decorator    => FavoriteFoodRepresenter,
             :class        => OpenStruct,
             :as           => :favoriteFoods,
             :embedded     => true,
             :skip_render  => true,
             :render_empty => false
end

class FavoriteFoodRepresenter < Roar::Decorator
  include Roar::JSON::HAL

  property :id, :skip_render => true
  property :name
end

json_string1 = "{\"id\": 123, \"name\": \"Bob\", \"_embedded\": {\"favoriteFoods\": [{\"id\": 321, \"name\": \"Pizza\"}]}}"
json_string2 = "{\"id\": 124, \"name\": \"Joe\", \"_embedded\": {\"favoriteFoods\": []}}"

person1 = PersonRepresenter.new(OpenStruct.new).from_json(json_string1)
=> #<OpenStruct id=123, name="Bob", favorite_foods=[#<OpenStruct id=321, name="Pizza">]>

person2 = PersonRepresenter.new(OpenStruct.new).from_json(json_string2)
=> #<OpenStruct id=124, name="Joe", favorite_foods=[]>

PersonRepresenter.new(person1).to_json
=> "{\"name\":\"Bob\",\"_embedded\":{\"favoriteFoods\":[]}}"

PersonRepresenter.new(person2).to_json
=> "{\"name\":\"Joe\"}"

As you can see from the above contrived example, the skip_render option only empties out the related collection, but still renders an empty array in its place.  In addition to that, the render_empty option won't help in this scenario either, although it does work when the collection is legitimately empty.
Hope this helps!

Haha, I had to look up my own API and see how :skip_render is interpreted! :blush:
The :skip_render option is run "per item" and I think that is the problem: while the items are left out, the original collection "wrapper" is still rendered. Can you verify that without HAL, please? (In a test, ideally?)?

Awesome news: In awesome Representable 2.4, which is gonna be awesome, we have a pipelined architecture per property. That means, you can set up a pipeline for, say, a collection and say "run :skip_render, for every item, but also after that for the entire property". It's so awesome.
collection :songs, render_pipeline: [Get, SkipNil, Iterate[SkipRender], SkipRender, Write]

That DOES sound awesome.  Can't wait!  :+1:


test: Output stderr of flynn-host ps when dumping logs

The command sometimes hangs in CI, so we want to be able to see the output when sending SIGQUIT.

LGTM


Docs: Add template variables content

Add docs for template variables to existing doc on variables. Specific changes:

Add content from https://community.grafana.com/t/how-to-use-template-variables-in-your-data-source/63250
Replace content on multi-variable support with community forum content
Restructure content slightly
Fix broken link and minor editorial tweaks

Fixes https://github.com/grafana/grafana/issues/70943

Looks like a great start @josmperez! A few things have changed since Marcus wrote that post on the community site. Would be good to have a discussion around the variable apis before publishing this, so I started a convo in our team slack.
I'd be happy to help out adding missing pieces here as soon as we reach to a conclusion on how to use variables in plugins.

Hi @sunker - I appreciate your willingness to edit this content or draft new content for this PR. Have you started this yet? If not, could you please let me know when I might see revisions? Thanks.

Hi @sunker - I appreciate your willingness to edit this content or draft new content for this PR. Have you started this yet? If not, could you please let me know when I might see revisions? Thanks.

Hi @josmperez. I'm afraid I need to focus on a other things right now. Can't say for sure, but hopefully I can start with this in a month of time.

@sunker - I know you've been busy with writing docs and other things. Do you think this is do-able for Q1?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Because of its age and conflicts with the reorganization of the site, this PR is closed in favor of https://github.com/grafana/plugin-tools/pull/1096


Enhancement - Sentence Solution Cache Refresh

We need a way to force a refresh of the stored solutions for a sentence so that we can ensure we pick up the latest data from the server.

Closing this as the forum is now completely gone.


Optimize visibility-off.svg

Description
Removes the slash, strangely created with an svg filter, in such a way that prevented the icon being used on anything other than a white background.
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[x] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

Changes the SVG definition.
old vs new:

How to Test-Drive This PR

change the background color of the password field
observe that the slash of the icon doesn't draw white.

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[x] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

@uxphilforce and I met to go over the svg review. As noted above, the changes look good. We can go ahead and merge this in.

I'll make a follow up PR to merge this change into the v2 branch as well.
Thanks for the contribution @mix3d !


Feature/narrative remove bridging text

In progress, partial requirement for #121

Lots of red :+1:


About the publication of the reflector information.

At present, the reflector information is published through the topic of /cloud_all_fields_fullframe. Can we change it to be published through the topic of /sick_picoscan/scan_fullframe ? Our company is currently testing this aspect and hopes to support it

Thanks for your feedback. The messages in topic "/sick_picoscan/scan_fullframe" are standard ROS messages of type sensor_msgs::LaserScan. This data format is defined by the ROS in https://docs.ros.org/en/noetic/api/sensor_msgs/html/msg/LaserScan.html. It allows the transmission of ranges and intensities of a single and planar laser scan, but cannot be extended with additional and lidar specific properties such as reflector bits.
We recommend using the more flexible point cloud data format in the topic "cloud_all_fields_fullframe", which includes all scan properties incl. the reflector bit.


Contributing to 'Big O Notation' Documentation

Hi,
This is the best article that explains Big O Notation in a concise way. Would be great, if those information is available in here for Integrity.
Thanks!

Heya,
We have a basic explanation of Big O Notation here. Feel free to improve upon it (in your own words!).
Going to add this to the Wishlist. Feel free to make a pull request if you want to add to anything in the repo!


isArray() preserve mutability and element type

Reopening https://github.com/microsoft/TypeScript/pull/42316, with any and unknown backward compatibility: https://github.com/microsoft/TypeScript/pull/42316#discussion_r823218462
There are a couple of related issues here:

Array.isArray() narrows readonly T[] -> mutable any[]
Consequently the false branch doesn't remove readonly T[]
It loses the element or iterated type of wider types ArrayLike<T> and Iterable<T>

https://github.com/microsoft/TypeScript/issues/17002 concerns issues 1 and 2. 1 and 3 are pretty similar --- https://github.com/microsoft/TypeScript/issues/33700 calls out issue 3, the still-wider type Iterable<T> vs. readonly T[].
https://github.com/microsoft/TypeScript/pull/42316 fixed https://github.com/microsoft/TypeScript/issues/17002 (1 and 2) but not https://github.com/microsoft/TypeScript/issues/33700 (issue 3), by changing the return type from arg is any[] -> arg is readonly unknown[]. That preserves mutability and therefore removes it from the false branch. It narrows:

T[] -> T[] & readonly unknown[] (which is mutable because the T[] component is mutable)
readonly T[] -> readonly T[] & readonly unknown[] (immutable)

It also preserves the element type of readonly T[].
https://github.com/microsoft/TypeScript/pull/42316 was closed because it narrowed any and unknown -> readonly unknown[] vs. any[] (which is the current behavior), breaking code that relies on unknown narrowing to mutable, or narrowing to elements of type any:
declare const u: unknown;
if (Array.isArray(u)) {
  u[1] = 12;
  u[1].length;
}

The current behavior is exceedingly permissive in those cases. The change added errors that weren't there before, but aren't necessarily correct or incorrect, because any and unknown can be anything. The fix wasn't worth the breakage: https://github.com/microsoft/TypeScript/pull/42316#discussion_r821975675
:adhesive_bandage: Proposed solution
This PR addresses backward compatibility, and also fixes https://github.com/microsoft/TypeScript/issues/33700 (issue 3), by instead adding overloads for:
    isArray<T>(arg: ArrayLike<T>): arg is readonly T[];
    isArray<T>(arg: Iterable<T>): arg is readonly T[];

This fixes 1, 2, and 3, for ArrayLike<T>, Iterable<T>, and their narrower types, including readonly T[], while preserving the current behavior for everything else, including any and unknown.
Fixes https://github.com/microsoft/TypeScript/issues/17002
Fixes https://github.com/microsoft/TypeScript/issues/33700
Fixes https://github.com/microsoft/TypeScript/issues/41808
:play_or_pause_button: Playground link

Workbench repro.
:technologist: Code

// @target: es2015
// @errors: 2322 4104

//interface ArrayConstructor {
//  isArray<T>(arg: ArrayLike<T>): arg is readonly T[];
//  isArray<T>(arg: Iterable<T>): arg is readonly T[];
//}

// https://github.com/microsoft/TypeScript/issues/17002
// Preserves mutability, false branch removes arrays, mutable or not

declare const mutable: string | string[];
if (Array.isArray(mutable)) {
  const stillMutable: string[] = mutable;
} else {
  const narrowed: string = mutable;
}

declare const immutable: string | readonly string[];
if (Array.isArray(immutable)) {
  const notMutable: string[] = immutable; // Should fail: readonly string[] isn't assignable to string[]
} else {
  const narrowed: string = immutable;
}

// https://github.com/microsoft/TypeScript/issues/33700
// Preserves element or iterated type of wider types

declare const arrayLike: string | ArrayLike<string>;
if (Array.isArray(arrayLike)) {
  const arrayOfElementType: readonly string[] = arrayLike;
  const notArrayOfAny: readonly void[] = arrayLike; // Should fail: string isn't assignable to void
}

declare const iterable: string | Iterable<string>;
if (Array.isArray(iterable)) {
  const arrayOfIteratedType: readonly string[] = iterable;
  const notArrayOfAny: readonly void[] = iterable; // Should fail: string isn't assignable to void
}

// https://github.com/microsoft/TypeScript/pull/42316#discussion_r823218462
// any and unknown backward compatibility

declare const any: any;
if (Array.isArray(any)) {
  const mutableArrayOfAny: void[] = any;
  const notAny: void = any; // Should fail: any[] isn't assignable to void
}

declare const unknown: unknown;
if (Array.isArray(unknown)) {
  const mutableArrayOfAny: void[] = unknown;
  const notAny: void = unknown; // Should fail: any[] isn't assignable to void
}

:slightly_frowning_face: Actual behavior

// https://github.com/microsoft/TypeScript/issues/17002
// Preserves mutability, false branch removes arrays, mutable or not

declare const immutable: string | readonly string[];
if (Array.isArray(immutable)) {
  const notMutable: string[] = immutable; // ❌ No error: You're free to mutate immutable
} else {
  const narrowed: string = immutable; // ❌ False branch removes mutable arrays only
}

// https://github.com/microsoft/TypeScript/issues/33700
// Preserves element or iterated type of wider types

declare const iterable: string | Iterable<string>;
if (Array.isArray(iterable)) {
  const arrayOfIteratedType: readonly string[] = iterable;
  const notArrayOfAny: readonly void[] = iterable; // ❌ No Error: Iterable<string> -> any[]
}

$ tsc --target es2015 input.ts
input.ts:8:9 - error TS2322: Type 'string | readonly string[]' is not assignable to type 'string'.
  Type 'readonly string[]' is not assignable to type 'string'.

8   const narrowed: string = immutable; // ❌ False branch removes mutable arrays only
          ~~~~~~~~

Found 1 error.

:slightly_smiling_face: Expected behavior

With this PR:
// https://github.com/microsoft/TypeScript/issues/17002
// Preserves mutability, false branch removes arrays, mutable or not

declare const immutable: string | readonly string[];
if (Array.isArray(immutable)) {
  const notMutable: string[] = immutable; // ✔ readonly string[] isn't assignable to string[]
} else {
  const narrowed: string = immutable; // ✔ False branch removes arrays, mutable or not
}

// https://github.com/microsoft/TypeScript/issues/33700
// Preserves element or iterated type of wider types

declare const iterable: string | Iterable<string>;
if (Array.isArray(iterable)) {
  const arrayOfIteratedType: readonly string[] = iterable;
  const notArrayOfAny: readonly void[] = iterable; // ✔ string isn't assignable to void
}

$ node built/local/tsc.js --target es2015 input.ts
input.ts:6:9 - error TS4104: The type 'readonly string[]' is 'readonly' and cannot be assigned to the mutable type 'string[]'.

6   const notMutable: string[] = immutable; // ✔ readonly string[] isn't assignable to string[]
          ~~~~~~~~~~

input.ts:17:9 - error TS2322: Type 'readonly string[]' is not assignable to type 'readonly void[]'.
  Type 'string' is not assignable to type 'void'.

17   const notArrayOfAny: readonly void[] = iterable; // ✔ string isn't assignable to void
           ~~~~~~~~~~~~~

Found 2 errors in the same file, starting at: input.ts:6

@DanielRosenwasser let's discuss this next week - seems promising

@RyanCavanaugh  Is there any movement on the issue? I have multiple projects in refactoring, where we have readonly types generated from graphql scheme, and old codebase, which uses Array.isArray(), and it is pain to break type inference with @ts-ignore comments.

@DanielRosenwasser do you have any news on ReadonlyArray and Array.isArray ?

Not sure if I get this right, but the immutable case only seems to only work because both string and readonly string[] are Iterable<string>. If you change it to readonly number[] instead the type checker reverts back to the old behavior:
// https://github.com/microsoft/TypeScript/issues/17002

declare const immutable: string | readonly number[];
if (Array.isArray(immutable)) {
  const notMutable: number[] = immutable; // ❌ No error: type of immutable is `any[]`
} else {
  const narrowed: string = immutable; // ❌ Error: `readonly number[]` is not removed from false branch.
}

@typescript-bot test it


next-router-mock doesn't support Next.js 11

next-router-mock doesn't support Next.js 11. When running npm install:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>

Fixed in v0.1.4! I simply changed peerDependencies to >=10.0.0.
I have not actually tested this, but anticipate it probably works without change.


Add netstat as fallback to lsof command to check service status

In many systems, lsof command is reserved for root user and hence it may cause the drat script to fail. We can configure netstat as fallback for the same.

@karanjeets you took care of this, right, if so please close.

@chrismattmann Yes. This has been taken care.
Replaced "lsof" with "nc" command. Related to PR #79


Add docfx install script

Docfx with cross-platform support is currently in beta, but I wanted to open this as a draft PR to get feedback.
Closes #790

@samruddhikhandale can I request a review from yourself or someone else on the team? Getting this container in and published would be extremely useful for a lot of teams at Microsoft, as most documentation is built using DocFX.

I don't have write permissions for this repository, so my review won't help. Probably @Chuxel (oof today) or @chrmarti or @joshspicer could help.

Gentle ping on this


[SHIP-0038] Use Release Branches for Releasing

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.
Per SHIP-0038, we are changing our release process to ship official releases from a release branch, rather than from main.
Describe the solution that you would like.

CI and release scripts can be run on a release branch (with release-v* pattern)
Release workflows must use an appropriate release branch and/or git reference (cannot blindly use latest commit from main)

Describe alternatives you have considered.
See SHIP-0038 for discussion
Anything else?
Part of shipwright-io/community#85

@SaschaSchwarze0 @qu1queee Can we call this "done"? I think at this point we just need to cut the official v0.13.0 release for "Build"

I would like to fully get a grasp of the whole new process first.  Not sure if this is something you can show next Monday during community meeting? .e.g. we need https://github.com/shipwright-io/build/pull/1566 in v0.13.0, how would that work with prow as part of the new process?

/close
We have now release v0.13.0 using the release branch mechanism!


adding Meteor package file to your gruntFile

Hi Guys,
I maintain currently your project as a Meteor package. Would be great if you could update your gruntfile that all updates are recognized by the Meteor packaging system. Here is some information about it:
https://github.com/MeteorPackaging
MeteorCommunity/discussions#14
https://www.youtube.com/watch?v=g-idz8UPtDM
https://www.youtube.com/watch?v=mIxZnOtWUUY
We opened already a group called angularuiand this project is already published and available https://atmospherejs.com/angularui/ui-calendar
I would like to add you to the angularuigroup that you can publish your changes directly into the project. Please contact me or https://github.com/Urigo for further details. Thanks for your great work!

cool can you send a PR for it?


Project structure: re-organization?

I do always feel bad to refer another repository that seems not to be related to this repository. They are aiming at different areas but only things in common is they are documents that we need to translate and publish to the same website.
Maybe we might need to refactor the whole repository structure to keep the maintainability of repositories. I'll research configurations about CI/CD as long as the idea of refactoring is accepted. Or this issue could be closed as unplanned.
Things to be done:

[ ] Get accepted or just close unplanned
[ ] Create a central publish repository
[ ] Update CI/CD and commit changes to publish repository
[ ] Use CI/CD to automatically deploy the changes that are committed to publish repository

You may just need to use emoji reaction to notify me whether you agrees this idea.

Lookinh into this owo

I do always feel bad to refer another repository that seems not to be related to this repository.

This made me accidentally came up with a few disadvantages of sub dictionaries:

Licensing. License files are included by default in the document structure and there isn't a clear way to resolve it.
Revision changing and updating. After sub-repo updates, you need to manually change the reference in the main repo.
Cannot run overall remark or test deployment on pure Markdown repos, making some vulnerable changes hard to find out.

Don't worry about the acceptance, your idea seems pretty right. High five on approving it.

[ ]  Create a central publish repository

I was never quite sure what was meant by ‘central repository.’ In its current structure, ‘osu-dictionary’ already functions as a central repository. When a PR or a new commit is pushed to the main branch, GitHub Actions are triggered to build the page to GitHub Pages.
From a CI/CD perspective, we already use version control and automated builds within our workflow, and the unit testing framework relies on simple GitHub Actions test builds. Therefore, our main repository should be capable of continuous delivery.
I noticed that the organization has created a repository named ‘atriiiiiiiiiiiiiiiiinterface’ for storing static HTML code of the page. Does this mean we need to move our workflow from GitHub builds to self-builds?
It would be helpful if you could explain a bit about the structure of the new architecture. Looking forward to your reply @astro-angelfish.


Please create an SDK for the PushNotifications like the one you had in AppCenter

Help us make content visible

Tell us what search terms you used and how you searched docs.
Tell us what docs you found that didn't address your concern.

Describe the new topic

Explain why this topic is needed.
Suggest a location in the Table of Contents.
Write an abstract. In one short paragraph, describe what this topic will cover.
Create an outline for the new topic. We'll help review the outline and approve it before anyone writes a topic.

This is a repo for ASP.NET Core docs. What type of PushNotifications


A request for support for Seeed Studio XIAO boards

The more boards that are supported the more users of the feature. Besides which, I am writing a new app for the board and have several planned.

The more boards that are supported the more users of the feature. Besides which, I am writing a new app for the board and have several planned.

There's a new version in the making, you can check the discussions in this repository to learn more information about it or contribute with feature requests - the current board support approach is likely going to be scrapped altogether in favor of a more universal solution.
The latest pre-alpha has many bugs, if you'd want to test the latest plugin in a more functional state, you can check out my pull request and build the plugin with my changes.


Create Framework case-study

DESCRIPTION
The following projects needs to be created:

REST API Website providing secured endpoint
UI Website accessing secured API
IdentityServer4 acting as identity provider.

Example needs to be saved to the following location:
https://github.com/GodelTech/GodelTech.Microservices.Examples/tree/master/src/REST API and UI Collaboration
Application examples can be found in the following integration tests:
https://github.com/GodelTech/GodelTech.Microservices.Security/tree/master/test
Resulted solution should start all three applications during debug session. More details you can find here:
https://docs.microsoft.com/en-us/visualstudio/debugger/debug-multiple-processes?view=vs-2019

Hi @DiamondDragon
Can you please check if this point is still valid?
We already updated README file and added demo part.
https://github.com/GodelTech/GodelTech.Microservices.Core/blob/main/README.md
https://github.com/GodelTech/GodelTech.Microservices.Core/tree/main/demo
Thank you


DBZ-6865 Avoid getting NPE when executing the arrived method in ExecuteSnapshot

https://issues.redhat.com/browse/DBZ-6865

@harveyyue Applied, thanks


gopass jsonapi return code always zero

gopass jsonapi doesn't seem to return a useful status code. At least for messages like {"type":"getLogin","entry":"..."}, it returns zero (success) even when the entry does not exist or the decryption failed.

It actually uses an error message as described here: https://github.com/gopasspw/gopass/blob/master/docs/jsonapi.md#error-response Does that answer your question?

I don't see why gopass couldn't still exit with a nonzero status in those cases. Not doing so definitely violates the principle of least surprise for me.

Ah, now I got it. Yes, this would be possible. At least I did not find anything in the docs that prevents using it as native messaging host app. I am not if and how this works out with multiple messages, which can in principle be handled by a native messaging host app. Do you have any specific use case for the error code?

Initially I was thinking it would make native messaging interop more straightforward, but it seems like the promise returned by browser.runtime.sendNativeMessage doesn't actually reject in the event of a nonzero exit code. So I guess it's just about CLI ergonomics at this point, which isn't nearly as important as I can't think of why a CLI caller of gopass would bother with the JSON API.
And if sending multiple messages to the same invocation of gopass jsonapi listen is a possible feature (though I don't think it works ATM?), then the status code issue becomes much less clear-cut anyway. Given that the presence of the error key can be used for that (as you pointed out), I'm happy to close the issue in that case.

@zsau thx for your hints, again something learned.


Visual artifacts

I'm trying to apply RgbQuant.js's quantization on a canvas where I've draw some PNGs (tiles from a mapping application).
These PNGs have some holes (transparency).
Also they not fill the canvas, leading to lots of "white pixels".

Left is the canvas before quantization. Right is after quantization.
After q.reduce(canvas) I'm using drawPixels function I found on RgbQuant.js's demo to render a canvas with quantization result.
But I'm getting lots of artifacts on the most dark pixels.
Tried with: method: 1 and method: 2, initColors: 8128 or with default initColors...
Using options: colors: 32, minHueCols: 0
Would you/someone have any idea how to getting it to work properly?

hey @dirceupj
rgbquant does not support alpha transparency. i actually don't understand why it would be needed for satellite images (as opposed to map layers like roads, places, etc.). the easiest solution would be to flatten the images before quantization. i'm pretty sure you can do this just with Canvas and drawImage & composite ops.
you can also take a look at a project derived from rgbquant [1] that supports alpha.
[1] https://github.com/ibezkrovnyi/image-quantization

Thank you for instant reply.
In fact it is a map layer derived from drone imaging. The images are "glued" and I expect transparency outside its boundaries and some holes. But it seems other pixels are also with transparency.
I'm first drawling them into the canvas and then loading into RgbQuant.js. I supposed that canvas didn't have transparency and flattens when I .drawImage() on it. But I may have supposed that wrong.
Thanks for pointing to @ibezkrovnyi/image-quantization, I've tried it and works as expected and it is based on your great work here.


Referencing experimental version of SQLDatabaseChain from the production project

https://github.com/langchain-ai/langchain/blob/a5a4c53280b4dae8ea2e09430fed88e0cd4e03d2/libs/langchain/langchain/chains/loading.py#L376
Work was done earlier this year to move all experimental and vulnerable code over to the experimental project. SQLDatabaseChain had (and still has) an open CVE against it so it was moved to the experimental project. However the experimental version of SQLDatabaseChain is being referenced in the production project on the line above. Our organization would like to start using LangChain but we cannot due to the open High severity CVE. Is it possible to either patch the vulnerability in code or complete the move of SQLDatabaseChain from the production project to the experimental?

Hi @RHendrixn!
Thanks so much for the feedback.
At the moment, langchain_experimental is an optional package and does not get installed by langchain. Installation of the package is entirely up to the user, and I suspect the security team should be able to entirely block installation of langchain_experimental.
We're open to feedback and the structure is not finalized yet. Would you be able to tell us why this is getting flagged by your security team right now?
Thanks in advance!
Eugene

@RHendrixn I haven't heard back  -- so closing this comment. please feel free to ping me / re-open if still an issue


Problem: 'Don't have account or can't sign in?' link on login page is useless for end-users.

Issue
On the login page, there is a link 'Don't have account or can't sign in?' that shows a pop-up, advising how to fix sign-in issues. This is useless and confusing for end-users as they then will try to gain access to the back-end to which they don't have access to. Perhaps this pop-up can be configurable so it can contain more helpful information on what admins can reset their password.
Impact
Web-Frontend (what users interact with)
Installation method
Docker
Database
No response
Browser
No response
Semaphore Version
2.10.21
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration
No response
Additional information
No response

Agree with you.


Adds thread runner, benchmark and stats components.

Accidentally adds too many commits history. Will recreate a PR.


Displaying value in different format for documentation colour tokens

Is your feature request related to a problem? Please describe.

Currently, the documentation tokens only allow you to show the value of the token. e.g. using hex #000000 will just display it as it. Being able to show them in other formats like RGB or HSL on top of the original value will be extremely helpful for managing documentation tokens.
Describe the solution you'd like
A 'display value' field in edit token and allow for manipulating the value e.g.rgb($neutral.50) and being able to select it in the contextual menu.

Does this needs to be prefilled?
Add screenshot pointing out where the field needs to be @rbosker
In the list for documentation, also place a field: 'Display Value'

Update on this: We initially wanted to tackle it in the next iteration, but I'm removing it again as I couldn't come up with a good enough solution. If someone has one that doesn't clutter the UI I'd appreciate it.

Suggest to close as its stale and can be reimagined when we focus on documentation in a future epic


Add support for mypy 0.800

Closes #678
Add support for mypy 0.800 by doing a very naive try/except. We
could copy the updated code here, but I don't think it is worth
doing so.
I also tried to use inspect to check if the class accepted info,
but didn't manage to get it working (also mypy gets compiled, I
wonder if that might cause issues with inspect).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds support for MyPy==0.800

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds support for MyPy==0.800


ig_service.fetch_open_positions()

ig_service.fetch_open_positions() returns one position less than it should. On the ig web platform I have 3 opened position but ig_service.fetch_open_positions() returns only 2 first positions.

Sorry. It seems that the api needs time to update the data.

Feel free to contribute @Sasanita

ps. The update of positions depends of expire_after time of equests_cache.CachedSession ;)

You can pass session = requests.Session() to avoid caching but I think it's default parameter settings according https://github.com/ig-python/ig-markets-api-python-library/blob/3cd3b49bf4c13e88f034e23684759da908d7652d/trading_ig/rest.py#L193-L194