mailto Spam Bot improvement

Questions
Answers

Description?
Encode E-Mail Adress and make use of Smarty mailto & encode function for better spam bot protection. See PrestaShop/Prestashop#17562 for reference

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/Prestashop#18928

How to test?
Please check in the footer and the contact us page, the contact mail works as before. Now it's protected against SPAM bots

Looks good 👍

the question is, why the templates here and in themes/classic/modules/ps_contactinfo/ differ substantially?

@ziegenberg Because contributors forgot to do modifications on modules. But thank you for your PR.
Ready for review ?

Yes, ready for review.
If contributors forgot to do modifications on modules, it sounds to me, that the templates here and in themes/classic/modules/ps_contactinfo should not differ. So my next questions: should I file a new PR for updating the templates here to reflect the changes in themes/classic/modules/ps_contactinfo/? I'd gladly do so, if desired.

If you can, do it :) We review two PR at the same time ;)

New PR is in, see #37. It was a bit messy though, as it looks like at some time in the past ps_contactinfo.tpl and ps_contactinfo-rich.tpl got mixed up.

Hi there, I don't think there is any rule regarding a wording used in a module that already exists as a back office string (localized in the Admin.* domain) but it might the occasion to set one. :-)
@Junebyun, do you confirm? If yes, we will have the two following scenarios:

keeping the Admin.* domain will allow us to keep the translation and avoid duplicating the string
turning the Admin.* domain into its own related module domain (Modules.Contactinfo.* domain) will make us lose the translation and duplicate the string but allow a more relevant domain (useful for translation and export)

I would keep Modules.Contactinfo.Shop as in the next PR #37 it's still Modules.Contactinfo.Shop. This is probably only copy&paste error on my side from the template files from themes/classic/modules/ps_contactinfo

Hi guys! Correct me if I'm wrong, but would that string appear in the FO?
Because if so, I found that there is the string: "Email us: [1]%email%[/1]" in Modules.Contactinfo.Shop
Can't we use that one? It would allow us to not duplicate an existing string and it would be in the relevant domain.

@Junebyun, it is the former wording, you can see it in the red parts (= the removed parts) in the Files changes tab. ;-)

Right my bad! Then I would go with the second suggestion: Modules.Contactinfo.Admin
It might duplicate the string but I prefer that strings are hosted in its own related domain. Plus it seems to be linked to another PR.

Hello @ziegenberg , thanks for your contribution, would you mind to rebase your pull request before merging ? Thanks

I rebased onto master and pushed.

Sorry, that was a mistake. I'll correct this asap.

@ziegenberg You have files in conflicts. Have you fetched upstream dev branch before rebasing ?

I fixed it.  Was a bit in a hurry. Sorry for the inconvenience.


Added Background Image

What is the change?
Added Background to website.
Related issue?
issue: #109
How was it tested?
Locally by contributor many times.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

@Pranav016 Done with all the changes. Please review my PR:)

@all-contributors please add @Aayush-hub for code

@all-contributors please add @Aayush-hub for code


Add documentation for more properties

Added dateFormat, className, placeholder properties
Added property descriptions
Reformatted to use JSDoc notation

Current coverage is 92.51%

Merging #381 into master will not affect coverage as of b5f4f06

@@            master    #381   diff @@
======================================
  Files            9       9
  Stmts          187     187
  Branches        38      38
  Methods         88      88
======================================
  Hit            173     173
  Partial          4       4
  Missed          10      10

Review entire Coverage Diff as of b5f4f06

Powered by Codecov. Updated on successful CI builds.

Hey @arrel, thanks for helping out here.  The API docs are generated with react-docgen so unfortunately these would be wiped out the next time they're generated.  Could you look into adding this info into the props in datepicker.jsx?

Aha! that's why the formatting was so terrible. I'll open another one tomorrow.


Support creation of web3 Commerce charges from Retail mini-dApps

https://docs.cloud.coinbase.com/commerce-onchain/docs/accepting-crypto
SwC V1 used this API, so I assume that there are Coinbase Commerce donation flows that don't directly go through the website.
NOTE: Coinbase Commerce recently undergone a significant API changes (e.g. from "v1" to "v2", and now, any new Coinbase Commerce accounts will be part of the new v2 API, but any already existing accounts will still behave with v1 API (for now).

Update, we need to use v2 API now moving forward.


fix(Android): createSocket is now a blocking method

Before, if you called createSocket('udp4') and bind() close together on production while running on a fast JS engine like Hermes, you would get the following error: "no client found with id X".
This was caused because createSocket('udp4') was running asynchronously and had not push the new socket to the SparseArray when the bind() method was called.

@mvayngrib What do you think of this?


Update rggen-verilog-rtl submodule

Hi @aignacio ,
I've found and fixed a bug of the axi4lite adapter. This bug causes inernal bus protocol violation.
(detail: rggen/rggen#122)
This PR is to update rggen-verilog-rtl submodule to import the fix for this bug.

Thanks @taichi-ishitani for the update!

Hey @taichi-ishitani
can you fix here in the generated Verilog to be compatible with verilator?

https://github.com/aignacio/axi_dma/actions/runs/3078411776/jobs/4973946202#step:6:60

Tks @taichi-ishitani I just added here and it worked like a charm! =)


Add unit tests for spanner extract and project

This adds basic unit tests for the spanner extract and project modules.
Fixes #63

@BryanCutler should we merge the changes from this branch now, or are you still making improvements?

@frreiss  I was going to bring this up, but ran out of time today. I'm not entirely clear on how dictionary extraction is supposed to work, which is why the test is pretty simple. I'll take another look and make this better before merging.


image: modify QOI to allow for loading from []byte

This PR modifies image to allows for a QOI format to be loaded from a []byte. It is a lot more flexible for working with various formats in embedded files.

What I really want to do is to load it directly via io.Reader to avoid any allocations. I might be getting this data from an embedded file system for example. This was just a step in that direction.

What do you mean exactly? That you'd load the entire image file into RAM, or only chunks of it on-demand?


Set up development environment

Everyone should install the following docker image in order to have a development environment: https://github.com/sr258/drupal-h5p-docker

Done


Provode edmx/ metadata and get running service

HI,
Does your repo is supporting the scenario which I provide edmx/ metadata XML and
it will generate service which can answer the calls according to the edm structure ?
Thanks,
Jenney

Hi Jenney,
The package generates the metadata and service according with your models in defined in Loopback. The application will have two basic end-points: the REST api generated from Loopback and the OData API generated by the package (that basic have the same collections from REST API).
Regards

Thanks!
Just to verify,  I must to provide models no edmx or metadata ...is it correct ?

Hello,
Yes, you need to define your models in Loopback.
Here you can check a example app: https://github.com/htammen/n-odata-server-example


[ART-6354] Setup snyk

Setup snyk (https://issues.redhat.com/browse/ART-6354)
Steps

Get the github token by following this doc using openshift-art-build-bot credentials on bitwarden. Generate a JWT token first and using that generate a github token
Add a secret to the repo by using GitHub API endpoint (docs) (but make sure to check if a secret with the same name doesn't exist, else the new value will overwrite the old one!)

You will need the repository public key, which you can get from here
And also the encrypt the secret value using the instructions given in the doc.

Test run: https://github.com/ashwindasr/art-bot/actions/runs/4492999119 (Test run does not inclue synk code command as it needs to be enabled in the synk dashboard settings, which has been done for openshift-eng)

Added secret to doozer {'name': 'SNYK_TOKEN', 'created_at': '2023-03-22T19:52:16Z', 'updated_at': '2023-03-22T19:52:16Z'}

/lgtm


Generate Random Color Use Case

Fixed my implementation so that it now follows our current structure of clean architecture and SOLID design principles.

What is the "target" folder for? You have two copies of a lot of files, one in the src/main/java we are using and one in the target folder.

What is the "target" folder for? You have two copies of a lot of files, one in the src/main/java we are using and one in the target folder.

Sorry, that was a mistake to add. The target folder is what gets auto-generated, I did not mean to commit that folder. I'll try to remove it. Maybe we should add it to our gitignore file.

The code and structure looks good. Issues I noticed though:

The colors shown are incorrect even though once selected, we can draw with the right color
I had issues running your test file. I keep getting a "java: package org.junit does not exist" error. Do you have any idea why? I tried reloading Maven and stuff but it still doesn't work.

I am still trying to find out what could be causing the palette not visually to update. Let me know if you see what could be the issue.

It works for me. Did you try hovering the line? It should give you the option to add the JUnit dependency. Attached is the test along with the code coverage.

It works for me. Did you try hovering the line? It should give you the option to add the JUnit dependency. Attached is the test along with the code coverage.

If I hover over the import statement, I get the option "add 'JUnit4‘ to classpath", but even after I click that I still get the error...

It works for me. Did you try hovering the line? It should give you the option to add the JUnit dependency. Attached is the test along with the code coverage.

If I hover over the import statement, I get the option "add 'JUnit4‘ to classpath", but even after I click that I still get the error...

Nevermind. I got it to work by unlinking and relinking as Maven project.


For Reference docs - Fix content issues found in azure-docs-sdk-python pipeline

Package Name:
Package Version:
Operating System:
Python Version:

Hello @danieljurek , please let me know if you have any questions - link to the Ref ADO bug info: https://dev.azure.com/ceapex/Engineering/_workitems/edit/928878
Describe the bug
Some docstring errors in azure-ai-ml package caused warnings in our pipeline. Reaching out to make you aware to fix.
For options in literalinclude directive, the option content should be indented.  The directive won't work because Sphinx can't parse it, and the code they want to include won't show on our page (although it doesn't break our new pipeline).

Jun Shi has created an example pr:
Fix azure-ai-ml docstring error of literalinclude directive indent by junshi356 · Pull Request #33629 · Azure/azure-sdk-for-python (github.com)
To Reproduce
n/a
Expected behavior
Screenshots
Additional context

@azureml-github can you please take a look at this issue and review the related PR? https://github.com/Azure/azure-sdk-for-python/pull/33629

@kristapratico - Will do


Also include C++ tarballs in releases/Github CI artifacts

This mean making a release is just a matter of pushing a tag to the repo. Distribution of the C++ parts of metatensor (e.g. pre-built versions in conda-forge) will then be able to use the tarball attached to the release as the sources to build.

:books: Documentation preview :books:: https://metatensor--385.org.readthedocs.build/en/385/

For some reason the jobs building wheels/sdist/tarballs are not running. I'll try again with a PR from this repo.

See #386

ok, there was a typo in the file, my bad ...


semantic error in javascript-closures

I would like to suggest the adjustment of the initCounter's returned method "reset".
By what I've interpreted, it should've reset the value to the initial, please correct me if I got it wrong
current
const initCounter = (start = 0) => {
  let value = start;
  return {
    get: () => value,
    increment: () => ++value,
    decrement: () => --value,
    reset: () => start
  };
}

proposed
const initCounter = (start = 0) => {
  let value = start;
  return {
    get: () => value,
    increment: () => ++value,
    decrement: () => --value,
    reset: () => value = start
  };
}

Fair point! 😉


Command ddev stop --all-other

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
In my daily work I am jumping between multiple projects and forget to stop the projects from time to time. I use ddev stop --all to shutdown all projects but sometime the project I'm working on is already running and I want to except it (to save time).
Describe your solution
Maybe we could add the command ddev stop --all-other (or name it as you want to) to shutdown all projects except the project of the current directory.
Describe alternatives
No response
Additional context
No response

My approach is ddev poweroff && ddev start, very easy.
Also note that you can use ddev list -j to get json output of all projects, filter on running ones, compare to current, etc.

There was a discord discussion with a solution from Thanasis Psarros.
Global command to stop other projects except the current directory project

From Discord: https://discord.com/channels/664580571770388500/1068592266752573440/1223319455740723230
Pull the "ddev/ddev-utilities" if never done.
docker pull ddev/ddev-utilities
Edit and create the "~/.ddev/commands/host/stop-other" file with the following contents

#!/bin/bash

## Description: Stop all other running projects
## Usage: stop-other
## Example: "ddev stop-other"

ddev stop $(ddev list --active-only -j | docker run -i --rm ddev/ddev-utilities jq -r .raw[].name | grep -v $(ddev describe -j | docker run -i --rm ddev/ddev-utilities jq -r .raw.name))

ddev restart
ddev stop-other

Thanks @joestewart , and of course if jq is on the machine then you don't need ddev-utilities, we just often mention that so people don't stumble on machines that absolutely have docker but might not have jq.

Since there's a good workaround documented here for this particular workflow, I'm going to close this as not planned.
One thing to consider is that it's super easy to create an add-on to deliver a custom command like this.


Map tools

This is an issue to track and investigate tools/ideas regarding Maps and what we can do with them. In general Mapbox looks superior to Google Maps. Each todo item represents a potential idea and can be crossed out as  a "no" or marked as "done" if we planned it and created an issue (issue should be referenced)

Mapbox Examples on what you can do with Maps and JS
Especially interesting

[ ] Marker Clustering - we can use it to analyze race dencity in certain areas as well as quickly see amount of events
[ ] Different marker with different styles - we can use them go show events by-type (RR, TT, CRITS, etc)

@Me4ta could you please review this, go through links, mb you would get some other ideas

We can close it, @Restuta ?

@Me4ta not yet, since our map is an image, while we want it to be a real map, so let it stay open


Share PID namespace policy repository.

Description
Adds a new repository to store the code for the policy which will validate if a pod is sharing process namespace.
Related to https://github.com/kubewarden/kubewarden-controller/issues/598

@jvanz the repository is ready


Documentation is confusing for newcomer from "worlds" other than Ruby

I programmed in many languages, but not in Ruby. So i have to rely on Ruby documentation, because Crystal doc is currently little bit confusing for newcomers.
During reading book at http://crystal-lang.org/docs again and again, when coding and searching for some help, I still can't help feeling like many parts of it expects some previous knowledge of programming in Ruby. Some things are just missing and i must read Ruby documentation or books about Ruby so that the moment comes when i say: I see! This is how it works / it is meant.
Other place when i search help is api doc at https://crystal-lang.org/api, which looks unfinished / incomplete, so i also often have to search in Ruby API docs, to make sure how things are likely to work and then search in the sources of Crystal.
Please do not take this as criticism, i try to background introduce myself and my future effort that i want invest to help you with this. So i want to focus on adding missing things for others, until i forget how i started with Crystal.  It's not a problem for me, but I would like to help others, especially to real beginners to programming, because Crystal is an excellent language and deserves it.
I would one day be able to recommend, for example to students at university, Crystal as their first language without the need to learn Ruby first.
I also think the diversity that programmers from other worlds (for example I'm primarily Java Guy) will bring can bring a lot of good for Crystal language and libraries design, and for whole Crystal community.

Yes, we're still missing lot's of documentation. Yet for some reason, many Crystal developers still manage to get around. I don't know if this is just because of Ruby background. There are also many differences to Ruby...
Anyway, it's great that you're willing to help! Especially people who are new to the language have a fresh view on things and what documentation is needed the most. Thanks for that!
If you can't write documentation for something yourself but think that it's important to document, don't hesitate to open issue asking someone else to do it.

I still can't help feeling like many parts of it expects some previous knowledge of programming in Ruby.

This is a well known issue! However, since it's very difficult for us - who already know the language - to figure out what's missing we really really need the community's help to address this issue. If you have to look something up in ruby docs bcause you don't understand it, please make an issue, or a comment on this issue to let us know. We can then work together on improving the documentation!

Two years later, how does everybody feel about status quo? Is it worth to keep this issue open, can find some concrete actionable items to work on?

I think the status quo didn't change much, but I agree it's best to have actionable items instead. Let's close it.

I hear frequently comments like "api doc ... looks unfinished / incomplete", and I'd love to contribute, but I don't know what's actually missing or what people see as missing.  I'm wondering, is there a way to automatically scan the code base to come up with a list of methods that need docs?

Technically, it's not hard. The information is all easily available in the API docs. But the nested document structure makes it less than trivial to query.


Fix conflict tests

Double-spends are tracked in the wallet so they can be flagged persistently.  This requires them to be distinguished from malleability clones, but they must not be "swept under the rug" as clones are (clones' accounting metadata is copied from the first clone).
txn_doublespend.py is corrected not to check for the (broken) double-spend sync behavior, and a new test txn_clone.py is introduced which does expect the sync behavior for a true clone.
This change exists as bitcoin/bitcoin#5881, but is needed now in XT.

@gavinandresen ?
Is there something specific holding up the merge into Core? I see that it's been ignored for over a month now.

This was against 0.10.2A.  Subsumed by the 0.11 patches.


BB-27 - [BUG] Reverse lookup record for host alias name still being created when dns_server_enable_extended_names set to false

Reverse lookup record still being created when dns_server_enable_extended_names set to false.  No forward lookup record is created, which is expected.
Context
When ```dns_server_enable_extended_names: false",  there should be not forward nor reverse lookup record for host alias name created for a nodes.  But the result is that reverse lookup record still gets created.
Process

Set variable, dns_server_enable_extended_names, to false
Run dns_server role
Query host name by an ip address

dig -x <ip address>

Expected result
; ANSWER SECTION:
<IP_ADDRESS>.in-addr.arpa. 86400 IN   PTR     compute-0-1.cluster.local.

Current result
;; ANSWER SECTION:
<IP_ADDRESS>.in-addr.arpa. 86400 IN   PTR     compute-0-1.cluster.local.
<IP_ADDRESS>.in-addr.arpa. 86400 IN   PTR     compute-0-1-net-1.cluster.local.

Possible Fix
Update the dnf reverse lookup template file to not create an reverse lookup for host name alias.
Additional data
OS: RockyLinux 9.3 x86_64

Dear @sgaosdgr
Thank you for reporting this issue :blush:
Indeed, I even forgot to fix bmcs, so both done now.


Coverage

Section "The problem of coverage" - I’d suggest to guide the reader to play with the two erroneous cases in the code snippet. How exactly should the test case warn them about a failure to divide by zero? What should they expect? It may not be clear to the reader what should happen when a value in B is set to 0, for example - nothing visually noticeable happens currently. It is not even a test case, so no green/red coloring is performed.

Fixed.


Feature request: allow some static workspace names

I'd like to keep a few of my workspaces with names I give them, like "1: work", "4: pics", and use this daemon to dynamically name all the workspaces that aren't on that exceptions list, which I could configure in the config file. Possible?

Hello, I just looked into this.
there is a single line to be changed, I changed it here
https://github.com/CastixGitHub/i3-workspace-names-daemon/commit/986ee65a7132854235228862259ccc7935fcb1a5#diff-2f1824e92c1a5b4d944c82038f257be7R195
I noticed it reaching 100% coverage, writing this test
https://github.com/CastixGitHub/i3-workspace-names-daemon/commit/986ee65a7132854235228862259ccc7935fcb1a5#diff-44c2c318351d9fcd29d696cbd1a4b0f0R135
so, you will also need to put something like this
bindsym $mod+i workspace i: work

in your i3 config file in order to create a named workspace
currently it this script does not take exceptions, it takes into consideration all numbered workspaces
so you can try to either use my fork (pytest branch), wait until this gets merged or fix the line yourself


Background mode not working on Catalina

The option to use the gif as a desktop background doesn't work as of macOS Catalina.

The reason the background mode is not working is the sandbox around the ScreenSaver engine.
How the mechanism was working in Pre-Catalina:

creating a plist file for the launch daemon in:
/Users/username/Library/LaunchAgents/com.waitsnake.animatedgif.plist
This contains the command for launch-daemon to start the ScreenSaver engine in a normal desktop window (a option Apple created once for screensaver debugging)
-> This is not longer working because of the sandbox that not allows files to be written.
Execute a terminal command to let launch daemon known that there is a plist file to use
Launch-daemon itself starts the ScreenSaver engine in a normal desktop window
when the screensaver AnimatedGif is loaded by ScreenSaver-Engine the saver itself detects than that it was started in window mode and not normal saver mode. if this is the case the saver changes the window type from a normal window to a background window.

Anyway because of the sandbox step 1) is not working and so background mode is not possible on Catalina. It could be fixed if Apple will allow Screensaver-Developers that a Screensaver can ask the user for Entitlements it needs to run. Ask a User for needed Entitlements is the way it works for normal Apps in Catalina.
The easiest workaround I could imagine is to disable or to remove the button that starts the background mode from the configuration panel so a user can not interact with it.
It is also possible to ask for the version of the operating system during initialization and disable the button for background mode programmatically in case version 10.15 is detected.
 Thanks for that. Sorry, but I was pissed off by Apple as they messed-up the screensaver API completely in Catalina with this new sandbox “feature” without giving the developer proper ways to handle this (e.g. ask User for Entitlements as a normal Apps can do) and I didn’t want to change the Screensaver in a direction that not fits my main use case (use it with offline GIFs rather than GIFs from URLs).

@Waitsnake
Thank you for getting involved 😀
I'd look into the different options when I have time, but leaning towards removing / disabling the button.
Let's hope Apple will fix this some how and that your original implementation / feature will be possible once again.


Fallback Policy threshold is not respected

Rasa Core version: 0.9.3
Python version: 3.6
Operating system (windows, osx, ...):osX
Issue:
Fallback policy is not working
fallback = FallbackPolicy(fallback_action_name="utter_fallback",
                          core_threshold=0.2,
                          nlu_threshold=0.2)
    agent = Agent(domain_file, policies=[
        AugmentedMemoizationPolicy(max_history=max_history),
        KerasPolicy(),fallback])
    training_data = agent.load_data(training_data_file)

    agent.train(training_data,
                       batch_size=20,
                       epochs=200,
                       validation_split=0.2,
                       max_number_of_trackers=100)

However when called, I receive intents with confidence less than 20% predicts the next action as defined but not fallback.
Not sure why is that

have you added a story with the fallback action?

Yeah

try adding
## fallback
  - utter_fallback

Ok, I will give it a shot 👍

Is it possible to create a pattern if fallback happens more than once, I change to another action?

@akelad  do we have to create an intent for fallback and if yes how can we determine training phrases for a fallback????

No you don't need to create an intent for the fallback. You can still do that, but using the FallbackPolicy is another approach: it looks at the confidence scores of the intent & action predictions and if they are to low runs a custom action.

@tmbo as in dialogflow fallback has its own json response for an out of scope message. I want a json response to handle at my node server end. I am not using actions for replies i am parsing for intent matching and sending replies from my node app . By adding fallback policy i am not getting right response it is catching up wrong intent's

@tmbo could you please share how to use FallbackPolicy?

@Primtek have you read the comments in this thread, they have quite a good explanation of how to use it. In addition to that, here is the exact code you have to add to your training script: https://core.rasa.com/patterns.html?highlight=fallback#fallback-default-actions
And make sure to add this story as well:
## fallback
  - utter_fallback

Hey sorry to reopen this. Any help would be very appreciated!!
How exactly do you train the model with the new fallback policy using the command line?
I know rasa_core/train.py has a '--fallback_action_name', argument. Would I specify the python script afterwards  for example ;
python -m rasa_core.train -d domain.yml -s stories.md -o models/dialogue --fallback_action_name fallback.py
with fallback.py being :
from rasa_core.policies.fallback import FallbackPolicy
from rasa_core.policies.keras_policy import KerasPolicy
from rasa_core.agent import Agent

fallback = FallbackPolicy(fallback_action_name="action_default_fallback",
                          core_threshold=0.3,
                          nlu_threshold=0.3)

agent = Agent("domain.yml", policies=[KerasPolicy(), fallback])

If not how exactly do I train my model with fallback.py being taken into account using the command line?
Thanks!!

Since the original issue was solved, I'll close it.
@asaiyed10 please post questions like this in our forum
You don't need to specify the --fallback_action_name, there's a default one that comes with rasa core. There is however nlu_threshold and core_threshold args which you should define


Fix populate on Get all exams by subjectId ( question -> questions )

@locxuandao Is this task completed?


feat(schema): Rename schema fields

Goal
Rename fields per team discussion

Tests are failing fyi @kkyeboah


⚠ Redacted has degraded performance

In aa71dad, Redacted ($RED) experienced degraded performance:

HTTP code: 200
Response time: 14031 ms

Resolved: Redacted performance has improved in 426b558.


Add sanitizers for WAMR CI

Hi team,
Proposing adding builds with different sanitizers (asan, ubsan, tsan) to improve overall code quality and safety

[X] add sanitizers for build_samples_wasm_c_api
[ ] fix ASAN errors
[ ] fix TSAN errors
[ ] fix UBSAN errors
[ ] add sanitizers for other tests

talking about ASAN it's quite likely to be false-positive as this projects implements custom stack unwind.
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
core/iwasm/common/wasm_runtime_common.c
core/iwasm/aot/aot_runtime.h
core/iwasm/aot/aot_loader.c```

Closing this PR to open a separate one for each sanitizer that will be added


bugfix: fix shell seata server ip address registered to the nacos

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

repeat 4701

@DCloudCoder thanks for your contribution，you can review the PR #4701


Remove meshzoo from napari

Description

As mentioned in https://github.com/napari/napari/issues/4324, meshzoo recently switched from being a small clean library to one with opaque source code and dependencies on binary only libraries which seem to serve no purpose, namely x21 and  kgt.
These libraries prevented pip install -e .[dev] from working on arm64. (Beyond that, I find it unnerving that a binary-only library with zero documentation was being installed when we set up a development environment.)
I was able to maintain the examples by using vispy.geometry import create_sphere. As a bonus, we no longer need to check for meshzoo when testing these example.
h/t to @Czaki and @psobolewskiPhD on Zulip.
Type of change

[X] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[X] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Both examples work on my end!
python clipping_planes_interactive_.py
does yield some warnings:
FutureWarning: Public access to Window.qt_viewer is deprecated and will be removed in
v0.5.0. It is considered an "implementation detail" of the napari
application, not part of the napari viewer model. If your use case
requires access to qt_viewer, please open an issue to discuss.!
/Users/piotrsobolewski/Dev/napari/examples/clipping_planes_interactive_.py:119: FutureWarning: Public access to Window.qt_viewer is deprecated and will be removed in
v0.5.0. It is considered an "implementation detail" of the napari
application, not part of the napari viewer model. If your use case
requires access to qt_viewer, please open an issue to discuss.!

Also, the spheres_.py looks more like a butt than two spheres... but I guess that's a different issue 🤣

qt_viewer is also unrelated to this change.


Line items with adjustments get double-applied discount amounts, causes under-reporting of tax liability

Please note I am using the 2-3-stable branch, I have not tested or compared to master branch.
Bug
Line item transactions are created in Avalara here:
https://github.com/railsdog/spree_avatax_certified/blob/2-3-stable/app/models/spree/avalara_transaction.rb#L295
Notice that the field used is 'pre_tax_amount', which is a field directly on the line_items table.
The table contains fields for quantity, price, and adjustment_total. The price column holds the pirce of the item before it is discounted, so the acutal price before the discount is quantity * price.
The discounted price is (quantity * price) + adjustment_total. (Note that adjustment_total is stored here in a negative values, as the total amount of adjustment that this line item has applied to it.)
Note that Spree stores pre_tax_amount as the result of the equation (quantity * price) + adjustment_total, so pre_tax_amount contains the price of the items after they have received their discount.
When the total transaction is passed to Avalara, one of the global (top-level) fields passed is "Discount", seen here:
https://github.com/railsdog/spree_avatax_certified/blob/2-3-stable/app/models/spree/avalara_transaction.rb#L419
Because all_adjustments scoops up both the order-level adjustments and the line item adjustments, this appears to create additional discounts in Avatax, thus the Avatax system is recording discounts on top of already-discounted prices, reducing the taxable amount to below the actual taxable amount.
Affected
This problem appears to only affect line items that have per-line item adjusments (feature introduced in Spree 2.2). As far as I can tell, other kinds of adjustments (whole order adjustments and shipping adjustments) are not affected by this problem.
Suggested Fix
I can see two possible remedies for this:

pass the before-discount line item price to avalara in the transactions. in avalara_transaction.rb#L295 change line_item.pre_tax_amount.to_f to  (line_item.quantity * line_item.price) . If the origional design intentaiton was to pass the full line item price, before discounts, this is probably the solution that will bring the implmentation correclty in line with the original design.

As an alternative fix continue to pass the discounted line items in the Line item transactions, but change the Discount that is passed to only include order-wide adjustments and not line item adjustments. For this fix, avalara_transaction.rb#L419 changes from order_details.all_adjustments to order.adjustments

(however, I'm not sure if this may remove the shipping adjustments which are needed? If so, maybe (order.adjustments + order.shipment_adjustments)

I think the root of the fix has to do with GAAP and how Avatax is designed to work -- should the line items be submitted before-discounted price, or is it OK to submit them after discounts have been applied.
I spoke to Avalara support (Cratha) just now and they informed me that either solution is acceptable in terms of the Avatax software.
For us at Mack Weldon, I'm actually more inclined to go with solution #2 (above), because I don't really want discounts order level applied proportionally in Avalara. I can definitely come up with use cases for which this does work correctly (for example, let's say 1 line item is discounted 10% but another one is discounted $5. Proportional application on Avalara's side won't work)
So my only final question has to do with whether or not the spree shipping adjustments should be passed as discounts at all. I'm inclined to say no, since these are actually charges and not discounts.
I would propose changing line 419 to :
        :Discount => order_details.adjustments.where(source_type: "Spree::PromotionAction").any? ? order_details.adjustments.where(source_type: "Spree::PromotionAction").pluck(:amount).reduce(&:+).to_f.abs : 0,

this way, only order-level adjustments will be passed to Avalara.
Adjusted line items will continue to have their reduced amounts passed to Avalara, as currently implemented.
So essentially, from Avalara's perspective, Spree line-item level adjustments will be as if they don't exist.

Thank you for looking into this. I had put some time in it today, but needed to hear back from Avalara on a few things. I will put this through and test it. Should be completed by tomorrow.

By changing https://github.com/railsdog/spree_avatax_certified/blob/2-3-stable/app/models/spree/avalara_transaction.rb#L295 to
line[:Amount] = line_item.price.to_f
Fixes the issue, just keep in mind when dealing with returns, it will suggest refunding the full amount and not the actual amount paid for.

@acreilly I see you seem to be suggesting that we go with option #1 (as I outlined above).
I think perhaps you meant that to be  ``` (line_item.price * line_item.quantity).to_f ***,
In Spree's domain model, line_item.price is the price for 1 single item.
the Spree Avatax documentation, it clearly says that the "Amount" field on the line item should be the qty * unit price. I have highlighted the relevant section from the Avatax docs below:

So, essentially, you're saying that the items should be passed with the full prices to Avatax, and then keep the all_adjustments as the sum of the amounts passed on the Document level in the "Discount" field?
Why are you also passing shipping adjustments as well to Avatax?

Can you highlight what you are talking about with the shipping adjustments?
On Sat, Jun 13, 2015 at 9:52 AM, Jason Fleetwood-Boldt <
<EMAIL_ADDRESS>wrote:

@acreilly https://github.com/acreilly I see you seem to be suggesting
that we go with option #1
https://github.com/railsdog/spree_avatax_certified/pull/1 (as I
outlined above).
I think perhaps you meant that to be ``` (line_item.price *
line_item.quantity).to_f ***,
In Spree's domain model, line_item.price is the price for 1 single item.
the Spree Avatax documentation, it clearly says that the "Amount" field on
the line item should be the qty * unit price. I have highlighted the
relevant section from the Avatax docs below:
[image: 2015-06-13_0947]
https://cloud.githubusercontent.com/assets/59002/8144542/8d67ca96-11b1-11e5-80d0-947f4faa3149.png
So, essentially, you're saying that the items should be passed with the
full prices to Avatax, and then keep the all_adjustments as the sum of the
amounts passed on the Document level in the "Discount" field?
Why are you also passing shipping adjustments as well to Avatax?
—
Reply to this email directly or view it on GitHub
https://github.com/railsdog/spree_avatax_certified/issues/37#issuecomment-111711464
.

--
Allison Reilly

I was just referring to order_details.all_adjustments -- this include order, lineitem, and shipping adjustments by default. I guess that is by design then?
I think I understand why it is implemented this way, so if the intention is to include all those adjustments in the document-level "Discount" field then that makes sense to me.

regarding (line_item.price * line_item.quantity).to_f
it looks like you are already a step ahead of me...
https://github.com/railsdog/spree_avatax_certified/commit/f50c6ecdadb661f02a27025ff6ea7709049923c0

@acreilly re-opening.  We need to make sure we have a few eyes on this and have some good code review before closing.

No problem, I have made the fix. Unfortunately, when I began working on this gem, Avalara's documentation was not nearly as good as it is now. @jasonfb Would you like to update the gem on your side and test if it is working for you?

Yes I'll have to go over this with Charley (our head of Finance) on Monday and get back to you.

Was the issue fixed for you?


Deprecation of Blob Helper

This task is here to track the effort to deprecate the following:

Generated.generated?
BlobHelper

These deprecations involve some pending changes on GitHub's side.

CC: @pchaigno

ok cool  what if u use a rrs.

@freddyrpina What do you mean?

@lildude Was there any progress on this?
PS: @Alhadis I removed a spam comment and your answer.

Wait, what did they say again? It's already vanished from my memory. :(

@lildude Was there any progress on this?

I have no idea 😁 I don't know any of the history or backstory around this.

These are just a few functions of the API that have been marked as deprecated on the Linguist side for a while. See 2006# (Comment) and #3359 for context.

I'm assigning you @lildude. Since it's something to do on closed-source code, it's out of my hands.

No idea what the hell's going on here, but I'm pretty damn sure that if I don't know, a bot doesn't know. :|
Unstale'd.

@brblck Have the changes required on GitHub's side been implemented? :tadaa:


How to change the Const module value without a mouse wheel ?

I use a wacom table in linux.

Not sure if it's in the docs but shift and cursor keys should do it.
pe 15. tammik. 2021 klo 2.20 rncar<EMAIL_ADDRESS>kirjoitti:

I use a wacom table in linux.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kometbomb/prototracker-modular/issues/47, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIIV2KXWY7754ONTG26NRTSZ6C23ANCNFSM4WDI5KJA
.

Not sure if it's in the docs but shift and cursor keys should do it.
pe 15. tammik. 2021 klo 2.20 rncar<EMAIL_ADDRESS>kirjoitti:

I use a wacom table in linux.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kometbomb/prototracker-modular/issues/47, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIIV2KXWY7754ONTG26NRTSZ6C23ANCNFSM4WDI5KJA
.


[AlertIOS] Change the keyboard type in prompt()

Is there a way to change the keyboard type in the text field for the prompt dialog? We need an option like keyboardType.

Hey gpbl, thanks for reporting this issue!
React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.

If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.

We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!


Filter away incompatible versions of COE based on app version in download manager

The app only works with the COE version 0.0.6. Therefore it should not be possible to download a previous version of the COE by using the app, as it is not compatible.

Delayed to post INTO-CPS


Container name with dots

Exception: Invalid docker image name: All letters must be lowercase and '.' or '_' characters are not allowed
@JosepSampe why we have this limitation? Seems Docker allows to use dots

@JosepSampe This was my request. Can you create a new lithops release?


Combined GEF & BSS facilities under one collection

removed the gef-facilities collection and combined all GEF facilities with BSS

removed the gef-facilities collection and combined all GEF facilities with BSS

Just to confirm all the facilities now will be stored in facilities collection?

removed the gef-facilities collection and combined all GEF facilities with BSS

Just to confirm all the facilities now will be stored in facilities collection?

yes, that's correct. we did the same thing for bss & gef deals a few weeks ago. now we have it for facilities as well


Image Builds getting stuck at "pip install -r requirements.txt"

Whenever I am trying to push a model to Replicate the process gets stuck when building the image as it comes to pip install step.
Building Docker image from environment in cog.yaml as r8.im/tonyhopkins994/...
[+] Building 15.5s (10/12)                                                                               docker:default
 => [internal] load .dockerignore                                                                                0.6s
 => => transferring context: 357B                                                                                0.1s
 => [internal] load build definition from Dockerfile                                                               0.9s
 => => transferring dockerfile: 315B                                                                               0.0s
 => resolve image config for docker.io/docker/dockerfile:1.4                                                       2.4s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84  0.0s
 => [internal] load metadata for r8.im/cog-base:cuda11.8-python3.9                                                 2.4s
 => [auth] cog-base:pull token for r8.im                                                                           0.0s
 => [1/5] FROM r8.im/cog-base:cuda11.8-python3.9@sha256:60b76d38c9c0869a1f634a620d37e45db364ef832c39fd2703ba23b37  0.0s
 => [internal] load build context                                                                                0.5s
 => => transferring context: 425B                                                                                0.1s
 => CACHED [2/5] COPY .cog/tmp/build20240904182212.7461832423469108/requirements.txt /tmp/requirements.txt         0.0s
 => ERROR [3/5] RUN pip install -r /tmp/requirements.txt                                                           5.4s
------
 > [3/5] RUN pip install -r /tmp/requirements.txt:
4.580 /root/.pyenv/pyenv.d/exec/pip-rehash/pip: line 20:    83 Illegal instruction     "$PYENV_COMMAND_PATH" "$@"
------
Dockerfile:4
--------------------
   2 |     FROM r8.im/cog-base:cuda11.8-python3.9
   3 |     COPY .cog/tmp/build20240904182212.7461832423469108/requirements.txt /tmp/requirements.txt
   4 | >>> RUN pip install -r /tmp/requirements.txt
   5 |     WORKDIR /src
   6 |     EXPOSE 5000
--------------------
ERROR: failed to solve: process "/bin/sh -c pip install -r /tmp/requirements.txt" did not complete successfully: exit code: 132
ⅹ Failed to build Docker image: exit status 1

cog.yaml contents:
# Configuration for Cog ⚙
# Reference: https://github.com/replicate/cog/blob/main/docs/yaml.md

build:
  gpu: true
  cuda: "11.8"
  python_version: "3.9"

  python_packages:
    - torch
    - torchvision
    - torchaudio
    - torchsde
    - transformers>=4.28.1
    - safetensors>=0.3.0
    - accelerate
    - Pillow
    - scipy
    - tqdm
    - diffusers>=0.30.0

predict: "predict.py:Predictor"

I've tried pushing 3 different models that have successfully been built and run before and they're all getting stuck with this error now.
I've been pushing models to Replicate using cog for a while but havent come across this issue before. Any help is appreciated : )

@tonyhopkins994 I'm having same exact issue - model was successfully built just yesterday :/ any luck?

@tonyhopkins994 I'm having same exact issue - model was successfully built just yesterday :/ any luck?

None so far. I've tried restarting Docker, deleting the previous version of the Docker image and doing a fresh build, restarting the VM and the PC. I can't imagine there's any problems with the actual .yaml file because I have hosted models with that config before and the problem is not even model specific.

Same issue for me on my Macbook since few days.
I tried to build/push using the github actions setup-cog and it worked fine so I think there is something wrong with my machine. However cog should be able to build models on any machine so this is weird.

thanks @juyaki can also confirm it works w/ GH actions for me. Must be an apple silicon specific issue. Maybe related to the pyenv 2.4.11?

I was using pyenv 2.4.10 and still got this issue, and since 2.4.10 is around since a month I think other people would have noticed...

Shouldn't be an apple silicon specific issue because I've been dealing with this on an intel machine.

Can you try this with --use-cog-base-image=false and let me know if the issue still persists?

--use-cog-base-image=false

Didn't solve the issue for me but triggered a new one:
=> CANCELED [stage-1  2/11] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked set -eux; apt-get update -qq && apt-get install -qqy --no-install-recommends curl; rm -rf /var/lib/apt/lists/*; TINI_VERSION=v0.19.0; TINI_ARCH="$(dpkg --print-architectur  0.0s
------
 > [deps 3/5] RUN --mount=type=cache,target=/root/.cache/pip pip install -t /dep /tmp/cog.whl:
3.261 ERROR: cog.whl is not a valid wheel filename.
------
Dockerfile:4
--------------------
   2 |     FROM python:3.12 as deps
   3 |     COPY .cog/tmp/build20240906211900.889378794329390/cog.whl /tmp/cog.whl
   4 | >>> RUN --mount=type=cache,target=/root/.cache/pip pip install -t /dep /tmp/cog.whl
   5 |     COPY .cog/tmp/build20240906211900.889378794329390/requirements.txt /tmp/requirements.txt
   6 |     RUN --mount=type=cache,target=/root/.cache/pip pip install -t /dep -r /tmp/requirements.txt
--------------------
ERROR: failed to solve: process "/bin/sh -c pip install -t /dep /tmp/cog.whl" did not complete successfully: exit code: 1

Can you try this with --use-cog-base-image=false and let me know if the issue still persists?

Tried a build with the --use-cog-base-image=false and got the following error:
Building Docker image from environment in cog.yaml as r8.im/tonyhopkins994/stable-materials...
[+] Building 160.4s (11/19)                                                                              docker:default
 => [internal] load build definition from Dockerfile                                                               0.8s
 => => transferring dockerfile: 2.21kB                                                                             0.0s
 => [internal] load .dockerignore                                                                                0.5s
 => => transferring context: 357B                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile:1.4                                                       1.4s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84  0.0s
 => [internal] load metadata for docker.io/library/python:3.9                                                      5.1s
 => [internal] load metadata for docker.io/nvidia/cuda:11.8.0-cudnn8-devel-ubuntu22.04                             3.4s
 => ERROR [deps 1/5] FROM docker.io/library/python:3.9@sha256:5be6ab129779da4729eb8be146bdddc3662b7c7b6cc7a07e9  145.7s
 => => resolve docker.io/library/python:3.9@sha256:5be6ab129779da4729eb8be146bdddc3662b7c7b6cc7a07e9f5a675cdb4746  2.2s
 => => sha256:5be6ab129779da4729eb8be146bdddc3662b7c7b6cc7a07e9f5a675cdb4746c7 10.35kB / 10.35kB                   0.0s
 => => sha256:cea2608c91d4b92d9e12848f922085195ccd41242e0aa682d8a10b196afc5478 2.52kB / 2.52kB                     0.0s
 => => sha256:f995cc3ec8cf00c0e4dca3bfc4877ac1e938edc035d725f673be91018c09652a 7.27kB / 7.27kB                     0.0s
 => => sha256:8cd46d290033f265db57fd808ac81c444ec5a5b3f189c3d6d85043b647336913 49.56MB / 49.56MB                  27.8s
 => => sha256:2e6afa3f266c11e8960349e7866203a9df478a50362bb5488c45fe39d99b2707 24.05MB / 24.05MB                  11.7s
 => => sha256:2e66a70da0bec13fb3d492fcdef60fd8a5ef0a1a65c4e8a4909e26742852f0f2 64.15MB / 64.15MB                  15.3s
 => => sha256:1c8ff076d818ad6b8557e03e10c83657cc716ab287c8380054ff91571c8cae81 52.55MB / 211.27MB                148.3s
 => => sha256:b4383cf9d518a310e9475543865f99a0f42680d1b208992c065066d743b383a9 6.16MB / 6.16MB                    17.9s
 => => sha256:3fdc16599dab968128f232f839d96fc4ed7580fe9ac15c0fc041c77051dfaf6c 15.82MB / 15.82MB                  23.6s
 => => sha256:cc4dba91fd49abc8a140f5a4cbb088448d398c793c9db6bb84b1d275960f9d29 232B / 232B                        24.5s
 => => sha256:9b34a017daeaefa45a9454b0fe70629a37c243fae4ab2d652e0a75f0668a7481 2.70MB / 2.70MB                    25.9s
 => => extracting sha256:8cd46d290033f265db57fd808ac81c444ec5a5b3f189c3d6d85043b647336913                          4.7s
 => => extracting sha256:2e6afa3f266c11e8960349e7866203a9df478a50362bb5488c45fe39d99b2707                          1.4s
 => => extracting sha256:2e66a70da0bec13fb3d492fcdef60fd8a5ef0a1a65c4e8a4909e26742852f0f2                          5.4s
 => [internal] load build context                                                                                0.7s
 => => transferring context: 58.20kB                                                                               0.0s
 => CACHED [stage-1 1/7] FROM docker.io/nvidia/cuda:11.8.0-cudnn8-devel-ubuntu22.04@sha256:8f9dd0d09d3ad3900357a1  0.0s
 => [stage-1 2/7] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked set -eux; apt-get update -qq && a  105.2s
 => CANCELED [stage-1 3/7] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked apt-get update -qq && apt  44.8s
------
 > [deps 1/5] FROM docker.io/library/python:3.9@sha256:5be6ab129779da4729eb8be146bdddc3662b7c7b6cc7a07e9f5a675cdb4746c7:
------
Dockerfile:2
--------------------
   1 |     #syntax=docker/dockerfile:1.4
   2 | >>> FROM python:3.9 as deps
   3 |     COPY .cog/tmp/build20240907003028.1324282726843351/cog-0.9.20-py3-none-any.whl /tmp/cog-0.9.20-py3-none-any.whl
   4 |     RUN --mount=type=cache,target=/root/.cache/pip pip install -t /dep /tmp/cog-0.9.20-py3-none-any.whl
--------------------
ERROR: failed to solve: failed to copy: local error: tls: bad record MAC
ⅹ Failed to build Docker image: exit status 1

So the previous error is gone but I'm not making any sense of the newer one either : )

I think the root of the issue here is something has gone with the arm64 versions of our base images, looking into it, hoping to have a solution in a few days (takes a while to rebuild all these)

Had the same issue in Macbook Air M1. Tried with GitHub Actions and the image was successfully built.

Same issue here

First time I (tried to) use cog and same issue on a Mac Studio (M1 Max).
Fresh install of cog (with brew install cog)
cog --version
cog version 0.9.20 (built 2024-08-19T14:53:01Z)

I simply tried to build cog-face-to-sticker and voila.
------
 > [stage-0 4/7] RUN pip install -r /tmp/requirements.txt:
1.289 /root/.pyenv/pyenv.d/exec/pip-rehash/pip: line 20:    83 Illegal instruction     "$PYENV_COMMAND_PATH" "$@"
------

Not going further, as I'm not enough familiar with all of this; I will wait for a fix 😅
Thanks.

OK I do believe this has been fixed, running @tonyhopkins994 cog.yaml on my mac seems to correctly pip install, in addition to this the integration tests all now run on my mac and don't produce illegal instruction errors. I'll close this but feel free to comment if this Illegal Instruction issue is still haunting you. If its a different issue lets make a separate issue for that.
If you are interested as to why this happened its due to me attempting to make the python interpreter that pyenv installs optimized to increase the speed and boot times of the containers, however it included -march=native and -mtune=native which introduced instructions tuned to the builders CPU that other CPUs and emulators can't handle, see here for more info:
https://brad.net.nz/blog/2019/07/12/docker-cflags-marchnative-and-illegal-hardware-instruction/
https://stackoverflow.com/questions/54039176/mtune-and-march-when-compiling-in-a-docker-image
In the future we will be more careful here by gating the base images behind flags.

Confirmed fixed 👍🏻

Many thanks.
And thank you for the explanation, it's interesting.


updated the parameters table for websites

🗣 Description

💭 Motivation and Context

🧪 Testing

📷 Screenshots (if appropriate)

✅ Checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

Looks like the precommit fixes I had made were reverted. I reconfigured so prettier will use the correct version. Do you want me to run precommit against all files, or is there WIP that it will effect?

Looks like the precommit fixes I had made were reverted. I reconfigured so prettier will use the correct version. Do you want me to run precommit against all files, or is there WIP that it will effect?


Requires mercurial

The plugin does not load without Mercurial plugin.  As a git user, I'd like the features of this plugin (the plugin name is "git commit message"), but without the dependency on the Mercurial plugin.

I am running the plugin within IntelliJ Idea without having mercurial installed. Can you show me the Idea Logs?


libudev-dev dependency

I was just attempting to install on a fresh Ubuntu system and discovered that it would fail until I installed libudev-dev.

@tompropst thanks for reporting.
Was the node-usb dependency failing? It's optional, so shouldn't be an issue.
Could you please share the console output and npm-debug log of the failure?

@sandeepmistry, I don't recall which package the failure was occurring in.  I saw a specific reference to libudev.h not found, installed that dependency, and viola. I'll try to reproduce it.

@sandeepmistry here are the reproduction steps and error information.

Clean Ubuntu install.
Install Node.js.

sudo apt-get install nodejs

Create node symlink to nodejs.

 System Linux 3.19.0-26-generic
gyp ERR! command "nodejs" "/usr/bin/node-gyp" "build" "--fallback-to-build" "--module=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding/usb_bindings.node" "--module_name=usb_bindings" "--module_path=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding"
gyp ERR! cwd /home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb
gyp ERR! node -v v0.10.25
gyp ERR! node-gyp -v v0.10.10
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp build --fallback-to-build --module=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding/usb_bindings.node --module_name=usb_bindings --module_path=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
node-pre-gyp ERR! stack     at maybeClose (child_process.js:743:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:5)
node-pre-gyp ERR! System Linux 3.19.0-26-generic
node-pre-gyp ERR! command "node" "/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb
node-pre-gyp ERR! node -v v0.10.25
node-pre-gyp ERR! node-pre-gyp -v v0.6.4
node-pre-gyp ERR! not ok
Failed to execute 'node-gyp build --fallback-to-build --module=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding/usb_bindings.node --module_name=usb_bindings --module_path=/home/plarray/code/node_modules/bluetooth-hci-socket/node_modules/usb/src/binding' (1)
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm WARN optional dep failed, continuing<EMAIL_ADDRESS>
><EMAIL_ADDRESS>install /home/plarray/code/node_modules/bluetooth-hci-socket
> node-gyp rebuild

make: Entering directory `/home/plarray/code/node_modules/bluetooth-hci-socket/build'
  CXX(target) Release/obj.target/binding/src/BluetoothHciSocket.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  SOLINK_MODULE(target) Release/obj.target/binding.node: Finished
  COPY Release/binding.node
make: Leaving directory `/home/plarray/code/node_modules/bluetooth-hci-socket/build'
<EMAIL_ADDRESS>node_modules/bluetooth-hci-socket
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
At this point, installing libudev-dev and retrying results in success.

@tompropst this is fine, as node-usb is an optional dependency on Linux, it's only needed on windows.
npm WARN optional dep failed, continuing<EMAIL_ADDRESS>
I've added a note in the read me for this.


LANDING_TARGET: support on firmware

WIP

[x] add coder and decoder (receiver, streamer)
[x] add uORB topics and msg
[x] add sdlog2 logging support
[x] submodules: update nuttx and mavlink to latest versions
[ ] add usage

I'm waiting for https://github.com/mavlink/mavlink/pull/400 merging. Also https://github.com/mavlink/mavlink/pull/401 may become handy for the usage case.

@LorenzMeier is there a usage case you propose to implementing here? Maybe something similar as APM has to IRLock?

I'm closing this since its incomplete and untested. If it is implemented in a complete fashion I'm more than happy to merge it since it looks useful.


double spaces in rich text editor cause problems

Entering two spaces makes tinyMCE insert a normal space and a non-breaking space entity; the latter is currently not handled correctly by the 'save' filter

Fixed  elegantly with commit 1701756c990c0e3b337d1779eef94810fce1e8cb


Swift 4 Compatibility

It would be awesome if there is a pod for swift 4

The pod is Swift 4 compatible. To disable Swift 3 @objc inference, you need to change 2 lines (use the "Fix me"s provided by Xcode)

Nice, also PRs are very welcome to add full Swift 4 compatibility. 🙇


Pattern logs match

Hi there, is it possible to specify for apache logs a group of log files? For an instance, on a shared server there will be one log file per domain /var/log/domain1.log.
So, could it work setting http log file to something like /var/log/*.log?
Thanks and keep up the great work!

Thanks for the kind words :) To address your question, PyFilter in its current state does not allow pattern matching on file names, this however could be changed with the use of glob. I think a nice addition would also be the ability to specify multiple log files via the use of a list in the config file

I think the glob is the best way to implement it. Think about a shared server with maybe 200 domains. Would be a pain to manually add an entry for each website :)

@lucianlazar1983 Apologies for the incredibly slow turn-around on this issue, the linked PR should resolve this issue!

@lucianlazar1983 Apologies for the incredibly slow turn-around on this issue, the linked PR should resolve this issue!

Thank you Jason, much appreciated! Will give it a go and post back feedback. Cheers!