NetworkExtension uses NSPrivacyAccessedAPICategoryFileTimestamp causing App Store Privacy issue

Hello,
We noticed one or more issues with a recent submission for TestFlight review for the following app:
Firezone
Version 1.0.0
Build<PHONE_NUMBER>
Although submission for TestFlight review was successful, you may want to correct the following issues in your next submission for TestFlight review. Once you've corrected the issues, upload a new binary to App Store Connect.
ITMS-91053: Missing API declaration - Your app’s code in the “Firezone” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryFileTimestamp. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
ITMS-91053: Missing API declaration - Your app’s code in the “PlugIns/FirezoneNetworkExtensioniOS.appex/FirezoneNetworkExtensioniOS” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryFileTimestamp. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
Apple Developer Relations

Looks like something inside the NetworkExtension uses the API as well.

Hello,
We noticed one or more issues with a recent submission for TestFlight review for the following app:
Firezone
Version 1.0.0
Build<PHONE_NUMBER>
Although submission for TestFlight review was successful, you may want to correct the following issues in your next submission for TestFlight review. Once you've corrected the issues, upload a new binary to App Store Connect.
ITMS-91053: Missing API declaration - Your app’s code in the “PlugIns/FirezoneNetworkExtensioniOS.appex/FirezoneNetworkExtensioniOS” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryFileTimestamp. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
Apple Developer Relations

It's probably coming from tracing_appender: https://github.com/tokio-rs/tracing/blob/master/tracing-appender/src/rolling.rs#L605

Unfortunately this is still an issue even without the log roller. Just got the email from Apple. 😢

Just received the error again. The saga continues.

I think I found the last place it's being used:
https://github.com/tokio-rs/tokio/blob/master/tokio/src/net/unix/pipe.rs#L1376
That means that codepath is likely being hit. I'll see if I can fork and patch around it to test the theory.

I've confirmed that this change successfully removes the last remaining _fstat from the debug target.
HOWEVER, _stat and _fstat are still present in the --release target.
Very strange


CSRSS injection after suspending PsProtection

hi darthton, i am trying to get x64 dll injected into csrss, i load driver which remove psprotection for 10 seconds and restore but in the time xenos returns error and bsod me. - Can send dump via email if you can provide.  am i miss something else like mitigation policy?
DEP (permanent); ASLR (high entropy); Dynamic code prohibited; Strict handle checks; CF Guard; Signatures restricted (Microsoft only)
any advice can give.  it work well for notepad when i protect it first.

Send to<EMAIL_ADDRESS>BSOD is probably due to csrss crash. Keep in mind you can't normally inject into csrss unless dll has microsoft signature. Manualmap shouldn't work either because of dynamic code restriction.


support set TProtocol when NewClientFactory

Support set TProtocol for ClientFactory and TableClientProxy.
And NewTableServiceClientFactory() with specify TProtocolFactory.
And support create SdsTHttpClient headers with different Content-Type based on protocol

+1


Issue with development environment not responding.

Sometimes the development freezes for a long time. With good luck it comes back up. This often happens even right after gdev up.
Log:
web_1              | 2017/02/23 13:21:59 [error] 312#312: *8 connect() failed (113: No route to host) while connecting to upstream, client: <IP_ADDRESS>, server: _, request: "GET / HTTP/1.1", subrequest: "/redis-fetch", upstream: "redis://<IP_ADDRESS>:6379", host: "hol.test"

deprecated issue


Cannot use Token-based Authentication Backend unless AXES_ONLY_USER_FAILURES is set to True.

I am running into a similar issue as #597 where I am using a Token Authentication Backend along side User-based authentication backends and I want to use Axes only for those User-based backends. I am running into an issue where my token based authentication will generate user_login_failed callbacks and as a result try and create AccessAttempt records with a username of "None" (a string).
I can work around this by setting AXES_ONLY_USER_FAILURES to True, however I really would like to do IP-based blocking (maybe AXES_LOCK_OUT_BY_USER_OR_IP or even just IP-based lockouts instead.

Hi @Kraust! This should now be resolved by version 6 release and the new AXES_LOCKOUT_PARAMETERS configuration flag that supersedes the old lockout parameter handling.
Please see: https://django-axes.readthedocs.io/en/latest/5_customization.html#customizing-lockout-parameters


Rename repo/project

Moving beyond four-function calculations with addition of booleans

Make sure to update lead heading in README.

New name shall be Wheel/WheelLang. Thanks, Emily.

Repo renamed.


swarm-website: multiple fixes

In an effort to add a bit more information about Swarm releases, I updated the website with a bit more current information.
I also fixed https://swarm.ethereum.org to forward to the website. I think, similarly as Geth, we should have information on Install/Download on our website.

Added Install section. Noticed that it is wrong in the documentation as well :/ Once we sort out the versioning and release process, this needs to be updated.
Disabled two broken links in the Papers section.
Updated the release date for POC 3.
Updated the location of the source code.

TODO:

[ ] currently Ubuntu instructions are wrong, as there is no such package. Actually even installing ethereum package, currently does not install Swarm. The only package we are actually publishing is swarm-unstable.

I will hold off with merging this, until https://github.com/ethereum/go-ethereum/pull/16988 is merged (and maybe even we have 0.3.1 released).


Add tolerations to cattle-node-agent for etcd/controlplane

https://github.com/rancher/rancher/issues/14296

Apply the same solution to in nginx-ingress-controller. This is necessary because the master nodes are static and can be used as the gateway for http / https requests.
kubectl patch daemonset nginx-ingress-controller -n ingress-nginx --patch "$(curl -sL https://gist.githubusercontent.com/superseb/257549cc2eeea197bae0667ac41abefa/raw/ad01acda10e21ae6eebd7e65f55b9bf4b66176bc/ds-cattle-node-agent-tolerations-patch.yml)


Fixes for German translation

Description
Since I'm not willing to create a new account with my personal information over at http://i18n.meetfranz.com/ just to fix some translation bugs, I created this PR. Sorry.
If contributors should really use that site, a github auth would greatly simplify the process and therefore make it much more attractive.
Motivation and Context
Fixed some incorrect words and replaced inconsistently used words.
How Has This Been Tested?
It has not.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project (run $ yarn lint).

Thank you :)


Single quotes should be allowed for value of "compatibility"

OS: Windows 7  I have ended up with a command like:
cleancss -c ie7 --rounding-precision '-1' <file>

ie7 shall not be enclosed in quotes, otherwise it's not recognized (that's the issue, see after)
-1 has to be enclosed in single quotes (so it's not handled as an option)

Also, I got confused by the single quotes in the readme: https://github.com/jakubpawlowicz/clean-css/blob/3.4/README.md#how-to-set-a-compatibility-mode
Thus, I think -c 'ie7', with single quotes, should be allowed as well.

Fair point, it should be!

It seems that --rounding-precision '-1' casts the value to NaN and not -1. The code works despite of this, by luck :-)

The real issue is that -1 cannot be used a CLI option value.
Current behaviour is that any non number value (e.g. '-1') internally results in no rounding.
What should be the advised way to disable rounding in CLI?

From now on --rounding-precision off is the new default value while -1 can still be used as an alias. Probably not used too much anyway since rounding will be disabled in 4.0.


Fixing typo

Hi @4c74356b41, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@4c74356b41 : Thanks for your contribution to the Azure documentation! The author, @rayne-wiselman, has been notified to review your proposed change.

@rayne-wiselman friendly reminder

@Jim-Parker
#sign-off
good to go


DNS resolution fails on Fuchsia due to C-ARES

DNS resolution is failing, because it is attempting to use C-ARES instead of the native resolver. We should disable C-ARES until we have a better solution. Internal context: b/159043106.

The change needed is:
--- a/include/grpc/impl/codegen/port_platform.h
+++ b/include/grpc/impl/codegen/port_platform.h
@@ -361,6 +361,8 @@
 #define GPR_ARCH_32 1
 #endif /* _LP64 */
 #elif defined(__Fuchsia__)
+#define GRPC_ARES 0
 #define GPR_FUCHSIA 1
 #define GPR_ARCH_64 1
 #define GPR_PLATFORM_STRING "fuchsia"


Add Github Actions CI

Fixes #46
Signed-off-by: siddhant-deepsource<EMAIL_ADDRESS>

@sourya-deepsource Will there also be any changes in the cli installation script since the path here has been changed to fetch the codepath from an environment variable.


Cannot see author of my Kata

Describe the bug
Kata author name disappear
To Reproduce
Steps to reproduce the behavior:
Open https://www.codewars.com/kata/my-languages with account ice1000
Expected Behavior
See my name
Screenshots

Closing as duplicate of #443


[Idea] Highlight Activites in stream/mark them as read

Next to the a page with all activities #528 it would be nice, if the you could mark them as read (or mark all as read) like here on github, facebook or your email inbox.
Or a easier way, highlight all activities since your last visit of the activity page, then you have to store only the date of the last visit.

There is now web notifications for that in master.


API call inside a JavaScript function present in a feature file

I  tried my best but could not find information on calling an API inside the Javascript function when dealing with automation in Karate. Now, I might get suggestions to call the API outside the function and then do operations inside the function. However, my use case is such that I have to call the API inside the function only. Is there a way to do this?
One approach is to create a Java file and then write the code in java. However, I specifically want to know if there is any way to call an API inside a JS function in a FEATURE FILE itself.

can you please ask this question on stack overflow ? I will answer it there: https://stackoverflow.com/questions/tagged/karate


Update to custom.scss

I have updated the custom.scss file according to the theme documentation and implemented the new zeplin design changes properly hope things will be good now, please review and let me know if any question

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

All done

please remove the overrides we pushed into the github.css and see that these changes apply without them?


Improve dcapt-snapshots tests

Currently, snapshot unit tests rely on test/dcapt-snapshots.json file which needs to be manually synced from https://raw.githubusercontent.com/atlassian/dc-app-performance-toolkit/master/app/util/k8s/dcapt-snapshots.json
This PR updates the tests to:

fetch the file from dcapt repo and write it to test directory
parse json and extract snapshot ids for the large dataset for all products
verifies the same ids are in the terraform plan modules

Checklist

[x] I have added unit tests (if applicable)

Neat! 👍


feat: show results with additional context

fixes #49
Summary
We show title headers that could be duplicated without additional context such as the URL. This PR adds additional context.
Before

After

@gabrielcsapo thanks for tapping me on the shoulder. I think this is an improvement and as a standalone PR can merge.  But I had something different in mind.
Details
What I had in mind was presenting the results closer to how Notion does it. (it's not perfect, so I'll outline what I think would be helpful to use)

To me, there are a few things here that make the results list clear.

The results always have the same top-level structure.

The title of the document always shows up on top.
The file path shows below it.

Next, if the query matches a substring in the document's body instead of the title, it shows that information. You can see that in the second result.

Now, if we look further, check out how they highlight substrings:

I like that they highlight only the part that matches your query, not the whole word that contains your query.
Currently, this is how this project shows substrings:

It highlights the whole word.  To me, this is somewhat hard to understand at first.
Proposal
Let's do it closer to how Notion does.

Titles on top
File Paths below
Remove the enter icon, this helps draw my attention to the external link icon if the file comes from an external source
Now, if the query matches something in the document instead of the title, show more below the file path (like Notion does)

If it matches the content of the page, show that with the substring highlighted.
if it matches a tag, show the tags highlighted.

I also think we should show external results and internal results in the same sections. No more sections at all, actually. Just keep the external icon and add something below the file path or at the bottom of the result that says something like External Source: Lixr

I tried to implement this, but I had a hard time understanding how the search index works.  I still can't understand what the single letter variables mean.
Here's my really shitty attempt to come up with a working example:

If you want to meet next week with @lbdm44 and help me understand how to make this work, I'm happy to attempt it or work with you guys on it.

@tylerbecks awesome write up! I think it definitely makes sense to implement the ideas you brought up. Ideally we can make it easier to tweak the search results in the future.
Let's sync up next week. I can merge this and publish for the time being tomorrow morning.


[Dependency] Bump JUnit to Version 1.1.5

Description
Bump JUnit to version 1.1.5
Review checklist

[x] PR is split into meaningful commits for the ease of reviewing
[ ] Tests have been written
[ ] Screenshots added (where applicable)
[x] Appropriate labels have been applied

Codecov Report

Merging #81 (0dfffc1) into main (d5c8ab2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #81   +/-   ##
=====================================
  Coverage   74.9%   74.9%
=====================================
  Files         45      45
  Lines       1354    1354
  Branches     400     400
=====================================
  Hits        1015    1015
  Misses       125     125
  Partials     214     214


Add notice as to which version of Jina examples work with.

Feature request:
A notice should be added to the top of all the READMEs in the example repo specifying which version of Jina these examples work with. The following text snippet is a good suggestion for what to add.
⚠ Please note that examples currently only work with Jina version 1.1. Please make sure you are running this version when using the examples. pip install jina == 1.1

Working on wikipedia, cross modal, multi modal, object search tumblr examples to update the latest version compatibility.


Problem with oscar.core.loading._import_module() in debug mode in Eclipse + PyDev

I'm porting a Oscar v0.8 project across to v1.0 from scratch and have hit a problem when running the debugger in Eclipse and PyDev that seems to stem from oscar.core.loading._import_module().
I am extending the catalogue app and when run from the normal Eclipse Run it goes fine but when run using Eclipse Debug I get
ImportError: No module named signals

I have not extended myshop.catalogue.signals (I've only added some fields to models.py).
The problem comes about in oscar.core.loading._import_module()
__, __, exc_traceback = sys.exc_info()
frames = traceback.extract_tb(exc_traceback)
if len(frames) > 1:
    raise

with PyDev running in debug mode frames contains:
[('/Users/<user>/.virtualenvs/myshop/lib/python2.7/site-packages/oscar/core/loading.py', 159, '_import_module', 'return __import__(module_label, fromlist=classnames)'), ('/Applications/eclipse-kepler/plugins/org.python.pydev_<IP_ADDRESS>411111611/pysrc/_pydev_imps/_pydev_pluginbase.py', 445, 'plugin_import', 'fromlist, level)')]

so it triggers the second condition detailed in the comments for _import_module().
The quick fix is to set
if len(frames) > 2:

and to just be aware that import errors may occur from inside the overridden module.
I'm not sure if this is only peculiar to my development setup, but I just wanted to flag it here in case someone else was experiencing this issue.

It won't fix for me. In my case there are 8 elements in the traceback. They appears while debugging using PyCharm 4 (PyCharm 3.4 is OK). Maybe it has something to do with https://github.com/mitsuhiko/pluginbase that was absent in previous versions of https://github.com/fabioz/PyDev.Debugger

Closing since issue is outdated and does not seem to be relevant any more. Please re-open in case of new questions/issues. Thanks!

Still relevant! PyCharm's remote pydev debugger is affected:
[<FrameSummary file /usr/local/lib/python3.7/site-packages/oscar/core/loading.py, line 182 in _import_module>,
<FrameSummary file /root/.pycharm_helpers/pydev/_pydev_bundle/pydev_import_hook.py, line 19 in do_import>]


builder: Workaround podman bug during manifest push

What this PR does / why we need it:
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirt-builder/1660974893405048832
723dd28d880e090e13b29aadf1792d4153dbad74a0a0dbd0b22979218e18137e
+ podman manifest push quay.io/kubevirt/builder:2305231145-64a7cd17b
Error: accepts 2 arg(s), received 1

publish-kubevirt-builder uses podman to build and publish the builder image. This change works around a known podman manifest push bug [1] by providing the destination until a now merged fix is released [2].
[1] https://github.com/containers/podman/issues/18360
[2] https://github.com/containers/podman/commit/bab4217cd16be609ac35ccf3061d1e34f787856f
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

I just ran through a manual example using the images I built yesterday and it works AFAICT - https://quay.io/repository/rhn_support_lyarwood/builder?tab=tags
$ podman image tag c4775c34cbe2 quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-arm64
$ podman image tag 4c5fdf2de08d quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-amd64
$ podman push quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-arm64
$ podman push quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-amd64
$ podman manifest create --amend quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089 quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-arm64 quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089-amd64
$ podman manifest push quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089 quay.io/rhn_support_lyarwood/builder:2305221646-ccaec9089

/cc @rmohr
/cc @brianmcarey
@rmohr would you mind reviewing this? @brianmcarey has run the updated script locally producing quay.io/kubevirt/builder:2305231351-206de78488.
The workaround actually breaks compatibility with docker as the manifest push command there doesn't accept an optional destination argument but as our automation only uses podman for now I'm not sure how important it is to support both runtimes?

/approve
/hold
does this still work for docker? If yes, feel free to remove the hold.

/unhold

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirt-builder/1661312728414818304 FWIW this is passing now, thanks all!


Dragging an assembly to an emtpy contents window does not prompt for lib folder

There used to be a warning if you tried to add a library to the root folder. It's not working, and while content does not go directly under lib either, we can still have a warning that it should go in lib\<tfm>

Might it be that dropping a library is the same as "Add Existing File" - so it's considered to be "general content" instead of "library"?
Admittedly, I'm new to NuGet, so that might not be a legitimate consideration.


AuditTo sink

When using the AuditTo the events should be written immediately and not batched. Since the splunk sink is based on PeriodicBatchingSink the events are batched according to parameters that defines batch count and interval. For now I've downloaded the code for the sink implementation and call it directly in my abstraction, so this isn't a stopping one.
This should perhaps be in the serilog-sinks-periodbatching since the behavior from AuditTo should be propagated down the the sink implementation.
Behind the scene something like SinkEmitBehavior could be introduced as passed a strategy to concerned parts to allow for honoring the desired functionality for AuditTo contract.
Edit I looked how it was done for mssql a certain sink is created for this. But the behavior for auditing spreads in different parts as well, for example PropertyValueConverter (#800), so to refactor this parts make sense.

Closing as a part of larger Serilog contrib reorg
Checkout https://github.com/serilog/serilog/issues/1627


Metric naming

Hi,
This is some late cycle feedback. I did not spot this during the PR - oops. But we were just working on alerts for the new routinator:unstable version.
I noticed this set of metrics:
routinator_repo_rejected_points{uri="https://$repo"} 0
routinator_repo_invalid_manifests{uri="https://$repo"} 0
routinator_repo_stale_manifests{uri="https://$repo"} 0
routinator_repo_missing_manifests{uri="https://$repo"} 0
routinator_repo_invalid_crls{uri="https://$repo"} 0
routinator_repo_stale_crls{uri="https://$repo"} 0
routinator_repo_stray_crls{uri="https://$repo"} 0
routinator_repo_valid_ee_certs{uri="https://$repo"} 0
routinator_repo_invalid_certs{uri="https://$repo"} 0
routinator_repo_invalid_roas{uri="https://$repo"} 0
routinator_repo_valid_gbrs{uri="https://$repo"} 0
routinator_repo_invalid_gbrs{uri="https://$repo"} 0
routinator_repo_other_objects{uri="https://$repo"} 0
routinator_repo_vrps_unsafe{uri="https://$repo"} 0
routinator_repo_vrps_filtered_locally{uri="https://$repo"} 0

It may be more idiomatic (with regards to the alerts that you rewrite) if these restructured to match this pattern:
routinator_repo_object{type="vrps", state="filtered_locally"} 0

With the current metrics our alert ends up looking like:
(routinator_repo_rejected_points{uri="$repo"} > 0)
or
(routinator_repo_invalid_manifests{uri="$repo"} > 0)
or
(routinator_repo_stale_manifests{uri="$repo"} > 0)
...

I would prefer an alerting query like
routinator_repo_object{uri="$repo",state=~".*(rejected|invalid|stale).*"}

If possible.
Whether this refactoring is still possible depends on how many alerts already exist…

And we should probably double check my proposal against the recommendations in https://prometheus.io/docs/practices/naming/

Hm, fair point. I still would want to keep VRP and object metrics separate since they very much are different things. I would also want to keep separate metrics for repositories and TALs. So, how about routinator_repo_objects{uri=, type=, state=}, routinator_repo_vrps{uri=, state=}, routinator_ta_objects{ta=, type=, state=}, and routinator_ta_vrps{ta=, state=}. In addition, keep existing metrics from 0.8 unchanged.

So we would go from:
routinator_repo_rejected_points{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_valid_manifests{uri="https://rrdp.ripe.net/notification.xml"} 14599
routinator_repo_invalid_manifests{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_stale_manifests{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_missing_manifests{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_valid_crls{uri="https://rrdp.ripe.net/notification.xml"} 14599
routinator_repo_invalid_crls{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_stale_crls{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_stray_crls{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_valid_ca_certs{uri="https://rrdp.ripe.net/notification.xml"} 14865
routinator_repo_valid_ee_certs{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_invalid_certs{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_valid_roas{uri="https://rrdp.ripe.net/notification.xml"} 22702
routinator_repo_invalid_roas{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_valid_gbrs{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_invalid_gbrs{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_other_objects{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_vrps_total{uri="https://rrdp.ripe.net/notification.xml"} 125235
routinator_repo_vrps_unsafe{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_vrps_filtered_locally{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_vrps_duplicate{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_repo_vrps_final{uri="https://rrdp.ripe.net/notification.xml"} 125235
routinator_rrdp_status{uri="https://rrdp.ripe.net/notification.xml"} 304
routinator_rrdp_notification_status{uri="https://rrdp.ripe.net/notification.xml"} 304
routinator_rrdp_payload_status{uri="https://rrdp.ripe.net/notification.xml"} 0
routinator_rrdp_duration{uri="https://rrdp.ripe.net/notification.xml"} 0.089

to
routinator_repo_objects{uri=..., type="publication_point", state="valid"} 0
// maybe: invalid, for symmetry
routinator_repo_objects{uri=..., type="publication_point", state="rejected"} 0

routinator_repo_objects{uri=..., type="manifest", state="valid"}  14599
routinator_repo_objects{uri=..., type="manifest", state="invalid"}  0
routinator_repo_objects{uri=..., type="manifest", state="stale"}  0
routinator_repo_objects{uri=..., type="manifest", state="missing"}  0

routinator_repo_objects{uri=..., type="crls", state="valid"}  14599
routinator_repo_objects{uri=..., type="crls", state="invalid"} 0
routinator_repo_objects{uri=..., type="crls", state="stale"} 0
routinator_repo_objects{uri=..., type="crls", state="stray"} 0

routinator_repo_objects{uri=..., type="certificate", state="ee"} 14865
routinator_repo_objects{uri=..., type="certificate", state="car"} 0
routinator_repo_objects{uri=..., type="certificate", state="invalid"} 0

routinator_repo_objects{uri=..., type="roa", state="valid"} 22702
routinator_repo_objects{uri=..., type="roa", state="invalid"} 0

routinator_repo_objects{uri=..., type="gbr", state="invalid"} 0
routinator_repo_objects{uri=..., type="gbr", state="valid"} 0

// other is implicitly valid?
routinator_repo_objects{uri=..., type="other", state="valid"} 0

Separating VRPs and TA from objects in repos feels logical.
As a repository operator, it would be great if I could alert on state="invalid".

Perhaps keep publication points also separate? Those are a bit different again and then routinator[_repo]_objects really is about individual objects.

Perhaps keep publication points also separate? Those are a bit different again and then routinator[_repo]_objects really is about individual objects.

Sounds good. Was considering that myself as well. The disadvantage of this is that each repository operator would need to create another alert, but that is easily solved with an example.

I think that the labels overlapping is fine. It is a nice property when the different labels of a gauge are dusjunct but sometimes the real world does not have this property..

Quoting from Prometheus best practices:

As a rule of thumb, either the sum() or the avg() over all dimensions of a given metric should be meaningful (though not necessarily useful). If it is not meaningful, split the data up into multiple metrics. For example, having the capacity of various queues in one metric is good, while mixing the capacity of a queue with the current number of elements in the queue is not.


AppendRow and fix NullCount bugs

Implements one part of 2719. I've added some discussions about adding an AppendRow API to BaseColumn.
This patch also fixes some bugs around NullCount.  Because C# Arrow is essentially immutable, it doesn't have to deal with keeping NullCount in sync on mutation. Arrow can pass in empty data and/or null buffers. DataFrame prefers to always populate both the data and null buffers, so this patch ensures that when empty data/null buffers are encounterd, they are initialized with the right default values.
Note: This is still zero copy. We only allocate and initialize when empty buffers are present.

Thanks for the initial review folks. I split out the NullCount changes(and relevant feedback) into https://github.com/dotnet/corefxlab/pull/2770. I'll put up the AppendRow changes after 2770 goes in.


reinstates lpass integration, moves inventory into a directory for tower

If we move the inventory into a directory instead of using the default hosts file, Tower can import the inventory hosts and groups without needing access to the vault password.
I hope this means that we can keep the lpass integration while also using Tower to run playbooks. Let's test to confirm.

With this change-set, in Tower we get this error:
Using /runner/project/ansible.cfg as config file
/runner/project/bin/lpass_default.sh: line 5: lpass: command not found
[WARNING]: Error in vault password file loading (default): Vault password
script /runner/project/bin/lpass_default.sh returned non-zero (127): None
/runner/project/bin/lpass_geniza.sh: line 5: lpass: command not found
[WARNING]: Error in vault password file loading (geniza): Vault password script
/runner/project/bin/lpass_geniza.sh returned non-zero (127): None
ERROR! Vault password script /runner/project/bin/lpass_geniza.sh returned non-zero (127): None

So we may still need to remove the scripts to get Tower working.

After the second commit, which comments out the ansible.cfg setting for the lpass integration, but leaves the scripts themselves, the inventory sync works again. I'll leave it to @rlskoeser to document how to use the scripts without that configuration.


RESTClient: add PageNumberPaginator

Implements #1205
This PR also extracts the common code from the OffsetPaginator into BaseNumericPaginator.

Maybe tests should parametrized because there two groups of similar tests

@sultaniman which two groups do you mean? TestOffsetPaginator & TestPageNumberPaginator?

@burnash btw. docstrings are PRO

@rudolfix sure I will create a note for myself to improve testing then.


Automate detection of Nodes CIDR for shoot clusters

How to categorize this issue?

/area networking
/kind enhancement
/priority normal
/platform equinix-metal
What would you like to be added:
Infrastructure controller should set status.nodesCIDR on Infrastructure object, based on CIDRs of created machines.
Why is this needed:
Right now creating Shoot clusters require user to create a dummy machine in selected region to force EM to assign Management CIDR for a project, so user can copy-paste it and specify it in the Shoot configuration.
@rfranzke said, that populating extensions.gardener.cloud/v1alpha1.Infrastructure.status.nodesCIDR should make Gardener automatically populate Shoot.spec.networking.nodes, so there is one manual step less for end user.

/close as it was handled with #150


Compute DX, DY logs at the basis sampling

I recently used compute_position_log() thinking it would take the deviation survey and produce a dx,xy,dz triplet for every position in the current basis.
It doesn't do that. fine and as basis is per curve maybe the does not make sense anyway.
However a nice feature would be to be able to do that interpolation in a single call and return the complete position log.

This is a good idea! Thanks Steve.


Peer reservations

I want to get this PR started now, while the work is in progress, to get more eyes and some direction. I'm going to link some internal resources for now; once they are polished, I'd like to find some way to publish them publicly.
For context, see #2938 (and JIRA 1712 if you have access).
I've written what I've deduced to be the steps for adding a command to rippled on our internal wiki. I've been following those steps below. Please comment there or here with any corrections or blind spots (especially blind spots; I don't know what I don't know).
I've left some questions in comments in the changes below. Please take a look and see if you can answer any. If you just want to skim for them, Ctrl-f for ?.
I'm having trouble figuring out how I should think about and handle "public key for a node" as a string. If there are any docs on this, please point me to them.
Similarly, our RPC "framework" seems to be immune to function abstraction. I've taken a stab at it below, but I'm not happy with it. Here's the pattern I see in the rest of the code:
Json::Value result;

auto tmpVar = tryToParse(someField);
if (notGood(tmpVar))
    return rpcError(rpcERROR_CONSTANT);

result[jss::some_field] = tmpVar;
return result;

The problem is the temporary variable combined with the early return for an error. If I try to put this in a function, I can't return both, so I end up taking an out parameter for the value. But I don't think I want to test for an empty Json::Value in the event of success, so I take that as an out parameter too and return a bool. It's all very gross to me. This kind of control flow is better suited by exceptions, in my opinion, or by an Error monad (do we have one available?). Thoughts?

Jenkins Build Summary
Built from this commit
Built at 20190515 - 17:15:35
Test Results

Build Type
Log
Result
Status

rpm
logfile
no test results, t: n/a [BAD EXIT]
FAIL :red_circle:

msvc.Debug
console
no test results, t: n/a [BAD EXIT]
FAIL :red_circle:

msvc.Debug, NINJA_BUILD=true
console
no test results, t: n/a [BAD EXIT]
FAIL :red_circle:

gcc.Release -Dassert=ON, MANUAL_TESTS=true
logfile
no test results, t: 306s [BAD EXIT]
FAIL :red_circle:

docs, TARGET=docs
logfile
1 cases, 0 failed, t: 0m1s
PASS :white_check_mark:

clang.Debug
logfile
no test results, t: 182s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dcoverage=ON, TARGET=coverage_report, SKIP_TESTS=true
logfile
no test results, t: 211s [BAD EXIT]
FAIL :red_circle:

gcc.Debug
logfile
no test results, t: 183s [BAD EXIT]
FAIL :red_circle:

msvc.Debug -Dunity=OFF
logfile
1176 cases, 0 failed, t: 1128s
PASS :white_check_mark:

clang.Debug -Dunity=OFF
logfile
1176 cases, 0 failed, t: 8m30s
PASS :white_check_mark:

msvc.Release
console
no test results, t: n/a [BAD EXIT]
FAIL :red_circle:

clang.Release -Dassert=ON
logfile
no test results, t: 294s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dunity=OFF
logfile
1176 cases, 0 failed, t: 11m31s
PASS :white_check_mark:

gcc.Debug -Dstatic=OFF
logfile
no test results, t: 183s [BAD EXIT]
FAIL :red_circle:

gcc.Release -Dassert=ON
logfile
no test results, t: 307s [BAD EXIT]
FAIL :red_circle:

gcc.Debug -Dstatic=OFF -DBUILD_SHARED_LIBS=ON
logfile
no test results, t: 184s [BAD EXIT]
FAIL :red_circle:

gcc.Debug, NINJA_BUILD=true
logfile
no test results, t: 178s [BAD EXIT]
FAIL :red_circle:

clang.Debug -Dunity=OFF -Dsan=address, PARALLEL_TESTS=false, DEBUGGER=false
logfile
1176 cases, 0 failed, t: 9m17s
PASS :white_check_mark:

clang.Debug -Dunity=OFF -Dsan=undefined, PARALLEL_TESTS=false
logfile
1176 cases, 0 failed, t: 10m13s
PASS :white_check_mark:

For context, see JIRA 1712.

:-(

@MarkusTeufelberger, obviously having the conversation on our internal wiki isn't idea. Here's the relevant content in the form of an issue: https://github.com/ripple/rippled/issues/2938

Thanks! :-)
Much clearer what this is supposed to do (without having to guess at the intentions).

@thejohnfreeman For unity builds, rcpcx1.cpp should include Reservations.cpp

You might want to consider having add and remove accept an array of objects allowing the caller to specify one or more pubkey/name pairs in a single call.

Codecov Report

Merging #2935 into develop will decrease coverage by 0.07%.
The diff coverage is 16.09%.

@@            Coverage Diff             @@
##           develop   #2935      +/-   ##
==========================================
- Coverage    69.38%   69.3%   -0.08%
==========================================
  Files          708     710       +2
  Lines        56426   56490      +64
==========================================
+ Hits         39152   39153       +1
- Misses       17274   17337      +63

Impacted Files
Coverage Δ

src/ripple/peerfinder/impl/SlotImp.cpp
51.28% <ø> (ø)
:arrow_up:

src/ripple/peerfinder/Slot.h
100% <ø> (ø)
:arrow_up:

src/ripple/app/main/Application.h
100% <ø> (ø)
:arrow_up:

src/ripple/peerfinder/PeerfinderManager.h
100% <ø> (ø)
:arrow_up:

src/ripple/overlay/impl/PeerImp.h
0% <ø> (ø)
:arrow_up:

src/ripple/peerfinder/impl/PeerfinderManager.cpp
55% <0%> (ø)
:arrow_up:

src/ripple/overlay/impl/PeerImp.cpp
0% <0%> (ø)
:arrow_up:

src/ripple/overlay/impl/OverlayImpl.cpp
28.91% <0%> (-0.05%)
:arrow_down:

src/ripple/overlay/PeerReservationTable.h
0% <0%> (ø)

src/ripple/net/impl/RPCCall.cpp
94.38% <0%> (-1.46%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5214b3c...3f5098e. Read the comment docs.

Sadly, this branch is is not currently building for me on macOS using Boost 1.70.0.  It looks like 1.70.0 lost the get_io_service() method in a couple of places.  All of the build errors I'm seeing involve the invocation of get_io_service() member functions.  The lines that I'm seeing build errors on are:
src/ripple/server/impl/PlainWSPeer.h:68
src/ripple/server/impl/PlainHTTPPeer.h:71
src/ripple/server/impl/SSLWSPeer.h:76
src/ripple/server/impl/SSLHTTPPeer.h:81
src/ripple/server/impl/Door.h:180
src/ripple/server/impl/Door.h:182
src/ripple/server/impl/Door.h:376

It's possible that a rebase atop 1.3.0-b6 will fix the issues.  It looks like the branch is currently sitting atop 1.3.0-b3


Wrap only necessary jupyter binaries

This should fix #188
The overlays were modified to only wrap jupyter-lab, jupyter-notebook and jupyter-nbclassic binaries. And it leaves untouched the other binaries that the derivations produce (in particular, jupyter-labextension for the issue mentioned above).
@kirelagin, Can you please check that this works as intended?

Yes, it seems to work as expected with this change.


Issue 211

Closes #211
Fixed bugs

ChEMBL should be an xref now
Query tests should only use mock database if TEST env is set, else use local db

CLI should allow update_merged flag to be set without using the normalizer or update_all flags

I don't think I can comment on the file directly but it looks like you renamed test_database.py to test__database.py

I don't think I can comment on the file directly but it looks like you renamed test_database.py to test__database.py

Yes. I wanted this test to run first so I just renamed it

@jsstevenson Yes. I wanted this test to run first so I just renamed it

Ah, cool. I think we can probably do something like this for any tests that we want to manually override the ordering of:
@pytest.hookimpl(hookwrapper=True)
def pytest_collection_modifyitems(items):
    # naive solution
    first_i = 0
    for i, item in enumerate(items):
        if item.originalname == 'the test that i want to go first':
            first_i = i
            break
    items.insert(0, items.pop(first_i))
    yield items


How to listen the navigation change?

I didn't found how to listen the event when navigation changed?
Thanks for the help

Hi @aalfiann ,
Actually you cannot dynamically change the navigation of the wizard. For that you should destroy it and create it with a new configuration.
Could you give me an example of the use you need?
Thanks in advance for your feedback

I mean, I just want to listen when someone change the step wizard through navigation..

Hi @aalfiann ,
Sorry for the time lapse between responses.
Two events have been added for when you navigate with the nabar.

forwardNavWizard
backwardNavWizard

You have it all documented in the Readme.me and in the Changelog.
I hope I solved your problem, anything else let me know.
Thank you very much for your help 🙌🏻.


🐛 fix deploy action

Adds a small step to copy the sample-data back where we expect it.
Broken by #109
(hard to test this one without merging it to main and seeing if the action works...)

@jdhoffa looks like this did not fix the problem... still no data on https://rmi-pacta.github.io/pacta-dashboard-svelte/


Make poetry a main dependency

Obviously, this package does not run if poetry is not installed. Should poetry be promoted from a dev-dependency to a full dependency?

Good question :)
nox-poetry has no dependency on Poetry because we only ever call it as an external command through the shell. So we don't depend on Poetry being installed in our Python environment.
Of course, you're right that we do depend on Poetry in a more general sense, and there are also undocumented version requirements. For example, Poetry < 1.0.0 definitely won't work because it has no export command.
The worry I have here is that a version mismatch with the globally installed version of Poetry could lead to problems, such as incompatible lock file formats. It will also be one more copy of Poetry to pin for a deterministic CI.
The thought of implementing nox-poetry using a stable Python API offered by Poetry is attractive though. I think poetry-core does not give us that (we need more than a PEP 517 build backend). I don't know if the upcoming plugin feature might change any of that.
So anyway, these are the reasons why I've been hesitant about declaring this dependency, but I'm very open for suggestions.

I opened #349 for the CI breakage we encountered here.

The worry I have here is that a version mismatch with the globally installed version of Poetry could lead to problems

I have heard of issues with installing poetry into a tox/nox container. It should not affect projects that use nox-poetry as a dev-dependency (almost all uses). However, the CI of nox-poetry itself might have issues. If this causes difficult CI problems with nox-poetry, then it is probably not worth it. But having a correct version of poetry brought in by pip install nox-poetry would be nice.

Opened a documentation issue for the Poetry requirements in #393 .
If nox-poetry had a dependency on Poetry, it would shadow an already installed Poetry within the Nox environment, and potentially even beyond that, depending on how the user's PATH is set up.
For now, I'm going to close this. Do let me know if you have further thoughts about this, though.


Warning message is shown in red font in powershell.

CLI version: 2.0.31
Please see the attached image.

Additionally, I'd point out that all the extra Powershell jargon is unintended and doesn't appear on CMD or bash.

I believe you are using PowerShell ISE or similar environment? This is not a CLI issue rather any 3rd party applications would have the same issue including git. You can check out this stack overflow thread for more details
For now please workaround by redirecting stderr to stdout, e.g., az login 2>&1 | % { $_.ToString() }.
In June, I plan to let login command default to authorization code flow instead device code, and that should avoid this issue completely.
//cc: @mayurid

Closing


Add ios target for using library with Compose for iOS

Add ios target to multiplatform-compose-setup for using library with Compose for iOS. It is impossible to use these dependencies in project with Compose for iOS without this target:

kviewmodel-compose
kviewmodel-odyssey

Done in https://github.com/adeo-opensource/kviewmodel--mpp/pull/18


Reintroduce simple text analysis escape without crash or box drawing issue

Notes from bugs:
From #6488

When I run this in PowerShell (7),
"`e[30;47m`u{2500} What `u{2500}`e[m"

the text comes out without antialiasing. It looks like it's being drawn with FillGeometry just like a box drawing glyph.

If I flip the colors, it comes out antialiased.

Okay, this is because we're not populating _glyphClusters when text is "simple". When we go to split the run later (we split runs for things other than text analysis!), we try to remap the glyph clusters around the split.
Inevitably, we end up falling into DrawGlyphRun with run.glyphCount = 0 because _SplitCurrentRun stomped the glyphCount because there was no glyph cluster mapping.
Somehow magically we end up doing a "get raw geometry, draw" for the entire string which very handily hides the glyph clustering bug!
This fix works but I do not believe it is correct:
diff --git a/src/renderer/dx/CustomTextLayout.cpp b/src/renderer/dx/CustomTextLayout.cpp
index d19d2d0c3..395a58224 100644
--- a/src/renderer/dx/CustomTextLayout.cpp
+++ b/src/renderer/dx/CustomTextLayout.cpp
@@ -336,6 +336,7 @@ CustomTextLayout::CustomTextLayout(gsl::not_null<IDWriteFactory1*> const factory
             for (size_t i = glyphStart; i < _glyphAdvances.size(); i++)
             {
                 _glyphAdvances.at(i) = (float)_glyphDesignUnitAdvances.at(i) / designUnitsPerEm * _format->GetFontSize() * run.fontScale;
+                _glyphClusters.at(i) = static_cast<UINT16>(i);
             }

             run.glyphCount = textLength;

I'm worried about that "magical" rendering fallthrough. With this fix, are we striking the text twice -- once as a geometry and once as a glyph run?
(I commented out the glyph run drawing, and I think the answer is no.)

From #6664

Terminal crashed. In debug configuration raised exception in "vector" include file in
function void _Verify_offset(const difference_type _Off) const at line 113
"cannot seek vector iterator after end"
Call stack:
...
problem at
src\renderer\dx\CustomTextLayout.cpp at line 867:
const auto postOriginX = std::accumulate(_glyphAdvances.begin() + run.glyphStart,
_glyphAdvances.begin() + run.glyphStart + run.glyphCount,
mutableOrigin.x);
_glyphAdvances.size(): 0x000000000000001f
run.glyphStart: 0x00000001
run.glyphCount: 0x0000ffff
Same problem in wsl2 (Ubuntu or CentOS not matter) with Midnight Commander... start ok (in user's home directory) but Terminal crashes when trying cd to /home directory with mouse double click under .. or with cd .. in command line.
@igorkuzuro

Reverted in #6665.

/cc @skyline75489
Michael's offered to bring this back, so there's no direct action required from you right now. Make sure you're on the review! :smile:


Why do errors have no stacktrace?

It's super annoying, that errors don't contain a stacktrace.
{ Error: ENOENT: no such file or directory, open '/repo_2017-09-01T1213/keywords'
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/repo_2017-09-01T1213/keywords' }

They contain absolutely no helpful information.
Is there a way to fix this?

Well, there is a memory dump when you cause a segfault in NodeGit or libgit2. It comes in the form of disassembly, though, so if you are not keen on parsing through pointer information they don't often help much. You can glean some info from them, however.
As for your concern, we generate errors directly from libgit2, so the error you see is simply the returned error code and error message from the libgit2 routine that we invoked via NodeGit. There isn't really a "stack trace" as you know it. You run one method at a time from NodeGit, so if you get an error you should be able to deduce where it is coming from with a little work.
That is all of the information we receive back from libgit2 so there isn't much else we can give you.
If you want to try and get a stack trace yourself, you can try using something like this to manually grab a trace from libgit2. Although, I have never done that so I cannot speak for its effectiveness.

I think the issue here is that it's not at all obvious where the error is coming from in a long promise chain given the (mostly) asynchronous nature of NodeGit.
If libgit2 doesn't provide a stack trace of C functions, can NodeGit not provide a stack trace of JavaScript functions?

We might be able to add some code to our generators to, at the very least, return what routine threw the error. I would need to look at the code that generates the async functions again, but I feel like that minimal solution might not be too bad to implement. What do you think of something like appending the function name to the error as some property, like err.errorFunction? I don't want to call it a stack, because it isn't. @implausible any thoughts?

Yeah that "solution" has been a verbally discussed intent for a long time, just nobody ever had time to get to it. Super useful though, most likely, even if just to aid in bug reporting or requesting help more than in direct debugging.

Maybe if I get time this weekend I will draft something up. It would be helpful, I agree.

@cjhoward92 For the function's name, what are you thinking of? The libgit2 C function like git_merge_base or the generated C++ function like Merge::base?

The name of the function you call from NodeGit. So Merge::base more likely than not.

That seems more logical to me, as we want this for debugging in JavaScript

I've submitted pull request #1393 which adds a new errorFunction property to the error with a value of Merge.base (as an example) to match the JavaScript function's name.

Merged

I'll leave it in here In case anyone has this problem.
To fix stacktraces I created this function:
export async function wrapError<T>(asyncFunc: () => T): Promise<T> {
  try {
    return await asyncFunc();
  } catch (errMsg) {
    if (errMsg && errMsg.errorFunction) {
      const err = new Error(errMsg.message);
      const stackList = err.stack.split('\n');
      err.stack = stackList.slice(0, 1).concat(stackList.slice(3)).join('\n');
      for (const k in errMsg) {
        err[k] = errMsg[k];
      }
      throw err;
    }
    throw errMsg;
  }
}

Then I wrap every nodegit call with it.
await wrapError(async () => await Repository.open(this.rootPath));

A bit hacky but this way I'm getting nice error messages:
Error: no reference found for shorthand 'refs/remotes/origin/xmain'
    at async GitScanner.pullBranch (file:///home/gg/workspaces/mieweb/wikiGDrive/src/git/GitScanner.ts:162:28)
    at async Context.<anonymous> (file:///home/gg/workspaces/mieweb/wikiGDrive/test/git/RebaseTest.ts:285:7)


Broken link

Broken link on page http://beanshell.org/developer.html to http://beanshell.org/bsh-2.0b4-src.zip
Reported by: *anonymous
Original Ticket: "beanshell/bugs/310":https://sourceforge.net/p/beanshell/bugs/310

This has been fixed now. Thanks!


refactor: merge *RequestDto with *UpdateDto

Feature Request
currently, for the Asset, ContractDefinition and PolicyDefinition endpoints we have two different objects representing the request body for creation and update.
Specifically, the UpdateDto miss the id property, but in fact it is something that could (and maybe, should) specified in the request body (other than in the request path).
Giving this, we could remove the WrapperDto classes and related transformers.
NOTE: this could be done only after the current deprecated is removed, otherwise this will be a breaking change.
Which Areas Would Be Affected?
management api
Why Is the Feature Desired?
refactor
Solution Proposal
If possible, provide a (brief!) solution proposal.

superseded by #3267


feat(plugin): trivy-aws as a plugin for Trivy

TODO

The current aws subcommand will cause conflict if we name the plugin the same. So I've named it aws-scan for now.
We need to deprecate the current aws subcommand within trivy. This will still continue to work until we remove it however. Will done in a separate PR.

Install

$ trivy plugin install ./trivy-aws.tar.gz
2024-05-18T00:06:06-06:00       INFO    Installing the plugin...        url="./trivy-aws.tar.gz"
2024-05-18T00:06:08-06:00       INFO    Loading the plugin metadata...

Run
$ AWS_REGION=<region> AWS_ACCOUNT_ID=<id> trivy aws-scan
2024/05/18 00:06:23 INFO Need to update the built-in policies
2024/05/18 00:06:23 INFO Downloading the built-in policies...

<results>

@simar7 Updated the docker version in the go-mock-aws package. https://github.com/aquasecurity/go-mock-aws/pull/5

I think we want to add this plugin to the index so people can install this plugin by trivy plugin install aws.

I think we want to add this plugin to the index so people can install this plugin by trivy plugin install aws.

Yes I was going to do just that 👍🏼

@simar7 Added!

Some packages such as cache, commands and scanner are duplicated in pkg and pkg/cloud/aws.
❯ ls pkg/cloud/aws
cache    commands scanner
❯ ls pkg/
cache       cloud       commands    concurrency errs        progress    scanner     types


Spp 9965 tac decimal output instead of float

Synopsis
Currently we convert our values to floats after completing decimal calculations. This is causing a margin of error in our results and tests. This PR focuses on the following things.

Removing the float conversion.
Introduce a decimal conversion function to common utils and use it in the totals and components method
Updating the tests to expect Decimal values.
Introducing a fine-tune for calculations that correct a set of components so that they always sum to match the associated total

Commenting and docstrings have been added where appropriate.
Checklist

[x] Documentation created/updated
[x] Tests created/updated

Thanks for the corrections @gibbardsteve they are all applied


roundtrippping content causes definition to disappear

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
1.2.4
Link to runnable example
https://stackblitz.com/edit/node-st1b3g?file=index.js
Steps to reproduce
Run
import { remark as remarFactory } from 'remark';
import { visit } from 'unist-util-visit';

const remark = remarFactory();

// clean extra attributes that make it hard to see issue
function scrubber(tree) {
  visit(tree, function (node) {
    node.value = undefined;
    node.position = undefined;
    node.spread = undefined;
    node.lang = undefined;
    node.identifier = undefined;
    node.label = undefined;
    node.title = undefined;
    node.url = undefined;
  });
}

const content = `[a]: �`;

const originalAst = remark.parse(content);
const newContent = remark.stringify(originalAst);
const newAst = remark.parse(newContent);

scrubber(originalAst);
scrubber(newAst);

console.log(JSON.stringify(originalAst, null, 4));
console.log(JSON.stringify(newAst, null, 4));

result is:
{
    "type": "root",
    "children": [
        {
            "type": "definition"
        }
    ]
}

then
{
    "type": "root",
    "children": [
        {
            "type": "paragraph",
            "children": [
                {
                    "type": "text"
                }
            ]
        }
    ]
}

and the output text is
[a]:

Expected behavior
definition content is preserved
Actual behavior
definition content disapepars
Runtime
Node v16
Package manager
npm v7
OS
Linux
Build and bundle tools
No response

also happens with
[a]

[a]: �

https://spec.commonmark.org/dingus/?text=[a]

[a]%3A %26%23xc%3B

released!


AMD64 LWJGL SUPPORT

Description
well my pc have the amd64 as the arch, and i want to program a engine in lwjgl but it says mismatch cuz i have a not compatible lwjgl support

Please make sure the JVM architecture matches the LWJGL artifact architecture. There's already support for amd64.
If you're using Maven or Gradle, the LWJGL build customizer can generate the appropriate definitions for you.

not it works good but now there is a error about funding the glfwkeycallback when i add all the libraries in gradle


Regression (false positive) with require - Unable to resolve path to module (import/no-unresolved)

We're using<EMAIL_ADDRESS>and noticed a regression with the no-unresolved rule
const Mingo = require('mingo');

Suddenly started resulting in the error:
Unable to resolve path to module 'mingo' import/no-unresolved

Not fully versed with how typescript imports work, but Mingo also uses it. My module does not.
https://github.com/kofrasa/mingo/tree/2.5.3
note we're also not using the "import" syntax here, but require.  Maybe plugin-import is mixing up "main" and "module" in package.json?
"main": "./dist/mingo.js",
 "module": "./lib/index.js",

the file at "module" is not available in this case.

Seeing the same after upgrading eslint-import-resolver-node from 0.3.4 to 0.3.5. Temp workaround in package.json:
{
  "resolutions": {
    "**/eslint-import-resolver-node": "0.3.4"
  }
}

We are seeing the same behavior on the version with ES6 imports as well.

@alasdairhurst mingo 2.5.3 indeed is broken; its "module" field points at a nonexistent file. Its "main", however, works, and this is indeed the major change in v0.3.5 of the node resolver.
While this is a correct error - the mingo maintainers would need to fix this (but probably won't, since they're up to v4 and this is a bug in v2) - it seems reasonable for the "module" field lookup, when the file does not exist, to fall back to checking the "main".

@kachkaev @plazek if this isn't the same root cause for either of you - meaning, if the package that's being warned on actually has an existing file where the "module" field points - please do file a new issue with as many details as possible.


Update slurm.sh

Codecov Report
Base: 64.68% // Head: 64.68% // No change to project coverage :thumbsup:

Coverage data is based on head (cb9a2b1) compared to base (943d182).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   64.68%   64.68%
=======================================
  Files         106      106
  Lines        2970     2970
  Branches      371      371
=======================================
  Hits         1921     1921
  Misses       1003     1003
  Partials       46       46

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

#448


Improve the content type and transformation section of the documentation

I have been struggling with serialization/deserialization for some days now, reading and rereading the documentation and debugging the source code.
Maybe it's just me but I would suggest that the documentation was cleared up a bit:

Default serialization: this closed issue discussed about the default serialization and the bad practice of having to share classes between the producer and consumer sides. The point is that that bad practice is still the default option in the framework but we can't guess it from the docs..

In my case, I send a service1.Order object:
orderProcessor.output().send(MessageBuilder.withPayload(order).build());
And the consuming service fails:
Caused by: org.springframework.core.serializer.support.SerializationFailedException: unable to deserialize [service1.Order]. Class not found.; nested exception is java.lang.ClassNotFoundException: service1.Order
	at org.springframework.cloud.stream.binder.AbstractBinder.deserializePayload(AbstractBinder.java:255) ~[spring-cloud-stream-1.1.0.RELEASE.jar:1.1.0.RELEASE]

This is my listener that expects service2.Order:
@StreamListener(OrderProcessor.INPUT)
public void handle(Order order){

I can see that the embedded headers indicate contentType=application/x-java-object;type=service1.Order so it's obvious why it's failing.
Specifying content-type: application/json in the configuration of the output channel solves this but, shouldn't it be indicated more clearly in the docs? I was kind of naive expecting a JSON conversion as the default one.
The documentation currently states:

Spring Cloud Stream attaches, by default, a contentType header to outbound messages

But IMO we can't directly guess that we will need by default to share classes between services.

6.2 section: I don't get what the columns really mean, my interpretation is:

Source payload: the object passed to the MessageBuilder.withPayload() function.
Target payload: the expected payload after the serialization, the one that will actually be transmitted (well, actually the source of the transmitted byte[]).
content-type header vs content type: the former a content type header passed while building the Message on the producer side. The latter the param that can be specified in the configuration property.

Am I right?
Also, I guess that table only applies regarding the producing side, no the consuming side.
Finally I just want to point out that this is only a suggestion based on my Spring Cloud Stream newbie experience. The platform is great and I do appreciate the clarifications and feedback I have been getting from the team.
Regards

Thanks @codependent! These are great suggestions and will help us get a better docs.


Added CSIRT/Security awesome list repo

Security related awesome list.
Contributing
(the same measurement rule as awesome-made-by-russians )
It's hard to calculate project popularity so we use stars to measure it. It's not quite fair, but it is what we have here on Github.
If you want to add a project to this list, please make sure that:

[x] The project was created by the developers born in Brazil
[x] The project can't be just a personal, experimental or sample project
[ ] The project has more than 100 stars on Github
[x] Place them in alphabetical order
[x] One repository per PR/contribution - avoid conflicts and simplify review

If they meet the requirements above, feel free to create a PR! 😁
I know that it doesn't have 100 stars, but I think security related topic is very important, so feel free to reject it (no problem at all).

Hey, thank you for your PR, but right now we are only accepting projects that has more than 100 stars.


Is it possible to add data filtering too

Is it possible to add data filtering too,

https://hc200ok.github.io/vue3-easy-data-table-doc/features/searching.html

@MABURUKI  Do you mean filtering feature here: https://hc200ok.github.io/vue3-easy-data-table-doc/features/filtering.html


General thoughts for improving performance on GKE using Pachyderm 1.8

Increasing ingress throughput:
Setup a node pool that consists of one big machine for Pachd. To ensure that Pachd is scheduled on this machine, create a node taint during pool creation time that applies to the created pool. Then, modify the Pachd deployment such that it has an appropriate toleration. Also, bump up the limit of CPUs and memory available for Pachd based on the size of the machine.
Example:
gcloud container node-pools create pachd-pool --cluster pach-cluster --scopes storage-rw --machine-type n1-standard-16 --num-nodes 1 --node-taints dedicated=pachd:NoSchedule
This command creates a node pool for the "pach-cluster" cluster with the node-taint "dedicated=pachd:NoSchedule"
The corresponding toleration in the Pachd deployment spec should be:
tolerations:
- key: "dedicated"
  operator: "Equal"
  value: "pachd"
  effect: "NoSchedule"

Increasing upload performance:
Create the kubernetes cluster with an ssd as the boot disk. Also, you can scale up the disk size to improve performance since IOPS and throughput increase with disk size in GCP.
Example:
gcloud container clusters create "pach-cluster" --scopes storage-rw --machine-type "n1-standard-4" --num-nodes=10 --disk-type "pd-ssd" --disk-size=200
This command creates a cluster called "pach-cluster" with a boot disk type of "pd-ssd" and a size of 200GB. This means that each node will have 200GB available to read and write from.
Increasing merge performance:
Increase the number of hashtrees (hashtree spec) in the pipeline spec. This number determines the number of shards for the filesystem metadata. In general this number should be lower than the number of workers (parallelism spec) and should not be increased unless merge time (the time before the job is done and after the number of processed datums + skipped datums is equal to the total datums) is too slow.

This is some brain-dump details for a future performance optimization doc that will need to be written eventually. That doc will still require additional input from Bryce at a future time.


A11y_AzureDataStudio_New deployment: SQL Server 2019 Big Data Cluster_ Screen reader: Narrator is not announcing the role of Dropdown button for the Location field.

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #BM-AzureDataStudio-Win32-Feb2022; #Azure Data Studio; #WCAG1.3.1; #Win32; #AINotInScope; #Info & Relationships; #Narrator; #NVDA;
Environment Details:
Windows Version :Windows 11 Enterprise
Application name :Azure Data studio
Repro Steps:
1.Turn on the Narrator.
2 Launch Azure Data Studio.
3. Select the Connections icon (if not already selected) from left bar.
4. Click on the ellipses '...' and select "New Deployment"
5.  In the Deployment options, select "SQL Server Big Data Cluster" card.
6. Validate the required tools are installed and the "Required Tools" table shows the status as "Installed". Without the required tools the Select button will be disabled.
7. Select the checkbox to accept the license terms and click Select
8. In the Deployment profiles screen, select an appropriate profile and click Next (you can also leave the defaults on)
9. In the Azure settings page, enter the required details and click Next
10.Verify whether that the narrator is announcing the role of dropdown or not.
Actual Result:
Narrator is not announcing the role of Dropdown button for the Location field.
Expected Result:
Narrator should announced the role of Dropdown button for the Location field.
Attachment:
Narrator Attachment:

NVDA Attachment:

As your gif shows, this is correctly being announced as "combo edit" so I'm not sure what the issue is here - this is indeed an editable combo box input so that should be correct.

@Charles-Gagnon
"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver"
Could you please tell us how to get "SQL Server Big Data Cluster in Deployment options to verify this bug

The Big Data Cluster feature has been removed, so all issues related to that functionality should be closed.

#Closed;
Since Big Data Cluster feature has been removed we are closing bug


Deal with incomplete scrapes.

A scrape might be incomplete because of a network error (connection closed, time-out, incomplete HTTP content, ...) or because a client wasn't able to collect all metrics (for whatever reason).
With https://github.com/prometheus/common/issues/14, it will be able to detect incomplete scrapes even without a network error.
At the very least, an incompletely scraped target must be marked as unhealthy, and its up metric must be 0. (This might or might not already be the case for network failures.)
Other measures to deal with incomplete scrapes need vetting:
It is easiest to reason about metrics if scrapes are atomic, i.e. either ingest all samples from a complete scrape, or none at all. Implementing an atomic scrape semantics has to be done carefully to not introduce a lot of allocation churn or unpredictable memory consumption (due to buffering until completion of a scrape is confirmed) and to not incur a significant performance cost.
On the other hand, in some situations it might be best to ingest what we can get, even if it is from an incomplete scrape. Via the up metric, alerts sensitive to incomplete scrapes can still be protected.
Note that a metric family will always be ingested as a whole from protobuf, even without a termination marker in the exchange format. The same guarantee can be given for the text format once we have a termination marker in the exchange format. However, since appending happens sequentially per time series, a rule evaluation might see some samples from a metric family already ingested but others not - even from a complete scrape.

When implemented, adding a stanza to prometheus.yml that this exporter supports termination markers would allow the co-existence with legacy exporters without triggering spurious alarms.

This is fixed in dev-2.0 AFAICS. We are reading the whole body and then trying to ingest the metrics atomically.
@fabxc @brian-brazil

The tsdb is not atomic.

Also, this wouldn't help with responses missing a Content-Length header.

Hmm it is atomic.
With regards to Content-Length, I don't think this line depends on Content-Length in any way.

It looks like this is likely not fixable with the Prometheus Text format, but OpenMetrics forces input to end with # EOF. Therefore I have opened #6505 to fix this issue.


build: Update glslang and SPIRV-Headers for next SDK

CI Vulkan-ExtensionLayer build queued with queue ID 14914.

CI Vulkan-ExtensionLayer build # 143 running.

CI Vulkan-ExtensionLayer build # 143 passed.


Add a window-specific filter for ghostty's quick terminal

Discussion: #614

Closing since it was fixed on Ghostty side. Thanks for the fix!


Testcafe v1.8.8 is not running for node 8.93

What is your Scenario?
I was running testcafe v1.8.8 for node 8.9.3
It was working well.
What is the Current behavior?
Recently I reinstalled testcafe 1.8.8 and getting this error.

But now I am getting this issue.
What is the Expected behavior?
It should open a testcafe popup but it didn't
What is your public website URL? (or attach your complete example)
There is not public.
Just for a simple test. it didn't work.
import { APP_URL } from '../lib/config';
fixture('term-condition').page(`${APP_URL}/`);

const sleep = (ms) => new Promise((resolve)=>setTimeout(resolve, ms))
test('Test', async (t) => {
  await sleep()
})

What is your TestCafe test code?
import { APP_URL } from '../lib/config';
fixture('term-condition').page(${APP_URL}/);
const sleep = (ms) => new Promise((resolve)=>setTimeout(resolve, ms))
test('Test', async (t) => {
await sleep()
Your complete configuration file
No response
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

install node 8.9.3
install testcafe 1.8.8
create a simple test.
Run the test with installed testcafe

TestCafe version
1.8.8
Node.js version
8.9.3
Command-line arguments
testcafe chrome -e tests/test.test.js
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Hello,
I could not reproduce this bug. It may be specific to your application. Please try to reproduce it on any public website.


Documentation still uses "findRow" instead of "findFirstRow"

Describe the bug
The documentation still uses findRow instead of findFirstRow in a bunch of the examples.

I have submitted a PR for this here: https://github.com/serverpod/serverpod_docs/pull/104

Thank you for the issue and the PR! Much appreciated :)


xml-crypto: update to 0.8

The comparison from 0.6.1 to 0.8.
As far as I can tell, the only functional changes are:

yaronn/xml-crypto@da0d09a8b028d5de90a39da8bca24530af399f12 (fixes yaronn/xml-crypto#70)
yaronn/xml-crypto@d1ddec98eadd78b9f74a0c1aa91223117efe966e
yaronn/xml-crypto@c6f7aaad7685502101e19f827fa5c001029b4519

And, it includes yaronn/xml-crypto@792d894ce8d4c5361650d5e873c8a7f01ae60337 which decreases the size of xml-crypto (and platforms that can't handle long paths properly...).


Rct Weekly - Crosstab of baseline activity completion

In the Recruitment Weekly Report can we please add a table for 'Completion of Baseline Activities for Verified Participants' where the overall specimens status are crosstabulated with the overall baseline survey status (e.g. all 3 sample donations and all 4 modules, but not broken down into blood vs. urine vs. saliva)? Edited to add: this should be for overall sites and then stratified by site. Example below.
Completion of Baseline Activities for Verified Participants

| Completed all 4   modules | Did not   complete all 4 modules
-- | -- | --
Completed all   3 sample donations | N(%) | N(%)
Completed some   but not all 3 sample donations | N(%) | N(%)
Did not   complete all 3 sample donations | N(%) | N(%)

Hi @mnataraj92 thanks for pointing that out, the wording is confusing. I think both should be none/0 completed. So lets update those labels to 'Did not complete any sample donations' and 'Did not complete any modules'.


the salt length in pkcs12 command did not  meet the required from NIST SP 800-132

1 The salt length could not setted by command
        if (maciter != -1)
            PKCS12_set_mac(p12, mpass, -1, NULL, 0, maciter, macmd);

2 the default length is 8 bytes
# define PKCS12_SALT_LEN 8

3 the salt shall be at least 128 bits(16 bytes) as define by  NIST SP 800-132
5.1 The Salt (S)
All or a portion of the salt shall be generated using an approved Random Bit Generator
(e.g., see [5]). The length of the randomly-generated portion of the salt shall be at least
128 bits.

Suggest:
1 update the default length to 16
2 Add the salt length option in pkcs12 command.

If this Suggestion is fine, I will raise PR to fix, Please help check.

Please note that the PKCS12 password based key derivation function for the MAC is NOT the PBKDF2 algorithm which means even with the salt length of 16 the PKCS12 files will not be compliant with NIST SP 800-132.
Unfortunately the PKCS12 standard does not allow any other password based key derivation function for the MAC.

PBKDF2 has a minimum salt length of 16 bytes.

Yes, but this is not a PBKDF2.

PBKDF2 has a minimum salt length of 16 bytes.

Yes, but this is not a PBKDF2.

Maybe this also required update to PBKDF2.
Appendix B.  Deriving Keys and IVs from Passwords and Salt
Note that this method for password privacy mode is not recommended
and is deprecated for new usage.  The procedures and algorithms
defined in PKCS #5 v2.1 [13] [22] should be used instead.
Specifically, PBES2 should be used as encryption scheme, with PBKDF2
as the key derivation function.

With PKCS12_set_mac() we are NOT talking about the password privacy mode but about the MAC! We are already using PBKDF2 with openssl-3.0 for the password privacy - i.e. the encryption of the key. However the MAC is still using the legacy key derivation because the standard does NOT provide a way to use PBKDF2 for it.

With PKCS12_set_mac() we are NOT talking about the password privacy mode but about the MAC! We are already using PBKDF2 with openssl-3.0 for the password privacy - i.e. the encryption of the key. However the MAC is still using the legacy key derivation because the standard does NOT provide a way to use PBKDF2 for it.

Got it, the security of Salt and the iteration was also refer NIST Special Publication 800-132 As per RFC7292.
##Refer:
4.  PFX PDU Syntax
The salt and (to a certain extent) the iteration count thwarts dictionary attacks against the integrity password.  See NIST Special Publication 800-132 [12] about how to choose a reasonable value for the iteration count.


Configure functional/functional-parameters to allow fp-ts lazy functions

Allow lazy functions when they appear in the AST as arguments to fp-ts's pipe/fold/chain/etc.
https://github.com/eslint-functional/eslint-plugin-functional/blob/main/docs/rules/functional-parameters.md#ignoreprefixselector and/or https://github.com/eslint-functional/eslint-plugin-functional/blob/main/docs/rules/functional-parameters.md#ignorepattern

This would help a lot here: https://github.com/eslint-functional/eslint-plugin-functional/issues/575


Optimization in CRUD tier

What type of PR is this?
kind cleanup
kind enhancement
What this PR does / why we need it:
This PR is an optimization to CRUD tier
when backend of a tier to be deleted  whether backend has no buckets is  checked
when tier is to be deleted the buckets of  backends of the tier should be empty check is added
Which issue(s) this PR fixes:

Fixes #1270
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:

@vineela1999 Please list out the optimizations in this PR and why they are needed.
Please add appropriate description and API output or logs where available.

@AmitRoushan , @kumarashit @asifdxtreme : Please review.

Note to @kumarashit  , @NajmudheenCT   :  Merge After #1273

pr#1273 is opened for the issue


[BUG]: CLI link to documentation is broken, and documentation indexing is broken

Contact Details [Optional]
No response
System Information
Zenml version 0.41.0
What happened?
Running ZenML locally and got this warning message:
The ZenML global configuration version (0.42.1) is higher than the version of ZenML currently being used (0.41.0). Read more about this issue and how to solve it here: https://docs.zenml.io/user-guide/advanced-guide/global-settings-of-zenml#version-mismatch-downgrading
Following that link https://docs.zenml.io/user-guide/advanced-guide/global-settings-of-zenml#version-mismatch-downgrading gets the following

The CLI warning isn't the bug, the documentation online is.
Reproduction steps
You can see the documentation search failure by going to 0.42.1 version online and trying to search for content:

I think the CLI issue is tied to this, some automatic documentation update is breaking?
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @patricksavill, thank you for reporting this issue. You are absolutely right, the link to the corresponding docs page seems to be broken. In case you need to take a look at the page, here is a working link to the page in question. We will fix the warning message with the next release.
Also, recently, we have had some issues regarding the search functionality of our documentation. We are currently investigating this issue and will try to fix it as soon as possible.

Hi @patricksavill, I have an update regarding this issue. Recently, we have refactored the advanced guide section of our docs and If you encounter this error with the latest release of ZenML, you should get the corrected link now.
On the other hand, we are still investigating the error in the search functionality of our documentation.


Issue while discovering local device

I am using dadb and it was not able to discover local device,
I am using following code to discover locally connected device
val dadb = Dadb.discover("localhost")
if (dadb == null) throw RuntimeException("No adb device found")
I ran into following error
java.lang.RuntimeException: No adb device found

@sunnyg522 was the device connected via USB or was it an emulator?

Closing due to lack of context. @sunnyg522 Feel free to reopen if you can provide more context


Wrong fstab content

The content of the fstab is completely wrong. Adapt it to the new btrfs layout

Fixed by #11


[Gene] Initial work on a Gene relay container

Note: Currently not exposing it outside of the storybook interface, I guess it can be used via Eigen's admin once there's an emission deploy too.

I've fixed a few places where ESLint didn't run to remove the ;, which adds some noise, I've not touched any of those files except to clean them to our standards while looking through the the app.
This updates us to Jest 15, biggest change is that it now automocks a lot more RN classes, https://github.com/facebook/jest/pull/1516 - it's not totally optimal, those mocks give warnings as you can see in the build ( or here ) as I work on this, I'll figure those out. Just learned how to do JS mocking in  general.

Will comment inline

          1 Error

:no_entry_sign:
No CHANGELOG added.

          1 Warning

:warning:
The following files do not have tests: lib/mocks/react-relay.js, lib/app_registry.js, lib/components/gene/header.js & lib/relay/routes.js

  Generated by :no_entry_sign: danger

Interesting, I assume then its using the shrink-wrap and ignoring my requests for jest 15

hah, thanks

Yeah npm shrinkwrap --help is the worst…

Go ahead and merge on 💚


Changes in file icon not diplayed until program restart

A side effect of icon caching.

Dupe of #97.


Use import() in SlashCreator#registerCommandsIn()

This mainly requires making the function async, and should also make directory listing also async.
While this is gonna be a breaking change for the method, should probably also add a filter function to allow for manual file filtering instead of having a custom extensions array option.

+1, as this will allow consumers to use this in pure ESM projects. For now, I believe the only way is to import and then register each command class manually via the SlashCreator#registerCommand() or SlashCreator#registerCommands().


aimbot not working.

before christmas update it was fine but after christmas update it cant even hit an heavy that is standing still. What is going on??????

"after christmas update"
 (latest)
there wasn't even an update yet??

nope


Https issues on goverment log in sites

Hello I have been trying now for a long time to take care of important business that requires me to go on sites like state officials sites to report issues.  And I get the sites are either " blocked " .or I get the Sasqwatch saying they can't load it or the 404 or 505 and many sites that should not say this site is not secure . Like the court house site or clerk of courts please assist if you know how to fix it ? Thank you 😊

@Christine57 This is not an IETF mailarchive issue.
You can read more about IETF here.
I suggest that you contact the relevant website administrators and your ISP (Internet Service Provider) regarding those issues.


ID to identify miners

Hello Unam, I want to identify a miner with his id to know who is the computer mining with this id, how can I do this please and where is the id located on the computer when we run the miner.exe, thanks

For that you'd usually use the IP, so check what the IP of the computer is using any website that shows it, then you can find that in the web panel.


I'm contacting Mojang's legal team

This repository is violating Mojang's intellectual property by utilizing modified code from official Minecraft Infdev. I will be contacting Mojang's legal team to inform them of this.
Thank you for your understanding.

minecraft infdev didn't have any license or contract to use it. Plus Microsoft ain't answering u. U are time waste.
Thanks for your understanding


[DOCFIX] Updated contributor numbers

@calvinjia Updated the contributor numbers in the Portuguese documentation.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12471/
Test PASSed.


How to limit checkbox selections?

I would like to limit the number of checkbox allowed.
One can only select 3 checkboxes.
http://jsfiddle.net/uo8v45qj/

It should be there I don't think so there is any option to set max selection of options. :(


test src/services/api/messages.rs

Increase test coverage by adding tests

Codecov Report

Merging #213 (6d83fd1) into main (e7193c7) will increase coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   70.93%   71.45%   +0.51%
==========================================
  Files          40       40
  Lines        2694     2694
==========================================
+ Hits         1911     1925      +14
+ Misses        783      769      -14

Impacted Files
Coverage Δ

src/services/api/messages.rs
100.00% <ø> (+100.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


rpm based installation script ?

Hello.
I want to install superadmin in order to replace pm2 on centos.
is there an rpm based installation script?
I'm really excited about this project, if there isn't.. i'll create one.
just want to know if anyone started the progress or is there any basic instructions on how to install
this on non-debian linux distro.
thank you!

Hi @kfirufk,
here is an installation script https://github.com/totaljs/superadmin/blob/master/install.sh but we use Ubuntu Server. Maybe it will work when you keep SuperAdmin requirements.
Give me a feedback.
Thank you!

BTW: Is there a problem to use Ubuntu Server?

Unfortunately I don't have ubuntu servers to test it on. We use gentoo, centos, coreos and an amazon linux distribution based on redhat

Try to modify install script and I can help you with another things.
SuperAdmin uses these commands/apps:

bash
lsb_release
lsof
ps
netstat
ifconfig
uptime
grep
awk
wc
du
cat
free
df
tail
last
tar
cp
mkdir
npm

Give me a feedback.


Override CSS properties on a per node basis

The Problem
Myself and a few others seem to want more control of the look and style of the nodes. I understand that this could open a can of worms that can easily get out of hand, so I have put a little thought into it and I think I have come up with a fairly middle of the road solution.
The Proposed Solution
I propose a syntax to configure the CSS properties for each node that would look something like this:
~~~
layout:
  name: cose
  rankDir: LR
~~~
[home] Home Hub - Communication Site
  [sales] Sales Team Hub - Communication Site
    ~~~
    style:
      background-color: green
      border-color: white
      border-radius: 50px 20px
    ~~~
    News: (home)
    Events: (home)
    [sales meetings] Sales Meetings Site - Teams Site
      Events: (sales)
      Documents: (sales)

The style configuration would be parsed to JSON and passed to the node using the cytoscape API .style() function, documentation found here. Which conveniently accepts JSON style-sheets.
For further usability I propose that the styles cascade to child nodes, for instance in the above example [home] would have the default style, while both [sales] and [sales meetings] node would have the new style applied. This would help by vastly reducing the duplication of style code.
To prevent cascading to [sales meetings] I propose the following syntax.
~~~
layout:
  name: cose
  rankDir: LR
~~~
[home] Home Hub - Communication Site
  [sales] Sales Team Hub - Communication Site
    ~~~
    style:
      background-color: green
      border-color: white
      border-radius: 50px 20px
    ~~~
    News: (home)
    Events: (home)
    [sales meetings] Sales Meetings Site - Teams Site
      ~~~
      style: default
      ~~~
      Events: (sales)
      Documents: (sales)

This will apply the default style to [sales meetings] and all of its children. Leaving [sales] the only element with a custom style.
Taking this idea one step further, I propose an additional syntax to copy styles from one node to another.
~~~
layout:
  name: cose
  rankDir: LR
~~~
[home] Home Hub - Communication Site
  ~~~
  style:
    background-color: black
    color: white
  ~~~
  [sales] Sales Team Hub - Communication Site
    ~~~
    style:
      background-color: green
      border-color: white
      border-radius: 50px 20px
    ~~~
    News: (home)
    Events: (home)
    [sales meetings] Sales Meetings Site - Teams Site
      ~~~
      style: (home)
      ~~~
      Events: (sales)
      Documents: (sales)

The above syntax would allow you to style the root node, thus all of the children, but revert back to the root style without duplicating the code. In this example [home] and [sales meeting] styles would match, leaving [sales] the only node with a differing style.
Implementation
I would love to try my hand at creating a pull request and implementing something like this myself but I don't have any experience in react (I have only ever used vue), so it will take a while to get on my feet. For now though, I look forward to any discussion that may come from this.
Thank you for the great work you are doing. What a wonderful product and what a joy it is to use!

This is an interesting syntax. https://github.com/tone-row/flowchart-fun/issues/97 has a similar goal; however, no one suggested a syntax similar to this. It's nice to have another option to consider.
I'm ramping up on this project again so I can say that this feature is definitely in the works. I'll leave this issue open until there is a working solution 👍🏻

This is an interesting syntax. #97 has a similar goal; however, no one suggested a syntax similar to this. It's nice to have another option to consider.

I tried to best match the header (YAML... I think) syntax and just apply it to an individual node. In an effort to make it feel cohesive. I think this syntax has plenty of room to be expanded beyond style, should the need for addition features arise in the future.

...changing the layout algorithm for child nodes

Ooh yeah, that's a use-case I've never even considered. I have no idea if that's supported in cytoscape off the top of my head. 🤔
Re:styling have a look at this comment. It's supported now 🎉  I opted for a different syntax, inspired by our convo in the spacing issue you opened.

Awesome! Thank you. I think having all of it in the header with selectors has the benefit of allowing the document to be cleaner and easier to read for newer users, but can make it more difficult to tell what is being styled, especially in big documents where scrolling is involved. I think there is a trad-off to be made in this case and I'll leave that up to you.
I haven't gotten a chance to play with it yet. Were you able (or are you planning to) enable cascading to child nodes?

At the moment styles don't cascade to child nodes though I can think of some potential solutions to achieve this. However you can reference multiple elements in the selector and select on other attributes, which could be useful depending on what you're working on.
https://flowchart.fun/c#H4hQGcBcE8BsFMBcoAEKC0LzwQY0gPYBOiKARAMQCGANBQEZ250AmZqaWMCynn9VXAGsA5kQIBXAHYt0uArGKliVKSPgdM2PIRLkA2rCr0cAKgC8AclwALAJawWlgLrs+UOEg7ubVAA5IKCx2VAC2BDKgIMCghH4oCABuOChSBCzwKFQcABS2DiwouACUoPpUzihxCfDJsKnpmfQc+vSV+Y5Z3ij6uO32nc18aPos-QVFQA


Update POST /activity response

The response isn't strictly needed, but the previous value was not useful in any way, as it was just the postgres serial id for the row.
The new response is the activity_id, which is the relevant id we use to track a unique activity.  That being said, the activity_id is already required to call the POST endpoint in the first place, so the caller should already have it on hand.
So, It might be just as valid to have no response (other than the 200 OK).  Thoughts?

this is on successful POST creation of an activity right? So I think returning the activity_id makes sense even if it is known in first place. But shouldn't it be a 201 response?

It could be a 201, though a 200 isn't wrong either. I'd probably just leave it for now, and we can probably have a ticket for an overall review of our error handling and messages and stuff all at once.


Integrate some of the popular checkpoints from VISSL repo as new pretrained checkpoints for OML

link: https://github.com/facebookresearch/vissl/blob/main/MODEL_ZOO.md

This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

So, let's close the issue


Do not run GitAuthTest by default

Motivation:
GitAuthTest requires you to have an access to a private repository
which is only accessible by LINE employees by default. It currently runs
when a user has an SSH key pair in ~/.ssh/id_rsa{,.pub} regardless
whether he or she has an access to the repository, leading to a test
failure.
Modifications:

The test now requires a user to set git.privateKey System property
explicitly to run the test.

Result:

Build passes anywhere.
Fixes #440

Thanks for reviewing!


Airline_anim doesn't autostarted

i used airline_anim in wlsample and the antimations didn't run automatically until i execute a command in Command mode

what is the command . you can checking  code and it can toggle by key u9

every commands. Example like :w,:NvimTreeToggle,:noh,:Telescope,etc..,but i have to run it once,then it just shows up animations

i don't know any reason  why that happen so you can try to copy that  airline_anim to your config and modify.