invalid public spreadsheet key results in crash

GET https://spreadsheets.google.com/feeds/worksheets/1lIo2calXb_GtaQ/public/basic?alt=json 400 (OK)Tabletop.xhrFetch @ tabletop.js:185Tabletop.requestData @ tabletop.js:162Tabletop.fetch @ tabletop.js:146Tabletop @ tabletop.js:124Tabletop.init @ tabletop.js:133on_click_import_button @ options.js:215v.event.dispatch @ jquery.js:2v.event.add.o.handle.u @ jquery.js:2
tabletop.js:181 SyntaxError: Unexpected token T
at Object.parse (native)
at XMLHttpRequest.Tabletop.xhrFetch.xhr.onload (chrome-extension://ggkonjneghcddicojapdfelfhilompae/js/tabletop.js:179:27)
loadSheets: function(data) {
  var i, ilen;
  var toLoad = [];
  this.foundSheetNames = [];

  for(i = 0, ilen = data.feed.entry.length; i < ilen ; i++) {

data is undefined if the spreadsheet key is invalid. I would rather it return an error or some indication that it failed rather than just crashing if the key is invalid.

It's sixty or seventy years later, but we have error handling now!


Import: Close SFTP session more aggressively

This came up looking at some server logs, and it's been updated on the server side already.  This aims to limit the API of SftpClient to a single method for opening a connection, downloading a file, and closing the connection.  In the current implementation, no callers are ever explicitly closing the connection.

selfie


[bug] Test notification does not work if there zero page watches

Version and OS
v0.47.03 docker image by linuxserver in Raspberry Pi
Is your feature request related to a problem? Please describe.
I face an issue after I deploy the app in a container.I have an error when there are no saved pages and I try to setup the mailtos  Notification setting.The python return an error on the test notification option.I have the stacktrace but not right now.I got confused at first place.
Describe the solution you'd like
I think it will be good to be included in the next release eventually, so the test notification works when there are no pages on the home page.
If this is not fixed in the latest build or nobody wants to check, I can take a look at the code if it is good to fix it.

I think I'm running into the same issue...

@dillfrescott what version is being run there?

@dillfrescott could you supply a screenshot that shows what version is on pikapods?

Strange thing is, i really feel like i've worked on a similar issue in the past, but no test was added so it probably raised its head again, but it wont happen anymore!

Sorry for the late response, its version 0.47.03


training data constructing code, please

Hello, I am very interested in your work, especially the kernel estimation and noise injection part. I couldn’t find that from your github release. Could you kindly provide us the code for training data constructing?

I found it, sorry for disturbing


Can't delete Remote SCIM Provider

Context
I'm trying to add a Remote SCIM Provider such as AWS, when I tried loading the provider configuration (or using the default configuration) after I filled the fields with the AWS SCIM Base URL and Bearer Token, I got the following error showing on the screen: "An internal error has occurred.", inspecting the page and clicking on the error on the browser's console I get the following json:
{
"detail": "not authenticated",
"schemas": [
"urn:ietf:params:scim:api:messages:2.0:Error"
],
"status": 401,
"scimType": "unauthenticated"
}

I'm not really understanding why I get such message when I'm using the admin user and the master realm. The admin user has the "scim-admin" role. Additional logs related to this error from Keycloak (bottom up):
log="2024-09-17 13:34:30,457 ERROR [de.captaingoldfish.scim.sdk.common.response.ErrorResponse] (executor-thread-10) JDBC exception executing SQL [delete from SCIM_RESOURCE_SCHEMA_MAPPING where ID in (select srtsm2_0.ID from SCIM_RESOURCE_TYPE srte1_0 join SCIM_RESOURCE_SCHEMA_MAPPING srtsm2_0 on srtsm2_0.RESOURCE_TYPE_ID=srte1_0.ID where srte1_0.SCIM_REMOTE_PROVIDER_ID=?)] [You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause] [n/a]: de.captaingoldfish.scim.sdk.common.exceptions.InternalServerException: JDBC exception executing SQL [delete from SCIM_RESOURCE_SCHEMA_MAPPING where ID in (select srtsm2_0.ID from SCIM_RESOURCE_TYPE srte1_0 join SCIM_RESOURCE_SCHEMA_MAPPING srtsm2_0 on srtsm2_0.RESOURCE_TYPE_ID=srte1_0.ID where srte1_0.SCIM_REMOTE_PROVIDER_ID=?)] [You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause] [n/a]" source=stdout
log="2024-09-17 13:34:30,457 ERROR [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (executor-thread-10) You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause" source=stdout
log="2024-09-17 13:34:30,457 WARN  [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (executor-thread-10) SQL Error: 1093, SQLState: HY000" source=stdout
log="2024-09-17 13:34:30,453 INFO  [de.captaingoldfish.scim.sdk.keycloak.administration.backend.scim.remotescimprovider.remoteprovider.RemoteProviderConfigHandler] (executor-thread-10) Deleting previous config of remote provider aws-attempt-2" source=stdout
log="2024-09-17 13:34:30,448 INFO  [de.captaingoldfish.scim.sdk.keycloak.administration.backend.scim.remotescimprovider.communication.RemoteProviderConfigLoader] (executor-thread-10) Meta Configuration from remote provider 'aws-attempt-2' was successfully loaded" source=stdout

AWS RDS MySQL is the database, for what it's worth. I'm not really sure how to interpret this error message or how to fix it. And, after this happened I tried to delete the Remote SCIM Provider and also wasn't successful. When I tried to delete the configuration I also got a 500 Internal server error, with the same json. The logs related to this attempt are pretty much the same as the ones I sent above.
The URL it tries to access when I try to load the configuration is: https://sso.mydomain.com/realms/master/scim/admin/backend/scim/v2/RemoteScimProviderConfig/a-medium-sized-token-here.
It's the same URL for the deletion endpoint.
So, to summarize, I can't load any provider configuration or the default configuration, and I also can't delete the providers.
Do you know what might be happening here? Keycloak version 25.0.5, plugin version kc-25-2.3.2. Thanks!
Screenshots

Trying to load a provider configuration:

Trying to delete a provider:

I'm wondering if this has something to do with the KC_PROXY_HEADERS variable that is currently set to xforward.

Looks like a dialect issue.
Keycloak uses hibernate to handle SQL dialects. In your case it seems that the database in use is not able to resolve the created SQL-query. The SQL queries are resolved by hibernate based on the selected SQL dialect. The question here is which SQL-dialect is currently in use and which dialect is supported by AWS RDS?
I have no experience with the AWS system and cannot support on this behalf but you can change the SQL dialect that is used by Keycloak with like this:
db=mysql
db-username=root
db-password=123456
db-url=jdbc:mysql://localhost:3306/keycloak
db-dialect=org.hibernate.dialect.MySQL8Dialect

in that case the MySQL dialect for verson 8 was explicitly selected. I would guess that in your case you will also need to find the correct dialect that should be used.
Normally the dialect is selected automatically but on some occasions this auto-detection does not work or cannot work if the dialect is no longer supported for example. I just had such a case recently with Postgres10 that is also no longer supported by the current Keycloak version.

Thanks for taking a look!
Apparently the dialect you selected there should be the same for AWS MySQL 8; I changed the driver I was using after your comment here because I realized I should use the JDBC AWS wrapper, as it provides a few other functions for AWS. With that said, my setup still didn't work. I'll keep searching to see if I find any information regarding what's the correct dialect for MySQL 8 running on AWS RDS.
Pasting here my configuration just in case someone is going through something similar.
Environment variables:
      {
        "name": "KC_DB_URL",
        "value": "jdbc:aws-wrapper:mysql://${aws_db_instance.db-sso.endpoint}/${aws_db_instance.db-sso.db_name}?characterEncoding=UTF-8&serverTimezone=UTC"
      },
      {
        "name": "KC_DB",
        "value": "mysql"
      },
      {
        "name": "KC_DB_DRIVER",
        "value": "software.amazon.jdbc.Driver"
      },

I'm using a custom Docker image so I can add some providers like the SCIM one:
FROM quay.io/keycloak/keycloak:25.0.5 AS builder

COPY SCIM-2.3.2-free.jar /opt/keycloak/providers/scim-2.3.2.jar
COPY kc-email-2fa.jar /opt/keycloak/providers/kc-email-2fa.jar
ADD --chmod=0666 https://github.com/aws/aws-advanced-jdbc-wrapper/releases/download/2.3.9/aws-advanced-jdbc-wrapper-2.3.9.jar /opt/keycloak/providers/aws-advanced-jdbc-wrapper.jar

COPY html-code-email.ftl /opt/keycloak/themes/base/email/html/code-email.ftl
COPY html-email-test.ftl /opt/keycloak/themes/base/email/html/email-test.ftl
COPY text-code-email.ftl /opt/keycloak/themes/base/email/text/code-email.ftl
COPY text-email-test.ftl /opt/keycloak/themes/base/email/text/email-test.ftl
COPY messages_en.properties /opt/keycloak/themes/base/email/messages/messages_en.properties

RUN /opt/keycloak/bin/kc.sh build -Dkc.db-dialect=org.hibernate.dialect.MySQL8Dialect

FROM quay.io/keycloak/keycloak:25.0.5
COPY --from=builder /opt/keycloak /opt/keycloak

ENTRYPOINT [ "/opt/keycloak/bin/kc.sh" ]

The only doubt I have is if I'm setting the dialect in the correct place there in the build, which I'm assuming that I am since the build didn't complain. I'll keep trying to set the correct drivers and dialect. Appreciate any thoughts/pointers!

this part is wrong:
-Dkc.db-dialect=org.hibernate.dialect.MySQL8Dialect
this would be
-Ddb-dialect=org.hibernate.dialect.MySQL8Dialect
without kc.
the KC_ is only used when using environment variables.
But I am also not sure if this will work. This depends on the underlying DBMS. Are you sure you are using a mysql 8 in AWS? I saw that AWS supports mysql 5.7 and 8. Make sure that you are really on mysql 8

Yeah, the DB was created with MySQL 8 and the specific version (by running select version();) is 8.0.39.
Just tried with the correct settings but it didn't work, unfortunately. I tried with both MySQL8Dialect and MySQLDialect.
I also tried with both AWS JDBC driver and the default MySQL one that Keycloak has. I'm gonna paste some more comprehensive logs here just in case it tells you something different.
Logs using the AWS driver but when I'm using the default the messages are very similar the only difference is the driver name that changes to mysql.c.j or something like this (bottom up):
log="2024-09-18 18:15:50,917 WARN  [io.agroal.pool] (executor-thread-2) Datasource '<default>': JDBC resources leaked: 1 ResultSet(s) and 1 Statement(s)" source=stdout
log= source=stdout
log="\t... 27 more" source=stdout
log="\tat org.hibernate.sql.exec.internal.StandardJdbcMutationExecutor.execute(StandardJdbcMutationExecutor.java:87)" source=stdout
log="\tat io.agroal.pool.wrapper.PreparedStatementWrapper.executeUpdate(PreparedStatementWrapper.java:90)" source=stdout
log="\tat software.amazon.jdbc.wrapper.PreparedStatementWrapper.executeUpdate(PreparedStatementWrapper.java:247)" source=stdout
log="\tat software.amazon.jdbc.util.WrapperUtils.executeWithPlugins(WrapperUtils.java:244)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.execute(ConnectionPluginManager.java:331)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.executeWithSubscribedPlugins(ConnectionPluginManager.java:230)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$makePluginChainFunc$4(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.executeWithTelemetry(ConnectionPluginManager.java:240)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$3(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$execute$5(ConnectionPluginManager.java:334)" source=stdout
log="\tat software.amazon.jdbc.plugin.AuroraConnectionTrackerPlugin.execute(AuroraConnectionTrackerPlugin.java:122)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$2(ConnectionPluginManager.java:268)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$makePluginChainFunc$4(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.executeWithTelemetry(ConnectionPluginManager.java:240)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$3(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$execute$5(ConnectionPluginManager.java:334)" source=stdout
log="\tat software.amazon.jdbc.plugin.failover.FailoverConnectionPlugin.execute(FailoverConnectionPlugin.java:222)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$2(ConnectionPluginManager.java:268)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$makePluginChainFunc$4(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.executeWithTelemetry(ConnectionPluginManager.java:240)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$3(ConnectionPluginManager.java:267)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$execute$5(ConnectionPluginManager.java:334)" source=stdout
log="\tat software.amazon.jdbc.plugin.efm2.HostMonitoringConnectionPlugin.execute(HostMonitoringConnectionPlugin.java:177)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$2(ConnectionPluginManager.java:268)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$makePluginChainFunc$1(ConnectionPluginManager.java:263)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.executeWithTelemetry(ConnectionPluginManager.java:240)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$null$0(ConnectionPluginManager.java:263)" source=stdout
log="\tat software.amazon.jdbc.ConnectionPluginManager.lambda$execute$5(ConnectionPluginManager.java:334)" source=stdout
log="\tat software.amazon.jdbc.plugin.DefaultConnectionPlugin.execute(DefaultConnectionPlugin.java:130)" source=stdout
log="\tat software.amazon.jdbc.wrapper.PreparedStatementWrapper.lambda$executeUpdate$17(PreparedStatementWrapper.java:253)" source=stdout
log="\tat com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdate(ClientPreparedStatement.java:988)" source=stdout
log="\tat com.mysql.cj.jdbc.ClientPreparedStatement.executeLargeUpdate(ClientPreparedStatement.java:1312)" source=stdout
log="\tat com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1003)" source=stdout
log="\tat com.mysql.cj.jdbc.ClientPreparedStatement.executeUpdateInternal(ClientPreparedStatement.java:1054)" source=stdout
log="\tat com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:912)" source=stdout
log="\tat com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)" source=stdout
log="\tat com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:130)" source=stdout
log="Caused by: java.sql.SQLException: You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause" source=stdout
log="\t... 18 more" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.endpoints.ResourceEndpointHandler.deleteResource(ResourceEndpointHandler.java:934)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.interceptor.NoopInterceptor.doAround(NoopInterceptor.java:21)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.endpoints.ResourceEndpointHandler.lambda$deleteResource$22(ResourceEndpointHandler.java:939)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.backend.scim.remotescimprovider.ScimRemoteProviderResourceHandler.deleteResource(ScimRemoteProviderResourceHandler.java:228)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.backend.scim.remotescimprovider.RemoteScimProviderToDatabaseConverter.deleteAssociatedResources(RemoteScimProviderToDatabaseConverter.java:199)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.backend.scim.remotescimprovider.RemoteScimProviderToDatabaseConverter.deleteAssociatedResourceTypes(RemoteScimProviderToDatabaseConverter.java:235)" source=stdout
log="\tat org.hibernate.query.sqm.internal.QuerySqmImpl.executeUpdate(QuerySqmImpl.java:675)" source=stdout
log="\tat org.hibernate.query.sqm.internal.QuerySqmImpl.doExecuteUpdate(QuerySqmImpl.java:704)" source=stdout
log="\tat org.hibernate.query.sqm.internal.SimpleDeleteQueryPlan.executeUpdate(SimpleDeleteQueryPlan.java:191)" source=stdout
log="\tat org.hibernate.sql.exec.internal.StandardJdbcMutationExecutor.execute(StandardJdbcMutationExecutor.java:101)" source=stdout
log="\tat org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:94)" source=stdout
log="\tat org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:108)" source=stdout
log="\tat org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:63)" source=stdout
log="Caused by: org.hibernate.exception.GenericJDBCException: JDBC exception executing SQL [delete from SCIM_RESOURCE_SCHEMA_MAPPING where ID in (select srtsm2_0.ID from SCIM_RESOURCE_TYPE srte1_0 join SCIM_RESOURCE_SCHEMA_MAPPING srtsm2_0 on srtsm2_0.RESOURCE_TYPE_ID=srte1_0.ID where srte1_0.SCIM_REMOTE_PROVIDER_ID=?)] [You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause] [n/a]" source=stdout
log="\tat java.base/java.lang.Thread.run(Thread.java:1583)" source=stdout
log="\tat io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)" source=stdout
log="\tat org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)" source=stdout
log="\tat org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)" source=stdout
log="\tat org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)" source=stdout
log="\tat org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)" source=stdout
log="\tat io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:582)" source=stdout
log="\tat org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:147)" source=stdout
log="\tat io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:141)" source=stdout
log="\tat org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.AdministrationBackendEndpoint$quarkusrestinvoker$handleScimDeleteRequest_503dd5e2ff097df80dbe24ca4e4822b62eb5dbfa.invoke(Unknown Source)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.AdministrationBackendEndpoint.handleScimDeleteRequest(AdministrationBackendEndpoint.java:124)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.administration.AdministrationBackendEndpoint.handleScimRequest(AdministrationBackendEndpoint.java:143)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.scim.AbstractEndpoint.handleScimRequest(AbstractEndpoint.java:72)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.scim.RetryStrategy.doWithRetries(RetryStrategy.java:58)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.keycloak.scim.AbstractEndpoint.lambda$handleScimRequest$2(AbstractEndpoint.java:75)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.endpoints.ResourceEndpoint.handleRequest(ResourceEndpoint.java:196)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.endpoints.ResourceEndpoint.resolveRequest(ResourceEndpoint.java:308)" source=stdout
log="\tat de.captaingoldfish.scim.sdk.server.endpoints.ResourceEndpointHandler.deleteResource(ResourceEndpointHandler.java:949)" source=stdout
log="2024-09-18 18:15:50,904 ERROR [de.captaingoldfish.scim.sdk.common.response.ErrorResponse] (executor-thread-2) JDBC exception executing SQL [delete from SCIM_RESOURCE_SCHEMA_MAPPING where ID in (select srtsm2_0.ID from SCIM_RESOURCE_TYPE srte1_0 join SCIM_RESOURCE_SCHEMA_MAPPING srtsm2_0 on srtsm2_0.RESOURCE_TYPE_ID=srte1_0.ID where srte1_0.SCIM_REMOTE_PROVIDER_ID=?)] [You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause] [n/a]: de.captaingoldfish.scim.sdk.common.exceptions.InternalServerException: JDBC exception executing SQL [delete from SCIM_RESOURCE_SCHEMA_MAPPING where ID in (select srtsm2_0.ID from SCIM_RESOURCE_TYPE srte1_0 join SCIM_RESOURCE_SCHEMA_MAPPING srtsm2_0 on srtsm2_0.RESOURCE_TYPE_ID=srte1_0.ID where srte1_0.SCIM_REMOTE_PROVIDER_ID=?)] [You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause] [n/a]" source=stdout
log="2024-09-18 18:15:50,899 ERROR [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (executor-thread-2) You can't specify target table 'SCIM_RESOURCE_SCHEMA_MAPPING' for update in FROM clause" source=stdout
log="2024-09-18 18:15:50,898 WARN  [org.hibernate.engine.jdbc.spi.SqlExceptionHelper] (executor-thread-2) SQL Error: 1093, SQLState: HY000" source=stdout

I am very sorry... I was not able to recreate the issue because I configured the wrong keycloak to mysql and therefore I got wrong test-results...
I was able to recreate it now and tried to fix it.
The SQL-dialect chosen by hibernate seems to be correct. The problem is that MySQL does not seem to support such SQL queries... I certainly did not expect that. And until know it seems you are the first one to test this with MySQL 😅
I just tried to fix it and uploaded a SNAPSHOT version for further testing: kc-25-2.3.3-SNAPSHOT-free you can download it on the website.

I'm happy to announce that both errors I had are gone with this new SNAPSHOT version. I was able to load the AWS configuration and will now configure it properly, I'll let you know if I stumble across other issues like this one.
Thank you for your assistance and fixes!

Sounds great.
Please let me know if you are finished with testing. If everything works fine I will release the fix.

I tested adding users and groups to AWS and it worked correctly so far, had no issues that weren't my own fault with this version.
Thanks again!


Ref 011 and 012 reporting allocations

Context
Writing up documentation from @nigel-lowry's session with @jamesrose on the morning of 22 Apr 21.
https://trello.com/c/HYNngevs
https://trello.com/c/lhJROn9k
Changes proposed in this pull request
Added new document and changed older document to reflect @asmega's recent PR which added a Web UI for common
allocation operations (https://github.com/DFE-Digital/get-help-with-tech/pull/1540)
Guidance to review

 Ref 012 - Enabling the delivery of remaining device allocations and router orders

 Ref 011 - Enabling the delivery of remaining device allocations and router orders


Unable to sign in with another account different to host account

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Install C# Dev Kit
Sign in with Microsoft to Use C# Dev Kit
Redirect to the Browser and Open the Host Account but not able to change to Different account.

How I do this?

/extC#

It looks like this is caused by the C# extension. Please file the issue to the C# extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

Thanks @gjsjohnmurray  for your quick response. I gonna post the issue


Attr class removed by CKeditor

Hey guys, I have a problem, CKEditor removes attr "class" from the content, even if I added allowedContent: true in my config.  All the rest of my config works fine, any idea ?
When I past code with classes, it saves it in my db with the classes, but if I want to edit the code, then classes are gone :/
CKEditor
ivory_ck_editor:
    configs:
        my_config:
            toolbar: [ ["Maximize", "-", "Source", "-", "Save"], .....]
            uiColor: "#FFFFFF"
            allowedContent: true

AFAIR, allowContext is not enought in order to keep everything as entered in the editor... There is something called ACF for (Advenced Content Filter) which maybe is the root cause of your issue...
Unfortunatelly, this is all I know related to your issue, so, I can't help more...

@jbracoupeau Does it help you?

Hi,
not really, I chose to do it another way, not using class attributes within the texts in CKEditor ;)
Thanks anyway, have a great week

Ok, so let's close it as there is nothing wrong in the bundle :)

Its not allowContent but allowedContent


Enhancement: Add a status and implement changes as the candidate goes to the process.

pub enum Status {     Offline = 0,     Online = 1,     Waiting = 2,     Queuing = 3,     Authoring = 4, }
Add a status using the enum above and implement changes as the candidate goes to the process.

Document: https://docs.google.com/spreadsheets/d/1xSMzUbkV7sl1g-G5n7-inF9vypxb5ulMLUGyh6weaX0/edit?gid=0#gid=0
This is done in this commit: https://github.com/Xode-DAO/xode-blockchain/commit/dbc26db7a80a56daca7ed2f69bb6f95ff735ff2f


[3.0] with the changes to physics_body_2d, I cant find a replacement for revert_motion on a KinematicBody2D

Operating system or device - Godot version:
Linux Ubuntu 64bit commit 36548a3fa58f00a3ef301f169f237b5641bdf635
Issue description:
cant find revert_motion on the physics_body_2d code anymore, what is the replacement to avoid the ethernal sliding on slopes?
Steps to reproduce:
test code from a couple of days ago with revert_motion() to avoid sliding on slopes, it wont work

Seems like an oversight. @reduz can it be implemented the same way how it's done in KinematicBody 3D? https://github.com/godotengine/godot/blob/master/scene/3d/physics_body.cpp#L911

@kubecz3k @reduz
Maybe this is also a good oportunity to fix a couple of lines inside physics_body_2d
inside Dictionary:
Dictionary KinematicBody2D::_move(const Vector2 &p_motion)

normal is wrong (it's saving .collision), it needs to be:
(also, please add collider_velocity to the Dictionary as follows)
   d["normal"] = col.normal;
   d["collider_velocity"] = col.collider_vel;

Thanks

You just move back your object using the travel property of the collider
var c = move_and_collide(blabla)
if (c):
     position -= c.travel


check: add support for processes

This is helpful for e.g. nMigen and CXXRTL, both of which support processes natively without requiring them to be expanded immediately after the frontend runs.

This PR currently does not enable tracking logic loops because it's not trivial to do with processes, though arguably this should be the place to track them.


docs: add CONTRIBUTING.md and DCO docs (from scope, modified for flux)

Let me know if there is anything special about the way Flux and its development works and I'll make sure to cover it.

Oh wait this branch is in a fork. Do you not have push rights to this repo?


[Feature Request] 1.16  Make Wandering Trader trades more configurable

Would you consider making the Wandering Villager trades configurable via datapack or other means?
I love the fancy loot he can have, but would like to tone down the enchants on them.

maybe™

maybe™

I'll take a maybe :D

I'll take a maybe :D

Trades are json https://github.com/Shadows-of-Fire/Apotheosis/tree/1.16/src/main/resources/data/apotheosis/wanderer_trades
(not yet released)


Edges in mesh load

This is remaining work from #38. Loading the Submesh edges from external formats is not done yet.

This functionality is not anymore within Mesh.load. Instead, facets are expanded to edges in GlobalBasis._expand_facets. There is now a crude implementation which does not work correctly in some edge cases (e.g. tetrahedron which has all nodes on the boundary.)
This should be fixed by first creating f2e type of mapping in MeshTet and then using that in GlobalBasis._expand_facets.


[manifest] Set default scheme for node driver registrar

fixes #1009
Release note:
NONE

@yerzhant For the start , this should be first raised in node-driver-registrar repo , we sync the manifests from the respective sidecars repos https://github.com/kubernetes-csi/node-driver-registrar

don't know the purpose to submit this PR
as the issue seems mention it's not related to CSI project..


Function identify() not returning correct results after pip installation

Fixed input type mismatch by casting user input to string before attempting to match countries. Renamed functions for readability.


[BUG] (code catalyst reports include cached report)

Describe the bug
Code catalyst is not ignoring node_modules/.cached which contains test-reports
node_modules/.cache/nx/3b3f674535ee4217684073f8403bf258d19c7ea4580caf69b4352ebff3ab3ec3/outputs/packages/infra/test-reports/junit.xml
Expected Behavior
Reports should not include cached reports
Current Behavior
cached reports being included it code catalyst reports
Reproduction Steps
Any build will generate this behavior
Possible Solution
No response
Additional Information/Context
No response
PDK version used
latest
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
N/A

Resolved in latest blueprint.


do not setup ownerrefs for clusterscoped/cross-namespace objects

fixes https://github.com/openshift/cluster-image-registry-operator/issues/216

/assign @dmage
i'm surprised this wasn't breaking us, setting up ownerrefs between objects that are not all within a single namespace results in very unpredictable results.

@bparees our flakes are the result of deleting the image config?
/lgtm

@bparees our flakes are the result of deleting the image config?

potentially yes, i think in at least some cases the issue is the imageconfig being deleted/updated (to remove the internal registry hostname) which causes a control-plane restart.  That shouldn't fail our tests, but if it takes long enough it can cause them to timeout.
That said, just not removing the imageconfig won't totally fix it, because even deleting the registry instance causes an update to the imageconfig (to remove the internal registry hostname) which will still restart the control plane.
I didn't create this PR as a direct fix for the flakes so much as something else I noticed while investigating them that definitely needs to be fixed.  But..fingers crossed it makes it better.

/retest

/retest

@dmage i had to add another commit to clean up how we were handling route ownership identification, ptal.

/hold
removeObsoleteRoutes also need to be fixed up to check for the owner annotation instead of the owner ref.
@dmage if you know what I'm referring to and can fix this up and merge it in a new pr in the morning that'd be great, if not I'll fix it when I get in.

@bparees I've pushed the fix to your branch.

thanks @dmage
/hold cancel

passed tests, manually merging to get us hopefully slightly less blocked.


Tsbuild watching packagejson is dependent on whether program was built in the invocation

Because these package json lookups are calculated when program is built.. If the program was already built and then you change package.json file and invoke tsbuild, the change wont be picked by ts build and it will be reported as upto date.
Also note that ts build uses the infomation from tsconfig to derive if things can be upto date. So we never watch module resolution etc. So this seems one off.
ts build also doesnt mean its incremental build so storing this info in tsbuildinfo is not enough.
Originally posted by @sheetalkamat in https://github.com/microsoft/TypeScript/pull/44935#r829461596

cc @weswigham

Yeah, definitely something we'd like to fix; unfortunately the way build mode operates just doesn't lend itself to a way to easily do this without doing exactly what build mode was intending to avoid - parsing every file for (nonrelative) specifiers and resolving them. The existing logic of pulling the data from the program cache is probably also a worthwhile optimization for non-initial builds, even if/when we can find a way to get the list for an initial build.

But it seems like somewhat of inconsistent experience.
if i did
tsc -b

some change to package.json

tsc -b => // This does not detect change..  and completes as is.. At which point only way to observe change is to do clean compile or delete tsbuildinfo.
// If we are relying here on change to source file or some such to observe the change why not in watch..

The behavior is different vs
tsc -b -w which detects the change and does the build.

The file watchers are normally polling so they have more cost associated with them.
What's the probability of only changing packge.json vs directory update (like npm install which replaces the file) if that is the case, may be directory watcher is better which is what we use for failed lookups..
Having said that i strongly believe, ts build should watch things that are derivable by config file or some heuristic files that can be observed with or without program creation

The file watchers are normally polling so they have more cost associated with them.
What's the probability of only changing packge.json vs directory update (like npm install which replaces the file) if that is the case, may be directory watcher is better which is what we use for failed lookups..

So in a monorepo setting (which is a primary usecase for build mode, if I recall correctly) only a package file changing without the whole directory structure changing is super common (about as common as people refactoring their file structure or packages I suppose). Package files are essentially simplified source files - they literally have imports in them, people change them as they please (and in ever increasing volume with modern package file features). Outside of that, most node_modules folders are usually installed once and done, and rarely updated.
Do we not use directory watchers wherever possible already? I'd have assumed a single directory watcher in the most-root location relevant to us that we then filter is what we already tried to do if the host supported it. I guess I'm not familiar with the performance characteristics of various file watching strategies, however.

Having said that i strongly believe, ts build should watch things that are derivable by config file or some heuristic files that can be observed with or without program creation

Watching every possoble package file path in a recursive directory structure is certainly an option I suppose (would be cheap and easy with a directory watcher I imagine). Certainly derivable without program data, and then the packages actually used in program creation can refine that in watch mode to a smaller set of relevant locations.


Fixed indents

Just minor fixes.

You're mixing tabs and spaces now. Also, these indent changes would really have been better in a single PR, instead of splitting them over multiple: #11 #10

Thx!


Amazon FreeRTOS on STM32

Hello,
I just wanted to ask does Amazon FreeRTOS support STM32L476RG or STM32L053?
Best regards :)

Thanks for this inquiry.  Neither board has been qualified up to now.

The NUCLEO-L476RG based upon the STM32L476RG is not on our list of qualified MCU based boards from ST, but it is a fairly close match to the STM32L4 Discovery Kit IoT Node which we do support.  Porting to this board should be possible and you can consult our porting guide for details.  See here:  (https://docs.aws.amazon.com/freertos/latest/portingguide/porting-guide.html)
The STM32L053 discovery kit is not on our list of qualified MCU based boards from ST.  Memory may be a concern in supporting Amazon FreeRTOS.  See our FAQ for details here:
https://aws.amazon.com/freertos/faqs/

Please let us know how we can assist further.

Greetings,
Thank you for your answer. I will to connect to AWS with nucleo board possessing STM32L476RG and external wifi module ESP8266. If something problematic occurs I will let you know.
Best regards

Thank you.  I will close this issue for now.  Please open a separate issue if needed.


Not working on subdomains in Linux hosting.

Trying to install it on a subfolder in Linux. But seems cannot create the user. No problem with the primary domain name.

Can you please provide server logs and details regarding your setup?


docs(guide/Running in Production): Typo fix

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update.
What is the current behavior? (You can also link to an open issue here)
Line reads 'using any 3rd part library that uses'.
What is the new behavior (if this is a feature change)?
Line now reads 'using any 3rd party library that uses'.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Changes verbiage '3rd part library' to '3rd party library'.

Thx for submitting the PR 👍
We still need a signed CLA in order to merge this :/

Aha, I see you submitted #15328. Closing this one.


Not Compatible with New version Unity Mod Manager

As title suggests, fail to compile with UMM of which version is 0.27.11 or Newer.

Cannot confirm. Was working fine after recompile. Should work now.


Upload the code?

Will this repo be populated with the code from the paper?

The repo has been updated.


Create a Social Post About Using the Screen Toolkit with Goose 🦢

Create a Social Post About Using the Screen Toolkit with Goose 🦢
Goose is your on-machine developer agent, automating engineering tasks seamlessly within your IDE or terminal. Guided by you, it can intelligently assess your project's needs, generate code modifications, and implement changes on its own.
Learn more about Goose in our documentation.
Once your content is merged, it will be featured on our Community Content site!
Example clips
https://github.com/user-attachments/assets/0217fc29-3b0b-4ab5-8a60-2dc53eb2b293
https://github.com/user-attachments/assets/5497112f-7ebb-4e73-9611-191be6d1934f
🚀 Goal
Create an engaging social media post or thread (Twitter/X, LinkedIn) sharing a tip, trick, or experience with the Screen Toolkit in Goose.
🤝 How You Can Contribute
Share things like:

A quick tip about the Screen Toolkit
A screenshot of your setup
A specific feature highlight
A debugging win
A creative use case
An integration tip

🔑 Tasks and Acceptance Criteria

[ ] Create a social media post about the Screen Toolkit
[ ] Post on your preferred social platform
[ ] Add your content to the content/content.json file
[ ] Create a pull request with your changes

Your contribution in content.json must include:
{
    "type": "social",
    "thumbnail": "./img/your-thumbnail.png",
    "title": "Your Post Title",
    "link": "https://platform.com/your-post",
    "contributor": "Your Name"
}

🌟 Resources

Goose Documentation
Goose repo
Screen Toolkit Documentation
How to use toolkits
How to create toolkits

Full episodes on Goose to understand more

Getting Started

Comment ".take" on this issue to get assigned
Fork the repository and create a new branch
Create your social post
Submit a PR with your content.json addition
Wait for review and address any feedback

Questions?
If you have any questions or need clarification, please comment on this issue!
Happy posting! 🦢
Would you like me to share the short version now?

.take


Constrain to openff-nagl ==0.3.6

Description
Some funky stuff happened with 0.3.7; I don't doubt it'll be fixed soon, this just down-constrains to a slightly older version.

Just to check Matt, what funky things were you seeing -- was it the failed pyarrow import? If so I don't think that would be necessarily resolved by downpinning nagl, but hopefully has been fixed upstream now: https://github.com/conda-forge/snappy-feedstock/issues/35#issuecomment-2043486477
Otherwise I can release 0.3.8 as I was planning to yesterday with snappy manually pinned.

I was getting a non-integer charge error where previously it was not erroring. That's the only detail I remember, let me find the log

Okay, comparing the logs here and #959, the difference is the snappy version after all. Still found a couple of improvements, though

Thanks for looking into this Matt!
I'm surprised that the NAGL failure triggered the NonIntegralMoleculeChargeError -- if I'm reading the example correctly, host should have no charges assigned (as NAGL failed) and guest should have AM1BCC charges assigned. The molecule in question (which I'm guessing is the host) seems to have a formal charge of -24, which might be why the -8 charge raised an error. I'm curious where these charges are coming from at all.
Molecule c1c2cc3cc1Oc4cc(cc(c4)Oc5cc6cc(c5)Oc7cc(cc(c7)Oc8cc9cc(c8)Oc1cc(cc(c1)Oc1cc(cc(c1)Oc1cc(cc(c1)O3)[C-]([O-])[O-])C1Oc3cc4c5cc3C(c3cc7c(cc3O1)OC9Oc1cc3c(cc1C7CC[C-]([O-])[O-])C(c1cc(c(cc1OC6O3)OC2O4)C5CC[C-]([O-])[O-])CC[C-]([O-])[O-])CC[C-]([O-])[O-])[C-]([O-])[O-])[C-]([O-])[O-])[C-]([O-])[O-] has a net charge of -8.000004101544619

I can't tell ... the differences in environments shouldn't cause any changes in AM1-BCC charge assignment, they differ almost literally only in the NAGL version that's installed, which shouldn't affect AmberTool's behavior?
Failing: https://github.com/openforcefield/openff-interchange/actions/runs/8592685125/job/23543063253
Passing: https://github.com/openforcefield/openff-interchange/actions/runs/8606724443/job/23585728482
I have a gut feeling the difference will be difficult or impossible to find, and maybe there's just some quirk associated with using something several patch versions too old. For now I think I'll leave it be, but in the future it may be better to just load the guest charges from disk and say "at this point in time with XYZ installed we assigned AM1-BCC ..."

Ah, I tracked it down because it was nagging away at me: partial charges are stored in host.sdf that the notebook was falling back on when it couldn't import NAGL.
>>> host = Molecule.from_file("host.sdf")
>>> host.partial_charges.sum()
-8.000004101544619 elementary_charge
>>> host.total_charge
-24.0 elementary_charge


AutoSize TextField

Hello,
Thanks for your AutoSizeText, it works really well.
Is it possible to have the same auto sizing feature for a TextField.
The Textfield would adjust the fontsize based on the input.
It would be really nice.

Currently that is not possible. Text and TextField are two different widgets so we would need a AutoSizeTextField. I'll leave this issue open and when other users need have the same request, I'll see what I can do 👍

Same here! Needed it always in every project ^^

I'm really unsure about this. Afaik neither iOS nor Android have an equivalent native EditText with auto sizing text. And I have never used an app where text resizes while I enter it...

Alright and what about a textfield like facebook, where you type text for a post? Facebook is shrinking the text size while typing. That's exactly what i need. I mean it's like the tutorial gifs you provide in your readme. I did a workaround for that posting issue, but autosizetext would help here a lot :)

I needed something like this too. I have an interface where all of the on the screen text is editable to certain roles and instead of switching them between Text and TextField, I instead only display TextFields with their readOnly property toggled.
Currently, I feel like switching from AutoSizeText to a TextField would also give the person editing a different impression since their text would size differently once they'd submitted.

Okay, you convinced me ^^
I don't know when I will have time to implement this.

Agreed! Would be great to have it for TextField and TextFormField!

Does anyone know if it is possible to adjust the text in the text field?

@leisim any updates?

Hi @Nolence @Ahmadre @raphFlash @leisim , I want it too so  I created one.
🎉 You might want to try this: https://github.com/lzhuor/auto_size_text_field
It's a work based off @leisim 's logic in auto_size_text. Hope we can improve auto_size_text_field together. ❤

@lzhuor thank you sooooo much ❤

@lzhuor is flutter v3 support planned?


IPMI Torture

[ ] Leverage IPMI torture test cases from op-test framework
https://github.com/open-power/op-test-framework/blob/master/testcases/IpmiTorture.py

[ ] Call from Robot -> OP-Test framework -> IPMITorture

This can do directly without the need for OpenBMC test to call it.. Since op-test itself is a open and we should just use as it is.


ECA hard fork

Most debugging is complete although it would be a good idea to run a public testnet to trial the upgrade large scale and see how the network responds.

We discovered what is likely an off by one error that is preventing PoS from working. We will investigate this issue more later today.

Reopening PR against main repository - testing has been completed successfully.


Enforce blog posts with category 'project' to contain one of the tags

  const TAGS = {
    education     : 'Mobile learning, talk to the professor, application management, and manage course schedules',
    entertainment : 'Movie updates, booking tickets, etc.',
    estate        : 'Sales, schedule appointments, customer support, etc',
    finance       : 'banking and Insurance: Account updates, OTPs, account transactions, Suspicious account, Insurance premium updates, and payment, recommend right insurance products, compare insurance premiums, password setting, and new loans, credit card updates, etc.',
    media         : 'Send digital newspapers, etc.',
    retail        : 'E-commerce expansion on SMS messaging platform; browsing, promotions, and complete transactions.',
    telecom       : 'Send Bills, complete payment, customer support, new connection/product, etc.',
    travel        : 'Browse hotels and tickets, booking, send boarding pass, etc',
  }

All post files are enforced.


Set listener when open and close intertitials in extension-admob

It would be interesting to know at what point is opened and closed interstitials (onAdOpened and onAdClosed) is closed;
They are existing => https://developers.google.com/admob/android/ad-events events
Interstitial sounds and sounds of the game are currently overlap.
It would be nice to hear these events know if i must stop/play game sounds

Done! You can not do:
AdMob.onInterstitialEvent = function(event:String){
    trace("Event: "+event);
};

Where event is one of this constant STRINGS:
	AdMob.LEAVING
	AdMob.FAILED
	AdMob.CLOSED
	AdMob.DISPLAYING
	AdMob.LOADED
	AdMob.LOADING


Support for DynamoDb v2 API

Codecov Report

Merging #230 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     85.91%   86.00%   +0.08%
- Complexity      310      315       +5
============================================
  Files            61       63       +2
  Lines          1193     1236      +43
  Branches         69       72       +3
============================================
+ Hits           1025     1063      +38
- Misses          146      147       +1
- Partials         22       26       +4

Impacted Files
Coverage Δ
Complexity Δ

...lock/provider/redis/spring1/RedisLockProvider.java
85.71% <0.00%> (-0.29%)
14.00% <0.00%> (ø%)

...edlock/provider/dynamodb/DynamoDBLockProvider.java
88.88% <0.00%> (ø)
4.00% <0.00%> (?%)

...umbs/shedlock/provider/dynamodb/DynamoDBUtils.java
87.50% <0.00%> (ø)
1.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c67228...6125287. Read the comment docs.

Excellent, thanks! Sorry I got overly ambitious with the module name and version.  I look forward to getting this released.

Released as 4.8.0


[Fix bug 1410727] Increase footer-nav width

Coverage remained the same at 90.584% when pulling 9e8316cd4a126523f72ae3d867232524f3f85165 on comzeradd:footer-nav into d95a22536e1855101d4973ca747a20a675e69e83 on mozilla:master.

Hi. I'm bug reporter. What is period to see changes?

Hi @JeanPaulLucien. Thank you for reporting this bug. The change will go live in the production server the coming week.


How to deal with association many to many ?

Hi,
With my mate, we are junior developper and we try to refactor our system with your boilerplate ! I have just a problem during my learning process, i had try to do a new Model Team (no problem for this) and now i try to do a n-n relation with pivot table TeamsUsers. I haven't find any example of this and i don't see how to make it properly.
Can i get a simple example or some link with info about this ?
Hope my sentences are clear !

firstly,  not related to this boilerplate,
what database are you using in your project, and are you also adopting sequelize from this boilerplate or are you using something else?

as that of course greatly impacts the way you will set-up your n-n relations.

Besides the setup of the pivot table and relation in your model, you need to think about your routing as well. for example,  are you going to add subroutes? or specific other routes for your relations
for example:

/api/users/:userId/teams  (GET: to list teams from a user,  POST to create a new team-user releationship...)
or will you be adding specific routes like
/api/teamsusers  [the whole crud on the relation itself]


Grabbed tracks should add to the bottom of playlists

When adding a song from search results to a playlist, it is appropriate for songs to be added to the top of that playlist.  However when grabbing a currently playing track, those should be added to the bottom of the playlist since they've obviously just been played.

I believe it already does that: http://i.imgur.com/ulbwNxK.png

As @foodbandlt said, I think it is already implemented - and I have the feeling I was implementing it :eyes:

Ok, I figured this out - it DOES add to the bottom as you show if you add it to the active playlist.  If you add it to a specific playlist, it adds it to the top instead.

Ahh, yeah.  I remember that.  I blame @DerpgonCz <3

Closing issue as expected functionality is working. Not a Bug

I really wish you guys would reconsider this.  I can't understand the logic of adding a grabbed track to the top of any playlist since it's been recently played.  And since it adds to the bottom of the playlist that's active or to the top of other playlists, it's confusingly inconsistent.

Eh, I don't see why not.  I think you're right, it would make it more consistent rather than adding confusing conditions where sometimes something happens and not other times.

Fixed in fc3182d

Ok, I hate to keep adding to this, especially if this new behavior is because I asked for it...  but I was expecting that grabbed tracks (regardless of their target playlist) would go to the bottom while searched for tracks would add to the top like they did previously.  It looks like searched for additions are also going to the bottom now?

These fixes were somehow lost and the behavior reverted to songs always being added to the top of the playlist.  Expected behavior, add to the top for searched songs, add to the bottom for grabbed songs.


mappingh thrust force into thrust setpoint

Hi guys,
I am controling a drone (px4 posix_sitl.launch) by ROS in gazbo simulation. The communication is through the mavros.
From the controller, I get the thrust force needed and I poublish to the topic ~setpoint_raw/attitude (http://wiki.ros.org/mavros#mavros.2BAC8-Plugins.setpoint_raw).
However, the the thrust force I got is in Newton but the robot in gazbo only accept a normalized thrust vale (0-1). Since it is a simulation in gazbo, I cannot do a dynamic identification...
Is there anyway for me to get the mapping the thrust force into the normalised thrust vale?
Thanks
Robin

@bresch this question is for you.

@robin-ecn I'm also facing the same issue as you were. Could you figure out how to find the mapping?


The difference between Module and Trainer load from checkpoint?

LightningModule has a function load_from_checkpoint, while the trainer also has a variable, namely resume_from_checkpoint, what's the difference between them?
By the way, I want to print the best result of the checkpoint whenever I resume from the ckpt, how can I do this job? I override the on_load_checkpoint of LightningModule, but nothing happens...

resume_from_checkpoint is private

https://pytorch-lightning.readthedocs.io/en/latest/weights_loading.html


By default, print out debug information when error was encountered

Simple code such:
await $`false`;

Throws totally unhelpful error message like
Uncaught Error: Exited with code: 1
    at CommandChild.pipedStdoutBuffer (file:///Users/krzkaczor/Workspace/spark/spark-alm-planner/node_modules/.pnpm/dax-sh@0.41.0/node_modules/dax-sh/esm/mod.js:8625:19)

(often even stack trace is not helpful).
I think the default behaviour should be to throw an error with command name that was executed and at least few final lines of stderr and stdout.
For reference, this is what bun/shell will do (output and error code both parts of the responses):

Hey @krzkaczor, hope you're doing well!
I think this is?
https://github.com/dsherret/dax/issues/150
https://github.com/dsherret/dax/issues/172

Hey David, long time no talk ;)
Yeah it's definitely related to those tickets, I decided to create another ticket because I think this behaviour should be a default.  Feel free to close this if you think the other tickets are enough.

I came up with the following to work around this. It works decently well, although you lose out on the text, json, etc. helpers on CommandBuilder since they essentially spawn internally. Would be nice if this was somehow built in to dax.
Usage:
const result = await exec($`some-command`);
const json = result.stdoutJson;

Implementation:
export async function exec(
  commandBuilder: CommandBuilder,
  captureOutput = true,
): Promise<CommandResult> {
  if (captureOutput) {
    commandBuilder = commandBuilder
      .noThrow()
      .quiet()
      .captureCombined();
  }

  const output = await commandBuilder.spawn();

  if (output.code !== 0) {
    const outputText = captureOutput
      ? output.combined
        .split('\n')
        .map((l) => `${' '.repeat(4)}${l}`)
        .join('\n')
      : '';

    throw new Error(`Failed to execute command\n${outputText}`);
  }

  return output;
}


kola: remove cmdline parameters for Tang and TPM tests

Remove kernel cmdline parameters for Tang and TPM tests
Removes rd.luks... cmdline parameters that are unnecessary once this PR in flatcar/bootengine is merged. Removing the cmdline parameters should also fix an issue with tests failing because of failing superfluous systemd-cryptsetup units during the first boot.
How to use
Run the cl.tpm.* and cl.tang.* tests.
Testing done
See the description of testing done in this PR.

[ ] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Thanks! When we backport your bootengine changes this will even work for the old Alpha, but maybe we should still bump the minimum image version for the test to be  3913.0.1 (should work for all cases, a bugfix Alpha, a new Alpha, or Beta promotion).

maybe we should still bump the minimum image version for the test to be  3913.0.1

Sounds good, I bumped the min version to 3913.0.1.


Server error messages

What changes are proposed in this pull request?
The goal of this PR is to introduce a way to communicate notifications (specifically, server errors to start with) to Sessions and the App.
An immediate benefit is users (including us) are immediately made aware of a server error. Currently, server errors occur silently, unless you are watching the server logs.
Server errors are caught via a decorator, and a notification socketio event is sent to all clients (the App, and all Sessions). The traceback is printed by Sessions. Not sure if we should include a traceback in the App.
Open to any and all suggestions! The spirit of this PR is to make it easier for us to track down bugs. And to maybe make it easier for us to help users. Or for users to help us!

How is this patch tested? If it is not, please explain why.
Forthcoming server test(s).
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[x] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

Server error notifications in the App. A traceback is also printed by connected Sessions.
What areas of FiftyOne does this PR affect?

[x] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[x] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

This is ready. Storybook should be working now, as well.

One can test this by trying to clear the sample selection. An exception is raised by the server for demonstrative purposes.

As a side note: ipython handles printing to an interactive console well, but the plain python interpreter does not (it still works, but any messages could be printed in the middle of a line that a user is editing, which could be confusing).
I think server stdout/stderr is going to a log file currently. A longer-term solution could be to direct users there, and/or display a relevant portion in the app.

As a side note: ipython handles printing to an interactive console well, but the plain python interpreter does not (it still works, but any messages could be printed in the middle of a line that a user is editing, which could be confusing).
I think server stdout/stderr is going to a log file currently. A longer-term solution could be to direct users there, and/or display a relevant portion in the app.

Good point. I'll circle back to this sooner than later.


Enhancements

Here are the tasks I proposed during the call:

[x] Remove clientID from code
[ ] Include a README.md with the installation instructions
[ ] Include localization (nls )
[ ] Try/catch the error somehow when the tile is not available

And one more ^_^:

[ ] Add a spinner after a map click while the image is loading

I've added an option to settings to configure the clientId along with short instructions how to get it.

I have updated the README and published a demo app where anyone can see how the widget works :).


Separate repository structure for Envoy core and extensions

One of the significant contributors to Envoy’s continued dependency and SLOC growth is C++ extensions.  Visualizations of this are provided in “Understanding, maintaining and securing Envoy's supply chain” EnvoyCon 2020 talk (slides, video).
Many of these extensions have limited support, maintenance and production use. Some are labeled alpha or have unknown security postures (see this list). One reason for the growth in C++ extensions is that Envoy has an unstable API internal C++ API, and upstreaming an extension ensures build maintenance as this API changes.
To structurally eliminate the dependencies implied by these extensions, we can ask that new external dependencies that are immature, not widely used or that are not in some sense “core” to Envoy, be added to either:

An independent extension repository.
A contrib/ directory tree in the Envoy repository that is distinct from the rest of the Envoy source.

This extension repository/directory will be validated for build/test by CI, but will not be covered by Envoy’s security policy or product security team. When an extension meets specified maturity criteria, it can graduate from the extension repository to the regular source tree. Proposed criteria:

The extension is stable (not alpha)
The extension’s dependencies meet all Envoy’s dependency criteria
The extension is known to be in production use by at least one known operator
The extension has active maintainers
The Envoy security team agrees that there is a compelling public interest in supporting the extension

There are also considerations and advantages around build time and binary size that might argue in favor of this approach.
A counter-argument to repository separation is that it is burdensome to work across multiple repositories for a typical git flow and we can effectively enforce extension support and dependency separation in a  single repository with the above criteria being used to eliminate extensions and dependencies from security team consideration when unmet.
We might also have different standards for API and code review in the extension repository/directory, making maintainership more scalable.
Opening this issue to track discussion on pros/cons of this approach.
CC @envoyproxy/maintainers @envoyproxy/security-team

From CI perspective, IMO it is hard to support a separate repository and that reduces the product velocity, instead we might just do another directory (e.g. contrib) with different set of bazel workspace / build rules?

This makes sense to me; it's challenging as a developer flow as well to have multiple repos. I like the idea of contrib and then having a clear path to migration to source/extensions based on specific criteria. I think by default we would not include contrib in the Envoy binaries built, but optionally using something like #7582.

Yeah +1 on contrib and we can generate 2 different images, one with contrib and one without? That should be really easy.

A couple of questions:

How do we structure things API wise? Do we have a contrib API, or place the extensions in the official Envoy API from the get go? I think there is a balance between API stability and API review overhead here.
Do we have differences in review policy in contrib? Pros are allowing faster experimentation and iteration (as you would have in a separate repo). The (very) big con is that this creates a very large step function to migration to core.

A couple of questions:

How do we structure things API wise? Do we have a contrib API, or place the extensions in the official Envoy API from the get go? I think there is a balance between API stability and API review overhead here.
Do we have differences in review policy in contrib? Pros are allowing faster experimentation and iteration (as you would have in a separate repo). The (very) big con is that this creates a very large step function to migration to core.

I'd say have contrib API in a separate directory, but in the same proto namespace so it can be moved from contrib to core without changing on-the-wire format, or really any source changes except maybe include paths.

There has been the occasional issue of extensions that envoy core ends up having a tight dependency on, and build/test of Envoy core can't happen if the relevant extension is disabled and related code deleted.  Having a separate directory for contrib and having an explicit goal of releasing with and without contrib sounds like a good step forward.  Would it also make sense to have an envoy release without extensions?  Granted, there are "extensions" like raw transport sockets and ssl transport sockets that Envoy does need in order to function.

Regarding API and extensions: Would it make sense to define config protos for extensions in that extension's extension source directory?  Nothing outside the extension needs to understand their config proto.

There has been the occasional issue of extensions that envoy core ends up having a tight dependency on, and build/test of Envoy core can't happen if the relevant extension is disabled and related code deleted. Having a separate directory for contrib and having an explicit goal of releasing with and without contrib sounds like a good step forward. Would it also make sense to have an envoy release without extensions? Granted, there are "extensions" like raw transport sockets and ssl transport sockets that Envoy does need in order to function.

We tightened the dependency enforcement and only a few extensions that Envoy core can depend on. I don't think the goal is to move all extensions to contrib, we need to define tiers of the extensions and decide which gets to the default image / additional flavored image, and supported by security team or not, etc.

seems like there is consensus not to move to a separate repo, so perhaps this point is moot...
the downside i see with that is that we would need to separate examples that required extensions, and i guess then replicate the ci for that

These are all good points. I've updated the title/top-level description to capture the contrib/ alternative.

I've put together a proposal for adding contrib/ to the Envoy repository. Please review! https://docs.google.com/document/d/1yl7GOZK1TDm_7vxQvt8UQEAu07UQFru1uEKXM6ZZg_g/edit#


KEP-4602: Crashloopbackoff alpha docs PR

Description
Docs changes for alpha changes to CrashLoopBackoff behavior per KEP-4603
Issue
kubernetes/enhancements: https://github.com/kubernetes/enhancements/issues/4603
kubernetes/kubernetes PRs:
- https://github.com/kubernetes/kubernetes/pull/128369
- https://github.com/kubernetes/kubernetes/pull/128356
- https://github.com/kubernetes/kubernetes/pull/128374
- https://github.com/kubernetes/kubernetes/pull/128559

/sig node

Hi @lauralorenz 👋
Just a reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review ahead of the "Ready for Review" deadline on Tuesday November 19th 2024 18:00 PST.
Thank you!

Hi @lauralorenz 👋
A quick reminder to get your PR ready for review before the deadline, Thursday Oct 24 at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.
Thank you!

Thanks @chanieljdan I'm on it!

Hi @nate-double-u, if I'm understanding the process correctly I think you're the PR wrangler for this week, want to make sure this is on track for lgtm/approve or if there are more/different people I'm supposed to be pinging about that. Thanks!

/cc
Hello lauralorenz
I am this week’s PR Wrangler shadow. Since Nate is busy now, I’ll take a look this PR

Hi @nate-double-u, if I'm understanding the process correctly I think you're the PR wrangler for this week, want to make sure this is on track for lgtm/approve or if there are more/different people I'm supposed to be pinging about that. Thanks!

Hi @lauralorenz, you understand the process correctly, unfortunately I had to step away last week. @Okabe-Junya has taken a look as the shadow for the week.

@Okabe-Junya ready for you again. Thanks!

/lgtm
from SIG node

tech LGTM and Docs LGTM noted above
/approve


Browse without webserver

Hi 👋
Just wondering, is it possible to "print out" to static html and browse the html via file:/// url in the browser?
Similar to mkdocs https://github.com/mkdocs/mkdocs/issues/2189
Depending on the case, this has some good advantages.

I'm afraid not. Also, the markdown rendering is done on the client (browser) side which would likely make this tricky to implement.
Out of interest, what's the usefulness of this? Is it just to negate the need for the server?

@dullage

I'm afraid not. Also, the markdown rendering is done on the client (browser) side which would likely make this tricky to implement.

I see, thanks for checking!

Out of interest, what's the usefulness of this? Is it just to negate the need for the server?

Correct, no need to spin up a web-server. Also you can sync the files with smb, iCloud or whatever and everyone would see the current htmls, without the need of network/firewall or VPN fiddling


One step at a time: see if we can convert  tags to underscores.

It seems like this should be testable both automatically and from the command-line, but I'm not quite sure how to go about doing so.  I'll poke away at it.


User Defined Rollup: Must have a value in the amount field for roll up of other currency field

While working to create a roll up of Fair Market Value from the Opportunity to the Account, I left the Amount field on the Opportunity empty (without a zero or any number, just blank). When I ran batch update, the roll up to the Account field was Zero.
Once I changed the Amount field on the Opportunity to a Zero, then the field on the Account accurately reflected the Fair Market Values of the Opportunities attached to that Account.
It seems to only be affecting currency fields and not the number fields. I'm assuming this is a bug, but perhaps it is acting as it should.
This image shows that the NOTHING  in the Opportunity amount field gives no value in the Account:

Account information:

This image shows that a Zero in the Opportunity amount field gives the value in the Account:

Account information:

Thanks, @ashimasaigal - I see what you mean. Not sure when anyone will have a chance to look at this, put I'll push it through to our backlog.

**lurch: add

Tracking W-019461

Thank you @judisohn , I was perplexed when this simple roll up wasn't working, glad it was an helpful find.

Included in beta release 3.128 (Beta 7)

Included in production release 3.128


Default config disparition ; Spells icons bug

Hello,
I have an issue with the spells icons in wand inventories, they are displayed as diamond axe with custom names and lores, so I thought it was something new in the config files, but I couldn't find the default ones. In the plugin repertory, there are all the modifiable config files (in those we create spells or wands or even items) but in the different folders (as wands, default, config) there is nothing. Could you please tell me where are the default config file gone ? And if the diamond axe bug is a functionality or a bug also ?
Best regards,
Elsopeen
Little update : I found how to restore default confgis thanks to the changelogs but the config.default.yml file still missing.

You need to use the resource pack now, or change your configs. There is info in the ResourcePack section of the wiki here to help you out.


Soda-Core Clickhouse Support

Hi guys,
Today Clickhouse it's our main DW and we would appreciate a lot if Soda-Core could integrate with it.
https://clickhouse.com/
Someone know if there is a way ?

SODA-1182

@vargacypher  We don't have direct support for it yet - but AFAIK, Clickhouse has MySQL wire protocol compatibility, maybe you can try using the soda-core-mysql package? Not sure how far you can go with it though

Oh Thk's,
I will test and give you feedback

Sorry about that, i was using the wrong port (9000 clickhouse native), when i changed to 9004 ( present in config.xml https://clickhouse.com/docs/en/interfaces/mysql/ ) it works .

@vargacypher Thank you for the feedback 🙏

Sorry about that, i was using the wrong port (9000 clickhouse native), when i changed to 9004 ( present in config.xml https://clickhouse.com/docs/en/interfaces/mysql/ ) it works .

Hey everyone 👋
I got this with 9004 port  Encountered a problem while trying to connect to mysql: 2003: Can't connect to MySQL server on 'my_host:9004' (60 Operation timed out)
Any ideas?
data_source ch_dwh:
  type: mysql
  connection:
    host: my_host
    port: '9004'
    username: my_user
    password: my_pass
    database: my_db

ClickHouse: <IP_ADDRESS>
soda-core: 3.0.16
soda-core-mysql: 3.0.16

@vijaykiran Hello, could you help here and answer, did you use Cloud version of clickhouse or it was local?


[size-report] add size-report for Thread 1.2

This PR adds size-report for Thread 1.2 features in the simplest way that does not require any change to openthread-size-report on Glitch.
Size reports for both Thread 1.1 and 1.2 are posted in the same comment with 1.2 report below 1.1 report.
This PR does not fully address style related comments in #5274, which we can leave to future enhancements.
QUESTION: should we put 1.2 report above 1.1 report instead?

Hi all @bukepo @abtink @jwhui @librasungirl ,
Any comments on this PR.
It would be really help to be able to see the code and ram size costs of 1.2 PRs
Thanks,

libopenthread-cli-ftd.a_1.2,  such naming with the version suffix seems to me a bit change.
I may prefer to add a separate version column a bit.

libopenthread-cli-ftd.a_1.2, such naming with the version suffix seems to me a bit change.
I may prefer to add a separate version column a bit.

Yes, it's a little bit strange.
But we can't have a separate version column without enhancing the openthread-size-report bot.
This PR however tries to add the Thread 1.2 size report with only OpenThread local changes.
I prefer to enhance the size report to follow whatever style we are going to agree in #5274 in a future PR.
Thoughts?


Changing the logic of allowableReuseDuration property

There are 2 issues when using allowableReuseDuration:

value 0 is not equal to disabling the property;
only one instance of LAContext is uses.

It can get trouble for example in situation when I set allowableReuseDuration and start scanning a lot of times - each next scanning will use the first result.
Could you change the logic of allowableReuseDuration?

remove optional type (from TimeInterval? to TimeInterval);
add the default value 0 to allowableReuseDuration;
remove didSet handler from allowableReuseDuration;
set the touchIDAuthenticationAllowableReuseDuration property right after LAContext creation.

For example
var allowableReuseDuration: TimeInterval = 0

// context
let context = LAContext()
context.touchIDAuthenticationAllowableReuseDuration = allowableReuseDuration

@lmvdev thanks for the feedback.
I'm not getting regarding set the allowableReuseDuration and start scanning a lot of times.
As per the documentation, this is only useful when the user has just unlocked the device with faceId or touchId and in the app we want to authenticate again.
Refer this for more details.
https://developer.apple.com/documentation/localauthentication/lacontext/1622329-touchidauthenticationallowablere
Please let me know your inputs :)
Thanks

I made the test project for you :)
Please, make follow steps:

configure face id on your device
install the application, not launch
lock the device and unlock with passcode (without your biometry)
launch the application and tap "Login" button
use your biometry to unlock the authorized part of application
move to the authorized screen (green background)
tap the "Logout" button and move to the unauthorized screen
tap the "Login" button <---- HERE you don't have to use your biometry, you can moving between authorized and unauthorized parts as much as you want

I think the last step is not correct because you unlocked the device without biometry (as I wrote in 3 step).
The reason of such behaviour I wrote in the first message of current issue.
Could you change the logic of allowableReuseDuration?
BiometricAuthenticationTest.zip

Hello
Is there news? Did you reproduce the problem?

@lmvdev I have checked your solution and you're right.
In the last step it should not use the previous value for authentication.
I much your appreciate your efforts to come up with this issue.
This can be solved in two ways:

Since you know the solution, Create a PR and be a collaborator
I will fix it and release the update later.

Let me know your thoughts :)
Thanks again
Rushi

You can fix )
How long does it take?

I will update to you soon.

@lmvdev this is fixed in the new version v3.1.3
Note: platform :ios, '12.0' is required while installing the pod.

Thank you!
I will check it later.
Why did you change minimum iOS version in pods?

It was Xcode12 standard recommendation. I also thought it's better to remove support for way older versions.


[ISSUE] Pop-up windows take up the same size as Chatterino size.

Good day, I'm sorry if this issue was already reported in the past, I've attempted to search through the reported issues but were unable to find any similar to what I'm experiencing.
When ever I, for example click on someones username when I am using chatterino, rather than the window popping up in appropriate size, the pop-up window is the same size as my chatterino window, causing it to look as following.

It overlaps the whole chatterino window, making it unable for me to see the chat, and it is also annoying to close said window as I am unable to change it in size, or close it, so I have to move it, then click on Chatterino once more to go back to the chat.
I hope this is enough information, will do my best to reply to any messages left on here.
Yours sincerely,
Brian

Did you compile your chatterino by yourself?
If so, did you check the requirements of qt being 5.10 or later?
There have been some similar issues to this because of older qt version.

Might also help to give some information on what version of chatterino, how you got it and what OS you are on

Hi, apologies I wrote a message before with the version and OS but I had to restart my browser and thus, the information got lost.
I am currently operating windows 10, 64 bit, Chatterino Version 2.0.4.
I did not compile Chatterino myself, I used the exe installer.

I have managed to resolve this issue, it was caused by my displayfusion, which was set to resize the Chatterino window once it was ran, it how ever did this every time a chatterino window was opened, resizing those. The fix for this was to edit the process to only do it once per process-name, sorry for posting a bug report here for something I caused myself, have a wonderful day!


monir 添加ui

Codecov Report

Merging #757 (fa55dc9) into feature_bk_plugin (3bbb025) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           feature_bk_plugin     #757   +/-   ##
==================================================
  Coverage              41.44%   41.44%
==================================================
  Files                    400      400
  Lines                  26811    26811
==================================================
  Hits                   11111    11111
  Misses                 15700    15700

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbb025...fa55dc9. Read the comment docs.


Fix bug in error messages printing

This should fix #36.
@justin808 Can you review it?

@justin808 Done!

I changed the strategy so that the place we put in the location of the messages is inside of the place where we polyfill on the server.


Multiple backends and parallel fetch stage

In the described scenario LinkRest will be able to mix different backends in one select (focusing on select chain for now). This means that the last two stages of select chain (CayenneQueryAssembleStage, CayenneFetchStage) should be replaced with a new ParallelFetchStage that would start and coordinate a bunch of parallel interdependent fetchers derived from the request include tree. Some of them may be getting data from Cayenne (and hence would incorporate the above two Cayenne stages). Others will be custom backends (e.g. REST). Some will depend on the results of their parent stages, some will not.
Once all results are received, they should be merged by the ParallelFetchStage into the overall object tree.

Mostly working. The approach for configuring non-standard backends is to use a @SelectRequestParsed listener to add custom Fetchers to ResourceEntity instances in the request. See FetcherBuilder for Fetcher creating helper API. Different fetchers are executed in parallel, except when child fetcher can't build its query until the parent is resolved.
We'll have more issues to address in the future:

Exposing ExecutorService and timeouts as configurable services
Parallelize PerParentFetcher loop, allowing individual fetchers to run on our ExecutorService.
Perhaps some per-entity custom fetcher API that allows to setup fetchers globally outside request scope.

Reopening... May need to be moved to a branch and redone.
Trying the approach in a real app, there are more scenarios than just fetching entity subtree per backend (e.g. the same entity can be composed from multiple backends). Also we should probably be using Java 8 CompletableFuture for managing the futures.

Reverted from master. Changes are now tracked on 166_multi_backend branch

Finally, we did it!


there was a overlapping that was happening in valid props section in CoreComponent documentation

Description
This error was occuring due to the lable which i have commented now which was placed in CoreSelect component. This error has been solved.
Image of solution

@arkaprota please close this and do the following

wrong branch name
wrong destination branch

and the solution is not perfect the label is missing from our Props Display async select component


pbTests add win playbook testing using WSL

This will allow everyone to test the playbook using WSL (the Linux CL built into modern windows).  This also allows simpler testing of the Playbooks as we can then use WSL support in GH Actions. This allows Ansible to run 'natively'.
This PR also adds the reboot tag to tasks that require a windows restart to be run as well as a modification to the shortnames script to both add a registry key (required for win 2022) and also skip creating a shortname if the original directory doesn't exist.

Checklist

[x] commit message has one of the standard prefixes
[ ] FAQ.md updated if appropriate
[x] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

I'm not in favour of adding more tests when we're failing to maintain the existing ones. The Solaris automated checks have been broken for a while and we've broken the VPC runs and not put the time into resolving them. We need to stabilise what we have before adding even more stuff for which we won't put in the time/effort to maintain.

@sxa to beg to differ? Looking at the recent runs the Solaris builds are all passing, as are the linter fixes that I merged yesterday. I don't think there is such a thing as over-testing, especially considering the VPC runs can only be triggered by maintainers

I think as a principle we should make sure the baseline is green before extending.  Sounds like in this case there's the one VPC PR to fix (which @gdams will look at today) or revert and then this should be OK to go again.

@sxa is this good to be merged now?

While I'm not going to block it (@karianna you are welcome to subject to my comments below if you wish) I'm not personally going to approve this as I don't want to take any responsibility for maintaining them once this is thrown over the wall. This really needs some of the following before it can even be considered IMHO:

An issue with a proposal as to why we want to do this with WSL
In the absence of a separate (1) some form of reasoning in the PR description
Whether we are suggesting that we gate a PR if it fails due to a specific issue with running under WSL (My feeling is no, since we do not currently support it anywhere in our processes, and most of our team does not use Windows so may struggle to debug a problem that occurs in that environment)
In light of (3), whether there will be people available to debug problems in a timely manner if and when this fails and issues are raised due to a non-obvious reason (perhaps whoever approves this will volunteer to monitor and triage failures?)

My personal view: Given the issues we have with VS2013 and VS2019 installs in the playbook at the moment, getting those to green would seem a more higher priority then adding this in (which currently excludes those installs and therefore actively masks underlying problems giving a false sense of success for a critical part of the build infrastructure)

I think we should merge this, it's adding more test coverage of the 'state of what we have today' which is always a good thing.
Definitely don't disagree that we need to clean up the remaining VS items.  I'll have a think about how we can best facilitate that (I get that its naturally in MSFT's wheelhouse).

when we're using the WSL support in GH Actions.

Did I miss the issue/plan etc. for utilising this at Adoptium? We should ideally be putting new proposals for things that will affect people in issues and relating PRs like this to them wherever possible.

We'll maintain the GH Action and work with any failing PRs

I'll hold you to that ;-)

@AdamBrousseau I've just spotted that this adds Community to some of the path checks - is this likely to impact you if you're not installing the community versions on any of your systems?

Thanks for the heads up @sxa . I think we're safe on this one since we already have a diverged win playbook for Visual Studio that has the Professional paths.

@sxa can we get this merged then please?

https://github.com/adoptium/infrastructure/pull/2232/files for me is showing a bunch of ansible lint warnings and I think we're still missing docs for this PR.
SInce we're in a release week, does this need to land for that?

Still awaiting docs.

isnt it much expensive to run windows (even WSL) in GH action than linux....

Are there any docs specific to running under WSL that we need?

I wouldn't have said so? It's just a Linux environment?

Also I assume that since this is adding in a gating GitHub check on each PR that MSFT are taking responsibility for any problems that occur in this environment and will respond to any problems specific to WSL in that check?

This PR check is run against Windows playbook changes only so won't gate Linux playbooks etc. This change has come from myself (an Adoptium contributor). I'm happy to monitor changes etc but am not suggesting that MSFT should in any way take responsibility for this pull request or subsequent breaking changes.

isnt it much expensive to run windows (even WSL) in GH action than linux....

@zdtsw this action is only run against Windows changes (not Linux). There is no associated cost with running GitHub actions other than the fact that you are burning through Actions minutes (of which we have extra provided by MSFT and have never come close to running out of). Windows uses a 2x multiplier as opposed to Linux but this is no way near the 10x multiplier for macOS (see https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#minute-multipliers)

Are there any docs specific to running under WSL that we need?
I wouldn't have said so? It's just a Linux environment?

If there's no difference running in WSL I'm happy with that answer.

This PR check is run against Windows playbook changes only so won't gate Linux playbooks etc. This change has come from myself (an Adoptium contributor). I'm happy to monitor changes etc but am not suggesting that MSFT should in any way take responsibility for this pull request or subsequent breaking changes.

I assume the intention of putting it in GHA is to make it run on each PR and therefore gate (block) merging if a failure occurs. I don't think any other github checks are on things we'd definitely block on so the question is - if a change fails only on WSL will the onus be on the PR submitter to fix any such failures, or will you respond to them?

@sxa I'm happy to help maintain the jobs, if the WSL element of things break then I'll work to fix it


Lifecycle methods are overridden

There is three methods that seem to act as lifecycle methods on the components: onRender, onUpdate and onRemove.
But the Monkberry constructor is setting them to null, and then the component constructor may set them to a function, like when you use a directive.
Because of that, you can't just declare an onRender method that call super.onRender() in your component class. It will get overridden. Right now if you want to do something on onRender or onRemove, you have to keep the ref of the current method within the constructor, assign a new method that do your stuff and also call the previous method.
It would be great if we could just create the lifecycle methods within our class and just call the super one if needed.

Yes, it's true, this methods using for internal purposes in monkberry. It's not like lifecycle methods.
But i think we can add lifecycle events with more native naming and rename onRender to something like __onRender__.

Looks like there was a PR #31  for this but it was never merged. I'm trying to use monkberry for a project (and love it) but i really need lifecycle methods. Any chance you could bump the version and add this feature?

Sorry, no, now main main goal is to finish next version.

Fair enough, is there any way I can help? If I push this feature to the next branch can you instruct me on how to use the new branch in my project :) ?


Pasting specially crafted HTML with inner \n  in a slate block using FF inserts spaces at the beginning and (apparently) randomly in the middle of the text

Describe the bug
If the copied HTML is crafted in a way that it contains \n on it, pasting in a slate block using FF inserts soft spaces at the beginning and (apparently) randomly in the middle of the text.
To Reproduce
Steps to reproduce the behavior:

Using FF
Use https://www.dlr.de/content/de/artikel/news/2022/03/20220831_intelligentes-lademanagement.html
Copy the text
Paste in a slate block

See the initial spaces in each block, also some weird double ones in the middle.

Expected behavior
The pasted content is clear of glitches.

Browsers are nasty.
Here's an example, you can see that a new line in a headline is visually rendered as a space:


[Feature] Create chip tool command to verify if a device is commissioned

Feature description
Create a chip tool command to verify if a device with a specific node_id is commissioned or not.
Command suggestion:
$ ./chip-tool pairing is-commissioned <node_id>

Returns true if the device is already commissioned in the fabric and false otherwise.
Suggestion for the return:
CHIP:TOO:   Is commissioned: true

Platform
all
Platform Version(s)
No response
Anything else?
No response

@ccruzagralopes How would chip-tool determine this, exactly?  That is, what definition of "commissioned" do you want to use here?  Just "operational advertisement is present"?  Or "can set up CASE session"?  Or something else?

@ccruzagralopes How would chip-tool determine this, exactly? That is, what definition of "commissioned" do you want to use here? Just "operational advertisement is present"? Or "can set up CASE session"? Or something else?

I want to know if the node already has a CASE session or not

If chip-tool is not in interactive mode, the answer is "it does not".
If chip-tool is in interactive mode, you can know whether chip-tool has a session id for the node, but you can't know whether the node knows about that session.  That is, sending messages on that session can still fail.  But we could expose API for this, yes.  Would you want to include a sessions marked "defunct" in this check, or just active ones?
And how would this get used in practice?

This would get used in Test Harness. We'd like to commission the device before running a test case, but only if it's not already commissioned. So we need this check first.
I'm not familiar with interactive mode. I don't believe that's used in Test Harness. Are you saying that if we don't use interactive mode, then it's not possible to know about the CASE session?

Someone just told me that I can use the command chip-tool delay wait-for-commissionee <nodeID> for what I need, so I'm closing this issue. Thank you

Ah.  That command establishes a CASE session to the node, so a different definition of "commissioned" from the above....


Why is this not zip-safe

Why did you declare your package as not-zip-safe?
cheers
hellerbarde

Thanks for pointing it out. I just did "copy & paste" from a Python packaging tutorial and known nothing about it.
Now I read the documentation and I think whether zip-safe or not is not a big issue for such a small project (it just a standalone script), so, I decided to simply omit it in next version.


Directly includes core-js in @babel/preset-env

Directly includes core-js in @babel/preset-env as per recommendations from https://babeljs.io/docs/en/babel-preset-env#usebuiltins
Unbreaks the component for React setups without global core-js. Fixes #64.

Hi @NadavShaar! What's your decision on the core-js babel issue?

Hi... I'm exploring other libraries to replace react sortable hoc to
resolve a few issues related to it and will update soon.
On Mon, 12 Apr 2021, 08:08 irisjae, @.***> wrote:

Hi @NadavShaar https://github.com/NadavShaar! What's your decision on
the core-js babel issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NadavShaar/react-grid-table/pull/65#issuecomment-817483790,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5ITFWDWEGGFK3MZ4ACL7LTIJ56RANCNFSM4Y7RQWMQ
.

@NadavShaar Sounds good! Looking forward to your work. May I once again express my appreciation for your of your fine work!


RC: Open edX studio doesn't load due to a theme error

Steps to Reproduce

Go to https://studio-qa.mitxonline.mit.edu/

Expected Behavior

Open edX studio should load

Actual Behavior

Internal Server Error

Stacktrace
@blarghmatey diagnosed this as a theme error with the latest release of edX:
Traceback (most recent call last):
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/lookup.py", line 241, in get_template
    return self._check(uri, self._collection[uri])
KeyError: 'mitxonline/cms/templates/widgets/footer.html'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/sentry_sdk/integrations/django/middleware.py", line 175, in __call__
    return f(*args, **kwargs)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/utils/deprecation.py", line 117, in __call__
    response = response or self.get_response(request)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 49, in inner
    response = response_for_exception(request, exc)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 114, in response_for_exception
    response = handle_uncaught_exception(request, get_resolver(get_urlconf()), sys.exc_info())
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/django/core/handlers/exception.py", line 153, in handle_uncaught_exception
    return callback(request)
  File "/edx/app/edxapp/edx-platform/common/djangoapps/util/views.py", line 95, in wrapper
    return func(request, *args, **kwargs)
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/error.py", line 26, in inner
    return func(request, *args, **kwargs)
  File "/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/views/error.py", line 50, in render_500
    return HttpResponseServerError(render_to_string('500.html', {}, request=request))
  File "/edx/app/edxapp/edx-platform/common/djangoapps/edxmako/shortcuts.py", line 178, in render_to_string
    return template.render(dictionary, request)
  File "/edx/app/edxapp/edx-platform/common/djangoapps/edxmako/template.py", line 82, in render
    return self.mako_template.render_unicode(**context_dictionary)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/template.py", line 444, in render_unicode
    return runtime._render(
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/runtime.py", line 874, in _render
    _render_context(
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/runtime.py", line 916, in _render_context
    _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/runtime.py", line 943, in _exec_template
    callable_(context, *args, **kwargs)
  File "/tmp/mako_cms/f13f950116d269293ac438cd8e2ded58/base.html.py", line 279, in render_body
    runtime._include_file(context, 'widgets/footer.html', _template_uri)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/runtime.py", line 780, in _include_file
    template = _lookup_template(context, uri, calling_uri)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/runtime.py", line 837, in _lookup_template
    return lookup.get_template(uri)
  File "/edx/app/edxapp/edx-platform/common/djangoapps/edxmako/paths.py", line 102, in get_template
    template = super().get_template(get_template_path_with_theme(uri))
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/lookup.py", line 252, in get_template
    return self._load(srcfile, uri)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/lookup.py", line 313, in _load
    self._collection[uri] = template = Template(
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/template.py", line 317, in __init__
    module = self._compile_from_file(path, filename)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/template.py", line 381, in _compile_from_file
    module = compat.load_module(self.module_id, path)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/mako/compat.py", line 53, in load_module
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/tmp/mako_cms/f13f950116d269293ac438cd8e2ded58/mitxonline/cms/templates/widgets/footer.html.py", line 22, in <module>
    from cms.djangoapps.contentstore.config.waffle import waffle, ENABLE_ACCESSIBILITY_POLICY_PAGE
ImportError: cannot import name 'waffle' from 'cms.djangoapps.contentstore.config.waffle' (/edx/app/edxapp/edx-platform/cms/djangoapps/contentstore/config/waffle.py)

The theme repo: https://github.com/mitodl/mitxonline-theme
Screenshot or Screencast

I'm pretty sure this is working now.

I'm pretty sure this is working now.

Correct! Thanks for closing this issue.