Subscribers are not notified for certain PGNs

In the sample code in README.rst, we see a statement here that says

To simply receive all passing (public) messages on the bus you can subscribe to the ECU object.

But it turns out that this is not true.  Certain PGNs will be diverted elsewhere and not make it as far as the subscribers, as can be seen here.  The following items will not get to the subscribers:

ParameterGroupNumber.PGN.ADDRESSCLAIM
ParameterGroupNumber.PGN.REQUEST
ParameterGroupNumber.PGN.TP_CM
ParameterGroupNumber.PGN.DATATRANSFER

If we want it to be a true statement that all passing message will be received by subscribers, then I think that we must remove the else: on line 521 of j1939_21.py and unindent the following lines.

Here is a way to use subclassing in order to receive notifications of (a selection of) the missing PGNs without changing any python-can-j1939 code.
It's a bit icky, but it might be useful to someone, depending on what practical situation they might be in.  Two of the j1939 classes are subclassed in this workaround, ElectronicControlUnit and J1939_21.  These imports are needed:
from j1939 import ElectronicControlUnit
from j1939.parameter_group_number import ParameterGroupNumber
from j1939.message_id import MessageId
from j1939.j1939_21 import J1939_21

Here is a customized J1939_21 class that can notify any of the "missing" PGNs after they have had their usual processing.  When creating an instance of this class, pass in a notify_these_also named argument that lists whichever missing PGNs are wanted:
class CustomJ1939_21(J1939_21):

    def __init__(self, *args, **kwargs):
        self.__notifyTheseAlso = kwargs.get("notify_these_also")
        self.__notifyCallback = args[0] # send_message
        super().__init__(*args)

    def notify(self, can_id, data, timestamp):
        super().notify(can_id, data, timestamp)
        # now notify any received messages that we're interested in, but which the regular J1939_21 class omits:
        mid = MessageId(can_id=can_id)
        pgn = ParameterGroupNumber()
        pgn.from_message_id(mid)
        pgn_value = pgn.value & 0x1FF00
        if pgn_value in self.__notifyTheseAlso:
            dest_address = pgn.pdu_specific
            self.__notifyCallback(mid.priority, pgn_value, mid.source_address, dest_address, timestamp, data)

The below change is circumventing the way that the ElectronicControlUnit constructor wants to create either a J1939_21 or a J1939_22 instance.  In order to substitute the above subclass of J1939_21 instead, we are needing to get rid of the self.j1939_dll (data link layer) object that got created during ElectronicControlUnit construction, and replace it with our custom one - and we want to achieve this before the async job starts looping:
class CustomECU(ElectronicControlUnit):

    def __init__(self, **kwargs):
        self.max_cmdt_packets = kwargs.get('max_cmdt_packets', 1)
        self.minimum_tp_rts_cts_dt_interval = kwargs.get('minimum_tp_rts_cts_dt_interval', None)
        self.minimum_tp_bam_dt_interval = kwargs.get('minimum_tp_bam_dt_interval', None)
        super().__init__(**kwargs)

    def _async_job_thread(self):
        del self.j1939_dll
        self.j1939_dll = CustomJ1939_21(self.send_message,
                                        self._job_thread_wakeup,
                                        self._notify_subscribers,
                                        self.max_cmdt_packets,
                                        self.minimum_tp_rts_cts_dt_interval,
                                        self.minimum_tp_bam_dt_interval,
                                        self._is_message_acceptable,
                                        notify_these_also = [
                                            ParameterGroupNumber.PGN.ADDRESSCLAIM,
                                            ParameterGroupNumber.PGN.REQUEST,
                                            ParameterGroupNumber.PGN.TP_CM,
                                            ParameterGroupNumber.PGN.DATATRANSFER
                                            ]
                                        )
        super()._async_job_thread()

In the notify_these_also list in the above code, I have put all four of the "missing" PGNs, but this can be changed to suit.  Maybe the most problematic is the PGN.REQUEST because this PGN is not only used for requesting address claim messages, is it? E.g. it is legit to use this PGN to ask devices on the bus for Software ID (0xFEDA) responses, etc., too?

Addendum to my last note about the non-address-claim PGN.REQUEST not making it to subscribers:
If using the ECU without a CA (the technique mentioned on this line), it seems that the PGN.REQUEST won't get to subscribers, but if using a CA, then the J1939_21.notify function will on this line call the CA's _process_request function, and then the subscriber will be called here. (This applies to every requested PGN except for PGN.ADDRESSCLAIM, which I don't think will make it subscribers at all unless we change the code or apply a workaround such as the one in my prior comment.)


:bug: Correctly pass kpm_kwargs and log_model_kwargs to pipeline_ml_factory instead of always using default values (#329)

Description
Close #329
Development notes

pass kpm_kwargs and log_model_kwargs to _turn_pipeline_to_ml method of PipelineML
refactor merge with default for readibility

Checklist

[x] Read the contributing guidelines
[ ] Open this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Update the documentation to reflect the code changes
[x] Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
[x] Add tests to cover your changes

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Codecov Report

Merging #332 (0deafc9) into master (a5c5781) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #332   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           28        28
  Lines          910       906    -4
=========================================
- Hits           910       906    -4

Impacted Files
Coverage Δ

kedro_mlflow/pipeline/pipeline_ml.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c5781...0deafc9. Read the comment docs.


[MacOS] Top menu is missing in 4.1 builds

Godot version
v4.1.rc2.official [46424488e]
System information
MacOS 14.0 Beta (23A5276g) - M2 Pro
Issue description
Top menu is missing in all the 4.1 builds. I've tried all the beta, dev and rc builds. It works in 4.0.3 stable version.

Steps to reproduce
Open any project.
Top menu is missing.
Minimal reproduction project
N/A

I can't reproduce it, might be macOS 14.0 Beta specific issue.

Unfortunately I don't have macos 13 device to test it. I thought since it works in 4.0.3 it is a Godot regression.

It is visible in MacOs13.4.1

Can't reproduce on the release version of Sonoma (14.0 - 23A344) either, probably was a beta bug.

Closing based on the discussion above.


WIP: ecx: add key generation support.

X25519, X448, Ed25519 and Ed448.

[ ] documentation is added or updated
[ ] tests are added or updated

Very early WIP, TLS tests are completely broken.

In travis it doesnt get past

make update
Due to s390 related code..

Failure in ./test/evp_test ./test/recipes/30-test_evp_data/evppkey.txt is in fips mode as these are not in the fips module.
You may need to seperate them out into another .txt file and add into the .t file.

It looks like you broke it good :)

Pauli just having a cursory look at a failure in ssl_test_old:
I think it generates one of your new keys and then runs..
static int add_key_share(SSL *s, WPACKET pkt, unsigned int curve_id)
{
....
/ Encode the public key. */
encodedlen = EVP_PKEY_get1_tls_encodedpoint(key_share_key,
&encoded_point);
which then calls     rv = evp_pkey_asn1_ctrl(pkey, ASN1_PKEY_CTRL_GET1_TLS_ENCPT, 0, ppt);
which probably then calls legacy_asn1_ctrl_to_param which will not handle ASN1_PKEY_CTRL_GET1_TLS_ENCPT and then return -2;
@mattcaswell you may already be aware of this?

I added these in FIPS mode.  I suspect there are things that have been missed so far.
Or I've missed thing that I shouldn't have.

@mattcaswell you may already be aware of this?

Yes - I made the same note here wrt ec keymgmt:
https://github.com/openssl/openssl/pull/11328#issuecomment-601253691

Failing in the TLS tests, but finally passing the EVP ones.

This seems to be close now, the TLS tests are rubbish but otherwise it seems to work.  After building this branch:
$ ./util/opensslwrap.sh genpkey -algorithm ED25519 -out ed.pem
$ ./util/opensslwrap.sh pkeyutl -sign -rawin -in /tmp/f -inkey ed.pem -out sig

Then on a fresh 3.0 (master) build:
$ ./util/opensslwrap.sh pkeyutl -verify -rawin -in /tmp/f -inkey ed.pem -sigfile sig

I get:

Signature Verified Successfully

Where /tmp/f is a trivial test file being verified.

Can this be rebased? Will the various fixes that @levitte put in help with the TLS failures now?

Just needs a rebase (to address the merge conflicts) and this fix, and all the tests will start passing:
diff --git a/crypto/evp/pmeth_gn.c b/crypto/evp/pmeth_gn.c
index 67800282de..9a7cdcf591 100644
--- a/crypto/evp/pmeth_gn.c
+++ b/crypto/evp/pmeth_gn.c
@@ -155,8 +155,9 @@ int EVP_PKEY_gen(EVP_PKEY_CTX *ctx, EVP_PKEY **ppkey)

         if (keydata == NULL)
             goto not_supported;
-        ret = evp_keymgmt_gen_set_template(ctx->keymgmt,
-                                           ctx->op.keymgmt.genctx, keydata);
+        if (ctx->keymgmt->gen_set_template != NULL)
+            ret = evp_keymgmt_gen_set_template(ctx->keymgmt,
+                                            ctx->op.keymgmt.genctx, keydata);
     }

     /*

We agreed last night to include shake also if ecx is being added to the fips module.
Matt was going to do this... I will let you figure out with him who does this work..

Shake as FIPS approved?

Hmm probably same as ecx  which is unapproved.

Apparently so, per p190 of the FIPS-140 I.G. document.

IG A.11 discusses CAVS testing for SHAKE, so it is possible to validate it.

Its a question of what will be validated by the lab.

Travis failures are from an asan memory leak.

@mattcaswell this is in the tls related code.
I am assuming this is related to calls to ssl_evp_cipher_fetch() which can return a fetched cipher.
Unless there are explicit matching free calls for each of these then there will be memory leaks,

The direct leak looks like it is a key manager from a fetch.

A pkey is being assigned to s->s3.tmp.pkey at the end of add_key_share() in statem/extensions_clnt.c.  This pointer remains until SSL_free() is called and isn't freed there -- memory leak.
For the recordlen test, freeing the pointer in SSL_free() stop the leaks.  This isn't the solution since other tests crash.  I suspect it should be freed earlier as part of the state machine.  @mattcaswell, I've no idea where.

A pkey is being assigned to s->s3.tmp.pkey at the end of add_key_share() in statem/extensions_clnt.c. This pointer remains until SSL_free() is called and isn't freed there -- memory leak.

SSL_free() calls s->method->ssl_free() which calls ssl3_free() which does this:
    EVP_PKEY_free(s->s3.tmp.pkey);
    s->s3.tmp.pkey = NULL;

Missed that code path.  An additional EVP_PKEY_free() call did fix the memory leak, so something else is holding onto a reference :(

Missed that code path. An additional EVP_PKEY_free() call did fix the memory leak, so something else is holding onto a reference :(

Looking now.

Travis failures are from an asan memory leak.

What travis failures? I'm not seeing any memory leak either locally or in the travis output (travis is green apart from a timeout in one build)? Appveyor is also green.

@mattcaswell - I can only assume one of your other PR's that has been merged today has addressed whatever was causing the issue?

I can only assume one of your other PR's that has been merged today has addressed whatever was causing the issue?

Possibly  this could be something to do with the private key handling and the public_from_private calls in this PR.

It looks to me that this can come out of WIP

The two address sanitizer builds were failing, they aren't now -- I did rebase a couple of times last night.

Travis is the usual time out.

I've removed the commit.  The CIs are expected to fail at this point.
Once #11550 is merged, I'll rebase and confirm the CIs pass.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Travis is happy, merged.  Thanks for all the input and assistance.


allow showWindow and hideWindow to be overridden

opening for feedback, I have a use case where i wanna use the menubar icon to open a positionalable window (and bypass the auto positioning) so I figured I can just intercept the showWindow and hideWindow methods and implement them myself

:+1:
Also, if it's only about bypass the auto positioning and you need to dynamically set the window position, you could perhaps use menubar.setOption to set x and y. But I guess it won't work for your use case. :)

I ended up not needing this, went a different route instead https://twitter.com/denormalize/status/655534785624866816
I think it might be kinda hacky to expose, so closing for now


Json2xls support multiple sheets

This is more of a request than an issue, but could you add support for multiple sheets when going from json to xls?
Basically I would like to be able to use this data (that comes out of xls2json) and convert it back to xls

Created https://github.com/dwqs/js2excel/pull/8
I also took the liberty of fast-forwarding the dev branch to match the current master

Will this PR be merged anytime soon?
I also need support for JSON to multiple sheets.

Just use my branch:
https://github.com/stackola/js2excel
Nothing changed in this repo anyways.

it it merged? any example to select the sheet to write?

Is there any update?
does js2excel support multiple sheets ?

+1


How do I serialize an inner list with parameters?

If I make a dictionary with an inner list:
sig1=("date" "multiple");keyid="foo";alg="bar"'

if I try to serialize that one value in the dictionary I can't:
const {sig1} = decodeDict('sig1=("date" "multiple");keyid="foo";alg="bar"');
encodeDict(sig1)
//      Error: failed to serialize [object Object] as Bare Item
encodeList(sig1)
//      Error: failed to serialize [object Object] as List
encodeList(sig1.value, sig1.params)
// serializes to a normal list with no params "date" "mutliple"
encodeItem(sig1)
// Error: failed to serialize [object Object],[object Object] as Bare Item
encodeItem(sig1.value, sig1.params)
//      Error: failed to serialize [object Object],[object Object] as Item

Support for inner lists is there, but an easy way to serialize them is not.

decodeDict returns dictionary(js object) witch key is sig1 but you destructuring it as {sig1}.
this case sig1 is value of inner list with parameters.
inner list with params are not Dict, List and Item.
you can't encode it as valid sfv.

reopen it if necessary.


Fix retiming for Vivado FPGA synthesis (FMA + FAUX)

We have RTL for an FMA unit which requires 5 cycle retiming fma
When we use the retiming flag, we only see a few logic levels moved around. (DC balances these pipelines well). Logic levels for the entire design are ~20.
INFO: [Synth 8-5816] Retiming module `wrapper_GT0_tempName`
    Effective logic levels on critical path before retiming is: 60
    Total number of crtical paths = 198
    Optimizing at the module level
    Optimizing locally to improve critical paths(may not reduce worst delay)
    Effective logic levels on critical path after retiming is: 49
    Total number of crtical paths = 3127
    Numbers of forward move = 190, and backward move = 125

It seems that Rocket has also encountered this issue and given up citing backwards retiming being a strategy for ASICs rather than FPGA:
issue 1
issue 2
Maybe there exists some high-effort retiming or targeted retiming flags to help out? This is our current synthesis command:
synth_design -top wrapper -part $PART -include_dirs $dir_list -flatten_hierarchy rebuilt -retiming

Fixed with #899


401 error and missing scope when run playground-for-flutter

browser_adapter.dart:98 GET https://localhost/v1/account 401
js_primitives.dart:30  User (role: guest) missing scope (account)

Code is from:  https://github.com/appwrite/playground-for-flutter. And I comment out the addHeader line:
client          .setEndpoint(              'https://localhost/v1')
 // Make sure your endpoint is accessible from your emulator, use IP if needed
.setProject('60793ca4ce59e') // Your project ID
.setSelfSigned() // Do not use this in production
//.addHeader('Origin', 'http://localhost') ;

BTW, sdk for node works.

browser_adapter.dart:98 GET https://localhost/v1/account 401
js_primitives.dart:30  User (role: guest) missing scope (account)

Code is from: https://github.com/appwrite/playground-for-flutter. And I comment out the addHeader line:
client          .setEndpoint(              'https://localhost/v1')
 // Make sure your endpoint is accessible from your emulator, use IP if needed
.setProject('60793ca4ce59e') // Your project ID
.setSelfSigned() // Do not use this in production
//.addHeader('Origin', 'http://localhost') ;

BTW, sdk for node works.

Please describe the scenario you are getting the error? What are you trying to do? Are you logged in? and Error possibly displayed in the browsers console looks like you are running on web?

Closing as there was no further response. Feel free to reopen if you have further issues.


[react-router-redux] push not working properly?

Version
5.0.0-alpha.4
Test Case
https://github.com/BerndWessels/preact-redux-isomorphic
Steps to reproduce
Expected Behavior
push('/about') should only do client-side routing and not make any network requests.
Actual Behavior
push('/about') makes an actual network request to example.com.
Code extract
The code in question:
const mapDispatchToProps = (dispatch) => {
  return {
    onNavigate: (path) => dispatch(push(path)),
    )
  }

The complete code:
/**
 * Import dependencies.
 */
import {h, Component} from 'preact';
import {connect} from 'preact-redux';
import {push} from 'react-router-redux';
import './mdl';
import {Layout} from 'preact-mdl';

/**
 * Import local dependencies.
 */
import AppDrawer from './components/app-drawer/component';
import AppHeader from './components/app-header/component';
import AppContent from './components/app-content/component';
import {fetchGraphQLQueryCreator} from './actions';

/**
 * Import styles.
 */
import 'material-design-lite/src/material-design-lite.scss';
import 'material-design-icons/iconfont/material-icons.css';
import styles from './styles';

/**
 * Create the component.
 */
class App extends Component {

  /**
   * Initialize local component state.
   */
  constructor() {
    super();
    this.state = {
      drawerCollapsed: true // TODO maybe better in redux state?
    };
  }

  // Called on server and client.
  componentWillMount = () => {
    // Load data if necessary.
    setTimeout(() => {
      if (!this.props.alreadyLoaded) {
        this.props.onReady();
      }
    });
  };

  // Collapse or expand the drawer.
  toggleDrawer = () => {
    this.setState({drawerCollapsed: !this.state.drawerCollapsed});
  };

  // Render the component.
  render({onNavigate, aTest}, {drawerCollapsed}) {
    return (
      <Layout fixed-header={true} js={false}>
        <AppDrawer collapsed={this.state.drawerCollapsed} onCollapse={this.toggleDrawer} onNavigate={onNavigate}/>
        <AppHeader onExpand={this.toggleDrawer} onNavigate={onNavigate}/>
        <AppContent/>
      </Layout>
    );
  }
}

/**
 * Map state to component properties.
 */
const mapStateToProps = (state) => {
  return {
    aTest: state.a.test,
    alreadyLoaded: state.a.hasOwnProperty('report')
  }
};

/**
 * Map actions to component properties.
 */
const mapDispatchToProps = (dispatch) => {
  return {
    onNavigate: (path) => dispatch(push(path)),
    onReady: () => dispatch(fetchGraphQLQueryCreator({query: `{ report(id: 4711) { name } }`})
    )
  }
};

/**
 * Export the container component.
 */
export default connect(
  mapStateToProps,
  mapDispatchToProps,
  null, {
    pure: false
  }
)(App);

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!

@timdorr This is actually a bug. But its a bug in Chrome. react-router-dom and react-router-redux are using history which eventually uses window.history.pushState which on Chrome causes an unnecessary network request.
This is a pretty bad bug since it causes massive unnecessary traffic.
You can easily observe this in all your react-router based projects - just check the devtools or see the increase in traffic to your servers.
Cheers
Bernd

pushState specifically does not issue a network request. It is designed to let you manipulate the browser history without actually navigating the browser to a new page. There is no bug with this in Chrome, as it would not work with the many, many sites using that API (Google's own sites included).


Account for typedef nullability

_desugarTypedef accepts a _RawType and returns its underlying type if it's a typedef. However, it doesn't account for whether the _RawType is nullable or not. In order to accurately desugar a use of a typedef, we should union the _RawType's nullability with the underlying type's nullability. For example, SomeTypedef? should always be nullable after being desugared.

It is indeed non-breaking. Done, thanks!


Fixup Row > Model for sidecar

Parsing an empty string was throwing errors when trying to convert Row > Model

Thanks @AudreyAltman!


Increase Modules per deployment from 20 to 50

defaults have been increased from 20 to 50 on the service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec6fc6a5-9bf6-889e-075d-b5b009e67d1f
Version Independent ID: f3d6fa56-a494-fec8-50e3-f8682c90ac42
Content: Understand Azure IoT Hub quotas and throttling
Content Source: articles/iot-hub/iot-hub-devguide-quotas-throttling.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@sudeepster Thank you for your feedback! We will review and provide an update as appropriate.

@sudeepster Just to confirm, are you referring to IoT Edge automatic deployments under Other limits section?

@sudeepster A PR has been created to address and update the doc as per suggestions. Changes will go live once it has been peer reviewed and merged by EOD.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


BREAKING CHANGE: Introducing native ReverseDSC support for the module

Pull Request (PR) description
Native ReverseDSC Support
This Pull Request (PR) fixes the following issues
N/A
Task list

[ ] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Linked to #443

@regedit32 & @johlju Sorry I had to spam you with all these commits. Existing Resources were not even at par with the code Cov requirements in their previous status. I believe all is now ready for a second round of reviews. Cheers!

There are a lot of duplicated code introduced with this change, I also want to look over this to see that it actually the correct way of doing this. Please continue resolving comments on this change, but I will add an 'on hold' label for the time-being so we have chance to discuss this.
I have offline conversation with @NikCharlebois about this, but I have not have time to get back to that yet.


[FEATURE] Proxmox module/integration

Please add a proxmox module that can manage proxmox vm's or containers.

Moved to https://github.com/Paymenter/Extensions/issues/2


[rcore] Flip VR screens

The left and right screens when calling LoadVrStereoConfig is flipped. This pull request simply flips them back to the correct configuration.

@orosmatthew thanks for the review!


Skip time if value same as previous time

Is your feature request related to a problem? Please describe.
If several times contain the same value, the value is sent at the time each time.
If you use the adapter to send brightness values to a lamp where the brightness was previously changed manually, the value is set by the scheduler at that point in time.
Describe the solution you'd like
Possibility to use a switch to specify whether the same value should be set at the time when it is identical to the previous value.

So auch bei mir mit dem Licht. Frau dimmt heller, z.B. 20:50 Uhr, Adapter stellt Helligkeit um 21 Uhr runter. Frau ist not amused. 😂


Refactored start method to use Promise.all

Fixes #1134
Description
Refactored NamedPipeServer's start method to use two promises to manage connecting to the incoming and outgoing servers instead of using a single promise for both.
Testing
Behavior should be the same, so additional tests are unnecessary.

Pull Request Test Coverage Report for Build 80186

5 of 14 (35.71%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.07%) to 88.621%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botframework-streaming-extensions/src/NamedPipe/NamedPipeServer.ts
5
14
35.71%

Files with Coverage Reduction
New Missed Lines
%

libraries/botframework-streaming-extensions/src/NamedPipe/NamedPipeServer.ts
1
77.46%

Totals

Change from base Build 80026:
0.07%

Covered Lines:
4416

Relevant Lines:
4794

💛  - Coveralls


Removed ModulesWithNumber type because it is replaced by title

#2576  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

May 1, 4:15 PM EDT: @tommylau523 started a stack merge that includes this pull request via Graphite.


Support property observers which are direct function references

Partially addresses #4543
Provides better static analysis and refactoring support in multiple tools. Alleviates the need for property reflection with Closure-compiler renaming.
The test case included isn't actually that useful (but does test the change). Real benefits come with the class style syntax:
class FooElement extends Polymer.Element {
  static get is() { return 'foo-element'; }
  static get properties() {
    return {
      bar: {
        type: String,
        observer: FooElement.prototype.barChanged_
      }
    }
  }
  barChanged_(newValue, oldValue) {
    console.log(newValue, oldValue)
  }
}

Sorry for the delay. Rebased to tip of tree.

Filed https://github.com/Polymer/docs/issues/2421 to add documentation.

Filed Polymer/docs#2421 to add documentation.

Oops, ignore me, missed that there already was an issue.


[5454] Allow upload of csv with blank rows

Context
Submitting a CSV with a blank row leads to the error message ”  must match a trainee record”.
However the csv file should instead be accepted.
Changes proposed in this pull request
Add a guard method to ensure that a blank row csv is accepted.
Guidance to review
Try to submit a blank row csv.
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

TEST2.csv
When I use this CSV in the deployment, it says:
3 trainees who will be recommended for QTS or EYTS
2 trainees who will not be recommended, as you did not give a date when they met the QTS or EYTS standards
However, it should not count '2 trainees' - there's no detail for them. It shouldn't be mentioned at all?


build: honour BUILD_SHARED_LIBS

This is needed for proper shared linkage to the BlocksRuntime (e.g. when
building SourceKit).  We now build BlocksRuntime shared or static as requested.

@swift-ci please test

Please test with following PRs:
apple/swift#19674
@swift-ci please test

Please test with following PRs:
apple/swift#19674
@swift-ci please test

@compnerd: I might be wrong, but it seems that libBlocksRuntime.so ends up in the “root” build directory, not anywhere its sibling libdispatch.so. If I understand correctly, any Swift code that imports Dispatch will need libBlocksRuntime.so available (from the changes in the modulemap).
One of those is XCTest. While compiling it uses https://github.com/apple/swift-corelibs-xctest/blob/master/CMakeLists.txt#L48 to point to the libdispatch.so library, but it points the search path to …/src (where no libBlocksRuntime.so can be found).
Another is LLBuild. From https://github.com/apple/swift-llbuild/blob/master/products/llbuildSwift/CMakeLists.txt#L19-L24 it points the library search path to …/src/.libs.
I think those might need to be fixed, but I will wait until I can talk with you to confirm.


Consider providing Tiny v2 Intermediary instead of v1

It's simple: in the end of the maven field, a :v2 should be appended to it so that the Tiny v2 Intermediary is used instead of Tiny v1;
For a while, I've been testing with using the v2 distribution instead of v1, and it has shown to be pretty reliable, and Quilt Loader has been supporting it well; The only issue would be with the installer/launcher implementations, which will need to support classifiers (an example is JumpQuilt, to which I PR'd classifier support in the end);
A side-effect of this would be that the Tiny v1 format won't need to be supported by Quilt Mapping Tools and such if it no longer ends being used on such essential spots;
The perfect moment to pull this off would be with the Meta v4, but we'll need to test a lot and make sure we won't ever need to provide the Tiny v1 version of Intermediary

Relevant notes here:
From past tests of mine, I've determined that the vanilla Minecraft launcher (which also covers CurseForge and friends), the MMC family (MultiMC, Prism Launcher, etc.), ATLauncher, and Technic Launcher are all launchers that support version classifiers on maven paths; The only thing that didn't support it was JumpQuilt, which was addressed by a PR adding support for it;
At this point, I believe that not supporting version classifiers at this point is a rookie mistake that is usually fixed on a launcher/tool's early lifespan and therefore we shouldn't worry about any potential breakage on that area
The only potential breakage we need to worry about is about whenever the first Intermediary that shares a version with Hashed (see #13) works with the first Quilt Loader release under the Intermediary v2 distribution; I'll investigate this myself

Update: it appears that all Intermediary versions had Tiny v2 distributions published retroactively, making issue #13 not a mandatory requirement for going forward with the change;
Testing with the earliest Quilt Loader version available through the meta (0.16.0-beta.1) and the earliest Intermediary sharing a Hashed version (1.19.4), I can determine that it is safe to go forward with the migration


Remove unused code

Change Description
Remove unused variable uint32_t sign_of_a = a.v >> 31; in float _eosio_f32_copysign( float af, float bf ) function and uint64_t sign_of_a = a.v >> 63; in double _eosio_f64_copysign( double af, double bf ) function.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Hello, please base your PRs off of the develop branch. Thanks.

Rebased in #7676.


Support adding constrained columns on tables with existing data

When I try to alter an existing table:
ALTER TABLE existing_table ADD something string NOT NULL DEFAULT "text";
I get this error message:
ALTER TABLE existing_table ADD something: cannot add constrained column to table with existing data in line 0
I don't know much about the internals of ql, but would it be possible to support this?

It is possible to certain extent support that. The problematic parts are:

It'll have to check every existing row of the table and thus take a long time.
If the constraint fails at any row, it'll have to undo any mutation made to the table so far and thus take even more time.

For the above reasons the feature is not implemented. It's still possible to do the equivalent operation by doing:

create an empty temporary table with the desired schema including the constraint
try to import the existing data into into the temporary table
if ok, delete all rows from the existing table, update the schema with the constraint and import the temporary table data into it.

The above "external" steps are not the fastest way how to workaround the issue, but probably a safe approach.
You're welcome if you would like to implement and contribute the feature internally in ql. Basically, it's just reproducing the above steps. Initially, just calling a few ql (ie text) statements reproducing the above steps would be enough and rather easy to implement, I guess.
WDYT?

Thanks for the quick reply!
I think it makes sense to apply the changes to a temporary table first. As far as I can tell ALTER statements usually have an implicit COMMIT so transactions shouldn't be an issue either. I might have a go at implementing this at some point, but will try the SQL workaround you mentioned first. Thanks!


ansible: Optionally skip ceph configuration on ciao nodes

Ciao requires a ceph cluster to be available for all ciao nodes.
The deployment playbook requires that the systadmin provides ceph
configuration and secret files in order to configure ceph on all
ciao nodes.
This changes introduces skip_ceph variable which allows the deployment
to skip ceph configuration and leave that step to be performed manually
by the sysadmin.
Fixes #782
Signed-off-by: Alberto Murillo Silva<EMAIL_ADDRESS>

Coverage increased (+0.01%) to 65.797% when pulling d872c61013602808e6fa56fae66c5cee1f477335 on albertomurillo:skip_ceph into d0951e28d6a33fc2437394aab79665d0c576f6c2 on 01org:master.

@markdryan Text was updated, thanks for the suggestions.

Coverage increased (+0.02%) to 65.144% when pulling 13b8e64542570c995f454537a1b051add48e1e0f on albertomurillo:skip_ceph into 4b1fbb2d6ada7a28dc31e5a9d05e775e1ab04eea on 01org:master.

Coverage remained the same at 65.176% when pulling 6ec1058024194251d62e4ab739e5e76d229d167c on albertomurillo:skip_ceph into 586d8f56c13837538ff4c24a307701f27852dae1 on 01org:master.

Coverage decreased (-0.02%) to 65.126% when pulling a49770de6f7b0944c73cf7536b1541745243060e on albertomurillo:skip_ceph into c09559bba9834aaddbd54212b1dbb3d076ba38fa on 01org:master.


Stateful api examples - Section 10a in issue 862

Here is the documentation for 10a - stateful examples, which is found in issue #862. @rabbah had requested I take the 3 examples from the IPL slides and add them to the document and I believe this specific section is perfect to highlight them.

@JamieDawson can you link this to the side bar/table of contents.
Also for the language examples can you apply the multi-tab pattern?

Fixed images to link properly in static/img folder.
All 3 code examples (JS, Python, and PHP) are now in a multi-tab solution.

Pending review.


Add ashfinal/qfview.nvim

Repo URL:
https://github.com/ashfinal/qfview.nvim
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[ ] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR! The changes you've made don't adhere to the checklist, I've deselected the item(s) that need to be fixed.

I must admit I'm a little confused with the description.  😃
If your question is about category(colorscheme or something else), under the hood, qfview.nvim uses the same APIs as nvim-pqf and more to achieve better UX. Meant to be a complete replacement of nvim-pqf, and lightweight trouble.nvim(I do love their folding function, BTW).


Pointing "FROM" to a private repo which name contains an hyphen is broken in 1.7

Create and push the following images:

foo/test-private - make this private on the hub
foo/test-public
foo/private - make this private on the hub

Now, rmi all these images.
Try to build the following dockerfiles:

FROM foo/test-private <- FAIL
FROM foo/test-public <- WORKS
FROM foo/private <- WORKS

Note that a simple docker pull foo/test-private works.
Reported initially by @sbasyal
cc @icecrime
ping @jlhawn @dmcgowan @stevvooe @RichardScothern

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Can you show how it fails?

@duglin I believe it fails authenticating properly.
DEBU[2559] Pulling tag from V2 registry: "latest"
DEBU[2559] [registry] Calling "GET" https://registry-1.docker.io/v2/dmp42/test-repo/manifests/latest
DEBU[2559] Getting bearer token with map[service:registry.docker.io realm:https://auth.docker.io/token] for
DEBU[2559] hostDir: /etc/docker/certs.d/auth.docker.io
DEBU[2560] hostDir: /etc/docker/certs.d/registry-1.docker.io
ERRO[2560] Error from V2 registry: Authentication is required.
DEBU[2560] image does not exist on v2 registry, falling back to v1
DEBU[2560] pulling v1 repository with local name "dmp42/test-repo"
Pulling repository dmp42/test-repo
DEBU[2560] [registry] Calling GET https://index.docker.io/v1/repositories/dmp42/test-repo/images
DEBU[2560] hostDir: /etc/docker/certs.d/index.docker.io
Error: image dmp42/test-repo:latest not found

I don't think this is just private repos that contain hyphens. I have several that fail in this same way for all images I have and none have hyphens.
I would also like to note, if I do a $ docker pull {user}/{repo}/{tag} everything works fine.
If I have a Dockerfile that looks like:
FROM {user}/{repo}/{tag}
MAINTAINER alairock
RUN "Hello World"

It fails with the same error you have there. (Note {user}/{repo}/{tag} == Private repo)
Docker v1.7.0


gatsby-v2  WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

I'm not sure if this is a known issue. I keep running into this webpack error when doing: yarn install && npm run build
I tried using different versions of node (10, 9, 8), and clearing node_modules:
rm -rf node_modules/ && yarn cache clean && npm cache clean --force
I wasn't able to find a webpack config.
Error stack:
⢀ Building production JavaScript and CSS bundles
success Building production JavaScript and CSS bundles — 88.749 s

error Building static HTML for pages failed

See our docs page on debugging HTML builds for help https://goo.gl/yL9lND

  WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
   - configuration.module.rules[6].oneOf[0].use should be one of these:
     non-empty string | function | object { loader?, options?, ident?, query? } | function | [non-empty string | function | object { loader?, options?, ident?, query? }]
     -> Modifiers applied to the module when rule is matched
     Details:
      * configuration.module.rules[6].oneOf[0].use should be a string.
      * configuration.module.rules[6].oneOf[0].use should be an instance of function
      * configuration.module.rules[6].oneOf[0].use should be an object.
      * configuration.module.rules[6].oneOf[0].use should be an instance of function
      * configuration.module.rules[6].oneOf[0].use[0] should be a string.
      * configuration.module.rules[6].oneOf[0].use[0] should be an instance of function
      * configuration.module.rules[6].oneOf[0].use[0] should be an object.

  - webpack.js:24 webpack
    [gatsby-starter-netlify-cms]/[webpack]/lib/webpack.js:24:9

  - build-html.js:34 Promise
    [gatsby-starter-netlify-cms]/[gatsby]/dist/commands/build-html.js:34:7

  - debuggability.js:303 Promise._execute
    [gatsby-starter-netlify-cms]/[bluebird]/js/release/debuggability.js:303:9

  - promise.js:483 Promise._resolveFromExecutor
    [gatsby-starter-netlify-cms]/[bluebird]/js/release/promise.js:483:18

  - promise.js:79 new Promise
    [gatsby-starter-netlify-cms]/[bluebird]/js/release/promise.js:79:10

  - build-html.js:33
    [gatsby-starter-netlify-cms]/[gatsby]/dist/commands/build-html.js:33:12

  - Generator.next

  - next_tick.js:131 _combinedTickCallback
    internal/process/next_tick.js:131:7

  - next_tick.js:180 process._tickCallback
    internal/process/next_tick.js:180:9

Thanks!

I'm able to build successfully if I do npm install && npm run build. Somehow installing packages with yarn install is causing the error.

Are you using the gatsby-v2 branch?

I had this exact same issue when attempting to deploy to Netlify. I tried deploying the gatsby-v2 branch.

If it's the v2 branch it's due to outdated lockfiles. Will update.

@erquhart , I verified that pulling gatsby-v2 works perfectly. Thank you for looking into this!

Awesome 👍


Add the IO Type ID of LED Light

Thank you for such a wonderful document!
I added an IO Type ID which I got when attaching 88005 LEGO® Powered Up LED Light to hub.

Hi @bricklife we will review this change, it is probably correct at first glance but the we need to double check. Expect his to take a little time, because of the holidays. Thanks for your contribution!


fix: pass accountId to useCosmosSdkStakingBalances

Description
This bug was only seen on wallets that had ATOM staking.  If no accountId was passed to useCosmosSdkStakingBalances then it would default validator information to ATOM.
Fix:
Pass accountId to useCosmosSdkStakingBalances so correct opportunity gets passed through.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk
Breaks Cosmos staking

Testing

Engineering
Test that OSMO staking/unstaking works
Test that ATOM staking/unstaking works

Operations
Test that OSMO staking/unstaking works
Test that ATOM staking/unstaking works

Screenshots (if applicable)

LGTM, tested against prod:
Prod
Incorrect multiple Osmo opportunities in Earn

This diff
Correct single staked opportunity row in earn opportunities

Also tested overview tab opportunities as a sanity check, as well as default ShapeShift opportunity in ATOM/OSMO asset on an empty account which are still looking good
Note, we will need a similar fix for asset page staking opportunities, as it is showing currently staked CosmosHub validators as an Osmosis default opportunity (see last row):

Thanks for tests 👏


Save more settings

Everything on the GUI, including entertainment group selection, monitor, ..., should be saved.

Will this be in one of the upcoming update? The last update 2.0 alpha 3 while really nice raises the center slowness/dampening way to much for my set up. I have a Lightbar plus right behind my monitor so the old setting of 2 was breath taking while watching movies or trailers and the new default of 10 feels extremely sluggish though I'm guessing this is because of my light placement! I only just realized settings weren't being saved because this was the first time I tried to change something from default. Thanks for your work this program's coming out really nice!

@BradyBrenot This sounds good, but would it be possible to add a reset button in case settings are changed inadvertently? Thanks


Terraform not a complete open source tool anymore

We can add about terraform changing its license to BSL to aware people.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d0717ae9-8312-3218-5c54-8dc9f56170fc
Version Independent ID: ba9cefc2-294a-0f38-16f6-f37f7fe98f76
Content: Overview of Terraform on Azure - What is Terraform?
Content Source: articles/terraform/overview.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@PriyanshNegi
Thanks for the feedback.
The article, Overview of Terraform on Azure - What is Terraform?, introduces the Terraform Azure providers and explains some of the benefits of using Terraform on Azure.
The HashiCorp Terraform licensing terms don't impact any of that content.


Unexplained consistent random stalling/crash with latest release builds

Minimal setup to reproduce the issue:

Multiple (>=2) CARLA 0.9.2 release server binaries running on the same GPU,
1 vehicle actor spawned with 1 RGB camera attached,
Using compatible PythonAPI build (0.9.2) for client communications

Observations/ Issues to be addressed:

Works as expected for a few thousand ticks
[ ] Consistently stalls (there is GPU activity though) after several thousand ticks (~2 hrs)
[x] Tries to send crash reports to Epic Games server which sometimes fails and causes stalling
[ ] The stderr/stdout messages are not informative when a SIGSEGV (signal 11) is received
[x] ERROR:tcp accept error: Too many open files (#1119)

Sample (short) trace of stdout when the stalling  happens:
...
================================================================================
[2019.01.08-22.02.55:704][  0]LogInit: Display: Game Engine Initialized.
[2019.01.08-22.02.55:704][  0]LogGameplayTags: Display: UGameplayTagsManager::DoneAddingNativeTags. DelegateIsBound: 0
[2019.01.08-22.02.55:704][  0]LogStats: UGameplayTagsManager::ConstructGameplayTagTree: Construct from data asset -  0.000 s
[2019.01.08-22.02.55:704][  0]LogStats: UGameplayTagsManager::ConstructGameplayTagTree: GameplayTagTreeChangedEvent.Broadcast -  0.000 s
[2019.01.08-22.02.55:718][  0]LogInit: Display: Starting Game.
[2019.01.08-22.02.55:718][  0]LogNet: Browse: /Game/Carla/Maps/Town01?Name=Player
[2019.01.08-22.02.55:731][  0]LogLoad: LoadMap: /Game/Carla/Maps/Town01?Name=Player
[2019.01.08-22.02.58:337][  0]LogAIModule: Creating AISystem for world Town01
[2019.01.08-22.02.59:354][  0]LogLoad: Game class is 'TheNewCarlaGameMode_C'
[2019.01.08-22.02.59:768][  0]LogWorld: Bringing World /Game/Carla/Maps/Town01.Town01 up for play (max tick rate 0) at 2019.01.08-17.02.59
[2019.01.08-22.02.59:795][  0]LogWorld: Bringing up level for play took: 0.437414
[2019.01.08-22.02.59:813][  0]LogCarlaServer: Initializing rpc-server at port 37382
[2019.01.08-22.02.59:821][  0]LogCarlaServer: New episode 'Town01' started
[2019.01.08-22.02.59:826][  0]LogLoad: Took 4.095626 seconds to LoadMap(/Game/Carla/Maps/Town01)
[2019.01.08-22.03.00:880][  0]LogLoad: (Engine Initialization) Total time: 6.40 seconds
[2019.01.08-22.03.01:057][  0]LogRenderer: Reallocating scene render targets to support 856x640 Format 10 NumSamples 1 (Frame:1).
[2019.01.08-22.03.01:651][  1]LogLinux: Setting swap interval to 'Immediate'
[2019.01.08-22.03.01:651][  1]LogLinux: Warning: Unable to set desired swap interval 'Immediate'
[2019.01.08-22.03.01:652][  1]LogCarla: Starting AWorldObserver sensor
[2019.01.08-22.03.56:994][626]LogHttp: Warning: 0x7fbb68fd5c80: request failed, libcurl error: 6 (Couldn't resolve host name)
[2019.01.08-22.03.56:994][626]LogHttp: Warning: 0x7fbb68fd5c80: libcurl info message cache 0 (Could not resolve host: datarouter.ol.epicgames.com)
[2019.01.08-22.03.56:994][626]LogHttp: Warning: 0x7fbb68fd5c80: libcurl info message cache 1 (Closing connection 0)

Related Issues: #1
CARLA Version: 0.9.2
OS: Ubuntu

Another reason for a crash:
terminating with uncaught exception of type

boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system>_error> >
: bind: Address already in use

The bind: Address already in use issue is still present with the 0.9.3 release. The process might just need to  try and bind to an unused port or even better, it can bind() to port 0 in which case the OS will allocate an unused port.

@nsubiron If you have a fix in place for the bind: Address already in use issue, can you please push to a branch (some other branch if not to master) ?

@praveen-palanisamy You can find latest build here. Now you can launch the simulator with -carla-streaming-port= to select the streaming port (and -carla-rpc-port= for main port). If the streaming port is set to 0, a random available port is chosen.

@nsubiron Nice! Thanks for the fix. It seems to be working well.
We can probably close this issue once it is merged into master.

Great :)


Drop off png support (for now)

This has various issues that it is causing with other libraries
folks are using with carla; so until it gets a little more attention
we should just avoid png support.

This change is

I had to update PythonAPI/Setup.sh as well to remove the PNG dependency.

Thanks for this request. We would appreciate this change a lot. In addition, I had to update PythonAPI/Setup.sh as well to remove the PNG dependency.

What did you do exactly?


fix: add SCA check and warning with link to activate it

fix #133.

rusting the test as I don't know if we can disable it once it's enabled

As subscription team explained, SCA is enabled for all new accounts and cannot be disabled. For very old accounts where SCA is disabled it can be enabled on subscription management page. It is cannot be disabled after one enables it, the widget appears only for accounts with disabled SCA.
At some point later this year it is going to be enabled for very old accounts regardless one wants it or not.


Support App Privacy Manifests

Apple required App Privacy manifests until 2025. So google-maps-ios-utils SDK that contains an app privacy manifest must be signed.
I would like to know when you adopt this change.
References
https://developer.apple.com/videos/play/wwdc2023/10060/
https://developer.apple.com/news/?id=av1nevon
https://developer.apple.com/app-store/user-privacy-and-data-use/
Please check it out. Thanks!
Describe the solution you'd like
Add Privacy Manifest
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

If you would like to upvote the priority of this issue, please comment below or react on the original post above with :+1: so we can see what is popular when we triage.
@harikrishnank333 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

The Google Maps Platform team is aware of Apple's announcements regarding third-party SDK privacy manifest and signature and required reason APIs. Although none of the Google Maps Platform SDKs for iOS are listed on Apple's page of "SDKs that require a privacy manifest and signature" as of the date of this message, the team is working on understanding and fulfilling the requirements in anticipation of Apple's requirements of apps and libraries (like this one) that use Maps SDK for iOS as a dependency.
"Star" the Maps SDK for iOS issue tracker issue to receive updates on the privacy manifest and signature for Maps SDK for iOS.

The installation instructions for Google Maps Platform SDKs for iOS now have download links and instructions for manually adding Privacy Manifest files for use with the latest versions of the SDKs. If you receive feedback from Apple regarding the contents of these privacy manifests, please report that feedback on this Issue Tracker issue. Find instructions and manifests for each SDK at the links below:

Maps SDK for iOS
Places SDK for iOS
Navigation SDK for iOS
Driver SDK for iOS
Consumer SDK for iOS

Closing this issue since further discussion should be done in the Maps SDK for iOS Issue Tracker.

@wangela Is there any updates for a new version of below pods that supports PrivacyInfo.xcprivacy:

pod 'GoogleMaps'
pod 'Google-Maps-iOS-Utils'


images appear to be unavailable after inserting via (+) sign

- Do you want to request a feature or report a bug?
bug
- What is the current behavior?
Images inserted in the raw editor seem like broken links in the preview after saving and reloading
- If the current behavior is a bug, please provide the steps to reproduce.
When adding an image to a post in the raw editor with the (+) sign, the image shows up in the preview.  After saving and reopening the post, the image is a "broken link" and there is a 404 on the image path in the developer console.
Nonetheless, the image is saved and present in the deploy preview.
- What is the expected behavior?
Images appear to be functional in each of: editor, preview, saved copy and the deploy preview
- Please mention your node.js, and operating system version.
netlify install of the CMS v .3.8
@cassiozen watched this happen :)

I've been looking into this -- I think the issue is that the image preview is stored on the new branch created when a new post is saved and isn't accessible when reviewed. However I can't confirm this yet, because I'm having trouble identifying the component(s) in question.  I've attached two images here:
(Looking for what component is rendering broken image graphic)

placeholder (what is this component?):

My hope is to replace the broken image with a placeholder (like the second image, but with a little more detail), however I'm not sure where to look for what is generating the 404 image. The CSS Modules and the naming structure of the components make it very hard to identify what I am looking at.

FYI I found the place you need to make the change and it is the VisualEditor

thoughts @biilmann?

@americool I talked to biilmann IRL and this is a Prosemirror thing and need to be fixed on that end. Not something apprachable within the CMS repo

Re-opening this, merits further exploration.

This is definitely related to @americool's post above. When the draft is saved, it creates a new branch etc, and puts the file there. Then when it's reloaded, the default AssetProxy class returns the image at it's saved path (something like "/img/{filename}.jpg"). If the site isn't deployed yet (which is the case within the editorial workflow), when you return to edit the entry, the image doesn't preview properly.
As a test, I did something like this:
const rawPath = "https://raw.githubusercontent.com/{username}/{reponame}/";
const previewImagesPath = "/site/static";
let image = getAsset(entry.getIn(["data", "image"]));
if (image.uploaded) {
      image = rawPath + branch + previewImagesPath + image;
    }
return

This works if the repo is public, but I haven't been able to get it working for a private repo yet.

I'd suggest something like the above could probably be baked into the AssetProxy class if it was deemed a good direction for this, but I'm not sure if it is indeed a good direction or not :)

@erquhart Just a thought - it might be best to rename this issue as it has more to do with the editorial workflow than the actual insertion of images. Something like "image uploading / editing in editorial workflow", maybe?

@anthonysapp just saw your comment - renamed. I agree that the asset proxy is the most likely point of failure, any fix will probably center on changes there.

I've ran into this too. I think an important question is what is the best/easiest/most consistent way to identify the proper url based on the context of the post.. maybe there should be a backend.url(branch/tag/commit, path) that will return a URL to the raw image for previews and use in the admin ui or something similar...
thoughts?

Update: introduction of the media library will cause asset management to be workflow agnostic, since uploading an asset will always result in a commit to the primary branch. Should be resolved when #350 is closed.

That makes sense for re-used content.  Does it make sense for one time use content?
Consider the following use case, I'm prepping content for a marketing campaign the doesn't got live till a future date.  My clients want to keep it quiet until the big campaign launch. I don't want the risk of content going public prematurely, and stressing my relationship with my client.

@dopry I'd expect that use case to occur in a private repo. As long as the related assets aren't included in a published entry, you should be fine.

You're absolutely certain that there is no way google will index that? If someone emailed a link to a client with a google apps account, would it get indexed and potentially become available through search?  I'd be much more comfortable if the content wasn't publicly available at all.

Google can't/won't index private info from your email. If your GitHub repo is private and you don't publish the asset, it won't be exposed.


Mark step as skipped

Hi,
Is there a way to mark a step as skipped?
We try to represent all important requirements in our feature files.
A side effect of that is that it won't be possible to run automatic tests of everything (Flash, UI look and feel, etc).
The simple way of handling this is just adding step definitions for those steps, but not actually doing anything in those steps (just letting them pass). That's what we've been doing so far. However, that way it is hard to measure how many, and which, steps are not being run.
Does Behat have support for this? If not, would it be a good idea to add?

@everzet can I throw SkippedException or something like that in hook to get skipped tests in the main report?

@everzet can I throw SkippedException or something like that in hook to get skipped tests in the main report?
I have the same question.
I want to integrate Behat with EPAM Report portal. How can I handle skipped tests?

@everzet It seems that we still need an equivalent to phpUnit's markTestIncomplete and markTestSkipped.
If some component of the testing infrastructure has dropped offline... a team may still want the rest of the tests to run.  skip/incomplete functionality would make this possible.

I agree about the need of being able to skip a test at a lower level


[Android]Unexpected crash behavior when update to  weex version  0.28.0, the log shows that couldn't find "libc++_shared.so" caught  the crash

The detail log as below:

2019-11-05 16:43:52.612 20343-20360/com.weex.app E/weex: commitCriticalExceptionRT :WX_KEY_EXCEPTION_SDK_INITexceptionload c++_shared failed Detail Error is: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.weex.app-1/base.apk"],nativeLibraryDirectories=[/data/app/com.weex.app-1/lib/arm, /data/app/com.weex.app-1/base.apk!/lib/armeabi, /system/lib, /vendor/lib]]] couldn't find "libc++_shared.so"
2019-11-05 16:43:52.612 20343-20360/com.weex.app E/SafeRunnable: SafeRunnable run throw expection:dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.weex.app-1/base.apk"],nativeLibraryDirectories=[/data/app/com.weex.app-1/lib/arm, /data/app/com.weex.app-1/base.apk!/lib/armeabi, /system/lib, /vendor/lib]]] couldn't find "libc++_shared.so"

--------- beginning of crash

2019-11-05 16:43:52.613 20343-20360/com.weex.app E/AndroidRuntime: FATAL EXCEPTION: WeexJSBridgeThread
Process: com.weex.app, PID: 20343
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.weex.app-1/base.apk"],nativeLibraryDirectories=[/data/app/com.weex.app-1/lib/arm, /data/app/com.weex.app-1/base.apk!/lib/armeabi, /system/lib, /vendor/lib]]] couldn't find "libc++_shared.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:972)
at java.lang.System.loadLibrary(System.java:1530)
at org.apache.weex.utils.WXSoInstallMgrSdk.initSo(WXSoInstallMgrSdk.java:130)
at org.apache.weex.WXSDKEngine$1.run(WXSDKEngine.java:224)
at org.apache.weex.common.WXThread$SafeRunnable.run(WXThread.java:70)
at android.os.Handler.handleCallback(Handler.java:754)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:165)
at android.os.HandlerThread.run(HandlerThread.java:61)

Describe the bug
I just update weex version to 0.28.0 and the crash happened when app started

As it's said in the documentation, Weex only supports x86, armeabi-v7a and arm64-v8a. No armeabi support.

So , what can i do to deal with armabi ?  The previous  version has no problem

As it's said in the documentation, Weex only supports x86, armeabi-v7a and arm64-v8a. No armeabi support.

So , what can i do to deal with armabi ? The previous version has no problem

Yes, from 0.28, armabi is not supported any more, as Google depracted and stopped the support for armeabi. There is nothing we can do here.

Yes, from 0.28, armabi is not supported any more, as Google depracted and stopped the support for armeabi. There is nothing we can do here.

Is there any compatibility scheme ?  I want to update , but this problem have to be settled

Weex will not provide armeabi considering Google's insturction.
You could copy files from armeabi-v7 of weex to your app's lib/armeabi. This may work, you could give it a try.

Weex will not provide armeabi considering Google's insturction.
You could copy files from armeabi-v7 of weex to your app's lib/armeabi. This may work, you could give it a try.

Thanks, i will try it

Also remember copy the JavaScript Interpreter to lib/armeabi.
https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle doesn't support armeabi, either.

Also remember copy the JavaScript interpreter to lib/armeabi.
https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle doesn't support armeabi, either.

Just now, i have tried several times ,
1.First , i build a new jni directory in jniLibs .
2.Next , i copy the so file to the directory , contains armeabi-v7 files in sdk and libjsc.so file ,
but in the buid process, it was deleted automatic , it was the jsc script that worked ?  So i can't
continue it , i don't know what todo now

Also remember copy the JavaScript interpreter to lib/armeabi.
https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle doesn't support armeabi, either.

Just now, i have tried several times ,
1.First , i build a new jni directory in jniLibs .
2.Next , i copy the so file to the directory , contains armeabi-v7 files in sdk and libjsc.so file ,
but in the buid process, it was deleted automatic , it was the jsc script that worked ? So i can't
continue it , i don't know what todo now

And the ndk config also the "ndk {
abiFilters "x86"
abiFilters "armeabi"
}"

Don't add apply from https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle.
Just copy all the so(jsc.so and weex related so) files to libs/armeabi.
FYI: I am sure about compile org.apache.weex:sdk:0.28 will not cause deleting your files. You might figure out yourself.

Don't add apply from https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle.
Just copy all the so(jsc.so and weex related so) files to libs/armeabi.
FYI: I am sure about compile org.apache.weex:sdk:0.28 will not cause deleting your files. You might figure out yourself.

OK, i will have a try , thanks very much !

Don't add apply from https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle.
Just copy all the so(jsc.so and weex related so) files to libs/armeabi.
FYI: I am sure about compile org.apache.weex:sdk:0.28 will not cause deleting your files. You might figure out yourself.

I have tried yesterday and it works well

Please check if your jnilibs configuration is normal

Don't add apply from https://raw.githubusercontent.com/apache/incubator-weex/release/0.28/android/sdk/buildSrc/download_jsc.gradle.
Just copy all the so(jsc.so and weex related so) files to libs/armeabi.
FYI: I am sure about compile org.apache.weex:sdk:0.28 will not cause deleting your files. You might figure out yourself.

Hi,I have a similar error."java.lang.ClassNotFoundException: Didn't find class "com.taobao.windmill.bundle.bridge.WeexBridge" on path: DexPathList[[zip file "/data/app/com.zhaopin.ihr-QAevaKfoDUkl0I0jJ00_0w==/base.apk"],nativeLibraryDirectories=[/data/app/com.zhaopin.ihr-QAevaKfoDUkl0I0jJ00_0w==/lib/arm, /data/app/com.***-QAevaKfoDUkl0I0jJ00_0w==/base.apk!/lib/armeabi-v7a, /system/lib, /vendor/lib]]",
dependencies just like this:
//bindingX
implementation 'com.alibaba.android:bindingx-core:1.0.1'
implementation 'com.alibaba.android:bindingx_weex_plugin:1.0.1'
//weex
api 'org.apache.weex:sdk_legacy:0.28.0'
Please tell me how to resolve it.


[UWP] Accepted permission decision not stored on Windows 10 Desktop

Please fill out either the bug or feature request section and remove whatever section you are not using.
Bug
Version Number of Plugin: 1.2.1
Device Tested On: HP ElitePad 900
Expected Behavior
Once user accepts permissions, they shall be stored and user shall not be asked again.
Actual Behavior
User is asked each time to give permissions to application.
Steps to reproduce the Behavior
Create simple Xamarin.Forms UWP project that request some permissions in runtime, run app on Win 10.
Feature Request:
Please fill in what you would like

Which permission? Not very helpful here. Please add code sample.

Hi James,
An example below works on:

Android 6 (consumer, industrial devices)
iOS 10.2.1 (iPhones, iPads)
Winows Phone 10.0.14393.953 (Phone Microsoft RM-1104_15442)
Not working on:
Windows Desktop 10.0.10240.16725 ( Tablet HP ElitePad 900).

Here is the code:
Permission[] requiredPermissions = new Permission[] { Permission.Location, Permission.Camera };
bool permisstionGranted = false;
PermissionStatus status;

foreach (var permission in requiredPermissions)
{
	permisstionGranted = false;

	while (!permisstionGranted)
	{
		status = await CrossPermissions.Current.CheckPermissionStatusAsync(permission);

		if (status != PermissionStatus.Granted)
		{
			var results = await CrossPermissions.Current.RequestPermissionsAsync(new Permission[] { permission });

			if (results[permission] == PermissionStatus.Granted)
			{
				permisstionGranted = true;
			}
		}
		else
		{
			permisstionGranted = true;
		}
	}
}

which permission is popping up on Windows 10 multiple times? what line of code does it pop up at?

It was asking for location permission.

I expect the method responsible  CrossPermissions.Current.RequestPermissionsAsync
I guess this is the only one that pops up dialog to user.

As soon as I get device back I will try it out, and give you info regarding 2.

It seems like UWP is asking for the location permission again every time you create a new build (i.e. press run in visual studio). I don't think this is a bug of this library, but rather a design decision made by the UWP team.
Have you tried launching the app from the start menu to check if the permission is stored in this case?

I am unable to reproduce with my sample that is in this repo.


App.d.ts missing properties types

Description
In App.d.ts the App class's properties are missing the types
export default class App {
    /** Slack Web API client */
    client: WebClient;  // client does appear in the d.ts file
    /** Receiver - ingests events from the Slack platform */
    private receiver;
    /** Logger */
    private logger;
    /**  */
    private authorize;
    /** Global middleware */
    private middleware;
    /** Listeners (and their middleware) */
    private listeners;
    private errorHandler;
//...

But it probably should be
export default class App {

  /** Slack Web API client */
  public client: WebClient;

  private clientOptions: WebClientOptions;

  private clients: { [teamId: string]: WebClientPool } = {};

  /** Receiver - ingests events from the Slack platform */
  private receiver: Receiver;

  /** Logger */
  private logger: Logger;

  /**  */
  private authorize: Authorize;

  /** Global middleware */
  private middleware: Middleware<AnyMiddlewareArgs>[];

  /** Listeners (and their middleware) */
  private listeners: Middleware<AnyMiddlewareArgs>[][];

  private errorHandler: ErrorHandler;
//...

What type of issue is this? (place an x in one of the [ ])

[x] bug?
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Irrelevant
Reproducible in:
package version: 1.4.1
node version: Irrelevant
OS version(s): Irrelevant
Steps to reproduce: Irrelevant

Personally, I don't see a big issue with the current output as it's not anyhow allowed to access private fields from external (except for casting to any) in the TypeScript world.
That being said, if we can add type hints to those without any side-effects, it may be beneficial for some cases (I'm still not sure what the case is with App yet though). I haven't investigated the options in detail yet, does anyone know an appropriate way to add only exposed types to private fields?

You're right. I didn't pay enough attention to the fact that they private. (I used receiver in a JavaScript app)

Thanks for your reply! I think we can close this issue now. If you have something further to discuss here, please feel free to reopen it.


THRIFT-5650: Implement UUID in Go compiler

Client: go

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

hmm go-swift cross-test failed.
@Jimexist do you know how to access the detailed log from github actions?

I found the url to the logs uploaded by failed cross-test by enabling debug logging, but I don't have access to it.

go-swift is failing because Go cross test server does not implement testUuid() method. This causes an error when the Swift client calls it as part of cross:
TApplicationError (1): Unknown Method
Message: Unknown function testUuid

@kinoroy thanks that's easy to fix.
just out of curiosity, did you run the crosstests locally or did you get that from the logs from github actions?

@fishy Sorry I forgot to mentioned, you can get the logs from GitHub on the job page once its complete just click "cross-test-log" to download :)

It looks like rust is also using the wrong TType value for uuid so the rs-go tests are failing.


DB2: extra embedded routines

DB2 LUW driver provides a very small number of embedded functions for syntax highlight.
We should extend it (with constants or by reading from SYSCAT.ROUTINES)

DB2 functions: https://www.ibm.com/support/producthub/db2/docs/content/SSEPGG_11.5.0/com.ibm.db2.luw.sql.ref.doc/doc/r0024845.html?pos=2

verified


Fixed misuse of Array.map

Related to #8
Switched from Array.map to Array.forEach calls where the return value of Array.map was not used before.
Tested by downloading everything from https://frappe.github.io/charts/ and then replacing the frappe-charts.min.js files with my newly build ones. Seems to work.

Used Array.reduce in those cases where it is was obvious. Commented on other cases.

Is someone interested in merging this? I will not resolve conflicts if this PR won't be included in the first place.

Not sure why this hasn't had a response from the maintainer on this, looks like good improvements 👍
@FabianTe There are some examples of this issue in the docs as well. For example: https://github.com/frappe/charts/blob/master/docs/assets/js/index.js#L108
Don't know if you want to go ahead and fix those also.

@tom-sherman No, there is no personal benefit for me to resolve all of these merge conflicts anymore.


Added Elvira Dzhuraeva to Kubeflow members list

This change is

Can you please also add yourself to Kubeflow/community members.yaml


Adjust workshop subtitle, was abit weirdly phrased

Also change subtitle to h4 instead, since h3 seemed a bit too big...

Indeed. It is a bit nicer! Thanks!


[Request/Question] Autobidder

The BIN snipe feature is a great one and I think we can improve the "dark side" of this tool by adding an auto-bid function. Do you think is it doable considering the EA limits and how the scripts work at the moment? If so, I will give it a try.

An Autobuyer isn't something I'd like to add to this repository as it puts the other scripts in a bad light as well.
I've done a Proof of Concept of it, which is still in the autobuyer branch. However, the use of it might get you banned quite easily.
It is certainly doable, but you will have to make sure every action including all pinEvents are accounted for. It is highly frowned upon by the community though.

Sry that I open that case but I dont wanna open a new one.
Which BIN snipe feature do you mean?
I would like to see a good feature to BIN snipe, do u mean the refresh transfer list thing?
Tried that with a filter for Kimmich SIF 86 but the search isn't updating with refresh transfer list, there were still old offers.
Or do I have to do something other?
besides that: thx for all the scripts, they are awesome!

Read the previous comment, and look at the specified branch.

ah, so the BIN snipe feature he mentioned is part of the autobuyer?
I dont wanna "cheat", just a comfortable way to find good offers without risk my account.
It can also be a form of a better filter, maybe search for multiple players or sth like that. On PC offers are rare so BIN sniping can be really boring coz u can search for 30 min and find nothing. -> u will search slower and then when u find one u are too slow to catch xD
maybe other users are using autobuyer.. :(
I would really enjoy to filter multiple targets, but is it possible to implement? I doubt it ;)
Can u say a word to the "refresh transferlist" thing? Idk what it's doing when there are also old (and sold!) offers in my search results. So it wont help for sniping, right?
thx dude

A good alternative it to use the "min bin search script" to find the lowest
price of a player on the market, you then know your manual sniping point.
On Thu, Oct 26, 2017 at 1:08 PM Feigenstaub<EMAIL_ADDRESS>wrote:

ah, so the BIN snipe feature he mentioned is part of the autobuyer?
I dont wanna "cheat", just a comfortable way to find good offers without
risk my account.
It can also be a form of a better filter, maybe search for multiple
players or sth like that. On PC offers are rare so BIN sniping can be
really boring coz u can search for 30 min and find nothing. -> u will
search slower and then when u find one u are too slow to catch xD
maybe other users are using autobuyer.. :(
I would really enjoy to filter multiple targets, but is it possible to
implement? I doubt it ;)
Can u say a word to the "refresh transferlist" thing? Idk what it's doing
when there are also old (and sold!) offers in my search results. So it wont
help for sniping, right?
thx dude
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Mardaneus86/futwebapp-tampermonkey/issues/66#issuecomment-339644969,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2D2_gsiOFI9IhbUcXlucQ79marO1Ivks5swHYsgaJpZM4QECeb
.


No possibility to run colab demo

Hi, I added it as a comment in previous issue, but I think it's nice to raise it as a separate ticket - an issue there was it'd be nice to update diffusers package to newer version, but nowadays I am unable even to run colab demo due to this error.
I wanted to follow up as presented demo colab is not working at all. When downloading StableDiffusion pipeline I got error
TypeError: getattr(): attribute name must be string
I found an error about it on SO: https://stackoverflow.com/questions/74687769/typeerror-getattr-attribute-name-must-be-string-in-pytorch-diffusers-how
When I force to use 0.24, I got error on importing diffusers_interpret:
ImportError: cannot import name 'preprocess_mask' from 'diffusers.pipelines.stable_diffusion.pipeline_stable_diffusion_inpaint' (/usr/local/lib/python3.10/dist-packages/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py)
So I tried to install it with pip again but it downloads diffusers back to 0.3.0
So I can create a pipe for stable diffusion (requires diffusers > 0.4)  OR I can use diffusers_interpret (requires 0.3).
Both of them does not work together in demo colab meaning I cannot reproduce your output

Hi @zakrzewki! Thanks for reaching out.
The problem is in diffusers as you stated, not in diffusers-interpret. diffusers==0.3.0 no longer loads models correctly from HuggingFace Hub.
I took a look and it would take a lot of effort to change this package to now work with a new version of diffusers. I'm can do it, but after some months HuggingFace will change diffusers again, and it will no longer be compatible.
The only real scalable solution is to have them slightly change the package as I mentioned here, and then do the according changes in this package.

If you just want a quick and dirty solution, you cane edit /usr/local/lib/python3.10/dist-packages/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py:

remove line 6 that imports preprocess_mask
create the preprocess_mask in that file:

def preprocess_mask(mask):
    mask = mask.convert("L")
    w, h = mask.size
    w, h = map(lambda x: x - x % 32, (w, h))  # resize to integer multiple of 32
    mask = mask.resize((w // 8, h // 8), resample=PIL.Image.NEAREST)
    mask = np.array(mask).astype(np.float32) / 255.0
    mask = np.tile(mask, (4, 1, 1))
    mask = mask[None].transpose(0, 1, 2, 3)  # what does this step do?
    mask = 1 - mask  # repaint white, keep black
    mask = torch.from_numpy(mask)
    return mask

I don't guarantee that StableDiffusionPipelineExplainer will work 100% though, because the API versions no longer match.


[feat] Add ConfigManager to Microservices SDK

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add the ConfigManager module in Microservices SDK.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:
https://github.com/dojot/dojot/issues/1529

maybe you can follow the same pattern in all folder and file names that already exist in the new folders and files

For me, it's a great job.
I just left a few comments. :)

Closed due to the creation for a repository for the Microservice SDK code.
New PR: https://github.com/dojot/dojot-microservice-sdk-js/pull/1


Avoid unknown in ctor

We have this ctor for LanguageModelToolResult
https://github.com/microsoft/vscode/blob/2eb50fc57e3084eb825ea01d1beca419df140890/src/vscode-dts/vscode.d.ts#L19900
The | unknown parts makes it that you can actually create this type with any kind of array. Maybe we should have unknown only on the property but not the ctor?

I was actually looking at the same thing in LanguageModelToolResultPart but we can't avoid it there because you need to pass all the parts from LanguageModelToolResult which include unknown. Maybe we can make it better in the future with a similar solution to the toolInvocationToken, like type LanguageModelFuturePart = { _symbol: unique symbol; }.
But I agree that there isn't any reason for the constructor on ``LanguageModelToolResultto takeunknown` so I'll do that as a candidate.

this... feels like a "verify by code review"
https://github.com/microsoft/vscode/blob/38dc6ac5a771cc94bde1344722bb2d02c80096ea/src/vscode-dts/vscode.d.ts#L19900
looks right


MSAL logout doesn't land me on microsoft logout page

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.15.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.1
Description
Hi,
I am using Angular wrapper of MSAL.js v2 in one of my clients' applications. We have a logout button, click on which should redirect the user to the Microsoft identity page where the user can select which account to log out from, and then it should redirect to the post logout redirect URL.
Right now, when I call .logoutRedirect() or ',logout()` the app redirects back to its root.. It skips the intermediate step where we can choose an account that the user wants to log out from.
I have also configured Front-channel logout URL in Azure but no luck here as well..
I am not sure what am I missing.
MSAL Configuration
auth:{
        "clientId" : "{client_id}",
        "authority": "https://login.microsoftonline.com/{tenant_id}",
        "redirectUri" : "http://localhost:4200/auth-callback",
        "postLogoutRedirectUri" : "https://localhost:4200/logout"
    }

Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@r4hulp have you registered your postLogoutRedirectUri as a Redirect URI (in addition to http://localhost:4200/auth-callback). Is there any argument you are passing to logout() or logoutRedirect() (in particular)? Btw, your redirectUri is on http, can you try using https as in your postLogoutRedirectUri and see if it helps?
Also, sharing msal logs would be helpful here (set the logger to Verbose).


Fix find all references for salsa

Issue:
currently "find all reference" would return no results if called on exported properties in JavaScript file. For example:

After the fix:

Where are the tests for this change?

looks good. please add some tests.

@DanielRosenwasser @mhegazy @RyanCavanaugh any further comments?

Added a couple of comments. Looks :+1: to me after that.

There are no tests for find all refs/rename locs at declaration sites - is this because it doesn't work right now? If it does work, can you add tests?
Either way, can you rename the tests and add a numbered suffix?i.e. renameJsExports.tsbecomesrenameJsExports01.ts`). I can see us adding more tests in the future that test renames on exports within a JS file.


Farmer v0.1 - Re-written in Golang

We've decided to re-write Farmer completely in Golang, and release our first stable version.
Glossary:
Box is a bunch of containers linked together which is an instance of your project with a unique name. It can be a test/staging instance and even a real production one.
v0.1 Checklist

[x] Box package which is the heart of Farmer whose responsibility is to:

[X] Create a box with its related container with a unique name, with a cloned source code; ready for deployment.
[X] Delete containers, volumes, backups, etc; of a box, by providing its name.
[X]  Inspect a box's containers information including container id, current ports, volumes, domains and etc; by providing box's name.
[X]  Deploy a box's containers information including container id, current ports, volumes, domains and etc; by providing box's name.
[X]  List retrieves list of all boxes with some basic information such as current ports, volumes, domains and etc.

[X] Docker API Client wrapper, so that Container can talk to Docker Engine.
[X] Hub package, so that we can send outputs to the user.
[X] Add a consumer user named farmer and monitoring access, for clients. (#36)
[X] Controller package which is responsible for providing farmer's API for box management, domain management, authentication, etc.
[X] Domain (#19) package, which manages box's domains together with its underlying reverse-proxy.
[x] Installation script (#18) which automates installation of Farmer and its dependencies.
[X] Setup a RabbitMQ container for Hub
[X] Setup a MySql container for database
[X] Setup an Nginx container to be used as reverse-proxy for handling domains.
[x] Setup a Golang container for compiling and running Farmer server.
[x] Final tests.
[x] Automatically download the Docker image defined in .farmer.yml if it's not locally available.

Your suggestions are very much appreciated :)

v0.1 is out successfully. Thanks @majidgolshadi


Layout threshold to be configured for all the existing layouts

Layout threshold is to be configured for all the existing layouts.

Refer TableCornerCirclesDetection.java processMat() log statements

threshold is added for all the layouts .


Swiping the Content page does not swipe the title to next title

Hi Sir ...
When i swipe the content page to the next page of the PagingMenuController , The moment of the underline or the selector of the title should start when we start swiping the page , But the code does not work like this ... Its not working as shown in the example
The movement of the underline starts after the swiping of the whole page is done and starts the movement to next title
Can you help me with this Sir ..

There was huge changes of animation codes, so example gif shows wrong one which is older version. Sorry for my inconvenience...
Well, it's connected to other issue. It'll be fixed in the future, but it's how it works for now.


Possibility to send NULL in POST request.

Hey there, I’m using RestEase Version="1.4.7" for net core application.
I faced with interesting issue.
I have a simple interface:
    public interface IPing
    {
        [Post("/api/ping")]
        IEnumerable<string> Ping([Body] List<string> list);
    }

And the endpoint looks like:
    [HttpPost]
    public IEnumerable<string> Ping([FromBody]List<string> list)
    {
        return list;
    }

The interesting thing is - if I decided to call this method without passing list, I mean I pass null.
My request:
POST https://localhost:5001/api/ping HTTP/1.1
User-Agent: HTTP-REPL
Content-Length: 0
Host: localhost:5001

And i see exception:
RestEase.ApiException: 'POST "http://localhost:33330/api/ping" failed because response status code does not indicate success: 415 (Unsupported Media Type).'
That’s fair, I didn’t set Content-Type header. I fixed this by updating interface.
    public interface IPing
    {
        [Post("/api/ping")]
        [Header("Content-Type", "application/json")]
        IEnumerable<string> Ping([Body] List<string> list);
    }

But now I’m getting another exception:
System.ArgumentException: 'Header Content-Type could not be added. Maybe it's a content-related header but there's no content, or it's associated with HTTP responses, or it's malformed?'
I’m sure on 100% that if I set header everything will be ok. This request will pass correctly:
POST http://localhost:33330/api/ping HTTP/1.1
User-Agent: HTTP-REPL
Content-Length: 0
Content-Type: application/json
Host: localhost:33330

Any ideas or workaround how should i set header when request have no content?

Right, so we spot that you passed null for the body, and so don't set HttpRequestMessage.Content here. Then when we come to apply headers here, we fail to it to the request content because there is no request content here.
I think there's an argument to say that we should add an empty body if you use [Body] but pass null (however I'm not sure whether this would break anything...).
As a short-term workaround, define another method which takes a [Body] string and pass string.Empty to it.

I’m not sure that I understand how it will helps me.
I need to call api/ping without list parameter because it’s a business logic of endpoint.
If you sent me list – I will use it to sort(for example) If not, I will give you all that I have.
How new method with [Body] string  will help me?

I'm giving you a workaround which should work until we can decide on the right changes, if any, to make to RestEase.
public interface IPing
{
    [Post("/api/ping")]
    IEnumerable<string> Ping([Body] List<string> list);

    [Post("/api/ping")]
    [Header("Content-Type", "application/json")]
    IEnumerable<string> Ping([Body] string filter);
}

Instead of doing this:
api.Ping(null);

Do this:
api.Ping(string.Empty);

In order to make RestEase send an empty body, which can still have a Content-Type header on it,

Oh i see. To be honest right now in client code i'm doing this:
api.Ping(list ?? new List<string>());
But your advice also works, thank you.
Howewer, usually we cannot control client code and imho this should be fixed.
Thank you ones again for so quick response.

Right, so you're sending the body [] (with a Content-Length of 2), instead of sending an empty body. That to me makes more sense - you're actually sending a body, so it makes sense to put a Content-Type header on it.
I think it's incorrect to say that an empty body is application/json, since an empty string is not valid JSON. Nor would it be correct to say that an empty body is application/xml, since an empty string is again not valid XML. However an empty body would be a valid text/plain content.... But I think putting this sort of logic into RestEase is several steps too far in the wrong direction.
So I think the sensible choices are:

If they've added a Header to the method, and the method has a body which is null, add an empty body
If they've added a header to either the method or the interface, and a method has a body which is null, add an empty body

Totally agree, and as another argument here i want to show behavior of native HttpClient:
     var client = new HttpClient();
     client.BaseAddress = new Uri("http://localhost:33330");
     client.DefaultRequestHeaders.TryAddWithoutValidation("Content-Type", "application/json");

     var message = await client
                       .PostAsync<List<string>>("api/ping", null, new JsonMediaTypeFormatter());
     var result = await message.Content.ReadAsAsync<string>();

This code will sent:
POST http://localhost:33330/api/ping HTTP/1.1
Content-Type: application/json; charset=utf-8
Host: localhost:33330
Content-Length: 4

null

Well that's sending the literal string "null", not an empty body. See how the content length is 4, not 0.
On 9 November 2018 07:47:09 GMT, kessko<EMAIL_ADDRESS>wrote:

Totally agree, and as another argument here i want to show behavior of
native HttpClient:
    var client = new HttpClient();
    client.BaseAddress = new Uri("http://localhost:33330");
client.DefaultRequestHeaders.TryAddWithoutValidation("Content-Type",
"application/json");

    var message = await client
.PostAsync<List<string>>("api/ping", null, new
JsonMediaTypeFormatter());
    var result = await message.Content.ReadAsAsync<string>();

This code will sent:
POST http://localhost:33330/api/ping HTTP/1.1
Content-Type: application/json; charset=utf-8
Host: localhost:33330
Content-Length: 4

null

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/canton7/RestEase/issues/109#issuecomment-437277400

HttpClient, of course, doesn't let you add content-related headers if there's no content. That's the root cause of this issue in RestEase!

Look at this please #110

Please see my earlier message:

So I think the sensible choices are:
If they've added a Header to the method, and the method has a body which is null, add an empty body
If they've added a header to either the method or the interface, and a method has a body which is null, add an empty body

I still think one of those choices is the right decision. I still think we should decide on one of those choices. I will reject PRs which do not implement one of those choices.

What about this?
https://github.com/canton7/RestEase/pull/110#discussion_r234686127

After our conversation in PR comments, if i understand you right then acceptable fix should be here .
Sounds like - if ObjectValue is null but the headers are added, and only if there are headers on the method (not the class) - then returns empty content instead of null.
and looks like:
  protected virtual HttpContent ConstructContent(IRequestInfo requestInfo)
  {
      if (requestInfo.BodyParameterInfo == null )
          return null;

      if (requestInfo.BodyParameterInfo.ObjectValue == null && requestInfo.MethodHeaders.Any())
          return new ByteArrayContent(new byte[0]);
      // other if statements...

Unfortunately it is not possible to use Array.Empty<> in net45 and netstandard 1.1

I will change behavior of existing test that will be  broken , tests that cover new logic also will be added.
@canton7  anything else that i missed?

Actually, my last thought is that it should be added where the headers are added, and only if there are body-related headers on the method itself (not the class). That way we avoid instantiating an empty body in most cases.

I see, those changes definitely should fix the issue.
May I assume your branch will be merged in master after you finished with tests?
If you need any help here, just tell me.

Sorry, this slipped under my radar. Including this in the next release shortly.


[Input][Transition] Input field inside a transition has wrong styling

Please check this fiddle: https://jsfiddle.net/f4cufkv3/1/
The input field is placed in a transition, as result it gets a wrong styling:

its display mode is set to "block", so its width is wrong (does not take the width of the container)
it always has the "active" state, so its rendering is also wrong.

I hack it by forcing its display mode to "flex" to make it as wide as its container, but this doesn't fix the "active" state issue.

The usage was wrong. The transition class should be only set at runtime by the transition module.
So if initialized by javascript it works as expected
See https://jsfiddle.net/omdg0nyf/


Undeclared dependency identified in client module.

Problem desciption
The module client currently relies on a transitive dependency that hasn't been explicitly declared.
It seems that a wide range of classes of xnio-api are used by client both at compile and test time.
[org.xnio.ChannelListeners, org.xnio.IoFuture, org.xnio.ssl.SslConnection, org.xnio.ssl.XnioSsl, org.xnio.Xnio, org.xnio.XnioWorker, org.xnio.ChannelListener, org.xnio.conduits.ConduitStreamSinkChannel, org.xnio.ChannelExceptionHandler, org.xnio.channels.StreamSourceChannel, org.xnio.conduits.ConduitStreamSourceChannel, org.xnio.XnioIoThread, org.xnio.OptionMap, org.xnio.Options, org.xnio.StreamConnection, org.xnio.FutureResult, org.xnio.channels.StreamSinkChannel, org.xnio.conduits.PushBackStreamSourceConduit, org.xnio.IoUtils]

It runs correctly at present due to the introduction of this dependency through transitivity.
com.networknt:client:2.1.29-SNAPSHOT:: -> io.undertow:undertow-core:2.3.10.Final::compile -> org.jboss.xnio:xnio-api:3.8.8.Final::compile

Possible Outcome:
Relying solely on transitive dependencies makes the project susceptible to changes outside your control. Failure or instability in the project's functionality due to changes in transitive dependencies caused by alterations or removal of the introducing transitive dependency.
Possible Solution
We should explicitly declare the dependency in our pom.xml to ensure it is clearly documented as a project dependency.

We have a discussion in the PR regarding this issue and the final decision is to keep the current dependencies.