[JN-1184] Enable editing of multi-language surveys

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Adds a language selector to survey editor, which enables viewing and editing content for multi-language forms

Currently, text questions, html questions, and basic choice lists are supported for i18n editing.  This is not intended to provide exhaustive support for all i18n editing -- some cases, like editing the "none of the above" option text will need to be handled separately.  But in your testing, please note any cases like that that you find so we can ticket them appropriately
TO TEST:  (simple manual steps for confirming core behavior -- used for pre-release checks)

go to https://localhost:3000/demo/studies/heartdemo/env/sandbox/forms/surveys/hd_hd_mental
edit some content in English and spanish
save the content
confirm the saved content reflects your changes

ah, good catch on the 'default' handling.  Instead of having "default" text, maybe we just default to the portal's default language?   @MatthewBemis  what do you think?

@devonbush that generally sounds good to me- I think it's better to lean into our concept of a portal default anyway instead of relying on SurveyJS's logic. Although I'm not sure what would happen if you switched to a language that doesn't have all fields defined in the selected language. SurveyJS uses the default language as a fallback in that case. But maybe there's a way to override that in the surveyJS model

yeah, I think surveyjs currently just shows blanks if it can't find a text for the current language, and there is no 'default'.  I'll take a look if that can be changed.

Just updated our populated surveys to have "en" rather than "default"


parent views start

I think a feature like this to allow parents to view their child's progress / stats is a great. The app 'Class Dojo' does something like this very elegantly. It's really easy for parents to get connected into the app for a student.
Do you have any design / wireframes / visual plans of what these views will look like?


Adds support for exporting to OpenSearch

here is support for exporting to OpenSearch. The current integration with ElasticSearch was not compatible with the latest version of OpenSearch, despite the APIs being roughly similar

Thanks for the PR. Already with previous additions of export capabilities to more and more 3rd party systems, I had the thought that plainly adding all these individual systems to NP's export may at some point in time lead to a non-optimal situation. Specifically, I'm worried about having all these dependencies in setup.py and requirements.txt as well as the code additions requiring maintenance - whereas most users either don't use any of them or if at all only one.
Now adding another one, which is even just a variant of one that is already supported by NP (and AFAIK not hugely popular in comparison), raises theses thoughts even more so. I'm thinking that NP should probably come without any export functionality aside from JSON export and instead export functionality should be added

either using pip extras (such as, pip install news-please[opensearch])
or individual pip packages (such as, pip install news-please news-please-opensearch)

Excited to hear what the community thinks about this.

Optionally, we can adapt the export to JSON for use with any ingestion tools like Beats, Logstash, and so on. This way, we can remove the code for exporters and add examples of configuring ingestion tools to the documentation.


Unable to run on latest DAPR version.

Describe the bug
1.) I m using DAPR 0.11.0 but tye automatically runs on 0.7.1.
2.) I don't know because of this problem or other, the app, and the DAPR side car unable to communicate.
To Reproduce
Running without Tye

With Tye

Further technical details
-Tye Version : 0.5.0-alpha.20502.1

To confirm, why did you end up closing this?

@jkotalik it is duplicated.
Somehow GitHub page, not refresh after submit, so I click submit again when I check the issue list it shows me two entries, so I closed this one.
please check this:
https://github.com/dotnet/tye/issues/689


Default HSTS config almost guaranteed to break email links with transactional email - among other things.

HSTS caused me a problem today.  I disabled it in my app about a month ago.  The nginx ingress controller kept serving the header though.
Restarting the nginx-controller stopped serving the header, but some damage was done - HSTS is a horrible idea, especially if you are using a CNAME to 3rd party services for transactional/marketing email and want to do click tracking.
Not sure if this is an issue with nginx or the controller.

HSTS is configurable: https://github.com/kubernetes/ingress/blob/master/controllers/nginx/configuration.md#allowed-parameters-in-configuration-configmap
If you serve your Ingress over https, it is enabled by default.

Hi Pieter, well snap!  That's where it's hiding.
Hey, HSTS is DANGEROUS and having it on by default I think is a HUGE MISTAKE
Here's why I think that, and an example:
Once HSTS is deployed you can't take it back without configuring the individual browsers.  It's dangerous because if you don't understand it and deploy it, you may be suddenly re-architecting around it.  I have services that specifically need to be http, and those are broken for 6 months now for anyone who's ever visited my site.
This problem will also show up for me as a broken signup process - where users couldn't verify their email addresses because the click tracking server replaced the links with https://email.service.com - which doesn't have a cert.
For email deliverability or other 3rd party services, they often want a CNAME.  E.g. email.myservice.com -CNAME-> clicktracker.theirservice.com
The default configuration here silently breaks that for 6 months without any work-around.  I can confirm this for SparkPost, MailChimp, CampaignMonitor, and SendInBlue.  Probably most email providers use CNAMEs for click tracking.
I disabled it in from my app a month ago, only to find out it's reenabled now.
EVERYONE I'VE MARKETED MY SERVICE TOO WILL BE UNABLE TO USE IT FOR 6 MONTHS BECAUSE OF THIS DEFAULT SETTING.  And I'm bummed about that.
Can I suggest either:

Not enabling it by default.  The no-undo is extremely risky behavior.
Lowering the max-age to days not months.
Not including subdomains.  This is how the CNAME works on these services.

This config loaded the gun and shot the foot.  I didn't figure it out it was my foot till a month later.

@MichaelJCole right now you can customize this hsts parameters in the configmap:

hsts-max-age
hsts-include-subdomains

I will add a new parameter to allow disabling the preload
If you need to disable this you can start setting hsts-max-age: 0 in order to avoid/update the time in the browsers and after a while you can remove the hsts feature setting hsts: "false.
About your comments: is almost impossible to build a one size fits all solution (not an excuse, sadly a reality) so the default we choose are based on common use cases that provides the "best" ootb UX. In particular the current hsts values were taken in consideration from this sites:

https://www.owasp.org/index.php/HTTP_Strict_Transport_Security_Cheat_Sheet
https://blog.qualys.com/securitylabs/2016/03/28/the-importance-of-a-proper-http-strict-transport-security-implementation-on-your-web-server
https://mozilla.github.io/server-side-tls/ssl-config-generator/

It is possible to build a one-size-doesn't-cause-hidden-problems-you-can't-walk-back solution, and that would be to not enable HSTS by default.
Thanks for the suggestions, I'll do that.

It is possible to build a one-size-doesn't-cause-hidden-problems-you-can't-walk-back solution, and that would be to not enable HSTS by default.

Sure. You just need to use an ingress controller with a configmap that by default disable the hsts feature.
The default configuration is published here:
https://github.com/kubernetes/ingress/blob/master/controllers/nginx/configuration.md#default-configuration-options

@aledbf, I would have to travel back in time to do that now.  Which is why it's not a good default choice.
Anyways, thanks for your project and attention to this issue.  Have a great week!

Closing. Pease reopen if you have another question.

If you find this, I was wrong about the behavior of setting max-age=0.
https://tools.ietf.org/html/rfc6797 says max-age=0 turns HSTS off, which is the best solution.
Here's my configmap:
apiVersion: v1
data:
  hsts: "true"
  hsts-include-subdomains: "true"
  hsts-max-age: "0"
  hsts-preload: "false"
kind: ConfigMap
metadata:
  name: nginx-load-balancer-conf
---

Note that the preload is dangerous because it implies consent for browser makers to permanently enable HSTS on your site - regardless of headers.  https://www.owasp.org/index.php/HTTP_Strict_Transport_Security_Cheat_Sheet

For anyone (like me) wondering how to disable HSTS for a single ingress while keeping it active for others in the same cluster, the following annotation appears to work:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/ssl-redirect: "false"
    nginx.ingress.kubernetes.io/configuration-snippet: |
      if ($scheme = https) {
        more_clear_headers "Strict-Transport-Security";
      }


Add "short_name" in android manifest

I am trying to define the "short_name" of my app according to the Chrome doc :
https://developers.google.com/web/updates/2014/11/Support-for-installable-web-apps-with-webapp-manifest-in-chrome-38-for-Android
When I add the short_name key in config/favicon.json, the resulting manifest does not show the short_name.

In fact it could be useful to allow any key/value pair in the android chrome manifest part.

I suggest you to use the existing_manifest setting.  Then, you pass it as an existing manifest. RFG will patch it with its own attributes (the icons, etc.). Also use the on_conflict member to specify what should happen when RFG tries to update an existing attribute (eg. for the day RFG generates short_name too).
More about this in the non-interactive API doc.

Thank you Philippe, it works perfectly.

Great! Thanks for closing this one :)


Discussion: Remove Parallel=Subdir feature

Parallel=Subdir feature was introduced before we had actual parallelization (i.e., Parallel=Dynamic or NodesByIterations). At that time, we ran tests in parallel according to subdir, which was used for external tests only. With the actual parallelization (i.e., Parallel=Dynamic), we do not use Parallel=Subdir feature anymore. The external tests are updated to use Parallel=Dynamic. As far as I know, this Parallel=Subdir feature is no longer used. I would like to propose removing this feature from our code base.
By removing Parallel=Subdir feature, it will make Parallel logic more simple and easy to add the enhancements (such as https://github.com/adoptium/aqa-tests/issues/4093 and https://github.com/adoptium/aqa-tests/issues/3986)

I think this seems like a wise course of action.  We no longer need this feature and removing it removes complexity and potential tech debt of supporting an unused feature.


Check layout instead of style before setting height and width to whatever is set in layout

isDimDefined checks is node.style[axis] is defined while in these places we do not care about node.style[axis] but node.layout[axis]. This caused parent height not to be correctly propagated to children.

Can you add a test case?

@vjeux will do

@emilsjolander Does this fix alone that bug with a specific height being passed to the measure function?

@lucasr no. that is more a limitation than a bug

@vjeux rebased to include test case. Also changed implementation to avoid some duplicate logic.

nvm this broke a lot of things in the transpiling. Fixing.

Nice, thanks!


The best approach to training several times

Let's say I trained a DreamBooth network with 30 images and 3000 steps. Saved in .ckpt
Then I got another set of 30 images. I don't have the opportunity/time to fully retrain the network on a more complete set of 60 images.
How should I change the training parameters (learning rate, number of steps) if I want to continue training on a new set? Do I need to train the text encoder again?
In short, give good advice, if anyone has any.

if the second batch of images are for a different subject with a different instance name, you will need to resume the training for the full steps (3000 in your case + textenc). if the learning rate is above 8e-6 up to 2e-5, keep the number of unet steps below 1500

Thx for answer. But in my case its same subject and instance name. What do you recommend?

If it's the same subject, resume the training with a lower learning rate and skip the text encoder


merge from konsum-frontend-svelte

package.json

chore(deps): add ^3.53.0 remove ^3.52.0 (devDependencies.svelte)

:tada: This PR is included in version 1.34.11 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.34.11
GitHub release

Your semantic-release bot :package::rocket:


Is it possible to change the current page programmatically?

Currently, I have tried the following:
paginationFactory({ page: 4 });
paginationContext.currPage  = 4;
Very frustrating as seems that all the examples work with either of these, but in my unfortunate case it doesn't work. What does happen is the currPage is set to 4 but the actual pagination on the interface isn't!

This could be a simple thing, why isn't it? Becoming increasingly frustrated by how challenging it is to simple update the page number on render of a component. Wow.

See https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/1634#issuecomment-1513062293 maybe you'll find a solution.


SSL Proxying List Tool

Description
We should implement the Include List of the SSL Proxying List Tool. It's important to tell Proxyman which domain/apps should be intercepted.
Doc: https://docs.proxyman.io/basic-features/ssl-proxying

Acceptance Criteria

Implement the SSL Proxying List UI (Only the Include List, and Exclude List will be done in separate tickets)
Able to add the Domain / App
Save the data to disk and load it at launch
Enable a Tool (Checkbox on the top)
Enable each rule (Checkbox on each rule)
Support Multiple selections

Every website & web these days communicate via SSL. I think this feature should be turned on by default.

Sorry @shirshak55 but I decide to not turn all by default.
If Proxyman decrypts all HTTPS traffic by default, it significantly slows your computer performance. It also adds a bunch of unnecessary requests to the apps that make them really difficult to use.
We strigly follow the design of "Proxyman for macOS".

Requirement Updates

Use Data Grid Pro to implement the table view
Implement the SSL Proxying Service as the Preudo code
The JSON file is persisted on User Data Folder
Support only Domain

Pseudo Sample

app-directory.ts

const getUserData = () => {
  const appPath = getAppFolderPath();
  return path.join(appPath, 'user-data');
};

SSL

class SSLEntry {

  isEnabled: boolean;
  name: string;
  type: SSL_TYPE
}

class SSLService {
  isEnabled: boolean
  entries: SSLEntry[];

  constructor() {
    // load a entries from a JSON
    const data = DiskStorage.loadJSON('ssl-proxying-service');
    this.isEnabled = data.isEnabled ?? true
    this.entries = data.entries ?? []
  }

  addEntry(entry: SSLEntry) {
    // add entry if it doesn't contain in the list

    // sync
    this.sync();
  }

  remove(entry: SSLEntry) {

  }

  isMatched(entry: SSLEntry) {
    // iterate the entries and check if it's matched
  }

  sync() {
    // save the entries to list as a json
    const data = {
      isEnabled,
      entries
    }
    DiskStorage.writeJSONFile('ssl-proxying-service', data);
  }
}

class DiskStorage {
  static async loadJSON(name) {
    const path = getUserData();
    const data = await fs.readFile(`${path}/${name}.json`, {
      encoding: 'utf8',
    });
    return JSON.parse(data);
  }

  static async writeJSONFile(name, json) {
    const path = getUserData();
    let data = JSON.stringify(json);
    await fs.writeFile(`${path}/${name}.json`, data);
  }
}

export default new SSLService();

Update requirement:

Write a Unit Test for SSL Proxy Service.


fix(upgrade): take prereleases into account

If users got a prerelease version installed and want to upgrade to the formal release version, the version checking should let them pass. For example, upgrading from v1.1.0-rc3 to v1.1.0 should not be blocked by the version-checking mechanism, though such behaviors are not recommended.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Users reported the upgrade from v1.1.0-rc3 to v1.1.0 will fail with the following message:
The current version v1.1.0-rc3 is less than the minimum upgradable version v1.0.3.

Solution:
This change contains two parts:

the upgrade controller, will only take effect after the next upgrade

according to the document of the library we leveraged, a suffix is essential to make the comparisons become prerelease-aware

the upgrade script, takes effect in the next upgrade

the version sorting is good enough, just added some additional handling about rc versions

Related Issue:
#3040
Test plan:
Test case 1

Prepare a v1.1.0-rc3 Harvester cluster with any number of nodes
Kickstart the upgrade to v1.1.0 (contain this PR)
The upgrade should continue til the end and not be blocked by the version checking

The following message should not show up in the condition of the upgrade CR:
The current version v1.1.0-rc3 is less than the minimum upgradable version v1.0.3.

The following line should not show up in the logs of any upgrade Jobs:
Current version is not supported. Abort the upgrade.

Test case 2

Prepare a v1.0.3-rc2 Harvester cluster with any number of nodes
Kickstart the upgrade to v1.1.0 (contain this PR)
The upgrade should be blocked by the version checking since v1.0.3-rc2 is older than v1.0.3, the required minimum upgradable version

The following line should show up in the logs of the apply-manifest Job:
Current version is not supported. Abort the upgrade.

Reopen this because we need to go through "upgrade to the same version" scenarios to verify some upgrade-related features/fixes.

After discussing with @guangbochen and @bk201, we decide to go with a simpler plan: adding "-0" suffix to minUpgradableVersion in package/upgrade-matrix.yaml while cutting future pre-releases. This will lift the restriction to RC versions' upgrade and keep the code of the upgrade controller and the script untouched.

A new issue #3633 occurred while testing upgrades from v1.1.0 to v1.1.2-rc2 after we applied the fix mentioned above.
Since adding a "-0" suffix to minUpgradableVersion in package/upgrade-matrix.yaml only partially addresses the original issue from the controller side, we're reopening this PR to solve the issue for both the controller and the scripts.

@mergifyio backport v1.1


Redis caching server + breakup

This PR breaks the caching part of the backend into a fulltext search -enabled Redis server.

Note that we still use DynamoDB, for the users table.
After this it just will not be used for caching.

Binaries +config to start the redis-server: https://github.com/webaverse/redis-server


Package correction to avoid compilation error

Classes moved to the relevant package

@visruth looks like it needs rebase

@vargasx hope it's fine now!


xfreerdrp Crashes with segfault in find_keyboard_layout_in_xorg_rules

Hi,
I completed compiling just the freerdrp package on Ubuntu Gnome 15.04, using this guide: https://github.com/FreeRDP/Remmina/wiki/Compile-on-Ubuntu-14.04-and-14.10. The build was successful only after adding libgstreamer-plugins-base1.0-dev as a dependency. I can add this in the page, just let me know.
This particular problem has been around since 2011 and has been reported on Launchpad: https://bugs.launchpad.net/ubuntu/+source/remmina/+bug/753520. Both GDB and Valgrind logs are attached to the bug report. In summary xfreerdp fails to load if the keyboard XKBLAYOUT is set to "za" or "mao" in /etc/default/keyboard, but setting it to "us" seems to make it work again.
This particular problem is fairly trivial to reproduce, but if you need more information let me know. Just using xfreerdp built from source produces:
(gdb) run +clipboard /sound:rate:44100,channel:2 /v:<ip/host> /u:<user>
Starting program: /usr/local/bin/xfreerdp +clipboard /sound:rate:44100,channel:2 /v:<ip/host> /u:<user>
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7fffecbf1700 (LWP 27493)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffecbf1700 (LWP 27493)]
0x00007ffff5d13232 in find_keyboard_layout_in_xorg_rules (layout=0x7fffe801ad70 "za", variant=0x7fffe801aff0 "") at /home/bruce/dev/desktop/FreeRDP/libfreerdp/locale/xkb_layout_ids.c:913
913				for (j = 0; xkbLayouts[i].variants[j].variant != NULL && strlen(xkbLayouts[i].variants[j].variant) > 0; j++)
(gdb) bt
#0  0x00007ffff5d13232 in find_keyboard_layout_in_xorg_rules (layout=0x7fffe801ad70 "za", variant=0x7fffe801aff0 "") at /home/bruce/dev/desktop/FreeRDP/libfreerdp/locale/xkb_layout_ids.c:913
#1  0x00007ffff5d13514 in detect_keyboard_layout_from_xkbfile (display=0x7fffe800e5a0, keyboardLayoutId=0x7fffecbf082c) at /home/bruce/dev/desktop/FreeRDP/libfreerdp/locale/keyboard_xkbfile.c:409
#2  0x00007ffff5d13373 in freerdp_keyboard_init_xkbfile (keyboardLayoutId=0x7fffecbf082c, x11_keycode_to_rdp_scancode=0x7ffff6047540 <X11_KEYCODE_TO_VIRTUAL_SCANCODE>) at /home/bruce/dev/desktop/FreeRDP/libfreerdp/locale/keyboard_xkbfile.c:347
#3  0x00007ffff5d11bcd in freerdp_keyboard_init (keyboardLayoutId=0) at /home/bruce/dev/desktop/FreeRDP/libfreerdp/locale/keyboard.c:112
#4  0x00007ffff7b49118 in xf_keyboard_init (xfc=0x60f000) at /home/bruce/dev/desktop/FreeRDP/client/X11/xf_keyboard.c:116
#5  0x00007ffff7b4fae8 in xf_pre_connect (instance=0x60ed20) at /home/bruce/dev/desktop/FreeRDP/client/X11/xf_client.c:971
#6  0x00007ffff5d47575 in freerdp_connect (instance=0x60ed20) at /home/bruce/dev/desktop/FreeRDP/libfreerdp/core/freerdp.c:75
#7  0x00007ffff7b515dd in xf_thread (param=0x60ed20) at /home/bruce/dev/desktop/FreeRDP/client/X11/xf_client.c:1467
#8  0x00007ffff760c3e3 in thread_launcher (arg=0x695ad0) at /home/bruce/dev/desktop/FreeRDP/winpr/libwinpr/thread/thread.c:259
#9  0x00007ffff55770a5 in start_thread (arg=0x7fffecbf1700) at pthread_create.c:309
#10 0x00007ffff72c090d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) quit

Thanks

@octoquad what version of FreeRDP are you using? Latest git master?

@bmiklautz Yes. This was originally reported here https://github.com/FreeRDP/Remmina/issues/441 roughly a month ago.

@octoquad I'm looking at the code and I suspect what's going on

@octoquad https://github.com/FreeRDP/FreeRDP/issues/2511 should fix your bug

@hardening, thanks. Can you confirm if this also fixes the mao (Maori) layout as well? I didn't see it in the patch. When I get a chance, I'll test your patch and confirm if everything is good.
Thanks for taking the time fix this :)

Hum it should not crash with Maori, but if you want the "good keyboard" (tm) you may give me the kind of keyboard that is used for maori.

Works fine. Thanks :)

@octoquad but do you get the correct keyboard, I mean do you have the right keys ?

I can't confirm mao, but I will check za. I was confirming that the xfreedrp doesn't crash on any command provided with XKB_LAYOUT set to za, which is what was happening before this fix. ZA and US layouts are pretty similar.

Mchrfin
Le 9 avr. 2015 22:22, "Bruce Pieterse"<EMAIL_ADDRESS>a écrit :

I can't confirm mao, but I will check za. I was confirming that the
xfreedrp doesn't crash on any command provided with XKB_LAYOUT set to za,
which is what was happening before this fix. ZA and US layouts are pretty
similar.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeRDP/FreeRDP/issues/2399#issuecomment-91370861.

@cgholam what do you mean with "Mchrfin" ?

Orido.zawj
بتاريخ Apr 10, 2015 10:12 AM، كتبها "Bernhard Miklautz" <
<EMAIL_ADDRESS>
@cgholam https://github.com/cgholam what do you mean with "Mchrfin" ?
—
Reply to this email directly or view it on GitHub
https://github.com/FreeRDP/FreeRDP/issues/2399#issuecomment-91505799.

Hi,
Apologies for the late response. Yes all keys work correctly.
Thanks


feat: Add academic exchange experience to about section

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Flow" is still frequently used as the product name

This page contains multiple references to "Flow" instead of "Power Automate". There are headers like "Administration of Flow" and "Can I block another person from using the paid features of Flow?" This seems outdated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c23aa79-64e4-9488-b528-af781d7b456e
Version Independent ID: aacc4f60-044f-d587-9dde-8a48168c59e7
Content: Power Automate sign-up Q&A in your organization - Power Automate
Content Source: articles/organization-q-and-a.md
Service: flow
GitHub Login: @stepsic-microsoft-com
Microsoft Alias: stepsic

I have updated this article & swept the repo for references to Flow as a product name. Flow is still valid within power automate, as you still create a 'flow' in PA.


Incorrect W0017 warning

Describe the bug
A fully qualified function call to the current module incorrectly triggers a W0017 (function is undefined) warning.
Furthermore, the doc page of the warning has an incorrect title. It says Unused Function while it should be Undefined Function.
To Reproduce**
Type this into VS Code:
-module(elp_w0017).
-export([loop/0]).

loop() ->
  timer:sleep(1000),
  ?MODULE:loop().

Expected behavior
There shouldn't be any warnings reported in this module.
Actual behavior
The last line is marked with W0017.
Context

ELP Version (output of elp version): elp 1.1.0+build-2024-04-17
Editor used: VS Code with v0.21.0 extension

I am unable to reproduce the warning.  I tried pasting your code into an existing valid erlang project, into an empty directory, and creating a test for it. None of these showed the problem.
And I will update the docs, thanks.
Please provide more specific instructions to re-create the error.

Hmm... It doesn't always work for me either. I have created this file as /home/dszoboszlay/elp_w0017.erl. If I close VS Code and type code elp_w0017.erl in a shell then first of all VS Code loads the file in restricted mode, but once I say I trust the authors, I get the error.
However, if I close the file in VS Code and then open the file again, I don't get the error any more.
Closing VS Code and typing code elp_w0017.erl again can reproduce the error.
Quite confusing, to be honest.

I tested it by making ~/fff and putting the file in there.
I am not prepared to give VS Code trust access to my entire home directory.

I don't think the directory would matter. I was initially suspecting that a space in the path could have been relevant, but it isn't.
I think what's important is that elp has to be started by VS Code directly for that file. So once elp is running, closing and reopening the file will not trigger the bug. But this may also be some race condition that depends on e.g. number of CPU cores in my machine and what other plugins VS Code is trying to start up in parallel. Is there a way to make elp log what is it doing? Currently it doesn't log anything for me. So it's hard to figure out what's the difference between the first and second opening of the file.

It logs to stderr by default, which VS Code shows in the output pane.

And I am looking into why we cant set the log level, and why our config settings show up a "Example configuration".
There is plenty of opportunity for people to improve the extension code, it is not high priority for us, as we have a custom internal one.

For me elp doesn't log anything (even if I redirect it to a file, I only get an empty file) and this output doesn't show up.
But I see this in the Extension Host output (when log level is set to trace):
2024-04-22 13:16:29.122 [info] ExtensionService#_doActivateExtension erlang-language-platform.erlang-language-platform, startup: false, activationEvent: 'onLanguage:erlang'
2024-04-22 13:16:29.122 [trace] ExtensionService#loadCommonJSModule file:///home/dszoboszlay/.vscode/extensions/erlang-language-platform.erlang-language-platform-0.21.0-linux-x64/client/out/extension
2024-04-22 13:16:29.123 [trace] ExtensionService#loadExtensionContext erlang-language-platform.erlang-language-platform
2024-04-22 13:16:29.164 [trace] ExtensionService#_callActivateOptional erlang-language-platform.erlang-language-platform
2024-04-22 13:16:29.171 [trace] [vscode.git] INVOKE provider 'Q=>Q.provideLinks(p.URI.revive(V),X)'
2024-04-22 13:16:29.172 [trace] [vscode.git] provider DONE after 1ms
2024-04-22 13:16:29.195 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'Q=>Q.provideDocumentSymbols(p.URI.revive(V),X)'
2024-04-22 13:16:29.195 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'we=>we.provideCodeActions(p.URI.revive(V),X,Q,ge)'
2024-04-22 13:16:29.199 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'ge=>ge.provideInlayHints(p.URI.revive(V),X,Q)'
2024-04-22 13:16:29.347 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'ge=>ge.provideDocumentRangeSemanticTokens(p.URI.revive(V),X,Q)'
2024-04-22 13:16:29.392 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 197ms
2024-04-22 13:16:29.392 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 197ms
2024-04-22 13:16:29.392 [trace] [InlayHints] NO inlay hints from 'erlang-language-platform.erlang-language-platform' for range {"startLineNumber":1,"startColumn":1,"endLineNumber":7,"endColumn":1}
2024-04-22 13:16:29.392 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 193ms
2024-04-22 13:16:29.392 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 45ms
2024-04-22 13:16:29.495 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'Q=>Q.provideDocumentSymbols(p.URI.revive(V),X)'
2024-04-22 13:16:29.496 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 1ms
2024-04-22 13:16:29.496 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'ge=>ge.provideFoldingRanges(p.URI.revive(V),X,Q)'
2024-04-22 13:16:29.497 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 1ms
2024-04-22 13:16:29.571 [trace] [erlang-language-platform.erlang-language-platform] INVOKE provider 'Q=>Q.provideCodeLenses(p.URI.revive(V),X)'
2024-04-22 13:16:29.571 [trace] [eamodio.gitlens] INVOKE provider 'Q=>Q.provideCodeLenses(p.URI.revive(V),X)'
2024-04-22 13:16:29.572 [trace] [eamodio.gitlens] provider DONE after 1ms
2024-04-22 13:16:29.572 [trace] [vscode.merge-conflict] INVOKE provider 'Q=>Q.provideCodeLenses(p.URI.revive(V),X)'
2024-04-22 13:16:29.572 [trace] [erlang-language-platform.erlang-language-platform] provider DONE after 1ms
2024-04-22 13:16:29.573 [trace] ExtHostCommands#executeCommand setContext
2024-04-22 13:16:29.573 [trace] ExtHostCommands#executeCommand _setContext
2024-04-22 13:16:29.574 [trace] [vscode.merge-conflict] provider DONE after 2ms
2024-04-22 13:16:29.640 [trace] [DiagnosticCollection] change many (extension, owner, uris) erlang-language-platform.erlang-language-platform _generated_diagnostic_collection_name_#3 [[{"$mid":1,"external":"file:///home/dszoboszlay/A1/B%202/elp_w0017.erl","path":"/home/dszoboszlay/A1/B 2/elp_w0017.erl","scheme":"file"},[{"startLineNumber":6,"startColumn":3,"endLineNumber":6,"endColumn":17,"message":"Function 'elp_w0017:loop/0' is undefined.","source":"elp","code":{"value":"W0017","target":{"$mid":1,"path":"/erlang-language-platform/docs/erlang-error-index/w/W0017","scheme":"https","authority":"whatsapp.github.io"}},"severity":4,"modelVersionId":1}]]]

You need to select Erlang Language Platform in the top right selector box of the Output pane, as in my example.
And I have a new release coming that lets you set logging in more detail

@dszoboszlay I cannot reproduce this either. Did you manage to get the logging working, so we can have a look at what's happening for you?

@alanz @dszoboszlay
I was too fast. I can indeed reproduce this. Here are the steps.

Add the above file to a new folder (e.g. /tmp/something)
Open VS Code (/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/bin/code)
Trust the newly created folder (Workspaces: Manage workspace trust -> Add /tmp/something
Open the folder (File -> Open folder... -> /tmp/something)
Navigate to elp_w00017.erl, the only file in the folder
ELP starts correctly
Switch to the CLI, open the same file (/Applications/Visual\ Studio\ Code.app/Contents/Resources/app/bin/code /tmp/something/elp_w0017.erl)
A bunch of warnings and errors appear, ELP crashes

Reason:
no value set for SourceRootQuery(SourceRootId(38))


Modernize table appearance

What feature do you want to see added?
The plugin uses the legacy bigtable design in https://github.com/jenkinsci/cloud-stats-plugin/blob/a4f9085f3daf2f673743e836512a72bee28f6bd0/src/main/resources/org/jenkinsci/plugins/cloudstats/CloudStatistics/index.groovy#L47 still.
To comply with the overall table design used in modern Jenkins, the plugin could make use of jenkins-tables, as documented in https://weekly.ci.jenkins.io/design-library/Table/
Upstream changes
No response

Hi @NotMyFault ,
This ticket looks good to me for getting started as a contributor.
Can I take this up?

For sure!


Adding home route to the logo  in navbar

The logo icon in the navbar when clicking doesn't head to the home route also the curson is not a pointer

We have a Home button so there is no need to route to home.


[NSTimeZone] Add implementation of abbreviation property and tests

Add implementation of NSTimeZone's abbreviation property getter.
Add a test case for the above implementation.

looks good to me


Add Cilium feature list to docs

Description of changes: Add a list of Cilium features supported in EKS Anywhere to documentation. This content is an updated version of the Editions: Open source and Enterprise section of the Isovalent Cilium product page.

I replaced the PR with PR #7065


feat(kubernetes): add support for custom docker0 net

What this PR does / why we need it:
Resolves an issue where egress could be blocked by the iptables route for the docker0 network on the masters and agents if the ingress IP is within the same subnet selected for docker0 by default.
Closes: #750

This change is

@dmccaffery,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@dmccaffery, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

CLA is signed and rebased -- let me know if this can be merged, or if anything else is required.
Thanks!

@JackQuincy can this get reviewed? I'll rebase again, but I don't want to keep doing it if I don't have to, lol.

Is there an accompanying issue for this? If so can you link it here. If not can you make one so that we can talk design there?  Normally networking changes like these we put behind a flag. Though I must admit I am not familiar with custom docker0 net

@JackQuincy Its linked in the PR, but it is #750

@JackQuincy fixed and rebased -- ready for merge.

@JackQuincy @seanknox updated: you can view the diff while ignoring whitespace here:
https://github.com/Azure/acs-engine/pull/753/files?w=1

@acs-bot test this please

@dmccaffery can you run make build to regenerate template.go?

@seanknox I did (I always do when I rebase), but I'll double check.

crap; you're right... 🤕 -- just pushed it; sorry about that.

@acs-bot test this please


Minimum b-factor value

Hi again!
Your fix for the TER statements works fine but I realized that another issue cropped up: I use the occupancy and b-value columns to assign atom to regions in QM/MM calculations. As such, most of the values are necessarily zero. I realize that this is contrary to the intended use of the b-value column but this behavior breaks my use case.
I'm not sure what a good solution might be here. Maybe b-values of 0.00 could be allowed (with warnings shown perhaps) with StrictnessLevel::Loose for open_pdb?
I'm currently in the process of refactoring my code to use this crate and it would be a pity if this excluded the possibility.

I do not remember coding anything anywhere that would prevent B factors or occupancies to be 0.00. I ran some tests and you can totally use atom.set_b_factor() and atom.set_occupancy() to set those properties to 0.0. And the following very minimal PDB file was parsed and saved successfully:
ATOM      2  CA  HIS A 465      34.226 -11.294   7.140  1.00  0.00           C
ATOM      3  C   HIS A 465      33.549 -10.658   8.347  1.00  0.01           C
ATOM      8  CD2 HIS A 465      35.297  -8.322   5.762  0.00 49.56           C
ATOM      8  CD2 HIS A 465      35.297  -8.322   5.762  0.01 49.56           C

If you have any error messages you could share with me I will dive into it, but otherwise I do not see any problem. Besides that the B factor column is 'misused' quite often for other things then the b factor, so the library should totally support any logical numerical value.

I swear this issue was real... I just ran my code again and it ran through without issue.
Sorry for bothering you about this, I think I should maybe stop for today.


Couple small issues in Integration project

PR for Issue #54

Also, I have ran the majority of the Integration unit tests and all green so far-- they take a long time to run.


Add free functions for decoding collections

In Argo 2 we removed the free functions decodeArray and decodeObject
in favor of adding this functionality to the types themselves. I believe
this was a mistake and would like to reintroduce them to the public API.
My reasoning is this:
Adding decode to these types does not make these types conform to
Decodable. That's confusing to me (and I'd imagine, other people). The
result of this is that you can't just decode directly to these types,
but instead have to use a special function. In the case of Array
that's not a huge deal since we expose an operator (<||) for this, but
for decoding objects, it means that users have to specify the actual
type that they'd like to decode. This is weird, since it's the only
place in the public API that we don't let users lean on the type system
to do the hard work for them.
I think it makes the most sense to reintroduce these free functions
without actually removing the existing protocol extensions. This will
improve backwards compatibility with Argo 1 and improve what I see as a
deficiency in the current API. In addition, if Swift ever gets the
ability to do conditional protocol conformance, leaving the existing
protocol extensions will make it easy to support that as well.
See #296 for an example of where we've made a user's code worse with the new
API.

:+1:

:+1:


Database taps: metadata not honored

after upgrading, the workflows that were running fine so far now fail with Extractor failed: Unrecognized replication_method None. I did meltano config tap-postgres--orchest-dashboard set _metadata '*' replication-method FULL_TABLE again just in case, still fails (which makes sense, because nothing changed in meltano.yml).

Duplicate of https://github.com/meltano/meltano/issues/3322


fix yaml keys

Addresses:
https://github.com/rancher/rancher/issues/15098

Small formatting thing but logic looks good

Thanks, @dramich. Fixed the formatting issue.


xlang-code-interpreter-python

where is the “xlang-code-interpreter-python” code。please，thks

Hi, we didn't release the code of the interpreter docker. However, we've uploaded the docker to dockerhub. Is it sufficient for your use?


Add delete by name

Added Ability to delete students by name
Updated Respective tests as well
Closes #99

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...seedu/edulog/logic/commands/DeleteNameCommand.java
28.57%
15 Missing :warning:

...seedu/edulog/logic/parser/DeleteCommandParser.java
60.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ
Complexity Δ

src/main/java/seedu/edulog/logic/Messages.java
87.50% <ø> (ø)
3.00 <0.00> (?)

...ava/seedu/edulog/logic/commands/DeleteCommand.java
100.00% <100.00%> (ø)
1.00 <1.00> (?)

...eedu/edulog/logic/commands/DeleteIndexCommand.java
100.00% <100.00%> (ø)
7.00 <7.00> (?)

...ain/java/seedu/edulog/logic/parser/ParserUtil.java
58.73% <100.00%> (ø)
15.00 <1.00> (?)

...seedu/edulog/logic/parser/DeleteCommandParser.java
77.77% <60.00%> (ø)
3.00 <2.00> (?)

...seedu/edulog/logic/commands/DeleteNameCommand.java
28.57% <28.57%> (ø)
2.00 <2.00> (?)


Support @position-fallback.

 Handle position-fallback @try blocks.

@sanajaved7 @mirisuzanne I think this is now complete for basic @position-fallback functionality, and ready for code and/or functional review! ✨
Remaining items (include new spec changes) are documented at the bottom of the README, and some have Trello cards as well.

It's interesting when I load it in arc (with experimental web platform features), I'm told that I don't need the polyfill - but it sure seems like we support more features than they do at this point.

Interesting! We're testing for support with 'anchorName' in document.documentElement.style, but maybe we want to be more specific?

Interesting! We're testing for support with 'anchorName' in document.documentElement.style, but maybe we want to be more specific?

Yeah, but probably not worth the effort for an experimental implementation. We could add that in if some browser actually ships a partial feature?


Dirty marker does not appear anymore

open Kaoto editor
add a step
--> the editor should become dirty and it is not

reproduced with Kaoto UI f6875efe866786ca25d9001e01d0df67db17d82d

I feel it is due to the Patternfly react core upgrade, in kie tools they had to change a bunch of things https://github.com/kiegroup/kie-tools/commit/0c8199f7de05429489f6f61feeb9bdb52e89f6eb

dirty marker working with https://github.com/KaotoIO/kaoto-ui/commit/95074d871ffb4e4ba2de39d17687f489ef31bee3

argh, I will need to retest each commits. it seems that the dirty marker is working when the initial content is not empty but not working when the initial content is empty.

the problem appeared with https://github.com/KaotoIO/kaoto-ui/commit/97f3d25d4ef7661b0a2bc5287d705fc4bd549b54
it is really only when starting with an empty file. If the file is not empty, it is still working correctly.


3.6 sanity-check pipeline starting failure

When I walk through "3.6 sanity-check pipeline:, I opened the .pipeline file, and imported the sanity_check.yaml , then, at step 8, I would expect a popup window like the following first snapshot , but, it jumped to a "cannot run pipeline" window like the following second snapshot. and Fail to continue!!!!

close.


Increased packets sanity check limit to 1024

For some simulations with big values for VLEN (e.g. 8k and 16k) there were more packets created on the fly and, as a consequence, failing the simulations. The sanity check has been increased in order to solve this high VLEN cases.
Supervised by @aarmejach
Change-Id: I137b0f3113687b3fc9c4154d19ca5e8017e6e992

It's worth noting that the packet queue exploding like this is potentially a big problem in terms of simulation accuracy. 1024 packets holding 64B cache lines would be equivalent to 64KiB of magic cache (behaving a lot like a low-latency L1 cache) that lives in non-intuitive places. That's quite a lot of memory that users won't know about. The reason this limit was set pretty low (I think it used to be lower than 128) was to avoid artificially increasing the amount of "invisible" caching in the system.
The "right" way of dealing with this would be for components that use the PacketQueue to apply throttling when packets when packets are getting backed up. Effectively, the panic triggering is indicative of a modelling bug.

This is a change that people have been requesting for a long time. I think we should merge it, despite the potential issues.

The reason this limit was set pretty low (I think it used to be lower than 128) was to avoid artificially increasing the amount of "invisible" caching in the system.

I strongly agree with this statement! However, in many cases the packet queue is used where there actually already is modeling of the buffers/caching. For instance, in the memory controllers, there is a packet queue on the response, but it is correctly modeled in the read/write queues on the request side.
I think the better solution would be to remove the packet queue from gem5 completely and put correct backpressure modeling throughout the system, but that's unlikely to be completed anytime soon. In the meantime, there's many use cases (vectors, GPUs, etc) where we need to support up to 1TB/s or more of bandwidth, and the packet queue limit is a perennial pain in these common use cases.

This is a change that people have been requesting for a long time. I think we should merge it, despite the potential issues.

I'm a bit worried that this will just hide the problem and lead to weird unforeseen consequences, but we need some sort of short-term hack that avoids panics. Would it be better to use the current level (128 entries) as a warning? We could also consider adding a panic with a higher, configurable, threshold that the component owning the queue can set.

The reason this limit was set pretty low (I think it used to be lower than 128) was to avoid artificially increasing the amount of "invisible" caching in the system.

I strongly agree with this statement! However, in many cases the packet queue is used where there actually already is modeling of the buffers/caching. For instance, in the memory controllers, there is a packet queue on the response, but it is correctly modeled in the read/write queues on the request side.

A short term fix would be to suppress the sanity check in such cases. It'd be interesting to understand how common this pattern is. It seems like a deeper queue wouldn't necessarily affect the modelling accuracy in these cases.

I think the better solution would be to remove the packet queue from gem5 completely and put correct backpressure modeling throughout the system, but that's unlikely to be completed anytime soon. In the meantime, there's many use cases (vectors, GPUs, etc) where we need to support up to 1TB/s or more of bandwidth, and the packet queue limit is a perennial pain in these common use cases.

Would it make sense to make the check configurable using a (global?) option to support these use cases? Increasing the limit to something big enough to cover this use case seems like it defeats the purpose of the check for the majority of users.

I don't have a strong preference on this either way, but I have a few comments that might be relevant here.  For reference, the comments on this change when it came up previously (2018) was:  why not just disable the sanity check for your specific simulation?
Regarding parameterizing it, I vaguely recall attempting to do this and it was a bit difficult because the PacketQueue is not a SimObject.  I think trying to add the plumbing to pass down the value was not straightforward too.
I think the packet queue is only used in the Queued*Ports.  In the GPU model at least, we do not use these. I did a quick grep and couldn't find them in the configs/ directory either.  I basically agree that we should prefer modeling true back pressure and not have magic buffers.  But that would be a much larger change.

I don't have a strong preference on this either way, but I have a few comments that might be relevant here. For reference, the comments on this change when it came up previously (2018) was: why not just disable the sanity check for your specific simulation?
Regarding parameterizing it, I vaguely recall attempting to do this and it was a bit difficult because the PacketQueue is not a SimObject. I think trying to add the plumbing to pass down the value was not straightforward too.

Yes, this is definitely an issue. One option we should consider is making this a global simulation option. It's a bit of a hack, but we could add a param in the system or root object. The former would require a change in the API since there is currently no way of accessing the system from PacketQueue. It might be worth making this change for other reasons like checking the memory mode. We should probably make the default limit configurable as well if we have the ability to pass options to the queue.


Corp chat message

Added toggle for chat messages and changed the color to pink as suggested. #5568

Wait now thinking about this, looks like the color is already configurable via Chat Color plugin..

But wouldn't that also change the kc chat color?

Yeah

Actually, the in-game one? probably not

So, should I just close this PR and open another one for the previous commit?

you can just remove the color related changes I guess

There :)


Two way binding on the output

Hi,
It could be great if the output-model would bind in the two way. If I clear my model, I would like the directive unselect all entries in the UI.
Thanks in advance

That doesn't sound reasonable. The output model is, as it's name suggest, an output data. It shouldn't interact with the widget. If you want to unselect all items, do it using the input model.

It makes sense. I'm going to fix my problem. Thanks

;)
Anyways, I'm planning on adding some helpers to the API. A few methods that would let you (un)select all or an item by ID, programatically. Expect it by the end of the week.

ok, cool :)


ADL location in resnet & pytorch implementation

First of all, great paper, and thank you for providing the tf implementation,
I was wondering about the correct locations to add the ADL module in a Resnet, in the command you only gave VGG example (end of block 3 & 4 and layer 53), but for resnet I see that you only apply ADL at the beginning of each Resnet block, can you please specify the best location to add ADL in this case.
Also, I am curious if the pytroch implementation will be available soon or it'll take some time (maybe I can start implementing it in this case).

Thanks for your interest in our work.
I am sorry for the delay of releasing more detailed instruction and pytorch implementation. I think that it will take about a month to release them because I am totally occupied by other projects now.
For the ResNet, we apply ADL blocks to first residual blocks of group 3&4 and right before the global average pooling layer.
You can use this:
python CAM-resnet.py --gpu 0 --data /notebooks/dataset/ILSVRC2012/ --imagenet --base-lr 0.1 --logdir ResNet_ImageNet --load ResNet --batch 128 --depth 50 --mode se --attdrop 31 41 5 --threshold 0.90 --keep_prob 0.25

Thank you.

Hi, sorry asking the same question again, but can you please provide the value of the argument --ADL-position for Resnet in the Pytorch version, I tired using "31 41 5" but its seems the function make_cfg expects 4 values.
Thanks

Hi, we are sorry for your inconvenience. Currently, the location numbers in pytorch version is not consistent with those of tensorflow version (In pytorch version, we use zero-based numbering).
You can use this:
gpu=0,1
name=resnet
epoch=200
decay=60
model=resnet50_ADL
server=tcp://<IP_ADDRESS>:12345
batch=128
wd=1e-4
lr=0.01
ADL_pos="30 40 42"
data_root="../CUB_200_2011"

CUDA_VISIBLE_DEVICES=${gpu} python train.py -a ${model} --dist-url ${server} \
    --multiprocessing-distributed --world-size 1 --pretrained \
    --data ${data_root} --dataset CUB \
    --train-list datalist/CUB/train.txt \
    --test-list datalist/CUB/test.txt \
    --data-list datalist/CUB/ \
    --task wsol \
    --batch-size ${batch} --epochs ${epoch} --LR-decay ${decay} \
    --wd ${wd} --lr ${lr} --nest --name ${name} \
    --use-ADL --ADL-thr 0.90 --ADL-rate 0.75 --ADL-pos ${ADL_pos}

Thank you very much.


[CLOUDSTACK-10039] Adding IOPS/GB offering

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

We want to add a disk offering where we can specify the Min/Max IOPS as a function of size. The idea is the larger volume you create, the greater your IOPS will be (this is similar to the way GCE handles IOPS). We also have added limits to the IOPS (min and max) so that once the volume goes beyond a certain size, the IOPS won't change and are capped to the given values.
The following parameters are added to the createDiskOffering API:

`miniopspergb' : Minimum IOPS/GB for the offering
maxiopspergb: Maximum IOPS/GB for the offering
highestminiops: The highest miniops value that is allowed for this offering
highestmaxiops: The highest maxiops value that is allowed for this offering

Could you resolve the conflict @syed ?

ACS CI BVT Run
Sumarry:
Build Number 1126
Hypervisor xenserver
NetworkType Advanced
Passed=109
Failed=5
Skipped=12
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
Failed tests:

test_router_dnsservice.py

test_router_dns_guestipquery Failed

test_routers_network_ops.py

test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 124 runs

test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 124 runs

test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 120 runs

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 120 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@syed can you fix the conflicts?

@syed ping

@rhtyd Sorry Rohit, looks like this slipped out of my radar. I've rebased and resolved the conflicts.

@syed looks like we have new conflicts

darn it! I'll resolve it now

@rhtyd Done!

Cool feature. Recently have thought about it.

Ping @syed

@rafaelweingartner I've resolved the conflicts. I'd really like to get this in because I think this is the 3rd time rebasing it. If you could do a code review, that would be sublime :)

@syed Hi, do you continue to manage this PR? I think it's very beneficial for 4.12.

@syed is it useful for solidfire? Is there any progress in this pr?

@syed this is an interesting feature; Do you intend to continue managing this PR?

I think that this PR is no longer necessary due to PR adding support for IOPS burst https://github.com/apache/cloudstack/pull/3133.

Hi @syed can you please confirm if this PR is still needed or can be closed by PR3133? In case it is, is it ready for review?

Hi @nvazquez Sorry for the delayed response. #3313 is different from this PR. The idea here is to give the operator the ability to expose storage offerings in the style AWS gp2/gp3  where IOPS scales with size.  I currently don't have a setup to work on this but would be happy to support if someone picks it up

Thanks @syed this will need some effort and resolving many conflicts. Do you think you can pick this up sometime soon? Otherwise we can move it for the next milestone

Probably good idea to move to next milestone
On Fri, Jul 16, 2021 at 11:28 AM Nicolas Vazquez @.***>
wrote:

Thanks @syed https://github.com/syed this will need some effort and
resolving many conflicts. Do you think you can pick this up sometime soon?
Otherwise we can move it for the next milestone
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/cloudstack/pull/2231#issuecomment-881532975,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANULU6WE5GA5WEDAFC66DTYBF3VANCNFSM4DWFD5ZA
.

Hi @syed thank you for your PR, given the inactivity in the last 4+ years, I'm closing this. If you happen to work on this feature and can fix conflicts pl re-open or re-raise the PR.


PERF-21 JMeter scripts for slow queries reported in Bugfest env

Purpose:
https://issues.folio.org/browse/PERF-21
Approach:
Investigate slow queries by writing JMeter scripts:

searchOrderById.jmx - search order by id in Orders->Orders App
searchOrderLinesByStatus.jmx - search order lines by status in Orders->Order lines App
searchOrdersByKeyword.jmx - search order by keyword in Orders->Orders App
searchOrdersByStatus.jmx - search order by status in Orders->Orders App
searchRequestByOpenStatus.jmx - search order by status in Requests App

For each .jmx file above, could you update Readme.md with workflow steps as followed in UI. Because without it, it is difficult to review HTTP requests made in *.jmx file.
For example:
Workflow for searchOrderById.jmx:
1 Open Orders App
2 Select Orders tab on the top left
3 Filter Orders by selecting status `Pending`
4 Select Orders by `Purchase order - msl9730`

I think we should do this for all JMeter scripts henceforth. By doing this, it will be easier for the reviewer to review the workflow.


The Registration tab is not working. I would like to contribute in this issue.

Issue Description:
Hey  @abhay-raj19 ! 👋 I've noticed that the Registration tab isn't functioning as expected, and I'm eager to roll up my sleeves and contribute to fixing it. Here's what I have in mind:
Proposed Solution:
I'm planning to create a dedicated web page that streamlines the registration process. This page will be designed to seamlessly gather all the necessary details from users, ensuring a smooth and hassle-free registration experience. Here's a brief outline of what I intend to include:
User-friendly Interface: Implementing an intuitive interface that guides users through the registration process step by step.
Input Validation: Adding robust input validation to ensure that all submitted data is accurate and complete.
Error Handling: Implementing error handling mechanisms to provide clear feedback to users in case of any issues during registration.
Data Storage: Setting up a secure backend system to store user registration data securely.
Integration: Integrating the new registration page seamlessly into the existing website, ensuring a cohesive user experience.
Looking forward to diving into this project and making a positive impact! Let's do this! 💪

Proceed @Dhiya-Natarajan


Web UI does not show thumbnails for webp image files

To reproduce:
Drag-and-drop the attached image to the web UI.
Expected:
Image thumbnail shows up and clicking it shows the full size image
Actual:
No thumbnail, clicking through shows a blank screen
hithere.webp.zip
Attached image zipped as github doesn't support webp either.

Issue is not related to web ui since the blob metadata is not indicating that the uploaded blob is an image

The webUI will presumably need to transcode, since browsers don't support it natively.

If the server identifies webp files as images, the web ui will display it
as an image. This issue is not related to the web ui.
webp is unsupported by Safari.
Chrome, Firefox, Opera, Edge, and their mobile versions all support it.
See https://caniuse.com/#search=webp
On Wed, 12 Jun 2019, 3:45 pm Daniel Heath<EMAIL_ADDRESS>wrote:

The webUI will presumably need to transcode, since browsers don't support
it natively.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/perkeep/perkeep/issues/850?email_source=notifications&email_token=AC4HOIBDCF74ERMOOOPH42DP2F37FA5CNFSM4COFFUL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXSAAQI#issuecomment-501481537,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4HOIFDGIWB3LKYT42GQNTP2F37FANCNFSM4COFFULQ
.


Update ProtoData and validation

This PR updates ProtoData and validation versions to propagate the latest changes in validation to the downstream modules.

@armiol, PTAL.

@alexander-yevsyukov, PTAL.


Update ru.js

Coverage remained the same at 60.982% when pulling a237979823d71c118824aaa2a799f1c3153feab8 on Globulopolis:master into 1ca0ab301f55562fe4828497b5aaaa173e46cd72 on johndyer:master.

Thanks for this PR. Merged now.


[Windows] Adjust min_dimensions and max_dimensions using AdjustWindowRectEx.

This fixes #196, although it does not update the documentation as suggested in the comments.

Sorry for the wait; you're at the top of my list now. Could you rebase/merge with the current master?

Rebased onto master.

I don't know what's going on with AppVeyor. That looks like a sporadic failure.

Thanks! Everything looks good, and it worked great when I tested it on Windows 10.
(I won't fuss about not making the documentation change, since the docs sorta need an overhaul soon anyway.)

...whoops, the CHANGELOG entry was under the wrong section from before. I'll have to remember to correct that.


global: factored out computing of md5 checksum

@lnielsen I have fixed the failing test.

@lnielsen hups. I hope I have pushed the correct version now. 🚀

Coverage increased (+0.07%) to 91.128% when pulling 905420e7d75124cc8324d56b6b960057796abb05 on jirikuncar:checksum into a17c9a56a687881f3d041b5fcc8313658e1bed2e on inveniosoftware:master.

Coverage increased (+0.07%) to 91.128% when pulling 905420e7d75124cc8324d56b6b960057796abb05 on jirikuncar:checksum into a17c9a56a687881f3d041b5fcc8313658e1bed2e on inveniosoftware:master.


Test datasets

I really hope to follow your work, but I found that the test set used in the paper is not public. Can you provide the test set used in the paper? Thank you very much.

I found it in https://github.com/csjliang/DASR/tree/master/datasets


How reliable are "FederalWell" and "IndianWell"?

These nominally boolean flags were not included in the SkyTruth data and so currently we mark them with NaN.  There were many disclosures from that era without those fields included on the PDF.  However, all directly downloaded data from FracFocus have either a True or False value.  Because it is set up as a boolean in FracFocus, some default value is added when the value is not reported.  It seems possible that some of those T or F should actually be "unknown" or "unreported".
Need to investigate further...

Judging by the disclosures that are available as PDFs but not within the bulk download with chemical records (largely FFversion=1),  when the FederalWell and IndianWell data are not recorded in the PDF, the value given in the bulk download is "False".  It should be NaN because a False implies that the well is not a Federal or Indian, when in fact, we can't say from these data.  This undermine the use of these fields until we can pinpoint those disclosures that do or don't have the field.


WPCFM

Details

Adds a dev workflow with npm run and lando
Adds two ways to manage configuration or environment settings

WP-CFM plugin. This plugin is controlled via the Admin UI and allows you to create environment specific bundles. These are manually imported/exported.
MU Plugin - dev-specific-configs.php and live-specific-configs.php files. These allow a developer to manually add config changes that are automatically run once the site is deployed.

Testing

[x] Grab a database export from pantheon and place it in the reference/ directory
[x] Run nvm use then npm install then lando start
[x] Run npm run refresh
[x] Copy the random password the refresh script outputs and use it to log into Wordpress with local-admin being your user account.
[x] Go to http://the-world-wp.lndo.site/wp-admin/options-general.php?page=wpcfm and switch between the environments (dev / live specifically) - Verify when switching to the live environment you now see a new config option ontop of all the other dev/test config options. Switching back to dev or test should hide this live config option.
[x] Note the one bundle currently in place: active plugins
[ ] Create another bundle and confirm that if you push the bundle the bundle gets created as a file in wp-content/config/[environment]

Notes

There are only two environment prepped in this PR

dev = local, pantheon multidev, and pantheon dev environments
'live` = pantheon test and live environments

WP-CFM exports/imports are manual. This means that when code is deployed to a specific environment the release manager will need to manually Pull the appropriate bundle. This can also be done via terminus. terminus wp the-world-wp.[environment] config pull [bundle_name]

@brandonhundt I think I got this PR in a place that is reviewable. I added some notes that give an override of the PRs limitations and environment definitions.

This is working after I updated lando to 3.6.0!

@brandonhundt Updated the readme with specifics around lando and node versions :+1:

Should we add reference/ directory to the .gitignore?


Add remot3-it/remote-it versions "v2.6.2"

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/azp run

Looks like the issues is that the PRs are not in the manifests folder.


Router scrollBehavior works only when  the page is loaded first time

Environment
------------------------------
- Operating System: `Darwin`
- Node Version:     `v17.4.0`
- Nuxt Version:     `3.0.0-27409509.e727bb4`
- Package Manager<EMAIL_ADDRESS>- Bundler:          `Vite`
- User Config:      `-`
- Runtime Modules:  `-`
- Build Modules:    `-`
------------------------------

Reproduction
Repository: https://github.com/lukaszflorczak/nuxt3-demo/tree/test/scroll-behavior (branch test/scroll-behavior)

Visit http://localhost:300/#section-3
Page should scroll smoothly to that section (the title should have 30px offset on top – from scroll behavior settings)
Scroll to the top and use the navigation – there is no smooth scrolling and offset

Describe the bug
It looks that scrollBehavior works properly only when the page is loaded the first time. Each next event is ignored, even though it is handled by the appropriate condition (for example if (to.hash) – we get console log message).
https://user-images.githubusercontent.com/1818979/153574614-698866e7-467e-4599-8ee4-a6e0dd7e894b.mov
The plugin with settings: https://github.com/lukaszflorczak/nuxt3-demo/blob/test/scroll-behavior/plugins/router.ts

Have a look here: https://github.com/nuxt/nuxt/issues/22663


The Next Story button does not update the url Route.. it keeps the first one.

After clicking Next Story button it should update the route as well. For now url keep the first one even after few "nextstory" click and other posts shown

Fixed in #268


Allow loading properties in XML format

It would be great if you could pass either a .properties or a .xml file with the properties to the com.onelogin.saml2.Auth constructor.
The code change should be as simple as using the Properties.loadFromXML(stream)  method.

The Auth class support a filename or a Saml2Settings object.
The Saml2Settings object can be generated by the SettingsBuilder class using:

fromFile Providing the filename of the file that contains the properties
fromProperties Providing a   java.util.Properties object
fromValues Providing a   Map<String, Object> object

So you already have different ways to import the data settings, if you want to add a new fromXML method to the SettingsBuilder class we are open to review and merge the PR.


DSD-525: Chakra SkeletonLoader

Fixes JIRA ticket DSD-525
This PR does the following:

Composes the DS SkeletonLoader component with Chakra's Skeleton component.

How has this been tested?
Storybook.
Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr748-hysja22ylzw6pzwtiqocppwatylcdrxo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/618046c635001899157bc11c

Tugboat has finished building the preview for this pull request!
Link:

https://pr748-hysja22ylzw6pzwtiqocppwatylcdrxo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/618046c635001899157bc11c

Tugboat has finished building the preview for this pull request!
Link:

https://pr748-hysja22ylzw6pzwtiqocppwatylcdrxo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/618046c635001899157bc11c

There are some styling issues with padding and image sizing.  I will take a closer look after I review the other PRs.

Tugboat has finished building the preview for this pull request!
Link:

https://pr748-hysja22ylzw6pzwtiqocppwatylcdrxo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/618046c635001899157bc11c

Tugboat has finished building the preview for this pull request!
Link:

https://pr748-hysja22ylzw6pzwtiqocppwatylcdrxo.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/618046c635001899157bc11c

Last update looks good.


SLIM-540 activate device

SonarQube analysis reported 2 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 pom.xml#L261: Make this line start at column 7.
 pom.xml#L463: Make this line start at column 7.

This pull request makes the build fail.

This pull request makes the build fail.


Wallet Will Not Sync

First, when the wallet opens this window opens as well and if you kill this window the wallet closes.
Second, although I have 35 active connections, my wallet is not syncing.

What version of the wallet are you using and what OS?

Please try again with 2.0.5. if you have a problem please ask us in the discord help channel.

Closed because of inactivity and probably no error in Spectrecoin.


Looking for guidance on generating motion dict pickle files

Hi,
Thanks for the awesome work. We are trying to run the training pipeline on DexYCB dataset and find the following error msg:
FileNotFoundError: [Errno 2] No such file or directory: '/mnt/homes/XXXX/XXXX/dex-ycb/dexycb_s0_motion_dict.pickle'

I suppose it's not from the original dataset, but generated by some preprocessing process in order to accelerate training. I am wondering if you can tell me how to generate such file. Thanks!

Good catch! Just added the script. Please see the last commit and updated README.


Release v0.17.0

v0.17.0 Dec. 29, 2020
Enhancements

Added save_plot that allows for saving figures from different backends #1588
Added LightGBM Regressor to regression components #1459
Added visualize_decision_tree for tree visualization with decision_tree_data_from_estimator and decision_tree_data_from_pipeline to reformat tree structure output #1511
Added DFS Transformer component into transformer components #1454
Added MAPE to the standard metrics for time series problems and update objectives #1510
Added graph_prediction_vs_actual_over_time and get_prediction_vs_actual_over_time_data to the model understanding module for time series problems #1483
Added a ComponentGraph class that will support future pipelines as directed acyclic graphs #1415
Updated data checks to accept Woodwork data structures #1481
Added parameter to InvalidTargetDataCheck to show only top unique values rather than all unique values #1485
Added multicollinearity data check #1515
Added baseline pipeline and components for time series regression problems #1496
Added more information to users about ensembling behavior in AutoMLSearch #1527
Add woodwork support for more utility and graph methods #1544
Changed DateTimeFeaturizer to encode features as int #1479
Return trained pipelines from AutoMLSearch.best_pipeline #1547
Added utility method so that users can set feature types without having to learn about Woodwork directly #1555
Added Linear Discriminant Analysis transformer for dimensionality reduction #1331
Added multiclass support for partial_dependence and graph_partial_dependence #1554
Added TimeSeriesBinaryClassificationPipeline and TimeSeriesMulticlassClassificationPipeline classes #1528
Added make_data_splitter method for easier automl data split customization #1568
Integrated ComponentGraph class into Pipelines for full non-linear pipeline support #1543
Update AutoMLSearch constructor to take training data instead of search and add_to_leaderboard #1597
Update split_data helper args #1597
Add problem type utils is_regression, is_classification, is_timeseries #1597
Rename AutoMLSearch data_split arg to data_splitter #1569

Fixes

Fix Windows CI jobs: install numba via conda, required for shap #1490
Added custom-index support for reset-index-get_prediction_vs_actual_over_time_data #1494
Fix generate_pipeline_code to account for boolean and None differences between Python and JSON #1524 #1531
Set max value for plotly and xgboost versions while we debug CI failures with newer versions #1532
Undo version pinning for plotly #1533
Fix ReadTheDocs build by updating the version of setuptools #1561
Set random_state of data splitter in AutoMLSearch to take int to keep consistency in the resulting splits #1579
Pin sklearn version while we work on adding support #1594
Pin pandas at <1.2.0 while we work on adding support #1609
Pin graphviz at < 0.16 while we work on adding support #1609

Changes

Reverting save_graph #1550 to resolve kaleido build issues #1585
Update circleci badge to apply to main #1489
Added script to generate github markdown for releases #1487
Updated dependencies to fix ImportError: cannot import name 'MaskedArray' from 'sklearn.utils.fixes' error and to address Woodwork and Featuretool dependencies #1540
Made get_prediction_vs_actual_data() a public method #1553
Updated Woodwork version requirement to v0.0.7 #1560
Move data splitters from evalml.automl.data_splitters to evalml.preprocessing.data_splitters #1597
Rename "# Testing" in automl log output to "# Validation" #1597

Documentation Changes

Added partial dependence methods to API reference #1537
Updated documentation for confusion matrix methods #1611

Testing Changes

Set n_jobs=1 in most unit tests to reduce memory #1505

Breaking Changes

Updated minimal dependencies: numpy>=1.19.1, pandas>=1.1.0, scikit-learn>=0.23.1, scikit-optimize>=0.8.1
Updated AutoMLSearch.best_pipeline to return a trained pipeline. Pass in train_best_pipeline=False to AutoMLSearch in order to return an untrained pipeline.
Pipeline component instances can no longer be iterated through using Pipeline.component_graph #1543
Update AutoMLSearch constructor to take training data instead of search and add_to_leaderboard #1597
Update split_data helper args #1597
Move data splitters from evalml.automl.data_splitters to evalml.preprocessing.data_splitters #1597
Rename AutoMLSearch data_split arg to data_splitter #1569

Wow, so many things happened this month!!

Perf test results here


feat: ZoomContentControl as a stand alone control in Toolkit

GitHub Issue (If applicable): closes #1109
PR Type
What kind of change does this PR introduce?

Feature

What is the current behavior?
ZoomContentControl doesn't exist in Toolkit
What is the new behavior?
Added ZoomContentControl to Tookit as a stand alone control
Added Samples, Tests and Docs for the same
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Tested the changes where applicable:

[ ] UWP
[ ] WinUI
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[x] Controls Doc Update
[ ] Extensions Doc Update
[ ] controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[x] Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[x] Contains NO breaking changes
[x] Associated with an issue (GitHub or internal)
[x] Commits must be following the Conventional Commits specification.

@vatsashah45 potentially for reference https://github.com/wieslawsoltes/PanAndZoom

@kucint Feel free to post your feedback after you are able to review the control directly here for better tracking, thanks!

@MergifyIO backport release/stable/6.3

@vatsashah45 Can you check the failing CI please?

note: CI issue related to uwp build langversion and lack of syntax sugars... to fix


Feature Request: Display Remaining Time Off and Accruals from Current Date

It would be a great addition to Stretch My Time Off if users could view their remaining time off from today’s date and see their projected accruals over the rest of the year. For example, a user could enter that they currently have 10 days off remaining, and a place for us to put how many days of PTO will we get from between now and the end of the year..

Exactly, planning days in the past does not make sense (unless as an option to see what we could have done).


NTR: transvection

A discussed in https://github.com/geneontology/go-ontology/issues/20791
I will create a new term, transvection

Child of 'regulation of gene expression, epigenetic'
Def: Regulation of transcription by interaction between an allele on one chromosome and the corresponding allele on the homologous chromosome. Transvection can lead to either gene activation or repression.
References:

PMID:33479152
PMID:24236213
@colinlog Any comments?

+[Term]
+id: GO:0140617
+name: transvection
+namespace: biological_process
+def: "Regulation of transcription by interaction between an allele on one chromosome and the corresponding allele on the homologous chromosome. Transvection can lead to either gene activation or repression." [PMID:24236213, PMID:33479152]
+is_a: GO:0040029 ! regulation of gene expression, epigenetic
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/21038 xsd:anyURI
+created_by: pg
+creation_date: 2021-03-08T18:30:47Z
+

Out of curiosity, why is this 'epigenetic' ?

This is what the wikipedia page says: https://en.wikipedia.org/wiki/Transvection_(genetics)
See also for eg PMID:31611231
@colinlog please reopen if that isn't right.

Clearrly I don't understand what it is.
But is this definition sufficient"
"Regulation of transcription by interaction between an allele on one chromosome and the corresponding allele on the homologous chromosome."


🏀 Playbook link doesn't work.

Describe the bug
🏀 Playbook link in the readme file doesn't work.
To Reproduce
Steps to reproduce the behavior:

Open readme.
Move to the "Learn more about unstructured data workflows" section.
Click to 🏀 Playbook link.
Observe the "This page does not exist" page.

Screenshots

Thanks for pointing that out!
I fixed the link will close the issue when it's merged.
Pull request #396

merged


Update find_and_lock and find_and_unlock methods

Changes:

removed locking_name_length parameter (looks unnecessary due to ability to define own locking_name_generator)
added parameter validation for locker method
updated searching criteria for find_and_lock, find_and_unlock and unlocked methods
now find_and_unlock accepts options to find a document (a document locking_name_field could be change during the lock, which made it impossible to unlock a document)
added index by locking_name to the tests

Thank you.