stateless_llama test_ test_vmfb_comparison broken with PyTorch 2.3

See: models/turbine_models/tests/stateless_llama_test.py
Marked as expectedFailure.
This test is failing during the export/tracing stage with the following error:
FAILED models/turbine_models/tests/stateless_llama_test.py::StatelessLlamaChecks::test_vmfb_comparison - TypeError: scaled_dot_product_attention(): argument 'is_causal' must be bool, not SymBool

From dynamic shapes manual in "Error Cookbook" section, it seems that we have to make changes to the operator schema to accept SymBool and not only bools in torch. But I was able to workaround it for now by changing in modelling_llama.py:
is_causal=self.is_causal and attention_mask is None and q_len > 1

to
True if is_causal=self.is_causal and attention_mask is None and q_len > 1 else False

But, after this change, ran into this error in iree-compile stage:
Diagnostics:
E               <stdin>:1101:13: error: failed to legalize operation 'torch.aten.scaled_dot_product_attention' that was explicitly marked illegal
E                   %73:2 = torch.operator "torch.aten._scaled_dot_product_flash_attention_for_cpu"(%64, %72, %44, %float0.000000e00, %true_61, %none_62, %none_63) : (!torch.vtensor<[1,32,?,128],f32>, !torch.vtensor<[1,32,?,128],f32>, !torch.vtensor<[1,32,?,128],f32>, !torch.float, !torch.bool, !torch.none, !torch.none) -> (!torch.vtensor<[1,32,?,128],f32>, !torch.vtensor<[1,32,?],f32>)

Do we need to register a decomposition for this op for this to work?

@saienduri what backend/device were you facing this issue on, and did you also try testing with an updated IREE build?
@Groverkss is there any expected failure cases like this with SDPA enabled for now?

This is on the cpu backend, and I was trying with the one pinned in turbine from 04/03. I just tried with the latest iree releases, but still the same issue.


Sprints mypy

Fix some type annotation errors and upgrade the version of mypy to mypy's master.

Merged all but the last commit, which breaks things.


Youtube video: change autoplay using radioButton

Hi,
I see that I can enable Youtube's video autoplay in youtube.js from videogular-youtube pluggin:
playerVars = {
         'controls': 0,
         'showinfo': 0,
         'rel': 0,
         'autoplay': 0, //Switch autoplay to 1 to autoplay videos
         'start': 0
  };

My problem is that I have two radioButtons for enable or disable autoplay. How can I make that, when I select enable autoplay, change the property to autoplay the video?
P.D. Sorry for my English.

When radioButton change value you need re-set autoplay in playerVars

How can I do that? I don't have any idea.

@lazaro92 Just make your idea in  codepen, I'll help you for it work

The thing is that I have a database of youtube videos. This database is:
Video : {       id: "",       url: "",      autoplay: ""  }
so, when I click radiobutton, it changes the database value of autoplay (true/false). I have to set autoplay when I load the page and obtain the video info from database.


chore: update documentation for application controller options and application sets

Signed-off-by: Tyler Auerbeck<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
What does this PR do / why we need it:
This is a small doc fix to add the AppSync option to the Controller documentation
Have you updated the necessary documentation?

[X] Documentation update is required by this PR.
[X] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #370
How to test changes / Special notes to the reviewer:
N/A

Just opened (and closed) another PR to add the AppSync property. Can I help to move this PR forward?

@iam-veeramalla Anything else needed here?

Thanks for the PR @tylerauerbeck


0.3.5 on PyPI?

Could you please publish 0.3.5 on PyPI?

before that: pip install git+https://github.com/s-block/django-nested-inline.git

While that does work, we try to avoid doing that because it increases the time it takes for our production deploys.

I totally agree. 0.3.5 contains some really important fixes and needs to hit PyPI ASAP.

Any news on that ? :)

We could also really use this being updated on PyPI

Any news?

I'd love to see MR #35 incorporated first, but yes, this really needs to be updated on PyPI.
@s-block, would it help you to define extra roles on PyPI? That way, other people can help keep the package up to date.

:+1: poke poke poke poke

0.3.5 now on Pypi

Fantastic! Thank you!

Cheers @s-block that is awesome

This issue seems to be solved and should be closed. I added new issue #74 for Django 1.10 compatible package though.

done


chore: add release notes for v0.12.0

Did some hand editing in this case:

Added a few missing breaking API changes (don't return void + use @func instead of @field)
Wrote an extra section under Breaking Changes with some more details on the new compat mode and how to upgrade modules via dagger develop
Reordered some of the entries to match the blog post + small misc formatting fixes
Added a breaking changelog about the Go SDK alias removal

In our current system, this only showed up in the Go SDK release notes. However, I don't think that makes sense for module-specific changes since it's a change that impacts users of the engine after upgrading, not users of the "go sdk as a library".

Would like to link to blog post here, but catch-22, so we can edit the release notes after the blog post is out with that link.
In the mean time, I do mention here that the breaking API change PRs have descriptions with more details.

Is it expected that the blog post link https://dagger.io/blog/dagger-0-12 currently returns a 404?

Should be fixed now!

Thanks!


Home in Navbar

Describe the bug
The 'Home' section present in the navbar must redirect to the top which is not doing as expected. As far as concerned it points to an element with id: 'intro'. But does not work as expected.
Expected behavior
On clicking home, the section must redirect to the top.

On clicking home, the section redirects to the top.


A fix for #280

This fixes #280 by first using splitlines() so that new lines are preserved.

I'm sorry I forgot to specify a certain commit.

You are not yet listed as an author in AUTHORS.txt, are you? Could you please add yourself?
I'll merge this afterwards.

No I was not, I added myself.

@libre-man Sorry for not being more responsive, I'll have a look at all your PRs on Monday at the very latest.

Thanks!


chore: change date handling

Draft A lot more unexpected behavior than I was hoping for. Using this as a sketch-pad while going through the tests.
Test 1. Confirm behavior of issuanceDate
    ✓ 1. case-0 should match the verifiable credential (255ms)
    ✓ 1. case-1 should match the verifiable credential (215ms)
    ✓ 1. case-2 should match the verifiable credential (208ms)
    ✓ 1. case-3 should match the verifiable credential (220ms)
    ✓ 1. case-4 should match the verifiable credential (208ms)
    ✓ 1. case-5 should match the verifiable credential (208ms)
    ✓ 1. case-6 should match the verifiable credential (206ms)
    ✓ 1. case-7 should match the verifiable credential (206ms)
    ✓ 1. case-8 should match the verifiable credential (204ms)
    ✓ 1. case-9 should match the verifiable credential (205ms)
    ✓ 1. case-10 should match the verifiable credential (208ms)
    ✓ 1. case-11 should match the verifiable credential (209ms)
    ✓ 1. case-12 should match the verifiable credential (205ms)
    ✓ 1. case-13 should match the verifiable credential (206ms)
    ✓ 1. case-14 should match the verifiable credential (208ms)
    ✓ 1. case-15 should match the verifiable credential (206ms)
    ✓ 1. case-16 should match the verifiable credential (222ms)
    ✓ 1. case-17 should match the verifiable credential (207ms)
    ✓ 1. case-18 should match the verifiable credential (214ms)
    ✓ 1. case-19 should match the verifiable credential (211ms)
    ✓ 1. case-20 should match the verifiable credential (213ms)
    ✓ 1. case-21 should match the verifiable credential (215ms)
    ✓ 1. case-22 should match the verifiable credential (216ms)
    ✓ 1. case-23 should match the verifiable credential (204ms)
    ✓ 1. case-24 should match the verifiable credential (204ms)
    ✓ 1. case-25 should match the verifiable credential (203ms)
    ✓ 1. case-26 should match the verifiable credential (205ms)
    ✓ 1. case-27 should match the verifiable credential (203ms)
    ✓ 1. case-28 should match the verifiable credential (205ms)
    ✕ 1. case-29 should match the verifiable credential (46ms)

The one case that's broken here is Digital Bazaar throws an error, and Transmute does not throw an error on sign. I think this is outside of the scope for dates, and I'll skip passed it because i'm more concerned about the errors in the following tests.
      Object {
    -   "reason": "Error: The property \"date\" in the input was not defined in the context.",
    -   "thrownOn": "sign",
    -   "type": "error",
    +   "@context": Array [
    +     "https://www.w3.org/2018/credentials/v1",
    +     "https://www.w3.org/2018/credentials/examples/v1",
    +   ],
    +   "credentialSubject": Object {
    +     "alumniOf": "Example University",
    +     "id": "https://example.edu/students/alice",
    +   },
    +   "id": "http://example.edu/credentials/1872",
    +   "issuanceDate": Object {
    +     "date": 25,
    +     "hours": 21,
    +     "milliseconds": 789,
    +     "minutes": 33,
    +     "months": 7,
    +     "seconds": 56,
    +     "years": 1991,
    +   },
    +   "issuer": "https://example.edu/issuers/565049",
    +   "proof": Object {
    +     "created": "2021-10-15T12:33:56Z",
    +     "jws": "eyJhbGciOiJFZERTQSIsImI2NCI6ZmFsc2UsImNyaXQiOlsiYjY0Il19..sSFwXkauRrVVmNmTJnRNK70WzU81gVz0mS9bJ6quIR5XyuIq2L29DS2zhJ8GKHjKkytLmR2MBVcfzRwBSDb0Cw",
    +     "proofPurpose": "assertionMethod",
    +     "type": "Ed25519Signature2018",
    +     "verificationMethod": "did:key:z6MktWjP95fMqCMrfNULcdszFeTVUCE1zcgz3Hv5bVAisHgk#z6MktWjP95fMqCMrfNULcdszFeTVUCE1zcgz3Hv5bVAisHgk",
    +   },
    +   "type": Array [
    +     "VerifiableCredential",
    +     "AlumniCredential",
    +   ],

Test 2. Confirm behavior of suite date constructor
Test 2 shows more errors than I was expecting. But after adding which date is being tested, I think I have a better idea of why.
    ✓ 2. case-0 removed should match the verifiable credential (257ms)
    ✓ 2. case-1 undefined should match the verifiable credential (203ms)
    ✓ 2. case-2 null should match the verifiable credential (203ms)
    ✓ 2. case-3 0 should match the verifiable credential (212ms)
    ✓ 2. case-4  should match the verifiable credential (203ms)
    ✕ 2. case-5 foobar should match the verifiable credential (2ms)
    ✓ 2. case-6<PHONE_NUMBER>208 should match the verifiable credential (205ms)
    ✓ 2. case-7 -1635774995208 should match the verifiable credential (205ms)
    ✓ 2. case-8 1 should match the verifiable credential (196ms)
    ✓ 2. case-9 -1 should match the verifiable credential (202ms)
    ✓ 2. case-10 123 should match the verifiable credential (201ms)
    ✓ 2. case-11 -123 should match the verifiable credential (205ms)
    ✓ 2. case-12 12345 should match the verifiable credential (204ms)
    ✓ 2. case-13 -12345 should match the verifiable credential (201ms)
    ✓ 2. case-14 1991-08-25T21:33:56+09:00 should match the verifiable credential (204ms)
    ✕ 2. case-15 Sunday, August 25th 1991, 9:33:56 pm should match the verifiable credential
    ✕ 2. case-16 25th Sunday August 1991 should match the verifiable credential (1ms)
    ✓ 2. case-17 Sunday August 25, 1991 should match the verifiable credential (201ms)
    ✓ 2. case-18 25 Aug 1991 should match the verifiable credential (205ms)
    ✓ 2. case-19 1991-08-25 should match the verifiable credential (198ms)
    ✓ 2. case-20 Sun, 25 Aug 1991 21:33:56  should match the verifiable credential (204ms)
    ✓ 2. case-21 08 25 1991 should match the verifiable credential (202ms)
    ✓ 2. case-22 Aug 25, 1991 should match the verifiable credential (200ms)
    ✓ 2. case-23 1991-08-25T21:33:56 should match the verifiable credential (205ms)
    ✕ 2. case-24 1991-08-25T21:33:56:789+09:00 should match the verifiable credential (1ms)
    ✓ 2. case-25 1991-08-25T21:33:56Z should match the verifiable credential (207ms)
    ✓ 2. case-26 1991-08-25T21:33+09:00 should match the verifiable credential (203ms)
    ✓ 2. case-27 1991-08-25T12:33:56.789Z should match the verifiable credential (197ms)
    ✕ 2. case-28 1991,7,25,21,33,56,789 should match the verifiable credential (1ms)
    ✕ 2. case-29 [object Object] should match the verifiable credential (1ms)

These tests should be throwing an error in the constructor of the suite. Which means I might not be catching it, as when I previously wrote the tests, there wasn't the possibility of errors being thrown here.
And after some investigation I was missing the condition for both fixture and output being an error when comparing results.
Test 3. Confirm behavior of suite date set directly
After fixing the error in test 2, i was hoping that all of the other tests would work. But test 3 seems to have errors. And what's weird is that the error is being thrown in the suite constructor even through that's not what's being tested in this case.
    ✓ 3. case-0 removed should match the verifiable credential (267ms)
    ✓ 3. case-1 undefined should match the verifiable credential (208ms)
    ✓ 3. case-2 null should match the verifiable credential (206ms)
    ✓ 3. case-3 0 should match the verifiable credential (212ms)
    ✓ 3. case-4  should match the verifiable credential (211ms)
    ✕ 3. case-5 foobar should match the verifiable credential (43ms)
    ✓ 3. case-6<PHONE_NUMBER>208 should match the verifiable credential (208ms)
    ✓ 3. case-7 -1635774995208 should match the verifiable credential (202ms)
    ✓ 3. case-8 1 should match the verifiable credential (212ms)
    ✓ 3. case-9 -1 should match the verifiable credential (208ms)
    ✓ 3. case-10 123 should match the verifiable credential (202ms)
    ✓ 3. case-11 -123 should match the verifiable credential (208ms)
    ✓ 3. case-12 12345 should match the verifiable credential (203ms)
    ✓ 3. case-13 -12345 should match the verifiable credential (204ms)
    ✓ 3. case-14 1991-08-25T21:33:56+09:00 should match the verifiable credential (205ms)
    ✕ 3. case-15 Sunday, August 25th 1991, 9:33:56 pm should match the verifiable credential (42ms)
    ✕ 3. case-16 25th Sunday August 1991 should match the verifiable credential (48ms)
    ✓ 3. case-17 Sunday August 25, 1991 should match the verifiable credential (204ms)
    ✓ 3. case-18 25 Aug 1991 should match the verifiable credential (195ms)
    ✓ 3. case-19 1991-08-25 should match the verifiable credential (205ms)
    ✓ 3. case-20 Sun, 25 Aug 1991 21:33:56  should match the verifiable credential (209ms)
    ✓ 3. case-21 08 25 1991 should match the verifiable credential (206ms)
    ✓ 3. case-22 Aug 25, 1991 should match the verifiable credential (198ms)
    ✓ 3. case-23 1991-08-25T21:33:56 should match the verifiable credential (211ms)
    ✕ 3. case-24 1991-08-25T21:33:56:789+09:00 should match the verifiable credential (42ms)
    ✓ 3. case-25 1991-08-25T21:33:56Z should match the verifiable credential (201ms)
    ✓ 3. case-26 1991-08-25T21:33+09:00 should match the verifiable credential (198ms)
    ✓ 3. case-27 1991-08-25T12:33:56.789Z should match the verifiable credential (206ms)
    ✓ 3. case-28 1991,7,25,21,33,56,789 should match the verifiable credential (3ms)
    ✓ 3. case-29 [object Object] should match the verifiable credential (1ms)

Looks like case 5 is the first one to throw an error. I'll change my for-loop to only run that condition and start tracing.
Edit:
Okay, now everything is working now. Except the object error from test 1. Not sure why the same input is passing in test 4.

Leaving my notes up and closing. 1 case not passing which will be addressed in its own pull request.


Autostart in KDE

Hey,
I am running arch on endevourOS  and on gnome when I used to run sudo systemctl restart keyd. It also used to autostart keyd on startup but on kde that's not the case. I have to manually start the script on startup in kde. Can you tell m how  I can make it so it can automcatically be started? Thanks so much for your time.
warmest regards,
Kanishka

I have to manually start the script on startup in kde.

I assume you are talking about keyd-application-mapper. Note that KDE wayland is unsupported. If you are using the X version then it should work, but you will manually need to find a way to add it to your start up logic. I'm closing this for now since it isn't a keyd bug.


Allow full configuration of Kubernetes Cloud Config

What this PR does / why we need it:
This PR continues the efforts to expose Kubernetes options and features by making the cloud-config eminently configurable. Every element of the cloud-config is provided through a pass-through map of options that are translated into expect cloud-config format.
As an example, the job will look something like this:
    name: cloud-provider
    release: kubo
    properties:
      cloud-provider:
        type: gce
      cloud-config:
        Global:
          project-id: ((project_id))
          network-name: ((network))
          node-tags: ((director_name))-((deployment_name))-worker

and the underlying INI file would render as:
[Global]
project-id=((project-id))
network-name=((network))
node-tags=((director_name))-((deployment_name))-worker

In the case of Azure, the cloud-config is expected to be in YAML, so the pass-through options look slightly different:
    name: cloud-provider
    release: kubo
    properties:
      cloud-provider:
        type: azure
      cloud-config:
        aadClientId: ((client_id))
        aadClientSecret: ((client_secret))
        cloud: ((azure_cloud_name))
        location: ((location))
        primaryAvailabilitySetName: ((primary_availability_set))
        resourceGroup: ((resource_group_name))
        securityGroupName: ((default_security_group))
        subnetName: ((subnet_name))
        subscriptionId: ((subscription_id))
        tenantId: ((tenant_id))
        useInstanceMetadata: true
        vnetName: ((vnet_name))
        vnetResourceGroup: ((vnet_resource_group_name))

and the underlying YAML would render as:
aadClientId: ((client_id))
aadClientSecret: ((client_secret))
cloud: ((azure_cloud_name))
location: ((location))
primaryAvailabilitySetName: ((primary_availability_set))
resourceGroup: ((resource_group_name))
securityGroupName: ((default_security_group))
subnetName: ((subnet_name))
subscriptionId: ((subscription_id))
tenantId: ((tenant_id))
useInstanceMetadata: true
vnetName: ((vnet_name))
vnetResourceGroup: ((vnet_resource_group_name))

How can this PR be verified?
Deploy with a cloud-provider and observe that the manifest renders into the expected INI file. Follow up by using a cloud-provider specific bit of functionality like a Load Balancer or Persistent Volume.
Is there any change in kubo-deployment?
Yes.
Is there any change in kubo-ci?
No.
Does this affect upgrade, or is there any migration required?
Not generally, unless operators are using custom ops-files to enable other cloud-provider options not covered by the default ops-files.
Those operators will need to rewrite the ops-file to move the option to the new format.
Which issue(s) this PR fixes:
https://www.pivotaltracker.com/story/show/161421611
Release note:

* The Kubernetes Cloud Config now accepts pass-through arguments from the BOSH manifest. See kubo-deployment/manifest/ops-files/iaas/<iaas>/cloud-provider.yml for examples.
  * As a result of this change, certain behaviors of the release will no longer occur:
    * In vSphere, the manifest property will need to handle escapes in the username and password fields.
    * In GCP, token-url must explicitly be set to 'nil' when supplying a service-key. See kubo-deployment/manifest/ops-files/iaas/gcp/add-service-key-master.yml for an example.
    * In OpenStack, supplying the OpenStack CA file does _not_ override the OpenStack CA file path. The path needs to be hardcoded into the cloud-config option. By default, that path is `/var/vcap/jobs/cloud-provider/config/openstack-ca.crt`

LGTM


feat: add gradle Helm release exists task

Description
This pull request changes the following:

adds a gradle task for checking if the Helm release specified is present, if it is not, it will fail.

This will be used to replace the following in the makefile sunset:
.PHONY: is-minio-operator-installed
is-minio-operator-installed:
	@echo ">> Checking for minio operator..."; \
	helm list --namespace=minio-operator | grep minio-operator &> /dev/null && { echo "Found minio operator."; exit 0; }; \
	echo "Minio operator not found."; exit 1

Related Issues

Closes #326

:tada: This PR is included in version 0.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


CMake Warning - Policy CMP0011

Hi,
Here is a warning that I have during CMake configure.
>cmake.exe -DCMAKE_BUILD_TYPE=Release -DTARGET_ARCH=Win32 -DLIB_SUFFIX=Win32/Release -G"Visual Studio 12" -Tv120_xp . -DCMAKE_INSTALL_PREFIX=./install .
-- The C compiler identification is MSVC 18.0.40629.0
-- The CXX compiler identification is MSVC 18.0.40629.0
-- Check for working C compiler using: Visual Studio 12 2013
-- Check for working C compiler using: Visual Studio 12 2013 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Visual Studio 12 2013
-- Check for working CXX compiler using: Visual Studio 12 2013 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- cotire 1.7.8 loaded.
CMake Warning (dev) at cmake/cotire.cmake:13 (include):
  Policy CMP0011 is not set: Included scripts do automatic cmake_policy PUSH
  and POP.  Run "cmake --help-policy CMP0011" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  The included script

    E:/islog/dev/lib/build/liblogicalaccess/cmake/cotire.cmake

  affects policy settings.  CMake is implying the NO_POLICY_SCOPE option for
  compatibility, so the effects are applied to the including context.
Call Stack (most recent call first):
  CMakeLists.txt:13 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Microsoft Visual Studio 0x11 detected
-- Found CXX11:
-- Boost version: 1.57.0
-- Found the following Boost libraries:
--   filesystem
--   system
--   date_time
--   chrono
--   thread
--   regex
-- Found OpenSSL: E:/islog/dev/lib/build/liblogicalaccess/packages/lib/Win32/ssleay32.lib;E:/islog/dev/lib/build/liblogicalaccess/packages/lib/Win32/libeay32.lib (found version "1.0.0b")
-- CXX RC target liblogicalaccess cotired.
-- Configuring done
-- Generating done
-- Build files have been written to: E:/islog/dev/lib/build/liblogicalaccess

As it say, it is only a warning for the project developer and I have not found an issue related to it. In case you are already aware of it you can close it :)

Did you set cmake_minimum_required in your project (https://cmake.org/cmake/help/v3.5/command/cmake_minimum_required.html)?

Exact @gjasny ! I had cmake_minimum_required(VERSION 2.6) I updated to cmake_minimum_required(VERSION 2.8.12) and the message is gone.
Thank you !


[FLINK-34902][table] Fix IndexOutOfBoundsException for VALUES

What is the purpose of the change
The purpose of this PR is to avoid wrong IndexOutOfBoundsException with Values.
For example, a query INSERT INTO t_3_columns (id, name, num) VALUES ('id_0', 'name_0', 5); should not throw an exception.
Brief change log

Fix the exception catching conditions with VALUES expression
Add tests

Verifying this change
org.apache.flink.table.planner.calcite. FlinkCalciteSqlValidatorTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Hi @twalthr thanks a lot for your review. Could you please recheck in your available time? Thanks


How to properly handle datetime in operations?

Having an operation that expects to get string formatted datetime, such as '2007-30-10', the cli interface apparently translates that to an int and complains about it.
Any ideas how to solve this?

Grrr! Oh dear, yes, it computes 2007-30-10 = 1967

Users will have to use quotes, i.e. time_min='2007-30-10'
I agree, this is not nice, but that's how it is for time being!

On Linux (bash, to be more precise) the only way this works is if the quote character is escaped, as such:
time_min=\'2007-10-10\'

I'll update the operation info. The interesting part is that
ect res open ... ... 2007-01-01 2007-12-30

works without quotes or anything. I presume the command line is parsed in a different way there.
Anyway, closing for now.


Support for viewport scaling

Our team is implementing a "zoomable" renderer, and for this we require the filter's effects also increase according to the current scale/zoom.
To solve this problem, we multiply certain quantities by the current scale. For example, in motion-blur we multiply the velocity by the current viewport scale.
apply(filterManager, input, output, clear, state) {
 const widthInverse = 1 / state.sourceFrame.width
 const heightInverse = 1 / state.sourceFrame.height

 this.uniforms.velocity[0] = this._velocity[0] * widthInverse
 this.uniforms.velocity[1] = this._velocity[1] * heightInverse

 if (this.viewport) {
    this.uniforms.velocity[0] *= this.viewport.scale.x
    this.uniforms.velocity[1] *= this.viewport.scale.y
  }

  filterManager.applyFilter(this, input, output, clear)
}

We have done this to motion-blur, drop-shadow, bevel and (possibly) others too. Would you guys accept this style on your codebase? (It is a backward-compatible change)

Out of interest where are you multiplying this in the dropshadow filter? I'm not having any lock applying this to the offsets.


Update analyzer version

Some libs use analyzer:  3.2.0 and I have dependencies conflict(

Done in 0.3.0


Skip writing out of function.constant if None

Skips serialization of None value for constant in function. Currently produces null, which can break some tooling that isn't expecting it, apparently
Partial fix to https://github.com/gakonst/foundry/issues/618

Just ran into this, this makes abis generated by forge incompatible with The Graph deployments, which is strange since it's also using this library for parsing.

Thanks @vkgnosis! Can we merge this?


[Fix #615] Change Rails/RedundantPresenceValidationOnBelongsTo to SafeAutoCorrect: false

Fixes #615
Change Rails/RedundantPresenceValidationOnBelongsTo to SafeAutoCorrect: false
As discussed in #615, this cop's autocorrect is unsafe because it changes the validation error message from "can't be blank" to "must exist". This can break tests and behavior that rely on the error message (such as localizations).
Basing my changes off of #582, I don't believe this requires any test changes, so I've just updated the documentation here.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Thanks!

Unfortunately, this change will be reverted by #620 because accept the use case. Anyway, thank you for the patch.

@koic Can you please explain, why the cop is safe for autocorrection?
belongs_to :foo
validates :foo, presence: true

Before autocorrection, the error is "foo can't be blank", after - "foo must exist".
message option for the presence validation is not used.

Ah, it seems that I was influenced by the test case. I will not revert this change and keep the mark unsafe auto-correction.  Thank you.


How should you add packages?

Before looking at this, please review #10.
Adding packages isn't a great experience with these constraints right now.
I've got a kinda mostly working implementation to solve part of this right now but I want to think about this more because I think it's more of a nuanced thing than my implementation looks like right now.
I think there are two things that a user wants at different times when they add a dependency in a monorepo.

Add a package as a dep to a package at the same version if it is already a dependency elsewhere in the monorepo, otherwise add the latest version of the package
Add the latest version of a package, if it is a dependency elsewhere in the monorepo, update it there

The question is, how should people do this?
Bolt did 1 and that seemed to work mostly well so maybe the answer is to only have 1 and then maybe also a way to upgrade packages? The thing that's implemented right now(which I think is broken) works like this yarn m add <theThing>and does 1
Slightly related but also a bit separate thing that's not really a problem because I think the solution is pretty good: Adding peerDependencies
In Yarn and npm(I think), when using the --peer flag adds a package as a peerDependency but you generally also want it as a devDependency. Because of the peer and dev dependency relationship check, we already enforce that. This means that Manypkg's --peer flag on whatever add command might exist should also add the dep as a devDependency.

Personal thoughts, doing 1 by default seems the most sane - upgrading packages accidentally is a bit scary (I've got a related brown bag topic on this)
Aside aside, are we assuming manypkg should be responsible for package installs? I thought we were handing that off to yarn?
2 seems useful when you want to finally upgrade. My hack workflow for this would be manually update a version in one package and run yarn manypkg --fix
(my hack way of getting the installs I want would probably be to run yarn add THING && yarn manypkg --fix && yarn, which is I guess the argument for why manypkg wants to at least partially handle the installs.)

If we're handling installs, I would make --peer install it as a peerDep and a devDep all in one.

Aside aside, are we assuming manypkg should be responsible for package installs? I thought we were handing that off to yarn?

We're still calling out to yarn to do the actual installing of packages but for 1, doing the package.json modification ourselves seems easier.

My hack workflow for this would be manually update a version in one package and run yarn manypkg --fix

This would currently work, the one problem I have with it though is that it means explaining how to add a package is "run Manypkg this command for this case" and "run Yarn and then Manypkg for this other case" for this other case which doesn't feel super good.

With 1, can we do:

get the version range found in repo
call yarn add package@found-range

Offloading even more of this to yarn? (Trying to keep the wrapper very thin)
Oh I wasn’t saying my hack was good. It’s tbh probably the reason to do this over bolt-check

With 1, can we do:

get the version range found in repo
call yarn add package@found-range

Offloading even more of this to yarn? (Trying to keep the wrapper very thin)

My fear with doing this is that I've experienced strange problems with running yarn add inside workspaces with resolutions not being respected and having to run yarn at the root to fix the things + if someone runs add with a range specified that's different from the other versions in the repo that's not the version in other places in the repo, we would have to do lots of installs but it's only one if we do the package.json modifications ourselves and then call out to yarn to install All The Right Things.

strange problems with running yarn add inside workspaces with resolutions not being respected

Wouldn't mind expanding on this - that seems a fairly hard blocker, you're right.

if someone runs add with a range specified

I guess we should align assumptions - if someone runs add for<EMAIL_ADDRESS>and it's different to the other versions in the repo, I assume it errors eed is already present at ^1.3.0 - upgrade existing dependencies if you want to install ^1.5.0 in the repository.
That said, this probably implies an upgrade command which really should just do package.json updating and a root yarn call, which we can share more code with if this does package.json modifying.


Appears to already work on 1.19.1. Please update mod page.

Thanks in advance! You're amazing in my book.

Fixed for both Curse and Modrinth as well as for 1.19.2

Thanks so much!


Preloading in time

Preloading a time in doesn't seem to work.
I've tried passing the time in as HHMM and HH:MM into both the value and data-defaultDate attributes but in all cases I get the following error:

Found a solution:
If you pass a date in with the time (I'm just passing in today each time) in the data-defaultDate attribute and then have the value attribute set as the time then it works.

Hey, thanks for reporting the issue.
I've just pushed a new release with improvements that allow passing in time only.
Check out the latest release and the updated example.

Ahh brilliant thanks.


Create Octant Helm chart

helm upgrade --install octant charts/octant

Hi @leoxiongdev / @leox-phq
First, thank you for the PR and your interest in Octant. At this time we won't be merging any deployment related code in to the Octant upstream repository. Currently our focus is on making the best single application experience we can.
I would encourage you to submit your chart to https://github.com/helm/charts

@leox-phq the helm/charts maintainers are directing people away from hosting charts there and instead encourage people to host their own charts and publish them on helm hub.  Speaking from personal experience, it will be a very slow process to host or maintain a chart in the helm/charts repo.
Are you interested in hosting a chart?

@billimek Yeah, I was just told the same on Kubernetes Slack #charts. I would be interested in hosting a chart, but at this stage we don't have the time to setup/maintain it.


Using RefreshCached but getting wrong images

in your demo DetailViewController.m  i change options with SDWebImageRefreshCached i find that i still get old images
- (void)configureView {     if (self.imageURL) {         __block UIActivityIndicatorView *activityIndicator;         __weak UIImageView *weakImageView = self.imageView;         [self.imageView sd_setImageWithURL:self.imageURL                           placeholderImage:nil                                    options:SDWebImageRefreshCached                                   progress:^(NSInteger receivedSize, NSInteger expectedSize, NSURL *targetURL) {                                       if (!activityIndicator) {                                           [weakImageView addSubview:activityIndicator = [UIActivityIndicatorView.alloc initWithActivityIndicatorStyle:UIActivityIndicatorViewStyleGray]];                                           activityIndicator.center = weakImageView.center;                                           [activityIndicator startAnimating];                                       }                                   }                                  completed:^(UIImage *image, NSError *error, SDImageCacheType cacheType, NSURL *imageURL) {                                      [activityIndicator removeFromSuperview];                                      activityIndicator = nil;                                  }];     } }

![Uploading 3.png…]()
same to #1818

the images you uploaded are not working. can you please conform to the ISSUE_TEMPLATE on this project?

@mythodeia
In line 175 completed  the downloadedImage or downloadedData  is nil but finished is YES, there is anything wrong?

This has happened to me too

When I use SDWebImageRefreshCached as the  option key in a viewcontroller,  it worked in the first time, but in second time  I open the viewcontroller ,the imageView showed nothing, the url is still right.

@dreampiggy I think our latest 4.1.1 changes will fix this issue as well. What do you think?

@bpoplauschi SD 4.1.1 now use that NSData to compare the response data with cache data, If the data is same it will never call twice. Previously we use a little hack code to detect whether the image data is from NSURLCache or download from the server, but it not really accurate. I think this one is better.

@bpoplauschi SD 4.1.1 now use that NSData to compare the response data with cache data, If the data is same it will never call twice. Previously we use a little hack code to detect whether the image data is from NSURLCache or download from the server, but it's not really accurate. I think this one is better.

@SimonCY Sorry. This is a bug introduced during SD4.1 and will be fixed in SD4.1.1

Thanks @dreampiggy


fix: respect pause and resume on connections

@diasdavid please review and release when happy

I'm suspicious that without any 'unpipe', this will create errors when we have other streams writing to the conn stream after the handshake has been performed.
How tested was this upgrade with swarm and secio tests?

@diasdavid can you write a test for the concern you have?

The best is to link it to swarm and make sure it passes all the tests cause there is a lot of writes coming from several places

swarm + secio passes with this change, that's why I implemented it in the first place

@dignifiedquire released on 0.10

thanks :)


Attribute ValidateObject is not exposed

Hi I have a issue on using ValidateObject/ValidateCollection validator it looks like is not exposed to outside usage.
Doc Info : https://usehydro.dev/features/form-validation.html

I see it here https://github.com/hydrostack/hydro/blob/main/src/Validation/ValidateObjectAttribute.cs
Version used: 0.16.2

Just eliminating the obvious but you not missing an import here correct ?

Don't know actually I've just imported Hydro and tried to inport Hydro.Validations

That change hasn't been yet released. Accidentally the docs have been updated by the github action, my bad. But very soon I will release version v1.0 😄 "Soon" is just a few days. Exciting changes coming, including rendering components like:
<my-component name="My name" />

Instead of
<hydro name="MyComponent" params="@(new { Name = "My name" })" />

For the time being you can temporarily copy the code for ValidateObject and ValidateCollection if you want to move further.

Awesome, great news , thanks


Bump version to 6.0.0

Prepping for 6.0.0 publish

@devoncarew I think i have fixed the dart sdk with this pending CL: https://dart-review.googlesource.com/c/sdk/+/360540
You mentioned google3 may also need an update, how do i check what would be breaking?

@devoncarew yep, I need this PR to merge so that I can publish the 6.0.0 version and then i will also update that CL with the new version

You can update that CL in advance in order to bring in the 6.0.0-wip version of this package. You'd just be guaranteeing that the 6.0.0 version of the package will be substantially similar to the 6.0.0-wip one.


Fix restore functionality for translation

This adds the translate or offset value to the original metadata, so that value can be restored after editing in the widget. I modified the associated tests to check that happens.

Codecov Report

Merging #54 (9d83e33) into main (7c430ab) will increase coverage by 0.04%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   93.46%   93.50%   +0.04%
==========================================
  Files          16       16
  Lines        1453     1463      +10
==========================================
+ Hits         1358     1368      +10
  Misses         95       95

Impacted Files
Coverage Δ

src/napari_metadata/_sample_data.py
34.61% <ø> (ø)

src/napari_metadata/_model.py
93.68% <100.00%> (+0.20%)
:arrow_up:

src/napari_metadata/_reader.py
72.59% <100.00%> (+0.20%)
:arrow_up:

src/napari_metadata/_tests/test_widget.py
99.63% <100.00%> (+<0.01%)
:arrow_up:

src/napari_metadata/_widget.py
93.26% <100.00%> (+0.09%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


http://localhost/laradrop/containers NOT FOUND

Hi Jasekz,
Thank for your package. It's interesting me. But I have a problem when install it into my project. When I install and run my url it show alert "Not Found". I followed all steps to install. Thank Jasekz again. Regards,

@minhliem86 Is your app located in a subdirectory, i.e http://localhost/myapp?  Also, please take a look at https://github.com/jasekz/laradrop/issues/16 to see if anything there may apply to your situation.

Thanks jasekz so much.

@minhliem86 I'm going to close this out.  Feel free to reopen if the issue is not resolved.


Feature/cblox ros

First code in master. Adds

cblox library
cblox_ros, which includes
** a small ROS interface,
** an example launch file for running kitti with lidar and ground truth localization.
Documentation to build and run the example.

@victorreijgwart Dunno if you wanna have a quick look at this. We've both looked at it so I guess it should be fine at this point.

SLGTM


🔴 Dataview Table Display Error in Version 7.0.0

Is the bug present when using the default Obsidian theme?
Yes
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
7.0.0
Describe the bug
00

Obsidian: 1.3.5
Minimal Theme: 7.0.0
Dataview: 0.5.56
Style Settings: 1.0.6

01

In version 7.0.0, using cssclass: max will cause "Dataview-Table" to display an error
Makes the table width displayed in “Dateview-Table” wrong
But using cssclass: wide is normal
This is also normal in older versions

02

In version 7.0.0, "Dateview-Table" always shows "Row lines"
Option "Style Settings > Minimal > Tables > Row lines" disappeared in version 7.0.0
Only “Style Settings > Minimal > Tables > Column lines” options remain
Cannot use "Style Settings > Minimal > Tables > Row lines & Column lines" to adjust whether the table borders are displayed or not as in the old version.

Debug info
None

Fixed in 7.0.1


Add reverse permutation for LNN connectivity

Summary
See #9036
Add reverse permutations in depth 2n+2 based on Section 5 of Kutin et al. (https://arxiv.org/abs/quant-ph/0701194)
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

27 of 27 (100.0%)  changed or added relevant lines in 4 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 89.365%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
94.03%

crates/qasm2/src/lex.rs
3
92.11%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
60179

Relevant Lines:
67341

💛  - Coveralls


cigien: Watch pingpongbuzz.com

cigien requests the watch of the watch_keyword pingpongbuzz\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

pingpongbuzz\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Aliasing an import created by createActions or just import specific actions?

Given my redux file:
DeviceNotificationSubscriptionRedux.js
import { createReducer, createActions } from 'reduxsauce'

const { Types, Creators } = createActions({
  subscribeDevice: ['userId', 'authToken'],
});

export const DeviceNotificationSubscriptionTypes = Types;
export default Creators

export const success = (state) => { fetching: true }

export const reducer = createReducer({ fetching: false }, {
  [Types.SUBSCRIBE_DEVICE]: success,
});

This is what my import looks like:
import DeviceNotificationSubscriptionActions from 'DeviceNotificationSubscriptionRedux'
Is there a way to alias this import or just import SUBSCRIBE_DEVICE action?
This doesn't seem to be working:
import { subscribeDevice } from 'DeviceNotificationSubscriptionRedux'

For named exports, they have to leave the file with the right name.
export const subscribeDevice = Creators.subscribeDevice
export const SUBSCRIBE_DEVICE = Types.SUBSCRIBE_DEVICE

That gets awfully typey though.
This article might help clear up the confusion.


Lsp Zero breaks after commit eaff24b on dev-v3

After yesterdays update, my lsp breaks down on a certain situation. If I start neovim and use telescope, it produces an error.  but if I do not start telescope and open a file randomly, the lsp works fine and telescope works fine after lsp is loaded. I think it is related to the way the plugins are being loaded but everything was working perfectly fine till yesterday before I updated to the latest version.
Some sort of help or guidance would be pretty helpful for me.
Neovim Version:
NVIM v0.10.0-dev-1041+g2ef7b6a43
Error Image:

Are you using the dev-v3 branch?

@VonHeikemen Sorry for taking so long to reply, something came up in my personal life.
For your question, yes I was using the latest branch of the dev-v3 but the later commits fixed it. Maybe, it is my fault for not waiting and creating an issue too early.

No problem.
By the way, the stable branch for version 3 has been created. Use the branch v3.x instead of dev-v3.


Authorization error

I receive the following error message after entering the API Key/Secret:
Traceback (most recent call last):
	7: from /usr/local/bin/t:23:in `<main>'
	6: from /usr/local/bin/t:23:in `load'
	5: from /Library/Ruby/Gems/2.6.0/gems/t-3.1.0/bin/t:20:in `<top (required)>'
	4: from /Library/Ruby/Gems/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	3: from /Library/Ruby/Gems/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	2: from /Library/Ruby/Gems/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	1: from /Library/Ruby/Gems/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
/Library/Ruby/Gems/2.6.0/gems/t-3.1.0/lib/t/cli.rb:82:in `authorize': uninitialized constant Twitter::REST::Client::BASE_URL (NameError)

Duplicated
https://github.com/sferik/t/issues/402


Parameter defaults ignored when nested inside hash

I'm not sure if this is the intended behavior or not, but there appears to be a problem with the :default option on params that are nested inside another param of type Hash.
For example, given this code:
params do
  optional :filter, type: Hash do
    optional :status, default: 'new'
  end
end
get do
  params
end

If I call this API, I would expect to get back:
{ "filter": { "status": "new" } }

but instead it will respond with
{}

I have a commit with an example failing test case.
https://github.com/tlconnor/grape/commit/26beeab

Does setting default on :filter change anything?

Does setting default on :filter change anything?

It does not help. Adding default: {} to the parent results in:
{ "filter": {} }

Looks like a bug. PRs welcome.

@dblock I would like to create a fix for this this, can you please point me to the right direction?

@sekmo Start by writing a failing RSpec test?

@dblock I mean can you point me to the part in the codebase where we deal with this logic?

Thank you, I'll check it out as soon as I have some time :)

Confirming this. Even when used example from the docs:
params do
  optional :audio, type: Hash do
    requires :format, type: Symbol, values: [:mp3, :wav, :aac, :ogg], default: :mp3
  end
end

get do
  params # {}
  declared(params) # {"audio"=>{"format"=>nil}}
end

Expected result {"audio"=>{"format"=>:mp3}}.
I'll try to provide failing spec later.


Add time tracking for issues

Hello,
This PR adds the Time Tracking features (set/reset time estimate, set/reset time spent, display time stats) for an Issue.
Cf https://docs.gitlab.com/ee/api/issues.html#set-a-time-estimate-for-an-issue
I hope this helps! This is my 1st contribution here, let me know if something is missing!

Looks good, thanks!


sc-3973 Legal person customer number basic component

Codecov Report

Merging #375 (67535ba) into main (108cbb5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   45.94%   45.92%   -0.02%
==========================================
  Files         224      224
  Lines       11054    11054
  Branches      606      606
==========================================
- Hits         5079     5077       -2
- Misses       5058     5059       +1
- Partials      917      918       +1

Impacted Files
Coverage Δ

directory/pkg/gds/gds.go
65.51% <0.00%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108cbb5...67535ba. Read the comment docs.


Added a features parameter to the internal calls of supervised learning.

@znation -- There is some logic in python that should be moved to C++ now that this is here, but this is needed for calling through the C-API layer.


Channel for large percentual changes in price on the 5m

For instance alert if $BTC is -7% in one candle

#67

We need a websocket for all crypto prices, this is doable.
At what % do we send an alert? +5%?

Would this really be useful? We could open a Binance websocket for all tickers, but it seems like this is not a great approach to find activate tickers. Beside, the point of the project is to be more focussed on social media / sentiment.


Announcement: dbt-athena-community

Hello everyone,
I want to take a few seconds of your time to announce that the dbt-athena community has taken the difficult decision to fork the current project and start a parallel and fully community-driven initiative to support the dbt-athena adapter.
Various changes were added in the last weeks at a faster pace thanks to the community. We now support dbt 1.3.0, Apache Iceberg, and many more features that will be released soon.
The new community aims to be fully community driven while maintaining direct connections with both dbt and AWS. Conversations with both parties are already underway.
You can find us at dbt-athena/dbt-athena. If you have open issues or feature requests here, please move them to dbt-athena/issues. Contributions are highly welcomed. See https://github.com/dbt-athena/dbt-athena/issues/66 for more details.
The main communication channel is #db-athena in the getdbt slack

This is so exciting! Is there a plan to put something in the readme to redirect people to the community fork?

This is so exciting! Is there a plan to put something in the readme to redirect people to the community fork?

Probably not, we tried to contact @Tomme (which is the only maintainer here) multiple times but without much luck.

Hi Team - Can we connect athena using AWS role. Is it possible?


testEcho() now works with Python 2 and Python 3

Ready to review/merge.

Closed in favor of https://github.com/openwhisk/openwhisk/pull/2007


poc: [M3-8631] - Use pnpm as our package manager

Description 📝

Uses pnpm as our package manager instead of yarn (classic) 📦
Doing this because yarn is no longer maintained 🧶
Opening this PR to see how chose/far we are from migrating 🆕
We can't use v9 yet because of https://github.com/dependabot/dependabot-core/issues/10534

How to test 🧪

[!warning]
Work in progress / POC

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Will revisit after https://github.com/linode/manager/pull/11005


move Step init logic from executor to library

Both the local and linux executors have to init a step object in a couple of places. This moves that logic into library to facilitate reuse.
The executor can't use StepFromContainer because that relies on the container Environment which is not configured yet.  So, we rename StepFromContainer to StepFromContainerEnvironment to more accurately represent what it does. Then we add a new StepFromBuildContainer function to create a new Step and initialize it using data from a library.Build and a pipeline.Container.
For background, see the conversation here: https://github.com/go-vela/pkg-executor/pull/179#discussion_r735875710
This should be merged before https://github.com/go-vela/worker/pull/239

I prepared the PR for the worker: https://github.com/go-vela/worker/pull/239


chore: add type="module" to package.json

This is needed so bundlers no what to do and expect (for example Vite)
This fixes #11

Would it be possible to have a look at this PR? Thanks

Thanks :-) Could you also tag a release?

Thanks :-) Could you also tag a release?

Done!


[QT-Wallet] "MWC" should be always in CAPS

Description:
"MWC" should be always in CAPS, but in the login screen it is in small case.
Please refer the screenshot for more details.

@mwc-design ,  I think it is a logo, so like this is fine?


I am running the workshop of serverlesspresso and I am getting this error

Resource handler returned message: "The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: 10b9bca8-1a3b-4782-bbdf-0be6def68c44)" (RequestToken: 428f38f8-1971-aec1-d05e-81d773623783, HandlerErrorCode: InvalidRequest)

I am also getting this error today. I updated the runtime in the cfn templates to nodejs20.x but sam will not pick up the new version and keeps using 14 for some reason...

Hi @kimberlyamandalu, thanks for your bug report. The issue can be resolved for now by updating the runtime version of the Lambda functions to Node v16. An upgrade to Node v20 isn't as easy, as that version uses the AWS SDK v3 instead of v2.
We are currently working on updating the functions to resolve this.

Duplicate of #53

Hi, the template has been updated and it should work again. Could you please test it again


Phassets warning

Xcode is giving a warning:

'imagePicker(_:didFinishPickingImages:)' is deprecated: This function will be removed from future versions. Please switch to using imagePicker(_,didFinishPickingAssets), and download UIImage using the PHAsset APIs.

Closes https://github.com/opalorange/OpalImagePicker/issues/56

@opalorange thanks for the amazing job! Would you have a chance to check this?

I added a commit that addresses this issue. Thanks!

Closed by https://github.com/opalorange/OpalImagePicker/commit/cf063ebc059b5f35dd1edcaaa0a99b278bf3e1d1


implement workarounds for division by zero

This now looks ready to me. This uses 0 as the result of the division if it would be 0/0.
See for a similar PR on game side:

https://github.com/Unvanquished/Unvanquished/pull/2533

Original message:
This is a draft and work-in-progress.
I dirtily enabled exceptions for divizion by zeros to catch them, and implemented mindless dirty workarounds for some of them.
This needs more thoughts for better workarounds. For now I divided by 1 any time there was a divizion by zero, but some other cases may require better values, like actually returning 1 for the whole division if we do 0/0, or returning a specific default value for when it cannot be computed.
That's why this PR is marked as work-in-progress.

Interestingly if I set minMsec to 0 when upcaping framerate, I get crazy fps:

It looks like this code was doing if 0 < 1; sleep 1ms  and then waited at least 1ms when framerate was unlimited:
	msec = com_frameTime - lastTime;

	while ( msec < minMsec )
	{
		//give cycles back to the OS
		Sys::SleepFor(std::chrono::milliseconds(std::min(minMsec - msec, 50)));

And with those division by 0 fix patches, things do not glitch:

When I tried this, there were way more places in the renderer with division by zero than just one. I decided against trying to "fix" them as this would just make the code slower and not fix any actual bugs.

I found another division by zero by reproducing the bug that totally breaks the renderer while going outside of the metro map in some places. By totally breaking the renderer I mean even loading a new map can't fix it, one has to entirely quit the game and restart the engine.
Unfortunately avoiding the division by zero doesn't fix the bug.
1900 -1971 100 -40 9
Warn: div: 0.000000

Thread 1 "daemon" received signal SIGFPE, Arithmetic exception.
0x000055555566dbe4 in SetViewportAndScissor () at Daemon/src/engine/renderer/tr_backend.cpp:758
758			scale = 2.0f / div;

Thread 1 (Thread 0x7ffff59fba40 (LWP 1792738) "daemon"):
#0  0x000055555566dbe4 in SetViewportAndScissor () at Daemon/src/engine/renderer/tr_backend.cpp:758
#1  0x0000555555678cf3 in RB_RenderView (depthPass=false) at Daemon/src/engine/renderer/tr_backend.cpp:4686
#2  DrawViewCommand::ExecuteSelf (this=0x7fffd74ccb94) at Daemon/src/engine/renderer/tr_backend.cpp:5588
#3  0x000055555566da49 in RB_ExecuteRenderCommands (data=<optimized out>) at Daemon/src/engine/renderer/tr_backend.cpp:5832
#4  0x000055555568b752 in RE_EndFrame (frontEndMsec=0x0, backEndMsec=0x0) at Daemon/src/engine/renderer/tr_cmds.cpp:889
#5  0x00005555556161b0 in SCR_UpdateScreen () at Daemon/src/engine/client/cl_scrn.cpp:327
#6  0x00005555556084ed in CL_Frame (msec=msec@entry=1) at Daemon/src/engine/client/cl_main.cpp:2553
#7  0x00005555555a0c5f in Com_Frame () at Daemon/src/engine/qcommon/common.cpp:1031
#8  0x000055555559a37d in main (argc=<optimized out>, argv=0x7fffffffd938) at Daemon/src/engine/framework/System.cpp:762

@illwieckz  something like this ?

I removed a workaround in favor of a proper fix:

https://github.com/DaemonEngine/Daemon/pull/813

can I get some approval?

The beacon ones seem wrong to me. The clamp_dir field of cbeacon_t is set only if the calculation of the preferred 2d position of the beacon is off-screen and it needs to be moved to be on the screen (this condition is indicated by clamped = true). So it's a bug that this ProjectPointOntoRectangleOutwards is performed for some reason when clamp_dir is not set. If there is no distance from the center of the screen, the operation should have been skipped.

The beacon ones seem wrong to me. The clamp_dir field of cbeacon_t is set only if the calculation of the preferred 2d position of the beacon is off-screen and it needs to be moved to be on the screen (this condition is indicated by clamped = true). So it's a bug that this ProjectPointOntoRectangleOutwards is performed for some reason when clamp_dir is not set. If there is no distance from the center of the screen, the operation should have been skipped.

I caught division by zero with the 2 others occurrence just by being unlucky at looking there or being there. I haven't reproduced with beacon but I haven't tried.

2 out of 3 cases are using clamp_dir from the beacon struct. The other one is the minimap. It uses the same kind of logic, where ProjectPointOntoRectangleOutwards is only supposed to be called if the point is outside the rectangle. So it is also a bug. There are no non-buggy cases.

I noticed that the usage of ProjectPointOntoRectangleOutwards in cg_beacon.cpp is using the result of CG_WorldToScreen. So your fix for CG_WorldToScreen in the gamelogic zero division PR likely prevents the bug.

Can I at least merge the first commit?

tr_bsp: implement workaround for division by zero

If I'm rioght it's about a division by zero occurring when loading data from BSP file, by using data from the BSP file.

Yeah the BSP lighting one LGTM.

Yeah the BSP lighting one LGTM.

I merged this commit.

So, there is one unmerged commit remaining in this branch, this also means the related division by zero is still alive.
Here is the dedicated thread for this specific commit:

https://github.com/DaemonEngine/Daemon/pull/812/files#r1186484684

Obsoleted by https://github.com/Unvanquished/Unvanquished/pull/3028


staging merge to live-based

Version(s) of document impacted

[ ] Impacts 6.next document
[ ] Impacts 6 document
[ ] Impacts 5.1 document
[ ] Impacts 5.0 document
[ ] Impacts 4.0 document
[ ] Impacts 3.0 document

Reason(s) for not updating all version of documents

[ ] The documented feature was introduced in version (list version here) of PowerShell
[ ] This issue only shows up in version (list version(s) here) of the document
[ ] This PR partially fixes the issue, and issue # tracks the remaining work

Docs Build status updates of commit d38e5d4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch live-based has been deleted or has been force pushed: fatal: Could not parse object '8e35b203fa84756aa3ce963252921033b01667ea'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d38e5d4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch live-based has been deleted or has been force pushed: fatal: Could not parse object '8e35b203fa84756aa3ce963252921033b01667ea'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d38e5d4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch live-based has been deleted or has been force pushed: fatal: Could not parse object '8e35b203fa84756aa3ce963252921033b01667ea'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


import FlashDepthwiseConv1d?

I found that in the model.py, FlashDepthwiseConv1d is used, but it seems that FlashDepthwiseConv1d is not imported.

@Hambaobao #7 should fix this.

Great!


Drag-and-drop does not work in web editor.

Godot version
4.2.beta1
System information
Godot v4.2.beta1 - Web - GLES3 (Compatability) - WebKit WebGL - (2 Threads)
Issue description
Whenever you try to drag and drop a file into the FileSystem on the web editor, it gives me this error “Failed to open /tmp/drop-(number)/(image file name).(file extension” (replace parentheses with file) I found out you can add files by downloading the project source, unzipping, adding the file, zipping, and then re-importing.
Steps to reproduce

Create and open a new project
Try to drag a file onto the FileSystem

Minimal reproduction project
N/A

I checked and it does not have this problem on Windows.

Could not reproduce on Chromebook.

Somehow it was fixed. Closing.


Create new table user_notes

PR #94 command uses table user_notes. If we don't make this available before merging the PR, is going to crash.
Table name: user_notes
+-----+---------+---------------+ ----------+
| id  | user    | Moderator     | Note |

@Vic-ST took care of this


macOS Metal backend support

I think sdl2 supports metal.
Its supported in other SDL2 bindings eg for Julia: https://github.com/JuliaMultimedia/SimpleDirectMediaLayer.jl/blob/bf7ec1bad5839f6e5b15f2e5aed09ee94a093939/src/LibSDL2.jl#L1948
It looks like node-sdl doesn't support this window mode.

@ExProbitasFiducia For using APIs like Metal, Vulkan, and DirectX12 I think it's a better idea to use the WebGPU APIs: https://www.npmjs.com/package/@kmamal/gpu. WebGPU will automatically use Metal, Vulkan, or DirectX12 under the hood, depending on if you are on Mac, Linux, or Windows, and you don't have to write custom code for each platform. As a bonus point the same code will also work in a web browser.
I could of course add an option to use the metal backend to node_sdl, but then you would also need bindings for the metal api functions. Do you have such bindings? I can't find any relevant packages on npm. Are you planning on implementing them yourself?


x/tools/gopls: makes http requests to random websites while editing module directive

In an attempt to make a small reproducer for https://github.com/golang/go/issues/43186, I created a go.mod that started:
module vanilla.xyz
After saving, I selected the word vanilla and started typing "chocolate" as a replacement. As I typed, gopls started attempting to retrieve results from intermediate domains choco.xyz, chocola.xyz, chocolat.xyz, despite me not hitting save. Sample alert from Little Snitch:

The partial module import path seemed to get cached, because well after I finished typing an hit save, I still got this error:

gopls currently tries to reload package metadata as you modify import statements in your file, which is why you saw these requests. We have made some changes in recent weeks to default to GOPROXY=off--can you try the latest gopls pre-release and confirm that it fixes the issue? You can download it by running GO111MODULE=on go get<EMAIL_ADDRESS>


Quote original command arguments.

This allows for commands like php foo.php "argument 1" "argument 2" to be handled correctly.

Won't this make a string literal of the entire command? "php foo.php argument 1 argument 2"

The quotes are retained around argument 1 and argument 2.  I tested this with and without a timeout and it works fine both ways.
A simplified test:
$ testfunc () { echo "$# parameters"; echo "$@"; "$@"}
$ testfunc echo hello
2 parameters
echo hello
hello
$ testfunc echo "Hello, world"
2 parameters
echo Hello, world
Hello, world
$

This was helpful for understanding how bash does expansions.

Cool!


Link to docs doesn't work for Span

Describe the bug
There's an awesome feature that when you display a type, it outputs the type's name and a hyperlink to the docs.
However, if you display the type Span<byte>, the URL isn't correct.
Did this error occur while using dotnet try or online?

[ ] dotnet-try
[x] .NET Jupyter Notebook
[ ] online

What kind of error was it?

[ ] User Interface (UI):  For example the output never displayed
[ ] Service Error: For example "The service is temporarily unavailable. We are working on it"
[x] Other:

Screenshots

clicking that hyperlink brings me to:
https://docs.microsoft.com/en-us/dotnet/api/System.Span%601%5B%5BSystem.Byte,%20System.Private.CoreLib,%20Version=<IP_ADDRESS>,%20Culture=neutral,%20PublicKeyToken=7cec85d7bea7798e%5D%5D?view=netcore-3.0

Please complete the following:

OS

[x] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[x] Chrome
[ ] Edge
[ ] Safari

This feature is an example of some of the ideas we have for using custom formatters for specific types. @BillWagner and I discussed expanding this to query docs.microsoft.com in order to more accurately locate the correct documentation.

It is an awesome feature BTW. Looking forward to more innovation in this space.


OpenMP: Unable to specify a shared variable

From the documentation, "Other OpenMP parameters like private, shared or reduction, are inferred automatically by the compiler."
What if Codon assumes wrongly? I wish for the ability to specify last_completed a shared variable, not made private. I'm in a critical block and not incrementing the variable, but instead assigning a value (e.g. not for reduction).
last_completed = -1

@omp.critical
def show_progress(high, limit):
    completed = int(float(high) / limit * 100)
    if completed != last_completed:
        last_completed = completed
        print(f"\rprogress {completed}% ", file=stderr, flush=True, end='')
        stderr.flush()

Error:
error: local variable 'last_completed' referenced before assignment

It's has been an interesting journey, experimenting with OpenMP using C and Codon.

@marioroy last_completed is a global vaiable. You are referencing it in if completed != last_completed: before assignment. The assignment happens at last_completed = completed. At this point last_completed is no longer a global variable. This doesn't work in Python either.

Thank you, @elisbyberi. I see now and understand.


Documentation: improve the managing-queues section of the Quick-start by adding a reference to the Deploying the broker section.

In the managing-queues section the user is invited to apply some changes to a broker pod.
However while running the sections one after the others I terminated the broker pod just before starting the managing queues section.
I propose to add a paragraph stating that a broker pod must be up and running to be able to apply the commands in this section. And to add a link to the Deploying the broker section.
This way if anyone runs the documentation in any order it should be easier to avoid the issue I was facing.

Fixed by https://github.com/artemiscloud/activemq-artemis-operator/pull/844


File type for .dockerignore should not be named 'Docker'

Extracted from https://youtrack.jetbrains.com/issue/IDEA-174706
Actually the filetype for .dockerignore files is named Docker in UI.
See attached screenshot showing 2 competing same-named Docker entries.

The black icon is from ignore plugin while "with-D" icon is from the Docker support plugin.
The fact that the black-whale icon is actually much nicer :) probably only contributes to the confusion of the users.
In addition to UI name, the key used to store the filetype association is actually also "Docker file" which is again competing with the official Docker support plugin, see the following extract from /options/filetype.xml file:
<application>
  <component name="FileTypeManager" version="17">
    <extensionMap>
      <mapping ext="custom-dockerignore" type="Docker file" />
      <mapping pattern="custom-docker-file" type="Dockerfile" />

The latter (the key in the options file) is more difficult to change, but UI name should be easy to fix.
Thanks

@borlander Thanks for this ticket. I agree with you that people can be confused with the very simmilar name.
I'll refactor those names (not only Docker but all the other file types too) and publish it with v2.0.0

@borlander Ok, I've updated the displayed name of the ignore-file types. Currently it looks like:


Adding versioning to the staging bucket created by cdk bootstrap

Hello,
I have a use case where I would like to use the staging bucket created by cdk bootstrap in the source stage of my CodePipeline that is created as part of my CDK application. While my synthesized CloudFormation stack will create successfully and my asset code will be successfully uploaded to the staging bucket, my CodePipeline will fail to execute because the staging bucket does not support versioning.
I see that the CFN template that creates the staging bucket is hardcoded in bootstrap-environment.ts. Would it be possible to add the VersioningConfiguration property to the S3 bucket resource or is there a particular reason why versioning is disabled?
Thanks!

Hi @lboucher, thanks for the question. I'll forward this to the people working on CodePipeline support.

Hey @lboucher, would you be able to provide a little extra context on what you are trying to do, from a broader perspective?
I always thought of the CDK bootstrap stack's content as an implementation detail of the CDK toolkit, so I'm super interested to know more about your use-case so we can make sure we determine the best way forward here.

Hi @RomainMuller ,
Thank you for the quick response.
Currently, I am just experimenting with the CDK in order to get more familiar with it. As part of my learning I thought I would try to make an app that makes a simple CodePipeline. The CodePipeline would consist of a source stage (which would be a S3 bucket) and a deployment stage that uses CodeDeploy to deploy to an autoscaling group of EC2 instances.
During my experimentation I read about the assets feature that allows one to package local files and directories which are needed by the CDK app to function.
https://awslabs.github.io/aws-cdk/refs/_aws-cdk_assets.html
The example provided talks about packaging handler code for a Lambda function, but I started wondering if I could use the assets feature to package and upload the web application I was planning on deploying using CodeDeploy. I saw that the assets feature uploads the files to a staging S3 bucket that is created as part of the cdk bootstrap command. This functionality got me wondering if I could use that same staging bucket as a source for my CodePipeline. If the code is in place in S3 once the CodePipeline resource finishes creation then a deployment of my application can start immediately.
To test, I ended up modifying my local version of the "bootstrap-environment" file so that it creates a S3 bucket that supports versioning. Once this change was in place I decided to try to following in my CDK application:
First I place the code I want to deploy using CodeDeploy in a directory called "sample-asset-directory". I then tell my cdk application to zip that directory and upload it to the staging bucket:
const asset = new assets.ZipDirectoryAsset(this, 'SampleAsset', {
path: './sample-asset-directory',
versioned: true,
});
I then add the bucket to my CodePipeline as the source stage and point CodePipeline to the s3 object key of my assets zip file:
const sourceAction = asset.bucket.addToPipeline(sourceStage, 'S3Source', {
bucketKey: asset.s3ObjectKey,
});
Since the asset zip file is uploaded before the CodePipeline is created then a deployment is automatically triggered to my EC2 instances once the CopePipeline finishes creation.
From my observations the synthesized CloudFormation stack and all of the resources it manages create successfully. By adding the versioning configuration to the staging S3 bucket my CodePipeline is able to grab my code from the bucket and deploy it to my CodeDeploy deployment group successfully. Without versioning on the bucket the execution of the pipeline won't work as CodePipeline requires S3 buckets that are used in a source stage to have versioning enabled.
The other cool thing I can do is I can update the code in the "sample-asset-directory" and then run cdk deploy. When cdk deploy is executed the CDK will upload a new version of the assets zip file to the staging S3 bucket. This in turn will trigger the CodePipeline to deploy the newest iteration of code to my EC2 instances with CodeDeploy. This makes it easy to deploy new iterations of my CodeDeploy application to my deployment group by using the cdk deploy command.
I imagine this work flow could maybe be used to package and deploy applications to Elastic Beanstalk as well. The deploy stage of the CodePipeline would just have to point to an Elastic Beanstalk environment. I haven't tested this functionality yet though.
I hope this is sufficient information about my use case. I am new to the CDK and am still learning so I am open to feedback. Feel free to let me know if there is a more preferred method of accomplishing my use case or if anymore information is needed.
Thanks!

I am wondering if a better approach would have been to use bucket deployments.
What do you think?

@lboucher Please re-open if bucket deployments won't work for your use case and we'll continue the conversation.


Serializing Vector of Struct T

Hello, I have done a lot of reading but have not seen anyone with this same problem. Or I may have missed it. I'm trying to serialize a Vec<T> where T is a struct with 2 fields. The output of the toml::to_string() function outputs it as follows:
[[]]
field1 = "string"
field2 = false

And this works with no errors. But the biggest problem is it cannot be deserialized because of [[]] brackets as it will throw an error -
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { inner: ErrorInner { kind: Wanted { expected: "a table key", found: "a right bracket" }, line: Some(0), col: 2, at: Some(2), message: "", key: [] } }', src/main.rs:251:5

I'm kind of new to Rust and i'm not sure if this is a place to post it but I would really appreciate it if someone could guide me with it.

This is a bug that should be fixed in this crate to return an error instead of silently succeeded (or auto-using inline tables), but in general tables only really work as a top-level serialization.

This is a bug that should be fixed in this crate to return an error instead of silently succeeded (or auto-using inline tables), but in general tables only really work as a top-level serialization.

Thanks for the reply. Sorry but, can you please explain what you mean by

but in general tables only really work as a top-level serialization.
I'm not really sure if you're saying it is not possible to do what I'm trying to do or there is another specific way of doing it.

@alalfakawma You need to place the vec into a container.  TOML works with key/value pairs, and that means a map or struct.  Example:
#[derive(Serialize)]
struct Foo {
    f1: i32,
}
// Instead of this...
let foos = vec![Foo{f1: 1}, Foo{f1: 2}];
println!("{}", toml::to_string(&foos).unwrap());

// Do this:
#[derive(Serialize)]
struct Container {
    foos: Vec<Foo>,
}
let b = Container{foos};
println!("{}", toml::to_string(&b).unwrap());

to_string should not be accepting non-map types.

types

Good point. Now I need to refactor my code 😅 to use the container. Thanks for the help guys.


Badge page

Badge page is ready to go. Test page: https://deploy-preview-15--peaceful-darwin-86c101.netlify.app/badge/RJXB-1

@webmaxru Looks good to me.
Out of curiosity, do you know if Netlify caches the results of the function or does it run anew every time?

@aarongustafson I couldn't find anything related to "regular" Netlify functions results caching. But it's not relevant for our scenario anyway - our badge generation function is more a wrapper which accepts new parameter every time during call from the webhook.
It's more interesting about on-demand builder function - we use it for the page generation. From the docs: "Response caching is based on the URL path and can’t be customized." so it exists but we don't have control over it.


DS Condition Support (was RFC 242)

Add support to DS for components to have an implicit Condition reference.

This support is already integrated in the main branch for DS 1.5.


fix accents on card

@kcbreuil  this heading and accent aren't aligning with the copy and button below.

Browser metadata
Path:      /
Browser:   Chrome 91.0.4472.77 on Mac OS 10.15.7
Viewport:  1677 x 914 @2x
Language:  en-US
Cookies:   Enabled

View on BrowserStack

Open Deploy Preview · Mark as Resolved


Added Test Coverage Tracking

Description of Work
Fixes #112
Added test coverage tracking with coveralls. Now using a testing framework named pytest to get coverage data and export it to coveralls.
Testing Instructions
Go to https://coveralls.io/github/mantidproject/fitbenchmarking to check the coverage.

could you please fix the conflicts


Release <IP_ADDRESS>

Codecov Report

Merging #123 (43edfed) into develop (ba2c062) will decrease coverage by 1.96%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             develop    #123      +/-   ##
============================================
- Coverage       7.46%   5.50%   -1.96%
- Complexity        12      14       +2
============================================
  Files             12      12
  Lines            576     581       +5
  Branches          29      30       +1
============================================
- Hits              43      32      -11
- Misses           532     549      +17
+ Partials           1       0       -1

Flag
Coverage Δ

IntegrationTests
?

UnitTests
5.50% <100.00%> (+2.38%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main/java/com/napier/sem/CityReporting.java
7.73% <100.00%> (+7.73%)
:arrow_up:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Require Challenge authors to have an email address on file

I am not a fan of requiring more information from users than strictly necessary, but being able to get in touch with challenge authors is becoming more important to address issues like #1520. Some use cases:

Enabling communication between mappers and challenge authors (not directly over email, but through MapRoulette messaging which would be forwarded to author email)
Letting authors know about / subscribe to the status of their challenges to keep them engaged
Letting authors know that their challenge is about to be made invisible due to inactivity (if and when we implement this)
For MapRoulette administrators to get in touch with authors about system updates and other administrative issues that may require action on their part.

Note that we'd also need some kind of email validation flow.

Howdy! Sorry to intrude. I just started trying MapRoulette out after someone suggested it for a big task we're planning.
Wanted to ask why email is required to be able to create a challenge?
OSM itself already has several means to communicate directly with a user, one of them being private messages, that work similarly to email except that the email itself is never shared with anyone (AFAIK). So essentially, I see two cons: my email being (unnecessarily) shared with MapRoulette users (or did I understand that wrong? (*)); and reimplementing the reimplementation of the wheel.
Even if email is not shared with other users, why can't OSM messages be used? Is there a technical reason for it? (I haven't searched around the OSM API to see if messages are programmatically accessible)
(*) You do say "not directly over email, but through MapRoulette messaging" but I don't know if that's been implemented or if it is still the plan.
And thanks for MapRoulette, it looks like it's exactly what we need for the mentioned plan! :)

You're welcome :)
The main reason we require an email address for Challenge owners is that there is no API for OSM messages, so MapRoulette cannot send automated messages for issues that require your attention, such as challenges being completed or made inactive because of inactivity.

Thanks for the reply! And is the email made public to anyone, with or without a MapRoulette account? Or is it used exclusively internally?


Give Textbox in Settings the Same Margin as Buttons

The textbox for testing the keyboard doesn't have any margins. It sticls to the sides of the screen while the buttons are nice and centered.

Proposal: Make text-bar shorter.
(Also, make it bigger if the user types an Enter)

Proposal: Make text-bar shorter.
(Also, make it bigger if the user types an Enter)

noted.
On Fri, 1 Jan 2021, 16:09 Glitchy-Tozier<EMAIL_ADDRESS>wrote:

The textbox for testing the keyboard doesn't have any margins. It sticls
to the sides of the screen while the buttons are nice and centered.
[image: Screenshot_20210101-113126_8Vim.jpg]
https://user-images.githubusercontent.com/59611881/103437238-74158380-4c25-11eb-818a-6c78450df806.jpg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/156, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX5WRZL6YJLMVD6ZBP3XGLSXWQ73ANCNFSM4VQFVZMQ
.

noted.
On Fri, 1 Jan 2021, 16:09 Glitchy-Tozier<EMAIL_ADDRESS>wrote:

The textbox for testing the keyboard doesn't have any margins. It sticls
to the sides of the screen while the buttons are nice and centered.
[image: Screenshot_20210101-113126_8Vim.jpg]
https://user-images.githubusercontent.com/59611881/103437238-74158380-4c25-11eb-818a-6c78450df806.jpg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flide/8VIM/issues/156, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX5WRZL6YJLMVD6ZBP3XGLSXWQ73ANCNFSM4VQFVZMQ
.

@flide Not relevant anymore

Looking forward to seeing what you have changed.
(Btw, you might know this already but you can add "Closes #156" to your PR and the issue should get closed once flide accepts it.)

@Glitchy-Tozier thanks, didn't know that


feat(logger): customizing logger output

Issue #, if available: #138 and #143
Description of changes:
Ensure that the initial key seq is: level,location,message,timestamp so by default messages in Cloudwatch logs are easier to read:
>>> logger = Logger()
>>> logger.info("Eggs")
{'level': 'INFO', 'location': 'method_name:126', 'message': 'Eggs', 'timestamp': '2020-08-27 15:32:51,285', 'service': 'app', 'sampling_rate': 0.0}

Also allow for reordering override via format_keys
>>> logger = Logger(format_keys=["message"])
>>> logger.info("Foo")
{'message': 'Message', 'level': 'INFO', 'location': 'method_name:139', 'timestamp': '2020-08-27 15:36:11,494', 'service': 'app', 'sampling_rate': 0.0}

You can also suppress timestamp or location fields by passing them in as None
>>> logger = Logger(stream=stdout, location=None, timestamp=None)
>>> logger.info("magnus")
{"level": "INFO", "message": "magnus", "service": "app", "sampling_rate": 0.0}

Finally you can already customize the format for location and timestamp. So putting it all together:
>>> logger = Logger(location="%(module)s.%(funcName)s:%(lineno)d", timestamp=None, format_keys=["location", "message"])
>>> logger.info("takeoff")
{"location": "space.fly:7", "message": "takeoff", "level": "INFO", "service": "falcon", "sampling_rate": 0.0}

Checklist

[x] Meet tenets criteria
[x] Update tests
[x] Update docs
[x] PR title follows conventional commit semantics

Codecov Report

Merging #140 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #140   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           24        24
  Lines          706       706
  Branches        67        67
=========================================
  Hits           706       706

Impacted Files
Coverage Δ

aws_lambda_powertools/logging/formatter.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da0cce...133f260. Read the comment docs.

@heitorlessa  maybe we can make the order configurable or get some feedback on what it should be.

made a few comments ;)
Additional thoughts:

I'm not 100% sure format_keys is descriptive enough for whoever unfamiliar with powertools to read and understand what's going on

Maybe ordered_message_keys? Kind of unsure of the name. :)

You had a comment about suppressing sampling_rate and possibly others in the future, has that changed? This doesn't address that

For service and sample_rate I would have to add a check for if it was set to None, vs just being left out. I will have to think about how.

made a few comments ;)
Additional thoughts:

I'm not 100% sure format_keys is descriptive enough for whoever unfamiliar with powertools to read and understand what's going on

Maybe ordered_message_keys? Kind of unsure of the name. :)

You had a comment about suppressing sampling_rate and possibly others in the future, has that changed? This doesn't address that

For service and sample_rate I would have to add a check for if it was set to None, vs just being left out. I will have to think about how.

What about log_record_order? Seems explicit enough to me even as sleepy as I am now.
I'd suggest keeping as is in terms of suppression, there could be side effects on these two:

If the customer wants to use the dynamic sampling feat (I have a list of customers already using in prod)
service is integral to Powertools terminologies, and this will degrade ops capabilities when creating metrics/visualization from logs etc

I will keep the log suppression as it then. We should make have a better overview of Powertools in the main website which highlights this. I still don't quite understand log sampling :-)

Thank you @michaelbrewer - I've just noticed I don't have push permissions to your branch to update a tiny typo in the test comments, so I'm merging as-is and will fix-later.

Thank you @michaelbrewer - I've just noticed I don't have push permissions to your branch to update a tiny typo in the test comments, so I'm merging as-is and will fix-later.

Oops. Thanks.


Support PORT env var as alternative to MELTANO_API_PORT

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2091
Originally created by @DouweM on 2020-06-08 21:30:27

As @rabidaudio wrote in https://gitlab.com/meltano/meltano/-/issues/2081:

Heroku injects a PORT environment variable to tell the app which port to expose. Meltano allows this but uses MELTANO_API_PORT.

View 4 previous comments from the original issue on GitLab


Ember angle bracket syntax support in handlebars

Input
The code looked like this before beautification:
<SomeComponent as |sc|>
    ...some content...
</SomeComponent>

Expected Output
The code should have looked like this after beautification:
<SomeComponent as |sc|>
    ...some content...
</SomeComponent>

Actual Output
The  code actually looked like this after beautification:
  <SomeComponent
    as
    |sc|
  >
    ...some content...
  </SomeComponent>

Steps to Reproduce
Environment
OS: MacOS

Can you link to the spec or docs for this?  We'll also need a bit more context - is this in an html file or some other kind?

@bitwiseman check out documentation for block parameters here. It happens in handlebars files.


Provide a way to apply quick fixes/refactorings/code actions in a bulk automated fashion

Currently, we have several quick fixes and refactorings. Some of these are generally to help reorganize your codebase/fix issues, some are more to migrate from JS to TS more easily, and some are to more-easily opt in to a more strongly-typed version of TypeScript.
The problem here is that these quick fixes/refactorings can become painful when manually applied. Sometimes we want to apply them en masse - altoghether. But perhaps the way I see this as is something that could be applied granularly (individually), altogether at once, or in a one-at-a-time but nonetheless automated fashion (supervised).
Some prior art here we may want to look at for inspiration are jscodeshift.

Also related is #14549

Quick and dirty Node.js script from @weswigham for applying all import fixes to a project: https://gist.github.com/weswigham/f477373b6124cc43df5356c75f66911b
I've taken it and adapted it to try to create a command-line formatter which will use TypeScript Language Service Plugins too: https://github.com/karlhorky/ts-language-service-plugin-formatting-cli
It's currently not working with the demo code, but apparently there's a way to make it work: https://github.com/frigus02/typescript-sql-tagged-template-plugin/issues/20#issuecomment-753661829

Quick and dirty Node.js script from @weswigham for applying all import fixes to a project: https://gist.github.com/weswigham/f477373b6124cc43df5356c75f66911b
I've taken it and adapted it to try to create a command-line formatter which will use TypeScript Language Service Plugins too: https://github.com/karlhorky/ts-language-service-plugin-formatting-cli
It's currently not working with the demo code, but apparently there's a way to make it work: https://github.com/frigus02/typescript-sql-tagged-template-plugin/issues/20#issuecomment-753661829

autofixer for TS2835
works by parsing the "did you mean" output of tsc
useful to add ".js" extension to imports (#16577)
(experimental-specifier-resolution flag was removed in node 19)


Add Paolo Grisoli to Contributors list

@kind84, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


EditableField: Fixes email type UI glitches

Problems
There were a couple of visual bugs on email type fields reported by Jared:

Extra spacing: http://c.hlp.sc/ac63799be531
Weird deletion behaviour when space present in value: http://c.hlp.sc/7a4b054a1277

Solutions
1. Extra spacing
Before, I had a minimum width on the "first chunk" (the part before the @), which in cases like a single letter name, would be too much and show extra space.
I removed the minimum width and instead applied a couple of rules to the second chunk (the domain), I also simplified the markup and included the @ in the second chunk to avoid some cases in which I noticed there was some extra space added to the first chunk because of how flexbox behaves.
2. Character deletion when spaces present
This was a Chrome only bug, present when adding an "email" type to the input, I'm not sure why exactly, but the solution was to give the input a type of text even when given an email type, this shouldn't be a problem because we are using our own validation and not the browser bundled one.

Pull Request Test Coverage Report for Build 2616

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2615:
0.0%

Covered Lines:
21

Relevant Lines:
21

💛  - Coveralls

Welcome back JP! Looks good. Just checking though ... would we throw validation in this case (due to the space)?

@jaredmcdaniel validation is handled outside of the component. The component's responsibility is just to display the errors.


Missing clippy ignore lint

Now core tests are failing because this lint skipper got lost somewhere along the way.

Can someone perhaps explain how

clippy can return the large result error https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
but when it is told to ignore the large result error, it pretends that it's never heard of such a thing
How can there can be two versions of rust running simultaneously / switch depending on whether there's an allow -A clippy::result-large-err flag?

Seems like it was probably a caching issue


test: enhance trigger tests

not sure about merging this as this code is already covered.. hmm.

it's probably a good thing to have more tests, even if it doesn't bump code coverage


BungeeCord API problems

Hi, I'm having issues with latest travertine release. I think you need to update bungeecord API

That's not even remotely the latest release

That's not even remotely the latest release


CollectionView Scrolling Problem

Hi,
I'm trying to implement collectionView your codes into my project(UIViewController -> CollectionView) . But when i scrool up or down, screen scrool doesnt work properly. Sometimes scrolling work properly but sometimes doesnt work.
How can i fix this problem ?
Or
If you have a sample project using collenctionView, could you send me please ?
Thanks.

Same problem here. I am waiting to fix this problem.

I'm adding a collection view in the demo app. The implementation is identical to the other views, but there is one catch: the translucent bar breaks the scrolling. The weird thing is that sometimes it works fine.
I'll do some more digging.

Thanks.Same problem here

I'm having this issue as well and tracked it down to ScrollingNavigationController.swift line 323.  It appears that simply calling setContentOffset there with any value doesn't cause the content offset to actually change and instead causes the bouncing of the scrollview to break.
I was able to replicate this reliably in a small sample project with a plain UICollectionView implementation so it appears to be a bug in UIKit.

Hey @brandonroth
Thank you for the forensic work on this issue 👍
Did you file a radar?

Same problem here


fix: ensures that the promoted standby active connections are dropped after promotion

This patch drops all the connections made before the standby promotion are dropped.
Closes #736
Signed-off-by: Armando Ruocco<EMAIL_ADDRESS>

/ready-to-test

/ok-to-merge

/ready-to-test