Error generating sdk package for local development

Issue Name
Error generating sdk package for local development
Summary
I tried to run the sdk generation locally using the npm command, and I received the following output and error:
npm run generate:sdk:local

><EMAIL_ADDRESS>generate:sdk:local
> node scripts/generate-nestjs-sdk

Cleanup old files...
Generating the new sdk...
Unable to find image 'openapitools/openapi-generator-cli:v7.9.0' locally
v7.9.0: Pulling from openapitools/openapi-generator-cli
521f275cc58b: Pulling fs layer
...
1a31074fb300: Pull complete
Digest: sha256:bb32f5f0c9f5bdbb7b00959e8009de0230aedc200662701f05fc244c36f967ba
Status: Downloaded newer image for openapitools/openapi-generator-cli:v7.9.0
docker: Error response from daemon: create %cd%: "%cd%" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.
node:child_process:965
    throw err;
    ^

Error: Command failed: docker run --rm -v "%cd%:/local" openapitools/openapi-generator-cli:v7.9.0 generate -i http://host.docker.internal:3000/explorer-json -g typescript-angular -o local/@scicatproject/scicat-sdk-ts --additional-properties=ngVersion=16.2.12,npmName=@scicatproject/scicat-sdk-ts,supportsES6=true,npmVersion=10.8.2,withInterfaces=true
Unable to find image 'openapitools/openapi-generator-cli:v7.9.0' locally
v7.9.0: Pulling from openapitools/openapi-generator-cli
521f275cc58b: Pulling fs layer
...
1a31074fb300: Pull complete
Digest: sha256:bb32f5f0c9f5bdbb7b00959e8009de0230aedc200662701f05fc244c36f967ba
Status: Downloaded newer image for openapitools/openapi-generator-cli:v7.9.0
docker: Error response from daemon: create %cd%: "%cd%" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.

    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at Object.<anonymous> (/home/nitrosx/repos/scicat-frontend/scripts/generate-nestjs-sdk.js:17:26)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    at node:internal/main/run_main_module:28:49 {
  status: 125,
  signal: null,
  output: [
    null,
    '',
    "Unable to find image 'openapitools/openapi-generator-cli:v7.9.0' locally\n" +
      'v7.9.0: Pulling from openapitools/openapi-generator-cli\n' +
      '521f275cc58b: Pulling fs layer\n' +
      ...
      '1a31074fb300: Pull complete\n' +
      'Digest: sha256:bb32f5f0c9f5bdbb7b00959e8009de0230aedc200662701f05fc244c36f967ba\n' +
      'Status: Downloaded newer image for openapitools/openapi-generator-cli:v7.9.0\n' +
      'docker: Error response from daemon: create %cd%: "%cd%" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.\n' +
      "See 'docker run --help'.\n"
  ],
  pid: 30566,
  stdout: '',
  stderr: "Unable to find image 'openapitools/openapi-generator-cli:v7.9.0' locally\n" +
    'v7.9.0: Pulling from openapitools/openapi-generator-cli\n' +
    '521f275cc58b: Pulling fs layer\n' +
    ...
    '1a31074fb300: Pull complete\n' +
    'Digest: sha256:bb32f5f0c9f5bdbb7b00959e8009de0230aedc200662701f05fc244c36f967ba\n' +
    'Status: Downloaded newer image for openapitools/openapi-generator-cli:v7.9.0\n' +
    'docker: Error response from daemon: create %cd%: "%cd%" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.\n' +
    "See 'docker run --help'.\n"
}

Node.js v18.20.3

Steps to Reproduce
Cloned repo and pull new-sdk-release branch.
Run command npm run generate:sdk:local

The issue is that the docker command to generated the sdk is missing the following option --add-host host.docker.internal:host-gateway which is needed for linux environments:
The full command should be:
ker run --rm --add-host host.docker.internal:host-gateway -v "cd:/local" openapitools/openapi-generator-cli:v7.9.0 generate -i http://host.docker.internal:3000/explorer-json -g typescript-angular -o local/@scicatproject/scicat-sdk-ts --additional-properties=ngVersion=16.2.12,npmName=@scicatproject/scicat-sdk-ts,supportsES6=true,npmVersion=10.8.2,withInterfaces=true

I was finally able to generate the sdk locally with the following command:
docker run
  --rm
  --add-host host.docker.internal:host-gateway
  -v "./node_modules:/local"
  openapitools/openapi-generator-cli:v7.9.0
   generate
   -i http://host.docker.internal:3000/explorer-json
   -g typescript-angular
   -o local/@scicatproject/scicat-sdk-ts
   --additional-properties=ngVersion=16.2.12,npmName=@scicatproject/scicat-sdk-ts,supportsES6=true,npmVersion=10.8.2,withInterfaces=true

My dev environment is linux: ubuntu base linuxmint

@nitrosx thank you for your feedback. I saw your PR against the new-sdk-release. I will try it locally as well on my windows machine and if it works we can use your improved command for sdk generation.

Solved by PR #1644


Timeout problem

Recently (I suppose nearly 10days) I'm getting this timeout error:

File "/usr/lib/python2.7/telegram/telegramclient.py", line 44, in sendMsg
self.bot.sendMessage(self.id_chat, self.message_notification)
File "/usr/lib/python2.7/telegram/telepot/init.py", line 203, in sendMessage
timeout=self._http_timeout)
File "/usr/lib/python2.7/telegram/telepot/init.py", line 147, in _post
response = requests.post(url, **kwargs)
File "/usr/lib/python2.7/telegram/requests/api.py", line 107, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/lib/python2.7/telegram/requests/api.py", line 53, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/telegram/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/telegram/requests/sessions.py", line 578, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7telegram/requests/adapters.py", line 449, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.telegram.org', port=443): Read timed    out. (read timeout=30)
Exception in thread telegram (most likely raised during interpreter shutdown):
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
File "/usr/lib/python2.7/ciaotools.py", line 79, in run
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'ExitNow'

I've already updated the library (this morning), but the problem persists...
Thank you for every support you can give me
Regards
Danny

Can you post a simplified version of your code here?

I just call this sendMsg function (which calls telepot API), from another scritp:
import telepot

class TelegramClient():

def __init__(self, telegram_params):

        self.token = telegram_params["token"]
        self.id_chat = telegram_params["id_chat"]
        self.message_notification = telegram_params["message_notification"]

        self.bot = telepot.Bot(self.token)

def sendMsg(self):
        self.logger.debug("Invio Msg...")
        self.logger.debug(self.id_chat)
        self.logger.debug(self.message_notification)
        self.bot.sendMessage(self.id_chat, self.message_notification)

I modified your code, removed the logger, and added a few lines that takes info from command line and calls sendMsg():
import telepot

class TelegramClient():
    def __init__(self, telegram_params):
        self.token = telegram_params["token"]
        self.id_chat = telegram_params["id_chat"]
        self.message_notification = telegram_params["message_notification"]

        self.bot = telepot.Bot(self.token)

    def sendMsg(self):
        self.bot.sendMessage(self.id_chat, self.message_notification)

import sys
token, id_chat, msg = sys.argv[1:]  # take info from command line

c = TelegramClient(dict(token=token, id_chat=id_chat, message_notification=msg))
c.sendMsg()

And everything works fine.


fix #15 Upgrade to latest jqwik version

I missed that one and worked on an upgrade to 1.7.3 instead. Which one should we go for?


added shop title component

Created ShopHeader component & added to header component to display on every page. Added some basic styling.

good work!


Links to images in the README.md were broken

Links to images in the README.md were broken

This is fixed with: ddcb1e9e1da454eb1d6745d10331be41691fe0d7


Add DuckDuckGo's XMPP hidden service

Adding DuckDuckGo's XMPP hidden service server.
Provider: DuckDuckGo
Onion: wlcpmruglhxp6quz.onion
Source: https://twitter.com/runasand/status/636278183600484356

The key should be the domain (i.e. dukgo.com). But, apart from Runa's tweet, I can't find any confirmation of this onion address. It doesn't appear on the DuckDuckGo pages from what I can find.
People can obviously use it if they wish but I'm not sure that it should be substituted by default.

I see. I'll investigate further and resubmit if applicable.

Thanks.


go generator - interface omits attribute when value equals 0

As reported in vspk-go nuagenetworks/vspk-go#5, some models have an interface which contains an attribute of type int. Those attributes should not be omitted if empty (omitempty) as golang considers 0 an empty value.
I am working on a PR to fix this.

Great! Thanks @rvichery  :)

I forked monolithe to modify the golang generator. I am simply removing the omitempty for boolean and integer attributes. I am currently testing the generated sdk within the terraform provider and when it will stable enough, I will create a PR on monolithe project.


3399: SMS Credentials Settings Fix

Updates view with new 'Clear' checkboxes
Updates backbone view with logic for checkboxes
Fixes Setting model to incorporate logic

Great work! I fixed one minor bug. Other than that, looks great. Good solution. I will merge.


"Getting Started" on tachyons.io doesn't work

Heads up that the site's "getting started" section says to put use this stylesheet which doesn't work:
<link rel="stylesheet"<EMAIL_ADDRESS>

Maybe it's cache from npmcdn...
v4.0.0-beta.33 is working<EMAIL_ADDRESS>

Strange, just tried it again:

@davidguttman Yeah, v4.0.0-beta.34 is not working for me too, only v4.0.0-beta.33.

Ah, missed that. v4.0.0-beta.34 is what is on the site though:

@davidguttman Yep, 34 is the current version. :)
I guess the problem is some kind of cache from npmcdn.

Looks like the distribution assets weren't pushed to npmcdn for some reason. I've just bumped a new version which should now work, 4.0.0-beta.35. I will be updating the docs accordingly now. Let me know if this doesn't work for you, thanks for reporting!


Cannot create multiple Grafana in the same namespace.

I tried to create multiple Grafana CRs in the same namesapce.
However, the generated resource names are duplicated since they are hard-coded such as grafana-service or grafana-admin-credentials.
As a result of it, I failed to create multiple Grafana CR on the same namesapce.
I think we should support multiple Grafana in the same namespace.
If grafana-operator builds resource names as ${grafana-name}-${resource-name}, this issue would be solved.

Moreover, it seems that grafana-operator cannot detect Grafana CRs in namespaces except for grafana-operator's namespace. (ref)
As a result of them, grafana-operator can deploy single grafana CR only, is it true?

Facing issue cause of this, it would be nice if we can support a different namespace for grafana. Its alright(even preferred) to place data sources in same namespace as in grafana.

@dulltz @rverma-jm  There's some planned work involving the ability for Grafana's to be managed by operators from different namespaces coming up soon, Not sure of the timeframe though so I can't give a definite "When".

@HubertStefanski
Thank you for your reply.
By the way, where is the future development plan of grafana-operator being mainly discussed?
I would like to see it if possible.

@dulltz Most of this planning for now is done internally as part of the development process for the Integreatly-Operator, as needs arise for functionality we delegate to work on the grafana-operator, we are actively ensuring that we take in a few issues for the grafana-operator in each sprint to keep it moving forward.
As of now I'm not sure if there are any external documents/places where work is being planned, but perhaps this is something to consider? @pb82

@dulltz @HubertStefanski Yes, currently the development of this operator is mainly discussed via Github issues and in our internal chat rooms. We can consider creating a google group for it.

@HubertStefanski @pb82
Thank you for your responce. I got the workflow of Integreatly-Operator a little.

We can consider creating a google group for it.

I'm concerned that running a Google Group will be too costly for the core members.
If the core members are not troubled at the moment, I think the current GitHub Issue-based development is fine.

Any update on this?

@NissesSenap @dulltz We are working on publishing a roadmap, but it will still take some time. Multi namespace support is considered, but probably not one of the top priorities from our side (although we certainly will accept community pull requests for this).

I’d like to tackle this problem.
As for running multiple Grafana in the same namespace, I believe that this can be easily solved by not creating resources with fixed names and prefixing them with the .metadata.name of the Grafana resource.
e.g.:
  func GrafanaDeployment(cr *v1alpha1.Grafana, configHash, dsHash string) *v1.Deployment {
	  return &v1.Deployment{
		  ObjectMeta: v12.ObjectMeta{
-			  Name:      GrafanaDeploymentName,
+			  Name:      fmt.Sprintf("%s-%s", cr.Name, GrafanaDeploymentName),
			  Namespace: cr.Namespace,
		  },
		  Spec: getDeploymentSpec(cr, nil, configHash, "", dsHash),
	  }
  }

https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/model/grafanaDeployment.go#L561
However, there is a problem with the GrafanaDataSource resource.
The current logic looks like this (If I’m wrong, please comment):

Grafana datasource config file is located in a ConfigMap named grafana-datasources.
grafana-datasources ConfgMap is created by Grafana controller.

https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/model/grafanaDatasources.go#L10
https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/grafana/grafana_reconciler.go#L192-L195

In the reconciliation loop for GrafanaDataSource, refer to the ConfigMap with the fixed name grafana-datasources and write the Grafana datasource config file.

https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/common/dataSourcesState.go#L51-L69
https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/grafanadatasource/datasource_pipeline.go#L55-L61
https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/grafanadatasource/datasource_controller.go#L207-L208

If you prefix grafana-datasource ConfigMap with the name of Grafana object, you will not be able to find ConfigMap in the reconciliation loop of GrafanaDataSource with the logic as it is.
Also, the GrafanaDashboard and GrafanaDataSource resources share the state of the Grafana controller in the ControllerState struct.
This struct is currently designed to manage only one Grafana, so multiple Grafanas cannot be managed.

https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/common/controllerState.go#L7-L13
https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/grafanadashboard/dashboard_controller.go#L118
https://github.com/integr8ly/grafana-operator/blob/v3.9.0/pkg/controller/grafanadatasource/datasource_controller.go#L115

I think grafana-operator is currently used by many companies, so we have to be careful about breaking changes.

I consider this to be a difficult and complex issue.
I think the solution with minimal changes is that the ReconcileGrafanaDashboard and ReconcileGrafanaDataSource have multiple ControllerState. (Alternatively, you may want to stop keeping the state in a structure and use the API to get it every time. Can consider storing the information needed to construct the ControllerState structure in the Grafana Object status.)
And add a new field to the Grafana CRD.
  dashboardLabelSelectors:
    type: array
    items:
      type: object
      description: Label selector or match expressions
+ datasourceLabelSelectors:
+   type: array
+   items:
+     type: object
+     description: Label selector or match expressions

GrafanaDashboard and GrafanaDataSource controllers refer to the labelselector of the multiple Grafana objects they hold, determine the match, and execute the process. (This can be may inefficient)
Do you have any other good ideas for this?

We had a conversation in the Kubernetes Slack thread:
https://kubernetes.slack.com/archives/C019A1KTYKC/p1616416376015000

I have created a PoC for architectural changes in grafana-operator to solve this problem:
https://github.com/d-kuro/grafana-operator/pull/1

@d-kuro thanks a lot! We'd like to evaluate your PR as soon as we can. This seems to address both issues.

Resolved in #919


mark suggested lr

is it possible to mark a suggested lr, after doing learn.recorder.plot().
like an arrow pointing towards lr which has high probability to work well.

@vainaijr You can use learn.recorder.plot(suggestion=True) to get the recommended lr. Please check this link for more details: https://docs.fast.ai/callbacks.lr_finder.html#Suggested-LR
Also https://forums.fast.ai/ is a better place to ask such questions.


Overwrite existing tag if it exists

Addresses https://github.com/tvdias/github-tagger/issues/10

This PR seems to modify a ton of lines unrelated to its topic (mostly changing quote-styles, it looks like). I'm not the owner or a contributor to this repo, but maybe it'd be a more palatable PR if you trimmed it down to just one change.

good point @waisbrot ... I branched of releases/v0.0.2 instead of master because I couldn't get master working... so this PR includes linter changes from 4134272 and ed73505 which are on the releases/v0.0.2 branch but not master

Ugh, yeah. I just tried to make a PR for ignoring an existing tag and ran into the same problem. Github actions for JS seem like a bit of a mess (with the requirement to check in node_modules and then the commit-hook to compile TS makes the whole thing more confusing.


Chrome Extension: Check if mail was parsed before sending

Often I find myself forgetting to parse a message before sending it.
Can we catch the parsed status on sending in the Chrome extension, and if it detects that there is parsable markdown content, pop up a message that asks

Your message contains markdown but hasn't been parsed. Are you sure you want to send plain text?
[Parse and send], [Send as plain text], [Cancel]

I see that there is a similar question for Thunderbird.
https://github.com/adam-p/markdown-here/issues/382#issuecomment-252579995


Make default values for zone rasters as a value (e.g., -99) instead of NA

Zone parameters are created with "NA" as default for areas with no value (no defined zone). It might be better to make it a value (e.g., -99) to allow functionality in using zones as constrains or priority harvest areas (rasters with NA values will not work as a priority area).
Describe the solution you'd like
When creating a raster parameter, make it standard practice to define a value, e.g.,
ALTER TABLE pixels ADD COLUMN zone1 INTEGER DEFAULT -99
The idea needs some consideration of implications and some testing before making a switch.

closing for now ... we can revisit once more complicated zoning priorities are considered


Configurable bazel executable path in gazelle extension

Like bazel-diff, it'd be nice to be able to configure the path to bazel.
https://github.com/bazel-contrib/rules_jvm/blob/main/java/gazelle/private/bazel/bazel.go#L28

The gazelle plugin no longer shells out to bazel at all, as of https://github.com/bazel-contrib/rules_jvm/pull/69 :)


Path for iohook not found.

I try to install a clean electron app with node and print keyup event in console using iohook.
Expected Behavior
npm start works fine and every keyup prints event in console.
Current Behavior
Cannot find module 'C:\Users\Matheus Prado\projects\personal\electron-quick-start\node_modules\iohook\builds\electron-v89-win32-x64\build\Release\iohook.node'
Require stack:

C:\Users\Matheus Prado\projects\personal\electron-quick-start\node_modules\iohook\index.js
C:\Users\Matheus Prado\projects\personal\electron-quick-start\main.js
C:\Users\Matheus Prado\projects\personal\electron-quick-start\node_modules\electron\dist\resources\default_app.asar\main.js
at Module._resolveFilename (internal/modules/cjs/loader.js:887:15)
at Function.n._resolveFilename (electron/js2c/browser_init.js:257:1128)
at Module._load (internal/modules/cjs/loader.js:732:27)
at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
at Module.require (internal/modules/cjs/loader.js:959:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object. (C:\Users\Matheus Prado\projects\personal\electron-quick-start\node_modules\iohook\index.js:24:21)
at Module._compile (internal/modules/cjs/loader.js:1078:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1108:10)
at Module.load (internal/modules/cjs/loader.js:935:32)

Possible Solution
Improve the way the path is formed, or explain some things better. I tried changing the folder name and then the error changed, saying you had node_module V 89 and the plugin needed V 83 and I just didn't understand what that meant.
Steps to Reproduce (for bugs)
Install Node from: https://nodejs.org/download/release/v14.16.0/
Install electron with: npm i -D electron@latest
Install iohook with: npm install iohook --save
And put this code in main.js of minimal project of electron:
const ioHook = require('iohook');

ioHook.on("keyup", event => {
  console.log(event); // {keychar: 'f', keycode: 19, rawcode: 15, type: 'keup'}
});

ioHook.start();

Your Environment
Node.js 14.16.0
Electron: 13.2.2
SO: Windows Pro x64
ioHook: 0.9.3

Check the docs for supported targets, Electron 13 is not yet supported https://wilix-team.github.io/iohook/installation.html


[EasyCodingStandard] error stats for checkers

Log checkers that fails, show statistics of most often issues and those that are not used at all

Not a priority


Tasty Bytes Zero to Snowflake FY25 Updates (2nd)

Tasty Bytes Zero to Snowflake FY25 Updates (2nd)

Fixed the wrong .json file


:man_farmer: PeerTracker.PeerTrackerStale test flaky on MacOS + Citadel

Environment

OS Version: homebrew-amd64 buildfarm
Source, gz-gazebo3

Reference failures: https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/223/
https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/221/
https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/216/

Error Message
/Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/ign-gazebo/src/network/PeerTracker_TEST.cc:178
Expected equality of these values:
  1
  stalePeers
    Which is: 2
Stacktrace
/Users/jenkins/workspace/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/ign-gazebo/src/network/PeerTracker_TEST.cc:178
Expected equality of these values:
  1
  stalePeers
    Which is: 2

Description

Expected behavior: Test Passes
Actual behavior: Sometimes it fails on MacOS

Steps to reproduce

Run a buildfarm job on gz-gazebo + MacOS
Repeat 1 until the error shows up

Output
See: https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/223/testReport/junit/(root)/PeerTracker/PeerTrackerStale/

Duplicated from #760


Clean up anchors, make sure header doesn't cover things up

Anchors are currently covered up by the floating header when the page jumps to position.

Resolved by #631


Add simple chem benchmarks to lm-evaluation-harness

Add simple chem benchmarks to the lm-evaluation-harness submodule. The harness contains a guide for implementing new tasks

[ ] #196
[ ] #197

See main.py in the chem benchmarks repository for more information.

Could you provide further description?

Hi, @hypnopump yes I'll try to outline the task here.
We are using lm-evaluation-harness as a submodule for all of our evaluation. This contains a number of different tasks already and so far we have only used the built in ones. However, it does have a guide for how new tasks can be added and we would like to evaluate on extra tasks in future. In particular, Andrew recently created these two new tasks and it would be good if we could add them as options to the lm-eval-harness. I haven't looked at the code in detail but it has scripts for creating and evaluating on the two new tasks, so we want each of these to be added in line with the existing evaluation submodule framework. I also haven't added a new task myself but as far as I understand a custom task class will need to be created using a template so it can be accessed through the evaluate functions but the guide above is probably much more thorough. You would need to think about how the metrics would be calculated for this task (e.g. probably accuracy), if there are any train/test splits, how the requests will be constructed for querying the model etc. Happy to discuss with you further or look at this in more detail if you have any more questions!
In particular, this is a submodule so make sure you check out the guide for contributing to the submodules. 😊

awesome!

Since there are no PRs for these tasks already I am going to start working on adding them today because we need more tasks but let me know if you have already made progress on either of these :)

There are also some simple chemistry benchmarks in big-bench, e.g. https://github.com/google/BIG-bench/tree/main/bigbench/benchmark_tasks/periodic_elements

Thanks, that is really helpful 😊

We have 2 new tasks now made from the coconut smiles dataset:

IsSmile (multichoice)
CompleteSmile (free form text generation)


Provide tests for __name__ == "__main__" sections

It would be nice to provide tests for sections of code that rely on __name__ == "__main__". Currently, this is ignored by the tests and coverage, but it would be desirable to test this anyway. This should be possible using imp.load_source from the builtin module imp. Notable mention to other strategies from StackOverflow ( http://stackoverflow.com/questions/5850268/how-to-test-or-mock-if-name-main-contents ).

These sections have been eliminated from the modules. There are some stubs created in the bin directory that are not tested. However, such an involved solution is not required for them.
Simply running --help should be sufficient to make sure they exist and are running roughly correctly. As all of them call a main function that is heavily tested, there is nothing else that needs to be done. This is considered a different issue and has been placed here ( #245 ).


Update yarn.lock

result of run yarn

@Zwilla thanks a lot for your contributions, they are really appreciated! However, it's not a good git practice to do a PR per file changed, a PR should be atomic and cover the suggested change as a whole. Here, the change to the lockfile is not meaningful without the corresponding change to the package.json, merging one without merging another would put the repo in an inconsistent state, so both have to be the same PR actually, titled something like "Upgrade outdated dependencies", that PR should cover updates to the package.json, yarn.lock and include any code changes, required for the upgraded versions of libraries to work properly (i.e. changes to App.js). It would be greatly appreciated if you could refactor the suggested changes accordingly so we can review, test and merge the suggested improvement as a whole.

Sorry man no. Take a look here:
https://github.com/kvhnuke/etherwallet/graphs/contributorsd
Top 9 Zwilla and no incontinent 😂
merge or close

Sorry to hear that. Unfortunately we can't merge the change in its current shape. Then I'll close this one and few other PRs which are essentially the same suggested update, a part of which is this one (#7, #9 and #11). You're welcome to re-open a well-formatted PR for that later if you wish. Thank you again for your contributions.


Could you provide cupy windows package

Hi, I am a cupy (and chainer) user, and I want to install cupy on my windows machine. So could you provide a windows version of cupy 4.0.0 package on PyPI?
Besides, could it run on Numpy 1.14.2 or 1.14.3 since the latest version of numpy is <IP_ADDRESS>?
Thanks for your help!

Thanks, we're currently preparing a wheel for Windows.

We started to provide windows wheels in v5.0.0b1.


Fix dead path links

Came across few dead links (leading to File Not Found) while reading the erc20 docs, corrected them.

I guess the issues are on my side then, sorry for the waste of time. Have a nice evening.


feat(figma-utils): add CLI option selector

Description

add CLI option selector to change the selector using in the .css file
fix: remove selector for SCSS format because this made the variables unusable
use the html selector for our light and dark theme so the selector becomes html.light and html.dark

Checklist

[x] The added / edited code has been documented with JSDoc
[x] All changes are documented in the documentation app (folder apps/docs)
[x] If a new component is added, at least one Playwright screenshot test is added
[x] A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Description

add CLI option selector to change the selector using in the .css file
fix: remove selector for SCSS format because this made the variables unusable
use the html selector for our light and dark theme so the selector becomes html.light and html.dark

Checklist

[x]  The added / edited code has been documented with JSDoc
[x]  All changes are documented in the documentation app (folder apps/docs)
[x]  If a new component is added, at least one Playwright screenshot test is added
[x]  A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

suggestion:
..the selector **used** in the .css file


Regular Expression Injection

didn't notice these, but it happens when you do things like use regular expressions for search.

The most common input to achieve a ReDos is:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!


Devel

Significant changes:

Decrease excessive use of templates.
Introduce an IoPin type that abstracts the platform-specific PrimitiveIoPin and handles inversions, etc. This also makes it possible to compile any machine with make MACHINE=... MACHINE_CLASS=generic to run a machine on any platform (uses dummy hardware I/O operations).
Rearrange files. src/drivers -> src/iodrivers and anything in that folder that doesn't derive from IODriver or isn't IO-related was moved to more appropriate folders (drivers/*coordmap.h -> motion/*coordmap.h).
Add a Servo class (experimental).
Machine::getIoDrivers() no longer has to return the A4988 stepper drivers - these are now managed by the CoordMap.
Introduce auto-generated documentation using cldoc. Docs can be viewed online here (still very much a work-in-progress).
Introduce automatic unit-testing using the CATCH framework.
Integrate with Travis CI to auto-compile docs and run tests after each push.
Implement additional M-codes (M111, M115, M117, M119 (partial), M280, M999).
Officially support clang compiler.

Lower-level Internal Changes:

Removed Event class altogether and just use OutputEvents.
Remove AxisHomeSteppers - replace with CoordMap::executeHomeRoutine() function.
CoordMaps now have the ability to inject their own IoDrivers into the tuple returns from the Machine by implementing the getDependentIoDrivers() function.
Replace many std::array<float, 4> and std::array<float, 3> with explicit Vector objects & make use of their mathematical operations in motion planning.

Etc:

Remove machines/rpi/kosselpi.h; implement machines/rpi/kosselrampsfd.h, which interfaces a raspberry pi to a ramps-fd board using only jumpers.
Replaced rcthermistor.h with a better implementation for ramps-fd (supports auto-calibration of the pin's threshold voltage).
Replace machines/generic/example.h with an actual usable machine: machines/generic/cartesian.h.

Pulling this before it gets too massive - build passes all tests; movement, fan control and hotend control all work fine on an actual kosselrampsfd machine. I assume that extrusion works, but I haven't been able to tune my PID loop enough to actually do a test print.


Add handling for superseded_by inconsistencies

This handles the edge case where the superseded_by is set in the json file but not in the meta csv.
@zerebubuth: could you review please?

:+1: looks good to me.


Add discovered clients functional tests

Q
A

Bug fix?
no

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
partially #109

Documentation
n/a

License
MIT

This just add functional tests on discovered clients as I will refactor this to use xml configuration instead of PHP in HttplugExtension. This will help me to not break discovered clients!

Thanks for the review!


Request: adjust font/line size

It'd be great to be able to make the font a little smaller so that more can fit on the line. It would also be great to be able to make the letters a little closer together for old writers.
Thanks so much for this!

Hi, thanks for the note. I forgot this little tool existed since my kids are older now. Let me see what I can do about it.

Hi, please take a look again. http://www.julienvanier.com/handwriting-sheet/ should now properly print 6 lines of smaller text in portrait orientation when using Chrome. Looks like there was a change in the browser sometime in the last 6 years that made it always think it was printing in landscape mode which meant it printed only 3 lines.


Create a Menu for Advanced Chip Functionality

Request Requirements
Request
Create a menu component that's similar to the dropdown. Ideally in the future dropdown component will be replaced with this more advanced component. It's a container that opens on click event below the clicked component.
Design
Figma
Updates required
This workflow will allow us to insert other components/objects into a menu that is activated by a chip.
In order to complete this component we need to make a few changes to existing components:
Chips

Add option to customize border radius

example: Need to be able to do 8px border radius for design

Update clear button styling to match new design

Split button separating clear action from chip label
End result looks like one chip but has two buttons (each hover state shows independently)

Label button opens menu/etc
Clear button clears selection

Menu

Toggle element ID property is required
Add option for menu to stay open after selecting from list

Add a control: disable-close-onselect. By default it should be false
Default this option to current behavior (closes when selecting)
Update data filter as selections are made

Each selection will reload the data set but the menu should stay open

Menu can be closed by clicking outside of menu (elsewhere on screen)
* Menu should also close when the parent component is clicked again
Allow other components to be added inside menu container

All form control options are valid for v1

Add parent styles to remove rounded corners on components when inserted into menu list within dropdown

List item (0 border radius)
Others TBD

Menu height should be:

Maximum of 70vh or 400px
Minimum of 40vh or 200px

Menu width should be”

Minimum of 160px
Maximum of 300px

Later Updates:

after this work is completed we will iterrate on this component to add a header/footer with actions for clear/close/etc
Not required for v1 right now

Design from Teja:
https://www.figma.com/proto/ygURNTfPtwqsdu4NsqoQQT/O%26PS-%26-Modus--patterns?page-id=810%3A22834&node-id=2682-648&node-type=section&viewport=377%2C499%2C0.43&t=Tvc7QAI0rT5hzgm0-1&scaling=min-zoom&content-scaling=fixed

Mitch to provide a Figma example.

@mitch-trimble Of the components listed which ones should have overwritten styles, including rounded corners (ie. list)

Should we break this issue up based on what control we are supporting?

We will create a separate issue to tackle the formatting fix of the menu to remove the rounded corners. It's a story we can complete prior to building out the feature.


Glob does not catch files in the sub-directory (CWL 1.0)

prepare_intervals.zip
25 BED files are created in Intervals subdirectory.
Glob: Intervals/*.bed does not catch them.
Another inconsistency, if the Glob is changed to:
*.bed
it does catch them.

The matching in CWLGlobServiceImpl is currently only done with the filename, not the whole path. This should probably be changed.


Update on #SNMP

With .NET Core 2.0 tooling, now #SNMP starts to offer official .NET Standard support in its 10.0 release (10.0.0 stable, and 10.0.1 currently in beta 1).
https://twitter.com/lextm/status/902726277622312960

Can you give a sample code for reading ARP table from switch    i tried with OID  <IP_ADDRESS>.<IP_ADDRESS>. but the data field is encoded in different character..


(📚) docs for PLW1641 known problems doesn't make sense

# Known problems
Does not check for `__hash__` implementations in superclasses.

__hash__ defined in a superclass doesn't affect the semantics:
class A:
    def __hash__(self):
        return 1

class B:
   def __eq__(self, other):
       return False
B.__hash__ # None

The rule is

Checks for classes that implement eq but not hash.

So.. if you have this:
class A:
    def __hash__(self):
        return 1

class B(A):
   def __eq__(self, other):
       return False

B implements hash via A but is not detected by Ruff.
What doesn't make sense about this?

What doesn't make sense about this?

as in my OP:
print(B.__hash__) # None

A class that overrides eq() and does not define hash() will have its hash() implicitly set to None.

source: https://docs.python.org/3/reference/datamodel.html#object.hash

Wow, so it's just when __eq__ is defined?

@KotlinIsland sorry your OP doesn't have inheritance
Interesting find though!


Webpack2 angular2 esri

arcgis-js-api usage with webpack2-angular2. arcgis-js-api was
configured with webpack1. this example shows how you can use
arcgis-js-api with webpack2. Please refer to readme for the steps used
to migrate from webpack1 to webpack2.

@hassanqaiser
This is great. I pulled and ran your code. It seems to work for the most part, though the map was not taking up the full height of the page and I would see this HMR error when ever I made a change to the source files:

However I can see that you're brining in most, if not all of the Angular Class repo, and as excited as I am to get webpack2, HMR, and all the other goodies (like karma unit tests) that are part of that repo into this one, I'm not sure that it's a good idea for me to merge all of that. As far as tooling is concerned, the purpose of this repo is to demonstrate just the configuration needed to get the ArcGIS API for JavaScript running in an Angular2 app. I don't want to confuse people by introducing all the other sophisticated tooling that is is part of that repo.
That said, I think it would be very valuable to have an example of the ArcGIS API for JavaScript working with the Angular Class starter. What I propose is that you just make a new repository called "webpack2-angular2-esri" or "angular2-webpack-esri-starter", or whatever you like and copy the contents of your webpack2-angular2-esri branch into that repository. Once you do that, I can create a link from the README of this repository to that one for anyone that wants to start with all the tooling included in the Angular Class starter.
I'd also likely open an issue here to upgrade to webpack2 w/o all the other configuration settings included in that repo.
What do you think?

@tomwayson thats good idea. I will create new repo and will send you the link shortly... thanks

@tomwayson  please find the link with new repository.
https://github.com/hassanqaiser/angular2_webpack2_esri
Thanks,

@hassanqaiser
Great! I've closed out #27 by linking to your repo and have added a link to the README
Thanks again for sharing this.


Testing with go 1.16 with unexpected call

What version of Go are you using (go version)?

$ go version 1.16.2

Does this issue reproduce with the latest release?
yeah, testing is better in 1.14
What operating system and processor architecture are you using (go env)?
go env
$ go env

set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\binst\AppData\Local\go-build
set GOENV=C:\Users\binst\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\binst\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\binst\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.16.2
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Users\binst\Desktop\store-api\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\binst\AppData\Local\Temp\go-build1283002382=/tmp/go-build -gno-record-gcc-switches

What did you do?

What did you expect to see?
test_result.txt
What did you see instead?

I have not looked at the code in question.  The error you report says that the test code got an "invalid memory address or nil pointer dereference" at c:/Users/binst/Desktop/store-api/api/models/product_test.go:15.  Are you sure that your code is not trying to dereference a nil pointer?


Deployment && Updating services at Service Farm

I'm developing message-based backend - multiple worker instances runs onto multiple servers, takes tasks from message queue (RabbitMQ), execute them and send results back to service bus.
I'm planning to implement workers as windows services but I have a real problem - how to easy deploy\upgrade them on multiple servers at data-center...
Is it possible to implement some kind of auto-update feature to Topshelf?

Yeah, look at using Octopus or Puppet or something to deploy your service upgrades. Doing something specifically inside Topshelf is out of scope, since most operations teams have standard ways they deploy code to servers and this would just create another one.


Fix 3rd party dependency

PING!

Hello there, this PR is also interesting for me mainly for the same reasons:

go<EMAIL_ADDRESS>bzr branch --use-existing-dir https://launchpad.net/~niemeyer/gocheck/trunk . in /Users/travis/gopath/pkg/mod/cache/vcs/f46ce2ae80d31f9b0a29099baa203e3b6d269dace4e5357a2cf74bd109e13339: exec: "bzr": executable file not found in $PATH

Actually tent doesn't exist anymore it seems: https://tent.io/

this should be fixed by https://github.com/digitalocean/godo/pull/223

or just running GO111MODULE=on go get github.com/digitalocean/godo solved it for me :D

Yep, fixed by
https://github.com/digitalocean/godo/commit/0168bd6520364c819c8462137e72412a1ff2b447


Feature/new partner logo

This PR adds UNEP Collaboration Centre partner logo to footer and partner page
PIVOTAL | BASECAMP
FOOTER:

ABOUT/CW PARTNERS:

I think we can but only on partners page. This logo is very long and the height is short, so it's hard to scale it on footer where we don't have free space

Yeah, that makes sense. Let's make it a little wider on the About page if possible. And keep it smaller on the footer as it doesn't fit as you said.

@simaob fixed :man_factory_worker:


Splash Screen on startup

StarlingBootstrap should be able to display a splash screen until Starling is initialized and the application is created. Maybe with a minimum time.
Random notes and ideas:

iOS can use Default PNG files, but not Android.
All platforms can display the application icon over a flat color.
Might use starling.utils.ScaleMode values.

Here's how Flex does it:
Adobe Flex 4.6: Define a mobile application and a splash screen

What I like about Flex mobile SplashScreen is the "zoom" mode. That allows to use a single .png file that will look good enough in most screens and aspect ratios.
If you need help with this feature I can do some testing to see how different scale modes look.

Hi Josh,
did you make any progress on the splash screen implementation?
thanks,

@quick6black No, I haven't done any work on this one yet.

this would be awesome :+1:

I extended the StarlingBootstrap so that I could have my own splashscreen (bitmap) created without any flickering after the default iOS splash image. I also considered the "zoom" to put the image on the correct place. Since I passed through here when I was looking for a solution, maybe this can help someone else out there: :)

package utils
{
	import flash.display.Bitmap;

	import feathers.core.StarlingBootstrap;

	public class Bootstrap extends feathers.core.StarlingBootstrap
	{
		private var _info:Object;

		public function Bootstrap()
		{

			var bmp:Bitmap = BmpSplash(); //Any embedded Bitmap here
			bmp.smoothing = true;

			if( bmp.width > bmp.height )
			{
				bmp.height = stage.fullScreenHeight;
				bmp.scaleX = bmp.scaleY;
			}
			else
			{
				bmp.width = stage.fullScreenWidth;
				bmp.scaleY = bmp.scaleX;
			}

			bmp.x = (stage.fullScreenWidth - bmp.width) / 2;
			bmp.y = (stage.fullScreenHeight - bmp.height) / 2;

			Globals.splashImage = bmp;
			stage.addChild( bmp );

			super();
		}

		override public function info():Object
		{
			if (!_info)
			{
				_info = {
					rootClassName: "MyApp",
					themeClassName: "themes.MyTheme"
				};
			}

			return _info;
		}

	}
}

I'm saving a reference to the Bitmap on a Global static variable (ugly, I know) so I can fade it out and then dispose it when I'm done loading and preparing everything.
The main reason for me is the flicker time between the iOS splash goes away and the context3d is created.

Wish you all the best!

Ok, it only worked on debug and "Fast" mode. When publishing on iOS with "Standard" mode the app crashes.
Josh, could you help me solving this, please? What am I missing to extend the StarlingBootstrap?
Help, pls?

I don't see anything wrong with your code. It's probably a bug in the iOS packaging. Sometimes when it optimizes more, these issues pop up, and you can tweak your code a bit to compensate.
The first thing I would try is moving your code in the constructor after the super() call. I could see that potentially being the place where the packaging has an issue.
Next, I would try temporarily remove the code in the constructor to see if your custom bootstrap works simply with your info() override.
Then, I'd try removing only some parts of the constructor code.
Basically, you're trying to narrow down exactly what is causing the crash. Once it stops crashing, you can add smaller parts back in until it crashes again. That'll help you figure out exactly which line it is, and you can try tweaking things to work around the issue.

@joshtynjala, Thanks very very much for the answer...it lead me to a good path and I found the problem. Accessing the static variable from the Globals class where I was storing my splash was causing the crash. Wasn't immediate, though....but after loading the theme the app crashed...
So, for everyone who needs this...I've stored the reference on the bootstrap class itself and all worked...no flickering anymore and my client is happy now:
package utils
{
	import flash.display.Bitmap;

	import feathers.core.StarlingBootstrap;

	public class Bootstrap extends feathers.core.StarlingBootstrap
	{
		private var _info:Object;

		[Embed(source="img_splashScreen.png")]
		public var BmpSplash:Class;

		public static var splashScreen:Bitmap;

		public function Bootstrap()
		{

			super();

			var bmp:Bitmap = new BmpSplash();
			bmp.smoothing = true;

			if( bmp.width > bmp.height )
			{
				bmp.height = stage.fullScreenHeight;
				bmp.scaleX = bmp.scaleY;
			}
			else
			{
				bmp.width = stage.fullScreenWidth;
				bmp.scaleY = bmp.scaleX;
			}

			bmp.x = (stage.fullScreenWidth - bmp.width) / 2;
			bmp.y = (stage.fullScreenHeight - bmp.height) / 2;

			Bootstrap.splashScreen = bmp;
			stage.addChild( bmp );

		}

		override public function info():Object
		{
			if (!_info)
			{
				_info = {
					rootClassName: "MyClass",
					themeClassName: "themes.MyTheme"
				};
			}

			return _info;
		}

	}
}

Enjoy it! :)
(And thanks again, Josh, for the awesome platform!)


AB#5018

Proposed changes

Related issues

Checklist

[x] I consider the submitted work as finished
[x] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Tested with the local build, @DallasP9124 @r-joyce please review and merge.


Refactoring of files and folder structure in src

Purpose
Refactoring the src folder. Closes #1663.
Review checklist
I have:

[x] followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
[x] followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
[x] followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
[x] checked that this PR does not duplicate an open PR.

In the Content, I have included

[x] relevant unit tests, and integration tests,

[x] appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[ ] I have read and checked the items on the review checklist.

bors try

bors try

bors r+

bors r+


Flake8 rule 'W291' reported an invalid point

Flake8 reported an invalid point for the rule W291, with the messge trailing whitespace.

Debug information:
Atom version: 1.23.1
Flake8 version: 3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 2.7.12 on Windows

Duplicate of #466


feat(tag): added the example with editing and removing tags

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[x] Documentation content changes

What is the current behavior?
Closes #614
What is the new behavior?
Added new example to show how to organize removable tags.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

the only thing I don't like :)

@vakhramoff please add a display: flex container for tags so empty tags line up (see screenshot above) and let's show notification always, not just when tags are gone.


allow pressing back button to close the modal on Android

Feature needed indeed !
Thanks @hlynn93, going to merge it 👍

Great! Maybe by default, the prop should be true but it's up to you. 👍


Use a development branch for API breaking changes towards v0.8.0 and beyond

Is your feature request related to a problem? Please describe.
In discussing the next release in #955  two difficulties have arisen:

An uncertainty in how to describe releases via semantic versioning (bugfix release E.g. 0.7.3 vs minor release E.g. v0.8.0).
Releasing incremental, API breaking changes along with bugfixes/enhancements.

Describe the solution you'd like
Utilize a development branch to centralize API breaking changes towards the goals of the v1.0.0.
Bugfixes and enhancements would still be merged straight into master as they currently are. Such changes are more straightforward and could be released to PyPI faster without concern of self-afflicted API changes and could enable a more bug-free and feature-filled PyPI version available for the masses.
Describe alternatives you've considered
Mark API breaking PRs as v0.8.0 and wait to merge them until they're all ready.
This would not allow the community a chance to tryout these changes ahead of time and would be difficult for developers to ensure API consistency.
Additional context
It looks like this was used in the past #178. Was there a reason for moving away from this workflow?

If we have to have multiple branches then I'd rather keep master on the bleeding edge and create bug fix branches for the older release series. But I think when looked at from that point of view it's clear that we don't have the person-power or development speed to make multiple branches worthwhile.
I think the major impediment is our own lack of will to push API changes faster.

This would not allow the community a chance to tryout these changes ahead of time and would be difficult for developers to ensure API consistency.

The community can more easily try out changes by simply using the master version on github. This is common practice for CI configurations for libraries with more infrastructure (e.g. pandas tests against numpy master).

I think the major impediment is our own lack of will to push API changes faster.

We certainly do have the "Will" to push API changes! :)

If we have to have multiple branches then I'd rather keep master on the bleeding edge and create bug fix branches for the older release series. But I think when looked at from that point of view it's clear that we don't have the person-power or development speed to make multiple branches worthwhile.

What I'm suggesting would simply make the development branch a single feature branch that could be managed by the team we have available.

I think the major impediment is our own lack of will to push API changes faster.

I agree with you and don't see a way to getting it done faster which is why I'm suggesting this path.

The community can more easily try out changes by simply using the master version on github. This is common practice for CI configurations for libraries with more infrastructure (e.g. pandas tests against numpy master).

From what I've witnessed, the current mode of operation is to push partial API improvements toward v0.8.0 within bugfix releases and decide that the API has changed enough to warrant a change to a minor release. That causes bugfixes and enhancements to take a long time to get to PyPI because there's fear that if we release API breaking changes every month then we'll lose users. By tucking them away and releasing them when they're finished in their entirety we could reasonably release bugfix releases monthly (v0.7.x) and minor releases with API improvements quarterly or even semi-annually (v0.x.0). This way we know what to release when and the community knows when significant changes have happened that they need to look out for. I otherwise have a hard time figuring it all out.
Maybe I'm making it too hard? 🤷♂

IMO a dev branch is not necessary. We have not reached v1.0 so breaking changes should be expected. Anyone who doesn't want to deal with breaking changes is free to use an older version. If they want new features they can manage the upgrades.
We already help users with deprecation cycles. We can help them more with better documentation and migration guides.
IMHO breaking changes only becomes an issue after v1.0, when we may choose to support multiple release branches such as a long term support (LTS) release to which we backport new features without making API changes. But I think that's a bridge we can cross when we get there.
My feelings on this are not set in stone, I could convinced otherwise, but I think those who would bare the greatest burden should have the most say. Will & Cliff
If our goal is to grow user base, there may be other concerns to users higher priority than breaking API changes. If it were up to me, I would invest in better engagement. Surveys, user group meeting, discourse or other modern forum, etc. I'm not convinced that a dev branch will deliver the expected impact for what it would cost in effort.

I'd like to first clarify that the intention for using a development branch is to manage API breaking changes together as a group of merged PRs not to move all development to this branch. It would be more correct to call it a feature branch. Such a branch would be named to indicate its purpose and be temporary. It's main purpose would be to group API breaking changes and contain them through a "third-digit" bug release(s) toward a "second-digit" minor release. My apologies for being less than clear.
Last Friday in a phone conversation between @cwhanse, @wholmgren and I, we discussed possible scenarios for this method. There we decided that we would push toward v0.8.0 now without such a branch but potentially implement one for future API changes if we decide it's useful and worth the effort which will be determined at a later date.
That resolves my reason for raising this issue and so I'll close this issue out. If there's further discussion I'll be happy to reopen.
Thanks to all for their insight!


2.x Deprecate non-namespaced functions in Twig

Ticket: https://github.com/timber/timber/issues/1580#issuecomment-360980331
Issue
In Twig, the following functions still exist: TimberPost, TimberImage, TimberTerm, TimberUser. For PHP, we replaced all those instances of non-namespaced functions. To make it more consistent, let’s deprecate these in Twig as well. The shorter versions that work perfectly fine (even without Timber\ as a prefix) already exist: Post, Image, Term, User. We can leave them as they are.
Solution

Deprecated TimberPost, TimberImage, TimberTerm, TimberUser in Twig. They don’t return anything.
Updated tests.
Updated guides where some of these function names were still used.

Testing
Yes.

Awesome, feels like a relief to have those gone


Terminate update when there is no asset

Current behavior: it's trying to update the tool despite an error. See: https://github.com/projectdiscovery/utils/blob/main/update/update.go#L75

Noticed because of this https://github.com/projectdiscovery/cdncheck/issues/103.

Closing this, as it's already terminating. Fixed in https://github.com/projectdiscovery/pdtm/pull/157.


CI: Use bitsandbytes<0.44.0 for llama2 example test

Describe your changes
Latest version of bnb has changes with zip(..., strict=True) which is not compatible with python <3.10. We need to eventually move to python 3.10+ since 3.8 is old but it needs bigger changes to the ci infrastructure https://github.com/microsoft/Olive/pull/1369.
Use a lower version in the test for now to unblock the CI.
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Lint and apply fixes to your code by running lintrunner -a
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
[ ] Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

closing in favor of https://github.com/microsoft/Olive/pull/1370


Removing a cookie or getting a key that does not exist creates a cookie

Hi
I found that when getting a cookie that does not exist , a cookie is created with a string value "undefined" .
I attempted to remove it,but found out that a removed cookie is set to "undefined" also instead of being removed.
I'm using Angular Final with version 1.2.4 of your tool

I will investigate this issue asap and release a new version with the fix. Thanks for letting me know.

I could not reproduce the issue with Chrome or Firefox.


CF Pages failing to build.

Describe the bug
Upon building using CF pages the following error is displayed and the build fails.
Error: "/opt/buildhome/repo/themes/blowfish/i18n/zh-TW.yaml:1:1": failed to load translations: unable to parse translation #0 because invalid plural category part_of_series
To Reproduce
Steps to reproduce the behavior:

Create page on CF-Pages
Link repo
Atempt to build

Expected behavior
The build to succeed.
Desktop (please complete the following information):

OS: MacOS
Browser Firefox
Version 109.0

Hugo & Blowfish versions

Hugo 0.54.0
Blowfish v2.26.0

Additional context
The entire log from CF is as follows:
14:43:29.498 | Submodule 'themes/blowfish' (https://github.com/nunocoracao/blowfish.git) registered for path 'themes/blowfish'
-- | --
14:43:29.499 | Cloning into '/opt/buildhome/clone/themes/blowfish'...
14:43:29.499 | Submodule path 'themes/blowfish': checked out '17557c7d731c3f07fb8cf72ebfc11c0cf21faa9a'
14:43:29.499 |
14:43:29.570 | Success: Finished cloning repository files
14:43:30.263 | Installing dependencies
14:43:30.276 | Python version set to 2.7
14:43:34.347 | v12.18.0 is already installed.
14:43:35.636 | Now using node v12.18.0 (npm v6.14.4)
14:43:35.890 | Started restoring cached build plugins
14:43:35.918 | Finished restoring cached build plugins
14:43:36.490 | Attempting ruby version 2.7.1, read from environment
14:43:40.391 | Using ruby version 2.7.1
14:43:40.767 | Using PHP version 5.6
14:43:40.974 | 5.2 is already installed.
14:43:41.002 | Using Swift version 5.2
14:43:41.003 | Installing Hugo 0.54.0
14:43:41.842 | Hugo Static Site Generator v0.54.0-B1A82C61A/extended linux/amd64 BuildDate: 2019-02-01T10:04:38Z
14:43:41.875 | Started restoring cached go cache
14:43:41.902 | Finished restoring cached go cache
14:43:42.098 | go version go1.14.4 linux/amd64
14:43:42.117 | go version go1.14.4 linux/amd64
14:43:42.122 | Installing missing commands
14:43:42.122 | Verify run directory
14:43:42.122 | Executing user command: hugo -b $CF_PAGES_URL
14:43:42.161 | Error: "/opt/buildhome/repo/themes/blowfish/i18n/zh-TW.yaml:1:1": failed to load translations: unable to parse translation #0 because invalid plural category part_of_series
14:43:42.162 | map[id:article translation:map[date:{{ .Date }} draft:草稿 edit_title:編輯內容 reading_time:map[other:{{ .Count }} 分鐘] part:Part this_article:This Article anchor_label:定位點 date_updated:上次編輯: {{ .Date }} reading_time_title:預計閱讀時間 table_of_contents:目錄 word_count:map[one:{{ .Count }} 字 other:{{ .Count }} 字] part_of_series:This article is part of a series.]]
14:43:42.169 | Failed: build command exited with code: 255
14:43:42.971 | Failed: an internal error occurred

Okay, I didn't notice CF was trying to build a prehistoric version of Hugo for some reason.
After manually specifying the latest version I'm getting this now:
`
17:56:11.717 |
-- | --
17:56:26.808 | Submodule 'themes/blowfish' (https://github.com/nunocoracao/blowfish.git) registered for path 'themes/blowfish'
17:56:26.809 | Cloning into '/opt/buildhome/clone/themes/blowfish'...
17:56:26.809 | Submodule path 'themes/blowfish': checked out '17557c7d731c3f07fb8cf72ebfc11c0cf21faa9a'
17:56:26.809 |
17:56:26.857 | Success: Finished cloning repository files
17:56:27.679 | Installing dependencies
17:56:27.693 | Python version set to 2.7
17:56:31.345 | v12.18.0 is already installed.
17:56:32.594 | Now using node v12.18.0 (npm v6.14.4)
17:56:32.856 | Started restoring cached build plugins
17:56:32.876 | Finished restoring cached build plugins
17:56:33.471 | Attempting ruby version 2.7.1, read from environment
17:56:37.504 | Using ruby version 2.7.1
17:56:37.941 | Using PHP version 5.6
17:56:38.378 | 5.2 is already installed.
17:56:38.409 | Using Swift version 5.2
17:56:38.409 | Installing Hugo 0.110.0
17:56:40.689 | hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended linux/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
17:56:40.693 | Started restoring cached go cache
17:56:40.715 | Finished restoring cached go cache
17:56:40.878 | go version go1.14.4 linux/amd64
17:56:40.896 | go version go1.14.4 linux/amd64
17:56:40.900 | Installing missing commands
17:56:40.900 | Verify run directory
17:56:40.901 | Executing user command: hugo -b $CF_PAGES_URL
17:56:41.025 | Start building sites …
17:56:41.026 | hugo v0.110.0-e32a493b7826d02763c3b79623952e625402b168+extended linux/amd64 BuildDate=2023-01-17T12:16:09Z VendorInfo=gohugoio
17:56:42.318 | WARN 2023/01/30 17:56:42 .File.Path on zero object. Wrap it in if or with: {{ with .File }}{{ .Path }}{{ end }}
17:56:42.978 | Error: Error building site: failed to render pages: render of "home" failed: "/opt/buildhome/repo/themes/blowfish/layouts/index.html:4:7": execute of template failed: template: index.html:4:7: executing "main" at <partial $partial .>: error calling partial: "/opt/buildhome/repo/themes/blowfish/layouts/partials/home/background.html:11:97": execute of template failed: template: partials/home/background.html:11:97: executing "partials/home/background.html" at <$homepageImage.RelPermalink>: nil pointer evaluating resource.Resource.RelPermalink
17:56:42.979 | Total in 2027 ms
17:56:42.989 | Failed: build command exited with code: 255
17:56:43.841 | Failed: an internal error occurred
`

I am sorry @MonsterMuffin this is not a bug on Blowfish. I am converting this into a discussion.


MountVolume.Setup failed for volume "prosody-plugins-volume" : configmap "jitsi-meet-prosody-plugins" not found

Affected versions

1.0.1 is affected
0.2.0 is not affected
Versions in between have not been tested

Issue description
Unfortunately, the latest changes have broken the helm chart for me. We're deploying on AKS.
The release is stuck trying to launch the prosody pod.
k get pods
NAME                                       READY   STATUS              RESTARTS   AGE
jitsi1-jitsi-meet-jicofo-b559d5b56-z6hjd   1/1     Running             0          76s
jitsi1-jitsi-meet-jvb-5cccdfbdc5-7hcgj     1/1     Running             0          76s
jitsi1-jitsi-meet-web-758b7fb5cd-mwvq4     1/1     Running             0          76s
jitsi1-prosody-0                           0/1     ContainerCreating   0          76s

$ k describe pods jitsi1-prosody-0
[ omitted ]
Events:
  Type     Reason                  Age                 From                     Message
  ----     ------                  ----                ----                     -------
  Normal   Scheduled               103s                default-scheduler        Successfully assigned jitsi/jitsi1-prosody-0 to aks-agentpool-31866087-vmss000000
  Normal   SuccessfulAttachVolume  93s                 attachdetach-controller  AttachVolume.Attach succeeded for volume "pvc-90042a02-f25e-4fb4-b901-36ab54811d7e"
  Warning  FailedMount             38s (x8 over 102s)  kubelet                  MountVolume.SetUp failed for volume "prosody-plugins-volume" : configmap "jitsi-meet-prosody-plugins" not found

I can't find any reference in the code to the prosody-plugins-volume or a jitsi-meet-prosody-plugins ConfigMap (only the jitsi-common one). Maybe this mount is unintended or the Configmap is missing?
Workaround
We've downgraded to version 0.2.0 of the chart and everything works well again. (helm install --version 0.2.0 [...])

I'm sorry. I fixed version 1.1.0 now.


Minor adjustments for devsetup tripleo multinode

Use the original ansible to_bool() filter (py3) in jinja2_render.
Simplify a condition for a supported cells number.
Copy nova_noceph.yaml from the local t-h-t files instead of heredocs.
Hide RH_REGISTRY_ credentials, when dumping the containers conf file.
Fix a typo in the supported cells number message.

ok but please lets sanity check the multinodes as usual

https://review.rdoproject.org/r/c/testproject/+/54199

/approve

LGTM


Add tooltip to error logs link

Description
Fixes https://github.com/dotnet/aspire/issues/6512
After:

Checklist

Is this feature complete?

[x] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[x] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Is this introducing a breaking change?

[ ] Yes

Link to aspire-docs issue (please use this breaking-change template):

[ ] No

Link to aspire-docs issue (please use this doc-idea template):

[x] No

Microsoft Reviewers: Open in CodeFlow

Tried this in a codespace and I see this:

Fixed. There was an existing issue with displaying text when there was one error.


find a word which has the highest number of repeated letters.

Write a program to find a word in a given string which has the highest number of repeated letters.
EXAMPLE -:
INPUT-she sold her olive shirt to mr federer.
OUTPUT-federer.

This issue labeled 'Easy' is only for FYs.

I would like to work on this issue
FY comp
Rishita Chourey

Hi there I would like to work on this issue.
Isha Baviskar FY Comp


LCP user passphrase is not stored persistently? (only for current app session)

When the app is closed + re-opened, the passphrase is asked again.
Tested with npm run start.

Also tested with npm run start:dev


IAM: Open Policy Agent integration

Resolve https://github.com/openvinotoolkit/cvat/issues/3950
Resolve https://github.com/openvinotoolkit/cvat/issues/2093
Resolve https://github.com/openvinotoolkit/cvat/issues/2708
Resolve https://github.com/openvinotoolkit/cvat/issues/2937
Resolve https://github.com/openvinotoolkit/cvat/issues/3482
Resolve https://github.com/openvinotoolkit/cvat/issues/3318
Resolve https://github.com/openvinotoolkit/cvat/issues/3247
Resolve https://github.com/openvinotoolkit/cvat/issues/3245
Resolve https://github.com/openvinotoolkit/cvat/issues/3151
Resolve https://github.com/openvinotoolkit/cvat/issues/2681
Resolve https://github.com/openvinotoolkit/cvat/issues/1578
Resolve https://github.com/openvinotoolkit/cvat/issues/1030
Resolve https://github.com/openvinotoolkit/cvat/issues/317
Resolve https://github.com/openvinotoolkit/cvat/issues/1835
Resolve https://github.com/openvinotoolkit/cvat/issues/3969

Motivation and context

Integrated Open Policy Agent to manage permissions. OPA is run as a separate micro service and handle input requests. Basically it responds with Allow/Deny.
Added Organization, Membership, Invitation concepts to manage permissions for different objects (e.g. tasks, jobs, projects, etc).
Removed auth application together with rule-based permissions
Added cvat.apps.iam application which have the logic to work with OPA
Migrated on the next version of Django and Rest framework

How has this been tested?

Added tests for policies and adjust REST API tests
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[x] I have added tests to cover my changes
[x] I have linked related issues (read github docs)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin , if I update the description, the PR checks are restarted. I don't think we need to do that without new commits. Could you please check?

@dvkruchinin , if I update the description, the PR checks are restarted. I don't think we need to do that without new commits. Could you please check?

@nmanovic
This is normal behavior. Because workflow main states
pull_request:
    types: [edited, ready_for_review, opened, synchronize, reopened]

This allows to run container builds and tests after changing the PR. This also applies to the name change.
Otherwise, after changing the name, it will be necessary to add/update the commit.
For example, after removing [WIP] from the name, it will be more convenient if workflow starts to see the result. These changes were made for this purpose.

any update?

any update?

Could you please test the current PR and comment?

How to filter jobs based on job_assignee_id , So that the logged-in User can see only the jobs, assigned to him?

@bsekachev,
Enhancements:

Add user sorting by role (in the organization page)
Maybe for the page with organization, make 2 tabs: people and settings (with information about the organization)
The open button is not entirely intuitive for the user, it may be better to add the settings icon next to the organization (in the dropdown) instead of the open button
Phone number field like this:

There is a long-distance to manifest button

Need to stretch the selector

@nmanovic,

It's impossible to import tasks to another organization

There is an exception when I try to invite the user to the organization If some users have the same email:

Could not invite this member<EMAIL_ADDRESS>to the organization
Open the Browser Console to get details

Maybe need to add user-friendly message.

Details
```
ERROR - 2021-12-09 08:55:56,849 - log - Internal Server Error: /api/v1/invitations
Traceback (most recent call last):
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/mixins.py", line 19, in create
    self.perform_create(serializer)
  File "/home/maya/Documents/cvat/cvat/apps/organizations/views.py", line 89, in perform_create
    serializer.save(**extra_kwargs)
  File "/home/maya/Documents/cvat/cvat/apps/organizations/serializers.py", line 101, in save
    invitation = super().save(**kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/rest_framework/serializers.py", line 205, in save
    self.instance = self.create(validated_data)
  File "/home/maya/Documents/cvat/cvat/apps/organizations/serializers.py", line 80, in create
    user = get_user_model().objects.get(**membership_data['user'])
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/django/db/models/manager.py", line 85, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/cacheops/query.py", line 352, in get
    return qs._no_monkey.get(qs, *args, **kwargs)
  File "/home/maya/Documents/cvat/.env/lib/python3.8/site-packages/django/db/models/query.py", line 439, in get
    raise self.model.MultipleObjectsReturned(
django.contrib.auth.models.User.MultipleObjectsReturned: get() returned more than one User -- it returned 2!
```

I'm fine with general functionality, but I would like to suggest some improvements:

As i can see short name of organization can't contain spaces/dashes/underscores maybe its good thing to have something so we can have some separated words

Here we have organization description. But I think font is too small. If we dont want to make this section too large maybe its better to move it to separate tab

When we want to edit organization email/location/phone, we can cancel editing by clicking outside of input, but when we do the same thing with description we cant cancel it. Maybe its good to add here cancel button or implement the same behavior.

Also I think its good to have placeholders in email/location etc.

Maybe its good to have search for users by name/username/role

@Marishka17 , I have fixed the problem with import of tasks. Thanks! Also it is very interesting finding with email addresses. It looks like we need to use usernames instead of email addresses because emails can be absent and non-unique.

One more issue:
Create org with any name, remove organization and try to create new org with the same name
Traceback (most recent call last):
   File "/opt/venv/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
     response = get_response(request)
   File "/opt/venv/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
     response = wrapped_callback(request, *callback_args, **callback_kwargs)
   File "/opt/venv/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
     return view_func(*args, **kwargs)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
     return self.dispatch(request, *args, **kwargs)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
     response = self.handle_exception(exc)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
     self.raise_uncaught_exception(exc)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
     raise exc
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 497, in dispatch
     self.initial(request, *args, **kwargs)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 415, in initial
     self.check_permissions(request)
   File "/opt/venv/lib/python3.8/site-packages/rest_framework/views.py", line 332, in check_permissions
     if not permission.has_permission(request, self):
   File "/home/django/cvat/apps/iam/permissions.py", line 966, in has_permission
     organization = request.iam_context['organization']
   File "/opt/venv/lib/python3.8/site-packages/django/utils/functional.py", line 246, in inner
     self._setup()
   File "/opt/venv/lib/python3.8/site-packages/django/utils/functional.py", line 382, in _setup
     self._wrapped = self._setupfunc()
   File "/home/django/cvat/apps/iam/views.py", line 64, in <lambda>
     request.iam_context = SimpleLazyObject(lambda: get_context(request))
   File "/home/django/cvat/apps/iam/views.py", line 45, in get_context
     raise BadRequest(f'{org_slug or org_id} organization does not exist.')
 django.core.exceptions.BadRequest: myorg organization does not exist.

@azhavoro
Client issue. Fixed.

Tried to deploy this branch on top of the latest develop:
...
  File "/opt/venv/lib/python3.8/site-packages/cacheops/transaction.py", line 93, in execute
    result = self._no_monkey.execute(self, sql, params)
  File "/opt/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/opt/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/opt/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/opt/venv/lib/python3.8/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/opt/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: column "sorting_method" of relation "engine_data" already exists

@Marishka17

The open button is not entirely intuitive for the user, it may be better to add the settings icon next to the organization (in the dropdown) instead of the open button

Fixed, this way:

There is a long-distance to manifest button

Fixed.

Need to stretch the selector

Fixed.
@klakhov

When we want to edit organization email/location/phone, we can cancel editing by clicking outside of input, but when we do the same thing with description we cant cancel it. Maybe its good to add here cancel button or implement the same behavior.

Fixed.

Merged develop. One problem appeared:
Cannot import a dataset: exception in serializer.

Traceback (most recent call last):
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/worker.py", line 936, in perform_job
    rv = job.perform()
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/job.py", line 684, in perform
    self._result = self._execute()
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/job.py", line 690, in _execute
    return self.func(*self.args, **self.kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 164, in import_dataset_as_project
    project.import_dataset(f, importer)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 144, in import_dataset
    importer(dataset_file, project_data, self.load_dataset_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/formats/registry.py", line 37, in __call__
    f_or_cls(*args, **kwargs)
  File "/home/user/cvat/cvat/apps/dataset_manager/formats/cvat.py", line 1051, in _import
    load_data_callback(dataset, instance_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 133, in load_dataset_data
    load_dataset_data(self, *args, **kwargs)
  File "/home/user/cvat/cvat/apps/dataset_manager/bindings.py", line 1564, in load_dataset_data
    project_annotation.add_task(task_fields, dataset_files, project_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 83, in add_task
    db_task = TaskSerializer.create(None, {
  File "/home/user/cvat/cvat/apps/engine/serializers.py", line 434, in create
    if project.organization != validated_data['organization']:
KeyError: 'organization'

@nmanovic One more question:
In my case it's possible to upload annotation from the Task view, but impossible from Job view for own or assigned tasks and non-admin users.

@bsekachev , I merged the develop branch today morning. I didn't want to commit till resolve all issues with tests. I will take care about all problems. If I need any help with UI, I will ask explicitly.

Merged develop. One problem appeared:
Cannot import a dataset: exception in serializer.
Traceback (most recent call last):
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/worker.py", line 936, in perform_job
    rv = job.perform()
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/job.py", line 684, in perform
    self._result = self._execute()
  File "/home/user/cvat/.env/lib/python3.8/site-packages/rq/job.py", line 690, in _execute
    return self.func(*self.args, **self.kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 164, in import_dataset_as_project
    project.import_dataset(f, importer)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 144, in import_dataset
    importer(dataset_file, project_data, self.load_dataset_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/formats/registry.py", line 37, in __call__
    f_or_cls(*args, **kwargs)
  File "/home/user/cvat/cvat/apps/dataset_manager/formats/cvat.py", line 1051, in _import
    load_data_callback(dataset, instance_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 133, in load_dataset_data
    load_dataset_data(self, *args, **kwargs)
  File "/home/user/cvat/cvat/apps/dataset_manager/bindings.py", line 1564, in load_dataset_data
    project_annotation.add_task(task_fields, dataset_files, project_data)
  File "/home/user/cvat/cvat/apps/dataset_manager/project.py", line 83, in add_task
    db_task = TaskSerializer.create(None, {
  File "/home/user/cvat/cvat/apps/engine/serializers.py", line 434, in create
    if project.organization != validated_data['organization']:
KeyError: 'organization'

It should be fixed now.

@nmanovic One more question: In my case it's possible to upload annotation from the Task view, but impossible from Job view for own or assigned tasks and non-admin users.

Just forgot to add 'import:annotations' scope into jobs.rego. Now it should work. Please don't forget after each update of rego rules to restart cvat_opa.

Hi @nmanovic,
Found a problem when running a test for Email verification system.
Could not fetch organizations list
Error: Request failed with status code 401. {"detail":"Authentication credentials were not provided."}.
e @ cvat-app.tsx:284

It is reproduced when building a CVAT with support for this system. How it's done in nightly.
How to reproduce:

Build CVAT with support Email verification system.
Try to register an user.

Hi @nmanovic, Found a problem when running a test for Email verification system.
Could not fetch organizations list
Error: Request failed with status code 401. {"detail":"Authentication credentials were not provided."}.
e @ cvat-app.tsx:284

It is reproduced when building a CVAT with support for this system. How it's done in nightly.
How to reproduce:

Build CVAT with support Email verification system.
Try to register an user.

I'll take a look into the issue, thanks

@dvkruchinin
Should be fixed now

Should be fixed now

@bsekachev
Yes, now it`s working. But need to fix the appropriate test. I did it in PR #4065

@dvkruchinin , could you please look https://github.com/openvinotoolkit/cvat/runs/4611278644?check_suite_focus=true?

@dvkruchinin , another test was failed https://github.com/openvinotoolkit/cvat/runs/4611629268?check_suite_focus=true. Is it a problem with tests itself or a bug? Could you please investigate?

Hi, how do we migrate to the version of CVAT that makes use of this IAM?

I have made an alpha release with IAM: https://github.com/openvinotoolkit/cvat/releases/tag/v2.0.0-alpha. Basically a new version of CVAT with the feature will be released in Q1'22. You can try it right now. Just download the develop branch and run usual steps to build and deploy CVAT. I will not recommend to run the version in production for now. My team will test the patch on an internal server this year, on cvat.org next year, implement more tests to cover the new functionality at the beginning of next year.


No way to set withCredentials when loading resources

I am loading a few resources which will look different depending on which user requests the resources. The users are identified via a cookie which is set for the active domain. In order for the browser to append cookies, withCredentials must be set to true on the XMLHttpRequest.
I don't see any way to set this through the Loader. Did I miss something, or is this something we can include?

Wouldn't it be easier to append some URL params to the request? Like site.com/yourResources?user=data_from_cookie ?

There are multiple reasons why I wouldn't want to do that:

The cookie (which is the credentials to my site) will be a GET parameter. Risky when using copy&paste. Also likely to end up in serverside logs (e.g. apache logs)
I would have to manually append this, rather than having the browser do it for me automatically.
I would need separate parsing of the authentication on the backend side depending on which Loader I'm using (Phaser, or another resource fetcher/setter in my application).

Yeah, but cookies are in no eay safer against a hacker.Also, using CORS with credentials is not enabled by default on Safari on iOS so the users would have to manually enable that. (Settings > Safari > Accept Cookies and set 'Always')
On Tue, Sep 13, 2016 at 19:33, Alexander<EMAIL_ADDRESS>wrote:
There are multiple reasons why I wouldn't want to do that:

The cookie (which is the credentials to my site) will be a GET parameter. Risky when using copy&paste. Also likely to end up in serverside logs (e.g. apache logs)
I would have to manually append this, rather than having the browser do it for me automatically.
I would need separate parsing of the authentication on the backend side depending on which Loader I'm using (Phaser, or another resource fetcher/setter in my application).

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Not very hard to implement to the loader.
Do we want to add this? Should it be for the whole loader or specific file? If for file then we need to make a check for withCredentials property on the file object. If for whole loader we probably should add property withCredentials.
https://github.com/photonstorm/phaser/blob/master/src/loader/Loader.js#L2336
There is the xhrLoad function which should be edited to check those things.

@stoneman1 I'm not super familiar with the Phaser codebase yet so I haven't attempted to make the changes but here are my thoughts about its design:
Optimally, it should be possible to set on a per-resource basis. I think most resource should have it set to false (the default value). Since it's credentials I think a defensive strategy is most sound. Only on occasion should it be set to true.
This means that an argument needs to be added for all different loading methods (json, spritesheet, image, etc.). Preferably an options object which may be extended in the future if more similar needs arise.
If that is too much work, I'm content with a simpler solution where withCredentials can be set globally on the loader object. Not as flexible, but get the job done. One apparent drawback is that it may be very common to keep assets (images etc) on a CDN, where you would most likely not want to send credentials.

So every load function needs a new parameter. Lets say that you want to load a image then you would use load.image(key, url, overwrite, {withCredentials: true}) and then you just check that property from the file in the xhrLoad function. Not too much of work really. Just waiting for other people to comment if this is something we want and how we want to do it :)

SGTM 👍

Before we discuss how this can be done (I can think of a few ways), sprite sheets and all images in Phaser are loaded via Image tags, not XHR, so withCredentials will make no difference to them at all. It'll only impact the resource files (json/xml), which are loaded via xhr.
@noseglid does that matter for your use-case? If not, then I've a way to implement this without needing new arguments for all methods. If it doesn't work for tag loaders (Image, Audio) then I'm not sure it's worth adding?

I only need it when loading stuff via XHR. It is probably a good thing it
can't be done for images etc. as they are likely to be on a CDN and one
should definitely not send credentials there.
For my specific use-case it is only the loadJSON method which matter
On Mon, 26 Sep 2016 at 22:40, Richard Davey<EMAIL_ADDRESS>wrote:

Before we discuss how this can be done (I can think of a few ways), sprite
sheets and all images in Phaser are loaded via Image tags, not XHR, so
withCredentials will make no difference to them at all. It'll only impact
the resource files (json/xml), which are loaded via xhr.
@noseglid https://github.com/noseglid does that matter for your
use-case? If not, then I've a way to implement this without needing new
arguments for all methods. If it doesn't work for tag loaders (Image,
Audio) then I'm not sure it's worth adding?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/photonstorm/phaser/issues/2753#issuecomment-249690621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4_-D7vcp5W9ad2vkImb0UJVy5yhU2Oks5quC2igaJpZM4J60--
.

Thank you for taking the time to open this issue. However, official support for Phaser 2 has now ended as we focus on preparing Phaser 3 for beta release. In a bid to keep the project tidy, and avoid confusion, we are closing all v2 related issues.
This does not mean your issue won't be looked-at. In November 2016 the Phaser CE (Community Edition) project began. The aim of Phaser CE was to allow the community to continue v2 development. Since then it has gained significant traction, with many updates and releases.
If you are still interested in having your issue investigated we strongly recommend testing the latest Phaser CE release. And only if the problem persists, opening an issue on the Phaser CE repo.


Multipart delivery (#7)

Created delivery method with locals.

Please fix the spec, get the build green :) https://travis-ci.org/lotus/mailer/jobs/77319916

@joneslee85 I think it's ok now, could you check please? :)


Correcting weekly time estimates with holidays

This will be corrected with reference to the UK bank holidays manually.


no tests.py file

The output of the github action running pytest returns 0 tests for your unit test because you guys have not added tests.py file. Hope you guys are working on your unit test file.

Yeah! you are right @s4il3sh you need to add a .py file the directory where your workflow is created to execute the github action.

sad


Integrate with Travis

As soon as we have tests (issue #34) we want to integrate with Travis https://travis-ci.org/
Honza

https://github.com/firebug/pixel-perfect/commit/f803658c440af15f9a544c9901dde39967f435c9
https://github.com/firebug/pixel-perfect/commit/44981564803a015fbb8c87abff340d816f420437
Honza

Travis builds are available:
https://travis-ci.org/firebug/pixel-perfect
Honza


Define code standards

Code style and structure should be well-defined and consistent.
The goal is to have no ambiguity as to how new code should be added and to have existing code be as readable as possible.
This includes "metacode" (link scripts and makefiles).  Scripts for code review and autodocs are left out of this ticket since they're a bit more out-of-band with respect to the build process.
Assembly

[x] Plan
[x] Implement
[x] Verify
[x] Document

Link script

[ ] Plan
[ ] Implement
[ ] Verify
[ ] Document

Makefile

[ ] Plan
[ ] Implement
[ ] Verify
[ ] Document

Leaving out linkscript and makefile code standards for now, they aren't that important.  Will need to revisit later when polishing the documentation.


Adds some additional setup for Xdebug

@cmmarslender @tlovett1
As per our meeting yesterday, here is the setup that I have used to get Xdebug working on a mac. I have added an entry for Windows but that is a guess and needs to be tested and we should get an equivalent for Linux as well

As per slack, I've reverted the path change and am using host.docker.internal to be compatible with Windows and OSX. Linux is still pending.

In the past I had a php image I used across windows and linux machines that had issues figuring out the host to use. In the end I used remote_connect_back=1 to allow me to use the same image on both without rebuilding images or updating configs between machines.
This would need adapted but if anyone is interested here is the RUN command from the dockerfile where I used this in the past. NOTE: connect_back is only for local (or networks not exposed to the world).
RUN yes | pecl install xdebug && \
    echo "zend_extension=$(find /usr/local/lib/php/extensions/ -name xdebug.so)" > /usr/local/etc/php/conf.d/xdebug.ini && \
	echo "xdebug.remote_enable=1" >> /usr/local/etc/php/conf.d/xdebug.ini && \
	echo "xdebug.remote_connect_back=1" >> /usr/local/etc/php/conf.d/xdebug.ini && \
	echo "xdebug.remote_handler=dbgp" >> /usr/local/etc/php/conf.d/xdebug.ini && \
	echo "xdebug.remote_mode=req" >> /usr/local/etc/php/conf.d/xdebug.ini && \
	echo "xdebug.remote_autostart=false" >> /usr/local/etc/php/conf.d/xdebug.ini

Thanks @ryanwelcher! I updated our php images to make your configuration work with linux as well. New images for php are building on dockerhub now.


try show error

>>> import pathlib
>>> xy = pathlib.Path('.')
>>> import click
>>> _green = lambda t: click.style(t, fg="green")
>>> print(_green(xy))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 1, in <lambda>
  File "/usr/lib/python3/dist-packages/click/termui.py", line 449, in style
    return ''.join(bits)
TypeError: sequence item 1: expected str instance, PosixPath found

it's click 7 https://github.com/alingse/git-ssh-key/issues/7