Update to support Rhel7 hosts alongside Centos7 hosts

This PR takes steps toward making Piecewise deployable to RHEL hosts directly rather than manually as was the case in Seattle.

Adds Ansible conditionals to detect RedHat hosts as well as  CentOS
Moves extraction of Maxmind CSV into OS specific playbooks, since Debian requires the -j flag but CentOS/RHEL do not
Begins to add requested changes from Seattle to the Rhel7 nginx conf file (See item 3 in #125)

This change is

Hi Chris. I've added a few comments.

Reviewed 2 of 8 files at r1.
Review status: 2 of 8 files reviewed at latest revision, 5 unresolved discussions.

ansible/deploy-piecewise.retry, line 0 at r1 (raw file):
You might like to add something like *.retry to the the .gitignore file to avoid this ever happening again.

ansible/files/rhel7/etc/nginx/nginx.conf, line 20 at r1 (raw file):

    log_format  syslog_ng  '$remote_addr $server_name $remote_user "$http_user_agent" $time_local "$request"  $status $body_bytes_sent';

    syslog_ng_log /var/log/nginx/nginx_socket syslog_ng;

Just reiterating here what we chatted about this morning: I think it would be better to keep a standard/stock nginx config to the extent possible, and let Seattle make these changes to their own deployment.

ansible/inventory/debian8-hosts, line 1 at r1 (raw file):

<IP_ADDRESS> ansible_ssh_user=critzo

Is your text editor (or git config) stripping the newlines from the end of files?

ansible/playbooks/all_hosts_tasks.yml, line 46 at r1 (raw file):

name: Get the latest MaxMind CSV
get_url:
url: http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNum2.zip

ansible/playbooks/all_hosts_tasks.yml, line 55 at r1 (raw file):

    creates: /tmp/GeoIPASNum2.csv
    remote_src: yes

Something seems strange to me here. I'm not sure why this would need the -j option. I just downloaded the MaxMind database specified in the URL above, and its contents are a single file (GeoIPASNum2.csv). I can only imagine that there is something not quite right about the way the unarchive module is being invoked here.
How about something like the following, which also obviates the need for the Get the latest MaxMind CSV task? I just tried it to a Debian host (EB) and it worked as expected:
  - name: Unzip MaxMind CSV
    unarchive:
      remote_src: yes
      src: http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNum2.zip
      dest: /tmp/
      creates: /tmp/GeoIPASNum2.csv

Comments from Reviewable

ansible/files/rhel7/etc/nginx/nginx.conf, line 20 at r1 (raw file):
Previously, nkinkade wrote…
Just reiterating here what we chatted about this morning: I think it would be better to keep a standard/stock nginx config to the extent possible, and let Seattle make these changes to their own deployment.

Acknowledged. I'll remove this in a commit before moving on.

Comments from Reviewable

ansible/inventory/debian8-hosts, line 1 at r1 (raw file):
Previously, nkinkade wrote…
Is your text editor (or git config) stripping the newlines from the end of files?

I think this is me just being pedantic. I just deleted the final blank line in this case, which has the added effect of stripping the newline char.

Comments from Reviewable

ansible/playbooks/all_hosts_tasks.yml, line 55 at r1 (raw file):
Previously, nkinkade wrote…
Something seems strange to me here. I'm not sure why this would need the -j option. I just downloaded the MaxMind database specified in the URL above, and its contents are a single file (GeoIPASNum2.csv). I can only imagine that there is something not quite right about the way the unarchive module is being invoked here.
How about something like the following, which also obviates the need for the Get the latest MaxMind CSV task? I just tried it to a Debian host (EB) and it worked as expected:
  - name: Unzip MaxMind CSV
    unarchive:
      remote_src: yes
      src: http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNum2.zip
      dest: /tmp/
      creates: /tmp/GeoIPASNum2.csv

I'll test that on a Debian and RHEL7 host to confirm.

Comments from Reviewable

Review status: 2 of 8 files reviewed at latest revision, 5 unresolved discussions.

ansible/inventory/debian8-hosts, line 1 at r1 (raw file):
Previously, critzo wrote…
I think this is me just being pedantic. I just deleted the final blank line in this case, which has the added effect of stripping the newline char.

I think the final blank line is not the issue, but the missing NL character at the end of the existing line. My understanding is that it is a POSIX compliance requires a NL character at the end of every line, including the last one.  And apparently C (and maybe others) require this:
http://stackoverflow.com/questions/5813311/no-newline-at-end-of-file

Comments from Reviewable

Reviewed 1 of 8 files at r1, 5 of 7 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


 There were some security fixes:
https://go.dev/doc/devel/release#go1.22.0

Sorry team, I thought this was good to go, but evidently not

@samjewell you probably need to bump the go version that is on the container that runs the build job here

@samjewell probably need to bump the go version for the ci build process

Ok @scottlepp - this looks better now - could you take a look please? Thanks!


Miro board setup for text review

[x] updated screenshots in folder
[x] Miro setup/permissions

Notes from the Slide version of the text review have been moved to the Miro board:


LogGroup SubscriptionFilter has a different resource name every deployment causing cloudformation failures

I am attempting to integrate datadog cdk construct v2 into my project like so:
if (props.datadog) {
      // For documentation: https://github.com/DataDog/datadog-cdk-constructs
      // NodeLayerVersion is gotten from: https://github.com/DataDog/datadog-lambda-js/releases
      const datadog = new Datadog(this, 'Datadog', {
        env: props.stackEnvironment,
        service: 'REDACTED',
        version: props.codeVersion,
        forwarderArn: Fn.importValue(props.datadog.forwarder!),
        nodeLayerVersion: props.datadog.nodeLayerVersion
      });

      datadog.addLambdaFunctions([...]);
    }

It appears that the SubscriptionFilters are being created with unique resource names every time. This causes cloudformation to try and add additional subscription to the log groups.  It fails because there is a limit on subscriptions. This limit is set to 2 and cannot change according to AWS docs.  https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/cloudwatch_limits_cwl.html
This resource id should not change from deploy to deploy. The offending code:
https://github.com/DataDog/datadog-cdk-constructs/blob/05098425d8201b19eae574bebaedb8fe1cc61b16/v2/src/forwarder.ts#L30
As long as the construct is scoped correctly, CDK will take care of the rest with the resource name.
How to reproduce?

Have datadog construct in the stack
Leverage forwarderArn
Attach to lambdas
Deploy 2-3 times (depends if other filters exists)
Observe error

12:06:30 PM | CREATE_FAILED        | AWS::Logs::SubscriptionFilter            | REDACTED...er348769153C2BF03B
Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: 85c404c8-84e0-4c7a-a379-17e3cb512271; Proxy: null)

12:06:30 PM | CREATE_FAILED        | AWS::Logs::SubscriptionFilter            | REDACTED...er3f6649f5015872C4
Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: f02d0345-31eb-4108-96e6-ed610f5eb326; Proxy: null)

12:06:31 PM | CREATE_FAILED        | AWS::Logs::SubscriptionFilter            | REDACTED...er09c33c10EA3CA0A6
Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: 35d42acb-8785-4aad-ad4a-def5b25c15b5; Proxy: null)

The stack named xxxx-sandbox-bri failed to deploy: UPDATE_ROLLBACK_COMPLETE: Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: 85c404c8-84e0-4c7a-a379-17e3cb512271; Proxy: null), Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: f02d0345-31eb-4108-96e6-ed610f5eb326; Proxy: null), Resource limit exceeded. (Service: AWSLogs; Status Code: 400; Error Code: LimitExceededException; Request ID: 35d42acb-8785-4aad-ad4a-def5b25c15b5; Proxy: null)

I'd suggest checking for other resources doing the same thing.

My workaround below.
I will also note that the same thing will happen if you also have Datadog AWS Integration installed at the account level and have CloudWatch checked off under the log configurations.  This causes subscription filters to be automatically applied to any new log groups. Be careful! :) In my case, this was also happening, so I simply removed adding the filter, but if you don't have that enabled you should be ok to keep it in.
import { Construct } from 'constructs';
import { LambdaDestination } from 'aws-cdk-lib/aws-logs-destinations';
import { Datadog, DatadogProps } from 'datadog-cdk-constructs-v2';
import { Function } from 'aws-cdk-lib/aws-lambda';
import { FilterPattern } from 'aws-cdk-lib/aws-logs';
import { FooLambda } from './foo-lambda';

export interface FooDatadogProps extends DatadogProps {
    readonly fooLambdas: FooLambda[];
}

/**
 * Intended to workaround: https://github.com/DataDog/datadog-cdk-constructs/issues/108
 */
export class FooDatadog extends Construct {

    readonly _datadog: Datadog;

    constructor(scope: Construct, id: string, props: FooDatadogProps) {
        super(scope, id);
        this._datadog = new Datadog(this, 'Datadog', props);
        this._datadog.addLambdaFunctions(props.fooLambdas.map(idexxLambda => fooLambda.function));

        // Fix for https://github.com/DataDog/datadog-cdk-constructs/issues/108
        if(props.forwarderArn) {

            const forwarderLambda = Function.fromFunctionArn(this, 'ForwarderLambda', props.forwarderArn!);
            const forwarderDestination = new LambdaDestination(forwarderLambda);

            props.idexxLambdas.forEach((lambda) => {
                const badFilterName = lambda.function.logGroup.node.findAll()[1].node.id;
                lambda.function.logGroup.node.tryRemoveChild(badFilterName);

                // remove this if you have datadog collecting ALL cloudwatch logs
                lambda.function.logGroup.addSubscriptionFilter('DatadogSubscription', {
                    destination: forwarderDestination,
                    filterPattern: FilterPattern.allEvents()
                });
            });
        }
    }

    get datadog() {
        return this._datadog;
    }

}

Hi @zomgbre I'm having some issues reproducing this. We're using the unique ID from the lambda function name, along with the Forwarder ARN, and combine it with our own constant prefix. I'm pretty new to this repository, but my experiments have made me believe that the resource name is deterministic, as the SubscriptionFilterName from cdk synth is consistent over multiple runs, and indeed multiple deploys of a demo project show that the filter name renames the same over multiple deploys:

Could you run cdk synth a few times and share the output? I'm trying to identify which part of the name generation would be non-deterministic.
Thanks!

Hi @zomgbre - I'm wondering if you've had a chance to try the debugging steps I outlined above? I'd like to identify what specifically keeps changing about the subscription name, which is causing this issue for you.
Thanks!

In the meantime, in addition to the workaround you've provided, I'd suggest exploring the Datadog Extension, which obviates the need for the Datadog Forwarder.
@astuyve , what's the recommended way to take advantage of addForwarderToNonLambdaLogGroups if on migrates to the extension? Instantiate datadog twice in the cdk code? one with and one without a forwarder arn specified?

This library wasn't intended to be instantiated twice, and I'm not sure what the impact of that would be.
If there are non lambda log groups, I'd recommend creating new stack specifically for subscribing non lambda log groups to Datadog, then using the addForwarderToNonLambdaLogGroups method to subscribe the forwarder to those groups.


feat: sb docs overview "Autocomplete.ts & FromControl.ts-create MuiAutocomp…

…lete override"

IconButton and LoadingButton missing description and override

IconButton and LoadingButton missing description and override

IconButton description: https://mui.com/material-ui/react-button/#icon-button
LoadingButton description: https://mui.com/material-ui/react-button/#loading-button
To override use Button.ts


How can i get a result without named variable

Hi, i'm trying to get a serialized result to ommit the name or variable on result.
How can i get the same result like using the $this->set('_serialize', 'varname'); in this plugin?
i want to get a result like this
{ "status": "OK", "result": { "falanu": [ "dhikanu", "tamburo" ] } }
instead of:
{ "status":"OK","result": { "bar": { "falanu": [ "dhikanu", "tamburo" ] } } }
without putting the name variable what i'm using in the response
thank you

Good question!
As of now, there is no automated solution for this. But you can do that by adding an extra key to your response array. See following example,
public function bar()
{
    $bar = [
        'bar' => [
            'falanu' => [
                'dhikanu',
                'tamburo'
            ]
        ]
    ];

    $this->set(compact('bar'));
 }


Updated dfVFS to version 20211224

Codecov Report

Merging #11 (729410b) into main (90a2d61) will decrease coverage by 1.63%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   78.68%   77.04%   -1.64%
==========================================
  Files           2        2
  Lines         122      122
==========================================
- Hits           96       94       -2
- Misses         26       28       +2

Impacted Files
Coverage Δ

imagetools/file_entry_lister.py
89.79% <71.42%> (-2.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a2d61...729410b. Read the comment docs.


Corrections in the MEB and BBM routines

During the preparation of the results for the modelling paper, several small issues with the MEB and BBM implementations appeared. We will merge these changes into the develop.

Solved in PR #318


Missing install instructions

how to install with meteor ?

Create a folder named packages in the root of your meteor app.
inside the packages folder, do a  it clone https://github.com/LumaPictures/meteor-jquery-select2.git
within the newly created meteor-jquery-select2 folder, you will find a packages.js file.
4.edit the file and add this line into the packages.description object.
name: "reactive:select"

Basically, it should look like this:
Package.describe({
  name: "reactive:select",
  summary: "A Blaze UI select2 component that supports reactive search."
});

go back to meteor root dir, then --> meteor add reactive:select2

Done.

Is there no way to do this with Meteor's recommended installation for npm packages? Something like
meteor npm install --save meteor-jquery-select2


Thank you for your contribution!


gui: "Text Search" does not show any window

In master, whenever any APK is opened in GUI, I can't open the "Text Search", there is a logged error, but I am not sure if it is related.
Is it only me? Since it wasn't there few days back
ERROR - Failed to parse '.arsc' file
jadx.core.utils.exceptions.JadxException: Error decode: resources.arsc
	at jadx.api.ResourcesLoader.decodeStream(ResourcesLoader.java:76)
	at jadx.core.dex.nodes.RootNode.loadResources(RootNode.java:84)
	at jadx.api.JadxDecompiler.load(JadxDecompiler.java:91)
	at jadx.gui.JadxWrapper.openFile(JadxWrapper.java:39)
	at jadx.gui.ui.MainWindow.openFile(MainWindow.java:203)
	at jadx.gui.ui.MainWindow.openFile(MainWindow.java:196)
	at jadx.gui.ui.MainWindow.open(MainWindow.java:158)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
Caused by: java.io.IOException: Expected entry start, expected offset: 0x717b0, actual: 0x717af
	at jadx.core.xmlgen.ParserStream.checkPos(ParserStream.java:123)
	at jadx.core.xmlgen.ResTableParser.parseTypeChunk(ResTableParser.java:210)
	at jadx.core.xmlgen.ResTableParser.parsePackage(ResTableParser.java:167)
	at jadx.core.xmlgen.ResTableParser.decodeTableChunk(ResTableParser.java:114)
	at jadx.core.xmlgen.ResTableParser.decode(ResTableParser.java:62)
	at jadx.core.dex.nodes.RootNode.lambda$0(RootNode.java:86)
	at jadx.api.ResourcesLoader.decodeStream(ResourcesLoader.java:71)
	... 20 common frames omitted

Please see #500, as a first step.

Looks like Error decode: resources.arsc exception was introduced in PR #487.
But I don't think it is related to text search window, because parsing executed of file open.

@asashour I made a fix for resource decoding exception. Can you check your issue with search dialog? If it still exists I need a way to reproduce it, because it works well for me.

Thanks, but I still have the issue, possibly because I am now not with the docking station, so the window may be somewhere else. I would check this on Monday again.
Steps:

Open GUI
Open file
Go to any class, to see its code
Navigation -> Text Search
"Decompiling" is progressing
"Indexing" is progressing
Nothing happens.

Expected: a window to search for the text.
This also happens for the "Class Search"

This is strange, and I can't reproduce it.
Only I can suggest is to reset settings ("Reset" button in preference dialog), because jadx save position and size of all windows, maybe somehow was saved zero size or wrong location. Or, check that values in Tools -> Log Viewer -> change log level to Debug and check first string started with Loaded settings:  at "windowPos" variable. Hope we will find the source of this issue.

Thanks, that solves it.
I guess this is potential enhancement, to check if the values are outside the current resolution.
I am closing this for now.


kutty-bootstrap: TabView component

Should have this behaviour: https://getbootstrap.com/docs/4.6/components/navs/#javascript-behavior

The TabView component should allow creating component with a tablist and different content associated with each tab in the tablist. The content of the "tab panel" should change based on which tab is selected.
Sample usage:
from kutty.bootstrap import TabView

tabs = {
    "Alice": "Alice likes Foo",
    "Bob": "Bob likes Bar",
    "Charlie": "Charlie likes Baz",
}
tab_view = TabView()
for title, content in tabs.items():
  tab_view.add_tab(title, content)

If user wants more control, they can use tab_view.tab_list and tab_view.tab_panel.

How will you support icons or badges in the title?
Something like:
https://getbootstrap.com/docs/4.6/components/badge/#pill-badges

How about if the title need not be text?
We could something like this:
tab_view = TabView()

for title, content in tabs.items():
    tab_view.add(Pill(title), content))

Same goes for content too.

Wouldn't it be better to have a separate TabPane class that contains both the title and the body?
That way, you can do:
tabs = TabView()
tabs.add_tab("Home", home())

which is same as:
tabs = TabView()
tabs.add(TabPane("Home", home()))

The TabPane can support extra options like pills, icons etc.

The tab title and body both need to go into separate divs. Also, I think my
solution was not correct. There are separate classes for each nav style.
nav-tabs and nav-pills are just two, and both have to be added on the
tab list and not individual tabs. I think a style_as="tabs" or
style_as="pills" might be more consistent here.
On Wed, Feb 1, 2023, 12:42 PM Anand Chitipothu @.***>
wrote:

Wouldn't it be better to have a separate TabPane class that contains both
the title and the body?
That way, you can do:
tabs = TabView()
tabs.add_tab("Home", home())
which is same as:
tabs = TabView()
tabs.add(TabPane("Home", home()))
The TabPane can support extra options like pills, icons etc.
—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/kutty/issues/26#issuecomment-1411568845,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7MKYPWMQYT4O3NIP4URBTWVIEHVANCNFSM6AAAAAAUNKGK2U
.
You are receiving this because you authored the thread.Message ID:
@.***>

The tab title and body both need to go into separate divs. Also, I think my solution was not correct. There are separate classes for each nav style.

What you have mentioned is just an interface. The implementation can decide to render the title and body in separate divs.

What you have mentioned is just an interface. The implementation can decide to render the title and body in separate divs.

For the components so far, we create special methods for adding elements like this conveniently, but each component itself renders only one output and that is directly added to the parent. It would be powerful if we could figure out a way to render a child differently based on its parent.

Rendering starts at the parent and parent decides how to render the
children. So the parent component has complete control over how to render
the children, either as a single div or in two different places.
On Wed, Feb 1, 2023, 4:25 PM Kaustubh Maske Patil @.***>
wrote:

What you have mentioned is just an interface. The implementation can
decide to render the title and body in separate divs.
For the components so far, we create special methods for adding elements
like this conveniently, but each component itself renders only one output
and that is directly added to the parent. It would be powerful if we could
figure out a way to render a child differently based on its parent.
—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/kutty/issues/26#issuecomment-1411862086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAB3EKJK3ZBCSWETZ33QFTWVI6K7ANCNFSM6AAAAAAUNKGK2U
.
You are receiving this because you commented.Message ID:
@.***>

But the render method would be on the child itself and it can only render to HTML text.
If we modify the parent's render method to take out the tab and content as attributes from the child, then that should be a new kind of component because sometimes it will be rendered with its render and sometimes with its parent's render.

Why not something like this?

class TabView:
    def __init__(self):
        self.panes = []

    def render(self):
        a = self.render_tabs()
        b = self.render_content()
        return html.div(a, b).render()

    def render_tabs(self):
        tabs = [pane.render_tab() for pane in self.panes]
        return html.ul(*tabs, class_="nav nav-tabs", role="tablist")

    def render_content(self):
        contents = [pane.render_content() for pane in self.panes]
        return html.div(*contents, class_="nav-content")

class TabPane:
    def __init__(self, title, content):
        self.title = title
        self.content = content

    ...

Because it doesn't store panes in self.children, it won't work with the
Optional wrapper element, but I think this should work if we store panes
in self.children and type-check through self.children instead.
I get the idea though that we create separate render methods on children
and rather than having separate add methods on parent.
On Wed, Feb 1, 2023, 4:52 PM Anand Chitipothu @.***>
wrote:

Why not something like this?
class TabView:
def init(self):
self.panes = []
def render(self):
    a = self.render_tabs()
    b = self.render_content()
    return html.div(a, b).render()

def render_tabs(self):
    tabs = [pane.render_tab() for pane in self.panes]
    return html.ul(*tabs, class_="nav nav-tabs", role="tablist")

def render_content(self):
    contents = [pane.render_content() for pane in self.panes]
    return html.div(*contents, class_="nav-content")

class TabPane:
def init(self, title, content):
self.title = title
self.content = content
...

—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/kutty/issues/26#issuecomment-1411898906,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7MKYOM7JWWQNXWF53BI7TWVJBODANCNFSM6AAAAAAUNKGK2U
.
You are receiving this because you authored the thread.Message ID:
@.***>

Why should Optional look at children. It should probably call an is_empty method with a default implementation using children . Subclasses should be able to provide custom implementation for that.

Agreed! This makes more sense.
On Wed, Feb 1, 2023, 5:40 PM Anand Chitipothu @.***>
wrote:

Why should Optional look at children. It should probably call an is_empty
method with a default implementation using children . Subclasses should be
able to provide custom implementation for that.
—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/kutty/issues/26#issuecomment-1411957512,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI7MKYJPGCD2KVURUZ54JGLWVJHE3ANCNFSM6AAAAAAUNKGK2U
.
You are receiving this because you authored the thread.Message ID:
@.***>


teradps/client/ranking/navbar/modal.html

43: ng-model="submit.newRanking.server"
wtf? :)

Good catch, thanks for letting me know.


Watch ink script directory recursively for changes

Swap out fs.watch for chokidar. Drop MD5 hash checks as the compilation is pretty fast anyway

 Ink tools doesn't watch sub directories but it should


Stuck on uploading zip to apple

I tried running notarize through github ci, and it is stuck on uploading the zip file to apple server
It worked yesterday, not sure if a patch was released that changed something, or if it is an error on apple servers
electron-notarize:spawn spawning cmd: xcrun args: [
'notarytool',
'submit',
'/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/electron-notarize-733mVx/MyApp.zip',
'--apple-id',
'*********',
'--password',
'*********',
'--team-id',
'*********',
'--wait',
'--output-format',
'json'
] opts: {}

solved, probably a hiccup in apple server

Is there a way to submit, get the UUID back, and then check again later on in another workflow job or something? I really wouldn't want this sort of delay eating up minutes of my CI time, 5-15minutes is already pushing it kind of high as Apple's communicated default for how long this should take, but it could be hours.

The above issue occurs for me.. its been 2 days
This is the log im getting so far https://pastebin.com/4mAaNRvk

Did the problem resolve for you? For me, the same seems to happen. Everything looks good but the process gets stuck at the very same step of or after app submission. Is there anything to check via electron-notarize or in the apple developer account?


Set SelfLink and Namespace fields correctly for Instances and Bindings

This was excruciatingly difficult to track down. 😱
cc @MHBauer @arschles

hey, look, two more places we have namespace information! It's almost like the types should have a method where they can be queried for whether they are in a namespace.
The links look good. Any ideas on brokers and serviceclasses?

The links look good. Any ideas on brokers and serviceclasses?

Broker and ServiceClass are correctly implemented as being non-namespaced.

I'm good with this. LGTM and merging now

  selfLink: /apis/servicecatalog.k8s.io/v1alpha1/brokerstest-broker
  selfLink: /apis/servicecatalog.k8s.io/v1alpha1/serviceclassestest-serviceclass

That doesn't look right to me.

Yep, those are issues, but not this issue.
On Wed, Feb 22, 2017 at 2:18 PM, Morgan Bauer<EMAIL_ADDRESS>wrote:

selfLink: /apis/servicecatalog.k8s.io/v1alpha1/brokerstest-broker
selfLink: /apis/servicecatalog.k8s.io/v1alpha1/serviceclassestest-serviceclass
That doesn't look right to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/400#issuecomment-281772243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmOfCwz-_uR7bq4TOmvY5FmM_l4rjks5rfIoEgaJpZM4MIQhT
.


[Feature]

Description
I would like to add a Compound Interest Calculator which would input the Principal amount, Interest rate and Time (number of years) from the user and display the compound interest. The proposed calculator would be created using HTML, CSS, and Javascript and can be added to the website as per the given guidelines.
Screenshots

Disclaimer: The screenshot is not of my own calculator. It is just a sample to show how the final calculator may look  like
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[X] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 kindly assign me this issue under JWoC  (after the coding phase starts)

Compound Interest calculator is already present on the website. Pls raise new issues only after checking the website, repository, and the issues for the existing ones @zul132

Hey @Rakesh9100 i checked the website but I could only see a Simple Interest calculator


Windows Cred API Accesses

Is your feature request related to a problem? Please describe.
Something for the password box to talk to
Describe the solution you'd like
Windows Creds API
Describe alternatives you've considered
Some sort of kee-pass like 2ndary file.  need to figure out linux support.

closed with 9f2b0451921d1346b4758e37fd858bcb28689489


bug in DataArray.plot.pcolormesh

What happened?
The below code fails - I believe its because _infer_interval_breaks is applied asymmetrically when one coord is string.
What did you expect to happen?
Success.
Minimal Complete Verifiable Example
from xarray import DataArray

x = DataArray(
    [[1, 2, 3], [4, 5, 6]],
    dims=("a", "b"),
    coords={"a": [1, 2], "b": ["a", "b", "c"]},
)
x.plot(infer_intervals=False)  # succeeds
x.plot()  # TypeError: Dimensions of C (2, 3) are incompatible with X (3) and/or Y (3); see help(pcolormesh)

MVCE confirmation

[X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
[X] Complete example — the example is self-contained, including all data and the text of any traceback.
[X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
[X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output
No response
Anything else we need to know?
No response
Environment

version 2022.3.0

suggested patch:
@@ -1446,9 +1446,10 @@ def pcolormesh(x, y, z, ax, xscale=None, yscale=None, infer_intervals=None, **kw
         else:
             infer_intervals = True

+    either_string = np.issubdtype(x.dtype, str) or np.issubdtype(y.dtype, str)
     if (
         infer_intervals
-        and not np.issubdtype(x.dtype, str)
+        and not either_string
         and (
             (np.shape(x)[0] == np.shape(z)[1])
             or ((x.ndim > 1) and (np.shape(x)[1] == np.shape(z)[1]))
@@ -1463,7 +1464,7 @@ def pcolormesh(x, y, z, ax, xscale=None, yscale=None, infer_intervals=None, **kw

     if (
         infer_intervals
-        and not np.issubdtype(y.dtype, str)
+        and not either_string
         and (np.shape(y)[0] == np.shape(z)[0])
     ):
         if len(y.shape) == 1:

Looks buggy indeed. But maybe either_string needs to handle z inputs as well?
Do you want to create a pull request?


Add allowed package sources policy

This adds a new allowed_package_sources policy that can gate content fetched by cachi2. This rule take a lot from the allowed_external_references, but makes it specific to content fetched by cachi2, because it is not uncommon for dependencies fetched by other means to define externalReferences of type distribution. Cachi2 currently produces the mentioned external reference only for packages fetched with the generic fetcher (docs WIP) that always produces a pkg:generic purl, but it is possible it will be extended to other package managers supported by cachi2 as well.
The rule data for this policy are structured as a list of regex patterns for a given purl type. Examples in tests.
Finally, this is my first contribution to EC (and rego) so please excuse any antipatterns I might have invented, feedback very much welcomed.
Resolves ISV-5342

@ralphbean could I get your eyes on this as general concept as well as the effective_on date?

It would be nice to add some explanation to the commit message, and also include a Jira reference, e.g.:
Ref: https://issues.redhat.com/browse/ISV-5342

(I know it's explained in the PR, but having it in the git history is preferable IMO.)
Nice PR btw!

It would be nice to add some explanation to the commit message, and also include a Jira reference, e.g.:

Commit message amended to better describe the change and reference a JIRA ticket.


Update README.md

What is this PR for?
To accelerate expanding Rekcurd, we need to update our installation manual.

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   92.17%   92.17%
=======================================
  Files          11       11
  Lines         946      946
=======================================
  Hits          872      872
  Misses         74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f033e...1f3c794. Read the comment docs.


Unexpected selection panel UI when removing an entity

Repro:

plots example
reset blueprint
remove "parabola" from the "curves" space view
now the "curves" entity path has a different selection panel with red warnings

https://github.com/rerun-io/rerun/assets/49431240/2c7dec6c-de62-4ab0-a9f2-daaf1c56180b

Happens with all entities once "Visualizer selection for all views" is enabled

this got already fixed for remove item context menu, but not that remove button

Oh yeah. Needs the same remove from selection treatment.


Make it possible to resize tabs

Since I often need to specify code that exists in two versions, the large vertical size of the tabs gets in the way, so I would like to be able to resize them, at least in height.
I also want to be able to remove all margins and padding that delimits the text specified in the tabs.
Here's a good example from opencv
I would be glad if something like this could be done.
Alternative option or only this.

You can override the tab css. I don't see it in scope to make tabs dynamically resizable.

I don't see it in scope to make tabs dynamically resizable.

Not dynamically (although this is an interesting feature), I'm only talking about static configuration.

You can override the tab css

Ok then how can I do this?

You can add custom CSS files to any sphinx docs via the [sphinx conf.py file] (https://stackoverflow.com/a/37980230/8103477).
#117 will allow you to remove all of the current formating to start from scratch too

You can add custom CSS files to any sphinx docs via the sphinx conf.py file.

Thanks for the help, now sphinx-tabs is used in the documentation for cython, the python compiler!


Fix compiler directive for gfx941 and gfx942

Added compiler directives for gfx941 and gfx942 in float8 header files.

Please fix static analysis fail.


how to join this project?

I'm very interested in this

If you're interested in contributing feel free to make a PR and I'll be happy to review and merge.


My repo is not syncing

Tried to set up another repo with a dataset but it is stuck while syncing. I am wondering if it's because I used whitespace in the dataset name:

So I updated the dataset name to remove whitespace and use lowercase letters only. But it gave the following error:

It's true that I don't have config.json file in my repo but is it required?

@anuveyatsu Thanks for reporting. I've already noticed this issue myself and have just deployed the fix. And no, config.json is definitely not required.

Closing as duplicate of #1295 which has just been fixed

Awesome @olayway 🚀


GitHubLog on 30/07/2015

2015-07-30 10:08:16.3539|WARN|thread: 1|StandardUserErrors|Showing user error Please check your log file for more details, or email support if you are still having problems.
GitHub.IO.ProcessException: Cloning into 'jdsf.isc'...
remote: Counting objects: 18705, done.
Receiving objects:   0% (1/18705)
Receiving objects:   1% (188/18705)
Receiving objects:   2% (375/18705)
Receiving objects:   3% (562/18705)
Receiving objects:   4% (749/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   5% (936/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   6% (1123/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   7% (1310/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   8% (1497/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   9% (1684/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:   9% (1861/18705), 128.01 KiB | 247.00 KiB/s
Receiving objects:  10% (1871/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  11% (2058/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  12% (2245/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  13% (2432/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  14% (2619/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  15% (2806/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  16% (2993/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  17% (3180/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  18% (3367/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  19% (3554/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  20% (3741/18705), 1.13 MiB | 1.12 MiB/s
Receiving objects:  21% (3929/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  22% (4116/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  23% (4303/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  24% (4490/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  25% (4677/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  26% (4864/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  27% (5051/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  28% (5238/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  29% (5425/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  30% (5612/18705), 3.41 MiB | 2.26 MiB/s
Receiving objects:  30% (5738/18705), 6.11 MiB | 3.04 MiB/s
Receiving objects:  31% (5799/18705), 7.60 MiB | 3.03 MiB/s
Receiving objects:  32% (5986/18705), 7.60 MiB | 3.03 MiB/s
Receiving objects:  32% (6020/18705), 7.60 MiB | 3.03 MiB/s
Receiving objects:  33% (6173/18705), 9.86 MiB | 3.27 MiB/s
Receiving objects:  34% (6360/18705), 9.86 MiB | 3.27 MiB/s
Receiving objects:  34% (6428/18705), 12.85 MiB | 3.19 MiB/s
Receiving objects:  34% (6428/18705), 16.11 MiB | 3.48 MiB/s
Receiving objects:  34% (6428/18705), 19.20 MiB | 3.43 MiB/s
Receiving objects:  34% (6428/18705), 22.35 MiB | 3.21 MiB/s
Receiving objects:  34% (6428/18705), 25.55 MiB | 3.08 MiB/s
Receiving objects:  34% (6428/18705), 28.83 MiB | 3.21 MiB/s
Receiving objects:  34% (6435/18705), 31.92 MiB | 3.15 MiB/s
Receiving objects:  34% (6436/18705), 33.57 MiB | 3.16 MiB/s
Receiving objects:  35% (6547/18705), 33.57 MiB | 3.16 MiB/s
Receiving objects:  36% (6734/18705), 33.57 MiB | 3.16 MiB/s
Receiving objects:  36% (6855/18705), 37.04 MiB | 3.23 MiB/s
Receiving objects:  37% (6921/18705), 37.04 MiB | 3.23 MiB/s
Receiving objects:  38% (7108/18705), 38.72 MiB | 3.27 MiB/s
Receiving objects:  39% (7295/18705), 38.72 MiB | 3.27 MiB/s
Receiving objects:  40% (7482/18705), 40.47 MiB | 3.30 MiB/s
Receiving objects:  41% (7670/18705), 40.47 MiB | 3.30 MiB/s
Receiving objects:  41% (7833/18705), 40.47 MiB | 3.30 MiB/s
Receiving objects:  42% (7857/18705), 40.47 MiB | 3.30 MiB/s
Receiving objects:  43% (8044/18705), 40.47 MiB | 3.30 MiB/s
Receiving objects:  44% (8231/18705), 42.12 MiB | 3.26 MiB/s
Receiving objects:  45% (8418/18705), 42.12 MiB | 3.26 MiB/s
Receiving objects:  46% (8605/18705), 42.12 MiB | 3.26 MiB/s
Receiving objects:  46% (8697/18705), 45.60 MiB | 3.37 MiB/s
Receiving objects:  47% (8792/18705), 45.60 MiB | 3.37 MiB/s
Receiving objects:  48% (8979/18705), 45.60 MiB | 3.37 MiB/s
Receiving objects:  49% (9166/18705), 47.38 MiB | 3.39 MiB/s
Receiving objects:  50% (9353/18705), 47.38 MiB | 3.39 MiB/s
Receiving objects:  50% (9530/18705), 47.38 MiB | 3.39 MiB/s
Receiving objects:  51% (9540/18705), 47.38 MiB | 3.39 MiB/s
Receiving objects:  52% (9727/18705), 49.13 MiB | 3.41 MiB/s
Receiving objects:  53% (9914/18705), 49.13 MiB | 3.41 MiB/s
Receiving objects:  54% (10101/18705), 50.77 MiB | 3.40 MiB/s
Receiving objects:  54% (10257/18705), 50.77 MiB | 3.40 MiB/s
Receiving objects:  54% (10285/18705), 55.62 MiB | 3.28 MiB/s
Receiving objects:  54% (10286/18705), 56.50 MiB | 3.13 MiB/s
Receiving objects:  55% (10288/18705), 56.50 MiB | 3.13 MiB/s
Receiving objects:  56% (10475/18705), 58.20 MiB | 3.16 MiB/s
Receiving objects:  57% (10662/18705), 58.20 MiB | 3.16 MiB/s
Receiving objects:  58% (10849/18705), 59.62 MiB | 3.06 MiB/s
Receiving objects:  59% (11036/18705), 59.62 MiB | 3.06 MiB/s
Receiving objects:  60% (11223/18705), 59.62 MiB | 3.06 MiB/s
Receiving objects:  60% (11376/18705), 59.62 MiB | 3.06 MiB/s
Receiving objects:  61% (11411/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  62% (11598/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  63% (11785/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  63% (11798/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  64% (11972/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  65% (12159/18705), 62.53 MiB | 2.91 MiB/s
Receiving objects:  65% (12172/18705), 66.79 MiB | 2.77 MiB/s
Receiving objects:  65% (12172/18705), 69.96 MiB | 2.95 MiB/s
Receiving objects:  65% (12172/18705), 73.13 MiB | 2.96 MiB/s
Receiving objects:  65% (12172/18705), 76.17 MiB | 2.99 MiB/s
Receiving objects:  65% (12172/18705), 79.28 MiB | 3.04 MiB/s
Receiving objects:  65% (12173/18705), 80.89 MiB | 3.08 MiB/s
Receiving objects:  66% (12346/18705), 80.89 MiB | 3.08 MiB/s
Receiving objects:  67% (12533/18705), 82.54 MiB | 3.07 MiB/s
Receiving objects:  68% (12720/18705), 82.54 MiB | 3.07 MiB/s
Receiving objects:  69% (12907/18705), 82.54 MiB | 3.07 MiB/s
Receiving objects:  70% (13094/18705), 82.54 MiB | 3.07 MiB/s
Receiving objects:  71% (13281/18705), 82.54 MiB | 3.07 MiB/s
Receiving objects:  72% (13468/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  72% (13571/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  73% (13655/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  74% (13842/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  75% (14029/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  76% (14216/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  77% (14403/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  78% (14590/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  79% (14777/18705), 84.04 MiB | 3.05 MiB/s
Receiving objects:  79% (14901/18705), 87.33 MiB | 3.08 MiB/s
Receiving objects:  80% (14964/18705), 87.33 MiB | 3.08 MiB/s
Receiving objects:  81% (15152/18705), 87.33 MiB | 3.08 MiB/s
Receiving objects:  82% (15339/18705), 87.33 MiB | 3.08 MiB/s
Receiving objects:  83% (15526/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  84% (15713/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  85% (15900/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  86% (16087/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  87% (16274/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  88% (16461/18705), 89.20 MiB | 3.16 MiB/s
Receiving objects:  88% (16537/18705), 91.13 MiB | 3.21 MiB/s
Receiving objects:  89% (16648/18705), 91.13 MiB | 3.21 MiB/s
Receiving objects:  90% (16835/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  91% (17022/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  92% (17209/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  93% (17396/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  94% (17583/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  95% (17770/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  96% (17957/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  97% (18144/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  98% (18331/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects:  99% (18518/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects: 100% (18705/18705), 93.23 MiB | 3.34 MiB/s
Receiving objects: 100% (18705/18705), 93.69 MiB | 3.36 MiB/s, done.

You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'
2015-07-30 10:06:43.9897|INFO|thread: 1|CommandLineHandler|Parsing command line arguments:C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4\GitHub.exe
2015-07-30 10:06:44.0227|INFO|thread: 1|AppInstanceCommunicator|Starting up as master instance of GitHub for Windows
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| #########################################
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| GitHub for Windows started. VERSION: <IP_ADDRESS>
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| Build version: b86a398244b1616c5ff52246cf77d6a56cb1f8f9
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***************************************
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***                                 ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***                                 ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***        Have a problem?          ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***    Email<EMAIL_ADDRESS>   ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***      and include this file      ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***                                 ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***                                 ***
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| ***************************************
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| OS Version: Windows NT 6.3.9600.0 amd64
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| CLR Version: 4.0.30319.34209
2015-07-30 10:06:44.0398|INFO|thread: 5|StartupLogging| Current culture: de-DE
2015-07-30 10:06:44.0428|INFO|thread: 5|StartupLogging| Terminal Services session: no
2015-07-30 10:06:44.0428|INFO|thread: 5|StartupLogging| Location: C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4\GitHub.exe
2015-07-30 10:06:44.5741|INFO|thread: 1|HardwareRenderingHelper|Your video card appears to support hardware rendering. If this isn't the case and you see glitches
2015-07-30 10:06:44.5741|INFO|thread: 1|HardwareRenderingHelper|set the GH_FORCE_SW_RENDERING environment variable to 1
2015-07-30 10:06:44.5741|INFO|thread: 5|StartupLogging| ActivationUri: https://github-windows.s3.amazonaws.com/GitHub.application
2015-07-30 10:06:44.5741|INFO|thread: 1|App|Checking whether application is network deployed.
2015-07-30 10:06:44.6141|INFO|thread: 5|GitEnvironment|Process set up with this SSH Agent info: 2680:/tmp/ssh-UxHTOqT3KMVs/agent.3800
2015-07-30 10:06:44.6141|INFO|thread: 5|GitEnvironment|PATH is C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin;C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4;C:\Users\Suriyaa\AppData\Local\GitHub\lfs-amd64_0.5.1;C:\Program Files (x86)\MSBuild\12.0\bin;C:\Perl64\site\bin;C:\Perl64\bin;C:\ProgramData\Oracle\Java\javapath;C:\Program Files (x86)\Intel\iCLS Client;C:\Program Files\Intel\iCLS Client;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x86;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x64;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Acer\Remote Files;C:\Program Files\Microsoft SQL Server\110\Tools\Binn;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0;C:\HashiCorp\Vagrant\bin;C:\Program Files (x86)\QuickTime\QTSystem;C:\Program Files\nodejs;C:\Program Files (x86)\Skype\Phone;C:\Ruby21-x64\bin;C:\Program Files\Boot2Docker for Windows;C:\commands;C:\Users\Suriyaa\AppData\Roaming\npm;C:\Users\Suriyaa\AppData\Local\atom\bin;C:\Users\Suriyaa\AppData\Local\Android\sdk\tools;C:\Users\Suriyaa\AppData\Local\Android\sdk\platform-tools;%JAVA_HOME%\bin;%ANT_HOME%\bin
2015-07-30 10:06:44.6141|INFO|thread: 5|StartupLogging| =====================================================
2015-07-30 10:06:44.6141|INFO|thread: 5|StartupLogging|  DIAGNOSTICS                                        |
2015-07-30 10:06:44.6141|INFO|thread: 5|StartupLogging| =====================================================
2015-07-30 10:06:44.6221|INFO|thread: 5|StartupLogging| Git Extracted: 'True:
2015-07-30 10:06:44.6221|INFO|thread: 5|StartupLogging| PortableGit Dir Exists: 'C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad'
2015-07-30 10:06:44.6221|INFO|thread: 5|StartupLogging| Git Executable Exists: 'C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin\git.exe'
2015-07-30 10:06:44.6221|ERROR|thread: 5|StartupLogging| MISSING PATH!!: 'C:\Perl64\site\bin'
2015-07-30 10:06:44.6372|ERROR|thread: 5|StartupLogging| MISSING PATH!!: 'C:\Perl64\bin'
2015-07-30 10:06:44.6372|ERROR|thread: 5|StartupLogging| MISSING PATH!!: '%JAVA_HOME%\bin'
2015-07-30 10:06:44.6372|ERROR|thread: 5|StartupLogging| MISSING PATH!!: '%ANT_HOME%\bin'
2015-07-30 10:06:44.6372|INFO|thread: 5|StartupLogging| ----------------------------------------------------
2015-07-30 10:06:44.6372|INFO|thread: 5|StartupLogging| PATH: C:\Perl64\site\bin;C:\Perl64\bin;C:\ProgramData\Oracle\Java\javapath;C:\Program Files (x86)\Intel\iCLS Client;C:\Program Files\Intel\iCLS Client;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x86;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x64;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Acer\Remote Files;C:\Program Files\Microsoft SQL Server\110\Tools\Binn;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0;C:\HashiCorp\Vagrant\bin;C:\Program Files (x86)\QuickTime\QTSystem;C:\Program Files\nodejs;C:\Program Files (x86)\Skype\Phone;C:\Ruby21-x64\bin;C:\Program Files\Boot2Docker for Windows;C:\commands;C:\Users\Suriyaa\AppData\Roaming\npm;C:\Users\Suriyaa\AppData\Local\atom\bin;C:\Users\Suriyaa\AppData\Local\Android\sdk\tools;C:\Users\Suriyaa\AppData\Local\Android\sdk\platform-tools;%JAVA_HOME%\bin;%ANT_HOME%\bin
2015-07-30 10:06:44.6882|INFO|thread: 5|StartupLogger|Proxy information: (None)
2015-07-30 10:06:44.6882|INFO|thread: 5|StartupLogger|Couldn't fetch creds for proxy
2015-07-30 10:06:44.9754|INFO|thread: 5|PortablePackageManager|Already extracted PortableGit.7z, returning 100%
2015-07-30 10:06:44.9964|INFO|thread: 1|ClickOnceAppIconHelper|Updating registry with our application icon 'C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4\Images\App.ico'
2015-07-30 10:06:45.0764|INFO|thread: 5|MsysGitCertificateInstaller|Found certificate cache, loaded 162 certificates
2015-07-30 10:06:45.0764|INFO|thread: 5|MsysGitCertificateInstaller|Created certificate bundle with 174 entries
2015-07-30 10:06:45.1605|INFO|thread: 5|StartupSequence|Took 216ms to Update certificate bundle from system store
2015-07-30 10:06:47.7202|INFO|thread: 1|CommandLineToolsExtractor|Portable Git and Git LFS are already extracted
2015-07-30 10:06:47.7202|INFO|thread: 1|GitClient|Installing git lfs filters
2015-07-30 10:06:47.7412|INFO|thread: 1|GitEnvironment|Process set up with this SSH Agent info: 2680:/tmp/ssh-UxHTOqT3KMVs/agent.3800
2015-07-30 10:06:47.7412|INFO|thread: 1|GitEnvironment|PATH is C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin;C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4;C:\Users\Suriyaa\AppData\Local\GitHub\lfs-amd64_0.5.1;C:\Program Files (x86)\MSBuild\12.0\bin;C:\WINDOWS\System32
2015-07-30 10:06:47.7562|INFO|thread: 1|ProcessWrapper|Starting: Process - FileName: 'C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin\git.exe', Args: 'lfs init ', Working Directory: C:\Users\Suriyaa\AppData\Local\Temp
2015-07-30 10:06:47.7652|INFO|thread: 1|ReactiveScreen|Activating GitHub.ViewModels.ShellViewModel.
2015-07-30 10:06:47.7652|INFO|thread: 1|ReactiveScreen|Activating GitHub.ViewModels.DashboardViewModel.
2015-07-30 10:06:49.1852|INFO|thread: 1|PortablePackageManager|Already extracted gitignore.7z, returning 100%
2015-07-30 10:06:49.9337|WARN|thread: 4|LoginCache|Could not get login for host 'GitHub.HostAddress'
System.Collections.Generic.KeyNotFoundException: The given key 'login:null' was not present in the cache.
2015-07-30 10:06:49.9997|INFO|thread:14|DashboardViewModel|Selected repository 'iSC-Host/jdsf.isc'
2015-07-30 10:06:51.1105|INFO|thread: 1|RepositoryHost|Log in from cache for login 'SuriyaaKudoIsc' to host 'https://api.github.com/' SUCCEEDED
2015-07-30 10:06:51.1735|INFO|thread:24|ApplicationShellInitializer|Running post login tasks. ~/.gitconfig is set up with user.name = 'Suriyaa Kudo' and user.email =<EMAIL_ADDRESS>2015-07-30 10:06:51.2115|INFO|thread:24|SSHKeyHelper|ssh-agent already running
2015-07-30 10:06:51.2266|INFO|thread:24|PortablePackageManager|Already extracted lfs-amd64.7z, returning 100%
2015-07-30 10:06:51.2386|INFO|thread:24|GitEnvironment|Process set up with this SSH Agent info: 2680:/tmp/ssh-UxHTOqT3KMVs/agent.3800
2015-07-30 10:06:51.2386|INFO|thread:24|GitEnvironment|PATH is C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin;C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4;C:\Users\Suriyaa\AppData\Local\GitHub\lfs-amd64_0.5.1;C:\Program Files (x86)\MSBuild\12.0\bin;C:\WINDOWS\System32
2015-07-30 10:06:51.2596|INFO|thread:24|ProcessWrapper|Starting: Process - FileName: 'C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin\ssh-add.exe', Args: '"C:\Users\Suriyaa.ssh\github_rsa"', Working Directory: C:\Users\Suriyaa\AppData\Local\Temp
2015-07-30 10:06:51.4057|INFO|thread:10|SSHKeyHelper|Found existing SSH key pair
2015-07-30 10:06:51.5648|INFO|thread:14|DashboardViewModel|Took 1562ms to create repository for location: C:\Users\Suriyaa\Documents\GitHub\jdsf.isc
2015-07-30 10:06:55.1547|INFO|thread: 4|SoftwareUpdateViewModel|Checking for new version
2015-07-30 10:06:55.8382|INFO|thread:25|BackgroundFetcher|Calculated a refresh period for C:\Users\Suriyaa\Documents\GitHub\jdsf.isc.git of 3600 seconds
2015-07-30 10:06:55.8402|INFO|thread:25|BackgroundFetcher|Added a delay for C:\Users\Suriyaa\Documents\GitHub\jdsf.isc.git of 13671 milliseconds
2015-07-30 10:07:05.2511|INFO|thread: 1|RepositoryModel|Cloning repo https://github.com/iSC-Host/jdsf.isc.git
2015-07-30 10:07:05.2642|INFO|thread: 1|GitLfsSmudgeTail|Setting Git LFS smudge progress environment variable
2015-07-30 10:07:05.2642|INFO|thread: 1|RepositoryModel|Cloning 'https://github.com/iSC-Host/jdsf.isc.git' to 'jdsf.isc' in directory 'C:\Users\Suriyaa\Documents\GitHub
2015-07-30 10:07:05.2912|INFO|thread: 1|GitEnvironment|Process set up with this SSH Agent info: 2680:/tmp/ssh-UxHTOqT3KMVs/agent.3800
2015-07-30 10:07:05.2912|INFO|thread: 1|GitEnvironment|PATH is C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\cmd;C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin;C:\Users\Suriyaa\AppData\Local\Apps\2.0\GQ5H1PAM.9MT\8RT7JX90.E15\gith..tion_317444273a93ac29_0002.000e_114545a4195e25d4;C:\Users\Suriyaa\AppData\Local\GitHub\lfs-amd64_0.5.1;C:\Program Files (x86)\MSBuild\12.0\bin;C:\WINDOWS\System32
2015-07-30 10:07:05.2912|INFO|thread: 1|ProcessWrapper|Starting: Process - FileName: 'C:\Users\Suriyaa\AppData\Local\GitHub\PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad\bin\git.exe', Args: 'clone --progress --recursive  --  "https://github.com/iSC-Host/jdsf.isc.git" "jdsf.isc" ', Working Directory: C:\Users\Suriyaa\Documents\GitHub
2015-07-30 10:08:16.2828|INFO|thread:20|GitLfsSmudgeTail|Cleaning up Git LFS smudge progress environment variable

Solved by James Dennes (GitHub Support) & Suriyaa Kudo (Maintainer of this project) on 2015/07/30:


Watcha (Instant Messaging/Whatsapp) Broken

Hey there,
It seems the link is broken.
Best,

I can confirm it indeed no longer works.

Removed, thanks!


Changed atom.exe to atom.cmd

In atom.json I have changed atom.exe to atom.cmd. atom.exe blocks the command line, while atom.cmd does not.

Thanks 👍


Replace jackson-databind with jodd-json

Replaces jackson-databind with jodd-json.
The motivation behind this is to reduce the likeliness of
a version conflict in existing applications. Jackson is
one of the most common JSON libraries out there, but it has
some severe issues when multiple versions are available on the
classpath.
jodd-json is a small JSON parser/serializer library with a minimal
footprint. The resulting shaded jar of java-jwt is about half the size
compared to when its bundled with jackson-databind.
The patch has a bad side effect in that it created different tokens
than the jackson-bind implementation, since it escapes all the
characters defined in RFC4627, while jackson-databind only escapes
the MUST characters. This is visible in the test cases that include
"/" in the claim values.
Another "bad" effect is the use of Map<String, Object>, and Object
references. I've tried to add the needed type checks, but there
might dragons left to slay.
This commit should fix issue #18 and similar multiple jackson versions
issues that might be out there is the wild.
The pull request needs a fair bit a review, as I'm not that familiar with either JWT or this particular implementation of it.

This is one approach of using something smaller than Jackson to do the JSON-lifting. The needs of java-jwt json wise is quite limited, so a smaller library might suit the need quite well. I'm sure there are other JSON serializer that we might look into if this one seems not to fit the bill quite right :)
It shouldn't be to hard to roll our own actually, if that is preferred.

Even you could use JSON Processing API (but only the jar of the spec) so everyone can choose the implementation.  It would be a light dependency from the point of view of project, and in cases you are using any application server it will comes with an implementation by default.

Thanks @klette @lordofthejars. The ideal would be to adopt JSR-353 but AFAIK none of the main JSON libraries support that spec (Jackson, GSON). (source).
Concerning jodd-json we have decided that for now we will keep using Jackson but we might revisit this in the future.

Another possibility might be jackson-jr:
 https://github.com/FasterXML/jackson-jr

which is relatively small, and when using repackaged version (jr-all) does not conflict in any way with full Jackson. It does use high-performance streaming parser/generator part of Jackson, but otherwise implements a bare-bone databinding to/from Beans and "untyped" containers (Maps, Lists, wrappers).
The intent here is to create something that is bit more streamlined for embedded use, where use of annotations is not needed not custom extensibility; but where good performance and support for things like generics (typed Collections, Maps) is useful.


Proof Of Concept

PROOF OF CONCEPT
To demonstrate the following:

Search and retrieve Flight Information using an API.
Display Flight Information.
Search and retrieve Movie Information using an API.
Display Movie Information.
Perform comparison of Movie and Flight Information.

proof Of concept approved


Feature request - Build Meteor package

Hi,
I would love to see this project directly intergarted with meteor.

Never used Meteor, what would be the impact? What need to be done to be integrated with meteor?

@VenelinPetkov did you try to import the npm package?
@tleunen usually npm packages integrate pretty easily with Meteor, since Meteor can require npm packages the same way vanilla node projects can.  But, some packages integrate better than others.  Some work without any modification, and others need to be tuned for Meteor's  environment.
The challenges with google mdl and Meteor are described here: https://atmospherejs.com/zodiase/mdl

So is there anything we can do to make it easier maybe? @generalleger

@tleunen Someone with some time just needs to try it and see how easily they integrate and where the issues are.

If React works nice with meteor so this https://github.com/reactjs/react-meteor should be helpful, As mentioned in the project itself React is agnostic of the way you fetch data from the server and meteor can be easily dropped in for that part.

@darkyen Meteor has built in support for React without using that package.  You can simply do meteor add react

@generalleger I think that is the official package that meteor installs when you do meteor add react (since its by react team)

@darkyen I think this is what they add...  https://github.com/meteor/react-packages

even better :D from meteor team +1

Meteor supports React (see http://react-in-meteor.readthedocs.org/en/latest/) so this shouldn't be an issue anymore.


Create http layer for pagination

Function that will return number of pages. It will be used to display proper number of page links #174
Arguments: number of articles we need to get in one call.
Konrad EDIT: argument: number of articles per page

I also don't think this is so simple. First of all, the frontend application won't request simply the number of articles from the articles endpoint. From what I have seen from https://github.com/kpagacz/wiki-on-fire/issues/179 we want to summarize data from multiple backend endpoints, parametrized by some time frames. So a single number of articles per page argument is definitely not enough. It also seems like such parameters as number of articles per page should be passed to the function created in here: https://github.com/kpagacz/wiki-on-fire/issues/179

I am closing this in favour of the modified scope of #179.


Use actual color variable name in onboarding and export

As a user, when I look at the example import statement for both SCSS/CSS and JS/TS, I want it to reference one of my actual color names.
In the example import statements in BOTH the onboarding flow and the Export Modal, we should use the color name given, so that the user can just copy paste.
For example, if the color name is "Globex Blue", the examples should reference "globex-blue" instead of the hardcoded "primary-color"
Please include a Loom / QA.

Hey @alexdanilowicz, I have given a pull request for this issue: #164


ARROW-270: Define more generic Interval logical type

@wesm does it look good? this is based on your comments in ARROW-270


[misc] Add external storage permission

Impacted tests(approved): new 0, update 2, delete 0
Unit test platform: Crosswalk Project for Android 19.48.497.0
Unit test result summary: pass 2, fail 0, block 0
https://crosswalk-project.org/jira/browse/XWALK-6032

LGTM


[Bug:] Compute a SHA-256 in a Cairo Program Causes Inconsistent Memory Error

Description:
I've encountered an error when using the compute_sha256_byte_array function from Cairo's corelib to compute the SHA-256 hash of an input ByteArray. The issue arises consistently across multiple versions of CairoVM.
Environment:
Tested on v1.0.1 and more recent commit 0d86936.
Steps to Reproduce:
Here is a simple Cairo program that uses compute_sha256_byte_array:
use core::sha256::compute_sha256_byte_array;

fn main() {
    compute_sha256_byte_array(@"hello world");
}

I ran the program as follow:
$ cargo run program.sierra.json --layout all_cairo

The following error is thrown, indicating an inconsistent memory state:
Error: VirtualMachine(Hint((0, Memory(InconsistentMemory((Relocatable { segment_index: 1, offset: 4 }, Int(9999999999999), RelocatableValue(Relocatable { segment_index: 5, offset: 0 })))))))

@raphaelDkhn compute_sha256_byte_array uses Starknet syscall which is not available for standalone programs, I suspect that might be the issue. We ended up using Cairo1 implementation https://github.com/keep-starknet-strange/raito/blob/main/packages/utils/src/sha256.cairo however it's really slow.
Alternative way is to use HDP interop https://docs.herodotus.dev/herodotus-docs/developers/data-processor/jargon/cairo1-cairo0-interoperability and leverage Cairo0 sha256 implementation https://github.com/starkware-libs/cairo-lang/blob/a86e92bfde9c171c0856d7b46580c66e004922f3/src/starkware/cairo/common/cairo_sha256/sha256_utils.cairo

@raphaelDkhn compute_sha256_byte_array uses Starknet syscall which is not available for standalone programs, I suspect that might be the issue. We ended up using Cairo1 implementation https://github.com/keep-starknet-strange/raito/blob/main/packages/utils/src/sha256.cairo however it's really slow.
Alternative way is to use HDP interop https://docs.herodotus.dev/herodotus-docs/developers/data-processor/jargon/cairo1-cairo0-interoperability and leverage Cairo0 sha256 implementation https://github.com/starkware-libs/cairo-lang/blob/a86e92bfde9c171c0856d7b46580c66e004922f3/src/starkware/cairo/common/cairo_sha256/sha256_utils.cairo

Oh I didn't know it was using SN syscall, makes sense now. Thank you @m-kus!


Allow selecting both a user and an organization

Removed the restriction to add topics/labels to user OR organization repositories exclusively.

Can you rebase this?

I've rebased the PR and tested everything again. Let me know if I need to do any other changes :)


Cylinder gets stuck on seams of static body while sliding against it.

Godot version
v4.0.beta.custom_build [705273140]
System information
windows 10
Issue description
Sliding a cylinder shape against a static body will cause it to get stuck against the seams in the mesh.

Steps to reproduce
run project and move cylinder against the static body
Minimal reproduction project
moveSlideStuck_beta16.zip

I'm seeing similar behavior with capsules against the edges of a boxshaped rigidbody3d.

Here's an example (sorry, this is intermittent for me so I captured it when I noticed the scene geometry triggering the issue, so there's not even visible collision shapes).
https://user-images.githubusercontent.com/364501/228639708-e00d27ab-eb44-4c5f-a963-5c15355c09b5.mp4
If the original minimal repro isn't sufficient, I'll try to repro this with a capsule & box.


Prowler scan without Compliance

New feature motivation
I have hopefully simple request. I would like to be able to do scan on my environment but without getting compliance reports.
I searched in documentation but i could not find how to exclude complete  compliance scanning when running "prowler kubernetes" report.
In my instance i am having some issues with compliance output as i am running prowler inside cronjob and therefore i want to run only prowler findings scan without compliance
Solution Proposed
Include flag or something to be able to exclude compliance scan.
Describe alternatives you've considered
All alternatives  are to just separate this scans or give ability to exclude compliance scan from main scan.
Additional context
No response

Hi @Imiler,
What you're requesting is actually the default behavior of Prowler in v4. By default, Prowler runs all its checks and maps those findings to different compliance standards. If you don't want to focus on certain outputs, you can simply ignore them.
Regarding the errors you're encountering when running Prowler in your cron job, could you provide more details? Even if Prowler is being executed inside a cron job, it shouldn't produce any errors. Specific error messages or logs would help me assist you better.
I look forward to your reply. Thank you for using Prowler🚀 .

Hi,
Let me explain my setup better.
I am running prowler as kubernetes cronjob to scan cluster and output reports to S3 bucket. (i am already using this s3 bucket output with prowler as cronjob but for AWS provider), i have granted it same permissions to be able to read/write to s3 bucket on my account/
In this cronjob i have one container that is doing prowler scan command with output to volume that is mounted to it. (this is EFS shared volume mount so multiple cronjobs can use it)
In other cronjob i have single container to perform AWS cp S3 command because my prowler container does not recognize that command. (this container literally only reads stored reports in my output folder from first container and should output that to S3 bucket)
Now issue that happens is that i am unable to give permissions to my cronjob to create new compliance folder when prowler scan runs. everything is fine i am just having issue because compliance gets generated in different folder.
I hope this helps any more.

I just wanted to add up that most weird thing here is that i am unable at all to run any aws cli command.
As example for dashboard it is stated to use: aws s3 cp s3:///output/csv ./output --recursive
i cannot run this command at all. I wanted to use this to copy paste output from prowler kubernetes scan to s3 bucket which i normally use for my other prowler aws scan. in prowler aws scan my command looks like this:
prowler aws -M html csv -R arn:aws:iam::$accountID:role/iam-prowler-access-xxxxxxxxx-D prowler-xxxxxxxxx
This command above runs my aws scan with no problems across multiple accounts and stores all reports in same place.

Hi @Imiler, I want to make sure I understand your use case.
It looks like you are running prowler kubernetes within the cluster, but are having trouble exporting to S3.
Currently the prowler kubernetes provider does not support direct export to S3 the same way that prowler aws can.
To accomplish the S3 export you have attached a volume to the prowler kubernetes pod. However, saving the compliance reports results in a file system error.
Does this sound correct? If so, could you share the file system error you are receiving with us?
By default prowler stores results in the path it was executed from, are you using --output-directory argument to change that location?
If you'd like, you can join our Prowler community on Slack to share any specific details: https://join.slack.com/t/prowler-workspace/shared_invite/zt-1hix76xsl-2uq222JIXrC7Q8It~9ZNog

I am closing the issue since we got no response. Please feel free to reopen it again. Thanks for using Prowler 🚀


Check for existence of a type in a set of types

Suggestion
I want to know how if in a set of types like the following two the type null exists.
type TransactionCategory = "B2B"| "SEZWP" | "SEZWOP" | "EXPWP" | "EXPWOP" | "DEXP" | null
type DutyStatus = "WPOD" | "WOPOD"

console.log( null in TransactionCategory).  //  ==> true
console.log( null in DutyStatus) // === false

🔍 Search Terms
type-system
✅ Viability Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[?] This feature would agree with the rest of TypeScript's Design Goals.

💻 Use Cases
For the UI I want to use such types for an SELECT control to determine if the set contains the option of selecting null or not. For that case I use Generics to overgive the type.

You can't do anything at runtime because the types are completely erased by the compiler, but you can check this in a conditional type at compile-time: null extends Type ? true : false ("is null assignable to this type?")


[Sprint: 47] XD-2987 Updated [Master+Backport] JMX Module name format

With the update of JMX Module Name format from XD-2941 the Acceptance tests had to be updated.
Also cleaned up some copy past errors from the past.

LGTM, rebased and merged into master 8a40e9d22f3322801de001a23d553a2ae5dbe4c2. Cherry-picked and pushed to 1.1.x 004b9cd1f74bbe6c3f01e9c65720937bc199d3b7


Name of some constituencies are in lower case on map view, it needs to bee changed to title case

@PixeledCode Please review this pull request and merge into main so we can close this issue.


Treats // in strings as a comment

I used the beautifier at jsbeuatifier.org  to beautify some minified JS for debugging.  Part of my input was
...long array here..., "//", "some other string", //another 3000 lines of code
The // and everything after it were taken as a comment.  // inside a string should not be.
Awesome tool though, just wish it didn't have that one bug that's killing me.

@gsechan - Could you give an example?  (maybe not 3000 lines long) 😄


Update dependencies

Fixes #2 and fixes #3. KubeSchedulerConfiguration v1beta3 was removed in k8s v1.29. Tested on my homelab.

Thank you very much for this. Was this tested on a live example?

Checked and approved. Just have to update CI and the example.


Set up more strict code styles and fix existing issues

Motivation:
Review code styles with some bots automatically.
Modifications:

Set up ReviewDog in GitHub Action to review code style.

Add more check rules to checkstyle plugin.

Result:

Obvious code styles can be reviewed and commented automatically.

Tests result look good

I've just added checks for @author tag and empty JavaDoc tags (@param, @return, etc.), which is the most obvious problems that we're facing from the current contributors, if I miss some, please let me know

I've just added checks for @author tag and empty JavaDoc tags (@param, @return, etc.), which are the most obvious problems that we're facing from the current contributors, if I miss some, please let me know

I think you should set them as an error, as removing the illegal ones once for all.

Does this review only cover the changes? I remember there are plenty of author, it didn't indicate them.

Codecov Report

Merging #4337 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4337      +/-   ##
==========================================
- Coverage   27.01%   26.98%   -0.03%
==========================================
  Files        1176     1176
  Lines       25677    25677
  Branches     3664     3664
==========================================
- Hits         6936     6930       -6
- Misses      18128    18133       +5
- Partials      613      614       +1

Impacted Files
Coverage Δ

.../server/telemetry/api/TelemetryRelatedContext.java
0% <ø> (ø)
:arrow_up:

.../skywalking/apm/agent/core/remote/GRPCChannel.java
81.25% <0%> (-6.25%)
:arrow_down:

.../agent/core/context/trace/AbstractTracingSpan.java
61.94% <0%> (-2.66%)
:arrow_down:

...king/apm/agent/core/remote/GRPCChannelManager.java
69.23% <0%> (-1.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01829a...fcde902. Read the comment docs.

Related to #4272

Please fix the conflicts. Besides the unstable profile e2e(will be fixed soon), there are other tests failing, please recheck.

Seems still failing. :P

2790 files changed. :P How this could be review.  Haha.

2790 files changed. :P How this could be review. Haha.

I can't even review myself 😢 , that's why I configure an incremental check before https://github.com/apache/skywalking/pull/4337#issuecomment-583848327
FYI, I just configure the rules and hit Command+Option+L, use regular expression to remove @authors, they effect mostly in just JavaDoc and imports, so as long as the tests passed, it should be generally OK then

Don't worry about profile e2e, it has a code issue which has been fixed in #4335. Waiting CI confirmation to merge it.

Merged, and conflicts showing up. Please fix, let's make this PR merged as next to avoid endless conflicts.

Fail in spring case every time, strange though. :P

Is the agent compiling test failure from one to another because of network issue? The CI passed, so I assume the compiling should be fine.

[ERROR] Failed to execute goal on project feign-scenario: Could not resolve dependencies for project org.apache.skywalking.apm.testcase:feign-scenario:jar:1.0.0: Could not transfer artifact io.github.openfeign:feign-core:jar:9.2.0 from/to central (https://repo.maven.apache.org/maven2): Failed to transfer file https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar with status code 500 -> [Help 1]

Seems like the Maven central is not stable.

Rechecked from locally, https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar download is good.

@kezhenxu94 Do you agree we should merge this than waiting the CI fails again and again because of network issue?

@apache/skywalking-committers please update the codes locally and reimport the codeStyle.xml into your IDEA, thanks :)

@kezhenxu94 Send a notification mail to dev ml please.


cutin.it

Domain
cutin.it
Link
https://cutin.it/anRa?sport=soccer
Version
0.0.0
What browsers are you seeing the problem on?
Microsoft Edge
What OS are you seeing the problem on?
Windows
Anything else?
No response

Domain
cutin.it
Link
https://cutin.it/anRa?sport=soccer
Version
0.2039
What browsers are you seeing the problem on?
Firefox
What OS are you seeing the problem on?
MacOS

They obfuscated their js lol.
For now they simply rely on window.count being set to -1 to fill the href in the button.
Quite ugly but for personal use, I made an userscript just for me.
        const checkElement = async selector => {
            while (document.querySelector(selector) === null) {
                await new Promise(resolve => requestAnimationFrame(resolve));
            }
            return document.querySelector(selector);
        };

        checkElement('a[class*="btn"][class*=sadsad]:not([href^=\\#])').then((selector) => {
            var url = selector.href;
            console.log("LINK FOUND : " + url);
            location.assign(url);
        });

        setTimeout(function () {
            console.log("resetting count")
            window.count = -1;
        }, 100)

Not sure when window.count is set or anything and i'm way to lazy to find more so I just set window.count to -1 every 100ms.

The JS is encoded with this method : https://scriptasylum.com/tutorials/encode-decode.html
Pretty trivial to decode.
var rawHTML;
window.dF = function(s) {
    var s1=unescape(s.substr(0,s.length-1));
    var t='';
    for(i=0;i<s1.length;i++)t+=String.fromCharCode(s1.charCodeAt(i)-s.substr(s.length-1,1));
    var unescappedHTML = unescape(t);
    rawHTML = unescappedHTML;
    return unescappedHTML;
}

and call the original dF('longstring') from the original site by copy / pasting it.
Not sure how to do get the raw string from dF programmatically.
JS Obtained from the code link above is then :

Countdown that contains our url.

Full Working POOC Userscript using MutationObserver's API :
https://gist.github.com/Write/d76f028279d9777873f051f8c9f04e1d
Tested and working on Firefox / Chrome.

Done in #766.


stack_LinkedList.cpp

In the above algorithm, first it is checked whether there is sufficient space to insert a new item and if the space is available, the item is inserted at the top of the stack. The insertion actually is made at the beginning of the linked-list and in deletion we first   check that whether the list is having any element or not. If it is having one or more elements, then the element at the top is deleted and correspondingly pointers are changed.

provide a detailed description of your algo.

Hi I had updated the description
On Mon, Oct 10, 2022 at 12:47 PM Manan Sharma @.***>
wrote:

provide a detailed description of your algo.
—
Reply to this email directly, view it on GitHub
https://github.com/manan-shxrma/dsalgo/pull/167#issuecomment-1272878032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASUFKNXZWLZFQ5VY4T4LGHTWCO7JZANCNFSM6AAAAAARA75CYM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update How-to-release.md

Modify section: Upload to Apache svn

Coverage remained the same at 19.237% when pulling 16d8228b7ee0825bf844a526d94884d8b3097ea6 on peng-yongsheng-patch-1 into 87a49597252f73eb057297bb820be9be63991353 on master.


chore: add default tag when tag is empty

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @gaocegege

Release note:

NONE

docker will use latest tag when the provided tag is empty.

Maybe we also need to support it in save and push.

Done, I moved it to the ParseReference function, that can unifies all kinds operator.


update http module with requests, methods, and statuses

Signed-off-by: Brian Downs<EMAIL_ADDRESS>

Well detailed description of the change :

Resolves:

Type of change:

Adds access to common headers, response codes, and messages.

[ ] Bug fix

[x] New feature

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping

[ ] Tests have been updated to reflect the changes done within this PR (if applicable).

[ ] Documentation has been updated to reflect the changes done within this PR (if applicable).

Preview (Screenshots) :

I can update docs if this changes is deemed acceptable.


Add MLIR files and op for three models in Stable Diffusion

Add MLIR files and op for three models in Stable Diffusion

Thanks!


accept s3.endpoint_url in aws config file

Codecov Report

Merging #46 (08a3aab) into main (1ac50d6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   86.93%   86.95%   +0.01%
==========================================
  Files          35       35
  Lines        3713     3717       +4
==========================================
+ Hits         3228     3232       +4
  Misses        485      485

Impacted Files
Coverage Δ

megfile/s3.py
92.58% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac50d6...08a3aab. Read the comment docs.


Readme

Changing the Readme with more plain sentences and mentioned related works (parse5 and htmlparser2).

CLA is valid!


adding a new test, small updates

FOR CONTRIBUTOR:

[X] I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
[X] License permits unrestricted use (educational + commercial)
[ ] This PR adds a new tool or tool collection
[X] This PR updates an existing tool or tool collection
[ ] This PR does something else (explain below)

Attention: deployment failure!
https://github.com/richard-burhans/galaxytools/actions/runs/10799704747


Info provider enhancements

I've ran into a couple of fixes and enhancements that I needed to adapt the MultiplexingDocumentStore to work with the MountInfoProvider. Not sure that I got the API right, so sending a pull request for discussion.

Closing to try a different approach regarding the MountInfoProvider API


order of arguments in in_top_k and top_k_categorical_accuracy not consistent

The order of the arguments in the function keras.backend.in_top_k(y_pred, y_true, k) is the opposite as in the function keras.metrics.top_k_categorical_accuracy(y_true, y_pred, k). I believe it would be good to have the same order for API consistency. Is there a good reason why this is not the case?

I see your point and it's valid, but I'm not sure we can change the backend function signature (it would break a lot of existing code.

Tagging as feature as this is a request to change the API.


MimeType Issue

Hey,
I have been running into an issue with this plugin. It gets installed and everything is fine and alright. Problem is when i open a product page, i sometimes get an empty page with an image in between, specially on chrome browser.
i get the following in console.
Resource interpreted as Document but transferred with MIME type image/jpeg:
I tried disabling all the extension i have installed one by one.. and this is the one which was causing the issue
Can you please let me know where i went wrong. I am currently debugging it myself as well.
I will let you know if i come up with something
Thanks

Hey @hammadxoho,
Sorry for the late reply! I dunno if you're still trying to resolve this problem. However, if you are, can you post some screenshots?

Closing because of lack of response. I don't have enough information to action this.


How do you run commands after performing a query?

Is there a way to run commands after performing a query? I tried using a CommandBuffer, but this doesn't satisfy the borrow checker:
fn foobar(mut world: World) {
    let mut cmd = CommandBuffer::new();
    let foobar_query = world.query::<&mut f32>();
    cmd.run_on(&mut world);
}

error[E0502]: cannot borrow `world` as mutable because it is also borrowed as immutable
   --> src/main.rs:407:16
    |
406 |     let foobar_query = world.query::<&mut f32>();
    |                        ----- immutable borrow occurs here
407 |     cmd.run_on(&mut world);
    |                ^^^^^^^^^^ mutable borrow occurs here
408 | }
    | - immutable borrow might be used here, when `foobar_query` is dropped and runs the `Drop` code for type `QueryBorrow`

It seems to work after manually dropping foobar_query:
fn foobar(mut world: World) {
    let mut cmd = CommandBuffer::new();
    let foobar_query = world.query::<&mut f32>();
    drop(foobar_query);
    cmd.run_on(&mut world);
}

But that's not really ideal in terms of ergonomics.

The more idiomatic approach would most likely be
fn foobar(mut world: World) {
let mut cmd = CommandBuffer::new();
{
let foobar_query = world.query::<&mut f32>();
// use the query here
}
cmd.run_on(&mut world);
}

but in principle, yes the query and its borrow of the `world` must end before `cmd.run_on(..)` can have exclusive/mutable access to `world`.

Typically you consume queries in a for loop or some sort of iterator construction, as illustrated in various examples. It They are then implicitly dropped after you're done with them.

Thanks, that works for me.


Update Simulation-service to align with new model schema

FYI: there's been little progress with a new AMR so I can't imagine this will be started let alone completed (by me at least @tangopapatime) before I start my Vacation next week.

Is this the same as #25?

yes i'm pretty sure this is a duplicate

@dgauldie i added #25 to the "Feature Planning" project so you can still track this issue. if this isn't right we can reopen this issue


[bug] Display issue in the side panel when notes have descriptions including line-breaks

🐞 Bug report
Description
When a note's description includes multiple lines, the side panel with the list of all notes attempts to render the descriptions including the linebreaks

🌍 Your Environment
Windows 10. I didn't have this issue before, so I am wondering if it might be related to changes in VSCode. I did update to VSCode 1.72? at some point in the last few days (not sure if the two events happened at the same time).

closed by #145


Interface, VMInterface filter based on IP Address (no ip address filters exist in 1.0 but could leverage the same code as VMInterface)

@nautobot/core related? #422


Update to v110

Closes #99.
Highlights:

Removed all of the debian_buster and inox patches. (Please leave comment if your setup depends on any of them.)
Updated google-toolbox-for-mac and LLVM.
Added a patch to fix building with LLVM 15.
Added a patch to disable the clang version check. (Copied verbatim from the Windows port. Maybe this patch should be in the upstream repo?)
Added another patch to allow bootstrapping gn with the default Python path.
Removed instructions relating to Python 2 from the readme, as it seems that it's not needed anymore.
Updated the copyright year.

I haven't tested packaging this yet, and someone else should probably test this out with their own setup as well, but otherwise I consider this ready for review.
UPDATE: Verified that this PR can build a functional DMG with build.sh.

Please address the failing test.

It seems to be building just fine. @networkException what do you think?

LGTM! I'm not familiar with the CI setup here but I assume merging and tagging should create a release? Also we need to figure out how to point homebrew at this repository

I've canceled all workflows except the tag-related.

Also we need to figure out how to point homebrew at this repository

It seems to be pointing to kramred's repository since like eternity :)

@kramred I only just now saw that you also published a release for this version on your fork. Are you still keeping that fork alive?
I'd generally like to have canonical packaging in this repository, as, if I understood you correctly, you don't have enough time to maintain packaging consistently. Ideally other people could just step in and push updates here.

kamred’s fork has been the only place producing fairly up-to-date arm64 builds for a long time.
The cost of macOS ARM64 workflows on github actions is incredibly high from what I remember.
On 5 Mar 2023 at 21:08 +0800, networkException @.***>, wrote:

@kramred I only just now saw that you also published a release for this version on your fork. Are you still keeping that fork alive?
I'd generally like to have canonical packaging in this repository, as, if I understood you correctly, you don't have enough time to maintain packaging consistently. Ideally other people could just step in and push updates here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hi,
thank you all, esp. @implicitfield, for keeping the macOS version up to date and having the binary releases here in the official macOS repo now.
I had pushed a release for the v110 version in my repo to have the updated binary available via homebrew.
The cask code for homebrew needs an update to point here and all should be good again regarding installing/updating via brew.

Alright, thanks for the update. I'm currently a bit busy, @implicitfield would you be willing to maintain this repo more actively (thats mainly publishing releases and getting them onto homebrew, etc)?


Support Braavos account class hash

Add support for latest Braavos account class hash: 0x00816dd0297efc55dc1e7559020a3a825e81ef734b558f03c83325d4da7e6253
Contract class from here.

Thanks for reporting. This is now supported in Starkli v0.2.6. Please run starkliup and it should work.


Setup nx

Replaces custom build configurations with Nx.
Notes

Most changes come from the package-lock.json file.
I recommend installing the nx CLI: npm install --global nx
To run all projects (in dev mode): npm start
To build all projects: npm run build
To test all projects: npm test
To lint all projects: npm run lint
For individual commands, use commands like nx serve api or nx test web
CMS database migrations have been removed in favor of the built-in snapshot tool. You can try it out with a blank database: nx import cms
To export changes to the CMS data model, run nx export cms and commit the updated snapshot.yml file.
CMS seed script still works the same as before, for now.
Basic dockerfiles for the API and Web projects are provided, but will need to extra checks for security hardening.
ESLint rules should work the same
No major source code changes. Some TypeScript related errors were fixed.
Building all projects result in build artifacts in the dist directory. The relevant projects include a generated package.json file with its runtime dependencies. Some dependencies might be missing if they're not directly imported in the related source code. See example of that in the docker/api/Dockerfile image.
The web-e2e project is a basic Cypress setup to be used for end-to-end testing the Web project.
Use separate databases for the CMS and API projects due to how the snapshot feature works.

Noticed one console error - getting the TypeError html.reduce is not a function whenever the dispatch notifications task is run.

Thanks @dallashuggins for the reminder! This should be fixed in a9c816a

Awesome! Confirmed that fixed it for me as well 🙌
One thing I noticed started happening is this message:
i18next::backendConnector: loading namespace emails for language en failed [Error: ENOENT: no such file or directory, open '/Users/dallas/Development/Work/Algorand/algomart/dist/apps/api/locales/en/emails.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/dallas/Development/Work/Algorand/algomart/dist/apps/api/locales/en/emails.json'
}

Afterwards it loads for en-US and finds the files, but initially looks for en and fails. Doesn't seem to affect anything, but results in a console error.

One thing I noticed started happening is this message [...]

🤦  I forgot to remove debug: true from i18n

Once this is merged, I recommend taking the following steps:

Backup your local .env files and ensure your local changes are stashed away or committed to your own feature branch
git switch main
git pull
npm install
npm install --global nx
Restore your .env files from backup
Ensure project runs as expected: npm start


Encoding problem of name

As you may know, unicode should be accepted in name (and even in URL but it's not the subject here).
Some name is writen in cyrilic: ðàäóæíûé ãåé-õàá.
But the pinger failed to treat it:
# /root/go-dcpp/dcping ping "dchub://XXXX.ru:411"
2019/03/04 22:06:09 invalid characters in name: "\xa0\xf0\xe0\xe4\xf3\xe6\xed\xfb\xe9\xa0\xe3\xe5\xe9-\xf5\xe0\xe1"
{"addr":["dchub://XXXX.ru:411"],"status":"offline"}*

Moreover, some names are just <Enter hub name here>, eg a correct name

I need to know more about this hub. Does it report any specific encoding to the pinger? Because if not, we have no way to detect it.
In any case, the pinger should not fail that way on encoding errors.

Does it report any specific encoding to the pinger?

I think we misunderstand.
Here, the case is, the hub is named "ðàäóæíûé ãåé-õàá" in other hublist.
When pinging it using dcping : /root/go-dcpp/dcping ping "dchub://XXXX.ru:411"
The pinger returns the error: invalid characters in name: "\xa0\xf0\xe0\xe4\xf3\xe6\xed\xfb\xe9\xa0\xe3\xe5\xe9-\xf5\xe0\xe1"
After some research, (for eg https://www.online-toolz.com/tools/text-unicode-entities-convertor.php /  Decode/Unescape Unicode Entities) \xa0\xf0\xe0\xe4\xf3\xe6\xed\xfb\xe9\xa0\xe3\xe5\xe9-\xf5\xe0\xe1 =  ðàäóæíûé ãåé-õàá
This problem occurs in this case: invalid characters in name: "<Enter hub name here>" (dchub://<IP_ADDRESS>:1209 or dchub://<IP_ADDRESS>:1209)

OK, thanks for clarifying it!

The first case (invalid characters in name: "\xa0\xf0\xe0\xe4\xf3\xe6\xed\xfb\xe9\xa0\xe3\xe5\xe9-\xf5\xe0\xe1") is from dchub://hubqueers.ru:411


Restaurant table reservation training data

I would like to contribute restaurant table reservation training data consisting of user location, restaurant type, table preference  and user review

Thanks for raising this issue, @amn41 will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Solved in #48


Fertile Crescent Plan pull request update

Ok I have done an "update from master" like what you said.

Yes, your latest merge is good Merge remote-tracking branch 'refs/remotes/simsulla/master' . Before that however you made a strange commit t, that revert some changes in the master (see the issues.txt file.
You should do a merge commit, and then add your changes and commit, and then make the pull request.