dependency failed to start

What did you do?

docker compose up

What did you expect to see?
I would expect the container to start without error.
What did you see instead? Under which circumstances?
dependency failed to start: container prometheus is unhealthy
System information
macOS 14 (Sonoma)
Prometheus version
v2.47.0

Prometheus configuration file
# my global config
global:
  scrape_interval: 15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
  # scrape_timeout is set to the global default (10s).

  external_labels:
    monitor: 'phoenix_app'

# Alertmanager configuration
alerting:
  alertmanagers:
    - static_configs:
        - targets:
          # - alertmanager:9093

# Load rules once and periodically evaluate them according to the global 'evaluation_interval'.
rule_files:
  # - "first_rules.yml"
  # - "second_rules.yml"

# A example scrape configuration for running Prometheus with Docker.

scrape_configs:
  # Make Prometheus scrape itself for metrics.
  - job_name: 'prometheus'
    static_configs:
      - targets: ['host.docker.internal:9090']
      # - targets: ['prometheus:9090']

  # Create a job for Docker daemon.
  #
  # This example requires Docker daemon to be configured to expose
  # Prometheus metrics, as documented here:
  # https://docs.docker.com/config/daemon/prometheus/
  - job_name: 'docker'
    static_configs:
      # - targets: ['<IP_ADDRESS>:9323']
      - targets: ['host.docker.internal:9323']

  #
  # Create a job for the Phoenix application.
  #
  # Reference:
  #
  # https://github.com/akoutmos/prom_ex/blob/master/example_applications/shared_docker/prometheus/config.yml#L15-L17
  #
  - job_name: 'phoenix_app'
    scrape_interval: 5s
    static_configs:
      - targets: ['host.docker.internal:4000']

  # Create a job for Docker Swarm containers.
  #
  # This example works with cadvisor running using:
  # docker run --detach --name cadvisor -l prometheus-job=cadvisor
  #     --mount type=bind,src=/var/run/docker.sock,dst=/var/run/docker.sock,ro
  #     --mount type=bind,src=/,dst=/rootfs,ro
  #     --mount type=bind,src=/var/run,dst=/var/run
  #     --mount type=bind,src=/sys,dst=/sys,ro
  #     --mount type=bind,src=/var/lib/docker,dst=/var/lib/docker,ro
  #     google/cadvisor -docker_only
  # - job_name: 'docker-containers'
  #   docker_sd_configs:
  #     - host: unix:///var/run/docker.sock # You can also use http/https to connect to the Docker daemon.
  #   relabel_configs:
  #     # Only keep containers that have a `prometheus-job` label.
  #     - source_labels: [__meta_docker_container_label_prometheus_job]
  #       regex: .+
  #       action: keep
  #     # Use the task labels that are prefixed by `prometheus-`.
  #     - regex: __meta_docker_container_label_prometheus_(.+)
  #       action: labelmap
  #       replacement: $1
# remote_write:
#   - url: '<Your Prometheus remote_write endpoint>'
#     basic_auth:
#       username: '<Your Grafana Username>'
#       password: '<Your Grafana API key>'

Alertmanager version
N/A

Alertmanager configuration file
N/A

Logs
docker compose up
[+] Running 2/0
 ✔ Container prometheus  Created                                                                                0.0s
 ✔ Container grafana     Created                                                                                0.0s
Attaching to grafana, prometheus
prometheus  | ts=2023-10-01T06:08:38.909Z caller=main.go:583 level=info msg="Starting Prometheus Server" mode=server version="(version=2.47.0, branch=HEAD, revision=efa34a5840661c29c2e362efa76bc3a70dccb335)"
prometheus  | ts=2023-10-01T06:08:38.909Z caller=main.go:588 level=info build_context="(go=go1.21.0, platform=linux/arm64, user=root@409eb5e6b30c, date=20230906-10:27:30, tags=netgo,builtinassets,stringlabels)"
prometheus  | ts=2023-10-01T06:08:38.909Z caller=main.go:589 level=info host_details="(Linux 6.3.13-linuxkit #1 SMP PREEMPT Thu Sep  7 07:48:47 UTC 2023 aarch64 39d6d04f566a (none))"
prometheus  | ts=2023-10-01T06:08:38.909Z caller=main.go:590 level=info fd_limits="(soft=1048576, hard=1048576)"
prometheus  | ts=2023-10-01T06:08:38.909Z caller=main.go:591 level=info vm_limits="(soft=unlimited, hard=unlimited)"
prometheus  | ts=2023-10-01T06:08:38.910Z caller=web.go:566 level=info component=web msg="Start listening for connections" address=<IP_ADDRESS>:9090
prometheus  | ts=2023-10-01T06:08:38.910Z caller=main.go:1024 level=info msg="Starting TSDB ..."
prometheus  | ts=2023-10-01T06:08:38.911Z caller=tls_config.go:274 level=info component=web msg="Listening on" address=[::]:9090
prometheus  | ts=2023-10-01T06:08:38.911Z caller=tls_config.go:277 level=info component=web msg="TLS is disabled." http2=false address=[::]:9090
prometheus  | ts=2023-10-01T06:08:38.912Z caller=head.go:600 level=info component=tsdb msg="Replaying on-disk memory mappable chunks if any"
prometheus  | ts=2023-10-01T06:08:38.912Z caller=head.go:681 level=info component=tsdb msg="On-disk memory mappable chunks replay completed" duration=1.042µs
prometheus  | ts=2023-10-01T06:08:38.912Z caller=head.go:689 level=info component=tsdb msg="Replaying WAL, this may take a while"
prometheus  | ts=2023-10-01T06:08:38.914Z caller=head.go:760 level=info component=tsdb msg="WAL segment loaded" segment=0 maxSegment=1
prometheus  | ts=2023-10-01T06:08:38.914Z caller=head.go:760 level=info component=tsdb msg="WAL segment loaded" segment=1 maxSegment=1
prometheus  | ts=2023-10-01T06:08:38.914Z caller=head.go:797 level=info component=tsdb msg="WAL replay completed" checkpoint_replay_duration=23.375µs wal_replay_duration=1.628625ms wbl_replay_duration=41ns total_replay_duration=1.663791ms
prometheus  | ts=2023-10-01T06:08:38.915Z caller=main.go:1045 level=info fs_type=EXT4_SUPER_MAGIC
prometheus  | ts=2023-10-01T06:08:38.915Z caller=main.go:1048 level=info msg="TSDB started"
prometheus  | ts=2023-10-01T06:08:38.915Z caller=main.go:1229 level=info msg="Loading configuration file" filename=/etc/prometheus/prometheus.yml
prometheus  | ts=2023-10-01T06:08:38.916Z caller=main.go:1266 level=info msg="Completed loading of configuration file" filename=/etc/prometheus/prometheus.yml totalDuration=708.334µs db_storage=959ns remote_storage=1µs web_handler=334ns query_engine=5.417µs scrape=161.041µs scrape_sd=19.542µs notify=9.792µs notify_sd=3.125µs rules=834ns tracing=1.75µs
prometheus  | ts=2023-10-01T06:08:38.916Z caller=main.go:1009 level=info msg="Server is ready to receive web requests."
prometheus  | ts=2023-10-01T06:08:38.916Z caller=manager.go:1009 level=info component="rule manager" msg="Starting rule manager..."
dependency failed to start: container prometheus is unhealthy

Hi!
Could you give us more info on your compose configuration? We don't provide anything in this repo, so it's unclear how you run & configure Prometheus (other than scrape config). You injected some commentary about # Create a job for Docker Swarm containers. but it's within scrape config, so it's hard to parse, plus we don't see how you spin up Prometheus containers. Thanks! 🤗
It feels you might missed some readiness probe (or healthcheck it's called in Docker swarm?)
(Triaged during Prometheus bug scrub meeting)

@bwplotka I have created a sample repository that you can find at the following location:
https://github.com/conradwt/promex-example-using-docker-desktop

Yep, it looks like a docker compose error https://github.com/docker/compose/blob/2945532f978ba1fc5b4e448359cf18f2e35f76eb/pkg/compose/convergence.go#L375C1-L375C63
I suggest you take a look at those healthchecks logs (maybe docker inspect may help)


Memory leak and inefficiencies

Team

[X] I've assigned a team label to this issue

What happened?
CancellationTokenSource memory leak where cancellation token sources are not being disposed of.
MemoryCache in the HalibutRuntime should only be created when needed. While the impact on Tentacle when creating this is minimal, it creates memory noise when running hundreds of HalibutRuntimes in the same Process.
Reproduction
.
Error and Stacktrace
No response
More Information
No response
Workaround
No response

Fixed in https://github.com/OctopusDeploy/Halibut/pull/355

Release Note: Halibut Memory Optimisations


Fix email protection in-context signup verification link handling

Task/Issue URL: https://app.asana.com/0/488551667048375/1207036390723022/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4412  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite


update initialopen ids on props change

When you change the initialOpen props, it has no effect right now. I needed this so I could track and change open nodes from my redux state.

@broncha
Thanks for the PR!
The code is fine. But the name of the prop is initialOpen, so I think it needs to be explained.
Can you please add to the API description in the README that if the prop is updated, the open state of the tree is also reset?

@minop1205 updated readme

@broncha
Confirmed.
Thank you!

@minop1205 you plan on a new release soon?

@broncha I have just published v2.0.2.
The initialOpen fix is also included in this version.

@minop1205 Thanks a lot!


RectangleComponent doesn't render paint

Current bug behavior
RectangleComponent doesn't render paint
Expected behavior
RectangleComponent does render paint
Steps to reproduce

class MyGame extends FlameGame {
  final rectangle = MyRectangle();

  @override
  Future<void>? onLoad() async {
    add(rectangle);
  }
}

class MyRectangle extends RectangleComponent {
  final myPaint = Paint()
    ..style = PaintingStyle.fill
    ..color = Colors.green;

  @override
  Future<void> onLoad() async {
    debugMode = true;
    size = Vector2(50, 50);
    position = Vector2(150, 150);
    paint = myPaint;
  }
}

Flutter doctor output

[✓] Flutter (Channel stable, 3.3.7, on macOS 12.6 21G115 darwin-arm, locale en-US)
    • Flutter version 3.3.7 on channel stable at /Users/lukepighetti/development/flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e99c9c7cd9 (12 days ago), 2022-11-01 16:59:00 -0700
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/lukepighetti/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

More environment information

Flame version: 1.4.0
Platform affected: web, perhaps more

Log information

Enter log information in this code block

More information

Possible duplicate of #1545. At least root cause seems to be the same. @lukepighetti please set the size while construction of your component to get passed this.

Updated the original issue to reflect this, thank you


Provide batched inference

LGTM! Do we need to collaborate with each other and try sending messages to the bot from different accounts on tg? Or is it not necessary, because other tests have been conducted? If so, maybe it would be a good idea to add tests to our repo as well? Or is that too much for us for now?

Totally agree about tests
I've added some basic ones now: server up, single request and concurrent requests


fix ResourceAllocation bug in ShiftCreateView

Coverage: 86.724% (+0.7%) from 86.015% when pulling 65bb8a57de5eff816aea97691433a970261a3913 on simpleresource-fix into 8bd3dbe0c9c8818fe29e9953757a28a4ca3ea975 on main.


useState(), useEffect() hook causes Viewer/ImageryLayer reload

When my component with Resium Viewer is changed with useState()/useEffect() hooks map is re-rendered. Maybe same problem as here

That is the expected behavior; please make good use of useMemo and other methods to prevent the read-only property from changing.
See also: #372


Anfranci/fix update cmd for jobs

PR to fix update command for Container App Job resources.
This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please write the description of PR into the HISTORY.rst, and if you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py


Kube Context Flag not respected

What steps did you take and what happened:
I am running the velero install command, but it does not appear to be respecting the --kubecontext flag.
What did you expect to happen:
I have three contexts in my local kubeconfig, APP-Dev and APP-Gotham are the two I am interested in. Even with my current context set to APP-Gotham, when I run the command, it still applies to the cluster that my local kubectl has setup as the default context. I expect the --kubecontext flag to be used regardless of what my current default context is.
The output of the following commands will help us better understand what's going on:
The following gist shows that my current default context is set to APP-Gotham. Prior to running velero install there are no pods (nothing exists yet). When I run the command with the --kubecontext set to APP-Dev, it still installs using the APP-Gotham context. You can see that the pod was created in the velero namespace.
https://gist.github.com/djtaylor/f26fafd1be6a42d5084e24fdf7c8dd54
Anything else you would like to add:
This appears to be client side only. If I can provide any other troubleshooting information please let me know.
Environment:
velero version:
Client:
	Version: v1.0.0
	Git commit: 72f5cadc3a865019ab9dc043d4952c9bfd5f2ecb

kubectl client and server version:
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.3", GitCommit:"435f92c719f279a3a67808c80521ea17d5715c66", GitTreeState:"clean", BuildDate:"2018-11-26T12:57:14Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.3", GitCommit:"435f92c719f279a3a67808c80521ea17d5715c66", GitTreeState:"clean", BuildDate:"2018-11-26T12:46:57Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

We are running on bare-metal using Ubuntu 18.04.2 with Kubernetes version 1.12.3.

xref #1637

@nrb can you look into this some more? I took a quick look and saw that here we're explicitly constructing a config, using empty strings for kubeconfig/kubecontext, rather than using the client.Factory passed into NewCommand(...) which gets those values bound to the flags. It looks like we might want to add a DynamicClient(...) method to the client.Factory type to make this easier, that uses the proper kubeconfig/kubecontext values.

That does indeed look like the right fix. PR incoming shortly.


rm: supported boards: imx6ulevk: fix preparation steps

Make preparation steps imx6ul-specific.
Make materials for preparation steps for imx6ull more specific.
Signed-off-by: Oleksandr Suvorov<EMAIL_ADDRESS>Readiness

[ ] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Make preparation steps imx6ul-specific
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[x] Run spelling and grammar check, preferably with linter.
[x] Avoid changing any header associated with a link/reference.
[x] Step through instructions (or ask someone to do so).
[x] Review for wordiness
[x] Match tone and style of page/section.
[x] Run make linkcheck.
[ ] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[ ] follow best practices for commits.

[x] Descriptive title written in the imperative.
[ ] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.

[ ] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for 8df12f0e8d4037f0ead8ccffbb223efa321ad026 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1808/docs/artifacts/html/index.html


[Question] How gtp5g module works between nodes ?

My scenario: I'm using free5gc with k8s on 3 node cluster. (1 node for Core Network, 1 node for UPF, 1 node for UE + gnB)
Question: Do I have to install gtp5g module only on UPF node or also on UE + gnB node ?
Question 2: Why is gtp5g supported on old OS only for old kernels 5.0/5.4 ? Right now we have Ubuntu 22 and kernel 5.18. Maybe it's good idea to update.

@MichalzDev

You only need to install gtp5g on the UPF node.
It's due to Linux API name always be changed.
if you are interested in, you could submit the pull request for supporting kernel 5.18^


Update the filtering UI to support filtering by issue type and tags.

This work will include some UI updates and updates to React.  I'm open to suggestions here, I have no strong feelings about the look so long as it's functional and relatively user-friendly.

I will have a look at implementing this


Zen Swing Wallet uses only 1 CPU core

I noticed that when updating the blockchain, swing wallet is only using one core.  Anyway to allow it to use multiple cores for faster blockchain updates?

The actual process of on-disk block-chain synchronization is not done by the GUI but by the ZEN core/node. The right place to report this issue is: https://github.com/ZencashOfficial/zen/issues

Can this issue be closed as it's not a Swing Wallet one ?

@zennermac should be able to close this one.


Align the content and definitions

The blog has been worked through with @swinslow  and Dolan for messaging:
https://github.com/communitybridge/easycla/blob/master/docs/getting-started.md#what-is-a-cla
Where is the content from here coming from and has legal reviewed?  We should have content aligned where we can:
https://github.com/communitybridge/easycla/blob/master/docs/getting-started.md#what-is-a-cla

Are these two different links? Am I missing something?

Oh, the cut and paste went wrong.  The versions are different, and I cut and paste from the blog into my original version of the getting-started doc.
https://www.linuxfoundation.org/blog/2019/07/easycla-beta/
Not sure if it's a good use of time introducing new content and then, if it hasn't been vetted, we go back and re-vet everything.

We've had several reviews on the current documentation since this issue was raised. Closing this issue during our backlog review. If additional help (be specific) is needed for the documentation, then please create a new ticket.


Change .timestamps to have variable arity

Previously, .timestamps had zero-arity.  It created created_at
and updated_at timestamps.
This change makes it so you can specify one or more custom timestamps.
See discussion at rom-rb/rom-rails#19

For some reason, I didn't get this error locally, but finally, I was able to reproduce it.
The issue seems to be with this line in lib/rom/rails/railtie.rb
ROM.setup(config.rom.repositories.symbolize_keys)

Being new to the codebase, I'm not quite sure what goes here. Should it be :sql?

@kchien we should get @aflatter's eager_loading branch merged into master so that you could rebase on top of it - it updates rom-rails to work with latest rom (from master). Sorry about that!

@solnic No worries. I was worried I messed up the code! :smile:

@solnic I rebased onto master and it appears the tests are passing now.

Merged. Thanks :)


Gitter (or other forum)?

Hi! Do you any forum where people could discuss autograd related stuff? For instance, Gitter would be a great option. Or are the issues meant as the place to ask questions?

Why not ask away here?


pin pip version for jupyter extension docker build

the latest release of pip was pulling in different versions of dependencies which broke our build. this change pins the pip install version to the version before that, which was working.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kevin Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Send rppo package for inclusion in rOpenSci

Re-look at requirements for rOpenSci

This has been sent!


Don't assume hardcoded udev rules

I would like to use a local clone of rivalcfg without doing a system installation of the package. I use an existing system to handle my udev rules files with specific groups. I am not willing to use perm 0666 but use 0660 instead. While this is a more advanced setup, there should not be a technical reason why the udev rules are required to use the specific filename. Please consider having udev rules be a separate configuration step, but during rivalcfg execution not assuming or requiring a specific udev config file. It should be sufficient to check presence and permissions for the known set of supported device ids - if they have the needed permissions then make it available for use.

Hello,
I do not know of to check permission before trying to open the device and having an error (I do not manipulate directly files in /dev, I use a library that abstract the access to HID devices for multiple OS).
If the udev file is not present, Rivalcfg only displays a warning that can be ignored by the end user. This warning and commands to install rules were added because most of the issues reported by users were related to that.
:)


Fix SwiftUI Previews in Xcode 14

Things to consider before you submit the PR:

[x] Are tests passing locally?
[x] Are the files formatted correctly?
[ ] Did you add unit tests?
[x] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description
This PR fixes SwiftUI Previews in Xcode 14 that failed to run when adding Azure Notification Hubs SDK through SPM.
Related PRs or issues
The fix is based on this PR from Visual Studio App Center SDK.
Misc
This PR fixes the following issue:
An iOS project doesn't work anymore for SwiftUI Preview with Xcode 14.
The project builds and runs fine, but Preview never works. The error message is as follows:
HumanReadableSwiftError

SettingsError: noExecutablePath(<IDESwiftPackageStaticLibraryProductBuildable:ObjectIdentifier(0x000060001f8fee80):'WindowsAzureMessaging'>)

Azure Notification Hubs SDK is added thought SPM.
SwiftUI Preview with Xcode 13 works.
More information about the issue in Xcode 14 can be seen in this Apple Developer forum thread.

@microsoft-github-policy-service agree

@rafaelcalunga thanks for the PR submission. I'll take a look and make sure this doesn't have any unintended side-effects.

@rafaelcalunga I spent some time researching the issue, and looking at the change made to the AppCenter SDK.
While removing the .type from the Swift library seems to workaround the Xcode issue, I'm concerned that changing the library type in the Swift package would be a breaking change for existing consumers of the package.
I noticed that AppCenter also released this change as part of a new major library version (see AppCenter PR #2439), which suggests they were also concerned with breaking existing consumers.
Several developers are reporting that Xcode 14.2 resolves the SwiftUI preview issue. That would be preferable to changing the library type.
Can you confirm if you've tried with Xcode 14.2?

@brannon I am happy to report that Xcode 14.2 appears to have resolved this issue for my apps.
Version 14.2 (14C18)
WindowsAzureMessaging 3.1.5

@rafaelcalunga thank you for confirming!


[AMORO-2510] [Improvement]: add some flink runtime info for optimizer

Why are the changes needed?

Close #2510.
Brief change log

Get TaskmanagerInfo through getRuntimeContext().getTaskManagerRuntimeInfo().getConfiguration() and add info  to the fail message
Add a metric for the total number of tasks processed in the optimize executor, and include optimizeGroup as a label for easier visualization

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@Aireed Can you add this part of unit tests or related screenshots?

@Aireed Thanks for your contribution.
Now, we support three deployment modes: yarn-per-job, yarn-application, kubernetes-application. I found that the kubernetes environment is not distinguished. The current logic will also be executed under kubernetes.
Can we only execute it in the yarn environment?
applicationId is the value from the high-availability.cluster-id attribute. If the user does not enable HA, will it affect the execution of FlinkExecutor?
I did not obtain taskmanager.resource-id in my environment (Flink 1.14.4 + yarn application mode). I saw the official website description 1. It is invalid under yarn?

Now, we support three deployment modes: yarn-per-job, yarn-application, kubernetes-application. I found that the kubernetes environment is not distinguished. The current logic will also be executed under kubernetes. Can we only execute it in the yarn environment?

of course we can if the info is meaningless in k8s environment.  i have no k8s environment, could you have time to test it.  i will find some way to distinguish the environment.

applicationId is the value from the high-availability.cluster-id attribute. If the user does not enable HA, will it affect the execution of FlinkExecutor?

I have tested  this scenario before submitting the PR. Even if HA is not enabled, the property "high-availability.cluster-id" still exists.

I did not obtain taskmanager.resource-id in my environment (Flink 1.14.4 + yarn application mode), I missing something? I saw the official website description 1. It is invalid under yarn?

i will try it later.
@zhongqishang

Now, we support three deployment modes: yarn-per-job, yarn-application, kubernetes-application. I found that the kubernetes environment is not distinguished. The current logic will also be executed under kubernetes. Can we only execute it in the yarn environment?

of course we can if the info is meaningless in k8s environment. i have no k8s environment, could you have time to test it. i will find some way to distinguish the environment.

I test in my k8s env(Flink 1.14.4 + k8s 1.19), TASK_MANAGER_RESOURCE_ID, HA_CLUSTER_ID is normal, like below:
TASK_MANAGER_RESOURCE_ID : {cluster id}-taskmanager-1-1,
HA_CLUSTER_ID : {cluster id}

But I didn't find HOST.

applicationId is the value from the high-availability.cluster-id attribute. If the user does not enable HA, will it affect the execution of FlinkExecutor?

I have tested this scenario before submitting the PR. Even if HA is not enabled, the property "high-availability.cluster-id" still exists.

Yes, it exists.

I did not obtain taskmanager.resource-id in my environment (Flink 1.14.4 + yarn application mode), I missing something? I saw the official website description 1. It is invalid under yarn?

i will try it later.
@zhongqishang

My fault, it exists.

cc @czy006 , this is the result of local test. PTAL.
Additionally, I have communicated offline with @zhongqishang  ,  and the information on the K8s environment is also ok and sufficient.


Add delete functionality to the CLI

User story
As a user of the DCP CLI, I want to have access to the bundle deletion functionality in the data store project so that I can delete bundles.
Depends on https://github.com/HumanCellAtlas/data-store/pull/684
Context
The /bundles/{uuid} HTTP endpoint in data-store now supports the HTTP DELETE method. This method requires the replica to be specified in the query string.

Triggering this without a version deletes the whole bundle
Triggering this with the version deletes that specific version

Will this command be visible and accessible to all users of the CLI? Should we restrict it somehow?

Good question, @kozbo. Until we have proper auth, the command could rely on boto credentials being present.

… and invoke the deletion lambda directly through the AWS APIs. Same could be done for reindexing.


[turborepo] outdated eslint doc (eslint-config-custom package)

What version of Turborepo are you using?
1.10.13
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
The documentation in https://turbo.build/repo/docs/handbook/linting/eslint is outdated. In the newly created monorepo, there are no longer an index.js file in packages/eslint-config-custom but a library.js, next.js, and react-internal.js instead. The website doesn't mentioned anything about these files.
Also, the extended eslint are different; old = "custom" new = "custom/next" which is different from this section: https://turbo.build/repo/docs/getting-started/create-new#understanding-eslint-config-custom
Expected Behavior
The doc should reflect the monorepo config
To Reproduce

====================

Reproduction Repo
No response

Thanks @boompikachu, we're in the middle of re-working these to be more consistent / correct. The code is landing first and the docs will follow shortly!

Thanks @boompikachu, we're in the middle of re-working these to be more consistent / correct. The code is landing first and the docs will follow shortly!

Thank you for an amazing monorepo
By the way, when changing from using index.ts (1.10.12) to next.js (1.10.13) file, will old users know the changes? I'm curious since if I were to init my turborepo now, will I miss out on some of the new features in the future?

Hi, is there any updated docs/ examples how to use the newly created files ( next.is, library.js etc..) Thanks

what are the use cases of library.js?


Change gyp to gn

Chrome has switched from gyp to gn, and Fuschia also uses it now.
Note that the "Chromium Ninja documentation" link is dead, but I'm not sure what to replace it with. The closest I've found is https://chromium.googlesource.com/experimental/chromium/src/+/refs/wip/bajones/webvr/docs/ninja_build.md, but I'm not sure that's the original intended target.

I think gn should be added. gyp still seems to exist here. Rebasing would fix the CI problem too.

IMHO removing GYP is fine, as there's also https://github.com/ninja-build/ninja/wiki/List-of-generators-producing-ninja-build-files.

The "Chromium Ninja" link target no longer really exists, now that ninja is the only way to build Chromium. Maybe that part can just go away.


perf: update dropdown version

Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Enhancements:

Update the dropdown version from 3.1.0 to 3.2.0 to improve performance.

:tada: This PR is included in version 3.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Edit: KSNF-DT1

Channel ID (required)
KSNFDT1.us
Channel Name
No response
Alternative Names
No response
Network
No response
Owners
No response
Country
No response
Subdivision
No response
City
No response
Broadcast Area
No response
Languages
No response
Categories
No response
NSFW
None
Launched
No response
Closed
No response
Replaced By
No response
Website
No response
Logo
https://upload.wikimedia.org/wikipedia/en/5/5c/KSNF_KSN_16_2023_logo.png
Notes
No response

Please update your request:

the size of the logo should not exceed 512x512px

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels


Recorded data found in mycar/tub folder but no data in mycar/data/

Is it correct behavior? I can found those record images and steering.json file in mycar/tub but nothing in mycar/data. But the instruction mentioned that to sync tub from mycar/data

I found a commit about change to single tub, checking whether it is related
https://github.com/wroscoe/donkey/commit/f5e0a996ca32be78f0813a5cb2384772ffbe0a12


[Feature] Support resourcetracker can be stored after compressing

For saving the capacity of the etcd cluster in the hub cluster, some resources are expected to less size.
For the resourcetrackers with more versions and  within all resources specifications, compressing them before saving will save much capacity, and improving usability of the hub cluster.
For implematation, we can set a parameter --feature-gate when core-controller work

Not only rt  but also apprev.

Let's talk this in #4395

@chivalryq They're not the same thing, so I removed the dup label. I think compress the data should be important as the data can be large and exceed the etcd limit(2MB) that make the vela core not work.


The test logger will now log the correct caller

Previous, since we weren't skipping, the logged caller would be 'logging.go'
For example see conformance logs here
info TestBlueGreenRoute logging/logging.go:141 Creating a Configuration

Will become
info TestBlueGreenRoute  conformance/blue_green_test.go:183 Creating a Configuration

/assign @srinivashegde86

can u add some context on what is this for?

@srinivashegde86 I updated the PR & commit messages to provide better context
Assigning @mdemirhan (as well) since I cleaned up the implementation by allowing zap.Options to be accepted by the pkg/logging library
/assign @mdemirhan

/approve
/lgtm

thanks for doing this. I was wondering how to do this, but did not get time to look into it.
This is great and will be helpful in debugging :)

/lgtm
/approve


[Work in progress] Classpath issue when trying Google Pubsub on Local docker env

I'm stuck trying to run my code changes in Hudi's local docker environment. The code is getting picked up correctly but there is a method conflict with Preconditions.checkArgument. Below is the full stack trace:
root@adhoc-2:/opt# spark-submit --class org.apache.hudi.utilities.sources.PubsubEventsSource $HUDI_UTILITIES_BUNDLE

22/08/03 11:55:32 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Exception in thread "main" java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;J)V
        at com.google.api.gax.batching.BlockingSemaphore.checkNotNegative(BlockingSemaphore.java:41)
        at com.google.api.gax.batching.BlockingSemaphore.<init>(BlockingSemaphore.java:45)
        at com.google.api.gax.batching.FlowController.<init>(FlowController.java:189)
        at com.google.api.gax.batching.FlowController.<init>(FlowController.java:158)
        at com.google.cloud.pubsub.v1.Subscriber.<init>(Subscriber.java:169)
        at com.google.cloud.pubsub.v1.Subscriber.<init>(Subscriber.java:91)

I'm aiming to replicate the Step #2 of the Building Local Docker Containers from the Hudi docs, which says the Jars can be picked up locally via the $HUDI_WS variable.
I'm currently suspecting issues with Guava pulled in for Presto and Trino, and trying to comment Presto and Trino modules before running the following command:
$ mvn clean package -Pintegration-tests -DskipTests -Dcheckstyle.skip -Drat.skip=true
I've also tweaked the POM of the packaging/hudi-utilities-bundle to manually include a bunch of Google Pubsub related Jars while generating the Shaded jar.
Related Slack thread: https://onehouseinc.slack.com/archives/C022Z7ZAC95/p1659541874159959

Was able to get over above error. Current error is shown below. Interestingly, same error happens outside of Docker too, when I followed the instructions here: https://app.clickup.com/18029943/v/dc/h67bq-7684/h67bq-20387. So likely something with the changes when I pull in the Google Pubsub libs and tweak the POM (hackily) to get it somehow to work with that.
$ spark-submit --class org.apache.hudi.utilities.sources.PubsubEventsSource $HUDI_UTILITIES_BUNDLE
22/08/04 06:24:12 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Exception in thread "main" java.lang.NoSuchMethodError: org.apache.hudibundle.com.google.api.core.AbstractApiService$InnerService.startAsync()Lcom/google/common/util/concurrent/Service;
        at org.apache.hudibundle.com.google.api.core.AbstractApiService.startAsync(AbstractApiService.java:119)
        at com.google.cloud.pubsub.v1.Subscriber.startAsync(Subscriber.java:294)
        at org.apache.hudi.utilities.sources.PubsubEventsSource.subscribeAsyncExample(PubsubEventsSource.java:38)

Am able to get over the issue by tweaking the POM and adding shading relocation etc (see latest state of PR). Program launches successfully and no classpath errors. It doesn't detect new Pubsub data though. That's probably due to some other error!


Shell highlighting single quotes is wrong.

When highlighting shell code with ' in it, the highlighter goes bananas. As seen here.
lukkit_help(){
    echo Lukkit
    echo Available Commands:
    command -v column >/dev/null 2>&1 && cmd="column -t -s -" || cmd=cat
    $cmd <<<'
    lukkit init        | Initialize Lukkit
    lukkit patch apply | Apply patches to build/
    lukkit patch build | Build patches from build/'
}

lukkit_init(){
    git submodule update --init
    cp -a indirect/Bukkit build/Bukkit
    cp -a indirect/CraftBukkit build/CraftBukkit
    lukkit_patch_apply
}

lukkit_patch(){
    echo "Use: 'lukkit patch [apply|build]
    exit 1
}

@phase Linguist only selects the grammar to use for highlighting. atom/language-shellscript is used to highlight Shell code on GitHub. You should open an issue there ;)

@pchaigno Ah! The more you know!


Unable to set soap_version

Hi,
This package seems to use zend-soap. I could not find any way of setting zend-soap options, e.g. soap_version.
Is there any way of setting options?

I do think it would be useful to have an options array in the package config - thank you for the suggestion, I will include that in the next release! Meanwhile, you could extend the controller and override the server() method to include setting options.

Thx!
I did overrode server() method.


Create cross-platform build script

The current build script (Scripts/buildpack.bat) only works on Windows, but not on MacOS.
In order to be able to build from the command line and create nuget packages also on MacOS, one could either:

add a Mac-specific build script or
create a cross-platform build script (maybe based on cake)

Option 2 is clearly preferable IMHO, but option 1 is still better than the current state of things.

One limitation of the build procedure on Mac is that it cannot build the Windows-specific parts (WPF and UWP), but everything else should actually be transferable.
I am starting to work on a Mac-specific build script in a first step. Once this is done, one could possibly meld the platform-specific scripts into a cake-based cross-platform script.

Yes, this needs improvements. Not sure which is the best way to proceed. I prefer a single script of course, but the main problem is not the script but the fact that we have components that can only be build on 1 of the platforms.
Not inclined to add Cake. Linux sh scripts are actually not that bad because they could also be built with WSL2 on Windows. I expect this to become a more common approach in general.
Eventually I would like to use more github actions and also release nugets through github actions.

I also consider dropping support for things that can not be build cross platform, or move them to a separate github repository.

I also consider dropping support for things that can not be build cross platform, or move them to a separate github repository.

Huh, that sounds problematic: UWP cannot be built on Mac, iOS cannot be build on Windows (without a Mac build server). I would not want to deprecate or remove any of those two.
Instead I think that for each platfrom one should only build the supported components.
For auto-building the nupkg one should stick to Windows (plus Mac build server), since that config basically supports all components.

Valid points, still I am thinking of a way to make it more maintainable. With your new PR we have two nuspecs. The nuspec is typically something we (meaning mostly me 🙄) forget to update. Now we have two of those. What if there is one nuspec for the shared functionality and separate nuspecs for Mac and UWP/WPF?
Also it is also possible to work without nuspecs, use the solution to decide what should be in the nuget.

Also it is also possible to work without nuspecs, use the solution to decide what should be in the nuget.

I was also thinking in that direction, but it might require some restructuring of the projects in the VS solution.

Not inclined to add Cake. Linux sh scripts are actually not that bad because they could also be built with WSL2 on Windows. I expect this to become a more common approach in general.

What's your argument against cake?
The problem with shell scripts is that they are not 100% portable. First of all the shell on Mac is not exactly the same as on Linux/WSL (zsh vs bash), and then there are issues like file paths etc. I don't have too much experience with cake, but I think it helps to abstract away such differences, and really have a single cross-platform build script.

Eventually I would like to use more github actions and also release nugets through github actions.

I agree that it would make sense to use github actions for the CI builds. This also came to my mind, and it might help to work around #1115.


Time axis labelling faulty in CombinedPlot of TimePlots #4214

problem has been fixed for python and js plugins

the fix is good, need to rerun the tutorials to fix the documentation.


[BEAM-8937] Add GroupByKey Java/Flink load test to Jenkins

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run seed job

Run seed job

Retest this please

Run RAT Precommit

retest this please


Better zoom gestures

I've tried your libray for subsampling in my Gallery app and I've noticed that the zoomable gesture handler is not as good as the previous solution I've used (https://github.com/usuiat/Zoomable) specially when used with lots of gesture (swipe up vertically, horizontal pager scroll etc)
Would be great if you can look into that library or allow the use of it because it would make the solution much better for Gallery/Media Viewer usescases
For Horizontal Pager even with the scroll disabled, it still conflicts with the other gesutres (swipe up)
LaunchedEffect(zoomableState.zoomFraction) {
    scrollEnabled.value = (zoomableState.zoomFraction ?: 0f) == 0.0f
}

Thanks!

I've noticed that the zoomable gesture handler is not as good as the previous solution I've used (https://github.com/usuiat/Zoomable) specially when used with lots of gesture (swipe up vertically, horizontal pager scroll etc)

Can you share a video of the issues you're seeing? It's difficult to visualize otherwise.

For Horizontal Pager even with the scroll disabled, it still conflicts with the other gesutres (swipe up)

Same question. I'm not sure what's conflicting and a video will help.

https://github.com/saket/telephoto/assets/19311643/1f58b7a7-efab-470b-98b6-d4aa6e9e0964

ZoomableImage(
    modifier = modifier.fillMaxSize()
        .combinedClickable(
                  interactionSource = remember { MutableInteractionSource() },
                  indication = null,
                  onDoubleClick = {},
                  onClick = onItemClick
        ),
    state = state,
    image = ZoomableImageSource.coil3(
          model = ImageRequest.Builder(LocalPlatformContext.current)
                      .data(media.uri)
                      .placeholderMemoryCacheKey(media.toString())
                      .build()
    ),
    contentScale = ContentScale.Fit,
    contentDescription = media.label
)

The issue happening at 0:05 in the video looks strange. I wonder if it's happening because the image hasn't fully loaded yet. Are you using placeholder images? If so, can you add a loading indicator to verify if the gestures start working only after the image has fully loaded?
Btw, it'd be best if you can share a reproducer for me to investigate instead of going back and forth with questions. Your app looks very cool, I'd love to support it.

Here is the app with the subsampling image applied (I've also made a custom source for coil3 (alpha)
For placeholder I'm using the coil's prebuilt memory cache key to get the lower quality image that was previously loaded in a grid view
https://github.com/IacobIonut01/Gallery/tree/0c3fac0b3246f5d82fb4b77ce54d267f2ac7d701

@IacobIonut01 I haven't gotten a chance to check out your project yet, but can you try out 0.8.0-SNAPSHOT? I made a small improvement to consume gestures immediately if multiple fingers/pointers are detected in https://github.com/saket/telephoto/commit/4c9118e1680efafc2c6b7b33319f2e281dfc7532.

Sure, but I couldn't find it on maven

You'll need to add the snapshot repository to access snapshot versions:
maven {
  url 'https://oss.sonatype.org/content/repositories/snapshots/'
}

Yeah it's better now

Glad to hear! Are there any remaining improvements you need?

Glad to hear! Are there any remaining improvements you need?

The only feature that is missing is progressive zoom (double tap 2x, another double tap 5x, another double tap max zoom for example)

Cool, tracking that in https://github.com/saket/telephoto/issues/32


feat: Nitro LLM to support custom instructions

Problem

Nitro to support custom instructions

Success Criteria

Curl with example input/ output

Additional context

done with the pre-prompt backlog


Fix: 'int|integer' rule validation

你这连单测都改了。。说明你改动的有问题啊

When you use validation for GET methods, the arguments are string by default, so the integer rule will not be matched.

要不合并到3.1？

要不合并到3.1？

不打算，因为这个改动比较麻烦，我宁愿加一个 strict 来标记这个必须是严格 int

要不合并到3.1？

不打算，因为这个改动比较麻烦，我宁愿加一个 strict 来标记这个必须是严格 int

I understand the previous part, however, I just don't know if I understand how "Add the type int as strict" will fix it, since if it is not an integer it will break the application.

要不合并到3.1？

不打算，因为这个改动比较麻烦，我宁愿加一个 strict 来标记这个必须是严格 int

I understand the previous part, however, I just don't know if I understand how "Add the type int as strict" will fix it, since if it is not an integer it will break the application.

integer like 1 or "1"
integer|strict only like 1 not "1"

要不合并到3.1？

不打算，因为这个改动比较麻烦，我宁愿加一个 strict 来标记这个必须是严格 int

I understand the previous part, however, I just don't know if I understand how "Add the type int as strict" will fix it, since if it is not an integer it will break the application.

integer like 1 or "1" integer|strict only like 1 not "1"

I'm create a strict rule validation supported only int|integer and bool|boolean.
"For me it didn't make sense to have the other types since there are rules that validate them correctly."

@iamrameffort  I made some adjustments to support the strict mode through parameters. Please take a look and see if it meets your requirements.

@iamrameffort I made some adjustments to support the strict mode through parameters. Please take a look and see if it meets your requirements.

@huangdijia Very good, I hadn't thought of that. Thank you

@iamrameffort I made some adjustments to support the strict mode through parameters. Please take a look and see if it meets your requirements.

@huangdijia Very good, I hadn't thought of that. Thank you

You're welcome!
https://github.com/friendsofhyperf There are many interesting components, welcome to understand and use.


CKKS: place mgmt ops and add RNS lowering

This is a mirror of #1126.
However, the complicacy is that in the CKKS pipeline we support tensor of ciphertext, which renders the following difficulties

tensor::ExtractOp has two semantic (mentioned in #1174)

ckks::RescaleOp takes tensor of ciphertext as input, which only accepts RLWECiphertext but not RLWECiphertextLike.

In tests/Dialect/Secret/Conversions/secret_to_ckks/matmul_loop.mlir, affine is not unrolled so LevelAnalysis can not work. It should not work as we do not have loop invariant kept here. For example, for the loop to carry out correctly in FHE, the invariant is the level is the same, which heavily depends on the body.
More case analysis here. The body is a mul_plain + add, which in different mgmt op placement strategy there will be different level analysis result. For example, if we mod reduce immediately after mul_plain, we get the level reduced by one hence the invariant is not kept. For the current strategy we fortunately kept this invariant.

My current workarounds over these are

Copy the secret-to-ckks code on deciding whether to pack tensor into ciphertext, then annotate these tensor::ExtractOp to distinguish semantic so that various analysis could work.
Fully unroll the tensor, namely for each element we generate a ckks.rescale.
I prefer to disable matmul_loop.mlir for now, asking the user to full-loop-unroll. In the future, I should make the analysis establishing invariant and error out when user wrote some invariant-broken code, so that we can have correct level analysis for loops.

You will need to rebase to fix the build error I unfortunately pushed to main earlier today.

Rebased and squashed.

Fixed the building. Seems that mlir::arith and mlir::heir::arith (added by arith to mod arith) has some name conflict.

This just got copybara-merged, but things look a bit funky?

I have a feeling 9315298 was merged and that's why github didn't recognize this as merged. (I think jeremy cloned this and fixed the internal build issues at that commit?)


Add docs for graphs (#1767)

Doc changes from PR #1767 have to be in the release branch as well

/intelci: run


Add swap and staking tests to preview endpoint

Summary
Currently, the /transaction-confirmation returns a TransactionInfo-like entity for the client to render details about swaps and TWAPs. We equally have the /preview endpoint that returns a TransactionInfo entity.
This adds swap and staking test coverage to the /preview endpoint to ensure usage of it can replace the /transaction-confirmation one.
Changes

Add swap/staking test coverage.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.9%) to 91.802%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/mappers/common/transaction-info.mapper.ts
1
82.24%

Totals

Change from base Build<PHONE_NUMBER>9:
0.9%

Covered Lines:
8492

Relevant Lines:
8908

💛  - Coveralls

At the request of QA, I'm marking this as a draft until the multichain feature is released.


fix checks for process.version.node

This still isn't fixing the issue for me. I've made a proof of concept showing the issue I'm running into here. The problem seems to require the wasm files to be in a module that gets imported, so in that demo I've made a quick and dirty submod/ directory with an emscripten module that gets copied into node_modules on install.
I still get errors when I try and run it, with or without this branch:

Okay, I believe that's that's a separate issue. Have you tried the resolution that it's giving you to add "rollup-plugin-node-polyfills" to {installOptions: {rollup: { plugins: [...] }} in your config file?

Let's follow up back in https://www.pika.dev/npm/snowpack/discuss/302


Rewriting container config breaks apt-get update on Ubuntu 22.04+

For example:
root@host:/# docker run --runtime oci-interceptor --rm -it ubuntu:22.04 bash
root@28a94c545cba:/# apt-get update
[...]
E: Problem executing scripts APT::Update::Post-Invoke 'rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true'
E: Sub-process returned an error code
root@28a94c545cba:/#

Something in the post-invoke cleanup scripts must be attempting to write to one of the files we're mounting as read-only (/etc/hosts, /etc/hostname, /etc/resolv.conf)

will be fixed with https://github.com/containers/oci-spec-rs/pull/125

Fixed in v0.2.0 by depending on a oci-spec-rs fork (https://github.com/dmartin/oci-spec-rs/tree/linuxsyscall-rename).
However, leaving this issue open until we can (hopefully) revert to upstream crate following PR merge.

Resolved w/ https://github.com/picoCTF/oci-interceptor/commit/02abff386e3ca4efc8f45b72821403b435b5544c


Remove all repro/proxy code

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #3500 (5963c4a) into main (896329d) will increase coverage by 5.86%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3500      +/-   ##
==========================================
+ Coverage   39.32%   45.19%   +5.86%
==========================================
  Files         299      164     -135
  Lines       36270    21709   -14561
==========================================
- Hits        14264     9811    -4453
+ Misses      22006    11898   -10108

see 122 files with indirect coverage changes

Closing off test


Feature Request for the Advanced formula environment: add function (and argument) descriptions to modules as well

Would it be possible to add function descriptions to module functions (Modules)  as well as it can be done for "named functions" (Names > Functions)? Maybe this can be done with some sort of special comment like
// @Description("This is a function description.")

which has to be placed directly above the function definition.
And maybe something similar can also be done for the functions arguments?

You should be able to add function descriptions already. Here is a related thread that might be helpful.
https://github.com/microsoft/advanced-formula-environment/issues/61
We do not have support for argument descriptions. A similar request is here: https://github.com/microsoft/advanced-formula-environment/issues/21
Feel free to add any feedback there!

Many thanks for the quick reply and sorry for the noise, because I wasn't aware of the extra repository. (Would I have been able to find it in this repository? If not, maybe add a link somewhere in the README.md?)
I'll close this issue here and will look through the issues there if I can find my second feature request there (as well).

No need to apologise @Mo-gul!

Would I have been able to find it in this repository? If not, maybe add a link somewhere in the README.md

Probably not - we should clarify and connect the relationship between to the repositories.
Thanks for your feedback.


Add bidirectional edge mode

It occurred to me that it would be trivial to add a bidirectional edge mode (I would have preferred "directed" and "undirected", but we already have "unidirectional"), just by taking the unidirectional edge of the lower H3 index in a given pair of cells. I don't have use cases in mind yet, but it seems like a useful primitive, and it's simple to implement on top of the unidirectional functions.
If we had a more efficient version of getH3UnidirectionalEdgeBoundary this might allow an even simpler optimization for h3SetToLinkedGeo than vertex mode.

Yep! Making the smaller index the first one is a good solution. Validating these bidirectional edges should also mark an inverted form as invalid.
A more efficient uni/bidirectional edge also would need to understand icosahedron face IJK rotations to determine the proper direction number when dealing with hexagons on the "edge" (which will depend on the res 0 parent owning icosahedron, not the icosahedron it is physically on).
Given those complexities I am not convinced a more efficient algorithm would be significantly more efficient.

This would now be called edge


Doc automation:Command reference: odo delete,list and set namespace

What type of PR is this:
area/documentation
What does this PR do / why we need it:
Which issue(s) this PR fixes:

Fixes #6724
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:

override OpenShift-Integration-tests/OpenShift-Integration-tests

/override OpenShift-Integration-tests/OpenShift-Integration-tests

I can see 3 tests failing:
FAILED] [2.655 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:40

[FAILED] [6.054 seconds]
doc command reference odo create namespace To create a namespace resource [It] Creates a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_createnamespace_test.go:35

[FAILED] [2.446 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a project resource for a openshift cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:57

I can see 3 tests failing:
FAILED] [2.655 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:40

[FAILED] [6.054 seconds]
doc command reference odo create namespace To create a namespace resource [It] Creates a namespace resource for a kubernetes cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_createnamespace_test.go:35

[FAILED] [2.446 seconds]
doc command reference odo delete namespace To delete a namespace resource [It] Deletes a project resource for a openshift cluster
/go/odo_1/tests/documentation/command-reference/doc_command_reference_deletenamespace_test.go:57

@ritudes I can see these tests failing when running them locally. I think you will need to fix them

Yes @feloy , I am looking into it.


[DDW-161] Fix theming issues on the wallet import overlays

This PR fixes UI issues on wallet import overlays
Testing Checklist

Slack QA thread
[ ] Test importing of wallets and compare with the design on all themes

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

inputs shouldn't have BG

4 in 1:
• icon should be dark
• checkbox should be dark
• "i" icon should be dark
• triangle and tooltip body are in different color

Input field color is wrong + text should be disabled too

checkbox here should be #fafbfc

for the disabled state border color and bg color should be exactly the same, so you can see it as one object

for the yellow theme we use other red to use on top of yellow color #be0b0b

when name is entered (field not empty and valid atm) we don't need this tooltip anymore I think

and

for dark blue theme are white (#ffffff), but proper color is #e9f4fe

checkbox is jumping 🤔

checkbox is jumping 🤔

Fixed

e9f4fe

fixed

imageand
image
for dark blue theme are white (#ffffff), but proper color is #e9f4fe

and

for dark blue theme are white (#ffffff), but proper color is #e9f4fe

Fixed

inputs shouldn't have BG

fixed

4 in 1:
• icon should be dark
• checkbox should be dark
• "i" icon should be dark
• triangle and tooltip body are in different color

Fixed

when name is entered (field not empty and valid atm) we don't need this tooltip anymore I think

Fixed

4 in 1:
• icon should be dark
• checkbox should be dark
• "i" icon should be dark
• triangle and tooltip body are in different color

Done

for the disabled state border color and bg color should be exactly the same, so you can see it as one object

Fixed

seems like triangle doesn't have opacity

Fix colors introduced by @nikolaglumac for block of text (1st step)

A few months ago we've updated all checkboxes, radio buttons and switches to be a bit smaller and borders to be thicker. Here borders are still thin,

@DeeJayElly This message is split on two lines in Japanese:

@DeeJayElly This message is split on two lines in Japanese:

@DeeJayElly we agreed to reduce those padding to 20px (instead of 70+)

seems like triangle doesn't have opacity

Fixed

@DeeJayElly This message is split on two lines in Japanese:

@DeeJayElly we agreed to reduce those padding to 20px (instead of 70+)

Fixed


PKCE error: invalid flow state, no valid flow state found

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Using the PKCE auth flow, await supabase.auth.exchangeCodeForSession(code) produces the following error:
AuthApiError: invalid flow state, no valid flow state found

Inspecting the DB and the gotrue source, I can see this is because user_id is NULL in the flow_state table.
To Reproduce
// root.tsx

import {
  createBrowserClient,
  createServerClient,
} from "@supabase/auth-helpers-remix";

...

export default function App() {
  const [supabase] = useState(() =>
    createBrowserClient<Database>(env.SUPABASE_URL, env.SUPABASE_ANON_KEY, {
      auth: { flowType: "pkce" },
    })
  );
  ...
}

// login.tsx

import { useOutletContext } from "@remix-run/react";
import { SupabaseOutletContext } from "../root";

export default function Login() {
  const { supabase, user } = useOutletContext<SupabaseOutletContext>();

  const signInWithGoogle = async () => {
    await supabase.auth.signInWithOAuth({
      provider: "google",
      options: {
        scopes: [
          "https://www.googleapis.com/auth/calendar.readonly",
          "https://www.googleapis.com/auth/calendar.events.readonly",
        ].join(" "),
        queryParams: {
          access_type: "offline",
          prompt: "consent select_account",
          redirect_uri: `${location.origin}/login/callback`,
        },
      },
    });
  };

  async function signInWithAzure() {
    await supabase.auth.signInWithOAuth({
      provider: "azure",
      options: {
        scopes: [
          "openid",
          "email",
          "user.read",
          "calendars.read",
          "offline_access",
        ].join(" "),
      },
    });
  }

  const logout = async () => {
    await supabase.auth.signOut();
  };

  return (
    <>
      {!user && <button onClick={signInWithGoogle}>Google Login</button>}
      {!user && <button onClick={signInWithAzure}>Outlook Login</button>}
      {user && <button onClick={logout}>Logout</button>}
    </>
  );
}

// login.callback.tsx

import type { LoaderArgs } from "@remix-run/cloudflare";
import { redirect } from "@remix-run/cloudflare";

import { createServerClient } from "@supabase/auth-helpers-remix";

export const loader = async ({ context, request }: LoaderArgs) => {
  const env = {
    SUPABASE_URL: context.SUPABASE_URL! as string,
    SUPABASE_ANON_KEY: context.SUPABASE_ANON_KEY! as string,
  };

  const response = new Response();

  const url = new URL(request.url);
  const code = url.searchParams.get("code");
  if (typeof code !== "string") return redirect("/login");

  // exchange the auth code for user session
  const supabase = createServerClient(env.SUPABASE_URL, env.SUPABASE_ANON_KEY, {
    request,
    response,
  });
  const { data } = await supabase.auth.exchangeCodeForSession(code);

  return redirect("/", {
    status: 303,
    headers: response.headers,
  });
};

Steps to reproduce the behavior, please provide code snippets or a repository:

Go to /login, click Google Login
Go through Google OAuth flow
When redirected to /login/callback, the follow error is displayed:

Unexpected Server Error

AuthApiError: invalid flow state, no valid flow state found

Expected behavior
As mentioned above, inspecting the DB and the gotrue source, I can see this is because user_id is NULL in the flow_state table. It's unclear when this would have been set, since this is the initial login, so no user has been created yet.
System information

OS: macOS
Browser: Chrome
Version of supabase-js: 2.21.0
Version of auth-helpers-remix: 0.2.0-next.3
Version of Node.js: n/a (using Cloudflare)

Additional context
Add any other context about the problem here.

Ok I've seen the issue in your code, you aren't passing the redirectTo url. I think you have confused the Supabase redirectTo url with the Google redirect_uri which are two different things.
await supabase.auth.signInWithOAuth({
  provider: "google",
  options: {
    redirectTo: `${location.origin}/login/callback`, // this is what you should have had in there
    scopes: [
      "https://www.googleapis.com/auth/calendar.readonly",
      "https://www.googleapis.com/auth/calendar.events.readonly",
    ].join(" "),
    queryParams: {
      access_type: "offline",
      prompt: "consent select_account",
    },
  },
});

Also you have some redundant code, since we are using the auth-helpers the PKCE flow is already set for you and you can't actually set auth properties of the createBrowserClient function. So you can remove the flowType stuff from the createBrowserClient.
createBrowserClient<Database>(env.SUPABASE_URL, env.SUPABASE_ANON_KEY)

@silentworks You're absolutely right! I had though I needed the provider to redirect directly to my endpoint. With that change, this works beautifully. I'm incredibly grateful for your help!

I initially asked this in the discussions, since I was not certain it was a problem with my setting or a bug. Today I tried reproducing the "User Management App with NextJS" example on my office computer, and I get the exact same error:
"AuthApiError: invalid flow state, no valid flow state found"

Any idea why I am getting this error?

@kei2e hey I don't know if you have resolved it yet, but if anyone still facing this issue, I just go ahead and remove magic link (Use the default auth ui form), this still send the magic link but it just for verify your email and you would still need a password. This worked for me when I follow the "User Management App with Next JS"
(Please love the comment if it useful, thank you!)

I struggled with this for a while but I identified the issue.
I have two urls, the self-hosted supabase (call it https://supabase) and my app (https://myapp). https://supabase is what goes in the NEXT_PUBLIC_SUPABASE_URL environment variable for example.
From the documentation it sounded like I needed to put in github and match in my code this url:
https://myapp/auth/callback
But it turns out I needed to use this url instead:
https://supabase/auth/v1/callback
For github at least, the redirect uri and the callback url needed to be the same or else I got an error.


Fix Dutch language filename on iOS

First thanks for all your work!
I encountered a small bug while installing the multiple_maps branch for an iOS app im developing which results in a file not found error of the Danish language files. The expected filename is pgm_Localizable_da.json but was pgm_Localizable_da.strings. After I renamed the file the installation worked as expected.
I hope the change is to your liking and please let me know if you need some further adjustments.

Thanks!


Patch for /table/block.cc

Look at line 192, line 197.

We are in fact finding the last restart point with a key <= target, so that we
can iterate forward to find the first key >= target.

Original issue reported on code.google.com by yalexfan on 28 Mar 2012 at 10:05

Merged into: #79

Attachments:

block.cc.patch

Original comment by<EMAIL_ADDRESS>on 28 Mar 2012 at 3:38

Changed state: Duplicate


increment seed for Travis tests

hack to ward off spurious test failures

Travis has seemingly recovered. We can reopen and merge this PR in the future, if need be.

Need be, apparently.


Cannot build the expected maps

Hi, I have run your project successfully on my PC. The instances you given can construct perfect semantic map.
When we record our own bag package,  we encounter some problems using the recorded bag package,.
we analysis the reasons:
(1) the camera position, I cannot confirm the camera position is correct, here is the calculation process:
get the pose of the first frame of the bag package, transform it into camera positon.
(2)the sensor, I used the mynteye camera record the bag package, its precision is too low, then I changed realsense camera, the reconstructed map cannot still satisfy my expectation.
Could you give me some clues, thanks a lot.

@zhaoyu19920930
Voxblox++ does not perform camera pose tracking, it relies on you to supply it with the camera poses associated with each frame via TF messages. So when you feed in your own recorded bag, make sure that the bag contains TF messages describing the camera pose associated with each incoming RGB-D frame ("associated" here means that the RGB-D image messages specify the needed frame in the frame_id field).
As for the realsense camera, I believe we have successfully used the RGB-D stream from a Realsense D435 to reconstruct dense enough object-level maps of tabletop and maybe even room-sized environments, so I do not see a clear reason why it should not work for you. What exactly are you not happy about in the reconstructed map?

Thanks for you nice reply, margaritaG.
My bag contains TF messages, and the RGB-D image messages specify the needed frame in the frame_id field. My first question  is solved.
When I cannot reconstruct map successfully, I started to study the code of the depth segementation node .Here is my understanding on this node:
(1)this node use the depth image as input, create several middle maps: depth map, depth_discontinuity map, max_distance map, min_convexity, normals map;
(2)then use the middle maps create the final_edge map;
(3)finally use the final_edge map, rgb image, mask_rcnn results generate the label map.
If my understanding has some incorrect points, please correct me.
My confusions:
(1)I find in your '/catkin_ws/src/depth_segmentation/depth_segmentation/cfg/realsense_config.yaml' file, you give the paremetes:  'max_distance_display: false',
‘max_distance_exclude_nan_as_max_distance: false’
’max_distance_ignore_nan_coordinates: false‘
that is to say, you don't use them, can you explain the meaning of max_distance map?
Many thanks！


Static callable referencing

Hello!
Please consider [ 'WP2Static\ViewRenderer', 'renderCrawlCache' ] -> [ ViewRenderer::class, 'renderCrawlCache' ]

Thanks @szepeviktor - looks like a lot of instances to go through, I'll review and make changes and fix the typing:
 Line   Controller.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  211    Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderCrawlQueue') given.
  220    Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderCrawlCache') given.
  229    Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderDeployCache') given.
  238    Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderStaticSitePat…') given.
  247    Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderPostProcessed…') given.

Parameter #6 $function of function add_submenu_page expects callable(): mixed, array('ViewRenderer::class', 'renderCrawlQueue') given.

These are resolved in the latest PR!!

Hey Leo!
It is not 'ViewRenderer::class' but ViewRenderer::class

Thanks @szepeviktor - I need some functional tests in this project for feedback!

... or yes, to actually RTFM 😄

All I can give you is grep -rFn 'WP2Static\'

Thanks, I'm halfway through em now. I'm lazy with git grep 'WP2Static\\'

All right.
In views e.g. use WP2Static\URLHelper;

should be applied throughout this repo now

There are Slevomat rules to guide all these...

There are Slevomat rules to guide all these...

ooh, looks great! Any other CS's I should be adding in alongside?

You may go

(Underscore-World) WPCS
readable PSR-12
Automattic's Neutron
Viktor's useful frankenstein
own Leon Coding Standard 👈


Slight change according to american english

This changes not required, please pick the issue having Hacktoberfest label on it  and make a valid contribution. thanks


Are there plans to implement hash join in Calcite query engine? Similar to IgniteHashJoin and HashJoinNode in ignite-3

This may be useful in some scenarios, such as joining a small table with a large table. We can use the small table as a driving table to detect records in the large table.


SecurityContextThreadLocalAccessor does not understand reactive security context

I have a webflux application that is mostly reactive but also uses some RestTemplates to synchronously fetch data.
Transferring the security context between the both is cumbersome so I want to use micrometer context-propagation to automagically synchronise the spring-security context between the threadlocal SecurityContextHolder and the reactive Context.
I remembered that spring-graphql has a class SecurityContextThreadLocalAccessor and registers it. So I added the jar as dependency and debugged a bit, optimistically expecting the synchronous and reactive security contexts to be in sync now. Found out that the SecurityContextHolder does inspect the reactive Context but does not pick up the SecurityContext cause it cannot find it. The security context sits in the reactive Context under the key org.springframework.security.core.context.SecurityContext and contains a Mono<SecurityContext>. The SecurityContextThreadLocalAccessor expects a key SecurityContext.class.getName() and a value of type SecurityContext
I now think/realize/suspect that this class was never intended to synchronize with the reactive Context, only with the graphql context. Right? But this is confusing in an application where all three types of contexts live. And it does seem a little clunky that the contexts are really quite similar but at the same time fundamentally incompatible.
I ended up writing a ThreadLocalAccessor of my own that does appear to be doing the trick
        ThreadLocalAccessor<Mono<SecurityContext>> threadLocalAccessor = new ThreadLocalAccessor<>() {
            @Override
            public @Nonnull Object key() { return SecurityContext.class; }
            @Override
            public Mono<SecurityContext> getValue() {
                return Optional.ofNullable(SecurityContextHolder.getContext()).map(Mono::just).orElse(null);
            }
            @Override
            public void setValue(@Nonnull Mono<SecurityContext> value) { value.subscribe(SecurityContextHolder::setContext); }
            @Override
            public void setValue() { SecurityContextHolder.clearContext(); }
        }

But this is exactly the type of code that I'd rather not be writing myself.
Is it okay to subscribe to the mono like this? Every time I've checked it was a MonoJust. Or will it break? I'm not trying to bum a free review of my code but want to explain that yes, it's short but it's probably also buggy and definitely nontrivial for me to write.
I think the Javadoc should explain that this class only understands the graphql context.
And I would love to find this kind of magic in one of the spring libraries. Probably spring-security.

I found https://github.com/spring-projects/spring-security/issues/13123 and comments there by people who are similarly confused.

Thanks for raising this issue. Our ThreadLocalAccessor is indeed dedicated to handling security with the GraphQL context and does not aim to support other uses cases.
I'm closing this issue as a duplicate of https://github.com/spring-projects/spring-security/issues/13123 since SecurityContextHolder belongs to Spring Security and the dedicated ThreadLocalAccessor should be colocated with that class.


staged-ledger diff-creation logs

Two levels of logging: Summary and Detail. In the detailed log, there is a line for every call to the check_constraints_and_update function and has the reason for why the block items like user commands, completed work, and/or coinbase were discarded.
Checklist:

[ ] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

Closes #0000
Closes #0000

The detailed log adds just one token to the summary log. Is it worthwhile to also have the summary log, which contains almost as much information?

Looks good. My only question is about the necessity of the CLI flag. Is this because logging the diff creation has a high cost associated with it, or is the worry that it is too noisy? If the worry is the latter, I would suggest not adding a flag and instead just making the logs be below the default log level the CLI will log (for instance, make them debug logs and they won't show up by default). This way, we can always retrieve these logs on crashes from users, and we don't need to rerun new networks with this flag enabled after we encounter something we need to debug.

Yeah the noisy bit (the cost is the same with or without the detailed logs). Also, the size of the detailed log is proportional to the transaction capacity and worst case for a block, it could have at least 2*transaction-capacity lines. Since we have a limit on the log size, this might take up considerable space? I was thinking of running a couple of our block producers with the flag on. I could turn this flag on by default and turn it back off if it is too noisy?

I could turn this flag on by default and turn it back off if it is too noisy?

I think it makes sense to turn it on by default for now, given that debug logs are hidden from users by default, and we can filter them out pretty easily in stackdriver or with logproc.


Teams: Fix team participation table sometimes missing entries

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

No Changes

Client

[x] I followed the coding and design guidelines.
No significant changes

Motivation and Context

getAssessmentLink is called with participation and/or submission having the value null, causing the errror:
TypeError: Cannot read properties of null (reading 'id')
    at rr.getAssessmentLink (team-participation-table.component.ts:138)
    ....

when a team didn't start an exercise. this then causes this and all following rows of the participation table to be skipped, making any submission among them unassessable.
The method should really never be called with null arguments in the first place, but i don't know enough about angular and how the artemis UI works to do that.
To Reproduce

create a team execise in one course
view the team details / participations page, it should list the exercise, but it doesn't
if the team belong to more than one exercise, the list may show up partially
if an exercise that requires assessment comes after en exercise that was not participated in, it will not show up and be impossible to assess

Description
Simply sets values for participation and submission so that no issues appear.

set participation to an empty object, so that the id access succeeds and returns undefined, valid input for participationId in getLinkToSubmissionAssessment.
set submission to "new", so that the link creation can continue, the generated link will likely be nonsense, but the result will not be used anyways as the assessment button will be disabled when there s no submission.

Steps for Testing

Prerequisites:

1 Instructor
1 TA
1 Student

Log in to Artemis
Reproduce the bug as above, before updating the client
see that all exercises are shown now

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Before:

After:

Thanks for providing the bugfix for this issue!
I added some improvements suggestions for the code

pretty sure the null comes from https://github.com/ls1intum/Artemis/blob/b3c13284da281cc3ee48dafcc3f03f444977ec83/src/main/webapp/app/exercises/shared/team/team-participation-table/team-participation-table.component.ts#L94 that could be changed to undefined (+ again below) but how knows what that would break

We prefer undefined over null in the client and should then also change the origin of the null value to undefined
If you use == instead of === in the checks, it will cover both, undefined and null

I know that undefined is preferred, but since the actual value passed is null (see my comment above), === undefined doesnt work and i forgot about ==.
but since i got removed from the ls1intum orga, i dont have write access to the branch anymore and cant fix it

I know that undefined is preferred, but since the actual value passed is null (see my comment above), === undefined doesnt work and i forgot about ==.
but since i got removed from the ls1intum orga, i dont have write access to the branch anymore and cant fix it

Sorry for removing you. We just cleaned up the organization and the teams. I will add you again.

in the meantime, I changed all null encounters to undefined in the component


only listen to subscription events upon successful subscribe()

This change primarily addresses the an issue of listening to correlation
id/event names that may have failed when the underlying
subscribe() call is made.  Basically, listening of correlation
id/event names happens after the underlying subscribe() call is
successful.
The logic has also been simplified for the sake of some additional O(N)
performance.  Once the code is refactored to utilize ES6 Map, the
performance concern will eliminated.
Closes #115

Updated PR with catch.

LGTM.

Addressed whitespace issue.


Investigate sensor options for Intake, Catapult, Climber position

There will be a need to know whether the Intake is extended before we are able to fire the catapult. The most basic options is that when we extend the Intake we immediately set its internal state to extended. Then we wait a certain amount of time after before allowing the catapult to fire.
Another option would be use a sensor like a limit switch or a Hall effect sensor (magnetic boolean sensor)
https://en.wikipedia.org/wiki/Hall_effect_sensor
These would allow us to sense the position of the intake so that we can get precise timing on knowing when it is extended.

Implemented climber limit switch


Focus-trap start marker doesn't work when focus is redirected to an internal element

If cdk-focus-start / -end is applied to, e.g., <md-radio-button>, the focus trap will try to focus the actual md-radio-button element. This is problematic because the radio button actually defers focus/keyboard interaction to an internal <input type="radio"> element.

@jelbourn is this an issue with the focus trap or the radio button? IMO it's a missing part of the radio button API, it should detect if someone is trying to focus it and redirect that focus appropriately.

The radio button's focus method focuses the right thing, but it doesn't do anything if you .focus() the native element. It's probably okay to set up a focus listener on the host and redirect, though.


chore: create codeql config

last current piece of:

#5

With this addition we've got all the usual boilerplate, settings, branch protection rules, etc. Only thing missing is release management/versioning and a CODEOWNERS.


Create tool to vacate drive

It would be helpful to have a tool that could be used to vacate a drive in a pool to prepare it for removal or replacement. Assuming the pool has sufficient capacity to hold the files from the target drive, the utility would redistribute the files in a similar manner to mergerfs.balance.
If there is already in-built support for this, I'm happy to hear about it.
Thanks!

I suppose a tool could be created. I've always just created a second pool which excludes the drive in question then rsync into that pool. Allows for picking the specific policy which my be necessary since you probably want to keep the existing policy while you continue to use the pool but want data spread differently when writing. That becomes far more complicated with an app since it'd need to replicate all that builtin logic. mergerfs.balance ignores the pool's policies and just rsyncs files around underneath mergerfs.

I don't know enough about how everything works, but here is one thought.
What if the vacate tool was a variant of balance that created large zero-fill temp files on the drive to be vacated which would be skipped during the balance phase. Then the cycle would look like this:

Fill drive with temp files
Balance
Return to #1 until no non-temp files remain.

One could probably do this manually, but having it all in one tool would be slick.
Maybe not the best approach, but would it work?

I really don't follow. The balance tool works independent of mergerfs outside querying it for the drives. It ignores ignores the policies the pool have completely. It's a simple way to redistribute files when you don't care at all which drive they end up on.
Vacating a drive is different. At least it always is for me. I more often than not to obey the policies. Which means I need to use mergerfs to make the decisions. That can only be done by creating another mount and moving files into it from the drive in question.
If you don't care about where files end up then changing the balance tool to use the drive as the source rather than the drive with the most used space is easy. But in my opinion so is removing the drive from the pool and running rsync.

I'm trying to find a way to do it while "online". Removing the drive from the pool effectively takes that data "offline" until the rsync is done.

That's why I said use a second pool.

Let me see if I understand:

Create pool2 excluding the drive to be removed. Both pools are active simultaneously.
Rsync from pool1 to pool2
Remove pool2
Remove drive to be removed from pool1

No. Not rsync from pool1 to pool2. Rsync from excluded drive to pool2.

This is generally documented in my extra docs.
https://github.com/trapexit/backup-and-recovery-howtos/blob/master/docs/recovery_(mergerfs).md

Thanks. I missed that because I didn't think of it as recovery.

I would like to vote for this as well.
I've read the link above and understand how to add another drive, and move data over.
I suspect to just "vacate" a drive, I would:

first remove it from the pool
second, copy/rsync the data from the drive i just removed back into the pool (to continue the use of its policy settings)
third, once copy is completed, then remove the physical drive

I think the OP's original thought would be for mergefs itself to handle this, if you remove the drive.  Like an option or flag to move all the data.
However, I also see the author's point: that mergefs is just a proxy service or sort.  And there are these tools here in this repo for more out-of-band functionality.  one could write a simple tool (and PR it here) for exactly that.  maybe mergerfs.remove or mergerfs.vacate or something.
I think it would come down to this:
If mergefs is intended to be responsible for maintenance of the pool at all, then yes this feature should be added.
But right now, reading the mergefs docs and reviewing these Tools, it would seem to be that:

mergefs is intended to be a simple proxy, perhaps to keep the code simple (it's got a lot of files already!).
And maintenance of the pool remains dedicated to these tools here in this repo.

Disclaimer: I just found out about mergefs and think it finally ticks most of the boxes I've been looking for to move off of DrivePool and back to full Linux servers again.  Especially for Plex and media.  I'm sitting on 15 or so disks and nearly 60 TB of space, largely duplicated 2x to 3x over.  I'm still reading on it but I think I am ready to take the plunge!

I'm doing it right now.
I have 3 disk of 1TB and one of 2TB.
I want to split my 2 TB disk into 2 partition of 1 TB.
What I do in a non efficient way is:

remove the disk from the pool
rsync the disk of 2 TB to the pool
repartition the disk
add back the 2 partitions to the pool

during the process a part of my data is missing.
I could have done it a bit more manually by moving the data from this disk to others also.
A tools to empty a disk from a pool to the other disks of the pool could be helpful.

The biggest thing that needs to be done to make it practical is the ability to get all options and create a list of them compatible for a mounting as the only good way to manage this behavior is to create a second, temporary pool without the drive in question and then rsync. Shouldn't be hard just needs to be done.


FI-479 Multiple Or Tests

This adds tests for multipleOr and  refactors resolve_element_from_path so we don't need can_resolve_path anymore. Tests for multipleAnd is only SHOULD's and can be added later. My strategy for multipleOr's was to look through the returned resources and look for two different values for the search param. If the second value was not found, then skip the test. I'm not sure if this is the best way so I'm open to suggestions.
Submitter:

[X] This pull request describes why these changes were made
[X] Internal ticket for this PR: https://oncprojectracking.healthit.gov/support/browse/FI-479
[X] Internal ticket links to this PR
[X] Internal ticket is properly labeled (Community/Program)
[X] Internal ticket has a justification for its Community/Program label
[X] Code diff has been reviewed for extraneous/missing code
[ ] Tests are included and test edge cases
[X] Tests/code quality metrics have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure
where appropriate, and accomplishes the task's purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure
where appropriate, and accomplishes the task's purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Can you rebase this on the most recent version of development?

Rebased to development


Check for peerSegmentDownloadScheme when reaching out to peer servers

Solves https://github.com/apache/pinot/issues/14377
Tested on internal Pinot cluster with successful resolution for realtime segments that failed to be uploaded to S3 due to the controller not able to reach the peer server to request the upload.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (9d67bcb).
Report is 1284 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (9d67bcb). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (9d67bcb)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14378       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


A javascript error in the main process

VSCode Version: 1.19.3
OS Version: Windows 10  Enterprise  2016 LTSB

Steps to Reproduce:

double  CTRL show listary search bar .

select a file and CTRL+O . select open with Code

error:

Does this issue occur when all extensions are disabled?: Yes

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Same.

Then ...

Looks like a duplicate of https://github.com/electron/electron/issues/10054 to me

it doesn't work.

As long as I do not open the file with Listary, I can use VS Code normally.