Incorrect response handling

We use kube2sky for DNS inside our K8S cluster.
It was down for some reason. but I haven't noticed that. When I created an ingress which required a certificate kube-lego did not handle the DNS problem quite well:
time="2016-12-09T17:16:54Z" level=info msg="requesting certificate for domain.foo.com" context="ingress_tls" name=https namespace="ece8168e-f5c7-4f41-9469-702f1eb2e4ec"
time="2016-12-09T17:16:54Z" level=info msg="creating new secret" context=secret name=kube-lego-account namespace="a12ddb33-13d4-43e4-9cfe-bf7e5b90935d"
time="2016-12-09T17:17:39Z" level=info msg="creating new secret" context=secret name=https namespace="ece8168e-f5c7-4f41-9469-702f1eb2e4ec"
time="2016-12-09T17:17:39Z" level=error msg="Error while process certificate requests: Secret \"https\" is invalid: [data[tls.crt]: Required value, data[tls.key]: Required value]" context=kubelego

Looks like if DNS is down kubelego fails silently and then tries to create an empty secret.

I am experiencing similar behaviour when inspecting the logs of the kube-lego container, although I am not using kube2sky, as far as I know.
I notice that the kube-lego-account is also not automatically created by kube-lego.
My current setup is:
[nrocco@metal ~]$ cat /etc/centos-release
CentOS Linux release 7.3.1611 (Core)

[nrocco@metal ~]$ kubectl version
Client Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.1", GitCommit:"82450d03cb057bab0950214ef122b67c83fb11df", GitTreeState:"clean", BuildDate:"2016-12-14T00:57:05Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.1", GitCommit:"82450d03cb057bab0950214ef122b67c83fb11df", GitTreeState:"clean", BuildDate:"2016-12-14T00:52:01Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"linux/amd64"}

I am running kubernetes on bare metal infrastructure.
In my previous setup (using kubernetes 1.4.6) kube-lego was working perfectly.
From the logs I am unable to determine if it is related to kubernetes 1.5.1 or acme, or both.

After further troubleshooting I found that the kube-lego container was not able to connect to the outside world due to missing iptables rules.
Docker was started using the flags
--iptables=false --ip-masq=false

as suggested by kubernetes.
After destroying my cluster and recreating it I can confirm that kube-lego works like a charm.
Sorry for the noise.

@nrocco thanks for letting me know. I was planning to upgrade my cluster to 1.5 this evening. If there would be a major problem with 1.5 it would be P0.
@sysradium: if you could raise the log level to debug and upload the ingress yamls somewhere it would help to dive a bit deeper on this

@simonswine I'm seeingl similary issues (note, though, that I'm new to the whole kubernetes thing so might have screwed up all sorts of things - that said, all the basic bits and pieces, except TLS, seem to work).
The logs (with debug) of the kube-lego pod say:
time="2016-12-22T15:34:13Z" level=info msg="kube-lego 0.1.3-d425b293 starting" context=kubelego
time="2016-12-22T15:34:13Z" level=info msg="connected to kubernetes api v1.5.1" context=kubelego
time="2016-12-22T15:34:13Z" level=debug msg="start watching ingress objects" context=kubelego
time="2016-12-22T15:34:13Z" level=info msg="server listening on http://:8080/" context=acme
time="2016-12-22T15:34:13Z" level=debug msg="CREATE ingress/default/knitpick-blog" context=kubelego
time="2016-12-22T15:34:13Z" level=debug msg="worker: begin processing true" context=kubelego
time="2016-12-22T15:34:13Z" level=info msg="ignoring as has no annotiation 'kubernetes.io/tls-acme'" context=ingress name=echomap namespace=default
time="2016-12-22T15:34:13Z" level=info msg="ignoring as has no annotiation 'kubernetes.io/tls-acme'" context=ingress name=kube-lego-nginx namespace=default
time="2016-12-22T15:34:13Z" level=debug msg=reset context=provider provider=gce
time="2016-12-22T15:34:13Z" level=debug msg=finialize context=provider provider=gce
time="2016-12-22T15:34:13Z" level=debug msg=reset context=provider provider=nginx
time="2016-12-22T15:34:13Z" level=debug msg=finialize context=provider provider=nginx
time="2016-12-22T15:34:13Z" level=info msg="process certificates requests for ingresses" context=kubelego
time="2016-12-22T15:34:13Z" level=info msg="creating new secret" context=secret name=knitpick-tls namespace=default
time="2016-12-22T15:34:13Z" level=info msg="no cert associated with ingress" context="ingress_tls" name=knitpick-blog namespace=default
time="2016-12-22T15:34:13Z" level=info msg="requesting certificate for knitpick.me,www.knitpick.me" context="ingress_tls" name=knitpick-blog namespace=default
time="2016-12-22T15:34:13Z" level=info msg="creating new secret" context=secret name=kube-lego-account namespace=default
time="2016-12-22T15:34:33Z" level=info msg="creating new secret" context=secret name=knitpick-tls namespace=default
time="2016-12-22T15:34:33Z" level=error msg="Error while process certificate requests: Secret \"knitpick-tls\" is invalid: [data[tls.crt]: Required value, data[tls.key]: Required value]" context=kubelego

The ingress yaml is:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: knitpick-blog
  annotations:
    kubernetes.io/tls-acme: "true"
    kubernetes.io/ingress.class: nginx

spec:
  tls:
    - secretName: knitpick-tls
      hosts:
        - knitpick.me
        - www.knitpick.me

  rules:
    - host: knitpick.me
      http:
        paths:
          - path: /
            backend:
              serviceName: knitpick-blog
              servicePort: 80

    - host: www.knitpick.me
      http:
        paths:
          - path: /
            backend:
              serviceName: knitpick-blog
              servicePort: 80

The only thing I've changed from the example lego deployment is that I've changed it to use the default namespace (instead of creating its own), changed the email, and changed the URL to use the staging API (that said, I also tried the production API but it didn't change a thing).
Also note that verification here would fail, as the actual domain names still point elsewhere - but: it's not even getting there - I don't see any challenge requests on the actual webserver for those domains.
Any ideas?

Ok, that was an embarrassing pilot error - networking was somewhat messed up.
However, it really doesn't help that, when kube-lego can't connect to the outside world it instead gives some random message about not being able to create an (empty?) secret.

Yeah, I guess it shouldn't even try to :)
@simonswine sorry don't have the logs nearby, but I think @bwalex explained the problem enough for you to find the bad place :) I guess it isn't that far away.
I wanted to fix that myself if the problem comes back but it never tit 😁

I have the same error
time="2016-12-09T17:17:39Z" level=error msg="Error while process certificate requests: Secret \"https\" is invalid: [data[tls.crt]: Required value, data[tls.key]: Required value]" context=kubelego

And actually can not see how to test the connectivity of the container because kubectl exec doesn't work with lego pod.
Any advice?

I'm getting exactly the same error as @whitecolor

I am also getting the same issue.  As far as I can see, the secret being created stores the certificate with the ca.crt key, and not tls.crt.  And there is no tls.key (or ca.key) anywhere in the secret.

For people who find this in the future, this is often b/c your KUBE_URL or KUBE_EMAIL variables in the helm chart are wrong.

@brendandburns Do you have any suggestions for how to diagnose that? How would you find that it was related to KUBE_URL and KUBE_EMAIL?


How to build IPA files without storing archivefiles in disk?

Just curious, how to build this IPA file without saving big archieved files?
It's large, we want to avoid saving it.

not sure if it is possible - or atleast if its an easy one, to build ipa without having xcarchive, could'nt you just empty the archive folder, after gym
we do it on the ci machines with:
FileUtils.rm_rf "~Library/Developer/Xcode/Archives/*"

Hi @jacobjiangwei right now it's not possible. I think @hjanuschka suggestion is a great one! Hope you have a great weekend coming up 👍


Using attr() for custom file input content

Currently the .file-custom class uses a pseudo-element for setting the "Choose file..." string. Instead of hardcoding that string in the styles, we could instead defer to the markup by using the attr() function.

  <input type="file" id="file">

could become:

  <input type="file" id="file">

with css like this:
.file-custom:after {
  content: attr(data-content-value);
}

As noted in the existing v4 documentation, there is no way to dynamically update that string without using javascript. However, even with javascript it's not easy to update the content value of the pseudo element. By moving the value to the markup, it's much easier to make changes using javascript.
The attr function seems to be well supported. If there is a different attribute other than data-content-value, that'd be fine too.
I'd be happy to make a pull request, just let me know.

I'm following the above method and it is working like charm. With pSeudo element we can't do much. Please do change design.
+1

@psoots solution is working like a charm.
I just add data-content-value to the span :

    <input type="file" id="form_profilePicture" name="form[profilePicture]">

Then I change the .file-custom::after into _custom-forms.scss like this :
.file-custom::after {
    content: attr(data-content-value);
}

And then, I just add these jQuery lines to make it work with all the input[type="file"] on the page :
$('input[type="file"]').on('change', function() {
    $(this).next('.file-custom').attr('data-content-value', $(this)[0].files[0].name);
});

Thanks @psoots for this little solution that is working like a charm :+1:

For Bootstrap 4 Alpha 3, the markup has been changed:
For the HTML, it is now:

  <input type="file" name="upload" class="custom-file-input" />

For the CSS:
.custom-file-control:lang(en)::after {
  content: attr(data-content-value);
}

For JS:
$('input[type="file"]').on('change', function() {
    $(this).next('.custom-file-control').attr('data-content-value', $(this)[0].files[0].name);
});

For me I had to change slightly the JS to make the above solution work:
$(document).on('change', 'input[type="file"]', function() {     $(this).next('.custom-file-control').attr('data-content-value', $(this)[0].files[0].name); });

Here's one solution in React + JSX (using the CSS above from @pinglamb ):

  <input
    type="file"
    className="custom-file-input"
    ref={(input) => this.fileInput = input}
    onChange={() => {

      // files.length is 0 if no file was chosen.
      const files = this.fileInput.files

      this.setState({
        chosenFileName: files.length ? files[0].name : null
      })
    }}
  />

Closing as duplicate of #20813 given that issue has more activity around it.


Remove .idea folder

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage     98.36%   98.36%
  Complexity       27       27
=========================================
  Files             3        3
  Lines            61       61
  Branches          4        4
=========================================
  Hits             60       60
  Partials          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319c109...fc333b2. Read the comment docs.


Enter the pre-oprational state

Hi!After startup, my device runs in the pre-operational state, and the NMT host controls me into the operational state. However, after running for a period of time, my device has entered the pre-operational state. I don't know why. What are the general conditions that will lead to pre-operational?
My NMT_CONTROL  Settings：
#define NMT_CONTROL  CO_ERR_REG_GENERIC_ERR \
                    | CO_ERR_REG_COMMUNICATION \

If error register is set, device enters pre-operational. See Emergency.

If error register is set, device enters pre-operational. See Emergency.

In the code, I only observed that the error register caused the system to enter the pre-operational state. However, when initializing CANopen and defining NMT_CONTROL, I did not enable CO_NMT_ERR_ON_BUSOFF_HB and CO_NMT_ERR_ON_ERR_REG.
/* verify NMT transitions based on error register */
    bool_t busOff_HB = (NMT->NMTcontrol & CO_NMT_ERR_ON_BUSOFF_HB) != 0
                    && (CO_isError(NMT->em, CO_EM_CAN_TX_BUS_OFF)
                        || CO_isError(NMT->em, CO_EM_HEARTBEAT_CONSUMER)
                        || CO_isError(NMT->em, CO_EM_HB_CONSUMER_REMOTE_RESET));
    bool_t errRegMasked = (NMT->NMTcontrol & CO_NMT_ERR_ON_ERR_REG) != 0
                    && (CO_getErrorRegister(NMT->em) & NMT->NMTcontrol) != 0;

    if (NMTstateCpy == CO_NMT_OPERATIONAL && (busOff_HB || errRegMasked)) {
        NMTstateCpy = (NMT->NMTcontrol & CO_NMT_ERR_TO_STOPPED) != 0
                    ? CO_NMT_STOPPED : CO_NMT_PRE_OPERATIONAL;
    }
    else if ((NMT->NMTcontrol & CO_NMT_ERR_FREE_TO_OPERATIONAL) != 0
        && NMTstateCpy == CO_NMT_PRE_OPERATIONAL && !busOff_HB && !errRegMasked
    ) {
        NMTstateCpy = CO_NMT_OPERATIONAL;
    }

There should be always emergency message when error register is set. See also object 0x1003 and candump. What is the reason for entering pre-operational?

There should be always emergency message when error register is set. See also object 0x1003 and candump. What is the reason for entering pre-operational?

The object 0x1003 is not enabled in my OD file.


[mDNS] Add commission advertiser

Problem
Commission device advertisement is missing from the current advertiser.
Summary of Changes

Add commission device support in Advertiser
Use mac address as the hostname, which is recommended in the spec.

Already in https://github.com/project-chip/connectedhomeip/pull/4200

Already in https://github.com/project-chip/connectedhomeip/pull/4200


ui: Show the window without focusing

This is a requested feature. https://github.com/glfw/glfw/issues/1189 This feature was introduced at GLFW 3.3.

+1 for this
please add it

I'm thinking the API. SetWindowInitialFocused?

As Run has been newly introduced and not in the stable version, we might change the Run API to take some options.

https://www.glfw.org/docs/latest/window_guide.html#GLFW_FOCUS_ON_SHOW_hint

https://github.com/go-gl/glfw/issues/267 The current blocker

hi @hajimehoshi,
forgive me, I am not a glfw master...
has this something to do with https://docs.microsoft.com/en-us/windows/win32/winmsg/extended-window-styles (ext style WS_EX_TOPMOST)?

This might take a little long time to investigate. Let me postpone this to the next milestone.

has this something to do with https://docs.microsoft.com/en-us/windows/win32/winmsg/extended-window-styles (ext style WS_EX_TOPMOST)?

Thanks. The hardest part of investigating is to compile this in C on Windows, and I've not succeeded yet. Your finding might help in the future, thanks.

Hi, thanks, this is still a topic for me and I still have no solution. Maybe we can solve this with a simple dll call to own window?
Thanks for all your work.


style(ClauseHeader): changed header background - I322

Signed-off-by: elit-altum<EMAIL_ADDRESS>Issue #322
Changes

Changes the ClauseHeader background gradient from #ECF0FA to #F9FBFF

Related Issues

Issue #322

@irmerk Please review!


Create new message from client -> server on unit select

It's necessary, if you want to check on server, if selection correct.
And you want to output fields to move to.

https://github.com/Miol-Mor/battle-game/pull/127


Default auth mode is not set to "server"

Summary
After updating Argo Workflow from v3.0 to v3.1-rc7, we were experiencing "token not valid for running mode" error when accessing argo-server's Web UI. This error always redirected us to Login page.
Although the following document indicates the default auth mode is set to server, it seems like the default auth mode is set to client and this behavior was causing the error.
https://github.com/argoproj/argo-workflows/blob/v3.1.0-rc8/docs/argo-server-auth-mode.md
After explicitly setting the --auth-mode to server in the manifest, the auth mode is set to server and works without error. (NOTE: we were also setting --secure=false option to disable TLS)
# Snippet of the argo-server manifest
    spec:
      containers:
      - name: argo-server
        image: docker.io/argoproj/argocli:v3.1.0-rc8
        args:
        - server
        - "--secure=false"
        # Need to add auth-mode setting explicitly.
        - "--auth-mode=server"

If the document is correct, default auth mode must be set to server when --auth-mode option isn't set.
Diagnostics
What Kubernetes provider are you using?
-> Kubernetes v1.16
What version of Argo Workflows are you running?
-> Argo Workflow v3.1.0-rc7, v3.1.0-rc8
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
-> K8sAPI
Did this work in a previous version? I.e. is it a regression?
-> Worked as expected in Argo Workflow v3.0.2. Possible regression.
argo-server's startup log: Without --auth-mode option, authModes is set to ["client"].
level=info authModes="[client]" baseHRef=/ managedNamespace= namespace=argo secure=false
level=warning msg="You are running in insecure mode. Learn how to enable transport layer security: https://argoproj.github.io/argo-workflows/tls/"                                                                   level=info msg="config map" name=workflow-controller-configmap
level=info msg="SSO disabled"
level=info msg="Starting Argo Server" instanceID= version=v3.1.0-rc8
level=info msg="Creating DB session"
level=info msg="Node status offloading config" ttl=5m0s
level=info msg="Creating event controller" operationQueueSize=16 workerCount=4
level=info msg="Argo Server started successfully on http://localhost:2746"

argo-server's error log:
level=info msg="finished unary call with code Unauthenticated" error="rpc error: code = Unauthenticated desc = token not valid for running mode" grpc.code=Unauthenticated grpc.method=GetInfo grpc.service=info.InfoService grpc.start_time="2021-05-25T06:57:04Z" grpc.time_ms=0.114 span.kind=server system=grp

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

You are correct. As of a security audit in v3, the default auth-mode was changed to client. You'll need to override it to use server mode.

@alexec
Thanks for the reply.
I still think it's a bug because default auth mode is different even in v3 and no document refers to it.

v3.0.x: Default auth mode is set to server.  (Tested with latest v3.0.7)
v3.1.x: Default auth mode is set to client.

Both codes and documents must be fixed according to Argo Workflows' v3 decision. And if the default mode has been changed to client in v3, it would be nice to note this as breaking changes like TLS.

Hey @alexec, if you have time can you sometimes fix, documentation? By default, the server will start with auth mode of "server". https://github.com/argoproj/argo-workflows/blob/4e450e250168e6b4d51a126b784e90b11a0162bc/docs/argo-server-auth-mode.md


Change multilingual detection

Use vocal size to detect if model is multi-lingual.

I would rather keep the current logic rather than rely on the vocab size even if the python version does this. It seems less likely to create issues if at some point new tokenizer are supported.

I would rather keep the current logic rather than rely on the vocab size even if the python version does this. It seems less likely to create issues if at some point new tokenizer are supported.

Totally get where you're coming from. Go ahead and close the PR if you'd like, and continue the great work!

Thanks for your understanding, also don't hesitate to start some discussions on the discord for that kind of thing, might be easier to get feedback/suggestions than through PR comments.


build: update react-native-permissions

Description
Updates react-native-permissions to 3.9.3. Which supports new RN arch.
Seems to reduce likelyhood of [no permission handler detected] error.
Type of change

[x] Refactoring (improving code without creating new functionality)

Tests

[x] No test

QA Notes
Built with Cocoapods and Xcode 15.0 for latest iOS 17.0.3 release on iPhone 13 Pro Max.

Thanks for the PR!


Omit settings page on install

Is there a way that we can omit showing the settings page upon install? If so, it may be a good idea to do it. There is probably not that much use anyways for showing that page as most users are probably not interested in changing the settings at that point.
Is the current default upon install "send GPC signal to all pages"? If not, let's change it to that (assuming that we are no longer showing the settings page upon install).

It is definitely possible to omit the settings page. However, would we like to also get rid of the tutorial? (Issue #267) If so, it would be easier to omit the settings page after this change has been made. I will tag and assign @sophieeng as this might be a good issue for us to discuss.

Yes, getting rid of both is the preferable solution in my mind.

Correct!

so this means no button that will pop up the tutorial, correct

I mean, just to clarify, there should be some UI element in the popup (button, link, ...) to bring up the tutorial and the settings. Just, the tutorial and settings should not pop up automatically upon install (or any other action except the user clicking the button, link, ...).

I have removed the code that opened the Options page on install. It will not pop up anymore on its own.
@SebastianZimmeck mentions setting the default to "send GPC to all pages" in this issue. If that is still for this issue I can try to take care of it.

@SebastianZimmeck mentions setting the default to "send GPC to all pages" in this issue

Yes, that would be great, @sophieeng!

GPC already does automatically send to all web pages, as confirmed by @OliverWang13.

Great! Then, nothing to do in that regard.

Both instances of code causing the Options page to appear on install were removed and merged to main. I am closing the issue.


Support messaging with the offscreen page

The offscreen page’s __getTabData call was throwing an error, causing the correct receiver to fail in responding with the right tabData.
The offscreen page, similar to the background service worker, lacks a tab, which this library did not handle correctly.

Notes:
See change that was reverted due to this bug: https://github.com/pixiebrix/pixiebrix-extension/commit/2021198cba9b4497afeb2db17d741cbf641a8326
Action item from: https://www.notion.so/pixiebrix/Postmortem-Release-2-1-6-13543b21a253809bab4cd2aace909433?pvs=4

Related: https://github.com/fregante/webext-detect/pull/32

I added support for offscreen document detection to webext-detect:

https://github.com/fregante/webext-detect/pull/32

As mentioned in an email to Todd, the messenger was likely failing because the offscreen document was not being properly detected. Also this line needs isBackground() || isOffscreenDocument()


+Online instead of +Clone Button

Hello,
the tutorial "Moving package into git" tells me to click the +Clone button. But i have a +Online button and it opens a different popup.
Please see screenshot.
What can i do to move a package into git?
Thanks
Frank

You have to click the +Online button. Apply an url to an online git repo (e. g. https://github.com/larshp/abapgit.git) and a package like the tutorial states.
We should update it though.

pull requests welcome to file https://github.com/larshp/abapGit/blob/master/docs/guide-moving-package.md


rewrite simulation section

@brandmaier please note that this is a WIP, I'll continue tomorrow.

OK, Pleaser merge.


fix: issue with proxy support and estimate_gas_cost

What I did
fixes: #16
fixes: #8

[ ] Required an Ape release!

How I did it
Make an ExplorerAPI to handle getting contact types so we can handle proxies this way (Feature not yet released)
How to verify it

You are not able to pay fees without specifying max_fee and interact with proxy contracts (e.g. checking your argentx balance)

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

failing tests because we need an ape release

failing tests because we need an ape release

Ape is released! Can retrigger?


Cannot perform minimal update on drugbank

Describe the bug
Cannot perform minimal update after reading the docs
To Reproduce
Steps to reproduce the behavior:

Install Neo4j desktop
Add dump from https://data.mendeley.com/datasets/mrcf7f4tc2/3 in neo4j
Setup database from dump with Neo4j version 4.2.3
Clone repo via git clone
Unzip data.zip from https://data.mendeley.com/datasets/mrcf7f4tc2/3 in "CKG\data"
Add DrugBase Full Database "full database.xml" in "CKG\data\databases\DrugBank"
Change connector configs (username and password)
Create conda environment
python setup.py install
Navigate into CKG\ckg\graphdb_builder\builder
python builder.py -b minimal -u username -n 1

Expected behavior
Creation of drug nodes and links in the database
Results*
Errors like:
Connection error:{code: Neo.ClientError.Schema.EquivalentSchemaRuleAlreadyExists} {message: An equivalent constraint already exists, 'Constraint( id=2, name='constraint_6f637020', type='UNIQUENESS', schema=(:Disease {id}), ownedIndex=1 )'.}.
(<class 'neo4j.exceptions.ClientError'>, ClientError("An equivalent constraint already exists, 'Constraint( id=2, name='constraint_6f637020', type='UNIQUENESS', schema=(:Disease {id}), ownedIndex=1 )'."), <traceback object at 0x000001A202313D48>), file: connector.py,line: 99
Connection error:{code: Neo.ClientError.Schema.EquivalentSchemaRuleAlreadyExists} {message: An equivalent index already exists, 'Index( id=3, name='index_662b2000', type='GENERAL BTREE', schema=(:Disease {name}), indexProvider='native-btree-1.0' )'.}.
(<class 'neo4j.exceptions.ClientError'>, ClientError("An equivalent index already exists, 'Index( id=3, name='index_662b2000', type='GENERAL BTREE', schema=(:Disease {name}), indexProvider='native-btree-1.0' )'."), <traceback object at 0x000001A202430688>), file: connector.py,line: 99
Connection error:{code: Neo.ClientError.Schema.EquivalentSchemaRuleAlreadyExists} {message: An equivalent constraint already exists, 'Constraint( id=5, name='constraint_80dda1d2', type='UNIQUENESS', schema=(:Tissue {id}), ownedIndex=4 )'.}.
(<class 'neo4j.exceptions.ClientError'>, ClientError("An equivalent constraint already exists, 'Constraint( id=5, name='constraint_80dda1d2', type='UNIQUENESS', schema=(:Tissue {id}), ownedIndex=4 )'."), <traceback object at 0x000001A202366708>), file: connector.py,line: 99
Connection error:{code: Neo.ClientError.Schema.EquivalentSchemaRuleAlreadyExists} {message: An equivalent index already exists, 'Index( id=6, name='index_846155cf', type='GENERAL BTREE', schema=(:Tissue {name}), indexProvider='native-btree-1.0' )'.}.
Screenshots

Desktop (please complete the following information):

OS: Windows10

I get the same error.
But I think it builds normally (I can see the drug nodes in the graph after the minimal update)
at some point neo4j changed dealing with the constraint uniqueness. I believe this is the cause of the warning message but I am not fully sure.

Thanks, I found the error and i added on all occurrences the "IF NOT EXISTS" to index and constraint creations. Nevertheless, the underyling issue why drugs were not updated were due to the fact that my neo4j db did not allow updates from resources outside of the "import" directory, which I already fixed now


Remediate North Carolina Transform Script

Problem
We have recently updated our transform python script framework to
make it easier to use and has far less boiler plate code. We need to migrate
the existing North Carolina script to this new framework.
Tasks

[ ] Create a 1,000 record sample file and share in the dropbox folder. Ideally
use resevoir sampling step from Kettle a'la src/main/pdi/NewYork/SampleNewYork.ktr
[ ] Create the correct initializer code in
src/python/national_voter_file/us_states/nc/transfomer.py.
You can use state_transformer_template.py or the Florida transformer for guidance
[ ] We now have new handling for Unparsable USAddresses. Make sure the extract_registration_address
populates RAW_ADDR1, RAW_ADDR2, RAW_ZIP, and RAW_CITY. With uncleansed data straight
from the voter file. If you are able to correcly parse the address with  USAddress
parser then set VALIDATION_STATUS to 2. Set VALIDATION_STATUS to 1 if the parser fails
and leave the Registration data fields set to None
[ ] delete prepare.py
[ ] Test out your transformer using the sample data file and review the results.
[ ] Update the test method in test_transformers.py and run the full nosetests

Closed by commit 2a6c836


Dark/light mode is out of container

I want to fix Dark/light mode bar because is out of container.

@Anjalee01 this issue was solved earlier, so i am closing this issue.


[Navbar] Remove depreciated navbar-light variant and adjust by the new color scheme settings

The Navbar light variant has been depreciated as of 5.2.0.
Navbar color variants are set by the applying bg utility classes.
Dark variant is set by adding data-bs-theme="dark" attribute.
https://getbootstrap.com/docs/5.3/components/navbar/#how-it-works
I guess we are about to abbandon the ColorScheme settings.

@crdo Do we want this to be in v4.0.0 or earlier minor release? (I just created a separate milestote v4.0.0, so use it if appropriate.)

Removed the ColorScheme parameter
Added the Theme parameter with BootstrapTheme enum (Light and Dark currently supported)
Adjusted the documentation
We do not have strong-type support for .bg-*-subtle and .bg-body-* classes


Minor update to bump up dependency on secp256k1.swift

Test are passing

@anquii Sorry, I should have gone into more detail: The latest version of secp256k1.swift now supports the combine operation, which I rely on for a different project. I set the version flag in the commit to .exactly be 0.14.0 to avoid having to update the repo for every minor change. Thanks for your consideration and especially for the work you put into this implementation, it's super useful!

@anquii Sorry, I should have gone into more detail: The latest version of secp256k1.swift now supports the combine operation, which I rely on for a different project. I set the version flag in the commit to .exactly be 0.14.0 to avoid having to update the repo for every minor change. Thanks for your consideration and especially for the work you put into this implementation, it's super useful!

i see, thx for contributing.
i've released it as v1.1.2.


Propagate PKGBUILD:depends changes to aur-depends.

I've noticed a small issue with dependency resolution on locally modified PKGBUILD.

Any modification in PKGBUILD:depends won't get reflected in aur-depends script.

For example ruby-travis has to be build against ruby-highline-1.6 but depends gave the versioned dependency ( depends=('ruby-highline>=1.6.0' 'ruby-highline<2.0.0')) which gets resolved as ruby-highline. Updating PKGBUILD:depends to include ruby-highline-1.6 isn't propagated to dependency resolve.

aur-depends doesn't use PKGBUILD in any way, it uses whatever is available on the AUR interface. If you want to resolve dependencies for local PKGBUILDs, generate .SRCINFO first and use aur-graph + tsort.

It's strange that aur rcp service doesn't resolve dependency version, aurweb clearly shows this :thinking:

https://lists.archlinux.org/pipermail/aur-dev/2018-June/004544.html
It's almost a year now so I don't expect it to ever be implemented in the API (nor do I have any knowledge of PHP to implement it myself).


Template boilerplate broken

Describe the bug
Template tooling is broken
To Reproduce

Expected behavior
I expect to be given something besides an error message - most probably hit one of the Get endpoints or similar

Windows Version: 11
Visual Studio Version: 16.11.7
AWS Toolkit for Visual Studio Version: <IP_ADDRESS>

Additional context
I am new to the whole AWS thing and I am trying to set up an API endpoint to deploy to a lambda. It would be nice if the tooling would work so I could follow along and learn how to do this.

Hi @lxman are you trying to follow along with a tutorial or video, and if so can you please share a link to the content?


Refine Build/Release process for all components

Please verify the version of wc-generator you have installed
No response
Please describe the work
All Auro repositories need to follow a consistent build and release process. Currently, this process is slightly different from one component to the next.
Task Breakdown

[x] Outline current build/release process
[ ] Determine what the ideal build/release process

Thoughts and opinions
Overall this process is okay but it glosses over the fact that there's almost a dozen build and build:* scripts in the package json that are all very important for each component. This is really hard to understand for me as a new-ish engineer to the Auro space, and seems fairly unmaintainable moving forward.
There's a couple instances of duplicated efforts/processing but overall it's not too bad. The BIGGEST issue I see here is the conditional check for merging to main is only ever run once on main by default. This could cause major headaches managing large changes since there could be many things that remain uncaught until they're already in main.
Finally, the convention in almost every JavaScript packages these days is to have maybe 5 scripts a developer should care about. Again following convention, these are dev, serve/start (for production mode locally), build, test, and lint - optionally a sixth could be typecheck if TypeScript is present and a separate check is desired. Having multiple build scripts can create confusion since a new developer doesn't immediately know which one they need to care about.
Proposals

Borealis uses wireit tool to run workflows that have dependencies on multiple package json scripts - https://github.com/google/wireit
Leverage upcoming changes to auro-library to seed repositories with "macro" style scripts that automatically handle build steps like generating documentation somehow

Exit criteria
No response

I was recently looking at the new Deno 2.0 release (created by Ryan Dahl, the creator of Node.js), which comes out of the box with
https://docs.deno.com/runtime/getting_started/command_line_interface/
https://www.youtube.com/watch?v=sgXr6iGT71Y

TypeScript support out of the box (deno run bypasses the need for a tsconfig)
lint subcommand (replace ESLint, etc)
format - replaces Prettier, etc
Backwards compatibility with NPM/package.json and monorepos (NPM Workspaces)
Has its own registry, JSR
Stable standard library: https://jsr.io/@std (replaces the need for Jest, Chalk, Lodash, to name a few)

I was recently looking at the new Deno 2.0 release (created by Ryan Dahl, the creator of Node.js):
https://docs.deno.com/runtime/getting_started/command_line_interface/
https://www.youtube.com/watch?v=sgXr6iGT71Y

TypeScript support out of the box (deno run bypasses the need for a tsconfig)
lint subcommand (replace ESLint, etc)
format - replaces Prettier, etc
Backwards compatibility with NPM/package.json and monorepos (NPM Workspaces)
Has its own registry, JSR
Stable standard library: https://jsr.io/@std (replaces the need for Jest, Chalk, Lodash, to name a few)

Test comment


Add an option to force lines to use the custom drawing method

Is your feature request related to a problem? Please describe.
When a line has a width of one, it uses GL_LINE to draw, which draws only individual pixels which would normally be fine. But if you have a scatter where it has zoomed in, the line is still just one pixel when it should be thicker.
Describe the solution you'd like
I would like a setting that forces the use of the custom drawing method.
Describe alternatives you've considered
You could also check whether the line has been transformed or scaled, though that may be more difficult. I could also change the width be not one but then it wouldn't be correct, this could also be problematic if zoomed in a high amount as there are only so many decimal spaces on the width before it rounds it too 1.
Additional context

From the kivy doc:

Closed via #8228


update package if packagedeployment revision changes

This builds off of https://github.com/nephio-project/nephio-controller-poc/pull/4 and should be merged after that one is merged and this is rebased.
Implements updating the downstream package if an upstream update if the revision in the PackageDeployment's package revision ref changes.

If there is a downstream draft, the draft gets updated.
If there is no downstream draft, then the latest published package gets copied to a draft, and the copy gets updated.

The update can be an upgrade or a downgrade.

Awesome. Looking forward to trying it out.


Allow cancelling programmatic scroll by user

It might be something only programmers can feel annoyed about but quite often when a scroll animation is running I'd like to cancel it and scroll the other way around.
A simple but effective method that should work in all modern browsers is to stop the smooth-scroll when the wheel or touchstart event is triggered.
Semi-real code(could be written more compact):
var cancelEvents  = ['wheel', 'touchstart'];
var userstopEvent = new Event('smoothscroll_userstop');

function applyEventFunctionToAll(func) {
	var i;
	for (i=0; i<cancelEvents.length;i++) {
		func('on' + cancelEvents[i]);
	}
}

function userStopAnimateScroll() {
	window.dispatchEvent(userstopEvent);
	stopAnimateScroll();
	applyEventFunctionToAll(removeCancelListener);
}

function removeCancelListener(eventName) {
	window.removeEventListener(eventName, userStopAnimateScroll);
}

function addCancelListener(eventName) {
	window.addEventListener(eventName, userStopAnimateScroll);
}

if (allowUserStopAnimationScroll === true) {
	applyEventFunctionToAll(addCancelListener);
}

My code does not handle anything like scrollers inside anything other than window. Mostly because I have no clue if it should.
And maybe it does not need to be in there core but it would be nice to be able to add this functionality with the "api".

Hey there... to be frank, I'm not sure the utility here is worth the added code bloat. This feels like a feature that doesn't serve much purpose for the average user.
Feel free to fork and modify the code as desired, though.

Hello, I also wanted to raise a ticket regarding this issue, I think having this will avoid the "jank" that currently exists when you attempt to scroll against the animation, I think this is relevant to many users.

Reopening for discussion.
With an approach like this, what happens when someone accidentally clicks or moves the scroll wheel while the animation is in place? Wouldn't this leave them "stranded" on the page somewhere other than where they intended to go?
Or is the idea that if the users clicks/scroll while the animation is in progress, they automatically jump to the anchored location?

A user interacting with the scroll wheel wants to scroll their window regardless of the current state of the animation. Ideally the animation should end and control returned as soon as the user attempts to scroll themselves.
Basically if the user uses their mouse wheel then the animation should end exactly at that time so that full control of the scroll is resumed.
At the moment you are fighting against the animation if you change your mind and attempt to scroll during the animation.

This seems counterintuitive to how a normal anchor link would work. You click the link, you're jumped down to that spot. If you change your mind, well... you're at the anchored location.

A standard local anchor is an instant interaction though. When animating scroll it is poor user experience to force the user to wait for the entire duration (and it looks really janky)

Fair points. In your opinion, what are appropriate events on which to cancel the animation? Scroll events obviously come to mind, but what else? Click? etc.

mousedown wheel DOMMouseScroll mousewheel keyup touchstart - I wouldn't bind to scroll as that event cannot always be explicitly linked to a user interaction.

Mousedown might throw off my dad who's one of the billion people that tends to double click buttons because (windows) explorer works like that.
Touch devices never(?) had double tap for opening so it should be less of an issue there.
Although I'm convinced this change is an improvement we can never be sure it suits everybody's needs. So it's good you didn't implement it right after my comment :) Some user testing would also be nice.

I think it's a really good idea and it's standard practice for me to implement in my projects, yes it shouldn't be bound to click, I highly recommend just the events I mentioned in my last comment.

I'd like to do a bit more research on best practices and user expectations before I make any changes here, but I am open to this as a feature.

Awesome. I forked this code into my current project and added a quick cancel function using '''function cancelScroll() {
var currentLocation = root.pageYOffset;
  stopAnimateScroll(currentLocation, currentLocation, animationInterval);
}'''

Not ideal but works for now, would love to see a proper implementation

Just adding my support for this feature. Scrolling is a very basic, "low-level" user interaction. Any time a user tries to do something that "always works" — like scrolling — and the ui doesn't respond to their input, it's bad UX. I would compare it to preventing a user from switching tabs or closing their browser. It doesn't matter if the user initiated a scroll animation, maybe they did it by accident, or they see content that they want as it scrolls by.
Thanks for a fantastic script otherwise!

I'm still struggling with what user actions should cancel the interaction. I do want to implement this though.

There's definitely some nuance to that question. I'd say you couldn't go wrong cancelling on scroll wheel and touch events at least. If there's some way to detect interactions with the scrollbar that would also be good (but I'm not sure how you'd go about that.) Keyboard events and mouse clicks get a bit trickier. One option would be to make this configurable? Then if a dev needs to cancel scrolling on some keyup event they'd be able to. Or maybe expose a cancel method that would be bound to arbitrary events?

You could also bypass this question entirely by checking that the scroll position hasn't changed before each time you run your animation loop. If it has changed, it means that something other than this script impacted the scroll position, implying that the user is trying to scroll the page somehow.

Something like this maybe:
var previousLocation = root.pageYOffset;

var loopAnimateScroll = function () {
  var currentLocation = root.pageYOffset;
  if(previousLocation !== currentLocation) {
    endLocation = currentLocation;
    stopAnimateScroll(position, endLocation, animationInterval);
  }
  timeLapsed += 16;
  percentage = ( timeLapsed / parseInt(animateSettings.speed, 10) );
  percentage = ( percentage > 1 ) ? 1 : percentage;
  position = startLocation + ( distance * easingPattern(animateSettings.easing, percentage) );
  root.scrollTo( 0, Math.floor(position) );
  stopAnimateScroll(position, endLocation, animationInterval);
  previousLocation = root.pageYOffset;
};

@NonesuchStudios Not necessarily:

Edit: Just clearing the interval without adjusting focus or firing the callback make sense in this case, since the scroll didn't actually finish.

If they're half-way through a scroll, shouldn't focus be on where they are?
I'm going to consult with a few of my a11y friends on this.

Interesting point. I would think that since screen readers jump through content in discrete steps it might be less disorienting to stay where you were when the canceled scroll was initiated. I'm far from an expert on these things though, I'd be curious to hear what your friends say!

This script is hands-down my favorite scrolling plugin out there, and definitely handles the technological aspects of being accessibility-friendly—my concerns for this issue are more on the cognitive end of things:

An interrupt would be disruptive if visual position didn't match programmatic focus. Not all screenreader users are blind, so that discrepancy could get very confusing very fast.
For less technologically savvy users, a scroll cancel could leave them confused since the intended destination isn't navigated to. I'm especially thinking in terms of motor disabilities or accidental scrolling (say Parkinson's, surprise cat on the trackpad, a janky mousewheel, etc.).

However, a cancel effect would be very handy for tall pages where there's been accidental triggering. Part of me is wondering if there's a threshhold you could set for preventing accidental cancellation, and part of me is thinking that catering to advanced users creates more problems than it solves?
Sorry I don't have a more concrete answer for you.

No apologies necessary @ericwbailey.  You hit on most of my major concerns. There's a strong part of me that also feels like as long as the scrolling speed is reasonably fast – say 300 ms or so – then canceling the action hurts more than it helps.

Definitely good points! Given these concerns, my vote would be to add this as an option.
I call animateScroll with a pixel value rather than a selector quite often. When it's used that way there are myriad situations where you'd want to make sure the scroll was interruptible and leave focus untouched.

So, things that one should consider concerning smooth scroll in general:
This is a feature for sighted users.  As far as my testing of features like this go for keyboard users and especially for users of assistive technology, they (generally) do not care for features like this, as they are typically trying to navigate pages as quickly as possible (using keyboards & menus to navigate a site is far slower than a mouse click, so many of these users have gotten quite adept at trying to move through UIs as quickly as possible).  Smooth scrolling is in opposition to that.
But regardless of whether this is a feature for them or not, one must keep focus management in mind with scripts like this, as it could be used by all people.
As @ericwbailey said:

An interrupt would be disruptive if visual position didn't match programmatic focus. Not all screenreader users are blind, so that discrepancy could get very confusing very fast.
For less technologically savvy users, a scroll cancel could leave them confused since the intended destination isn't navigated to. I'm especially thinking in terms of motor disabilities or accidental scrolling (say Parkinson's, surprise cat on the trackpad, a janky mousewheel, etc.).

What we have to keep in mind here, is that if there is a cancel of the smooth scroll, what happens to focus management?  Does it still get pushed to the location it should have been?  That seems silly since the action was interrupted.  Should it be reset to the original trigger?  This makes more sense to me...but still seems like a less than ideal solution.  Do we find the first focuable element in the current view port and just attach focus to that?  That...sorta makes sense, but what if there are no focusable elements in the view port?  Or what if there are fixed elements in the view port that would actually move them further up or down the DOM.  Let's thinks some more here...
Again, we should go back to the type of user that would be using smooth scrolling.
Screen reader users don't use skip links as much as one might think.  Screen readers have built in navigational controls to jump to landmarks, headings and links on a page.  Those controls are how most screen reader users get around a page quickly.  These skip links are mostly just clutter in the list of links that they can jump through with screen reader navigation controls.
So we probably don't have to worry about screen reader users and them losing focus management, because they're not likely to be using these sorts of skip links.
But as Eric said, not all screen reader users are blind.  Right.  I would classify these people as sighted (or partially sighted) keyboard users.  And again, these are not the target audience for smooth scrolling.  They want to get through the document quickly, and while they might want to use a skip link, it'd arguably be better for them if it just took them to their destination.
So, verbose lead-in out of the way. What should happen here?
I would submit that the solution to this may be in how the smooth scroll is activated.
If a user activates it via keydown, that means they likely navigated to it via keyboard controls.  In instances like this, I would say the scroll should not be allowed to be canceled as a keyboard user wants to go to the destination of the link.  The smooth scrolling is not the expected behavior for them, as links typically just go to their destination, so they're likely not going to sit there and be like "OH WAIT. THIS DOCUMENT I ALREADY NAVIGATED THROUGH.  LET ME TAB AROUND IN IT AGAIN, RIGHT HERE, BECAUSE LOL".  Also why are they talking in all caps? So mad...
However, if a user activates the smooth scroll via mouse click/down/whatever, I could very well understand that they might want to cancel out of that functionality.  It may be for reasons like "oh, wait. something shiny caught my eye. I should interact with this brand some more."  Or... no.  It's probably only that one reason.
So, to sum this up.
If a user interacts with the smooth scroll trigger via keyboard controls, I wouldn't suggest you allow the scroll to be cancelled, because it's not expected behavior.
if a user interacts with the smooth scroll trigger via mouse click/down/up/ok, it's probably ok to allow the scroll to be cancelled.  Yes, this could still be a keyboard user with a cat attacking their track pad, or some other slip up.  So to mitigate this, I'd say keep focus on the smooth scroll trigger.  So if the scroll is interrupted, they could just initiate it again.
  Hope you aren't sorry you asked me to join in :)

@scottaohara - should keyboard events trigger smooth scrolling at all then?
My love of smooth scrolling: it makes anchor links less disorienting for sighted users by providing a visual reference that you're moving elsewhere on the current page--not going to a new one.

Also, skip nags aren't really used that much? I feel like everything I know is a lie.

skip navs are used.  just not necessarily by blind screen reader users who have different, comparable, means of navigating a page.  this was news to me too, before I started doing more testing with low/no-vision users who never needed them cause they were using the built in screen reader functionality, as i mentioned above.
and yes, though I am quite snarky in my post (sorry it's my default state), I'm not trying to down play it as a UX feature for sighted users.  But let's be clear here, this is a feature enhancement for sighted users, and it would be slowing down the expected interaction for blind keyboard users, if they were to use it.
With that said I don't necessarily think this should be a mouse click only feature, but if it was updated to have an option to make it mouse click only...I'd personally want that.
But it definitely shouldn't be able to be interrupted if it was initiated by a keyboard user, since the expected functionality is "i click link. I go there", regardless of if this is on the same page or not.
I'm just saying I'm less worried about mouse interactions cancel out the smooth scroll.  But again, only if a mouse triggered the interaction to begin with.

Given that keyboard events also fire as a click, and implementing this would be quite complex for what I perceive to be a limited benefit, I'm labeling this one wontfix. Sorry!

@NonesuchStudios Revisiting this, can you tell me more about this?

I call animateScroll with a pixel value rather than a selector quite often. When it's used that way there are myriad situations where you'd want to make sure the scroll was interruptible and leave focus untouched.

Sure! Some examples from recent projects:

To make it clear that a particular page was scrollable, I used animateScroll to scroll down just a little, to provide a "peek" of further content. This is helpful for sighted users, but irrelevant for people navigating with a keyboard or screen reader.
To accommodate a large inline video that was exactly the height of the viewport, I used animateScroll to center on the video when a user clicks the play button. Otherwise, it was very difficult to manually scroll perfectly to that position.
Scrolling down to content from above the fold when a user clicks a "down arrow" icon. This was a consistent pattern on multiple pages, and for a number reasons it was much easier to scroll to a pixel value, instead of using hash-links. Another feature that's useless for someone who will just tab to the first header below the fold.

Hopefully those examples make sense!

@NonesuchStudios Super helpful, thanks! A few quick follow-up questions, if you don't mind:

With the "down arrow" icon, why wouldn't you want to bring focus to the new content?
What should happen after cancelling? Should the page stay where it is? Jump somewhere else?
Is this something you feel should happen automatically (ex. when hitting escape or scrolling up) or only run programmatically (via an API call like smoothScroll.cancelScroll())?

In this case, passing focus would be fine actually. The animation should still be user-interruptible though.
The page should stay where it is. The whole idea is that if the user tries to initiate their own manual scroll, the script should immediately cede control to the human input instead of "fighting" the user's attempt at scrolling. The only intuitive way to do this is to leave everything as-is.
In my ideal world we'd have both: A global option to turn this on and off by default that could be overridden by passing a param to animateScroll. And an api call. The built-in version could be very simple and just cancel the animation when any input causes a scroll. The api would allow the flexibility to handle more complicated setups, any unforeseen edge cases that might crop up.

Ok, so the good news: this is coming to version 12 as public method. You'll be able to setup your own events to cancel scrolling using the new cancelScroll() method.
The bad news: I will not be adding any automatic support or settings for this. It can only be done via the API, and you'll be responsible for handling things like focus and position on the page.
I'll be releasing Smooth Scroll 12 shortly.

@cferdinandi fantastic! Thank you so much for your hard work!

Done: https://github.com/cferdinandi/smooth-scroll/pull/362


feat: added DJAGGER_DOCUMENT url_names parameter to resolve url also with their names

with this feature we extend the DJAGGER_DOCUMENT paramenters and we can configure the resouces also with url_names. Eg:
DJAGGER_DOCUMENT = {
    "app_names" : ['my_entire_app'],
    "url_names": ['oidc_provider_token_endpoint']
}

Ok, I'll review this over the weekend.

Ok, done, thank you

Ciao @royhzq
when do you think to have a new release of djagger?

@peppelinux I'm planning to do a release 1.1.2 with the above changes by this Thursday


Provide install manifests that do not contain the gateway-api admission server

What would you like to be added:
A release artifact similar to https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.8.1 which contains the installation manifests for Gateway API CRDs and not the Gateway API admission server and related resources
Why this is needed:
Installing the Gateway API admission server is optional and all its functionality has been replaced by CEL validations
https://kubernetes.io/blog/2023/08/29/gateway-api-v0-8/#cel-validation

Is this kind of a part of https://github.com/kubernetes-sigs/gateway-api/issues/2319? We could merge them as it would seem reasonable for one body of work to take care of both at the same time. We don't have to though either.

@shaneutt yes its related to #2319, but imo having a smaller work item is much easier to track and assign to a community contributor
looks like https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh needs to be updated to accomplish this goal, the question is around naming and content - should we just create a experimental-crds-install.yaml & standard-crds-install.yaml and keep the existing experimental-install.yaml & standard-install.yaml as is ?

@shaneutt yes its related to #2319, but imo having a smaller work item is much easier to track and assign to a community contributor

:+1:

looks like https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh needs to be updated to accomplish this goal, the question is around naming and content - should we just create a experimental-crds-install.yaml & standard-crds-install.yaml and keep the existing experimental-install.yaml & standard-install.yaml as is ?

I'm not sure we should start having all these extras laying around, I think we should just remove the admission server bits and be done with it, v0.8.0 (the last release intended to "support" the webhook) is branched and any future webhook development should probably be isolated to that branch.

cool @shaneutt, I can take care of this
/assign @arkodg

I'm not sure we should start having all these extras laying around, I think we should just remove the admission server bits and be done with it, v0.8.0 (the last release intended to "support" the webhook) is branched and any future webhook development should probably be isolated to that branch.

Unfortunately per #2319 we still actually need to keep the webhook around in v1.0. Because we've committed to supporting 5 trailing Kubernetes versions, we need to wait until v1.29 is live to fully drop the webhook. It looks like that is currently scheduled for Dec 5, and of course we want to launch v1.0 by the end of October. My suggestion would be for the default installation method to exclude the webhook starting in v1.0, but I think we still need to leave it around for that release and provide a way to install it as an add-on for 1.24 clusters.

Ah, yeah this had slipped my mind, and it's true so sorry about that @arkodg but I guess we can't get away with a toss in the bin on this one.

Cool, waiting for specific guidance on this before continuing any further

@robscott two options here, for each of standard and experimental, we have two install manifests

crds-install & webhook-install
OR
crds-install & all-install (this file exists today)

which one do you prefer ?

Thanks @arkodg! Currently each release has experimental-install.yaml and standard-install.yaml files, I think we should keep those going forward, but remove the webhook from them and instead add a short-lived (v1.0 only) webhook-install.yaml, does that make sense? (The webhook installation is the same regardless of release channel).
I think the result would just be a relatively simple change to https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh.
Maybe you were talking about different files than I was though, so let me know if I missed something.

I'm on board with that too :+1:

Thanks @arkodg! Currently each release has experimental-install.yaml and standard-install.yaml files, I think we should keep those going forward, but remove the webhook from them and instead add a short-lived (v1.0 only) webhook-install.yaml, does that make sense? (The webhook installation is the same regardless of release channel).
I think the result would just be a relatively simple change to https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh.
Maybe you were talking about different files than I was though, so let me know if I missed something.

sgtm, on it !


merge from template-sync/template-arlac77-github

package.json

chore(package): add 0BSD (license)
chore(deps): add ^2.3.4 remove ^2.3.3 (devDependencies.browser-ava)

LICENSE

chore(license): add year

README.md

docs(README): update from template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.842%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
416

Relevant Lines:
426

💛  - Coveralls


Install script should create ./bin/dev

[ ] For parity with JSBundling, the installer script should create a simple shell script at ./bin/dev with this contents:

#!/usr/bin/env bash
if ! command -v foreman &> /dev/null
then
  echo "Installing foreman…"
  gem install foreman
fi
foreman start -f Procfile.dev-static

[ ] remember shell script must be set to be executable (chmod 0755 ./bin/dev)

[ ] use the post-install message to direct people to this option

TODO: @jasonfb says he will PR this.

@jasonfb I like the idea. Can you throw in a PR?

@jasonfb I like the idea. Can you throw in a PR?

Keep me as backup

@ahangarha you can do this if you like. It's simple enough.


Better package argument error

The package name is supposed to be specified on the command line as an argument.
Closes: https://github.com/aws/eks-anywhere-packages/issues/491

/approve
/lgtm


Correction for raw affiliation Laboratoire d’Économie, Finance, Management et Innovation - UR UPJV 4286; New Bulgarian University

Correction needed for raw affiliation Laboratoire d’Économie, Finance, Management et Innovation - UR UPJV 4286; New Bulgarian University
raw_affiliation_name: Laboratoire d’Économie, Finance, Management et Innovation - UR UPJV 4286; New Bulgarian University
new_rors: 002qhr126;01gyxrk03
previous_rors: 002qhr126
works_examples: W4321261209
contact: 7c2b2f111c93b097120abb524a31f510:adef6e784d5bf2d5e49bbd0a79fcfd83 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Fix link in README

gitmoji has its own page, so it should be better than github.com.

Thanks for your contribution @okuramasafumi. I agree with you, but can you use a gitmoji in your commit title? 😄

Why not 😁


@collection directive multi-site support?

I'm working on a Statamic site that has been "intertwined" with a custom Laravel app. They've built the entire front-end with Blade templates using Blade Directives.
My work with them has been to add multilingual support for a Spanish version of the site. I've worked through most of that, and the site and it's Spanish content are loading as expected at the corresponding URL's.
There are a few places, though where instead of content controlled through the CP, a template will loop through a collection to show all the entries. Out of the box, the @collection directive was not respecting the multisite setup, and would show all the entries in the collection instead of just the ones pertaining to that site or language.
I've been working with the gents at Statamic, and they suggested adding a site:is directive to make the collection only show entries for the site the user is viewing. This seems to have no affect on the results, either. Here is the relevant part of the template:

            @collection('activities',  ['where' => 'published:' . true, 'orderBy' => 'order:asc', 'site:is' => Statamic\Facades\Site::current()->handle()])

                <x-image-card
                    :image="$entry['hero_image']['url'] ?? ''"
                    :title="$entry['title']"
                    :copy="str_limit($entry['hero_copy'], $limit=150, $end='...')"
                    :link="$entry['permalink']"
                    link-text="Learn more"
                />

            @endcollection

Am I missing something simple here, or maybe there's a bug? I'm not sure what else I need to do.

Turns out updating to v.3 of the add-on fixed this. Composer was capped at v.2 and we didn't realize there was a newer version available.


Mastermind Javascript game added - GSSOC'23

Mastermind game - new project

Close #2414

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

Please merge this as part of GSSOC'23

Hello! Please check this PR and merge it as part of GSSOC'23

I have made the changes and resolved the conflicts, please check

Please check now


Rm https section

@alexandresobolevski - could you review? a couple different things here, check it out commit-by-commit

good to 💃 ?

heck ye


Generate documentation for content, tests, and types packages

Generate documentation for content, tests, and types packages

Added via https://github.com/RedHatInsights/insights-results-smart-proxy/pull/103


optimize fill(0) for integer arrays

Per discussion here
https://forum.crystal-lang.org/t/fastest-and-iconic-way-to-zero-an-array/1799/17
optimize fill(0) operation for integer arrays.
class Array(T)
  def fill(value : T)
    {% if Int::Primitive.union_types.includes?(T) %}
      if value == 0
        to_unsafe.clear(size)
      else
        fill { value }
      end
    {% else %}
      fill { value }
    {% end %}
  end
end

For the implementation, checking for value.zero? is probably better.

Well, we still need to decide what to do with Floats, for which there is a 0 that is not all 0s.

Dealing with floats need not prevent optimizing for integers.
If there is an accepted viable process to optimize for floats it can be added later.

For the implementation, checking for value.zero? is probably better.

Why?

I'd say .zero? should be recommended generally because it work for any number type. In this case it doesn't matter, but for example with complex numbers it makes a difference.

I'd say .zero? should be recommended generally because it work for any number type. In this case it doesn't matter, but for example with complex numbers it makes a difference.

Thanks, I didn''t realize that, but good to know, though here we know value is an integer.

PR done here.
https://github.com/crystal-lang/crystal/pull/8903

I think you can close this, nice work.


Change on premises

Hi folks,
can we change  "on premises" to on-premises please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a7c1600-c310-fb7f-7976-2025ee9256f3
Version Independent ID: 9241081b-eabb-78a8-af86-2c0f27e7e671
Content: Enable unlimited archiving — Admin Help - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/enable-unlimited-archiving.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@r-milne Thanks for heads up. Next time, please fix typos like this by submitting a pull request. Here's how: https://review.docs.microsoft.com/en-us/office-authoring-guide/contribute-get-started-setup-quick-update?branch=master


It's not work after convert the widget to input

If I convert subject to input, the subject's value will not work. It will keep the value of it's widget form.

Hi, sorry for delay. Yes, it's a known bug and it is not meant to be used like this for now. I did this to have a full interactive preview. Thus, only "inside" values are used (only JS code). If using widgets as inputs, I won't be able to preview result dynamically. TODO...

I'm not sure the "OUTPUT_NODE" attribute can do this?
I saw some custom nodes use this to do some api communication with serverside. The PREVIEW_STRING can be provided by serverside.

Thank you I will tak ea look when I find some time...

I'm not sure the "OUTPUT_NODE" attribute can do this? I saw some custom nodes use this to do some api communication with serverside. The PREVIEW_STRING can be provided by serverside.

I figured it out, if there is no OUTPUT_NODE, the workflow will not run...😅

This looks an amazing project but sadly I also found the node buggy. Hope you can polish it :)

This is a problem for me too. I want to be able to use wildcards, which this node can not recognise, so I create the prompt in a node that does use wildcards and feed it into this one....and it is completely ignored :(

here is a hotfix for this issue.
https://github.com/syllebra/bilbox-comfyui/pull/19
It looks there are changes to disable do the node.type check from ComfyUI.

I commited the hot fix and it works now. However, you still need to select another parameter for auto update if nodes linked to widget input are modified.


also exclude bulbs BaseSuperFeautre model from make_content

@mparent61 @benghaziboy

Coverage decreased (-0.2%) to 85.932% when pulling d3a8b1d1c49f74ff3b71bc6676b87ff9c3dc1943 on exlusions into 9f8973cab8ec80583c19fb491844b09867166dad on master.

👍


RPM speeds in dumped info

https://github.com/Umio-Yasuno/amdgpu_top/blob/ee770d7a6982647b1a9702cd2f30c384d3ce0eee/src/dump_info.rs#L212
https://github.com/Umio-Yasuno/amdgpu_top/blob/ee770d7a6982647b1a9702cd2f30c384d3ce0eee/crates/amdgpu_top_json/src/output_json.rs#L65
Hi!
I've noticed a small inconsistency in the TUI/cli, I'm not sure if it was done on purpose or not :)
Dumping info by default, non-json way, returns only max_rpm, while dumping info as json returns only current RPM.
I can prepare a PR adding current and max rpm to both dump options if you don't mind!

Please open PR.

 Have a nice day :)


Support for Opentracing > 0.31

The Tracinghandler currently doesn't work with Opentracing versions < 0.31 because of its usage of the SpanBuilder.startManual() method. Are you planning to create a release that supports more recent Opentracing versions?

Would you like to submit a PR to update the OT API?

sure, the changes required are minimal. I was primarily wondering whether you still support this little project and would release a new version once we have the changes in place ;-)


[Ruleset Engine, WAF] Max body size analyzed varies per plan

Summary
Addresses PCX-12405.

Preview of updated pages:
https://pedro-pcx-12405-clarify-requ.cloudflare-docs-7ou.pages.dev/waf/managed-rules/#important-remarks
https://pedro-pcx-12405-clarify-requ.cloudflare-docs-7ou.pages.dev/ruleset-engine/rules-language/fields/http-request-body/


use env vars for ohai+chef version

we're floating on master now, so i think i'm going to whack merge on this to add the env vars.


Are you sure install Visual Studio 2015 not 2019?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ebf2732-040f-8496-4583-11d341a25dbb
Version Independent ID: c685bd0a-8f1a-9697-2ae9-425023ef8a47
Content: Write a Universal Windows driver (KMDF) based on a template - Windows drivers
Content Source: windows-driver-docs-pr/gettingstarted/writing-a-kmdf-driver-based-on-a-template.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Oops!
Thanks for spotting this, @huhuang03! I've changed the link to point to the latest version of Visual Studio.
Eliot


Downloading images sometimes hits the 10 min timeout

The image downloads can take longer than 10 minutes, so doubling the timer


fix producer topic metadata on-demand fetch when topic error happens

This PR can help fix producer topic metadata on-demand fetch when topic error happens in metadata response.
There is an option Full in Config to config whether producer should fetch all topic metadata in a cluster or do it on-demand.
This feature is added in #937.
But there is an situation where we may make on-demand topic metadata fetching fall back to empty once an topic error happens in metadata update.
For example, if an ErrLeaderNotAvailable error happens, the topic name will be deleted from client.metadata. This will result in an empty topic slice when refresh topic metadata next time in https://github.com/Shopify/sarama/blob/master/client.go#L648-L666 from client.Topics() which actually read topics from client.metadata. Thus we lost the topic name which we need to periodically refresh metadata.
We should not update client.metadata or delete any topic key from it.

/cc @eapache @chandradeepak @wvanbergen

/cc @burke

If ErrLeaderNotAvailable happens, the topic will be deleted from the map but will immediately be re-added at line 756. I don't understand how this is a bug.

If ErrLeaderNotAvailable happens, the topic will be deleted from the map but will immediately be re-added at line 756. I don't understand how this is a bug.

@eapache Sorry for not making the description clear and correct. The error maybe ErrUnknownTopicOrPartition or ErrInvalidTopic or ErrTopicAuthorizationFailed or any other errors that will make the switch case continue.

/cc @eapache @chandradeepak @wvanbergen @burke

I'm not sure I agree. If the broker returns one of those errors the topic either doesn't exist or is fundamentally inaccessible. Leaving it in the metadata hash at that point would be extremely misleading to callers and would likely lead to other problems when trying to iterate over the set of topics.

But there is an situation where we may make on-demand topic metadata fetching fall back to empty once an topic error happens in metadata update.

I'm also not sure how this can happen. The refreshMetadata method already checks if the list of Topics is empty when trying to do a partial refresh: https://github.com/Shopify/sarama/blob/f7df95cff1bc4d14a4194a5be4c88a86253afb98/client.go#L654-L655

@eapache

I'm also not sure how this can happen. The refreshMetadata method already checks if the list of Topics is empty when trying to do a partial refresh

Yes. That's right. But refreshMetadata will return ErrNoTopicsToUpdateMetadata forever since the topic error happens. This is a problem because the topic error may disappear, but the topic name has been removed from metadata and it will not recover automatically alongside the topic error recover. A restart of producer must be done. This hits me.

If the broker returns one of those errors the topic either doesn't exist or is fundamentally inaccessible.

The error maybe not all related with producer side configuration. Some errors are related with server side operations or status.

OK, I understand. As mentioned, leaving it in the metadata would cause other issues. A better solution would be to keep a separate copy of the topics when not doing full metadata, and use that (in combination with client.Topics() still) in refreshMetadata().

As mentioned, leaving it in the metadata would cause other issues. A better solution would be to keep a separate copy of the topics when not doing full metadata, and use that (in combination with client.Topics() still) in refreshMetadata().

I have thought that before i propose this PR. I think directly update the client.Topics is fine. According to the discuss above, it seems that a new field should be added to store topic names whose metadata are need to be updated periodically. @eapache
Will update this later today.

@eapache PTAL.

thanks!


Refs 1947: Update e2e test template

Summary

Update e2e testing template names to not be specific to the stage environment
Create an identifier string to pass to the test container's IQE_IBUTSU_SOURCE env value. This is used when reporting test results.

Testing steps

https://issues.redhat.com/browse/HMS-1947


Support custom response code for redirect

Currently the HTTP redirect returns response code of 303.
This response code should be customizable e.g. response().code(302).

The fix is available in the 5.0.10 release.


Feature/allow navigation for api calls

During testing, we encountered a couple of bugs these changes should fix those:
iframe style
Added display: block; to the iframe style to prevent whitespace at the end of the iframe, this was causing unwanted scrolling behavior when using the search function.
webViewController.loadFlutterAsset
Changed webViewControllerload.HtmlString to webViewController.loadFlutterAsset, loadHtmlString method would often throw a exception I don't know why but using the loadFlutterAsset method solved it.
onUrlNavigation filter for api requests
On iOS the navigationDelegate will also be triggered by api requests made by the javascript on the page. To make the behavior the same as Android I've added a filter on these request to make sure that  api request (from talkJS) are always allowed.
This will also make sure that a user of the plugin can not prevent the plugin from loading the chat by returning a UrlNavigationAction.deny from onUrlNavigation (Which is how we found out about the issue when we started testing on iOS)

Thanks for the PR.
The changes you proposed make sense and solve your problems.
The problem is that we need the baseUrl to be https in order to make voice recordings work, so webViewController.loadFlutterAsset is not the solution.
Can you investigate what are the exceptions caused by webViewController.loadHtmlString?

@Alexander-Ordina We (at TalkJS) were discussing internally what the default behaviour of links would be.

@bugnano I figured out what was going on:
The initialUrl: 'about:blank' was causing the page to load 2 times, first the blank page then the talksJS page if the first one was not finished before the second one started loading then the onPageFinished would not fire for the second page only for the first. This seems to only happen with the webViewController.loadHtmlString() method.
The fix for this was simple, I just removed  initialUrl: 'about:blank'  since it is not required for webview This way it will only load the one page and the onPageFinished function will fire an excute the required code.
I put the webViewController.loadHtmlString() back so I hope you agree with this fix.

Closing as no longer relevant with InAppWebView


Web Assembly

Will you be adding web assembly builds soon? Or is the Web Assembly MVP not sufficient enough for libsass?

I have not dabbled with WebAssembly yet and I don't plan to in the sort term, but I'm sure sass.js will eventually be a WebAssembly thing.

I've tried my luck with WebAssembly but wasn't able to make native-wasm work.
-s WASM=1 -o test.html  will generate eveything needed for execution, but I get the following error:
trying binaryen method: native-wasm
failed to compile wasm module: RangeError: WebAssembly.Module(): Wasm compilation exceeds internal limits in this context for the provided arguments
Uncaught no binaryen method succeeded. consider enabling more options, like interpreting, if you want that: https://github.com/kripken/emscripten/wiki/WebAssembly#binaryen-methods

Firefox and Chrome can't run the generated test.wasm directly either, they abort because of a version mismatch. … will try again in a few weeks.

Via a tweet I noticed that @AshKyd made some changes to sass.js to get wasm to work.
@AshKyd do you want to send a PR for that? Does this still work in browsers not supporting WASM?

@rodneyrehm Was more a learning experience. It doesn't work in Node 8 (not sure why), and there's no fallback either so it's not mergeable without more work.
I can't commit to anything, but if nobody else picks it up I might have another look when I have some time. :)

FYI: https://github.com/sass/node-sass/pull/2220

Thanks for the nudge @mgreter - I've just released a beta for WASM: 0.11.0-beta.1
Please try it out and tell me if something goes wrong with the relative loading of libsass.wasm. Not sure if I should consider this a (potentially) breaking change or not…

Hey
I am currently testing the WASM beta and at least for a simple use case it works fine with no issues.
My use case is a Browser-based Monaco Editor sass => sass.js => inject to styles -WYSIWYG editor.

I guess we'll have to try some more (and probably produce a bigger build), because IE11 doesn't support WASM…
no native wasm support detected
no binaryen method succeeded. consider enabling more options, like interpreting, if you want that: https://github.com/kripken/emscripten/wiki/WebAssembly#binaryen-methods

https://gist.github.com/surma/b2705b6cca29357ebea1c9e6e15684cc might help with switching from this archaic grunt build thing to webpack with support for wasm.

https://developer.microsoft.com/en-us/microsoft-edge/platform/status/webassemblymvp/ suggests that Edge is now supporting WASM as well

Can we get a new WebAssembly build after all these updates? :)

Can we get a new WebAssembly build after all these updates? :)

were you using the 0.11.0-beta.1 build already?

Yes, it is about 2 seconds faster for my setup.


Convert to Swift 3

Would be awesome to have this library working on Swift 3 as well

Swift 4, please!

请更新到Swift 4


Flutter does not provide prebuilt ARM64 binaries for Android

At least not to my knowledge.

Per @chinmaygarde:

I suspect there will be some complexity in the tooling w.r.t the AOT snapshotter since the i386 based snapshotter for armv7a wont work when creating snapshots for aarch64 (we could just the same snapshotter that is used for iOS but obviously that is absent on linux hosts).

@jason-simmons is this safe to close?

@jason-simmons says this is fixed!


How to limit identity creation per IP

I stored identity created per IP, but i don't know how to validate it.
If the validation is in the model, no way i can get the request.ip string.

The latest version of the gem, 3.0.3 has an :on_valdiation option, which can be used to implement a captcha and could also be used to validate IP.
Cheers!


Extending rbac

In the "Zowe Application Framework Configuration" section, added a sub-section "Applying role-based access control to application services."

I've already added a number of comments to the old PR, so see https://github.com/zowe/docs-site/pull/496 for my review.

Adding sections on configuring role-based access control to Zowe in the Configuration and Extending sections.


Naming DateRegion

Branch from the discussion in #123.
The rationale for renaming it to DateRegion was that Region is too general; it could be used in a different context which is not at all imaginary when working in a international context.
Region is backward compatible.
It is obvious that the naming causes confusion with DateInRegion and it would be easily resolved by renaming it back to Region.  Maybe it is a good idea, but also maybe we can find another -more specific- name?

Area?

Frankly I've not any better idea right now... sic!
(But if you we stay with DateInRegion and Region encapsulate params for DateInRegion seems natural Region is the name for this struct)

Agreed, let's move back to Region

Done in 68e121438f6934b1a15bf98410c2f85308cecea5


Fix redis room pubsub shutdown

task.exception will throw if the task was cancelled, so we have to handle that exception differently

Bors merge


Make current_activity commands to be hub commands. And make them queryable.

I think it make sense to POST to /hubs/:hubSlug/commands/:commandSlug rather than to POST to /hubs/:hubSlug/current_activity/:commandSlug.
Also I think these current activity commands should be queryable.

Also I think these current activity commands should be queryable.

The commands are currently query-able with:
GET /hubs/:hub_slug/activities/:activity_slug/commands

I think this is the better approach since it means you can see the commands for each activity ahead of time, rather than having to actually change your activity to get a list of the supported commands.

I agree they are available ahead of time, and that is useful. However, I think it makes sense to be able to see what commands are currently available, rather than having to look up the current activity, and then querying for the commands for that activity, which is why I left that old query in.

meh, it seems to me that any time you're going to need to know what the list of commands are, its because you're automating in a specific way. You'll know which activity you're automating for.
I'm not a big fan of being able to do the same thing in 2 ways. This will muddy things up and just add yet anotherrrr endpoint.

I get where you're coming from. And I'm hoping that pulling the common code out might alleviate some of those concerns.
I would still contend though that it is useful to list commands that you have access to, rather than having to look up what your current activity is, and determining what commands that activity has, and then issuing the command on the "current_activity" URI. Feels more "REST"y to GET /hub/:hubSlug/commands, and then to post to /hub/:hubSlug/commands/:commandSlug.

Feels more "REST"y

I agree with this regarding /hub/:hubSlug/commands/:commandSlug

Which is more reason to have GET /hub/:hubSlug/commands return the list of commands you can POST to /hub/:hubSlug/commands/:slugCommand. While yes it adds another end-point, I would argue that the GET /hub/:hubSlug/activities/:activitySlug/commands endpoint is the additional and redundant one (albeit nice to have so we have some idea in advance what the commands for different activities are), since there is no corresponding POST for it.

OK FINE! Sold me!

Welp, I merged it and immediately saw an issue:
Should we change this MQTT topic;
harmony-api/hubs/family-room/current_activity/command

to
harmony-api/hubs/family-room/command

to mirror the http api?

Yes we probably should. I can do that and update the docs.

Created PR#45


Consider removing dependency on Microsoft.AspNet.Http and related dependencies

For larger projects I'm often forced to create single purpose command line tools to which one might have to sign in with user/administrator account. This is currently awkward since all the security checks like CanSignInAsync  are within SignInManager and the whole thing is dependent on the http stack. I'd like to see the library split into two, one specific to http and one that contains just the core logic behind authenticating and locking out users.

ASP.NET Identity is targeted at ASP.NET web scenarios only.


[PE-D][Tester E] Assigning Deliveries to Employees

In the inspect tab, the intended functionality is for the user to indicate the employee name in the command from the inspect tab, as seen in the screenshot below:

However, in the inspect tab, there is no list of employees available and the user will have to choose the employee he wants to assign it to before hand in the main window before assigning the delivery. It might be helpful and clearer to include a list of employees in the inspect tab as well.

Labels: type.FeatureFlaw severity.Low
original: ethan-goh/ped#7

New feature, so unable to do anything about this.


Edit table/field comment

Complex table/field edit could be quite complicated and some things can't be changed easily. But editing comment is.
We might also support complex/multiline comments/documentation.

There is a bug with removing query parameters on save/close.
Also, click on entity row now opens comment edit, it used to be a column list and I'm not sure if current state is good.


[PSM Interop] Log on debug level when resource deletion failure is 404

Removes noise from the cleanup/teardown ops.
GCP APIs
In GCP APIs, change log level for delete operations that failed because the resource doesn't exist (API 404) from info to debug.  Framework's logging philosophy is to only log external operations (e.g. APIs, RPCs). If no error logged, the op is assumed successful.
In the deletion case, is still possible to discriminate between whether the op was actually performed by observing the Waiting %s sec for %s operation id: %s log message.
K8s APIs
In K8s APIs:

For delete operations that failed because the resource doesn't exist (API 404) the log level is changed from info to debug
For delete operations that failed for any other reason, the log level is changed from info to warning
When wait_for_deletion is enabled (it's the default) the delete operation will be confirmed with logger.info("<resource_kind> %s deleted", name). Previously it logged at the debug level.


Not seeing new TSV format Columns for the new TSV file in the TN card

v1.0.0 build a2e8af6 QA.

log in to the app using your login.
Select org as test_org and lang as en.
select the book as Titus from top navigation bar. Note: see the tN card shows Reference column.

From the top navigation, select another book. Note: see that the columns in the tN card are changed and Reference no longer shows in the card, nor in the Column settings.

Is it switching Old and new TSV formats?

I deleted my old branch and found the tN card to show new TSV columns correctly in v1.0.0 build a2e8af6.


Option for YAML to be hidden by default

I prefer only showing the YAML metadata when necessary. The rest of the time it's hidden.
Whenever I restart Obsidian I need to toggle this plugin to hide it. Can you give the option to hide the YAML by default?
This would be helpful on mobile too.

This is good idea. I will implement it soon.

had released, please upgrade to 1.1.0.


ClusterPeer should cache Cache if necessary.

The default cluster peer Infinispan caches the cache already and in some implementations caching the cache at Hosting is not desired and may break the implementation.


cmd/cue: -l flag cannot combine context (filename) and expression on input data

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20221119112418-32bfffd0aa53

       -compiler gc
     CGO_ENABLED 1
          GOARCH arm64
            GOOS linux
             vcs git
    vcs.revision 32bfffd0aa538d63757efeef393bc37a06c8c9a4
        vcs.time 2022-11-19T11:24:18Z
    vcs.modified false

Does this issue reproduce with the latest release?
Yes
What did you do?
# Use the detail field to construct a path for the imported result
exec cue import -l detail -o - input.json
cmp stdout no_context.golden

# Use the filename to construct a path for the imported result
exec cue import --with-context -l 'path.Base(filename, path.Unix)' -o - input.json
cmp stdout context.golden

# Can I combine the two?
exec cue import --with-context -l 'path.Base(filename, path.Unix)' -l detail -o - input.json
cmp stdout combined.golden

-- input.json --
{
	"filename": "rubbish",
	"detail": "something"
}
-- no_context.golden --
something: {
	filename: "rubbish"
	detail:   "something"
}
-- context.golden --
"input.json": {
	filename: "rubbish"
	detail:   "something"
}
-- combined.golden --
"input.json": something: {
	filename: "rubbish"
	detail:   "something"
}

What did you expect to see?
A passing test.
What did you see instead?
It's not possible to provide a -l path that combines references to both context information (filename et al) and expressions that refer to the object being imported:
$ ts repro.txtar
# Use the detail field to construct a path for the imported result (0.017s)
# Use the filename to construct a path for the imported result (0.016s)
# Can I combine the two? (0.014s)
> exec cue import --with-context -l 'path.Base(filename, path.Unix)' -l detail -o - input.json
[stderr]
error evaluating label detail: reference "detail" not found
[exit status 1]
FAIL: /tmp/testscript991473742/repro.txtar/script.txtar:10: unexpected command failure

That said, the expectation above needs to be caveated. --with-context provides an undocumented means to address contextual information which, as demonstrated in the second case, includes filename. In the third example above, filename is an ambiguous reference to either the filename provided by --with-context or the field by the same name for the object being imported. It's unclear therefore that we can combine references to both context information (filename et al) and expressions that refer to the object being imported; in the general case it will be ambiguous. We might need to think about a different way of referencing context information (#context?).
Also, the data provided by --with-context does not appear to be documented.

The data provided by --with-context is documented in cue help flags.
Admittedly that could/should be referred to elsewhere in the docs (I always forget where it lives myself!).
Those docs show that the original data is available in the data field, so your example can be made to work
by using this incantation:
exec cue import --with-context -l 'path.Base(filename, path.Unix)' -l data.detail -o - input.json

So I'll close this issue as "working as intended" and raise another to improve the docs for --with-context
which are clearly not surfaced as clearly as they should be.

Ah perfect, thanks!


Array for views gives "TypeError: Arguments to path.resolve must be strings"

Hi, I have express-handlebars 2.0.0 on express 4.12.3, and I think I've discovered a bug.
The aforementioned TypeError gets raised when I try and render a view. The line that seems to be causing it is line 193 of express-handlebars.js: view = this._getTemplateName(path.relative(viewsPath, viewPath)). Since I've passed an array to app.set('views'), viewsPath is also an array, and thus raises that error. I'd try and fix it myself, but I don't really know how I'd go about that.
Just in case it helps, here is my index.js (the error occurs when I visit /resonate/bts/editor):
var express = require('express');
var path = require('path');
var fs = require('fs');
var hbs = require('express-handlebars');
var app = express();

app.set('view options', {layout: false});
app.engine('.rsn', hbs({extname: '.rsn'}));
app.set('view engine', '.rsn');
app.set('views', [
  path.join(__dirname, 'resonate/bts',
  path.join(__dirname, 'resonate/template')
]);

app.enable('trust proxy');

...

var files = [];
walk('resonate/template', function(f,s) {
  files.push(f);
});

app.get('/resonate/bts/editor', function(req, res) {
  res.render('editor', {
    files: files
  });
});

app.use(require('compression')());
app.use(express.static(__dirname));
app.listen(8080);

Any ideas would be fantastic, thank you!

Makes sense that you'd get a type error when setting views to an array based on the current implementation of renderView(). This is also related to #112.
To support views being an array this code would need to be refactored. A new private method could be added to resolve view name.

Ah right, I see. Thanks a lot!

I just ran into this issue today as well. I imagine this will come up more as an issue as people migrate to Express4 / use multiple view directories.

did you fix the problem？it still throw err 'Path must be a string',when i set the views to an array .
-_-


Cannot fine the specified checkpoint.

I have a checkpoint named test.cpkt but when I run  sh exec_infer.sh --ckpt_name="test" (with our without quotations, and with or without /gpt2), the script cant find the checkpoint.

Hi, thank you for your attention to this project.
If the script cannot find the checkpoint, I think this is because the checkpoint direction is not correctly specified.
The checkpoint directory is {args.ckpt_dir}/{args.model_type}.
Can you check again whether the model is properly contained in above directory?

I am now running sh exec_infer.sh --ckpt_name="test"  with test in the saved_models/gpt2 and it still can't find the checkpoint. Is there any more arguments I need?

Then is the extension of the checkpoint file .ckpt?
The script automatically append .ckpt extension at the end of ckpt_name.

apologies, here's a screenshot. Theres a seinfeld.ckpt in my saved_models/gpt2 folder

I just trained the model with small amount of data and executed inference script just like you did.
It works perfectly fine and if you didn't modify the codes, then this would be a typo issue regarding the directory name or file name.
Please show me the entire shell script file exec_infer.sh and your file list in saved_models/gpt2 directory.

I recommend you to pull again since I just modified small error. I mistakenly pushed data truncation for testing before. I fixed so that the entire training data should be included.

The two screens requested. Pulled again and getting the same error. Thank you for the help so far.

You didn't specify the checkpoint file name.
You should change --ckpt_name=CKPT_NAME into --ckpt_name="seinfeld".

Oh I see. So I have to change the arguments in the script as opposed to just in the command line. Thank you!

Yes. And I recommend you to retrain your model. Since I changed data loading part when I re-pushed.


[OPENTOK-43733] Log when RTT is really high

What is this PR doing?
This PR adds a watcher to the publisher so that we can detect when we have really high values of rtt (=> 10000) either for video or audio.
How should this be manually tested?
Will be hard to test since we can't reproduce the scenario. But, we can make a change to see how it will log:

Change the line 32 in the file publisher-rtt-watcher.js to this:

if (roundTripTime <= RTT_THRESHOLD) {

npm run build
npm start
Open localhost:3000 and join a room
go to network tab and check that every 30s you should see a new ClientEvent log with a data similar to this:

clientSystemTime:<PHONE_NUMBER>740
clientVersion: "v2.20.3"
componentId: "meet.tokbox.com"
connectionId: "90c76575-2007-4d5b-b4b7-b6cd533747c1"
guid: "2c8e322b-0feb-4b6d-859d-2bed9ea98dbb"
kind: "video"
logVersion: "2"
name: "meet.tokbox.com"
partnerId: "100"
rtt: 0.218
sessionId: "1_MX4xMDB-fjE2Mjk5MjU1OTA5MzF-YUJpN1JHTTVnUC95TjRTMWtvRHZnVDlDfn4"
source: "http://localhost:3000/dfdsffds?tokenRole=moderator"
userAgent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36"

Because of this change to test it, you will see two logs, one for audio and one for video. In real like, it will only log the video kind that has the high value. In case both have high values, it will log both (audio and video).
What are the relevant tickets?
OPENTOK-43733

I'm a little confused by what I'm seeing. I've made the change so that we log when the RTT time is less than the threshold and in the network tab every 30 seconds I see 3 logs for video and 1 for audio. Is this expected?


Is there API for searchPublicChat method?

I need to get user ids for username and google suggests to use searchPublicChat, but it seams absent in this library. Is there a way to invoke this method or equivalent ?

TLRequestContactsResplveUsername