File structure

Now everyone has their own taste about how to structure files, however at this moment I see 2 problems.

First letter capitalized or not? I see certain files not being capitalized at this moment should they be capitalized or should the others files not being capitalized as first letter?
File suffix, we are working here with JSX syntax however are naming the files as .js files, I think they should be renamed to the correct file extension -> .jsx

i think its quite common. components captitalized, everything else lowercase. index.js. Minimap.js <Minimap />. as for jsx, i have never seen anyone use jsx before, didn't even know it existed. i think it's perfect as it is now, same as the default react startup https://codesandbox.io/s/elated-stonebraker-f7ci1 or cra

Hmm okay

btw i found this: https://reactjs.org/docs/faq-structure.html react ofc is unopinionated but these suggestions are what i see most people using.

Now everyone has their own taste about how to structure files, however at this moment I see 2 problems.

First letter capitalized or not? I see certain files not being capitalized at this moment should they be capitalized or should the others files not being capitalized as first letter?
File suffix, we are working here with JSX syntax however are naming the files as .js files, I think they should be renamed to the correct file extension -> .jsx

We already had an issue with filename capitalization because git does not pick up capitalization changes by default. Some filesystems are case insensitive and didn't have an issue, while others are case sensitive and the build broke. We can avoid problems with capitalization if we standardize on lowercase.
I also agree that .jsx is the appropriate file extension for files using the jsx syntax. It's nice that the default configuration of create-react-app just makes it work, but we can have better build performance if we specify which files need transpiliation from jsx to js.

if we use jsx, then i think we could move to vite. craco + esbuild is faster than cra, but vite is up without any delay, 0.01ms, also fast refresh is instant. but i think it wants "jsx" which i thought is weird. @bjornstar @Gusted should we?

@bjornstar @Gusted should we?

I've heard of Vite and seen it a couple of times being used. It's more tooling thann CRA offers at this moment and seems like they already have a template for react however if we for some reason want's to switch to Ts in the future it's  better to do it now and use the typescript react template.
Vite overall seems great no issues raised from me. Additionally we could covert this into a discussion, to get some more input.

I don't mind trying vite, using create-react-app is really slow and painful.


What is the shape/structure of the y_pred and y_true argument in loss function when multiple outputs are used?

Hi,
I want to write a custom loss function involving two different outputs from one network. I'm not sure how to do it because I cannot access each prediction separately. So in Keras, what is the structure of y_pred and y_true when you have multiple outputs and targets?
Any idea is greatly appreciated.
Thanks!

How did you train your network without knowing what y_true looks like?
With multiple outputs, y_true needs to be a list of labels, or a dictionary with keys for the name of the output layer pointing to a numpy array with dims (batch_size, num_classes). something like {"occupation": array_with_dims(32, 8), "height": array_with_dims(32,1)} if occupation had 8 categories.
A more complete example for creating and passing in x, y_true as part of a generator ):
def next(...): # py2, could use yield instead

      ...

      batch_x = np.zeros((batch_size, size_of_input), dtype=K.floatx())
      occupation_label = np.zeros((batch_size, num_occupation_classes), dtype=K.floatx())
      height_label = np.zeros((batch_size, 1), dtype=K.floatx())

      for i, input in enumerate(batch_of_inputs):
            batch_x[i]=input
            occupation_label[i,idx_of_occupation_of_input] = 1.
            height_label[i] = height_of_input

     return batch_x, [occupation_label, height_label]
     # OR
     labels_dict = {'occupation' : occupation_label, "height" : height_label
     return batch_x, labels_dict

I edited the generator source code in flow_from_directory() for my own purposes, but it depends on the use case.
I would assume that the structure of y_pred will mirror the structure that you give the model from y_true, but I don't know.

@micahprice
Hi,
Thanks for your reply! This is exactly what I need.
I didn't realize I can pass the y_true in a dictionary format.
I'll try it out later today.

https://keras.io/getting-started/functional-api-guide/#multi-input-and-multi-output-models

I was going through various issues in order to solve a problem. And I saw this.. I need a similar kind of help here:
https://github.com/tensorflow/tensorflow/issues/24519
Can you help please?


How to define a DOM node using defineExpose

What problem does this feature solve?
I know that defineExpose is a compiled macro.But in vue3, the root node is fragment. I want to manually specify the root node to let other components find it.
Although I can define a function, many components are third-party and will only look for $el
What does the proposed API look like?
I don't know What should I do.

I don't know What should I do.

Go to chat.vuejs.org and ask the community, please. Issues are not a help board.


Zoom out

part two of the zoom spectacular

let me know what you think

@juliusv ready for review

@juliusv after a lengthy rebase, ready for review. but feel free to leave it for monday..

@juliusv ping

:+1: besides comments


Change env variable names to match other QDK Live tests.

Just change the name of environment variables to match those of live tests (i.e. use the AZUREQUANTUM prefix to avoid conflicts with other variables).

I don't disagree, but this the name we already use and it would require changes in multiple repos. The aim is just to bring this one in-sync with the rest.


Bump NuGet packages. Fix versions for .NET 6 and 7.

I noticed that NuGet package restore would fail for .NET 6 and 7 due to some package references not having framework targets set, in addition to dependencies being out of date. This change fixes that.

Strange. Visual Studio 2022 must have just been confused, then.


Javascript Prototype Support

I'm going on a limb, but I was wondering if we could use prototypes in javascript plugins.
I am assuming we cannot since most of the plugins are just one large object, but I figured I would ask anyway.
something like
stringBuilder: function(player, msg) {
        var x = new stringBuilder();
        x.init({
            player: player,
            msg: "example"
        });
    },

    stringBuilder.prototype.init(options) {
        var player = options.player,
            msg = options.msg,
            color = this.getStringColor(playerid),
            prefix = this.getUserPrefix(player);
    },

    stringBuilder.prototype.getStringColor(id) {
        return data[id].color;
    }

I know this isnt a working setup but just a simple example.

Yes it is possible to use prototype in JS plugins.  I am fairly certain that as long as the instantiated global variables matches the name of the plugin then even the plugin itself can be a prototype.  I might be wrong there but generally the answer to your question is yes in any case.

So, I could do something like
pluginName.prototype.stringBuilder = function(player, msg) {
var x = new stringBuilder();
        x.init({
            player: player,
            msg: "example"
        });
    },
pluginName.prototype.stringBuilder.init = function(options) {
var player = options.player,
            msg = options.msg,
            color = this.getStringColor(playerid),
            prefix = this.getUserPrefix(player);
}

While keeping the plugin as an object? Can I declare the prototypes inside the object or should they be built outside the object?
Or ss long as the plugin itself is properly set to
pluginName.prototype = function() {
   Plugin code
};

Yea, you're on the right track
var pluginobject = function() {
//...
}

pluginobject.prototype.test = function() {
// ...
}

var globalpluginname = new pluginobject();

So if we decided to keep it all together in the object
it would probably go like this ?
var pluginobject = function() {

  this.testProto: function() {
      //..
    },

    this.testProto.prototype.test: function() {
      //..
    },
    var x = new testProto();
  testProto.test();
}

Thanks for the help by the way!

JavaScript protocol support has been added in PR #344.


Fix remove instance step

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/hold


adds basic topic integration and a topic column to the data view

Adds basic topic integration to the db and both python writer-scripts.
Adds a new topic column to the data view.
To keep things simple and in line with the cloud-based dms, the topic-strings defined in the PaPi dms-lite examples should be used.
This new topic field can be a basis for future data-sorting and visualization features (see Refs).
Fixes: https://github.com/Project-Owl/dms-lite/issues/20, https://github.com/Project-Owl/dms-lite/issues/21
Refs: https://github.com/Project-Owl/dms-lite/issues/16

This looks great! Thank you, let me test real quick and then merge!

Changes to the PaPi dms-lite examples can be viewed here: https://github.com/Teikahym/ClusterDuck-Protocol/commit/42f61be31e9cc0cedc649052de60b1ff93a0f3e3
Should I create a pull request for the main Repository (Call-for-Code) or the Project-OWL fork?

If you would like to create the Pull Request to the ClusterDuck Protocol Call For Code repository.
Thank You we are currently working on the DMS-Lite Updates.

The Call-For-Code repository is the official open-source repository. We use the Project OWL fork to make pull requests to the Call-For-Code repository.
Code looks great!


Add knative/client and its plugins to the release process

Not specific for this PR, but I saw the releasability of kn-plugin-source-kamelet is failing.

Not specific for this PR, but I saw the releasability of kn-plugin-source-kamelet is failing.

thanks for the heads, we will investigate this asap.


feat(optimizer, storage): pushdown range-filter to storage

Range-filter scan has been supported in storage #589. But the query engine doesn't make use of it. This PR adds an optimization rule to push range predicates from filters down to scans. To identify range predicates on primary keys (e.g. id > 1), we introduced the range analysis. It will extract a KeyRange from =, >, >=, <, <=, and node, which can be passed into storage later.
Another goal of this PR is to decouple storage from the query engine v1. Currently it depends on BoundExpr from v1 to filter data inside storage. But in fact we don't expect storage to support general filters other than range filters on keys. So this PR removed general filter from storage and added a KeyRange for range filter. After that, the v1 engine can be removed completely.
A simple test on TPC-H dataset:
# disable filter scan rule
> select count(O_ORDERKEY) from orders where O_ORDERKEY < 10;
+---+
| 7 |
+---+
in 0.018s

# enable filter scan rule
> select count(O_ORDERKEY) from orders where O_ORDERKEY < 10;
+---+
| 7 |
+---+
in 0.002s

Also it seems that we pass Option<KeyRange> to the filter but the default value for that is true? Shall we convert it to None somewhere so that we can avoid unnecessary expression evaluation?

I've changed the default value to null so that it's more intuitive. In fact, there is no evaluation for both cases. It only takes the Option<KeyRange> out from the filter node when building executor.


Add message embed capability

Added ability to convert URLs inside messages to embed objects. Messages like:
"Watch this video https://www.youtube.com/watch?v=jNQXAC9IVRw" will be converted into youtube embed markup, where the message is rendered using:
{{$message->toHtmlString()}}

All recommendations answered. All tests passing

@cfpinto  In config oembed section should contains others options like 'width, height`. So it will be more configurable.

The oembed specifications already cover that level of customization. If having styling problems css should be able to handle it. The custom oembed driver does not support offline embed so width and height not necessary I believe


CLI: az vm update --host argument not working as expected

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
az vm update for VMs on multitenant doesn't work as expected in the following use cases:

For a multitenant VM in the same region/zone as the host/host group, if the host group does NOT have VM autoplacement enabled, the value for the --host argument should be the host name, not the host ID:

Host ID in this case, is confusing to the customer in that there are multiple properties that seem like they could be the correct ID (asset ID, host ID, essentials ID):

For a VM on ADH, you cannot use az vm update to change the host assignment to nothing (e.g. moving it to multitenant rather than ADH). This is the same for host group assignment for autoplaced VMs.

To Reproduce
Scenario 1: Create a VM in multitenant and a HG/ADH in the same region/zone as the VM. Stop/deallocate the VM. Try to use az vm update with the --host argument using just the host name or the host ID, not the full /subscriptions/... resource path.
Scenario 2: Have a VM running on an ADH. Stop the VM. Invoke az vm update with --host "" or -- host "" --host-group "". Or set either to null.
Expected behavior
For manual placement, the VM should be able to use the simple host name (rather than ID) to be assigned to the host. Automatic VM placement works as expected to place the VM onto the host (e.g. az vm update with only --host-group specified in a host group with autoplacement is enabled).
For manual placement, the VM should be able to be removed from the host by removing any value assigned to host via --host "" (or null? Whatever is best practice). For autoplaced VMs, the VM should be able to be removed from the host group by removing any value assigned to the host group by --host-group "" (or null, whatever is best practice).
Environment summary
CLI: 2.35.0
OS: Windows 11

Additional context

Compute

@cxznmhdcxz Please help have a look~

Hi @brittanyrowe , for Scenario 2, this command could remove a vm from host:
az vm update -n vm -g group --set "host={}"

@cxznmhdcxz  can we please update documentation to include how to remove a VM from a host?


fix ValueError when parsing editable path without slashes

Related to #83? Seems like maybe a different error though.
This resolves an issue I'm getting when attempting to parse https://github.com/apache/superset/blob/89dbb9888cced762696347a610750755b539f2f0/requirements/base.txt. (Chokes on -e file:..

@vergenzt - apologises I haven't looked at this - looks like we need the DCO signing please first.

No worries! Amended with signoff. Let me know if you need anything else!


toolchain = "nightly" not respected in a workspace

Describe The Bug
A task's toolchain = "nightly" option doesn't seem to take effect in the child tasks executed in each package of a virtual workspace repo.
In my git repo I have the following in a Makefile.toml at the root:
[tasks.format]
description = "Fix code formatting"
toolchain = "nightly"
command = "cargo"
args = ["fmt", "--all"]

I also have a rustfmt.toml in the root that sets some rustfmt options available only in nightly:
max_width = 100

use_field_init_shorthand = true
imports_granularity = "Module"

#
# Unstable options.  This requires nightly rust to format code.  Try:
#
# 1) cargo make format
# 2) cargo +nightly fmt --all
#
# The latter requires rustup.
#

group_imports = "StdExternalCrate"
wrap_comments = true
reorder_impl_items = true

With the above, in a non-workspace repo, cargo-make  runs "cargo fmt --all" using the nightly toolchain, as expected.
With the above, in a  virtual workspace repo, cargo-make appears to run the same command in each package in the workspace but not with the nightly toolchain. I would expect it to use the nightly toolchain.
The fix in this specific case is to set workspace = false for [tasks.format], since fmt has its own workspace traversal logic anyway (which I enable by passing it the --all flag).
I'm filing this despite that available workaround. It seems useful to have the toolchain = "nightly" option propagate to the child tasks executed in each package of a virtual workspace repo.
To Reproduce
$ git clone https://github.com/matta/sift
$ cd sift
$ git reset --hard dad768bd8ab55baeb55c4a0700757b08d30ef2b2
$ cargo make format

The above sets up a small repo that exhibits the bug (at a revision before I found the workaround I describe above).
Now run cargo make format.
The output is:
cargo-make] INFO - cargo make 0.37.15
[cargo-make] INFO - Calling cargo metadata to extract project info
[cargo-make] INFO - Cargo metadata done
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: format
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: workspace
/home/matt/git/sift
[cargo-make][1] INFO - Calling cargo metadata to extract project info
[cargo-make][1] INFO - Cargo metadata done
[cargo-make][1] INFO - Project: sift-core
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: format
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Execute Command: "cargo" "fmt"
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `reorder_impl_items = true`, unstable features are only available in nightly channel.
[cargo-make][1] INFO - Build Done in 0.70 seconds.
[cargo-make][1] INFO - Calling cargo metadata to extract project info
[cargo-make][1] INFO - Cargo metadata done
[cargo-make][1] INFO - Project: sift-egui
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: format
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Execute Command: "cargo" "fmt"
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `reorder_impl_items = true`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Module`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.
Warning: can't set `reorder_impl_items = true`, unstable features are only available in nightly channel.
[cargo-make][1] INFO - Build Done in 0.71 seconds.

The visible warnings make it clear that the exec of each "cargo fmt" command is not being done with the nightly channel.

@matta sorry for late reply.
this is hard to act on as i'm missing some info but i think you are confusing how things work in workspaces.
in workspaces, each make doesn't 'see' the workspace level makefile so whatever you configured there is lost and actually they are invoking the core built in format task
so add:
CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = true
to your makefile in the workspace level
see more here
https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#automatically-extend-workspace-makefile
also got a hunch you are not aware you get dozens of built in tasks unless you skip core tasks
https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#disabling-predefined-tasksflows
tell me if that 1 liner solve it for you

closing due to lack of feedback


MSC2675: Serverside aggregations of message relationships

Rendered
Replaces #1849 along with #2674, #2676, and #2677
FCP proposal

Synapse implementation:

/relations endpoint
Bundled aggregations

@deepbluev7 has pointed out that we could make the target event id an opaque (encrypted) value as far as the server is concerned and pass that opaque id to /relations and /aggregations. If clients can decrypt that opaque value to the actual target event id, they can still apply the returned aggregation and relations to the correct event.

I'm not quite sure I follow that suggestion. Maybe an example would help. If the server knows which events to return based on an encrypted event ID doesn't that mean that the server knows the mapping from encrypted id -> id which makes it pointless?

seems like there are lots of comments here which need addressing; I don't think more input from the SCT is a blocker at the moment, so I'm removing it from the todo list.

The majority of this should be ready for re-review from the SCT.

In an effort to get concerns raised more quickly, let's merge this:
@mscbot fcp merge

@mscbot concern visibility changes need to be descoped

@turt2live, @erikjohnston: this has changed substantially since your FCP ticks so I'm taking the liberty of removing your ticks.

@mscbot resolved visibility changes need to be descoped

I have addressed the mentioned open threads.

(removing needs-implementation here because this stuff is all used in element and synapse today)

if someone could track down the implementations and link them in the PR description, that'd be super amazing. It's hard to believe that this is implemented exactly as described without evidence.

@mscbot concern lacking implementation validation
@mscbot concern general clarity - TR review

if someone could track down the implementations and link them in the PR description, that'd be super amazing. It's hard to believe that this is implemented exactly as described without evidence.

I linked to the relevant bits of the Synapse implementation (the new endpoint and how the bundled aggregations get included).

Thanks! Looks to be vaguely enough to compare against.
@mscbot resolve lacking implementation validation

@turt2live I see you removed the unresolved-concerns label, but you still have one outstanding concern on this MSC. Is that intentional?

oops, thought I didn't hold that concern as blocking, sorry.
@mscbot resolve general clarity - TR review

So regarding Handling limited (gappy) syncs: I couldn't find any MSC Proposal handling this, is there any?
IMHO, this is the most important part, since for example:
If we received and event via sync, which may has annotations bundled into it and keep it up-to-date via local aggregation using all future m.relates_to events, but then go offline for a day and come back, without syncing all events in-between, we end up in an incorrect state for the local aggregations of the already received event.
If we would simply use a locally cached copy of the locally aggregated event, it would not match a refreshed version from the server. Thus, in this situation, we can't really trust any local copies of events, except we query all relational events, that happened in-between. This would make "jumping back" to the locally saved event somewhat incorrect (mismatches a fresh copy from the server). And refreshing all locally saved events would diminish any possible traffic savings gained by local caching.
Only case I see in which we could realistically save traffic is an initial sync, with filters enabled to not fetch all m.annotation / ... / events, but include then in consecutive /sync calls. Other than that, this makes locally caching/saving events, in order to not re-query them, a step harder, since we have to be really careful to keep all the local events in sync & up-to-date.
This problem is (imho) rather drastic in bigger rooms with large amounts of daily traffic. When loading older messages we may end up loading batches upon batches of events filled with relational events only until we load a real m.text message that the client could display. (e.g. if many reactions have happened) But we cannot exclude them, if we choose to locally aggregate already received events, since we might miss some otherwise.
In that light, it almost seems more logical and traffic-saving to discard local copies all together in order to take advantage of aggregations and bundling. In that case, we can always apply a filter for the events received in /sync and can be sure that the data received is up-to-date. (after loading/paginating through the /aggregations endpoint if there is a next_batch present)
Am I missing something obvious here, or am I correct that making local copies in combination with this MSC seems like a pain?

@ara4n @turt2live  I guess it's pointless to comment here since the proposal has been merged, but I feel like chiming in, as a client developer:
I've been reluctant to implement anything not yet in a released version of the spec, but in my client I did implement support for reaction annotations, since they're so widely used in Element and other clients already.  But now I'm seeing my client not render annotations in some cases, which I've found is because the server is now aggregating some of them.
I understand the motivations for this proposal, but at the same time, it increases the complexity of developing clients: rather than simply handling each reaction annotation event, a client must handle both aggregated reaction annotations and individual reaction annotation events.  This means that, when an individual event comes in, I have to emulate the server-side aggregation in my client, adding it to the annotated event's unsigned data myself, so that I can still have a single path for rendering an event.
Fundamentally, this means that a single logical action (reacting to a message) may now be represented in a room's timeline in two different ways: as individual events, or as aggregations of metadata on the annotated event.  So this does not seem to make it easier for clients, but rather, more complicated.
I feel like Matrix would do well to emulate the Zen of Python: there should be one, and preferably only one, way to represent a logical event in a room's timeline.  This would greatly simplify implementations on both clients and servers, which would do much to help ensure Matrix's adoption and longevity.
My two cents.  Thanks.

Spec PR: https://github.com/matrix-org/matrix-spec/pull/1062

Merged 🎉


Feature request: Truncate hostname from FQDN to dinamically assign kerberos realm

It would be great to truncate the hostname from the FQDN to use it dynamically as kerberos realm.
You could implement a "winrm-is-domain-member" boolean to enable or disable this functionality.

winrm-is-domain-member - (for example,. as in https://github.com/rundeck-plugins/rundeck-winrm-plugin) Option to truncate hostname when used as domain for kerberos login. If set to "true", replaces "host.domain.tld" with "domain.tld" appending to username.

+1

Thanks for the feedback. We aren't using this with kerberos at the moment, so this isn't something that would be implemented any time soon. Merge requests are welcome.


The current readme has incorrect statement

Sorry, that's a dirty fix. But would do the trick for now.

Good enough for now, thanks :+1:

👊
On February 10, 2015 at 8:52:11 PM, Felix Krause<EMAIL_ADDRESS>wrote:
Good enough for now, thanks
—
Reply to this email directly or view it on GitHub.
—
Thanks,
Almas Sapargali
http://almassapargali.com


Fix raffler [WIP]

@rdohms: you wanna merge this before the next meetup? :wink:

I wouldn't merge it without extensive checking... May have had alcoholic influence when writing... Not sure :P feedback required, since i'm too tired right now to check myself.


Ews Exchange: Bug fix for PAPP-25569 and documentation changes for PA…

…PP-25200
Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the readme.html.
[ ] If this is a new connector or you are adding new actions

[ ] Please document in the readme.html all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

The integration test pipeline is failing due to timeout as it takes more than one hour. Attaching the pipeline link from pytest for the same - https://cd.splunkdev.com/phantom-apps/app-tests/-/pipelines/5810714

@ishans-crest  - Latest pipeline execution link for pytest - https://cd.splunkdev.com/phantom-apps/app-tests/-/pipelines/5852656


This project needs more visibility

Hi,
i think this project needs more visibility ! The official website never speaks about it. We should have a link to this repo in the homepage in Learn > Other ressources.
Also, we shoud have a link in the Documentation page in sidebar menu and in Symfony Best Practices section.
What do you think ? For now, beginners and others can't find this project if there are any link in the official website.

I agree with you, we need more visibility.
However, the project is already mentioned and explained in the docs: http://symfony.com/doc/current/book/installation.html#installing-the-symfony-demo-application

I think this issue should be opened in symfony-docs repo

Issue opened : https://github.com/symfony/symfony-docs/issues/5541

Closing it in favor of the symfony-docs issue.


WIP - Ensure Pylint<=2.0.0 on Python 2.x

Fixes #2057

[x] Title summarizes what is changing
[x] Includes a news entry file (remember to thank yourself!)
[?] Unit tests & code coverage are not adversely affected (within reason)
[x] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
[x] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
[n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
[n/a] package-lock.json has been regenerated if dependencies have changed

@DonJayamanne to get CI to complete faster I have gone ahead and edited your code to pass pylint<2.0.0.


ccl_sigmaR does not use the 2D P(k,z) spline to compute sigmaR

Comparing CCL and NumCosmo, which already implements the 2D (k, z) spline for P(k, z), we noticed that the 5e-5 required precision fails:

sigma at z > 0.8 and is attained between 0 <= z < 0.8 and  0.1 < R < 100;
dlnsigma_dlog10M at z > 0.8 and is attained between 0 <= z < 0.8 and  0.3 < R < 100, if the interval for R starts at 0.1 then it already fails at z = 0.

The lower bound for R is controlled by K_MAX_SPLINE. But even if we increase its value, we still have problems at high z (z ~1).
Originally posted by @pennalima in https://github.com/LSSTDESC/CCL/issues/79#issuecomment-472574231
I just realized that CCL does not use the P(k,z) to compute sigma_R at redshifts z>0. It always compute at z=0 and then multiply the result by the growth function. This leads to lower precisions at high redshifts.

ccl_sigmaR relies on the linear power spectrum, so the scaling by the growth function should be sufficient. Wouldn't using P(k,z) introduce additional uncertainties due to the splining of the matter power spectrum? To increase the precision, have you tried improving the sampling of the growth function instead?

If I'm not mistake we tried improving the sampling in the growth and obtained the same order of magnitude for the difference. It is expected that the growth computed by the simple ODE (that both NumCosmo and CCL use) will differ from the actual growth computed by CLASS (or CAMB) which takes into account the (small at that point) coupling with the other components. To avoid this, when using CLASS and splitting P(k,z) = D^2(z)P(z), we use D(z) = sqrt (P(k_star, z) / P (k_star, 0)) with a fixed fiducial k_star instead of D(z) as the solution of the simple ODE.
I'll test if using your growth the difference vanishes.

@vitenti was there any update on this?

Addressed by #800


separates logEntry and commits in logEntry model

A couple of remarks about the model.
I think you're doing too much at once here and it becomes a bit diffuse.
So I've come up with a suggestion for splitting LogEntry and Commit, such that a LogEntry has a Commit instead of being one.
A note about not using classes:
When it comes to the models I use interface more as a struct or type. Ideally they should all be readonly as well. I've done a sloppy job with that so far though, and the fact that I extend the model of extension/git complicates things, and leads to the annoying problem of authorEmail and parents.
So really, it's nothing on you, it's the shortcuts I've taken to quickly make this extension work.
And thanks again for helping, I've done some testing and it looks and works great. 😃
Full ownership of the entire model is a goal further down the line.
In general I'm going for more of a functional style than OO. (I realize this might not be clear 🐱 )
The view parts use classes and some OO patterns because it think it fits the problem well, but they don't keep that much state and their render functions are almost pure.

That separation seems fine to me, I think that's okay either way, worst case we can always come back and refactor it.
I use class because I want to throw error early on if someone try to access something that doesn't exists. Of course one can use Object.assign with an object that has those two getter functions that throw an error to be more "functional", and I thought that's probably easier to use a class. Maybe that's also a sign that those shortcuts needs to be refactor in some way, but that's probably in the future.
I got a sense of functional style when going through the code 😺 As long as objects stay pure and have shallow inheritance, I think objects can provide utilities. Anyway, thank you for clarifying.
Thank you for turning this around quickly 😊


Does not work in MatLab 2016b

I run launch and get
Error using getappdata
Value must be a handle.
Error in GridLayout/Update (line 282)
OldPosition = getappdata(Obj.Container,'Position');
Error in GridLayout>@(hsrc,ev)Update(Obj,true)
Error using GridLayout (line 70)
Error while evaluating UIContainer SizeChangedFcn
Undefined function or variable 'fHG1Client'.
Error in simiam.ui.AppWindow/create_layout (line 212)
jClient = jFrame.fHG1Client;
Error in simiam.ui.AppWindow/load_ui (line 72)
obj.create_layout();
Error in launch (line 20)
app.load_ui();

I get the same errors in matlab 2016a

I get similar errors in MATLAB R2019b (and a few warnings).
Error using getappdata
Value must be a handle.

Error in GridLayout/Update (line 282)
            OldPosition = getappdata(Obj.Container,'Position');

Error in GridLayout>@(hsrc,ev)Update(Obj,true) (line 72)
                'ResizeFcn', @(hsrc,ev)Update(Obj,true), ...

Error using GridLayout (line 70)
Error while evaluating UIContainer SizeChangedFcn.

Warning: The JavaFrame figure property will be removed in a future release. For more information, see Recommendations for Java
and ActiveX Users on mathworks.com.
> In findjobj/getRootPanel (line 383)
  In findjobj (line 216)
  In simiam.ui/AppWindow/create_layout (line 140)
  In simiam.ui/AppWindow/load_ui (line 72)
  In launch (line 20)
Warning: The JavaFrame figure property will be removed in a future release. For more information, see Recommendations for Java
and ActiveX Users on mathworks.com.
> In findjobj/getRootPanel (line 383)
  In findjobj (line 216)
  In simiam.ui/AppWindow/create_layout (line 183)
  In simiam.ui/AppWindow/load_ui (line 72)
  In launch (line 20)
Warning: The JavaFrame figure property will be removed in a future release. For more information, see Recommendations for Java
and ActiveX Users on mathworks.com.
> In findjobj/getRootPanel (line 383)
  In findjobj (line 216)
  In simiam.ui/AppWindow/create_layout (line 190)
  In simiam.ui/AppWindow/load_ui (line 72)
  In launch (line 20)
Warning: The JavaFrame figure property will be removed in a future release. For more information, see Recommendations for Java
and ActiveX Users on mathworks.com.
> In findjobj/getRootPanel (line 383)
  In findjobj (line 216)
  In simiam.ui/AppWindow/create_layout (line 195)
  In simiam.ui/AppWindow/load_ui (line 72)
  In launch (line 20)
Warning: The JavaFrame figure property will be removed in a future release. For more information, see Recommendations for Java
and ActiveX Users on mathworks.com.
> In simiam.ui/AppWindow/create_layout (line 211)
  In simiam.ui/AppWindow/load_ui (line 72)
  In launch (line 20)
Unrecognized function or variable 'fHG1Client'.

Error in simiam.ui.AppWindow/create_layout (line 212)
            jClient = jFrame.fHG1Client;

Error in simiam.ui.AppWindow/load_ui (line 72)
            obj.create_layout();

Error in launch (line 20)
app.load_ui();

I appreciate it's been a while since this tool was developed so maybe shouldn't expect it to work today.  How serious are these bugs and what would it take to update the code? (Happy to help if it's within my capabilities).

Actually there's a post about this error on the Mathworks help forum here:
There is one answer that recommends the following:

Change the code to jClient = jFrame.fHG2Client;

This seems to eliminate the last error (but I don't really understand how).

I managed to hack my way past the immediate errors (see here for example) but then the UI launches and there are still lots of problems (e.g. text on buttons missing) so I guess this is going to be more than just a quick-fix:

@billtubbs Any luck getting the simulator fully working on a newer version of MATLAB?

@jtisaacs I was using version R2019b.  I haven’t tried anything more recent.

I have it working now on R2020a. Beyond the fixes that you mention above I had to make changes to the AppWindow function to make the images show up on the buttons. The problem seemed to be with using img paths when I was using the html strings, so I switched to loading the image and setting the 'cdata' field.

I have it working now on R2020a. Beyond the fixes that you mention above I had to make changes to the AppWindow function to make the images show up on the buttons. The problem seemed to be with using img paths when I was using the html strings, so I switched to loading the image and setting the 'cdata' field.

@jtisaacs would you mind sharing how you fixed it? Maybe you can upload it to Github (or submit a pull request).


an issues about zookeeper 3.4.14 and spring cloud config

Thanks for raising a Spring Cloud issue.
Question
I set some config in bootstrap.yml
cloud:     config:       enabled: true       name: zookeeper-client       uri: http://..........
Bug report
generally, spring cloud config will load remote config files first.
but, zookeeper discovery running at first and connect localhost/<IP_ADDRESS>:2181 address

Can you please describe the problem in more detail. What you're doing, what is happening and what you think should happen. Please include versions.

Can you please describe the problem in more detail. What you're doing, what is happening and what you think should happen. Please include versions.

of course. I want put my config files in github repo, and i create a zookeeper config file in it.
i make a config client project and make a spring.cloud.config.name property ,put zookeeper config file name . I click running project button, the log shows zookeeper connect localhost/<IP_ADDRESS>:2181 not the address i set on github

Can you please describe the problem in more detail. What you're doing, what is happening and what you think should happen. Please include versions.

can you help me to solve this problem?

What is the name of the property file in your git repo?  Why are you setting spring.cloud.config.name instead of using spring.application.name?

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


[netcore][03.welcome-user] Fix typos and improvements

Proposed Changes
Fix several typos in readme.md of sample # 03 welcome-user
Testing
The Read Me should not have typos

replaced with https://github.com/southworkscom/BotBuilder-Samples/pull/63


feat: Improved translations

Improved translations by adding the plural's support to:

Refreshing items in history
Contact form

Will fix #2269

Codecov Report

Merging #2272 (367ba3d) into develop (2ea0da3) will decrease coverage by 1.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2272      +/-   ##
==========================================
- Coverage     8.86%   7.70%   -1.17%
==========================================
  Files          161     181      +20
  Lines         6623    9232    +2609
==========================================
+ Hits           587     711     +124
- Misses        6036    8521    +2485

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
19.23% <0.00%> (-14.98%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
26.47% <0.00%> (-4.96%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

packages/smooth_app/lib/main.dart
15.74% <0.00%> (-2.16%)
:arrow_down:

...s/smooth_app/lib/pages/onboarding/next_button.dart
2.22% <0.00%> (-1.78%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9f372...367ba3d. Read the comment docs.


feat: use safe securityContext as default

Signed-off-by: Jorge Turrado<EMAIL_ADDRESS>Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
[x] README is updated with new configuration values (if applicable)

Related to https://github.com/kedacore/keda/issues/2933

LGTM, did we port all changes from core here

Yes, I have added here exactly the same configuration added to core in this PR to be consistent

hey @lsolovey
we have just released new chart version fixing the problem


Addressed Error for Events Missing Required Fields

Should throw an ArgumentNullException if required fields for EventGridEvent are missing when EventGridEvent.Parse is called (matches the behavior for CloudEvents). Before, no error would be thrown (and would throw an error when trying to access event data).

Can we add a test for this?

/check-enforcer evaluate


Game Crashed(Survival)

I was trying to play the survival mode while the game crashed
How to reproduce

Step 1 Get the latest Dev Build
Step 2 and play the survival mode...

link to log file: https://drive.google.com/uc?id=1sK0YsaMcAnrUWP-d8TGtQfS16ftiHUkj&export=download
i have the latest Dev build
Computer details

Hi there :)
This is a know issue in the dev build, we're doing a big module overhaul, see #3737. We need to apply more fixes then get a new good build out.
For reference in general this is for JoshariasSurvival - we could keep this issue to track when JS is stable again

Closing this as complete - JS works fine now in build http://jenkins.terasology.org/job/DistroOmega/1061/artifact/distros/omega/build/distributions/TerasologyOmega.zip and hopefully will keep working normally 👍


Initial Typescript Commit

Hi,
I really like your approach to this. Thinking of using it in a project and saw that you wanted to implement Typescript into it. I have taken a stab at it.
It has all been converted, the only thing that is a problem is 1 test failing but I was hoping to get your assistance to sort that out, and then all of the typescript should be good. Might need a bit of tweaks from your side as you know the library better, but thought this would be a good starting point at least.
Let me know if there is anything you want me to change or if there is anything I can help with.
Kind Regards,
Adrian

Wow! That's a lot of work! First of all, thank you for doing this.
This is definitely a welcoming change but I  have to go through this when  I have some time. I will get back to you on this.
Again, Appreciate your effort on this!


Make loading buttons unclickable and add that to reset-project modal

Fixes #581
disabled={disabled && !loading} just increases the likelyhood that/makes it easier for a dev to make the button looks nice while it's displaying a loading indicator.

I just realized that I should also look into why the OTEL traces for these 500s were useless.

disabled={disabled || loading} is easier for me to read instead of the double negative, would you also agree?

I couldn't reproduce meaningless traces 🤷
@megahirt disabled || loading is not the same thing as disabled && !loading.
I don't want to disable the button if it's loading, because a colourful loading button looks nicer than a greyed-out loading button.

disabled || loading is not the same thing as disabled && !loading. I don't want to disable the button if it's loading, because a colourful loading button looks nicer than a greyed-out loading button.

Yeah, you're right.  I looked at that one too fast.  I did sort of expect that you would be disabling the button to make it unclickable during loading, but it seems like you're ignoring the click in some other way (and I don't understand the code enough to find that part).
This is one of those PRs where a screenshot would be helpful for me.  I would actually love a screenshot on all UI PRs, but we can discuss that as a process change at a team meeting.

Turns out that Playwright does wait for pointer-events to be enabled.
I added a test that demonstrates that.

And for the record, here are what the sandbox buttons now look like:


Pod install not working

Unable to find host target(s) for StripeNative. Please add the host targets for the embedded targets to the Podfile.
I get this installing from npm

Removed cocoapods in https://github.com/lrettig/react-native-stripe/commit/e133a30226cab80a748669ce0483b1c569a282f0, this is no longer an issue. Thanks.


how to swap alt and super

i used dwm on x
i want to swap alt and super global

[ids]
*

[main]
leftalt = layer(meta)
leftmeta = layer(alt)

You can find the manual using man keyd.


NPM test failing for node_redis

When I run npm test I get the following error:
 Error: Redis could not start on port 6379

Do I need to setup my firewall for this to work?

You already have a local redis instance running on that port. Right now it is not ideal that the tests rely an a specific port but it would be quite some work to change that. You just have to close your local instance and run the tests afterwards again.

Same for me, git clone this repo, npm it, I'm using node 8.9.0 and Docker.
docker pull redis
docker run -p 6379:6379 --name redis-server -d redis
npm test

><EMAIL_ADDRESS>test /home/aroberts/node_redis
> nyc --cache mocha ./test/*.js ./test/commands/*.js --timeout=8000

(node:3386) Warning: process.on(SIGPROF) is reserved while debugging

  1) "before all" hook
Error: Port 6379 is already in use. Tests can't start.

    at /home/aroberts/node_redis/test/lib/redis-process.js:37:23
    at tryCatcher (/home/aroberts/node_redis/node_modules/bluebird/js/release/util.js:16:23)
    at Holder$2._callFunction (eval at generateHolderClass (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:92:16), <anonymous>:14:44)
    at Holder$2.checkFulfillment (eval at generateHolderClass (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:92:16), <anonymous>:29:30)
    at Promise.eval (eval at thenCallback (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:14:16), <anonymous>:6:20)
    at Promise._settlePromise (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:566:21)
    at Promise._settlePromise0 (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)

------------------------|----------|----------|----------|----------|----------------|
File                    |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------------------|----------|----------|----------|----------|----------------|
All files               |    11.49 |     1.78 |     1.37 |    11.49 |                |
 node_redis             |    10.84 |     0.31 |        0 |    10.84 |                |
  index.js              |    10.84 |     0.31 |        0 |    10.84 |... 8,1084,1089 |
 node_redis/lib         |    11.99 |     2.92 |     2.33 |    11.99 |                |
  command.js            |    22.22 |       50 |        0 |    22.22 |... ,9,10,11,12 |
  commands.js           |    36.23 |    23.81 |       40 |    36.23 |... 101,104,105 |
  createClient.js       |     6.67 |        0 |        0 |     6.67 |... 71,75,76,79 |
  customErrors.js       |     37.5 |        0 |        0 |     37.5 |... 31,36,37,38 |
  debug.js              |       50 |        0 |        0 |       50 |            6,7 |
  extendedApi.js        |    13.85 |        0 |        0 |    13.85 |... 109,110,112 |
  individualCommands.js |     8.61 |        0 |        0 |     8.61 |... 613,615,616 |
  multi.js              |     6.42 |        0 |        0 |     6.42 |... 181,183,184 |
  utils.js              |     1.75 |        0 |        0 |     1.75 |... 117,118,120 |
------------------------|----------|----------|----------|----------|----------------|
npm ERR! Test failed.  See above for more details.
[aroberts@oc3752625144 node_redis]$ docker kill redis-server
redis-server
[aroberts@oc3752625144 node_redis]$ npm test

><EMAIL_ADDRESS>test /home/aroberts/node_redis
> nyc --cache mocha ./test/*.js ./test/commands/*.js --timeout=8000

(node:3586) Warning: process.on(SIGPROF) is reserved while debugging

  1) "before all" hook
Error: Redis could not start on port 6379

    at /home/aroberts/node_redis/test/lib/redis-process.js:40:23
    at tryCatcher (/home/aroberts/node_redis/node_modules/bluebird/js/release/util.js:16:23)
    at Holder$2._callFunction (eval at generateHolderClass (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:92:16), <anonymous>:14:44)
    at Holder$2.checkFulfillment (eval at generateHolderClass (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:92:16), <anonymous>:29:30)
    at Promise.eval (eval at thenCallback (/home/aroberts/node_redis/node_modules/bluebird/js/release/join.js:14:16), <anonymous>:6:20)
    at Promise._settlePromise (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:566:21)
    at Promise._settlePromise0 (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/aroberts/node_redis/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/home/aroberts/node_redis/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)

------------------------|----------|----------|----------|----------|----------------|
File                    |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------------------|----------|----------|----------|----------|----------------|
All files               |    11.49 |     1.78 |     1.37 |    11.49 |                |
 node_redis             |    10.84 |     0.31 |        0 |    10.84 |                |
  index.js              |    10.84 |     0.31 |        0 |    10.84 |... 8,1084,1089 |
 node_redis/lib         |    11.99 |     2.92 |     2.33 |    11.99 |                |
  command.js            |    22.22 |       50 |        0 |    22.22 |... ,9,10,11,12 |
  commands.js           |    36.23 |    23.81 |       40 |    36.23 |... 101,104,105 |
  createClient.js       |     6.67 |        0 |        0 |     6.67 |... 71,75,76,79 |
  customErrors.js       |     37.5 |        0 |        0 |     37.5 |... 31,36,37,38 |
  debug.js              |       50 |        0 |        0 |       50 |            6,7 |
  extendedApi.js        |    13.85 |        0 |        0 |    13.85 |... 109,110,112 |
  individualCommands.js |     8.61 |        0 |        0 |     8.61 |... 613,615,616 |
  multi.js              |     6.42 |        0 |        0 |     6.42 |... 181,183,184 |
  utils.js              |     1.75 |        0 |        0 |     1.75 |... 117,118,120 |
------------------------|----------|----------|----------|----------|----------------|
npm ERR! Test failed.  See above for more details.

@BridgeAR hi, what's the recommended way to test node_redis then? Ideally with and without Docker - but with Docker (as at the very top of my post), it can't connect. Given how popular it is it'd be great to ensure it remains compatible with the latest Node.js releases.


Class Gregwar\Image\Adapter\Imagick contains 1 abstract method and must therefore be declared abstract or implement the remaining methods

Class Gregwar\Image\Adapter\Imagick contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Gregwar\Image\Adapter\AdapterInterface::saveWebp)

You need to install imagick php extension and also imagemagick package in your system to fix this issue.
source: https://stoorm.org/article/probleme-class-gregwarimageadapterimagick-contains-1-abstract-method-and-must-therefore-be-declared-abstract-or-implement-the-remaining-methods

@doxt3r AKAIK this issue was already resolved.  I don't see how your suggestion makes sense as a resolution for this namespaced lib.  Anyway, closing this out.


The string 'Open Storage Insights' is not localized for one storage account

Storage Explorer Version: 1.34.0-dev
Build Number: 20240308.12
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.4 (M1 Pro)
Reproduce Languages: All languages
Architecture: ia32/x64/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Launch Storage Explorer -> Open 'Settings' -> 'Application -> Regional Settings'.
Select 'français' -> Restart Storage Explorer.
Right click one storage account.
Check whether all strings are localized.

Expected Experience
All strings are localized.
Actual Experience
The string 'Open Storage Insights' is not localized.

Verified this issue on the main build 20240327.12. Reproduce. We are going to reopen this issue and verify it on a newer build.

Verified this issue on the main build 20240328.5. Fixed for all languages. So, we are going to close it.


[Usability] .disabled & :disabled

For .disabled and :disabled buttons should add JS to return false on click so as to prevent browser from following the link/making use of the form button.

We have that in our docs javascript, but won't add it as a plugin or anything like that.


ignoredFolder does not contains appropriate content for each runtime

When runtime is node, the ignoredFolders does not contain 'node_module{,/**}. Seems like there should be break` for each of the switch cases.

@jasmingoh Thanks for reporting this issue.  Definitely is a bug, should have break statements there.


Change of behavior "Error: Resource not accessible by integration"

It started to happen two days ago without any relevant change from our side in all PRs:
https://github.com/rizinorg/rizin/pull/1222
Here is our CodeQL action configuration:
https://github.com/rizinorg/rizin/blob/dev/.github/workflows/code-analysis.yml
The error message is the following:
https://github.com/rizinorg/rizin/pull/1222/checks?check_run_id=2855028592#step:4:1
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/_actions/github/codeql-action/v1/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Job.doExecute (/home/runner/work/_actions/github/codeql-action/v1/node_modules/bottleneck/light.js:405:18) {
  name: 'HttpError',
  status: 403,
  headers: {
    'access-control-allow-origin': '*',
    'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
    connection: 'close',
    'content-encoding': 'gzip',
    'content-security-policy': "default-src 'none'",
    'content-type': 'application/json; charset=utf-8',
    date: 'Fri, 18 Jun 2021 03:41:52 GMT',
    'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
    server: 'GitHub.com',
    'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
    'transfer-encoding': 'chunked',
    vary: 'Accept-Encoding, Accept, X-Requested-With',
    'x-content-type-options': 'nosniff',
    'x-frame-options': 'deny',
    'x-github-media-type': 'github.v3; format=json',
    'x-github-request-id': '0405:5D98:A0F49:119F3A:60CC1600',
    'x-ratelimit-limit': '5000',
    'x-ratelimit-remaining': '4848',
    'x-ratelimit-reset': '1623989200',
    'x-ratelimit-resource': 'core',
    'x-ratelimit-used': '152',
    'x-xss-protection': '0'
  },
  request: {
    method: 'PUT',
    url: 'https://api.github.com/repos/rizinorg/rizin/code-scanning/analysis/status',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'CodeQL-Action/1.0.2 octokit-core.js/3.1.2 Node.js/12.13.1 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"workflow_run_id":948607521,"workflow_name":"Code scanning","job_name":"build","analysis_key":".github/workflows/code-analysis.yml:build","commit_oid":"3dc5ffebacc2420e860f67c3dfcfe08fcf87e09d","ref":"refs/heads/codeql-fixes","action_name":"init","action_ref":"v1","action_oid":"unknown","started_at":"2021-06-18T03:41:51.948Z","action_started_at":"2021-06-18T03:41:51.948Z","status":"starting","matrix_vars":"{\\n  \\"name\\": \\"CodeQL-cpp\\"\\n}"}',
    request: { agent: [Agent], hook: [Function: bound bound register] }
  },
  documentation_url: 'https://docs.github.com/rest'
}
Error: Resource not accessible by integration

Thank you for your report!
I wonder, could this be related to the following issue? https://github.com/github/codeql-action/issues/464
It looks to be the same error. Could it be that the permissions on your repo were changed recently?

We didn't touch, and this is set to RW:

You can actually see in a workflow run what permissions it has. It gets printed out near the top. In your run it did appear to have write permission, so it seems like a different class of bug than others where the workflow runs with read permissions for some reason.

I do note that there have been passing runs since, including runs on the push event. So I'd hope perhaps this is just a one-off.

I'm getting the same error, but only for commits where Dependabot merged one of its PRs. These are showing the following error:

Error: Workflows triggered by Dependabot on the "push" event run with read-only access. Uploading Code Scanning results requires write access. To use Code Scanning with Dependabot, please ensure you are using the "pull_request" event for this workflow and avoid triggering on the "push" event for Dependabot branches. See docs.github.com/en/code-security/secure-coding/configuring-code-scanning#scanning-on-push for more information on how to configure these events.

The highlighted part does not really help, because this affects pushes to master, not pull requests or Dependabot's branches.

@AlCalzone, check out the "analysis still failing on the default branch" section of https://github.com/github/codeql-action/issues/416. Apologies this information is not yet in the proper troubleshooting docs but that change is in progress and we'll update the error message to point there when done.

@robertbrignull Unfortunately this is not a solution for me

From what we can tell the only case where this can happen is if the dependabot PR is merged by using the @dependabot squash and merge syntax. Our advice would be to avoid using this syntax if at all possible. Thankfully the new feature to automatically merge a pull request may be able to help here and fulfil the same functionality.

I'm using an action to determine whether dependabot PRs should be merged automatically, based on the dependency type and version bump. The built-in auto-merge functionality is simply not granular enough for this.
That action is using the @dependabot squash and merge syntax to let Dependabot handle the merge queue, including automatically rebasing when conflicts happen.
Rebasing also seems to trigger even when there are no actual merge conflicts, so there must be something else that Dependabot does. I might be mistaken though - if it is okay to just merge those PRs when there is no merge conflict, triggering GitHub's auto-merging from the action might be a solution.

I'm sorry it's a bit of a pain. It's an annoying consequence of various bits of valid behaviour. The core behaviour to understand is that code scanning analysis won't work on commits authored solely by dependabot, except when analysing a pull request. I hope you'll be able to jig your CI to prevent this case. Unfortunately the only alternative would be to manually restart any analyses that fail because of this reason, as they'll work on the second try because a non-dependabot actor has triggered them.

Would it be possible to add a condition to the default CodeQL job to skip these impossible-to-build commits? Something like github.actor != 'dependabot-bot' || github.event_name != 'push'.

Uploading SARIF files started failing for me about 24 hours ago. Here is an example of the failure.
Here and here are examples of the container uploading the SARIF file successfully a few days ago.
I didn't touch the SARIF part, but I did change how I authenticate with AWS. I switched from using GitHub Secrets to using the Open ID connect and added the permissions block in the action.
Could the permissions block be the reason? If so, what do I need to add?

Answering my own question:
I need the permissions block, otherwise the OpenID connect fails and it has to look like this:
permissions:
    id-token: write
    contents: write              # This is required for actions/checkout@v1
    security-events: write   # To upload sarif files

@martinschaef you are correct that you have to configure the permissions block accordingly. If a particular permission is not mentioned in the permissions block then it gets set to none.
The minimal permissions that should be needed for a workflow to use the CodeQL Action are mentioned in the example workflow at https://github.com/github/codeql-action#usage: security-events: write, and for private repos contents: read and actions: read. This assumes you are using actions/checkout@v2.
To address some earlier questions in the thread, Dependabot runs will now respect the permissions block.

Looking at
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'CodeQL-Action/1.0.2 octokit-core.js/3.1.2 Node.js/12.13.1 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },

I think either codeql replaces tokens with [REDACTED] itself or more likely GitHub does that to prevent codeql from printing tokens to the log. I wonder if it would be possible not to log tokens with write permissions?

Looking at
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'CodeQL-Action/1.0.2 octokit-core.js/3.1.2 Node.js/12.13.1 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },

I think either codeql replaces tokens with [REDACTED] itself or more likely GitHub does that to prevent codeql from printing tokens to the log. I wonder if it would be possible not to log tokens with write permissions?

There are two relevant mechanisms for masking secrets, neither of which are done by the CodeQL Action itself:

The Octokit.js library (which the CodeQL Action uses under the hood for GitHub API calls) replaces tokens with REDACTED before it logs the headers: see here.
Actions secrets that are printed as plain text get redacted (replaced with *s) in the Actions log UI: see https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#masking-a-value-in-log and https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets.

For this reason I believe the CodeQL Action itself is never actually logging write tokens

As long as the CodeQL Action uses the library it's probably safe to say that it logs something with Octokit.js on errors at least and depending on the version of the library it could be anything unless the library is pinned to particular SHAs and gets reviewed when it's updated (which almost never happens)

Actions secrets that are printed as plain text get redacted

I don't think they are always redacted and that's probably why https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets says explicitly

Warning: GitHub automatically redacts secrets printed to the log, but you should avoid printing secrets to the log intentionally.

I think it would be better if the action would fail silently like, for example, labeler, which fails with something like
Error: HttpError: Resource not accessible by integration
Error: Resource not accessible by integration

https://github.com/evverx/systemd/runs/4199356475?check_suite_focus=true

I have this in my YAML file from private repo:
    permissions:
      id-token: write
      actions: read
      contents: read
      pull-requests: read
      security-events: write

But i still have the error:
Error: Advanced Security must be enabled for this repository to use code scanning.

Any solution?

@WaKeMaTTa Make sure to enable advanced security on your repository. The docs are here.
If you are still seeing problems, please raise a new issue and include the relevant parts of the workflow.

@aeisenberg I don't have this option in our private repo:

Please take a look at Enabling Advanced Security Features. You will need an enterprise account to enable Advanced Security on private repositories.

Hi, Kindly enable https://docs.github.com/en/enterprise-cloud@latest/get-started/learning-about-github/about-github-advanced-security#enabling-advanced-security-features.
Then go ahead and add these permission to your workflow for private repos.
permissions:
actions: read
contents: read
security-events: write
statuses: write

Fwiw, it is possible to make things friendlier to users... I intend to include sarif handling in check-spelling with code like this:
https://github.com/check-spelling/check-spelling/blob/8e5f1a5eb8b1cf0da26fe3def6e3229d1cf0c6b9/unknown-words.sh#L1253-L1260
https://github.com/check-spelling/check-spelling/blob/8e5f1a5eb8b1cf0da26fe3def6e3229d1cf0c6b9/unknown-words.sh#L875-L878
Alternatively, if you want to actually take a full leap and just check to see if you go splat, you can do something like this:
https://github.com/actions/labeler/pull/405/commits/6390989c0a6816934c9b32ca51eb4ea99aaf3387
For an expected error, it's really cruel to force users to read through an http header dump instead of providing the information they need in an easy to digest format.
I'd be willing to private a PR of either form to this repository if someone expresses a willingness to review it (sadly the actions/labeler repository appears to be a 👻 town, so I'm not going to allocate resources for things that are unlikely to be reviewed).


buildFHSEnv: filter what we include a little bit

This mostly prevents random junk from leaking into fhsenvs, but also fixes Steam not having a /var anymore.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We can just add extraPathsToLink and things that really need everything will pass "/" (though they really shouldn't).

Added extraPathsToLink, also added /opt to the default list.

As I said, I'm not really comfortable to have this as the default. I think that breaks the expectation that everything you put into the FHS builder is going to show up in the FHS and it shouldn't do that unless it's explicitly asked.

I actually think this makes more sense as a default, because it helps with things like "oh no where did my /var go in the fhsenv".

Shouldn't /var be bind-mounted by the init script?

It's currently not special cased, so if the fhsenv has a /var, it just wins.

Hmm, shouldn't it just be bind-mounted over the /var?
I also think that should someone really add a package that has a var/ subdir, the expectation would be that it's in the FHS when there's no host /var.
If a regular old package has a var/ subdir though, I'd consider that a bug of that package.

AFAICT, they merely contain empty dirs which are probably intended to pre-create those dirs in global-FHS package managers but that's of little relevance for us.
I think I'd be happier with an exclusionary solution; excluding /var specifically from the fhsenv to allow bind-mounting.
I really don't like to break expectations for packages put into buildFHSEnv.

We could just force bind /var on activation at that point, which is also probably fine, but ehhhhh I don't know how I feel about any of this anymore, there's no good way out.

I've had a look at the packages that do populate /var with anything other than empty dirs using
nix-locate --top-level -r '^/var/.*$' -t r -t r -t s

It's mostly stuff that does not belong in /var. I'd be fine with excluding /var by default; any package that populates it is broken IMHO.

We could just force bind /var on activation at that point

I don't think that'd work reliably because I think if there's only one package with var/ buildEnv makes it a symlink which we can't bind-mount over. :/
The only way to do this reliably would be to remove var/ from the env in a post-processing step or see whether buildEnv is able to to blocklisting for paths.

OK so after closer inspection, we actually explicitly copy /var, so we can just not do that.


feat: Update proto def to pass 'buf lint'

This commit modifies the protobuf definition for Hipcheck plugins to meet the expectations of 'buf lint', which checks protobuf definitions against a set of best practices. The main goal here is to make the service definition more defensive against forward-compatibility issues.
This also includes updates to the code that interacts with the generated code to make sure it still compiles.

I imagine this will break the working communication with the dummy plugin via hc plugin

Ah, you're right that I'll need to update that as well. I'll amend the patch with that.

Julian has some in-flight changes to the demo plugin with stuff that we'll be pulling out into our Rust plugin SDK, and I'd rather that get merged first and then rebase this on top. So this'll wait until that's ready.

Resolved merge conflicts, now to get it to compile again haha

@j-lanson removed boxed query stream. Ready for re-review


Pi4 arm/v8 support

Is your feature request related to a problem? Please describe.
Hello, is it possible to run this on a Pi4? I'm running armf on dietpi, I notice some of the forms mention an arm/v7 version
Describe the solution you'd like
support for a pi4
Thanks

At one time, the armv7 build was functional, but it no longer works. Despite my efforts to resolve the issue, the build keeps getting stuck at downloading packages. I decided to cease my attempts and removed all references to armv7.
You might consider building the image on your Raspberry Pi yourself; there's a chance it could work for you. (If it works please let me know, maybe it was just a cross compile issue..)

I'm a noob when it comes to docker but I'll give building my own image a go. I have this running now ...
docker build https://github.com/jorenn92/Maintainerr.git
No errors so far!

ah well, it was worth a try.
ERROR: failed to solve: process "/bin/sh -c yarn run build:ui" did not complete successfully: exit code: 1
Thanks for your help, I'll just have to wait until my new NAS arrives.

ah well, it was worth a try.
ERROR: failed to solve: process "/bin/sh -c yarn run build:ui" did not complete successfully: exit code: 1
Thanks for your help, I'll just have to wait until my new NAS arrives.

What was the specific error message you encountered? It's possible that I'm familiar with it. At least you made progress; I didn't even reach the point of building the apps.

Btw, doesn't the arm64 image work on the pi 4? I was always under the impression it did.

Btw, doesn't the arm64 image work on the pi 4? I was always under the impression it did.

Aha! It does, all I have to do was specify the platform in the compose file. Although, now it's running and built I cannot access it, no ip shown in portainer for the stack.


Client Allocation Request for: 北京中经天平科技有限公司

Client Allocation Questions
Core Information

Name: 北京中经天平科技有限公司
Website / Social Media: https://www.bjzjtp.com
Region: Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f3wwbylr4mxlqcbqvoj3qct2smns4oqk6ewtjwh6cexytv2bqx5w33mw3wpjbtaxnht5az575ia7amj4dtexsq
Notary Requested: MRJAVAZHAO

@szcrzx201 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Please get the information from the last application.https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/891
This is our usage record, please check it.
Deals.xls

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzaceac3o6ygw6vcxn3bbegzkkha3ekfgj3nksp7qy7ha7bgqpc3x3szi

Address

f3wwbylr4mxlqcbqvoj3qct2smns4oqk6ewtjwh6cexytv2bqx5w33mw3wpjbtaxnht5az575ia7amj4dtexsq

Datacap Allocated

NaNB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzaceac3o6ygw6vcxn3bbegzkkha3ekfgj3nksp7qy7ha7bgqpc3x3szi


[GSOC'22 Project] Latest version of FeatureList Networking Visualization Module

Look at this
https://github.com/sanbit876/mzmine3/pull/4


Scoop Update Hugo .25 for latest instead of .29

https://github.com/gohugoio/hugo/releases
Scoop update hugo is pulling 0.25.1 but it should be at 0.29. I might be missing something, if so, I apologize.

Please run scoop update and then scoop update hugo


Service Account fails to create with non-nil error with nil state error

Describe what happened
The service account resource occasionally fails to create with non-nil error with nil state. The account is actually created so further attempts to re-create it cause conflicts. This was reported by users and also affects our tests.
I've come across this particular flake a few times now:
https://github.com/pulumi/pulumi-gcp/issues/2683
https://github.com/pulumi/pulumi-gcp/issues/2530
but those are just the two issues outlining the exact failure. There could be more where the error wasn't noted. We should investigate.
Sample program
See run output in those links.
Log output
No response
Affected Resource(s)
No response
Output of pulumi about
n/a
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

We suffer from this on an almost daily basis since a couple of weeks.
The first attempt to create a service account frequently fails with:
gcp:serviceAccount:Account (*****):
      error: expected non-nil error with nil state during Create of urn:pulumi:***

A retry of the pulumi up than fails with:
    gcp:serviceAccount:Account (*****):
      error: 1 error occurred:
      	* Error creating service account: googleapi: Error 409: Service account sa-**** already exists within project projects/*****.
      Details:
      [
        {
          "@type": "type.googleapis.com/google.rpc.ResourceInfo",
          "resourceName"<EMAIL_ADDRESS>        }
      ]
      , alreadyExists

Only remedy we have is to manually delete the service account in GCP and then do a pulumi retry.

Thanks for reporting @wvanderdeijl. Are you also running this in tests or are you seeing these errors in production workflows? I strongly suspect this is indeed GCP API doing something but we might be able to mitigate it.

This is in production workflows. We do multiple deployments a day. Not all run into this issue, but a significant percentage does.

This might be version related. I tried with the following simple pulumi (clean) project:
import * as gcp from "@pulumi/gcp";

const prefix = 'a';
for (let i =0; i<=75; i++ ) {
    new gcp.serviceaccount.Account(`${prefix}account${i}`, { accountId: `${prefix}account${i}` });
}

With the freshly installed npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>I could run this script without issues and update the prefix from a, to b, to c, so effectively running it three times without issues.
But when downgrading to npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>it failed on the first attempt with 6 service accounts failing with this error.
Not sure if this is concidence.

Interesting, thank you for reporting back @wvanderdeijl. It would be great if this is indeed fixed!


Minor polishing of InMemoryFunctionCatalog

Removed constructor in InMemoryFunctionCatalog that creates empty maps and no registrations since there is no way to register anything after catalog is created.
Refactored registration logic a bit more functional/concise in the FunctionRegistration constructor of InMemoryFunctionCatalog
Added additional assertions in tests

Also, since we're composing a new function in cases such as lookupFunction("f1,f2,f3") should we automatically register the result of the composition (if not null) in the functions map to avoid re-composition on subsequent call with the same name?

I'm getting test failures when I merge this. Could be just me, or maybe something else changed since the PR. If you could rebase and re-push that will help (I set up Travis to build when you do that next time).

@dsyer changes are pushed. The reason for a test failures was the fact that I added 'notEmpty' assertion for registrations, but now I see that it can be empty. All is good now

Merged in ae14c236e (I changed your email address - can you do that on your side, please, for next time - maybe change your default in ~/.git/config?)

@dsyer email is changed closing PR


V2 Update to @material-ui/core

Fixes #17
Purpose

Update to a more stable material ui version
Travis github pages auto deployment

What to Check
package.json

:+1:


db.end() Protype Extension Issue

Disclaimer:
This is NOT an issue with node-mysql in itself, this is an extension I'm trying to add to it for easier coding and less arthritis. This is a great nodejs plugin and I do not mean any disrespect when posting these errors, these are 100% my fault and not the module's.
Hey guys, as pertinent to my thread here about issuing a db.end() command after each query: https://github.com/felixge/node-mysql/issues/1081 (Authored by: EnzoMartin)  I have been getting this error:
[TypeError: Cannot read property 'prototype' of undefined]
var mysql = require('mysql');
					var db_config = {
						host: 'localhost',
						user: 'root',
						database: 'forum',
						password: 'blowme'
					};
					var db;

 var query = db.prototype.query;
db.prototype.query = function(){
    var args = Array.prototype.slice.call(arguments);
    var callback = args.pop();

    args.push(function(){
        db.end();
        callback.apply(this,arguments);
    });

    query.apply(this,args);
};

Which seems odd because db is already set and my connection is working, any ideas?

When the line var query = db.prototype.query; is executed, db is still undefined. You have to actually set db to something before trying to do anything with it.

But I can use db.query('select blah'); right below it and it works...

Is what you pasted the exact code you are running, or did you just put a bunch of things together? It's hard to tell, because as far as I would know, what you pasted in the original is exactly the source code you are running. If it's not, then I'm not sure how to help...

You see, if what you pasted, you have the line var db; and then one blank line below that you have the line var query = db.prototype.query; which of course would throw the error TypeError: Cannot read property 'prototype' of undefined because you never set the variable db to anything.

Full code for my MYSQL to initiate a connection and not produce a FATAL error that crashes NODEJS when the connection to mysql is lost:
// Only use MYSQL for specific functions ~
				if(['JOIN', 'ATTACKMOB', 'JOINGAME', 'PINFOUPDATE','FA', 'BR', 'BL', 'CG', 'EQI','SU'].indexOf(Command) != -1){

					var mysql = require('mysql');
					var db_config = {
						host: 'localhost',
						user: 'root',
						database: 'forum',
						password: 'ezpk123'
					};
					var db;

 var query = db.prototype.query;
db.prototype.query = function(){
    var args = Array.prototype.slice.call(arguments);
    var callback = args.pop();

    args.push(function(){
        db.end();
        callback.apply(this,arguments);
    });

    query.apply(this,args);
};

function handleDisconnect() {
  db = mysql.createConnection(db_config); // Recreate the connection, since
                                                  // the old one cannot be reused.

  db.connect(function(err) {              // The server is either down
    if(err) {                                     // or restarting (takes a while sometimes).
      console.log('error when connecting to db:', err);
      setTimeout(handleDisconnect, 5000); // We introduce a delay before attempting to reconnect,
    }                                     // to avoid a hot loop, and to allow our node script to
  });                                     // process asynchronous requests in the meantime.
                                          // If you're also serving http, display a 503 error.
  db.on('error', function(err) {
    console.log('db error', err);

    if(err.code === 'PROTOCOL_CONNECTION_LOST') { // Connection to the MySQL server is usually
	console.log("MONKEY?");
     handleDisconnect();                         // lost due to either server restart, or a
    } else {                                      // connnection idle timeout (the wait_timeout
         //throw err;                                  // server variable configures this)

    }
  });

}

handleDisconnect();

Unfortunately what you just posted is such an anti-pattern that you'll be guaranteed to run into all sorts of issues in the future. But in order to just get you paste this hump, your code should look like this:
// Only use MYSQL for specific functions ~
                if(['JOIN', 'ATTACKMOB', 'JOINGAME', 'PINFOUPDATE','FA', 'BR', 'BL', 'CG', 'EQI','SU'].indexOf(Command) != -1){

                    var mysql = require('mysql');
                    var db_config = {
                        host: 'localhost',
                        user: 'root',
                        database: 'forum',
                        password: 'ezpk123'
                    };
                    var db;

function handleDisconnect() {
  db = mysql.createConnection(db_config); // Recreate the connection, since
                                                  // the old one cannot be reused.

 var query = db.query;
 db.query = function(){
    var args = Array.prototype.slice.call(arguments);
    var callback = args.pop();

    args.push(function(){
        db.end();
        callback.apply(this,arguments);
    });

    query.apply(this,args);
  };

  db.connect(function(err) {              // The server is either down
    if(err) {                                     // or restarting (takes a while sometimes).
      console.log('error when connecting to db:', err);
      setTimeout(handleDisconnect, 5000); // We introduce a delay before attempting to reconnect,
    }                                     // to avoid a hot loop, and to allow our node script to
  });                                     // process asynchronous requests in the meantime.
                                          // If you're also serving http, display a 503 error.
  db.on('error', function(err) {
    console.log('db error', err);

    if(err.code === 'PROTOCOL_CONNECTION_LOST') { // Connection to the MySQL server is usually
    console.log("MONKEY?");
     handleDisconnect();                         // lost due to either server restart, or a
    } else {                                      // connnection idle timeout (the wait_timeout
         //throw err;                                  // server variable configures this)

    }
  });

}

handleDisconnect();

Okay, now I'm receiving:
db error { [Error: Cannot enqueue Quit after invoking quit.] code: 'PROTOCOL_ENQ UEUE_AFTER_QUIT', fatal: false }
This is most likely because the prototype function is pushing the db.end already and I have tons of db.end's() scattered all over the place, right? lol

Yea, you got it, lol. You can only call db.end() once on a connection, and so this addition will cause all those calls to produce that error.

Yeah figured! And thanks for putting that piece of code block in it's proper place.. Gosh now knowing all about how this mysql runs, while looking over my code I want to throw up.
That prototype function that EnzoMartin made doesn't push or create another query does it, it just pushes db.end()? I heard you mentioning something about creating a new query in your other posts, and that scared me.

i'm confused on what this does...
 var args = Array.prototype.slice.call(arguments);
    var callback = args.pop();

Where is the arguments variable set?

db.end() doesn't run another query, but it does send a command to the MySQL server: the quit command to end the connection.
The arguments variable is a special object that is part of the JavaScript language.

Basically "where does arguments come from" is the same as "where does function come from": it's just part of JavaScript :) nothing to do with this library.

LOL. While fixing some salmon burgers.. I just realized.. I cannot use this prototype.. Why? Because of nested queries.......Haha.

Right, since .end() is being called automatically after a .query(), you'll only ever be able to do a single query. And I guess it's used a lot in Node.js? It certainly exists in JavaScript itself (you'll see it in Firefox, IE, Chrome, Opera, etc.), though you don't typically use it until you're trying to accomplish real goals in JavaScript, which is typically occurring on the server side, in Node.js.

Yeah, starting to see it now more often. Especially looking in the source of these ws and mysql
plugins.. ^_^ Stuff that is way over my head, but interesting. I just get confused when I see all the .this and .this crap. The underscore stuff makes my head boggle.  I understand the objects though and how they're being used. Way more than I did 3 months ago, that's for sure. Which is good because I store my players RPG data in an object called RPGDATA ^^.. Which is nice.

Yes, internal communications we have used single character property names and other tricks for saving network traffic.


Updated example description to make it more precise.

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Updated example description to make it more precise.

Updated example description to make it more precise.


rename repo to flappybug-sprint2 lol

@benyam7  It's sprint 1. xD The previous one was sprint 0. Lol

lol issue closed 😆


scss color variables should be set only if not already present

It would be useful,  if  sccs variables  $primary and  $secondary  were set with the !default directive:
$primary: #3579F6 !default; // "accept all" button and privacy policy link color
$secondary: #89a !default; // "accept necessary" button color

This way they would not  overwrite variables with the same names, which might already exist in a project...
https://github.com/shaack/cookie-consent-js/blob/e35c30980d361935533b128d0618ea1fdca3f23c/src/cookie-consent.scss#L1

Color variables are now more detailed and all !default
https://github.com/shaack/cookie-consent-js/blob/master/src/cookie-consent.scss
Thanks for reporting.


KETTLE-71 - Add Vagrantfile

First pass to adding Kettle to Jenkins CI using the standard Vagrant setup we have for other projects.
How to test:

Checkout PR
vagrant up # npm audit warnings will show in red, it's expected.
npm run lint:vagrant
npm run test:vagrant

ok to test

ok to test

Closing in favor of https://github.com/fluid-project/kettle/pull/48


Adds Sonatype Nexus Repository Manger as a Helm repository host

Signed-off-by: Matt Johnson<EMAIL_ADDRESS>

Hi @mattjohnson, please open a new PR over at helm/helm-www for PRs against Helm 3's documentation. This PR is pointing at Helm 2's documentation. Thanks.

Hi @bacongobbler, I intended this for Helm 2's documentation. When we have better support for Helm 3 I'll add some docs there too.

Re-opening as a change to Helm 2 only.


dir_lock issue still present in 3.0.7

it's still dying with
NameError: name 'dir_lock' is not defined
Traceback (most recent call last):
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\multiprocess\process.py", line 314, in _bootstrap
    self.run()
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\multiprocess\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\ofscraper\utils\download.py", line 237, in process_dict_starter
    asyncio.run(process_dicts_split(username,model_id,ele,log,p_logqueue_,pipe_))
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\asyncio\runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\asyncio\runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\ofscraper\utils\download.py", line 336, in process_dicts_split
    setDirectoriesDate()
  File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\ofscraper\utils\download.py", line 872, in setDirectoriesDate
    with dir_lock:
         ^^^^^^^^
NameError: name 'dir_lock' is not defined

Yes
I was able to trigger the error
In the end it is easier to just set the directories in the main thread.
With that said it should be fixed in 3.0.9


server: fix expiry test flake

Ensure compared times are within a second of one another instead of
rounding, which can flake if the two times are different enough to
do round to different values.
Tested using the golang.org/x/tools/cmd/stress tool.
The following set of commands fail without this patch:
$ go get golang.org/x/tools/cmd/stress
$ go test -o server.test github.com/coreos/dex/server
$ stress ./server.test -test.run=TestOAuth2CodeFlow
219 runs so far, 0 failures
425 runs so far, 0 failures
618 runs so far, 0 failures
802 runs so far, 0 failures
^C

Closes #699

lgtm.


Feature/logging

@fela98
Looks like the pool changes had not been merged in, so they are also included here.
This branch is currently running on the test server.


Keep aad legacy code

Recover aad legacy code.
Add SPEL like @ConditionalOnExpression("#{'${azure.active.directory.uri:notExist}' != 'notExist'}") to make legacy code and new code not work at the same time.
Change new property prefix from 'azure.activedirectory' to 'azure.active.directory'.

/azp run java - spring - tests

/azp run java - spring - tests


distorted 3d image

librealsense
2.36.0 RELEASE

OS
Windows

Name
Intel RealSense D435

Serial Number
740112070993

Firmware Version
<IP_ADDRESS>

Advanced Mode
YES

Camera Locked
YES

Usb Type Descriptor
3.2

Product Line
D400

Asic Serial Number
828313020569

Firmware Update Id
828313020569

Please provide a description of the problem
since the camera got a mild hit the input is a follow:

is it a hardware problem? did somthing broke or do i need to recalibrate?

Hi @netanelfar   A 400 Series camera can become mis-calibrated if it receives a physical shock such as a hard knock or a drop on the ground.  It can be re-calibrated with software such as the Dynamic Calibrator tool.
https://downloadcenter.intel.com/download/29618/Intel-RealSense-D400-Series-Dynamic-Calibration-Tool
Aside from the black areas, there does not seem to be serious problems with the image though.   It may therefore be sufficient to first try using the Self Calibration function that is built into the RealSense Viewer to inprove depth quality.  You can launch this tool by going to the More option at the top of the Viewer's side-panel and selecting the On-Chip Calibration option from its menu.

@MartyG-RealSense thanks,
after using On-Chip Calibration option and running my test code i got this:

as you can see the image is distorted even more.
is should i try Dynamic Calibrator?

The blue '3D' option in the top corner of the Viewer indicates that you are in 3D mode.  This is a type of depth sensing scan made from a cloud of points.  Also, in the last of the images above you have the depth stream disabled, leaving just a broken looking RGB image.  It is typical for the RGB to look incomplete in this mode.
To get a normal unbroken RGB image, you should click the '2D' option.

Hi @netanelfar    Do you require further assistance with this case, please?   Thanks!

hi @MartyG-RealSense the problem still exist i tried to recalibrate but hr edges are still distorted, is there anything else i can do to try to fix it?

I ran extensive further tests in 3D point cloud mode with a D435 with color mapped to depth and was able to recreate the characteristics of your scene.  The only real way I found to make a further improvement, such as reducing the corner distortion, was to move the camera further away from the observed scene.

@MartyG-RealSense . thanks for your help, ill close it for now