NavigationActions.init ?

https://github.com/react-community/react-navigation/blob/master/docs/guides/Navigation-Actions.md
Says there should be an Init action "used to initialize first state if state is undefined"; however the docs only mentioned it without a dedicated section.

From what I can tell it works pretty much the same as NavigationActions.reset. Which is to say, not very well.

Pinging OP @gsklee since this issue has not been active for a while, and it's related to an old version of the lib.
Please let me know if you want this to remain open, because if I get no answer in the next 7 days I will close it.
That said, it's not like there's much to say about Init, as pointed out by @Cygnus2112 - anyway a PR to add a couple lines would surely be welcome.

Hi there @gsklee ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


chore: Update dev container

Description

Updates the dev container definition to utilize homebridge-config-ui-x and default config/auth configurations.
Related Issues
Fixes #
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Developer experience (improves the developer experience

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

jest coverage report 🧪
Total coverage

Status
Category
Percentage
Covered / Total

🟢
Statements
90.73%
372/410

🔴
Branches
55.3%
219/396

🟢
Functions
88.11%
89/101

🟢
Lines
90.68%
370/408

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold


Dependency issues during installation: unsatisfiable scipy version

Hello! First of all, thank you for open-sourcing your amazing work.
I encountered some dependency issues following the instructions in the INSTALL.md file.
The logging information shows that: semantic-sam 1.0 requires scikit-image==0.21.0, scikit-image 0.21.0 requires scipy>=1.8, and kaolin 0.11.0 requires scipy<=1.5.2,>=1.2.0. The dependencies cannot be resolved because no version of scipy can satisfy all 3.
Please resolve this issue. Thank you very much!
P.S. How to reproduce:
Follow  INSTALL.md, after executing pip install git+https://github.com/UX-Decoder/Semantic-SAM.git@package, an error message is shown:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
kaolin 0.11.0 requires scipy<=1.5.2,>=1.2.0, but you have scipy 1.10.1 which is incompatible.

Execute pip uninstall scipy && pip install scipy==1.5.2, an error message is shown:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
scikit-image 0.21.0 requires scipy>=1.8, but you have scipy 1.5.2 which is incompatible.

Execute pip uninstall scikit-image && pip install scikit-image==0.18.3, an error message is shown:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
semantic-sam 1.0 requires scikit-image==0.21.0, but you have scikit-image 0.18.3 which is incompatible.

@WilliamHaiweiGu
Hi there,
Thank you for your interest in our project and for bringing this issue to our attention.
I have updated the INSTALL.md to address the installation issue. The compatibility problem with the dependencies should not affect the subsequent operation of the project. You have two options:

You can choose to keep your current environment as it is.

Alternatively, you can reinstall kaolin 0.13.0 using the following command to avoid the error:
pip install kaolin==0.13.0 -f https://nvidia-kaolin.s3.us-east-2.amazonaws.com/torch-1.10.1_cu111.html

Problem solved.


Update KNOWNISSUES.md

Added some issue #s for open issues.  Removed some rows from the table that have been fixed.

Your changes LGTM. Do we plan on making changes to the cmdlet table too?

@joeyaiello I made some changes in the table, although the diff doesn't make it clear since it's treating the table as one entity.  Update-Help was removed as it works now.  I'll do a separate PR once I identify which cmdlet sets in the table have open issues and which don't.


Remove revB/revC support

For both iOS and Android.
fpga.version() will be removed. The version string remains as before at fpga.read(2, 12)

Done in bart/fpga-version-check branch.


Required extensions not bundled on Linux

VSCode Version:   d81ee41c51cae93a5cac967e42a28660a3a7e005 & 31ceb1112602e005150c8ab481c8e38069da1cca
OS Version: Ubuntu 16.04

Steps to Reproduce:

F5
Get error "Configured debug type 'extensionHost' is not supported."

I needed to revert to version 25b370a3ebe800ac1fedc551a47b7689aa2a5c5b to debug my extension.

The reason for this is that the required node extensions is not bundled in our linux package. You can see this by going to the extensions viewlet and trying to install node-debug (it is possible to do that since it is missing). Once you install it - everything works fine.
Not sure if this has something to do with how our ubuntu deb package is built and maybe that process did not pick up our new required extensions thing.
On win and osx it works fine.
Forwarding to @sandy081 and @joaomoreno the extension people.

@weinand It turns out we are hitting the race condition at build time in which the placeholder package.json files are overwriting the real ones.

We could drop the placeholder folders and move the two OSSREADMEs into another spot that is not considered an extension location.

True. For now I was thinking of simply filtering them out of the build.

I just cloned the VSCode repo and executed scripts/npm.sh install and then launched it, and pressing F5 I still get this error. Is this a bug, or am I supposed to still do something to get this working?

This is as designed, when you run vscode out of source the node debug is not packaged as an extension - it only gets packaged once you build the full vscode.
What you need to do is copy the node-debug from your vscode stable installation folder inside your user .vscode-oss-dev/extensions folder. That way the out of source vscode will pick up the built in node debug extension


Empty placeholder causing active label

If the placeholder on an input is empty, we shouldn't classify that as active.
Signed-off-by: Daniel Rix<EMAIL_ADDRESS>

Fixed by #1709

Are there any updates with this issue?

I just outright abandoned using this project and moved to MDL.
Another reason I abandoned was because of how #1746 wan handled and the general idea of a broken master and a broken  main site that maintainers kept refusing to fix.
This issue is just a testament to the maintainers that they don't care about the project anymore or they are more interesting in doing the work themselves as opposed to using PRs properly.


sip clients not being authenticated?

set up another asterisk to register with an invalid sip user/ext or password - can get default incoming menu
https://www.voip-info.org/asterisk-sip-allowguest/
https://www.voip-info.org/asterisk-sip-insecure

asterisk frontend has
[futel-prod]
canreinvite=no
host=futel-prod.phu73l.net
type=peer
;trustrpid=yes
;sendrpid=yes
insecure=port,invite
defaultuser=800
fromuser=800
; to be populated in sip_callcentric.conf
secret=
this lets frontend do:
exten => s,1,Dial(SIP/800@futel-prod)
futel-prod sends user to default-incoming
frontend has futel-prod and 800 in sip show peers
futel-prod has nothing
nothing shows up in futel-prod log before context dialplan starts going by


Fix UI Bugs for Labels

Fixes UI Bugs for Labels cc @lucferbux
Description

Before
Registered Model List View (Default State)

Registered Model List View (Hover Overflow Label)

Registered Model Details Edit View

After:
Registered Model List View (Default State)

Registered Model List View (Hover Overflow Label)

Registered Model Details -> Labels -> Edit

How Has This Been Tested?

Testing:

Go to Registered Model List view and verify that overflow label is visible by default.
Click a model, go to "Details" and verify the overflow label is shown by default.
Click "Edit" button to the right of the Labels section, and verify the "Add label" button is visible by default.

Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[x] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

[x] The developer has added tests or explained why testing cannot be added.
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

/lgtm


Lura toon denovo

Source information
Lura tonn 1.4.56
Source language
Português
Steps to reproduce
O WebView está funcionando, as atualizações estão funcionando, mas os capítulos não estão abrindo devido a um erro

Expected behavior
O app deveria abrir normalmente e o dowload deveria ocorrer normalmente
Actual behavior
Deu erro
Mihon/Tachiyomi version
0.17.0
Android version
Android 11
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

---Adicione um :+1: [reação] a [questões que você acha importantes].[reação]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/[issues você acha importante]: https://github.com/keiyoushi/extensions-source/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

Duplicate of #6468


File

@BrooklinJazz I just finished the File drills, but I got stuck on this exercise, can you help me with it, please?
Use [File.stream!/3] and [Stream.filter/2] to filter in lines from multi-line.txt that contain numbers less than or equal to 3.

Hi Paulo!
This one is a bit tricky, because it has many edge cases depending on how you decide to implement it. I think I may remove it from the exercises, or make it clear what you have to handle.
Specific Solution (brute force)
In the simplest case, we can assume we only need to filter for line 1, line 2, and line 3 rather than lines with any number or numbers. You've already shown you can split the lines into a list, so to do this, you could filter that list by if each element contains 1, 2, or 3.
There are a few different methods. Here's one:
File.stream!("multiline.txt")
|> Enum.filter(fn line ->
  Enum.any?(1..3. fn integer -> String.contains?(line, "#{integer}") end)
end)

This handles our exact multi-line.txt file. However, it doesn't handle if the string contains other numbers such as 11.
General Solution
If we instead need to handle any numbers, we can use Regular expression.
For example, we could scan all numbers in a string using the \d+ regular expression, then check if each number is less than or equal to 3.

Also, you made the base branch of this PR DockYard Academy, rather than your fork, so I'm going to close it.


Artifact in depth images

Hi,
when visualizing the depth images from the simulator using the code, I see some horizontal lines artifacts.

Could you please tell me why these artifacts are showing and how I can solve that issue ?

@baotruyenthach @vmelan @andyzeng
hi, please help me how to remove the lines in the heightmaps?
thanks!


Update cachestat examples for kernels < 5.16 and add comments for 5.16+

According to the discussion in https://github.com/cloudflare/ebpf_exporter/issues/370:

Updated instrumented probes for operation on kernels < 5.16;
Added commentary for adapting the example to work on 5.16+ kernels;
Removed kprobe instrumentation in favor of kfunc and tracepoint;
Replaced ksym decoder with enum structure and static_map;
Updated label names to be more human readable.

With CI running a newer kernel, you need to update this as well:

https://github.com/cloudflare/ebpf_exporter/blob/master/Makefile#L25-L30

When testing locally, I see that cache_writes and page_mark_dirties are identical:
ivan@vm:~$ curl -s http://ip6-localhost:9435/metrics | grep cache_ops
# HELP ebpf_exporter_page_cache_ops_total Page cache operation counters by type
# TYPE ebpf_exporter_page_cache_ops_total counter
ebpf_exporter_page_cache_ops_total{operation="cache_access"} 98
ebpf_exporter_page_cache_ops_total{operation="cache_writes"} 2930
ebpf_exporter_page_cache_ops_total{operation="page_mark_dirties"} 2930

Here are the stack traces for both on v6.9-rc3:
        __traceiter_writeback_dirty_folio+76
        __traceiter_writeback_dirty_folio+76
        __folio_mark_dirty+560
        mark_buffer_dirty+188
        __block_commit_write+192
        block_page_mkwrite+284
        ext4_page_mkwrite+1160
        do_page_mkwrite+100
        do_wp_page+368
        __handle_mm_fault+2808
        handle_mm_fault+364
        do_page_fault+292
        do_mem_abort+80
        el0_da+48
        el0t_64_sync_handler+192
        el0t_64_sync+408

        mark_buffer_dirty+0
        block_page_mkwrite+284
        ext4_page_mkwrite+1160
        do_page_mkwrite+100
        do_wp_page+368
        __handle_mm_fault+2808
        handle_mm_fault+364
        do_page_fault+292
        do_mem_abort+80
        el0_da+48
        el0t_64_sync_handler+192
        el0t_64_sync+408

It looks like both are called unconditionally from block_page_mkwrite:

https://github.com/torvalds/linux/blob/v6.9-rc3/fs/buffer.c#L2623-L2625

I don't think we need two counters for one thing.

@bobrik, interesting behavior!
Locally, both counters have different values for me:
$ uname -r
6.1.0-0.deb11.6-amd64

$ curl -s localhost:9435/metrics -s  | grep page_cache_ops_total
# HELP ebpf_exporter_page_cache_ops_total Page cache operation counters by type
# TYPE ebpf_exporter_page_cache_ops_total counter
ebpf_exporter_page_cache_ops_total{operation="cache_access"} 1.3989073e+07
ebpf_exporter_page_cache_ops_total{operation="cache_writes"} 472184
ebpf_exporter_page_cache_ops_total{operation="page_mark_dirties"} 295110

Stack traces:
$ bpftrace -e 'tracepoint:writeback:writeback_dirty_folio,kprobe:mark_buffer_dirty { @[kstack]=count();}
...
@[
    mark_buffer_dirty+1
    __block_write_begin_int+676
    block_page_mkwrite+227
    ext4_page_mkwrite+650
    do_page_mkwrite+79
    do_fault+700
    __handle_mm_fault+1649
    handle_mm_fault+221
    do_user_addr_fault+460
    exc_page_fault+113
    asm_exc_page_fault+34
]: 943
@[
    mark_buffer_dirty+1
    __block_commit_write.constprop.0.isra.0+85
    block_page_mkwrite+345
    ext4_page_mkwrite+650
    do_page_mkwrite+79
    do_fault+700
    __handle_mm_fault+1649
    handle_mm_fault+221
    do_user_addr_fault+460
    exc_page_fault+113
    asm_exc_page_fault+34
]: 943
@[
    __folio_mark_dirty+504
    __folio_mark_dirty+504
    mark_buffer_dirty+256
    __block_write_begin_int+676
    block_page_mkwrite+227
    ext4_page_mkwrite+650
    do_page_mkwrite+79
    do_fault+700
    __handle_mm_fault+1649
    handle_mm_fault+221
    do_user_addr_fault+460
    exc_page_fault+113
    asm_exc_page_fault+34
]: 944
@[
    __folio_mark_dirty+504
    __folio_mark_dirty+504
    mark_buffer_dirty+256
    __block_commit_write.constprop.0.isra.0+85
    block_page_mkwrite+345
    ext4_page_mkwrite+650
    do_page_mkwrite+79
    do_wp_page+534
    __handle_mm_fault+2524
    handle_mm_fault+221
    do_user_addr_fault+460
    exc_page_fault+113
    asm_exc_page_fault+34
]: 1700
@[
    mark_buffer_dirty+1
    __block_commit_write.constprop.0.isra.0+85
    block_page_mkwrite+345
    ext4_page_mkwrite+650
    do_page_mkwrite+79
    do_wp_page+534
    __handle_mm_fault+2524
    handle_mm_fault+221
    do_user_addr_fault+460
    exc_page_fault+113
    asm_exc_page_fault+34
]: 1713

As far as I understand, the main fork occurs in this condition - https://github.com/torvalds/linux/blob/4fe89d07dcc2804c8b562f6c7896a45643d34b2f/fs/buffer.c#L2526
(In the latest version of the kernel, this code was rewritten a little, but again, as far as I can tell, the logic has not changed - https://github.com/torvalds/linux/commit/fe181377a23cce5987fc32f1877cfcd223561609)
Therefore, I am not sure that both counters always duplicate each other. What do you think about it?

It's probably that just my vm exhibits this behavior. I don't see it in production.
You should still update this before I can merge:

https://github.com/cloudflare/ebpf_exporter/blob/master/Makefile#L25-L30


Can not connect thermal printer

Hi owner.
Thank you for your sdk. But I can not connect with my thermal printer.
I got this error:
2022-01-23 20:50:45.449003+0700 HYDemo[17125:3633506] [CoreBluetooth] API MISUSE: <CBCentralManager: 0x280225300> has no restore identifier but the delegate implements the centralManager:willRestoreState: method. Restoring will not be supported
2022-01-23 20:50:45.476559+0700 HYDemo[17125:3633506] [CoreBluetooth] API MISUSE: <CBCentralManager: 0x280225300> can only accept this command while in the powered on state

Could you please check? Many thanks!

Please try to connect your thermal printer with Swift-Demo in Example

I tried both Swift and ObjC and got this message.
I tried version 1.4.0, still can not connect but does not received this message.

Ok, I see, I want to know what brand of printer you are using?

Is the phone bluetooth turned on?

https://www.google.com/search?q=apos+p100
Here is my printer.
Of course, I turned it on.

I can connect successfully with this framework.
https://github.com/KevinGong2013/Printer

There is a connection check in the SDK. Currently, only the printers of Xiamen Hanyin Electronic Technology Co., Ltd. can be connected.

@CodeFeel
Could you please make it can connect to other kind of printers?

I'm sorry, I'm afraid this won't work;
If you use our company's printer, this is ok


Reduce  container ID in event to 12 characters

Event logs the full ID of containers, it takes lot of places in the screen and make it hard to read other useful information.
Thu, 11 Jun 2015 11:34:50 +0000   Thu, 11 Jun 2015 11:34:50 +0000   1         nginx-controller-6df80   Pod                     spec.containers{nginx}              killing            {kubelet <IP_ADDRESS>}         Killing 08b2ba60914f1997d22669d2c1bce174fb9154350e143a224b48808a939f9072
Thu, 11 Jun 2015 11:35:23 +0000   Thu, 11 Jun 2015 11:35:23 +0000   1         nginx-controller-904vw   Pod                     implicitly required container POD   started            {kubelet <IP_ADDRESS>}         Started with docker id 381491cf5002fed558ae809db44a391755dbd0ccb1e722d1d0241bf58cbd298d

When using docker ps, it shows only the first 12 characters of the id, and docker inspect can take this as parameter or auto completing the full ID.
$ docker ps
CONTAINER ID        IMAGE                                  COMMAND                CREATED             STATUS              PORTS               NAMES
381491cf5002        gcr.io/google_containers/pause:0.8.0   "/pause"               7 minutes ago       Up 7 minutes                            k8s_POD.ef28e851_nginx-controller-904vw_default_f28c9688-102d-11e5-beea-fa163e837eb3_c3f25fb1
$ docker inspect 381491cf5002
$ docker inspect 381491cf5002fed558ae809db44a391755dbd0ccb1e722d1d0241bf58cbd298d

Can we do the same thing as docker do, any put more detailed information in the event as mentioned in #6532?

I think we'd happily take a PR to do this... ;)

Fixed by #9706. Thanks @hurf!


Remove examples from pyproject.toml

It is quite annoying to have to go through all these known errors when looking the mypy output for other files

/test

How about removing example from pyproject.yaml?

Do we want to fix annotations of these files?

/test

I'm thinking of checking examples and test codes with￼ allow-untyped-defs so that we can verify the correctness of types in PPE code base, without adding type annotations to examples and tests.


Special Characters along with Alpha and Numeric

login to page
create new crisis
Copy and Paste
"a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!"
giving a Server Error in '/' Application. issue

went to /Disaster/Create
Entered a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!a1!
page returned errors
•The field Disaster name must be a string with a maximum length of 50.
•Disaster name cannot have special characters.

I'm working on this.

@ryan-mcguire can you confirm that it's working okay now? I think it got fixed since the original issue was put in.

You're correct... this is indeed fixed.

Closing per above converstation


[SEASK-71] TPDM Starter Kit - Quick Start - Packer

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Midterm -- 02 Apr 2024

Read the problems: FI6004-01-2023-01_UTS_01Apr2024_1400_v5.pdf
Answer each problems in separated file and save them as PDF files.
Name the files with format NIM_ProblemNumber,
e.g. 10240007_1.pdf, .., 10240007_5.pdf.
Update it before 9 April 2024, 2100 here.

Here is my work for the midterm of this class:
Problem 1: https://github.com/halserach/SolusiUTSFI5001_2324_2/blob/main/20223014_1.pdf
Problem 2: https://github.com/halserach/SolusiUTSFI5001_2324_2/blob/main/20223014_2.pdf
Problem 3: https://github.com/halserach/SolusiUTSFI5001_2324_2/blob/main/20223014_3.pdf
Problem 4: https://github.com/halserach/SolusiUTSFI5001_2324_2/blob/main/20223014_4.pdf
Problem 5: https://github.com/halserach/SolusiUTSFI5001_2324_2/blob/main/20223014_5.pdf
Thank you very much!

Here are my works for the midterm examination:
20223014_1.pdf
20223014_2.pdf
20223014_3.pdf
20223014_4.pdf
20223014_5.pdf
Thank you!


Enhance error reporting to broker from server

so that Query execution error behaves like Query cancellation error and reports on which server the error occurs

Codecov Report

Merging #10531 (71dc5f5) into master (114a81e) will increase coverage by 40.92%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             master   #10531       +/-   ##
=============================================
+ Coverage     27.90%   68.83%   +40.92%
- Complexity       58     6262     +6204
=============================================
  Files          2087     2112       +25
  Lines        112306   113086      +780
  Branches      16918    17011       +93
=============================================
+ Hits          31340    77838    +46498
+ Misses        77869    29773    -48096
- Partials       3097     5475     +2378

Flag
Coverage Δ

integration1
?

integration2
24.34% <66.66%> (+0.17%)
:arrow_up:

unittests1
67.84% <66.66%> (?)

unittests2
13.88% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/core/transport/InstanceRequestHandler.java
64.06% <0.00%> (+21.87%)
:arrow_up:

...core/query/executor/ServerQueryExecutorV1Impl.java
82.02% <100.00%> (+5.63%)
:arrow_up:

... and 1549 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add self.batch_set_item and self.batch_get_item for cutmix

Applies the new setters and getters from PR 943 to batches for cutmix

@eracah could you wait until Wednesday to merge this one? I'm going to cut the v0.7.0 branch most likely on Tuesday, and I'm thinking we release the batch type removal for all algorithms together....probably in v0.7.1?

@eracah could you wait until Wednesday to merge this one? I'm going to cut the v0.7.0 branch most likely on Tuesday, and I'm thinking we release the batch type removal for all algorithms together....probably in v0.7.1? (Alternatively, if you can finish all algorithms by Tuesday, then let's get all of them in 🔥 )

Haha that's some good motivation

Subclassing algorithms wasn't part of the agreed upon design. It's certainly flexible but you'd need a lot more boiler plate and knowledge of the algorithm.

Subclassing algorithms wasn't part of the agreed upon design. It's certainly flexible but you'd need a lot more boiler plate and knowledge of the algorithm.
Had envisioned callables passed to init for the messy edge cases not covered by indexing.

We do have to add four new arguments: [get, set] x [input, target], but still easier than subclassing


chore: prevent auto-merge of major deps bump

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 29.635%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3676

Relevant Lines:
13047

💛  - Coveralls


fix #3480 - copy doesn't work on Safari

Closes https://github.com/emilk/egui/issues/3480
I've tested this on Safari and Chrome on macOS Sonoma 14.0.
Could be improved to only call event.preventDefault() if runner.logic() actually performed a copy, but I don't see a way to get that information out with the current API.

I also noticed middle clicking a "source code" URL in egui.rs triggers Safari's popup blocker. This is likely the same issue - eframe should run logic headlessly from inside the click handler so it inherits the "user interaction" permissions when processing the click.


feat(wallet): Add Gap Limit Options

Description

Upgrades Beignet to 0.0.23.
Implements gapLimitOptions from upgrade.

New wallets default to a lookBehind of 5 and a lookAhead of 1 to limit queries to Electrum.
Restored wallets temporarily use a lookBehind of 20 and a lookAhead of 20 during the initial scan. Once this scan finishes it reverts back to the default lookBehind-lookAhead of 5-1.
If you think the 5-1 defaults are low, we can try something higher like 5-5, but restored wallets may come close to the limits of what a given Electrum server will tolerate for extremely active users or heavy testing sessions.

Adds two dev-only views.

Monitored Address Types: Found in "Settings->Advanced->Bitcoin Address Type" beneath "Monitored Address Types" allowing us to adjust what address types are actively being monitored. An app restart is required for changes to take effect.
Gap Limit: Found in "Settings->Advanced->Gap Limit" allowing us to adjust the gap limit in Bitkit as needed for testing/debugging.

Updates broadcastTransaction, getReceiveAddress & getBalance methods.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Tests

[x] No test

Screenshot / Video

QA Notes

Restores should continue to work as expected. Once a restore is successful and the initial scan is complete we should be able to observe that the gap limit lookAhead and lookBehind were reverted to their default of 5-1 in "Settings->Advanced->Gap Limit".

How does lookBehind: 20 works during wallet restore, it still can't go behind index 0, right?

How does lookBehind: 20 works during wallet restore, it still can't go behind index 0, right?

A lookBehind of 20 is not necessarily needed during the initial scan for a restore since we're scanning all addresses as we generate them anyway, it's just there to conform to the standard/default.


Design QA - Placing a bet, Wager field

Right now when a user submit a bet on the Betslip, "Wager" field is populated with the max order amount available, but this behavior is incorrect: The user should enter the amount of $ he wants to bet, so it would be like this:

much better. closing


Investigate bookList not updating automatically after inserting a new book

While reviewing the pull request for #164 we noticed random failures in robot tests after inserting a new book. The results could be verified outside of robot tests, too.
The issue is that after a book is inserted into the database and the book list is updated, the new book does not appear. Instead, the server returns a 304 response with outdated list of books. Insertion appears to happen correctly, as by refreshing the page the new book appears.
The issue likely has something to do with the LRU cache in mysql2, which is not that well documented. The npm page https://www.npmjs.com/package/mysql2 states "If you execute same statement again, it will be picked from a LRU cache which will save query preparation time and give better performance".
Looks like this is a cache invalidation issue. There are also others facing similar issue: https://github.com/sidorares/node-mysql2/issues/929

As mentioned in the similar issue link, the problem seems to boil down to transactions, however adding book or fetching all books doest not use transactions, only OIDC authentication uses transactions so the core issue might be in the authentication. When the book is added and then in the same function (backend) all books are fetched for logging purposes the newest addition is already in the list before the successful response has even been returned to frontend. Potential solution would be to send a list of all books in the return statement after adding a new book, however this might mess up pagination on the page so it would require extra steps in frontend.

Great job @Lauri-Iivarinen !
The potential solution would likely be feasible, but as you said, it would require some changes to both the backend and frontend and would likely complicate the app even more. I'm also concerned that we will find similar issues in the future with any feature we develop that would require adding data and updating the view.
I happened to notice that we are using an outdated version of the mysql2 package. Our version is 2.3.3 and the latest is 3.6.1: https://github.com/LibraryProjectGroup/library-project-backend/blob/0c6a8456f33eaccf4bad4b9c439c34442240ab4c/package.json#L24-L25 https://www.npmjs.com/package/mysql2?activeTab=versions. Maybe we should first try to update the dependency and see if the library was to blame and has been fixed?
Also, there seems to be a mysql dependency in our package.json that probably should be removed...

Hi! Absolutely random person from internet asking for help with the absolutely exact issue. Have you figured out the problem? Is really the only solution to not use transactions?

Hello. Unfortunately we did not resolve the issue but since the problem was quite small for this project we merely bypassed it by changing how backend returns data in couple occasions.

Hah, thanks for info! I was able to solve it by adding one more query  - "SELECT 1 WHERE 1 = 0",  which triggered LRU to cache this specific query and not the one i needed to. Since then, i only got right data.


promxy upgrade

WIP change

Was this opened accidentally? Usually, a WIP PR should be opened if you want to show something for early discussion before doing the real review. Having this open for two weeks without further comment is confusing for the maintainers.

Yeah this isn't meant for review yet. it's ok to close this review.


Add armv7m assembly strcpy.

Summary
Assembly version of strcpy for armv7m.
Impact
Replace common strcpy if CONFIG_ARMV7M_STRCPY is enabled
Testing
tested using a testcase designed for arch libc function, see https://github.com/apache/nuttx-apps/pull/1662

Very nice @XinStellaris did you execute some benchmark test to check how much is this version faster?

Very nice @XinStellaris did you execute some benchmark test to check how much is this version faster?

Yes ,I have tested on STM32F429-disc1:
native C                                                                  assembly
strcpy total(run 25 times) cpu cycles 27081          strcpy total(run 25 times) cpu cycles 7115
strcpy average cpu cycles 1083                             strcpy average cpu cycles 284
That is nearly 1/4 of the cpu cycles of native C

@pkarashchenko could you review it ?


adding waf customer info line

@winthrop28 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


CREST fleet fixes

I've gone with the full media type as it's the exact string you will be using in the Accept/Content-Type header when making requests. As far as marking them as such, that would probably be a good idea. Placing the media type above the sample body with no label might leave some people confused.
As they are dealing with different operations on the same resource type (view, create, edit, delete) I feel it would be best to keep them on the same page: scrolling through a single page is easier than moving between four separate pages.

@CarbonAlabel I've moved my autogen from uid to mime type labeling them as ###Mime Types.  I will start using the term mime type instead of uid in my discussions.
As for the mime type per page, currently the worst case is two mime types per a given endpoint.  i.e. 2 pages not 4.


Can you export this as a type like PrinterType?

https://github.com/seokju-na/react-thermal-printer/blob/65b23afdb255a139eafa03a7dee0fcf95bd04fe1/packages/react-thermal-printer/src/components/Printer.tsx#L31

You can use ComponentProps type from react module.
import type { ComponentProps }  from 'react';
import type { Printer } from 'react-thermal-printer';

type PrinterProps = ComponentProps<typeof Printer>;


cargotest: Fix with_*_does_not_contain to support [..] and macro matching.

I changed it so that it is essentially the opposite of with_*_contains to keep it symmetric.
Any in-flight PRs using the old style will need to be updated (else they will incorrectly silently pass).  Alternatively, we could rename the method to avoid that.
The following tests contained brackets, so they were not checking what they thought they were checking.  I did a cursory look at them, but perhaps someone else could double-check that they make sense.  Asserting what doesn't happen can be tricky since there is an infinite number of things that won't happen.  Preferably a test would assert that it appears in one scenario and not another (like incremental_profile does), but some of them don't or can't.
build::incremental_profile
build::incremental_config
build::cargo_compile_with_workspace_excluded
build::build_all_exclude
build::targets_selected_default
check::targets_selected_default
check::check_filters
rustc::targets_selected_default
rustc_info_cache::rustc_info_cache
warn_on_failure::no_warning_on_bin_failure
warn_on_failure::warning_on_lib_failure

BTW, would you be interested in a PR that adds some documentation to cargotest?
I've discovered things I didn't know where there.  I think some docstrings on some of the methods, and a short guide for new contributors would be helpful.

Awesome, thanks!
@bors: r+
I'd definitely be up for documentation in cargotest :)
It's pretty disorganized right now and could definitely use some love.

:pushpin: Commit e7896a2 has been approved by alexcrichton

:hourglass: Testing commit e7896a2f6831eb223c273420d968446c883f47d3 with merge a04e2e5bd9a54332328a4c04ca6389fe31f4f4e1...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a04e2e5bd9a54332328a4c04ca6389fe31f4f4e1 to master...


remove globals

I was looking for a good nice small lib, unfortunately this uses global vars... which is a pretty big nogo.

Yes (1 global sortable, if I am not mistaken), this is necessary for people who do not use some kind of module system.
However feel free to send a PR to allow an additional build which is not a UMD but just a module.
Of course you could also send a PR that changes the src to be es6 module based and add a build step for a UMD, but this would be quite a bit (but good) PR.


Node.js exposed API is http://localhost:5000/hello but in react in file "authConfig" endpoint is  http://localhost:5000/api/todolist" which is wrong.

Please help me as i am student, our node js only exposed api http://localhost:5000/hello but in Front end  we put  http://localhost:5000/api/todolist into our file name authConfig and this route does not exist in the nodejs. I am looking forward to hear from anyone soon.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb86b02a-e703-09d7-01ee-48b621ab7967
Version Independent ID: dc9d5ad2-817e-c769-2890-d29805811a82
Content: Configure authentication in a sample React SPA by using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/configure-authentication-sample-react-spa-app.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@Jamal8548
Thank you for your feedback. You're right, the API endpoint is /hello and not /api/todolist. We've made the correction, but the change will take a few hours before it goes live.

#assign: kengaderdus

@kengaderdus Thanks for acknowledging! After fixing this route issue, please test your application as when you click on the HelloApi get request is not reaching to the backend and when you go into the network tab it will show you error. Secondly in documentation it is confusing for readers that what this application supposed to do after clicking on this button. It would be really helpful if you would update that part of doc also.

@Jamal8548
Thank you again for catching that. It has been fixed.

@kengaderdus just one short query, How Azure AD B2C authenticate with NODEJS( GraphQL-Apollo Server) API and ReactJs?
This sample react app is authenticating with NODEJS (express js REST API) but there is nothing written about react App with Nodejs (GraphQL-Apollo Server)API authentication. Please help me as i want to apply authentication same as written in the documentation for REACT -NODEJS(but with graphQL-Apollo Server) but there is no clue on the internet about it. It would be really helpful if you would provide an example for this in docs also. GraphQL (API) is most widely using now.

@Jamal8548
Thank you for your question. I don't have an answer at the moment. I'll comment back when I've something. Meanwhile, I encourage you to post you question in Microsoft's Q&A forum.
Thanks.

@kengaderdus would you please give me your valuable feedback in this regard. I am student.
USE CASE: My project is based on React(Front end) -NodeJs(API). I want authentication and authorization (both) in my project. Currently, I tried it with Azure AD B2C but how can I get authorization in it.  I researched about it and found that it may get users from Azure AD (graphAPI) before generating a token or something like that... so please recommend the best solution for the upper use case. I want the best solution which is less in cost and effective. As i read that with Azure AD B2C first 50,000 users / month are free and i could not find how many users are free with Azure AD and in the end please recommend me that should i go with only Azure AD (it's expensive) Or i should go with Azure AD B2C(50,000users/per month free- less cost) but one drawback that authorization is not a feature of Azure AD B2C, so should i go with the above recommended solution that to get users from Azure AD for authorization and use Azure AD B2C? Your valuable feedback would be highly appreciated for the above chaos.


Retrieve network information for external validator from beacon node endpoint

PR Description
Currently, when running a remote validator client (typically using the teku vc ... subcommand), a --network option needs to be specified. The value provided to this option can either be the name of one of a set of defined networks (mainnet, prater, etc.), or a path to a configuration file, in the case of a custom network. This information is used to load the relevant network presets and constants that a VC will need.
However, because a beacon node already exposes some of this information through its config API (/eth/v1/config/spec), a VC can technically fetch these details directly, without requiring the cli option.
This PR enables this feature through a new option value, auto, added to the --network option of a validator-client subcommand. All other values to the --network option values have been deprecated in favor of this value.
Example: teku validator-client --network=auto
Fixed Issue(s)
This PR fixes #3530
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Sorry for the delay in looking at this one.  It's on my list for today.

Hi, sorry for the delay on this (again), I've gotten drawn into preparing for a round of merge interop testing and lost track of this.  Will make sure it gets looked at today.

no worries, thanks Adrian

Overall, this change looks good. I had a bit of a play around and it's mostly doing what I expect, just a little cleanup on the sleep timeout and then it's probably in pretty good shape!
I really like the idea of downloading the spec and using that, it should be a good addition to the validator-client.

sure! done. thanks Paul


docker compose up doesn't work with M1

It's a known issue that some docker containers don't work with the M1 chip. https://github.com/docker-library/mysql/issues/778
The version that the project is using specifically doesn't work with m1 throwing
failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: no match for platform in manifest sha256:7cf2e7d7ff876f93c8601406a5aa17484e6623875e
64e7acc71432ad8e0a3d7e: not found

However, using the latest image seems to work. Maybe we can pin the latest version (8.x) instead of 5.7 here?
-    image: mysql:5.7
+    image: mysql:latest

Hi @prajjwol, thanks for bringing this up! We use MySQL 5.7 on production so we pin the image to match.


[FEATURE] zip/  very minimal equal

Requires: https://github.com/jfalcou/eve/issues/718
We want the basic implementation of eve::algo::equal (equivalent to std::equal).
The implementation at this point should be something like:
bool operator()(f, l, f1, pred) const {
   zip r {f, l, f1};
   return eve::algo::any(r.begin(), r.end(), [&](auto xy) { auto[x, y] = xy; return eve::not_(pred(x, y)); });
}

bool operator()(I1 f, S1 l, I2 f1) const {
   /*convert to common iterator type I1, I2*/
   return operator()(f, l, f1, eve::equal);
}

zip under the hood should just probably be two tuples, or tuple + size, not zip_iterator because it can't be.
P.S. equal of course should call all and not any but let's make the whole thing work first.

Now done


Update rancher/hyperkube

Need to update rancher/hyperkube to v1.21.5+

I bumped into this issue in an air-gapped install and fixed it by manually adding the new version to rancher-images.txt, re-assembling the tarball via the provided rancher-save-images.sh script and then loading the resulting tarball into the private registry
Bottom line: I just wanted to leave a reminder to make sure that rancher-images.txt is also updated.

@MrMonster911 This should be covered by https://rancher.com/docs/rancher/v2.5/en/admin-settings/k8s-metadata/#air-gap-setups, if not, please create a new issue with what you are seeing.

@superseb Sorry, I think I was being a bit TOO terse, I was seeing this during a fresh, air-gapped installation of Rancher 2.6.0, so I don't think that link would have been available to me yet (or it might, I don't 100% remember when I was presented with the issue), anyway, it wouldn't even be an issue, in the first place, if "rancher/hyperkube:v1.21.5-rancher1" was in the rancher-images.txt file listed in the GitHub page of the version 2.6.0 release, this seems, to me, like the intention? Otherwise the air-gap install procedure should probably mention this? But, regardless, if the "fix" isn't simply to also put this string in the rancher-images.txt file, this ticket probably isn't the place for my reminder/request?

@MrMonster911 v2.6.0 was shipped with v1.21.4, so if it is showing v1.21.5, it does have access to releases.rancher.com to get updates or something else is happening. Please file a new issue with steps to reproduce so we can investigate. The published images for a release should be enough to provision clusters in airgap (as that are the images for that release), the only way to get newer versions is if Rancher retrieves them from our location remotely (releases.rancher.com)

@superseb I just checked, and you're absolutely right, the environment is not as air-gapped as I was led to believe, which explains the situation perfectly, the private registry only had access to what I'd manually put in there, but the environment (which, to be fair isn't truly air-gapped, but meant to simulate an air-gapped environment) does, indeed have access to releases.rancher.com.
Sorry for wasting everyone's time, I'll make sure the environment more closely resembles an air-gapped one instead!
Thanks for your prompt responses, it's very much appreciated!


web_benchmarks_canvaskit bench_picture_recording.canvaskit.estimatePaintBounds.average regression

Looks like this engine roll: https://github.com/flutter/flutter/pull/55351.

Chatted with @dnfield (who chatted with @yjbanov) offline. We believe that we can  remove the TODAY label as the canvaskit backend is still experimental.

See https://github.com/flutter/flutter/issues/55389

Thanks Jason! Closing this duplicate in favor of #55389.


[GCViewer] Sync OpenFileDialog history with plugin preferences component

Sync history of OpenFileDialog with plugin preferences component.

Own implementation of OpenFileHistoryAdapter.java with wrapping PreferencesComponent.java could be used in OpenAction.java

Maybe it's could be made in more general way, so Histogram component properties could be used in the same way with little changed code.

Short plan

Make all properties global(application level)
Both - viewer and histogram parts must interact with common interface to keep their properties(eg.  CommonGCPluginsHistory)
Settings like capacity of max num of stored properties must be configurable via gui on settings tab


sentencepiece: 0.1.94 -> 0.1.95

Motivation for this change
Changelog:
https://github.com/google/sentencepiece/releases/tag/v0.1.95
This was merged before in #108756, but I reverted the version bump in #108920 since upstream has updated the 0.1.95 tag several times. But is seems that the dust has settled (6 days since the last tag change), so it should be ok to update now.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109503 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

python37Packages.sentencepiece: log was empty
python38Packages.sentencepiece: log was empty
python39Packages.sentencepiece: log was empty
sentencepiece: log was empty

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109503 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

python37Packages.sentencepiece: log was empty
python38Packages.sentencepiece: log was empty
python39Packages.sentencepiece: log was empty
sentencepiece: log was empty

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109503 run on x86_64-linux 1

4 packages built:

python37Packages.sentencepiece
python38Packages.sentencepiece
python39Packages.sentencepiece
sentencepiece

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109503 run on x86_64-linux 1

4 packages built:

python37Packages.sentencepiece
python38Packages.sentencepiece
python39Packages.sentencepiece
sentencepiece


Queue does not persist when application is closed

Hi, I've  issue when closed the app and then run again, the data in queue don't persist. Any solutions?

This feature is critical to me as well (as users can sometimes stay offline for a few days). Couldn't queued items be stored locally in a lightweight database? :)

@alexisthual Did you find solution for this?

No I didn't! :)

I have the same issue, this is most likely to be handled by your app not by QueueLink itself. This is tricky due to how Apollo Operation is constructed with its Forward function and Observer being both closely tied to the specific network request.
This being said, it would be extremely helpful If enqueue function of QueueLink was typed as protected not as private.
@helfer


Q: One partition, many consumers

Asking here as per the README instructions.
I need to consume a topic that has one partition and I am trying to understand two scenarios in which the same consumer group could have two consumers:

Setting up two machines for high-availability.
Coexistence of listeners in deployments of code updates without downtime.

I know that one consumer group normally has less consumers than partitions (or equal), but given that partition assignment is done by the broker, I don't quite see a technical reason why the situation above couldn't work.
Indeed, in my tests ruby-kafka seems to handle this just fine. The active consumer processes messages, and the additional ones (I launched two of them) are there doing nothing, though they keep checking something every second:
D, [2018-02-20T17:44:23.083772 #7906] DEBUG -- : Waiting for response 28 from ubuntu:9092
D, [2018-02-20T17:44:23.084096 #7906] DEBUG -- : Received response 28 from ubuntu:9092
I, [2018-02-20T17:44:23.084179 #7906]  INFO -- : There are no partitions to fetch from, sleeping for 1s
I, [2018-02-20T17:44:24.084763 #7906]  INFO -- : There are no partitions to fetch from, sleeping for 1s
I, [2018-02-20T17:44:25.085194 #7906]  INFO -- : There are no partitions to fetch from, sleeping for 1s
I, [2018-02-20T17:44:26.087011 #7906]  INFO -- : There are no partitions to fetch from, sleeping for 1s
...

The command-line utility distributed with Kafka (bin/kafka-console-consumer.sh) seems to sit there just idle, though ruby-kafka seems also idle with default logger, so perhaps it only appears to be idle.
Do you know what is the behavior of the broker when a consumer is connected but cannot assign a partition to it because there are as many consumers as partitions for its consumer group? I have not been able to find documentation about it in the Kafka official docs.
What is ruby-kafka trying there every second? Do consumers need to check for rebalancing actively instead of being idle and be notified by Kafka?
Could it be the case that the Scala client is also retrying as ruby-kafka does? I mean, maybe that's the only possible behavior?
Do you see anything that's fundamentally/technically wrong with this approach aside from nagging Kafka every 1s for days?

Hi @fxn,
The behaviors of your consumers are totally normal and intentional. By the design, each partition of a topic is exclusively consumed by a consumer; and a partition could not be shared between many partitions. This design ensures the consuming order of the same partition. The consumer group must respect this principle when they decide the group assignment. Therefore, when the number of consumers is greater than the partitions, some of them just idle and do nothing. This behavior is not written in the official document, this is the only possible correct behaviors for the clients to implement. From the environments that I'm working on, as well as from some of my friends', the best practice to scale up is to increase the number of partitions.
About your second question, in the consuming process, Kafka takes a really passive role, while the consumers take an active role. It means that the clients keep polling from Kafka; there aren't' any mechanism for Kafka to actively notify consumers. Subsequently, in your example, when the consumer tries to fetch the message batch from Kafka, it receives an error message about the assignment situation and just simply for a number of seconds and tries again.
I don't know about the Scala client, so I couldn't answer your question about this. But in my knowledge, the Java relative languages are the first class in Kafka world. So, it actually many steps ahead of ruby-kafka (feature-wised).
One more thing, since the version 0.9, Kafka follows the client-side assignment design, which means that the partition assignment logic belongs to the client side. The broker does not involve in this process. ruby-kafka only supports round-robin assignment. You can get the assignment detail in lib/kafka/round_robin_assignment_strategy.rb.
Hope that would help 😄

Awesome reply!
Let me try to understand the impact of extra consumers in the client-side. Let's say we have one partition, one active consumer, and you launch three extra machines, each one with one consumer for that same consumer group.
Are those three extra consumers able to join the consumer group and then poll but receive no messages? If yes, is that poll call just bloking for poll.ms milliseconds? Or do they get an error from the broker?
I see there is a max.poll.interval.ms that defaults to 5 minutes. If the consumers are actually able to join the group and they keep polling, I guess this won't be reached (due to the 1s retries) and therefore they won't be kicked out of the group. Squares?

[snip] It means that the clients keep polling from Kafka; there aren't' any mechanism for Kafka to actively notify consumers. Subsequently, in your example, when the consumer tries to fetch the message batch from Kafka, it receives an error message about the assignment situation and just simply for a number of seconds and tries again.

Actually, fetching is not part of the consumer group API. Rather, the periodic heartbeat request that each consumer is required to send back to the group's controller broker is used to notify the consumers that a new "generation" of the group has been created, and that they need to rejoin, which will trigger another round of partition assignment. It's correct that this is done by the consumers themselves – one is selected as group leader by the broker and sends back the assignments.
@fxn in your scenario, the three extra consumers will simply sleep and periodically send in a heartbeat request (see heartbeat_interval for a way to configure the frequency). If the active consumer dies, it will either tell the broker with a leave request, if there's no time for that, the broker will notice once the heartbeat isn't sent. That would trigger a new group generation, and the response to the other consumers' heartbeats would indicate as such, causing them to rejoin, one to be selected as leader, and the partition to be assigned to one of the remaining three consumers.

@dash and the heartbeats of the idle consumers would trigger rebalances causing an overhead? Guess not, but let me confirm :).

There is only a rebalance, i.e. a new group generation (which leads to new assignments), if a group member comes or goes. So if one of the idle consumers fails to send in a heartbeat you'd get a rebalance. But that shouldn't happen – they send in heartbeats even when idle.

You definitely want to avoid having consumer come and go often – stability is key to performance.

@dasch don't know technically if heartbeats count for max.poll.interval.ms. Would the idle consumers be kicked out after that interval and trigger a rebalance?

I think that config is only used in the Java client, and thus not enforced by the brokers.

That is, if the Java client library doesn't get a poll call within that interval, it assumes that the user of the client is blocked or dead and proactively leaves the group.

It is true that that option is for Java client only. The broker doesn't have this config.

So the conclusion seems to be that this approach is technically sound. This topic doesn't have enough volume to justify several partitions for scalability purposes. If we don't need them either for the use cases above, then one partition is simpler.
Guys this help has been extraordinary, gotta have a beer if we ever meet in a conference. Thanks very much! ❤

No problem, let me know if you run into any issues 😄


Add British English preference to PR template

Pull Request

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#143  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 27, 6:21 AM EDT: A user merged this pull request with Graphite.


Installation from obsidian's plugins page is broken

I think the issue is that obsidian tried to install 0.1.5 version that is missing from the releases list

I have the same problem.

A new release is added. Thanks for the report!


CMake: ARCH roots issue

Describe the bug
I'm not able to build since https://github.com/zephyrproject-rtos/zephyr/pull/41301.
This is likely due to my local installation, but I can't get what should be updated.
For instance, when running west build -p auto -b nucleo_f401re samples/hello_world/, I'm getting the following error:
CMake Error at /local/mcu/zephyrproject/zephyr/cmake/arch.cmake:41 (message):
  Could not find ARCH=nucleo_f401re for BOARD=nucleo_f401re, please check
  your installation.  ARCH roots searched:

Issue shows up with with https://github.com/zephyrproject-rtos/zephyr/commit/254e35d61d59feca6e9b91fcc9ce7d3416917c22
I've tried to re-run source zephyr-env.sh with no success
Environment (please complete the following information):

OS: Ubuntu 18.04.6 LTS
Toolchain (e.g Zephyr SDK, ...): zephyr-sdk-0.13.2
CMake: 3.22.1
Python 3.8

Expected behavior
A clear and concise description of what you expected to happen.
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
Logs and console output
Here is the full log to the error:
$ west -vvv build -p auto -b nucleo_f401re samples/hello_world/
args namespace: Namespace(command='build', help=None, verbose=3, zephyr_base=None)
ZEPHYR_BASE=/local/mcu/zephyrproject/zephyr (origin: env)
args: Namespace(board='nucleo_f401re', build_dir=None, build_opt=[], cmake=False, cmake_only=False, command='build', dry_run=False, force=False, help=None, pristine='auto', source_dir=None, target=None, test_item=None, verbose=3, zephyr_base=None) remainder: ['samples/hello_world/']
source_dir: samples/hello_world/ cmake_opts: None
setting up build directory
setting up source directory
config dir-fmt: build
build is a zephyr build directory
build dir: build
pristine: auto auto_pristine: True
/local/mcu/zephyrproject/zephyr/build is a zephyr build directory
setting up source directory
sanity checking the build
/local/mcu/zephyrproject/zephyr/samples/hello_world is NOT a valid zephyr build directory
APPLICATION_SOURCE_DIR: /local/mcu/zephyrproject/zephyr/samples/hello_world
pristine: True
CACHED_BOARD: nucleo_f401re
-- west build: generating a build system
cmake version 3.22.1 is OK; minimum version is 3.13.1
Running CMake: /local/home/frq07517/.local/bin/cmake -DWEST_PYTHON=/usr/bin/python3.8 -B/local/mcu/zephyrproject/zephyr/build -S/local/mcu/zephyrproject/zephyr/samples/hello_world -GNinja
Including boilerplate (Zephyr base (cached)): /local/mcu/zephyrproject/zephyr/cmake/app/boilerplate.cmake
-- Application: /local/mcu/zephyrproject/zephyr/samples/hello_world
-- Zephyr version: 3.0.99 (/local/mcu/zephyrproject/zephyr)
-- Found west (found suitable version "0.12.0", minimum required is "0.7.1")
-- Board: nucleo_f401re
CMake Error at /local/mcu/zephyrproject/zephyr/cmake/arch.cmake:41 (message):
  Could not find ARCH=nucleo_f401re for BOARD=nucleo_f401re, please check
  your installation.  ARCH roots searched:

  /local/mcu/zephyrproject/zephyr
Call Stack (most recent call first):
  /local/mcu/zephyrproject/zephyr/cmake/app/boilerplate.cmake:387 (include)
  /local/mcu/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:24 (include)
  /local/mcu/zephyrproject/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:40 (include_boilerplate)
  CMakeLists.txt:5 (find_package)

I do not see that error building on dd3f251f1006ae84283acf60ddc2c7f2cefad1e6
and when my cmake is cmake version 3.21.1 is OK; minimum version is 3.13.1

@tejlmand Could you provide more details on error message:
Could not find ARCH=nucleo_f401re
Why would ARCH be the board ID ?

I can confirm this issue. I can reproduce it with CMake v3.22.2. No issues when using CMake 3.21.4.

This is caused by a bug in the CMake 3.22 PyPI package, ref: https://gitlab.kitware.com/cmake/cmake/-/issues/23187
and this code is triggering said bug: https://github.com/zephyrproject-rtos/zephyr/blob/5ee306944b37fac3143f30e759478c6e8a9d36a4/cmake/modules/arch.cmake#L32-L33
Looking into how we can restructure code, so we don't trigger the CMake bug.

see also: https://github.com/scikit-build/cmake-python-distributions/issues/221

I'm running into this issue from the Pigweed CI now only the check wasn't catching it. It's on CMake 3.24.2. Can we just get rid of the cmake version check? Or just ban cmake_path in favor of https://cmake.org/cmake/help/latest/command/get_filename_component.html?

I set priority medium because this is breaking downstream CIs (feel free to adjust)

I'm using 3.24.2 as well and I don't see this. Using the cmake that comes with Arch Linux.

It seems that the toolchain used to build cmake for our CI is the same as the one used for PyPI which is how we're coming across this. The issue still exists in 3.24.2 depending on how cmake is built. I propose that we remove the version check and just see if cmake_path returns the same path, thoughts @mbolivar-nordic?

thoughts @mbolivar-nordic?

No objections, but this is really a question for @tejlmand


Swupdate watchdog timeout not working

When running swupdate manually with for example swupdate -i image.swu, the update is installed on the unused partition (e.g. mmcblk1p5). On the following reboot (booting from mmcblk1p5) watchdog should start, giving me one minute to confirm the successful installation by running the complete_update.sh script. If this is not done within one minute (and please correct me if I'm wrong), watchdog should restart the system, which should result with the system booting into the previous partition (mmcblk1p4). This all works perfectly fine except for watchdog triggering the reboot.
The boot logs mention some issue with setting the timeout, but the default timeout should already be one minute. When using bg_printenv a timeout of zero seconds is shown.
From the boot log (whole_boot.log):
[  855.558516] watchdog: watchdog0: nowayout prevents watchdog being stopped!
[  855.565445] watchdog: watchdog0: watchdog did not stop!
[  855.608032] systemd-shutdown[1]: Using hardware watchdog 'K3 RTI Watchdog', version 0, device /dev/watchdog0
[  855.617961] systemd-shutdown[1]: Modifying watchdog timeout is not supported, reusing the programmed timeout.
[  855.627959] systemd-shutdown[1]: Watchdog running with a timeout of 1min.
[  855.939774] watchdog: watchdog0: nowayout prevents watchdog being stopped!
[  855.946646] watchdog: watchdog0: watchdog did not stop!
WDT:   Not starting watchdog@40610000
Watchdog started, timeout 60000 ms
Starting C:BOOT1:linux.efi with watchdog set to 0 seconds ...
[    0.000000] Kernel command line: console=ttyS3,115200n8 earlycon=ns16550a,mmio32,0x02810000 rootwait watchdog.handle_boot_enabled=0
[    2.168983] watchdog: watchdog0 running and kernel based pre-userspace handler disabled
[    5.557697] systemd[1]: Using hardware watchdog 'K3 RTI Watchdog', version 0, device /dev/watchdog0
[    5.566810] systemd[1]: Modifying watchdog timeout is not supported, reusing the programmed timeout.
[    5.576207] systemd[1]: Watchdog running with a timeout of 1min.

bg_printenv output after executing swupdate:
----------------------------
 Config Partition #0 Values:
in_progress:      no
revision:         2
kernel:           C:BOOT0:linux.efi
kernelargs:
watchdog timeout: 0 seconds
ustate:           0 (OK)

user variables:
----------------------------
 Config Partition #1 Values:
in_progress:      no
revision:         3
kernel:           C:BOOT1:linux.efi
kernelargs:
watchdog timeout: 0 seconds
ustate:           2 (TESTING)

user variables:

start_watchdog is also configured in the U-Boot environment:
$ sudo fw_printenv | grep watchdog
bootcmd=run start_watchdog; run distro_bootcmd
start_watchdog=if test ${watchdog_timeout_ms} -gt 0; then wdt dev watchdog@40610000; wdt start ${watchdog_timeout_ms}; echo Watchdog started, timeout ${watchdog_timeout_ms} ms; fi
watchdog_timeout_ms=60000

Is it intendet to only switch back to the original partition when triggering the reset manually?

The watchdog phase starting with the firmware (or, on x86 devices, with EFI Boot Guard) is there to guard kernel boot up to the point that systemd can take over monitoring of the system. That means if your post-update health check fails, you actively need to restart the system. If the service that is supposed to check that is failing, systemd is your first line of defense. Only if systemd crashes, the hw watchdog comes into play again.
Yes, this also needs documentation, likely in isar-cip-core... @gylstorffq @fmoessbauer

Thanks for the clarification!


ENH: Migrate content links from .md5, .sha512 to .cid

With the ContentLinkSynchronization.sh script in the ITKData repository.
Re: #3760

@thewtex What additional URLs, network, and executable dependencies with using cid/IPFS? I went to read about this but "ipfs.tech" is blocked on my network as being labeled as a"peer-to-peer" category.

I went to read about this but "ipfs.tech" is blocked on my network as being labeled as a "peer-to-peer" category.

Wow, that censorship of documentation for an open source peer-to-peer project is horrible! IPFS helps to address this type of censorship. If you are really interested you could try browsing ipfs.tech on IPFS instead of dealing with censored DNS by using the Brave Browser.
A few additional resources to learn about IPFS:

https://filebase.com/blog/a-beginners-guide-to-ipfs-content-addressing/
https://education.district0x.io/district0x-educational-specific-topics/understanding-technology-behind-district0x/ipfs/
https://docs.filebase.com/what-is-filebase/storage-networks/ipfs
https://www.youtube.com/watch?v=l44z35vabvA

What additional URLs, network, and executable dependencies with using cid/IPFS?

There are generally less limited dependencies.
Data is downloaded via HTTP gateways, which include many different IPFS gateways, and also GitHub Pages and Kitware's Apache server. In practice, not all of these are going to be censored. And if that was so, you could still run a local gateway or use the release tarballs.

ghostflow-check-master failures is expected.


Ignore more warnings in vs2017 to make it build

Visual Studio 2017 complains about a few more things in the standard header files.
Alternative would be to disable warnings-as-errors entirely so it's easier to build in the future.

Rebased and pushed onto master as 1dc1d15182


Deepspeed Zero3 support

@danielhanchen Hi, could you please give some advice for this issue? DPO training failed with Deepspeed Zero3 offload.
pip install "unsloth[cu121-ampere-torch211] @ git+https://github.com/unslothai/unsloth.git"
torch                         2.1.1+cu121
unsloth                       2024.1
Driver Version: 535.129.03   CUDA Version: 12.2

Traceback (most recent call last):
  File "/workspace/llm_tuning/DPO/LLaMA-Factory/src/train_bash.py", line 14, in <module>
    main()
  File "/workspace/llm_tuning/DPO/LLaMA-Factory/src/train_bash.py", line 5, in main
    run_exp()
  File "/workspace/llm_tuning/DPO/LLaMA-Factory/src/llmtuner/train/tuner.py", line 38, in run_exp
    run_dpo(model_args, data_args, training_args, finetuning_args, callbacks)
  File "/workspace/llm_tuning/DPO/LLaMA-Factory/src/llmtuner/train/dpo/workflow.py", line 30, in run_dpo
    model = load_model(tokenizer, model_args, finetuning_args, training_args.do_train)
  File "/workspace/llm_tuning/DPO/LLaMA-Factory/src/llmtuner/model/loader.py", line 83, in load_model
    model, _ = FastLanguageModel.from_pretrained(**unsloth_kwargs)
  File "/miniconda3/envs/llm_factory_unsloth_tf437/lib/python3.10/site-packages/unsloth/models/loader.py", line 79, in from_pretrained
    return dispatch_model.from_pretrained(
  File "/miniconda3/envs/llm_factory_unsloth_tf437/lib/python3.10/site-packages/unsloth/models/llama.py", line 689, in from_pretrained
    model = FastLlamaModel.post_patch(model)
  File "/miniconda3/envs/llm_factory_unsloth_tf437/lib/python3.10/site-packages/unsloth/models/llama.py", line 738, in post_patch
    model.model.embed_tokens = torch.nn.Embedding.from_pretrained(model.model.embed_tokens.weight)
  File "/miniconda3/envs/llm_factory_unsloth_tf437/lib/python3.10/site-packages/torch/nn/modules/sparse.py", line 210, in from_pretrained
    assert embeddings.dim() == 2, \
AssertionError: Embeddings parameter is expected to be 2-dimensional

deepspeed_z3_offload_config.json

{
  "train_batch_size": "auto",
  "train_micro_batch_size_per_gpu": "auto",
  "gradient_accumulation_steps": "auto",
  "gradient_clipping": "auto",
  "zero_allow_untested_optimizer": true,
  "fp16": {
    "enabled": "auto",
    "loss_scale": 0,
    "loss_scale_window": 1000,
    "initial_scale_power": 16,
    "hysteresis": 2,
    "min_loss_scale": 1
  },
  "bf16": {
    "enabled": "auto"
  },
  "zero_optimization": {
    "stage": 3,
    "offload_optimizer": {
      "device": "cpu",
      "pin_memory": true
    },
    "offload_param": {
      "device": "cpu",
      "pin_memory": true
    },
    "overlap_comm": true,
    "contiguous_gradients": true,
    "sub_group_size": 1e9,
    "reduce_bucket_size": "auto",
    "stage3_prefetch_bucket_size": "auto",
    "stage3_param_persistence_threshold": "auto",
    "stage3_max_live_parameters": 1e9,
    "stage3_max_reuse_distance": 1e9,
    "stage3_gather_16bit_weights_on_model_save": true
  }

Oh looks like Hiyouga answered it! :) Sadly haven't gotten to make Deepspeed work with Unsloth yet!

what do we need to make it work with deepspeed?

@thedarkzeno Oh it's much more complicated sadly


Issue with SA1642 and private constructors

In the old stylecop, SA1642 would suggest the following text for private constructors
SA1642 : CSharp.Documentation : The documentation text within the constructor's summary tag must begin with the text: Prevents a default instance of the  class from being created.
With the analyzer, it now gives me the following (when you use the lightbulb icon)
/// Initializes a new instance of the  class.
This was the suggestion for public constrictors
SA1642 : CSharp.Documentation : The documentation text within the constructor's summary tag must begin with the text: Initializes a new instance of the  class.
Has the rule changed?

The change was by-design; see #413 for details.
This is a duplicate of #831.
We really need to implement #359 as a home for this information, but haven't yet. You can see this change is listed in a comment in that issue to make sure it gets included.


Change Log

Points taken from the existing release notes. Could probably be improved further with other props / issue/pr links, but it should be sufficient for most.

Why do we need a changelog as separate file? We already have the Release list. I would just link there. Note: I fixed them last week, removing and adding was needed. Still can be improved further by using "added/removed/fixed" headlines for each.

Because it's standard, and git-platform agnostic (the changelog gets delivered with the rest of the files). If this repo moves to Bitbucket, or a Satis install, the list of changes (and not just the list of commits) are kept with it.
For each release, just populate the changelog, and the copy over to the GitHub releases if you wish.

Still can be improved further by using "added/removed/fixed" headlines for each.

The http://keepachangelog.com format suggests 6 subheadings, though for such small number of bullet points per release (which is good in itself), I see the subheadings as redundant noise, especially when the subsections are empty.

Agree. But as maintaining this is neither funny not makes contributing easier (we would need to force people to add to those changelog or do it ourselfs), I would suggest to automate this on Circle CI or on Travis CI: Fetch the release list with the GitHub API, loop over it and append to a changelog.md to extend the PR. How does that sound?

That sounds like even more hard-work and a another chance for things to potentially break :-)
I don't agree that contributors should be amending the change log - it's another potential source of merge conflict, and the wording may not reflect how the repo maintainer wants to communicate a change.
For this repo, with so few changes per release, it can either be done at release time (as you would with the release notes anyway) and just scrap the Unreleased section, or whenever a merge or direct commit is made, just add the entry to the change log when the subject is fresh in your mind, and the issue / PR ticket number is doesn't have to be found again. At release time, you can then just add the date and linked version number to the top, and a new Unreleased above that - it's not that much work. Making release notes is easy, and you've then already done it :-)

Change log in a separate file is good for me: it's easy to access it while developing, in fact looking a single file in IDE context is easier to go GitHub and look for release list.
http://keepachangelog.com/ suggests 6 subheadings, but not all of them are mandatory.
In the example given in the website only subheadings which have entries are included.
In release notes I usually at least include Added, Changed, Fixed because that works for me as a checklist if I should release a patch, a minor or a major release, because of Semver. For example if I have something in Added that is a minor release, if I have some BC changes in Changed that is major release.
In theory, I would just copy and paste from release notes into Changelog file.  And the one he sent was pretty good anyway.
Maybe later, WP Starter changelog could be made more in line with release notes and
http://keepachangelog.com/.


Unreachable code in SessionTokenHelper.java line 159

https://github.com/Azure/azure-sdk-for-java/blob/cd464cfe7c217332e1d02a29b7a78c3ff04ef9b6/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionTokenHelper.java#L158-L159
Line 159 is unreachable because the call to getLocalSessionToken in line 158 will always result in an java.lang.IllegalStateException due to the hard-coded empty string in the 3rd parameter.
https://github.com/Azure/azure-sdk-for-java/blob/cd464cfe7c217332e1d02a29b7a78c3ff04ef9b6/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionTokenHelper.java#L64-L73
We are experiencing the same issue in version 2.6.5 (com.microsoft.azure.cosmosdb.internal.SessionTokenHelper).

Thanks for reporting this issue in Cosmos v2 @mshikaji.  I'm assigning this issue to @kushagraThapar to follow up.
@mshikaji please note that there are newer versions of the Cosmos SDK available for use (v3 and v4-beta) (https://mvnrepository.com/artifact/com.azure/azure-cosmos)

@mshikaji I will investigate this. Thanks for reporting.

This has been fixed in v4 SDK.


LOSS 始终是0.01

您好！


ROC extra stuff

i removed some stuff into a file
roc-extra-unused.Rnw
that is somwhat old, and outdated
but there is also some potentially good stuff in there
should be reviewed for a potential extra lecture material, maybe we also need separate issues for this

This is a general discussion we should have. See #449

we have a new chunk now


Data Fetching for One Tool

Notion ticket link

Tool landing page data fetching

Implementation description
This ticket fetches the tool information for a specific tool using the /api/tool/{id} api call. It grabs all the information for the tool and displays it on the page with minimal design.

Steps to test

Create a tool
Copy the tool id and paste it into this route: locahost:3000/tool?id=<INSERT TOOL ID>

What should reviewers focus on?

Ensure all the necessary information is being displayed

Checklist

[x] My PR name is descriptive and in imperative tense
[x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
[ ] I have run the appropriate linter(s)
[x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Looks pretty good. But you have to lint your files so that the checks stop failing:

You need to get the appropriate formatter from the VSCode Extension store (i think we use ESLint) and then run the "yarn lint" in the command line (like you would run yarn dev). If yarn lint doesnt work for you (it doesn't for me) go the affected files:

and fix the related errors:

This can usually be done in one move using the command (Shift + Option + F) - MacOS or (Shift + Alt + F) - Windows.

Looks pretty good. But you have to lint your files so that the checks stop failing:  You need to get the appropriate code formatter from the VSCode Extension store (i think we use ESLint) and then run the "yarn lint" in the command line (like you would run yarn dev). If yarn lint doesnt work for you (it doesn't for me) go the affected files:  and fix the related errors:  This can usually be done in one move using the command (Shift + Option + F) - MacOS or (Shift + Alt + F) - Windows while in the unlinted file.

Thanks for the review @ChinemeremChigbo! I've applied linting!

Sick! Works great. Have we thought about how admins are going to host their photo / video files? A note if they use youtube videos they have to use the "embed" type link for it to work properly with Iframes eg typing https://www.youtube.com/embed/TBqRiIJpEXo into the link field instead of https://www.youtube.com/watch?v=TBqRiIJpEXo

I think we'll likely just import/duplicate the code we use in the MD renderer to display videos/images (I believe we're relying on a library that converts to embeds under the hood for videos)


Remove redundant swap logic

This logic should no longer be necessary:  It was a result of some problems we were having with ingestion on the bigquery connector that have now be verified to work.
@Tarrasch sorry for the delay with this but should be all set now :)

Is it still atomic?

@erikbern Thankfully, it is!  The problem we were seeing was in unrelated java code that relied on partial loads per mapper in hadoop followed by a final table merge, so the intention here was to hide the table as it was loaded with disposition APPEND to avoid querying partial data.
The loads as performed by luigi via GCS are fully atomic.

excellent

Finally! Great job! :D
Just please amend the commits so the history looks clean. :)

@Tarrasch Rebased

Cool. Lets merge once tests pass! :)

:+1: Also triggered a rebuild, tests are green now.


Translation equivariance and translation action on type-n steerable vectors

In the appendix of the paper, "translations are trivial to deal with". However, while we can use Wiger D matrices as O(3) representations acting on the steerable vectors, I'm confused that  how to have R^3 translations acting on the steerable feature vectors, if there are multiple types?
I'm aware that in the message passing frameworks, the convolution are built upon relative positions between two nodes x_j - x_i, but shouldn't this be translational invariant, instead of translation equivariant?

Hi,
It is true that relative positions are translation invariant. However, since the feature vector travels with the node as the graph is translated, the feature vector itself is equivariant.
Kind regards,
Rob


Pre-fill Chrome path

The chomePath setting should be pre-filled depending on the platform

I'm trying to get this to work on macOS; would the correct value for this be "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome"?

Yes it should be correct,
have you tested that? What was the result?


webpack legacy loader external not working

webpackIndexHTMLPlugin: {
   loader: 'external',
 },

does not result on anything no scripts are injected

I just tried it, and it's working fine for me. Are you sure you're using 2.2.2 of building-webpack? This is what my config looks like:
const path = require('path');
const merge = require('webpack-merge');
const CopyWebpackPlugin = require('copy-webpack-plugin');
const createDefaultConfigs = require('../../modern-and-legacy-config');

const configs = createDefaultConfigs({
  input: path.resolve(__dirname, './index.html'),
  webpackIndexHTMLPlugin: {
    loader: 'external'
  }
});

if (Array.isArray(configs)) {
  module.exports = [
    merge(configs[0], {
      plugins: [new CopyWebpackPlugin(['demo/**/*.txt'])],
    }),
    configs[1],
  ];
} else {
  module.exports = configs;
}

Hi, seems like I have outdated version somehow.
Now it works after update to latest one
Thank you!


Unit test failed with directory mode 0600

I made some unit test with go test, the test always fails complaining "No permission to SOME_DIR", where SOME_DIR is created in the _test.go file with file mode 0600.
As I see from some refs, the execution permission is also needed to access the files insdide the folder, so should it make sense that we change the file mode to 0700?
A test in shell, can't even cd into the folder with mode 0600:
 ~  mkdir perm-test
 ~  chmod 0600 -R perm-test/
 ~  cd perm-test/
cd: Permission denied: “./perm-test/”

Refs:
https://wiki.archlinux.org/index.php/File_permissions_and_attributes


Add TensorFlow

a list of awesome Tensorflow items

Thanks for the suggestion :smiley:
Please have a quick read through of the instructions for creating a new list.
Could you add a license (CC0 preferably) and some contribution guidelines? You can use this one as a template. Also, this pull request: https://github.com/jtoy/awesome-tensorflow/pull/3 hasn't been reviewed yet.
Perhaps a small description and a link to tensorflow.org would be good for this project - a new user visiting wouldn't know what Tensorflow is. e.g. Tensor flow is an open source software library for numerical computation using data flow graphs.

awesome suggestions , I've made the changes! let me know if you have other ideas. I update the list about once a week.

I still don't see the license anywhere.

Added

Why should TensorFlow be under Platform?
The list could use some improving when it comes to formatting and grammar. You've pretty much have 5 different ways of writing TensorFlow in there. Please keep it consistent. Same with ending an item description in a . or not. It's GitHub, not Github.
With TensorFlow Libraries, the TensorFlow prefix is moot.
If you want to contribute to this list (please do), send me a pull  and following should not be under the What is TensorFLow section.

@sindresorhus and all, thanks for the suggestions, I cleaned it all up.  I think ready to merge.

@sindresorhus on the platform question, where do you suggest it goes under then?
Platform was the best category out of the current categories. TensorFlow is a platform for writing deep learning models.
Its not computer science or theory since its a software library.
maybe under programming language?
I personally would make a new category called machine learning and put  it under that.  What do you think?

I personally would make a new category called machine learning and put it under that. What do you think?

Could the following existing item go under that new category Computer Vision, ``Deep Learning (Neural networks), Deep Vision`?

I like under deep learning, will do!

No need to open a new pull request. In the future just update the existing pull request. Opening duplicate pull requests just makes the issue tracker noisy.
https://github.com/sindresorhus/awesome/blob/master/contributing.md#updating-your-pull-request


Undocumented Title Feature

Hi there,
After searching for a bit, I found out how to actually set the title you can see in the android notification center once you receive a message there.
Found out using this: https://github.com/aerogear/aerogear-pushplugin-cordova/pull/42/files
It can be done by sending a title value in the payload of the notification, I think that this should be documented somewhere.
Example Payload:
{
    "collapseKey": "optional",
    "data": {
        "message": "There was a plane crash in the south pacific.",
        "title": "Super Important News Reader"
    }
}

thank you!!


"flutter pub global activate webdev" isn't valid

The page:
https://github.com/flutter/flutter_web#install-the-flutter_web-build-tools
Says to:
# Install the flutter_web build tools

To install the webdev package, which provides the build tools for Flutter for web, run the following:

    $ flutter pub global activate webdev

But this command apparently isn't recognized (flutter pub results in an error).
Removing "flutter" runs pub, apparently that's is what's wanted.

On Windows.

@freedaun

But this command apparently isn't recognized (flutter pub results in an error).
Is the flutter command available in your PATH environment variable?

Is the flutter command available in your PATH environment variable?

Yes. The error produced by flutter pub. The error is:
Missing subcommand for "flutter pub".

Flutter by itself lists its options.

@freedaun
Paste flutter doctor -v please.
It's working fine on my Mac using the latest master.
KyleWongdeMacBook-Pro:flutter_gallery kylewong$ /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/bin/flutter pub global activate webdev
Resolving dependencies...
+ args 1.5.1
+ async 2.2.0
+ browser_launcher 0.1.2
+ build_daemon 0.6.1 (1.0.0 available)
+ built_collection 4.2.2
+ built_value 6.5.0
+ charcode 1.1.2
+ codemirror 0.5.5+5.46.0
+ collection 1.14.11
+ convert 2.1.1
+ crypto 2.0.6
+ devtools 0.0.19 (0.1.0 available)
+ devtools_server 0.1.2
+ dwds 0.3.2
+ fixnum 0.10.9
+ http 0.12.0+2
+ http_multi_server 2.0.6
+ http_parser 3.1.3
+ intl 0.15.8
+ io 0.3.3
+ js 0.6.1+1
+ json_annotation 2.4.0
+ logging 0.11.3+2
+ matcher 0.12.5
+ meta 1.1.7
+ mime 0.9.6+2
+ octicons_css 0.0.1
+ package_config 1.0.5
+ package_resolver 1.0.10
+ path 1.6.2
+ pedantic 1.7.0
+ platform_detect 1.3.5
+ plotly_js 0.0.1
+ polymer_css 0.0.1
+ pool 1.4.0
+ primer_css 0.0.2
+ pub_semver 1.4.2
+ pubspec_parse 0.1.4
+ quiver 2.0.3
+ rxdart 0.21.0 (0.22.0 available)
+ shelf 0.7.5
+ shelf_proxy 0.1.0+6
+ shelf_static 0.2.8
+ shelf_web_socket 0.2.3
+ source_maps 0.10.8
+ source_span 1.5.5
+ split 0.0.2
+ sse 2.0.2
+ stack_trace 1.9.3
+ stream_channel 2.0.0
+ stream_transform 0.0.19
+ string_scanner 1.0.4
+ term_glyph 1.1.0
+ typed_data 1.1.6
+ uuid 2.0.1
+ vm_service_lib 3.15.1+1 (3.15.1+2 available)
+ watcher 0.9.7+10
+ web_socket_channel 1.0.13
+ webdev 2.0.5
+ webkit_inspection_protocol 0.4.0
+ yaml 2.1.15
Downloading webdev 2.0.5...
Downloading webkit_inspection_protocol 0.4.0...
Downloading shelf_proxy 0.1.0+6...
Downloading sse 2.0.2...
Downloading uuid 2.0.1...
Downloading pedantic 1.7.0...
Downloading dwds 0.3.2...
Downloading vm_service_lib 3.15.1+1...
Downloading build_daemon 0.6.1...
Downloading devtools 0.0.19...
Downloading split 0.0.2...
Downloading rxdart 0.21.0...
Downloading primer_css 0.0.2...
Downloading polymer_css 0.0.1...
Downloading plotly_js 0.0.1...
Downloading platform_detect 1.3.5...
Downloading octicons_css 0.0.1...
Downloading devtools_server 0.1.2...
Downloading browser_launcher 0.1.2...
Downloading codemirror 0.5.5+5.46.0...
Precompiling executables...
Precompiled webdev:webdev.
Installed executable webdev.
Warning: Pub installs executables into $HOME/.pub-cache/bin, which is not on your path.
You can fix that by adding this to your shell's config file (.bashrc, .bash_profile, etc.):

  export PATH="$PATH":"$HOME/.pub-cache/bin"

Activated webdev 2.0.5.
KyleWongdeMacBook-Pro:flutter_gallery kylewong$ open  $HOME/.pub-cache/bin
KyleWongdeMacBook-Pro:flutter_gallery kylewong$ /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/bin/flutter --help
Manage your Flutter app development.

Common commands:

  flutter create <output directory>
    Create a new Flutter project in the specified directory.

  flutter run [options]
    Run your Flutter application on an attached device or in an emulator.

Usage: flutter <command> [arguments]

Global options:
-h, --help                  Print this usage information.
-v, --verbose               Noisy logging, including all shell commands executed.
                            If used with --help, shows hidden options.

-d, --device-id             Target device id or name (prefixes allowed).
    --version               Reports the version of this tool.
    --suppress-analytics    Suppress analytics reporting when this command runs.
    --bug-report            Captures a bug report file to submit to the Flutter team.
                            Contains local paths, device identifiers, and log snippets.

Available commands:
  analyze                  Analyze the project's Dart code.
  attach                   Attach to a running application.
  bash-completion          Output command line shell completion setup scripts.
  build                    Flutter build commands.
  channel                  List or switch flutter channels.
  clean                    Delete the build/ and .dart_tool/ directories.
  config                   Configure Flutter settings.
  create                   Create a new Flutter project.
  devices                  List all connected devices.
  doctor                   Show information about the installed tooling.
  drive                    Runs Flutter Driver tests for the current project.
  emulators                List, launch and create emulators.
  format                   Format one or more dart files.
  help                     Display help information for flutter.
  install                  Install a Flutter app on an attached device.
  logs                     Show log output for running Flutter apps.
  make-host-app-editable   Moves host apps from generated directories to non-generated directories so that they can
                           be edited by developers.
  precache                 Populates the Flutter tool's cache of binary artifacts.
  pub                      Commands for managing Flutter packages.
  run                      Run your Flutter app on an attached device.
  screenshot               Take a screenshot from a connected device.
  test                     Run Flutter unit tests for the current project.
  upgrade                  Upgrade your copy of Flutter.
  version                  List or switch flutter versions.

Run "flutter help <command>" for more information about a command.
Run "flutter help -v" for verbose help output, including less commonly used options.
KyleWongdeMacBook-Pro:flutter_gallery kylewong$ /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/bin/flutter pub --help
Commands for managing Flutter packages.

Usage: flutter pub <subcommand> [arguments]
-h, --help    Print this usage information.

Available subcommands:
  cache       Work with the Pub system cache.
  deps        Print package dependencies.
  downgrade   Downgrade packages in a Flutter project.
  get         Get packages in a Flutter project.
  global      Work with Pub global packages.
  pub         Pass the remaining arguments to Dart's "pub" tool.
  publish     Publish the current package to pub.dev.
  run         Run an executable from a package.
  test        Run the "test" package.
  upgrade     Upgrade packages in a Flutter project.
  uploader    Manage uploaders for a package on pub.dev.
  version     Print Pub version.

Run "flutter help" to see global options.
KyleWongdeMacBook-Pro:flutter_gallery kylewong$ /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/bin/flutter doctor -v
[✓] Flutter (Channel master, v1.6.4-pre.18, on Mac OS X 10.14.6 18G29g, locale en-CN)
    • Flutter version 1.6.4-pre.18 at /Users/kylewong/Codes/Flutter/alibaba-flutter/flutter
    • Framework revision 323373d333 (6 hours ago), 2019-05-27 12:27:28 -0700
    • Engine revision 8dc3a4cde2
    • Dart version 2.3.2 (build 2.3.2-dev.0.0 e3edfd36b2)

Unzipped flutter 1.7.8 for mac, and with both flutter and pub in path, I see this:
Muralis-MacBook-Pro:flutter_dadjokes murali$ flutter --version
Flutter 1.7.8+hotfix.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 20e59316b8 (4 weeks ago) • 2019-07-18 20:04:33 -0700
Engine • revision fee001c93f
Tools • Dart 2.4.0

Muralis-MacBook-Pro:flutter_dadjokes murali$ which flutter
/Users/murali/Downloads/flutter/bin/flutter

Muralis-MacBook-Pro:flutter_dadjokes murali$ which pub
/Users/murali/Downloads/flutter/bin/cache/dart-sdk/bin/pub

Muralis-MacBook-Pro:flutter_dadjokes murali$ /Users/murali/Downloads/flutter/bin/flutter pub
Missing subcommand for "flutter pub".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

Muralis-MacBook-Pro:flutter_dadjokes murali$ flutter pub
Missing subcommand for "flutter pub".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

There is no $HOME/.pub-cache/bin directory on my computer.
baloneo@baloneo-linux:[~]:ls ~/.pub-cache  git  global_packages  hosted  _temp

Same here.
Missing subcommand for "flutter pub".
Output of flutter doctor -v:
[✓] Flutter (Channel stable, 1.22.2, on Linux, locale ru_RU.UTF-8)
    • Flutter version 1.22.2 at /home/farid/snap/flutter/common/flutter
    • Framework revision 84f3d28555 (8 недель назад), 2020-10-15 16:26:19 -0700
    • Engine revision b8752bbfff
    • Dart version 2.10.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/farid/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /home/farid/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[!] Android Studio
    • Android Studio at /home/farid/android-studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.15.1

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

Installed on Linux Mint 19.
If it makes sense: when I was installing dart I did not add its bin directory to PATH. Instead there was a symlink created in /usr/bin directly to /usr/lib/dart/bin/dart. Then I've installed flutter. Probably it did not found dart's pub executable in PATH thus did not enable its pub command?
Now I have whole /usr/lib/dart/bin in PATH, but still no flutter pub command.


Close the connection to Riemann when the RiemannReporter is told to stop()

This addresses #65.

Thanks Michael!


FastMarchingUpwindGradient (Python) is broken as of 2.2

Test script to run after installing SimpleITK 2.2.0 or 2.2.1:
import SimpleITK as sitk

sitkImg = sitk.GridSource()
trialPoints = [(0, 0, 0)]
targetPoints = [(2, 0, 10)]
gradientImg = sitk.FastMarchingUpwindGradient(sitkImg, trialPoints, 1, targetPoints)
print("successfully obtained gradient image")

Resulting output:
Traceback (most recent call last):   File "/home/agilman/test/simpleitk/./sitk_test.py", line 8, in <module>     gradientImg = sitk.FastMarchingUpwindGradient(sitkImg, trialPoints, 1, targetPoints)   File "/home/agilman/test/simpleitk/venv/lib/python3.9/site-packages/SimpleITK/SimpleITK.py", line 26008, in FastMarchingUpwindGradient     return _SimpleITK.FastMarchingUpwindGradient(*args, **kwargs) RuntimeError: Exception thrown in SimpleITK FastMarchingUpwindGradient: /tmp/SimpleITK-build/ITK-prefix/include/ITK-5.3/itkFastMarchingUpwindGradientImageFilter.h:267: ITK ERROR: FastMarchingUpwindGradientImageFilter(0x5633f9ea66f0): No target point set. Cannot set the target reached mode.
With SimpleITK <IP_ADDRESS>, the success message is printed.

FYI, I got the same error on 2.2.1, and it worked on <IP_ADDRESS>.  Will investigate further.

Update: So if we use the actual filter object (FastMarchingUpwindGradientImageFilter), the latest SimpleITK works fine.  Something about the procedural version is broken.

https://github.com/InsightSoftwareConsortium/ITK/pull/3354/files
This code is failing because of this recent change to the ITK FastMarchingUpwindGradientImageFilter.

The procedural version takes a numberOfTargets parameter before the targetPoints parameter. The filter json file suggests that the filter's TargetReachedMode gets updated based on the number of targets, but given the change @dave3d mentions, updating the mode without having set the target points themselves could very easily raise an error.

A PR with a test and solution is in progress now.