Versions policy: specify how/if to migrate from unversioned to versioned formula

This issue regards our documentation and policies at https://github.com/Homebrew/brew/blob/master/docs/Versions.md.
I hope we can add a policy to address this specific question:

If an unversioned formula is tracking a specific (old) major version of upstream then what should we do?

Here is concrete discussion on one such instance: https://github.com/Homebrew/homebrew-core/pull/102250. Regardless of the resolution there, this policy could be clarified in our documentation/policy.

Pinging contributors to that file for the related points: @MikeMcQuaid @SMillerDev @EricFromCanada @gromgit @jonchang

Our issue tracker is for bugs and feature requests (or, more generally, tracking work to be done).
This belongs in the discussions page. Please post there if you'd like to continue this.


Fix modification of client option hash

I'm not really sure this is the best way, but we shouldn't modifying client option hashes, especially since they can be frozen.

Hello,
let me try to understand what your situation is.
You're passing a frozen client option hash to rufus-scheduler and that triggered an error since rufus-scheduler is adding information to it.
Am I getting it right?

That's correct. In version 3.0.8, when Chronic is used to parse the time string, the result is cached by mutating the supplied options. I think the scheduler shouldn't be modifying that hash.

OK, I will fix it my way.

Thanks a lot!

No, thank you!!


Create CODE_OF_CONDUCT.md

So I'm interested in helping create a friendly, inclusive development community around Flutter. I think it's a good idea to have a code of conduct for contributors.

Pull Request Test Coverage Report for Build 100

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.667%

Totals

Change from base Build 97:
0.0%

Covered Lines:
88

Relevant Lines:
96

💛  - Coveralls


nghttp2: adding a compile-out option

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

/retest


Lengthy Scope names or descriptions cause UI rendering issue

Describe your problem(s)
If we add scope name or description with lengthy string then we wont be able to see rest of the columns. Due to that cannot delete scope or view all columns
Describe your solution
Having UI field validation would solve this issue along with API level data validation

How will you implement it

Optional Fields
Related Issues:

Suggested Labels:

Suggested Assignees:

Closing the issue since it's fixed in wso2/carbon-apimgt#9269


It will be nice to have option to update to latest bootloader EEPROM

It will be nice to have option to update to latest bootloader EEPROM
to testing version

@xlazom00 please close this issue if it has been resolved. Thanks.


Individual CI doesn't work, while manual trigger works fine - Azure Devops Server - Self Signed Certificate

I am using an Azure DevOps Server 2020 on my Windows 2019 server. And I use a git server (Bonobo) to have my repository (Selected other git, when configuring repository source). I use self signed certificate for this repository.
In my Azure Devops Server, I set this config:
git config --system http.sslverify "false"
git config --global http.sslverify "false"

since cert is self signed. Now, when I run the pipeline manually, I can start the pipeline and it works like a charm . But when it comes to Individual (automated) running, I get error. Here is the output (there is no log, this is from summary page):
An exception occurred while polling the repository.  Error: Microsoft.TeamFoundation.Build2.Server.Extensions.ExternalConnectorException: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel. ---> System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel. ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid according to the validation procedure.
   at System.Net.TlsStream.EndWrite(IAsyncResult asyncResult)
   at System.Net.ConnectStream.WriteHeadersCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
   at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.<SendAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.TeamFoundation.Build2.Server.Extensions.GitConnector.GetBranches(IVssRequestContext requestContext, ExternalConnection connection, Int32 timeoutSeconds, Boolean useAnonymousAccess)
   --- End of inner exception stack trace ---
   at Microsoft.TeamFoundation.Build2.Server.Extensions.GitConnector.GetBranches(IVssRequestContext requestContext, ExternalConnection connection, Int32 timeoutSeconds, Boolean useAnonymousAccess)
   at Microsoft.TeamFoundation.Build2.Server.Extensions.GitSourceProvider.GetMatchingBranchRefs(IVssRequestContext requestContext, BuildDefinition definition, IList`1 branchFilters)
   at Microsoft.TeamFoundation.Build2.Server.Extensions.GitSourceProvider.GetSourceVersionsToBuild(IVssRequestContext requestContext, BuildDefinition definition, List`1 branchFilters, Boolean batchChanges, String previousVersionEvaluated, Dictionary`2& ciData, String& lastVersionEvaluated)
   at Microsoft.TeamFoundation.Build2.Server.Extensions.BuildPollingJobExtension.Run(IVssRequestContext requestContext, TeamFoundationJobDefinition jobDefinition, DateTime queueTime, String& resultMessage).

And when I look at git version of the server and git version of Azure devops server, they are different.
The logs of Azure Devops Server webpage logs says
git version
git version 2.28.0.windows.1

but when I check for git version from powershell, I get different version:
git --version
git version 2.37.1.windows.1

I guess, the configurations for git is different for Azure Devops and for the server.
I investigated even more, and found out that all git configs are looking for the same location. I guess the Individual automated run is running over a different structure.
Taken from this ticket: But if TFS is using something else for polling for External Git repository rather then Git.exe (like some Web API)
I guess Azure Devops is using something other than Git.exe. Btw I haven't changed any configuration (other than git config command above) in server, you can test this with dev.azure.com and you will get the same results.
Edit: Oops I forgot to mention that I added GIT_SSL_NO_VERIFY 1 setting in variables of pipeline variables.

Hi @sahin52 thank you for reporting!
We are currently working on higher priority tickets, let us come back soon.

I now understand, Individual CI is polling the repository in order to understand if there is a change, while manual trigger works when we click on run. The polling process is the cause of the error.

Btw the solution to this problem is to have a proper https connection for the url. if it's self signed, or the certificate has timed out, you may face this problem. Closing the issue.


Can not auto complete code in spyder ide version 3.2.8

I'm using anaconda 5.2 and spyder 3.2.8 in Mac or Win10
I found I can auto complete all coding in ipython console using 'Tab',but I can't auto complete in editor.
And interesting is:
some code can auto complete in editor,some code can not.Like bleow:
Positive in completion  : np.*  /  pd.*   /    string.upper()
Negative in completion : dataframe.*
Please fix it, I try all I can find in these discussion in google  but failed.

Please read this
https://stackoverflow.com/questions/42777430/why-autocompletion-options-in-spyder-3-1-are-not-fully-working-in-the-editor
to understand why this doesn't work in our Editor.

thanks, rodeo is works better and I hope spyder can improve,it's a very useful feature

I'm using anaconda 5.2 and spyder 3.2.8 in ubuntu16.04, I also have this problem now. I have tried "spyder -- reset" already, but it still doesn't work. No found enum or enum34 in conda list and pip list. Is there any solution now?

I am new to spyder and I am facing the same problem of autocompletion not working, can anyone please help, fyi enum or enum34 not found in the conda list


Update syntax for Solidity 0.8.8

Syntax updates for Solidity 0.8.8:

I reclassified type as a keyword rather than a builtin, now that it can be used for custom type declarations.

I highlighed wrap and unwrap as builtins when used as a member of something else.  I'm a little uncertain whether this is a good idea; it's possible that wrap and unwrap functions are sufficiently common that highlighting this would be annoying, and it would be better to just omit highlighting for these. So, uh, please let me know what you think of this.  (@gnidan, I can't add you as a reviewer, but do you have an opinion on this?)

I reclassified type as a keyword rather than a builtin, now that it can be used for custom type declarations.

This seems reasonable.

I highlighed wrap and unwrap as builtins when used as a member of something else.  I'm a little uncertain whether this is a good idea; it's possible that wrap and unwrap functions are sufficiently common that highlighting this would be annoying, and it would be better to just omit highlighting for these. So, uh, please let me know what you think of this.  (@gnidan, I can't add you as a reviewer, but do you have an opinion on this?)

I think if they are sufficiently common it is a good thing to draw attention to, especially as it is a new feature.

I think if they are sufficiently common it is a good thing to draw attention to, especially as it is a new feature.

I'm not sure I understand what you're saying here.  I'm saying that if x.wrap and x.unwrap are sufficiently common as existing things, it might be obnoxious to highlight.  Ideally not every instance of x.wrap or x.unwrap would be highlighted, only those cases where x is a UDVT.  But that's not something we can feasibly do with HLJS; it's either highlight all such cases or none of them.  So the question is, would making it highlighted in all cases -- to get it highlighted when x is a UDVT -- be too obnoxious due to existing (and non-conflicting) usage of x.wrap or x.unwrap in other cases?
I don't think I understand what your answer to that question is.

But that's not something we can feasibly do with HLJS; it's either highlight all such cases or none of them.

Oh, right! There's not enough information to disambiguate.  I misunderstood your 2nd point. However I still think that if this is a new feature we should draw attention to it and wait for feedback that it is noisy.
This Github search suggests wrap is not so popular in GH public repos

OK, cool, I'll go ahead with that then.  I'll go back and add the comments you suggested and then merge / release this.
I asked about wrap/unwrap because earlier I had contemplated making value a builtin (#24) and @frangio was like no that'd be way too noisy.  (We ended up coming up with a special-case hack to handle it.)  I knew that like wrapped ether was a thing so I wasn't sure if that would be a common existing usage that would cause noise?  Wrap/unwrap also just seemed like it might be a common pair in general.  But sounds like it isn't so there's no problem!


Chrome blocking and pouchdb location.

While using this with IE, it asked me if I wanted to unblock content, and after doing so, everything worked fine.  However, I would like to use Chrome's dev tools (since IE doesn't have the best ones) to monitor local storage... however, it's blocking this script.  All I see is gray map whenever I set use of cache to true.
In a separate, but relatable question... where is pouchdb stored?  I would like to cache the tiles and redistribute to several machines.
Thanks,
BK

What do you see in Chrome's dev console and network monitor? Is your webpage being served through HTTP or HTTPS? Are your tiles being served by HTTP or HTTPS?
See also http://stackoverflow.com/questions/9972049/cross-origin-data-in-html5-canvas

In a separate, but related question... where is pouchdb stored?

RTFM: http://pouchdb.com/adapters.html

I would like to cache the tiles and redistribute to several machines.

Then this is the wrong tool. See https://github.com/mapproxy/mapproxy (see #2)

Except for the fact that MapProxy requires installation and I can't install it on every client..... since I'm seeking an offline solution, having them connected to a server that has this is not an option either.

You don't install mapproxy on every client. You install it on one of your servers, and have all clients seed from there.
Once again: what's in chrome's dev console and network monitor? This smells like a cross-origin policy issue, and there should be something on the logs.

But like I said... if clients are offline, how would they be able to connect?  I'm looking for an offline solution.
As far as Chrome, I get this:
Image from origin 'http://<IP_ADDRESS>' has been blocked from loading by Cross-Origin Resource Sharing policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access.

This library is meant for clients which are able to connect to the server, cache the tiles, then go offline. That is my use case, and I have no interest on functionality beyond that. If you want to extend this code  in order to export/import a cache, go ahead.
If you are planning on distributing a completely offline application along with tiles, the solution then is to pack your tiles as a MBtiles file (or whatever) and use that.

No 'Access-Control-Allow-Origin' header is present on the requested resource

Well, make sure that your tile server adds a Access-Control-Allow-Origin: * header to every tile served.

Thanks.


[AMORO-1619] 0.4.x support copy large files when executing full optimizing of Unkeyed Mixed Hive Table

Why are the changes needed?

Close #1619 .
Brief change log

optimizers support copy files to new hive locations if all files in this task are large files
full optimizing plan of Unkeyed Mixed Hive Table supports split large files and small files into different tasks

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@wangtaohz We cannot close the issue as it is not fixed in the master branch yet.

This PR has not been merged for a long time, is something stopping it? @zhoujinsong @wangtaohz


trouble using with Electron: "DMX is not a constructor"

I'm not sure if this is strictly speaking an issue, or just something I'm having difficulty with in my setup. I've been trying for several days to get this library working in an Electron project I'm testing.
I'm just using the demo_simple.js code as is:
var DMX = require('./dmx'); var A = DMX.Animation; var dmx = new DMX(); var universe = dmx.addUniverse('demo', 'null')
but it bugs out at the constructor, with a TypeError: DMX is not a constructor.
Has anyone successfully used this with Electron? Is this error indicative of a simple config problem, or is there some fundamental reason I won't be able to make this work?
Thanks for what looks like a super project,
Cheers,
David Hoare

do you have another assignment to the variable DMX or a second file called "dmx.js" that will be found instead?

if you have installed node-dmx via npm you might want to try var DMX = require('dmx')? I'm a bit puzzled how this error can occur.

Hey @davidhoare,
Can you show us a little bit more how you use this library? I also guess there is some naming conflict.
I just tried using this library inside a super simple electron project and it works for me there.
See the attached zip file for a very simple test based on demo-simple in electron: test-electron.zip - does this work for you?
--maex

Hello :-) Thank you both for responding!
Re the first error - - you were right: there was another file in the same folder (dmx.json) that I was using as a config file...
However, now that I've cleaned that up, I'm getting a version conflict error with both my project and the sample that Max provided.
Module version mismatch. Expected 49, got 48.
I think I can trace this to the serialport module (maybe :-) because it was what I had to install to the local node_modules folder in Max's sample in order to get it to launch. Now that it launches, I get that version mismatch error in console.
What version of node are you using or should this be compatible with. I cannot find version '49' anywhere - - it goes from 48-->51 in terms of official releases... (https://nodejs.org/en/download/releases/)
Thank you for your help! I think I'm getting closer :-)
DH

I think a npm install electron-rebuild and then ./node_modules/.bin/electron-rebuild  -$(electron -v) should fix that issue.

god bless you! I've been fighting with this for days!!!
I'm (obviously :-) new to Electron, and I thought it would be a fun way to create a little cross-platform version of a lighting console program I did years ago in VB... Little did I imagine the headaches getting it setup properly. I hope this is it now (appears to be working just fine) so thank you again ever so much for your time tonight.
Cheers!
David

glad it's working!
Have fun :)

Woho, good news! 🎉
Have fun playing around with it 👍

@davidhoare another thing which you might want to do (unless you have a specific other need) is make sure you are using the same version of node as electron is built with. Right now, if you are on latest electron, you should be using 6.5.0, the release page is a good place to check often =)


fix CSS for react-select

fix https://github.com/apache/incubator-superset/pull/3726

Coverage remained the same at 71.271% when pulling 7a73c64e666ec346e9e1c18c8fe84aa8f3b13eae on graceguo-supercat:bump-react-select into abfa03474cae49f66caf0d77533bf9b8e040145e on apache:master.

LGTM


Linux GUI was not working in wsl2

Windows Build Number
Microsoft Windows [Version 10.0.19043.1110]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
Gedit
and all the Linux GUI Apps
Repro Steps
I install the gedit in Ubuntu 20.04 on WSL2 and uptodate all packages and drivers.
install the gedit using "sudo apt install gedit" successfully installed open the gedit using "gedit" not opening.
Expected Behavior
open the Linux GUI apps
Actual Behavior
Unable to init server: Could not connect: Connection refused
(gedit:336): Gtk-WARNING **: 18:06:59.829: cannot open display: localhost:0.0
Diagnostic Logs
No response

From what I know, WSLg updates aren't on the Windows 10 insiders/general updates. You need to be on Windows 11 to be able to use WSLg.

I updated the Windows 10 Insider Preview build 21362+
problem fixed
https://github.com/microsoft/wslg

I am not using windows insider preview. I update my windows today.
Below is my update. I tried gui apps in wsl - ubuntu. It is not showing any error and also not opening.

Same here with Windows 11, 22000.194

Updated Windows 11, installed Nvidia driver, after wsl --update and wsl --shutdown and also apt update, I still get the same error.
Unable to init server: Could not connect: Connection refused
(gedit:472): Gtk-WARNING **: 20:26:29.949: cannot open display:
I tried on two different machines, the same error, any suggestions?

Same here. No luck getting WSLg working to enable GUI applications.
Using Windows 11 Pro, build 22000. WSL Ubuntu Community Preview freshly installed, which is Ubuntu 21.04 with kernel <IP_ADDRESS>.
$ sudo apt install x11-apps -y
...looks good...
$ xcalc
Error: Can't open display: :0
The whole WSLg situation is very confusing. If you run "sudo ubuntuwsl visual", you can enable "legacy integration" of GUI and audio apps, but it requires an external Xserver and PulseAudio server running on native Windows. I assume that is NOT what you want to do to make use of WSLg.
So this doesn't "just work" as you'd expect. I suspect the issue is there is no X server running on Linux itself. But before I go about installing xserver-xorg-core or a desktop, I'd like to have confirmation of someone out there getting this working. Maybe there is a simpler way to enable WSLg without having to install a full desktop on Linux.

Have you upgraded to Windows 11? I followed @LohiKarma97's instructions and https://docs.microsoft.com/en-us/windows/wsl/tutorials/gui-apps. And it works now.

It looks like you may have got Wayland-native apps to work but not X11 ones ? (just a hunch based on this article)

That's possible. I subsequently got nautilus working, but pretty much everything else does not work. I always get the "Error: Can't open display :0" message. This would imply there is no Xserver. But isn't the point of WSLg to avoid installing an X server? At this point, I've pretty much given up on it, assuming that when the WSL2 Community Preview moves into production, everything will "just work".

Yes that's the point.  Personally I had to remove everything X-related (things I had tried to make GUIs work in WSL1 and failed),  reinstall everything, and then follow the procedure above.

@Aquariu, did you do this with the WSL2 Community Preview, or were you using the production version of WSL2? I'm sure this all works on the production version, but that version is stuck on the old LTS version of Ubuntu. I went with the Community Preview to be able to use 21.04.

Hi,
I'm on Win11 22000.318. I installed a fresh copy of ubuntu 20.04 and upgraded wsl2 and everything else, even ubuntu. typing "gedit", opens up gedit beautifully. But typing "sudo gedit", gives:
cannot open display: :0
Is there any way to get native gui working for sudo too?

I was having the same issue as you but I finally managed to fix it by running wsl --update from Power Shell running in admin mode.

+1 here, powershell procedure (in admin mode) also worked for me as I went through the tutorial. Thanks all!

@MichaelChampigny I was having the same issue, I just did the following to resolve it:
a. Run PowerShell in Admin Mode. b. Execute wsl --update c. Execute wsl --shutdown d. Run gedit in Ubuntu
That resolved my issue :)

thanks a lot buddy! Solved my issue!!

just type on powershell this command
wsl --update

@MichaelChampigny I was having the same issue, I just did the following to resolve it:
a. Run PowerShell in Admin Mode. b. Execute wsl --update c. Execute wsl --shutdown d. Run gedit in Ubuntu
That resolved my issue :)

The Run PowerShell in Admin Mode is critical. Thank you.

Helped me this commands, thank you.

I got the same problem on Windows 11 and, since I was using XServer on Windows 10, I just needed to remove (or comment) these lines out:
# export DISPLAY=$(cat /etc/resolv.conf | grep nameserver | awk '{print $2}'):0
# export LIBGL_ALWAYS_INDIRECT=1

Then, I've shutdown the wsl (wsl.exe --shutdown) and it did the trick.

This is it I also had added those lines. Once I removed it worked! Thanks.

I got the same problem on Windows 11 and, since I was using XServer on Windows 10, I just needed to remove (or comment) these lines out:
# export DISPLAY=$(cat /etc/resolv.conf | grep nameserver | awk '{print $2}'):0
# export LIBGL_ALWAYS_INDIRECT=1

Then, I've shutdown the wsl (wsl.exe --shutdown) and it did the trick.

It's worked for me. Thanks!!!!

@saulotdr thanks!


Any plan to support Angular 2.0?

It's cool that ngAlertify supports Angular 1.0 very well.
However, since Angular 2.0 is RC now, any plan to support it?

The library itself doesn't actually require anything special to play nice with NG2.
I found NG2 much more friendly when it comes to pure js library usage, than NG1. You have typings for the module so you can easily use the vanilla implementation without any problems.


Invidual DHCP static host gateway override "none" fails

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x ] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
A DHCPv4 service on an interface allows setting 'gateway=none' globally. When creating a static DHCP assignment for a single host/ip/mac, under gateway overrides for that host 'gateway=none' throws an error.
This is seen as unexpected, I should be able to override this one host's gateway setting that may be global. "none" works when set at interface level - therefore an override should be possible at host level.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce

OPNsense 21.1.3-amd64FreeBSD 12.1-RELEASE-p14-HBSDOpenSSL 1.1.1j 16 Feb 2021

Steps to reproduce the behavior:

Go to Services > DHCPv4 > LAN
Click on / add a "DHCP Static Mappings " for a single host mac and IP pair.
On the newly created entry, override gateway with "none" value
See error

The following input errors were detected:

A valid IP address must be specified for the gateway.
The gateway address none does not lie within the chosen interface's subnet.

Expected behavior
Override "none" for gateway address should NOT fail in the individual static mapping page. It does work fine on the parent interface global setting "none"
Describe alternatives you considered
There isn't any other than manual overriding at client level. We want the DHCP server to respond to DHCP DISCOVER with the override values for the mac address. It's broken.
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
OPNsense on Promox VE 6.3.3

The page doesn't suggest "none" is supported, but for consistency I've added it in https://github.com/opnsense/core/commit/c4e8018fc99b9407dfbfe43473543446f3f8ddd8.


Clipping issues at high frames size

Wonderful work here, really a lifesaver.
However, I noticed that at a high frame count, the generated cube begins to clip into the camera, as seen here:

Wonderful work here, really a lifesaver. However, I noticed that at a high frame count, the generated cube begins to clip into the camera, as seen here:

Thank you for your feedback. I will attempt to fix this issue. Please stay tuned for further updates.

Thank you once again for your feedback.  This issue is related to the camera's near clipping plane.  I have already set a value for it, and it seems to have resolved your issue.  As for the appropriate value for this parameter, I will continue monitoring and testing.  Thank you for your support.
SHA：09feee2369d065e7616107b5fc9b8dd97d7de0ba


wasm plugin: Initialize SanitizationConfig

@traeak can you please take a look?
the /lib contents all come from the proxy-wasm project and I would like to keep them untouched for now.
Can the fix be done in this way and be ok? Thanks.

Cherry-picked to v10.0.x


feat: Profile page Improvement

Fixes #4438
Describe the changes you have made in this PR -
I added the section on social media profiles (Instagram, Github, twitter, linkedin) to the profile page.
I have made the required changes in the database to keep the information saved to the user's profile.
Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tanmoysrt Hey any idea why is this one check failing? The changes I made in my localhost worked fine for me as mentioned in the issue and pr.

@tanmoysrt Hey any idea why is this one check failing? The changes I made in my localhost worked fine for me as mentioned in the issue and pr.

Check the logs https://github.com/CircuitVerse/CircuitVerse/actions/runs/7346057602/job/20000198995

@tanmoysrt I have made the required corrections in the commits already as stated there.

@tanmoysrt I have made the required corrections in the commits already as stated there.

Check the logs many testcases has been failed. It maybe as you have added new fields and methods
NoMethodError:
2023-12-28T19:15:29.8399573Z  undefined method `instagram' for #<User id: nil, email<EMAIL_ADDRESS>name: "Jacquelyne Bednar", created_at: nil, updated_at: nil, provider: nil, uid: nil, admin: false, country: nil, educational_institute: nil, subscribed: true, locale: "en">

You need to fix and write new testcases for new changes as well.


修复计算虚拟网卡数量sql错误

这个 PR 实现什么功能/修复什么问题:
修复计算虚拟网卡数量sql错误
是否需要 backport 到之前的 release 分支:

release/2.11

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #1900 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1900      +/-   ##
=========================================
- Coverage    7.53%   7.52%   -0.01%
=========================================
  Files         418     418
  Lines       64735   64735
=========================================
- Hits         4875    4872       -3
- Misses      59450   59452       +2
- Partials      410     411       +1

Flag
Coverage Δ

#aFlag
7.52% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/networks.go
0.86% <0%> (ø)
:arrow_up:

pkg/util/rbacutils/rbac.go
73.83% <0%> (-0.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2884035...ebd35cd. Read the comment docs.

/lgtm
/approve


Epic - Typeahead: CSS Modules

Jira
http://vjira2:8080/browse/BDS-1807
Summary
Adds CSS Module support to the Build Tools. These updates allow for auto-generated scoped CSS selectors to keep templates, styles and JS all in sync.
Part of the broader Typeahead component work.
Details

Adds opt-in support for CSS Modules to the existing Build process.
Only components with Sass files named NAME.scoped.scss have their class names semi-randomly generated when compiling.
The way these build updates are set up, the Sass file ending in .scoped.scss is what triggers the JSON file with the key:value pairs to get generated and added to the folder the Sass file is living in. This is the critical piece in how the class names that get used in the Twig template stay in sync with the CSS getting compiled.
Javascript files pulling in .scoped.scss files also trigger this "opt-in" CSS Module behavior, however these use a different mechanism under the hood to generate the generated class names. Essentially we're using two different off the shelf approaches to handling CSS Modules that both share the same "randomly generated class name" selector logic.

How to test

Review PR changes
Confirm Travis build passing as expected
Check out the full Typeahead code branch to see how these changes actually fit into the current workflow + build process:

typeahead.scoped.json
typeahead.scoped.scss (nothing different other than the .scoped.scss file name)
typeahead.twig -- pulls in the external (dynamically generated but still committed to Git) JSON file to map to the compiled CSS class names / selectors
typeahead.js - which pulls in the scoped Sass file + maps to a modified version of the classnames helper library to match to selectors like this automatically

@christophersmith262 and @danielamorse any feedback on this before we merge this in for the upcoming v2.9.0 release?

@sghoweri thanks for the clear PR description. I get it now, and it looks like you did a nice job setting up scoped selectors in Bolt!
Couple things before I finish the review:

There are conflicts with Master that need to be resolved.
When I inspect the Typeahead component I don't see any CSS associated with elements using the scoped classnames (see staging). They're just using vanilla form styles. Is it not working or is it supposed to be unstyled?
Twig (no-JS) version has styles but no scoped classnames. Isn't Twig supposed to use the scoped classnames, too?

@danielamorse I'll need to resolve those merge conflicts but regarding the Twig-specific selectors for Typeahead, I just needed to enable the feature flag I had set up for this 😉
https://github.com/boltdesignsystem/bolt/commit/2ea655be1d9e92ddbd3c35764141b639eca853a2

I just needed to enable the feature flag I had set up for this 😉

Hmm, still not working for me. Any ideas?

I just needed to enable the feature flag I had set up for this 😉

Hmm, still not working for me. Any ideas?

@danielamorse fixed it! Had to tweak the Webpack logic after all the merging + update the Typeahead Nightwatch test to account for the semi-mangled classnames that are getting used here.
Should be good to take another look at :)

@sghoweri I looked again and the Typeahead styles still aren't working. No JS errors. Try again? Or, let me know if you're seeing something different locally.

@colbytcook closing, this is neat but at the moment we're not looking to implement randomly generated class names. I won't delete the work, just closing the PR.


ocamlPackages.alcotest: 0.4.5 -> 0.7.2

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Updated to take into account @sternenseemann’s suggestion: inheriting the installPhase.


City history

User story :
When a user clicks on a city in the search history they are again presented with current and future conditions for that city.
Acceptance criteria :

Search results are saved into local storage
when the button is clicked it returns results for the current day
when the city button is clicked it displays future conditions (forecast) for this city

Search results are saved into local storage as live URLs for those locations


check configPath IsAbs not join the pwd

run in windows got a wrong path
if I input  c:\kt\conf\a.toml
it get c:\kt\c:\kt\conf\a.toml
go I check  configPath IsAbs before join

This looks good. Thanks for the PR @weisd  :+1:


feat: pgvector vector store and a Supabase client

Closes https://github.com/hwchase17/langchainjs/issues/128
Basic implementation of supabase pgvector querying. ~No adding of vectors atm.~
Seems complicated to figure out what the schema and query is for each user.. not sure how to generalize.
Also a problem is passing through match_count in addition to k, as well as limiting tokens used.

I updated the code to match the blog post. I think thats the best way forward, assume people used the blog post exactly as is. we can extend it to handle schema changes outside the post if people come forward with them
Currently doesnt set id, or handle metadata though, because the blog post didnt.
Also I dont think we can execute raw sql
https://github.com/supabase/supabase/discussions/3419#discussioncomment-1428126
So Im not sure I can just have a prepare() fn that creates the table and query sadly

Not much to say on my end, looks good to me.
Also, first time looking at langchain, this lib looks fire 🔥

(for me) to do here

[ ] Move the sql setup code to the docs
[ ] Add an integration test
[ ] Rename to SupabaseVectorStore
[ ] Handle error

I updated the code to match the blog post. I think thats the best way forward, assume people used the blog post exactly as is. we can extend it to handle schema changes outside the post if people come forward with them
Currently doesnt use metadata though, because the blog post didnt.... Also not sure how to handle errors, throw?
Also I dont think we can execute raw sql supabase/supabase#3419 (comment)
So Im not sure I can just have a prepare() fn that creates the table and query sadly

Supabase client doesn't allow SQL but it is possible to connect directly to the database with a database client. Maybe the idea of a generic PG client would make sense.

@sbusso  yeah I found their urls and have something vaguely working with the postgres package. but then it feels like we need an abstraction so people can use whatever postgres library they want.. not sure how far to chase this.

Could go this route
export interface PGClient {
  similaritySearchVectorWithScore(
    query: number[],
    k: number
  ): Promise<[Document, number][]>;
  addVectors(
    vectors: number[][],
    documents: Document[],
    _ids?: string[]
  ): Promise<void>;
  prepare: () => void;
}

You dont even bring in any postgres libs into upstream this way just an example lib implements one, and they copy and paste it around with the example to build their schema and queries

Thanks a lot for this @jacobrosenthal

Per @jacobrosenthal's request on discord, re-posting here my message from Discord. We've merged this without the additional abstraction added in the last commits PGVectorClient because we already have an abstraction which is virtually identical, ie. the VectorStore base class, and the new abstraction didn't add anything additional specific to Postgres that warranted the additional complexity. Hope that helps, any questions let me know.


[BUG] YouTube Terms of service violation

Describe the bug
My recent app's update got rejected because of YouTube Terms of service violation:

Your app currently contains YouTube videos, but watermark is not linked to YouTube while a YouTube video is playing.

Expected behavior
https://developers.google.com/youtube/terms/branding-guidelines

Any YouTube logo used within an application must link back to YouTube content or to a YouTube component of that application

Screenshots

Was your application rejected over at the App Store or Google Play Store ?

Google Play Store

Which package are you using?

youtube_player_flutter: ^7.0.0+7

If you're using your custom controls then consider hiding the logo with some overlay on Paused state and you can place your own implementation of YouTube button in the overlay that redirects to YouTube.

So there is no parameter to control the visibility of the logo or what it should do when the logo is tapped.

No. But the Youtube logo goes away if you use web controls, which is default for youtube_player_iframe.

Okay, so a solution would be to download the Youtube logo from here .
Then use a package like url_launcher to open the Youtube application or website whilst passing the id for that particular video ?

OK. I placed a container with 1/4 width and 1/4 height on the bottom right corner. When it's tapped, the app will open our YouTube Channel. I will update here if Google Play's reviewers reject the app again.

@zjamshidi Any update ?

I submitted a new app update, and they approved it.

placed a container with 1/4 width and 1/4 height on the bottom right corner

I have few questions regarding it:

Do I need to show title and Icon all the time or only when the overlay is shown?
On tapping YouTube icon, should the link direct to the video on YouTube or can I direct just to the channel? YouTube branding guidelines mentions that the logo must link back to YouTube content or to a YouTube component of that application.

@zjamshidi

placed a container with 1/4 width and 1/4 height on the bottom right corner

I have few questions regarding it:

Do I need to show Icon all the time or only when the overlay is shown?
Do I need to show title at all? Or only when the overlay is shown?
On tapping YouTube icon, should the link direct to the video on YouTube or can I direct just to the channel? YouTube branding guidelines mentions that the logo must link back to YouTube content or to a YouTube component of that application.
Also Overlays and frames mentions that You must not display overlays, frames, or other visual elements in front of any part of a YouTube embedded player, including player controls. Similarly, you must not use overlays, frames or other visual elements to obscure any part of an embedded player, including player controls. Does this mean that you can't have your own custom controller?

Do I need to show Icon all the time or only when the overlay is shown?
Do I need to show title at all? Or only when the overlay is shown?

The logo and the title are shown by the library. The problem is the logo is shown but it's not linked to Youtube

On tapping YouTube icon, should the link direct to the video on YouTube or can I direct just to the channel? YouTube branding guidelines mentions that the logo must link back to YouTube content or to a YouTube component of that application.

I linked the logo to our youtube channel as our application's Youtube component

Also Overlays and frames mentions that You must not display overlays, frames, or other visual elements in front of any part of a YouTube embedded player, including player controls. Similarly, you must not use overlays, frames or other visual elements to obscure any part of an embedded player, including player controls. Does this mean that you can't have your own custom controller?

I added an invisible clickable frame over the video player to make the logo tappable.


Race condition

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:
http://bl.ocks.org/donflopez/ae47b6aecee96a2058e5538e530f580f
RESULT:
It throws an error:
tangram.min.js:12 Uncaught TypeError: Cannot read property 'hasPendingRequests' of null
    at e.value (tangram.min.js:12)
    at e.value (tangram.min.js:12)
    at e.hooks.move (tangram.min.js:11)
    at e.fire (leaflet.js:5)
    at e._onPanTransitionStep (leaflet.js:9)
    at e.fire (leaflet.js:5)
    at e._runFrame (leaflet.js:9)
    at e._step (leaflet.js:9)
    at e._animate (leaflet.js:9)

EXPECTED RESULT:
No error
ENVIRONMENT:
Any environment.
OTHER:
Take a look at this PR, it is right?

Ups, I've seen this just now, sorry!


How can I make texts still loop scroll, even through texts fit container ?

Thanks for the awesome lib! Now I wanna my texts scroll loop, even texts are short, how can I achieve this effect?

Thanks!
Its been a while since I looked at the code but it seems like you're right. If the text is small enough to fit then there's no way to make it still scroll.
The code that makes it happen is on line 191 in index.js.
I'd be happy to accept a pull request that adds a new prop to override this.
Something like:
  shouldBounce: (this.props.forceBounce) || this.distance < this.containerWidth / 8

I've tried your advise, add a prop 'forceBounce' to the lib, but it didn't work. What's more, it would make loop feature fail, LoL~

#25 Will be going out in the latest release and should fix your issue

Thanks for the library, too 👍
hmm may I seek the reason why forceBounce be remove in new version? QQ.


Update docker setup guide

#1599  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Java Test Report expanding/collapsing tests opens up a new blank page tab on each click

OS/Web Information

Web Browser: Chrome/Brave/Firefox
Local OS: Mac OS X Catalina, Windows 10
Remote OS: Ubuntu 20.04
Remote Architecture: Clean install of Ubuntu and code-server, not dockerized.
code-server --version: 3.9.3

Steps to Reproduce

Install java extensions pack form market place (microsoft market place, install manually)
run a java test, after java test report comes up, attempt to expand the failed test to reveal the failed reason
when clicking on to expand the failed tests, a separate tab opens with with a link to a blank page.

Expected

Expanding/Collapsing tests in the report should'nt open a web page that leads no where.
Actual

A separate tab opens up on each click to collapse/expand a test result. This does not happen in the official msft vscode desktop release, only on code-server.
Logs

The most recent files from ~/.local/share/code-server/coder-logs = Logs are empty, (code-server-stderr.log) and (code-server-stdout.log) files are empty.

The browser console,

The browser network tab.

Screenshot

https://user-images.githubusercontent.com/60336163/117546486-80e52200-afdf-11eb-9918-9432f3ed2c6b.mov
Notes

Not reproducible in vanilla vscode, works as expected.
This issue can be reproduced in VS Code: No.

I've done some further digging and revering to version 0.27.0 of the extension fixes this issue. I then installed 0.28.0 and issue came back. So something about the changes in 0.28.0 and later versions produces this error.


the dep lib portable-atomic is outdated

Would you update the  portable-atomic to 1.6?  thx

sure, thanks for telling me

should be done in 0.2.1


Compiled binary segfaults when run

Here's my test Nim program:
import myprogramapppkg/submodule

when defined napibuild:
  # Running `denim build myprogram.nim` compiles with `-d:napibuild`
  import denim # NAPI bindings
  import jsony

  init proc(module: Module) =
    module.registerFn(0, "getWelcomeMessage"):
      return %* getWelcomeMessage()

elif isMainModule:
  echo(getWelcomeMessage())

When I run the binary created in the bin directory I get a segfault 11. I suspect node-gyp has a problem somewhere. When I searched on this problem I saw that people logged similar issues for previous versions of node-gyp, but those are fixed by now.
Version information:
$ node --version
v18.16.0
$ node-gyp --version
v9.4.0
$ nim --version
Nim Compiler Version 1.6.12 [Linux: amd64]
Compiled at 2023-03-10
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: 1aa9273640c0c51486cf3a7b67282fe58f360e91
active boot switches: -d:release

All good here. This is weird. Try with bun?
Btw, jsony is not necessary here.
$ node -v
v18.16.1

$ node-gyp --version
v9.4.0

Nim Compiler Version 1.6.12 [Linux: amd64]
Compiled at 2023-03-10
Copyright (c) 2006-2023 by Andreas Rumpf

git hash: 1aa9273640c0c51486cf3a7b67282fe58f360e91
active boot switches: -d:release

I upgraded to Node 18.16.1, but it didn't help. I'm running Fedora, but that shouldn't be a problem.
How would I test with Bun? Does it have its own extension compiler?

No, but you can try run the compiled .node addon with Bun.

Here's a similar issue someone has with a Go add-on segfaulting: https://github.com/nodejs/node-gyp/issues/2695. Although their case segfaults at the end, while mine segfaults at the very beginning. That's why I think this is a node-gyp issue.

I might try Bun, but I'm not optimistic.
My gcc version: (GCC) 13.1.1 20230614 (Red Hat 13.1.1-4).


LLAMA-2652 Device is getting stuck in stanby after start Maintenance …

…start
Reason for change: Removing Request Reboot call as no action on it.
Test Procedure: build procedure
Risks: None
Signed-off-by: Michael Anand<EMAIL_ADDRESS>

Abandon


node: Json standard support

Describe the feature
JSON command support for Node.js
Follow-up ticket: #2529
Commands
Full list is listed in https://github.com/valkey-io/valkey-glide/wiki/ValKey-Commands-Implementation-Progress#json-module

[ ] JSON.CLEAR - #2566
[ ] JSON.DEBUG - https://github.com/valkey-io/valkey-glide/pull/2572
[x] JSON.DEL - https://github.com/valkey-io/valkey-glide/pull/2505
[x] JSON.FORGET - https://github.com/valkey-io/valkey-glide/pull/2505
[x] JSON.GET https://github.com/valkey-io/valkey-glide/pull/2427
[x] JSON.RESP https://github.com/valkey-io/valkey-glide/pull/2510
[x] JSON.SET https://github.com/valkey-io/valkey-glide/pull/2427
[x] JSON.STRAPPEND - #2537
[x] JSON.STRLEN - #2537
[x] JSON.TOGGLE https://github.com/valkey-io/valkey-glide/pull/2491
[x] JSON.TYPE https://github.com/valkey-io/valkey-glide/pull/2510

Finished JSON TOGGLE, TYPE, RESP
Full list is listed in https://github.com/valkey-io/valkey-glide/wiki/ValKey-Commands-Implementation-Progress#json-module

[ ] JSON.ARRAPPEND
[ ] JSON.ARRINDEX
[ ] JSON.ARRINSERT
[ ] JSON.ARRLEN
[ ] JSON.ARRPOP
[ ] JSON.ARRTRIM
[ ] JSON.CLEAR
[ ] JSON.DEBUG
[ ] JSON.DEL
[ ] JSON.FORGET
[x] JSON.GET https://github.com/valkey-io/valkey-glide/pull/2427
[ ] JSON.MGET
[ ] JSON.NUMINCRBY
[ ] JSON.NUMMULTBY
[ ] JSON.OBJLEN
[ ] JSON.OBJKEYS
[x] JSON.RESP https://github.com/valkey-io/valkey-glide/pull/2510
[x] JSON.SET https://github.com/valkey-io/valkey-glide/pull/2427
[ ] JSON.STRAPPEND
[ ] JSON.STRLEN
[x] JSON.TOGGLE https://github.com/valkey-io/valkey-glide/pull/2491
[x] JSON.TYPE https://github.com/valkey-io/valkey-glide/pull/2510

finished RESP, STRLEN, STRAPPEND, DEBUG is in review


Issues about fixed the FPS

Hello,
When I run fcn-resnet18-cityscapes-512x256 on Jetson Xavier, the FPS is too high for me.
Can I make the FPS at a fixed value, such as 60?
Looking forward to u reply.

@zhuzhuxia1221 sorry for the delay - you should limit the framerate from the camera, or add the equivalent of a sleep() call to slow down the processing.


Crucial Info missing..

[This page talks about starting with first "Chat, teams, channels, & apps in Microsoft Teams" for the phased options, but it does not even talk about how to set it up for these features/workload only and other options Meetings and voice features are turned off.  please update the articles with step by steps guidance so people can turn on only "Chat, teams, channels, & apps in Microsoft Teams" and other things are turned off. thanks ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c73be3fd-282d-8e5a-02f8-37d2f27c95ab
Version Independent ID: 0baeeca3-237f-31dc-d3da-35140b9ebb9a
Content: Chat, teams, channels, & apps in Microsoft Teams - Microsoft Teams
Content Source: Teams/deploy-chat-teams-channels-microsoft-teams-landing-page.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

@M365GitHubCloud  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@M365GitHubCloud Thank you for reaching out. At a quick glance, I see that this article was updated a few days ago with new information. Please check and confirm if it's still missing crucial information. Thank you.

We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Automatically set first created state as initial state

Proposed feature or solution
As every machine I've ever seen has the initial state as q0 and the first created state has the default name of q0, I believe it would lead to a better user experience to automatically set it as the initial state. Doing this would save the average user two clicks (right click & click on menu)  and make the program more convenient to use.
This also wouldn't inconvenience users who want to use another state as the initial state, as by setting an initial state it would automatically unset the current one.
Alternatives
No response
Additional information
No response

Banger idea


Fix for cdb.admin.WizardProperties test

Due to a randomly failing non-deterministic client-side test in cdb.admin.WizardProperties I decided to take a stab at it while waiting for the results of the next build. I figured the setTimeout was the culprit so I refactored the test case to use the async mechanism provided by Jasmine (the done callback).
But for some reason the tests continued to fail randomly, so I changed the assertion to:
expect(t1).toBeGreaterThan(t0)

But the test still continued to fail sometimes, but now I could see why:
$ grunt jasmine --filter="wizards.spec.js"
Running "jasmine:cartodbui" (jasmine) task
Testing jasmine specs via PhantomJS

............................X.............

Summary (1 tests failed)
X cdb.admin.WizardProperties when column is removed should active polygon
   Expected<PHONE_NUMBER>802 to be greater than<PHONE_NUMBER>802.
   Error: Expected<PHONE_NUMBER>802 to be greater than<PHONE_NUMBER>802.
       at stack (file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1455)
       at buildExpectationResult (file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1425)
       at file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:572
       at file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:321
       at addExpectationResult (file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:516)
       at file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1386
       at file:///Users/viddo/src/cartodb/lib/assets/test/spec/cartodb/models/wizards.spec.js:359
       at attemptSync (file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1741)
       at file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1729
       at file:///Users/viddo/src/cartodb/.grunt/grunt-contrib-jasmine/jasmine.js:1753

42 specs in 1.076s.
>> 1 failures
Warning: Task "jasmine:cartodbui" failed. Use --force to continue.

Aborted due to warnings.
Task 'jasmine:cartodbui' took 3462ms
All tasks took 3462ms

So apparently t0 and t1 sometimes ends up having the same value... not very reliable. By the look of the spec it seems the intention is to verify the callbacks are called in a certain order, so I changed the expectation to check for that instead, and now the spec seems to work fine.
Conclusions:

Please don't use setTimeout in test cases. They are unreliable and when accumulated they slow down the test suite significantly, use the provided async mechanism instead.
Don't use +Date() to do comparisons of order, since the value may not be unique. Use something that can be checked consistently instead.

The test case is the same, simply refactored it to have the setup in a beforeEach block, and each assertion in its own it block.

Frontend tests were OK :+1: (details)

@CartoDB/frontend Please read the PR desc (all of you ;)).
Not many changes, but can someone please verify that I didn't miss anything too? Also, with the changed assertion for the call order I also discovered that one callback is called twice but that perhaps doesn't matter?

@javisantana, do you remember why we set that value?

Read :ok_hand:

no idea

If we don't know then I suggest to leave it as it is/was, OK to merge?

:jp:


AIS Test Account setup guide outdated recommendations

The documentation at https://github.com/SwisscomTrustServices/pdfbox-ais-client/blob/main/docs/get-authentication-details.md#ais-test-account needs to be updated. It suggests to generate a 2048 bit key while apparently, starting from 2023, Swisscom requires certificates to be based on 3072 bit keys.

@pwgr - Swisscom still support 2048 bit key, but recommend using of 3072 bit keys.


Progress HTTP service replaces flask archive API:

[ ] Accept POST /storage/ingests in DisplayIngest model
[ ] Send to SNS topic as IngestBagRequest

[ ] Subscribe archivist queue

DUPE!


No target folder created inside spring-cloud-function/spring-cloud-function-samples/function-sample after successful build from the root folder

Describe the bug
Please provide details of the problem, including the version of Spring Cloud that you
are using.
Latest
Sample
If possible, please provide a test case or sample application that reproduces
the problem. This makes it much easier for us to diagnose the problem and to verify that
we have fixed it.

./mvnw clean install - build passed without error
ls -l spring-cloud-function-samples/function-sample/target
ls: cannot access 'spring-cloud-function-samples/function-sample/target': No such file or directory
java -jar spring-cloud-function-samples/function-sample/target/.jar
Error: Unable to access jarfile spring-cloud-function-samples/function-sample/target/.jar

I am puzzled as to why would you expect the .jar file? This is not how maven/java packaging works.
JAR files have names which in maven builds matches <artifactId>-<version>.jar, so what you should be looking for is function-sample-2.0.0.RELEASE.jar

Did not generate any jar inside target folder and don't teach me how Maven
works
See the outcome of the ls *.jar command
On Thu, Sep 9, 2021, 2:14 AM Oleg Zhurakousky @.***>
wrote:

I am puzzled as to why would you expect the .jar file? This is not how
maven/java packaging works.
JAR files have names which in maven builds matches
-.jar, so what you should be looking for is
function-sample-2.0.0.RELEASE.jar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-cloud/spring-cloud-function/issues/738#issuecomment-915794861,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVCSSD5C3Z7UBNJCLBGTI3DUBBGFBANCNFSM5DPYSUTA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


fix README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 89.29%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
3043

Relevant Lines:
3408

💛  - Coveralls


Argument 1 (NSTimeInterval) of RCTTiming.createTimer must not be null

This error appears on swipe:

Also tried using https://github.com/manandmoon/react-native-swiper but same error appears.

try the new version please


Add clear option in optimize, and pass it as true in GitHub action

Otherwise old files are piling up and the deploy branch becomes a massive mess.

(also the emergency option is to checkout gh-pages, rm everything, add everything (so effectively delete evertyhing on the repo branch) and then re-triggering from master.


project pages violates CORS and cannot be loaded

We got a report from @msehnout that they cannot load https://dashboard.packit.dev/projects/github.com/osbuild/osbuild
Easily reproducible, the error is:
Unable to connect
There was an error retrieving data.

Console seems to suggest that:
Access to fetch at 'https://prod.packit.dev/api/projects/github.com/osbuild/osbuild' from origin 'https://dashboard.packit.dev' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Do we just need to set some CORS-related header to make browsers happy?

https://prod.packit.dev/api/projects/github.com/osbuild:
[
    {
        "namespace": "osbuild",
        "repo_name": "osbuild",
        "project_url": "https://github.com/osbuild/osbuild/osbuild",
        "prs_handled": 0,
        "branches_handled": 0,
        "releases_handled": 0,
        "issues_handled": 0
    },
    {
        "namespace": "osbuild",
        "repo_name": "osbuild",
        "project_url": "https://github.com/osbuild/osbuild",
        "prs_handled": 28,
        "branches_handled": 4,
        "releases_handled": 0,
        "issues_handled": 2
    }
]

related to packit/packit-service#797

@mfocko Good catch!

@lachmanfrantisek I could probably fit it in the card, also I'm wondering if it makes sense to have projects with no associated builds, maybe I should check against the DB how many rows does it affect

@mfocko Can you please update the card/description to match the actual problem? (So do some database clean up.) What about closing in favour of packit/packit-service#797 update that one to cover this problem?

@lachmanfrantisek will do


[zh-cn] resync kustomization.md

Resync the text by following the en upstream #35522.
content/zh-cn/docs/tasks/manage-kubernetes-objects/kustomization.md

Preview: https://deploy-preview-35911--kubernetes-io-main-staging.netlify.app/zh-cn/docs/tasks/manage-kubernetes-objects/kustomization/

/lgtm


nTweaks status

Hey @nallar
I was wondering what the current status of this project is. Is it abandoned, will it be continued. I would really like to use it in production mode as mobs/mobspawning seems to be quite heavy:

1270v3
16 players
8 tps
70-80% (90-100ms) mobs according to tickProfiler (mainly squid's and hostile)
mobs are spread over the whole world (no big mob farm)

Not working on it much (you can tell by how long it took to notice this issue :P).
Occasionally making changes, and the existing patches should be fine for production use. Incompatible with some mods which have world leak issues, so you may need to turn off the world cleaning and world unloading patches if that's a problem.

yeah, I noticed :D @nallar any chance on accepting the java patcher pull req and updating the maven repo + modpatcher depend? I would like to use the official repo.

I'm having some trouble building ModPatcher - Gradle's being unhappy, guessing something changed that conflicts with the weird build.gradle. Will need to get that sorted first.


Zoom and pan (with animate) methods zoom into the wrong point in contain mode

Describe the bug
Sorry, I don't understand how to use jsbin. So I wrote the example here.
I am trying to zoom in to the point I want. I add focal to the zoom function, but it does not zoom to the point I want.
When the "contain" setting is "outside", zoom and pan (with animate) methods zoom into the wrong point when called consecutively.
The "pan" method looks glitchy when delayed by "setTimeOut".
Your environment
panzoom: 4.1.0
Mozilla Firefox 75 (64 Bit)
Expected behavior
Steps to reproduce
https://codepen.io/harebuus/pen/JjYOdjX

Is there any improvement about this, and I am having the same problem. @timmywil @harebuus

The point is wrong because it needs to finish painting to get proper dimensions for containment. As you pointed out, the README suggests wrapping the second call in setTimeout to wait for the paint and get proper dimensions. However, if you're trying to animate the calls, that wouldn't work so well. What would work is if you knew the exact point ahead of time, but I'll have to think on this.

Thanks. I am following for this development.

I was looking at this again. I'd like to avoid duplicating all the calculations the browser does for you. This is part of what keeps Panzoom so lightweight. It seems all you need is a zoom method that will zoom to the right spot. The contain option can have some side effects, but the focal option is expected to be translated to its post-zoom coordinates. So, I realized I already wrote a method for this. I just don't use it outside of zooming with wheel very often. Try the zoomToPoint method instead of the focal option and I think you'll get much closer to what you're expecting.
https://codepen.io/timmywil/pen/PoPvoYp


Validation in / not in breaks with values ending in backslash

Laravel Version
10.29.0
PHP Version
8.2.14
Database Driver & Version
No response
Description
In and NotIn validation rules do not work correctly for values ending in backslash.
Steps To Reproduce
Execute the following tinker commands:
Validator::make(['a' => 'b\\'], ['a' => Illuminate\Validation\Rule::notIn('b\\')])->passes();
Validator::make(['a' => 'b\\c'], ['a' => Illuminate\Validation\Rule::notIn('b\\c')])->passes();

First validator passes, seconds fails as expected. First should fail too.

The Validator uses the function str_getcsv($parameter) inside the validation cycle to hydrate the Validation Rules based on a string. In your example not_in:"b\" the problem is, that the function str_getcsv uses \" as an escape and enclose character. So the value the parser will output will be b\" and that is not b\ so the validation passes. I don't really have an idea on how to fix this
But the probleme is here: https://github.com/laravel/framework/blob/fc453b908fc41fea8b428260b2d4f3527d046bf8/src/Illuminate/Validation/ValidationRuleParser.php#L283

This might not be the prettiest solution, but it seems to work.
protected static function parseParameters($rule, $parameter)
{
     $parameters = static::ruleIsRegex($rule) ? [$parameter] : str_getcsv(
         str_replace('\\\\', '__BACKSLASH__', trim($parameter, '"'))
     );
     return str_replace('__BACKSLASH__', '\\\\', $parameters);
 }

I don't know if there are any security concerns, but I could do a PR and implement this.

Looks like for now, we're not going to support this, sorry.


Need to escape argument with space

I have test functions having space in it's name. If I run it via mirakle, build is failed. I think that gradle arguments are send to remote server well, but some arguments need to be escaped.
I've test on gradle 7.2 / mirakle 1.5.0
Here's my gradle command
 ./gradlew testDebugUnitTest --tests "MyUnitTestClass.testFunction haha"
============REMOTE GRADLE ARGUMENTS===============
-Pmirakle.build.on.remote=true
...
--tests
MyUnitTestClass.TestFunction haha   // <-- arguments sent well. but not escpaed?
...
============REMOTE GRADLE ARGUMENTS===============
...
FAILURE: Build failed with an exception.

* What went wrong:
Task 'haha' not found in root project 'MyProject'.

You can reproduce this by create an unit test and make a  function with space in it's name just like below
class MyUnitTestClass {
   @Test
   fun `testFunction haha`() {
     ...
   }
}

If I run command like below ( added extra escaping) , build succeed.
./gradlew testDebugUnitTest --tests "\"MyUnitTestClass.testFunction haha\""
============REMOTE GRADLE ARGUMENTS===============
-Pmirakle.build.on.remote=true
...
--tests
"MyUnitTestClass.testFunction haha"
...
============REMOTE GRADLE ARGUMENTS===============


Can't get this working with Expo

Describe what happened
I can't get the DataDog SDK working within my expo project. I'm getting a couple different errors.
One at the prebuild stage
✖ Config sync failed
SyntaxError: [ios.entitlements]: withIosEntitlementsBaseMod: Expected "/*" or ";" but "e" found.

And another at the run:ios stage.
TypeError: null is not an object (evaluating '_foundation.DdSdk.initialize')

I created a new minimal expo project. At a high level, here's what I'm doing.
# Create new expo project
yarn create expo-app datadog-expo-issue
cd datadog-expo-issue/

# Install expo-datadog and dependencies
yarn expo install expo-dev-client expo-datadog @datadog/datadog-ci

# Export MARKETING_VERSION and DATADOG_API_KEY
cp ../template/.envrc .
direnv allow

# Add datadog configuration and initialize
cp ../template/App.js .

# $ git diff App.js
# diff --git a/App.js b/App.js
# index 09f879b..4c77950 100644
# --- a/App.js
# +++ b/App.js
# @@ -1,6 +1,19 @@
#  import { StatusBar } from 'expo-status-bar';
#  import { StyleSheet, Text, View } from 'react-native';
#
# +import { DdSdkReactNative, DdSdkReactNativeConfiguration } from "expo-datadog";
# +
# +const config = new DdSdkReactNativeConfiguration(
# +  "<CLIENT_TOKEN>",
# +  "local",
# +  "<APPLICATION_ID>",
# +  false, // track user interactions such as tapping on a button. You can use
# +  false, // track XHR resources.
# +  false // track errors.
# +);
# +
# +DdSdkReactNative.initialize(config);
# +
#  export default function App() {
#    return (
#      <View style={styles.container}>

# Prebuild

yarn expo prebuild

# yarn run v1.22.15
# datadog-expo-issue/node_modules/.bin/expo prebuild
#
# 📝  Android package Learn more: https://expo.fyi/android-package
#
# ✔ What would you like your Android package name to be? … datadogexpoissue
#
#
# 📝  iOS Bundle Identifier Learn more: https://expo.fyi/bundle-identifier
#
# ✔ What would you like your iOS bundle identifier to be? … datadogexpoissue
#
# ✔ Created native projects | gitignore skipped
# ✔ Added Metro config
# ✔ Updated package.json and added index.js entry point for iOS and Android
# › Removed "main": "node_modules/expo/AppEntry.js" from package.json because we recommend using index.js as main instead
#
# › Installing using Yarn
# Using node to generate images. This is much slower than using native packages.
# › Optionally you can stop the process and try again after successfully running `npm install -g sharp-cli`.
#
# ✖ Config sync failed
# SyntaxError: [ios.entitlements]: withIosEntitlementsBaseMod: Expected "/*" or ";" but "e" found.
# SyntaxError: [ios.entitlements]: withIosEntitlementsBaseMod: Expected "/*" or ";" but "e" found.
#     at peg$buildStructuredError (datadog-expo-issue/node_modules/xcode/lib/parser/pbxproj.js:429:12)
#     at Object.peg$parse [as parse] (datadog-expo-issue/node_modules/xcode/lib/parser/pbxproj.js:1891:11)
#     at pbxProject.parseSync (datadog-expo-issue/node_modules/xcode/lib/pbxProject.js:63:24)
#     at getPbxproj (datadog-expo-issue/node_modules/@expo/config-plugins/build/ios/utils/Xcodeproj.js:404:11)
#     at ensureApplicationTargetEntitlementsFileConfigured (datadog-expo-issue/node_modules/@expo/config-plugins/build/ios/Entitlements.js:132:47)
#     at getFilePath (datadog-expo-issue/node_modules/@expo/config-plugins/build/plugins/withIosBaseMods.js:393:79)
#     at action (datadog-expo-issue/node_modules/@expo/config-plugins/build/plugins/createBaseMod.js:68:34)
#     at interceptingMod (datadog-expo-issue/node_modules/@expo/config-plugins/build/plugins/withMod.js:126:27)
#     at evalModsAsync (datadog-expo-issue/node_modules/@expo/config-plugins/build/plugins/mod-compiler.js:256:31)
#     at async Object.compileModsAsync (datadog-expo-issue/node_modules/@expo/config-plugins/build/plugins/mod-compiler.js:160:10)
# error Command failed with exit code 1.
# info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

# Is the config plugin really necessary?
# Seems like it only uploads debug symbols and source maps
jq 'del(.expo.plugins)' app.json > app.json.new && mv app.json.new app.json
yarn expo prebuild --clean
yarn expo run:ios

# ...
# › Installing on iPhone 14 Pro Max
# › Opening on iPhone 14 Pro Max (datadogexpoissue)
# › Opening datadogexpoissue://expo-development-client/?url=http%3A%2F%2F<IP_ADDRESS>%3A8081 on iPhone 14 Pro Max
#
# › Logs for your project will appear below. Press Ctrl+C to exit.
# iOS Bundling complete 5760ms
#  WARN  Possible Unhandled Promise Rejection (id: 0):
# TypeError: null is not an object (evaluating '_foundation.DdSdk.initialize')
# @http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:120077:28
# tryCallTwo@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:30625:9
# doResolve@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:30789:25
# Promise@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:30648:14
# initialize@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:120036:27
# @http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:119572:43
# loadModuleImplementation@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:290:14
# @http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:1357:48
# loadModuleImplementation@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:290:14
# guardedLoadModule@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:163:47
# global code@http://<IP_ADDRESS>:8081/index.bundle?platform=ios&dev=true&hot=false:121704:4
# › Stopped server
# ✨  Done in 151.29s.

Additional context
$ yarn list --pattern expo-datadog
yarn list v1.22.15
└─<EMAIL_ADDRESS>✨  Done in 0.18s.

$ cat package.json
{
  "name": "datadog-expo-issue",
  "version": "1.0.0",
  "scripts": {
    "start": "expo start --dev-client",
    "android": "expo run:android",
    "ios": "expo run:ios",
    "web": "expo start --web"
  },
  "dependencies": {
    "@datadog/datadog-ci": "^1.13.3",
    "expo": "~46.0.9",
    "expo-datadog": "^45.0.0",
    "expo-dev-client": "~1.2.1",
    "expo-status-bar": "~1.4.0",
    "react": "18.0.0",
    "react-native": "0.69.5",
    "expo-splash-screen": "~0.16.2",
    "react-dom": "18.0.0",
    "react-native-web": "~0.18.7"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9"
  },
  "private": true
}

Hi @onlyanegg, thanks for reaching out!
expo-datadog is not yet supporting Expo 46 - which includes a change in the iOS build phase where we upload js source maps to Datadog.
We're currently bringing support for Expo 46 - see https://github.com/DataDog/dd-sdk-reactnative/pull/272.

Thanks for getting back to me @louiszawadzki !
When I downgrade expo to 45, I'm still getting that second error
[Unhandled promise rejection: TypeError: null is not an object (evaluating '_foundation.DdSdk.initialize')]

Seems like there's nothing related to datadog within the Podfile.lock, and when I look at NativeModules, DdSdk is not defined.

Figured it out. TLDR: Install @datadog/mobile-react-native
I was looking into how native library linking works and saw this line

At the startup, React Native CLI reads configuration from all dependencies listed in package.json and reduces them into a single configuration.

And realized that the Pod spec was in the @datadog/mobile-react-native package which wasn't getting read by react-native since it wasn't a direct dependency of my app.
I see that that's part of your PR.
Anyway, thanks again! I appreciate your prompt response. You can probably close this now :)

I still face this issue on Expo 46, shouldn't it be fixed already?
prebuild / EAS Build:
✖ Config sync failed
SyntaxError: [ios.entitlements]: withIosEntitlementsBaseMod: Expected "/*" or ";" but "e" found.

Fixed the build issue upgrading expo-datadog to 46.0.0


fix(errors): display snackbar on error

Codecov Report

Merging #100 (08e2b66) into master (ee56da1) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   50.46%   50.30%   -0.16%
==========================================
  Files          28       28
  Lines         650      646       -4
  Branches       59       59
==========================================
- Hits          328      325       -3
+ Misses        304      303       -1
  Partials       18       18

Impacted Files
Coverage Δ

src/app/configs/configs.component.ts
45.45% <0.00%> (-0.38%)
:arrow_down:

src/app/domains/domains.component.ts
45.45% <0.00%> (-2.38%)
:arrow_down:

src/app/profiles/profiles.component.ts
90.90% <0.00%> (-0.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee56da1...08e2b66. Read the comment docs.


[Question] OPT_REFERRALS

How to enable option that is similar to the OPT_REFERRALS in the python libraries?

You can't, since there is no referral chasing support in the library, and I don't plan to add it. Referral chasing is woefully underspecified, especially regarding the security properties of further connections, and IMO is best handled through environment-specific code.
The adapter framework supplied by the crate should be sufficient to implement referral chasing, and I'm interested in any deficiencies encountered in such an implementation, but I'm not going to write it myself.


feature: Fast-lane upgrade of CLI to latest version

Add code to postCreateCommand scripts which auto-upgrades the CLI to the latest available version.

@doosuu refined it a bit


cmd/compile: optimize append performance

Using go devel +ed4a27a
I ran the following benchmarks:
func BenchmarkFoo(b *testing.B) {
    a := make([]byte, 1000)
    b.SetBytes(int64(len(a)))

    for i := 0; i < b.N; i++ {
        var n int
        for j := 0; j < 1000; j++ {
            a[n] = byte(j)
            n++
        }
        a = a[:n]
    }
}

func BenchmarkBar(b *testing.B) {
    a := make([]byte, 1000)
    b.SetBytes(int64(len(a)))

    for i := 0; i < b.N; i++ {
        a = a[:0]
        for j := 0; j < 1000; j++ {
            a = append(a, byte(j))
        }
    }
}

Currently I see:
BenchmarkFoo-4   3000000           588 ns/op    1700.17 MB/s
BenchmarkBar-4   2000000           871 ns/op    1147.11 MB/s

I expect to see these two to perform about the same.
@klauspost

Dup of #11419?
I'm not sure I'd expect them to be equal, though. append is a runtime call and will be more expensive than not making a call.

similar to #14718
Here its slightly different in that the a have the same cap at the end.
But the argument that one is a runtime call i would share and so they can never be equal.
But maybe the gap can be narrowed...

This is unrelated to either #11419 or #14718.  It should be fixable.
We inline the easy part of append in the compiler.  a = append(a, b) compiles to something like:
if len(a) == cap(a) {
  a = ...some runtime call...
}
a[len(a)] = b
len(a)++

The branch is predicted not taken (and will never be taken in this case), so the grow path is out-of-line.
The inner loop of BenchmarkFoo is:
	0x006b 00107 (/home/khr/go/issue14758.go:12)	CMPQ	BP, AX
	0x006e 00110 (/home/khr/go/issue14758.go:12)	JCC	$0, 173
	0x0070 00112 (/home/khr/go/issue14758.go:12)	MOVB	BPB, (BX)(BP*1)
	0x0074 00116 (/home/khr/go/issue14758.go:11)	INCQ	BP
	0x0077 00119 (/home/khr/go/issue14758.go:11)	CMPQ	BP, $1000
	0x007e 00126 (/home/khr/go/issue14758.go:11)	JLT	$0, 107

The inner loop of BenchmarkBar is:
	0x0083 00131 (/home/khr/go/issue14758.go:26)	LEAQ	1(BP), SI
	0x0087 00135 (/home/khr/go/issue14758.go:26)	MOVQ	SI, "".autotmp_0012+72(SP)
	0x008c 00140 (/home/khr/go/issue14758.go:26)	CMPQ	SI, AX
	0x008f 00143 (/home/khr/go/issue14758.go:26)	JGT	$0, 191
	0x0091 00145 (/home/khr/go/issue14758.go:26)	MOVB	$0, (DX)(BP*1)
	0x0095 00149 (/home/khr/go/issue14758.go:26)	MOVQ	SI, BP
	0x0098 00152 (/home/khr/go/issue14758.go:20)	MOVQ	BP, "".autotmp_0011+80(SP)
	0x009d 00157 (/home/khr/go/issue14758.go:25)	CMPQ	BP, $1000
	0x00a4 00164 (/home/khr/go/issue14758.go:25)	JLT	$0, 131

I suspect that most of the time is lost with the extra writes to those autotmp variables.  We might be able to lift those writes to after the loop, or get rid of them altogether.  David was thinking about this at some point.
@dr2chase

Just for context, this came up in CL/20513, and provided a very small performance boost of ~1% when the slice length was tracked manually.
This is not a priority, but a nice to have.

On tip (to-be-1.9) I see:
name   time/op
Foo-4   1.02µs ± 1%
Bar-4   1.02µs ± 0%

name   speed
Foo-4  977MB/s ± 1%
Bar-4  978MB/s ± 0%

I guess this is fixed, so I'm closing this issue.

Looks like actually is BenchmarkFoo that got slower on tip; so they're not the same (on tip) because Bar got faster, but because Foo got slower (resp. go1.8). Reopening (and sorry for the noise).

The original bug was fixed recently with better spill code generation: https://go-review.googlesource.com/c/34822/
The regression from 1.8 is #15837

@randall77, does that mean this bug should be closed, or ... ?

Well, I suspect the regression is because of #15837.  Leave this open so I can double-check after I get a fix together for that issue.


Merge ms

Codecov Report

Merging #188 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   53.16%   53.15%   -0.01%
==========================================
  Files         343      343
  Lines       26411    26414       +3
  Branches     3442     3443       +1
==========================================
  Hits        14041    14041
- Misses      11651    11654       +3
  Partials      719      719

Impacted Files
Coverage Δ

lib/python/treadmill/sproc/tickets.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfd2676...b601b5b. Read the comment docs.


Expose textAlign on TextFormField

Fixes #11404

This seems reasonable but we should probably have a test to make sure it works as expected (and more importantly, to make sure we don't accidentally remove it one day while "cleaning up"!)
cc @HansMuller who is working on text fields.
cc @cbracken who has worked on TextFormField recently.

Right, sound good! I took inspiration from text_form_field_demo_test.dart and text_field_test.dart to setup a test case.
Since this is my first patch to Flutter I'm not sure about the testing practices so let me know if something is off 😄

Thanks!


April 5th, 2021 Community Meeting

Please add a topic in this thread and add a link to the Github issue associated with the topic.
Please make sure you give folks enough time to review/discuss the topic offline on Github before coming into the meeting
(optional) Paste the image of an animal :smile_cat:

Quickly discuss on https://github.com/shipwright-io/build/issues/694

With the Monday holiday in Europe, we still need to decide about rescheduling or cancelling this meeting, no?
@sbose78 at least when I look at my meeting invite, you own the meeting.  Feel like making a call here?

Twitter account? https://github.com/shipwright-io/build/issues/707
Contact me to get stickers!

Cancelling this week, let's review #694 today and if you want stickers please let me know 😄

Reopening / repurposing this for the April 12 meeting.

Do we want to remove deprecated fields in v1alpha1? https://github.com/shipwright-io/build/pull/725#issuecomment-817111011

Update our branch protection rules so we can "float" k8s and golang version: https://github.com/shipwright-io/build/pull/723/

Minutes:

Parameters EP - needs more feedback related to direction (free form parameters vs. 1st class APIs). The environment variables proposal from @gabemontero will be influenced by our approach here.
Twitter account - there is a growing need for credentials to be shared among project maintainers/admins. This applies not just to our twitter account, but things like credentials used in our private git test suite.
Removing deprecated fields - we need to ensure that we can do this safely for things that upgrade Shipwright. Example - do we ensure that unknown fields are preserved in etcd? In addition, downstream consumers may depend on current APIs, they need notice before fields are removed.
k8s 1.20 bump revealed that some e2e/integration tests include kube versions in their names. If possible, this should be switched to use "latest"
Removing PipelineResources - this is not being promoted out of Tekton alpha. EP is up to discuss our path forward.
Local source EP - a similar feature is being proposed in Tekton, with a different technical approach. This is an area we can collaborate in. All agree this is a feature Shipwright wants.

/close


[new page] migration from other tools

Originally: https://github.com/influxdb/influxdb.com/issues/450
Graphite is the first one to tackle.

how to configure carbon-relay to send existing graphite stream to graphite AND InfluxDB
how to configure the graphite plugin, with basic templates for collectd and statsd metrics
example queries for cpu usage and average network bandwidth on eth0

Will ask for community help

related to #327

closing as this is something Marketing is doing.


test: Pin guava version to avoid dependency clash

Description
Quarkus bom explicitly defines a dependency on guava but that version clasehs with the one required by the selenium version used by vaadin testbench.
Type of change

[ ] Bugfix
[ ] Feature

Checklist

[X] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[X] I have added a description following the guideline.
[ ] The issue is created in the corresponding repository and I have referenced it.
[ ] I have added tests to ensure my change is effective and works as intended.
[X] New and existing tests are passing locally with my change.
[X] I have performed self-review and corrected misspellings.

Additional for Feature type of change

[ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

If you could add a note about this issue of testbench with quarkus to the documentation it would be great: https://github.com/vaadin/docs/blob/latest/articles/flow/integrations/quarkus.asciidoc

If you could add a note about this issue of testbench with quarkus to the documentation it would be great: https://github.com/vaadin/docs/blob/latest/articles/flow/integrations/quarkus.asciidoc

Will do. Should it go to "Limitations" paragraph or its better add a "Know issues"?

Perhaps add a new Known Issues paragraph there.


No auto toggle after correctly guessing answer

Expected Behavior
After you correctly guess rebus, it moves on the next one automatically.
Actual Behavior
After you correctly guess rebus, you have to hit the right key to proceed to the next.

Can I take this issue?

Hi, I would like to work on this issue.

Can I take this one?

Can I take this one?


Explore what custom bindings and/or motions would be useful for my rails projections.

[ ] <leader>fac to jump to a related spec/factories/*.rb file?
[ ] <leader>dec to jump to a related app/decorators/*.rb file?
[ ] Find out if the above can be made more generic with a prefix indicating a "gem projection" (<leader>gf and <leader>gd?)

It should be noted that both draper and factory_bot are currently defined as a projection. Because of this, executing :Ed will open a related decorator and :Ef will open a related factory. This might be enough and not warrant a leader binding.


InvalidArgumentError: 9 root error(s) found.

https://discuss.tensorflow.org/tag/keras
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
TensorFlow installed from (source or binary): Colab
TensorFlow version (use command below): 2.6
Python version: Colab
Bazel version (if compiling from source):
GPU model and memory: TPU
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
Describe the problem
I was trying to run keras/vit code example on TPU but it causes the following error.

InvalidArgumentError: 9 root error(s) found.
(0) Invalid argument: {{function_node __inference_train_function_49310}} Incompatible shapes: [256,25,64] vs. [144,64]

[[{{node gradient_tape/model_1/patch_encoder_1/add/BroadcastGradientArgs}}]]
[[TPUReplicate/_compile/_12894506912996439067/_4]]
[[tpu_compile_succeeded_assert/_14236840403296971761/_5/_197]]
(1) Invalid argument: {{function_node __inference_train_function_49310}} Incompatible shapes: [256,25,64] vs. [144,64]

[[{{node gradient_tape/model_1/patch_encoder_1/add/BroadcastGradientArgs}}]]
[[TPUReplicate/_compile/_12894506912996439067/_4]]
[[tpu_compile_succeeded_assert/_14236840403296971761/_5/_245]]
(2) Invalid argument: {{function_node __inference_train_function_49310}} Incompatible shapes: [256,25,64] vs. [144,64]

I think it's due to the use of tf.image.extract_patches function on TPU. But not sure.
Reproducible Coe.
Describe the expected behavior.
It should simply run.
Contributing.

Do you want to contribute a PR? (yes/no):
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Source code / logs.
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

cc @ksalama

Is this going to happen on training?  As I cannot reproduce your error on Colab/TPU with the vanilla notebook.
Can you share your Colab?

@bhack hi, I've shared a reproducible colab link, mentioned above. If it's not working, please try this.

Ok now I can reproduce it I don't think it is related tf.image.extract_patches as it is in the official list without special notes:
https://cloud.google.com/tpu/docs/tensorflow-ops
Have you tried to check the TPU compatiblity graph:
https://cloud.google.com/tpu/docs/cloud-tpu-tools#tpu_compatibility_graph
I don't if on colab it could be retrieved with:
https://colab.research.google.com/github/tensorflow/tpu/blob/master/tools/colab/profiling_tpus_in_colab.ipynb

OK, I just replace class Patches and PatchEncoder layer with a single class PatchEmbed layer that does a similar thing but doesn't use tf.image.extract_patches and it runs successfully.
def create_vit_classifier():
    inputs = layers.Input(shape=input_shape)
    # # Create patches.
    # patches = Patches(patch_size)(inputs)
    # # Encode patches.
    # encoded_patches = PatchEncoder(num_patches, projection_dim)(patches)

    encoded_patches = PatchEmbed(img_size=(72, 72),
                                 patch_size=(patch_size, patch_size), in_chans=3,
                                 embed_dim=projection_dim)(inputs)

Are you sure that it was about tf.image.extract_patches? As I see that you have also removed the keras embedding layer. I don't know what is the behavior inside the TPU strategy_scope:
https://github.com/keras-team/keras/blob/42bf9972492f47c3d3c249de9c20942ba217937d/keras/layers/embeddings.py#L83-L99

I'm not sure if it causes for tf.image.extract_patches. I guess came from seeing the error logs, i.e. patch_encoder_3; maybe from layer PatchEncoder.
InvalidArgumentError: 9 root error(s) found.
  (0) Invalid argument: {{function_node __inference_train_function_43005}}
    Incompatible shapes: [100,25,64] vs. [144,64]

	# ---------------------------------------  HERE ------------------------
	 [[{{node gradient_tape/model_1/patch_encoder_3/add/BroadcastGradientArgs}}]]
	 [[TPUReplicate/_compile/_58268965962327260/_4]]
	 [[tpu_compile_succeeded_assert/_14858208428749173052/_5/_197]]

Also in the following docstring, it says if my embedding matrix is too large for the GPU, I may consider placing the operation on CPU.
https://github.com/keras-team/keras/blob/42bf9972492f47c3d3c249de9c20942ba217937d/keras/layers/embeddings.py#L83-L99
But note that here I'm using TPU. Even if I set tf.config.set_soft_device_placement(True), it doesn't work either.

What I see is:
tf.keras.layers.Add

It takes as input a list of tensors, all of the same shape, and returns a single tensor (also of the same shape).

In your example if add a check in your PatchEncoder
    def call(self, patch):
        positions = tf.range(start=0, limit=self.num_patches, delta=1)
        pos_emb = self.position_embedding(positions)
        proj =  self.projection(patch)
        tf.test.TestCase().assertEqual(proj.shape,pos_emb.shape)
        encoded = pos_emb + proj
        return encoded

AssertionError: TensorShape([None, None, 64]) != TensorShape([144, 64])


Performance bottleneck when converting big 3-dimensional vector of bytes to Variant

I have a function that returns (String, Vec<Variant>).
The function looks like this:
// CHUNK_SIZE is equal to 32 -> vector has size of 65_536 bytes
let data: Vec<Vec<Vec<(u8, u8)>>> = vec![vec![vec![(0, 0); CHUNK_SIZE]; CHUNK_SIZE]; CHUNK_SIZE];

let out = (
    String::from("ChunkUpdate"),
    vec![
        // pos is just vector of 3 i64's
        Variant::new(pos),
        Variant::new(data)
    ]
);

return out;

A simple benchmark using std::time::Instant reveals that the let out call takes about 10.000 µs.
Is there any way to improve this?

I tried to optimize it by not returning any Variant but the Vector itself.
The function now looks like this:
    #[export]
    fn fetch_chunk_event(&mut self, _owner: &Node) -> Option<( Vec<i64>, Vec<Vec<Vec<(u8, u8)>>> )> {
        self.chunk_events.pop()
    }

But the performance is still as bad as before.
I think it still gets transformed to a Variant internally to communicate with Godot

Why do you nest the vector 3 times? This means that you have CHUNK_SIZE^2 allocations instead of one. It also means that each of those vectors has to be marshalled individually into a Variant, which is definitely killing performance.
Since you store "only" 64 kB, it should be well possible to use a single Vec with contiguous storage. Just remap the indices.
Since you store a tuple of two u8 values, you might also consider using ByteArray (GDScript's PoolByteArray), which stores bytes contiguously. This is even more efficient, I'm not sure about the max size of that however.

I tried to optimize it by not returning any Variant but the Vector itself.

As you suspected, this does the same behind the scenes. Exported methods marshal their parameters and return values.

After flattening the 3 dimensional vector so that the function returns Option< (Vec<i64>, Vec<(u8, u8)>) >
the time got down to about 8 milliseconds.
What really helped was replacing the (u8, u8) tuple to just a single byte.
In this case the time was in between of 1.5 and 4 milliseconds.
I also changed the way I measure the time.
Now this is being done in GDScript like this:
var start = OS.get_ticks_msec();

var chunk_event = tcp_client.fetch_chunk_event();

var finish = OS.get_ticks_msec() - start;

And additionally with the profiler in the Debugger menu.
But this is still way to much time and I cant imagine adding anything new to the game, when the fetching of chunk-data alone without meshing already takes 4ms in the gameloop.
One potential important thing to add is that the TcpClient struct has the runtime field, which holds an instance of a tokio::runtime::Runtime to handle the asynchronous TcpServer.
I will further look into if and how this impacts performance

I now got a relatively minimal working example without any runtime field:
rust code:
const CHUNK_SIZE: usize = 32;

use gdnative::prelude::*;
use std::time::Instant;

/// The TcpClient "class"
#[derive(NativeClass)]
#[inherit(Node)]
pub struct TcpClient {
}

#[methods]
impl TcpClient {
    fn new(_owner: &Node) -> Self {
        TcpClient {}
    }

    #[export]
    fn fetch_chunk_event(&mut self, _owner: &Node) -> Option< (Vec<i64>, Vec<u8>) > {
        let start = Instant::now();

        let pos: Vec<i64> = vec![
            0,
            0,
            0
        ];
        let mut data: Vec<u8> = vec![0; CHUNK_SIZE.pow(3)];
        for x in 0..CHUNK_SIZE {
            for y in 0..CHUNK_SIZE {
                for z in 0..CHUNK_SIZE {
                    // https://coderwall.com/p/fzni3g/bidirectional-translation-between-1d-and-3d-arrays
                    let i = x + y * CHUNK_SIZE + z * CHUNK_SIZE * CHUNK_SIZE;
                    data[i] = 0x05;
                }
            }
        }
        // in my case 60 µs
        godot_print!("took: {} µs", start.elapsed().as_micros());

        Some((pos, data))
    }
}

GDScript code:
func _process(_dt: float):
	var start = OS.get_ticks_msec();

	var chunk_event = tcp_client.fetch_chunk_event();

	var finish = OS.get_ticks_msec() - start;

I am running the Game by pressing F5 in the editor and I compiled the rust library in release mode

So, a few things:

Are you using godot-rust 0.10?
You mention release mode, how did you exactly compile Rust? Any Cargo profiles?
A single frame won't suffice to measure time, and OS.get_ticks_msec() is likely inaccurate. You should try measuring this over a longer time, or use a high-performance timing API.
You might need to consult a profiler to know what exactly takes time. It's of course not trivial since this happens at the boundary, but ultimately all is C++ and Rust code.
If that doesn't help, do you really have to move 64kB of data to GDScript every frame? Keeping it in Rust would likely be orders of magnitude more efficient, or transporting only relevant data (e.g. changed chunks or so).

I am using godot-rust 0.10
I simply compile the library without any profile like so: cargo build --release
Is the release mode achieved when exporting the project?
I use the Profiler in the Debugger menu at the bottom

But now I got it to work very nicely by having the chunk_updates: Vec<ByteArray> field on the node,
which gets fed like this:
let mut data: ByteArray = PoolArray::from_vec(vec![0; CHUNK_SIZE.pow(3)]);
for x in 0..CHUNK_SIZE {
    for y in 0..CHUNK_SIZE {
        for z in 0..CHUNK_SIZE {
            // https://coderwall.com/p/fzni3g/bidirectional-translation-between-1d-and-3d-arrays
            let i = x + y * CHUNK_SIZE + z * CHUNK_SIZE * CHUNK_SIZE;
            data.set(i as i32, chunk.data[x][y][z].to_category().0);
        }
    }
}
self.chunk_updates.push(data);

Then every frame in the _process function I pull one update in GDScript by popping one element from the chunk_updates like this:
var chunk_update = client.fetch_chunk_update(); # PoolByteArray
if chunk_update:
	print(chunk_update.size());

With this method it only takes roughly about 10 to 20 micro seconds (maybe even less).

Is the release mode achieved when exporting the project?

Yes, that should do it too, as long as you don't export it as Debug.

But now I got it to work very nicely by having the chunk_updates: Vec<ByteArray> field on the node,
which gets fed like this:

Great to hear you could solve it! So was the decisive change that you directly used ByteArray instead of letting it convert to Variant? Or you pass overall less data?

Directly using ByteArray and not using signals was the solution here.