Added batching for preloading repos

There are now over 688 repos being crawled to build the issues list. When this command runs, it loops through each repo and fetches the issues.
At the moment this process takes over 3 minutes running on a single process. So I've updated this to run on batch to run quicker (the server has 5 queue workers running for this queue).

I'm curious, why did you choose to batch the repos instead of creating one job per repo?

That's a good question, to be honest! I felt like batching them would be faster than running one job per repo.
I thought there might be a bit of overhead in dispatching each job and then booting it up to run. So I just guessed that by batching, we'd be able to avoid this overhead a bit more because we'd reduce the job dispatching and running by 10 times.
But, I'll be honest, this is all based on a pure guess and I didn't spend any time testing whether it's true or not haha 😄
If you think there's a simpler way of doing it, I'm more than happy to change this though to keep in nice and clean


Graphics device does not initialize in markdown session

SetVsGraphicsDeviceAsync seem to get stuck

https://github.com/Microsoft/RTVS/commit/dad3e65a0ab9ae9f936772f00a846038c3d324da

Still has issues

https://github.com/Microsoft/RTVS/commit/30b7dcc86b562c3678d27ea21130cbbb4c34a3b8


Unable to access the dataset

Hey, I was trying to implement the repository but the access to the dataset is denied

The dataset link is shown here:   https://github.com/NVlabs/acronym (the link changed recently)

The dataset link is shown here: https://github.com/NVlabs/acronym (the link changed recently)

Hey what about the checkpoints?

I just updated the checkpoints links as well.


Missing ROM implementation for clause table and address translation table

I'll implement this if needed. Currently we are not exceeding the 18kb and 36kb BRAM reservoir on zynq7020

I will implement this if necessary.

Moved to notes to keep issues to TODO list


Improved footer-dark-14 and made it responsive

Solved #869 . Improved footer-dark-14 and made it responsive. Screenshots attached.

Fix the Download App store and google store button and except that everything looks amazing @Dibyendu303

Updated @Rajdip019


Disjoint union not working for state and setState

reproduce link
I'm trying to render a component with two possible state, but can't correctly pass the flow type. Not sure this is a bug or not, really appreciate if someone could help me on this.
import React, {Component} from 'react';

type Props = {}

type StateA = {
  fetched: false
};

type StateB = {
  fetched: true,
  msg: string
};

type State = StateA | StateB;

class Demo extends Component<Props, State> {
  state = {
    fetched: false
  }

  componentDidMount() {
    this.fetch();
  }

  fetch() {
    this.setState({
     show: true,
     data: 'abcdefghi',
    })
  }
  render() {
    if (!this.state.fetched) {
      return loading...
    }
    return (this.state.msg);
  }
}

but receive error message:
 ^ Cannot call `this.setState` with object literal bound to `partialState` because: Either property `data` is missing in object literal [1] but exists in `State` [2]. Or a callable signature is missing in object literal [1] but exists in function type [3].

I think you should add the common state to the state.
Something like:
type CommonState = {
  show: boolean,
  data?: string
};

type State = (StateA | StateB) & CommonState;

then, that should work.


Transparency doesn't work in iOS FillRectangle()

I noticed that filling a rectangle in iOS doen't set the background to transparent. It works fine on WinUI and Android. Here is the code. On iOS, it always yields White background. I tried FillPaint as well, but same issue.
private void DrawBackground(ICanvas canvas, RectF dirtyRect)
{
    canvas.SaveState();

    canvas.FillColor = Colors.Transparent; ////TODO: Bug Fix in iOS - Transparency doesn't work

    canvas.FillRectangle(dirtyRect);

    canvas.RestoreState();
}

Has anyone found a workaround for this? I'm running into the same problem, even if I don't draw the rectangle. On Android the canvas is transparent by default, on iOS it's white.


Dub build

Dub version 1.0.0
DMD version 2.073.2
dub fetch daffodil
dub build daffodil
I get the following error:
\dub\packages\daffodil-0.1.2\daffodil\source\daffodil\util\range.d(56,1): Error: class daffodil.util.range.ImageRangeObject!(Range).ImageRangeObject interface function 'int opApply(scope int delegate(PixelData))' is not implemented

I've made a new release, version 0.1.3, that contains the fix for this. I fixed this a while ago but hadn't bothered releasing a new version.


economy placeholder

Please provide these fields before submitting an issue.
SpongeAPI version: <IP_ADDRESS>
Plugins installed: Total Economy 1.7.1
Description: when I try to use de %economy_balance_...% with my currency in the Total Economy, it didin´t show me the currency, and shows me as a text, Im doing something wrong? or there isn´t any compatibility with the plugins?

What version of PlaceholderAPI are you using? As well, try typing /papi parse shiosakun %economy_balance_...% and seeing what happens - if it has red text, hover over it to see if there are any suggestions or error messages.

Closing this issue as no one has replied about this.


remove redundant type validation

Could you please rebase on latest develop?

close, will merge into a new PR.


update documentation with MAM and minor enhancements

#sign-off

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Error in importing Module

I am running Python 3.5.1 on Windows in virtual environment. I installed websockets using pip.
When I try to import the websockets library I get the following error:
>>> import websockets
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "*\websocket_app\websockets\__init__.py", line 3, in <module>
    from .client import *
  File "*\websocket_app\websockets\client.py", line 10, in <module>
    from exceptions import InvalidHandshake
ImportError: No module named 'exceptions'

The exception you're getting doesn't match the current source code:
from .exceptions import InvalidHandshake

You must have accidentally modified your local installation.

Thanks for the comment! My mistake!


Fix build failure in "devel branch.

Plant presets are stored as a YAML document that can be read by
the server.

The build failed on this due to a missing dependency, so we're going to have to merge again.


Testing

Create dummy datasets which can be post publicly, and re-run tests

yes, we need to share them, making sure there is no PHI

Guidelines for removing PHI
https://wiki.cancerimagingarchive.net/display/Public/Submission+and+De-identification+Overview

Make sure you don't end up doing a ton of manual curation to achieve deidentification.. ideally you only ever have to do it once, when going from a real dataset with PHI to your first simulated dataset without PHI.. and then on, start with the simulated one with no PHI at all.
if you are starting from an already fully open dataset, that's been clearly deidentified by the respective admins (like ADNI etc), then you need not worry, although if you come across PHI, let me know and we can discuss what to do


Synchronize content changed in modal window with relations graph (locks, labels)

Fixed as of https://github.com/odalic/odalic-ui/commit/5119dc721b981614976c40eb018e2279d43da372 , unless I am severely mistaken.


merge MONDO_0008331 'pseudopapilledema (disease)'

MONDO_0008331 'pseudopapilledema (disease)' has a comment: May be merged in future as this represents a phenotypic feature

@pnrobinson do you think this should be obsoleted from Mondo?

This is a phenotypic feature and belongs in the HPO, see eg.https://www.ncbi.nlm.nih.gov/books/NBK538291/

perfect, thanks @pnrobinson!


luci-app-adblock: Add translation

Add po templates
Add Simplified Chinese translation

Signed-off-by: Hsing-Wang Liao<EMAIL_ADDRESS>

You need to amend the commit message itself to have the signed-off-by line.
It should be there so that it gets saved to the git history. PR conversation messages are not stored in git

Ok, I have added the signed-off-by.

Thanks.


Reporting a vulnerability

Hello!
I hope you are doing well!
We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly.  GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.
Can you enable it, so that we can report it?
Thanks in advance!
PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

Hi, feel free to report the issue here, publicly. You've opened similar issues on 230 other repos, so I'm inclined to believe this is spam, but if you do have an issue to report please do so.

This is spam, this user is posting this exact same comment on hundreds of repositories (they're up to 780 now).


Apps installed from the App Store crash on launch in jailbroken state

Describe the bug
I’m a jailbroken state, whenever trying to open an app that was installed through the app store the app immediately crashes. This is fixed by rebooting.
Expected behavior
The app is supposed to open.
Info (please complete the following information):

iDevice's version: iOS 15.3.1
Computer OS and version: iPhone X
The command you ran: ’sudo bash ./palera1n.sh --tweaks 15.3.1’

Additional context
No tweaks installed, it was a fresh install of Palera1n.

Please learn how to read, it says this is an issue in the readme. No ETA on fix.


Add image file size to the response

Add image file size to the response

Good stuff! I changed "size" to "fileSize" for clarity.


TabNine consumes excessive CPU for extended periods

I'm using TabNine 1.0.9 in SublimeText 3.1.1 on OS X 10.13.6.
Much of the time, the TabNine process shows that it's using 100-120% CPU. The rest of the time it bounces between 0% and 40% CPU. I'm not sure what is causing this; I thought it might be related to backup activity causing a lot of filesystem events, but now I'm not sure.
Assuming this is not expected behavior, I'm happy to help troubleshoot this.
I should add that I really like TabNine's functionality, so I've been putting up with the high CPU except when running on battery.

Does the high CPU usage stop once you stop typing? If so, it's likely TabNine updating the index in the background to reflect the changing state of the current file. This process is not very efficient at the moment, and is a high priority for improvement within the next month or so.

Thanks for the response. No, the high CPU usage continues even when Sublime is in the background.
I tried to see if there was a correlation between typing in Sublime as well as saving changes to disk when TabNine wasn't consuming much CPU, but there doesn't seem to be one: CPU usage it briefly jumps a bit but it doesn't begin one of these extended periods (I haven't measured it, but 10s of minutes) of maxing out a core.

Thanks. I'll keep an eye out for the update.

The update is released! (Full changelog)
Unfortunately I did not include the improved error reporting in this release.

The CPU usage seems a little better these days. The TabNine process isn't usually pegging a core at 100%. It does tend to hang between 20% and 70% for extended periods however.

Getting the same issue with the deoplete-tabnine plugin in vim.

The log doesn't appear to be getting thrashed though.
[2019-02-25][13:43:32][server][DEBUG] [autocomplete] 7 ms
[2019-02-25][13:43:32][server][DEBUG] [autocomplete] 8 ms
[2019-02-25][13:43:32][server][DEBUG] [autocomplete] 3 ms
[2019-02-25][13:43:32][server][DEBUG] [autocomplete] 7 ms
[2019-02-25][13:43:33][server][DEBUG] [autocomplete] 8 ms
[2019-02-25][13:43:33][server][DEBUG] [autocomplete] 10 ms
[2019-02-25][13:43:33][server][DEBUG] [autocomplete] 6 ms
[2019-02-25][13:43:34][server][DEBUG] [autocomplete] 12 ms
[2019-02-25][13:43:34][server][DEBUG] [autocomplete] 7 ms
[2019-02-25][13:43:34][server][DEBUG] [autocomplete] 11 ms
[2019-02-25][13:43:36][server][DEBUG] [autocomplete] 4 ms
[2019-02-25][13:43:36][server][DEBUG] [autocomplete] 5 ms
[2019-02-25][13:43:38][server][DEBUG] [autocomplete] 2 ms
[2019-02-25][13:43:42][server][DEBUG] [autocomplete] 14 ms
[2019-02-25][13:43:42][server][DEBUG] [autocomplete] 15 ms
[2019-02-25][13:43:43][server][DEBUG] [autocomplete] 10 ms
[2019-02-25][13:43:43][server][DEBUG] [autocomplete] 7 ms
[2019-02-25][13:43:43][server][DEBUG] [autocomplete] 2 ms
[2019-02-25][13:43:45][server][DEBUG] [autocomplete] 17 ms
[2019-02-25][13:43:45][server][DEBUG] [autocomplete] 16 ms
[2019-02-25][13:43:45][server][DEBUG] [autocomplete] 11 ms
[2019-02-25][13:43:46][server][DEBUG] [autocomplete] 8 ms
[2019-02-25][13:43:50][server][DEBUG] [autocomplete] 9 ms
[2019-02-25][13:43:53][server][DEBUG] [autocomplete] 18 ms
[2019-02-25][13:43:54][server][DEBUG] [autocomplete] 26 ms
[2019-02-25][13:43:54][server][DEBUG] [autocomplete] 10 ms
[2019-02-25][13:43:55][server][DEBUG] [autocomplete] 5 ms
[2019-02-25][13:43:56][server][DEBUG] [autocomplete] 16 ms
[2019-02-25][13:43:56][server][DEBUG] [autocomplete] 11 ms
[2019-02-25][13:43:57][server][DEBUG] [autocomplete] 3 ms
[2019-02-25][13:43:57][server][DEBUG] [autocomplete] 16 ms

35% of memory is roughly 5GB on my system

I'm seeing the same issue on macOS 10.14.2 with Sublime Text 3, even when I'm not using Sublime or modifying the repo with the command line.
99% CPU usage, 2.2 GB memory usage.

@seren Is TabNine abandoned already? This issue is a dealbreaker and I cannot use TabNine even though I paid for it.

@zxqfl  Is TabNine abandoned already? This issue is a dealbreaker and I cannot use TabNine even though I paid for it.

Yeah, I recently had to remove it so that my battery would last more than an hour. It's too bad, because this is the only thing keeping me from buying it.

TabNine is not abandoned. Is the repository causing this issue open source? This may allow me to replicate and fix the issue.

I'm sorry for the inconvenience. You can contact me at<EMAIL_ADDRESS>to receive a full refund.

@zxqfl I put a comment with some instructions on how to replicate this with OpenWrt over at #43, along with some analysis of what looks like a bug (and possibly even the cause).

I also have high cpu usage over time without doing anything:

As a follow-up, after removing TabNine I discovered that Sublime was burning CPU for a different reason: a .git folder in my home directory.
Thus I may have blamed TabNine unfairly due to this issue cropping up around the time I installed it. I've re-installed it and will report back if the high CPU usage returns.

Thus I may have blamed TabNine unfairly due to it being installed around then same time that this issue cropped up. I've re-installed it and will report back if the high CPU usage returns.

But as you can see on my post above it also happens on a completely unrelated editor and without that one going nuts. (VSCode) So I wouldn't close the issue.

No, I'll leave it open for the other issues. I'm not sure mine is resolved either.

@zxqfl Any progress?

@zxqfl Is there any chance you can share the source code with me so I can diagnose this? It's getting really annoying.

I disabled it for now because on some projects I've had a constant 100% CPU usage on one core I couldn't stop..

I'm working on open sourcing the code that TabNine uses to index projects. Once this is done, you'll be able to investigate the issue yourself if you wish.
In the meantime, I can look into it if you can provide steps that I can use to reproduce the issue.

Other people who find this issue: Check or think whether it might be an LSP server.
Personally sometimes the Rust LSP server triggered by TabNine consumes all my cores to build the project in the background. One of my processor monitoring apps attributes this CPU to Sublime rather than the LSP server process because it's under Sublime in the tree. I'm not sure what Activity Monitor shows by default. This isn't a problem with TabNine though.
Anyhow if you're having CPU usage issues consider whether this might be the case and maybe you want to ditch your LSP server and just use raw TabNine with TabNine::no_sem

I'm a new user giving TabNine a try and experiencing this same issue.

Same with me: macOS, Emacs, and TabNine 2.0.4

this is happening for me too. I can provide more information if it helps

Is there any way to provide logs that could help debug this?
~/.vim/plugged/tabnine-vim/binaries/2.1.5/x86_64-unknown-linux-gnu/TabNine is the process that's currently using 100% CPU for me. There doesn't appear to be anything in either of the stdout or stderr files which its arguments point to.

When using vscode, the CPU usage does not reach 70% when inputting, causing the computer to be stuck.

I'm seeing the same kind of issue. CPUs are being maxed out for minutes at a time.
$ ./TabNine --version
TabNine 2.1.5 (x86_64-unknown-linux-musl)
Jacob Jackson<EMAIL_ADDRESS>
$ nvim --version
NVIM v0.3.8
Build type: RelWithDebInfo
LuaJIT 2.0.5

# using github.com/tbodt/deoplete-tabnine, git hash 5ba086d08f1da93ec9bbe9276dbc62fcb301aeed

Happening to me as well. Also, the completion are slow to arrive and halt the PC at time. This has started happening recently. I am using Emacs with Spacemacs configuration.

Hey @zxqfl - what can we do to get this issue looked into? TabNine is amazing, but I'm finding I have to terminate it to save battery/energy.
Please help!

been using via coc.nvim, disabling after experiencing the same, and then seeing this on answered thread.

I'm having the same issue on an ec2 t2.medium instance with the tab nine vim plugin. This seems to completely lock up my instance every few hours, to the point where I need to reboot it to continue.

I've been having the same issue. I'm on macOS Mojave using VSCode. As a temporary fix, I've disabled TabNine on a per-workspace basic, because I use VSCode to type my notes and do programming at school and the battery life was getting really bad (~ 2 and a half hours).

You can disable TabNine Local feature in TabNine::config.

Possibly related, I can't even open the config on my work machine. Whenever I type TabNine::config it opens the browser yes, but the page load times out and TabNine pegs all CPU cores to 90% until I kill it.

Just to chime in, I'm using TabNine Local with no LSP in SublimeText 3 on MacOS Mojave.
I do see TabNine peg the CPU when I'm actively typing, but as soon as I stop it drops back down to 0% CPU.
I see there are options in config to disable DTN Local when on battery power so perhaps that can help those out who are using their text editor for notes when not plugged in. There's also an option for "Power saving mode" but I've not yet tried that and there doesn't seem to be a description of how it does that.
Just wanted to offer up some potential options for those experiencing this issue, but also to chime in that it doesn't seem to be occurring outside of when it's actively in use for me so the root cause might be the code/editor DTN is interacting with.

I'm getting this when I'm just writing Markdown. It pegs the CPU while I'm typing, and then goes back to idle. I'm using the tabnine-vim plugin. Since I'm writing Markdown, that should eliminate any kind of LSP issues, correct?

By default, tabnine seems to use the half of the available cores: for example, CPU usage of TabNine --benchmark-local is nearly 400% on an 8-core machine.
If "Power saving mode" is enabled, the load is reduced to about 130%.
However, sometimes CPU usage of TabNine exceeds 300% while editing a python file in power saving mode; the editor is Neovim and LSP is disabled.
Is it possible to set the number of threads?

$ TabNine -v
TabNine 2.1.20 (x86_64-unknown-linux-musl)

i have the same issue in mac book pro + tabnine+ pycharm

Hi All, we have a fix in beta (version 2.3.4) for excessive CPU and memory consumption by TabNine.
We'd appreciate it if you try it out and let us know if it solves the issue for you.
To try the fix, you have to enable the beta version. Just open TabNine's config by typing TabNine::config in your editor, and then check both Update TabNine automatically and Receive beta releases of TabNine Then, restart your editor, and press TabNine::confiig to verify you have TabNine 2.3.4. or newer.  Please let us know if this version solves the problem for you. We plan to make it available to all users in a couple of weeks.

I have no such settings in the VS-Code extension

Here is top command output with version 2.3.4  and Deep TabNine Local enabled. About 1.9G memory get used.
  PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
 7755 vision    20   0 2190848   1.9g  10280 S   0.0  12.3   1:34.71 TabNine

It is normal memory usage.
Tabnine local eats lot of memory

@drorweiss I've been using the 2.3.4 beta on Windows 10 & Visual Studio code for a week now and am happy to report that CPU usage is normal. I'm no longer encountering the problems I've reported in #148 .

Thanks, @cstuder
We're continuing to gradually release the correction to all users.
I'll add the comment about the fix in the original issue.

Hi All, we have a fix in beta (version 2.3.4) for excessive CPU and memory consumption by TabNine.

Were compromises take taken to allow this? And has this been included in version 2.3.5?

Hi @NilsIrl

Were compromises take taken to allow this?

Not really. The only "compromise" is that occasionally, TabNine would stop itself for a very brief period to prevent consuming excessive resources.

And has this been included in version 2.3.5

Yes.

CPU usage is still very high even though I'm only using TabNine Cloud)

CPU usage can get high for short periods of time. Do you see high CPU usage for long periods of time?

CPU usage can get high for short periods of time. Do you see high CPU usage for long periods of time?

Yes, generally after I'm typing it is still high.
Right now though I can't get it to go over 20%. What I'm going to assume is that yesterday for whatever reason it was still using TabNine local even though I had told it not to. And that with a system restart the setting somehow got applied.
So for me, assuming the current behavior doesn't change, I would consider it fixed.

on macbook pro 16 inch intel, macos version 12.6.1..it seems the same issue
use a lot of CPU and memory...
I use vscode...
does it fixed?

I just come to say this. It happens again right now with the latest version.
I'm using Tabnine Pro with  IntelliJ, MacOS Big Sur (11.6), 16GB RAM. It's eating up all my CPU, making the CPU to be throttled to 40-50% of its capacity.
Is there any solution for this?

Hi
Every 5 seconds the CPU consumption of TabNine jumps up to 75% even though not working on VisualStudio and keeping the Windows just in the background.
Tabnine 3.79.0 Liunx Mint 21.3


NOISSUE - Fix VerneMQ compilation

Signed-off-by: Drasko DRASKOVIC<EMAIL_ADDRESS>

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   83.67%   83.67%
=======================================
  Files          75       75
  Lines        5083     5083
=======================================
  Hits         4253     4253
  Misses        582      582
  Partials      248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fd492...0aed957. Read the comment docs.


GitHub Actions

Hey @amandamartin-dev! 😄 What do you think of adding a GitHub action where we congratulate people for contributing to our project? It would be a great way to foster a warm yet inclusive environment, especially for first timers.

Sure! That's a great addition

Coming over from Twitch on @CBID2's suggestion: I personally don't particularly enjoy working on new things in CI/CD land, but have a template repo here that might be useful: https://github.com/JoshuaKGoldberg/template-typescript-node-package. Cheers! ❤🔥


Get list of ensemble members and steps from GEFS .idx filenames

GEFS filenames include init datetimes, ensemble members, and steps. Although this will be a dataset-specific feature. Other datasets might not include all this info in the filenames.
We can probably just read a handful of .idx filenames from each directory. Not entirely sure how to choose that handful though!
Parse the ensemble member as a String and the step as a TimeDelta.

This old code could be re-used:
impl GefsIdxPath<'_> {
    fn extract_forecast_step(&self) -> anyhow::Result<TimeDelta> {
        let n_parts = self.parts.len();
        let filename = &self.parts[n_parts - 1];
        let filename_len = filename.as_ref().len();
        // The forecast step is always in the last 8 to 4 chars e.g. "f330.idx".
        let start_i = filename_len - 7;
        let end_i = filename_len - 4;
        let step_str = &filename.as_ref()[start_i..end_i];
        let timedelta = if step_str == "anl" {
            TimeDelta::zero()
        } else {
            let forecast_hours: i64 = step_str.parse()?;
            TimeDelta::hours(forecast_hours)
        };
        Ok(timedelta)
    }
}

I'm considering dumping this approach in favour of #28!

Yes, for now at least, I'm just going to manually extract the ens members and steps from the GEFS docs. See https://github.com/JackKelly/explore_nwps


[GUI] The GUI breaks if the device is from a template with associated FW

The GUI breaks when the device is from a template with associated FW.
Steps to reproduce the problem:

template and device created by GUI

view device details

return to device list

template and device created by the API; FW added by GUI

view device details

return to device list

change page

Affected Version: 62.3-20190603

Test OK.
Tested in version: 63.1-20190705


fix(removing lot of console errors & ESLINT warnings and errors)

removing most of Accounts/Website console errors and ESLINT warnings and errors

try npm run test-all
from 248 problems/warnings

to this

@jomarmontuya can we check marketing pages are ok?

Everything seems to be working fine on the marketing side thank you!


Insufficient memory for windows gradle check on core

Describe the bug
For opensearch core, gradle check on windows CI results in OOM errors due to the insufficient memory allocated for the windows agent on Jenkins.
Here's the links to the Jenkins runs with memory failures:
https://build.ci.opensearch.org/job/gradle-check/7512
https://build.ci.opensearch.org/job/gradle-check/7511
https://build.ci.opensearch.org/job/gradle-check/7504
To reproduce
Run gradle check on windows for 1.3 or 1.x branches.
Expected behavior
For gradle check to pass, this is a request to increase the memory allocated for the CI runner in order to get a full gradle check without any failures due to insufficient memory (since windows is limited at 32gb currently).
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

Will try to add more memory to WINRM consumption.
Set to 30270 from 10240 MB per connection.
Thanks.


image stretch

Hi,
Is there a way to set the image to "Stretched" mode? Currently, it seems the image is "zoomed" or "spanned" across the frame available.
For example, in the ngx-gallery tag, it takes options like width, height and fullWidth etc, but is there an option to set the image mode to Stretched so that it resizes to fit the frame space available?
Thanks

Hi @cyfrost  did you get the answer to this?


document release process

We need to do another release and there is no release documentation.

We do have GitHub actions setup in this repository which release helm binaries for different architectures. However, for the last two releases we are only releasing the source code. We need to clean up and update the GitHub action to release hybrid and helm binaries.


Add description to start day.

Description
Added a label to the start day in the scenario component.
Related Issues
Resolves #202
Checklist
I, the author of this PR checked the following requirements for good software quality:

[x] The code is properly formatted (I ran the formatter)
[x] The code is written with our software quality standards (I ran the linter)
[x] The code is written using our code style
[x] Extensive in source documentation has been added
[ ] Unit and/or integration tests have been added
[x] All texts have been internationalized with at least the following languages:

[x] English
[x] German

[x] I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
[ ] I attached performance measurements to prevent performance degradation
[x] I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

[ ] I ran the software once and tried all new and related functionality to this PR
[ ] I looked at all new and changed lines of code and commented on possible problems
[ ] I read the added documentation and checked if it is understandable and clear
[ ] I checked the added tests for completeness
[ ] I checked the internationalized strings for spelling errors
[ ] I checked the performance metrics for problems or unexplained degradation
[ ] I checked that the changes are noted in the changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 17.478%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
264

Relevant Lines:
1180

💛  - Coveralls


REST API for entries

[x] CRUD operations as rest.
[x] Timeline list in another controller.
[ ] Let client generate entry id, will be useful later.

Let client generate entry id, will be useful later.

It's ready, but client doesn't use it right now.


Add migration to remove arcgis column

CR @gfiorav More data-loss inducing migrations = more fun

📦 it when 🍏


MongoDB Support

As a developer I want to be able to use MongoDB instead of a SQL database.

Correct me if I'm wrong but this could be easily achieved with converting the Raw SQL statements to Eloquent methods?


Resident Evil 2  looping animation.

Version
3.1.3 (cbe02d7)
Seed
R720-UBN1-XMHH40MZ9Y1R0NJVPEVPEZ1ZZZZZZZZZZZZZZZZZZZZZ
Scenario
RE 2 (Leon A)
Player Character
Alfred
What happened?
When being grabbed by a zombie arm, Leon (Ada) shot and the character was in a loop, I couldn't get out unless I closed the game.
This happened in the Leon A -  Room 502 underg. passage

Duplicate of #254


Online primary key changes

Fixes #5955.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9408d487cfb0017ec3b5707585af0b18e3318129/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fee584b26fbd31c97eb6d60e3e4bc32a44707ea5/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/450418905e421c0cb500185a14d9a7828e4f566e/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/251d52c17068d06e4ab5a5f4f1aed31808b3d561/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/experimental-features.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

I'd be more explicit about the fact that the old primary key becomes a secondary index after the primary key change, rather than just mentioning that it is there after code sample of the primary key change executing.
Not sure where to put this, but I think we should mention somewhere that this is an expensive operation that performs a number of rewrites of indexes.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/74963c79df5e2bc94d392a97dc7e48476c9efa1a/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/experimental-features.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7795f8c429b1d1fdb9e3417c2b0addf0488398b1/
Edited pages:

v20.1/alter-primary-key.md
v20.1/alter-table.md
v20.1/constraints.md
v20.1/create-table-as.md
v20.1/experimental-features.md
v20.1/indexes.md
v20.1/partitioning.md
v20.1/primary-key.md
v20.1/sql-statements.md

LGTM. Yeah it doesn't seem like we need to go into that much detail about how and why indexes get rewritten.

@Amruta-Ranade Ping on review :)

Sorry for the late review!

No problem!


Tailwind and DaisyUI no longer works for Storybook

There were a lot of changes for dependencies under packages/react. The refactor was completed but now tailwind and daisyUI no longer works. You can see that no styles are working here now: http://storybook.akello.io/

/attempt #169

/attempt #169


Can you put the example data in the repository?

I just cloned the repo and everything compiled with no problems. But when I try to run it, it says it can't find data/data_to_test_priors.txt. It'd be good to have that file in the repository.

Fixed now, sorry about this.
I'm now using the simulated data in the BL2009 example. The options in OPTIONS are not ideal (in fact I'll open another issue to ask for your help on that)


EmojiSheet Pack Issue

i am using latest one "sheet_google_32" but i am trying to pack asset with 1 padding but latest one is not pack correctly. old once is pack correctly but some emoji not supported.
so please check latest once and give solution as soon as possible.
also i have attached old and latest screenshot please check
thank you

can you please update all sprite sheet into POT?
for example : sheet_google_32 size is 20742074 using 16.4MB but you set and proper convert into 20482048 then size under 5MB.
so if possible to update all sprite sheet so it's work correctly and use less size.

For your first comment: The sheet is packed correctly. The image is 2074 pixels wide per side, with 61x61 images. Each images has 34 pixels of space, which is 32 pixels of image with a 1 pixel margin. This sizing is correct. Have you updated your code to have 61x61 images in the sheet?

For your second comment: I don't know what POT is, and have been unable to find anything on Google. There are palette indexed versions of the sheets which reduce size, at the cost of lower color-correctness,

i mean set the sheet size into Power of Two(like 128128, 256256, 512512, 10241024, 20482048, 40964096)
For Example:sheet_google_32 size is 20742074 using 16.4MB but you set and proper convert into 20482048 then size under 5MB.
so if possible to update all sprite sheet so it's work correctly and use less size.

i need this too! all unity user want this.

You are free to resize sheets to any size you want. However, the current set of images will not fit in 2048x2048 pixels at 32px each - there are just too many and they don't fit.

https://github.com/sssooonnnggg/emoji_pot
Hi, I created a tool to resolve this issue, it converts the 32x32 sheet to 30x30 sheet within a POT texture. (2048x2048)


Jabalpur,madhya pradesh cororna update

Jabalpur district of madhya pradesh has now total 9 corona positive cases
On wednesday, 8 april a new corona case has been test positive in adarshnagar in jabalpur but it has not been updated yet in this site.
The new patient is 60-year-old man his contact history is being traced, said sources. He is from Adarsh Nagar locality from the city and had returned to Jabalpur from Hyderabad on March 20.
Plz update...

@jamy007 please use this form to report cases
https://docs.google.com/forms/d/1HVXi3-0ckxGTS81yAN1RmgrVnvg9cg2pyPTuPgBeVEo/

I reported the cased yesterday that jabalpur has total 11 cases sinse
previous sunday but still it has not beet updated yet, it is still showing
10 cases, i also has mentioned the the link-
https://www.google.com/amp/s/www.naidunia.com/lite/madhya-pradesh/jabalpur-jabalpur-coronavirus-update-one-more-coronavirus-positive-found-in-jabalpur-city-5482432
On Fri, Apr 10, 2020, 5:34 PM Krishna Pravin<EMAIL_ADDRESS>wrote:

Closed #902
https://github.com/covid19india/covid19india-react/issues/902.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/covid19india/covid19india-react/issues/902#event-3221657096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APEDSGVFB6AYFYG64B6RPMLRL4DOLANCNFSM4MFMZZZA
.

@jamy007 we usually update the data only if it is from official sources like government social media handles, press bulletins, official government websites, etc


chore: change log

Types of PR

[x] New Features

Description

release 1.0.5

How to review this PR

update cli pipx install . -f
verify that cli vesion is 1.0.5 driving_log_replayer --version
build workspace colcon build --symlink-install --catkin-skip-building-tests --cmake-args -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release --packages-up-to driving_log_replayer describe multiple datasets in a scenario
run simulation driving_log_replayer simulation run -p perception
verify that the command has the following statement python3 ${your_autoware_path}/install/driving_log_replayer/lib/driving_log_replayer/perception_database_result.py -s ${scenario_path} -r ${output_path}
confirm that database_result.json is created in the root of output_dir after all launches are finished.

Others

thank you for reviewing

closes #16


Add Content-Type Handling on POSTs

If a Content-Type: application/json header is not included on POST, it blows up with an internal (not useful) error reported back to the end user.

Closing this issue as we've decided to not support POST (#12).


[iOS] Support for layout container (Flow + AreaGrid)

Support for Flow Layout Container

This PR adds support for the Layout container for elements of type AdaptiveCard, Container, Column and Table Cell.
This PR introduces a feature flag resolver interface that allows the host to implement and register it, enabling control of features through ECS settings.
For flow layout container, we are writing equal width distribution logic for elements like Container, ColumnSet and TableCell.

A new layouts property is introduced on container elements. The value is an array of Layout objects. The layout objects look like this:

The layout to apply is determined the following way:

Look for the first layout in the list whose targetWidth property matches the current host width. If one is found, apply it

Otherwise, look for a layout that doesn’t have a targetWidth defined. If one is found, apply it

Otherwise, apply a default Layout.Stack layout and ignore other layouts in the list

Spec for Layout.Flow

Spec for AreaGrid layout:

Sample Card:
Flow Layout Container

Area Grid Container

Looks good!. Is there any test you consider could be added?. If some recursive layout card could be added (if not already there) to ensure working on that scenario too would be great.

Looks good!. Is there any test you consider could be added?. If some recursive layout card could be added (if not already there) to ensure working on that scenario too would be great.

Done

Thank you @wyAbhishek , this is a huge undertaking and changeset. Some feedback. Feel free to prioritize on what would be too much of a lift that doesn't make sense to have now to get this feature set out.
Swift PM Support:
Your new header files added which are exposed to the swift package manager imports need to be symlinked to the iOS Include directory like done here:
https://github.com/microsoft/Teams-AdaptiveCards-Mobile/pull/155/files
in order to do this, go to the include directory in your terminal and run commands on the relevant header files:
IE:
ln -s ../ACRIFeatureFlagResolver.h ./ACRIFeatureFlagResolver.h
c_str() nullability
The conversion from c_str() to NSString using NSString stringWithCString:encoding: assumes the conversion will always succeed.
Please add error handling to manage cases where the conversion might fail (e.g., if the string is nullptr or if there's a failure in conversion).
No Default Case Handling in Switch Statements
The switch statements in methods like distribute: and shouldUseNewLayoutForView: do not have a default case. Add a default case to handle unexpected CardElementType values please.
ACRView - Use of Magic Numbers for Width and Height
please turn magic numbers like -1 into a constant for us to track.
ACRFlowLayout.h - lack of docs
add docs on this and other new additions if possible.

Thank you @wyAbhishek , this is a huge undertaking and changeset. Some feedback. Feel free to prioritize on what would be too much of a lift that doesn't make sense to have now to get this feature set out.
Swift PM Support:
Your new header files added which are exposed to the swift package manager imports need to be symlinked to the iOS Include directory like done here:
https://github.com/microsoft/Teams-AdaptiveCards-Mobile/pull/155/files
in order to do this, go to the include directory in your terminal and run commands on the relevant header files:
IE:
ln -s ../ACRIFeatureFlagResolver.h ./ACRIFeatureFlagResolver.h
c_str() nullability
The conversion from c_str() to NSString using NSString stringWithCString:encoding: assumes the conversion will always succeed.
Please add error handling to manage cases where the conversion might fail (e.g., if the string is nullptr or if there's a failure in conversion).
No Default Case Handling in Switch Statements
The switch statements in methods like distribute: and shouldUseNewLayoutForView: do not have a default case. Add a default case to handle unexpected CardElementType values please.
ACRView - Use of Magic Numbers for Width and Height
please turn magic numbers like -1 into a constant for us to track.
ACRFlowLayout.h - lack of docs
add docs on this and other new additions if possible.

Thanks @hggz for review.
I have addressed some items and left some for future PR. Following is the list:

Created symlink for ACRIFeatureFlagResolver
Added a wrapper method for optiona std::string to NSString converstion. This has all safety built in.
Default handling is already there. Validated that it works.
Not removing magic number, because we don't have a constant file. There are many magic number scattered through out the code, this will need separate PR
I will add documentation for new layouts. Some work is pending for phase1, I will take it up then.


[PLT-8177] Fix multiple files upload error

Summary
Fix multiple files upload error
Ticket Link
Jira ticket: PLT-8177
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

Yes, not migrated yet. Original problem was that the object was said to be frozen and immutable. Draft is coming from BrowserStore.
I'm not totally sure why it's failing that way.
It's just a quick fix and might change once migrated.

@saturninoabril I don't quite get it, what does FilePreview with those objects, does it modify them somehow? this will make the FilePreview component to re-render every time as the props will always be different and that might affect performance, I think you need to look were the object is being modified and fix that

The error is rooted from here - https://github.com/mattermost/mattermost-webapp/blob/master/stores/browser_store.jsx#L30 - but couldn't figure out why.
I'll check once again.

@saturninoabril I think it is from this line https://github.com/mattermost/mattermost-webapp/blob/05f2eb0cc4a2c91aa4a99de8d117c2e48eca3a9c/components/file_preview.jsx#L44
I changed it in this PR https://github.com/mattermost/mattermost-webapp/pull/210. I don't see any issues with that on my branch now though.

@sudheerDev Thanks for the input!
@enahum I'm actually not sure. FilePreview does not modify the object but it's receiving a frozen object. I suspect that React prevents re-render whenever that frozen object changed from parent component (in this case either from CreateComment or CreatePost). So, the solution could be:

clone the object before passing into FilePreview (my initial commit),
render FilePreview using cloned object (@sudheerDev  solution),
clone the object into state of FilePreview (my second commit).

Any thoughts?

Well I don’t have a strong opinion on how to fix it but my onmy concern is that the object is getting modified somewhere and I would not be surprised if that causes any other issues, so go ahead make your fix and then if it causes other problems we can look deeper into it

Thanks! I'll keep an eye on future issue.
@sudheerDev Sorry but I'll go and merge this. Please rebase your PR.

@saturninoabril Just a note: if we can avoid state then we can replace that with stateless components later.


Draw schedule name

What is the expected enhancement?
It would be nice if Schedule.draw() would display the Schedule's name as a title.

This is just fyi. The function to create axis object is placed here.
https://github.com/Qiskit/qiskit-terra/blob/ff6b94120520b5c27d6316088eafc90338a97914/qiskit/visualization/pulse/matplotlib.py#L572-L576

This is just fyi. The function to create axis object is placed here.
https://github.com/Qiskit/qiskit-terra/blob/ff6b94120520b5c27d6316088eafc90338a97914/qiskit/visualization/pulse/matplotlib.py#L572-L576

Cheers @nkanazawa1989, was not used to Pulse yet, so didn't know where to start. Thank you very much

Fixed by https://github.com/Qiskit/qiskit-terra/pull/4122


Submitting resource usage for runtimes

Looking at the usage submission docs (https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/doc/api.md) it seems that when submitting the usage for runtimes, the resource_instance_id would be the right  field to submit the buildpack_guid to specify which actual runtime is being used by the consumer (application). Is that the correct interpretation of the api ?
Another concern is what happens when resource_instance_id is missing in initial submissions. In some cases it may not be available initially but only provided later - for example CF may not provide it in start event but in stop. In that case, can the collector propagate runtime id to other submissions for the same consumer_id  ?

it seems that when submitting the usage for runtimes, the resource_instance_id would be the right field to submit the buildpack_guid

For services, you can use:
resource_id: <service id>
resource_instance_id: <service instance id>
consumer_id: <app id> // if known

For app usage, use:
resource_id: <buildpack id>
resource_instance_id: <app id>
consumer_id: <app id>

... What happens when resource_instance_id is missing in initial submissions... can the collector propagate runtime id to other submissions for the same consumer_id

I'm not following that part. With 'resource_instance_id is missing' are you saying that the buildpack id is missing (I'm inferring that from the fact that you were asking about putting the buildpack id in the resource_instance_id field in your previous question)? Did you mean buildpack id as well when you said runtime id later? Not sure either what you meant by 'propagate runtime id to other submissions for the same consumer_id'. Can you help me understand that part with an example maybe?

Also look at the Abacus CF app usage bridge
https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/lib/cf/bridge/src/index.js#L237
for an example of what to do.
I believe the bridge does the right thing with these ids. It doesn't seem to set the consumer id but I don't think that's absolutely necessary. Setting the consumer id is only needed if you want to see an aggregate of app usage per consumer (i.e. per app) in the summary report.

In the docs, tests and the bridge the resource_id determines how the usage submission is handled by matching definition in lib/config/resource/lib/resources.
This led me to assume that resource_id determines a set of resources - application runtimes,
which are metered in the same way.
If resource_id is a buildpack guid, it may cause proliferation of resource definitions for similar resources, for example different versions of nodejs runtime. These versions may be added at any time so a mechanism to register them may be needed.
There is also a problem with custom buildpacks which can be provided during application deployment (https://docs.cloudfoundry.org/buildpacks/custom.html). In that case, the buildpack guid is unknown and the application usage could not be measured.
The specific scenario of missing buildpack guid is following the bridge implementation. The submission is based on the first STARTED app usage event. In some cases - average is about 10% on Bluemix,
the buildpack_guid and buildpack_name fields of the first STARTED event are null. If the buildpack_guid is needed to correctly submit, it must be obtained by some other means.

@piotrprzybylski We actually report BUILDPACK_SET after the STARTED event (https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/lib/cf/bridge/src/index.js#L269).
Any idea if BUILDPACK_SET events are reliable? If so this will help to add the needed buildpack field since the set event is fired almost immediately after start events.

In the docs, tests and the bridge the resource_id determines how the usage submission is handled by matching definition in lib/config/resource/lib/resources. This led me to assume that resource_id determines a set of resources - application runtimes, which are metered in the same way. If resource_id is a buildpack guid, it may cause proliferation of resource definitions for similar resources, for example different versions of nodejs runtime. These versions may be added at any time so a mechanism to register them may be needed.

@piotrprzybylski: AIUI this is already covered in issue #38. Please review #38 and comment there if needed.

There is also a problem with custom buildpacks which can be provided during application deployment (https://docs.cloudfoundry.org/buildpacks/custom.html). In that case, the buildpack guid is unknown and the application usage could not be measured.

As I mentioned in issue #37, Abacus does not make any assumption on the contents of the resource_id. You just need to provide a value for that resource_id to get usage aggregated for it (any value that makes sense to you, including 'unknown' for example if that allows you to categorize unknown buildpacks).

The specific scenario of missing buildpack guid is following the bridge implementation. The submission is based on the first STARTED app usage event. In some cases - average is about 10% on Bluemix, the buildpack_guid and buildpack_name fields of the first STARTED event are null. If the buildpack_guid is needed to correctly submit, it must be obtained by some other means.

Not sure if missing the buildpack info from the app usage STARTED event is a bug in the CF app usage event API or the expected behavior of that API. You may want to review the app usage BUILDPACK SET event as suggested by @hsiliev or raise an issue with the CF app usage event API to resolve this. If you're not getting the buildpack info from any app usage event, then you're correct that you'll need to obtain the buildpack info by some other means, as again Abacus will require a resource_id to aggregate usage for it.

@jsdelfino - Thank you, #37 and #38 suggested solution to the problem I tried to solve so I will continue discussion there.

@hsiliev - Yes, you submit the usage for BUILDPACK_SET event but the preceding start would still have to be submitted as unknown - what discussed in #37 and #38 would help with that submission and the unknown period would depend on the interval between events. I don't have detailed numbers but that interval is usually minutes. But we have also seen situation when there is START, followed by STOP, both without guid and without buildpack_set event between them.
Also, from the 200k event sample sample there were about 42k of BUILDPACK_SET events and all of them contain the buildpack_guid (CF 210).

The lack of buildpack info in the initial START event is not a defect as explained at [1] - the information is not yet available and will be provided in the following BUILDPACK event.
[1] -<EMAIL_ADDRESS>

@piotrprzybylski, @hsiliev Is there any further discussion needed here or is a code change required? otherwise I'm planning to close this issue in a day or two.

Closing as there's no more discussion. Please reopen if needed.


[3.1] Add new modules kubernetes and xds

Add new modules and reognize related codes.

dubbo-kubernetes, kubernetes integration
dubbo-xds, xds integration

Codecov Report

Merging #10325 (80c2eee) into 3.1 (f1af604) will decrease coverage by 0.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #10325      +/-   ##
============================================
- Coverage     65.54%   64.84%   -0.70%
+ Complexity      319      294      -25
============================================
  Files          1243     1243
  Lines         54155    54148       -7
  Branches       8184     8158      -26
============================================
- Hits          35495    35112     -383
- Misses        14792    15164     +372
- Partials       3868     3872       +4

Impacted Files
Coverage Δ

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pc/cluster/router/file/FileStateRouterFactory.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...o/rpc/cluster/router/script/ScriptStateRouter.java
0.00% <0.00%> (-67.31%)
:arrow_down:

...mmon/serialize/fastjson2/FastJson2ObjectInput.java
0.00% <0.00%> (-62.50%)
:arrow_down:

...mon/serialize/fastjson2/FastJson2ObjectOutput.java
0.00% <0.00%> (-56.25%)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
15.72% <0.00%> (-55.90%)
:arrow_down:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...on/serialize/fastjson2/FastJson2Serialization.java
57.14% <0.00%> (-28.58%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-25.00%)
:arrow_down:

... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1af604...80c2eee. Read the comment docs.


Feature: Add specified message

I like the shortcut to commit my current state in one go to GIT. However, I would like to specify a short message when I invoke the command myself. Workflow for me is;
Hotkey -> Commit prompt (may be pre-filled with default message) -> Commit & Push all
Ideally I see the files and check / uncheck the ones excluded, but I understand the philosophy of the backup plugin, and I can use a separate source control tool e.g. Sourcetree to do a fine grained commit. But in small bursts (e.g. an adjustment to one jounal entry) I would like to specify a more fine grained message.
Thank you for this plugin!

I'd like to +1 this, especially if invoked by a hotkey.
Currently, I rely on another Git client (GitKraken or Git bash) to manually set commit message.

I'd like to +1 this, especially if invoked by a hotkey.
Currently, I rely on another Git client (GitKraken or Git bash) to manually set commit message.

Is now available in the new release


feat: check the directory the script is being run from and give a warning

Signed-off-by: Harikrishnan Balagopal<EMAIL_ADDRESS>

Was there an issue with the approach 1 of using $0?


Allow supporting multiple sources of object/location metadata

Another great idea suggested by a user.
This would allow not needing to copy-paste as much, and under the hood it's really just a bunch of dictionary merges.

Hi @sea-bass, I would like to work on this issue, but I’m not entirely sure what needs to be done here. From what I see in the current codebase, location and object metadata are defined in YAML files and loaded using world.set_metadata, either directly through the World class or via the WorldYamlLoader. Could you share more details about what you have in mind?

Correct -- so right now, you can only link to a single metadata file.
But what if you have multiple file sources? For example, you may have:

Food objects
Drink objects
Garbage objects
... etc

What if you could specify multiple sources of metadata, so instead of set_metadata() there was something like add_metadata() that would combine knowledge from different files to prevent copy-paste?

Hi @sea-bass, thanks for explaining. With this much information, I’ll start thinking and get back to you once everything is clear in my mind.

I did some digging and planning to implement something like this:
Current Codebase:
World.set_metadata currently accepts a single source of metadata for locations and objects. Under the hood World class is delegating the set_metadata responsibility to individual Locaton.set_metadata and Object.set_metadata, which further call EntityMetadata to load the parsed metadata (YAML) into a dict.
During this process, EntityMetadata saves the filename, which later used by WorldYamlWriter. Since the current implementation uses a single metadata source, the self.filename attribute in EntityMetadata is enough to store information
Approach for supporting multi sources of locations/objects metadata:
As you suggested, we can define add_metadata something, so I am planning to add this method to the World, Location, and Object classes, similar to how set_metadata is used in the current implementation. The add_metadata methods in Location and Object will call an update method in EntityMetadata, which will be responsible for merging metadata from different sources.
For example:
class World:
   ....
   def add_metadata(self, locations=None, objects=None):

        if locations is not None:
            Location.add_metadata(locations)
        if objects is not None:
            Object.add_metadata(objects)
   ....

class Location:
   ....
   @classmethod
    def add_metadata(cls, filename):
        new_metadata = EntityMetadata(filename)
        cls.metadata.data.update(new_metadata.data)
   ....

class Object:
   ....
   @classmethod
    def add_metadata(cls, filename):
        new_metadata = EntityMetadata(filename)
        cls.metadata.data.update(new_metadata.data)
   ....

class EntityMetadata :
  self.data
   ....
   def update(self, new_data):
        self.data.update(new_data)
   ....

Based on above implementation (rough idea) we can create a world from different sources like this:
world.add_metadata(
        locations=os.path.join(data_folder, "location1.yaml"),
        objects=os.path.join(data_folder, "object1.yaml")
    )

 world.add_metadata(
      locations=os.path.join(data_folder, "location2.yaml"),
      objects=os.path.join(data_folder, "object2.yaml"),
  )

 world.add_metadata(
      locations=os.path.join(data_folder, "location3.yaml"),

One challenge I foresee with this approach is ensuring that I collect all the source files that define metadata for locations and objects. Based on this, I would need to modify the logic in WorldYamlWriter, which is especially important when the reset-world option is selected in the GUI.
What do you think of this approach?

FYI, today I tried implementing the approach shared above, and it is working fine so far. I am planning to test it thoroughly from every possible angle.Once I am confident it is working well and after receiving your feedback on the shared approach, I will raise a draft PR, so that you can check out the working model. If any changes or additions/deletions are needed, I’ll address them there.

Hi @sea-bass, does the above-shared approach align with your thoughts on supporting multiple sources of object/location metadata?

Hi @sea-bass, does the above-shared approach align with your thoughts on supporting multiple sources of object/location metadata?

Yes, this looks good! Feel free to put up a draft PR whenever you have something, and I'll look at the code.


Content management: consider offline if Kolibri Studio isn't reachable

It has been noted that the offline check we have in place is weak. We currently use it in the onboarding for disabling download option and in the landing page for disabling the feedback button. But there are more uses coming for content management: download content should be scheduled for later if the app is offline https://github.com/endlessm/endless-key-content-private/issues/17#issuecomment-1551338721
The way we do it is by listening to the browser offline event.
The Kolibri Device tab does it by checking if Kolibri Studio is reachable. That seems a better approach for or own content management, which uses Studio too.

I'm deassigning myself from this one too.


Terminal font

I really love this font draws line instead of ⣿, may I ask what font is being used?
Thanks.

its jetbrainsmono nerd font

I am using the same font but it doesn't draw lines.
Can you kindly share your st config? Thanks.

I am using the same font but it doesn't draw lines. Can you kindly share your st config? Thanks.

it doesnt draw lines? wym, you mean ligatures?

check my st repo!

Thank you so much for your config,
it turns out it's my st problem, after install your verison it draws blocks instead of braille.

check my st repo!


scrap metal illustration

Asset: https://drive.google.com/file/d/1cKoSUr3omx7F3sPeMJvWublbC2mFfmI8/view?usp=sharing

Credit to: CrispBacon


Installer Blank Page After Migration

fixed. it turns out i did not put proper permission on database user.

SQLSTATE[42804]: Datatype mismatch: 7 ERROR:  column "special_price" cannot be cast automatically to type numeric
HINT:  You might need to specify "USING special_price::numeric(12,4)". error postgres 12

Hi! I have the same problem but a my database user has All Privileges.

@LuckyDude68
instead of GUI, you can check setup the bagisto using command line.
check if .env exist then add the database credentials and run the below command
php artisan bagisto:install

@vaishaliwebkul
I installed it using CLI,
.env exists,
I did 'php artisan bagisto:install',
and with or without 'php artisan serve'
it still remains the same

@LuckyDude68
Is php artisan bagisto:install command executed successfully??

@vaishaliwebkul I did a full reinstall and now it seems to work.

Getting below error

@elitedigitaltech
you may follow this https://forums.bagisto.com/topic/1913/base-table-or-view-not-found/2

Follow that for fresh migration but still same error base table channel not found

@elitedigitaltech
may I know your database version? Also check the total number of table created in database.

No table created

Follow that for fresh migration but still same error base table channel not found

I have this error with a fresh install
how can solve it


Feature with large image - CTA does not obey open in new window checkbox

The Feature with Large Image CTA does not obey the "open in new window" checkbox in the link properties dialog.

I looks like that info isn't being sent to the field based on an ACF option. It's also one of those odd links that still has a separate field for the label.
We could either

update the ACF field to also send the extra info, including the 'new window' option and not change anything else
or update ACF and remove the label to just use the 'Insert/edit link' format to handle the label and the link

And if this is the preferred option, should it be updated across all links?

I also noticed that we may not have an 'External Link' style for buttons like we do for links, so this also might be a discussion for the larger group.
https://www.theme.iastate.edu/iastate22/fractal/components/detail/link-set.html


GitLab Support

I currently self-host GitLab and use it almost exclusively, so I'd love to see support for GitLab. GitLab has its own implementation of webhooks but it I believe it has some compatibility already with GitHub webhooks (you might be able to use a similar request body).
I'll have a look at getting it running with GitLab and make a PR if any changes need to be made.

We've split a lot of the GitHub specific logic out already, so it should be straightforward to copy that pattern into a gitlab method. Then, we could add a specific /gitlab endpoint to handle the webhook specifics.
I don't know much about GitLab, so I'm opening this up for contributions! Shouldn't be too much work tbh!

@zpnk I'm working on this, not sure when I'll have it done by though! 👍


Fetch view columns asynchronously

Right now, we synchronously fetch the column names and then populate the view columns. This tweaks that logic to fetch them async in tandem with populating our views and then filling in the columns after the fact.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 11 (81.82%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 91.931%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

introspect.go
9
11
81.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
3851

Relevant Lines:
4189

💛  - Coveralls


Disable decimal

How I can disable decimal?
I could not find it in documentation
If  aDec set to null it will trigger error vmin and vmax

One of two ways
//Use whole numbers only on the min/max
vMax: "9999999999"
vMin: "0"
or
// assign 0 to the mDec option
mDec: "0"
On 12/14/2015 2:09 AM, Epenjehem wrote:

How I can disable decimal?
I could not find it in documentation
—
Reply to this email directly or view it on GitHub
https://github.com/BobKnothe/autoNumeric/issues/185.

Gracias :)


Add an "object proxy" example

Hello,
Perhaps it's me, but the examples of the documentation seem pretty advanced. For example, when we check Pykka, the first example is about proxies, but I haven't found how to do something equivalent with pulsar.
Here is what Pykka looks like for this example:
import pykka

class Data(pykka.ThreadingActor):
    pykka_traversable = True
    def __init__(self):
        super(Data, self).__init__()
        self.saved_value = 0
    def inner_method(self):
        return 42

if __name__ == '__main__':
    actor_ref = Data.start()
    actor_proxy = actor_ref.proxy()
    print(actor_proxy.inner_method().get())
    actor_proxy.saved_value = 10
    print(actor_proxy.saved_value)

# Output:
# 42
# 10

Would it be possible to have an example for this case in the documentation as well?

Does the greater example do?
https://github.com/quantmind/pulsar/blob/master/examples/snippets/greeter.py
pulsar requires asyncio event loop to run.

The greeter example shows a class calling a method outside itself, and it also calls the global variable names just like that.
I don't get it…

Please contact the mailing list for this type of questions.


typo

Inside the database clusterz

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07adfd46-7af7-5966-a3de-d67623f6c642
Version Independent ID: a638d2d6-5be0-7e40-70ea-dc2a3f65e649
Content: Connectivity architecture in Azure Database for PostgreSQL
Content Source: articles/postgresql/concepts-connectivity-architecture.md
Service: postgresql
GitHub Login: @kummanish
Microsoft Alias: manishku

@omiday We are looking into this and will make necessary changes.

@omiday We have created the PR to make this change. It will reflect once it is approved.

@kummanish Please review the changes for following PR and take appropriate decision:
https://github.com/MicrosoftDocs/azure-docs-pr/pull/85779

I have seen the change. Looks good to me.

@kummanish You must have received a request to approve the change. Please check and approve the request.

Link of the PR
https://github.com/MicrosoftDocs/azure-docs-pr/pull/85779

@omiday we have made necessary changes to the doc and they may take some time to reflect. We will close the issue once the changes are reflecting.


Uncaught ReferenceError: $timeout is not defined

error only occurs in min ver. Maybe inline annotation is missing for $timeout?
c3-angular.min.js:5
angular.module("gridshore.c3js.chart").directive("c3chart",["$timeout",C3Chart($timeout)]),angular.module("gridshore.c3js.chart").directive("chartColors",ChartColors),angular

Fixed the issue, everything is back to normal again


Add vote.volatility.com to custom domains

Hi! What is your PR about?

[ ] Add or edit a skin
[x] Add custom domain for your space
[ ] Add alias for migrate your space
~Add images for your space~ (deprecated) Add the image URL on the space settings directly
~Edit your space with GitHub?~ (deprecated) Please migrate your space to ENS https://docs.snapshot.page/spaces/migrate
~Create your space with GitHub~ (deprecated) Create your space with ENS instead https://docs.snapshot.page/spaces/create

Moved up a few lines, thanks 🤓


Unittest not running because QiskitTestCase class is removed in Qiskit 1.0.

Information

Qiskit Cold atoms version:latest
Python version: Python 3.12.3
Operating system: macOS

What is the current behavior?
As per issue #97, the qiskit-terra (>=0.17.1) dependencies need to be removed. I have also noticed that the unittest files depend on the qiskit.test class QiskitTestCase, which is not available in Qiskit 1.0 and beyond.
Steps to reproduce the problem

Create a virtual environment
Install the latest version of Qiskit 1.0 and necessary qiskit libraries (e.g. qiskit_are, qiskit-nature, qiskit-algorithms)
Update lines 26 and 27 of qiskit_cold_atom/applications/time_evolution_solver.py to:

            from qiskit_algorithms import TimeEvolutionProblem
            from qiskit_algorithms.time_evolvers import TrotterQRTE

(this change will ensure the use of the qiskit-algorithm rather than the deprecated qiskit.algorithm.

run python -m unittest  in the root folder
The error displayed is:

            From qiskit.test import QiskitTestCase
        ModuleNotFoundError: No module named 'qiskit.test'

This is because qiskit.test class QiskitTestCase is not defined in Qiskit 1.0
What is the expected behavior?
Unittests should run and either pass or fail.
Suggested solutions
[update at on 3/09/24 at 16:43GMT on possible solution]

remove qiskit.test from qiskit-cold-atom and use an alternative method

I think this problem should be addressed before (or while) resolving issue #97

Indeed, QiskitTestCase was removed in https://github.com/Qiskit/qiskit/pull/11445. It can probably just be replaced by unittest.TestCase.

Hello @1ucian0 okay! I will try this and open a PR when done.

Hello, @1ucian0 is there any documentation explaining how to substitute iteration of CircuitInstruction in Qiskit 2.0 using the operation, qubits and clbits named attributes? I am searching for it but cannot find it anywhere.

I think I resolved the problem.

Great! want to push somewhere? I could have a look.

Hello, I only fixed that particular issue, I still have some others to solve. They will all be on this branch
https://github.com/robotAstray/qiskit-cold-atom/tree/fix-qiskit-terra-dependencies

@1ucian0 Since we need to move from BackendV1 to BackendV2, some changes are necessary in the definition of the class FermionSimulator(), which inherits from the class BaseFermionBackend(), which takes a BackendV2  as an argument.
FermionSimlutor will need two additional methods:

def max_circuits()
def target()

What would be the requirements for (1) and the instructions for (2)


 Hopefully this causes GHCR to end up with a valid image manifest, up until now all of them have been weird/broken.

Not sure if this will actually fix the issue, but worth a try.


go-docker: update to 1.6 builder

Can we update this to 1.6.1 while we're at it?
https://groups.google.com/forum/#!topic/golang-announce/9eqIHqaWvck

closing as #433 fixed this


Missing feedback after copying

After copying the address or the profile link (via the Share button) we should show a toast indicating that the text was successfully copied.
If we don't, it looks like the copy action is not working.

Hi! rendering a toast includes too much effort and time we don't have now. What about this solution I proposed here: https://profile-git-fix-copy-feedback-decentraland1.vercel.app/accounts


Recurrence Relations notes by MIT

:wave: hey @kunal-kushwaha! This looks great. I'll go ahead and merge this, thanks for the contribution! :100:


Add alternative mirrors

I don't know any other mirrors that always serve maps with video. chimu.moe is fast, but only returns video sometimes. kitsu.moe only returns videos within the US.

The downloads seem to be stopping partway through, or even returning corrupted results?

catboy.best is back up, but I should still find an alternative in case it goes down again.


Tooltip docs are incomplete

The Tooltip docs say:

Wrap the button in a Tooltip widget to show a label when the widget long pressed (or when the user takes some other appropriate action).

The (or when the user takes some other appropriate action) implies we could choose other actions to show the Tooltip, or that at least they are already built-in, but the docs don't mention any other ways to show the Tooltip neither how to reconfigure it's default behavior, like changing "long-press" to "on tap".
The only hint I could get to the explanation of this sentence is in the waitDuration description where it says the Tooltip will also be shown on a pointer hover.
So are the docs incomplete or the Tooltip should have additional functionality?

@feinstein @TahaTesser - Could anyone help me I want the tooltip to work "on tap" not by "long-press"

Currently you can't.

Can we close this issue?

@TahaTesser what does the "good first contribution" label means?

@feinstein
This label encourages first-time contributors to fix an issue, especially those who feel daunted by the idea of creating PR for  Flutter itself, I would think fixing tooltip docs would qualify

Understood.
The problem here is knowing the intent of the text, is the text wrong or is the implementation wrong? And the only ones who know are the devs of the Tooltip.
Sometimes I open issues like this, where the docs and the implementation conflict. We can't know if the docs should be fixed to match the code, or the code should be fixed to match the docs. But a lot of times the beginners jump to fix the docs, and if the reviewers aren't careful, we can make a bug become the official implementation.

@feinstein
I agree
CC @HansMuller since he approved this https://github.com/flutter/flutter/pull/65250 and can shed some light on this issue
Thank you

@feinstein I see your point, I thought since the documentation has been over this issue could be closed.

#66250 rewrote the bit of text in question so I'm going to close this issue. If the new text (below) is still confusing, please open a new issue.
/// Tooltips provide text labels which help explain the function of a button or
/// other user interface action. Wrap the button in a [Tooltip] widget and provide
/// a message which will be shown when the widget is long pressed.

Not confusing at all, just making sure we have the intended behavior on the docs and not a possible deviation by a bug.


bug: Infinite loading screen v1.0.6

The loading screen in the Pyoncord Discord mod never stops, preventing access to the app's features. The user interface remains stuck on the "Bezig met laden (loading in English)" message indefinitely.
Device Details:

Device: Samsung Galaxy A54 5G
OS: Android 14
App Version: v1.0.6

Additional Information:

The issue persists after restarting the app.
No error messages are displayed.

Attachments:

Screenshot of the loading screen

Having the same issue on both Samsung Galaxy s21 and s9

Having the same issue on both Samsung Galaxy s21 and s9

Did you find a fix?

Network issue, try a different ISP/network or use a VPN and perform a restart


helmfile sync/apply output error when 'installed: false' is set and the release does not exist.

continuing in the spirit of https://github.com/roboll/helmfile/issues/423 ..
I understand that the intended behaviour for this is to simply uninstall a release if it is already installed. but could it be possible to do so AND if it is not released, not output any error? or at the very least just a Warning?? FWIW it does not error our (command still exits with 0 despite the various e.g. Error: getting deployed release "jaeger": release: "jaeger" not found
Reason is I am using this as a way to decide on which env (which correspond to kube contexts in my case) to install charts on, rather than have 1 helmfile per env, i've decided to create 1 helm file per namespace with all possible charts in each namespace, but explicitly setting which envs need those charts with installed values such as:
installed: {{ eq .Environment.Name "dev" "staging" "production" }}
installed: {{ eq .Environment.Name "dev"  }}
installed: {{ eq .Environment.Name "qa" "staging" "production" }}
installed: {{ eq .Environment.Name "production" }}
etc.
Many thanks!

Good catch! This should definitely be fixed, and I submitted #508

Thank you @mumoshu !


Make TargetPlatformVariant.all the default for flutter widget tests

This changes the default platform variant for widgets tests from just TargetPlatform.android to TargetPlatformVariant.all().
The motivation for this change is described in the design document at flutter.dev/go/test-all-platforms
Fixes https://github.com/flutter/flutter/issues/86817
Will require follow up in https://github.com/flutter/flutter/issues/87682 for broken test files.
These files are broken due to

leaked states or dependencies
some tests are platform-specific and rely on the previous default
many are affected by default scrollbars on desktop platforms as those tests require a MediaQuery to be present

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@goderbauer I have added comments to the points of interest above. There are a lot of tests to repair after this, but most of them are simple (i.e. most scrolling tests are missing media queries needed by desktop scrollbars)

Gold has detected about 1 new digest(s) on patchset 10.
View them at https://flutter-gold.skia.org/cl/github/87680

Gold has detected about 1 new digest(s) on patchset 11.
View them at https://flutter-gold.skia.org/cl/github/87680

Gold has detected about 1 new digest(s) on patchset 12.
View them at https://flutter-gold.skia.org/cl/github/87680

After discussing with other contributors, I do not think we are going to pursue this change right now, the newly introduced test randomization needs time to stabilize. This change would exacerbate the amount of potentially broken tests from day to day when the random seed changes. Will leave the issue open to revisit.


filing search have to specify filing type even though it is optional

filing search have to specify filing type, even though it is supposed to be optional
#To Reproduce
using the filing doc quickstart example but removing row on filing type
from datetime import date
from secedgar import filings, FilingType

my_filings = filings(start_date=date(2020, 12, 10),
                     end_date=date(2020, 12, 15),
                     user_agent="Name (email)",
                     count=50)

my_filings_urls = my_filings.get_urls()

#Bug
AttributeError                            Traceback (most recent call last)
/var/folders/p6/282rtsj52x15882qy3mp5hpc0000gn/T/ipykernel_37555/3180531280.py in <module>
      5 company_filings = filings(cik_lookup="aapl",
      6                           user_agent="Name (email)")
----> 7 company_filings_urls = company_filings.get_urls()
      8 company_filings_urls

~/opt/anaconda3/lib/python3.9/site-packages/secedgar/core/company.py in get_urls(self, **kwargs)
    246             urls (list): List of urls for txt files to download.
    247         """
--> 248         return {
    249             key: self._get_urls_for_cik(cik, **kwargs)
    250             for key, cik in self.cik_lookup.lookup_dict.items()

~/opt/anaconda3/lib/python3.9/site-packages/secedgar/core/company.py in <dictcomp>(.0)
    247         """
    248         return {
--> 249             key: self._get_urls_for_cik(cik, **kwargs)
    250             for key, cik in self.cik_lookup.lookup_dict.items()
    251         }

~/opt/anaconda3/lib/python3.9/site-packages/secedgar/core/company.py in _get_urls_for_cik(self, cik, **kwargs)
    285         while self.count is None or len(links) < self.count:
    286             data = self.client.get_soup(self.path, self.params, **kwargs)
...
--> 263         filings_filtered = [f for f in filings if f.type.string == self.filing_type.value]
    264         return [f.filinghref.string for f in filings_filtered]
    265

AttributeError: 'NoneType' object has no attribute 'value'

Thanks for pointing this out @juliantcchu! Are you able to help with the bug fix?


Land sea mask generation

[x] Add the land sea mask generation capability using regionmask
[x] Replace CDAT's landseamask generation to the new function

[x] mean climate
[x] precipitation variability

Sanity check:

[ ] demo 1b notebook results are consistent
[ ] demo 7 notebook results are consistent

I'll test this out in the extremes metrics branch

@lee1043 This looks fine to me:

@lee1043 This looks fine to me:

I actually did not implement the new mask correctly and I believe this is using the pcmdi_utils version...still working on testing the extremes

@acordonez Thank you for checking. Please let me know when you done testing this with extreme branch. If merging this PR into main would better help your testing of extreme branch, I can also do that.

This time I should be using the new land/sea mask, I pulled all the other code out of my branch: