A simple way to replace siimple colors

Is your feature request related to a problem? Please describe.
My problem is that I would like to be able to use my own colors
Describe the solution you'd like
A simple way to replace siimple's default values
Describe alternatives you've considered
The first obvious solution was to overwrite all colours and background for each class, but it can feel like you are rewriting the all siimple CSS.
Secondly, we could rename all the legacy colours and palette colours from the variables file but it will mean we will have the redo the operation at each package update.
Additional context
Thanks for your help. Really great library, like the fact that this is CSS only! ;)

Hello @valentinbdv ! Thanks for your issue!
Yes, you can replace the default colours of siimple without rewriting the library. As you can see in file scss/_variables.scss, all the colours variables has a !default flag, so you can create a SCSS file, for example custom-siimple.scss, and overwrite the variables you want:
//My custom colors
$siimple-default-primary: #4e91e4;
$siimple-default-success: #4acf7f;
$siimple-default-warning: #fbc850;
$siimple-default-error: #ee675d;

//Load the siimple library
@import "siimple/scss/siimple.scss";

Now you can compile this file with sass, and you will get a CSS file with all the siimple components but using your own colors.
Please, try it and tell me if that solves your question. If not, we can find another solution :smile:

@jmjuanes thanks a lot for your quick answer. Impressive!
It works, I indeed can easily change siimple's colours.
But there is a drawback, now the siimple style is compiled after mine and so it overwrites my style when I want the opposite.
Not sure how I can avoid that while still being able to have my colours used by siimple.

Ok I figured it out.
Just had to import custom-siimple file at first.
Thanks again ;)

@valentinbdv You can import only your custom-siimple, because both have the same components. If you import the original and your custom version, you are loading the same library twice...

Yes @jmjuanes I was importing it only once.
But the issue was that I imported my custom-siimple (which import all siimple) after every CSS files. So I just had to import it first to allow my own style to overwrite siimple style.

@valentinbdv Perfect! :smile:

Closing this issue. Please, if you have more questions please open a new issue! Thank you :smile:


chore: release main

:robot: I have created a release beep boop
renderer: 1.0.11
1.0.11 (2023-12-23)
Bug Fixes

upd renderer (6645f19)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pavophilip/react-shader-fiber/releases/tag/renderer-v1.0.11 :sunflower:


Duplicate Notification Received upon FCM Error

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: N/A (we are using Firebase Functions)
Firebase SDK version:
Library version: firebase-admin 6.0.0
Firebase Product: Messaging

[REQUIRED] Step 3: Describe the problem
Received duplicate notification upon error from firebase-admin messaging.

{ Error: The service is currently unavailable.
at FirebaseMessagingError.FirebaseError [as constructor] (/srv/node_modules/firebase-admin/lib/utils/error.js:39:28)
at FirebaseMessagingError.PrefixedFirebaseError [as constructor] (/srv/node_modules/firebase-admin/lib/utils/error.js:85:28)
at new FirebaseMessagingError (/srv/node_modules/firebase-admin/lib/utils/error.js:241:16)
at Function.FirebaseMessagingError.fromServerError (/srv/node_modules/firebase-admin/lib/utils/error.js:271:16)
at FirebaseMessagingRequestHandler.handleHttpError (/srv/node_modules/firebase-admin/lib/messaging/messaging-api-request.js:125:50)
at /srv/node_modules/firebase-admin/lib/messaging/messaging-api-request.js:113:23
at
at process._tickDomainCallback (internal/process/next_tick.js:228:7)
errorInfo:
{ code: 'messaging/server-unavailable',
message: 'The service is currently unavailable.' },
codePrefix: 'messaging' }

Steps to reproduce:
This is the first time it has happened. We just sent a notification after a Firestore trigger is executed (onCreate). And we encountered that error. It does not happen always. Since it is intermittent, I cannot provide a way to reproduce it.
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
We just sent the notification using this piece of code
return admin.messaging().send(message)     .then((response) => {       return console.log('Response: ', response);     })     .catch((err) => {       console.error(err);     });
No retry at all. So if the server respond w/  'Error: The service is currently unavailable.' I expect

Firebase Messaging does not send it at all
Firebase Messaging handles the retrying and no duplicate notification should occur.

// TODO(you): code here to reproduce the problem

Thanks,
Kian

@kixortillan how often would you say this happen?
Tagging @sampson-chen to follow up.

@hiranya911 Actually this only happened twice on the same day with a time difference of less than 10 mins. It never happened again. Also, (I'm not so sure) I think the mobile phone received the notification, w/c is the opposite of what the error message stated. Because our QA team raised that they received a duplicate notification where in fact my logs state that an error has occurred while sending it.
That's all I can provide for now. Just want to give you a heads-up so maybe the Firebase team may revisit the implementation of this sometime.
Thanks!

Getting duplicate notifications occasionally too. We're sending notification on http request.

the same issue.. duplicate notifications and errors

Same happens to us occasionally.

Sorry for the slow response on this issue. Did this happen again recently? It would be helpful to know the exact time when this happened.

I got duplicated notifications with sendAll(), frequently.

Confirmed this issue comes from google services

Hi @tuledev can you file a support ticket in https://firebase.google.com/support ? From there we can start get for information from your requests etc.

fwiw - I'm getting this daily using the python library.


Possible EventEmitter memory leak detected

There is a bug when using the latest version Atom and Break. I'm sure this is related to socket.io
(node:9955) Warning: Possible EventEmitter memory leak detected. 11 ipc-helpers-window-method-response listeners added. Use emitter.setMaxListeners() to increase limit

This is a problem with Atom and not Break.


Error:(40, 8) error: RNGoogleSigninModule is not abstract and does not override abstract method onNewIntent(Intent) in ActivityEventListener

Works great on iOS, but after following Android setup guide the gradle build fails. I'm getting this error:
Error:(40, 8) error: RNGoogleSigninModule is not abstract and does not override abstract method onNewIntent(Intent) in ActivityEventListener

This was user error. I was using 0.6.1 of this package.

I have the same issue with RN v0.33 and react-native-google-signin v0.8.0. I'm getting this error:
RNGoogleSigninModule.java:40: error: RNGoogleSigninModule is not abstract and does not override abstract method onActivityResult(Activity,int,int,Intent) in ActivityEventListener
public class RNGoogleSigninModule extends ReactContextBaseJavaModule implements ActivityEventListener
and this error:
RNGoogleSigninModule.java:53: error: method does not override or implement a method from a supertype

I have the same issue with RN v0.33 and react-native-google-signin v0.8.0.

Since RN v0.33 FB has changed onActivityResult listener interface.
I have solved this issue thanks to @ivpusic and his PR #126

I had this problem too.
And I solve this problem by removing the "Activity activity" parameter from onActivityResult () method in RNGoogleSigninModule.java


Turn prgi into a general tool

The prgi tool is tied to prgi (DD1315). Change it into a more general tool, canvas2ladok. It can take the identifiers (set as variables in prgi) from the command line.

And perhaps we should move this tool to another repo?

Have the prgi tool as an import command. Then we can add the corresponding export command in the canvas command (or similar).


JIT donate_argnums slows down execution

Description
I'm currently working on an RL project where I augment a replay buffer (basically a dynamically growing deque of data) inside a jitted function I loop over using jax.lax.fori_loop. However, this requires memory copies of the complete deque every time I modify it, which is quite some overhead with 100k entires. Inspired by https://github.com/hr0nix/dejax, I thought it might make sense to try out the donate_argnums argument when jitting the function.
This is my setup before the modification:
def loop_fn(_, carry):
    loop_state, replay_state = carry
    ...
     # Some modifications to the loop_state and replay_state
    return new_loop_state, new_replay_state

loop_fn = jit(loop_fn)
for i in range(...):
    loop_state, replay_state = jax.lax.fori_loop(0, FLAGS.log_frequency, loop_fn, (loop_state, replay_state))

Because jax.lax.fori_loop only accepts one argument to the looped function, I have to "hack it" a bit to be able to make use of donate_argnums, i.e.:
def fori_loop_fn(loop_state, replay_state):
    return jax.lax.fori_loop(0, FLAGS.log_frequency, loop_fn, (loop_state, replay_state))

fori_loop_fn = jit(fori_loop_fn, donate_argnums=(1,))
for i in range(...):
    loop_state, replay_state = fori_loop_fn(loop_state, replay_state)

I mean, it works, however, it's tremendously slowing down training. Do you know why this is? I thought donate_argnums might even improve performance. Or might there be an issue with how I combine it with jax.lax.fori_loop?
What jax/jaxlib version are you using?
0.4.13
Which accelerator(s) are you using?
GPU
Additional system info
Ubuntu 20.04
NVIDIA GPU info
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.125.06   Driver Version: 525.125.06   CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:08:00.0 Off |                  N/A |
| 32%   41C    P8    21W / 350W |     20MiB / 24576MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      1325      G   /usr/lib/xorg/Xorg                  9MiB |
|    0   N/A  N/A      1699      G   /usr/bin/gnome-shell                6MiB |
+-----------------------------------------------------------------------------+

It's hard to say what's going on here without more information. I tried reconstructing the issue given the information you provided, and found that buffer donation speeds up the execution by about 20%:
import jax
import jax.numpy as jnp

def loop_fn(_, carry):
    loop_state, replay_state = carry
    new_loop_state = loop_state + 1
    new_replay_state = replay_state + 1
    return new_loop_state, new_replay_state

loop_fn = jax.jit(loop_fn)
LOG_FREQUENCY = 1000
NUM_ITERS = 100

def fori_loop_fn(loop_state, replay_state):
    return jax.lax.fori_loop(0, LOG_FREQUENCY, loop_fn, (loop_state, replay_state))

fori_loop_fn_jit = jax.jit(fori_loop_fn)
def f_without_donation(loop_state, replay_state):
  for i in range(NUM_ITERS):
    loop_state, replay_state = fori_loop_fn_jit(loop_state, replay_state)
  return loop_state, replay_state

fori_loop_fn_donate = jax.jit(fori_loop_fn, donate_argnums=(1,))
def f_with_donation(loop_state, replay_state):
  for i in range(NUM_ITERS):
    loop_state, replay_state = fori_loop_fn_donate(loop_state, replay_state)
  return loop_state, replay_state

loop_state = jnp.arange(100)
replay_state = jnp.arange(100_000)

%time fori_loop_fn_jit.lower(loop_state, replay_state).compile()
# CPU times: user 57.5 ms, sys: 1.82 ms, total: 59.3 ms
# Wall time: 53.8 ms

%time fori_loop_fn_donate.lower(loop_state.copy(), replay_state.copy()).compile()
# CPU times: user 61 ms, sys: 2.89 ms, total: 63.9 ms
# Wall time: 66.7 ms

%time loop_state, replay_state = jax.block_until_ready(f_without_donation(loop_state, replay_state))
# CPU times: user 1.03 s, sys: 4.04 ms, total: 1.03 s
# Wall time: 1.04 s

%time loop_state, replay_state = jax.block_until_ready(f_with_donation(loop_state, replay_state))
# CPU times: user 884 ms, sys: 2.2 ms, total: 886 ms
# Wall time: 886 ms

(in case you're unfamiilar, %time is an IPython magic command that works in notebook environments like Jupyter or Colab)
This makes me think that some other unmentioned factor is relevant in your situation. Would it be possible for you to distill your code into a minimal reproducible example of the behavior you're seeing?

Hm, okay interesting. I will try to build a minimal reproducible example. However, I already noticed a few of the following prints in my output:
Constant folding an instruction is taking > 1s:

  %fusion.5 = (u32[8388608]{0}, u32[8388608]{0}) fusion(), kind=kLoop, calls=%horizontally_fused_computation

This isn't necessarily a bug; constant-folding is inherently a trade-off between compilation time and speed at runtime. XLA has some guards that attempt to keep constant folding from taking too long, but fundamentally you'll always be able to come up with an input program that takes a long time.

I ran the command with the XLA_DUMP flag, however, this creates over 4k files.
xla_dump_files.txt
I added the ls of the directory as a txt file. However, don't know if this helps in any way.


Can you release KID evaluation code you used in your paper?

+1

@Ha0Tang https://github.com/taki0112/GAN_Metrics-Tensorflow  The other repo of the author might help

@taki0112  Hi, taki. I use your pretrained 100epoch model to run the test with your dataset, and calculate the KID with THE above method of yours.
I put 100 selfie image of testA into folder real_source, and 100 anime image from trainB into folder real_target, the generated 100 anime images from testA are put into folder fake.
It takes very long time to calculate FID.
KID_mean :  2.721179649233818
KID_stddev :  0.5364757962524891

And
mean_FID :  1.3425915359497071
mean_KID_mean :  11.149919640272856
mean_KID_stddev :  0.4221153156831861

And my question is how can I evaluate a single image?

I got this result I have no idea to solve how to get its result. Please help me If so I will do appreciate it.
Instructions for updating:
Use keras.layers.flatten instead.
Calculating Inception Score with 200 images in 10 splits
Inception Score calculation time: 19.770402 s
IS :  (3.134819, 0.46620637)
WARNING:tensorflow:From /home/prip/GAN_Metrics/frechet_kernel_Inception_distance.py:128: to_double (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.cast instead.
FID :  0.7782485961914063
WARNING:tensorflow:From /home/prip/GAN_Metrics/frechet_kernel_Inception_distance.py:246: to_int32 (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.cast instead.
KID_mean :  nan
KID_stddev :  nan


pod-topology-spread link is broken (filename probably renamed)

Links for pod-topology-spread kep is broken.
Links was corrected to the right name (in all languages).
In addition, Markdown was linted with vscode plugin

Thanks for the clean up. Could you please split this into separate PRs for different languages? We have subteams dedicated to review different translations.

Thanks for the clean up. Could you please split this into separate PRs for different languages? We have subteams dedicated to review different translations.

Sure
https://github.com/kubernetes/website/pull/19970
https://github.com/kubernetes/website/pull/19971
https://github.com/kubernetes/website/pull/19972
Closing this issue


Fixed sorting bug for multi column sort

There was a bug in multi column sort where the orders and sort fields  would be reversed on table redraws without the user changing the sort info. This was because array.reverse() was used which changes the underlying array. Applying slice().reverse() first makes a copy of the original array and then returns the reverse of it, leaving the original arrays in a correct state.

hello @varak69, thank your contribution, I'll review it as soon as possible, btw, is https://github.com/AllenFang/react-bootstrap-table/issues/973#issuecomment-274288558 the issue you try to solve?

Hi @AllenFang
I took a look at that issue and commented as to why it isn't working. Just a spelling error.
This fix is for another issue which hasn't been logged but I came across it in our app. We had a table which was being unnecessarily redrawn on mouse enter/leave. Each time it was redrawn the order of the sort fields changed without them being changed by the user. I'll see if I can make a codepen for it.

thanks for quickly response :) it's awesome that you found the root cause for that issue, just a wrong spell.. 👍

@AllenFang
Here's a codepen:
http://codepen.io/Varak/pen/egVzWz?editors=0010
As you can see, the sort order isn't changed anywhere in the codepen yet when the component rerenders (just move the mouse over it multiple times), the sort field and sort order array are reversed each time.

Released on v2.11.0, thanks your contribution !!

Thank you! :)


run train.py error undefined symbol

When I run tools/train.py, I got this:
ImportError: /data3/home_jinlukang/detection/mmdetection/mmdet/ops/dcn/deform_conv_cuda.cpython-36m-x86_64-linux-gnu.so: undefined symbol: __cudaPopCallConfiguration
Here is the env:
nvcc -V == 9.0
torch.__version__=='1.1.0
torch.version.cuda==9.0
Can somebody help me?

Hi @jinlukang1 ,
Please refer this issue https://github.com/open-mmlab/mmdetection/issues/66
We would appreciate if you could use the “Error report” issue template.


init the solution to get cognito tokens

Changes
added ability to get tokens from cognito
Known Issues
no issues

This looks fine to me on first glance.
Any reason it is closed?


feature request: integration of group chats

(again... love your work so far, slightly sorry for opening this)
The current version allows the bot to be added to group chats, but responds with "access denied" to all users not individually added to the config.
It would be nice to be able to add group IDs. (since my few friends do not know what their id is and are not inclined to find out and/or tell)
Since groups usually contain non-bot related chats, it would also be nice if within those groups it would only react to a specific /something or @bot message, instead of reacting to every potentially unrelated message.
If this is already on your agenda, or has been ignored for some reason, I apologize.

Works in our new update.


Update example page for v1.3.0

without styles...

Codecov Report

Merging #21 (eb4ebc6) into main (647b430) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          126       126
  Branches        36        36
=========================================
  Hits           126       126

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support for more datasets

Hello, I really like your awesome work!
It seems that the released codes contain only the part for Moving MNIST. Could you please share more codes (like dataset.py and training arguments for TaxiBJ) which are certain to be helpful for me to reproduce you results?
Thanks for your help!

Thank you for your appreciation of our work. Regarding TaxiBJ:
0.Download the original dataset from here: https://gitee.com/arislee/taxi-bj
1.For the preprocessing, please refer to https://github.com/Yunbo426/MIM/blob/master/src/data_provider/taxibj.py.
2.Key training configurations are as follows:
patch_size = 4
depths = 12
heads_number = [8]
window_size = 8
drop_rate = 0.
attn_drop_rate = 0.
drop_path_rate = 0.1
batch_size = 4
lr = 1e-4

Great! And I would really appreaciate it if you could share training configs for Human3.6M and KTH. BTW, how many epochs should I train SwinLSTM for the four datasets mentioned in the paper?
Thanks!

Great! And I would really appreaciate it if you could share training configs for Human3.6M and KTH. BTW, how many epochs should I train SwinLSTM for the four datasets mentioned in the paper?
Thanks!

hi~bro, did you attempt  to run TaxiBJ dataset, i noticed if patch_size==4, the input will be downsample 4 times, but PatchInflated only upsample 2 times for input, this will meet an error, do you meet this qusetion? Thanks very much.

Great! And I would really appreaciate it if you could share training configs for Human3.6M and KTH. BTW, how many epochs should I train SwinLSTM for the four datasets mentioned in the paper?
Thanks!

hi~bro, did you attempt to run TaxiBJ dataset, i noticed if patch_size==4, the input will be downsample 4 times, but PatchInflated only upsample 2 times for input, this will meet an error, do you meet this qusetion? Thanks very much.

Hello! In fact, I did meet the same problem, so I just fix it myself by modifying the transposed convolution used in the PatchInflated function. I think the upsample scale should be dependent on the patchsize.

Hi, here are the more details regarding the training configuration and the PatchInflated layer:
0. Human3.6m:
patch_size = 2
depths = 12
heads_number = [8]
window_size = 4
drop_rate = 0.05
attn_drop_rate = 0.
drop_path_rate = 0.1
batch_size = 8

KTH:
patch_size = 4
depths = 6
heads_number = [8]
window_size = 4
drop_rate = 0.
attn_drop_rate = 0.
drop_path_rate = 0.1
batch_size = 8
Suggested epoch numbers for four datasets:
MMNIST: 2000
Human3.6m: 100
KTH: 100
TaxiBJ: 100
For the PatchInflated Layer:
With patch_size set to 4, add an extra layer of transposed convolution in PatchInflated. For larger values, continue adding layers as needed. The code is as follows:
self.Conv_ = nn.Sequential(
nn.ConvTranspose2d(in_channels=embed_dim, out_channels=embed_dim, kernel_size=(3, 3), stride=stride, padding=padding, output_padding=output_padding),
nn.GroupNorm(16, embed_dim),
nn.LeakyReLU(0.2, inplace=True)
)

Hi, here are the more details regarding the training configuration and the PatchInflated layer:
0. Human3.6m:
patch_size = 2
depths = 12
heads_number = [8]
window_size = 4
drop_rate = 0.05
attn_drop_rate = 0.
drop_path_rate = 0.1
batch_size = 8
1.KTH:
patch_size = 4
depths = 6
heads_number = [8]
window_size = 4
drop_rate = 0.
attn_drop_rate = 0.
drop_path_rate = 0.1
batch_size = 8
2.Suggested epoch numbers for four datasets:
MMNIST: 2000
Human3.6m: 100
KTH: 100
TaxiBJ: 100
3.For the PatchInflated Layer:
With patch_size set to 4, add an extra layer of transposed convolution in PatchInflated. For larger values, continue adding layers as needed. The code is as follows:
self.Conv_ = nn.Sequential(
nn.ConvTranspose2d(in_channels=embed_dim, out_channels=embed_dim, kernel_size=(3, 3), stride=stride, padding=padding, output_padding=output_padding),
nn.GroupNorm(16, embed_dim),
nn.LeakyReLU(0.2, inplace=True)
)


Data Module Adapter for Anomalylib

Hi @yangchenyun, thanks for your contribution. Can you add a description to your PR?

PR with wrong commits, sorry.
I will reopen a new one with relevant changes to upstream.

no worries, thanks


Extra event incorrectly triggered

Clicking on Button 1 causes both onButton1Click() and onButton2Click() to be triggered. Only onButton1Click() should be called if Button 1 is clicked. Interestingly, setting the key on the div containing Button 2 prevents this issue from happening.
Same code works as expected with React and testing indicates that the issue was introduced in Preact 5.x.
Here's a demo of the issue on jsfiddle.
import { Component, render } from "preact";

class App extends Component {
  constructor(props) {
    super();

    this.state = {
      showSection: true
    };
  }

  render() {
    const section = (

Button 1

    );

    return (

        {this.state.showSection && section}

Button 2

    );
  }

  onButton1Click = () => {
    console.log("button 1 click");
    this.setState({ showSection: false });
  };

  onButton2Click = () => {
    console.log("button 2 click");
  };
}

render(<App />, document.getElementById("root"));

I haven't fully finished looking into this, but if it's recycling-related, there's no recycling whatsoever in the upcoming major update. Let's hope this goes away then!

This issue seems to be caused by the recycler that was present in the 8.x release line. We completely removed the recycler for our next version and bugs like this should be a thing of the past :+1:

Tested this on Preact 10 alpha0, and it's still happening.
https://codesandbox.io/s/vj1p70kz4y

This is caused by microtasks being flushed between event propagation.
My understanding of the flow:

click event is dispatched at target Button 1
click handler is invoked on Button 1
setState() in handler enqueues rendering, which is implemented as a Promise.then()
click handler returns, and event propagation kicks in
event propagation flushes Promise tasks between each Node, so the enqueued render happens synchronously before propagation can continue
the synchronous render mutates the DOM tree in-place, resulting in Button 1 becoming Button 2, with the new event handler now set as a click listener.
rendering completes, and propagation picks up, moving to the next event handler which is now the newly-installed one.

@developit I have been reasoning about this quite a while, don't we also impose setTimeout in our hooks flushing? Losing Promise.resolve for setTimeout would allow these two more or am I mistaking here?

@JoviDeCroock IIRC setTimeout is used to obtain an "after frame callback". It's possible we'd want to keep an eye on that, and if folks are hitting timer clamping we could switch the hook implementation back to MessageChannel.

This seems to be resolved in the beta.0 release, if this pops up again feel free to reopen this issue.


feat: Add customizations to timeseries

Added optional markers to Start, End and Mid Points (circle, square, triangle-up and triangle-down)
Allowed functionality to disable the line (to switch between Scatter and Line+Scatter Plots)
Added the option for recognize NA / NULL in the value array (y-values) and remove that associated x-y-value from the data. This avoids an automatically inserted step that would "drag the line plot to zero, or add a marker" at that particular position.
Added the option to configure a custom range for both axis independent of the data ranges. This allows for fixed-scale axis for multiple tasks.
Added the option to hide the axis (incl. ticks and marks).
Added the width of the brush (selected portion of a plot), to the bottom right corner of the tracker (vertical cursor line).

closing in favour of #887


[EventHubs] merge working websocket changes to feature branch

follow-up of #24410

removed pyamqp test folder, b/c websocket tests are already in test_send.py
test pipeline run here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1568000&view=results

API change check for azure-eventhub
API changes have been detected in azure-eventhub. You can review API changes here


Zero width chars not showing in diff

🐛 Bug Report
Differences in strings containing zero width chars are not highlighted, making them incredibly hard to spot and debug. Eg, one of the following strings has as its first character (character at position 0) a byte order mark character as its first character, and the other has the letter "T" as its first character.

Additional useful info

UTF-16 spec on Byte Order Mark character (scroll to end of page). Its hex code is FEFF, or 65279 in decimal.
Related issues: #8448, #6881

To Reproduce
Just create two strings that look identical, one of which contains a character such as the BOM character.
Expected behavior
A clear indication of the difference.
envinfo

  System:
    OS: Linux 5.4 Ubuntu 18.04.5 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
  Binaries:
    Node: 14.4.0 - ~/.nvm/versions/node/v14.4.0/bin/node
    Yarn: 1.21.1 - /usr/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.4.0/bin/npm
  npmPackages:
    jest: ^26.0.1 => 26.0.1

hey can I work on this issue

@devil-cyber sure, thanks!

Can you please explain a bit how to get satrted
On Tue, Oct 6, 2020, 4:27 PM Simen Bekkhus<EMAIL_ADDRESS>wrote:

@devil-cyber https://github.com/devil-cyber sure, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/jest/issues/10584#issuecomment-704191431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPIV6SRF6YBAJ7PXUA6NDLSJLZZ7ANCNFSM4SD3APZA
.

This is really @pedrottimark's domain, but it should be somewhere in https://github.com/facebook/jest/tree/5da90b58eb6673e6f406f9ebc369b1f0fb747384/packages/jest-diff. Maybe @jeysal could provide some more details?

Ok
On Tue, Oct 6, 2020, 5:00 PM Simen Bekkhus<EMAIL_ADDRESS>wrote:

This is really @pedrottimark https://github.com/pedrottimark's domain,
but it should be somewhere in
https://github.com/facebook/jest/tree/5da90b58eb6673e6f406f9ebc369b1f0fb747384/packages/jest-diff.
Maybe @jeysal https://github.com/jeysal could provide some more details?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/jest/issues/10584#issuecomment-704206685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPIV6RNGEGSFLYBHMN4X6LSJL5T5ANCNFSM4SD3APZA
.

I would expect most of the changes to be in pretty-format more likely than jest-diff.
We want to serialize a string starting with certain characters in a different way.
There should probably be a brief discussion on how exactly this should be visualized, ideally with input from @aryzing as well.
Maybe "\uFEFFbla", but then how do we distinguish it from a string actually containing those characters (afaik backslashes are not an escape character in formatted strings)? Maybe move it before the "?

Ok
On Tue, Oct 6, 2020, 5:06 PM Tim Seckinger<EMAIL_ADDRESS>wrote:

I would expect most of the changes to be in pretty-format more likely
than jest-diff.
We want to serialize a string starting with certain characters in a
different way.
There should probably be a brief discussion on how exactly this should be
visualized, ideally with input from @aryzing https://github.com/aryzing
as well.
Maybe "\uFEFFbla", but then how do we distinguish it from a string
actually containing those characters (afaik backslashes are not an escape
character in formatted strings)? Maybe move it before the "?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/jest/issues/10584#issuecomment-704209663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPIV6URBXMS6UGEMQXIOIDSJL6MXANCNFSM4SD3APZA
.

@jeysal on my side no strong preferences on display, just thought I'd bring this up as it might trip up others in the future. Perhaps there's appetite for visually separating parts of the string corresponding to invisible characters or whitespace characters other than the typical whitespace you get with the spacebar.
Maybe (fyi, 00A0 is no-break space)
Expected: "Rest of string"
Received: \uFEFF + "Rest of" + \u00A0 + "string"

Like I said, no strong feelings either way, I'm sure that any reasonable indication of the presence of such characters will be fine.

Believe this isn't resolved yet, is it?

I would like to create a PR.
It is difficult for me to modify the pretty-format to make the zero-width space visible. I am also concerned about the performance impact.
It would be simpler to implement if the specification were that if the test fails, the zero-width space, if present, would indicate the position at which it first appeared. This would also be beneficial to some extent. The performance impact would be minimal.

I was just thinking about a solution for the issue.
Sorry I couldn't declare it before working on it.
I will try to create a PR as well.
I thought https://github.com/facebook/jest/pull/13997 was a very good approach.
I thought the issue was that simply replacing a zero-width space with a no-break space makes it difficult to recognize that it is a zero-width space.
Also, there are multiple zero-width spaces other than FEFF, so I think this needs to be detected as well.
I took the approach of using Note to tell that a zero-width space exists. The disadvantages of this approach are that it is difficult to visually see where the zero-width space exists and that it is impossible to detect when there are multiple zero-width spaces.
I hope my PR will be of help and reference for a good solution.


Branches give compile errors

I tried to clone and builld the following branches:

single-threaded
bands
rayon
All of those branches using 'cargo build' give compile errors.

I am working on updates to all published branches. The updates will depend on PR #16.


Support for Relay

Is your feature request related to a problem? Please describe:

Support for the Yolink Relay device
Describe the solution you'd like:

I would like the ability to remotely control my pool pump via contact closure switches
Describe alternatives you've considered:

Additional context:

Great plugin!   I’ve been looking for homekit support for yolink for some time.

I need to see the logs... if the relay is not recognized then it will be reported in the log with a statement that the device is unsupported.  And then accompanying useful information in JSON format.  You should see this during initialization and maybe also whenever the device reports status (so, e.g. if you manually turn the really on/off then that may cause a message to log that the plugin received something it does not know about).
Thanks
David

My mistake - it shows up as a switch.  I didn’t see it in the documentation so I assume it was not supported.

Thanks for testing.  Next time I am in the readme, I'll add it to the list.


unsatisfiable classes after last uberon release

The build is failing because three classes are unsatisfiable:

This is the reason:

In essence, the problem is that you cant be at the same time part of the nervous and the skeletal system; which you are  if you are a hair cell (nervous system.. sounds weird) and chochlea (skeletal system).

Dont know how to fix but needs to to resume the build.

Maybe related? Maybe not. https://github.com/obophenotype/uberon/issues/1905

Thanks Nico! I'll look into it.

Yes, this relates to the inference review where we objected to the inference that the cochlear hair cells were under skeletal system. Our assumption was that this was an issue with Uberon but I guess what ever fix they did made things worse?

Not sure. No content work for me :D

Checking the eqs for these, they all follow the pattern
'has part' some
(absent
and ('characteristic of' some
('sensory hair cell'
and ('part of' some cochlea)))
and ('has modifier' some abnormal))
Guessing it is the ('part of' some cochlea) that is breaking things.
I'm removing the and ('part of' some cochlea)
Also changed sensory hair cell to auditory hair cell as that is a better term.

That fixed it. Branch merged.


Co-existance with PowerToys

What feature or improvement do you think would benefit Files?
PowerToys offer various beneficial tools, some integrated with Windows Explorer. Most work fine with Files as well, however few may collide, namely:

thumbnail preview and "normal" (Alt-P) preview.
Peak: PowerToys offers file peak preview with CTRL-Space shortcut. This is very similar to MacOS CMD-Space preview, which is great

==> it would be good if PowerToys could be used with Files efficiently.
Requirements

thumbnail preview integration with PowerToys
normal" (Alt-P) preview integration with PowerToys
PowerToys Peak integration with Files

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3636
Comments
Great work!

Thanks for the feedback, Peek doesn't have an API to allow Files to use it. This is being tracked here https://github.com/microsoft/PowerToys/issues/26422
Thumbnail preview that PowerToys adds also work in Files
Files has a preview pane via the toolbar button.


Allow to override the ViewPathFormat in ViewViewComponentsResults

Please allow changing the ViewPathFormat.

Can you give us more detail about what you're trying to accomplish?

In mvc5 ik have als controller like LoginController
In my lay-out I have @Html.Action ("login","login") this will render a partial login view which contains a login form with Ajax postback. So when the user signs in it post it's data to the login controller. And returns a partial view.
I think you know what I mean.
In vnext html.action is replaced with view components however I can figure out how to achieve this.
So I tried a view components to point to the login view to render te login form. Then I noticed that the view components always adds components to the view location

You can fully qualify the view path by prefixing the path with ~/. Does that meet your needs?

Closing for now, but let us know if the current behavior is insufficient.


Change CLI main command to arbitrary name

Thanks a lot for this package! We are implementing in our SDK docs and it's working great.
We have, however, a small issue that we believe you could help with. In the setup.py in our package we use:
entry_points="""
        [console_scripts]
        up42=up42.cli:main
    """

Which means that the main function of the up42/cli.py script is used as the entry point for the click CLI, but the main name gets replaced with the up42 name, so that you can call up42 authenticate instead of main authenticate. In the generated docs with mkdocs-click we see the main name instead, which can be confusing for users.
It would be great if we could somehow in the mkdocs-click setup add an entry_point, i.e.:
::: mkdocs-click
    :module: up42.cli
    :command: main
    :entry_point: up42
    :depth: 2

And then in the generated docs all the main references would be replaced with up42.
I believe this could be quite useful since a number of click CLIs are using mechanisms similar to this. Happy to hear any alternative suggestions/comments/questions you have!

👋 @rodrigoalmeida94 I think you would just need to rename your main function to up42.

Hey @AdrienFromToulouse ! Quite right, talk about missing the simplest solution... Thanks for the help!


Sync published with master

Sync the 'published' repo with  updates from 'master'

Deploy preview for docsdocker ready!
Built with commit 35fb5ad9ae5d0bd6ff20d9ca67bbddff21eeb1bf
https://deploy-preview-9182--docsdocker.netlify.com

lgtm. @usha-mandya qq: what does toc_min and toc_max do?

Thanks @Dawn. It only displays H1 and H2s on the mini toc on the right-hand side.


Tutorial bug: backend yarn install failure

Successfully followed tutorial up to here:

running Ubuntu on WSL on HP laptop:

Warning with yarn install then command not found:

red cross after running yarn explain command:

Any suggestions?
Kind regards
Mark

Hi @MarkCatch, thanks for raising the issue.
I'm still running yarn version 1.22.22, which works for me. Could you try it with that?

OK thanks for the prompt response.
I switched to 1.22.22 as you suggested and made progress. I now have two consoles running frontend and backend

But opening the browser doesn't look right?:

Mh, that looks like the activitypods server is down. Did you run make start in the root directory?
Remember to run make stop again later, as it's consuming quite some RAM :)

OK I restarted Pod provider, backend and frontend and hey presto:

Thanks for the support

Feel free to close

@MarkCatch Great to see it works !
If you run into other issues, feel free to open another issue, or post on our Matrix space.


Updated broken link + added new data science resource

The link to the resource "learn python" was no longer working so I updated it. I added a new educational link to DataCamp's free interactive coding tutorial for python.

Thanks @martijnsublime!


Vry starting error. tried 5 times (log report)

[2023.09.29-18.59.19] got region from logs '['ap', ['ap-1', 'ap']]'
[2023.09.29-18.59.19] Api urls: pd_url: 'https://pd.ap.a.pvp.net', glz_url: 'https://glz-ap-1.ap.a.pvp.net'
[2023.09.29-18.59.19] opened lockfile
[2023.09.29-18.59.19] got version from logs 'release-07.06-shipping-4-983570'
[2023.09.29-18.59.49] Traceback (most recent call last):
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connection.py", line 203, in _new_conn
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\util\connection.py", line 85, in create_connection
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\util\connection.py", line 73, in create_connection
TimeoutError: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connectionpool.py", line 790, in urlopen
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connectionpool.py", line 491, in _make_request
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connectionpool.py", line 467, in _make_request
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connectionpool.py", line 1092, in _validate_conn
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connection.py", line 611, in connect
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connection.py", line 212, in _new_conn
urllib3.exceptions.ConnectTimeoutError: (<urllib3.connection.HTTPSConnection object at 0x0000020329354F10>, 'Connection to raw.githubusercontent.com timed out. (connect timeout=None)')
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\adapters.py", line 486, in send
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\connectionpool.py", line 844, in urlopen
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\urllib3\util\retry.py", line 515, in increment
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /zayKenyon/VALORANT-rank-yoinker/main/status.json (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x0000020329354F10>, 'Connection to raw.githubusercontent.com timed out. (connect timeout=None)'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 99, in
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\src\requestsV.py", line 68, in check_status
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\api.py", line 73, in get
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\api.py", line 59, in request
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\sessions.py", line 589, in request
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\sessions.py", line 703, in send
File "C:\Users\isaac\Documents\GitHub\VALORANT-rank-yoinker\venv\Lib\site-packages\requests\adapters.py", line 507, in send
requests.exceptions.ConnectTimeout: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /zayKenyon/VALORANT-rank-yoinker/main/status.json (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x0000020329354F10>, 'Connection to raw.githubusercontent.com timed out. (connect timeout=None)'))

Hey there! A win-error 10060 is generally due to one of these factors:

This may be because the port vRY uses is already in use (1100).
Start off by checking your firewall settings to see if it is being blocked, temporarily disabling your firewall will confirm this.
If needed, you could then try to restart: vRY, but if that doesn't fix it then VALORANT, but then if that doesn't fix it then your computer.

If you have a slower internet connection then changing the value of cooldown located in config.json to 0 (manual refresh) or to something > 1 may help.

If that doesn't work then changing the port located within the config.json file may work.


Update use-array.map-to-dynamically-render-elements.md

typo
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

I do not really see the issue here, the text tells you the programmer that there is no way of knowing how many items a user might have on their list.

It's just a simple typo detected, instead of "as the programmer" => "as a programmer"

It is both grammatically correct.

Thank you for opening this pull request.
This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Add native autocorrect, autocapitalize and spellcheck attributes to i…

Add native autocorrect, autocapitalize and spellcheck attributes to input elements to have more control over keyboard behaviour.
Add target attribute to list-item link, i.e. to allow target=“_system” with the cordova inappbrowser plugin.

Merged, thanks


Change side effect dispatch model

I didn't have much time today to flesh out my ideas, but here is a rough first draft for some of my ideas in #8. I decided to push now (with all tests failing ☺) as the changes are pretty much how I envisioned them, so we can use them as a discussion point. What's left to do is some admin stuff:

[x] Add defer/clearDefer utilities (just a setTimeout(callback, 0) abstraction)
[x] Remove unused code
[x] Tests
[ ] Readme

The PR is much appreciated!
I left few comments, these are just cosmetic things, mostly related to code style and let's discuss few problems/ideas here in the discussion.
Let me first ask a question, is the "all effects have been dispatched" hook the only purpose of this PR?
I definitely like the idea of providing the dispatch directly to enhanced reducer so that we can get rid of AppStateWithEffects, I must have been drunk while I was thinking about it. Looks like my head was too tied with the previous implementation also the idea about thinking of iterable with last element acting as app state is great. These two things should definitely get merged.
Now few problems:
Only thunks are allowed as side effects
I explained this in the comment already, we should not allow user to dispatch synchronous action. Any action dispatched via effect should be async and this means that only thunks should be acceptable. I would rather avoid dependency on redux-thunk therefore we would need to have this implementation here.
Now you might protest because I am saying that only async thunks are accepted yet we are not deferring the action execution in the current implementation but you are doing that in your PR meaning that it's better to do it your way. However, I believe that we should not explicitly defer the action execution.
Dispatched actions within effect should be naturally asynchronous otherwise it's action chaining which is wrong, user's responsibility is to met this condition, our responsibility is to verify that they are not doing that.
Action dispatched via side effect should not allow yielding another effects which dispatch another actions
In the current implementation we are ensuring the exact opposite. Few days ago I realized that this approach is actually wrong. I always kept advocating the idea that as long as the action is dispatched asynchronously it's not cascading event and it's still a valid point but the argument about single interaction entry point is much more stronger.
Therefore this is not ideal:
function* reducer(appState, action) {
  if (action === 'FOO') {
    yield dispatch => asyncWork().then(() => dispatch('BAR'));
  } else if (action === 'BAR') {
    yield dispatch => asyncWork().then(() => dispatch('BAZ'));
  }

  return appState;
}

We should instead enforce doing this:
function* reducer(appState, action) {
  if (action === 'FOO') {
    yield dispatch => {
      asyncWork()
        .then(() => dispatch('BAR'))
        .then(asyncWork)
        .then(() => dispatch('BAZ'));
    }
  }

  return appState;
}

We are obviously giving up some flexibility but this approach will make the code much more easier to reason about. Because of this invariant we'll proably have to keep the dispatch method wrapped anyway.
We can use Promise chain + middlewares
If the answer for my question is yes, then I believe we can implement it with less intrusive implementation which will use promise chain and middleware. Bottom line: we can definitely use some parts of your code but let me first do some proof of concept with less intrusive implementation.

There were a couple goals of this PR: reduce surface area (only wrap a single function), remove AppStateWithEffects, allow the dispatch of anything (🙃), and expose the dispatch results.
I think just because we think a user shouldn't do something, that doesn't mean we should enforce it. There might be some who argue side effects in a reducer should never be done, but because it can be done we can experiment with different styles. This applies to two things.
First is the anything-dispatching. I don't think I completely understand the technical limitation keeping us from allowing it. Technically all actions (whether thunked or not) are dispatched, and what is the real benefit of yield dispatch => dispatch('FOO') over yield 'FOO'?
I mainly want this because I have some custom middleware which responds to promises, so writing yield Promise.resolve('FOO') is a nice syntactic thing.
Second, I completely agree that effects shouldn't have effects, but I don't think we should enforce that. Once an action is dispatched it would be weird to (externally or internally) keep some metadata on it disallowing further effect propagation. Once an effect is dispatched it should behave like any other action. In some systems this also might be useful.
Finally, I'll have to see your promise chain implementation. My initial reaction is that I'm not sure I like it. Adding promises kinda removes the purity of the implementation. I am curious about the "+ middleware" part though.

@calebmer

There were a couple goals of this PR: reduce surface area (only wrap a single function), remove AppStateWithEffects, allow the dispatch of anything (🙃), and expose the dispatch results.

Excellent! I agree with:

reduce surface area - though I am not sure whether we manage to wrap just single function
remove AppStateWithEffects
expose dispatch results

I think just because we think a user shouldn't do something, that doesn't mean we should enforce it. There might be some who argue side effects in a reducer should never be done, but because it can be done we can experiment with different styles. This applies to two things.

Yes and No. Just keep in mind that even when using redux-side-effects we are not breaking the premise of pure reducers with no side effects. We are effectively getting rid of this very important condition. So even in original createStore in Redux this is something banned.

First is the anything-dispatching. I don't think I completely understand the technical limitation keeping us from allowing it. Technically all actions (whether thunked or not) are dispatched, and what is the real benefit of yield dispatch => dispatch('FOO') over yield 'FOO'?

All I wanted to say is that either yield dispatch => dispatch('FOO') or yield 'FOO' is wrong because this is something called action cascading which has always been banned and we should not break it. First time I was working with Flux It didn't took me a long till I realized that action chaining is evil and everything becomes quite tangled. I try to think about actions as Events now and everything is much more easier to reason about. I believe the well known exception "Cannot dispatch in the middle of dispatch" helped dozens of people with proper Flux architecture.

I mainly want this because I have some custom middleware which responds to promises, so writing yield Promise.resolve('FOO') is a nice syntactic thing.

Agreed, I might have not expressed myself clear enough. It should not be allowed to dispatch sync action in effect. Promise is by nature async therefore it makes sense to accept either thunk or Promise

Second, I completely agree that effects shouldn't have effects, but I don't think we should enforce that. Once an action is dispatched it would be weird to (externally or internally) keep some metadata on it disallowing further effect propagation. Once an effect is dispatched it should behave like any other action. In some systems this also might be useful.

To advocate this it would require probably whole blog post, for starters, it may be useful to at least log some warning that it's not ideal to cascade async actions.

Finally, I'll have to see your promise chain implementation. My initial reaction is that I'm not sure I like it. Adding promises kinda removes the purity of the implementation. I am curious about the "+ middleware" part though.

Here it is

Either yield dispatch => dispatch('FOO') or yield 'FOO' is wrong because this is something called action cascading which has always been banned and we should not break it.

Ok, I get it now. However, I still believe in dispatching whatever is yielded for the middleware reason I stated above. A warning/error when yielding a plain object is totally understandable though.

I think development warnings are a good idea to solve some of the pattern breaking issues (plain object dispatch & effect effects) but I don't think we should limit technical capabilities.

Ok, the code is ready to merge except for README information and I haven't changed some of the things you mentioned as I'm a bit confused on what you want, I'll ask for clarification where necessary. Also changed is that if you take a look at https://github.com/salsita/redux-side-effects/commit/3d94095f6888c4b2db4a412d73a3b4bb2961b132, I think that's a much better solution then what I had before or the proposed change in #10. It's a very clean API and gives the user control of the deference mechanism.
Points of contention that are still included in this PR are:

Dispatch of whatever gets yielded (requires redux-thunk for current functionality).
Side effects can't have effects.

I'm willing to put error messages in development for both of these, however I think it best if we leave the capability to do these things even if they aren't best practice (for extensibility purposes).
Finally, to tie a nice bow on this PR do you want to rename createEffectCapableStore here or in another PR? My vote is for applyEffectCapability or applyEffectCapabilities. I think making it a function similar to applyMiddleware in allowing it to take a config option could be helpful if that helps to relate the two names (one config option could be never deferring the dispatch of effects forcing the developer to call dispatchEffects whenever they wanted the effects to be run).

Ok, added the warnings for anti patterns for discussion.

Thanks @calebmer, will merge the code in temp branch. There are few things I want to polish. For example I would like to get rid of Task class completely.

Ok, sounds great 😊

Hello @calebmer,
sorry it took me so long but I would like to revive the discussion. We've had some issues trying to solve how everything fits into a larger application and we would really like to see this PR merged, however I'd rather avoid over-engineering stuff. There have also been many changes in the overall architecture decisions which come up from redux-elm
I have incorporated some of your ideas and tried to implement something simple and here's the starting point https://github.com/salsita/redux-side-effects/commit/875ddc6be25977619cf76d7d6b17bbbac98f6aa9
Could you please have a look whether this kind of change makes sense for you? We'd need somehow expose dispatchEffects function to exactly match interface that you'v proposed but I have an idea.

Hey, long time no see :blush: I've actually come full circle too, especially after seeing this proposal.
I've moved on to another project since this PR, but I'm looking for a chance to try it again soon. That said, it took me a bit to get back in the mindset. The code in 875ddc6 looks great, much cleaner than what this PR ended up becoming.
As for dispatchEffects, I'm going to leave a comment on the commit to throw my 2 cents in on how I'd implement dispatchEffects.
So at this point, should we start thinking about closing this PR in favor of the next branch?

If there's any other way I could help, please let me know :blush:

Continuations with Effect Handlers is a nice idea, yet I am afraid that major drawback of the solution is that propagation of side effects is not explicit. It works like try/catch you can basically throw an error deeper in the hierarchy and exception automatically propagates up until it reaches first catch block, which is not explicit and is a bit difficult to reason about.
Thanks for your help @calebmer closing in favor of next


ODS > Component > Edit Text

Edit Text
Requirement
As a developer
I want to insert a editable text
So That I will get this ready to use component compatible with Orange design specifications and a11y requirements
DSM staging reference
General description
Component
For the component description please refer to the DSM updates
App Page
the page will propose to the user to describe the component and allow to see the implementation in action.
UI specifications
Anatomy
Component
For the component description please refer to the DSM updates
App Page

title: "Edit Text"
image: xxx.jpg
Text: intro text in the DSM
Core field: And example of a text field where the user can select the existing text and view the prompt color setup.

Variants

NA

States

NA

Internationalization

NA

UX specifications
Interaction

All:

The user is able to select a text using the default OS behavior

Touch:

Nothing Specific

Keyboard:

Nothing specific

Animations

default OS animation

Accessibility
Visual Accessibility

taken into account within the design creation process

Usage Accessibility

(?) Focus order - NA
(?) Focus loss expected behavior - NA
(?) Screen Reader - default OS behavior
(?) Switch Control

Technical specifications
Implementation tasks

[ ] Task 1
[ ] Task 2

Related tasks

[ ] Task 1
[ ] Task 2

This  one was done during sprint 9


selectlist btn-block and data-resize="auto"

the dropdown is wonky and not correctly located when used with btn-block. The dropdown should be
sized and located the same as the combobox.

      Selects

        <button class="btn btn-default btn-block dropdown-toggle" data-toggle="dropdown" type="button">

        </button>

1

2

3

4

5

        <input class="hidden hidden-field" name="mySelectlist" readonly="readonly" type="text"/>

This is probably something to do with the data-resize="auto". the menu is being resized based on the text, but it looks like you have sized the button to fill the space ("block style"). You could try removing data-resize="auto" and seeing if you are happy. @Alondite00 is looking into it.

We may want to call data-resize="auto" something like data-resize="menu-content" or something, since auto isn't very specific. Auto what?

What's causing that wonky css is the column class directly on the selectlist.  The selectlist automatically resizes to the size of the content.  Try this:

            Select List Goes Ya:

                <button class="btn btn-default btn-block dropdown-toggle" data-toggle="dropdown" style="width:100%;" type="button">

                </button>

alpha one five nine two

1

alpha one five nine two

alpha one five nine two

alpha one five nine two

                <input class="hidden hidden-field" name="mySelectlist" readonly="readonly" type="text"/>

@dexwerx Please use a wrapper div to create columns. I'm closing unless you have any issues going down the path with a wrapper div. Feel free to re-open if this markup doesn't work. Thanks!


FreeBSD recognized as Linux

echo '<IP_ADDRESS> - - [23/Mar/2021:04:01:15 +0100] "GET example.com HTTP/2.0" 200 3606 "https://duckduckgo.com/" "Mozilla/5.0 (X11; FreeBSD amd64; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.182 Safari/537.36"' | goaccess --log-format='COMBINED'

navigate to 6 - Operating Systems, it shows Linux, the expected value would have been FreeBSD

Thanks for reporting this. Can I ask, do you know why it shows Linux?

This should be fixed upstream and will be deployed in the upcoming version. Thanks again!


Bad publish, I think? There is a merge conflict in the dist

I deleted node_modules and installed again and still getting this. Also cleared caches and installed.
Pretty sure you published a merge conflict (the conflict is on npm only, not on here).
ERROR in ./node_modules/validatorjs/dist/validator.js
Module build failed (from ./node_modules/ember-auto-import/node_modules/babel-loader/lib/index.js):
SyntaxError: /home/robbo/Code/postedin/app/node_modules/validatorjs/dist/validator.js: Unexpected token (1:0)

> 1 | <<<<<<< HEAD
    | ^
  2 | /*! validatorjs - 2019-12-24 */
  3 | =======
  4 | /*! validatorjs - v3.17.0 -  - 2020-08-18 */

Went down to 3.19.0 and same issue. Working again on 3.18.x.

Hey Rob
This is quite curious?  I  have done clean installs locally and all is working as expected.  How are you including with your project?
Using the typically require, all works fine?

I went into a new directory, did yarn cache clean; yarn add validatorjs and then did vim node_modules/validatorjs/dist/validator.js and see the code pasted above.

Give me a moment here and I will try again using yarn. I am using npm.

I just did the same process with npm, same thing.

@robclancy OK, I have been able to track down and clear the issue.  Quite a bizarre issue, but all is good now.
If you could please give it a quick check, I would appreciate it.

Yep all is good now, thanks.


ui: onroad e2e long toggle

WIP, just to see what it's like onroad. Includes code from https://github.com/commaai/openpilot/pull/26346

Closing to preserve history https://github.com/commaai/openpilot/pull/26405


Added missing node_modules-directory

Obviously every second project that prides itself of being one of the best ones contains a fat node_modules directory where nearly the whole internet gets copied into. However, since we don't need any code, it should stay empty all the time.

once you provided empty node_modules, you have to provide packages.json

You're right! Give me a second

Done.

Which? dependencies are empty

We don't need any dependencies here.

@rnelson0 the package.json-file contains no code, only structured data.

I think it's best to add a no_modules folder

with noxx_modules, you mean?


Update Heroku

[ ] Update Heroku app to match current codebase
[ ] Test if we can link the url from Heroku
[x] Gather invoices and get reimbursement and/or transfer payment to the university

Heroku paid through June. Planning to switch to AWS after June


Security issue through demos, unable people to browse/read the system files

you can play with system path using /demos/
eg: HTTP POST to https://rtcmulticonnection.herokuapp.com/demos/../../../../../../../../etc/passwd
this read file read ac should be activity should be handled properly only allowing read/include file from certain path only

Use http post, not get

@muaz-khan how about doing path sanitization and set default directory?
therefore the URI cannot be used to try to access anything outside the default dir?

Something like this? E.g. uri.index('../') !== -1
function serverHandler(request, response) {
    var uri = url.parse(request.url).pathname,
        filename = path.join(process.cwd(), uri);

    if (request.method !== 'GET' || uri.index('../') !== -1) {
        response.writeHead(401, {
            'Content-Type': 'text/plain'
        });
        response.write('401 Unauthorized: ' + path.join('/', uri) + '\n');
        response.end();
        return;
    }
});

still open
https://rtcmulticonnection.herokuapp.com:443/../../../../etc/passwd

i suggest to set default directory and working on that directory only, not allowed to go out
var rootDirectory = '/path/to/working/directory';
if (request.method !== 'GET' || path.join('/', uri).indexOf('../') !== -1) {
response.writeHead(401, {
'Content-Type': 'text/plain'
});
response.write('401 Unauthorized: ' + path.join('/', uri) + '\n');
response.end();
return;
}
    // additional checking
    if (filename.indexOf('\0') !== -1) {
        response.writeHead(401, {
            'Content-Type': 'text/plain'
        });
        response.write('401 Peekabooo :p :p :p :p 0 \n');
        response.end();
        return;
    }

    if (filename.indexOf(rootDirectory) !== 0) {
        response.writeHead(401, {
            'Content-Type': 'text/plain'
        });
        response.write('401 Peekabooo :p :p RD  \n');
        response.end();
        return;
    }

// end of additional checking
... sorry for the ugly code, i'm not a javascript developer :p

It's still open !


add REPL and set HTTP compat to avoid 1.0

Compile Times benchmark
Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:
using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

using
create
display
create
display

GLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

CairoMakie
14.73s (10.94, 32.74) 7.97+-
30.19s (22.51, 67.64) 16.57+-
4.42s (3.27, 9.91) 2.43+-
24.13ms (18.07, 53.83) 13.12+-
30.02ms (21.99, 69.83) 17.60+-

master
11.19s (10.91, 12.12) 0.46+-
23.10s (22.31, 25.62) 1.16+-
3.42s (3.29, 3.88) 0.21+-
19.05ms (18.00, 20.86) 1.03+-
22.62ms (21.64, 24.32) 1.16+-

evaluation
+24.02%, 3.54s noisy🤷♀ (0.63d, 0.29p, 4.21std)
+23.50%, 7.09s noisy🤷♀ (0.60d, 0.30p, 8.87std)
+22.57%, 1.0s noisy🤷♀ (0.58d, 0.32p, 1.32std)
+21.06%, 5.08ms noisy🤷♀ (0.55d, 0.35p, 7.08std)
+24.65%, 7.4ms noisy🤷♀ (0.59d, 0.31p, 9.38std)

WGLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–


Merge prTesting_202004211920 branch to master branch

Docs Build status updates of commit 512c88a:
:clock10: Pending: waiting for processors (10 builds ahead of you)
:warning: Docs Build is busy, currently there are 10 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 512c88a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestRef.md
:warning:Warning

Details

split/updateTestRef.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 1: [Suggestion] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning on 04/01/2020.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: add a simple proxy mempool

add some very basic proxy mempool that wrap a real mempool and handles the calls to its functions.
This is only a POC

This change is

Codecov Report
Attention: Patch coverage is 84.21053% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 70.07%. Comparing base (7b06d43) to head (5c62995).

Files
Patch %
Lines

crates/mempool_node/src/proxy_mempool.rs
79.31%
3 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   64.64%   70.07%   +5.42%
==========================================
  Files           5        7       +2
  Lines          99      137      +38
  Branches       99      137      +38
==========================================
+ Hits           64       96      +32
- Misses         35       38       +3
- Partials        0        3       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixes error where json response code could not be set

I wasn't able to set the response code for a json response. I didn't want to force the response code at the controller level so I dug in to figure out why I couldn't set it at the the engine level.

Looks good to me! Thanks!


this.embeddings.embedDocuments is not a function

What am I doing wrong here?
import { Ollama } from "@langchain/community/llms/ollama";
import { OllamaEmbeddings } from "@langchain/community/embeddings/ollama";
import weaviate, { ApiKey } from "weaviate-ts-client";
import { WeaviateStore } from "@langchain/weaviate";

const ollama = new Ollama({
  baseUrl: "http://localhost:11434",
  model: "llama2"
});

const embeddings = new OllamaEmbeddings({
  model: "llama2",
  baseUrl: "http://localhost:11434"
});

const weaviateClient = weaviate.client({
  scheme: process.env.WEAVIATE_SCHEME || "http",
  host: process.env.WEAVIATE_HOST || "localhost",
  port: process.env.WEAVIATE_PORT || "8080",
  apiKey: new ApiKey(process.env.WEAVIATE_API_KEY || ""),
});
const documents = ["hello world", "hi there", "bye now"];
const documentEmbeddings = await embeddings.embedDocuments(documents);

console.log({ documentEmbeddings }); // Prints out the array of vectors

const results = await WeaviateStore.fromTexts( // This block errors
  documents,
  [{ foo: "bar" }, { foo: "baz" }, { foo: "bar" }],
  documentEmbeddings, // Also tried with the embeddings variable here
  {
    client: weaviateClient,
    indexName: "Test",
    textKey: "text",
    metadataKeys: ["foo"],
  }
);

console.log({ results });

Errors with:
file:///.../dist/vectorstores.js:168
        return this.addVectors(await this.embeddings.embedDocuments(documents.map((d) => d.pageContent)), documents, options);
                                                     ^

TypeError: this.embeddings.embedDocuments is not a function
    at WeaviateStore.addDocuments (file:///home/slyke/path/to/app/node_modules/@langchain/weaviate/dist/vectorstores.js:168:54)
    at WeaviateStore.fromDocuments (file:///.../dist/vectorstores.js:322:24)
    at WeaviateStore.fromTexts (file:///.../dist/vectorstores.js:310:30)
    at file:///home/slyke/path/to/app/test.js:38:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I'm looking at: https://api.js.langchain.com/classes/langchain_weaviate.WeaviateStore.html and following this example: https://js.langchain.com/docs/integrations/vectorstores/weaviate while referencing https://js.langchain.com/docs/use_cases/question_answering/local_retrieval_qa and https://js.langchain.com/docs/integrations/text_embedding/ollama
The example is not clear on how weaviateStore.fromTexts uses new OpenAIEmbeddings() since it's just imported in. I believe there needs to be some OllamaEmbeddingsInterface passed into here. Passing documentEmbeddings and embeddings both cause errors and I'm unsure how to use Ollama or OllamaEmbeddings with WeaviateStore.fromTexts.

Hey @dosubot,
I'm using the latest versions of the npm modules, just created a new project with npm init and ran all the npm installs. The OllamaEmbeddings class does have the embedDocuments function. This function returns:
{
  documentEmbeddings: [
    [
        1.1969940662384033, -0.052228473126888275,      1.546292781829834,
        // ... brevity snip
        1.4512828588485718,
      ... 3996 more items
    ],
    [
         2.5101842880249023,   -3.273963451385498, -0.14006204903125763,
        // ... brevity snip
       -0.19518393278121948, -0.40836334228515625,   -1.797864317893982,
          1.854506015777588,
      ... 3996 more items
    ],
    [
         2.894432783126831,   -2.758491039276123,  -0.43672826886177063,
        // ... brevity snip
       -0.1770072877407074,  0.12030475586652756,   -0.6426188945770264,
        1.7523319721221924,
      ... 3996 more items
    ]
  ]
}

From this line:
const documentEmbeddings = await embeddings.embedDocuments(documents);

So we can conclude that it's working.
However, when passing the object that's in the documentEmbeddings variable into WeaviateStore.fromTexts it errors with: TypeError: this.embeddings.embedDocuments is not a function.
So it seems like WeaviateStore.fromTexts does not accept the result from the OllamaEmbeddings::embedDocuments() function.

This is what I initially tried, but was getting fetch errors. When I modify the code to what you provided I get the following error:
file:///...dist/vectorstores.js:155
            throw Error(`Error adding vectors: ${e}`);
                  ^

Error: Error adding vectors: TypeError: fetch failed
    at WeaviateStore.addVectors (file:///...dist/vectorstores.js:155:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async WeaviateStore.fromDocuments (file:///...dist/vectorstores.js:322:9)
    at async file:///home/slyke/repos/llms/ollama/test.js:38:17

Node.js v20.11.0

I know that Weaviate is working correctly, because I can access it from my browser and it replies with:
{"links":[{ snipped a bunch of stuff }]}

It's also accessible with VectorAdmin, so I'm unsure why fetch is failing, as the error is not helpful.

Figured out the solution, the code you provided was correct. The issue was that weaviate.client does not accept a port parameter, so I had to append 8080 onto the host field.
const weaviateClient = weaviate.client({
  scheme: process.env.WEAVIATE_SCHEME || "http",
  host: process.env.WEAVIATE_HOST || "localhost:8080" // <--- Here
  apiKey: new ApiKey(process.env.WEAVIATE_API_KEY || ""),
});


supplement for dal grammar

Changes proposed in this pull request:

add support for account manager
add support other administrative

Pull Request Test Coverage Report for Build 450

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 65.69%

Totals

Change from base Build 414:
0.007%

Covered Lines:
9640

Relevant Lines:
14675

💛  - Coveralls


Webview - mediaPlaybackRequiresUserAction is not true by default

Description
When a web page contains a video, this video is automatically	played in full screen, even if user has no touch the web player.
Reproduction
Just create a simple project with a webview and open a site containing a video.
Solution
To fix this issue, it should define default props value for mediaPlaybackRequiresUserAction
In documentation, this props must be set to true by default but in fact, this props has not default value.
Some other props must be set to true by default but in code source i don't find this init on ios webview. (WebView.ios.js) in contrary with android webview (WebView.android.js)
 static defaultProps = {     javaScriptEnabled : true,     scalesPageToFit: true,   };
Additional Information

React Native version: 0.39.2
Platform: IOS, no test on android.
Operating System: MacOS

Thanks for any advice by advance.

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


Probot v13 Octokit calls time out when running inside Dockerised AWS Lambda

Bug Report
Current Behavior
Any octokit related call times out, tried even with 10s timeout.
It doesn't seem to be related to any rate limit and there's no specific log pointing in any direction.
const { octokit, payload } = context;
const { repository, workflow_run } = payload;
const { getWorkflowRunUsage } = octokit.rest.actions;

await getWorkflowRunUsage({
  owner: repository.owner.login,
  repo: repository.name,
  run_id: workflow_run.id,
})

Expected behavior/code
The call should resolve the promise without timing out, usually in less than 1s.
With Probot v12.4.0 works fine.
Environment

Probot version(s): v13.3.0
Node/npm version: Node v20 / pnpm v8
OS: AWS Arm64 Lambda with Docker image public.ecr.aws/lambda/nodejs:20.2<IP_ADDRESS>

Possible Solution
N/A
Additional context/Screenshots
It seems to work fine locally, but fail within Docker/AWS Lambda.
I wonder if it can be related to the changes to the fetch method or the bump to the latest version of octokit itself.

Just to make sure, the webhook handler for your event got fired, and you are making a call to the GitHub api with the information from that webhook, and That call is then timing out.
I don't see why this would suddenly change between these Probot versions.
Can you reproduce the issue if you call octokit directly in Docker without the webhooks handler?

I gave it a shot in this way, using @octokit/rest v20:
const app = async (app: Probot) => {
  const { APP_ID, PRIVATE_KEY, INSTALLATION_ID } =
    process.env;

  try {
    const octokit = new Octokit({
      authStrategy: createAppAuth,
      auth: {
        appId: APP_ID,
        privateKey: PRIVATE_KEY,
        installationId: INSTALLATION_ID,
      },
    });

    const { data } = await octokit.rest.actions.listRepoWorkflows({
      owner: "owner",
      repo: "repo",
    });

    app.log.info(`[OCTOKIT] listRepoWorkflows: ${data.total_count}`);
  } catch (err) {
    app.log.error(`[OCTOKIT] listRepoWorkflows: ${(err as Error).message}`);
  }

It's giving an error: Client network socket disconnected before secure TLS connection was established
I've tried switching @octokit/rest to v19 and still fails but with: fetch failed
Let me know if I can give you more insights 😉

Yeah, we recently switched to using the Fetch API instead of node-fetch, I'm thinking something has broken for your use case.
Can you try seeing if that helps you out?
Instructions on patching out fetch can be found here: https://github.com/node-fetch/node-fetch?tab=readme-ov-file#providing-global-access

Added it to the previous example with no success:
import "./fetch-polyfill";

const app = async (app: Probot) => {
  const { APP_ID, PRIVATE_KEY, INSTALLATION_ID } =
    process.env;
...

I've also added timeouts to all the octokit calls, inside and outside the webhooks and they all seem to suffer the same problem, using also the custom octokit and not the instance coming from Probot.

You might need to pass --disable-experimental-fetch to node as well.
Try using v2 of node-fetch instead

Hmm. in gcf i also dont get the probot app running with probot 13. Maybe it is connected.

@paolo-chiabrera
We suddenly get a string for response.status in gcf. Can you see if you have the same issue in aws?

Under NodeJS I'm seeing statuses as numbers.
The spec says that it is numbers, https://developer.mozilla.org/en-US/docs/Web/API/Response/status#value

Sorry for being late, after using --no-experimental-fetch flag for Node.js things seem to work fine with Probot v13 🎉

@wolfy1339
It is a big mystery, why the status is a string and not a number in gcf.


Project URL directs to a 404

The URL that is linked on this project's page, https://www.trufflesuite.com/ganache-ui, directs to a 404. Is there possibly another path it should be directed to?

Good catch! I've fixed that to point to https://www.trufflesuite.com/ganache


build(dependabot): ignore minor and patch github-actions updates

See https://github.com/mercurius-js/mercurius/pull/652

LGTM, could you resolve the conflicts :)

LGTM, could you resolve the conflicts :)

Sure, done!


Fire particles not appearing

Closed by https://github.com/belathus/Wanderlust-Renewed/commit/ceb7e34573f2714a4ba2e089ba789840ffaa3f59


Remove websocket close call causing infinite recursion

Call to ws.close() will immediately call the onDisconnection callback again creating an infinite recursion.  Fix is to delete redundant call to ws.close().
Fix tested in recent Debian distribution.

I'll need to do some further testing on this one...looks like it does get rid of the infinite recursion (preventing a Seg Fault at least on Mac), which allows the Disconnected message to be output, but then the program doesn't terminate on its own anymore. The infinite recursion seems to have been a crude method to get the program to end.

I didn't see any option in uWebSockets for exiting on disconnect.  Here'a a different branch that will just reset the filter on disconnect (if that's preferred).


Specifications page: make the table look like the original site

Change the specifications table to look like this (with only two columns) -- from https://in-toto.io/specs/:

rather than what it currently is:

You have given this review here in this discussion.


std.process: Enforce nothrow/@nogc in forks

Also fix erroneous usage of errnoEnforce in fork.
Needs https://github.com/dlang/druntime/pull/1571

LGTM

Auto-merge toggled on

LGTM


Vue2 Support

Is there any chance this could be extended to support Vue2?

Look like it's already supported.
https://github.com/hannoeru/vite-plugin-pages/issues/12

Yep sorry i realised this after


Terasology crashes on startup

http://pastebin.com/QEfZbz4y
Packages:
Java: Oracle-jdk-<IP_ADDRESS>
Portage <IP_ADDRESS> (python 3.4.3-final-0, default/linux/amd64/13.0/desktop/gnome/systemd, gcc-4.9.3, glibc-2.21-r1, 4.3.0 x86_64)
System uname<EMAIL_ADDRESS>KiB Mem:     8133256 total,   1200700 free
KiB Swap:    4194300 total,   4194300 free
Timestamp of repository gentoo: Thu, 19 Nov 2015 11:00:01 +0000
sh bash 4.3_p39
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p39::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.10-r1::gentoo, 3.4.3::gentoo
dev-util/cmake:           3.3.1-r1::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.17::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.9.3::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers)
sys-libs/glibc:           2.21-r1::gentoo
I don`t see an error message though, which could be related, that the game would not start.

I fixed this through installing openjdk. Maybe my Oracle-jdk-1.8 installation wasn`t compatible with Terasology

Thanks for the detailed report! Glad you could resolve it :-)
Odd issue too.

Unfortunately Java wasn't the issue. Xrandr wasn't installed. Maybe it's
possible to edit the script to check for dependencies?
Am 19.11.2015 4:52 PM schrieb "Rasmus Praestholm"<EMAIL_ADDRESS>
:

Thanks for the detailed report! Glad you could resolve it :-)
Odd issue too.
—
Reply to this email directly or view it on GitHub
https://github.com/MovingBlocks/Terasology/issues/2013#issuecomment-158098109
.

Interesting, good to know. At least we could probably add a note about Xrandr somewhere as a common issue. I imagine it is more of an LWJGL topic though than anything Terasology specific. It might be possible to script something but I'm unsure what (in a portable fashion) or who might have the time, skill, and OS availability to do it.
Unless maybe you're up for trying something out ... :-)

What do you need xrandr for? I didnot havea look at the full log, but I don't get the connection between TS and xrandr. ..


Update Assets.pod

Thought the example would be a little clearer if a css file was pointing to a css file.

Thank you! :+1:


Documentation link for migrate displays 404 error

In the documentation for the site commands here http://docs.rtcamp.com/easyengine/commands/site/ if you click the migrate link it will bring you to a 404 page.

Hello @texgibson ,
Thanks for pointing this.
Migrate command is not yet ready. We now removed that from doc.
Ref: https://github.com/rtCamp/docs.rtcamp.com/commit/6d03c486a8d1cb67541af41862f8fab881f282be


Added data summary for reads.

This updates the info frontpage to include information on readgroupsets. Here is a snapshot:
GA4GH reference server 0.1.0a2
Protocol version 0.5.1
Operations availableMethod	Path
POST	/v0.5.1/callsets/search
POST	/v0.5.1/readgroupsets/search
POST	/v0.5.1/reads/search
GET	/v0.5.1/references/<id>
GET	/v0.5.1/references/<id>/bases
POST	/v0.5.1/references/search
GET	/v0.5.1/referencesets/<id>
POST	/v0.5.1/referencesets/search
POST	/v0.5.1/variants/search
POST	/v0.5.1/variantsets/search

Uptime
 Running since a second ago (14:49:27 31 Mar 2015)
ConfigurationKey	Value
DEBUG	True
REQUEST_VALIDATION	False
RESPONSE_VALIDATION	True

Data
VariantSets

1kg-phase1
1kg-phase3

ReadGroupSets

low-coverage
	low-coverage:HG00096.mapped.ILLUMINA.bwa.GBR.low_coverage.20120522
	low-coverage:HG00533.mapped.ILLUMINA.bwa.CHS.low_coverage.20120522
	low-coverage:HG00534.mapped.ILLUMINA.bwa.CHS.low_coverage.20120522

It's not very pretty, but it does give useful information.
I've also removed the numVariants bit, as we can't calculate this at the moment for VCFs and it would be confusing to leave it as 0.

Oh good, I was intending to do this.
+1


OpenScenario AttributeError: 'NoneType' object has no attribute 'get_forward_vector'

I tried to run:
python scenario_runner.py --openscenario srunner/examples/PedestrianCrossingFront.xosc --reloadWorld --output
and scenario started but after  few seconds it stoped with an error:
AttributeError: 'NoneType' object has no attribute 'get_forward_vector'
'NoneType' object has no attribute 'get_forward_vector'
Destroying ego vehicle 2953
No more scenarios .... Exiting
System settings:
OS: Ubuntu 18.04
CARLA Version: CARLA 0.9.9
Python version: 2.7.17
Version: 0.9.9

Now, there is another error:
Traceback (most recent call last):
File "scenario_runner.py", line 382, in _load_and_run_scenario
self.manager.run_scenario()
File "/home/sehrizadasahinovic/scenario_runner/srunner/scenariomanager/scenario_manager.py", line 216, in run_scenario
self._tick_scenario(timestamp)
File "/home/sehrizadasahinovic/scenario_runner/srunner/scenariomanager/scenario_manager.py", line 260, in _tick_scenario
self.scenario_tree.tick_once()
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/behaviour.py", line 158, in tick_once
for unused in self.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/scenario_runner/srunner/tools/py_trees_port.py", line 61, in tick
for node in self.decorated.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 309, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/scenario_runner/srunner/tools/py_trees_port.py", line 61, in tick
for node in self.decorated.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 309, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/scenario_runner/srunner/tools/py_trees_port.py", line 61, in tick
for node in self.decorated.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 309, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/scenario_runner/srunner/tools/py_trees_port.py", line 61, in tick
for node in self.decorated.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 578, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 309, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/composites.py", line 494, in tick
for node in child.tick():
File "/home/sehrizadasahinovic/scenario_runner/srunner/tools/py_trees_port.py", line 61, in tick
for node in self.decorated.tick():
File "/home/sehrizadasahinovic/.local/lib/python2.7/site-packages/py_trees/behaviour.py", line 249, in tick
new_status = self.update()
File "/home/sehrizadasahinovic/scenario_runner/srunner/scenariomanager/scenarioatomics/atomic_behaviors.py", line 505, in update
self._distance += calculate_distance(self._location, new_location)
File "/home/sehrizadasahinovic/scenario_runner/srunner/scenariomanager/scenarioatomics/atomic_behaviors.py", line 54, in calculate_distance
return location.distance(other_location)
AttributeError: 'NoneType' object has no attribute 'distance'
'NoneType' object has no attribute 'distance'
Destroying ego vehicle 433
No more scenarios .... Exiting

@sehrizadasahinovic First, this isn't related to the problem I mentioned before, that was due to my own stupidity.
Now, I just tried with CARLA 0.9.9 and it is indeed failing but it works with current CARLA master. Why? CARLA 0.9.9 has a problem related to the loading of the world, which causes some actor instances to be wrong. This was solved at CARLA <IP_ADDRESS> + a patch to UnrealEngine (patch instructions here, a t the dependencies section).
Therefore, you have two options:

Do not reload the world (don't use --reloadWorld)
Upgrade to CARLA <IP_ADDRESS> and patch Unreal

Hi @glopezdiest , it works now. Thx a lot.


option for stay subscribed on EOSE

clients may want to stay subscribed to possible new events after EOSE.

feature added:
https://github.com/sepehr-safari/nostr-hooks/commit/be38fddba6ddb24b52567ae6ccef7d4ccb84d47d


Pipeline drawing edge-case

I just found a case where the Pipeline.draw method fails:
from creme import compose
from creme import datasets
from creme import feature_extraction
from creme import linear_model
from creme import preprocessing
from creme import stats

X_y = datasets.fetch_bikes()

def add_hour(x):
    return {
        **x,
        'hour': x['moment'].hour
    }

model = compose.Whitelister('clouds', 'humidity', 'pressure', 'temperature', 'wind')
model += (
    add_hour | (
        feature_extraction.TargetAgg(by=['station', 'hour'], how=stats.Mean()) +
        feature_extraction.TargetAgg(by='station', how=stats.EWMean())
    )
)
model |= preprocessing.StandardScaler()
model |= linear_model.LinearRegression()

model.draw()

This is what I get:

But it should be something like this:

I think we have some brainstorming to do @gbolmier :)

Aïe :sweat_smile: thx @MaxHalford!

Fixed sir! I just submitted the PR :wink:
My bad, it was a little oversight... but I think there is still things we need to discuss together (e.g. estimators declarative order isn't respected here, in your example we first declare our model with a Whitelister but it ends up in second position, right after the Pipeline starting with the add_hour func)

Nice one!
I think that if you sort the keys you loop over for the TransformerUnion then it should work. What I mean is replace for ix, sub_key in enumerate(step.keys()) with for ix, sub_key in enumerate(sorted(step.keys())). If you have the time can you check if it works and update your PR? :)

Actually there is no need for ix and enumerate now! I'm updating it

Thanks!


Bitcoin payment

i have create bitcoin payment adapter
May optimize for usage
config = $config;
        if(!$this->config['btcaddress']) {
            throw new Exception('Payment gateway "Bitcoin" is not configured properly. Please update configuration parameter "Bitcoin address" at "Configuration -> Payments".');
        }
    }

    /**
     * @param Box_Di $di
     */
    public function setDi($di)
    {
        $this->di = $di;
    }
    public static function getConfig()
    {
        return array(
            'can_load_in_iframe'   =>  true,
            'supports_one_time_payments'   =>  true,
            'supports_subscriptions'       =>  false,
            'description'     =>  'bitcoin',
            'form'  => array(
                'btcaddress' => array('text', array(
                            'label' => 'Your Btc Address',

                    ),
                 ),
            ),
        );
    }
    /**
     * Generate payment text
     *
     * @param Api_Admin $api_admin
     * @param int $invoice_id
     * @param bool $subscription
     *
     * @since BoxBilling v2.9.15
     *
     * @return string - html form with auto submit javascript
     */
    public function getHtml($api_admin, $invoice_id, $subscription)
    {
        $data['btcaddress']           = $this->config['btcaddress'];
        $invoiceModel = $this->di['db']->load('Invoice', $invoice_id);
        $invoiceService = $this->di['mod_service']("Invoice");
        $invoice = $invoiceService->toApiArray($invoiceModel, true);
        $rate = json_decode(file_get_contents("http://www.coinvibes.com/api/v1/tickers/btce/btc_eur"),1);
        $price_in_btc = round($invoice['total'] / $rate['average'],8);
        return "Price in BTC = ".$price_in_btc."BTCPlease send to ".$data['btcaddress']."or Scan QR code your bitcoin appWhen You sent your payment Open Ticket which included your Bitcoin address.";
    }
    public function process($tx)
    {
        //do processing
        return true;
    }
}

Thank U. useful to

Please open a pull request regarding this payment gateway in https://github.com/boxbilling/extensions repository.

there are some automated services which can do this work (like Coinbase)


Add headless mode option into the release types. Update call to SwitchActiveBuildTarget

Thanks. These look like good additions. I'll get this merged as soon as I can test them out.

Unity Editor crashes if you try to build with development build and headless mode options at the same time, I did a new update: https://github.com/jraicr/unity-build/commit/216c6c1acefc48bf6488b9de10b476293e4a0f7e


Openlayers 7

Does this component support Openlayers 7.  If yes, how to set it up?

Now we user 7.2.2


Local attributes look weird

Here's how they look with lua.tmbundle:

And here's how they look with my own:

It's just as simple as this:
<dict>
	<key>match</key>
	<string><(const|close)></string>
	<key>name</key>
	<string>storage.type.attribute.lua</string>
</dict>

Please make a pull request for it, thank you!


Added support for accounts-passwords

I have added basic support for passwords login.
I have tested it with facebook and google. All emails are moved to "old" account as services in original lib. I have added special case for signInWithPassword which handles password login.

@lirbank any chance of getting this merged in? Would be extremely useful to add to our projects

Closed due to inactivity of repository owner. @lirbank