[tool_crash] ArgumentError: Invalid argument(s)

Command
flutter --no-color build ios

Steps to Reproduce

...
...
...

Logs
ArgumentError: Invalid argument(s)
#0      _StringBase._interpolate (dart:core-patch/string_patch.dart:861:9)
#1      _BuildIOSSubCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:240:72)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1157:12)
<asynchronous suspension>
#3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1009:27)
<asynchronous suspension>
#4      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#5      AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
<asynchronous suspension>
#6      CommandRunner.runCommand (package:args/command_runner.dart:197:13)
<asynchronous suspension>
#7      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:278:9)
<asynchronous suspension>
#8      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#9      AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
<asynchronous suspension>
#10     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:234:5)
<asynchronous suspension>
#11     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:64:9)
<asynchronous suspension>
#12     run.<anonymous closure> (package:flutter_tools/runner.dart:62:12)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.3 20D91 darwin-x64, locale en-IN)
    • Flutter version 2.0.3 at /Users/senthiljs/development/flutter
    • Framework revision 4d7946a68d (5 weeks ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/senthiljs/Library/Android/sdk
    • Platform android-S, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Connected device (3 available)
    • CPH2001 (mobile)                     • WGCMHEN7YH6STCVS                     • android-arm64  • Android 10 (API 29)
    • iPod touch (7th generation) (mobile) • 02A8115F-0DB9-445A-8DDF-1A11EB02A601 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • Chrome (web)                         • chrome                               • web-javascript • Google Chrome 89.0.4389.128

• No issues found!

Flutter Application Metadata
Type: null
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: null
Creation framework version: null
Plugins
connectivity-2.0.2
connectivity_for_web-0.3.1+4
connectivity_macos-0.1.0+7
flutter_plugin_android_lifecycle-1.0.11
geocoding-1.0.5
geolocator-6.2.1
geolocator_web-1.0.1
google_maps_flutter-0.5.33
image_picker-0.6.7+22
open_file-3.1.0
path_provider-1.2.0
path_provider_linux-2.0.0
path_provider_windows-2.0.0
shared_preferences-2.0.5
shared_preferences_linux-2.0.0
shared_preferences_macos-2.0.0
shared_preferences_web-2.0.0
shared_preferences_windows-2.0.0
url_launcher-5.7.10
url_launcher_linux-0.0.1+4
url_launcher_macos-0.0.1+9
url_launcher_web-0.1.5+3
url_launcher_windows-0.0.1+3

Similar issue was fixed, merged and cherry picked into Stable, https://github.com/flutter/flutter/issues/59029.
Not sure if it has come back.
Keeping this open for further insights.
Cc: @jmagman

App ID should be more resilient. https://github.com/flutter/flutter/issues/59029#issuecomment-654492636
https://github.com/flutter/flutter/blob/4d7946a68d26794349189cf21b3f68cc6fe61dcb/packages/flutter_tools/lib/src/commands/build_ios.dart#L240

@jmagman Hi again :)
Coming back to this issue, I verified by running below commands on latest stable version of framework and didn't get the reported error.

flutter --no-color build ios:

dhs@Dhss-MacBook-Pro flavors_example % flutter --no-color build ios
Building com.nevercode.triage for device (ios-release)...
Automatically signing iOS for device deployment using specified development team in Xcode project: X8NNQ9CYL2
Running Xcode build...
 └─Compiling, linking and signing...                         7.0s
Xcode build done.                                           41.4s
Built /Users/dhs/Documents/NCFlutter/triage-examples/flutter_examples/flavors_example/build/ios/iphoneos/Runner.app.
dhs@Dhss-MacBook-Pro flavors_example %

flutter build ios --release -t lib/main_dev.dart --no-codesign --flavor dev --build-number=635:

dhs@Dhss-MacBook-Pro flavors_example % flutter build ios --release -t lib/main_dev.dart --no-codesign --flavor dev --build-number=635
Warning: Building for device with codesigning disabled. You will have to manually codesign before deploying to device.
Building com.nevercode.triage for device (ios-release)...
Running Xcode build...
 └─Compiling, linking and signing...                         3.1s
Xcode build done.                                           36.6s
Built /Users/dhs/Documents/NCFlutter/triage-examples/flutter_examples/flavors_example/build/ios/iphoneos/Runner.app.
dhs@Dhss-MacBook-Pro flavors_example %

With these updates, is it safe to close this issue ?

Given that we don't have reproducible steps here, closing.


Unable to join federated rooms #572

Use the roomAliases field of RoomPreviewData. It contains either the aliases provided by MXPublicRoom or the aliases in the state of a room we are peeking in.

LGTM


Convert numbers to decimal representation

Test doesn't work with hexadecimal numbers. Convert them to decimal
representation before comparing them otherwise the script aborts when
it encounters number with non-decimal-digit character.

Hi Petris,
Thanks for your pull request!
What is the test case that fails, and do you have any console output to describe the failure?

Hi,
try e.g.
partrt run -c 0xf rt true
it fails with
/usr/bin/partrt: line 788: [: f: integer expression expected
the same can be triggered using move command

Ok, I see. I was thinking unit test, done too much development on unit tests lately apparently... It looks good to me.

It's merged now, thanks for your contribution Petris!


Datasource and GenerationLength

@timoschick my PR adds some new basic functions for processing the metadata types DATASOURCE and LENGTH:

datasource parser (w/o threshold)
datasource preprocessor
datasource tests
length parser (global)
length preprocessor
length tests

Merged in #81.


Don't emit a warning to import Foundation for dynamic decls even in S…

…wift 4 mode
Dynamic does not imply @objc anymore.

@swift-ci Please smoke test


pull request for e2e test at 12/25/2016 19:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Agent Catalog Serialization

AREV LPA Data is polluting the agents serialization, so updated shadowcat set_sc_agents job to parse the AREV data back into individual subjects and names that should propagate into better agent serialization


⚠ Avatar API Endpoint has degraded performance

In 618bbb4, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1178 ms

Resolved: Avatar API Endpoint performance has improved in 5e29b90.


Build Errors in Libscout-master project

I'm getting build errors as soon as I open the project in eclipse. Please find the below screenshot and help me in fixing them.

Make sure you add an Android SDK .jar to your dependencies. See instructions at LibScout 101 in the Readme.


Update event.md - the description is hard to understand

The description is hard to understand. It uses circular references to the word event and refers to an undefined term, namely `pub;lisher class".
Summary
Describe your changes here.
I propose a new description of the event keyword without referring to the meaningless event word.
The publisher class must be defined as a placeholder of the event variable but must not be defined referring to the event term.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/keywords/event.md
docs/csharp/language-reference/keywords/event

@BillWagner thanks for the answer.
I agree with you that the documentation must be consistent so if there is a definition we must follow it. So for me, the priority is consistency. But we must also avoid logical errors like "enables an object or class ". Talking about objects we are talking about run-time. Objects are created at run-time by instantiating reference types. The documentation is about compile time so we can only talk about class as a type. But type (including but not limited to class) is only a text (snippet of a program). so the sentence "enables an object or class to provide notifications" is logically inconsistent for me, because the class is only a text so it doesn't have any behavior (it describes behavior but it is a huge difference).  Let me give you an example
public class MyClass
{
    public delegate void MyDelegate(string message);
    public event MyDelegate MyEvent;
}

Can we agree that MyEvent is a variable - a value holder because we can assign value to it?
Can we agree that MyDelegate  is this variable type?
Can we agree that public is an access modifier to the MyEvent variable?
Can we agree that access to the selected operations is not symmetric in the context of the MyClass boundary?
Can we agree that we are talking only and only about compile-time syntax and semantics of the text?
BTW where I can find the definition of the pointer term?

@BillWagner again,
Using Copilot: A delegate in C# is a type that represents references to methods  -  so maybe we should replace a method pointer with a method reference in my proposal?
Unfortunately in this definition, there is a next error because delegate is also a variable not only a type, for example
public class MyClass
{
    public delegate void MyDelegate(string message);
    public MyDelegate delegateVariable;
}

Can we agree that delegate is the keyword used to declare a delegate type?
Can we agree that the MyDelegate is the type?
Can we agree that the delegateVariable is a variable ( a value holder) prefixed by the public access modifier?
Can we agree that all operations (including invoking all members added in advance to the delegateVariable ) are visible outside the class boundary?

Let me stress

I am not a native speaker.
I have not reviewed the documentation so I am not sure about the consistency of my proposals.

@BillWagner Sorry for step by step refinement. Let's look at the ANTLR definitions:
event_declaration
    : attributes? event_modifier* 'event' type variable_declarators ';'
    | attributes? event_modifier* 'event' type member_name
        '{' event_accessor_declarations '}'
    ;

variable_declarators  is a list of identifiers that are variables, isn't it?
member_name is a variable identifier, isn't it

Why not
member_name = variable_declarator;

The term pointer was used in another discussion but I think it was used inappropriately in that discussion. In the context of .Net the appropriate term is reference . The term pointer is relevant to unmanaged languages and interfacing with them.

The following is my understanding and possible confusion. If any of the following is incorrect then it might be a deficiency in the documentation.
I think the fundamental problem is that the event keyword is used in C# in a very confusing manner. A fundamental design criteria for the language is that it be readable yet I think this is an example of a violation of that.
The term event is a term used with all multiprocessing operating systems. Events are synchronization objects. IBM Mainframe operating systems had events half a century ago. Windows had (has) events in the original 16-bit versions of Windows, as in:
Using Event Objects (Synchronization) - Win32 apps | Microsoft Learn
https://learn.microsoft.com/en-us/windows/win32/sync/using-event-objects
In .Net there are ManualResetEvent and AutoResetEvent classes. Yet the event keyword seems to mean something very different.
I wish people would not call everything a keyword. When there is a specific name for what something is then the documentation should say what the keyword is. I can't find an explanation of what the event keyword is. Is it an attribute? A modifier? A type? Something else? event keyword - C# reference | Microsoft Learn is the official specifications that developers of C# compilers would use to write a compiler. Even that does not specify what the event keyword is. Very frustrating.
event keyword - C# reference | Microsoft Learn is the (this?) programming documentation of event. Note that it says that the event keyword declares an event. Further down is something interesting. It says:

Events are a special kind of multicast delegate

Whereas in other contexts, such as for other operating systems including the Windows API, an event is very different. Microsoft's use of the term event in the context of .Net seems to be inconsistent with the typical use of the term. If that is correct then it definitely needs clarificati9on.

HI @BillWagner; thanks for the discussion, One more thing.
Look at

event assignment example

It is a declaration defining the event and an assignment statement simultaneously. The assignment statement, as far as I know, is available only for variables, isn't it? This operation is visible at compile time only and only inside the class, so the visibility is not symmetric.
I agree that it is a special variable because it holds a reference to set. Hence we can only add or remove members of this set. Review the mathematical set theory. Unfortunately inside the class (publisher), we can also remove all members (assign null) or assign a set with a single member, can't we?

Because member_name might include an explicit interface implementation. (Something like IEnumerable<MyType>.GetEnumerator().

not sure but you may be right. Let me stress that thanks to many "simplifications"  (many thanks from my students) a reference to the method (delegate value) could be instantiated implicitly (no new operator), for example, lambda expression

public event Func<int, int> square = x => x * x;

Can we agree that the x => x * x; is a method (anonymous but a method with one parameter x and one return statement returning value x * x
Can we agree that we are creating a reference to this method in this assignment statement (right side of the = operator
Can we agree that we are adding this reference (a reference to an instance of a delegate value) to the set and assigning a reference to this set to an event (variable?)
Can we agree that this operation (assignment) is visible inside the class defining the field as its member only?
There is only one question, how broad the meaning must be scoped to make the documentation consistent, and how to explain this to someone wanting to only use this language, say engineer? In my opinion, by "Simplifying" the language syntax we are making semantics hard to understand.
Fortunately, according to my experience, event implementation is always the same but the description is completely different so it could create frustration.  In all the cases I know event always is a set of references to methods.  The signaling event can be read as "invoking all members of this set". Callback in other words.
Rdgs,
Mariusz

First, the language reference is meant to be an informal companion to the standard (the C# Language Specification). It shouldn't disagree with the spec, but it isn't as complete. It also isn't as formal. From that goal, here's some specific answers:

IBM documents computer languages differently. See Enterprise COBOL for z/OS documentation library. They have both a programming guide and a language reference. The programming guide is like the documentation that Microsoft provides. I think it is unfortunate that Microsoft omits details from the documentation that is relevant to the use of their software that is considered too technical.

C# events can represent Windows events. I'm not sure I understand that comment.

My understanding is that when the event keyword is used in C# it is used to provide something very different from most other uses of the term event. In most uses there is a set and reset status. As in the ManualResetEvent and AutoResetEvent classes and for the event objects in the Windows API. For C# event provides a list of delegates, right? Does event provide set and reset statuses? My understanding is that it does not. Therefore that needs to be emphasized and clarified.

The delegate keyword is used to declare the delegate type
The event keyword is used to declare the event variable (example)

That is very confusing. The term variable is essentially synonymous with name. I do not understand what more that it implies in this context. If it is appropriate to say that event declares a list, something like that, then that would be useful.

The delegate keyword is used to declare the delegate type. The event keyword declares an instance of the delegate type and supports add and remove operations (or += and -=). The instance of the delegate is a property that supports add and remove. (That handles both the 3rd and 4th items above).

That helps. I think it is important that the documentation make that clear. Except, does event declare an instance of the delegate type without the delegate keyword? If not then I think it is confusing to say that the event keyword declares an instance of the delegate type. This is where it helps to specify what the event keyword is. Is it a type? I think that it is not. It is an attribute or modifier or something like that. I think a clear definition of what the event keyword is would help.

Hi All,

The term variable is essentially synonymous with name.

I disagree, for me the variable is a placeholder for a value, so there is an available assign operation, for example, field. local variable, parameter, etc, Identifier of the variable is only a name that must be unique in the visibility scope used to distinguish it from others.

Does event provide set and reset statuses?

Yes. But the "set" and "reset" in your sentence I read as requests to change a condition and notify the result by activating sth (callback, scheduler, etc)

reset (resetting event example)
set += actually, it is adding the next member to the existing set or adding a reference to a new set populated with one member as in the following example

  public event Func<int, int> square = x => x * x;

we also may notify the event (condition) by using the event variable as the invocation of all methods (if any) pointed by it (already added to the set), for example (event notification)

@SamHobbsOrg the ManualResetEvent and AutoResetEvent are classes (reference types) but not events. My understanding is that both represent a condition that can be changed using operations like set and reset. These operations must not be interrupted by any concurrent activity to protect consistency. The operations could change the condition and invoke operations related to the scheduling mechanism. It doesn't necessarily need an event as the language construct (as far as I remember my PhD dissertation). Maybe the Event suffix in the names is confusing but we must not refer to these classes talking about the language construct "event". As we talk about the language definition we must not simultaneously talk about the type declarations provided by the language except types tightly coupled with the language constructs like IDIsposable, IEnumerable, etc.
According to my understanding, we must distinguish between the event keyword, event variable, event concept, event type, event handler, and event term. For me, it is the main reason we are discussing it late after the language was proposed for the first time.

@BillWagner, I opt for point 1. It is imperfect, but I recognize it as a step in a good direction. In your proposal, consider only the definition of the subscriber and publisher roles. You are referring to subscribers, but there is nothing about publishers. You said, Events are the means... but what does that mean in terms of the language? Maybe replace the means with member. It leads to Events are the members.... BTW, can events be declared as members of structs? I like the proposal that instead of a reference to method you are using the delegate term (Clients attach delegates ...). I understand that it is a value of the delegate type.
Go ahead.
Independently I will work on a video explaining this topic in more detail. By design, it will be a section in my new book addressing delegates, events, communication, callback, and reactive programming in the context of program architecture and anonymous function. Hopefully, this video will be a good starting point for entering a discussion and proposals for conceptual docs on events later.

Events are the means for a class or object to notify clients that something happened. A class or object raises the event.

The fundamental topic is the event keyword. How does the event keyword do anything to notify the clients? If it does the notification then that needs to be explained. Because as best as I understand things, the event keyword just creates a list of a specified delegate type that has appropriate overloads for adding and removing. The actual calling of the delegates is done by something else.

Clients attach delegates to an event by adding the delegate to the declared event.

Attach as in adding to the list, correct?

Clients can also remove delegates from the declared event.

Remove as in detach, correct? Remove as in removing from the list, correct?

It's valid for an event to have no subscribers. In that case, the event object is null.

That is consistent with an empty list, correct?
I think discussions here of the use of the term event in other contexts is relevant to any developer familiar with the term in other contexts. The most important point I think is that the event keyword means something different from all other contexts that the term event is used. Perhaps if that is established then I don't need to spend an hour or more trying to provide specifics. For example the following is documentation of what relevant events are for the IBM Mainframe environment.

Synchronizing tasks (WAIT, POST, and EVENTS macros) - IBM Documentation
EVENTS — Wait for one or more events to complete - IBM Documentation

@mpostol

BTW, can events be declared as members of structs?

Yes. However, the can't be declared as members of ref struct types.


Import fails

Something seems to have changed overnight -- I'm getting an error when running import flash_cosine_sim_attention (running off 0.1.15 pip-installed):
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ubuntu/.local/lib/python3.8/site-packages/flash_cosine_sim_attention/__init__.py", line 1, in <module>
    from flash_cosine_sim_attention.flash_cosine_sim_attention import flash_cosine_sim_attention, plain_cosine_sim_attention, l2norm_tensors
  File "/home/ubuntu/.local/lib/python3.8/site-packages/flash_cosine_sim_attention/flash_cosine_sim_attention.py", line 10, in <module>
    exec(open('flash_cosine_sim_attention/version.py').read())
FileNotFoundError: [Errno 2] No such file or directory: 'flash_cosine_sim_attention/version.py'

When the package is make install'd, everything works as expected (I'm assuming it's another bundling issue :^))
Edit: actually the make install version only works when running from the repository  -- I get the same issue when running outside the repository

@kradonneoh https://github.com/lucidrains/flash-cosine-sim-attention/commit/178c41a797d4a5389728a80cad505d899edc211f may be fixed in 0.1.17 :crossed_fingers:

@kradonneoh do let me know if the kernel works or does not work for your problem 🙏


why no_std and no_main

when i tried this a few days ago it didn't have those changes so is there any reason why.
imo this is kinda confusing like can i just remove those or do things break when i remove them.
talking about these in main.rs
#![no_std]
#![no_main]

#[no_mangle]

Thanks for noticing!
These were forgotten since the last change to the template that simplified it (who uses the template without STD?).
I've fixed it now.


DaedalusIPC clean ups

For #209.
I would also like to add the javascript test case from cardano-wallet, but am out of time today.

this needs some update to nix files.

OK I updated the nix files. Up to you to decide on <<$>> - I don't normally use it.


disableKinds works incorrectly

hugo env
Hugo Static Site Generator v0.29 windows/amd64 BuildDate: 2017-10-09T07:56:25+02:00
GOOS="windows"
GOARCH="amd64"
GOVERSION="go1.9"

No disable kinds usage
This command:
hugo -D

Renders in /public/ the following:
public
├── categories
|   ├── music
|   |   ├── index.xml
|   |   └── index.html
|   ├── movies
|   |   ├── index.xml
|   |   └── index.html
|   ├── index.xml
|   └── index.html
├── tags
|   ├── reviews
|   |   ├── index.xml
|   |   └── index.html
|   ├── soundtrack
|   |   ├── index.xml
|   |   └── index.html
|   ├── index.xml
|   └── index.html

This is correct, because without disableKinds set to disable taxonomy and taxonomy terms I would expect this.
Disable taxonomy terms
This command:
hugo --disableKinds=taxonomyTerm

Renders:
public
├── categories
|   ├── music
|   |   ├── index.xml
|   |   └── index.html
|   ├── movies
|   |   ├── index.xml
|   |   └── index.html
├── tags
|   ├── reviews
|   |   ├── index.xml
|   |   └── index.html
|   ├── soundtrack
|   |   ├── index.xml
|   |   └── index.html

I think this is incorrect, because taxonomyTerm here doesn't disable the taxonomy terms pages but instead the index.html of the main taxonomies (/tags/index.html and /categories/index.html).
In other words, --disableKinds=taxonomyTerm term behaves here like --disableKinds=taxonomy should. I base that assumption of how it should work based on the official definition of 'taxonomy' and 'taxonomy term'.
Disable taxonomies
With this command:
hugo --disableKinds=taxonomy

The website renders like this:
public
├── categories
├── tags

Now the taxonomy folders generate, but they're empty. I think this is incorrect too, because the taxonomy terms should remain. (Otherwise there's no point in having the additional taxonomyTerm setting.)
Disable both taxonomies and taxonomy terms
With this command:
hugo --disableKinds=taxonomy,taxonomyTerm

Both the /tags/ and /categories/ folder don't generate. This behaviour is exactly like documented so correct.
But in practice this is the same as using --disableKinds=taxonomy, with only the additional benefit that taxonomyTerm deletes the empty taxonomy folders.
I don't think taxonomyTerm is added only to remove empty folders, so I'd say that behaviour is odd too.

I don't have the disableKinds configuration variable set in my configuration file, so there's no conflict between the command flag and configuration file.
I have the cleanDestinationDir configuration variable set to true to make sure there are no files left over from the previous build.

your example above actually works correctly according documentation in Taxonomy Templates Docs
Disable Taxonomy Terms
according the docs on Taxonomy Templates Docs

A taxonomy terms page will be rendered at example.com/<PLURALTAXONOMYNAME>/ (e.g., http://spf13.com/topics/)

in your example categories and tags are the Taxonomy Terms
Disable Taxonomy
according the docs on Taxonomy Templates Docs

A taxonomy will be rendered at /PLURAL/TERM/ (e.g., http://spf13.com/topics/golang/)

In your example categories/music and categories/movies is the Taxonomy
Why categories and tags folder generated?
Because you did not set any [taxonomies] configuration in your config file. as the default HUGO will set categories and tags as your [taxonomies] config.
Yes, the definition of Taxonomy and TaxonomyTerms are not same between documentation in Content Management / Taxonomies and Templates / Taxonomy Templates
as in Content Management / Taxonomies explained like this
Moonrise Kingdom            <- Content
    Actors                  <- Taxonomy
        Bruce Willis        <- Term
        Bill Murray         <- Term
    Director                <- Taxonomy
        Wes Anderson        <- Term

So, the documentation need to be revised, we need to clearly define what we called as taxonomy and taxonomyTerm

Thanks for your thorough reply Pamubay. I think you're on to something. If your explanation holds for the Hugo team, the Content management / Taxonomies page is indeed incorrect.
So my website example has the following meanings for the taxonomies:
website                     <- Content
    categories              <- Taxonomy term
        music               <- Taxonomy
        movies              <- Taxonomy
    tags                    <- Taxonomy term
        reviews             <- Taxonomy
        soundtrack          <- Taxonomy

With this explanation:
(1) hugo --disableKinds=taxonomyTerm works correctly because it disables the index.html and index.xml files in /tags/ and /categories/.
(2) hugo --disableKinds=taxonomy still works incorrectly. Because with that command, the index.html and index.html in /tags/ and /categories/ do not render (as mentioned above).
But those files in /tags/ and /categories/ should render, because if I disable my taxonomies (reviews, soundtrack, music, movies), the taxonomy terms (tags, categories) pages should still appear.
Otherwise, there's no point in having the combination of --disableKinds=taxonomy,taxonomyTerm to turn both taxonomies and taxonomy terms off. In practice, --disableKinds=taxonomy already turns off both (with only the empty taxonomy term folders kept).

Why categories and tags folder generated?
Because you did not set any [taxonomies] configuration in your config file. as the default HUGO will set categories and tags as your [taxonomies] config.

I do have the taxonomies configured in my config.toml file, like so:
[taxonomies]
    category = "categories"
    tag = "tags"

So this doesn't seem to explain why --disableKinds=taxonomy gives empty folders with no taxonomy and taxonomy term pages.

So, the documentation need to be revised, we need to clearly define what we called as taxonomy and taxonomyTerm.

I fully agree with that. It's a serious topic because taxonomies are already abstract enough for beginners that conflicting docs pages are terrible. If it were not for you I would never have figured out that some doc pages define taxonomy and taxonomy term differently. Thanks! 😄

Otherwise, there's no point in having the combination of --disableKinds=taxonomy,taxonomyTerm to

What happens here, I'm pretty sure, is this:

If you disable taxonomies, Hugo creates no taxonomies.
If Hugo creates no taxonomies for a term, Hugo does not create the Page for the term (even if it is enabled)

So you may have a point in that the combination above does not make sense, but it is fairly simple: Don't use it. We're not adding any validation or similar to the disableKinds value. That is up to the user.


add support for control messages carried in zson.Record

This commit allows for control messages (aka zson commentds)
to be carried in zson.Records and read/write to zson text and
raw formats.
Such records are not allowed into the proc flowgraph.
This mechanism is useful for higher layers to embed control
and signaling into a stream of raw zson records.  For example,
zson over http uses these messages to provide end-to-end
reliability semantics.

👍 but update the spec doc too?

done!


converting project  structure to go module

and, please add a release tag for everyone, thanks

Coverage decreased (-1.5%) to 78.111% when pulling 6b52f8bfe6d6086a0b873fb50316e920c8e2de4b on winjeg:master into 2cc03de413da42869e2db7ce7965d3e978d917eb on samuel:master.


fix: add matthewraymond

Fixes Issue

Changes proposed
I am contributing to linkfree by adding my profile in it!
[x] - Correct; marked as done
[X] - Correct; marked as done
[ ] - Not correct; marked as not done
-->
Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[X] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Thanks for the suggestion, updated my code as your suggestion!

Thanks for the suggestion, updated my code as your suggestion!

I changed my code as suggested

Hmm it isn't updated plus the Prettier CI is failing

can you suggest me how to fix it? btw i allready commited ur suggestion.

Fixed the issue!


nixos/haproxy: check conf on build

Motivation for this change
Current services will continue deploying configuration even though config may contain syntax errors. This pull request check config syntax on build which makes it easier to notice errors.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

ping @symphorien @Ma27

ping @symphorien @Ma27

@SuperSandro2000 Anything else needs to be revised? I am not sure about the editorConfig test tho: I intended to leave an extra newline when generating before appending user config.

@SuperSandro2000 Anything else needs to be revised? I am not sure about the editorConfig test tho: I intended to leave an extra newline when generating before appending user config.

@NeverBehave please review this PR: https://github.com/NixOS/nixpkgs/pull/62853

@NeverBehave please review this PR: https://github.com/NixOS/nixpkgs/pull/62853

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

From the manual it said “Only checks config file and exits with code 0 if no error was found, or exits with code 1 if a syntax error was found.” I believe only syntax error will fail the build, where the path won’t be touch during validation. I didn’t thought about that at first so I would give it a shot.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

From the manual it said “Only checks config file and exits with code 0 if no error was found, or exits with code 1 if a syntax error was found.” I believe only syntax error will fail the build, where the path won’t be touch during validation. I didn’t thought about that at first so I would give it a shot.

[nix-shell:~]$ haproxy -c -f haproxy.conf
[NOTICE] 016/052037 (9649) : haproxy version is 2.3.2-d522db7
[NOTICE] 016/052037 (9649) : path to executable is /nix/store/fw0yfwfpadhdsfsljrfmsckpafrmd8fg-haproxy-2.3.2/bin/haproxy
[ALERT] 016/052037 (9649) : parsing [haproxy.conf:3] : 'bind <IP_ADDRESS>:443' : unable to stat SSL certificate from file '/etc/ssl/certs/mysite.pem' : No such file or directory.
[ALERT] 016/052037 (9649) : Error(s) found in configuration file : haproxy.conf
[ALERT] 016/052037 (9649) : Fatal errors found in configuration.

Well it looks like that the certificate file will be checked. Then I think it is better to keep it away from the sandbox for now. Thanks for pointing this out.

[nix-shell:~]$ haproxy -c -f haproxy.conf
[NOTICE] 016/052037 (9649) : haproxy version is 2.3.2-d522db7
[NOTICE] 016/052037 (9649) : path to executable is /nix/store/fw0yfwfpadhdsfsljrfmsckpafrmd8fg-haproxy-2.3.2/bin/haproxy
[ALERT] 016/052037 (9649) : parsing [haproxy.conf:3] : 'bind <IP_ADDRESS>:443' : unable to stat SSL certificate from file '/etc/ssl/certs/mysite.pem' : No such file or directory.
[ALERT] 016/052037 (9649) : Error(s) found in configuration file : haproxy.conf
[ALERT] 016/052037 (9649) : Fatal errors found in configuration.

Well it looks like that the certificate file will be checked. Then I think it is better to keep it away from the sandbox for now. Thanks for pointing this out.


Fixing aggregate queries with no GROUP BY to include the end time

Queries with a time constraint but no group by would not include the
final point from the underlying iterator.
Fixes #6229.

@benbjohnson
@toddboom this should probably be cherry-picked for 0.12.1.

:+1:


No code actions available when selecting text in visual mode

Code actions are not working when selecting code in visual mode.
If you make the same selection with the mouse, code actions become available:

This is because visual selection isn't sent to vscode. There are issues tracking this.
Workarounds off the top of my head:

open code actions from F1/C-p command picker
route code actions keybinding (ctrl+.) through neovim

send ctrl+. to neovim from vscode in keybindings.json
invoke code actions picker from neovim using VSCodeNotifyVisual


Taking over as maintainer for pyxdg?

I mentioned this in a pull request over at the pyxdg repository. The problem is that pyxdg is effectively EOL while also still being the official/reference implementation for a number of XDG standards in Python.
My reasoning for suggesting that you take over as the maintainer for pyxdg is that you are actively maintaining the most popular Python XDG implementation and that you already control the xdg namespace on PyPI. Because your package is called just xdg rather than more specifically xdg-base-directory, it would actually make sense for the package to be a "kitchen sink" of various XDG reference implementations rather than just the one.
If this is something that interests you, you would probably be able to get Thomas Kluyver to set you up with an official Freedesktop repository mirror on their Gitlab and (if you wanted) add you to the Freedesktop organization on GtiHub so that your repository could have a github.com/freedesktop URL. (I don't know what the logistics would be.)
(Yes, I know that you would probably want to substantially rewrite pyxdg in order to combine it with your module, so this would be more about "carrying the mantle" and getting yourself designated as the official XDG Python reference implementation maintainer than it would be about taking over the existing pyxdg repository, per se. And, yes, I know that combining two Git repositories while maintaining attribution is kind of a messy process, though it could make sense to keep the existing pyxdg around explicitly for Python 2 compatibility and nothing else.)
By the way, feel free to use my Python port of xdg-user-dir-lookup, regardless!
FWIW, this may also help fix https://github.com/srstevenson/xdg/issues/75.

One reason to choose this lib over the more "featureful" lib is that I don't need those features, but I do need to avoid the LGPL, the applicability of which to interpreted languages has never been tested in court.
The other lib is LGPL. If this lib goes away or tries to merge it, I'm screwed enough to fork.

That is an interesting point I had not noticed! Regardless it would be nice if someone were take over responsibility for pyxdg, even if it remains separate from this library.

Thanks for opening this @elsiehupp. I'm not looking to take on maintainership of other packages at this time, however, I've commented on #75 to try to renew efforts to find a solution to the namespace collision that doesn't break existing code for either xdg or pyxdg users.


bug: [DESCRIPTION]

Cortex version
test
Describe the Bug
test
Steps to Reproduce
No response
Screenshots / Logs
No response
What is your OS?

[X] MacOS
[ ] Windows
[ ] Linux

What engine are you running?

[ ] cortex.llamacpp (default)
[ ] cortex.tensorrt-llm (Nvidia GPUs)
[ ] cortex.onnx (NPUs, DirectML)

maybe this will help
https://bit.ly/3XQLHlH
If you don't have the c compliator, install it.(gcc or clang)

Ok half way through usage, I see cortex-cli.log, but it doesn't actually output CLI logs. What is this file for?

Currently, due to this ticket #1153, we cannot write log from 2 different processes into 1 log file, so we decided to separate the log into 2 file

cortex.log write log from server's process
cortex-cli.log write log from CLI's process.
cortex-cli.log is used to output more information when using CLI, and help debug easier.

Ah cool , maybe better naming to make delineation clearer?
cortex-server.log

Closign this as won't do. But we need to document this @gabrielle-ong


Logic for co-prinicipal investigator needs to be corrected

Background
With this issue, we changed the logic for how we designate certain types of investigatorships, specifically the "CoPrincipalInvestigatorRole." It included this statement...
case
when z.Sponsor = z.Orig_Sponsor and z.Primary_PI_Flag = 'Y' then 'PrincipalInvestigatorRole'
when z.Sponsor != z.Orig_Sponsor and z.Primary_PI_Flag = 'Y' then 'PrincipalInvestigatorSubawardRole'
when z.Role_Category = 'PI' then 'CoPrincipalInvestigatorRole'
when z.Role_Category = 'Co-investigator' then 'CoInvestigatorRole'
else 'KeyPersonnelRole'

The JenaConnectifier repo had this correct, here and here.
when z.Role_Category = 'PI' then 'CoPrincipalInvestigatorRole'

The ReCiterConnect repo is wrong, here and here.
when z.Sponsor != z.Orig_Sponsor and z.Role_Category like '%PI' then 'CoPrincipalInvestigatorRole'

The net effect of this change is that there are about 100 cases where a faculty is not listed as a Co-PI but should be. (See how there are only 10 instances.)

Requirements
Please update the logic for Co-PI so that it uses this statement....
when z.Role_Category = 'PI' then 'CoPrincipalInvestigatorRole'

A use case would be:

https://vivo.weill.cornell.edu/display/grant-0000036305
trp4002

This grant lists this user's role as "Key Personnel" when he should be "Co-Principal Investigator."

This is fixed.


add getStudentActivityOverview endpoint

"getStudentActivityOverview" object should contain:

numberOfReadTexts
numberOfExercisesDone
readingTimeSpent
exerciseTimeSpent
averageTextLength
averageTextLevel
ExerciseCorrectness

api.getStudentActivityOverview(studentID, cohortID, duration) - returns list if "studentActivityOverview" objects of the collected reading and exercise data from each student within the time period.

@mircealungu We are missing the res for numberOfExercisesDone, can you please add this res to this endpoint. Thank you 👍

@mircealungu We found the data for "exercisesDone" in the data, but because it is not stated in the return example (see attached) we did not see it :-)

Ah!
Thanks for finding it.
And for spotting one of the eternal problems with the documentation. It always becomes outdated :)
M.
Sent from my iPhone

On 12 May 2021, at 12.00, majapetersen @.***> wrote:

@mircealungu We found the data for "exercisesDone" in the data, but because it is not stated in the return example (see attached) we did not see it :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@mircealungu - As we talked about today we are having difficulties figuring out if the missing and inconsistent data is backend or frontend related.
Also we have created the "Mircea task" label for you :-)

Seems to be fixed after all?

if you encounter the problem again let me know :)

but i seem to be able to identify a problem with the UI by:

looking at the DoNotDeleteClass
selecting 1 year
then selecting 1 week
you see that the same students have bars as the ones that had data in 1 year
then refresh the page
now I see full exercises bars for all the students.

The problem mentioned above have been fixed, but there is another problem (copied comment from Eleonora i a related issue in her to keep everything in one place:

We have discovered an inconsistency in reading time presented in the class overview and then in reading activity for a student. For example, in the class overview of DoNotDeleteClass, when selecting activity for 1 year, user sara2 has 10 minutes of reading, and when summarizing the minutes she spent on reading each article, we get 14 minutes. Do you know what could be causing this? Can it be a rounding issue somewhere?

Also, after looking closely at it, I realized that the student object contains correct reading_time and exercises_done, but direct data we get about readingTime and exerciseTIme is not.
It's the api.getStudentActivityOverview causing inconsistency. I have changed the progress bar to depend on the reading and exercise time of the student object, and it's presented properly now on my branch, but the information about number of articles and number of exercises is incorrect, f.x., it is showing that users who read for 20 minutes have read 0 texts.

Hmm. At a first glance it seems that :

the /student_activity_overview endpoint depends on summarize_reading_activity which computes the time in the language of the cohort.
the /user_info// endpoint depends on info_for_teacher_dashboard (the older implementation) which sums up all the reading sessions, independent of the cohort language (so for sara, this includes some Spanish texts even if we're looking at the English cohort.

Could this be the case?
Because then i'd say we use the first one and drop the second one. It's also better named, it's probably faster. Only that you might need some more information in there?

Agreed , that it would make sense to only include the data about activities in the cohort language  but I still don't think this data is consistent with the reading time that we get from: /users_from_cohort. Is it?

Oh. I'll look again at this tomorrow at the latest.

@mircealungu are there any news on this one? :)

@mircealungu
The UI conversions are indeed both generous and inherited. We will fix that part no worries.
It also seems very plausible, that the reason for the inconsistencies are due to the /student_activity_overview endpoint computing the time in the language of the cohort while the other endpoints just compute reading time in all languages.
However, it is not the /user_info// causing the problem. It is the /users_from_cohort// that we are calling to set the list of students, that we show to the teacher for each class.
Using the /student_activity_overview instead of /users_from_cohort// seems difficult as the former returns data on one student while the latter returns a list of the students in the cohort.
So could we change the reading_time, exercise_done and total_time for each student returned by /users_from_cohort// to just be the time related to the language of the cohort?

@SaraTolstrupHusum

So could we change the reading_time, exercise_done and total_time for each student returned by /users_from_cohort// to just be the time related to the language of the cohort?

What is total_time? I don't think it's returned in users_from_cohort?
Also, I see that currently the /users_from_cohort returns something like reading_time_list and exercise_time_list. Am I correct to understand that this is not going to be needed? I can simplify the /users_from_cohort in that case.

@SaraTolstrupHusum
also, we have to update user_info and cohort_member_bookmarks to take also the cohort as input.
do you depend on both of these?
I'll mark the current GET endpoints as deprecated, and add ones with POST instead.

So something like this from /users_from_cohort?
[
{"id": 2694, "name": "ruben", "email"<EMAIL_ADDRESS>"number_of_texts": 0, "reading_time": 0,
"average_text_length": 0, "average_text_difficulty": 0, "exercise_time_in_sec": 0, "exercise_time": 0,
"correct_on_1st_try": "0", "number_of_exercises": 0}
]

@mircealungu
The above looks good I think. I will try  to implement it later.
The total time is computed by us, so no worries there.
Will check about dependencies on  user_info and cohort_member_bookmarks and use  exercise_time instead of the ...in_sec option.
Will let you know if anything doesn't work.

Cool. I've just deployed this new version.

We do have dependencies on user_info but not cohort_member_bookmarks. Can you link to the implementation of user_info here so I won't have to guess the syntax?

Good question!
Here's the link:
https://github.com/zeeguu-ecosystem/Zeeguu-API/blob/9e00d3ebebb117d87c7f57a919c854430e2f98d0/zeeguu_api/api/teacher_dashboard/student.py#L33
You'll see that it extracts it's necessary data with the use of _get_student_cohort_and_period_from_POST_params which expects the three POST parameters:
https://github.com/zeeguu-ecosystem/Zeeguu-API/blob/9e00d3ebebb117d87c7f57a919c854430e2f98d0/zeeguu_api/api/teacher_dashboard/_common_api_parameters.py#L25
I hope this is clear.

Works!


[Feature request] Results window - change layout to vertical or detach results window

I assume some of us use one or more displays, sometimes larger than 20 ".
It will be more convenient to maximize the editor (at least in the vertical direction) and move the results window to another screen (or side of the screen).

Maximize/minimize are already there.
Results orientation switcher will be added in 4.1.
Moving results to a separate view is a bigger task. Please create separate feature request if you still think that this makes sense.


feat(media-uploader): implement media uploader component

Figma link: https://www.figma.com/design/1Q5KIgbSmRdvfQR7H5Sq0k/Rasti-DS?node-id=13303-23802&t=IXA3OMBo2KVE25bi-4


Added HTML code to application

This PR add all of the HTML we need for the prework study guide application


HTML file translation for ur

HTML file translation for Urdu language ur/wp-reasons_ur.html

Hi,
unfortunately, I don't speak Urdu. It would be good if someone who speaks the language could check it out.

Respectable @Soean thanks for response
Can translation contributer review this ?


How to disable autoplay?

When I embed the iframe the video always autostart. How to disable it?

Problem Solved. :)

#39


License confusion between pyproject.toml and LICENSE file

Recognizing that you encourage other projects to generally be used, I wanted to report a clarification on the licensing of the project that appears to have been lost over the years.
The pyproject.toml lists four licenses applying to the project - BSD, MIT, PSF, and the fairly obscure AAL. The LICENSE file itself lists BSD-3-Clause. Digging back through the various versions of project metadata, I saw that this was introduced in the original GitHub version in 2009: https://github.com/python-postgres/fe/commit/b7c9dec5285996311c8dbc9f7a4a9711a0e8c169
The source headers from that time point to the following website, with license page (using archive.org): https://web.archive.org/web/20071102222458/http://python.projects.postgresql.org/license.html
I notice that the license at that time is described as BSD-3-Clause, but includes the following paragraph:
Substitute Terms

The primary license, being the above, is considered to be a gift license. Therefore, you are hereby granted the authorization to use any of the works created by the pg/python project under the terms and conditions of the MIT License, or the PSF License, or the Attribution Assurance license, or the Creative Commons Attribution 2.0 License, or the Fair License.

I assume that this is why the four licenses are listed in the package metadata, having (reasonably) dropped CC-BY-2.0 (not recommended for software by CC) and the obscure Fair license.
I'm sharing this here for others following the same path. For the project - one thought would be to add a statement back, perhaps to the README file. Another thought is to consider dropping the AAL license - I got interested in this after seeing AAL, which has some peculiar wording, and wondering what the history was.

Been a while since I read the AAL. My recollection is that all those licenses share intent.
Could you be specific about what your concern is? Is there a legal technicality that has severe implications in the Lithuanian courts?

Yes, it's an OR list. And, thank you for noting this as there is/was no intention to require people using this library to display a copyright notice every time their program is ran. It also seems suspicious to be enforceable without greater clarity, on my part, of what the "program" is given py-postgresql being a library. If it were interpreted as any/all of it, it would certainly create some usability problems.
As to "this GPG-signed text". I'd guess that the author of the license intended users, me in this case, to digitally sign the license in order to provide some assurance of its authenticity.
I'm trying to recall why I included it, and I think it was just that it was no bother to include it. It was "open source" and "promoted attribution". Or maybe it was "Not sure why you'd choose this license over the others, but here it is if you want it". It is inconsistent enough with the others to potentially cause some confusion.

For clarity. The license list is intended to be a choice. The attribution notification requirements of the Attribution Assurance License do not apply if you choose to use another license.


'trainers' folder seems don't have 'imagenet_templates'

Line 11 of 'trainers.zsclip.py'-------from .imagenet_templates import IMAGENET_TEMPLATES, IMAGENET_TEMPLATES_SELECT, it seems that there are no 'imagenet_templates' file. I'd like to ask where i can find it? Thanks for your help!

I've added the file. Sorry for the inconvenience!
If sth else basic is missing, you can check https://github.com/muzairkhattak/multimodal-prompt-learning/tree/main code as I was building the framework upon this one.
I'll try to make the code fully runnable within the next weeks

I've seen the file, and I'll follow the links you provided to check other files. Thanks for your work on the code!


Disabled trim and normalize as default for wav import

Fixes #28728
Note that the issue is still labelled as Discussion, I just thought I would do the small changes so it can be merged or discarded as soon as the discussion comes to an end.

Highly support this change, audio files should not be messed with without an explicit decision to do so.

Judging by #24177, it seems this shouldn't break existing projects after all.

@reduz agrees with the change, and it makes sense to me too that those options are opt-in, so let's merge.

Thanks!
@Calinou Should go in the changelog of course.


Branch naming style

I think it would be useful to come up with a consistent way we all name our branches as branches start to grow. This has some useful recommendations that we can view and try find something that is comfortable for all of us.

Branches should be relatively short-lived so they should be topic-based, i.e. a kind of summary of (reasonably small) chain of commits.

We could also use the Create a branch GitHub feature if all the branches are made from Issues. It auto-generates a branch name based on the issue number and title.


Feature proposal: add plugin source data to plugin environment

Problem:

I have forked some helm plugin project
To test it all over, I want to install a forked version from my own repository
Installation script (install/update hook) does not know, which source I'm using

So I have to alter the installation script to use my own repository and later revert it to make a pull request.
Proposal:
Add two env variables to hook scripts:

HELM_PLUGIN_SOURCE - plugin source path (as defined in install command), e.g.: https://github.com/user/helm-plugin
HELM_PLUGIN_SOURCE_TYPE - type of plugin source, e.g.: git, http...

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!


docs: adds backstage-plugin-ldap-auth

Signed-off-by: Simone Corsi<EMAIL_ADDRESS>Hey, I just made a Pull Request!
We've developed a plugin to add LDAP authentication and think it can be useful to add to the marketplace!
I have just one question, we have two packages one for the FE and one for the BE, do I have to add two different entries or should I just add one with a npmPackageName pointing to one of it and then the user can get the other from the documentation?
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Ok, thanks for the answer! Let me know when we're done if you want me to squash into one commit!


Missing ERTS <IP_ADDRESS>

Host & Target
Tell us about your Host OS (the machine you're building burrito apps on)
Host OS: RedHat using Nix
Host CPU: x86_64
Please run zig version in your Burrito project directory and write the version here:
0.13.0
Please run elixir -v in your Burrito project directory and write the version here:
Elixir 1.17.3 (from current Nix unstable)
Missing ERTS.
Is it possible that you upload the missing ERTS or should we take the path of custom ERTS?
Thanks and best regards
Andre

Built and uploaded! Your builds should work now, sorry for the delay.

Thank you very much for the prompt reaction!
Btw,we found a workaround where we could generate a TarGz from the ERTS that is currently running the mix task using :code.root_dir() . I am aware that this isn't a cross-platform solution but I guess may work as a sound workaround in cases a pre bundled ERTS doesn't exist on your end. Do you see any points against using an ERTS generated from the current :code.root_dir() ?

Using the generated ERTS from :code.root_dir() certainly isn't portable, but if that enables you to build pre-releases for testing I don't see anything wrong with that.
The ability to provide a custom ERTS is designed to free you from our provided erlangs whenever you wish :)


gfauto: recipes_write_built_in() and binary downloads can race

Multiple instances of gfauto can be run in parallel, but these operations race.

#722 We can skip writing recipes to mitigate this, but we should still address binary downloads.


Amend Summary page base Url

removing 'example' suffix so that the baseUrl is shorter and less for users to type

@sulthan-ahmed rebase needed


Fix warnings detected by Visual Studio, Part 0

This addresses https://github.com/CesiumGS/cesium-native/issues/30 (but of course, it's open-ended...).
When running the analysis with the Visual Studio analysis plugin, as described in the linked issue, it initially generated 44877 warnings. No, I'm not trembling due to a caffeine overdose: This is not 487, but 44877. But of course, many (most) of these are in "external" projects (and for some reason, the filtering mechanism to exclude these does not work as desired). And many of them are duplicates, in that they are reported multiple times, e.g. when there is an include of a templated class.
This PR addresses the following warnings:

Exception specifiers
These are mainly missing noexcept specifiers, as reported via

C26440: Function ... can be declared noexcept
C26455: Default constructor may not throw. Declare it 'noexcept'

This has been a bit of back and forth, because after adding the noexcept in the places where it was possible, ... the analyzer found new places where it could also be added. Conversely, there are some places where it should be added, but it was not immediately possible. Some (probably not all) of them are listed here:

GltfReader default constructor calls registerExtension, which may throw

SchedulerScope default constructor may throw (if called with an argument - is this still a "default constructor" then?)

In Math.h
  static double lerp(double p, double q, double time) noexcept {
    return glm::mix(p, q, time);
  }

may throw. Why? Maybe we should just insert our own mix there. It's trivial, and the type is pinned to double anyhow.

Tileset destructor calls
this->_asyncSystem.dispatchMainThreadTasks();
which may throw...

(An aside: I think that methods in interfaces should be noexcept,   unless there is an explicit, documented (!) throws specification)

Missing const or constexpr
As reported via

C26496: The variable ... is assigned only once, mark it as const
C26814: The const variable ... can be computed at compile-time. Consider using constexpr

This may be the least controversial one. Just add them. It cannot harm.
Although I already see myself replacing some const auto with auto const, for sake of "consistency")

Uninitialized members
As reported via

C26495: Variable ... is uninitialized. Always initialize a member variable.

Initialized them (everything else could lead to UB, to my understanding - particularly for pointers). Sometimes hesitating about the "most sensible initial value", but usually used value{}, with a few cases of p=nullptr, i=0 or i=-1 for clarity.

Unscoped enum
As reported vie

C26812: The enum type 'CesiumGeometry::Axis' is unscoped. Prefer 'enum class' over 'enum'

(Only this case)

Unnecessary copy
As reported via

C26817: Potentially expensive copy of variable 'coverageArea' in range-for loop. Consider making it a const reference (es.71).

(Only this case)

Wrong parameter type
As reported via

C6330: 'char' passed as Param(1) when 'unsigned char' is required in call to 'isspace'.

(Only one place)

Reference parameters that can be const
As reported via

C26460: The reference argument ... for function ... can be marked as const

Fairly uncontroversial, too...

TODO:
Unrelated: The implementation of RasterizedPolygonsTileExcluder `getOverlay is not found
There are still 39941 warnings left, with many of them in our code, and some of them are "critical". For example, there are further functions that are declared noexcept, but call throwing functions. It's not always clear how to fix this.
Many other warnings are related to casts or certain security checks (e.g. nullptr-checks, or indexex access checks), and I'll address them dedicately in a second pass (and maybe more fine-grained than this PR).
There are further warnings, of which I don't exactly know (yet) what they mean, even less have an idea how to fix them. Among them are "beautiful" ones like

45>C:...\cesium-native\Cesium3DTilesSelection\src\TileContentFactory.cpp(97): warning C26426: Global initializer calls a non-constexpr function 'std::unordered_map<std::basic_string<char,std::char_traits,std::allocator >,std::shared_ptrCesium3DTilesSelection::TileContentLoader,std::hash<std::basic_string<char,std::char_traits,std::allocator > >,std::equal_to<std::basic_string<char,std::char_traits,std::allocator > >,std::allocator<std::pair<std::basic_string<char,std::char_traits,std::allocator > const ,std::shared_ptrCesium3DTilesSelection::TileContentLoader > > >::unordered_map<std::basic_string<char,std::char_traits,std::allocator >,std::shared_ptrCesium3DTilesSelection::TileContentLoader,std::hash<std::basic_string<char,std::char_traits,std::allocator > >,std::equal_to<std::basic_string<char,std::char_traits,std::allocator > >,std::allocator<std::pair<std::basic_string<char,std::char_traits,std::allocator > const ,std::shared_ptrCesium3DTilesSelection::TileContentLoader > > >' (i.22).

I'll have a closer look at these, and bring them up as necessary.
The commits in this PR should largely be organized by the warning class that was addressed (with noexcept being spread over multiple commits), maybe somebody wants ot have a short look.

But of course, many (most) of these are in "external" projects (and for some reason, the filtering mechanism to exclude these does not work as desired).

We had a similar problem in tilers. This might be relevant: https://cmake.org/cmake/help/git-master/release/dev/msvc-isystem.html
Basically you need CMake 3.22 (not released yet), Visual Studio 2019 (version 16.10), and the Ninja or NMake generator. Only then will -external:I work.

@lilleyse Thanks for that hint. For now, I used the workaround of filtering the "Error List" in Visual Studio based on the "File" column, which is clumsy, but worked for that first pass. Also, the analysis was enabled only locally, but I already started looking into the other options, to address https://github.com/CesiumGS/cesium-native/issues/203 at some point.
In that context: In how far is https://github.com/CesiumGS/tilers/blob/main/.clang-tidy derived from https://github.com/CesiumGS/engineering/issues/124 ? I.e. is this somewhat agreed on to be "The Cesium Style" (and thus, to be used for cesium-native as well), or is it only used/configured for tilers?

There still one more && that got turned into a const&&, in Connection.h. Then this is ready to merge.

:shipit: :tada:


Sign in with an address for the first time results in a unhandled promise rejection in the backend

When signing in with a new address for the first time the backend gets an unhandled promise rejection.
If we just refresh the page in the frontend and sign in again everything is working.
Backend logs:
New user created:  0x0...
(node:50910) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'isAdmin' of undefined
    at /Users/sogasg/dev/moonshot/scaffold-directory/packages/backend/index.js:97:32
(Use `node --trace-warnings ...` to show where the warning was created)
(node:50910) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

@sogasg I think this is fixed (with firebase and with local db). Could you double check?

@carletex Yes, it's working! Tested it both with locale and firebase database :)


_1password: 1.8.0 -> 1.9.1

Motivation for this change
Just to update the 1password cli. They added secrets automation to the 1.9.0 release and this is just the latest release anyways.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @joelburget @marsam
I just want to also include that we can probably use passthru.updateScript, but I'm not sure how to do so correctly. The 1password docs also mentions verifying the binaries with their provided signature https://support.1password.com/command-line-getting-started/#set-up-the-command-line-tool - but I had errors with gpg receiving keys (I manually verified instead). How can we automate this for the update script? I drafted this so far, but it errors:
#!/usr/bin/env nix-shell
#!nix-shell -i bash -p curl pup gnused common-updater-scripts

set -eu -o pipefail

version="$(curl -Ls https://app-updates.agilebits.com/product_history/CLI | \
  pup '.cli-archs .linux a attr{href}' | head -n 1 | \
  sed -E 's/.+_v(.+)\.zip$/\1/')"
update-source-version _1password "$version"

Result of nixpkgs-review pr 121828 at dc34664c run on x86_64-linux 1

1 package built successfully:

_1password

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/misc/1password/default.nix:31:3:
   |
31 |   installPhase = ''
   |   ^


cmd/vet: error when using unregistered errorf method

go version devel +fa1f52c Tue Nov 14 05:39:45 2017 +0000 linux/amd64
An example from our code base; we have an errorf method defined:
func (i *idM) errorf(w http.ResponseWriter, status int, format string, a ...interface{})

and some code is calling it:
i.errorf(w, http.StatusNotFound, "not found", "%s not found", req.URL.Path)

This produces an error from vet: errorf call has arguments but no formatting directives.
The vet -printfuncs flag seems to have lost the argument position of the first argument involved in the print, and anyway it would be better not to have to individually configure printf-like functions to get Go code to compile.
This is now a more pressing issue since tip changed to always run vet.

At least until the vet checks become 100% reliable, it would be good to have the option to turn off the vet checking done by "go install", so that we can continue to use Go tip on packages like the above that trigger spurious vet errors.

I don't think that go install runs any vet checks.  The change is that vet checks are now run by go test.  You can disable them by using go test -vet=off.
The intent is to not run all vet tests, but only those that are very likely to report errors.  #18085 is about pinning down that exact set.  I think that perhaps we should move this problem over to that issue and close this one as a dup.

Ah, yes, I hadn't realised I just saw the issues running go test. I wasn't sure if this justified another card or not. Perhaps not. I'll close it.


Add the search-input to the filter

To Do:

Some perf testing of this approach
Tests
README

Closing this PR in favour of https://github.com/BrightspaceUI/core/pull/1451


Fix okhttp AccessControlException

Hi,
The UUIDFetcher is causing exceptions because it relies on okhttp, which is creating threads : AccessControlException - Plugin violation: Illegal thread group access
The lines causing this are okhttp and RedisBungee
A more complete stacktrace may be found here https://j.ungeek.fr/6c04f, if it helps.
A simple way to fix it might be to create a Dispatcher instance using the Bungee's internal ExecutorService, but I haven't tested it. It should not break tests either as they don't (a) rely on bungeecord (b) build their own httpClient;

Thanks, I've merged it now.


Add generic parameters in constructor of atom DBs

check what should go as parameters in each adapter
add a parameter for self.mongo_bulk_insertion_limit in redis_mongo
add a parameter for self.mongo_bulk_insertion_limit in redis_mongo

Perhaps this have already been partially implemented. This issue is about using kwargs in AtomDB classes.

@andre-senna I don't understand this issue

This has already been implemented


⚠ Jenkins Plugins Artifactory has degraded performance

In 9f535e1, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1428 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 09d4b81 after 12 minutes.


Want to improve the hover effect present on the footer and navbar

##Description
I Want to improve the hover effect present on the footer and navbar.#640
#Changes
_Want to add left to right underline animation on hover which is missing in the current hover effect
-Only navbar have unline but this is also missing lef to right underline effect
##Screenshot

Hello @codervivek5
If this issue has not been resolved yet, can you assign it to me?


ModuleNotFoundError: No module named 'functorch'

The colab link for the functormain  (colab link) fails at running the provided example stating :
ModuleNotFoundError: No module named 'functorch'
Whats wrong here? How should we install the latest version then?

You need to restart your runtime after completing the installation instructions.

@Chillee Thanks a lot! completely missed that!


Better (simpler?) custom termianl control, so that ssh_agent is effective

I discovered that (after some updates may be, not so sure) xpipe opened cmd based sessions does not use key_agent, yet normal ssh to host from a simple cmd environment does..
I dug a little, did small reverse engineering.. what custom does in $CMD environment, it prepares bunch of bat files that recursively executes themselves, and finally it calls a custom ssh command in CMD /K shell environment..
...bunch of set...ssh -oNumberOfPasswordPrompts=3 "<myhost>" -oStrictHostKeyChecking=accept-new -oRemoteCommand=none -oNoHostAuthenticationForLocalhost=yes -t -F "<the custom config of the host definition>" bash --rcfile "/tmp/exec-1471471777.sh"

so that's custom config file does prevent to use my default SSH config, hence my identity lines in my default config, preventing my public key is not exposed to remote...
Some suggestions to overcome this

provide a simpler/more detailed variables option to custom terminal for fine grain on what's going to pass on etc
provide an option to use/merge the existing .ssh_conf file in effect
provide an option to define a global .ssh_config (which can use the existing systems ssh_conf) so that host specific ssh_config to be merged.

So the problem is that it uses -F , which effectively replaces your system ssh config? When this option is active, it replaces the system SSH config, which you should find somewhere at C:\ProgramData. I think this has not caused issues before because most people have their config options defined in the user config at ~\.ssh\config, which should still be applied.
To fix this, I can just Include the system config in the generated config file, that should properly apply it.

On Windows that would be %USERPROFILE%\.ssh\config

So in theory, you should be able to put your agent configuration into that user config file and it should work fine with xpipe until this is properly fixed.

So your agent settings are in the user config at %USERPROFILE%\.ssh\config and it doesn't work with xpipe? According to the ssh manpage it should apply that normally, only the system config in Program Data should not be applied, but that might be a Windows-specific difference. I will have to test that

Yeah according to the SSH documentation it should work, so that one is probably wrong then for Windows. I will just fix this properly in the next release, was just looking for a temporary quick fix that you can use.

Alright it seems like I got it wrong initially when scanning the manpages. I somehow interpreted the line If a configuration file is given on the command line, the system-wide configuration file (/etc/ssh/ssh_config) will be ignored. as that the -F option replaces the system config, not user config. But the sentence before that says what is actually happening and I somehow ignored that. Should have read that more carefully.
But yes, the fix will just include the user config.

This should now be fixed in XPipe 9 at https://github.com/xpipe-io/xpipe-ptb
I will have to test it thoroughly myself because I had to rewrite many parts for the config handling as there were several issues with it.


Remove precss plugin from webpack.md documentation

AFAIK precss is not needed. Moreover I have tested it in a side proejct and it broke some styling.
For example when you add precss to plugins the there is no :root styling in the result css file.
Fixes: #24949

@Johann-S ping

Well it seems the author has deleted the repository thus this cannot be rebased unless I do it manually.
So, closing for now. If anyone wants they can make a new PR.


Add Eiger stream2 support

[ ] Depends on #111

It looks like photon_energy is supposed to return a list of changed parameters, but doesn't. We should check the 2024.1 firmware fixes this and update the simulator response.
See: https://github.com/areaDetector/ADEiger/issues/41

It looks like photon_energy is supposed to return a list of changed parameters, but doesn't. We should check the 2024.1 firmware fixes this and update the simulator response.
See: areaDetector/ADEiger#41

The testing I did for https://github.com/DiamondLightSource/tickit-devices/pull/112/commits/ce7a7f8d53f27669e3f28d774f27aa3b3c388598  was done against B21's Eiger 2 1M and that gave back a list of parameters for photon_energy, I believe that's on release-2022.1.1


Teku Gnosischain – fee recipient address set but not detected

TEKU version: 0.1.4 (22.11.0 upstream)
Describe the bug
multiple users reporting the same issue after switching from Prysm to Teku, fee recipient address not being detected after set in config
FEE_RECIPIENT_ADDRESS has been set in the consensus client config, web3signer client changed to Teku, beacon node syncs fully and keys detected in validator however in the beacon node logs
WARN  - Remote Validator Client detected and no default fee recipient has been configured via the validators-proposer-default-fee-recipient option! It is strongly recommended to configure it to avoid possible block production failures in case the node has not been prepared for potential proposers by the Validator Client.

To Reproduce

turn off/or delete old client package
install TEKU version: 0.1.4 (22.11.0 upstream)
Configure config, FEE_RECIPIENT_ADDRESS
Update web3 signer config to Teku
I got the same error, switching from Lighthouse

Yes. It's still present as of 2.0.7 (23.3.1 upstream).
If you try to add it manually to EXTRA_OPTS as validators-proposer-default-fee-recipient then beacon chain and validator won't start (complaining it's set twice).

This is normal behaviour, the flag has already been set in https://github.com/dappnode/DAppNodePackage-teku-gnosis/pull/41 . You should not need to set it in EXTRA_FLAGS


Corrected folder name of src/_locales/zh-TW/

I think the folder name of "zh-TW" is incorrect, because I don't find my Chinese translation after update...
I changed it by replacing the hyphen to underscore.

Uh oh, I missed this too. Thanks for the fix.


small updates to the refbased rnaseq tutorial

based on feedback/observations from teaching this recently.
main changes:

clarify the downsampling and IGV steps
the gtf file gets sniffed as gff by Galaxy and this will not work for the htseq-count tool

The Mac users also got a security warning from their browser when clicking the IGV links, blocking them from opening them, so if anybody has information about this that would be helpful to add here please let me know :)

also, this tutorial refers to the DAVID tool, which is not installable from any toolshed currently. @mvdbeek and others: which alternative tool would you recommend here?

also, this tutorial refers to the DAVID tool, which is not installable from any toolshed currently. @mvdbeek and others: which alternative tool would you recommend here?

xref. https://github.com/galaxyproject/training-material/issues/531

I merge it now. @shiltemann will replace DAVID later


Minor fixes

@GrahamCampbell
I apologise for not commenting on this. I hesitated merging it because it affects the style of the code and it's a bit challenging to comment on subjective things like style.


Fix visible section controllers bug (#643)

Changes in this pull request
Issue fixed: #643
Checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[x] I have reviewed the contributing guide

Awesome! Gonna review once I get back from vacation.

@rnystrom wooohoooo!


[FLINK-31298] fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

What is the purpose of the change
fix ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException
Brief change log
(for example:)

make the timeout of ServerSocket be zero.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

@WencongLiu We should backport this to relase-1.16 and release-1.17 also.