TSC crashes on <30 line project

Repro case: https://github.com/bcherny/tsoption/blob/7ae2d5d/index.ts (tree)
Repro steps:

Git pull tsoption@7ae2d5d
Run npm install
Run ./node_modules/.bin/tsc

Node version: 6.9.5
TypeScript version: 2.4.1
Error output:
$ ./node_modules/.bin/tsc

<--- Last few GCs --->

   31467 ms: Mark-sweep 1339.6 (1437.6) -> 1339.6 (1437.6) MB, 1460.1 / 0.0 ms [allocation failure] [GC in old space requested].
   32931 ms: Mark-sweep 1339.6 (1437.6) -> 1339.6 (1437.6) MB, 1463.8 / 0.0 ms [allocation failure] [GC in old space requested].
   34405 ms: Mark-sweep 1339.6 (1437.6) -> 1340.7 (1421.6) MB, 1473.7 / 0.0 ms [last resort gc].
   35885 ms: Mark-sweep 1340.7 (1421.6) -> 1341.8 (1421.6) MB, 1480.1 / 0.0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x11cf6b9cfb51 <JS Object>
    1: getReturnTypeOfSignature [/Users/bcherny/Sites/tsoption/node_modules/typescript/lib/tsc.js:~27029] [pc=0x11e2ac7e930b] (this=0x11cf6b9e6f19 <JS Global Object>,signature=0x35a7fc95c541 <a Signature with map 0x210c46c5c571>)
    2: getReturnTypeOfSignature [/Users/bcherny/Sites/tsoption/node_modules/typescript/lib/tsc.js:~27029] [pc=0x11e2ac7e84ad] (this=0x11cf6b9e6f19 <JS Global Object>,s...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [/Users/bcherny/.nvm/versions/node/v6.9.5/bin/node]
 2: node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/bcherny/.nvm/versions/node/v6.9.5/bin/node]
 3: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [/Users/bcherny/.nvm/versions/node/v6.9.5/bin/node]
 4: v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [/Users/bcherny/.nvm/versions/node/v6.9.5/bin/node]
 5: v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [/Users/bcherny/.nvm/versions/node/v6.9.5/bin/node]
 6: 0x11e2ac2079a7
Abort trap: 6

Changing type declaration to interface can solve this.
interface MonadNone<T> {
  ap<U>(option: Some<(value: T) => U>): None<U>
  chain<U>(f: (value: T) => Some<U>): None<T>
  chain<U>(f: (value: T) => None<U>): None<T>
}

interface MonadSome<T> {
  ap<U>(option: Some<(value: T) => U>): Some<U>
  chain<U>(f: (value: T) => Some<U>): Some<U>
  chain<U>(f: (value: T) => None<U>): None<T>
}

interface None<T> extends MonadNone<T> {
  flatMap<U>(f: (value: T) => Some<U>): None<T>
  flatMap<U>(f: (value: T) => None<U>): None<T>
}

interface Some<T> extends MonadSome<T> {
  flatMap<U>(f: (value: T) => Some<U>): Some<U>
  flatMap<U>(f: (value: T) => None<U>): None<T>
}

export type Option<T> = Some<T> | None<T>

export function None<T>(): None<T> {}
export function Some<T>(value: T): Option<T> {}

export let Option = <T>(value: T | null) => {
  if (value == null) {
    return None<T>()
  }
  return Some(value)
}

This problem is probably caused by caching. Anonymous object type will not be cached, so some recursive signature like (f: (value: T) => Some<U>) will incur exponential anonymous type instantiation. Thus OOM crash.

This seems like a big problem. TypeScript either needs to enforce a preferred type declaration scheme or support all type declarations equally. It's not enough for the official response to be, "just use interfaces". That makes writing TypeScript a guessing game.

@fruchtose at the risk of being obvious, us crashing is not a way of us telling you not to write a particular piece of code :wink:

@RyanCavanaugh, I apologize if my response comes across as harsh. It's an issue that's started to crop up lately in my TS work. While it it's frustrating to have an issue to point to, it's a bit of a relief as well to identify a possible root cause.

My team is also facing the same issue. Devs are getting annoyed, since we can not run incremental builds for TDD any more. Unfortunately it is closed source. But here is what i can tell so far.

The error is same as above FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Occurs with typescript 2.4.x and also 2.3.x
We are using webpack
checked this guide

allowJs is false already
noImplicitAny is false already
transpileOnly is false already

When i search the project for type declarations, i can find about 134 matches. According to the comments above, those types wont be cached and may lead to out of memory. I tried to declare those types differently.
Some simple types can not be rewritten. Those look like
export type BrandColorName =
  "" |
  "dark" |
  "primary" |
  "secondary" |
  "success" |
  "warning" |
  "danger" |
  "info"

Majority of our types have been changed from this
import { AbstractControl } from "@angular/forms"
export class MyModel {
  // ...
}
export type MyModelForm = { [K in keyof MyModel]: AbstractControl }

to this
import { AbstractControl } from "@angular/forms"
export class MyModel {
  // ...
}
// next line is changed
export interface MyModelForm = { [K: string]: AbstractControl }

unfortunately this did not help. I still can get into the out the of memory crash. I can not say if the changes helped at least a bit, since i have no idea how to measure the compilers workload. I would appreciate any guide or hint how i could do that.
Even if the changes would have helped, i'd still prefer the type declaration like it was before the change since it helps us in 3 ways

allows us very easily to follow a convention where several types must have the same keys
no need to declare same keys across several types, which makes 1 a no brainer
intellisense, which is now obviously missing on the changed types

@giniedp Probably your problem is deeper than OP's problem.
It seems that you have a quite large project. My suggestion is:

split your project into smaller sub-project so that you can compile fewer files in one time
deleting your code until TS stops OOM, this might help you find the root cause of crashing
set node's --max_old_space_size. This is the last resort that you can permit node to consume more memory.

Hope this helps.

@giniedp Also see https://github.com/Microsoft/TypeScript/issues/13538.

@HerringtonDarkholme Confirming that changing every instance of type to interface fixes the issue. However, as that is a workaround, have you guys thought about what it would take to fix the underlying issue?

just to let you know. If i separate the typescript compilation from webpack then the bare tsc compilation runs in 13 seconds and only reaches 500MB of memory usage. Incremental compilation is then about 9 seconds. So that part actually looks good. Webpack is the one who does the heavy lifting while bundling.

@bcherny Here are some notes from investigating your repro. The way that compilation fails on your repro is as follows:
When type checking export let Option = ..., the return type is inferred as the union of the return statements: None<T> and Some<T>. But return type inference has subtype reduction turned on in order to produce a nicer type in the presence of subtyping (specifically, to avoid Base | Derived1 when Base would do). This means that the compiler checks whether None<T> is a subtype of Some<T>. It's not, but it's close, which means that the compiler has to examine the structure of the whole type to find out why. You could annotate the return type; it cuts off all this work. But in real usage, it would be just as bad to mistakenly assign a value of type None<T> to one of Some<T>, so an annotation isn't a real solution.
Eventually, compilation gets stuck in a loop between None.flatMap and MonadNone.chain. After it checks that the parameters of each are assignable to the other, it has to examine the return types. The return types are None<T>, but T is fresh each time, so it just loops until it hits the depth limit, over and over again, bouncing a little back up before having to check the rest of each freshly generated type.
There is a fix in master that improves relationship checking for generic types, but it doesn't apply to type aliases. However, even extending that fix to type aliases doesn't prevent the oomemory crash. I think that's because the type argument is not a simple type variable. It's (value: U) => U, and right now function types are not cached, so each (value: U) => U is unique per recursion in the relationship check. I believe @ahejlsberg is looking at caching function types; I'll report back once he has something ready to try so that I can combine my fix and see whether together they help.

Not sure if this is covered here or elsewhere already, but a similar error is thrown by this code:
interface A<B = A> {
  a: B
}

[0] RangeError: Maximum call stack size exceeded
[0]     at resolveNameHelper (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:27493:35)
[0]     at resolveName (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:27491:20)
[0]     at resolveEntityName (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:28152:26)
[0]     at resolveTypeReferenceName (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:32960:20)
[0]     at getTypeFromTypeReference (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:33043:30)
[0]     at getTypeFromTypeNode (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:33904:28)
[0]     at getDefaultFromTypeParameter (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:32189:66)
[0]     at getMinTypeArgumentCount (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:32470:26)
[0]     at getTypeFromClassOrInterfaceReference (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:32875:44)
[0]     at getTypeReferenceTypeWorker (/Users/bcherny/Sites/mousepig/client/node_modules/typescript/lib/typescript.js:32990:24)

@bcherny No, that's an unrelated problem, I will open a new issue.


global: invalid copyrights years

Problem:
Some files have copyright years in the past and don't include 2017 even thought they were created that year.

I think this can be closes since we have changed the license and updated the headers.


Add [Stellarlogy stellarlogy.com] #issuer GBFE66…UFML5N

Address: GBFE66R77SPV2XOBSVGDSAHLBY5GCMYOE6G6UMCN47RNYWTHZJUFML5N
Tags: issuer
Title: Stellarlogy  Domain: stellarlogy.com
Requested by @stellarlogy

Please add the issuer

This has been added to the earlier same request.
https://github.com/stellar-expert/public-directory/issues/596


Auto Morph to Event Sub-Process by changing Start Event Type

Given a Sub-Process with a None Start Event. When I morph the Start Event into a different Start Event type, e.g. a Message Start Event, I would like the Sub-Process to be auto-morphed into an Event Sub-Process.
 The resulting model had half a dozen Event Sub-Processes. In such an expensive meeting every click saved results in more valuable discussion time.
Many customers are also asking how they can create an Event Sub-Process because it is not intuitive.
Furthermore, a 'normal' Sub-Process with a Start Event other than a None Start Event is a BPMN Syntax Error. Usually, the modeler is quite good at preventing them, but here is a loophole to create an invalid model.
Consequently, we would auto-morph back into a normal Sub-Process when the Start Event is morphed into a None Start Event.
Auto-morphing the Start Event, when the Sub-Process is morphed, would also be nice. However, morphing to an Event Sub-Process would require a sensible default auto-morph type for the Start Event, e.g. Message Start Event.
Chaining this with #914 would be perfect, i.e. Drawing a Message Flow to a Sub-Process with None Start Event makes it an Event Sub-Process with a Message Start Event.
Would this be an easy-pick for a pull request?

This would be implemented as a behavior that implicitly replaces the sub-process after replacing the event. Not an easy pick but doable.

I still wish we had this literally every time I create an event sub-process. The only thing that eases the pain is that all the extra clicks have kind-of gone into muscle memory by now ;-)

But beginners can obviously not rely on muscle memory and may have a hard time even finding out how to create their first event sub-process if they are like me focusing on the event-type first and not caring about BPMN requiring a dotted line around the sub-process.

Thanks for bringing this up again. It would solve some issues we have currently, including the fact that certain things you can model today are actually illegal:

We want to prevent illegal intermediate steps, and assist the users at the same time

What is clearly visible in our existing behavior:

We explicitly limit what the users can do (rather than auto-morphing)
Changing to an event-sub-process is a 2+ step operation (rather than one)


Add a build script

All the tutorials I'm seeing focus on compilation, build is probably a misnomer in this case, it really should be called tests.sh (will happily do this). Does it still make sense to use a makefile? Do you know where to find documentation that focuses on this aspect of a makefile? Everything I'm seeing focuses on the compilation aspect, i.e. here's a set of source files you need to compile for this step.

It would look something like this (totally untested):
PLATFORM="platform=iOS Simulator,OS=10.1,name=iPhone 7"
SDK="iphonesimulator10.1"

.PHONY: all lint test carthage

lint:
    pod lib lint --allow-warnings

test:
     xcodebuild clean test -destination "$PLATFORM" -sdk "$SDK" -project tests/PINCache.xcodeproj -scheme PINCacheTests ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO | xcpretty -t; test ${PIPESTATUS[0]} -eq 0

carthage:
    carthage build --no-skip-current

all: lint test carthage

... and then you would invoke different targets as make lint or make lint test or make all.


How to avoid crash when NetworkImage fetching a bad url?

I have checked url == null or url.isEmpty ,but I don't know how to check the image is exsist.

Can you please provide more information?

output of flutter doctor -v
the error message in the crash output
the code that results in that crash

I have the same problem.The follow code is a part of my log.
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════ The following assertion was thrown building DayItem(dirty): 'package:flutter/src/painting/image_provider.dart': Failed assertion: line 406 pos 16: 'url != null': is not true.


[improve][common] Add thread name for RateLimiter.

Contribution Checklist
Motivation
Add thread name for RateLimiter
Documentation

[x] doc-not-needed

Matching PR in forked repository
PR in forked repository: https://github.com/Technoboy-/pulsar/pull/11

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e420c6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #18013   +/-   ##
=========================================
  Coverage          ?   27.37%
  Complexity        ?     3568
=========================================
  Files             ?      393
  Lines             ?    43418
  Branches          ?     4462
=========================================
  Hits              ?    11884
  Misses            ?    29684
  Partials          ?     1850

Flag
Coverage Δ

unittests
27.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


feat(map_loader): add waypoints flag

Description
The change by https://github.com/autowarefoundation/autoware_common/pull/252
In the above PR, use_waypoints is defined and this PR uses it. Please see the above PR in detail.

Tests performed

simple planning simulator works.
Effects on system behavior

The centerline is treated as waypoints inside the Autoware's implementation.
As a result, the centerline will be connected to the planned path smoothly, and fix several limitations described here
Interface changes

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 Cloud you please add use_waypoint parameter to the schema file?

@SakodaShintaro @YamatoAndo
Thank you for the review!
I fixed the schema json.
https://github.com/autowarefoundation/autoware.universe/pull/7480/commits/1f908fa1c4885b7d03c95c56432c70d5e9021fb5


Update to axum 0.6.0

Resolves #345

failures:

error: doctest failed, to rerun pass `-p utoipa-swagger-ui --doc`
---- src/lib.rs - (line 93) stdout ----
error[E0599]: the function or associated item `new` exists for struct `Router<B>`, but its trait bounds were not satisfied
  --> src/lib.rs:105:25
   |
15 |  let app = Router::<B>::new()
   |                         ^^^ function or associated item cannot be called on `Router<B>` due to unsatisfied trait bounds
   |
   = note: the following trait bounds were not satisfied:
           `B: Clone`
           `B: Sync`
help: consider restricting the type parameters to satisfy the trait bounds
   |
13 |     B: HttpBody + Send + 'static, B: Clone, B: Sync
   |                                 ~~~~~~~~~~~~~~~~~~~

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
Couldn't compile the test.

failures:
    src/lib.rs - (line 93)

@juhaku I believe it should be fixed. Wanna poke the CI button?

Sure


[type:polish] No need to convert args to string pass to Lua script

No need to convert args to string pass to Lua script

Codecov Report

Merging #5059 (9db7ffa) into master (2088df1) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5059      +/-   ##
============================================
- Coverage     63.31%   62.96%   -0.35%
+ Complexity     8549     8498      -51
============================================
  Files          1221     1221
  Lines         36367    36346      -21
  Branches       3328     3324       -4
============================================
- Hits          23025    22887     -138
- Misses        11454    11574     +120
+ Partials       1888     1885       -3

Files Changed
Coverage Δ

...iter/algorithm/ConcurrentRateLimiterAlgorithm.java
37.50% <ø> (ø)

...in/ratelimiter/algorithm/RateLimiterAlgorithm.java
0.00% <ø> (ø)

...imiter/algorithm/AbstractRateLimiterAlgorithm.java
100.00% <100.00%> (ø)

...r/algorithm/SlidingWindowRateLimiterAlgorithm.java
100.00% <100.00%> (ø)

.../plugin/ratelimiter/executor/RedisRateLimiter.java
86.36% <100.00%> (-0.60%)
:arrow_down:

... and 54 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Integrate ngX-Rocket as a JHipster module for a fullstack experience

I had the occasion to talk with the creator of JHipster recently, and it seemed a good idea to integrate ngX-Rocket as a JHipster module: we would generate the frontend, and JHipster would take care of the backend, it's a win-win 😎
The integration should not be that difficult at first view:

The complete JHipster frontend would be replaced by ngX-Rocket (it's already supported)
They use Yeoman composition, like our addon system so basic integration should be straightforward.
The integration does not need to be feature complete: by the own words of its creator, some JHipster generations tools are overkill, like the entity part for the frontend. We should just concentrate on the basic: integrate with the build, use their rest API and plug-in authentication.

I propose that we advance on this by steps:

[ ] Step 1 - POC: Make the minimum changes to make ngX-Rocket a valid JHipster module that replace their frontend, that works with their build system, in a separate branch.
[ ] Step 2 - API integration: Make the minimum integration work to plugin with their backend APIs (home rest service example and authentication). At this point a first release as a JHipster module could be proposed.
[ ] Step 3 - Polish integration: Add missing templates (#186) and integrate signup/reset password methods from authentication service with their backend

Any comments/help on this welcome!

Is back-end integration still part of the scope of the project? I feel like we barely keep up with changes on the web side already (and by "we", I really mean you @sinedied and @captaincaius 😸). Maybe we should accept that this is not the core of the project.
Of course maybe @ludovicderochethales has something waiting on his shelves, let us know in that case.
I guess this comment also applies to #26 and #156.

Is back-end integration still part of the scope of the project?
It is definitely, and will be part of my focus with my upcoming next position 😉 I've already tested the fullstack integration as part of an internal company generator based on ngx, and so far it's working well ^^
In the next months I plan to prototype simple backend integrations for C#, Java (not using JHipster) and Node.js, as well as using pre-made docker images for hosting only deployments, we will see how it goes! The tricky part as always will be to document all of these 💪


Add support for head-as-boolean

When enabled, all HEAD operations will return a Success field in their
response envelope.  For HTTP status >= 200 and < 300 Success will be set
to true.
For operations that don't model header responses, return a
BooleanResponse response envelope.
Update codegen for latest azcore and armcore.
Consolidated some checks into a single byValue flag.
Removed some duplicated code.
Updated autorest.testserver to latest version.

Fixes https://github.com/Azure/autorest.go/issues/498

/azp run


Add notarize action

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context
This pull request adds the notarize action from zeplin/fastlane-plugin-notarize, as discussed in https://github.com/zeplin/fastlane-plugin-notarize/issues/22. 🍻
Description
Notarize action uploads an app to Apple's notarization service, querying the result periodically until it's complete—which currently takes around 2 minutes. In case of success, it staples the app with the notarization ticket. In case of failure, it prints the log file listing all the issues.
Note that tests are still missing, cheers!

Fastlane needs a category for the docs, which CI is complaining about right now:
Unknown action category 'undefined', must be one of testing, building, screenshots, project, code_signing, documentation, beta, push, production, source_control, notifications, app_store_connect, misc, deprecated
Definition looks like this:
https://github.com/fastlane/fastlane/blob/34105dde4e26d3f3c3f28a46f4de091894d30048/fastlane/lib/fastlane/actions/sh.rb#L66-L68
Probably code_signing is the most appropriate one? Not sure.

code_signing makes sense, added it!


Use mdjs-layout

WIP for now, but will continue later. @m4dz if you wanna to continue yourself, let me know please.

@m4dz this is almost ready, I thinkg dockit-core needs some polishing, because on the starter kit side it's all correct now, but if we merge this now, a few tokens will be shown incorrectly. Actually the current master also contaijns a few bugs due to dockit-core, which I also fixed, but new ones became visible due to Prism and other style of the mdjs-layout, so dockit-core needs even more improvement. Hopefully it's not a super prio, because I need to switch to another task now, but I'm planning to return to this ASAP.

@m4dz finally finished this :) I managed to fix a lot of small things, which are present in the current main branch anyway and not related to mdjs-layout migration, but just became visible thanks to that, but not everything is clear how to fix. I'll leave it up to you to decide as you probably know better. Read my comments about particular code.

Beeing a bot here :D
👀 Review in Backlight.dev

💻 Link the PR in your app (?)

npx backlight@latest link @divriots/starter-vue3 --branch pr:4@bashmish

Beeing a bot here :D (next time it should be done automatically)
👀 Review in Backlight.dev

💻 Link the PR in your app (?)

npx backlight@latest link @divriots/starter-vue3 --branch pr:4@bashmish


modularized parameter generation

Got this error from Travis CI: The command "openssl aes-256-cbc -K $encrypted_6de54f97b202_key -iv $encrypted_6de54f97b202_iv -in dokku-deploy.enc -out dokku-deploy -d" failed and exited with 1 during .
Is this due to some code change I made? I would assume not; can someone restart the build?

This is really old... not sure if you still want to try to merge it after the Spektra updates...

Oh yeah...I had forgotten about this; nah, no need to try to merge anymore :)


Revert "Merge pull request #20 from georgehrke/master"

This reverts commit 99e6b3a718ceb93e8f571824ff4026c2016a9559, reversing
changes made to aac08f74e8d10fdf17cdfb9ee4edd205b9363f74.
@georgehrke @evert as discussed in https://github.com/evert/davclient.js/pull/20

Ok, since we discussed it and agreed already, I'm merging this.


Automatically add issues to Project board

Issue: https://github.com/simplybusiness/silversmiths/issues/5
This adds issues to our project board

/dobby version patch


Signal router

Provides a virtual matrix switcher for arbitrary system designs. Functions as a standalone module for signal distribution only, or can be included in drivers which extend this for full room interaction.
Settings define physical connectivity between devices, with all other operation inferred from interfaces.
Switcher_1:
  - *Foo
  - *Bar
Display_1:
  hdmi: Switcher_1.1
  hdmi2: *Baz

This is parsed into a graph representing all of the possible system connectivity with device interactions required to realise this stored on it's edges. Background info and design of this: https://docs.google.com/document/d/1DG2s9jjMVhiW65YGPDkUnOYYpFDeW42SkGvHyp1BEjQ/edit
Signal distribution is then performed with a single 'route' request.

@caspiano - sorry for those auto-dismissals. I thought I'd flicked this back to draft while refactoring. Current state is gtg.


Remove color from .ms-font classes

For discussion, I think that color should not be declared in the .ms-font-* classes.
Anywhere I want the color to be @ms-color-neutralPrimary I can probably inherit from the parent, and redeclaring it on any element where I try to use .ms-font-* to change text size makes these classes difficult to use on any background other than white.
As these classes seem to be intended as font size modifiers, changes in font-size and font-weight (In this case achieved by using a differently weighted font-family) make good sense, but declaring color seems to over-reach what I see as the usefulness of the classes, and in fact there are specifically other classes to handle color.
Curious to hear any reasons why these classes should continue to declare color.

Thanks for reaching out, @TheTedAdams. The .ms-font-[size] classes are intended as base font classes, and they intentionally set the size, weight, and color. You can apply these classes to a single text element, or on a container for inheritance down to all of the text inside.
To change the size of a specific element (independent of color and weight) we provide ms-fontSize-[size] classes. You may not have known about these because they're missing from our styles documentation page. Sorry about that. With classes for size, color, and weight it's possible to apply all of the text properties without ever using a base class.
Now that you know about these classes (e.g. ms-fontSize-xl) do they fit your needs? Here's an example of how you could combine the base classes and a size override:

This paragraph will inherit the medium font size set by the base class.

And so will this paragraph.

This paragraph has a size class that makes it larger.

Demonstration on CodePen

Leaving this issue open so that we can get the .ms-fontSize-[size] classes documented.

That will work. I still think it would be useful to be able to declare size and weight with a single class (since that is how the typography will normally be scaled) without color, but for now I can do it with ms-fontSize-* and ms-fontWeight-*. Thanks for the info!

Are the .ms-fontSize-[size] classes going to be in the documentation? Issue closed and I don't see them at http://dev.office.com/fabric/styles

My mistake, we should definitely keep this issue open until we've documented the size classes.

Created a pull request on our internal documentation repo that documents the .ms-fontSize-[size] classes.
While we understand that some users of Fabric (like @TheTedAdams) would prefer that the base classes not include color, this is an important part of the design language and something that we want to keep in place. The documentation updates will make this clear to prevent confusion.


Commit Time: Support JenkinsPipelineStrategy builds with embedded jenkinsfiles

Describe the behavior changes introduced in this PR\
Currently the commit time exporter fails if it finds a jenkins buildConfig that doesn't have a Git URL set. This code change will allow scanning of environment vars (pipeline params) as well, and handles failures better.
Linked Issues?
resolves #145
Testing Instructions
Please include any additional commands or pointers in addition to our standard PR testing process.
@redhat-cop/mdt

@etsauer I merged the latest master into this PR from the UI here - I kept changes from both branches:

master had a new function _get_repo_from_build_config added by @willowmck in #229
your branch had changes to the same file in the get_repo_from_jenkins function)

Approving as it works in my tests, but I would like input from @willowmck at least to make sure everything lines up with what was done in #229

Those changes look good to me @shaheinm .  Thanks!


updates per SA DOC-2548

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-576

Preview environment: https://ci.pr.harness.io/pr-576

Preview environment: https://ci.pr.harness.io/pr-576


Wrong $GOROOT if go binary is not in subpath

If the go binary is in i.e. "/usr/bin/go", $GOROOT is automatically set to "/usr" which is wrong.
Solution:
Please add an option to set goroot and go binary by yourself.

Sure.
This will be solved in this week's release.

Awesome thanks!

@siklol I guess your /usr/bin/go is a symbolic link, can I follow it and resolve to its ../.. as GOROOT automatically?

ls -l /usr/bin/ | grep go
-rwxr-xr-x 1 root root  6895792 Feb 17 00:28 go
@blindpirate Nope. Not a symlink. I'm using arch. Also, symlinking it to /usr/lib/go/bin/goExec or somewhere doesn't work either.
Better to add an option where I can specify the GOROOT

Got it. Thanks.

@siklol It has been supported. Please see configuration for more details.


Adds numberOfWorkers to app service plan

The purpose of this update is to try to help resolve the issue of numberOfWorkers property not being available from SDKs even though it is available from the list app service plans REST API.  See https://github.com/Azure/azure-rest-api-specs/issues/7990 for details.  As far as what SDKs need to be updated, I'm specifically not finding it in the java SDK so I know that would need to be updated.  I haven't tried any of the other SDKs so I can't be sure, but would assume this impacts most, possibly all.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify (see above)

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[x] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@weidongxu-microsoft FYI, PR on azure-rest-api-specs side to add numberOfWorkers.

This should be solved in https://github.com/Azure/azure-rest-api-specs/pull/19430 and appear in 2022-03-01

That is great news, thank you @weidongxu-microsoft!


Add colorbar to figure 1 example

This commit adds a color bar to indicate the meaning of the color map
for the example betweenness centrality graph in Figure 1.

LGTM. I like the colorbar, I will tweak the proportion of the image in the paper and merge it. The new resolution is different, so the old proportions make the image look small

While you're updating the formatting, maybe we should add to the caption that it's the normalized betweenness centrality too to explain what the visualization is. I realize it's there to just showcase we have visualization support but it's lacking context on what it is and some people commented to me they were wondering about it

While you're updating the formatting, maybe we should add to the caption that it's the normalized betweenness centrality too to explain what the visualization is. I realize it's there to just showcase we have visualization support but it's lacking context on what it is and some people commented to me they were wondering about it

I agree, I will change the caption to be more descriptive. I am also thinking about adding more graphs to the image to focus more on examples than on that single graph itself.

superseded by #485


[WIP] Allow NUTS to do eager evaluation on forward and backward trajectory in parallel

Submission Checklist

[ ] Run unit tests: ./runTests.py src/test/unit
[ ] Run cpplint: make cpplint
[ ] Declare copyright holder and open-source license: see below

Summary
This is a WIP to allow NUTS to perform calculation of the forward and backwards trajectory in parallel.
Intended Effect
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian Weber and Steve Bronder
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

I think I did pencil the graph structure down somewhere…let me search for it.

I only saw this in the email preview (in the same file as @SteveBronder is commenting on), I'd have coded this
fwd_idx == 0 ? true : valid_subtree_fwd[fwd_idx - 1];

as
fwd_idx == 0 || valid_subtree_fwd[fwd_idx - 1];

It's the same behavior because of the short-circuiting of ||.

Here is what my iPad has in my notes app on this:

(ignore for now the red arrows..I explain them below)
So you see the left and the right legs of the trajectory which have yellow path's. Each blob is a point on the trajectory where something happens. Specifically at these points the state is being send along the arrows to the middle process in black, which is the "abort checker process". The blue and green blobs fire off that we explore 2^n (n being the current depth) steps deeper the trajectory in that direction. The checker process in the middle recieves the states which must be compared to evaluate the U-turn criterion.
The idea is that you lay out the full tree to it's maximum depth first (putting lambda's into the leaves doing the work when called) and then you let the TBB run the tree for you in full automation. The execution is canceled once the U-turn criterion is met. At that stage execution of the tree is stopped and the identified state is returned.
If I recall correctly, the red connections are only wired up if you want a serial execution of things. So I intentionally wire-up the graph differently in the case of running this sequentially. This is to help the TBB figure out easier what to do when running the graph. I recall that this was good for single-core performance.
Ok... now that's what is behind this. Does this help already or should I try to annotate the source with reference to the figure?


Fix for #632 - put task name inside quotes

Fix for the following error that popped up after upgrading to Gradle 2.2 -

Could not find property 'assembleRelease' on task ':sugar:libraryJar'

#632

Coverage remained the same at 74.786% when pulling 90f904f26f040dfea4a843b4bd06d56bd06243d0 on jaibatrik:hotfix/AssembleReleaseFix into ca5dd14df77d4a78047197f223eaf1b0f6c50c16 on satyan:master.


Build SQL from AST

Is it possible to take the parse tree and build a SQL statement?  My use case is renaming tables (like, scanning for each time a relation is named and prepending a prefix).  It seems like it might be possible since normalize is able to rewrite the query, but I'm not sure.

Technically there is parts of Postgres that can do this, specifically inside postgres_fdw
https://github.com/postgres/postgres/blob/master/contrib/postgres_fdw/deparse.c
Since pg_query has access to all of postgres that doesn't require catalog access, it might be possible to add this as a feature - but its a good amount of work for sure.
I'll keep it in my mind and might hack on this when I find the time, in any case feel free to hack on it yourself and submit a PR / ask for feedback :)

Cool.  For now, I realized that the AST includes a position field, so I'm using that to do string replacements of the table names.  But I'll likely have a use for AST to query at some point, so I may take a stab at it.
All this is for https://github.com/playlist-media/turboquery, which is designed to take queries that execute against a Postgres database (like on RDS) and automate the transfer of data to Amazon Redshift, execution of the query at Redshift, and transfer back to Postgres.  It does some basic rewriting of the query to ensure it works on Redshift.  Far from complete, but we're looking to put it into production at Playlist.  Some complex queries are seeing around a 200x speedup using this approach.
So, all in all, thanks for the awesome gem!  It's proving very useful.  :smile:

Nice, that looks like an awesome tool, and using substitutions using the positions in the AST sounds like a good approach :)
I've taken another look, and it looks like the best AST-to-SQL approach might be to just implement the deparsing of the AST in Ruby, since Postgres' own logic is a bit incomplete except for the most basic cases - and its quicker to write this in Ruby anyway.
In case you do come back to that route feel free to give me a shout, I might be able to find some time to help out & implement the basic support.

@jacobwgillespie I'm experimenting with some basic support of this, see the spec for whats supported:
https://github.com/lfittl/pg_query/blob/master/spec/lib/deparse_spec.rb
I'll continuously expand this, is there a specific set of SQL that would need to be supported so this is useful to you? (e.g. all variants of SELECT)

Hey!  Sorry, late reply.  What I'm modifying are SELECT statements and INSERT INTO table SELECT statements.  Thanks, looking awesome!

@jacobwgillespie Just released 0.6.0 version of the gem which has deparsing support & should solve your use case :)

:+1: Thanks!


Safer delete

Thanks for creating this plugin, it is useful.
I ran into a problem I had though. This plugin definitely very dangerous... this PR makes it a little less dangerous...
So I passed in
// WARNING: DON'T DO THIS AT HOME
var Clean = require('clean-webpack-plugin');
new Clean('');
// DO NOT DO THIS AT HOME.

and....... it deleted everything in my current project path. Bye bye, .git directory...
gladly it was a beginning of a small project, and the important files I still had tabs open...
but yeh, kinda nuts. I was trying to tell Clean to delete nothing, and I thought passing in an empty string, will cause it to not delete anything..... instead it deleted everything....
This PR prevents this... disallows deleting of the entire project library, also makes sure anything you do delete is a sub-folder of the current project....
// Also prevents these dangerous deletions...
// WARNING DO NOT TRY THIS!

Wow. completely missed this PR. Thank you @quangv :sparkles:
Give me a few days to test, but looks good at first glance :+1:


achcli: update help/usage text

Noticed this when working on https://github.com/moov-io/ach/pull/753

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   93.13%   93.13%
=======================================
  Files          66       66
  Lines        5829     5829
=======================================
  Hits         5429     5429
  Misses        240      240
  Partials      160      160


Sharing the same io_service

Big fan of the Simle-Web-Server, excited to try this library also. Is there a way to have it share the same io_service as another thread?

Thank you, but not quite sure what you mean with "same io_service as another thread". Could you please elaborate?

Yes, my apologies. In my program, an io_service is already running on a thread. This thread also handles TCP clients that can message each other. I'd like to add this websocket library onto that thread to also message the same clients without having to do threadsafe stuff. Am I misguided?

That is a good point, either the io_service should be accessable for reuse (you can currently subclass the server to do this now though I think), or you should be able to set the io_service to use when starting the server. I'll think some more on this next week when I have time.

Okay. That makes sense. I'll look into subclassing it if you don't have time.

Currently, I'm leaning towards making io_service a public ´shared_ptr` member. If set, no attempts will be done to start io_service in this library, and if not set, the behaviour would be like it is now depending on the number of threads set.
I'm thinking about making some additional changes that will break backward compatibility:

shared_ptr arguments should be const shared_ptr... &
number of threads should be set in config and not in constructor


Jesse: Watch freeemailchecker.net

Jesse requests the watch of the watch_keyword freeemailchecker\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

freeemailchecker\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mast in Charcoal HQ


Parameterize GCSClient chunksize for better control when uploading or downloading data

Closes #1218
I upped the default chunksize to 10 mb and parameterized as GCSClient(chunksize=10 * 1024 * 1024).
Creating GCSClient() instances can be expensive if you hit the API at the wrong time, so the user can also override the chunksize when calling the download() or put() methods directly rather than instantiating another instance of GCSClient() with a different chunk size.
@erikbern ready for review.  I didn't see a docstring convention mentioned anywhere so I wasn't sure how to format.

Do @mikekap want to quickly review this too? This looks good to me. Just see Erik's comment. :)

@erikbern @Tarrasch Moved default chunksize to global variable.

LGTM
I realize maybe we should have made chunksize configurable but it's no biggie. let's merge

LGTM as well.
A small note - I didn't expect making a GCSClient to be a heavy op. I don't use the default client myself (to pass in a local descriptor, I have a globally memorized one). Perhaps if the default construction is that expensive, we should memorize it in the BigqueryTarget constructor?

@mikekap It's only heavy because of the API discovery.  If you hit the Google API at a time with high latency then it can be expensive to build a GCSClient().  Instantiating a client with every target creates more opportunities for encountering latency.
A generic luigi solution might be to just instantiate a GCSClient() in a gcs.GCS_CLIENT global variable and have the GCSTarget() grab that one rather than creating a new instance if a client is not supplied.
Our solution was to attach a singleton GCSClient() to a subclassed luigi.task.Config object paired with a DynamicTarget() that always gives us GCS targets with the instantiated client or a more appropriate target based on the schema://.  It also gave us the opportunity to create a GCSClientStub() that translates GCS paths to local paths for running locally and testing.  We have not started integrating BigqueryTargets() but will before too long and will report back if we find some latency.  The BenthospConfig() object always references a single client in a class variable no matter how many times it is instantiated.
def DynamicTarget(path, **kwargs):

    """
    A single interface for dynamically retrieving luigi target objects based on
    the input path's schema.

        file://path = LocalTarget
        gs://path = GCSTarget

    The ``BenthospConfig()`` object is used to determine if a stubbed client
    should be used.

    Parameter
    ---------
    path : str
        Behaves just like ``path`` for any other target, except it requires a
        schema.
    kwargs : **kwargs, optional
        Additional keyword arguments for the desired target.
    """

    cfg = settings.BenthospConfig()

    if path.startswith('gs://'):
        kwargs.update(client=cfg.gcs_client)
        return gcs.GCSTarget(path, **kwargs)

    elif path.startswith('file://'):
        return luigi.LocalTarget(path[7:], **kwargs)

    else:
        raise ValueError("Unrecognized schema: {}".format(path))

class GCSClientStub(object):

    """
    Drop-in replacement for luigi.contrib.gcs.GCSClient
    Maps a given GCS path to a given local file path so that any request using a gcs path
    will be executed on the local file system
    """

    def __init__(self, local_root=os.getcwd(), **kwargs):

        """
        Create a special GCS client that operates locally.
        Parameters
        ----------
        local_root : str, optional
            Consider this location to be the root of GCS.  Any sub-directories
            will be considered buckets.  Creating a bucket creates a sub-dir in
            this location.
        kwargs : **kwargs, (does nothing)
            Quietly eat arguments that would be passed to ``GCSClient()`.
        """

        local_root = os.path.abspath(local_root)
        if not os.path.exists(local_root):
            os.makedirs(local_root)

        self._local_root = local_root

        self.fs = LocalFileSystem()

    def _gcs2local(self, path):

        """
        Convert a GCS path to a local path
        """

        split = urlparse.urlsplit(path)
        bucket = posixpath.join(self._local_root, split.netloc)
        path = posixpath.join(bucket, split.path[1:])  # Slice off leading slash
        if not os.path.exists(bucket):
            os.makedirs(bucket)
        return path

    def _local2gcs(self, path):
        path = path.replace(self._local_root, '', 1)[1:]  # Slice off leading slash
        return 'gs://' + path

    def _path_to_bucket_and_key(self, path):
        (scheme, netloc, path, _, _) = urlsplit(path)
        assert scheme == 'gs'
        path_without_initial_slash = path[1:]
        return netloc, path_without_initial_slash

    def copy(self, source_path, destination_path):
        source_path = self._gcs2local(source_path)
        destination_path = self._gcs2local(destination_path)
        LocalTarget(source_path).copy(destination_path)

    def download(self, path):
        # GCSClient() downloads the file to a temp location and returns an open
        # file pointer, so we do the same thing here

        path = self._gcs2local(path)
        assert os.path.exists(path), "File does not exist: {}".format(path)
        with tempfile.NamedTemporaryFile(delete=False) as fp:
            LocalTarget(path).copy(fp.name)
            return gcs._DeleteOnCloseFile(fp.name, 'r')

    def exists(self, path):
        return self.fs.exists(self._gcs2local(path))

    def isdir(self, path):
        return self.fs.isdir((self._gcs2local(path)))

    def listdir(self, path):
        lpaths = self.fs.listdir(self._gcs2local(path))
        return (self._local2gcs(p)for p in lpaths)

    def mkdir(self, path, **kwargs):
        return self.fs.mkdir(self._gcs2local(path), **kwargs)

    def put(self, filename, dest_path, **kwargs):
        LocalTarget(filename).copy(self._gcs2local(dest_path))

    def put_string(self, contents, dest_path, **kwargs):
        dest_path = self._gcs2local(dest_path)
        bname = os.path.basename(dest_path)
        if not os.path.exists(bname):
            os.makedirs(bname)
        with LocalTarget(dest_path).open('w') as f:
            f.write(contents)

    def remove(self, path, **kwargs):
        # GCSClient does not fail on remove() if the path does not exist, but LocalFileSystem does,
        # so check to make sure it exists before attempting to remove
        if self.exists(path):
            return self.fs.remove(self._gcs2local(path), **kwargs)
        else:
            return False

    def rename(self, source_path, destination_path):
        source_path = self._gcs2local(source_path)
        destination_path = self._gcs2local(destination_path)
        LocalTarget(source_path).move(destination_path)

Thanks for the patch. I guess when users find that the value should be parametrized they'll add it :)


Update more URLs of the Stimulus project

Q
A

Bug fix?
yes

New feature?
no

Tickets
-

License
MIT

Similar to #118.

Duplicate of #117?

Yes, let's close. Cheers!


feat(key_signature): ✨ show cautionary accidentals in + when not present in other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1053

Relevant Lines:
1053

💛  - Coveralls


V1.x fix osx qrenderdoc

Foundation commits for OSX capturing in RenderDoc
Fixes crash when existing renderdoc on OSX

Closing for now after offline discussion about re-basing/re-doing later.


image list used in Train.jsx should auto-generate

I have a train image I'm not ready to share, but to use it I have to keep a private copy of Train.jsx to maintain just to use one image not hard-coded in the list.

Train images are now in src/images/trains and should all be pngs, and now just referenced by their name. No file edits needed.


Updating prettier config

Closes #156
Changes

Added new line addition on formatting in prettier config
Updated the recent files added as per the formatting

Type of change

[ ] Bug fix
[x] Feature update
[ ] Breaking change
[ ] Documentation update

@nitin-1926 @Saurabhsharma884 Thanks 👍


编译报错Unresolved reference: TaskDbHelper

编译报错：
Running Gradle task 'assembleRelease'...
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/DownloadWorker.kt:62:27 Unresolved reference: TaskDbHelper
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/DownloadWorker.kt:136:20 Unresolved reference: TaskDbHelper
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/DownloadWorker.kt:148:20 Unresolved reference: TaskDbHelper
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/DownloadWorker.kt:446:38 Unresolved reference: IntentUtils
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/FlutterDownloaderPlugin.kt:49:27 Unresolved reference: TaskDbHelper
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/FlutterDownloaderPlugin.kt:49:42 Unresolved reference: TaskDbHelper
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/FlutterDownloaderPlugin.kt:369:13 Unresolved reference: IntentUtils
e: file:///D:/Pub/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5/android/src/main/kotlin/vn/hunghd/flutterdownloader/TaskDao.kt:8:37 Unresolved reference: TaskDbHelper

环境：
[✓] Flutter (Channel stable, 3.16.3, on Microsoft Windows [版本 10.0.22621.2715], locale zh-CN)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Community 2019 16.11.11)
[✓] Android Studio (version 2023.1)
[✓] Connected device (4 available)
[✓] Network resources
版本：1.8.0

你好，尝试以下步骤：

al_downloader升级到1.8.3版本
删除AS编译缓存
删除flutter_downloader本地缓存，路径例如/Users/xxx/.pub-cache/hosted/pub.flutter-io.cn/flutter_downloader-1.11.5
重新运行你的项目


setting nfsMountOptions: 'vers=4' results in error (exit status 32)

Describe the bug
When I set nfsMountOptions: 'vers=4' I get this errors like this
MountVolume.SetUp failed for volume "pvc-5fac2bac-b21f-4d7d-ab7a-d5a56381ac77" : rpc error: code = Internal desc = error mounting NFS volume <myip>:/my:storagePrefix_pvc_5fac2bac_b21f_4d7d_ab7a_d5a56381ac77 on mountpoint /var/lib/kubelet/pods/0cef26a5-8966-472e-b7c1-7cd4d568ff66/volumes/kubernetes.io~csi/pvc-5fac2bac-b21f-4d7d-ab7a-d5a56381ac77/mount: exit status 32

With no nfsMountOptions or with nfsMountOptions: 'ro' it works fine.
I see no more information about why the mount failed.
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version: trident:21.07.2
Trident installation flags used: unknown
Container runtime: docker 20.10.10
Kubernetes version: v1.21.7
Kubernetes orchestrator: Rancher v2.6.3
Kubernetes enabled feature gates: unknown
OS: Ubuntu 18.04.6 LTS
NetApp backend types: ONTAP
Other:

To Reproduce
Steps to reproduce the behavior:

set nfsMountOptions: 'vers=4' in TridentBackendConfig or StorageClass
create pod which is using the TridentBackendConfig or StorageClass

Expected behavior
A clear and concise description of what you expected to happen.
The nfs export gets mounted without error.

Hi @domruf,
This error is being returned as an error when executing the mount binary. The manual page for mount(8) lists the return code of 32 as "mount failure". The mount failure can occur for numerous configuration issues either on the Kubernetes worker node or in the configuration of the storage backend.
One recommended approach is to access your Kubernetes worker node and run the mount command. Use this method to troubleshoot why the mount operation is failing. I'm closing this GitHub issue since this isn't a Trident specific issue. Trident will execute the provided mount options when attempting to mount an NFS volume. Please contact NetApp support if you need additional assistance.


When reprojecting Image layers, suggest doing somewhat more than the visible area

When you have a reprojected map with an image layer, the image layer is only computed for the visible area on the screen. This is a pity as it means that any panning of the image shows a cutoff layer. This is different to the unprojected case, where some level off off-screen computation is performed (so that small pans looks nice).
I'd like some level off offscreen image layer to be precomputed.

Maybe I'll have a go at implementing this....


ErrorOverlay.setEditorHandler

Hello, could you please help me with this
Step to reproduce:

cloned repo
npm install
npm run create-react-app ../new-project
cd ../new-project
npm run start
Compiled successfully!

and

Interesting; I think our local create-react-app sometimes hiccups and doesn't use the latest version of sub-dependencies.
I'd really appreciate you tracking this down, because it doesn't reproduce in a released version or the local version.
It's going to be pretty low priority for us so anything you do will help. 😄

In my case, I was referencing
`"react-error-overlay": "^1.0.10",`

in my
package.json
file, as opposed to "react-script" requiring "1.1.1" version.

I just hit the same error and in my case I erroneously had react-dev-utils in my peer dependencies.


Revert "Upgrade rebar3 (#695)"

This reverts commit 9a5c4c39009cd967b61ab62627322e413987012d.
The rebar3 upgrade had a strange side-effect (cause still unknown) which made it impossible to load plugins. Until we figure out what that issue was let's revert back to the old rebar3 version (3.5.3 -> 3.3.6).

Tested and this fixes the issue for me


Features expected for 1.0 version

Hello, recently I have played with this framework and find it very interesting. I would be happy to use it. But right now it is not ready for real usage and here I'll will try to summarize all key features (fixes) expected for release version of the library.
1. Collections of Renderable of different type
Currently trait Renderable depends on component, but it is a huge limitation not allowing to create a collection of different kind of components and also not allowing to create nested components (Issue #128) (create container components like Tabs, Stacks, etc.), so ideally Renderable trait should looks like:
pub trait Renderable<CTX> {
    /// Called by rendering loop.
    fn view(&self) -> Html<CTX>;
}

Why is it possible?
Component is required only(AFAIK) for handling listeners (precisly for handle result type from listener callback) and for handling props changes. Those two things may be done in the component itself rather then in the library (or some how another way).
2. React syntax
A lot of people got used to use React syntax, and this library has to keep close to it as much as possible, so here is as example:
...
    fn view(&self) -> Html<CTX, Self> {
        html! {

{ format!("{} on {} clicked", self.counter, self.limit) }

                <Button: onsignal=|_| Msg::ChildClicked, title="Middle", />

        }
    }
...

should looks like:
...
    fn view(&self) -> Html<CTX, Self> {
        html! {

{self.counter} on {self.limit} clicked

                <misc::Button onsignal={|_| Msg::ChildClicked}>
                   Middle
                </misc::Button>

        }
    }
...

Reacts componentDidMount analog
I think it will be good to exted Renderable trait:
pub trait Renderable<CTX> {
    /// Called by rendering loop.
    fn view(&self) -> Html<CTX>; // What about to rename this method to `render`
    /// Called after component mounted (updated) with all captured refs HashMap
    fn mount(&self, refs: HashMap<String, &Html<CTX>>) { // Or similar
        /// No default implementation
    }
}

Get rid of all confusing commas and semicolons
here are the issues #98, #127
I suspect it may be solved by a compiller plugin (as @DenisKolodin mentioned in #127).
Allow raw text nodes
I don't see any limitations from rust to make it
html! {

 Some raw text here

{"Regular expression style if you need     special    formatting! Or smiles :)"}

}

Components should be able to have a body
html! {
    <Tabs>
        <Tab>
            Some data here
        </Tab>
        ...
    </Tabs>
}

React's references to elements (virtual nodes)
html! {

Some data

}

3. Move virtual dom part into seporate crate
Why?
Because it would be great to use such react's style with different backends, like stdweb (for web) or GTK (for desktop). I suppose #108 may be easily solved by HTML rendering backend.

Yeah these features will make it actually usable for a serious project. Right now I can only do some small applications. Also something like high order components/render props/children like react would be good so that we can make more parts of the app declarative.
Right now parceljs supports rust and I'm planning to use rust for calculations on state and later on move to this ui framework if possible.
https://medium.com/@devongovett/parcel-v1-5-0-released-source-maps-webassembly-rust-and-more-3a6385e43b95

React's references to elements (virtual nodes)

html! {

Some data

}

React deprecated string refs (it's a legacy feature now) and recommends callback refs and object refs instead.

Waiting for compiler plugin ...

For point 1, as memtion in #128 by DenisKolodin:

If you want to render Link inside any Component you should describe it in type

and I support for component restriction. But it should Render more easy, and hope to just like writing HTML DOM tree.

Here is I'm finally gathered all my ideas as PoC in one place. Please check it. If you have some ideas how it can be integrated into yew it would be awesome.

Yew 1.0 Update
We are getting closer to releasing a v1.0 version of Yew and I wanted to address some of the requests here and provide updates :)

1. Collections of Renderable of different type
Currently trait Renderable depends on component, but it is a huge limitation not allowing to create a collection of different kind of components and also not allowing to create nested components (Issue #128) (create container components like Tabs, Stacks, etc.)

Nested Components v1 was completed in https://github.com/yewstack/yew/pull/589 and will be matured in v2 here https://github.com/yewstack/yew/pull/756 (along with the removal of generics in the virtual dom)

2. React syntax
Reacts componentDidMount analog

Fixed here: https://github.com/yewstack/yew/pull/583

Get rid of all confusing commas and semicolons

Fixed here: https://github.com/yewstack/yew/pull/500

Allow raw text nodes

Yes, this would be nice, but AFAICT not easy to implement. May come in the future 🤷♂ I created an issue here: https://github.com/yewstack/yew/issues/757

Components should be able to have a body

Mentioned already, but fixed here: https://github.com/yewstack/yew/pull/589

React's references to elements (virtual nodes)

Fixed here: https://github.com/yewstack/yew/pull/715

3. Move virtual dom part into seporate crate

Yeah, I think this is a good idea, created an issue here: https://github.com/yewstack/yew/issues/758

I'm going to close this issue in favour of the 2 new issues I created. Thanks for writing this up @andreytkachenko!


The cross-hair line on the price history chart jumps unexpectedly

https://bitsharestalk.org/index.php/topic,19417.msg249450.html#msg249450

It's almost fixed now.
The only problem (a small one indeed) is that when you move the mouse upwards (from the volume section of the chart towards the price section) the horizontal part of the cross-hair line behaves quite randomly: sometimes it shows up just after you enter the price section and sometimes you need to move the mouse much higher to make it show up.

@neura-sx
Is this still an issue? If not close. If so, please screenshot or give a very specific example so I can duplicate it.
OS:
Browser:

Chrome / Win 7
Yes, in the 2.0.151119 release the bug is still there.
As you can see in those two screen-shots below: when you roll your mouse from the bottom part of the screen upwards there is always a moment when you are close enough to the price history chart so that the horizontal part of the cross-hair shows up. But the problem is it shows up differently for different candles - it seems like there is some random factor deciding about it.

I see this. It's just cosmetic. Moving it to mid-December.


pretty alerts

[!TIP]
You can test the success alert by sending any form, they will not actually be sent (they are mocked)

pros:

beautiful alerts

cons:

increase fetch-and-qr.js bundle size from ~7kb to ~80kb
uses a patch to remove protestware from sweetalert2

[!IMPORTANT]
TODO: separate success() and error() and make sure window width is ok for error (and format error with title and body)

[!CAUTION]
Before merging, remove mocked response from pages/fetch-and-qr.ts

Will be replaced by the popover + modal API


Broke goto definition click inside of script in html

Does this issue occur when all extensions are disabled?: Yes

Version: 1.96.1 (user setup)
Commit: 42b266171e51a016313f47d0c48aca9295b9cbb2
OS: Windows_NT x64 10
Steps to Reproduce:

Create new file with html type
Put code

<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Document</title>
</head>

<body>
    <script>
        const b = new Blob([]);
    </script>
</body>

</html>

Press ctrl and hover cursor over Blob to see underline to go to definition
No underline below Blob and click on it doesnt do anything

Not sure that Go To Definition ever worked on built-in symbols in embedded JavaScript.
It works for symbols defined in the script itself.


How to use "loadAudio" more than once ?

I want to use loadAudio to replace the already set audio

Did anyone ever figure this out

I saw this error when I wanted to change it in html
'demo/audio/audio1.mp3' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, data, isolated-app, chrome-extension, chrome, https, chrome-untrusted.'
I was able to change the sound when I put it in a project in visual studio
`
@RenderBody()
Play

<script>
    let wave = new CircularAudioWave(document.getElementById('chart-container'));
    wave.loadAudio('Content/er/demo/audio/audio1.mp3');</script>

`
but I still haven't found how to change the gif file :(

Does the file is hosted on the same website ?
If is not, the website that call the image will trigger CORS errors
Le mar. 9 juil. 2024, 14:34, serdar78 @.***> a écrit :

I saw this error when I wanted to change it in html
'demo/audio/audio1.mp3' from origin 'null' has been blocked by CORS
policy: Cross origin requests are only supported for protocol schemes:
http, data, isolated-app, chrome-extension, chrome, https,
chrome-untrusted.'
I was able to change the sound when I put it in a project in visual studio
`
@RenderBody()
Play

`
but I still haven't found how to change the gif file :(
—
Reply to this email directly, view it on GitHub
https://github.com/kelvinau/circular-audio-wave/issues/21#issuecomment-2217563328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APUD6YO7IMDYN3USTR4A6UDZLPKEHAVCNFSM6AAAAABJYP7OM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXGU3DGMZSHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


PPF-360: fix paragraph coordinate logic for non left aligned text wrapped paragraph fields

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (07c96e9) 100.00% compared to head (da161c8) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #362   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines          644       659   +15
=========================================
+ Hits           644       659   +15

Impacted Files
Coverage Δ

PyPDFForm/__init__.py
100.00% <100.00%> (ø)

PyPDFForm/core/filler.py
100.00% <100.00%> (ø)

PyPDFForm/core/template.py
100.00% <100.00%> (ø)

PyPDFForm/core/utils.py
100.00% <100.00%> (ø)

PyPDFForm/core/watermark.py
100.00% <100.00%> (ø)

PyPDFForm/middleware/text.py
100.00% <100.00%> (ø)

PyPDFForm/wrapper.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


8689czd8r remove RDS maintenance banner

Description
ClickUp Ticket: 8689czd8r
Upgrade complete. Remove maintenance banner.

This is failing for a trivial reason (slash in branch name instead of underscore) so I'm just going to merge it. I have it on the list to update Jenkins to allow slashes.


Class-based resolvers

Add initial support for class-based resolvers.
This approach should also allow registration of resolvers at run-time.

Pull Request Test Coverage Report for Build 1152

14 of 22 (63.64%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 88.872%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Schema/Resolver/AbstractResolver.php
0
4
0.0%

src/Schema/Resolver/ResolverRegistry.php
8
12
66.67%

Totals

Change from base Build 1150:
-0.04%

Covered Lines:
5151

Relevant Lines:
5796

💛  - Coveralls


Python3.6 idioms

[x] Passes black . && mypy . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Use python 3.6+ idioms; most changes are f-strings
Mostly from pyupgrade --py36-plus **/*.py

Tests broken by #3409 - please stand by...

Thank you


How can we return 404 for routes that are not defined?

I am trying to write this piece of code in Handler.php's render method
`if($this->isHttpException($e))
{
switch ($e->getStatusCode())
{
// not found
case 404:
throw new \Symfony\Component\HttpKernel\Exception\HttpException\NotFoundHttpException("path not found");
});
break;
            default:
                return $this->renderHttpException($e);
                break;
        }
    }

    return parent::render($request, $e);`

It is showing error(PFA screenshot)

Return a 404 Not Found response is the default behavior of Dingo API.
So, what do you mean?

I mean it should not return a fancy HTML page. I want to return a JSON response like
{      message : 'path not found',      status_code : 404 }
Ofcourse HTTP status code must be set to 404

It is not clearly yet.
As stated on Dingo API documentation (https://github.com/dingo/api/wiki/Configuration#response-formats) the default response format is JSON.
The error in your image is about a FatalErrorException because you wrote some code in Handler.php.
Why are you writing this code? Is it because you want the message to be path not found instead of 404 Not Found?


How to handle firebase auth errors?

I'm trying to build a login page with firebase auth plugin. But I don't know how to handle auth errors in a cross-platform way. For example, this are some PlatformException that I get when the user type the wrong password/email or there are a network issue.
On iOS:
PlatformException(Error 17011, FIRAuthErrorDomain, There is no user record corresponding to this identifier. The user may have been deleted.)

PlatformException(Error 17009, FIRAuthErrorDomain, The password is invalid or the user does not have a password.)

PlatformException(Error 17020, FIRAuthErrorDomain, Network error (such as timeout, interrupted connection or unreachable host) has occurred.)

On Android:
PlatformException(exception, There is no user record corresponding to this identifier. The user may have been deleted., null)

PlatformException(exception, The password is invalid or the user does not have a password., null)

PlatformException(exception, A network error (such as timeout, interrupted connection or unreachable host) has occurred., null)

The format is: code, message, details. In Android I get a code: exception, what does it mean? And also in iOS I always get a message: FIRAuthErrorDomain and not any standard code listed here.
The code:
try {
    _user = await _auth.signInWithEmailAndPassword(
        email: _email,
        password: _password);
} on PlatformException catch (e) {
    print(e);
}

Temporary fix (don't rely on this solution)
In the meantime the problem can be fixed  (see bottom for warning on this solution) with something like that:
enum authProblems { UserNotFound, PasswordNotValid, NetworkError }

authProblems errorType;
if (Platform.isAndroid) {
  switch (e.message) {
    case 'There is no user record corresponding to this identifier. The user may have been deleted.':
      errorType = authProblems.UserNotFound;
      break;
    case 'The password is invalid or the user does not have a password.':
      errorType = authProblems.PasswordNotValid;
      break;
    case 'A network error (such as timeout, interrupted connection or unreachable host) has occurred.':
      errorType = authProblems.NetworkError;
      break;
    // ...
    default:
      print('Case ${e.message} is not jet implemented');
  }
} else if (Platform.isIOS) {
  switch (e.code) {
    case 'Error 17011':
      errorType = authProblems.UserNotFound;
      break;
    case 'Error 17009':
      errorType = authProblems.PasswordNotValid;
      break;
    case 'Error 17020':
      errorType = authProblems.NetworkError;
      break;
    // ...
    default:
      print('Case ${e.message} is not jet implemented');
  }
}
print('The error is $errorType');

Warning: The problem, that I would like to emphasize with this issue, it's that you can't rely too much in this solution because a simple FirebaseAuth update can screw it up. Also if you choose this way be sure to lock the firebase_auth: ?.?.? to a specific version in the pubspec.yaml file.

Flutter doctor
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.6 17G65, locale en-IT)
    • Flutter version 0.5.1 at /Users/.../Library/flutter
    • Framework revision c7ea3ca377 (10 weeks ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/.../Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] IntelliJ IDEA Community Edition (version 2017.3.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700

[!] VS Code (version 1.25.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected devices (1 available)
    • Nexus 5X • 01ce0d68fc7ca517 • android-arm64 • Android 8.1.0 (API 27)

Similar to #18312, #13027

i think this issue is the appropriate spot...
i'm seeing
PlatformException(exception, The sms verification code used to create the phone auth credential is invalid. Please resend the verification code sms and be sure use the verification code provided by the user., null)

if a user enters the wrong SMS code when doing phone number auth -- it looks like this this may be getting addressed in https://github.com/flutter/plugins/pull/678 if it's similar to #18312 ?

@joshkendrick My upcoming patch will address this. and #18312

sounds great!

@joshkendrick My upcoming patch will address this. and #18312

@joshkendrick , will your update allow us to catch all Firebase exceptions that currently can't be handled?
(I see many several issues posted about exceptions not handle but only you seem to be addressing it)

Is there any hack, to identify the errors correctly in android? Because now the error code is not provided. :(

Any update on this? I need error code to display custom error message

+1.. this is a core part of the firebase auth experience. Really difficult to release an app into the wild where all sorts of auth errors might crop up. The PlatformException thrown freezes up the whole app and makes it unusable until a recompile..

@suparnavg Sorry why you are saying that this auth errors freezes up the app and it's not unusable until a recompile? In the code that I've included it doesn't happen. You are maybe forgetting the try {} catch (e) {} statement? If not can you give a more detailed example?

@knitero See the updated question for a temporary solution.

@riccardoratta  Thanks, this is bad, but the best possible solution :)

@riccardoratta The solution you proposed is what I wanted to prevent :(

@anderscheow Yes, it's the point of the issue. We need a cross platform way (for example by an enum) to know exactly what kind of error firebase auth is throwing. The temporary fix I've included is if you have an application that need to be publicated as soon as possible and you don't know how to proceed.

My fix will be merged soon and this can be resolved.

Is the fix release?

You can do
    try {
      //
    }on PlatformException catch (error)  {
       List<String> errors = error.toString().split(',');
      print("Error: " + errors[1]);
    }

You will get the error only like
 The email address is badly formatted

On Android, you can grab the code from the exception. I can't test on iOS atm but is there a reason not to use this?
catch (e) {
  print(e.code);
  switch (e.code) {
    case 'ERROR_INVALID_EMAIL':
      authError = 'Invalid Email';
      break;
    case 'ERROR_USER_NOT_FOUND':
      authError = 'User Not Found';
      break;
    case 'ERROR_WRONG_PASSWORD':
      authError = 'Wrong Password';
      break;
    default:
      authError = 'Error';
      break;
  }
}

I implemented the error handling. You do not want to use error.toString() rather as @mikecbone said. Check the code if you want some specific behaviour when an error occurs then you can show a widget or take the user to a specific screen. If you want to display the friendly message. Then you can use error.message, or as @mikecbone has done so you can app specific messages perhaps, or custom localised versions.
https://api.flutter.dev/flutter/services/PlatformException-class.html

On Android, you can grab the code from the exception. I can't test on iOS atm but is there a reason not to use this?
catch (e) {
  print(e.code);
  switch (e.code) {
    case 'ERROR_INVALID_EMAIL':
      authError = 'Invalid Email';
      break;
    case 'ERROR_USER_NOT_FOUND':
      authError = 'User Not Found';
      break;
    case 'ERROR_WRONG_PASSWORD':
      authError = 'Wrong Password';
      break;
    default:
      authError = 'Error';
      break;
  }
}

@mikecbone, where can we find all these existing error messages? Firebase official docs don't have it... And i can't find anywhere...

@mikecbone, where can we find all these existing error messages? Firebase official docs don't have it... And i can't find anywhere...

You can find a list of errors here. You just need to replace FIRAuthErrorCode with ERROR and then stick an underline between each word.
So FIRAuthErrorCodeUserNotFound becomes ERROR_USER_NOT_FOUND
Not the best solution I know, but it does seem to work.

Oh boy, so that's the secret... Thank you!

I documented the error codes in the source on each one of the FirebaseAuth functions.

@slightfoot
I'll check it out! Thank you!

I documented the error codes in the source on each one of the FirebaseAuth functions.
For example: https://github.com/flutter/plugins/blob/master/packages/firebase_auth/lib/src/firebase_auth.dart#L204
So just check the function comments you are calling.

Error 404

I documented the error codes in the source on each one of the FirebaseAuth functions.
For example: https://github.com/flutter/plugins/blob/master/packages/firebase_auth/lib/src/firebase_auth.dart#L204
So just check the function comments you are calling.

Error 404

Indeed

@riccardoratta
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/725. Any further collaboration will be done there.

I made a gist with all the auth errors from firebase with an example https://gist.github.com/nikhilmufc7/6b74a3c12a6e2d3284942d40ff583e37


Nodemcu board could not handle 16v ?

I have bought a esp8266 nodemcu board, yet it is burned and smoked out when i connect 16v to Vin pin and GND to GND ?  Diodes are burned as it is shown in the figure  ?
I could not understand why ? Because diodes and AMS1117 has maximum power input rating as much as 18V ?

Most devkits have a max input voltage closer to 5v.  A very few can handle up to 12v, but those get fairly warm.  It’s the other components, mainly the voltage regulator, that limit it.
Mark Stevens
Sent from my iPhone
All typos are Siri's fault!
On Aug 14, 2018, at 6:15 AM, mmaxus35 <notifications<EMAIL_ADDRESS>wrote:
I have bought a esp8266 nodemcu board, yet it is burned and smoked out when i connect 16v to Vin pin and GND to GND ? Diodes are burned as it is shown in the figure ?
I could not understand why ? Because diodes and AMS1117 has maximum power input rating as much as 18V ?
[nodemcu]https://user-images.githubusercontent.com/22351514/44088620-82a4e3f8-9fcc-11e8-9770-547b4b206da5.jpg
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/nodemcu/nodemcu-devkit-v1.0/issues/34, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATsI7E8sC4469IDNBdnkSbqhuiBRa4w1ks5uQrFggaJpZM4V8PqV.


1.1.2 rollup into master

Coverage increased (+0.8%) to 76.732% when pulling 40a75886122ad38b37a3ca98010cc226b69e1623 on v1.x into d13f2c25b0779f6d4734ec0c46b856f023d7f23e on master.


Using API in cron it fails

I'm trying to use the api to sync actualbudget with the bank via cron task... if i run the command on the shell it works, but when I run it by cron I get a error:
{"error":"Unknown error while interacting with Actual Api. See server logs for more information"}

But when I go to the log all seems ok, I even seem GoCardless pulling the data!
Do you have any idea on what could it be?
Thank you

I am getting the same error but on a different situation.
Here are my logs
Actual HTTP Server Listening on PORT:  5007
Unknown error while interacting with Actual Api. See server logs for more information TypeError: injected.send is not a function
    at send (/usr/src/app/node_modules/@actual-app/api/dist/methods.js:76:21)
    at Object.downloadBudget (/usr/src/app/node_modules/@actual-app/api/dist/methods.js:93:12)
    at Budget (/usr/src/app/src/v1/budget.js:19:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /usr/src/app/src/v1/routes/index.js:10:27
Actual api client initialized successfully
Error parsing metadata: SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at /usr/src/app/node_modules/@actual-app/api/dist/app/bundle.api.js:47109:42
    at async Promise.all (index 0)
    at async handlers.get-budgets (/usr/src/app/node_modules/@actual-app/api/dist/app/bundle.api.js:47104:34)
    at async handlers.api/download-budget (/usr/src/app/node_modules/@actual-app/api/dist/app/bundle.api.js:37318:33)
Loading fresh spreadsheet
Syncing since 2024-12-03T10:45:36.868Z-0007-bcd002848d4fbaee 0 (attempt: 0)
Got messages from server 70
Error creating map from sync id to budget id SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at /usr/src/app/src/v1/budget.js:258:31
    at Array.forEach (<anonymous>)
    at refreshSincIdToBudgetIdMap (/usr/src/app/src/v1/budget.js:257:19)
    at Budget (/usr/src/app/src/v1/budget.js:21:5)
    at async /usr/src/app/src/v1/routes/index.js:10:27
Performing transaction reconciliation
Performing transaction reconciliation matching


CLI tools refactoring

Hi. Beautified and optimized some stuff without changing any logic and functionality.

@Madis0 It would be great to refactor CurseForge to Packwiz-Modrinth.py as well (using f-strings, pathlib, tomllib etc.). But there's too much "path magic" going on in there. So I didn't touch it to avoid breaking anything. Maybe you can do it as the author of the code.

Why remove type hints?

Why remove type hints?

Oops, my bad. Fixed.

Other than that looks good, and I'm not asking you to write type hints, I simply want to understand why did you remove them.

Other than that looks good, and I'm not asking you to write type hints, I simply want to understand why did you remove them.

Initially I decided to remove all return type hints since project is pretty small and not all functions were annotated in the first place.

Why not replace with pathlib functions?

There's too much path-related code in this file. Don't want to break anything. Ofc it'd be better to completely rewrite it using pathlib. But I've no time for testing it.

Initially I decided to remove all return type hints since project is pretty small and not all functions were annotated in the first place.

No matter how small the project is, writing type annotation (not only for return types, but also for arguments) is a good habit to develop.  So I would like you to bring back argument type hints, and, if you have time, to write it to other non annotated functions.

There's too much path-related code in this file. Don't want to break anything.

Funny thing, if you read it closely, you would realize that a good chunk if this code is not used, and can be freely deleted.
Most of this code is kept "just in case", so the author could change the method exporting modpack to Modrinth,  which is I doubt would work after so much time of just gathering dust.

Ofc it'd be better to completely rewrite it using pathlib. But I've no time for testing it.

You won't be able to test it anyway ¯\_(ツ)_/¯

So I would like you to bring back argument type hints, and, if you have time, to write it to other non annotated functions.

@RozeFound I already did it in 962d099

I already did it in 962d099

In 962d099 you did only return type hints, but not function arguments

Anyway, @JustKappaMan, приятно видеть земляка в опенсорсе :)
You don't plan on adding anything else?

You don't plan on adding anything else?

Nope :)

Worked for me.


[docs] : fixing broken links in contribuiton.md

✏ Describe the bug
There the links in the end of the contribution.md are not redirecting to proper url
📸 Screenshots
No response

i would like to work on this..

Thank you to spot that out, go for it :heart_eyes:  @amitanshusahu


Add ability to visualize Exodus sidesets and nodesets

Describe the solution you'd like.
Title mostly says it all . . .  This capability would be just as useful as being able to visualize the element blocks.

@nDimensionalSpace do you happen to have an Exodus dataset on RZ/CZ with sidesets and nodesets.

@markcmiller86: I do have a mesh I am thinking of in the context of this question, which I will most likely send to you.  If that doesn't work out, I will create one and send it along.