Filter focus events that came from the API

As described in #13238. libuv sends a focus event to jiggle the handle. Now that we support focus events as VT input (#12900), we'd translate those focus events to VT input as well. That combination of things caused exiting neovim to emit a \x1b[O to the input line of the shell when exited.
To fix this, we're going to secretly filter out any focus events that came from the API, before translating to VT. We're fortunate here, the FOCUS_EVENT_RECORD version of the ctor is only called by the API.

[x] Closes #13238
[x] Tested manually
[x] I work here

Big s/o to @j4james for coming up with this one.

It turns out the unit tests use that ctor to inject focus events ;) and then make sure focus VT comes out
Error: Verify: AreEqual(false, pInput->HandleKey(inputEvent.get())): Verify FOCUS_EVENT was NOT handled. - Values (0, 1) [File: C:\a\_work\1\s\src\terminal\adapter\ut_adapter\inputTest.cpp, Function: Microsoft::Console::VirtualTerminal::InputTest::TerminalInputTests, Line: 306]

It turns out the unit tests use that ctor to inject focus events ;) and then make sure focus VT comes out

I think that particular test is just checking whether HandleKey returns false for focus events, which we could "fix" by changing the return value here:
https://github.com/microsoft/terminal/blob/cbdbdbb9bf948a556462928e8e44a468cb1780fb/src/terminal/input/terminalInput.cpp#L533-L536
Semantically I'm not actually sure what the correct return should be though. Prior to this PR it would have depended on whether mouse focus mode was enabled or not, so maybe false would be more appropriate given we're not generating the focus reports in this case. I'm curious what the implications are for any HandleKey callers though.


Fixed tests for #13114

https://github.com/yiisoft/yii2/pull/13114#issuecomment-267349783

Good job!

Thank you very much!


Unable to access storage in terminal proot distro

Things gonna be good if we can access both device internal & external storage.
Don't know if it's possible to access external storage
Karbon

Termux: in here we can access the internal storage

I have already reported @RohitKushvaha01 to this bug.

I see, still i think having different issue apart from TODO is gonna be organized


Shellcheck Invalid configuration Fix Configuration

Hello,
I have pycharm on ubuntu and installed shellcheck, but the shellcheck invalid configuration error message appears.
I tried configuring it according to the "fix configuration" option, but the request appears to be an ".exe". Does this plugin only work on Windows?

Ubuntu is supported

I agree that naming could be more misleading


Added recursive flag to remove older upstream dirs

During the cleanup of older upstream builds, we need the rm -r flag added to remove directories as well as files.
@jvlcek

Will merge without Travis.
@JPrause FYI, if you put [skip ci] in the commit message body it will skip travis builds.


More performance tuning on ValueSet expansion.

Note to self: need to address bug when expanding with bad URL parameter instead of context.

Re: https://github.com/jamesagnew/hapi-fhir/pull/1468#issuecomment-529028294
This is fixed. There's still an issue where ValueSet.id is passed instead of ValueSet.url as the url parameter for the $expand operation. Legacy-mode expansion is used instead of persistence-backed expansion, and larger ValueSets may result in a timeout.

@jamesagnew, this is ready for review. Thanks!


Resolve #16

@IlyaKhD please review
/cc @San4es

@AlekseyMartynov,
Now, this sample works! Thank you for operative fix!

:shipit:


[Tab] Applies muiTheme to Tab component.

We noticed that the Tab component did not pick up any theme overrides. This should allow you to style them from your custom theme.
Thanks.

Cool, just pushed a commit to better adhere to the pattern. Let me know what you think.

#1244 Allows us to customize the inkbar color through theme vars. Also, #1133 is a discussion on whether we should be putting css styles inside our theme, so I'm going to close this until we have clearer direction on #1133.


Sprites menu crashed in spanish in context translation

@pelikhan
When trying to translate the Cherry Pickr editor for in context translation from English to Spanish:
go to sprites menu
appears like this

This also happens when trying to translate the same menu in the Dance Party editor

This implies a translation is invalid in spanish.

This implies a translation is invalid in spanish.


app: Raise windows when opening new tabs via IPC

When Lagrange is opened via a terminal -- or more importantly, when
opened as a MIME handler for gemini:// links in other applications --
users expect Lagrange to take focus. However, if Lagrange is already
open and the request is piped over IPC, this fails. In theory this
should be as simple as adding a SDL_RaiseWindow() in the right place. In
practice there's a chain of race conditions that make the obvious
solution fail in a non-obvious way.
Signed-off-by: Alyssa Rosenzweig<EMAIL_ADDRESS>

Note: I'm nt familiar enough with the SDL event loop to know if accessing window from here is safe. If it isn't, we need some other way to block.

Thanks for working this out. I was thinking of implementing window raising at some point but wasn't even aware of this focus-stealing prevention trickery.  However, the IPC signal may be handled in any thread, so postCommand_App might not be called in the main thread and I'm pretty sure SDL wants windows accessed only from there.
So what should occur is that the CLI requests a raise and blocks in communicate_Ipc_ until the window actually has been raised. I think the simplest way to do this is to add a parameter to the "ipc.signal" command (it gets always appended at the end in write_Ipc). The recipient executes this command when the previous actions have been done, and it's guaranteed to run on the event loop in the main thread.

However, the IPC signal may be handled in any thread, so
postCommand_App might not be called in the main thread and I'm pretty sure
SDL wants windows accessed only from there.

I was afraid there'd be something like that. This was mostly a drive-by
so if you were planning on finishing this anyway, please don't block on
me. (If not, I'm not sure when I'll have time to do Gemini patches
next.)
The situation on Linux/Wayland is more dire, as pointed on #sdl on IRC.
There's no standardized protocol for raising whatsoever. GNOME Wayland
has a special vendored protocol accessible via GTK, but short of adding
a GTK backend to SDL I'm not sure how to make use of that. I'm not sure
if KDE has an equivalent protocol, but the one I saw is decidedly GNOME
specific. It's a shame there isn't a 'cleaner' way of expressing this
pattern.

Sure, I can make the needed changes and merge this, no worries.

f033188b8103135b4e4ce1746bfc26a527323ba8 includes the suggested changes.


[CI] Add miss works

Fixed #15

I don't see the .vsix file in the artifacts on the link shown.  Everything there is a .zip file.

Good work. Please resolve the conflicts with the latest release workflow changes. The workflow now also includes uploads for regular release versions.

Gonna look into the PRs soon. Sorry, about the delay.


Add codecov.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4ae38a8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   96.87%
=======================================
  Files           ?        3
  Lines           ?       32
  Branches        ?        1
=======================================
  Hits            ?       31
  Misses          ?        1
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae38a8...fd15bc9. Read the comment docs.


Adding mention at start of new paragraph does not work when previous paragraph ends with mention

When you add a mention on a line, press Enter to move to a new line, and then immediately add another mention on the next line, the first mention is replaced by the new mention you just added.
For example, if I try to add:
@joeblow
@henry
It will be converted to:
@henry
In _renderMentionIntoEditor, after the placeholder text is inserted into the editor, editor.getContent() will return something like
@joeblow

@h__PLACEHOLDER__
. Notice there is no whitespace between the paragraph tags, so the regex ends up replacing the wrong thing.
Thx.

I'll take a look at this when I have a chance. That PLACEHOLDER/regex solution has never sat easily with me.

@donnapep I can't replicate your exact issue, but I do see that if you try and add @users without any space in between (@usera@userb) it collapses down to one user.

Do you think that https://github.com/Kindling/react-tinymce-mention/commit/ca268b1bcb5652301f8b03ba7962ea79e319c9d6 would handle this better?

@deltamualpha I sorta ended up doing my own thing, but you might be interested in this.
Only trick is that you'll need to know the length of the mention text (this.state.query in the above snippet) in order for this to work.

@donnapep Ah, clever! I found myself wishing I had that in this case... might be worth a refactor to add that to the props being passed around.

@deltamualpha Yeah, I'd looked at submitting a PR but then realized it wasn't going to be as simple as I'd hoped. Good luck!


Fix bug when dsn is redis://password@localhost

This change does not make much sense in my opinion: the authentication part of an URI actually requires both a username and a password or a username with an empty password at worts, but we know that redis has no concept of username and that's why for passwords we actually use a password parameter in the query string (that is redis://localhost?password=redispassword)


Is unnecessarily a class

While writing my first Ruby gem, I found your fine article related to Dogeify—thanks very much! :)

I changed Dogeify from a module to a class. The reason for doing so is that an instance of EngTagger needs to be initialized, and I don't want this initialization to have to occur every time Dogeify processes text.

I'm aware that, presently, each new instance of Dogeify instantiates a new EngTagger.
For even more efficiency—in a highly entertaining post—Matt Aimonetti and Evan Phoenix suggest (in effect) that you can instantiate an EngTagger exactly once (when the gem is required), and keep a reference to this EngTagger instance in a constant (hidden within Dogeify's module namespace):
module Dogeify
  Tagger = EngTagger.new
end

This means Dogeify needn't be a class, after all. :)
And as you know, due to the multicore crisis, both Elixir, the (Ruby-related) language—as well as functional programming in general—are important (read: "the new coolness").
Perhaps it's good not to teach people to write gems as classes unnecessarily. Do you think so? :)
If you agree, I suppose (alternatively and more easily) you could tell your readers that converting Dogeify to a class really wasn't necessary, but that you simply did so for didactic purposes.

There are several ways of using Dogeify. The first way is to go through ... Dogeify ... itself.
The second way is to modify the String or Array classes by including either core extension.

Here's some example code with Dogeify as a module (instead of a class, using "hello" instead of actually converting to doge-speak):
class EngTagger; def hello(s) "hello #{s}" end end
module Dogeify
  Tagger=EngTagger.new
  extend self
  def dogeify(*a)
    case
    when !a.empty?
      Tagger.hello a.join ''
    when (self.class.ancestors.include? String)
      Tagger.hello self.to_s
    when (self.class.ancestors.include? Array)
      self.map{|e| Tagger.hello e}
    end
  end
end
class String; include Dogeify end
class Array;  include Dogeify end
Dogeify.dogeify 'a'    #=> "hello a"
"abc".dogeify          #=> "hello abc"
%w(this that).dogeify  #=> ["hello this", "hello that"]

Even better:
class EngTagger; def process(s) "hello #{s}" end end
module Dogeify
  Tagger=EngTagger.new
  public
  extend self
  def dogeify(*a)
    return dogeify_parameters a unless a.empty?
    dogeify_self
  end
  private
  def array_like?(   object) object.respond_to? :map     end
  def regexp_like?(  object) object.is_a?        Regexp  end
  def string_like?(  object) object.is_a?        String  end
  def dogeify_parameters(a ) dogeify_object      a       end
  def dogeify_self(        ) dogeify_object      self    end
  def dogeify_object(object)
    case
    when ( array_like? object) then object.map{|e| dogeify_object e}
    when (regexp_like? object) then object
    when (string_like? object) then Tagger.process object
    else object
    end
  end
end
class String; include Dogeify end
class Array;  include Dogeify end

Dogeify.dogeify 'a'                      #=> "hello a"
"abc".dogeify                            #=> "hello abc"
%w(this that).dogeify                    #=> ["hello this", "hello that"]
[1, %w(this that), 3].dogeify            #=> [1, ["hello this", "hello that"], 3]
['here', /pattern/, 1, 'there'].dogeify  #=> ["hello here", /pattern/, 1, "hello there"]
/pattern/.dogeify                        #=> NoMethodError: undefined method `dogeify' for /pattern/:Regexp

But:
class Object; include Dogeify end
/pattern/.dogeify                        #=> /pattern/


Withdraw the deadline for Backlog Candidates and reopen issues closed from it without accepted pr.

Retirar o prazo para Backlog Candidates e reabrir issues dele fechados sem pr aceito.
Ampliar o prazo candidate for our backlog para infinito e deixar aberto e reopen issues Backlog Candidates que foram fechados e não tem um pull request aceito. Pois tem poucos Backlog Candidates.
[en]
Extend the candidate for our backlog to infinity and leave open issues and backlog candidates that have been closed and do not have a pull request accepted. Because there are few Backlog Candidates.

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

make "upvote feature request" text clearer (#90091)

Bot, esse issue não está duplicado de acordo com o texto da resposta que você enviou!
Bot, this issue is not duplicated according to the text of the reply you sent!


Add support for dameng database

Please support dream database, now we need to add drivers manually,and there are drawbacks to this approach.
1.After the table is created the fields of the table cannot be modified.
2.Incompatible data types.
3.SQL syntax does not match.
4.The UI interaction is not friendly.Exmple,The SQL statement is correct, but a red wavy line is displayed on the UI.
(DM Official website : https://www.dameng.com/)
Requests from Chinese users, thanks

Thank you for the idea.

Duplicate of #10133


[rPi, volumio] SpInit error on startup

Hello,
Unable to start spotify-connect-web, here is the console output:
volumio@volumio:~/spotify-connect-web$ ./spotify-connect-web --username xxxxx --password xxxxx --bitrate 320 --debug
Loading Spotify library...
min_volume_range: 0.0
Using libspotify_embedded version: release-esdk-1.20.0-v1.20.0-g594175d4
ESDK: SpRegisterDebugCallbacks [returned value: 0]
SpInit: 5
SpInit failed, exiting
Any suggestion? Thanks!

Fixed, my spotify_appkey was not downloaded properly...


Loading up site with unique param values?

I have an app that when a user views the site they need to have jwt token and refresh id in the param (?t=aas;kldfjaksdf&r=123), how can I only in development pass in those two params value of my run script so that I can load up the site with those information and the entire app works? Or do you recommend another way?
Right now I am loading up the site https://localhost:3000 and the manually typing in (?t=whatevertoken&r=refreshid), I would like to not do that every time.
Thanks

You can set BROWSER env variable to a custom Node script that opens an arbitrary URL.
See here for some information about this feature: https://github.com/facebookincubator/create-react-app/pull/1590.


Viewer Debugger renders two times + long height

Hello all,
I have no error for this unless it is related to the last issue I posted but when only debug is set to true it render the inspector two times instead of one!
Using 3.3.0.beta-5
Bugs

Expected result: Should render the debugger only once with a normal height
Current result: Render double sometimes even triple times with a very loong loooong height

Warnings on #5056 show up on this too

solved issues with my react re rendering many times

How did you fix it ?


Add example XML snippet

In this type of pages, having an example input or output XML helps a great deal in quickly understanding it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d605f11-eaa8-8a0d-1727-8a6d5531d6ba
Version Independent ID: 69554d83-fede-0a01-2549-d9b51503f781
Content: How to qualify XML element and XML attribute names
Content Source: docs/standard/serialization/how-to-qualify-xml-element-and-xml-attribute-names.md
Product: dotnet-fundamentals
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Thanks for the suggestion -- we'll add examples the next time we update the article, or you're welcome to submit a PR if you have examples you'd like to contribute.

Thanks for the suggestion, but we don’t have the resources to invest in this area, so we are closing the issue. If we get more 👍 responses to the issue, we’ll reconsider.


statsWithin does not affect sales in current data endpoint

When making a request with entries=0, the response has the sale-related properties set to 0, instead of providing stats within the past 7 days. statsWithin should take precedence over entries for the purposes of the DB fetch.

Closing - forgot I had temporarily removed sales from the current data endpoint to debug load issues


Getting Relation columns and tables to fill JSON map

You can generate a map JSON file with a filled ParentTable ParentColumn and ParentSchema.

@AAVision Thank you for adding this! Can you rebase and fix the conflicts? I'll merge once they are fixed.

@junkert Done 👍

Thank you @AAVision !


P110 not showing any sensor data after update to 2.0.0

Version of the integration
2.0.0
Configuration
3 x TAPO P110 HW Version 1.0 FW Version 1.2.3 Build 230425 Rel. 142542
Describe the bug
The  sensors Current Power, Month Energy, Month Runtime, Today Energy and Today runtime all state unknown after update to 2.0.0
I have deleted and manually added them again, als rebooted several times, but state remains unknown.
Debug log
2023-07-06 10:38:12.200 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.044 seconds (success: True)
2023-07-06 10:38:12.416 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.048 seconds (success: True)
2023-07-06 10:38:12.509 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.044 seconds (success: True)
2023-07-06 10:38:16.112 INFO (MainThread) [custom_components.tapo] Unloaded entry for 27c82b3b10884380c3c1d81e18424d92
2023-07-06 10:38:16.122 DEBUG (MainThread) [custom_components.tapo.common_setup] Creating new API to create a coordinator
2023-07-06 10:38:16.364 INFO (MainThread) [custom_components.tapo.coordinators] Login to <IP_ADDRESS>, success: Right True
2023-07-06 10:38:16.409 INFO (MainThread) [custom_components.tapo.coordinators] Detected model of <IP_ADDRESS>: p110
2023-07-06 10:38:16.457 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.047 seconds (success: True)
2023-07-06 10:38:16.534 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.048 seconds (success: True)
2023-07-06 10:38:19.160 INFO (MainThread) [custom_components.tapo] Unloaded entry for 1161cd785ad421b6818c60d4e1a4d46a
2023-07-06 10:38:19.172 DEBUG (MainThread) [custom_components.tapo.common_setup] Creating new API to create a coordinator
2023-07-06 10:38:19.361 INFO (MainThread) [custom_components.tapo.coordinators] Login to <IP_ADDRESS>, success: Right True
2023-07-06 10:38:19.398 INFO (MainThread) [custom_components.tapo.coordinators] Detected model of <IP_ADDRESS>: p110
2023-07-06 10:38:19.445 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.046 seconds (success: True)
2023-07-06 10:38:19.528 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.051 seconds (success: True)
2023-07-06 10:38:22.548 INFO (MainThread) [custom_components.tapo] Unloaded entry for 09566cca8633c6060c878def59a55e83
2023-07-06 10:38:22.552 DEBUG (MainThread) [custom_components.tapo.common_setup] Creating new API to create a coordinator
2023-07-06 10:38:22.753 INFO (MainThread) [custom_components.tapo.coordinators] Login to <IP_ADDRESS>, success: Right True
2023-07-06 10:38:22.797 INFO (MainThread) [custom_components.tapo.coordinators] Detected model of <IP_ADDRESS>: p110
2023-07-06 10:38:22.844 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.046 seconds (success: True)
2023-07-06 10:38:22.923 DEBUG (MainThread) [custom_components.tapo.coordinators] Finished fetching tapo data in 0.047 seconds (success: True)

Also P115

Same problem here.

Same for me, tried deletion and re-adding but still the same. I also noticed a firmware update avaliable for the plugs, I did this and restarted both plug and HA but still the same, No sensor data

As a workaround for now, i have deleted all the files in the /config/custom_components/tapo folder. After that i re-installed the 1.7.1 version and restarted HA. This has, for now, resolved my issue.

Probable duplicate of #423

Until a fix is avalaible I am restoring from backup

Fix in https://github.com/petretiandrea/home-assistant-tapo-p100/issues/423
Works for me


Nagle's Algorithm in nodejs-websocket ?

Not really an issue, just a question.
Does nodejs-websocket make use of Nagle's Algorithm?
If so, how do I turn it off?

Hello @Logstone
This module uses Node.js' core socket implementation. You can access the underlying socket object via the socket property
From Node docs:

By default TCP connections use the Nagle algorithm

So yes, websockets created with this lib have Nagle's algorithm on by default. You can change that via socket.setNoDelay([noDelay])


⚠ Samsung has degraded performance

In 5029128, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2678 ms

Resolved: Samsung performance has improved in aed6824.


feat: use Docker to build

Hi @Decagon,
Not sure if you're taking PRs.
Just added a Dockerfile to make it easier to try out - see README changes for usage.
Thanks for the repo btw!

Thanks for the PR! I changed the dependencies of hofs-churn; could you update your Dockerfile and part in the README.md to reflect the new changes? Thanks!


bump go to 1.20; bump go dependencies

As elastx uses k8s clusters are now running 1.25,
we cannot use 1.27 APIs at this point. Safest choice is to use 1.26.
Note: the build scripts seem to be broken, likely due to the go upgrade to 1.20.
I would need some help here to fix this, as go is not my expertise.

I think you want to do something like this: https://github.com/qvicksilver/elx-nodegroup-controller/tree/kubebuilder-v4
Haven't tested very much but at least it builds.

@qvicksilver i had bumped to 1.26 for the reasons of not running too far ahead of the current version of my cluster and secondly also because the types of some packages changed requiring some code changes. What you have there looks very good! I can give it a test spin if you like to verify it.

I'm a bit late to the party however we are working on updating this controller.
We have a PR: https://github.com/elastx/elx-nodegroup-controller/pull/5 to update to modern versions of everything and start working on dynamic node matching. Currently it's tailored towards our kubernetes service but we will also look into some kind of label match for cluster with "randomized" node names.
With that I'll mark this PR as closed in favor of the above mentioned one


BLD: Re-enable /EHsc and fvisibility flags

gh-16165 removed /EHsc and -fvisibility=hidden flags, for reasons
that aren't clear to me. So this returns them and writes it in a more
meson-ic way (if that's a word).

Looking at mesonbuild/meson#10369, the visibility doesn't defaults to hidden when language=cpp which is the case for both of these.

Looking at that PR, I think what it does is set inlineshidden for C++ and hidden for C. The description of gnu_symbol_visibility says: This value can either be an empty string or one of default, internal, hidden, protected or inlineshidden, which is the same as hidden but also includes things like C++ implicit constructors as specified in the GCC manual. Ignored on compilers that do not support GNU visibility arguments.. So I think it actually hides more for C++.

Hrm, you're right. When I try it out it passes both -fvisibility=hidden and -fvisibility-inlines-hidden. Whereas on its own, -fvisibility-inlines-hidden is less restrictive because non-inline functions won't be hidden.

Looking at mesonbuild/meson#10369, the visibility doesn't defaults to hidden when language=cpp which I think is the case for both of these.

Actually, it defaults to inlineshidden for both C and C++, but that then gets reset to hidden inside the compiler class for source files that don't support the "inlines" part.


⚠ Bofrost.fr has degraded performance

In 95d22bf, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1156 ms

Resolved: Bofrost.fr performance has improved in c2518a7.


Range Inputs are not styled on mobile.

The range sliders are not styled at all on Chrome and Edge on mobile on Bootstrap 4.5
It is partially styled on Firefox mobile, lacking the blue strip.
I was planning to make a simple demo, but realized that it is already visible on bootstrap 4.5 documentation on forms.
I thought that it would be enough for a demo.
I tried them on:
Edge version <IP_ADDRESS>74
Chrome 85.0.4183.127
Firefox 81.1.1 (Build #2015764545)
On a: Samsung SM-G611F
Android 9 on Kernel 3.18.91-15922581
Chrome:
Edge:
Firefox:

I checked on Bootstrap 5 alpha page that it is rendered correctly there.

@coliff's comment is correct.

Thanks, that helped.


[FEATURE] make resolution and year as required property in publish page

Feature Description
bring resolution and year tag under general tab and make them required property to force users to select it.
then, remove them from tags tab

Feature Implementation
No response
Feature Alternatives
No response
Feature Impact
No response
Feature Rationale
No response
Feature Considerations
No response
Feature Requirements
No response
┆Issue is synchronized with this Wrike task by Unito

according to the feedback from @iferencik, no one in UNDP want to input these information if they are required. And there might be some metadata missing some of information like year and resolution in the document of original data.
I can bring year and resolution more visible in editor, but it can still remain as optional.


Build provider binaries for all GOOS+GOARCH combinations

The "build for all providers" github action builds binaries only for the amd64 architecture. This PR changes that to allow creation of binaries across the board for all GOOS/GOARCH combinations.
While this commit registers as a rewrite (due to indentation changes), git diff -w gives a clearer picture of the change I've made:
samveen@zero2w:~/workspace/terraformer $ git diff -w HEAD^ HEAD |cat
diff --git a/build/multi-build/main.go b/build/multi-build/main.go
index e4dad148..8b6f3834 100644
--- a/build/multi-build/main.go
+++ b/build/multi-build/main.go
@@ -28,6 +28,7 @@ func main() {
 			allProviders = append(allProviders, providerName)
 		}
 	}
+	for _, arch :=  []string{"amd64", "arm64"} {
 		for _, OS := range []string{"linux", "windows", "mac"} {
 			for _, provider := range allProviders {
 				GOOS := ""
@@ -35,15 +36,15 @@ func main() {
 				switch OS {
 				case "linux":
 					GOOS = "linux"
-				binaryName = "terraformer-" + provider + "-linux-amd64"
+					binaryName = "terraformer-" + provider + "-linux-" + arch
 				case "windows":
 					GOOS = "windows"
-				binaryName = "terraformer-" + provider + "-windows-amd64.exe"
+					binaryName = "terraformer-" + provider + "-windows-" + arch + ".exe"
 				case "mac":
 					GOOS = "darwin"
-				binaryName = "terraformer-" + provider + "-darwin-amd64"
+					binaryName = "terraformer-" + provider + "-darwin-" + arch
 				}
-			log.Println("Build terraformer with "+provider+" provider...", "GOOS=", GOOS)
+				log.Println("Build terraformer with "+provider+" provider...", "GOOS=", GOOS, " for GOARCH=",arch)
 				deletedProvider := []string{}
 				for _, f := range files {
 					if strings.HasPrefix(f.Name(), filePrefix) {
@@ -94,6 +95,7 @@ func main() {
 				cmd := exec.Command("go", "build", "-v", "-o", binaryName)
 				cmd.Env = os.Environ()
 				cmd.Env = append(cmd.Env, "GOOS="+GOOS)
+				cmd.Env = append(cmd.Env, "GOARCH="+arch)
 				var outb, errb bytes.Buffer
 				cmd.Stdout = &outb
 				cmd.Stderr = &errb
@@ -117,3 +119,4 @@ func main() {
 			}
 		}
 	}
+}

CLA signed.

Maintainers, please get the checks run so that I can fix things it they're broken.


AttributeError: module 'grpc.experimental.aio' has no attribute 'StreamUnaryCall'

Upgrading to the latest version has produced the following error:
AttributeError: module 'grpc.experimental.aio' has no attribute 'StreamUnaryCall'
We have reverted back to the previous version, which isn't facing this issue, but flagging it here, as it will affect others.
It seems to be the same issue as raised here for google-api-core
Environment details

Python version: 3.7.3
google-cloud-datacatalog version: 1.0.0

Steps to reproduce

See stack trace below, it happens on importing the datacatalog client

Stack trace
from google.cloud import datacatalog
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<%APPDATA%>\Python\Python37\site-packages\google\cloud\datacatalog.py", line 20, in <module>
    from google.cloud.datacatalog_v1beta1 import DataCatalogClient
  File "<%APPDATA%>\Python\Python37\site-packages\google\cloud\datacatalog_v1beta1\__init__.py", line 23, in <module>
    from google.cloud.datacatalog_v1beta1.gapic import data_catalog_client
  File "<%APPDATA%>\Python\Python37\site-packages\google\cloud\datacatalog_v1beta1\gapic\data_catalog_client.py", line 25, in <module>
    import google.api_core.gapic_v1.client_info
  File "<%APPDATA%>\Python\Python37\site-packages\google\api_core\gapic_v1\__init__.py", line 26, in <module>
    from google.api_core.gapic_v1 import method_async  # noqa: F401
  File "<%APPDATA%>\Python\Python37\site-packages\google\api_core\gapic_v1\method_async.py", line 20, in <module>
    from google.api_core import general_helpers, grpc_helpers_async
  File "<%APPDATA%>\Python\Python37\site-packages\google\api_core\grpc_helpers_async.py", line 145, in <module>
    class _WrappedStreamUnaryCall(_WrappedUnaryResponseMixin, _WrappedStreamRequestMixin, aio.StreamUnaryCall):
AttributeError: module 'grpc.experimental.aio' has no attribute 'StreamUnaryCall'

Looks to be an issue with one of the other packages - after applying a pip --force-reinstall, this issue has resolved itself


Force ReRender When .map Completes

Hello,
I am trying to use the swiper by populating it with a variable number of components based on an array. However, it seems the swiper needs to be rerendered after the map completes.
const colorParams = {
  slidesPerView: 3,
  spaceBetween: 30,
  freeMode: true,
  rebuildOnUpdate: true
};

<Swiper {...colorParams}>
  {
    ColorOptions.map((color) => {
      return (
        <ColorCircle /> /* puedo component code */
      );
   })
 }
</Swiper>

I don't see anything in the docs about this and am hoping I'm just missing something. All of my other testing looks to work fine up until I try to populate the slider with a map method.

Hi @yuschick , u can use params rebuildOnUpdate: true or shouldSwiperUpdate : true.  If u wanna rebuild Swiper each time component got re-rendered , just use rebuildOnUpdate. If u wanna update Swiper only, just use shouldSwiperUpdate

I have the same issue and not working with shouldSwiperUpdate  and rebuildOnUpdate .

such a beautiful tool but doesnt work with map well, at tried above methods rebuildOnUpdate, at first run it doesnt work but if you navigate to any other page with router and come back it works, dont know how to fix it .. wish it worked well with fetched data from db via redux store .... 👎

worked like a charm i was using it in params but should be used like below
<Swiper {...params} shouldSwiperUpdate>

It's not working!

In your object colorParams include the following propertie
rebuildOnUpdate: true

Neither props are recognized by react...
React does not recognize the rebuildOnUpdate prop
React does not recognize the shouldSwiperUpdate prop

I've tested them today and rebuildOnUpdate + shouldSwiperUpdate still don't work in react. We need something like this for some maps with more logic.

I've tested them today and rebuildOnUpdate + shouldSwiperUpdate still don't work in react. We need something like this for some maps with more logic.

hey, any updates ?


[Android] Not showing Local notification when app is Open on release mode

I am using Notifee version "7.4.0"
react-native-firebase version "15.7.1"
This is my Code:
const onDisplayNotification = async (notification) => {
try {
// Request permissions (required for iOS)
await notifee.requestPermission()
// Android
  // Create a channel (required for Android)
  const channelId = await notifee.createChannel({
    id: 'appchanel',
    name: 'appchanel',
    vibration: true,
    sound: 'default',
    importance: AndroidImportance.HIGH,
    vibrationPattern: [300, 500],
  });
  const settings = await notifee.getNotificationSettings();
  if (settings.authorizationStatus == AuthorizationStatus.AUTHORIZED) {
    console.log('Notification permissions has been authorized');
  } else if (settings.authorizationStatus == AuthorizationStatus.DENIED) {
    console.log('Notification permissions has been denied');

    let result = await notifee.openNotificationSettings(channelId)
  }
  // Display a notification
  let result = await notifee.displayNotification({
    title: notification.title,
    body: notification.body,
    android: {
      channelId,
      smallIcon: 'ic_launcher', // optional, defaults to 'ic_launcher'.
      // // pressAction is needed if you want the notification to open the app when pressed
      pressAction: {
        id: channelId,
      },
      sound: 'default',
      vibrationPattern: [300, 500],
      asForegroundService: true,
    },
    ios: {
      // iOS resource (.wav, aiff, .caf)
      sound: 'default',
    }
  });
  console.log('notifee.displayNotification: ', result);
} catch (error) {
  console.log('error: ', error);
}

}

is it working in debug mode ? i couldnt see notification in both mode on Android but Ios working well. My compiler and target versions are 33 and my Android real device is latest version of Android

Yes. iOS working well.
But android. debug mode is working. But release mode, app not show notification
and also i was set target version are 33
ext {
buildToolsVersion = "29.0.3"
minSdkVersion = 26
compileSdkVersion = 33
targetSdkVersion = 33
ndkVersion = "20.1.5948944"
}

hi, please can you log what the error is (as i see you have a try/catch)? Should be able to see this in the logcat. Also, i'd recommend testing a basic notification first in release mode without the foreground service and vibration pattern.

Closing due to lack of information and lack of activity

don't forget to add this line  in AndroidManifest.xml
    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>


Improve Travis config

Some improvements can be made to Travis config:

[x] Test failures can be accumulated, so that it is easier to see what else is broken
[x] Xcode-related fields can be removed as we do custom build steps
[x] Use xcpretty to format output

@srdanrasic Ready for merge.

Looking good :)


Add issue templates for bugs, documentation, features, and others.

Hi @Abhijay007 I tried creating the YAML forms for Issue#81 and added them to the ISSUE_TEMPLATES  directory.  Please take a look when you have time and let me know if I need to make changes. Thank you

I will take a look later today.
On Sat, Oct 21, 2023, 9:34 AM Abhijay Jain @.***> wrote:

@.**** approved this pull request.
LGTM 👍
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uptane_uptane.github.io_pull_95-23pullrequestreview-2D1691259388&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=6EUMMBozkgK8WHd9Shiis5q6nN0m7io87yuLKW77OBl4xgRrDSXvvZsovXSCCqJ8&s=__M03oj2FfG6FImJ5hX5KO_CXCLf7kChtjuov6oTxXw&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADPGUX4K2ISEBAMWKN7NMMTYAPFMZAVCNFSM6AAAAAA6KEZVHOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJRGI2TSMZYHA&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=6EUMMBozkgK8WHd9Shiis5q6nN0m7io87yuLKW77OBl4xgRrDSXvvZsovXSCCqJ8&s=LNQG1zipd8nnQiIJXzoGDwxH93udTYJIIF1x9xnR-Ls&e=
.
You are receiving this because your review was requested.Message ID:
@.***>


docs: updating the hdkey ADR  [skip ci]

Description:
Updating the ADR to reflect the recent changes in bip32 derivation.
Mainly, secp256k1 stays the same.
We introduce now HDKeys for Ed25519, those will be using  different bip32 implementation.
The ADR changes are to reflect this but no more changes have been done to the derivationPath specification.
Requires no cloud agent changes as that is already implemented.
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

@elribonazo, you need to merge this PR with the megalinter fixes.
If you add [skip ci] to the end of the PR name, it will pass much faster.

@elribonazo, you need to merge this PR with the megalinter fixes. If you add [skip ci] to the end of the PR name, it will pass much faster.

Done


octave-kernel: fix broken logo path and modernize meta

Description of changes
This kernel is currently broken due to a change in the path to the logo PNG upstream. This PR fixes it and also modernizes the meta field slightly.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2474

This PR fixes it and also modernizes the meta field slightly.

This is nonsense, it does not matter if meta is using with lib or not and neither is more modern than the other.

@SuperSandro2000 so I would have thought, but a previous reviewer felt strongly about it:
https://github.com/NixOS/nixpkgs/pull/244775#issuecomment-1647725642

He is at least partly wrong about it. nil, probably the best lsp right now, can handle with lib properly in some cases already and I only expect it to become better over time. There is currently no tool I know which falls apart when with lib is used and honestly it would probably be pretty weak if it couldn't handle this.


Upgrade recharts to 2.1.9

The current version of recharts does not properly display the area chart required for issue #17.  This problem is solved in version 2.1.9

I should be able to open a quick PR for this tonight - I'm also tinkering with existing graphs for the #28 so I want to make sure they don't break on upgrade

This will be done in PR #43


remove java-7 as the preferred 'java'

When I run java in this container, I get Java 7, which is confusing. It's actually got both Javas installed.
This does the symlink change so that java gets the expected Java 8.

 You're right; I was running inside a secondary container where I'd installed Maven (and apt-get install maven install jdk-7 and messed up my links).
Sorry for the confusion.


⚠ Bofrost.at has degraded performance

In ce539ef, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1345 ms

Resolved: Bofrost.at performance has improved in a5db449.


Answer "What does Line Notation refer to in the field Cheminformatics?"

@koustavpan Try to come up with more informative PR titles in the future.

@koustavpan You should merge the PRs post approval


Add CONTRIBUTING.md

Resolve #3
@gtema Please check, if contributing guide is compliant with OTC open source approach

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   64.25%   64.25%
=======================================
  Files           5        5
  Lines         870      870
=======================================
  Hits          559      559
  Misses        208      208
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0dca57...45d8965. Read the comment docs.


Remaining dbt models

What is it?

[x] Add artifact_id, project_id, and collection_id, which will need to be added to basically every table.
[x] user_namespace in the projects and collections. (should our namespace be oso?)
[x] artifact_current_name - need to be able to search by the current name, type, namespace
[ ] collection event tables (daily, weekly, monthly), (to, from)

And this issue afterwards
https://github.com/opensource-observer/oso/issues/841

[ ] artifacts_by_project_slugs. Let's include artifact_latest_name, artifact_id, and project_id, project_user_namespace
[ ] projects_by_collection_slugs. We should similarly include project_id, collection_id, collection_user_namespace, project_user_namespace
[ ] I think we're still missing events_daily/weekly/monthly_to/from_collection
[ ] More minor, for first/last contribution, is artifact_id => from_artifact_id, and project_id => to_project_id? Just trying to be clear which is the from and to

@ryscheng use artifacts_by_project and projects_by_collection. The from/to collection should be there.

@ryscheng closing for now. as I believe this was all completed.


Merge uniswap example from plutus-pioneer-program to plutus-pab

Area
[] Plutus Foundation Related to the GHC plugin, Haskell-to-Plutus compiler, on-chain code
[x] Plutus Application Framework Related to the Plutus application backend (PAB), emulator, Plutus libraries
[] Marlowe Related to Marlowe
[] Other Any other topic (Playgrounds, etc.)
Describe the feature you'd like
Currently there are two versions of the Uniswap example: one in plutus and another one is in https://github.com/input-output-hk/plutus-pioneer-program. The suggestion is try and merge the pioneer version of starting Uniswap example and make one unique version that can be used as a reference for Plutus example.

The actual Uniswap pab uses the contract from plutus (https://github.com/input-output-hk/plutus-pioneer-program/blob/main/code/week10/app/uniswap-pab.hs#L25). I guess the question why there is yet another Uniswap contract should be asked in the issue in the plutus-pioneer-program repo.

That was a part of Lars's Pioneer Program lectures where it is explained how Uniswap is working and example usage to launch locally. The difference is that the plutus's version of PAB for uniswap starts some pools before starting to accept requests from the outside. But the pioneer's version does not, since it tries to walk through developers to get to work with the dApp from clean slate.
So the point of an issue is try to merge these changes back to plutus repository and make as a sinlge source of truth to help guide developers to get familiar with this contract example.

Had a brief chat about this with @kelizarov - this issue is just about making the "Create liquidity pool" bit of the initialization code optional in the plutus-pab example:
https://github.com/input-output-hk/plutus/blob/master/plutus-pab/examples/uniswap/Main.hs#L73-L81
I'll reopen this, we can tackle it in the next sprint, if nobody else gets to it first.


Is there a non-Express way to add https to my Facebook bot?

I'm done with local development and am trying to get production setup. However, I can't figure out how to make the webserver an https one. I saw this but it wasn't helpful. Do I have to create my own Express server for this to work or is there an easier way to do this?

I always use Nginx and it's reverse proxy option to forward traffic to the Express server, IMO just makes it easier to add certs with things like Lets Encrypt.
These might help you out though
https://github.com/Daplie/greenlock-express
https://community.apigee.com/articles/28041/nodejs-and-self-signed-ssl-certificates.html

I recently solved a similar problem. I used Nginx as a web server, installed a valid SSL certificate so that it can run on HTTPS. This isn't the hard part, just Google around for a guide on how to get and install a valid SSL certificate on Nginx.
The harder part is taking all port 443 and port 80 traffic and redirecting it to a new port. This new port is the one you'll start botkit on. This article was really helpful for me in showing how to forward all traffic from one port to another with Nginx. Good luck!

The easiest way I found @bencooper222 was to setup an AWS account. Setup an EC2 instance for Ubuntu.
Follow this guide on DigitalOcean - https://www.digitalocean.com/community/tutorials/how-to-set-up-a-node-js-application-for-production-on-ubuntu-14-04
Once you've done that. You can load balance your ec2 instance, AWS gives you a checkbox to basically say, do you want to use an SSL certificate. You select yes, setup your server and there. You have a server using https and since you followed the digitalocean all you should the routes setup for proxying or at least, can understand enough of the tutorial that you can find and change what you need to get it setup.

Thanks all!


Remove duplicate code

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (334bdba) to head (97fcc0a).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #472   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           96        96
  Lines         2503      2488   -15
  Branches       224       224
=========================================
- Hits          2503      2488   -15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


A re-used terminal doesn't always fire an onExit event.

Related to #54397.
@EricJizbaMSFTcreated an example that shows this very nicely: https://github.com/EricJizbaMSFT/helloworldext
Run the debug launch config to repro. Once the second task in the prelaunch starts, run the Terminate Task command.
Expected: There is a terminal onExit event
Actual: Since the terminal was re-used and some clean up was missed, it thinks that this second call to TerminalInstance _onProcessExit is spurious and does not fire the event or do any of the _onProcessExit tear down.
The clean up that's missed is in reuseTerminal:
	if (this._isExiting && this._shellLaunchConfig.waitOnExit) {
		this._xterm.setOption('disableStdin', false);
		this._isExiting = false;
	}

because this._shellLaunchConfig.waitOnExit is false. In this case, waitOnExit is false because the task terminal reveal is set to Never, and the task is a background task. This is the info for the new task, not the old one. It looks like an ordering issue.

@alexr00 Not sure how to verify. I don't see a second task in the prelaunch.

Verifying #54397 will also verify this one.


I generated my cert with the cert-only command with letsencrypt and left it in the /etc/letsencrypt/live folder.

Hi @Dynamite874, are you sure your LE certs a correctly mounted?
Can I see your folder setup and docker-compose.yml file?
Thank you.

Here is my test using your command:
$ docker exec mail openssl s_client -connect <IP_ADDRESS>:25 -starttls smtp -CApath /etc/ssl/certs/
depth=2 O = Digital Signature Trust Co., CN = DST Root CA X3
verify return:1
depth=1 C = US, O = Let's Encrypt, CN = Let's Encrypt Authority X1
verify return:1
depth=0 CN = domain.com
verify return:1
CONNECTED(00000003)
---
Certificate chain
 0 s:/CN=domain.com
   i:/C=US/O=Let's Encrypt/CN=Let's Encrypt Authority X1
 1 s:/C=US/O=Let's Encrypt/CN=Let's Encrypt Authority X1
   i:/O=Digital Signature Trust Co./CN=DST Root CA X3
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIF
...
==
-----END CERTIFICATE-----
subject=/CN=domain.com
issuer=/C=US/O=Let's Encrypt/CN=Let's Encrypt Authority X1
---
No client certificate CA names sent
---
SSL handshake has read 3316 bytes and written 456 bytes
---
New, TLSv1/SSLv3, Cipher is ECDHE-RSA-AES256-GCM-SHA384
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-AES256-GCM-SHA384
    Session-ID: 28429B71D7EDB42EFED18E93E2B6604CDB48957D1D979241F9D4F665D51E5EE2
    Session-ID-ctx:
    Master-Key: 6C23219EA467BBE1FC8D76AE3A9E7805A7AA29D031AE43F38465DD1E008D86178F690FA7EF88C6402A53F7EA01814BE1
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time:<PHONE_NUMBER>
    Timeout   : 300 (sec)
    Verify return code: 0 (ok)
---
250 DSN
DONE

Not sure what you mean by correctly mounted that may be the issue :).
`root@cg-docker1:~/mail# nano docker-compose.yml
GNU nano 2.2.6                                                               File: docker-compose.yml
maildata:
image: ubuntu
volumes:
- /var/mail
command: /bin/true
mail:
image: "tvial/docker-mailserver"
hostname: mail
domainname: clevergirls.tv
volumes_from:

maildata
ports:
"25:25"
"143:143"
"587:587"
"993:993"
volumes:
./spamassassin:/tmp/spamassassin/
./postfix:/tmp/postfix/
./opendkim/keys:/etc/opendkim/keys
./letsencrypt/etc:/etc/letsencrypt
environment:
DMS_SSL=letsencrypt
ENABLE_POP3=1

`

I am getting this from google

What is Google usage here?

Google is what I am using to connect to the server. So the mail client, I
am assuming the errors google is giving me is due to the config I have for
the mail server.
Sorry for not being clear about that.
--
Will Wright
<EMAIL_ADDRESS>http://willsworkspace.co.uk
On 3 March 2016 at 14:42, Thomas VIAL<EMAIL_ADDRESS>wrote:

I am getting this from google
What is Google usage here?
—
Reply to this email directly or view it on GitHub
https://github.com/tomav/docker-mailserver/issues/94#issuecomment-191792589
.

This might not be a issue with the mailserver anymore, seem to be having a
issue with my server MX records :). You should be able to close this now.
Thanks for the help.
--
Will Wright
<EMAIL_ADDRESS>http://willsworkspace.co.uk
On 3 March 2016 at 15:01, Will Wright<EMAIL_ADDRESS>wrote:

Google is what I am using to connect to the server. So the mail client, I
am assuming the errors google is giving me is due to the config I have for
the mail server.
Sorry for not being clear about that.
--
Will Wright
<EMAIL_ADDRESS>http://willsworkspace.co.uk
On 3 March 2016 at 14:42, Thomas VIAL<EMAIL_ADDRESS>wrote:

I am getting this from google
What is Google usage here?
—
Reply to this email directly or view it on GitHub
https://github.com/tomav/docker-mailserver/issues/94#issuecomment-191792589
.

Or perhaps Google is waiting for special SSL ciphers... Let's close this issue since not directly related to features provided by the image.
But feel free to contribute if needed.


Build is Crashing on auto CI/CD github

Bug report

What is the current behavior?
I am facing this issue on ci github build and deploy  for the react
ERROR in vendor.866ce385a84cdb53c394.chunk.js from Terser
Error: Call retries were exceeded
If the current behavior is a bug, please provide the steps to reproduce.
I am using webpack
"webpack": "4.46.0",
"terser-webpack-plugin": "^4.2.3",

What is the expected behavior?

Other relevant information:
webpack version:  4.46.0
Node.js version: 16.15.0
Operating System: ubuntu-latest
Additional tools:

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.


workflows: community: Update actions/checkout to v4

Hi @Sushrut1101 ,
Thanks for opening this PR,
Can you please provide any documentation to this version upgrade ?


Possible Epic fight Compatibility?

As the title states, would it be possible to add compatibility with epic fight mod, specifically, the key binds used?
By default, for example when trying to use, the attack key bind from epic fight, any code does not work, and you will just attack.

Hi, you are able to modify which keys are used through datapack. Origins itself isn't really supposed to be designed around having Epic Fight, so your best bet is to look at Epic Fight's keybind ids, and replace parts of powers with them.


Make the gallery card clickable

I miss click severals times because only the Read more text is clickable. Now the whole gallery card is clickable

awesome! 🔥


Early Login: Homepage is displayed after signing out

Environment Details
Spartacus: develop
Browser: Chrome
Device: mac
Happens on: https://dev-com-10.accdemo.b2c.ydev.hybris.com:4200/electronics-spa/en/USD/login
Steps to Reproduce

enable early login

routing: {
   protected: true,
   /* ... */
}

Sign in
Sign out

Actual Result
Upon signing out, the homepage is displayed.
Expected Result
The login page should be displayed instead.

Currently we might not have /logout page in CMS.
Will look into that


Make health check path configurable

The code in health.rs does a basic check to / only. We should make it configurable.
Note: While we are waiting on a configuration file format, we can set the value in src/alacrity.rs or something. The important part is that the health check code is not hardcoding the value.

Fixed in https://github.com/hjr3/weldr/pull/100


CheckRackLabels patching is ignored?

What happened?
In this comment on PR: https://github.com/k8ssandra/cass-operator/pull/698#issuecomment-2434637388
The StS labels were not changed in CheckRackLabels() for some reason. We need to investigate if we can replicate this or if this was just something Kubernetes opted not to do in this test run.
The unit tests have not caught this sort of behavior.
What did you expect to happen?
CheckRackLabels() should always update the StS ObjectMeta labels (not Spec labels) on every run.
How can we reproduce it (as minimally and precisely as possible)?
Not known.
cass-operator version
1.22.4
Kubernetes version

Method of installation
No response
Anything else we need to know?
No response
┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-74

This unit test seems to work fine for StS:
func TestCheckRackLabels(t *testing.T) {
	rc, _, cleanupMockScr := setupTest()
	defer cleanupMockScr()
	require := require.New(t)
	err := rc.CalculateRackInformation()
	require.NoError(err)

	desiredStatefulSet, err := newStatefulSetForCassandraDatacenter(
		nil,
		"default",
		rc.Datacenter,
		3)
	require.NoErrorf(err, "error occurred creating statefulset")

	desiredStatefulSet.Status.ReadyReplicas = *desiredStatefulSet.Spec.Replicas

	trackObjects := []runtime.Object{
		desiredStatefulSet,
		rc.Datacenter,
	}
	rc.Client = fake.NewClientBuilder().WithStatusSubresource(rc.Datacenter).WithRuntimeObjects(trackObjects...).Build()

	rc.statefulSets = []*appsv1.StatefulSet{desiredStatefulSet}

	res := rc.CheckRackLabels()
	require.Equal(result.Continue(), res, "Label updates should not cause errors")
	require.Subset(desiredStatefulSet.Labels, rc.Datacenter.GetRackLabels("default"))
	desiredStatefulSet.Labels[api.RackLabel] = "r1"
	require.NotSubset(desiredStatefulSet.Labels, rc.Datacenter.GetRackLabels("default"))

	res = rc.CheckRackLabels()
	require.Equal(result.Continue(), res, "Label updates should not cause errors")
	require.Subset(desiredStatefulSet.Labels, rc.Datacenter.GetRackLabels("default"))
}

I can't replicate this behavior with manual testing either.

In manual testing, I do:
make create-kind-cluster cert-manager # (from k8ssandra-operator)
helm install --namespace cass-operator --create-namespace k8ssandra k8ssandra/cass-operator --set global.clusterScoped=true
kubectl apply -f tests/testdata/default-three-rack-three-node-dc-4x.yaml #(with some changes to the manifest so we have `datacenterName: DC&n_!!` and `size: 1`)
 helm upgrade --namespace cass-operator k8ssandra k8ssandra/cass-operator --reuse-values --set image.registry="michaelburman290" --set image.tag="v1.22.4-dev.a08e8eb-20241024"

I had to go manually edit the cass-operator deployment to get michaelburman290/cass-operator:v1.22.4-dev.a08e8eb-20241024 as image.
I then see:
template:
      metadata:
        creationTimestamp: null
        labels:
          app.kubernetes.io/created-by: cass-operator
          app.kubernetes.io/instance: cassandra-cluster1
          app.kubernetes.io/managed-by: cass-operator
          app.kubernetes.io/name: cassandra
          app.kubernetes.io/version: 4.1.6
          cassandra.datastax.com/cluster: cluster1
          cassandra.datastax.com/datacenter: DCn
          cassandra.datastax.com/node-state: Ready-to-Start
          cassandra.datastax.com/rack: default
...
metadata:
    annotations:
      cassandra.datastax.com/resource-hash: cnWZxVtbq2P3v/qFieMCgdJulBmPuFbG/d+kOF27N1Y=
    creationTimestamp: "2024-10-25T03:39:04Z"
    generation: 1
    labels:
      app.kubernetes.io/created-by: cass-operator
      app.kubernetes.io/instance: cassandra-cluster1
      app.kubernetes.io/managed-by: cass-operator
      app.kubernetes.io/name: cassandra
      app.kubernetes.io/version: 4.1.6
      cassandra.datastax.com/cluster: cluster1
      cassandra.datastax.com/datacenter: DCn
      cassandra.datastax.com/rack: default
...

I waited another 10 minutes just to be sure, eventually indeed I got:
metadata:
    annotations:
      cassandra.datastax.com/resource-hash: cnWZxVtbq2P3v/qFieMCgdJulBmPuFbG/d+kOF27N1Y=
    creationTimestamp: "2024-10-25T03:39:04Z"
    generation: 1
    labels:
      app.kubernetes.io/created-by: cass-operator
      app.kubernetes.io/instance: cassandra-cluster1
      app.kubernetes.io/managed-by: cass-operator
      app.kubernetes.io/name: cassandra
      app.kubernetes.io/version: 4.1.6
      cassandra.datastax.com/cluster: cluster1
      cassandra.datastax.com/datacenter: test-dc
      cassandra.datastax.com/rack: default
    name: cluster1-dcn-default-sts

So it looks like I just wasn't waiting long enough.
I do wonder whether the selector.matchLabels and template.metadata.labels fields will come back to bite us, as they never get updated (by design).
Is this a weird little bit of hidden complexity that we should try to iron out?

I do wonder whether the selector.matchLabels and template.metadata.labels fields will come back to bite us, as they never get updated (by design).

They get updated once it's allowed. So once there's any change to CassandraDatacenter object or allowupdate-spec=once/always is set as annotation, we will update them.


update experiment_state

What problem does this PR solve?
update experiment_state
What is changed and how does it work?
update experiment_state
Check List
Tests

No code

Code changes

Has Go code change

Side effects

NO

Related changes

NO

Does this PR introduce a user-facing change?:

NONE

Codecov Report

Merging #558 into master will decrease coverage by 5.22%.
The diff coverage is 40.84%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   61.39%   56.16%   -5.23%
==========================================
  Files          64       67       +3
  Lines        4069     4307     +238
==========================================
- Hits         2498     2419      -79
- Misses       1383     1717     +334
+ Partials      188      171      -17

Impacted Files
Coverage Δ

controllers/kernelchaos_controller.go
0.00% <0.00%> (ø)

controllers/podchaos/types.go
65.95% <0.00%> (ø)

controllers/stresschaos_controller.go
0.00% <0.00%> (ø)

pkg/chaosdaemon/netem_linux.go
26.66% <0.00%> (ø)

pkg/chaosdaemon/netlink_linux.go
0.00% <ø> (ø)

pkg/chaosdaemon/stress_server_linux.go
0.00% <0.00%> (ø)

pkg/utils/chaosdaemon.go
51.21% <ø> (ø)

pkg/webhook/config/config.go
17.14% <ø> (-72.86%)
:arrow_down:

pkg/webhook/config/watcher/config.go
41.66% <ø> (-58.34%)
:arrow_down:

pkg/webhook/config/watcher/util.go
75.00% <ø> (ø)

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d798a...14e21ad. Read the comment docs.

/merge


Is master on pip?

Running into an issue with utils.apply_modifications on Windows that the temporary directory is not Windows compatible, but I noticed the issue has been addressed on master branch. The current version I can get from pip is 0.4.1 which was released a year ago. Is there a version that I'm missing?

I think that the fix has not been released yet.
I installed it directly from master branch.
pip install git+https://github.com/raghakot/keras-vis.git

Any idea when the fix is going to be released?


Grammar and flow improvements in some of the intro and basic docs

This is mostly small tweaks, punctuation, etc. They're general improvements that I split off from #1010 as I figured that there was less potential for these edits to alter the intent of the content, and, hence, the likelihood of the PR being accepted.

Thanks a lot! :grin: looks good!

Hey, thank you so much for this. :+1:


Navigation inside decompiled files

I see that vscode now has support for navigation inside a decompiled file. This is not the case for this plugin. It only has some very simple hover information on some things.
I want to be able to keep navigating in the decompiled files.
Currently, we are falling back to the currently attached solution, and I think that was the case for vscode previously, but it seems they must have changed something to make it better

I am able to navigate through decompiled files, is this still an issue ? or was it just fixed lately ?

I tested this yesterday when I opened the issue🤔 do you have a small video of you doing this? I am able to navigate to a decompiled file, but I can't continue navigating

Can confirm this works fine for me too, same behaviour as vscode, gd works fine inside decompiled files even to other decompiled files. I can record something in a test project when i can.

Super weird

yes, I have the same issue. It can't go to other definition of the decompiled file.


Should we remove the tabbed tables on rental#show?

Since we're unlikely to have an overwhelming number of incurred incidentals, I think it would make more sense to display these tabbed tables one after another. This would allow users to see the big "Total Amount Due" as well as the pricing breakdown without having to do any clicking.

i think its fine if you want to

It doesn't matter with me because if you print the copy, the incurred_incidentals and financial_trans are stacked with each other already. If anything, I think it would be better to have financial_transactions 'active' or first in the the tabbed tables.

How does this look to y'all?

:eyes: 👍  :2nd_place_medal: 👱


Create template partial for Event creation form

Related to https://github.com/myfossil/myfossil-theme/issues/29

Closing in light of using the admin panel to create events...


OneNote section groups not importing properly

Rather than organizing my notes by [notebook] --> [sections], I have most sections organized under section groups, such that my OneNote is organized as [notebook] --> [section group] --> [sections]. Sections are nested in section groups which are nested within notebooks.
In the Importer, the sections at the top level of my notebook import correctly, but the section groups simply don't appear on the list. Any plans to change this? Section groups exported for me without issue when I used the tool at https://github.com/theohbrothers/ConvertOneNote2MarkDown
Looking forward to getting many of my notes into Obsidian! Thanks for all the great work.

I just realized this when trying to use the importer as well. I don't see my section groups and anything nested within it at all.
Hope this is something we can accomplish at some point, this way I can finally divorce from OneNote (mostly used for work).

Should be fixed in the next release of the Importer! It didn't work because of a little typo in an URL :p

Should be fixed in the next release of the Importer! It didn't work because of a little typo in an URL :p

Thank you so much for the quick-fix! Looking forward to it; Appreciate your hard work.


Remove more JCenter references

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test RFR

I've triggered the following builds for you. Click here to see all build failures.

ReadyForRelease build

@bot-gradle test RFR without PTS

I've triggered the following builds with parameters: -DenablePredictiveTestSelection=false for you. Click here to see all build failures.

ReadyForRelease build

I've triggered the following builds for you. Click here to see all build failures.

Quick Feedback (Trigger) (Check)

I've triggered the following builds for you. Click here to see all build failures.

Quick Feedback (Trigger) (Check)

@bot-gradle test qf

I've triggered the following builds for you. Click here to see all build failures.

Quick Feedback (Trigger) (Check)

The merge queue build has failed. Click here to see all failures.

The merge queue build has failed. Click here to see all failures.


Move timer objects to the end of member list

In high CPU load it can happen, that Timer thread wakes up,
is swapped out, and when application resumes it does not resume with timer
thread, but transport thread, that decides to do failover, destroys
InactivityMonitor object. When its members are getting destroyed,
they arrive at Timer object that joins, timer thread resumes in
writeCheck or readCheck method, only to find out asyncTasks is already
destroyed because it comes later in member declaration list so it was
destroyed first. Moving Timer object to the end of the list, guarantees
that they will be destroyed first, so their threads will get joined and
allowed to finish, before the rest of the object is destroyed.
Closes AMQCPP-626

Guys. Is there anything that needs to happen, so this PR gets some (any) attention?

Just wait and keep patient, or maybe you would like to send an email to the master.

Needing to wait almost three weeks for a root-caused patch to receive any attention, doesn't exactly build trust in a library. I have sent 2 emails to dev list, as well as logged JIRA. Not sure what (who?) the "master" is, but I feel like I've done enough tho. Thank you for the tip. I'll just wait and keep being patient.

@tabish121

@Pingmin thank you for trying, but after I month with no reaction whatsoever, I should probably come to a conclusion that this project is effectively abandoned.

Many years later. Any news?

Good luck @unjello ! I was about to do a PR to update zlib and get rid of a CVE alert we have. I don't think I'll waste time with that.

Hi @unjello @sandym
I'm an ActiveMQ committer and would be able to help modernize. My C++ is a bit rusty, so I'd need an assist. I think first step would be to modernize the tool chain (add git action and jenkins file to get some automated build testing going.
Would either of you be able to assist in PRs for that?


Doesn't work when configured on a fork (1.7.0)

Some teams use hierarchical projects, where there is a company project and repo and a team fork of that repo. If the team repo (which is a fork, but can have forks of its own) has the plugin configured directly on it, no notifications are set. It doesn't matter if the company projects enables notifications for forks (not what we want) or if the fork itself does, or both.
All parent project settings are overridden and everything is enabled. Looking at the latest source, it doesn't appear that the behavior is any different than our current version.

How about ignoring whether the repo is a fork if the settings override is on?

Did you try checking this box on your repo:
"Enable slack notifications for personal"
"If enabled, users will receive slack notifications for personal repos (forks) for both push and pullreqs"
It should enable notifications even for forks.


bertieb: Watch love-and-lottery-spells-expert.com

bertieb requests the watch of the watch_keyword love-and-lottery-spells-expert\.com. See the MS search here and the Stack Exchange search here.

love-and-lottery-spells-expert\.com has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by CalvT in Charcoal HQ


Wrong highlighting of days out of the month

versions:
"@material-ui/pickers": "^4.0.0-alpha.6",
"@material-ui/core": "^4.9.11",
expected: June 31 is out of the month and 1,2,3,4,5,6 is current month
actual:

Provide a way to reproduce the issue. This code sandbox template could helpt

done https://codesandbox.io/s/nice-brattain-0g5lt

reproduced here https://codesandbox.io/s/nice-brattain-0g5lt. If we move to June, 1-6 days, marked as disabled, but we can set reduceAnimations={true} and everything ok

oh thanks 👍

Hmm


npm run error

npm install osmojs
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! A complete log of this run can be found in:
what should i do

Are you using a npm registry of sorts?
https://www.npmjs.com/package/@cosmjs/stream

I would look at your network connection, ensure you're using the proper npm registry. Everything works, I also tested yarn add osmojs again and everything installs correctly.

I also tested npm install which also works.


fix: omit data-race panic on GC()

What type of PR is this?

fix
Check the PR title.

[ ] This PR title match the format: <type>(optional scope): <description>
[ ] The description of this PR title is user-oriented and clear enough for others to understand.
[ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
GC() will change the underlying map pointer with holding read lock, which Load() may be read this map also with read lock. In our design, this is allowed since GC only replace this map with the same content (only shrink its capacity). But go runtime can not correctly recognize this case. Therefore, we use atomic operations to omit -race panic.

It seems there is no affection on performance:

name                                   old time/op    new time/op    delta
SessionManager_CurSession/sync-16        23.8ns ± 0%    23.5ns ± 0%   ~     (p=1.000 n=1+1)
SessionManager_CurSession/parallel-16    13.7ns ± 0%    12.9ns ± 0%   ~     (p=1.000 n=1+1)
GLS_Get/sync-16                          62.9ns ± 0%    51.2ns ± 0%   ~     (p=1.000 n=1+1)
GLS_Get/parallel-16                      21.6ns ± 0%    19.8ns ± 0%   ~     (p=1.000 n=1+1)

zh(optional):
(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

fix #5 #4

fix #5
fix #4


Add presto DATE function

Addresses issue https://github.com/facebookincubator/velox/issues/4429.
Output of function test for initial commit
velox/_build/debug/velox/functions/prestosql/tests$ ./velox_functions_test --gtest_filter=DateTimeFunctionsTest.dateFunction
Running main() from /home/czentgr/gitspace/velox/_build/debug/_deps/gtest-src/googletest/src/gtest_main.cc
Note: Google Test filter = DateTimeFunctionsTest.dateFunction
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from DateTimeFunctionsTest
[ RUN      ] DateTimeFunctionsTest.dateFunction
WARNING: Logging before InitGoogleLogging() is written to STDERR
E0406 16:58:18.660641 48890 Exceptions.h:68] Line: /home/czentgr/gitspace/velox/velox/type/TimestampConversion.cpp:502, Function:fromDateString, Expression:  Unable to parse date value: "2012-08-09 06:00:00.000", expected format is (YYYY-MM-DD), Source: USER, ErrorCode: INVALID_ARGUMENT
E0406 16:58:18.662225 48890 Exceptions.h:68] Line: /home/czentgr/gitspace/velox/velox/type/TimestampConversion.cpp:502, Function:fromDateString, Expression:  Unable to parse date value: "foobar", expected format is (YYYY-MM-DD), Source: USER, ErrorCode: INVALID_ARGUMENT
E0406 16:58:18.663712 48890 Exceptions.h:68] Line: /home/czentgr/gitspace/velox/velox/parse/TypeResolver.cpp:111, Function:resolveScalarFunctionType, Expression:  Scalar function signature is not supported: date(BIGINT). Supported signatures: (varchar) -> date, (timestamp with time zone) -> date, (timestamp) -> date., Source: USER, ErrorCode: INVALID_ARGUMENT
[       OK ] DateTimeFunctionsTest.dateFunction (39 ms)
[----------] 1 test from DateTimeFunctionsTest (40 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (73 ms total)
[  PASSED  ] 1 test.

Output of fuzzer
velox/_build/debug/velox/expression/tests$ ./velox_expression_fuzzer_test --seed 123456 --duration_sec 60 --logtostderr=1 --minloglevel=0  --only date --v=1 2>&1 | tee fuzzertest.out
...
I0406 17:08:10.718812 49751 ExpressionFuzzer.cpp:1172] ==============================> Done with iteration 10477
I0406 17:08:10.718884 49751 ExpressionFuzzer.cpp:972] ==============================> Top 1 by number of rows processed
I0406 17:08:10.718889 49751 ExpressionFuzzer.cpp:974] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I0406 17:08:10.718892 49751 ExpressionFuzzer.cpp:978] date 10478 100.00% 960982
I0406 17:08:10.718919 49751 ExpressionFuzzer.cpp:984] ==============================> Bottom 1 by number of rows processed
I0406 17:08:10.718922 49751 ExpressionFuzzer.cpp:986] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I0406 17:08:10.718925 49751 ExpressionFuzzer.cpp:991] date 10478 100.00% 960982
I0406 17:08:10.718931 49751 ExpressionFuzzer.cpp:1004] ==============================> All stats sorted by number of times the function was chosen
I0406 17:08:10.718935 49751 ExpressionFuzzer.cpp:1006] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I0406 17:08:10.718938 49751 ExpressionFuzzer.cpp:1010] date 10478 100.00% 960982
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

Test fails likely unrelated to my changes. I've noticed this one failing locally before velox_exec_test when working on another PR.
185: [ RUN      ] NthValueTest/MultiNthValueTest.tinyintValues/2
186: [       OK ] AggregatesTestInstantiation/SimpleAggregatesTest.multiInput/63 (148 ms)
186: [ RUN      ] AggregatesTestInstantiation/SimpleAggregatesTest.multiInput/64
199: *** Aborted at<PHONE_NUMBER> (Unix time, try 'date -d @1680877199') ***
199: *** Signal 11 (SIGSEGV) (0x10) received by PID 42234 (pthread TID 0x7f8790c51700) (linux TID 150976) (code: address not mapped to object), stack trace: ***
199: (error retrieving stack trace)
185: [       OK ] NthValueTest/MultiNthValueTest.tinyintValues/2 (175 ms)
185: [ RUN      ] NthValueTest/MultiNthValueTest.tinyintValues/3

Closing as better/duplicate of https://github.com/facebookincubator/velox/pull/4604.
This PR also ha a fix for negative timestamps.


⚠ Bofrost.at has degraded performance

In 2724a9b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1081 ms

Resolved: Bofrost.at performance has improved in 3ed568c after 20 minutes.


Add hex quiz component

Zero To Mastery - Webblocks 2022 📦📦
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:
I've added a hex color code quiz. The user has to guess the hex code of the color displayed - they have three randomly generated choices, only one of which is correct.
Screensho

ts

@sirnotes @beneyal @wmporter @danicc


FAQ

Adding frequently asked questions section, moving IERS tutorial into it, adding tutorial on precision to explain #66 and close #89.

Looks generally good to me - the comments above are mostly wordsmithing/being pedantic.

@eteq : I addressed each of those comments int he latest commit. Pull the trigger when you like?


pr

i was just trying you please dont ignore i took too much time to do so please

Mention issue first..!


Changed RUST_LOG usage to CARGO_LOG to avoid confusion.

Fixes #6189.
Changes Cargo to to initialize env_logger with the CARGO_LOG variable instead of RUST_LOG. Also updated documentation, tests, etc. to match the change.

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks for the PR! In light of https://internals.rust-lang.org/t/cargo-and-rustup-development/8615/1 I don't think we're willing to merge this at this time. This is changing a very longstanding interface in Cargo which I unfortunately think we don't have ti,e to prioritize and review until after the edition and planning.

Yeah, there's still the issue to track the request so no reason this has to sit around taking up space.

@alexcrichton I see why this should not be merged during the features-freeze, but I am strongly in favor of this change in general.

Can this be revisited now?
This makes env_logger difficult to use with Cargo.
I'm assuming that --verbose is used by most casual Cargo users, so this won't have big impact. It's probably less painful to change Cargo than to change 1000 other projects.


chore: fix unknown in ghcr registry

Overview
Closes #2412

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2693 (82e2ddf) into main (c650453) will increase coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
+ Coverage   51.35%   51.45%   +0.10%
==========================================
  Files         159      159
  Lines       10698    10698
==========================================
+ Hits         5494     5505      +11
+ Misses       4725     4719       -6
+ Partials      479      474       -5

see 6 files with indirect coverage changes


Fixed note

There was a space missing and it showed as a single note with the [AZURE.NOTE] text inside.

Hi @gbellmann, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Make sure FormType::getName is SF3.0 compatible

I'm confused now I found out framework-bundle does not include the form component. See https://github.com/symfony/framework-bundle/blob/master/composer.json
So, apparently we do need to include the other components that were defined before: https://github.com/dmishh/SettingsBundle/blob/1.x/composer.json
The required components are defined via require-dev though, that's why tests pass: https://github.com/symfony/framework-bundle/blob/master/composer.json#L39

Oh, thats right.
I do not think we need to add the components that is added by framework bundle.
So :+1: to adding the form component to our composer.json

What about the others?:
    "symfony/security": "~2.1,!=2.5.0",
    "symfony/validator": "~2.1,!=2.5.0",
    "symfony/translation": "~2.1,!=2.5.0",

We need to add
"symfony/form": "^2.7,^3.0",
"symfony/validator":  "^2.7,^3.0",
"symfony/translation":  "^2.7,^3.0",

Security is part of the framework bundle, right?

Next to that, they should be "required" in Travis too.

Yes

translation also is required via the framework.

Sorry, correct.

form requires validator, see:  https://github.com/symfony/form/blob/master/composer.json#L28
See PR #74


Duplicate properties information

The details property of map.message.complete is given by the child nodes of ToC "Channels & Payloads => map.message => map.message.complete.  In almost all cases it appears that the details object is identical to the channel message that the map.message.complete is responding to.  So why repeat it here?  That just creates the possibility that they accidentally get out of synch.  And that appears to have happened in at least one place.  Compare the two entries for map.overlay.create.  Under the message complete subtree the map.overlay.create includes a menuId while in the original channel message description for that message there is no menuId.

From message https://groups.google.com/forum/?hl=en#!topic/common-map-widget-api/rvq5Wyny9I4

Addressed in RC12 of CMAPI 1.3.0 now online for comment review period of 30 days


Minor wording change

Things added/changed:

Minor wording change.

LGTM. Thanks for your contribution.


Code example for dotnet core library is wrong

Is your feature request related to a problem? Please describe.
Where :
https://docs.microsoft.com/en-us/dotnet/core/tutorials/library-with-visual-studio-code#add-a-console-app-to-the-solution
In pp.3 'Open ShowCase/Program.cs and replace all of the code with the following code.'
What :
Presented code example doesn't compile.
Why :
This method "void ResetConsole()" doesn't contain declaration or input parameter of "row".
Describe the solution you'd like
add input parameter in "void ResetConsole()" -> "void ResetConsole(int row)"
update call this method "ResetConsole();" -> "ResetConsole(row)"

This issue was moved to dotnet/docs#21597


Documentation:  Update tests on using library(pkg_name) versus pkg_name::function

Please select a category the issue is focused on?
Function Documentation
Let us know where something needs a refresh or put your idea here!
See #1235 for additional discussion and guidance.

@esimms999-gsk Please go ahead and take this on.

I spoke with Ellis Hughes at GSK about this. His take on it:
In your package code, you should be using the importFrom tags for your functions to identify
which functions from your various libraries to make available internally. However, the functions
needed for testing may not be the same as you need for making your package work, which is why you
put them in the “suggests” of your DESCRIPTION file. You should never use a library call in your tests
because that changes the environment from then on and your tests need to be run in a specific order
to work. Using package::function will give you access to the function without changing your environment.
You should not be using library anywhere in your package except maybe your vignettes.
See hadleys writing on testing: https://r-pkgs.org/testing-design.html
So, maybe this Issue should be turned around to update all the tests to replace any library calls with packagename::function()?
I have not yet read the link provided by Ellis, but hope to get to it one of these days. :)  Until then, I hope to hear other opinions on this from @bms63 and  @thomas-neitmann .

Many thanks Eric for chasing this.
Tests
Welll...it is pretty explicit on not using library calls in tests!  Good to know

So if we have the packages in depends/suggest (i.e. tibble and admiral.test) then our tests should just run with no issues?  I just tried this out and it works for the tribble function when I add tibble to @importFrom in admiral-package.R file, but it does not work for admiral.test.  It looks like we need to @export the datasets in admiral.test to have them be available within the namespace for the tests.
Possible ways forward:
The first way:  Add @export to admiral.test datasets and then load them into admiral, but this would make the package larger I think.  However, this means all the testing data is easily accessible and we no longer have to add library(admiral.test) or pkg_name::dataset to any of the test code
The 2nd way:  Remove library calls and add tibble::tribble and admiral.test::dataset where needed and not do anything with @importFrom for tibble or admiral.test.
I'm leaning more to 2nd way as it doesn't increase the size of the package.  We can add to the agenda for Wednesday's meeting to see how we want to proceed for the tests.
Examples
I think we are okay to have library call in the examples.   I think this is confusing for new users to see pkg_name::function in the examples rather than library(pkg_name), but this is just my personal preference.  I'm happy to change it all up.

Any thoughts @pharmaverse/admiral on testing design?

@bms63 Thanks for digging up the documentation.
A nice explanation, with an example, from Christina Fillmore at GSK:
You don’t want to make library calls in your tests cause it will change the environment the tests are run in. So lets say you just used dplyr::mutate() in the package and you never put in an import statement. Then in your tests you called library(dplyr). There wouldn’t be any issues cause all of dplyr would be imported into your environment. But if a user tried to use your package without library(dplyr) it would fail and say function not found.
You can read more about this here.

Modified ~12 files to replace library(packagename) with packagename::function(). These are in PR.
Two left to do, both with library(admiral.test):
test-call_derivation.R
test-deprecation.R (also has library(rlang) and library(tribble). Note that tests are currently failing.


Add 2 new run-time diagnostics: PDF and conditional stats

@marchdf I'm thinking of moving this to PP and plugging this into PeleC at one point, so I'm interested in your feedback on the interface, maybe too convoluted ?
@baperry2 compared to what you're currently using, you'll need to manually specify a list of variables to output on the 2D plane instead of getting the entire state. There might be a way to add macro name that assemble set of variables of interest to make that easier.

Oh this is an excellent idea! Let me look at the code.

Lucas, this is fantastic! It's great to be able to dump derived variables using the diagnostics and its better to be able to specify what you need rather than just getting everything. The conditional statistics and PDF capability will also be quite useful.
One thing that would be very helpful is to add column headers to the output files and maybe use fixed width formatting to make them more easily human readable (not as important).
Additionally, while looking over this I've thought of small wish list of ways to extend/further improve this capability. All these are low priority, but are things I'd add as the use case comes up and I'm recording here so I remember:

add option for fixed bounds for the conditioning variable similar to what there is for the PDF variable (to enable postprocessing combination of multiple time instances where the extrema are different)
add condSq variable when computing integral conditional statistics (to allow computation of the standard deviation when combining data from multiple time instances during postprocessing)
add option to internally accumulate conditional statistics/PDFs over time
add problem-specific derived variables like in PeleC (https://github.com/AMReX-Combustion/PeleC/blob/d044eec3a6ad65b31b9088673701f37ff0e06a2c/Exec/RegTests/TGReact/prob.H#L151) to allow for custom use of these functions (the use case I have in mind is collecting statistics conditioned on radius for a turbulent jet.)

[ ] header in the ASCII files for PDF/Conditioned stats
[ ] fixed formatting of ASCII files
[ ] bounds on conditional variable
[ ] accumulate stats over time
[ ] add user-defined derived


Support tooltips on suggestions

Support for

This pr adds support for description to suggestions, while fully maintaining old string suggestions
TODO:

[x] add support for platforms
[x] decide how we should transform suggestions to components for minecraft (minimessage, json, legacy, plain text?)
[x] Review javadocs
[x] Fix totally wrong API annotations to new methods
[x] maybe some name changing

Added examples on velocity and paper in how to use this new feature
Here are the screenshots of the result
Velocity:

Paper:

Also deprecated methods that may result in losing the tooltip because of completion -> string -> completion transformation due to lack of support
All internal parsers now won't lose the tooltip
Soon will rebase

idk, maybe I shouldn't provide explicit support for components here, but expose an api to registers a custom suggestion that supports that?
the code becomes a mess and a spaghetti code when i try to add support for adventure when it seems like adventure shouldn't even be mentioned there
i can easily provide support for plain text as tooltips, but that's the maximum without making a mess

i think for most of cases plain text will be enough to make cool tooltips, so don't think that many projects would care about component tooltips

Is it good now or should I change something?

if you want to use this support as much as me, I posted it on https://repo.masmc05.dev/repository/maven-snapshots/, the version is 1.9.0-SNAPSHOT, after this will be merged I'll delete it from there

I've tested this feature on Paper 1.20.1 (build 156) and it seems to not working correctly:

But it works perfectly fine on Paper 1.16.5 (build 794):

Argument code:
.argument(StringArgument.builder<ISender?>("mail")
    .withCompletionsProvider { context, _ ->
        val player = context.sender.player() ?: return@withCompletionsProvider emptyList()
        Database.getReceivedMails(player).filter { it.sender != null }.map { DescriptiveCompletion.of(it.id.toString(), "Example description") }
    }
)

I've tested this feature on Paper 1.20.1 (build 156) and it seems to not working correctly:
But it works perfectly fine on Paper 1.16.5 (build 794):
Argument code:
.argument(StringArgument.builder<ISender?>("mail")
    .withCompletionsProvider { context, _ ->
        val player = context.sender.player() ?: return@withCompletionsProvider emptyList()
        Database.getReceivedMails(player).filter { it.sender != null }.map { DescriptiveCompletion.of(it.id.toString(), "Example description") }
    }
)

Could not replicate this
Is the code 100% the same on both versions? Could you try forcing the registering of async command competition? If yes, did it change anything?

I've tested this feature on Paper 1.20.1 (build 156) and it seems to not working correctly:
But it works perfectly fine on Paper 1.16.5 (build 794):
Argument code:
.argument(StringArgument.builder<ISender?>("mail")
    .withCompletionsProvider { context, _ ->
        val player = context.sender.player() ?: return@withCompletionsProvider emptyList()
        Database.getReceivedMails(player).filter { it.sender != null }.map { DescriptiveCompletion.of(it.id.toString(), "Example description") }
    }
)

Could not replicate this
Is the code 100% the same on both versions? Could you try forcing the registering of async command competition? If yes, did it change anything?

Using PaperCommandManager#registerAsynchronousCompletions solved the problem

closing in favor of https://github.com/Incendo/cloud/pull/495


[feat] - new resource - schedule

Hi All,
CircleCI will deprecate scheduled workflows and scheduled pipelines will take over its place. [source]
To setup scheduled pipelines is only possible through API or UI. It would be great if this terraform provider would add support for schedule as well.
API documentation - https://circleci.com/docs/api/v2/#tag/Schedule
Thanks for the consideration,
Andor

Discovered this provider looking for exactly this feature :)

hello folks,
I have added support for scheduled pipelines, amongst other resources, in my (unofficial) Terraform provider for CircleCI.
I hope this may be useful for you.


github description bug, feature question, and request

It says on the main github page that the java7 branch compiles in Java 7 and also java 5-6. This is in fact not the case, as the Long.compare() method used by the LongFraction class does not exist before java 7. I often use the BigFraction class in Java 6, so it would be nice if it worked in that version.
I also noticed a lot of new features added. I noticed the roundToDenominator() method, however you can extend this to any value using round(x,m)=round(x/m)*m. m here is the increment to which you are rounding, and the single argument round() function rounds to integral value.
Another question I have is regarding the () syntax for repeating digits. Even though the parsers never handle it this way, I think a syntax like 0.1(6) is confusing, as it could be interpreted as 0.16... or 0.6. Is there a better syntax? Or do you think () is the best option?

I'm not sure how 0.1(6) could be interpreted as 0.6. When I researched ways of representing repeating decimals, all the other methods involved typographic marks that you wouldn't be able to represent in unformatted text (or maybe you could represent it somehow with unicode characters, but it would be inconvenient). The parenthetical notation is easy to represent in plain ascii characters, so I went with that and documented it as best I could in the javadoc.
I'm not sure if I need yet more rounding functions, but I'll keep it in mind.
I'll try to look into Java 6 sometime this week. I have never actually tried it with Java 6 JDK.

I'm not sure how 0.1(6) could be interpreted as 0.6.

Like this. In the case where () is not explicitly meaning repeating decimal, it can be interpreted as multiplication. This is not a problem for your parser, however if I were to pass 0.1(6) to an algebraic expression class it would do the multiplication instead of throw an exception
import net.objecthunter.exp4j.*;
public class Test {
  public static void main(String[] args){
    Expression e = new ExpressionBuilder("0.1(6)").build();
    System.out.println(e.evaluate());//returns 0.6
    Expression f = new ExpressionBuilder("0.16\u0307").build();//throws an error
    System.out.println(f.evaluate());
  }
}

Using \u0307 for combining dot and \u0305 for combining bar work perfectly fine. I understand that it's not easy for everyone, and since () works unambiguously for the BigFraction parser you shouldn't change it. However support for forms like 0.13̅0̅5̅ or 0.13̇05̇ would be nice.
For rounding functions, given that your roundToDenominator function essentially performs the roundToValue function, I imagine these would not be too hard to implement.
//static versions of round to value
  public static BigFraction roundToValue(BigFraction toRound,BigFraction val){
    return roundToValue(toRound,val,RoundingMode.HALF_UP);
  }
  public static BigFraction roundToValue(BigFraction toRound,BigFraction val,RoundingMode roundingMode){
    return BigFraction.valueOf((toRound.divide(val)).round(roundingMode)).multiply(val);
  }

Speaking of roundToDenominator, why does it round to integer? I expected it to round to fraction...

I've added a java6 branch that will compile in Java6. I see what you mean about 0.1(6), but I don't think I want to implement unicode support. You only get the repeating decimal syntax if you ask for it, at which point you could write logic to change it as needed. If you're taking user input and passing it into the string constructor, you can also run a check to make sure it doesn't use repeating decimal syntax if you don't want to allow it.
For roundToDenominator, I think I was trying to solve a problem like- if every pizza has 8 slices, and we purchased 6 pizzas for 20 people, what's the minimum number of slices should each person get? Answer is 6/20, floor-rounded to nearest eighth (2/8) and taking the numerator- 2 slices. If I returned the fraction it would be reduced as 1/4, and you'd have to do additional math to get the 2 that you really wanted. In retrospect, roundToDenominator is solving a pretty specific problem that the user could solve on their own without the function pretty easily. But I don't want to deprecate or change what the function does either, so that I don't break anything. I'll probably eventually add something like roundToValue function that you propose.

FYI- Just added a roundToNumber(), which rounds to the nearest multiple of a given number. No plans to add unicode for repeating fractions or to change roundToDenominator().