DRAFT workers labels

Initial implementation for workers labels
DONE

[x] Added a new worker_label text field to models.Project
[x] Added a new settings that makes the match between labels and docker images
[x] Added a second worker in the docker-compose using QGIS 3.18 (based on the same dockerfile but different base image - made the dockerfile configurable by the way) (not yet tested, just so that we have two different workers to test)
[x] Added image property to the workers definitions in the docker-compose, so the images get tagged

TODO

[ ] Probably worth thinking how we want to deal with docker image builders (build in the same repo ? how do we version ? etc.)
[ ] Test a little bit (did not really test if it works yet)
[ ] Tests (automated)

Thoughts/remarks :

This will still require many changes the day we want to support external workers, but we should be able to keep the worker_image field (hence will be backwards compatible for users)

Not sure at all how this would work in a kubernetes setup. I guess in such a case, we'd need to host the images to a docker repo ?

Initially I started with a more flexible approach where each project would just specify the docker image name instead of some hard-coded label, but I don't think it's going to be maintainable and poses more security issues. This means that now you need a migration if you are to add new workers, so not sure how it would work with external workers too... I'm not too sure how well this will all work in the end, maybe we need to discuss usage scenarios more in detail.

Adding the worker definitions in docker-compose is quite convenient, but a bit messy (we for instance don't really want to start it on docker-compose up). We could keep them in a separate docker-compose, but these docker-compose files are really starting to proliferate too much :-)

Task linked: DEV-2872 Support multiple labeled qgis workers

Closing for now, as it is not expected to be merged soon and there are already a bunch of conflicts. Keeping the branch though!


Remove workaround to pull container image from registry.k8s.io

Configure the registry.k8s.io manually is no longer required. The upstream patch has been accepted and released in the helm chart version 4.0.18.
Reference:

https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/252

Checklist

[x] The PR has a meaningful title. It will be used to auto generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
[x] PR contains a single logical change (to build a better changelog).
[x] Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[x] Link this PR to related issues or PRs.

Remove the workaround added in #32.


chore(pull_request_template): Update PR template

What this PR does / why we need it
This PR slightly improves the PR template readability and comments out the CONTRIBUTING.md reference.
PR Checklist

[x] This PR adds docs

Github Issue
[XX-XX]

Notes for your reviewers

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.84%. Comparing base (710239d) to head (c4a75de).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   40.84%   40.84%
=======================================
  Files          58       58
  Lines        2904     2904
=======================================
  Hits         1186     1186
  Misses       1530     1530
  Partials      188      188

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Correct perms for dist folder, explicit copy & remove old .dockerignore

quay.io/kuadrant/console-plugin:v0.0.14
sh-5.1$
sh-5.1$ cd /usr/share/nginx/html
sh-5.1$ ls
1040-chunk-d134c6b1ec0f400587f0.min.js		    3992-chunk-d536915a08a22b8fb859.min.js		6202-chunk-9961a854c01c5d1b068b.min.js.LICENSE.txt  8906-chunk-3f1147347760b551b057.min.js
1240-chunk-4ffca4814c3aa6892308.min.js		    404.html						6279-chunk-38c0b4d4acbae5f464f4.min.js		    8906-chunk-3f1147347760b551b057.min.js.LICENSE.txt
1281-chunk-0344c707cb195d3e6069.min.js		    416-chunk-364e702457e1ff8b2b14.min.js		6291-chunk-4ddd722ea715b0f18cdf.min.js		    8994-chunk-4cdc36ef2b3b333dbcd8.min.js
1283-chunk-b8c04937acc7e321c59b.min.js		    4194-chunk-7630c4e6aa9458971c6b.min.js		6291-chunk-4ddd722ea715b0f18cdf.min.js.LICENSE.txt  8994-chunk-4cdc36ef2b3b333dbcd8.min.js.LICENSE.txt

Status: Downloaded newer image for quay.io/kuadrant/console-plugin:v0.0.15
sh-5.1$ cd /usr/share/nginx/html
sh-5.1$ ls
404.html  50x.html  dist  entrypoint.sh  icons	index.html  nginx-logo.png  poweredby.png  system_noindex_logo.png

Since around 0.0.15 or so, our builds have been missing a bunch of files that should have been copied to dist. Since the base image change, didn't spot a silently failing copy because of perms. Have addressed the perms issue, and fixed the build. Testing locally, the yarn dist / webpack steps now work correctly.
We'll release this as v0.0.17 (and likely nuke the two previous "releases").
After this change:
sh-5.1$ ls /usr/share/nginx/html
1040-chunk-d134c6b1ec0f400587f0.min.js
1240-chunk-4ffca4814c3aa6892308.min.js
1281-chunk-0344c707cb195d3e6069.min.js
1283-chunk-b8c04937acc7e321c59b.min.js

verified on cluster
@R-Lawton

/lgtm
verified all works in cluster


Fixed few pixels deviation problem

Fixed Columns and gutter width not adding up to the element width problem.

Fixed:
Pixel deviation problem.


Added lint config

LGTM. But there are issues when merging into master, because feature/lint is not up-to-date.
Let's first merge master into feature/lint and resolve the issues + maybe already make the lint fixes.

@calvintam236 Fixed all lint warnings. If you don't understand why I did something at some points, simply checkout commit 853df50 and run lint yourself, so you can see why I had to change something ;)
If you want, we can merge this first and then release v 2.0.0!?


[Request for External] report 8 Budget

Dear ALAppExtensions team,
On behalf of 4PS I would like to request to make variable 'GLFilter' protected on 'report 8 Budget'.
protected var
    GLFilter: Text;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Merge common code in AuRa and BABE

AuRa and BABE have a massive amount of code that is duplicated between them.  Most of the changes I have made to one have also had to be made to the other.  As such, it is prime time to merge the common code.
The merged code should go in core/consensus/slots, as much of it is tightly coupled to slot-based algorithms.
I plan on doing this fairly soon, once I have implemented network peer session key verification.  If anyone wants to implement this in the meantime, I will gladly mentor them.

Was this closed by #3377 or is there more to it? I'm looking around something to work on as my first issue 🚀


Overall schema for multi-fluorophore integration.

I've tried to sketch an overall roadmap of how this can be achieved by following ways

I've added multiple TODO statements in the existing code where I beleive that things needs to change.
I've created few relatively empty classes which can be subsequently filled.

Please let me know what you think of this. I'll be happy to improve based on your opinions on what changes should be made in this plan and also what changes I should do in my style of coding (variable/class/file names, formatter/linter, commit messages) or anything else.
Below is a brief summary:

Support for get_spectrum() for all filter types in filter.py. This will ensure a unified way of creating wavelength intervals.
interval_creation.py implements one way of creating the intervals.
creating base_modality.py which can support multiple psfs. Individual modalities just need to implement generate_psf().
excitation_emission_model.py which will stochastically simulate the fluorophore excitation and emission process.

I'll close this PR and will open another one with a different branch after incorporating the changes. Just want to say that this is very informative !


Show validation/network errors in Create Item form

Eg; a Password field with a min length of 8 characters, but only enter a password of length 3, it show an error in the admin UI.
This appears to be a regression - errors used to be surfaced as a toast notification.

Another example is when creating an item without filling out required fields.


Catch-22 with optional reducers and onDisappear

I have a view with a subview which uses a IfLetStore, so if some substate is not nil the view is presented. That subview sends an action in the "onDisappear". The issue is that if I set the substate to nil to make the subview disappear, the subview sends that action after the substate is nil, so the optional reducer crashes.

Why the assertion in the optional function?
How do I break this cycle? I guess I can just have a boolean to say if the view should be shown, but it feels weird having to do that.

Personally I use the solution described at https://forums.swift.org/t/ifletstore-and-effect-cancellation-on-view-disappear/38272/23. Check out the whole thread it's quite comprehensive.

Hi @buscarini, I'm going to close this issue out since it's more of a question of how to model optional features, and there are workarounds these days, such as setting breakpointOnNil: false on the optional reducer. We have a lot we've been exploring when it comes to navigation that will hopefully shed some light on more best practices soon.
If you'd like to discuss other workarounds, please feel free to reopen this as a GitHub discussion 😄


Ability to enhance SSR ?

Hi was just wondering if we could use this to improve the engine's implementation of SSR? It's pretty low res and generally bad haloing for any RE title.
Thanks!

Yes. I have played around with the resolution of SSR before, but I don't recall exactly in which class it's located in.

via.render.SSRControl
via.render.SSRControl.SSRControlType
via.render.SSRControl.SSRResolvePointNum
I'm guessing one of these? Will have a mess around but I'm at a night time part of the game atm so hard to see reflections. Will play more til I get another good example of water.

via.render.SSRControl via.render.SSRControl.SSRControlType via.render.SSRControl.SSRResolvePointNum
I'm guessing one of these? Will have a mess around but I'm at a night time part of the game atm so hard to see reflections. Will play more til I get another good example of water.

Let us know how it goes.

Seems like they're using some form of FidelityFX based SSR as all of the get calls in SSRControl return nil and I can see types for FidelityFXSSR. Just makes it a bit more complicated.

Seems like they're using some form of FidelityFX based SSR as all of the get calls in SSRControl return nil and I can see types for FidelityFXSSR. Just makes it a bit more complicated.

Dang, that's disappointing.


feat: tool use

#760

Just wanted to drop in and give a few words of encouragement here: this feature will be unbelievably cool and useful once implemented -- fantastic initiative :partying_face:


merge DR16 to main

yay

Changes fixed above comments, looks good!

Need to add timeout for invalid data to write 0s.

Ready to merge, but see issue #13 for future changes


ella: downloadFile method not working on safari ios

We are creating an anchor tag and setting its target to _blank and we are performing click action via javascript. Safari on ios is assuming it as a popup and is blocking it, it works when Block Popup is turned off.
.
Can we add check for Safari to avoid link.target='_blank, and then the file will open on same tab. One issue with this solution is that, on ios Safari and Chrome have same userAgents so it will be difficult to differentiate between them.

file check


Enable Travis' container-based infrastructure.

Should start and run a little faster.

Ref: http://docs.travis-ci.com/user/workers/container-based-infrastructure/


Git - large change improvements

[x] Add telemetry for when the git.statusLimit is reached
[ ] Improve experience when the git.statusLimit is reached (guide user to increase the limit)

Hey @lszomoru, reviving this based on our recent discussion and the extension hang data.
There are 3 major ways to hit this limit (maybe others? tell me):

Accidental .git: .git was initialized in some parent folder (like ~/ in https://github.com/microsoft/vscode/issues/151827) by accident.
Repos with huge build/dependency folders that should be ignored. VS Code helps with that by recommending to detect and ignore those folders.
Merges or initializing large repos. The users most affected by this warning and who need to change the limit.

Lower value: vscode.git already causes hangs for some users (https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Agit+label%3Aperf), so a lower value could help users with accidental git repos. Large repo users can still change the setting.
 Most that hit the limit seem to be just slightly over 10.000 – so even just using 11.000 would remove 99% of hangs.
Other ideas:

💡 Make the limit time-based. Compared to the number of files changed, the amount of time a status update takes is much closer to the impact on user experience. It also adapts to the environment, as we see issues from users with extremely slow git setups (firewall, antivirus, spinny disks, etc).
Prevent interruption by only warning users that actually ever opened SCM view during the session, otherwise silently disable file change updates and only show a warning in SCM.
Link to setting from the warning (right now just offers OK and Never show again).

cc @jrieken

@digitarald, thank you very much for the write-up.
I would personally prefer to increase the limit so that people with large repositories do not see the warning and they can use VS Code to interact with their large repository but also try to limit the number of repositories that are being opened "accidentally".

Accidental .git: .git was initialized in some parent folder (like ~/ in https://github.com/microsoft/vscode/issues/151827) by accident.

As far as my understanding goes, the standard behaviour of git.exe is to start walking up the directory tree in order to discover the first .git folder. One can control this behaviour by using the GIT_CEILING_DIRECTORIES  environment variable. The most common scenario here is when there is a .git folder in the $HOME directory and that is the one that gets opened. Couple of things we can consider:

Do not open the .git folder from $HOME unless $HOME is opened in VS Code.
Show a notification that the .git folder is in the $HOME folder and have the user agree to open it.


firebase_auth 0.16.1 mysterious crash happens when exit from the app and then get back to it.

This applies to version 0.16.1, the current version as of this writing.
1 - Mysterious crash happens when exit from the app and then get back to it.
2 - Happens also during calling FirebaseAuth.instance.signOut() and various other signIn methods.
3 - The problem disappears completely when downgrading to version firebase_auth: 0.15.5+3 and I dont knouw about other versions. so fix the 0.16.1 and later versions please.
@override
  void initState(){
    authService.onAuthStatusChanged().listen((event) {
      print('forex editor onAuthStatusChanged() with event =$event');
      if(event!=null && mounted) {
        setState(() {
          loggedIn = true;
        });
      } else if (event==null && mounted){
        setState(() {
          loggedIn = false;
        });
      }
    });
   super.initState();
  }

then simply a different widget appears based on logged in or not in the build method.
error crash text:
I/flutter (12650): forex editor onAuthStatusChanged() with event =FirebaseUser(Instance of 'PlatformUser')
D/FirebaseAuth(12650): Notifying id token listeners about user ( HgiJFxeeIyZRCHMV6dMsDjO5bf62 ).
I/PGA     (12650): PgaSocketInit: opened /dev/bstpgaipc: fd = 47
I/PGA     (12650): Attempting to create new SOCKET connection pid = 12650, tid = 13444
I/PGA     (12650): PgaSocketInitClientPgaIpc: data mapped to 0xaffaa000
I/PGA     (12650): New SOCKET connection: com.asoft.rayancontroller (pid 12650, tid 13444)
I/PGA     (12650): PgaSocketInit: opened /dev/bstpgaipc: fd = 59
I/PGA     (12650): Attempting to create new SOCKET connection pid = 12650, tid = 13443
I/PGA     (12650): PgaSocketInitClientPgaIpc: data mapped to 0xafec0000
I/PGA     (12650): New SOCKET connection: com.asoft.rayancontroller (pid 12650, tid 13443)
I/flutter (12650): build() MyHomePageState: loggedIn=false => LoginScreen
I/flutter (12650): MyHomePageState onAuthStatusChanged with event = FirebaseUser(Instance of 'PlatformUser')
I/flutter (12650): finished registering firestore listen callback in the ForexEditorState constructor
I/flutter (12650): document().snapshot().listen() callback in Constructor (document change detected)  ------------------------------------!
I/flutter (12650): setting state variables: ->>>>>>>>>>>>>>>>>>>>>>>>>>>>
I/flutter (12650): mounted = true >>>>> setting textEdit controllers
I/flutter (12650): forex editor onAuthStatusChanged() with event =FirebaseUser(Instance of 'PlatformUser')
D/AndroidRuntime(12650): Shutting down VM
D/AndroidRuntime(12650): procName from cmdline: com.asoft.rayancontroller
E/AndroidRuntime(12650): in writeCrashedAppName, pkgName :com.asoft.rayancontroller
D/AndroidRuntime(12650): file written successfully with content: com.asoft.rayancontroller StringBuffer : ;com.asoft.rayancontroller
E/AndroidRuntime(12650): FATAL EXCEPTION: main
E/AndroidRuntime(12650): Process: com.asoft.rayancontroller, PID: 12650
E/AndroidRuntime(12650): java.lang.NullPointerException: Attempt to invoke virtual method 'void io.flutter.plugin.common.MethodChannel.invokeMethod(java.lang.String, java.lang.Object)' on a null object reference
E/AndroidRuntime(12650): 	at io.flutter.plugins.firebase.cloudfirestore.CloudFirestorePlugin$DocumentObserver.onEvent(CloudFirestorePlugin.java:429)
E/AndroidRuntime(12650): 	at io.flutter.plugins.firebase.cloudfirestore.CloudFirestorePlugin$DocumentObserver.onEvent(CloudFirestorePlugin.java:402)
E/AndroidRuntime(12650): 	at com.google.firebase.firestore.DocumentReference.lambda$addSnapshotListenerInternal$2(com.google.firebase:firebase-firestore@@21.3.0:504)
E/AndroidRuntime(12650): 	at com.google.firebase.firestore.DocumentReference$$Lambda$3.onEvent(com.google.firebase:firebase-firestore@@21.3.0)
E/AndroidRuntime(12650): 	at com.google.firebase.firestore.core.AsyncEventListener.lambda$onEvent$0(com.google.firebase:firebase-firestore@@21.3.0:42)
E/AndroidRuntime(12650): 	at com.google.firebase.firestore.core.AsyncEventListener$$Lambda$1.run(com.google.firebase:firebase-firestore@@21.3.0)
E/AndroidRuntime(12650): 	at android.os.Handler.handleCallback(Handler.java:751)
E/AndroidRuntime(12650): 	at android.os.Handler.dispatchMessage(Handler.java:95)
E/AndroidRuntime(12650): 	at android.os.Looper.loop(Looper.java:154)
E/AndroidRuntime(12650): 	at android.app.ActivityThread.main(ActivityThread.java:6138)
E/AndroidRuntime(12650): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(12650): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:893)
E/AndroidRuntime(12650): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:783)
I/Process (12650): Sending signal. PID: 12650 SIG: 9
Lost connection to device.

Hi @asoftraiden
Using the package version on official example
i cannot reproduce any of the issues you mentioned

stable flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-2.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-2.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 15a28159bc (10 days ago), 2020-06-23 04:52:58 -0700
    • Engine revision 91a63d6a44
    • Dart version 2.9.0 (build 2.9.0-19.0.dev 7e72c9ae7e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS desktop • macos                     • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Please try official example
Thank you

Well it is very subtle error in the 0.16.1 version but I present in both the emulator and the real physical device. It appears that an event inside the auth library could not find the callback because it somehow became null internally only sometimes.

We are facing the same issue as well. The app mysteriously crashes when we try to do a log out.
Platform: Android 8.0
Version: 0.16.1
How to simulate

Login through OTP
Close the app (Use physical back button to close app, don't kill the app and launch app)
Open the app and do a log out
App immediately crashes

Side Note

We tried 0.15.5+3 and there is no issue. It seems the crash happens since the Android v2 embedding migration.
Logging out without closing the app will not crash the app, but will crash the app the next time a login is attempted after closing the app. (Login -> Logout -> Close App(Back until app is closed) -> Login -> Crash)
Killing the app then logout won't crash the app.

Conclusion
The only way to simulate it is

Login/Logout the app
Use physical Back Button until the app is closed (Not killing the app using Overview button)
Open the app up again, login/logout
Crash

D/FirebaseAuth( 3461): Notifying id token listeners about a sign-out event.
D/FirebaseAuth( 3461): Notifying auth state listeners about a sign-out event.
D/AndroidRuntime( 3461): Shutting down VM
E/AndroidRuntime( 3461): FATAL EXCEPTION: main
E/AndroidRuntime( 3461): Process: com.krave.kravemobileconsumer, PID: 3461
E/AndroidRuntime( 3461): java.lang.NullPointerException: Attempt to invoke virtual method 'void io.flutter.plugin.common.MethodChannel.invokeMethod(java.lang.String, java.lang.Object)' on a null object reference
E/AndroidRuntime( 3461):        at io.flutter.plugins.firebaseauth.FirebaseAuthPlugin$3.onAuthStateChanged(FirebaseAuthPlugin.java:710)
E/AndroidRuntime( 3461):        at com.google.firebase.auth.zzp.run(com.google.firebase:firebase-auth@@19.2.0:3)
E/AndroidRuntime( 3461):        at android.os.Handler.handleCallback(Handler.java:808)
E/AndroidRuntime( 3461):        at android.os.Handler.dispatchMessage(Handler.java:101)
E/AndroidRuntime( 3461):        at com.google.android.gms.internal.firebase_auth.zzj.dispatchMessage(com.google.firebase:firebase-auth@@19.2.0:6)
E/AndroidRuntime( 3461):        at android.os.Looper.loop(Looper.java:166)
E/AndroidRuntime( 3461):        at android.app.ActivityThread.main(ActivityThread.java:7529)
E/AndroidRuntime( 3461):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime( 3461):        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
E/AndroidRuntime( 3461):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:921)

same issue in latest firebase auth

same issue occured. (package : firebase_auth)
version 0.15.5+3 : normal
version 0.16.0 : app crash
version 0.16.1 : app crash

error log
D/AndroidRuntime(27359): Shutting down VM
E/AndroidRuntime(27359): FATAL EXCEPTION: main

reproduce

app log out --> app start --> app crash
app kill (force close) --> app start --> normal
app log out --> app kill (force close) --> app start --> normal

This error occurs when the app is restarted while the app is running in the background launcher of Android Device. This is a very important issue because it is the general way users use the app.

@asoftraiden
I've tested this and I am unable to replicate on the rework that is currently being worked on.
The roadmap can be found here.  Please keep an eye on the roadmap for the next release, and let us know if you are still able to replicate this yourself

Closing - please let us know if you continue to have issues after using the reworked plugin.


Change Compare to Distro Graph

Prompts and GUI display, name change on button, data processor update.

Updated this to now show distro graph. Also has all option added to correlation as well.


context_init: Fix cleanup in error handling

Also never use OSSL_LIB_CTX_free() on incompletely initialized context.
Fixes #17291

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master and 3.0 branches. Thank you for the review.


promtool metrics issues

Hi @mgumz,
prometheus promtool check metrics reports some issues related to metrics naming and help text. See,
$ curl -s http://localhost:8080/metrics | prometheus-2.41.0.linux-amd64/promtool check metrics
mtr_report_avg_gauge metric name should not include type 'gauge'
mtr_report_avg_gauge no help text
mtr_report_best_gauge metric name should not include type 'gauge'
mtr_report_best_gauge no help text
mtr_report_count_hubs_gauge metric name should not include type 'gauge'
mtr_report_count_hubs_gauge no help text
mtr_report_duration_ms_gauge metric name should not include type 'gauge'
mtr_report_duration_ms_gauge metric names should not contain abbreviated units
mtr_report_duration_ms_gauge no help text
mtr_report_last_gauge metric name should not include type 'gauge'
mtr_report_last_gauge no help text
mtr_report_loss_gauge metric name should not include type 'gauge'
mtr_report_loss_gauge no help text
mtr_report_snt_gauge metric name should not include type 'gauge'
mtr_report_snt_gauge no help text
mtr_report_stdev_gauge metric name should not include type 'gauge'
mtr_report_stdev_gauge no help text
mtr_report_wrst_gauge metric name should not include type 'gauge'
mtr_report_wrst_gauge no help text

5a6600c9be84f70c64d4b1e7342db2e872da6b9f  addresses the issue. I have implemented it in https://github.com/mgumz/mtr-exporter/tree/feature/multi-jobs
I have put the "old" metrics on "deprecation" (planned removal with mtr-exporter:0.4.0, whenver that might be). So, promtool check metrics will highlight the (deprecated) metrics for a while, but the new ones should actually match the best practices.


Pipeline keeps running when copy-template Task fails

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
copy-template Task failed because the template it tried to create already existed. After that the Pipeline stayed in state Running.
What you expected to happen:
The Pipeline switches to state Failed when copy-template Task failed.
How to reproduce it (as minimally and precisely as possible):

Create template (e.g. with name testtemplate)
Run copy-template Task with parameter targetTemplateName set to testtemplate

/cc @ksimon1

I have been testing this behavior and what I have come to is that if you do not force any order of tasks then copy-template task fails, but tasks after that will be still executed and Pipelinerun will be in state Failed.
When I have forced task copy-template to be executed before other tasks in pipeline, for example by adding to other tasks:
runafter:  - copy-template
than the log looked like this:
[copy-template : copytemplate] templates.template.openshift.io "testtemplate-copied" already exists

Tasks Completed: 1 (Failed: 1, Cancelled 0), Skipped: 1

And pipeline was in state "Failed" and did not keep executing tasks after copy-template task, which seems to me as a correct behavior. Please let me know if this worked for you or if I misunderstood the issue.

@0xFelix

Your description is correct and the behavior seems correct to me. It is working for me now and I can't reproduce the issue, thank you.


Curious about the macro, "WIN32", and others defined in minwindef.h

I see that the macro WIN32 is always defined if the user #includes <minwindef.h> or #includes <Windows.h> in a C++ project, so I'm wondering if the macro WIN32 is still used commonly?
If yes, should the macros in the header file minwindef.h be included on this page, or it will be in a separate Windows specific article about Windows macros?
Are we discouraged from using minwindef.h and should follow the conventions of using only the macros with the leading underscores listed in this page?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 302c807b-34ed-c367-be11-c1528666cb75
Version Independent ID: acf8ddce-337a-1a41-d39e-b7d2b52360cf
Content: Predefined Macros
Content Source: docs/preprocessor/predefined-macros.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @mikeblome
Microsoft Alias: mblome

@tommai78101
Good question. The important distinction here is predefined. This page lists the macros the compiler may define before any macros defined by source code (or in the project files, or on the command line) are created. Anything defined in the headers for Windows or MFC or WinRT is not part of the predefined macros, so it won't be mentioned here.


Add a tutorial

This is very much a moving target but shows how a conference could be scheduled with the tool as is.
I think it highlights  a couple of things that can be removed from the data structures (we're duplicating things with the rooms which I'm not sure are necessary) but hopefully this tutorial helps with our discussion going forward. :)

Coverage increased (+0.006%) to 98.636% when pulling b320630aae067a229e60d8c5fb3f08a429e50a26 on 6-tutorial into 86d52345da3e6fe8103778381b256aacca450f09 on master.

Coverage increased (+1.4%) to 100.0% when pulling 6ad2a4e21ddd073ffaa9c9b8fc0bea4151644eaf on 6-tutorial into 86d52345da3e6fe8103778381b256aacca450f09 on master.

Coverage increased (+1.4%) to 100.0% when pulling 33477eac2eac14f6c1206a378c196c977eb21d47 on 6-tutorial into 86d52345da3e6fe8103778381b256aacca450f09 on master.

I hope you don't mind me butting in?

Mind?!! I'm delighted! Welcome aboard.

Coverage increased (+1.4%) to 100.0% when pulling 99c8358299b3b0f797e5ac64c81a5284e7399313 on 6-tutorial into 86d52345da3e6fe8103778381b256aacca450f09 on master.

Thanks for the comments @alexwlchan: very helpful!.
For some of your questions about the data setup this is all based on the current setup in the library. I think I'd suggest we remove the Room class: and replace this with simply using a string in slot.rooms:
So that would replace the initial setup of this Tutorial with:
>>> from conference_scheduler.resources import Room, Slot, Event

>>> talk_slots  = [Slot(room='Big', starts_at='15-Sep-2016 09:30', duration=30, session="A", capacity=200),
...                Slot(room='Big', starts_at='15-Sep-2016 10:00', duration=30, session="A", capacity=200),
...                Slot(room='Small', starts_at='15-Sep-2016 09:30', duration=30, session="B", capacity=50),
...                Slot(room='Small', starts_at='15-Sep-2016 10:00', duration=30, session="B", capacity=50),
...                Slot(room='Big', starts_at='15-Sep-2016 12:30', duration=30, session="C", capacity=200),
...                Slot(room='Big', starts_at='15-Sep-2016 13:00', duration=30, session="C", capacity=200),
...                Slot(room='Small', starts_at='15-Sep-2016 12:30', duration=30, session="D", capacity=50),
...                Slot(room='Small', starts_at='15-Sep-2016 13:00', duration=30, session="D", capacity=50),
...                Slot(room='Big', starts_at='16-Sep-2016 09:30', duration=30, session="E", capacity=50),
...                Slot(room='Big', starts_at='16-Sep-2016 10:00', duration=30, session="E", capacity=50),
...                Slot(room='Big', starts_at='16-Sep-2016 12:30', duration=30, session="F", capacity=50),
...                Slot(room='Big', starts_at='16-Sep-2016 13:00', duration=30, session="F", capacity=50)]
>>> workshop_slots = [Slot(room='Small', starts_at='16-Sep-2016 09:30', duration=60, session="G", capacity=50),
...                   Slot(room='Small', starts_at='16-Sep-2016 13:00', duration=60, session="H", capacity=50)]
>>> outside_slots = [Slot(room='outside', starts_at='16-Sep-2016 12:30', duration=90, session="I", capacity=1000),
...                  Slot(room='outside', starts_at='16-Sep-2016 13:00', duration=90, session="J", capacity=1000)]
>>> slots = talk_slots + workshop_slots + outside_slots

And everything else works just fine (the room is actually just decorative, the session is used by the algorithm underneath).
What do you think @meatballs ?

Yeah, let's get rid. We can always add it (or something like it) back if we need a more friendly interface.
I was actually starting to think about how it might not be a 'room' anyway and, at the very least, needed renaming to 'venue' or something else.

Yeah, let's get rid. We can always add it (or something like it) back if we need a more friendly interface.
I was actually starting to think about how it might not be a 'room' anyway and, at the very least, needed renaming to 'venue' or something else.

Ok cool, I'll pick that up in this PR?

Coverage remained the same at 100.0% when pulling 1569cb001c42444bdfb39260a752b6ead4a0f239 on 6-tutorial into ac27c72921546c7bafd3296cfc4366d680126f0f on master.

I've made those changes in this one: also changes rooms to venue.


Extensions tab hangs forever

The extension tab hangs forever without showing any extensions (neither installed nor available in the marketplace). So I cannot install any extensions.

VSCode Version: 1.9.1
OS Version: Windows 10

Steps to Reproduce:

Open Extensions tab
It hangs for ever

The same happens when I try to install an extension with CTRL+P > ext install csharp
I already tried to completely uninstall VS Code, delete the extensions directory, reboot, and then install it again, but that didn't help.
And since this seems to be a cause of similar issues: I am not behind a proxy.

You might not know that you are behind a proxy. Are you in some corporate network?

Yes, I am in a corporate network, but my colleagues don't have such problems with VS Code and they are in the same network.
But I tried the app mentioned in #18103 anyway and it showed no errors. Can I provide any more information?

What was the output of that app?

 F1 Developer Tools

No, that looks good to me. I can inspect the html code, the css style and so on with it.

I meant the Console tab.

There I can select top or workerMain.js#editorWorkerService, but I don't see any messages. The space beneath is completely blank.

Can you share a screenshot?

Sure:

If you remove the @recommended and replace it with something else, you get the same behaviour? Do you actually have any http.proxy setting? How about a HTTP_PROXY env variable?

Yes, the same behavior, no matter what I choose in the extensions tab: @outdated, @disabled, or nothing (so my installed extensions). It just keeps that way so that it looks as if it would still be loading something. Shouldn't at least the display of installed extensions work independently of any network issues?
I don't have a HTTP_PROXY env variable set and I don't know of any other http proxy setting on my system. I definitely didn't set one.
When you think that this problem is network related: Is there anything else I can check to verify this? Would it help for example when I record the network traffic when I open the extensions tab?

@SecSan Yes it should...
Can you try out the ZIP release? https://az764295.vo.msecnd.net/stable/f9d0c687ff2ea7aabd85fb9a43129117c0ecf519/VSCode-win32-1.9.1.zip

That didn't change anything, the extensions tab still hangs.

Can you tell me where VS Code stores its settings and configuration? Maybe I just need to delete some config files or registry keys, so I can do a completely fresh install.
(I could make a copy of the files before, in case it actually helps. So you can check them to find what causes the problem)

Yeah let's try that. It should be somewhere in %APPDATA%.

Ok, I deleted the Code directory in %APPDATA% as it seemed to belong to VS Code, uninstalled the application, and made sure that nothing was left of it in C:\Program Files (x86)\. Then I tried first your ZIP release and afterwards the normal setup, but the problem is still there in both versions.

Is there any chance you can clone our code and try it out from source?

I tried to install as described in the article you linked to, but I got the following error:
C:\Workspace\GitHub\vscode>scripts\npm install
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade

><EMAIL_ADDRESS>preinstall C:\Workspace\GitHub\vscode
> node build/npm/preinstall.js

/d : Die Benennung "/d" wurde nicht als Name eines Cmdlet, einer Funktion, einer Skriptdatei oder eines ausführbaren
Programms erkannt. Überprüfen Sie die Schreibweise des Namens, oder ob der Pfad korrekt ist (sofern enthalten), und
wiederholen Sie den Vorgang.
In Zeile:1 Zeichen:1
+ /d /s /c node build/npm/preinstall.js
+ ~~
    + CategoryInfo          : ObjectNotFound: (/d:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

<EMAIL_ADDRESS>C:\Workspace\GitHub\vscode
`--<EMAIL_ADDRESS>extraneous

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v6.10.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>preinstall: `node build/npm/preinstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preinstall script 'node build/npm/preinstall.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the code-oss-dev package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build/npm/preinstall.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs code-oss-dev
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls code-oss-dev
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Workspace\GitHub\vscode\npm-debug.log

Settings and versions mentioned in the article:
C:\Workspace\GitHub\vscode>node -v
v6.10.0

C:\Workspace\GitHub\vscode>npm -v
3.10.10

C:\Workspace\GitHub\vscode>echo %PYTHON%
C:\Python27\python.exe

C:\Workspace\GitHub\vscode>python --version
Python 2.7.10

npm-debug.zip

The article says to use scripts\npm install. Not npm install.

That's exactly what I did: I was in the vscode folder and executed scripts\npm install.

Oh I misread that, sorry.
What does
/d : Die Benennung "/d" wurde nicht als Name eines Cmdlet, einer Funktion, einer Skriptdatei oder eines ausführbaren
Programms erkannt. Überprüfen Sie die Schreibweise des Namens, oder ob der Pfad korrekt ist (sofern enthalten), und
wiederholen Sie den Vorgang.
In Zeile:1 Zeichen:1

mean?

Are you in a PowerShell maybe? Can you try a Command Prompt?

The error was actually related to PowerShell, although I executed it from a Command Prompt, but it seems that it used the COMPSEC env variable at some point which was set to PowerShell on my system. After changing it to the normal cmd.exe I could complete the installation.
And now I can finally use extensions! I installed two extensions (csharp and prettify-json) and they work as expected.

Just wanted to say that the problem is now also gone with the newest release 1.10.2. I can now finally use extensions again :)
So I am closing this issue.

Hi there, wanting to chime in. I have the same problem for a few days now, all the outlined steps above didn't help.
I followed the issue above and really have EXACTLY the same behavior.
I'm still having the same problem with 1.10.2, and also with the insider builds.

Nevermind, I somehow skipped over the part with the ComSpec variable.
I too had mine set to PowerShell. Changed back to cmd.exe and extensions are working just fine again.
Really seems that VS Code doesn't want any other ComSpec than cmd.exe under Windows 10.


Play without HVSC locally installed

Download tunes to temporary files on-demand.

Maybe use something like https://github.com/gokyle/cachesrv to serve files?


The "srcSet" prop is inconsistent

While preloading images, the srcSet prop is being treated as a single string, but when rendering, it is treated as an array of strings.
I think it would be better to use single strings instead of arrays to follow the standard notation of srcSets, but in order not to break backwards compatibility, dynamic type checking should be used.

@jossmac I think this should not be closed yet, because single strings still cannot be used instead of string arrays for srcSet.

this probably should not have been merged, as this merge was pending and would have resolved the issue https://github.com/jossmac/react-images/pull/175


Correction for raw affiliation French intergroup of CML (Fi-LMC Group), Poitiers, France; Laboratory for Hematology and UMR 5239 CNRS, Centre Hospitalier Lyon Sud, Pierre-Bénite, France

Correction needed for raw affiliation French intergroup of CML (Fi-LMC Group), Poitiers, France; Laboratory for Hematology and UMR 5239 CNRS, Centre Hospitalier Lyon Sud, Pierre-Bénite, France
raw_affiliation_name: French intergroup of CML (Fi-LMC Group), Poitiers, France; Laboratory for Hematology and UMR 5239 CNRS, Centre Hospitalier Lyon Sud, Pierre-Bénite, France
new_rors: 023xgd207;029brtt94;02feahw73;01tkejf16;01bj4fd12
previous_rors: 023xgd207;029brtt94;02feahw73;01tkejf16
works_examples: W2001678255
contact: fddc52817ccd98f612263686984386ea:bbbb4349cd1ce8a73e42307cee7f @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


Missing await on EchoBot

var result = this.Recognizer.RecognizeAsync(context, ystem.Threading.CancellationToken.None);
var topIntent = result?.GetTopScoringIntent();

Missing an await on 'result'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73b78c1c-bd0f-caec-32ad-47e6dfcc5b34
Version Independent ID: 00957482-fbae-de4e-6c9c-49dae66c74af
Content: Using LUIS for Language Understanding - Bot Service
Content Source: articles/v4sdk/bot-builder-howto-v4-luis.md
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

Being taken care of, thanks for reporting!

This topic has been updated. If you find other issues, please open a new issue.


chore(main): release mdl 1.15.5

:robot: I have created a release beep boop
1.15.5 (2024-08-22)
Miscellaneous

main: release mdl 1.15.4 (#183) (5fb6052)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

mdl-v1.15.5
:sunflower:


added dropdown to navigation with links to various pages.

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!

##I have added a dropdown menu to the navigation, linking to other pages not showing on the original navigation.

the user will see the dropdown menu on hover to the navigation tab called "More"

Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

This fixes issue: https://github.com/zero-to-mastery/Keiko-Corp/issues/411
Summarize what this PR fixes:-
I have added a dropdown menu to the navigation, linking to other pages not showing on the original navigation.
Fixes #
https://github.com/zero-to-mastery/Keiko-Corp/issues/411
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

I was not the first one to claim this issue but it was reassigned to me by @brittneypostma

Please see screenshot below:

@brittneypostma PR has been made.  Please let me know if there is anything else you would like to be added to this.  By the way, the dark mode is not working.
Thanks

Looks good, I think pricing should be before the more dropdown though. I'm merging this in for now.

Good morning @brittneypostma
I added the dropdown there because on the original mockup there is no pricing on the navigation.  I am not sure at what time it was decided that it will be there.  I will go ahead and create a new issue and submit a PR to fix that and add it on the right side of the pricing tab.
Thank you!


Marimo is unable to save to PNG for some (not all) notebooks

Describe the bug
Saving to PNG fails for some notebooks.
The toaster appears with the error message, but no information is logged to the browser console - no errors, warnings, etc are added.
Environment
{
  "marimo": "0.9.16",
  "OS": "Linux",
  "OS Version": "5.15.0-124-generic",
  "Processor": "x86_64",
  "Python Version": "3.10.13",
  "Binaries": {
    "Browser": "--",
    "Node": "--"
  },
  "Dependencies": {
    "click": "8.1.7",
    "docutils": "0.21.2",
    "itsdangerous": "2.2.0",
    "jedi": "0.19.1",
    "markdown": "3.7",
    "narwhals": "1.13.2",
    "packaging": "24.1",
    "psutil": "6.1.0",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.11.2",
    "pyyaml": "6.0.2",
    "ruff": "0.7.1",
    "starlette": "0.41.0",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.32.0",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "altair": "5.4.1",
    "pandas": "2.2.3",
    "pyarrow": "17.0.0"
  }
}

Code to reproduce
My guess is there's a failure in downloadByUrl here: https://github.com/marimo-team/marimo/blob/7dfbc560dbbe49678dbfaba6c7af437c53aa75b5/frontend/src/utils/download.ts#L18
But because there's no JS error emitted, I don't know exactly how to reproduce.
I've got a notebook with 2 Pandas DataFrames displayed and 4 Altair charts.
The DataFrames are displayed by returning the DF at the end of the cell as per https://docs.marimo.io/guides/working_with_data/dataframes.html#displaying-dataframes - so I'm assuming they're using mo.ui.table.
When I comment out the DataFrames, then the download works. When I switch to mo.plain(...) to render the DataFrames, then download works.
I don't think there's anything special about the DataFrames apart from they have a "large" number of columns - the first one is 37 columns, but the second one is a limited subset of columns aggregated.

Thanks for reporting. Are you able to get it to consistently fail? Are you able to share the code? It looks like chrome has a 2mb limit for what we are doing, but Firefox does not. What browser are you using? Can you try safari or Firefox?

Thanks for reporting.

NP 🫡

Are you able to get it to consistently fail?

Yes I think so - I was on Friday and I can check again today.

Are you able to share the code?

Not the exact notebook I have now because it's full of financials, but maybe I can find a way to strip it down.

It looks like chrome has a 2mb limit for what we are doing, but Firefox does not. What browser are you using?

Am on Firefox 132.

Can you try safari or Firefox?

Not sure what other browsers I can try with.
I think there are two possible avenues:

See if it works in another browser, or
Create a shareable notebook that fails.

Not sure what's best to push on.

If you can share a similar notebook, I can try in other browsers for you, and it will help us debug the issue.

Just some small updates here:

Able to reproduce this with latest 0.9.27.
Have had two more notebooks fail to render PNG.
Notebooks seem to need to have a "large" DataFrame in them to cause the failure. Previously I had "wide" data (more than 30 cols). This time I've got only 8 cols, but 1.2M rows.
The most recent notebook had a single piece of information shown from its big DataFrame - a single column description: round(df['samples_count'].describe(), 0) 👈🏻 Once I comment this out, the notebook can be rendered to PNG.
PNG failure happens whether the download is triggered from the burger menu or the ctrl-K palette.


Pass IdentifierToken to BindingIdentifier in renaming code.

Hoisting inside of function* on the var x causes the let x to be renamed;
the rename code passed a string where  an IdentifierToken was required.
Fixes #1733

This is a real fix, but I don't think the cause is real.  The var x does not need a rename as far as I understand it. So the trigger for finding the type error, the hoisting action, is unnecessary. I think this is another instance of the problem with scopes of for loops in the blockbinding code.

LGTM


Add storybook for playground library

Don't include it anwhere but this will help showcasing all the components available in the playground.

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/playground

Show changes

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3412/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3412/


DataFrame can't handle separators in data

Related to #2968
Looks like DataFrame can't handle CSV where the separator appears in the column data.
Repro
var frame = DataFrame.LoadCsv(fileName);

foreach (var row in frame.Rows)
{
    Console.WriteLine(row[0]);
    Console.WriteLine(row[1]);
    Console.WriteLine(row[2]);
    Console.WriteLine();
}

CSV contents:
Name,Age,Description
Paul,34,"Paul lives in Vermont, VA."
Victor,29,"Victor: Funny guy"
Maria,31,

Expected behavior
Prints the contents of the CSV
Actual behavior
Exception:
Unhandled exception. System.FormatException: Line 2 has less columns than expected
   at Microsoft.Data.Analysis.DataFrame.GuessKind(Int32 col, List`1 read)
   at Microsoft.Data.Analysis.DataFrame.LoadCsv(Stream csvStream, Char separator, Boolean header, String[] columnNames, Type[] dataTypes, Int64 numberOfRowsToRead, Int32 guessRows, Boolean addIndexColumn, Encoding encoding)
   at Microsoft.Data.Analysis.DataFrame.LoadCsv(String filename, Char separator, Boolean header, String[] columnNames, Type[] dataTypes, Int32 numRows, Int32 guessRows, Boolean addIndexColumn, Encoding encoding)
   at ConsoleApp49.Program.Main(String[] args)

Maybe CSV parsing should get its own library in the BCL similar to JSON and XML? It is an extremely common need. CSVHelper is a great (and very popular) library but obviously you guys can not reference it in your packages.

Related to #2787


Feature request: shade protobuf dependency

We've had some issues with conflicting protobuf dependencies (javalite vs protobuf-lite) due to this dependency and others. Would you be open to shading the protobuf dependency instead?

Is this before or after the 1.9 release (see https://github.com/google/TestParameterInjector/issues/23) ?

It was, yeah

It was, yeah

Does this mean it was before or after?

I looked into this a bit, and it feels like I don't have enough Maven experience to be able to fix this without reproducing the issue and without breaking something else.
Do you have a concrete example change you think would work?
@cpovirk Do you have any advice here?

I've gotten myself a bit twisted around trying to understand this, but here's where I am, which is hopefully not wildly wrong:
My mostly unhelpful starting point is that I don't think this is "morally" TestParameterInjector's fault: The problem is the libraries that are still on the old protobuf-lite. (Or the Real Problem is that the protobuf people renamed protobuf-lite to protobuf-javalite in the first place. But we're stuck with that problem. Being stuck with that, incidentally, was quite possibly one of the experiences that the authors of https://jlbp.dev/JLBP-6 were familiar with when they wrote about not ever doing that kind of thing....)
Like I said, that's mostly unhelpful. But given that you're reporting other dependencies that are causing the same problem, I'd nudge you toward figuring out where the old protobuf-lite is coming from and trying to get those libraries to upgrade. But I seem to recall that protobuf at least used to require a close match between the runtime and the compiled code, so maybe that will go poorly? Or maybe it's gotten better, or maybe it was always OK as long as the runtime was the newer of the two? But it sounds like we're talking here about excluding the newer runtime, so I guess not?
(Digression(?): I just tried doing the upgrade for Truth. I got stuck because https://github.com/xolstice/protobuf-maven-plugin/pull/70 isn't in a release yet.... But that affects only our tests, so if by chance Truth is part of the problem, let me know, and we'll live without those tests or otherwise hack around it for now.)
My next can-you-"just...?" suggestion is whether you've looked into excluding the protobuf-javalite dep from TestParameterInjector or explicitly declaring protobuf-lite deps in whichever projects are currently seeing protobuf-javalite "win" over it.
It does seem like it would be possible for TestParameterInjector to declare its protobuf dependency as optional/provided. That would essentially automated the exclusion, so it would be good news for people who need the exclusion but bad news for users who get mysterious errors until they add the protobuf dep themselves. Or maybe TestParameterInjector could avoid those mysterious errors by switching to using the protobuf APIs only reflectively: If protobuf isn't on the classpath, then TestParameterInjector doesn't need it, since it can't be being asked to create parameters of that type. But that's a workaround in its own way, just one that would live in TestParameterInjector.
Given that TestParameterInjector does need to create instance of MessageLite types to pass to user-written tests, I'm not sure that shading can help here. But it's possible that I've misunderstood the problem, in which case lots of what I just wrote might be wrong :)


WS check during install falsely returns OK if another server is listening to port 9000

Test and Verified by Install and Upgrade.
Tested manually by down WS and direct curl then upgrade/install the cluster.
Close & Moving to Done


Update for go1.19

Update dependencies and allow building with go1.19.

Codecov Report

Merging #150 (3e90699) into main (a9fac8a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   64.47%   64.47%
=======================================
  Files          22       22
  Lines        2418     2418
=======================================
  Hits         1559     1559
  Misses        676      676
  Partials      183      183

Impacted Files
Coverage Δ

p2p/protocol/head/head.go
60.63% <100.00%> (ø)


Hello I want to ask a question

Hi. I'm new to coding. Is this possible to implement with a ChakraUI library for converting text to bionic reading?
Also, I'm not sure if this is the right place to ask.

You might need to override the component you need for bionic reading.

@elitetrollz
Hi. Thanks for leaving a question.
I'm sorry, but I don't understand the question, do you want to use this module as a component?
Like this -> https://codesandbox.io/s/festive-stonebraker-ij329x

@elitetrollz
Was the answer helpful?
If you have any other questions, please create a new issue or reopen this issue. Thank you.


Drink Water Extension

Is your feature request related to a problem? Please describe.
To enable users to track how much water they consumed throughout the day, I want to develop a Drink Water extension.
Describe the solution you'd like
I would make it using Javascript, and this would help the users to keep  a track of how hydrated their body is at a given time.
How do we know when the feature is complete?
I would like to raise PR for it.
Please assign this to me under GSSOC'24 @Sulagna-Dutta-Roy

Already added to my repository #335
Kindly raise new Issues. Closing this

Already added to my repository #335
Kindly raise new Issues. Closing this

Okay! Thank you.


No session factory registered for the given session options

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.3 LTS
TensorFlow installed from (source or binary): source
TensorFlow version: v2.1.0
Python version: 3.7.4
Installed using virtualenv? pip? conda?: conda
Bazel version (if compiling from source): 0.29.1
GCC/Compiler version (if compiling from source): g++ 7.4.0

Describe the problem
I have built TF from source (link). I have trained a DNN in python, frozen it as a .pb file, and now I would like to load the model and perform the evaluation in m my C++ code (Gist here).
However I get a segfault already when trying to create a session :
2020-02-03 11:55:25.001775: E tensorflow/core/common_runtime/session.cc:89] Not found: No session factory registered for the given session options: {target: "" config: } Registered factories are {}.
error while creating session: Not found: No session factory registered for the given session options: {target: "" config: } Registered factories are {}.

There have been similar issues (e.g. #3308), for which the proposed solution is to add the -Wl,--whole-archive flag when linking the TF libraries ; however this does not seem to work for me.
Does anybody have an idea what I could be doing wrong ?
Provide the exact sequence of commands / steps that you executed before running into the problem

Build TF from source

Compile (successfully) a custom C++ code creating a Session, linking the TF libraries with the relevant option (e.g : -L/home/ntonon/Documents/Programmes/tensorflow/bazel-bin/tensorflow -Wl,--whole-archive -Wl,--no-as-needed -ltensorflow_framework)

Running the code gives the error cited above.

Thanks in advance.

Hi, Have you solved this problem?
It has been troubling me for quite a long time until I add a header file in the source cpp in which the main function is compiled.
You can try to add "tensorflow/cc/client/client_session.h" in your entrance source file.
Though It has solved this problem, but I still don't know why.

Hi, yes I managed to solve it, unfortunately I tried so many things I don't remember what helped.
I now link as such (probably an overkill):
LFLAGS+= -L/home/mypath/tensorflow/bazel-bin/tensorflow -Wl,--allow-multiple-definition -Wl,--whole-archive -ltensorflow_framework -Wl,--whole-archive -Wl,--no-as-needed -ltensorflow_cc #-lprotobuf
I think what caused the issue for some reason was this :
session = tensorflow::createSession((tensorflow::GraphDef*) graphDef);
which I replaced by manual calls to functions:
tensorflow::Status status; tensorflow::SessionOptions sessionOptions; status = NewSession(sessionOptions, &session); status = session->Create(*graphDef);

It took me quite a long time to debug this issue.
Finally I fixed it by using this tensorflow_cc library.
This is how to generate this lib:
bazel build --config=opt //tensorflow:libtensorflow_cc.so

Then pick it from bazel-out path to wherever you want to put in. For example, I put it in /usr/local/lib/python3.10/dist-packages/tensorflow/.
Link this lib with -ltensorflow_cc in CMakeLists.
It makes me confused that pip install tensorflow cannot be used as C++ API creating session? Even ABI version fixed.

pip install tensorflow can only generate libtensorflow_cc.so.2 and libtensorflow_framework.so.2. I found that when I use flags  -ltensorflow_cc  and  -ltensorflow_framework , they are not found.
If the tensorflow is installed manuelly using bazel, libtensorflow_cc.so and libtensorflow_framework.so will be generated in /tensorflow/bazel-bin/tensorflow/ directory. Then linking wirh flags  -ltensorflow_cc  and  -ltensorflow_framework does the trick.


Terminal keeps show parameter undefined

I've updated some gem, and this is happens. I using regular expressions instead of cucumber expressions, so how to hint the "parameter undefined" in my terminal? how to remove the "parameter undefined" in my terminal?

Closing as not enough info provided.
@ameliaanism if this is still an issue please provide enough information to reproduce the error


Ensure we're returning correct response to enough_data

@PhilipTB this is the proposed change to the service interface. Without this the call to enough_data_to_set_target? always returns true, even if an estimate is required. This is the high-level guard that the application uses to ensure that sufficient data is available.


Add image and pdf fields in data request form

Add image and pdf fields in data request form
Upgrade  django-bulma to 0.9.0

Closes #230


Error while handling 429

Got the following error:

Err 	TwitterCrawler.CrawlPageAsync: error while handling 429: System.ArgumentOutOfRangeException: Number must be either non-negative and less than or equal to Int32.MaxValue or -1.
Parameter name: millisecondsTimeout
at System.Threading.WaitHandle.WaitOne(Int32 millisecondsTimeout, Boolean exitContext)
at TumblThree.Applications.Crawler.TwitterCrawler.d__40.MoveNext()

The issue has been fixed and closed. You can still comment. Feel free to ask for reopening the issue if needed.


Importing from SQLite

Hi,
Will you be considering importing directly from an SQLite database? (and exporting to...)
Thanks!

Importing is definitely on the roadmap (#892). Exporting to a SQLite database will likely take some more time to get to, but could be added as well.


New release

Added 91 new icons, for 260 total (Figma file)
Removed two-tone style, for now
Modified the code templates so that icons without variants don't have unnecessary code and typings
Double checked the output for bugs and rendering glitches

Thoughts on making this 3.0.0? 2.5.0?

Looks like it has breaking changes. Shall we go with 3.0.0?

Looks like it has breaking changes. Shall we go with 3.0.0?

Yeah, let's go with 3.0.0. I guess it's a good time to start following semver for real 😀


add BQN language

Add support for the BQN language as it's now passed the 2k unique file threshold.
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.bqn

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://github.com/Brian-ED/rayed-bqn

Sample license(s):

[x] I have included a syntax highlighting grammar: [URL to grammar repo]

[x] I have added a color

Hex value: #21584F
Rationale:  This is the main colour associated with BQN

[ ] I have updated the heuristics to distinguish my language from others using the same extension.

Add support for the BQN language as it's now passed the 2k unique file threshhold.

Not quite. 1 repo alone accounts for 380 of those files.

So how many files can a single repository account for as a percentage of the threshold?

So how many files can a single repository maximally account for as a percentage of the threshold?

It's not about how many files a repo has but rather how widely used the extension is. If there is an indication of a single user or repo having a disproportionate impact on the usage, I'll exclude it... 2000 files spread across 200 repos is a lot more indicative of widespread usage than 2000 files in a single repo.

You'll also need to run script/list-grammars also run at the bottom of that script.

When I try to run script/list-grammars I get the following error:
./script/list-grammars
Traceback (most recent call last):
        9: from ./script/list-grammars:4:in `<main>'
        8: from ./script/list-grammars:4:in `require'
        7: from /home/skykanin/Projects/linguist/lib/linguist.rb:5:in `<top (required)>'
        6: from /home/skykanin/Projects/linguist/lib/linguist.rb:5:in `require'
        5: from /home/skykanin/Projects/linguist/lib/linguist/language.rb:9:in `<top (required)>'
        4: from /home/skykanin/Projects/linguist/lib/linguist/language.rb:9:in `require'
        3: from /home/skykanin/Projects/linguist/lib/linguist/classifier.rb:1:in `<top (required)>'
        2: from /home/skykanin/Projects/linguist/lib/linguist/classifier.rb:1:in `require'
        1: from /home/skykanin/Projects/linguist/lib/linguist/tokenizer.rb:2:in `<top (required)>'
/home/skykanin/Projects/linguist/lib/linguist/tokenizer.rb:2:in `require': cannot load such file -- linguist/linguist (LoadError)

Seems that it's unable to load linguist/linguist from lib/linguist/tokenizer.rb for some reason.

You need to install the linguist gem... or use the Codespace we recommend.

Yes, it's the github-linguist gem. If you've got it installed, try running bundle exec ./script/list-grammars else try the Codespace.

I've indexed the following 27 Advent of Code repositories, which brings this search up to 2k.
repo:AlexDikelsky/puzzles OR repo:alephno/aoc2021 OR repo:alvinvoo/aoc2021 OR repo:arwn/aoc2021 OR repo:dancek/bqn-advent2021 OR repo:frasiyav/AoC2021 OR repo:m-lima/advent-of-code-2021 OR repo:AugustUnderground/AoC2022 OR repo:Choram/AoC2022BQN OR repo:Nhlest/AoC2022 OR repo:SamuelSarle/advent OR repo:akamayu-ouo/AoC OR repo:bddean/aoc OR repo:dancek/bqn-advent2022 OR repo:dankeyy/aoc22 OR repo:dgkf/advent-of-code OR repo:eissplitter/aoc-2022 OR repo:extorious/aoc2022 OR repo:felixr/advent-of-code OR repo:juriad/advent2022 OR repo:mpizzzle/AdventOfCode OR repo:saltysylvi/bqn-aoc2022 OR repo:RKBethke/aoc23-bqn OR repo:azenna/advent-of-code-2023 OR repo:icendoan/aoc OR repo:qqii/advent-of-code-2023 OR repo:timmarinin/aoc2023 OR repo:dlozeve/aoc2023

I note that file totals frequently don't add up right: the full search of added files gives 286, while this half returns 150 and this half returns 157, totalling 307. And these "286" files were needed to increase BQN's total from 1.8k to 2k, as earlier 255 wasn't enough.

Popularity really isn't the priority right now... passing tests is 😉

Apologies, I'd just talked to skykanin who believed popularity was the only remaining issue. I'm asking around to see if I can find someone to help.

@lildude could you approve the workflow? I was able to get rid of all the test failures locally :slightly_smiling_face:

@lildude Github's search indexing now shows that BQN has 3.4k unique files so I think this PR should be good to merge after the tests are rerun.

@lildude Github's search indexing now shows that BQN has 3.4k unique files so I think this PR should be good to merge after the tests are rerun.


failsafe postCreate script

postCreate.bash would fail if a database did not exist in a developer's environment. This is fixed by making migrations if creating the 'docker' admin user fails and trying again.

LG, will this come with any changes I have to do locally?

No, hopefully it makes us have to do less work, like calling the clear_models script manually for example.


 For the Card view, messages are truncated with an added tooltip. For the Drawer (Side panel) view, messages are split onto new lines.
Screenshots:

Card View

Side Panel View

CC: @karthikjeeyar

/approve
/lgtm

/cc @rohitkrai03

/approve


Support torch dataloader without torch formatting

In https://github.com/huggingface/datasets/pull/5084 we make the torch formatting consistent with the map-style datasets formatting. More specifically, a torch formatted iterable dataset will yield torch tensors.
The previous behavior of the torch formatting for iterable dataset was simply to make the iterable dataset inherit from torch.utils.data.Dataset to make it work in a torch DataLoader.
For those who want to keep using a torch DataLoader without using the torch formatting, we need the datasets.IterableDataset class to inherit from torch.utils.data.IterableDataset by default.
Since we don't want to import torch on startup, I created this PR to dynamically make the datasets.IterableDataset class inherit form the torch one. In particular, this will work:
>>> from datasets import load_dataset
>>> ds = load_dataset("c4", "en", streaming=True, split="train")
>>> from torch.utils.data import DataLoader
>>> dataloader = DataLoader(ds, batch_size=32, num_workers=4)
>>> for example in dataloader:
...:     ...

When the DataLoader checks if ds inherits from torch.utils.data.IterableDataset, I dynamically add it as a parent class. This is done by using __get__ on ds.__class__.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Need some more time to fix the tests, especially with pickle

And I actually don't quite understand the idea - what's the motivation behind making only IterableDataset compatible with torch DataLoader without setting the format explicitly?

Setting the format to pytorch = set the output types of the dataset to be pytorch tensors. However sometimes your dataset is not made of tensors but you still want to be able to use a pytorch DataLoader

A bit more context.
The arrow-backed Dataset supports DataLoader(ds) (even if the format is not "torch"), and we want to be able to do the same with IterableDataset for consistency. However, this is when the PyTorch internals come into play - an iterable dataset needs to be an instance of torch.utils.data.IterableDataset due to this check (notice there is no check for the map-style version). Hence the explicit subclassing in this PR.

Exactly :) Btw I just took your comments into account @polinaeterna , so feel free to review again

just checking, does this change still preserve the fix to the "data duplicate when setting num_works > 1 with streaming data" issue from before?
https://github.com/huggingface/datasets/issues/3423

Yes :)


Outline around bars in bar plot

I need a white bar in my bar plot with a white background, but since there are no outlines around the bars, one cannot see the white bar. (Hydrogen is always white in chemistry!)
I posted on Stack Overflow; someone suggested this is not currently possible?
http://stackoverflow.com/questions/29310646/outline-around-bars-in-bar-plot-in-gadfly?noredirect=1#comment46827123_29310646

There was't a way, but there is now by adding e.g. Theme(bar_highlight=color("dark grey")).

@dcjones Thanks. Now, I am attempting to use this feature with an \alpha value for transparency, and I think this bar_highlight is not accepting RGBA as a type.
LoadError: MethodError: `convert` has no method matching convert(::Type{Union{ColorTypes.Color{T,N},Function,Void}}, ::ColorTypes.RGBA{Float64})
This may have arisen from a call to the constructor Union{ColorTypes.Color{T,N},Function,Void}(...),
since type constructors fall back to convert methods.
Closest candidates are:
  call{T}(::Type{T}, ::Any)
  convert{T}(::Type{T}, !Matched::T)
while loading In[36], in expression starting on line 1

 in call at /home/cory/.julia/v0.4/Gadfly/src/varset.jl:53


Fix biases for "test-variations": ["Disabled", "Enabled"]

Hi @rwbutler, Thanks for your work!
I think I found a small corner case when assigning "test-variations": ["Disabled", "Enabled"] instead of "test-variations": ["Enabled", "Disabled"]. When the order is reversed, biases aren't reversed. Not a big deal, but it could be annoying to release a feature to 90% of users, thinking only 10% would be impacted.
For example, with the following feature file:
{
    "features": [{
        "name": "Example Feature Flag",
        "enabled": true,
        "test-variations": ["Disabled", "Enabled"],
        "test-biases":[90, 10]
    }]
}

Calling Feature.named(.exampleFeatureFlag)!.description results in the following:
Feature: Example Feature Flag
Enabled: false
Test variations: Enabled (90.0%), Disabled (10.0%)
Test variation assignment: 93% -> Disabled

The same behaviour occurs with Off/On instead of Disabled/Enabled.
I made a quick and dirty patch for it, which preserves the method testVariationsContains in case you planned to use it for other use cases. It's not the most elegant way, but it seems to do the trick.

Added new unit tests to cover this use case: https://github.com/rwbutler/FeatureFlags/commit/1f993c95bc2aa84e7d5e63cec2547c4991e19234

@nicolasanjoran Have given you a credit in the CHANGELOG / release notes - hope this resolves the issue for you! 🙏


torus-trooper: init at 0.22

Motivation for this change
Continuing what I started in #35482 :)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125651 run on x86_64-linux 1

1 package built:

torus-trooper

It builds and it works :+1:

Result of nixpkgs-review pr 125651 at 9e35a173 run on x86_64-linux 1

1 package built successfully:

torus-trooper

16 suggestions:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:52:5:
   |
52 |     (debianPatch
   |     ^

warning: build-tools-in-build-inputs
unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/games/torus-trooper/default.nix:82:3:
   |
82 |   buildInputs = [
   |   ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:46:5:
   |
46 |     (debianPatch
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/games/torus-trooper/default.nix:90:3:
   |
90 |   installPhase = ''
   |   ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:58:5:
   |
58 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:70:5:
   |
70 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:49:5:
   |
49 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:67:5:
   |
67 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:34:5:
   |
34 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:43:5:
   |
43 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:40:5:
   |
40 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:55:5:
   |
55 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:37:5:
   |
37 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:61:5:
   |
61 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:64:5:
   |
64 |     (debianPatch
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/games/torus-trooper/default.nix:31:5:
   |
31 |     (debianPatch
   |     ^


Unity errors when adding libraries in the Asset folder

[ x ] I am at the right place and my issue is directly related to ROS#. General technical questions I would post e.g. at ROS Answers or Stack Overflow. For library-specific questions I would look for help in the corresponding library forums.

[ x ] I have thoroughly read the Contributing Guideline and writing this issue is the right thing to do in my case.

I have a question!

[ x ] I searched the Wiki, open and closed issues for an answer. I tried my best to find the answer by myself without success. I believe that the discussion we will have in this issue, and the solutions we might find, will help me, and likely other community members who have a similar problem.

Here is my question:
 Hello! Thank you so much for sharing the source code and writing the detailed tutorials, they were of excellent help as well as very interesting. I'm new using ROS# and I'm trying to make an Unity template putting all sources of the RosBridgeClient and Urdf libraries in the Unity Assets folder and deleting RosbridgeClient.dll and Urdf.dll from the Plugins folder instead, this to better understand how the library works (following also what said in the issue #169).
Once I open Unity gives me many warnings and errors and I can't find a solution for that.
Could you explain me what I have to add specifically in the asset?
Thanks.

Hello @Scarf195
Any progress so far? Maybe describing the errors you get in detail might help for better understanding?

My setup :

Ubuntu 18.04
Unity 2019.3.08a
.NET 4.x

Here is what I get when copying the source of RosBridgeClient inside my project and removing the .dll

Seems that part of the problem is namespace clashing between internal classes like Publisher with ROS# Publisher amongst others


Invalid mappings can destabilize ambassador and introduce a brittle state

Describe the bug
Applying an invalid mapping seems to be tolerated fairly fine by ambassador. Actually, as long as the invalid mapping exists, it can throw the gateway into a brittle state where any new ambassador pods will be stuck in a crash loop.
While the invalid mapping exists, ambassador cannot scale or recover.
What is also very concerning, it seems that multiple attempts to apply bad mappings do not generate the same log output. The first attempt will result in an error and stack-trace, the 2nd attempt seems to generate a seemingly irrelevant message saying the following
2019/06/17 15:18:14 kubebootstrap: found xxx "service" in namespace "*" 2019/06/17 15:18:14 kubebootstrap: sent "service" to 1 receivers
Third attempt and beyond will not result in any log lines. It does not matter if the same or multiple different broken mappings are applied.
To Reproduce

Apply the following mapping:

---
apiVersion: v1
kind: Service
metadata:
  name: errored-mapping
  annotations:
    getambassador.io/config: |
      ---
      apiVersion: ambassador/v1
      kind:  Mapping
      name:  # ERROR
      prefix: /
      host: errored.config.net
      timeout_ms: 10000
      service: this-is-a-service-maybe:8080
      rewrite: /
      bypass_auth: true
spec:
  ports:
    - name: errored-svc-ambmap
      port: 80

Check ambassador logs, you should see this:

2019/06/17 15:16:51 notify: sh /ambassador/post_watt.sh http://localhost:8002/snapshots/2
2019-06-17 15:16:52 diagd 0.72.0 [P83TThreadPoolExecutor-0_3] INFO: Update requested: watt, http://localhost:8002/snapshots/2
2019-06-17 15:16:52 diagd 0.72.0 [P83TAmbassadorEventWatcher] INFO: copying configuration: watt, http://localhost:8002/snapshots/2 to /ambassador/snapshots/snapshot-tmp.yaml
2019-06-17 15:16:52 diagd 0.72.0 [P83TAmbassadorEventWatcher] ERROR: could not reconfigure: ACResource: Mapping requires name ({'prefix': '/', 'host': 'errored.config.net', 'timeout_ms': 10000, 'service': 'this-is-a-service-maybe:8080', 'rewrite': '/', 'bypass_auth': True})
2019-06-17 15:16:52 diagd 0.72.0 [P83TAmbassadorEventWatcher] ERROR: ACResource: Mapping requires name ({'prefix': '/', 'host': 'errored.config.net', 'timeout_ms': 10000, 'service': 'this-is-a-service-maybe:8080', 'rewrite': '/', 'bypass_auth': True})
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 600, in run
    self.load_config_watt(rqueue, url)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador_diag/diagd.py", line 708, in load_config_watt
    fetcher.parse_watt(serialization)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/config/resourcefetcher.py", line 154, in parse_watt
    self.handle_k8s(obj)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/config/resourcefetcher.py", line 202, in handle_k8s
    filename=self.filename, rkey=rkey)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/config/resourcefetcher.py", line 259, in parse_object
    self.process_object(obj, rkey=rkey)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/config/resourcefetcher.py", line 310, in process_object
    r = ACResource.from_dict(rkey, rkey, serialization, obj)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/resource.py", line 196, in from_dict
    return resource_class(rkey, location=location, serialization=serialization, **attrs)
  File "/usr/lib/python3.6/site-packages/ambassador-0.0.0.dev0-py3.6.egg/ambassador/config/acresource.py", line 64, in __init__
    raise Exception("ACResource: %s requires name (%s)" % (kind, repr(kwargs)))
Exception: ACResource: Mapping requires name ({'prefix': '/', 'host': 'errored.config.net', 'timeout_ms': 10000, 'service': 'this-is-a-service-maybe:8080', 'rewrite': '/', 'bypass_auth': True})

Delete the config in step 1 and apply it again, you should see something like this

2019/06/17 15:18:14 kubebootstrap: found 31 "service" in namespace "*"
2019/06/17 15:18:14 kubebootstrap: sent "service" to 1 receivers

Repeat step 3, nothing in logs

Keep the bad mapping and delete any of the ambassador pods or scale up the ambassador deployment, notice they are in a restart loop and never ready.

Delete the bad mapping. After another restart, the pod from step 5 should be running

Expected behavior
I expect that every time a bad mapping is applied, i get the same message in the logs. Hopefully the same message as the one in step 2.
I expect errored mappings to be listed in the ambassador route table or in the notices section of the diagnostics page.
I expect that error-ed mappings do not stop ambassador pods from starting.
Versions (please complete the following information):

Ambassador: 0.72
Kubernetes environment: AKS
Version 1.13.5

@kflynn @danielbryantuk  I would start implementing a fix but i'd like to know if you agree with my solution:

Add error handling so the exception is handled as an error, the logs would look like this:
2019-06-17 15:16:52 diagd 0.72.0 [P83TAmbassadorEventWatcher] ERROR: ACResource: Mapping requires name ({'prefix': '/', 'host': 'errored.config.net', 'timeout_ms': 10000, 'service': 'this-is-a-service-maybe:8080', 'rewrite': '/', 'bypass_auth': True})

I assume that doing that will fix the brittleness issues since it will stop the exception from bubbling up and killing whatever it is killing right now. This would be the minimum necessary.

Write the error in tvars under errors or notices. If errors don't show properly in diag view, i will put it in notices. I want it to show in the diag page but i don't want to implement new ui for it.

PS:
Adding the broken mapping to the routes table is an improvement that i don't have the time to implement. It involves updating the routes table to show invalid/ errored routes and a reason for why they are in that state.

Same problem here. We are using the gateway to serve differents apps on our Kubernetes cluster, and a wrong configuration makes the whole service unstable.

@kflynn now that the PR has been merged, this can be closed

I wish Ambassador was written in something like Go. Error handling is like part of the language, and is easy to find, and know when something could error.


Fix lazy repeater

This commit is forked off tag 0.6.5 - the latest tag to support php 5.3
Had to remove the use statement in LazyRepeat to get Message::parse() with PhpArray codec working.

This looks like it has already been fixed in master.  Thanks


Make npm IDE features available in non-Node.js web projects

npm is often used as a client-side package manager, even in projects where the back-end platform is not Node.js. It would be helpful to be able to use the npm features in any kind of web project.

Which projects are ya thinking it might be useful in?
Right now NTVS uses a different project system than other projects in VS, so it would not be easy to do. ASP.NET actually worked in our npm component in to their project system, so perhaps they'd be a good team to contact about bringing it into other projects in the future.
That said, the Interactive Window .npm command should be more doable. I believe we have some code in there that specifically checks for the Node.js project flavor.

+1 for this. It would be nice to be able to use the npm GUI in other project types.
e.g. I've just created a sample project using the ASP.NET 5 Preview Templates and would like to use it here.

@brettpostin gotcha, so the npm integration in solution explorer is already there (it's not the exact same, but hey're using our npm component).. and it'd take a bit of work, but we could turn the GUI into a global command...


Add Open Up The Cloud

Please check if the PR fulfills these requirements

[x] Links are correct
[ ] Github handle of user is specify, if not use LinkedIn link
[x] Entry is according to standard- [Name](URL) - Resources description [@github-username](https://github.com/github-username)

Thanks for your contribution @loujaybee!


Add fallback when resolving application name

Resolves #1137

Have you considered what happens to HostingStartupAssemblies when ApplicationName ends up being null?
https://github.com/aspnet/Hosting/blob/312e0da556e491a1a5b120a3c6d5626f5b5e2edc/src/Microsoft.AspNetCore.Hosting/Internal/WebHostOptions.cs#L31-L32
I think it might be a good idea to fall back to the entry assembly inside WebHostOptions instead of outside.

@JunTaoLuo Seems to be some odd diffs here (renaming). I'm not sure if it is intentional.

I moved two projects that were test apps into a different test assets directory. They are not tests themselves but are used in other tests.

Fixed test failures, ready for a final 👀


4.0.10-Final: CancelledKeyException

I've got a user on a legacy version reporting this error:

I know the version is old and it may be fixed, but I'd appreciate a look be taken. Apparently it happens to many connections to the server simultaneously.

Yeah its fixed

Am 20.03.2015 um 16:15 schrieb md-5<EMAIL_ADDRESS>I've got a user on a legacy version reporting this error:
I know the version is old and it may be fixed, but I'd appreciate a look be taken. Apparently it happens to many connections to the server simultaneously.
—
Reply to this email directly or view it on GitHub.

Alright, I might try a backport.
Any idea which version it was fixed in @normanmaurer ?

Doesn't really matter, I've backported the 4.0.23 upgrade


Core Customer Journey design improvements

Job
Start working on the improvements to the core customer journey.
⚠ Dependencies

UX audit
Design System
Market analysis (somewhat)
Writing audit

Can pick this and help with this as well.

@snehganjoo sure thing!
Let's narrow down the scope:

What precisely can we improve?
How will this impact the customer experience and the product growtg?
How will we measure success?

I'd suggest to begin by identifying small, incremental improvements we can make. If we could supplement it with some user study (a usability or concept testing), it would be terrific!
I'm here if you need anything!

@sirkotsky here is a basic plan of action for this task. Let me know your thoughts

Explore flow and make note of UI/UX issues through usability tests (can use task based walkthrough and use heuristics to do this).
Unmoderated/moderated user testing if possible would yield better results.Can try and recruit participants to do a think aloud - 5 users
List the changes/issues and rate them as per RICE (Reach, Impact, Confidence, Effort)
Basis changes suggested design screens
Run a quick prototype test to iterate and finalise- can use RITE here (it is very effective ( https://about.gitlab.com/handbook/product/ux/ux-research/rite/)
Build and deploy. Depending on changes made in the flow we can setup a success metric for the feature set. like clickthroughs, conversions, time spent etc

@sirkotsky some initial thoughts . Using Figjam to work and ideate on this. PF the link below

@snehganjoo thanks for sharing the FigJam.
Looking into the jam board right now, you are up to some good points there in terms of identifying the potential areas for improvement, but the conclusions you make may not really make sense from the user+product perspective and rely more on your understanding as a designer and a strive to simplify the experience rather than the customer's need and the product's value prop.
To give an example, "Actions and attributes" are a core part of the experience management which spans across multiple customer journeys: it resides at the top of the hierarchy because it's a global control that applies to more than just particular surveys.
You might be starting out a bit ambitious looking at every single step of the journey and trying to highlight many things at once. Moreover, you are looking at the customer experience, which is great, but I would reframe the conclusions as hypothesis: for instance, you say that templates are "very confusing and overwhelming for a user" but our case study shows quite the opposite. Remember that our users are looking for various products to be embedded in their customer's lifecycle, so the availability of various templates with different objectives is one of the key value propositions of ours.
I would recommend narrowing your scope to one journey point: for instance, looking into the survey analysis assessment and explore what we can improve. You could talk to the community users on Discord to see how they use the survey results, what are the features that are missing, and how we can improve the experience of assessing and reviewing survey data?
You've got a good eye and a really admirable strive for making the customer experience pleasant, I think with a little bit of focus and some iterations + a lot of user research (which you already have in your plan!) you'll be absolutely unstoppable! Let me know what you think!

Preliminary observation basis the survey but the N is too small to comment.
The value prop that keeps users coming back from their responses, is the fact that Formbricks is Open Source.
From an experience stand-point there is an equal split b/w custom template usage and pre-created template.
So far feature requests wrto survey experience have been a) ability to embed images b) one-time fill survey and c) a view which shows all questions on 1 page.
I tried Discord to get some qualitative data but have now moved to an in-app survey.
From my experience as a user (and trying to put aside my bias as much as possible) I still do feel that the template experience can be simplified, I did go through the case study but I am not sure apart from the usage pattern analysis / quantitative analysis what other qualitative data from users was used to come to this conclusion.
Another suggestion I have, again stemming from my experience of using Formbricks is introducing a word cloud analysis section for descriptive responses.
Let me know what you think.

I understand that we have a rather limited amount of customer data available to make well-informed decisions, and this poses a challenge. However, I would suggest you frame this as a sequence of hypothesis –> explorations –> refinement, where the initial assumption drives various concepts, which are tested and refined with the audience.
You could take either of the areas for improvement you see fit, frame a clear hypothesis ("by changing X, we will achieve Y and Z"), diverge it (design 2-3 concepts), and test them (quick usability testing with community volunteers) to find the one that truly works.
For instance, simplifying the survey form sounds like a great improvement. Let's take one assumption ("Creating a survey is a tedious and long process") and a hypothesis ("By reducing the number of steps required to create and configure a survey, we can increase user activation rate and increase the number of survey being launched"), and design a couple of concepts (i.e. 1) w/ settings and questions on the same page; 2) w/ simple vs advanced creation mode; 3) ...). Then, we can quickly test the concepts and see which one works best with our audience.
You have great ideas: I merely suggest to ground them and focus on identifying problems first rather than coming up with solutions right away.
Looking forward to hearing your ideas!


react-scripts: not found

When I run the code, I have this error
`><EMAIL_ADDRESS>start /home/alpha/Rover-Mission-Control

react-scripts start

sh: 1: react-scripts: not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file sh
npm ERR! errno ENOENT
npm ERR<EMAIL_ADDRESS>start: react-scripts start
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
`

Should I run npm install before ?

I still have the issue

npm install
npm start

Works for me on a computer I have not run this projct on before.
Make sure you have latest node version, I have v12.18.2


docs(config): add favicon

Converted the home page image to a 128x128 favicon
Added the favicon to a new the public folder
Referenced it on the head property of the config.js file
Enjoy!

Thank you!


add DRONE_COMMIT

Purpose
In testing, codecov-bash was uploading reports to the wrong commit SHA when using drone ci.
It is unclear where it was getting the incorrect value from.
This code, outside of the codecov-bash script, did seem to help.
export VCS_COMMIT_ID=$DRONE_COMMIT
export GIT_COMMIT=$DRONE_COMMIT
The previous comment "drone commits are not full shas" was written in 2015 and may be obsolete now.

@sdarwin thanks for this commit. Unfortunately, we will be deprecating codecov-bash in favor of uploader. You are welcome to open a PR there


Rename build to install

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-monitor-opentelemetry-exporter