What happens if the access token is about to expire?

The AbaxAuth class will refresh an expired access token (if able) when you call AbaxAuth.getAccessToken. It will not refresh the access token if the token is about to expire, say in 1 second, 30 seconds, 1 minute or 5 minutes.
It's quite plausible that whatever the access token is subsequently used for will face a 401 error if the AbaxAuth naïvely tells you "this token is good to go 👍" when it is in fact expiring very shortly. For example, a program fetching thousands of entities that needs to slow down due to rate limiting could easily last more than a few minutes. If you know that your program falls into this category, it would be nice to be able to tell AbaxAuth that you won't accept an access token that is about to expire very shortly.
Perhaps we should add an option to the AbaxAuth class or getAccessToken function that lets the user specify an amount of time that the token ought to last.
That could look like this:
const abaxAuth = new AbaxAuth({
  clientId: 'abc',
  clientSecret: 'def',
  redirectUri: 'http://localhost:3000',
});

abaxAuth.setCredentials({
  accessToken: 'existingToken',
  refreshToken: 'refreshToken',
  expiresAt: new Date('2024-04-10T12:00'),
  tokenType: 'Bearer',
});

const apiKey = abaxAuth.getAccessToken(600); // get an access token that must last at least 600 seconds from now

Alternatively, it could look like this:

const abaxAuth = new AbaxAuth({
  clientId: 'abc',
  clientSecret: 'def',
  redirectUri: 'http://localhost:3000',
  minimumAccessTokenDuration: 600, // access tokens must last at least 600 seconds when retrieved
});

abaxAuth.setCredentials({
  accessToken: 'existingToken',
  refreshToken: 'refreshToken',
  expiresAt: new Date('2024-04-10T12:00'),
  tokenType: 'Bearer',
});

const apiKey = abaxAuth.getAccessToken();

I feel that regardless of how we implement it, there should be a default value between 60 seconds and 300 seconds. Does anyone really want an access token that lasts less than a minute? That seems incredibly risky considering rate limiting.


feat(themes): add more themes by tPenguinLTG

Issue: #213
Themes added:
aiee
ash
blue
cherry
darkTeal
fxDev
hotChocolate
monochrome
polarized
powerShell
raspberry
redWine
seawater
solarizedDark
solarizedLight
stormClouds
wmii

:tada: This PR is included in version 3.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Apologies, I had let this slip in my busyness. I will make an effort to PR the unpublished ones soon.

@tpenguinltg no worries! as you can see I opted for first converting the themes using the util you've created, and then just exporting the result as literal object. That's because it makes it easier for me to port the themes to react95-native (I can just copy the files 😅 )

That unfortunately would mean more work for v4, but I guess it's easier than what will have to be done for the other themes since we still have the original values. Would you want me to do the same when I PR the new ones?


Add saveMap and readMap to DatastoreOperations

Need to check if it's possible at all.

Map findByIdAsMap(Object id, TypeInformation mapType)
We have to use "TypeInformation" vs plain old "Class" because we need the type parameters of the key and value, and also the value type may have type parameters.
I also intentionally didn't put Map<A,B> as the return type and TypeInformation<Map<A,B>> as the param because B might be a type with type param like List<Double> or even another embedded Map<C,D....> , and B would only refer to List or Map in those cases respectively, so having these type params doesn't actually get us anything.
void writeMap(Object id, Map map)
I don't think we need the type information for the write because we can examine each item in the map and convert based on their individual types.

I think it has to be
Map findByIdAsMap(Key key, TypeInformation mapType)
void writeMap(Key key, Map map)
Because we need to get not only an id, but also a kind, and a Key has both.


Implementing Stack using Javascript

Initiative (Required)
Hacktoberfest 2024 🎃
Is your feature request related to a problem? Please describe.
I am planning to introduce data structures to this repo
Describe the solution you'd like.
I will implement stack functionality using JavaScript. it will include push, pop, peek and isEmpty
Add any other context or screenshots about the feature request here.
No response

please assign this issue to me. I have the solution ready, just need to raise its PR


feat: introduce failure parser

Closes #159

Codecov Report

Merging #160 (60279ee) into main (f2a962b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

:exclamation: Current head 60279ee differs from pull request most recent head c512def. Consider uploading reports for the commit c512def to get more accurate results

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   97.86%   97.93%   +0.07%
==========================================
  Files          19       20       +1
  Lines         187      194       +7
  Branches       29       30       +1
==========================================
+ Hits          183      190       +7
  Misses          4        4

Impacted Files
Coverage Δ

src/parsers/failure.ts
100.00% <100.00%> (ø)

src/parsers/index.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Windows immediately stops with message INFO[0000] Bye

Using the newest released binary (also tried the one before the newest) I get the message "INFO[0000] Bye" instantly after typing "dry".
Docker started properly and is running but I can't seem to get this running. Sadly I don't get any detailed error messages.

Hi,
Could you please try to redirect stderr output to a file and copy the content here: dry 2&> dry-complains.txt
Also, are you trying to run dry on Windows?

Hi thanks for your quick response. Yes sorry should have written that in my text. I am trying to run dry on Windows.

Ok, it works now. Had to activate: Expose daemon on tcp://localhost:2375 without TLS in the docker settings. Sadly the color theme makes it unusable on windows. But there is already another issue for that.
Thanks for your help.


chore(release): 1.1.0

Purpose
Merge minor version in.

Why would you want to merge this back in?
Based on our guide only major release needs a merge back, but minor and patch does not.

So that:

the next release version is automatically and correctly picked up
the repository's home page CHANGELOG.md is up to date

We might want to rethink our guide, based on the above, it makes sense to release on main and then cut the release branch, which only needs cherry-picked commits for hotfixes.
What do you think?

the next release version is automatically and correctly picked up

But I guess this would only be for minor, excluding patches correct? Also, how would it be in case of e.g. 1.2.0 bump when currently latest is 2.0.0?

the repository's home page CHANGELOG.md and package.json are up to date

I guess having CHANGELOG.md to reflect changes is OK, but then yet again not very clear to me the situation of multiple major versions. Do we only have bugfixes in previous versions when the next major released?

It makes sense to release on main and then cut the release branch, which only needs cherry-picked commits for hotfixes.

Yet again not entirely sure, unless having release branch per major version is not that good of idea?
P.S. I believe that the log generator was a little wrong, I just noticed that the license fix was already applied before the initial release.

I guess the point of major release branches is to retroactively apply hotfixes:

For minors and patches it makes total sense to simply fast-forward on the trunk - main.
We always need the latest version on main, otherwise we can't auto-gen the next version:

P.S. I believe that the log generator was a little wrong, I just noticed that the license fix was already applied before the initial release.

That happened because we were missing a tag, I created it afterwards but too late.
I'll open another MR to fix the changelog.


Need to be able to assign a specific cidr range for DHCP in WSL2 distros

When I connect to my corporate VPN they use the CIDR range <IP_ADDRESS>\16 which seems to always conflict with the CIDR range being used by Hyper-V / WSL so I cannot connect to the internet from the WSL distro, and sometimes not even connect to my corporate network if the IP address assigned happens to already be in use.
Describe the solution you'd like
I would like to be able to assign a specific CIDR range for use by the Hyper-V Default Switch &| the WSL vswitch.

Ref #4601.


AWS LAMBDA - Invalid `photon.() EROFS: read-only file system, chmod '/var/task/.../query-engine-rhel-openssl-1.0.x'

I am trying to use photon within my aws lambda functions. I am bundling the generated photon package within my node_modules. In my lambda code, I am initializing my Photon client using this function, in order to determine database during runtime:
import { Photon } from '@prisma/photon';

export const getPhoton = (prismaDbUrl: string): Photon =>
  new Photon({
    datasources: {
      db: prismaDbUrl
    }
  });

However I receive an error when I try to query database using photon. Below is result of my lambda function
{
  "errorType": "Error",
  "errorMessage": "\nInvalid `photon.()` invocation in /var/task/node_modules/@prisma/photon/index.js:2159:44\n\n\n\nEROFS: read-only file system, chmod<EMAIL_ADDRESS>  "trace": [
    "Error: ",
    "Invalid `photon.()` invocation in /var/task/node_modules/@prisma/photon/index.js:2159:44",
    "",
    "",
    "",
    "EROFS: read-only file system, chmod<EMAIL_ADDRESS>    "    at PhotonFetcher.<anonymous> (/var/task/node_modules/@prisma/photon/index.js:63:31)",
    "    at Generator.throw (<anonymous>)",
    "    at rejected (/var/task/node_modules/@prisma/photon/index.js:6:65)"
  ]
}

It is not possible to run chmod within aws lambda (except in /tmp). The real question however is: Why does photon need to run chmod in the first place?
I have inspected the generated photon package a bit, but I still cannot figure out, why does photon need to run chmod on the query engine, or how to solve this problem.
Prisma2 version:
2.0.0-preview019
Photon version:
2.0.0-preview019
Note: I am unable to upgrade to the newest version, since I am also using nexus-prisma plugin

@simonobe Can you please share your serverless.yml file 🙏 ?

sorry did not see this comment before. I can share you some parts, but probably not all of it. Can you please tell me, which part of serverless config you would like to see? Moreover, I do not see how serverless.yml is of any relevance. I can tell you how we bundle our code, as that seems more relevant to me.
We are using webpack to bundle our code.
However each time we rebuild with webpack, we are also rebuilding node externals. That means that after webpack builds our package (but before we zip it), we reinitialize the photon package (without 'native' binary target, since this would only bloat the package - btw the package is over 100MB, can something be done to reduce that?).
In order to execute reinitialization of the photon package, we use our custom serverless plugin to hook into the process of package building.
Nevertheless, if we look at the error, it is clear to see where the problem is. AWS Lambda environment does not allow to execute chmod command, which alters /var/task directory, which is exactly what PhotonFetcher seems to be doing. Can you please help me understand, why does chmod needs to be executed in the first place?

Yeah, I asked for it because I wanted to know if there are any build steps as you have mentioned.
Now can you please share the generator section of your schema. I want to see what you have in your binaryTargets property, either it is specified or not

Yeah, I asked for it because I wanted to know if there are any build steps as you have mentioned.
Now can you please share the generator section of your schema. I want to see what you have in your binaryTargets property, either it is specified or not

this is the generator from schema I use
generator photon {
  provider      = "photonjs"
  binaryTargets = [ "rhel-openssl-1.0.x"]
  output = "build/serverless/service/node_modules/@prisma/photon"
}

@pantharshit00  were you able to go through the issue?
generally speaking are there any people who are succesfuly using photon on AWS?

This is being caused by building locally with output on Windows, then uploading to run on a Linux environment: https://github.com/prisma/prisma-client-js/issues/476

Maybe we can close this in favour of #476 as we have identified the problem there.
cc @janpio

Done, and linked to this issue as "more information".


[Rendering][Teams][iOS] The markdown is not handled in the adaptive card when the card includes mention

Target Platforms
iOS
SDK Version
1.0
Application Name
Microsoft Teams
Problem Description
The markdown is not handled in the adaptive card when the card includes mention.
But when the mention part is not in card JSON, markdown is processed appropriately.
Screenshots
Adaptive card with mention within:

Adaptive card without mention within:

Card JSON
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "Container",
            "items": [
                {
                    "type": "TextBlock",
                    "text": "Hello <at>Username</at>",
                    "wrap": true
                },
                {
                    "type": "TextBlock",
                    "text": "This is some text that includes markdown. **This part should be bold.** [This is a link](https://www.example.com)",
                    "wrap": true
                }
            ]
        }
    ],
    "msteams": {
        "entities": [
            {
                "type": "mention",
                "text": "<at>Username</at>",
                "mentioned": {
                    "id": "<userId>",
                    "name": "Username"
                }
            }
        ]
    },
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.0"
}

Sample Code Language
No response
Sample Code
No response

This issue has been copied over to Microsoft Teams repo here: https://github.com/MicrosoftDocs/msteams-docs/issues/4253


Custom system prompt and Modelfile system prompt not reaching Ollama

Bug Report
Description
Bug Summary:
The system prompt set at Settings -> General -> System prompt is being totally ignored lately (it has correctly worked in my setup previously). Also, I have some Modelfiles defined with their own embedded system prompts. These sometimes do work, but not always.
Steps to Reproduce:
My environment consists in an Open WebUI instance in a server and an Ollama being served in a different machine.
In my user account I have the following content in Settings -> General -> System Prompt:

Eres un pirata y no puedes evitar mostrarlo al hablar. Además, siempre te acompaña tu dicharachero loro pirata, Barbeque

In addition, I have some modelfiles with a system prompt defined. E.g.:

FROM llava:7b-v1.6-mistral-q4_0
SYSTEM """
You are an expert image analysis assistant with industry experience across all facets, often used as a forensic expert to analyze evidence and advise commercial and government clients on how to use equipment to take photographs and the processing and post-production that could be applied to them. When I present you with an image, do the following:
Create a working title of the Photo.
Write a brief overview of the photo, capturing its essence and setting the scene.
Describe the photo's main subject(s) in detail, including any interesting features or characteristics.
Write an analysis of the photo's composition, such as framing, perspective, and use of light. Highlight any unique elements that draw the viewer's attention.
Describe the emotional impact or mood conveyed by the photo. Consider the feelings it evokes and any storytelling elements present.
If not described in the prompt, invent some fictional information about where the photo was taken, including geographic location or any relevant contextual details that enhance its significance.
Include technical information such as making an assumption or best guess of the camera settings, lens used, and any post-processing techniques employed.
Additional Notes: Invent additional information or anecdotes that add to the story behind the photo or its creation process.
""""

Starting a new chat with any model will trigger the 1st kind of bug (user defined system prompt) for me.
The 2nd bug (Modelfile defined system prompt) is triggered when asking the model instance derived from that Modelfile.
Expected Behavior:
I expect my user defined system prompt to always be passed to the Ollama model and receive a response which is coherent with it. And I expect models defined with a Modelfile to also take into account the specified instructions.
Actual Behavior:
Models are responding in a way that is totally unaware of both system prompts. In fact, in the Ollama logs I am seeing that the system prompts are not reaching it (details in logs and screenshots below).
Environment

Open WebUI Version: 0.1.125

Ollama (if applicable): 0.1.38

Operating System: Ubuntu 22.04

Browser (if applicable): Firefox 126.0

Reproduction Details
Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.
[X] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):
Case 1:  conversation with a regular llama3-3B model

I have this system prompt defined:

Then I make the following interaction:

The request as shown in the browser console (no trace of the system prompt):

Case 2:  conversation with a Modelfile instanced model

The Modelfile:

Then I make the following interaction:

The request as shown in the browser console (no trace of the Modelfile prompt):

Installation Method
We are using Docker Compose to setup the Open WebUI.
Additional Information
It stopped working some days ago. To my knowledge, the only relevant changes I did since then were some updatings of the Ollama and Open WebUI versions.
Thank you!

As usual with any new release, we often do some fixes afterwards that push direct to main and build new Docker images. If you haven't already done so as of 3hrs ago please try re-pulling again.

Great, that fixed it, thanks!


[IMPORTANT] Dear folks who sent pull-request, and are disappointed for the commit that was merged as different name

Dear folks.
@Mandaryn https://github.com/rack-test/rack-test/pull/115
@anatol https://github.com/rack-test/rack-test/pull/89
@anatol https://github.com/rack-test/rack-test/pull/90
@benders https://github.com/rack-test/rack-test/pull/127
@bestie https://github.com/rack-test/rack-test/pull/133
@croeck and @timsly https://github.com/rack-test/rack-test/pull/125
@d-unseductable https://github.com/rack-test/rack-test/pull/112
@davidcelis https://github.com/rack-test/rack-test/pull/132
@iGEL https://github.com/rack-test/rack-test/pull/108
@jdrago999 https://github.com/rack-test/rack-test/pull/124
@jordimassaguerpla https://github.com/rack-test/rack-test/pull/72
@mperham https://github.com/rack-test/rack-test/pull/154
@olivierlacan https://github.com/rack-test/rack-test/pull/146
@reiz https://github.com/rack-test/rack-test/pull/126
@sanemat https://github.com/rack-test/rack-test/pull/70
@scepticulous https://github.com/rack-test/rack-test/pull/141
@tenderlove https://github.com/rack-test/rack-test/pull/131
@terceiro https://github.com/rack-test/rack-test/pull/134
@tgxworld https://github.com/rack-test/rack-test/pull/116
@trevor https://github.com/rack-test/rack-test/pull/81
Dear folks to send pull-request but are disappointed that the PR was not merged directly, but merged to master branch as other people's name.
Maybe I listed up all the target people. But if I missed, let me know.
I am Jun Aruga.
I am working as a maintainer from this month.
First of all, I will apologize that we disappointed you.
We have to admit that we made a mistake for the way to merge. It was not a best way.
Let me tell you why this was happened.
The rack-test project had not worked more than 2 years, as my recognition.
People like you, sent PR or tried to contact to original author.
Though he maintained by alone, he was busy.
However recently this month the situation was changed. You can see a thread [1] for detail.
2 leaders did stand to tackle for the situation.
1st leader had kept own fork merging many PRs to expand rack-test's life time.
2nd leader was able to contact original author, and he was success to move original repository to rack-test/rack-test. You can see this repo's URL is changed to rack-test/rack-test.
They were the light of this project. They recovered this dead project.
They are working for this project as maintainer.
I also joined from this month as maintainer.
Last time only 1 maintainer for rack-test.
But now we have at least 3 maintainers for rack-test. rack-test is enhanced
There are around 10 or 20 people like you, who are disappointed for that.
I will definitely write every people's name like you to History.txt file, though this is not best way.
https://github.com/rack-test/rack-test/blob/master/History.txt
I am happy for you to understand that every people tried to recover rack-test, and spent a time for that. And we made mistake. But now mostly this repository is starting to recover.
I really thank you all very much.
[1] https://github.com/rack-test/rack-test/issues/135

@junaruga really appreciate you taking the time and spending the effort on documenting why this happen. It was an "easy way" for me to try and recover from the lack of maintenance the last years; taking @scepticulous fork was the easiest way to get some of the recent work incorporated.
Sorry for the confusion this caused to you, my apologies. We truly appreciate ALL the contributions from all of you. Let's work really hard to "make rack-test great again"! 😉

@perlun Yes, I can understand you. It was easy way. And we had to do it at that time to recover this repository as faster.

I will definitely write every people's name like you to History.txt file, though this is not best way.

History.txt was updated by PR https://github.com/rack-test/rack-test/pull/165


Add benchmark results in README.md

Added benchmark results for enums with unit variants in https://github.com/devashishdxt/desse/commit/87da05ce81fb1243758849bb864f77c544e8adf6.

Closing in favour of https://github.com/devashishdxt/desse/pull/10


Patching Array

Given a sorted positive integer array nums and an integer n, add/patch elements to the array such that any number in range [1, n] inclusive can be formed by the sum of some elements in the array. Return the minimum number of patches required.
Example:
Input: nums = [1,5,10], n = 20
Output: 2
Explanation: The two patches can be [2, 4].
Can i contribute into this algorithm? @amritansh22

Yes sure.

Assigned you @sdatrey


Worker Annotation for Android WorkManager Worker

Is your feature request related to a problem? Please describe.
I would like to use exclusively annotations to define my Android dependencies
Describe the solution you'd like
A Worker annotation that be placed on WorkManager worker implementations to inject
Describe alternatives you've considered
I currently use the Kotlin DSL to define my workers
Target Koin project
koin-annotations

Hi @mschwerz-bitrip , I am not sure about your question but there exist an annotation for Worker @KoinWorker
Also check out this project on how I did the setup - koin-playground

Hi @mschwerz-bitrip , I am not sure about your question but there exist an annotation for Worker @KoinWorker
Also check out this project on how I did the setup - koin-playground

I 100% did not see that. Thank you for mentioning!


[calceph] update to version 4.0.3

[ X] Changes comply with the maintainer guide.
[ X] SHA512s are updated for each updated download.
[X ] Any fixed CI baseline entries are removed from that file.
[X ] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ X] Only one version is added to each modified port's versions file.

Thanks for the update!


Merges Master to Live. See commits for details.

Docs Build status updates of commit 4f69578:
:clock10: Full build: the average full build time is 13 min(s) 50 sec(s), this is based on the last 459 build(s) for this repository.

Docs Build status updates of commit 4f69578:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/devices/Clear-MobileDevice.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mail-flow/Get-MessageTraceDetail.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Search-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Add-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Remove-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPNavigationNode.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Set-SPTrustedRootAuthority.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Split-SPScaleOutDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/New-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/New-Team.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-Team.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 140d9cc:
:clock10: Full build: the average full build time is 13 min(s) 50 sec(s), this is based on the last 460 build(s) for this repository.

Docs Build status updates of commit 140d9cc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Export-AutoDiscoverConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/devices/Clear-MobileDevice.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mail-flow/Get-MessageTraceDetail.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Search-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Add-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Remove-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Get-PnPNavigationNode.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Set-SPTrustedRootAuthority.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-server/Split-SPScaleOutDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

skype/skype-ps/skype/New-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/New-Team.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-Team.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


FIX: Menu in DataGrid shows incorrectly due to z-index

Commit  9fa7d0182d57f25cb38ef971b212a974d45f39d8 introduces a fix and a bug at the same time. This PR keeps the fix and removes the bug.
z-index set to 20 to give people more room in-between
Before as shown in issue #355

In this PR
Menu above DataGrid Header (same as previous commit)

Menu's navigation menu above other Menu's in a DataGrid

Hi @vertonghenb,
Maybe we can keep 2 instead 20 for z-index since we had problems in the past with other libraries like Bootstrap.


added support for repeatable change scripts such as stored procedures…

snowchange is great at handling versioned script changes useful in maintaining objects that get altered over a period of time.
I have modified the utility a little, to make it easy to maintain objects like stored procedures and functions that could be called as "code" and always need to be applied in their entirety. Scripts that hold such code are called out as repeatable.

Thank you for thinking about this @kedar-waval. I have also thought about adding support for repeatable migrations to snowchange so happy to see someone take this up. But I would like us to follow the Flyway semantics for repeatable migrations. The file naming semantics for snowchange have been modeled after Flyway and I would like to keep that. Please see the documentation here: https://flywaydb.org/documentation/concepts/migrations#repeatable-migrations
This will also make snowchange better handle files in the project root folder. I think we should ignore any files that don't match the specific project files we're looking for, instead of treating all .sql files that don't start with V as repeatable.
Hope that makes sense.

Thanks for reviewing @jeremiahhansen!
Flyway style naming convention makes sense for repeatable scripts. I have made changes so that snowchange now uses that naming convention.

Hi @jeremiahhansen,
I had noticed this comment in the script:
TODO: Figure out how to directly SELECT the max value from Snowflake with a SQL version of the sorted_alphanumeric() logic
I have modified the SELECT statement in fetch_change_history to take advantage of the INSTALLED_ON column for getting the last applied version number.

Thank you @kedar-waval. Do you have some examples of repeatable scripts?

@kumarjoshi, did you mean examples of naming repeatable scripts?
Here you go:
R__sp_add_sales.sql
R__fn_get_timezone.sql
R__fn_sort_ascii.sql

@kumarjoshi, did you mean examples of repeatable scripts names?
Here you go:
R__sp_add_sales.sql
R__fn_get_timezone.sql
R__fn_sort_ascii.sql

I meant the actual scripts (similar to the ones in demo/citibike)

Thanks @kedar-waval and @kumarjoshi, appreciate the help here. I'll take a closer look at the changes.
With respect to the fetch_change_history() changes, I'm trying to think through the edge cases with relying on the INSTALLED_ON data instead of the version number. I want to be sure that the most recent record based on INSTALLED_ON will also return the correct version number. One thing that came to mind is that most DCM tools include the ability to undo or roll-back transactions. If snowchange supports this someday then we wouldn't always want the most recent versioned change record. Maybe at that point we'd just include the versioned and undo scripts in the query. I'll give it some more thought.

Sorry for the slow response here @kedar-waval, should have time to do a final review/test in the next few days. Thanks!

Alright, I think these changes look good. Still cautious about the change to find the max version but I think that it makes sense. And at the very least I think it practically behaves the same as it does now. Thanks again for the changes!

Sure!
No problem @sfc-gh-jhansen.
I am glad that snowchange will now support repeatable scripts.
Cheers!
Kedar


⚠ Secret Website 3 has degraded performance

In 64b1f84, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2697 ms

Resolved: Secret Website 3 performance has improved in 3e5187f.


Update dax-lsstsw-matrix env to 1eb92eb

Already merged, and now replaced.

(Was merged via DM-31967.)


Do I have microSD card bay on any computer?

With kudu1 gone https://github.com/130s/hut_10sqft/issues/537 that has microSD slot, I need to find an alternative computer that has one.

Found a slot on p50.


I have to allow status modification without a message

First, my opinion is, we have to add a message to change the status, because it's good for customer relationship, but I am not the one using the helpdesk and I need to allow this.
In the trait, we have:
    /**
     * @var string
     *
     * @Assert\NotBlank()
     */
    protected $message;

The ideal is to add a configuration option to allow or not this field to be empty, but, I can't search for this now.
Have you an idea ? (I hope I miss something simple :) )

If you need to customise the traits, the easiest way would to implement the interface directly.
Hackzilla\Bundle\TicketBundle\Model\TicketMessageInterface
Then you can manually copy and paste the contents of the trait, and make changes.

I am sorry, but I have difficulties to picture what you say, I understand the principle, but I am not seeing how to use is in my case

in the doc

Use the TicketBundle xml as a basis and copy it into your bundle.
The link is dead

Whoops.
https://github.com/hackzilla/TicketBundle/tree/develop/Resources/config/doctrine/model

I think I miss something ...
Class "myapp\Entity\TicketMessageWithAttachmentFromMail" is not a valid entity or mapped super class.
Btw a question, is it logical to have $message assert notNull in the trait, but null=true in the doctrine xml definition, and required%false in the form type ?

probably not logical.
but at least nothing appears to be breaking.

Yes :) it is working, my point is perhaps it is better to not assert notNull in the entity, and let users override this with custom entities, or custom tpl (if the validation of the form is enough)
At first, my goal was to add a configuration variable to allow empty messages or not, and not send notification if the message is empty, but with the assert, I can't find a good way to do it

My hope was that developers would roll their own entities.
I'm trying to remove doctrine and symfony as a dependancy, at least for the core.
Then people can decide to use between doctrine, and mongo.  or fosuser and something else.

you're right

develop branch has v4, which is almost done.
Needs a lot more documentation.
Checkout the develop branch of  Ticket Demo App, as I have that working.

I'm sorry, I don't understand what you say :)
To do this without touching the core, I have override the class in a child bundle, entity and doctrine xml files

In v4, I am completely removing entities.
I don't want to have to deal with them.
If people want extra columns, or to use UUID instead of integer, for the IDs
That said, I have some example entities for people to start with.
https://github.com/hackzilla/TicketBundle/tree/develop/Resources/doc/entities
Pretty much, everything, should be overridable.  (except for pagination).

Currently in develop branch


Add Timestamps to oci.log

Hello,
I have used this script successfully in the past but by now it appears that there are absolutely no domains left. I have been running the script for months now with no luck. This means that I have long stretches of time without checking the logs, and on occasion I have noticed that for one reason or another it stopped working. I think it would be quite helpful to include a timestamp by default so that we can check the log and quickly be able to tell when a job was run. It would be as simple as changing line 90 in index.php to echo date('d/m/y h:i:s'), " $message\n";

For me it was on line 98 " echo "$message\n"; "
It worked perfect, thank you 👍

Works great, thanks

Worked, thanks


Check for duplicates in History collection needs to take alias into account

A user reported that the following in a History.rc file:
                           'T2M'      , 'SURFACE' ,  'T2MMIN'  ,  'MIN' ,
                           'T2M'      , 'SURFACE' ,  'T2MMAX'  ,  'MAX' ,

was causing History to crash with an error like so:

It turns out the logic I added to prevent duplication in the collection needs to allow for specifying duplicate short_name+gridcomp combos if the alias is different as there are valid reasons to do this.

Nice catch! I think the GEOS_IT has this in its history.


[2.0] Add readonly support in storage providers

🚀 🚀 Pull Request
Checklist:

[x]  My code follows the style guidelines of this project and the Contributing document
[x]  I have commented my code, particularly in hard-to-understand areas
[x]  I have kept the coverage-rate up
[x]  I have performed a self-review of my own code and resolved any problems
[x]  I have checked to ensure there aren't any other open Pull Requests for the same change
[x]  I have described and made corresponding changes to the relevant documentation
[x]  New and existing unit tests pass locally with my changes

Changes
Enforce mode='r' at the storage-provider level. Implemented top-down using StorageProvider base class, and extensively tested.

I think a better way to set modes would be to pass them to the storage providers in their constructors instead of enabling read mode later.

I think a better way to set modes would be to pass them to the storage providers in their constructors instead of enabling read mode later.

@AbhinavTuli that works when the provider is initialized, but not when it's passed directly. I think the way it's done currently is best for now.


[Doc] Incorrect process given for handling the bookmarked login scenario

Is your suggestion related to a missing or misleading document? Please describe.
In the Handle the browser back button and bookmarked login page document, it was instructed to configure registry values to handle the said scenario. However, the handling of this scenario is changed with [1], hence, instead of the registry values, the Access URL should be configured.
Describe the improvement
Configuring an Access URL should be instructed to handle the said scenario.
[1] https://github.com/wso2/carbon-identity-framework/pull/3274

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Support cmaps with only CID characters, when building the ToUnicode-map (issue 9367)

In this particular case the CMap-data that we create contains only numbers, but no strings, which causes PartialEvaluator.readToUnicode to create a ToUnicode-map with only empty strings.
Please note: This is yet another case where I don't know if it's necessarily the best and most correct solution, but it does fix the referenced issue.
Fixes #9367

/botio test

/botio-linux browsertest

/botio browsertest

/botio-linux preview

Looks good to me; thank you!
/botio makeref


Reference to (original) URL where the CSR file was used in a (first) JSlink connection

While testing I have created multiple CSR files (in the default /Style Library/) on multiple sites.
I now do not know in which sites I used which CSRfiles.
Suggested feature: When the Cisar file is created add a comment section displaying the URL(s) where the file was JSlinked
eg:
/*
Created on:
JSLinks:
https://365csi.sharepoint.com/sites/VM/Lists/Tasks/AllItems.aspx
https://365csi.sharepoint.com/sites/Demo/Lists/Tasks/MyItems.aspx
/JSLinks
*/

What you suggest will track only cases when a file was JSLink'ed via Cisar, which can be really confusing if there're some other guys in the team who don't use Cisar...

If Cisar sees a WebPart is allready linked it:
A. Would be nice to notify the developer
B. Could be added to the (comments) list
It should be easy with Cisar to delete any existing links; the Microsoft way is way too much clicks.
Again, not for me.. I have a Bookmarklet which resets JSlink values. (but with Cisar it could be easier done)

Lets not waist time on not-really-urgent issues.... closing this

Lets focus on important issues.. closing this


feat(simulation): update simulation models (breaking change)

Summary
Testing Process
Checklist

[x] Add a reference to related issues in the PR description.
[x] Add unit tests if applicable.

@shahnami can you sort the breaking tests, please?

@tirumerla looks like this package was introduced in another PR (the one adding EAS example I think), any idea why it's complaining here?


fix(controller): Fix argo retry with PVCs. Fixes #4275

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] My organization is added to USERS.md.
[x] I've signed the CLA.
[x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.

@alexec Rebased onto master and addressed all comments.


Move attributes to device model and remove integration attribute

Just a bit of cleanup 😄

Moves hardware attribute to device_info.
Removes integration attribute as the integration is specified in device_info
Change MANUFACTURER to human-readable instead as this is the name shown in the UI and should not be google_home but Google Home.

Tested and works locally


Documentation: BoxMesh UV scaling for vertex shader

Added a comment that translates the UV scaling from the standard shader properties to how that is done in a vertex shader. New text:
"This is equivalent to adding [code]UV *= vec2(3.0,2.0)[/code] in a vertex shader."

The stable name is CubeMesh.  Clicking "latest" from that page doesn't redirect to BoxMesh.  The page CubeMesh should similarly be updated: https://docs.godotengine.org/en/stable/classes/class_cubemesh.html

Thanks and congrats on the first merged PR!
But please do take note that you resolved a review suggestion without applying it. Don't hesitate to ask questions on your next PR if you need assistance.

@YuriSizov  Thank you for the support.
Where's the best place to ask for help on a PR?


Colab Notebooks

What does this PR do?

Adds official Lightning notebooks to github and opens up opportunity for community notebook contributions. 🍻
~NOTE - These are all linking to my personal fork right now, we will want to switch the links to PytorchLightning org before merging.~
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

for pip install in notebooks use future 0.9 not RC :]

@justusschock I guess that there is a format that is more friendly to review, and from which the notebook is generated, this gives 10x more lines then the notebook has...

lets check other way of to have review friendly format...

Yeah @Borda great point... this is something I was thinking too.
What do you think about me or @edenafek leaving our emails there? Then...

Users post their notebooks in their own repos/send us a colab notebook
They send in request to get added to our contributor notebooks via email.
If approved, we link to their colab notebooks in a 'contributor notebooks' table (We don't link to GitHub since it could disappear - colab we could get snapshot)

Kaggle notebooks allowed?

@nateraw Actually I feel it hard to link against snapshots, since we can't maintain them and we can't make sure they run all the time. So I'd rather only link notebooks. We actually control ourselves

@nateraw I think that they can open a PR with any kind of notebook and we can adjust in the PR process, just take their notebook and in very next commit convert it t the expected format...

@Borda the only issue with converting it from python file is that we always have to run It when we build docs to have the state on docs. But I agree, that it's hard to review otherwise

If you click on the dropdown and select "view file", you can see the rendered output, not sure if that helps as it does not show changes, but at least you can read the main content :)

@awaelchli yes, but if you want to review it, that's really hard :)

If you click on the dropdown and select "view file", you can see the rendered output, not sure if that helps as it does not show changes, but at least you can read the main content :)

yes, that is the difficult part for review, that in the nice view it does not show the diff :(

there are tools for this, but usually they're not that good. On the other hand, we should not have to change them that often, once we have them in CI, right? So probably it's okay, to make these changes manually and to also check them manually.

Can we use this https://sphinx-gallery.github.io/stable/index.html like https://github.com/pytorch/tutorials is using?
It allows us to write in python files with some structure, but the generated output formats are .rst for viewing on the website, .pynb and .py which you can download and run them.

Moving to #3591