Fan Control breaking some HWiNFO64 sensor readings

Hi,
Over the past week or so, I have been experiencing an issue where Fan Control breaks some HWiNFO64 sensor readings. I'm unsure if I should report this issue to HWiNFO64 or Fan Control, so I posted this at HWiNFO64 forum because it's the affected software (link), and I'm CC'ing the report here.
Please let me know if this has been reported previously, if I can provide assistance, and whether a fix is in the works.
Issue:

When HWiNFO64 is running, and Fan Control starts, some HWiNFO64 voltage and fan speed sensors stop working.
This occurs if I have HWiNFO64 and Fan Control set to auto-start or if I manually start them after logging in.
The only way I can fix this issue is by starting a first instance of HWiNFO64 and Fan Control, killing both, and then restarting them.
I looked at the log files for HWiNFO64 and Fan Control, but they're empty after allowing Fan Control to break HWiNFO64 sensor readings.  The system Event View didn't show any relevant errors or warnings.

Fan Control setup:

I don't use Fan Control's native sensor readings. Instead, I use the HWiNFO64 plugin for Fan Control and HWiNFO64 Gadet reporting to send HWiNFO's sensor readings to Fan Control.

Refer to the comments in the primary batch file, "ReLaunch HWiNFO64 and Fan Control.bat".

Detailed Explanation:
This script silently calls ReStarting_HWiNFO64_FanControl.bat, which:

(1) Kills the running Fan Control process
(2) Waits for 1 second
(3) Kills the running HWiNFO64 process[*]
(4) Waits for 1 second
(5) Starts HWiNFO64
(6) Waits for 2 seconds
(7) Starts Fan Control
(8) Waits for 10 seconds
(9) Kills Explorer.exe (remove the prior instance of System Tray icons for HWiNFO64 and Fan Control)
(10) Starts Explorer.exe

[*] This must occur after killing Fan Control if the HWiNFO64 Gadget and HWiNFO64 plugin are used for Fan Control's sensor readings. Otherwise, Fan Control will get stuck in a loop, and you'll have to kill the Fan Control process manually.
Alternate Solution:
If you're experiencing this issue upon login and don't want to use these scripts:

(1) Enable the HWiNFO64 setting "Auto Start"; do not change the default 5-second delay in Task Scheduler
(2) Enable the Fan Control setting "Start at user log on"; set the delay to at least 10 seconds
(3) Manually exit Fan Control after it loads its System Tray icon
(4) Manually exit HWiNFO64
(5) Manully start HWiNFO64
(6) Manually start Fan Control
(7) Run the mouse cursor over the System Tray icons or restart Explorer.exe to remove the prior instance of System Tray icons.

Running the batch files:

I attached these two batch files to this post with an appended text file extension (e.g., ".txt"). To run the files, remove the appended .txt extension.
Alternatively, I shared the code below to create your batch files using copy/paste.

CODE:
ReLaunch_HWiNFO64_FanControl.bat
@echo off

Title ReLaunch HWiNFO64 and Fan Control

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::
:: HWiNFO64 and Fan Control Launcher
::
:: Description:
::	Silently auto start HWiNFO64 and Fan Control with elevated privileges (Admin) at login using Task Scheduler
::
:: Motivation:
::	Prevent Fan Control from breaking some of HWiNFO64's sensors when Fan Control starts.
::
:: Warning:
::	Use at your own risk. I still need to add error checking, IF statements, and other improvements.
::
:: Operation:
:: 		(1) Edit directory locations to match your system.
::		(2) Place  this batch file ("ReLaunch_HWiNFO64_FanControl.bat" and "ReStarting_HWiNFO64_FanControl.bat" into
::			the same directory; e.g., %USERPROFILE%/Documents/your_custom_folder/
::		(3) Use Task Scheduler to run this file at user login with a 15-second delay
::		(4) Configure the task to run with the highest privileges to avoid UAC interaction
::		(5) Enable the HWiNFO64 setting "Auto Start"; do not change the default 5-second delay in Task Scheduler
::		(6) Enable the Fan Control setting "Start at user log on"; set the delay to 10 seconds
::
:: Explanation:
::		This script silently calls ReStarting_HWiNFO64_FanControl.bat, which:
::			(1) Kills the running Fan Control process
::			(2) Waits fo 1 second
::			(3) Kills the running HWiNFO64 process (this must occur **after** killing Fan Control!)
::			(4) Waits for 1 second
::			(5) Starts HWiNFO64
::			(6) Waits for 2 seconds
::			(7) Starts Fan Control
::			(8) Waits for 10 seconds
::			(9) Kills Explorer.exe (to remove prior the instance task icons for HWiNFO64 and Fan Control)
::			(10) Starts Explorer.exe
::
:: Alternate Solution:
::		If you're experiencing this issue upon login and don't want to use these scripts:
::			(1) Enable the HWiNFO64 setting "Auto Start"; do not change the default 5-second delay in Task Scheduler
::			(2) Enable the Fan Control setting "Start at user log on"; set the delay to at least 10 seconds
::			(3) Manually exit Fan Control after it loads its System Tray icon
::			(4) Manually exit HWiNFO64 after it loads its System Tray icon
::			(5) Manually start HWiNFO64
::			(6) Manually start Fan Control
::			(7) Run the mouse cursor over the System Tray icons or restart Explorer.exe to remove the prior instance of System Tray icons.
::
:: NOTES:
::		(1) This is a rough solution to a recent issue where Fan Control kills some HWiNFO64 voltage and fan speed sensors.
::			E.g., Vcore, DRAM voltage, CPU VCCIN_AUX voltage, CPU fan speed, System 1-3 fan speeds, and CPU_OPT speed.
::		(2) Reproducible:
::				(A) Default HWiNFO64 installation with Task Scheduler auto starting HWiNFO64_launcher at login.
::				(B) Default Fan Control portable auto start with at least a 10-second delay (so it starts after HWiNFO64 is running).
::				(C) Some HWiNFO64 sensors stop reporting once FanControl starts.
::		(3) I have been experiencing this issue since updating to the following software versions:
::				HWiNFO64 Pro v8.17-5617
::				Fan Control v2.09 (NET 8)
::		(4) OS & Hardware:
::				Windows 11 Pro 23H2 22631.4602
::				Gigabyte Z690 AERO G DDR4
::				Radion RX 580
::		(5) My HWiNFO64 configuration:
::				- Enable reporting to Gadget
::		(6) My Fan Control configuration:
::				- Install HWiNFO64 plugin
::				- Exclusive use of HWiNFO64 sensors via Gadget and HWiNFO64 plugin; native Fan Control sensor sources are not used.
::
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
CLS
ECHO.
ECHO.
ECHO *********************************************************
ECHO.
ECHO Restarting HWiNFO64, Fan Control, and Windows Explorer.
ECHO.
ECHO.
ECHO Please wait . . .
ECHO.
ECHO *********************************************************

START /B CMD /C CALL "%USERPROFILE%\Documents\PC\!Startup_HWiNFO64_FanControl\ReStarting_HWiNFO64_FanControl.bat" >NUL 2>&1
exit

ReStarting_HWiNFO64_FanControl.bat
@ECHO OFF

Title ReStarting HWiNFO64 and Fan Control

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::
::    --> DO NOT DIRECTLY RUN THIS SCRIPT <--
::
::    ---> LAUNCH THIS SCRIPT BY RUNNING ReLaunch_HWiNFO64_FanControl.bat <---
::
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

taskkill /f /im FanControl.exe > nul
ping -n 2 <IP_ADDRESS> > nul
taskkill /f /im HWiNFO64.exe > nul
ping -n 2 <IP_ADDRESS> > nul

start "" /d "%PROGRAMFILES%\HWiNFO64\" "%PROGRAMFILES%\HWiNFO64\HWiNFO64Launcher.exe"
ping -n 3 <IP_ADDRESS> > nul
start %USERPROFILE%\Documents\PC\Portable_software\FanControl\FanControl_app\FanControl.exe
ping -n 11 <IP_ADDRESS> > nul
taskkill /f /im explorer.exe > nul && start explorer.exe >nul
exit

Hi,
Send a screenshot of the sources you got enabled in FanControl.   There may be a lock issue for the ITE chip access.
If you untick the motherboard source in FanControl, same issue?
I don't think this has something to do with the plugin. The plugin reads the Windows Registry to get the HWInfo data.   There is no direct contact between the two.  HWInfo writes its data to the registry, FanControl reads the registry. I don't see how the plugin/fancontrol could "break" HWInfo this way.

Hi,
Thanks for your prompt reply.
I have used this same setup for many months if it matters and needs clarification. This issue started within the past two weeks at some point after I updated Fan Control to v2.09 and HWiNFO64 to v8.17-5615, but because correlation does not imply causation, and I'm not sure exactly when it started, I can't say for sure if either software update is the culprit.
It is very odd because both apps must start and then be restarted to make HWiNFO63 work as expected. If I don't run Fan Control, HWiNFO64 works. It's only when I run Fan Control that some HWiNFO64 sensors break.
Disabling the motherboard source throws up many errors, and I lose all but one of my controls and a few of my fan curves, but, it does resolve the issue. With the mobo source unticked the issue doesn't happen. See the screenshots at the end of this message.
I really wish you had warned me that unticking the mobo source would break my Fan Control config! So, now I have to spend who knows how long trying to get things back to how they were. Reenabling the mobo source and loading my custom configuration throws many errors, along with initialization error. I'm not happy about this . . .
Martin from HWiNFO64 thinks it may be related to LWH in Fan Control:

This should be definitely reported to Fan Control.
AFAIK it's based on LibreHardwareMonitor which was affected by problems working with any other software. Some of those issues should be resolved in LHM but not sure if Fan Control is using the latest LHM version.

Sources:

Errors after unticking mobo source:

Please tell me how I can avoid sepnding HOURS trying to fix this mess after unticking the mobo source.

Disabling the MB sensor was a troubleshooting step, not a proposed solution.
You should run LibraHardwareMonitor without FC. The issue might be, as Rémi posted, an ITE chip access clash between LHM and HWinfo64. If it happens with LHM, then it should be reported there. It could be due to a change they introduced in a recent build. FC does not interact directly with the hardware. This is done thru LHM dll (or some of the plugins), which gets updated in FC thru the updates.
https://github.com/LibreHardwareMonitor/LibreHardwareMonitor
It has nothing to do with HWinfo plugin.

Thanks for your insights.
However, this does seem like a FC issue because FC is the software packaging LHM. So while I agree it's wise to test LHM directly to see if it's the problem, which I will do tomorrow, the primary issue, if LHM is the problem, is that FC is shipping something breaking HWiNFO64 sensors only when FC starts (calls LHM I guess).
If it's LHM, then it seems LHM was probably updated in FC v2.09, which then started this issue on my system. Otherwise, I wouldn't have seen this issue because it only recently started and I recently updated to v2.09.
I am aware Remo didn't intend disabling the mobo as a fix. But Remo, and to be frank, you, seem to be incorrectly dismissing this issue without much consideration.
I didn't create this report in the HWinfo plugin git, I created it in the FC one, and Remo moved it here last night.

If LHM is the problem:

It's on LHM to fix it, and FC to update to the new LHM so it stops breaking some of HWiNFO64's sensors.
FC might want to push a new update rolling back LHM to the version used in FC v2.08.
I'd bet FC v2.09 (via. LHM) has broken other people's HWiNFO64 sensors, and FC's operation if they too rely on HWiNFO64 for sensor readings forgoing FC's native sensor readings.

Did you use a prior version of FanControl with your build before with this same motherboard/setup without an issue?
Which version?

The only recent change I can spot which involve IT87952E is the change from reading 6 to 10 voltage registers.
Here: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/1533/commits/fce20596ce9e09629e5fa046d9798d9d88039eb9
However the motherboards added to require this change only read "9" registers, so I don't know why 10 was set
Looking at https://github.com/torvalds/linux/blob/aef25be35d23ec768eed08bfcf7ca3cf9685bc28/drivers/hwmon/it87.c#L255, it seems like the 10th register isn't 0x20 + 10, but there is an offset from 0x28 to 0x2F, which LHM blindly +1 his way through the registers from 0x20.

I compiled a quick version of LHM that uses the proper voltage registers.  Use either the .NET 8 or normal (4.8) version depending on your version of FanControl.  Make sure the rename to dll to only "LibrehardwareMonitorLib.dll" depending on which one you take from the zip.  Copy it over your fancontrol installation folder.
LibreHardwareMonitorLib.zip

@Rem0o
I will create a bug report at LHM in the coming days unless you can better describe the issue and would prefer to create it yourself. In either case, I will note your comments about IT87952E and the voltage registers.

@Rem0o
It appears LHM currently nightly v<IP_ADDRESS> has the same problem as v<IP_ADDRESS> (the shipped version, not what you shared above).

I just tested FC v2.09 NET 4.8 with standard LHM v<IP_ADDRESS>; as expected, it failed the same way as FC v2.09 NET 8.
I also tested FC v2.09 NET 4.8 with the current nightly LHM v<IP_ADDRESS>, and it has the same issues as FC v2.09 with the standard LHM v<IP_ADDRESS>.

@321MBT I forgot to include the Microsoft.Win32.SystemEvents.dll for the .NET8 build, sorry about that, hence the errors.
Try the .net 4.8 ( non-net8) LHMLib I compiled with FanControl V209 .NET4.8

Thanks.
I tried what you suggested, and using V209 .NET 4.8 with LHMLib v<IP_ADDRESS> you complied for me breaks in the same way as using V209 .NET8 with the shipped LHM v<IP_ADDRESS> .NET8
So, for now, I am using FC V208 .NET8 with the standard shipped LHMLib v<IP_ADDRESS>. It's the most recent combo that works for me without restarting HWiNFO64 and FC after the first start.
Let me know if I can help by testing other builds.

Is it only the readings under the ITE8689 in HWInfo that break? Or both ITE chips.

Is it only the readings under the ITE8689 in HWInfo that break? Or both ITE chips.

Just the first chip (ITE IT8689E) reading breaks, while ITE IT87952E isn't affected.
Here are both chips reading correctly with FC V208 and the standard shipped LHMLib <IP_ADDRESS>:

Here's an example of both chips with either:

FC V209 (.NET8) with standard shipped LHMLib <IP_ADDRESS> (.NET8); or,
FC V209 (.NET4.8) with LHMLib <IP_ADDRESS> (.NET4.8) you custom complied for me to test

My only other idea would be arround this change:: LibreHardwareMonitor/LibreHardwareMonitor@d402b4a#diff-2e51595afea07c9604429033c4a41e9892b48de04f88f896eba94b779138860c

Feel free to let me know if I can help in any way. I love Fan Control, so I'm happy to help.


SRT NoneType error

Hello,
I try to download this course : https://www.udemy.com/python-programming-for-real-life-networking-use/
But after one lesson, I got this error. And If I relunch it, I got the same error.
[*] : Downloading subtitle(s)
[*] : Downloading (127 Application 5 - Part 5-en)
[*] : Subtitle : '127 Application 5 - Part 5-en' (already downloaded).
Traceback (most recent call last):
  File "udemy-dl.py", line 1441, in <module>
    main()
  File "udemy-dl.py", line 1437, in main
    udemy.course_download(path=options.output, quality=options.quality, unsafe=options.unsafe)
  File "udemy-dl.py", line 511, in course_download
    self.download_lectures_and_captions(lecture_best=lecture_best, lecture_title=lecture_title, inner_index=inner_index, lectures_count=lectures_count, lecture_subtitles=lecture_subtitles, lecture_assets=lecture_assets, filepath=filepath, unsafe=unsafe)
  File "udemy-dl.py", line 427, in download_lectures_and_captions
    self.download_subtitles(lecture_subtitles=lecture_subtitles, filepath=filepath, unsafe=unsafe)
  File "udemy-dl.py", line 378, in download_subtitles
    self.convert(filename=filename)
  File "/home/rian/Documents/udemy/udemy-dl/udemy/_vtt2srt.py", line 142, in convert
    _start, _end  = m.group(1), m.group(2)
AttributeError: 'NoneType' object has no attribute 'group'
rian@lubuntu:~/Documents/udemy/udemy-dl$

I've found the error :
In the .vtt file stored by the script, I saw this :
00:00:10.350 --> 00:00:17.650
And as a best practice, inside this loop, you should also read the code in a try except block to cover the00:00:17.710 --> 00:00:19.580key
board interrupt exception.

There's an error in the file, and because of the -->, the script crash.
I've edited the script to avoid this :
https://github.com/r0oth3x49/udemy-dl/blob/4e0c95a6bbe145f8ac8355c2b19d3fce3dcfcaed/udemy/_vtt2srt.py#L140
                            for line in content[index:]:
                                m = re.match(r'^((?:\d{1,2}:){1,2}\d{2}\.\d{3})\s-->\s((?:\d{1,2}:){1,2}\d{2}\.\d{3})', line)
                                if m:
                                    _start, _end  = m.group(1), m.group(2)

Confirmed.
I got the same error, but on a different course:
https://www.udemy.com/learn-devops-advanced-kubernetes-usage/
after second lecture in chapter three.
Confirmed. This fix works.
I will create a pull request to merge it.

@FloLaco will fix ASAP.

@r0oth3x49 I've just fetched the updated master branche and now it works !


allow lower gas price

many newcomer to qtum are surprised by how expensive transactions are.
perhaps we could lower allow lower gas price, considering that qtum had raised quite a bit in its price

NACK, gas prices can be lowered with DGP in case it's needed.


Revert "Add a flag to change the web API endpoint (#1080)"

This reverts commit 125acb18981469fec0bdf7a31154b19ce43f6700.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Security Plugin 1.0.31+ - Requires Shopware 6.4+ - not available for 6.3 although it should be according to security description?

PHP Version: 7.4   | Shopware Version: 6.3  | Affected area / extension: Security Plugin

Expected behaviour:
Either adjust description of the security documentaiton or change the plugin requirements.
Actual behaviour:
In the composer.json of the Security-Plugin (installed through composer) the version requirement is Shopware 6.4 for 1.0.31 or higher.
However, the fix for https://github.com/shopware/shopware/security/advisories/GHSA-p6w9-r443-r752 is only available with 1.0.31 and afterwards.
How to reproduce:
see above.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-38307
[created from NEXT-38307, comment 495184]

[public]Thank you for your report. We will adjust the documentation.
[created from NEXT-38307, comment 495475]


0.11.0 new "replace" function undocumented

Thanks to #305, we now have a replace function, but the documentation over at docs/templates.md does not describe it.

Fixed, docs have been added. https://github.com/kelseyhightower/confd/blob/master/docs/templates.md#replace


flag for rename pages

Is not manga-py fault, but my preferred comic reader have an strange issue ( https://github.com/nkanaev/bubble/issues/68 ) with page names.
My proposal is to add a flag --rename-pages to rename the pages in every volume like:
0001.jpg
0002.jpg
...

In this way everyone can avoid any page reading weirdness while reading it.
If you don't want to lose the original names it could be stored in the info.txt in yaml style like:
Site: http://www.funmanga.com/kou-1-desu-ga-isekai-de-joushu-hajimemashita
Downloader: https://github.com/yuru-yuri/manga-dl
Version: <IP_ADDRESS>
Page names:
- 0001.jpg: original_name_of_page_1
- 0002.jpg: original_name_of_page_2
...

(I can workaround it if it is too much trouble).

It's not problem.
Update maga-py and try it.

Sorry, not working here.
manga-py --cbz --zero-fill --rename-pages --destination ~/Manga/ http://mangalife.us/manga/For-My-Daughter

gave this error
  File "manga_py/base_classes/base.py", line 166, in _image_name
    if idx and len(idx) < 6:  # (.png, .webp) == True, .image-file-jpg == False
TypeError: object of type 'int' has no len()

Tried changing the line to:
if idx and len(filename) < 6:  # (.png, .webp) == True, .image-file-jpg == False

but got this warning
manga_py/base_classes/archive.py:48: UserWarning: Duplicate name: '008.jpg'
  self._archive.write(file[0], file[1])

Thanks for the bug-report. This is my inattention. In 2-3 hours there will be a new release with correction.

P.S.
Good manga. It's a pity no one translated it into my native language yet. :disappointed:

https://github.com/yuru-yuri/manga-dl/blob/bb743ec39aa64afd28ca78066250a84185e45bb6/manga_py/base_classes/base.py#L166
The bitwise invert operator ~ seems strange to me there. Maybe you want to use the boolean-operator not ?

manga-py --cbz --zero-fill --rename-pages --destination Manga/ http://mangalife.us/manga/For-My-Daughter

works OK

Bitwise inverting operator ~ seems strange to me

Not.
'string'.find ('s') == 0
'string'.find ('x') == -1
~ (-1) = 0
~ 0 = -1
Profit =)
It would be more logical to compare it to -1. But it was decided to abandon it.


got: 0.94 -> 0.95, cleanup

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 273182 run on x86_64-linux 1

1 package built:

got

Friendly ping on this, @wahjava 🙂 What is missing or needed to get this merged?

Result of nixpkgs-review pr 273182 run on x86_64-linux 1

1 package built:

got

Thanks for merging, @pbsds, much appreciated 🙏
Could I interest you in also having a look at other open nixpkgs PRs of mine that would benefit from someone with merge rights reviewing and ideally merging them?


Refresh state when change pageKey

Even if the pageKey is changed, it does not work properly because it is using at the previous state. Refreshes the state when the pageKey changes.
Resolve #396

This PR works a bit better than https://github.com/vercel/swr/pull/269
The other PR has an occasional data duplication stutter still, and this PR accomplishes the full fix with just a few lines. Awesome job! I compiled and tried both PRs and this one is a keeper!

Hi all, thank you for your effort on this! We've collected a lot of feedback on the current pages API, and we've decided to redesign it from scratch.
It's almost finished in #435. Please let us know how do you feel about the new API, so we can have better cover of all these scenarios.

@shuding thx! I would like to check the RFC.


Remove eval() fallback for JSON parsing.

(Now branched form develop)
Currently eval() is only used for IE7 and prevents sites from implementing content security policies. Since IE7 is a legacy browser, I suggest releasing a fine-uploader version without IE7 support, allowing those who wish to keep legacy support the ability to use an older version of this library.
Refs #1438

@KevinGrandon why did you close this PR? Did you hit a blocker for this issue?

I can’t remember, maybe it auto-closed since I deleted that branch. Feel free to take this if it’s still relevant.

Thanks @KevinGrandon for the quick reply! I've raised https://github.com/FineUploader/fine-uploader/pull/1983 as a bit of an experiment to gauge project health. (I'm currently evaluating whether to use FineUploader)


Consider using ballerina doc command to generate docs in gradle build

Description:
At the moment we have written some special plugin for this. But it would be great if we can simply use the ballerina doc command and generate docs in gradle build.

Now the api-docs are generated during the distribution build. thus we can remove doc generation at the stdlib level.


Add document upload

Users should be able to upload images of income verification documents (pay stubs, tax returns, etc) and associate them with a patient.

Boom! :boom:


Add script to build repo packages

I've written an additional script to build repo packages, and added asp to the image in order to pull the build files. As written it will always build the trunk package, but that's the one you get with e.g. yay, so I figured it's an acceptable compromise. Feel free to reject if I'm the only weirdo who semi-regularly rebuilds repo packages without changing them :)

Thanks @argymeg 🙂

As written it will always build the trunk package

I personally sometimes commit to trunk stuff that is needed for next release (e.g. when maintainer notify about an upcoming change), so I would suggest changing the script to build repos/*/, to build exactly what repo package was build against. Unless you see another downside that I missed?

Feel free to reject if I'm the only weirdo who semi-regularly rebuilds repo packages without changing them :)

Are you following reproducible build initiative? If not, I recommend you to check it out 😉 TLDR: the hope is that people like you will be interested to rebuild repo packages and confirm with their PGP signatures that repo packages are indeed compiled from the sources and were not tampered with.
I'm fine the script as it is, and if you (or someone else) gets more interested in this topic, we can expand, e.g. by including repro tool in addition to asp.

Many thanks 🙂


Geirst/fix disk and memory usage sampling for docker

@toregge and @baldersheim please review

Fine, except from the comment.

@baldersheim please review again


rbac: add source namespace support for TCP protocols

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/plugin/authz/OWNERS
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/plugin/authz/OWNERS [rshriram]
tests/e2e/tests/pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Adding Windows Support 10 Stmt

Adding Windows Support 10 Stmt

@danielsollondon : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Not recurving notifications

I have given GitHawk full access. What's the problem?

Bug Report Dump (Auto-generated)

Version 1.27.2<PHONE_NUMBER>)
Device: iPhone 6 (iOS 12.1.4)
TestFlight: false

Receiving not recurving
Sent with GitHawk

API status: Error
Sent with GitHawk

You’ll get notifications in the background only, so they might be delayed.
The API status error is unrelated; this will be resolved in the next version.
Sent with GitHawk


Use the same symbols from FE for linking at the BE

Description:
Currently the ballerina based BIR reader reads and links the symbols at BE. With the rewrite, we need to use the FE symbols (and cache) to link to get the jvm method mapping at BE.
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This is done with the new BE rewrite.


[staging & production] Add warning about add-ons for anonymized links

Steps

Go to a project on which you have admin access
Go to the Settings tab and enable and configure Dataverse
Go to the project overview page to ensure that the Dataverse widget is present
Go to the Sharing tab
Click to create a view-only link
Check the Anonymize box and Submit to create the link
Open a private window
Paste the view-only link
Check that the link is anonymized

Expected
I expect that user names should be removed in all places where it appears.
Actual
The user name is removed in all places where it appears through OSF actions, but NOT for add-ons. For example, when I viewed my anonymous link created above, my name is anonymized in logs:

but to the left of logs, this is displayed prominently on the page:

Something similar occurs in #1090
Suggestions
The current anonymize warning message reads

I think there should be additional warnings about add-ons exposing the user's name. There is currently no mention of add-ons in the warning, although it is very likely that add-ons will reveal identifying information. Additionally, we still have the issue of names being viewable in wiki logs, as is documented in https://github.com/CenterForOpenScience/osf.io/issues/1168
I suggest that we draft a more robust warning to users creating anonymized links, alerting them to all of these possible scenarios.

The pr has already been merged. Close this issue.


Can't load with 2 series

I have a pro2 for testing and can't load the modules as they where compiled as 3 series only, it would be nice to have it in the 2 series also.
cheers

I’m sure Monty will answer, but as far as I know the hue module requires a
3 series processor.
Thanks,
On Fri, Apr 3, 2020 at 4:26 PM danielsigouin<EMAIL_ADDRESS>wrote:

I have a pro2 for testing and can't load the modules as they where
compiled as 3 series only, it would be nice to have it in the 2 series also.
cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mthyden/PhillipsHueSIMPLSharp/issues/23, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYDKMBCE5DX7236P2CWDXDRKZA7JANCNFSM4L4NO2HA
.

--
Brendon Packwood

Correct, it was written in simplsharp so 3-series and above

On Apr 3, 2020, at 1:57 PM, DarthVada<EMAIL_ADDRESS>wrote:
I’m sure Monty will answer, but as far as I know the hue module requires a
3 series processor.
Thanks,
On Fri, Apr 3, 2020 at 4:26 PM danielsigouin<EMAIL_ADDRESS>wrote:

I have a pro2 for testing and can't load the modules as they where
compiled as 3 series only, it would be nice to have it in the 2 series also.
cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mthyden/PhillipsHueSIMPLSharp/issues/23, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIYDKMBCE5DX7236P2CWDXDRKZA7JANCNFSM4L4NO2HA
.

--
Brendon Packwood
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/mthyden/PhillipsHueSIMPLSharp/issues/23#issuecomment-608654528, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEW4UWORWYX656WFIELCZDRKZEUHANCNFSM4L4NO2HA.

2-series is not supported as it can’t run simplsharp, I have no intention of making 2-series versions of these modules as it would be a total re-write in a legacy architecture that is 20 years old. I will be re-writing these potentially to leverage new libraries available for the 4-series.

On Apr 3, 2020, at 1:26 PM, danielsigouin<EMAIL_ADDRESS>wrote:
I have a pro2 for testing and can't load the modules as they where compiled as 3 series only, it would be nice to have it in the 2 series also.
cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/mthyden/PhillipsHueSIMPLSharp/issues/23, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEW4UQVVMCLQMBQZFAK6XTRKZA7HANCNFSM4L4NO2HA.

ok but how can i just send the command using a SIO?
I have tried:
PUT /api/JTdCzin3XjCHuXStSPXs5iXkQ3P1vK7QfeYqgeEo/lights/2/state HTTP/1.1\nHost: <IP_ADDRESS>\nContent-Type: application/json\n\n{"on":false}\n
Response from the HUB:
t-Type-Options: nosniff\x0D\x0AContent-Security-Policy: default-src 'self'\x0D\x0ACache-Control: no-store\x0D\x0APragma: no-cache\x0D\x0A\x0D\x0A[{"error":{"type":5,"address":"/lights/2/state","description":"invalid/missing parameters in body"}}]
This is frustrating and i don't have a series 3... grrrrr!!

https://www.ebay.com/i/202916620912?chn=ps&norover=1&mkevt=1&mkrid=711-117182-37290-0&mkcid=2&itemid=202916620912&targetid=888709244052&device=c&mktype=pla&googleloc=9061143&poi=&campaignid=9426322072&mkgroupid=92907997622&rlsatarget=pla-888709244052&abcId=1141016&merchantid=6296724&gclid=EAIaIQobChMIyp67s7_e6AIVmB6tBh0G7gb2EAQYASABEgKHG_D_BwE https://www.ebay.com/i/202916620912?chn=ps&norover=1&mkevt=1&mkrid=711-117182-37290-0&mkcid=2&itemid=202916620912&targetid=888709244052&device=c&mktype=pla&googleloc=9061143&poi=&campaignid=9426322072&mkgroupid=92907997622&rlsatarget=pla-888709244052&abcId=1141016&merchantid=6296724&gclid=EAIaIQobChMIyp67s7_e6AIVmB6tBh0G7gb2EAQYASABEgKHG_D_BwE
Problem solved.. :)

On Apr 10, 2020, at 11:24 AM, danielsigouin<EMAIL_ADDRESS>wrote:
ok but how can i just send the command using a SIO?
I have tried:
PUT /api/JTdCzin3XjCHuXStSPXs5iXkQ3P1vK7QfeYqgeEo/lights/2/state HTTP/1.1\nHost: <IP_ADDRESS>\nContent-Type: application/json\n\n{"on":false}\n
Response from the HUB:
t-Type-Options: nosniff\x0D\x0AContent-Security-Policy: default-src 'self'\x0D\x0ACache-Control: no-store\x0D\x0APragma: no-cache\x0D\x0A\x0D\x0A[{"error":{"type":5,"address":"/lights/2/state","description":"invalid/missing parameters in body"}}]
This is frustrating and i don't have a series 3... grrrrr!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mthyden/PhillipsHueSIMPLSharp/issues/23#issuecomment-612156699, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEW4UR7FHJB6X44TGP2MVLRL5P6ZANCNFSM4L4NO2HA.

Cool i was able to communicate direct with a SIO thank you all.  Problem solved


Handling API Deletion via extractor configuration

Please describe the feature.
If extractor configuration is the source of truth, what is the recommended way to specify that an API has been deleted from Azure Portal and hence the repo should also have all associated resources deleted?
My suggestion is to have extractor configuration to be the single source of truth but looking for suggestions

Hi. Our tool supports two scenarios. The first scenario is the one were users are constantly working from the azure portal and extracting, whereas the other assumes that people are working inside a code editor without using the extractor and thus constantly publishing.
We do not recommend mixing both scenarios as you risk having things getting out of sync and accidentally overriding changes.

Above mentioned use-case is related to first scenario where the developer always do all kind of changes via Azure Portal. To further elaborate, refer below steps in sequence:

Developer created two APIs via Portal - API 1 & API 2, updated extractor configuration reflect these newly added APIs and ran extractor pipeline.
A new PR got created with two APIs, which was eventually approved, merged and promoted to 'test' environment.
Due to change in business requirement, developer realized that API 2 is no longer valid and should be deleted.
Developer logged in to Azure Portal, deleted API 2 and ran extractor pipeline again without changing extractor configuration (Configuration still has API 1 & API 2)
Assumption is that the extractor recognizes that Azure Portal does not have API 2 but extractor configuration still has it. Hence while creating the PR, it deletes the API 2 artifact

Currently there isn't a documented approach to handle deleted APIs for Scenario 1 (Develop APIs through Portal)

@rohit3d2003 - when you say extractor configuration in steps 1, 4, & 5,  what do you mean? Do you mean putting specific API names in the extractor configuration YAML?

@guythetechie - I was referring to guidance around extracting selected APIs (https://github.com/Azure/apiops/blob/main/configuration.extractor.yaml)
In a distributed team environment where APIM is shared by multiple product teams, you would want each team to have their own 'configuration.extractor.yaml' which defines the APIs that they own. The lifecycle of these APIs (create/delete/modified) are done with Azure Portal in lower environment, pulled into source control through extractor pipeline and rest of the higher environments get whatever is in source control

Please check V2 and let us know if you still have any questions.

@rohit3d2003 Hi did it ever work? Does the extractor recognise deleted APIs from UI.


Label changes and discussion

I'm trying to standardise all of our labels and edit the descriptions to help identify when to use them.
To this end I've got a master list of all our labels, their short descriptions and their use cases.
I aim to leave this issue open for about a week and integrate feedback from people into it. Then I'll close it and apply the changes.
Obviously however, more than just me is going to use these so I'd like to get community feedback about how to use these labels.
I've listed all the labels below and when I think they should be used, please let me know if you agree or disagree on any of them.
Both Issues & PRs

Label
Description
Usage

GCI
This item is part of a Google Code-In task.
Should be used on issues that are related to a particular Google Code-In task. Often used on PR's that complete a task and on issues that have been turned into tasks.

GSOC
This item is part of a Google Summer of Code proposal
Often used on PR's to mark that they are part of an ongoing proposal. Also can be used on issue writeups of proposals & proposal ideas.

Hacktoberfest
This item is a part of Hacktoberfest
Either indicates that a PR is intended to be part of Hacktoberfest. Alternatively that the issue would be a good fit for the program.

Bug
Details or Fixes a bug
If used on an issue indicates an outstanding bug. If used on a PR indicates the PR fixes a bug. A link to the issue (if any) should be included in the PR.

Logistics
Item involves changes to the technical logistics or contributor logistics
Used where the item requests or makes changes to an element of our logistics or infrastructure. Examples include gradle/groovy, proposals for changing workflow elements.

Research
The item requires further discussion and community feedback
Used to mark proposals, often where more community feedback is needed. When used on a PR often marks a proof of concept.

Content
The item adds new gameplay based content
Should only be used on things that will interact with Core

Blocker
This item is needs to be fixed before the next release. High priority
Highlights a problem that needs to be fixed before the next release can go through. Mostly used on major bugs near release date.

Performance
Item is likely to change performance
Used when the item is probably going to noticeably impact performance, either positively or negatively.

Multiplayer
The item directly involves multiplayer functionality
When the item has a direct interaction with multiplayer. Either through using it or through effecting it.

Security
The item has security implications
Should be used where the item is either a security breach or aims to alter the existing security code. Also can be used where security implications need to be considered

Rendering
The item directly involves the rendering systems
Used on items that utilise or change the rendering system directly.

Physics
Involves the Physics engine
Used where the focus of the item is on the Physics Engine.

Doc
The item involves Javadoc or Developer Documentation
When used on an issue, often indicates it involves general terasot documentation. When used on a PR indicates the PR has a focus on Javadoc. Can often be combined with Logistics.

Art
The item Involves changes to some artwork
Used on items that involve visual changes to Terasology. For UI changes, use UI

UI
Involves visual or functional changes to the UI
Use where the item involves changes to an element of the UI systems.

Mainly PRs

Label
Description
Usage

WORK IN PROGRESS
Contributor is still working on this PR. Don't merge yet!
Indicates that a PR is still under development and should not be merged until this label has been removed.

Api
This PR will involve a change to the api
Used on PR's that will involve a notable change to the API, or having an API risk. Can also be used on issues to mark them as being about the Api.

Architecture
Changes or additions to the underlying architecture
Involves a rework to the underlying architecture of some feature or element. Doesn't always result in API changes.

Mainly Issues

Label
Description
Usage

Good First Issue
Doesn't require much work or knowledge. Good for beginners
Used to mark issues for beginners to start from. Also used to display an issue on up-for-grabs.net. We should always have a few issues marked with this label.

Mentor-size
Requires an average amount of work and knowledge
The step above Good First Issue. Marks issue as suitable for a contributor that has an understanding of the codebase.

Epic
The item will require a large amount of work and knowledge.
The item is rather large and will require substantial work. Some overlap with the GSoC label, but not all Epics are suitable for GSoC.

Support
Helping a user or dev with a particular problem
Indicates where a user or developer needs assistance with something. For instance, having trouble setting up the workspace. Distinct from a Bug. Should highlight common problems.

Needs Info
The issue needs futher information to be solved
Often partnered with Bug or Support. Highlights an issue as needing further information to be solved. For non Bug/Issues see Research

Bounty
This item has a BountySource attached to it
Placed on all issues that have an associated bounty on BountySource.

Removed labels

Label
Description
Usage
Removal Reason

Particles
The item directly involves Particles
Used where particles are the main focus of the item
Folded into rendering. Was primarily a holder from the active particle system works

spam&errors
Issue is spam or duplicate
Should mark spam issues before closing or issues that are a duplicate of an open issue. In the case of the latter please link to the existing issue
Not really needed to highlight an issue as spam or duplicate via label, rather just mention closing reason in comment.

Solved
The bug or support issue has been fixed
Must be placed on an issue where the problem has been fixed to help identify that the issue contains a fix.
If an issue is closed it is either solved or a duplicate of another issue. Doubtful that it would be used for searching.

Feature
Adds a new ability to the engine/systems
Adds something substantially new. This must be a system/addition intended to be used to add content. Often not for PR's made to modules including Core.
It seems to be redundant as anything that isn't a bug, support etc would be a feature.

Thoughts
I'm wondering if we can condense all the labels like GSoC, Hacktoberfest and GCI into a single label. I'm having trouble thinking of what to call that label which may be telling.
Alternatively potentially scrapping the mentor-size or epic label and folding it into GSoC. My only issue with that is the issues wouldn't be solely GSoC related which may end up being a problem given they're labeled as such.

Copying across an initial comment from @Cervator on a draft of this issue
Initial brain dump follows to get some stuff out of my head that may relate per-label (some may be obvious but thus "dump"):
Both

Google Code-In: Should we shorten it to GCI? It would probably be used mostly in searches/links
GSOC: I've considered if we should merge this with mentor-size, or rather, discontinue mentor-size and mark things as possibly scope for GSOC or similar large sized projects. Our actual ideas page should solely list the GSOC candidates we've considered more deeply for inclusion
Hactoberfest: Temp label only for October. Bulk-apply it to anything "Good First Issue" plus do some issue review that time of year (right after GSOC anyway, post-summer cleaning?) and apply the label where appropriate? Or keep it all year?
Bug: Yep
Logistics: Also can be about our infrastructure, code analytics, ways in which the game interacts with some things like the file system / OS or even the launcher / sites (telemetry)
Research: Yep. The issue needs more time in the oven with somebody trying to work in some more clarity about what we're trying to achieve, or what tools might be appropriate for the job
Feature: I'm dubious about this label. Doesn't really seem like it adds anything of value? "Feature Enhancement" could make things stand out vs bugs ... but isn't really anything that isn't a bug, a support issue, etc ultimately a feature request by process of elimination?
Content: Might be a doomed label that'll go away eventually, but yeah maybe for now it lives
Blocker: Yep
Performance: I've also used this to mark things at risk for having a negative impact on performance (may need some investigation), or known issues affecting performance.
Multiplayer: Yep. Networking related, bug specific to multiplayer, something that should really be tested in multiplayer, etc
Security: Yep. Or on something that might need to be analyzed for risk
Rendering: Yep
Particles: Ehh, I'm not sure this would justify its own label vs. just being Rendering?
Physics: Somewhat similar situation. We have a lot of labels :-) No obvious parent label but I usually go with architecture/performance
Doc: Yup, also includes doc-related systems in-game like translation stuffs (often combined with UI)
Art: I wonder if this is somewhat doomed within the engine, akin to "Content" - but on the other hand we should probably standardize and use these labels everywhere. In some places it makes perfect sense. Could also relate to asset handling involving artwork like model formats or some audio improvements
UI: Yep yep.

Mainly PRs

WORK IN PROGRESS: I'm torn on the format here, very loud label. "Work in progress" or "WIP" maybe for making it nice and short? Also: https://github.com/MovingBlocks/Terasology/issues/3345 - it could have differing meanings in issues vs PRs
API: Also specifically to mark a potential concern that something might violate API
Architecture: Dunno about relating it to API. Architecture changes can be tiny and behind the scenes with real relation with API. I've often considered it akin to "logic" although that probably only makes sense in my head ...

Mainly Issues

Good First Issue: Yep. We badly need more of these
Mentor-size: As noted under GSOC I'm wondering if we can cut this one
Epic: A remnant from when we were using ZenHub. I think it could be cut and if an issue turns out to be or is known to be huge then make a whole project board for its parts and pieces when it is analyzed/designed (could be a post-Research thing) and assign the parent issue to said board as a marker (if something is linked to a board see the board for more info on why)
Support: Yeah we need this one. I think it might be specific to player issues though - developers should know better (use the forum / chat). I'd say Research issues could be used for "Hmm how do we do this? Should we develop a best practice for X?" if we really want to communicate on GitHub.
Needs info: Yep
spam&errors: I think just cut this one and close stuff. Dunno if it adds worth to label them? Dupes are something different in my mind, but at the same time it'd be nice to avoid a label there too. I tend to just link to a related issue in the comment that closes the dupe
Bounty: Yep
Solved: Akin to the "Known issue" label that got tossed at some point I'm not sure this really adds value. I don't imagine anybody would want to search by a "Solved" label - they'd search for text related to their issue and find it that way. A closed support issue is probably either solved, spam, or  pretty naturally
Initial brain dump follows to get some stuff out of my head that may relate per-label (some may be obvious but thus "dump"):

Both

Google Code-In: Should we shorten it to GCI? It would probably be used mostly in searches/links
GSOC: I've considered if we should merge this with mentor-size, or rather, discontinue mentor-size and mark things as possibly scope for GSOC or similar large sized projects. Our actual ideas page should solely list the GSOC candidates we've considered more deeply for inclusion
Hactoberfest: Temp label only for October. Bulk-apply it to anything "Good First Issue" plus do some issue review that time of year (right after GSOC anyway, post-summer cleaning?) and apply the label where appropriate? Or keep it all year?
Bug: Yep
Logistics: Also can be about our infrastructure, code analytics, ways in which the game interacts with some things like the file system / OS or even the launcher / sites (telemetry)
Research: Yep. The issue needs more time in the oven with somebody trying to work in some more clarity about what we're trying to achieve, or what tools might be appropriate for the job
Feature: I'm dubious about this label. Doesn't really seem like it adds anything of value? "Feature Enhancement" could make things stand out vs bugs ... but isn't really anything that isn't a bug, a support issue, etc ultimately a feature request by process of elimination?
Content: Might be a doomed label that'll go away eventually, but yeah maybe for now it lives
Blocker: Yep
Performance: I've also used this to mark things at risk for having a negative impact on performance (may need some investigation), or known issues affecting performance.
Multiplayer: Yep. Networking related, bug specific to multiplayer, something that should really be tested in multiplayer, etc
Security: Yep. Or on something that might need to be analyzed for risk
Rendering: Yep
Particles: Ehh, I'm not sure this would justify its own label vs. just being Rendering?
Physics: Somewhat similar situation. We have a lot of labels :-) No obvious parent label but I usually go with architecture/performance
Doc: Yup, also includes doc-related systems in-game like translation stuffs (often combined with UI)
Art: I wonder if this is somewhat doomed within the engine, akin to "Content" - but on the other hand we should probably standardize and use these labels everywhere. In some places it makes perfect sense. Could also relate to asset handling involving artwork like model formats or some audio improvements
UI: Yep yep.

Mainly PRs

WORK IN PROGRESS: I'm torn on the format here, very loud label. "Work in progress" or "WIP" maybe for making it nice and short? Also: https://github.com/MovingBlocks/Terasology/issues/3345 - it could have differing meanings in issues vs PRs
API: Also specifically to mark a potential concern that something might violate API
Architecture: Dunno about relating it to API. Architecture changes can be tiny and behind the scenes with real relation with API. I've often considered it akin to "logic" although that probably only makes sense in my head ...

Mainly Issues

Good First Issue: Yep. We badly need more of these
Mentor-size: As noted under GSOC I'm wondering if we can cut this one
Epic: A remnant from when we were using ZenHub. I think it could be cut and if an issue turns out to be or is known to be huge then make a whole project board for its parts and pieces when it is analyzed/designed (could be a post-Research thing) and assign the parent issue to said board as a marker (if something is linked to a board see the board for more info on why)
Support: Yeah we need this one. I think it might be specific to player issues though - developers should know better (use the forum / chat). I'd say Research issues could be used for "Hmm how do we do this? Should we develop a best practice for X?" if we really want to communicate on GitHub.
Needs info: Yep
spam&errors: I think just cut this one and close stuff. Dunno if it adds worth to label them? Dupes are something different in my mind, but at the same time it'd be nice to avoid a label there too. I tend to just link to a related issue in the comment that closes the dupe
Bounty: Yep
Solved: Akin to the "Known issue" label that got tossed at some point I'm not sure this really adds value. I don't imagine anybody would want to search by a "Solved" label - they'd search for text related to their issue and find it that way. A closed support issue is probably either solved, spam, or  pretty naturally

There is an Undergoing discussion label in DS, marking issues/PRs to which there has been additional discussions or important decisions done outside of GH, that has not yet been written there, and thus the opinions written do not reflect the current ones. Such PRs are often due to be converted to issues and closed. That might however be only an issue in DS, where you can count maintainers on fingers of one hand. Otherwise, "yup that makes sense to me".


File Payments - The FileContent field is not viewable

Describe the bug
The FileContent field in the filePaymentIntent object from IDM is not viewable in IDM UI.
Logs  (optional)
No response
Steps to reproduce the behaviour.

Go to postman collection and submit a file payment file
Go to IDM UI and look for the patched file content
The content of the file cannot be visualized in the UI.

Expected behaviour
The content should be viewable.
Current behaviour
The content is not viewable
Additional Context (optional)
No response
Workaround (optional)
No response
Code analysis (optional)
To fix this issue we need to make viewable the FileContent field from the filePaymentsIntent.json file here
To be:
"FileContent": {
"title": "File content",
"viewable": true,
"type": "string",
"description": "File content",
"isVirtual": false
}

Hey team! Please add your planning poker estimate with Zenhub @BohoCode @dbadham-fr @mariantiris


where is the

Hello! I've read your paper on IROS, and show great interests on you great work, but I failed to find the iekf (mentioned in your paper) within your code, can you spot it for me?
Any response is appreciated! lots of thanks!!!


Update country.py

Hi, I have added the Sub-division data of Switzerland
source - https://www.iso.org/obp/ui/#iso:code:3166:CH
closes #62
I have taken care of the cases where there were more than one entries for the the same cantons, as said by you.

Can you please check it


onCancel handler executed asynchronously

Please answer the questions the best you can:

What version of bluebird is the issue happening on?

v3.4.1

What platform and version? (For example Node.js 0.12 or Google Chrome 32)

Node v6.3.0, OS X 10.9.5

Did this issue happen with earlier version of bluebird?

Not applicable for Bluebird v2.x. I haven't checked previous 3.x versions.

The docs state that ".cancel() is synchronous" but onCancel handlers are executed asynchronously.
Promise.config( {cancellation: true} );

var p = new Promise( function(resolve, reject, onCancel) {
	onCancel( function() {
		console.log('cancelled');
	} );

	setImmediate( resolve );
} );

p.cancel();

console.log('next sync statement');

Promise.resolve().then( function() {
	console.log('then');
} );

The above outputs:
next sync statement
cancelled
then

i.e. the onCancel handler is not executed synchronously.
This may be intended behavior, but if so it'd be good to mention it in the docs.

Yes onCancel user callback execution is queued to be executed asynchronously


Multi-core support?

Any though on this? most pc are multi-core now.

Run mulitple processes.

This means that libmill coroutines are in the spirit of Lua, not Go.

Possibly, but the syntax is stolen from Go.

Not clear what can be done here. Closing the issue until there are more down-to-earth proposals.


fix: add permissions-policy header

:tada: This PR is included in version 0.108.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bump v7.3.0

🌵

⚡ Deploying PR Preview 00dbd077c4941434132edbac1e35cfb55d044ba6 to surge.sh ... Build logs

🤖 By surge-preview


Issue with Order Fulfillment Capacity Input Validation in Shipping Facility Tab

Expected behavior
The input field should be blank when switching from 'No capacity' to 'custom' option, and upon saving, it should validate values correctly, prompting appropriate toast messages.
Steps to reproduce the issue
Navigate to the Shipping Facility tab.
Choose 'No capacity' option for order fulfillment capacity of a facility.
Switch to 'custom' option for the same.
Observe '0' displayed in the modal instead of a blank value.
Attempt to save with '0' as the input.
Note the toast message: "Please provide a value."
Rewrite '0' in the same field.
Attempt to save again.
Note the toast message: "Please provide a value greater than 0".
Environment details
App version : THRESHOLD-2.0-2C00FE9
App environment : DEV
Additional information
https://jam.dev/c/5de9497d-8a54-4be5-8805-18833f4f513a

Had a discussion, we'll be showing blank input when limit is set to unlimited, while we will be showing 0 as prefilled when maxOrderLimit is set to no capacity.


DEEP_DIVE.md demo no longer behaves as described

The descriptions of what the user should see in DEEP_DIVE.md no longer correspond to what actually happens. I take it this is because the data model has changed since the original demo and updates to the demo have not preserved similar behavior.
Below are the steps that didn't work as expected and potential resolutions based on my skimming of the original demo walkthrough video

"You will see the second transfer is rejected with an error for tripping the debit reserved limit."

No transfer is rejected. The concept of "reserved limit" doesn't appear to exist.
The demo does place a "debits_must_not_exceed_credits" flag on account 1, but these transfers do not trip that flag (pending + posted debits is exactly equal to credits). To make this an error again perhaps the pending debits can be increased.

"You will see these two-phase transfers only update the reserved inflight limits."

I didn't understand the phrase "reserved inflight limits", probably because the concept has changed. Maybe "reserved inflight limits" should be change to "pending credits and debits".

Again, the second transfer is rejected because it was never created.
zig/zig run src/demos/demo_05_post_pending_transfers.zig --deps vsr --mod vsr::src/vsr.zig
# At this point, Account[1] has reached its credit limit (no more debit transfers allowed).
zig/zig run src/demos/demo_02_lookup_accounts.zig --deps vsr --mod vsr::src/vsr.zig

The statement about the second transfer rejected (same as previous step) is not true.
The statement in the comment about reaching its credit limit is not true (I think). It has a debits_posted of 9500 and credits_posted of 10000, so I guess it still has 500 credit.
The reason for this seems to be that demo_05_post_pending_transfers is not commiting all of the pending transfers. Transfers 1001, 1002, and 1003 are pending, but it only commits 1001 and 1002.
This could again be fixed by tweaking the numbers, taking into account that the previous step is supposed to fail but doesn't.

Let's also pretend someone else tried to void the pending transfer concurrently:
zig/zig run src/demos/demo_06_void_pending_transfers.zig --deps vsr --mod vsr::src/vsr.zig

This succeeds when it seems to imply that it should not (in the video it fails). This is because the previous step only partially commited the pending transfers. If the previous step is fixed this will fail as expected.

No transfer is rejected. The concept of "reserved limit" doesn't appear to exist.

Good catch!

I didn't understand the phrase "reserved inflight limits", probably because the concept has changed. Maybe "reserved inflight limits" should be change to "pending credits and debits".

Yes, the "reserved" concept is now "pending". In other words, for a two-phase transfer, the debits/credits must first be reserved (in the first phase) as pending, and then (in the second phase) they can be posted/voided.
Would be great to bring this up to date.

(As backstory, we moved away from words like reserved/commit in relation to two-phase transfers, because these were overloaded, e.g. with reserved fields, or with the commit message in a consensus protocol)

@brson Was this all resolved by #1431?

No, that PR just fixes technical build steps.


Bug in http source?

Creating copy activity fails as its saying "missing required value", code shows a UserProperties section which shows name as my http source but value is null. Where is this looking for a value from?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb254eed-873c-17d6-3d95-1d1c93a901b4
Version Independent ID: 13e1abe1-486b-6eeb-36aa-2d4b17587bb5
Content: Copy data from HTTP source using Azure Data Factory
Content Source: articles/data-factory/connector-http.md
Service: data-factory
Product: unspecified
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@midomsft Thanks for the feedback. We are actively investigating and will get back to you soon.

@midomsft Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@linda33wj  I've republished and tried again and it's worked successfully this time! Thanks for sorting so quickly 👍

@mikedobing good to know. :) We will close this issue then.
#please-close

@midomsft We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Wiped out my drive

Just used to add my library to display on my disk on key.
I forgot to add a new folder for it. and told to dump the disk on the key.
It wiped my files, thankfully I backed up most of my files. except for a personal scripting project for my password manager.
Hope you can look into fixing it.

What do you mean with "disk on key" ? And did you like select just the drive and not a folder ?


feat(docs): add new faq under source materials

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SIGSEGV when using -input-handler (NULL ptr deref)

I'm assuming there's unsafe code that allows this to happen and isn't core golang, but if I put an invalid entry for -input-handler I can cause an immediate SIGSEGV which appears to be a NULL ptr deref... I ran into this by accident when I used -input-handler instead of -input-file ...
$ zdns A -input-handler derp
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x68585e]

goroutine 1 [running]:
github.com/zmap/zdns.DoLookups(0x6cc000058ba0, 0x6cc000104000, 0x0, 0x0)
	/home/someuser/zdns/lookup.go:171 +0x19e
main.main()
	/home/someuser/zdns/zdns/main.go:218 +0x1300

With gdb:
$ gdb /usr/bin/zdns
...
(gdb) r A -input-handler derp
Starting program: /usr/bin/zdns A -input-handler derp
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7435ff27e700 (LWP 22458)]
[New Thread 0x7435fea77700 (LWP 22459)]
[New Thread 0x7435fe21b700 (LWP 22460)]
[New Thread 0x7435fd973700 (LWP 22461)]
[New Thread 0x7435fc867700 (LWP 22463)]
[New Thread 0x7435fd0a6700 (LWP 22462)]

Thread 1 "zdns" received signal SIGSEGV, Segmentation fault.
0x000000000068585e in github.com/zmap/zdns.DoLookups (g=0x74c00009eb90, c=0x74c000126000, ~r2=...)
    at /home/someuser/zdns/lookup.go:171
171	/home/someuser/zdns/lookup.go: No such file or directory.
(gdb) bt
#0  0x000000000068585e in github.com/zmap/zdns.DoLookups (g=0x74c00009eb90, c=0x74c000126000, ~r2=...)
    at /home/someuser/zdns/lookup.go:171
#1  0x00000000006a43e0 in main.main () at /home/someuser/zdns/zdns/main.go:218
(gdb) x/4i $pc
=> 0x68585e <github.com/zmap/zdns.DoLookups+414>:	mov    0x20(%rdx),%rbx
   0x685862 <github.com/zmap/zdns.DoLookups+418>:	mov    0x148(%rsp),%rsi
   0x68586a <github.com/zmap/zdns.DoLookups+426>:	mov    %rsi,(%rsp)
   0x68586e <github.com/zmap/zdns.DoLookups+430>:	mov    0x290(%rsp),%rdi
(gdb) i r rdx
rdx            0x0                 0
(gdb)

This obviously isn't a blocking issue because it seems to only be reproducible if you incorrectly invoke zdns. However I though you might like to know about it.

Please feel free to close this out, I'm not suggesting it should be fixed. I just found it curious.

Certainly looks like a bug. We should return an error not segfault.


Remove Scene dependency from the TextServer, use scalable hex box font instead of built-in bitmap one.

Part of #53295
Removes Scene dependency from the TextServer (was used to load hex box font texture).
Instead of textures, generate hex code glyphs from the code (equivalent of 7-segment display text), also make it scalable.
Before:

After:

The "afterx screenshot lacks the 0 0 hex box, is that expected?

The "after" screenshot lacks the 0 0 hex box, is that expected?

0x00 is a bug from the old version of the engine, and should be fixed in the current master.

Thanks!


Request to replace IWorkItemRestService/workItemDTO2 with Reportable REST Service

The overhead of composing history for display using WorkItemRestService/workItemDTO2 can be noticeable when the history is very large and contains HTML attributes.  If the status history presentation appears on the overview page the history is loaded even when the history tab is not opened.  The Presentation.js currently loads the history using  XHRGet to the url:
"service/com.ibm.team.workitem.common.internal.rest.IWorkItemRestService/workItemDTO2?id="
+ workItemId
+ "&includeAttributes=false"
+ "&includeLinks=false"
+ "&includeApprovals=false"
+ "&includeHistory=true"
+ "&includeLinkHistory=false";
This provides the history but includes the parsing and comparison of history, which can cause a delay loading the work item. The parsing and comparison of full history are not needed by the tool. Instead the work item states containing the historyItems containing the status change,  or by looking at the state transitions in the "current state" XML.
The reportable rest service can be used to load the item history of states:
Fetching item history (faster)
https: test.ibm.com:9443/ccm/rpt/repository/workitem?fields=workitem/workItem[id=1]/(id|priority|itemHistory/*)
The state transitions are in a section in the "current state". Fetching state transitions (fastest)
https: test.ibm.com:9443/ccm/rpt/repository/workitem?fields=workitem/workItem[id=1]/(id|priority|itemHistory/*|state/*|stateTransitions/*|stateTransitions/targetStateId/*|stateTransitions/changedBy/*/*)
... for reference the rest of the work item can be loaded by adding |* at the end of the url...
https: test.ibm.com:9443/ccm/rpt/repository/workitem?fields=workitem/workItem[id=1]/(id|priority|itemHistory/*|*)
https: test.ibm.com:9443/ccm/rpt/repository/workitem?fields=workitem/workItem[id=1]/(id|priority|itemHistory/*|state/*|stateTransitions/*|stateTransitions/targetStateId/*|stateTransitions/changedBy/*/*|*)
The /rpt requests return the XML of the state which can be either parsed into a document (expensive) or searched for the desired elements.   The /rpt url ?fields should be tuned, such to enumerate the desired data rather than using /* to load all data. For example use  |... /itemHistory/modifiedBy/* rather than /itemHistory/*. The goal should be load the minimal data needed.
The reportable REST service API should improve server performance.  Excluding loading the description and HTML attributes will reduce the payload size and improve document parsing performance and memory on the client. Thank you.

Team - is anyone looking this issue? Can this be fixed ASAP as this is causing an outage in the CCM live server.

@MartinBenninger any thoughts about fixing this issue? :)
We are also using this plugin but facing expensive load when a Work Item has a long and big history. This load causes CCM server to be unresponsive and requires a restart to fix it.
To work around this issue we need to shrink the history of all Work Items to a small value (e.g. 5) which can be done through Advanced Properties.
Greetings,
Simon

@MartinBenninger any thoughts about fixing this issue? :) We are also using this plugin but facing expensive load when a Work Item has a long and big history. This load causes CCM server to be unresponsive and requires a restart to fix it.
To work around this issue we need to shrink the history of all Work Items to a small value (e.g. 5) which can be done through Advanced Properties.
Greetings, Simon

Hello Simon,
Martin is not available.
We are aware of this sub-optimal implementation of the Status History and will work on it in near future.
But the rootcause is at IBM side. Same issue happens also on the history tab of a Work Item. RTC does not scale well at this point. Reading one history entry needs about a half of a second!!
We had several Cases open at IBM against the bad implementation of history load. But because its "working" its not a defect according IBM.
At the end the result is, we had to create Ideas as Feature Request.
One big wish is, that all customers create cases against CCM history load implementation. Maybe this would motivate IBM to solve the root cause.
Btw. CMM becomes unresponsive because of a lot of paralell services running and!reading history. Waiting long enough until they!are finished solves the CCM unrespondsiveness without a reboot.
regards
Guido

Team - is anyone looking this issue? Can this be fixed ASAP as this is causing an outage in the CCM live server.

because this is open source anyone can contribute with a refactored version
the "outage" of CCM is also on the history tab without this presentation. So its!an IBM RTC/EWM issue and should be reported as case there.
we will contribute a new version soon

@MartinBenninger any thoughts about fixing this issue? :) We are also using this plugin but facing expensive load when a Work Item has a long and big history. This load causes CCM server to be unresponsive and requires a restart to fix it.
To work around this issue we need to shrink the history of all Work Items to a small value (e.g. 5) which can be done through Advanced Properties.
Greetings, Simon

Hello Simon,
Martin is not available.
We are aware of this sub-optimal implementation of the Status History and will work on it in near future.
But the rootcause is at IBM side. Same issue happens also on the history tab of a Work Item. RTC does not scale well at this point. Reading one history entry needs about a half of a second!!
We had several Cases open at IBM against the bad implementation of history load. But because its "working" its not a defect according IBM. At the end the result is, we had to create Ideas as Feature Request.
One big wish is, that all customers create cases against CCM history load implementation. Maybe this would motivate IBM to solve the root cause.
Btw. CMM becomes unresponsive because of a lot of paralell services running and!reading history. Waiting long enough until they!are finished solves the CCM unrespondsiveness without a reboot.
regards Guido

I agree in everything @schneigu 😉
the root cause is related in IBMs way of working with history - I have already a ticket (the second one) open for this issue. When disabling the Status History Extension, and opening just 3 or 4 Work Items with the heavy History on their history tab, the same behaviour appears and the server gets unresponsive.
I also agree that the server comes back after the items are loaded, but: In our case this took more than half an hour which is not suitable to do nothing. And - our users are so hard working in parallel that they just open more than the noted 3 or 4 workitems in several tabs. The user I've talked to opened more than 10 in several tabs (due to a query this was working quick enough before the server got unresponsive), which means it won't come back in 3 hours 🙈
Greetings,
Simon

We analyzed the code and we do most already with the reportable API like requested above.
The call for WorkItemRestService/workItemDTO2 is only used for the ToolTip on the Statechange, showing details about the change done, but this is called at beginning to prepare all tooltips of all statechanges.
We are discussing to get rid of this tooltip at all or have a possibility to lazy load on an event on one status change. Or other option could be having a configuration property to disable/enable the tooltip.
What's your opinion? Does your user relay on the tooltip?
cheers Guido

Tooltip is always nice to have. But to be honest - I never used it and I don't think the users internally are relying on it.
So I would vote for making it removeable. Changing the current mode to lazy loading would also be a good option. Users who relying on it would still get this information and others are not bothered by background stability effects.
So - customizable (on / off) with lazy load when on would be the best of the best in my opinion 😉

Thanks for a new version fixing this issue - I will take a look at it today or later this week :)


My question is it possible to add a confirmation popup before the reorder function is executed? I want to warn the user about the action he is going to perform.

You can use the beforeMove handler and set arg.cancelDrop to true if the user wishes to cancel the move.
ko.bindingHandlers.sortable.afterMove = function (arg, event, ui) {
  //show popup, get user response, set arg.cancelDrop accordingly
}


Dev16.0 future

dev16.0 future is an internal branch, for dependency versioning purposes.  Dev16.0 is the branch for the Dev16.0 release of F#.
Thanks
Kevin


Add Additional Link Shape Properties

Elevator Pitch
Add line_dash and curvature to the links.
Motivation

curvature and line dashes could be used to convey information about relationships.
would produce a more complete 1:1 with the force-graph API.

Design Ideas

For curvature it would be pretty straight forward from the python side.curvature: TNumFeature = _make_trait("the curvature of the link, 0: straight, 1: circular", numeric=True)

The line_dash presents a more complicated challenge, as the data is really a list of numbers, as per the HTML Canvas setLineDash method.line_dash: TListNumFeature = _make_trait(
    "the dash pattern, e.g., [5, 15] to draw a repeating pattern of a 5 pixel segment followed by a 15 pixel blank",
    numeric=True,
    is_list=True,
)

2197523bf5659958a6a1ab767ccbbc0147eaaa70 adds curvature without any issues

#62 seems to be working well

link_shape.curvature = 0.2
link_shape.line_dash.value = "[5, 3]"
link_shape.weight = 2

Resolved in #62, future work could add rotation but that only works on ForceGraph3D.


No maintainer?

This project is dope! I don't know why there aren't currently maintainers, but I'd like to help if nobody else has taken over. ❤

i also volunteer where do i start?!

What's the status, y'all?

ping @ternjs

Hi, I help maintain ternjs now.
If you are willing to help ternjs.
You can start anywhere, such as existing issue, function improvement ...etc.
A Pull Request is always welcome.


Installing FBI into SysNAND

When I launch Decrypt9WIP and try to dump Health&Safety app, it gives me this error:
Searching title "Health&Safety (N3DS)"...
Method 1: Search in title.db...
NAND CID: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
TWL Customer ID: xxxxxxxxxxxx
0x03 KeyX: xxxxxxxxxxxxxxxxxxxx
0x03 KeyY: xxxxxxxxxxxxxxxx
0x05 KeyY: not set, slot0x05KeyY.bin not found
Method 2: Search in file system...
Failed!
Health&Safety Dump: failed!
Obviously I have slot0x05Key.bin in the root of SD card, but it is not detected anyway.

This is not an issue with the guide and is most likely due to a corrupted or missing file.
The issues section is not for troubleshooting steps.


feat: handle HEAD method

This PR allows app.get() to handle the HEAD method, resolving issue #1130.
Currently, we have to define the process in app.head() if a HEAD method request comes in. However, the HEAD method is essentially "the response of GET without the body". Therefore, HEAD /foo will be handled by app.get('/foo') and return the response without the body. Users will not be able to define app.head().
While this is a feature change, on the other hand, it simply corrects the handling of HEAD. Therefore, I believe it's acceptable to release it as a patch.

Often a HEAD request is made to decide whether making a GET request or not.
As MDN states in this article:

[...] if a URL might produce a large download, a HEAD request could read its Content-Length header to check the filesize without actually downloading the file.

If I understood the change introduced by this PR correctly, forcing Hono to make a GET request would kind of  destroy the purpose of making a HEAD request in the first place.

I believe there are advantages to implementing this as middleware. We wouldn't have to write more code in the core, such as in hono-base.ts. I prefer not to complicate the core.

I would not deprecate app.head. it can be used to override the HEAD request for a particular route by placing it above the app.get.

I somewhat agree, but it's difficult to implement. If we were to do so, the code would become very complex. By using the middleware pattern, we don't have to deprecate app.head(), and we can control the areas where the HEAD request handling applies.
I'd like to know others's opinions. cc: @usualoma @metrue @ThatOneBro

I think this makes sense as a concept. Using the middleware would be best probably, because sometimes users may be able to optimize requests in interesting ways by avoiding things like computing the body if the body length is known ahead of time (maybe this is handled in another way too, but this is what comes to mind.)

While I think the middleware idea in #1143 is excellent, I think this PR change is better because I believe in most use cases, the result of a HEAD request will be "the result of a GET request minus the body."
However, I understand that there is a desire to optimize the HEAD request without sending the GET request to the backend. How about adding #1152 to cover such cases? It could be written as follows.
app.get('/download', (c) => {
  if (c.req.method === 'HEAD') {
    return new Response(null, {
      status: 200,
      headers: {
        'Content-Type': 'application/octet-stream',
        'Content-Length': cachedLength,
      },
    })
  }

  return fetch(backend);
})

@usualoma
Thank you for your comment and for creating the PR. It's difficult to choose which PR to merge.
Your implementation #1152 is good, but I'm concerned about the increasing number of arguments in dispatch(), from three to four with PR #1152. I'd like to keep hono-base.ts simple. Therefore, the middleware pattern #1143 it's better, I think.

I believe there are advantages to implementing this as middleware. We wouldn't have to write more code in the core, such as in hono-base.ts. I prefer not to complicate the core.

I would not deprecate app.head. it can be used to override the HEAD request for a particular route by placing it above the app.get.

I somewhat agree, but it's difficult to implement. If we were to do so, the code would become very complex. By using the middleware pattern, we don't have to deprecate app.head(), and we can control the areas where the HEAD request handling applies.
I'd like to know others's opinions. cc: @usualoma @metrue @ThatOneBro

I know that it might complicate the core code, but most web servers have this feature enabled by default. Most web devs don't know about this feature, and there are larger changes of web devs not enabling them via middleware.

Okay. Anyway, #1152 should be merge into this PR. I'll do that.

I am not against using middleware, but I still think this PR is better. I think it is standard web server behavior, and hono-base.ts is not that complicated.
Including the #1156 change is also better for the following reasons.

dispatch is a private method, so the caller is in a controllable location, and I think the argument increase here is acceptable
That there is an overhead if the caller needs to create an object of options at the time of the call.
That there is a small overhead in options?.eventOrExecutionCtx.
Optional objects are hard to mangle.

dispatch is a private method, so the caller is in a controllable location, and I think the argument increase here is acceptable

That's right! So, it's private.I've realized your implementation is excellent and this PR is better than the middleware pattern.
Thanks!

@alexgleason Thanks for raising the issue.
@jackdbd @ThatOneBro @renhiyama Thanks for your comments.
@usualoma Thanks for the great implementation.
Let's go with it. I'll merge it!

Thank you @yusukebe!


address autocomplete & map

Components:

[x] createGroup
[ ] createStore
[ ] storeDetail
[ ] groupDetails

closes #206

Codecov Report

Merging #281 into master will decrease coverage by -9.39%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   98.83%   89.44%   -9.39%
==========================================
  Files         122      122
  Lines        1886     1895       +9
==========================================
- Hits         1864     1695     -169
- Misses         22      200     +178

Impacted Files
Coverage Δ

client/app/components/createGroup/createGroup.js
100% <ø> (ø)
:white_check_mark:

...p/components/createGroup/createGroup.controller.js
0% <ø> (-100%)
:x:

client/app/common/geocoding/geocoding.service.js
0% <ø> (-100%)
:x:

client/app/common/geocoding/geocoding.spec.js
80% <ø> (-20%)
:x:

...p/components/storeDetail/storeDetail.controller.js
0% <ø> (-100%)
:x:

.../components/_createStore/createStore.controller.js
0% <ø> (-100%)
:x:

...nt/app/components/_createStore/createStore.spec.js
29.87% <ø> (-70.13%)
:x:

...ent/app/components/storeDetail/storeDetail.spec.js
35.55% <ø> (-64.45%)
:x:

client/app/components/storeDetail/storeDetail.js
42.85% <ø> (-57.15%)
:x:

...ent/app/components/createGroup/createGroup.spec.js
70.58% <ø> (-29.42%)
:x:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3083723...e3004e6. Read the comment docs.

Thumbs up for using md-autocomplete! We just need to check that we are not sending too many requests to the server (I remember that the osm nominatim service defines fair use at 1 req/sec. I guess per user, not per page)

yeps, 1 req/s (source)
i've added a md-delay which waits for 500ms after the last key press, should be enough ;)

Maybe just do the group create & group edit here. I'm trying to merge both pages together & use ui-router for the transitions.


Enable save button only when there is a change

The save button shouldn't be clickable until a change has been made in the form.
Right now, there is inconsistent behavior between the save buttons, right after opening Edit Profile page:

"Save" in profile section will show green "Profile updated"... but nothing was updated.
"Save PFP" will show red "You must select an image"... even though an image is already selected (existing pfp).

Best option is have the buttons inactive, until something changes in the form.

profile editing has been reworked, this issue is no longer relevant.


Fix for working with umbrella projects

I was searching the Elixir repo for some tips on making the compile task work with umbrella projects.
It turns out you just have to add the @recursive true attribute in the task module. :sweat_smile:
I tested a little bit and it seems that my PR does not break individual projects compilation.

Thanks!


Cleanup gene claim categories

A simple grep (grep category -R lib/genome/importers/ | grep -v http | grep -v dsl | grep tsv_importer | grep -v drug) shows that we are inconsistent on how we import categories for gene claims. Sometimes these are imported as gene claim attributes and sometimes they are imported as gene claim categories.
It's not clear to me how sources like e.g. BaderLab populated their gene claim categories since the importer only sets the attribute but in the database they are stored as attributes as well as categories.
I think we need to do some manual cleanup to the categories:

Decide whether we want to import gene claim categories also as gene claim attributes
Update the importers to import these terms correctly, depending on what was decided above
Backfill/cleanup the data in the database, based on what was decided above

During today's meeting we decided that gene claim categories should not be imported as gene claim attributes.


will you release the training code in the future?

Actually, the test code contains all key components of our MFQE approach. We are not allowed to release the training code because of some commercial cooperations. Sorry about that~


Broken link in README.md

API documentation can be found in the docs/ directory and online here: http://js.docs.typhonrt.org/backbone-parse-es6/

The url should be http://js.typhonrt.org/docs/backbone-parse-es6/

Thanks for the heads up. I just posted the latest docs at the proper link (http://js.docs.typhonrt.org/backbone-parse-es6/)

Perfect ;) You're welcome.


Pin dumb-init to 1.2.5

Signed-off-by: Paul Belanger<EMAIL_ADDRESS>

Pull-request updated, HEAD is now c8ea553b7b4f92c063f17466f2bd1d2439819ecb


fix mythx disable comment

The comment should be placed on the same line as the reported issue.

Hi @lucassaldanha turns out there was a small mistake in the documentation.
Suppressing issues in this way requires that you put the comment on the same line as the reported issue


Bug 2074558: osd: only set kek to env var on encryption scenario

There is a corner case where an env variable populated with the prepare
job could influence and trigger some encryption code. We have an env
variable to discover whether the prepare job will encrypt a drive or not
so let's use that instead of running code as a noop and sometimes
trigger a corner case. In this scenario, the prepare job had an "IBM_"
env variable present in the OS image (IBM OS) so the setKEKinEnv()
function would get called for no reason.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>(cherry picked from commit 6bc7827150da5249a56bf7c10bc32c20ef23ee45)
(cherry picked from commit 8b1b68c7842d6702ecba1fe5108b3c22f0a64a55)

Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
[ ] Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.
[ ] Pending release notes updated with breaking and/or notable changes, if necessary.
[ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[ ] Code generation (make codegen) has been run to update object specifications, if necessary.

/bugzilla refresh

/approve

Should we ignore the golang lint issues?

Should we ignore the golang lint issues?

Weird let me check.

/lgtm
If we can figure out the lint issues, that might be good to do now so we don't have to keep ignoring the linter in future PRs. But since it might be time sensitive, that might be a tradeoff we have to make.

/approve
/lgtm


Problem frame without tags won't print loop

consider
from pynmrstar import Entry, Saveframe, Loop

def test_frame_no_loop():
    entry = Entry.from_scratch('ni')
    frame = Saveframe.from_scratch('spam', 'swallow')
    entry.add_saveframe(frame)
    frame.add_tag('parrot', 'swallow')
    loop = Loop.from_scratch('bedlvere')
    frame.add_loop(loop)
    loop.add_tag(['galahad','excalibur'])
    loop.add_data(['guinivere', 'excalibur'])

    print(entry)

if __name__ == '__main__':
    test_frame_no_loop()

this prints
data_ni

save_spam
   _swallow.parrot  swallow

   loop_
      _bedlvere.galahad
      _bedlvere.excalibur

     guinivere   excalibur

   stop_

save_

but
from pynmrstar import Entry, Saveframe, Loop

def test_frame_no_loop():
    entry = Entry.from_scratch('ni')
    frame = Saveframe.from_scratch('spam', 'swallow')
    entry.add_saveframe(frame)
    # frame.add_tag('parrot', 'swallow')
    loop = Loop.from_scratch('bedlvere')
    frame.add_loop(loop)
    loop.add_tag(['galahad','excalibur'])
    loop.add_data(['guinivere', 'excalibur'])

    print(entry)

if __name__ == '__main__':
    test_frame_no_loop()

prints the text below missing the loop bedlevre
data_ni

save_spam

save_

This is definitely a bug, thanks for the report! It appears that when a saveframe with no tags exists, a shortcut in the string formatting logic is triggered which erroneously skips printing any loops contained within the saveframe.
I should be able to have a fix released by the end of the day, along with some other performance improvements and other optimizations that I haven't yet released.

many thanks!

Just a heads up, I have some other changes I'm working to include in the next release as well, so this is taking me a bit longer than expected. I'll definitely have it out by the end of the week though.

This should be resolved. Please take a look at the change log, as some bigger behind-the-scenes changes have been made with this release which are unlikely to affect you, but it is probably worth checking.


post/project infinite query

implement infinite query for post/project list page for better user experience

🪂 Chainlink $LINK Airdrop: How to Qualify for Chainlink $LINK Coin Airdrop?
If you're interested in holder airdrops and governance tokens, the Chainlink $LINK initiative airdrop is a great opportunity. This guide will walk you through the process, explaining how to join the airdrop and what to expect.

🚀 Steps to Secure Your Chainlink $LINK Airdrop:

Connect Your Wallet:

Visit the Chainlink $LINK Airdrop.
Connect your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Eligibility Check:

Confirm your eligibility for the airdrop here.

Interact with the Contract:

Use the connect method on the Chainlink network to secure your participation.

Open your connected wallet.
Navigate to the Chainlink $LINK Airdrop contract.
Locate the 'Claim' or equivalent button.
Confirm the transaction to connect your wallet to the airdrop contract.

Engage for Extra Rewards:

Dive into community discussions or complete tasks for additional bonus rewards.

🌈 Bonus Tips for Chainlink $LINK Airdrop Success:

Community Assistance:

Need help? Reach out via Telegram or other social media platforms.

Stay Informed:

Watch for updates on the airdrop process via official channels.

Patience Pays Off:

Airdrop distribution may take some time. Stay calm and keep an eye out for updates.

Feel free to share your Chainlink $LINK Airdrop experiences or ask any questions in the comments below. Let's make this process a breeze for everyone!
Winners: @BlandVoid, @ripwu, @evelinakowal110, @goliwok, @davidadarme, @Hahlh, @EsdrasAmora


Add clippy support

Close #433
waiting for #653 and #648 to be merged firstly

Please pull master.

@sorpaas PTAL

And could you cherry-pick https://github.com/paritytech/frontier/pull/648 and this PR to polkadot-v0.9.19 branch

I'd prefer not to. Release branches should only cherry pick security PRs.
Those new changes will come on polkadot-v0.9.20 branch.


Add startsWith predicate

Rebasing previous work

Hey @rdblue,
Sorry for creating something else I didn't need to, well at least now I know how to do transformations :)
So I updated one transformation, namely the Bucket, but I don't know how this would be done for others like Dates for example. I think that for the Identity transform there is no need to update it as it will just apply the predicate anyway. Thanks a lot for the pointers and help @rdblue !

@renato2099, have another look at your bucket projection. It isn't correct. There is no relationship between hash values of two strings and whether the strings have the same prefix.
I agree with your logic about the identity transform. The date and timestamp transforms can't be applied to a string column, so no need to update those. The only remaining transform is truncate, which needs to be handled.

hey @rdblue
Thanks a lot for your help! I have updated the PR, please let me know if I am still missing something else.

@renato2099, sorry for the delay. I didn't realize you had updated this.
I see a few issues, still. I don't see an update to Truncate in these changes. I do see a test. Did you accidentally drop those changes? Also, we need to add tests for StartsWith for all of the transforms, and for both project and projectStruct.

Merged as part of #327. Thanks for working on this, @renato2099!


Update template for XS6

After XS6 update, MonoDevelop.CocosSharp.Templates add-in is broken. I updated for this change.
I couldn't find this changes from the release note but I found some information below:

https://github.com/PrismLibrary/Prism/issues/638#issuecomment-227186035
https://www.jimbobbennett.io/more-on-xamarin-studio-add-ins/

Releated https://github.com/mono/CocosSharp/issues/362

Thanks @haruair


Datepicker opening after tab switch

To reproduce : open picker, select a date, do not click anywhere, change browser tab, come back to datepicker's tab : the datepicker is open again.
maybe related to #102

angular-moment-picker.js line 766

				// event listeners
				$scope.focusInput = function (e) {
					e.preventDefault();
					$scope.input[0].focus();
				};
				$scope.input
// Removing the 'focus' event here solve the issue but breaks keyboard tab navigation when focusing icon
					.on('focus click', function () { $scope.$evalAsync($scope.view.open); })
					.on('blur',        function () { $scope.$evalAsync($scope.view.close); })
					.on('keydown',     function (e) {
						if (!$scope.keyboard) return;
						e.preventDefault();
						$scope.$evalAsync(function () { $scope.view.keydown(e); });
					});
				$scope.contents.on('mousedown', $scope.focusInput);
				$scope.container.on('mousedown', $scope.focusInput);
				angular.element($window).on('resize scroll', $scope.view.position);
			});

Hi @tm-fari,
Actually it is wanted that focus event will get the picker to open, and removing this will cause an unwanted breaking change (and it also removes a useful feature).
This is not due to Angular Moment Picker but to a browser behavior.
angular.element('input').on('focus', function () { console.log('input focused'); });

You can see that if you change browser tab and go back to the previous one, it will always fire focus event.
Anyway, you can control picker opening/closure by handling is-open attribute of the directive.
Hope this helps! :)

Hi,
Thank you very much for your reply, I'll take a closer look at this
later this week.
Thanks also for moment-picker, we were having issues with angular
material datepicker and are quite happy now with yours!
Take care
Fahri Tardif
On 17-01-20 05:15 PM, Indri Muska wrote:

Hi @tm-fari https://github.com/tm-fari,
Actually it is wanted that focus event will get the picker to open,
and removing this will cause an unwanted breaking change (and it also
removes a useful feature).
This is not due to Angular Moment Picker but to a browser behavior.
angular.element('input').on('focus',function  () {console.log('input focused'); });
You can see that if you change browser tab and go back to the previous
one, it will always fire focus event.
Anyway, you can control picker opening/closure by handling |is-open|
attribute of the directive.
Hope this helps! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/indrimuska/angular-moment-picker/issues/118#issuecomment-274194442,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVBD4Oiu1P4KG2jZiztcfCF860T30hgoks5rUTH_gaJpZM4Lk9kR.


Configure subdomain pointing to netlify deploy

To track work configuring a subdomain to point to the netlify site master branch deploy. I'm not sure what it's supposed to be, but probably something like https://needs.mutualaidmamas.com would be appropriate.

setup CNAME to point to netlify site
configure netlify to issue Let's Encrypt certificate

@mmoutenot if you want to give me netlify access (or if we want to create a new account for this), I can take this on once we hear back about access.

:wave: sorry I've been MIA. Been working long days and not much energy for computers outside of that. I'll try to transfer it to you @mewtaylor

@mewtaylor what is your netlify login/email?

@mmoutenot no apology necessary! I hope everything's ok, glad you're taking screen breaks. Just sent you my info.

@mewtaylor I think you should create a new netlify site. Because we are on the free tier, to transfer I would need to open a support ticket apparently.