LUKS & LVM support and file system refactoring

This PR does refactors the current file system code to allow it to model complex disk layouts that include LUKS container and LVM. For this it introduces a simple entity data model that can be used to navigate and operate on such complex layouts in a very generic way.

The byte/sector size stuff really was a mess - sorry about that!

Needs rebase (to fix EL9 mockbuild).

I am marking this as ready for review. There are still two TODO list items open but they will be additive to the existing code and not change it anymore.

Manifest and image info updates coming later today

Very nice work! It must have been quite an effort to rework all of partitioning code and extend it. Respect 🙇♂
I added a "few" inline comments, but to sum it up:

I have concerns about mixing sizes in bytes and sectors when using disk.Partition.

Inside disk all the declarations should actually be bytes now and there should not be a mix anymore. Any left-over, I think, would be a mistake. In osbuild2 it will need to be sectors because that is what org.osbuild.sfdisk wants.

I think that some disk-related methods could be made more generic and not hardcode things like e.g. filesystem with XFS, etc. The question is whether it is worth it and makes sense, but I thought that it could, given the extent of refactoring and goal to make the code generic.

I think that is actually a good idea. Just passing Filesystems around does not fully work, because of the case of Btrfs, where you can't have a different filesystem. But I think we should think about this and extend it in the future.

A bit of a nitpick, but I think that consistency is important. You used Gen...StageOptions() name for constructors, instead of New...StageOptions() as it is currently used across the code base. Using the Gen... name for functions / methods which generate e.g. slice of stages which do something more advanced probably makes sense. However I think that we should keep naming consistency for constructors.

I think our idea was New... is typically used in Go to create single objects, i.e. as you also call them, they are constructors. All our Gen... methods are not object constructors but helper functions to generate an array of stages. My personal initial intuition was to actually have them take a Pipeline parameter and just add the stages to the pipeline instead of returning them, but @achilleas-k preferred to return them because that was done in other places so we stuck with that.

Very nice work! It must have been quite an effort to rework all of partitioning code and extend it. Respect 🙇♂
I added a "few" inline comments, but to sum it up:

I have concerns about mixing sizes in bytes and sectors when using disk.Partition.

Inside disk all the declarations should actually be bytes now and there should not be a mix anymore. Any left-over, I think, would be a mistake. In osbuild2 it will need to be sectors because that is what org.osbuild.sfdisk wants.

Yes, this is the case from what I remember. Nevertheless I would find it less confusing (also in case of debugging an issue related to partitions) to use a different structure type in osbuild2.

I think that some disk-related methods could be made more generic and not hardcode things like e.g. filesystem with XFS, etc. The question is whether it is worth it and makes sense, but I thought that it could, given the extent of refactoring and goal to make the code generic.

I think that is actually a good idea. Just passing Filesystems around does not fully work, because of the case of Btrfs, where you can't have a different filesystem. But I think we should think about this and extend it in the future.

Fair enough. However as I commented inline, some Entities like LVM logical volume could contain another container inside it, not just a filesystem.

A bit of a nitpick, but I think that consistency is important. You used Gen...StageOptions() name for constructors, instead of New...StageOptions() as it is currently used across the code base. Using the Gen... name for functions / methods which generate e.g. slice of stages which do something more advanced probably makes sense. However I think that we should keep naming consistency for constructors.

I think our idea was New... is typically used in Go to create single objects, i.e. as you also call them, they are constructors. All our Gen... methods are not object constructors but helper functions to generate an array of stages. My personal initial intuition was to actually have them take a Pipeline parameter and just add the stages to the pipeline instead of returning them, but @achilleas-k preferred to return them because that was done in other places so we stuck with that.

My comment is specifically related to functions / methods which create a single object - stage options. I think that these should be treated as constructors. This is the case for other osbuild2 stages, which were not touched by your PR. But I'll double-check your changes once more.

A bit of a nitpick, but I think that consistency is important. You used Gen...StageOptions() name for constructors, instead of New...StageOptions() as it is currently used across the code base. Using the Gen... name for functions / methods which generate e.g. slice of stages which do something more advanced probably makes sense. However I think that we should keep naming consistency for constructors.

I think our idea was New... is typically used in Go to create single objects, i.e. as you also call them, they are constructors. All our Gen... methods are not object constructors but helper functions to generate an array of stages. My personal initial intuition was to actually have them take a Pipeline parameter and just add the stages to the pipeline instead of returning them, but @achilleas-k preferred to return them because that was done in other places so we stuck with that.

To add to this a bit:
There's two aspects here.  One is what @gicmo mentioned: I argued against calling a function NewX() when it wasn't returning a variable of type X.  This covers cases like GenCopyFSTreeOptions() or GenImageKernelOptions(), or the cases where a slice of Stage is returned.
The other aspect is cases like GenZiplInstStageOptions(), which do return the type mentioned in the function name.  I felt that given the arguments and what the functions do in these cases, it's a bit more than a constructor and doing much more than just initialising a struct type with some values.  I don't feel strongly about this though, that's still a constructor at the end of the day, I just wanted to differentiate it from the "dumb" constructors we have for stages and the like.  Maybe it's a distinction without a difference though and we should just use NewX() for anything that takes some arguments and creates a new X.

To add to this a bit:
There's two aspects here. One is what @gicmo mentioned: I argued against calling a function NewX() when it wasn't returning a variable of type X. This covers cases like GenCopyFSTreeOptions() or GenImageKernelOptions(), or the cases where a slice of Stage is returned.
The other aspect is cases like GenZiplInstStageOptions(), which do return the type mentioned in the function name. I felt that given the arguments and what the functions do in these cases, it's a bit more than a constructor and doing much more than just initialising a struct type with some values. I don't feel strongly about this though, that's still a constructor at the end of the day, I just wanted to differentiate it from the "dumb" constructors we have for stages and the like. Maybe it's a distinction without a difference though and we should just use NewX() for anything that takes some arguments and creates a new X.

Thanks for the explanation and additional context. The source of my opinions may be that coming from other programming languages, I don't view constructors necessarily as functions which have to be simple or "dumb".

Thanks for the explanation and additional context. The source of my opinions may be that coming from other programming languages, I don't view constructors necessarily as functions which have to be simple or "dumb".

Yeah, I'm not convinced by my argument either tbh.  Renaming :)

CentOS Stream 9 tests are known to be broken unrelated to this PR (sadly), so I'll override CI and do an admin merge.

:rocket:

🚀


abusehelper.bots.abusech.ransomwarebot: abuse.ch Ransomware Tracker feed

Polling bot for abuse.ch Ransomware Tracker feed.

Are the "first seen" missing the Z timezone marker?

Looks good to me :+1:


tests: ignore pg_xact files in comparison

Problem
This test has been flaky for years.  It's a very important correctness test, so we need to get it off the list of flaky tests to avoid ignoring other more severe failures.
It's not obvious to me exactly why it's failing, but this is a binary-level difference in postgres structures that I'm not qualified to diagnose: the test is hoping that CHECKPOINT will guarantee that everything in pg_xact hits disk, but this is either not the case, or there is some subtle underlying issue that can result in different file content from the same stream of writes.
Closes https://github.com/neondatabase/neon/issues/559
Summary of changes

Exclude pg_xact files from comparison in check_restored_datadir_content

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

I'm pretty reluctant about this. If the test cannot validate pg_xact anymore, it reduces the coverage of the test significantly.
I created https://github.com/neondatabase/neon/pull/6666, as yet another attempt fix the discrepancy. I was not able to reproduce the flakiness locally, so it's just based on a hunch that something happens in the database after the last checkpoint that isn't reflected in the basebackup yet. I think even if it doesn't fix the flakiness, it's a more robust approach anyway. If it doesn't fix the flakiness, let's revisit this.

https://github.com/neondatabase/neon/pull/6666 is a plausible fix, so I'll close this and we can monitor the test to see if it stabilizes.


Fix error in create_log_entry example

The current example reports that it may return an error.
We should change the example to (by default) create fresh entry data (this requires either a new test file or a new signing key or both, I don't remember offhand but it can be tested), upload this data to Rekor, and then clean up after itself.

I'm working on this


Fix Coalesce casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion

Which issue does this PR close?

Closes #10261
Closes #10241
Part of #10507
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks @jayzhan211  - I will check this out tomorrow

I am sorry I ran out of time to review this yesterday. I plan to do so later this morning

I made a PR with just your wonderful tests in https://github.com/apache/datafusion/pull/10334/files

Marking as draft as I think we are pursuing an alternate strategy, https://github.com/apache/datafusion/issues/10423, now

In general I am concerned about the potential downstream effects of this change. I don't fully understand them
What I would ideally like to do is to run the influxdb_iox regression tests with this change and see what happens.
I am not sure I have the time to do that in the next week -- maybe @appletreeisyellow  does 🤔

Basically I worry this is just changing behavior rather than fixing a bug and will result in churn for no benefit downstream. I may be mis understanding the change and rationale however

I believe the coercion rule is quite messy as it currently stands. It would be more understandable and maintainable to move the coercion rule from coerced_from to each individual function. This way, it would be clear which coercion rule applies to each function or signature. Having a single function handle multiple coercion rules makes the code harder to reason about and could cause downstream issues, as you have pointed out. I've also filed an issue to track this at @10507.
Would it be better to start by removing the rule from coerce_from and moving it to the specific function or signature?

I am not sure I have the time to do that in the next week -- maybe @appletreeisyellow does 🤔

@alamb I'm happy to coordinate with our performance team and run an influxdb_iox regression tests if needed

I don't think this needs a performance test -- I was thinking just the main test suite

I believe the coercion rule is quite messy as it currently stands. It would be more understandable and maintainable to move the coercion rule from coerced_from to each individual function. This way, it would be clear which coercion rule applies to each function or signature. Having a single function handle multiple coercion rules makes the code harder to reason about and could cause downstream issues, as you have pointed out. I've also filed an issue to track this at @10507.
Would it be better to start by removing the rule from coerce_from and moving it to the specific function or signature?

Hi @jayzhan211  -- I am sorry I haven't had a chance to devote more time to this and review. I will try and find some time in the next few days

I don't think this needs a performance test -- I was thinking just the main test suite

I was thinking performance regression 😅 Got it! I can put up an Influxdata test agains this branch, sometime this afternoon

Looks good, and existing tests are passing 👍  🚀

Thanks @alamb and @appletreeisyellow

Thank you for sticking with it @jayzhan211  -- so much is going on!@


$interval is called without delay

According to the doc, the delay argument is not optional. This causes troubles with ngMocks which expects an explicit delay.

I just ran into the same issue, is there any progress here? @ddolcimascolo do you have a PR open with this change?
I created a PR to fix this but it seems like you've done the same thing in your fork.


Refresh Tableview in childcontainer

Hello, is it possible to refresh the tableview of a child container? I am using pulltorefresh, I then call tableview refresh data, but the tableview does not actually get refreshed.
Is it possible to refresh the tableview inside a child container?
Thanks

Hi @aferrerb,
Refreshing a child controller's tableView is not something that XLPagerTabString can natively supported because it doesn't restrict child view controllers to have a table view.
As I don't know how your code looks like, I guess that when the pull-to-refresh event is fired you can get the list of child controllers by accessing to the childControllers property from your PagerTabStripViewController and then call to refresh the table for each of them.
I would define a protocol or a base class for the child view controllers in order to safely call to refresh their table.
If you provide us with more information we might be more helpful :)
Regards


Ensure that Quorum geth is on the PATH

geth version
Geth
Version: 1.9.12-stable
Git Commit: b6f1c8dcc058a936955eb8e5766e2962218924bc
Architecture: amd64
Protocol Versions: [65 64 63]
Go Version: go1.13.8
Operating System: linux
GOPATH=
GOROOT=/home/infosec/work/env/go
./raft-start.sh
ERROR: you appear to be running with upstream geth. Ensure that Quorum geth is on the PATH (before any other geth version).
Steps to reproduce the behavior
Hello everyone,
I am doing some experiment about quorum
But it says
ERROR: you appear to be running with upstream geth. Ensure that Quorum geth is on the PATH (before any other geth version).
What can i do

Hi, this message is informing you that your geth command is running standard go-ethereum and not quorum.  Make sure that you have built quorum and your PATH variable is pointing to it.
 I have succeed.


Adding GET request for Slack Integration on a Project

@rawkode I'll merge this as is, but will make a small follow up PR to tighten things up a bit. Will reference this PR so you can see what I changed. Thanks!


Full DOIs?

@bmanubay - Niels in the Gilson lab remarks that the filename field seems to be part but not all of the DOI. Is there a way to get the full DOI? Particularly, he says:

The filename field seems to be a DOI, except that the first half of the DOI (registry/registrant) is missing.   I can google the filename and usually get to the published article, but is there some way to get the full DOI directly?

For instance, the first line here:
https://github.com/open-forcefield-group/open-forcefield-data/blob/master/Binary-Mixtures/Property data/eme_bin.csv (is that where I should be looking on github?) says ... j.jct.2005.03.012, but the full DOI is 10.1016/j.jct.2005.03.012

Hey @davidlmobley
Unfortunately that is the information that ThermoPyL provides for filename when the data is pulled down. I looked into finding some way to generate DOI from these abbreviated article titles (like a Python module or something), but couldn't find anything.

Probably a good question for Ken Kroenlein?  They should be documenting that.
Note:

The link to the original ThermoML standard description is broken on this page: Click on "Pure Appl. Chem., 2006, 78, 541-612" (ThermoML Recommendations 2006)
That paper is here but doesn't mention anything about truncated DOIs---it suggests full DOIs are stored in the sDOI field.


Refactored project import

Unit testing and optimization of #269
Stylistic improvements to drib rendering.
Project tips moved to top and expanded.
#270 shown on home.
Minor updates to dependencies.

Codecov Report

Merging #271 (42094d5) into main (963da76) will increase coverage by 2.31%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   41.81%   44.13%   +2.31%
==========================================
  Files          30       30
  Lines        3281     3306      +25
==========================================
+ Hits         1372     1459      +87
+ Misses       1909     1847      -62

Impacted Files
Coverage Δ

dribdat/public/project.py
23.75% <ø> (+0.09%)
:arrow_up:

dribdat/user/models.py
54.13% <0.00%> (+5.32%)
:arrow_up:

dribdat/public/api.py
29.75% <18.51%> (+0.07%)
:arrow_up:

dribdat/apipackage.py
31.50% <45.00%> (+21.35%)
:arrow_up:

dribdat/user/constants.py
35.18% <50.00%> (ø)

dribdat/apiutils.py
40.44% <100.00%> (+20.68%)
:arrow_up:

dribdat/database.py
88.88% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963da76...42094d5. Read the comment docs.

Deployed to meta.

Deployed to https://meta.dribdat.cc/


Reduce number of parallel runs in Drone CI

@vascoguita why did you do this? This will increase the CI time dramatically.

It was a mistake, I already removed the merge.


(ASC-1085) (ASC-1126) create pipeline for MaaS system tests.

Prior to this PR there is no pipeline for MaaS system tests.
This PR is to create the job.
(cherry picked from commit 60af32574f7f1248d3f3072c82cf07483cffd2d0)
Issue: ASC-1085

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.

recheck_xenial_no_artifacts_swift_deploy


I2C NACK when full

This PR adds NACK functionality to the I2C target. It adds a mode bit in the control register to control whether target stretches the clock when ACQ FIFO is full or sends a non-acknowledge instead.
Closes: https://github.com/lowRISC/opentitan/issues/15227

The last force push was a rebase on top of the latest I2C changes.

I'm closing this PR since it seems like another more feature-full one: https://github.com/lowRISC/opentitan/pull/21857


Not using system libraries by default

https://github.com/sparklemotion/nokogiri/blob/master/ext/nokogiri/extconf.rb#L87
This seems baffling, I would have thought that you'd surely need to opt into building a local copy of a library that has a reasonable history of security issues (that are fixed in a timely manner), unless there's a new nokogiri release after each one you're probably left with a broken lib.

@richo - Please check out #1220 which proposes some behavior changes to address these concerns.

I believe the concerns in this issue are covered in #1220 which is being worked on now. I'd like to close this and redirect conversation over to that issue. Please let me know if you have objections, else I'll close in a day or two.

Please keep in mind that you can install nokogiri using the --use-system-libraries option to force the use of installed system libraries. Currently this is opt-in, and I understand the objections to that behavior.
This behavior is being changed to not be strict opt-in or opt-out, but some nuance that is posted at #1220.

Recommend closing issue in favor of discussion in #1220.

Agree.


feat: allow webserver_config.py to come from the image

What does your PR do?
Allows the user not to use a chart-based webserver_config.py, but instead one that comes from the image

@thesuperzapper now that I see you're back, I'm hoping this is relatively simple to review.

@thesuperzapper now that I see you're back, I'm hoping this is relatively simple to review.

@mb-m I never left, lol, I have actually been spending an unbelievable amount of time on https://github.com/airflow-helm/charts/issues/339, I am still hoping to have it in 8.7.0, but if enough useful PRs build up, I will cut 8.7.0 before then.

@mb-m @thesuperzapper   reference  readme https://github.com/airflow-helm/charts/blob/main/charts/airflow/docs/faq/configuration/airflow-configs.md
When to set  env say this use case AIRFLOW__WEBSERVER__WEB_SERVER_SSL_KEY from a Secret , does the airflow.cfg automatic detect the the env , I see the from docs. it says you can either set in the airflow.cfg or environment variables


Service invocation supports passing of query strings/fragments in URL

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[X] Read the contribution guide
[N/A] Commands include options for Linux, MacOS, and Windows within codetabs
[N/A] New file and folder names are globally unique
[N/A] Page references use shortcodes instead of markdown or URL links
[N/A] Images use HTML style and have alternative text
[N/A] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR seeks to supplement the service invocation documentation to clarify that a query string and fragment can be passed within the URL and Dapr will pass it through unchanged. I couldn't find this documentation otherwise documented anywhere except as a single test case in the .NET SDK
Issue reference
https://github.com/dapr/dotnet-sdk/issues/1303

@hhunter-ms This PR has no dependency on the C# SDK PR I also created this morning as it's just sharing general guidance around the fact that the capability is there by default (where it's not presently called out).


Supporting Environment Variables for Checkout Extensions

https://github.com/Shopify/ui-extensions/issues/680#tasklist-block-7c820eb1-76d3-45df-8ccc-72261f4bf071
https://github.com/Shopify/ui-extensions/issues/680#tasklist-block-b39b563d-13bc-4737-9de5-6b36daa80465
Please list the related package(s)

checkout-ui-extension
If this related to specific APIs or components, please list them here

Is your feature request related to a problem? Please describe.
App that my team develops is deployed to multiple environments (dev. sandbox, staging, prod, etc). Whenever, I am deploying app to these environments process becomes very manual. For each environment I need to go and select the different app and then run deploy command. Also, inside my extension code, api endpoint will change depending upon the environment. Whenever, I run yarn dev for a particular app, I need to go in extension code and change the api endpoint manually. It would be wonderful if you can provide .env file and we can set env vars for shopify app dev and `shopify app deploy' commands in the .env file.

Support passing the environment variables to checkout extensions. It is needed if the extension is built for multiple environments and use different APIs.
Describe the changes you are looking for

Ability to pass custom options to shopify app dev and shopify app deploy, it could be using either .env file or separate key-value pairs. These environment variables should flow to the checkout extension code and it should be made available to use.
Describe alternatives you’ve considered

Let's say extension is deployed on 3 environments dev, sandbox, and prod. For each of these envs checkout extension would want to hit different url dev.mydomain.com, sandbox.mydomain.com, etc. But whenever app is deployed, I can't really specify which env to target. To achieve this I have defined extension settings, whenever app is deployed I can get value for env from extension settings. But extension settings are not available when running local dev server. So whenever I run the local dev server, I've to go and update the env code. It is really frustrating.
Additional context

Okay I found a workaround by hardcoding a list of test shop IDs that will use the development endpoint, and all others use the production one.

Any update on this issue ? Feels like we cannot use environment variable to configure our extension.
It should be available since we want to configure our extension according to the stage it's going to be deployed (local, staging, production, etc).
Is there any workaround for this ? I guess we can use the useSettings hook from the checkout-ui-extensions-react and then configure our app from the shopify.extension.toml, but that forces us to hardwrite configuration.


[WIP] Post comment containing failed pictures to PR

The goal of this bot is to make it easier to update visual diff pictures created in #624 and #626.

Creates a Gist
Pushes a zip file to it (can't do it in one step sadly)
Posts a comment on the failed PR with a link to the zip

The reason why we use Gist is that I don't think that it's currently possible to directly create a comment with files with the GitHub API.
WIP: Figure out Travis secrets

Ok, so this isn't actually doable without an external server I think, so I'll just put this on hold for a bit until I find a solution.

This would be an awesome dedicated service

Was thinking about that too actually. Do you have any suggestions / whishes? I'm mostly stuck on figuring out the security aspect of it right now.

so something exactly like percy!

Closing in favour of #668


shoulder-exam

referenced

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #143   +/-   ##
======================================
  Coverage    30.4%   30.4%
======================================
  Files          16      16
  Lines         375     375
  Branches      100     100
======================================
  Hits          114     114
  Misses        261     261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e837c...231fdcf. Read the comment docs.


Build fails on SVG error

Attempting to build with command PATH_TO_XMLLINT="/usr/bin/xmllint" PATH_TO_JING="/usr/bin/jing" PATH_TO_SAXON_JAR="../saxon9he.jar" PATH_TO_TEI_STYLESHEETS="../Stylesheets" ./build.sh build gives this error:
mei-err.log

Hi,
the essential message in your error log is this line:
Caused by: org.xml.sax.SAXParseException; systemId: http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng; lineNumber: 6; columnNumber: 3; The element type "hr" must be terminated by the matching end-tag "</hr>"
To my opinion this is a bug in the TEIC/Stylesheets project as it does not resolve correctly the mentionned URL.
We can solve this also by setting the URL to https://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng in the MEI sources or just in your odd file.
HTH, franz

Is this a problem with the value currently set in the MEI sources?

yes, seems to  be:
customizations\mei-all.xml:100:        <moduleRef url="http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng"
customizations\mei-all_anyStart.xml:136:        <moduleRef url="http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng"
customizations\mei-CMN.xml:95:        <moduleRef url="http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng"
customizations\mei-Mensural.xml:95:        <moduleRef url="http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng"
customizations\mei-Neumes.xml:95:        <moduleRef url="http://www.tei-c.org/release/xml/tei/custom/schema/relaxng/svg11.rng"
source\modules\MEI.xml:86:        <graphic url="ExampleImages/accid-20100510.png" height="50%" width="50%"/>
source\validation\mei_odds.odd:60:        <moduleRef url="http://relaxng.org/relaxng.rng"/>

Can confirm that changing SVG links to HTTPS solves my issue.

OK; thanks. I'll flag this as an urgent change

I've filed a new tracking issue for this fix to go into the MEI core, so I will close this issue now.

Re-opening so we can have a specific issue to fix, as per the Slack conversation.


Add on fails to start: s6-overlay-suexec: fatal: can only run as pid 1

Trying to run this as an add on on a 2022.5.4 system generates the error: s6-overlay-suexec: fatal: can only run as pid 1
Something seems to have changed w.r.t hass add on configurations.  Active discussion is currently occurring in this community thread:
Hello_world example addon from developer docs stopped working (s6 overlay issue?)
Adding init: false to the add on's config.yaml might fix this, though there seems to be more discussion about updating base images.
**UPDATE: ** Adding init: false to the add on's config.yaml enabled the addon to start.  While this seems to work I didn't try to sort through the discussion in the community thread to figure out if this is the right thing to do.

It’s running fine on my 2022.5.4 system running Home Assistant OS7.6- are you running HA in a container or Home Assistant OS?

@rct - thanks for that - I've added init: false per your commit - it is working on my system without error however I didn't have an error previously. Strange that some system have it.

@vk2him - Yes, it is working for me since adding init: false.  Not sure why it isn't tripping you up. Maybe you haven't rebuilt with the v3 s6 base/components yet?
S6-Overlay 3.x update on our docker base images from Home Assistant Developer blog has some more info.

Yes I've made the MQTT_TOPIC configurable.  Also, I've removed the leading / from the topic.  I'm still somewhat new to MQTT, but I believe that's creating a topic path that is (null)/envoy/json.  It could be seen in the MQTT explorer GUI as having an empty top level topic string.   Of course that change will break existing state_topic definitions for sensors.
Thanks for creating this project. I've been putting off trying to create my own addons, but I've been learning from your project, so thanks for that.
One more thing - the code as currently written won't work standalone unless you have a /data/options.json file.  So there needs to be a way to set where that is or try a few paths.

@rct - yes you're right - I didn't need to rebuild so that's probably why I didn't see it - thanks for raising the issue and providing the fix!
Re using it standalone - I mentioned in the Readme under Installation Method 2 that  /data/options.json is needed - as an alternative you could also hard-code the values into '[envoy_to_mqtt_json.py' - this is how I originally used it.
Cheers


See Filings Info

When using Filings > See Filings Info, and entering "bond" for the court ID I get the error below. Note: I've primarily been testing with boone which does not produce this error:
TypeError: 'NoneType' object is not iterable
In field index number 0

History
Needed definition of get_filing at 0.00000s
Tried to run block at 0.00006s

code: |
  resp = proxy_conn.get_filing(court_id, filing_id)
  del court_id
  del filing_id
  get_filing = True

Needed definition of filing_id at 0.00015s
Tried to ask question at 0.00022s

id: filing id
question: |
  Filing id?
fields:
  - Filing id: filing_id
    datatype: combobox
    code: |
      [filing_id_and_label(y) for y in proxy_conn.get_filing_list(court_id, today().minus(years=1), today().plus(days=1) ).data]

A similar behavior exists when trying to cancel a filing. That is, choosing "bond" produces an error:
TypeError: 'NoneType' object is not iterable
In field index number 0

History
Needed definition of cancel_filing at 0.00000s
Tried to run block at 0.00006s

code: |
  resp = proxy_conn.cancel_filing_status(court_id, filing_id)
  del court_id
  del filing_id
  cancel_filing = True

Needed definition of filing_id at 0.00015s
Tried to ask question at 0.00022s

id: filing id
question: |
  Filing id?
fields:
  - Filing id: filing_id
    datatype: combobox
    code: |
      [filing_id_and_label(y) for y in proxy_conn.get_filing_list(court_id, today().minus(years=1), today().plus(days=1) ).data]

This is likely because we haven't made any filings in bond, so there aren't any potential cases to select from. Need a better DA fallback for that.

I think we still need the review filings permission for these calls, yes? I haven't ever gotten them to work

See #29


Out of Memory Error : Recycle?

Please forgive me for my noob-ness in Android programming. Just learnt Java weeks ago.
I've been using Lazylist to load images from website. However, I've been getting OOM error.
I searched it up on Stackoverflow and realized that recycle is needed so that space can be allocated for more images.
I looked it up on ImageLoader and this (recycle) wasn't implemented. I tried to code it myself yet faced with lots of error [bitmap.recycle()]. May I ask if this is possible?
Furthermore, in the listview, one image doesn't cause an error, yet when I add textview etc, it caused the OOM error too.
Thanks!

I  have the same issue,
any solution ?


ICommonAPI.setPlayerModel() not work

Non-static method 'setPlayerModel(java.lang.Class<P>, P, com.tom.cpm.shared.io.ModelFile, boolean)' cannot be referenced from a static context
when im trying to use ICommonAPI.setPlayerModel(Player.class, playerObj, modelFile, forced); method

You need an instance of ICommonAPI to set the player model, and you must call this on the server! It won't work on the client.


vscode extension fails with new refactoring "move to file"

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
1.8.2
Link to runnable example
No response
Steps to reproduce

Install the extension
create an .mdx file and two .ts files
try to move something from one ts file to another via the new refactoring "move to file"
observe the error shown by vscode

Expected behavior
vscode should show the file selection popup (it does without the extension installed)
Actual behavior
An error pops up:

 TypeScript Server Error (5.4.2)
Debug Failure. File /.../file.mdx has unknown extension.
Error: Debug Failure. File /.../file.mdx has unknown extension.
at extensionFromPath (/.../node_modules/typescript/lib/tsserver.js:21381:39)
at /.../node_modules/typescript/lib/tsserver.js:147260:33
at mapDefined (/.../node_modules/typescript/lib/tsserver.js:2680:22)
at Proxy.getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:147259:19)
at IpcIOSession.getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:187171:41)
at getMoveToRefactoringFileSuggestions (/.../node_modules/typescript/lib/tsserver.js:185370:43)
at /.../node_modules/typescript/lib/tsserver.js:187524:69
at IpcIOSession.executeWithRequestId (/.../node_modules/typescript/lib/tsserver.js:187516:14)
at IpcIOSession.executeCommand (/.../node_modules/typescript/lib/tsserver.js:187524:29)
at IpcIOSession.onMessage (/.../node_modules/typescript/lib/tsserver.js:187566:51)
at process. (/.../node_modules/typescript/lib/tsserver.js:189175:14)
at process.emit (node:events:514:28)
at emit (node:internal/child_process:937:14)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

Runtime
Other (please specify in steps to reproduce)
Package manager
Other (please specify in steps to reproduce)
OS
Linux
Build and bundle tools
Other (please specify in steps to reproduce)

This is also a debug error encountered by @Princesseuh in astro language tools. It needs to be solved upstream. I will open an issue to TypeScript.

Yep, here's the corresponding issue https://github.com/withastro/language-tools/issues/812

This is somewhat relevant to #413 - downgrading to 1.7.3 worked


Update comments onboarding tour

Description
Comments tour updates
Fixes #5577
Depends on changes done in #5521
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: update-comments-onboarding-tour-cherry-picked

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
53.64 (0.03)
35.38 (-0.02)
32.17 (0.04)
54.2 (0.04)

:red_circle:
app/client/src/api/OrgApi.ts
56.25 (-3.13)
0 (0)
8.33 (-8.34)
54.84 (-3.22)

:red_circle:
app/client/src/comments/CommentCard/CommentCard.tsx
72.67 (-0.82)
63.25 (-2.24)
42.86 (-1.04)
73.13 (-0.9)

:green_circle:
app/client/src/comments/inlineComments/AddCommentInput.tsx
74.34 (1.96)
42.5 (0)
65 (1.84)
74.75 (2.22)

:green_circle:
app/client/src/comments/inlineComments/OverlayCommentsWrapper.tsx
96.77 (0.22)
75 (0)
100 (0)
100 (0)

:red_circle:
app/client/src/comments/inlineComments/useOrgUsers.tsx
95.45 (-4.55)
77.78 (2.78)
100 (0)
95.45 (-4.55)

:red_circle:
app/client/src/components/ads/tour/TourTooltipWrapper.tsx
96.77 (0)
69.44 (0.69)
80 (-3.33)
96.77 (0)

:green_circle:
app/client/src/pages/Applications/permissionHelpers.tsx
100 (7.69)
100 (0)
100 (50)
100 (8.33)

:red_circle:
app/client/src/pages/Editor/ToggleModeButton.tsx
64.75 (-4.82)
25.37 (-12.13)
40 (2.96)
63.28 (-4.03)

:red_circle:
app/client/src/reducers/uiReducers/orgReducer.ts
13.51 (-2.71)
0 (0)
0 (-4.17)
13.51 (-2.71)

:red_circle:
app/client/src/reducers/uiReducers/commentsReducer/handleNewCommentThreadEvent.ts
86.67 (-5.64)
75 (-8.33)
100 (0)
86.67 (-5.64)

:red_circle:
app/client/src/sagas/OrgSagas.ts
18.05 (-4.51)
2.7 (-0.33)
7.14 (-7.15)
22.64 (-3.78)

:green_circle:
app/client/src/selectors/entitiesSelector.ts
48.02 (0.25)
5.56 (0)
19.05 (-0.23)
45.78 (0.33)

:green_circle:
app/client/src/selectors/organizationSelectors.tsx
69.77 (2.33)
0 (0)
31.58 (5.26)
66.67 (3.71)

:green_circle:
app/client/src/utils/helpers.tsx
55.56 (1.97)
30.99 (4.23)
26.92 (3.84)
49.17 (1.67)

:red_circle:
app/client/src/utils/storage.ts
37.23 (-2.19)
13.64 (0)
16.67 (-3.33)
30 (-2)

:sparkles: :new:
app/client/src/utils/hooks/useOrg.tsx
88.24
27.27
100
87.5

:red_circle:
app/client/src/utils/hooks/useProceedToNextTourStep.tsx
100 (0)
40 (-10)
100 (0)
100 (0)

/ok-to-test sha=0892ea0


hide bottom container

How to hide bottom container which includes time, seek bar and full-screen icon. I don't want to set any progress bar on view.

call setAllControlsVisible interface

I was set this method in the adapter of the list but it visible bottom container.
Check my code
holder.mPlayerWidget.setAllControlsVisible(View.GONE,View.GONE,View.VISIBLE,View.VISIBLE,View.VISIBLE,View.VISIBLE);

Call setAllControlsVisible after startPlay. but if you touch screen bottom container will be shown. you can modify "changeUiShowState(Mode mode)" in MxVideoPlayerWidget

I was tried to modify "changeUiShowState(Mode mode)" but it's not working properly.
Can you please provide any boolean method for maintaining its visibility?

I don't think this amendment is necessary.

It's required because in the list I just want to play video on click of the center play button and in some scenarios we just need to play video full screen without bottom container so we can hide it.
If possible can you please set any method to maintain its visibility and update code for same.

ok, i will add in next version. thank you

you can use 1.1.9 version.
setAutoProcessUI(true) and setUIStatusListener()
you can call setAllControlsVisible in listener


Make (Unreal) non-unity build available

This lets IWYU-type errors be fixed; they are often masked by it. Fix all detected errors of this kind. Note that it is on by default, likely for performance reasons.

Description

Fixes #
Where has this been tested?

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...

Possible Drawbacks

This change is

Note: may depend on https://github.com/CarlaUnreal/UnrealEngine/pull/11 as UnrealHeaderTool whined about Unreal internals without that change.


deprecate environment in favor of api_url

@brettbuddin stil very much a work in progress but thanks for the review! i'm currently struggling with the acceptance tests / doc generation 😕


Test sway at commit and converge for unseen candidates

Test that a participant sways for unseen candidates at COMMIT and CONVERGE.
Part of #237

The codecov claims that CONVERGE sway is not hit.

OK this is ready for another look; please let me know if you can think of a simpler way to test sway at CONVERGE. thanks

What is the source of non-determinism? I think it should be only the chain seed, which leads to beacons.

What is the source of non-determinism?

Order of chainsupport map for committed state, and consequently candidate inclusion in tryConverge which determines whether we sway at CONVERGE or not.

Order of chainsupport map for committed state

That seems counter to the comment there, as the comment states that there should be only one.

That seems counter to the comment there, as the comment states that there should be only one.

Right. If i have not missed anything I think that would only hold if this is fixed.


WIP - Autoscaling

CPU Utilization Autoscaler
6 iperf clients, 128 connections each, 10 second runs, 30 minute runtime.


goldpriceticker: disable plot, hopefully temporarily

@aaronbrace76 This app is performing a very large number of cache operations. For now, I'm disabling the time series component. There's a good chance other functionality is broken in the process. Could you take a look and see if the plot can be restored, while keeping down the number of cache operations?

Yes, it looks like the longer periods are receiving more datapoints from the API I wrote than the Tidbyt can even display, several for each day and the more days that elapse obviously it keeps getting bigger.
I can certainly cut it down by a factor of about 4 relatively easily, is that enough reduction or do I need to dig deeper?
I can also disable caching entirely and just return the full dataset every time. Caching was originally important when I was paying per query, but since I wrote my own API now its not that important.
Just trying to understand the scale of the cache issue.

The key thing is to cut down caching to a small (and constant) number of calls. It should be sufficient to cache the HTTP calls (ideally by passing ttl_seconds to http.get()) and say one cache.set for the resulting time series (even that may not be necessary, unless computing it is very expensive).


Add missing flush in one of the buffer creation helpers.

This caused gears to break, after a driver change removed an implicit flush in our buffer copy implementation that had been hiding this issue. I could have just changed gears to use coherent memory, but it seemed sensible to fix the helper infrastructure anyway.

Thx for the PR! Very much appreciated.


BFT-463: Add LeaderSelectionMode::Rota

What ❔
Adds a LeaderSelectionMode::Rota to allow specifying leaders in subsequent views using a list of public keys. The 1st validator on the list is going to be the leader in view 0, the 2nd in view 1, the 3rd in view 2, wrapping around to start from the beginning as the views increase. There can be repeated keys on the list, and they all have to be part of the committee.
Why ❔
This is part of BFT-439 to modify the BFT tests to use the approach outlined in the Twins paper. Part of that is the ability to control who is the leader in each of the views.
With this change we should be able to generate a fixed leader schedule for the first few rounds of a protocol. The implementation wraps around so it's a total function, but in practice the tests will provide leaders for all the rounds executed in the test.
Why not modify Sticky?
I thought about whether I should add a new variant to LeaderSelectionMode or modify LeaderSelectionMode::Sticky to allow multiple values. On the Protobuf bytecode level they should be compatible, and I thought Sticky is probably used mostly in tests.
Based on the answers in the comments below, this is not the case, and it is in fact used in production to represent the centralised sequencer. The genesis it is part of is stored in Postgres as JSONB, so changes in the key name would not be backwards compatible. The protobuf_conformance workflow correctly highlighted this regression 🎉

please remember to make the pr backward compatible

please remember to make the pr backward compatible

I tried; can you highlight what you consider a breaking change?

Are there some JSON based parsers, for config or genesis?

I can see the config being read from JSON in node/tools/main. All other JSON-Protobuf conversions seem to be in various tests.
So my question is, do you prefer to have a new variant next to Sticky because it's used in production configs, or is it a breaking change in JSON format that doesn't actually affect anything other than in-memory tests?
Happy to add a new variant, just thought I'd open the PR and ask here.

genesis is stored in postgresdb in jsonb format

also, Sticky is currently the only variant used in zksync-era and it will be in use for foreseeable future (main node being the only proposer).

also, Sticky is currently the only variant used in zksync-era and it will be in use for foreseeable future (main node being the only proposer)

Thanks. I thought you would do that with a single sized committee and round-robin.
Okay, what should I call this thing with multiple users... 🤔

plan is to make ENs non-proposer validators

Hate to ask, but what's an "EN"?

External node. That's old terminology though, we can start calling them full nodes.

Thanks @brunoffranca
That's what I thought, except in your presentation the full nodes were connected through the gossip-network, not the consensus-network, so "non-proposing validator" was slightly confusing into which network they would belong to, and if the consensus (as validators), then why external (or full) at the same time?

Round robin and Rota are synonyms.

I don't think they are synonyms... supervisors create the rota for workers to do, they aren't necessarily doing any round robin 🤔
From Google:
noun
1.
BRITISH
a list showing when each of a number of people has to do a particular job.

Since we are rotating on a subset of validators, maybe call it Subset?

The problem is it's not a subset, it's a list that can be arbitrarily long and contain arbitrarily repeating elements, e.g. [Alice, Bob, Alice, Alice, Alice, Charlie].

So, I think Grzegorz comment was a bit confusing. Let me clear this up.
We have 2 types of nodes: full nodes and validators. Full nodes (previously called external nodes) only participate in the gossip network. Validators participate in the gossip and validator networks.
The plan now is for us to have several validators but only one will be the leader (using the Sticky selection mode).

From vocabulary.com:

You can also call a rota a roster.

@brunoffranca would you prefer Roster?

I can see you like the name Rota. Let's keep it.


Update remaining RecordingInterfaces to use SpikeInterface backend

[x] IntanRecordingInterface
[x] BlackrockRecordingExtractorInterface
[x] BlackrockSortingExtractorInterface
[x] CED [Not tested in the old backend]
[ ] Cell Explorer [Not available in spikeinterface]
[x] Neuralynx
[x] NeuroscopeSortingExtractor
[x] OpenEphys
[x] PhySortingInterface
[x] SpikeGadgetsRecordingInterface

@h-mayorquin Please add the others, thanks! (Done!)

Axona has been added to spikeinterface:
https://github.com/SpikeInterface/spikeinterface/pull/529


Euler angles

The output euler angles have strange orientation , how its possible to get world orientaion for example in NED system ?

What do you mean "strange orientation"? X is roll, Y is yaw and Z is pitch

Look on ui printed yaw , pitch , roll
Its probably represented by quaternion to euler angles .
The yaw range is -90 to 90 , and also pitch roll start climbing when
turning.
Expected yaw, pitch , roll to be in NED coordinate system as should be in
the aircraft .
On Sat, 13 May 2023 at 6:00 Jakob @.***> wrote:

What do you mean "strange orientation"? X is roll, Y is yaw and Z is pitch
—
Reply to this email directly, view it on GitHub
https://github.com/gue-ni/OpenGL_Flightsim/issues/11#issuecomment-1546506303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGFAB5TZ73J6SFEESV4AGLXF32N7ANCNFSM6AAAAAAX3XVHVM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Using Simd interleave leads to wrong result for Lanes = 1

The following code returns a wrong result
#![feature(portable_simd)]

#[cfg(test)]
mod tests {
    use std::simd::Simd;

    #[test]
    fn test_interleave() {
        let a = Simd::<u8, 1>::from_array([1_u8; 1]);
        let b = Simd::<u8, 1>::from_array([2_u8; 1]);

        let (c, d) = a.interleave(b);

        assert_eq!(c.to_array(), [1_u8; 1]); // this works
        assert_eq!(d.to_array(), [2_u8; 1]); // this is wrong, because d is [1_u8; 1]
    }
}

I suspect that this is because 1 / 2 = 0.
This is the playground link: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=bffbd7488ab03295b9c7724a32a8511c

Good catch, thanks!


Operator precedance problems

I notice that if I have vectors/matrices of same size a, b, c, then, in the following:
a + b :* c

The addition is computed first, instead of the 'expected' multiplication. Can this be fixed?

latest master/snapshots have changed the elementwise operators to be :, +:+, etc. because of the surprising precedence.


Azure is charging bandwidth consumption when sync'ing between storage accounts within the same region

Which version of the AzCopy was used?
10.4.3
Which platform are you using? (ex: Windows, Mac, Linux)
Windows VM or Azure function
What command did you run?
azcopy.exe sync "fileshare[SAS]" "filesahre[SAS]" --log-level=NONE --delete-destination=true
What problem was encountered?
Both the source and destination storage accounts exist in the same Azure region but in different subscriptions. On initial sync from an Az Func or Windows VM in the same region as the storage accounts, source had 100Gb, destination was empty. There was an unexpected bandwidth charge on the source storage account, the equivalent of 3 times the monthly fee to store the 100Gb in Azure (LRS).
.
As per MS documentation, bandwidth is charged when it leaves the region... https://azure.microsoft.com/en-au/pricing/details/bandwidth/ "i.e. data going out of Azure data centres;"
Does the AzCopy job run from a specific region?
How can we reproduce the problem in the simplest way?
Sync 100Gb using AzCopy, using azure file shares, source and destination should be in the same Azure region (subscriptions shouldn't make a difference)
Have you found a mitigation/solution?
None found
Hope you can shed some light on this - thanks

@amishra-dev This seems pretty weird.  Any ideas?

Hi @Timothyoverton
Do you have the account details for me to check. I am not an expert at this, but i can hit up a few friends to see whats going on.
Thanks

HI @amishra-dev, thanks, this was the source storage share: https://tim.file.core.windows.net/timtest

and destination?

destination file share: https://extbackuptesting.file.core.windows.net/timtest
June 9th was the date, during the day (+10 GMT)

Hi @Timothyoverton,
Can you try this again from a smaller share? Also which region is this VM in?

BTW, how sure are we that the displayed charge was a bandwidth charge, and not a transaction charge?  (I don't know enough about billing to know if this is a relevant question, but figured I'd share it anyway).

Hi,
@amishra-dev I can try it with a smaller share, 5Gb? Region is Australia East.
@JohnRusk I'm looking at Azure > Subscriptions > cost analysis > just filtering by the storageaccount > says bandwidth, see images below

Hi @Timothyoverton,
Thanks for the details, just being pedantic here, but the VM's region (where azcopy is running) is also australiaeast correct?

Also, please let me know when you have tried with the 5Gb share. Thanks

Hi, I've been using an Azure Function in Australia East to run the Azcopy, i'll try 5Gb share this morning and let you know.

To create the 100Gb share, I copied a 600mb file several times within the share, maybe that counted as bandwidth? I'm just uploading the full 5Gb now into the smaller share, this will be counted as ingress as per normal. Will see how we go.

I've found a new way to look at storage account stats in the Az Portal... the egress is where the cost lies

I'll compare this with the 5Gb share that is coming

Hi Guys, midday I ran the 5Gb azcopy using an azure function in the same region as the storage account, this was the result.
Source https://tim.file.core.windows.net/fivegbtest
Destination https://extbackuptesting.file.core.windows.net/fivegbdestination

Then, I repeated the test with another 5Gb share, to a new share, same storage accounts, but running Azcopy from a VM in the same region. This was the result
Source: https://tim.file.core.windows.net/fivegbtestfromvm
Destination: https://extbackuptesting.file.core.windows.net/fivegbtestfromvmdestination

The costing for the day cannot be queried at this stage, but based on the above, I'm going to be charged for 10Gb of egress, when the data has never left the region. Can you confirm?

Another View
Source storage account (6 hours)

Destination storage account

Hi @amishra-dev
Looks to be a false alarm, despite the Egress showing 10Gb from the storage account, I haven't been charged any further bandwidth charges for yesterday, the Egress is free as hoped. I'm running a final 50Gb test this afternoon and will double check the billing on Monday, will let you know.

Thanks for confirming @Timothyoverton.


chore: Add REUSE tool information to README

In line with SAP OSPO requirements, this PR adds the REUSE Tool links to the README
Notes:

Please register the repository with the REUSE Tool to complete the integration (see #196 and #197)

Fixes #195

Thanks for merging this PR. Please also don't forget to register your project: https://api.reuse.software/register

Thanks for merging this PR. Please also don't forget to register your project: https://api.reuse.software/register

Thanks, Sebastian for the PR. I have completed the registration and now the status reflects that this repo is complaint.


Cannot use function

I see my function and its alias in my saved queries, but when I call my function in the query editor, the function name is red underlined and the query fails.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 84d4e579-8d9a-473a-8c2f-8242942d048c
Version Independent ID: d9977efb-b617-42aa-15f0-82d35cd4df93
Content: Functions in Azure Monitor log queries
Content Source: articles/azure-monitor/log-query/functions.md
Service: log-analytics
GitHub Login: @bwren
Microsoft Alias: bwren

@chriskuech Thanks for the Comment. We are actively investigating and will get back to you soon.

@chriskuech, I have tested and tried to to reproduce your issue of getting red underline or query failure but I couldn't see any such issues.
One observed note is, even if your saved query has some condition w.r.t TimeGenerated (say for ago 7d), etc. but when you reference that saved query in another new query and run it for default time range i.e., last 24 hours then the referenced saved query executes for default time range i.e., last 24 hours but not for TimeGenetrated ago 7d (which may end up in providing zero results in case there is no related output in last 24 hours). So AFAIK as per current design, we have to explicitly give the range of time in the new query as well. @bwren, can you provide your insights on this observed note ?
@chriskuech, Other than above observed note, I don't see any issues like red underline or query failure.
At this point it appears that there's no further edits or updates needed for the documentation so I suggest you to open a thread and ask for suggestions and answers in communities like MSDN Forum or Stack Overflow for dev related queries. Or as in your case it is hard to say what is causing you to hit the issue, support would be able to determine this with more information (like what is the error that gets generated when query is failed, access related, etc.) So here are the steps to raise a support tickets with Azure technical support if you already have a support plan. But if you don't, then please send mail to<EMAIL_ADDRESS>with your subscription ID and a link of this Github thread for context and we will assist you with engaging Azure technical support.
Hope this helps!!

Assigning @bwren for insights on above observed behavior.

I don't have any insights here.  I've not been able to reproduce either.  The note that you reference has to do with the time range of the data used by the query.  Shouldn't effect whether the function works or not.

@KrishnaG-MSFT Suggest we close or assign elsewhere since this doesn't appear to be a doc issue.

#please-close

Hi, I am exactly getting the same issue reported by @chriskuech . Please investigate.
I am saving a function with alias and it is visible in Query explorer but when i call that function in log analytics query it is not coming up.

Hi, Today, I am exactly getting the same issue reported by @chriskuech and @KrishnaM . Please investigate.


fix copy-mode and keybindings with brackets

fix copy-mode removal when not in copy mode
fix: keybinding bracket commands

@sainnhe friendly reminder here!

fix copy-mode removal when not in copy mode

I also found this issue. Another way to fix is here https://github.com/sainnhe/tmux-fzf/pull/82


fix: remove missing sourcemap vue-router warnings

Description

We need to skip Nitro when using generateSW strategy with sourcemap enabled:

Linked Issues

Additional Context

[!TIP]
The author of this PR can publish a preview release by commenting /publish below.

/publish


add test case time field to models and json v 1.0

I need to look at supporting this from python 2.7 unit test. I'm not aware of any timing features that exist.. building support might be annoying

Not worried about adding into python unittest. There's support for this through junit parsing and in the puv model.


ar.read_atlas_peak(atlastype) not working if atlastype is 'desikan_killiany' str

Hi all,
While using ar.read_atlas_peak(atlastype, coordinate, prob_thresh=5) to inquire the region a voxel belongs to, we noticed that the documentation suggests atlastype should be a str.
The following code doesn't not work:
ar.read_atlas_peak(“desikan_killiany”, [10,10,10])

while the code below does work:
ar.read_atlas_peak(ar.get_atlas("desikan_killiany"),[10,10,10])

This suggests atlastype should be the atlas itself, not a string. Is that correct? If so, let me know if a PR is needed or if one of you can fire a hot fix for the documentation...
Thanks.
ps: Congrats on shipping to JOSS =)

Hi @pfdamasceno,
Thank you for pointing this out. I've corrected the function (https://github.com/miykael/atlasreader/pull/110) so that it works now with "desikan_klilliany".
And thanks about the JOSS comment, we're very happy about it :-)

Updated version can be installed with pip install -U atlasreader


NSFW no allow a cat and a white image

Potential NSFW content was detected in one or more images. A black image will be returned instead. Try again with a different prompt and/or seed.
can i fix it ?

i think i have missed something help needed
python3 server.py
Loading Model...
{'trained_betas'} was not found in config. Values will be initialized to default values.
ftfy or spacy is not installed using BERT BasicTokenizer instead of ftfy.
Finished!

Serving Flask app 'server'
Debug mode: off
WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
Running on all addresses (<IP_ADDRESS>)
Running on http://<IP_ADDRESS>:8888
Running on http://<IP_ADDRESS>:8888
Press CTRL+C to quit
Accept-Encoding: identity
Transfer-Encoding: chunked
Host: <IP_ADDRESS>:8888
User-Agent: Python-urllib/3.10
Variations: 1
Prompt: A beautiful mountain landscape in the style of greg rutkowski, oils on canvas.
Steps: 32
Seed: 1337
Sketch-Strength: 0.25
Prompt-Strength: 7.5
Content-Type: application/octet-stream
Connection: close

100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:01<00:00,  5.87it/s]
Potential NSFW content was detected in one or more images. A black image will be returned instead. Try again with a different prompt and/or seed.
<IP_ADDRESS> - - [12/Sep/2022 12:23:56] "POST /api/img2img HTTP/1.1" 200 -

you aren't missing anything--unfortunately the default Safety checker is just really strict :/
when i get back to working on the new backend this will be removed


Setup Travis continuous testing

Absolutely agreed on this. Along with a sample project, this will get a lot
of test coverage.
On Sun, Jun 14, 2015 at 3:19 PM Advay Mengle<EMAIL_ADDRESS>wrote:

Assigned #178 https://github.com/j2objc-contrib/j2objc-gradle/issues/178
to @brunobowden https://github.com/brunobowden.
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/178#event-330547727
.

As long as Travis can run j2objc and clang, yep =)

This should be much more valuable now that we have hermetic unit tests.

I just got this done for one of my other open-source projects.  I also have a dedicated account
It will be done in two steps:

A direct commit from the API account that just enables travis.


Investigate NextAuth migration

Basic Information
This may be required to support a more complex permissions system
Research into possibility:

How much needs to be changed? Backend/frontend
Does it support all features that Clerk has? NextAuth actively discourages native login and so the provider (Credentials Provider) is crippled
Does this introduce extra complexity into the database schema?
How difficult would using Clerk's metadata api be to store things like description and role?
Setting up providers -- more things to add to the env

Other Information
[Are there any additional information that we should know about?]

Next auth might take too long to migrate @justinliangg has done the completed role integration on issue 15. No further actions needed


Add Pytorch support to Rasa

What problem are you trying to solve?
Adding Pytorch models compatibility to Rasa.
What's your suggested solution?
Write a backend using Pytorch code. So, adding pytorch models will be easy.
Examples (if relevant)
No response
Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done
No response

Technically we already support PyTorch models, you'd merely need to write a custom component that uses it. Could you further elaborate what you mean by PyTorch support?

Ahhha, it makes sense. Since we just take care of inputs and outputs.
Is just adding custom component, then give it an input and take the output ?

Is just adding custom component, then give it an input and take the output ?

Most functions can be given "an input" and return "an output", so it's hard to give a directed answer to this question. You may however gain some inspiration from having a look at the implementation of custom components here. At the time of writing these components support Rasa 2.x and may serve as a starting point.

I'll close the issue for now though, since it's technically already resolved.


Frontend (client/...) restructure directory

under client, there are 3 sub folders: menu, question and a shared folder
app.html becomes question.html, which is now located in the question directory

Am unsure if I edited the config files correctly, but karma seems to be running fine, as well as e2e (though it could be that it's running okay because the config file isn't correct..).

Okay, PTAL!


CAPA architecture overview

Task
Create architecture overview page for the Cluster API AWS, equivalent to https://docs.giantswarm.io/platform-overview/cluster-management/vintage/aws/ .

We have generic docs for CAPI where we have the option of having sections different by a provider. Since the idea is having roughly same architecture across providers we keep a single doc and highlight which are the differences in areas like networking or segmentation


[Forge] Server Crash at Login. BiomeDict - MoCreatures

Getting the following crash at login https://gist.github.com/Sandriell/e4a9befbed23dcfbfdf5a818a0b9d3d8
Looks like its MoCreatures trying to check biomes for spawning. The first thing referenced is BiomeDictionary, so I am guessing this is related to the previous issues with BiomeDictionary support.
Looks like this issue over at BiomeBundle is related: https://github.com/BiomeBundle/BiomeBundle/issues/58

Thanks for the bug report, could you try v16 from https://minecraft.curseforge.com/projects/open-terrain-generator/files and tell me if that fixes the problem?

v16 did not fix it.

I've had multiple reports of the biomedict exception with different mods, have spent half a day testing but I cannot get it to crash. Do you know of a way to reproduce the bug?

Please try v17 at https://minecraft.curseforge.com/projects/open-terrain-generator/files/2413721 and tell me if that fixes the problem. Your existing worlds affected by the bug should work again with this build. Thanks!

Other users who were getting the same exception have reported it as being fixed by v17. Closing this issue, thanks for reporting!


Thordan Unreal & Thaleia raid

Hello, I dont exactly know if its by Bossmod but it also doesnt work there like before.
In the game I dont see any aoe indicators, animations or castbar on targer or enemy list. also I dont see any enemies that are targetable, boss is just teleporting and dealing dmg while I have 100% knockback resist out of nowhere.  Bossmod showing nothing, game showing nothing except the characters and actual boss.
Im wondering if its by some error of bossmod or smthin else.
Thanku for response.

Thordan unreal is supposed to be working fine (checked last week), thaleia is not implemented yet.
I'll need the logs to investigate further, please see readme on instructions.

Hey, I am so sorry, I figured it out and its not your plugin that makes the thing.
It was some setting in Penumbra.


Need a way to determine 'output pools'

When a user wants to mix coins we need a way to show what possible output denominations are available for other users to join the mixing.
Either set this on the server side or allow users to propose them.
For example: If Alice has 0.21 BTC that she wants to mix she could either select a mix from the server (which may show '0.1 BTC output pool', '0.2 BTC output pool' etc) or she may propose a pool somehow (maybe from the post-mix wallet?) - by proposing a 0.21 BTC pool that other users could then see and join if the wanted to.
If for example the following were submitted/proposed:
0.21 BTC
0.22 BTC
0.30 BTC
The server could create a mix where all outputs were 0.21 BTC if there was not already sufficient liquidity to cover the 3 proposals. So the users that had proposed the above could all join the 0.21 BTC mix with the seconds and third users getting change of 0.01 BTC and 0.1 BTC respectively to their pre-mix wallet.

For now it's just a tumbler configuration. This not only not needed to be figured out in implementation time, it's the tumbler operator who must decide.
However I was long thinking introducing some kind of dynamic denomination, something similar you proposed here, but that needs some thoughtful considerations, because this would come with some GUI challenges. The GUI wouldn't be able to estimate fees, number of rounds and time of mixing upfront. Luckily, it's just a server configuration, easy to change later.
At the beginning however we should start with a common denomination per mix and stick with it as long as we reach stable hundredish anonymity set.
Anyway it was a braindump, we'll need to think of it further.


[main] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc knative-sandbox/client-writers
/assign knative-sandbox/client-writers
Produced via:
./hack/update-deps.sh --upgrade --release v0.22
./hack/update-codegen.sh

Details:
bumping knative.dev/client 43b669f...c628423:
  > c628423 Use context.Context in API methods (# 1274)

/ok-to-test


Adding TopWikipediaSessions integration test

This test should run with postcommits.

@Ardagan and I had a chat offline, and I need to look into what Andrew recommended me to do. Give me a couple weeks to get to this again.


[PT Run] Not able to search the Name of a localized shortcut

Windows: 10.0.18363
PT: 0.18.1
Module: PT Runnet

In german windows we have a shortcut called 'Editor' who reference to 'notepad.exe'.
If I search notepad I see this shortcut as Notepad in the results.
But if I search for Editor nothing is found.

Issue still exist in 0.19.

closing this against #4145


build error becaseof the 'mock-core-js' plugin

when I build, occurs an error:

I found the reason is the mock-core-js in vite-plugin-mdx which transform the 'core-js' into empty

why need this plugin? can it removed?

i issue the wrong repo, the correct is : https://github.com/storybookjs/builder-vite/issues


Ref doc gen: Format user directory as ~ and use forward slashes

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/derekbekoe/azure-cli-extensions.git@help-gen-user#subdirectory=src/$EXT&egg=$EXT"


15538 Fixed restoration type layout and validation issues

Issue #: bcgov/entity#15538
Description of changes:

app version = 5.11.20
imported latest shared Approval Type component
fixed approval type layout
refactored approval type validation
refactored restoration type validation
fixed restoration business name layout

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-create-dev--pr-735-kkbs1pvw.web.app

/gcbrun


BUG? ValueError("Too Much Spent")

Is this correct? Why is it >=?
Maybe I've misunderstood?
if not self.utxos[tx.parent].amount >= tx.amount_spent():
                raise ValueError("Too Much Spent")

https://github.com/JeremyRubin/tinycoin/blob/master/chain.py

Hey! Thanks for taking a look -- the tinycoin project is really just a toy for educational purposes, and has no sort of pretension around being correct.
In this case, I do believe it is correct.
What we're saying is as follows:
If the paren't amount is NOT greater than or equal to the amount spent, throw an error.
This is invertible to saying that the tx.amount_spent() should be less than the parent amount.
Thanks for taking a look!

Ah, I must've missed the not without parens and forgotten the precedence of operations.
not 0 >= 0  # False
not (0 >= 0)  # False
(not 0) >= 0  # True

Is there any good reason to specify the expression with the extra boolean instead of just inverting the comparison?
AFAIU, the black code formatter doesn't attempt to simplify these but does do pep8ification.

I wrote it that way at the time because I thought it was more clear. If you want to do a PR here, with whatever cleanups happy to take them but this project is essentially archived :)

I'd hate to impose a particular style guide and add my name to the git blame for like every line here.

It's not an actively maintained project at all -- it's just an educational resource. If you care to make it better and more accessible, I'm happy to have your commits (I just won't have that much time to do thorough review)


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.12.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore(SetTheory/Ordinal/Basic): deprecate results on WellOrder

This PR is analogous to #18205.

Sorry, I'm not sure I understand why it is analogous to https://github.com/leanprover-community/mathlib4/pull/18205. Are you planning of eventually getting rid of WellOrder?

WellOrder is an implementation detail. The preferred form of the quotient constructor is type r, and we should never be using anything like ⟦⟨α, r, wo⟩⟧.

bors merge


TechDocs: Write instructions on how to use the URL preparer (and dir preparer)

Feature Suggestion

Write a tutorial page with instructions on how one can use the URL preparer for TechDocs. The default preparer is git which uses git clone to download the files and generate docs from. The URL preparer (thanks to @hooloovooo) is much faster and uses the Source Code Hosting Provider (e.g. GitHub)'s API to download files.
Also, there is a dir preparer that can be used to build docs from a local directory. Write a short guide on how can one build docs from a local directory.
Possible Implementation

Add a tutorials or guides section along with https://backstage.io/docs/features/techdocs/techdocs-overview
Context

See the discussion https://discord.com/channels/687207715902193673/714754240933003266/783710216000372737
Give an app-config.local.yaml example for dir: preparer.

URL Reader's docs are here https://backstage.io/docs/features/techdocs/how-to-guides

URL Reader's docs are here https://backstage.io/docs/features/techdocs/how-to-guides


Typescript compilation fails (Cannot find type definition file for 'ws' / 'request')

Expected behaviour
When importing this lib in a typescript project, we should be able to compile using the libs types.
Actual behaviour
node_modules/twitch-js/index.d.ts:9:23 - error TS2688: Cannot find type definition file for 'ws'.

9 /// <reference types="ws" />
                        ~~

node_modules/twitch-js/index.d.ts:10:23 - error TS2688: Cannot find type definition file for 'request'.

10 /// <reference types="request" />
                         ~~~~~~~

node_modules/twitch-js/index.d.ts:13:56 - error TS2307: Cannot find module 'request'.

13 import { RequestCallback, Options as ApiOptions } from 'request';
                                                          ~~~~~~~~~

Steps to reproduce
From a new folder:

npm init
npm install -D typescript twitch-js
create a file index.ts containing:

import { Client } from "twitch-js";

export function test() {
  const c = new Client();
}

.\node_modules\.bin\tsc .\index.ts

It outputs the error above.
Maybe this is a case where @types/request and @types/ws should be moved from devDependencies to dependencies? like described here: https://stackoverflow.com/a/46011417/1245409
Your environment

Operating system(s): Windows 10
TwitchJS version: 1.2.16
NodeJS version: 10.13.0

Can you try to add @types/ws and @types/request in your devDeps project?

Yes, I can confirm that it successfuly compiles when I add those types myself

This is a regression after #180, and potentially fixed by #183.
To continue https://github.com/twitch-apis/twitch-js/pull/180#issuecomment-439572392 and  @thomaslule suggestion, what are the downsides to adding @types/ws and @types/request to the dependencies.
Adding documentation is nice, but people never read the docs 😀


[Fix] Docker image not found when running locally

Making the local image's name fixed

Docker image name should be fixed with this PR (ref)


ssr + useFetch not revalidating after upgrade from 3.3.3 to 3.4.3

Environment

Operating System: Darwin
Node Version:     v16.20.0
Nuxt Version:     3.4.3
Nitro Version:    2.3.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      routeRules
Runtime Modules:  -
Build Modules:    -

Reproduction

nuxt.config.ts

    routeRules: {
        '/**': { swr: 5 }
    }

server route

export default defineEventHandler(async (event) => {
  return new Date().toISOString()
})

fetch data using useFetch

<template>

Date: {{ data }}

</template>

https://stackblitz.com/edit/github-ugjk5d?file=nuxt.config.ts
Describe the bug
rendered html is not changed after cache expiration and uses same NUXT payload
Additional context
3.3.3 this working corectly
3.4.0 - 3.4.3 not working
Logs
No response

Same issue? https://github.com/nuxt/nuxt/issues/20630

tested latest nuxt 3.6.2 and it working correctly


[QA] UI doesn't revert to original style after users click Toggle All and repeats the action

To Reproduce
Steps to reproduce the behavior:

Open PSAT from DevTools
Visit any frame
Right click on any column header
Click on "Toggle All" option
Now, there will be only on column present with "Name"
To get all the columns back, again right click on "Name" column and click on "Toggle All" option
Observe UI which is completely distorted.

Expected behavior
The table columns should get its original style
Screenshots
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/8092f5a0-522f-48a4-b1de-acb5b4e4c5ab
Test Environment
1. Chrome - New instance
2. Chrome version: - Version <IP_ADDRESS> (arm64)
3. OS - MacOS (arm64)
4. PSAT - V0.4.0

@mayan-000 Could you please check the below scenario where I have tried to show case the use case of toggling the random columns and how it shrinks the Domain columns width.
Visual
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/e490428f-6558-4bc8-a06f-491d32c4b962
Screenshot

@mayan-000 This looks good now.

@mayan-000
For CLI I accidentally came to this scenario and found that UI fails to revert back to it original style while toggling the columns otherwise it looks.
Please check the below visual.
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/5489eb85-0be3-429b-8655-c03acb35000b

@mayan-000 The issue mentioned here seems working fine now. However, I have found that with the latest code pull, the vertical scroll bar is missing from PSAT Extension along with CLI.
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/f8695c65-1d4d-4bff-b6d2-f4b18c757469

[ ] The table border is not properly visible the horizontal scroll is present.

Steps to reproduce:
Open any frame and do the horizontal scroll.

[ ] The blank table is visible for few seconds even though the cookies count and cookies are present while loading the page.

Steps to reproduce:

Open any site and visit any site.
Observe on the first frame for first few seconds the cookies table will not shown.

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.01.30-13_02_14.webm

This has been addressed in V.0.5.0 Release.


Feature working cookiebot

Added ignore tags to every script on frontpage.
Note that the last commit is untested. This is only included to show how a Cookiebot report page could be created.

I'll just make the changes now -- i have the time :smile:


ng build --optimization, default value is not TRUE

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
even though the documentation claims the default value is TRUE, none of the script files are minimized without "--optimization true" parameter.
Minimal Reproduction
run ng build
check vendor.js or main.js
Exception or Error
No response
Your Environment
Angular CLI: 16.1.6
Node: 19.8.1 (Unsupported)
Package Manager: npm 9.6.4
OS: darwin arm64

Angular: 16.1.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1601.6
@angular-devkit/build-angular   16.1.6
@angular-devkit/core            16.1.6
@angular-devkit/schematics      16.1.6
@angular/cli                    16.1.6
@schematics/angular             16.1.6
rxjs                            7.8.1
typescript                      5.1.6
zone.js                         0.13.1

Anything else relevant?
No response

This is most likely caused by customized configuration for the project within the workspace angular.json file.  If there is a vendor chunk and the chunks do not contain hashes then the project is probably building a development configuration by default.
The following is the contents of the build target for a newly generated v16 project:
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "dist/test-project",
            "index": "src/index.html",
            "main": "src/main.ts",
            "polyfills": [
              "zone.js"
            ],
            "tsConfig": "tsconfig.app.json",
            "assets": [
              "src/favicon.ico",
              "src/assets"
            ],
            "styles": [
              "src/styles.css"
            ],
            "scripts": []
          },
          "configurations": {
            "production": {
              "budgets": [
                {
                  "type": "initial",
                  "maximumWarning": "500kb",
                  "maximumError": "1mb"
                },
                {
                  "type": "anyComponentStyle",
                  "maximumWarning": "2kb",
                  "maximumError": "4kb"
                }
              ],
              "outputHashing": "all"
            },
            "development": {
              "buildOptimizer": false,
              "optimization": false,
              "vendorChunk": true,
              "extractLicenses": false,
              "sourceMap": true,
              "namedChunks": true
            }
          },
          "defaultConfiguration": "production"

"optimization": false, in the development configuration is the only time optimization is specified.


Patch vulnerabilities

@QiJin-Bouvet Ready for test. It's a minor upgrade to our socket packages which affects the live collaboration feature.

Tested with commit 77be156 in TEST env.
Live function works good.


Add MIT licence

For reference: https://choosealicense.com/licenses/mit/
Please follow the contribution guidelines.

I would like to take this one.
In addition to requiring to follow the contribution guidelines,
is it adding a LICENSE file would be fine? Do I need to add the header for every js file stating the license terms?


Setter on variables that contains an instance are triggered while setting a property of this instance if using a one liner

Godot version
3.3.2 stable
System information
Win10
Issue description
I'm having this setup on a game I'm working on, a Singleton CtrlPopulator with :
[...]

var actual_consumer setget setActual_consumer

[...]

# SET/GET
func _setActual_consumer(consumer):
	print("in actual_consumer setter with %s" % consumer)
	actual_consumer = consumer
	if actual_consumer != null:
		actual_consumer.change_state_to("GoToBar")

at some point :
CtrlPopulator.actual_consumer.given_cocktail = CtrlPlayerController.PlayerCamera._Cocktail.duplicate()

is called, this is triggering the setter from the singleton and the print up here will trigger within console on the 8th line after  system and engine description :
in actual_consumer setter with [KinematicBody:1770]
[KinematicBody:1770] changing state to GoToBar
transition: IfConsumerAlreadyPresent
transition: IfNearEnough
[KinematicBody:1770] changing state to RequestBeverage
transition: IfReceivedCocktail
transition: IfDiscontent
in actual_consumer setter with [KinematicBody:1770] # << this is not normal
[KinematicBody:1770] changing state to GoToBar
# ...

Steps to reproduce

clone this demo : https://github.com/Moltenhead/The-Space-Bar-demo.git
launch the game
when the little character arrives and have a bubble upon his head press up key (z/w/up arrow)
select any ingredient using left, up or right direction + space bar (directions are wasd keys or zqsd or arrows)
mash space bar until progress bar is full

The little character will go right. This is due to the bit of code shown up triggering the setter of actual_consumer from the singleton CtrlPopulator.gd. The console will print the details :
in actual_consumer setter with [KinematicBody:1619]
[KinematicBody:1619] changing state to GoToBar
transition: IfConsumerAlreadyPresent
transition: IfNearEnough
[KinematicBody:1619] changing state to RequestBeverage
transition: IfReceivedCocktail
transition: IfDiscontent
in actual_consumer setter with [KinematicBody:1619]
[KinematicBody:1619] changing state to GoToBar
transition: IfConsumerAlreadyPresent
transition: IfNearEnough
[...]

The in actual_consumer setter with [KinematicBody:1619] is not supposed to trigger on line 8.
Now if you replace the code in :
res://Assets/Scripts/Controllers/ctrl_PlayerController.tscn
at line 151 :
-               CtrlPopulator.actual_consumer.given_cocktail = CtrlPlayerController.PlayerCamera._Cocktail.duplicate()
+               var consumer = CtrlPopulator.actual_consumer
+               consumer.given_cocktail = CtrlPlayerController.PlayerCamera._Cocktail.duplicate()

The precedent call to the setter will not happen if you redo the same exact operation in game, and the little character will go back where he came from. The previous print will not appear at the 8th console line.
Minimal reproduction project
https://github.com/Moltenhead/The-Space-Bar-demo.git

Don't hesitate to DM me on the godot discord if you need guidance on the code - same nickname.

Confirming this issue. I'm seeing the same thing in 3.3.2. Any time I directly set a property on an object to which I have assigned a setter, the setter is called. If I first assign the object to another variable, then set the property, the setter is not triggered.

It sounds similar to the issues mentioned in https://github.com/godotengine/godot/issues/38221#issuecomment-628679879.

Duplicate of #28720 and/or #31245.


fix(Navis): Localised versions of Navis will now correctly build the commit object

Fixes: #2893
Description & motivation
Non-anglicised installations of Navisworks could not send geometry.
Changes:

Prior Base object type conversion was tied to a localised string "Geometry" // me == dumbass

Changed logic to a switch on HasGeometry as a method

Extracted CategoryToSpeckle method into a new ConvertModelItemToSpeckle method

Added helper methods: FindCategoryProperty, GetCategoryDisplayName, CreateSpeckleObject

Updated comments for clarity and documentation<!---

Screenshots:

Validation of changes:
I have run the application in various Latin and non-Latin language modes - all produced success.
Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[x] I have updated or added relevant documentation.

We've all used localized strings at some point ;)


Minimal PR for ownCloud core

My current plan is:

[x] display contacts from ScienceMesh in files-sharing auto-complete
[ ] when selecting a ScienceMesh contact as a sharee, create the outgoing share via Reva
[x] incoming shares look the same as regular OCM shares

When done, ping OC customers within the consortium so they can push for it to be reviewed.

Working on this in https://cs3org-ocmtestsuite-3s47veqh1p5.ws-eu81.gitpod.io/ and https://github.com/owncloud/core/compare/master...pondersource:core:sciencemesh-minimal?expand=1

And https://github.com/cs3org/ocm-test-suite/tree/oc-pr-testing

For the search, we can copy the approach from https://github.com/SURFnet/rd-sram-integration/issues/41

Got it working on the ShareesController side, now working on  https://github.com/pondersource/oc-sciencemesh/pull/new/search-plugin-for-minimal

The config for the ShareProviderFactory takes care of the second point.


Documentation error on readme: inet-interfaces

The documentation on the readme describes how to create a role for a relayhost, and defines the override attributes as part of that role. One of those overrides lists "inet-interfaces" => "all". This option in postfix should use an underscore, not a dash.
Directly copy/pasting this role, without fixing the typo, results in:
grep interfaces /etc/postfix/main.cf
inet-interfaces = all
inet_interfaces = loopback-only

Thanks for reporting this documentation issue. I've fixed the README.


[Onboard quorum driver to fullnode] 2/n add execute transaction end points

In this PR we add execute_transaction endpoint in fullnode.

add QuorumDriverApi since its execution_transaction function's signature is different from RpcGatewayApi, including param list and result type
FN enable this api by default.

Next:

e2e test
metrics
eagerly update txns from quorum driver(?)

see also:
https://github.com/MystenLabs/sui/pull/3778

I'm curious what our story is about equivocation prevention as we move to deprecate gateway

I'm curious what our story is about equivocation prevention as we move to deprecate gateway

Best I've heard is potentially resolving them at epoch change

We will need to do this in gateway->sdk because a user should not be able to easily trigger equivocation through normal operations, and a user should be able to send multiple transactions in parallel that use different gas objects.

But of course in the end at epoch boundary we will also be able to remove any object locks as well, but that's a last resort


SafeFactory.deploySafe should have the option to add modules to a safe on deploy

Context / issue
To improve the user experience of deploying new safes within applications for AA.
In case your feature request related to a problem, please add clear and concise description of what the issue is.
Users have to make too many transactions to prepare a Smart Account for usage as a bundler.
Please add a clear and concise description of what you want to happen.
SafeFactory.deploySafe should have an additional modules: string[] option that is passed to the setup of the safe and automatically enabled after deployment, without requiring a second transaction.
Please add a clear and concise description of any alternative solutions or features you have considered.
Keep the user-experience poor.

You can do this by passing suitable to and data arguments to deploySafe, and adding the follwoing to your module:
import<EMAIL_ADDRESS>
contract MyAwesomeModule {
    ...
    // Can only be called as delegatecall from a GnosisSafe during setup.
    function enableModule(address module) external {
        address payable thisAddr = payable(address(this));
        GnosisSafe(thisAddr).enableModule(module);
    }
   ...
}

then you first create your module, then deploy:
       const iface = new ethers.utils.Interface(["function enableModule(address module)"]);
       const safeAccountConfig: SafeAccountConfig =  {
           owners: owners,
           threshold: <threhold>,
           to: myAwesomeModule.address,
           data: iface.encodeFunctionData("enableModule", [myAwesomeModule.address])
       };

       safe = await safeFactory.deploySafe({ safeAccountConfig });

it will delegatecall into your module while allowing you do to anything as initial set up of the Safe.

You can do this by passing suitable to and data arguments to deploySafe, and adding the follwoing to your module:
import<EMAIL_ADDRESS>
contract MyAwesomeModule {
    ...
    // Can only be called as delegatecall from a GnosisSafe during setup.
    function enableModule(address module) external {
        address payable thisAddr = payable(address(this));
        GnosisSafe(thisAddr).enableModule(module);
    }
   ...
}

then you first create your module, then deploy:
       const iface = new ethers.utils.Interface(["function enableModule(address module)"]);
       const safeAccountConfig: SafeAccountConfig =  {
           owners: owners,
           threshold: <threhold>,
           to: myAwesomeModule.address,
           data: iface.encodeFunctionData("enableModule", [myAwesomeModule.address])
       };

       safe = await safeFactory.deploySafe({ safeAccountConfig });

it will delegatecall into your module while allowing you do to anything as initial set up of the Safe.

Perfect, thanks.

hey guys, I have a doubt related to the method being used here for enabling a module.
As per the discussion:

This works. Function A is called successfully.

But this doesnt, when I wrap my module behind a proxy. Function is not called at all in this case.

Am I missing anything?
@froggiedev @valeryz