Cannot vendor k8s httplog

Sample code:
package main

import (
	"io/ioutil"
	"os"

	_ "k8s.io/kubernetes/pkg/client/metrics/prometheus" // for client metric registration
	"k8s.io/kubernetes/pkg/kubectl/cmd"
	cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
	_ "k8s.io/kubernetes/pkg/version/prometheus" // for version metric registration

	"github.com/spf13/cobra/doc"
)

func main() {
	kubectl := cmd.NewKubectlCommand(cmdutil.NewFactory(nil), os.Stdin, ioutil.Discard, ioutil.Discard)
	doc.GenMarkdownTree(kubectl, "./")
}

End of trash -u output:
INFO[0318] Checking out 'k8s.io/apiserver/pkg/httplog', commit: 'master'
INFO[0318] Fetching latest commits from 'origin' for 'k8s.io/apiserver/pkg/httplog'
ERRO[0318] `git fetch -f -t origin` failed:
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

FATA[0318] fetch failed                                  i={Package:k8s.io/apiserver/pkg/httplog Version:master Repo:}

Try to remove trash cache: rm -fr ~/.trash-cache.

That worked - Can you explain why the cache was at fault here?
Perhaps there should be a purge cmd for the cache?

I'm getting the same error message for other packages, and removing the cache doesn't help. This happens on a fresh machine without ever having had trash run before but from a repo that has been in development for some time.


html-preview: update selectors

Fixes for GitHub HTML Preview stopped working due to new selectors

Thanks for the help!


Relation between did-id and peer-id

I would like to rise this issue to the team members to share their opinions on the following issue.
Morever, since this question is more related to the fula app use cases, kindly ask you to pay attention [@keyvan-m-sadeghi, @ehsan6sha , and @farhoud].
In a previous team meeting, @masih came up with the idea of making a relation between a did-id and a peer-id, and I started working on that.
So far, I have started working on two solutions.  Relation between did-id and peer-id. But we will have to choose one of these.

[ ] 1 st method of generating peer-id can be based on did-id.
[ ] 2 nd, both can be independent of each other. Still, we can mapping them in the did-doc.

Note: Please also look at this issue: #59
  graph TD;
      DID-id-->Peer-id;

1st method we can generate a single peer-id based on a one unique did-id. One-to-One (One user can have one peer-id with one did-id).
  graph TD;
      DID-doc-->DID-id;
      Peer-id-1-->DID-doc;
      Peer-id-2-->DID-doc;
      Peer-id-3-->DID-doc;
      Peer-id-n-->DID-doc;;

In Method 2, you can generate a single did-id and multiple peer-ids. One-to-Many (A single user can have multiple peer-ids for each devices).
I would love for you to share your thoughts.

@ruffiano89 my only concern on number 2 is where we keep the DID-doc?

These concerns are for both cases, so I think the solution is DID providers.

@ruffiano89
I my view it's more about work we have to done:

peerId exist at least in 5 programing language
in libp2p you can access and validate it everywhere.
lot of existing protocol and libraries exist

If you can manage a way to handle access control with peerId it is more reusable.
if we go with first option can we  map multiple did to a single did as parent?
@ehsan6sha @ghorbani-m
We can use

ION
Look like we have to run some nodes and pay transaction fees for our user to give them free identity.
We can reuse box owner resource next but RPI does not have half of resource these kind of node runs on.

Q: if we go with first option can we map multiple did to a single did as parent?
A: @ehsan6sha, yes we can map multiple dids to root did.

13.07.2022. In the last sprint meeting we come up use case design as follows:

One did per user.
Group sharing identity with one group did.

Q: if we go with first option can we map multiple did to a single did as parent?
A: @ehsan6sha, yes we can map multiple dids to root did.

13.07.2022. In the last sprint meeting we come up use case design as follows:
One did per user.
Group sharing identity with one group did.


[WIP] When --start-paused is passed on flutter for web applications, don't eagerly call main

Description
As in the description. Also removes work around for error messages that isn't needed anymore. I'm not quite sure if this is sufficient for breakpoints

This isn' quite enough

@DanTup could you take a look at the one sometime this week?
I've got some of start paused working just by skipping the invocation of main. I think I can listen to resume events to figure out when to invoke it again, but that hasn't been enough to get vscode to work.

Had a quick test of this, but it didn't work. When we connect and call getIsolate() to get the state of the isolates, the isolates pauseEvent is a Resume event rather than some sort of Pause event (we expect it to be paused at the start, then we'll send breakpoints, then resume it):
[5:56:55 PM] [Observatory] [Info] ==> {"id":"7","method":"getIsolate","params":{"isolateId":"1"}}
[5:56:55 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","result":{"type":"Isolate","id":"1","number":"1","name":"http://localhost:60854/:main()","startTime":null,"runnable":true,"livePorts":null,"pauseOnExit":null,"pauseEvent":{"type":"Event","kind":"Resume","timestamp":null,"isolate":{"type":"@Isolate","id":"1","number":"1","name":"http://localhost:60854/:main()"}},"libraries":[{"type":"@Library","id":"dart:_runtime","name":"dart:_runtime","uri":"dart:_runtime"},{"type":"@Library","id":"dart:_debugger","name":"dart:_debugger","uri":"dart:_debugger"},{"type":"@Library","id":"dart:_foreign_helper","name":"dart:_foreign_helper","uri":"dart:_foreign_helper"} // ...

Full log is here in case it's useful:
Dart-Code-Log-2019-08-02 17-56-04.txt

There's an issue here with PauseStart unticked - I don't know if this means dwds doesn't support this yet? (cc @grouma)
https://github.com/dart-lang/webdev/issues/166

Is this a specific event we need to handle?
We have the infrastructure to support this. See:
https://github.com/dart-lang/webdev/blob/a8451a935db8f3821dd1cd279f5510850dfdb065/dwds/lib/src/connections/app_connection.dart#L23

Is this a specific event we need to handle?

I think it's the isolate state that's wrong. If I run with --start-paused and then call getIsolate() through the VM service, the pauseEvent of the isolate should be in one of the paused states (IsolateStart?), but it's currently in the Resume state (suggesting it's running and not paused).

(FWIW my understanding of how it works is mostly based on just debugging and trying to make things work against the VM, it may be better to try and find a more official source for the lifecycle of these things in the VM, if one exists!)

Please open a tracking issue on package:dwds.

Done! -> https://github.com/dart-lang/webdev/issues/629

@jonahwilliams dwds has been updated to set the initial state to PauseStart - I'm not familiar with how that gets to here - do we need to wait for a release of dwds and then update pubspec references?

It should be up to date, I can give this a poke this week

With the updates here I'm getting to another vmservice method, but we don't seem to be hitting the resume as expected:
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","event":{"type":"Event","kind":"ServiceRegistered","timestamp":null,"service":"hotRestart","method":"hotRestart"}}}
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","result":{"type":"Isolate","id":"1","number":"1","name":"http://localhost:62127/:main()","startTime":1568078589403,"runnable":true,"livePorts":0,"pauseOnExit":false,"pauseEvent":{"type":"Event","kind":"PauseStart","timestamp":1568078589403},"libraries":[{"type":"@Library","id":"dart:_runtime","name":"dart:_runtime","uri":"dart:_runtime"},{"type":"@Library","id":"dart:_debugger","name":"dart:_debugger","uri":"dart:_debugger"},{"type":"@Library","id":"dart:_foreign_helper","name":"dart:_foreign_helper","uri":"dart:_foreign_helper"},{"type":"@Library","id":"dart:_interceptors","name":"dart:_interceptors","uri":"dart:_interceptors"},{"type":"@Library","id":"dart:_internal","name":"dart:_internal","uri":"dart:_internal"},{"type":"@Library","id":"dart:_isolate_helper","name":"dart:_isolate_helper","uri":"dart:_isolate_helper"},{"type":"@Library","id":"dart:_js_helper","name":"dart:_js_helper","uri":"dart:_js_helper"},{"type":"@Library","id":"dart:_js_mirrors","name":"dart:_js_mirrors","uri":"dart:_js_mirrors"},{"type":"@Library","id":"dart:_js_primitives","name":"dart:_js_primitives","uri":"dart:_js_primitives"},{"type":"@Library","id":"dart:_metadata","name":"dart:_metadata","uri":"dart:_metadata"},{"type":"@Library","id":"dart:_native_typed_data","name":"dart:_native_typed_data","uri":"dart:_native_typed_data"},{"type":"@Library","id":"dart:async","name":"dart:async","uri":"dart:async"},{"type":"@Library","id":"dart:collection","name":"dart:collection","uri":"dart:collection"},{"type":"@Library","id":"dart:convert","name":"dart:convert","uri":"dart:convert"},{"type":"@Library","id":"dart:developer","name":"dart:developer","uri":"dart:developer"},{"type":"@Library","id":"dart:io","name":"dart:io","uri":"dart:io"},{"type":"@Library","id":"dart:isolate","name":"dart:isolate","uri":"dart:isolate"},{"type":"@Library","id":"dart:js","name":"dart:js","uri":"dart:js"},{"type":"@Library","id":"dart:js_util","name":"dart:js_util","uri":"dart:js_util"},{"type"…
[6:23:11 PM] [Observatory] [Info] ==> {"id":"8","method":"setExceptionPauseMode","params":{"isolateId":"1","mode":"None"}}
[6:23:11 PM] [Observatory] [Warn] No thread for pause event
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","event":{"type":"Event","kind":"ServiceRegistered","timestamp":null,"service":"fullReload","method":"fullReload"}}}
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","event":{"type":"Event","kind":"ServiceRegistered","timestamp":null,"service":"ext.dwds.screenshot","method":"ext.dwds.screenshot"}}}
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Service","event":{"type":"Event","kind":"ServiceRegistered","timestamp":null,"service":"reloadSources","method":"reloadSources"}}}
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","result":{"type":"Success"},"id":"8"}
[6:23:11 PM] [Observatory] [Info] ==> {"id":"9","method":"setExceptionPauseMode","params":{"isolateId":"1","mode":"None"}}
[6:23:11 PM] [Observatory] [Info] <== {"jsonrpc":"2.0","result":{"type":"Success"},"id":"9"}
Mon Sep 09 2019 [18:23:21 GMT-0700 (Pacific Daylight Time)] Log file ended

No thread for pause event

I'm improved this error a little now. It happens because the isolate field is missing on the PauseEvent object in the response to getIsolate:
==> {"id":"7","method":"getIsolate","params":{"isolateId":"1"}}
<== {
	"jsonrpc": "2.0",
	"result": {
		"type": "Isolate",
		"id": "1",
		"number": "1",
		"name": "http://localhost:60506/:main()",
		"startTime":<PHONE_NUMBER>585,
		"runnable": true,
		"livePorts": 0,
		"pauseOnExit": false,
		"pauseEvent": { // <------ No isolate ref on here
			"type": "Event",
			"kind": "PauseStart",
			"timestamp":<PHONE_NUMBER>585
		},
		"libraries": [/*SNIP*/],
		"breakpoints": [],
		"exceptionPauseMode": "none",
		"rootLib": {
			"type": "@Library",
			"id": "package:flutter_gallery/main_web_entrypoint.dart",
			"name": "package:flutter_gallery/main_web_entrypoint.dart",
			"uri": "package:flutter_gallery/main_web_entrypoint.dart"
		},
		"extensionRPCs": []
	},
	"id": "7"
}

In the VM, the isolate ref is included:
"pauseEvent": {
	"type": "Event",
	"kind": "PauseStart",
	"isolate": {
		"type": "@Isolate",
		"id": "isolates\/1241700780580311",
		"name": "main",
		"number": "1241700780580311"
	},
	"timestamp":<PHONE_NUMBER>694
},

In this instance (where we called getIsolate) we could code around this, but since there are multiple debugger implementations I think it would be better to have the behaviour aligned? (cc @grouma).

If I work around that locally, I then hit this error when it starts sending breakpoints:
[1:46:18 PM] [Observatory] [Error] NoSuchMethodError: The getter 'id' was called on null.
Receiver: null
Tried calling: id
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      ChromeProxyService.addBreakpointWithScriptUri (package:dwds/src/services/chrome_proxy_service.dart:182:51)
<asynchronous suspension>
#2      VmServerConnection._delegateRequest (package:vm_service/vm_service.dart:911:51)
<asynchronous suspension>
#3      _rootRunUnary (dart:async/zone.dart:1132:38)
#4      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#5      _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)
#6      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)

The requests look like this:
[1:46:10 PM] [Observatory] [Info] ==> {"id":"608","method":"addBreakpointWithScriptUri","params":{"isolateId":"1","scriptUri":"file:///Users/dantup/Dev/Google/flutter/examples/flutter_gallery/lib/gallery/app.dart","line":64}}
[1:46:10 PM] [Observatory] [Info] ==> {"id":"609","method":"addBreakpointWithScriptUri","params":{"isolateId":"1","scriptUri":"file:///Users/dantup/Dev/Google/flutter/examples/flutter_gallery/lib/demo/animation/home.dart","line":495}}
[1:46:10 PM] [Observatory] [Info] ==> {"id":"610","method":"addBreakpointWithScriptUri","params":{"isolateId":"1","scriptUri":"file:///Users/dantup/Dev/Google/flutter/examples/flutter_gallery/lib/demo/animation/home.dart","line":496}}

Open up some tracking issues on package:dwds and I'll work on them.

Thanks - I opened:

https://github.com/dart-lang/webdev/issues/656 - pause events should include isolate references
https://github.com/dart-lang/webdev/issues/657 - "getter 'id' was called on null" when calling addBreakpointWithScriptUri

@grouma

Also can you share a version of VS Code so I can test this behavior locally?

Sorry, missed this. You shouldn't need a special build, if you enable the web stuff in Flutter (be on master, and run flutter config --enable-web) then Chrome will show up as a device. If you hit F5 to run, it'll try and run and debug as usual (you may wish to enable the Observatory logfile or run Dart: Capture Logs and tick Observatory to get a log of all the communication over the VM service).

@DanTup is there a way to configure VS Code to run Flutter from source?
Something like this:
 dart /usr/local/google/home/grouma/flutter/packages/flutter_tools/bin/flutter_tools.dart run -d chrome -v

You can't fun a "flutter project" like that because it wants to invoke flutter, though if you open the flutter_tools repo you could run it that way (because you're just running a Dart script). I have a launch.json I use when hacking on flutter_tools so I can easily step through and debug flutter_tools:
{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Dart",
			"program": "bin/flutter_tools.dart",
			"request": "launch",
			"type": "dart",
			"args": [
				"doctor"
			]
		}
	]
}

I change the args here to match what I want to run. Then when pressing F5 it'll run with the debugger attached. Does that help?

(you can set cwd for the current directory as well as the args btw)

Hmmm. I don't think that's what I want. I want to run a Flutter web application through VS code but using Flutter Tools from source. This way I can make changes to the Flutter Tools and validate that breakpoints / other IDE features work.

Hmmm. I don't think that's what I want. I want to run a Flutter web application through VS code but using Flutter Tools from source. This way I can make changes to the Flutter Tools and validate that breakpoints / other IDE features work.

Ah, got it. There's no built-in way to do that now. I usually just delete the flutter_tools.snapshot file and it rebuilds. It's not as fast as running from source but it's not something that I've done enough to add support for (I don't think it'd be difficult to have as a setting if it happens a lot though).
Potentially you could also just hack the flutter script to not generate/use a snapshot and invoke it from there, though I haven't tried it!

@jonahwilliams looks like the breakpoint issue is resolved with https://github.com/flutter/flutter/pull/41805. I tried to test with this one too (without it there's a race with setting breakpoints) but wasn't sure how to resolve all the conflicts - if you can rebase this, I can re-test them together.

@DanTup I'll push  a new PR, this one got pretty stale

Closing in favor of the PR linked above


:sparkles: Implements Upsyncer Virtual Workspace

Summary
Implementation of a VirtualWorkspace for the Upsync of resources (Downstream to Upstream).

Refactor the syncer virtual workspace to return multiple workpsaces
New Upsync VW
Transformations for the Upsync VW.

Related issue(s)
Fixes https://github.com/kcp-dev/kcp/issues/2141

In addition to the last comments I added, we should rewrite history with just the meaningful commits before merging.

OOMKilled let's see if it was a flake or there's something broken
/retest

/retest

/approve


Eqprs models and upload functionality (v2)

Task status is not reflected when task completes

This file should have matched at least on Basic Education department because I changed 2022-23 to 2018-19 and have that department in 2018-19 but it couldn't find the department.
NationalInstitutionsOversight.csv


[SPARK-13548][BUILD] Move tags and unsafe modules into common

What changes were proposed in this pull request?
This patch moves tags and unsafe modules into common directory to remove 2 top level non-user-facing directories.
How was this patch tested?
Jenkins should suffice.

cc @srowen are there other things we can easily do?

Test build #52174 has started for PR 11426 at commit 0c967cc.

I like this -- I assume common is for modules that don't even depend on Spark Core and could even be separated from Spark. That seems true of both of these, so, OK.
The next change I'd suggest is putting extras/* into external, and likewise for both docker* modules.
The only weird thing there is that java8-tests isn't exactly "external". I suppose it goes away as soon as Spark requires Java 8, so if it's odd, at least it won't last too long.
I'd also like to unify the various "config / build / binary" dirs, but that's going to be a little more disruptive or need more discussion about the theory.

Test build #52174 has finished for PR 11426 at commit 0c967cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52174/
Test FAILed.

"I suppose it goes away as soon as Spark requires Java 8, so if it's odd, at least it won't last too long."
That's probably at least one year away...!

Test build #2596 has started for PR 11426 at commit 0c967cc.

Test build #2596 has finished for PR 11426 at commit 0c967cc.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #2597 has started for PR 11426 at commit 0c967cc.

Test build #52248 has started for PR 11426 at commit f953d03.

Test build #52248 has finished for PR 11426 at commit f953d03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52248/
Test FAILed.

Test build #2597 has finished for PR 11426 at commit 0c967cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #2598 has started for PR 11426 at commit f953d03.

Test build #2598 has finished for PR 11426 at commit f953d03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Alright merging this in master.


Single-page mode

For those that want to convert the whole book to a PDF or read it cover to cover.

Probably not worth the effort. Few will read in one sitting, and changing chapters is not hard.


how to predict

when i want to predict, I found that it's impossible to input the test_trgs because it doesn't exist actually ... so how should I predict a sample?

Hello @shaomai00, thank you for your interest in this short project. The textual corpus was the contribution of someone else in my experiment with Keras. I can ask and see if I can put it in my github repository. But as a short explanation: this text is a generated text, built based on a simple syntactic rules. These rules produce two languages which have different tree structures at the end so the translation would be about learning how to translate underlying trees.

ok,thank you. And my new question is I found the encoder_decoder model's input needs [src_input, trg_input] ,after I fit a model, I realized that if I want to predict, I must feed the trg_input which doesn't exsit (when I predict a sentence,I only have src...). So how could that be possible? should I change the model's structure?

Aha, ok! So the solution is that you start from an empty target sentence with just start marker  in the sentence. Then during the training time you move forward and predict word by words.

I got it! thank you for your explanation~


Checkbox does not support disable

Unless there is something I am missing, I don't see anyway to use the disable attribute nor the ng-disable directive with this.

See the Index.html for an example using the ng-disabled attribute,

ng-disabled wasn't working for me when I tried it, but that could very well be on my usage. As long as there's docs suggesting it should work, I'm satisfied. Thanks!


Integrate eslint-plugin-redos to Prevent ReDoS Vulnerabilities

Background
In light of recent issues and pull requests, specifically Issue #2609 and PR #2824, there's a growing need to proactively prevent Regular Expression Denial of Service (ReDoS) vulnerabilities in our codebase.
Proposal
To address this, I propose the integration of eslint-plugin-redos into our development workflow. This plugin will help us identify potentially vulnerable regex patterns in our code, thereby preventing possible ReDoS attacks.
Implementation
The integration involves adding eslint-plugin-redos to our package.json and configuring it according to our project's coding standards. The official documentation for eslint-plugin-redos can be found here, which provides detailed instructions on how to use and configure the plugin effectively.
Expected Impact
By implementing this plugin, we can enhance the security and robustness of our application, ensuring that similar issues to those addressed in Issue #2609 and PR #2824 are mitigated before they arise. This proactive approach will not only improve our code quality but also align with best practices in software development.

I appreciate this PR, but Zod's actually moving away from eslint imminently, so I'm going to close this.
Zod also now relies on a fair number of dynamically generated regexes, so I think the best approach to addressing this issue is adding runtime tests using https://www.npmjs.com/package/redos-detector or similar, which I'll do shortly in the v4 branch.


cannot drive.files.update to "addParents" with service jwt client

I have a service account and I'm using the subject param in JWT function from google-auth-library-nodejs/lib/auth/jwtclient.js. I get a 200 OK status but the parents are not actually added.
Example:

const jwtClient = new google.auth.JWT(
        key.client_email,
        null,
        key.private_key,
        [
            'https://www.googleapis.com/auth/spreadsheets',
            'https://www.googleapis.com/auth/drive'
        ],
<EMAIL_ADDRESS>);

async.waterfall(
    [
        (callback) => {
            sheets.spreadsheets.create(
                {
                    auth: jwtClient,
                    resource: {
                        properties: {
                            title: moment().format('YYYY-MM-DD')
                        }
                    }
                },
                (err, spreadsheet) => {
                    console.log(spreadsheet);
                    callback(err, spreadsheet.spreadsheetId)
                }
            )
        },
        (spreadsheetId, callback) => {
            console.log(config.spreadsheetFolders.international);
            drive.files.update(
                {
                    auth: jwtClient,
                    fileId: spreadsheetId,
                    resource: {
                        addParents: config.spreadsheetFolders.international
                    }
                },
                (err, file) => {
                    console.log(file);
                    callback(err, file);
                }
            )
        }
    ],
    (err, results) => {
        if (err) {
            console.log(err);
        } else {
                        something();
        }
    }
);

Ideas? This is Drive api v3 just fyi.

Got in contact with Google support. I'll update further when an "api specialist" reaches out! Woohoo!

Eric Koleda answered my question on July 27, 2016! Whoops, so sorry!
https://stackoverflow.com/questions/38590881/google-drive-file-update-with-2-legged-oauth-returns-ok-but-doesnt-work-as-expe


Vscode Error While Turning on Settings Sync

When I enable Settings Sync: Show Log :
2023-08-17 07:25:33.838 [info] Using settings sync service https://vscode-sync.trafficmanager.net/
2023-08-17 07:25:33.838 [info] Auto Sync is disabled.

I tried some issues that have similar situations with me and they don't work.
I disabled all extensions beforehand.

Solved. I reset the default browser in settings.


Local test suite

Move the entire test suite to run locally, without relying on fork testing.
Still several todos to make this a viable solution:

[x] CI seems to either be running against a fork or has a bug
[x] setupAnvil not fully resetting chain
[x] e2e tests config addresses

Closes #488

@0xOlias Do you want to add the pnpm wagmi generate command as a postinstall script or add it to the contributing docs?


Headers with values containing a colon are not parsed correctly

Hi, thank you for working on this plugin!
I was playing around with the authorization headers and found that basic auth would not work for me. This is the request I tried:
GET http://httpbin.org/basic-auth/foo/bar HTTP/2.1
Authorization: Basic foo:bar

Which using curl -v http://httpbin.org/basic-auth/foo/bar -u foo:bar should respond with
{
  "authenticated": true,
  "user": "foo"
}

I investigated this a bit and found that the headers were not being parsed correctly if the value contained a colon (:).
Slightly modifying the regular expression used for parsing the headers fixed the issue for me, I'll submit a pull request in a second :)

You're a hero! :heart:! What a great catch! Thanks for your PR! It's already merged into main and will be released soon!


[window.fetch] Unable to return result

$ cat main.dart
import 'dart:html';

main() {
  window.fetch('https://httpbin.org/get').then((response) {
    print(response);
  });
}
$ dart2js main.dart
Compiled 7,352,967 characters Dart to 87,873 characters JavaScript in 1.19 seconds

main.dart:4 Uncaught TypeError: C.Window_methods.fetch$1(...).then$1 is not a function
at Object.main (main.dart:4)
at out.js:2325
at out.js:2309
at out.js:2320
at out.js:2328
main @ main.dart:4
(anonymous) @ out.js:2325
(anonymous) @ out.js:2309
(anonymous) @ out.js:2320
(anonymous) @ out.js:2328

@terrylucas - it appears that fetch is declared to return a Future, and the original JS fetch returns a Promise. Seems like there is a conversion missing between the two?

This problem no longer exists today

This problem no longer exists today


make stats17-20 script into big function

What I really should do ideally is make the stats script into a function because I want to call it/do the exact same thing for all slices of the data, but would this be a pain to create, and would this exhaust the memory anyway?

At this point, there's a lot going on in the stats script that would make function-ing useful but also very acrobatic, and there would also be creating only 2 more year group scripts, so the sum of the marginal costs of making and maintaining new group-year scripts appears to be lower than the upfront cost of making a working function script at this point

resolved in #30


[Run] investigate DPI Awareness for font rendering

On a 4K monitor at 200%
0.35:

PR https://github.com/microsoft/PowerToys/pull/10568:

It's slightly better but far from ideal.

Inthe app manifest, setting:
  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
    </windowsSettings>
  </application>

results in:

but it's not placed in the center of the screen (shouldn't be too hard too fix the position).

oooooooooooooooo

this seems like an easy fix to add that, right?

@crutkas

this seems like an easy fix to add that, right?

It depends, in FZ Editor we couldn't use it because of a framework bug that prevented us from fine controlling the windows position on non-primary monitors in some multi-monitor configuration where different DPI scaling factors are used.
For PT Run, given the less complex UI, the bug might not show up, but we need to test it.

We should document that quirk but yes, i think this is a good item.  put this in 39/41?

@crutkas
we have a test app that shows the .Net DPI bug https://github.com/microsoft/PowerToys/tree/master/tools/FancyZonesEditor_DPI_test we need to add a readme to provide context.

@enricogior @crutkas
A WPF application is not able to automatically handle dpi scaling without additional developer work. Take a look at High DPI Desktop Application Development on Windows. Positioning of PT Run is already dpi aware but height and width are not.
I'm wondering if it makes sense to postpone this item until we migrate to winui. Any thoughts?

how easy is the fix?

I think it is a medium-cost item. Also, probably we are going to have the same issues as in https://github.com/microsoft/PowerToys/issues/5616. I don't think the same workaround will work for this issue.

Duplicate of #8949?

Is this still an issue with the latest version? /needinfo


Verify that "Setting a cookie on the domain of the WebSocket URI" documentation works

I've attempted to follow the "Setting a cookie on the domain of the WebSocket URI" section in the documentation, but it appears that browsers do not behave as indicated there.
My tests consists of:

https://host1 serves a cookie JS based setter website (document.cookie = "role=" + value + ";samesite=lax";) and a WebSocket server.
https://host2 tries to establish a connection to wss://host1/socket

To test, I browse the setter website explicitly, and then go to host2. As variations, I have also tried embedding host1 into host2 through an iframe.
In no setup (other than a single host serving both the site that opens the web socket and the cookie setter) I have observed the cookie being sent along with the WebSocket connection.
If the described setup actually works, it'd be great to see maybe a link to a reference project using it and thus demonstrating that browsers do work that way. Otherwise, please consider updating it to state that cookies are only sent when the web socket and the site opening it are on the same host (possibly on different subdomains if configured correctly).

The key message of the docs is "don't do this unless you really know what you are doing" :-)
There is an example in the repo which, I believe, works: https://github.com/aaugustin/websockets/tree/main/experiments/authentication
Run python app.py in this directory and see how it goes.
For the purposes of the Same Origin Policy, which is what you're struggling with, localhost:8000 and localhost:8003 are just as different as host1 and host2.

I just tried running that code. It's working. I see the cookie in the network inspector.


Clone and install eip712sign from a local repo

Per @mdehoog :
> we should temporarily remove the eip712sign installation from make deps given it's broken at the moment
> actually maybe better to fix it to do the local checkout, go install, and delete the local checkout. Once the upstream fix is merged we can switch it back to a remote go install

EDIT: since https://github.com/ethereum/go-ethereum/pull/28945 and subsequently https://github.com/base-org/eip712sign/pull/9 were merged, we were able to fix this by simply updating the version tag

✅


query parameters json schema

Hi, I'm wondering if there is any provided json schema definition for the query parameters

Query parameters are not JSON; why would there be a corresponding JSON Schema?

i see, i'm wondering if there should be any validation of the query parameters values, and if so, a json schema can be used to define them for jsonapi compliance.

i get your point, since the query parameters are not even sent in json format then we can't use a json schema for it (not the same as request/response body, which are in fact sent in json format).


Changed default ports for the Kafka Sample

The sample would crash on running with dozer live. Since the port 8080 was pre-occupied with RedPanda Server.
Changes:

docker-compose.yml: Start the RedPanda server on port 61234 instead of 8080.
dozer-config.yaml: Keep the Rest port default to 8080 instead of 8088.

Try not to change unrelated lines?


Timeline for shim layer for unenlightened guest OSes?

looking to move my windows SEV VMs down off cloud, which means needing a paravisor-type shim layer for their unenlightened OS.  Was told that this is on coconut's roadmap -- what do y'all expect the general timeline for that to look like?

Unfortunately it is too early to make statements about the timeline for this feature, but it is definitely on the roadmap. All I can say is that it is unlikely to to happen this year.


ignore multi workers tests

system.packages.MessageHubMultiWorkersTest > Mussage Hub Feed should assign two triggers to same worker when only worker0 is available SKIPPED

system.packages.MessageHubMultiWorkersTest > Mussage Hub Feed should assign a trigger to worker0 and a trigger to worker1 when both workers are available SKIPPED

system.packages.MessageHubMultiWorkersTest > Mussage Hub Feed should assign a trigger to worker1 when worker0 is removed and there is an assignment imbalance SKIPPED

system.packages.MessageHubMultiWorkersTest > Mussage Hub Feed should balance the load accross workers when a worker is added SKIPPED


deliveries/rush: implement the UberRush API

The UberRush API allows for food deliveries. Once the functionality is in with a couple of methods of making this possible, it opens up the possibility for this API client to be useable for one off apps e.g a food ordering and delivery app. Given that uberhook has already been implemented, it should become easier to assemble the pieces in order to build a food delivery app and also get notifications of different webhook events.

Methods:

[ ] Request Delivery
[ ] List deliveries
[ ] Get a quote for a delivery
[ ] Get the status for an ongoing delivery
[ ] Get the receipt for a completed delivery
[ ] Get the ratings for a completed delivery
[ ] Submit a rating for a delivery
[ ] Get the available rating tags for a delivery
[ ] Cancel a delivery
[ ] Get all regions in which UberRush is available


First Contribution by Emile-Daisy

Name: Emile-Daisy
Project: The Django open-source project
Governance model: https://www.djangoproject.com/weblog/2020/mar/12/governance/
Django is an open-source web framework for Python that follows a community-driven development model. The Django project has a governance model that outlines how decisions are made and who has authority in the project. Here are the key elements of the Django governance model:

Django Technical Board: The Django Technical Board (DTB) is responsible for overseeing the technical direction of the project. The DTB consists of five members who are elected by the Django core team for a term of two years.

Django Core Team: The Django Core Team is responsible for maintaining the Django codebase and reviewing contributions from the community. The Core Team consists of approximately 20 members who are selected based on their contributions to the project.

Decision Making: Major decisions in the Django project are made through a consensus-based approach. The Core Team and the DTB discuss and debate proposals, and decisions are made based on the opinions of the majority. In cases where a consensus cannot be reached, the DTB has the final say.

Contribution Guidelines: The Django project has detailed guidelines for contributing to the project. These guidelines cover code style, documentation, testing, and other aspects of contributing to the project.

Code Review: All code contributions to Django are reviewed by the Core Team. The Core Team provides feedback on the code, and contributors are expected to address the feedback before their code is merged into the codebase.

Release Cycle: The Django project has a regular release cycle, with new versions of Django released approximately every eight months. The release cycle includes alpha and beta releases, as well as a release candidate.

The Django governance model is designed to ensure that the project remains open and community-driven while also maintaining a high level of quality and consistency in the codebase.
The decision making process for the Django open source project typically involves the following steps:

Discussion: When a new feature or change is proposed, it is first discussed on the Django Developers mailing list or on the project's issue tracker. The proposal is presented with supporting evidence or use cases, and the community is invited to provide feedback and raise any concerns or alternative solutions.

Decision-making body: Once a proposal has been discussed, a decision-making body is responsible for making the final decision. For Django, this body is the Django Technical Board (DTB). The DTB is made up of a group of developers who are responsible for the overall technical direction of the project.

Decision criteria: The DTB considers a range of criteria when making decisions, including the impact on the community, the maintainability of the code, and the overall direction of the project. They also consider the opinions of the wider community and aim to reach a consensus where possible.

Voting: In some cases, the DTB may hold a vote to make a decision. Each member of the board has one vote, and a decision is made based on a simple majority.

Implementation: Once a decision has been made, the implementation of the change or feature is typically done by a volunteer contributor from the community. The code is reviewed by other members of the community, and any issues or bugs are addressed before the code is merged into the main codebase.
The decision making process for the Django open source project is transparent, community-driven, and focused on the long-term goals of the project. The process is designed to ensure that decisions are made in the best interests of the community and the project as a whole.

Finding information about the governance model for Django is relatively easy, as the project's website includes a section dedicated to governance, which can be accessed from the main navigation menu. This section provides detailed information on how the project is run and how decisions are made. Understanding the governance model, however, may require some familiarity with open source development and community-driven projects. The Django governance model is based on the principles of open governance, with a core team of developers overseeing the project's development and decision-making processes. The model is structured around a set of governance documents, including a code of conduct, a roadmap, and a technical board that oversees development and manages conflicts. Overall, while understanding the details of the Django governance model may require some prior knowledge of open source development, the information is easily accessible and well-documented for those interested in learning more.

@arliss-NF

cc @arliss-NF

cc @arliss-NF

@12Daisy - so sorry for the delay - this is an excellent first contribution.  Very thorough and concise.  Well-organized and the content is at the level we are looking for.  Moving on to your second contribution.  Please make sure to submit a final application.  Thank you.


Make more tests

We need to cover more areas with our tests, now that we are better acquainted with the code

We should take a better look on our tests. I ran our test suite several times and some tests were failing sometimes due to mistakes using the Math.random() function to generate inputs.
We fixed the in_circle test for the Safe Zone. It was creating a player that was supposed to be inside the safe_zone, but it was actually outside.
The update_circle test is also bugged due to similar reasons. It gave me this output error
`` yarn run v1.9.4
$ jest
PASS tests/server/bullet.test.js
● Console
console.warn node_modules/node-uuid/uuid.js:48
[SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()
PASS tests/server/_aux.test.js
● Console
console.log objects/_aux.js:13
function getRndInteger: max must be bigger than min
FAIL tests/server/safe_zone.test.js
● Console
console.warn node_modules/node-uuid/uuid.js:48
[SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()
console.log objects/safe_zone.js:28
SafeZone constructor: center_x must be non-negative or smaller than max_x
console.log objects/safe_zone.js:28
SafeZone constructor: center_y must be non-negative or smaller than max_y
console.log objects/safe_zone.js:28
SafeZone constructor: center_x must be non-negative or smaller than max_x
console.log objects/safe_zone.js:28
SafeZone constructor: center_y must be non-negative or smaller than max_y
console.log objects/safe_zone.js:28
SafeZone constructor: radius must be bigger than zero
console.log objects/safe_zone.js:44
SafeZone update_circle: new_center_x must be smaller than current center_x.
console.log objects/safe_zone.js:44
SafeZone update_circle: new_center_x must be smaller than current center_x.
console.log objects/safe_zone.js:44
SafeZone update_circle: new_center_x must be smaller than current center_x.
console.log objects/safe_zone.js:44
SafeZone update_circle: new_center_x must be smaller than current center_x.
● objects/safe_zone: update_circle() - sucess
expect(received).toBe(expected) // Object.is equality
Expected: 351
Received: 956
49 |
50 | dc.update_circle(new_temp_x, new_temp_y, new_temp_r);

51 | expect(dc.center_y).toBe(new_temp_y);
| ^
52 | expect(dc.center_x).toBe(new_temp_x);
53 | expect(dc.radius).toBe(new_temp_r);
54 | });

at Object.toBe (tests/server/safe_zone.test.js:51:23)
PASS tests/server/box.test.js
● Console
console.warn node_modules/node-uuid/uuid.js:48
[SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()
PASS tests/server/player.test.js
● Console
console.warn node_modules/node-uuid/uuid.js:48
[SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()
console.log objects/player.js:104
SHOOT! bullets left: 7
Test Suites: 1 failed, 4 passed, 5 total
Tests: 1 failed, 17 passed, 18 total
Snapshots: 0 total
Time: 2.074s
Ran all test suites.


OpenSSL error during boto3 import

System Info
AWS Inferentia2 host with the following AMI:

Deep Learning AMI Neuron (Ubuntu 22.04) 20240226

ami-09765a839c76c84f2 (64-bit (x86))

Reproduction (minimal, reproducible, runnable)
On a fresh optimum-neuron[neuronx] install, just importing any symbol from optimum.neuron leads to the following error:
AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY'. Did you mean: 'X509_V_FLAG_EXPLICIT_POLICY'?
Expected behavior
There should not be any error. The fix is to update manually the pyopenssl package:
python -m pip install pyopenssl==24.0.0

Fixed in latest AMI.


Added spanish translation for "Security"

Made the translation for section 2.5 which is Security but appears as 2.6 in the original english text - haven't found an explanation for that difference but didn't want to edit since all the numbers seem changed and maybe there's a good reason. Do you know why @medied?

also, @medied: your video is so fckin helpful man, I wish all coders were so generous with first time github users. thanks and congrats.
i can take on the rest of the spanish translation if it's tedious for you (really just let me know and feel free to leave it) - I even kind of have fun doing this

@mairwilliams very glad to hear you found the video useful, hopefully others will too. Thanks!
Good catch on the section numbers' mismatch. Looked into it and realized it's because we added a new section (2.4 Pilot, regarding Colombian pilot) in the original english section but hadn't updated the spanish skeleton. Just pushed 5ed05d9d7fcd4a31a06036373c10006cbe459a6f to fix that.
And yea awesome thanks! Feel free to translate as much as you want! We are using this spreadsheet to coordinate, anything that hans't been claimed is fair game. You can see @nelruk has also been translating.


Add github actions so that tests can be executed on pushes & PRs against main

Example run here : https://github.com/liquibase/liquibase-test-harness/runs/1495851784?check_suite_focus=true


added one make file just for internal dev

Just to unify some standarded operaitons.

Closed it due to this patch has been merged into #8 .


[FormControlLabel] Fix misplaced asterisk when labelPlacement is provided

[x] I have followed (at least) the PR section of the contributing guide.

Fixes #37281
I was not able to push on PR #37286, so created this one and closed that.
Argos detected changes (https://app.argos-ci.com/mui/material-ui/builds/14969/51477913), but I couldn't find any differences after inspecting between the production version and this PR.

Before: https://codesandbox.io/s/exciting-feather-0d0e2o?file=/demo.tsx
After: https://codesandbox.io/s/silly-shamir-3j68c8

Argos is being weird this week for some reason! It's not just you. 😅

Argos is right in this case - if you open your before/after examples you'll notice that the "after" one has the asterisks positioned slightly higher.

@michaldudak I fixed it now. I had checked the documentations (which Argos checks against), and there I couldn't visually identify any differences. However, thanks for pointing it out in the CodeSandbox examples.


use CL_R

closes #317

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.90%. Comparing base (e82060b) to head (2e655ed).

Files
Patch %
Lines

clic/src/opencldevice.cpp
0.00%
3 Missing :warning:

clic/src/openclbackend.cpp
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   47.90%   46.90%   -1.00%
==========================================
  Files         235      235
  Lines        3144     3147       +3
  Branches     1571     1571
==========================================
- Hits         1506     1476      -30
- Misses        368      436      +68
+ Partials     1270     1235      -35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[URGENT] Update SDWebImage dependency for Apple Privacy

There is a deadline coming up where Apple requires all usage of SDWebImage to include xcprivacy files. That was added in the 5.18.7 release: https://github.com/SDWebImage/SDWebImage/releases/tag/5.18.7
However, SDWebImageSwiftUI has no way to use the new version, so it's not currently possible to get the required version.
Apple will stop accepting uploads without this file starting on May 1, 2024, so this update needs to be made very soon to allow time to integrate and test the dependency update.

SDWebImageSwiftUI has no way to use the new version, so it's not currently possible to get the required version

Why ? See our demo's Podfile.lock
PODS:
  - libavif/core (0.11.1)
  - libavif/libdav1d (0.11.1):
    - libavif/core
    - libdav1d (>= 0.6.0)
  - libdav1d (1.2.0)
  - libwebp (1.3.2):
    - libwebp/demux (= 1.3.2)
    - libwebp/mux (= 1.3.2)
    - libwebp/sharpyuv (= 1.3.2)
    - libwebp/webp (= 1.3.2)
  - libwebp/demux (1.3.2):
    - libwebp/webp
  - libwebp/mux (1.3.2):
    - libwebp/demux
  - libwebp/sharpyuv (1.3.2)
  - libwebp/webp (1.3.2):
    - libwebp/sharpyuv
  - SDWebImage (5.19.0):
    - SDWebImage/Core (= 5.19.0)
  - SDWebImage/Core (5.19.0)
  - SDWebImageAVIFCoder (0.11.0):
    - libavif/core (>= 0.11.0)
    - SDWebImage (~> 5.10)
  - SDWebImagePDFCoder (1.0.1):
    - SDWebImage (>= 5.14.1)
  - SDWebImageSVGCoder (1.7.0):
    - SDWebImage/Core (~> 5.6)
  - SDWebImageSwiftUI (3.0.1):
    - SDWebImage (~> 5.10)
  - SDWebImageWebPCoder (0.14.5):
    - libwebp (~> 1.0)
    - SDWebImage/Core (~> 5.17)

DEPENDENCIES:
  - libavif/libdav1d
  - SDWebImageAVIFCoder
  - SDWebImagePDFCoder
  - SDWebImageSVGCoder
  - SDWebImageSwiftUI (from `./`)
  - SDWebImageWebPCoder

SPEC REPOS:
  trunk:
    - libavif
    - libdav1d
    - libwebp
    - SDWebImage
    - SDWebImageAVIFCoder
    - SDWebImagePDFCoder
    - SDWebImageSVGCoder
    - SDWebImageWebPCoder

EXTERNAL SOURCES:
  SDWebImageSwiftUI:
    :path: "./"

SPEC CHECKSUMS:
  libavif: 84bbb62fb232c3018d6f1bab79beea87e35de7b7
  libdav1d: 23581a4d8ec811ff171ed5e2e05cd27bad64c39f
  libwebp: 1786c9f4ff8a279e4dac1e8f385004d5fc253009
  SDWebImage: 981fd7e860af070920f249fd092420006014c3eb
  SDWebImageAVIFCoder: 00310d246aab3232ce77f1d8f0076f8c4b021d90
  SDWebImagePDFCoder: ec8d162f5a4a34760bf1ea3d7f818dd85dc82e81
  SDWebImageSVGCoder: 15a300a97ec1c8ac958f009c02220ac0402e936c
  SDWebImageSwiftUI: 5acb843d4fb27841adac772aecc0516e9ee90356
  SDWebImageWebPCoder: c94f09adbca681822edad9e532ac752db713eabf

PODFILE CHECKSUM: a1b2837f429f61673bea58532abe00e850c10aeb

COCOAPODS: 1.15.2

I don't think SDWebImageSwifUI Can not use the latest version of SDWebImage

@dreampiggy I don't understand your last comment?
I'm getting the following when I upload now. Not sure if it is because of SDWEBImage, but I've added the PrivacyInfo for my app.
ITMS-91053: Missing API declaration - Your app’s code in the “UntitledBarracks” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryFileTimestamp. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.
ITMS-91053: Missing API declaration - Your app’s code in the “UntitledBarracks” file references one or more APIs that require reasons, including the following API categories: NSPrivacyAccessedAPICategoryUserDefaults. While no action is required at this time, starting May 1, 2024, when you upload a new app or app update, you must include a NSPrivacyAccessedAPITypes array in your app’s privacy manifest to provide approved reasons for these APIs used by your app’s code. For more details about this policy, including a list of required reason APIs and approved reasons for usage, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api.

However, SDWebImageSwiftUI has no way to use the new version, so it's not currently possible to get the required version.

Is your project issue. Maybe your min deployment version is wrong.
The demo shows that "we can always get the new version"

What linkage did you use ?
For dynamic linkage, each framework use its own symbol. SDWebImageSwiftUI does not use any FileSystem API, so it shouldn't
For static linkage, each framework share the same symbol. So maybe you need to declare NSPrivacyAccessedAPICategoryFileTimestamp at App level

We use swift package manager. I don't know wether spm packages are static or dynamic linked.
SDWebImageSwiftUI has no references to NSPrivacyAccessedAPICategoryFileTimestamp but SDWebImage does and SDWebImageSwiftUI depends on it.

Is that final package actually contains the Privacy Manifest ? Maybe the issue is that SDWebImage does not get recognized contains a valid manifest

Yes, the privacy manifest file is there, however the reasons for NSPrivacyAccessedAPICategoryFileTimestamp don't show up in the privacy report (i just generated one).

I means, the final package (.ipa)
It seems the syntax is correct as Apple's forum ?
https://github.com/SDWebImage/SDWebImage/blob/master/Package.swift#L35
https://forums.developer.apple.com/forums/thread/742527

I guess this is SwiftPM only problem, marked as label here. And you can test using CocoaPods or manural archive (using Carthage build for exmaple)

We don't have CocoaPods nor Carthage in our project, so I am not able to test this easily.

Can you provide what that looks like because I'm still getting warned on this privacy issue using SPM.

We are using xcodegen, so I'm not 100% sure of how this would look with a standard SPM integration, but we have the following dependencies defined:
  SDWebImage:
    # This is a dependency of SDWebImageSwiftUI and SDWebImageSVGCoder, but needs to be
    # explicitly set to v5.19.1 for xcprivacy support. Once those SDKs are updated, we
    # can remove this explicit version tracking.
    url: https://github.com/SDWebImage/SDWebImage
    version: 5.19.1
  SDWebImageSwiftUI:
    url: https://github.com/SDWebImage/SDWebImageSwiftUI
    version: 2.2.3

This setup makes use of the correct version of SDWebImageSwiftUI, while bumping SDWebImage itself up to the latest version.

Here's what I have

I'm not sure if there was additional work. We had to have our own privacy manifest set up, so it's possible we resolved our warnings by adding that.

Thanks! I've added mine as well, maybe you have some pointers?

That looks to be about what I would expect. I'm not sure what else would be missing outside of for some reason the file not being included I the final build. Sorry I can't help much more here.

Adding SDWebImage 5.19.1 via SPM as an explicit dependency to the project does not resolve the issue. I am still getting the privacy issue.
And SDWebImageSwiftUI already adds SDWebImage 5.19.1, so explicitly adding SDWebImage should not make a difference.

When using our repo's own Demo (open SDWebImageSwiftUI.xcworkspace), click archive, I can see the xcarchive, and the App bundle actually contains the PrivacyInfo.xcprivacy, under a bundle named SDWebImage_SDWebImage.bundle

@ginnheimerCoder Does your final app or ipa not contains this file ?

Using the same tree command, it only shows our own PrivacyInfo file under the root directory of the app. There is no SDWebImage_SDWebImage.bundle branch and no PrivacyInfo file in it.

I re-added SDWebImageSwiftUI and now using the tree command, the SDWebImage_SDWebImage.bundlebranch is showing up and has the PrivacyInfo file in it – however, Apple is still complaining.

however, Apple is still complaining and SDWebImage with the declared reason is not showing up in the privacy report.
So, what's actually needed ? I saw the Apple forum seems some devs use SDWebImage as the correct way.

See: https://forums.developer.apple.com/forums/thread/734971

On the Apple forum, nobody mentions the use of SPM.

On the Apple forum, nobody mentions the use of SPM. I think this is an SPM issue.

There are no different if you use Static Library in CocoaPods.
I guess when you use .framework bundle, you will not have any issue. Does the Apple ITC tools only scan for .framework (Static framwork or dynamic framework)

what exactly do you mean when you say "use .framework bundle"? I just included the package via Swift Package Manager. Nothing more. What do I need to change?

So it seems like the issue has been resolved on the apple side.
Today I received a response from the TSI i opened. Apple simply said “There has been a change in the policies. You should be able to upload a binary that contains a static framework.”
They linked to the reminder Apple released on Friday.
I uploaded a new build (with no changes to the privacy issue) and up until now I haven’t received the privacy issue e-mail.

SPM does not use Static framework to distribute your code.


Implement a test suite that covers provisioning and configuration

The current test suite is limited to linting shell scripts. This is too limited and requires manual testing.
We should implement automated checks for:

[ ] Provisioning (number of machines, OS)
[ ] Kubernetes cluster (number of nodes, type of nodes)
[ ] Kubernetes infrastructure (network plugin)
[ ] Kubernetes workloads (try to deploy a workload and see the results)
[ ] Lint Ansible playbooks
[ ] Lint Ansible roles
[x] Lint YAML
[x] Lint markdown
[x] Validate Vagrantfile
[x] Validate Travis configuration file
[x] Lint shell scripts

This proved to be not the easiest of problems to solve, because I didn't find any free CI services that let you run Virtualbox (or other hypervisors for what matters) during a CI build.
It may be necessary to switch to a different implementation if we want to achieve this.

It's now possible to run libvirt on Travis! See https://github.com/jonashackt/vagrant-travisci-libvrt


Rerun all plates to include Zernike features

Problem
When I first created the CellProfiler pipeline for NF1, I avoided calculating Zernike features in the MeasureObjectIntensityDistribution module as CellProfiler indicated that it would save computational time if you did not calculate these features.
Solution
After further discussion with the NF1 team, adding this calculation to the pipeline makes sense. CellProfiler parallelized will need to be rerun.

This issue has been fixed in PR #20.


disqus: Update dir-disqus on bower

Could you please update your disqus directive on bower. The SSO feature is missing in the version, currently added to bower.

Yes, now updated


HBASE-28951 rename the wal before retrying the wal-split with another worker

Added an workerchange counter so that each time we can have a new name, that is needed in case the supposed dead RS starts to process the WAL after some time. I checked that wal name pattern, that we use for validating the wal is (.+)\.(\d+)(\.[0-9A-Za-z]+)? . This change is fitting there.

While going through the code I saw some comments and code that are not aligning. As per this comment, WALSplitter.splitLogFile should not be getting used in procedure based splitting. I think this is becuase we are using SplitLogWorker.splitLog(that is deprecated) in SplitWALCallable.
Can someone help me understad this? Is this a miss or it is known? cc @Apache9 , @apurtell

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 43s

master passed

+1 :green_heart:
compile
3m 13s

master passed

+1 :green_heart:
checkstyle
0m 42s

master passed

+1 :green_heart:
spotbugs
3m 24s

master passed

+1 :green_heart:
spotless
0m 41s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s

the patch passed

+1 :green_heart:
compile
3m  5s

the patch passed

+1 :green_heart:
cc
3m  5s

the patch passed

+1 :green_heart:
javac
3m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 41s

the patch passed

+1 :green_heart:
spotbugs
3m 33s

the patch passed

+1 :green_heart:
hadoopcheck
9m 19s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
hbaseprotoc
1m  3s

the patch passed

+1 :green_heart:
spotless
0m 39s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

38m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
dupname asflicense cc buflint bufcompat codespell detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti

uname
Linux 6762302b0f27 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1b4fef43d5aff10fc6a9b8895c2740a410c8a46e

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed

+1 :green_heart:
shadedjars
5m 35s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 32s

hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
200m 22s

hbase-server in the patch passed.

227m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
unit javac javadoc compile shadedjars

uname
Linux c10023771c0b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1b4fef43d5aff10fc6a9b8895c2740a410c8a46e

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/1/testReport/

Max. process+thread count
5671 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Umeshkumar9414 So the idea here is to have a retry counter attached to the wal name. And whenever split wal fails and another worked picks up same wal, it increments the counter!!

@Umeshkumar9414 How is this handled if the the splitwal proc fails and also root procedure fails.

In general I think the approach is OK, renaming is a typical way for fencing. But I suggest we keep the old behavior when there is no retry, so we can get better compatibility.

Yeah I didn't do any changes when there is no retry

@Umeshkumar9414 If the the splitwal p

Thanks @mnpoonia  to point this out. I need to when the parent SCP fails and lets say we have created another SCP. It will just list all the files in WALDirectory and create SplitWalProcedure for all but yeah I need to handle the first retry with retryCount 0.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s

master passed

+1 :green_heart:
compile
3m 12s

master passed

+1 :green_heart:
checkstyle
0m 43s

master passed

+1 :green_heart:
spotbugs
3m 31s

master passed

+1 :green_heart:
spotless
0m 41s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed

+1 :green_heart:
cc
3m 15s

the patch passed

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

+1 :green_heart:
spotbugs
3m 42s

the patch passed

+1 :green_heart:
hadoopcheck
9m 44s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
hbaseprotoc
1m 10s

the patch passed

+1 :green_heart:
spotless
0m 41s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s

The patch does not generate ASF License warnings.

40m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
dupname asflicense cc buflint bufcompat codespell detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti

uname
Linux c46c05b919dc 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd0af96a0e0d0c8234574f4c8c0f37089bc822fb

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 21s

the patch passed

+1 :green_heart:
compile
1m 50s

the patch passed

+1 :green_heart:
javac
1m 50s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed

+1 :green_heart:
shadedjars
6m 20s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 49s

hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
185m 20s

hbase-server in the patch passed.

216m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
unit javac javadoc compile shadedjars

uname
Linux d29383b280f5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd0af96a0e0d0c8234574f4c8c0f37089bc822fb

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/2/testReport/

Max. process+thread count
5354 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

What about add a new step after acquire worker to rename the wal file, where we just append the worker's name to the wal file name as suffix?
And we need to be very careful when dealing with retrying...
There are several problems currently

Renaming failure does not always mean the old file is still there, maybe the renaming is complete but we just do not get the result because of a network issue, then in the current code we will consider the splitting as finished and cause data loss.
We will do the renaming after release worker, if the renaming fails, when retrying we will release the worker again, this will cause  trouble...

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s

master passed

+1 :green_heart:
compile
3m  5s

master passed

+1 :green_heart:
checkstyle
0m 42s

master passed

+1 :green_heart:
spotbugs
3m 22s

master passed

+1 :green_heart:
spotless
0m 41s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s

the patch passed

+1 :green_heart:
compile
3m  5s

the patch passed

+1 :green_heart:
cc
3m  5s

the patch passed

+1 :green_heart:
javac
3m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 40s

the patch passed

+1 :green_heart:
spotbugs
3m 35s

the patch passed

+1 :green_heart:
hadoopcheck
9m 20s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
hbaseprotoc
1m  3s

the patch passed

+1 :green_heart:
spotless
0m 40s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s

The patch does not generate ASF License warnings.

38m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
dupname asflicense cc buflint bufcompat codespell detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti

uname
Linux 20282ab7b0c9 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd0af96a0e0d0c8234574f4c8c0f37089bc822fb

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed

+1 :green_heart:
shadedjars
5m 34s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 32s

hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
182m 30s

hbase-server in the patch passed.

209m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
unit javac javadoc compile shadedjars

uname
Linux b355e55fc518 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd0af96a0e0d0c8234574f4c8c0f37089bc822fb

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/3/testReport/

Max. process+thread count
5492 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

While going through the code I saw some comments and code that are not aligning. As per this comment, WALSplitter.splitLogFile should not be getting used in procedure based splitting but we are using the same method. We are calling SplitLogWorker.splitLog(that is deprecated) in SplitWALCallable. And inside this method here, we call WALSplitter.splitLogFile. Can someone help me understad this?

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed

+1 :green_heart:
shadedjars
5m 53s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 34s

hbase-protocol-shaded in the patch passed.

-1 :x:
unit
12m 30s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

38m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
unit javac javadoc compile shadedjars

uname
Linux 10487a26c15e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a2f732dbe4738e8290334ef4864e8fdf8b161e44

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/4/testReport/

Max. process+thread count
1790 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s

master passed

+1 :green_heart:
compile
3m 13s

master passed

+1 :green_heart:
checkstyle
0m 42s

master passed

+1 :green_heart:
spotbugs
3m 30s

master passed

+1 :green_heart:
spotless
0m 41s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s

the patch passed

+1 :green_heart:
compile
3m  9s

the patch passed

+1 :green_heart:
cc
3m  9s

the patch passed

+1 :green_heart:
javac
3m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 33s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
3m 44s

the patch passed

+1 :green_heart:
hadoopcheck
9m 50s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
hbaseprotoc
1m  6s

the patch passed

+1 :green_heart:
spotless
0m 40s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s

The patch does not generate ASF License warnings.

41m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
dupname asflicense cc buflint bufcompat codespell detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti

uname
Linux 2bff36406c2c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a2f732dbe4738e8290334ef4864e8fdf8b161e44

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/4/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s

master passed

+1 :green_heart:
compile
3m 27s

master passed

+1 :green_heart:
checkstyle
0m 41s

master passed

+1 :green_heart:
spotbugs
3m 40s

master passed

+1 :green_heart:
spotless
0m 42s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s

the patch passed

+1 :green_heart:
compile
3m 28s

the patch passed

+1 :green_heart:
cc
3m 28s

the patch passed

+1 :green_heart:
javac
3m 28s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 36s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
3m 53s

the patch passed

+1 :green_heart:
hadoopcheck
10m 44s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
hbaseprotoc
1m 13s

the patch passed

+1 :green_heart:
spotless
0m 40s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

43m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
dupname asflicense cc buflint bufcompat codespell detsecrets hbaseprotoc spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti

uname
Linux dd88e2ccf603 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd576cdbe6070dcc43a10e5238ffc5a207429272

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed

+1 :green_heart:
shadedjars
5m 47s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 32s

hbase-protocol-shaded in the patch passed.

-1 :x:
unit
211m 51s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

241m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6534

Optional Tests
unit javac javadoc compile shadedjars

uname
Linux 153b6b6e2528 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd576cdbe6070dcc43a10e5238ffc5a207429272

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/5/testReport/

Max. process+thread count
5332 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6534/5/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


fix(frontend/controller): convert search query to ascii when required

otherwise it will unnecessarily move around sihari accent character (ASCII i)
fix #166

Summary
The search query was unnecessarily being converted to ascii which caused it to move the accent character (sihari). Making sure the query is not ascii before converting it resolved it.
Before

After

Tests
Tried ascii and unicode on desktop and mobile phone.
Tried all sorts of various characters on keyboard without having the render mess up (and hopefully assuming that applies to query as well, no easy way to test all those manually)
Other
I am unsure if there is a way to refactor such that I don't have to use the same conditional in two separate locations
PM / Time
Took between 30-45 minutes

https://github.com/ShabadOS/database/issues/1333

This is wrong, GurbaniAkhar has characters outside of the 128-char ASCII range.
It should be solved in https://github.com/ShabadOS/database/issues/1333

Closing in favor of using isGurmukhi gurmukhi utils https://github.com/ShabadOS/gurmukhi-utils/pull/141


CIP-0067 | add ADA Handles Virtual SubHandle

Reserving a label for Virtual SubHandles. These are Handles that the issuer (root Handle owner) retains ownership over, but still allows for address resolution to a specified wallet, and personalization features.

1 - Why does this application need its own Asset Name Label as opposed to a CIP-0010 Transaction Metadata Label?

I wonder about this too. It seems like it's very ADA Handle specific. Maybe this should be more generalized.

Thank you for taking a look at this!

Why does this application need its own Asset Name Label as opposed to a CIP-0010 Transaction Metadata Label?

ADA Handle won't be using transaction metadata to represent Virtual SubHandles. We will be using a token with UTxO datum sitting at smart contract. The smart contract will allow changes to the UTxO datum based on some specific logic. Wallet DApps will resolve a subclass of Handle addresses based on this datum.

Why is there not a corresponding addition to CIP-0068

I believe Ales answered this already, but CIP-67 isn't explicitly tied to CIP-68. CIP-67 defines classes of data that DApps can use to identify what kind of datum they are dealing with within a UTxO. In our case we have dozens of DApps that use our protocol. This would help them identify the different tokens in use in that protocol.

Since "class": "Virtual_SubHandle" leaves this label in a class by itself, is there not a more general category that could be assigned here...

I'm not exactly sure what is being asked here, but I am happy to try and answer. Handles are used in dozens of DApps (we suspect the number is closing in on 100 DApps, if it hasn't passed it already), including nearly all of the wallets, exchanges, and explorers in use on Cardano today. So while the class may be more specific to our protocol, Handles itself is in use by a large population within Cardano.

1 - Why does this application need its own Asset Name Label as opposed to a CIP-0010 Transaction Metadata Label?

I wonder about this too. It seems like it's very ADA Handle specific. Maybe this should be more generalized.

I did ask this question in a private chat with a prominent contributor to the CIP process. It was their opinion at the time that ADA Handle can and should be considered a protocol if that is our intention. And it is. We are working tirelessly to take us down the road of decentralizing all aspects of ADA Handles. Where Kora (the current stewards of ADA Handles) will likely always be contributors to the protocol, we will slowly pass the reigns of stewardship to the community. We are already taking steps to do this. It's just a delicate process and we aren't a huge team.

I think we should still talk about the choice of class (whether it should have more generality) at the next CIP meeting if not already settled on GitHub in the meantime (cc @KtorZ @Ryun1 @SebastienGllmt) & I will look out to make sure it's on the agenda if discussion still needed.

Fair enough. We were considering what an abstracted version of this would look like. The intended purpose would be for non-NFT address resolution, which boils down to a single field on our case. We do have other fields that are related to Handle Personalization in this token, but I'm not sure that feature is very "abstractable".
Our other option is to simply make use of one of the 16 labels reserved for private use within a policy ID. But as I mentioned earlier, we were encouraged to represent our intention as a protocol and make it part of the official public label space. Which does reflect our direction.

Did this make the agenda at the last CIP meeting? Curious to hear the latest thoughts.

Yes @papag00se we discussed it but the resolution never got recorded here & my apologies for that.  We are transitioning to a new format for agendas which will mark resolutions as notes (https://hackmd.io/@cip-editors - cc @KtorZ) but while in this flux some action items for editors were stuck in our own personal notes for this meeting cycle. 😖
What I meant to say: there was more discussion about how CIP-0067 needs to be updated when a candidate class is added (everyone agreed that your label itself is needed).  This asset label request is in its own class whether Ada Subhandles are considered their own "protocol" or not.  The consensus as suggested above is that we need an update to CIP-0067 itself including:

what constitutes the requirement for a new class
what process to follow when adding a class, including whether CIP-0067 needs to be updated or not
possibly an enumeration of existing classes (a list which will grow with time)
etc.

We had agreed to ping @alessandrokonrad about this and I don't know if that's been done: I should have done that here, and long ago.  @alessandrokonrad can you feed back ASAP about what kind of asset name label classification process we need, hopefully before our CIP meeting (in about 8 hours) so we can discuss this issue today with your input (or you might even come to the meeting 🙏)?

@papag00se @alessandrokonrad it's confirmed on meeting agenda here: https://hackmd.io/@cip-editors/65

It's possible I misunderstood the purpose of the "class" designation. I was under the impression that is was a one-to-one relationship between an asset label and a class. If one wanted to add a label, they also must add a class. The statement -

...adding a label can be done trivially but that adding a class should at least have some documentation about who else might be using the class.

- causes me to think they are not actually one-to-one. An asset label may or may not have an asset class, but an asset class would always have a label. (Maybe the latter isn't even true?)
So now I am in doubt and don't have the same confidence you have that we know what we're talking about. Maybe with a bit more clarity I could get that confidence back.

@papag00se likewise I am somewhat underconfident - in my case, about the practical consequences of the classification scheme.  Therefore I don't know if it may be silly to ask: @alessandrokonrad would there be any practical use for an undefined or default class?

For some clarity for the CIP process and guidance for the Ada Handle team.
Definition of an asset class: "A grouping of native assets on the Cardano blockchain that share similar characteristics and properties as defined by their protocols or issuers."
Here the "property" refers to an attribute, quality, or feature that is inherent to an object or entity that we are trying to represent with a native asset (how things behave). For instance, properties could include its fungibility, its divisibility, or the total supply of the asset.
Here the "characteristic" is typically a distinctive feature or quality that helps to identify, distinguish, extend or describe the object at hand (how things look). Characteristics might include behaviors or patterns that are not inherent to the native asset but emerge from how it interacts with its environment or how it is expected to be used.
An example; for the class of NFT's, you expect, for each native asset in this class, some particular formatted metadata to exist that needs to be resolved (a characteristic). Besides that, for a NFT, as the name suggests, we expect that there should only exist one (a property).
To identify and come up with a new asset class, and thus a label, one should ask these questions: Given a representation of an object that you represent by a native asset, what are its characteristics and properties? Given these characteristics and properties, why do these not fit into another already existing class? Given my new class, what are the general properties and characteristics that all members in the class share? Abstract away of the project-specific design requirements. If some data needs to be resolved, in what format do we expect this for a general member in the class?
Hope this helps. Could you format a table of characteristics and properties for your generalized sub handles? Additionally, a rationale for each is appreciated, remember that as an outsider of the handle business, I have no clue what things are supposed to do. Currently, I do not see why the virtual sub handle is not in the NFT class and why its metadata could not handle the logic of being a virtual sub handle?
@rphair and @alessandrokonrad, I think we should add something to CIP 67 to guide this process, what do you think of the above? Let's take this PR as an experiment and later reflect on how we would do this in the future.

@perturbing I think the language above (included under a subheading, with the enumerated points, definitions & questions bulleted etc. 🤓) would be very good to add to CIP-0068 unless @alessandrokonrad has any objections or modifications.
I also think that if CIP-0068 is to be asking these comprehensive questions, then the answers should be officially documented (not just in the proposer's PR) when proposing a new asset class.  So far, that place has been CIP-0068... getting back to what I was asking in https://github.com/cardano-foundation/CIPs/pull/504#pullrequestreview-1382001137.
So @perturbing unless I have gotten this point wrong, I think there should be a heading like "How to submit a proposal for a new asset class" including the requisite modifications to both the CIP-0067 array and the CIP-0068 text.  An alternative might be adding some new fields to the array with some kind of standardised characteristics and properties... but I feel that anything like this would be outgrown and/or a lot of trouble to maintain.

Could you format a table of characteristics and properties for your generalized sub handles?

I guess this means we are asking @papag00se to include an addition to CIP-0068 in this PR where the material above can be added.  Again, please correct me if I'm wrong.

Let's take this PR as an experiment and later reflect on how we would do this in the future.

yes, if this works as a model then please @perturbing submit another PR with the general additions to CIP-0068.  If necessary I will try to write it, although I don't work with the practical applications enough to be able to defend the language in the editorial process.
Once that's done I would hope @mmahut (from Blockfrost, a major implementor of CIP-0068) can review this process to ensure in advance that it will work well with their own methods. 🙏

Discussed in CIP editors' meeting today & thanks @perturbing for attending.
We noted again that CIP-0067 and CIP-0068 are considered to be separate, as @alessandrokonrad already pointed out, but clarified that a section should be added to CIP-0068 when there is common metadata to define.  So @papag00se regarding whether a CIP-0068 update is required, you can decide based on the metadata that tokens in your new class would need.
@perturbing also confirmed he has been in touch with the ADA Subhandle team to help answer these questions.  Current status is that we're waiting for the results of their consultation to be recorded here before proceeding with this PR.

@perturbing @papag00se this item is on our CIP editors' meeting agenda again (https://hackmd.io/@cip-editors/69 - Tuesday 04 July 16:00 UTC) so please come if you can present your discussions suggested in https://github.com/cardano-foundation/CIPs/pull/504#issuecomment-1598580495 or at least post them here.

@perturbing thanks for confirming before the CIP Editors' meeting today your offer to "write something up" regarding https://github.com/cardano-foundation/CIPs/pull/504#issuecomment-1598580495.
FYI @papag00se we agreed at that meeting to mark this Waiting for Author until we have that statement, here in this thread and/or the PR content, in which we are hoping to see both:
1 - implications for this PR (what ADA SubHandle team actually wants for classes, exactly why the need it, and exactly how others might use it)
2 - implications for CIP-0068 as requested in https://github.com/cardano-foundation/CIPs/pull/504#issuecomment-1598272600 & https://github.com/cardano-foundation/CIPs/pull/504#issuecomment-1598580495.

@rphair
I am currently working on rethinking and redoing some wording and formatting on the two CIPs to make them more clear. However, I am currently on vacation so this will take some time as it is not a priority.

@perturbing also confirmed he has been in touch with the ADA Subhandle team to help answer these questions. Current status is that we're waiting for the results of their consultation to be recorded here before proceeding with this PR.

Although the ada Handle team contacted me, it was not for consultation but to request a review of this CIP. If they want to proceed with their request, they will need to provide more information.

apologies @perturbing when I used the word "consultation" I realise now that had the wrong implication... I was only trying to pass along that you'd bee in contact about this issue & am correcting my language above.
We're all looking forward to any time you can spare on this issue, and if @papag00se needs the CIP-0067 addition on the critical path for the Ada SubHandles project then perhaps he can also make some arrangements to provide the details requested in https://github.com/cardano-foundation/CIPs/pull/504#issuecomment-1620581263.

@papag00se according to a proposed update to CIP-0068 (https://github.com/cardano-foundation/CIPs/pull/586) there is no longer a requirement to update the CIP-0067 table unless new token types are added.  In any case a new CIP would be required covering the proposed addition and its token metadata completely.
From the current state of the discussion, and given there hasn't been a justification posted so far about why a new CIP-0067 registry entry would be needed either to implement your application or extend its data structure to other applications, my understanding is that this PR can now be dropped.
If that's not true... i.e. if your application depends on that registry entry, would you please ASAP:

post here, so we know that you're still interested in pushing this forward;
comment on https://github.com/cardano-foundation/CIPs/pull/586 about how you think your use case justifies a CIP-0067 registry entry, if you're not already or eventually prepared to submit a CIP with a complete definition of ADA SubHandle tokens with a complete spec for their metadata & versioning.

Thank you everyone for taking the time to think through this. I believe that the CIP-67 process is more refined now. I also think that after these discussions we have come to the conclusion that ADA Handles Virtual SubHandles are a specific enough implementation that generalizing the schema into a new asset_name_label class may not be beneficial to anyone else.
We did brainstorm a way to define a "sub-asset" class where an owner of one token can associate many "sub-tokens" to that owner token. There may be something there that we could make work and it would be general enough for others to build upon. For example, for projects that would like to offer owner-controlled fractionalizing of their tokens.
But overall, I think we are ready to throw in the towel on creating a new asset class and just use one of the private labels from the 0-15 range.

What is the process for closing these? Does the OP just hit the button, or is there a process?

@papag00se the ideal process is to do what you have just done: to summarise the issue for anyone who might come across this PR later.  Sometimes editors will close a PR with no updates, but since you've submitted the conclusion I think it makes the most sense to close this yourself. 😇