useSignMessage leads to deep link issue on mobile

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.6.2
Current Behavior
In our web application, we requires users to sign a message in order to log in. On mobile, we're seeing that prompting users to sign a message leads to the deep link issue described here where the browser will fail to deep link into the app. It would be great to have a similar hook to usePrepareSendTransaction for signing messages so that we can prepare any async work before users are prompted to sign.
Expected Behavior
A hook like usePrepareSignMessage that does any async work ahead of time
Steps To Reproduce

Prompt user to connect any mobile wallet using WalletConnect
Prompt user to sign message
User gets redirected to a new web page rather than deep linked into the app

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Hey @melissafzhang – do you think you can provide a minimal reproducible example? I can't seem to reproduce this.

@jxom do you have a default project I can play with? I've been trying to get WalletConnect working on codepen but I keep getting No wagmi client found. Ensure you have set up a client: https://wagmi.sh/docs/client https://codesandbox.io/s/stoic-brattain-jjvrlz?file=/src/App.js

Interesting about the error. I tried to pull down the repository but struggled to get it to run (ran into some framer-motion dependency issues).
I created a minimal sandbox here: https://codesandbox.io/s/crimson-meadow-idpb05?file=/pages/index.tsx
However, I don't get these deep linking issues on this sandbox.

@jxom With your example, I'm not able to connect my wallet at all. After I click "Wallet Connect" and choose Rainbow, it automatically redirects me to the Rainbow web page.
https://user-images.githubusercontent.com/38673112/186278036-d8751d4a-9463-4bfd-875f-6764a7f7c90b.mov

Interesting. I get a different outcome :\
https://user-images.githubusercontent.com/7336481/186279411-0d3514e9-5c7e-401e-b545-2fa6f1097b93.mp4

Is your internet connection a bottleneck?

:/ wow totally different haha... My wifi is pretty fast but my phone is kind of old. Just to confirm, are you using Safari?

Yep! Safari on iOS 16.0

I am going to close this issue as it's now becoming stale and we are unable to reproduce. If a clear minimal reproducible example is provided, we can reopen this issue.

Yup no problem! I figured out that the issue was specific to my device. Thanks!


Jenijune13 build gunicorn and footer

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@vinothkumar66 I believe this was opened by mistake? If so, could you close the PR?

Seems like a mistake, closing... If the intention was to open a PR please re-open


[CI] Add jenkinsfile for dubbo snapshot deployment

What is the purpose of the change
Add jenkinsfile for dubbo snapshot deployment
Currently existing job is configured by web ui, but it's better to use Jenkinsfile to make configuration more easy to modify. More information about Jenkinsfile, refer to https://jenkins.io/doc/book/pipeline/jenkinsfile/
Brief changelog
The jenkins job every trigger by two conditions:

every two hour check git repo update, if it has new commit, will start
every 12 hours will run without commit check (in case first rule trigger build but travis still pending)

This job will do following step

check if current commit already deployed
check current commit status is pass (depends on travis CI result)
check current project is using snapshot version
do snapshot deployment
save current commit id

Verifying this change
https://builds.apache.org/job/Apache Dubbo/job/apache-dubbo-snapshot-deployment/
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4205 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4205      +/-   ##
============================================
+ Coverage     62.93%   62.97%   +0.04%
+ Complexity      507      505       -2
============================================
  Files           769      769
  Lines         33058    33214     +156
  Branches       5217     5249      +32
============================================
+ Hits          20806    20918     +112
- Misses         9858     9896      +38
- Partials       2394     2400       +6

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/remoting/transport/AbstractChannel.java
75% <0%> (-12.5%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
66.66% <0%> (-4.77%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyClientHandler.java
64.7% <0%> (-3.72%)
0% <0%> (ø)

...bo/rpc/cluster/support/FailbackClusterInvoker.java
67.21% <0%> (-3.28%)
0% <0%> (ø)

...pache/dubbo/registry/support/AbstractRegistry.java
78.54% <0%> (-3.07%)
0% <0%> (ø)

...exchange/support/header/HeaderExchangeHandler.java
64.75% <0%> (-2.46%)
0% <0%> (ø)

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b97a0b...55e5aed. Read the comment docs.

Fix some issue when new version first deploy snapshot. new snapshot version 2.7.3 is ready. (https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo-container-api/)
This jenkins job runs for a few weeks, I think it's ready to merge now.


Support reproducible restarts with RRTMGP

Please see https://github.com/CliMA/RRTMGP.jl/issues/544 for the description of the issue.
### Tasks
- [ ] https://github.com/CliMA/ClimaAtmos.jl/issues/3384

Closed by #3384


Update mergify rules to auto merging

Updated Mergify rules to wait for centos CI to go green before merging the PR, even if the PR has two approvals

/retest all

/retest all

Merging this one as it blocks PR from  auto merging if the CI is not passed


Windows tests failures in jballerina-integration-tests module

Description:
please refer following build scan.
https://scans.gradle.com/s/qzivs3c3twlfw/tests/failed
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

The http tests are failing, hence assigning stdlib folks

The failed HTTP test cases are outdated and no longer maintained in the repo. Hence closing the issue.
PS: Existing windows test failures are captured via these issues


docs: Link to occ from refresh table docs.

Prompted by https://github.com/crate/crate/issues/4711

Codecov Report

Merging #4891 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4891      +/-   ##
============================================
- Coverage     82.08%   82.07%   -0.02%
+ Complexity    10653    10644       -9
============================================
  Files          1293     1293
  Lines         44537    44537
  Branches       5629     5629
============================================
- Hits          36559    36554       -5
- Misses         5337     5341       +4
- Partials       2641     2642       +1

Impacted Files
Coverage Δ
Complexity Δ

...ration/collect/collectors/OrderedDocCollector.java
75% <ø> (-25%)
5% <ø> (-2%)

...va/io/crate/operation/projectors/DMLProjector.java
62.96% <ø> (-14.82%)
4% <ø> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
85% <ø> (-10%)
2% <ø> (ø)

...tor/transport/distributed/SingleBucketBuilder.java
66.66% <ø> (-9.53%)
6% <ø> (-1%)

core/src/main/java/io/crate/types/ArrayType.java
73.84% <ø> (-7.7%)
24% <ø> (-2%)

...in/java/io/crate/breaker/RamAccountingContext.java
80% <ø> (-5%)
19% <ø> (-3%)

...sport/executionphases/InterceptingRowReceiver.java
89.74% <ø> (-2.57%)
16% <ø> (-1%)

...ticsearch/indices/recovery/BlobRecoverySource.java
71.25% <ø> (-2.5%)
6% <ø> (ø)

...peration/collect/collectors/CrateDocCollector.java
87.59% <ø> (-2.19%)
41% <ø> (-1%)

...a/io/crate/operation/fetch/NodeFetchOperation.java
83.67% <ø> (-2.05%)
13% <ø> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79a0a2...62f7af6. Read the comment docs.


[open] add functionality for file opening

The ability to open a file in both the default file browser and web browser is needed in case a user needs to quickly inspect files.

Addressed by PR https://github.com/odeke-em/drive/pull/352


Update values.yaml

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. helm upgrade on minikube, helm install on gke)

It looks like @fitiany hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot


[dashboard] Deprecate superset published API

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[X] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Following SIP-31, this change deprecates superset/dashboard/<dashboard_id>/published/ API endpoint. Simply using the new API PUT method.
Need to merge #8911 first.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

Codecov Report

Merging #8914 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #8914   +/-   ##
=======================================
  Coverage   58.97%   58.97%
=======================================
  Files         359      359
  Lines       11333    11333
  Branches     2787     2787
=======================================
  Hits         6684     6684
  Misses       4471     4471
  Partials      178      178

Impacted Files
Coverage Δ

...set/assets/src/dashboard/actions/dashboardState.js
40.96% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce5add...7f2366a. Read the comment docs.


[multistage] implement naive round robin operator chain scheduling

fixes #9615
This is a follow-up to #9711 and follows the design outlined in this design doc.
This PR implements a round robin operator chain scheduling algorithm and sets up the interface for future PRs that will implement more advanced scheduling. As of this PR, we can be guaranteed that all queries will make progress (see the change in pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SSBQueryIntegrationTest.java, you can now run it under situations with only 2 cores available) but the algorithm is still very hungry for CPU (queries with nothing in their mailbox will still be scheduled).
Review Guide:

look at OpChainSchedulerService and RoundRobinScheduler, which contains the logic of yielding threads when there's no more work to be done for a given operator chain
look at WorkerQueryExecutor to see where this new scheduler is now wired in as opposed to running the work directly on the old worker pool
I added some logic to PhysicalPlanVisitor to collect information on mailboxes so that later we can hook up the mailboxes with the scheduling logic. Probably should have been done in a follow-up PR but 🤷 I was already at it. Let me know if you want me to split it up
Look at the corresponding tests

cc @walterddr @61yao

Codecov Report

Merging #9753 (2f952ef) into master (2f640ff) will decrease coverage by 45.53%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #9753       +/-   ##
=============================================
- Coverage     70.08%   24.54%   -45.54%
+ Complexity     4980       53     -4927
=============================================
  Files          1951     1944        -7
  Lines        104561   104502       -59
  Branches      15836    15836
=============================================
- Hits          73279    25653    -47626
- Misses        26155    76234    +50079
+ Partials       5127     2615     -2512

Flag
Coverage Δ

integration1
?

integration2
24.54% <0.00%> (-0.09%)
:arrow_down:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pinot/query/runtime/QueryRunner.java
0.00% <0.00%> (-81.56%)
:arrow_down:

...uery/runtime/executor/OpChainSchedulerService.java
0.00% <0.00%> (ø)

...ot/query/runtime/executor/RoundRobinScheduler.java
0.00% <0.00%> (ø)

...ot/query/runtime/executor/WorkerQueryExecutor.java
0.00% <0.00%> (-92.31%)
:arrow_down:

...query/runtime/operator/MailboxReceiveOperator.java
0.00% <0.00%> (-78.95%)
:arrow_down:

...g/apache/pinot/query/runtime/operator/OpChain.java
0.00% <0.00%> (ø)

.../pinot/query/runtime/plan/PhysicalPlanVisitor.java
0.00% <0.00%> (-96.78%)
:arrow_down:

...va/org/apache/pinot/query/service/QueryServer.java
0.00% <0.00%> (-72.50%)
:arrow_down:

...in/java/org/apache/pinot/spi/utils/BytesUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/BaseRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1427 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update variable type decl in internal function _webui_round_to_memory_block to resolve sing-comp warning

Nice you fixes already most of the warnings! Good work :100:


How can I install torch_geometric in remote server without manually do it.

📚 Installation
How can I install torch_geometric in remote server without manually do it.
I have no choice now but to use cloud to run my program and the problem I always have with torch_geometric is that it can't simply be install by "pip install torch_geometric" but i have to also install torch_sparse, ... etc which depends on cuda version and pytorch version.
I usually have to do it manually everytime, but now I am using third party cloud and have no choice to manually install those packages.
Is there a way to install torch_geometric without manually do it?
it is probably something super easy, but like other programming problem if I don't know the word to search for the problem, no way I can find solution unless I have to read the a whole books on similar topic.

Are you speaking about a requirements file? I'm not really sure by what you mean by you cannot automate it. As long as your PyTorch/CUDA version is known, you can easily install it via pip. Can you give a concrete example which shows the problem of installing PyG?

May be I just don't know how to do it correctly.
I tried using both pip freeze and conda list to produce requirements file.
but from what I know is that torch_geometric have to install based on specified version of CUDA and python.  Wil using pip freeze or conda list allow for this flexibility where the neccesary will be install automatically based on verion of CUDA and python? because when I run it in Floydhub, a cloud service. The machine fail to install torch_geometric.
Note: I don't know cuda version of floydhub machine. May be there is a way to get this information, I haven't look in to it.
Thank you

@rusty1s Could you please follow up with this matter? i am the same person as Anak2016.

Sorry, I was offline for a few days.
In general, you need to know the CUDA version installed to install PyTorch Geometric. You can find it by running nvcc --version or torch.version.cuda.
Then you can create a requirement file like this:
-f https://pytorch-geometric.com/whl/torch-1.5.0.html
torch-scatter==latest+${CUDA}
torch-sparse==latest+${CUDA}
torch-geometric


"Failed to decode constructor arguments" when running script

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (3cdee82 2024-02-15T00:19:38.655803000Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
Similar issue to https://github.com/foundry-rs/foundry/issues/6571. This only broke with 3cdee82 – the nightly release from the day before fd87629 works fine
Havent been able to isolate it specifically, and the current optimism build doesn't trigger the bug.
For context: the script running is used to deploy around 200 contracts with about 1.5k transactions. Will update if I manage to get it into a sample repo
Error message:

2024-02-15T21:48:11.162433Z ERROR forge::cmd::script::transaction: Failed to decode constructor arguments contract=Some("AddressComponent") signature=constructor(address,uint256) is_create2=false constructor_args=90b9317c2b3be33c164621cf9cae64736f6c63430008110033000000000000000000000000610178da211fef7d417bc0e6fed39f05609ad788

fd87629...3cdee82
Either https://github.com/foundry-rs/foundry/pull/7108 or https://github.com/foundry-rs/foundry/pull/7109
Are you able to reproduce on every run?
If you can't get a minimal repro, could you share the full logs with RUST_LOG=debug,evm::traces=trace?

@DaniPopes managed to reproduce it here. Note that it only doesn't work when broadcasting to a node
https://github.com/chlwys/foundry_decode_constructor_reproduction


How to refresh

In my render() upon a state change I return
<TreeView treeData={data} />
However, the jstree does not appear to refresh. I've tried using jstree's functions destroy and refresh without any luck.
Are there any examples that do this?
Thanks!

It doesn't support that, if you would like to you will have to make changes to the jstree in the src $('#data').jstree(true).refresh();

v0.0.3
Here's the code in my render().
    var data =  'core' : {
        'check_callback' : true,
        'data' : treeData
      },
      'plugins': ['types']
    };

    return (
      <TreeView treeData={data} />
    );

treeData is just an array of jstree nodes.

Refresh feature was added in 0.1.0. See demo app in demo folder.

Great work! This works perfectly.


[ENH] - Document the ideal way for conda-store to be deployed

Feature description
We need documentation on how to deploy conda-store for production environments. Currently we have information about local docker and kubernetes installations, and a bit of information about using NFS, etc. But it would be useful to have full-featured documentation about production installations, including recommendations about instance size, NFS, storage, etc.
Value and/or benefit
Improved documentation will make conda-store more accessible to new users.
Anything else?
No response

related to https://github.com/conda-incubator/conda-store/issues/895 and https://github.com/conda-incubator/conda-store/issues/944

Closing as a duplicate of https://github.com/conda-incubator/conda-store/issues/727


apkmd does not work for Instagram.

it failing saying 0/1 app has been downloaded, the config file is here
{
    "options": {
      "arch": "arm64-v8a"
    },
    "apps": [
      {
        "name": "ig",
        "org": "instagram",
        "repo": "instagram-instagram"
      }
    ]
}

thanks for hotfix


Error: failed to start mongod

I am creating an app with hapi.js and MongoDB change streams. I followed this tutorial to figure out how to setup replica sets to get change streams to work: http://thecodebarbarian.com/a-nodejs-perspective-on-mongodb-36-change-streams.html. I am using the Mongoose driver and there is a heading toward the bottom of the tutorial titled "Change Streams in Mongoose" that explains how to configure Mongoose to use change streams.
The problem that I am having is that I get this error in the terminal when I start my app:
Error: failed to start mongod with options --bind_ip=localhost,--port=31000,--dbpath=/path/to/mongodb-repl-sets/31000,--replSet=nrd-mongo-repl

I have my app configured with Nodemon, so if I save a server-side file, then Nodemon will trigger a reload and the error goes away and the database seems to work without any problems. However, the error will display at random times after I save a server-side file.
This is the part of my server.js file that sets up the replica set and connects to MongoDB through Mongoose:
// -----------------------------------------------------
// Configure the MongoDB replica set for change streams
// -----------------------------------------------------
await console.log(createTimestamp(), `"Starting replica set..."`);

// Start a 3-node replica set on ports 31000, 31001, 31002.
// The name of this replica set is "nrd-mongo-repl".
const replSet = new ReplSet('mongod', [
  { options: { bind_ip: 'localhost', port: 31000, dbpath: `${__dirname}/mongodb-repl-sets/31000` } },
  { options: { bind_ip: 'localhost', port: 31001, dbpath: `${__dirname}/mongodb-repl-sets/31001` } },
  { options: { bind_ip: 'localhost', port: 31002, dbpath: `${__dirname}/mongodb-repl-sets/31002` } }
], { replSet: 'nrd-mongo-repl' } );

// Initialize the replica set
await replSet.purge();
await replSet.start();
await console.log(createTimestamp(), `"Replica set is running"`);

// ------------------------------------------------------
// Connect to MongoDB server through the Mongoose driver
// ------------------------------------------------------
const replSetUri = 'mongodb://localhost:31000,localhost:31001,localhost:31002/nrd?replicaSet=nrd-mongo-repl';

// Once the hapi server is started, connect to MongoDB server through Mongoose using a
// JavaScript await function. The {} is an empty options object, which is an optional argument.
const dbConnection = await Mongoose.connect(replSetUri, {});

// Create at least one of your collections here to avoid this error "MongoError: cannot
// open $changeStream for non-existent database: <db_name>"
await Mongoose.connection.createCollection('discharge_time');

Does anyone have any thoughts on what is going on?
Thank you for your help!

I'm also using the same source code. My problem is that (it seems) the database is being restarted... I lose all my collections every time I run the server.
I also have an open question at Stackoverflow: https://stackoverflow.com/questions/49540337/node-js-mongodb-mongodb-topology-manager-why-im-i-losing-my-collections
I came here expecting to understand those purge and start commands, but the readme didn't help much. Any tips on what's going on?

Hi @SamuelEarl and @jcotero,
What this script is doing is destroying a recreating a ReplicaSet every time that the script is run. That is what the purge and start do. @jcotero, that is why whenever you run the script, you are losing all of your data. Similarly, if you run this script too many times in close proximity, you may attempt to delete and/or create a replicaset two times in a row, which may lead to the error that @SamuelEarl is seeing.
If you are attempting to do more than try out changestreams, and want to use them in a production environment, I would not use mongodb-topology-manager, but would instead follow our tutorials for deploying a replica set.
Let me know if you have further questions.

I am having a similar issue, this seemed like an easy way to set up a replica set locally for testing and development. However, I would love to keep my data when I run my script to start the replica set again. Is there such a feature here that I am not aware of? If I try to just start it again with start() or restart(), I get the MongoError: already initialized error (not doing this in close proximity).

@midthun AFAIK there isn't currently a way to do that. If you'd like the feature, you can request it on our JIRA.

Closing this for now, please file JIRAs for any further questions. Thanks!

@daprahamian Ok I see, no problem, it is just a nice to have feature. For now I can work around it with a few modifications. If I set this to true, I can restart the replica set with the start() function so it does not purge the data. However, I do not know the side effects of this.

I hit on the same problem and would want to retain data after every restart. The 'this' you mentioned at line 188 is no more there (blank now). Can you please let me know what that line refers to? Thanks

Ignore my question. There is an option "restart" that does the job of starting the replica set without purge


vue devtools is blank

I can't view vue devtools. It's just a blank page.
Open devtools, click Vue tab.

Node version: v12.15.0
NPM version: 6.13.7
vue-cli version: 4.2.2
Operating System: MacOS 10.15.3

additionally, my terminal returns this error:
┏ Electron -------------------

  2020-02-10 15:23:24.257 Electron[5045:71217] *** WARNING: Textured window <EventDispatchingWindow: 0x7f891c4791d0> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.

┗ ----------------------------

┏ Electron -------------------

  [5045:0210/152344.653738:ERROR:CONSOLE(1)] "Uncaught SyntaxError: Unexpected token ...", source: chrome-extension://vue-js-devtools/build/devtools.js (1)

┗ ----------------------------

tried to downgrade to node v10.16.0 and npm v6.9.0 since these are the versions currently installed in my other machine (linux) which the vue devtools works. Unfortunately, still not working on my mac. :(

SOLVED! Apparently, this is not an issue with this repo but an issue with the chrome version i'm having. It's too old to work with latest version of vue devtools extension specifically the Chrome 58 that ships with my electron 1.7.2. Also I found out that the last version of chrome where the latest vue devtools is working is chrome 60. So I tried upgrading the electron to v2.0.0 which ships with chrome 61 and it works!


Multitap Keyboard

Implements additional mode for moving the cursor in the edited text. Swipe down for changing modes.

Thanks!


Update README.md

Checklist:

[x] The plugin is specifically built for Neovim.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] It's not already on the list.
[ ] It supports treesitter syntax if it's a colorscheme.

Thanks for the PR!
Something went wrong with the syntax of your lines, when you fix that I can merge your PR. See the failing CI.


Minor rewording of 2.6 to make it easier to understand.

Addressing #321 with minimal changes. (No changes in spec semantics)
@reactive-streams/contributors Please review and vote.

Wanting to look at the changeset shows me a 500 error page; does it work for you?

@ktoso Same here. I had trouble with #339 as well the past week, mostly since the Amazon outage. The patch links from the email work for me:
https://github.com/reactive-streams/reactive-streams-jvm/pull/342.patch
https://github.com/reactive-streams/reactive-streams-jvm/pull/342.diff

Thanks, will have a look

Yeah, I have issues with GH as well, 500s all over the place.

Uhm, if the change is only to add the , then I don't think it's helping enough.
The linked issue proposes a more wordy version, however we could find a balance between the current and the new one perhaps?
How about:

A Subscriber MUST call Subscription.cancel() when it is no longer interested (or able) in receiving signals from its Publisher, even without the Publisher having signaled onError or onComplete.

not, it changes "the Publisher" to "its Publisher" and adds the comma.

I see, the valid to its... still is not completely clear though, as witnessed by that issue. We don't use that wording anywhere else either AFAICS. A subscription can be valid, but this is the single case we used it for a Subscriber.

No, it is not about the Subscriber being valid, it is about the Subscription not being valid.

Proves my point that it's easy to confuse the "it" then though?

@ktoso Very good point. See my second attempt.

Hmm, simple wording and I think it does indeed cover all the cases we mean here.
The extended intent section explains what we mean well now.
Sounds good to me 👍

@reactive-streams/contributors Yay or nay?

@reactive-streams/contributors Ping!


Spanish translation for "A Propos"

The "About" page is just a placeholder:
https://github.com/promethe42/cocorico/blob/master/api/db/pages/acerca-de-esto.html
We need to fix it by translating/adapting the content of:
https://github.com/promethe42/cocorico/blob/master/api/db/pages/a-propos.md
Documentation about how to translate pages is here:
https://github.com/promethe42/cocorico/blob/master/doc/Localization.md#translating-pages

@virgile-dev could you take care of this please?


Hung connection to vertica

Hi! Can anybody help with understaning problem? I've got code like in examples:
	connDB, err := sql.Open("vertica", dwhConnection)
	if err != nil {
		return fmt.Errorf("failed to connect to dwh: %w", err)
	}
	defer connDB.Close()

	vCtx := vertigo.NewVerticaContext(context.Background())
	// Only keep 40,000 rows in memory at once.
	if err = vCtx.SetInMemoryResultRowLimit(40000); err != nil {
		return fmt.Errorf("failed to setup vertica context 'in memory row limit' param: %w", err)
	}

	if err = connDB.PingContext(vCtx); err != nil {
		return fmt.Errorf("failed to ping dwh vertica database: %w", err)
	}

set env VERTICA_SQL_GO_LOG_LEVEL=1 to debug connection:
Dec  8 22:35:08.397069 DEBUG connection: Established socket connection to vertica-proxy:5435
Dec  8 22:35:08.397491 DEBUG connection: -> Startup (packet): ProtocolVersion:00030009, DriverName='vertica-sql-go', DriverVersion='1.2.0', UserName='*******', Database='DWH', SessionID='vertica-sql-go-1.2.0-7362-1638992108', ClientPID=7362
Dec  8 22:35:08.444401 DEBUG connection: <- Authentication: 3, extraAuthData 0 byte(s)
Dec  8 22:35:08.444528 DEBUG connection: -> Password: *********
Dec  8 22:35:08.507618 DEBUG connection: <- Authentication: 0, extraAuthData 0 byte(s)
Dec  8 22:35:08.523473 DEBUG connection: <- ParameterStatus: client_locale='en_US@collation=binary'
Dec  8 22:35:08.523540 DEBUG connection: <- ParameterStatus: client_label='vertica-sql-go-1.2.0-7362-1638992108'
Dec  8 22:35:08.523576 DEBUG connection: <- ParameterStatus: server_version='v9.2.1-5'
Dec  8 22:35:08.523618 DEBUG connection: <- ParameterStatus: long_string_types='on'
Dec  8 22:35:08.523648 DEBUG connection: <- ParameterStatus: protocol_version='196616'
Dec  8 22:35:08.523676 DEBUG connection: <- ParameterStatus: standard_conforming_strings='on'
Dec  8 22:35:08.523710 DEBUG connection: <- KeyData: BackendPID=15975925, CancelKey=320BD015'
Dec  8 22:35:08.523746 DEBUG connection: <- Notice: (7) notice(s)
Dec  8 22:35:08.523779 DEBUG connection: <- ReadyForQuery: TransactionState='I'
Dec  8 22:35:08.523842 DEBUG stmt: stmt.QueryContextRaw(): select now()::timestamptz
Dec  8 22:35:08.523986 DEBUG connection: -> Query: Query='select now()::timestamptz'
Dec  8 22:35:08.573319 DEBUG connection: <- RowDesc: 1 column(s)
Dec  8 22:35:08.573379 DEBUG connection: <- Cmd Completed:
Dec  8 22:35:08.573404 DEBUG connection: <- ReadyForQuery: TransactionState='T'
Dec  8 22:35:08.573424 DEBUG connection: Setting server timezone offset to +03
Dec  8 22:35:08.573524 DEBUG connection: -> Parse: PreparedName='S736216389921082019727887', Command='select 1 as test', NumArgs=0
Dec  8 22:35:08.573587 DEBUG connection: -> Describe: TargetType=S, TargetName='S736216389921082019727887'
Dec  8 22:35:08.573614 DEBUG connection: -> Flush
Dec  8 22:35:08.622399 DEBUG connection: <- ParseComplete
Dec  8 22:35:08.622474 DEBUG connection: <- ParameterDesc: 0 parameter(s) described: []
Dec  8 22:35:08.622516 DEBUG connection: <- RowDesc: 1 column(s)
Dec  8 22:35:08.622623 DEBUG connection: -> Close: TargetType=S, TargetName='S736216389921082019727887'
Dec  8 22:35:08.622677 DEBUG connection: -> Flush
Dec  8 22:35:08.622724 DEBUG connection: <- Cmd Description: tag=SELECT, hasRewrite=false, rewrite=''

So, thats it) after that nothing else happens

The regular workflow should have a DEBUG connection: <- CloseComplete line at the end of such log file. Looks like the server doesn't send a CloseComplete message to the client.
One suspicious thing in this log file is that after the session is created there is an additional Notice message. Unfortunately the go client currently doesn't implement notice reading. Therefore please try to modify the source code  msgs/benoticemsg.go and print the notice, or connect with vsql to see if there are any notice pop up after login.

I should make an enhancement to print out the Notice messages if running at log level 0.


feat: add support for custom heading CSS class

This is a Goldmark supported feature that isn’t reflected in GeekDoc theme.
This PR only adds support for custom heading CSS classes (.className and class="class1 class2"). Custom ids are not supported, nor any other custom attribute (#id and attrName=attrValue).

@xoxys I’m not a go developer by I tried to follow the code to better understand this behavior and here’s what I found.
In Hugo’s code for hooks rendering, we can see that when rendering a heading hook, the AttributeString function is called on the node to retrieve the id attribute:
anchori, _ := n.AttributeString("id")

Source
And in Goldmark’s code I found these lines that seem to be relevant:
	if b.AutoHeadingID {
		id, ok := node.AttributeString("id")
		if !ok {
			generateAutoHeadingID(heading, reader, pc)
		} else {
			pc.IDs().Put(id.([]byte))
		}
	}

Source

So it seems that the id custom attribute processing for headings is already handled by default.


Gtk::CssProvider::ParsingErrorSignal#connect does not compile

css_provider = Gtk::CssProvider.new
css_provider.parsing_error_signal.connect do |section, error|
  # debug
end

This code does not compile with the following error message:
In lib/libadwaita/lib/gi-crystal/src/auto/gtk-4.0/css_provider.cr:198:74

 198 | ::Box(Proc(Gtk::CssSection, GLib::Error, Nil)).unbox(_lib_box).call(section, error)
                                                                      ^---
Error: no overload matches 'Proc(Gtk::CssSection, GLib::Error, Nil)#call' with types Gtk::CssSection, Pointer(Void)

Overloads are:
 - Proc(*T, R)#call(*args : *T)

The generated code:
      def connect(handler : Proc(Gtk::CssSection, GLib::Error, Nil), *, after : Bool = false) : GObject::SignalConnection
        _box = ::Box.box(handler)
        handler = ->(_lib_sender : Pointer(Void), lib_section : Pointer(Void), lib_error : Pointer(Void), _lib_box : Pointer(Void)) {
          # Generator::BuiltInTypeArgPlan
          section = Gtk::CssSection.new(lib_section, :none)
          error = lib_error
          ::Box(Proc(Gtk::CssSection, GLib::Error, Nil)).unbox(_lib_box).call(section, error)
        }.pointer

        handler = LibGObject.g_signal_connect_data(@source, name, handler,
          GICrystal::ClosureDataManager.register(_box), ->GICrystal::ClosureDataManager.deregister, after.to_unsafe)
        GObject::SignalConnection.new(@source, handler)
      end

GI-Crystal version: 0.12.0
Crystal version: 1.4.1

I should add that this used to work in an older version of GI-Crystal

I see the issue.... there's no ArgPlan for error parameters, so it's just using the same value without any conversion, like it does for Int32 and other basic types.

I took a look on this, the proper fix isn't soooo simple, because the proper fix need to make the signal parameters arrive as a exception class translated from the GError, not GLib::Error, in fact GLib::Error shouldn't exist as a wrapper of GError, but as a base class for all exceptions generated from GError.
i.e. GError must be tagged as a hand made type on bindings.yml, but the current implementation of handmade type is too open due to GValue implementation, so I need to re-think a bit how to deal with these handmade types.


Clean ML benchmark

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue
I think this implementation is more in a "sklearn style". It may be easier to other people to use it.
How Has This Been Tested (if it applies)
I have tested it only with a small optimization. It could be great to test it by launching experiments seqmltuning and naiveseqmltuning.
Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.

Also you'll need to update the values in the tests ;)

The error for "install" is super weird to me... maybe we just rerun...

Ok I have changed the test values, sorry I always forget that.
For the number of variables, I agree but I can't find an easy way to simplify this, as there are many ml experiments in the class.

The error for "install" is super weird to me... maybe we just rerun...

I don't know :(
I have updated the tests, they are ok now, but the install error is still there.

The error for "install" is super weird to me... maybe we just rerun...

I don't know :(
I have updated the tests, they are ok now, but the install error is still there.

I'll investigate, looks unrelated

@fteytaud can you try merging master? There were some incompatibilities with recent sphinx (doc building) versions

@fteytaud can you try merging master? There were some incompatibilities with recent sphinx (doc building) versions

Seems ok, you're a boss ;-)

merged, thanks ;)


Investigate test_truncated_gz failure

Possibly the simplification of PipedGzipReader.read introduced in #14 sometimes causes a test failure, as seen on Travis.

Hmmm. I can run this through hyperfine with a 100 runs. Using conda I can test multiple interpreters.
If that helps.

I can now actually reproduce this locally with while tox; do true; done. This failed after a minute or so.

I think it’s a timing issue in PipedGzipReader.close().

I cannot reproduce the error on my machine. Which makes me suspect that it is a race condition, and this machine is just to fast to get it.
I made a small fix in #17 which should prevent the race condition from happening.

I also thought that adding a .wait() would be an idea, but there’s a big warning in the docs that it can deadlock when used with stdout=PIPE, which we do use. The intention of the previous code within read() and readline() was to trigger the .wait() only when we were sure that we were already at EOF, which would imply that the process won’t write any further data into the kernel buffer.
I’m not sure that a self.process.terminate() followed by an immediate self.process.wait() cannot deadlock. When you read just a couple of bytes from a file and then close it before reaching the end, perhaps the signal gets queued and delivered only after the process has managed to fill the buffer already.
However, I don’t see this happening in my tests and the PR fixes this particular issue.

I also thought that adding a .wait() would be an idea, but there’s a big warning in the docs that it can deadlock when used with stdout=PIPE, which we do use. The intention of the previous code within read() and readline() was to trigger the .wait() only when we were sure that we were already at EOF, which would imply that the process won’t write any further data into the kernel buffer.

When working on pytest-workflow I have experienced issues with .wait() because I was piping stdout and sterr of a workflow engine to a PIPE and the process hanged in production because long pipelines produce more stdout than 64kb.
Apperently Popen.communicate() can fix this. I used it successfullty with pytest-workflow.
https://docs.python.org/3.5/library/subprocess.html#subprocess.Popen.communicate

I’m not sure that a self.process.terminate() followed by an immediate self.process.wait() cannot deadlock. When you read just a couple of bytes from a file and then close it before reaching the end, perhaps the signal gets queued and delivered only after the process has managed to fill the buffer already.

I think .wait() should not cause any problems here. There are two situations when the file is closed:

Everything finished succesfully. The process has an exit code. No problems there.
The (python) program crashes and pigz is still running. Process.terminate will run in this case. Even if the kernel buffer is full the process gets a signal and it will terminate. If the buffer is full it is just waiting for it the buffer to empty, but that should not block process signals.

So far the theory. I guess time will tell if it is correct...

Popen.communicate() reads all the data at once. Because we want to stream in xopen, it doesn’t help here.
Regarding wait + terminate, I forgot that if a process (pigz) is blocked on a write(), it will still receive signals. So it should work.

Note that I just pushed bfc714d, which fixes another issue that I saw when running the tests repeatedly. I’ll tag another release shortly.

Revisiting this because of https://github.com/pycompression/xopen/pull/63#issuecomment-837644218: My comment about communicate() wasn’t thought out – I understand that we should rewrite everything to use communicate(), but using communicate() just before shutdown should be fine and solve this problem.


C#, SharePoint CSOM equivalent?

I am looking to expose this functionality as a customization using a C# solution, to give the end user the ability to change it themselves.

@bforsyt4 Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Why does this library alter the main videojs player's source?

If the Ads are playing in some floating iframe anyway, why should this plugin EVER concern itself with the source of the video player?
Just trying to understand it better.
I'm really struggling to make use of it at all.
I have an app I'm writing that needs to continuously play video back to back.  It doesn't appear this plugin was designed for this.
When I try to do manual ad breaks the plugin doesn't work anymore.
Can anyoen tell me which version of video.js, videojs-contrib-ads, is most compatible?
Sadly, I'm also needing videojs-contrib-hls which requires a certain version of video.js of like 5.10+ i think. :-/

Hey Josh,
We handle the video source because the IMA plugin needs to know when the source changes in order to work properly. The way we make sure we know when this happens is by forcing you to do it through us. You should be able to modify our playlist example to do what you want though - simply listen for the video to finish via addContentAndAdsEndedListener, and use the code in the playlist example's onPlaylistItemClick to play your next video. Let me know if there's anything else I can do to help out.
Thanks!
Shawn

Closing but feel free to re-open if you have any more questions :)


Hack together a working heroku add-on

This doesn't include the authorization of rendering new images, just the handshake and account setup for heroku resources.

Procfile change then A+ would merge


Feature/LINK-1774 keyclock authentication

DRAFT!

Thanks for good PR comments, I commited the fixes

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5be6c00) 99.73% compared to head (967bef2) 99.72%.
Report is 4 commits behind head on main.

Files
Patch %
Lines

src/domain/app/header/Header.tsx
93.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   99.73%   99.72%   -0.02%
==========================================
  Files         595      568      -27
  Lines        9796     9440     -356
  Branches     2161     2060     -101
==========================================
- Hits         9770     9414     -356
  Misses         23       23
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix config to point to new resource

Fixes https://github.com/cgs-earth/pygeoapi-geoconnex-examples/issues/1 and makes pygeoapi use a resource which is valid and doesn't 404
Kyle said

also the id_field: is now evidently SITE_CODE

However, I did not find that to be the case. I am finding that I can query fine without changing the id_field but if i change it to SITE_CODE it causes an error.
landing-pages-1  |   File "/pygeoapi/pygeoapi/provider/sqlite.py", line 265, in __load
landing-pages-1  |     assert len([item for item in result
landing-pages-1  | AssertionError: id_field not present

that is very confusing. the basic API call https://data.ca.gov/api/3/action/datastore_search?resource_id=ab3f524c-850f-40e4-b27a-6cae7154add5&limit=5
shows SITE_CODE is a field and the older one isnt

Fixes #1 and makes pygeoapi use a resource which is valid and doesn't 404
Kyle said

also the id_field: is now evidently SITE_CODE

However, I did not find that to be the case. I am finding that I can query fine without changing the id_field but if i change it to SITE_CODE it causes an error.
landing-pages-1  |   File "/pygeoapi/pygeoapi/provider/sqlite.py", line 265, in __load
landing-pages-1  |     assert len([item for item in result
landing-pages-1  | AssertionError: id_field not present

This is showing an error in the sqlite provider not the CKAN provider. Might be part of the issue


Migration Failed

Bug report
Issue Description
Fresh Install on CentOS, failed on migrate.

   Illuminate\Database\QueryException  : SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json null, `created_at` timestamp null, `updated_at` timestamp null) default cha' at line 1 (SQL: create table `roles` (`id` int unsigned not null auto_increment primary key, `name` varchar(191) not null, `description` varchar(191) null, `permission_type` varchar(191) not null, `permissions` json null, `created_at` timestamp null, `updated_at` timestamp null) default character set utf8mb4 collate 'utf8mb4_unicode_ci' engine = InnoDB ROW_FORMAT=DYNAMIC)

  at /opt/websites/bagisto/vendor/laravel/framework/src/Illuminate/Database/Connection.php:664
    660|         // If an exception occurs when attempting to run a query, we'll format the error
    661|         // message to include the bindings with SQL, which will make this exception a
    662|         // lot more helpful to the developer instead of just the database's errors.
    663|         catch (Exception $e) {
  > 664|             throw new QueryException(
    665|                 $query, $this->prepareBindings($bindings), $e
    666|             );
    667|         }
    668|

  Exception trace:

  1   Doctrine\DBAL\Driver\PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json null, `created_at` timestamp null, `updated_at` timestamp null) default cha' at line 1")
      /opt/websites/bagisto/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:63

  2   PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json null, `created_at` timestamp null, `updated_at` timestamp null) default cha' at line 1")
      /opt/websites/bagisto/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:61

  Please use the argument -v to see more details.

Preconditions
1. 0.1.8, 0.1.7
2. System : CentOS

Steps to reproduce
Used both UI installation or command line installation.

Hello @lYesterdaYl Your version of MariaDB does not support JSON columns. We recommend you to use latest MariaDB or Mysql version which have support for JSON columns.

I see. Thanks.


better dynamicparam

hello
its possible to reinvent the concept of dynamic param fo better and simple  use
Steps to reproduce
dynamicparam {
  param(
    [parameter(mandatory)]
    $param1,
    [switch]
    $param2,
    [validateSet('a','b','c')]
    [char]$letter
  )

  # and here the logic

  return $dynamicObject
}

How about this:
[cmdletbinding()]
param()

dynamicparam {
    class MyDynamicParams {
        [Parameter()][string]$ABC
    }

    return ($dynamicParams = [MyDynamicParams]::new())
}

begin {
    $dynamicParams.ABC
}

This works today.

Well, it's better than the "standard" implementations we usually see, but it's still very much an arcane syntax -- I don't think I've ever seen anyone talk about approaching it like that before.
Additionally, any parameter attributes that need script blocks cannot be used there, as classes prevent you from supplying script blocks to member attributes. So that rules out [ValidateScript()], [ArgumentCompleter()] and I think a few others. I can think of a few ways to skirt those rules in this specific case, but I think the case can still be made that dynamicparam... leaves a lot to be desired, unfortunately. 🙁

I think @bielawb first proposed this technique, maybe in this talk.
Script blocks in attributes can be made to work with classes - it just requires delaying the creation of the scriptblock until the attribute is instantiated.
Dynamic parameters were never meant to be easy. There was always a strong desire for a declarative style, and whenever possible, improving on that instead of making dynamic parameters "easier".
As an example, parameter sets can get unwieldy in some cases. There were some discussions around "mutual exclusion sets" to make it easier to express things like "one of a,b,c and one of d,e,f". I don't recall any concrete proposals from those discussions, but it's an example of the strong desire to remain as declarative as possible.

Declarative is great, it doesn't have to be "easy". But I think dynamicparam strongly tends towards more "obscure" than "declarative", really. 😕


File I/O

Class / etc to support easy reading and writing of files. Both binary and textual, as well as console I/O

[ ] foo

Fixed by #31 and #32.


installation script updates

Hi @mithro , this is where my current copy is at - my notes are in README.md, I integrated some of the changes back to the script.
This should work - I haven't done a full test on a new system yet though (and there's still one or two instructions in the README.md that could be put back into the script)

These where merged in https://github.com/timvideos/HDMI2USB-misoc-firmware/commit/8d96a8742abba8820b27aa4f4facd4946650f0f1


Replace git-code-format-maven-plugin by spotless-maven-plugin

Replace git-code-format-maven-plugin by any of the following :

formatter-maven-plugin (used in https://github.com/marcwrobel/jbanking/),
or spotless-maven-plugin (used in https://github.com/lescastcodeurs/lcc-slack-bot/).

They are more simple to use.

Will try with spotless-maven-plugin, it is has way more features.


Remove datasets requirement and instead rely on download from huggingface_hub

We currently handle all dataset manipulation through our own dataset classes, all we are using datasets for is a convenient wrapper for downloading the dataset to disk. We should be able to just rely on huggingface_hub to do the same thing.

@joecummings is this still something we plan to do?

To be clear, as it currently stands it's not possible to provide a custom dataset in the appropriate chat template/format in the config file? By custom dataset I mean one that is not listed on this page, but is available as a dataset on the Huggingface Hub, or locally, and follows the right template.

Just to be clear, can I use my custom dataset, stored locally in the appropriate Alpaca format, by providing it in the config file to train the model? Specifically, can I override the Lora_70B.yaml config file with my custom dataset as shown below (dataset = my_custom_dataset ) or in any other way?
tune run --nproc_per_node 2 lora_finetune_distributed --config llama3/8B_lora \
dataset = my_custom_dataset

@amitb-nuscale if you are trying to use a custom dataset builder function that returns a Dataset class in python code, then yes you can provide an override like you did (but without spaces):
dataset=module.path.to.my_custom_dataset
If you have a local file saved in the alpaca format that you want to use instead, then you need to override the source and data_files parameters:
dataset.source=csv dataset.data_files=my_data_file.csv

@RdoubleA - May be I am missing something. But changing it into dataset.source=csv dataset.data_files=my_data_file.csv is generating an expected error - alpaca_dataset() got an unexpected keyword argument 'data_files'.
Here is the code:
When I removed the torchtune.dataset.alpaca_dataset from the config.yaml file , It states that 'NoneType' object has no attribute 'split'.

Hey @amitb-nuscale, are you still running into issues? We have since updated the tutorial on custom datasets that may address your problems. If you are still facing difficulties, would you be able to post a separate issue on it since it is unrelated?
@joecummings @kartikayk closing this issue because based on offline discussions around iterable / streaming datasets, we will need to rely on HF Datasets APIs and load_dataset for more configuration around sharding / shuffling for iterable datasets.


docs(guide/pipes): follow-up to #1654

Dart-side updates following #1654:

Updates to follow style guide
Suites passed:

public/docs/_examples/pipes/dart

Suites failed (known issue - #1761):

public/docs/_examples/pipes/ts

@kwalrath : ready for review.

LGTM.


Add private and multi-provider tests for CAPZ

What this PR does
Introduces two tests lanes: Private CAPZ WCs and CAPV WCs on CAPZ MCs.
Checklist

[x] Update changelog in CHANGELOG.md.

Trigger e2e tests
/run cluster-test-suites

/run cluster-test-suites

I will split CAPV on CAPZ tests and Private CAPZ tests. Closing this one.


Discuss: deprecate BB & BB/Marionnete from program.

BB is really good as a starting point to show how MVC frameworks help us, so that people can appreciate Angular/Ember's doings better.

There's less hype about BB, though there're projects both starting and in maintaince mode present

Maybe, a better way would be to make an introduction to React & use some lib for model and routing. Basically, BB alternative w/o all that jQuery stuff.

Done & done.


Move hydrotools namespace packages to separate repositories

The "Run Slow Unit Tests" Action has been failing for some time. The hydrotools ecosystem has grown to the point that it has become unwieldy to track and manage the code-base through a single repository. With hundreds of unit tests, it's a nightmare to troubleshoot issues, especially if an error is originating from a subpackage unrelated to your pull request. I propose we spin-off the subpackages under the python directory to their own repositories.
I know everyone is extremely busy nowadays (and we seem to be getting busier as time progress!), so I'm not asking for any major contributions. I'm just opening this ticket to track and discuss progress. I can handle the code migration, NOAA-OWP formalities, and re-deployment to PyPI.
This repository will remain as a mock convenience package that just installs a selection of other hydrotools. namespace packages.

I am not overly fond of this idea, however i'm open to the idea. If the primary motivator for the change is difficulty troubleshooting CI, I think we should first look at changes we can make to improve our CI actions. I empathize with you that it can be difficult to parse through the CI logs to find the one line you are interested in, but I think we can improve our quality of life by, for example testing each subpackage in its own CI action.
I personally, from a developers experience perspective, like that everything is in one repo. Its less mental overhead, for me, to track down an issue in any of the packages if they are all in the same place. I will also make the argument that we've retained consistency and quality in coding and documentation practices across the subpackages in part due to our single repo organization. With subpackages living in other repositories it seemingly becomes less apparent differences in documentation style for example.
As a user of hydrotools, its really nice that I can just go to one place if I need to see the source, create an issue, or share the tool suite with an interested party. I do less searching to find what I want when everything is nearby.

@aaraney So, instead of having "Run Unit Tests", we have "Run  Unit Tests"? This seems like a good compromise that would also keep the strengths you mentioned.
Are there any other QOL changes we could make to differentiate the packages for maintenance purposes, without having to resort to a full diaspora?

@aaraney So, instead of having "Run Unit Tests", we have "Run subpackage Unit Tests"? This seems like a good compromise that would also keep the strengths you mentioned.

Yep, that is what im thinking.

Are there any other QOL changes we could make to differentiate the packages for maintenance purposes, without having to resort to a full diaspora?

Issue and PR tracking is sometimes a pain. We could add labels for each subpackage and I can look into creating a github action that automatically tags issues and PRs with the appropriate label(s)? That is the only QOL issue that comes to mind at the moment. Do you have others, @jarq6c?


JavaScript error when starting the programm without admin rights

**OS: Windows 7
**Issue Descriptions: I can´t start the programm since 5 days. every time i want to start it i get the following error. It only happens when i want to start it as normal non-admin-rights-user. as admin it works.

Please go to
%APPDATA%\Google Play Music Desktop Player\json_store

And delete the .settings.json file.  This issue has been fixed in master

thank you!


[url] tag does not work when URL does not have a schema prefixed

When using the DefaultCodeDefinitionSet the following does not work: [url=www.google.com]www.google.com[/url]. This is not unreasonable since it is technically not a valid URL, however most users will expect this to work. It may be fruitful to include a mechanism where it can default to the http:// schema when none is found.
This issue has been raised on behalf of https://github.com/r04r/Minichan/issues/21.

Same error with img tag.
UrlValidator is very strong, it works with filter_var($input, FILTER_VALIDATE_URL) and do not pass relative URLs and URLs without scheme. May be parse_url() is better way for URL validation.

I have some code here to deal with this, but it's pretty hacky: https://github.com/r04r/Minichan/commit/0d2853443216d42df808a8d6d622930db38595ab


Create the outgoing email components to remind students to take their evaluations

This is going to be the most sane in the admin with a drop-down


Unified Pallet Storage Version

We want to have a unified way of storing the storage version of a pallet so that it can be referenced (and adjusted) by migrations.
We will probably want to generate it from or tie it to the versioning of the pallet crate.
related to #6482

related to https://github.com/paritytech/substrate/issues/7210
I think this can be close now that all pallet write their version to storage.
as written there: https://github.com/paritytech/substrate/issues/7210#issuecomment-714526491
I think the migration strategy is in good shape now

closed by #7208


Fix block admin for definition list and text/image

These didn't work after #13 - just a minor import bug.

Ship it


Working Effectively with Legacy Code (3%)

Page 8:

Most reams that I've worked with have tried to manage risk in a very conservative way. They minimize the number of changes that they make to the code base. [...] "What? Create another method for that? No. I'll just put the lines of code right here in the method, where I can see them and the rest of the code. It involves less editing, and it's safer."

It's tempting to think that we can minimize software problems by avoiding them, but, unfortunately, it always catches up with us. When we avoid creating new classes and methods, the existing ones grow larger and harder to understand.

When people don't make changes often they get rusty at it. Breaking down a big class into pieces can be pretty involved work unless you do it a couple of times a week. When you do, it becomes routine. You get better at figuring out what can break and what can't, and it is much easier to do.

Page 13:

One of the most frustrating things about larger tests is that it seems that we can have error localization if we run our tests more often, but it is an illusion. It we run our tests and they pass, and then we make a small change and they fail, we know precisely where the problem was triggered

Page 18:

The Legacy Code Change Algorithm:

1. Identify change points.
2. Find test points.
3. Break dependencies.
4. Write tests.
S. Make changes and refactor.

Skipped Part II, Part III:
Page 311-312:

Has this ever happened to you? You start to work on one thing, and then you think, "Hmm, maybe I should clean this up." So you stop to refactor a bit, but you start to think about what the code should really look like, and then you
pause. That feature you were working on still needs to be done, so you go back to the original place where you were editing code. You decide that you need to call a method, and then you hop over to where the method is, but you discover
that the method is going to need to do something else, so you start to change it while the original change was pending [...] Well, that's how it goes on some teams. A pair has an exciting programming episode, but the last three quarters of it involve fixing all of the code they broke in the previous quarter.

I have this little mantra that I repeat to myself when I'm working: "Programming is the art of doing one thing at a time." When I'm pairing, I always ask my partner to challenge me on that, to ask me "What are you doing." If answer
more than one thing, we pick one.

Page 317:

It's easy to make a mistake and have no idea that you've broken the software. A second set of eyes definitely helps. Let's face it, working in legacy code is surgery, and doctors never operate alone.

Page 328:

Superficially, this might look like we're making things pretty for prettys-sake, but one pervasive problem in legacy code bases is that there often aren't any layers of abstraction; the most important code in the system often sits intermingled with low-level API calls. We've already seen how this can make testing difficult, but the problems go beyond testing. Code is harder to understand when it is littered with wide interfaces containing dozens of unused methods. When you create narrow abstractions targeted toward what you need, your code communicates better and you are left with a better seam.


doc: Effective Go section about Errors uses type assertion without mentioning errors.As

What version of Go are you using (go version)?
n/a
Does this issue reproduce with the latest release?
n/a
What operating system and processor architecture are you using (go env)?
n/a
What did you do?
Read about errors in "Effective Go"
What did you expect to see?
Examples that use the current best way of inspecting concrete error values or acknowledgment that there is a better way with a reference to details about the alternatives.
What did you see instead?
Use of a type assertion in the style typically used with Go 1.12 and earlier without any mention of errors.As available since Go 1.13.

See #28782

Marking needs decision. I think whether this is fixed is wholly dependent on #28782, but it's still useful to have this issue linked and hanging around to add to the pile of related issues.


Add LOM analysis to the API documentation and remove the word quantization from the wrong file

https://github.com/Qiskit/qiskit-metal/blob/7aac15529e6b7c40151f37279568fe674308f21d/qiskit_metal/analyses/__init__.py#L46

The tree structure was reorganized, and the init has LOM .


Facing an issue with the within command

INTERSECTS area circle 1.2379 101.2823 100 is returning the area required
but WITHIN area circle 1.2379 101.2823 100 is not returning any area, although the circle lies inside the area.

Hi Akshay, are you still running into problems with this issue?
Your INTERSECTS and WITHIN queries will both return objects from the specified area collection when those respective objects intersect or are fully within the circle.
Are there objects in the area that should be returned that are not?

I'm closing this issue for now. But feel free to reopen if needed. Thanks.


[IOTDB-1239]Incorrect datetime value can be inserted into iotdb successfully

Description
Resubmit PR

#3000

fix IOTDB-1239
https://issues.apache.org/jira/browse/IOTDB-1239
support big datetime parse and query
IoTDB> SET STORAGE GROUP TO root.sg
Msg: The statement is executed successfully.
IoTDB> CREATE TIMESERIES root.sg.d1.s2 WITH DATATYPE=DOUBLE, ENCODING=PLAIN
insert into root.sg.d1(time,s2 ) values<PHONE_NUMBER>000000,8.76);
Msg: The statement is executed successfully.
IoTDB>
Msg: The statement is executed successfully.
IoTDB> select * from root.sg.d1;
+-------------------------------+-------------+
|                           Time|root.sg.d1.s2|
+-------------------------------+-------------+
|+51853-10-03T00:00:00.000+08:00|         8.76|
+-------------------------------+-------------+
Total line number = 1
It costs 0.328s
IoTDB> select * from root.sg.d1 where time=51853-10-03T00:00:00.000+08:00
+-------------------------------+-------------+
|                           Time|root.sg.d1.s2|
+-------------------------------+-------------+
|+51853-10-03T00:00:00.000+08:00|         8.76|
+-------------------------------+-------------+
Total line number = 1
It costs 0.049s

Coverage increased (+0.01%) to 53.066% when pulling 6670214df990e25a25dff8b041c093468ae9b9ee on IOTDB-1239 into bc6c4af55e1b9b2272f4b2bb7e2f78a985b810e2 on master.


Do not split runestone payload into MAX_SCRIPT_ELEMENT_SIZE pushes

I believe the MAX_SCRIPT_ELEMENT_SIZE limit is only checked when outputs are spent. Since runestones begin with an OP_RETURN, they can never be spent, so we do not need to chunk the payload.
It's unfortunate that I'm only realizing this now, since if I had known it earlier, we could have required the payload to be a single data push, since without the MAX_SCRIPT_ELEMENT_SIZE limit, there's no reason to accept multiple data pushes in the payload.
This is marked as a draft PR, because although I think it's correct, I want to actually test it against Bitcoin Core to confirm before merging.

Confirmed this locally with a split which generated a 4550 byte OP_RETURN. OP_RETURNS are totally uninterpreted and unexecuted. The script does not even need to be valid, and the script element size of 520 byte is unchecked.

I believe the MAX_SCRIPT_ELEMENT_SIZE limit is only checked when outputs are spent

I can confirm that.
I had to change MAX_OP_RETURN_RELAY to get sendrawtransaction to accept an OP_RETURN longer than 83 bytes but that's the only change I had to make. Then I was able to create a 200 edict runestone with a 874 byte OP_PUSHDATA2:
$ bitcoin-cli -regtest getrawtransaction a6c3de3d9b9fb0f849816e7127987aef4e7245af0a041f1feebde089ea5481dc 1 | jq -r .vout[0].scriptPubKey.hex
6a5d4d6a0300c5090164000000640100006402000064030000640400006405000064060000640700006408000064090000640a0000640b0000640c0000640d0000640e0000640f000064100000641100006412000064130000641400006415000064160000641700006418000064190000641a0000641b0000641c0000641d0000641e0000641f000064200000642100006422000064230000642400006425000064260000642700006428000064290000642a0000642b0000642c0000642d0000642e0000642f000064300000643100006432000064330000643400006435000064360000643700006438000064390000643a0000643b0000643c0000643d0000643e0000643f000064400000644100006442000064430000644400006445000064460000644700006448000064490000644a0000644b0000644c0000644d0000644e0000644f000064500000645100006452000064530000645400006455000064560000645700006458000064590000645a0000645b0000645c0000645d0000645e0000645f000064600000646100006462000064630000646400006465000064660000646700006468000064690000646a0000646b0000646c0000646d0000646e0000646f000064700000647100006472000064730000647400006475000064760000647700006478000064790000647a0000647b0000647c0000647d0000647e0000647f00006480010000648101000064820100006483010000648401000064850100006486010000648701000064880100006489010000648a010000648b010000648c010000648d010000648e010000648f0100006490010000649101000064920100006493010000649401000064950100006496010000649701000064980100006499010000649a010000649b010000649c010000649d010000649e010000649f01000064a001000064a101000064a201000064a301000064a401000064a501000064a601000064a701000064a801000064a901000064aa01000064ab01000064ac01000064ad01000064ae01000064af01000064b001000064b101000064b201000064b301000064b401000064b501000064b601000064b701000064b801000064b901000064ba01000064bb01000064bc01000064bd01000064be01000064bf01000064c001000064c101000064c201000064c301000064c401000064c501000064c601000064c701
$ python
>>> 1748/2
874.0
>>> 0x036a
874

That's 6a (op_return) 5d (op_13) 4d (op_pushdata2) 6a03 (874 bytes) ...

Would this change be backwards compatible?


Pin PyPi release (setup.py) to dcoscli==0.4.16

This strategy is working for me in dcos-commons.
I'll rework CLI initialization next sprint to free myself from my dependencies on the old cli.


Allow for autogen bypass, partial fix for #264 #252 #207, ref #303

This PR does a few things:

Small tweaks to autogen script to include the python command in the generated files
Inline the autogenerated files needed for the csp main build

Add tests to enforce that these dont deviate

Tweak cmake autogen command to look for existing autogen files

Looks like I'll need to add some bypasses for these static asserts which we'd expect to fail if generated in one location and compiled on another

[ ] forgot to push the test


Upgrade to Swift 5, remove warnings, Xcode 10.2, update PromiseKit, and bump version

Swift 5 update, fix warning, update PromiseKit and Xcode 10.2

Tests run locally but build Travis CI is running 10.1

Thank you for your help!

@yannickl thank you for this great library!


docs for tranining of unpaired images show wrong plot

In the cyclegan training doc you are showing the plot for pix2pix. You may want to replace it with:
https://github.com/GaParmar/img2img-turbo/blob/main/assets/examples/training_evaluation_unpaired.png

Oooh, good catch!
The docs should be updated now!


Paint sizes

We need each lens galaxy to carry a size with it (in arcsec) - these can be painted on at the same time as the colors. If a different catalog was used for positioning than painting, or if we were going to generate mock images from scratch, we'd need this size. Having the size in the catalog could also be useful when understanding the sim images later, too.

Tom Collett's lenspops code can help with this, at the same time as providing colors. I'll close this for now, and re-issue as part of the new program.


feat: Initial test case for repl errors

Hey @devsnek
I worked on the item : https://github.com/nodejs/repl/issues/6
This should be the beginning for adding test cases for repl 👍
Have a look and let me know we can follow the same pattern for other test cases too. Once this is good, may be we can then add scripts to run our tests on our npm build process.
Thanks for your time on this.

ping @devsnek

ping @devsnek

i'd like to see if we can set up CI of some sort for the linter before we merge more PRs

@devsnek Any update on this?

I know it's a long time, any update here? cc @devsnek


acc.pollStatus is not a function

[2020-5-3 04:50:47] TypeError: acc.pollStatus is not a function | stdout
at /usr/local/lib/node_modules/homebridge-sure-petcare-platform/index.js:66:21 | stdout
at /usr/local/lib/node_modules/homebridge-sure-petcare-platform/node_modules/sure_petcare/index.js:112:9 | stdout
at SurePetcareApi. (/usr/local/lib/node_modules/homebridge-sure-petcare-platform/node_modules/sure_petcare/index.js:144:13) | stdout
at Request.self.callback (/usr/local/lib/node_modules/homebridge-sure-petcare-platform/node_modules/request/request.js:185:22) | stdout
at Request.emit (events.js:180:13) | stdout
at Request. (/usr/local/lib/node_modules/homebridge-sure-petcare-platform/node_modules/request/request.js:1154:10) | stdout
at Request.emit (events.js:180:13) | stdout
at IncomingMessage. (/usr/local/lib/node_modules/homebridge-sure-petcare-platform/node_modules/request/request.js:1076:12) | stdout
[2020-5-3 04:50:47] Got SIGTERM, shutting down Homebridge...

at Object.onceWrapper (events.js:272:13)
stdout

at IncomingMessage.emit (events.js:185:15)
stdout

at endReadableNT (_stream_readable.js:1101:12)
stdout

at process._tickCallback (internal/process/next_tick.js:114:19)
stdout

[2020-5-3 04:50:47] Got SIGTERM, shutting down Homebridge...

What version of homebridge are you running?

Not sure what I was on before but I just updated to 1.0.4 to check. Same error.

I just updated my doctor container to the latest image and redownloaded all my plugins. Same error :/

Just tried installing the latest oznu/homebridge docker container for fun and no luck. I was using marcoraddatz-homebridge before.  Same error either way.
acc.pollStatus is not a function
Thanks for your help

What version of the plugin are you running? I just released an unrelated update to support battery info - but just want to be sure we're troubleshooting the same version.

Also, I just upgraded my testing setup to homebridge 1.0.4 (latest as of writing) and am not getting that issue, so that rules out the newest homebridge being an issue (at least for now).

Looks like 1.2. I just uninstalled and reinstalled to make sure I'm using the latest.
Strangely I'm now getting this error :/
[5/8/2020, 10:42:25 AM] TypeError: Cannot read property 'where' of undefined | stdout
at /usr/local/lib/node_modules/homebridge-sure-petcare-platform/accessories/SurePetcareOccupancySensor.js:53:42 | stdout

I’m getting this error as well now.  Not sure why.  It worked fine then today I restarted Homebridge and am now getting the Acc poll status error.

Just upgraded to Hoobs 3.2.4 and the Sure plugin is working again.

Closing due to inactivity. If this is still an issue please feel free to re-open this issue. Thanks!


type A = ['🌑', '👾'] [-1]   //----------->  🌑" | "👾"

// ?????  TypeScript 4.4.2
type A = ['🌑', '👾']
type B = A[-1] //-------------> "🌑" | "👾"
type C = -1 extends keyof A ? 1 : 0 //-------------> 1

playground

👾 Sokoban Game in Pure TypeScript Type System

Repo: https://github.com/fc01/TypeGame

Is this a bug report? A feature request? Just advertisement? No clue.


luaPackages.moonscript: Correct package version to dev-1

Motivation for this change
The "0.5.0-1" rockspec on luarocks has a bug, resulting in it pulling the current git master version, which is what we have effectively been using.
Given that 0.5.0-1 is the latest release, is 6 years old, and that there have been some bug fixes since then, we do actually want to be using the git master version, but we also want to be using the correct rockspec (particularly as alt-getopt has been replaced by argparse in the moon binary).
@teto
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Looks good. Would be nice to have a nixpkgs-review pr 147093 with it. Can't run it since I have no space left on my disk :/

@teto I skipped it initially because AFAICT there aren't any downstream consumers of moonscript within nixpkgs. A run of nixpkgs-review has now confirmed this:
shados@dreamlogic[~/nixpkgs-pr (moonscript-correct-package-version ↩=)] λ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/shados/.cache/nixpkgs-review/rev-4a96192479dfeda6d21bb21664bcf027791ed7e8/nixpkgs 9c1e0e0244d978115924f77541eeb7dd2809022d
Preparing worktree (detached HEAD 9c1e0e0244d)
Updating files: 100% (29000/29000), done.
HEAD is now at 9c1e0e0244d Merge pull request #147117 from VergeDX/arcmenu
$ nix-env --option system x86_64-linux -f /home/shados/.cache/nixpkgs-review/rev-4a96192479dfeda6d21bb21664bcf027791ed7e8/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit --no-ff 4a96192479dfeda6d21bb21664bcf027791ed7e8
Automatic merge went well; stopped before committing as requested
$ nix-env --option system x86_64-linux -f /home/shados/.cache/nixpkgs-review/rev-4a96192479dfeda6d21bb21664bcf027791ed7e8/nixpkgs -qaP --xml --out-path --show-trace --meta
4 packages updated:
lua51Packages.moonscript (0.5.0-1 → 1) lua52Packages.moonscript (0.5.0-1 → 1) lua53Packages.moonscript (0.5.0-1 → 1) luajitPackages.moonscript (2.1.0-2021-10-27-moonscript-0.5.0-1 → 2.1.0-2021-10-27-moonscript-dev-1)


Scaffolding (on 1.0 project) a view with model and without dbContext fails for Delete, Details and List templates

Repro Steps:

Create a new Asp.Net Core project with Individual auth (1.0)
Add a model class

public class Car
{
   public int ID { get; set;}
   public class Name { get; set;}
}

Right click Views folder -> Add View

Scaffolding fails with below error

This patch fix is approved. Please follow the normal code review / pull request process and make sure you make the change in the correct branch.

I am assuming the other issue for 1.1 (https://github.com/aspnet/Scaffolding/issues/427) is also approved.

@prafullbhosale I will approve it shortly; just waiting for the build system to be up and running for the patch.

@prafullbhosale / @mlorbetske - do you guys have a status update on this bug? We want to get the patches done ASAP.

The branches are setup and included in the Coherence-Patch builds.
Only remaining part is to bump up the versions for latest packages. Have those on PR https://github.com/aspnet/Scaffolding/pull/453 and https://github.com/aspnet/Scaffolding/pull/452

Fixed in rel/tools-1.0.1

Preview builds of this patch fix should be available on the following feeds:

https://dotnet.myget.org/gallery/aspnet-1-0-5-may2017-patch-public (for fixes in the 1.0.x release)

Feed URL to add to NuGet.config: https://dotnet.myget.org/F/aspnet-1-0-5-may2017-patch-public/api/v3/index.json

https://dotnet.myget.org/gallery/aspnet-1-1-2-may2017-patch-public (for fixes in the 1.1.x release)

Feed URL to add to NuGet.config: https://dotnet.myget.org/F/aspnet-1-1-2-may2017-patch-public/api/v3/index.json

If you have a chance, please try out these preview builds and let us know if you have any feedback!

Tested the scaffolding packages from the feed, the fix looks good.


Getting intermittent 'This repo is not configured yet..' for configured repo's

Also see discussion on #2
Seems to occur somewhat frequently on https://tokenlog.xyz/HausDAO/pokemol-web

Pokemol's repo was using an xDAI token. Updated their config with a default chainId.

Pokemol's repo was using an xDAI token. Updated their config with a default chainId.


refix #471 for service-ttl error

Though #471 had been closed, I think the fix was not enough.
The real reason is, when the service was registered, the TTL was not set.
So we need to set TTL when RegisterHealthCheck() is false and heartbeatProperties.isEnabled() is true.
The settings are:
spring.cloud.consul.discovery.register-health-check=false
spring.cloud.consul.discovery.heartbeat.enabled=true
I had fixed it with my SpringCloud Finchley, and copied the changes to master branch.
And I find that function createCheck() had been fixed with moving HealthCheckCriticalTimeout to the top of this function.
There are still two places need to be fixed!

Can you explain better the situation why you think this is a problem?
Also, tests are required.

@spencergibb Consul supports two types of healthcheck, one is consul call the healthcheck interface， which is enabled when spring.cloud.consul.discovery.register-health-check=true, another is the service reports its own status to consul,which is enabled by spring.cloud.consul.discovery.heartbeat.enabled=true. If the consul server does not receive the status report from service in TTL time, the service will be marked as unavailable.
In the method createCheck(), it will add TTL time to service registeration info when ttlConfig.isEnabled(), and health check interface will not be set. But when register-health-check is not true, createCheck() will not be called, and the TTL will not be set. It's the reason for #471. So we need to set TTL when heartbeat.enabled is true.
Are you means  heartbeat.enabled=true must  be set both with register-health-check=true? I think it's two types of healthcheck and heartbeat shoud not depend on register-health-check.
I will add test later.

I found that the method  createCheck() was fixed by PR #500, and it was related to issue #490.
In #490, the user had set heartbeat.enabled to true, but had not set register-health-check to false.
But I don't think heartbeat.enabled must be used with register-health-check=true.

I had added tests in my branch.


[Bug] Fail to build docker (cwebp)

To Reproduce
Steps to reproduce the behavior: docker build . (with NODE_ENV=production)
Expected behavior
Should not fail
Actual behavior
fail
Step 7/10 : RUN npm ci --only-production --silent
 ---> Running in 1c89267a05c4

Skipping 'fsevents' build as platform linux is not supported
Love nodemon? You can now support the project via the open collective:
 > https://opencollective.com/nodemon/donate

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.14.1/linux_musl-x64-72_binding.node
Download complete
Binary saved to /app/node_modules/node-sass/vendor/linux_musl-x64-72/binding.node
Caching binary to /root/.npm/_cacache/node-sass/4.14.1/linux_musl-x64-72_binding.node
Binary found at /app/node_modules/node-sass/vendor/linux_musl-x64-72/binding.node
Testing binary
Binary is fine
  ⚠ Command failed: /app/node_modules/cwebp-bin/vendor/cwebp -version
Error loading shared library libGL.so.1: No such file or directory (needed by /app/node_modules/cwebp-bin/vendor/cwebp)
Error loading shared library libX11.so.6: No such file or directory (needed by /app/node_modules/cwebp-bin/vendor/cwebp)
Error loading shared library libXxf86vm.so.1: No such file or directory (needed by /app/node_modules/cwebp-bin/vendor/cwebp)
Error loading shared library libXi.so.6: No such file or directory (needed by /app/node_modules/cwebp-bin/vendor/cwebp)
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __fprintf_chk: symbol not found
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __memcpy_chk: symbol not found
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __vfprintf_chk: symbol not found
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __sprintf_chk: symbol not found
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __snprintf_chk: symbol not found
Error relocating /app/node_modules/cwebp-bin/vendor/cwebp: __longjmp_chk: symbol not found

  ⚠ cwebp pre-build test failed
  ℹ compiling from source
  ✔ cwebp built successfully
  ✔ pngquant pre-build test passed successfully
  ✔ optipng pre-build test passed successfully
  ⚠ Command failed: /app/node_modules/mozjpeg/vendor/cjpeg -version
Error relocating /app/node_modules/mozjpeg/vendor/cjpeg: __snprintf_chk: symbol not found
Error relocating /app/node_modules/mozjpeg/vendor/cjpeg: __memcpy_chk: symbol not found
Error relocating /app/node_modules/mozjpeg/vendor/cjpeg: __longjmp_chk: symbol not found
Error relocating /app/node_modules/mozjpeg/vendor/cjpeg: __fprintf_chk: symbol not found

  ⚠ mozjpeg pre-build test failed
  ℹ compiling from source
  ✖ Error: Command failed: /bin/sh -c autoreconf -fiv
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --force
configure.ac:23: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1

    at /app/node_modules/bin-build/node_modules/execa/index.js:231:11
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 0)
  ⚠ Response code 404 (Not Found)
  ⚠ gifsicle pre-build test failed
  ℹ compiling from source

Notes

Thanks for the report. Going to close this one and handle all Docker related issues in #454.


x/website: "The Laws of Reflection" blog post needs a section on generics

The blog post The Laws of Reflection, while old, is still a commonly used in-depth resource for the reflect package. There needs to be a preamble explaining how the reflect package is affected by generics (it isn't).
cc: @ianlancetaylor
cc: @robpike

I would say rather than a preamble, it just needs a clarification in a couple of places. It also needs a tweak because Println etc. now handle reflect.Type more nicely, which invalidates a tiny bit of explanation.


Error when exporting model as SavedModel

Bug description
Attempting to export a model as a SavedModel using the code snippet from the docs gives:
  AttributeError: Exception encountered when calling layer 'db_net' (type DBNet).

    in user code:

        File "/home/sam/development/workspace/ml/python/lib/python3.10/site-packages/doctr/models/detection/differentiable_binarization/tensorflow.py", line 241, in call  *
            out["preds"] = [preds[0] for preds in self.postprocessor(prob_map.numpy())]

        AttributeError: 'Tensor' object has no attribute 'numpy'

    Call arguments received by layer 'db_net' (type DBNet):
      • x=tf.Tensor(shape=(None, 1024, 1024, 3), dtype=float32)
      • target=None
      • return_model_output=False
      • return_preds=False

Code snippet to reproduce the bug
import tensorflow as tf
from doctr.models import db_resnet50

model = db_resnet50(pretrained=True)
input_t = tf.random.uniform(shape=[1, 1024, 1024, 3], maxval=1, dtype=tf.float32)
_ = model(input_t, training=False)
model.save('/home/sam/development/workspace/ml/ds_restnet50')

Error traceback
  AttributeError: Exception encountered when calling layer 'db_net' (type DBNet).

    in user code:

        File "/home/sam/development/workspace/ml/python/lib/python3.10/site-packages/doctr/models/detection/differentiable_binarization/tensorflow.py", line 241, in call  *
            out["preds"] = [preds[0] for preds in self.postprocessor(prob_map.numpy())]

        AttributeError: 'Tensor' object has no attribute 'numpy'

    Call arguments received by layer 'db_net' (type DBNet):
      • x=tf.Tensor(shape=(None, 1024, 1024, 3), dtype=float32)
      • target=None
      • return_model_output=False
      • return_preds=False

Environment
/home/sam/development/workspace/ml/python/lib/python3.10/site-packages/tensorflow_addons/utils/tfa_eol_msg.py:23: UserWarning:

TensorFlow Addons (TFA) has ended development and introduction of new features.
TFA has entered a minimal maintenance and release mode until a planned end of life in May 2024.
Please modify downstream libraries to take dependencies from other repositories in our TensorFlow community (e.g. Keras, Keras-CV, and Keras-NLP).

For more information see: https://github.com/tensorflow/addons/issues/2807

  warnings.warn(
Collecting environment information...

DocTR version: v0.6.0
TensorFlow version: 2.12.0
PyTorch version: N/A (torchvision N/A)
OpenCV version: 4.7.0
OS: Ubuntu 22.04.2 LTS
Python version: 3.10.6
Is CUDA available (TensorFlow): No
Is CUDA available (PyTorch): N/A
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA

Deep Learning backend
  warnings.warn(
is_tf_available: True
is_torch_available: False

Btw if it helps, same issue running from inside docker:
FROM python:3.8-slim

ENV PYTHONUNBUFFERED 1
ENV PYTHONDONTWRITEBYTECODE 1

COPY ./pyproject.toml /tmp/pyproject.toml
COPY ./README.md /tmp/README.md
COPY ./setup.py /tmp/setup.py
COPY ./doctr /tmp/doctr
COPY ./export.py /tmp/export.py

RUN apt-get update \
    && apt-get install --no-install-recommends ffmpeg libsm6 libxext6 -y \
    && pip install --upgrade pip setuptools wheel \
    && pip install -e /tmp/.[tf] \
    && pip cache purge \
    && apt-get autoremove -y \
    && rm -rf /var/lib/apt/lists/* \
    && rm -rf /root/.cache/pip

ENTRYPOINT python /tmp/export.py

Where export.py is the script from earlier.


ManifestGenerate - URI malformed

Summary
Getting URI malformed error while generating the manifest using the CLI.
Steps To Reproduce

IMPORTANT
Run "sf project generate manifest -p force-app -t package --api-version=58.0  --json "

{   "code": 1,   "context": "ManifestGenerate",   "commandName": "ManifestGenerate",   "message": "URI malformed",   "name": "URIError",   "status": 1,   "stack": "URIError: URI malformed\n    at decodeURIComponent (<anonymous>)\n    at DecodeableMap.getExistingKey (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/decodeableMap.js:71:32)\n    at DecodeableMap.set (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/decodeableMap.js:53:31)\n    at ComponentSet.add (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/componentSet.js:332:35)\n    at buildComponents (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/componentSet.js:89:25)\n    at ComponentSet.fromSource (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/componentSet.js:93:9)\n    at ComponentSetBuilder.build (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/source-deploy-retrieve/lib/src/collections/componentSetBuilder.js:40:59)\n    at ManifestGenerate.run (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/plugin-deploy-retrieve/lib/commands/project/generate/manifest.js:38:81)\n    at async ManifestGenerate._run (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@salesforce/plugin-deploy-retrieve/node_modules/@oclif/core/lib/command.js:117:22)\n    at async Config.runCommand (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@oclif/core/lib/config/config.js:529:25)\n    at async run (/Users/srinivas.s/.local/share/sf/client/2.15.9-ffa76de/node_modules/@oclif/core/lib/main.js:90:16)",   "exitCode": 1,   "warnings": [] }
Expected result
It should generate package manifest
Actual result
URI malformed"
System Information

sf version --verbose
 CLI Version:
	@salesforce/cli/2.15.9

 Architecture:
	darwin-arm64

 Node Version:
	node-v18.15.0

 Plugin Version:
	@oclif/plugin-autocomplete 2.3.10 (core)
	@oclif/plugin-commands 3.0.4 (core)
	@oclif/plugin-help 6.0.4 (core)
	@oclif/plugin-not-found 3.0.2 (core)
	@oclif/plugin-plugins 3.9.4 (core)
	@oclif/plugin-search 1.0.4 (core)
	@oclif/plugin-update 4.1.3 (core)
	@oclif/plugin-version 2.0.3 (core)
	@oclif/plugin-warn-if-update-available 3.0.2 (core)
	@oclif/plugin-which 3.0.6 (core)
	@salesforce/cli 2.15.9 (core)
	apex 2.3.20 (core)
	auth 2.8.25 (core)
	data 2.6.1 (core)
	deploy-retrieve 1.19.2 (core)
	info 2.6.51 (core)
	limits 2.3.41 (core)
	login 1.2.39 (core)
	marketplace 0.3.1 (core)
	org 2.11.5 (core)
	packaging 1.26.4 (user)
	schema 2.3.31 (core)
	settings 1.4.36 (core)
	sobject 0.2.14 (core)
	source 2.10.45 (core)
	telemetry 2.3.8 (core)
	templates 55.5.17 (core)
	trust 2.6.22 (core)
	user 2.3.39 (core)
	@salesforce/sfdx-scanner 3.18.0 (user)

 OS and Version:
	Darwin 22.6.0

 Shell:
	zsh

Additional information

The command works fine with CLI version 2.13.9 and failing in all latest versions.

Thanks for reporting.  I'll get this bug fixed asap.
If you add this code : console.log(key); above line 71 of this file<EMAIL_ADDRESS>then run the command again the last key logged is the name of the metadata that's it's having a problem decoding.  I'd be interested in what the key is if you're willing to share it.  I can add a test for it as well.

Thanks for reporting. I'll get this bug fixed asap.
If you add this code : console.log(key); above line 71 of this file<EMAIL_ADDRESS>then run the command again the last key logged is the name of the metadata that's it's having a problem decoding. I'd be interested in what the key is if you're willing to share it. I can add a test for it as well.

Thanks for your response @shetzel .
Here is the metadata type and the file path pattern.
documents/xxxxx/xxxx.txt%7E

Hmmm, that decodes just fine.  Regardless, I have a PR to fix this in SDR here: https://github.com/forcedotcom/source-deploy-retrieve/pull/1167

@shetzel Can you please let me know which version of the SF CLI will have this fix?

@ar-srinivas - it will be in the next CLI release candidate (Nov 15th, 2023).  You might be able to install the latest deploy-retrieve plugin now for the fix.

@shetzel What is the exact command to update this specific plugin without upgrading the version from 2.15.9?

To install the latest version of the deploy-retrieve plugin, sf plugins install deploy-retrieve@latest

@shetzel Can you please help us on this error.
I am facing an issue when we run plugins install command, the error remains same for any plugin installation.
Command:
sf plugins install deploy-retrieve@latest
Error:

Version:
CLI Version:
@salesforce/cli/2.17.14
Architecture:
linux-x64
Node Version:
node-v20.9.0
Plugin Version:
@oclif/plugin-autocomplete 3.0.1 (user)
@oclif/plugin-commands 3.0.6 (user)
@oclif/plugin-help 6.0.5 (user)
@oclif/plugin-not-found 3.0.3 (user)
@oclif/plugin-plugins 4.1.7 (user)
@oclif/plugin-search 1.0.6 (user)
@oclif/plugin-update 4.1.3 (user)
@oclif/plugin-version 2.0.6 (user)
@oclif/plugin-warn-if-update-available 3.0.2 (user)
@oclif/plugin-which 3.0.8 (user)
@salesforce/cli 2.17.14 (core)
apex 2.3.20 (user)
data 2.6.3 (user)
info 3.0.1 (user)
limits 3.0.1 (user)
login 2.0.1 (user)
marketplace 1.0.2 (user)
org 2.11.8 (user)
schema 3.0.1 (user)
settings 2.0.2 (user)
sobject 0.2.15 (user)
source 2.11.0 (user)
telemetry 3.1.0 (user)
templates 55.5.18 (user)
trust 3.0.2 (user)
user 2.3.42 (user)
OS and Version:
Linux 6.2.0-1011-aws
Shell:
bash
Root Path:
/home/ubuntu/sf


native_sso_flow.md: detail base64 gotchas

Explain character set and padding requirements for the code verification string. These bit me until I went and inspected the Python example.

Directing people to use a specific character set for the encoding when the type of URL safe base64 encoding required by the SSO is already well defined in https://tools.ietf.org/html/rfc4648#section-5 feels like a bad idea.
Warning people to make sure they're using the base64url encoding instead of the basic base64 encoding (and maybe linking to its definition) would be good, but the way that is done in this PR feels like it would confuse even more people,