Containers fail to create and probe exec errors related to seccomp on recent kernel-5.10 versions

What happened:
After upgrading EKS nodes from v20230203 to v20230217 on our 1.24 EKS clusters after a few days a number of the nodes have containers stuck in ContainerCreating state or liveness/readiness probes reporting the following error:
Readiness probe errored: rpc error: code = Unknown desc = failed to exec in container: failed to start exec "4a11039f730203ffc003b7e64d5e682113437c8c07b8301771e53c710a6ca6ee": OCI runtime exec failed: exec failed: unable to start container process: unable to init seccomp: error loading seccomp filter into kernel: error loading seccomp filter: errno 524: unknown

This issue is very similar to https://github.com/awslabs/amazon-eks-ami/issues/1179. However, we had not been seeing this issue on previous AMIs and it only started to occur on v20230217 (following the upgrade from kernel 5.4 to 5.10) with no other changes to the underlying cluster or workloads.
We tried the suggestions from that issue (sysctl net.core.bpf_jit_limit=452534528) which helped to immediately allow containers to be created and probes to execute but after approximately a day the issue returned and the value returned by cat /proc/vmallocinfo | grep bpf_jit | awk '{s+=$2} END {print s}' was steadily increasing.
What you expected to happen:

Containers to launch successfully and become Ready
Liveness an readiness probes to execute successfully

How to reproduce it (as minimally and precisely as possible):
I don't currently have a reproduction that I can share due to my current one using some internal code (I can hopefully produce a more generic one if required when I get a chance).
As a starting point we only noticed this happening on nodes that had pods scheduled on them which had an exec liveness & readiness probe running every 10 seconds that performs a health check against a gRPC service using grpcurl. In addition to this we also have a default Pod Security Policy (yes we know they are deprecated 😄) that has the following annotation seccomp.security.alpha.kubernetes.io/defaultProfileName: docker/default.
These two conditions seem to be enough to trigger this issue and the values reported by cat /proc/vmallocinfo | grep bpf_jit | awk '{s+=$2} END {print s}' will steadily increase over time until containers can no longer be created on the node.
Anything else we need to know?:
Environment:

AWS Region: Multiple
Instance Type(s): Mix of x86_64 and arm64 instances of varying sizes
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): "eks.4"
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): "1.24"
AMI Version: v20230217
Kernel (e.g. uname -a): 5.10.165-143.735.amzn2.x86_64 #1 SMP Wed Jan 25 03:13:54 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Release information (run cat /etc/eks/release on a node):

BASE_AMI_ID="ami-09bffa74b1e396075"
BUILD_TIME="Fri Feb 17 21:59:10 UTC 2023"
BUILD_KERNEL="5.10.165-143.735.amzn2.x86_64"
ARCH="x86_64"

I've managed to build a reliable reproduction for this issue that I can now share. A quick summary is that the impact seems to depend on instance type. I have been able to consistently reproduce this issue on c5d.xlarge & c5a.xlarge instance types (x86_64). I have seen some bpf_jit memory growth on c6g.xlarge instances (arm64) but it seems a bit slower and I haven't seen containers fail to create on these nodes yet as a result. I can't reproduce this issue on a t3a.large instance as bpf_jit memory levels remain pretty consistent.
The easiest way to reproduce this is to spin up a fresh EKS 1.24 cluster and add a single node of the required instance type (this makes it easier to observe) running EKS AMI v20230217 (or v20230304). Then run the following commands:
kubectl delete clusterrolebinding eks:podsecuritypolicy:authenticated
kubectl delete clusterrole eks:podsecuritypolicy:privileged
kubectl podsecuritypolicy eks.privileged
kubectl apply -f https://gist.githubusercontent.com/essh/f7dd219a48df25e7294847484da112b7/raw/503ff9a8f32f19430040cd65c213479979bfcc3c/bpf-jit-leak.yaml

This removes the eks.privileged PSP, installs PSPs that use seccomp and starts up a simple app with some exec probes that trigger the issue. The container used for this app is built from the source available at https://github.com/essh/grpc-greeter-node.
Once this is running you can observe memory growth by executing sudo cat /proc/vmallocinfo | grep bpf_jit | awk '{s+=$2} END {print s}' on the node. You can tweak the replica count up and down to speed up/slow down this process. If you leave it long enough the value will exceed net.core.bpf_jit_limit and you will end up with failure to create containers/exec probs. We were seeing this after about 2-3 days with our node types/workloads in our environment.
This same test against EKS AMI v20230203 nodes or lower (kernel 5.4) does not exhibit this issue.

@essh really appreciate the details; I'm following up internally with our kernel folks and will update here as I try to reproduce.

@essh really appreciate the details; I'm following up internally with our kernel folks and will update here as I try to reproduce.

@essh @cartermckinnon I happened to take a look at this recently, and tried to reproduce this on latest bpf tree kernel. I dumped the values around bpf_jit_charge_modmem and bpf_jit_uncharge_modmem, in particular the size passed in and the value of bpf_jit_current after the operation. They all look sane to me. For example, when running tcpdump with a specific filter (e.g. tcpdump -i lo tcp) but also a test application loading a seccomp BPF policy, and I can see the bpf_jit_current counter going up and then discharging again with the same value. Also I tested on native eBPF programs, same here. This all looks good to me.
@cartermckinnon if you follow-up with kernel folks, I'd suggest to check the same.. meaning, is bpf_jit_current steadily increasing (and never decreasing) or does it look sane when loading/unloading programs and just the default limit is too low.
Either way, the default limit for any BPF user for the JIT is currently set to 1/4 of the module memory space, and I'll send an upstream patch (and also recommend for stable) to bump this default limit to 1/2.
From @essh's description though, it looks like the counter is never decreasing which looks like a kernel bug if indeed true, perhaps some backport going wrong, etc. Would be good to double check.

Looks like potentially missing kernel commit in seccomp causing this issue: a1140cb215fa ("seccomp: Move copy_seccomp() to no failure path.") (via<EMAIL_ADDRESS>

Is memleak (mentioned in<EMAIL_ADDRESS>fixed in 5.4? If so, would it make sense for kernel in amazon-eks-ami published AMI to be downgraded from 5.10 to 5.4 until memleak fix is "backported" to 5.10 and newer?

5.4 kernel would not be affected as it does not seem to have the offending commit 3a15fb6ed92c ("seccomp: release filter after task is fully dead") which a1140cb215fa ("seccomp: Move copy_seccomp() to no failure path.") fixes.

Thanks @borkmann for heads up!
It's non trivial to downgrade the kernel downstream when building AMI based on this upstream EKS node AMI which is on kernel 5.10; It would be great that  this upstream AMI gets downgraded to kernel 5.4 (at least until memory leak is backported to affected 5.10+ kernels), and anyone that really needs 5.10 or newer and can live with known memory leak, can more easily upgrade the kernel on their own in custom AMI based on the upstream one. WDYT?

I'll defer to AWS folks with regards to your question, Cc @cartermckinnon. Hopefully this can be fixed quickly by cherry-picking the two commits below for EKS kernel.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a1140cb215fa13dcec06d12ba0c3ee105633b7c4
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=10ec8ca8ec1a2f04c4ed90897225231c58c124a7

@borkmann ACK on behalf of @cartermckinnon. please give us some time to do things...

Unfortunately the series of patches we've cherrypicked internally does not seem to resolve the issue. We're still looking into it.
I was not able to reproduce this with 5.15, so we're diff-ing the changelog as well.

It's non trivial to downgrade the kernel downstream when building AMI based on this upstream EKS node AMI which is on kernel 5.10

@stevo-f3 This should do it:
yum versionlock delete kernel
amazon-linux-extras disable kernel-5.10
amazon-linux-extras enable kernel-5.4
yum install -y kernel

At present, we have more users needing 5.10 who are not experiencing this leak than those who are; downgrading the official build to 5.4 would be a last resort if we can't put a fix together.

We can't use 5.15 - recently downgraded to 5.10, with 5.15 were experiencing kernel panics on instance startup, on production only.
Thanks for downgrade to 5.4 instructions, is trivial after all, will use it at least until fix available.

After backporting a1140cb215fa ("seccomp: Move copy_seccomp() to no failure path.") to our 5.10 kernel, I didn't see any memleak with @essh 's repro.  I will release a new kernel with the commit and post the backport patch to the upstream 5.10 tree as well.

Thank you @q2ven!

I'm running Karpenter and running into this issue. Is there any fix I can apply? Very worrying.

@rarecrumb looking at the kernel version of the newest release:
https://github.com/awslabs/amazon-eks-ami/releases/tag/v20230411#:~:text=amazon-eks/1.22.17//-,AMI details,-%3A
it says:
Kubernetes 1.24 and above: 5.10.176-157.645.amzn2
Which is older than the AMI i pointed to above:
kernel-5.10.177-158.645.amzn2
So please wait for next drop or build an AMI with the kernel version above.
cc @mmerkes @cartermckinnon

@rarecrumb looking at the kernel version of the newest release: https://github.com/awslabs/amazon-eks-ami/releases/tag/v20230411#:~:text=amazon-eks/1.22.17//-,AMI details,-%3A
it says: Kubernetes 1.24 and above: 5.10.176-157.645.amzn2
Which is older than the AMI i pointed to above: kernel-5.10.177-158.645.amzn2
So please wait for next drop or build an AMI with the kernel version above.
cc @mmerkes @cartermckinnon

How long until a new AMI is published with this fix in place?

@essh Can you please this kernel? kernel-5.10.177-158.645.amzn2 and let us know?

I've tried updating to kernel-5.10.177-158.645.amzn2 as suggested but my reproduction is still showing continuing growth when testing with the sudo cat /proc/vmallocinfo | grep bpf_jit | awk '{s+=$2} END {print s}' command. If it's felt this kernel should fix the issue is there anything else I could do to confirm this outside of waiting some number of days for things to start failing?

I can also confirm that issues still persist with 5.10.176-157.645.amzn2.

After Upgrade EKS to 1.25, we also met this issue.
We're using EKS managed group, will the Kernel fix apply to the EC2 node automatically?

Having same issue with EKS 1.26 managed group.

Having the same issue with EKS 1.25. AMI version: 5.10.176-157.645.amzn2.x86_64

The same problem for this setup:
Kernel version: 5.10.176-157.645.amzn2.x86_64
Kubelet version: v1.24.11-eks-a59e1f0

On:
Kernel version: 5.4.226-129.415.amzn2.x86_64
Kubelet version: v1.24.7-eks-fb459a0

works great.

is still showing continuing growth

@essh growth at the same pace as before or is it slower growth rate originally?

@SimonKO9 what's your scenario? (seccomp? cilium?)

@dims it's seccomp, containers running on a code crash eventually and no more can be started (unless seccomp=unconfined is passed explicitly). We downgraded to 5.4 and we're running without issues now.

I've switched to Bottlerocket

Have the same issue after upgrading to the latest v20230411.
The nodes get the error within less than 1 day!
Reverted to previous v20230406 seems solved the problem

@essh growth at the same pace as before or is it slower growth rate originally?

The pace felt roughly the same but I did not perform a side by side comparison at this stage.

We have the same issue, hoping for a quick fix, otherwise have to go to BottleRocket I guess.

We're following up on this with our kernel folks; we believe we've identified the necessary patches. I'll update here once we've verified and have a kernel build in the pipeline.

Just wanted to make sure you are aware that we see the issue with ECS as well, not just EKS.  We have replicated it with kernel 5.10.177-158.645.amzn2

We created a new EKS cluster on version 1.24, After that below error started to show while container are starting up.
Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to init seccomp: error loading seccomp filter into kernel: error loading seccomp filter: errno 524: unknown

We created a new EKS cluster on version 1.24, After that below error started to show while containers are starting up.
Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to init seccomp: error loading seccomp filter into kernel: error loading seccomp filter: errno 524: unknown
Any plans of reverting this to the last stable version till the time AWS finds a fix?

This ☝
Why is a broken AMI still the default for Amazon's managed node groups?
Can't that be backed out or the release pulled?

Can team rollback the commits and make a new release?

FWIW with eksctl it is possible to pin previous version with
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
  name: k8s
managedNodeGroups:
  - name: nodegroup
    releaseVersion: 1.24.11-20230406  # or any other from https://github.com/awslabs/amazon-eks-ami/releases
    ...

Of course this is very unfortunate bug that renders our nodes unusable within day or two even with increased bpf_jit_limit and we're hoping for a quick fix.

Official guidance:
Kubernetes pods using SECCOMP filtering on EKS optimized AMIs based on Linux Kernel version 5.10.x may get stuck in ContainerCreating state or their liveness/readiness probes fail with the following error:
unable to init seccomp: error loading seccomp filter into kernel: error loading seccomp filter: errno 524

When a process with SECCOMP filters creates a child process, the same filters are inherited and applied to the new process. The Amazon Linux kernel versions 5.10.x are affected by a memory leak that occurs when parent process is terminated while creating a child process. When the total amount of memory allocated for SECCOMP filter is over the limit, a process cannot create a new SECCOMP filter.  As a result, the parent process fails to create a new child process and the above error message will be logged.
This issue is more likely to be encountered with kernel versions kernel-5.10.176-157.645.amzn2 and kernel-5.10.177-158.645.amzn2 where the rate of the memory leak is higher.
Amazon Linux will be releasing the fixed kernel by May 1st, 2023. We will be releasing a new set of EKS AMIs with the updated kernel latest by May 3rd, 2023.

Same issue is impacting us, subbed for updates.

Subbing for updates as well, this issue has been impacting us for days now.

Same issue happening on my clusters. Subbing for latest updates.

Hi, the same for me, with EKS 1.26 AMI version: 5.10.176-157.645.amzn2.x86_64

Hey guys, appreciate you're all subbing but think of the people that are already subbed getting all these pointless messages.
If you're not gonna add any information that's relevant to the resolution of the issue please refrain from sending another message and just click the subscribe button.

The kernel fix seems to have been released now, as 5.10.178-162.673.amzn2.x86_64.

Yes, it's available. Folks that manage custom AMIs can start using the kernel and we're preparing AMIs for release on Wednesday that will include the latest kernel.

The v20230501 release has started now, and it includes 5.10.178-162.673.amzn2.x86_64 for all AMIs that use 5.10 kernels. We have tested the kernel and expect it to resolve this issue for customers. New AMIs should be available in all regions late tonight (PDT).

v20230501 is available in all regions now! Update to the latest EKS Optimized AMIs and this issue should be resolved.

Is the kernel fix actually fixing the bug for good or is it just bumping the default bpf jit memory limit?

@michelesr<EMAIL_ADDRESS>

thanks @ljosyula @mmerkes @cartermckinnon @q2ven
https://github.com/awslabs/amazon-eks-ami/releases/tag/v20230501

We are still seeing this issue across our prod cluster after upgrading to 1.24.
Increasing the bpf_jit_limit does indeed fix the issue for pods stuck in Pending due to this seccomp issue. But it is, at best, only a temporary fix, and after a few days the new limit again gets saturated due to the underlying memory leak and we are faced with this problem again.
Looks like we are going to have to downgrade to kernel 5.4 as the only option for now.

That said, can we re-open this issue?
I see from the commits referenced to this issue that AWS team is still trying to wrangle/fix this bug, and so obviously this is still actively being worked on. But this issue being in Closed state falsely gives the impression that it has been fixed.
(Also, I am surprised that not more people are reporting this? Do we just have an unnatural amount of liveness/health check probes or something?)

@skupjoe We haven't had any reports of this since https://github.com/awslabs/amazon-eks-ami/issues/1219#issuecomment-1534536682, can you confirm the kernel version you're on?

I downgraded from 5.10 to 5.4.283-195.378.amzn2.x86_64 and unfortunately it is still happening after about 3.5 days of uptime.
Increasing the bpf_jit_limit helps things for another ~3 days, but then the issue comes back.
It seems to happen on instances of any size/type- I am looking at it happening on a c6a.large, m5a.8xlarge, and a m5a.2xlarge nodes.
I am desperate to get this fixed and it has been happening to me since eks 1.24 upgrade. And now I am on 1.27 and will be upgrading to 1.28 tonight.
We are not using PSP and I don't see any seccomp config set anywhere at the pod level or on my k8s node config:
[root@ip-10-0-82-217 /]# sudo cat /etc/containerd/config.toml | grep -i seccomp

But the kernel supports it:
[root@ip-10-0-104-41 /]# grep SECCOMP /boot/config-$(uname -r)
CONFIG_HAVE_ARCH_SECCOMP=y
CONFIG_HAVE_ARCH_SECCOMP_FILTER=y
CONFIG_SECCOMP=y
CONFIG_SECCOMP_FILTER=y

Can we re-open this? Or should I raise a new issue?

I am considering moving away from amazon-eks-ami as I am desperate to get this issue fixed. Can anybody suggest a good replacement? Maybe Bottlerocket?

@skupjoe If you're seeing this issue on the 5.4 kernel branch, it is definitely not the same issue described above. Please open a new issue or an AWS support case and we can take a look.

I see from the commits referenced to this issue that AWS team is still trying to wrangle/fix this bug, and so obviously this is still actively being worked on. But this issue being in Closed state falsely gives the impression that it has been fixed.

The commit references are a kernel change that was made by a community member to increase the default JIT space for BPF programs. It is not a fix for the issue described here, which was a memory leak. The memory leak was fixed by @q2ven (IIRC). We have no reason to think there's been a regression.


Appcusive-API: errors on Tenant (Update,Add and Navigation properties CreatedBy, ModifiedBy)

[ ] Tenant does not have Navigation properties CreatedBy, ModifiedBy
[ ] No properties are saved on PATCH (no errors)

PATCH http://<IP_ADDRESS>/Appclusive/api/Core/Tenants(guid'11111111-1111-1111-1111-111111111111') HTTP/1.1
DataServiceVersion: 3.0;NetFx
MaxDataServiceVersion: 3.0;NetFx
Content-Type: application/json;odata=minimalmetadata
Accept: application/json;odata=minimalmetadata
Accept-Charset: UTF-8
User-Agent: Microsoft ADO.NET Data Services
Host: <IP_ADDRESS>
Content-Length: 437
Expect: 100-continue

{"odata.type":"biz.dfch.CS.Appclusive.Core.OdataServices.Core.Tenant","Created":"2015-12-14T16:12:47.09Z","CreatedById":"1","Description":"SYSTEM_TENANT a","ExternalId":"11111111-1111-1111-1111-111111111111","ExternalType":"Internal","Id":"11111111-1111-1111-1111-111111111112","Modified":"2015-12-14T16:12:47.09Z","ModifiedById":"1","Name":"SYSTEM_TENANT a","ParentId":"11111111-1111-1111-1111-111111111111","RowVersion":"AAAAAAABSck="}

[x] Exception on POST (add) HTTP 500

POST http://<IP_ADDRESS>/Appclusive/api/Core/Tenants HTTP/1.1
DataServiceVersion: 3.0;NetFx
MaxDataServiceVersion: 3.0;NetFx
Content-Type: application/json;odata=minimalmetadata
Accept: application/json;odata=minimalmetadata
Accept-Charset: UTF-8
User-Agent: Microsoft ADO.NET Data Services
Host: <IP_ADDRESS>
Content-Length: 425
Expect: 100-continue

{"odata.type":"biz.dfch.CS.Appclusive.Core.OdataServices.Core.Tenant","Created":"2015-12-17T14:28:50.4556647+01:00","CreatedById":"1","Description":"Desc","ExternalId":"13f68a68-d017-4482-9bcc-bcca229da1c2","ExternalType":"Internal","Id":"13f68a68-d017-4482-9bcc-bcca229da1c2","Modified":"2015-12-17T14:28:50.4556647+01:00","ModifiedById":"1","Name":"TEST","ParentId":"22222222-2222-2222-2222-222222222222","RowVersion":null}

[ ] Add .Expand("CreatedBy").Expand("ModifiedBy") in TenantController

@ChrEggenberger please test again. This should work now as well with JSON. At least it works when accessing the API (newest version deployed today) directly via browser

@ChrEggenberger please test again. I fixed the bug when updating/saving Tenants and redeployed yesterday evening

@rufer7  Creating new tenants works (POST) But Patch does still have the same problem. no exception but no data saved

@ChrEggenberger thanks for the information. I actually saw in the code that some calls for validation and copy on patch were missing. I will add them and with the next release and deployment the functionality will be available.

@rufer7  Navigation properties CreatedBy, ModifiedBy on Tenant are still missing (used for displaying in general tab).
Maybe it just needs a new release of the biz.dfch.CS.Appclusive.Api nuget-package

@ChrEggenberger because the Tenant entity is the only entity not deriving from BaseEntity the properties CreatedBy and ModifiedBy are not available on Tenant and won't be available. But you could load the user by Id using CreatedById and ModifiedById

@ChrEggenberger where do we stand here?

Working now

@ChrEggenberger so we can close this issue?


feat: Serde Serialize and Deserialize traits for the RbTree in the ic-certified-map crate.

This change adds the serde Serialize and Deserialize traits to the RbTree in the ic-certified-map crate.
Useful for serializing a canister's certified data during upgrades.
This PR changes the 'static generic lifetime bounds on the RbTree impl blocks and replaces it with a custom lifetime 't.
How Has This Been Tested?
#[test]
fn test_serde_serialize_and_deserialize() {
    type Tree<'a> = RbTree<&'a str, Hash>;
    let t1: Tree<'_> = Tree::from_iter([("hi", [1; 32]), ("hello", [2; 32]), ("world", [3; 32])]);

    let mut b: Vec<u8> = Vec::new();

    serde_cbor::to_writer(&mut b, &t1).unwrap();

    let t2: Tree<'_> = serde_cbor::from_slice(&b[..]).unwrap();

    assert_eq!(t1, t2);
}

Checklist:

[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[x] I have made corresponding changes to the documentation.

Hey, I replaced the 'static generic lifetime bounds on the RbTree impl blocks for a custom lifetime 't.

and added a test

Looks like the new canister import functionality is messing with the PR check: https://github.com/dfinity/cdk-rs/actions/runs/6156757139/job/16706101327?pr=399

Looks like the new canister import functionality is messing with the PR check: https://github.com/dfinity/cdk-rs/actions/runs/6156757139/job/16706101327?pr=399

Hey @adamspofford-dfinity, LGTM.

Thanks Adam @adamspofford-dfinity for the review and merge.
My apologies for putting off addressing your feedback for a while there. Won't happen again.


Sponge Plugins list String too big

running /sponge plugins on big packs can kick you from the server
[16:01:13] [Netty Server IO #1/ERROR]: io.netty.handler.codec.EncoderException: String too big (was 36841 bytes encoded, max 32767)
old issue https://github.com/SpongePowered/SpongeForge/issues/918

Addressed by PR: https://github.com/SpongePowered/SpongeCommon/pull/1250


6×6 symbols for perturbed circle

Do you need me to see if it can be reduced to 3x3?

Yes

Codecov Report

Merging #51 (dcd9d4e) into master (883e3d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   36.10%   36.10%
=======================================
  Files          11       11
  Lines         950      950
=======================================
  Hits          343      343
  Misses        607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883e3d6...dcd9d4e. Read the comment docs.


remove the default font size of icons

Fixes #18018 . See that issue for some background about why this change was made.
Note that I choose to NOT make a new major of core-plugin-api, but sneakily downgrade it as being basically a feature addition to support MUI5/6 icons properly in your apps. The breakage to consumers is that they aren't able to render an IconComponent with fontSize="default", but arguably that's iffy and hasn't worked at a technical level for the last two major versions of MUI anyway.
I'm very happy to be challenged on this fix, but it actually seems like newer versions of MUI make TypeScript really confused when it encounters the props as a union type, and then matching that with the complex OverrideableComponent interface's double function signature. This is nicely explained by @secustor in the above issue (thanks for helping debug this!)

@Rugvip Maybe it wasn't broken on MUI4, but would be on >4.


feat: pull add on images through replicated proxy

replace add on image references in order to pull images using replicated proxy for oci artifacts.

lgtm pending andrew's comment and merge of the other pr


Vulkan sandbox

This is a big change... still some work in progress but I made it somehow.
C++ is complicated when it comes to setting up a project and building a tree/hierarchy tree.
As always, open for discussion about any change and can clarify everything I did.
We can discuss either here or sometime on zoom/google meet :)

There are new changes that will help us with project setup - Premake.
Premake will be downloaded automatically once you execute the setup bat script and create a project for you.
The setup bat script will also check for Vulkan and download the installer (will prompt the user first), and launch it.
Currently its set to download and install the latest version of Vulkan (Dec 3 if I'm not mistaken).
The great thing is you can install it anywhere and Premake will automatically load it into the VStudio project.
The bad news is you will need to uninstall the previous version if you have it.
I encourage you to clone this project, uninstall vulkan and run the setup bat script.
Note: You will need Python 3.3+ which I assume you probably already have it installed :)
Note2: Premake currently supports VS2019 project generation, once its created you will need to retarget it for VS2022.
Don't worry, VS will just notify you about that once the project is opened.
The time has come where we do not need to worry about having the same devel env and can just clone, code, commit.


Added support to run kibana

@frodenas yes technically a user can't immediately see kibana via docker services; but we're working on that separately

Thanks!

can you build and push this as new 1.4? or do we want new tag?

It's built automatically on every push. Take a look at https://registry.hub.docker.com/u/frodenas/logstash/builds_history/38547/.

Sorry, it'll be built on master. I'll merge the 1.4 branch right now.

oh awesome! thanks!

On Mar 9, 2015, at 2:44 PM, Ferran Rodenas<EMAIL_ADDRESS>wrote:
Sorry, it'll be built on master. I'll merge the 1.4 branch right now.
—
Reply to this email directly or view it on GitHub
.


middleware/fastcgi: Stripping PATH_INFO from SCRIPT_NAME

While trying to get ownCloud to work I discovered that ownCloud produced a redirect loop once someone logged in. Digging through the source code of ownCloud I found out that this issue was related to the way ownCloud forms the urls parts that are passed to their router.
In their getRawPathInfo function they make use of SCRIPT_NAME environmental variable. When I compared this with Apache, I noticed that Caddy's SCRIPT_NAME included the PATH_INFO variable.
https://github.com/owncloud/core/blob/7ff12d74d9f408836f1a40475e92723c60cf56d5/lib/private/appframework/http/request.php#L568
/**
 * Get raw PathInfo from request (not urldecoded)
 * @throws \Exception
 * @return string Path info
 */
public function getRawPathInfo() {
    // ...
}

More info about the SCRIPT_NAME variable can be found in the CGI version 1.1 standard, RFC 3875

4.1.13.  SCRIPT_NAME
The SCRIPT_NAME string forms some leading part of the path component
of the Script-URI derived in some implementation-defined manner.  No
PATH_INFO segment (see section 4.1.5) is included in the SCRIPT_NAME
value.

This pull-request is the most naive patch I could come up with, and might not be totally like you want it. So tell me if I need to change something.

cf. #172 (related to fix_pathinfo)

Hi, how about we do that on this line https://github.com/DenBeke/caddy/blob/master/middleware/fastcgi/fastcgi.go#L165. ?
That basically means SCRIPT_NAME will hold same value as DOCUMENT_URI

Will look into it once I have ownCloud running. That way I can it a bit more...

Alright, I'm ready to merge this in, although I want to replace the LastIndex stuff with TrimPrefix, I think. Also the PR needs to be rebased with the latest master. Also, @DenBeke, make any changes you'd like (if any) related to @abiosoft's suggestion - if it works, of course ;)

Will do, @mholt.

It should be alright now, @mholt...


Can't get rotation point to be around (0,0) for objects with multiple fixtures

When I add multiple fixtures to a single body using Box2D, the body rotates around the centre point of the first fixture (polygon), instead of the centre point of the body (0,0). Imagine like this: enter image description here
Example
The centre point of the shape is (0, 0). How can I make it so that it rotates around the true centre point instead of the centre of the first fixture?

Rotation should normally be around the centre of mass. What densities are you setting for the fixtures? Do you have a link to the code? (Or a minimal repro.)

I'm using AddTorque to rotate the object, I think that also matters in how rotation is handled? The current density set to the fixtures is 1 as default(so is friction and restitution).
 public CreateBody(bodyType: BodyTypes, collider: PhysicsColliderComponent, options: PhysicsOptions): Box2DBody {
    //create body def
    let shape = collider.mesh;
    let position = collider.gameObject.transform.position;

    let bodyDef = new Box2DBodyDef(bodyType, position, options);
    let shapeCount = shape.PointSets.length;
    let box2DShapes = Array<b2Shape>(shapeCount);
    let b2Body = this._b2world.CreateBody(bodyDef.box2DBodyDef);

    for (let i = 0; i < shapeCount; i++) {

      let b2Shape = new b2PolygonShape();
      let polygon: Vector2[];
      polygon = shape.GetScaledPoints(collider.gameObject.transform.scale)[i]; // scales points

      b2Shape.Set(polygon);
      box2DShapes[i] = b2Shape;
    }

    //create box2D fixtures
    for (let i = 0; i < box2DShapes.length; i++) {
      let fixture = new b2FixtureDef();
      fixture.shape = box2DShapes[i];
      fixture.density = options.densityValues[i];
      fixture.friction = options.frictionValues[i];
      fixture.restitution = options.resitutionValues[i];
      b2Body.CreateFixture(fixture);
    }

    //make Box2DBody
    let body = new Box2DBody(b2Body, new ID().ID, bodyType);

    //add Box2DBody to bodies
    this._bodies.set(body.ID, body);
    body.gameObject = collider.gameObject;

    if (bodyType == BodyTypes.STATIC) this._staticBodies.push(body.ID);
    if (bodyType == BodyTypes.KINEMATIC) this._kinematicBodies.push(body.ID);
    if (bodyType == BodyTypes.DYNAMIC) this._dynamicBodies.push(body.ID);

    return this._bodies.get(body.ID) as Box2DBody;
  }

That doesn't look like regular Box2D code. What programming language and game engine is this? If this is for a specific game engine, it might be easier to get help in their forums.
Either way, I don't have enough context to understand what's wrong. Can you post a complete repro that is easier for others to inspect and run?

Unity Box2d. Use unity phisics.

Yeah, the body should rotate about the center of mass. Unity might be doing something internally that affects this. If you can reproduce the problem in the Box2D testbed, feel free to re-open.


MAT-5828_timeField

MADiE PR
Jira Ticket: MAT-5828
(Optional) Related Tickets:
Summary
All Submissions

[x] This PR has the JIRA linked.
[x] Required tests are included.
[x] No extemporaneous files are included (i.e Complied files or testing results).
[x] This PR is merging into the correct branch.
[ ] All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
[ ] Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

[x] This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
[ ] All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers
By Approving this PR you are attesting to the following:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
The tests appropriately test the new code, including edge cases.
If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

replaced by this new PR: https://github.com/MeasureAuthoringTool/madie-design-system/pull/182


➕ [RESOURCE] - Add Free book for app development

Idea Contribution

[X] I have read all the resource request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Where do you want to add the resource? Specify the category and section.
I want to add free resource book for app development
Provide the URLs of the resources you are adding
chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://baou.edu.in/assets/pdf/PGDCA203_slm.pdf
Any alternative approaches/features
No response
Additional Context
No response
Code of Conduct

[X] I follow the CONTRIBUTING GUIDELINE of this project.

@jfmartinz sir please assign this issue to me


define the part of code to submit

🚀 Feature Proposal
We need a magic comment to define where is the actual user code to submit.
Motivation
I am playing with rust. The code structure is as follow.
pub struct Solution;

impl Solution {
    pub fn two_sum(nums: Vec<i32>, target: i32) -> Vec<i32> {
    // ...
    }
}

look at the first line(Line 9).
I will get an error in vs code without that line.
And I will get an error if I submit code with that line.
✘ Compile Error
  ✘ 0/0 cases passed (N/A)
  ✘ Error: Line 54, Char 1: the name `Solution` is defined multiple times (solution.rs)
  ✘ Error: Line 54, Char 1: the name `Solution` is defined multiple times (solution.rs)
   |
9 | pub struct Solution {}
   | ------------------- previous definition of the type `Solution` here
...
54 | struct Solution;
   | ^^^^^^^^^^^^^^^^ `Solution` redefined here
   |
   = note: `Solution` must be defined only once in the type namespace of this module

The Line 54 is at LeetCode test side.
It is better to define which is the actual user code to submit and which is not.

For example:
pub struct Solution;

// @lc user code start

impl Solution {
    pub fn two_sum(nums: Vec<i32>, target: i32) -> Vec<i32> {
        unimplemented!()
    }
}

// @lc user code end

#[cfg(test)]
mod tests {
    use super::Solution;

    #[test]
    fn it_works() {
        assert_eq!(vec![1, 2], Solution::two_sum(vec![3, 2, 4], 6));
    }
}

# @lc user code start

class Solution:
    def twoSum(self, nums: List[int], target: int) -> List[int]:
        pass

# @lc user code end

if __name__ == '__main__':
    s = Solution()
    print s.twoSum([3, 2, 4], 6)

So each time we will extract out the content between the special tag comments, save it to a temp file and submit through CLI.
Another usage for this tag to provide a better place to put the Code Lens (issue #407 ). Currently the Code Lens is always put at the end of the file.
@magic-akari Would you like to contribute for this? I guess we need also update the template here: https://github.com/leetcode-tools/leetcode-cli/tree/master/templates

I tried to make a prototype here https://github.com/leetcode-tools/leetcode-cli/pull/23
Would you like to review it?

Thanks, I just left some comments there.

I have a python script that does it better. It does the following things:

generate a local runnable cpp file linked to my own header only cpp-stl pretty pretty printer.
run it and test against the test cases.
also generate a submittable file without the main and all the includes.

The most straight forward way to do this is to define a runtests functions inside the solution class and only call the runtests function inside the main.  Scripting becomes much easier.
Let me know if you would like to make this a multi-language script. Right now what is missing is the ability to catch failed cases and convert it to appropriate types in the language. However, this is easily achievable if you are willing to use some Haskell or Ocaml to do pattern match!

Thank you @jasonsun0310 ,
So far the problem is addressed in https://github.com/leetcode-tools/leetcode-cli/pull/23.
Let's see if the users need more powerful support later...


Design

Are we keeping the same design or there's another one?

There's another design coming today & framework change. Nuxt.js it is.

A little teaser...

But..but.. that's only a new colour 😊
I need more than that 👀

@nirvanpagooah cool choice!

Can we make the text and logo stick out a little bit more? If we gonna have posters i think it won't be much perceivable from afar.

Everything looks great :tada:
/close


Fix generated YAML whitespace

This PR removes unnecessary whitespace from the generated YAML.
Most of these fixes are basically including a - in the template variables, i.e. updating {{ ...  }} to {{- ... }}.
To test, I recommend running the Helm install command with the --dry-run and  --debug flags, for example:
helm package op-scim-bridge && \
helm install op-scim-bridge op-scim-2.3.0.tgz --create-namespace --namespace op-scim-bridge --dry-run --debug > helm_output.yaml

This command does a dry run of the install command with debug enabled and stores the output in a file called ./helm_output.yaml.
Inspecting the YAML for any unexpected new lines in the generated output.
Resolves #34.

I'll take a look at the CI failure.


project.app/main.jsbundle does not exist. This must be a bug with

Is this a bug report?
(write your answer here)

Have you read the Contributing Guidelines?
(Write your answer here.)
Environment

Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

same for me


feat: add signed fetch

Codecov Report
Patch coverage has no change and project coverage change: -0.31% :warning:

Comparison is base (9cd4af8) 16.97% compared to head (08a6faf) 16.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   16.97%   16.66%   -0.31%
==========================================
  Files          61       62       +1
  Lines        7837     7982     +145
==========================================
  Hits         1330     1330
- Misses       6507     6652     +145

Files Changed
Coverage Δ

rust/decentraland-godot-lib/src/comms/livekit.rs
0.00% <ø> (ø)

...ecentraland-godot-lib/src/comms/player_identity.rs
0.00% <0.00%> (ø)

...t/decentraland-godot-lib/src/comms/signed_login.rs
0.00% <ø> (ø)

rust/decentraland-godot-lib/src/comms/ws_room.rs
0.00% <ø> (ø)

...ust/decentraland-godot-lib/src/dcl/js/fetch/mod.rs
0.00% <0.00%> (ø)

...traland-godot-lib/src/dcl/js/fetch/signed_fetch.rs
0.00% <0.00%> (ø)

rust/decentraland-godot-lib/src/dcl/js/mod.rs
0.00% <0.00%> (ø)

rust/decentraland-godot-lib/src/dcl/mod.rs
29.41% <0.00%> (-5.08%)
:arrow_down:

rust/decentraland-godot-lib/src/lib.rs
47.36% <ø> (ø)

...raland-godot-lib/src/scene_runner/scene_manager.rs
0.35% <0.00%> (-0.05%)
:arrow_down:

... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unlock images correctly on Err

If the CommandBuffer encountered an error in the lock_submit function,
it would unlock all the previously locked resources and return the
error. It would unlock all the images with a None value which would
panic in an assertion in the unlock method of the images.
This change should help with the panics mentioned in #1441 and #1447.
With this fix, it should return the error that is occurring instead of
panicking.
* [ ] Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
* [ ] Updated documentation to reflect any user-facing changes - in this repository
* [ ] Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

[x] Ran cargo fmt on the changes

@Eliah-Lakhin Well, I'm open for a review here actually. I don't know if this is correct, but the images are unlocked the same way in the unlock method of the buffer.
The panics of the asserts in the mentioned issues disappear with this fix though.

@Gosuo Can you add an entry to the changelog file, please?

@Eliah-Lakhin Oh, I thought the change log is only for user-facing changes, but I can add an entry as soon I have time.

@Gosuo Well, this is an actual(and important!) bug fix affecting the end-user experience, so I would log it anyway :)

@Eliah-Lakhin Added the information to the changelog.

@Gosuo PR merged. Thank you very much for this fix! Now it will unblock a number of higher level features progress.

I guess this is not correct. When a command buffer execution fails (which should never happen with vulkano), it is unspecified what the contents and layout of the images it touched are.
However in the unlock methods parameter you specify what the layout is after command buffer execution and I guess the None value is exactly for this purpose: Telling the image that the layout is unknown because of an execution error.
The solution here is obvious: Fix the actual error that causes the command buffer execution to fail.

@faulesocke But the actual underlying Vulkan buffer wasn't executed at that point. It just locked the needed resources from the Rust point of view. That way the image wasn't touched at that point, or am I wrong?
Sounds logical though that the current unlocks with the final layout are not correct. Maybe unlock it with the initial layout?

Well but when nothing was executed the image is certainly not in the desired final layout, is it?

What do you suggest? Revert the change?
Your example in #1447 fails at the insertion introduced in #1444, so I'm not sure how to test this further.

Not sure what to do. This needs further investigation. I might have time for it during the weekend.

@faulesocke, @Gosuo Please keep updating me on the issue progress. These features are completely above of my current understanding of Vulkano internals, so I will leave it to your hands.


No module named scipy

I get an error while running the visualization.py
it says
Traceback (most recent call last):
File "/home/pi/Desktop/audio-reactive-led-strip-master/python/visualization.py", line 5, in
from scipy.ndimage.filters import gaussian_filter1d
ImportError: No module named 'scipy'
Thanks in advance

Hey,
sudo apt-get install python-scipy
or
pip install scipy
Is your solution.
Web-RPi

Hello again,
both solutions will not work
pi@raspberrypi:~ $ sudo apt-get install python-scipy
Reading package lists... Done
Building dependency tree
Reading state information... Done
python-scipy is already the newest version (0.18.1-2).
0 upgraded, 0 newly installed, 0 to remove and 149 not upgraded.
while doing pip install scipy gives me this error
Command "/usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-vXKyIP/scipy/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-E8RSED-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-build-vXKyIP/scipy/

Not sure, I can’t find much info on that. At this point all I can recommend is basic diagnostic steps, uninstalling everything to do with it, reinstalling. Installing all updates for everything.

Did you try "sudo pip install scipy" ?


Fix an issue where the WKWebView thread is blocked indefinitely sometimes

Fix an issue where the WKWebView thread is blocked indefinitely sometimes if the scanner is presented modally and the cordova-plugin-wkwebview-engine plugin is used

@moritzhartmeier the window is deallocated by ARC when the last view controller that has a reference to it is deallocated. (aka it's deallocated as a consequence of this line self.pickerContainer = nil;). If you check I'm not keeping any strong reference to the UIWindow instance ;)

Hm, interesting stuff :D


Release v1.5.0

This PR bumps the version to 1.5.0.
Checklist

[x] I used npm version <major|minor|patch> to update package.json, inspecting the changelog to determine if the release was major, minor or patch.
[x] The CHANGELOG has been updated to show version and release date - https://keepachangelog.com/en/1.0.0/.
[x] @since X.Y.Z annotations have been added to new APIs.
[x] The only commits in this PR are:

the CHANGELOG update.
the version update.
@since annotations.

[x] I will make sure not to squash these commits, but rebase instead.
[x] Once this PR is merged, I will push the tag created by npm version ... (e.g. git push origin vX.Y.Z).

The proptests found another bug: https://github.com/inrupt/solid-client-js/runs/2029956579?check_suite_focus=true
I'll fix that first.


I can't seem to find right version of Microsoft.Extensions.Configuration.Json for .net framework 4.6.1

Describe the bug
I upgraded my application from DNX451 to .net 4.6.1 and I am looking for the version of Microsoft.Extensions.Configuration.json for my framework but I can't seem to find one. Is it deprecated already?
To Reproduce
Steps to reproduce the behavior:

Using version '2.2.0' of package 'Microsoft.Extensions.Configuration.Json'
Just tried to compile my application
using the following project.json

{
  "version": "1.0.0-*",
  "description": "ApiClient Console Application",
  "authors": [ "hasanm" ],
  "tags": [ "" ],
  "projectUrl": "",
  "licenseUrl": "",

  "compilationOptions": {
    "emitEntryPoint": true
  },

  "dependencies": {
    "Microsoft.AspNet.WebApi.Client": "5.2.3",
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.1.2",
    "Microsoft.Extensions.Configuration.Json": "2.2.0"
  },

  "commands": {
    "ApiClient": "ApiClient"
  },

  "frameworks": {
    "net461": {
      "frameworkAssemblies": {
        "System.Runtime.Serialization": "<IP_ADDRESS>",
        "System.Xml": "<IP_ADDRESS>"

      }
    }
  }
}

Get the following compile error
Severity	Code	Description	Project	File	Line	Suppression State
Error	NU1002	The dependency Microsoft.Extensions.Configuration.Json 2.2.0 in project ApiClient does not support framework .NETFramework,Version=v4.6.1.	ApiClient

Expected behavior
I should be able to find a right version of Microsoft.Extensions.Configuration.Json pacakge for .net 4.6.1
Screenshots

You might want to remove all project.json and start over.

and use 2.2 for Microsoft.Extensions.Configuration.EnvironmentVariables
the Microsoft.Extensions.* packages should all be the same version at least same mayor version


Satisfy tests showing the SQL analysis honoring the removal of a ConfidentialityTag due to a PolicyRule.

This issue tracks creating a simple test on the SQL analysis integrated with Raksha showing that a PolicyRule requesting the removal of a ConfidentialityTag is honored. This comes after the test showing ConfidentialityTags have any effect at all (#352) and requires the construction and exposure of PolicyRule IR structures (#348, #349, #351). Note that, because PolicyRules only take effect if certain IntegrityTags are present upon their inputs, this requires the propagation of IntegrityTags as well.

Done.


Option source add CSS folder to my path

Hi,
I used the module with express 4 and when I put the path to the source folder it suffix him with the css folder :
Here is the code :
  app.use(sassMiddleware({
    src: path.join(__dirname,  '../assets/sass'),
    dest: path.join(__dirname,  '../assets'),
    debug: true,
    outputStyle: 'expanded',
    prefix: '/assets',
  }));
```
![image](https://cloud.githubusercontent.com/assets/1548421/9882731/7bf84578-5bd6-11e5-9a43-8acca216ff6a.png)

Is it a normal feature ? Or maybe i'm doing something wrong ?
Thanks

Hi, I think there is nothing wrong with your configuration. However, it seems like your web request is /assets/css/main.css instead of /assets/main.css.
If you intend to consume from /assets/css/main.css on client-side, then either create a URL rewrite rule (or control it with MVC route) to map /assets/css to /assets before the preprocessing, or set dest to path.join(__dirname, '../assets') (or IMO even better use path.resolve like: path.resolve(__dirname, '../assets')).

Hello,
You were right, I changed the prefix parameter to /assets/css and it works well !
Thanks

No problem. Glad to hear that it resolved your issue. :)
FYI: v0.9.5 tag is just released with more options and improvements. Please try it out let us know if you encounter any issue.


Pass SSL related parameters when obtaining OAuth token

What does this PR do?
It passes tls_* config parameters when making requests to obtain OAuth tokens.
It includes a modified copy of the AuthTokenOAuthReader class from the base package. I don't intend to merge this as is, but it should be a proof of concept before updating this directly in the base package.
Motivation
Support case.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Closing as this integration has been revamped


Tautomers

I am still using REINVENT 2.0 (have not updated to 3.0 yet) and have observed that incorrect (less abundant at specific pH) tautomers are generated. I have used QED as scoring function component in RL mode. As these are still valid SMILES molecules, incorrect tautomers (not penalised) are present even in the  last batches of generated molecules.
Examples of molecules with incorrect tautomers:
c1ccccc1-c1[nH]c(=N)nc(OC)c1 &
c1(=N)[nH]c(C)c(C#N)c(OC2CCCC2)n1
Is there some way to tailor scoring function components in REINVENT2.0 to generate correct tautomers? Are there updates to REINVENT 3.0 that would help generate correct tautomers? Thank you.

Thanks for bringing this up, it is indeed a good point. I always thought It is a bit tricky to penalize a specific tautomer generation since the molecules are still valid and this may confuse the learning. I cant remember proving this assumption though So it may turn out to be beneficial to have a component that propagates back score for incorrect tautomers. Another alternative is to append certain tautomer patterns in the Custom Alerts component and thus prevent them from appearing. The model will clearly learn that. One could even use a softer penalty than the one used in Custom Alerts (since that one is binary 0 or 1).
Third alternative to deal with these molecules is to introduce the implemented tautomer canonicalization from RDKit:
http://rdkit.blogspot.com/2020/01/trying-out-new-tautomer.html
I believe I had it in earlier versions but it did impact the speed (slightly) and I think there were some other issues that made me reconsider and stick with just a conventional canonicalization. Again, this was a few RDKit versions ago so probably worth trying it out again.
Sadly we have a few other items as a top priority so I cant promise it would be addressed right away.

Thank you for these suggestions. I shall try to implement these approaches and compare the generated molecules.

Looking forward to hear about the outcome 👍


random_distortion() not support mask

Hi, I now have an image(np.array) and a mask(np.array), and I want to perform random distortion on them. I have tried this:
assert isinstance(imnp, np.ndarray) and isinstance(gt, np.ndarray)

images = [[imnp,gt]]
p = Augmentor.DataPipeline(images)
p.crop_by_size(1,768,768,centre=False)
p.random_distortion(1,3,3,100)

aug_im = p.sample(1)

# visualize the mask on the image
landmarks = np.argwhere(aug_im[0][1]>=1)
plt.imshow(aug_im[0][0])
plt.scatter(landmarks[:,1], landmarks[:,0], s=10, marker='x', c='g')
plt.pause(0.001)

It seems that the distorted mask aug_im[1] is not consistent with the distorted image aug_im [0]. I can post image if it helps.
So does random_distortion() can't deal with image and its mask at the same time?

@duanzhiihao check issue #188
you can augment image and mask in parallel using
p.ground_truth(y_root)

the random distortion fails
random rotation and flipping work fine

Hi @VincentYCYao, @duanzhiihao, this has now been resolved as of version 0.2.6. Just upgrade via pip (pip install Augmentor -U)


Do you have example inputs

Hello!
I am helping a colleague run this script and I was wondering if you have any small sample inputs that you can add to the repository.
Thank you!

Demo data with results have been added.
Best,
Michael

Thank you so much.
On Dec 9, 2018 4:56 PM, "Michael McKain"<EMAIL_ADDRESS>wrote:
Demo data with results have been added.
Best,
Michael
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mrmckain/PUG/issues/2#issuecomment-445575573, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD7hwH7aPfrTtm_Byh8p5hWL2LQDE_chks5u3YcggaJpZM4Y6Eak
.


⚠ Bofrost.de has degraded performance

In 3dc4a5a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1170 ms

Resolved: Bofrost.de performance has improved in 5072b81.


apps: Remove BLE sample applications

Those were moved to apache-nimble repository.

Looks good. Are all the tutorials/docs updated to refer to the apps in mynewt-nimble?

Btw, the reason I asked is because I was looking here: https://mynewt.apache.org/latest/network/docs/mesh/sample.html and it still uses @apache-mynewt-core/apps/blemesh (but I haven't checked if the docs sources are up to date!), so just to ensure tutorials, etc are updated.

good point, we should update docs too


Files 3.2.3 only on an admin account ?

Description
On my Windows 11 PC, files 3.2.3 installs and runs on the administrator account, but is very slow to start up. On a non-admin account, it is not even seen in the list of installed software, so does not launch... It seems to me that this wasn't the case on a previous version, maybe 3.0, but I can't remember. In short, disappointing, even if the look seems nice.
Steps To Reproduce
no special steps
Requirements
No crash, simply is not seen (so does not work) on a non-admin account
Files Version
3.2.3
Windows Version
11
Log File
.

You have to install Files on the accounts you want to use it on it isn't a global install. As for startup it should run in the background after first launch for instant opening.


Dropout for LSTM, GRU, SimpleRNN, and Embedding layers.

I don't think there is sufficient justification to include the ModelTest callback and predict_stochastic method into the master codebase. I would rather have this PR focus on the addition of dropout / regularization to the RNN layers.
By the way, it seems like you have quite a few trailing spaces in your code. I suggest you install a linter such as this one to detect and remove them.

Agreed

Excellent. Thanks a lot, this is now merged.
I'm thinking we should plan to abstract get_constants in the future, since it creates a lot of code redundancy.

Awesome. I was going to update the example file imdb_lstm.py to:

print('Build model...')
model = Sequential()
model.add(Embedding(max_features, 128, input_length=maxlen, dropout=0.5))
model.add(LSTM(128, dropout_W=0.5, dropout_U=0.5))
model.add(Dropout(0.5))
...
model.fit(X_train, y_train, batch_size=batch_size, nb_epoch=15, validation_data=(X_test, y_test), show_accuracy=True)

This is what the results look like before dropout:

Train on 20000 samples, validate on 5000 samples
Epoch 1/15
20000/20000 [==============================] - 42s - loss: 0.4705 - acc: 0.7728 - val_loss: 0.3841 - val_acc: 0.8310
Epoch 2/15
20000/20000 [==============================] - 42s - loss: 0.2676 - acc: 0.8935 - val_loss: 0.3634 - val_acc: 0.8368
Epoch 3/15
20000/20000 [==============================] - 42s - loss: 0.1642 - acc: 0.9410 - val_loss: 0.4106 - val_acc: 0.8336
Epoch 4/15
20000/20000 [==============================] - 42s - loss: 0.0913 - acc: 0.9700 - val_loss: 0.5181 - val_acc: 0.8234
Epoch 5/15
20000/20000 [==============================] - 42s - loss: 0.0734 - acc: 0.9762 - val_loss: 0.5570 - val_acc: 0.8300
Epoch 6/15
20000/20000 [==============================] - 42s - loss: 0.0419 - acc: 0.9865 - val_loss: 0.7032 - val_acc: 0.8236
Epoch 7/15
20000/20000 [==============================] - 42s - loss: 0.0325 - acc: 0.9891 - val_loss: 0.7419 - val_acc: 0.8260
Epoch 8/15
20000/20000 [==============================] - 42s - loss: 0.0210 - acc: 0.9935 - val_loss: 0.8792 - val_acc: 0.8264
Epoch 9/15
20000/20000 [==============================] - 42s - loss: 0.0304 - acc: 0.9897 - val_loss: 0.8041 - val_acc: 0.8174
Epoch 10/15
20000/20000 [==============================] - 42s - loss: 0.0173 - acc: 0.9953 - val_loss: 0.9233 - val_acc: 0.8240
Epoch 11/15
20000/20000 [==============================] - 42s - loss: 0.0087 - acc: 0.9974 - val_loss: 0.9507 - val_acc: 0.8318
Epoch 12/15
20000/20000 [==============================] - 42s - loss: 0.0314 - acc: 0.9906 - val_loss: 0.8402 - val_acc: 0.8174
Epoch 13/15
20000/20000 [==============================] - 42s - loss: 0.0140 - acc: 0.9953 - val_loss: 0.9607 - val_acc: 0.8238
Epoch 14/15
20000/20000 [==============================] - 42s - loss: 0.0070 - acc: 0.9980 - val_loss: 1.0835 - val_acc: 0.8260
Epoch 15/15
20000/20000 [==============================] - 42s - loss: 0.0034 - acc: 0.9988 - val_loss: 1.0937 - val_acc: 0.8174
5000/5000 [==============================] - 2s
Test score: 1.09374942386
Test accuracy: 0.8174

And this is with dropout:

Train on 20000 samples, validate on 5000 samples
Epoch 1/15
20000/20000 [==============================] - 45s - loss: 0.6394 - acc: 0.6253 - val_loss: 0.5157 - val_acc: 0.7760
Epoch 2/15
20000/20000 [==============================] - 45s - loss: 0.5481 - acc: 0.7310 - val_loss: 0.4186 - val_acc: 0.8206
Epoch 3/15
20000/20000 [==============================] - 45s - loss: 0.4990 - acc: 0.7649 - val_loss: 0.4269 - val_acc: 0.8170
Epoch 4/15
20000/20000 [==============================] - 45s - loss: 0.4808 - acc: 0.7808 - val_loss: 0.4056 - val_acc: 0.8182
Epoch 5/15
20000/20000 [==============================] - 45s - loss: 0.4579 - acc: 0.7937 - val_loss: 0.3991 - val_acc: 0.8176
Epoch 6/15
20000/20000 [==============================] - 45s - loss: 0.4320 - acc: 0.8108 - val_loss: 0.3816 - val_acc: 0.8308
Epoch 7/15
20000/20000 [==============================] - 45s - loss: 0.4191 - acc: 0.8171 - val_loss: 0.4286 - val_acc: 0.8154
Epoch 8/15
20000/20000 [==============================] - 45s - loss: 0.3956 - acc: 0.8334 - val_loss: 0.3768 - val_acc: 0.8316
Epoch 9/15
20000/20000 [==============================] - 45s - loss: 0.3823 - acc: 0.8355 - val_loss: 0.3767 - val_acc: 0.8336
Epoch 10/15
20000/20000 [==============================] - 45s - loss: 0.3706 - acc: 0.8433 - val_loss: 0.3679 - val_acc: 0.8348
Epoch 11/15
20000/20000 [==============================] - 45s - loss: 0.3577 - acc: 0.8482 - val_loss: 0.3702 - val_acc: 0.8328
Epoch 12/15
20000/20000 [==============================] - 45s - loss: 0.3435 - acc: 0.8543 - val_loss: 0.3741 - val_acc: 0.8338
Epoch 13/15
20000/20000 [==============================] - 45s - loss: 0.3430 - acc: 0.8552 - val_loss: 0.3705 - val_acc: 0.8302
Epoch 14/15
20000/20000 [==============================] - 45s - loss: 0.3266 - acc: 0.8627 - val_loss: 0.3655 - val_acc: 0.8422
Epoch 15/15
20000/20000 [==============================] - 45s - loss: 0.3221 - acc: 0.8648 - val_loss: 0.3704 - val_acc: 0.8402
5000/5000 [==============================] - 2s
Test score: 0.37036307745
Test accuracy: 0.8402

How do I do this after the pull request was merged?


Notifications category and label - why both?

🚀 Feature Request
Relevant Package
notifications service
Description
Notifications have both a category and label.  As of V2, both are un-enumerated string arrays.  Why have both?
Describe the solution you'd like
remove or combine - or come up with valid use case for both (or enumerations)
Decision per Core WG of 5/26/21 - keep for V2 for now.  Revisit in the future.

the major reason is that they are semantically different


Package request: Celeste64

Project description
Relive the magic of Celeste Mountain alongside Madeline in this small, heartfelt 3D platformer. Created in a week(ish) by the Celeste team to celebrate the game’s sixth anniversary
Metadata

homepage URL: https://maddymakesgamesinc.itch.io/celeste64
source URL: https://github.com/ExOK/Celeste64
license: source code MIT, assets unfree
platforms: unix

Add a :+1: reaction to issues you find important.

I'll try packaging this for you, I've been wanting to contribute to nixpkgs anyways.

#285232


Require only app-extension-safe APIs

tl;dr: Marks Rive library as safe, to prevent potential App Store rejection.
If an app extension (e.g., a widget) depends on Rive, when you build your app you'll be warned that you're Linking against a dylib which is not safe for use in application extensions. Apple may reject the app for this.
A library is safe for application extensions if APPLICATION_EXTENSION_API_ONLY = YES.
Right now, APPLICATION_EXTENSION_API_ONLY is unspecified in Rive, but Rive is only using APIs that are safe for app extensions. Since Rive is safe, I marked it as safe. If an unsafe API is ever used in the future, Xcode will generate errors. I'd guess that given the usual unsafe APIs, this seems unlikely ever to be a problem for Rive.
I didn't see some project file management setup, so I edited the .pbxproj directly.

Thanks for contributing this! We've patched this from an upstream repo and this has landed in v5.1.4


enh(centreon-frontend) : rework the header for it to be more responsive

Description
The main purpose of this PR is to enhance the header styling and add some extra features to it. In addition to that, we make sure to make the header responsive using different designs according to differents breakpoints
Type of change

[ ] Patch fixing an issue (non-breaking change)
[ ] New functionality (non-breaking change)
[ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

develop

 How this pull request can be tested ?
this can be tested with additional modules : centreon and centreon-bam
Community contributors & Centreon team

[x] I have followed the coding style guidelines provided by Centreon
[x] I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
[x] I have commented my code, especially hard-to-understand areas of the PR.
[ ] I have rebased my development branch on the base branch (master, maintenance).

Don't forget to update Storybook's snapshots

some screenshots from storybook :
status counter: 5 stories

toggle icon: 2 stories

submenu header :

Don't hesitate to resolve the conversation when resolved :)

@Med1233 it seems that you have unresolved ESLint issues. You can run npm run eslint:fixto fix them

@Med1233 it seems that you have unresolved ESLint issues. You can run npm run eslint:fixto fix them

I got 2 warnings for using "any" as params type for the onClick function. I know that using "any" turns of type checking which is absolutely bad, but in this case, onClick can have params of any type.

@bdauria
I got 2 warnings for using "any" as params type for the onClick function. I know that using "any" turns off type checking, which is absolutely bad, but in this case, onClick can have parameters of any type.

@Med1233 you need to regenerate some storyshots for the build to pass:

To do so, first build the storybook by running:
npm run build:storybook
Then you can re-generate the snapshots by running:
npm run t -- -u

@Med1233 you need to regenerate some storyshots for the build to pass:
To do so, first build the storybook by running: npm run build:storybook
Then you can re-generate the snapshots by running: npm run t -- -u

the last command is it: npm run test -- -u ?

@Med1233 you need to regenerate some storyshots for the build to pass:
To do so, first build the storybook by running: npm run build:storybook
Then you can re-generate the snapshots by running: npm run t -- -u

the last command is it: npm run test -- -u ? most of the tests didn't pass, and they returned the same error message "Image StoryShots › ...". should I delete all existing storyshots in "image_snapshots" before running the first command ? or it's something else?


Java Implementation of Search Algorithms

Ground rules:

Whoever claims the Issue first, should send a Pull Request within 24 hours else it'll be assigned to another claimant and further Pull Requests regarding that issue will not be entertained.
Pull Requests sent without claiming and referencing the Issue will not be entertained.
Make sure your Pull Requests have just one commit in them. Squash multiple commits into one if you have to.

Kindly claim for the following Search Algorithms:

Linear Search
Binary Search

I will like to take binary search.

Go ahead! @rahul26081995

I will like to take linear search.

Well done guys.


terra-application-navigation not themed for clinical-lowlight-theme

Bug Report
Description

When trying to view terra-application-navigation in clinical-lowlight-theme the theme variables are not being correctly applied.
https://pages.github.cerner.com/orion/orion-application/components/orion-application/demo

Steps to Reproduce

Navigate to https://pages.github.cerner.com/orion/orion-application/components/orion-application/demo
Switch to clinical-lowlight-theme
Nav Bar and portions of the Utility Menu are not themed correctly

Additional Context / Screenshots

Expected Behavior

All components should be correctly themed when using a theme.
@ Mentions

@StephenEsser @mjhenkes

Transferring issue to Terra-Framework.


allow_downgrade in rpm_package

This patch enables us to downgrade rpm by supporting allow_downgrade option for rpm_package resource as yum_package resource does.
rpm_package "foo" do
  source "ImageMagick-c++-<IP_ADDRESS>-7.el6_5.x86_64.rpm"
  allow_downgrade true
end

This patch should hold off until #2692 is merged and get rebased on top of that.

Travis failed, but it looks it is not related with this commit??

@sonots Could you rebase against master per Lamont's request?

@smurawski rebased

Minor nit in one of the specs, but I'm okay with merging either way
:+1:


Dark mode

I would like alar.ink to support dark mode, i.e., light text over a dark background.
Dark mode is more comfortable to read in low-light environments, like at night. Prominent websites and OSes these days support dark mode, so it's a little jarring when I switch from other browser tabs or windows to alar.ink and the screen is suddenly much brighter.
There are two ways we can implement this:

Use prefers-color-scheme for conditional styling. This is the simplest way and only requires changing the CSS.
Add a dark mode toggle button somewhere on the page. This gives the user more freedom to pick the mode they want, but requires using localStorage to keep track of their preference across requests. It's also unclear to me where to add the toggle button. Most websites add it to their site's header, but alar.ink doesn't have a header.

@knadh Let me know if you're willing to have this feature on alar.ink. If you're too busy to implement it, I can do it and send a pull request (though it could take me a few weeks, since my free time is limited). If you'd like me to implement it, please let me know whether you want to go with method 1 (prefers-color-scheme) or method 2 (toggle button).

Thanks @sharmaeklavya2. You can send a PR once the big pending update to this repo is done. Please see https://github.com/alar-dict/alar.ink/pull/11#issuecomment-1987785119


Improving docs or examples

Ian and I are always saying "Oh, it'd be great to have this example in our docs!" but because we can't always add them immediately we don't and we end up losing them. This issue is an effort to document these little good snippets that we wish we had to someday actually add them to our docs.
Please feel free to drop yours in the comments :)
Just add a sentence (or more) explaining what the example is about.

[ ] Use ipycytoscape as an embeded widget https://github.com/QuantStack/ipycytoscape/issues/172#issuecomment-713823288
[ ] helper function to create nodes and edges from dicts https://github.com/QuantStack/ipycytoscape/issues/185#issuecomment-733593298

[ ] Changing the size of the graph using cyto.layout.width and cyto.layout.height https://github.com/QuantStack/ipycytoscape/issues/170#issuecomment-706248455

talking about layouts.... what about a list of the different layouts somewhere?
here: https://js.cytoscape.org/#cy.layout there is not such list neither.

[ ] helper function to create nodes and edges from dicts https://github.com/QuantStack/ipycytoscape/issues/185#issuecomment-733593298

So there is an example which I would probably enjoy seeing in the docs as it took me a while to figure it out (btw the gif in README is outdated), this is changing layout on the fly and using the exact positions of nodes (no layout). I even wonder if it would make sense to make name=None to act like name='preset' (with default being whatever is being used by default at the moment).

Code in:

https://github.com/krassowski/computational-notebooks-for-biomedical-research/blob/master/cytoscape_widgets.py
https://github.com/krassowski/computational-notebooks-for-biomedical-research/blob/master/Examples_Jupyter_notebook.ipynb

of note, in current examples the redraw currently happens on every callback, but it could only happen on if event['name'] != 'value': (I think that @ianhi mentioned this earlier elsewhere).

@krassowski this is sooooo cool

Thank you for this adition @krassowski is super! :)


DNS resolution fails in Kubernetes after upgrade from 1.1.4 to 1.2.0-pre4-rc11

**Rancher Version:**1.1.4 to 1.2.0-pre4-rc11
**Docker Version:**1.10.3
**OS and where are the hosts located? (cloud, bare metal, etc):**Ubuntu, Cloud
**Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)**Single node
**Environment Type: (Cattle/Kubernetes/Swarm/Mesos)**Kuberneres
Steps to Reproduce:

Create a Kubernetes env in v1.1.4
Upgrade rancher to 1.2.0-pre4-rc11
Upgrade environment

Results:
DNS resolution fails. kubectl cannot get nodes/pods
> kubectl get nodes
Unable to connect to the server: dial tcp: lookup master on <IP_ADDRESS>:53: no such host

ping from user pods does not work
root@k8testrc1-j22ro:/# ping www.google.com
ping: unknown host

based on debugging info, removing the 169.x.x.x route from the set of routes inside k8s containers, helps to restore the dns functionality:
root@k8testrc12-55c6z:/# ip route show
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/16 dev eth0  proto kernel  scope link  src <IP_ADDRESS>
<IP_ADDRESS> dev eth0  scope link  src <IP_ADDRESS>
<IP_ADDRESS>/16 dev eth0  proto kernel  scope link  src <IP_ADDRESS>

Tested with upgrade from 1.1.4 to 1.2.0-pre4-rc12. DNS resolution works in Kubernetes after upgrade from 1.1.4 to 1.2.0-pre4-rc12.


Godot closing itself while saving a scene after canceling its termination

Godot version
4.1.1.stable
System information
Godot v4.1.1.stable - Windows 10.0.22000 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1050 Ti (NVIDIA; <IP_ADDRESS>40) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
Issue description
https://github.com/godotengine/godot/assets/72339524/eccffb5b-d5e0-4f98-9626-391ee0d08a3f
Godot simply closes itself when trying to save a scene after canceling app termination
Steps to reproduce
Load a project, change something in the scene, try to close the engine but click on cancel, then try to save a scene and the engine will close itself
Minimal reproduction project
N/A

It can be reproduced in 4.1.dev1, possibly due to the introduction of #67466 (Scene tab closing refactor).

PR fix submitted.

Can't reproduce in 4.3.
I think there was a duplicate issue that got fixed independently.


Add :stopcountdown

This adds a :stopcountdown command that will stop all currently running Hint Countdowns and Countdowns for all players.
It also switches Hint Countdown to use service.StartLoop so that they can be more easily terminated when :stopcountdown is run.

Oops, this has commits from a different PR, I'll reopen with it correct


incorrect L2 RPC chain id on op-node

Followed the procedure. networks/mainnet/genesis.json and chain iD is set to 5000 as expected. OP_NODE_L1_ETH_RPC in docker-compose file is pointing to our internal node. Where else should I be checking to mitigate this error?
t=2024-11-19T14:33:21+0000 lvl=eror msg="Error initializing the rollup node" err="incorrect L2 RPC chain id, expected from config 5000, obtained from client 1"
t=2024-11-19T14:33:21+0000 lvl=eror msg="Unable to create the rollup node"   error="incorrect L2 RPC chain id, expected from config 5000, obtained from client 1"
t=2024-11-19T14:33:21+0000 lvl=crit msg="Application failed"                 message="incorrect L2 RPC chain id, expected from config 5000, obtained from client 1"

typo in docker compose file.


add omniruntime adapter for openLooKeng

add omniruntime adapter for openLooKeng

/check-cla

/lgtm

/lgtm

/approve


data: eddiejaoude2

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Closing as this was done for recording a video


Open a team for all contributors for falcon app

Hey to make it easier to mention everyone here to code review. Can you please create us some group for that? or any automation that put us all as reviewers for the PRs?
@mgold1234 @natifridman @kobihk @nunnatsa

IMHO when you add a group instead of specific persons it is less effective than to ask them literally

Hi @AvivLiberman. Adding a user to github team means to add them to the github organization. This is not what we want, but to only add users to the specific repo.
I added all of you to this repo.


e2e fix

Description

Short description here *

closes #4706
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Processing #4710.


Duplicate options appear in html

是的 我也遇到这个情况了
vscode 版本:

版本: 1.70.2 (Universal)
提交: e4503b30fc78200f846c62cf8091b76ff5547662
日期: 2022-08-16T05:36:37.829Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

volar插件版本:v0.40.13

希望能够尽快修复这个 BUG, Thanks♪(･ω･)ﾉ

Same issue, with only this extension enabled. Everything else disabled. As soon as I disable extension and reaload, bug is gone.

@johnsoncodehk   nonono,  are you sure ? I retested it your way, but it didn't change anything. And vscode doesn't recognize these configurations.

Can you reproduce this problem locally?
Myvscode version:

Version: 1.70.2 (Universal)
Commit: e4503b30fc78200f846c62cf8091b76ff5547662
Date: 2022-08-16T05:36:37.829Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

volar version:

@you-hengh You should install v1.0.0-alpha.0: #1880

@you-hengh You should install v1.0.0-alpha.0: #1880

Can you create a normal html file to open your volar and see if the code hints will be repeated twice?

I installed v1.0.0-alpha according to your request and set the specified configuration as you suggested, but the code hint was still displayed twice.
When the volar plug-in is disabled, the code prompt is displayed only once

so.....you look

@you-hengh You should not enable volar.vueserver.petiteVue.processHtmlFile and volar.vueserver.vitePress.processMdFile, it's for petite-vue / VitePress supports, please remove volar.vueserver.petiteVue.processHtmlFile, volar.vueserver.vitePress.processMdFile and reload VSCode.

@you-hengh You should not enable volar.vueserver.petiteVue.processHtmlFile and volar.vueserver.vitePress.processMdFile, it's for petite-vue / VitePress supports, please remove volar.vueserver.petiteVue.processHtmlFile, volar.vueserver.vitePress.processMdFile and reload VSCode.

yes!   yes!  it's OK!!!

Thank you very much!


Navigation drawer and search bar overlapping issue

In my case when I am implementing common header like this
NavigationLayout:

    MDToolbar:
        id: toolbar
        pos_hint: {"top": 1}
        title: "Navigation Drawer"
        md_bg_color: app.theme_cls.primary_color
        elevation: 10
        left_action_items: [['menu', lambda x: nav_drawer.toggle_nav_drawer()]]

    ScreenManager:
        id: scr_mngr
        size_hint_y: None
        height: root.height - toolbar.height

        Test1:
            id:sc1
        Test2:
            id:sc2
        Test3:
            id:sc3

    MDNavigationDrawer:
        id: nav_drawer

        ContentNavigationDrawer:
            id: content_drawer

for multiple screens and if I am implementing search bar on it then both are overlapping but
in older versions, I am not facing overlapping issues. see below how problem looks like

This is my sample working code
test.zip

@navjotcis https://github.com/HeaTTheatR/KivyMD/issues/157

@navjotcis

@HeaTTheatR Thank you for help


Do you provide code to reconstruct wav from only acoustic tokens?

We don't have this code ready yet. It's very likely that model may not reconstruct well.


Consider implementing RFC 9535

IETF RFC 9535 defines a proposed standard for JSONPath. Other resources:

A partial Compliance Test Suite.
Behaviours of various implementations can be checked in the comparison project. Please note that the JSONPath Reference Implementation referenced in the comparison project is stalled/archived and incomplete.
At the time of writing, online sandboxes for RFC 9535 are available in C# and in Rust.
For more background and comments on the status of the CTS and RI, see this this post (also here in the IETF blog).
Public discussion occurs in the IETF JSONPath Working Group's mailing list (archive).

(See here for updates to this list of resources.)
Valid approaches for this project are to (a) implement the RFC in whole or in part, (b) document its behaviour relative to the RFC, and (c) do nothing.

Thanks, Glyn. This project has been following the spec since 2022 and is up to date with it at the moment.

That's great news. Thanks.


Group admission groups by letter on overview page

When you are responsible for a lot of group admissions, the list becomes difficult to search. This PR adds grouping by first letter if there are >= 5 groups:

There are two things I wish we didn't do as much:

Inline CSS
Model logic in the view

The precedence for this has been set years ago in this project, but something we could do to clean up a bit. Otherwise, looks very good 👏

Inline CSS

Agreed, the goal is to move all common styles to the new bootstrap-like modern css system (eg. float right). I still think it is better to do inline css sometimes if you dont need too much styling. We discussed this and decided that its an acceptable tradeoff to prevent too many CSS files which are more difficult to manage and may cause accidental breaking of other pages.

Model logic in the view

Agreed
We'll try to keep this in mind moving forwards!

@evgiz Sounds good :-)


CIF-1474 - Support Bundle Products: add-to-cart and cart display

Description
Added support for adding to cart a customized bundle product
The cart also displays this customization when listing its content.
Related Issue
CIF-1304
CIF-1474
Motivation and Context
Support Bundle Products
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes and the overall coverage did not decrease.
[x] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

In general, I'm ok with the changes, the comments I've made are "nice-to-have"s


support for http://dzen.ru/video/watch

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and am willing to share it if required

Region
Russia
Example URLs
single video : https://dzen.ru/video/watch/6759f6b178cb546846d74e7d
playlist: https://dzen.ru/id/66636f6e74e3fd4b431e9301?clid=1400
Provide a description that is worded well enough to be understood
I cannot download video clips from that site. ie. dzen.ru/video/watch
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU https://dzen.ru/video/watch/6759f6b178cb546846d74e7d
[debug] Command-line config: ['-vU', 'https://dzen.ru/video/watch/6759f6b178cb546846d74e7d']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [542166962] (zip)
[debug] Python 3.10.12 (CPython x86_64 64bit) - Linux-5.15.0-126-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.11.0, brotli-1.0.9, certifi-2020.06.20, mutagen-1.45.1, requests-2.25.1, secretstorage-3.3.1, sqlite3-3.37.2, urllib3-1.26.5
[debug] Proxy map: {}
[debug] Request Handlers: urllib
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[ZenYandex] Extracting URL: https://dzen.ru/video/watch/6759f6b178cb546846d74e7d
[ZenYandex] 6759f6b178cb546846d74e7d: Downloading webpage
[ZenYandex] 6759f6b178cb546846d74e7d: Redirecting
ERROR: [ZenYandex] 6759f6b178cb546846d74e7d: Unable to extract metadata; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/usr/bin/yt-dlp/yt_dlp/extractor/common.py", line 742, in extract
    ie_result = self._real_extract(url)
  File "/usr/bin/yt-dlp/yt_dlp/extractor/yandexvideo.py", line 260, in _real_extract
    data_json = self._search_json(
  File "/usr/bin/yt-dlp/yt_dlp/extractor/common.py", line 1360, in _search_json
    json_string = self._search_regex(
  File "/usr/bin/yt-dlp/yt_dlp/extractor/common.py", line 1346, in _search_regex
    raise RegexNotFoundError(f'Unable to extract {_name}')

Duplicate of #11385


Add semantic versioning

Added v0.0.1 - https://github.com/radu-matei/azure-functions-golang-worker/releases/tag/v0.0.1


Refctor to support move to Azure Static Webapps

Promoted site generator to project :)
Live previews :)
Broken hard-coded links in generator :(

Addresses:

#7
#8

This PR breaks the site generation workflow.

This PR breaks the site generation workflow.

Fixed


[Feature] Appsmith functions should have object based signatures instead of functional arguments

Summary
Appsmith functions should have object based signatures instead of functional arguments.
Motivation
It's very hard to debug & understand the code when functions such as Api1.run(undefined, undefined, params) are written. A much better way to write these functions would be:
Api1.run(
onSuccess: () => {},
onError: () => {},
params: {}
)

This ensures cleanliness of code & much greater user understandability of the Appsmith product.

Api.run now supports params as object. Also, success and failure callbacks can not be then and catch block. I believe this was the intention with above feature request hence closing this now.


Basic pretrained models + quickstart instructions?

Hi there,
Practitioner of several years with deep experience (not much GH footprint in terms of recent experience) in model architecture selection, training, etc. This looks like a fun enough problem for me to work on, not definitely confirmed on it, but looking on potentially picking this up as a side project from when I have spare 'problem-solving' cycles to burn on things for funsies.
I guess in looking through everything there's a possibility to kick everything off from scratch, but I'm a fan of pretrained models, or at least partially-trained models in some form. Are there any S3 dumps of model checkpoints we can finetune from?
Also, in scanning the README, my old training setup is rather aged -- 1070, so the TPU/V100 space on CoLab is probably my go to for now. Do you have a local setup, conda env, docker container, etc that you're working in? Looking to see if there's anything I need to do to standardize the path on my end.
Thanks for putting all of this together. Been working on a few semi-ish related things (not too close, but semi) for a little while, and been watching this repo. Glad to see it's alive and still moving.
If it's of any value, are there branch privs on this repo, and is there any process I should go through to getting those? I'm not looking for anything beyond being able to create/push to individual remote branches, I'd like the PR process and everything that comes with it.
Many thanks, hope you are well,
EF

Hi there! We're always glad to see new people joining the conversation!
Let's address the outlined points:

Regarding pretrained models: We do not have any pretrained models yet, as the codebase is still a work in progress and some details still need to be tweaked.
As for any "reproducible environment": we do not have a sandard docker image. Since the code is provided a package, most of the packages needed for the components assembled are installed automatically when this code is installed as a package. For some initial tests, there's a notebook which installs the necessary dependencies at the beginning which you could use as a starting point: https://github.com/lucidrains/alphafold2/blob/main/notebooks/egnn_esm_end2end.ipynb
Regarding private branches: the development of the main project is carried out in public, as far as I know, and everyone is encouraged to submit changes in the format of Pull Requests.

We're discussing the developments of the project in the EleutherAI discord (#alphafold channel) which you can join here: https://discord.com/invite/vtRgjbM


Type missmatch in generator with static PHP Mapping (LazyUuidFromString to property Uuid)

Hello,
i got a type missmatch on persist:
Cannot assign Ramsey\Uuid\Lazy\LazyUuidFromString to property SharedBookshelf\Entities\User::$id of type Ramsey\Uuid\Uuid
versions:
doctrine/orm: 2.8.1
ramsey/uuid-doctrine: 1.6.0

The entity code:
<?php declare(strict_types=1);

namespace SharedBookshelf\Entities;

use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
use Doctrine\ORM\Mapping\ClassMetadata;
use Ramsey\Uuid\Doctrine\UuidGenerator;
use Ramsey\Uuid\Uuid;
use SharedBookshelf\Repositories\UserRepository;

class User implements Entity
{
    private Uuid $id;
    private string $username = '';
    private string $password = '';

    public static function loadMetadata(ClassMetadata $metadata): void
    {
        $builder = new ClassMetadataBuilder($metadata);
        $builder->createField('id', 'uuid')
            ->makePrimaryKey()
            ->generatedValue('CUSTOM')
            ->setCustomIdGenerator(UuidGenerator::class)
            ->build();
        $builder->setCustomRepositoryClass(UserRepository::class);
        $builder->addField('username', 'string');
        $builder->addField('password', 'string');
    }

    public function getId(): Uuid
    {
        return $this->id;
    }

    public function getUsername(): string
    {
        return $this->username;
    }

    public function setUsername(string $username): void
    {
        $this->username = $username;
    }

    public function getPassword(): string
    {
        return $this->password;
    }

    public function setPassword(string $password): void
    {
        $this->password = $password;
    }

}

i am not 100% sure if this is due to the fact that i use the static php meta function, i took your annotation example as the basis in combination with: https://www.doctrine-project.org/projects/doctrine-orm/en/2.8/reference/php-mapping.html#php-mapping
The detailed error with trace (project: https://github.com/xuedi/sharedBookshelf):
Details
Type: TypeError
Code: 0
Message: Cannot assign Ramsey\Uuid\Lazy\LazyUuidFromString to property SharedBookshelf\Entities\User::$id of type Ramsey\Uuid\Uuid
File: /home/xuedi/projects/sharedBookshelf/vendor/doctrine/persistence/lib/Doctrine/Persistence/Reflection/TypedNoDefaultReflectionProperty.php
Line: 46
Trace

#0 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/persistence/lib/Doctrine/Persistence/Reflection/TypedNoDefaultReflectionProperty.php(46): ReflectionProperty->setValue()
#1 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php(762): Doctrine\Persistence\Reflection\TypedNoDefaultReflectionProperty->setValue()
#2 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(964): Doctrine\ORM\Mapping\ClassMetadataInfo->setIdentifierValues()
#3 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(1790): Doctrine\ORM\UnitOfWork->persistNew()
#4 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php(1746): Doctrine\ORM\UnitOfWork->doPersist()
#5 /home/xuedi/projects/sharedBookshelf/vendor/doctrine/orm/lib/Doctrine/ORM/EntityManager.php(614): Doctrine\ORM\UnitOfWork->persist()
#6 /home/xuedi/projects/sharedBookshelf/src/Repositories/UserRepository.php(19): Doctrine\ORM\EntityManager->persist()
#7 /home/xuedi/projects/sharedBookshelf/src/Controller/SignupController.php(65): SharedBookshelf\Repositories\UserRepository->save()
#8 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(43): SharedBookshelf\Controller\SignupController->index()
#9 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/Routing/Route.php(384): Slim\Handlers\Strategies\RequestResponse->__invoke()
#10 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Slim\Routing\Route->handle()
#11 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Slim\MiddlewareDispatcher->handle()
#12 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/Routing/Route.php(341): Slim\MiddlewareDispatcher->handle()
#13 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/Routing/RouteRunner.php(84): Slim\Routing\Route->run()
#14 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(107): Slim\Routing\RouteRunner->handle()
#15 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/MiddlewareDispatcher.php(147): Slim\Middleware\ErrorMiddleware->process()
#16 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#17 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/App.php(215): Slim\MiddlewareDispatcher->handle()
#18 /home/xuedi/projects/sharedBookshelf/vendor/slim/slim/Slim/App.php(199): Slim\App->handle()
#19 /home/xuedi/projects/sharedBookshelf/src/Framework.php(58): Slim\App->run()
#20 /home/xuedi/projects/sharedBookshelf/src/Factory.php(63): SharedBookshelf\Framework->run()
#21 /home/xuedi/projects/sharedBookshelf/public/index.php(17): SharedBookshelf\Factory->run()
#22 {main}

This seems to be because of https://github.com/ramsey/uuid/issues/327 and the addition of LazyUuidFromString in 4.1. I'm having a similar issue with the version 4.1 of ramsey/uuid

You are supposed to declare the type to be UuidInterface, not Uuid, which is only one possible implementation of a UuidInterface.
This is a bug in your type declaration, not in this library.
This is explained in https://github.com/ramsey/uuid/issues/327#issuecomment-683883097

As @Ocramius said, please use UuidInterface instead of Uuid. Thanks!


[consensus] remove ChainedBftSMR

Motivation
The only responsibility of ChainedBftSMR today is to spawn the event loop and
hold the runtime, so we can just return the runtime as other services.
All the tests written in chained_bft_smr_test should be either move to
event_processor_test to test the event driven response or smoke tests as
integration tests.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Existing tests.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

Oh wow, seeing all the chained bft smr tests removed hurts...
So the chained_bft_smr_tests today are using network playground to control the message delivery and thus play different scenarios. This is not something we can easily do with the smoke tests today.
I guess it's a matter of terminology, but the smoke tests today are using real DB / execution / network / state-sync.
Chained-bft-smr tests could mock them all and test consensus functionality only. Isn't it a good thing to have?

Totally agree we don't have the ability to control network in smoke test which should be added.
There's two types of tests there

test expected behavior upon certain event which belongs to unit test in event_processor
test overall system works (with fault tolerance) which belongs to e2e tests in smoke tests

Here's a list of mapping of the existing tests:
Already exist:
basic_start_test  -> smoke_test_multi_node
start_with_proposal_test -> smoke_test_single_node
happy_path_with_multi_proposer -> smoke_test_multi_node with multi proposer
basic_full_round_test -> smoke_test_multi_node
basic_block_retrieval -> event_processor::process_block_retrieval
basic_state_sync -> test_basic_state_synchronization
basic_commit_and_restart -> test_basic_restartability
basic_commit_and_restart_from_clean_storage -> test_startup_sync_state_with_empty_consensus_db
chain_with_nil_blocks -> event_processor::nil_vote_on_timeout
aggregate_timeout_votes -> event_processor::process_vote_timeout_msg_test
Should add:
state_sync_on_timeout -> event_processor::sync_on_timeout
block_retrieval_with_timeout -> event_processor::block_retrieval_on_timeout
secondary_proposers -> event_processor::secondary_vote_on_timeout
sync_info_sent_if_remote_stale -> event_processor::sync_info_sent_if_remote_stale

yup, going to do some cleanup and add missing event_processor test

@bors-libra r=davidiw

:pushpin: Commit 4991a8a has been approved by davidiw

:hourglass: Testing commit 4991a8a4f844174f6cc6547c98093d1a93d58817 with merge f01aef5c9a774b1826d0082a4447171391941d37...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing f01aef5c9a774b1826d0082a4447171391941d37 to master...

ah I will miss chained_bft_smr_test.rs


discovery: TopologyWatcher.Stop() should wait for all Go routines to …

@alainjobart @michael-berlin
…finish

This change is

LGTM