[Feature Request] Sort On Time

The problem I have activating "Sort On Before Save" is that I've auto save triggering after 1 second automatically. Which tries to reorder my imports while I'm writing them.
It would be nice to have a "Sort On Time" and put the time in ms, to be able to separate both functions but still have automatic sorting.
Thank you in advance.

I was also facing a similar issue with the 'import-sorter' extension in vs code. Just a suggestion for ext. maintainers the sort should trigger on some event like pressing cmd+s/ctrl+s or at the custom shortcut, so that developer/user has control over it, just like say prettier ext. formatting is working when 'format on save' and 'auto-save' is enabled in vs code editor.
Thanks.


Application forgets vMix IP address

The application does not save the latest IP address used. For example, if I connect to a remote machine over LAN then I would like to use an IP like <IP_ADDRESS> but after closing and reopening Listotron it shows default address <IP_ADDRESS>.
If already implementing the remembring of the latest IP maybe also implement history as a dropdown selector for quick access lately used IP-s.

I will work on this


swagger-ui middleware generates wrong URL when behind a proxy

The swagger-ui middleware will set a Swagger-API-Docs-URL response header so that swagger-ui can load the proper Swagger definition.  This feature does not work when you are behind a proxy or serve your swagger-tools API from some base path.

#317 fixes this.


added security sample

added security sample
some bugfixes for security layer
client can define realm / application with request
better config params for security
fix for https://github.com/canoo/dolphin-platform/issues/782

This change is

Coverage decreased (-0.1%) to 54.436% when pulling 797d187002a92803c0ca398a0b98df80370e03c4 on security-sample into 1311bf975ecfd4f9508c32ab2b5576169e2062d5 on master.

Coverage decreased (-0.1%) to 54.436% when pulling 3d9e2adbb39fe0938b13c94304ec51fb9ed57422 on security-sample into 1311bf975ecfd4f9508c32ab2b5576169e2062d5 on master.

Coverage decreased (-0.1%) to 54.436% when pulling 3d9e2adbb39fe0938b13c94304ec51fb9ed57422 on security-sample into 1311bf975ecfd4f9508c32ab2b5576169e2062d5 on master.

Coverage decreased (-0.1%) to 54.455% when pulling d91c94f29d97bb353ca1f7f91e8571277dfda473 on security-sample into 1311bf975ecfd4f9508c32ab2b5576169e2062d5 on master.


Add support for multi-contract calls to unit testing

On slack it was mentioned that unit testing would be limited to calling into the current contract, however this doesn't need to be the case.
It should be possible to call into all contracts that were declared under [contract-dependencies] whether directly or transitively. We have their src, and can build and deploy them just like we can build and deploy a local contract.
This would make for a good followup to #3262 cc @kayagokalp. Rather than only deploying the project contract, we'd deploy all contract dependencies that exist within the graph.
We will still be limited in the case that a contract attempts to call into another contract that is not declared under [contract-dependencies], e.g. if a contract is constructed from a raw contract ID within Sway code.
This is something we should communicate in the [contract-dependencies] docs and under the Sway contract docs in general - to encourage users to always declare their contract dependencies under [contract-dependencies] if possible as it gives forc the power to do cool stuff like this.
It might be possible to support private contracts (where the src or salt is not known) by extending the [contract-dependencies] feature a little. I'll open a new issue with some thoughts. Edit: see #3572.

Deploying undeclared contract dependencies
Thinking on this more, a contract dependency must always be declared in the inputs of the transaction in order to call into it from a contract or script.
This implies that it should be possible for us to fetch and inspect the Create transactions of contract dependencies to detect any other transient contract dependencies so that we can fetch those, deploy them, check their transaction inputs for more contract dependencies, and so on. We can potentially integrate this fetching of undeclared contract dependencies during our package graph construction so that we can reason about them alongside the rest of our dependencies.
We should investigate how fuels currently determines what contracts should be present in the transaction inputs, as we can likely do something similar for detecting and determining the IDs of undeclared contract dependencies in workspace members before deploying them.

For now, we can stick to deploying declared [contract-dependencies] as we don't yet have infrastructure in forc for querying the fuel network. The package registry (#3752) will require such support, so perhaps we can revisit deploying undeclared contract dependencies in the future.

On a related note: As scripts may also have [contract-dependencies], we should likely also support deploying all contract dependencies for script tests too (not just contract tests). This would allow for scripts to declare unit tests that test out certain contract interactions before running the real thing.


Kube-dns issue when specifying custom vnet + kubenet + k8s 1.8 + acs-engine v0.14.5 + 2 agent pools

Is this a request for help?:  No

Is this an ISSUE or FEATURE REQUEST? (choose one):  ISSUE

What version of acs-engine?: acs-engine 0.14.5

K8S 1.8
What happened:
I discovered if I created a service with 2 endpoints, and then ssh’ed to an agent node, curling to the service IP endpoint only worked 50% of the time.  (i.e. when the service routed the request to the same agent host I was running on)
It manifests itself as this error:  https://github.com/feiskyer/kubernetes-handbook/blob/master/en/troubleshooting/cluster.md#kube-dnsdashboard-crashloopbackoff
Logs from running:
kubectl logs -n kube-system kube-dns-v20-5d9fdc7448-9t257 kubedns
I0329 20:25:28.095397       1 dns.go:173] Waiting for services and endpoints to be initialized from apiserver...
E0329 20:25:28.595180       1 reflector.go:201] k8s.io/dns/pkg/dns/dns.go:147: Failed to list *v1.Endpoints: Get https://<IP_ADDRESS>:443/api/v1/endpoints?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout
I0329 20:25:28.595257       1 dns.go:173] Waiting for services and endpoints to be initialized from apiserver...
E0329 20:25:28.595819       1 reflector.go:201] k8s.io/dns/pkg/dns/dns.go:150: Failed to list *v1.Service: Get https://<IP_ADDRESS>:443/api/v1/services?resourceVersion=0: dial tcp <IP_ADDRESS>:443: i/o timeout
I0329 20:25:29.095305       1 dns.go:173] Waiting for services and endpoints to be initialized from apiserver...

thfalgou@k8s-master-30864926-0:~$ kubectl get ep -n kube-system kube-dns
NAME       ENDPOINTS   AGE
kube-dns               49m

thfalgou@k8s-master-30864926-0:~$ ssh k8s-agentpri-30864926-0
thfalgou@k8s-agentpri-30864926-0:~$ curl <IP_ADDRESS>

Times out 50% of the time.

Other half of the time:
Hostname: foo-svc-5c4f4c85b9-c5kvk

Pod Information:
	node name:	 k8s-agentpri-30864926-0
	pod name:	 foo-svc-5c4f4c85b9-c5kvk
	pod namespace:	 default
	pod IP:  	 <IP_ADDRESS>

What you expected to happen:
I expect the service to work 100% of the time.
How to reproduce it (as minimally and precisely as possible):
# az group create -n rgSprinttDev -l southcentralus

# az network vnet create -g rgSprinttDev -n vnSprinttDev --address-prefix <IP_ADDRESS>/24 --subnet-prefix <IP_ADDRESS>/24 --subnet-name snSprinttK8sDev

# acs-engine deploy --api-model avigo.json --subscription-id df8428d4-bc25-4601-b458-1c8533ceec0b -l southcentralus --resource-group rgSprinttDev

# kubectl apply -f https://raw.githubusercontent.com/evillgenius75/docker-labs/master/K8s/foo-svc-int.yaml

# cat avigo.json

{
  "apiVersion": "vlabs",
  "properties": {
    "orchestratorProfile": {
      "orchestratorType": "Kubernetes",
   "orchestratorRelease": "1.8",
      "kubernetesConfig": {
        "networkPolicy": "none",
        "privateCluster": {
          "enabled": true
        }
      }
    },
    "masterProfile": {
      "count": 1,
      "dnsPrefix": "dnsSprinttPenn",
      "vmSize": "Standard_D2_v2",
      "vnetSubnetId": "/subscriptions/df8428d4-bc25-4601-b458-1c8533ceec0b/resourceGroups/rgSprinttDev2/providers/Microsoft.Network/virtualNetworks/vnSprinttDev2/subnets/snSprinttK8sDev2",
      "firstConsecutiveStaticIP": "<IP_ADDRESS>",
      "vnetCidr": "<IP_ADDRESS>/24"
    },
    "agentPoolProfiles": [
      {
        "name": "agentpri",
        "count": 1,
        "vmSize": "Standard_D2_v2",
        "vnetSubnetId": "/subscriptions/df8428d4-bc25-4601-b458-1c8533ceec0b/resourceGroups/rgSprinttDev2/providers/Microsoft.Network/virtualNetworks/vnSprinttDev2/subnets/snSprinttK8sDev2",
        "availabilityProfile": "AvailabilitySet"
      },
      {
        "name": "agentpri2",
        "count": 1,
        "vmSize": "Standard_D2_v2",
        "vnetSubnetId": "/subscriptions/df8428d4-bc25-4601-b458-1c8533ceec0b/resourceGroups/rgSprinttDev2/providers/Microsoft.Network/virtualNetworks/vnSprinttDev2/subnets/snSprinttK8sDev2",
        "availabilityProfile": "AvailabilitySet"
      }
    ],
"linuxProfile": {
      "adminUsername": "thfalgou",
      "ssh": {
        "publicKeys": [
          {
            "keyData": "<removed>"
          }
        ]
      }
    },
    "servicePrincipalProfile": {
      "clientId": "<removed>",
      "secret": "<removed>"
    }
  }
}

@lastcoolnameleft Did you run the command described here to attach the route table to your VNET after cluster creation?
https://github.com/Azure/acs-engine/blob/master/docs/custom-vnet.md#post-deployment-attach-cluster-route-table-to-vnet
This is required to make the proper network attachments for kubenet ("networkPolicy": "none") clusters.

@jackfrancis Thanks for the information!  I'll work with the customer to see if this fixes their issue.

@lastcoolnameleft I was not able to reproduce the issue after deploying the same apimodel, do you know if this is a transient error or if 100% of deployments with that apimodel show these symptoms?

Glad to hear this was fixed, sorry for the manual ugliness, but your courage and perseverance was rewarded!


Add HyperLogLog Data Type

Adds HLL data type + bucket properties.
Test with a devrel of this Riak branch: https://github.com/basho/riak_ee/tree/develop-2.2
Docs PR forthcoming.

Docs at https://github.com/basho/private_basho_docs/commit/a126a2d2a5097e06b79062853e56769e3a346b2f.

@alexmoore nice job :+1:


ClipboardMonitor causes background lag when enabling clipboard buttons

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
flutter_quill: ^11.0.0-dev.17  &  flutter_quill_extensions: ^11.0.0-dev.7
Steps to reproduce

Add QuillSimpleToolbar and pass QuillSimpleToolbarConfig with showClipboardCut, showClipboardCopy, or showClipboardPaste set to true
Since it adds the button with Clipboard Service it causes performance issues:
Source code for reference:

import 'dart:async';

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

import '../../common/utils/widgets.dart';
import '../../editor_toolbar_controller_shared/clipboard/clipboard_service_provider.dart';
import '../../l10n/extensions/localizations_ext.dart';
import '../base_button/base_value_button.dart';
import '../simple_toolbar.dart';

enum ClipboardAction { cut, copy, paste }

class ClipboardMonitor {
  bool _canPaste = false;
  bool get canPaste => _canPaste;
  Timer? _timer;

  void monitorClipboard(bool add, void Function() listener) {
    if (kIsWeb) return;
    if (add) {
      _timer = Timer.periodic(
          const Duration(seconds: 1), (timer) => _update(listener));
    } else {
      _timer?.cancel();
    }
  }

  Future<void> _update(void Function() listener) async {
    final clipboardService = ClipboardServiceProvider.instance;
    if (await clipboardService.hasClipboardContent) {
      _canPaste = true;
      listener();
    }
  }
}

class QuillToolbarClipboardButton extends QuillToolbarToggleStyleBaseButton {
  QuillToolbarClipboardButton({
    required super.controller,
    required this.clipboardAction,
    super.options = const QuillToolbarToggleStyleButtonOptions(),

    /// Shares common options between all buttons, prefer the [options]
    /// over the [baseOptions].
    super.baseOptions,
    super.key,
  });

  final ClipboardAction clipboardAction;

  final ClipboardMonitor _monitor = ClipboardMonitor();

  @override
  State<StatefulWidget> createState() => QuillToolbarClipboardButtonState();
}

class QuillToolbarClipboardButtonState
    extends QuillToolbarToggleStyleBaseButtonState<
        QuillToolbarClipboardButton> {
  @override
  bool get currentStateValue {
    switch (widget.clipboardAction) {
      case ClipboardAction.cut:
        return !controller.readOnly && !controller.selection.isCollapsed;
      case ClipboardAction.copy:
        return !controller.selection.isCollapsed;
      case ClipboardAction.paste:
        return !controller.readOnly && (kIsWeb || widget._monitor.canPaste);
    }
  }

  void _listenClipboardStatus() => didChangeEditingValue();

  @override
  void addExtraListener() {
    if (widget.clipboardAction == ClipboardAction.paste) {
      widget._monitor.monitorClipboard(true, _listenClipboardStatus);
    }
  }

  @override
  void removeExtraListener(covariant QuillToolbarClipboardButton oldWidget) {
    if (widget.clipboardAction == ClipboardAction.paste) {
      oldWidget._monitor.monitorClipboard(false, _listenClipboardStatus);
    }
  }

  @override
  String get defaultTooltip => switch (widget.clipboardAction) {
        ClipboardAction.cut => context.loc.cut,
        ClipboardAction.copy => context.loc.copy,
        ClipboardAction.paste => context.loc.paste,
      };

  @override
  IconData get defaultIconData => switch (widget.clipboardAction) {
        ClipboardAction.cut => Icons.cut_outlined,
        ClipboardAction.copy => Icons.copy_outlined,
        ClipboardAction.paste => Icons.paste_outlined,
      };

  void _onPressed() {
    switch (widget.clipboardAction) {
      case ClipboardAction.cut:
        controller.clipboardSelection(false);
        break;
      case ClipboardAction.copy:
        controller.clipboardSelection(true);
        break;
      case ClipboardAction.paste:
        controller.clipboardPaste();
        break;
    }
    afterButtonPressed?.call();
  }

  @override
  Widget build(BuildContext context) {
    final childBuilder = this.childBuilder;
    if (childBuilder != null) {
      return childBuilder(
        options,
        QuillToolbarToggleStyleButtonExtraOptions(
          context: context,
          controller: controller,
          onPressed: _onPressed,
          isToggled: currentValue,
        ),
      );
    }

    return UtilityWidgets.maybeTooltip(
        message: tooltip,
        child: QuillToolbarIconButton(
          icon: Icon(
            iconData,
            size: iconSize * iconButtonFactor,
          ),
          isSelected: false,
          onPressed: currentValue ? _onPressed : null,
          afterPressed: afterButtonPressed,
          iconTheme: iconTheme,
        ));
  }
}

Since the QuillToolbarClipboardButton was added to the Widget tree, it starts affecting the app performance & memory on the background, even if you are not actively copying or pasting with clipboard at the moment.

W/Looper  ( 4641): PerfMonitor longMsg : seq=69 plan=18:41:47.480 late=0ms wall=1570ms h=android.os.Handler c=io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0 procState=-1
W/Looper  ( 4641): PerfMonitor longMsg : seq=71 plan=18:41:48.479 late=572ms wall=1418ms h=android.os.Handler c=io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0 procState=-1
W/Looper  ( 4641): PerfMonitor longMsg : seq=73 plan=18:41:49.479 late=991ms wall=1410ms h=android.os.Handler c=io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0 procState=-1
W/Looper  ( 4641): PerfMonitor longMsg : seq=74 plan=18:41:50.559 late=1323ms wall=1427ms h=android.os.Handler c=io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0 procState=-1
...
...

Expected results
Expected Clipboard to not be as heavy for the application and to not cause performance issues.
Actual results
ClipboardService causes background lag when used.

It is possible there is a better implementation of Clipboard Monitor. I will try to take a look myself and tweak some stuff to see if it is any better. Right now it re-instantiates the ClipboardService every second, which could be an issue.
class ClipboardMonitor {
  bool _canPaste = false;
  bool get canPaste => _canPaste;
  Timer? _timer;

  void monitorClipboard(bool add, void Function() listener) {
    if (kIsWeb) return;
    if (add) {
      _timer = Timer.periodic(
          const Duration(seconds: 1), (timer) => _update(listener));
    } else {
      _timer?.cancel();
    }
  }

  Future<void> _update(void Function() listener) async {
    final clipboardService = ClipboardServiceProvider.instance;
    if (await clipboardService.hasClipboardContent) {
      _canPaste = true;
      listener();
    }
  }
}

flutter_quill: ^11.0.0-dev.17

Did you encounter the issue with older versions in case you used them?

with showClipboardCut, showClipboardCopy, or showClipboardPaste set to true
Since it adds the button with Clipboard Service it causes performance issue

To clarify, the ClipboardService is used even when the clipboard toolbar buttons are disabled. The issue is likely with ClipboardMonitor.

Did you encounter the issue with older versions in case you used them?

I used the previous versions but cannot confirm with certainty that it was also present.
I'll be looking into Clipboard monitor and try to fix them on myself and will open a PR if I have success.
Thanks for clarifying that Clipboard service is actually being used even when the buttons are not visible, I was not aware of this and it actually reduces the scope for my investigation :)
Also, Merry Christmas 🎄

I used the previous versions but cannot confirm with certainty that it was also present

The PR #1843 could be related, disabling the clipboard toolbar buttons should fix the issue.

I was not aware of this and it actually reduces the scope for my investigation :)

It might be worth trying quill_super_clipboard since it will replace the quill_native_bridge clipboard implementation with super_clipboard to confirm whether this is an issue with the DefaultClipboardService.

for clarifying that Clipboard service is actually being used even when the buttons are not visible

It's being used when copying an image, pasting an image (when flutter_quill_extension is utilized), and pasting rich text content from the system clipboard (as HTML).
What is the use-case for clipboard actions in the toolbar, or why is it needed?

Thanks
Merry Christmas 🎄

You're welcome. I'm familiar with those parts (except #1843), so let me know if you have questions.

What is the use-case for clipboard actions in the toolbar, or why is it needed?

Just a very convenient way to use some actions (especially paste). I have no problem implementing them on my own, but I'll give it a try to fix buttons / clipboard monitor, so those actions are available for everyone using the plugin from toolbar as well.

It's being used when copying an image, pasting an image (when flutter_quill_extension is utilized), and pasting rich text content from the system clipboard (as HTML).

After a second thought, I do use them for pasting images. I'll give it a proper test and come back to it later on

I will disable those buttons as a breaking change in v11

Change introduced (7abe6d2365542d2e23047bfafe35ad5949391831).

I have concluded my review and can give some more details:

The issue is only present for "Paste" button.
PerfMonitor messages were complaining only about await Clipboard.getData(Clipboard.kTextPlain); function when there  was a big enough content: image or a lot of text. *The function itself is Flutter's own implementation and works as intended.
Since the timer was periodic and was checking that every 1 second, it indeed causes a lot of lag and without debouncer / optimization it seems like a very heavy check when there is big clipboard content.
One way to optimize that would be to introduce a flag if clipboard content is already being retrieved and do not trigger the function again in that case and while it will improve the performance by a lot in some cases, it is still not enough in others and feels a little bit useless since the timer is running constantly.

I would suggest to allow the users to determine "canPaste" status on their own and take control of the button's state. Then the users can also implement their own error handling for "onPaste".
Then we don't need periodic timer and the function will only be called during the actual use of it, which seems optimal to me.
Let me know if you would agree and then I can prepare a PullRequest with changes.

, it indeed causes a lot of lag and without debouncer / optimization it seems like a very heavy check when there is big clipboard content.

One possible solution is to listen to the system clipboard changes, which involves platform-specific code and might not be available on some platforms or has some restrictions.

await Clipboard.getData(Clipboard.kTextPlain)

I was considering replacing it with platform code in quill_native_bridge to solve the image paste issue, which was fixed in #2384 by pasting the image first.

I would suggest to allow the users to determine "canPaste" status on their own and take control of the button's state. Then the users can also implement their own error handling for "onPaste".

How would they solve it? It's not possible without platform code AFAIK, and I think users prefer something that's already implemented without much configuration.
For now, we should notify users about this issue before they enable those buttons.

One possible solution is to listen to the system clipboard changes, which involves platform-specific code and might not be available on some platforms or has some restrictions.

Exactly. I was trying to see if there are available solutions but it feels like an overkill

How would they solve it? It's not possible without platform code AFAIK, and I think users prefer something that's already implemented without much configuration.

This is already implemented in flutter with the simple in-built import from "services".
import 'package:flutter/services.dart';

...

await Clipboard.getData(Clipboard.kTextPlain);

And this is exactly the same how it is used in flutter quill => clipboard_service
  /// If the Clipboard is not empty or has something to paste
  Future<bool> get hasClipboardContent async {
    final clipboardData = await Clipboard.getData(Clipboard.kTextPlain);
    return clipboardData != null;
  }

For me it also feels like that they can implement their own "canPaste" (aka isEnabled) if they really need it to avoid periodic checks.
Aka:

Enable "canPaste" always by default
Allow pasting their own state to "canPaste" flag
If "paste" fails or no content found, they can handle it on their own (for example display a snackbar saying "no clipboard content").

You can paste this code to dartpad to verify that it is available.
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  void getClipboardContent() async {
    final ClipboardData? clipboardData =
        await Clipboard.getData(Clipboard.kTextPlain);
    final String? copiedText = clipboardData?.text;

    print("Clipboard content: ${copiedText}");
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: OutlinedButton(
            onPressed: getClipboardContent,
            child: Text("Print clipboard content"),
          ),
        ),
      ),
    );
  }
}

And this is exactly the same how it is used in flutter quill => clipboard_service

BTW, the current solution is not efficient. The hasClipboardContent determines if it has copied something to the system clipboard and if we can paste it. This will only check plain text. It's on my TODO list to improve it.

This is already implemented in flutter with the simple in-built import from "services".

The issue is how we can listen to clipboard state changes, and the current solution achieves that by running platform code every 1 second from the Dart side, which is not efficient.

For me it also feels like that they can implement their own "canPaste" (aka isEnabled) if they really need it to avoid periodic checks.

Assuming they have greater control,
how would they solve the issue? There is almost no cross-platform solution that's consistent.
I will check to see if it's possible using platform code.

I think it comes to the discussion if the "canPaste" flag is even needed for the in-built "paste" button.
For my use case I would just completely remove the canPaste flag and make it always active, and handle the exceptions/empty clipboard when I actually interact with the button


[BUG] Typo on landing page

Describe the bug
On the landing page of the website there are two sentences with a typo:
Just under the title there is:
"Open source UI visual tool to build your customized LLM ochestration flow & AI agents"
And under get started the title:
"LLM Ochestration"
Expected behavior
It should be Orchestration
Screenshots

appreciate the notice, now fixed!


Please use git tags

Please tag your releases, so they can be seen on GitHub.
Also, this may help F-Droid.

We haven't been tagging releases since the iOS and Android version numbers are sometimes out of sync (mostly when a minor patch is released for bugs only present on one platform), and we aren't using GitHub tags for F-Droid anyway, but we could put in separate release tags for iOS and Android, like Mapbox does.
We'll do this starting with the next release, unless the community thinks it's worth tagging retroactively. Thank you for the suggestion.

Yeah, nothing is wrong with tagging separate tags for Android/iOS.


Updates based on notebook implementation

Changes needed for https://github.com/jupyter/jupyter-js-notebook/pull/213

👍


feat(ui-ux): allow 100% dusd vault to borrow non-dusd tokens

What this PR does / why we need it:
Allow borrowing of dTokens when vault has 100% DUSD collateral
To borrow DUSD token:

Vault should have DFI collateral > 50% (of loan value) AND vault should NOT have any DUSD collateral
Vault has 100% DUSD collateral (newly added when dusd-loop is enabled)

To borrow non-DUSD tokens:

Vault should have DFI collateral > 50% of loan value
Vault should have DUSD collateral > 50% of loan value

Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

Codecov Report

Merging #4129 (f93baf5) into main (d61a44b) will increase coverage by 2.27%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main    #4129      +/-   ##
==========================================
+ Coverage   56.07%   58.35%   +2.27%
==========================================
  Files         438      438
  Lines       12353    12356       +3
  Branches     4090     4091       +1
==========================================
+ Hits         6927     7210     +283
+ Misses       5342     5056     -286
- Partials       84       90       +6

Files
Coverage Δ

...r/screens/Loans/hooks/ValidateLoanAndCollateral.ts
94.73% <100.00%> (-0.27%)
:arrow_down:

...eens/Loans/screens/AddOrRemoveCollateralScreen.tsx
54.95% <0.00%> (-1.47%)
:arrow_down:

... and 60 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


[PROJECT PROPOSAL] Garbage classifier using computer vision

Project Request
Algorithm that shorts different types of garbage materials, organic, metal, plastic etc to help automate recycling, using computer vision and CNN

Field
Description

About
This project will classify different types of garbage materials

Github
Gaurav0369

Email
<EMAIL_ADDRESS>

Label
Project Request

github.com/Gaurav0369

Define You

[x] GSSOC Participant
[x] Contributor

Project Name
Garbage classifier
Description
This algorithm will be able to detect and classify among 7 different types of garbage materials which help immensly in automating the recycling process
[Description of the project, its goals, and expected outcomes]
Scope
It will use the camera and can detect one material at a time and a total of 7 materials, if there is no material it will output "none".
[The project's boundaries, including its objectives, deliverables, and constraints]
Timeline
7 august 2023
[The project's estimated start and end dates, milestones, and deadlines for deliverables]

Hi @miraj0507 @adithya-s-k , I have created this issue under GsSoc'23 and want to work on it please assign it to me.


No LOD visualisation without http://labs.regesta.com/resourceProxy/ ?

Hello again (one last time)
I have loaded a GETTY thesaurus into a bigdata rdf store and I can browse it from inside lodlive.
From an analisys of the javascript calls issued by lodlive I noticed a call to
http://labs.regesta.com/resourceProxy/?uri=http%3A%2F%2Fvocab.getty.edu%2Faat%2Fsource%2F2000087067&query=SELECT DISTINCT * WHERE {<http%3A%2F%2Fvocab.getty.edu%2Faat%2Fsource%2F2000087067> %3Fproperty %3Fobject. FILTER(%3Fproperty !%3D <http%3A%2F%2Fdbpedia.org%2Fontology%2FwikiPageWikiLink>)} ORDER BY %3Fproperty&callback=lodlive
How is lodlive really functioning? Is lodlive only functioning because it calls http://labs.regesta.com/resourceProxy/ ? Why does it have to call it ? Lodlive was supposed (I think) to work with an LOD endpoint, not needing any further repository ...
I would appreciate very much your response here
Thank you very much
Regards

Hello
I think I can answer to my question: labs.regesta.com/resourceProxy is the real processor of lodlab. This was your decision, data come from the browser down to regesta which performs the query and up again to the browser.
A pity for mixed contents! I am running lodlive in https mode, the call to regesta is in http mode... and thus blocked by the browser ...
Maybe this beeing a hint for allowing https on regesta resourceProxy server????
I know https is slow, but also the idea to redirect data to a server might be slow ... ;)
Thank you
Regards

labs.regesta.com/resourceProxy is used to fix some issues with the published data, if you look at the output of the call you will see that the response is just a sparql json result
it is used when lodlive doesn't know which is your sparql endpoint or if your publication has some issues  (jsonp, etc.)


[Bug]: is missing in props validation  when wrapped  by Memo

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview

type NavbarSegmentedProps = {
  authRouters: MetaMenuAuthRouteObject[]
  opened: boolean
  setOpened: (opened: boolean) => void
} & Omit<NavbarProps, 'children'>

export const NavbarSegmented: FC<NavbarSegmentedProps> = memo(
  ({ authRouters, opened, setOpened, ...props }) => {

  }
)

24:6   error    'authRouters' is missing in props validation      react/prop-types
24:19  error    'opened' is missing in props validation           react/prop-types
24:27  error    'setOpened' is missing in props validation        react/prop-types
53:46  error    'authRouters.map' is missing in props validation
Expected Behavior
it is ok
eslint-plugin-react version
7.32.2
eslint version
8.30.0
node version
v16.16.0

.eslintrc.json
{
  "env": {
    "browser": true,
    "es2021": true
  },
  "extends": [
    "eslint:recommended",
    "plugin:react/recommended",
    "plugin:@typescript-eslint/recommended",
    "plugin:react-hooks/recommended"
  ],
  "overrides": [],
  "parser": "@typescript-eslint/parser",
  "parserOptions": {
    "ecmaVersion": "latest",
    "sourceType": "module"
  },
  "plugins": [
    "react",
    "react-refresh",
    "@typescript-eslint",
    "@tanstack/query"
  ],
  "settings": {
    "react": {
      "version": "detect"
    }
  },
  "rules": {
    "react/react-in-jsx-scope": "off",
    "react/self-closing-comp": ["error"],
    "quotes": ["error", "single"],
    "semi": ["error", "never"],
    "react/display-name": ["off"],
    "@typescript-eslint/no-explicit-any": "off",
    "@tanstack/query/exhaustive-deps": "error",
    "react-refresh/only-export-components": "warn",
    "curly": ["error", "multi"]
  }
}

same here.

Have you tried like this-

type NavbarSegmentedProps = {
  authRouters: MetaMenuAuthRouteObject[]
  opened: boolean
  setOpened: (opened: boolean) => void
} & Omit<NavbarProps, 'children'>

 const NavbarSegmented: FC<NavbarSegmentedProps> =  ({ authRouters, opened, setOpened, ...props }) => {}

  export default memo(NavbarSegmented)

@Charlygraphy23  second way is ok, but cause new warning  with eslint-plugin-react-refresh
https://github.com/ArnaudBarre/eslint-plugin-react-refresh/issues/6

So name it - components shouldn't be arrow functions.

it works ,  thanks


Adding array values and reinitialising the form causes added fields to disappear

I haven't been able to establish the root cause of this issue and if it is related to initializeState() when using destroyOnUnmount: false as per #430, or if it is more caused by some potentially incorrect behaviour of addField().
Given I initialise my form with
fields: [ 'bar[].deeper' ],
initialValues: {
  bar: [
    { deeper: 'baz' }
  ]
}

When I run
bar.addField();

I get
{
  bar: [
    { deeper: { initial: 'baz', value: 'baz' } },
    { value: undefined }
  ]
}

When I then type in my new deeper field at index 1 I get
{
  bar: [
    { deeper: { initial: 'baz', value: 'baz' } },
    { value: undefined, deeper: { value: 'typed value' } }
  ]
}

Similarly when I run
bar.addField({
  deeper: 'qux'
});

I get
{
  bar: [
    { deeper: { initial: 'baz', value: 'baz' } },
    { value: { deeper: 'qux' } }
  ]
}

The result of this that when I reinitialise the form index 1 of bar is dropped and I only see the correctly formed data:
{
  bar: [
    { deeper: { initial: 'baz', value: 'baz' } }
  ]
}

Thanks again, let me know if you need any further detail.

Yep this has been fixed by https://github.com/erikras/redux-form/releases/tag/v4.1.0. Thank you very much :)


Cannot resolve modules fs, net and tls

If I try to connect to a database Webpack throws this:
ERROR in ./~/mysql/lib/Connection.js
Module not found: Error: Cannot resolve module 'net' in C:\Wamp64\www\react\node_modules\mysql\lib
 @ ./~/mysql/lib/Connection.js 2:23-37

ERROR in ./~/mysql/lib/Connection.js
Module not found: Error: Cannot resolve module 'tls' in C:\Wamp64\www\react\node_modules\mysql\lib
 @ ./~/mysql/lib/Connection.js 3:23-37

ERROR in ./~/mysql/lib/protocol/sequences/Query.js
Module not found: Error: Cannot resolve module 'fs' in C:\Wamp64\www\react\node_modules\mysql\lib\protocol\sequences
 @ ./~/mysql/lib/protocol/sequences/Query.js 6:19-32

I don't know if this is an error my mysql or if it is caused by webpack or nodejs (I cannot load the module even if I write var x = require("fs"); outside the mysql function (anywhere in my code))
My webpack.config.js:
module.exports = {
    entry: "./src/App.js",
    output: {
        path: __dirname,
        filename: "app.js"
    },
    module: {
        loaders: [{
            test: /\.jsx?$/,
            exclude: /node_modules/,
            loader: "babel",
            query: {
                presets: ["es2015", "react"]
            }
        }]
    }
};

And my package.json:
{
  "name": "react",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
      "babel-core": "^6.7.*",
      "babel-loader": "^6.2.*",
      "babel-preset-es2015": "^6.18.*",
      "babel-preset-react": "^6.16.*",
      "webpack": "^1.13.*",
      "webpack-dev-server": "^1.16.*"
  },
  "dependencies": {
      "react": "^15.3.*",
      "react-dom": "^15.3.*",
      "mysql": "^2.12.*",
      "express": "^4.14.*"
  }
}

My Code (just the mysql function):
var mysql = require("mysql");
var user = this.refs.username.value;
var password = this.refs.password.value;
var sqlCommand = "SELECT * FROM users WHERE user = '".concat(username, "' AND pass = '", password, "'");
//console.log(user + " - " + password);

var connection = mysql.createConnection({
    host: "localhost",
    user: "root",
    password: "",
    database: "lg"
});
connection.connect();
connection.query(sqlCommand, function(err, rows, fields){
    if(!err){
    console.log(rows);
    console.log(fields);
    }else{
        console.log("Error while querying: ".concat(err));
    }
});
connection.end();

I'm not sure if this module can be used with webpack? I'm not very familiar, and have just never used webpack. Any hints / PRs you can make would help out a lot :) !

i'm having the exact same issue. Also using webpack. I've tried older versions of the package and it's still the same problem. Where are the 'net', 'tls' and 'fs' modules supposed to be? Cause they dont seem to be in my node_modules/mysql folder.
Any info you need to help sort this out, i'm here.
Here's a pastebin of my console logs http://pastebin.com/M7AcvVEX.
It appears it's searching for the modules on the node_modules and the mysql/node_modules folders, and the files are not there.

Are you doing client or server webpack? If server this might help http://jlongster.com/Backend-Apps-with-Webpack--Part-I

Where are the 'net', 'tls' and 'fs' modules supposed to be?

They are built directly into Node.js itself.

The true solution to this seems to be to add target: 'node' to your module.exports object in webpack.config.js. At least, that was the solution for me.

if i add target: 'node' to module.exports it return another bug: ReferenceError: require is not defined

Fixed this by adding
node: {
    fs: 'empty',
    net: 'empty',
    tls: 'empty',
  },

to webpack config, but Idk why it does that yet...

Where are the 'net', 'tls' and 'fs' modules supposed to be?

They are built directly into Node.js itself.

@dougwilson as someone who's new to webpack and node, what does your answer imply? I'm still not sure how we are supposed to get the build to work.

I've never worked on the frontend and I just don't have an answer. If someone can help provide an answer, I'd be happy to relay.

ok gotcha sorry i thought you closed this issue bc there was a known solution.
I tried @tanohzana's solution but then when my script loads, I'm unable to call any of mysql's functions (createConnection, query, etc..).
I tried target: node but then I ran into ReferenceError: require is not defined. I wasn't expecting that to work though since my target is not node.

I mainly close this because this issue gets opened periodically and I have not seen any solution that works. Without a path forward, the issue is just noise. If someone can provide what the path forward is, I can always reopen this or any of the other issues for this. As of now, we don't support what you're trying to do since we don't know how to support it. Just Node.js is supported until someone contributes a web browser solution.

I'm working on something unrelated to this mysql project but came across this same issue when attempting to use nodemailer. It looks like it may be a bug in webpack: https://github.com/webpack-contrib/css-loader/issues/447

I'm still facing the same issue.
I'm adding it to an Ionic project and when attempting to run it, I've the following error:
[ng] ERROR in ./node_modules/mysql/lib/Connection.js [ng] Module not found: Error: Can't resolve 'crypto' in '/Users/flavio/quizAdmin/node_modules/mysql/lib' [ng] ERROR in ./node_modules/mysql/lib/protocol/Auth.js [ng] Module not found: Error: Can't resolve 'crypto' in '/Users/flavio/quizAdmin/node_modules/mysql/lib/protocol' [ng] ERROR in ./node_modules/mysql/lib/protocol/sequences/Query.js [ng] Module not found: Error: Can't resolve 'fs' in '/Users/flavio/quizAdmin/node_modules/mysql/lib/protocol/sequences' [ng] ERROR in ./node_modules/mysql/lib/Connection.js [ng] Module not found: Error: Can't resolve 'net' in '/Users/flavio/quizAdmin/node_modules/mysql/lib' [ng] ERROR in ./node_modules/mysql/lib/protocol/Protocol.js [ng] Module not found: Error: Can't resolve 'stream' in '/Users/flavio/quizAdmin/node_modules/mysql/lib/protocol' [ng] ERROR in ./node_modules/mysql/lib/protocol/Timer.js [ng] Module not found: Error: Can't resolve 'timers' in '/Users/flavio/quizAdmin/node_modules/mysql/lib/protocol' [ng] ERROR in ./node_modules/mysql/lib/Connection.js [ng] Module not found: Error: Can't resolve 'tls' in '/Users/flavio/quizAdmin/node_modules/mysql/lib'
Any idea how to fix it?

No. https://github.com/mysqljs/mysql/issues/1563#issuecomment-435971206

This is not an mysqljs-issue.
These errors occur mainly due to webpack not being configured properly for backend-usage.
After superficially reading some "webpack and node.js" stuff via google and stackoverflow,
I suggest putting mysqljs in the externals section of the backend-config.


Possible memory leak in v0.15.1?

Hi all
First, thanks for the application, helped already a lot to keep node processes running.
I have found a warning about a possible memory leak and the according trace in my forever log file. It seems for me, that the cause is in forever code. If files change, normally I observe the "restarting script because change changed" entry followed by two other lines. Before the warning popped up, the "restarting script because change changed" was reported 10 times in sequence without the other log lines. Unfortunately, I had not yet enabled the time stamps in the forever logs...
I use v.0.15.1 and start the node application as follows:
forever -a -l "$logDir/forever.log" -w --watchIgnore "*.pyc" start server.js

forever log with warning and trace:
error: restarting script because change changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #4
error: restarting script because change changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #5
error: restarting script because change changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #6
error: restarting script because change changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #7
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because change changed
(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at ChildProcess.EventEmitter.addListener (events.js:160:15)
    at ChildProcess.EventEmitter.once (events.js:185:8)
    at Monitor.kill (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:381:11)
    at Monitor.restart (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/monitor.js:332:12)
    at EventEmitter.<anonymous> (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/lib/forever-monitor/plugins/watch.js:77:15)
    at EventEmitter.emit (events.js:106:17)
    at EventEmitter.<anonymous> (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/node_modules/chokidar/index.js:152:38)
    at EventEmitter.FSWatcher._emit (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/node_modules/chokidar/index.js:179:5)
    at EventEmitter.<anonymous> (/usr/local/lib/node_modules/forever/node_modules/forever-monitor/node_modules/chokidar/lib/nodefs-handler.js:263:16)
    at Object.oncomplete (fs.js:107:15)
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #8
error: restarting script because change changed
error: restarting script because change changed
error: restarting script because add changed
error: restarting script because add changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #9
error: restarting script because add changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #10
error: restarting script because unlink changed
error: Forever detected script was killed by signal: SIGKILL
error: Script restart attempt #11

Anybody else observing the same?
Best, Andi

I'm experiencing the same issue. Were you able to resolve the problem?

No, haven't yet resolved the problem.

Same problem here.

forever should add an option to delay the restart on file change to prevent many restarts when many files change at once.

Hitting this as well now here. Hard to know what changed since I recently moved to a brand new environment and wonder if my local version of foreverjs was different from the one in my last environment.

FWIW my forever.js command runs shelljs to delay restarts on crashes, but there's no way to delay forever.js restarts themselves on watches (they are treated as two different areas of code base if you dig into the source here).
// my-forever-app.js
require('shelljs/global');

setTimeout(function(){
  exec('./my-app', {async:true});
}, 3000);

If you are using shelljs to start your app and haven't disable the log file output, make sure to add /shelljs* to your .foreverignore file.


SaveEditor.exe wont launch

I am unable to launch this program.  Please help.
I have installed https://aka.ms/vs/16/release/vc_redist.x64.exe
I have tried running in compatibility mode and running as admin
Running win10 with all latest drivers
Windows 10 Home
Version    20H2
Installed on    9/10/2020
OS build    19042.867
Experience    Windows Feature Experience Pack 120.2212.551.0

Maybe you have an antivirus that is too careful with raw executables (not signed, no icon, etc..) ?
It could also be about the directory it is in, check that the path doesn't contain weird characters (russian, spanish, korean directory name) since it could be a problem when opening the db/config files (I haven't double checked this part of the code).
Also, have you tried older versions and the pre-release ? In v0.4.6-alpha.3 you'll find a *_Debug.exe version that should pop an error window.
As an advice, don't run things as admin when they do not work. It is unsafe and usually never solves such problem.

I have No AV installed.
The path is
C:\Users\PC\Desktop\CP2077 SE\SaveEditor.exe
tried changing to CP77 root DIR
Tried 4.6 alpha3 and the latest neither work. Literally nothing happens.

Here is a debug version which should popup a message box "startup":
https://github.com/PixelRick/CyberpunkSaveEditor/releases/tag/win10-issue-test
If this box appears then the problem is with the windowing/rendering, otherwise it would be a mystery for me.
Do you have d3d11.dll and D3DCOMPILER_47.dll in your system32 ?

Timeout !


Fixing SEO crawling issues and adding useful markup

I've added missing titles and schema.org markup.

Done @alejofernandez :)
Let me know if you need anything else!

This one is ready to merge, will do it later on today


Rendering Crash when opening a jei tab related to immersive weapons

crash-2023-03-16_20.59.45-client.txt

The 1.18.2 version was built against JEI <IP_ADDRESS>, and you are using a newer version (10.x.x.x) which includes breaking changes, causing IWCB to crash. I no longer support 1.18.2, so you will need to downgrade JEI or not include IWCB.


Please update to 2.13

Thanks for your work on this great plugin! A new release using Google Formatter 2.13 would be appreciated.
Thanks.

We have a PR for this: #114. Hopefully the maintainers have some time to look at it. :pray:

There, release 2.13 should be available on Maven Central soon.


Always getting stats for all my databases

Hello,
I'm doing some tests with your tool, and for now, I have a small problem: I try to get only stats for one database in my server, but I always get stats for all DB. I tried:
pgcluu -o /tmp/report_mathon_143/ /tmp/stat_mathon_dev/ --db-only mathon_143
and
pgcluu_collectd -D -i 10 /tmp/stat_mathon_dev/ --dbname mathon_143
Thkx

Hi,
You are confusing pgcluu_collectd option --dbname with --included-db. The first one is use to set the database to connect using psql and to be able to collect statistics. The second is use to limit the statistics collect to a comma separated list of database name.
So you must run the following commands:
 pgcluu_collectd -D -i 10 /tmp/stat_mathon_dev/ --dbname mathon_143 --included-db=mathon_143

pgcluu -o /tmp/report_mathon_143/ /tmp/stat_mathon_dev/ --db-only mathon_143

Having to different options for the same things (--db-only and --included-db) is historical, sorry for that.
I have updated the pgcluu_collectd usage and documentation about --included-db which has wrongly the description of an --excluded-db instead. This last option does not exists.
Please download last development code and let us know.
Best regards,

Hi,
I just downloaded the actual version of master: I did the install like indicated in the readme file (I have already the old version of pgcluu but I suppose this won't causes problems).
Now when I run:

pgcluu_collectd -D -i 10 /tmp/stat_mathon_dev/ --included-db=mathon_dev

I get:

Global symbol "$db_limit" requires explicit package name at /usr/local/bin/pgcluu_collectd line 1813.
Execution of /usr/local/bin/pgcluu_collectd aborted due to compilation errors.

Sorry, please download again, last commit b886d4a remove some debug garbage.

Now when I ran:

pgcluu -o /tmp/report_gs/ /tmp/stat_gs/ --db-only gs_prod_2015_06_19

I get a lot of warnings:

Use of uninitialized value in concatenation (.) or string at /usr/local/bin/pgcluu line 3316.
Use of uninitialized value in concatenation (.) or string at /usr/local/bin/pgcluu line 3317.

But the report is generated for one database only so it's good for me ;)
Thkx

Could you send me<EMAIL_ADDRESS>your data files, uninitialized value warning should not happen ?

Thanks a lot for your help, last commit ede771d fix this last issue as well as a wrong overall statistics in the main Home report.

 Like time by query?

I should report such information but you need to install pg_stat_statements extension into the pgcluu_collectd connection database.  in your case:
psql mathon_143 -c "CREATE EXTENSION pg_stat_statements"

Or if it  already exists pgcluu_collectd must connect to that database.

Hi again,
I have done like you said:
psql mathon_143 -c "CREATE EXTENSION pg_stat_statements"
Where can I find the list of queries and the details info for each one?
Also, why some stats are showed for some DB and not for others?
Thks

I think pull request #49 might fix this issue.  For each database that have queries in pg_stat_statement you will have a submenu called " Statements statistics" and the top queries for this database. Please update pgcluu code from github it should works now.


What is "rem dry"?

English is not my native language, googling was not really helpful.

rem dry stands for Remaining dry. It's represented in percentages in this library, thus chanceofremdry returns the chance of remaining dry in percentage.

So it means the chance of no rain (at all) but not stated as a negative?

Sounds like it. I might update this library to address further confusion in the future.


Don't generate clients for apis/duck

... they are not real types.
Fixes: https://github.com/knative/pkg/issues/75

/LGTM


NIFI-12596: PutIceberg is missing case-insensitive Record type handling in List and Map types

Summary
NIFI-12596
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

+1 LGTM, tested with and without the PR and verified the correct behavior. Thanks for the fix! Merging to support/nifi-1.x and main


Error on Update and save your “Email for notifications”

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to https://docs.microsoft.com/en-us/users/kobbi/settings
Scroll down to Manage Email Preferences
Click on Save
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Enterprise
Browser Chrome
Version 86.0.4240.75

Additional context
Add any other context about the problem here.

@diogokobbi Please report feedback at https://docs.microsoft.com/en-us/learn/support/troubleshooting#report-feedback


Not an issue, a question / request.

Is it possible to have a number that floats in the middle of the vein box, showing the max ore QL?
and maybe have a true/false toggle in the config file for it.

It will be added.


error status code received from the API v0.0.23

I have a new OCP 4.10.20 cluster, while configuring Group Sync Operator for Authenticating Azure AD, getting this error on sync.
apiVersion: redhatcop.redhat.io/v1alpha1
kind: GroupSync
metadata:
creationTimestamp: '2023-01-14T11:44:40Z'
generation: 1
managedFields:
- apiVersion: redhatcop.redhat.io/v1alpha1
fieldsType: FieldsV1
fieldsV1:
'f:spec':
.: {}
'f:providers': {}
'f:schedule': {}
manager: kubectl-create
operation: Update
time: '2023-01-14T11:44:40Z'
- apiVersion: redhatcop.redhat.io/v1alpha1
fieldsType: FieldsV1
fieldsV1:
'f:status':
.: {}
'f:conditions':
.: {}
'k:{"type":"ReconcileError"}':
.: {}
'f:lastTransitionTime': {}
'f:message': {}
'f:observedGeneration': {}
'f:reason': {}
'f:status': {}
'f:type': {}
manager: manager
operation: Update
subresource: status
time: '2023-01-14T11:44:40Z'
name: azure-groupsync
namespace: group-sync-operator
resourceVersion: '413456'
uid: 8c63bb97-3fe1-4a27-96ff-7200ef10ede7
spec:
providers:
- azure:
credentialsSecret:
key: AZURE_CLIENT_SECRET
kind: Secret
name: azure-group-sync
namespace: group-sync-operator
groups:
- cld-az-ocpvnl-nonprod-sg
name: azure
schedule: '* * * * *'
status:
conditions:
- lastTransitionTime: '2023-01-14T11:50:12Z'
message: error status code received from the API
observedGeneration: 1
reason: LastReconcileCycleFailed
status: 'True'
type: ReconcileError

Can additional logs be added, such as those from the operator?

This is GroupSync instance status
Spec:
Providers:
Azure:
Credentials Secret:
Key:        AZURE_CLIENT_SECRET
Kind:       Secret
Name:       azure-group-sync
Namespace:  group-sync-operator
Groups:
cld-az-ocpvnl-nonprod-sg
Name:    azure
Schedule:  * * * * *
Status:
Conditions:
Last Transition Time:  2023-01-14T12:39:57Z
Message:               error status code received from the API
Observed Generation:   1
Reason:                LastReconcileCycleFailed
Status:                True
Type:                  ReconcileError
Events:
Type     Reason           Age                 From       Message

Warning  ProcessingError  89s (x21 over 56m)  GroupSync  error status code received from the API
will upload other logs related to Operator shortly.

@dbacademy any update?

@sabre1041 We had microsoft and redhat case for this but didnt get any solution. we downgraded to v0.0.20 but till same issue
AME                          DISPLAY               VERSION   REPLACES                      PHASE
group-sync-operator.v0.0.20   Group Sync Operator   0.0.20    group-sync-operator.v0.0.19   Succeeded
NAME                  PACKAGE               SOURCE                CHANNEL
group-sync-operator   group-sync-operator   community-operators   alpha
:~/group-sync$ oc get groupsync
NAME              AGE
azure-groupsync   7m56s
Following is the error into the status
Status:
Conditions:
Last Transition Time:  2023-03-08T18:50:39Z
Message:               error status code received from the API
Observed Generation:   1
Reason:                LastReconcileCycleFailed
Status:                True
Type:                  ReconcileError
Events:
Type     Reason           Age                  From       Message

Warning  ProcessingError  3m (x17 over 8m32s)  GroupSync  error status code received from the API

@dbacademy what permissions are associated to the Application ID? Are you using Application level permissions

@sabre1041 we are using Microsoft AD, and service principle we are using have permission as following on Microsoft Graph API.
Application.ReadWrite.All
Directory.AccessAsUser.All
Directory.Read.All
Group.Read.All
GroupMember.Read.All
User.Read
User.Read.All

Hi @sabre1041  ; sorry. I forgot to update the status, The issue was resolved. Yes App ID we are using do not have Application level permission rather it had Delegated permission. I added Application level permission for following and it worked.
Directory.Read.All
Group.Read.All
User.Read.All


Restructure and improve docs around txacme use.

In particular, improve the clarity of the server endpoint string
documentation.

This change is

Reviewed 2 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

docs/using.rst, line 4 [r1] (raw file):

============

There are several possible ways to make use of txacme, from a simple endpoint.

"from a simple endpoint" doesn't seem to make sense as an ending to this sentence. I think you have some missing or incorrect words here, can't tell which.

docs/using.rst, line 15 [r1] (raw file):

to store certificates in, and the underlying endpoint to listen on. One might
use the following command to start a Twisted web server on TCP port 443 and
store certificates in the `/srv/www/certs` directory:

You need double backquotes here (single backquotes get you a reference).

docs/using.rst, line 88 [r1] (raw file):

The `.ICertificateStore` and `.IResponder` interfaces are the main extension
points for using the issuing service directly. For example, a custom
implementation might manage the certificate configuration of a cloud load

I know this is my wording originally, but how about expanding this to "a custom implementation of .ICertificateStore" since it seems a bit unclear?

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

Comments from Reviewable

Current coverage is 99.93% (diff: 100%)

Merging #48 into master will not change coverage

@@             master        #48   diff @@
==========================================
  Files            20         20
  Lines          1535       1535
  Methods           0          0
  Messages          0          0
  Branches        139        139
==========================================
  Hits           1534       1534
  Misses            1          1
  Partials          0          0

Powered by Codecov. Last update 37c7c73...9fb9a47

Review status: 1 of 2 files reviewed at latest revision, 3 unresolved discussions, some commit checks broke.

docs/using.rst, line 4 [r1] (raw file):
Previously, mithrandi (Tristan Seligmann) wrote…
> "from a simple endpoint" doesn't seem to make sense as an ending to this sentence. I think you have some missing or incorrect words here, can't tell which.

Sorry, I started writing this and forgot to finish it. It's done now. The thinking here was to give a brief overview (even though there's a bit of duplication in the specialised sections) of the possible ways to use txacme.

docs/using.rst, line 15 [r1] (raw file):
Previously, mithrandi (Tristan Seligmann) wrote…
> You need double backquotes here (single backquotes get you a reference).

Done.

docs/using.rst, line 88 [r1] (raw file):
Previously, mithrandi (Tristan Seligmann) wrote…
> I know this is my wording originally, but how about expanding this to "a custom implementation of `.ICertificateStore`" since it seems a bit unclear?

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Converting YAML doc with date types to JSON creates invalid JSON doc

Microsoft.OpenApi version 1.1.0 -
I'm pulling in a YAML OpenApi doc with the following property in a schema:
orderedOn:
    type: string
    description: The date the order was submitted.
    format: date
    readOnly: true
    example: "2018-01-23"

When using the serializer  (doc.Serialize(ms, openApiVersion, format);, where ms is a MemoryStream, openApiVersion is OpenApiSpecVersion.OpenApi3_0, and format is OpenApiFormat.Json, the JSON output is:
"orderedOn": {
    "type": "string",
    "description": "The date the order was submitted.",
    "format": "date",
    "readOnly": true,
    "example": 2018-01-23T00:00:00.0000000-05:00
}

which is invalid JSON (the date is not properly quoted)

This is fixed in #322. We will release a patch version by next week.

Thank you, I'll close this then.


Update README.md to add build instructions

Added a copy-able bash script to clone & build IREE. Also added link to iree.dev website for more detailed instructions.

fixes #16263


Elmah YSOD: The given assembly name or codebase was invalid (Exception from HRESULT: 0x80131074)

Hi there,
I'm running Elmah with packages from Nuget in an ASP.NET MVC app targeting .NET 4.6.2

elmah v1.2.2
Elmah.Contrib.WebApi v<IP_ADDRESS>
elmah.corelibrary v1.2.2

When I navigate to ~/elmah.axd I encounter a YSOD (yellow screen of death) instead of the usual elmah page loading:
Server Error in '/' Application.
The given assembly name or codebase was invalid. (Exception from HRESULT: 0x80131047)
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.IO.FileLoadException: The given assembly name or codebase was invalid. (Exception from HRESULT: 0x80131047)

Source Error:

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:

[FileLoadException: The given assembly name or codebase was invalid. (Exception from HRESULT: 0x80131047)]
   System.RuntimeTypeHandle.GetTypeByName(String name, Boolean throwOnError, Boolean ignoreCase, Boolean reflectionOnly, StackCrawlMarkHandle stackMark, IntPtr pPrivHostBinder, Boolean loadTypeFromPartialName, ObjectHandleOnStack type) +0
   System.RuntimeTypeHandle.GetTypeByName(String name, Boolean throwOnError, Boolean ignoreCase, Boolean reflectionOnly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean loadTypeFromPartialName) +70
   System.RuntimeType.GetType(String typeName, Boolean throwOnError, Boolean ignoreCase, Boolean reflectionOnly, StackCrawlMark& stackMark) +40
   System.Type.GetType(String typeName, Boolean throwOnError) +34
   Elmah.SimpleServiceProviderFactory.CreateFromConfigSection(String sectionName) +162
   Elmah.ErrorLog.GetDefaultImpl(HttpContext context) +134
   Elmah.ServiceContainer.GetService(Type serviceType) +49
   Elmah.ServiceCenter.FindService(Object context, Type serviceType) +25
   Elmah.ServiceCenter.GetService(Object context, Type serviceType) +31
   Elmah.ErrorLog.GetDefault(HttpContext context) +22
   Elmah.ErrorPageBase.get_ErrorLog() +32
   Elmah.ErrorLogPage.OnLoad(EventArgs e) +308
   System.Web.UI.Control.LoadRecursive() +130
   System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +2839

Version Information: Microsoft .NET Framework Version:4.0.30319; ASP.NET Version:4.7.2633.0

It's working in our master branch of our project, but my branch (where I've been updating Nuget packages) is running into issues. I've confirmed:

Web.config, and the csproj file entries for Elmah are exactly the same as the master branch
the csproj references to the DLL's match up properly
the dll's exist on disk and are making it to the proper bin folder for the project

Any ideas how I can solve this?
Best,
Chris

Assembly Binding Log Viewer is a good tool to use for troubleshooting assembly load and binding issues. If you can run under a debugger and inspect the FileLoadException.FileName property of the exception that it can provide pointers to the offending library. Usually, these kinds of problems are also caused by bit-ness mismatch the library being loaded and the hosting process. In the past, I've seen people get into this sort of trouble by using the wrong 32-bit versus 64-bit version of the SQLite library.

Thank you for responding so quickly!!
Interesting; I'll take a look at the log viewer. We're running a full SQL server with our projects set to compile as Any CPU with dev on x64 Windows 10 and hosting on x64 Server 2016.
I think the issue is that I'm trying to add Stackify (nuget packages: StackifyLib and StackifyLib.Elmah). When I revert to a clean branch of Master and only install those I run into these errors.
Here's what I've got in my web.config (might be something misconfigured?)
Inside of

Inside of

Inside of

Inside of

Does that all look okay?

I don't know anything about StackifyLib and StackifyLib.Elmah so can't comment about that. The assembly name in the type attribute of the <errorLog> element seems suspicious and malformed so I'd start there. It would coincide with the error message that the given assembly name or codebase was invalid.

Confirmed it's definitely that line; I commented out the malformed line and replaced it with what we had and Elmah loads fine. I'll follow up with their team to figure out what it should be.
  <elmah>
    <!--<errorLog type="Elmah.SqlErrorLog, Elmah, StackifyLib.ELMAH.StackifyErrorLog, StackifyLib.ELMAH" connectionStringName="ErrorLoggingDbDSN" />-->
        <errorLog type="Elmah.SqlErrorLog, Elmah" connectionStringName="ErrorLoggingDbDSN" />
    <security allowRemoteAccess="true" />
  </elmah>

Thank you for all the help! If I do get a solution, I'll post it back here for future reference if anyone stumbles across this.

In case anyone runs across this; we enabled Elmah to work with Stackify (and retain access to ~/Elmah.axd) with the following:
In our App_Start we’ve got a Global.cs class and we’re using this:
        /// <summary>
        /// This is an application hook that elmah calls when it logs an error.
        /// We tie into this hook to also send the error our stackify retrace program
        /// </summary>
        /// <param name="sender">not used</param>
        /// <param name="args">An elmah event that contains the exception that was thrown</param>
        protected void ErrorLog_Logged(object sender, ErrorLoggedEventArgs args)
        {
            StackifyLib.Logger.QueueException(args.Entry.Error.Exception);
        }

In web.config:
  <elmah>
    <errorLog type="Elmah.SqlErrorLog, Elmah" connectionStringName="ErrorLoggingDbDSN" />
    <security allowRemoteAccess="true" />
  </elmah>

And any custom exceptions we were handling from other libraries, etc. we updated our elmah calls from:
Elmah.ErrorLog.GetDefault(HttpContext.Current).Log(new Elmah.Error(ex));
to this:
Elmah.ErrorSignal.FromCurrentContext().Raise(ex);
This probably isn't necessary but is the nicer way to do it as of Elmah 1.2

@cvocvo Thanks for dropping in with notes on what worked for you. I'm sure it'll help out someone someday.


Upgrade jQuery

The current version of jquery has security vulnability.
Change package.json to the following
jquery ~> 3.0.0

Fixed at https://github.com/makoto/blockparty/pull/109


Add configurable table names

This pull request adds configurable table names to the config file. Created because I needed to move the tables to a different schema and wasn't sure how to override the package model's getTable methods.
For each config usage I set a default of the original table name, therefore this change should be backwards compatible even if the end user already published an older version of the config.

Heya, thanks for your PR. However, this is already possible. You can publish the migrations:
https://github.com/lmsqueezy/laravel/blob/main/src/LemonSqueezyServiceProvider.php#L62-L64
Then override the models by extending them with your own and adjusting the table name:
https://github.com/lmsqueezy/laravel/blob/main/src/LemonSqueezy.php#L111

Perfect thanks! Looks like you'd use the useCustomerModel/useOrderModel in your app service provider the same way you'd use ignoreMigrations.


Support for embedding images & Horizontal lines

This is an excellent editor and I would readily drop the old Plus Editor for this if it had support for image embedding and Horizontal lines.
Those are basically also the only elements of basic markdown syntax missing.
But overall, well done and will continue to watch this project with interest.

Thanks for the suggestion. It turned out to easy to add, and I just deployed the changes.


[Spec][Show Card] Revisit popup show card support

Details
Current behavior for hosts setting show card mode to popup is not well tested. Additionally, new input validation features do not work well across popup show cards. As we are not aware of any hosts using popup show cards, we should revisit whether support of popup show cards continues to make sense, and whether we want to invest in improving these scenarios or consider deprecating this support.

@JeanRoca Please follow up with @matthidinger to discuss deprecating popup show cards.


PSCommandNotFoundSuggestion stops working if unknown command is too long

Steps to reproduce
abcdefg
abcdefgh
abcdefg

Expected behavior
It should show a suggestion after all three commands above
Actual behavior
The suggestion is only shown after the first unknown command
PS C:\> abcdefg
abcdefg : The term 'abcdefg' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ abcdefg
+ ~~~~~~~
+ CategoryInfo          : ObjectNotFound: (abcdefg:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

Suggestion [4,General]: The most similar commands are: cd, del, ac, clear, diff, cd.., cd\, alg.exe, at.exe, calc.exe.
PS C:\> abcdefgh
abcdefgh : The term 'abcdefgh' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ abcdefgh
+ ~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (abcdefgh:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

PS C:\> abcdefg
abcdefg : The term 'abcdefg' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ abcdefg
+ ~~~~~~~
+ CategoryInfo          : ObjectNotFound: (abcdefg:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

PS C:\>

Environment data
Name                           Value
----                           -----
PSVersion                      7.0.0-preview.4
PSEdition                      Core
GitCommitId                    7.0.0-preview.4
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This happens only if the commands are is copy pasted together to console.

This happens only if the commands are copy pasted together to console.

You don't need to copy and paste the commands to repro this.

Can you elaborate on how you executed those invalid expressions. When I execute it one by one or with semicolons in a line, I get suggestions for all.

Did you try typing them in? Did you try longer strings?

7 chars: abcdefg works, abcdefgh doesn't
6 chars: aaaaaa works, aaaaaaa doesn't

I debugged it and stopped when an ArgumentNullException was thrown and found this script block on the stack. Looks like Get-Command $lastError... returns null.
https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/hostifaces/HostUtilities.cs#L68-L73

Interesting, as you mentioned it fails for long strings but not all long strings. I think its not finding a match for those string, hence nothing is printed.
Cc: @SteveL-MSFT

Nothing is printed because of the exception, it returns an empty string and gets disabled.
https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/hostifaces/HostUtilities.cs#L513-L517

The current "suggestion framework" is pretty primitive.  We have an open issue to fix this so that suggestions are part of ErrorRecords rather than scrub later.  In this case, it seems that line 72 should check if anything was returned.  Since the current algorithm uses fuzzy matching, repro depends on what is on your system and what results get returned from the fuzzy matching.  It seems reasonable that after a certain length of characters, it wouldn't actually match anything reasonable on your system.

I have a mostly-working WIP implementation of Suggestions-on-ErrorRecord over in #9115
It's largely functional, just stuck on some test failures. If there's interesting in having that available for PS7 I can look at bumping it up my priority list. Might need a hand with some of the odder failures that are cropping up, though. 🙂


API phase 11: cleanup old API and protoc code

Motivation
See #1764
Closes #2077, Closes #2078, Closes #2153, Closes #411, Closes #2163, Closes #2145
Changes

Removes old GRPC API and HTTP-JSON gateway code
Removes protobuf code
Updates tests to use new API
Lots of cleanup of the system tests

Test Plan
No new tests required, this does not add any new functionality. Affected tests are updated/removed.
TODO

[x] Remove old API code
[x] Update tests to use new API instead
[x] Remove all protobuf-related code and references
[x] Update README
[x] Update to API v1.0.0, adding GatewayService to new API for poet (#2133)
[x] Implement GatewayService (#2156)
[x] Update poet (https://github.com/spacemeshos/poet/issues/98)
[x] Fix p2p tests broadcast issue
[x] Update hardcoded go-spacemesh docker images in configs
[x] Open issue to replace all curl/json http gateway server API interactions in tests with python grpc library (#2185)
[x] Update system tests (including tx_generator WalletAPI, test_p2p) to use new API
[x] Make sure spacecraft has been updated to factor in new ports and commandline flags (https://github.com/spacemeshos/spacecraft/issues/1)
[x] Update hardcoded poet docker image spacemeshos/poet:develop, fix in configs (needs https://github.com/spacemeshos/poet/pull/105)
[x] Merge #2157
[x] Merge #2159
[x] Merge #2169

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

This is basically done, and all system tests are now passing for me locally. It's blocking on the following things in roughly the following order:

#2157 needs to be reviewed and merged (@y0sher, @antonlerner 🙏)
#2159 needs to be reviewed and merged (@y0sher, @antonlerner 🙏)
the PRs I opened against poet need to be reviewed and merged, most crucially, https://github.com/spacemeshos/poet/pull/105 (@moshababo 🙏)
once that's done, need to fix hardcoded poet docker image here
need to discuss #2168 and resolve that

Then this is good to go.

bors try

bors try-

bors try

could you remove the print that says not reporting status update as no one is listening please?

could you also remove the print that says not reporting status update as no one is listening please?

I'll change this from INFO to DEBUG, does that make sense? It's sort of useful as a debug message so that you know why not everything is being reported, also because of #2085

bors try

bors try-

bors try

bors merge

bors merge

bors merge


[BEAM-9577] Migrate PortablePipelineJarCreator to new artifact service.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @ibzib

Run Java PreCommit

Run Java PreCommit

First there were some (unrelated) flakes, now somthing odd happened with the worker. Trying again.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

sdks:java:io:rabbitmq:test timed out

Run Java PreCommit


SU(n) decomposition

Context:
The paper "Simple factorization of unitary transformations" proposes a factorization scheme that decomposes elements of SU(n) as a sequence of SU(2) transformations. This sequence of SU(2) transformations can then be mapped to an operation  on optical modes including two phase plates and one beam splitter.
Code in this PR is based on Olivia di Matteo's @glassnotes CASPAR implementation.
Description of the Change:
This PR implements a new decomposition for unitary matrices U passed to ops.Interferometer by expressing them as U = det(U) S and then applying the decomposition here referenced to S.
The result is a circuit containing a Rgate on each mode (related to the determinant of the unitary U) in addition to the recursive decomposition of the operation.

Decomposition of an unitary from U(4).
Benefits:
This PR implements the factorization above mentioned, hence making all the known (to date) unitary factorizations available on strawberry fields.
Possible Drawbacks:
None
Related GitHub Issues:
None

@sduquemesa this is very exciting! :tada: Happy to review if you need an extra pair of eyes.

Almost there @sduquemesa : https://app.codecov.io/gh/XanaduAI/strawberryfields/compare/665/diff I think what is needed is to also permute the rows of the unitary...

@sduquemesa : the changes in this PR were not updated in the CHANGELOG file. Worth adding them!


Bluetooth: Mesh: Prevent CDB reusing address of deleted nodes

According to MshPRFv1.0.1, section 3.10.7, the Provisioner shall only
use reuse addresses of the deleted nodes after IV Index is updated.
This change prevents CDB reusing addresses of the deleted nodes until IV
Index is updated. Due to a high range of the unicast addresses, CDB only
stores the highest deleted address once a node is deleted. This creates
a limitation where allocating a node with the high primary unicast
address and then deleting it will make CDB skip big range of address
until next IV Index update.

@PavelVPV please rebase

@jhedberg @ludvigsj please re-approve after rebase.

@jhedberg could you please re-approve?


[needs triage] [1.5] Refcount leak in lbmap backends during restore

I noticed that when we restore services, we don't increment the refcount for the backed in lbmapCache.addBackedIDs. The callchain is:
daemon/daemon.go:NewDaemon
daemon/loadbalancer.go:restoreServices
lbmap.AddBackedIDsToCache
lbmapCache.addBackedIDs
Later in daemon/loadbalancer.go:restoreServices we call lbmap.UpdateService and that calls  lbmapCache.prepareUpdate[https://github.com/cilium/cilium/blob/master/pkg/maps/lbmap/bpfservice.go#L251]. In lbmapCache.prepareUpdate we remove deleted backends that are no longer used. Note that we check if count == 1 to do this.
If we restore services & backends, and then add and remove other services that use these backends, would we end up with a refcount 1 less than it should be, and would delete the restored backends too early?
@brb I assigned to you only so you see it. I have no proof this is happening.

@raybejjani we have been tracking something related with this for the last week. Do you have any debug logs? @brb wants debug logs badly.

Thanks! I'm triaging it.

@aanm alas, no, I was looking at all this code because we were tracking this. :/

I think this issue is invalid, as lbmapCache.addBackendIDs() populates only lbmap.backendIDByAddr, and any to-be restored service goes through lbmap.UpdateService which does the refcounting of backends:
$ cilium service update --frontend '<IP_ADDRESS>:6666' --backends '<IP_ADDRESS>:80,<IP_ADDRESS>:80' --id 1234
Creating new service with id '1234'
Added service with 2 backends

# <-- restart cilium -->

$ cilium service update --frontend '<IP_ADDRESS>:6666' --backends '<IP_ADDRESS>:80,<IP_ADDRESS>:80' --id 1235
Creating new service with id '1235'
Added service with 2 backends

$ cilium service delete 1235
Service 1235 deleted successfully
$ sudo cilium bpf lb list # <-- checks whether backend exists in the cilium_lb4_backends map; reports "backend $ID not found" if it doesn't.

SERVICE ADDRESS   BACKEND ADDRESS
<IP_ADDRESS>:6666      <IP_ADDRESS>:80 (1234)
                  <IP_ADDRESS>:80 (1234)
                  <IP_ADDRESS>:0 (1234)


Cannot read properties of undefined (reading 'backdrop')

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
I get an error in the console using WebPack & Bootstrap 5.2
bootstrap.esm.js:3318 Uncaught TypeError: Cannot read properties of undefined (reading 'backdrop')
    at Offcanvas._initializeBackDrop (bootstrap.esm.js:3318:1)
    at new Offcanvas (bootstrap.esm.js:3192:1)
    at HTMLDocument.<anonymous> (scroll-to-anchor.js:7:25)

first error says
const isVisible = Boolean(this._config.backdrop);
second one
this._backdrop = this._initializeBackDrop();
third one
const bsOffcanvas = new Offcanvas('myOffcanvas');
I tried to simulate it in Codepen but it is without any error. https://codepen.io/5ulo/pen/BarMQBg
Everything is the same.
Reduced test cases
This is in my js
import { Offcanvas } from 'bootstrap';

document.addEventListener('DOMContentLoaded', function () {

    const myOffcanvas = document.getElementById('offcanvas');
    const bsOffcanvas = new Offcanvas('myOffcanvas');

});

Here's Codepen example but shows no errors
https://codepen.io/5ulo/pen/BarMQBg
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.2.0

You have some mistakes in you javascript code
Change to this and you are fine

import { Offcanvas } from 'bootstrap'
document.addEventListener('DOMContentLoaded', function () {
  const bsOffcanvas = new Offcanvas('#offcanvasNav');
});

have same problem and i check my javascript code also it's working fine.
anyone have other solution for this problem

I have the same problem and I initialized via data attribute.
Fixed by adding a bs-target attribute, even though close btn is inside the canvas.
%button.btn-close{"aria-label" => "Close", "data-bs-dismiss" => "offcanvas", type: "button", "data-bs-target" => "#style-sidebar"}

I have the same Problem.
Here is a minimal Example:
https://codepen.io/Benjamin654/pen/KKrERbd
If you use the navbar-toggle button (not the blue one) in breakpoint < sm -> js error
If you open the offscreennavbar with the blue button and try to close it with X -> js error

i had the same problem and as @Swolie  suggested, correct data-bs attributes fixed it

Yep same problem here; attempting to cause bootstrap mobile menu to hide when you click a link on it and I also had to add both
data-bs-toggle="offcanvas" data-bs-target="#offcanvas"
to each a tag.
Thanks for the tip @Swolie you're a star


Introspection endpoint will never be accessed

First, thanks for this interesting addon!
I've tried it, used your example, but the introspection endpoint will never be accessed. That's all:
{"level":"debug","ts":1667069922.8714907,"logger":"http.handlers.oauth2_token_introspection","msg":"authorizing request"}
{"level":"debug","ts":1667069922.8716848,"logger":"http.handlers.oauth2_token_introspection","msg":"getting token from 'Authorization: Bearer' header"}
[Oct 29 18:58:42] error <IP_ADDRESS> test.example.com - "GET /private HTTP/3.0" 401 ["Mozilla/5.0 (Macintosh; Intel Mac OS X ...)]

This is my config for oauth2:
(oauth2_protected) {
	oauth2_token_introspection {
		token_location bearer_token
		introspection_endpoint https://auth.example.com/oauth/v2/introspect
		introspection_authentication_strategy client_credentials
		introspection_client_id my_client_id
		introspection_client_secret my_very_secure_secret
		introspection_timeout 1000
		set_header X-API-GATEWAY-SCOPE scope
		set_header X-API-GATEWAY-SUBJECT sub
		set_header X-API-GATEWAY-EMAIL-ADDRESS email
	}
}

And a backend for testing:
test.example.com:443 {
	import wildcard
	import client_headers
	import log_formatted INFO

	@protected_paths {
		path /private
		path /very-private
	}
	route {
		import oauth2_protected
		reverse_proxy @protected_paths http://<IP_ADDRESS>:2000   # <- there is just a whoami docker image running, showing all headers
	}
}

I'm using Caddy 2.6.2
Am I right, that at least a request must be seen in the logs to https://auth.example.com/oauth/v2/introspect, doesn't matter if it's a valid url or not? But there is no request to auth.example.com.

Hey @helmut72. Your Caddyfile has:
introspection_endpoint https://auth.example.com/oauth/v2/introspect

That can't be the actual introspection endpoint you're using, as that's not a real host. When I use that host I get:
caddy_1  | 1.6670757128949387e+09	error	http.handlers.oauth2_token_introspection	error performing token introspection. Post "https://auth.example.com/oauth/v2/introspect": dial tcp: lookup auth.example.com on <IP_ADDRESS>:53: no such host

So I assume you're using a real introspection endpoint and this was just an example.
Anyhow, can you include the exact request you're making to Caddy, including the headers? I just noticed that when the oauth2_token_introspection config has token_location bearer_token and you don't actually pass a Authorization: Bearer <my token> HTTP header, the caddy-oauth2-token-introspection module will not print out  a debug statement that it can't find the header, it will just return a 401 status code.
Example request:
curl -vv -H "Host: api.myhost.com"  -H "Accept: application/json" -H "Content-Type: application/json" http://localhost:8080/v1/protected-endpoint

*   Trying <IP_ADDRESS>:8080...
* Connected to localhost (<IP_ADDRESS>) port 8080 (#0)
> GET /v1/protected-endpoint HTTP/1.1
> Host: api.myhost.com
> User-Agent: curl/7.79.1
> Accept: application/json
> Content-Type: application/json
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 401 Unauthorized                   <----------- HERE
< Date: Sat, 29 Oct 2022 20:43:58 GMT
< Content-Length: 0
<
* Connection #0 to host localhost left intact

Logs for that request:
caddy_1  | 1.667076238368348e+09	debug	http.handlers.oauth2_token_introspection	authorizing request
caddy_1  | 1.6670762383684053e+09	debug	http.handlers.oauth2_token_introspection	getting token from 'Authorization: Bearer' header

As you can see it doesn't print anything useful that it couldn't find the access token. I will fix this so it prints a debug statement that it couldn't find the access token, but in the mean time, let me know what your request looks like.

So I assume you're using a real introspection endpoint and this was just an example.

Yes, it's just an example. I don't write down any real domains I use.

Anyhow, can you include the exact request you're making to Caddy, including the headers?

Thanks for writing down everything. Now it becomes clearer for me and I'm sure, I have misunderstood oauth2_token_introspection. I have only tried it with a browser, expected to be redirected to the IDP to login to get access to my secured site, sending username, email header.
Caddy includes forward auth module, but this is only supported for a few IDPs Then I thought to use your module. Sorry for the noise.


Used rst inline literal syntax for None in docs.

@jdufresne Thanks :+1: I found two more cases:
https://github.com/django/django/blob/cf2ca22a5797cdd53a10954e9811893325b24a30/docs/ref/models/instances.txt#L565
https://github.com/django/django/blob/cf2ca22a5797cdd53a10954e9811893325b24a30/docs/releases/1.7.txt#L130
Can we fix also QuerySet.none()?
https://github.com/django/django/blob/cf2ca22a5797cdd53a10954e9811893325b24a30/docs/ref/models/querysets.txt#L867-L868

Thanks for finding those additional cases. Fixed in the latest revision.


Running 2017-latest on AKS cluster

Hi, I'm trying to run sql server on AKS cluster (v1.14) on Linux node.
I'm able successfully run server:2017-latest or server:2017-latest-ubuntu on my development machine on latest docker ce. As well as directly on cluster node by using:
sudo docker run -e 'ACCEPT_EULA=Y' -e 'SA_PASSWORD=<YourStrong!Passw0rd>' \
   -p 1433:1433 --name sql1 \
   -d mcr.microsoft.com/mssql/server:2017-latest

But when I try to deploy it on cluster it fails with various errors, for example:
2019-06-06 17:52:14.61 spid6s      Error: 17120, Severity: 16, State: 0.
2019-06-06 17:52:14.61 spid6s      SQL Server could not spawn HADRON Manager thread. Check the SQL Server error log and the operating system error log for information about possible related problems.
2019-06-06 17:52:14.62 spid6s      Startup of Always On Availability Groups replica manager failed due to SQL Server error 17120.  To determine the cause of this error, check the SQL Server error log for the preceding error.
2019-06-06 17:52:14.62 spid9s      Starting up database 'mssqlsystemresource'.
2019-06-06 17:52:14.62 spid6s      Starting up database 'msdb'.
2019-06-06 17:52:14.63 spid9s      The resource database build version is 14.00.3162. This is an informational message only. No user action is required.
2019-06-06 17:52:14.66 spid9s      Starting up database 'model'.
2019-06-06 17:52:14.73 spid10s     A self-generated certificate was successfully loaded for encryption.
2019-06-06 17:52:14.75 spid10s     Server is listening on [ 'any' <ipv6> 1433].
2019-06-06 17:52:14.75 spid10s     Server is listening on [ 'any' <ipv4> 1433].
2019-06-06 17:52:14.98 spid9s      Polybase feature disabled.
2019-06-06 17:52:14.98 spid9s      Clearing tempdb database.
2019-06-06 17:52:15.82 spid9s      Starting up database 'tempdb'.
2019-06-06 17:52:16.16 spid9s      The tempdb database has 1 data file(s).
2019-06-06 17:52:33.24 Server      Software Usage Metrics is disabled.
2019-06-06 17:52:34.04 Server      Failed to verify the Authenticode signature of 'C:\binn\secforwarder.dll'. Signature verification of SQL Server DLLs will be skipped. Genuine copies of SQL Server are signed. Failure to verify the Authenticode signature might indicate that this is not an authentic release of SQL Server. Install a genuine copy of SQL Server or contact customer support.
2019-06-06 17:53:53.28 Server      Server is listening on [ ::1 <ipv6> 1434].
2019-06-06 17:53:53.28 Server      Server is listening on [ <IP_ADDRESS> <ipv4> 1434].
2019-06-06 17:53:53.28 Server      Dedicated admin connection support was established for listening locally on port 1434.
2019-06-06 17:53:53.28 spid10s     Recovery is complete. This is an informational message only. No user action is required.
2019-06-06 17:53:53.28 spid10s     SQL Server is now ready for client connections. This is an informational message; no user action is required.
2019-06-06 17:53:53.31 spid34s     The Service Broker endpoint is in disabled or stopped state.
2019-06-06 17:53:53.34 spid34s     The Database Mirroring endpoint is in disabled or stopped state.
2019-06-06 17:53:53.36 spid34s     Service Broker manager has started.
This program has encountered a fatal error and cannot continue running at Thu Jun  6 17:57:17 2019
The following diagnostic information is available:

       Reason: 0x00000006
      Message: Last Chance
      Address: 0x14c7437d1
   Parameters: 0x51eb0b9b0
   Stack Trace:
               000000006b732f12

I'm using this yaml:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: sqlblank
  labels:
    app: sqlblank
spec:
  replicas: 1
  template:
    metadata:
      name: sqlblank
      labels:
        app: sqlblank
    spec:
      terminationGracePeriodSeconds: 10
      containers:
      - image: mcr.microsoft.com/mssql/server:2017-latest-ubuntu
        name: sqlblank
        ports:
        - containerPort: 1433
        env:
        - name: MSSQL_PID
          value: "Developer"
        - name: ACCEPT_EULA
          value: "Y"
        - name: MSSQL_SA_PASSWORD
          value: "<Password>"
        resources: {}
      restartPolicy: Always
      imagePullSecrets:
        - name: vberegistrysecret
      nodeSelector:
        name: linux1
  selector:
    matchLabels:
      app: sqlblank

I tried different images such as microsoft/mssql-server-linux, server:2019-CTP3.0-ubuntu with the same results. Any ideas what is wrong?

Hi
You could try to check the following cu article
https://support.microsoft.com/en-my/help/4484710/cumulative-update-14-for-sql-server-2017

Hi! I'm running mcr.microsoft.com/mssql/server:2017-latest-ubuntu
which already includes CU15:
> kubectl logs sqlblank-5d5cc56c4-lmrch
2019-06-06 17:52:13.13 Server      Microsoft SQL Server 2017 (RTM-CU15) (KB4498951) - 14.0.3162.1 (X64)
        May 15 2019 19:14:30
        Copyright (C) 2017 Microsoft Corporation
        Developer Edition (64-bit) on Linux (Ubuntu 16.04.6 LTS)

looks the same as https://github.com/microsoft/mssql-docker/issues/441
What Storage was used?


Support KeyVault

https://msdn.microsoft.com/en-us/library/azure/dn903609.aspx

Now need the Swagger file
https://github.com/Azure/azure-rest-api-specs/issues/67