Error in Home Assistant (result["altitude"] = result.pop("alt"))

Hi,
I'm getting the following error in the addon (logfile) when starting:
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
Starting GPSD with device "/dev/ttyACM0"...
Traceback (most recent call last):
File "/gpsd2mqtt.py", line 103, in
Connected to MQTT broker
result["altitude"] = result.pop("alt")
^^^^^^^^^^^^^^^^^
KeyError: 'alt'
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped
Is there a way to debug further?
Stefan

Seems your GPS does not report altitude. I think I can fix that. Could you turn on debug and see if we get a full NMEA JSON output?

Hi,
Enabled debug, didn't a lot of more information:
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
Starting GPSD with device "/dev/ttyACM0"...
These are the options in use.
Serial device: /dev/ttyACM0
Traceback (most recent call last):
File "/gpsd2mqtt.py", line 103, in
Device Baudrate: 9600
MQTT Hostname: core-mosquitto
MQTT TCP Port: 1883
MQTT Username: gpsuser
MQTT Password: XXXXXXXX
Debug enabled: True
Sending CONNECT (u1, p1, wr0, wq0, wf0, c1, k60) client_id=b''
Sending PUBLISH (d0, q0, r0, m1), 'b'homeassistant/device_tracker/gpsd/config'', ... (164 bytes)
Received CONNACK (0, 0)
Connected to MQTT broker
result["altitude"] = result.pop("alt")
^^^^^^^^^^^^^^^^^
KeyError: 'alt'
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped
Stefan

Hi,
I just got an update from HA itself and it seems now it is working... bit weird but debug output of the addon:
Published: {'class': 'TPV', 'device': '/dev/ttyACM0', 'status': 2, 'mode': 3, 'time': '2023-06-07T21:10:24.000Z', 'ept': 0.005, 'altHAE': 98.9, 'altMSL': 52.5, 'epx': 1.803, 'epy': 1.893, 'epv': 5.75, 'magvar': 1.8, 'speed': 0.062, 'climb': 0.2, 'eps': 3.78, 'epc': 11.5, 'geoidSep': 46.4, 'eph': 3.325, 'sep': 5.795, 'altitude': 52.5, 'longitude': X.7244955, 'latitude': X.848089833} to topic: gpsd/attribute
Sending PUBLISH (d0, q0, r0, m492), 'b'gpsd/state'', ... (6 bytes)
Sending PUBLISH (d0, q0, r0, m493), 'b'gpsd/attribute'', ... (374 bytes)
Stefan

The problem was that the first message from the GPS did not send the altitude and since I rename this attribute in the device_tracker the script fails. In v.0.0.108 this is not checked. So if the GPS does not send alt (or lat or lon) the script just continues and does not rewrite. So now it should not fail anymore, even if it does not sent alt etc.
The debug message is basically the JSON coming from the GPS device. That looks just fine :)
I will make some more readme, but one hint of what I did was to create a person (for my boat, that is my use-case) and then added the device tracker "device_tracker.gps_location" to track the location of that person. Then I added a photo for that "person" (boat!) and then added a map. That makes it look a bit cool :)

But sidetrack aside! Upgrade to 0.0.108 to make sure the add-on does not crash when starting.


Don't set -mno-sse / -mno-avx2

On PPC and other architecutres neither -msse nor -mno-sse are supported.
Yet https://github.com/zarr-developers/numcodecs/blob/45a8ef3cea0e49bb29c523b9d897811fcc30949f/setup.py#L25-L32 numcodecs will set -mno-sse / -mno-avx2 on those platforms.
Either make it conditional on have_sse/avx2, or don't set any -mno-* flag at all, why bother?

Thanks for the issue, @haampie. Do you have the feeling that another PR like https://github.com/zarr-developers/numcodecs/pull/483 would achieve what you're looking for?

The script would have to be updated either like:
if have_sse2:
    base_compile_args.append('-mno-sse2' if disable_sse2 else '-msse2')

but I'd be happier if it was just:
if have_sse2 and not disable_sse2:
    base_compiler_flags.append('-msse2')

I don't think I've ever seen a build system that explicitly disabled a certain micro-architecture. Most of the build systems do something like ENABLE_SSE2=1 -> -msse2

Is this issue fixed? I am having problem while building and pushing image to docker hub on (linux/arm64/v8).

it's not

The change described in https://github.com/zarr-developers/numcodecs/issues/486#issuecomment-1786744743 seems reasonable. @haampie, do you think you'd be able to open a pull request with that change?


add instanceID to containerEvents so that we set that field when we correlate an event

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.


Electron Sandbox Workspace Setting

Testing #155827
Sandbox is meant to be a global setting, but when setting it in the workplace settings, it doesn't show that it is not allowed and suggests to restart vscode. When it then restarts, it does not start in sandbox mode (No Sandbox message in DevTools).
I believe that the setting should actually be showing an error when set in the workplace settings (red squiggly line) and should not prompt to restart.

I guess I am missing 'scope': ConfigurationScope.APPLICATION,


New members do not get email to create account

A number of new hires did not get emails to create account so they can receive notifications of appointments.

@grkatsas thanks for the issue request. I'll check on this on the evening. It seems the system is not sending any emails, I think.

@grkatsas as a temporary solution,  you could probably set them their password from the admin panel, if I remember correctly?

@grkatsas OK so this issue does relate to our sass source code - Relevant verification.
Which leads me to believe it has something to do with our server. So I opened a ticket with our server provider. They will respond in the next 24 hours.
In the meantime, we could temporary allow an admin/secreteriat to the set the password for new users?  How does that sound?

Closed by https://github.com/sass-team/sass-app/commit/f3ad63e2553066e601b676cf8370165a86dcd9ec
Our server provider suggests we're find from the server settings.
As such, I just implemented this functionality to use our local mail server instead of the mailgun api.
Please let me know if any issue arises.


Improve whitespace for Parser tests

PR Summary
Initial part of #9792. Splitting this out to simplify review process. 🙂
PR Context
Parser tests are really difficult to read through and work with. We don't need to edit them a lot, but when we do it tends to be a test of patience, and we can make it less of a hassle.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

@vexx32, your last commit had 4 failures in PowerShell-CI-windows
Error occurred in test script 'D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1'
At D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, D:\a\1\s\src\powershell-win-core\bin\Release\netcoreapp3.0\win7-x64\publish\Modules\Pester\4.8.0\Pester.psm1: line 1097

Error occurred in test script 'D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1'
At D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, D:\a\1\s\src\powershell-win-core\bin\Release\netcoreapp3.0\win7-x64\publish\Modules\Pester\4.8.0\Pester.psm1: line 1097

Error occurred in test script 'D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1'
At D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, D:\a\1\s\src\powershell-win-core\bin\Release\netcoreapp3.0\win7-x64\publish\Modules\Pester\4.8.0\Pester.psm1: line 1097

Error occurred in test script 'D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1'
At D:\a\1\s\test\powershell\Language\Parser\Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, D:\a\1\s\src\powershell-win-core\bin\Release\netcoreapp3.0\win7-x64\publish\Modules\Pester\4.8.0\Pester.psm1: line 1097

@vexx32, your last commit had 4 failures in PowerShell-CI-macos
Error occurred in test script '/Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1'
At /Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, /Users/vsts/agent/2.150.3/work/1/a/bins/publish/Modules/Pester/4.8.0/Pester.psm1: line 1097

Error occurred in test script '/Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1'
At /Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, /Users/vsts/agent/2.150.3/work/1/a/bins/publish/Modules/Pester/4.8.0/Pester.psm1: line 1097

Error occurred in test script '/Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1'
At /Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, /Users/vsts/agent/2.150.3/work/1/a/bins/publish/Modules/Pester/4.8.0/Pester.psm1: line 1097

Error occurred in test script '/Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1'
At /Users/vsts/agent/2.150.3/work/1/s/test/powershell/Language/Parser/Parser.Tests.ps1:1143 char:1
+ }
+ ~
Unexpected token '}' in expression or statement.
at <ScriptBlock>, /Users/vsts/agent/2.150.3/work/1/a/bins/publish/Modules/Pester/4.8.0/Pester.psm1: line 1097

Whoopsie, let me double check what I did there...


Custom announcements are impossible

Description
For some reason, a recent update has managed to break the announce and announceui commands. They show as autofill in console, but are not recognized.
Reproduction

Attempt to use announce or announceui, either via console or admin menu
Unrecognized command
Catch fire

Screenshots

Additional context
I have zero idea how this even happened

You need a separate admin access now for this


cmd/go: hangs with ssh timeouts for https-hosted repo

gopls 0.9.1/go 1.18.4
This is not a new issue, but it appears to be a regression not seen in quite some time.
When trying to open a workspace folder containing many references to normally "unresolvable" packages, gopls gets totally stuck and unable to function while also spamming the VS Code status bar with the error message "context deadline exceeded".
The deadline is exceeded because "git ls-remote " is unable to complete (for whatever unrelated reason). In quite a few preceding gopls versions it was not a problem (the "bad" packages will get a red squiggle and everything else just works), but 0.9.1 somehow gets very upset.

Thank you for reporting!

Can you confirm that this is not a problem in v0.8.4 (v0.9.0 is almost the same as v0.9.1).
Can you see if it's an issue in v0.9.2-pre.2 (go install golang.org/x/tools/gopls@v0.9.2-pre.2)? A lot of loading logic has changed, and while I don't yet understand the root cause, we should confirm that it's still a problem.

Generally speaking, our initial go list request should fail, and then gopls should become responsive, albeit with package errors. It's possible that our logic to retry the initial workspace load has regressed. I will look through CLs to try to guess where this may have happened, but more details would be helpful. Do you see any other errors in your logs? If you have a reliable reproducer, would you be willing to help bisect?

It is pretty curious, may be the problem is with some other tool, not gopls.
Basically, I've got an auto-generated package of a form "some.url/repo.git/package/autogenerated". Those used to work until recently with both "gopls" and "go mod tidy -e" (the former adds squiggles, the later reports an error).
Now I can see "go mod tidy" being stuck and the following processes extant:

go mod tidy -e -compat 1.18

git ls-remote git+ssh://some.url/repo

ssh -o ControlMaster=no -o BatchMode=yes -o SendEnv=GIT_PROTOCOL some.url git-upload-pack 'repo'

"some.url/repo.git" is something that actually exists, only the package is auto generated. Yet, it has no ssh support in there, only https.

Does go list ./... get stuck? If it went from returning an error to getting stuck, that would explain the regression. Gopls sets an (IMO extremely generous) timeout of 10m for the initial workspace load. It is hard for us to distinguish between slow network and a hanging process like this.

Upon doing further diagnostics I discovered the situation below (I think "some.url" in my case is hosted on AWS)

ssh some.url
debug2: resolving "some.url" port 22
debug1: Connecting to some.url [addr1] port 22.
debug1: connect to address addr1 port 22: Connection timed out
debug1: Connecting to some.url [addr2] port 22.
debug1: connect to address addr2 port 22: Connection timed out
debug1: Connecting to some.url [addr3] port 22.
ad infinitum, AWS has many addresses in its cloudfront pool

On one hand, now I understand this to not be a problem with go tools, but some funny AWS config, recently implemented.
On the other hand, this may affect any sort of package hosted in a similar AWS setup. I don't have the details for the setup, but I know that the repo is supposed to be served on HTTPS, there's no SSH in there.
So, possibly, go should not wait on ssh to complete before trying https, but either try https first, or try them in parallel.

Thanks for the details.
CC @bcmills to see if there's anything actionable here for cmd/go.

My present work around for the issue was to edit the global .gitconfig as following:
[url "https://some.url"]
        insteadOf = "ssh://some.url"
        insteadOf = "git+ssh://some.url"

Clearly, this is far from perfect, but it gets gopls going. :-)

go shouldn't know anything about ssh, it gives git a repo url with http(s). It sounds like the problem is with your git config, which is the part responsible for rewriting https git urls to use ssh.

My git config, until very recently, was trivially simple. The problem has something to do with this:
https://github.com/golang/go/blob/d922c0a8f5035b0533eb6e912ffd7b85487e3942/src/cmd/go/internal/vcs/vcs.go#L242
Namely, it appears to be trying the protocols from this slice in reverse order.
In general, it's a bad idea to do unsolicited calls on other people ssh ports. To name one example, sshd is often used in combination with fail2ban: the later will add the client IP to the iptables blacklist if too many unsuccessful login attempts. There should be a syntax of some sort, possibly in go.mod, to specify the exact protocol to use with each repo.

I shall also add, that "GIT_ALLOW_PROTOCOL=https" also works for me, owning to #17299. Yet, I do think that ability to specify a specific protocol for each package will be a valuable addition to go tooling. Contemporary internet is not a happy place by any measure, with all the networking malice and security countermeasures going around.

There should be a syntax of some sort, possibly in go.mod, to specify the exact protocol to use with each repo.

There is: the go-import reply from the initial HTTPs fetch can specify a complete URL, including the exact scheme to use.
It is true that we don't have a way to specify the URL scheme when bypassing the go-import protocol by using an explicit .git extension within the import path, but that also doesn't seem to come up very often. 🤔

Yes, and sometimes it's even supported by various vendors (I think gitlab had added some automatic Go friendly redirects into their system). But in a simple case people may want to simply expose some git repo without bothering too much with additional secure http endpoints.
I do appreciate the fact that Go is very open source friendly language trying to encourage people to host their packages openly in public repos. Alas, this world is less than perfect. :-)


Variables docstring intellisense feature

Hi,
I have some class variables with a docstring.
class Variables():
    MY_VAR = "foobar"
    """MY_VAR docstring"""

    YOUR_VAR = 1
    """YOUR_VAR docstring"""

    OUR_VAR = 2.2
    """OUR_VAR docstring"""

Intellisense does not provide those docstrings.
Is there an option to enable displaying variable docstrings.
I'm aware that this is not PEP compliant but sphinx and epydoc support this to allow better documentation.
http://epydoc.sourceforge.net/manual-docstring.html
Thank you

Hi,
I am also looking forward to have a infobox in VSCode, showing the variable documentation. Here is an equivalent example how this looks in PyCharm:

Here the appropriate definition of the variable and its pydoc:

Thanx in advance

I'm going to transfer this as a feature request over to Pylance. MPLS isn't heavily maintained anymore and we aren't adding new features to it, but this is in range of something we could try in Pylance.


(Issue with typescript) TypeError: Converting circular structure to JSON

Describe the bug
If for some reason, you type props as null and return null in render
// Null.tsx
import React from "react";

export default class Null extends React.Component<null> {
   render() {
      return null
   }
}

and then use that component with children (implicitly sets this.props.children):
// index.tsx
import React from 'react';
import ReactDOM from 'react-dom';
import './index.css';
import App from './App';
import reportWebVitals from './reportWebVitals';
import Null from './Null';

ReactDOM.render(
  <React.StrictMode>
    <Null>
      <App />
    </Null>
  </React.StrictMode>,
  document.getElementById('root')
);

// If you want to start measuring performance in your app, pass a function
// to log results (for example: reportWebVitals(console.log))
// or send to an analytics endpoint. Learn more: https://bit.ly/CRA-vitals
reportWebVitals();

the resulting error crashes npm start
Did you try recovering your dependencies?

(Write your answer here.)
my-ts-app-2: npm --version gets 8.1.1
solver: yarn --version gets 3.0.2
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(paste the output of the command here.)
PS C:\Users\Steven\Documents\code\js\sudoku\my-ts-app-2> npx create-react-app --info

Environment Info:

  current version of create-react-app: 5.0.0-next.47+1465357b
  running from C:\Users\Steven\Documents\code\js\sudoku\my-ts-app-2\node_modules\create-react-app

  System:
    OS: Windows 10 10.0.19042
    CPU: (4) x64 Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz
  Binaries:
    Node: 16.11.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 94.0.4606.81
    Edge: Spartan (44.19041.1266.0), Chromium (95.0.1020.30)
    Internet Explorer: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    react-scripts: 5.0.0-next.47 => 5.0.0-next.47+1465357b
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

npx create-react-app@next --scripts-version=@next --template=typescript@next my-ts-app
cd my-ts-app
In the src folder, create Null.tsx as shown above and edit index.tsx as shown above

Expected behavior

(Write what you thought would happen.)
Errors but doesn't crash typescript itself
Actual behavior
I don't think typescript is supposed to crash

(Write what happened. Please add screenshots!)
Before typing props as null

After

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

https://github.com/icecream17/my-ts-app-2/commit/9aa67c5edec3f5c20e1f4eaa5563b2f5d13cb148

probably fixed by https://github.com/microsoft/TypeScript/pull/47604 (haven't checked)


Port the remaining stats sections of the tutorial

Fixes https://github.com/tskit-dev/tutorials/issues/72 but this is a straight port of the text and code without any rearranging, so needs a lot of work (but at least it runs OK).

One question is that the LD calculations are used as an example of running analytical calculations in parallel. Do we want to retina this as the example, or are there better parallel computation examples we could use?

The other (major) question is how we should rearrange / delete / add to the material to get this into a decent shape before merging it. Any comments or help much appreciated. I guess it's probably worth doing in parallel with https://github.com/tskit-dev/tskit/pull/1499

LGTM, but I think we need to make the parallel example much smaller so that it executes in < 1s. Looks like it's timing out here on the build.

Ah, good spot. I wondered what the issue was.


Add a --short flag to kubectl config view

Defaults to false, when enabled, redacts raw data for a shorter,
human-readable view. Useful for inspecting files that have embeded
data. We may actually want to make the default be --short=true, and
disable it for --flatten.
cc @deads2k, @satnam6502

Optional nit, the code lgtm.
@liggitt  Any thoughts on the defaulting.  It'd be nice to be able to read the output by default, but changing the default value of short based on the value of other flags might be confusing.

Rather than having --short which defaults to true, how about --full or --raw or --authinfo which defaults to false? I fell that short is not quite the right words here since what you want to do is to express the idea of just an abstraction or sub-set of the original information being passed through.

You could try going one step further and actually having --redacted that substitutes the certs and replaces the tokens and passwords.  It would be removing two non-secrets as well, but would make it easy for people to shared troublesome kubeconfigs for help.

@deads2k, @liggitt what do you think of Satnam's idea of using --raw for full output, and redacting byte data by default? The other flags (--flatten, --minify, --output) would still output raw byte data, and we can fail the command if users specify incompatible flags (e.g. both --raw=false and --flatten).

@deads2k, PTAL
Changed flag name to --raw, enabled by default, except when --flatten is true. Let me know if you have any objections.

lgtm

Re-running Shippable.

Can haz merge?


Was support for HDFS dropped?

About a year ago when I was last doing distributed XGBoost experiments I was able to build from source with the USE_HDFS=ON option so that I could run distributed training from the cli.
I can't find that option in CMake any more and trying to run XGBoost applications causes errors like
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/hadoop/io/DataOutputBuffer

Is there some process I'm missing to build with HDFS support? Is using Spark the only way to run distributed training now?

The option is in dmlc-core instead of XGBoost,  but since dmlc-core is submodule so it should be effective.  I'm not sure about the error. @CodingCat Is there additional things we need to do in XGBoost for supporting HDFS in XGBoost?

I just verified the USE_HDFS parameter is effective in compilation.

The option is in dmlc-core instead of XGBoost, but since dmlc-core is a submodule so it should be effective. I'm not sure about the error. @CodingCat Is there any additional things we need to do in XGBoost for supporting HDFS?

as far as I know, no,

Let me take a closer look tomorrow.

Possible root cause: https://github.com/dmlc/dmlc-core/pull/262#issuecomment-513555466
Marked as an issue by @hcho3 back in August.

Closing this, the issue being tracked in https://github.com/dmlc/dmlc-core/issues/552


bpdoc improvements

Improve readability in bpdoc by removing naming stutter.
Fixes the documented type for properties stored in pointers, previously printed as "Type: *ast.StarExpr"

LGTM


Can't compile in Tauri on macOS (missing HDF5)

Platform: macOS 14.2 apple silicon
I am trying to use netcdf5 in a Tauri application. I'm starting with the basic print file example but it's running into issues at the build step with the following error:
 Compiling tauri v1.5.4
error: failed to run custom build command for `hdf5-sys v0.8.1`

Caused by:
  process didn't exit successfully: `/Users/nakaj/Documents/sandbox/nc_analyzer/metro_nc/src-tauri/target/debug/build/hdf5-sys-58f0def845f04fb4/build-script-build` (exit status: 101)
  --- stdout
  Attempting to find HDF5 via Homebrew (any version)...

  --- stderr
  thread 'main' panicked at /Users/nakaj/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hdf5-sys-0.8.1/build.rs:548:13:
  Unable to locate HDF5 root directory and/or headers.

I checked home-brew cellar and verified I already have hdf5 v1.14.3 installed.
Even after commenting out all the example code, and only importing the library, the build error persists
Solution
resolved the issue by enabling the "static" feature in the Cargo.toml:
netcdf = { version = "0.8.3", features = ["static"] }

That said, it would be nice to have some detailed instructions or a link to them for those who don't want to use a binary blob.

This is blocked on https://github.com/aldanor/hdf5-rust/issues/262
For reference: The static feature builds from source and is not a binary blob per se :)

Commenting for posterity. Specifying the static feature was the happy path to a successful windows/msvc build for me, and as a rust newb this instruction was not clear to me either.
cargo add netcdf --features static will update your project's Cargo.toml file.
I did not try the conda method but ci.yml shows you which environment variables to set.


expire old s3 access logs

Once https://github.com/byu-oit/terraform-aws-postman-test-lambda/pull/49 goes through, I'll have another PR to apply the log retention to the Postman stuff as well.

Change of plans. I added the Postman logs change to this PR.


should the repository be set to private?

https://github.com/facebook/create-react-app/blob/493a379c21064a32a567b3b3fd13487264f71121/package.json#L2
I don't know a lot about the internals of this project, but is this supposed to be?

It’s a top level package.json that’s only used for shared development dependencies and isn’t supposed to be published to npm. So yes, it’s intentional.
The repository is not private, it’s open source.  If it were private you wouldn’t be able to see it.

The repository is not private, it’s open source.  If it were private you wouldn’t be able to see it.

That's why I asked. Thank you! 👍


How do you use this bundle?

I've created a vite react project and was intented to use this, but I am getting following error:
_bundle.js:640 Uncaught ReferenceError: memoryInitializerPrefixURL is not defined
    at setMemoryInitializerPrefix (_bundle.js:640:9)
    at Object.init (_bundle.js:714:13)
    at node_modules/quietjs-bundle/_bundle.js (_bundle.js:1480:7)
    at __require2 (chunk-OROXOI2D.js?v=a2f26ecc:16:50)
    at node_modules/quietjs-bundle/index.js (index.js:2:22)
    at __require2 (chunk-OROXOI2D.js?v=a2f26ecc:16:50)
    at dep:quietjs-bundle:1:16

import quiet from 'quietjs-bundle';
quiet.setMemoryInitializerPrefix('/');
quiet.addReadyCallback(
	function success() {
		quiet.receiver({
			profile: 'ultrasonic',
			onReceive: console.log,
			onCreate() {
				console.info('Receiver ready');
			},
		});
		quiet
			.transmitter({
				profile: 'ultrasonic',
				onFinish() {
					console.info('Transmission finished');
				},
			})
			.transmit(quiet.str2ab('hello'));
	},
	function error(e) {
		console.error('addReadyCallback reported an error', e);
	},
);

What I am doing wrong here? Thanks a lot @edgarogh

What's this line ? I don't think I export this function anywhere. Everything you have access to is specified in template.index.d.ts.
import quiet from 'quietjs-bundle';
+ quiet.setMemoryInitializerPrefix('/');
quiet.addReadyCallback(
	function success() {
		quiet.receiver({
			profile: 'ultrasonic',
			onReceive: console.log,
			onCreate() {
				console.info('Receiver ready');
			},
		});
		quiet
			.transmitter({
				profile: 'ultrasonic',
				onFinish() {
					console.info('Transmission finished');
				},
			})
			.transmit(quiet.str2ab('hello'));
	},
	function error(e) {
		console.error('addReadyCallback reported an error', e);
	},
);

Does your program work without this line ?
You could also try quiet.Module.setMemoryInitializerPrefix('/'); but I cannot guarantee that it will work and still have no idea of what it's supposed to do.

Thanks for the fast reply, I appreciate it :)
Well, it doesn't work if I do have or not this code. When I put just this in component:
import quiet from 'quietjs-bundle';
the error in console I get is the same:
_bundle.js:640 Uncaught ReferenceError: memoryInitializerPrefixURL is not defined
    at setMemoryInitializerPrefix (_bundle.js:640:9)
    at Object.init (_bundle.js:714:13)
    at node_modules/quietjs-bundle/_bundle.js (_bundle.js:1480:7)
    at __require2 (chunk-OROXOI2D.js?v=b773379f:16:50)
    at node_modules/quietjs-bundle/index.js (index.js:2:22)
    at __require2 (chunk-OROXOI2D.js?v=b773379f:16:50)
    at dep:quietjs-bundle:1:16

What are you compiling the file with ? Parcel ? Browserify ? Webpack ?
As a reminder, quietjs only works in browser environments, in case you were trying to use quietjs-bundle server-side. That's not something I can easily fix.

Yes, I need it only in browser environment.
I'm using vite as a bundler for the app, I believe it uses Parcel under the hood.
Do I have to build something previously in the \node_modules\quietjs-bundle\ folder? Sorry if I missed that, I don't know how/what should be done.

Oh sorry, you told it before but I didn't know Vite was a web bundler. I'll try to reproduce your issue this evening (UTC+2, it's 11:58 currently) when I have my personal computer.

Thank you very much :)

@edgarogh
Jut to be clear: Vite is not imperative, if it works with any other setup, I can use it - this is not the final product, just a proof of concept.
So anything that works is fine.
Thanks again

@edgarogh
So I installed react-create-app, added quietjs-bundle and I am getting following build errors:
Compiled with problems:

ERROR in ./node_modules/quietjs-bundle/_bundle.js 1618:26-39

Module not found: Error: Can't resolve 'fs' in 'C:\Projects\project\node_modules\quietjs-bundle'

ERROR in ./node_modules/quietjs-bundle/_bundle.js 1619:30-45

Module not found: Error: Can't resolve 'path' in 'C:\Projects\project\node_modules\quietjs-bundle'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
	- install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "path": false }

ERROR in ./node_modules/quietjs-bundle/_bundle.js 5513:15-47

Module not found: Error: Can't resolve 'crypto' in 'C:\Projects\project\node_modules\quietjs-bundle'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
	- install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "crypto": false }

but since I've added example code (quiet.addReadyCallback...) I am getting "Receiver ready" in console.
Any idea how to fix this?

Regarding the webpack issue, well, I don't really know webpack. That said, the error logs seem to give you quite a bit of information and advice. quietjs's (the actual library, not my bundle) dependencies uses if conditions to load some modules (crypto, fs, etc.) only if you're running under NodeJS and it looks like webpack isn't able to tree-shake those away, so it wants to include useless polyfills even though the if branch is unreachable.
One solution could be to have quitejs-bundle simply text-replace all occurences of require("fs") and require("crypto") to null, since they will never be called anyways.
Regarding the second issue, it's because web browsers don't want you to play audio without the user's consent, so you must do any audio-related task in a "user gesture" handler (click, key-press, etc.). You can't play audio when the page loads for instance.


Convert doc to nbsphinx

My method is to automate when possible but do it manually when not.

[x] Convert LaTeX to markdown with pandoc: pandoc -f latex -t markdown_github galgebra.tex -o galgebra.md
[x] Manually fix obvious math equations conversion problems
[x] Fix equation numbering and referencing in MathJax (which I have no clue for now)
[x] Convert part of the markdown with python code to notebooks using notedown (tried, but defined new command can't work across cells, possibly add a init_cell?)
[x] Run nbval for these python code in notebooks and add these tests to coverage
[x] Convert to readthedocs using nbsphinx
[x] Publish to readthedocs: https://galgebra.readthedocs.io/en/latest/
[ ] Break into a few small markdown files
[ ] Convert the python code and pdf output referenced in the tex doc to notebooks

Updated TODOs ( Feb 2019) :

[x] Add badges
[x] Clean up doc/
[x] Fix obvious display problems in the current readthedocs documentation ( https://github.com/pygae/galgebra/pull/9#issuecomment-425442908 )
[x] Update installation instructions and remove the old ones
[ ] Add migration guide from brombo/galgebra
[x] Rewrite the intro section of sphinx doc
[x] A feature diff between this fork and the upstream
[x] Add links to generated doc in README (done in the form of badge, but will add one more link after the crash course)
[x] A "quick start" or "crash course" as discussed in https://github.com/pygae/galgebra/pull/9#issuecomment-466016537

Merging #9 into master will increase coverage by 8.63%.
galgebra/ga.py 64.81% <0%> (+2.05%)
galgebra/metric.py 56.54% <0%> (+2.07%)
galgebra/printer.py 40.8% <0%> (+10.5%)
galgebra/lt.py 22.48% <0%> (+11.4%)
galgebra/mv.py 49.8% <0%> (+12.72%)

:v:

The build failure is expected, working on a fix.

The doc is now published to https://galgebra.readthedocs.io/en/latest/index.html using this branch. @arsenovic @hugohadfield

There're some strange difference between local build and readthedocs build:
Local:

readthedocs:

which I have no clue. The .md and .ipynb are fine.

good job with all your work on this.
my only comment is that you  might consider adding a short 'crash course'  or a 'quick intro' eventually. most people have short attention.

dont forget to add link to the docs in the readme.

my only comment is that you might consider adding a short 'crash course' or a 'quick intro' eventually. most people have short attention.

dont forget to add link to the docs in the readme.

ok

The work of original nbsphinx is backed up to nbsphinx_backup using:
git checkout -b nbsphinx_backup nbsphinx
git push --set-upstream origin nbsphinx_backup

And I've reworked on the history of the nbsphinx branch:
# Go back to where the coverage PR has been merged
git reset --hard 21ed56db65fc57cf720cab5f3425a06469eb64e8
# Catch up with master
git pull origin master --ff-only

# A series of cherry-picks and resolve conflicts (almost none)

And then I force-pushed to rewrite the history of nbsphinx so I don't have to open a new PR.

There're some strange difference between local build and readthedocs build

The previous problems are gone.
Here are the problems left:
In Linear Transformations/Outermorphisms:

In Covariant, Contravariant, and Mixed Representations

In Instantiating a Multivector:

In Backward Compatibility Class MV:

In Submanifolds:

And many places like this after "The output of this code is".

@utensil the README is excellent! One small suggestion: I'd have kept the opening line

geometric algebra/calculus modules for sympy

from the original README, or some variation thereof. For example:

Geometric Algebra (GA) and Geometric Calculus (GC) for SymPy

Ideally, the repository description

Symbolic Geometric Calculus package

should match this one-sentence description as well.

@utensil the README is excellent! One small suggestion: I'd have kept the opening line

geometric algebra/calculus modules for sympy

from the original README, or some variation thereof. For example:

Geometric Algebra (GA) and Geometric Calculus (GC) for SymPy

Ideally, the repository description

Symbolic Geometric Calculus package

should match this one-sentence description as well.

There is a one-sentence description in the new README:

Symbolic Geometric Algebra/Calculus package for SymPy.

Is that ok? Or is it distracted by the badges so you missed it?

@waldyrious Thanks for the great suggestions based on word-by-word proofreading, do you have any advices on Features or Getting Started? I'm not satisfied with them too.

Comments from codacy-bot for markdown files are super annoying, disabled them on Codacy:

@arsenovic @hugohadfield @waldyrious
Now most of tasks are completed for a first iteration(see the main thread at the top, I kept updating the task, 16 of them has been completed), I propose to merge this PR as is and leave the following tasks to later PRs:

[ ] Pick a better getting started example
[ ] Improve Section Features in README
[ ] Write a feature-complete tutorial like clifford's
[ ] Break into a few small markdown files
[ ] Complete proofreading of the whole document and fix formula issues
[ ] Fix outdated description in document
[ ] Refer to historical document for users encountering the outdated description in current document
[ ] Improve API document
[ ] Convert the python code and pdf output referenced in the tex doc to notebooks
[ ] Further fix cross references
[ ] Add description and attributions for the included materials in Section Resources

Comments welcome :smile:

There is a one-sentence description in the new README:

Symbolic Geometric Algebra/Calculus package for SymPy.

Is that ok? Or is it distracted by the badges so you missed it?

You're right, that is OK, and I did miss it due to the badges. Perhaps adding the sentence below the badges would make it more visible:

As an alternative, I've also seen the badges added to the heading itself — something like this:

Do any of these options look better to you? I have a slight preference for them but as long as the text is actually present, I don't mind if you choose to keep the current format.

do you have any advices on Features or Getting Started? I'm not satisfied with them too.

I think it's a good call to make improvements in further PRs. As a mostly curious layman with negligible mathematical background, I'll be happy to contribute in the development of approachable introductory material :)

yes i think what you have is good.  can be improved upon as time allows.

Looks really good :)

The failing doc build is simply because I pointed to branch nbsphinx on readthedocs.io, will rectify in a sec.


Fix for ORDER BY (#1101)

This pull request fixes the ORDER BY bug which caused the Jenkins builds to fail. The bug was in the index_scan_executor.cpp. The BWTree returned the tuples in the correct order, however we were trying to optimize the executor by consolidating all the tuples from a single physical tile into a single logical tile (thereby violating the order by clause). I have fixed the logic and it passes all the order by tests. However, I am running the code on a vagrant machine and I am not able to recreate the parallelism required to create two workers. To test if this works, @apavlo can you trigger the Jenkins build?

@poojanilangekar Thanks!
@pervazea Were you able to recreate this bug in the LLVM engine?

Coverage decreased (-0.03%) to 76.805% when pulling 0528cd3523a770118b341801c65111b18a13f6e2 on poojanilangekar:master into 7cbedfbf39afe525536008417e7394dff3e30871 on cmu-db:master.

Yes. The bug is independent of  LLVM / codegen.

From: Andy Pavlo<EMAIL_ADDRESS>Sent: Friday, February 2, 2018 8:34 PM
To: cmu-db/peloton
Cc: Pervaze Akhtar; Mention
Subject: Re: [cmu-db/peloton] Fix for ORDER BY (#1101) (#1122)
@poojanilangekarhttps://github.com/poojanilangekar Thanks!
@pervazeahttps://github.com/pervazea Were you able to recreate this bug in the LLVM engine?

You are receiving this because you were mentioned.
 I forgot that we don't support index scan in the LLVM engine yet.
@poojanilangekar Good find!
I will merge this when the build passes.

I ran psql_test.sh on this PR on a release build, with 8 cores enabled. It passed, with the following fix:
Need to modify psql_test.sh according to the following diff:

-PELOTON_USER="postgres"
+PELOTON_USER="default_database"


Year in the footer is not updated automatically

How should we actually go ahead to keep this up to date?

You fixed this @adneforslund ?

Hotfixed it at least, Im not sure if this should be handled in Sanity, Javascript, or wheter it should be hardcoded, but at least it says 2022 now

Finally time to prioritize this 😂

This is editorial task now. Copyright can be changed from text snippets.

Remove text snippet and hardcode the value

@millianapia, looks good! Just a minor comment.
When removing the feature flag also remember to delete the text snippet on studio/schemas/textSnippets.ts

@millianapia @fernandolucchesi - any test criteria for this one?

@millianapia @fernandolucchesi - any test criteria for this one?

Value is now hardcoded, meaning the text snippet will be useless from now on, so we will remove it. A way to test it is to change the Copyright text snippet to a random string, and seeing that it still shows Copyright 2023 Equinor

@NickHaggerty1 @meols

Great! Thanks :smile:


[web] iOS 15 does not load/rendering issues

Steps to Reproduce

A lot of our users have issues opening our Flutter app on Safari. This might be related to this issue.
On iPad the web version does not run at all, or has severe rendering issues.
In the JavaScript console there are no errors.
Our build command:
flutter build web --dart-define=SENTRY_RELEASE=$SENTRY_RELEASE -t lib/$FLAVOR_ENTRYPOINT --release --source-maps --web-renderer canvaskit
On Chrome (desktop) this issue does not seem to happen.

Hi @vixez, thanks for filing the issue.
Please provide the output of flutter doctor -v and a complete minimal reproducible code sample.
Thank you

[✓] Flutter (Channel stable, 2.5.3, on macOS 11.5.2 20G95 darwin-x64, locale en-GB)
    • Flutter version 2.5.3 at /Users/glennruysschaert/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/glennruysschaert/Library/Android/sdk
    • Platform android-31, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.1, Build version 13A1030d
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (3 available)
    • GM1913 (mobile) • 2b00d10b • android-arm64  • Android 11 (API 30)
    • macOS (desktop) • macos    • darwin-x64     • macOS 11.5.2 20G95 darwin-x64
    • Chrome (web)    • chrome   • web-javascript • Google Chrome 96.0.4664.55

• No issues found!

I cannot provide an example as this is company owned code.

Hi @vixez, can you check if this issue is similar to yours?
If it is, can you check if any of the workarounds in there work for you?
https://github.com/flutter/flutter/issues/89655

Hello @danagbemava-nc
I tried the solution but it did not work.
However I did find something else.
If I remove --web-renderer canvaskit from the build command, it does work on my iPad (with some lag).
So it seems that rendereris the source of the issue.

If I remove --web-renderer canvaskit from the build command, it does work on my iPad (with some lag).

Several people reported issues with canvaskit applications on iOS 15 before the beta became stable. If you don't specify a renderer it defaults to auto which I believe should use the html renderer on mobile devices and tablets.
Can you check on the master channel to see if you still experience this issue?

Hello @danagbemava-nc ,
When I switch to the master channel and build with
flutter build web -t lib/main-customer_production_store.dart  --release --source-maps --web-renderer canvaskit
I can confirm it works on my iPad (iPad Air 4tth Gen, iOS 15.1) on Safari.

Then the issue has been fixed.
A fix should rollout to stable in the future. I would also recommend you check out the beta channel to see if the issue is fixed over there as well, as that channel is more stable than master.
Given https://github.com/flutter/flutter/issues/94111#issuecomment-984448921, I feel it is safe to close as fixed.
If you still experience this issue, kindly leave a comment below with the output of flutter doctor -v, thank you


Update Marketo settings and documentation

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1308
Originally created by @iroussos on 2019-11-15 13:48:42

Following the completion of meltano/tap-marketo#2, we should update Marketo's configuration settings to use start_date instead of start_time
We should also update the documentation for tap-marketo to reflect that change and the new env var name.

View 2 previous comments from the original issue on GitLab


Use MacOSXWatchService instead of PollingWatchService

This is a resend of https://github.com/sbt/sbt/pull/4052.
It bumps up IO to 1.1.5, and also adds new closewatch mode.
/cc @eatkins

Merging this since #4052 has passed the review.


luck balance problem:C# solution

Added a new solution for luck balance problem using C# programming language

Hi @RyanFehr
I've changed the space complexity of the problem to O(n) in readme. We require this space to sort the input values using quick sort. I also saw that you've clearly mentioned it in your thoughts section, that you think it to be O(1) assuming the input array is already given. But since the input is given line by line from console, it is more fitting to consider it O(n) as we're storing the input in memory for solving the problem. I hope you would agree to my argument. Please act accordingly.


Separate legends (including main axes) from marks.

This allows to add a global color or radius legend to the plot as in https://observablehq.com/@data-workflows/plot-radiuslegend (ref #23 and #236).
Legends have the same signature as marks, but they receive only scales (index and channels are empty).
An issue is that the axes are below the marks, but I would tend to put the color and radius legends above them.
(I kept "unshift" to maintain the exact same order as in the test plots)

see also #425

Related #1197.


Animation in map

Is it possible that animation works whith element only one times.
I'd like to change line's color smoothly

something like that

Hello!
I'm not sure I understand your question. Do you want to change the color of a line over time?

no.
I want that line appear smoothy

something like transition

http://tangrams.github.io/shaders-demo/#16/40.7036/-74.0050
like rainbow here

ivangorelow,
I think you trying to describe a color gradient? (which, in a sense, is what the 'rainbow' selection in the link you mentioned above, is doing - the pixels' hues change incrementally (or 'smoothly' as you said' above ).
I'm interested in doing the same thing (using this for polygons like small bodies of water, etc) and used some code from @patriciogonzalezvivo  - see https://mapzen.com/blog/behind-the-scenes-tron2/  for the basis of my code )
and started working on it with this https://thebookofshaders.com/edit.php?log=160726010850

Hi @ivangorelow! If I understand correctly you want to fade in a rainbow... but never fade it back... right?
A way to do that is to use u_time uniform but clamp it to a range between 0. and 1. So the timer on the map will achieve 1. seconds and stay in that value. Check line 40 of this example https://thebookofshaders.com/edit.php?log=170119144638
Note that in that example I'm looping through time with a fract in line 34. You probably don't want that.

and how van I use your examples in my map whith android?


Order of JSON parameters appears to matter for JSONPath

Let's say we have the following JSON:
{ "store": {
    "book": "In store"
  },
  "street": {
    "book": "On the street"
  }
}

Using JSONPath, the expression $.store should return the store object ({book: "In store"}). This works fine in Gatling.
Likewise, $.street should return the street object ({book: "On the street"}) - at least, that's what happens in this online tester. In Gatling, however, this only appears to work when street is the first value in the root object.
Unless I'm misunderstanding, that's not how it should work, right?

I just added a test with your sample and Gatling works fine as expected: 6917d596906a16cdc85b4e1ac1abe6762c2da76c
It looks like a problem on your side.

If you can provide a reproducer, feel free to ping so I can reopen.

Hmm, then I'm probably doing something wrong somewhere else. Sorry to have wasted your time...

What does your check look like exactly? Are you trying to extract a String, or an object(ie a Map)? If the former, beware that white spaces are stripped. If the latter, beware that you have to use ofType (see test).

 Lower logging level in logback.xml and Check that your response is indeed the JSON payload you expect.


[examples] Nextjs Link missing passHref

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
mui recently updated nextjs-with-typescript example that changes Link component.
The new Link component wraps a tag with styled and this component lost it's native behavior.

Expected Behavior 🤔
Native link should

ctrl(or cmd) + click to open browser in a new tab
when mouse hover to a link, it's href displays in the bottom left of a browser.

Steps to Reproduce 🕹

https://codesandbox.io/s/cranky-bash-2tddh?file=/pages/index.tsx
Context 🔦

Your Environment 🌎
same with the codesandbox example.

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

diff --git a/examples/nextjs-with-typescript/src/Link.tsx b/examples/nextjs-with-typescript/src/Link.tsx
index 2f54fb257e..7318f42a94 100644
--- a/examples/nextjs-with-typescript/src/Link.tsx
+++ b/examples/nextjs-with-typescript/src/Link.tsx
@@ -28,6 +28,7 @@ export const NextLinkComposed = React.forwardRef<HTMLAnchorElement, NextLinkComp
         replace={replace}
         scroll={scroll}
         shallow={shallow}
+        passHref
         locale={locale}
       >
         <Anchor ref={ref} {...other} />

That fixes it.
Thank you.

It's a regression from #28178. I removed the passHref prop from NextLinkComposed because it has no effects, but I forgot to keep the prop applied inside.
Regarding the fix proposed in https://github.com/mui-org/material-ui/issues/28588#issuecomment-927529221, we also need to update the other /examples.


leaking color picker instances

Hello,
ISTM that this addon leaks color picker instances. I am using 8 pickers, and I have a checkbox that toggles them off and on. Every time I uncheck and check the checkbox, it leaks 8 instances of the color picker that never get cleaned up. This appears to be because the color picker is being added to the DOM on didInsertElement, but no symmetrical teardown hook on willDestroyElement exists.
I'll try to send through a PR to fix this.

Thanks for uncovering this. :+1:
I'll look forward to the PR. If you hit a snag I'd also be happy to look into this myself, just let me know.

willDestroyElement: function() {
    this.$().spectrum("destroy");
  }

Seems too prevent leaving a invisible div at the end of the DOM.

Thanks @riklaunim, this issue dropped of my radar. I just published 0.4.2 which should include your fix.


test-integration-docker-compatibility: switch away from docker-compose (v1) to docker compose (v2)

https://github.com/containerd/nerdctl/blob/dcb6a397e6b637d72fa80faca2b61d90f9a795d4/pkg/testutil/testutil.go#L595

@AkihiroSuda do we have existing blockers for this transition to docker compose(v2), or we just need to make sure all tests are passed after transition?

I don’t see any blocker

Hi @AkihiroSuda I'm working on this and would like to have your input on a question
docker compose v1 and v2 themselves have incompatible behaviors on some commands/formats, which fails some of our docker-compatibility tests after switching to v2, because I guess previously we follow the docker v1 behavior while writing these commands/tests.
My question is:

Should we change the v1 behavior in nerdctl compose to match v2 in such cases (and update tests accordingly)?
Or we should not change the current implementation, and instead should try best to write tests that are generic to both v1 and v2 (e.g., avoid v1/v2 incompatible behaviors). Then our tests won't fail for either v1 or v2.

Personally I would prefer 1 since compose-v2 has been released for a while, and it's difficult to keep nerdctl compose compatible with both v1 and v2.
But that also means we should check and only use docker compose v2 in CI instead of falling back to v1 when v2 not there. (because it will fail anyway). Not sure if this is okay.
Thanks :)

As an example, docker compose v1 uses _ when creating containers while v2 uses -.
    compose_up_linux_test.go:410: projectName="nerdctl-compose-test-1670887650"
    compose_up_linux_test.go:417: assertion failed:
        Command:  /usr/bin/docker compose -p nerdctl-compose-test-1670887650 -f /tmp/nerdctl-compose-test370185716/docker-compose.yaml ps
        ExitCode: 0
        Stdout:   NAME                                       COMMAND             SERVICE             STATUS              PORTS
        nerdctl-compose-test-1670887650-orphan-1   "sleep infinity"    orphan              running
        nerdctl-compose-test-1670887650-test-1     "sleep infinity"    test                running

        Stderr:

        Failures:
        Expected stdout to contain "nerdctl-compose-test-1670887650_orphan_1"

Thanks, 1 seems good


Small grammar fix

A very minor grammar fix for the documentation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @nikolasburk , apologies for tagging you randomly but it appears I missed something when creating this PR and one other #4955 so nobody was added/notified as a reviewer. Would you mind helping me get these approved?

@do4gr I apologize for the random tags, just trying to understand how I can make someone aware that this PR exists since I'm unable to add reviewers and none were added automatically after I signed the CLA. Same problem for #4955 . I must have missed a step somewhere creating my PRs.
Thank you all 🙏🏼

Thanks a lot for catching this @robin-macpherson and apologies for the delay 🙌

Thanks a lot for catching this @robin-macpherson and apologies for the delay 🙌

Thank you @nikolasburk ! Would you mind also merging #4955 ? Also, what's the correct way for me to do this in the future so that I can add you as a reviewer and not have to tag you in a comment?


Not able to expose http and https endpoints for Eureka Client

 Below are my configurations for Eureka Client
eureka.instance.instanceId=${spring.application.name}:${spring.application.instance_id:${random.int}}
eureka.instance.nonSecurePortEnabled=true
eureka.instance.securePortEnabled=true
eureka.instance.securePort=${server.port}
eureka.instance.nonSecurePort=${http.port}
spring.cloud.bus.enabled=true
same configuration is enable for Eureka Server, Zuul and COnfig Server.
When I try to call a service by using Zuul's non secure port, I am getting connection refused.
Below is the /eureka/apps/ output

1
UP_3_

DDO-CONFIG-SERVER

ddo-config-server:-1727522517
GCOTVMMW7123731.nam.nsroot.net
DDO-CONFIG-SERVER
<IP_ADDRESS>
UP
UNKNOWN
8887
8888
1

MyOwn

30
90
1557235502739
1557235742706
0
1557235502739

8888

http://GCOTVMMW7123731.nam.nsroot.net:8887/

http://GCOTVMMW7123731.nam.nsroot.net:8888/actuator/info

http://GCOTVMMW7123731.nam.nsroot.net:8888/actuator/health

https://GCOTVMMW7123731.nam.nsroot.net:8888/actuator/health

ddo-config-server
ddo-config-server
false
1557235502739
1557235502680
ADDED

DDO-ZUUL

ddo-zuul:-933721402
GCOTVMMW7123731.nam.nsroot.net
DDO-ZUUL
<IP_ADDRESS>
UP
UNKNOWN
8078
8079
1

MyOwn

30
90
1557235419873
1557235749588
0
1557235419875

8079

http://GCOTVMMW7123731.nam.nsroot.net:8078/

http://GCOTVMMW7123731.nam.nsroot.net:8079/actuator/info

http://GCOTVMMW7123731.nam.nsroot.net:8079/actuator/health

https://GCOTVMMW7123731.nam.nsroot.net:8079/actuator/health

ddo-zuul
ddo-zuul
false
1557235419875
1557235419535
ADDED

DDO-OS-DATAPROVIDER-SERVICE

ddo-os-dataprovider-service:-1777536612
GCOTVMMW7123731.nam.nsroot.net
DDO-OS-DATAPROVIDER-SERVICE
<IP_ADDRESS>
UP
UNKNOWN
8892
8899
1

MyOwn

30
90
1557235548752
1557235758706
0
1557235548752

8892

http://GCOTVMMW7123731.nam.nsroot.net:8892/

http://GCOTVMMW7123731.nam.nsroot.net:8899/actuator/info

http://GCOTVMMW7123731.nam.nsroot.net:8899/actuator/health

https://GCOTVMMW7123731.nam.nsroot.net:8899/actuator/health

ddo-os-dataprovider-service
ddo-os-dataprovider-service
false
1557235548752
1557235548690
ADDED

spring Boot version : 2.1.3
Spring CLoud version Greenwish.SR1

Can you provide a complete, minimal, verifiable sample that reproduces the problem?  It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

Actually, it won't, since there is much more to projects than just properties.

Hi Spencer,
My projects have not been evolved as of now. Whatever is needed to bring the Microservice framework up and running only those changes are there. Very minimal code is there.

Hi Spencer,
Any update on this?

We need complete working projects to try and reproduce, whether there is minimal code or not.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Error with Docker Compose: Python and Pip Linking

Hi, I'm trying to execute the instructions in the README  file (Docker section) but the command docker-compose up returns the following error:
ERROR [relying-party.org 3/9] RUN ln -s /usr/bin/python3 /usr/bin/python && ln -s /usr/bin/pip3 /usr/bin/pip

unfortunately this repository is outdated right now regarding the software components outside this repository


Bugfix for numba binning when df cols are of different types

Several people have reported a bug per email with
TypingError: Failed in nopython pipeline (step: nopython frontend)
non-precise type array (pyobject, 2d, F)

A quick fix was to just use hist_mode: numpy.
Now I finally managed to track it down to the cause. When the dtypes of different cols that are being binned are not the same, such as int16 and float32, numpy treats the array as a type object.
Usually, numpy infers these types and choose the highest precision type for all in array automatically. However, if you do df.values, it is an object. But somehow choosing columns and then getting values makes numpy choose the array type correctly.
I also added an exception in case the array type is still an object.

apparently was addressed here but with a different solution:
https://github.com/OpenCOMPES/sed/blob/702203f9e55128b53be484852650aec1fa443697/sed/core/processor.py#L2021-L2042

I cannot reproduce this problem with the test data. Can you post concrete steps how to reproduce, and maybe add a test for this?

I cannot reproduce this problem with the test data. Can you post concrete steps how to reproduce, and maybe add a test for this?

I will try to reproduce this with test data but this can also be tested with the data/config here:
https://syncandshare.desy.de/index.php/s/58y44ncLFWpggTS

This should produce the relevant error:
config_path = "tests/data/loader/flash/config.yaml"
sp = SedProcessor(runs=[43878], config=config_path, collect_metadata=False)

# just as an example
sp._dataframe = sp._dataframe.astype({'dldTimeSteps': 'float32', 'dldPosX': 'uint32', 'dldPosY': 'uint32'})

axes = ['dldTimeSteps',  'dldPosY', 'dldPosX']
bins = (1, 10, 10)
ranges = [[4200, 5000], [460,470], [460,470]]
res = sp.compute(bins=bins, axes=axes, ranges=ranges)

The root problem is that your config file does not fit to the data. In your data file, the delayStage channel consists of a 2D array of four different values:

This is represented as an "object" type in the dataframe (because each column can only be 1D):

So the problem is not in the binning code, but in the dataframe and config. A solution is to add slicing to the config:
    # Optical laser channels
    delayStage:
      format: per_train
      group_name: "/FL1/Experiment/Pump probe laser/delay line IK220.0/ENC/"
      slice: 0

Then it works with the code from the main branch.

So the problem is not in the binning code, but in the dataframe and config. A solution is to add slicing to the config:

That seems to indeed be the problem. My reasoning for the bug were incorrect.
However, I still support this change for a few reasons
In case it is incorrectly defined channels by user

that are not being binned, this will still bin the correctly defined channels (that are to be binned)
https://github.com/OpenCOMPES/sed/blob/67cc3ec23bc8aa92479f695c035aa9735d1f5fcd/sed/binning/binning.py#L173
that are being binned, it will throw an error that is clearer than what numba throws (we can change it to let the user know to add the correct slices for example).
https://github.com/OpenCOMPES/sed/blob/67cc3ec23bc8aa92479f695c035aa9735d1f5fcd/sed/binning/binning.py#L175-L179


How to resize TVIVideoView in video call

Hi, I am using Twilio in my project for video call and screen sharing but I am facing issue into video call preview View resizing, I want to resize preview view to different height width but when I set height width it applies on view but actual video data remains same height width.
I think there is maintain some aspect ratio in Twilio but I want to change this aspect ratio.
please help me how can I resize video preview height width with custom values.
Thanks in advance.

Hi @rashidabbas,

please help me how can I resize video preview height width with custom values.

TVIVideoView supports some UIView.contentMode settings. For example, if you want to scale the content to fill (by cropping it) you can do the following:
myVideoView.contentMode = .scaleAspectFill

Just like any other UIView, it's up to you how you size your TVIVIdeoView.
Best,
Chris

Hi,
I hope this answered your question. Feel free to re-open if you're still having content formatting/sizing issues.
Best,
Chris


358 increase coverage

Increase TableFilter coverage (#358)

Codecov Report

Merging #493 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   87.56%   87.58%   +0.01%
==========================================
  Files          38       38
  Lines        4392     4390       -2
  Branches      333      334       +1
==========================================
- Hits         3846     3845       -1
+ Misses        525      524       -1
  Partials       21       21

Impacted Files
Coverage Δ

src/tablefilter.js
92.02% <100%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0a6a0...cc5c8b9. Read the comment docs.

:shipit:


Interactive Debugging

I would like to be able to use the AHK's support for DBGp.
However, I was only able to find one forum entry asking for help without replies.
I anyone using this (or the Xdebug Client package) for AHK coding in sublime?

This is better discussed on the forum rather than in a issue.


Implement kwargs for isapprox

Currently we don't accept rtol or atol keyword arguments. For compatibility with the API one expects from the standard implementations of Base.isapprox, we should do so.

This actually causes problems due to the fact that the GA types currently are subtypes of Number... it means that when rtol is specified, we actually end up trying to call the version of isapprox in Base that is implemented for (::Number, ::Number), but also supports kwargs.
This seems counterintuitive, but it's a consequence of how Julia implements kwargs dispatch right now. See here: https://github.com/JuliaLang/julia/issues/9498


deprecated : explorer.openEditors.visible = 0

The release notes of 1.20 seems to indicate that we won't be able to set the visibility in settings.
Please, keep a parameter to completely hide the OPEN EDITORS view.
This is a key aspect to deploy the editor and imply our way to use it.
from https://code.visualstudio.com/updates/v1_20#_open-editors-updates :
The ability to set explorer.openEditors.visible to 0 to hide the OPEN EDITORS view is being deprecated in the January release and we plan to drop it in February. To hide the OPEN EDITORS view, use the context menu in the Explorer title area to control the visibility of views.

VSCode Version: 1.20
OS Version: Windows

Thank you,
Guido

@gpuido users can now right click to hide the explorer view.
What you seem to want is API to hide views, which we do not provide. I will rename this to be a feature request regarding that. We will not bring back the hack to hide the open editors view.
fyi @sandy081

@isidorn Do you mean that we will need an extension targeting a future API to
hide 'open editors view' without user right click ?
Setting the view visibility is, well, a setting.
Why can't we just have  "explorer.openEditors.visible": false  in user settings ?

I mean, I don't need an API. I just need "explorer.openEditors.visible" being still available in the next version.

If you are a user, you can just right cclik on that view to hide it as shown in the gif.
If you are an extension, we need to add api for this to be possible.
Which one are you?

A user.
User settings are here to avoid clicking around to setup our coding environment.
That's why I don't understand why this is deprecated.
visibility settings are the first thing anyone configure in user settings.
Please, keep that one too.

Nope. Please just hide it in the split view, we preserve this across workspaces, so you will only need to do it once as a user.
Closing as designed.
Thanks for feedback

@isidorn, does this mean that deprecation is already done (in Insiders or(and) Stable?) and functionality in its final form?

@usernamehw look at https://code.visualstudio.com/updates/v1_20#_open-editors-updates

The ability to set explorer.openEditors.visible to 0 to hide the OPEN EDITORS view is being deprecated in the January release and we plan to drop it in February.

we plan to drop it in February - is it referring to February as month or release? I, personally, don't know.

Deprecated means it will disappear in the next stable version.
I haven't check if it's already done in insider.

February release.

It is already removed in the insiders.
It will be removed in the next stable which we plan to ship start of march.

@isidorn Don't you feel it's a bit weird to remove a basic visibility setting like this ?
somewhere, in a file, the setting will be set once we right click on it and hit hide.
vscode have always been about a clean slate to start with.
I personnaly use the tree+editor+terminal. No Open editor view, no tabs.

@isidorn I have reset the title since it was a renamed on a misunderstanding.

I agree. This should continue to work in the user's settings.json file. This isn't about an API, this is about this in the JSON file.
"explorer.openEditors.visible": 0
I very much liked that with a simple JSON file my exact VSCode preferences can be restored. That makes it easy to set up new environments, virtual machines, etc. I keep this file in a gist and keep it up-to-date.
It's disappointing that the setting will no longer be respected. This also sets a bad precedent that full-customization and preferences is no longer portable in a JSON file.

I agree with the others here. I don't understand what was wrong with this being a setting in settings.json. I thought was wonderful for the exact same reasons as others suggested. I can sync my editor across multiple environments with a single file. It's wonderful. What is the benefit of a right click if I may ask?

Thanks for your feedback. The benefit or right click is that it behaves like any other view in all the other split views (debug views, custom views in explorer).
For those views we do not have settings to hide, so in the same way open editors will not have a special visibility setting.
All of this is done for consistency and for removing special code that had to deal with this.

The other views are not on by default though. So when I set up a new environment I don't need a setting to remove all annoying views, because they are not on by default. So if consistency is key here, then the open editors view will be hidden by default? If yes, then I don't mind, otherwise it's a really annoying thing. It will be like Visual Studio where the first thing you do after opening is to hide all the side panels which you never use and where I know the key combination anyway to pop it open if I need it...

@dustinmoris if you hide it once it will be hidden forever in all workspaces.
By default it is shown.
Debug views are also there by default.

Ok I see. I understand how this makes sense, however I personally think it would have been better to create consistency the other way around (even though that would have been more work). Instead of having no settings for windows at all anymore I think it would have been awesome to have settings in settings.json for all windows. There is huge value in being able to have my VS Code settings synced to my Google Drive and if I set up a new dev machine somewhere else I have my entire VS Code environment configured the same way again in which I am the most productive, including the layout of all windows, where I have my debug console, if open editors are on/off, etc.
Also this feature wouldn't be an all or nothing. I think it would be nice to still keep the right click functionality, but instead have it saved into the user's settings file. Essentially you save the state somewhere anyway, so might as well save the state into a place where the user can benefit from it.
Maybe the PM of VSCode can think about this ^
There is a reason why VS Code has become so popular so quickly. The more "hackable" it is by a user, the more it remains the editor which people went for in the first place.

@isidorn I really think this should still be a setting (number or boolean). In 1.20 I pull my settings.json file in and the workbench is exactly as I want it, in 1.21 it looks like this:

@Tyriar we will have a transition strategy, if you had a setting we will write it into your local storage. Once I push the transition strategy I will close this issue.

@isidorn the main point is I work on many different machines and pull in my settings file on all of them, the transition strategy of converting the setting would eventually be removed and I would be left with the open editors pane that I have to close manually on every new machine.
This seems like one of those big decision sort of things that we should persist in settings.json so its portable?

@Tyriar I agree with you that it is nice to have this portable. However I still hold the reasons I specified above, consistency and open editors not being special than other split view
Bottom line I hate spanding more of my time on this when I have actual work to do. So I will revert my commit and bring back the open editors visible 0.
Thanks for feedback

Thank you @isidorn for bringing it back.
I understand the consistency reasons.
This somewhat relate to the history of the open editors view (working files!) as an alternative to tabs.
Sorry that you had to bring back all this code
as deleting old code brings so much satisfaction. =)

@isidorn Also would like to say thanks to you! Really appreciate that you took the time to explain the consistency issue and your willingness to revert the change even though I can see that this is perhaps not the best solution to the problem!
You guys are doing a fantastic job with VS Code, it has certainly become one of the most popular editors not only amongst .NET folks but also among the wider developer community! Thanks everyone involved in it!


:arrow_up: Upgrade @material packages to 0.19 versions

:boom: Change "accent" to "secondary" golbally, as done by MDC-Web.
https://github.com/material-components/material-components-web/pull/1116
:sparkles: {{mdc-button}} now has unelevated boolean attribute (default: false)
:sparkles: {{mdc-button}} now has dense boolean attribute (default: false)
:sparkles: {{mdc-button}} now has compact boolean attribute (default: false)
:sparkles: {{mdc-textfield}} now has box boolean attribute (default: false)

And of course, in the middle today's upgrade, 0.20 was shipped.


Problem with pywdf installation " python setup.py egg_info did not run successfully"

Hello, i try to install pywdf, but i can't, i have this error:
(.venv) PS C:\Users\Cristiano\PycharmProjects\ProvaPYTHON> pip install git+https://github.com/gusanthon/pywdf
Collecting git+https://github.com/gusanthon/pywdf
Cloning https://github.com/gusanthon/pywdf to c:\users\cristiano\appdata\local\temp\pip-req-build-vduvqfxm
Running command git clone --filter=blob:none --quiet https://github.com/gusanthon/pywdf 'C:\Users\Cristiano\AppData\Local\Temp\pip-req-build-vduvqfxm'
Resolved https://github.com/gusanthon/pywdf to commit f4c1df0bb9d245c26db68c339bb84ad211dafd44
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "C:\Users\Cristiano\AppData\Local\Temp\pip-req-build-vduvqfxm\setup.py", line 4, in
long_description = fh.read()
^^^^^^^^^
UnicodeDecodeError: 'cp932' codec can't decode byte 0x82 in position 1181: illegal multibyte sequence
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
I use Python 3.12.3  , pip 24.0 on Windows 10;
How can I solve it?
Thanks for you attention

Hi Cristiano,
Sorry, it has been only tested on Linux and OSX, never on Windows.
Maybe you can try with WSL: https://learn.microsoft.com/en-us/windows/wsl/install
Hope this helps.


Filter functionality for emoji-spam messages

Now that someone's figured out you can cause havok by dumping massive amounts of emojis into a channel, we need a filter to automatically manage this ASAP. Detection should be fairly simple, a very high emoji count is required for the effect (>20/message to >250 for varying impact) but emoji variance is not required.
Tangentially: This is also likely related to a discord update that went out that has slowed the emoji loading process recently.
I think we can safely filter out and autodelete high emoji messages without significant false positives.
We may want to handle both unicode emojis and server emojis.
It's possible for unicode emojis to get a higher "load" because they could as one character for message transmission purposes but server emojis count for more. However, server emojis may be animated, and will apply significant load by that fact as well.

So what kinds of emojis does this affect?  Do standard unicode ones trigger it?  Is it specifically Discord or custom emoji?

FYI we already have a rule for custom emojis, we can simply edit this one.

I will fix it.

I will use emoji library (https://github.com/carpedm20/emoji/blob/master/emoji/unicode_codes.py) as Unicode emojis can be made from multiple emojis and this library takes care over parsing them as 1 emoji.


OpenEBS(catalog) meet mount failed after the node is shutdown and removed

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Deploy openebs from catalog(using rancher's chart)
Deploy a statefuel set using pvc with standard storage class(1 postgresql pod + 2 replica pods)
Shutdown the node which is running the stateful set pod.
Wait 5 mins for the eviction.
For now, all the deployments pods rescheduled successfully. And statefuel set still be the 'unkowning' status because of the k8s design.
Then delete the shutdown node from cluster. The statefuel set start rescheduling.

Result:
The stateful set stuck on 'container creating' with folloing except:
Events:
  Type     Reason              Age   From                       Message
  ----     ------              ----  ----                       -------
  Normal   Scheduled           2m    default-scheduler          Successfully assigned default/pg-test-0 to rancher-worker-1
  Warning  FailedAttachVolume  2m    attachdetach-controller    Multi-Attach error for volume "pvc-58d76046-f3b1-11e8-88d1-fa163ef661ff" Volume is already exclusively attached to one node and can't be attached to another
  Warning  FailedMount         22s   kubelet, rancher-worker-1  Unable to mount volumes for pod "pg-test-0_default(7436210d-f443-11e8-88d1-fa163ef661ff)": timeout expired waiting for volumes to attach or mount for pod "default"/"pg-test-0". list ofunmounted volumes=[pg-test-vol]. list of unattached volumes=[pg-test-vol default-token-jlhsd]

Other details that may be helpful:
Seems it didn't detached the volume from the shut down node. So the new created stateful set pod can not mount the volume even if the replica and controller still working.
If using the openebs from helm, follow the steps above, all fine except a warning:
Events:
  Type     Reason                  Age   From                       Message
  ----     ------                  ----  ----                       -------
  Normal   Scheduled               1m    default-scheduler          Successfully assigned default/pg-test-0 to rancher-worker-2
  Warning  FailedAttachVolume      1m    attachdetach-controller    Multi-Attach error for volume "pvc-673958bf-f447-11e8-88d1-fa163ef661ff" Volume is already exclusively attached to one node and can't be attached to another
  Normal   SuccessfulAttachVolume  1m    attachdetach-controller    AttachVolume.Attach succeeded for volume "pvc-673958bf-f447-11e8-88d1-fa163ef661ff"
  Normal   Pulling                 39s   kubelet, rancher-worker-2  pulling image "harbor.io/library/balabalayi/bitnami-postgresql:9.6.11-root"
  Normal   Pulled                  1s    kubelet, rancher-worker-2  Successfully pulled image "harbor.io/library/balabalayi/bitnami-postgresql:9.6.11-root"
  Normal   Created                 1s    kubelet, rancher-worker-2  Created container
  Normal   Started                 0s    kubelet, rancher-worker-2  Started container

>
>
> k get pods
NAME                                                             READY     STATUS    RESTARTS   AGE
pg-test-0                                                        1/1       Running   0          1m
pvc-673958bf-f447-11e8-88d1-fa163ef661ff-ctrl-7f5bd7558d-b6dlg   2/2       Running   2          13m
pvc-673958bf-f447-11e8-88d1-fa163ef661ff-ctrl-7f5bd7558d-zgmwn   2/2       Running   0          1m
pvc-673958bf-f447-11e8-88d1-fa163ef661ff-rep-557d45854b-n7fsv    1/1       Running   0          13m
pvc-673958bf-f447-11e8-88d1-fa163ef661ff-rep-557d45854b-nqzpq    1/1       Running   0          1m

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.1.1
Installation option (single install/HA): single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):custom
Machine type (cloud/VM/metal) and specifications (CPU/memory):openstack vm
Kubernetes version (use kubectl version):1.11.3

@BalaBalaYi Have you resolved that issue somehow? Or @guangbochen can you provide any info on this? Cause we faced the same exact issue.

@ArgonShepard I'll try this when v2.2 release. Keep tracking........

@kmova, @prateekpandey14 maybe u guys can help on this? thanks.

@ArgonShepard - are you using baremetal K8s cluster?

@kmova yes

@ArgonShepard -- for onpremise clusters, there is an open issue that takes longer time - more than 30 mins before the controller can decide that the older node is down. Here are some related issues:
https://github.com/kubernetes/kubernetes/issues/63475
https://github.com/kubernetes/kubernetes/issues/65392

@ArgonShepard Reproduced this issue with rancher/rancher:v2.2.0 and openebs:v0.8.1. And the result is same with @kmova above. The 'force-detached' happend after 6miniutes but not the moment the node is deleted. Here is the log output:
Containers:
  wiki:
    Container ID:   docker://f977218ac3f40172da55b26419df956c56d47ba3c9a9221892d1ae530948da43
    Image:          harbor.io/library/bitnami/dokuwiki:0.20180422.201901061035
    Image ID:       docker-pullable://harbor.io/library/bitnami/dokuwiki@sha256:5795591bbac1a772af9337657968e7e3b2fa22e191641514655f9c09bb23f29e
    Port:           80/TCP
    Host Port:      0/TCP
    State:          Running
      Started:      Wed, 27 Mar 2019 08:20:59 +0000
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /bitnami from wiki-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-j8p87 (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  wiki-volume:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  wiki-volume
    ReadOnly:   false
  default-token-j8p87:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-j8p87
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason                  Age                    From                      Message
  ----     ------                  ----                   ----                      -------
  Normal   Scheduled               8m43s                  default-scheduler         Successfully assigned test/wiki-0 to rancher-agent-3
  Warning  FailedAttachVolume      8m43s                  attachdetach-controller   Multi-Attach error for volume "pvc-021aec18-5067-11e9-a7c5-fa163ee7a8f3" Volume is already exclusively attached to one node and can't be attached to another
  Warning  FailedMount             4m22s (x2 over 6m40s)  kubelet, rancher-agent-3  Unable to mount volumes for pod "wiki-0_test(4e5c411f-5068-11e9-a7c5-fa163ee7a8f3)": timeout expired waiting for volumes to attach or mount for pod "test"/"wiki-0". list of unmounted volumes=[wiki-volume]. list of unattached volumes=[wiki-volume default-token-j8p87]
  Normal   SuccessfulAttachVolume  2m43s                  attachdetach-controller   AttachVolume.Attach succeeded for volume "pvc-021aec18-5067-11e9-a7c5-fa163ee7a8f3"
  Normal   Pulling                 2m27s                  kubelet, rancher-agent-3  pulling image "harbor.io/library/bitnami/dokuwiki:0.20180422.201901061035"
  Normal   Pulled                  117s                   kubelet, rancher-agent-3  Successfully pulled image "harbor.io/library/bitnami/dokuwiki:0.20180422.201901061035"
  Normal   Created                 117s                   kubelet, rancher-agent-3  Created container
  Normal   Started                 117s                   kubelet, rancher-agent-3  Started container


OAuth2 resource indication

We may want to have RFC8707 and accordingly allow to modify the "aud" claim in our access token JWT.
This likely requires a client/user configuration which allows us to white/blacklist resources.

The audience parameter must/is checked at the API and the userinfo endpoint.
This means that by default, we need to add the service host to the audience claim if access to the API is granted or the userinfo endpoint accessible. I.e. (if the openid or omejdn:* scopes are granted).
After reviewing the commit, I think this is missing and should be added.