Problem with "embed with"

It's pretty straightforward:
This works:
{% embed '_partials/validator.twig' with { 'id':field.id, 'errors':field.errors } %}

This does not:
{% embed '_partials/validator.twig' with
{
'id':field.id,
'errors':field.errors
}
%}

But with the include statement it does:
{% include '_partials/form-item.twig' with
{
'id':field.id,
'label':field.label
}
%}

Confirming. In addition, substituting out blocks with empty/null variables causes an error:
{% embed<EMAIL_ADDRESS>with { 'classes': 'media-item', 'title': item.title, 'url': item.url, 'image': item.image, 'label': item.label, 'type': item.type  } only %}
          {% block text %}

{{ fieldText }}

          {% endblock text %}
        {% endembed %}

I think from what I gather in the Twig docs that the lack of the fieldText variable should not stop the block from displaying the markup in this situation.

@derekreesemediacurrent I'm not following your "in addition." What here is empty or null, and what's breaking? (Maybe a more minimal example?)
Tangent: ooh did you create an @components namespace or something?? And you have it working in twig.js? If that's correct, I'd love to hear how you did that. Don't want to swamp this thread… if it's lengthy, maybe dm me on twig.js gitter

Looks to me like this is more specifically any time there's a line break between the { and the } of an embed tag's with (i.e. twigjs errors even if there's only one line break in there, and it can be anywhere in there)

@olets The null variable is fieldText, which isn't passed in the with statement part of the embed. Shouldn't Twig.js should treat it just like any other variable that isn't provided a value?
{% embed<EMAIL_ADDRESS>with { 'classes': 'media-item' } only %}
  {% block text %}

{{ fieldText }}

  {% endblock text %}
{% endembed %}

For namespaces, see https://github.com/twigjs/twig.js/pull/195

Ah okay didn't know if fieldText had been set somewhere else. You're definitely right about how it should work - e.g. http://twigfiddle.com/zz6agb. Can you check that in twig.js? It's working for me
Continuing the namespaces tangent ;) Sweet! Where are you adding that variable?

I've run into this issue as well
http://twigfiddle.com/j02f4n
{% embed "label.twig" with {
    'for': 'cat'
  } only %}
    {% block innerHTML %}
      A cool cat
    {% endblock %}
{% endembed %}

<label{% if accesskey %} accesskey="{{accesskey}}"{% endif %}{% if class %} class="{{class}}"{% endif %}{% if contenteditable %} contenteditable="{{contenteditable}}"{% endif %}{% if contextmenu %} contextmenu="{{contextmenu}}"{% endif %}{% if dir %} dir="{{dir}}"{% endif %}{% if draggable %} draggable="{{draggable}}"{% endif %}{% if dropzone %} dropzone="{{dropzone}}"{% endif %}{% if for %} for="{{for}}"{% endif %}{% if form %} form="{{form}}"{% endif %}{% if hidden %} hidden="{{hidden}}"{% endif %}{% if id %} id="{{id}}"{% endif %}{% if lang %} lang="{{lang}}"{% endif %}{% if spellcheck %} spellcheck="{{spellcheck}}"{% endif %}{% if style %} style="{{style}}"{% endif %}{% if tabindex %} tabindex="{{tabindex}}"{% endif %}{% if title %} title="{{title}}"{% endif %}{% if translate %} translate="{{translate}}"{% endif %}>
  {% block innerHTML %}{% endblock %}

Console Error
  ```bash
Error compiling twig template /Users/jP/Sites/twag/views/index.twig:
TwigException: Unable to parse 'embed "../twag/label.twig" with {
    'for': 'cat'
  } only'
Error parsing twig template /Users/jP/Sites/twag/views/index.twig:
TypeError: Cannot read property 'forEach' of undefined
    at Object.Twig.forEach (/Users/jP/Sites/twag/node_modules/twig/twig.js:151:24)
    at Twig.parse (/Users/jP/Sites/twag/node_modules/twig/twig.js:830:19)
    at Twig.Template.render (/Users/jP/Sites/twag/node_modules/twig/twig.js:1267:30)
    at params.load (/Users/jP/Sites/twag/node_modules/twig/twig.js:7009:41)
    at loadTemplateFn (/Users/jP/Sites/twag/node_modules/twig/twig.js:5374:18)
    at tryToString (fs.js:455:3)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:442:12)
  ```

It seems fixed in v0.10.0


updated code to use the Level 2 mwRTM parameters

Addresses changes that are needed to use L-band radiative transfer model (RTM) parameters derived from the SMAP L2 passive retrieval product.
Includes all commits from earlier PRS #419, #425, and #426.

My two most recent commits resolved the merge conflict with develop, fixed minor (no-impact) bugs, and (hopefully) addressed the outstanding issues from PRs #419, #425, and #426 except the following:

add VEGOPACITY_FILE to ldas_setup, GEOSldas_LDAS.rc

@gmao-rreichle , ldas_setup now can add vegopacity file.  "MWRTM_FILE" in the input script file for ldas_setup should be changed to "MWRTM_PATH" which may contain "mwRTM_param.nc4" and "vegopacity.bin" . @gmao-qliu , would you help to test the ldas_setup?

Thanks, @weiyuan-jiang.  While you're at it, can you please add the missing "global-to-domain" mapping after reading the veg_opacity from the input file?

Thanks, @weiyuan-jiang. While you're at it, can you please add the missing "global-to-domain" mapping after reading the veg_opacity from the input file?

That should happen automatically after I added the vegopacity file to group here

The link is not shown up in my reply

Thanks, @weiyuan-jiang. While you're at it, can you please add the missing "global-to-domain" mapping after reading the veg_opacity from the input file?

That should happen automatically after I added the vegopacity file to group here (line -731-732)

Ok.  Sorry I keep being confused about the workings of MAPL.  But the link above ("line 731-732") is for ldas_setup, which only makes sure the vegopacity file can be found by GEOSldas.x.  Since vegopacity is a seasonally varying climatology (just like LAI, and unlike the fields in the mwRTM param file), GEOSldas.x will read it repeatedly.  If I'm not mistaken, the pertinent piece is then the MAPL object in this MAPL_ReadForcing() call..  That is, the MAPL object knows which N_catl tiles to extract from the vegopacity file for each local domain.  Does this make any sense?

That is not how we deal with the mapping. ldas_setup do the mapping here.  https://github.com/GEOS-ESM/GEOSldas/blob/a06fcd92d6dd8cd361dc665c36d9a5ece82613e5/src/Applications/LDAS_App/ldas_setup#L743-L744  .  GEOSldas.x does not know about the mapping any more.

Thanks, @weiyuan-jiang.  Now I get it, I think...  Sorry it's taken me so long to refresh my memory.
In a nutshell, there's a pre-processed  vegopacity file that includes only the tiles for the simulation domain.  MAPL then thinks that this potentially regional simulation domain is the "global" domain.
This has implications for the "snow albedo" PR in the GCM GridComp that @biljanaorescanin is working on.  Her current implementation reads a global tile file directly into the Catchment GridComp.  To make this work for GEOSldas, we would have to add the snow albedo file to the list of files that need to be preprocessed.  So rather than changing Biljana's GCM GridComp implementation, we would need a matching GEOSldas PR.  Does this sound right?
For reference, the snow albedo file is most similar to the mwRTM_param file because it's nc4 and contains a static (time-invariant) parameter.

@gmao-rreichle , ldas_setup now can add vegopacity file. "MWRTM_FILE" in the input script file for ldas_setup should be changed to "MWRTM_PATH" which may contain "mwRTM_param.nc4" and "vegopacity.bin" . @gmao-qliu , would you help to test the ldas_setup?

I just tested "ldas_setup". It works with both L2RTM and the old RTM setting.

It passed the nightly test before I created the pull-request. @gmao-rreichle @weiyuan-jiang
Full log file: /discover/nobackup/qliu/SystemTests/logs/LDAS/2022-01-31/log.14:46:11
Runtype	Clone	Build	Build Time	Model Run/Compare	Assim Run/Compare

conus	pass	pass	13 min	pass/pass	-- / --
global	--	--	--	pass/pass	pass/pass
globalcs	--	--	--	pass/pass	pass/pass
globalcnclm4	--	--	--	pass/pass	-- / --

It passed the nightly test before I created the pull-request.

Thanks, @gmao-qliu.  I took another look at the run failures this morning.  @weiyuan-jiang, it's looking like this is a problem with the latest changes to ldas_setup.  When I do setup with this branch for the global assim test case, LDAS.rc contains the following line:
MWRTM_FILE:                         /discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/mwRTM_param.nc4
In the nightly test with develop, LDAS.rc instead contains this line:
LANDASSIM_INTERNAL_RESTART_FILE:    ../input/restart/mwrtm_param_rst
When I (i) manually edit LDAS.rc after setup to look like that from the nightly test and (ii) create a link:
ln -s /discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/mwRTM_param.nc4 [...]/input/restart/mwrtm_param_rst
then the run failure goes away and I get 0-diff results.  I haven't figured out yet how to change ldas_setup.

It passed the nightly test before I created the pull-request.

Thanks, @gmao-qliu. I took another look at the run failures this morning. @weiyuan-jiang, it's looking like this is a problem with the latest changes to ldas_setup. When I do setup with this branch for the global assim test case, LDAS.rc contains the following line:
MWRTM_FILE: /discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/mwRTM_param.nc4
In the nightly test with develop, LDAS.rc instead contains this line:
LANDASSIM_INTERNAL_RESTART_FILE: ../input/restart/mwrtm_param_rst
When I (i) manually edit LDAS.rc after setup to look like that from the nightly test and (ii) create a link:
ln -s /discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/mwRTM_param.nc4 [...]/input/restart/mwrtm_param_rst
then the run failure goes away and I get 0-diff results. I haven't figured out yet how to change ldas_setup.
PS: Just to confirm, the commit before the ldas_setup changes passes the global assim test case.

I am looking into it now...

MWRTM_FILE: /discover/nobackup/mathomp4/LDAS_Restarts/NGHTLY_TST_TV4000/mwRTM_param.nc4

What is your version of GEOSldas that has this in the LDAS.rc? I thought we remove it long time ago. Can you show me your test forlder?

Oh, the night test should fail because we need to change the input file's "MWRTM_FILE"  to "MWRTM_PATH"

ldas_setup now can add vegopacity file. "MWRTM_FILE" in the input script file for ldas_setup should be changed to "MWRTM_PATH" which may contain "mwRTM_param.nc4" and "vegopacity.bin" . @gmao-qliu , would you help to test the ldas_setup?

@gmao-rreichle @gmao-qliu  above is the information after I commit ldas_setup. I think Qing has test it.

@weiyuan-jiang:  Yes, the problem is with the config of the LDAS_GLOBAL/assim test case, which does not yet reflect the intentional interface change from MWRTM_FILE: to MWRTM_PATH:.  It's very obvious after looking at this fresh this morning and with hindsight.  I was too tired and there were too many other things going on when I tried to sort this out on Friday afternoon and evening.
Having said that, it would be good to adjust ldas_setup so it processes the MWRTM files exactly like the bcs files (see #533).  Would you have time today to take a look?

Now the new push change the interface again. The input file should contain BCS_RESOLUTION. It will add to BCS_PATH or MWRTM_PATH to obtain the real paths of the BCS and mwRTM. @gmao-qliu @gmao-rreichle

The most recent commits improve the documentation and fix no-data-value problems with the new vegopacity export variable.
Related to the latter, the vegopacity.bin file:

must use MAPL_UNDEF (1.e15) as the no-data-value (b/c of MAPL_ReadForcing()) and
should not contain small negative values (around -1.e-10).

I verified that the branch is 0-diff against develop in the nightly LDAS_GLOBAL/assim test (after suitably changing the global.assim.exec file to reflect the interface changes, ie, BCS_PATH, BCS_RESOLUTION, MWRTM_PATH).
I also verified that the branch runs with mwrtm parameters from the SMAP L2_SM_P_E product (mwrtm_param.nc4 and vegopacity.bin) in the configuration of the nightly LDAS_GLOBAL/assim test.  As expected, this run is not 0-diff against develop.


/keybase not created, fuse not mounting

I installed keybase for arch linux using the recommended yaourt instructions, but the KBFS was not created nor mounted. ls shows now keybase in / . I can't access keybase encrypted things or keybase public things. I tried reinstalling and executing run_keybase again, but even though the ANSI squirrel says "mounting /keybase" the opposite has happened.
my log id: 87ab8c64e174c58aeb11d81c

Are you running a custom kernel without the FUSE module enabled? And is /keybase empty (it needs to be)?

I am not using a custom kernel on this machine. /keybase must be empty because /keybase does not exist. do I need to create /keybase?
If so, with what permissions? Do I need to enable a systemd service to allow kbfs tto run at startup for the fuse mount to function?

I see two errors in your log.  From November 28:
2 2016-11-28T19:20:55.548664 ▶ [DEBU kbfs main.go:108] 005 Mounting: /keybase
3 2016/11/28 19:20:55 mount helper error: fusermount: mountpoint is not empty
4 2016/11/28 19:20:55 mount helper error: fusermount: if you are sure this is safe, use the 'nonempty' mount option

From December 15:
27 2016-12-15T11:49:18.544404 ▶ [DEBU kbfs main.go:111] 005 Mounting: /keybase
28 2016-12-15T11:49:18.547164 ▶ [DEBU keybase login_state.go:920] 006 + LoginState: Running request loop
29 2016/12/15 11:49:18 mount helper error: fusermount: fuse device not found, try 'modprobe fuse' first

On november 28th, I attempted manual creation of the keybase folders, hoping to "force" keybase to recognize /keybase. Today (dec15), I eliminated /keybase before mounting. I ran modprobe fuse with output
modprobe: FATAL: Module fuse not found in directory /lib/modules/4.8.11-1-ARCH
I already have the most up-to-date version of fuse installed. Do I need to reboot for the hooks to work?

It looks like your kernel is misinstalled somehow, since it should contain the fuse module and that modprobe line should work.

Agreed with @cjb, we assume that FUSE is installed and loaded on all the distros we support, and the run_keybase script doesn't do anything to detect when that's not the case. Apologies for not reporting errors from that script more cleanly though. (It starts services in the background, and sends their output to the logs, so it's a little tricky to collect errors at that point.)
Is it possible you upgraded the kernel on your machine without restarting it? Whenever I have problems with "kernel stuff" I always suspect that first.

After reboot I get 7a240f88a99a2ffe62762e1c
It says that the /keybase mountpoint does not exist. Do I need to manually make the directory, and, if so, with what permissions?

Hmm. Take a look at /opt/keybase/post_install.sh. That should've been installed as part of the keybase-bin package, and it should've been run by the post-install hooks. It creates the directory like this:
if mkdir /keybase &>/dev/null ; then
  chmod 777 /keybase
fi

Which is to say "try to create /keybase, and if we just created it successfully, change its permissions to 777." So you could just run the same chmod command now. But the more concerning part for me is why that didn't happen as part of installing the package. Is there any chance you deleted the folder somehow after installing? If you don't have any theories, I'm curious what happens if you reinstall keybase-bin? Any interesting output from that?

open sudo mkdir /keybase, run_keybase returns error (user does not have permission)
bafflingly, attempting sudo run_keybase causes such an enormous problem that sudo ls /keybase freezes my shell. I'm manually stopping the keybase programs, completely deleting /keybase, and awaiting further orders.

Yeah sudo run_keybase is going to cause terrible problems. You're going to have a FUSE mount for root, and then try to read it as your regular user. That said I'm afraid I didn't understand the first command you said you ran. Could you write out each command and its output for me on separate lines, like this:
$ echo command one
command one
$ echo command two
command two

Also, could you please give me the output of mount? Finally, have you tried restarting your machine yet?

I tried restarting my machine. I was able to make it work after I manually created the keybase folder with the 777 permission.

But a new issue arose when trying to install keybase for another user. I share my Linux installation with my brother, and we dial into via SSH. We wanted to try to have both of us signed into keybase at the same time, and it worked for about 90 seconds. Now, neither one of us has access to our own files, and root can not access, delete, or unmount any part of /keybase.

We don't have much support for multiple users accessing /keybase right now. I'm not sure how the 90 seconds effect came about, but in general I think your issues are expected when one user accesses another user's FUSE mount.
I think it's expected that root shouldn't be able to read another user's files in /keybase. (Other than of course by running commands as that user.) I'm surprised that sudo umount /keybase doesn't work for you though. Does fusermount -u /keybase also not work?
If you want to do some custom scripting, it's possible for you both to use Keybase as long as you don't use the same mount point. If you take a look at the /usr/bin/run_keybase script, you'll see two places where we use the path /keybase, once as an argument to fusermount -u and once as an argument to kbfsfuse. If you copy that script and change both of those paths to something like $HOME/keybase, and run your custom script for startup instead of the global one, you should both be able to run at the same time. (You will need to disable ~/.config/autostart/keybase_autostart.desktop as described in that file, and you'll probably also need to mkdir the mount point you choose.)
Apologies for not having an easy environment variable you can set to make this happen. I'll put up a PR for doing that.


Improve peripheral naming consistency

Right now we have two naming conventions.

Mcp4725.yaml with name Mcp4725
MCP9808.yaml with name MCP9808
Tcs3725.yaml with name TCS3725

We need to pick one and update tests and stuff.

Hey @Fleker, I would like to take this one, may I ?

Is it ok for you is we take the "all uppercase" naming convention ?

I made the PR #88 for this issue

Yeah that's fine.


Filter list boxes: Users lose context on the option after selecting it

Description
Tracy Note: This ticket is related to https://github.com/CodeForPhilly/clean-and-green-philly/issues/631 & probably would be fixed with that refactor to pull out the selected pills from the dropdown.
When selecting an option in the listbox "Neighborhoods" , "Community Organizations" or "Zoning", we remove the option from the list, and put it in a pill form. When a screen reader user selects this option, we do not give feedback about what happened to the option after selecting it. It just disappears in the list. This can potentially throw off screen reader users and would require them extra steps to investigate to what had happened with their selection.

DEMO: NVDA+FF. For this ticket, see 0:00-1:40  part of the demo
https://github.com/CodeForPhilly/clean-and-green-philly/assets/102739972/ade5b3b2-ca41-4165-ac9f-6bbbb8ca462c

Recommendation

Option 1: Keep them in the list, put a checkmark to visually distinguish that it's been selected. Announce the selected state.  Deselecting this would clear the pill. This would be the cleanest experience.
Option 2: Have a mechanism to announce that the option has been selected and removed from the list.

Hi, may I be assigned this ticket?

@zheyichn assigned!

Hi @bacitracin @marvieqa
I have one question. At 1:40 in the video above, what are the proper key(s) used to exit the dropdown list? I pressed Esc to leave the dropdown menu, but the selected items disappeared, leaving only one empty pill form as shown below. This issue persists whether or not I make any changes.

@zheyichn I don't have time to check on this right now, but this ticket is related to the bug you mentioned and calls out expected behavior https://github.com/CodeForPhilly/clean-and-green-philly/issues/631#issue-2296592210

Hey @zheyichn, if you haven't gotten too deep in this, I'd like to take this ticket back and work on it some more. It turns out that we have 5 other filter related tickets created, and I want to make sure they are all aligned in behavior before people start working on them.

Hey @bacitracin So far, I have made only a few changes to implement option 1 as stated above. I believe the issue with exiting the dropdown is out of the scope of this task. That sounds good—I'll hold off on further work for now. Let me know when it's ready. Thanks!

@zheyichn Cool, sorry for the confusion! I've put "Blocked" on all the tickets in review so it shouldn't happen again. I'll keep in mind that option 1 was doable/we have work done already.

@bacitracin where does this issue stand? should we rewrite and reissue, keep it as is, or close as unplanned?

@nlebovits This one would be likely be fixed by the refactor suggested in https://github.com/CodeForPhilly/clean-and-green-philly/issues/631. I'll close this so people don't work on it on its own., it's a bit of a dupe ticket.

Closing since this issue will be tackled in a different ticket.


Do things to update_time from Account, Shop, Product, etc

are they not updated when updated?

they do?

they don't?

Sol lies here I think
https://dev.mysql.com/doc/refman/8.0/en/show-columns.html

@Extra
Any additional information that is available about a given column. The value is nonempty in these cases:
auto_increment for columns that have the AUTO_INCREMENT attribute.
on update CURRENT_TIMESTAMP for TIMESTAMP or DATETIME columns that have the ON UPDATE CURRENT_TIMESTAMP attribute.
VIRTUAL GENERATED or STORED GENERATED for generated columns.
DEFAULT_GENERATED for columns that have an expression default value

by adding default_generated, pass value to the column produce error.


left only one version of the method ontology

in hbp_measurement_methods_ontology replaced the prefix and the url, so that it corresponds to the current practice
Also:
git rm hbp_method_ontology.ttl hbp_domain_aspect.ttl
git mv hbp_measurement_methods_ontology.ttl hbp_method_ontology.ttl

Make clear in the commit message that domain_aspect ontology is also deleted with this commit.

domain_aspect ontology is not deleted with this commit!


libc: minimal: fix fwrite()

The implementation of fwrite() in the minimal libc does not increment
the source pointer, and thus always print the same character.

Codecov Report

Merging #7625 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7625      +/-   ##
==========================================
+ Coverage   55.09%   55.25%   +0.16%
==========================================
  Files         474      468       -6
  Lines       51786    51792       +6
  Branches     9937     9909      -28
==========================================
+ Hits        28530    28618      +88
+ Misses      19304    19261      -43
+ Partials     3952     3913      -39

Impacted Files
Coverage Δ

kernel/stack.c
67.3% <0%> (-27.29%)
:arrow_down:

kernel/msg_q.c
77.77% <0%> (-18.06%)
:arrow_down:

kernel/init.c
68.42% <0%> (-12.29%)
:arrow_down:

kernel/mempool.c
83.11% <0%> (-9.43%)
:arrow_down:

kernel/pipes.c
83.62% <0%> (-7.42%)
:arrow_down:

subsys/net/ip/trickle.c
82.6% <0%> (-5.8%)
:arrow_down:

tests/ztest/include/ztest_assert.h
29.41% <0%> (-3.93%)
:arrow_down:

tests/net/trickle/src/main.c
91.42% <0%> (-2.86%)
:arrow_down:

tests/net/tcp/src/main.c
49.59% <0%> (-0.88%)
:arrow_down:

subsys/net/lib/app/net_app.c
42.7% <0%> (-0.45%)
:arrow_down:

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50990cd...0687791. Read the comment docs.


Call intermittent checker

Part of servo/servo#12629

This change is

You'll also need to update buildbot/master/files/config/master.cfg to add new Buildbot Builders so Buildbot knows to schedule + run the jobs.

@asajeffrey I think you wanted the intermittent checker to run nightly instead of on each build, right?

Indeed, we're running the intermittents 300 times each!

r=me after squash and the servo/servo PR lands.

Squished.

servo/servo#12629 landed.
@bors-servo r+

:pushpin: Commit 21d29e9 has been approved by aneeshusa

:hourglass: Testing commit 21d29e9 with merge 57e57c6...

:boom: Test timed out

@bors-servo r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 21d29e9 has been approved by aneeshusa

@bors-servo retry

:hourglass: Testing commit 21d29e9 with merge 5813ae5...

:broken_heart: Test failed - status-travis

@bors-servo retry

#467
#465

:hourglass: Testing commit 21d29e9 with merge 6bcf41e...

:sunny: Test successful - status-travis


Links to Zulip messages should open in app.

In a long running topic, it is sometimes helpful to link back to an earlier comment. Currently this can be done by copying and pasting the externally accessible URL for the post, but this is annoying because it opens a browser window for users of the stand-alone apps. Alternatively, the old post can be quoted, but that's not the greatest solution either.

Yeah, I was confused because we actually changed that target=_blank thing to no longer be a problem while I was on paternity leave, so I didn't know :).
@Be-ing given that change, do you think there's still an issue here?  I'm wondering if we should close this completely or open a more focused issue on what remains.

Closing under the assumption that my analysis there was correct; feel free to correct if I missed something @Be-ing :).


fix a few typos in docs

Hey Martin, thank you for the PR!
No worries for the Travis CI tests failure, this is due to a tensorflow mismatch issue between the C library downloaded from the website and the tensorflow source code - go side - of the repo.
I just have to fix the .travis.yml - thanks again for the PR, it made me found this problem


Unable to process task

Hi, Thanks for this great plugin.
I want use this plugin but i can't. When run gruntfile.js i get an error.
Please help me.

Verifying property bake.build exists in config...ERROR

Unable to process task.
Warning: Required config property "bake.build" missing. Use --force to continue.

Hi and thank you for using grunt-bake!
The error you described is likely to be caused by a wrong configuration in your Gruntfile.js. Please verify that you have loaded grunt-bake grunt.loadNpmTasks( "grunt-bake" ); and that you have set up the grunt-section with task build, as written in the readme:
grunt.initConfig( {
  bake: {
    build: {
      options: {
        ...
      },
      files: {
        ...
      }
  }
}

Thank. My problem was resolved.


Ubuntu version hard-coded in, causes error searching for release file

Describe the bug
When creating a custom Linux VM I am using Ubuntu 20.04. Within the VM I get an error relating to there being no Release file. (Unfortunately I no longer have the actual error).
The fix was to edit the apt_sources_config.yml to use 20.04 instead of 18.04.
Edited line:
deb [signed-by=/etc/apt/trusted.gpg.d/microsoft.gpg] ${nexus_proxy_url}/repository/microsoft-apt/ubuntu/20.04/prod $RELEASE main
Steps to reproduce

Create custom Linux VM image
Create VM
Manually run the vm_config.sh file and see error looking for Release file
Edit the apt_sources_config.yml to use 20.04 instead of 18.04.

Let's look at making this release agnostic. I'll take a look when have some time.

This has been addressed now with release v0.17.0


"An error occurred: fetch is not a function" while running a custom LLM

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Windows 10
- Continue version: v0.8.60
- IDE version: VSCode 1.95.3 (latest)

Description
I have implemented a custom LLM that I use to connect to a custom company GPT endpoint (API is not compliant with standard OpenAI API).
I was inspired by the:
https://github.com/continuedev/continue/issues/2250#issuecomment-2348004867
Everything used to work as intended but recently I experienced the following error:
An error occurred: fetch is not a function
It seems to me that this might be related to the:
https://github.com/continuedev/continue/pull/2935
In the:
core/config/types.ts
the CustomLLM does not specify the signal: AbortSignal so perhaps it might be causing my issue?
export interface CustomLLMWithOptionals {
    options: LLMOptions;
    streamCompletion?: (
      prompt: string,
      options: CompletionOptions,
      fetch: (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>,
    ) => AsyncGenerator<string>;
    streamChat?: (
      messages: ChatMessage[],
      options: CompletionOptions,
      fetch: (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>,
    ) => AsyncGenerator<string>;
    listModels?: (
      fetch: (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>,
    ) => Promise<string[]>;
  }

  /**
   * The LLM interface requires you to specify either `streamCompletion` or `streamChat` (or both).
   */
  export type CustomLLM = RequireAtLeastOne<
    CustomLLMWithOptionals,
    "streamCompletion" | "streamChat"
  >;

config.ts
export function modifyConfig(config: Config): Config {
  config.models.push({
    options: {
      title: "Custom LLM",
      model: "Custom LLM",
      requestOptions: {
        caBundlePath: "<PATH>"
      }
    },
    streamCompletion: async function* (
      prompt: string,
      options: CompletionOptions,
      fetch
    ) {
      try {
        const apiKey = "<API_KEY>";
        if (!apiKey) {
          throw new Error("API key is not set.");
        }

        const response = await fetch("<CUSTOM_COMPANY_ENDPOINT>", {
          method: "POST",
          headers: {
            "Content-Type": "application/json",
            "Authorization": `basic ${apiKey}`,
          },
          body: JSON.stringify({
            model: "gpt-4o",
            messages: [
              { role: "user", content: prompt },
            ],
            stream: false,
          }),
        });

        if (!response.ok) {
          const errorText = await response.text();
          throw new Error(`HTTP Error ${response.status}: ${response.statusText}\n${errorText}`);
        }

        const data = await response.json();

        if (data.choices && data.choices.length > 0) {
          const content = data.choices[0].message?.content;
          if (content) {
            yield content;
          } else {
            throw new Error("The response does not contain content.");
          }
        } else {
          throw new Error("The response does not contain choices.");
        }

      } catch (error) {
        console.error("An error occurred in streamCompletion:", error);
        yield `An error occurred: ${error instanceof Error ? error.message : String(error)}`;
      }
    },
  });
  return config;
}

To reproduce

Create a CustomLLM model and try to  use the chat window.

Log output
ERR [Extension Host] An error occurred in streamCompletion: TypeError: fetch is not a function
	at CustomLLMClass.streamCompletion [as customStreamCompletion] (<user_path>\.continue\out\config.js:42:32)
	at streamCompletion.next (<anonymous>)
	at CustomLLMClass._streamComplete <user_path>\.vscode\extensions\continue.continue-0.8.60-win32-x64\out\extension.js:538324:28)
	at _streamComplete.next (<anonymous>)
	at CustomLLMClass.streamChat (<user_path>\.vscode\extensions\continue.continue-0.8.60-win32-x64\out\extension.js:84625:30)
	at async llmStreamChat (<user_path>\.vscode\extensions\continue.continue-0.8.60-win32-x64\out\extension.js:541134:23)
	at async mh.value (<user_path>\.vscode\extensions\continue.continue-0.8.60-win32-x64\out\extension.js:548054:29)

cc @sestinj as he was more involved in the PR you referenced (https://github.com/continuedev/continue/pull/2935). It does seem plausible /likelythat the issue is with the AbortSignal as you described.

Hi!Something new about issue?I have same problem with my custom LLM:
An error occurred: fetch is not a function


The pybtex module has the errors.enable_strict_mode method changed to…

It tries one version of the command, and it that throws and exception, it tries another.

I refactored this project (#6), and remove pybtex.enable_strict_mode().
Do you think this version detecting of pybtex is needed for the refactored version?

I don't think its really necessary. It's your call if you want the user to see pybtex errors or not.
But it does make things easier to debug, and most latex end users can code python, so there's a good chance that they will contribute back if you make it easier for them to do so.


python312Packages.aiojellyfin: 0.10.0 -> 0.10.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.homepage for python312Packages.aiojellyfin is: https://github.com/Jc2k/aiojellyfin
meta.changelog for python312Packages.aiojellyfin is: https://github.com/Jc2k/aiojellyfin/blob/refs/tags/v0.10.1/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.10.1 with grep in /nix/store/dm0bgblfax6amn358jp2w3qlhal7skvp-python3.12-aiojellyfin-0.10.1
found 0.10.1 in filename of file in /nix/store/dm0bgblfax6amn358jp2w3qlhal7skvp-python3.12-aiojellyfin-0.10.1

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

home-assistant-custom-components.mass
music-assistant
python311Packages.aiojellyfin
python312Packages.aiojellyfin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dm0bgblfax6amn358jp2w3qlhal7skvp-python3.12-aiojellyfin-0.10.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.aiojellyfin https://github.com/r-ryantm/nixpkgs/archive/f736faead85d4da25cd1dc1061eb03095753929d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f736faead85d4da25cd1dc1061eb03095753929d#python312Packages.aiojellyfin

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dm0bgblfax6amn358jp2w3qlhal7skvp-python3.12-aiojellyfin-0.10.1
ls -la /nix/store/dm0bgblfax6amn358jp2w3qlhal7skvp-python3.12-aiojellyfin-0.10.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 120m and timed out

Maintainer pings
cc @mweinelt for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Breaks music-assistant tests.

Done in https://github.com/NixOS/nixpkgs/commit/863ae0703ded14d281600ef70ecc1e7564672412.


Enable / Disable multi level tags

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/42314
PROPOSAL: N/A
Tests / QA Steps

Enable tags on a workspace
Create several tags. Confirm that bulk enable and disable works by checking the top checkbox and clicking the Selected button.
Enable the accounting feature and connect to QBO.
Go back to the Tags screen and check that Classes and Customers/Projects are now imported as tags
Click Classes. Click the top checkbox. Click the Selected button and click Disable
Check that all tags in Classes are disabled
Do the same thing but enable tags this time. Check that all tags in Classes are enabled back.
Click Customers/Projects. Do the same thing as above. Confirm that they work.

Offline tests

Follow the same steps from Step 1 to Step 2 offline  and confirm it works
Do Step 3 while the device is online
Follow Step 4 to Step 8 offline and confirm it works
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
Tested this on web desktop
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/98560306/cd349461-7bf2-4bb1-92de-e52bbd4daa5e

MacOS: Desktop

@hayata-suenaga Can we merge this PR first https://github.com/Expensify/App/pull/42149? So we can cover the setWorkspaceTagEnabled call in TagSettingsPage

Changed the base branch to the QBO freeze branch. We can merge there anytime

Can you please fix the lint issue

ah I didn't realize that. thank you for letting me know 😄 I'll update my PR

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/16493223/2f0d4854-524a-43c1-9b4f-687de4e99381

Android: mWeb Chrome

Networking issue

iOS: Native

https://github.com/Expensify/App/assets/16493223/0b110a0f-9d73-4036-9068-565095700087

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16493223/b4532f11-875d-4ffb-bd71-07eeebb7d1ad

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16493223/462905ff-1c64-4fcc-af6f-e6ffca33ce08

MacOS: Desktop

https://github.com/Expensify/App/assets/16493223/8d6d5102-21ab-4e63-96a3-fbf4f5ada47a

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

#42315 failing with #42314 in desktophttps://platform.applause.com/services/links/v1/external/03a18aec5fd806bbc900f164f8aeea0f398fff1b91024577f20675ea458b776d

@kavimuru thank you for letting me know is the issue only happening on desktop?

@hayata-suenaga This is happening only in desktop, retested.
https://github.com/Expensify/App/assets/43996225/9385c750-2153-4b13-9b89-f75f055c6a3b

I believe this is a pusher related issue. will post this in Slack

https://expensify.slack.com/archives/C036QM0SLJK/p1717443889264419?thread_ts=1717422872.999129&cid=C036QM0SLJK

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat: edit user profile / account

What does this pull request aim to achieve? 💯
Add edit user profile / edit user account
API endpoint added (first draft version basic implementation)
todo: check URL's input format & sanitization
Will add frontend too before merging

Some work I've been doing also relates to these 2 big issues
#462 to clean up forms:
I've done some work on these form components, and currently it seems that the components like  BaseInput and InputWrapper that are used on Login / Signup and Create Profile can probably be merged and replaced by the FormInput in which I've added some more functionality here, but needs to be checked for the whole application
#490 to improve the state management and look at useage of Redux, useReducer hooks and Context API:
Here I've been able to reuse the userReducer logic for user profile and use the Context API with a HOC wrap a provider around these pages, but this doesn;t seem sufficient yet, it would be better to integrate this at a global level after login with the user, and it seems like we might be trying to reinvent redux here which makes me think maybe redux isn't so bad after all (for example: it helps to prevent unneeded renders for state updates and also helps to combine mutliple reducers like sstate slices).

Hi @robinv85
I have questions about frontend (let me know, if it's not in the scope of this PR)

When I navigate between Profile Information/ Account Information - On Account Information Avatar is not shown, only bottom of the icon is shown:

In zeplin: there is email field (disabled) on the Account Information screen.

When I select edit icon from Profile page:
Edit Account Information has a href="/edit-profile". Shouldn't it have href="/edit-account"?:

Could we move Don't show my address checkbox a little on the left like in the design:
https://app.zeplin.io/project/5ecaed1b2522d9280f1a4792/screen/5ed0333ed0ac739bb73c36df

Hi @galeza
thanks for already testing, it's not completely ready yet, still draft PR

about point 1

The problem is because if you refresh the page, currently the "session" data is lost, so the avatar with the initials is not properly rendered. How I want to fix this in the first place:

make sure this page is not accessible when not logged in (will redirect back to login page)
fix the session storage so you can refresh and keep the data

And then next steps probably we can also fix that Avatar component to make it more robust if no data is passed, and we also have to fix that for image uploads here but i think it's a separate github issue that also needs backend work.

I asked about this on slack and seems like the design is not accurate, same for location fields, so i don't think it has to completely match the current design on zeplin, we can add email change later after MVP

didn't notice that, I will check :)

The idea of adding the url base for social accounts is good but we need to either include the base url anywhere the link is used OR pass the base with the username to the backend (so https://www.linkedin.com/in/joshmorel/ instead of joshmorel)

Right now href="joshmorel" which is no good.
I'd prefer sending the passing the base url when updating as we there there are fewer places we need to worry about it.

@joshmorel yeah I'm working on updating the backend too so it uses the same regex validations, and only stores the username part, it's pretty straightforward to add the URL part of the social networks... I didn't really consider this in scope here but I guess it's not much work to fix it on view profile too

I think this should be ready for review now but there are 2 related problems:

location component doesn't always work, but it's quite complex and also used on the create-profile without initial value so maybe it needs to be fixed in a separate pull request
view profile also might not be working with these social URL's and we also need to add icons and maybe some more finishing touches but naybe better also in separate PR

ok yeah just doing some finishing touches before I merge and we can fix location input on a separate issue


Deprecate boundary_slice kwarg: kind following pandas

[x] Towards #8036
[x] Tests added / passed
[x] Passes black dask / flake8 dask / isort dask

Expect 38 failures on upstream on this branch

phew ok this one is good to merge.


Can we show or hide specific time slots in week view

Clear and concise description of the problem
hello! This is Rishabh !
i am trying to show some specific time slots in a week view but i am not able to find the correct solution. I have tried the min and max props and these are helpful , if we wanted to show a range of timeslots but my requirement is to show specific timeslots ( in my case i wanted to show only 2-3 timeslots but these are not in consecutive order) so in that case min and max props approach failed.
To achieve this thing i also tried to play with html i made all timeslots display : none except the timeslots in which event happend
let timeslotColumns = document.querySelectorAll(".rbc-time-column");
timeslotColumns.forEach((e) => {
  let childrens = e.children;
  Array.from(childrens).forEach((e, i) => {
    if (e.classList.contains("rbc-timeslot-group"))
      e.style.display = "none";
    e.classList.add(`timeslot-${i}`);
  });
});
const a = document.querySelectorAll(".timeslot-17");
console.log(a);
Array.from(a).forEach((e) => {
  e.style.display = "block";
});

but this logic failed because after doing this the event is not showing properly

can anyone help me to solve this problem
Suggested solution
          min={minTime}
          max={maxTime}

Alternative
No response
Additional context
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[ ] I'm willing to open a PR

@Rishabh-Jain-Rj What, exactly, is it you are trying to accomplish with these 'slots' you are trying to display? Give us the use case of what it is you are trying to achieve.

We have huge data of students which we show in weekly view. We want to merge rows and hide rows to get more spacing. We are looking for a feature where we can provide custom time slots only to display weekly views.
For example,
Use Case 1: by default, all time slots are hidden, and if we add Mon 12-1 PM, it will show only 1 row of time slots which we can achieve using min and max.
Use Case 2: We added Tues 2-3 PM now we want to show only 2-time slots from the left panel 12-1, and 2-3 PM. The benefit of doing this we have a custom interface in the cell which we really need a big space.
I hope I have clarified the use cases.

@utkarshsystem No, I'm afraid I still do not understand what it is you are ultimately trying to accomplish.
If you set timeslot: 1 and step: 60, then there are no grid lines in an hour range. That said, the event you place in that area would only take up all of that height if the start and end also covered that entire hour long block.
In my own application, events can be as short as 15 minute, or last multiple days. I only show abbreviated info related to my event (an appointment) (like the person it is for and the start and end times) in the calendar/TimeGrid view. For my users to get an expanded view of all of the event's (appointment's) details, the user selects the event, which shows that expanded detail in a side panel. That detail could be as long as I want, and I have very detailed display logic around those details, completely separate from all the Big Calendar logic. A Master/Detail view, if you will.

@Rishabh-Jain-Rj Currently there is no native support for such a function. You may have to write a custom view to accomplish what you're asking.

@Rishabh-Jain-Rj I get what you are saying. He basically wants to show some specific timeslots based on if they have events or not. Let's say the usual timeslot range is 12:00 PM to 12:00 AM but events are present only for 02:00 PM to 03:00 PM and 08:00 PM to 09:00 PM so he would want to show only those slots with maybe interpolation dots going on showing that there are other slots between them but they are not visible or something. @cutterbl Can I try to implement it?

@usmanabdurrehman You can try, but you would definitely need a custom view, and probably need some custom layout algorithm or something...

@cutterbl Cool. Let me see.

I have the same question


bug: Issue with a server that does not send player counts or samples

Describe the bug:
Library is incompatible with a server that does not send player count or sample.
Code:
const mcUtil = require("minecraft-server-util");

const mcUtilOptions = {
    timeout: 7500,
    enableSRV: true
};

mcUtil.status("removed IP", portnumber, mcUtilOptions).then(
   (result) => console.log(result)
).catch(
(error) => console.log(error)
);

Error:
TypeError: Cannot read properties of undefined (reading 'online')
    at Object.<anonymous> (/home/bartek/Desktop/terracraft.js/node_modules/minecraft-server-util/dist/status.js:112:46)
    at Generator.next (<anonymous>)
    at fulfilled (/home/bartek/Desktop/terracraft.js/node_modules/minecraft-server-util/dist/status.js:5:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Expected behavior:
The server to return the status successfully but without player count or sample information.
Additional context
My private server does not send any player count or sample information. This seems to upset the library.

Thank you for bringing this issue to my attention. I did not realize that Minecraft allows you to not send a player count. I’ll likely be implementing a fix tomorrow night in this library as well as my Go library for retrieving Minecraft statuses.

Apologies for a late reply, but unfortunately I will not be fixing this issue on this library, as the library will be deprecated soon due to issues with reliability with the standard networking library in Node.js. I've posted more information about this on the README.

All good, I will maintain my own version of the library.


NT: Allow the definition of multiple imagePullSecrets for initContain…

…ers and sidecarContainers

Going to wait for Chaice to review this, just to double check everything. Also I have a work-around merged and I have no idea how to actually deploy this change


Create SECURITY.md

Adds SECURITY.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.275%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
67229

Relevant Lines:
78838

💛  - Coveralls


Support publishing to Azure China

What would you like to be added:
Azure - just like AWS - is maintaining a separate partition in China, which "is a physically separated instance of cloud services" (ref). Since Gardener will support operations in Azure China in the future, Garden Linux needs to be published there among all the other cloud platforms.
Alignment with @shaoyongfeng may/will be necessary.
Why is this needed:
see above

TOOO:

[ ] Request Azure China subscription that can be used by GL team in order to create community image.

Az China Subscription request in: https://itsm.services.sap/srm?id=ticket&table=sc_req_item&sys_id=0175332beb3e0ad0b756f5d3dad0cdb3&view=srm


modify confusing description about building image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@MregXN please sign the cla

@MregXN please sign the cla

done.


[FEATURE]: As a user, I want results to show another image on hover

How can the project be improved?
The BaseResultImage component is able to show an image, but is not ready to show another on hover.
We would like to provide the possibility to show another image on result image hover.
How can this be solved?
Scenario
Given a shopper who is seeing a result
when the user hovers the result image
then the image is animated to show an alternative image
when the user stops hovering over the image
then the original image is shown
Proposed solution
We can create a computed property images that is calculated with the Result images filtered to exclude the images present in failedImages.
Then we can modify getImageSrc in this way:
get imageSrc(): string {
      return !this.hasEnteredView ?
        ''
        : this.hover && this.images.length > 1
          ? this.images[1]
          : this.images[0];
    }

And activate hover property when the user hovers the image.
Customizations supported
Provide a way to enable/disable the hover behavior, maybe with a prop flipImageOnHover, for example
Additional information
Alternative image
The alternative image to use will be the second in the Images array in the Result Type
If there is not any second image, and flipImageOnHover is enabled, nothing will happen when the user hovers.
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

I would like to work on this. Can you please assign this to me?

Hello @jatinmark, thanks for the offer!! We are trying to define better this task because we are struggling when deciding if we want to do this on the BaseResultImage component or use composition and do it in another. You can grab this and do a PR, but due to this decision,  you might take a path that is not ideal in the end. So you can take it if you want to have this on mind or take this other issue, easier, to begin with.

Closing this issue because we want to define it better to avoid contributors to work on an issue with poor requirements


[Bug] The job status is always initializing

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
java8
Scala Version
2.11.x
StreamPark Version
2.0.0
Flink Version
1.16.0
deploy mode
kubernetes-application
What happened
作业状态一直卡在 初始化中
Error Exception
No response
Screenshots
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi. This issus has been solved in #2579  , you can pull the latest code or or wait for the new version to be released to experience.


Failed to create control plane pods on disconnected cluster

hello,
I try to create a hypershift + kubevirt cluster on disconnected cluster.
i stuck on the stage when on the new namepsace cluster have the 4 pods:
capi-provider, cluster-api, control-plane-operator and ignition-server
after that it need to create more pods for the control plane but it didn't happend.
i don't see any log in the control-plane-operator pod that can help me.
infra OCP version: 4.9.12
cluster version that i try to up: 4.10.11
Thanks!

@nadavdolin please provide also the hypershift image version or at least the operator digest.

@nadavdolin can you tell whether there were any failures to pull images in the control plane namespace? (a list of events in that namespace may help)

The new version of hypershift is fix the problem, Thanks!

/close


Forking gists

I've just cloned a gist repository:
[tom@elbridge 788e00bd9293a3b05895]$ git remote -v
origin	https://gist.github.com/japaric/788e00bd9293a3b05895 (fetch)
origin	https://gist.github.com/japaric/788e00bd9293a3b05895 (push)

And I thought it'd be nice to be able to fork the gist + push to my fork using hub, as can be done with regular GitHub repositories. Alas:
[tom@elbridge 788e00bd9293a3b05895]$ hub fork
Error: repository under 'origin' remote is not a GitHub project

That's not a bad idea!


Update embedded-multi-geo.md

Adding another limitation: "Multi-Geo isn't available for Power BI Germany, Power BI China operated by 21Vianet, or Power BI for the US government."

@Alonbaram : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This pull request is for the Live branch. We can't merge to Live. Would you resubmit your changes to the master branch? Thanks.


Allow custom max summary length

Right now, the max summary length is hard-coded and is 3000. I think it would be nice to allow users to change that threshold if needed.

Thanks for the feedback @rusmux! Right now the token length is a limit from the OpenAI servers.  I did recently update the logic to allow for more tokens with the default model.
As a followup, I'm looking at more AI technique to allow breaking up longer changes as well!


Normative: Limit valid values for DurationFormats to match upcoming limits in Temporal

See #157
Upcoming revisions to Temporal will limit the valid values for Temporal.Duration. This commit applies the same limits on valid values for Intl.DurationFormat DurationRecords. Specifically: the absolute values of the values stored in each of the [[Years]], [[Months]], and [[Weeks]] fields cannot exceed 2^32, and the absolute value of the value obtained through converting the values in each of the sub-week fields to seconds and then summing them must not exceed 2^53.

TG2 approval: https://github.com/tc39/ecma402/blob/master/meetings/notes-2023-11-16.md#decide-if-upcoming-temporalduration-limits-should-have-an-impact-on-durationformat-157

2023-11-28: This PR achieved TC39-TG1 consensus.

Test coverage → https://github.com/tc39/test262/pull/3988

Updated to match limits currently set in Temporal. See: https://github.com/tc39/proposal-temporal/pull/2727#
@ptomato has pointed me toward https://github.com/tc39/proposal-temporal/pull/2727#discussion_r1408573795 for thoughts on implementation. He's also written a polyfill that implements the limits via string manipulation to run test262 tests against.
@ryzokuken @FrankYFTang

Note the text in Temporal PR 2727 was not the latest, Anba made some changes to it afterwards.

Note the text in Temporal PR 2727 was not the latest, Anba made some changes to it afterwards.

Just pushed a corrected version. Thanks for catching that!

Does this change mean BigInt math is not required (just like in Temporal)?

Could we do the following change to better match Temporal?

in ToDurationRecord change

24. If [IsValidDurationRecord](https://tc39.es/proposal-intl-duration-format/#sec-isvaliddurationrecord)(result) is false, throw a RangeError exception.

to
24. If IsValidDuration]( result.[[Years]] ,  result.[[Months]] ,  result.[[Weeks]] ,  result.[[Days]] ,  result.[[Hours]] ,  result.[[Minutes]] ,  result.[[Seconds]] ,  result.[[Milliseconds]] ,  result.[[Microseconds]] ,  result.[[Nanoseconds]] ) is false, throw a RangeError exception.

and change this part to be the exact text of
7.5.15 IsValidDuration ( years, months, weeks, days, hours, minutes, seconds, milliseconds, microseconds, nanoseconds )
from Temporal spec (probabaly except replacing the "to construct a Temporal.Duration" part to "to construct a DurationRecord"

Notice, with the PR , some test cases in
https://github.com/tc39/test262/blob/main/test/intl402/DurationFormat/prototype/format/precision-exact-mathematical-values.js
will be invalid and require changes to test the boundary condition and throwing/not throwing in the correct values


'Restart Conversation' should be 'New Conversation'

'Restart Conversation' Button should be called 'New Conversation'.
Had me confused for 3 days. Thank you very much.

@mewa1024 thoughts?

@tonyanziano Hmm. I'll label add "design" and "backlog" labels to keep an eye out for similar feedback. In the two user studies involving Emulator (pre-Build and post-Ignite), none of the participants seemed confused about the restart button, so I'm hesitant to change it without more feedback. Also the circular arrow icon is pretty common for "restart" and we've been using that icon since v3, so again, I'd like to get wait for more feedback.

#630 for a little more context.


fix: work-around long path issues on windows

Create a monkey-patch to get around the long filename issues on windows in the example.  If I understand how the yarn patch works, we shouldn't have to do this for each example, but we'll probably want to document this and/or do a round with the react-native-vision-camera folks to see if they are willing to fix this on their end.
The core of the patch is to use a custom build of ninja.exe and tell it that we can have long path names.  In order for this to work, you need to first enable long paths on windows. The quick way to do that is to run this reg file as admin and reboot.
The changes in the gradle file are under Windows-only build flags.  I verified that it works on both Windows and Mac (and I verified that it failed on mac if I didn't put in the protection.

Not sure why the ios build is failing. It might not be you

Yeah - I didn't touch the ios build at all (not that that's fullproof). If I'm reading the logs correctly, the error is
PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/runner/Library/Developer/Xcode/DerivedData/objectdetection-epvaeodgotlmjmbjzuuweyfalevk/Build/Intermediates.noindex/objectdetection.build/Debug-iphonesimulator/objectdetection.build/Script-C38B50BA6285516D6DCD4F65.sh (in target 'objectdetection' from project 'objectdetection')
2024-04-11T16:05:23.4787540Z     cd /Users/runner/work/react-native-mediapipe/react-native-mediapipe/examples/objectdetection/ios
2024-04-11T16:05:23.4788670Z     /bin/sh -c /Users/runner/Library/Developer/Xcode/DerivedData/objectdetection-epvaeodgotlmjmbjzuuweyfalevk/Build/Intermediates.noindex/objectdetection.build/Debug-iphonesimulator/objectdetection.build/Script-C38B50BA6285516D6DCD4F65.sh
2024-04-11T16:05:23.4789230Z error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

I've noticed when building the ios version of the example that I end up with changes to podfile.lock and project.pbxproj - it looks like Suki pulled in some changes with #41, so maybe that's a clue?

Not sure why the ios build is failing. It might not be you

Yeah - I didn't touch the ios build at all (not that that's fullproof). If I'm reading the logs correctly, the error is
PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/runner/Library/Developer/Xcode/DerivedData/objectdetection-epvaeodgotlmjmbjzuuweyfalevk/Build/Intermediates.noindex/objectdetection.build/Debug-iphonesimulator/objectdetection.build/Script-C38B50BA6285516D6DCD4F65.sh (in target 'objectdetection' from project 'objectdetection')
2024-04-11T16:05:23.4787540Z     cd /Users/runner/work/react-native-mediapipe/react-native-mediapipe/examples/objectdetection/ios
2024-04-11T16:05:23.4788670Z     /bin/sh -c /Users/runner/Library/Developer/Xcode/DerivedData/objectdetection-epvaeodgotlmjmbjzuuweyfalevk/Build/Intermediates.noindex/objectdetection.build/Debug-iphonesimulator/objectdetection.build/Script-C38B50BA6285516D6DCD4F65.sh
2024-04-11T16:05:23.4789230Z error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

I've noticed when building the ios version of the example that I end up with changes to podfile.lock and project.pbxproj - it looks like Suki pulled in some changes with #41, so maybe that's a clue?

Where are you seeing these log errors? I guess they are in the raw logs, is that how you found them?

Not sure why the ios build is failing. It might not be you

Yeah - I didn't touch the ios build at all (not that that's fullproof). If I'm reading the logs correctly, the error is
PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/runner/Library/Developer/Xcode/DerivedData/objectdetection-epvaeodgotlmjmbjzuuweyfalevk/Build/Intermediates.noindex/objectdetection.build/Debug-

Where are you seeing these log errors? I guess they are in the raw logs, is that how you found them?

The error is in the raw log file at line 46839. However, I found it by downloading the log archive (available from the gear icon from the build-ios results. That gave me a zip with more structured logs and I was able to drill down to the build_iod/8_Build example foriOS.txt log and find the error.
I just noticed that #61 failed the same job. And checking the log archives, it is failing in the same way, so it looks like we've got an intermittent error in our CI process (yuck). I'll do some digging on this today, but let me know if it's all right to run this job again to see what happened (I think you said there is a monetary cost per run)...

If this SO answer is accurate, it looks like this error stems from podfile.lock and manifist.lock being out of sync, which shouldn't happen if pod install has been run in the build environment.  Looking at the workflow file it appears that we won't run pod install if the pods are cached in either the turbo repro or cocoapods-cache.  But of course if those caches are working correctly we shouldn't need to run pod install.  I'm wondering if there is any possibility that one or the other of these mechanisms is mis-computing the hash that's used to decide if the pods are out of date?
One thing we could try is disabling one or both of those caches in the build system and see if this intermittent error disappears (we'd probably have to leave them off for a while).  I'm not familiar enough with these systems to know what and how much we're getting out of these caches (probably build speed, but maybe it's cheaper as well)?


Fixes #24. Adds new configurable option to not shrink wrap list items

Fixes #24. Adds new configurable option to not shrink wrap list items using S2ChoiceConfig.shrinkWrap or SmartSelect.single.choiceShrinkWrap/SmartSelect.multiple.choiceShrinkWrap.
If choiceShrinkWrap is true choices list will shrink wrap the choices, causing the list to resize based on the number of available choices, by default it will shrink wrap which was the default behaviour before this change.
Usage:
SmartSelect<T?>.single(
  choiceShrinkWrap: false
);

SmartSelect<T?>.multiple(
  choiceShrinkWrap: false
);

After fix if you pass SmartSelect.single.choiceShrinkWrap=false
https://user-images.githubusercontent.com/1186833/193662296-8283955b-db87-44f4-b5a7-8d0fa7359912.mp4

@vasilich6107 please merge this


reflow function if you have banged on the database as a map and want to flow changes to materialized views

can probably just set-diff and flow changes

as we just have keywords at the root of the db, not sure how this will work. Might be better to just use a custom map type


How to copy a session which can run with options?

Click to expand!
Issue Type
Others
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
2.8.0
Custom Code
Yes
OS Platform and Distribution
Windows 11
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Here's part of my code:
 def fun(self):
        self.lr=1e-2
        self.gen_optimizer()
        self.sess.run(tf.variables_initializer(self._optimizer.variables()))
        self.sess_backup=copy.copy(self.sess)
        #tf.train.Saver().save(self.sess,'tmp.ckpt')
        for u in range(0,self.num_test_users):
            print('Evaluating user',u,':')
            self.sess=copy.copy(self.sess_backup)
            #tf.train.Saver().restore(self.sess,'tmp.ckpt')
            #self.sess.run(tf.variables_initializer(self._optimizer.variables()))
            tmp1,tmp2,tmp3=self.fun2(12,u)
            for i in range(0,self.adapt_itrs): #local adaption
                self.adjust(i,tmp1,tmp2,tmp3,u)

I want to totally restore the session each time it enters the for loop. Just as what is commented out, I tried to use tf.train.Saver, but it can't totally restore: in the for loop, the model is trained several times using sess.run, and as time goes by, the running speed is slower and slower, which means that there must be redundant graphs stored in self.sess. So I tried to use copy.copy to copy the whole session as a backup to be restored later, but it reports that Run with options is not supported for this session. since the following steps use the feed_dict.
Standalone code to reproduce the issue
Here's a meaning less program but it can clarify my problem:
import copy
import tensorflow.compat.v1 as tf
import numpy as np
tf.disable_v2_behavior()
sess=tf.Session()
_input=tf.placeholder(dtype=tf.float32, shape=[100, 20], name="input")
_output=tf.placeholder(dtype=tf.float32, shape=[100, 1], name="output")
W = tf.get_variable(name="W", initializer=tf.truncated_normal(shape=[20, 1],
                                         mean=0, stddev=0.03),dtype=tf.float32)
output=tf.matmul(_input,W)
loss=tf.reduce_sum(tf.square(_output-output))
_optimizer = tf.train.AdamOptimizer(0.01)
optimizer = _optimizer.minimize(loss, global_step=tf.Variable(0, trainable=False))
input_mat=np.random.rand(100,20)
output_mat=input_mat@np.random.rand(20,1)
init=tf.global_variables_initializer()
sess.run(init)
_,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})
for i in range(5):
    '''
    Each time entering the loop, reset the session to the original one.
    Don't use tf.train.Saver, because it cannot totally restore the whole session since the running speed
    is still lower and lower.
    '''
    sess2=copy.copy(sess)
    _,l=sess2.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat}) #Reports "Run with options is not supported for this session."
    sess2.close()
sess.close()

Relevant log output
= RESTART: D:/programming/python/research_backup/AutoRec/Autorec_filmtrust_exp2/try.py
WARNING:tensorflow:From D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\compat\v2_compat.py:107: disable_resource_variables (from tensorflow.python.ops.variable_scope) is deprecated and will be removed in a future version.
Instructions for updating:
non-resource variables are not supported in the long term
Traceback (most recent call last):
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1377, in _do_call
    return fn(*args)
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1360, in _run_fn
    return self._call_tf_sessionrun(options, feed_dict, fetch_list,
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1453, in _call_tf_sessionrun
    return tf_session.TF_SessionRun_wrapper(self._session, options, feed_dict,
tensorflow.python.framework.errors_impl.UnimplementedError: Run with options is not supported for this session.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:/programming/python/research_backup/AutoRec/Autorec_filmtrust_exp2/try.py", line 26, in <module>
    _,l=sess2.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat}) #Reports "Run with options is not supported for this session."
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 967, in run
    result = self._run(None, fetches, feed_dict, options_ptr,
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1190, in _run
    results = self._do_run(handle, final_targets, final_fetches,
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1370, in _do_run
    return self._do_call(_run_fn, feeds, fetches, targets, options,
  File "D:\Users\myhac\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorflow\python\client\session.py", line 1396, in _do_call
    raise type(e)(node_def, op, message)  # pylint: disable=no-value-for-parameter
tensorflow.python.framework.errors_impl.UnimplementedError: Graph execution error:

Run with options is not supported for this session.

</details>

In TensorFlow, you can use the tf.Session.run() method to run a session with options. To copy a session with options, you can use the tf.Session.clone() method. This method creates a new session with the same settings as the original session, including the session options. For example:
# Create original session
original_session = tf.Session(config=tf.ConfigProto(allow_soft_placement=True))

# Clone the session
cloned_session = original_session.clone()

You can then use the cloned_session object to run operations and evaluate tensors, just like you would with the original session.
Alternatively, you can also create a new session with the same options as the original session by passing the options to the tf.Session() constructor when creating the new session. For example:
# Create original session
original_session = tf.Session(config=tf.ConfigProto(allow_soft_placement=True))

# Create new session with same options as original session
cloned_session = tf.Session(config=original_session.config)

It shows that sess has no attribute 'clone'. I replaced sess2=copy.copy(sess) with sess2=sess.clone(), and the error log is:
Traceback (most recent call last):
  File "D:\programming\python\research_backup\AutoRec\Autorec_filmtrust_exp2\try.py", line 25, in <module>
    sess2=sess.clone()
AttributeError: 'Session' object has no attribute 'clone'. Did you mean: 'close'?

The code runs, however, unfortunately, something changes next time when entering the for loop, since sess2.run consumes more time. This is my overall code:
import copy
import tensorflow.compat.v1 as tf
import numpy as np
from time import time
tf.disable_v2_behavior()
sess=tf.Session()
_input=tf.placeholder(dtype=tf.float32, shape=[10000, 20], name="input")
_output=tf.placeholder(dtype=tf.float32, shape=[10000, 1], name="output")
W = tf.get_variable(name="W", initializer=tf.truncated_normal(shape=[20, 1],
                                         mean=0, stddev=0.03),dtype=tf.float32)
output=tf.matmul(_input,W)
loss=tf.reduce_sum(tf.square(_output-output))
_optimizer = tf.train.AdamOptimizer(0.01)
optimizer = _optimizer.minimize(loss, global_step=tf.Variable(0, trainable=False))
input_mat=np.random.rand(10000,20)
output_mat=input_mat@np.random.rand(20,1)
init=tf.global_variables_initializer()
sess.run(init)
_,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})
tf.train.Saver().save(sess,'./')
t=time()
for i in range(10000):
    if (i+1)%100==0:
        print(time()-t)
        t=time()
    sess2=tf.Session()
    tf.train.Saver().restore(sess2,'./')
    _,l=sess2.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat}) #Reports "Run with options is not supported for this session."
    sess2.close()
sess.close()

The output is
3.409499168395996
6.0418853759765625
8.92863917350769
12.089853763580322
16.55520009994507
19.047667026519775
22.33715510368347
25.662793159484863

The code is absolutely correct, if it's time consuming, you can train your model on Google Colab or using Kaggle Kernels.
As the performance on these platforms is absolutely fantastic and is free of cost.

The code is absolutely correct, if it's time consuming, you can train your model on Google Colab or using Kaggle Kernels.
As the performance on these platforms is absolutely fantastic and is free of cost.

I think it has nothing to do with the training platform, since I have implemented it on multiple platforms, including my laboratory's server. The main problem is not that the program is time consuming. In fact, the speed is acceptable at first few iterations. But as time goes by, it becomes slower and slower. For the examplified program, I'm not aiming at reduce the costed time to something like 2 sec or 1 sec, instead, I want all printed time interval to be 3 seconds, just like the first one hundred  iterations.

I got it !!! Please try this optimized code:
import copy
import tensorflow.compat.v1 as tf
import numpy as np
from time import time

tf.disable_v2_behavior()
sess=tf.Session()
_input=tf.placeholder(dtype=tf.float32, shape=[10000, 20], name="input")
_output=tf.placeholder(dtype=tf.float32, shape=[10000, 1], name="output")
W = tf.get_variable(name="W", initializer=tf.truncated_normal(shape=[20, 1],
                                         mean=0, stddev=0.03),dtype=tf.float32)
output=tf.matmul(_input,W)
loss=tf.nn.l2_loss(_output-output)
_optimizer = tf.train.AdamOptimizer(0.01)
optimizer = _optimizer.minimize(loss, global_step=tf.Variable(0, trainable=False))
input_mat=np.random.rand(10000,20)
output_mat=input_mat@np.random.rand(20,1)
init=tf.global_variables_initializer()
sess.run(init)
_,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})

t=time()
for i in range(10000):
    _,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})
    if (i+1)%1000==0:
        print(time()-t)
        t=time()

tf.train.Saver().save(sess,'./')
sess.close()

@Kobe972
The Session was designed for TensorFlow v1. Session does not work with either eager execution or tf.function, and you should not invoke it directly. To migrate code that uses sessions to TF2, rewrite the code without it. See the migration guide on replacing Session.run calls and please refer to Functions, not sessions.
Thank you!

I got it !!! Please try this optimized code:
import copy
import tensorflow.compat.v1 as tf
import numpy as np
from time import time

tf.disable_v2_behavior()
sess=tf.Session()
_input=tf.placeholder(dtype=tf.float32, shape=[10000, 20], name="input")
_output=tf.placeholder(dtype=tf.float32, shape=[10000, 1], name="output")
W = tf.get_variable(name="W", initializer=tf.truncated_normal(shape=[20, 1],
                                         mean=0, stddev=0.03),dtype=tf.float32)
output=tf.matmul(_input,W)
loss=tf.nn.l2_loss(_output-output)
_optimizer = tf.train.AdamOptimizer(0.01)
optimizer = _optimizer.minimize(loss, global_step=tf.Variable(0, trainable=False))
input_mat=np.random.rand(10000,20)
output_mat=input_mat@np.random.rand(20,1)
init=tf.global_variables_initializer()
sess.run(init)
_,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})

t=time()
for i in range(10000):
    _,l=sess.run([optimizer,loss],feed_dict={_input:input_mat,_output:output_mat})
    if (i+1)%1000==0:
        print(time()-t)
        t=time()

tf.train.Saver().save(sess,'./')
sess.close()

Your code is different from my original code, since I restore the model at each beginning of the for loop. The problem appears to has to do with the computation graph. So I use tf.reset_default_graph at the begining of the for loop and rebuild variables. It works out, but rebuilding all variables each time I want to restore the session is inconvinient. It seems that there's not a satisfying solution in tensorflow.compat.v1

@Kobe972 The Session was designed for TensorFlow v1. Session does not work with either eager execution or tf.function, and you should not invoke it directly. To migrate code that uses sessions to TF2, rewrite the code without it. See the migration guide on replacing Session.run calls and please refer to Functions, not sessions.
Thank you!

Thanks! It looks sound. I'll try tf.2

@Kobe972
Thanks for the reply !
Please try in TF v2.x and let us know, Is the issue still persists.
Thank you!

@Kobe972 Thanks for the reply ! As mentioned above comment. Could you please update the status once you tried on TF v2.x and let us know, Is the issue still persists.
Thank you!

I solved the problem using a more sophisicated method which I mentioned before. I will try it if I am available.

@Kobe972
Could you please feel free to close the issue if it is resolved ?
Thank you!

Yes. Thank you!


Query reusing graph clause variable in statement pattern returns incorrect result

Current Behavior
running the following query for a particular dataset produces different results on rdf4j (4.2.3) vs graphdb (10.2.2 which uses rdf4j 4.2.3)
query:
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix owl: <http://www.w3.org/2002/07/owl#>

select distinct ?modeliri ?modelLabel {
    graph ?modeliri {
        ?modeliri a owl:Ontology ;
        rdfs:label ?modelLabel .
    }
}

data:
<http://something/s> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/2002/07/owl#Ontology> <http://something/s> .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-something"@en <http://something/s> .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-somethingelse"@en <http://somethingelse/c> .

Expected Behavior
graphdb appears to be correct.
Steps To Reproduce

rdf4j running on wsl docker, graphdb desktop on windows
insert quads:

<http://something/s> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/2002/07/owl#Ontology> <http://something/s> .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-something"@en <http://something/s> .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-somethingelse"@en <http://somethingelse/c> .

run query:

prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix owl: <http://www.w3.org/2002/07/owl#>

select distinct ?modeliri ?modelLabel {
    graph ?modeliri {
        ?modeliri a owl:Ontology ;
        rdfs:label ?modelLabel .
    }
}

expect 1 row on rdf4j 4.2.3 but received 2.

<http://something/s> | "s-label-something"@en
<http://something/s> | "s-label-somethingelse"@en

graphdb returns 1 (as expected)
<http://something/s> | "s-label-something"@en

Version
4.2.3
Are you interested in contributing a solution yourself?
Perhaps?
Anything else?
can maybe help debug/patch but would need some pointers on where to start to look.

if we remove the onotology check statement, rdf4j will return back one row:
query:
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix owl: <http://www.w3.org/2002/07/owl#>

select distinct ?modeliri ?modelLabel {
    graph ?modeliri {
        ?modeliri rdfs:label ?modelLabel .
    }
}

returns:
<http://something/s> | "s-label-something"@en

I can confirm this is present in 4.3.3 too (but not in Halyard push strategy :) @nguyenm100)

So the important pieces are that there are two graphs, and that the behaviour is correct when inferencing is off.

Hi Jerven, can you elaborate?  Is there a configuration I can use with vanilla rdf4j and workbench the query that gives me the result matching graphdb?
btw- I created a repo in graphdb w/o inferencing and still received only one result as above.

One thing worth checking is what happens if all the data is in the unnamed graph.
e.g.
<http://something/s> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://www.w3.org/2002/07/owl#Ontology> .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-something"@en .
<http://something/s> <http://www.w3.org/2000/01/rdf-schema#label> "s-label-somethingelse"@en .

Another query we should test:
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix owl: <http://www.w3.org/2002/07/owl#>

select distinct ?modeliri ?modelLabel {
    graph ?modeliri {
        ?modeliri a owl:Ontology ;
    }

    graph ?modeliri2 {
        ?modeliri rdfs:label ?modelLabel .
    }

    FILTER(?modeliri = ?modeliri2)
}

And maybe also:
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix owl: <http://www.w3.org/2002/07/owl#>

select distinct ?modeliri ?modelLabel ?g {
    graph ?g {
        ?modeliri a owl:Ontology ;
        rdfs:label ?modelLabel .
    }
}

I haven't tested anything but I believe the core of the problem may be that the variable binding the graph name and the subject name is shared. We have a long-standing issue (see https://github.com/eclipse/rdf4j/issues/514) with how context/named graphs are handled in the SPARQL engine, that may be causing the same problem here.

Part of the problem, from memory, is that in our current algebra representation, named graph scope is not represented as a separate algebra node, but as an attribute on each statement pattern node. To fix, we should probably refactor the algebra.

Given the bug is not present in my EvalStrategy impl, I'm going to guess there is a bug in StatementPatternQueryEvaluationStep. This could be verified by trying an older version, e.g. v3.7.4.

I've created a PR to reproduce this issue:
https://github.com/eclipse/rdf4j/pull/4677

I might have found the issue. There is some code to deduplicate the vars so that we don't insert the same value multiple times into the BindingSet. This code runs before we create the getters for each of the four spoc vars. So in this case we don't create the getter for the context var because it has been set to null during the deduplication. Moving the code for the getters above the code for the deduplication fixes this.

This has also been fixed in 4.3.4.


Determine whether initcontainer is needed through IPAConfig options

Some times we can build a http server out of cluster and we can also ues it to be as a image-server. And we can upload kernal and ramdisk into it. So I think we may don't need the init-Pod in Ironic's Pod.
I have modified the Ironic CRD
apiVersion: metal3.io/v1alpha1
kind: Ironic
metadata:
  name: ironic-server
spec:
  images:
    ipaConfig:
      ipaEnabled: true
      ironic: registry.paas/metal3-io/ironic:v1.0
      ramdiskDownloader: registry.paas/metal3-io/ipa-config:v17

@dhellmann Hi , Could you have a look my code.

Hi! Are you still interested in this change? I'll be doing some work around ramdisk settings and may as well include your change if you don't have time to update it.


Unbreak sendmail

The sendmail command was recently broken: https://github.com/camptocamp/puppet-postfix/pull/199#issuecomment-361594549
This Pull-Request unbreaks the sendmail command and relax some permissions which where changed from the default to more restrictive ones.

Tested; works here. Seems worth merging.