Doom does not work immediately with org-export-head

Hi,
I have tried a new installation of Doom emacs, but I met a difficulty with org-export-el that is org mode to blog exporter:
https://github.com/itf/org-export-head
The code that I put in config.el is here : https://github.com/itf/org-export-head/blob/master/blog.org
I works with emacs 27.1 and org-mode 9.4, but something is missing with Doom emacs, and I do not know what.
Best wishes,
Jo.

(require 'cl)  in ~/.doom.d/config.el solved this problem and now org-export-heard works, even if package cl is deprecated.


error when trying to import  gym_miniworld on Google Colab

Before, I had no problems in running minigrid over Colab, however I have tried several options in order to run Miniworld over Colab but have not succeeded. At the beginning of my Colab notebook, I first install the following libraries:
!pip install rarfile --quiet
!pip install stable-baselines3 > /dev/null
!pip install box2d-py > /dev/null
!pip install gym pyvirtualdisplay > /dev/null 2>&1
!sudo apt-get install -y xvfb python-opengl ffmpeg > /dev/null 2>&1
!pip install gym-miniworld > /dev/null 2>&1

Then, the error appears right when importing the libraries:
import gym
import gym_miniworld

The error I get is the following:
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
[<ipython-input-13-7f542eec6530>](https://fv0dqg4ruxm-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab-20220224-060059-RC00_430667398#) in <module>()
      1 import gym
----> 2 import gym_miniworld

3 frames
[/usr/local/lib/python3.7/dist-packages/pyglet/gl/__init__.py](https://fv0dqg4ruxm-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab-20220224-060059-RC00_430667398#) in <module>()
    233 elif compat_platform == 'darwin':
    234     from .cocoa import CocoaConfig as Config
--> 235 del base  # noqa: F821
    236
    237

NameError: name 'base' is not defined

Any suggestion on how to handle this? Many thanks!

Hmmm it seems like pyglet can't run on your config, presumably because there's no display.
Have you tried rendering offscreen: https://github.com/maximecb/gym-miniworld#offscreen-rendering
Or using xvfb?

I've been able to get around this by first adding your code to a script, and then executing on Colab as:
!xvfb-run -a -s "-screen 0 1024x768x24 -ac +extension GLX +render -noreset" python3 script_name.py
(there may be other ways too).

xvfb creates a virtual display which is often necessary when running on clusters.
Does it work if you use egl instead of xvfb? i.e.
PYOPENGL_PLATFORM=egl python3 script_name.py

xvfb creates a virtual display which is often necessary when running on clusters.
Does it work if you use egl instead of xvfb? i.e.
PYOPENGL_PLATFORM=egl python3 script_name.py

We should probably update the instructions in the readme to explicitly mention clusters and colab.

Just tested on Colab, this works too.

I updated the readme to make it clearer that this is needed to run on Colab and on clusters 👍


Migrate clients implementation from reqwest to hyper

This PR addresses https://github.com/foundation-model-stack/fms-guardrails-orchestrator/issues/247 and https://github.com/foundation-model-stack/fms-guardrails-orchestrator/issues/248. Decoupling these two issues proved difficult:

leaving just open ai temporarily using a reqwest client would require some temporary hacking
integrating hyper without considering SSE streaming support could cause issues retroactively

So this PR addresses HTTP streaming as well through the implementation of an EventSource (similar to eventsource crate) that uses a hyper Client instead of a reqwest Client and RequestBuilder. This PR also introduces additional infrastructure needed for configuring TLS without help from the reqwest library. Parts of the new TLS logic and streaming logic inspired by reqwest and reqwest_eventsource. The request invocation logic for all the HTTP clients needed to be updated, however all the new complexity is hidden in the HttpClient and the handler functions of individual clients becomes simplified.

Nice work on this, I recognize this isn't trivial. I did a high-level review and just want to provide some initial feedback & suggestions.

I would avoid adding custom types and traits that aren't absolutely essential, especially those with conflicting names of common types used in these crates as this can be confusing. This adds bloat and makes it harder for others to follow.
A few callouts:

This Body trait seems probably unneeded and the name is confusing as it conflicts with hyper::body::Body

pub trait Body:
    hyper::body::Body<Data = Bytes, Error = hyper::Error> + Serialize + Send + Sync
{
}

The DataStream type appears to be essentially the same thing as http_body_util::BodyDataStream, so I think you can use this instead of adding a custom type + Stream impl on it.  http_body_util::BodyExt includes into_data_stream() to return a BodyDataStream from Body, e.g. in Response::bytes_stream(), I think you can do the following and drop this type, unless I'm missing something:

    pub fn bytes_stream(self) -> impl futures_core::Stream<Item = Result<Bytes, Error>> {
        // DataStream(self.0.into_body().map_err(Into::into))
        self.0.into_body().map_err(Into::into).into_data_stream()
    }

Is a HttpClientExt trait needed to add an inner() method? Why not just add inner() to HttpClient directly?

pub trait HttpClientExt: Client {
    fn inner(&self) -> &HttpClient;
}

We probably don't need this RequestLike trait; for HttpClient::get() and HttpClient::post(), we can probably just simplify the type signature from T: RequestLike + Send + Sync + 'static to body: impl Serialize (or body: Bytes if we need more flexibility, handling the json serialization in the clients)?

pub trait RequestLike: Serialize + Clone {}
impl<T> RequestLike for T where T: Serialize + Clone + Send + Sync + 'static {}

Hmm, I'm not a fan of adding the EventSource wrapper to this crate, it feels like it should be separate from the orchestrator, if we actually need it. I was playing around with eventsource_stream a bit, and I think we can get away with just using this directly for our requirements, doing something like the following for example in the openai client, i.e. just using eventsource() provided by the eventsource_stream::Eventsource trait.

    let mut event_stream = self
        .client()
        .clone() // ideally not needed
        .post(url, headers, request)
        .await
        .unwrap() // since this is just an example
        .bytes_stream()
        .eventsource(); // provided by eventsource_stream::Eventsource

    tokio::spawn(async move {
        while let Some(Ok(event)) = event_stream.next().await {
            // process similar to how we are doing it now
        }
    });

(if you drop it, I would keep it for reference if we ever need something like it)

Why do HttpClient::get() and HttpClient::post() take self instead of &self?

@declark1 thanks for the initial feedback, really helped clean up the branch. I think I have addressed all of the comments

@pscoro I just realized that our connect_timeout and request_timeout aren't migrating correctly as hyper doesn't implement these and they are being mapped to different types of timeouts below in the builder.
    let client = hyper_util::client::legacy::Client::builder(TokioExecutor::new())
        .http2_keep_alive_timeout(connect_timeout)
        .pool_idle_timeout(request_timeout)
        .build(https_conn);

I'm mostly concerned with request_timeout as this is important to have. I think we would either need to handle this in HttpClient::send() doing something like the example here or use/create a wrapper such as hyper-timeout (haven't used it before).

@declark1 hyper-timeout has connect, read, and write requests, would you know if request timeouts map to read timeouts, or to both read and write timeouts, etc?

@declark1 hyper-timeout has connect, read, and write requests, would you know if request timeouts map to read timeouts, or to both read and write timeouts, etc?

I'm not sure, it needs to be investigated further

Pushed a fix @declark1, some notes:

before we used reqwest::ClientBuilder::timeout() for request timeout which sets the total timeout for the transmission of the request from the start of the connection until the end of the response - this is more closely achieved with tokio::timeout than with read/write timeouts
this fix uses hyper-timeout for connection timeout and uses tokio timeout for request timeout
Im not a fan of propagating request timeout into the http client to be used in the send function but its the most straightforward solution and I am currently already looking into changes relating to client creation and figure this will probably get addressed better in the near future
to build on that, I think a cleaner solution for request timeouts is to use tower-timeout https://docs.rs/tower-timeout/latest/tower_timeout/index.html, which I can introduce with the tower integration


Support manual trigger for checks

Describe the feature you would like and why you want it
While the current implementation of kuberhealthy supports the continuous validation of K8s components and app, it would be nice to be able to manually trigger a check, e.g. after a deployment of an app to K8s.
Additional context
We're currently evaluating to use kuberhealthy for service validations. While there are examples of how to create simple HTTP code/response content check, we want to take it to the next level and run HTTP API test suites. These should continuously run (already supported by kuberhealthy), but also be triggered manually in our deployment pipelines after a deployment rolled out for a specific app (this feature request).

@FraBle this seems like a good feature for us to take on! Thinking through the possible implementation and wondering if we should create a new custom resource, like khjob and have the check operate like a manually triggered k8s job and ensure that this khjob state gets reported back instead of a khstate

Yeah, the use case is pretty close to what a traditional K8s Job does, so reporting back directly to the khjob (or equivalent) makes sense. I wonder if it would be possible though to combine this with the existing khcheck to avoid duplication: the same validations that run continuously should also be able to get triggered after an app deployment.

Going to take an initial stab at this feature! The plan is to create a new CRD khjob which kuberhealthy watches for and triggers when the khjob resource is applied. This khjob reports back to kuberhealthy and a khstate for the khjob is also captured. In the khstate we add a "KuberhealthyJob" boolean to indicate that this khstate object is from a khjob

@joshulyne That sounds good to me. Thank you for picking it up! 🚀

Hi @joshulyne , thanks for picking this up! I just wanted to ask how you are doing with this issue as I'm also interested in this feature. Please let me know how I can support here if possible.

hi @linkvt! so sorry it's been taking forever to merge PR #584 D: the tag says 2.4 release, but we're actually aiming for 2.3 as this PR is pretty much ready to be merged. We're soak testing it now in our own clusters! Feel free to pull down the khjob branch and test out the khjob feature, if you'd like! That'd be super helpful. I believe theres a docs/external_khjob.md file that explains how to implement the khjobs. Let me know how it works for you!


[Feature] Introduce mod bucket generator to paimon

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently, when we define the bucket-key in the Paimon table, the bucket is generated using hash(bucket-key) % bucket_number. However, there are cases where we have already determined the target bucket at the computing edge.
For instance, let's consider a Paimon table that stores user ID bitmaps. We aim to distribute users into 32 buckets evenly. Therefore, we calculate a bucket_no key using hash(user_id) % 32. Yet, under the current mechanism, it will be recalculated as hash(bucket_no) % bucket_number, potentially causing data skew within buckets due to hash collisions.
So, what about allowing the definition of the bucket generator eg:
HASH_MOD
MOD

By this, we can directly use MOD to distribute the data.
Solution
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

CC @JingsongLi WDYT ?

@Aitozi Sounds good to me.

@Aitozi @JingsongLi
IMO, while MOD mode can solve the issue here, its applicable scenarios are limited.
I think Iceberg's truncate partitioning might be a better solution. It can also solve the problem here and is applicable to a wider range of types.
It also has the advantage of maintaining data continuity (for numerical types like INT, LONG), which is very beneficial for primary key tables using auto-increment IDs. For STRING types, it can cluster records with the same prefix, which is beneficial for filtering with starts_with query predicates.

@zhongyujiang Thank you for your input.  It seems the term "bucket" refer to the different concept in Iceberg and Paimon. The "bucket" is one way to transform partitions in Iceberg.
I agree that the truncate transform is more flexible. How about we also consider supporting the bucket's generate function? For example:
hash(x) % N
truncate(x) -- with different types having different implementations

CC @JingsongLi

The "bucket" is one way to transform partitions in Iceberg.

Yea, I think Iceberg refers to all methods of dividing datasets as partitioning.
+1 on introducing the truncate transform.
I wonder if it would be better not to bind concepts like truncate and hash bucketing to Paimon bucket, as this could lead to more flexible partitioning methods, such as truncate(col1, width), bucket(col2, numBuckets).


Implicitly set content type for ObjectResults containing ProblemDetails

A user of my problem details middleware filed an issue (https://github.com/khellang/Middleware/issues/5) thinking something was wrong with my middleware when seeing that ProblemDetails responses came back with Content-Type: application/json in some cases and Content-Type: application/problem+json in other cases.
The issue turned out to be MVC writing the response in the first case, and my middleware handling the response in the second case.
It would be nice if MVC could implicitly add application/problem+json and application/problem+xml to the result ContentTypes if no content type has been added already, so it ends up with the correct Content-Type header in the response.
// @pranavkm @rynowak

It would be nice if MVC could implicitly add application/problem+json and application/problem+xml to the result ContentTypes

Over here - https://github.com/aspnet/Mvc/blob/release/2.2/src/Microsoft.AspNetCore.Mvc.Core/ObjectResult.cs#L54-L57?

Yeah, something like that, but I think OnFormatting might be too late in the pipeline?


GH-41691: [Doc] Remove notion of "logical type"

In several places in the Arrow specification and documentation we use the term "logical types", but we don't use it consistently and we don't actually have physical types (only physical layouts) to contrast it with. This creates confusion for readers as it is not immediately clear whether all data types are "logical" and if there is a meaningful distinction behind our usage of this term.
Also address GH-14752 by adding a table of data types with their respective parameters and the corresponding layouts.

GitHub Issue: #41691

cc @jorisvandenbossche @AlenkaF

I reused @AlenkaF 's idea of a table here, but I changed the contents quite a bit.
Some open questions:

for the type parameters, should we use a description in natural language (such as "bit width" or "signedness") or the physical parameter names in Schema.fbs (such as bitWidth or is_signed)?
should we explain the type parameters in full (this would result in a more lengthy though more informative doc), or should we just keep a couple explanatory notes as here?
should we repeat the term "Layout" under the "Physical Memory Layout" column? For example, write "Fixed-size Primitive Layout" instead of the terser "Fixed-size Primitive".

Also cc @alamb @tustvold @paleolimbot @wesm

@github-actions crossbow submit preview-docs

@github-actions crossbow submit preview-docs

The HTML preview can be seen at http://crossbow.voltrondata.com/pr_docs/41958/format/Columnar.html

should we explain the type parameters in full (this would result in a more lengthy though more informative doc), or should we just keep a couple explanatory notes as here?

I think for the content you created here (i.e. the overview table), the current level of detail is fine.
For me it is a separate question if we want to keep Schema.fbs as the "authoritative source" for the explanation of those parameters. Personally, I don't like that this is "hidden" in a fbs file which is actually specific for IPC (there are a few things in that file that are not generic for the columnar format). I think ideally we would move the explanation of the parameters in the fbs file to the actual format specification, but then the question is how to deal with the duplication with the fbs file (we don't want two places to keep in sync, but would it be fine to cut down the content in the fbs file largely?)

For me it is a separate question if we want to keep Schema.fbs as the "authoritative source" for the explanation of those parameters. Personally, I don't like that this is "hidden" in a fbs file which is actually specific for IPC (there are a few things in that file that are not generic for the columnar format).

I agree that it makes things a bit intimidating; also, reading a fbs file just to find prose documentation is not really a pleasant experience. Perhaps open a new issue for this?

I agree that it makes things a bit intimidating; also, reading a fbs file just to find prose documentation is not really a pleasant experience. Perhaps open a new issue for this?

Opened https://github.com/apache/arrow/issues/42011 about moving a lot of the prose content from Schema.fbs to Columnar.rst


Gate all resources on apt being installed

This prevents us trying to create /etc/apt/... on non-debian systems

I think rather than each individual resource having an only_if block we should just bang the whole thing in an if statement and avoid this problem in future.

At first I did that, but I was curious if we had some magical reason at some point for doing the resources individually.  It seems kinda odd to have about a dozen resources gated with the same logic. If you can't think of a reason that we might have done it that way I'm all for ripping it all out.

:+1: pending rebase


fix: using with STI models

Hello guys. This PR allows to nest ActiveFormModel forms from AR models with STI column.
I have an error trying to use this gem with STI models like that:
class User < ActiveRecord::Base
end

class Client < User
end

class SignUpForm < Client
  include ActiveFormModel
end

SignUpForm.new

Exception:
ActionController::UnfilteredParameters: unable to convert unpermitted parameters to hash

.../actionpack-6.1.4/lib/action_controller/metal/strong_parameters.rb:316:in `to_h'
.../activerecord-6.1.4/lib/active_record/inheritance.rb:278:in `subclass_from_attributes'
.../activerecord-6.1.4/lib/active_record/inheritance.rb:58:in `new'

That's happened because Rails redefines a .new method in active_record/inheritance.rb to find a subclass from attributes passed to Model.new. So #initialize method is not yet called here and we have unpermitted params.
Permitting params in .new instead of #initialize fixes this issue. Please tell me if you see any drawbacks with this approach.

Looks good! Resolve conflicts pls and I'll merge it

Done


kubectl --validate flag not validating input file when running create -f

My understanding of kubectl's --validate flag is that it's supposed to error out if it can't parse its input as a valid API object. Maybe my understanding is wrong, but if it isn't, then the --validate flag is currently broken.
This came up when a user's service was coming up without a load balancer when they used the following yaml:
kind: Service
apiVersion: v1beta3
metadata:
  name: locust-master
  labels:
    name: locust
    role: master
spec:
  ports:
    - port: 8089
      targetPort: 8089
      protocol: TCP
      name: locust-master-web
  selector:
    name: locust
    role: master
createExternalLoadBalancer: true

The createExternalLoadBalancer parameter is incorrectly at the top level, when it's supposed to be inside the spec. Running kubectl create -f locust-master-service.yaml --validate happily succeeds, with the server never seeing the createExternalLoadBalancer parameter.
You can make this even more extreme by throwing in arbitrarily named fields that don't exist anywhere in the API:
kind: Service
apiVersion: v1beta3
metadata:
  xxxxxxxxx: yyyyyyyy
  name: locust-master
  labels:
    name: locust
    role: master
spec:
  aaaaaaaa: bbbbbbbbb
  ports:
    - port: 8089
      targetPort: 8089
      protocol: TCP
      name: locust-master-web
  selector:
    name: locust
    role: master

Running kubectl create -f locust-master-service.yaml --validate with this input file also happily succeeds.
@brendandburns @jlowdermilk

I ran into a similar issue when using a secret in a pod and had a "source" section in my YAML that was incorrect, but the command did not error, just ignored parts of below irrelevant YAML.
Sent from my iPhone

On Apr 30, 2015, at 6:16 PM, Alex Robinson<EMAIL_ADDRESS>wrote:
My understanding of kubectl's --validate flag is that it's supposed to error out if it can't parse its input as a valid API object. Maybe my understanding is wrong, but if it isn't, then the --validate flag is currently broken.
This came up when a user's service was coming up without a load balancer when they used the following yaml:
kind: Service
apiVersion: v1beta3
metadata:
name: locust-master
labels:
name: locust
role: master
spec:
ports:
- port: 8089
targetPort: 8089
protocol: TCP
name: locust-master-web
selector:
name: locust
role: master
createExternalLoadBalancer: true
The createExternalLoadBalancer parameter is incorrectly at the top level, when it's supposed to be inside the spec. Running kubectl create -f locust-master-service.yaml --validate happily succeeds, with the server never seeing the createExternalLoadBalancer parameter.
You can make this even more extreme by throwing in arbitrarily named fields that don't exist anywhere in the API:
kind: Service
apiVersion: v1beta3
metadata:
xxxxxxxxx: yyyyyyyy
name: locust-master
labels:
name: locust
role: master
spec:
aaaaaaaa: bbbbbbbbb
ports:
- port: 8089
targetPort: 8089
protocol: TCP
name: locust-master-web
selector:
name: locust
role: master
Running kubectl create -f locust-master-service.yaml --validate with this input file also happily succeeds.
@brendandburns @jlowdermilk
—
Reply to this email directly or view it on GitHub.

Yes. I have ran into this as well. A field was at the wrong level and --validate just ignored it.
Validation ignores unknown fields: https://github.com/GoogleCloudPlatform/kubernetes/issues/5889

Isn't #5889 orthogonal? It's about adding server-side validation, whereas I'd like to make our existing client-side validation option validate properly.

This is also broken for json files, not just yaml:
{
   "kind":"Service",
   "apiVersion":"v1beta3",
   "metadata":{
      "name":"locust-master"
   },
   "spec":{
      "ports": [
        {
          "port":8089,
          "targetPort":8089,
          "protocol":"TCP",
          "name": "locust-master-web"
        }
      ],
      "selector":{
         "name":"locust",
         "role":"master"
      }
   },
  "aaaaaaaa":"bbbbbbbb"
}

@a-robinson Yes sorry. You are right.

I believe the current validation at most catches required fields that are not provided. Unfortunately, our nearly ubiquitous use of omitempty defeats even that checking.

@brendandburns Are you actively working on this? If not, we'd like to reassign it.
Yesterday, we discussed stricter json parsing (also discussed in #3338) as an alternative. Since kubectl currently round-trips objects (#3955), it will drop unknown fields, anyway.
However, when I was thinking about #4855, it reminded me that strict parsing needs to be optional, and we'd want to disable it at least for parsing responses in essentially all clients. We might also want to make it optional for requests (#5889), but I haven't thought of a use case for that yet.

I asked about whether strict parsing should be the default for requests in #7600, some concerns were brought up there.

Also being discussed in #4855.

@bgrant0607 I believe that this specific issue is fixed by #7919 I'm going to close it, we can discuss the defaulting elsewhere.
fwiw, making it optional for parsing requests is useful too in case you have skew between client version and server version.
Also, we should likely have a send the raw data we read, rather than re-encoding the object for transmittal, option.


Help , To add Accessory

I read in this guide
https://github.com/KhaosT/HAP-NodeJS/wiki/Adding-Multiple-Accessories
but if I try to add one, spite change the username , this is not on the list
But the username has a specific procedure to be able to assign ?
I 'm trying to dublicate Light_accessory.js but i have this problems . I would like a little help , thanks

What's the problem you encountered when duplicates Light_accessory.js? There are several changes to this project in the past few months and the wiki may no longer valid...

I have also a problem duplicating light accessory. I change username but after node Core.js I got this error:
Error: dns service error: name conflict
at new Advertisement (/home/pi/hap/node_modules/mdns/lib/advertisement.js:56:10)
at Object.create [as createAdvertisement] (/home/pi/hap/node_modules/mdns/lib/advertisement.js:64:10)
at Advertiser.startAdvertising (/home/pi/hap/lib/Advertiser.js:43:30)
at Accessory._onListening (/home/pi/hap/lib/Accessory.js:352:20)

i got the same error

I got the same error too, I duplicate an accessory but now I get this error.

I managed to fix this by also making this line unique:
var light = exports.accessory = new Accessory('Light', lightUUID);
for example:
var light = exports.accessory = new Accessory('Office Light', lightUUID);
(in addition to the object name, the UUID, and the MAC address/username, though those might not all be neccessary)


Cannot unmarshal !!seq into string

I was playing around with sops to get the hang of it and unfortunately I keep getting an unmarshalling error whenever my yaml includes lists. Like in the default provided when running:
> nix-shell --run "sops blubb.yml"
<file_content>
hello: Welcome to SOPS! Edit this file as you please!
example_key: example_value
example_array:
- example_value1
- example_value2
example_number: 1234.5679
example_booleans:
- true
- false
</file_content>

Yields:
hostymchostface> /nix/store/5mr1s98rsxrxiywkhfrn8zir4isf0rqg-sops-install-secrets-0.0.1/bin/sops-install-secrets: Cannot parse yaml of '/nix/store/rcncfxywky46lx9d30ycr896rgmkhykf-bla.yml': yaml: unmarshal errors:
hostymchostface>   line 4: cannot unmarshal !!seq into string
…
hostymchostface>   line 8: cannot unmarshal !!seq into string

Are you trying to keys that contain lists? This is not supported. You can have lists in your document so. I just tested that.

Are you trying to keys that contain lists? This is not supported. You can have lists in your document so. I just tested that.

Ok. Now I got an error.

Ok. Now I got an error.

@Mic92 Not really, I merely gave it a spin with the file it generates when you run the command.

@Mic92 Not really, I merely gave it a spin with the file it generates when you run the command.


[HIVEMALL-83][Bug] Fix wrong getV() arg on ffm_predict

What changes were proposed in this pull request?
getV() called in ffm_predict takes wrong argument.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-83
How was this patch tested?
N/A

LGTM 👍

Changes Unknown when pulling 45567c8322de6b978c88d896b7c1882f90a3f669 on takuti:ffm into ** on apache:master**.

Changes Unknown when pulling 45567c8322de6b978c88d896b7c1882f90a3f669 on takuti:ffm into ** on apache:master**.


I don't want to set up opacity.

If you do show menu at PullDownButton, the opacity is applied, so could you make it an option to use it?

Hey @etgkqo
I have an update ready for publish with a fix for you issue. Unfortunately i can't publish it right now since publish command drops with network exceptions 😕
I'll try to publish a later and @ you again when it will be published 😄.
Anyway, here is the update:
PullDownButtonTheme(
  applyOpacity: false,
)

or
PullDownButton(
  itemBuilder: ...,
  buttonBuilder: ...,
  applyOpacity: false,
)

It's live @etgkqo :D


[Feature Request]: Ability to ping Distant Horizons chunks.

Not sure how this would be implemented but currently the behavior is that it will ping up to how many vanilla chunks are loaded in. If you try to ping anything further than the vanilla render distance, it simply wont.

Hey, as far as I know, Distant Horizons works similar to Nvidium, where terrain only lives in GPU memory (see here). As you might have guessed, the chunks are not actually loaded and therefore can't be raycasted to.

Distant horizon api has support for raycasting into its terrain if i remember correctly

Good to know, I'll look into it!

I have drafted a proof of concept for an integration of the DH Api into Ping Wheel.
Unfortunately, with the latest version of Distant Horizons (v2.1.0a), the raycast can no longer respond within a reasonably short duration, due to heavy performance optimizations of the mod. From my testing, I've had inconsistent access times between 0.5 and 20 seconds on good hardware and up to a minute on a slower machine. With version 2.0.1a this was usually less than a few milliseconds at most.
I've talked to the project owner about the issue on Discord, but we can't tell if and when this will be addressed.


update components imports to not use wildcard

linode-components/* needs to be explicit

Just wanted to confirm that the * is intended to be a wildcard. For example:
linode-components/forms

from this error:
Module not found: Error: Cannot resolve module 'linode-components/forms' in
.../manager/src/linodes/linode/settings/advanced/components
@ ./src/linodes/linode/settings/advanced/components/CreateOrEditConfig.js 1:1833-1867

which appears to be this line

Oh, i see. Thanks for clarification

We've successfully upgraded node and npm -> yarn without this. No need.


Where are wget / curl used?

I couldn't find any reference to wget or curl in the code.

wget and curl are used in the setup script

Thanks!


[FLINK-22384][docs]Chinese typos in "fault-tolerance/state/"  page

What is the purpose of the change
i found Chinese typos in  https://ci.apache.org/projects/flink/flink-docs-master/zh/docs/dev/datastream/fault-tolerance/state/  text content  "和 keyed state 类系"  Should be replaced with  "和 keyed state 类似"
Brief change log
change "和 keyed state 类系"  to "和 keyed state 类似"
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (no)

@wuchong please review , thanks


[IMPROVEMENT] Upgrade support bundle kit version

Is your improvement request related to a feature? Please describe (👍 if you like this request)
The current support bundle kit version is vulnerable to CVEs. We should upgrade to the latest versions that have the fixes.
Fixes:

SUSE-SU-2023:3454-1
SUSE-SU-2023:3823-1
SUSE-SU-2023:4044-1
SUSE-SU-2023:3823-1
SUSE-SU-2023:4044-1
SUSE-SU-2023:3954-1
SUSE-SU-2023:3997-1
SUSE-SU-2023:3699-1

Describe the solution you'd like

[ ] Mirror support-bundle-kit component image to longhorn.io
[ ] Upgrade image in the deployment:

YAML
Chart

Describe alternatives you've considered
None
Additional context
https://github.com/longhorn/security/issues/16

@yangchiu please help to mirror rancher/support-bundle-kit:v0.0.29 to longhornio. Thank you.

Seems https://github.com/rancher/support-bundle-kit/pull/81 is taking longer for the
merge. So @yangchiu could we go forward to mirror rancher/support-bundle-kit:v0.0.29 and handle the fix in https://github.com/longhorn/longhorn/issues/6997.

Image mirrored: https://hub.docker.com/layers/longhornio/support-bundle-kit/v0.0.29/images/sha256-2928f85742a47be4c18f990468b5bdd075936a8ef8e6d400eb1f2228080fadf0?context=explore

Hi @c3y1huang, https://github.com/rancher/support-bundle-kit/pull/81 is already merged, thanks!

Verified pass on longhorn master (longhorn 07a87d, longhornio/support-bundle-kit:v0.0.31)
Install Longhorn master(v1.6.0-dev) by yaml and chart, the support bundle can download and extract after download.


Tests missing from PyPI

I am trying to package pyuca for NixOS but cannot run tests because the PyPI package lacks them.
See also the Debian thread about the issue:
https://lists.debian.org/debian-python/2016/04/msg00074.html

I don't think the tests should ship with the package normally. Is there a workaround I can help with?

I think you are supposed to include the unit test into the tarball but not into the wheel.
Looking through the packaging docs, I could not find anything mentioning whether to include tests into the tarball. The following StackOverflow answers suggest they are supposed to be included:
https://stackoverflow.com/a/16444257/160386
https://stackoverflow.com/a/32391295/160386
https://stackoverflow.com/a/14437754/160386
Out of top 15 packages on PyPI, only three (pip, awscli and colorama) do not include tests in the tarballs so it seems to be common practice.

yep, makes sense to include them in a source distribution. I just need to work out how to now :-)

Requests seem to add it through MANIFEST.in: https://github.com/requests/requests/blob/master/MANIFEST.in

I can second that. Unit tests can be used by packagers to test the distro package.


error in installation/ python setup.py egg_info

This is probably not the best place to ask this question, but I was wondering if anyone came across this or know what this error points to during installation. The command line is

pip install --user --upgrade fmriprep-docker

Collecting fmriprep-docker
Using cached fmriprep-docker-0.5.4.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-Qvo5S9/fmriprep-docker/setup.py", line 43, in
main()
File "/tmp/pip-build-Qvo5S9/fmriprep-docker/setup.py", line 14, in main
info = runpy.run_path(op.join(this_path, 'fmriprep_docker.py'))
File "/usr/lib/python2.7/runpy.py", line 252, in run_path
return _run_module_code(code, init_globals, run_name, path_name)
File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code
mod_name, mod_fname, mod_loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/tmp/pip-build-Qvo5S9/fmriprep-docker/fmriprep_docker.py", line 3, in
from builtins import int, map, input, zip
ImportError: No module named builtins

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-ypLRg8/fmriprep/.

Both docker and manually prepared environment routes produce the same error in installation. I have some restriction issues in this computer and I ran it with sudo but I am still wondering if that might be a cause. Thank you for the help!

pip install future

This should be automatically installed when you try to install fmriprep-docker... I'll see if I can figure out why it's not working.
Also, this is a great place to ask the question. :-)

That command helped. Thank you!

We should revisit this after 0.6.1 is released, to verify that it can be installed without pre-installing future. (See #631.)

Alright, it looks like #631 had no effect:
$ docker run --rm -it continuumio/miniconda
root@20b4fbe854c7:/# pip install fmriprep-docker==1.0.0rc1
Collecting fmriprep-docker==1.0.0rc1
  Downloading fmriprep-docker-1.0.0rc1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-1QAk0K/fmriprep-docker/setup.py", line 43, in <module>
        main()
      File "/tmp/pip-build-1QAk0K/fmriprep-docker/setup.py", line 14, in main
        info = runpy.run_path(op.join(this_path, 'fmriprep_docker.py'))
      File "/opt/conda/lib/python2.7/runpy.py", line 252, in run_path
        return _run_module_code(code, init_globals, run_name, path_name)
      File "/opt/conda/lib/python2.7/runpy.py", line 82, in _run_module_code
        mod_name, mod_fname, mod_loader, pkg_name)
      File "/opt/conda/lib/python2.7/runpy.py", line 72, in _run_code
        exec code in run_globals
      File "/tmp/pip-build-1QAk0K/fmriprep-docker/fmriprep_docker.py", line 3, in <module>
        from builtins import int, map, input, zip
    ImportError: No module named builtins

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-1QAk0K/fmriprep-docker/

Perhaps we should just update the docs to say 'pip install --user --upgrade future fmriprep-docker`?

FMRIPREP does not support python < 3 anymore.


efficiency pump (HUP) control voltage

Hello, is it possible to integrate the efficiency pump (HUP) control voltage.
In Luxtronik, the efficiency pump is a control function for the main circulation pump (HUP).
If the efficiency pump is active (switch.luxtronik_xxxx_efficiency_pump)
then the speed of the main circulation pump (HUP) can be set.
The mainboard then outputs a control voltage 3-10V for the main circulation pump (HUP) that then determines the speed.
I have found the following parameters for this.

Minimal is the speed when the WP is off
Nominal is the speed when the WP is active

parameters
867 ID_Einst_Effizienzpumpe_Nominal_akt
868 ID_Einst_Effizienzpumpe_Minimal_akt
visiblities
239 ID_Visi_SysEin_EffizienzpumpeNom
240 ID_Visi_SysEin_EffizienzpumpeMin

English Key: ?
English Name (min): „efficiency_pump_minimal“
English Name (nom): „efficiency_pump_nominal“
Unit: „V“
MinValue: 3,0
MaxValue: 10,0
Step: 0,5
Perhaps a factor: not known
device_class (parameters): „number“
device_class (visiblities): „sensor“
icon: „mdi:pump“

Thanks a lot :-)

Thanks.
Can you explain something?
Which pump is set to "efficiency"? circulation_pump_heating, additional_circulation_pump, dhw_recirculation_pump, dhw_circulation_pump or pump_flow?
What or how does this values control?
3-10 Volt means the ElectricPotential provided from heatpump to the pump?
Nominal is the default provided ElectricPotentia and minimal is provided in mode efficiency?
In which cases activates the heatpump this efficiency?

Is available in the main branch. Release comes later.

See 2023.10.14-Beta

Wow. Thank you for the work


Closes #224 | Create dataloader for Korpus Nusantara corpus

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@SamuelCahyawijaya I paste the chat history below:
@yana-xuyan : Thank you for your contribution! For "tiociu" and "khek", since there is no ISO code for those two, let's just keep it in this way.
On the other hand, there seems to be some conflicting files on your commit, can you merge the latest update from the master branch to your branch and push again? Thank you!

/test dataset=korpus_nusantara subset_id=korpus_nusantara_ind_day_nusantara_t2t

/test dataset=korpus_nusantara subset_id=korpus_nusantara_day_ind_nusantara_t2t

/test dataset=korpus_nusantara subset_id=korpus_nusantara_ind_day

/test dataset=korpus_nusantara subset_id=korpus_nusantara_khek_ind

@yana-xuyan : Thanks for contributing, the dataset looks good to me! Approving this PR!


Lock all npm dependencies to exact versions instead of auto-update

Currently all dependencies are on auto-update. We should lock in the exact versions to avoid breaks in the future when dependencies come out with new versions. From now on when we run npm i dependency_name --save --save-exact to always lock in the current version.

I guess this is good solution. If anyone is more familiar with nodejs let us know ;]

from here:https://github.com/hovancik/stretchly/commit/3dc28c5fa658a49efe84aae6b64fef5299701288#r29659128
But that's what semver is for. "^version" stands for "any compatible with 'version'" therefore it is usually safe to update. Yeah it is still possible that the app breaks but it's rare and usually unintentional, developers will most likely quickly fix any breakage in the upcoming, also compatible version when reported.
And this usually won't happen on master because in order to actually get those updates you have to npm update (npm install may also use new versions but this also have to be PR into the repository as both package.json and package-lock.json will change) and then PR new versions, so it is kind of pointless to have exact versions in package.json (it may be useful only in some corner cases where you know that you don't need to update, or developer doesn't respect the semver).
Also we have package-lock.json in the repo, therefore if you npm install --no-save npm will not update any packages and install exactly what is in package-lock.json even if package.json has "^ver" in it. (package-lock saves the exact whole current dependency tree, so every dependency and dependency of dependencies and so on is fixed).
Anyway this is much better that having to manually update everything, because not only you won't get new features, but also any bugfixes will have to be monitored manually in all libraries used. This way we will only need to

run npm update and check that everything works to get all compatible features and bugfixes
manually npm update app@version major versions, which may by definition be incompatible as some breaking changes were introduced (npm will not update those without manual update with version specifier if you have "^ver" set in dependencies).

So I suggest we revert that change as this will make maintenance of dependencies much harder, with having manually check for new versions and look for them, instead of just getting them 'almost' for free with semver.

@lundibundi This is a good find, thanks! @hovancik shall we revert back to auto-update? This is probably best, but then we just need to keep in mind that package-lock.json will be changing with updating dependencies.

@lundibundi good find, thanks! @hovancik should we revert back? We can just use the --no-save tag instead of the --save-exact to maintain the package-lock.json the same.


Allow to restart declined pipelines

closes https://github.com/woodpecker-ci/woodpecker/issues/300

Looks good but have not tested it jet

tested :tada:


[Enhancement] Add test code for this module [eventmesh-admin-rocketmq]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
Add unit test code for eventmesh-admin-rocketmq.
Describe the solution you'd like
Module name: eventmesh-admin-rocketmq
Located in: eventmesh-admin/eventmesh-admin-rocketmq
Task Status: ×(unfinished) / √(finished)

Notes: This issue will not be closed, if you want to submit a pr to do some unit tests on this module or select some of the following classes to do some unit tests, please submit a detailed issue separately and linked to the pr you submitted.

Task Status
Class
Type

×
org/apache/eventmesh/admin/rocketmq/controller/AdminController.java
controller

×
org/apache/eventmesh/admin/rocketmq/handler/TopicsHandler.java
handler

×
org/apache/eventmesh/admin/rocketmq/request/TopicCreateRequest.java
request

×
org/apache/eventmesh/admin/rocketmq/response/TopicResponse.java
response

×
org/apache/eventmesh/admin/rocketmq/util/JsonUtils.java
utils

×
org/apache/eventmesh/admin/rocketmq/util/NetUtils.java
utils

×
org/apache/eventmesh/admin/rocketmq/util/RequestMapping.java
utils

×
org/apache/eventmesh/admin/rocketmq/util/UrlMappingPattern.java
utils

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Hi! can you assign this good first issue to me? thanks

Hi! can you assign this good first issue to me? thanks

OK, welcome~

您好，我是武跃航，您的邮件我已收到。

@SunnyBoy-WYH Hello! This issue will not be closed, so you can re submit a detailed issue of this module, and then submit pr and associate it with the issue you proposed.

Hi I would like to contribute to this issue can you let me know how I can solve this issue?

eventmesh-admin-rocketmq module has been removed. Closing this issue now.


Return token links

Feature request
Is your feature request related to a problem? Please describe.
At the moment an invite handled by sending an email. It would be nice to:

return the invite link when the /invite route is called
optionally choose to send emails (eg, send by default, parameter to not send)

Additional context

Requested by monitoro
https://github.com/supabase/supabase/discussions/715

updated to include all token types:
invite, magiclink, reset password, confirmation etc.

Hi, just came across this and I was wondering if this is still on the roadmap (or if I missed the explanation in the docs)? It would be great to be able to use a custom ConfirmationURL to support a fully offline testing environment for a user signup auth flow, for example. Thanks for all your incredible work!


Out of capacity

Some days ago I tried to start the sample WordPress stack (https://labs.play-with-docker.com/?stack=/wordpress/latest/stack.yml#), but it failed with this notice:
We are really sorry but we are out of capacity and cannot create your session at the moment. Please try again later.

The issue still persists.

Just tried this and it works for me. Try again.

@marcosnils: Yes, I tried again and now it works for me, too.

This issue is still there

This issue is still there

Just tried this and it works fine to me.

We are really sorry but we are out of capacity and cannot create your session at the moment. Please try again later.
same problem!!!

Anyone up with a solution to this?


Update to<EMAIL_ADDRESS>dependency

This pulls the fix for https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/529 which is showing whenever ng i18n capabilities are used the following warning DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.
Also should probably fix https://github.com/angular/angular-cli/issues/7078

Heya, the real problem here is that we accidentally left the webpack 3.3 commit in 1.2.2. It shouldn't have been there. The issue where we're tracking this is https://github.com/angular/angular-cli/issues/7078.
I'm closing the PR because this is not the right approach. We'll have to make a non-PR commit directly to the 1.2.x branch.


[AllocBoxToStack] Computing partial_apply frontier looks thru copies+moves.

When determining where to destroy a captured alloc_box, the frontier of the capturing partial_apply is computed.  Previously, that computation only considered the direct uses of the partial_apply.  If the partial_apply were copy_value'd + destroy_value'd or move_value'd, however, the result would be a miscompile where the destroy_addr/dealloc_stack for the alloc_stack to which the alloc_box was promoted was destroyed before the apply of the closure which used the address.

@swift-ci please test

@swift-ci please test


updated for new output format in 1.1.2

Since I just recently changed the output format which breaks your
solver, I went ahead and corrected the sample puzzles and the one line
of code that so that it started reading from line 4 instead of line 3.

@joshbduncan , thanks for this!  Before accepting this pull request, it may be worth discussing a more robust interface between the word search generator and solver to avoid issues like this in the future due to such tight coupling.
An idea: consider adding a JSON output format (e.g., "puzzle.json") to the generator tool.  This then provides a structured way to input the puzzle data - grid, words, answer key.  Then changes to the generator's text output format won't impact the solver's ability to ingest the JSON file format.  What do you think?

Makes sense... I was just trying to fix what I broke but I can see how this feature would be a benefit. I'll take a closer look at your code to determine the best path forward. Thanks for the idea!


[Task] Chat Typing Indicator Presentation

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

having some issues with MSFAvatarGroup, I am planning to resolve it once I got back from FluentUI team, but please let me know if you would like me to address it in this PR instead.


Automate domains from GIT not all properties editable

Purpose or Intent
The name and description properties for a GIT domain are not editable, we can only edit the enabled, priority properties.
Links

https://github.com/ManageIQ/manageiq/pull/8897

@gmcculloug @Fryguy @h-kataria
Please review

UI changes look good.

￼For GIT Domain

For User Domain

LGTM.  @gmcculloug please merge if it looks good to you as well.


metadata: Find a way to identify where metadata was not propagated

One-liner
We need a way to identify where metadata was lost within an ETL step.
Context & details
While working on an ETL step, sometimes you do an operation that did not respect propagation of metadata. And if you don't notice it, you may reach the end of the step and then need to go back and figure out where metadata was lost.
We need to avoid that situation. I can think of a few options:

The easiest is to move the function owid.catalog.tables.check_all_variables_have_metadata to etl.helpers (and possibly rename it to something shorter). This function checks if all columns have at least one origin. This function can be used (manually) every now and then while debugging.
Add a method to Table that checks the same thing. It could be something like tb.check_metadata().
Create a new tool that executes an etl step and goes line by line, checking if at any point an indicator loses its origins. Not sure how this would look like.

Ideas 1. and 2. sound good (2. is more slick in my opinion). I do this quite often, too, and I tend to add breakpoints __import__('ipdb').set_trace() and print metadata. Having such a method would save me some time.
@pabloarosado there are too many assignees :), pick one and let him do this.

Just added tb.check_metadata() (feel free to modify it as you want @pabloarosado, I didn't notice you assigned yourself)

Hey @Marigold thanks for the heads-up. I'm trying something here, if it works out, I'll do a PR soon.

Thanks to @pabloarosado, we can now set Table.DEBUG = True and see where it fails. See https://github.com/owid/etl/pull/1697


[ddc] language/closure/cycles_test has inconsistent results over the OS and browser configurations

language/closure/cycles_test is passing, failing, and flaking on at least one of the stable ddc configurations.

I want to work on this issues please assign me this issue


Windows doesn't resolve LAN hostnames

With dnscrypt enabled, Windows can't goto LAN resources (local shared folders/files, my NAS..., error is "Windows cant access to %NETWORKNAME%"). I tried disabling dnscrypt-proxy and the resources are available at the moment.

Current forwarding rules are:
*.lan                <IP_ADDRESS>
*.local              <IP_ADDRESS>
10.in-addr.arpa      <IP_ADDRESS>
192.in-addr.arpa     <IP_ADDRESS>
254.169.in-addr.arpa <IP_ADDRESS>
lan                  <IP_ADDRESS>
local                <IP_ADDRESS>
And of course, the network router is in <IP_ADDRESS>

I use forwarding rules for this exact purpose and it works for me. One thing that jumps out at me is that wildcard aren't supported by DNSCrypt (or necessary).
https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Forwarding

I know (I only tried with It for discarding all the options), anyway the same rule without wildcards are at the bottom. I also tried without It and in other PCs (Windows 10 x64) with same result.
I noticed if I click in a network device, primarily the popup error appears, but if I click on It for 8-10 times, finally It founds and connects

I tried now, and also, sometimes, my NAS doesn't appear in network shares if DNSCrypt is running (maybe due the other network share is resolved through WINS instead DNS)

But have you tried it without the wildcards? They may be causing dnscrypt-proxy to fail to parse the entire forwarding-rules.txt.
Like I said, it works for me. Also, you may have more luck asking for help on the dnscrypt-proxy repo. This is just a front end. Here is my forwarding-rules.txt. Maybe that will be helpful to you. It forwards my local domains to my domain controllers/dns servers.
168.192.in-addr.arpa  <IP_ADDRESS>, <IP_ADDRESS>
mydomain.com          <IP_ADDRESS>, <IP_ADDRESS>
mydomain.local        <IP_ADDRESS>, <IP_ADDRESS>
mydomain.net          <IP_ADDRESS>, <IP_ADDRESS>

Yep, now I tried like this:

Really...very strange, if I disable DNSCrypt, my NAS appears in Network, if I enable, then, it disappears:

Solved! It was because this option blocking IPv6

I thought that blocking IPv6 would be resolved through IPv4


Integrate third party websites

By embeding /frame-api.html you can now query which rooms the user has admin in. By then sending another event via postMessage you can change the room's current media.
This enables other websites to implement a Send to/ Open in shitty-sync button.
Security can be handled with CSP headers.

We could also use a new view for creating a new room with preset media.


Test for embedded definitions (using single Swagger/OpenAPI file)

I have a JSON file with embedded schemas in the definitions object. Is it possible to test for those schemas straight with match_json_schema()?
Neither match_json_schema('openapi#/definitions/SomeSchema') or match_json_schema('openapi.json#/definitions/SomeSchema') are seem to work, so now I have to manually create separate files for each schema of my definitions before I run tests.

@Ajaxy could you share your schema definitions and the JSON you're trying to validate against them?

It's just a regular swagger.json file:
{
  "swagger": "2.0",
  "info": {
    "title": "D.O.C API 1.0",
    "description": "...",
    "version": "0.0.1"
  },
  "host": "api.afapp.com",
  "basePath": "/v1",
  "schemes": [
    "https"
  ],
  "consumes": [
    "application/json"
  ],
  "produces": [
    "application/json"
  ],
  "paths": {
    /* ... */
  },
  "tags": [
    /* ... */
  ],
  "definitions": {
    "Clinic": {
      "type": "object",
      "properties": {
        "name": {
          "type": "string"
        },
        "address": {
          "type": "string"
        },
        "latitude": {
          "type": "number"
        },
        "longitude": {
          "type": "number"
        }
      },
      "required": [
        "name",
        "address",
        "latitude",
        "longitude"
      ]
    },
    /* ... */
  }
}

So I'm to trying to check it like this:
expect(result[:clinics][0]).to match_json_schema('swagger.json#/Clinic')

I was able to do this with this code:
require 'json'
require 'json_matchers/rspec'

JsonMatchers.schema_root = 'spec/schemas'

file = File.read 'spec/schemas/swagger.json'
swagger = JSON.parse(file, symbolize_names: true)

# Fix for json_matchers single-file restriction
swagger[:definitions].keys.each do |key|
  File.open("spec/schemas/#{key}.json", 'w') do |f|
    f.write(JSON.pretty_generate({
      '$ref': "swagger.json#/definitions/#{key}"
    }))
  end
end


@keyframes failing with invalid selector after

Running the following scss with<EMAIL_ADDRESS>returns the css as expected.
@mixin keyframes($animation-name) {
  @keyframes $animation-name {
    @content;
  }
}

@include keyframes(bounce) {
  0%, 20%, 50%, 80%, 100% {transform: translateY(0);}
  40% {transform: translateY(-30px);}
  60% {transform: translateY(-15px);}
}

When switching to<EMAIL_ADDRESS>it fails with the following message, complaining about @keyframes $animation-name:
{
  "message": "invalid selector after  ",
  "column": 13,
  "line": 2,
  "file": "/Users/davidlanger/repos/temp-libsass/test.scss",
  "status": 1
}

Checked with sassc, seems to be a libsass issue

Ok, I'll post the issue there. (And install sassc so I'll post in the right repo next time)

According to my tests, sass/libsass@974ae42b87a3714fff5ed38132272486747f524c broke this. This was introduced in https://github.com/sass/libsass/pull/1177

@davidlanger I have fix in Libsass. Created a new issue there to track this https://github.com/sass/libsass/issues/1214.


Pr/54 - Added Bower file and updated package.json

Thanks @mckramer. Made the changes you suggested.

:+1:


[FEATURE] manifestCreator: i18n section v22

With app descriptor v22 (1.21.0)
the i18n sections in the manifest are objects
with:

bundleUrl
supportedLocales

Coverage decreased (-0.07%) to 92.882% when pulling f96159a91ff392d45fa1327194f241a93cd1220d on manifest-creator-supported-locales into 9433f6a989d6fea46f637ac8ff58c739977f456c on master.


Is it possible to name an object property default?

I have the following definition:
type: object
properties:
  type:
    type: string
  references:
    type: array
    items:
      type: object
      properties:
        reference:
          type: string
        axis:
          type: object
  default:
    type: string

I got these errors from the spectral linter, so I wonder if the issue is coming from the fact that the attribute is named default.
 error  oas3-valid-schema-example  schema is invalid: data/type must be equal to one of the allowed values, data/type must be array, data/type must match a schema in anyOf
 error  oas3-valid-schema-example  type must be JSONType or JSONType[]: [object Object]

I have no issue when generating code with this definition.

@sydneyhenrard yes, you can definitely name a property anything you want, so I don't see a problem here.  You should raise your question with the Spectral folks, as we don't have the resources to  trouble-shoot tooling issues here in the spec repository.


chore: Clean up <CookieWarning />

Description 📝

Testing my bot
Updates <CookieWarning />

Please add a chageset to your PR 🥺🚨

Please add a chageset to your PR 🥺🚨

Please add a chageset to your PR 🥺🚨


Import

Add the ability for the admin to import memos from the filesystem... this should include updating the JSON and Memo names to UUIDs  And a screen to verify which ones to actually import
Could be at a user/memo/version or user/memo or user or group of users

Perhaps if there is no meta data files... then create meta data?

use json
if the filenames are not UUIDs then make/rename as part of the import
use the directory structure
how do you assign memo numbers?


Add dockerfile for docker containerization

Add dockerfile and tweaked readme to add docker instructions

can you add a ci build of this to push to ghcr? having all these in a single pull request would be a good idea


Better handle the case where one item appears on many works

Sierra allows a single item to appear on multiple works – for example, multiple works or images that have been bound together. But there's only one physical item, and if one person requests it then nobody else can request it.
In one of the most extreme cases, an item appears on over 700 works: https://wellcomecollection.org/works?page=1&query=b8bgjpur
This causes a few issues:

It's confusing for users. They request an item and expect to get one thing, and actually they get a much bigger thing. It's not obvious to them they've got the right thing, or how to find what they were originally looking for.

We forget what they actually requested.
For example, I placed a request on b13742036 (Matthew Gwinne, M.D). The same item appears on 704 other works. If I look in my list of requests in Encore/OPAC, it shows me b12873251 (The roll of the Royal College of Physicians of London), which is a completely different works. If I don't have my own notes, I won't remember what part of this I was looking for.

We should consider whether there's a better way to present this information, so we can make it less confusing for visitors.

Here's one initial thought about we could make this better:

Remember which work an item was originally requested from, and include that in the list of requests
Include a note telling them how many other works have this item

e.g.


build: perform parallel builds of BlocksRuntime

Build both the static and shared variants of the BlocksRuntime.  This is needed
for proper shared linkage to the BlocksRuntime (e.g. when building SourceKit).
Build both variants and install to the appropriate location.

CC: @gottesmm @kevints

Discussed with @kevints offline.  We have a better approach that we are going to be taking and this change will be revised with a new version.


Added a mechanism to avoid datetime.datetime issues when serializing dat...

Hello,
I was wondering whether we could add the lines of the pull request to tablib. It p[revents an error message when serializing datetime.datetime objects.
Up to you.
Cheers
H

:sparkles: :cake: :sparkles:


[1.18.1] Appears to break REI recipe lookup

Nice work on the mod!!
Trying it out I noticed with your mod in the mix the REI "u" and "r" don't appear to work for recipe lookup.   After disabling the mod and NBTCrafting, REI works fine.
Keep up the good work.

In my testing I was not able to reproduce this issue, but the last release made some significant changes that might fix the problem. Let me know if the issue persists so I can keep looking into it, or close this issue.

Also, thank you so much for all the positive encouragement. Means a lot.

Thanks for looking into it.  Im testing it now.

I remember when I started making mods, nice to get some recognition for hard work.

This issue seems to be resolved, so I am going to close this. Please reopen this issue if the problem persists.


microk8s.reset still running after +2 hours

Using microk8s 1.18.2 stable. After a flawed attempt to upgrade istio outside of microk8s I ended up with a partial updated of istio. I decided to reinstall microk8s from scratch by
$ microk8s reset
$ sudo snap remove microk8s

microk8s reset still running since more than 2 hours. The activity monitor shows microk8s-reset.wrapper at 0% CPU but the LED of the hard drive is still blinking nonstop since microk8s reset was started.
Attached is the inspection report created by microk8s inspect on a new terminal, while microk8s reset is still running since +2 hours.
inspection-report-20200527_005622.tar.gz

I can see the cluster is not healthy. The apiserver is complaining. This is most probably why microk8s reset kept retrying to cleanup any running workloads. I could offer more insight on what went wrong if you give me a way to reproduce the setup you have.

Im actually surprised that you're not facing issues.  The hostname has capital letters.
Either change it to all small or add --hostname-override in kubelet.

@balchua can you elaborate a bit more on "add --hostname-override in kubelet"?

I could offer more insight on what went wrong if you give me a way to reproduce the setup you have

@ktsakalozos this would be quite time consuming, not sure if it would be worthwhile of your time for now. If there was nothing obvious in the inspection report. Maybe you can close that issue?
I am testing an application which uses an open source stateful serverless technology which is called Cloudstate. This needs a Custom Resource Definition called cloudstate operator. The tech is in alpha stage at the moment. The deployment and testing the service is not very smooth for now. It would be more time efficient if I break down the support request in smaller chunks.


Do we need a navbar in the first and second page?

What do you think guys?
Do you think it makes sense to leave the navbar on the first and second page?

I don't think a navbar is necessary for this project actually as the views are sequential, you have to go through the whole flow for it to make sense, right? My instincts say scrap it

Hmm, I think the current navbar isn't much use, but it could be useful to have navigation for home forwards and backwards. I'm also well into bottom navbars for mobile as they look native n slick.


Unrecognized argument in launching the shell with docker

I am trying to launch the p4rt shell with docker on the exercises in the tutorials (https://github.com/p4lang/tutorials/tree/master/exercises/p4runtime) with the command :
[sudo] docker run -ti -v ../tutorials/exercises/p4runtime/build/:/tmp/ p4lang/p4runtime-sh --grpc-addr <IP_ADDRESS>:50051
--device-id 0 --election-id 0,1
--config /tmp/advanced_tunnel.p4.p4info.txt, /tmp/advanced_tunnel.json
but I got "unrecognized argument: /tmp/advanced_tunnel.json"
These are the two files that the P4 compiler creates when I launch the exercise. I also tried:
[sudo] ./p4runtime-sh-docker --grpc-addr <IP_ADDRESS>:50051
--device-id 0 --election-id 0,1
--config ../tutorials/exercises/p4runtime/build/advanced_tunnel.p4.p4info.txt, ../tutorials/exercises/p4runtime/build/advanced_tunnel.json
and I got " CRITICAL: root: " " is not a valid file"
Since on the README, there is written to use the bmv2.json file created by the compiler, I cannot understand where is the problem.
Does anyone know how to fix it?
P.S. I also tried 9559 as the port number, but I got the same result.

looks like you have a whitespace between the 2 files, so it would be interpreted as 2 command-line arguments instead of 1: --config /tmp/advanced_tunnel.p4.p4info.txt, /tmp/advanced_tunnel.json

Thank you, now it's working.


Remove locks around method and field ID retrieval

Closes #1005.

coverage: 92.009% (-1.7%) from 93.677%
when pulling 1e7116d71bd9e3297f0a501e464a864a01de8aaa on no-lock
into 71ada4b5c8001e6b8207ed40331d158e0912cd94 on main.


Backtrack not working

Heya just wanted to test this, and seems after the new update backtrack doesn't work? ms set to 200 I do slowmotion and backtrack simply just doesn't work. Never had an issue before, worked fine 2 days ago

It's working as intended, the problem lies within your paste or PC.


fix(kafka): update kafka lib; make kafka errors unsilent

Errors on sending to kafka when they failed, used to fail silently. This
lead to user frustration.  This updates the kafka client and injects a
logger so they now fail loudly.

@nathanielc yes I have.

This is good news.  We have been running into these problems.  Is it possible to create a docker image?: https://hub.docker.com/_/kapacitor


Update security-windows.md

Network security needs to allow traffic to Common and shared infrastructure endpoints in addition to Teams endpoints.

Learn Build status updates of commit e4835ec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/rooms/security-windows.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Correct method for passing "orderBy:" as a variable?

I'm trying to pass in the "orderBy:" parameter as a variable in the GraphiQL client, but I'm not sure how:
query getRegions ($order: String) {
  iwRegions (range: [0, 4], orderBy: $order) {
    name
  }
}

with variables:
{
  "order": "name"
}

but I get an error message:
{
  "errors": [
    {
      "message": "Variable \"$order\" of type \"String\" used in position expecting type \"IwRegionPropertiesEnum\".",
      "locations": [
        {
          "line": 1,
          "column": 19
        },
        {
          "line": 2,
          "column": 38
        }
      ]
    }
  ]
}

How should I do this?
Thanks,
Adrian

Maybe this https://stackoverflow.com/questions/35946313/how-to-set-a-relay-variable-as-an-enum-value/35987582#35987582 ?

Does this work?
query getRegions ($order: IwRegionPropertiesEnum) {
  iwRegions (range: [0, 4], orderBy: $order) {
    name
  }
}

I can't get it to work, but... GraphiQL is doing something odd. When I paste the above (with a few extra columns included in the query), and then try to set up the variables, the typeahead functionality in the variables pane forces the following:
{
  "order": "name"
}
or similar, for the other column names (if I add them to the query).

Executing the query then produces:

{
"data": {
"iwRegions": null
},
"errors": [
{
"message": "undefined passed as argument #0 for 'orderBy' operation. Call skipUndefined() method to ignore the undefined values.",
"locations": [
{
"line": 2,
"column": 3
}
],
"path": [
"iwRegions"
]
}
]
}

Note the line number at "node_modules\objection-graphql\lib\argFactories.js:119:15" should be 118, but I stuck a 'console.warn()' in at 118

@Trellian I found a bug in this. It's now fixed in master

Awesome! Thank you!


Feat/task 4746

The proliferation of Swagger annotations means that there is a lot of duplication, and it makes it difficult to properly compose the controller operations into a single class.
Use Java annotation(s) to remove duplicated Swagger annotations from controller methods.

Hey, this is a module consumed by stacks-java, therefore shouldn't it be agnostic to the type of API someone writes? It seems this references things specific to the Demo Menu API app

Hey, this is a module consumed by stacks-java, therefore shouldn't it be agnostic to the type of API someone writes? It seems this references things specific to the Demo Menu API app

Where are you seeing specific Menu type changes? I've looked through the code and cannot see anything that I would consider generic

/azp run


feat(azure-iot-device):  Add 'downstream/leaf' device sample for IoT Edge

Thank you for helping us improve the Azure IoT Python SDK!
Need Support?

Have a feature request for SDKs? Please post it on User Voice to help us prioritize
Have a technical question? Ask on Stack Overflow with tag "azure-iot-hub"
Need Support? Every customer with an active Azure subscription has access to support with guaranteed response time.  Consider submitting a ticket and get assistance from Microsoft support team
Found a bug? Please help us fix it by thoroughly documenting it and filing an issue on GitHub (See below).

Here's a little checklist of things that will help it make its way to the repository: Note that you don't have to check all the boxes, we can help you with that.
This being said, the more you do, the quicker it'll go through our gated build!
-->
Checklist

[ x] I have read the contribution guidelines.
[n/a ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
If this is a modification that impacts the behavior of a public API

[n/a ] I edited the corresponding document in the devdoc folder and added or modified requirements.

Description of the solution
there were no existing samples that showed how a 'downstream' or 'leaf' device could connect to IoT Edge using the V2 SDK.  The existing 'edge' sample scenarios were all for iot edge 'modules'.  So I added a very simple sample that will hopefully save customers some research time, particularly in how to feed the IoT Edge TLS certificate's root ca cert in so that it's trusted by the leaf device

/azp run Azure.azure-iot-sdk-python

/azp run Azure.azure-iot-sdk-python

/azp run Azure.azure-iot-sdk-python

/azp run

/azp run Azure.azure-iot-sdk-python

/azp run Azure.azure-iot-sdk-python-horton-e2e

Hi @stevebus , apologies for the delay here. Agreed that this sample should exist, but our current model is to have more specific scenarios (like this) reside in a customer-facing Azure Samples repo rather than this one. This could be an opportunity to work with the docs team for a quickstart around this. Starting a side thread now to discuss.

Ok, @elhorton and @jebrando ...  per our discussions, I restructured to put my sample in with the other edge samples (at least I think I successfully did :-)).  Let me know if it looks ok now.

thanks @stevebus, looks great. made small adjustment and will work to merge soon. appreciate your help!

/azp run Azure.azure-iot-sdk-python-dps-e2e


WIP: user-operation-was-included-in-block RPC

Problem
There's no way to know if an operation was included in a block. We want to be able to do this for accurate benchmarking.
Solution
This is a bad solution: we just search all the applied blocks. Keeping the applied blocks is already bad - we should instead use an indexer, as discussed in #535. But this approach is "good enough" till we have a proper indexer.
Related

#535
#539

I marked this as draft until @lykimq has a chance to test this.

@d4hines I messed up with the rebase with main, and it took more time to fix git, so I decide to fork this branch and close it. Sorry about it.


Paraphraser added

Added Paraphraser from prebuilt model
Have modularized the code for better support in future.
Added a test case in main.py for testing the implementation.

Merging the Paraphraser unit from Gaurav


Instantiate ixmp.Platform() hangs forever

Code sample or context
import os
import pandas as pd
import ixmp as ix
import message_ix

mp = ix.Platform()

Expected result
Return an object.
Problem description
The code is running as expected inside the message_data module.
In the console the code hangs.
Versions
Output of ixmp show-versions
'ixmp show-versions' in a terminal:
msg_kit ixmp show-versions

ixmp:        3.9.1.dev0+g35da509.d20240726
     e12922f (HEAD -> main, origin/main, origin/HEAD) Merge pull request #532 from iiasa/issue/531
message_ix:  3.9.0
     1125579 (HEAD -> main, tag: v3.9.0, origin/main, origin/HEAD) Clarify release procedure
message_ix_models: 2024.4.23.dev803+ge76bbd33
     4d95695c (HEAD -> main, origin/main, origin/HEAD) Merge pull request #195 from iiasa/costs/fom-vintage
message_data: 2020.6.21.dev3109+gfff251a4e
     b1114e7b7 (HEAD -> il/transport-2024-01-20, origin/il/transport-2024-01-20, il/transport-2024-04-16) Edit the il docs

click:       8.1.7
dask:        2024.7.1
genno:       installed
graphviz:    0.20.3
jpype:       1.4.0
… JVM path:  /opt/miniconda3/envs/ME_X86_P3.10/lib/jvm/lib/libjli.dylib
openpyxl:    3.1.5
pandas:      2.2.2
pint:        0.24.3
xarray:      2024.6.0
yaml:        6.0.1

iam_units:   installed
jupyter:     installed
matplotlib:  3.9.1
plotnine:    0.13.6
pyam:        2.2.3

GAMS:        36.2.0

python:      3.10.14 | packaged by conda-forge | (main, Mar 20 2024, 12:53:34) [Clang 16.0.6 ]
python-bits: 64
OS:          Darwin
OS-release:  23.2.0
machine:     x86_64
processor:   i386
byteorder:   little
LC_ALL:      None
LANG:        he_IL.UTF-8
LOCALE:      ('he_IL', 'UTF-8')

Please see #538 and https://github.com/iiasa/ixmp/issues/538#issuecomment-2254995425 in particular; I think this behavior is a good indicator that my comment there is moving you in the right direction :)

Thank you for the answer, problem solved.


Request: demo

Could you please publish a demo via Github Pages?

@lolmaus I just put together the most basic implementation of this addon.  You can clone it here https://github.com/malchak/notify-example, and run it locally.

Awesome, thank you! There's only one step left: build the demo and push it to the gh-pages branch of malchak/notify-example.

Hi there, sorry for the quiet on this issue, been very busy getting a beta release ready. I've nearly finished a project page for this, but I'm moving all my project pages to my blog, and it's not finished yet. Will advise when it's done (hopefully soon).

I've finally added a project page and demo to my blog: http://aexmachina.info/ember-notify. Enjoy!

Nice, thank you.


sql_exporter does not recover from killed connection

Even if the MySQL database is available again, the exporter still indicates that the database would be offline.
Restarting the exporter solves the problem.

I0617 09:38:10.729547   25695 promhttp.go:38] Error gathering metrics: [from Gatherer #1] bad connection
I0617 09:38:25.729122   25695 promhttp.go:38] Error gathering metrics: [from Gatherer #1] bad connection
I0617 09:38:40.730307   25695 promhttp.go:38] Error gathering metrics: [from Gatherer #1] bad connection

Our configuration:
---
# Global defaults.
global:
  scrape_timeout_offset: 500ms
  min_interval: 0s
  max_connections: 3
  max_idle_connections: 3

target:
  data_source_name: {{ item.url }}

  collectors: [managed_mysql]

collector_files:
  - managed_mysql_collector.yml

---
collector_name: managed_mysql

metrics:
  - metric_name: mysql_stats
    type: gauge
    help: 'Get lots of stats'
    key_labels:
      - Variable_name
    values: [Value]
    query: |
      SHOW status
      WHERE variable_name
      IN ('threads_connected',
          'Aborted_clients',
          'Aborted_connects',
          'Access_denied_errors',
          'Acl_users',
          'Bytes_received',
          'Bytes_sent',
          'Connections',
          'Max_used_connections',
          'Memory_used',
          'Uptime',
          'Innodb_data_read',
          'Innodb_data_reads',
          'Innodb_data_writes',
          'Innodb_data_written'
          )

I decided to switch to the fork burningalchemist/sql_exporter which has updated multiple dependencies.

Still suffering from the same issue.  The exporter is not recovering from DB connectivity problems.  Anybody has an idea on how to resolve?

Hello 0xErnie,
Thank you for your reply.  I have not tried your solution by switching to the burningalchemist/sql_exporter.  Is this solution fully upward compatible?  What is your experience with it?
rgardelein


Bug with Textarea autosizing feature when livewire update is triggered on filament page

Package
filament/filament
Package Version
v3.2.97
Laravel Version
v10.48.19
Livewire Version
v3.5.4
PHP Version
PHP 8.2.17
Problem description
On edit or create form when you have Textarea component and autosize() is enabled on first page load (in case of edit page) component behave ok. But if any action on that page triggers change (livewire update) then textarea component will shrink to default height. If you then type again something in the textarea component then it will resize properly.
Expected behavior
If autosize is enabled on the textarea component I want to be able to see whole text in component always without the scrollbar.
Steps to reproduce
Add Textarea component with autosize() option enabled in any form. Then add Toggle component with live() option enabled so that something can trigger change on the edit page.
\Filament\Forms\Components\Toggle::make('check_me')->live(),
\Filament\Forms\Components\Textarea::make('description')->autosize()

Add few lines of text in the Texarea component. Then go to edit page. Everything should be fine. All lines in the text area should be visible. Now, trigger the changes with Toggle component and text area component will shrink to some default height.
Reproduction repository (issue will be closed if this is not valid)
https://github.com/filamentphp/filament
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Encountered the same problem which can be reproduced by adding this simple snippet to a Page:
public function table(Table $table): Table
{
    return $table
        // ...
        ->actions([
            TableAction::make('some action')
                ->button()
                ->form(
                    function () {
                        return [
                            Textarea::make('some action')
                                ->default(str_repeat('a', 1000))
                                ->hintAction(
                                    FormAction::make('trigger livewire request')
                                )
                                ->autosize()
                        ];
                    }
                )
        ]);
}

That bug is fixed in version 3.2.98. Just update filament package to the latest version.


Translated blog falco-2020

/kind content
/kind translation
/area blog
What this PR does / why we need it:
Translated blog "Falco in 2020" to Japanese.
/assign @leodido
/assign @fntlnz
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajakavitha1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rajakavitha1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @rajakavitha1 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TakaoShimizu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TakaoShimizu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TakaoShimizu: PR needs rebase.

Hi @TakaoShimizu
I'm trying to rebase this PR for you.

@TakaoShimizu: PR needs rebase.

Hi @TakaoShimizu
I'm trying to rebase this PR for you.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ded78d5a9cd07e28c6f5e9237a0af948fd65fa66

LGTM label has been added.  Git tree hash: ded78d5a9cd07e28c6f5e9237a0af948fd65fa66

Thank you so much @TakaoShimizu ! 🤗

Thank you so much @TakaoShimizu ! 🤗


Minor docs fixes

This fixes few minor docs/ tickets as listed

#1511
#1582
#1592
#2041
#2231
#2731
Adds a MySQL troubleshooting guide

As I am a GSoD'19 applicant; prev

https://github.com/mattermost/docs/pull/2697
https://github.com/mattermost/docs/pull/2698

Reviews:
Jason - config-settings.rst
Katie - bulk-export.rst
Paul - config-settings.rst

Carlos review: New document - source/install/trouble_mysql.rst.

@icelander Do the changes to the config-settings.rst look correct?

Hi @tapaswenipathak, wondering if you'd be open to migrating the changes you made to the source/administration/config-settings.rst file to a new pull request as there starts to be merge conflicts in this pull request due to other recent changes we've made to that specific file?
That way we can also get this pull request merged and then continue to review any edits you make to source/administration/config-settings.rst file in a separate pull request.


integration test notification via updateMessageHandler

closed via https://github.com/jwhited/corebgp/commit/f203fa78c0f6252097e4cd9e3984dd99e04485f9


Windows 7 driver issues

So I'm trying to use this inside a Windows 7 VM, and the driver doesn't install itself on this OS. I tried to use the FTDI VCP drivers but without success. What driver should I use for this to work?

You need an INF file referencing usbser.sys driver. There is not a universal one. Here is one from a long time ago for a Atmel Raven USB Stick. You will need to edit this and change VID/PID and optionally strings.
RZUsbStick.txt (rename to *.inf)

I just found a similar solution just after I made the issue, but thanks for the help!!