Spacy 2.0

I'm wondering if it's possible to work with SpaCy 2.0.
I can change the dev-requirements and force it to version 2.0
However, I not sure about the impacts. Anyone have look it?

I don't know of anyone who has tried it. If you do let us know how it goes, but I was under the impression that 2.0 was a big breaking change though.
Is there a specific need driving the desire for 2.0 or just curiosity?

since we aren't doing any model training with spacy at the moment I guess there shouldn't be a big issue there (you should avoid using and training models with different spacy versions though, so just keep them consistent). but tbh I haven't tried it for a couple of weeks because it was still very unstable when I touched it.

Has anyone tried this (rasa + spaCy 2.0)?

not that I know of

I tried and get some errors, @wrathagom have you got plans to support spacy 2?

I tried and get some errors, have you got plans to support spacy 2?

I tried and get some errors, @wrathagom have you got plans to support spacy 2?

@vctrferreira what error did you get?

First visible error is when instantiated spacy, in file spacy_utils.py line 109
if nlp.path is None:
nlp object has no attribute path, I solved this problem removing this block
Second error is when I parse new interpretations, new interpretations returns first interpratation every time

@tmbo
I tried with English model and Portuguese, that last one I have build from scratch, both give me the same error, like @vctrferreira said.
INFO:rasa_nlu.utils.spacy_utils:Trying to load spacy model with name 'en'
Traceback (most recent call last):
  File "/root/anaconda3/envs/spacy2/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/root/anaconda3/envs/spacy2/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/home/renato/Arquivos/rasa/rasa_nlu/train.py", line 96, in <module>
    do_train(config)
  File "/home/renato/Arquivos/rasa/rasa_nlu/train.py", line 83, in do_train
    trainer = Trainer(config, component_builder)
  File "rasa_nlu/model.py", line 124, in __init__
    component = component_builder.create_component(component_name, config)
  File "rasa_nlu/components.py", line 327, in create_component
    component = registry.create_component_by_name(component_name, config)
  File "rasa_nlu/registry.py", line 136, in create_component_by_name
    return component_clz.create(config)
  File "rasa_nlu/utils/spacy_utils.py", line 53, in create
    cls.ensure_proper_language_model(nlp)
  File "rasa_nlu/utils/spacy_utils.py", line 109, in ensure_proper_language_model
    if nlp.path is None:
AttributeError: 'English' object has no attribute 'path'

spacy 2.0 is still not stable - but as soon as there is a stable release or a release candidate we will quickly add it. (which doesn't say that you can not provide a PR to provide support for the alpha version in the meantime ;))

We're getting closer to a RC, although there's still a bit to do. The policy re breaking changes has been to keep the Doc, Token and Span API pretty much the same compared to the 1.x branch. There have been changes to training, vectors, saving and loading, and the NLP pipeline.
At the moment we're breaking model compatibility very often with the nightlies, so you'll have to redownload (and retrain models) a lot. On the plus side, accuracy is improving pretty quickly. The NER model is now at 86.5% F1 on OntoNotes 5, a 30% error reduction over spaCy 1. The current model is rather slow on CPU, but I've got a branch that's hitting a better speed/accuracy trade-off.
More details here: https://alpha.spacy.io/usage/

@honnibal sounds great, I am excited for the changes 2.0 brings. I'll keep an eye out for the RC.

First of all, thanks for the great product!

Do you have plans to integrate it anytime soon?

just tried it and it seems to work out of the box ™. Nevertheless, there are a couple of cool features we can add with that new versions. did you run into any issues @shasha79

Hi @tmbo with our team we are going to test it (v2) in our dev environment ! I'll keep you informed !

@Moumouls sounds great - keep me posted :+1:

Are there any plans to accommodate training spacy (2.0) ner/intent models? (As opposed to only allowing for built-in spacy models)

Hi ! I have good news after few tests on our dev environement, it seems that Spacy 2.0.2 is fully compatible with the last version of Rasa 10.4.
I have tested training a small model with FR language and to use it : it works (with the http server).
I have just to reported one thing, training time seems to be a little bit longer.
I have a suggestion too : when we provide a training for a project wich not have a folder, don't show an error "Project don't exist", i think that it's more flexible if Rasa can create on the fly the folder and use the new project.
So you have all the advantages of Spacy v2 ready to run !
@tmbo

Sounds great!
@roryjbeard definitely.
@Moumouls concerning the project suggestion, can you create a separate issue for that so we don't forget about it?

@tmbo no problem for the project suggestion !

I just re-check @tmbo, the project creation on the fly works ! So it's fully flexible.

:tada:
It's true that training is slower. There are also tonnes more hyper-parameters, unfortunately. The docs are much better though: https://spacy.io/usage/training
I have some doubts about the add-a-label functionality when using a pre-trained model, so you should test that carefully.

supported in latest release 0.11.x


bug with timeseries

When the time in timeseries past 00:00 than the chart doesn't go further.
See example in jsfiddle: http://jsfiddle.net/7kYJu/998/
when you remove 00:00 en 01:00 than the chart is good

Hi,
This is expected and not a bug because c3 is implemented to sort data based on x when loading. And I think 00:00 and 01:00 are not clear enough to know it's later than 23:00. So, please try +24h format (e.g. 24:00 http://jsfiddle.net/7kYJu/1102/ ) or add yyyymmdd to the xs.


the -f option seems to have stopped working in build 7865 (works in 6943)

Describe the bug
My scheduled CI from 6 days ago succeeded: https://github.com/ansible-collections/community.hashi_vault/runs/3281498133?check_suite_focus=true#step:6:561
The scheduled CI from the next day, with no changes, failed: https://github.com/ansible-collections/community.hashi_vault/runs/3292087124?check_suite_focus=true#step:6:29
I am directly providing every file to be uploaded via -f options. This was working fine, now it can't find any files.
I tried this locally as well, downloading the latest version of the script, and I can't get it to recognize any files that way. Adding verbose, it looks like it's ignoring the -f option (though not completely, because I don't add it and it can't find any files, it says I should use -f to specify the files to upload).
To Reproduce
Steps to reproduce the behavior:
codecov -f path/to/file.xml

Expected behavior
Specified file(s) uploaded
Screenshots

Additional context
The thing that puzzled me is that both before and after it broke, the version returned by the binary is 0.1.0. Looking at your releases page it now seems like you release new versions without changing the version number? If so, that means I don't have any way of trying to download an older version to see if the behavior really changed. I also can't get the binary to show me a specific build/commit which would have also helped diagnose the difference.
A new build was released right around when the behavior seemingly changed. It contains 16 commits but I can't really tell which if any of them may have contributed to it:
https://github.com/codecov/uploader/compare/v0.1.0_7865...master
Edit: I see that there are tests for finding specific files with -f, and presumably those tests hadn't failed, so I'm not entirely sure what I'm seeing, I just know it was working 6+ days ago, and since then, it isn't :(

confirmed
I put up a PR in my repo ( https://github.com/ansible-collections/community.hashi_vault/pull/129 ) that downloads the previous build direct from the github release, and with that previous release everything is working: https://github.com/ansible-collections/community.hashi_vault/runs/3334647366?check_suite_focus=true#step:6:362
I also confirmed this locally.
So, build 6943 works fine.
The build I get when downloading "latest" via https://uploader.codecov.io/latest/linux/codecov (which I presume is build 7865) is not working.

@briantist Regarding older versions, if you drop latest from the URL, you can see all the versions available
Regarding the -f flag, we'll take a look.

@briantist Regarding older versions, if you drop latest from the URL, you can see all the versions available

I figured that out eventually, see https://github.com/ansible-collections/community.hashi_vault/pull/130 , but please consider actually including your build as part of the version number, and reporting it from the application itself. It would have been easier to troubleshoot if I could have clearly seen that the version changed based on the output.

Regarding the -f flag, we'll take a look.

Thanks


feat(telemetry): Remove consent confirmation prompt for kedro-telemetry

Description
Partly solves https://github.com/kedro-org/kedro-plugins/issues/726
Development notes

_confirm_consent was removed
now we use consent from the .telemetry file if it exists and has a valid format otherwise, we consider consent is True

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes

A few things:

I contend that we should merge this one before proceeding with https://github.com/kedro-org/kedro/pull/3976
Maybe we could try to address #728 in this same PR
I gave this a try with a previously created project, and got this:

$ kedro run
[07/04/24 08:19:51] INFO     Using `conf/logging.yml` as logging configuration. You can change this by setting the KEDRO_LOGGING_CONFIG environment __init__.py:249
                             variable accordingly.
                    ERROR    Failed to retrieve UUID: badly formed hexadecimal UUID string                                                             plugin.py:78
[07/04/24 08:19:52] WARNING  Failed to send data to Heap. Response code returned: 400, Response reason: Bad Request                                   plugin.py:336
                    WARNING  Failed to send data to Heap. Response code returned: 400, Response reason: Bad Request                                   plugin.py:336

which is probably not related to this PR, but maybe it's too scary (specially given that it's printed twice, maybe because of #730?). I think there are 2 things here:

The "Failed to retrieve UUID" message introduced in #596 could maybe be "Could not find or create project UUID" and maybe set it as a warning (although I'm hesitating whether the user needs to see it at all)
The HTTP 400 to Heap was unexpected, maybe there's something wrong when the Project UUID is empty? https://github.com/kedro-org/kedro-plugins/blob/92bf6ebaa249c9e144fc6fee18a83b76973c13f2/kedro-telemetry/kedro_telemetry/plugin.py#L80

And finally, the "Kedro is sending anonymous usage data" message I proposed in https://github.com/kedro-org/kedro-plugins/issues/715 is not being shown.

A few things:

I contend that we should merge this one before proceeding with Make kedro-telemetry a core dependency kedro#3976
Maybe we could try to address kedro-telemetry: Introduce environment variables for disabling telemetry and revise disabling methods #728 in this same PR
I gave this a try with a previously created project, and got this:

$ kedro run
[07/04/24 08:19:51] INFO     Using `conf/logging.yml` as logging configuration. You can change this by setting the KEDRO_LOGGING_CONFIG environment __init__.py:249
                             variable accordingly.
                    ERROR    Failed to retrieve UUID: badly formed hexadecimal UUID string                                                             plugin.py:78
[07/04/24 08:19:52] WARNING  Failed to send data to Heap. Response code returned: 400, Response reason: Bad Request                                   plugin.py:336
                    WARNING  Failed to send data to Heap. Response code returned: 400, Response reason: Bad Request                                   plugin.py:336

which is probably not related to this PR, but maybe it's too scary (specially given that it's printed twice, maybe because of #730?). I think there are 2 things here:

The "Failed to retrieve UUID" message introduced in feat(telemetry): Unique User IDs in kedro-telemetry - merge only for kedro-telemetry release 0.4.0 #596 could maybe be "Could not find or create project UUID" and maybe set it as a warning (although I'm hesitating whether the user needs to see it at all)
The HTTP 400 to Heap was unexpected, maybe there's something wrong when the Project UUID is empty? https://github.com/kedro-org/kedro-plugins/blob/92bf6ebaa249c9e144fc6fee18a83b76973c13f2/kedro-telemetry/kedro_telemetry/plugin.py#L80

And finally, the "Kedro is sending anonymous usage data" message I proposed in #715 is not being shown.

@astrojuanlu, thank you for the review!

I believe there is not much difference if we merge this PR before #3976 or after as it only removes the consent confirmation prompt and works fine with the latest kedro==0.19.6 version and changes introduced in the PR #3976
I think we can follow @DimedS split and address #727 ("Kedro is sending anonymous usage data" will be added with this PR) and #728 separately on top of this PR and, once they're ready, merge them together one by one.
I was not able to reproduce the errors you mentioned. I've tested the current change on spaceflights-pandas with kedro==0.19.6 and changes from here #3976. Both work well. I double checked the response status when sending to the heap - it looks good - 200 OK. I also checked that project ID is creating well and is part of the query. But anyway, the current changes cannot not affect the project ID logic. Could you please check if the error is not appearing for you without current changes?


Suggestion: Enable inferring the result type of a generic function based on the context in which it is used

It's a very common situation in our code when we wish TypeScript could infer the result type of a function with a generic result based on the context in which that function is used. Here are a couple of use cases to support the feature request:
Case 1: Generic fail function (for being able to throw from an expression)
function fail<r>(message: string) : r { throw new Error(message); }
function id<a>(value: a) : a { return value; }
function withFew<a, r>(values: a[], haveFew: (values: a[]) => r, haveNone: (reason: string) => r) : r {
    return values.length > 0 ? haveFew(values) : haveNone('Array is empty.');
}
var values = Math.random() > 0.5 ? ['a', 'b', 'c'] : [];
var few = withFew(values, id, fail); // <-- actual result is {}, expected is string[]

Case 2: Empty container constructors:
function toArrayOf<a>() : a[] { return []; }
function id<a>(value: a) : a { return value; }
function withSome<a>(valueOpt: a, haveSome: (value: a) => r, haveNone: (reason: string)  => r) : r {
    return valueOpt != null ? haveSome(valueOpt) : haveNone('Value is unspecified.');
}
var valuesOpt = Math.random() > 0.5 ? ['a', 'b', 'c'] : null;
var values = withSome(valueOpt, id, toArrayOf); // <-- actual result is {}, expected is string[]

Case 3: Sum types (empty container sort of case)
interface Optional<a> { some?: a; none?: string;  }
function fromSome<a>(value: a) : Optional<a> { return { some: value }; }
function fromNone<a>(reason: string): Optional<a> { return { none: reason }; }
var value = Math.random() > 0.5 ? fromSome(123) : fromNone('Not this time'); // <-- acutual Optional<{}> expected Optional<number>

fromNone should not be defined as generic. Generic type parameter a has no manifestation in the argument, and in return has no runtime impact. there is no way for function fromNone to observe the type a at runtime; and i believe this is the same issue with other examples as well.. the intended type flow is rather artificial.
the call to fromNone<number>('string') is just sugar for a cast <Optional<number>> fromNone('string'); I do not see how the compiler should figure this type out from use cases?
I think a better typing would not make fromNone gneric:
function fromNone(reason: string) { return { none: reason }; }
var value = Math.random() > 0.5 ? fromSome(123) : fromNone('Not this time');

this way value here is Optional<number>|{none:string}, which is correct representation of the two values. the only property that is exists in both branches is none?: string. contextual type can be used then to make value: Optional<number>.

fromNone is a constructor for the Optional<a> type, it has to be generic in order to produce Optional<a>

you are right that the a parameter is no use in fromNone function, i deliberately simplified the example for better clarity, the original definitions that we use in production code look that this:

interface Optional<a> {
   'an optional': Optional<a>; // a brand to get a nominal type: https://gist.github.com/aleksey-bykov/0ab85f0b5e83fc848f85
   'depends on a': a;              // an explicit yet nominal use of `a` to make it a part of the object surface: https://github.com/Microsoft/TypeScript/issues/468
}
function fromSome<a>(value: a) : Optional<a> { return <any> { some: value }; }
function fromNone<a>(reason: string) : Optional<a> { return <any> { none: reason }; }

sugar or not the whole point of the none case is to be able to encode a type which is missing a value, your suggestion about a uion with {none:string} keeps only a missing value while discards the information about the type itself, but the type cannot be thrown away because the whole purpose for having it in the first place is to enforce a set of permitted operations, consider:

// with type omitted
interface Optional<a> { some?: a; none?: string; }
function fromNone(reason: string) { return { none: reason; }
var noUser = fromNone('There is no user you are looking for.');
var noAccount = fromNone('There is no account either.');
noUser = noAccount; // since no type is in place the assignment is legit albeit doesn't make sense

// with type preserved
interface Optional<a> { 'uses a': a; }
function fromNone<a>(reason: string) : Optional<a> { return <any>{ none: reason; } }
var noUser = fromNone<User>('There is no user you are looking for.');
var noAccount = fromNone<Account>('There is no account either,');
noUser = noAccount; // <-- disallowed as it should be, since doesn't make sense

i am surprised to see you clueless as for where i am coming from, take a look at Options in F#: https://msdn.microsoft.com/en-us/library/dd233245.aspx they are generic and they have both constructors for the some and none cases and if you take a closer look at the none case you can see it is generic too https://msdn.microsoft.com/en-us/library/ee340390.aspx

basically any FP languge has it, and i just wish TypeScript had some of its features too and wasn't that much of OOP and C#

@aleksey-bykov How did you not get a type mismatch error on the return expression of fromNone in case 3? string is not compatible with a type parameter.

@aleksey-bykov I think what you are asking for is a persistent bottom type that will be inferred when there are no inference candidates, and will be subsumed by all other types. Similar to null or undefined, except that it would not widen to any, or at least it would not widen at the end of type argument inference.
Your suggestion to infer from the context would work for case 1 and case 2, but not case 3 because case 3 has no contextual type, it's just a union.
But actually I think @mhegazy is right that these functions should not generic. What you really want is for them to return some bottom type that will not widen.
@aleksey-bykov I will also add that many of the cases you are mentioning suggest that you are trying to do type unification in TypeScript. The inference system in TypeScript is not unification based. Unification treats all occurrences of a type as equal citizens when it comes to inference, even if the direction of inference does not match the direction of the flow of values. By contrast, TypeScript's inference is direction sensitive. In only infers types in the direction that matches the value flow. This is why it infers from parameters, but not return types. It is the same reason TypeScript does not infer the type of a value based on how the value is used later on.

@JsonFreeman

I think what you are asking for is a persistent bottom type that will be inferred when there are no inference candidates

Very well could be, although my though was that return types in such situation can only be inferred when there is at least one candidate whose type would be the type of the result.

Similar to null or undefined, except that it would not widen to any, or at least it would not widen at the end of type argument inference.

I wish at this point I could say definite yes or no, but I don't know the domain subject so well so I have to trust someone who claims to know it better.

... but not case 3 because case 3 has no contextual type, it's just a union.

Can't see how case 3 is different from say case 2. Anyway with new cool features of TS 1.6 (with parameters in type aliases and custom type guards) case 3 can already be taken down as irrelevant.

But actually I think @mhegazy is right that these functions should not generic. What you really want is for them to return some bottom type that will not widen.

Indeed using a specific case of a union (a sum term) rather that a all-cases-considered container (a product) eliminates a need to for each case to be dependent on each other's case type parameters.

I will also add that many of the cases you are mentioning suggest that you are trying to do type unification in TypeScript.

This is where I will be frowning. I don't have enough theoretical background to reason about whether what you just said is right or wrong. What is a type unification? Is there a link that lays it out in plain English? Similarly what is "direction sensitive" inference? Is it good or bad?
I have a couple of very practical situations at hands that I wish required less typing (were inferred by the language). I hope you are not going to say it is not possible to do due to fundamental limitations that TypeScript design team has decided to embrace.

This is a pretty concise summary of unification with an example:
https://cs.brown.edu/courses/cs173/2002/Lectures/2002-11-13.pdf
More to the point: Let's take case 1 that you've given (case 2 is similar). I'm going to copy it here for ease of looking:
function fail<r>(message: string) : r { throw new Error(message); }
function id<a>(value: a) : a { return value; }
function withFew<a, r>(values: a[], haveFew: (values: a[]) => r, haveNone: (reason: string) => r) : r {
    return values.length > 0 ? haveFew(values) : haveNone('Array is empty.');
}
var values = Math.random() > 0.5 ? ['a', 'b', 'c'] : [];
var few = withFew(values, id, fail); // <-- actual result is {}, expected is string[]

My claim is that there is no useful inference that can be made from the fail function in the call to withFew. You want string[] to be inferred, but fail says nothing about string[]. The only way to infer string[] is by inferring it from id, which indeed we do. This is because id says that it returns the same type it is given.
If I understand correctly, you are suggesting that withFew would provide a context that makes the r in fail correspond to string[]. Then the instantiated signature for fail would be (message: string): string[], and then we could infer string[] back to the r in withFew. But that becomes rather meaningless because fail could not tell withFew anything that the latter didn't already know.
The real problem here is that an inference with no candidates yields {}, which spoils the inference for the call to withFew. If just the id function were used for inference, we'd be in good shape. But fail is providing an extra candidate {} which comes to ruin the party.
And making fail generic does not actually do anything. It is just as if you had written function fail(message: string): {}.

guys, i am dying to see this on your upcoming design meeting agenda, please please please

We generally don't bring Needs Proposal issues to the meeting. If you can figure out a way to solve this problem, we can take a closer look. Otherwise extant problems around more common patterns take higher priority in terms of us figuring out how to fix things.


Tensorflow 2.2 support

Is it possible to use LMS with Tensorflow 2.2 or is there a plan for this in the future?

How about tensorflow 2.1? On what version is it available?
When I run this code:
import tensorflow as tf
tf.config.experimental.set_lms_enabled(True)

I get the error-
AttributeError: module 'tensorflow._api.v2.config.experimental' has no attribute 'set_lms_enabled'

Help

LMS is available for TF2.1 in two ways:

patch the TF2.1 code base with the patch in this repo and rebuild  (https://github.com/IBM/tensorflow-large-model-support/#building-tensorflow-from-source-with-tensorflow-large-model-support)
use the WML CE version of TF2.1 located in this conda channel:
https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda/#/

https://github.com/IBM/tensorflow-large-model-support/#installing-tensorflow-large-model-support

Hi again
TF 2.2 with integrated LMS is available now in this channel:
https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda-early-access/
Please give it a try and let us know how it goes!

Is the LMS enabled by default in this TF 2.2 version?

LMS should be available in the TensorFlow 2.1 and 2.2 versions in that channel. The enablement using tf.config.experimental.set_lms_enabled(True) should work.
It is possible that one or more TensorFlow packages have been installed into your environment from a different channel. Can you post the output of conda list | grep tensorflow ?

Output is below
tensorflow                2.2.0           gpu_py37_970.g1bb2968    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda-early-access
tensorflow-base           2.2.0           gpu_py37h8a81be8_0    defaults
tensorflow-estimator      2.2.0           py37_5bd33a6_1597.g1bb2968    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda-early-access
tensorflow-gpu            2.2.0              970.g1bb2968    https://public.dhe.ibm.com/ibmdl/export/pub/software/server/ibm-ai/conda-early-access

yeah - you have tensorflow-base from defaults. That's not a workable mix.
Try
conda install tensorflow-base=2.2.0=gpu_py37_2b96f36_162011.g4c42fc8
Hopefully that will get the right one on there.

Thank you, needed to add --strict-channel-priority to conda command but got it working in the end.


All observed points added to result dict

Hello,
I feel all observed points should be added to the results dict, not only the ones observed after the Bayesian fit. The random points in the initialization and the points explored by the user are equally valid, right? It would be sad if the maximum is one of them and it's therefore missed :)
I thought the best way to ensure all observed points are added to the results dict is to just do that in BayesianOptimization._observe_point().
Cheers,
Jonas

I'm working on this and a number of other fixes and improvements, so I'll close this PR since a good amount of refactor is taking place.

Ok thank you very much for the info! Cheers


Upload converted files to DANDI

This PR is intended to address #79 and provide users with the ability to upload their datasets to DANDI.
Currently, there are a few issues to solve before this can be merged:

Uploading the converted file fails because "1 out of 1 files were found not containing all necessary metadata: /Users/garrettflynn/Desktop/GUIDE/conversions/converted.nwb"
Boolean values are not yet rendered with the JSONSchemaForm

As discussed, using latest NeuroConv main plus that one extra conditions for validating age +/- date_of_birth for subjects should be the only piece missing

@garrettmflynn Ready for review?

Yes!

It works, and fine as-is for now
In modular (non-chained) PRs, can you make the following changes?
a) I can't change the 'staging' flag (boolean)
b) I can't change cleanup flag - also might want to adjust it at the NeuroConv level to specify cleanup of the DANDI folder only, but leave the original NWB files untouched...
c) You can skip the Version argument, I need to review if we even need it in the function itself (all uploads go to 'draft' even if there's a published version available, and all it downloads is the metadata.yml file anyway...)
d) We don't need to ask the user to specify the Dandiset Folder Path  - it's fine to set it to be the parent of the NWB data folder


Connection level transformer settings

Hi,
I am working on a project that needs several ioredis connections. I encountered a problem very recently because I added a replyTransformer, working on zrangebyscore, which was fine for one connection by inappropriate for another.  Unless I am mistaken ioredis does not support transformers at the connection level.  My solution right now is add the transformer and then clear the require cache before using ioredis for the next connection, but I have been advised that is not a good solution. I think this would be a useful addition to the capabilities of ioredis.
Thanks,
Best regards,
Matt

Global level transformations will be deprecated in the 3.0 version and hooks will be introduced. Currently connection-level transformers are not supported. Two workarounds may be used before 3.0:

Your approach, clear the require cache to force node.js requires a isolate ioredis instance for each connection.
Simply override the command like:

const Redis = require('ioredis');
const redis = new Redis();
const zrangebyscore = redis.zrangebyscore.bind(redis);
redis.zrangebyscore = function (args, /* other arguments...*/) {
  return zrangebyscore(args,  /* other arguments...*/).then((reply) => {
    // transform reply here
    return reply;
  });
};

See https://github.com/luin/ioredis/issues/347 for details.

Thanks @luin , really appreciate your quick response,

We also have a use case for this functionality.
Can one of this issue or #347 be reopened considering the feature is not implemented.


Transition to PyMC3

Hi,
Are there any plans to transition to pymc3?
I'v noticed that pymc is somewhat old and doesn't have a lot of development going for it, yet pymc3 provides new features and serious performance boost. How difficult would it be to transition from pymc to pymc3?
Saul

Shouldn't be hard! I've been planning on it. I haven't had much time to work on it lately, but feel free to contribute a branch!

Sounds good, Ill give it a shot this weekend.
Btw, this is a really cool library, thanks for creating it.

Glad you like it!

Hi,
I took a look at the code, and it seems that moving to pymc3 might require a little more work than I initially thought. The main reasons are that pymc3 doesn't have the stochastic decorator and that causality tests don't cover the statements that interface with pymc. Ill try to write some tests for it later this weekend, so we can do the transition without worries. Let me know if you have any pointers to writing good tests for that. Here is a test coverage report for the file that interfaces with pymc independence_tests.py
For now, I submitted a pull request updating the versions for all the other packages used.

Sounds great! I seem to remember running into that issue before when I was
playing around with pymc3 and thinking of upgrading.  It'd be great if you
sorted it out!
Your changes look good so far. There was one that needs to be reverted (for
efficiency).
Thanks for contributing!!!
Best,
A
On Fri, Oct 13, 2017 at 10:22 PM, Saul Fuhrmann<EMAIL_ADDRESS>wrote:

Hi,
I took a look at the code, and it seems that moving to pymc3 might
require a little more work than I initially thought. The main reasons are
that pymc3 doesn't have the stochastic decorator and that causality tests
don't cover the statements that interface with pymc. Ill try to write
some tests for it later this weekend, so we can do the transition without
worries. Let me know if you have any pointers to writing good tests for
that. Here is a test coverage report for the file that interfaces with
pymc independence_tests.py
https://s3-us-west-2.amazonaws.com/test-coverage-saulf/causality_inference_independence_tests___init___py.html
For now, I submitted a pull request updating the versions for all the
other packages used.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/akelleh/causality/issues/41#issuecomment-336603266,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABrkQIKyGJm_WZa4E2DbKiBS6rysTMJQks5ssBrMgaJpZM4P16ql
.

--
Adam Kelleher | BuzzFeed | Principal Data Scientist |<PHONE_NUMBER> | tw:
@akelleh | github: akelleh
111 East 18th St., NY, NY 10003
#1 Most Innovative Company In The World – Fast Company
http://www.fastcompany.com/3056057/most-innovative-companies/buzzfeed-for-shaking-up-media-across-the-globe

Updating: pymc3 is incompatible with the statsmodels kernel regression, so I'm removing the mixed independence tests, which are the only portion of the package that uses pymc 2. That'll let me get rid of that dependency, and we can upgrade to pymc3 for future features. I'll reimplement mixed variable type independence tests if/when there's a compatible kernel density estimator, or pymc removes the theano dependence (I think that's planned for pymc4)


Clear all filters in form which contains a range

Hi,
I'm wondering if you can help please?
I've got some filters set up, and one of them is a range slider, based on the example here: https://demos.kunkalabs.com/mixitup/filtering-by-range/
The filters are working great, and the range is working well too. However, I'm trying to add a 'Clear Filters' button and getting some unexpected behaviour. The first click on the button clears the form, and other 'conventional' filters just fine, but the custom range values persist. Then when the button is clicked a second time, the range values are cleared out.
I've looked through the documentation and cannot find where the hooks are documented. My current line of thought is that the custom filter that is being registered doesn't actually get cleared when the form is reset.
Any ideas at all?

I'm having the same issue.
The reset event does not trigger a change event on input range, that could start a new operation that runs the testResultEvaluateHideShow that could take the new range value into account.
Here is a quick and ugly workaround : https://codepen.io/ZalemCitizen/pen/NWzRKgK
for whatever reason (the real one, in fact) a simple change triggered on one of the range inputs is not a sufficient workaround
you have to reset each input range yourself like
inputRange.value = inputRange.defaultValue
then trigger a new mixItUp operation (i.e a single input range change)
If you're using mixItUp MultiFilter, the reset may trigger a new mixItUp operation too early and since change event handler on range input is running
mixer.filter(mixer.getState().activeFilter)
the current mixer state still contains values of other fields before reset, so it restores these former values
I suggest you

remove change event dispatch
change your button type from reset to button
on click event handler on this button, you reset the input ranges to their default values
run form reset to reset all other filters : mixItUp reset event handler on form will then refilter


[AutoPR mysql/resource-manager] MySql: included package tag for java, added java readme

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6435

This PR has been merged into https://github.com/Azure/azure-sdk-for-java/pull/3726


You can't set the 'sslEnabled' setting unless you also set a non-default 'host'

As stated in https://github.com/GitLiveApp/firebase-java-sdk#limitations, Offline Persistence and SSL is not supported for Firestore.
Disabled SSL means we cannot use the default host firestore.googleapis.com, is there any alternative host we can use?
Could not find anything on the internet

What error are you getting? It is used by others with standard Firebase

@nbransby forgot to mention that this only occurs on desktop, so android works fine.
The error message is the exact title after disabling ssl, however if I use default settings the desktop app crashes because it could not find an Application class or something like that, as this is android only.
Should be easy to create a simple reproducer, if you need more information hmu, but I'm on vacation right now so it could take a while

I think you might be missing this https://github.com/GitLiveApp/firebase-java-sdk/blob/master/README.md#initializing-the-sdk

That actually works, used Context before and didn't know you exposed Application as well.
Can be quite confusing in multiplatform projects as they have the exact same package name.


Implement is_sign_* and signum methods in terms of libm.

Rationale
rust-gpu project uses num-traits directly and via glam. However, integer_decode() function is a bit poisonous for it - it immediately requires both Int16 and Int64 traits.
This PR reimplements corresponding functions in terms of libm's copysign. (For some reason, rust's libm is missing signbit - it can be done with a bitcast though, maybe that's actually a better implementation avenue).

However, integer_decode() function is a bit poisonous for it - it immediately requires both Int16 and Int64 traits.

Can you elaborate? I don't understand what's poisonous, or what those traits are.

However, integer_decode() function is a bit poisonous for it - it immediately requires both Int16 and Int64 traits.

Can you elaborate? I don't understand what's poisonous, or what those traits are.

Simply put, those traits (capabilities actually - I mistyped) are what is required of target hardware to successfully translate spir-v to machine code. Nonstandard integer sizes present a problem, especially on older hardware.

If there are worries of performance, I can re-do it as a separate feature flag, depending on libm. Would that be necessary or more agreeable?

I wasn't really thinking about performance yet, but I guess it is a little unfortunate that the libm call won't usually be inlined, unless you enable LTO.
Maybe we should just write the no-std version of is_sign_negative directly, with only that small subset of integer_decode_f32/f64 that deals with the sign bit. Then signum should still be fine with the default impl.

Fair enough!

Thanks!
@bors r+

bah, wrong bot...
bors r+


Provide Logging Guideline

Provide logging guideline.  Should including at least the following:

Why we use the standard logger and not stdout.  It's crazy we have to explain this, but better to spell it out.
How to do application level logging.  This is harder than it looks.
Attaching handlers, creating additional loggers, patterns and anti-patterns.
Provide an example

Finally, update the template providing a basic logging example.

@germa89, this still needs to be resolved by generalizing our recomendations. Pinging @dnwillia-ansys for visibility.

I'm happy to include any suggestions @dnwillia-ansys might have. Anyway we should probably have another look at it in the comming weeks.


Change h2 queries to use array type in integration tests

H2 2.x supports array type now. We should move the old way of creating multiple $column__MV$i columns convention.

Here is the PR for the change. thanks

I think we can close this issue. thanks


Cannot create/quit window multiple times on Linux!

Hi,
I got multiple issue reports on the Glimmer DSL for LibUI project about not being able to create/quit a main window multiple times on Linux (getting a segfault):

https://github.com/AndyObtiva/glimmer-dsl-libui/issues/45
https://github.com/AndyObtiva/glimmer-dsl-libui/issues/48

I confirmed that this works correctly on the Mac though. I am able to create a window, start the main event loop. quit the LibUI event loop, create another window, restart the main event loop, and finally quit again.
So, this seems like a Linux issue only. It is problametic because it prevents users from being able to launch/close/relaunch windows in the same Ruby application. To get around it, they could script multiple Ruby applications I suppose, but it would be great if libui-ng behaved consistently in Linux and Mac with regards to being able to launch a window multiple times.
If you need further information about the issue, please let me know.
Thank you in any case for continuing to maintain libui-ng. It's a very convenient cross-platform GUI library.

create a window, start the main event loop. quit the LibUI event loop, create another window, restart the main event loop, and finally quit again.

This appears to be a Ruby FFI bug on Linux..
I cannot reproduce with C equivalent, try this simple modification to hello-world example:
diff --git a/examples/hello-world/main.c b/examples/hello-world/main.c
index 85658042..4471ba85 100644
--- a/examples/hello-world/main.c
+++ b/examples/hello-world/main.c
@@ -30,6 +30,17 @@ int main(void)

        uiControlShow(uiControl(w));
        uiMain();
+
+       // Create a new window
+       w = uiNewWindow("Hello World!", 300, 30, 0);
+       uiWindowOnClosing(w, onClosing, NULL);
+
+       l = uiNewLabel("Hello, World!");
+       uiWindowSetChild(w, uiControl(l));
+
+       uiControlShow(uiControl(w));
+       uiMain();
+
        uiUninit();
        return 0;
 }

Thank you all. I will take a look at this issue.


go mod vendor should add go generate dependencies

What version of Go are you using (go version)?

$ go version
go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/aj/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/aj/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/aj/github.com/xxx/xxx/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0g/01vpdjf507z8qk3lvgfnh1hw0000gn/T/go-build639981897=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I have a module which is not a code dependency, but rather a go generate dependency:
//go:generate go run github.com/UnnoTed/fileb0x b0x.toml

I'm trying to add it to my vendor directory and have it stay there.

What did you expect to see?
I'd expect to be able to run go mod vendor and have the generate dependencies copied over as well.
What did you see instead?
Even though I've manually added the go generate dependency into go.mod it's not it's not being copied to vendor when I run go mod vendor. In fact, it's sometimes pruned from vendor when I run that.

See https://github.com/golang/go/issues/25922 and https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module. go mod generally removes (prunes) unused dependencies, so right now you need to keem them as imports somewhere.

@mvdan Thanks for the quick reply. It's a binary, not a library, so it's not possible even to use _ to import and ignore. Any other ideas?


Add support for ISO 8601 format dates/datetimes

See Filtering on Date Fields With DjangoFilterBackend Doesn't Quite Work. · Issue #1338 · tomchristie/django-rest-framework over on DRF.
It looks like there's no fix coming in Django soon so we should add something here.
:loudspeaker: @copitux — sorry for the interruption — Would we be able to incorporate your code from Iso 8601 DateTimeFilter to Django Rest Framework and Django-Filter? (It doesn't provide licence info.)

+1, this coming in anytime soon?

Actually I found out that using either Arrow or Delorean for parsing the dates is way better then adding support for a specific format.
I'd be willing to provide form fields that parses dates with those libraries.
The form fields won't introduce hard dependencies but will allow the client to filter with any format that Arrow or Delorean are familiar with.

Hi @thedrow.
This sounds great. What would it look like from the declaration point of view, and would it cover all the cases?
I'm happy to recommend a dependency if the benefit is there...

I have no idea actually. Maybe we should consider introducing a datetime_parser keyword argument that will determine the form field's datetime parser.

+1, it will be really good feature, especially when using django_filter with djangorestframework

We're using Delorean and this currently works for us:
class DeloreanDateTimeField(forms.DateTimeField):
    def strptime(self, value, format):
        return delorean.parse(value, dayfirst=False).datetime

class DeloreanDateTimeFilter(DateTimeFilter):
    field_class = DeloreanDateTimeField

We could instead override the default Django Date/Time form field to accept a parser callable and call it in strptime(). This will also require us to add a new keyword argument to all Date/Time related filters.

Hey @thedrow — at this point I'm inclined to finish and merge #264 rather than add a dependency.


Support for async Methods in ISubscriber.Subscribe

Is it possible to implement an async Method as a parameter for the Subscribe Method in ISubscriber.

This is definitely doable, I will create a PR soon.

Thanks!

Nice thanks, when do you plan to add it?

Added support for async subscription

Subscribe works fine for me but SubscribeAsync does never trigger. Any ideas? My code is exactly the same as the one posted in the image save for the method name.


Don't send null id attribute when creating a new resource

Addresses #36 - We should not be providing the id property when creating a resource with a server-generated ID. We currently set id to null in our POST request, which goes against the JSON:API specification.

👍


Release 1.1.1 is missing from Docker Hub

Just tried to update one of our projects to the latest release and got an error, checked Docker Hub and saw that 1.1.1 isn't listed (https://hub.docker.com/r/checkr/flagr/tags), last release was 1.1.0. Any chance of getting 1.1.1 tagged and pushed?

Thanks for the reminder, released 1.1.1 and the demo website now. https://hub.docker.com/r/checkr/flagr/tags


fix bug in silhouete calculation

Correct bug from #210

This is not an issue for other silhouette metrics? I guess it's very unlikely that this happens either way... so might be fine to ignore other cases for now.

The code worked for me after this fix. But this could happen whenever n_classes==n_instances in sklearn silhouette (if it is used somewhere else as well - I did not check).

It's used in a couple more scores... but if someone has issues with that, we can move this check into another more central silhouette function :).


HBASE-27729. Missed one parameter when logging exception in StoreFileListFile.

JIRA: https://issues.apache.org/jira/browse/HBASE-27729.

@slfan1989 Can you help review this pr?

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
compile
2m 28s
master passed

+1 :green_heart:
checkstyle
0m 33s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 25s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 27s
root in the patch failed.

-1 :x:
compile
0m 24s
hbase-server in the patch failed.

-0 :warning:
javac
0m 24s
hbase-server in the patch failed.

-0 :warning:
checkstyle
0m 29s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 44s
The patch causes 16 errors with Hadoop v3.2.4.

-1 :x:
hadoopcheck
3m 34s
The patch causes 16 errors with Hadoop v3.3.4.

-1 :x:
spotless
0m 32s
patch has 23 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
0m 20s
hbase-server in the patch failed.

@Apache9 @virajjasani Thank you very much for helping to review the code!


[Python] add start_iteration to python predict interface (#3058)

Suggested by Issue #3058. Add start_iteration for python prediction.

@shiyu1994 Also, please add some tests that checks new param is working.
Letting know @imatiach-msft about changes in SWIG API.

ping @shiyu1994 for R's test fails:
══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 558 | SKIPPED: 2 | WARNINGS: 0 | FAILED: 7 ]

Failure: start_iteration works correctly (@test_Predictor.R#49)
Failure: start_iteration works correctly (@test_Predictor.R#50)
Failure: train and predict binary classification (@test_basic.R#32)
Error: lgb.intereprete works as expected for binary classification (@test_lgb.interprete.R#38)
Error: lgb.intereprete works as expected for multiclass classification (@test_lgb.interprete.R#89)
Error: lgb.plot.interepretation works as expected for binary classification (@test_lgb.plot.interpretation.R#38)
Error: lgb.plot.interepretation works as expected for multiclass classification (@test_lgb.plot.interpretation.R#87)

@shiyu1994 it seems there are some lint/doc problems.

@jameslamb @StrikerRUS  Could you tell me how to update the R documentation in R-package/man folder? It seems that the tests failed due to code/doc mismatch. I try to use roxygen2 and run roxygenise under R-package folder but the following error occurs. Thanks.

@shiyu1994
can you try to bulid R package first, then run roxygen2?
https://github.com/microsoft/LightGBM/tree/master/R-package#install

It seems that roxygenise(load = 'installed') works.

I think .Rdata should be removed.

also
The downloaded source packages are in
	‘/tmp/Rtmp3IyK3E/downloaded_packages’
Writing NAMESPACE
Writing NAMESPACE
Writing predict.lgb.Booster.Rd
Some R documentation files have changed. Please re-generate them and commit those changes.

    Rscript build_r.R
    Rscript -e "roxygen2::roxygenize('R-package/', load = 'installed')"

Thank you so much @shiyu1994
@jameslamb @StrikerRUS I am going to merge this. If there are any problems, we can create another PR to fix it.


[DOC] Incorrect description of default value for indices.breaker.total.use_real_memory

What do you want to do?

[x] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The documentation states that the default value of indices.breaker.total.use_real_memory is false, but in the source code it is set to true.
https://github.com/opensearch-project/documentation-website/blob/main/_install-and-configure/configuring-opensearch/circuit-breaker.md?plain=1#L18
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/indices/breaker/HierarchyCircuitBreakerService.java#L91

Thanks, @hogesako - do you want to take a stab at creating a PR for the fix?

@hogesako Nicely done! I'll send this through doc review. Thanks!


[BugFix] Fix collect unknow statistics let row count error

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/starrocks/pull/19733 lose code
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[x] 2.4
[ ] 2.3

@mergify backport branch-2.4


feat: Add json function to CustomStreamMap

This allows using json.loads() and json.dumps() to convert fields between text and json representations.
Particularily useful moving data between MySQL and Postgres where MySQL stores json as text, and Postgres stores json as JSONB.
Usage in a stream_map:
        stream_maps:
          sample-reports:
            recipients_email_addresses: json.loads(recipients_email_addresses)

Closes https://github.com/meltano/sdk/issues/1502

📚 Documentation preview 📚: https://meltano-sdk--2531.org.readthedocs.build/en/2531/

Ah, you want me to add docs to https://meltano-sdk--2531.org.readthedocs.build/en/2531/stream_maps.html#built-in-functions ?

Ah, you want me to add docs to https://meltano-sdk--2531.org.readthedocs.build/en/2531/stream_maps.html#built-in-functions ?

yeah 🙏

Thanks for those documentation improvements @edgarrmondragon :pray:

Thanks @grigi!


Fixed infinite path appending when cross seeding multiple torrents

Description
Please include a summary of the change and which issue is fixed.
Fixes #490
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated the docstring for new or existing methods
[x] I have modified this PR to merge to the develop branch

I'm not around to test but overall fix seems fine? I assume you've tested the solution

Yeah I tested it, it's definitely fixed


Return value is not mentionned in the documentation

The actual signature in VS Code is:
trigger OnLookup(var Text: Text)  : Boolean
begin
...
end;
Although I never use the return value of the OnLookup in a Page, it's not mentionned throughout the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d7300c7-ba26-3283-32bd-51e2257c4b08
Version Independent ID: 7066ccbc-994d-f3e4-9359-14a84091ef36
Content: OnLookup (Page fields) Trigger - Business Central
Content Source: dev-itpro/developer/triggers/devenv-onlookup-page-fields-trigger.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hello, thanks for catching this. The topic will be updated with the next refresh of the docs.


How to use it in VUE or React

There is no guidance in the documentation.

In what context?

I introduced heat.js in vue to throw such an error.

Can you post an example of the Vue component please?
Thanks


Dockerise the boilerplate

Dockerise the express server component with separate containers for app and DB (and cache server and log server and ...)  along with supervisor for launching the app/containers.
Basically, a clear picture of how to deploy the application which is using this boilerplate.  Can goto next level of how to configure the setup with kubernetes.

Thank you for the suggestion @code-reflex
I'm starting to work on this.
I'm not a pro in container related stuff, appreciate any help/info here.

Here's the commit for docker deployment. Appreciate your comments on

Which container registry would you recommend me to push the docker image to?
Is there any further optimization you'd recommend.


Testbed module

See #33.

Pull Request Test Coverage Report for Build 165

32 of 34 (94.12%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.0%) to 81.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

synorchestrator/testbed.py
31
33
93.94%

Totals

Change from base Build 162:
2.0%

Covered Lines:
324

Relevant Lines:
400

💛  - Coveralls


Update pt-BR.coffee

Coverage remained the same at 63.494% when pulling ef8e38989342a2437a2ad1fd67852e320c1d4295 on traducaoenlix:patch-29 into c2121f437d2a6893951c062079ebc8a86721aba8 on codecombat:master.


Unable to open the ImageNet pretrained weight fo the STDC backbone

Hello there! Thank you very much for open-sourcing your code. It was really a nice paper to read, combining some of the best ideas. I wanted to tryout the model on a custom dateset and I downloaded the ImageNet pre-trained weights just for the STDC Backbone. The .tar files from the the google drive could not be extracted using CLI as well as the Archive Manager. Any help on this would be really great.
The files that I tried to extract are STDCNet1446_76.47.tar and STDCNet813M_73.91.tar from here

STDCNet1446_76.47.tar

STDCNet1446_76.47.tar and STDCNet813M_73.91.tar do not need to extract, you can use them directly~

@MichaelFan01 Oh ok. So I can just use them like .pth files. I understand the extensions don't matter in Linux but I just got carried away with the .tar extension
So I guess I can use something like:
model.load_state_dict(torch.load(PATH))
Thanks for your clarification


Rewarded video is not showing.

Hi,
I am trying to implement this plugin with my telerik platform hybrid app. I am trying to show reward video. Below is the code that I am using which is provided in your doc.
var admobid = {};

// TODO: replace the following ad units with your own
if( /(android)/i.test(navigator.userAgent) ) {
  admobid = { // for Android
    banner: 'ca-app-pub-3940256099942544/6300978111',
    interstitial: 'ca-app-pub-3940256099942544/1033173712',
    rewardvideo: 'ca-app-pub-3940256099942544/5224354917',
  };
} else if(/(ipod|iphone|ipad)/i.test(navigator.userAgent)) {
  admobid = { // for iOS
    banner: 'ca-app-pub-3940256099942544/4480807092',
    interstitial: 'ca-app-pub-3940256099942544/4411468910',
    rewardvideo: 'ca-app-pub-3940256099942544/1712485313',
  };
} else {
  admobid = { // for Windows Phone
    banner: 'ca-app-pub-6869992474017983/8878394753',
    interstitial: 'ca-app-pub-6869992474017983/1355127956',
    rewardvideo: '',
  };
}

function initApp() {
  if (! AdMob ) { alert( 'admob plugin not ready' ); return; }

  // this will create a banner on startup
  /*AdMob.createBanner( {
    adId: admobid.banner,
    position: AdMob.AD_POSITION.BOTTOM_CENTER,
    isTesting: true, // TODO: remove this line when release
    overlap: false,
    offsetTopBar: false,
    bgColor: 'black'
  } );

  // this will load a full screen ad on startup
  AdMob.prepareInterstitial({
    adId: admobid.interstitial,
    isTesting: true, // TODO: remove this line when release
    autoShow: true
  });*/

  AdMob.prepareRewardVideoAd({
                  adId: admobid.reward,
                  autoShow: true,
                  isTesting: true
            		},
                function(msg) {
                    alert("prepare video : "+JSON.stringify(msg));
                },
                function(msg) {alert("prepareReward failed: " + msg)});
  AdMob.showRewardVideoAd();
}

I am calling the initApp method in button click. I can see the alert box of successful prepare but no ads are showing.
Can anybody please help me out with this ?
Thanks!
Saikat

It will take a few seconds for the plugin to load ad resources from server, so do not call showRewardVideoAd() immediately. Instead, call it later.
var videoReady = false;
function prepare() {
    videoReady = false;
    AdMob.prepareRewardVideoAd({
        adId: admobid.reward,
        autoShow: false,
        isTesting: true
    });
}
function show() {
    if(videoReady) {
         AdMob.showRewardVideoAd();
    }
}
document.addEventListener('onAdLoaded', function(data){
    if(data.adType == 'rewardvideo') videoReady = true;
});
document.addEventListener('onAdFailLoad', function(data){
    if(data.adType == 'rewardvideo') {
         videoReady = false;
         prepare(); // prepare again for next ad
    }
});
document.addEventListener('onAdDismiss', function(data){
    if(data.adType == 'rewardvideo') prepare(); // prepare again for next ad
});

// call prepare() when your app init
// call show() when game level end or other place

Hello,
Thank you very much for your support. I have tried to do what you suggested. I actually calling prepare method from another button click. But it is always failing back to onAdFailLoad event. I have printed the response. It is as follows.
{ "isTrusted" : false}, "adNetwork" : "AdMob", "adType" : "rewardedvideo", "adEvent" : "onAdFailLoad", "error" : 3 , "reason" : "No fill"
I am not sure why this is happening. Can you please help me out on this ?

No fill, means that admob did not find suitable ad resource for your ad request.
Usually, banner/interstitial ad have very high fill rate (>95%), but I am not quite sure about the fill rate of video ad.
Maybe you can try using admob with mediation to Vungle or other video ad provider, to increase the fill rate.

Thank you for your answer. I will try and let you know . One more thing , is there any adapter required in cordova for admob-Vungle ?

why I am getting Internal Error. below is the response for reward video fail
adEvent:"onAdFailLoad"
adNetwork:"AdMob"
adType:"rewardvideo"
bubbles:false
cancelBubble:false
cancelable:false
composed:false
currentTarget:null
defaultPrevented:false
error:0
eventPhase:0
isTrusted:false
path:Array(2)
reason:"Internal error"
returnValue:true
srcElement:document
target:document
timeStamp
103994.015
type:"onAdFailLoad"

We guess the "internal error" might be caused by SDK version change. The plugin has just been upgraded to latest SDK, please update the plugin and re-try.

I guess this a little late but the problem may be this.
admobid = { // for Android
    banner: 'ca-app-pub-3940256099942544/6300978111',
    interstitial: 'ca-app-pub-3940256099942544/1033173712',
    **rewardvideo:** 'ca-app-pub-3940256099942544/5224354917',
  };

AdMob.prepareRewardVideoAd({
                  adId: **admobid.reward,**
                  autoShow: true,
                  isTesting: true
            		},
                function(msg) {
                    alert("prepare video : "+JSON.stringify(msg));
                },
                function(msg) {alert("prepareReward failed: " + msg)});
  AdMob.showRewardVideoAd();
}


Propagate props to svg root element

Sorry no test added. How do you want us to test this? Not even sure we should test if the syntax is valid...
Close #2

Thank you.
Regarding tests, I'll try something this week.
I just had some ideas. Maybe send the output to babel and check if the output parsed correctly and exported a class extending React.Component ?


chore(deps): update terraform terraform-ibm-modules/vpe-gateway/ibm to v4.3.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/vpe-gateway/ibm (source)
module
minor
4.2.0 -> 4.3.0

Release Notes

terraform-ibm-modules/terraform-ibm-vpe-gateway (terraform-ibm-modules/vpe-gateway/ibm)
v4.3.0
Compare Source
Features

add eu-fr2 to container registry domain mappings (#546) (6bc18d6)

v4.2.1
Compare Source
Bug Fixes

added explicit mapping for ICR us-east region (#541) (280b071)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Any Recommendation for serialization between IronPython and cPython3

Hello.
As a developer who use jsonpickle as a way to bridge between Python 2 (IronPython) and  Python 3 (cPython) code. I find that sometimes my objects are jumbled upon serialization.
My particular use case is when I serialize a custom object that I wrote in ronPython with make_refs=True, keys=True .
If I deserialize this object in Python 3.7.6, the items that clearly had an "py/id" were all mixed up.
I wonder if the developers have tested a scenario where serialization between IronPython 2 and cPython 3, And if there are somethings that need to be aware of.

This problem do not happen if I deserialize the said object in IronPython

Oh yeah, there is an edge case across the 2 vs. 3 barrier around how dictionary keys are sorted.  It started in py3.6 to be precise.
Anyways, long story short is that, yeah, the IDs will be in a different order due to the difference in object traversal.  The traversal / encoding strategy is something that could be improved.  In the library you'll see parts where we conditionally sort based on the older python version.
The newer versions do not sort when iterating over dicts, because dict key order is now preserved in python, and that is basically the hard part.
One thing that would work would be to tweak it to unconditionally sort.  The downside is that py3 loses its dict-preserving property, but it's all a trade-off.
There was a previous issue reported where the user wanted to preserve the dict order, and that's what led to the current behavior.  I wouldn't be opposed a patch that adds another boolean flag to opt-in to unconditionally sorting.
The function where we sort is util.items(...) and you'll see a few key places in pickler.py and unpickler.py where util.items(...) is used.
A quick hack for testing is to unconditionally set PY3_ORDERED_DICT = False in the compat.py and see if that gets it working.

Thank you so much for your help.
So if I understand it correctly, since I serialize in py2, the object dict is sorted on serialize and then written to disk. When I unpickle it in py2 again, since PY3_ORDERED_DICT = False, the deserialization works as expected. However, if I unpickle it in py3, PY3_ORDERED_DICT = True, the result is scrambled.
For the quick hack test you suggested is it okay if I force jsonpickle.util.PY3_ORDERED_DICT = False after import jsonpickle? Or do I have to change compat.py in the installed source.

I have trouble reproducing the error in my code, probably because my dependency library updated some code and now its not triggering the problem. I'll investigate further and get back.

For the quick hack it unfortunately requires changing compat.py in the source because other modules import that symbol directly.  There are also some early decisions about whether to initialize the backend with sort_keys=True that necessitate changing it at that level.

@davvid Thanks. I'm still trying to reproduce my error with no luck. But if I do, I'll try your hack and report back. I'll close this issue for now and reopen if I can find something.


chore: selectively resolve typescript eslint package

Updating @netlify/eslint-config-node to v7 causes a dependency resolution conflict with Gatsby's version of @typescript-eslint/eslint-plugin, which in turn causes linting errors.
This PR fixes that by adding selective version resolution in the package.json. We can remove this when Gatsby updates @typescript-eslint/eslint-plugin to v5.

Was never merged and Gatsby already updated @typescript-eslint/eslint-plugin to v5


Custom Camera Views. URGENT!!!

Is it possible to put different multiview poses, custom-made, and then use the 3D construction of this repo? I think I should set the new custom poses for the 3D reconstruction task, if so... how do I do that?

Yes. It is feasible, but it requires training a new model using new poses.

Yes. It is feasible, but it requires training a new model using new poses.

@xxlong0
Thanks for your reply... What I meant is I am using another diffusion model for the multi-view generation, but this model doesn't generate the same poses as Wonder3D's multi-views. My question is how to use your 3D reconstruction on my poses?
I saw you had a fixed poses folder (instant-nsr-pl/datasets/fixed_poses) if I adjusted the numbers in each file according to my views would that be the way? if yes, how do I get these parameters?


Contribution

Hi @brancobruyneel I hope you're doing well.
I'm junior web developer (JS/TS/React) and I'm currently learning Rust too. I want to contribute to your project to learn more Rust, Yew and help with features and issues...

Hi! Great, you are at the early stages of the project ;) I'll try to add more issues related to Yew, so that you can pick one that interests you.

OK cool.

@brancobruyneel have an idea of how I can run on my local machines the project ?
cargo install but got error like this :
error: found a virtual manifest at C:\Users\Tawaliou.A\Documents\Rust\OSS\crabtyper\Cargo.toml instead of a package manifest


Adding external calling function parameter type hints

Description

Python doesn't provide access modifier, so i added type hints based on the methods called by the ~test.py files run in the tox script. However, the type hints provided by Python do not perform static type checking, so they cannot detect runtime errors in advance. Therefore, I think we can consider introducing static type checking in the next step with a tool like Mypy.
As soon as i'm done with this PR, i'll be doing some research on Mypy.
Related: #170
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Refactoring, Maintenance
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@MoonJeWoong 님, 하기 사항 확인 부탁드립니다.
=================================== FAILURES ===================================
_________________________________ FLAKE8-check _________________________________
/home/runner/work/fosslight_util/fosslight_util/src/fosslight_util/set_log.py:47:131: E501 line too long (157 > 130 characters)


[W5][W15-3]Wee Soo Jun

Make FindCommand case insensitive
@Happytreat

Can you please write clearer comments

write clearer comments

Well done!

Useful changing. Make case insensitive is alwasy needed. Good job.


Replace FwLinks with the actual target links - csharp folder

Sub-issue for folder https://github.com/dotnet/docs/tree/master/docs/csharp
/cc @xaviex

Can I volunteer to fix this?


chapter2: RuntimeError Expected object of type torch.FloatTensor but found type torch.LongTensor for argument #2 'target'

target = Variable(t.arange(0, 10))
criterion = nn.MSELoss()
loss = criterion(output, target)
loss

ubuntu 16.04, python 3.6.3, pytorch 0.4.1, RuntimeError occurs that
RuntimeError: Expected object of type torch.FloatTensor but found type torch.LongTensor for argument #2 'target'
The error is at target = Variable(t.arange(0, 10)), which return a Tensor with target.type() == 'torch.LongTensor', while mismatched with output.type() == 'torch.FloatTensor'.
Therefore, I modify it to
target = Variable(t.arange(0, 10).float())
But another error about shape mismatched occurs
RuntimeError: input and target shapes do not match: input [1 x 10], target [10] at /pytorch/aten/src/THNN/generic/MSECriterion.c:12
so add .view(),
target = Variable(t.arange(0, 10).float()).view(1, -1)
Done.
Hope the author can modify the error. Thx~

Thanks for your answer!!!


Remove the iter8 k subcommand

Remove the iter8 k subcommand and replace them with the appropriate iter8 subcommands. iter8 k persistent flags will be absorbed as part of iter8 persistent flags.

part of https://github.com/iter8-tools/iter8/issues/1448

We should explore removing the iter8 k subcommand (ie, iter8 k run becomes just iter8 run).

When we eliminate the implementation of the command, make sure we eliminate any code that this used exclusively by them. For example, several functions in the kubedriver.


Frontend: Volume slider

My suggestion (user story): Volume bar is on toolbar, can be dragged to decrease/increase volume of project. If a waveform is selected on the timeline, the volume bar controls the overall volume of that specific audio.

I like the idea of having a toolbar, we can also move the metronome here as well. For other tools I was thinking we could add bass, speed and options to delete/add sounds.


baetyl-1246: Add tx in shadow

Codecov Report

Merging #362 (ab97196) into master (8fc3c6b) will decrease coverage by 0.06%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   65.25%   65.18%   -0.07%
==========================================
  Files          94       94
  Lines        6435     6451      +16
==========================================
+ Hits         4199     4205       +6
- Misses       1641     1653      +12
+ Partials      595      593       -2

Impacted Files
Coverage Δ

plugin/database/shadow.go
67.96% <43.75%> (-4.36%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fc3c6b...ab97196. Read the comment docs.


How to use vue js with a voyager project Laravel

Laravel Version: 5.5
Voyager Version: 1.1
PHP Version: 7.1
Database Driver & Version: 5.6

Description:
I have a laravel project installed running with a voyager package. How can I use vue js and implement this technology in my voyager project? Remember that I'm using the substitutions of views.
Steps To Reproduce:

How do you expect to use VueJS? Within Voyager or external to voyager? If external, then you don't need to do anything related to Voyager, just make it happen like you would any other site

This is the question. I need to use the vuejs within the voyager project. Rewriting the views browse.blade.php and edit-add.blade.php. I need to use the vues within those views.
resources/views/vendor/voyager/slug-name

Why do you need to use it in Voyager's views?  We already use vue on a couple views (media manager comes to mind), so it's possible, but you'll have to build your custom components into Voyager's app.js, or inject a new JS file with your vue component in it.  This is a lot of work for something that doesn't provide much benefit

I found an option to insert an app.js file into the voyager configuration file. But when I put the file it returns me the following error.
Uncaught TypeError: $(...).perfectScrollbar is not a function @fletch3555 @greut @wuwx @cbtech @
file config/voyager.php
'additional_js' => [         'js/app.js',     ],

Does your js code make use of perfectScrollbar?

@thsdeveloper
there is a hooks name polls, which use the vue. you should try to hooks:install it and try to code review. maybe help to you

How I use my how Vue components? In the Voyager assets is not include axios.

@thsdeveloper I did this:

I copied the files in the voyager assets from the vendor folder to my project assets
Change the package.json to add the dependencies in the voyager assets (don't repeat the Vue dependency)
Run npm install to get the packages
Combine yours app.js with the voyager's app.js
Compile the assets npm run dev or run prod
In the master.blade.php change the app.js to your compiled (override the view)

I haved a issue with bootstrap.js and I use with the CDN.
I use Laravel 5.5 and PHP 7.2

Also the Database tool is Vue.
You can take a look at it for reference.

I have a question related to this... I have Laravel Spark + Voyager installation. Spark comes with it's own package.json dependencies and resources file structure much similar to Laravel's base installation.
It has been working fine for months. Until now that I manually checked if Voyager has new packages in package.json ... noticed I never had added these deps into my package.json. And then I ran into problems with Vue single file components not building anymore.
Anyhow, I just installed a fresh L5.5 and then Voyager into it. Now package.json is identical to what L5.5 repo has:
{
    "private": true,
    "scripts": {
        "dev": "npm run development",
        "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
        "watch": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
        "watch-poll": "npm run watch -- --watch-poll",
        "hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
        "prod": "npm run production",
        "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
    },
    "devDependencies": {
        "axios": "^0.17",
        "bootstrap-sass": "^3.3.7",
        "cross-env": "^5.1",
        "jquery": "^3.2",
        "laravel-mix": "^1.0",
        "lodash": "^4.17.4",
        "vue": "^2.5.7"
    }
}

While Voyager repo has this file:
https://github.com/the-control-group/voyager/blob/1.0/package.json
What is happening here, how is voyager's package.json not included/merged with Laravel's package.json – is it because of that "private": true ?
{
  "private": true,
  "scripts": {
    "dev": "npm run development",
    "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --watch --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch-poll": "npm run watch -- --watch-poll",
    "hot": "cross-env NODE_ENV=development node_modules/webpack-dev-server/bin/webpack-dev-server.js --inline --hot --config=node_modules/laravel-mix/setup/webpack.config.js",
    "prod": "npm run production",
    "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "devDependencies": {
    "axios": "^0.15.3",
    "bootstrap-sass": "^3.3.7",
    "cross-env": "^3.2.3",
    "jquery": "^3.1.1",
    "laravel-mix": "0.*",
    "lodash": "^4.17.4",
    "vue": "^2.1.10"
  },
  "dependencies": {
    "ace-builds": "^1.2.6",
    "animate.css": "^3.5.2",
    "bootstrap": "^3.3.7",
    "bootstrap-datepicker": "^1.6.4",
    "bootstrap-datetimepicker": "0.0.7",
    "bootstrap-switch": "^3.3.4",
    "bootstrap-toggle": "^2.2.2",
    "brace": "^0.10.0",
    "cropperjs": "^1.0.0",
    "datatables-bootstrap3-plugin": "^0.5.0",
    "datatables.net": "^1.10.15",
    "datetimepicker": "^0.1.38",
    "dropzone": "^5.0.1",
    "highlight": "^0.2.4",
    "icheck": "^1.0.2",
    "jquery-match-height": "^0.7.2",
    "jquery-sortable": "^0.9.13",
    "jquery-ui": "^1.12.1",
    "perfect-scrollbar": "^0.7.1",
    "readmore-js": "^2.1.0",
    "select2": "^4.0.3",
    "simplemde": "^1.11.2",
    "slugify": "^1.1.0",
    "tinymce": "^4.6.3",
    "toastr": "^2.1.2",
    "vue": "^2.3.4"
  }
}

Why should Voyagers package.json be merged with Laravels?!
Those are two different npm "projects"

Can I use the app.js of Voyager and the app.js of my Laravel project? It repeat included scripts as vue and jquery packages. Will generate conflicts?

To use Vuejs within a Voyager project you will need to remove the default Laravel jQuery load in the bootstrap.js file within your resources/assets/js directory. This is causing a conflict with the Voyager jQuery version.
Just find this section and remove it completely.
/**
 * We'll load jQuery and the Bootstrap jQuery plugin which provides support
 * for JavaScript based Bootstrap features such as modals and tabs. This
 * code may be modified to fit the specific needs of your application.
 */

try {
    window.$ = window.jQuery = require('jquery');

    require('bootstrap');
} catch (e) {}

You will then also need to go to the master.blade file within the vendor files and add an id="app" to the main content wrapper.
You can find this around line 99 in the file and there is a comment  within the blade file. The div you are looking for has a container-fluid class on it.

                @yield('page_header')

                @yield('content')

Don't change anything under /vendor.

there is conflict with jquery inside bootstrap.js that require in the app.js
just uncomment single line require jquery and all working fine.
i have added it successfuly in my laravel voyager project, cause i cannot add multiple data dynamically when i have hasMany relationship,
so i think to add some vue component inside voyager create blade so i can insert many data to related table
im override voyager views to mine so i think it wouldn't break other script

Please don't comment on really old/closed issues. This has gone untouched for nearly a year and was for an older version.


Special symbols

Good day.
Thank you for the amazing program.  It helps a lot.
In engineering, we use various special naming conventions, which I do not see in Calcpad at this stage.
It would be a great help if these were added. The suggestions are:
X_infinity  will display as X with subscript ∞
X_bar will display with a bar centered above the X
X_dot    will display with a dot centered above the X
X_ddot   will display with a double-dot centered above the X
X_hat     will display with a hat (^) centered above the X
X_tilde    will display with a tilde (~) center above the X
X|minus  will display as X superscript -
X|plus will display as X superscript+
X|star will display as X*
I see the following options are available, but I think this might help in programming, and not using special keys
X|o will display as X superscript o.
X_prime will display as X'
X_dprime  will display as X''
X_tprime  will display as X'''
Thank you again for your effort to make this program much better.

Hi @Itenium!
Thank you for your suggestions. It is a good idea to use aliases to implement decorations on names. Only vertical bar cannot be used, since it is already in use as a separator. But I think, underscore can be applied instead.


feat: Add signInMulti method

Description
This PR is about adding the signInMulti method to the public API of the wallets in Wallet Selector based on https://github.com/near/NEPs/pull/428 .

Added interfaces in wallet.types for the signInMulti.
Added signInMulti in each wallet, it initially throws when calling this method.
Added logic in the core package to allow sign-in with multiple contracts.
Updated modal-ui and modal-ui-js to pass the list of contracts to the signInMulti method.
Added docs for signInMulti.

Wallets that support signInMulti in this PR

none

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Type of change.

[ ] FIX - a PR of this type patches a bug.
[x] FEATURE - a PR of this type introduces a new feature.
[ ] BUILD - a PR of this type introduces build changes.
[ ] CI - a PR of this type introduces CI changes.
[ ] DOCS - a PR of this type introduces DOCS improvement.
[ ] STYLE - a PR of this type introduces style changes.
[ ] REFACTOR - a PR of this type introduces refactoring.
[ ] PERFORMANCE - a PR of this type introduces performance changes.
[ ] TEST - a PR of this type adds more tests.
[ ] CHORE - a PR introduces other changes than the specified above.

Hi @kujtimprenkuSQA @MaximusHaximus What is the status of this PR? Our team is recently tried to add a relevant feature and discovered this. I wonder if we can move this forward

Hi @kujtimprenkuSQA @MaximusHaximus What is the status of this PR? Our team is recently tried to add a relevant feature and discovered this. WIP branch. I wonder if we can move this forward

Hi, this PR is not ready to be merged yet as we still need this additional PR https://github.com/near/wallet-selector/pull/847 related to the comment https://github.com/near/wallet-selector/pull/811#discussion_r1242130459 to be reviewed and make a decision if we should go with it or not since it will introduce breaking changes in Wallet Selector.
As of right now, we are not aware if any wallet supports the signInMulti.
For browser wallets I think this update in NAJ is needed: https://github.com/near/near-api-js/issues/1153 there was some work done related to it: https://github.com/near/near-api-js/pull/1163

OK, so maybe I may move forward with my experiments in here then: https://github.com/near/wallet-selector/pull/887 ?
This approach does not require change in wallets, and does not introduce any breaking change to the wallet selector. It simply offers the option to add a function access key to another contract, and store it in a separate keystore ( near-api-js supports multiple keystore with different prefixes ).
As you can see from the test case there's a new method addContractConnection that you can call to add a function access key to an additional contract and store it locally.
For the particular issue for NEAR DevHub the idea is then to create the access key for the devhub contract when you submit something for the first time, and then reuse that access keys for later calls. This way, the user could also authenticate with other contracts on demand.
cc @ailisp @frol

See a proof of concept demo video here ( for the wallet-selector guestbook ):
https://www.youtube.com/watch?v=ocZKP2-Lxes

@petersalomonsen the demo is very cool! I wonder how can we invoke wallet.addContractConnection from the DevHub widget, since there is no BOS api to access wallet directly

@petersalomonsen the demo is very cool! I wonder how can we invoke wallet.addContractConnection from the DevHub widget, since there is no BOS api to access wallet directly

@ailisp thanks, and actually you don't need to invoke that from the DevHub widget. This should be handled by the nearsocial viewer ( or maybe VM ) so that it detects if there's a wallet redirection, and then offers to add a function access key for that contract. Here's an example of how I've added this to the viewer for my PoC with the DevHub widget: https://github.com/NearSocial/viewer/pull/189/files
And this is also what's used in the demo you can see here: https://youtu.be/DVoZK5CJ2uE

What is the plan for this feature moving forward? Any timeline estimates or prediction of when it could be available?

What is the plan for this feature moving forward? Any timeline estimates or prediction of when it could be available?

The initial work for adding the signInMulti into the wallet-selector has been done in this PR, but to address the comment left here https://github.com/near/wallet-selector/pull/811#discussion_r1242130459 there was a need to make some additional changes https://github.com/near/wallet-selector/pull/847 that would be breaking changes in wallet-selector.
We still need a review from Pagoda and further discuss this implementation before it's merged.
As mentioned in the above comments the currently available keystores will have to catch up in order to support multiple keys per account https://github.com/near/near-api-js/issues/1153 there was some work done related to it: https://github.com/near/near-api-js/pull/1163


json_decode JSON_BIGINT_AS_STRING PHP 5.5.?

PHP Warning: json_decode(): option JSON_BIGINT_AS_STRING not implemented
https://bugs.php.net/bug.php?id=63520
art4/json-api-client/src/Utils/Helper.php line 54
maybe this should be workarounded/adopted to be future proof
I am experiencing this with php version 5.5.9 on a debian server - on dev systems it was all good...

I think you filed this in the wrong place - this is a ruby client, not php


More comprehensive unit harmonization

Change Summary
Unit harmonization is improved by:

using a better map parsed from WRF Registries (yes, all of them, but not WPS)

translations are generated manually using custom external tool
includes all versions from WRFv4.0 onwards
makes bracket cleaning superfluous

extracting this map from the config yaml to avoid clutter

Related issue number

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI
[x] Documentation reflects the changes where applicable

There are some units which I didn't quite know how to translate:

top level eddy conductivity from previous timestep (W/m.K)

is this W m-1 K-1 or W K m-1?

Maximum mass-flux (neg: all dry, pos: moist) (m/s * area)

is this m3 s-1 or m-1 s-1 or even kg m2 s-1 or kg s-1 m-2?

Small ping on this PR :)

As far as the units of uncertain translation go:

savedtke12d with W/m.K: given how it is used in https://github.com/wrf-model/WRF/blob/master/Registry/registry.lake, I'd say match the thermal conductivity values elsewhere in the same registry...so W m-1 K-1.
maxMF with m/s * area: given how it is used in https://github.com/wrf-model/WRF/blob/v4.2/phys/module_bl_mynn.F, it is the product of edmf_a (unit - which becomes dimensionless) and edmf_w (m s-1), which weirdly enough implies that it should be m s-1. I'm not too concerned about getting this perfectly right, as I'd hope that anybody digging that much into the weeds of the MYNN-EDMF scheme knows what they are doing to be able to properly use that field.

Hey, happy holidays! Sorry for the long delay on my part now... Didn't have too much time to spend on this until now due to AGU.
I added the changes, however I don't quite know what you would like to see here.

add new tests for each of the new categories of units handled in the expanded unit_harmonization_map

What are the new categories you're referring to?

Small ping here :)

Thanks for the ping on this, and sorry for the very long delay! Unfortunately I'm a bit swamped with prelim-related stuff at the moment, so I won't be able to get back to this until next week. But, hopefully will be able to then.

Hey :) just a small reping

Hey @jthielen, I'm just going to go ahead and merge this if you don't mind.

Hey @jthielen, I'm just going to go ahead and merge this if you don't mind.

Yes, please go ahead! Sorry for my continued inattentiveness. Hopefully things will be getting better soon.


Chore/test coverage/management resource

Checklist

[x] Server: I added multiple integration tests (Spring) related to the features

Motivation and Context

This PR increases the test coverage of Management and Audit resources from 37% and 10% to 100% (both). All REST endpoints are covered now.

see my inline comment. Do NOT use additional spy beans!

Yes I removed them. I tried to use them, as I thought that was the reason for GitHub CI server tests to fail, but it is not.

see my inline comments and please merge develop

I resolved the comments and updated the branch. The Server tests on GitHub CI are failing, but this is only 2 quiz exercise tests


fix: bump Dockerfile to use Python 3.10 image (fixes #533)

Thought I'd throw in a quick fix for this - should resolve #533


Exploration for milestone 1c

In order to think about milestone 1c I'll do some hackathon-style experiment, linking gh-issues and a jira instance and maybe a TikiTracker.
For GitHub, the quick start was quite easy, and simply running things like gh api /issues --method GET > gh.json will do the trick for this goal.
I'll look into Jira now to see if I can do the same there

Got Jira API access working with basic auth:
curl -v https://mysite.atlassian.net --user me@example.com:my-api-token

Next step:

extract some issued from GitHub, store them in a .json file
run a lensmap over them,
POST them to Jira, store the Jira identifiers in LRI mapping

Working on this in https://github.com/federatedbookkeeping/task-tracking/tree/ponder-source-1

This seems to work well so far.
I think the main issue that feels a bit unsolvable may be https://github.com/federatedbookkeeping/research/issues/49
But will deal with that as described there.
For Solid OS Issue tracker, the LRI mapping could be stored inside the Turtle. In general, the bridge bot can keep track of the LRI mappings. I feel confident that this is now successfully explored, so we can move on to Milestone 3.


Adding cpu and memory requests to status-monitor container and remove limit from the coredns container

What this PR does / why we need it:
Adding resources.requests cpu and memory to status-monitor container.
Remove the resources.limit.memory from the coredns container.
Special notes for your reviewer:
Release note:

/approve

Can you issue please a new tag ?


[SVE] Add support for representing and creating buffer-level predicates

Representation
This commit extends BufferLoad and BufferStore to accept a predicate mask argument indicating which lanes in a vectorized buffer load/store should be read/written.
As a simple example, we can load all lanes:
tir.BufferLoad(buf, [tir.Ramp(0, 1, 8)], predicate=tir.Broadcast(1, 8))

Or disable loading all lanes:
tir.BufferLoad(buf, [tir.Ramp(0, 1, 8)], predicate=tir.Broadcast(0, 8))

In TVMScript, buffer loads and stores are currently displayed using a "short-hand" notation e.g. A[0:4], but there was no clear path for extending this notation to support predicates. Therefore, the vload/vstore notation is used e.g. A.vload([T.Ramp(0, 1, 4)], predicate=...). The TVMScript printer falls back to the vload/vstore notation whenever predicates are specified.
Creation
Buffer-level predication becomes more motivating when combined with the tir.get_active_lane_mask intrinsic. It can be used to mask off lanes when the vectorized axis is not divisible by the vector length. A detailed example and rationale can be found in the RFC.
Predicated buffer load/stores are created in the VectorizeLoop pass via TryPredicateBufferAccesses. This pass aims to convert block-level predicates e.g.
for i_0 in T.serial(4):
    for i_1 in T.vectorized(4):
        if i_0 * 4 + i_1 < 14:
            B[i_0 * 4 + i_1] = A[i_0 * 4 + i_1] + 1.0

to buffer-level predicates, e.g.
for i_0 in T.serial(4):
    predicate = T.get_active_lane_mask("int1x4", i_0 * 4, 14)
    A_load = T.meta_var(A.vload([T.Ramp(i_0 * 4, 1, 4)], predicate=predicate))
    B.vstore([T.Ramp(i_0 * 4, 1, 4)], A_load, predicate=predicate)

It takes a conservative approach for now, focussing only on expressions produced by the split scheduling primitive, but more complex expressions could be supported in the future.
TryPredicateBufferAccesses can be explicitly enabled/disabled with the tir.enable_buffer_level_predication pass context option. By default it will be disabled, unless the target supports SVE, in which case it will be enabled by default.
~Note: this commit depends on https://github.com/apache/tvm/pull/16965, so also contains the contents of https://github.com/apache/tvm/pull/16965.~
Co-authored-by: Elen Kalda<EMAIL_ADDRESS>Co-authored-by: Neil Hickey<EMAIL_ADDRESS>

cc @ekalda @tqchen @Lunderberg @cbalint13 @Anndrey24

No problem, and thank you on the revisions!

@tvm-bot rerun

friendly ping @Lunderberg if you have some free time

Apologies for not getting back to the review, and thank you for making the changes!


Query Recommendation by Recommendation Type

As a ...
I need ...
So that ...
Details & Assumptions:

...

Acceptance Criteria:
Given [some initial state]
When [some event]
Then [some measurable outcome]

@prasannachidire update the UserStory


Expect one key per secret.

Purpose
Load one key per secret from AWS.
Checklist

[ ] My code follows the style of this project.
[ ] The code compiles without warnings.
[ ] I have performed a self-review of the changes.
[ ] I have documented my code, in particular the intent of the
hard-to-understand areas.
[ ] (If necessary) I have updated the CHANGELOG.

@shjortConcordium Can you also make sure there are no multi-line log entries. They are cumbersome to deal with and break nice properties logs generally have.
That probably means replacing any remaining {#:?} with {} or {:?}.


Update high-availability.md

For #### Install with a self-signed certificate you need add command "-static address local ip"

@fazars : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Standardize icon sizes on map

This is pretty minor, and may be fine to just leave. The icons are causing the buttons on the map to be different sizes:

The first highlighted button is larger than the second highlighted button, even though there's more text on the second one. Seems like we could give the icons a set size or something. Pretty sure it's the icons anyway. Probably would go with a universal height across them and an auto width?

Yeah I'm pretty sure it's the icons too.

It is the icons. We could increase the min height of the container as a quick fix;however, the optimal solution would be to have icons that occupy similar real estate: height and width.
There is a related umbrella issue for standardizing icons.

Closed with the linked PR


enhancementadd eliminate filter on one row relation rule

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Volunteers can add blue markers to the map

[x] become a volunteer form
[x] add to Firebase and the map
[x] clicking on a blue marker shows the volunteer's details

Finished