runtime: memory of finished goroutines not freed

Go version
go version go1.19 windows/amd64
Output of go env in your module/workspace:
Does not depend env

What did you do?
I have observed that after creating a large number of Goroutines, the memory does not seem to be released back to the system. Specifically, I suspect there might be an issue with the sched.gFree.noStack in proc.go, where the Goroutine structures are not being properly cleared, leading to potential memory leak.
What did you see happen?
The memory used by the finished Goroutines does not appear to be released, even when the Goroutines are no longer in use. This suggests a potential memory leak in the runtime's Goroutine management.
What did you expect to see?
I expected that after Goroutines finish their execution and are no longer needed, the memory they occupied would be returned to the system.

I have observed that after creating a large number of Goroutines, the memory does not seem to be released back to the system.

In short period of time ? If so, it might related to  #9869 ?

1.19 isn't a supported version anymore (currently 1.22 and 1.21).
how are you measuring memory?
do you have a reproducer?

package main

import (
	"fmt"
	"net/http"
	_ "net/http/pprof"
	"runtime"
	"sync"
	"time"
)

func printMemStats() {
	var m runtime.MemStats
	runtime.ReadMemStats(&m)
	fmt.Println("`````````````````````````````````````````````")
	fmt.Println("Memory Allocation:")
	fmt.Println("Alloc:", m.Alloc)
	fmt.Println("TotalAlloc:", m.TotalAlloc)
	fmt.Println("HeapAlloc:", m.HeapAlloc)
	fmt.Println("HeapSys:", m.HeapSys)
	fmt.Println("HeapIdle:", m.HeapIdle)
	fmt.Println("HeapInuse:", m.HeapInuse)
	fmt.Println("HeapReleased:", m.HeapReleased)
	fmt.Println("HeapObjects:", m.HeapObjects)
	fmt.Println("runtime.NumGoroutine():", runtime.NumGoroutine())
}

func main() {
	go func() {
		fmt.Println(http.ListenAndServe("localhost:6060", nil))
	}()

	num := 1000000
	printMemStats()
	wg := sync.WaitGroup{}
	wg.Add(num)
	for i := 0; i < num; i++ {
		go func() {
			defer wg.Done()
			time.Sleep(time.Second)
		}()
	}
	wg.Wait()
	printMemStats()
	time.Sleep(time.Second * 5)
	runtime.GC()
	for {
		time.Sleep(time.Second * 10)
		printMemStats()
	}
}

The memory usage after creating one million goroutines is as follows.

The memory usage after a period of time is as follows.And then it never goes down again.

I think that the goroutines in sched.gFree.noStack have not been properly removed.

It is true that we never free a g structure once allocated. They get put in the allgs list and live there forevermore.
Freeing the gs could be done, I suppose, but would make unsynchronized access to allgs  trickier because it would need to handle the shrinking case. And maybe there are other parts of the runtime that assume gs are never freed.
Which is to say, maybe we could do this, but it isn't trivial.
Is there a situation where this is actually causing a problem? Most servers, at least in steady state, would reuse these gs effectively.


Add support in profiles plugin for directories

The profiles plugin currently has support to load a single "profile"
file for each component in the FQDN. This changeset makes it so the
plugin supports the filename actually being a directory with multiple
*.zsh files in it. Each of those files are then loaded in alphabetical
order

Is there any reason this was closed? I find myself wanting this same feature, and I've implemented it myself as well (albeit in a slightly different manner).


[turborepo] concurrency limit breaks when a task errors out

What version of Turborepo are you using?
1.6.3
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
Turborepo's concurrency setting breaks once an error is observed. If one of the executed tasks returns with 1 turbo will execute every remaining task at once regardless of the value of --concurrency

I also tested it with 1.5.*, the issue was present

I'm actually on Windows/WSL

Example, running turbo run test --concurrency 2
# ... before this point only 2 tasks were being executed at any given time
@alexaegis/advent-of-code-2021-21:test: ERROR: command finished with error: command (/home/alex/git/@alexaegis/advent-of-code/solutions/typescript/2021/21) pnpm run test exited (1)
# ... after it, you can see this is a lot more than 2
@alexaegis/advent-of-code-2016-02:test: cache miss, executing 639047a84ccf8023
@alexaegis/advent-of-code-2015-04:test: cache miss, executing 3280086c58a105dc
@alexaegis/advent-of-code-2020-05:test: cache miss, executing d6b6532f5c460697
@alexaegis/advent-of-code-2019-01:test: cache miss, executing 868b0f4fb2ba65fb
@alexaegis/advent-of-code-2018-15:test: cache miss, executing 8509e9399fb7ebd1
@alexaegis/advent-of-code-2018-03:test: cache miss, executing 05b14ceee3ab2c21
@alexaegis/advent-of-code-2018-12:test: cache miss, executing efa0d9a9a2918f24
@alexaegis/advent-of-code-2021-16:test: cache miss, executing d55648999d80d74f
@alexaegis/advent-of-code-2021-13:test: cache miss, executing 1ec18a1c68f5c9c8
@alexaegis/advent-of-code-2019-12:test: cache miss, executing bdd7390eb750ec0c
@alexaegis/advent-of-code-2020-21:test: cache miss, executing a1770238ff83c7bf
@alexaegis/advent-of-code-2020-16:test: cache miss, executing 37698a3f9f9f5d7f
@alexaegis/advent-of-code-2020-19:test: cache miss, executing 01518afe953f3653
@alexaegis/advent-of-code-2021-01:test: cache miss, executing ed7f78aed374eefa
@alexaegis/advent-of-code-2018-01:test: cache miss, executing 35d5464f25a1d456
@alexaegis/advent-of-code-2018-07:test: cache miss, executing ba5f1acdbb871f36
@alexaegis/advent-of-code-2018-09:test: cache miss, executing f81cf430f725eda6
@alexaegis/advent-of-code-2019-23:test: cache miss, executing c8a209c062bc69b6

Expected Behavior
When running a set of tasks, the number of concurrently executed tasks should never raise above the limit set by the user.
To Reproduce

I linked a branch where some tests are intentionally broken, the repo uses pnpm, run pnpm install and pnpm test for a quick reproduction

Have a repo with a lot of packages, each having a script that executes vitest on itself.
Run each of those using turbo with concurrency set to 2 (otherwise it would fill up all available RAM pretty quickly and fail. Also I usually set it higher but the difference between 2 running concurrently and all of them is easier to tell with the naked eye compared to 6 vs all of them)

At workspace package json:
		"lint": "turbo run test --concurrency 2",

At each package:
		"test": "vitest --passWithNoTests --coverage --run",

Watch turbo running each test task, 2 at most at any given time
At one point an error is encountered because of a failing test, the task exists with 1.
After this point turbo starts executing every remaining task at once. (Filling up memory and crashing eventually)

This isn't specific to tests, the same thing happened with lints, tsc checks and prettier.

Reproduction Repo
https://github.com/AlexAegis/advent-of-code/tree/repro/turbo-concurrency-bug

Tested in latest canary and this was fixed in the Rust port.


Fix IRC quit messages sending to all channels by tracking users

Keep a list of users in each channel, using the names event in addition to the join/part events, so as to prevent spamming unnecessary channels when the quit event is raised with all channels from a server.
Fixes #213.
I'm not sure if this is a bug with node-irc (the quit event shouldn't be sent for all channels on that server, just the channels the user is in) or if it's intended behavior (the quit event is sent 'for the server', and so for all channels on it). Either way this is a workaround to make the new functionality… less spammy. I might report it there but they don't seem to have very active development.
This also rewrites a test name to make it fit into the syntax ("Bot Events should…") and reflect the new functionality: "should be possible to get the bot to announce itself joining" → "should announce the bot itself when config enabled".

Coverage increased (+0.1%) to 98.238% when pulling 1c8fa12defd5b79a897330f19cd4d2f37c055a22 on Throne3d:fix/quit-messages-all-channels into 27f9abe6c79fb22ba786a32580fb4c543e472045 on reactiflux:master.

I can't think of a better way to fix this either - seems like it's a TODO in the node-irc codebase: https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L587-L592
I'm not sure if it's strictly worth it, but I think the implementation here is clean enough that we should include it. Maybe use a set instead of an array for the user lists though? That way you can use .add and .delete instead of needing to find the index etc.

Coverage increased (+0.08%) to 98.222% when pulling cc990d67e14dc8e9b093f895d3574b2d29518b52 on Throne3d:fix/quit-messages-all-channels into 27f9abe6c79fb22ba786a32580fb4c543e472045 on reactiflux:master.

It doesn't even look like in their code they're trying to match if the user is in that channel – they just delete the user from the channel (whether they were there or not) and proceed to add it to the list, when I think they should be guarding by whether the object's key exists?
I've updated this to use sets – thanks, didn't realize they existed in JavaScript. (Or, well, ECMAScript 6?)

Ye, it indeed doesn't look like it attempts to find the correct username.
There's a couple of PRs to node-irc for the issue: https://github.com/martynsmith/node-irc/pull/376 and https://github.com/martynsmith/node-irc/pull/359
If they ever get merged we can remove this I guess.

Released in 2.3.1 - thanks!


The hdf5 and hdf5-sys names on crates.io

Dear user of / contributor to hdf5-rs: if you support the idea that this crate is renamed to hdf5 on crates.io (and the library is renamed to hdf5 as well), please leave a shout here (your voice matters!):

https://github.com/stainless-steel/hdf5/issues/5

Longer story: when this crate was created, names "hdf5" and "hdf5-sys" (and "hdf5" library name) had already been reserved on crates.io, hence we currently have the following collection of crates:

hdf5-rs
libhdf5-sys
hdf5-derive
hdf5-types

Also, since hdf5_rs makes for an unwieldy import name, the library is currently named h5, like h5::File. This makes it somewhat confusing and is arguably non-idiomatic, compared to other popular Rust crates (e.g. take "curl": the github repo is "curl-rust", the crates are "curl-sys" and "curl", the library is "curl").
As the author (@IvanUkhov) of hdf5 and hdf5-sys crates notes, he has no future plans in supporting or developing those packages -- which may lead to further confusion for new users. However, he kindly agrees to transfer the ownership of those names to us, conditional on the fact that this is "what the community prefers" (which is the part where you, the community, come in):

However, I do want to make sure that it is indeed what the community prefers, and I wasn’t able to infer this from the download counters of hdf5 and hdf5-rs.

If we rename the crates, we'll end up with the following:

hdf5
hdf5-sys
hdf5-derive
hdf5-types

with the library name being "hdf5", importable like hdf5::File.
libhdf5-sys crate would then be deprecated and eventually removed from the crates.io index.

The naming dilemma has been resolved, thanks a million to everyone involved (see https://github.com/hilbert-space/hdf5/issues/5 for details).


Fix link to docs in README

The previous link is broken. I've updated it to point to docs.rs instead.

This looks good to me. Thanks @ucarion!

My pleasure! Thanks for working on lazy_static!


Add jenkinsfile

@mohhef Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


[BUG] Speedmine BreakCrystal issue

https://user-images.githubusercontent.com/103523147/188643868-e9d4d7fe-3530-483a-998b-01fba04bd245.mp4
BreakCrystal in Speedmine only breaks crystal which are placed next to obsidian and not on the obsidian

😅 I know it is a bit confusing but breakCrystal only breaks crystals that are already there. The crystals Speedmine places itself need to be broken with AutoCrystal ahhhhhhhhhhhhhhhhhhhhh. I guess this could be done better...

Yea, if u could make speedmine break crystals which it places it could be broken a lil bit faster ig

i lick yuo config :+1:


Get WSL

https://cloudblogs.microsoft.com/industry-blog/en-gb/cross-industry/2020/03/31/how-to-deploy-linux-in-wvd-when-you-cant-deploy-linux-in-wvd/

Need to use a larger VM SKU (not B series) and also need to add WSL to image.


add invoice api

Codecov Report

Merging #3 (d125351) into main (6dcd557) will increase coverage by 1.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   96.74%   98.14%   +1.40%
==========================================
  Files           3        4       +1
  Lines         123      216      +93
==========================================
+ Hits          119      212      +93
  Misses          2        2
  Partials        2        2

Impacted Files
Coverage Δ

contact/contact.go
100.00% <100.00%> (ø)

invoice/invoice.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dcd557...d125351. Read the comment docs.


fix: predictions lambda access policy type

Description of changes

changed type exposed for prediction lambda access from CfnRole to CfnPolicy

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9058 (6045303) into master (5d60832) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9058   +/-   ##
=======================================
  Coverage   55.42%   55.42%
=======================================
  Files         885      885
  Lines       50102    50102
  Branches    10806    10806
=======================================
  Hits        27769    27769
  Misses      20285    20285
  Partials     2048     2048

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d60832...6045303. Read the comment docs.


$category->getSubCategories() have to use the id_lang

$category->getSubCategories() have to use the id_lang instead of id_categorie

Questions
Answers

Description?
Please be specific when describing the PR.  Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.

Type?
bug fix / improvement / new feature / refacto / critical

BC breaks?
yes / no

Deprecations?
yes / no

Fixed ticket?
Fixes PrestaShop/Prestashop#{issue number here}.

How to test?
Please indicate how to best verify that this PR is correct.

Hi, just stumbled over this issue.
It is still a bug in current version. It is very obvious if you look at the code. Please reopen and use this description table:
Descripton:
Wrong ID in method arguments in getWidgetVariables
Type: bugfix
BC breaks: no
Deprecations: no
Fixed ticket: no / unknown
How to test: navigate to a child category in mode "CATEGORY_ROOT_CURRENT_PARENT"


PowerToys Run errored when not actively been used

ℹ Computer information

PowerToys version: <IP_ADDRESS>
PowerToy Utility: n/a
Running PowerToys as Admin: no
Windows build number: 10.0.19042.0

📝 Provide detailed reproduction steps (if any)

Browsing a website, not actively using any PowerToys app
Get pop-up message titled "Something went wrong" and asked to file a bug by clicking the link (i.e. here).

✔ Expected result
Nothing - I would not expect to see this message when not interacting with the app.
❌ Actual result
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19042.0
IntPtr Length: 8
x64: True
Date: 28/01/2021 15:49:03
Exception:
System.ArgumentException: Destination array was not long enough. Check the destination index, length, and the array's lower bounds. (Parameter 'destinationArray')
at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)
at System.Collections.Generic.List`1.System.Collections.ICollection.CopyTo(Array array, Int32 arrayIndex)
at System.Collections.ArrayList.InsertRange(Int32 index, ICollection c)
at System.Windows.Data.ListCollectionView.b__1_0()
at MS.Internal.Data.SynchronizationInfo.AccessCollection(IEnumerable collection, Action accessMethod, Boolean writeAccess)
at System.Windows.Data.BindingOperations.AccessCollection(IEnumerable collection, Action accessMethod, Boolean writeAccess)
at System.Windows.Data.ListCollectionView.RefreshOverride()
at System.Windows.Data.CollectionView.RefreshInternal()
at System.Windows.Data.CollectionView.PostChange(NotifyCollectionChangedEventArgs args)
at PowerLauncher.ViewModel.MainViewModel.<>c__DisplayClass141_0.b__0()
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
Once I close the error message, I appear to be able to still use PowerToys without having to restart it.
📷 Screenshots

Tracked by #8921

@editedbaseline
Can you update it to 0.33.1 and check if it still reproduces?

Hi, updated but given I didn't do anything to trigger it initially (it just happened while I was working on something else) I cannot recreate on demand.
Thanks

@editedbaseline
Thank you for following up!
Let us know if it will happen with the new version.


Add rolandeco's file

created a branch, created a file and made a commit, and opened a pull request

ggggggggg


Dependency update September 2024

Pull Request
🤨 Rationale
A follow-up for https://github.com/ni/nimble/pull/2410 and https://github.com/ni/nimble/pull/2408 which were getting in weird states due to dependency updates around rollup.
👩💻 Implementation
Previously had found that the rollup-plugin-sourcemaps was causing issues because it had not been updated in a long time and resulted in a transitive dependency on an old rollup version. This seems to mess with rennovate updates.

Updated to rollup-plugin-sourcemaps2 which now seems to be used in at least a few projects
Updated other dependencies that were pending
Leveraged a new flag added to concurrently that causes the build logs to align nicer by making prefixes the same width. Also has a bug fix that handles stray new lines once in a while.
Rebuilt the lockfile

🧪 Testing

Verified manually that the bundled minified builds have working source maps
Rely on CI for rest of the updates
Trigger full storybook build

✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI gonna bypass for a pretty straightforward dependency upgrade


SingleGetTickerProviderMixin gone after updating to 3.11.1

Describe the bug
My app had a SingleGetTickerProviderMixin on my controller to pass a vsync parameter to a TabBarController. Once I updated the package the mixin is no longer available, don't know if this is intended or not - maybe it was overlooked in the refactoring process?
To Reproduce
Steps to reproduce the behavior:

Create a controller and try to add the above mixin, an error will be displayed.

Expected behavior
The mixin should be there as was in previous versions
Screenshots
If applicable, add screenshots to help explain your problem.
Flutter Version:
1.20.1 - pre
Getx Version:
3.11.1
Describe on which device you found the bug:
ex: Not device related
Minimal reproduce code
class SampleController extends GetxController with SingleGetTickerProviderMixin {}

observe the error from the IDE on Get 3.11.1.

This PR solves it https://github.com/jonataslaw/getx/pull/632
Today it will go to pub.dev

Sorry, didn't see that... looking forward to the update.
Btw, thanks for this amazing package, my entire app has been transformed as a result!

Added again at 3.12
Thanks for reporting this


min fee as ax+b

In the LaTeX spec, instead of keeping the minfee calculation abstract, define it as ax+b, where a and b are in the protocol constants and x is the number of bytes in an encoding of the transaction.

After talking with @dcoutts, it would be better to treat x as an abstract size, not the bytes of the transaction.  We would then have an abstract function which computes x based on a transaction.
￼￼￼￼￼


Environment variables are the unresolved variables

Describe the bug
Environment variables are the unresolved variables
To Reproduce
Steps to reproduce the behavior:

Create lambda with 1 env var
Create step function with that lambda
Log the process.env
Your env vars show up as the unresolved variable string. i.e. ${something}.

Expected behavior
It should show up as the real env var's value
Additional context
As noted here:

Note: Variable references in the serverless instance are not resolved before a Plugin's constructor is called, so if you need these, make sure to wait to access those from your hooks.

So we just need run the injectEnvVars on a certain hook when the env vars have been evaluated

solved, thank you very much!


Get the columns of a table at extension time

Just thought I'd make an issue a-la https://github.com/tgriesser/bookshelf/pull/177#issuecomment-31844939
I think this is a great idea, and not being able to know information about the columns in a table has been a big issue for me as well.

Just checking if this is implemented now?

@amanmohla not to my knowledge.

@rhys-vdw @amanmohla There is still my old PR https://github.com/tgriesser/bookshelf/pull/244
It might not be exactly what you want and maybe it won't even work with the current version but maybe it is a start?

getTableColumns: function () {
        var tableName = this.getTableName(),
            schemaName = this.getSchemaName();
        return thBookshelf.knex
            .raw('SELECT column_name FROM information_schema.columns WHERE table_schema = \'' + schemaName + '\' AND table_name = \'' +
                tableName + '\'')
            .then(function (result) {
                var columns = _.map(result.rows, function (row) {
                    return row['column_name'];
                });
                return promise.resolve(columns);
            });
    }

At the moment I am using something like this to fetch columns, but was wondering if there is something already implemented.

@amanmohla Why not check out @johanneslumpe's PR #244? If it works we might be able to work towards getting it in the next release.

I wanted to get TableColumns for the exact same reason, clean invalid attributes from the query. However, I wanted to set them at runtime, so that I don't have to make a DB call for each query just to get column names. I think i can reuse some of the code in the pull request.

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again

This is a very old issue, but if anyone finds this, you can use Knex's columnInfo to do this.


Update tapable.md

Noticed a small (teeny tiny) error in the first line. Just fixing it :)

Closing this commit, I'd like to make a few more changes to the docs on this page and will recommit in a new branch.


feat: add FeatureFlagProvider

Description
In #320 we added server-side generation of feature flags. That populated the initial flags bootstrapped on posthog.init, and we could then query posthog to get the feature flag status
It turns out that this has two problems:

Posthog is initialised in a useEffect, so the server render and initial client render don't have information about flags
useAnalyticsService only initialises posthog when cookie consent is granted. If the user denies consent or never interacts with the cookie banner, posthog won't work as expected

This PR:

Creates FeatureFlagProvider
Passes bootstrapped server feature flags to FeatureFlagProvider
Makes useClientSideFeatureFlag consume the provider, and fall back to a bootstrapped value if posthog hasn't loaded flags

Testing:

We don't have any flags at the moment, but you can play with this on #354

LGTM, tested the 'cool new feature' and worked as expected

Great. Thanks Joe

:tada: This PR is included in version 1.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CSV export format improvement

Is your feature request related to a problem? Please describe.
Currently the CSV export can hardly by used for calculation, as the values are "polluted" with Mi, m, -> or ? characters
Describe the solution you'd like
It would be very useful to have a CSV export with values that can be used for calculation in a spreadsheet, like for the json export.
Describe alternatives you've considered
Actually the only way I found is to take the JSON as input and do my own CSV  with tools like jq, but it's not very convenient

Hi, this makes sense and we are open to a PR that would fix this. The relevant code is in robusta_krr/formatters/csv.py


Dashboard disfigured by a comment!

Many a times when my pc is off, I use my mobile for codewars! I use the site as desktop mode on chrome! This is an issue I faced today. A comment disfigured my dashboard. I know this a silly thing to report as the site isn't meant for mobile users but I felt like it should be taken care of!

OS: [Android (Pie)]
Browser: [Chrome(Lastest Version available on Googleplaytore)]

Fixed


Freecam movement issues unknown commands

Unknown command "0460^7"
Unknown command "20^7"
Unknown command "60^7"
Unknown command "2^7"
Unknown command "5^7"
Unknown command "98^7"
Unknown command "4^7"
Unknown command "5^7"
Unknown command "5^7"
Unknown command "7^7"
Unknown command "41^7"
Unknown command "67^7"
Unknown command "55^7"

This happens when spamming movement keys rapidly, and is only applicable to ETe, likely same issue as the client has sometimes with command execution, closing.


[HOLD for payment 2022-03-22] Searching non existing currency results in a blank page with active Confirm button - reported by @Tushu17

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

In NewDot, click the green "+" button and select Send Money or Request Money
Click on Currency symbol
Enter something that returns no results (i.e. enter "bug" into the search field)
Click continue on a empty box.

Expected Result:
It should show something like "no results found" and Confirm button should be disabled.
Actual Result:
It shows a blank results page with an active continue button.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.41-0
Reproducible in staging?:  Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/156305411-494877bf-7ca4-4929-a703-edf6e3ec959d.mp4
Expensify/Expensify Issue URL:
Issue reported by:  @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644878029333329
View all open jobs on GitHub

Reproduced this issue, and clarified the action steps in the original GH issue. Ready for engineering. 👌

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Looks good to me, sending to external for better handling of this case in the app.

Upwork job posting: https://www.upwork.com/jobs/~0117a680819923466f

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

I suggest to update IOUCurrencySelection.js so that sectionlist has listemptycomponent set to show No results found when data is empty, and a state to hold sectionlist's data

@laravue1118 You should be new here. Check out our contributing guidelines
Go through these closed issues here for reference.
And make a proper proposal with all the changes you would make to solve this issue.

Proposal
 {this.state.currencyData.length === 0 ? (
                                <View style={[styles.ph5, styles.pb5]}>
                                    <Text style={[styles.textLabel, styles.colorMuted]}>
                                        {this.props.translate('common.noResultsFound')}
                                    </Text>
                                </View>
                            )
                            : null }

we can add the code given above after line 181. By this we can show the no results found message below the search input
https://github.com/Expensify/App/blob/3d2ec235a49198fe7759bfff0bf022e644b3d27b/src/pages/iou/IOUCurrencySelection.js#L176-L181
And to remove the ALL CURRENCIES header when no result is there we can just add a if statement like below -
    getSections() {
        const sections = [];

        if (this.state.currencyData.length > 0) {
            sections.push({
                title: this.props.translate('iOUCurrencySelection.allCurrencies'),
                data: this.state.currencyData,
                shouldShow: true,
                indexOffset: 0,
            });
        }
        return sections;
    }

Proposal
I will update getSections function.
`
getSections() {
    const sections = [];

    if (this.state.currencyData.length > 0) {
        sections.push({
            title: this.props.translate('iOUCurrencySelection.allCurrencies'),
            data: this.state.currencyData,
            shouldShow: true,
            indexOffset: 0,
        });
    }

    return sections;
}

`
I will update rendering of sectionlist.
`
                        <SectionList
                              ...
                              ListEmptyComponent={ <Text>No results found</Text>}
                              ...
                              renderSectionHeader={({section: {title}}) => (
                                  this.state.sections.length > 0 ? <View>
                                      <Text style={[styles.p5, styles.textMicroBold, styles.colorHeading]}>
                                          {title}
                                      </Text>
                                  </View> : null
                              )}
                          />

`
And in the confirmCurrencySelection, I will check if the data is empty and show error.
`
confirmCurrencySelection() {
    if (this.state.currencyData.length === 0) {
        // show error
       return;
    }
    IOU.setIOUSelectedCurrency(this.state.toggledCurrencyCode);
    Navigation.goBack();
}

`

I will check on this by Wednesday.

Hmm I actually think it would be ok to keep the All currencies header and display No results found underneath it. @laravue1118 can you expand on how you will show the error?

@luacmartins, This is how it will look if we keep the All currencies header -

I like that better, but I'll ask for @Expensify/design input here.

I had proposed a solution here in case it got missed. I have a better approach for both the options -
                               {this.state.currencyData.length === 0 && (
                                            <Text style={[styles.ph5, styles.textLabel, styles.colorMuted]}>
                                                {this.props.translate('common.noResultsFound')}
                                            </Text>
                                          )}

If we wanna keep the All currencies header we need to add the code written above after line 209 https://github.com/Expensify/App/blob/3d2ec235a49198fe7759bfff0bf022e644b3d27b/src/pages/iou/IOUCurrencySelection.js#L205-L212
If we don't want the  All currencies header then we can just render the header based on this.state.currencyData.length
renderSectionHeader={({section: {title}}) => (

                                        <View>
                                            {this.state.currencyData.length === 0 ? (
                                                <Text style={[styles.ph5, styles.textLabel, styles.colorMuted]}>
                                                    {this.props.translate('common.noResultsFound')}
                                                </Text>
                                            ) : (
                                                <Text style={[styles.p5, styles.textMicroBold, styles.colorHeading]}>
                                                    {title}
                                                </Text>
                                            )}
                                        </View>
                                    )}

cc: @luacmartins

When there are no results based on your search, I think I prefer it without the "ALL CURRENCIES" header.

Thanks @shawnborton! @thesahindia I like your updated approach, but can you elaborate on how you'll display the error when the user taps Confirm with no selected currency?

@luacmartins, I think we don't need an error here as one option always stays selected, so when the user taps confirm the currency that was already selected will be used.

Hmm that makes sense. Alright then, let's move forward with your updated approach and removing the All currencies header.

📣 @thesahindia You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@thesahindia Can you please apply to the job in Upwork so I can issue payment? - https://www.upwork.com/jobs/~0117a680819923466f

Done ✅

@Santhosh-Sellavel @Tushu17 @thesahindia paid - thank you!

@NicMendonca When you please end the contract on the Upwork, thanks!


[deployment examples] simplify traefik configuration

Description

Simplifies the deployment example by using a global http to https redirect.

During testing and changing the configuration a few things popped up and have been fixed / changed, too:

Removes the "owncloud10_with_oc_web" example. This is outdated since we have the ownCloud Web app for ownCloud 10 and the Web sidecar docker image (https://hub.docker.com/r/owncloud/web). Parts of the example have been prepared to demonstrate the migration, but it was neither working nor documented. An migration example will be added in https://github.com/owncloud/ocis/pull/2302
fix login with ldap example by setting the cn to the username
remove idp from the keycloak example because it will never be used in that case
fix access to the minio console in the S3 example deployment

Related Issue

none

Motivation and Context
Simplify the deployment example
How Has This Been Tested?

on dev machine by running docker-compse up -d in the respective deployment example directory

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

@micbar can I have a review please? :-)


Fully mock MetaMask

What is the new or updated feature that you are suggesting?
Would be awesome if testingUtils.getProvider() would return an EIP-1193 compatible provider.
Here is a mock provider which could be used:
https://github.com/NoahZinsmeister/web3-react/blob/f8e5531f8facb53d7cb35165d1878db284c24736/packages/eip1193/src/index.spec.ts#L20
Why should this feature be included?
When testing code based on web3-react, it actively uses the Web3Provider to add even listeners and make RPC requests.

Hey @talentlessguy! Thanks a lot for the issue!
So the current provider should implement quite closely the interface of an EIP-1193 provider, i.e. the request and the events part. Thanks to your link, I'm trying to migrate the event handling part to EventEmitter from node directly in order to be fully ok with EIP-1193 on this side (wip PR here :)
However, the provider is not functionally implementing the EIP-1193 specs intentionally as the goal is to let the developer mocks the way she/he wants the RPC requests and emit the needed events on demand.
I don't think I can return the mock provider of web3-react, the events emitting and listening are similar in both provider (once my update PR has been merged at least ahah), however the implementation of the request method is different. In the case of the mock of web3-react, only some RPC methods are mocked using local state while in the approach of this lib, we register mocks of any RPC method
However, to be honest, I have not tried the library with web3-react so I definitely need to do so in order to check if something is not working as intended 😅

Closing this issue as web3-react is now supported from #48
Reopen if any issues occur!


[cxx-interop] Only run tests for reference types against a recent Swift runtime, pt 2

rdar://128681577

@swift-ci please test


convert dwa encoder to use algorithm quantize

Convert the quantization from a massive table to a bit-fiddling algorithm which is more code but significantly faster (in some cases, almost 2x). This also eliminates the giant lookup tables from the binary, which reduces the compiled size of the core library by half on x86, with avx2 / f16c enabled anyway.
This will help with the dwa performance problems noted in #1915 where the compressor got much slower

This also eliminates the giant lookup tables from the binary, which reduces the compiled size of the core library by half on x86, with avx2 / f16c enabled anyway.

I think, based on the code that on non-intel the giant look up tables are eliminated as well, just checking because I could read this comment as the giant lookup tables still exist on not-intel. I'm asking though, because maybe some detail is hidden in platform switches not in the diff.
We still have the giant table for unit testing. Do we need any touch on the cmake script to govern the creation of the table according to whether testing is enabled?

Happy New Year! Yes, sorry, bad wording: this is entirely a cross-platform / architecture change, just removing 1.3MB of binary tables. I mentioned avx2 / f16c only to indicate that is where the performance numbers I might quote are indicative of (my older core i9-9900k). I have not yet been able to test on newer / alternate hardware, but expect there to be a good boost for all systems with increasingly disparate memory speed vs. instruction execution. This is could be viewed as a step towards enabling a gpu version of this, or easier implementation in an embedded system, as examples, not that I have explicit plans to do any of that.
This is not fully branchless unfortunately, as I could not work out the math yet to reason about the error tolerance being full 32-bit float precision, but wanting to quantize a 16-bit float. This code replicates the results precisely for the allowed range of quantization levels (0-100) for DWAA/B. However, if we were to change the error tolerance to be to a half float value, we could greatly simplify the code (faster still) and I believe have it be fully deterministic and mostly branchless (the odd check for inf / nan).
But I didn't want to change the output values just yet...

We still have the giant table for unit testing. Do we need any touch on the cmake script to govern the creation of the table according to whether testing is enabled?

AFAIK, we long ago removed rules to create these files, only leaving the code which did so as reference, which I have not changed....


h2-2.1.214.jar: CVE-2022-45868(7.8) and logback-core-1.2.11.jar: CVE-2023-6378(7.5) not found

Hi Team, We are using Dependency-Check Core version 9.1.0 in our pipelines to scan our applications which is developed using .Net with azure technologies. When we run our pipelines we see scan result below
One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
h2-2.1.214.jar: CVE-2022-45868(7.8)
logback-core-1.2.11.jar: CVE-2023-6378(7.5)
See the dependency-check report for more details.
Dependency Check completed with exit code 15.
Dependency Check reports:
[
'/home/vsts/work/_temp/dependency-scan-results/dependency-check-junit.xml',
'/home/vsts/work/_temp/dependency-scan-results/dependency-check-report.html',
'/home/vsts/work/_temp/dependency-scan-results/dependency-check-report.json'
]
However we didn't use the following .jars anywhere in our applications. Since our applications are built on .Net and Azure. I have scanned the directories and attached logs file.
logs.txt
Can you please assist us how to resolve ?

Check which part of the filesystem you are actually scanning and the args to the dependency check CLI.
Perhaps your pipeline workers also run jobs for Android builds, and thus you are finding issues within Gradle installations (which are shown in your log).
In particular your log shows
2024-04-09T09:05:48.7271383Z Searching in the entire directory structure starting from: /

... i.e it is scanning the role root filesystem for your worker. If that is what your pipeline is doing, you are scanning much more than an individual project, and you will be scanning tools pre-installed on your workers, which may include Gradle and Java tools.
The dependency check reports will show you the affected files and which path those files are in the filesystem.

Hi @chadlwilson  Thanks for the response. Surprisingly without doing any changes/updated from our side We don't see this issue anymore from our pipelines.
FYI... I have tested the my pipeline in following below
echo "Searching in directory of the: ${{ BuildDirectory }}"
find ${{ BuildDirectory }} -name ".jar" -  No .jars for this case
echo "Searching in directory one level above: $(dirname ${{ BuildDirectory }})"
find $(dirname ${{ BuildDirectory }}) -name ".jar" - -  No .jars for this case
echo "Searching in the entire directory structure starting from: /"
find / -name "*.jar" - -  For this case we have seen the attached logs
This case path would be /usr/share/ **(shared path)

If you are using persistent agents for your build/pipeline system it may be that other builds are installing such dependencies and if you are scanning the entire build agent/workers's filesystem, then you may see them. In any case, if you're doing scans for an individual build you should only be scanning their "workspace"/area, not the entire file system, or the working areas of other builds, and may want to check you're actually only scanning the appropriate location.

Hi @chadlwilson well, we have different agents for our builds however for OWASP task we are using Microsoft hosted agent.


feat: Use Vite with SWC

Use Vite with SWC for React templates.
I have not tested any mobile builds using the plugin.
Documentation for the plugin is available here.

I am not a react dev and I am not sure if swc is the default option now in the react community but vite is still not including swc in their default react templates and we should stay in sync with them as our templates is mostly based on the vite ones.

I agree, best to keep with vites current template.
Hopefully revisit in the future 🚀


Short solution needed: "Delete query with PHP PDO" (php-pdo)

Please help us write most modern and shortest code solution for this issue:
Delete query with PHP PDO (technology: php-pdo)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Delete query example with PHP PDO


Support vsock on Android as well as Linux.

This change depends on rust-lang/libc#1905 so can't be merged until that is merged and released.

The libc change has now been merged and released, please review.

The CI failure looks unrelated to my change as far as I can tell, is there some way to rerun it?

I think that failure is due to a bug in glibc.  I restarted it.  But note this warning, that is probably related to your PR:
use of deprecated item 'nix::libc::VMADDR_CID_RESERVED': VMADDR_CID_RESERVED is removed since Linux v5.6 and replaced with VMADDR_CID_LOCAL

Ah, that might be because of the libc version upgrade. Fixed now.

Looks good.  Now please squash your commits.

Also, looks like you'll need to rebase.

Thanks, rebased and squashed.


INSTA-17654 Split tokens and cost into input and output values

Introduce new metrics for LLM input and output tokens and cost.

@LakshmiPriyaSujith I think we need a new release of otel-dc-llm after we finish the application based metrics tracking like https://github.com/instana/otel-dc/releases


My C++11 fork

I put some effort into integrating C++11 language features, unifying codepaths, realizing the unit tests using the boost unit test framework and refactoring some internals over here... what is your opinion about these changes?
In addition to that I started writing new API docs using mkdocs and doxygen, but got carried away by my studies. If you want I will share the current state with you.
Best wishes,
Henrik Gaßmann

Please do not use C++11 only features. It should be usable with C++98. If you have some config that makes it usable with both, ok. But please do not break C++98 support

Thanks for the comment. I have no intention of introducing C++11/14/17 into the code base. It should work with a reasonably compliant C++ 98 compiler.


Property 'collate' does not exist on type 'ColumnBuilder'

Environment
Knex version:  0.95.6
Database + version: mysql 2.18.1
OS: Linux
Bug
Hello,
Typescript says that the 'collate' property is not exposed by the Column builder class. While the documentation suggests the opposite: https://knexjs.org/#Schema-collate .
Here the issue on VSCode:

I am working on solving this but a few questions come to mind:
Is it better to have a specific type informing the supported collates like :
export type CollationType =
'armscii8_general_ci'|'ascii_general_ci'|
'big5_chinese_ci'|'binary'| 'cp1250_general_ci'|
'cp1251_general_ci'|'cp1256_general_ci'|
'cp1257_general_ci'|'cp850_general_ci'|
'cp852_general_ci'|'cp866_general_ci'|
'cp932_japanese_ci'|'dec8_swedish_ci'|
'eucjpms_japanese_ci'|'euckr_korean_ci'|
'gb18030_chinese_ci'|'gb2312_chinese_ci'|
'gbk_chinese_ci'|'geostd8_general_ci'|
'greek_general_ci'|'hebrew_general_ci'|
'hp8_english_ci'|'keybcs2_general_ci'|
'koi8r_general_ci'|'koi8u_general_ci'|
'latin1_swedish_ci'|'latin2_general_ci'|
'latin5_turkish_ci'|'latin7_general_ci'|
'macce_general_ci'|'macroman_general_ci'|
'sjis_japanese_ci'|'swe7_swedish_ci'|
'tis620_thai_ci'|'ucs2_general_ci'|
'ujis_japanese_ci'|'utf16_general_ci'|
'utf16le_general_ci'|'utf32_general_ci'|
'utf8_general_ci'|'utf8mb4_0900_ai_ci'|'utf8_unicode_ci';

And then :
collate(collation : CollationType);

in ColumBuilder interface ?
Or just :
collate(collation : string);

in ColumBuilder interface ?

@LeopoldBriand as say ion MySql documentation, user can define collation so collate(collation : string); can be enough and accept user defined collations.

At this moment, the ColumnBuilder interface doesn't have collate method at all

Hello @piotr-cz, I haven't been thinking about this for a long time, but the problem was that collate was one of the possible modifiers and that it was not in the typescript interface. Modifiers list is available here .
I have never done a PR for this but it is never too late. Maybe we should include other missing types if there are. I'll have a look around.


Pass stats in Segment event properties

Description
https://segment.com/docs/connections/sources/catalog/libraries/server/node/#track
Type of change

[x] Bug fix
[ ] New feature
[ ] Breaking change

Good find @thomas-gerber


Look Inside by 4 Hero unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

Artist should be 4hero to get lyrics instead of 4 hero


Fix static setup location

Resolves #11 by using sys.prefix in setup.py, faucet.py, and gauge.py if it detects that Faucet is being installed or run in a virtual envrionment. Any other case keeps the default locations.
Tests were performed in two scenarios: Global installation (currently working and documented method) and installation within a virtual environment created by virtualenv.

Global Install

New Ubuntu 16.04 VM created with prereqs required by Faucet installed globally

Required manually installing pip 8.1.2 as ryu 4.5 dependencies fail to install with the default pip 8.1.1 provided by Ubuntu 16.04 (you can see this fail when you build the Faucet Docker.tests container, but ryu is already installed so the test still passes).

Faucet installed by using sudo pip install <faucet_location>

Confirmed configuration files placed in /etc/ryu/faucet both before and after changes

Replaced default config with simple config for testing with Mininet
Confirmed Faucet working by running sudo ryu-manager $faucet_prefix/ryu_faucet/org/onfsdn/faucet/faucet.py where faucet_prefix=$(pip show ryu-faucet | grep ^Location: | awk -e '{print $2}')
Ran sudo mn --test pingpair --mac --controller remote,<ip>:6633. Mininet was run in a different VM.

Virtual Environment Install

New Ubuntu 16.04 VM created with prereqs required by Python and virtualenv only

Used standard system pip 8.1.1 as virtualenv automatically installs the latest pip in the created virtual environment.

New virtual environment created using virtualenv ~/faucet-dev/venv as an unprivileged user
Copied Faucet to ~/faucet-dev/faucet
Faucet installed by using pip install ~/faucet-dev/faucet inside the activated virtual environment

Current master fails as it tries to write to /etc/ryu/faucet as an unprivileged user
These changes cause install to pass with default config placed in ~/faucet-dev/venv/etc/ryu/faucet/

Confirmed Faucet working by running ryu-manager ~/faucet-dev/faucet/ryu_faucet/org/onfsdn/faucet/faucet.py in the activated virtual environment as an unprivileged user. (after changes only)
Ran sudo mn --test pingpair --mac --controller remote,<ip>:6633. Again, Mininet was run in a different VM. (after changes only)

The full test suite is available at https://github.com/inside-openflow/faucet-vagrant-tests which I put together to test Faucet installations in different environments. It tested more than I described here.
The only thing I'm unsure about are the changes to the documentation. Also, this is my first pull-request I filed on github. Feedback is appreciated.

Hi Leo,
Thanks once again for doing this.
Our Pull request requires that tests be passing -
https://github.com/onfsdn/faucet#testing  Can you please make sure you can
run the same?
Thanks & Regards
/Shivaram
On Fri, Aug 19, 2016 at 4:27 PM, Leo Scott<EMAIL_ADDRESS>wrote:

Resolves #11 https://github.com/onfsdn/faucet/issues/11 by using
sys.prefix in setup.py, faucet.py, and gauge.py if it detects that Faucet
is being installed or run in a virtual envrionment. Any other case keeps
the default locations.
Tests were performed in two scenarios: Global installation (currently
working and documented method) and installation within a virtual
environment created by virtualenv.

Global Install

New Ubuntu 16.04 VM created with prereqs required by Faucet
installed globally

Required manually installing pip 8.1.2 as ryu 4.5 dependencies
fail to install with the default pip 8.1.1 provided by Ubuntu 16.04 (you
can see this fail when you build the Faucet Docker.tests container, but ryu
is already installed so the test still passes).

Faucet installed by using sudo pip install <faucet_location>

Confirmed configuration files placed in /etc/ryu/faucet both
before and after changes

Replaced default config with simple config for testing with
Mininet
Confirmed Faucet working by running sudo ryu-manager
$faucet_prefix/ryu_faucet/org/onfsdn/faucet/faucet.py where faucet_prefix=$(pip
show ryu-faucet | grep ^Location: | awk -e '{print $2}')
Ran sudo mn --test pingpair --mac --controller remote,:6633.
Mininet was run in a different VM.

Virtual Environment Install

New Ubuntu 16.04 VM created with prereqs required by Python and
virtualenv only

Used standard system pip 8.1.1 as virtualenv automatically
installs the latest pip in the created virtual environment.

New virtual environment created using virtualenv ~/faucet-dev/venv
as an unprivileged user
Copied Faucet to ~/faucet-dev/faucet
Faucet installed by using pip install ~/faucet-dev/faucet inside
the activated virtual environment

Current master fails as it tries to write to /etc/ryu/faucet
as an unprivileged user
These changes cause install to pass with default config placed
in ~/faucet-dev/venv/etc/ryu/faucet/

Confirmed Faucet working by running ryu-manager
~/faucet-dev/faucet/ryu_faucet/org/onfsdn/faucet/faucet.py in the
activated virtual environment as an unprivileged user. (after changes only)
Ran sudo mn --test pingpair --mac --controller remote,:6633.
Again, Mininet was run in a different VM. (after changes only)

The full test suite is available at https://github.com/inside-
openflow/faucet-vagrant-tests which I put together to test Faucet
installations in different environments. It tested more than I described
here.
The only thing I'm unsure about are the changes to the documentation.
Also, this is my first pull-request I filed on github. Feedback is
appreciated.
You can view, comment on, or merge this pull request online at:
https://github.com/onfsdn/faucet/pull/12
Commit Summary

Support virtualenv and pyvenv paths for log and config default
locations
Remove leading slash in data_files only if in venv

File Changes

M README.rst
https://github.com/onfsdn/faucet/pull/12/files#diff-0 (2)
M setup.py https://github.com/onfsdn/faucet/pull/12/files#diff-1
(12)
M src/ryu_faucet/org/onfsdn/faucet/faucet.py
https://github.com/onfsdn/faucet/pull/12/files#diff-2 (11)
M src/ryu_faucet/org/onfsdn/faucet/gauge.py
https://github.com/onfsdn/faucet/pull/12/files#diff-3 (12)
M src/ryu_faucet/org/onfsdn/faucet/util.py
https://github.com/onfsdn/faucet/pull/12/files#diff-4 (17)

Patch Links:

https://github.com/onfsdn/faucet/pull/12.patch
https://github.com/onfsdn/faucet/pull/12.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/onfsdn/faucet/pull/12, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmf8_nyeJIgrLEFLEYYObXSM4dBrogUks5qhjvcgaJpZM4Jo7mx
.

One other thing - can you please update README.rst -
https://github.com/onfsdn/faucet#installation Installation section and add
a sub-section for installing the same in a virtual env?  This will greatly
help a user who is trying to do this.
Thanks & Regards
/Shivaram
On Fri, Aug 19, 2016 at 10:13 PM, Shivaram Mysore<EMAIL_ADDRESS>
wrote:

Hi Leo,
Thanks once again for doing this.
Our Pull request requires that tests be passing -
https://github.com/onfsdn/faucet#testing  Can you please make sure you
can run the same?
Thanks & Regards
/Shivaram
On Fri, Aug 19, 2016 at 4:27 PM, Leo Scott<EMAIL_ADDRESS>wrote:

Resolves #11 https://github.com/onfsdn/faucet/issues/11 by using
sys.prefix in setup.py, faucet.py, and gauge.py if it detects that
Faucet is being installed or run in a virtual envrionment. Any other case
keeps the default locations.
Tests were performed in two scenarios: Global installation (currently
working and documented method) and installation within a virtual
environment created by virtualenv.

Global Install

New Ubuntu 16.04 VM created with prereqs required by Faucet
installed globally

Required manually installing pip 8.1.2 as ryu 4.5
dependencies fail to install with the default pip 8.1.1 provided by Ubuntu
16.04 (you can see this fail when you build the Faucet Docker.tests
container, but ryu is already installed so the test still passes).

Faucet installed by using sudo pip install <faucet_location>

Confirmed configuration files placed in /etc/ryu/faucet both
before and after changes

Replaced default config with simple config for testing with
Mininet
Confirmed Faucet working by running sudo ryu-manager
$faucet_prefix/ryu_faucet/org/onfsdn/faucet/faucet.py where faucet_prefix=$(pip
show ryu-faucet | grep ^Location: | awk -e '{print $2}')
Ran sudo mn --test pingpair --mac --controller remote,:6633.
Mininet was run in a different VM.

Virtual Environment Install

New Ubuntu 16.04 VM created with prereqs required by Python and
virtualenv only

Used standard system pip 8.1.1 as virtualenv automatically
installs the latest pip in the created virtual environment.

New virtual environment created using virtualenv
~/faucet-dev/venv as an unprivileged user
Copied Faucet to ~/faucet-dev/faucet
Faucet installed by using pip install ~/faucet-dev/faucet inside
the activated virtual environment

Current master fails as it tries to write to /etc/ryu/faucet
as an unprivileged user
These changes cause install to pass with default config
placed in ~/faucet-dev/venv/etc/ryu/faucet/

Confirmed Faucet working by running ryu-manager
~/faucet-dev/faucet/ryu_faucet/org/onfsdn/faucet/faucet.py in the
activated virtual environment as an unprivileged user. (after changes only)
Ran sudo mn --test pingpair --mac --controller remote,:6633.
Again, Mininet was run in a different VM. (after changes only)

The full test suite is available at https://github.com/inside-open
flow/faucet-vagrant-tests which I put together to test Faucet
installations in different environments. It tested more than I described
here.
The only thing I'm unsure about are the changes to the documentation.
Also, this is my first pull-request I filed on github. Feedback is
appreciated.
You can view, comment on, or merge this pull request online at:
https://github.com/onfsdn/faucet/pull/12
Commit Summary

Support virtualenv and pyvenv paths for log and config default
locations
Remove leading slash in data_files only if in venv

File Changes

M README.rst
https://github.com/onfsdn/faucet/pull/12/files#diff-0 (2)
M setup.py https://github.com/onfsdn/faucet/pull/12/files#diff-1
(12)
M src/ryu_faucet/org/onfsdn/faucet/faucet.py
https://github.com/onfsdn/faucet/pull/12/files#diff-2 (11)
M src/ryu_faucet/org/onfsdn/faucet/gauge.py
https://github.com/onfsdn/faucet/pull/12/files#diff-3 (12)
M src/ryu_faucet/org/onfsdn/faucet/util.py
https://github.com/onfsdn/faucet/pull/12/files#diff-4 (17)

Patch Links:

https://github.com/onfsdn/faucet/pull/12.patch
https://github.com/onfsdn/faucet/pull/12.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/onfsdn/faucet/pull/12, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmf8_nyeJIgrLEFLEYYObXSM4dBrogUks5qhjvcgaJpZM4Jo7mx
.

Sorry I forgot to mention that my test suite build and runs the Docker.tests container, which specifically runs the test mentioned in the readme. This was the first test case I added to that suite. See https://github.com/inside-openflow/faucet-vagrant-tests/blob/master/scripts/build-docker-test.sh and https://github.com/inside-openflow/faucet-vagrant-tests/blob/master/scripts/run-docker-test.sh. The test passed both before and after the changes.
lf it needs to pass outside of docker, please see my current issue at #10. If someone could provide me with a known working guest configuration, I can test that.
I'll update the documentation as suggested when I am back at a computer. I do hope it helps :)

I'll submit another pull request in the future with documentation on setting up with a virtual environment. I'm currently writing an article on that subject.

I should also mention that the PR included two commits. The first one removed the first slash in all cases, the second one put it back except if it could tell if it was in a venv.


Testing with vaul drawer

Hey, I just want to propose a section in README.md explaining on how to test components that use the drawer.
I had an issue testing one of my components where jest/testing-library would error out because JSOM does not have a shim of visualViewport and HTMLElement.prototype.setPointerCapture.
I have added the following to a setup-after-env.js file and now tests work!
/**
 * JSDOM doesn't support visualViewport, so we need to mock it globally.
 */
global.visualViewport = {
  addEventListener: jest.fn(),
  removeEventListener: jest.fn(),
  height: 800, // Any height you would like
  width: 400, // Any width you would like
}

/**
 * JSDOM doesn't support HTMLElement.prototype.setPointerCapture, so we need to mock it globally.
 */
global.HTMLElement.prototype.setPointerCapture = jest.fn()

Probably not the best implementation, but it works well enough.

Thank you, I'm planning on adding a section on testing in docs soon!


How to get fail reason for a mail?

I need to understand the failure reason and not just what email addresses that failed.
Couldn't find any info how so I'm using this hack:
In file: swiftmailer/lib/classes/Swift/Transport/AbstractSmtpTransport.php:422
Uncomment a line and add as below:
// $failedRecipients[] = $forwardPath;
$failedRecipients[] = ['email' => $forwardPath, 'code' => $e->getCode(), 'message' => $e->getMessage()];

Now when sending a mail:
$mailer->send($message, $failures);

The variable $failure will contain more info than just the email. Even though it solves my problem temporarily, it's not a good solution. I would really like to see a better way to get that failure info .

$mailer->send() throws Swift_TransportException or Swift_RfcComplianceException when the message fails to send for either reason.
In the catch($e) {...} block you can use $e->getMessage() to get the error message.

$mailer->send() throws Swift_TransportException or Swift_RfcComplianceException when the message fails to send for either reason.

No it does not. It just provides a list of addresses that failed.
Exceptions are swallowed silently in \Swift_Transport_AbstractSmtpTransport::_doMailTransaction()


Features translation

Dear friend
I have to ask questions:

Is it possible to translate the features values and scores to the classes as output json?
Is it possible to catch these features at or with timestamps?

Please guide and help if this is possible.

Hi!
I have implemented neither 1 nor 2 but I believe it should be quite straightforward to add these features to the code now.
Especially for 1, do you mean that you want the classifier label scores? if yes you can change the backbone and use one which outputs scores instead of features.
For 2: Because the features are densely extracted at a fixed fps, it should be also easy to get the timestamp for each feature.


Table font size bug when changing paging

Using chrome on my android mobile again.
I'm on the docs site, looking at table component.
I changed the page size to 10 and new rows appeared as expected. However some of the text of the new rows used a larger font size for no discernable reason. See screenshot:

Can not reproduce on my Android Phone.

I can no longer repro this either. Very odd. I'll close and reopen if I come across it again in future.


Duplicated path on windows 10

Hi, I have issue with generated snapshots!
I have next configuration:
Structure:
root/
    - cypress/
        - e2e/
            - auth/
                - auth.spec.cy.ts
            - search/
                - search.spec.cy.ts
        - fixtures/
              ...
        - snapshots/
        - support/
              ...
              - commands.ts
        - cypress.config.ts

cypress.config.ts:
import { defineConfig } from 'cypress';
import { addMatchImageSnapshotPlugin } from '@simonsmith/cypress-image-snapshot/plugin';

export default defineConfig({
    e2e: {
        baseUrl: 'http://localhost:4200',
        setupNodeEvents(on) {
            addMatchImageSnapshotPlugin(on);
        },
    },
    component: {
        devServer: {
            framework: 'angular',
            bundler: 'webpack',
        },
        specPattern: '**/*.cy.ts',
    },
});

commands.ts:
import { addMatchImageSnapshotCommand } from '@simonsmith/cypress-image-snapshot/command';

addMatchImageSnapshotCommand({
    failureThreshold: 0.00001,
    failureThresholdType: 'percent',
    customDiffConfig: { threshold: 0.00001 }, // Adjust as needed
    capture: 'viewport',
});

Each test file has a call snapshot match command.
Results:
On MacOs, Ubuntu - snapshots created with expected structure:
snapshots/
    - auth/
         - auth.spec.cy.ts/
             - Auth.snap.png
    - search/
         - search.spec.cy.ts/
              - Search.snap.png

On my Windows 10 machine:
Run mode::
snapshots/
    - cypress
        - e2e
            - auth/
                - auth.spec.cy.ts/
                    - auth/
                        - auth.spec.cy.ts/
                            - Auth.snap.png
             ...

Watch mode:
snapshots/
    - cypress
        - e2e
            - auth/
                - auth.spec.cy.ts/
                     - Auth.snap.png
             ...

Following this recomendation https://github.com/simonsmith/cypress-image-snapshot#snapshot-paths I was configured command like this:
addMatchImageSnapshotCommand({
  ...
  e2eSpecDir: 'cypress/e2e/'
})

But it does not help.
After some investigation, we found that windows incorrectly handle slashes in path.
So after updating command configuration like this:
const isWindows = Cypress.platform === 'win32';
addMatchImageSnapshotCommand({
    failureThreshold: 0.00001,
    failureThresholdType: 'percent',
    customDiffConfig: { threshold: 0.00001 }, // Adjust as needed
    capture: 'viewport',
    e2eSpecDir: isWindows ? 'cypress\\e2e\\' : 'cypress/e2e/',
});

Two levels of snapshots folder structure is gone:    cypress and e2e.
But is still has duplicated folders in run mode.
After some more deep investigation and debuging, I figured out that, in runImageDiffAfterScreenshot function replacement of specName not working. So this:
const dirName = path.dirname(
    screenshotConfig.path
      // remove the screenshots path and just leave folders to be created in
      // the snapshots folder
      .replace(screenshotConfig.specName, '')
      // remove specName here because in run mode it's added and duplicated.
      // In open mode it's an empty string so is ignored
      .replace(screenshotsFolder, ''),
  )

Should be updated with this:
const dirName = path.dirname(
    screenshotConfig.path
      // remove the screenshots path and just leave folders to be created in
      // the snapshots folder
      .replace(path.normalize(screenshotConfig.specName), '')    <--------  changes here
      // remove specName here because in run mode it's added and duplicated.
      // In open mode it's an empty string so is ignored
      .replace(screenshotsFolder, ''),
  )

Only after that everything working as expected on my window machine.

Hey,
Thanks for the detailed report! Do you want to open a pull request for this change? It looks good to me.
I don't have a windows machine to test on

Sure, I will do that)

:tada: This issue has been resolved in version 8.1.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


K8SPG-303 add users test

CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Add users test
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are the manifests (crd/bundle) regenerated if needed?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PG version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

We run 7 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/3aacd93dc200d8881571752742dc5a1fa2c3861b
image: perconalab/percona-postgresql-operator:PR-451-3aacd93dc

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

We run 7 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/7cbba32849edd44bd3dc3bd619f45a6f0bdd9050
image: perconalab/percona-postgresql-operator:PR-451-7cbba3284

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

users
failed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/fe591ab621020dbd87d57745ee9b66e21136b6ca
image: perconalab/percona-postgresql-operator:PR-451-fe591ab62

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

users
failed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/fe591ab621020dbd87d57745ee9b66e21136b6ca
image: perconalab/percona-postgresql-operator:PR-451-fe591ab62

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

users
passed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/fe591ab621020dbd87d57745ee9b66e21136b6ca
image: perconalab/percona-postgresql-operator:PR-451-fe591ab62

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
failed

monitoring
passed

telemetry-transfer
passed

users
passed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/fe591ab621020dbd87d57745ee9b66e21136b6ca
image: perconalab/percona-postgresql-operator:PR-451-fe591ab62

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
passed

monitoring
passed

telemetry-transfer
passed

users
failed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/bc7a445bb7d2b2346c56afb4ae61ee409131d9d6
image: perconalab/percona-postgresql-operator:PR-451-bc7a445bb

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
passed

monitoring
passed

telemetry-transfer
passed

users
failed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/32bd532f903d269ccdb36d71fc60b3c28f12dd22
image: perconalab/percona-postgresql-operator:PR-451-32bd532f9

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
passed

monitoring
passed

telemetry-transfer
passed

users
failed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/32bd532f903d269ccdb36d71fc60b3c28f12dd22
image: perconalab/percona-postgresql-operator:PR-451-32bd532f9

Test name
Status

init-deploy
passed

demand-backup
passed

scaling
passed

scheduled-backup
passed

start-from-backup
passed

monitoring
passed

telemetry-transfer
passed

users
passed

We run 8 out of 8

commit: https://github.com/percona/percona-postgresql-operator/pull/451/commits/32bd532f903d269ccdb36d71fc60b3c28f12dd22
image: perconalab/percona-postgresql-operator:PR-451-32bd532f9


[FEATURE REQUEST] LoRA info for LoRA Stacker

LoRA Stacker of the Efficiency nodes repo is able to select/load x amount of loras and it would be very useful if the LoRA info function would support the node. The node looks like this.

Thanks in advance!

So this is a feature request for an completely different node pack lol

You can use this
LoraLoader.lora_name,LoraLoader|pysssss,LoraLoaderModelOnly.lora_name,LoRA Stacker.lora_name.*
In the setting called 🐍 Model Info - Lora Nodes/Widgets
This should add support for the stacker, and you can add support for other nodes in the same manner.


Simplify floats in constants.py

Simplify floats in constants.py

This also changes the dtype of the constants from float to int which is maybe not desired
type(5) == int
type(5.) == float

This also changes the dtype of the constants from float to int which is maybe not desired
type(5) == int
type(5.) == float

That's true, but I guess the writing of the floats as 5. comes from the python2 when 2/3 equaled 0. In python3 it is not really necessary to write floats as2/3 equals now 0.6666... .
Furthermore I could not find any import of any constant in the scipy.constants module except phi which is used in the _rotation_group module. So there should not be any harm except any user imported manually a constant and checked its type.

So there should not be any harm except any user imported manually a constant and checked its type.

There's also the possibility of changing some array to an integer type and causing overflow somewhere. There's only small chances of this happening, but with 10M users someone is likely to run into this. They're also unnecessary changes, so no need to take small chances. I'm fine with the temperature related ones (those stay floats), but can you please revert the others?

Merged, thanks @jakobjakobson13


access violation while building D3D12nBodyGravity

i am trying to build and run the D3D12nBodyGravity sample program and getting "access violation error" at the line specified in the image file attached.
I am having the same error pop up in all directx programs.
i updated my windows 10 home version and before that there was no error like this. I can say that because i ran the sample programs in the book "game programming with directx 12" and they run without problems but now even those programs are having this error.

The crash is happening the driver, so you should look at updating that. If the samples "ran before and stopped working lately", then that definitely points to a driver issue.


Improve archives endpoint logic (and automatic-archives logic) to improve performance.

Currently, cache_url.py determines the last time a URL has been archived by checking information about the URL in the internet archive, a time-consuming request.
This is despite the fact that we have a last_cached column in the data_sources table, which the cache_url.py script updates after sending an archive request.
Additionally, the cache_url.py logic determines if a URL should be updated again by performing a script-side calculation to determine if enough time has passed since the last time a URL was archived to archived it again. And it performs this operation every time the URL is retrieved. So if a URL is set to be updated only annually, and the archives script operates every day, it will check that URL script-side 364 times before it gets to the point where it actually has to re-archive it.
Instead of doing that, simply have the re-archive date be calculated at the time of archive, and put that in the database. Then, modify the archive retrieval script to retrieve only those data sources whose re-archive date is before the current datetime. This way, we only have to perform script-side operations on those URLs which we know need to be re-archived, rather than re-examining URLs that have already been archived recently.
To make things more clear on the database side, maybe make an archived_data_sources table that links one-to-one with the data_sources table, which the archive-relevant data can be stored in.

A relevant endpoint has been migrated to v2: https://github.com/Police-Data-Accessibility-Project/data-sources-app-v2/pull/96


Allow encoded forward slashes

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3933
What does this Pull Request do?
Change configuration to allow encoded forward slashes (%2F) in the path since Shiro 1.13
How should this be tested?
There is a test in fcrepo-webapp and this does seem to appear only with Tomcat.
Build the WAR before this PR and deploy it to Tomcat.
Perform a PUT with an encoded slash
curl -ufedoraAdmin:fedoraAdmin  -XPUT -d" @prefix dc: <http://purl.org/dc/elements/1.1/> . <> dc:title 'Some object' ." -H"Content-type: text/turtle" "http://localhost:8080/fcrepo/rest/admin_set%2Fdefault" -i

See a 400 Bad Request
Build with this PR, and try again. Get a 201 Created or 204 No Content (depending on if it exists already).
Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers

It appears that the snapshot of fcrepo-storage-ocfl 6.4.0-SNAPSHOT has not been deployed lately. I can't seem to deploy the snapshot so I am not sure what we should do here.

Actually it does appear that fcrepo-storage-ocfl was deployed recently, maybe I have a mistake.


[BUG] Unable to add CupertinoSwipe(CupertinoLabel) to CupertinoScrollview

Description
I am trying to add a bunch of CupertinoSwipe(CupertinoLabel)'s to CupertinoScrollview and it fails to render.
Expected Behavior
Scrollview of Labels with Swipe function.
Example
        for _ in range(20):
            swipe = CupertinoSwipe()
            btn = CupertinoLabel(
                text='Test %s' % _,
                size_hint=(0.5, 0.5),
                pos_hint={"center": (0.5, 0.5)}
            )
            swipe_action = CupertinoSwipeAction()
            swipe.add_widget(swipe_action)
            swipe.add_widget(btn)
            layout.add_widget(btn)
        scroll_view = CupertinoScrollView(
            size_hint=(1, 1),
        )
        scroll_view.add_widget(layout)

Environment
MacOS 12.6 M1
Python 3.9.3
Kivy 2.2.0.dev0
kivy-cupertino cloned from GitHub(Sept 24, 2022)
Additional Information
Thank you all for all your work. This project is amazing.

What is layout and why is btn being added to both swipe and layout?

I apologize that was a typo.
        layout = GridLayout(cols=1)         for _ in range(20):             swipe = CupertinoSwipe()             btn = CupertinoLabel(                 text='Test %s' % _,                 size_hint=(0.5, 0.5),                 pos_hint={"center": (0.5, 0.5)}             )             swipe_action = CupertinoSwipeAction()             swipe.add_widget(swipe_action)             swipe.add_widget(btn)             layout.add_widget(swipe)         scroll_view = CupertinoScrollView(             size_hint=(1, 1),         )         scroll_view.add_widget(layout)

Adding a CupertinoTableCell to swipe and adding the label to that cell should solve your issue. Make sure to set the size_hint_y of layout and swipe to None  and manually set the height of swipe.  Also make sure to include layout.bind(minimum_height=layout.setter('height')) so the ScrollView works

Got it working! Thank you!
```
layout = CupertinoTableGroup(size_hint_y=None)
    layout.bind(minimum_height=layout.setter('height'))
    for _ in range(20):
        btn = CupertinoLabel(text='test')
        clickable_table = CupertinoClickableTableCell()
        swipe = CupertinoSwipe(size_hint_y=None)
        swipe_action = CupertinoSwipeAction(side = 'left')

        clickable_table.add_widget(btn)
        swipe.add_widget(swipe_action)
        swipe.add_widget(clickable_table)
        layout.add_widget(swipe)

    scroll_view = CupertinoScrollView(
        size_hint=(1, 1),
    )
    scroll_view.add_widget(layout)


jQuery category like button doesn't work as expected

On Django 2.2 this doesn't work as expected:
“Don’t forget to add in the URL mapping, into rango/urls.py. Update the urlpatterns by adding in:
path('like$', views.like_category, name='like_category'),”
I read the docs and tried this:
re_path(r'^like/$', views.like_category, name="like_category"),
and it kind of works, but after the first like, every time I refresh once liked category, refresh automatically adds +1 to the number of likes.
In the console it's visible that opening/refreshing the category is requesting 'like_category' view at the same time:
[12/Jul/2019 19:39:02] "GET /rango/like/?category_id=5 HTTP/1.1" 200 2
[12/Jul/2019 19:39:02] "GET /rango/category/python/ HTTP/1.1" 200 6311

Hi Piotr,
Sounds strange. However, this is over the old version -- I fixed several things that were outstanding and it looks like this is one of them. The code above is a hangover from Django 1.9/1.10/1.11, where it uses regex to map patterns. So you are technically correct in trying re_path() to fix this issue.
However, I've updated the book since you reported this to use the following:
path('like_category/', views.LikeCategoryView.as_view(), name='like_category'),
Instructions have been updated to reflect this change in URL/name.
Not sure I can replicate the behaviour regarding multiple likes coming down on it when the page is refreshed? That is very strange. Again, code has been revised -- if you want to check our model solution on the new code GitHub, would you agree with what I have put in?
Cheers,
David


tabs shortcode with erlang/elixir as example

It took me a lot of fiddling but I think I've got a usable bulma based tab shortcode added.
Example:
{{<tabs Erlang Elixir>}}

{{<tabsection>}}
{{< highlight erlang >}}
{deps, [{opentelemetry_api, "~> 0.3"}]}
{{< / highlight >}}
{{</tabsection>}}

{{<tabsection>}}
{{< highlight elixir >}}
defp deps() do
  [
    {:opentelemetry_api, "~> 0.3"}
  ]
end
{{< / highlight >}}
{{</tabsection>}}
{{</tabs>}}

@austinlparker can you tell what is going wrong with the checks? I took a look and it is something about a hash..

ok luc's change should fix this, rebase and you'll be g2g


Sorted block and mob subsections under world-settings section

I sorted them out, from A to Z!
If everything is fine, I will sort next subsections tomorrow

Looked over the blocks subsection and everything seems to be in place. Still need to look over all the options under the mob subsection.


unify warnings

What does this PR do?
Reaction on https://github.com/PyTorchLightning/pytorch-lightning-bolts/pull/338#issuecomment-723052607
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @Borda! Thanks for opening this PR.

In the file pl_bolts/utils/warnings.py:

Line 26:8: E111 indentation is not a multiple of four

Do see the Hitchhiker's guide to code style


Create continuous perf tests

Figure out how to find out when we regress perf.

@kalman, should we close this now in favor of more targeted work?

Yes.
(For the record: there is a perf test infrastructure which writes data into noms, and soon to be a graph for viewing the results. It's easy, modulo dealing with Noms APIs, to write another frontend for the perf data which does monitoring).


[Request] Scriptableobject attribute

This thread shows a few attributes related to using scriptableobjects nested in monobehaviours
https://forum.unity.com/threads/editor-tool-better-scriptableobject-inspector-editing.484393/
Consider adding something like this to your package

Guys, what do you think about this?
Should I make an attribute, or make a custom inspector for scriptable objects, so that they can be collapsed/uncollapsed by default?

Implemented in abf930678a848c310d9c927dd11305afef0f5f4d
I decided to make it an attribute for consistency, and because many people are using custom property drawers for scriptable objects.


Feature: API binding for TearDown

Codecov Report

Merging #49 into develop will decrease coverage by 0.1%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
- Coverage    43.81%   43.71%   -0.11%
===========================================
  Files          108      108
  Lines         8923     8944      +21
===========================================
  Hits          3910     3910
- Misses        4907     4928      +21
  Partials       106      106

Impacted Files
Coverage Δ

ogame.go
5.4% <0%> (-0.03%)
:arrow_down:

handlers.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a814bfe...e96ed43. Read the comment docs.


Verifying programs with output

When verifying programs that use output like printf,puts,fprintf, Symbiotic is unable to tell the difference between output from klee and output from the verified program.
To reproduce the problem, verify memcleanup of the following program with --no-slice:
extern int printf(const char *, ...);

int main()
{
    printf("KLEE: ERROR: malicious.c:5: memory error: memory not cleaned up");
    return 0;
}

Fortunately, error replay prevents us from producing incorrect answer, but this prevents Symbiotic from answering correctly. I suggest we somehow ignore calls of these functions in klee.

I see, I know about this problem, but ignoring the calls can introduce other problems. The printf function may not only print output but also set variables ("%n" format), so we cannot entirely ignore it. The best solution would probably be to provide our implementations of such functions.

For KLEE, we can redirect the stdout/stderr during executing the external calls to new file descriptors (opened over /dev/stdnull for instance), so that they do not get mixed with the output of KLEE.

I didn't think of %n, now I agree we can't just get rid of the calls. But I like the solution which redirects output to /dev/null.


Improve code coloring & formatting on IntelliSense info panels

In my example below, the quick info panel (Ctrl + Space (twice)) is greyscale and hard to read. I suggest the following improvements for the IntelliSense panels:

For the quick info panel (these already exist on the mouse hover panel)

add syntax coloring
change word wrapping behavior so words don't get broken up across multiple lines

For both the quick info panel and mouse hover panel (see the PyCharm example showing these 2 features)

apply code autoformatting for newlines and indentation
add inferred type hints for arguments and return values

Was there a decision on this item? Hover is shown by VS code, so we'd only be able to add/remove text (not change colors)

This is probably a dupe. If not, this needs to go to discussions.

formatting updated.  We dont control wordwrapping.. There is an inlay hint setting to see inferred return values.
This issue has been fixed in prerelease version 2023.2.11, which we've just released. You can find the changelog here: CHANGELOG.md

We dont control wordwrapping

Is that an intrinsic limitation of the LSP, or where should I create an issue to address this? Having the function arguments entirely cut off without any line breaks or even a horizontal scrollbar makes using VS Code for Python much harder

This issue has been fixed in prerelease version 2023.2.11

Which part was fixed? In the latest version it seems like the function arguments preview in the Quick Info panel has disappeared completely.

The color coding in the Hover Panel is different but still doesn't differentiate between argument name and type (the new coloring is less readable than what I showed in my original screenshot in my opinion). My suggestion was to take the old Hover Panel styling and apply it to the Quick Info panel.

All the problems in bullet points in my original issue description still seem to exist or have regressed.


Bump Dependencies #11988141252

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/11988141252

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Outdated


Show alert when external route is set while token is not set for model server

Closes #1582
Description

Added the alert as the description in the issue. One thing that needs to be noted is that the regular user with edit permission cannot enable the token, so the alert will show as soon as the user enables the external route.
As the project admin:

As the project user with edit access:

How Has This Been Tested?

Go to the project details page, try to add a model server
In the adding modal, check to enable the external route
Make sure the alert is shown
Check to enable token
Make sure the alert is gone

Test Impact

Added integration test to test all the situations where the alert is visible/hidden.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@vconzola Can you check the UI changes above?

@DaoDaoNoCode Just to be clear, for the project admin (first screenshot) the Require token auth checkbox is auto-selected when the user selects to enable external routes, and the warning is only displayed when the Require token auth checkbox is then unchecked. Is that correct?
For the second use case, project user with edit permissions, looks correct. As soon as the Enable external routes checkbox is checked, then display the warnings.

@DaoDaoNoCode Just to be clear, for the project admin (first screenshot) the Require token auth checkbox is auto-selected when the user selects to enable external routes, and the warning is only displayed when the Require token auth checkbox is then unchecked. Is that correct?

@vconzola Currently it's not, the required token will not be auto-checked together along with the external route checked, if that's the case you are expecting, I could make the change.

@DaoDaoNoCode The video shows the flow as I would expect it. So lgtm.

@DaoDaoNoCode The video shows the flow as I would expect it. So lgtm.

Yes, the message should appear regardless wether the user is admin or not, cause the security risk (non authenticated requests) is there for everyone, so yes, this seems great, I'll take a look later to review it.

/hold
@DaoDaoNoCode the issue is a story -- you'll want to target this to the feature branch

@vconzola Hi, I just noticed that this PR can also solve the issue in #1581, can you check the second screenshot in the description? (As the project user with edit access)

@DaoDaoNoCode I think the changes (warning and popover) look fine. But I do have a couple questions:

Does it ever make sense to have token auth checked when external routes is not checked? If not, then do we need to change the interaction of those two checkboxes so that the state shown can never exist?
When a user with Edit permissions adds a model server, are the Route and Token fields checked by default or unchecked by default? I thought they were unchecked, but I'm not sure. Not sure it matters for this PR; I'm just curious.

@vconzola Good question.

I would like @lucferbux to answer this question because I am not very sure about it
The fields are unchecked by default

Great, then I think no more changes need to be made to this PR and it's ready to get reviewed!


No method for instant order buy and sell

This is more of a feature request. The SDK does not provide buy or sell instant order methods.

this issue can be closed


Add topics from wiki

Move the missing topics from the wiki to the handbook.

@DanielRosenwasser can you take a look

@DanielRosenwasser Ping!

@mhegazy can you change the names to the appropriate markdown file paths as per #114?

:bell:


[DOCS] Open Links in Different Tabs

Description
This is a very small issue but important for better UX for the future. But when I went to Docs > Quickstart - creating your Profile through Forms
It's asking me to Go to "BioDrop Homepage" with the link embedded to the homepage. Ideally it should open on the different tab on clicking the link, so people can come back and continue following the steps written in the docs by simply switching the tab to create a BioDrop link. Opening in the same page means no going back and bad user experience :))
It's a small change but v v v effective for the longer run
Screenshots

Do you want to work on this issue?
None
Additional information
No response

Thanks for raising!

Please assign this issue to me.

I am interested in working on this, can it be assigned to me please?

Can you please assign this issue to me so that i can contribute to
Looking forward to hear from you guys!

@rizahmeds as you were the first to request this once the label changed, I have assigned it to you.

Please assign it to me

We are glad that you want to work on this issue but please look on the assignee section if the issue is already assigned look for another issue to work you can find all these information on our contributing guidelines https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md