Load plugins from

Part of https://github.com/ignitionrobotics/ign-gazebo/issues/265
Desired behavior
From https://github.com/ignitionrobotics/ign-gazebo/issues/265:

Some more pointers for visual plugins that are purely related to rendering:

ign-gazebo should load <visual><plugin>s. As a reference, here's what it took to load <sensor><plugin>s.
Gazebo-classic's visual plugins are loaded by gazebo::rendering on both server and client scenes. I believe an equivalent implementation would have to live in ign-rendering.

Alternatives considered

Implementation suggestion

Additional context

Some extra notes:

ign-rendering doesn't depend on SDFormat. We can either add this dependency, or use plain XML to pass configuration like ign-gui does

Some interesting plugin points would be to provide pre-render and render callbacks

For completeness, I'll just mention that we should provide complete plugin tooling like we do for other libraries, i.e. expose an environment variable with lookup paths for the plugins, etc.

@iche033 and I just discussed this briefly during a meeting. I think he would prefer that this happen in ign-gazebo instead, which is fine with me. The following comment from @chapulina in https://github.com/ignitionrobotics/ign-gazebo/issues/265#issuecomment-665331412 led me to open this issue:

Gazebo-classic's visual plugins are loaded by gazebo::rendering on both server and client scenes. I believe an equivalent implementation would have to live in ign-rendering.

The important thing to me is that visual plugins take effect on both the server and GUI client. I can close this issue in favor of https://github.com/ignitionrobotics/ign-gazebo/issues/265 if this can be accomplished there

this happen in ign-gazebo instead

I'm also ok with that. We already support accessing the rendering API from both server and GUI plugins: https://ignitionrobotics.org/api/gazebo/7.0/rendering_plugins.html. It would be nice to support plugins that are attached to a visual and can be loaded on both the server and client, without the need to create separate ones.

some thoughts on where to implement visual plugins
ign-rendering:

Need to support loading custom plugins
needs to add tinyxml / sdformat dependency for reading plugin params
no access to ECM, no concept of models, links, visuals (almost everything is just a visual or sensor in ign-rendering)
Once plugin support is implemented, should be easier to get them loaded on both server and gui side in ign-gazebo.

ign-gazebo:

need to figure out a way to load plugins on both server and gui.
support reading sdformat params
access to ECM

Currently the main rendering thread are created by either ign-gui's MinimalScene or ign-gazebo's sensors system. Internally ign-rendering does not run a thread or emit render events. One option to do it in ign-rendering would be to emit render events whenever the scene pre / post render occurs, and have visual plugins connect to these events if they want to perform some logic every iteration. While on ign-gazebo, the event system and rendering thread are all set up but we don't have a way to load plugins on both server and gui side.

access to ECM

The way this is handled on the GUI front is that plain ignition::gui::Plugins don't have access to the ECM, and  ignition::gazebo::GuiSystems extend ignition::gui::Plugins providing access to the ECM on top of plan GUI features.

Need to support loading custom plugins

Worth mentioning that ign-rendering already supports one plugin type: rendering engines.

ign-rendering:

Need to support loading custom plugins

this will be a bit of work, but I think ign-plugin handles most of the difficulty

needs to add tinyxml / sdformat dependency for reading plugin params

I believe ign-gui uses tinyxml2 directly to read plugin parameters and doesn't depend on libsdformat, so we could follow that same pattern. Or we could make libsdformat a dependency of a component of ign-rendering but not the core library, like in ign-physics

no access to ECM, no concept of models, links, visuals (almost everything is just a visual or sensor in ign-rendering)

perhaps we can look at some of the existing visual plugins in gazebo11 and irg_open to see if there are any that depend on Model / Link APIs

Once plugin support is implemented, should be easier to get them loaded on both server and gui side in ign-gazebo.

👍

ign-gazebo:

need to figure out a way to load plugins on both server and gui.
support reading sdformat params
access to ECM

Currently the main rendering thread are created by either ign-gui's MinimalScene or ign-gazebo's sensors system. Internally ign-rendering does not run a thread or emit render events. One option to do it in ign-rendering would be to emit render events whenever the scene pre / post render occurs, and have visual plugins connect to these events if they want to perform some logic every iteration. While on ign-gazebo, the event system and rendering thread are all set up but we don't have a way to load plugins on both server and gui side.

it sounds like we don't have any ideas about how to load visual plugins on both server and GUI via ign-gazebo? I consider that a core requirement

we don't have any ideas about how to load visual plugins on both server and GUI via ign-gazebo

I think we won't be able to use the existing plugin base classes on ign-gazebo, System and GuiSystem, because they're tied to either the server or the GUI.
We could create a new ignition::gazebo::rendering::Plugin base class that's loaded (and updated?) by RenderUtil, because RenderUtil is used by both server and GUI to pass information between the ECM and ign-rendering.

One option to do it in ign-rendering would be to emit render events whenever the scene pre / post render occurs, and have visual plugins connect to these events if they want to perform some logic every iteration.

I've been giving this issue some thought, and I think there's a lot of value in taking the ign-rendering plugin route instead. The events idea from @iche033 sounds reasonable to me, and supporting generic ign-rendering plugins means they can be leveraged by applications other than Gazebo.


How to extract mesh geometry from polylines?

How should I create faces and vertices from 3D points list? (dxf.entities -> type = 'POLYLINE')
I have tried this:
function addTriangle(g, p, i1, i2, i3) {
    if(Math.max(i1, i2, i3) > p.length - 1) return;
    let p1 = p[i1];
    let p2 = p[i2];
    let p3 = p[i3];
    g.vertices.push(new THREE.Vector3( p1.x, p1.y, p1.z ))
    g.vertices.push(new THREE.Vector3( p2.x, p2.y, p2.z ))
    g.vertices.push(new THREE.Vector3( p3.x, p3.y, p3.z ))
    g.faces.push(new THREE.Face3(g.vertices.length - 3, g.vertices.length - 2, g.vertices.length - 1))
}

    var g = new THREE.Geometry();

    polylines.map(p => {
        for(let i=0;i<p.length;i+=6) {
            addTriangle(g, p, i, i+1, i+2)
            addTriangle(g, p, i+3, i+1, i)
        }
    })

But several polygons are missed. Moreover, I see a few points with a zero coordinates

I don't think there's enough information to help here, can you provide a stackblitz with a basic sample of the problem?
Here's a simple template, you should add your dxf file and log the things that give you problems.

@Serthys https://stackblitz.com/edit/js-csuc78?file=index.js
You can open downloaded scene.json in the three.js editor

You can open downloaded scene.json in the three.js editor
The scene data on that editor is stored on your browser, I can't see it.
Try creating a scene.json file on the stackblitz project and paste the contents you can download there.

You can load any dxf file

I have added scene.json to project

Ok, I didn't understand you before. I thought you were trying to load the scene file.
The file I need to test what's wrong is the dxf you are parsing, not the result.

roof.dxf being imported in Blender (using the addon DXF import) correctly
https://stackblitz.com/edit/js-csuc78?file=roof.dxf

DXF file connet bu uploaded due to 413 Request Entity Too Large

Upload it on other place like pastebin for example.

DXF is too large (about 3MB)

@Serthys https://ufile.io/817ihu0z

I've checked the dxf source and the zeros are already there, it doesn't look like an error from the parsing.
About how to extract the data and siplay it in threejs, I've never used the 3d features of dxf some I'm kinda lost there. If you manage to do it feel free to submit a pull request on /gdsestimating/three-dxf.


TEI output: handle tail of certain elements

Changes:

I added some code to clean the TEI output and remove tails on <p>, <fw>, <ab> and <lb/>

for <p> elements: if they have a tail, the tail is merged with the text content
for <fw> and <ab>, a new <p> sibling is added and the former tail added as its text
<lb/> that are direct children of <div> are converted to a <p> and the tail is added as text

Background:
Tail on elements like <p> and <fw> usually results in a validation error with TEI P5. The same is true for <lb/> that have <div> as parent.

superseded by #254


Update documentation request

I got tripped up three times getting this setup on premise:

According to the Sentry documentation:

organisation: Required, Sentry organisation to upload files to
project: Required, Sentry project to upload files to

I was continually getting 401s, I didn't realize these were supposed to be the slugs, until reading through the code. Would be helpful to mention that fact.

Mentioning the apiKey is the same as the new Auth Tokens would be nice, since API Keys were previously a completely different thing in Sentry.

baseSentryURL needs to have the suffix /api/0/projects

I've run into the first problem as well. The returned error is quite non-descriptive, and from the documentation it isn't immediately obvious that the 'short name' (as sentry calls it in their ui) needs to be used.


[Feature] Add "batch" logic to gen-matrix script

Is your feature request related to a problem? Please describe.
Currently the gen-matrix script spins out a single instance for each task-id generated. This is too excessive cost wise.
Describe the solution you'd like
Add a new gen-matrix script, or flag that can allow the script to "batch" executions into sub-arrays. This way we can use run-many, similar to the run-many script.
The output should be similar to the current gen-matrix script, except there are nested property arrays.

A limitation I'm not sure how to work around is the fact nx run-many can only handle 1 target at a time, which is how the run-many script works.
Need to brainstorm how to stay within that limitation, and somehow create a script to run all the tasks for a given target. 🤔
One option may be to update the library itself to have a single ci task that then runs all the tasks relevant for that target.
Then create some tooling to verify each project defines that task.


Fixed Azure Disk Encryption prerequisites link.

Corrected the Azure Disk Encryption prerequisites link.

@jabster78 : Thanks for your contribution! The author, @mestew, has been notified to review your proposed change.

@jabster78 thanks for noticing that problem and fixing it!
#sign-off


Does not close after sim exit

I have an issue with this mod, where it does not close automatically after I exit the sim. I have to go to Task Manager and quit the application. I have auto-start with FSUIPC.
Let me know if you need anything in terms of troubleshooting this issue.

But you give it some Time to actually close itself? So it would be still open after let's say 5 Minutes?
What FSUIPC Version are you running? What das the RunIf Line with WorkingTitle2GSX.exe looks like in your FSUIPC7.ini File? (In the Directory you've installed FSUIPC to)
You could post a Log of WorkingTitle2GSX where it happens. (%appdata%\WorkingTitle2GSX\log)

Yes usually it stays open and I have to close it from task manager myself.
My FSUIPC version is 7.4.4
WorkingTitle2GSX20240124.log
FSUIPC auto launch line:
[Programs]
RunIf1=CONNECTED,CLOSE,C:\Users\aidsc\AppData\Roaming\WorkingTitle2GSX\bin\WorkingTitle2GSX.exe

Hmm, going by the Log Messages it seems Flight Simulator itself is still detected as running - else WT2GSX would close itself.
Maybe as a Workaround it would help when you use KILL instead of CLOSE? That can have the Side-Effect that the Icon is still visible in the Systray (because the Binary is killed and can't clean that up).
[Programs]
RunIf1=CONNECTED,KILL,C:\Users\aidsc\AppData\Roaming\WorkingTitle2GSX\bin\WorkingTitle2GSX.exe

Changing it from CLOSE to KILL solved the issue for me, thanks a lot.


Fix audit entry detail encoding

Work around getting ASCII-8BIT for audit entry detail.

Coverage decreased (-1.14%) to 84.37% when pulling 0a1fbb600440650e5a0193dff3ac81fc24f47dd5 on fix_audit_entry_detail_encoding into 8a7376fef684e5d8d6d8c13cfaeb97cd75b5fcf8 on master.

Coverage decreased (-1.14%) to 84.37% when pulling 0a1fbb600440650e5a0193dff3ac81fc24f47dd5 on fix_audit_entry_detail_encoding into 8a7376fef684e5d8d6d8c13cfaeb97cd75b5fcf8 on master.


Binary to apply search patterns to disjunction of configurations

Right now, the llvm backend is capable of search if you don't specify any search pattern. However, it is a nontrivial effort to make a tool to deal with search patterns on the llvm backend because the search patterns are dynamically generated by user input after the semantics has been installed on the machine, but currently the only way to match a pattern in the llvm backend is to compile some code to do it.
Since this step ought not to take very much time, being pure matching with no function evaluation or rewrite steps, I propose that we get the haskell backend to perform this step, similar to how the haskell backend makes use of binaries generated by the llvm backend in order to do unparsing.
What we need is a tool that takes as input:

A disjunction of concrete terms
A search pattern in the same format that the haskell backend normally receives search patterns

And produces as output a disjunction of conjunctions, #Bottom, or #Top, depending on circumstances, where the result is a disjunction of substitutions of the variables in the search pattern, in the same format that the haskell backend normally outputs when performing a search.
This isn't very high priority and isn't blocking anything (in particular it's lower priority than the iele lto packaging issue), but it is required to mark some parts of the k grant as completed.

@dwightguth Do you have any input examples for this tool?


Add pkcs12 password feature into Bundle resource

It is another PR related to #199  . It adds PKCS12 arbitrary password feature into Bundle resource.

No ideas why tide stage get in error.

@arsenalzp I think you need to rebase your work. There are conflicts and changes unrelated to your PR.


Update package.json to cdt-cloud url/homepage

Update with the most up-to-date url the
package.json files in the project.
Probably was forgotten when migrating the
project to eclipse-cdt-cloud in github.
Signed-off-by: Francesco Robino<EMAIL_ADDRESS>

Thanks @frallax for this contribution which LGTM. -With just a few comments:
* Noticed some other occurrences of the legacy url in this repo; @bhufmann, how do you think we should carry those updates forward? We might be missing some in sibling repos, too. Consistency-wise, I mean. And I remember us discussing that update some months ago, but not sure about what we ended up deciding.

If other places need to fixed as well, the I suggest to open another PR for them.


[UX]

Description
Currently the posts are displayed in Grid format in view all comment dialog box, we can modify it to display the posts in image slider as shown in #126
Screenshots

Additional information
No response

you can go ahead :)

check points for this issue

Got them!


how to use Custom ViewModel Navigation With MasterDetailPage

0
Im Using Custom ViewModelFirst Navigation .Reference of navigation is here https://docs.microsoft.com/en-us/xamarin/xamarin-forms/enterprise-application-patterns/navigation
I have implemented this navigation with ViewModel working fine.But With the MasterDetailPage. The page is not becoming the child of MasterPage. How i should navigate so that the views become the childView of the MasterPage(Parrent Page).
` private async Task InternalNavigateToAsync(Type viewModelType, object parameter)
        {
            try
            {
                Page page = CreatePage(viewModelType, parameter);
                if (page is MasterMainPage)
                {
                    Application.Current.MainPage = new CustomNavigationPage(page);
                }
                else
                {
                    var navigationPage = Application.Current.MainPage as CustomNavigationPage;
                    if (navigationPage != null)
                    {
                        await (App.Current.MainPage as MasterDetailPage).Detail.Navigation.PushAsync(page);
                        //var masterMainPage = Startup.ServiceProvider?.GetService<MasterMainPage>();
                        //masterMainPage.Detail = page;
                        // await navigationPage.PushAsync(page);

                    }
                    else
                    {
                        Application.Current.MainPage = new CustomNavigationPage(page);
                    }
                }
                await (page.BindingContext as ViewModelBase).OnAppearing(parameter);
            }
            catch (Exception ex)
            {

                throw;
            }
        }

`
In the Code I'm setting the MasterDetailPage as Root and using navigation. I'm Not understanding how i should add the different views to the child of MasterDetailPage.

Hi @TrueTech-Source
Hi @zubair1995
As the docs say, the NavigationService is only designed to work with ContentPage objects, using hierarchical navigation. It will require substantial re-working to work with a MasterDetailPage.


Consider adding examples for extras_require

Perhaps the project could benefit from adding syntax examples for two useful features, commonly seen in the wild:

extras, e.g. myproj[this,stuff]
conditional deps, i.e. environment markers (e.g., requiring backports only when needed)

Additionally, I think the UploadCommand thing is feature bloat and should be removed.  It doesn't really belong here directly in setup.py, being duplicated in each and every project.  Maybe just add a comment or a link to a good guide about how to use twine?

Note: there is now an 'extras' example in the master branch.

I disagree: with so much tooling and documentation out there that predates twine, updating the behavior of setup.py upload is a good thing to do. You can use twine separately, but I'd prefer to at least have upload do the right thing instead of the wrong thing.
Also: I like the fact that python setup.py sdist upload is one command, while cleaning out the dist/ directory, running python setup.py sdist, and then uploading the result with twine is three.

@rspeer  The content in setup.py should be info specific to that project.  I agree that default behaviour for python setup.py upload could be improved, but this needs to be addressed directly in distutils and/or setuptools, not copy-pasted from github.com/kennethreitz.

You're asking for this to be blocked by impossible things, @wimglenn. The behavior of distutils cannot be changed, because it's in the standard library. And making setuptools depend on twine would be a circular dependency.
There has been some very vague discussion of how to improve this situation, but clearly nothing will happen soon. The pypa maintainers already expect people who want to be able to use setup.py upload to patch it in their own setup scripts.

@rspeer  The upload command is now deprecated by setuptools.  See https://setuptools.readthedocs.io/en/latest/history.html and https://github.com/pypa/setuptools/pull/1410

This entire repository is basically obsoleted by PEP 517/PEP 518.  Closing.


Suggested Actions: Majority of the Javascript sample is missing

Here it is in its entirety on the page:
*/
async sendSuggestedActions(turnContext) {
    const cardActions = [
        {

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53446ad1-6b8c-1ccb-6e78-2cb14358b1c3
Version Independent ID: 8b0fcc34-e624-64a9-adc8-6c8fa3031f54
Content: Use button for input - Bot Service
Content Source: articles/v4sdk/bot-builder-howto-add-suggested-actions.md
Service: bot-service
GitHub Login: @Kaiqb
Microsoft Alias: kamrani

@q00u Thanks for pointing out the misaligned snippet. It's been fixed in https://github.com/MicrosoftDocs/bot-docs-pr/pull/2418 and should go live shortly.

Closing now that the fix is live.


We should split reader.ts into several artifacts

Problem

Currently, reader artifacts contain: the generated TypeScript __param type, the generated __outputType type, and the reader AST.
If a resolver is unreachable from an entrypoint, we do not need to generate the reader AST. But we do need to generate the types. So, we generate unneeded reader ASTs.
If the resolver is never selected by another resolver and is not an entrypoint, we do not need to generate the output type. So, we generate some unneeded output types.
However, we need to define a __param type for all user-defined resolvers, because it is used by iso.ts. We currently generate unneeded __param types for __refetch artifacts (though, seemingly not for magic mutation fields.)

Note: the output and param types that we generate that are not needed are not as big of a deal as the unneeded reader AST, because:

output types are easy to create
__refetch fields are rarer
So, if not generating the output and param types adds complexity, we can punt on it.

Solution

So, instead, we should split reader.ts into reader.ts (containing the reader AST and reader artifact), param_type.ts and output_type.ts.

Details

Type/field/param_type.ts should import the output_type of all selected resolvers and export the param type
Type/field/output_type.ts should contain the ResolverReadOutType (e.g. export type Query__HomeRoute__outputType = (React.FC<ExtractSecondParam<typeof resolver>>);) and nothing else.
Type/field/reader.ts should define the reader AST. It should import the user-defined exported resolver function (i.e. export const pet_stats_card = iso(...)). It should import the param and output type. It should define and export the artifact.

Follow ups:

We should only generate types, and not reader ASTs, for unreachable client fields
Maybe this has some implication for __refetch fields. That seems to work correctly now, but it would be worth double checking whether we can simplify things.
I'm hoping that this results in cleaner code, which will make it easier to do things like asynchronously import JavaScript (see #33)

Can I take this?


I can't compile the showcase example and installing libxext-dev diden't fix the error.

Describe the bug
I can't compile the showcase example and installing libxext-dev diden't fix the error.
To Reproduce
Steps to reproduce the behavior:

Git clone the orbtk repo
Run cargo run --example showcase --release in wsl debian
Profit!!!!

Expected behavior
I wanted to compile the showcase example
Screenshots
Desktop (please complete the following information):

OS: WSL debian windows 10
Browser ¿?
Version ¿?

Smartphone (please complete the following information):

Device: ¿?
OS: ¿?
Browser ¿?
Version ¿?

Additional context
This is the log of cargo when i tried to run the example
error: failed to run custom build command for `sdl2-sys v0.34.5`

Caused by:
  process didn't exit successfully: `/home/uwu/orbtk/target/release/build/sdl2-sys-eac5ee27e416feb0/build-script-build` (exit status: 101)
  --- stdout
  running: "cmake" "/home/uwu/orbtk/target/release/build/sdl2-sys-9a5c8f96adbc95a3/out/SDL2-2.0.14" "-DSDL_SHARED=OFF" "-DSDL_STATIC=ON" "-DCMAKE_INSTALL_PREFIX=/home/uwu/orbtk/target/release/build/sdl2-sys-9a5c8f96adbc95a3/out" "-DCMAKE_C_FLAGS= -D__FLTUSED__ -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=release"
  -- Checking for module 'jack'
  --   No package 'jack' found
  -- Checking for module 'libpulse-simple'
  --   No package 'libpulse-simple' found
  -- Checking for module 'esound'
  --   No package 'esound' found
  -- Checking for modules 'bcm_host;brcmegl'
  --   No package 'bcm_host' found
  --   No package 'brcmegl' found
  -- dynamic libX11 -> libX11.so.6
  -- dynamic libXext -> libXext.so.6
  -- dynamic libXrender -> libXrender.so.1
  -- Configuring incomplete, errors occurred!
  See also "/home/uwu/orbtk/target/release/build/sdl2-sys-9a5c8f96adbc95a3/out/build/CMakeFiles/CMakeOutput.log".
  See also "/home/uwu/orbtk/target/release/build/sdl2-sys-9a5c8f96adbc95a3/out/build/CMakeFiles/CMakeError.log".

  --- stderr
  CMake Error at cmake/macros.cmake:28 (message):
    *** ERROR: Missing Xext.h, maybe you need to install the libxext-dev
    package?
  Call Stack (most recent call first):
    cmake/sdlchecks.cmake:413 (message_error)
    CMakeLists.txt:1177 (CheckX11)

  thread 'main' panicked at '
  command did not execute successfully, got: exit status: 1

  build script failed, must exit now', /home/uwu/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.45/src/lib.rs:894:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Should be solved with given development branch.

@seamasteruwu
Would liketo close  this issue. Can you confirm that it is working in 0.3.1-alpha4 or develop ?


Add typings that work with current TS version

This branch basically just copies the typings from https://github.com/timdp/es6-promise-pool/issues/47 and adds them. Works better than the current typings.

:x: Build es6-promise-pool 203 failed (commit https://github.com/timdp/es6-promise-pool/commit/17106e522d by @haslers)

Fails with error TS2304: Cannot find name 'EventTarget'

@haslers , this version is working for me and does not depend on external typings (it only exposes addEventListener & removeEventListener from EventTarget) :
/* eslint no-use-before-define:0, semi:0, space-infix-ops:0 */

declare namespace PromisePool {

  type EventName = 'fulfilled' | 'rejected';

  interface Options<T> {
    promise?: Promise<T>;
  }

  interface Event<T> {
    target: PromisePool<T>;
    type: EventName;
    data: T;
  }

  type Producer<T> = IterableIterator<Promise<T>> | Promise<T> | (() => PromiseLike<T> | null | void) | T;
  type Listener<T> = (param: Event<T>) => any;
}

declare class PromisePool<T> {

  constructor(
    source: () => PromisePool.Producer<T>,
    concurrency: number,
    options?: PromisePool.Options<T>
  );

  concurrency(concurrency: number): number;
  size(): number;
  active(): boolean;
  promise(): Promise<T> | null;
  start(): Promise<T>;

  addEventListener(type: PromisePool.EventName, listener: PromisePool.Listener<T>): void;
  removeEventListener(type: PromisePool.EventName, listener: PromisePool.Listener<T>): void;
}

export = PromisePool;

EventTarget is part of TypeScript’s definitions:
λ rg "interface EventTarget"
typescript\lib\lib.webworker.d.ts
526:interface EventTarget {

typescript\lib\lib.d.ts
8826:interface EventTarget {

typescript\lib\lib.es2016.full.d.ts
4674:interface EventTarget {

typescript\lib\lib.es2018.full.d.ts
4677:interface EventTarget {

typescript\lib\lib.dom.d.ts
4671:interface EventTarget {

typescript\lib\lib.es2017.full.d.ts
4679:interface EventTarget {

typescript\lib\lib.esnext.full.d.ts
4676:interface EventTarget {

typescript\lib\lib.es6.d.ts
10487:interface EventTarget {

What is your setup, @aMarCruz? If Promise is defined, EventTarget ought to be there too.

@Aankhen , my tsconfig.json:
{
  "compilerOptions": {
    "lib": ["es6"],
    "module": "commonjs",
    "allowJs": true,
    "noImplicitReturns": true,
    "outDir": "lib",
    "sourceMap": true,
    "target": "es6"
  },
  "compileOnSave": true,
  "files": [
    "index.d.ts"
  ],
  "include": [
    "src"
  ]
}

from my package.json :
  "dependencies": {
    "es6-promise-pool": "^2.5.0",
    "firebase-admin": "~5.12.1",
    "firebase-functions": "^1.1.0"
  }

This is the default setup for Google Firebase cloud functions, in a node.js environment.

...my devDependencies:
  "devDependencies": {
    "eslint": "^5.1.0",
    "firebase-functions-test": "^0.1.2",
    "mocha": "^5.2.0",
    "ts-node": "^7.0.0",
    "typescript": "^2.9.2",
    "typescript-eslint-parser": "^16.0.1"
  },

Yeah, I copied your configuration and I get the same error unless I remove the "lib": ["es6"] in tsconfig.json, even though EventTarget exists in lib.es6.d.ts. That’s really strange.

Sorry about the radio silence here. I want to have another attempt at improving the typings. That said, I'm still not using TypeScript personally, and we've kind of drifted away from it at work as well.
I'm happy to accept working typings from the community. There are currently three PRs open around typings: #40, #47, and #63 (this one). Intuitively, I'd close the older two and merge the most recent one. However, that probably shouldn't be the only criterion.
Since I don't have a lot of skin in this game, I'm looking at you guys to review the PRs. Please let me know what you think. Thanks!

Thanks for your feedback!
I think it would make a lot of sense to migrate the typings to DefinitelyTyped. I've just commited a change that removes them from the package, but I should probably hold off on releasing a new version until you or someone else has added them to DefinitelyTyped? What's the procedure?

Not at all. Thank you for a very useful library!
I can add them to DefinitelyTyped (it only needs writing a few tests to go with the definitions and opening a PR), but perhaps @aappddeevv would prefer to submit the definitions themselves (with the options fixed) so that their name is in the list of authors and they’re contacted in case of issues.

Sounds good!
After the typings have been added to DefinitelyTyped, tsc will automatically pick them up, right? Or do I need to put anything in package.json? If not, I can perhaps already do a minor release with the typings removed.

You don’t need to do anything; you only need a types entry if you include types. For DefinitelyTyped packages, the end-user runs npm install @types/package, e.g. npm install @types/es6-promise-pool. I would suggest waiting until that’s been added to do the release, because otherwise there will be a window where neither the package itself nor DefinitelyTyped has the types.

Makes sense. Could you ping me here once the typings are in DefinitelyTyped? Thanks!

I’ve been trying to put an improved version of the types together for DT since the original authors don’t seem to be around, but I ran into a roadblock: I haven’t been able to figure out how to avoid flattening the output type, i.e. tell TypeScript that if Bluebird is passed in as the promise library then the output is a Bluebird promise too. No luck on Stack Overflow so far. I’m hoping someone has an answer.

This is getting complicated. I realized my mistake, which solved the direct issue, but when you add another layer, there is a hole in the type inference that seems to make it impossible to express the types in TypeScript.


It is not using GPU

I have NVIDIA RTX 3070 GPU and when I ran this command:
python inference_video.py --exp=2 --scale=1 --video=test_video.mp4
It wasn't using any of my GPU but a CPU instead.

me to

我也是这样的，很奇怪

https://pytorch.org/get-started/locally/

try to install CUDA with this command


Update mkdocs.yml

We’ve updated the guidebook top navigation to increase the font color contrast and font size. In doing so the space between the labels is smaller, thus reducing the ability to differentiate between the labels. To correct this, we’re changing the navigation labels using words with equivalent meaning and fewer characters. "About CivicActions" changes to "About us".
"Common practices and tools" changes to "Our practices and tools".

:books: Documentation preview :books:: https://civicactions-handbook--1113.org.readthedocs.build/en/1113/

Thanks @ContentBrewmaster!


x/build: migrate to using Go modules

On https://golang.org/cl/128636, @bradfitz notes:

I'd want to understand what we do & don't use [modules] for […].
For example, all of our "make deploy-prod" etc scripts right now build in a Docker container with an entirely different mechanism.

Initially, I think we should start with exactly what we're doing today, but with the ability to make changes in x/build with a known-reasonable set of dependencies. That's https://golang.org/cl/128636.
There are certainly more interesting steps we can take down the road: for example, we might be able to use go mod download in place of cmd/gitlock to wire in dependencies.
This issue is for tracking those steps.

@FiloSottile notes: “there’s stuff in vendor/ that disagrees with the go.mod, we should fix that if we’re going all in on modules”

(I'm guessing he's referring to the stuffi in vendor/github.com/tarm/serial.)

“there’s stuff in vendor/ that disagrees with the go.mod, we should fix that if we’re going all in on modules”

There's also https://go-review.googlesource.com/129075, those 2 commands must be out of sync too by now.

I think it's time to delete gitlock.
I've been using modules for my own projects for some time and prefer it over gitlock. (which was always meant as a medium-term solution)
/cc @dmitshur

Well, given this is x/build and its policy (which I can't find for some reason right now), we can experiment with modules as long as they work for our needs. See https://go-review.googlesource.com/c/build/+/128636/#message-82cc0747061a265a95ab44a9ef7debe6798a4392.
I'm in favor of using modules to build commands reproducibly for deployment (aka, replace what gitlock is used for now). 👍
As long as that doesn't interfere with keeping the libraries in this repo (e.g., maintner) working in the GOPATH world.

First speed bump:
bradfitz@gdev:~/src/golang.org/x/build/cmd/gopherbot$ GO111MODULE=on go mod init

bradfitz@gdev:~/src/golang.org/x/build/cmd/gopherbot$ GO111MODULE=on go list -json .
.....
can't load package: package golang.org/x/build/cmd/gopherbot: unknown import path "golang.org/x/build/cmd/gopherbot": ambiguous import: found golang.org/x/build/cmd/gopherbot in multiple modules:
        golang.org/x/build/cmd/gopherbot (/home/bradfitz/src/golang.org/x/build/cmd/gopherbot)
        golang.org/x/build v0.0.0-20181108190521-5df336cd7fdc<EMAIL_ADDRESS>
I suppose we could have one go.mod for all things in x/build but I'd prefer that each package main tool have its own, so we can bump dependencies independently as we deploy things.
Otherwise we'll be in a state where source code doesn't match deployed reality and we we'll bump go.mod deps affecting a dozen binaries and only deploy one of them, and have a few that haven't been deployed for years with untested deps.
What do I need to do to get past that error above, @bcmills?

If you're splitting out a submodule, the new submodule needs to depend on a version of the parent that does not contain itself.
(For strict go get -u compatibility it should be a cycle as described in https://golang.org/issue/27858#issuecomment-425089484, but since nobody should be importing cmd/gopherbot from outside it probably doesn't matter in this case.)
If you want to actually test that change, you'll probably need a replace directive. (In general, testing changes to multiple modules in the same repo is difficult; see https://github.com/golang/go/issues/27542.)

To add to @bcmills's comment, whilst the replace method works (gist, results), you can also do this via separate commits.

I think this is all done.
gitlock is dead.


Feature request deConz styling of  tag

The text on the ingress entry page in deCONZ 6.2.2 is almost unreadable on dark themes.
Is it possible to change the styling of the paragraph tag to use the primary-text-color variable?
Thanks!

+1 here, I was just about to open same request by myself :) It would be perfect if --primary-text-color or --secondary-text-color variable would be used.
It would also be great if e.g top bar could use the common variable that's used though all HA (--primary-color). Same thing about buttons.
Anyways, this UI improvement looks fantastic. Thank you!

We can expose themes to ingress pages, however, a background color was added in #1523, to prevent those issues.
Releases as v6.2.3 should be available for an update at any moment now.

You're the man, Frenck!

Actually, I'm not, this is Bram's work.


Plugin changelog - show before update

Hi,
First, thank you for your work on this !
I have a suggestion : I think it could be better to show the changelog  of a plugin (if it exists)  before updating, with an option to cancel, rather than after, what do you think ?

Hi @nicoduj,
Thanks for your suggestion. This will land in the next major release (4.0.x).
The system will attempt to pull the latest release notes from GitHub and display them screen allowing the user to review them before proceeding with an update.
This will only work when the plugin author publishes a release on GitHub with release notes.

Hi,
would it be possible to show the changelogs of all versions between the currently installed plugin version and the latest version?
Currently only the changelog of the very latest version is displayed, but if I have installed an older version, that is older than one release behind the latest update, I do miss the changes between my installed version and the latest update.
For example:
My installed plugin version: 1.0
Released updates of this plugin: 1.1, 1.2 and 1.3
Displayed changelog in config ui x: only 1.3 and not 1.1 and 1.2 (so I'm missing the changes of 1.1 and 1.2 here and have to look them up manually)


When generating asset-manifest.json compute all entrypoints

Even though CRA by default only generates main entrypoint there is no strong reason to only compute this information for that very entrypoint. This will make it easier for people who eject and need this feature for multiple entrypoints.

friendly 🏓 @mrmckeb


[Avalonia] [Win32] When Window.WindowState=Maximized is set initially on window the Window.OffScreenMargin property is not updated corectly

Describe the bug
When Window.WindowState="Maximized" is set initially on Window the Window.OffScreenMargin property is not updated.
To Reproduce
Run SandBox sample:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x='http://schemas.microsoft.com/winfx/2006/xaml'
        MinWidth="720" MinHeight="480"
        WindowStartupLocation="CenterScreen"
        ExtendClientAreaTitleBarHeightHint="50"
        ExtendClientAreaToDecorationsHint="True"
        ExtendClientAreaChromeHints="Default, PreferSystemChrome, OSXThickTitleBar"
        Background="Blue"
        Name="MainWindow"
        WindowState="Maximized"
        x:Class="Sandbox.MainWindow">
  <Border Margin="{Binding #MainWindow.OffScreenMargin}" BorderBrush="Red" BorderThickness="1" Background="Green">
    <Button Content="Maximize" VerticalAlignment="Top" Name="MaximizeButton" Click="MaximizeButton_OnClick" />
  </Border>
</Window>

using Avalonia;
using Avalonia.Controls;
using Avalonia.Controls.Presenters;
using Avalonia.Interactivity;
using Avalonia.Markup.Xaml;
using Avalonia.Win32.WinRT.Composition;

namespace Sandbox
{
    public class MainWindow : Window
    {
        public MainWindow()
        {
            this.InitializeComponent();
            this.AttachDevTools();
        }

        private void InitializeComponent()
        {
            AvaloniaXamlLoader.Load(this);
        }

        private void MaximizeButton_OnClick(object sender, RoutedEventArgs e)
        {
            WindowState = WindowState.Maximized;
        }
    }
}

Expected behavior
When Window.WindowState="Maximized" is set initially on Window the Window.OffScreenMargin property is updated.
Screenshots
The button and caption buttons in title bar are cut of from top:

After restoring and maximizing again the window content is properly drawn

Desktop (please complete the following information):

OS: Windows
Version 0.10.18, master

Additional context

ExtendClientArea is called before WindowState.Maximized is set so it actually calculates OffScreenMargin for WindowState.Normal
After that WindowState property is set to proper value WindowState.Maximized and _lastWindowState is WindowState.Maximized
The WM_SIZE message is processed but _lastWindowState is already changed from WindowState setter so UpdateExtendMargins is not called again

https://github.com/AvaloniaUI/Avalonia/blob/84791dbf2e772cad889d575ef64000b5ba3d637a/src/Windows/Avalonia.Win32/WindowImpl.cs#L293
https://github.com/AvaloniaUI/Avalonia/blob/84791dbf2e772cad889d575ef64000b5ba3d637a/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs#L574

Is there any way to handle with this bug at this moment?

Has this been fixed? I still have a very similar Bug.

@apophilipse should be fixed in latest version of Avalonia 11.x


Fix project leak via indexable set

ExternalIndexableSetContributor is an extension point. Extension points live as long as the whole application, so caching project without cleaning them up causes projects to be leaked.

This seems to be the most straightforward fix, however, I'd also consider caching file sets as a Project UserData value instead of keeping them in the extension point field

Coverage increased (+0.04%) to 49.902% when pulling 64f9818cad10953c7871151223c0ce4fe7a272ae on denofevil:project_leak into 524030a7cd5e8e9dc2fd5f0d9181fd8ac91ce8b9 on hsz:master.

Thanks, I'll include this in the next release quite soon.


Adaptive Learning: Add option to import exercises and lecture units when importing competencies

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I strictly followed the client coding and design guidelines.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

Setting up new courses that use a lot of material from last year's course is quite a lot of work. Especially linking the learning objects to their respective competencies.
This should be automated to simplify the setup of a new course.
Description

When importing all competencies and prerequisites from another course, the instructor can choose to include the exercises and/or lecture units linked to these competencies. Additionally a date can be set that is used as reference for all exercise and lecture unit dates, so they don't have to be manually adapted from the last year.
In case exercises with the same title already exist in the course, the exercise with that title is not imported but the existing exercise is linked to the imported competency instead.
This PR does not change the import validation for competencies. So it is still possible to create multiple competencies in a course with the same title, by importing competencies with the same name.
The import functionality for all linked learning objects is already implemented for all import options on the server side but only available for importing all competencies and prerequisites on the client side. @JohannesWt will implement this in a follow up, where he'll refactor the whole page.
Steps for Testing

Prerequisites:

1 Instructor

Log in to Artemis
Create a few exercises and lecture units and link them to competencies/prerequisites
Go to another course and import all competencies and prerequisites from the other course with different configurations:

Only import exercises
Only import lecture units
Have some lecture units/exercises already existing in the course with the same title
Set a reference date and check that all dates of the learning objects are set relative to that

Delete all competencies before importing them again, since they would get duplicated otherwise!

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Introduced new import options for competencies and their relations, improving flexibility during the import process.
Added methods to query various entities (e.g., exercises, lectures) by title and course ID for more precise searches.
Introduced CompetencyImportOptionsDTO to encapsulate various import options, streamlining the import process.
Enhanced lecture import functionality with additional configuration options.
Improved data retrieval for quiz exercises with additional related information.
Added new methods allowing for comprehensive import of learning objects associated with competencies.
Implemented a dynamic import table interface for managing import objects with search, sort, and pagination capabilities.
Added a debouncing method to optimize function calls in the API service.
Introduced a new delete method to the API service for better HTTP operation support.
Added unit tests for the JudgementOfLearningRatingComponent to validate rating functionality and error handling.

Bug Fixes

Improved error handling during competency imports.

Documentation

Updated method signatures in several resource classes to reflect new DTO implementations and functionality.
Enhanced localization files to provide clearer guidance on import functionalities.
Refined documentation comments in the API service for consistency and clarity.

What is the reason for finding Exercises by Title? As we are loading the exercises from the server anyways and only display them in the client, we should always be able to get the exercise's ID from the DTO, no?

We load the competencies of the old course together with their related exercises and lecture units. We now want to import these competencies and related learning objects into a new course. For the new course we do not have any ids that we could look up, all we can do is check if a learning object in the new course already exists. If that is the case, we connect it to the imported competency, otherwise we import (duplicate) this learning object into the new course as well.
In the future we should also verify that we do not duplicate competencies if one with the same name already exists, but this is not part of this PR.

I deployed another PR (https://github.com/ls1intum/Artemis/pull/9283) via badge to ts3, there it worked fine 🤔

Due to the test refactoring there are a few merge conflicts, please resolve them


Create data model for follow ups

In order to make documents smaller, we'll split follow ups from contacts into their own document. We need a schema for that.

Fixed by #60.


[WIP] GeoWebCache directory layout

This pull request adds a support for GeoWebCache layout.
This is still work in progress.
I would like to get comments about the implementation.

Closing this due to inactivity. Feel free to reopen


If statements break on CircleCI

CircleCI tests fail when running markcop:

I've replicated the problem locally by using dash (instead of bash):
../markcop/bin/markcop: 44: ../markcop/bin/markcop: Syntax error: word unexpected (expecting ")")

This occurs  on line 52 also.
EDIT: Somehow #3  fixes this: https://circleci.com/gh/hackedu/hackedu/337

This is closed by #3

Closed by #3.


Token rotation checkbox is missing on V9

On Foundry V1 build 238 + DnD5e 1.5.6 + Auto-Rotate 1.2.6, I'm no longer seeing the per-token checkbox to enable/disable auto-rotation. Note that existing tokens (both those that auto-rotate and those that don't) are still behaving correctly, and the Lock checkbox does override behavior for tokens that previously had auto-rotate enabled. I assume the change was caused by V9 changes to the token configuration UI, which no longer contains a "Position" tab.

Having the same problem. Please fix immediately, it makes this module almost impossible to use. The only workaround is to copy existing tokens that are already configured to auto-rotate. That is obviously not possible when installing the module for the first time or creating a new world.

@Clashsoft @chklein1 This should be fixed now. Sorry for the delay!


Add halo_selection_func feature to subhalo-based mock population

Suggestion made by @duncandc. Should be entirely straightforward to implement.

This is resolved by #550


1.10: add Date Stamp to 1.10 form

User Story
“As the Arbitrator of the Article 1.10 complaint process I want the form to record the date it was submitted so I can have that important information for arbitration hearings.”
Tasks
Add 'submission date' to 1.10 form, It could work like the telework submission date below but other solutions/suggestions are welcome

Acceptance Criteria
When a 1.10 form is submitted, the date of submission is recorded in the pdf (and the email?)

Goal is to have date of submission in the pdf,  it does not necessarily have to be a form field

ready to test new date field. @ayushdamani . the field is at the bottom of the form, above the submit button. It should not be editable and display today's date.

Confirmed working ✅
Thanks Andrew!

@Stella-Archer please review the change and let me know when to move it to prod :).

One small edit - Could we clarify the label above the date from “Date” to “Date Submitted

Team to test tonight and report back if problem was fixed

Aug 17 Deployment was tested on 1.10, telework and SL review all worked as expected closing tix


Add AttriCSS and Tufte CSS

AttriCSS: https://raj457036.github.io/attriCSS/
Tufte CSS: https://edwardtufte.github.io/tufte-css/
Hope you don't mind me putting both in one PR.

@TheLastZombie Thank you for this PR! Since AttriCSS has 6 different themes, perhaps we should add it as a collection to include all of them?
Tufte CSS looks great, but note that it (or rather a slightly modified version of it) is already included under the Asciidoctor Skins collection. Admittedly, this is not the most obvious place to find it, and it would also probably be good to be able to get updates to the CSS from the original project. However, that leaves the question of whether to keep both versions or to delete one of them (probably the older / modified version). I am tending toward the latter option, but if you have any thoughts, let me know!

Thanks for catching this! IMO not adding the new theme would be better since removing the already existing one would essentially make the Asciidoctor skin collection incomplete.

Looks great! :+1:


Bug: Error: "state" value received from authentication server does no match client request. Possible cross-site request forgery

I got the error: "state" value received from authentication server does no match client request. Possible cross-site request forgery but when I look into the code it seems that there is a compare between null (as loadedState is null and receivedState is ""). This is in Firefox. Maybe the behavior is different on Firefox
Steps To Reproduce
We have a custom identity provider, so it might only be related to this own identity provider, but the steps are very simple

Login (don't pass any state)
See error in console

The current behavior
An error is shown
The expected behavior
No error is shown since both values are more or less equally empty. Probably a warning could be printed to state that a state should be set.
If I set a state (even a simple one), it works like a charm.

Hi, thanks for reporting.
Could you post the auth and token requests and all their parameters?
If you are not posting a state, then you should not get a empty sting back, I would consider that a identity provider bug. "More or less equal" is not really good enough when working with security related values :stuck_out_tongue:
If that is the case, I would just add a state to the request, it's recommended anyway.

For our purpose we have added a state. It's just a dummy state, but it stops the browser from complaining. And we want to use this state in the future anyway.


disable secure jmx tests for open as they use secrets

We were having nightly DC/OS open builds failed for JMX tests e.g. in 1.13 DC/OS open nightly build
and the reason was the secrets consumed in JMX feature:
state=TASK_FAILED message=Failed to launch container: Collect failed: Default secret resolver cannot resolve references protobuf=task_id { value: "test.integration.kafka__kafka-0-broker__84faae5e-3bad-41d2-9e4e-29703e307457" } state: TASK_FAILED message: "Failed to launch container: Collect failed: Default secret resolver cannot resolve references" slave_id { value: "c52e36a4-6d3f-4b81-aac2-ef2035802e6b-S0" } timestamp: 1.5596350010287921E9 executor_id { value: "test.integration.kafka__kafka__c0e3ce92-71ce-4570-800b-f6a2e864a136" } source: SOURCE_SLAVE reason: REASON_CONTAINER_LAUNCH_FAILED uuid: "\347\331J\223\337mM\374\242G\303\314\022hj\334"

This PR is to disable these tests for DC/OS Open

open build is skipping the test

rebased and merged to master


Segmentation violation (SIGSEGV) at Global Routing Resizer Timing Optimizations (gfmpw-1c)

Description
Hi there! This may be exactly the same as #2035 and already fixed (but awaiting deployment?). In any case I'm including this bug report in case it helps provide another test case.
I'm using caravel_user_project tag gfmpw-1c to harden a user project macro, and I have frequently had it crash on step 20 (Global Routing Resizer Timing Optimizations). This seems to be unpredictable, but can be worked around for any given iteration of my design if I fiddle marginally with things like FP_CORE_UTIL.
Reported error:
[STEP 20]
[INFO]: Running Global Routing Resizer Timing Optimizations (log: ../home/zerotoasic/anton/algofoogle-multi-caravel/openlane/top_ew_algofoogle/runs/23_12_03_15_56/logs/routing/20-resizer_timing.log)...
[ERROR]: during executing openroad script /openlane/scripts/openroad/resizer_routing_timing.tcl
[ERROR]: Log: ../home/zerotoasic/anton/algofoogle-multi-caravel/openlane/top_ew_algofoogle/runs/23_12_03_15_56/logs/routing/20-resizer_timing.log
[ERROR]: Last 10 lines:
36# 0x00007FC4A3C9FF1E in /lib64/libtcl8.5.so
37# Tcl_EvalEx in /lib64/libtcl8.5.so
38# Tcl_Eval in /lib64/libtcl8.5.so
39# sta::sourceTclFile(char const*, bool, bool, Tcl_Interp*) in openroad
40# ord::tclAppInit(Tcl_Interp*) in openroad
41# Tcl_Main in /lib64/libtcl8.5.so
42# main in openroad
43# __libc_start_main in /lib64/libc.so.6
44# 0x0000000000D3DC77 in openroad
child killed: segmentation violation

[ERROR]: Creating issue reproducible...

Expected Behavior
Flow should complete normally.
Environment report
open_pdks e0f692f46654d6c7c99fc70a0c94a080dab53571
Kernel: Linux v6.2.0-37-generic
Distribution: ubuntu 22.04
Python: v3.10.12 (OK)
Container Engine: docker v24.0.5 (OK)
OpenLane Git Version: 7ea7a2aeef4bea5445d133c26ca2b3e9f0d0c78f
pip: INSTALLED
python-venv: INSTALLED
---
PDK Version Verification Status: MISMATCH
The version of open_pdks used in building the PDK does not match the version OpenLane was tested on (installed: e0f692f46654d6c7c99fc70a0c94a080dab53571, tested: dd7771c384ed36b91a25e9f8b314355fc26561be)
This may introduce some issues. You may want to re-install the PDK by invoking `make pdk`.
---
Git Log (Last 3 Commits)

7ea7a2a 2023-10-15T17:01:59+03:00 Fix `FP_PIN_ORDER_CFG` being overriden (#2017) - Kareem Farid -  (grafted, HEAD, tag: 2023.10.16)
---
Git Remotes

origin	https://github.com/The-OpenROAD-Project/OpenLane (fetch)
origin	https://github.com/The-OpenROAD-Project/OpenLane (push)

Reproduction material
issue_reproducible.tar.gz
Relevant log output
...
[INFO GRT-0018] Total wirelength: 1110572 um
[INFO GRT-0014] Routed nets: 16288
[INFO]: Setting RC values...
[INFO RSZ-0094] Found 44 endpoints with setup violations.
Signal 11 received
Stack trace:
 0# 0x0000000000D44DF7 in openroad
 1# 0x00007FC49F16A400 in /lib64/libc.so.6
 2# grt::MakeWireParasitics::estimateParasitcs(odb::dbNet*, std::vector<grt::GSegment, std::allocator<grt::GSegment> >&) const in openroad
 3# grt::FastRouteCore::CalculatePartialSlack() in openroad
 4# grt::FastRouteCore::mazeRouteMSMD(int, int, float, int, int, bool, int, float, int, int, int, float&) in openroad
 5# grt::FastRouteCore::run() in openroad
 6# grt::GlobalRouter::findRouting(std::vector<grt::Net*, std::allocator<grt::Net*> >&, int, int) in openroad
 7# grt::GlobalRouter::updateDirtyRoutes() in openroad
 8# rsz::Resizer::updateParasitics() in openroad
 9# rsz::RepairSetup::repairSetup(float, double, int, bool, bool, bool) in openroad
10# 0x0000000000E85CE5 in openroad
11# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
12# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
13# TclObjInterpProcCore in /lib64/libtcl8.5.so
14# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
15# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
16# 0x00007FC4A3CEB647 in /lib64/libtcl8.5.so
17# TclEvalObjEx in /lib64/libtcl8.5.so
18# 0x00007FC4A3D2627F in /lib64/libtcl8.5.so
19# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
20# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
21# 0x00007FC4A3CEB647 in /lib64/libtcl8.5.so
22# TclEvalObjEx in /lib64/libtcl8.5.so
23# 0x00007FC4A3CA61D0 in /lib64/libtcl8.5.so
24# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
25# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
26# 0x00007FC4A3CEB647 in /lib64/libtcl8.5.so
27# TclEvalObjEx in /lib64/libtcl8.5.so
28# 0x00007FC4A3CA9F00 in /lib64/libtcl8.5.so
29# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
30# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
31# TclObjInterpProcCore in /lib64/libtcl8.5.so
32# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
33# 0x00007FC4A3CE336C in /lib64/libtcl8.5.so
34# TclObjInterpProcCore in /lib64/libtcl8.5.so
35# 0x00007FC4A3C9EEB2 in /lib64/libtcl8.5.so
36# 0x00007FC4A3C9FF1E in /lib64/libtcl8.5.so
37# Tcl_EvalEx in /lib64/libtcl8.5.so
38# Tcl_Eval in /lib64/libtcl8.5.so
39# sta::sourceTclFile(char const*, bool, bool, Tcl_Interp*) in openroad
40# ord::tclAppInit(Tcl_Interp*) in openroad
41# Tcl_Main in /lib64/libtcl8.5.so
42# main in openroad
43# __libc_start_main in /lib64/libc.so.6
44# 0x0000000000D3DC77 in openroad

With latest OpenROAD head, the crash not reproducible. So you can update OpenROAD commit and run again.

@algofoogle OpenLane head (which doesn't necessarily follows OpenROAD head) doesn't reproduce the crash. Can you update OpenLane and try again ?

I will give it a try! I don’t have a failing case right now but I will try the update after the next time I hit the error :)

@algofoogle Great. Please open a new issue if something surfaces.


Failure to build<EMAIL_ADDRESS>on RHEL-7/x86_64

Hello, when trying to build vscode 1.10.2 on RHEL-7 (using spec file from https://github.com/FZUG/repo/blob/master/rpms/vscode/vscode.spec; 1.9.1 can be build without problems), I crash when building<EMAIL_ADDRESS>npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/windows-foreground-love):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"win32","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/windows-mutex):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"win32","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm ERR! Linux 3.10.0-617.el7.sgruszka.x86_64
npm ERR! argv "/home/matej/build/EXTRAS/vscode/vscode-1.10.2/.nvm/versions/node/v6.10.1/bin/node" "/home/matej/build/EXTRAS/vscode/vscode-1.10.2/.nvm/versions/node/v6.10.1/bin/npm" "install" "--loglevel" "info"
npm ERR! node v6.10.1
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the native-keymap package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs native-keymap
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls native-keymap
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/matej/build/EXTRAS/vscode/vscode-1.10.2/npm-debug.log
error: Bad exit status from /var/tmp/rpm-tmp.aiHLtp (%build)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.aiHLtp (%build)

npm-debug.log.txt

@mcepl
Sorry about that. This module now also includes X11/extensions/XKBrules.h and I think that would require also yum install libxkbfile-devel.x86_64 on Red Hat. I will update the README


Develop in the open

In at least a few forum posts, such as (https://support.displaylink.com/forums/287786-displaylink-feature-suggestions/suggestions/16639654-linux-wayland-support), it was suggested that the community develop functionality that doesn't exist. Unfortunately, that would be pointless as pull requests are not considered for actual merging as described in comments for  #148, #146, #142. Additionally, the core driver code is provided as binary. I can't for the life of me figure out why you won't open source some code that you clearly don't not care about maintaining all that much.

Development for Wayland is in progress (as Wim wrote in the link you have
provided) mainly in other components, like GNOME or Mutter. We had also added
support for different pixel formats (e4ea8d3d8aec816411bfcf1057448a4cac36381c) to EVDI as a possible optimization
of pixel path. Any PR is welcome and is considered for merge but sometimes we
already have those changes and are testing them before a push.
We have explained why we are providing part of the solution in binary format,
please take a look at our support page.
Hope I have helped explaining things a bit.
Closing.


[BUG] harvester make ci failed when verify vm api in local

Describe the bug
execute make ci in local laptop under harvester master branch, got error as follows.
The verify vm api always failed, and in the kind I found both harvester deployment and harvester node manager not running.

To Reproduce
Steps to reproduce the behavior:

check out harvester master branch
execute make ci

Expected behavior
no error
Support bundle
N/A
Environment

harvester master branch
local laptop

Additional context
make ci passed in github actions.

The error is virt-launcher pod fails with:
compute {"component":"virt-launcher","kind":"","level":"error","msg":"Failed to sync vmi","name":"test-grsvz","namespace":"default","pos":"server.go:202","reason":"virError(Code=1, Domain=1
0, Message='internal error: Failed to start QEMU binary /usr/bin/qemu-system-x86_64 for probing: libvirt:  error : cannot execute binary /usr/bin/qemu-system-x86_64: Operation not permitted
\n')","timestamp":"2024-06-26T07:46:15.346012Z","uid":"e4ec1043-d9ce-4246-b672-f554e9a00169"}

Per @Vicente-Cheng's investigation, adding Root feature to kubevirt object is a workaround. We don't know why the CI pass in GHA runners yet.

For now, we can disable the following apparmor for the local tests.
// on host side
# aa-disable /etc/apparmor.d/usr.sbin.libvirtd
# aa-disable /etc/apparmor.d/usr.sbin.virtqemud

But I am not sure if there is another way to give the correct permission, or if we need to disable that.

I added the test to check our GHA configuration for AppArmor and looks like the AppArmor is disabled on that.
PR (only for checking): https://github.com/harvester/harvester/pull/6075
Action: https://github.com/harvester/harvester/actions/runs/9678919059/job/26703719522
So, that's why the GHA can run make ci successfully.
I will comment on our script to provide tips we need to disable the virtqemud
Then we can close this one. WDYT?
cc @brandboat, @bk201

I added the test to check our GHA configuration for AppArmor and looks like the AppArmor is disabled on that.
PR (only for checking): https://github.com/harvester/harvester/pull/6075
Action: https://github.com/harvester/harvester/actions/runs/9678919059/job/26703719522
So, that's why the GHA can run make ci successfully.

Interesting, thanks for confirming !

I will comment on our script to provide tips we need to disable the virtqemud
Then we can close this one. WDYT?

I'm fine with this one, perhaps we could also add some description to https://github.com/harvester/harvester/blob/master/tests/README.md.


Random crashes when pumping out fluid from fluid tanks and extract them into air

Describe the Bug
sometimes the game crashes when when pumping out fluid from fluid tanks (from any mod) using pipes and extract them into air.
it crashes randomly and usually crash when the pipes are working as intended. Strange.
Reproduction Steps

make a infinite fluid source
pump them into air uninterruptedly
sometimes they will crash(or not)

Expected Result
They shouldn't crash
Screenshots and Videos
No response
Crash Report or Log
https://paste.mozilla.org/adJLkXCB/raw
Operating System
macOS 12.5 Beta (21G5027d)
Mod Version
0.5.0c
Minecraft Version
1.18.2
Other Mods
in the crash report
Additional Context
I didn't check the Forge version

why 2 dupe issue


Advance update alias

I thought it would be good to avoid calling commands that aren't present on the system. I also added the update command(s) for nixpkgs.

Thanks for the patch! However, I personally don’t use nixpkgs and all machines on which I’d ever run update are guaranteed to have brew and npm installed. As such, I am closing this.


Can't configure ILI9341 and XPT2046 for 2.8" TFT SPI 240X320

Works fine with Arduino ID and LV_Arduino 3.0.1 (both display and touch) However, looks strange with the lv_port_esp32
and touch is incorrect
This is with Arduino ID and lv_arduino library 3.0.1.  No problem scrolling the scroll bar.
https://user-images.githubusercontent.com/15612908/120123233-f2af2680-c1ad-11eb-9a92-7d1bc30519cf.jpg
This is the lv_port_esp32 build with eclipse and idf plugin on Windows 10.
lv widgets demo: the modal dialog fills the whole display width and the background windows is also too big. When touching, none of the buttons or the tabs  responding but the background window is scrolling erratically
https://user-images.githubusercontent.com/15612908/120123288-402b9380-c1ae-11eb-8c46-ec5e55218335.mp4
This is the sdkconfig used
sdkconfig.txt
Hope somebody can give me a clue
Thanks

I found out. It was a matter of setting the right parameters in the sdkconfig file
In my case this gave a reasonable performance:
CONFIG_LV_TOUCH_X_MIN=150
CONFIG_LV_TOUCH_Y_MIN=150
CONFIG_LV_TOUCH_X_MAX=2000
CONFIG_LV_TOUCH_Y_MAX=2000
CONFIG_LV_TOUCH_INVERT_X=y
CONFIG_LV_TOUCH_INVERT_Y=y
CONFIG_LV_TOUCH_DETECT_PRESSURE=y

however to get there it took some trial and error with different values.


MTC service_id merge update

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
Resolves #244 by always feed-scoping the service_ids encountered in the chronologically first feed version that is merged.
Also:

adds test for service_id feed scoping during MTC merges
consolidates some test code
moves all GTFS files/folders used for testing to the src/test/resources/com/conveyal/datatools/gtfs folder.

Codecov Report

Merging #253 into dev will decrease coverage by 11.68%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##                dev     #253       +/-   ##
=============================================
- Coverage     31.67%   19.98%   -11.69%
+ Complexity      649      398      -251
=============================================
  Files           150      150
  Lines          8048     8181      +133
  Branches       1085     1123       +38
=============================================
- Hits           2549     1635      -914
- Misses         5185     6403     +1218
+ Partials        314      143      -171

Flag
Coverage Δ
Complexity Δ

#end_to_end_tests
?
?

#unit_tests
19.98% <100%> (-0.25%)
398 <0> (+4)

Impacted Files
Coverage Δ
Complexity Δ

...conveyal/datatools/manager/jobs/MergeFeedsJob.java
72.88% <100%> (+1.2%)
87 <0> (+4)
:arrow_up:

.../conveyal/datatools/manager/models/LoadStatus.java
0% <0%> (-100%)
0% <0%> (-1%)

...a/com/conveyal/datatools/manager/auth/Actions.java
0% <0%> (-100%)
0% <0%> (-1%)

...manager/jobs/CreateFeedVersionFromSnapshotJob.java
0% <0%> (-100%)
0% <0%> (-4%)

...ls/manager/models/FeedValidationResultSummary.java
0% <0%> (-92%)
0% <0%> (-4%)

...yal/datatools/manager/jobs/FetchSingleFeedJob.java
0% <0%> (-82.36%)
0% <0%> (-6%)

...ls/manager/jobs/NotifyUsersForSubscriptionJob.java
0% <0%> (-72.35%)
0% <0%> (-7%)

...va/com/conveyal/datatools/manager/models/Note.java
0% <0%> (-66.67%)
0% <0%> (ø)

.../com/conveyal/datatools/manager/models/Bounds.java
0% <0%> (-64.29%)
0% <0%> (-5%)

.../conveyal/datatools/manager/models/Deployment.java
0% <0%> (-61.3%)
0% <0%> (-21%)

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a80c6...b8e0a33. Read the comment docs.

See additional comments and questions in https://github.com/ibi-group/datatools-server/pull/253#discussion_r338886946.

@evansiroky, following up on this PR so we can get it merged in. As you are aware, MTC has elected to move forward with the calendar_dates check, but let's handle that in a separate PR. We'll also need to address the other part of #256 in a separate PR (I need to check with MTC about that item as well).
In the meantime, could you fix the conflicts and re-assign to me once it's ready for a final check?

I fixed the merge conflicts.

Not sure what happened, but GitHub just decided there were more conflicts. Can you investigate, @evansiroky?

Never mind, I think GitHub just hiccuped. I pulled the branches locally, did a merge, and git just did a fast forward.


Provide an easy way to edit a rule's id in the decision table view

Is your feature request related to a problem? Please describe.
The modeler auto-generates rule ids with prefix "DecisionRule_" and a hash suffix as their individual values, such as "DecisionRule_09xkbzp".
As a user or tester, it is pretty hard, however, to remember what specific conditions rule "DecisionRule_09xkbzp" is associated with. This is particularly the case when debugging and monitoring matched rules via log messages during runtime of the DMN engine in a Spring Boot application, for example.
Unfortunately, renaming a rule's id in the modeler to alleviate rule recognition is really cumbersome. It requires the user to switch to the XML view and edit their id as part of the XML rule tag. In case of a large decision table with many rules one can lose overview in the many XML tags easily.
I therefore suggest an easier way to edit an individual rule's id in the decision table view to be able to give it a semantically more meaningful value.
Describe the solution you'd like
My proposed solution is similar to editing the details of input and output rule elements. One can modify their attributes, such as expression, input variable, or type, via a "floating panel" by double-clicking on the label in the column header.
Similarly, one could modify a rule's id by double-clicking on the row number displayed in the first column in the decision table. A small "floating panel" would allow editing the corresponding rule id.
Describe alternatives you've considered
None.
Additional context
None.

Thanks for opening this issue.
From what I understand your issue is "make it easier to trace/debug rule evaluation using a Camunda Spring Boot application logs". Is that correct?
Could you share details on how you debug evaluation? What are these log messages you refer to and how do these get easier to understand by hand crafting rule IDs?

Thanks for opening this issue.
From what I understand your issue is "make it easier to trace/debug rule evaluation using a Camunda Spring Boot application logs". Is that correct?
Could you share details on how you debug evaluation? What are these log messages you refer to and how do these get easier to understand by hand crafting rule IDs?


Issues building on MacOS - GoogleAppMeasurementOnDeviceConversion

Description
When trying to build for Mac (Apple Silicon or Intel), I encounter a compile time error listed below. I've tried toggling FirebaseAnalyticsSwift, FirebaseAnalytics and FirebaseAnalyticsOnDeviceConversion all to iOS only in Link Binary With Libraries, yet still run into issues. I can't seem to figure out how to get my project compiling for MacOS with firebase.
Reproducing the issue
No response
Firebase SDK Version
10.3.0
Xcode Version
14.1 Beta 3
Installation Method
Swift Package Manager
Firebase Product(s)
Analytics
Targeted Platforms
macOS
Relevant Log Output
GoogleAppMeasurementOnDeviceConversion

/Users/brettrosen/Library/Developer/Xcode/DerivedData/Todo_Reimagined-baermdjxpolcftgaxsdqplfwnctf/SourcePackages/artifacts/googleappmeasurement/GoogleAppMeasurementOnDeviceConversion.xcframework:1:1 While building for macOS, no library for this platform was found in '/Users/brettrosen/Library/Developer/Xcode/DerivedData/Todo_Reimagined-baermdjxpolcftgaxsdqplfwnctf/SourcePackages/artifacts/googleappmeasurement/GoogleAppMeasurementOnDeviceConversion.xcframework'.

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

I don't think there's a way for Xcode's multiplatform target feature to support different binary Swift Package dependencies.
I believe there needs to be a separate target for each platform.


Add #in query using '= ANY' and '!= ALL'

Here's my first go at #111.
I used = ANY because it expects an array whereas the IN comparison expects a comma separated list of scalar expressions. The pg driver inserts an Array(Int32) directly like {1,2,3} and I couldn't separate the elements into scalar values without using multiple placeholders which i think is unnecessary.
There may be a way to do it with IN, but I don't know how and I don't think there are any drawbacks of using ANY.
Anyway, great work on this. I can't wait to use it on a project when I get the time.

I'll have to review this later, but I'm adding these resources that will be helpful to later me and possibly others:

https://stackoverflow.com/questions/34627026/in-vs-any-operator-in-postgresql/34627688
https://stackoverflow.com/questions/31191507/how-to-use-any-instead-of-in-in-a-where-clause-with-rails/31192557#31192557

Thanks for tackling this! This will be necessary for preloading. I'm excited :)

Thanks for the links @paulcsmith. I took a look at them, and I did more searching but I can't find a way to convert an array into a set so it can be used by IN. I'll keep my eyes open and let you know if I find anything.

K I opened an issue and added a PR for the Int32 thing.
I agree on using ANY, I think that's the way to go. And no problem, it was a learning experience if nothing else. I don't have time now, but I'll work on it tomorrow.

Alright, I reset it to the map values for in commit and rebased it.

Awesome! Thanks a ton :D


Refactor Go services to use gRPC season

Rabbit season

Flaky Test
Failure Summary
Logs

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

[chromium] should display user profile information correctly.
The test timed out waiting for the element 'User ID: eli3cruz' to become visible.
Logs ↗

[chromium] should return list of users correctly.
The API call to get a list of users failed with a 404 Not Found error.
Logs ↗

... and 3 more

View Full Report ↗ ⋅ Docs


fix: install iscsi package in Mariner 2.0

What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: install iscsi package in Mariner
related to https://github.com/Azure/AKS/issues/4153, iscsi-initiator-utils should be installed on Mariner
Which issue(s) this PR fixes:

Fixes https://github.com/Azure/AKS/issues/4153
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
fix: install iscsi package in Mariner

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.39%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2292

Relevant Lines:
2887

💛  - Coveralls

Just chipping in here that we're waiting for this to be merged and part of the image for AKS so we can utilize the iscsi driver.


[Scenario] Historias de Arkham - Agatha Crane

Hello!
I would like to publish the first scenario of the project "Historias de Arkham".
Thank you.
What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?
x Mansions of Madness
Descent
What expansions does the scenario require?
Conversion Kit (CK)
First Edition (MoM1E) - Also Recurring Nightmares
Fatal Alchemy (FA) - Also Suppressed Memories
Call of the Wild (CotW) - Also Suppressed Memories
Beyond the Threshold (BtT)
Streets of Arkham (SoA)
Sunctum of Twilight (SoT)
Horrific Journeys (HJ)
Path of the Serpent (PotS)
What expansions can the scenario optionally use?
Conversion Kit (CK)
First Edition (MoM1E) - Also Recurring Nightmares
Fatal Alchemy (FA) - Also Suppressed Memories
Call of the Wild (CotW) - Also Suppressed Memories
Beyond the Threshold (BtT)
Streets of Arkham (SoA)
Sunctum of Twilight (SoT)
Horrific Journeys (HJ)
Path of the Serpent (PotS)
Please enter the GitHub Url to your scenario here
https://github.com/DaniMassaro/AgathaCrane

Added to the manifest.
@antontimmermans , would you mind to add it to the statistics?


Remove custom IP address logic for Mirror Node address book and use DAB

with:

Mirror Node v0.111.0 was released with support for HIP-869 Dynamic Address Book
We should be able to remove dependency for @hashgraph/proto and simply return the results of
await fileQuery.execute(this._nodeClient) at https://github.com/hashgraph/solo/blob/02526f556fbd7f8a4a3f13f2f99bde63457be3ae/src/core/account_manager.mjs#L629-L629
removing all of the custom logic that follows in that function.

requires FST charts to be upgraded to mirror node v0.111.0+ : https://github.com/hashgraph/full-stack-testing/blob/31535b1d09dab8c3cba35712dada4ce647be5959/charts/fullstack-deployment/Chart.yaml#L41

:tada: This issue has been resolved in version 0.29.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Command containing multiple quotes is not executed although the result is shown as successful

Describe the bug
Command is not executed when using server.shell operation. I also tried creating a new operation for this, but that didn't work either.
When running the command in the terminal it is applied as expected.
To Reproduce
Created an example that reproduces the issue here:
https://github.com/alexandrunastase/pyinfra-dconf-issue-repro
Expected behavior
dconf write command is executed
Actual behavior
dconf write command is not executed
Meta

Include output of pyinfra --support.

--> Support information:

    If you are having issues with pyinfra or wish to make feature requests, please
    check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
    When adding an issue, be sure to include the following:

    System: Linux
      Platform: Linux-5.11.0-16-generic-x86_64-with-glibc2.33
      Release: 5.11.0-16-generic
      Machine: x86_64
    pyinfra: v1.3.10
    Executable: /home/alex/.local/bin/pyinfra
    Python: 3.9.4 (CPython, GCC 10.2.1 20210401)

How was pyinfra installed (source/pip)?
pip
Include pyinfra-debug.log (if one was created)
Does not exist
Consider including output with -vv and --debug.

sudo -l
Matching Defaults entries for alex on zen:
    env_reset, mail_badpass, secure_path=/usr/local/sbin\:/usr/local/bin\:/usr/sbin\:/usr/bin\:/sbin\:/bin\:/snap/bin

User alex may run the following commands on zen:
    (ALL : ALL) ALL
pyinfra inventory.py up.py -vv --debug
    [pyinfra_cli.main] Checking potential directory:
    [pyinfra_cli.main] Checking potential directory:
    [pyinfra_cli.main] Checking potential directory:
    [pyinfra_cli.main] Checking potential directory:
--> Loading config...
--> Loading inventory...
    [pyinfra_cli.inventory] Creating fake inventory...

--> Connecting to hosts...
    [@local] Connected
    [pyinfra.api.state] Activating host: @local

--> Preparing operations...
    Loading: up.py
    [pyinfra.api.operation] Adding operation, {'dconf write test'}, opOrder=(4,), opHash=6a58b6c7e02f6d92150e84bffa4418d987f54dc9
    [@local] Ready: up.py

--> Proposed changes:
    Groups: inventory / @local / my_hosts
    [@local]   Operations: 1   Commands: 1

--> Beginning operation run...
--> Starting operation: dconf write test
    [pyinfra.api.operations] Starting operation dconf write test on @local
[pyinfra.api.connectors.local] --> Running command on localhost: sudo -H -n sh -c 'dconf write /org/gnome/desktop/wm/keybindings/close "['"'"'<Primary>q'"'"']"'
[@local] >>> sudo -H -n sh -c 'dconf write /org/gnome/desktop/wm/keybindings/close "['"'"'<Primary>q'"'"']"'
[pyinfra.api.connectors.util] --> Waiting for exit status...
[pyinfra.api.connectors.util] --> Command exit status: 0
    [@local] Success

--> Results:
    Groups: inventory / @local / my_hosts
    [@local]   Successful: 1   Errors: 0   Commands: 1/1

Interesting! I suspect this is a similar issue to the quoting ofsed commands, will start by looking there!

I've been digging into this and am struggling to re-create the issue, I've setup an example to just echo out the quoted value as it makes it easier to debug:
from pyinfra.operations import server

server.shell(
    commands='''echo "['<Primary>q']"''',
)

Output:
$  pyinfra @local test_quotes.py  -vvv
--> Loading config...
--> Loading inventory...

--> Connecting to hosts...
    [@local] Connected

--> Preparing operations...
    Loading: test_quotes.py
    [@local] Ready: test_quotes.py

--> Proposed changes:
    Groups: @local
    [@local]   Operations: 1   Commands: 1

--> Beginning operation run...
--> Starting operation: Server/Shell (commands=echo "['<Primary>q']")
[@local] >>> sh -c 'echo "['"'"'<Primary>q'"'"']"'
[@local] ['<Primary>q']
    [@local] Success

--> Results:
    Groups: @local
    [@local]   Successful: 1   Errors: 0   Commands: 1/1

This does appear to be correctly quoting and printing ['<Primary>q'] as expected? @alexandrunastase would you mind testing with this example as well, there could be something else going on here.

Hey Nick. Thanks again for taking a look into this.
So I think I found an even better way of reproducing the issue.
from pyinfra.operations import server

server.shell(
    commands='''echo "\"['<Primary>q']\"" | sudo tee keyboard.txt ''',
)

Output from pyinfra is a file containing [<Primary>q]. So no single quotes and no double quotes in this case
But when running the command directly in the terminal
echo "\"['<Primary>q']\"" | sudo tee keyboard.txt

the output is quoted as expected: "['<Primary>q']"

Thanks for the update - I believe this is actually due to Python escaping the \" even within the triple quotes; for example the following works as expected:
from pyinfra.operations import server

server.shell(
    commands='''echo "\\\"['<Primary>q']\\\"" | tee keyboard.txt ''',
)

I think the triple backslashes are unavoidable in getting Python to correctly include the single one in the final command:
In [1]: print('''echo "\"['<Primary>q']\"" | sudo tee keyboard.txt ''')
echo ""['<Primary>q']"" | sudo tee keyboard.txt

In [2]: print('''echo "\\\"['<Primary>q']\\\"" | sudo tee keyboard.txt ''')
echo "\"['<Primary>q']\"" | sudo tee keyboard.txt

Thanks for the reply. I was not aware of this. I assumed this trippe single quotes allows any quotes inside. Your example works indeed for the writing correctly into the file, but I tried escpating the double quotes with the tripple backslashes for the dconf example at the beginning and that didn't work. Do you have any idea how that could be fixed?

I believe the fix would be to wrap the string in double quotes, ie:
''' dconf write /org/gnome/desktop/wm/keybindings/close "\\\"['<Primary>q']\\\"" '''
I can test with dconf itself but this appears to correctly print out with both the double and single quotes included:
from pyinfra.operations import server

server.shell(
    commands=''' echo "\\\"['<Primary>q']\\\"" ''',
)

So I tried this exact thing in this file : https://github.com/alexandrunastase/pyinfra-dconf-issue-repro/blob/main/up.py .
The escaping seems to be alright in the created file, but somehow the dconf command is still not executed properly, although the return code seems to be 0. Maybe there is something else that I am missing, apart from the quoting.


Virus warning

I'm on Windows 10 with love version 11.4
Every time I try to build, Windows Defender pops up because it found "Worm:Win32/AutoRun!pz" in a temporary file "RCX89D2.tmp" in the "AppData\Local\makelove\love-binaries\11.4" folder.
The tmp file is randomly generated during build and gets deleted and blocked by Windows defender instantly.

I've just started getting this as well. Allowing it in defender and retrying seems to be ok as a workaround.
I'm not sure there's anything we can do to actually solve this though.

But how can you be sure that it's really a false positive?

because the "threat" is quite literally the love zip you would download normally:
https://github.com/pfirsich/makelove/blob/master/makelove/windows.py#L34
https://github.com/pfirsich/makelove/blob/f192818e9845683d55dbf40e0415e1cf978524e9/makelove/util.py#L84


Scan aborted right away

Current Behavior

Once I click 'Scan Genshin' it immediately gives me a 'Scan aborted' message and 2 error logs.
at InventoryKamera.Scraper.InitEngines()
at InventoryKamera.Scraper..cctor()
Expected Behavior
The scanner continues to scan
Reproducing a Behavior
I'm not sure. I used the scanner a few weeks ago and it worked fine. Now it wont scan.
Device OS
Windows 10
Genshin Impact Version
3.0
Inventory Kamera Version
1.2.6
Screen resolution, screen mode, and UI scale
1920x1080
Additional notes and remarks
No response
Evidence
No response
Preflight Checklist

[X] I have checked for similar issues in the issue page, and I have not found any similar to mine.
[X] I am using the latest version of the scanner.
[X] I tried setting the scanning delay to maximum, and it still doesn't work.
[X] I have attached the video recording to the bug report.
[X] I have attached the error log to the bug report.
[X] I am available to later explains the issue.
[X] I have disabled all screen filtering software or plugins (i.e. HDR, Image Sharpening) while scanning.
[X] I use default in-game keybindings or have configured keybindings for the scanner.

I ended up reinstalling and it fixed the issue


Please prevent same name in Globals and Locals

Please let the compile give an error in this case:

Or add (at least) CodeCop warning.

+1 for CodeCop warning not error.

I vote for the error. Having global and local vars with the same name is incredibly confusing to read and quite bad form. I've seen it lead to bad logic as well when the wrong variable was being used from what the developer intended.

An example would be in  C#, you can save variable name in class level or method level, you can distinguish the scope by using this keyword.

Yup fair enough, I just think that it's not a very clean way to write code. I'm actually reworking as much code as I can to eliminate global vars completely :)      ….but of course that's not always possible.

I agree, it gets messy...

"... eliminate global vars completely ..."

Agreed, the functional style of programming usually helps making things easier to understand. Reducing or eliminating global variables reduces the number of interactions that a function could possibly do by explicitly listing only the variables that a function is allowed to access.

"...reworking..."

This is the issue. While in the theoretical world everything can be converted, in the real world you're waiting on other people (usually Microsoft) to allow to the allow the change to be possible.
This reminds me of a feature of other code analysis tools (Inline excuses #2970) with that additional feature it could be reasonable to add a $CodeCop warning for every use of a global variable.


Fixes around std::io being renamed to std::old_io

Fixed imports and io:: references
Fixed deprecated Writer::write calls to use Writer::write_all

Thank you!


Add "professors" aggregate endpoint to course endpoint

Currently, it can be inconvenient and overcomplicated for our end users to perform some common aggregate operations such as getting all of a course's professors.
As such, we should add the following endpoints which immediately aggregate and return matching courses' professors:

Query based: GET /course/professors (allows for querying like the base course endpoint)
ID specific: GET /course/{courseId}/professors (gets professors only for a specific course)

Can I be assigned this

Can I be assigned this

Absolutely!

Hey, I'm hoping to finish this by Saturday.  I've been swamped with exams, HackUTD, and a bunch of other stuff, so I haven't gotten to finishing this

No worries, thanks for the update :)


Contributing packages with missing dependencies

What is the best/proper way to contribute new packages with a lot of missing dependencies?
Can I create a big PR with many commits (one for each dependency)?
Or is it better to create many PRs?
If this is better asked somewhere else please point me in that direction

Adding or updating dependencies of the actual package the PR intends to add is fine. Just make sure you split them into commits and follow the contributing guidelines (i.e. "foo: init at 4.2.0", "bar: init at 13.37" etc.). A PR should be a package that accomplishes a certain goal and every commit inside it should be one step towards that goal.
Probably better to ask things like these in Discourse or Matrix.


[PWX-22759] Added IBM node driver

Added IBM node driver

What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:

@harsh-px / @thiguetta / @sharma-tapas , pls review


extensibility for eval metrics

new Problem property all_metrics_fns allows extending metrics functions in a Problem versus adding it to metrics.METRICS_FNS, especially if the function depends on problem information

Thanks a lot @rllin-fathom !


Change theme of datepicker

Hey, I think the ability of changing colors of header, buttons, background, texts and etc are needed to be supported.

It support these features dear.
You can change all of them like flutter datepicker.
Please follow this issue.
https://github.com/flutter/flutter/issues/58254#issue-627398973


baseUrl should be ignored with absolute paths

Since I'm reading Link headers from a remote service and they are absolute URIs, I need to strip the baseUrl before using my http-client instance configured with a baseUrl; I think it would be logical to ignore the baseUrl when a path starts with http[s]://.
See PR https://github.com/aurelia/http-client/pull/102.

This does not work for me:
http.configure(conf=>{
	conf.withBaseUrl("http://localhost:51713");
	conf.withDefaults({method: "POST", credentials: "include"});
});

this._http.fetch("http://localhost:8080/Resources/menustore.json", { method: "GET",}),
creates a Request with  http://localhost:51713http://localhost:8080/Resources/menustore.json as url

This is http-client repo, it seems you're using fetch-client.

@Cedware heruan is correct; you're using aurelia/fetch-client. I have opened a PR that fixes the problem in that library. It should go out in the next release. Thanks for the report!


LibWeb: Use available size in calculate_inner_height()

Although the parameter is named "available size," it is always supposed
to represent the containing block size whenever it has a definite value.
Therefore, it is possible to simply use this value instead of performing
a containing block lookup.
This change actually improves correctness for grid items whose
containing block is defined by the grid area, as
Node::containing_block() does not account for this.

The first commit says it can’t have a test because it’s preparation for the second commit.
But the second commit has no test either? :)

he first commit says it can’t have a test because it’s preparation for the second commit.
But the second commit has no test either? :)

right, the first commit is needed to avoid regression in the second. and the second is needed to avoid containing block lookup and align calculate_inner_height() with calculate_inner_width(), so both use passed available size.

he first commit says it can’t have a test because it’s preparation for the second commit.
But the second commit has no test either? :)

right, the first commit is needed to avoid regression in the second. and the second is needed to avoid containing block lookup and align calculate_inner_height() with calculate_inner_width(), so both use passed available size.

This part of the commit message made it sound testable:

This change actually improves correctness for grid items whose
containing block is defined by the grid area, as
Node::containing_block() does not account for this.

So it’s more correct now but not in a way we can prove with a test?

ok, that's fair! I added new test that demoes improvement in correctness. it was actually easier than I though 😅


Branch lc correct delete s for undo

Pull Request Test Coverage Report for Build 446

0 of 0   changed or added relevant lines in 0 files are covered.
26 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 78.089%

Files with Coverage Reduction
New Missed Lines
%

file:/home/travis/build/AY1920S2-CS2103-W14-2/main/src/main/java/seedu/address/model/supplier/Supplier.java
1
97.83%

file:/home/travis/build/AY1920S2-CS2103-W14-2/main/src/main/java/seedu/address/logic/commands/EditSupplierCommand.java
4
94.52%

file:/home/travis/build/AY1920S2-CS2103-W14-2/main/src/main/java/seedu/address/logic/commands/DeleteSupplierCommand.java
21
53.85%

Totals

Change from base Build 440:
-0.02%

Covered Lines:
1896

Relevant Lines:
2428

💛  - Coveralls


[Suggestion] It would be better to remove the "Load More..." button after importing 50 documents into the collection

OS: Windows 10
Azure Database Build Version: 20230314.4
Azure Resources Build Version: 0.6.2
Regression: Not a regression
Repro Steps:

Create a MongoDB account -> Create a database -> Create a collection.
Import 50 documents into the above collection.
Expand the above collection -> Click "Load More...".
Check whether more document load in the list.

Actual:
No more documents load in the list.
Suggestion:
It would be better to remove the "Load More..." button after importing 50 documents into the collection.
More Info:
This issue also reproduces for the SQL account.

Since this issue also involves "load more", let's track it in #2113


[Bug]: Number card increment/decrement

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
Before clicking on the + sign:

After clicking on the + sign I see the following for a second:

At the end I get:

Expected Behavior
I'd expect to see 15.5 after clicking on the + sign and not 16 for a second.
Steps To Reproduce
I have an MQTT number sensor:
  - name: "Thermostat Target Temperature"
    state_topic: "homeassistant/thermostat/target_temp/cmd"
    command_topic: "homeassistant/thermostat/target_temp/state"
    device_class: temperature
    qos: 2
    min: 5
    step: 0.5
    max: 35

On my Dashboard I'm using a Number Card for this:
- type: custom:mushroom-number-card
  entity: number.thermostat_target_temperature
  icon: mdi:thermometer
  fill_container: false
  display_mode: buttons
  layout: horizontal
  secondary_info: last-updated

Context
YAML state

Environment
- Browser: Firefox 111.0
- HA Version: 2023.3.3
- Mushroom: 2.6.1

Anything else?
No response

Thanks @oxigen-dev !


Oracle Cloud Vault guide

I didn't create a base guide - looking at John's Google guide it doesn't appear that there's much in common, We can extract a base guide later if it makes sense.
Run ./gradlew clean micronautCloudSecretsOracleBuild -x micronautCloudSecretsOracleRunTestScript to build the guide.
Preview: micronaut-cloud-secrets-oracle.pdf

@sdelamo the guide is ready for proofreading