Enforce linting check on contracts naming convention

https://github.com/ubiquity/ubiquity-dollar/pull/848#issuecomment-1852582043

Perhaps solhint or https://github.com/solhint-community/solhint-community fork could be integrated after all rules are agreed:
Example settings:
https://github.com/PaulRBerg/foundry-template/blob/main/.solhint.json
There are differences in so called 'best practices' rules, it would be good to fully review and decide on which subset or superset of rules to use.
https://github.com/protofire/solhint/blob/develop/docs/rules.md#best-practise-rules
vs
https://github.com/solhint-community/solhint-community/blob/master/docs/rules.md#best-practise-rules

Perhaps solhint or https://github.com/solhint-community/solhint-community fork could be integrated after all rules are agreed:
Example settings:
https://github.com/PaulRBerg/foundry-template/blob/main/.solhint.json
There are differences in so called 'best practices' rules, it would be good to fully review and decide on which subset or superset of rules to use.
https://github.com/protofire/solhint/blob/develop/docs/rules.md#best-practise-rules
vs
https://github.com/solhint-community/solhint-community/blob/master/docs/rules.md#best-practise-rules

#851

There are differences in so called 'best practices' rules, it would be good to fully review and decide on which subset or superset of rules to use.

lol thats unfortunate.

It's nice the recopilation, but we should follow the convention by 50% or own judment, the reason?
an e.g

no-inline-assembly

We have inline assembly in diamond, and there is no issue with that, as much as it shows as recommended, it can be turned off.. This is one of many others
The idea (my idea) it's to stylize the code more and enforce the rules, but still many of these can be turned off

! action returned an unexpected value

Currently trying to debug this but I'm only seeing it in this repo so I'm debugging in production now. Sorry for the incoming notifications.

test

test

/help

test

test

test

test

/help

test

test

/help

test

Netlify logs just stopped outputting any of my logs suddenly...

test

/help

test

test

test

/help

@pavlovcik be honest, you did it to showcast the new table command data, looking amazing 😄  🔥 🔥 !!

@pavlovcik be honest, you did it to showcast the new table command data, looking amazing 😄 🔥 🔥 !!

lol really its cause I couldn't reproduce the assign event error but not I think its because its from other issues that the wildcard automatic unassign finds. Also I added a lot more logs so that's why we were able to diagnose the issue better.
Thanks for the compliment!

test

test

test

testing netlify logs

/help

test

test

testing netlify logs

looks like still outputting logs after a few hours


AGET

Environment details:

local deployment
Docker version 17.04.0-ce, build 4845c56
Ubuntu 16.04

Steps to reproduce the issue:
while running the openwhisk build locally in Ubuntu I am getting unable to resolve 'github.com'

execute docker build -t controller /home/nokia/openwhisk/core/controller

Provide the expected results and outputs:
build should have been successfull

Provide the actual results and outputs:
output comes here

Step 8/12 : RUN wget https://github.com/swagger-api/swagger-ui/archive/v2.1.4.tar.gz &&     mkdir swagger-ui &&     tar zxf v2.1.4.tar.gz -C /swagger-ui --strip-components=2 swagger-ui-2.1.4/dist &&     rm v2.1.4.tar.gz &&     perl -pi -w -e  's{http://petstore.swagger.io/v2/swagger.json}{/api/v1/api-docs}g;' /swagger-ui/index.html
---> Running in 754b8ca09b5e
--2017-04-27 05:35:41--  https://github.com/swagger-api/swagger-ui/archive/v2.1.4.tar.gz
Resolving github.com (github.com)... <IP_ADDRESS>, <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... failed: Connection timed out.
Retrying.
Additional information you deem important:

I have tried adding proxy server in the /etc/resolv.conf but dint help
Also exported HTTP_PROXY and HTTPS_PROXY in the docker file, but this also dint help
if I do a wget from the directly from the prompt I am able to download the tar

I'm getting the feeling your docker/network setup is broken. This doesn't seem a problem with OpenWhisk itself but with the underlying docker system you use.
Can you run the following please:
docker run --rm buildpack-deps:trusty-curl wget https://github.com/swagger-api/swagger-ui/archive/v2.1.4.tar.gz

This is  resolved by adding following changes to the docker file.
RUN export http_proxy=<proxy_host>&&
export https_proxy=<proxy_host>&&
wget https://github.com/swagger-api/swagger-ui/archive/v2.1.4.tar.gz &&
mkdir swagger-ui &&
tar zxf v2.1.4.tar.gz -C /swagger-ui --strip-components=2 swagger-ui-2.1.4/dist &&
rm v2.1.4.tar.gz &&
perl -pi -w -e  's{http://petstore.swagger.io/v2/swagger.json}{/api/v1/api-docs}g;' /swagger-ui/index.html


Comparison of different Flux implementations and others

It would be nice to add a tabular overview of different Flux implementations to https://learnrelay.org/introduction/what-is-relay#how-is-it-different-than-other-flux-implementations.
Also, we could compare Relay to Apollo or other GraphQL clients (lokka?). See http://www.codazen.com/choosing-graphql-client-apollo-vs-relay/

@lvarayut do you want to tackle this issue? :rocket:

@marktani, I would love to help but I'm currently very busy. I could help you review it afterward.

Depending on my schedule I might be able to take over, let's see how it works out :)

maybe we could turn this into a questionnaire that will help people decide on the GraphQL client to use by answering a few simple questions.


fix error when extracting exif metadata features from images in RAI Vision dashboard

Description
fix error when extracting exif metadata features from images in RAI Vision dashboard
Customer encountered exception:
Traceback (most recent call last):
  File "./rai_vision_insights.py", line 540, in <module>
    main(args)
  File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/azureml/rai/utils/telemetry/loggerfactory.py", line 153, in wrapper
    return func(*args, **kwargs)
  File "./rai_vision_insights.py", line 456, in main
    rai_vi = RAIVisionInsights(
  File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/rai_vision_insights/rai_vision_insights.py", line 269, in __init__
    ext_test, ext_features = extract_features(
  File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/utils/feature_extractors.py", line 86, in extract_features
    row_feature_values[feature_names.index(tag)] = data
ValueError: 'XPComment' is not in list

To fix these, a set of test cases were added to the metadata feature extraction logic.  By adding the XPComment field, which contains a string of bytes, the issue was reproduced and fixed locally.  Also some other issues were found and fixed with the method, such as an error when feature metdata parameter is unspecified.
Checklist

[x] I have added screenshots above for all UI changes.
[x] I have added e2e tests for all UI changes.
[x] Documentation was updated if it was needed.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0700cdc) 89.72% compared to head (3be2e84) 78.89%.

Files
Patch %
Lines

...n/responsibleai_vision/utils/feature_extractors.py
77.77%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2461       +/-   ##
===========================================
- Coverage   89.72%   78.89%   -10.83%
===========================================
  Files         122       14      -108
  Lines        6751     1355     -5396
===========================================
- Hits         6057     1069     -4988
+ Misses        694      286      -408

Flag
Coverage Δ

unittests
78.89% <81.81%> (-10.83%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP: Set creator while WI creation

Fixes iss-244
Why:
We need to record who created what (in WI for now). Need to fill up the field 'Fields['system.creator']' by current logged in user's email.
What:
As of now there is no special type which can identify a user in fields. Make use of tokenManager to read/extract tokens.
How:
Add a new UserType, Unmarshall FieldDefinition for UserType.
Move Equaler, Lifecycle to new package to avaoid cyclic import.
Remove some tests on temperory purpose.
ToDo:
add email to the system.creator
add middleware to consume Locate method.
write/update tests which will use login context.

@pranavgore09 Could you rebase this of a almighty-core/master as user_auth is now upstream. Also change the target of the PR to almighty-core/master.

roger that !

I tried to align this branch of mine with upstream/master and failed several times after attempting pulling, rebasing, cherry-picking whatever needed in correct order.
Reasons were remote base branch was deleted, the same was squashed, May be I forgot to rebase yesterday. After all attempts either build and tests were failing or comparison in PR was showing 54 files modified :)
After spending good amount of time I decided to create new branch off upstream/master and redo needed changed but this time in neat and better way.
Lessons learnt -

Avoid working off other branches (other than upstream/master, may create issues if others are working, squashing, force pushing  on same !)
Keep PR smaller.
Learn git :sweat_smile: (to not to create a mess for self)

So I will be creating 2 PRs, one for architectural package level changes and second for actual task related changes.
Happy coding :smiley:


Widget for direct backend use

I'm looking for a way of rendering part of the GUI using OpenGL, e.g; to have a 3D preview of a model embedded in a ui panel.
Perhaps a solution that is not very intrusive is to render to texture (Ideally from a shared context) and display it in Monomer.
A widget encapsulating this behavior would be ideal.

Hi @edmeme!
It is possible to make OpenGL-based widgets without rendering them to a texture. The render function of Widget runs in IO instead of a restricted monad; this allows calling any OpenGL function you need. If other Renderer instances are added in the future (for Vulkan or Metal), this escape hatch will allow making low-level rendering with them too. The objective of choosing IO instead of a restricted monad was to give flexibility to applications that need this kind of functionality without tying the library to any specific backend.
When doing low-level OpenGL rendering, some care needs to be taken:

Since NanoVG depends on OpenGL's context, modifying it may cause unexpected results. You will need to call Renderer's saveContext/restoreContext for this.
Unless you are using appRenderOnMainThread, doing anything related to OpenGL outside the render function will cause a crash due to OpenGL's threading constraints. Consequently, shader compilation has to happen in the render function; you will need to use an IORef (that you can create on init) to avoid re-compiling the shader or re-creating vertex buffers every time. I will improve the API to remove this workaround and allow initializing OpenGL resources with a mechanism equivalent to RunTask.

I'll add an example with proper documentation; I had this in my backlog, but I never got around to implementing it. I'll keep you posted.

Hi @edmeme!
I just released version <IP_ADDRESS>, which includes better support for initializing OpenGL resources. I also added a new example that explains how to integrate OpenGL into a Monomer application. You can find the source code of the example here.
I hope it's useful for your use case!

Thank you very much, it looks great :)
I like a lot the concept and design of Monomer so far, thanks for writing it

Done!


Works IIIF troubleshooting

Issues with iiif-builder Manifests and Collections when used on works pages
https://github.com/wellcomecollection/wellcomecollection.org/issues/6428

[x] 1. Make v2 manifests use fake pre-auth-1 ../auth/0/.. strings in their profiles (although Gareth can use both forms, so not a blocker)
[ ] 2. Make v2 manifests that are part of collections use the v2 path for their parent collection on the within property. They currently point to the canonical (versionless) Collection, which is wrong - the work page follows this link but even if it didn't it needs fixing.
[x] 3.  sequences.canvases[0].images.resource.service was an array and is now an object. https://wellcomelibrary.org/iiif/b12811385/manifest  vs  https://iiif.wellcomecollection.org/presentation/v2/b12811385. This is because we tidied up duplication of services in the manifest and removed the declaration of an auth service on the image resource itself. We can put this back if the work page needs it, but does it actually need it? It produces huge bloat in the JSON. This is the cause of (5) in https://github.com/wellcomecollection/wellcomecollection.org/issues/6428 so will reinstate.
[ ] 4.  Investigate any differences in search implementation - we should be reproducing all the incorrect, pre-spec features of the search here! I can see from this PR that the works page was inferring canvas index from id which will not work. Q for @gestchild - does that PR fix this and is search now working as expected? (I will still test it this morning).
[x] 5. Thumbnails as object (fixed)

General point above about identifiers - canvases are one of several resources that on wl.org have unstable, index-based IDs (e.g., ../55). Clients should treat all resource IDs as opaque strings, but the temptation to extract that 55 and use it as an array index is strong! All IDs now are derived from METS names for things; wc.org does not mint identifiers for digital objects. Now, Goobi might also use index-based-id-generation (e.g., b12345678_0023), but it is at least the source of truth for those names, they can be traced back to digitisation workflow and files on disk, etc. They will also survive some degree of reorganisation within Goobi.

Note on 3) for @gestchild
sequences.canvases[0].images[0].resource.service is now an array again - compare
https://wellcomelibrary.org/iiif/b12811385/manifest
with
https://iiif-test.wellcomecollection.org/presentation/v2/b12811385
(note iiif-test not iiif)
This is because we have re-introduced the auth service as a service on the image resource itself as well as on the image resource's image service.
The current live one https://wellcomelibrary.org/iiif/b12811385/manifest has an unnecessary repetition of the auth service everywhere it is asserted - this dates from the time when we had several different 0.9x drafts of auth running simultaneously. There are still two present, but they are now the same service, which is obviously pointless.
This is more easily seen after the first canvas, where we just use the string IDs of the services:

In the iiif-test one, I have removed this duplication. Which, because of the JSON-LD of IIIF Presentation 2, means we introduce a new object/array discrepancy between old and new:

Specifically,
sequences.canvases[0].images[0].resource.service.service is now a single string rather than an array of strings in the picture, or on the first canvas, a single object rather than an array of objects.
I can easily just duplicate these again, to match the current published one, if that makes it easier.
If I don't hear this afternoon, that's what I'll do.
These array/object annoyances are not present in IIIF V3, thankfully!

Note - this is not deployed so it's only present on deliberately created test ones such as https://iiif-test.wellcomecollection.org/presentation/v2/b12811385 above.

OK... have now reinstated the duplications
https://iiif-test.wellcomecollection.org/presentation/v2/b12811385?nocacheme
We can remove this later if it's safe to do so.

can be seen at https://iiif-test.wellcomecollection.org/presentation/v2/b18031511_0006

I spent some time looking at search; behaviour is identical but there was one silly bug in the autocomplete service. I suspect the works page doesn't actually use the link provided in the autocomplete response to perform the search (the UV doesn't).
https://github.com/wellcomecollection/iiif-builder/pull/154/commits/d6e1bdcc8ce5bd99e2eb778d62cdb5e8c427fefd

Thanks @gestchild
We're currently re-generating all IIIF content (last time I hope). I'll close this for now.


PyFerret plots in LAS squash the time-axis labels

Reported by ansley b manke on 31 Aug 2017 19:33 UTC
In LAS we draw plots with small margins (using viewports), and with the tic-marks drawn inside the box.  When running PyFerret, this winds up placing the labels on time axes right on or overlapping the axis line. This happens with the time-axis styles that have just one line of labels, like the names of months.
Attached are a LAS plot and the same data plotted with default window setup.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2559

Comment by ansley.b.manke on 31 Aug 2017 19:36 UTC
Investigating, this is related to the positioning of the tic marks on the axes.  We draw the tic marks inside the plot box, and the labels seem to be located relative to the tics.  If I set the style to have short tic marks extending outside the box, it looks better, but only for the time-axis styles with a single label.  Ones labeled with year and month for instance look worse.  This needs to be fixed in PyFerret.

Comment by ansley.b.manke on 31 Aug 2017 19:44 UTC
The third image has year/month labels. It's not as jarring as the ones with months only, but the month labels are still right on the plot line.

Attachment from ansley.b.manke on 31 Aug 2017 19:33 UTC
LAS y-t plot
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2559_GIT_1831/08E427827CC93C475E68C74B48349DA9_plot_image.png

Attachment from ansley.b.manke on 31 Aug 2017 19:34 UTC
the same plot without viewport and other special drawing settings
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2559_GIT_1831/default.png

Attachment from ansley.b.manke on 31 Aug 2017 19:41 UTC
A plot with year/month labels on the time axis
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2559_GIT_1831/BC4033612D25D4215084E971810848C0_plot_image.png


Suggestion/Issue

It's half a issue, half a suggestion, but there is no button in the artifact generator to reduce the number of rolls into the substat.
Other than that... Amazing work with the app!

The list of substats is a two-dimensional and unordered array, easy to add, but not easy to reduce. I‘m thinking about whether to refactor it.


Datalab local

Local execution with user accounts.

Review status: 0 of 130 files reviewed at latest revision, 5 unresolved discussions.

containers/datalab/debug.sh, line 23 [r1] (raw file):
Added a comment about it being for enabling the node debugger.

containers/datalab/Dockerfile.in, line 90 [r1] (raw file):
We need some location for users to map in the external directory they are going to use.

containers/datalab/Dockerfile.in, line 120 [r1] (raw file):
Removed

containers/datalab/content/run-debug.sh, line 18 [r1] (raw file):
I repurposed it to enable node debugging.

Comments from Reviewable

Review status: 0 of 130 files reviewed at latest revision, 5 unresolved discussions.

containers/datalab/debug.sh, line 23 [r1] (raw file):
Done.

containers/datalab/Dockerfile.in, line 90 [r1] (raw file):
Done.

containers/datalab/Dockerfile.in, line 120 [r1] (raw file):
Done.

containers/datalab/content/run-debug.sh, line 18 [r1] (raw file):
Done.

sources/lib/datalab/gcp/datalab/_projects.py, line 47 [r1] (raw file):
Done.

Comments from Reviewable

Done reviewing. A few observations.

PTAL

LGTM.


Different profiles for different keybindings

Of course also a hotkey to switch between those profiles

Multiple configs are supported in new version.


Make report of scanned maps with missing bounding boxes

Maps without boundings boxes and that do not have FGDC metadata to pull from
List of bibids should be divided by holding location (Lewis map collection and RBSC historic maps)

@tampakis List of all ImageWorks without bounding boxes and with no FGDC record:
image_works_no_coverage.csv.zip

bib_ids_no_coverage.zip


Karpenter roles to follow new policy guide from new release v0.32.x

Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

No 🛑: please wait to file a request until the functionality is avaialble in the AWS provider
Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.
The new Karpenter version moved the product to beta and changed how the IAM policies for the controller and nodes should be configured.
Describe the solution you'd like.
Follow Karpenter provided policy: https://github.com/aws/karpenter/blob/main/website/content/en/docs/upgrading/v1beta1-controller-policy.json
Describe alternatives you've considered.
You could provide a new additional policy, but I believe the default behavior of the module should be aligned with the latest Karpenter version
Additional context
I would like to work on this feature if there is no active work yet

Is there any timeline for v20.0.0? EKS 1.29 has kinda forced my hand on dealing with Karpenter.
ERROR controller.awsnodetemplate karpenter version is not compatible with K8s version 1.29

Does anyone know of any workarounds for dealing with the karpenter 32.0+ changes in the meantime, short of abandoning the module and managing it myself?

@johnjeffers thats not related to this module - v20 should be live today/tomorrow and it has an IAM policy aligned with the current upstream project recommendation but you will still see that error message due to https://github.com/aws/karpenter-provider-aws/issues/5528

@bryantbiggs Thanks for that info. I know that the module isn't the reason for the error message. What I didn't know is that Karpenter 0.33 isn't compatible with k8s 1.29. I thought I'd be able to get past that error by upgrading, which I hadn't done yet because I was waiting for v20 of the module.

This issue has been resolved in version 20.0.0 :tada:


something wrong with the &apos escape

When there are single quote characters in the notebook outputs, nbconvert converts them to "'", which is fine. But the pelican-ipythonnb converts the "'" to "& apos;".
So the single quote character in the notebook outputs ends up to "& apos;" in the html source code, and "& apos" in the chrome display.
Looks like the single quote is converted twice.
Cannot locate where does the convertion happen.

Hi， Daniel
First thanks for creating the great plugin!
May I know if this issue has been resolved? I followed your recommended method and I also encountered the same problem recently, as shown below:

My setup:

Mac OS  X
Pelican 3.6.0
iPython notebook 3.2.1
Python 2,7.10

Hello, I just tested that example you posted on my setup and it looks to be working in the latest versions. See here: http://danielfrg.com/drafts/ipython-notebook-templates.html
My setup:

Hi, thank you very much!
I turns out to be working fine after I replaced the original plugin with your newest one.
Another minor issue when generating the HTML file, not sure if you happen to know about it.

@DanceOfDragon @danielfrg Hi, I think this error is not really solved. It only works if BeautifulSoup4 is not installed. If it is intsalled in core.get_html_from_filepath BeautifulSoup starts to mask all ampersands.


Fix clusterIP assignment

What this PR does / why we need it: Fixes clusterIP assignment.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/minio/minio/issues/6307
Special notes for your reviewer:

ping @scottrigby @unguiculus

/ok-to-test


Added ability to select by one or more states to Embeddings tab.

The actual formatting is pretty ugly, since Streamlit doesn't like spaces (Neither st.text_area nor st.text_input accepted them for me), and separation by commas doesn't work well when the format "channel, (x, y)" has commas. We could use regex but that raises further problems. So instead I decided on the format:
"channel,(x,y)|channel2,(a,b)|channel3,(c,d)" which I am...not super pleased with, but does work. And at least | means "or", which devs will understand.
Open to better ideas here.

Fixed according to suggestions


Requeue

This introduces a controller which requeues when there are changes to ManagedOSVersionChannel, thus reverts back to default sync_interval in our tests(60m).
It also ties the necessary pieces to report back at kubernetes, and the reconciler now reports back the status as well with events.
Still missing specific tests for it
Fixes: #23

couple of unrelated fixes in here that we missed (tests added):

Metadata injection was not functional at all
Upgrade container spec injection was not functional at all

@Itxaka @davidcassany @mjura Seems all good here from local testing too, looks good for review


Fix "installing bash completion" instructions

The scripts are copied/linked into a directory, not a file. The two directories are the default locations for bash completion extensions.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:albers/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

This patch was created in the github file editor. I assume that for one-word documentation changes no DCO is required. If this is wrong, please let me know.

Hi @albers, it is required indeed ;-) sorry for the pain

@dgageot Thanks for the quick reply. No problem, I was just being lazy. The PR is updated now.

LGTM

LGTM (not a maintainer in this repo), thanks @albers :+1:

LGTM


python3Packages.nats-py: 0.11.5 -> 2.0.0

Motivation for this change
https://github.com/nats-io/nats.py/releases/tag/v2.0.0

Rename from asyncio-nats-client
Fix build (https://hydra.nixos.org/build/166441114)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 158582 run on x86_64-linux 1

2 packages built:

python310Packages.nats-py
python39Packages.nats-py


Add specturm to inject time analysis

When you click on a circle in the plot you open the spectrum in the bottom plot. For this I added a sealed class that either gives features or Scan for an XYDataset like ColoredXYDataset

Merged together with @SteffenHeu


Support desired state reconciliation

Harbor Compose currently works well if used exclusively to create and manage shipments.  However, if some types of shipment changes are made outside via the UI or APIs, there can be some challenges.
When a user runs harbor-compose up, Harbor Compose should make the shipment look exactly like what's defined in the compose files.
Some notable examples...

Using the UI, envvars are added at the shipment/environment level while harbor-compose manages them at the container-level and there are duplicates.  Harbor Compose should probably delete them (or duplicates) from the environment-level.
port changes are not currently supported
would be nice if we could detect changes to things like barges and ports, and know to automatically bring down the shipment first.  (barge change feature is currently broken out)
there are probably others...

Moving to terraform.


KAFKA-7187 MockConsumer can fetch offsets based on timestamps

Add implementation for the MockConsumer, previously unexisting, for fetching offsets based on provided timestamps.
The unit test case was improved to include the testing of the fetching offsets based on timestamps.
Committer Checklist (excluded from commit message)

[ x ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ x ] Verify documentation (including upgrade notes)

Retest this please

@nucatus Thanks for your patch. This idea is LGTM. Could you rebase PR?


Setting toggle syntax broken

Newsboat version (copy the output of newsboat -v or the first line of git show): cd9d777 (also broken in 2.22.1, 2.22)
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
macro m set mark-as-read-on-hover!

Steps to reproduce the issue:

Open any feed

Run the provided macro

Instead of toggling mark-as-read-on-hover it displays an invalid syntax error.
Bisect points to 0fb0c28fb974a1a4f3030de2350e7bb6bcc0cf6a, which makes sense.

I somehow overlooked that feature, thanks for the report!
I'm working on a fix now.


Allow to attach an exting stream to XMLReader

Add FluentDOM\XMLReader::attachStream() to attach stream to read from

Implemented.


"Narrow" FoV sending wrong value to GoPro

I was trying to use this script with my GoPro Hero 12 Black in "narrow" field of view mode, but couldn't get it to work. After digging around, I found out that the integer that should be passed in the HTTPS request for narrow is 2, but the value being passed in the script is 6.
The script is as follows:
    elif [[ ${GOPRO_FOV} == "narrow" ]]; then         GOPRO_FOV_ID=6
It should be:
    elif [[ ${GOPRO_FOV} == "narrow" ]]; then         GOPRO_FOV_ID=2
This part is line 112-113.
P.s.: Making this change on my end does make everything work fine.

Narrow view also does not work in Hero 11.


fix(title): fix copying on WSL 2 by bumping clipboardy version

Commit message
In this PR, support for WSL was added in clipboardy v2.3.0. Since WSL
support for title would be nice, clipboardy's version was increased
from 1.2.2 to 3.0.0.
Because clipboardy is now an ES module, the method of importing it had
to change to use the import function rather than require.
Additional information
After testing locally in WSl 2, I've confirmed that the changes does enable auto-copying on WSL to function as described. When I ran the tests, they all passed. Albeit, it was on Node v17.0.1.
There is no engines field in the package.json file specifying the node version, so I'm unsure if this PR would count as a breaking change to using import.
Please let me know of any changes I should make!

Are you interested in tackling #69?

After reading through the ticket and the linked gist, I would say I'm interested to trying to address it!

Awesome, yeah I figured I'd mention that since it's related to this PR.

it would be nice to have this fix since it also fix vulnerabilities issue for using exec 0.8.0

It looks like project now uses pnpm to manage the dependencies, making this PR obsolete. I do want to take a stab at #69 like I promised to, so I'll close this PR and reopen another one that aims to address #69 as well as the dependency issue for clipboardy.

#83 includes updating clipboardy to v3.0.0.


E2E test for Azure Event Grid source is flaky, fails to receive event after 10 min

This run, for example, shows two consecutive failures of that particular test:
https://github.com/triggermesh/triggermesh/runs/5009110595?check_suite_focus=true
Relevant code:
https://github.com/triggermesh/triggermesh/blob/fb11bdeb11dbb3d1ce38c07a646886fd5cb55d43/test/e2e/sources/azureeventgrid/main.go#L153-L165
Might be related to #446

#538 was a workaround.
#611 should be a permanent fix.

This test is still flaky. #658 didn't help, the event we're expecting never arrives.
Re-opening.

The E2E test for the Azure Blob Storage source doesn't have this issue, although both sources are using the exact same underlying Azure services.
My own conclusion to this is that we should simply pick a more reliable source of events inside the test itself (e.g. something generated by some Azure service instead of "create resource").


feat: Add info command to bb

Resolves #1922
Resolves #1923
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

@kevaundray Can you run prettier on bb.js?

strange cannot reproduce these errors locally


Sass does not support tempDir option

Hello, I am using Ruby gem sass 3.4.13 with this plugin and I get errors with the tempDir option.
You can see in the reference below that the option is invalid for sass, so when you pass it down to the command it fails.
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#options
The solution would be to remove this option before calling the command.

Pull requests accepted. I'm not really supporting this plugin anymore; with most Sass development going towards libsass, I think most people are using gulp-sass now.

Hey, sorry, this project is now deprecated because Ruby Sass is deprecated.
See: https://github.com/sindresorhus/gulp-ruby-sass#deprecated


[#11] Load games from archive

This adds the ability to load a game from any user's archive for review.
An important thing to note is that this only allows one game to be reviewed at a time. Since Shin is not a windowed application like the KGS Java client, it seemed like this was the best way to go. This also does not support the ability to save reviewed games in a user's archive; that is a feature that won't make sense to implement until Shin has a feature-complete SGF editor.
I've made my best guesses as to what the UI/UX for the user game summary modal should look like (and how the load-game form should look). Please comment with any recommended changes.
Vercel deployment: https://shinkgs.ectopod.vercel.app/

nice work,  thank you!


Update play-json to 2.10.3

About this PR
📦 Updates com.typesafe.play:play-json from 2.9.4 to 2.10.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play", artifactId = "play-json" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.typesafe.play", artifactId = "play-json" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #792.


Update uploaded version

As it turns out, the version distributed through NPM isn't the most-current one.
Could you possibly update?

Project is deprecated.


Indexers not running when new review is created

If a new review is created it does not update Elastic Search

Hi @simonmaass
Last I checked it worked - nothing has changed for reviews for quite some time.
We have plugin on afterSave and subscription in mview.xml
https://github.com/DivanteLtd/magento2-vsbridge-indexer/blob/develop/src/module-vsbridge-indexer-review/Plugin/Indexer/Review/Save/UpdateReview.php
https://github.com/DivanteLtd/magento2-vsbridge-indexer/blob/develop/src/module-vsbridge-indexer-review/etc/mview.xml
Which Magento version do you use ?

@afirlejczyk thnx for reploy - we are using 2.3.4 - i will debug it in more depth again

Only approved reviews are exported, I just check it on Magento 2.3.0 and it's working.
If you are using on schedule mode I would check if triggers were created.


[Event Request] Codeunit 99000774 "Calculate Routing Line" - OnAfterSetCalendarEntryFiltersOnFinitelyLoadCapBack

Describe the request
I want to set additional calendar entry filters. Therefore, I request the following event:
local procedure FinitelyLoadCapBack(TimeType: Enum "Routing Time Type"; ConstrainedCapacity: Record "Capacity Constrained Resource"; ResourceIsConstrained: Boolean; ParentWorkCenter: Record "Capacity Constrained Resource"; ParentIsConstrained: Boolean)
var
    LastProdOrderCapNeed: Record "Prod. Order Capacity Need";
    AvailTime: Decimal;
    ProdEndingDateTime: DateTime;
    ProdEndingDateTimeAddOneDay: DateTime;
    SetupTime: Decimal;
    TimetoProgram: Decimal;
    AvailCap: Decimal;
    DampTime: Decimal;
    xConCurrCap: Decimal;
    EndTime: Time;
    StartTime: Time;
    ShouldProcessLastProdOrderCapNeed: Boolean;
begin
    if (RemainNeedQty = 0) and WaitTimeOnly then
        exit;
    EndTime := ProdEndingTime;
    ProdEndingDateTime := CreateDateTime(ProdEndingDate, ProdEndingTime);
    ProdEndingDateTimeAddOneDay := CreateDateTime(ProdEndingDate + 1, ProdEndingTime);
    ConCurrCap := ProdOrderRoutingLine."Concurrent Capacities";
    xConCurrCap := 1;

    LastProdOrderCapNeed.SetCapacityFilters(ProdOrderRoutingLine.Type, ProdOrderRoutingLine."No.");

    CalendarEntry.SetCapacityFilters(ProdOrderRoutingLine.Type, ProdOrderRoutingLine."No.");
    CalendarEntry.SetFilter("Starting Date-Time", '<= %1', ProdEndingDateTime);
    CalendarEntry.SetFilter("Ending Date-Time", '<= %1', ProdEndingDateTimeAddOneDay);
    // NEW BEGIN
    OnAfterSetCalendarEntryFiltersOnFinitelyLoadCapBack(CalendarEntry);
    // NEW END
    if CalendarEntry.Find('+') then
        // ...
end;
[IntegrationEvent(false, false)]
local procedure OnAfterSetCalendarEntryFiltersOnFinitelyLoadCapBack(var CalendarEntry: Record "Calendar Entry")
begin
end;

Additional context
I want to filter the calendar entry for "Capacity (Effective)" <> 0.
Internal work item: AB#544580

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 23210.


Refactored tests to use absolute file paths

This sounds good, although I would wait until we resolve #238 so we can have our beloved aeon.load back?

@glopesdev Done - check now?


Feature/setup

These are the environments implemented in this branch;

React app,
React Router,
React redux,
Middleware,
Linters

Hi @Ayokunnumi1  👍 Good Job so far.
To highlight 🍾
Good commit history ✔
Your design looks good 💯 ✔
Good PR description ✔
Follow GitHub flow ✔
Required changes ♻ ♻
kindly Please add a Descriptive Readme file.
it looks like the MIT file is not Present.


Tagslam gives bayes tree node not found when I try to tune the algorithm for the bag file of my setup.

Setup:  Markers are placed in a gazebo simulation with turtle bot and odometry is fed from the simul itself. I have given information about two markers in the tagslam.yaml file but with respect to the global coordinate frame of gazebosim.
It gives me this error that I'm trying to understand:
[ERROR] [1674501247.977188733]: /tagslam: Requested the BayesTree clique for a key that is not in the BayesTree
[tagslam-1] process has died [pid 9562, exit code 255, cmd /home/dt/AddverbWork/slamalgos/tagslam_ws/devel/lib/tagslam/tagslam_node __name:=tagslam __log:=/home/dt/.ros/log/ea0002dc-9b51-11ed-997c-91c581871bdd/tagslam-1.log].
log file: /home/dt/.ros/log/ea0002dc-9b51-11ed-997c-91c581871bdd/tagslam-1*.log

When I increase the   minimum_viewing_angle parameter this error goes away, however I'm looking for a better way to optimise and find these parameters. Any insights and help is appreciated, cheers.

My tagslam.yaml file:
tagslam_parameters:
  optimizer_mode: fast
  minimum_viewing_angle: 35.0
  max_num_incremental_opt: 100
  pixel_noise: 2.0
  max_subgraph_error: 50.0
  subgraph_abs_prior_position_noise: 0.1
  subgraph_abs_prior_rotation_noise: 0.1
  use_approximate_sync: true
body_defaults:
  position_noise: 0.05
  rotation_noise: 0.01
default_body: perch
bodies:
 - perch:
    is_static: true
    default_tag_size: 1.0
    pose:
      position:
        x: -1.05
        y: 11.66
        z: 2.5
      rotation:
        x: 0
        y: 0
        z: 0
      position_noise:
        x: 0.0001
        y: 0.0001
        z: 0.0001
      rotation_noise:
        x: 1.0e-05
        y: 1.0e-05
        z: 1.0e-05
    type: simple
    tags:
      - id: 21
        size: 1.0
        pose:
          position:
            x: 0
            y: 0
            z: 0
          rotation:
            x: 1.57
            y: 0
            z: 0
          position_noise:
            x: 0.0001
            y: 0.0001
            z: 0.0001
          rotation_noise:
            x: 1.0e-05
            y: 1.0e-05
            z: 1.0e-05
      - id: 20
        size: 1.0
        pose:
          position:
            x: -2.35
            y: -1.5
            z: 1.5
          rotation:
            x: 1.57
            y: 0
            z: 0
          position_noise:
            x: 0.0001
            y: 0.0001
            z: 0.0001
          rotation_noise:
            x: 1.0e-05
            y: 1.0e-05
            z: 1.0e-05
 - rig:
     is_static: false
     type: simple
     odom_topic: "/odom"
     odom_frame_id: base_footprint
    #  T_body_odom:
    #   position:
    #     x:  -1.05
    #     y:  11.66
    #     z:  2.5
    #   rotation:
    #     x:  0.0
    #     y:  0.0
    #     z:  0.0

That's a new one to me. Could you please post the whole console log that tagslam is spitting out (not just the error)? I suspect something like duplicate tags.

Yes, so i was trying to find the same, however tagslam-1.log doesn't exist even though there should be one.

Sorry I really can't say what's going on there. I suspect you discovered a bug that bites when tags are dropped due to low viewing angle. This is something that's supposed to kick in only very rarely, but in your case it's happening all the time. This may trigger a bug that is otherwise undetected.
Can you create a rosbag that's small enough to be downloaded? I'd also need the exact tagslam.yaml, cameras.yaml, and camera_poses.yaml to reproduce the problem.

Somehow the problem is not constrained properly. TagSLAM bombs out the first time it sees a tag with known pose (i.e. tag 20). But since your tagslam.yaml file looks good I suspect it has to do with the drops.

That sounds good to me, please have a look at these files that I'm using with the code:
https://drive.google.com/drive/folders/1pvBHGp265mASetoFkR77UB-Kbqr0yYmY?usp=sharing
The bag file is small tests_gazebo goes with other test files and test.launch goes inside launch folder in the tagslam_tests folder.
Also, I wanted to ask other questions about Tagslam and making the development better and more understandable if someone wants to use some specific functions for the code. Can I mail you regarding the same?

I had a look at your files:

your tagslam.yaml has tag size = 1.0. So you are using 1m tags? Please check. To get any thing sensible I had to position your root tag (id 20) at a height of 5m.
your cameras.yaml has the intrinsics wrong. It should read like this:
intrinsics: [1206.8897719532354, 1206.8897719532354, 960.5, 540.5]
you are feeding in odometry. That's great, but odometry confers scale. So if your tag size is wrong, TagSLAM gets conflicting data from odom and tags.
If you use odometry, you need to correctly specify the transform between odometry and body. You tried first with some absurdly large values (y: 11.66, that's meters!) and no rotations (fat chance your camera and odometry body pose are identical!). This way the odometry does more harm than good.
Given the placement and viewing angles, you cannot run on tags only. You need odom to get decent results. But for odom to work, you need to work out the transform (most importantly, the rotation!) between your camera coordinate system (which is identical to your rig body) and whatever your odometry subsystem considers its reference frame.
Below is the best I could get using fake_odom (note: you will get way better results using your odom, but with the correct transform)

Hello, I made the changes(or close) to what you suggested, but I'm still not able to get the results that you have shown in the figure, can you share your files with me so that I can recreate these results?

 I assume the robot moves in the ground plane. Your robot was not. To make it move in a ground plane I had to place tag 20 at about 5m high.
You can read about how to set the odom transform up here: https://berndpfrommer.github.io/tagslam_web/input_files/
The format in which the intrinsic calib is to be given can be found here (also read NOTE at the very bottom of page): https://berndpfrommer.github.io/tagslam_web/intrinsic_calibration/

@dt1729 you can read about fake odom here:
https://berndpfrommer.github.io/tagslam_web/input_files/
Sorry the rviz graph I sent you was an intermediate result. I kept hacking the files trying to use your odom so I lost the exact files that produced the graph above (they were obtained by disabling your odom).

closing this as resolved. Please re-open if there are still problems.


spirv-fuzz: Wrap region in single iteration loop

This transformation should take region R and turn it into, essentially:
for (int new_counter = 0; new_counter < 1; new_counter++) {
  R;
}

Several variations are possible here:
(1) The loop can be "for" style, with the check and break occurring in the loop head, or "do-while" style, with the check and break occurring at the back-edge block
(2) The loop counter can be a variable that is loaded and stored, or an id for which OpPhi captures the loop-carried dependence
(3) In the case where the loop counter is a variable, it can be Private or Function
(4) The counter could start from 0 and go to 1, or start from 1 and go to 0, and the check can use != or an ordered comparison.
(5) The counter could be integer or floating-point
Ideally the transformation should support all of these.  I'm unsure whether this should be achieved by one monolithic transformation or a couple of different transformations.  For instance, the "for" and "do-while" approach have different consequences for ids defined in the new loop and used after the loop, as the "for" approach changes dominance.

@paulthomson for info.


Display issue on Git for Windows CLI

My cli: Using git for windows 1.9.5.msysgit.0 (latest)
Python 3.4.3 on windows.
Also, the require_confirmation setting has been set to True in the current screenshot.

Same problem here. I think Git Bash uses the underlying cmd Windows prompt and it cannot display ANSI color.

I got the same problem. I think the issue here is that the Python version is geared for Windows and doesn't know anything about running in a MinGW shell. Consequently, it seems to mess up the escape sequence output. If I take that output, replace all the little arrows with \033, and echo -e it in the shell, it works just fine.


Moshi Kotlin

KotlinJsonAdapterFactory() uses the Kotlin Reflection Library that will increases APK Sizes because it is 2.5 MB jar files to be added to the project. The Moshi's Kotlin codegen uses kapt.  The Performance wouldn't be great as codegen is.
My opinion to be avoid of the kotlin-reflect dependency. One more thing, the latest version of moshi is 1.6.0.

This would also solve the following warnings:
w: Runtime JAR files in the classpath should have the same version. These files were found in the classpath:
    /home/travis/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-reflect/1.1.1/e68cf130c2dbdd68a72f4a750cf442dffcd877ce/kotlin-reflect-1.1.1.jar (version 1.1)
    /home/travis/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.2.51/fa8127e505bff50fec291d0dd619d1bda5c619e0/kotlin-stdlib-1.2.51.jar (version 1.2)
    /home/travis/.gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.2.51/e4a9d4b13ab19ed1e6531fce6df98e8cfa7f7301/kotlin-stdlib-common-1.2.51.jar (version 1.2)

I have commented in the PR. :)


error[E0433]: failed to resolve: use of undeclared crate or module anchor_spl

⚠ Don't use issues for support questions ("How does x feature work in Anchor? How to do x in Anchor?"). Use the discord instead https://discord.gg/NHHGSXAnXk (but don't ping maintainers). ⚠
error[E0433]: failed to resolve: use of undeclared crate or module anchor_spl
--> programs/test/src/lib.rs:2:5
|
2 | use anchor_spl::token::{self, Mint, TokenAccount, Transfer};
|     ^^^^^^^^^^ use of undeclared crate or module anchor_spl
v0.30.0
macOs

cargo add anchor-spl
build success


Image preview

I can't see the preview of the images, only the icon. Is this a bug?

@Mattiuz93 What version of Files do you have?

The last of the Microsoft store. Anyway after a reboot now it's all ok 🤗
Inviato da Pixel 4a (5G) 📱
Il dom 7 mar 2021, 07:00 Yair Aichenbaum<EMAIL_ADDRESS>ha
scritto:

@Mattiuz93 https://github.com/Mattiuz93 What version of Files do you
have?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/3866#issuecomment-792223292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQNHAT3DJTWBZUZFYN2JXPTTCMJA3ANCNFSM4YXQJMDA
.


Yeoman Vue Generator compared to the vue-cli?

Hi! First of all good job on Vue.js! I've been using it in some pet projects recently and it's been a blast. Looking forward to using it in a more official capacity :-)
This might be partial ignorance speaking since I have not looked into it in detail, but I was just wondering why the yeoman generator was dropped in favor of the vue-cli? Especially since the vue-cli appears to be a Vue-flavored Yeoman (e.g., templates vs generators).
Thanks in advance!

The main reason is that vue-cli makes it easier to just fork one of the official templates and create your own tailored template (instead of having to mess with Yeoman's generator API and publish to npm). Imo Yeoman's generator API verbosity/complexity/constraints just outweighs the extra bits of functionality.
The other factor is branding. vue init just feels better than yo vue ;)


Set default kurento listenting interface to ansible_default_ipv4.interface

Also adds lo because it may choose it when you have added your external address to the lo interface
Fixes #94

@felinira sorry for asking this since you already did so much work.
Would you be able to rework this PR to fit with bbb/2.3?

I am not the PR creator, but I used it successfully to overcome issue #94. Should I create a new pull request with the changes needed to be merged?

I am not the PR creator, but I used it successfully to overcome issue #94. Should I create a new pull request with the changes needed to be merged?

Hi @ChrisKar96, that would be nice, thank you!


failure using Grammar::Tracer

The failing code is detailed in gist https://gist.github.com/tbrowder/db2a3a80d09e5fddaf755ecc42178953 and is repeated below:
# cat file: lib/Presenters.pm6
unit module Presenters;
use Grammar::Tracer;
grammar Presenters::PGrammar {
    token TOP {
        [
            | <entry>
            | <blank>
        ]+
    }
    token entry   { <key> <sep> <value> }
    token key     { \h* \w+ }
    token sep     { \h* ':' \h* }
    token value   { \N+ }
    token blank   { \h* \n }
}

# cat file: ./test-presenters.data
id: laue-d
name: Lauer, Denny
id: horn-a
name: Hornstein, Anne
id: bran-e
name: Branch, Eddie

# cat file: ./grammar-test-fail.p6
#!/usr/bin/env perl6
use lib <./lib>;
use Presenters;
my $pfil  = "test-presenters.data";
my $mp = Presenters::PGrammar.parse(slurp $pfil);
say "WARNING: Presenters grammar failed to match." if !$mp;
say $mp;

# executing
./grammar-test-fail.p6
TOP
Cannot invoke this object (REPR: Null; VMNull)
  in block  at /usr/local/rakudo.d/share/perl6/site/sources/C0DCFF5AEFDF38901A375AE53AF39C4F12B3F6FC (Grammar::Tracer) line 43
  in regex TOP at /usr/local/people/tbrowde/mydata/tbrowde-home-bzr/mydomains/domains/primary-web-servers/web-sites/computertechnwf.org/public/lib/Presenters.pm6 (Presenters) line 6
  in block  at /usr/local/rakudo.d/share/perl6/site/sources/C0DCFF5AEFDF38901A375AE53AF39C4F12B3F6FC (Grammar::Tracer) line 49
  in block <unit> at ./grammar-test-fail.p6 line 7

After removing "use Grammar::Tracer" the code runs to completion:
# executing
./grammar-test-fail.p6
｢id: laue-d
name: Lauer, Denny
id: horn-a
name: Hornstein, Anne
id: bran-e
name: Branch, Eddie
｣
 entry => ｢id: laue-d｣
  key => ｢id｣
  sep => ｢: ｣
  value => ｢laue-d｣
 blank => ｢
｣
 entry => ｢name: Lauer, Denny｣
  key => ｢name｣
  sep => ｢: ｣
  value => ｢Lauer, Denny｣
 blank => ｢
｣
 entry => ｢id: horn-a｣
  key => ｢id｣
  sep => ｢: ｣
  value => ｢horn-a｣
 blank => ｢
｣
 entry => ｢name: Hornstein, Anne｣
  key => ｢name｣
  sep => ｢: ｣
  value => ｢Hornstein, Anne｣
 blank => ｢
｣
 entry => ｢id: bran-e｣
  key => ｢id｣
  sep => ｢: ｣
  value => ｢bran-e｣
 blank => ｢
｣
 entry => ｢name: Branch, Eddie｣
  key => ｢name｣
  sep => ｢: ｣
  value => ｢Branch, Eddie｣
 blank => ｢
｣

Note that if I use "Grammar::Tracer::Compact"" all works well.

“me too” comment.
Grammar::Debugger:ver<1.0.1>:auth<github:jnthn>
Rakudo version 2018.02.1 built on MoarVM version 2018.02

As a workaround, add no precompilation; above the use Grammar::Tracer line. (An easy fix will probably be to stick that line in `Grammar::Tracer itself, though that's probably only hiding the real issue).

Hit more or less identical symptom playing with Grammar::Modelica .  Switching from | to || (LTM to regular alternation) worked for the Grammar::Modelica case and also worked when I tried it with Presenters::PGrammar.  no precompilation; also worked for the Grammar::Modelica example.


fixes typo seprators should be separators

I thought this word looked funny... I think it was meant to be separators.

@maskott thanks for the PR


Fix line coverage

Use istanbul lines calculation to remove estimated line coverage.
Referencing the following issue #117

@allcontributors please add @jlim9333 for code


Enhancement: Add a Frequently Asked Questions Section, Responsive for All Screen Sizes

Create an accordion-style FAQ section to enhance the website's usability and organization.
Ensure that each question smoothly expands upon clicking, revealing the answer underneath for better clarity.
Incorporate animations for a seamless transition between opened and closed states, improving the overall user experience.
Design the FAQ section to resemble modern interfaces, making it visually appealing and user-friendly.

i updated faq section made it responsive...


Telegraf 1.15 new plugins

1.x docs version of plugins (exact same as changes from 2.x PR that you already approved!)

obsolete being we're combining Telegraf plugin docs in new structure


deps.sh: Add support for python3-only installs

At least in Ubuntu, python always refers to python 2, while python 3 is python3. If only python3 is installed, deps.sh will fail but it's otherwise a supported configuration AFAIK

Counterpoint, and I may be totally wrong: isn't python just a symlink to /usr/bin/python2.7?
I thought the use of the python symlink in Ubuntu was so that users could easily adjust which version of python is their primary version, without uninstalling or reinstalling anything. For example, just repointing the python symlink to /usr/bin/python3.6 would now call python3.6 whenever you execute python

build.sh specifically invokes python2 when installing utilities that are only python 2.x compliant; for utilities that can run under either python 2.x or 3.x it simply invokes python. But since some of the external utilities are only supported in python 2, systems that only have python 3 installed won't be able to run those utilities.
Bottom line, if you only have python3 installed, you should expect some of these external utilities to fail.

@devttys0

But since some of the external utilities are only supported in python 2,

Which are these?
It should be fairly straight forward to make them support also P3, no?

@devttys0
Running the binwalk script itself is not possible on python3-only ubuntu, as it begins with #!/usr/bin/env python, when there's no "python" symlink or executable present anywhere. I'm assuming that on dual-version (python2+python3) system, python2 is always selected as the interpreter :(
@decidedlygray there's an implicit expectation of a lot of scripts, etc., that python points to python2, and creating the symlink might backfire later. (when you do add python2 to your system, for example.)


FILTER: By time

Connect the timeslider widget to the data, so that the period chosen in the timeslider filters the elements on the map. Probably can be done by making the layer time-enabled.

Was very easy to do, I did:

make the layer time-enabled
Adjust one entry for the first_date column which was set to 1.1.1970, which is the start date of the time in the internet, so it was not meaningful and I just deleted it. The reason for why this was a problem is that the timeline adjusted its range automatically


Trello plugin not working

It takes me to the notification page, and if I click any links it opens in my browser instead of in Trello. If I click on a username like @me34343434, then it shows the cards for a brief moment and then switches back to the notification menu.
I'm running Ubuntu 16.04 and logged in with Google.

I just got rid of this part in webview.js in the Plugin's folder:
// always redirect to notifications
    // if(window.location.href.indexOf('notifications') === -1) {
    //   window.location.href = window.localStorage.initUrl;
    // }


Introduce video recording of tests

🚀 Feature Proposal
Implement an out of the box solution for recording videos of test runs with Jest and Puppeteer.
Motivation
Well, there are three main reasons why you should be recording videos of all your tests:

Eliminates the "but it works for me" – forget about those unreproducible bugs that developers reject as a voodoo. If you have a bug on a video for everyone to see, then it did happen and is something that needs immediate attention.
Because textual bug reports can be lacking –  Textual descriptions of bugs often tend to leave important information out. Video recording the bugs as they happen allow developers to notice further details that may help track down the bug and get it fixed.
Exploratory testing – relying solely on memory and note-taking in exploratory testing doesn’t really cut the mustard. A video of all your testing actions is much better than that. Use it for future reference to see what was tested, or to roll back when encountering a bug to understand what brought it to the surface.

Example
The video recorder primarily runs as a custom reporter.

We use ffmpeg to record videos of our tests on CI.
The entire test runs in the context of an Xvfb server and currently works only for Linux.
In order to record videos, we set up an environment variable of the name DISPLAY which basically triggers the test to run in a browser on the CI within an Xvfb server.

videorecorder.js
/* eslint-disable no-console */
const { spawn } = require( 'child_process' );
const { toFilepath } = require( './Util' );

class Recorder {
	constructor() {
		this.ffmpeg = false;
	}

	logBuffer( buffer, prefix ) {
		const lines = buffer.toString().trim().split( '\n' );
		lines.forEach( function ( line ) {
			console.log( prefix + line );
		} );
	}

	start( test, outputDir, display ) {
		if ( display && display[ 0 ] === ':' ) {
			const videoPath = toFilepath( test, outputDir, 'mp4' );
			this.ffmpeg = spawn( 'ffmpeg', [
				'-f',
				'x11grab', //  grab the X11 display
				'-video_size',
				'1280x1024', // video size
				'-i',
				display, // input file url
				'-loglevel',
				'error', // log only errors
				'-y', // overwrite output files without asking
				'-pix_fmt',
				'yuv420p', // QuickTime Player support, "Use -pix_fmt yuv420p for compatibility with outdated media players"
				videoPath // output file
			] );

			this.ffmpeg.stdout.on( 'data', ( data ) => {
				this.logBuffer( data, 'ffmpeg stdout: ' );
			} );

			this.ffmpeg.stderr.on( 'data', ( data ) => {
				this.logBuffer( data, 'ffmpeg stderr: ' );
			} );
		}
	}

	stop( test, outputDir ) {
		const videoPath = toFilepath( test, outputDir, 'mp4' );
		if ( this.ffmpeg ) {
			console.log( '\n\tVideo location:', videoPath, '\n' );
			this.ffmpeg.kill( 'SIGINT' );
			this.ffmpeg = false;
		}
	}
}

module.exports = new Recorder();

We start the video recorder before each test and kill the ffmpeg instance after each test is over. The video is saved as a .mp4 file in the folder specified by outputDir. This is how we call the video recorder in a global beforeEach and kill it in a global afterEach. The code resides in a file jest.setup.js which is passed to setupFilesAfterEnv in the jest.config.js file

jest.setup.js
const { screenshot, videorecorder } = require( '../helpers' );

jasmine.getEnv().addReporter( {
	specStarted: result => {
		jasmine.currentTest = result;
	},
	specDone: result => {
		jasmine.currentTest = result;
	}
} );

beforeEach( async () => {
	global.page = await global.browser.newPage();
	await global.page.goto( global.baseUrl );
	videorecorder.start( jasmine.currentTest.fullName, global.logpath, global.display );
	await screenshot( global.page, jasmine.currentTest.fullName, global.logpath );
} );

afterEach( async () => {
	videorecorder.stop( jasmine.currentTest.fullName, global.logpath );
	await screenshot( global.page, jasmine.currentTest.fullName, global.logpath, false );
	await global.page.close();
} );

jest.config.js
const path = require( 'path' );

module.exports = {
	globals: {
		baseUrl: ( process.env.MW_SERVER || 'http://localhost:8080' ) + (
			process.env.MW_SCRIPT_PATH || '/'
		),
		display: process.env.DISPLAY,
		logpath: process.env.LOG_DIR || path.join( __dirname, 'log' )
	},
	preset: 'jest-puppeteer-preset',
	roots: [ 'specs' ],
	verbose: true,
	globalSetup: './env/global/setup.js',
	globalTeardown: './env/global/teardown.js',
	setupFilesAfterEnv: [ './env/jest.setup.js' ],
	testEnvironment: './env/testEnvironment.js',
	testTimeout: 60000
};

We have bootstrapped the code for a video recorder as a custom reporter and can be found here:
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/602302
The recorder video for test can be found here:
https://integration.wikimedia.org/ci/job/mediawiki-quibble-selenium-vendor-docker/18336/artifact/log/Page-should-be-deletable.mp4
Pitch
Why does this feature belong in the Jest Puppeteer ecosystem?
Currently I am working as a student developer at Wikimedia Foundation for Google Summer of Codes 2020. My major task is to evaluate browser automation replacements for WebdriverIO and we have Puppeteer as one of our contenders, the other being Cypress.
What we found to be highly useful for debugging our E2E test was having video recording of each test run. Most of our tests run on our Jenkins CI environment which runs a slightly different configuration of our core software than the one we use for development and often things that run locally would fail on CI primarily because of differing Node.js versions, differing Chrome versions, etc. Screenshots and video recording have helped us come a long way and I think this would help the community at large as well and it would be awesome if we could include it as an out of the box solution.

Any updates on this? @und3fined-v01d  what's in Utils?

Thanks for sharing and detailed description
+1, this feature is needed, it also works "out of the box" for cypress, which is becoming an increasingly attractive alternative for jest over the years


Cannot uninstall VS Code/delete Code.exe file

VSCode Version: 1.32.3
OS Version: Windows 10

Steps to Reproduce:

Navigate to AppData/Local/Programs/Microsoft VS Code
Right-click Code.exe and press delete

After not being able to update VS Code and having my issue here closed, I attempted to uninstall the program. The uninstaller did not remove all of the files so I attempted to delete them manually. When I try to delete Code.exe, it says "The action can't be completed because the file is open in System"
ProcessExplorer is unable to find anything when I include the filename Code.exe and Unlocker is unable to delete the file.
I am basically out of business as far as VS Code is concerned and have to use Atom or some other editor until I can get this resolved.

Can you delete after restarting?

I was having the same issue trying to update VS Code to 1.33.0, but a system restart resolved it. Why? I have no idea.

I'm having a similar issue, too. I haven't been able to update in weeks because it says that Code.exe is open in System. Tonight, I wasn't able to run any Python commands in the integrated terminal. Then, my system crashed (I'm not sure that that had to do with this issue), and on restart, launching Code resulted in this error:

I decided to do an uninstall and start fresh, but the Windows uninstaller couldn't remove Code.exe for the same reason, and I can't even delete it. When I try to launch it, I get this error:

This was after trying to uninstall, so that may be contributing to the issue.
I'm at a complete loss as to what to do.

I´m with the same problem!

@joaomoreno Any chance there's a fix for this? VSCode is my preferred IDE, but it's completely unusable and inaccessible as is.

@kydojo Can you use Process Hacker to figure out what's the full command line of that runaway Code.exe process?

I'm with the same problem and i thought the restart/uninstall would help... Now i can't even reinstall VSCode because of this apparent process running in the background..

@joaomoreno I'm on a tight deadline with a project right now, but I will definitely do that next week and report back. Thanks

I uninstalled VSCode (user) as far as possible, although Code.exe and others were stubborn due to the "Code.exe process". Then i reinstalled the VSCode System version. Fixed all problems for me.
I could then go into the C:\Users\myuser\AppData\Local\Programs\Microsoft VS Code path and delete the remains of the user install. I haven't had problems with the System install yet.
I hope you guys can use this info for your problems.

Is there a fix for this? No luck with the ideas posted here.

The same problem here, VS Code 1.41.0. Restart/uninstall didn't help, Code.exe was blocked by System..
The Veng97's fix did work.

Same problem here.
Can't launch, Uninstall or reinstall VS. |:
Cannot delete code.exe in any way.

Background update causes this problem. User setup is no longer available.

Re-logging did not work to delete Code.exe, but rebooting did

Uninstall, reboot did not work.  Started in safe mode deleted Microsoft VS Code folder.  Rebooted and installed.

Uninstall, Reinstall, Reboot did not work.  Ended up starting up in safe mode and deleting the folder AppData/Local/Programs/Microsoft VS Code.   Rebooted and reinstalled and all was good.

I followed these steps and managed to get it reinstalled:

Reinstall and ignore all the warning messages that appear in the installation wizard.

Reboot computer (I'm not sure if it necessary).

Open VSCode, an error message will appear that it cannot find Code.exe and if you want to look for the file manually, close that message window.

Uninstall VSCode

Reinstall VSCode, no warnings should appear this time.

Apparently Code.exe gets removed by the installation process if you ignore all the warning messages.

@abdllhbyrktr The background update caused this problem for me too. When I closed VSCode a background update window popped up and then crashed, I couldn't open it after that nor remove Code.exe manually.

Same issue just happened during an auto-update on my vsc. (win 10 v1909)

I am having the exact same issue

Having this issue now as well. Is there no resolution?

Having this issue now as well. Is there no resolution?

I wasn't ever able to find one, albeit, I haven't tried in months. I started a new job, and VS Code isn't an approved IDE there, so I haven't had a reason to try to fix it.

I got it to work by starting the computer in safe mode, and even though I was administrator and had this problem, for some reason this gave me the ability to delete Code.exe, and then reinstall. Really annoying problem, and I still have no idea what the real problem is, other than that it was connected with a background update.

Uninstall
Registry cleaner
Restart
Delete the entire folder
Download the newest version
Fresh install  (no errors)

Note: Make sure to extract your userSettings.json if you have any so afterward it'll be the like the issue newer even occurred. same icons, same color schema, same theme, etc.

Wow, working in vs code. closed vs code. vs code tried to update and BOOM "access denied" permissions failure. Why? Because of a microsoft security measure. I go to fix ownership and BOOM code.exe inside directory is missing a container ... WHAT AM I TO DO NOW!

I had the same issue, and the Sade Mode method did work. Microsoft should probably fix this?

Having the same issue - this is the second time that inno_updater.exe wasn't able to work fully, and it wasn't possible to uninstall; code.exe and inno_updater.exe cannot be deleted - even after a reboot.  I love code, but the updating always seems to be a pain on Windows (it seems OK on macOS, but it always seems a bit janky as it runs at odd times).

Same issue here: automatic updater did stuck on code.exe that could not be replaced.  Aborted installation.   Manually un-installed using the add or remove program.  Then ran VSCodeUserSetup-x64-1.47.2, still same issue.  So aborted again.  Went to C:\Users\pthivierge\AppData\Local\Programs\Microsoft VS Code using a file explorer with administrative right, deleted code.exe, AND AFTER BEING DELETED, F5 to REFESH AND CODE IS COMING BACK!  realised that SYSTEM has a handle on the file !??? I'll try to reboot.  Perhaps some mecanism I don't understand in the user folder.  I'll give it a shot with the SYSTEM installer instead, my guess is this could work in a more standard way as it requires more rights to be installed...

@pthivierge - that's exactly what I saw.  I rectified it by booting in Safe Mode, and then deleting the file from there.  Then I could reboot normally and reinstall.... until the next update!

I have had this issue on two computers now. The best way I found to fix it was:

Uninstall VS Code
Clean registry with CCleaner, Glary Utilities, etc
Reboot into Safe Mode
Delete %localappdata%\Programs\Microsoft VS Code*
Reboot into full Windows
Install VS Code System

If you had issues deleting the VS Code folder in safe mode you will need to create a bootable drive and delete it from there. Below are some links to help you with this process.
https://support.microsoft.com/en-us/help/15088/windows-10-create-installation-media
https://www.tenforums.com/tutorials/21756-boot-usb-drive-windows-10-pc.html#option1

Having the same issue presently


Docs: Correct branding and coin name in all the docs

Rebased to include patch removing all trailing whitespaces from all the docs


add configuration for prost and prost_types paths

Motivation
Allowing users to configure the prost and prost_types paths lets crates "wrap" prost as an implementation detail. This is particularly useful for crates that attempt to expose a "framework" for rpc services. For instance, tonic could reexport prost and set this to use ::tonic::prost, and users of tonic would not need to depend on prost directly.
Solution
Added two new configuration methods and fields to Config: prost_path and prost_types_path. These default to ::prost and ::prost_types, respectively.
If prost_path is changed from ::prost, a new attribute is added to structs: #[prost(path = "the_new_path")]. This is used in prost-derive in order to use the correct path.

Is this what tonic wants to do?  My experience with building applications with tonic and prost is that custom code generation options are usually required (using prost_build::Config), and at that point it's going to be an impediment that the API split is duplicated and obscured. I can see this being a very slight win for 'hello world' minimal setup examples, but personally I think that's not a useful thing to optimize for.

Is this what tonic wants to do? My experience with building applications with tonic and prost is that custom code generation options are usually required (using prost_build::Config), and at that point it's going to be an impediment that the API split is duplicated and obscured. I can see this being a very slight win for 'hello world' minimal setup examples, but personally I think that's not a useful thing to optimize for.

No, sorry! I didn't mean to speak for tonic here, I just thought it was a good example.

I can see this being a very slight win for 'hello world' minimal setup examples, but personally I think that's not a useful thing to optimize for.

That's a fair point. This might be optimizing too much for app setup instead of realistic long-term use cases.

I have a related issue with this using tonic https://github.com/hyperium/tonic/issues/699#issuecomment-875975780.
::prost expects prost to be in the same package that compiles protos. In my case, prost is imported from another package, and this causes the module not to be found.

I read the pr (https://github.com/tokio-rs/prost/pull/147) that addresses this, but Rust-2018 equivalent of ::prost would be crate::prost?

Any chance of getting this addressed?

@wycats can you give a bit of color around your usecase/motivation?  My thoughts are the same as what I wrote in https://github.com/tokio-rs/prost/pull/488#issuecomment-864586915, ie this is a nice-to-have for the simplest of getting started usecases, but ultimately users will need to pull in prost on non-trivial projects anyway.  If there's something I'm overlooking I'm glad to hear it, though.

Fixes #939


HELM evaluation framework tries to generate with temperature=0 which leads to inf tensors

HELM evaluation framework tries to generate with temperature=0 which leads to inf tensors error.
I don't have much idea how LLM will react to adding 1e-9 to the temperature value but this would avoid the error here.

        # forward
        logits = model(x, max_seq_length, input_pos)
        logits = logits[0, -1] / (temperature + 1e-9)

Do you know why is that? It's very strange. Do you have any links?

I don't have any link, unfortunately! I tried printing the input request where the temperature was set to 0.

Weird assumption: this framework relies on this additive in the denominator part and thus wants to use the lowest possible temperature so during sampling the logits with the highest probability will be outputted.
Though not sure how useful this information is 🙃.

thanks for finding this @carmocca! It seems that neurips client doesn't have this condition to the raw request - https://github.com/stanford-crfm/helm/pull/1693/files#diff-a9de0c80d20516c09d5131d26c59dfdab923a2c7cfd2e09b8814e9bc4bd7521eR47

https://github.com/stanford-crfm/helm/pull/1693 will close this issue


Fix gohm balance in fuse

sohm <-> gohm
add info tooltip -> toggle to switch between staking to sOHM or staking to gOHM


[OTHER]: (Feature request) nano-bind bazel support

pybind11 has an official bazel wrapper for the repo.
Currently, there is a community solution that is inspired by the same approach, here.
Is it possible to link the implementation or have the two projects under the same GitHub organization for more visilibity?
I believe that will help the community to come together and contribute in the same way.
I am curious about your thoughts on this.

The implementation is linked in the documentation here: https://nanobind.readthedocs.io/en/latest/api_cmake.html (First bullet in the list)
Granted, it's not very visible because it is given as a small reference in the CMake document, which is decidedly not where you'd look for Bazel support. I could offer contributing (and maintaining) a dedicated document on Bazel in the nanobind documentation if @wjakob is interested.

Certainly, I'd be more than happy to host a bazel tutorial here as well. However, I do not plan to create a GitHub org or similar for the nanobind repo, if this is what @MAminSFV .
By the way, this is not an issue. Please do not open issue tickets for things that aren't an issue. What you meant to create is a discussion post.

I do not plan to create a GitHub org or similar for the nanobind repo, if this is what @MAminSFV was asking for.

@wjakob
Thank you for the explanation.
Having a dedicated Bazel document will be beneficial and works as suggested by @nicholasjng and it is much appreciated.
I can also help by preparing a PR in the same fashion as it is done in the pybind docs and ask for your review.

By the way, this is not an issue. Please do not open issue tickets for things that aren't an issue. What you meant to create is a discussion post.

Thank you for pointing this out, I was not aware of this tab.
I will use that section from now on.


Export common traits in rand in ark_std

This is a draft PR. More changes that handle #20 would appear soon.

The current change is to export the interfaces for 0.7 and 0.2, both old versions.
There will be three steps:
(1) merge this.
(2) modify the downstream to use this instead of rand.
(3) bump the version up from here.

@Pratyush I don't have permission to this repo and need you to take a look.
By the way, this repo does not have many nice GitHub properties, such as the lovely labels or reviewers.

Passed the CI.


[rtext] Font loading and export, codepoints never filled with unique entries.

Using the ExportFontAsCode(font, "/Users/user/project/FontTestExport.h"); function noticed that my codepoints array is never filled with unique entries but rather with any character encountered.
So looked into raylib fn LoadCodepoints() and indeed it stores any character even if given multiple times, which means they all get loaded or exported as often they appear in the array, multiple times. Thinking the fn was not intended to be used on plain utf8 encoded text but on selective collections of characters. Then started searching for an appropriate function out of raylib that would really just expose unique codepoints and could not find one.
Am i doing it wrong or is it indeed a missing feature?
Meanwhile wrote down a function supporting unique codepoints. Meant to really just load characters in fonts that are needed by getting rid of dublicates when creating codepoints. So that Re-allocate buffer makes even sense, in the former LoadCodepoints Function it would just reallocate but with the same size as before, as it never gets rid of dublicates.
bool ContainsCodepoint(int *codepoints, int count, int search) {
    //TODO: might need codepoints==NULL check here.
    for (int has=count; has>0; has--) {
        if (codepoints[has]==search) return true;
    }
    return false;
}
int *LoadUniqueCodepoints(const char *text, int *count)
{
    int textLength = TextLength(text);

    int codepointSize = 0;
    int codepointCount = 0;

    // Allocate a big enough buffer to store as many codepoints as text bytes
    int *codepoints = (int *)RL_CALLOC(textLength, sizeof(int));

    for (int i = 0; i < textLength; i += codepointSize)
    {
        int uni = GetCodepointNext(text + i, &codepointSize);
        if (ContainsCodepoint(codepoints,codepointCount,uni)) continue;
        codepoints[codepointCount] = uni;
        codepointCount++;
    }

    // Re-allocate buffer to the actual number of codepoints loaded
    int *temp = (int *)RL_REALLOC(codepoints, codepointCount*sizeof(int));
    if (temp != NULL) codepoints = temp;

    *count = codepointCount;

    return codepoints;
}

please test.
For me this suggested fn improves quite a lot the loading process.
Example text "Hello World" contains already 3x"l". It should load only once the "l".

@designerfuzzi Actually that's the expected behaviour. The function is intended to convert an UTF-8 string into a Codepoint array.
You can check text_codepoints_loading example for an example on duplicates removal. That's up to the user for now but maybe at some point I add that function to raylib.

hmm. Maybe then the documentation line should express this behaviour. Yet it makes not much sense to allow fronts to load in "Hello World" the "l" three times by default.

@designerfuzzi I think the documentation is clear on its behaviour:
// Load all codepoints from a UTF-8 text string, codepoints count returned by parameter

It does not mention any filtering or ducplicates removal.


npmjs ownership

The ownership of this package on npmjs.com should be moved from me to the trackthis organisation.

This shouldn't be an issue as long as all the team members are added as owner to it on npmjs.com


Draft: Bjm/stiffened gas DO NOT MERGE

Sample MR for DEMONSTRATION ONLY
PR Summary
Adds the stiffened gas EOS to singularity

PR Checklist

[x] Adds a test for any bugs fixed. Adds tests for new features.
[ ] Format your changes by using the make format command after configuring with cmake.
[ ] Document any new features, update documentation for changes made.
[x] Make sure the copyright notice on any files you modified is up to date.
[ ] After creating a pull request, note it in the CHANGELOG.md file
N/A If preparing for a new release, update the version in cmake.

Disregard. This was a tutorial


Feature/demo

This PR was intended for preparation of the demo but i think we should probably keep the current changes so that the app is always deployable. E.g: login / accounts does not exist yet, so we should not have it enabled at all.

Yes, we should have only deployable, backend supported features in the UI.

I will need this branch further on to generate newer installers.
Could we rename it to cardano-sl-0.1 so it matches the backend branch?

@domenkozar the branch is not gone but merged into develop, you can branch off with cardano-sl-0.1 and continue there 😉
In general we tend to avoid to make other branches than develop / master the main branches.

As soon as we start doing releases (as of yesterday), we need to move closer to git-flow branching, which allows one branch per release cycle.


Destroy surfaces on client destruction (XDG shell)

Prevents accessing freed wlr_xdg_client_v6 from xdg_surface_destroy() after it has been freed.
Prevents segfault when closing weston-transformed.

Thanks!

I think this is a protocol error on the part of the client:

Destroying a bound xdg_shell object while there are surfaces still alive created by this xdg_shell object instance is illegal and will result in a protocol error.


Better model

Right now the model is trained from 5 ham and 5 spam cNFTs... should probably make this more like 500/500 or 5000/5000

it's a little better now (20/20) but not by much


Writing in markdown.

I noticed that when writing a text in markdown, line breaks are almost not possible.
It is only possible to make a writing block and to skip one or two lines to create another paragraph.
But I found out that in the css, you just have to remove the margin on the .content to get a better presentation of the text.

Hello @Dabs-Cedric
I have added the functionality to insert line-break as <br>. you can download the latest version and try it. thank you

Ok, thanks.


fix release-5.2 missing br unit test

replay test ci (ut from base-branch release-5.2 latest merged pr https://github.com/pingcap/tidb/pull/34029)
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/46062/pipeline


bug: Dragged item should keep elevated z-index while animating back to it's placeholder location

This may not necessarily be a bug, but it seems odd to me.
While a grid item is being dragged, it's z-index value is set to a high value (1000) to visually layer it on top of the other grid items. Immediately upon releasing the drag, the z-index value is restored to it's default value, and the grid items layer according to natural DOM order.
This places the dragged item animating back to it's placeholder location behind other items that came after it.

In my opinion, the dragged item animating back to it's placeholder location is still "more important" than the other grid items until it's drag [visually] fully completes and should therefore keep it's high z-index value until the animation/transition ends.
Like this:

This keeps the visual behavior consistent for any dragged item --> a user not aware of DOM order layering may very well question why the animating dragged item sometimes is over top of items and sometimes not.
This issue about adding a CSS class for the animating to placeholder state could easily help solve this.

Thanks for the nice report!
Yes, it is a visual bug, dragged item should be on top until animations ends.
I see you posted a feature that could resolve this: https://github.com/katoid/angular-grid-layout/issues/5
I agree with that feature & the proposed code from Angular Material. The way they solve it is totally fine, an I am sure it is bullet prof.
Do you want to do a MR with the solution @Achilles1515 ? The name of the class could be ktd-grid-item-animating or ktd-grid-item-dragend.


Enable overwriting of property uaa.require_https

The uaa job defines a property require_https, which could be
used to configure the uaa to accept only https requests (plaing
http requests are then redirected to https).
This patch adds the require_https property to cf-properties.yml,
so that it could be overwritten in a configuration stub file.
The default is set to 'false' to keep the current default
behaviour of the uaa job if the property is missing.

Regarding the CLA request: I am working for SAP and AFAIK there should be a corporate CLA in place. Let me know if this is not the case or if I should provide some further details.

@krumts I believe you need to make your membership of the SAP github organization public.
@chipchilders Can you confirm if the SAP github org is configured in dreddbot.

@krumts I believe you need to make your membership of the SAP github organization public.
Thanks for the hint! I made my membership pulbic, it wasn't hidden by intent.

@dieucao AFAICT, SAP doesn't have a GH org configured. @krumts is there a GH org that you are part of for tracking SAP employees authorized to contribute to CF?

I have emailed Sanjay Patil from SAP to get this setup.

SAP is not cleared to contribute code. Please accept this PR if there are no technical issues with it.

Hi there!
We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.
The current status is as follows:

[ ] #99824326 Enable overwriting of property uaa.require_https

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

Hi @krumts,
Thanks for the PR.  I think it's better to avoid having defaults in templates, because there becomes too many places for these defaults to live (manifest stubs, manifest templates, job specs, job templates, source code...).  The UAA job spec should specify defaults (or handle null values gracefully); I've raised this issue here.
You can change the value to null or ~ in the template; this still supports overriding but lets the job spec determine the default (if any)

Sorry for the long delay in responding to your PR.  I will close this PR due to inactivity for now, but if you wish to make the above suggested fixes and re-open the PR, we will respond promptly.

@Amit-PivotalLabs
Hi Amit,
thanks for looking into my PR. I made the proposed changes (use ~ instead of defaulting to false) and merged them in my branch krumts:enable_uaa_require_https. I can't figure out to reopen this pull request. Shall I create a new one?

Hi Krum,
Yup, a new PR would be great.
Thanks,
Amit
On Wed, Aug 5, 2015 at 2:46 AM, Krum Tsvetkov<EMAIL_ADDRESS>wrote:

@Amit-PivotalLabs https://github.com/Amit-PivotalLabs
Hi Amit,
thanks for looking into my PR. I made the proposed changes (use ~ instead
of defaulting to false) and merged them in my branch
krumts:enable_uaa_require_https. I can't figure out to reopen this pull
request. Shall I create a new one?
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/cf-release/pull/654#issuecomment-127937881
.

Hi Amit,
I created https://github.com/cloudfoundry/cf-release/pull/763
Regards,
Krum

Thanks Krum,
Looks good. If you follow the pivotaltracker.com link from the bot in your
new PR, you can see it's been prioritized in the backlog.
Best,
Amit
On Monday, August 10, 2015, Krum Tsvetkov<EMAIL_ADDRESS>wrote:

Hi Amit,
I created #763 https://github.com/cloudfoundry/cf-release/pull/763
Regards,
Krum
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/cf-release/pull/654#issuecomment-129424990
.


Support non-flat directory structures (especially regarding ocr-d interoperability)

As already proposed in #160 it should be possible to work with non-flat directory structures, especially regarding interoperability with ocr-d.
The first and probably essential step would be to rewrite the way direct requests work. Instead of supplying as single bookpath, direct requests should expect e.g. a map of images with image variants (+ possibly additional information).
When this is implemented writing a module which reads e.g. image variants and segmentation from an ocr-d METS file and passing it on to LAREX should become a lot easier than with our current implementation.
This would also allow the enhancement for OCR4all described here.

Above described ability to directly read images / XML files from ocr-d METS files (as well as an overhaul of the data structure required for direct requests) was added in d675aab

I have just started testing the new dev with all the new features (book import dialog with page selection and METS support, preserving PAGE reader/writer, metadata editor, book reload, fullscreen, image rotation etc). It's absolutely awesome! (Sorry I did not find the time for participating with reviews and tests earlier.)
However, there seem to be some issues with the METS support. I am still trying to fully grasp why my OCR-D workspaces won't open, but the following block in the library view seems odd:
https://github.com/OCR4all/LAREX/blob/8ccd341923c190198c4a12bb690953a2d078df8f/src/main/java/de/uniwue/web/controller/ViewerController.java#L249-L268
I wonder:

why determine the type (PAGE vs image) via filename extension (and not MIME type), and why only by looking at the first file? (I would assume the MetsReader parses the structMap for physical pages, and then gets a single file from the chosen fileGrp per pageId. That file should be a PAGE if possible, but could also be an image – if no annotation exists for that pageId in that fileGrp yet. What makes matters worse is that by OCR-D spec there can be  PAGE files as well as derived images in the same fileGrp – the latter for AlternativeImages of that PAGE. See OCR-D core for an implementation – just ignore the multi-fileGrp semantics.)
why combine the image file path from the PAGE path plus the /PcGts/Page/@imageFilename or //AlternativeImage/@filename, contrary to what the comment says (metsXml.root instead of pageXML.parent), and contrary to the OCR-D spec, which says image paths are relative to the METS and not relative to the PAGE location? (If this is intentional, you are not alone: PageViewer uses the same convention. But it does make life very difficult for OCR-Ders.)

LAREX used to have an inconsistency around the image path resolution:

when reading pages, it would use the filesystem path (image suffix in the flat directory structure)
when writing pages, it would use the @imageFilename path (which could be different)

I have not even looked at the writing side for now. But I can imagine it is difficult to get consistency when you want to support both the old flat and the new METS bookpaths.

why combine the image file path from the PAGE path plus the /PcGts/Page/@imageFilename or //AlternativeImage/@filename, contrary to what the comment says (metsXml.root instead of pageXML.parent), and contrary to the OCR-D spec, which says image paths are relative to the METS and not relative to the PAGE location?

Looking more closely, the current implementation is neither the one nor the other (PAGE directory or METS directory), but a different beast: the PAGE directory's parent. Of course, the latter two often coincide, but as soon as the PAGE lives in the root level, or in a directory deeper than one level below the METS, then it won't work.

Another observation is that the order of the bookpath in the library view has changed. It used to be sorted alphabetically (which is best for many purposes I guess), but not looks random. Ideally, we could click on the column titles to have it sorted by name or date...

Something seemed to have gone wrong during one of the last pushes into dev, this worked prior to this and I can reproduce it in the current dev. @chaddy314 or me will try to fix this ASAP.
Thanks for the report and sorry for the inconvenience.

why determine the type (PAGE vs image) via filename extension (and not MIME type), and why only by looking at the first file? (I would assume the MetsReader parses the structMap for physical pages, and then gets a single file from the chosen fileGrp per pageId. That file should be a PAGE if possible, but could also be an image – if no annotation exists for that pageId in that fileGrp yet. What makes matters worse is that by OCR-D spec there can be PAGE files as well as derived images in the same fileGrp – the latter for AlternativeImages of that PAGE. See OCR-D core for an implementation – just ignore the multi-fileGrp semantics.)

Internally MIMETYPE of each fileGrp is already being processed in MetsReader. Having MIME as an extra parameter for directrequest would indeed be a cleaner solution. Especially if the possibility exists that images could  be in application/vnd.prima.page+xml

Looking more closely, the current implementation is neither the one nor the other (PAGE directory or METS directory), but a different beast: the PAGE directory's parent. Of course, the latter two often coincide, but as soon as the PAGE lives in the root level, or in a directory deeper than one level below the METS, then it won't work.

This seems to be an overlooked relic from the early stages  of the implementation and will be fixed ASAP.

Another observation is that the order of the bookpath in the library view has changed. It used to be sorted alphabetically (which is best for many purposes I guess), but now looks random. Ideally, we could click on the column titles to have it sorted by name or date...

Alphabetical sorting will be pushed soon to the current pull request. Sorting by column is a really nice suggestion I'm considering implementing after this upcoming release.
Thanks for the detailed report!

Sorting by column is a really nice suggestion I'm considering implementing after this upcoming release.

Using something like DataTables should make this pretty easy.

@bertsky Could you send us the OCR-D workspace which failed to open for you so that we could test it locally? :grin:

@maxnth unfortunately, I don't have it anymore. I'll recreate it and test out the new RC myself (but not before Aug 16, sry)

Note: spaces and dots in the directory of the book will also break the METS reader.


Poseidon rework

Poseidon Rework
Description
Poseidon Rework to make it easier to audit, and viable for use in the prover. Closes #263
Type of change
Please delete options that are not relevant.

[x] New feature

Codecov Report

Merging #485 (ae435af) into main (8fcd64f) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   94.37%   93.73%   -0.64%
==========================================
  Files          65       62       -3
  Lines        8715     8513     -202
==========================================
- Hits         8225     7980     -245
- Misses        490      533      +43

Impacted Files
Coverage Δ

crypto/src/hash/poseidon/mod.rs
0.00% <0.00%> (-90.48%)
:arrow_down:

crypto/src/hash/poseidon/parameters.rs
0.00% <0.00%> (-70.84%)
:arrow_down:

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Poseidon has been finished, this is no longer needed


[stable/gcloud-endpoints] Deprecating Chart.

What this PR does / why we need it:
As discussed in #2149, this Chart is not working for a very long time now and nobody seems to be picking up the slack. Therefore, I think it's warranted to deprecate this chart. I followed the steps outlined in PROCESSES.md at the root of the charts repository.

/assign @linki
/assign @unguiculus

Of course, the CI fails...

Was trying to push it directly but couldn't since master is now protected.

/retest

/lgtm


update Zenodo badge to generic version

According to the settings page on Zenodo, this badge image and DOI link will always resolve to the latest respective version.

This is pretty uncontroversial and it would be nice to have the correct badge showing... merging without review.


Handle config file and add additional validations

This pr
-Supports migration of  existing keys/token of providers to the newly created provider config file.
-Checks properties and data types mismatch.
-New flag to use custom source/provider config file, as default is created and used.

Before merging => check if https://github.com/projectdiscovery/cloudlist/pull/40 can be applied to subfinder for providers

Closing as this issue has been resolved with alternate logic in subfinder project.