Adds yarn, updates travis to install using yarn

Yarn does not yet jive with bower, when it does this build step will be removed: https://github.com/yarnpkg/yarn/pull/896
Added gulp-imagemin optional dependencies
closes #245
@chriskacerguis @himdel

@chriskacerguis Looks like this a done deal.
So going forward would we be using yarn instead of npm?

Hi @AparnaKarve yes, that is correct (the readme is updated).

@AparnaKarve you're correct, yarn or yarn install will now be the way to setup dependencies
We aren't exactly using yarn instead npm.   npm is still very much involved in the app, you could think of yarn as an package.json manager.

@AllenBW I'm seeing a error npm-shrinkwrap.json found. This will not be updated or respected. See [TODO] for more information. - we should probably reflect what's in shrinkwrap to yarn.lock and remove that shrinkwrap...
And another thing, should we remove scripts.install & scripts.postinstall from package.json now?  Feels like we shouldn't be using npm-specific scripts if we're not using npm..

@himdel Thanks for the feedback!! So first point, do we need the shrinkwrap anymore? (After removing the file and running yarn install again)gulp templatecache operates as expected, updating the dependencies likely resolved this isssssssssssuuuuueeeeeeee. 🌮
☝ so you mind if i axe the file in question?
Second point, SO a cool thing yarn does is yarn run foo where foo can be the name of any script we have in our package.json.... the bummer is right now it doesn't quite work (see https://github.com/yarnpkg/yarn/issues/1156) , but IDEALLY I would like to keep the scripts there, and references them in the future rather than rewrite them all the places they are required

Right.. looking at the issue that caused us to have npm-shrinkwrap in the first place (https://github.com/tracker1/gulp-header/issues/37), it's resolved and probably only affected gulp-header 1.8.3, so 1.8.8 should be fine.
So feel free to completely and utterly destroy npm-shrinkwrap.json ;).
And if the scripts are planned to be supported, then sure, let's keep them :)


add read_reddit.py

Description

Checklist
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

add read reddit file

I changed the read_reddit.py
https://github.com/wangxiaoyunNV/dgl/tree/master/examples/pytorch/cugraph_graphsage


Allow results to be sorted alphabetically by first name

This would make scorecard checking much easier.

Just so you know: there's a dedicated double-check screen, which makes it straightforward as long as you put scorecards on a pile as you do dataentry. If you still believe sorting makes sense, we can obviously add a that!

That's awesome!
Sorting would still be useful to prevent using CTRL+F hundreds of times.

Fixed in 060b73af7c81f5101dc90475a35ba78a3ed6a315.


Issues with brotli content encoding

Compressed inscriptions are not being displayed in certain cases.
I've seen this personally on ordinals.com, and locally on regtest with Safari. Firefox and Chrome both seem to work.
This is odd, because caniuse suggests that brotli is widely supported.
This might have to do with cloudflare monkeying around with the accept-encoding header.

I submitted a support ticket to Cloudflare, hopefully they get back to us soon.

Here's a JS inscription that works on ord.io but not on ordinals.com. Surprisingly, the inscription you linked (e81abf9041d3842757d537316d26f2d97f79dcfa7dbe4dcc949c957aa1db30afi0) doesn't work on ord.io either.
This works.
https://www.ord.io/45219844
https://ordin-delta.vercel.app/content/6dc2c16a74dedcae46300b2058ebadc7ca78aea78236459662375c8d7d9804dbi0
This doesn't work.
https://ordinals.com/inscription/6dc2c16a74dedcae46300b2058ebadc7ca78aea78236459662375c8d7d9804dbi0

Even if cloudflare stop messing with the headers, this is still an issue for ord running on http ports. Browsers apparently only support brotli on ssl connections.

Boy, that's annoying 😅

@casey I know you mentioned not wanting to uncompress on the server side, but maybe that can be a flag instead.
i.e -uncompress-when-no-encoding-match

Yeah, just thought it could possibly be messing with this. Would love to see this fixed soon, especially as the fees have remained ridiculously high in recent days.

Next thing to try: Include the value of the Accept-Encoding header in the inscription content type not acceptable error, so we can see what exactly cloudflare is sending in the request. I've been talking to Cloudflare technical support, and they seem to think they're sending the right header.

If there are no known brotli-bomb exploits, can we please consider running ordinals.com with the new --decompress flag until this is fixed?

I think we would very quickly get a brotli-bomb, and have to turn it off, which would suck.

Fair enough. Hope this gets sorted out soon!

Even if cloudflare stop messing with the headers, this is still an issue for ord running on http ports. Browsers apparently only support brotli on ssl connections.

I don't see this on chrome and a local ord server w/ brotli compressed ordinals
works fine for me over http

Hi all, just wondering if there's any update here. We're launching on Monday and use Brotli for our SNES emulator and many other parts of the project. Wondering if it's been considered to create a decompression ratio limit to avoid Brotli Bombs? For example, if the inscribed file is 1 kb, perhaps limit decompression to 1 MB or 2 MB?

To give an update on this: We have a man on the inside at Cloudflare, and he was able to confirm that this is a Cloudflare issue. Brotli decompression should have rolled out to us by now, but for some reason it hasn't, so it's definitely a bug with Cloudflare.

Wondering if it's been considered to create a decompression ratio limit to avoid Brotli Bombs? For example, if the inscribed file is 1 kb, perhaps limit decompression to 1 MB or 2 MB?

Unfortunately, the brotli library doesn't provide a way to limit the size of decompressed data.

Thanks Casey, and just to confirm, this is not the issue?

Yeah, this isn't the issue. The setup looks like this:
client <-> cloudflare <-> our backend

This setting controls whether or not cloudflare returns brotli compressed responses to the client. But the issue we have is that cloudflare isn't accepting brotli compressed responses from our backend.

One temporary solution could be to add a new flag --decompress-before-block to apply it only to inscriptions created before a specific block height. That way, ordinals.com can run with that flag without the risk of a brotli bomb.

Would that temp solution only apply to new collections? Yea this bug is affecting me i believe my stl test inscription is able to be viewed fine on ordinal novus i inscribed back in November (35363385 have to zoom in a lot) but i get this error when trying to view the ones i compressed with brotli (ordinal novus is in beta but only one i know of that can view stl files, ord.io and ordinals.com just show blank screens)
{
"status": 500,
"body": {
"error": "Unexpected error occurred"
}
}

I think --decompress-before-block would be confusing, since it wouldn't be clear why some compressed inscriptions worked and some didn't.

@casey Totally agree. I thought it could be updated on a weekly basis or so, after checking all br inscriptions, and can be removed once cloudflare fixes the issue. So, this would just be a stopgap until then.

Brotli now works on couldflare!


LightGBM does not comply with sklearn's check_is_fitted

Environment info:
Operating System: Windows 10
CPU/GPU model: Processor	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, 2112 Mhz, 4 Core(s), 8 Logical Processor(s)
C++/Python/R version: 3.7.4

LightGBM version or commit hash: 2.3.1
Error message

sklearn.exceptions.NotFittedError: This LGBMClassifier instance is not fitted yet. Call 'fit' with appropriate arguments before using this estimator.
Reproducible examples

see below
Steps to reproduce
import lightgbm
lgbmc = lightgbm.LGBMClassifier()
lgbmc.fit([[1,2,3], [4,5,6]], [0, 1])
from sklearn.utils.validation import check_is_fitted
check_is_fitted(lgbmc)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\rolutz\AppData\Local\Continuum\anaconda3\lib\site-packages\sklearn\utils\validation.py", line 967, in check_is_fitted
    raise NotFittedError(msg % {'name': type(estimator).__name__})
sklearn.exceptions.NotFittedError: This LGBMClassifier instance is not fitted yet. Call 'fit' with appropriate arguments before using this estimator.

@romanlutz
Can you please clarify the versions of packages?
My ones are 2.3.1 and 0.21.3 and I get the following error runnig your code:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-3-e108069c5d34> in <module>
----> 1 check_is_fitted(lgbmc)
TypeError: check_is_fitted() missing 1 required positional argument: 'attributes'

Which indicates the wrong way of usage.
Adding required argument I have no errors:
check_is_fitted(lgbmc, ['classes_'])

OK, seems the problem is in that in 0.22 version scikit-learn again changed API silently. Now attributes=None argument is optional.
Anyway, with a fix above works fine with new versions (2.3.2 and 0.22.1) as well.

Wow, thanks for your quick response!
I used scikit-learn==0.22.1, but even with the last released scikit-learn version (0.22.2.post1) I still get the same error
sklearn.exceptions.NotFittedError: This LGBMClassifier instance is not fitted yet. Call 'fit' with appropriate arguments before using this estimator.
I can confirm that I'm getting the same TypeError that you got when I downgrade to 0.21.3
Looks like it became optional with this change about 4 months ago: https://github.com/scikit-learn/scikit-learn/pull/15947/files

I used scikit-learn==0.22.1, but even with the last released scikit-learn version (0.22.2.post1) I still get the same error

Weird!
I just installed scikit-learn from conda and lightgbm from nightly artifacts and have no problems...
import lightgbm
print(lightgbm.__version__)
lgbmc = lightgbm.LGBMClassifier()
lgbmc.fit([[1,2,3], [4,5,6]], [0, 1])
from sklearn.utils.validation import check_is_fitted
check_is_fitted(lgbmc, ['n_features_'])
from sklearn import __version__ as sk_ver
print(sk_ver)

2.3.2
0.22.1

I don't see the issue with
check_is_fitted(lgbmc, ['n_features_'])

either (regardless of the version I'm using), but if you remove the second argument it shows up. I guess I'm not familiar enough with LGBM to tell, but shouldn't it work without that extra arg?
From what I understand about check_is_fitted is checks whether all attributes with trailing underscore are set, which they should be after fit. @adrinjalali can perhaps correct me on this.
Is that not the case in LGBM?

The part which does the check in sklearn is:
    if attributes is not None:
        if not isinstance(attributes, (list, tuple)):
            attributes = [attributes]
        attrs = all_or_any([hasattr(estimator, attr) for attr in attributes])
    else:
        attrs = [v for v in vars(estimator)
                 if v.endswith("_") and not v.startswith("__")]

    if not attrs:
        raise NotFittedError(msg % {'name': type(estimator).__name__})

And the issue is that LGBMClassifier has opted for storing the actual values in _attribute (_n_feautres for instance), and define all attribute_ as a @property, and properties are not listed in vars(obj). Properties can be very expensive to check and call, so I'm not sure if it's a good idea for sklearn to include them in the check.
Also, these @propertys in LGMBClassifier raise a LGBMNotFittedError instead of an AttributeError, and I remember some versions of python would raise instead of returning False on a hasattr(obj, 'attr') if that attribute would not raise an AttributeError.
@ogrisel @rth @NicolasHug WDYT?

I used scikit-learn==0.22.1, but even with the last released scikit-learn version (0.22.2.post1) I still get the same error

Weird!

On the contrary - rather than upgrading the environment, you need to pin all packages used by LightGBM, including sklearn to old versions from 6 months ago when the "current" (latest) LightGBM release was built. There are more and more API discrepancies with the recent versions of sklearn...
@StrikerRUS : a release is long overdue...

@mirekphd

On the contrary - rather than upgrading the environment, you need to pin all packages used by LightGBM

Please refer to #2987 for the discussion about pinning dependencies.

a release is long overdue...

We are preparing v3 release: #3071.

Hello @adrinjalali !
Have scikit-learn team made any decision for using properties as indicators of fitted estimators: https://github.com/microsoft/LightGBM/issues/3014#issuecomment-618056991?
Also, it looks like internally some scikit-learn estimators uses properties for some attributes (coef_, intercept_, n_iter_, for instance). Does it mean that they are incompatible with scikit-learn tools which use check_is_fitted?

https://github.com/scikit-learn/scikit-learn/blob/e770715c434739647ddbb645ff0fcd40c64ba1fd/sklearn/svm/_base.py#L489-L505
https://github.com/scikit-learn/scikit-learn/blob/3561802bdc9e3a32492c3ce9d8943e9a85519a7f/sklearn/naive_bayes.py#L652-L663
https://github.com/scikit-learn/scikit-learn/blob/0cfe98b9f81463143675793e5b4b11268b2cf857/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py#L770-L773

Hi,
Is this problem already fixed?
I use LightGBM version 3.0.0, and scikit-learn version 0.23.2.
When I try to run the code in the section "Steps to reproduce", from @romanlutz, I still get the NotFittedError error (sklearn.exceptions.NotFittedError: This LGBMClassifier instance is not fitted yet. Call 'fit' with appropriate arguments before using this estimator).
Or, in order to fix this error, should we keep using the workaround check_is_fitted(lgbmc, ['n_features_']) ?

Hello @GlorianY !
The problem is fixed in the master branch. Unfortunately, the fix was not included in the 3.0.0 release. It will be in the next one. For now you can download wheel file from nightly build and install it: https://lightgbm.readthedocs.io/en/latest/Installation-Guide.html.


Stop plan parameter models converting to camelCase

Previously with #132, all config, API parameter and plan model parameter names were converted to camelCase when loaded externally (e.g. from JSON). So
class TaskResponse(BlueapiBaseModel):
    """
    Acknowledgement that a task has started, includes its ID
    """

    task_name: str = Field(description="Unique identifier for the task")

Would accept the following via the API:
{"taskName": "my task"}

and a plan like
def my_plan(foo_bar: str) -> MsgGenerator:
    ...

Would accept:
{"name": "my_plan", "params": {"fooBar": "qwerty"}}

This PR is speculative and a request for opinions. It reverts the second case, as it likely adds confusion. But also treating the two cases differently may add confusion. Any thoughts?

I would be in favour of this. Having the request format be able to take multiple forms just add confusion. eg how would it handle requests for
def demo(foo_bar: int = 42, fooBar: str = "42") -> MsgGenerator:
    pass

It's a slightly contrived example but I don't see the benefit to allowing variations in general.

If no one strongly objects I'm going to merge this, will make life easier for artemis purposes


[add-resource] New Plugin 'World Maps'

I would like to add my new plugin to the Grav Repository.
Here are the project details: https://github.com/Widebob/grav-plugin-world-maps

Added.. Thanks.

Hi Grav team !
The World Maps plugin have been updated to v1.0.1, is it possible to update the version from 1.0.0 to 1.0.1 in your plugin references ? The old one is not working.
https://github.com/Widebob/grav-plugin-world-maps
https://github.com/Widebob/grav-plugin-world-maps/releases/tag/1.0.1
Changelog and Readme can be updated too.
Thanks for all
Best regards

It will update automatically if you do the release properly.  It looks like you forgot to update your blueprint.yaml in the 1.0.1 release: https://github.com/Widebob/grav-plugin-world-maps/blob/1.0.1/blueprints.yaml
Still says 1.0.0

Ouh yes my bad !
Now at the 1.0.2 (readme improved). Thank you for it :)


Add some more runtime type support.

This makes u256 work in particular.

Another LGTM from me as well, thanks.


Set up tests for supported permissions

I haven't played with the UI testing in Xcode 7 yet but I expect we'll need lots of UI tests since permissions require user input. Hopefully we can automate this.
My preference would be something like this:

[ ] Run a set of UI tests that create a few dialogs with each of the permissions

[ ] Verify all permissions can be denied and detected as such

[ ] Verify all permissions can be approved and detected as such

[ ] Any tests that require devices (bluetooth, for one) can be hooked up to a device and run similarly (denied, delete/reset and then approved)

Resetting the simulator gives a fresh slate for permissions, unlike just deleting an app from a device. We'll have to figure out how to balance this with permissions that require a device.

The hackish way to re-request permissions on the device is to change the bundle id, we'd probably need to make a script to run the tests and also change the bundle in that case.

Good idea, that's an excellent way of testing on device/sim without having to reset content and settings :/

Sadly UIT doesn't support interaction with system alerts as far as I know...It'll be probably added by the time GM is released.

Ugh. I'll do some testing when Xcode 7b3 comes out and file some radars if we can't.

UI testing (iOS9+) bug when interacting with system alerts: https://forums.developer.apple.com/thread/11574


Unit Converter Project

Hello Sir,
I want to add my unit converter project in this repo.
Screenshot

Additional Context
Sir please assign me to this issue

@avinash201199 @Shu12388y Please assign me this issue

@apu52 start working


Create payment request

User story
As a moderator
I need a for for creating a payment request
So that I can register the details of recipient, amount, currency etc of a grant to be paid out to a recipient
Acceptance criterias

Verify that only moderators can access the UI
Verify that only moderators can access the contract methods for creating a payment request
Verify that the payment request is crated on the DAO contract

Overall acceptance criterias ( applies to each user story )

Verify that the UI implementation corresponds to the Figma design
Verify frontend automatic tests

Verify that there's an automatic playwright test visualized in an automatically generated screen recording
Verify that the tests covers relevant usage and misuse scenarios
Verify that the tests demonstrates how the UI is guiding the user in an intuitive way by providing validation messages and hints

Verify backend

Verify that the contract implements the data structure that represents the frontend
Verify that the contract implements the same verification mechanisms and validation messages as the frontend

Verify backend automatic tests

Verify that there are unit test on the detailed level covering multiple variants of input and expectations
Verify that there are integration tests using near-workspaces-rs for covering the scenarios of input and expected output from the frontend
Verify that the playwright tests interacts with a testnet contract, to show the full end-to-end flow

Before merge: Verify that the functionality, test coverage (as shown by the screen recording), is according to expectations of the product owner.

It's completed


add h5 handling module and tweak some imports

add routines for creating hdf5 groups and datasets

cc @mkitti

It looks you have not implemented the context manager yet or is there another issue?

I sidelined the context manager idea for now. Having access_h5 return a generator breaks the API too much when compared to access_zarr, so I'm just dealing with the chore of closing the underlying file object on the Dataset and Group

Do we have any known use cases where we might want to send keywords to h5py.File? Trying to split out the keywords adds a fair amount of complexity and increases the future the maintenance cost when keywords are added upstream.

In our current use, we primarily modify the dataset keywords and overall those are most subject to changes. There's a keyword argument for many of the builtin filters for example.
The h5py.File keywords are for advanced usage and for the most part h5py and HDF5 seem to select the best one given the platform:

None
Strongly recommended. Use the standard HDF5 driver appropriate for the current platform. On UNIX, this is the H5FD_SEC2 driver; on Windows, it is H5FD_WINDOWS.

The one file driver option that may be of interest is

‘ros3’
Allows read only access to HDF5 files on S3.

However, I suspect you might want to use Zarr for this case.
My recommendation is just to forward all keywords to the h5py.create_dataset. If someone wanted to use the advanced file driver keywords, they could could just call h5py.File with the needed keywords directly and pass that in as "container".

h5py.create_group has name and track_order parameters.
https://docs.h5py.org/en/stable/high/group.html?highlight=create_group#h5py.Group.create_group
These are both shared with create_dataset.
Via the current API, I think the easiest way to create a group would be just to pass in a string with path separators. h5py will automatically create the groups. I doubt that anything we are doing is going to depend on the creation order of the groups or datasets.

Here's a link that describes imod's use of HDF5 files:
https://bio3d.colorado.edu/imod/doc/hdf_format.html

In IMOD's implementation of HDF5 image files, everything is under a top group of "MDF" and a subgroup or "images".  Below that can be two different data organizations: a stack of 2-D images that are all the same size, or a set of one or more 3-D volumes that can be different sizes.

The X and Y dimensions are defined by the image sizes, which must all be equal.  The Z dimension is the number of images.
The mode is defined by the data type stored for bytes, short integers and floats.  Bytes are stored unsigned. RGB data are stored as unsigned bytes in a sequence of RGB triplets.  Complex data are stored as a float data type in a sequence of real, complex pairs just as in an MRC file.  They are also organized the same way as in an MRC file
Images are treated in IMOD as right-handed, with the first pixel at the lower left corner. Following the conventions of the HDF5 high-level image interface, this is indicated with an attribute "DISPLAY_ORIGIN" set to "LL".
For an image stack, the MDF/images group contains a sequence of groups named from "0" to "NZ-1", each with a 2-D dataset named "image".  Input files may have these groups in any order and may skip values, but these group numbers are considered to define the order of the images, starting with the lowest actual group number as Z = 0, and the highest one as Z = NZ -1.

It may be useful for us to support this virtually via soft links or virtual datasets.

hmm i don't think we need to support IMOD

We don't "need" to do it, but it would be an added bonus if we could. The only practical thing we would need to do is add a few extra attributes. Mapping the imod layout into our current layout via symlinks would be trivial and add little to the overall file size.

If you still really wanted to split keywords, perhaps splitting it the other way would make sense then. All keywords go to require_dataset or create_dataset by default, except for ones we specifically list.
The list of h5py.File keywords is:

driver
if driver == 'split'

meta_ext
raw_ext

if driver == 'ros3'

aws_region
secret_id
secret_key


us-va-gloucester

{
    "coverage": {
        "country": "us",
        "state": "va",
        "county": "Gloucester"
    },
    "website": "http://www.co.gloucester.va.us/GeographicInformationSystems%28GIS%29/tabid/692/Default.aspx",
    "note": {
        "email"<EMAIL_ADDRESS>        "phone": "804-693-1109"
    }
}

I can't access the map page without some sort of plugin. Looks like raster map. Need data.

Stale


Unable to start Ubuntu 20 LTS: The specified module could not be found

Environment
Windows build number: Microsoft Windows [Version 10.0.19041.450]
Your Distribution version: Ubuntu 20 LTS (I can't access WSL so I can't run the exact command, but it seems to happen in all distributions)
Whether the issue is on WSL 2 and/or WSL 1: WSL 2

Steps to reproduce

Run the wsl command

When attempting to run using Windows Terminal there's an error code as well:

WSL logs:
Expected behavior
WSL will start the Ubuntu 20 LTS distribution successfully.
Actual behavior
An error prevents WSL from starting correctly.
I have Docker installed which also does not start up correctly.

Uninstall Docker and do a re-install of VMM feature. See if WSL2 works afterwards. Then re-install Docker, be sure to NOT choose the WSL2 backend. If this works, then try using the WSL2 backend. If this fails, file logs for both Docker and WSL. https://docs.microsoft.com/en-us/windows/wsl/troubleshooting

Re-installing WSL 2 worked, thanks!

In electronic devices restarting things usually solves the unexpected bugs.
This solved for me after trying many things:
Windows Features on & off -> Disable Windows Subsystem for Linux -> Reboot -> Re-Enable Windows Subsystem for Linux


Fix optimizer cast

Fixes optimizer cast from flattened input to compiler input

Before version 0.8.6 omitting the 'enabled' key was not equivalent to setting it to false and would actually disable all the optimizations. When we compile the source code with Remix with optimization disabled, it still automatically uses false as a value for enabled key.
This PR sets enabled = false in case if optimization runs are omitted. That interface makes the verifier behavior consistent with Remix.
https://docs.soliditylang.org/en/latest/using-the-compiler.html#compiler-input-and-output-json-description


Patsy Formula capabilities

It would be nice to be able to feed in formulas on top of dask DataFrames similar to statsmodels; related: patsy issue #93

Just saw this pop up in the patsy issue I was surveying. How about even better, from blaze tables?


Teva 1414 bugfix improvements

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-1414
Changes in this PR:

Default target to dev (staging gets refreshed nightly with the same backup, so dev is more likely to be refreshed on demand).
Use setup-cf-cli action, as already in use on sync_staging_db.yml workflow
TRUNCATE alert_runs table during sanitisation

Review app deployed to https://teaching-vacancies-review-pr-2792.london.cloudapps.digital


The TesseractOCR/TesseractOCR.h can't found when add TesseractOCR.framework to existing project

I following the instruction to add the framework to my existing project, but get following error:
"TesseractOCR/TesseractOCR.h file not found"

i have installed pod 'TesseractOCRiOS', '3.1.1' but cant able to  "import TesseractOCR" @kevincon @lbwxly

@nitinumaretiya123 the latest version is 4.0.0, not 3.1.1. See the installation instructions at https://github.com/gali8/Tesseract-OCR-iOS/wiki/Installation.
If you're still having trouble after following those instructions, please create a new issue instead of commenting on an old issue like this one.


Harold rename maybe d to maybe ast

This PR is moot, as you've already pushed to main-AST (note that the PR tries to merge to main, which is not what you intended).  I suggest that you close this, and we forgive your sins.  This one time :smile:.

forgive me father, ...


Allow auto confirm for implode

It would be great if there was a flag I could set to auto confirm a Mix release.clean --implode.  While this is not something I would use in my day to day work, asking for a confirmation from my Jenkins build machine ( or any cl system) is difficult to work around.
Thanks for the awesomeness that is exrm!!!

Should be fairly trivial to add this as an enhancement. I'll add it to the TODO list!

This is now in master :)


feat: add support for job_options argument

In Que v1.2, it was deprecated to pass top level keyword args in the
enqueue method. This is to prepare for Que v2. This causes warnings
such as:
Passing job options like (tags) to `JobClass.enqueue` as top level keyword args has been deprecated and will be removed in version 2.0. Please wrap job options in an explicit `job_options` keyword arg instead.

The keyword arguments are: queue, priority, run_at, tags, and
job_class. These must be wrapped around the job_options keyword.

This is my first PR here. I believe this should be a minor version bump since the underlying gem que is being upgraded. Upgrading que to the latest v1, would require additional changes such as migrating the que database, so v1.2 is the acceptable minimum version for now.

Thanks so much for the contributions @bautrey37 and @indrekj! We're definitely on the right track here! It looks like some of the specs are failing, though. The test output can be a bit hard to read, but if you search for 7 failures you should be able to track them down. Mind taking a look? Happy to assist with debugging 😄.

@plantfansam Can you assist me? I updated the branch, and now the build checks that were there, are no longer there. What happened to them?

@bautrey37 I think your tests are failing because you haven't updated the Appraisals file

Hello, and thank you for your contribution!
We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib repo.
This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib. Sorry for the inconvenience!
To do that, you can:

Create a fork of opentelemetry-ruby-contrib and copy the git url
In your opentelemetry-ruby repo, run git remote add tmp-contrib <your-fork-git-url>
git push tmp-contrib your-branch-name
Open a new PR in contrib (feel free to just copy/paste your original PR description there)
Close your open PR in this repo with a comment that links to your new PR in contrib
Delete your tmp-contrib remote from opentelemetry-ruby (git remote rm tmp-contrib)
git clone your opentelemetry-ruby-contrib fork, check out your branch, and make all changes in that repo from now on!

Sorry again for the inconvenience, and thank you for contributing!

@plantfansam Thank you for the help. I've opened up the PR on the contrib repo. Can you take a look? Thanks.


spiffs_page_delete relies on 0 -> 1 transitions being ignored

I am working with a flash controller that does not like it when application tried to set bits from 0 to 1.
naturally, it's not possible, and most controllers just ignore it, but not this one - it raises an error for such writes, and I found that SPIFFS is a bit sloppy in this regard.
It seems that spiffs_page_delete tries to set the flags blindly, assuming that 0 -> 1 transitions will be ignored. Well, that is not always the case and SPIFFS should not assume this behavior of the underlying controller.

https://github.com/pellepl/spiffs/pull/173 is my quick whack at it. i'm not at all sure this is all that needs to be done, but tests are now passing without the "flags exemption".

Sorry for belated reply.
Transitions 0->1 being ignored is one of the main presumptions when writing spiffs. What flash controller is it? I have never stumbled upon one not allowing this.
I am deliberately sloppy here as, in my view, this is an optimization.
Looking at your fix I am actually a bit surprised, I think you covered it all. I thought there would be more cases.
What I would like to have is a config define around the readout as it will affect performance somewhat. At least to my experience, 99% of all flashes do not have a problem with ignoring 0->1.

controller is the one built into TI CC3220, but i think it's generic to TI (Tiva chips have the same).
it's described in chapter 21 of the TRM.
in particular, bit 10 of the FCRIS register is:
INVDRIS -- Invalid Data Raw Interrupt Status
...
1h = An interrupt is pending because a bit that was previously
programmed as a 0 is now being requested to be programmed as a
1.

and indeed controller refuses the write of any of the data loaded into the data registers tries to flip bits from 0 to 1.
yes, it saves a read. makes sense to make it a config option, sure.

what would you call the option? i'll amend #173.

Ummm.... That is a very good question. _CONFIG_READB4WRITE? I'm open to
suggestions. 😉

Off topic, but the CC32 flash, that is the internal flash rom you're referring to? Not anything external to the uC itself?

SPIFFS_CONFIG_NO_BLIND_WRITES ? with the default of 0, meaning blind writes are allowed and 0 -> 1 transitions are ignored.
yes, i'm using part of internal flash for the filesystem.

SPIFFS_CONFIG_NO_BLIND_WRITES ?
Splendid! Much better.
Ok, internal flashes seem to have more weird constraints in general. The
EFR only allows two writes to same address before one must erase IIRC.

@pellepl ok, please take a look at #173


Add toString method to GeoJson feature

Add toString method to GeoJson feature, this should be similar to KML feature.

Added toString function.


api: _* attributes preservation

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

To resolve possible overwrite of '_*' fields in https://github.com/inveniosoftware/invenio-records-rest/blob/master/invenio_records_rest/views.py#L574-L575
WDYT?

cc @lnielsen @jirikuncar

@hachreak please see https://github.com/inveniosoftware/invenio-deposit/pull/60

Coverage increased (+0.05%) to 98.034% when pulling e85e6b72f25b5d3f6ffecdf44ee6d2ed861226d4 on hachreak:update_clear_records into c60bc4626a0739c6c190c3ff09ca8ed49765510f on inveniosoftware:master.

could we use both?
The status is something specific for deposit.
The behavior "preserving _* fields" could be considered a general behavior for all kind of records?

Coverage increased (+0.08%) to 98.066% when pulling 3be1adde6ba92da0568d8a822a43abfb73a2aed8 on hachreak:update_clear_records into c60bc4626a0739c6c190c3ff09ca8ed49765510f on inveniosoftware:master.

It will prevent many low-level scripts and other dependencies to work correctly, hence I'm closing it for now.


show unconfirmed balance (unlocked and locked) in wallet/account pages

This is important. As currently one might be able to get quite some money back (because of unconfirmed refund coin outputs) but this is not shown in balance, only in the transactions list.

closed in https://github.com/threefoldfoundation/tfchain-wallet-electron/commit/388fe4baa6d8b8b8dccbc3f10e60b6b2702dae3e


[motion] Not support the spring of transition

Clear and concise description of the problem

can't Implement
Suggested solution

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

now supported. with version 0.4.0.


Link to or mention WSL2 Linux Containers - https://docs.microsoft.com/en-us/windows/wsl/tutorials/wsl-containers

I'm testing whether I can run a windows container and still run Linux containers (and or linux vms). The page in question describes setting up Hyper-V for Linux containers. I've also found a page that shows how to setup Linux containers using WSL2. https://docs.microsoft.com/en-us/windows/wsl/tutorials/wsl-containers.
It would be good to update this page to explain whether the Hyper-V linux container still applicable and link to the WSL2 setup.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51faeed1-77c1-c8c6-c097-6806a3bbdf85
Version Independent ID: 84597429-d2e1-71ed-ee5d-fd2d66dcbff7
Content: Set up Linux Containers on Windows 10
Content Source: virtualization/windowscontainers/quick-start/quick-start-windows-10-linux.md
Product: windows-server
Technology: windows-containers
GitHub Login: @taylorb-microsoft
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Linux-specific code in np/util/common

np/util/common.[ch]xx includes a few time-related functions that (currently) use some Linux-specific stuff (eg. clock_gettime).
Would a np/util/platform/linux.cxx, etc, be the preferred approach here?  Or ... ?

This issue was fixed in commit d8ac046 on 2014-09-01.


-x (audio only) on YouTube flag downloads both video and audio stream, which is slow.

If I use -x on YouTube, despite there existing separate video and audio streams, both get downloaded if you pass -x flag.

Carefully read new issue template and provide all requested information.


CliApp fails with ValidationError when field has underscore in its name

Hi, I ran into a really strange bug with pydantic==2.9.2 and pydantic-settings==2.6.1
The following snippet fails:
import pydantic
import pydantic_settings

class AlphaBeta(pydantic.BaseModel):
    field: str | None = None

class RunCLI(pydantic.BaseModel):
    alpha_beta: AlphaBeta = AlphaBeta()
    # alpha: AlphaBeta = AlphaBeta()

    def cli_cmd(self):
        print(self)

pydantic_settings.CliApp.run(
    RunCLI,
    cli_args=[],
)

I'm getting the following error:
ValidationError: 1 validation error for CliAppBaseSettings
alpha_beta
  Extra inputs are not permitted [type=extra_forbidden, input_value={'field': None}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden

while the following passes
import pydantic
import pydantic_settings

class AlphaBeta(pydantic.BaseModel):
    field: str | None = None

class RunCLI(pydantic.BaseModel):
    # alpha_beta: AlphaBeta = AlphaBeta()
    alpha: AlphaBeta = AlphaBeta()

    def cli_cmd(self):
        print(self)

pydantic_settings.CliApp.run(
    RunCLI,
    cli_args=[],
)

Any help is appreciated.

Thanks @ljendele for reporting this. Could you please test it on main? we have some unreleased changes that might fix your problem.

Thanks @hramezani! I can confirm that the issue is gone when installing from main. Feel free to close the issue.

Thanks @ljendele  for the feedback

The fix will be available in the next release


[Impl]Ptr-Ref wrapper implementation

Table of Contents

Code of Conduct
Proposal Implementation

Code of Conduct
This project has adopted the code of conduct defined by the Contributor Covenant
to clarify expected behavior in our community. For more information, see the .NET Foundation Code of Conduct.
Proposal Implementation
Implemented Ptr, Ptr2D, and Ptr3D and change Mut variants to Ref versions. Ptr does not pin any managed code and is very slimmed down to just wrap native pointers and access their data.
Ptr is used for any variable with the out attribute or is returned, otherwise Ref types are used. All const related code was removed.
Most of the Ptr tests were removed as Ptr types do not implement conversions to or from managed types. Otherwise, all remaining tests are currently passed by these types.

So I just realized when I rebased (accidently based this branch on my main which was behind) I forgot to regenerate and I notice some issues I missed when rebasing, should compile all good now.
As for string conversions, we can add those, but I wanted to minimize how much we were allocating in the Ptr types. I would actually more want to remove the string conversion in Ptr/Ptr.
As for referenceGen, none of these are autogenerated. I did miss one of the comments at the top of the ref type. These are all handwritten and modified a bit from the old, generated sources. We could feasibly write a generator for these, but I do feel like it would be more time than it is worth.


Allow user to set custom livenessProbe and readinessProbe

Hi team,
This PR allows user to set custom value for livenessProbe and readinessProbe too
Provide a description of what has been changed
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] README is updated with new configuration values (if applicable) learn more
[ ] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes https://github.com/kedacore/charts/issues/508

@JorTurFer When we set for other deployments like admission webook,

I'm thinking of deprecating this field webhooks.healthProbePort and opt for the more generic one like livenessProbe or readinessProbe. wdyt?
https://github.com/kedacore/charts/blob/00a3e0cfce41a7f8efde769a9dd46ae39ac770ec/keda/templates/webhooks/deployment.yaml#L88
https://github.com/kedacore/charts/blob/00a3e0cfce41a7f8efde769a9dd46ae39ac770ec/keda/values.yaml#L86
Is there a process about deprecation that we can follow? I think we need to add something here right (link) ?

@JorTurFer When we set for other deployments like admission webook,

I'm thinking of deprecating this field webhooks.healthProbePort and opt for the more generic one like livenessProbe or readinessProbe. wdyt?
https://github.com/kedacore/charts/blob/00a3e0cfce41a7f8efde769a9dd46ae39ac770ec/keda/templates/webhooks/deployment.yaml#L88
https://github.com/kedacore/charts/blob/00a3e0cfce41a7f8efde769a9dd46ae39ac770ec/keda/values.yaml#L86

I think that we hace to maintain both during some period to not break the chart from one version to the next

Is there a process about deprecation that we can follow? I think we need to add something here right (link) ?

It's a good question. @tomkerkhove @zroubalik , is the helm chart covered by our deprecation policy? I think so but I'd like to read your thoughts

@zroubalik yes. Thats the link I posted above. I will make the changes right away

Thanks for the imporvement!


[Bug report] Parsing error when the message name is contained in the message fields

I think the parser will fail if the message name is contained in the message field type.
Steps to reproduce
Using the following schema:
proto mytest

enum payload_data_type_e: uint8 {
    PAYLOAD_DATA_TYPE_UNKNOWN = 1
    PAYLOAD_DATA_TYPE_DETECTOR = 2
}

message payload_data_t {
    payload_data_type_e type = 1
}

When compiling
$ bitproto -O c .\mytest.bitproto
error:  .\myschema.bitproto:L9  { => Some grammar error occurred during bitproto grammar parsing.

My guess is that this error is due to a kind of name collision in the lexer.

@g-berthiaume
Hi ~
Yeah, there is a name collision mistake.
type is a keyword like what the keyword typedef does in C. Example here
Use like:
type Timestamp = int64;
it will fix:
proto mytest

enum payload_data_type_e: uint8 {
    PAYLOAD_DATA_TYPE_UNKNOWN = 1
    PAYLOAD_DATA_TYPE_DETECTOR = 2
}

message payload_data_t {
    payload_data_type_e data = 1
}

@g-berthiaume
hmm, yep. the word type is a reserved keyword, this breaks parsing, it can't be used as a message field's name.
But I think this word "type" is  a very common word, so I decided to solve this.
A newer version of bitproto, v0.4.2 was just uploaded, which fixed this problem.
Now the following message parses well:
message Test {
    uint4 type = 1  // it's ok now
}

You can upgrade bitproto via pip install -U bitproto.
https://github.com/hit9/bitproto/releases/tag/v0.4.2

That's great!
Thanks for your work!
On another note:
For some reason, I'm having difficulty installing: Pip raise the following exception:
FileNotFoundError: [Errno 2] No such file or directory: '../README.rst'
Is it possible that the package builder executes setup.py outside of the compiler/ directory?
Maybe it's a problem with my machine ^^

@g-berthiaume Thanks for reporting this bug.
pip install -U bitproto would work now.
Or you can download the binary directly from https://github.com/hit9/bitproto/releases/tag/v0.4.4


Update to remove all usages of unstable features

In src:

Replaces dependency on in-rustc libc with the libc crate on crates.io
Removes unrequired imports of std::ffi::AsOsStr, as Path implements a separate .as_os_str() method without the trait
Replaces usage of OsStr.to_cstring() with CString::new().

Note: this replaces a match statement with try!()

io::Error implements From<NulError>, so we can just use try!() instead of manually crafting an io::Error.

Replaces usage of slice.position_elem() with .splitn()

This usage of .nsplit(|b| b == &0u8).next().unwrap() splits the slice on the first \0 byte, taking everything before it, or just leaves it as it is if the slice doesn't have any \0 bytes

Note: the 2 passed to splitn() ensures that splitn won't continue checking the string for more \0 bytes after it has found one \0 byte.

This exactly mirrors the behavior of the code it replaced, it just uses .split() instead of manually checking for the first instance of \0 and splitting the slice manually.

In tests:

Replaces usage of file.path() with just using the PathBuf produced by temp_file().

As far as I can tell, both file.path() and the PathBuf produced should be exactly the same, as the PathBuf is literally taken from the exact file which was opened.

Switches usage of PathBuf::from(path.as_os_str()) to PathBuf::from(path)

This also updates .travis.yml to build and test with both the 1.0.0 beta build, and the latest nightly (instead of just the latest nightly).

Thanks a lot for the contribution, and sorry for the delay.

No problem, thank you!


Support updated Linea gas fee estimation

Explanation
Currently, the TransactionController provides only initial gas fee values using both the request and suggested values from the GasFeeController.
The client UIs then allow these gas fee values to be edited using custom values, or suggested values for different priority levels (low, medium, and high) from the GasFeeController. These suggested values are sourced directly from the GasFeeController state.
The goals of this PR are to:

Support the new Linea gas fee flow using the linea_estimateGas RPC method to recommend a baseline baseFeePerGas and priorityFeePerGas specific to each transaction on Linea chains.
Implement a GasFeeFlow architecture to support alternate modularised sources of gas fee estimates depending on transaction criteria such as chain ID.
Implement a GasFeePoller helper to automatically monitor all unapproved transactions and periodically store updated gas fee estimates in their metadata using suitable gas fee flows.

The intended benefits of this system are:

To decouple the clients and their UIs from additional domain and complexity, specifically alternate gas fee sources such as the GasFeeController, SmartTransactionsController, and the Linea RPC method.
To abstract these gas fee sources so additional implementations can be easily added and tested in isolation.
To avoid duplicated logic in both clients, so it can instead be defined in a single location, the TransactionController, as it already contains a considerable amount of gas fee logic, and provides a clean mechanism to store transaction specific estimates via the TransactionMeta type.

References
Fixes #2001
Changelog
@metamask/transaction-controller

ADDED: Add the gasFeeEstimates property to TransactionMeta to be automatically populated on unapproved transactions with estimates for each priority level.
ADDED: Use the linea_estimateGas RPC method to provide transaction specific gas fee estimates on Linea networks.

Checklist

[x I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@matthewwalsh0 How crucial is this change? I would like to try to get https://github.com/MetaMask/core/pull/3827 in after the DevEx team gets in the multichain PR, so that it doesn't cause too many additional merge conflicts in that PR and we have a messenger we can pass around, etc.

@mcmire To follow up on the comment I left above, @matthewwalsh0 and I spoke and agreed that this can go in first. I will rebase my BaseController v2 PR on top of this after it's merged. So all good here :)


Make a Flatpak, AppImage or Snap

In that order of preference... Not everyone runs Ubuntu, Fedora or Debian.

So logical.


Adding documentation on the env variable DD_SITE

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
DD_SITEenv variable was not documented.
Motivation
The intent is to avoid people to lose time like it did in my research.
Testing Guidelines
Just verify if the documentation is good for you guys.
Additional Notes
I would also verify also DD_URL, it is not clear what the difference between the two is.

Thanks for the PR.
As of now, we don't support the environment variable for DD_SITE for  v5 of our Agent.
DD_URL is used in v5 to proxy connections as noted in the docs:
https://docs.datadoghq.com/agent/proxy/?tab=agentv5#datadog-agent-configuration
Although we support DD_SITE in v6, docs were indeed missing for the Agent v6 container, and I've opened a PR on that repo:
https://github.com/DataDog/datadog-agent/pull/3233
Thanks again for your contribution!


"flask tests" command does not work

When I run flask tests command after setting up the project, I get this error
Error: No such command "tests".
As far as i know, i do not think flask has tests command. Can anyone help with this?

The command is flask test, not flask tests.


Aws Issue - Port issues

Aws Issue - Port issues

By default AWS does not open any port other then 22 for ssh.
Also the default ports are 2375 and 2376.

We need to manually open the ports in the instance configuration . Else we face the following issues :

docker swarm joining will fail as port number 2377 is not opened by default.  Docker swarm init will by default create join tokens with port number 2377.
Services and containers which are placed on other machines in the swarm network will not be able to communicate with each other
We cannot access the deployed docker services with their port number.
Manually need to open the port numbers used by the services (Requires knowledge on the deployed architecture regarding which services port configurations)

Solution 1 : Easiest for Development purposes

Edit Inbound rules  to allow all traffic to all.

Solution 2 : Complex

Manually set the rules.

-Even after manually setting rules, still there were some issues like the portainer and portainer-agent was not able to fetch information about containers running in worker machines.
Conclusion :
Solution 1 works like charm and everything is working as expected


Node Keys are displayed in logs

They shouldn't be.  Probably best to do a pass through the logging and make sure that there isn't any potentially sensitive information being logged.

Logging node keys is fine. Logging enroll secrets is not.


Handling upload events in $.fetch() via options

xhr.upload has events too, just like the xhr-object. For example "onprogress".
$.fetch() allows you to assign to the xhr-object by passing "remaining" (not documented) options to it. However, with uploads you'd more likely want to pass them to xhr.upload, not xhr.
The best solution I could think of (backwards compatible and allows you to add properties to either) is to add properties to upload if passing them in options.upload.
Ex:
$.fetch('/my/url', {method: 'POST', onprogress: downloadProgressHandler, upload: {onprogress: uploadProgressHandler}})

Doing that today leads to an error TypeError: Cannot assign to read only property 'upload' of object '#<XMLHttpRequest>'. So the change would definitely be non-breaking.

Agreed, that would be a good syntax for it. PR? :)

I will wait until #205 is closed to avoid conflicts.

Added in #207


skip parameter not taking expression for boolean

Describe the bug

When using version 1.3.1 with withHooks, the input type for render props query component is not taking boolean type for skip param type, instead, I see { variables: {...}; skip?: false } | { skip: true }. So skip can only be set with true or false.
This will break common expression like !undefined or !a && b.
eg.
<Get_FooComponent variables={{...}} skip={!a && !b}>

To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

# Put your schema here

My GraphQL operations:

# Put your operations here

My codegen.yml config file:

# Put your YML here
generates:
  src/_generated/graphql.tsx:
    documents:
      - src/components/**/*.{ts,tsx}
      - src/queries/**/*.{ts,tsx}
    plugins:
      - 'typescript'
      - 'typescript-operations'
      - 'typescript-react-apollo'
    config:
      withHooks: true

Expected behavior

Environment:

OS:
@graphql-codegen/...:
NodeJS:

Additional context

I didn't understand the problem, so skip should take a boolean which can be the result of an expression.

it seems that skip can only be set to true or false, not the result of an expression. So, <Get_FooComponent variables={{...}} skip={true}>  works but <Get_FooComponent variables={{...}} skip={!false}>  wouldn't

What do you mean by not working? Is there any TS error or isn't it working on runtime?

there's a TS error says
Types of property 'skip' are incompatible.
Type 'boolean' is not assignable to type 'true'.ts(2322)

that's right. these are part of generated code:
export type PartnerPayoutAccountsComponentProps = Omit<
  ReactApollo.QueryProps<
    PartnerPayoutAccountsQuery,
    PartnerPayoutAccountsQueryVariables
  >,
  "query"
> & // totally not needed part: why was the code generated?
  (
    | { variables: PartnerPayoutAccountsQueryVariables; skip?: false }
    | { skip: true });

and above code prevent from assign boolean value into skip.

If this is intended, feel free to close. But I wonder if there's any reason for avoiding boolean type here? Not sure if I'm the only one but I was using an expression for skip.

https://github.com/dotansimha/graphql-code-generator/pull/1926/files?file-filters[]=.ts#diff-ce84bc42a6b0c5a7f856c37781eb4e65R113
This commit cause the issue. But, is it really good not to let assign boolean value into skip parameter?
isSkip: boolean = true;
variables = {};
<GeneratedComponent
  variables={isSkip ? undefined : variables}
  skip={isSkip}
/>

Above code looks fair to me but cannot be compiled because typescript cannot check type of the code from generated type definitions as
(
    | { variables: GeneratedVariables; skip?: false }
    | { skip: true });

I reverted the commit and made pr. Letting variable optional when skip parameter is true is quite awesome, but it is meaningless when type check cannot catch.

Fixed in: https://github.com/dotansimha/graphql-code-generator/pull/2251

awesome! Thanks, guys!

@wangsongiam keeping open until we'll release a stable version with the fix :)

Fixed in 1.5.0 🎉


Added Mac Catalyst Support

Adds Mac Catalyst support
Closes https://github.com/getditto/DittoSwiftTools/issues/135

I went ahead and linked this to #135 and added your name there. Thanks for tackling this!


Deprecation warning when using React 15.5

With React 15.5, importing PropTypes from React is deprecated in favour of importing from the new 'prop-types' package.
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
Can ReactInlineEdit be updated?

Now with React 16 out, this is a a breaking issue FWIW.


[DTSSTCI-95] Add hearingCreatedDate to a listing

https://tools.hmcts.net/jira/browse/DTSSTCI-95

[ ] tests have been updated / new tests has been added (if needed)

Updated listings:

QA Approved.


Perform linting on Ansible playbooks

This PR:

Adds experimental to ansible-lint skip_list
Perform linting on Ansible playbooks
Closes #100

another Galaxy error, https://github.com/ansible-community/molecule-plugins/actions/runs/4179174587/jobs/7238820200#step:6:72

oh, thanks for doing it ! Btw, I already did some fixes in the past: https://github.com/ansible-community/molecule-plugins/pull/90. Since your PR is doing more, I'm happy to close mine. Nevertheless, I'm not seeing any alignment fixes for molecule/test-podman/verify.yml. Has this already been fixed ?
And for the galaxy failure, looks like we're getting it more and more. Not sure we can do anything. Maybe using GHA caching ? but I'm not sure it's a good idea or if it'll work.

So sorry @apatard, I totally missed #90 ... and I also missed molecule/test-podman/verify.yml but that should be fixed now.

So sorry @apatard, I totally missed #90 ... and I also missed molecule/test-podman/verify.yml but that should be fixed now.

No worry. All that matter is that the lint issues are getting fixed. I've closed my PR.

pushed an extra commit to hopefully finishing linting issues. I hope you don't mind. Also, realized after pushing that this PR was about playbooks only, so fill free to kill my commit if wanted and I'll send a new PR

All good @apatard

I believe there's a need to restart a lot of tests due to yet more Galaxy issues, ansible-playbook -i'<IP_ADDRESS>,' -c local ./src/molecule_plugins/podman/playbooks/validate-dockerfile.yml works locally (tm).

yeah, same here. I don't remember having issues with it on my test vm... but on gha, it seems to happen a lot. I'm disappointed that there's no error message. I thought we were seeing them previously (unless I'm mixing with ansible-lint or molecule ci)

Yeah, previously (or maybe because of other causes) there was proper timeout error messages but this just fails.

fyi, added a label to make the latest check green.

fyi, added a label to make the latest check green.

thanks, i dont have that power


Error: class uri 'eventlet' invalid or not found

Hi,
It appears that Eventlet 0.30.3 removed eventlet.wsgi.ALREADY_HANDLED which is used by gunicorn
See: https://github.com/eventlet/eventlet/issues/702
The pinned version eventlet==0.31.0 in requirements.txt causes this error for me:
Error: class uri 'eventlet' invalid or not found:

[Traceback (most recent call last):
  File "/mnt/c/Users/ingo/Documents/Code/SatSale/.venv/lib/python3.6/site-packages/gunicorn/util.py", line 99, in load_class
    mod = importlib.import_module('.'.join(components))
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/mnt/c/Users/ingo/Documents/Code/SatSale/.venv/lib/python3.6/site-packages/gunicorn/workers/geventlet.py", line 23, in <module>
    from eventlet.wsgi import ALREADY_HANDLED as EVENTLET_ALREADY_HANDLED
ImportError: cannot import name 'ALREADY_HANDLED'

Workaround
pip install --upgrade eventlet==0.30.2

It seems like the eventlet dependency was removed with 4312c7682113d138483722e50eccdf4a314805a6 and now the error pops up again (at least it did for me).

Running with nohup gunicorn -w 1 -b <IP_ADDRESS>:8000 satsale:app > log.txt 2>&1 & worked, I guess the README has to be updated.

Running with nohup gunicorn -w 1 -b <IP_ADDRESS>:8000 satsale:app > log.txt 2>&1 & worked, I guess the README has to be updated.

Good call. I recently had some issues with RPC connection no longer working after some time when not using eventlet,
Can confirm that I have been running with the command above just fine. Thank you Gigi, and for trying it out. Please let me know of any suggestions/feedback. (or pull requests!)
Updated README.md: https://github.com/nickfarrow/SatSale/commit/eb2beade6d5fc2f0998abda7e87bb28e35b8f97d


add bpir3 patch to avoid crashing the device on missing band information

My bpir3 was crashing almost daily with logs like:
Internal error: Oops:<PHONE_NUMBER>000006 [#1] SMP

I found these forum threads which described behavior very similar to the one displayed by my device:

https://forum.banana-pi.org/t/bpi-r3-crash-in-sta-set-sinfo-0xa18/15290
https://github.com/openwrt/openwrt/issues/13198

After applying the patch mentioned in https://forum.banana-pi.org/t/bpi-r3-crash-in-sta-set-sinfo-0xa18/15290/10, I've been running the device for 3 weeks without issue.
This patch does not solve the underlying issue but it avoids crashing the device.

This looks reasonable enough to me.
Merged with some additional comments and a change to the commit message as 0f6fe1d77b3fc2198aabf76453f0a5159c9835c5


Add Ko chapter2 2.mdx

@lewtun check plz :)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@lewtun I fix conflict and push again! one more check please 🙂

Looks great, thanks for iterating!


minor version bump

Description
Minor version bump for release.
Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

Codecov Report
Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.39%. Comparing base (074f15a) to head (d5bb4c9).

Files
Patch %
Lines

dbt_common/__about__.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   64.39%   64.39%
=======================================
  Files          51       51
  Lines        3134     3134
=======================================
  Hits         2018     2018
  Misses       1116     1116

Flag
Coverage Δ

unit
64.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate with sqlean

https://github.com/nalgeon/sqlean is a great set of extensions for SQLite. We should consider if/how to integrate with it - e.g. by adding it as a submodule and hooking it into the build system, so that it's easy to opt-in for the features provided by sqlean.

We do have sqlean extensions included for a long time now.


Off() method not exposed in HubConnection

The Off() method is implemented in the HubConnectionManager but not exposed trough HubConnection like the On<T>() Method
How do I unregister a function then?
Thanks!

You should not call directly the Off, hence why it wasn't exposed. When you call On<T>(), it will return a IDisposable.
All you have todo is call Dispose() on it as in the regular SignalR C# library.
Look at the samples here https://github.com/BlazorExtensions/SignalR/blob/master/test/Blazor.Extensions.SignalR.Test.Client/Pages/ChatComponent.cs#L66
Let me know if you have any problems with it.

I'm closing it but let me know if you wasn't able to use the method explained. Thanks!


decode issue with password

Hello,
I was trying to use this library on a demo API based on the rest API sample code but received the following error:
  File "/usr/lib/python3.8/site-packages/trading_ig-0.0.6-py3.8.egg/trading_ig/rest.py", line 1117, in create_session
  File "/usr/lib/python3.8/site-packages/trading_ig-0.0.6-py3.8.egg/trading_ig/rest.py", line 222, in _req
  File "/usr/lib/python3.8/site-packages/trading_ig-0.0.6-py3.8.egg/trading_ig/rest.py", line 137, in req
  File "/usr/lib/python3.8/site-packages/trading_ig-0.0.6-py3.8.egg/trading_ig/rest.py", line 81, in _create_first
    #df_ask = response['prices']['ask']
AttributeError: 'str' object has no attribute 'decode'

I did try commenting out line 81 in rest.py and reinstalling the library and this seemed to resolve the issue. Am I doing something wrong? Should the password be something other than a str?
Regards

If you don't use the password encryption at connect I think that replacing the line 81 in rest.py :
params['password'] = params['password'].decode()
by
if type (params['password']) is bytes:
    params['password'] = params['password'].decode()

Should do the job. Otherwise you could try to set the encryption parameter to True.

Thanks for the help, I managed to fix my issue by doing password.encode().

@eddycurrently thanks for that, i am very much against modifying the library code so this works perfectly!

@BroBan, OK, I'll close the issue then.


MySqlConnection ambiguous v<IP_ADDRESS>

Hi I am using MySqlBackup.Net <IP_ADDRESS> in my .Net Core 2.2 project. Now I am keep getting the following error. Can you please help to see what could be wrong. I am also using Pomelo.EntityFrameworkCore which seems like uses the MySqlConnector. Thanks

Yes, possible cause of problem is: Pomelo.EntityFrameworkCore uses MySqlConnector and MySqlBackup.NET uses MySql.Data.
Both MySqlConnector and MySql.Data has the class of MySql.Data.MySqlClient
Here is one of the possible solution:

You can try create a new folder "MySqlBackup" in your project.
Download the source code files of MySqlBackup.NET and copy paste it into that new folder.

With this, MySqlBackup.NET will be using class library of MySqlConnector too.

Thanks a lot. I solved this by replace Pomelo.EntityFrameworkCore by MySql.Data.EntityFrameworkCore. MySql.Data.EntityFrameworkCore uses MySql.Data, which is the same as MySqlBackup.


Ubuntu 22.04 support

Closes #47
There's still a glitch where the mailbox directories aren't being created as they should (might be a directory permission issue). This is exclusive to Jammy from what I can see.
Still waiting for Roundcube 1.6 to leave RC status before the PR can be merged.

Glitch resolved. Waiting for the following until I merge:

[ ] Roundcube 1.6 final release;

[ ] CardDAV plugin tarball fix - see mstilkerich/rcmcarddav#386

Hi, I was wondering If there are any more blockers for this to be merged?

Not reeeeallly
Other than addressing some issues that have been reported and are still building up... :sweat_smile:


Fix RDP8 gateway disconnections

@freerdp-bot test.

@freerdp-bot test

the build bot failed for some reason for Win64, retesting

@freerdp-bot test

Branch/tag couldn't be fetched from github.

Most of the formatting looks broken (spaces vs tabs)

@mfleisz I will get the formatting fixed, you are correct.

I thought maybe the problem was the RDG BIO, but it turns out the problem also affects the TSG BIO. I really can't figure out what's wrong with the BIO, even looking at OpenSSL code. The problem occurs more quickly with OS X for some reason with the stock OpenSSL (0.9.8gz). I have tried figuring out if what we're doing is somehow correct for full duplex usage, and I couldn't find confirmation that we can safely call SSL_read/SSL_write in parallel. This is extremely annoying, as it works well 99.9% of the time with all of the effort we've put in. This stack overflow question affirms that at least with < 1.0.0 we can't do that safely: http://stackoverflow.com/questions/14467630/clarifying-openssl-0-9-8l-concurrency-support-can-ssl-instances-be-used-by-mul. I couldn't find confirmation that it should be safe in any way for later versions. I removed the false fix and added locking around operations that deal with SSL*. I need more extensive testing, but it appears to be stable now. I hate to have to lock SSL*, but I don't see much more options to make a definitive, stable fix. Any thoughts?

OpenSSL has been making our lives miserable for so long. I found out that a few weeks ago, mbed-tls was relicensed under the Apache license, which would make it usable for us (https://tls.mbed.org). It is apparently the result of ARM buying the rights on PolarSSL and offering it now under Apache 2.0. Building is simple (cmake is supported), and it appears very portable. I would seriously consider at least adding support for mbed-tls, this would alleviate a lot of pain that we currently encounter with OpenSSL.

IIRC on MacOS async transport is activated by default, that could explain why it happens more frequently.

@awakecoding mbed-tls might be an good alternative but I wouldn't drop openssl completely. Also using a not that wide spread ssl toolkit might make packaging/distribution even harder.

About mbed-tls, they don't seem to support reading and writing at the same time. This is quite explicit in the doc: a rule says that until the doc says it's safe you shouldn't do it, and the doc almost never talk of this). Perhaps dropping concurrent read / write would remove us some pain too !

@bmiklautz @hardening we have tested the new more proper fix that involves locking operations dealing with SSL*, and it appears to be stable now. Aside from the gateway, we have had many user reports similar failures with direct connections in the recent months. I'm thinking we really don't have much of a choice but to lock those operations. Are we good to merge? The current code is definitely not safe, and this new fix is not going to cause another cat and mouse chase between false fixes and true fixes.

@hardening as for mbed-tls, I think it's at least worth a shot to attempt adding optional support for it. The building procedure would likely involve preparing an mbed-tls build instead of using distribution packages, but it would be statically built in. As for full duplex, I didn't have the time to take a look, but if OpenSSL doesn't do it then it's not really a downside at this point.

I haven't tested the changes in rdg but the changes in tls.c look good to me.

@bmiklautz we've tested the RDG changes, and it definitely resolves the issues we were having.


Event Forwarding

What problem does this feature solve?
This feature removes boilerplate-ish code to forward events, making the coding experience feel more vue-ish.
In a parent-child-grandchild scenario where the grandchild needs to pass information to the parent, it currently has to emit an event which is then captured by the child who forwards it to the parent.
This feature would remove the need to write the function in the child that forwards the event from the grandchild to the parent.
FYI: This has been implemented in Svelte:
https://svelte.dev/tutorial/event-forwarding

But that's a lot of code to write, so Svelte gives us an equivalent shorthand — an on:message event directive without a value means >'forward all message events'.

What does the proposed API look like?
For Instance:

"[at]click.forward"
simply "[at]click"

Duplicate of https://github.com/vuejs/vue/issues/9325


Subtitles long loading

Hello! I used that lib to implement subtitles in my project. A lot of users have issues with loading, mostly on Windows 7. It takes really long time to load subtitles, but when it loaded once user can change them immediately. What could be wrong?

I met the same problem. It may be related to network but I have no idea.
When I serve and access my app locally, subtitles load immediately.
However, when app is served at a remote server, it takes a long time loading subtitles after  subtitles-octopus-worker.js, subtitles-octopus-worker.wasm, subtitles-octopus-worker.data have been downloaded (the network panel shows that).
I change my local app to use worker served remote, and same long loading happened.


Important instruction for usage added in README i.e. load teljs module

Addition of instruction to load the 'teljs' module into the angular app. i.e.
angular.module('', ['teljs']);

Hi.
Im sorry I haven't pull this until now.
Thank you for the contribution.

Michael

My pleasure.


TypeScript Organize Imports removes aliased imported types that are in use

Issue Type: Bug

Create a new TS project that uses an NPM package, such as "typescript"
Create a TS file that imports a type from that package, aliasing it to a different name.  Use that aliased type in the code.  E.g.:

import { BaseType as Foo } from "typescript";
const x: Foo = null;

SHIFT+ALT+O  (or CTRL+SHIFT+P, TypeScript: Organize Imports)

Expect:
No changes
Actual:
The import line is removed, and the code no longer compiles.
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.14393

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

Memory (System)
15.84GB (8.69GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions: none

Duplicate of https://github.com/Microsoft/TypeScript/issues/22743
Should already be fixed in vscode insiders


Questions about training on my custom dataset (gray-scale, 1 class)

❓ Questions and Help
Hi,
Thanks for reading my issue!
I have a dataset consisting of 1.4k thyroid ultrasound images (1.4k ultrasound images(.jpg) and 1.4k groundtruth masks(.png)), and they are grayscale images.  My dataset has only one category — throid nodule (excluding background). I want to train a model based on mask-rcnn to segment thyroid nodules.
Here’s what I have done:

Converting data set into COCO format by using pycococreator.
Changing some configs.
Run the train_net.py and test_net.py.
The result is not very satisfactory.

Writing this issue, I reverently ask that:

How to change some code to train gray-scale images?
How to determine the _C.SOLVER.MAX_ITER and _C.SOLVER.STEPS with about 1k images?
I don't quite understand the evaluation indicators for coco datasets, such as AP，AP50 and AP75. Can you explain it for me?
Is there any way to calculate the dice coefficients of the model on the test set?
Is there any way to use the mask images(.png) directly to train without converting it into coco?

Thank you very much!

@shanruiyu Were you able to run the train_net.py?

@shanruiyu Were you able to run the train_net.py?
Yes!  And I can also run test_net.py,  I curious to know how to calculate the dice coefficients on coco format dataset.

I have similar problems with you,  have you solved your problems?  Can you add my QQ to have some discussion? My QQ is 304378542


External Direct link

I understand you can link to specific id attributes by doing the following:
Link
but using that with a homebrewery share link just doesn't work, i get that is because the document is inside an iframe or because the page is not rendered before following the link, but is there a way around this?

There is a way in vanilla JS.
// Get the hash value from the URL
var hash = window.location.hash;

// Check if the hash value exists and is not empty
if (hash && hash !== '') {
   // Get the iframe element
   var iframe = document.getElementById('BrewRenderer');

   // Wait for the iframe to load
   iframe.onload = function() {
       // Get the element with the corresponding ID in the iframe
       var target = iframe.contentDocument.getElementById(hash.slice(1));

       // Scroll the iframe to the target element
       if (target) {
           iframe.contentWindow.scrollTo(0, target.offsetTop);
       }
   };
}

I don't know how to do this in React.

Just theorizing here... We could render the entire brew text to HTML, parse it for a matching ID, determine the immediately preceding
 and then, once the iFrame is loaded, scroll to page X.
It's not a perfect solution, but it should work, even if the brew is large enough to activate PPR.

See also https://github.com/naturalcrit/homebrewery/issues/2830

Isn't this fixed by #3156?

Isn't this fixed by #3156?

No.
#3156 will clear the blocker to a fix, but not effect a fix.
Specifically, the anchors in the preview would be rendered into an iframe, but the window.location only looks at the top level html document. Even if all the headings were rendered into the preview (via PPR etc), the iframe does not get targeted by window.location.hash.

#3506 adds this functionality, grabbing the hash location, determining if it is a page or an element, if it is an element, it scrolls to the page of the element.

Just some feedback, the linking seems to be weird for example:
https://homebrewery-pr-3506.herokuapp.com/share/5BLGepL_5gWo#WEAPON_MOD_PROP_POWERFUL
Seems to jump to the right page, however jumping using the specific page seems to jump to the next page:
https://homebrewery-pr-3506.herokuapp.com/share/5BLGepL_5gWo#p82
goes to page 83 instead of 82

This is because we get whether the page is visible from the page number, but scroll to the top page, i can fix this easily.

Simple, good catch, our first page is numbered #p0, will update this right now.


ESP32 initialize encryption data transmission. using shared_key that the ESP created

What needs to be done
So far, the ESP32 can only end-to-end communicate with another atSign if that other atSign has initialized the transaction by creating the @esp:shared_key@app aes key that is encrypted with @esp's rsa public encrypt key.
Once #20 is complete, we can utilize AtClient::get_aes_key_shared_by_me within AtClient::get_ak to check if we created the key in the ESP.

Closing, merging the details into #20


the vendor file changed hash when I add echart to children chunk

Version
2.9.3
Reproduction link
https://github.com/InvincibleJun/demo
Node and OS info
Node 8.9.1 / npm 5.5.1 / Windows 10
Steps to reproduce
for example, I have four pages which use `() => import and use echarts. when all pages use echarts and I packed, it will make a extra chunk file. Then I only use echarts in two pages and I packed, the vendor.[hash].js is different as old file. it ‘s so terrible.
CommonsChunkPlugin options as follows or see the demo
    new webpack.optimize.CommonsChunkPlugin({
      name: 'vendor',
      minChunks (module) {
        // any required modules inside node_modules are extracted to vendor
        return (
          module.resource &&
          /\.js$/.test(module.resource) &&
          module.resource.indexOf(
            path.join(__dirname, '../node_modules')
          ) === 0
        )
      }
    }),
    // extract webpack runtime and module manifest to its own file in order to
    // prevent vendor hash from being updated whenever app bundle is updated
    new webpack.optimize.CommonsChunkPlugin({
      name: 'manifest',
      minChunks: Infinity
    }),
    // This instance extracts shared chunks from code splitted chunks and bundles them
    // in a separate chunk, similar to the vendor chunk
    // see: https://webpack.js.org/plugins/commons-chunk-plugin/#extra-async-commons-chunk
    new webpack.optimize.CommonsChunkPlugin({
      name: 'app',
      async: 'vendor-async',
      children: true,
      minChunks: 3
    })

What is expected?
the vendor hash not changed
What is actually happening?
the hash changed

Hello @InvincibleJun
Thank your for your interest in this project.
However, your issue is a usage/support question, and the issue tracker is reserved exclusively for bug reports and feature requests (as outlined in our Contributing Guide).
We encourage you to ask it on the forum  , Stack Overflow or on our Discord chat and are happy to help you out there.


removed version + added missing csrf env variable

removed version (obsolete)
added missing DJANGO_CSRF_TRUSTED_ORIGINS env variable

Just a question: I don't really understand. I thought the setting in django is named CSRF_TRUSTED_ORIGINS not DJANGO_CSRF_TRUSTED_ORIGINS. How does this env var get propagated correctly to a django setting?

Just a question: I don't really understand. I thought the setting in django is named CSRF_TRUSTED_ORIGINS not DJANGO_CSRF_TRUSTED_ORIGINS. How does this env var get propagated correctly to a django setting?

Typically you use the DJANGO_ prefix to indicate this is a DJANGO variable and some packages automatically fallback to resolving this correctly and automatically (eg. Django Configurations, but we don't use that yet - would be good candidate to use though)
For now we read them in Settings.py:
https://github.com/buildingSMART/validate/blob/69b6058c2569b33eb058dfa8e7e3d9797c4636d5/backend/core/settings.py#L114-L115


Added new smol 🤏 Multimodal RAG System with ColSmolVLM and SmolVLM recipe 🧑🍳

What does this PR do?

Fixes #243
Who can review?
@merveenoyan and @stevhliu

very cool!

View / edit / reply to this conversation on ReviewNB
andimarafioti commented on 2024-12-05T12:45:51Z ----------------------------------------------------------------
Have you tried to also quantize the docs_retrieval_model?

The library currently doesn't support quantization_config as in transformers:

It could be possible but I think it would add a lot of complexity to the notebook without that native support.

In the actual notebook, it's not shown twice: https://github.com/huggingface/cookbook/blob/12a99a3d8c4f5607bb382e1d8536e60392e653b1/notebooks/en/multimodal_rag_using_document_retrieval_and_smol_vlm.ipynb

View entire conversation on ReviewNB

Added! Comparison of these two systems and the other two multimodal RAG recipes :)

View entire conversation on ReviewNB

Updated 🤗

Thanks for the suggestions @merveenoyan 😄 Applied!


"News_Homepage" Navbar Space Correction

Title and Issue number
Frontend Project "News_Homepage" Navbar Space Correction
Close #3712
Output
Before

After

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md

@MohitGupta121 Kindly review this pull request.


Added a default value for the '-conf' flag

By default matterircd doesn't attempt to read any config file, now it
will attempt to read from /usr/local/etc/matterircd/matterircd.toml if
it exists.

Now with actually working code!

hi rmzg, thanks for your contribution.
This is a good idea, but I think changing the default to "matterircd.toml" is better than "/usr/local/etc/matterircd/matterircd.toml"
If you could make this change I can merge it, thanks!

Changing it is fine but I'm confused, what directory it would look for that file in? I picked the /usr/local.. one out of the documentation for creating a config file.

It will look in the current directory, so if you're starting matterircd while being in /home/user it'll look for /home/user/matterircd.toml
If you want to run it as a service you can always explicitly mention -conf /usr/local/etc/matterircd/matterircd.toml
Most users don't have access to write in /usr/local/etc/matterircd

That's a good point, I've always run matterircd from a docker image, maybe -conf /usr/local/etc... should be added to that as a default option?

Updated.

Thanks!
Regarding to the docker question: with the -v option of docker you can mount the matterircd.toml where you want


Update pull_request_template.md

Welcome @nelsonmic! I don't think that class of content would be anything but clutter in our PR template, so I'm closing this.


Python 3

Hello,
it will be nice if Python 3 could be supported
because I see many
print ...

in your code instead of
print(...)

I also think you might use requests
http://docs.python-requests.org/en/master/
to have same code for Python 2 and 3
Six (2x3) could also help
https://pythonhosted.org/six/
Kind regards

Hi femtotrader,
Thanks for sharing the information.
Making the toolbox compatible for both Python 2 and 3 has been on our list for a long time (probably too long), we have bumped its priority and will work on it once we can. We are currently working on implementing important features and introducing more data.

I tried making the changes in pull request 6 (https://github.com/Quantiacs/quantiacs-python/pull/6) to add python3 support. I've tested it with some of the samples from sampleSystems.


HDDS-4846. Add line break when node has no pipelines for ozone admin datanode list command

https://issues.apache.org/jira/browse/HDDS-4846
One line cosmetic change. Pls refer to the original jira for slightly more info on it.

Thanks @ayushtkn for the +1!


Investigate new ways in order to display HTMLHinter Hint

Presently we spawn a second gutter to the left of the line numbers gutter, this current method wastes a lot of horizontal space which is very important when it comes to our web implementation of brackets due to space wasted on the preview. This problem is refactored further if we consider that we do not know how the user will use our application.
Possible Solutions:

Override the Gutter in relation to the line in which an error shows up so that we don't need to spawn a new gutter

User the Vertical Scroll bar method inside code mirror to spawn the icon, this method is currently used in thimble so it should not be difficult to implement

https://github.com/KeniMorri/HTMLHinter/pull/8 is fixing this, which I am hoping we'll get in today.

This just needs to land via submodule update in bramble.  Leaving open til then.


Add key visualisations onto dashboard listing page

Have created a Lume processor which searches for the following style of markup:
      <div data-injector-url="<page url>" data-injector-selector="<css selector>">

This runs after the file is rendered, and searches the page with the url specified. It then scans the DOM for the first element that matches the supplied selector, and injects the content inside the element tagged with the data-injector-url and data-injector-selector.


Share Project dialog is excessively wide

Not broken, but it feels odd.

I also think the continue should come on the right hand aligned, instead of left.


Module not found: Error: Can't resolve './_assert' ... Did you mean '_assert.js'?

When using
import { k12 } from '@noble/hashes/sha3-addons'

I ended up with the Module not found error. As a quick fix, I needed to change the file sha3-addons.js and add the .js file extension to the require statement. I'm writing this issue because I'm uncertain if this type of require without the extension is intentional or not.

That has been fixed in v1.1.1

I'm using version 1.1.5, and it is importing _assert without .js extension.

published 1.2.0


Fix MusicStore tests

Fixes #12097
The issue here is that the tests were incorrectly creating multiple instances of the same entity. This was being masked by a bug in EF which has just been fixed. The fix here is to not try to track multiple instances with the same ID.

@dougbu This is now merged.


Fixed a problem where default: "1000000000" in time.Duration was equal to "0".

In v1.1.0, setting default: "1000000000" for time.Duration was equivalent to "1s".
but, In v1.2.0, setting default: "1000000000" for time.Duration is equivalent to "0".
Therefore, even if time.Duration is set to a string that can be converted to int64, I did correct as "time.Duration".
#19

Does the author not maintain the repository?


ModuleId to PalletId - part of #8372

Related #8372
@thiolliere

I think we shouldn't put PalletId in sp-.

Maybe it should be moved to frame-support, I don't know why it is in primitives considering client doesn't need it.

Yeah @AurevoirXavier please move PalletId to frame-support.

Yeah @AurevoirXavier please move PalletId to frame-support.

Where should I place it? Currently I place it on the frame-support's root (lib.rs)

root is ok to me, but compilation needs to be fixed

root is ok to me, but compilation needs to be fixed

Okay. Companion is on the way.

root is ok to me, but compilation needs to be fixed

On the way.
Also a companion for polkadot.

@thiolliere I also change the subcommand moduleid to palletid

@AurevoirXavier this requires a polkadot companion.

@AurevoirXavier this requires a polkadot companion.

Done

bot merge


Add sensitive detector and hits

Add sensitive detectors for CEE and CHE sections (no AHCAL for the moment) and handle their hits.

Accepting PR #3.


[Project] Deletion of inactive individual accounts

I think this would be positive to start cleaning our database from inactive accounts. It's a way to delete the many spam accounts that were created on the platform.
It's also a good practice for privacy reasons. I'm sure not many companies are doing this because they use the number of account as vanity metrics. But we're not in this league and can do it our way.
We could start targeting:
Individuals

With no activity since more than 1 year
With no Transaction whatsoever in their account
With no Expense in their account
With no Membership or Membership invitation in their account

We could send them an email saying we're gonna delete their account if they don't Sign In or answer to the email within one month. After one month, we would proceed with soft deletion in the database.

I would like to do this early next year.

Any other condition to look at ?

Maybe non-deleted comments on other account. It's not an easy one since spammers also use comments, but creating an account just to say Bravo on an update published for the latest release of your favorite lib is a legit use case.

Proposed email:
Hello,

We're writing to you about your Open Collective account created with your email in 2017.

It seems this account is inactive and not being used for anything major on the platform like:
- contributing financially to a Collective
- submitting an expense to a Collective
- being an admin or a member of a Collective
- generally interacting with conversations, comments or reactions

For that reason, we think it's best practice to forget you and proceed with the deactivation then deletion of your account.

If you're fine with this, *you don't have to do anything*. Don't worry, you will be of course able to create a new account at any time in the future if needed.

If you want to keep your account, simply [sign in](https://opencollective.com/signin) on Open Collective within the next month or answer this message.

Whatever your decision, be sure that we're doing this with good intentions, mainly as a matter of respect of your privacy, and on our side to reduce our environmental footprint.

Best Regards,

The Open Collective team

Individuals
* With no activity since more than 1 year

* With no Transaction whatsoever in their account

* With no Expense in their account

* With no Membership or Membership invitation in their account

Maybe can we add to this accounts that we've already banned? This way those emails are freed.

@SudharakaP It's actually nice to block emails after banning users, it makes it more difficult for them to re-register.

We could send them an email saying we're gonna delete their account if they don't Sign In or answer to the email within one month

If we reach out to thousands of users, I will vote to omit that "or answer the email" part to ensure we don't have to update many user entries manually.

Step 1
Soft-delete completely empty accounts.

[ ] Create a script
[ ] SQL query to target user, then soft-delete in Users and Collectives tables
[ ] Make free user emails for new sign in (add timestamp in it)

Step 2
Soft-delete accounts with minor activity after warning.

[ ] Script to mark all candidate users with a flag and the date they were flagged
[ ] Export a list of emails
[ ] Contact them (Mailchimp or API/Mailgun, depend the amount of users)
[ ] After 1 month delete flagged users without new activity

Step 3
Automatize in a cronjob and do this regularly (users without activity within 1 year)

@znarf did we ever complete this?

No, we only worked on Step 1 and were not able to deliver on Step 2. This is still a todo but not currently worked on.
There is also some follow up to step 1 here: https://github.com/opencollective/opencollective-api/pull/8748


How to handle importation creating new collection

I've mapped secret collection on PGP UID and then keys and subkeys for this UID as keys for this collection. I seems to work well, except for the import logic.
In secret, ImportStoredKeyRequest needs to put the imported key in an existing collection, while in PGP, when importing a key, the collection (i.e. the UID) may not exist yet. For example I'm importing the public key of someone I currently have no key.
Possible solutions are:

add a ImportStoredKeyWithCollection that creates the collection when importing the key.
add a fake collection name that would be a magic keyword. When this  collection name is used the collection existence check is not done.
create a new ImportCollectionRequest object.
or last, let the user do ImportKeyRequest, then CreateCollectionRequest and StoreKeyRequest.

Currently, I'm using an hybrid solution 2, by always returning a fake "import" collection when listing collections in secret for GnuPG in addition to the real ones. Then, I can do a ImportStoredKeyRequest within the "import" collection. It has the drawback that this fake collection is listed in the setting page… And  that I cannot import the same key twice (to  update it for instance) because the key already exists in the metadata  database and the import fails before reaching the plugin code.
Solution 1. would be fine, but is to GnuPG centric IMHO. Solution 2. makes it work with minimal daemon modifications but is a bit of a trick. Solution 3. is nice, but even for GnuPG it has no direct match since importing a collection will imply importing one to several keys also at the same time. Solution 4. will work out of the box but is a pain for the user (additionally, even for GnuPG it has to be bend a bit since one cannot create a collection without creating keys for it).

This is following a discussion I've had with @chriadam on IRC.

Honestly, I believe the system we created with collections and plugins has become a bit too complex (and hard to understand by the end user). Originally we agreed to just use one collection, called SailfishSigningKeys on our UI for simplicity's sake but now we show all of them, resulting in a messy UI (in my opinion).
So right now even if the user only has just one key, s/he still sees a lot of confusing information. Even I was unsure where to tap on the screen when I first saw the current version. So we are still thinking about how to improve the user experience in the signing page.

in PGP, when importing a key, the collection (i.e. the UID) may not exist yet

I'm not familiar with PGP, but: is there a reason why you can't use an existing collection? You could also just check whether the collection exists and create it when not, using the respective request classes (we have code for this in secrets-ui).
If you really need the collection creation to happen at import, I would suggest to just enhance the import request with an additional boolean property to indicate that the daemon should create the collection if it doesn't exist. I think this would be the cleanest possible approach if you really need to use separate collections for every import.


[v2] Pageevents are attached twice (or more)

Have a look at
https://github.com/framework7io/Framework7/blob/v2/src/modules/router/router-class.js
at line 859, it should be
$pageEl[0].f7RouteEventsAttached = true;
instead of
$pageEl[0].f7PageEventsAttached = true;

Fixed in latest beta


Unresolved reference apollo3.gradle.api in custom gradle plugin

Version
3.7.4
Summary
Hi!
I wrote my plugin and there is a problem.
The Apollo classes are not visible in Android Studio, but everything is compiled correctly.
I have been observing the problem since 3.0.0.

Steps to reproduce the behavior
Example Project:
ApolloPluginTest.zip
Logs
No response

Alright, I can reproduce with
Android Studio Electric Eel | 2022.1.1 Patch 2
Build #AI-221.6008.13.2211.9619390, built on February 17, 2023
Runtime version: 11.0.15+0-b2043.56-8887301 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 13.1
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 10
Registry:
    external.system.auto.import.disabled=true
    ide.text.editor.with.preview.show.floating.toolbar=false

Non-Bundled Plugins:
    com.intellij.marketplace (221.6008.18)
    com.jetbrains.codeWithMe (221.6008.13.5)

It's working fine with Android Studio Girafe 2022.3.1 Canary 7 and IntelliJ 2023.1 EAP so I'm going to assume this will itself automatically in a few months.
apollo-gradle-plugin is the relocated jar so looks like there's something in the relocation that Android Studio didn't like. If it's too much of an issue for you and you can't switch to a Canary version, you can use apollo-gradle-plugin-external and plugin id com.apollographql.apollo3.external that has external bundling. Let me know if you see anything we can do, if not I'll close this issue.

The problem has been reproduced since version 3.0.0 and Android Studio of those versions (a year and a half ago).
All this time the problem did not disappear and decided to highlight it.
At the moment, this is not a big problem, but it really hinders any changes in the future (you have to write blindly).
But now working through apollo-gradle-plugin-external has helped me - this is already a solution that helps in the moment, thank you!
If the problem disappears in future versions of Android Studio, it will be cool, then you can close the issue.

Marking this one as blocked. Let's try again when Flamingo goes stable.

Working as of Android Studio Koala | 2024.1.1 Patch 1


[CLN] Move validation logic to server

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Move validation logic for embedding set operations from client to server

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2709  👈
#2686 : 1 other dependent PR (#2699 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikechroma and the rest of your teammates on  Graphite

related issue: https://github.com/chroma-core/chroma/issues/164