[SPARK-10251][CORE] some common types are not registered for Kryo Serializat…

…ion by default

@rxin can you please take a look?

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #41632 has started for   PR 8465 at commit 3b3d18c.

Test build #41632 has finished for   PR 8465 at commit 3b3d18c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41632/
Test FAILed.

Merged build finished. Test FAILed.

Test build #41633 has started for   PR 8465 at commit 6d9f6d1.

Test build #41633 has finished for   PR 8465 at commit 6d9f6d1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41633/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #41640 has started for   PR 8465 at commit a4877f0.

Test build #41640 has finished for   PR 8465 at commit a4877f0.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41640/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #41643 has started for   PR 8465 at commit 162a6f2.

Test build #41643 has finished for   PR 8465 at commit 162a6f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41643/
Test FAILed.

jenkins, please test

Test build #1694 has started for   PR 8465 at commit 162a6f2.

Test build #1694 has finished for   PR 8465 at commit 162a6f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks - I've merged this.


simple theme for linux console

I've noticed with a couple linux distributions (debian/arch) that the default linux console can't render the fonts from the default robby-russel oh-my-zsh theme. I imagine most people aren't faced with the linux console and are using some terminal emulator, but it is a bit odd to see. Perhaps oh-my-zsh could load a simpler theme if it detects it's being run in a linux console. Thoughts?

What character set is your terminal using? utf-8?

Oh My Zsh doesn't have the ability to know when a particular character is displayed correctly, that's a competency of the terminal emulator and no shell script has the ability of peaking into that realm.
You have two alternatives to use here:

Change the default font your TTYs use. These are special fonts (PSF fonts) since tty emulators don't have the same ability to display any font as normal terminal emulators do. Since you're using Debian I can tell you exactly how, see below.

Use fbterm which will display a full-blown terminal emulator, capable of displaying whatever font you use in your default terminal emulator.

If you decide to use the first approach, here's how you do it in Debian:

Put a custom font capable of display the symbols you need in /usr/share/consolefonts. This can be a powerline font or a normal one that can display other unicode symbols. I'm using Terminus PSF fonts from Powerline. The vNNx part of the font name is the size (NN) and style (x, normal or bold).

Change your /etc/default/console-setup file to use the newly downloaded font. In my case, that's:

# CONFIGURATION FILE FOR SETUPCON

# Consult the console-setup(5) manual page.

ACTIVE_CONSOLES="/dev/tty[1-6]"

CHARMAP="UTF-8"
FONT="ter-powerline-v16n.psf.gz"

Note that I have CHARMAP="UTF-8" in there as well. I don't remember if that's a default setting, but if you don't have it you should add it just in case.


Clean up KeyExtent

Replace confusing overloaded constructors with self-descriptive
static factory methods
Move metadata serialization into Metadata schema class
Remove unnecessary WritableComparable interface
Improve javadocs
Replace private equals method with Objects.equals
Remove methods only used in tests
Use TableId instead of String and fix variable name (tableId
instead of incorrect tablename)
Shorten accessor method names
Make KeyExtent closer to immutable (it's not truly immutable,
because Text objects that represent endRow and prevEndRow are
mutable)

I know this is a big PR, but most of this was done with very simple automated refactorings in the IDE... it just looks like a lot more was done, because KeyExtent is used in a lot of files.
I think these changes are worth it, because they make dealing with KeyExtent a bit less error prone, especially with the various Text parameters that had different semantics in the overloaded constructors. Giving names to those overloaded constructors, and eliminating the setters makes this object safer to use.
I'm currently running the full ITs on this before I'd consider merging.

My run of the full ITs passed.


[Manage Joiners] Create Ride Invitations

As a Driver I want to invite some colleagues to join the ride so that they participate in my ride.
Description

https://www.figma.com/file/q2QTrUQLmisr90FzvU7HLm/Request-Mockup?node-id=3733%3A11566
https://www.figma.com/file/q2QTrUQLmisr90FzvU7HLm/Request-Mockup?node-id=3734%3A12248
https://www.figma.com/file/q2QTrUQLmisr90FzvU7HLm/Request-Mockup?node-id=3734%3A12071

Acceptance Criteria

User accesses to this screen from Publish a Ride page (US#58) or Edit the Ride page (US[#9 ].
User shall input SS e-mail address into the edit box.
2.1. IF User inputs an invalid e-mail address and the system didn't find it in SSBS and between registered App users, the system shall mark the edit box with a red line and write "Error" under it.
2.1.1. Add invitation button shall be disabled.
2.2. User shall input only a unique SS email.
2.2.1. If User inputs the same SS email more than once, the system shall mark the edit box with a red line and write "Error" under it.
WHEN User pushes Add Invitation button, the system shall send a notification to the invited User.
User shall see a list of e-mails addresses (where invitations were sent) with the statement for each invitation (Sent, Accepted, Declined).
WHEN User pushes Save button, system shall save data into DB and transfer User to ___.

Assumptions & Constraints

Quantity of invited Users shall not exceed the number of available seats for this ride.
1.1. IF any invited User rejects the invitation, the inviting person can send invitation to another App User.

Epic link
Epic #68
Labels to be added
"User story" ("story"), Priority ("pri: ")
Tasks

[ ] sample task.

Implemented


Some updates for NegativeBinomial

Uncomment the check_discrete_distribution tests.
Expand the documentation--explain the meaning of r and p.
Note that r can be real.

Closes gh-115.

I've long forgotten the context to #115 but this seems reasonable and if the tests pass then I think it's fine


Support private AzureDevOps uri's

Private DevOps url's have a different format, this PR allows those to work as well.
I opted to keep one DevOps class, but it seemed cleaner to split them up as both input and output differ greatly.

I don't have any way of testing it myself. Did it work as expected, @StevenThuriot ?


Add Autotools based build system

Also support various ANCIENT_API_foo macros in <ancient/ancient.hpp> in order to avoid having to define macros containing all kinds of escaping-requiring characters from the build system.
The supported common cases are ANCIENT_API_VISIBILITY_DEFAULT (any modern Unix-like system), ANCIENT_API_VISIBILITY_DEFAULT_USED (some Emscripten targets), and ANCIENT_API_DECLSPEC_DLLEXPORT/ANCIENT_API_DECLSPEC_IMPORT (Windows).
Rename old Makefile to Makefile.unix.
This avoids the name conflict with the automake Makefile generated by configure.
Add autoconf/automake/libtool/pkg-config build system.
The old build system stays functional (albeit with a non-standard Makefile.unix name). A simple work-around to just continue with the old build system is to use ln -s Makefile.unix Makefile while developing.
Introduce package versioning (using SemVer) and soname versioning via libtool.
Details are documented at the top of configure.ac.
Release tarballs can now be generated either as before via a direct repository snapshot, or via make distcheck.

This pull request addresses (5), (6), and (7) from #13.


Why is there no SVC?

Hello!
Thanks for the excellent library. I noticed some SVC files but they are commented out. Is there any reason why SVC is not implemented?
Thank You!

Hey @syedzayyan! Great question. For industrial libraries like scikit-learn, they solve the SVC problem by solving the dual, and using more linear algebra tricks. These tricks aren't really supported in the current version of Tensorflow.js. Initially I attempted to solve the SVC problem by using gradient descent (without the linear algebra tricks), but ran out of time before starting a new job.
Feel free to submit a PR if this speaks to you, and I will see it merged in.


b4 submission

node log concordium-testnet-node-720c35f70fd2b29380f055708077d72d6d8593428c8e7af40d76189dab2f4d50.log

confirmed:B4
address:3Py66Br8qxmUXvVDwZndFTBpMcwN84U8a7yg7wg7iKyYgvxG96
baker:558

confirmed:B4
address:3Py66Br8qxmUXvVDwZndFTBpMcwN84U8a7yg7wg7iKyYgvxG96
baker:558


Compile failed on windows machine

The crate version: polling v2.5.0
The rustc version: 1.61.0

The github action setup:
    - if: matrix.os == 'windows-2019'
      name: Windows Dependencies
      run: |
        iwr -useb get.scoop.sh -outfile 'install-scoop.ps1'
        .\install-scoop.ps1 -RunAsAdmin
        echo "LIBCLANG_PATH=$($HOME)/scoop/apps/llvm/current/bin" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
        echo "$env:USERPROFILE\scoop\shims" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
        scoop install llvm yasm

The error message:
error[E0432]: unresolved import `std::ffi::c_int`
 --> C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\polling-2.5.0\src\wepoll.rs:4:5
  |
4 | use std::ffi::c_int;
  |     ^^^^^^^^^^^^^^^ no `c_int` in `ffi`

For more information about this error, try `rustc --explain E0432`.

Thanks for the report! It seems we should use std::os::raw::c_int (added in rust 1.1) instead of std::ffi::c_int (added in rust 1.64).

Fixed in v2.5.1 (#50).

Whoops, my mistake. We may want to test the MSRV on all platforms to prevent this from happening in the future.

~Whoops, my mistake. We may want to test the MSRV on all platforms to prevent this from happening in the future.~ It looks like we do? Strange that it didn't catch that.

I guess maybe more careful chose a rustc version in CI would catch the problem :)

~Whoops, my mistake. We may want to test the MSRV on all platforms to prevent this from happening in the future.~ It looks like we do? Strange that it didn't catch that.

As for windows, I added CI for MSRV in #50.

~Whoops, my mistake. We may want to test the MSRV on all platforms to prevent this from happening in the future.~ It looks like we do? Strange that it didn't catch that.

As for windows, I added CI for MSRV in #50.

Oh, that explains it, thanks for taking care of that.


Update management-and-monitoring.md

Update the text for additional information:
Potential integration with on-premises security information and event management (SIEM) systems such as ServiceNow or ArcSight or Onapsis security platform

@roboban : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


pretrained discriminator request

Hello @huiyegit
First of all, thank you for providing this code!
I am trying to utilize transfer learning (as in http://arxiv.org/pdf/1805.01677v2) to see if I can optimize the model for my test domain. As far as I understand, I would need a pretrained Discriminator as well to perform this task.
Unfortunately, due to hardware limitations, I am unable to perform the training myself with reasonable effort. This is why I wanted to ask if it would be possible for you to provide the discriminator model to go with the DM-GAN-CL COCO Generator with 200 Epochs and the AttnGAN-CL COCO Generator with 80 Epochs?

I only saved the Discriminators of the last epoch. Here are the links:
AttnGAN+CL, COCO, epoch 120:   https://drive.google.com/file/d/1-dMiXaoNVitAs6hQBSPLanLUEDkW5uUS/view?usp=sharing
DM-GAN+CL, COCO, epoch 200:  https://drive.google.com/file/d/1ObfV_5N9YA9PRNJFfh1Omn8TLS2Dn1D7/view?usp=sharing

Tanks a lot!


more complaint data granularity

If the following are captured w/ IA Pro it would be great to display it on this site and allowable by local law:

officer name (consider unique IDs with common names) eg https://cpdb.co/data/bk42RA/citizens-police-data-project
relationships between officers working together & complaints eg https://cpdb.co/data/bk42RA/citizens-police-data-project
capture an anonymous complaint ID to capture community member that complain frequently; this might require harmonizing many complaint interfaces, eg in Baltimore there are 4 ways to complain: 311/911, walk-ins, civilian complaint review board, through PD IA
complaint narrative information (w all PII redacted of course), eg http://www.consumerfinance.gov/data-research/consumer-complaints/

if they aren't captured by IA Pro, they should be included in updated contract requirements or cities should consider RFPS for alternative software.

Hi @rebeccawilliams thank you for the suggestions. We're definitely keeping additional data and relationships like this in mind.
One question: when you say "relationships between officers working together and complaints", do you mean "co-accused officers", as shown on the cpdb site?

Thanks @tmaybe, yes that's what I was thinking of and from that example.
Other related items that would be interesting would be:

what departments or forces an officer has been a part of - this would help show both internally and externally if an officer with a substantial complaint history was reassigned (potentially triggering earlier intervention if new complaints arise) and give context to why an officer may have a higher complaint count (field v desk work)


You can't get the real source paths when using sourceMapEmbed

Hi,
I was trying to build a plugin that would extract images and web fonts from the generated CSS and copy them to the distribution directory.
The idea was to use sourceMapEmbed, then after this plugin generated the CSS, I would go get the map, list the original sources and search for url(...)s on the code, copy them and replace the path on the CSS.
The problem I found is that, because this plugin uses renderSync with the data option, the source map sources is stdin.
Playing around with the plugin code I saw that the only reason for using data is when you receive the prependSass option, and I was thinking that maybe you could use data only when prependSass has some value, and in case is empty, use file.
The change would be something like this:
- const sassConfig = Object.assign({ data: `${prependSass}${code}` }, options.options);
+ const baseConfig = prependSass
+   ? { data: `${prependSass}${code}` }
+   : { file: id };
+ const sassConfig = Object.assign(baseConfig, options.options);

The rest would work the same.
Would you consider it if I send a PR?
Regards

Hi @homer0, I think it could be nice.Fell free to send the PR.I will handle it in time.

hi @homer0  checkout the new version:
<EMAIL_ADDRESS>

@differui Awesome, thanks!!!


app icon for android & ios

adaptive icon foreground and background
backup icon for android and ios if adaptive fails
specific files created by the command:  flutter packages pub run flutter_launcher_icons:main

Looks fine. When this PR is approved only merge it after PR #8 is merged.


💡 [FEATURE] - Light Mode for the website

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
I will add a light mode for the website
Explain your solution
No response
Any alternative approaches/features
No response
Additional Context
No response

Duplicate


Research and Document Design inspirations for frontend

Request: build off others great work when implementing our own design.
Short description:

Current state:

Site is not intentionally designed, or drawing from any design philosophy.

Desired state:

We have a documented set of touchstones or inspirations to draw from when making our own front-end

Tasks:

[ ] (Add tasks to achieve desired state)

@zachmandeville: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

specifying the label manually: /sig <group-name>
e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

used landscape as sarting point, but focused on building something quickly for user feedback instead of having an indepth design document. still useful for future work, but will open a more specific ticket then.


[Bugfix:Submission] Fixed improper delete permission when assignment is viewed

Fixes #10916
Please check if the PR fulfills these requirements:

[ ] Tests for the changes have been added/updated (if possible)
[X] Documentation has been updated/added if relevant
[ ] Screenshots are attached to Github PR if visual/UI changes were made

What is the current behavior?

Currently, if an instructor creates an assignment, and the student views but does not submit it, the delete button will still appear for the instructor. When the instructor attempts a deletion, it will lead to a database error page.
What is the new behavior?
The viewing of the assignment will act like a submission was made for the purposes of delete checking. Meaning, the delete button no longer appears, and if an outdated delete button was pressed, it will only show a warning error popup and refresh the page.
Other information?

Tested manually using Chrome Tab for instructor and Chrome Incognito Tab for student on a Windows 11 device.

Hey this PR has to be inside the submitty repo not your personal one. It wouldn't be allowed to merge via your personal one.


Passtrough request to namer class

We should inject the @request_stack to the namer class.
Thanks to @nomadOnWeb for this idea (#228).

@bytehead This will result into a BC break. Do you like to directly merge it into a new version if I create a PR for it? Which version of this bundle does allow BC breaks?

We should just add RequestStack $requestStack as argument to the constructor. :+1:

Should be added to the docs for slow folks like myself ;-)


https://superset.apache.org/ - website not scrolling

Hello
https://superset.apache.org/ is having problems. On the right side of the pages there are scroll bars.  I am not able to scroll the Text down.

@arunpune I use the latest Firefox and Chrome on OSX, the websites are all normal.
which browser do you use?

@zhaoyongjie i have the latest Google Chrome Broswer.
Google Chrome is up to date
Version 86.0.4240.75 (Official Build) (64-bit)
I am not able to scroll it up and down.
https://superset.apache.org/docs/installation/installing-superset-using-docker-compose
check this link given above
It does not work on Fire fox Mozilla also

hey @arunpune, sorry we are not able to reproduce it in chrome or mozilla, and we have not seen any other similar reports. im closing this issue for now.

I have the same behavior - tried Firefox, Chro

me, Opera.
Windows 10 OS.
All browsers up-to-date
Scroll bar doesn't want to move more that what can be seen in the snip attached.
Tried re-dimensioning my browser, clearing cache, nothing works

@Adrian08011990 - thanks, but this appears to be a (closed) duplicate of #18868 .


Connect-DbaInstance - Support making DAC connection

Something I think @FriedrichWeinmann will need to assist with is allowing our DbaInstance parameter to handle admin:$instance so we can allow our connect command to make the DAC connection into SQL Server.
Currently, our type is borking because it can't parse it:

Once that is done then we can easily adjust the settings for the connection to handle making that DAC connection to the instance. Some of the leg work for this is being done via #6828

Happy to update that.
How exactly should I parse that notation however?
Is that <hostname>:<Instancename> ?

The "admin:" I would think should indicator that the fact connection is desired. I don't know if we maybe add a property for this?
Anything after that would be your normal host and/or instance name.

Alright, so basically I'll be parsing everything after the colon as the actual input and the leading 'admin:' changes the input-type to 'DAC' or somesuch, which Connect-DbaInstance will respect?
Can definitely do that :)
Today.

Thanks so much to you both 🥳

Well they are exceptions that what is on the left on the colon is used.
"tcp:" vs "np:" whitch I think is being handled either on the type or by connect command, can't remember.

(lol you made your theme sparkle, nice, @wsmelton !)

@FriedrichWeinmann - Is this already implemented?

No, requires a change to our library code.


ABJ status for students

When a student is not present but he has a justification, I can not save this information. Could we add a way to store this information?

+1

I didn't see where I can set this status in the interface. Maybe I missed something.


Silence warnings related to missing indices.

Suppress [E::idx_find_and_load] for files with missing indices.

I like this change.
To limit the repeated code, what if we change VariantFileStream to accept a filename instead of a file object?  Then, we could suppress the warnings one place in VariantFileStream.__init__.

Needs testing.


[docs] Add warning about download token exposure relates to #3605 and #3396

Description
Fixes #3605 #3396

warnings about tokens for public repos using expo which auto generates the keys within some critical files.
Reference to the android and iOS mapbox token setup guides for token creation and mention this is the recommended solution for public repos otherwise it violates mapbox private download token policies
Add alternative keychain solution for android which completely abstracts the key and removes risk of token theft via plain text.

Checklist

[x] I've read CONTRIBUTING.md
[ ] I updated the doc/other generated code with running yarn generate in the root folder
[ ] I have tested the new feature on /example app.

[ ] In V11 mode/ios
[ ] In New Architecture mode/ios
[ ] In V11 mode/android
[ ] In New Architecture mode/android

[ ] I added/updated a sample - if a new feature was implemented (/example)

I am also having troubles hiding my secret key when building my app with npx expo prebuild. This command exposes my secret key automatically. Can i hide that in gradle.properties somehow?

If you don't set RNMapboxMapsDownloadToken and set your secret token in your .netrc and gradle.properties does that work?
RNMapboxMapsDownloadToken was implemented for remote build on eas.

I am also having troubles hiding my secret key when building my app with npx expo prebuild. This command exposes my secret key automatically. Can i hide that in gradle.properties somehow?

If you don't set RNMapboxMapsDownloadToken and set your secret token in your .netrc and gradle.properties does that work?
RNMapboxMapsDownloadToken was implemented for remote build on eas.

Do you mean my global gradle.properties? Because Ive done it like this:
set my api key in app.config.js and eas.json.
When I run npx expo prebuild (--clean), it autogenerates new files and exposes my sk key in Podfile and /android/gradle.properties.
Is there a better way of handling it?

Right so I think I need to swap this diction here.
If the app requires OR commits native directories publicly, then usage of (ios) $HOME/.netrc and (android) android/local.properties / $HOME/.gradle/gradle.properties file for the secrets would be required in order to adhere to Mapbox's private token policy.
Apps would require committing their ios or android directories only if they did the following

the app is brownfield - a mixture of react-native and android
Has integrated other libraries that require custom code and do not support EAS or expo directly

Am I missing anything for these requirements?


Meta data displayed on FB for pages

The issue is that pasting for example this page http://netdevelopers.pl/facebook/top-last-month
into FB news feed should show there some content of the actual page. A teaser.
Currently this is displayed:
".NET Developers Poland
NETDEVELOPERS.PL"
What we should have in this particular case is something like:
"Top posts in January 2017" and some more info.

So basically this is about adding fb: tags in the header?


zaneh_ jquerysolution

Overall great job! :+1: You didn't include your comfort/completeness but hopefully it was easier to do this assignment the second time around.


Fix flaky test regarding PerformanceMeasure sampling rate

What does this PR do?
Fix a flaky test where our margin of error regarding sampling rate was too small.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.23%. Comparing base (a783738) to head (ded5bcb).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2046      +/-   ##
===========================================
+ Coverage    83.18%   83.23%   +0.04%
===========================================
  Files          493      493
  Lines        17691    17701      +10
  Branches      2681     2685       +4
===========================================
+ Hits         14716    14732      +16
+ Misses        2238     2228      -10
- Partials       737      741       +4

see 28 files with indirect coverage changes


Finetune using OpticalFlow Models

Hi @dutran,
First, thank you for making public this wonderful work.
I've already been able to use this code to finetune R(2+1)D model on my dataset and run dense prediction with success.
Now I would like to use Optical Flow for computing accuracy rate of R(2+1)D-Two-Stream and I have some questions:
1 - Can you provide the R(2+1)D-Flow trained in "Kinetics", because I found only trained "Sports1M+Kinetics"?
2 - Can you provide an example or tutorial that give more details of how to finetune Optical flow model, I notice that Optical flow models need a lot of parameters to train: frame_gap_of, sampling_rate_of, clip_length_of, flow_data_type, do_flow_aggregation, flow_alg_type?
Best regards,
Murilo Varges

@murilovarges

https://www.dropbox.com/s/qd0wjvhtqt88qx4/r2.5d_d34_l32_from_scratch_of_bn0.9.pkl?dl=0

For the parameters of optical flows, you can check them here https://github.com/facebookresearch/R2Plus1D/blob/master/scripts/extract_feature_kinetics_of.sh

@murilovarges

https://www.dropbox.com/s/qd0wjvhtqt88qx4/r2.5d_d34_l32_from_scratch_of_bn0.9.pkl?dl=0
For the parameters of optical flows, you can check them here https://github.com/facebookresearch/R2Plus1D/blob/master/scripts/extract_feature_kinetics_of.sh

What does the file in 1 contains? Does it contain the weights of R(2+1)D model trained from scratch using kinetics flows?


bug(mat-radio-group): Problems with name attribute

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Credits to find bug to @RedHeadEmile
The mat-radio-group create input type="radio" with the same name that the parameter "name" in mat-radio-group
    <mat-radio-group name="test" >
      <mat-radio-button [value]="..."></mat-radio-button>
      ...
    </mat-radio-group>

This makes that if you have a component like
   <mat-radio-group name="test" [(ngModel)]="variable">
      <mat-radio-button [value]="false">False</mat-radio-button>
      <mat-radio-button [value]="true">True</mat-radio-button>
    </mat-radio-group>]

You can not use two times in a component
<fool-component></fool-component>
<fool-component></fool-component>

See the SO discussion
Reproduction
Steps to reproduce:

See the behaviour fool-component in this stackblitz
When you select one of the radio buttons, deselect the radio buttons of the another component

Expected Behavior
You can select the radio-buttons independiently
Actual Behavior
You can not select the radio-buttons independiently
Possible solution: change the _updateRadioButtonNames function adding the nextUniqueId to the name of the radios
Environment

Angular: 15.0.0
CDK/Material: 15.0.3
Browser(s): any
Operating System (e.g. Windows, macOS, Ubuntu): any

I think it's working as intended. Changing _updateRadioButtonNames woud include a breaking change. Radio buttons are scoped globally even in native html. It's the developer's responsibility to define unique names for different radio-groups.
Your example with native radio buttons produces the same result.

Totati, in my opinion, has no sense that the name of the created radio buttons depends if I use the "name" in the mat-group or not. Who matter this names to?

Then use ReactiveForms so you don't have to provide a name :) TemplateDrivenFroms requires you to name your controls (you even get an error when you don't), so it's your responsibility to name them correctly. MatRadioGroup makes it easier to name your radios as you don't have to name them individually, it takes care of this. Yes they use a generated unique name when you don't provide one, so if you don't have to care about the name (when you use ReactiveForms, or use standalone ngModels), you can ignore it. The same could happen with id-s. If you hardcode an id in a component and you repeat that component, well, you designed your component badly as it would produce invalid HTML. You should not think about the solution (which has been accepted on SO) as a hack, because that's what HTML and TemplateDrivenForms requires you to do.

Closing since this is how native radio buttons work as well. It's up to the consumer to provide an appropriate name or leave the name blank which will allow Material to auto-generate one for you.


QPS is too small to cause problems

When a large number of jobs are submitted in a short period of time，queueunit client qps  too small causes the qu update Dequeued to block for a long time，throughput drop

Support by #45
/close


[Installation]: editable install fails with setuptools 70.0.0

Your current environment
Ubuntu 22.04.4 LTS
python 3.10.12
torch 2.1.2+cpu
vLLM 0.3.3+neuron205

How you are installing vllm
pip3 install -e vllm

Error message
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error

  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [21 lines of output]
      /tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_nu
mpy.cpp:84.)
        device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
      Traceback (most recent call last):
        File "/usr/local/lib/python3.10/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/usr/local/lib/python3.10/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/usr/local/lib/python3.10/dist-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 132, in get_requires_for_build_editable
          return hook(config_settings)
        File "/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 448, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
        File "/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/setuptools/build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 13, in <module>
        File "/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 28, in <module>
          from pkg_resources import packaging  # type: ignore[attr-defined]
      ImportError: cannot import name 'packaging' from 'pkg_resources' (/tmp/pip-build-env-9h8zh2_3/overlay/local/lib/python3.10/dist-packages/pkg_resources/__init__.py)
      [end of output]

Workaround
setuptools 70.0.0 was released earlier today. Pinning it to version 69.5.1 here resolves the issue.

How do I apply it in colab or paperspace?

Seem to be an issue of setuptools version 70, try pip install "setuptools<70.0.0".

setuptools 70.0.0 was released earlier today. Pinning it to version 69.5.1 resolves the issue.

You saved me hours of further googling, thank you!

How do I apply it in paperspace?

git clone vllm
cd vllm
edit pyproject.toml, and modify this line to be "setuptools = 69.5.1",
pip3 install -e .

FYI: torch>=2.2.0 updates torch/utils/cpp_extension.py to no longer import pkg_resources. Therefore, this problem should not occur with the latest version of vLLM which uses torch==2.3.0.


perf: improve upsert responses bulk

Description
This PR applies some performance improvements related to the bulk upsert responses endpoint since some environments are experimenting with a high execution time when running this operation with 100 items in the request.
The performance improvements are:

Read all requested records at once instead of once at a time.
Stop checking the existence of the search index since is taking longer.

These improvements are applied based on the profiling results using the test ...
Also, since the current API controller is doing many things, a new design proposal is applied in the implementation by defining a simple use case implementation for this functionality. The use case wraps all the needed steps to cover the functionality and make the controller implementation quite simple, focusing only on exception handling and request/response serialization.
Closes #4449
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[ ] New feature (non-breaking change which adds functionality)
[X] Refactor (change restructuring the codebase without changing functionality)
[X] Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference tests)
Test locally
Checklist

[ ] I added relevant documentation
[X] I followed the style guidelines of this project
[X] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Great work @frascuchon discarding 100 records.


Compensate for MAC part of the crypto function deprecation

This alleviates part of the usability degradation reported in #14628.

Add convenience ~functions EVP_MAC_calc() and OSSL_HMAC()~ one-shot MAC function EVP_Q_mac().
This helps compensating for deprecated functions such as HMAC()
and reduces clutter in the crypto lib, apps, and tests.
Also fixes memory leaks in generate_cookie_callback() of apps/lib/s_cb.c.

~Add hints how to replace deprecated SHA256() and the like~
Update: this item has moved to #14741.

~Add simple convenience functions OSSL_keygen(), OSSL_RSA_keygen(), and OSSL_EC_keygen().
Also improve deprecation information on RSA and EC key generation/management functions.~
Update: this item has moved to #14695.

ssl.h.in: Fix deprecation exclusion for SRP-related declarations

DOC: Fix all wrong occurrences of <propq> to I<propq>

Checklist

[x] documentation is added or updated
[x] tests are added or updated

The naming of these functions should be properly discussed by OTC.

I don't want to get into naming arguments, but I will point out that "Q" is a loaded term in the United States these days.

I don't want to get into naming arguments, but I will point out that "Q" is a loaded term in the United States these days.

Yeah, and moreover 'Q' is a pretty unclear abbreviation.
I do not think we need it.
Here I've changed the preliminarily used names to EVP_mac() and OSL_keygen().

When replacing the legacy low-level implementation of HMAC(),
I found that HMAC() is still in use at multiple places in
providers/implementations/rands/drbg_hmac.c and
providers/implementations/kdfs/hkdf.c - is this on purpose?
I had to replace one of these uses, namely at the end of HKDF_Extract(),
by EVP_mac(libctx, "HMAC", NULL, ...) and therefore pass in libctx
because otherwise fetching the HMAC algorithm would have failed for the internal HKDF
test in self_test_kdf().
I also had quite some trouble with other HMAC (-based) tests and with
apps/openssl fipsinstall -module providers/fips.so -provider_name fips -mac_name HMAC -section_name fips_sect

because there is an obscure case that the key input can be NULL for single-shot calculations, and eventually I was able to fix those by employing in EVP_mac() essentially the same trick as done in the original HMAC()` implementation:
    /* Single-shot - on NULL key input, set dummy key value for EVP_MAC_Init. */
    if (key == NULL && keylen == 0)
        key = data;

When replacing the legacy low-level implementation of HMAC(),
I found that HMAC() is still in use at multiple places in
providers/implementations/rands/drbg_hmac.c and
providers/implementations/kdfs/hkdf.c - is this on purpose?

Yes, this is fine.  We do reserve the right to use those functions internally, since they are the actual implementation.  What else would we use?  There will be a point in the future, when the deprecated symbols have been removed from public view and these functions are truly only used in our providers, where we probably will shuffle around a lot of source to make things clearer.
Please remember that deprecation doesn't necessarily mean that functionality is removed, just the symbols will be removed from public view.

We do reserve the right to use those functions internally, since they are the actual implementation. What else would we use?

Yeah, at one place the actual default implementation needs to be done,
but I was not sure if this is HMAC() in hmac.c itself
(and if so, it could likely be sufficient to reference it once).

We do reserve the right to use those functions internally, since they are the actual implementation. What else would we use?

Yeah, at one place the actual default implementation needs to be done,
but I was not sure if this is HMAC() in hmac.c itself
(and if so, it could likely be sufficient to reference it once).

You might also want to consider how self contained a provider implementation is.  Hypothetically, by adding the extract indirection of using EVP_mac() instead of HMAC() in the provider, you make it do the whole fetching thing, and also possibly fail, if somehow the HMAC algorithm is unavailable for fetching.  Using the more internal method of calling HMAC directly take away a possible error path.

What is the difference - morally speaking - between OPENSSL_COMPENSATE_DEPRECATION and OPENSSL_SUPPRESS_DEPRECATED?

Good that you ask.

OPENSSL_NO_DEPRECATED (which can be triggered by the configuration option no-deprecated) hides declaration and implementation of symbols deprecated for OpenSSL versions up to (i.e., below or equal to) the version given by OPENSSL_API_COMPAT (which by default refers to the current OpenSSL version).
OPENSSL_SUPPRESS_DEPRECATED has effect only when OPENSSL_NO_DEPRECATED does not take effect, i.e., deprecated symbols are still usable.
Its effect then is to disable deprecation warnings.
In the light of this clarification, I'd say it should better be called OPENSSL_NO_DEPRECATION_WARNINGS.
OPENSSL_COMPENSATE_DEPRECATION has effect only when OPENSSL_NO_DEPRECATED is defined, i.e., in situations where deprecated symbols are hidden. In this case, it adds #defines that compensate for the loss of certain commonly used symbols, such as SHA256() and HMAC().

@t8m, the "OTC hold" label can be removed.

As just discussed in the OTC meeting,
I've adapted the name of the new quick one-shot EVP_mac() function to EVP_Q_mac().
Also tentatively removed the OPENSSL_COMPENSATE_DEPRECATION macro
since apparently it's not really needed - see https://github.com/openssl/openssl/issues/14628#issuecomment-818609682.

A macro should stay - for the compatibility #defines. Not for the whole EVP_Q_ api.

The OPENSSL_COMPENSATE_DEPRECATION macro should stay - for the compatibility #defines. Not for the whole EVP_Q_ api.

All right, so kept OPENSSL_COMPENSATE_DEPRECATION.

Is there anything more to do on this PR?

According to https://github.com/openssl/openssl/issues/14628#issuecomment-819247760, removed all the OPENSSL_COMPENSATE_DEPRECATION business.

Rebased to fix merge conflicts.
Can this be approved now?

@t8m, I wonder why you removed the 3.0.0-beta1 milestone?
This needs to get in before API/feature freeze.

Because it is not a 3.0 blocker. So it can be reviewed and merged before beta1 but we will not block the release for it.

@paulidale, nearly two weeks ago you wrote:

This looks really good. Just a few minor things to consider.

and I responded to all those things, see above.
Can you approve now?

Rebased again to fix ugly merge conflicts.
@paulidale can you please approve now?

check_update CI failure appears unrelated.

It is probably related. You need to run make update on a build configured with enable-fips

2021 21:30, 21:30, David von Oheimb @.***> napsal/a:

check_update CI failure appears unrelated.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/openssl/openssl/pull/14664#issuecomment-832951893

It is probably related. You need to run make update on a build configured with enable-fips

Oh, what a counter-intuitive new requirement!
If this continues to be needed it should be enabled by default.
At first it had no effect, but after installing unifdef it worked.
Thanks for the hint. check_update now succeeds.

It is probably related. You need to run make update on a build configured with enable-fips

Oh, what a counter-intuitive new requirement!

It should be easy to add a check into "make update" that sees if FIPS is enabled in the current build and exit if not.

If this continues to be needed it should be enabled by default.

At first it had no effect, but after installing unifdef it worked.

That should also be checked which unifdef >/dev/null || { echo no unifidef; exit 1}

Looks good. Apologies for the delay, this fell to the bottom of the list and I didn't remember :(

Thanks @paulidale and @slontis for your approval and further comments, which I just handled.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Rebased to fix merge conflict and add author name in CHANGES.

Looks like there is still one :(
I don't think these fixes need reset the timer or need reapproval.

Looks like there is still one :(

These conflicts all the time on the FIPS checksums are a PITA.
I wonder why this is needed each time - wouldn't it be sufficient to do that for releases?

I assume you mean Mediterranean flatbread :)

I certainly would prefer eating Pita over fixing intermittent FIPS checksum errors :stuck_out_tongue_winking_eye:

These conflicts all the time on the FIPS checksums are a PITA.

I assume you mean Mediterranean flatbread :)

I certainly would prefer eating Pita over fixing intermittent FIPS checksum errors :stuck_out_tongue_winking_eye:

Well, but if I ate pita as often as I fixed FIPS checksums (or at least tried to do do) recently I would get fat :frowning_face:


Error reporting MAC connection to Docker-Desktop

I made the following mistake when I used Lens to connect to the Docker-Desktop Times on the MAC
Both Docker and Kubernetes are running
2020/06/18 08:42:17 http: proxy error: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "kubernetes")

macos10.14
docker-desktop version <IP_ADDRESS>
docker version 19.03.8
kubernetes version 1.16.5

how to enable debug mode

Hello, facing same issue with windows docker desktop, if anyone has a working solution? Thanks in advance.


pandas 1.0.3 does not recognize cftime.DatetimeGregorian as time

Apologies if I've missed this issue being raised elsewhere.
Creating a pandas index from cftime.DatetimeGregorian objects results in an index which is not understood as a time index by pandas. I think this appeared with the latest pandas version but I'm not sure:
import cftime
import pandas as pd

print(cftime.__version__)
print(pd.__version__)

t = [cftime.DatetimeGregorian(2012, 6, 1)]
s = pd.Series([1], index=t)

s.index.year

Output:
<IP_ADDRESS>
1.0.3
Traceback (most recent call last):
  File "/home/mowglie/Documents/git/salem/salem/sandbox.py", line 10, in <module>
    s.index.year
AttributeError: 'Index' object has no attribute 'year'

Thanks!

I'd be surprised if this particular example ever worked.  Pandas on its own does not know how to cast cftime dates to an xarray.CFTimeIndex.
Perhaps you were hit by the change made in https://github.com/Unidata/cftime/pull/135, where datetime.datetime objects were no longer returned by default when possible by cftime.num2date?

Thanks for the quick reply!
This seems to be it. I'm using netCDF4.num2date to read times that I feed to pandas afterwards. Strangely enough, latest netCDF4.num2date on my env (4.8.3) does not have the only_use_cftime_datetimes kwarg available yet (although it is documented).
Anyways, I'll find my way possibly by using cftime.num2date directly. I'm a it concerned that  cftime.num2date now returns objects that aren't recognized by pandas, but I think you guys know what you have to do ;-)


Pull Operator username from config.json or Window.prompt()

Currently we need an operator username to pull the operator details. We dont have any kind of account/operator creation for the time being.
Therefore, we'll need to pull an operator username from a configuration file. There is an argument to be made that we include a config.json in the source code, but I believe this is not ideal. Someone who has downloaded the binary of Operator or compiled from source can either:
A) create the config.json manually in the same directory the binary is, or,
B) get a Window.prompt() on first load for the API/Socket server URI
So we need to:

Every time we load the application, check for a config.json file.
If it doesn't exist, Window.prompt() the user for an operator username.
Add that operator into, and create a config.json file

There is significant overlap with this and Issue #10, whoever takes this on should probably do both. Both should use the same config.json file

Resolved in #40


Raise more information when file can not be found

These are usually two cases where we can not load a map:

there is no corresponding file found
the format of the found file is not correct

Before this PR, there we will always show the same error for these two cases. This PR first checks the first case then the second.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 84.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
1970

Relevant Lines:
2343

💛  - Coveralls


Undo and Redo Shortcuts!

Functionality is correct from my testing. Organization is probably not optimal. Particular attention would be appreciated for testing a bunch of different combinations of proof and draw tools. Marking ready for review


esbuild fails with - No loader is configured for ".node" files

Trying to build my project with esbuild, index.js throws errors for all of the binary targets.

Hi @mattrochon,
To resolve the above issue you would need to use .node loader. See: https://github.com/evanw/esbuild/issues/1051. Let me know if this helps.

I have tried that solution but it is not able to resolve the files on deployment to a lambda function.
The plugin proposed there tries to load all of the binaries, even ones that havent been installed and fails.
Bit out of my depth on this bundling stuff but very much would like to be able to use the node engine in my lambda function.

@mattrochon What specific set-up are you using (e.g. aws starter template, esbuild template, etc.)?

I'm not sure how to get this to build properly using esbuild. Do you have any insight here?

ok, add
--external:@gorules/zen-engine
and make sure your node modules has the binary targets you need
and itll work

Thanks for sharing! I'll close the issue now.

ok, add
--external:@gorules/zen-engine
and make sure your node modules has the binary targets you need
and itll work

@mattrochon I'm in a very similar position to yourself. Why would you mark zen-engine as an external module? Are you also copying that into the lambda? Would you mind sharing your esbuild config?
Thanks for any help you can provide

So, copy it in the lambda and exclude specific platforms used. If you do local seploy from mac, then exclude darwin one, and if you do it via GH actions, exclude the x64 one like so:


fix button "Message with" style

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23769
PROPOSAL: https://github.com/Expensify/App/issues/23769#issuecomment-1654683433
Tests

Open the app and login with any account.
Click on FAB > split bill > enter an amount then click next.
Share with account has long email (example: nathanmulugetatesting+12345@gmail.com).
Split the bill.
Click on the IOU card to open its details.
Click on the account you split the bill with him.
Verify that the "Message with" button is not truncated early before the end of line.
Return to the chat and mention an account that has a long email (example: nathanmulugetatesting+12345@gmail.com).
Select the mention to navigate to the details page.
Verify that the "Message with" button is not truncated early before the end of line.

[x] Verify that no errors appear in the JS console

Offline tests
N/A.

QA Steps
Same as Tests step.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/41129870/50129f14-72ba-4788-85ef-fe32b13678d7

Mobile Web - Chrome
https://github.com/Expensify/App/assets/41129870/3284e44c-055c-4ca5-ba74-6826c08c8342

Mobile Web - Safari
https://github.com/Expensify/App/assets/41129870/fe26e208-9680-4bde-991f-faf7eec8b5c1

Desktop
https://github.com/Expensify/App/assets/41129870/3d1e47df-9994-437a-bc38-ea730f2315b3

iOS
https://github.com/Expensify/App/assets/41129870/1f3fb56f-fee2-4e04-9cdd-c2a0bddb28a0

Android
https://github.com/Expensify/App/assets/41129870/bd33e316-5a85-4720-a179-5cfc72c2f668

@Ollyws update Tests step.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


CTAS from CTE query that extracts scalar columns from json tables does not do distinct

CTAS from CTE query that extracts district scalar columns from json tables does not do distinct
create table test_distinct_scalar_from_json  as (with cte1 as ( select scalar_col_1, scalar_col2, json_col_1 from tables)
, cte2 as (select scalar_col_1, extract_scalar_from_json_col_1 as scalar_col_11 from cte1)
select distinct  scalar_col_1,scalar_col_11 from cte2 )
succes in creating the table with duplicates in the resulting table.

!👎


WIP: Fast-RTPS not terminating cleanly

Convert the transport UDP receiver into a non-blocking receiver to permit proper thread termination.
issue #473

I don't think this is the correct path for this kind of change. I would much rather see an implementation parallel to the TCP non-blocking implementation.


Bittrex create_limit_buy_order 'string indices must be integers'

I'm having trouble placing orders on Bittrex:
The verbose output is monstrously long. Let me know if you need it...
    print bittrex.create_limit_buy_order('FUN', 6570, 0.00000519)
Traceback (most recent call last):
File "C:\Users\Kenneth\eclipse-workspace\Chank\CCXTtests.py", line 91, in
print bittrex.create_limit_buy_order('FUN', 6570, 0.00000519)
File "C:\Python27\lib\site-packages\ccxt\exchange.py", line 918, in create_limit_buy_order
return self.create_order(symbol, 'limit', 'buy', *args)
File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5037, in create_order
'market': market['id'],
TypeError: string indices must be integers, not str

@PhinixPhire hi! There's no such pair as 'FUN' on Bittrex:
mbp:ccxt igorkroitor$ python examples/py/symbols.py bittrex | grep FUN

id              symbol          base            quote

BTC-FUN         FUN/BTC         FUN             BTC
ETH-FUN         FUN/ETH         FUN             ETH

Looks like there are only two pairs, invoving the FUN currency on Bittrex, namely:

'FUN/BTC'
'FUN/ETH'

Does this answer your question?

Oops. Unfortunately, I gave you output from a misrepresentative test (should have been FUN/BTC). Here's the trouble I'm having, despite API permissions set appropriately:
Traceback (most recent call last):
File "C:\Users\Kenneth\eclipse-workspace\Chank\CCXTtests.py", line 91, in
print bittrex.create_limit_buy_order('FUN/BTC', 6570, 0.00000519)
File "C:\Python27\lib\site-packages\ccxt\exchange.py", line 918, in create_limit_buy_order
return self.create_order(symbol, 'limit', 'buy', *args)
File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5042, in create_order
response = getattr(self, method)(self.extend(order, params))
File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5166, in request
raise ExchangeError(self.id + ' ' + self.json(response))
ccxt.errors.ExchangeError: bittrex {"message":"INVALID_PERMISSION","result":null,"success":false}

@PhinixPhire well, if Bittrex says INVALID_PERMISSION, then you probably confused it and didn't set appropriate permissions on an appropriate keypair. Could you misplace the keys somewhere? If you're using multiple keypairs, check that they are not getting redefined or overrided implicitly by a mistake. Are you sure your keys are set up correctly?

I am sure. I just created a fresh pair with appropriate permissions and have the same error. fetch_balance, on the other hand, works fine.

@PhinixPhire can you post verbose output?

Sure thing!
('https://bittrex.com/api/v1.1/market/buylimit?nonce=1507568144243&rate=0.00000519&apikey=[REMOVED]&market=BTC-FUN&quantity=500.00000000', 'GET', 'https://bittrex.com/api/v1.1/market/buylimit?nonce=1507568144243&rate=0.00000519&apikey=[REMOVED]&market=BTC-FUN&quantity=500.00000000', '\nRequest:', {'apisign': '[REMOVED]', 'Accept-Encoding': 'gzip, deflate', 'User-Agent': 'ccxt/1.9.65 (+https://github.com/kroitor/ccxt) Python/2.7.14'}, None)
('GET', 'https://bittrex.com/api/v1.1/market/buylimit?nonce=1507568144243&rate=0.00000519&apikey=[REMOVED]&market=BTC-FUN&quantity=500.00000000', '\nResponse:', 'Date: Mon, 09 Oct 2017 16:55:45 GMT\r\nContent-Type: application/json; charset=utf-8\r\nContent-Length: 80\r\nConnection: close\r\nSet-Cookie: __cfduid=d47f9b519cb7bb05d99a1de5a72376e0c1507568145; expires=Tue, 09-Oct-18 16:55:45 GMT; path=/; domain=.bittrex.com; HttpOnly\r\nCache-Control: private\r\nContent-Encoding: gzip\r\nStrict-Transport-Security: max-age=15768000\r\nX-XSS-Protection: 1; mode=block\r\nX-Content-Type-Options: nosniff\r\nX-Download-Options: noopen\r\nServer: cloudflare-nginx\r\nCF-RAY: [REMOVED]-LAX\r\n', u'{"success":false,"message":"INVALID_PERMISSION","result":null}')

@PhinixPhire , so, if you return to the API keys setup page on their webiste, your trade limit permission for the key looks like the one shown below (the second key on that image), does it?

I am asking, because I'm able to place orders on Bittrex with ccxt in all three languages (JS, Python and PHP) with an appropriately set up keypair (just checked that). So it must be an issue with:

improperly set up permissions
misplaced keys somewhere

Can you try a minimal setup with your key:
import ccxt
bittrex = ccxt.bittrex({
    "apiKey": "YOUR_KEY",
    "secret": "YOUR_SECRET",
    "verbose": True,
})
print(bittrex.create_limit_buy_order('FUN/BTC', 500, 0.00000519))

?

I'm terribly sorry. I was under the impression that setting restricted the API trades to a maximum. Changing it did indeed fix the issue.
Apologies. And Thanks!

@PhinixPhire no problem! Thanks for reporting back. Let us know if you have any other difficulties or questions with it. Cheers!