peer-to-peer code review 9th Sept

Your design looks great and responsive. but I believed it could be improved by generating the cards through Javascript.
Also please the use of insertAdjacentHTML is more security efficient than using innerHTML. please in your free time make that adjustment.

Great job on the project 🎉 .  The project part is displaying well and the pop-up window is as n the project requirements. But when you zoom out the page, the card containers expand and don't look any more like the template. It would be interesting to handle that for a better user experience.

👍 Good Job
Everything Looks Good and clean on the page and it is well documented.
You can also consider generating the cards from your Js File.

Your design looks great and responsive. but I believed it could be improved by generating the cards through Javascript.
Also please the use of insertAdjacentHTML is more security efficient than using innerHTML. please in your free time make that adjustment.

Thanks, I will implement these

Great job on the project 🎉 . The project part is displaying well and the pop-up window is as n the project requirements. But when you zoom out the page, the card containers expand and don't look any more like the template. It would be interesting to handle that for a better user experience.

Thanks, I will surely fix that

👍 Good Job Everything Looks Good and clean on the page and it is well documented. You can also consider generating the cards from your Js File.

Thanks, I will work on that


Upgrade Opendistro to Previous versions - Dependency Issues

Hello,
I'm trying to upgrade Openditro from version 1.0.2 to version 1.7.0 with CENTOS 7. I'm following the docs as below but i'm getting dependency issues.
yum install opendistroforelasticsearch-1.7.0
Error: Package: opendistro-knn-<IP_ADDRESS>-1.noarch (opendistroforelasticsearch-artifacts-repo)
Requires: elasticsearch-oss = 7.6.1
Removing: elasticsearch-oss-7.0.1-1.x86_64 (@elasticsearch-7.x)
elasticsearch-oss = 7.0.1-1
Updated By: elasticsearch-oss-7.8.0-1.x86_64 (elasticsearch-7.x)
elasticsearch-oss = 7.8.0-1
Available: elasticsearch-oss-6.3.0-1.noarch (elasticsearch-6.x)
elasticsearch-oss = 6.3.0-1
Available: elasticsearch-oss-6.3.1-1.noarch (elasticsearch-6.x)
elasticsearch-oss = 6.3.1-1
Available: elasticsearch-oss-6.3.2-1.noarch (elasticsearch-6.x)
Is there any way to upgrade Opendistro to previous versions? I've tested to upgrade to the last version and it was succesfull.
Thanks in advance.
Gabriel.

Hi @gferrette sorry for the inconvenience here.
Seems like there is an issue with our docs on upgrading process, sorry about that.
Here is an option I test it myself to upgrade from 1.0.2 to 1.7.0.
Note that I use a wildcard due to 1.7.0 have plugin version all match to <IP_ADDRESS>, not necessarily true for all releases:
https://opendistro.github.io/for-elasticsearch-docs/docs/install/plugins/
sudo yum install yum-utils sudo yumdownloader elasticsearch-oss-7.6.1 sudo yumdownloader opendistroforelasticsearch-1.7.0 sudo yumdownloader opendistro-*<IP_ADDRESS> sudo yum install `ls | grep rpm`
I am seeing:
``
Installing:
opendistro-anomaly-detector   <IP_ADDRESS>-1
opendistro-index-management   <IP_ADDRESS>-1
opendistro-knn   <IP_ADDRESS>-1
Updating:
elasticsearch-oss   7.6.1-1
opendistro-alerting   <IP_ADDRESS>-1
opendistro-job-scheduler   <IP_ADDRESS>-1
opendistro-performance-analyzer   <IP_ADDRESS>-1
opendistro-security   <IP_ADDRESS>-0
opendistro-sql   <IP_ADDRESS>-1
opendistroforelasticsearch   1.7.0-1
``
NOTE: I have no data in my test and I recommended you to test this on another server with dummy data to check if data is correct after the upgrade.
Please let me know if you have any other questions.
I hope this could help you with your upgrade.
Thanks,
Peter

Hello @peterzhuamazon !
I've tested this procedure that you have suggest on my test environment and it worked like a charm!
On saved objects now i see"Advanced Settings [7.0.1]" and "Advanced Settings [7.6.1]" after upgrade.
Do you know if i can delete "Advanced Settings [7.0.1]"?

Thank you very much for your quick answer!
Gabriel.

Hi @gferrette I am not sure about this.
Where did you see this happening?
Could you show me the entire page?

Hello @peterzhuamazon !
Sure, follow below the entire page, i saw that on Management->Saved Objects:

Hi @gferrette could you show me the contents of both advanced settings?
If the contents of these saved objects do not affect normal usages, then you can just keep it there.

Hello @peterzhuamazon !
Both advanced settings have the same content as example bellow, if I change something on one "Advanced settings" it is reflecting on the other one.

Hi @gferrette you can just leave it as it be, seems like it wont impact normal usages.
If you really want to remove it:

We suggest you test the deletion on your test machine and see if there is any issues
Make sure you export the saved objects as a backup before doing so:
https://www.elastic.co/guide/en/kibana/current/managing-saved-objects.html#:~:text=Kibana are overwritten.-,Exportedit,and export objects by type

Thanks,
Peter

Hello @peterzhuamazon !
Thanks a lot for this help.
I'm going to make those tests.
Att,
Gabriel.


feat: decompose into reusable functions

Make BGPS less opinionated and easier to use.

no longer applicable due to v2 rewrite


Concurrent BulkInsertOrUpdateAsync Calls with UpdateByProperties Set, throws Duplicate Key Name Errors

I have an import script that runs 3 concurrent instances, each perform a BulkImportOrUpdateAsync call with the UpdateByProperties value set to my unique Key of my object.
However; when running this routine, I will occassionally get errors in regards to a Duplicate Key Name on the Temp Key it tries to create using the UpdateByProperties field. (This field does have a Unique Key already set)
Is there some property I can set so that the Temp Keys created to have a random identifier like the Temp Tables. Or could this be implemented if not?
                await context.BulkInsertOrUpdateAsync(distinctSummonersList, options =>
                {
                    options.UpdateByProperties = [nameof(Summoners.Puuid)];
                });

public class Summoners
{
    [Key] public uint Id { get; set; }
    [MaxLength(78)] public string Puuid { get; set; }
    [MaxLength(64)] public string SummonerId { get; set; }
    public PlatformRoute Platform { get; set; }
    [MaxLength(43)] public string RiotId { get; set; }
    public ushort ProfileIcon { get; set; }
    public ushort SummonerLevel { get; set; }

    // RowVersion property
    [Timestamp]
    public byte[] RowVersion { get; set; }

    public ICollection<SummonerRanks> RankedEntries { get; set; }
    public ICollection<Participants> MatchHistory { get; set; }
}

            modelBuilder.Entity<Summoners>()
                .HasKey(s => s.Id);

            modelBuilder.Entity<Summoners>()
                .HasIndex(s => s.Puuid)
                .IsUnique();

            modelBuilder.Entity<Summoners>()
                .HasIndex(s => new { s.Platform, s.SummonerId })
                .IsUnique();

            modelBuilder.Entity<Summoners>()
                .Property(s => s.Platform)
                .HasConversion<short>();

            modelBuilder.Entity<Summoners>()
                .Property(s => s.RowVersion)
                .IsRowVersion();

Are you using SqlServer?, since there as far as I know Temp table does not have nor created any Key or Indexes.
If that's what you are reffering to.

I am using MySQL, I did transition over to SQLServer briefly and didn't experiance this issue which I think is because of what you mentioned here. But decided in the end to revert back

Thinking about it, is this intended? I already have a Unique Key set against my Puuid column. Is there a reason why it needs to setup a Temp Key against that column again for the same table.
I am wondering if my configuration is perhaps wrong?
I have defined it as a Unique Index within my model builder. Is there anything else I can do so that it uses this Key rather than trying to create a new one.

From my understanding the issues are likely one or more of the following:

My Unique Key on my Puuid Column is not being picked up. Resulting in the code attempting to create a temporary Unique Key against the table that already has a Unique Key. Possible configuration issue on my side in the Table, C# Object, or EF Core Model Builder. What are your suggestions to handle this?
The "GetUniqueConstrainName" function within "MySqlQueryBuilder" only creates a Key Name that is Unique Outside of Concurrency. In my case because I have 3 different instances interacting with my Summoners Table. All of them are generating the same "Unique" Constrain Name. If this was actually Unique with some randomness inserted this would likely solve the issue.

Curiously, if I want to run my code concurrently, what are the best practices you suggest?


Why redirect_to_login when target URL does not require login

If target URL does not require login and session_is_expired is true, user should continue to target URL instead of being redirected to login page!

Agreed. Alternatively, a method should be run (defined in settings?) that takes a request and lets the developer decide whether to redirect.


DEPS: array-api-strict to v2

Description
Description
Trying validate #1902 with #1861 changes. In case of green CI, #1902 will be approved and merged and #1861 will be rebased for the new changes.
Based on #1861
TODO:
Additionally array-api-compat addition into requirements list will be checked

Checklist to comply with before moving PR from draft:
PR completeness and readability

[ ] I have reviewed my changes thoroughly before submitting this pull request.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
[ ] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
[ ] I have added a respective label(s) to PR if I have a permission for that.
[ ] I have resolved any merge conflicts that might occur with the base branch.

Testing

[ ] The unit tests pass successfully.
[ ] I have run it locally and tested the changes extensively.

Performance

[ ] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
[ ] I have provided justification why performance has changed or why changes are not expected.

/intelci: run

/intelci: run

/intelci: run


Remove scalar aliases and iterable

Hey there,
I started working on something similar and after implementing a couple of backports I found your project. Thanks for the effort!
I added checks for the scalar aliases boolean and double (which I would prefer to never ever see, but some people still use ...) and for the PHP 7.1 iterable.
Cheers,
Mike
P.S. more PRs coming in the next few days (if you're interested)

The tests failed because of array in class constant. Could you please move the array from constant to variable?

Will do when I'm home. Thanks.
On Jul 17, 2017 16:17, "Ondřej Bouda"<EMAIL_ADDRESS>wrote:

The tests failed because of array in class constant. Could you please move
the array from constant to variable?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ondrejbouda/php7backport/pull/13#issuecomment-315768036,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACEXfe7FVG7_29b5pjnyiQpA2F0284p6ks5sO2wdgaJpZM4OZZjh
.

Done


Toggling an ion-searchbar in the toolbar does not resize ion-content appropriately

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
If I have a page consisting of an ion-header which contains an ion-navbar and an ion-toolbar with the toolbar having a ion-searchbar and an *ngIf on it to toggle whether the searchbar is displaying or not, and an ion-conent. When I toggle the toolbar to on/off, the ion-content below it does not rerender/resize and this results in the appearance of the ion-searchbar hovering over the ion-content.
Better illustrated here:

If I have the above rendered without an *ngIf (i.e. where the ion-searchbar is always displaying), then the page is rendered as expected with the ion-content appearing beneath the ion-navbar and ion-toolbar.
Expected behavior:
For the ion-content to be re-rendered beneath the ion-searchbar when it is toggled to show after being hidden, and for the ion-content to be pushed down to accommodate the expanded ion-header.
Steps to reproduce:
Please see the Plunk here: http://plnkr.co/edit/Tc5T80Qcef0LyroYzy4M?p=preview
Tap the search button in the top-right, and notice it appear above the ion-list.
Related code:
<ion-header>
  <ion-navbar>
    <ion-title>
      Ionic Blank
    </ion-title>

    <ion-buttons end>
      <button ion-button icon-only (click)="toggleSearchbar()">
        <ion-icon name="search"></ion-icon>
      </button>
    </ion-buttons>
  </ion-navbar>

  <ion-toolbar *ngIf="showSearchbar">
    <ion-searchbar></ion-searchbar>
  </ion-toolbar>
</ion-header>

Other information:
I have attempted the *ngIf on both the ion-toolbar and ion-searchbar which resulted in the same output.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.1
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.5.0
Xcode version: Xcode 8.2.1 Build version 8C1002

Hey, thanks for opening an issue with us! I have made a plunker here which shows the correct way to do this. Whenever doing something that should cause the content to resize (like dynamically opening a searchbar in your app) you must call the resize method on the component instance of the ion-content in your app. This tells the content to re-compute its dimensions to match the new content height.

Hey @jgw96 - that's perfect 🙂 - thanks so much for the how-to.

Thank you, it worked for me as well! :)

@jgw96 , needing to call the resize method in this way seems like a workaround to a bug rather than how it should work by design.
Is there any way the framework could do this automatically?  Possibly by detecting when  headers or footer height changes and calling resize automatically?
Or better yet, If Ionic headers and footers were to be re-implemented using flexboxes instead of the current complicated markup and css, this problem would go away automatically and the page markup would be greatly simplified.  Has there been any discussion within the Ionic team of re-implementing headers and footers using flexboxes?


Specify max pods on provisioner resource

The max pod node constraint uses the default setting for the Bottlerocket AMI. This value is not accurate when configuring aws-vpc custom CNI where the max pods is reduced because one network interface is no longer available for pods.
As well when using other CNI plugins, the default max pods can be increased as max pods is no longer constrained by the available network interfaces.
Another interesting note about max pods per node is the 110 default that is often used when not limited by CNI is a bit arbitrary, and this value can be safely 250+ on larger instance types (reference)

Thanks for this report. My initial feeling is that we should achieve this via custom launch templates. I want to provide docs for a launch template baseline (including our default userdata) that will make it easy for folks to extend with use cases like this.

Scoping this to v0.3

Hey @mcavoyk , have you seen the latest v1.9 CNI release which increases the pod density? https://github.com/aws/amazon-vpc-cni-k8s/releases/tag/v1.9.0

Should be part of this doc: https://github.com/awslabs/karpenter/issues/432

if you set a lower value to "max pods" (e.g., 50) in a custom launch template, will karpenter know about this? or will it provision a node that can handle 70, and yet only 50 schedule onto that node?

The behavior is somewhat broken now. It assumes CNI specific limitations and there is no way to get around this: https://github.com/aws/karpenter/issues/954

My proposal to solving this:
spec:
  podCapacityModel: "static|eni"
  staticPodCapacity: 110

The eni model needs an AMI that supports it, but that is what is assumed today.
In the future, a resource-based capacity model may be added, but again requires an AMI that supports it (or that karpenter can provide the data per Node rather than per LT)
If this sounds good, I can try to implement this.

Would that spec be used in addition to instance type capacity? 110 pods on a .small instance is a lot different than 110 on a .24xlarge

What do you mean by instance capacity?
It would only be used to determine how kubelet's MaxPods is set. It would not affect anything wrt cpu and memory resource constraints.

See https://github.com/aws/karpenter/issues/954#issuecomment-998899853. Now that we have spec.kubeletConfiguration, we could allow someone to specify a value directly. Would this work?

I'd like to hold off and think a little more deeply before we make changes. Max pods is not a concept that melds naturally with heterogenous instance types. I want to be very careful about how we decide to approach this. Most of the team is currently on vacation, so this may need to wait for the new year.

I would be fine with agreeing on a large value for MaxPods so that it doesn't become a part of the equation.

Makes sense to wait until the team comes back. For my use case, I simply don't want to set it at all or use a crazy high number.
As we find more AWS VPC CNI-specific things, it almost makes me think if there's a high-level config that needs to indicate this, as defaults should vary quite a bit.
Anywho... everyone have a great break and we'll pick it up after the holiday!

Would it be possible to consolidate this and #954 since they both deal with the same problem / request?

Coming in v0.5.6


[Bug]: Jest doesnt transform file from node_modules even with empty ignore settings

Version
29.1.2
Steps to reproduce

Place somewhere 2 files:

package.json:

{
  "dependencies": {
    "@babel/core": "^7.19.3",
    "@babel/preset-env": "^7.19.3",
    "babel-jest": "^29.1.2",
    "jest": "^29.1.2",
    "parsinator": "2.1.2"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "jsx"
    ],
    "moduleDirectories": [
      "node_modules"
    ],
    "transform": {
      "\\.[jt]sx?$": "babel-jest"
    },
    "transformIgnorePatterns": [],
    "verbose": false
  },
  "babel": {
    "env": {
      "test": {
        "plugins": [
          "@babel/plugin-transform-modules-commonjs"
        ]
      }
    }
  }
}

jest.test.js:

import Parsinator from 'parsinator';

npm install
npx jest

Expected behavior
No errors, all fine
Actual behavior
    export { ParseError, VERSION, between, buildExpressionParser, choice, count, debugTrace, end, fail, fromGenerator, many, many1, map, maybe, peek, regex, regexMatch, run, runToEnd, sepBy, sepBy1, sequence, str, surround, until, wrapFail };
    ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import Parsinator from 'parsinator';
        | ^
      2 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1678:14)
      at Object.<anonymous> (jest.test.js:1:1)

Additional context
Tried "transformIgnorePatterns": ["^$"],, "transform": {".*": "babel-jest"} whatever doesn't work
Environment
OS: Linux KDE Neon 5.25 (20.04)
CPU: x86_64
Node: 16.17.1
npm: 8.15.0

remove stale

remove stale

Are you using .babelrc or babel.config.json to configure babel? With the former node_modules is ignored. You can find more information about that in https://babeljs.io/docs/en/config-files. If that's your problem, renaming .babelrc to babel.config.json could make it work for you.

@julienw, no, to reproduce a bug you need only 2 files as mentioned in 1st post: package.json  and jest.test.js

Maybe I just misunderstand something, because jest says

To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.

Also can't find anything about configuring babel itself in jest docs.
Anyway, I tried to add include option to babelrc:
{
  "dependencies": {
    "@babel/core": "^7.19.3",
    "@babel/preset-env": "^7.19.3",
    "babel-jest": "^29.1.2",
    "jest": "^29.1.2",
    "parsinator": "2.1.2"
  },
  "jest": {
    "moduleFileExtensions": [
      "js",
      "jsx"
    ],
    "moduleDirectories": [
      "node_modules"
    ],
    "transform": {
      "\\.[jt]sx?$": "babel-jest"
    },
    "transformIgnorePatterns": [],
    "verbose": false
  },
  "babel": {
    "env": {
      "test": {
        "plugins": [
          "@babel/plugin-transform-modules-commonjs"
        ],
        "include": ["node_modules"]
      }
    }
  }
}

Output:
    /tmp/t/jest.test.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import Parsinator from 'parsinator';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

Looks like jest managing ignore paths by itself and any additional config may break setup (as I've got above).

Maybe I just misunderstand something, because jest says

To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.

Also can't find anything about configuring babel itself in jest docs.

When you use transformIgnorePatterns, you instruct Jest where to run babel. The default is to ignore node_modules and some other things. If you configure it to [], you basically instruct Jest to run babel on every file.
But if babel doesn't apply to node_modules, then nothing happens... A good way to check this is by running babel directly on the files and check the output. If you install @babel/cli you should have it in node_modules/.bin/babel.
I also struggled about that during a long time too, I believe Jest docs should be improved in this regard. It may be because this changed with babel v7, babel v6 had a different behavior (see this babel v6 vs v7 comparison), and so Jest's doc wasn't updated since then.
Again, the only way to have babel transform node_modules files is using babel.config.js to configure babel. If you configure it inside package.json or with .babelrc babel won't transform the files in node_modules.
This is extremely unclear in all existing docs. I hope I cleared it up here for you, as the result of some hours of debugging.

In short: move everything you have under "babel" in your package.json to babel.config.js, and everything should work for you.

move everything you have under "babel" in your package.json to babel.config.js, and everything should work for you.

No, it doesn't. Same error:
    /tmp/t/jest.test.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import Parsinator from 'parsinator';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1449:14)

Can you please share your full project in a repository?

Here: https://github.com/iassasin/jest-bug-repro

Your problem is now with the include option in your babel configuration. It doesn't match your source file so it just ignores your source file when parsing. Remove it and then it works fine for me.

Ok, now I see. Moving same config to different place make the magic. :confused:
Thank you!


nodemon not working is there any errors in building the model? If I run it with npm start, nothing is visible in the browser after a while...

nodemon not working is there any errors in building the model? If I run it with npm start, nothing is visible in the browser after a while

The issue is with the package.json file. Change the "start" in the scripts. It must be "start": "nodemon server,js" instead of "start": "node ./server.js".

The issue is with the package.json file. Change the "start" in the scripts. It must be "start": "nodemon server.js" instead of "start": "node ./server.js".


Wrong number of licenses

An administrator creates an access review of Group D with 6 member users and 108 guest users. Makes it a self-review.
Shouldn't the number of licenses be 6 rather than '-'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a8a3416-ca49-e148-89ec-aa004914eaa5
Version Independent ID: 6e6831f4-40ed-4058-5a6f-56cd3900460a
Content: What are access reviews? - Azure Active Directory
Content Source: articles/active-directory/governance/access-reviews-overview.md
Service: active-directory
Sub-service: compliance
GitHub Login: @barclayn
Microsoft Alias: barclayn

@jasonpanggit Thanks for the feedback! We are taking a look into this and will get back to you soon.

@jasonpanggit Thanks for the feedback! We are taking a look into this and will get back to you soon.

@jasonpanggit Thank you for pointing it out. I have updated Required number of licenses to 6. The change is sent to author for review and will reflect on the doc after approval.

@jasonpanggit Thank you for pointing it out. I have updated Required number of licenses to 6. The change is sent to author for review and will reflect on the doc after approval.


EnvFile plugin not supported in IDEA 2021.2

It does also not work in 2021.3:

Did you try version 3.2.2?

No, now I found out that I haven't installed this plugin. I don't know why this message appears, maybe another plugin brings this as dependency or there are any old files in a cache directory of IntelliJ IDEA? Now I have installed the plugin (version 3.2.2) using the plugin marketplace and the error is gone. :+1:

Same, have this issue since ages withouth explicitly having installed the plugin


Close resource_stream file pointer

Description
Treat resource_stream like a file open function to close file pointer after usage
References
Fix #19
Checklist

[x] I have read the contribution guide
[x] Code lint checked via inv lint
[x] changes file included (see docs)
[x] Usage documentation added in case of new features
[x] Tests added

Pull Request Test Coverage Report for Build 446613282

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 97.966%

Totals

Change from base Build 435545326:
0.08%

Covered Lines:
208

Relevant Lines:
210

💛  - Coveralls


Most Thumpnails and Profile Pictures wont load on Tor

Bug
Most Video Thumpnails and Profile Pictures wont load when I'm connected to Tor, except for gif's
To Reproduce
Steps to reproduce the behavior:

Connect your System to the Tor Network via Anonsurf or a Tor Router
Open the LBRY Desktop App
Look for some new Videos or purge the Application Cache

Expected behavior
All Video Thumpnails and Profile Pictures load as usual.
Screenshots

System Configuration

LBRY Daemon version: 0.67.2
LBRY App version: 0.44.0
LBRY Installation ID:
gtD6evJQfAMgJCvxxVMNhCLwmRXgRqy5mSA1w4P5qyVfAV6S2Jv5MwigCAyPrHirg
Operating system: Debian Linux

Sorry to hear about the trouble. Not sure what we can do here if those URLs are not accessible via some relays you are connecting to. Some of the images may be hosted under spee.ch or a thumbnails.lbry.com url.


Wrapping map in a type breaks toValue after 6c0d9883792e42e6da320ac03ae0d6c1b0cd7530

After 6c0d9883792e42e6da320ac03ae0d6c1b0cd7530 (git bisected it) it seems like wrapping map[string]interface{} breaks toValue at least in parts. The following example illustrates it
package goja

import "testing"

type mapping map[string]interface{}

func TestFunctionInMap(t *testing.T) {
	const SCRIPT = `
    a.s();
	`

	r := New()

	r.Set("a", mapping{ // !!!!!!!!!!!!  swapping for map[string]interface{} works
		"s": func() bool { return true },
	})

	prg := MustCompile("test.js", SCRIPT, false)

	res, err := r.RunProgram(prg)
	if err != nil {
		t.Fatal(err)
	}

	if !res.StrictEquals(valueTrue) {
		t.Fatalf("Unexpected result: %v", res)
	}
}

This will say that you can't call [object Object] but it will work if you swap mapping for the map[string]interface{} or use ToValue directly on the func() or if it is func(FunctionCall) Value. Probably other variants work as well.
The reflect code behaves strangely, and it seems like the origValue just happens to not be of Kind func . But  reflect.ValueOf(i) does return func.
Just replacing origValue with reflect.ValueOf(i) ... breaks, obviously in some other cases. :(
https://github.com/dop251/goja/blob/b95230a9dbad42ddf5220c752e5d396eb58f405f/runtime.go#L1861

Reverting the changes to object_gomap_reflect.go from https://github.com/dop251/goja/commit/6c0d9883792e42e6da320ac03ae0d6c1b0cd7530 fixes the issue and does not fail any other tests.
But this seems wrong to me. Also, I don't understand why value returns different thing from reflect.ToValue(value.Interface()) - that seems like the kind of thing that should give you equal values, but I have not used reflect all that much.

MapIndex returns an reflect.Value which is an interface which is kind of makes sense because that's what the map's element type.  reflect.ValueOf() on the other hand always returns the concrete value, not the interface.


How to set SINGLE_AUTO to the Barcode Scanner?

Hi,
I would like to set SINGLE_AUTO to the Barcode Scanner. How can I possible do that? I need to solve it asap.

kindly explain what you mean by SINGLE_AUTO. If it is what i think , the snippet below should be able to help.
                                  .setTouchAsCallback(false)

This will allow a single scan and would not require the user taping the screen to process the frame.

This is the solution I want
https://stackoverflow.com/questions/42112519/how-to-disable-multiple-barcode-detection-android-vision-api


vmware controller: instance IP address not displayed

[Version]
V16.0 Fix 6
[Date]
2016/06/26
[Test category]
Creative
[Description]
Access Info set to default in Tech service:
ParameterDefinition id="ACCESS_INFO" configurable="true" default="${HOST}, ${IP}" mandatory="false" valueType="STRING"
Create VMware instance,
log on to CTMG look at Subscription screen:
Host name is displayed, IP address isn't
Same is true for the notification email:
Dear Ms. Julia,
You have been granted access to the subscription VMware_Original_With_ALL(3).
Freddy-000028,
With best regards.
[Steps to reproduce]
Create Vware instance with default from delivered TechService
[Expected result]
Hostname, IP-Address displayed in Email and Subscription screen
[Observed result]
Only host address is displayed.
[Details]
See above;
[Messages and logs]

Fixed with commit.

Master 2016/07/22
now it is ok
Dear user,
You have been granted access to the subscription VMware_4_Nics_Preset.
Elfriede3, VM Network: [<IP_ADDRESS>, fe80::250:56ff:fe9d:1d30]
With best regards.
This email has been automatically generated. Please do not reply to this email.


CK3 titles

https://www.diffchecker.com/EdkXBvaC
The titles that are in green are the ones added by CK3 and for which the EU4Vic2 converter lacks appropriate flag files
EDIT: Duchies and counties are still to be checked

Closed: the game already handles CK3 titles by assigning random flags if nothing is found. Thus, virtually only minor duchies, counties or mod titles would risk getting incoherent flags.


Pose initialization keeps running via automatic_pose_initializer

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
In automatic_pose_initializer, which was recently added to autoware.universe in https://github.com/autowarefoundation/autoware.universe/pull/1431, keeps running the pose initialization request under certain condition. The condition is that the timer_ period is set lower than the time it takes to calculate the pose initialization.
  const auto period = rclcpp::Rate(1.0).period();
  timer_ = rclcpp::create_timer(this, get_clock(), period, [this]() { on_timer(); });

The default value rclcpp::Rate(1.0) works fine on my PC, but for example by setting this value to rclcpp::Rate(3.0), the pose initialization request keep running.
https://user-images.githubusercontent.com/44218668/187813018-7f13743e-a9f7-48b8-8932-faacb3ededa2.mp4
Expected behavior
The automatic_pose_initializer should run only one single successful pose initialization request.
Actual behavior
As mentioned above, the package keeps running the initialization when the rate is set high enough.
Steps to reproduce
As mentioned above, in l.29 from system/default_ad_api_helpers/automatic_pose_initializer/src/automatic_pose_initializer.cpp
  const auto period = rclcpp::Rate(1.0).period();

change the value 1.0 to some higher value, e.g. 3.0.
Versions

OS: Ubuntu 22.04
ROS 2: Humble
Autoware: https://github.com/autowarefoundation/autoware.universe/commit/dcf99e533cb13b1bbce0ba4281afc8a101ce32a3

Possible causes
It is possible that the sub_state_ is blocked by timer_ and cannot update the state_.state from UNINITIALIZED to INITIALIZING or INITIALIZED.
Additional context
No response

How about this? @isamu-takagi @YamatoAndo
void AutomaticPoseInitializer::on_timer()
{
  if (state_.state == State::Message::UNINITIALIZED) {
    try {
      const auto req = std::make_shared<Initialize::Service::Request>();
      cli_initialize_->call(req);
    } catch (const component_interface_utils::ServiceException & error) {
    }
  }
}

to
void AutomaticPoseInitializer::on_timer()
{
  if (state_.state == State::Message::UNINITIALIZED) {
    try {
      const auto req = std::make_shared<Initialize::Service::Request>();
      cli_initialize_->call(req);
      const auto res = cli_initialize_->async_send_request(req).get();
      if (!res->status.success) {
        state_.state = State::Message::UNINITIALIZED;
      } else {
        state_.state = State::Message::INITIALIZED;
      }
    } catch (const component_interface_utils::ServiceException & error) {
    }
  }
}

Thank you for reporting. I will check it.

Fixed in this PR. https://github.com/autowarefoundation/autoware.universe/pull/1756


Fix/Align initial screen style with the rest of the client

Before submitting this PR, please make sure:

[x] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Initial screens apply the selected color configuration.
Tests performed by the developer:
Ran the client.
Tips for QA testing:
Please test on Windows specifically because I couldn't.

PRP: https://snapshot.org/#/hbot-prp.eth/proposal/0x09a367e0db44e89189a562a38946f875f95c1e5241d8578d06eebf7f29a79fa5

Initial screen changes looks ok for me on AWS

but there's an Issue with Input panel background affected with black background and redundant whitespace painted black
for Environment: Win10, MacOs, Ubuntu Source.
Steps:

install feature branch
Set up and enter the password
Pay attention into the Input pane (lower left)

Actual:
Input panel background affected with black background and redundant whitespace painted black
Expected:
Input panel not affected with redundant whitespace painted black and background
Win10 Source:

MacOs Source:

Ubuntu Source:


Update go to 1.22.3

Bump Go version to 1.22.3 due to vulnerabilities in Go 1.22.2 identified by the Trivy vulnerability scanner.
https://github.com/kubernetes-csi/livenessprobe/pull/262
https://github.com/kubernetes-csi/livenessprobe/actions/runs/9034677921/job/24827762006?pr=262
Go updated to 1.22.3

/retitle Update go to 1.22.3

/cc @jsafrane

It appears that pull-kubernetes-csi-release-tools-external-snapshotter test is in a state where running go mod tidy in response to the Go version upgrade results in changes to the go modules. Therefore, after merging this PR, it seems that updating the go modules version will be necessary on the external-snapshotter side.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-release-tools/252/pull-kubernetes-csi-release-tools-external-snapshotter/1788961194170650624

/cc @xing-yang

I wonder why it failed due to recently added API validation rules:
diff --git a/vendor/github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumegroupsnapshot/v1alpha1/types.go b/vendor/github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumegroupsnapshot/v1alpha1/types.go
index b8de6494..4110c292 100644
--- a/vendor/github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumegroupsnapshot/v1alpha1/types.go
+++ b/vendor/github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumegroupsnapshot/v1alpha1/types.go
@@ -36,6 +36,7 @@ type VolumeGroupSnapshotSpec struct {
 	// class will be used.
 	// Empty string is not allowed for this field.
 	// +optional
+	// +kubebuilder:validation:XValidation:rule="size(self) > 0",message="volumeGroupSnapshotClassName must not be the empty string when set"
 	VolumeGroupSnapshotClassName *string `json:"volumeGroupSnapshotClassName,omitempty" protobuf:"bytes,2,opt,name=volumeGroupSnapshotClassName"`
 }

Apologies, it seems that there were differences unrelated to the Go version, causing make test-vendor to fail.
I have created a PR to fix this issue at the following link:
https://github.com/kubernetes-csi/external-snapshotter/pull/1084

Based on the output below, it appears that make test-vendor is being skipped.
### test-vendor:
Repo uses 'go mod'.
Skipping vendor check because the Prow pre-submit job does not affect dependencies.

https://github.com/kubernetes-csi/external-snapshotter/pull/1073
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-snapshotter/1073/pull-kubernetes-csi-external-snapshotter-unit/1787547224096378880

It seems that the process is skipped under the following conditions:
https://github.com/kubernetes-csi/csi-release-tools/blob/b82ee38887c684a306b57dbfaba9c0f5d3fa7921/verify-vendor.sh#L32-L37

/retest

@xing-yang The pull-kubernetes-csi-release-tools-external-provisioner test has passed as a result of merging the following PR:
Would you please review this PR again when you have a moment?
https://github.com/kubernetes-csi/external-snapshotter/pull/1084

/lgtm
/approve


Feat/ctc/feature branch queries

Description
Music year: 1970

List of changes

Issue(s)
Fixes #
How to test

Go to {owa_deployment_url}
Click on ______
You should see ______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.643.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add gpt-4-turbo to AzureConfig

A better solution is to ask the user to also the model version. This is how we can precisely handle this apsect. Because still the default version of the model name gpt-4 isn't turbo, which is determined by selecting the model version as 1106-preview.
Let me update this PR by adding a new parameter to the AzureConfig to define model version

@pchalasani I've added the model version. It's only necessary when the model name is gpt-4. That's why I define a func to handle this aspect.


support to send image from txt2img/img2img to cleaner directly

I already completed this feature but need to wait https://github.com/novitalabs/sd-webui-cleaner/pull/6 merged first

fixed in https://github.com/novitalabs/sd-webui-cleaner/pull/9


Context menu size and location changes, but not for more readability

Expected behavior
Long-press on message and the menu should appear in a good location and readable.
This is in a non-split screen mailbox view.
Actual behavior
The messages closer to the top of the screen pop menus further down the screen, until it is almost unusable in the lower-right corner.
Steps to reproduce
(see screenshots)

Long press on a message in the lower part of the screen. The menu appears as you'd expect.

Long press on a message at the top of the screen. The menu is down in the lower-right corner.

See the difference in the menu usability

Environment
K-9 Mail version: 5.010
Android version: Android N Preview 5 on Nexus 5x
Account type (IMAP, POP3, WebDAV/Exchange): IMAP

We don't position the popup ourselves. This is most likely a bug in your version of Android.

I'm seeing this with 5.010 on a Nexus5x with Android 7.0 (pretty sure it didn't happen with Android v6). Can K9 influence the dimensions? Should it be reported upstream?

Sorry, ignore that. Just realized #1581 addresses my question.

Android 7 nathinn
Am 22.09.2016 7:25 nachm. schrieb "Ryan Roden-Corrent" <
<EMAIL_ADDRESS>
Sorry, ignore that. Just realized #1581
https://github.com/k9mail/k-9/issues/1581 addresses my question.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/k9mail/k-9/issues/1544#issuecomment-248970421, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVVQbiH20MYgnlvwxhyW_GEyaUSHRURxks5qsroVgaJpZM4JczSY
.


import  error

from apsimNGpy.core.apsim import ApsimModel    error
The detail error was
KeyError: 'APSIM is not loaded in the system environmental variable'
Can you help me ?

Most likely you have not added APSIM binaries path to the python Path see the debugging section in the README file

I check the  README file, and added the APSIM path of bin to the python Path

the way you are using it is not correct
from apsimNGpy.config import set_apsim_bin_path
apsim_path = 'D:/APSIM/APSIM2024.11.7612/bin/'
set_apsim_bin_path(apsim_path)


How to get current/duration ?

Hi,
Is there any way to get value of current/duration of the playing videos.
Thanks and best regard.

Implemented in v3. See https://docs.fluidplayer.com/docs/api/events/#timeupdate


Tracking Code Mismatch alert on GA

I got an alert like this on Google Analytics:

And I have the beacon code with the correct tracking ID:
![Analytics](https://ga-beacon.appspot.com/UA-45321252-5/welcome-page)

any ideas what might be happening?

Looks similar to #30. I just updated my URL from:

to

I'll close this issue if this fixes the problem.

Closing, please reopen if this still an issue.


HSDS not working with new versions of Docker

The code that determines if a node is running in Docker or not looks to be broken with newer Docker versions.  With Docker 20.10.14 at least, checking the /proc/self/cgroup (see: https://github.com/HDFGroup/hsds/blob/master/hsds/basenode.py#L649) doesn't have the docker field.
Consequence is that requests to the rangeget proxy aren't getting routed properly.

I've put in a fix here: https://github.com/HDFGroup/hsds/commit/a1c518c5ca1905a1e4c551c824f2abf567492187 that uses the root inode number to determine if the container is running in docker or not.
Alternatively, the environment variable "IS_DOCKER" can be set in the deployment yaml.


The thread name length of the Unified Read Pool should be changed to less than 15

Bug Report
Due to the thread name length being restricted to 16 characters (including the terminating null byte '\0') in Linux, the thread name of the Unified Read Pool will be truncated to unified-read-po in TiKV, which will cause some statistical information to be lost, for example, the current thread count and the thread-level CPU usage info.

/type bug
/severity major

/type bug
/severity major

This is not a major bug which is strongly needed to fix actually.  The most serious impact at present is just a bit inconvenient to write some code. So please change the severity.


Live Chat Transcript email is not being sent

I've written the below code to email chat transcript.
 async requestTranscript(emailAddress: string) {
    const emailTranscriptParam = {
      emailAddress,
      attachmentMessage: "Chat Transcript",
    };

    await this.#ocSDKInstance.emailLiveChatTranscript(emailTranscriptParam);
  }

In the network tab I see a successful POST request being made. But I don't receive any email.
I've tried this multiple times, but it doesn't seem to work.

Is email transcript configured?

Documentation can be found here
There's a prerequisite to configure mailboxes before enabling email transcript feature

Does email transcript work with the out-of-box chat widget?

If email transcript does not work with out-of-box chat widget, then it's most likely a configuration issue.


[Feature]: Update VS Code extension name and description

Describe the feature you would like
Extension name should change from taqueria -> Taqueria
Description should change to:
Build, test and deploy smart contracts and dapps on Tezos
Is this feature solving a problem?
Details about the problem your feature solves
Please share any additional details you have?
Details about the problem your feature solves
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Do you know how this is done? I don't see anything in the publish workflow so I'm assuming there's an admin panel or something to manage our listing

I don't know. @danielelisi did the initial setup, Dan can you help us out?


Navbar breaks on intermediate screen size

The navbar ends up breaking when the screen isn't large enough to support it full width:

A possible design idea:

Changes spacing in top bar
Changes h1 styles
Adds following styles for the new menu bar
Need to work out how to center the button labels vertically, what happens with bigger screens etc

nav.action-bar {
    background: #fafafa;
    border: 1px solid #eeeeee;
    display: flex;
    justify-content: space-between;
    font-size: 14px;
}

nav.action-bar a {
    height: 30px;
    position: relative;
    color: rgba(0, 6, 22, 0.9);
}

a.download:before {
    content: "\f019";
    font-family: FontAwesome;
    width: 30px;
    height: 100%;
    line-height: 30px;
    display: inline-block;
    font-size: 20px;
    margin-right: 2px;
}

a.menu:after {
    content: "\f0c9";
    font-family: FontAwesome;
    width: 30px;
    height: 100%;
    line-height: 30px;
    display: inline-block;
    font-size: 20px;
    margin-left: 2px;
}

This got kinda fixed ages ago with the photo design


⚠ Bofrost.com has degraded performance

In cb32974, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1436 ms

Resolved: Bofrost.com performance has improved in d4825a8 after 6 minutes.


Incorrectly marking a declaration as unused

Apologies if this is the wrong repo for this.

VSCode Version: 1.45.1
OS Version: Windows 10 & macOS

Steps to Reproduce:
The issue can be observed on CodeSandbox which I guess uses the same underlying code.
https://codesandbox.io/s/lucid-http-qscl0?file=/src/App.js
CancelToken is being marked as an unused declaration when it clearly isn't and applying the quick fix breaks the code.

Does this issue occur when all extensions are disabled?: Yes

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Yes it does

This is a bug with the typings that axios is shipping
If you enable type checking in the JS file, you'll see the error on new CancellationToken:
'CancelToken' only refers to a type, but is being used as a value here.ts(2693)

If your code is correct, please file a bug against axios to have them fix their typings

No worries, thanks for investigating!


Fix SELECT identification

Correctly identify SELECT/PRAGMA/etc statements that start with whitespace (eg: a new line) instead of ignoring them

This pull request fixes a problem I noticed while working on a recent project. When identifying SELECT/etc statements, the regex used ignores statements that start with whitespace. So for example, this:
db.query(`
    SELECT * FROM tests WHERE
    user_id = ? AND
    memo_id = ?
`, ['abc', 'defg'])

- wouldn't correctly be recognized as a SELECT statement because of the whitespace (new line) at the beginning. This whitespace doesn't affect other query types because they aren't checked the same way, and this creates confusing/inconsistent behavior (from personal experience: it stumped me for two days 🙃)
The fix I've added just adds a \s? \s* bit at the start of the regex in order to check for any whitespace that may be there. If this won't work, feel free to change it- it's just the simplest fix I could come up with

it's in, thanks


Make e2e tests more configurable

Feature request

Currently, the e2e test uses various hard-coded parameters for the scenarios around testing with kind clusters only. We do have some environment variables for fetching tokens and ssl certs. Following the same path, we should review other parameters that would make it easier to run tests with different kinds of setups.
Especially the serverName and serverAddress variables.
Refer here:
https://github.com/tektoncd/results/blob/fdc47542cc0ce52fadaa4389a01ff0c2b75fe6e5/test/e2e/e2e_test.go#L59-L70
Use case

In a case where results is deployed on a remote server
Results is deployed in a different namespace

+1 on this - it would be great if the e2e test script allows the tests to be run against a real deployment on a production cluster.
Variables that probably need/should be tunable:

serverName - unclear if this is needed on a real deployment?
serverAddress - this will definitely need to be tuned if Results is exposed via an Ingress object, LoadBalancer service, etc.
certFileName - this probably won't be needed if the server address uses a publicly trusted certificate - ex, if the Ingress uses a LetsEncrypt TLS cert.


Set controller defaults for 0.11.2 tag

Ignoring current lint job output, as I can't produce locally, and the linter's output doesn't point to anything in my code (it actually looks maybe like it's arguing about code within the linter itself, potentially?)


[Bug]: Screenshot method is not working well

Describe the bug
In a TC while we are making validation on some exisitng info in the modal, the method that caputre the screenshot of the validations, is clicking on the app screen so the modal is being got closed and then the rest of validation failues due to the non-exisitng of the rest of elements
Link to SHAFT_Engine Console logs
SHAFT Engine Logs - Current Method log: init
[ReportManager] Setting "targetOperatingSystem" property with "windows". @05-11-2023 13:01:47.0995 PM
[ReportManager] Capabilities {acceptInsecureCerts: true, browserName: MicrosoftEdge, ms:edgeOptions: {args: [--start-maximized, --remote-allow-origins=*, --enable-automation, --disable-background-timer-..., --disable-backgrounding-occ..., --disable-features=Calculat..., --disable-hang-monitor, --disable-domain-reliability, --disable-renderer-backgrou..., --disable-features=Autofill..., --metrics-recording-only, --no-first-run, --no-default-browser-check, --silent-debugger-extension..., --disable-extensions, --disable-component-extensi..., --disable-dev-shm-usage, --disable-features=MediaRouter, --disable-features=Translate, --disable-ipc-flooding-prot..., --disable-background-networ..., --mute-audio, --disable-breakpad, --ignore-certificate-errors, --disable-device-discovery-..., --force-color-profile=srgb, --hide-scrollbars, --host-resolver-rules, --no-pings, --disable-features=AvoidUnn..., --disable-features=Certific..., --disable-sync, --disable-features=Optimiza..., --disable-features=DialMedi..., --disable-features=GlobalMe..., --disable-features=Improved..., --disable-features=LazyFram..., --disable-field-trial-config, --enable-features=NetworkSe..., --enable-features=NetworkSe..., --enable-use-zoom-for-dsf, --log-net-log, --net-log-capture-mode, --disable-client-side-phish..., --disable-default-apps, --disable-features=Interest...], extensions: [], prefs: {download.default_directory: C:\Sondos\CIT\R10\RefAppAut..., download.prompt_for_download: false, profile.default_content_settings.popups: 0}}, pageLoadStrategy: none, timeouts: {pageLoad: 60000, script: 30000}, unhandledPromptBehavior: ignore, webSocketUrl: true} @05-11-2023 13:01:48.0037 PM
[ReportManager] Attempting to run locally on: "windows | Microsoft edge". @05-11-2023 13:01:48.0039 PM
[ReportManager] Identifying OS/Driver combination. Please note that if a new browser/driver executable will be downloaded it may take some time depending on your connection... @05-11-2023 13:01:48.0041 PM
[ReportManager] Successfully Opened: "windows | Microsoft edge". @05-11-2023 13:01:53.0124 PM
[ReportManager] Target URL: "https://vfgrp-app2-test.app-prod.digitalretail.vodafone.com/" @05-11-2023 13:01:53.0201 PM
[ReportManager] Initial URL: "about:blank" @05-11-2023 13:01:53.0234 PM
[ReportManager] Navigate to url "https://vfgrp-app2-test.app-prod.digitalretail.vodafone.com/". @05-11-2023 13:02:00.0557 PM
[ReportManager] Explicit wait until: "url to contain "https://vfgrp-app". Current url: "https://vfgrp-app2-test.app-prod.digitalretail.vodafone.com/"". @05-11-2023 13:02:00.0569 PM
SHAFT Engine Logs - Current Method log: setup
[ReportManager] File Action "DoesFileExist" successfully performed. With the following test data "File Path: "src/test/resources/changePlanJourneyTestData/planFeatureData.json"". @05-11-2023 13:02:00.0691 PM
[ReportManager] File Action "GetAbsolutePath" successfully performed. With the following test data "Relative Folder Path: "src/test/resources/changePlanJourneyTestData/planFeatureData.json"". @05-11-2023 13:02:00.0692 PM
[ReportManager] File Action "DoesFileExist" successfully performed. With the following test data "File Path: "src/test/resources/changePlanJourneyTestData/planFeatureData.json"". @05-11-2023 13:02:02.0393 PM
[ReportManager] File Action "GetAbsolutePath" successfully performed. With the following test data "Relative Folder Path: "src/test/resources/changePlanJourneyTestData/planFeatureData.json"". @05-11-2023 13:02:02.0393 PM
SHAFT Engine Logs - Current Method log:
[0;7m------------------------------------------------------------------------------------------------------------------------------------------------
Starting Execution: '1 out of 1' test cases in the current suite
Test Method: 'changePlanJourney.planStepFeature.ALPlanStepTests.validatePlanDetailsIsDisplayedOnceClickingOnSeeMoreDetailsButtonForPM'
Test Description: 'PM || Plan Step || Google Chrome || Ensure that plan details is displayed once clicking on See more details button'

[ReportManager] Type "6947826024" into "MSISDN". @05-11-2023 13:02:02.0772 PM
[ReportManager] Setting "skipTestsWithLinkedIssues" property with "true". @05-11-2023 13:02:03.0076 PM
[ReportManager] Select "PAYM" from "Plan Type". @05-11-2023 13:02:03.0400 PM
[ReportManager] Moved the mouse to the middle of the element. @05-11-2023 13:02:03.0611 PM
[ReportManager] Click "Continue". @05-11-2023 13:02:03.0677 PM
[ReportManager] Moved the mouse to the middle of the element. @05-11-2023 13:02:03.0911 PM
[ReportManager] Click "Continue Without Code". @05-11-2023 13:02:03.0952 PM
[ReportManager] Moved the mouse to the middle of the element. @05-11-2023 13:02:05.0977 PM
[ReportManager] Click "See more details". @05-11-2023 13:02:06.0057 PM
[ReportManager] Assertion "ValidateElementExists" PASSED. Expected "Element Should Exist, locator 'By.xpath: //h2[@data-testid='plan-details-subtitle']'" and Actual "Element Exists". Comparison Type "EQUALS". Validation Type "POSITIVE". @05-11-2023 13:02:09.0423 PM
[ReportManager] Assertion Passed: The Element located by "By.xpath: //h2[@data-testid='plan-details-subtitle']" exists. @05-11-2023 13:02:09.0423 PM
[ReportManager] Successfully created attachment 'Screenshot -<PHONE_NUMBER>491_validatePlanDetailsIsDisplayedOnceClickingOnSeeMoreDetailsButtonForPM_ValidateElementExists_passed' @05-11-2023 13:02:09.0457 PM
[ReportManager] Expected condition failed: waiting for com.shaft.gui.element.internal.ElementActionsHelper$$Lambda$1076/0x00000008012aa110@4b3ebc09 (tried for 60 second(s) with 100 milliseconds interval) || no such element: Unable to locate element: {"method":"xpath","selector":"//div[@data-testid='plan-details-name']"} @05-11-2023 13:03:09.0516 PM
[ReportManager] Assertion "ValidateElementExists" FAILED. Expected "Element Should Exist, locator 'By.xpath: //div[@data-testid='plan-details-name']'" and Actual "Element Doesn't Exists". Comparison Type "EQUALS". Validation Type "POSITIVE". @05-11-2023 13:03:10.0075 PM
[ReportManager] Assertion Failed: The Element located by "By.xpath: //div[@data-testid='plan-details-name']" exists. @05-11-2023 13:03:10.0077 PM
[ReportManager] Successfully created attachment 'Screenshot -<PHONE_NUMBER>735_validatePlanDetailsIsDisplayedOnceClickingOnSeeMoreDetailsButtonForPM_ValidateElementExists_failed' @05-11-2023 13:03:10.0078 PM
[ReportManager] Successfully created attachment 'Validation Test Data - Failure Reason' @05-11-2023 13:03:10.0081 PM
[ReportManager] Assertion "ValidateElementExists" FAILED. Expected "Element Should Exist, locator 'By.xpath: //div[@data-testid='plan-details-name']'" and Actual "Element Doesn't Exists". Comparison Type "EQUALS". Validation Type "POSITIVE". @05-11-2023 13:03:10.0082 PM
[ReportManager] Successfully created attachment 'SHAFT Engine Logs - Current Method log: init' @05-11-2023 13:03:10.0095 PM
[ReportManager] Successfully created attachment 'SHAFT Engine Logs - Current Method log: setup' @05-11-2023 13:03:10.0097 PM
Environment
Chrome, edge

SHAFT_Engine version that exhibits the issue (Note: We support only the latest release):  7.4.20231026
Last SHAFT_Engine version that did not exhibit the issue (if applicable):
Desktop OS: [e.g. iOS] windows
Desktop Browser (if applicable): [e.g. chrome, safari] chrome, edge
Desktop Browser Version (if applicable): [e.g. 22] chrome [118.0.5993.120 ] edge [118.0.2088.76 ]
Mobile Device Name (if applicable): [e.g. iPhone6]
Mobile Device OS (if applicable): [e.g. iOS8.1]
Mobile Device Browser or Native App:
Mobile Device Browser (if applicable): [e.g. chrome, safari]
Mobile Device Browser Version (if applicable): [e.g. 22]

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots, gifs, or video recordings to help explain the issue you're facing.
Additional context
Add any other relevant context about the problem here.

@SondosSaber after several attempts I wasn't able to reproduce this issue.
Kindly provide a code snippet @Test method that I can copy-paste in my test classes to reproduce this problem and attempt fixing it.
PS. I recommend setting the screenshotParams_screenshotType to Regular and trying again.
PSS. feel free to reopen once you can share a code snippet to reproduce the issue. I will attempt a blind fix anyway.

@MohabMohie
hello Mohab
@Test
public void validatePlanDetailsIsDisplayedOnceClickingOnSeeMoreDetailsButtonForPM(){
    new EntryPointPage(driver)
            .setCustomerData_AL_PMAndNavigateToPromoCodePage(validNumberPM)
            .navigateToCurrentPlanPageWithoutPromoCode()
            .openSeeMoreDetailsPlanModal();

    Validations.assertThat().element(PlanPage.planDetailsTitle_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planName_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planOriginalPrice_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planOriginalPriceCurrency_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planFinalPrice_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planFinalPriceCurrency_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.recurrentPayment_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.duration_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.firstInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.secondInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.thirdInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.fourthInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.closeIcon_Modal()).isEnabled().perform();
    Validations.assertThat().element(PlanPage.chooseThisPlanBtn_Modal()).isEnabled().perform();
     Validations.assertThat().element(PlanPage.closeBtn_Modal()).isEnabled().perform();
}

After the first validation and upon making the screenshot of the first validation the tooltip/modal is closed as it is closing by clicking outside it, rest of validations are getting failed as the modal is closed.

by this workaround the code is working

@Test
public void validatePlanDetailsIsDisplayedOnceClickingOnSeeMoreDetailsButtonForPM(){
    new EntryPointPage(driver)
            .setCustomerData_AL_PMAndNavigateToPromoCodePage(validNumberPM)
            .navigateToCurrentPlanPageWithoutPromoCode()
            .openSeeMoreDetailsPlanModal();

    SHAFT.Properties.visuals.set().screenshotParamsWhenToTakeAScreenshot("FailuresOnly");
    Validations.assertThat().element(PlanPage.planDetailsTitle_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planName_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planOriginalPrice_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planOriginalPriceCurrency_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planFinalPrice_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.planFinalPriceCurrency_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.recurrentPayment_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.duration_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.firstInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.secondInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.thirdInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.fourthInclusion_Modal()).exists().perform();
    Validations.assertThat().element(PlanPage.closeIcon_Modal()).isEnabled().perform();
    Validations.assertThat().element(PlanPage.chooseThisPlanBtn_Modal()).isEnabled().perform();
    SHAFT.Properties.visuals.set().screenshotParamsWhenToTakeAScreenshot("ValidationPointsOnly");
    Validations.assertThat().element(PlanPage.closeBtn_Modal()).isEnabled().perform();
}


Fix assert when arming the nuke.

Apparently trying to anchor an entity twice throws an assert!
Note: this PR will conflict with #18869. Idk which one we wanna merge first.

This one. It fixes and obvious issue and is easy to understand and review.

should hopefully not conflict now just merg


Avoiding

Even through preserve_styles defaults to false I am still seeing the styles from my stylesheet_link_tag in a style section in the e-mail. The styles are correctly inlined but they are also in a style tag. This causes the e-mail to be much bigger as a bunch of styles are included (not just those inlined). This causes Gmail to display as [message clipped]. How can I get just the inlined ones?

Closing this as I realized it was due to unused styles. Evidently they are preserved by premailer in a style tag. My assumption was that any styles that could not be inlined were dropped. This assumption was incorrect.

Any chance of merging this (https://github.com/soundasleep/premailer-rails/commit/e4a0e7f1b803f08feb03fec5eda96a5b61c68e3d) in?

Probably not.
Maybe @eric1234's explanation can help you to reduce your message size:

Closing this as I realized it was due to unused styles. Evidently they are preserved by premailer in a style tag. My assumption was that any styles that could not be inlined were dropped. This assumption was incorrect.


Add Laravel Pint for code styling

Add Laravel Pint to enforce formatting on files. Also added Github Actions to enforce this styling on pull requests

This is good to add, and I finally reviewed this and would like this in there, but the pint version in there requires PHP 8. This branch works with PHP 7.2, so it's incompatible. I also didn't check this out until now after leaving it open for so long, so the formatting needs to be re-done.  This would be good to re-do after we release a 1.0.


Can't download from Vimeo - no video formats found

[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'http://vimeo.com/141610338', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.11.10
[debug] Python version 2.7.9 - Linux-3.16-2-amd64-x86_64-with-debian-8.0
[debug] exe versions: ffmpeg 2.6.1, ffprobe 2.6.1, rtmpdump 2.4
[debug] Proxy map: {}
[vimeo] 141610338: Downloading webpage
[vimeo] 141610338: Extracting information
[vimeo] 141610338: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 378, in _real_extract
view_count = int(self._search_regex(r'UserPlays:(\d+)', webpage, 'view count'))
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 584, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract view count; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 661, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 290, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vimeo.py", line 427, in _real_extract
self._sort_formats(formats)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 766, in _sort_formats
raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Seems to be happening with any video I've tried to get from vimeo, even ones that worked just a few weeks ago.

This started happening on November 11th.

Duplicate of #7460.


requirements.txt isn't used

The requirements.txt file lists dependencies, but the Dockerfile only installs a few specific Python packages, instead. Does requirements.txt need to be added to the Dockerfile? It is the standard way to define Python dependencies for a project and a convention that will help any prospective or new developers find their way around the infrastructure.

Just want to add a note that requirements.txt file is used in hs_docker_base sub-directory when most (if not all) required packages are installed into hs_base container for use by hydroshare. There is no requirements.txt being used in the hydroshare root directory, though.

Just want to add a note that requirements.txt file is used in hs_docker_base sub-directory when most (if not all) required packages are installed into hs_base container for use by hydroshare. There is no requirements.txt being used in the hydroshare root directory, though.

In the interests of continuing the discussing in a single location, here was Michael's follow up:
As Hong mentioned, make reference to the requirements.txt and Dockerfile found in hydroshare/hs_docker_base
In general the Dockerfile defines install components at the OS level (for example apt-get or yum) and requirements.txt defines the Python packages installed using pip.
You will however notice a mix of apt-get and pip install in the Dockerfile that defines hs_docker_base, and I'm unsure if that was intentional or not for dependencies and such.
The Dockerfile in the main hydroshare directory builds off of the hs_docker_base image that was already built using the definitions in the hs_docker_base directory.
The pip install statements could very likely be migrated to the requirements.txt file that resides within hs_docker_base, and probably exist where they currently do because they were easier to add on there as the project evolved. By this I mean it's much quicker to build in packages at the outer layer rather than recompile the whole base image again.

I did not notice the other Dockerfile in hs_docker_base, I was only looking at the root Dockerfile and that requirements.txt and wondering why they weren't connected. I was however not basing this only on the contents of the files, but on the haystack package I added to requirements.txt not being installed when I rebuilt my containers, until I added them to that root Dockerfile.
Can you explain why that may have been?
Can you also explain the benefit of not simply installing all dependencies in each container, so that nothing can become amiss or out of sync? What does the root Dockerfile container run that it does not need the python packages?

Resolved via discussion by email of usage


Query has been removed after first click on Link

Version
4.0.0
Steps to reproduce

create a Link component like that

<Link to={{ pathname: '/homepage', query: {...oldQuery, image: 11} }}>
    Image capture
</Link>

Click the first time on this Link
Then check the HREF atribute of DOM  element

Expected Behavior
After the first click DOM  element should be
Actual Behavior
But actually it is

The query property of location objects is no longer supported. It would take me a while to explain all the details, but basically it boils down to there being query objects are not standardized and React Router/history not actually have an internal use for query objects. Instead, you should pick your own query package to parse and stringify location.search.
I wrote qhistory for people who really want query support. It works basically the same way that useQueries did with history v2/3.

Thank u for this clarifications!
so, i'll consider your library


Rename Heading to Label and unify spacing

@PavelHolec don't know about the name... Label doesn't evoke "has an icon and maybe some other text" in my head, but otherwise 👍

Agree with @sjavora, Label doesn't really have a semantic meaning in relation to Document text levels (where this should exactly be a Heading analogy), it's rather a component which carries different levels and styles of text, be it paragraph, heading, quote, etc. 🤔
Taking the snapshots in mind, it would rather be a Title to complement the Description, but this really starts being complicated.


test: use new sdk-test-utilities package in unit tests

PR summary
This commit simply adds a dependency on the newly-published @ibm-cloud/sdk-test-utilities package and modifies the generated unit test code slightly to use this new package instead of getting the test utility functions from the node core dependency.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.59.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add symbol for attachments publishers and modernize test

[X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[X] Ensure that the pull request title represents the desired changelog entry
[X] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[X] Ensure you have provided tests - that demonstrates feature works or fixes the issue

released as https://github.com/jenkinsci/junit-attachments-plugin/releases/tag/92.v46b_185115f82 @Vlatombe


Compile front-end

Proposed changes

Adds front end for compilation + basic graph simplification.
Removes simplify

@angeloskath I think we could aim to land the front-end only as we work towards more back-end compiler support (keep the diffs manageable).
Already might be useful for

Compiling little functions with redundant work (e.g. layer norm)
Compiling larger graphs with lots of small ops (reduce graph overhead + redundant work)

@angeloskath I removed the closure captures from Python and updated the tests to reflect the new behavior. If you have no other comments, let's merge and then we can build from it / iterate.

We should push updates to mlx-examples

Good point, I will do that now

I think the call to remove the python closure stuff was 💯 btw.

Okay landing this 🚀 thanks for the review!!


Qla2xxx skipping scsi scan host

After linux kernel commit (currently in scsi-staging [1])
scsi: qla2xxx: Log message "skipping scsi_scan_host()" as informational
makes it to distro kernels, we can check whether systems didn't perform
SCSI scan (e.g., qla2xxx driver configured in target-only/non-initiator
mode), which is not currently used in Canonical deployments (no storage
with Fibre Channel SCSI Targets) and was actually a support ticket, due
to a forgotten config file/option).
With the following in /var/log/kern.log:
Sep 12 19:01:31 mfo-t470 kernel: [649534.924685] qla2xxx [0000:04:00.0]-0122:1: skipping scsi_scan_host() for non-initiator port
Sep 12 19:01:31 mfo-t470 kernel: [649535.132764] qla2xxx [0000:04:00.1]-0122:10: skipping scsi_scan_host() for non-initiator port

Test:
mfo@mfo-t470:~/git/hotsos$ ./scripts/hotsos --kernel
...
kernel:
...
  potential-issues:
    KernelWarnings:
      - The qla2xxx driver did not perform SCSI scan on host/port [0000:04:00.0]-0122:1.
        Some SCSI disks/paths might not be present. (Module option 'qla2xxx.qlini_mode')
        (origin=kernel.auto_scenario_check)
...

[1] https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=6.1/scsi-staging&id=eee8bb4a2b58212843aec92dd6c8c1cc193209e0

Hey @dosaboy, sure! Done, tested and pushed. Thanks!


Created Sieve.cpp

The Sieve is helpful in finding prime numbers below a particular value(n) in the most efficient way.

Please rename this to SieveOfEratosthenes.cpp and then I will merge it.

Is this okay?

Is this okay?

Yes, thanks.


Use filepath.Split instead of filepath.Base

filepath.Base has problem when path contains drive. To fix this problem I switched to Split that return dir and filename.

@gpaul I copied description from commit message https://github.com/dcos/dcos-diagnostics/commit/31c614572f6d2d8ad3667b4373b9397c06f3cfdc

What is the problem exactly?

Build not pass on Windows because temp directory where we store bundles has drive in it so filetpah.Base returns wole path not only file name.

See https://github.com/golang/go/issues/7698
The issue is that you're using path.Base instead of filepath.Base.


Updated eu (Basque) translation

Commit made via Stringlate

Hi, are you able to rebase against latest?
Because this pull request adds the translation files, but are already there.
I.e. this pull request should ideally show only the updates...

Actually this matches the code already in the repo, so closing as there's nothing to do.


Decouple depositors from zenodo to allow different storage backends

This PR creates an abstract interface for Depositors to easily allow new storage backends for our archivers. It also implements the interface for the zenodo depositor.

I took another crack at this and reorganized into PublishedDeposition and DraftDeposition base classes, and there are methods to go from a published deposition from a draft and vice-versa. I think this sort of encapsulates the main states of the depositor, which is basically that a deposition can be published and read only, or in a draft state and readable/writeable. The draft deposition will also return a new instance of its self every time you make an edit, which should update any state it maintains about its contents.


error in nnd updateOutput: invalid device function ; error in nnd get grad: invalid device function

after I compile Chamfer 2D, 3D, 5D, when I run the "unit_test.py"， it shows me such error:
Loaded compiled 2D CUDA chamfer distance
Loaded compiled 3D CUDA chamfer distance
Loaded compiled 5D CUDA chamfer distance
testing Chamfer 2D
error in nnd updateOutput: invalid device function
error in nnd get grad: invalid device function
AssertionError: chamfer cuda and chamfer normal are not giving the same results
my environment: python3.7 + cuda 10.1 + pytorch 1.6
can you help me? thanks

Hi @a4152684 ,
I would start by looking at the output of the cpu/gpu approaches and check which one is failing for you.
Let me know if you get to the bottom of it;
Best regards;
Thibault

Hi @ThibaultGROUEIX
thank you for your reply
I think the problem lies in the output of the gpu, the output of the gpu is all 0

I see, this is very strange. It works on my end so it is hard for me to debug in your stead.
I recommend line-by-line debugging with PyCharm or VS Code to understand what is going on,
Kind regards


feat: bump k8s.io/* components to v0.22.0-beta.0

Signed-off-by: Daniel Sover<EMAIL_ADDRESS>
Description of the change:
This commit primarily bumps all the k8s.io/* component dependencies to v0.22.0-beta.0 ahead of the eventual v0.22 release (kube 1.22) where a further rebase will be required.
The following additional changes were made:

Removed the kube api-server pin as https://github.com/kubernetes/apiserver/issues/65 was resolved in v0.22.0-beta.0
Removed the delegated authentication watch request bug fix pin as this was resolved in v0.22.0-beta.0
Bumped helm.sh/helm/v3 to latest release as the older version was importing a k8s.io/api/batch/v2alpha1 package which is not in the newer version of the api
Bumped controller runtime and controller tools to the latest releases as there was an issue with the metrics package in controller runtime in the prior version
Ran make codegen to update the package server openapi schema
Bumped kube-openapi to latest (via go get)
Removed the google/gnostic pin as it is no longer required, see https://github.com/google/gnostic/issues/195

Motivation for the change:
Part of the eventual v0.22 rebase
Follow-on Work

Block installing deprecated APIs in the InstallPlan execution. This will require adding a detailed error message — do not let the create event occur and hit the api-server.
Update all OLM tests to use v1 CRDs exclusively.

These will be addressed in a follow-up PR. The changes made in this PR do not prevent deprecated APIs from being installed on-cluster.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

/approve


Add github link

Add a link to this github repo somewhere on the page.
You can make a navbar and put it there or just add a github icon somewhere on the side.

Hi, I love your game and I feel happy to join with it. Here is my code with navbar and GitHub link to you project:
`

Jigsaw puzzles

GitHub

`

Hi, I love your game and I feel happy to join with it. How can I submit the code change??


some TBB stuff

quick link: all esr-60 tortrac tickets
networking

[ ] FPI Alt section?

HTTP AltSvc - tor 24553
HTTP2 - tor 14952 , also see tor 27260
SSL Session identifiers - tor 17252
Mozilla OA tests:  bugzilla 1337868

perf / timing

[ ] enforce dom.event.highrestimestamp.enabled=true

although they are talking about deprecating it it, but it would still hang around in ESR60
https://bugzilla.mozilla.org/show_bug.cgi?id=1485264
maybe we should add this and enforce it, because I've seen at least a couple of times now where people get confused. The pref name is a tad ambiguous and the desired outcome is oxymoronic (Thorin)
^^ Thorin is smart, be like Thorin :white_check_mark:

[ ] check what TBB do with some of the timing prefs (from #457 ) regardless of RFP

dom.enable_performance (4603) which I THINK controls

dom.enable_performance_navigation_timing
dom.enable_performance_observer

dom.enable_resource_timing

[ ] maybe consider adding the two RFP prefs for 4500 if only for info's sake (from #457 )

privacy.reduceTimerPrecision
privacy.resistFingerprinting.reduceTimerPrecision.microseconds

wasm

wasm * wasm_ionjit + wasm_baselinejit - tor 21549

other

[ ] security.webauth.webauthn tor 26614
[ ] do a diff
enable HWA tor 9145

source

we finally enabled hardware acceleration for improved browser rendering performance after applying a fix for a long-standing bug, which often caused crashes on Windows systems with graphics cards, e.g. from Nvidia

I have no idea what that means for non-windows users

ua spoof

tor 26146 - i am interested in what they do

personally I think they should limit OS to "windows" only given 1. they can live with breakage and users expectations 2. giving away free entropy is never good 3. extremely few sites will go to the lengths required to unmask the real OS and if they do, they gain nothing more than if the UA had given it away anyway 4. some methods such as TCP/IP FP'ing are moot in TBB, and TBB also disables JS by default

original post
just dropping this here for later ... [merged into above]

https://bugzilla.mozilla.org/show_bug.cgi?id=1337868 < they still need to audit http2 is isolated

also: all esr-60 tortrac tickets

https://blog.torproject.org/new-release-tor-browser-80a10
Update 2 (8/23 16:20UTC):

We audited and enabled HTTP2 which should give performance improvements on many websites

also, interestingly enough

Moreover, we finally enabled hardware acceleration

maybe worth considering adding a new section FPI Alternatives and move that stuff there. If the TBB guys are confident that it's sufficiently mitigated by FPI it should be good enough for our purposes too.
However I don't think it's a good idea to enable HWA, especially in TBB because lots of cards ie drivers are blacklisted and it's easy to detect if HWA is enabled or not. It's kind of curious too because they still limit the CPU to 1 core. I mean if #s of CPUs and CPU performance overall is a concern then GPU should definitely be as well.

I thought about that (FPI alt) :heavy_check_mark: But we need to make sure, and with HWA, that they haven't applied their own patches

https://blog.torproject.org/comment/276515#comment-276515 .. on enabling HWA

Don't you know that:

D2D renders fonts differently?
only WebGL has a so-so sanitizer (ANGLE), other calls are direct?
DXVA has different versions and no sanitization of videos?

https://blog.torproject.org/comment/276556#comment-276556
Well crap ... that's a bit of a catch 22. I'm waiting to see what they do, and they're watching us

But we need to make sure ... that they haven't applied their own patches

They didn't mention anything about custom patches in the 2 tickets about HTTP2 and TLS session IDs.
But they'll keep HTTP2-Push disabled (for now?)
If you want to make sure, the easiest way would be to ask Arthur.

Sure. Not doing anything until 8 final is out, because who knows what will get reverted. I only mentioned it because TBB has/had a lot of changes to networking under the hood.
I have some reservations about TBB TBH. Arthur has stated in the past that with FPI, they want to enable all cookies, including 3rd party, in the future. Now they're removing restrictions on other items (SSL session ticket ids, altsvc, http2), and now HWA ...
I get that they have a different threat model, and users can change to a new node at will (which wipes everything), but FPI does not protect against repeat 1st party visits - although to be fair, a VPN even though you might share the IP with others, doesn't either.
Anyway, I'm more concerned with FF. TC's looks like the perfect answer to me.

FYI privacy.reduceTimerPrecision.microseconds never existed.
It's privacy.resistFingerprinting.reduceTimerPrecision.microseconds
I've fixed it in #7

FYI: re wasm: https://old.reddit.com/r/TruthLeaks/comments/96qmmq/webassembly_is_a_privacy_security_nightmare_it/
question: isn't wasm governed by uMatrix's script ? It's still a script, right?

Yes, subset of JS:

a webpage needs to run JavaScript in order to launch webassembly programs

https://forums.informaction.com/viewtopic.php?f=10&t=25081#p97951
https://github.com/stevespringett/disable-webassembly#security-considerations
https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1456308

FYI: https://blog.torproject.org/new-release-tor-browser-80 - can't believe they rushed out a release (right?), there's too many open issues IMO, no need to rush it. I would assume we would be better off waiting a few weeks until the next couple of dot releases

FYI:

Article: https://youbroketheinternet.org/trackedanyway
Paper: https://svs.informatik.uni-hamburg.de/publications/2018/2018-12-06-Sy-ACSAC-Tracking_Users_across_the_Web_via_TLS_Session_Resumption.pdf

Haven't read it yet. TBB has a different threat model. I don't care if they allow SSL session ticket IDs. Personally, for me, this will stay disabled. Needs more analysis. eg. does this impact HTTP2 etc (having to negotiate a new handshake on every request?), what mechanisms can clear them, etc?

^^ @earthlng check your mail, FYI, we'll see what happens

https://arthuredelstein.github.io/tordemos/os-detection-font-css.html
Well, that went well: I'm on some sort of triple hybrid system

That is actually bad, isn't it?

Not sure - good I defeated it. Obviously I have blocked all fonts except the three in options. But it's just a concept. But yes, there are many ways to detect OS. TBB for example leaks OS via its fonts sets (they differ per platform)

Both of these demos are tailored for TBB. The 2nd one could also be used to detect your configured font when fonts are generally disabled with browser.display.use_document_fonts=0

https://www.zdnet.com/article/cloudflare-ends-captcha-challenges-for-tor-users/ - might explain why HTTP2 was also enabled (after ensuring it was covered by FPI of course)

Cloudflare reCAPTCHA De-anonymizes Tor Users via Cryptome 2016

TLS Session Resumption reduces the load for every handshake, but allows tracking between TLS Sessions and can be defeated by closing the browser (so that it clears the TLS cache).

a bit late but thanks for the link :jeans: :kiss:

Blame the yellow naked man. I posted before but there was a broken reference due to pants editing.

Slightly OT: FYI: https://www.zdnet.com/article/http-over-quic-to-be-renamed-http3/

QUIC stands for "Quick UDP Internet Connections" and is, itself, Google's attempt at rewriting the TCP protocol as an improved technology that combines HTTP/2, TCP, UDP, and TLS (for encryption), among many other things

On IP terms, TCP is stateful and requires acknowledgment of each segment, while UDP is stateless. The only sane use of UDP over TCP should be for video streaming and not whole sites.
https://github.com/quicwg
https://datatracker.ietf.org/doc/draft-ietf-quic-http/
So g00gle will serve HTTP/QUIC Endpoints? Section 2.2 of the last link above tells us it will be done via an Alt-Svc: header field and I'll gladly strip away that headers.

...that is: 0703 disable HTTP Alternative Services

Another one from Waterfox https://github.com/MrAlex94/Waterfox/issues/799

FYI: https://old.reddit.com/r/netsec/comments/a1d6hl/stealing_webpages_rendered_on_your_browser_by/
also: huh?

Is this some sort of bug or server config: go to https://www.cc.gatech.edu/ and it is secure, view the PDF and it's not

For whatever it's worth, that server is jacked up. It only supports TLS 1.0 and its clock is running 20 minutes behind. I keep security.tls.version.min at 3 so I can't connect at all; curious why it would show different security statuses for the index vs the PDF, though.

I'm still quite keen to create a FPI alternatives section, but with the prefs left active. We've focused on SSL sessions (yup, talked to death), HTTP2 (no one really knows), and AltSrv (alt-svc headers can be used for cross domain tracking) .. but lets not forget OCSP cache is also isolated.

check what TBB do with some of the timing prefs

TB 8.0.3

4603 dom.enable_performance = default false (true in FF)

they leave dom.enable_performance_navigation_timing & dom.enable_performance_observer as true (we don't have these, but looks llike 4603 is a master pref)

4602 dom.enable_resource_timing = default false

These are already covered by RFP (we checked when the bugzilla for them were dome). I can't currently re-find the tor ticket comment where it was tested and confirmed by Arthur. Also Tor Browser is kinda out of whack with deprecated prefs and these RFP alts - it will take them time to sort everything out (not much happening in all the 8.5 hardened versions on this), meanwhile they are just erring on the side of caution, I guess.
Moving to ignore for now. They'll come up again in a TB diff down the track

Do you want to do anything about security.webauth.webauthn etc

I don't think we need to do anything about this

https://trac.torproject.org/projects/tor/ticket/26614
https://bugzilla.mozilla.org/show_bug.cgi?id=1432542

/* xxxx: disable Web Authentication API [FF60+]
 * [1] https://developer.mozilla.org/en-US/docs/Web/API/Web_Authentication_API ***/
user_pref("security.webauth.webauthn", false);

Tor is only disabling it because they haven't vetted it. - Reopen this issue if you think otherwise. Other than that, this will no doubt come up again when we do a TB diff (but man, its taking them a long time to get Quantum Tor Browser sorted out!)

Update: re https://github.com/ghacksuserjs/ghacks-user.js/issues/491#issuecomment-442756129 re Stealing Webpages Rendered on Your Browser by Exploiting GPU Vulnerabilities
Tom Ritter emailed me back.

This paper is from 2014. I'm not sure why or how to made the news cycle last month.
The attack vector for this is an attacker running an application accessing GPU memory locally on your computer. It's not a malicious website.

We're not concerned about this attack vector - if someone is running native code locally (even as a different user) - we aren't in a position to defend against these types of side channel attacks.

My bad, not sure why it popped up on my radar TBH. Old paper and system is already compromised. I really must think more before I type (note to self: think MOAR)


Where call loginWithCas() function ?

I just put the settings CAS into settings.json and run my project with this cmd :
meteor run --settings settings.json
But i don't understand where to call the client-side loginWithCas() function?

@kevd17
https://github.com/wekan/wekan/blob/devel/client/components/main/layouts.js#L125
To find something in Wekan, you can also use find.sh script at https://github.com/wekan/wekan

I have not tested yet does CAS work and how:
https://github.com/wekan/wekan/issues/2166
I presume using CAS would need adding some settings to Snap and Docker.
At some previous open and closed issues and PRs at https://github.com/wekan/wekan you can find some CAS related code and comments.
I would need to know how to setup some CAS server to test. Someone had CAS working somehow in those issues and PRs.


[QUESTION] Icon on the left of the services

Hello,
it's me, again !

Can you tell me what that represents? Is this customizable?
Thx

Yeah, that is supposed to show the opening method (newtab, sametab, iframe, etc). It uses font-awesome for the icons, so it looks to me like it's not getting loaded. Try setting enableFontAwesome: true under appConfig, and let me know if that doesn't fix it :)

Adding enableFontAwesome: true under appConfig actually solved the problem, thank you.


Fixes Deprecation warning for #has_rdoc (Rubygems)

fixes https://github.com/randym/axlsx/issues/585

👍 A bit of context rubygems 1.7 release notes

This has been fixed in caxlsx: https://github.com/caxlsx/caxlsx/commit/9c194405b57c803c65943f7cdce2fb825bd892e7


Update Dockerfile

I added those two and posted the dockerfile changes but looks like it ended up as a new PR.  These are from the container testing.


Is it possible to use logical_imager with pytsk?

Hi, just want to know if pytsk support the use of logical_imager function?

What is "logical_imager function"?

Hi, sorry i think my question dont really express what i wanted to ask. I see that autopsy has the function to create an image of a live logical drive, and i am wondering if the pytsk3 can do the same as well?

What storage media image format?
pytsk is a wrapper around libtsk. You might be able to read a storage media device through libtsk and write that to a storage media image file, but that is quite obscure way of doing things I would recommend against it.
I'm also unsure if libtsk deals with errors like a specialized disk imaging tool would.

I am trying to create a forensic disk image, so i guess any will do, maybe VHD.
Basically, the main idea here is to search unallocated space within a logical drive. The only solution i found was to provide a forensic disk and using python to do so. I was thinking, since pytsk is a wrapper around libtsk, it might be possible to search unallocated space of a running logical drive. If not, i was wondering if pytsk can help to create the forensic disk image.

I am trying to create a forensic disk image, so i guess any will do, maybe VHD.

Correct me if I'm wrong but it sounds to me you're trying to search unallocated space of a mounted logical drive ?
And that creating a disk image (forensic or not) is a possible solution you've already decided on.

If you say "forensic disk image" what do you mean? Do you mean you want a storage media image that includes unallocated space? Or are there other requirements?
What file system are you talking about?
What do you mean with "unallocated space"? Does your definition include slack and/or free space or do you only mean space marked by the file system as unallocated?

You can likely use libtsk/pytsk to get the file system unallocated information and scan those ranges. But that sounds like a lot of trouble if there are tools like bulk-extractor?

I am trying to create a forensic disk image, so i guess any will do, maybe VHD.

Correct me if I'm wrong but it sounds to me you're trying to search unallocated space of a mounted logical drive ?
And that creating a disk image (forensic or not) is a possible solution you've already decided on.

If you say "forensic disk image" what do you mean? Do you mean you want a storage media image that includes unallocated space? Or are there other requirements?
What file system are you talking about?
What do you mean with "unallocated space"? Does your definition include slack and/or free space or do you only mean space marked by the file system as unallocated?

You can likely use libtsk/pytsk to get the file system unallocated information and scan those ranges. But that sounds like a lot of trouble if there are tools like bulk-extractor?

I am trying to search unallocated space of a mounted logical drive.
As my end-goal is to search and recover data from unallocated space,i would want a disk image (i.e.,  .raw, .dd) which includes the unallocated space.
I would guess the file system is NTFS.
By unallocated space, it is more of space occupied by deleted files previously, that is marked as unallocated by the system, so i guess it includes free space.

I am trying to search unallocated space of a mounted logical drive.

For what purpose? File recovery? Fragment recovery? Textual string recovery?
Why do you want to build it yourself / use pytsk/libtsk? Why not use existing tool that already do this?

I am trying to search unallocated space of a mounted logical drive.

For what purpose? File recovery? Fragment recovery? Textual string recovery?
Why do you want to build it yourself / use pytsk/libtsk? Why not use an existing tool that already does this?

For file recovery, and i wanted to build a forensic tool, which can search unallocated space and recover data from it. If the existing tool allow me to do so via command line and in daemon mode, i would like to try as well. I just came across pytsk, as i saw that autopsy has that functionality.

The scope of your goal is beyond pytsk/libtsk. libtsk (Sleuthkit) is not the same as Autopsy.
You can use pytsk/libtsk to solve part of the problem but not entirely.
There are already tons of file carving tools (including command line ones) have a look at https://forensicswiki.xyz/wiki/index.php?title=Tools:Data_Recovery#Carving
How do you imagine using such a tool in daemon mode? once the recovery is done there is no need to keep the process running?

oh thanks for the clarification. Would explore the links you provided, appreciate the help.
I was thinking that the tool will stop the process after recovery is done.

I was thinking that the tool will stop the process after recovery is done.

It is unclear to me why do you need a daemon then, but that's a different topic. See https://en.wikipedia.org/wiki/Daemon_(computing) for an explanation strict sense of the terminology
I'll close this issue since you're initial question appears to be answered.