Optional parameters with 'params' keyword

The page should discuss optional parameters used in conjunction with params
For example:
void foo(string dflt = "default", params string[] details);

Discuss how these work:
foo("detail1", "detail2");
foo("x", "detail1", "detail2");
foo(dflt: "x", "detail1", "detail2");

Is the language spec clear enough that in the first case the value for:
dflt is null
details is ["detail1", "detail2"]

In the second case:
dflt is null
details is ["x", "detail1", "detail2"]

In the third case:
dflt is "x"
details is [ "detail1", "detail2"]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: dbdb1f5e-a34b-6f30-2262-7c659e1ee466
Version Independent ID: c985d741-8cf9-4486-d803-ddee5904faa1
Content: params keyword for parameter arrays - C# reference
Content Source: docs/csharp/language-reference/keywords/params.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hello @djmarcus1!
I found ambiguity in this approach.
You can have this information on the page.
But, trying to follow the same standards as the other examples as in, ref, out, and the other ones, we should put this option on everyone.
Or, maybe we could use these pages as a specific topic for the subject suggested, adding a link to the optional parameters detailing page.
And there add some examples for each of these Method Parameters.
What do you think about this second option?
I can send a PR for this topic, after our discussion.

Hi @djmarcus1 @Viniciusap
Before we make any changes, let's discuss the issue.
I wrote a small program to replicate the sample:
foo("detail1", "detail2");
foo("x", "detail1", "detail2");
foo(dflt: "x", "detail1", "detail2");

void foo(string dflt = "default", params string[] details)
{
    Console.WriteLine($"dflt: {(dflt is null ? "*null*" : dflt)}");
    Console.WriteLine($"details: {details.Length}");
    foreach (var item in details)
        Console.WriteLine($"\t{item}");
}

The output I get is:
dflt: detail1
details: 1
        detail2
dflt: x
details: 2
        detail1
        detail2
dflt: x
details: 2
        detail1
        detail2

Namely, the positional parameter dflt is not null in any of the examples. Try it here: Sharplabl.io
What should be added or changed here?

Hello @BillWagner
No additional parameters are permitted after the params keyword in a method declaration, and only one params keyword is permitted in a method declaration.
And also the nullable parameter should be the last one.
Even if we change the type of the dflt we can't use the 'default' value.
I did two examples here:
Shaplabl1
Shaplabl2
For my perspective there is a bug here to be updated.

There is a couple of solutions to be suggested here:
1 - Take off the possibility to have a nullable parameter.
2 - Correct the behavior to accept a nullable parameter and put them at the end (CS0231 must add an exception to nullable parameters).
3 - Correct the behavior to accept a nullable parameter to be understood with a param key (IDE0060 it's not thrown when the param is the last one)

@Viniciusap I have trouble understanding some of what you're saying, but I'll try to respond anyway.

"Nullable" is not the same as "having a default value". That's why your first example does not compile. You could fix that by changing the type of the parameter to int?.
Parameter default values have very limited usefulness in params methods, but that's not a bug. If you want this to improve, consider opening a new discussion at dotnet/csharplang about this.

Hi, @svick.
I may have used the wrong word here. I apologize.
I was trying to say an "optional parameter".
And maybe the word "bug" was the wrong one too. It's more like a clear use of both approaches together. Because right now we can't use the full possibilities of them together. In my examples, I'm trying to show all possibilities we can use the default value using them together. Because @BillWagner shown to us the usage of parameters using the same type, I wanted to see if the compiler could understand different types too.
A revised list of my suggested approaches.
1 - Take off the possibility to have an optional parameter with params.
2 - Correct the behavior to accept an optional parameter and put them at the end (CS0231 must add an exception to the optional parameter).
3 - Correct the behavior to accept an optional parameter to be understood with a param key (IDE0060 it's not thrown when the param is the last one)

@Viniciusap
I like parts of this list better:

1 - Take off the possibility to have an optional parameter with params.
We should make this change, but I'd like to phrase it differently. You can't specify a default value for a params array, because the language already defines one. When the caller doesn't provide any values for the params array, the value is an empty array. The 3rd bullet item in the first list implies this, but isn't as clear. We should add a sentence here.

2 - Correct the behavior to accept an optional parameter and put them at the end (CS0231 must add an exception to the optional parameter).
I think what you're saying here is that a params array must be last. It must follow all other parameters, even those with default values.

3 - Correct the behavior to accept an optional parameter to be understood with a param key (IDE0060 it's not thrown when the param is the last one)
I'm sorry, but I don't understand what change you want to make here. Can you rephrase it?

@BillWagner how about now?
1 - Take off the possibility to have an optional parameter with other parameters using params. One or another should be used never both. Possibly creating a new compiler error to be triggered when that happens.
2 - Correct the behavior to accept an optional parameter and put them at the end (CS0231 must add an exception to the optional parameter).  Today we have a rule that params should be the last one. We may add an exception for this rule when using an optional parameter
3 - Correct the behavior to accept an optional parameter to be understood with a param key (IDE0060 it's not thrown when the param is the last one). This is what's happening today. The optional parameter it's not being identified when we are trying to use it together with one parameter using the key params no matter the types we are using. So we need to correct the behavior to understand the parameter with default values, even if it's not the last one when it is together with another parameter params.
I'm sorry, English it's not my first language. This list is three different suggestions and approaches to try to open a ticket to update the csharplang repo.

Hi @Viniciusap
The first idea should be discussed in dotnet/csharplang rather than here.  That would be a change to the language.
The second two could be discussed on dotnet/roslyn instead. They would change the behavior of analyzers, not the language.
Go ahead and open those discussions and reference this issue.
Once those are resolved, we can decide if we want to update the docs based on the resolution of those discussions.

Hi @BillWagner, thank you!
Discussion

closing in favor of language design discussion.


Add support so administrators can specify the location and name of the zim file

To date, I've used a hard-coded location and filename for the zim file. This hasn't been a problem when developing or testing locally, however it'd be useful to enable the server administrator to configure the module to specify the location and filename for the zim file.

Fixed in https://github.com/kiwix/kiwix-apache/commit/0b43ba46b0ab7b59ad8fbd27393dc61fd96550f5


Improved: ORDER - have requestMenuLocation (OFBIZ-12971)

Given that request screens are used as portal pages, the inclusion of such portal pages in other applications leads to errors being thrown for the associated menus (due to the use of the mainMenuLocation parameter in web.xml). Having a requestMenuLocation in web.xml solves this issue.
modified:

web.xml: add contextParam requestMenuLocation
CommonScreens.xml: change location request related menus
CustRequestScreens.xml: change location request related menu

Hi @PierreSmits ,
Why has this been closed? TIA

Ah I think I got, it has been partially replaced by https://github.com/apache/ofbiz-framework/commit/6039526c744e1a75e5c40b553de964041f386531, nevermind.


Try to connect on private server in  https

Hi
I try to connect to a server in https with a certificat not signed by a big CA compagny but by an private not recognized by browser.
When I choose https the client change to http and failed the validation.
Why replace https by http ?
                    // If the url begins with HTTPS, fallback to HTTP                     if (/^https:\/\/.+/.test(host)) {                         hostField.value = host.replace('https://', 'http://');                         return execValidation();                     }

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30515936-try-to-connect-on-private-server-in-https?utm_campaign=plugin&utm_content=tracker%2F19476668&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19476668&utm_medium=issues&utm_source=github).

We fallback to try to find one accessible server.
Which version are you using?

Hello
You can close the issue, we can't use self signed certificat with electron.
I use let's encrypt for have a valide certificate.


[BUG] fastchat + vLLM +OpenAI API 调用qwen模型，数据不需要预先处理吗

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
官方给出的调用方式为：
openai.ChatCompletion.create(
model="Qwen-7b-chat",
messages=[
{"role": "user", "content": "你好"}
],
)
但是qwen 模型接收的输入格式不应该是这样吗？ <|im_start|>user\n你好<|im_end|>\n<|im_start|>
请问vllm+openai 自己实现了预处理还是需要自己处理成这样呢？
openai.ChatCompletion.create(
model="Qwen-7b-chat",
messages=[
{"role": "user", "content": "<|im_start|>user\n你好<|im_end|>\n<|im_start|>"}
],
)
期望行为 | Expected Behavior
1
复现方法 | Steps To Reproduce
1
运行环境 | Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA (`python -c 'import torch; print(torch.version.cuda)'`):

备注 | Anything else?
1

Please follow the examples or look into the OpenAI API documentation.
For Qwen1.0, it is FastChat that performs the messages to input sequences conversion.
For Qwen1.5, it is vllm that uses the tokenizers in transformers to perform the conversion.


meteor.collection update function?

Meteor provides an update function for the Meteor Collection object. Is there an equivalent for the $meteor.collection service? I only see save(), remove(), subscribe(), but no update.
What would be a good way to specifically update an existing doc? Just calling save() on it?

Yes exactly, save() is the equivalent but simpler version of update.
If you want to use update, you can call it directly on the Meteor collection

Awesome thanks Uri!


put event listeners inside document ready and annotate code

added a document ready for event listener and annotated and organized things

Looks great.


Fix character range to include last character

Fix character range alternative parser optimization to include last character.
Fixes #33

Thanks again for the fix!  Sorry for the lag on getting this in.


feat: upgrade @stacks package to 3.1.0

Simple pr upgrading the stacks.js dependencies released as 3.1.0 today.
Linked issue https://github.com/blockstack/stacks.js/pull/1117.
cc/ @kyranjamie @fbwoolf

@kyranjamie How risky it'd be to do a release out of master just with the commit before the code freeze on Monday?

I would say fairly risky without thorough QA. Unforeseen issues are the reason for the code freeze.
@pradel I know you're eager for this feature. We can share a feature build for you to test it over the holidays if this helps?

@kyranjamie yes please, that would be great.
When can we expect it to be released if it's not included in this version?

Closing for https://github.com/hirosystems/stacks-wallet-web/pull/2089


Enhancing metadata API to return upsert partition to primary key count map for both controller and server APIs

Scope of the PR
Enhance server and controller API to return partition to primary key count for realtime tables that have upsert enabled:

Server API: returns the map for all the partitions hosted by the instance.
Controller API: returns the map for the table.

Testing
The changes were tested locally by invoking the server endpoint followed by controller endpoint to test that there is no duplication in counting PK's. The replication of segments across servers could be a potential reason for duplication, but the controller API has taken care of it.

Server responses:

{
    "tableName": "upsertMeetupRsvp_REALTIME",
    "diskSizeInBytes": 0,
    "numSegments": 1,
    "numRows": 0,
    "columnLengthMap": {},
    "columnCardinalityMap": {},
    "maxNumMultiValuesMap": {},
    "columnIndexSizeMap": {},
    "upsertPartitionToPrimaryKeyCountMap": {
        "0": 48
    }
},

{
    "tableName": "upsertMeetupRsvp_REALTIME",
    "diskSizeInBytes": 0,
    "numSegments": 1,
    "numRows": 0,
    "columnLengthMap": {},
    "columnCardinalityMap": {},
    "maxNumMultiValuesMap": {},
    "columnIndexSizeMap": {},
    "upsertPartitionToPrimaryKeyCountMap": {
        "1": 45
    }
}

Controller response

{
        "tableName": "upsertMeetupRsvp_REALTIME",
        "diskSizeInBytes": 0,
        "numSegments": 2,
        "numRows": 0,
        "columnLengthMap": {},
        "columnCardinalityMap": {},
        "maxNumMultiValuesMap": {},
        "columnIndexSizeMap": {},
        "upsertPartitionToPrimaryKeyCountMap": {
          "0": 48,
          "1": 45
        }
}

What if there is discrepancy for partitions with multiple replicas?

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (4823802) 61.66% compared to head (3ad1d19) 34.74%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

...psert/ConcurrentMapTableUpsertMetadataManager.java
0.00%
5 Missing :warning:

...t/controller/util/ServerSegmentMetadataReader.java
0.00%
4 Missing :warning:

...che/pinot/server/api/resources/TablesResource.java
0.00%
4 Missing :warning:

...ot/common/restlet/resources/TableMetadataInfo.java
0.00%
3 Missing :warning:

...ata/manager/realtime/RealtimeTableDataManager.java
0.00%
3 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12334       +/-   ##
=============================================
- Coverage     61.66%   34.74%   -26.92%
- Complexity      207      944      +737
=============================================
  Files          2421     2345       -76
  Lines        131852   128149     -3703
  Branches      20345    19789      -556
=============================================
- Hits          81303    44531    -36772
- Misses        44582    80419    +35837
+ Partials       5967     3199     -2768

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
34.74% <0.00%> (-26.80%)
:arrow_down:

skip-bytebuffers-false
34.74% <0.00%> (-26.91%)
:arrow_down:

skip-bytebuffers-true
0.00% <0.00%> (-61.52%)
:arrow_down:

temurin
34.74% <0.00%> (-26.92%)
:arrow_down:

unittests
46.56% <0.00%> (-15.10%)
:arrow_down:

unittests1
46.56% <0.00%> (-0.20%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Why we are limiting the scope to upsert enabled realtime table vs all realtime tables?


Unable to run

Hi,
When I run using the iOS simulator, I keep getting a black screen and following warning. Any suggestion on what I'm doing wrong?
Module Rust requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Misconfiguration by myself, I'm able to run the example


This is related to these two issues:
https://github.com/lexibank/transnewguineaorg/issues/14#issuecomment-782874114
https://github.com/lexibank/walkerarawakan/issues/12#issuecomment-782873959

I'm closing this since the new PR #10  for the Lexibank 2.0 release addresses it already.


Add ClusterClaim controller

Signed-off-by: Yang Le<EMAIL_ADDRESS>The task link: https://github.com/open-cluster-management/backlog/issues/7156

/assign @deads2k
/assign @pmorie
/assign @qiujian16

/approve

I have recommendations that can come as followups
/lgtm


GraphQL format?

Maybe this is something we can try to make Guangyun access easier to do?

I published a plain JavaScript library. It would cover most of the use cases.
<script src="https://sgalal.github.io/Guangyun/brogue2.js"></script>

The size of the library is less than 1 MB, which is satisfactory for most of the web applications. The actual transferred size (compressed) is less than 0.5 MB.

This repository is renamed to sgalal/qieyun-sqlite.
The JavaScript library is split into a different repository: sgalal/qieyun-js.

I have made a sgalal/qieyun-autoderiver in JavaScript, using the sgalal/qieyun-js library. I believe the data is quite easy to access now.


Support upload to zenodo

This PR aims to ease the uploading process for users, essentially eliminate the hassle of uploading weights to zenodo, upload yaml to github and make PR. Here we use as our storage backend and upload the files directly with a custom UI.

@constantinpape Now the upload feature is more complete, could you please try it out  with the preview link generated above?
Right now, items will be uploaded to sandbox version of zenodo, so don't hesitate to upload test packages.
After uploading, an email will send to me and I can approve or reject whether the item should be listed in the bioimage-io community: https://sandbox.zenodo.org/communities/bioimage-io

@constantinpape Now the upload feature is more complete, could you please try it out with the preview link generated above?
Right now, items will be uploaded to sandbox version of zenodo, so don't hesitate to upload test packages.

Awesome! I will give it a try later today.

@oeway I tried to upload with the following zip: https://oc.embl.de/index.php/s/zghIW2vqLKNCFcd
But when pressing "Ok" after importing the zip the menu does not continue and some errors are thrown in the console:

There were also some other minor issues I noticed:

The model file inside of the zip had to be called model.yaml, but afaik we allow it to be called <SOME_NAME>.model.yaml.
The format version is not copied from the yaml: it showed 0.1.0, but the value in the yaml is 0.3.1.
The source field was empty, although the zip contains a (local) source file that is also listed in the yaml.

@oeway I tried to upload with the following zip: https://oc.embl.de/index.php/s/zghIW2vqLKNCFcd
But when pressing "Ok" after importing the zip the menu does not continue and some errors are thrown in the console:

Thanks! Somehow I cannot reproduce the issue with your file. Possibly because I made changes in the meantime. I am now able to proceed to the uploading step. Could you please try it again?

There were also some other minor issues I noticed:

The model file inside of the zip had to be called model.yaml, but afaik we allow it to be called <SOME_NAME>.model.yaml.

Yes, we had some discussion a while about when we place the model yaml inside a package, we should rename it to model.yaml. The thing is we will need some kind of fixed entrypoint (a bit like the setup.py file of a python package and  index.html page of a website), otherwise we will need to search within the package which is not always possible (e.g. on zenodo it will generate more requests). Plus, we don't want really multiple yaml in one package.
And now while working on other RDF file, I am even thinking we should perhaps rename model.yaml to something more generic, so we can also pacakge datasets, notebooks, applications, and share the same entry point yaml file name. I thought about config.yaml but then noticed it might be confusing since we have config key in the model.yaml. I would propose something like rdf.yaml, rdf.bioimage.io.yaml, or bioimage.io.yaml.

The format version is not copied from the yaml: it showed 0.1.0, but the value in the yaml is 0.3.1.
We need to distinguish version and format_version here, in one of the onging PR, I propose that we add a version key to label the model itself. Imagine the model with the same name can also evolve, e.g. trained with more data, since the purpose is the same, one might want to use the exact same name, and we might not want to have distinct entries in bioimage.io. We simply want new users to use the new version of the model. In this case a version key would help. (Let's discuss more on the weekly meeting.)

The source field was empty, although the zip contains a (local) source file that is also listed in the yaml.

There is a collision in the definition of source key: https://github.com/bioimage-io/spec-bioimage-io/issues/85
I will remove it from the form now.

This seems to be a firefox issue. I still get the following issue there:

I tried with chromium and there it works. (I didn't proceed with the upload further, because I couldn't log into zenodo there, but I think that's an unrelated issue).
I have the following versions:
pape@mokshi:~$ firefox --version
Mozilla Firefox 88.0.1
pape@mokshi:~$ chromium --version
Chromium 91.0.4472.77 snap

I tried with chromium and there it works. (I didn't proceed with the upload further, because I couldn't log into zenodo there, but I think that's an unrelated issue).
I have the following versions:
pape@mokshi:~$ firefox --version
Mozilla Firefox 88.0.1
pape@mokshi:~$ chromium --version
Chromium 91.0.4472.77 snap

Ok, but I just tried Firefox 88.0.1 (64-bit) on macOS and it worked. I had to allow popup window in the addrress bar to get the zenodo login window, maybe that's the problem for you? Maybe you blocked the popup window in Chrome too?

Ok, but I just tried Firefox 88.0.1 (64-bit) on macOS and it worked. I had to allow popup window in the addrress bar to get the zenodo login window, maybe that's the problem for you? Maybe you blocked the popup window in Chrome too?

Still doesn't work for me.  (And I think it works on chromium, I just don't have a PW manager there, so I can't so easily log into git / zenodo.)

And now while working on other RDF file, I am even thinking we should perhaps rename model.yaml to something more generic, so we can also pacakge datasets, notebooks, applications, and share the same entry point yaml file name. I thought about config.yaml but then noticed it might be confusing since we have config key in the model.yaml. I would propose something like rdf.yaml, rdf.bioimage.io.yaml, or bioimage.io.yaml.

I agree, we should update this so we have a unified entry point.
I suggest we discuss this in a separate issue in the spec repo.

Note that I am on Ubuntu 20.04. (And I think it works on chromium, I just don't have a PW manager there, so I can't so easily log into git / zenodo.)

Hmm,  I know the error, but don't know why it happens. I will investigate into that later.
Maybe someone else can also try it. @FynnBe @esgomezm Could you test the upload feature when you have sometime?

Which browser or OS do you want to check?

Which browser or OS do you want to check?

I think Linux + Firefox would be good if you have it available.

Hi! I played a bit with Linux + Fireforx and when uploading the zip file, it worked correctly. I got to the point in the image but without publishing the model. In Zenodo all the files were OK so I guess that this part will work also.
What was a bit confusing is that the feature creates a new user with the github credentials which is different from the one I already had with the same github account. So now I have two zenodo accounts with the same name and different content? how can access one or the other one?
The interface says: "New changes will be added as a new version". This was kind of confusing. Does the upload feature allow updating a published version? Or do you mean that you need to make a new submission?

Then, I tried to upload the model but using the RDFX. When doing so, do we also need to upload the model.yaml?
In any case, I tried it in both ways: uploading the zip file as before, and uploading the files in the zip, without being compressed.
It outputs the following message:

Regarding GitHub - Zenodo permissions, when you give them for the first time, two contradictory messages appear (see the image). Do you think it could be possible to remove the second one saying invalid authorization request?

@esgomezm Thanks for testing!

Hi! I played a bit with Linux + Fireforx and when uploading the zip file, it worked correctly. I got to the point in the image but without publishing the model. In Zenodo all the files were OK so I guess that this part will work also.

Good!

What was a bit confusing is that the feature creates a new user with the github credentials which is different from the one I already had with the same github account. So now I have two zenodo accounts with the same name and different content? how can access one or the other one?

Aha, this is because we are using the sandbox version of zenodo (https://sandbox.zenodo.org) for testing, so that requires a different account.

The interface says: "New changes will be added as a new version". This was kind of confusing. Does the upload feature allow updating a published version? Or do you mean that you need to make a new submission?

I updated the text on the interface now. This basically means if you publish you can not remove it but you can change it by adding new versions. You can also test this feature, on the first screen if you specify an existing doi using option 3, then you should get a update existing deposit option.

Then, I tried to upload the model but using the RDFX. When doing so, do we also need to upload the model.yaml?
In any case, I tried it in both ways: uploading the zip file as before, and uploading the files in the zip, without being compressed.
It outputs the following message:

I guess what happens is that you don't have covers specified in your RDF, can you confirm that? I have fixed the issue though by make it empty by default.
In general, for issues like this it would also help if you can open the browser development tool and copy the error in the browser console.

Regarding GitHub - Zenodo permissions, when you give them for the first time, two contradictory messages appear (see the image). Do you think it could be possible to remove the second one saying invalid authorization request?

Unfortunately not, this is the part implemented by Zenodo, we can however submit a github issue to them.
Anyway, please try the latest version (e.g refresh the page twice) and see if the issues still exists.

Hi @oeway!
I'm trying to upload a model but now it doesn't work when uploading the files to zenodo:

@esgomezm Thank you for the report with console error. I just fixed it now.
Does this mean your RDF does not have a author field?

It has, but in which format? the list or the composite dict? :)

It has, but in which format? the list or the composite dict? :)

We are still in 0.3.1 format right now, so it should be a list of strings.

Done!
The only thing is that with the size of the window I couldn't see the rolling circle so I click on upload a couple of times and the app created as many zenodo drafts as clicks

We opened pandora's box:
Now I should upload this model.yaml to my github repo but I should change all the paths to weights so they point to the ones in zenodo. Otherwise, I cannot use the packager, am I right?

We opened pandora's box:
Now I should upload this model.yaml to my github repo but I should change all the paths to weights so they point to the ones in zenodo. Otherwise, I cannot use the packager, am I right?

I got an email about your model ;) see below:

And I just approved the request, so you should see the new item in the model zoo now.
One idea is that you don't need to do anything in your github repo for those models which applied to be listed in the zenodo community (as you see we already listed your published model). So in this case we don't really need github repo for storing models.
However we can still use the community partner github repo for validating, and testing the models with CIs, it will generate a json file with the testing reports for each model, with the possibility to black list some models from showing on the website.
Let me know what you think.

Ok, it sounds good.
I don't see it in the main bioimage.io webpage but in the preview.
I think it's a pity if these models wouldn't be linked to the model packager as they indeed ready for that. Otherwise, we need to go to Zenodo and download each file one by one.
@constantinpape you have the model available for testing :)  https://deploy-preview-104--bioimage.netlify.app/#/?id=10.5072%2Fzenodo.849111

@constantinpape you have the model available for testing :) https://deploy-preview-104--bioimage.netlify.app/#/?id=10.5072%2Fzenodo.849111

Awesome! I will check it out later.

@esgomezm There was an issue about the display of linked items, now it has been fixed, so you should got the packager by default. Unless you removed it from links when you upload it.

Just tried the Upload-feature: Works fine! :) Really nice. Only thing I'd change is the second step, which Esti mentioned before I think. I tried the N2V Model bundle, I only had to change the MDF name.
When clicking on "OK" you just get redirected wordlessly to Zenodo and I think I had to click "OK" 4 times (First time Zenodo Login, Log into Zenodo from Github, allow 3rd party tool and so on) until I could proceed.
And I'm really missing a "Download all" button on Zenodo, but that's another topic.

@tomburke-rse Thanks for testing it.

Only thing I'd change is the second step, which Esti mentioned before I think. I tried the N2V Model bundle, I only had to change the MDF name.

Let's discuss in today's meeting about the naming of the manifest file.

When clicking on "OK" you just get redirected wordlessly to Zenodo and I think I had to click "OK" 4 times (First time Zenodo Login, Log into Zenodo from Github, allow 3rd party tool and so on) until I could proceed.

Right, there is easy way around it, I hope it won't cause too much confusion for the users.

And I'm really missing a "Download all" button on Zenodo, but that's another topic.

We will add a download all button to the zenodo description test then.

I tried this with 2 other setups, but ran into the following issues:
Setup 1
OS: CentOS 8 (This is a VM @ EMBL)
Firefox: 78.11
I can go through the whole procedure and click "Upload as new Deposit".
However this fails with
Failed to upload file: Error: Failed to update metadata, error: [{"field":"metadata.creators.0.name","message":"Not a valid string. Name is required."}]

I am trying to upload this model.
Setup 2
OS: Same
Chromium: 85.0
I come up to the zenodo login with github credentials but then it just resets to the Bioimage.Io site after a few seconds (not enough to enter credentials, esp. not with 2FA).

@constantinpape Thanks for the report and providing the test package. I debugged it and found out that I didn't implement the new authors format. I have now fixed it, please give the new version a try (you may need to reload twice).
No idea about the login issue, is there a chance to get a screen recording?

please give the new version a try (you may need to reload twice).

Yes, it works now, Here's the uploaded model: https://sandbox.zenodo.org/record/865308#.YMkExSWxVpQ.

No idea about the login issue, is there a chance to get a screen recording?

Sure. I also checked this locally now and the same issue occurs with chromium 91.0 (on Ubuntu 20.04). See screenrecording below; after a couple of seconds the zenodo github login tab just closes.

@constantinpape I just fixed the packager, and there are also some adjustment to fit the changes we have for config. Could you give it another try before we merge?

@constantinpape i saw your new upload: https://sandbox.zenodo.org/record/865994 please note that your docs file has unusual indentation which make the entire docs rendered as a code block. Removing the indentation should fix the issue.

@oeway I checked the uploader again (as you have already seen) and it works. The model packager also works,  but it does not include all files that need to be packaged: documentation.md and environment.yaml are missing:

Note that I did not list these in attachments, because I thought that the doc and dependency file should always be packaged. But if you think that this is rather an issue of the model and they should be added to attachments I can also fix this on the model side.

@constantinpape i saw your new upload: https://sandbox.zenodo.org/record/865994 please note that your docs file has unusual indentation which make the entire docs rendered as a code block. Removing the indentation should fix the issue.

Thanks for checking. I will fix it in the code that generates this.

I found another issue: The Download RDF button on zenodo does not work for this model:
When I go to https://bioimage.io/#/p/zenodo:865994 I just see a white page.

I found another issue: The Download RDF button on zenodo does not work for this model:
When I go to https://bioimage.io/#/p/zenodo:865994 I just see a white page.

Thanks for testing it again!
That's expected. As I mentioned earlier, I haven't implemented the download link yet, that's a preserved link. After merging it will show a popup message saying not implemented instead of a blank page.
I will delay the implementation of downloading from zenodo, since the recommended way is to download with the packager on bioimage.io.
Regarding the docs and dependency in the packager, i will fix that in the packager app. Also note that, we agreed that we will move source and dependencies to the weight format in 0.4.0.

Thanks for testing it again!
That's expected. As I mentioned earlier, I haven't implemented the download link yet, that's a preserved link. After merging it will show a popup message saying not implemented instead of a blank page.
I will delay the implementation of downloading from zenodo, since the recommended way is to download with the packager on bioimage.io.

OK, that sounds good.

Regarding the docs and dependency in the packager, i will fix that in the packager app.

Awesome!

@oeway I’m checking the models from the uploader and the source button (<>) works differently. Instead of showing the model yaml it redirects you to zenodo. Do you think it would be possible to show the specs?

@oeway I’m checking the models from the uploader and the source button (<>) works differently. Instead of showing the model yaml it redirects you to zenodo. Do you think it would be possible to show the specs?

Hi, sorry I forgot to change that, now fixed. Note that it will only work for newly uploaded models. Please upload a new model and see if it works.

All fixed now, except the login issue mentioned by @constantinpape
Now merge.

All fixed now, except the login issue mentioned by @constantinpape

I made #113 to keep track of these issues.

Now merge.

Awesome. Thanks Wei!


segment

Hello. I recently try to run allreduce_benchmark with GPU. However, when I run it, the console prints "Segmentation fault (core dumped)" after it printed "Submitting 5 warmup jobs.". I find that when I compile the allreduce_benchmark using the command "make allreduce_benchmark  DPDK=1 MLX5=1 VCL=0 CUDA=1" under the /p4app-switchML/dev_root/benchmarks/, the console prints that "Makefile:72: CUDA is set. But GPU memory is not yet handled by any of the prepostprocessors in the client library." I think this problem causes segment fault but don't understand why it happens. Would you like to give some advice? Thanks in advance!

Hey Lace,
Yeah the CUDA flag is not yet fully supported. The benchmark is going to send GPU pointers to the client library, but the client library prepostprocessors will deal with it as a CPU pointer hence the segmentation fault. This means that you have to copy your tensors to CPU before you use SwitchML.

Thanks very much!

Does this mean the performance reported in switchML paper is with back and forth tensor copy between CPU and GPU memory?

Yes, that is correct. The training experiments reported in the NSDI'21 paper are copying data from the GPU buffer to the CPU memory, performing quantization and then using DPDK to send data to the switch. The same with inverted order and dequantization happens in the other direction.
We expect a significant improvement with 1) quantization done by the GPU and 2) using GPU-direct or similar technologies to skip the data copies to/from CPU memory, but unfortunately we haven't implemented this yet.


Enabling drag-and-drop functionality for the Cluster Explorer, Cluster Management sections would enhance convenience.

Is your feature request related to a problem? Please describe.
With the latest dashboard updates in version 2.8, there is some extra space allocated to the cluster management page, cluster explorer page, and the hamburger menu page.
Describe the solution you'd like
It would be convenient if the area could be easily moved by dragging.
Additional context
From the screenshots, the space allocated to the pages is too much, if its drag and drop, if there is an option provided to adjust to the required space will be more convenient.

I think in the 2.8.0 timeframe we should reduce the width of all non-cluster explorer side menu's.
Post 2.8.0 we should consider letting the user manually change this. We would need to persist the users change as well

If I understand this correctly, you would like to resize both the app-bar (when open) and the menu?

The width of the app-bar or menu should (almost) never be smaller than their content. Your screenshots do not show the longer text labels which are shown within those areas.

In the next iteration, we should investigate making the sidenav menu resizeable. The app bar has a minimized state already and shouldn't need this kind of functionality.

@kwwii that is correct, I would like them - both app-bar and the menu to be resized.
However, as previously mentioned in the comments above, as it's important to note that the space is required for both 'Virtualization Management' and the 'About' page, we can disregard the app bar section.


test threaded Chez Scheme

Correct, we don't support multi-threaded programs, but we do have users that have only the threaded version of Chez Scheme installed on their systems and would like to use Swish. See a9722308da8330a64e8e7040647ff251f0159108.

I see.
What do you think about adding that disclaimer to README.md, maybe under the Design section?

I like those suggestions, thank you!

Thanks, Bob!


autoRegisterTemplate is not working in appsettings.json

I don't know where to log this issue. Here or the settings plugin. It might be an issue of this repo, i thing because settings works in a generic way.
I have this settings, but autoRegisterTemplate is always false
{
        // Logging to ElasticSearch
        // Note that Name is case-sensitive
        "Name": "Elasticsearch",
        "Args": {
          "nodeUris": "http://<IP_ADDRESS>:9200",
          "autoRegisterTemplate": true,
          "indexFormat": "authIndex-{0:yyyy.MM}",
          "minimumLogEventLevel": "Debug"
}

It may not be available.
Looking at the documentation in the main README  the autoRegisterTemplate key isn't listed.
I think it might be needed in LoggerConfigurationElasticSearchExtensions.cs.
It may be the reason I can't get the sink to work with my dotnet core 2.0.0 appsettings.

I found, that it is possible to configure the ealasticsearch sink with appsettings.json.
But you have to use options instead of Args as name of the configuration object.
Example:
{
"Serilog": {
    "Using": [
      "Serilog.Sinks.Debug",
      "Serilog.Sinks.Elasticsearch"
    ],
    "MinimumLevel": "Debug",
    "WriteTo": [
      {
        "Name": "Debug"
      },
      {
        "Name": "File",
        "Args": {
          "path": "_temp\\log\\log.txt"
        }
      },
      {
        "Name": "Elasticsearch",
        "options": {
          "nodeUris": "http://localhost:9200",
          "indexFormat": "index-{0:yyyy.MM}",
          "templateName": "serilog-events-template",
          "autoRegisterTemplate":  true
        }
      }
    ],
    "Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ],
    "Properties": {
      "Application": "Sample"
    }
  }
}


[Android] Sync find_helper.{cc,h} copies with upstream

Incorporate changes that went into the upstream versions of
find_helper.{cc,h}:

1cfca29 Fix for problem with activating find-in-page match via find
tickbar.
c0b762b Implement a shell of FindRequestManager, and hook it up to
WebContentsImpl.

In addition to reducing the delta to upstream and making updating the
code in the future easier, it actually makes the code work in debug
mode (we were hitting some DCHECKs because the code had not been
updated).
RELATED BUG=XWALK-7325

@lincsoon @xzhan96
Reason number<PHONE_NUMBER>2912313563 not to copy entire files from upstream.

@mrunalk

@chuan9

LGTM!


Monitor with systemd has non-accurate run times.

When running the monitor script through systemd Uptime-Kuma often gets a "pending" flag on it. I'm trying to find solutions. Currently I've been trying to shorten the run interval but it only works for a bit of time before the next pending comes. As far as I can see the script does run at the specified time but it doesn't seem to be sending the curl command on time.

Partially fixed with a4aeadf going to add documentation that can potentially mitigate the issue.


np.matmul produces wrong result with NumPy RHS

The following multiplication produces a result with too few entries in the underlying contents, leading to errors when accessing items:
transform = ak.Array(
    [
        [0, 1, 0],
        [1, 0, 0],
        [0, 0, 1],
    ]
)

vector = ak.Array(
    np.r_[4,5,6].reshape(3, 1)
)

result = np.matmul(transform, vector)
result[0]

This does not happen if I create the vector Array by hand:
vector = ak.Array(
    [
        [4],
        [5],
        [6]
    ]
)
result = np.matmul(transform, vector)
result[0]

This is also true of transpose(vector) @ transform
>>> import awkward as ak
>>> ak.__version__
'1.2.2'

The tests are failing on platforms without numba, because the matmul indirectly calls numba. Do you have any suggestions here? I could add
numba = pytest.importorskip("numba")

to manually register the numba dependency, but this won't scale as more features have numbafied implementations.

pytest.importorskip("numba") is a good thing to add (without the assignment because flake8 would complain about the variable not being used).
There are a lot of tests that only work if Numba exists. Matrix multiplication is the only feature in which that is hidden—users don't have to manually import Numba to use it, so failures due to the lack of Numba could be a surprise—but if this is a popular feature, it should be ported to the C++ layer, anyway.
(This feature was originally written to answer an email. I didn't want to put a lot of time into something without knowing that it would be needed for analysis. Yours is the first use-case that I know about.)

OK, I'll modify the test accordingly. I should have put this comment in the PR, but it's been a long day :weary:
I understand that the feature is not really a "production one", and I can see why it makes sense to keep things high level unless required. I'm not personally going to advocate for that yet, so once this issue is closed all is fine by me!


[Feature]: Beam Search also requires diversity

🚀 The feature, motivation and pitch
Basically in decoding stage, we use sampling strategy with parameters like top_p/top_k/temp/xx_penalty to control the diversity of the generated content. However beam_search is still very important at the moment, but lacks relevant parameters to control its diversity, which is already supported in HF as follows:
HammingDiversityLogitsProcessor：https://huggingface.co/docs/transformers/zh/internal/generation_utils#transformers.HammingDiversityLogitsProcessor
Alternatives
No response
Additional context
No response

Same here!

The outputs of vLLM and Hugging Face differ significantly in this regard, making it impossible to achieve a seamless migration.


3.2.0 needs to be pushed to CocoaPods trunk

Latest available through CocoaPods is 3.1.0.

Oops, sorry about that. 3.2 should be up there now.


Increase grpc max recv message size

Skipping the usual boilerplate, because this is a kludge, everyone involved knows its a kludge, and we'll revert it in the next release.
Increases the maximum recieved message size for gRPC client connections to math.MaxInt32. This means that large controlapi List requests will be proxied correctly.

@dperny if this codeline is only accessible behind an api that has the proper creds, then i think the increase of the max message size is ok

Looks like this only affects the connections between the managers. Also, this is reverting back grpc to the same behavior as previous releases. These help mitigate the risk somewhat @andrewhsu

nitpick: update the comment in the code to something along the lines of https://github.com/docker/swarmkit/pull/2775#issuecomment-434846869


Move doc generation to jsii-docgen

Use rosetta to transliterate the assemblies
Use the docgen code to create the API reference.

Output should be a single markdown file that can rendered by the front-end. Should produce one file per submodule

Resolved here: https://github.com/cdklabs/jsii-docgen/pull/356


Saving individual tensors to file

Feature request
Are there still plans to support saving individual tensors to a safetensors file? Specifically, for my use case I would want to update a tensor in-place, meaning the new tensor would have the same shape/size as the existing one. In theory, I would just need to find the offset of a given a key, but I'm not sure if this is possible?
This seems related but has been closed? https://github.com/huggingface/safetensors/pull/134
Motivation
I want to avoid loading/saving the entire file when I just need to modify a few tensors of a large file.
Your contribution

FYI for anyone who comes across this - I ended up implementing this in a fork (https://github.com/mar-muel/safetensors).
The fork supports the save_tensors method which allows to overwrite an arbitrary number of tensors in the target file (requirement is that they have the same shape/dtype as the original tensor):
import torch
from safetensors import safe_open, safe_write
from safetensors.torch import save_file, save_tensors
import sys
tensors = {
   "weight1": torch.zeros((1024, 1024)),
   "weight2": torch.zeros((1024, 1024))
}
save_file(tensors, "model.safetensors")
with safe_open("model.safetensors", framework="pt", device="cpu") as f:
    for key in f.keys():
        print(f.get_tensor(key))
new_weight = torch.ones((1024, 1024))
overwrite_key = 'weight1'
save_tensors({overwrite_key: new_weight}, 'model.safetensors')
with safe_open("model.safetensors", framework="torch", device="cpu") as f:
    nw = f.get_tensor(overwrite_key)
print(nw)


Deploy a URI Derefrencing Service

Users should be able to take a graph URI and de reference it for additional information-ideally in the browser. phuzzy.link is a service that offers these capabilities but is fairly out of date and needs work to bring online. Additionally, the project is configured to run as a separate website; we may be able to use LodView as an alternative.

At the moment, when gnis-ld subjects are dereferenced, they end up on the KnowWhereGraph deployment of phuzzy.link


isServer and isClient always false on Instantiated objects

Describe the bug
When using Instantiate to create a non networked object, inside the Start/Update/OnTriggerEnter etc. both isServer and isClient are always false in the spawned object, regardless of whether the method is running on the server or the client. [ServerCallback] and [ClientCallback] work but even then isServer and isClient return false inside those methods.
As I'm new to mirror I assumed I was doing something wrong, but they return correctly when using non spawned objects (placed in scene prior to running). So I have to assume it's a bug unless I misunderstand some behaviour about spawned objects. I tried older versions of mirror and had same issue.
[IMPORTANT] How can we reproduce the issue, step by step:
I made a template: https://github.com/Quetra1/isServerDemo
It's just a player object and spawned objects, arrow keys to move and press spacebar to spawn the object on the client and server using a [Command]. The Console will log isServer/isClient on Start/Update/OnTriggerEnter on the spawned objects.
Expected behavior
isServer/isClient should return true when functions are running on the server or client respectively.
Desktop (please complete the following information):

OS: Windows
Build target: Windows
Unity version: 2022.319f1
Mirror branch: 93.0.1

isServer / isClient aren't set until after NetworkServer.Spawn is called with the object. You're only instantiating the thing without spawning it.


treewide(maintainers): remove polykernel

Description of changes
As note in https://github.com/NixOS/nixpkgs/pull/318401#issuecomment-2241749292, I no longer have the time to actively uphold my maintainer responsibilities.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you for your contributions!


Find last filled row number of a column in a worksheet

Hi, I'm trying to set up a dashboard in a worksheet that has multiple Pivot tables. The data they display will be changing and so the Pivot table size in rows will be changing and I need to define where to place the next pivot table without it overwriting data in the previous cells. Is there a way to find the last filled row number of a column or the cell where a pivot table ends? Thanks!

Looks like the Dimension property on the Pivot Table sheet does not get populated. There may be a property on the pivot table itself.

$xlfile = "$env:TEMP\test.xlsx"
rm $xlfile -ErrorAction SilentlyContinue

$data = ConvertFrom-Csv @"
Region,Item,TotalSold
East,screws,55
East,avocado,57
North,pear,29
North,lime,71
West,avocado,25
South,melon,100
East,peach,61
East,pear,67
North,orange,1
North,screwdriver,76
"@

$xl = Export-Excel -InputObject $data -Path $xlfile -PassThru -PivotData @{TotalSold='sum'} -PivotRows Region -Activate

Close-ExcelPackage $xl -Show


Unclear return behavior for getProperty

Steps to reproduce
N/A

Puppeteer version: 10.0.0 (but seems true for 10.2.0 also)
Platform / OS version: Ubuntu 20.04
URLs (if applicable): N/A
Node.js version: 14.17 LTS

What steps will reproduce the problem?
The puppeteer docs website says getProperty on a JSHandle returns a promise that will resolve to another JSHandle
Same is true for the markdown docs in the repo here
The function definition here however indicates it may also return undefined.
What is the expected result?
It should be consistent across the docs and the implementation
What happens instead?
It isn't
I don't think im missing anyting obvious, is this is a typo / bug / known inconsistency?

@ckcr4lyf Thanks for your bug report! Not sure what's going on here but I'm happy to look into it!


Fix circle CI build failing at install chromedriver step

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

For more info refer: https://github.com/CircleCI-Public/browser-tools-orb/issues/75

browser-tools have fixed this issue in the latest release.


Block auto-disarm when in Launch Detection for Catapault/Hand-Launched FW

Describe problem solved by the proposed pull request
Hand launched Fixed-Wings are unable to use auto-disarm due to it being based of the Land-Detector. Because the Launch-Detection is less sensitive to "Non-Landed" States than the Land-Detector, this will often lead to a situation where the motor is not spinning and the vehicle transitions from landed to non-landed and then back to landed, triggering the auto disarm. This occurs during ground handling after the vehicle is armed. Currently we leave auto-disarm disabled.
Test data / coverage
This has been tested in a lab on a pixracer flight controller mounted on a fixed wing vehicle while spoofing GPS. https://review.px4.io/plot_app?log=e6249163-72e1-4ae6-9aa0-b56c947659de
Describe your preferred solution
This issue is solved by having the Fixedwing Position Controller set a message on the position_controller_status uORB struct determining whether or not Launch-Detection is running. This message is then subscribed to by the commander, which then blocks all auto-disarming if it is running(true).
Describe possible alternatives
There was talk about using a variable already declared for this, but that is based off of Land-Detector which this is circumventing.
Additional context
Discussed in this weeks dev-call.
FYI @Antiheavy

FYI/A @MaEtUgR , we discussed this during the Dev call.  This PR helps make life easier for hand-launched fixed wings, now that auto-disarm is enabled by default: https://github.com/PX4/Firmware/pull/12346

Re-based and implemented the suggested improvements. @MaEtUgR can you review it again?

We have tested this branch on the ground.  We also have been extensively flight testing a slightly different version of this (built on v1.8.0) for the past month.  It works quite well.

@Kjkinney Could you please resolve the conflict so that we can merge it?

Moving to new PR


Fixed ammo on playerstart target_give

playerstart is referencing the default ammo count code using the momentum equivalent ammo/weapon names, so I've added a case for those too.

What map is this an issue on? I suspect that this is only happening because GetGiveTargets is not finding linked targets recursively.

Line 349 says otherwise


Remove unnecessary autopilot config

This PR removes the current period and the allow redundant IP config.
@ChrisSchinnerl this is where I would draw the line as far as removing contract sets goes, there are outstanding tasks in the issue referenced below but I feel tackling all of those would bloat the feature branch too much
Relates to https://github.com/SiaFoundation/renterd/issues/1667

Lgtm but it seems like this PR is targeting a branch that doesn't have an open PR anymore? Might need to be retargeted if true before merging.

This merges into removal of contract sets. Now that the UI is merged I kind of want to merge everything into the base branch and go from there. It's at a point where it's technically good enough to be merged into dev I feel. The small design decisions I made that we potentially want to revert can be done in the base branch. Especially since the UI got merged I want to consolidate into a single branch and play-test the whole feature in a single PR because of the many migrations.


CI: Widen Actions version requirements

This avoids version bumps for every minor update.

Thank you, good idea!
bors r+


Here's what I'd like to see / collaborate on

Okay, so I'm a little bit of a freak when it comes to my servers, and I tend to compile everything myself to ensure the latest features & what have you.
I tried and failed recently to do kubernetes on Arch linux, but I'd love to try again with a hand from none other than @errordeveloper (or with his discouragement re:arch, chase coreos's alpha build and figure out how to get weave running in cloud-config as a Docker plugin and then kubernetes also using weave as a plugin and finally, scope to show pretty pictures of it all!)
Or.... any general guidance will do nicely.
Thanks!
-Jake

@faddat that's very interesting indeed! Sorry that I've missed this post... If you would like to use Weave Docker plugin, you should check status of Kubernetes plugin support first, i.e. whether it handles multiple IP addresses or not. Please hit me up on IRC or Slack, if you want to go through this in real time :+1:


[QUESTION] Logging the details of call to downstream services

Question
Hi,
We are interested in logging all the requests that Zuul does to all downstream services. We are also interested in that log follows a particular format and its impact in performance is minimum.
We have seen a class TraceProxyRequestHelper that does something that we are interested in but we dont know to how to change its behavior. An additonal question is if that class is the one that we should care about.
Please could  anybody help on this?
Regards

You can extend the class.  But since its not conditionally created you would likely have to mark your instance as @Primary.

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.


std.file: Posix readImpl: An internal check of correctness.

The last two lines of the loop:
immutable newAlloc = size + sizeIncrement;
result = GC.realloc(result.ptr, newAlloc.get, GC.BlkAttr.NO_SCAN)[0 .. newAlloc.get];

should only be executed when "size == result.length", not generally when "size >= length", though the "if" condition immediately above may indicate the general case.
The "size > result.length" case can never happen. If it does, we have an internal bug (or there is a bug in the implementation of the POSIX read function).
However, this is not obvious without looking attentively at the code (this is subjective--it might simply mean that I am slow).
I wish to suggest that we clarify by a comment/assertion/always-enabled-assertion. Currently, by an assertion.

ping @DoctorNoobingstoneIPresume

ping @DoctorNoobingstoneIPresume

I'm going to close this as there is not activity and the impact of the change is minimal.


Prepare PySpark 3 for dev purpose

I use the manual build version of PySpark for development. As of https://github.com/apache/spark/commit/ee8d66105885929ac0c0c087843d70bf32de31a1, we need some changes accordingly.

Codecov Report

Merging #1181 into master will decrease coverage by 1.64%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   95.28%   93.63%   -1.65%
==========================================
  Files          35       35
  Lines        7084     7105      +21
==========================================
- Hits         6750     6653      -97
- Misses        334      452     +118

Impacted Files
Coverage Δ

databricks/koalas/internal.py
95.74% <60%> (-0.77%)
:arrow_down:

databricks/koalas/typedef.py
82.92% <71.42%> (-0.83%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
24.32% <0%> (-72.98%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
76.59% <0%> (-8.52%)
:arrow_down:

databricks/conftest.py
92% <0%> (-6%)
:arrow_down:

databricks/koalas/frame.py
96.44% <0%> (-0.57%)
:arrow_down:

databricks/koalas/generic.py
95.85% <0%> (-0.42%)
:arrow_down:

databricks/koalas/plot.py
94.04% <0%> (-0.24%)
:arrow_down:

databricks/koalas/groupby.py
91.4% <0%> (-0.2%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c2214...f7138f2. Read the comment docs.

I'm merging this for my dev :-).


Kidding. I figured out I "Start Game".

real :trollface:


Revert dont-ask-if-flag-set

#800 introduced a bug in all instances of check_config where subtensor.network was consistently recognized as None which prevented any scripts from running. This PR reverts the breaking changes.

Pull Request Test Coverage Report for Build 2bee7247-adf6-48c4-8993-2e7fc7ebe998

75 of 75 (100.0%)  changed or added relevant lines in 9 files are covered.
7 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.09%) to 81.618%

Files with Coverage Reduction
New Missed Lines
%

bittensor/_dendrite/init.py
1
85.0%

bittensor/_logging/init.py
1
69.95%

bittensor/_threadpool/priority_thread_pool_impl.py
1
74.63%

bittensor/_dataset/dataset_impl.py
2
89.75%

bittensor/_receptor/receptor_impl.py
2
90.71%

Totals

Change from base Build 9ac5ecae-79f5-4831-8612-ce91f8a624c3:
0.09%

Covered Lines:
4178

Relevant Lines:
5119

💛  - Coveralls


Lazy Loading Support

Wanted to ask if Alasql supports lazy loading, and if it doesn't discuss how it could be implemented.
This is because sometimes you may have a very large dataset that exists out of memory or you cannot send all of it the frontend for querying.
So if there was a way to create a table that had custom defined hooks where you can send AJAX queries to the backend to fetch more data to fill the table, then this would allow one to lazy load an alasql table, which would mean you could run sql queries in the browser on datasets that are actually stored on the backend.

There is no support for lazy load at the moment.

This is because sometimes you may have a very large dataset that exists out of memory or you cannot send all of it the frontend for querying.

I must admit that is sounds like a challenge that should be solved in a traditional way, fetching the real response at the host (so avoiding alasql totally)
I have had situations where the raw data was too big, but I then made a mix where the initial data was aggregated (into days instead of minutes) - and then having other aggregations in other datasets.
So getting the aggregated data from the host but using alasql to filter became my solution.
Please describe your challenge further so we can all contribute to a good solution.


influxdb errors when trying to parse some state attributes

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.47.0
Python release (python3 --version):
Python 3.5.2
Component/platform:
influxdb
Description of problem:
In the last update of the influxdb component a change was introduced to parse float attributes with attached units, but now this causes an error with state attributes like the one shown below.
From a custom component (which is a homemade current meter), the entity state is:
sensor.enerpi:
  state: active
  attributes:
    Consumption Week (kWh): 8.5,8.1,9.6,8.9,9.6,9.3,3.5
    Power 1min (W): 316
    friendly_name: Power State
    Power Peak (today): 353
    Last Main Power (W): 316
    Power 5min (W): 314
    last_update: 2017-06-18 11:08:42.06
    LDR: 39
    icon: mdi:flash
    Consumption Day (Wh): 3464.872

The attribute that is failing is Consumption Week (kWh), which is 8.5,8.1,9.6,8.9,9.6,9.3,3.5 and can't be parsed to float.
Expected:
To be optional, and handle the ValueError silently when parsing doesn't work for the attribute.
Problem-relevant configuration.yaml entries and steps to reproduce:
influxdb:
host: !secret influxdb_host
  port: !secret influxdb_port
  database: !secret influxdb_db
  username: !secret influxdb_user
  password: !secret influxdb_pass
  default_measurement: state
  include:
    entities:
      # ...
     - sensor.enerpi
      # ...

Traceback (if applicable):
2017-06-18 10:08:13 ERROR (Thread-3) [homeassistant.core] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
  File "/home/homeassistant/.pyenv/versions/3.5.2/envs/hass35/lib/python3.5/site-packages/homeassistant/components/influxdb.py", line 164, in influx_event_listener
    json_body[0]['fields'][key] = float(value)
ValueError: could not convert string to float: '8.5,8.1,9.6,8.9,9.6,9.3,3.0'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/homeassistant/.pyenv/versions/3.5.2/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/homeassistant/.pyenv/versions/3.5.2/envs/hass35/lib/python3.5/site-packages/homeassistant/components/influxdb.py", line 170, in influx_event_listener
    non_decimal.sub('', value))
ValueError: could not convert string to float: '<IP_ADDRESS>.<IP_ADDRESS>'

Additional info:

Sorry, I didn't see #8042, which is related to this.
@philhawthorne, I will try the patch in #8080 and comment about

Fixed in #8080


Cannot search with symbol chat widget

Unable to search when writing formatted text in the text generator, not sure why but it just won't let me search for stuff.

Same with the image text generator

Fixed in https://github.com/Zailer43/FZMM-Mod/commit/61df86bd3507c16e4d39ec2c6ba3e781a003ceb5


Update on documentation maybe?

Hey there, first time trying out mongoid_spacial... :)
I think would be nice to have an update on documentation just noticing that you should run rake db:mongoid:create_indexes once you setup your models...
Just to reduce tracking time when the error Mongo::OperationFailure: can't find special index: 2d for happens
Can I send a pull request on that?
Cheers :D

Feel free to write a pull request I would accept the help gladly

done :)


In IE 10 & above browser, PDF file downloading issue

In IE 10 & above the PDF file is downloads, but (Ex:- Out of 14 pages data only 11 pages are downloaded and in that 5 pages  data are visible and remaining pages visible black screen )

Hi,  I am giving more information about the above issue-
Using script files :- jquery-1.12.3.min.js, jspdf/1.3.4/jspdf.min.js, html2canvas/0.4.1/html2canvas.min.js
Code  calling in button click-
var pdf = new jsPDF("p","pt","letter");
pdf.internal.scaleFactor = 2.00;
var options = {pagesplit: true};
pdf.addHTML(document.body,options,function() { // here reading the entire body content
pdf.save("HTMLTOPDFFILE.pdf"); //This will output the PDF in a new window
});
By using this code, it's well in chrome & Mozilla browsers where as in IE browser 10 & above its behave differently, show limited pages are downloading & unable to view all data after certain limit (ex; 5 pages) remaining with black screen.
For your reference, adding sample screen

Thanks, have a great day. Any help is appreciated to resolve the above issue.

Hi, the black bar issue is definitely a result of not using the version of html2canvas in the vendor/ folder. More info here.

Hi ekoopmans, while using this link **https://jsfiddle.net/o0kL8zkk**/  and add my script, css then in IE the below error throws

Please check it. iam waiting for your response.

You've got two open issues, I've responded to your issue regarding promises already here. You need to include a Promise polyfill.

Good morning, the above issue is resolved but the data is not splitting what the user accepts. below the sample screen shot-

Note:- same issue for image also.
Any help is appreciated.

Take a look at this issue for more info on that problem. You can use

Hi, I used page breaks for page splitting. but the data in page is getting dynamically. so, we don't know how much data is getting while generating PDF. The Text or images breaks in middle.


Added support for parameters

Added support for parameters specified in https://developer.forecast.io/docs/v2#options

Good idea. We shouldn't be putting required parameters after optional ones though. Think you could revise your code to have array $parameters = null
Also it looks like your tabbing is off and the code is misaligned.

Thanks for the quick response. I've fixed both issues in commits 4ac1d4d and 7e075df.

cool. I'll probably go through and replace all the indenting with spaces just before I make the next release

Applied auto formatting in 192b5a3, should be good to go I think

@Baabah awesome thanks for going ahead and doing the auto formatting!


changed authorization attribute

ARUHA-2132
Description
Added more parameters to authorization attribute
Review

[ ] Tests
[ ] Documentation
[ ] CHANGELOG

Looking good 👍
Please, address minor comments so we can merge it.

👍


[Linting & Validation] Error notification for inline lg should navigate to form instead of all up view

If there is an error in an .lg template, the notifications/linking heuristic should be:

if if the error is in an inline lg template, link to the form
if the error is a custom crafted lg template, link to the .lg file

If there is an error in an .lg template, the notifications/linking heuristic should be:

if if the error is in an inline lg template, link to the form
I guess we can treat naming-format is bfd[type]-[id] is an inline lg template.

if the error is a custom crafted lg template, link to the .lg file

By the way, because of our inline editing experience is based on template, can lgParser diagnostic provide a property indicate error belong to which template, or a template level diagnostic ? @Danieladu @boydc2014
if not we have to repeat write code like this in several place.
// filter diagnostics belong to this template.
      lgDiagnostics = checkText(text).filter(lgDialg => {
        return (
          lgDialg.range.start.line >= template.startLineNumber &&
          lgDialg.range.end.line <= template.endLineNumber
        );
      });

addressed via https://github.com/microsoft/BotFramework-Composer/pull/1856


adding custom style suppot for td

To add custom styles at run-time in Cell component. With this we can change border color, width etc.

@prpateldev  published :) Please try 0.2.2


fish init file uses unsupported and syntax

Output
Opening a new terminal:
~/.phpbrew/phpbrew.fish (line 413): Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
    __phpbrew_update_config $argv && __phpbrew_set_path
                                   ^
from sourcing file ~/.phpbrew/phpbrew.fish
	called on line 17 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
	called during startup

source: Error while reading file “~/.phpbrew/phpbrew.fish”

Sourcing the file by hand (source ~/.phpbrew/phpbrew.fish):
~/.phpbrew/phpbrew.fish (line 413): Unsupported use of '&&'. In fish, please use 'COMMAND; and COMMAND'.
    __phpbrew_update_config $argv && __phpbrew_set_path
                                   ^
from sourcing file ~/.phpbrew/phpbrew.fish
	called on standard input

source: Error while reading file “~/.phpbrew/phpbrew.fish”

Expected Result

no output when opening a new shell
no errors when sourcing the phpbrew.fish file from within fish

Command
source ~/.phpbrew/phpbrew.fish --debug
Platform
OS: Ubuntu 18.04.5 LTS
Running PHP:
PHP 7.2.24-0ubuntu<IP_ADDRESS> (cli) (built: Jul  5 2021 17:41:32) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.24-0ubuntu<IP_ADDRESS>, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.9.4, Copyright (c) 2002-2020, by Derick Rethans

phpbrew:
phpbrew - 1.27.0
cliframework core: 2.5.4

fish: version 2.7.1

I guess this issue can be closed as outdated.
fish supports && starting from version 3 - https://github.com/fish-shell/fish-shell/issues/4620

Whoa, completely forgot about this issue (I've been using so much docker that I don't use phpbrew anymore). And now I'm wondering why I didn't just opened a PR...

I'm going to close the issue because it's outdated and it's fixed in the Fish 3 version.


TD3

Ready for review - reproducing paper
Note: Slight renaming of the noise_percentage_schedule parameter resulted in some changes in unrelated files.
Also, some small fixes to DDPG.

Comparison of TD3 (called FixedCriticInputBugAndBootstrapBug) to DDPG (no batchnorm)
The TD3 implementation in this repo significantly outperforms the paper published results.
Hopper

Walker2D

Reacher

Half Cheetah

Ant


Put the AvailabilityContext into the ExportContext

Let's put OS version information into the ExportContext, so that we only have to perform the source location lookup once.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - f3cbef87d90531243405227be5e1cf1b83cf237c

Build failed
Swift Test OS X Platform
Git Sha - f3cbef87d90531243405227be5e1cf1b83cf237c

@swift-ci Please smoke test

@swift-ci Please smoke test


Update README.md with table of contents

@sarthakvijayvergiya @mrhouzlane I incorporated the changes from Sarthak's branch over the merged one from yours, Mehdi, I think this captures the key changes from both.


TPF Factory has real value defaults

Problem description

When we create a TPF using the TPFFactory, the template file has default values for e.g. column, row, the WCS. This means that any file created with the factory has these values set.
Example

e.g. Here is a new asteroid TPF, which has a wrong column and row number from being created with the TPF factory.

Expected behavior

There shouldn't be any defaults in the template file.

Issue should have been fixed as part of #243.  Closing!


password not configurable for SshWanDetect?

seems in /tests/ssh_forward_port.py, the password(for WAN ssh connect to DUT) was hard coded as "password"?
sp = lib.common.spawn_ssh_pexpect(ipaddr, "root",
               "password", prompt="root@OpenWrt", port=port, via=wan)

You can change the word "password" to anything you want.  You have the source code :)
Here's an outline of how one could create a new configuration parameter:

Add a line to config.py like: default_vm_password = "password"
Change tests/ssh_foward_port.py to:

sp = lib.common.spawn_ssh_pexpect(ipaddr, "root",
               self.config.default_vm_password, prompt="root@OpenWrt", port=port, via=wan)

I think that might work, but someone should give it a try - and submit a code change for review.  I could see that being useful.

There are also dynamic devices now and you can add as many as you want to the boardfarm config, the password is saved so you could add your own new device you want to ssh (or re-use one that is there) and the password is moved from the config file to the device class. Look at commit aacff18abbd348a3987a1ec08360a202b16e9195 for more details.


Importing Button via '@material-ui/core'  causes style anomalies.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
On some components within our code base we've been having these odd style issues where things don't look the same as on other pages
Imagine this layout
<Navbar />
 <Switch>
  <Route  component={LocationSelect}/>  // import { Button } from '@material-ui/core';
  <Route  component={Menu} /> // import Button from '@material-ui/core/Button';
</Switch>

Navbar has a hamburger Button that open up a MUI Swipeable Drawer.
When the drawer is opened when viewing LocationSelect Route

When the drawer is opened when viewing Menu Route

It seems that when we modify the way we import the Button it can break some of the overall styles, resulting in some funky looking UI. To be clear... the styles within the context of the Menu Route are the correct ones. The issues aren't limited to just the Drawer, as other component also showed some style irregularities.
We are using babel plugin import to help reduce the MUI bundle (might be relevant)
  plugins: [
    'styled-components',
    '@babel/plugin-proposal-class-properties',
    '@babel/plugin-syntax-dynamic-import',
    [
      'babel-plugin-import',
      {
        libraryName: '@material-ui/core',
        libraryDirectory: 'esm',
        camel2DashComponentName: false,
      },
      'core',
    ],
    [
      'babel-plugin-import',
      {
        libraryName: '@material-ui/icons',
        libraryDirectory: 'esm',
        camel2DashComponentName: false,
      },
      'icons',
    ],
  ],

Probably not an urgent issue per se... as we are able to work around it with the imports... but I believe there might be an issue with the way the MUI Button gets exported, as its causing the issues mentioned above.

Tech
Version

Material-UI
4.7.2

React
16.12.0

Browser
Chrome , Safari

TypeScript
No

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


Slurm collector: Comment JSON parsing

Codecov Report

Merging #211 (f6fee8c) into main (592c4c0) will decrease coverage by 0.11%.
The diff coverage is 31.14%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   45.33%   45.22%   -0.11%
==========================================
  Files          40       40
  Lines        2539     2596      +57
==========================================
+ Hits         1151     1174      +23
- Misses       1388     1422      +34

Impacted Files
Coverage Δ

collectors/slurm/src/sacctcaller.rs
0.00% <0.00%> (ø)

collectors/slurm/src/configuration.rs
11.05% <48.71%> (+11.05%)
:arrow_up:

auditor/src/domain/score.rs
60.44% <0.00%> (-0.75%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Updating Archiver Package Allows for Working Tars

Problem:

Building COINSTAC on Macs produces a broken tar archive.

Solution:

Update the archiver library to version 2.0.0.

Tests:

npm run build in base directory
npm run build in coinstac-ui directory
Decompress /packages/coinstac-ui/coinstac-darwin-x64.tar.gz and run the enclosed application.

macOS looks good. I’ll check out Windows.

Works on Windows 10. Not going to bother with Windows 7.


Issue #910 - Require Python 3.9 (for alignment with Qpid Proton Python)

This is the first part, changing Python version in Fedora, CentOS and Ubuntu CI jobs. I will address the RPM and Container jobs later.
Closes #910

Codecov Report
Base: 27.51% // Head: 27.51% // No change to project coverage :thumbsup:

Coverage data is based on head (ca9a418) compared to base (01bd599).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #911   +/-   ##
=======================================
  Coverage   27.51%   27.51%
=======================================
  Files         136      136
  Lines       32575    32575
  Branches     5222     5222
=======================================
  Hits         8962     8962
  Misses      22463    22463
  Partials     1150     1150

Flag
Coverage Δ

unittests
27.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Skip the flaky test TestAppDomainProcessExitEvenHandlerNotLeaking for now

PR Summary
The test TestAppDomainProcessExitEvenHandlerNotLeaking is still failing intermittently.
Disable it for now to unblock CIs, and I will look into how to fix it.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

I'm merging this PR to unblock CI runs.


docs: Update migrating.md with pagination

Updating migration doc with pagination information

closing due to merge conflicts, but open to adding more info on the pagination feature differences in the migration guide.


Missed "period" at the end of one sentence.

Describe the bug
You can get the source code of the example from here
Reproduction steps
You can get the source code of the example from here**.**
Expected behavior
You can get the source code of the example from here**.**
Additional context
No response

Could you please be a little bit more specific here? For example, in which section? (I found this sentence in "Advanced Features -> Bitfusion" section, but there is a period there. I am not sure if that is the sentence you were specifying. If so, this problem might have been already fixed. Otherwise, could you please specify the section of this issue?)

Describe the bug
You can get the source code of the example from here
Reproduction steps
You can get the source code of the example from here**.**
Expected behavior
You can get the source code of the example from here**.**
---Original---
From: @.>
Date: Thu, Mar 9, 2023 21:29 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [vmware/ml-ops-platform-for-vsphere] Missed "period" at the endof one sentence. (Issue #42)
Could you please be a little bit more specific here? For example, in which section? (I found this sentence in "Advanced Features -> Bitfusion" section, but there is a period there. I am not sure if that is the sentence you were specifying. If so, this problem might have been already fixed. Otherwise, could you please specify the section of this issue?)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[Sigmastar] Add initial support for infinity6e platform

Here is an initial implementation for the infinity6e platform, currently intended to work with the CamHi SSC338Q module.
The goal is to have it fully working from the sdcard without ever modifying the internal nand:
The user creates a FAT32 partition and copies UBOOT, uImage.ssc338q and rootfs.squashfs.ssc338q, the device boots and provides an accespoint to enter the setup.
#671 Adds an initial initramfs to load the actual rootfs from the sdcard, it then proceeds with switch_root to the new rootfs.
The initial initramfs doesn't allow pivot_root to change to the overlayfs, that is why this additional initramfs was added.
However, there might be a better solution to save changes/settings without relying on overlayfs.
#670 Adds automatic accesspoint functionality to have the device acessible without needing uart/ethernet.
A current drawback is the manual saving process by entering 'savesettings', it takes a copy of /overlay/root and move it to the sdcard. This copy will be restored before overlayfs is mounted.

Thank you very much for the final PR and explanations after communication in person.
After checking the CI, I'll be sure to do a merge.


free_subnet: simplify loop to detect overlapping subnet

don't need a flag when we use a for/break/else

Coverage remained the same at 100.0% when pulling 1c8ced95f98e0858beaab768eeac9166f04f9cf9 on free_subnet into 648c05d45035d562f4302495fb9aa74d4ae26e46 on master.


feat: Update OperatePage FAQ link to Docker Desktop 2.6.1

Let's hold off on this @mohandast52 – it seems like shifting to 2.6.1 doesn't actually resolve the issue.


Add includeOne method

An ability to check passwords for the new metric – including at least one element from provided set.
if any other changes for this functionality needed - let me know.

@nut4k1
Good, Should we have excludeAll(['A','B','C'])? just include/exclude pair? (IncludeOne/ExcludeAll)

3.6.0 released. well done ;)


Explorer resize divider needs styling

There is a specific style for resizable dividers, it should be set for the Explorer divider as well, at least for mobile, where there are no mouseovers.

Also make it work on mobile.

Implemented in v2.3.57


prefetch plugin tests fail on ubuntu 22

prefetch_bignum, prefetch_overlow and prefetch_simple fail on ubuntu 22 with the error that traffic_server's return code is -2 instead of 0.  It appears that the rest of the test passes and we are failing as the traffic_server process is shutting down.  I cannot reproduce this exit state with replay files and traffic_server running in gdb.
Hopefully someone with more expertise in the autest framework can take a look at this.

 Test : Checking that ReturnCode == 0 - ^[[0m^[[31mFailed^[[0m^[[1m

    Reason: Returned Value -2 != 0

strategies_ch also fails with the same error,

Looking into this some more, I came across the following reference
https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess.returncode
This implies that a return code of -2 as identified by python could mean that traffic_server shutdown as the result of a SIGINT (2).  @dragon512 said that the autest infrastructure would first try to send a SIGINT and then a SIGTERM to shutdown traffic_server.
Perhaps the issue is the different versions of python handle this differently.  In that case -2 should be an allowable return value.  Although I am unclear on how you specify allowable exit codes for the traffic_server process in autest.
In my dev box, I'm running the following python

$ python3 --version
Python 3.10.12


python2 assumed when python is in path, fails with miniconda3

In moltemplate.sh:
if which python > /dev/null; then
    PYTHON_COMMAND='python2'
elif which python3 > /dev/null; then
    PYTHON_COMMAND='python3'
else
    echo "Error:  $G_PROGRAM_NAME requires python or python3" >&2
    exit 1
fi

This fails when conda is activated and 'python' leads to python 3+.
If I knew bash well enough I would fix this to check the version with 'python -v'

Hi Lunar
This is distressing.  I switched the default interpreter to python2 to get around a nasty bug which only occurs using python3 (when not in debug mode).  (a "Hiesenbug").  Switching to python2 isn't really a solution either (since most people use python3).  But I will fix your problem today.  (I'll worry about this other bug later.)

I just posted an update to moltemplate that includes an attempt to fix the bug you reported.
Please try it and let me know if it resolves the issue.
-Andrew

Hi Andrew
e619a8d3fefb199d8516dd3a76fe7172d07286cb fixes it, thanks!


Link back to the Axis Design Sprint Repo

Also link to presentations such as the 8 design principles and Liza's visual design principles


Classifing commits

Hello,
For classifying commits I need a good amount of labeled commits, and as I understand there are no labels for the DRR commits (except for the tool in the name), so how should I go about it? Thanks. @monperrus

indeed, the tool name is the label.

but what about the other possibilities? So I just know one of the possible labels.

yes, this is the only ground truth we have.
maybe some patches are identical, which means that they can be merged with multiple labels.

still, the amount of data in each repair tool is small, for example, there are thirteen file-pairs for Arja, I don't think the results of SVM would be reliable in such a case. Am I right? @monperrus

should I predict whether a commit can be generated by a specific repair tool or not, or can it be generated by any repair tool or not? @monperrus

In more details, now I have generated features for all the commits in the DRR correct folder.
So, now I have to fill in a binary table (0,1) with rows corresponding to the commits and the columns corresponding to the repair tools in order to do the ML phase.
My question is that How I should fill in this table?
I can fill the spots where the name of the repair tool is in the file and the identical files, but what about the rest of the table ? should I use the results from the coming project? @monperrus

should I predict whether a commit can be generated by a specific repair tool or not

yes, and we would have N classifers where n is the number of repair tools

We'll use the RepairThemAll data once the pipeline is running.


x/tools/go/packages: can't distinguish generated sources from user-provided ones

When using go list -test, we can distinguish user-provided sources from generated ones based on whether the paths are absolute, as documented here (emphasis mine):

By default, the lists GoFiles, CgoFiles, and so on hold names of files in Dir (that is, paths relative to Dir, not absolute paths). The generated files added when using the -compiled and -test flags are absolute paths referring to cached copies of generated Go source files. Although they are Go source files, the paths may not end in ".go".

Unfortunately, golang.org/x/tools/go/packages removes that distinction by making all of the GoFiles it returns absolute, without apparently preserving enough information to undo that transformation. That makes it very difficult to use go/packages to write tools that transform or otherwise refactor user-provided source code, such as the one in CL 137076.
CC @matloob @alandonovan @ianthehat @rsc

The assumption "absolute <=> generated" doesn't hold for other build systems such as Bazel, in which a package may contain a mixture of sources from different directories. Indeed, it doesn't even hold for go list in the presence of modules, since source files may reside in the module cache.
The go/packages API could in principle record which files are generated (and at one point it did), but we removed on the grounds that refactoring tools should decide which files to edit based on the "DO NOT EDIT" comment convention proposed in github.com/golang/go/issues/13560.

The DO NOT EDIT convention relies on three assumptions:

Generated code is not checked in to the repository.
Users never want refactoring tools to apply even trivial edits to files that say DO NOT EDIT.
All generated files actually follow the convention.

I don't know about (3), but I do not believe that (1) or (2) holds outside of Blaze/Bazel.

In particular, you could imagine a workflow that goes:

Refactor the code using some tool, including arbitrary package moves.
Re-run the generators for all generated files that were touched.

Step 1 should not require additional intervention to prune or exclude generated files, since they may be needed to type-check packages at any intermediate state.


[FEATURE] memory metrics

I am working on new ensemble model but I would like to compare its performance against other models. It is somehow possible to get memory consumption metrics per model when evaluate models ?
It could be just text info like running_time is.

Yes, there is.
If you are using an Evaluator you just need to include model_size in the list passed to the metrics option.
Otherwise, you can use the following method:
from skmultiflow.utils import calculate_object_size

Thank you, it is working.
But I can't find info about output value. It is averaged size or computed in each period ?

In the evaluator, it is the current model size measured every n_wait samples.


tolua for arm64 have problem bytecode

I add tolua for android 64bit, but when i run app in mobile, it can't load lua
E/Unity: LuaException: tolua.lua: cannot load incompatible bytecode
(Filename: currently not available on il2cpp Line: -1)
E/Unity: LuaException: Lua table UpdateBeat not exists

u should compile 64bit bytecode and 32bit bytecode when your apps used both armv7 and arm64 architecture


Update site-wide settings

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (aca43ea) compared to base (b139b23).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


tf.keras.callbacks.ModelCheckpoint: initial_value_threshold not working, definition with a mistake

Click to expand!
Issue Type
Documentation Bug
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
'2.3.0'
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
The manual defines initial_value_threshold as
"Floating point initial "best" value of the metric to be monitored. Only applies if save_best_value=True. Only overwrites the model weights already saved if the performance of current model is better than this value. "

save_best_value is not defined!

If  save_best_only was meant, then it is not working like the manual says.
I have no other idea, how should I get initial_value_threshold work, it is still starting with -inf.

Standalone code to reproduce the issue
es = EarlyStopping(monitor='val_loss', verbose=1, patience=20)
tmpmodelfile = 'models/' + model_config_name + '/temp1_best_model.h5'

evaluation = model.evaluate(vd[feature_cols], vd[target],
                            batch_size=batch_size, verbose=2,
                            return_dict=True)
#3231/3231 - 2s - loss: 0.0500 - mean_squared_error: 0.0500
mc = ModelCheckpoint(tmpmodelfile, monitor='val_loss',
                     verbose=1, save_best_only=True,
                     initial_value_threshold=evaluation['loss'],
                     save_best_value=True)
history = model.fit(td[feature_cols], td[target],
                    validation_data=(vd[feature_cols], vd[target]),
                    batch_size=batch_size, epochs=epochs,
                    verbose=2, callbacks=[es, mc])
Epoch 1/400
Epoch 00001: val_loss improved from inf to 0.04999, saving model to models

Relevant log output
No response

@agoeroeg Thanks for reporting the issue.
I tried to replicate the issue in TF v2.3 and and in the latest TF v2.11 using a simple MNIST convnet .
I have observed the reported behaviour in TF 2.3 where as in TF 2.11 I was able to get the initial_value_threshold work with the given value.
Please find the gist of TF 2.3 here and gist of TF 2.11 here and let us know if it helps. Thanks!