Doesn't find all forks

This is a great tool. However, does it actually list all forks? I went to: http://forked.yannick.io/dfabulich/choicescript
I noticed I am not in the list: https://github.com/Flurrywinde/choicescript
Also, recently I saw another fork made an update, but that fork was also not in this list: https://github.com/ldarren/choicescript/commits/master

While I can't comment for certain (as I don't have much experience with Ruby/Octokit) I have a pretty good idea of why this is. Typically, when using the Github REST API, sending a GET request to api.github.com/repos/:user/:repo/forks returns the first 30 forked repositories. That's what we're seeing here.
It is possible to get all of the forks - at least using traditional means such as curl, you simply send a GET request to api.github.com/repos/:user/:repo/forks?page=2 or whichever "page" (ie group of 30 repos) you want. I'd assume Octokit has some feature to allow this...?
Here's the issue: the github API limits you to 5,000 requests per hour (at least, for OAuth apps - it could be even fewer) and each "page" you request counts against this. The API doesn't state any way to simply request all pages . . . trying to get each of these pages individually would totally break functionality. Take this example: let's say a user requested all of the forks of twbs/bootstrap - this repository has over 50,000 forks, which would require well over 1,500 calls to the github API to list all of them. A few of these and the service is unusable for all users for the remainder of the hour.
The only option here is to ditch the REST API and use the v4 API - again, I don't really have any experience with it, so it may also limit API calls (though it's designed to be more flexible in the data requested, so I'd be surprised if you couldn't get all forks at once). Plus, I have no idea if Octokit supports using the v4 API so it might require a total overhaul of the code base.


[Question] How much performance difference will servo engine make compared to gecko and blink web engines?

Curious to know about it because i know verso will launch pretty late and who knows if there are some minor differences or no differences then do you think people will give verso a try?

The performance of servo in comparison to mainstream should be very significant: https://youtu.be/u0hYIRQRiws

I tested ares-6 and jetstream2 before. The results are decent. We are also trying to run speedometer3 from Servo, but there's still some blockers we are trying to resolve.

nice hope to get best possible foss browser in future
Thanks for your hardwork devs :-))


Some suggestions on how to make it async

Makes all registerNativeModules<platform> async, which allows us to:

lazily pool for params
add a nice catch for uncaught exceptions (this is a straight copy from #56)
fixes registerNativeModuleAndroid return value (this is #62)
promiseWaterfall resolves with an array of all tasks results instead of the last one
linkAssets happens at the end now (previously undefined order because of Promise.all)
instead of Promise.all(promiseWaterfall(deps), linkAssets) we now have a flatMap and use promiseWaterfall only once.

Also @Kureev - params do not work on patches lower than 0.20 (probably because we do not find & replace them). Not sure if something we need to do though.

I am going to close this one and send yet another one to filter const dependencies with extracted isInstalled check.

Diff has been cleaned up. For now registerDependencyIOS does not return a promise because we do not poll for params yet - this can be easily added in next release.
registerDependencyAndroid is now async, because when dependency is not yet linked, we will poll for params from inside it.

Since we now check for isInstalled before, that leads to better messages:

Everything works, also extra tests were added.

In next PR I would like to extract isInstalled checks from unregisterNativeModule.

Commits fixing unlink (Android) were reverted because @Kureev is working on Android at the same time - feel free to take inspiration from them. Definitely needs to be fixed before we ship next release.

LGTM from @Kureev via FB.


Get coordinate values of both bounds and safe area

Add coordinate values of both bounds and safe area to LayoutControlParameter struct
Usage:
{ $0.safeVertical(at: 0.3) }
{ $0.boundsHorizontal(at: 0.75) }

Make LayoutControlHorizontalParameter, LayoutControlVerticalParameter, LayoutControlPointParameter for pinXxx methods.
In these parameters, only get desired parameters, e.g., in LayoutControlHorizontalParameter, only get things like .safeLeft, .boundLeft, .boundOriginalLeft, .boundSafeLeft but can not get things like .safeTop or safeWidth.


i18n(es): update cosmic

Description (required)
updates cosmic based on this commit d42c225b0071af2fe16d88d732a0a73d9c456b88

Related issues & labels (optional)

Closes # N/A
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

es
guides/cms/cosmic.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


⚠ Diverse AirCon & Mechanical has degraded performance

In be023a0, Diverse AirCon & Mechanical (https://diverseaircon.com.au) experienced degraded performance:

HTTP code: 200
Response time: 15477 ms

Resolved: Diverse AirCon & Mechanical performance has improved in a74e6a4 after 5 minutes.


Question: How to set curl options for HTTP from inside dmd?

alex.braunegg reported this on 2018-11-09T23:07:57Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=19385
Description
Hi,

In Curl 7.62.0, this now defaults to using HTTP 2.0 for connections where h2 is available, when build with h2 support.

Is there a way to set the libcurl options to force http 1.1 for all connections rather than using 'no flag' which lets libcurl choose the connection mechanism?

I have tried the following:

import std.net.curl;
http = HTTP();
http.handle.set(CurlOption.http_version,"v1_1");

However this generates the following error:

std.net.curl.CurlException@std/net/curl.d(4340): Unsupported protocol on handle 555E47E726A0

Can anyone advise how to set the curl options so that I can tell the library to only use http 1.1?

The issue I am trying to solve is - when DMD is using HTTP2 for file downloads, 'something' is happening when the file download is being completed which is causing an error - as the file 'disappears'. When downgrading the curl library to 7.61.0 (which does not enable http2 by default) there is no issue.

References:
https://dlang.org/library/etc/c/curl/curl_http_version.html
https://github.com/abraunegg/onedrive/issues/220
https://github.com/curl/curl/issues/3253

dfj1esp02 commented on 2018-11-12T13:14:11Z
See issue 19367 - until 8 november phobos didn't support http2, you're getting http status 0 and throw an exception for it, you also have a scope guard that deletes the file if exception is thrown, that exception is later caught and ignored, that's why you don't see anything happening. It's a good idea to log exception in its constructor - as soon as possible - this way you have little chance to ignore it, it's a life saver in remote debugging.


Add a css-transitions player

Hi,
I've been using your flip technique since the blog post, and I was a bit surprised that you didn't include a css-only solution in this library... So here it is !
I also had to move the easing configuration responsibility to the different players, since css does not support functions, obviously.
Cheers.

Ok @googlebot, I signed it...

You're welcome @googlebot !

Thanks very much! It's a great addition.
I do have some nits, so I'll step through and add them if you're willing to tweak as needed? TBH some of them are to map to the .eslintrc rules. I should add the tests in as per #1 so they get caught automatically.

I do have some nits, so I'll step through and add them if you're willing to tweak as needed?

No prob, go ahead !

TBH some of them are to map to the .eslintrc rules

Did my best to try to match the cs, but should be easier with an eslintrc

This is the one I used, btw:
{
    "root": true,
    "parser": "babel-eslint",
    "env": {
        "browser": true,
        "es6": true
    },
    "extends": "eslint:recommended",
    "rules": {
        "indent": [2, 2],
        "curly": [1, "multi", "consistent"],
        "quotes": [2, "single", "avoid-escape"],
        "linebreak-style": [2, "unix"],
        "semi": [2, "always"],
        "no-multi-spaces": 2,
        "space-before-function-paren": [2, "always"]
    }
}

I added the one I've been using to the repo, so we can standardize around that. I think we should add two of your rules: "semi": [2, "always"] and "quotes": [2, "single", "avoid-escape"] (I don't think I have avoid-escape set).
Do you fancy PR'ing that in, then checking this PR to see that it matches? Given #4 I guess some of the changes in this PR might be temporary, but as with that Issue I didn't want you to think I'd forgotten you ;)

@googlebot w4t?

@googlebot confirm!

@googlebot sudo confirm ?

@googlebot damnit!
Something got wierd with my rebase...

@paullewis Ok, squashed everything together ...

updates on this one?

@ju1ius I just tried to use the dist/flip.js file to test the performance benefit of the CSS player, but neither the default or CSS player seems to work.
Nothing seems to be standing out as the culprit in your changes, so I'm assuming that the dist file may not have built properly.
If anyone's interested, here's a comparison I made of a dropdown animation using a height transition in CSS versus FLIP:

The second animation (FLIP) seems to still have some frames dropping. Here's the culprit trace:

I was hoping to test the CSS player and see if it was more performant :(


Possible time drift

According to next lines, if device time drifts away from host time, then ROS frame timestamps will also drift, because software synchronization is done only once after the 1st frame retrieval.
https://github.com/intel-ros/realsense/blob/5210e673ec0d266c62590b433c8b568954f4fdfd/realsense2_camera/src/base_realsense_node.cpp#L543
https://github.com/intel-ros/realsense/blob/5210e673ec0d266c62590b433c8b568954f4fdfd/realsense2_camera/src/base_realsense_node.cpp#L550
The drift could be avoided if we had possibility to get current camera time.
Then we could compare it to frame timestamp and convert the latter to host time with the next formula:
frame_timestamp_host = current_timestamp_host - (current_timestamp_camera - frame_timestamp_camera)

[Please Ignore - RealSense system comment]


Sorting by datetime breaks ordering for dates before September 10th 2001

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
When you have collection items with the datetime field and you sort by that field in the UI and also using sort in the API client GraphQL connection, any collection item fields that have a date older than September 10th 2001, seem to get mistaken for being a more recent collection item in the sort order:
Posts sorted by releaseDate:

Post test2 with releaseDate September 10th 2001:

Post test3 with releaseDate September 9th 2001:

Reproduction
https://github.com/HarveyPeachey/bug-sort-date-sep-2001
Steps to reproduce
Run npm run dev
Visit http://localhost:3000/admin/index.html#/collections/post/~
Click sort by dropdown and select Release Date (Oldest First)
See test3 being moved to the bottom of the sorted list when it should be at the top
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
    Memory: 15.74 GB / 31.95 GB
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\Documents\Projects\bug-sort-date-sep-2001\node_modules\.bin\yarn.CMD
    npm: 8.5.2 - ~\AppData\Roaming\npm\npm.CMD
    pnpm: 9.0.6 - ~\AppData\Roaming\npm\pnpm.CMD
  npmPackages:
    @tinacms/cli: ^1.5.34 => 1.5.45
    tinacms: ^1.5.24 => 1.6.3

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

Bump

@JackDevAU Hi, Can I work on this?

@JackDevAU Hi, Can I work on this?

Absolutely! Join the discord or post here if you need help!


Windows 10 Session Shadowing not working

I am unable to get session shadowing working with Windows 10.
I have the below settings;

For testing I log into the console of the PC and then login via RDP using the same user, the console session gets kicked out and then if I log into the console the RDP session gets kicked.
I have tried with and without the user permission but I receive no prompt to allow shadowing.

Just disable single session by user and it will work.
On Feb 8, 2017 5:42 PM, "mukowman"<EMAIL_ADDRESS>wrote:

I am unable to get session shadowing working with Windows 10.
I have the below settings;
[image: rdp]
https://cloud.githubusercontent.com/assets/1369447/22764742/a99e42ba-eec0-11e6-9241-f14d476c6734.png
For testing I log into the console of the PC and then login via RDP using
the same user, the console session gets kicked out and then if I log into
the console the RDP session gets kicked.
I have tried with and without the user permission but I receive no prompt
to allow shadowing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stascorp/rdpwrap/issues/206, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFEaebPYkS6lsXKimSgj3MD8uv40qXSfks5ram8hgaJpZM4L7mVJ
.

I removed this checkbox but now I have multiple sessions for the same user, definitely not shadowing the session.

@mukowman you're just doing it wrong. To shadow another active session you need to use mstsc with special parameters, see README.md for links.


Corrected issue with _mapRect calculation causing negative height and Overlay image clipping.

Does any other open PR do the same thing?

No
What issue is this PR fixing?
The _mapRect generated from the MKMapRectMake() method was returning a negative height. This caused an invalid boundingMapRect, causing clipping of the overlay. The problem seems more pronounced on iOS 13.
possibly https://github.com/react-native-community/react-native-maps/issues/2801
How did you test this PR?

iOS AirMap only. Tested on real device and simulator.
Problem seems more pronounced on iOS 13.
Create clean react-native project, using latest react-native-maps. Add overlay with bounds within north/west hemisphere. Zoom into the overlay. Clipping should not happen and full overlay should be displayed in the correct location and size.
Was not tested in any other hemisphere.

@bvelasquez ❤
Could you test in various places of the globe to see if it behaves right?
Thanks 🤗

var selectedRegion = null;

    // const {width, height} = Dimensions.get('window');
    // 40.330924,-105.451970,40.794140,-104.715886 sw/ne
    const region1 = {
      latitude: 40.330924,
      longitude: -105.45197,
      latitudeDelta: 1.0,
      longitudeDelta: 1.0,
    };
    const bounds1 = [[40.79414, -105.45197], [40.330924, -104.715886]];

    // 48.994875,30.822980,49.146022,31.070173 sw/ne
    const region2 = {
      latitude: 48.994875,
      longitude: 30.82298,
      latitudeDelta: 1.0,
      longitudeDelta: 1.0,
    };
    const bounds2 = [[49.146022, 30.82298], [48.994875, 31.070173]];

    // -23.849183,133.658552,-23.446632,134.251814 sw/ne
    const region3 = {
      latitude: -23.849183,
      longitude: 133.658552,
      latitudeDelta: 1.0,
      longitudeDelta: 1.0,
    };
    const bounds3 = [[-23.446632, 133.658552], [-23.849183, 134.251814]];

    // -53.194104,-71.001892,-53.088663,-70.848083 sw/ne
    const region4 = {
      latitude: -53.194104,
      longitude: -71.001892,
      latitudeDelta: 1.0,
      longitudeDelta: 1.0,
    };
    const bounds4 = [[-53.088663, -71.001892], [-53.194104, -70.848083]];

Tested with the above regions for the MapView and bounds for the Overlay. All display correctly without clipping.
Any other coordinates you want me to try, let me know.

May also help with these issues:
https://github.com/react-native-community/react-native-maps/issues/2776
https://github.com/react-native-community/react-native-maps/issues/2135


Make REQUEST_LAUNCH codes public

Thanks for submitting a PR! Please read these instructions carefully:

[ ] Explain the motivation for making this change.
[ ] Provide a test plan demonstrating that the code is solid.
[ ] Match the code formatting of the rest of the codebase.
[ ] Target the master branch, NOT a "stable" branch.

Motivation (required)
Thanks in advance for taking a look. The product I work on uses react-native-image-picker. We would like to hook directly into these REQUEST_LAUNCH codes, but newer versions of this package don't expose them publicly anymore. I looked at the change that took them from public to private, and there didn't seem to be an explicit reason for the change. This change just makes them public again.
Test Plan (required)
Just a minor change to make it easier for consuming apps to use these codes. Just making the 4 codes public.

Tell us how this hook works, why do you require request codes? The best thing would be just fork this library, make changes and use it. Since this change is simple we might consider it, but I don't think its right.

:tada: This PR is included in version 3.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


A Question

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used:

Environment name and version:

Operating System and version:

Link to Kodi debug log:

Has the lt2http functionality been fully subsumed into the Elementum server? Or what's going on there?

Opposite. Changes from plugin.video.elementum need to be moved into lt2http and catch up all the latest changes/fixes with settings.
I hope to complete update.

What does lt2http have that Elementum does not?

Eventually torrenting functionality will be removed from Elementum and lt2http will be used instead.

What does lt2http have that Elementum does not?

Eventually torrenting functionality will be removed from Elementum and lt2http will be used instead.

Is it because you want to factor out the complexity of torrent handling from Elementum?
But then why write lt2http in C++ when you could also use Go like your other projects?

Is it because you want to factor out the complexity of torrent handling from Elementum?

It is to make Elementum lighter, easier to support, ability to use torrenting externally/centrally.

But then why write lt2http in C++ when you could also use Go like your other projects?

Because libtorrent library (https://github.com/arvidn/libtorrent) is originally in C++ and Go is using Swig to operate with that library. It brings memory issues and maitanence issues as well. It is just easier to have it separately and natively (and it would work faster).

But then why write lt2http in C++ when you could also use Go like your other projects?

Because libtorrent library (https://github.com/arvidn/libtorrent) is originally in C++ and Go is using Swig to operate with that library. It brings memory issues and maitanence issues as well. It is just easier to have it separately and natively (and it would work faster).

Okay then what about using anacrolix/torrent? It is actively maintained Go library that has a torrent Reader interface so you can use it for streaming without doing a lot of dev work, and you would be using Go for your torrent web server, making things easier.

Okay then what about using anacrolix/torrent?

Elementum was using anacrolix/torrent in version 0.0.*, you can take a look and use it if you want.
There is no plan to return back.

For sure there will be no migration done by me.
There is always a possibility to fork/contribute.

For sure there will be no migration done by me. There is always a possibility to fork/contribute.

What is the reason(s) though you moved away from anacrolix back then?

What is the reason(s) though you moved away from anacrolix back then?

Bad speeds when working with files and when having many files in a session.

Ah ok, this is not something anacrolix/torrent would have likely improved over time, as it is in Go, with its characteristic concurrency model and garbage collection affecting performance (correct me if I'm wrong @anacrolix)
So Denis, in terms of porting things into lt2http: Over the past three years with the elementum/bittorrent package, have you added features to Elementum's torrent handling and streaming algorithm that make it materially better at torrent media serving than what was in lt2http, or is it just bug fixes in the Go implementation and compatibility updates to keep up with libtorrent over the years?

I appreciate the thought @malixi94. Denis was a very early adopter of anacrolix/torrent. I think Elementum stopped using it around 2018/2019. There were some huge performance improvements in 2021 that probably addressed many problems, so I don't know where it stands now relative to the issues Denis had back then.

I appreciate the thought @malixi94. Denis was a very early adopter of anacrolix/torrent. I think Elementum stopped using it around 2018/2019. There were some huge performance improvements in 2021 that probably addressed many problems, so I don't know where it stands now relative to the issues Denis had back then.

@anacrolix what about when there are like a thousand torrents in a session though, doesn't the speed and memory consumption significantly deteriorate?

@anacrolix Nice to see you here. Cheers! 🍺
@malixi94 That is great to hear about anacrolix/torrent improvements. I was continuing following the changes and work there.
The problem with migrating back from libtorrent is that needs huge amount of time and time to solve all incoming issues reported by users.

@elgatito looking into the lt2http code, you define your own Reader class which manually cobbles byte buffers together using readv calls through a libtorrent custom storage interface, and then hands it to the web framework for serving.
This implementation presents problems in libtorrent 2.0, as was made clear in #6118 since running your readv-calling client code callbacks in the network thread is not safe, according to Arvid. He suggested you use read_piece() on the torrent handle instead, but that has its own problems.
Have you added features to the elementum/bittorrent package over the past three years that has made its torrent handling and streaming algorithm diverge from that of lt2http?
Hmm even if this is the case I'm thinking that the additional code that needs to be ported to lt2http is miniscule compared to porting the lt2http implementation itself to using libtorrent 2.0 (same goes for porting elementum/bittorrent to 2.0) Is my intuition correct Denis?
@anacrolix I searched in your torrent repo, there was an issue (#820) where having more than 10 torrents caused problems, but this seems to have been fixed by you, which is good.
But there was another issue (#839) - open for nearly a year now - where having 30 torrents caused apparently the same sort of problems of "high load". So is 10 to 20 torrents at a time the high mark for anacrolix/torrent? Because libtorrent-based clients do 1000 torrents in a session without issue.

@elgatito how do you figure lt2http should be ported to libtorrent 2.0?
I don't know if you've thought about it, but can it safely somehow get the torrent data for streaming without using read_piece()? Or would libtorrent itself have to be changed, its interface, to accommodate apps like l2http, to make things easier?
What do you think is the best course of action?


Documentation on amending request object

The documentation on how to amend the request object (with Middleware for example) could use some more explanation that it works like a regular dict. See #1447.

@ahopkins I can handle this.


regex support in routef %O

Hey there, I've been playing with Oxpecker and so far so good!
I'm tryng to configure a route with a regex using %O
routef "/posts/{%O:regex(^.+_(\\d{4}-\\d{2}-\\d{2}-\\d+)$)}"

However, every time I startup the server I hit this exception
Unhandled exception. Microsoft.AspNetCore.Routing.Patterns.RoutePatternException: In a route parameter, '{' and '}' must be escaped with '{{' and '}}'.
   at Microsoft.AspNetCore.Routing.Patterns.RoutePatternParser.Parse(String pattern)
   at Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.MapMethods(IEndpointRouteBuilder endpoints, String pattern, IEnumerable`1 httpMethods, RequestDelegate requestDelegate)
   at Oxpecker.EndpointRouteBuilderExtensions.MapSingleEndpoint(IEndpointRouteBuilder builder, HttpVerbs verb, String routeTemplate, RequestDelegate requestDelegate, FSharpFunc`2 configure)
   at Oxpecker.EndpointRouteBuilderExtensions.MapOxpeckerEndpoint(IEndpointRouteBuilder builder, Endpoint endpoint)
   at Oxpecker.EndpointRouteBuilderExtensions.MapOxpeckerEndpoints(IEndpointRouteBuilder builder, IEnumerable`1 endpoints)
   at Oxpecker.EndpointRouteBuilderExtensions.MapOxpeckerEndpoint(IEndpointRouteBuilder builder, Endpoint endpoint)
   at Oxpecker.EndpointRouteBuilderExtensions.MapOxpeckerEndpoints(IEndpointRouteBuilder builder, IEnumerable`1 endpoints)
   at Oxpecker.Middleware.UseOxpecker@19.Invoke(IEndpointRouteBuilder builder)
   at Microsoft.AspNetCore.Builder.EndpointRoutingApplicationBuilderExtensions.UseEndpoints(IApplicationBuilder builder, Action`1 configure)
   at Oxpecker.Middleware.ApplicationBuilderExtensions.UseOxpecker(IApplicationBuilder builder, IEnumerable`1 endpoints)
   at <StartupCode$Openapo>.$Program.main@() in X:\Openapo\Program.fs:line 27

I'm not sure if I'm missing something or what I'm trying to do is not supported in Oxpecker.

@AngelMunoz Hi! I think you should do what the error says - replace single curly braces into double curly braces inside regex. Also, it seems you are matching a string, so %s should work as well. %O is used for types that are not supported by F# routef module, I should probably make it more clear in docs, thanks for raising an issue!

I'm trying to match a string with a particular format hence why I was trying to use a regex definition there. Using %s matches only until there's a space or a special character, as an example:
F# is very good! gives me F as the route parameter
even if I url encode the string.
Using the double {{}} also fails, I digged a bit last night and I think this is likely messing with this regex being used for routef
https://github.com/Lanayx/Oxpecker/blob/develop/src/Oxpecker/Routing.fs#L82
In any case, I'll take that this is not supported currently thanks for the quick answer!

@AngelMunoz can you please give a regex example that doesn't work for you? I tested this yesterday and it worked:
routef "/posts/{%s:regex(^.+_(\\d{{4}}-\\d{{2}}-\\d{{2}}-\\d+)$)}" (fun id -> text id)

Oh right, my bad that one you provided does not have runtime errors at registration but does not match this path for some reason
/posts/F#%20and%20oxpecker%20are%20doing%20cool%20things!_2024-10-27-38 I get a 404

Here's a quick video of what's going on, a single string matches just fine but the other one does not
https://github.com/user-attachments/assets/4d619aa3-dafb-48cd-8bca-218f22aa00d5
But I'm suspecting that might be due my regex. In any case I am able to use the regex in the path as it was expected. I thought it was just for %O but it can be used with %s as well. thanks again!


missing FormattedSDDLText

I'm trying to open the blank template Schema.msi from MSI SDK, Package::open panic with Invalid category: FormattedSDDLTexterror. From this doc it seems FormattedSDDLText is an officially supported data type. Maybe it is missed from rust-msi ? I have compared the Category enum with the official doc, found the following differences
rust-msi            official doc
---------------------------------------
missed              FormattedSDDLText
missed              Time/Date
KeyFormatted        missed
Url                 missed
---------------------------------------

Should be easy enough to add FormattedSDDLText and Time/Date.  Can you link to the Schema.msi file you're using (or just post the file here) so I can test it out?

this is the file I'm trying to open with.
Schema.zip , or you can check this link for more. Thank you for maintaining this project!

Thanks!  With the above commit I just pushed (bba603e), reading that Schema.msi file seems to work fine now.


Improve tests

Codecov Report

Merging #203 (89517e0) into master (46e115e) will increase coverage by 1.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   85.01%   86.60%   +1.58%
==========================================
  Files          27       27
  Lines        2149     2127      -22
==========================================
+ Hits         1827     1842      +15
+ Misses        322      285      -37

Impacted Files
Coverage Δ

mapentity/helpers.py
72.44% <ø> (+5.62%)
:arrow_up:

mapentity/widgets.py
100.00% <100.00%> (+31.03%)
:arrow_up:

mapentity/registry.py
96.29% <0.00%> (-0.53%)
:arrow_down:

mapentity/views/api.py
100.00% <0.00%> (+1.96%)
:arrow_up:

mapentity/views/mixins.py
100.00% <0.00%> (+11.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e115e...89517e0. Read the comment docs.


POC: AWS system manager inventory with data sync

User Story
As a product manager I want to be able to understand what we have running on the platform and where there are vulnerabilities - for example when a component is no longer in support or if there is a security incident related to that component. We can then advise application teams of potential issues.
I also ways to be able to provide security teams with the relevant information allowing them to contact application teams directly.
This ticket is to look to see if we can use AWS Systems Manager Inventory with Resource Data Sync as a tool to satisfy this requirement. The theory is we can gather information about software installed on all instances that have SSM agent installed/activated. We can then use Resource Data Sync to gather all inventory information for multiple accounts/regions into a central s3 bucket that can then be queried by Athena or any other visualisation tool  -see https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-inventory-datasync.html
This way we can query what software and packages are deployed across the platform and help to identify the impact of any security vulnerabilities
Perhaps this would best be collected in an s3 bucket in the “organisation-security” account?
This is a POC only and is only required for a small subset - maybe 1 or 2 applications only.
Value / Purpose
This helps us to understand risks within the platform and help to address, alongside other teams, some of those vulnerabilities.
Useful Contacts
No response
Additional Information
This is a follow on from https://github.com/ministryofjustice/modernisation-platform/issues/6317
Clearly this will not work for elements without SSM, but this should be a minority of instances.
Definition of Done

[ ] Decide on account(s) to use in the POC
[ ] Agree/create s3 bucket to use
[ ] Configure/use datasync to send inventory data to s3 bucket
[ ] Review data in bucket for value
[ ] if time set up a tool (athena?) to query data for the account
[ ] Present to the team
[ ] If agreed raise further tickets to progress

closed as duplicate


Update Timeline “2022-06-16t15-40-38-831z-campaign”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
a6539c2a52ad01cb80c2aaa5d29bc84998e67f71

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62e9c847f1187b00083f4c62


Stubs: session management and pin map proto changes to support pin group feature

[x] This contribution adheres to CONTRIBUTING.md. (Required)
[ ]  Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

The session_management_service.proto and pin_map_service.proto are updated in sync with their copies in ni-apis to support the pin group feature.
The LabVIEW measurmentlink API stubs (MeasurementLink Session Management Client.lvlib, MeasurementLink Pin Map Client.lvlib) are updated following the \measurementlink-labview\docs\Regenerating Server and Client.md to sync the proto file changes.

Why should this Pull Request be merged?

To keep the proto files and stubs in sync with their copies in ni-apis supporting the pin group feature.
The PR updates the stubs only. The wrapper changes for the new stub are yet to be done along with the pin group feature development.
The newly generated stubs shouldn't impact any of the existing workflow.

What testing has been done?

The existing 151 test should pass.

@Prem-MysteryPro did you use this version of grpc-labview? https://github.com/ni/grpc-labview/releases/tag/v<IP_ADDRESS>
That's the one we've used to generate against. We don't want to upgrade to <IP_ADDRESS> yet.

@Prem-MysteryPro did you use this version of grpc-labview? https://github.com/ni/grpc-labview/releases/tag/v<IP_ADDRESS>
That's the one we've used to generate against. We don't want to upgrade to <IP_ADDRESS> yet.


Unable to set the config.environment value after tealium has been created (which is required as soon as the platform cannot be hard coded, but comes from a config file or elsewhere in an asynchronous manner)

tealium_angular_fixed.js.zip
Here is the bug / issue we have faced:
"environment" value is supplied in a, asynchronous manner because comes from a config file (same problem if cpming from api server calls, with $http.get which is asyncchornous by nature
Therefor, in the .config of the tealium service (where tealimuProvider is available), this asynchronous value cannot be known at this step...)
But the problem is that the tealimu API has no setConfig nor setConfigValue method...
By angularJs spec, it is not possible to inject a service into a Povider (service provider), the only place where setConfig or setConfigValue can be set (same isssue if injecting $http ng service because it is by nature asynchronous. this men
Attached is a proposed fixed  (which only expose a setEnvironment function on tealium object) , so that we can set this asynchronously , after tealium instantiation, not at the provider level.
So the usage is :
1 first , at tealiumProvider lelve, setConfig orSetConfig Value as you would do before.
2. after tealium instantiation, inside the contructor of your service using tealimu, get the env value (from another config service in general, qwhich is set as resolve dependency of this one), and cakl this new method like this  "tealium.setEnvironment(myPlatform)" (where myPlatform is either dev, qa or prod.
Could you please fix this issue which is imo blocking for a majority of projects, since the env platform is dynamic (cannot be hard coded because depends upon the testbed / runtime environment)
tealium_angular_fixed.js.zip

Have you considered hard-coding environment string to "/prod" and then using the Extension in Tealium iQ for "Domain-based Deployment"?
Use this customization to load a QA or Dev version of your Tag Deployment based on hostname.

Hi,
not sure to understand the point as I am a Tealium newbie: do you mean that overriding this value should by done on the ops side, on the tealium server itself ? and not on the js code  side.
Could you please give me pointers regarding this Tealium IQ extension ?
Thanks in advance for your support !
Best regards,
Prisca

Based on the hostname match, the utag.js can bring in the /dev/utag.js or /qa/utag.js versions at runtime.
This is described here: https://community.tealiumiq.com/t5/iQ-Tag-Management/Domain-Based-Deployment-Extension/ta-p/13703
This may be a solution for you.


Ridge Regression - where to apply priors?

Hi Team, regarding ridge regression, was wondering if it's possible to choose what prior (weight) to apply to each of the variables? Would be useful to force in variables that the model dropped from the model (coef=0) Thanks

Hi, this can be achieved by using the parameter penalty.factor in glmnet, see the library documentation here


[FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

What is the purpose of the change
Add documentation about the AdaptiveBatchScheduler
Verifying this change
Document change without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@tillrohrmann @dmvk would you help to take a look at the EN version document if it is convenient?

I'm not sure whether ABS should have its own "top level" section under the deployment menu. Would it make sense to incorporate this into elastic scaling page?

I'm not sure whether ABS should have its own "top level" section under the deployment menu. Would it make sense to incorporate this into elastic scaling page?

Good idea! +1 to add this doc as an Adaptive Batch Scheduler section in Elastic Scaling page.

Are you also planning a blog post for this? It would be a good opportunity to enhance this with some high level pictures that could be then reused.

Yes, blog post is in our plan, maybe shortly after 1.15 release.

Thanks for your comments @zhuzhurk @dmvk @tillrohrmann, this goes a long way towards perfecting this document. I've update the document, looking forward for your further feedback.
@dmvk Currently RSS does not support ABS (mainly does not support one input gate consumes subpartition range), so the part of integrating with external shuffle services , I think it can be added after RSS is adapted to ABS. When posting blog posts in the future, if the adaptation of RSS has finished, users can also be recommended to use it.

Thanks for addressing the comments! The change looks good to me.
@dmvk do you want to take another look?

@flinkbot run azure


Update to py311

Hi Muhammad,
would you consider this PR updating to python 3.11. Monailabel depends on your work and it wont install on python 3.11 as the numpy version in your work does not support 3.11. I tried to do all the steps to upgrade, but did not check if any functionality breaks. I don't think so but you are the expert :-)
Thanks would be great if you could accept it.

Hi @elitap
Many thanks for your contribution. Of course such contributions are most welcome.
I am currently away for a conference, should be back starting the third week of October. Will review this then and get back to you with any comments/suggestions.
You might also want to have a look at torchmaxflow library that is based on this code and may need a similar PR contribution if you are interested...

HI @elitap
Many thanks for your contribution here.
I did some testing locally, add some necessary changes needed here and also revert some changes that were not needed for this. I am doing a couple of more test on github after which I will release version 0.0.6 that should have support for py3.11.
Thanks once again for your contribution and for highlighting that these changes are necessary for your work with monai label.

@elitap as you can already see, I have released this.
I have added a PR to update to v0.0.6 for numpymaxflow in MONAILabel here: https://github.com/Project-MONAI/MONAILabel/pull/1575

Hi @masadcv,
awsome, thank you very much :-).


Exclude buildings from the purchase index

Currently, my strategy includes keeping my Wizard towers at low numbers so I can use them to double up on Hand of Fate spells.

Keep your Wizard Towers at 430
When a frenzy cookies shows up:

Cast Hand of Fate
Sell 400 Towers
Cast Hand of Fate again

Because of this, Wizard Towers are always my least-purchased building and are always the green option for buying with CookieMonster's price index calculations.
I would still like to take advantage of the index for other buildings while doing this strategy, so it would be helpful to exclude some buildings from the calculation so their numbers aren't accounted for when doing the color highlighting.
Attached screenshots show the current implementation compared to a mockup of what this feature might look like

This is actually a duplicate of #155 (and indeed a very useful function).
It is planned for the next release but I can't give a release date just yet.

Ah great to see! Apologies for not looking harder for an existing thread.

No problem! Always happy to see people finding the GitHub, that's often the most difficult step :)


I want to search bellinge denmark

Subject: I want to search bellinge denmark
Description:
It not working
Results:
It tells me be more clear
But i film in bellinge denmark and clik on it but
When click it tel me be more dont know the word
More clear more to the piont i think it means more specifiek but i can go try to fill in name of verys small town
Backend version: develop-bf8528d9
Frontend version: develop-bf8528d9
User Agent: Mozilla/5.0 (Linux; Android 11; SM-A127F Build/RP1A.200720.012; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/98.0.4758.101 Mobile Safari/537.36 EdgW/1.0
Page: https://couchers.org/search?#loc=4.38/60.36/7.49/36.6
User: appel300 (3936)

dupe #2631


Rough API

Extremely rough api for the controller <-> agent communication

Coverage remained the same at 50.0% when pulling 7a7d4f953a1bf5cb6cf64d885f49da75d5a16cca on cholcombe973:master into 6b9aaa008680b46c96c0f60fe237120c9a17e38d on ChrisMacNaughton:master.

Coverage remained the same at 50.0% when pulling 7a7d4f953a1bf5cb6cf64d885f49da75d5a16cca on cholcombe973:master into 6b9aaa008680b46c96c0f60fe237120c9a17e38d on ChrisMacNaughton:master.


[WIP]Check parameters in contracts

:x: Build AElf <IP_ADDRESS>47 failed (commit https://github.com/AElfProject/AElf/commit/0857095e66 by @xiangxingxing)

:white_check_mark: Build AElf <IP_ADDRESS>53 completed (commit https://github.com/AElfProject/AElf/commit/2d6b8c0d54 by @xiangxingxing)

:white_check_mark: Build AElf <IP_ADDRESS>57 completed (commit https://github.com/AElfProject/AElf/commit/01b874fc95 by @xiangxingxing)

:white_check_mark: Build AElf <IP_ADDRESS>74 completed (commit https://github.com/AElfProject/AElf/commit/fefa6d0bb6 by @xiangxingxing)

:x: Build AElf <IP_ADDRESS>43 failed (commit https://github.com/AElfProject/AElf/commit/feab24b9b7 by @xiangxingxing)


haskellPackages.leveldb-haskell: fix build

Description of changes
Fix tests failure for base≥4.15.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of haskellPackages.leveldb-haskell
[x] Tested basic functionality of all binary files (none)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Cherry-picked as 6a36abcd594.

Thank you!


Mac: click-through from other app should focus on the editor area that was clicked

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:22:50.650Z)
OS Version: Darwin x64 16.5.0
Extensions:

Extension
Author (truncated)
Version

python
don
0.7.0

Steps to Reproduce:

Open Terminal area
In Code, click the code area to focus it
Switch to another app
Click terminal area in Code through another app

The expected behavior for click-through on macOS is that focus goes to the area that you've clicked. For instance, if I have a (standard) Terminal window with two tabs open and the Finder is the foreground program, clicking on a tab on that terminal window will both bring the Terminal app in focus and switch to the tab that I've clicked.
With Code, the actual behavior is that the program goes to the foreground but the focus within the app stays with whatever was focused at the time Code was put to the background.
This frequently causes me to start typing commands in my editor view.

Reproduces without extensions: Yes

Duplicate of https://github.com/Microsoft/vscode/issues/24634


Use size results from _parse_request everywhere (Fix facet aggregation)

Caused by #1007
There was a new field returned from the request parsing logic and was not unpacked everywhere.
Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

Codecov Report

Merging #1020 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage    90.6%   90.64%   +0.03%
==========================================
  Files          50       50
  Lines        6762     6763       +1
==========================================
+ Hits         6127     6130       +3
+ Misses        635      633       -2


RLock lease expiry not being extended in spite of RLock being acquired

Our Microservice is running in Azure. It is deployed with 2 pods. Each pod attempts to lock the same RLock, the idea being that only one pod at a time holds the lock.
RLock is obtained using org.redisson.api.RLockAsync.lockAsync() and onComplete() lambda is used to get notified about lock acquisition.
We observed following: pod1 had the lock but then pod2 got notified of lock acquisition.
We logged: 22/10/2021 09:54:19.178 heldByCurrentThread=true, ttl=29982 based on this code
"heldByCurrentThread=" + leaderLock.isHeldByCurrentThread() + ", ttl="+ leaderLock.remainTimeToLive()
On 22/10/2021 09:54:24.363, 22/10/2021 09:54:34.364 and 22/10/2021 09:54:44.364 leaderLock.isHeldByCurrentThread() returns true however at 22/10/2021 09:54:54.365 it returned false.
So we lock again and within 1 msec get notified about success: heldByCurrentThread=true, ttl=29998
This cycle continues from then on:

we get the lock without issues, very quickly
within 30 seconds we lose the lock and so go back to 1)

I think 30 seconds matches lockWatchdogTimeout setting. I see no warn/error log related to Redis connectivity
I have logs for around 3 hours when this issue has persisted but it might have well lasted for much longer.
Expected behavior
If a client acquires RLock then it should also be able to extend its (lease) time
Actual behavior
A client acquires RLock but then seems unable to extend its (lease) time
Steps to reproduce or test case
Issue intermittent
Redis version
Redisson version
3.15.6
Redisson configuration
config: ---
clusterServersConfig:
idleConnectionTimeout: 10000
connectTimeout: 15000
timeout: 3000
retryAttempts: 3
retryInterval: 1500
password: "..."
subscriptionsPerConnection: 5
sslEnableEndpointIdentification: true
sslProvider: "JDK"
pingConnectionInterval: 5000
keepAlive: true
tcpNoDelay: true
nameMapper: !<org.redisson.api.DefaultNameMapper> {}
loadBalancer: !<org.redisson.connection.balancer.RoundRobinLoadBalancer> {}
slaveConnectionMinimumIdleSize: 24
slaveConnectionPoolSize: 64
failedSlaveReconnectionInterval: 3000
failedSlaveCheckInterval: 60000
masterConnectionMinimumIdleSize: 24
masterConnectionPoolSize: 64
readMode: "MASTER"
subscriptionMode: "SLAVE"
subscriptionConnectionMinimumIdleSize: 1
subscriptionConnectionPoolSize: 50
dnsMonitoringInterval: 5000
natMapper: !<org.redisson.api.DefaultNatMapper> {}
nodeAddresses:

"rediss://ixcc-qa-redis.redis.cache.windows.net:6380"
scanInterval: 5000
checkSlotsCoverage: true
threads: 16
nettyThreads: 16
codec: !<org.redisson.client.codec.StringCodec> {}
referenceEnabled: true
transportMode: "NIO"
lockWatchdogTimeout: 30000
reliableTopicWatchdogTimeout: 600000
keepPubSubOrder: true
useScriptCache: false
minCleanUpDelay: 5
maxCleanUpDelay: 1800
cleanUpKeysAmount: 100
nettyHook: !<org.redisson.client.DefaultNettyHook> {}
useThreadClassLoader: true
addressResolverGroupFactory: !<org.redisson.connection.DnsAddressResolverGroupFactory> {}

Which eviction policy does Redis use?

Hi @mrniko ,
eviction policy is volatile-lru
async callbacks don't do much processing

volatile-lru removes least recently used key(s) from the memory with a special consideration: the key must have an expiry time set.
Did you try to set noeviction ?

Hi @mrniko , Azure Redis instance is shared across many services and so I cannot simply experiment with such global settings. If this issue ever happens again what I should I check on the Redis side? I can definitely check some basics like expired and evicted keys

You need to set eviction policy to noeviction, so locks and other object won't disappear.


ssl - improve documentation on mbedtls_ssl_read and PEER_CLOSE_NOTIFY

Add a description of MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY to the documentation, as suggested by hanno-arm.
This fixes https://github.com/ARMmbed/mbedtls/issues/2173.

I've double-checked that the pr-head job's only failure was in a know-flaky ssl-opt.sh test that passed in the pr-merge job (and is quite obviously unrelated to this documentation-only PR), so can be ignored for the purposes of merging this PR.


Add CM17A support

Description:
Add CM17A support.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7743
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

I recently updated to this version, and was having the code incorrectly identify my CM11 as a CM17. The code assumes that if an exception is thrown at setup (from the "heyu info" command) that it's because it's a CM17.
I'm not sure why the exception on "info" was being thrown, in my case, so if you want, you can ignore this message. (It seems to have fixed itself. Fine.) But perhaps we can find a better way of identifying CM11 .vs. CM17?
I haven't had the opportunity to contribute to the codebase yet, but perhaps this is something I can help with. I thought I'd bring this up first, see what the thoughts are about this issue. (I'm not entirely sure what the protocol is around here, whether this message is appropriate or not - if not, my apologies.)

@RobCranfill Please do not report issues or ask for support in PR's.
If you are in need of support, you should try our Community Forum or join our Discord chat server. You are more likely to get the answer you are looking for in those places.
If you've found an issue, please create a new issue here on GitHub.
Thanks! 👍

Frenck, again, my apologies if this comment is inappropriate. But I did not think I was asking for support, nor reporting an issue. I was more asking a question about the design decision behind this bugfix, with an eye to perhaps reporting the current state as a "bug", and offering/coding a solution, once I understood why the original "fix" was made the way it was.
Is there no facility here for discussion coding decisions?
(It seems unlikely that the appropriate people would be online with the chat server, but perhaps the forum is the place I should go. But my question relates very specifically to this particular bug, this particular fix.)

The 'info' command was used because it appears to be the only way to distinguish between CM11A/CM17A. If there is a better way feel free to open a new issue.

Please open an issue if you suspect a bug.
If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.
Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug.
Thanks!


Clarification for ESP based board when accessing their filesystem

As a beginner using an ESP based board I was confused when couldn't find the /flash directory. Thus, made small addition in the README file that might help clarify for others.

Thanks for the clarification.


CPS-57 Accept Usage File is sending wrong parameter in post request.

Codecov Report

Merging #73 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   92.71%   92.71%   +<.01%
==========================================
  Files          67       67
  Lines        1907     1908       +1
==========================================
+ Hits         1768     1769       +1
  Misses        139      139

Impacted Files
Coverage Δ

connect/resources/usage_file_automation.py
97.05% <100%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42672b6...f4b7a1b. Read the comment docs.


Add chrome extension URL as trusted app

Currently the user needs to add the correct extension URL as a trusted app manually to allow access to NSS Pods. This is a manual step described on the options page.
We can simplify this, by doing it automatically (e.g. by just clicking a "Trust WebClip" button on the options page)
Since the options page does not send an origin header, the options page can do a request to add the required triple to the user profile.
As of today this is only needed for NSS, since CSS does not make use of the "trusted app" authorization and ESS does not work yet at all (see #21)

part of https://github.com/codecentric/web-clip/issues/29

Since the options page does not send an origin header, the options page can do a request to add the required triple to the user profile.

Unfortunately, this is no longer true. The options page does indeed send an origin header and is therefore not allowed to add the required tripes.

As of today this is only needed for NSS

I do not think it is worth to put more effort on workarrounds for NSS, since solidcommunity.net and probably other providers will be moving from NSS to CSS in the long term and app authorization will work differently in the future. For now, we need to guide NSS users to add the correct extension URL as trusted app manually.


Multi-Hop Multicast Packets via NCP

I have a network with 2 routers and 1 leader. The leader is within range of router 1, and router 1 is within range of router 2, but the leader is out of range of router 2 and must go through an extra hop to get there.
When I send a multicast packet from the leader to the all-nodes link-local address "FF02::1", I would expect both routers to receive the multicast packet, but it appears that router 1 swallows the multicast and router 2 never receives the packet. I have debugged the outgoing packet to ensure the hop limit is > 1.
I am using three CC2538 processors as NCPs via wpantund. This issue is similar to #238. (maybe a regression?)
When I get a spare moment, I will try reproducing with the CLI.

Link-local scope in Thread is defined by receivers within direct transmission range.  If you want to reach receivers multiple hops away using multicast, you need to use Realm-Local Scope (e.g. FF03::1).

Thanks, that seems to do the trick. In the CLI, pinging FF02::1 only returned a ping from router 1, but pinging FF03::1 returned a ping from both routers. I'll go ahead and close this issue.


Automatically generated reference documentation based on values.schema.json

Hello,
I am not sure if this is the right place for my question, but I would like to ask if anyone knows of any tool to automatically generate documentation from values.schema.json. This file usually contains the complete structure and data types, but may also contain a description for each field. JSON is not a very user-friendly format, and useful to be able to visualize this file in a more user-friendly form. This would also facilitate the maintenance of the project as there would be no need to maintain the documentation manually in the README.md file. The README.md files would only contain conceptual information, and detailed information would be available in the reference documentation.
I don't know if it should be part of the helm or some other external tool, but I'd like to discuss this feature.
Best regards,
Kamil Breguła
Related issues:
https://github.com/apache/airflow/issues/11077 (a small POC is available here)
https://github.com/artifacthub/hub/issues/755

This could also make a great feature or plugin.

https://github.com/adobe/jsonschema2md

Together with the Artifact Hub team, we managed to prepare documentation.

You can take a look at it live in the Artifact Hub package: https://artifacthub.io/packages/helm/artifact-hub/artifact-hub
More info: https://github.com/artifacthub/hub/issues/755
I just need to find a person to handle my one ticket. Can you help me with this?
https://github.com/helm/helm-www/issues/903


tac is not portable

Hi,
If I invoke asdf list all perl command on osx I get following
No compatible versions available (perl )

Inside bin/list-all I see the following line
$(perl_install_bin) --list-all | tac | tr '\n' ' '

According to this answer tac can
be replaced by tail -r command.
Can you please adjust it.

@somatoko
Sorry for the delay.
I have corrected it below.
Can you please check if it works?
https://github.com/ouest/asdf-perl/pull/13


Marker remove

How does marker remove work? I tried marker remove tilesetter but it saysusage: marker [-h] {mark,get,remove,update} .... Tilesetter is alias for a command. Using the full command didnt work either
~/Documents/Godot/Tilesetter/Tilesetter$ marker remove ~/Documents/Godot/Tilesetter/Tilesetter/.Tilesetter
usage: marker [-h] {mark,get,remove,update} ...
marker: error: unrecognized arguments: /home/joni/Documents/Godot/Tilesetter/Tilesetter/.Tilesetter

Edit: For anyone wondering you just type `marker remove` and then you choose the command from a menu

Thank you!


fix(hebergement): redirect at update

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


hcat: type unstable based on the number of arguments

Hi, thanks for the very useful package!
I noticed that when doing hcat, I get varying output type based on the number of arguments.
I think adding a method like below could resolve this:
function Base.hcat(vectors::ComponentVector{T,A,Tuple{Ax}}...) where {T,A,Ax}
    return ComponentMatrix(hcat((getdata(v) for v in vectors)...), Ax(), FlatAxis())
end

happy to open a PR if you think that would work.
Minimal Example:
using ComponentArrays
c = ComponentVector(a=1)
display(hcat(c, c))
display(hcat(c, c, c))

Oh yeah, if you wouldn't mind, I'd appreciate that PR!

https://github.com/jonniedie/ComponentArrays.jl/issues/113 is also related

See #169


Export control (ECCN)

Hi, is there ECCN for typescript or email address I can contact regarding US export compliance for this project?

I'm following up with our internal contact on the matter and will let you know what I find out

TypeScript doesn't have an ECCN and we aren't able to assist further in this matter.


Fix leaked ResponseBody in NihmsLoader

Warning message in the nihms-loader about leaked response body:
WARNING: A connection to http://stage.internal.pass-core-api/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

Identified that the response body leak was occurring in the pass-data-client. Discussed with @markpatton and will add try-with-resources in the JsonApiPassClient for the responses.


wrong overlapping event

I'm using the app on android OS,
recently got an overlap event with a varified COVID19 patient.
When I cross-checked with ministry of health's most updated report AND after rechecking with your PointsUtc.json file, the there is no overlapping.
Specifically, the app claims there has been a verified COVID19 patient in
"מגה בעיר", רחוב אבן גבירול 30, תל אביב - יפו
at the time of 31.03.20 at around 11:59
but there hasn't been one according to your db ( the only occurrence in this location is at 2.4.20):
{"type":"Feature","id":382637,"geometry":{"type":"Point","coordinates":[34.7819995,32.0749569000001]},"properties":{"OBJECTID":14797,"ID":null,"Name":"","Place":"\"מגה בעיר\" אבן גבירול 30 תל אביב - תל אביב - יפו","Date":1586510303000,"types":"G_Poi","Comments":null,"POINT_X":32.0749569000001,"POINT_Y":34.7819995,"fromTime":1585832400000,"toTime":1585833000000,"sourceOID":1,"flight":null,"flightFrom":null,"flightArrival":null,"stayTimes":"14:00 - 14:10","fromTime_utc":1585825200000,"toTime_utc":1585825800000,"Key_Field":14797}}

also attached

jpg of event reported according to your app.

@greenyossi, can anybody take a look on this?

@dotansimha @yoav85 @MaxToyberman can you take a look at this issue?
I think false-positives (and maybe undiscovered false-negatives?) are not something that this app should have the luxury of having.

@RamLavi I'm not part of this project officially, and honestly, as an open-source developer, I'm not excited or keen to work on this project at all.
This project is not maintained as a real open-source.
It seems like the MOH developers has their own private and plan agenda, and they just manage the source code on GitHub.
The roadmap is not clear and not public, CI fails, there are PRs that has been ignored by the maintainers, and in general it seems like a poorly maintained open-source.
You can take a look at the list of PRs for example. And the list of commits is messy, open-source project shouldn't have commits called fixes or some more fixes or updated.
The effort of sharing the developers community is worth it, but it seems like the MOH doesn't understand it so far, and they choose to develop it internally, and just share the source code.
Related: https://github.com/MohGovIL/hamagen-react-native/issues/141


Update Spring Boot to the latest version

Update the guide to use the most recent Spring Boot version.
Files that require changes are:
initial/build.gradle
initial/pom.xml
complete/build.gradle
complete/pom.xml

I would like to work on this issue. Can you assign it to me?

Hi @yr1404 .  Thank you for your interest!  Please feel free to submit a PR for this issue.  The first valid PR that we get we will merge.
If you don't get the chance to work on this issue there should be other opportunities.  Spring Boot releases approximately once per month so frequent updates will be needed.  Additionally this same issue exists in about 16 other repositories in the spring-guides org.
Thanks again for your interest!  If you need help learning the processes here is a great video by two Spring Engineers on how to contribute to open source.

Thank for suggesting the video @robertmcnees.

Thanks for the PR @yr1404 !  It has been merged.  I'll close this issue for now.  We will likely have more upgrade possibilities in the future.


Mention example on TrainIT

Hi,
would you like to mention this example (https://github.com/trainit/2018-03-nette-webpack)?
It might be good for both sides.

Done, thanks for the suggestion :)

Thank you.

Tiny detail, it seems that mention does not create a link in README.

Oh. Thanks for pointing out.


Improve namedPartial convention for yield: aNamedPartialToYield on: aContext

In some cases we might want to refer to a partial that is nested in the dictionaryish of partials of aContext.
For example, to prevent code repetition and reuse templates, we might want to render a shared partial:

<st= STT yield: 'shared/alerts.html' on: self alerts>

That partial should render well when the context has:
partials := { #shared -> { 'alerts.html' ->  '
Some alerts to render
' asSTTemplate } asDictionary } asDictionary

Done https://github.com/sebastianconcept/STTemplate/pull/8


Integrate zlib into Python distribution

No more missing zlib compiler errors.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Change content looks good; merge on test results.


PYIC-4120: add error handling contract test for passport CRI

Proposed changes

Add error handling pact contract test for CRI

What changed

Added token and credentials endpoint contract tests

Why did it change

To improve pact tests code coverage

Issue tracking

PYIC-4120

Looking at the Passport VC Confluence page here: https://govukverify.atlassian.net/wiki/spaces/PYI/pages/3239772254/<IP_ADDRESS>.+Passport+Verifiable+Credential+VC it looks like we could also get a D02 ci in the VC. We should have a test for that too.


Tutorial

Can someone please make a tutorial, I am so confused and I need to do this.

A tutorial is already in the readme, in the "Video Interpolation with FFmpeg" section.

Bruh Ut doesn't even work and its confusing

It does in fact work. Just tested it a few minutes ago. You might need to read up how a terminal works, and that you may need get ffmpeg into the same folder as dain.

Still very confused, also will it ever get a GUI?

This repository probably won't get a GUI. You also probably want to look at cain-ncnn-vulkan instead, since it's faster with similar quality.
Or RIFE, since you can run it from google colab

This repository probably won't get a GUI. You also probably want to look at cain-ncnn-vulkan instead, since it's faster with similar quality.
Or RIFE, since you can run it from google colab

You can run DAIN from Colab too, just FYI

Can confirm the instructions in the readme do work other than having to copy the model files out to the root directory.

I tried to make the dain-ncnn-vulkan Tutorial with chinese, https://www.bilibili.com/read/cv9263017

I tried to make the dain-ncnn-vulkan Tutorial with chinese, https://www.bilibili.com/read/cv9263017


Update pastebin automatically with newest installer

I created a small script to remove some of the hassle with pasting a new pastebin code for when the installer changes.
A small revision that really doesn't accomplish any of the goals, but something that is nice to have. :smile:

Does this create a new paste every time, or does it update the current one?

It creates a new paste each time, I don't believe the api makes editing pastes possible.

Alright.
I'm not sure how useful this will be,
But I will merge it if you document the PASTEBIN_API_KEY file. (that it should exist, and what it should contain (which I just guess is the api key to pastebin, but it should be written down))

Haha, yes I only realized after creating upload.py that the installer really wouldn't change much and thus this script wouldn't be too useful, and might be overkill. Oh well. It's a nice tool to have nevertheless.


Bumping TypeScript version to 3.6.4 (Currently latest stable version)

#82
NOTE: It is also possible to change it to "latest" but since its the latest stable version I think it's better to leave it at 3.6.4 for now.

Thanks!


Can Dat Desktop be installed on Windows?

I'm trying to "npm install" on windows but i get errors:
prebuild WARN install No prebuilt binaries found (target=v4.5.0 arch=x64 platform=win32)
'make' is not recognized as an internal or external command,

Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
 ERR! argv "C:\\Program Files (x86)\\nodejs\\node.exe" "C:\\Users\\user\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install"

I installed http://gnuwin32.sourceforge.net/packages/make.htm
and i get
prebuild WARN install No prebuilt binaries found (target=v4.5.0 arch=x64 platform=win32)
make: Interrupt/Exception caught (code = 0xc00000fd, addr = 0x4227d3)
prebuild ERR! build Error: make  failed with exit code 255
prebuild ERR! build     at Object.exports.spawnFailed (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\sodium-prebuilt\node_modules\prebuild\error.js:31:10)
prebuild ERR! build     at ChildProcess.<anonymous> (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\sodium-prebuilt\node_modules\prebuild\util.js:116:14)
prebuild ERR! build     at emitTwo (events.js:87:13)
prebuild ERR! build     at ChildProcess.emit (events.js:172:7)
prebuild ERR! build     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

prebuild ERR! build error
prebuild ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
prebuild ERR! stack     at ChildProcess.onExit (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\node-gyp\lib\build.js:276:23)
prebuild ERR! stack     at emitTwo (events.js:87:13)
prebuild ERR! stack     at ChildProcess.emit (events.js:172:7)
prebuild ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
prebuild ERR! not ok
prebuild ERR! build Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
prebuild ERR! build     at ChildProcess.onExit (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\node-gyp\lib\build.js:276:23)
prebuild ERR! build     at emitTwo (events.js:87:13)
prebuild ERR! build     at ChildProcess.emit (events.js:172:7)
prebuild ERR! build     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

Not yet. We're working on prebuilt versions of Dat's native dependencies so
we can have it work smoothly on Windows too. See
https://github.com/datproject/dat/issues/581
On Tue, Jan 3, 2017 at 2:50 PM Rik<EMAIL_ADDRESS>wrote:

I installed http://gnuwin32.sourceforge.net/packages/make.htm
and i get
prebuild WARN install No prebuilt binaries found (target=v4.5.0 arch=x64 platform=win32)
make: Interrupt/Exception caught (code = 0xc00000fd, addr = 0x4227d3)
prebuild ERR! build Error: make  failed with exit code 255
prebuild ERR! build     at Object.exports.spawnFailed (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\sodium-prebuilt\node_modules\prebuild\error.js:31:10)
prebuild ERR! build     at ChildProcess. (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\sodium-prebuilt\node_modules\prebuild\util.js:116:14)
prebuild ERR! build     at emitTwo (events.js:87:13)
prebuild ERR! build     at ChildProcess.emit (events.js:172:7)
prebuild ERR! build     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
prebuild ERR! build error
prebuild ERR! stack Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
prebuild ERR! stack     at ChildProcess.onExit (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\node-gyp\lib\build.js:276:23)
prebuild ERR! stack     at emitTwo (events.js:87:13)
prebuild ERR! stack     at ChildProcess.emit (events.js:172:7)
prebuild ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
prebuild ERR! not ok
prebuild ERR! build Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
prebuild ERR! build     at ChildProcess.onExit (C:\Users\User\Downloads\dat-desktop-master\dat-desktop\node_modules\node-gyp\lib\build.js:276:23)
prebuild ERR! build     at emitTwo (events.js:87:13)
prebuild ERR! build     at ChildProcess.emit (events.js:172:7)
prebuild ERR! build     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/datproject/dat-desktop/issues/122#issuecomment-270117902,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlemKtVRiedlUA6c2OadCMHUhEEDCeks5rOlIrgaJpZM4LZnyP
.

Ok, thank you for answer.


Misleading command invocation nvram.md/sealing

The "Sealing" section of nvram.md demonstrates the following command sequence:
$ tpm2_pcrread -o srtm.pcrvalues sha256:0,1,2,3
$ tpm2_createpolicy --policy-pcr -l sha256:0,1,2,3 -f srtm.pcrvalues -L srtm.policy
$ tpm2_nvdefine 0x1500019 -C o -s 32 -L srtm.policy -a "policyread|policywrite"
$ tpm2_nvwrite 0x1500019 -C 0x1500019 -P pcr:sha256:0,1,2,3=srtm.pcrvalues -i testfile
$ tpm2_nvread 0x1500019 -C 0x1500019 -P pcr:sha256:0,1,2,3=srtm.pcrvalues

You don't have to provide a file for tpm2_createpolicy, it will implicitly use the current values of the specified PCRs.
But you show a more general case, and that's fine.
However, the inclusion of "=srtm.pcrvalues" in arguments for the last two tpm2_nvwrite and tpm2_nvread commands is totally bogus,
and arguably should raise an error from the tpm2-tools parser. Obviously, when invoking those commands with a PCR policy, the contents of that are irrelevant. The source of the PCR values is (and must be) only the current state of the specified PCRs, on the device.

Thanks,
the course and those commands are pretty old now. At least when I wrote it
originally the above was the case.
I no longer work for Nokia, so I'm wondering what to do with that course
--- I've been teaching it at universities (or actually using that material
as part of the TPM part of my courses)....there's a book due out "real soon
now"
t.
Ian
On Mon, 1 Jul 2024 at 03:11, SharkOverBite @.***> wrote:

The "Sealing" section of nvram.md demonstrates the following command
sequence:
$ tpm2_pcrread -o srtm.pcrvalues sha256:0,1,2,3
$ tpm2_createpolicy --policy-pcr -l sha256:0,1,2,3 -f srtm.pcrvalues -L srtm.policy
$ tpm2_nvdefine 0x1500019 -C o -s 32 -L srtm.policy -a "policyread|policywrite"
$ tpm2_nvwrite 0x1500019 -C 0x1500019 -P pcr:sha256:0,1,2,3=srtm.pcrvalues -i testfile
$ tpm2_nvread 0x1500019 -C 0x1500019 -P pcr:sha256:0,1,2,3=srtm.pcrvalues
You don't have to provide a file for tpm2_createpolicy, it will
implicitly use the current values of the specified PCRs.
But you show a more general case, and that's fine.
However, the inclusion of "=srtm.pcrvalues" in the last two command, to
tpm2_nvwrite and tpm2_nvread is totally bogus,
and arguably should raise an error from the tpm2-tools parser. Obviously,
when invoking those commands with a PCR policy, this file is completely
irrelevant. The source of the PCR values is (and must be) only the current
state of the linked PCRs on the device.
—
Reply to this email directly, view it on GitHub
https://github.com/nokia/TPMCourse/issues/22, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHKY2MKEAHZ6UJB7U53LUM3ZKCNEDAVCNFSM6AAAAABKEQZHDSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DENJRG4YDCNY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I understand. There's still, after all these years, a great lack of good, well-written (I can't bold that enough), procedural documentation. This one is better than most, though quite focused on attestation use-cases (which I care less about).
I have verified that the commands work without specifying the file (as logically, they must, what are the semantics of attaching the file??). Since I've opened an issue on tpm2-tools, we'll have to see what they have to say about it.
Good luck with the book (when and if). If it's well-written, I'd love to read it.

Thanks,
yes, I certainly share your comment on a lack of procedural
documentation.   I worked extensively with attestation, hence the emphasis
there ( even wrote the "best" attestation server ever ! )
I'll probably fork the course and rewrite it over the next few weeks - will
go alongside the courses I teach and the upcoming "real soon now" book
t.
Ian
On Mon, 1 Jul 2024 at 18:11, SharkOverBite @.***> wrote:

I understand. There's still, after all these years, a great lack of good,
well-written (I can't bold that enough), procedural documentation about
TPM. This one is better than most, though quite focused on attestation
use-cases (which I care less about).
I have verified that the commands work without specifying the file (as
logically, they must, what are the semantics of attaching the file??).
Since I've opened an issue on tpm2-tools, we'll have to see what they have
to say about it.
Good luck with the book (when and if). If it's well-written, I'd love to
read it.
—
Reply to this email directly, view it on GitHub
https://github.com/nokia/TPMCourse/issues/22#issuecomment-2200423690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHKY2MIQYKJ7L5V3DFMEGADZKFWR3AVCNFSM6AAAAABKEQZHDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGQZDGNRZGA
.
You are receiving this because you commented.Message ID:
@.***>

Looking forward to the fruits of your many labors.

tpm2-software/tpm2-tools say I'm wrong, that it's not an error but an optimization which supposedly saves another step by the device IIUC. I don't understand their response to be honest.


Feat/dynamic log level

Feature or Problem
Today it's not possible to update the host's log level at runtime, which can make it impossible to debug issues which go away after restarts. This updates the host to listen on a subject and update its log level (and a companion subject for simply returning the current log level), which included a lot of plumbing. I also added wash logs get/set for good measure
NOTE: I tried to follow the subject convention outlined in https://github.com/wasmCloud/wasmCloud/issues/1108, so the new subjects might look out of place compared to the status quo.
Related Issues
Resolves https://github.com/wasmCloud/wasmCloud/issues/998
Release Information
Next, for core, tracing, control-interface, the host, wash-lib, and wash-cli 😅
Consumer Impact
N/A, new feature
Testing

Unit Test(s)

Acceptance or Integration

Manual Verification
Tested e2e with new builds:
./target/debug/wasmcloud
2024-01-29T23:21:50.310400Z  INFO async_nats::options: event: connected
2024-01-29T23:21:50.310410Z  INFO async_nats::options: event: connected
2024-01-29T23:21:50.311812Z  INFO wasmcloud_host::wasmbus: bucket already exists. Skipping creation. bucket=LATTICEDATA_default
2024-01-29T23:21:50.312093Z  INFO wasmcloud_host::wasmbus: bucket already exists. Skipping creation. bucket=CONFIGDATA_default
2024-01-29T23:21:50.315665Z  INFO wasmcloud_host::wasmbus: wasmCloud host started host_id="NAHSIKVUXY6THUZRHNG2KWCR725CRT3YEN2XWSDB62DDYOID6BYS4NLR"
2024-01-29T23:22:16.507724Z  INFO wasmcloud_host::wasmbus: updating log level level=Trace
2024-01-29T23:22:16.510618Z TRACE wasmcloud_host::wasmbus: handled control interface request
2024-01-29T23:22:20.281526Z TRACE heartbeat: wasmcloud_host::wasmbus: generating heartbeat
2024-01-29T23:22:20.281713Z TRACE heartbeat:inventory: wasmcloud_host::wasmbus: generating host inventory
2024-01-29T23:22:50.269039Z TRACE heartbeat: wasmcloud_host::wasmbus: generating heartbeat
2024-01-29T23:22:50.269222Z TRACE heartbeat:inventory: wasmcloud_host::wasmbus: generating host inventory

~/wasmcloud/wasmcloud/target/debug/wash logs get snowy

Host `snowy-dream-3908` configured with log level `info`

~/wasmcloud/wasmcloud/target/debug/wash logs set snowy -l trace

Host `snowy-dream-3908` configured with log level `trace`

@brooksmtownsend I assume we want to revisit this post 1.0?

I think so, this feels like a good change to be able to make even with our idea of hosts being cattle not pets. The conflicts seem to be pretty huge at this point so it would be worth re-doing


Gradle updates

This PR will update some the gradle stuffs that can be better represented

[ ] Introducing token replacement.
[x] Update HEADER.txt
[ ] More organised build.gradle
[ ] PluginInfo class for storing token values from blossom.
[ ] Remove forge repo

There is no value to having such a chunk of text at the top of every file, IMO. it's all in the referenced file. Is there a justification for having that at the top of every file?

However MIT'S does require that chunk of information in the header

It doesn't. It requires that the copyright notice be included with substantial parts of the software, that's not the same as in the file header.

Read the must section: https://tldrlegal.com/license/mit-license

"You must include the license notice in all copies or substantial uses of
the work.".
That's not the same as each file.
On Tue, 1 Mar 2016 at 14:59 Hunar Roop Kahlon<EMAIL_ADDRESS>wrote:

Read the must section: https://tldrlegal.com/license/mit-license
—
Reply to this email directly or view it on GitHub
https://github.com/EssencePowered/Essence/pull/7#issuecomment-190756751.

Alright I will revert that... Also will be closing this branch and opening one targeting master

To be clear - I'm not against changes like this, I just like a reasoned justification. However, my problems with such a huge licence header are:

They take up a huge amount of space in the file. IDEs often contract it, but it seems superfluous
Copyright law applies whether or not that notice is there - and so does the licence (note that I had to do some software law research a while ago so I've had experience!)

The shorter header states that we are licensed under the MIT licence. It has the added bonus of not needing to be updated as the year changes, or contributors, or anything like that. The work is covered whatever we choose to do.

It's fine.. If we want to update it in the future it's easy to do so no biggie


Problem with reading the position of wam-v

Hi,
for testing with my own controllers, I need information about the wamv's position.
Using ROS1 + Gazebo11 it works in general properly:
rostopic echo /gazebo/model_states/pose[17]
It was more difficult with ROS2 and Gazebo Garden to get it moving, but after a few more installations in the docker, thrusters also started up.
Now, in ROS2 and Gazebo Garden I don't know how to read the current position. The elements of the group
/wamv/pose
return either fixed values or other than "pose" in the "component inspector" in GazeboSim. How to read the position of the device correctly? BTW: GPS and IMU readings are working properly.

You need to enable the ground truth flag in the file wamv_gazebo.urdf.xacro.
<xacro:arg name="ground_truth_enabled" default="true" />

Thanks for your help.
Will this modification add fields for /wamv/pose? Because I still can't find something like .../pose/position?

Look for /wamv/sensors/position/ground_truth_odometry

I have no such topic like /wamv/sensors/position/...  .  Does anything else need to be done/compiled/whatever after changing the xacro content before relaunching the world?

It started working after installing the latest versions: Gazebo Garden, ROS Humble and vrx. What's more, the current version on my machine shows 90% "simulation speed," while the older version (less than a year old) shows only 60%. So it was worth refreshing the model.
Thanks for your help.

Hi I added the ground truth flag as above instruction but nothing shows up on my rqt graph for ros2 humble. Can you please help me with this?

@sontung1010
Is the topic available for you via ros2 topic list?
Maybe post your rqt-graph here.


TestHTTPRouteEssentials flakes

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Observed during 2.1 release. Happened on Enterprise Postgres (IDK what it is, but that particular job appears to get all the GH Actions flakes) once, cleared on re-run at https://github.com/Kong/kubernetes-ingress-controller/blob/a0f6eb48eed2f8f1d0b992adee61da70be902721/test/integration/httproute_test.go#L186-L187
Log snippet: flake.txt
Expected Behavior
No response
Steps To Reproduce
No response
Kong Ingress Controller version
No response
Kubernetes version
No response
Anything else?
No response

Another partial log, with only lines that look relevant here: flake2.txt
Curiously, we do successfully create the route AFAICT, it's just not actually routing, apparently.

One of the runs (trying to get another bad one/compare against non-debug runs to confirm) with additional debug logging failed because the route is present, but its service is unavailable:
2022-01-04T14:23:47.0876942Z     httproute_test.go:209: flake debug:
2022-01-04T14:23:47.0877774Z         status 503
2022-01-04T14:23:47.0879463Z         body: {"message":"failure to get a peer from the ring-balancer"}

In the problem run, we have an unusually long time between syncs. We sync before the parentRef is restored, test it for a few minutes unsuccessfully, and then complete another sync after:
2022-01-04T14:23:42.6621779Z time="2022-01-04T14:23:42Z" level=info msg="successfully synced configuration to kong." subsystem=proxy-cache-resolver
...
2022-01-04T14:23:43.5541961Z     httproute_test.go:177: putting the parentRefs back
2022-01-04T14:23:44.5619293Z     httproute_test.go:186: verifying that the Gateway gets linked to the route via status
2022-01-04T14:23:44.9233321Z 2022/01/04 14:23:44 http: TLS handshake error from <IP_ADDRESS>:42804: EOF
2022-01-04T14:23:45.4441181Z creating upstream httpbin.85ba31d6-4b64-413c-b18d-19b3ce3f32ab.80.svc
2022-01-04T14:23:45.5016512Z creating target <IP_ADDRESS>:80 for upstream 3ec82f27-611f-482f-b547-bbba6dfc90ed
2022-01-04T14:23:45.5606166Z creating service 85ba31d6-4b64-413c-b18d-19b3ce3f32ab.httpbin.824683935852
2022-01-04T14:23:45.5657437Z     httproute_test.go:189: verifying that putting the parentRefs back results in the routes becoming available again
2022-01-04T14:23:45.6063928Z creating route 85ba31d6-4b64-413c-b18d-19b3ce3f32ab.baea6767-3f42-4789-b2ab-697d1a432581.3384b4ab-ee62-48ed-9f18-398a72711630
2022-01-04T14:23:45.6554146Z time="2022-01-04T14:23:45Z" level=info msg="handling service for status update" name="\"85ba31d6-4b64-413c-b18d-19b3ce3f32ab.httpbin.824683935852\"" protocol="\"http\""
2022-01-04T14:23:45.6558937Z time="2022-01-04T14:23:45Z" level=info msg="handling status updates for kong route" route="\"85ba31d6-4b64-413c-b18d-19b3ce3f32ab.baea6767-3f42-4789-b2ab-697d1a432581.3384b4ab-ee62-48ed-9f18-398a72711630\""
2022-01-04T14:23:45.6563113Z time="2022-01-04T14:23:45Z" level=info msg="updating status for v1/Ingress" name=baea6767-3f42-4789-b2ab-697d1a432581 namespace=85ba31d6-4b64-413c-b18d-19b3ce3f32ab
2022-01-04T14:23:45.6582686Z time="2022-01-04T14:23:45Z" level=info msg="failed to retrieve v1/Ingress: the object is gone, quitting status updates" name=baea6767-3f42-4789-b2ab-697d1a432581 namespace=85ba31d6-4b64-413c-b18d-19b3ce3f32ab
2022-01-04T14:23:47.0876942Z     httproute_test.go:209: flake debug:
2022-01-04T14:23:47.0877774Z         status 503
2022-01-04T14:23:47.0879463Z         body: {"message":"failure to get a peer from the ring-balancer"}
... more of the same
2022-01-04T14:26:45.5675376Z     httproute_test.go:194:
2022-01-04T14:26:45.5676948Z            Error Trace:    httproute_test.go:194
2022-01-04T14:26:45.5677778Z            Error:          Condition never satisfied
2022-01-04T14:26:45.5678805Z            Test:           TestHTTPRouteEssentials
2022-01-04T14:26:45.5681204Z     httproute_test.go:147: cleaning up the httproute baea6767-3f42-4789-b2ab-697d1a432581
2022-01-04T14:26:45.5732048Z     httproute_test.go:104: cleaning up the service httpbin
2022-01-04T14:26:45.6124771Z     httproute_test.go:90: cleaning up the deployment httpbin
2022-01-04T14:26:45.6226942Z     httproute_test.go:75: cleaning up gateways
2022-01-04T14:26:45.6304969Z     httproute_test.go:46: cleaning up gatewayclasses
2022-01-04T14:26:48.6930373Z deleting route 85ba31d6-4b64-413c-b18d-19b3ce3f32ab.baea6767-3f42-4789-b2ab-697d1a432581.3384b4ab-ee62-48ed-9f18-398a72711630
2022-01-04T14:26:48.7628289Z deleting target <IP_ADDRESS>:80 for upstream 3ec82f27-611f-482f-b547-bbba6dfc90ed
2022-01-04T14:26:48.8543791Z deleting service 85ba31d6-4b64-413c-b18d-19b3ce3f32ab.httpbin.824683935852
2022-01-04T14:26:48.9254062Z deleting upstream httpbin.85ba31d6-4b64-413c-b18d-19b3ce3f32ab.80.svc
2022-01-04T14:26:48.9895382Z time="2022-01-04T14:26:48Z" level=info msg="successfully synced configuration to kong." subsystem=proxy-cache-resolver

That doesn't fully explain the story though, since the same thing happens in a run that gets past that part of the test:
2022-01-04T10:18:05.9309281Z time="2022-01-04T10:18:05Z" level=info msg="successfully synced configuration to kong." subsystem=proxy-cache-resolver
2022-01-04T10:18:09.9696632Z     httproute_test.go:174: putting the parentRefs back
2022-01-04T10:18:10.9819518Z     httproute_test.go:183: verifying that the Gateway gets linked to the route via status
2022-01-04T10:18:11.9858748Z     httproute_test.go:186: verifying that putting the parentRefs back results in the routes becoming available again
2022-01-04T10:18:14.4965499Z creating target <IP_ADDRESS>:80 for upstream 2a8bce42-43be-446d-b566-e6c225ceecc7
2022-01-04T10:18:14.9942497Z     httproute_test.go:189: deleting the GatewayClass
2022-01-04T10:19:00.4142361Z time="2022-01-04T10:19:00Z" level=info msg="successfully synced configuration to kong." subsystem=proxy-cache-resolver

Further confusing the issue is that the creating target message implies that deck received the event for the thing we need to fix the ring balancer error: https://github.com/Kong/deck/blob/v1.10.0/diff/diff.go#L348 fires before https://github.com/Kong/deck/blob/v1.10.0/diff/diff.go#L369
Do() there further does not spawn new goroutines and invokes the go-kong client function in the same goroutine several calls after:
https://github.com/Kong/deck/blob/27094f2333fc3aa380f5c926e88600dafc0db019/crud/registry.go#L105
https://github.com/Kong/deck/blob/27094f2333fc3aa380f5c926e88600dafc0db019/crud/registry.go#L61
https://github.com/Kong/deck/blob/27094f2333fc3aa380f5c926e88600dafc0db019/types/target.go#L30
It's possible that there's some thread pausing in Actions after the Do() call that we can't see (there are no logs after we can use to confirm). Kong access logs should confirm if this is the case, but we don't get those (not sure if there's an easy way to obtain them--I think we can with the KubeAPI client even if it's a bit annoying).
If that is the case I'm:

Unsure why only this test is affected since any config update delay should result in Eventually timeouts. IIRC some other tests wait for confirmation that config is live via status, which isn't possible with HTTPRoute since it updates status in the controller, without waiting for config to be live, but that doesn't really matter, since similar failures would just make the status Eventually time out.
Unsure if there's anything we can do about the flake. At best we wait for confirmation that the config update completes before testing the route, but that would also time out if it's slow.

but we don't get those (not sure if there's an easy way to obtain them--I think we can with the KubeAPI client even if it's a bit annoying).

I think given everything you've pointed out, and given the above comment specifically now might be a good a time as any to add a pre-cleanup function to the test suite that gathers the KIC and GW logs and stores those [as CI artifacts] for inspection, as this would be a generally helpful facility going forward in addition to being specifically helpful here.

Alright, apparently my initial thoughts were wrong. Not clear still why the sync completes so long after starting, but the individual requests to create the target have finished before the test starts (ignore my busted logging):
2022-01-05T09:02:23.4199955Z creating target <IP_ADDRESS>:80 for upstream f9eabae7-a5ed-4cbc-8efb-da63d80376c1
2022-01-05T09:02:23.4201542Z TRR starting Do() for target <IP_ADDRESS>:80 for upstream f9eabae7-a5ed-4cbc-8efb-da63d80376c1
2022-01-05T09:02:23.4202654Z TRR starting Create() for target {<nil> 0xc002e5a060 0xc002e5a070 0xc002e0d5f0 0xc00297b378 [0xc002e5a090]} for upstream 0xc002e5a080
2022-01-05T09:02:23.4761682Z TRR finished Create() for target {<nil> 0xc002e5a060 0xc002e5a070 0xc002e0d5f0 0xc00297b378 [0xc002e5a090]} for upstream 0xc002e5a080
2022-01-05T09:02:23.4763358Z TRR finished Do() for target <IP_ADDRESS>:80 for upstream f9eabae7-a5ed-4cbc-8efb-da63d80376c1
2022-01-05T09:02:23.4774555Z creating service 60c90b29-9f99-4b58-a918-daf563ddd6c6.httpbin.824680869404
2022-01-05T09:02:23.4776228Z TRR starting Do() for service 60c90b29-9f99-4b58-a918-daf563ddd6c6.httpbin.824680869404
2022-01-05T09:02:23.5298822Z TRR finished Do() for service 60c90b29-9f99-4b58-a918-daf563ddd6c6.httpbin.824680869404
2022-01-05T09:02:23.5312419Z creating route 60c90b29-9f99-4b58-a918-daf563ddd6c6.6e869b59-29c1-4fc3-b3cf-db63e4f0db0e.3613ca13-06f5-4d72-8190-3fc9ee42dfee
2022-01-05T09:02:23.5315603Z TRR starting Do() for route 60c90b29-9f99-4b58-a918-daf563ddd6c6.6e869b59-29c1-4fc3-b3cf-db63e4f0db0e.3613ca13-06f5-4d72-8190-3fc9ee42dfee
2022-01-05T09:02:23.5882007Z TRR finished Do() for route 60c90b29-9f99-4b58-a918-daf563ddd6c6.6e869b59-29c1-4fc3-b3cf-db63e4f0db0e.3613ca13-06f5-4d72-8190-3fc9ee42dfee
2022-01-05T09:02:23.9380405Z     httproute_test.go:209: flake debug:
2022-01-05T09:02:23.9381525Z         status 404
2022-01-05T09:02:23.9382313Z         body: {"message":"no Route matched with those values"}
2022-01-05T09:02:24.9409980Z     httproute_test.go:209: flake debug:
2022-01-05T09:02:24.9410697Z         status 503
2022-01-05T09:02:24.9412642Z         body: {"message":"failure to get a peer from the ring-balancer"}

I noticed we had a rather old version of Enterprise used via KTF and went to check changelog fixes for balancer bugs, since there's no good reason for this to occur:
2022-01-05T13:56:59.1000108Z     httproute_test.go:214: flake debug:
2022-01-05T13:56:59.1000762Z         status 503
2022-01-05T13:56:59.1002360Z         body: {"message":"failure to get a peer from the ring-balancer"}
2022-01-05T13:56:59.1004385Z     httproute_test.go:217: getting http://<IP_ADDRESS>:8001/upstreams/httpbin.99cfe4c5-a5a6-4de8-941c-93df32c5d06e.80.svc/targets
2022-01-05T13:56:59.1433619Z     httproute_test.go:228: upstream targets:
2022-01-05T13:56:59.1436660Z         {"data":[{"upstream":{"id":"8de0227d-deda-4383-8962-ebeb62fe8572"},"target":"<IP_ADDRESS>:80","created_at":1641391018.729,"id":"e04c74b6-7def-4a5e-843e-cf485b017c95","tags":["managed-by-ingress-controller"],"weight":100}],"next":null}
2022-01-05T13:56:59.1848405Z     httproute_test.go:239: upstream health:
2022-01-05T13:56:59.1853252Z         {"node_id":"546b2f46-5ce1-44a2-8565-b3d9a9069e00","data":[{"health":"HEALTHCHECKS_OFF","upstream":{"id":"8de0227d-deda-4383-8962-ebeb62fe8572"},"target":"<IP_ADDRESS>:80","created_at":1641391018.729,"id":"e04c74b6-7def-4a5e-843e-cf485b017c95","tags":["managed-by-ingress-controller"],"weight":100,"data":{"port":80,"dns":"A","host":"<IP_ADDRESS>","addresses":[{"port":80,"health":"HEALTHCHECKS_OFF","ip":"<IP_ADDRESS>","weight":100}],"weight":{"available":100,"total":100,"unavailable":0},"nodeWeight":100}}],"next":null}
2022-01-05T13:56:59.2914614Z     httproute_test.go:250: upstream list:
2022-01-05T13:56:59.2922797Z         {"data":[{"healthchecks":{"active":{"http_path":"/","https_sni":null,"healthy":{"http_statuses":[200,302],"interval":0,"successes":0},"unhealthy":{"timeouts":0,"interval":0,"http_statuses":[429,404,500,501,502,503,504,505],"http_failures":0,"tcp_failures":0},"concurrency":10,"type":"http","timeout":1,"https_verify_certificate":true},"passive":{"type":"http","healthy":{"http_statuses":[200,201,202,203,204,205,206,207,208,226,300,301,302,303,304,305,306,307,308],"successes":0},"unhealthy":{"timeouts":0,"http_failures":0,"http_statuses":[429,500,503],"tcp_failures":0}},"threshold":0},"hash_on_header":null,"created_at":1641391018,"hash_on_cookie_path":"/","hash_fallback":"none","hash_fallback_header":null,"hash_on_cookie":null,"host_header":null,"tags":["managed-by-ingress-controller"],"hash_on":"none","algorithm":"round-robin","id":"8de0227d-deda-4383-8962-ebeb62fe8572","client_certificate":null,"name":"httpbin.99cfe4c5-a5a6-4de8-941c-93df32c5d06e.80.svc","slots":10000}],"next":null}
2022-01-05T13:56:59.3808078Z     httproute_test.go:261: service list:
2022-01-05T13:56:59.3813328Z         {"data":[{"port":80,"created_at":1641391018,"updated_at":1641391018,"write_timeout":60000,"connect_timeout":60000,"id":"6ff7bc14-72f0-4633-a106-9f93f8ec622a","name":"99cfe4c5-a5a6-4de8-941c-93df32c5d06e.httpbin.824635535340","tls_verify_depth":null,"host":"httpbin.99cfe4c5-a5a6-4de8-941c-93df32c5d06e.80.svc","path":"/","protocol":"http","retries":5,"client_certificate":null,"read_timeout":60000,"tls_verify":null,"tags":["managed-by-ingress-controller"],"ca_certificates":null}],"next":null}

If you have targets, and they are not unhealthy, you should get a peer from the ring-balancer. Reading <IP_ADDRESS> reminded me of an old thorny internal issue report (FTI-2691), which affects the fairly specific situation where you use a non-default workspace (everything in the Enterprise test does) and repeatedly create and destroy the same upstream, which is exactly what we're doing here.
Don't think there's an easy way to prove that's the cause (would need to review the case to see if there's an indication in Kong logs, but we can't easily get those from CI yet) but it sounds too close to the mark and there's not really much of anything that looks like a controller-side race or likely flake cause here.