Unable to extract uploader id

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

:youtube-dl -U
youtube-dl is up-to-date (2021.12.17)

:youtube-dl "https://www.youtube.com/watch?v=oLV23rsdy4I" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=oLV23rsdy4I', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg N-74700-g628a73f, ffprobe N-74700-g628a73f
[debug] Proxy map: {}
[youtube] oLV23rsdy4I: Downloading webpage
[youtube] oLV23rsdy4I: Downloading MPD manifest
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\youtube.py", line 1794, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

French computer, windows 10 family. well known ID issue, but even with the last version, not working (i've seen https://github.com/ytdl-org/youtube-dl/issues/31530)

Read it, then, and do what it suggests. Or post your failing installation log. You are not running a fixed version.

Hello, I had the same issue, fixed by installing a youtube-dl version with git like explained here: https://github.com/ytdl-org/youtube-dl/issues/31530#issuecomment-1435477247

What I said, in fact, though git is not required.

His output shows 2021.12.17 which is the latest version as per the https://yt-dl.org/ website.

Same issue on latest version.
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://youtu.be/j__MFhKvGQA', '-s', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg 4.2.3, ffprobe 4.2.3
[debug] Proxy map: {}
[youtube] j__MFhKvGQA: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the la
test version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complet
e output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line
815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line
836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py"
, line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\youtube.py
", line 1794, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py"
, line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug .
Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbos
e flag and include its complete output.

Did try to update, however this is the latest release.

yt-dlp is working for me on windows

@SaintlyCoder, @Ytrog, @ississi: do actually read the response to the issue. Follow the link in the issue description to solve the problem.

Yeah I did. Basically the solution is to get the master version via git. It would be nice it it was to be resolved on the stable release and not requiring the users to basically construct a dev environment for this.

**Ytrog ** commented Jun 26, 2023 •

I can confirm this works
Download the compiled binary file and use that
Description
Ubuntu Linux, Python3.8

Read it, then, and do what it suggests. Or post your failing installation log. You are not running a fixed version.

I did it, and the tool reply me it is up to date.  Or maybe, such a clever dev in his tower...

"Make sure you are using the latest version; type  youtube-dl -U  to update"

-> ":youtube-dl -U
youtube-dl is up-to-date (2021.12.17)"

But no problem, i tool a serious tool (yt-dlp.exe) and everything works fine now. bye.

So you actually didn't read #31350, then.

"Read it, then, and do what it suggests.". yes, i read it. But I'm on Windows and don't know how to use git. And most of the documentation seems to be unix(variant) based. So after a while of digging I found an alternative solution with yt-dlp. Not my fault you don't help people who want to learn.

From other people's responses it seems that the relevant article wasn't clear/useful for them either. I couldn't work out how to make or find the latest windows exe. If someone could tell me how to do that from #3150 then that would be really useful, please. thanks.

thank you, I've pieced together what I hope are the relevant bits for me from all the posts involved :-)

Ahem, #31530. But apart from that it seems straightforward, if you've used hypertext before.

In read the Description below you follow the linked word Description.
In the Description you follow the linked word below in See below for ways to update to a fixed version.
That gives you the post that explains how to update your yt-dl, depending on the type of installation.

From your log you have a single file Windows build, so you need an unofficial nightly build of the same type: go to the site linked as example from If you want a single file executable .... Or, as you decided, you could install yt-dlp if it was suitable.

This tells me nothing, why refer to it if it doesn't contain steps that will resolve the issue?
The youtube video shows a person commenting out the uploaderID line in the python script and they copy and CD in to that directory to access the script.
When I try it, I get an error.
Everything else previous suggests methods that DO NOT EXIST on this linux install.
There is no brew or pip I tried the github thing as aswell and that downloaded and nothing happened to resolve the problem and despite downloading the yt-dlp program, my system says it does not exist.


chore(storybook): add storybook & stories

This PR adds Storybook back and includes basic stories for nearly all components in the UI.
Changes

Adds Storybook
Adds stories for most components
Refactors WaitingPage for easier testing

Relates to #1100 , but doesn't resolve it as I simply ran out of time.
Hopefully next steps for future work will include setting up mocking, reusing these stories to write unit tests for components, setting up visual diffing through Chromatic like we used to have, and setting up CI/CD to run these for PRs.

thanks Tomo!
@Delawen do you know how to disable files ending in .stories.tsx for DeepScan? I didn't see a workflow file for it or settings in the app either. is it that I need to create a config file?
I guess it might make sense for Codecov to ignore these as well since the components themselves are already covered by Codecov.


Reporting a small issue with code coloring when word type is present

From @RaviTezu on July 27, 2016 4:35

As you can see from the above image line Ftype String looks different(color)
I think, Ftype is interpreted as an actual keyword type and it is changing the color of the next word(string in this case). I have checked this against Default and other themes and I can reproduce this on Mac(OS X El Capitan) and Ubuntu(14.04).
vscode version: 1.3.1
Copied from original issue: Microsoft/vscode-go#408

The grammar for Go is contained inside VS Code and it hasn't been updated since a while. The version of the grammar shipped in VS Code is 0.39 and there is now version 0.42.1 available, we should update the grammar in VS Code.
Moving the issue to VS Code


Update cmake to 3.25.1

Changes from #28126 but triggers a new pipeline run

Probably won't be green on first run so you need to trigger a second one shortly after the first finished.
But I assume you know how vcpkg CI works and why it will be green in the second run ;)

But I assume you know how vcpkg CI works and why it will be green in the second run ;)

Please tell me :)

Please tell me :)

triggering a rebuild will most likely only rebuild the failing ports and as such stuff like file conflicts or non declared optional dependencies will no longer fail CI due to the partial rebuild.

Depends on #28485

I don't get why libphonenumber does not find protobuf-lite. It works locally. In the ci the protobuf-lite file is there and it already finds the header. I don't see a difference between the ci and my local setup.

/azp run

Re-run ci to get the latest error messages. :)

I don't get why libphonenumber does not find protobuf-lite. It works locally. In the ci the protobuf-lite file is there and it already finds the header. I don't see a difference between the ci and my local setup.

Check the names:
libphonenumber searches for protobuf which means protobuf.lib for MSVC.
protobuf installs  libprotobuf.lib and libprotobufd.lib.

Depends on https://github.com/microsoft/vcpkg/pull/28748

@FrankXie05 The last failure is a baseline regression. So maybe already add the review label?

Merge master for ci baseline regression.

@vicroms it would have been good if this pr would have been merged together with vcpkg_find_acquire_program pr since it would have halved the number of world rebuilds.
The only regression here was/is a know baseline regression which is also a leaf in the dependency tree.
How about adding a tag: Has/Shows/Discovers: baseline regression to not stop PRs from being looked at and being tagged as reviewed?

@FrankXie05 The baseline regression is still there...

@autoantwort we will solve this regression today.  :)

I'm ok with merging even with the existing regression on zeroc-ice, it will be addressed in another PR.

I'm ok with merging even with the existing regression on zeroc-ice, it will be addressed in another PR.

LGTM, waiting for the ci osx check to pass.


Can not register node.

I'd like to register a Debian 8 box in cloud.docker.com but failed. It's always "Waiting for contact from agent". Then, I did try to reinstall the latest dockercloud-agent, reviewed the config file, the run the agent in standalone mode.
dockercloud-agent -standalone -stdout
2016/05/22 23:23:52 Running dockercloud-agent: version 1.1.0
2016/05/22 23:23:52 Create pid file(/var/run/dockercloud-agent.pid): 10123
2016/05/22 23:23:52 Checking if config file exists
2016/05/22 23:23:52 Loading Configuration file
2016/05/22 23:23:53 New TLS certificates generated
2016/05/22 23:23:53 Downloading docker binary...
2016/05/22 23:23:53 Downloading docker definition from
2016/05/22 23:23:53 Cannot get target definition: Get : unsupported protocol scheme "". Retry in 1 second
2016/05/22 23:23:54 Cannot get target definition: Get : unsupported protocol scheme "". Retry in 2 second
2016/05/22 23:23:56 Cannot get target definition: Get : unsupported protocol scheme "". Retry in 4 second
2016/05/22 23:24:00 Cannot get target definition: Get : unsupported protocol scheme "". Retry in 8 second
2016/05/22 23:24:08 Cannot get target definition: Get : unsupported protocol scheme "". Retry in 16 second

I have the same issue.
2016/06/30 10:28:28 Running dockercloud-agent: version 1.1.0
2016/06/30 10:28:28 Create pid file(/var/run/dockercloud-agent.pid): 2113
2016/06/30 10:28:28 Checking if config file exists
2016/06/30 10:28:28 Loading Configuration file
2016/06/30 10:28:28 Registering in Docker Cloud via POST: https://cloud.docker.com/api/agent/v1/node/
2016/06/30 10:28:30 Registration failed, 402. Retry in 1 seconds
2016/06/30 10:28:32 Registration failed, 402. Retry in 2 seconds
2016/06/30 10:28:35 Registration failed, 402. Retry in 4 seconds
2016/06/30 10:28:40 Registration failed, 402. Retry in 8 seconds
2016/06/30 10:28:46 Running dockercloud-agent: version 1.1.0
2016/06/30 10:28:46 Found pid file, make sure that dockercloud-agent is not running or remove /var/run/dockercloud-agent.pid
2016/06/30 10:28:49 Registration failed, 402. Retry in 16 seconds
2016/06/30 10:28:53 Running dockercloud-agent: version 1.1.0
2016/06/30 10:28:53 Found pid file, make sure that dockercloud-agent is not running or remove /var/run/dockercloud-agent.pid
2016/06/30 10:29:06 Registration failed, 402. Retry in 32 seconds
2016/06/30 10:29:39 Registration failed, 402. Retry in 64 seconds
2016/06/30 10:47:36 Running dockercloud-agent: version 1.1.0
2016/06/30 10:47:36 Create pid file(/var/run/dockercloud-agent.pid): 10052
2016/06/30 10:47:36 Checking if config file exists
2016/06/30 10:47:36 Loading Configuration file
2016/06/30 10:47:36 Registering in Docker Cloud via POST: https://cloud.docker.com/api/agent/v1/node/
2016/06/30 10:47:37 Registration failed, 402. Retry in 1 seconds
2016/06/30 10:47:39 Registration failed, 402. Retry in 2 seconds
2016/06/30 10:47:42 Registration failed, 402. Retry in 4 seconds
2016/06/30 10:47:48 Registration failed, 402. Retry in 8 seconds
2016/06/30 10:47:57 Registration failed, 402. Retry in 16 seconds
2016/06/30 10:48:14 Registration failed, 402. Retry in 32 seconds
2016/06/30 10:48:47 Registration failed, 402. Retry in 64 seconds
2016/06/30 10:49:05 Running dockercloud-agent: version 1.1.0
2016/06/30 10:49:05 Create pid file(/var/run/dockercloud-agent.pid): 10105
2016/06/30 10:49:05 Checking if config file exists
2016/06/30 10:49:05 Loading Configuration file
2016/06/30 10:49:05 Registering in Docker Cloud via POST: https://cloud.docker.com/api/agent/v1/node/
2016/06/30 10:49:07 Registration failed, 402. Retry in 1 seconds
2016/06/30 10:49:10 Registration failed, 402. Retry in 2 seconds
2016/06/30 10:49:14 Registration failed, 402. Retry in 4 seconds
2016/06/30 10:49:19 Registration failed, 402. Retry in 8 seconds
2016/06/30 10:49:28 Registration failed, 402. Retry in 16 seconds
But then .. nothing ... after another 15 minutes.
I have been TRYING to find a way to completely start over. I am using a FRESH INSTALL of Ubuntu Server 15.04 LTS. No firewalls on a static IP. I am. Do we need to be editing documents to show what is required ahead of time? I mean, i've tried so many different ways to install docker, including docker.io, docker-machine, docker-engine... i just don't understand at this point why so many people have this problem yet nothing seems to be documented.
I have only been successful in registering a node in docker-cloud but on Ubuntu Service 16.04 LTS, but only after a bunch of different methods. I actually installed "experimental" release of docker only to have Docker-agent install and remove it and drop in another version of docker. The sad part was that after attempting to add the -g /data portion to my DOCKER_OPTS in /etc/defaults/docker, the service completely failed and never could be resurrected again.

@maietta
402 Payment Required  which means you can only provision one free node without setting the billing info.  If you need to configure more nodes, you need to go to the Web UI and complete the your billing info.
Thank you

This also is a problem on Ubuntu 17.04 Zesty but unfortunately at time of writing there is no published sysv-rc package for zesty :(
https://packages.ubuntu.com/search?keywords=sysv-rc


Remove package lark-stubs from setup.py

The package was removed in PR lark-parser/lark#926.  pip fails when trying to install lark upstream:

error: package directory 'lark-stubs' does not exist

It does work with this change.

One note: This change is also made in #996 (currently open).

Closing in favor of #996.  I've checked if there's another PR before opening this, but didn't see it.


update RGD file name

Pointing to the latest RGD file on S3 bucket.

Looks like the same error as the previous PR. Perhaps these is a problem with their file?
Extracting files from (tmp/RGD_0.6_4.tar.gz) ...
Traceback (most recent call last):
  File "fetch_test_index.py", line 7, in <module>
    al.load_from_mods(test_set = True)
  File "/home/travis/build/alliance-genome/agr/indexer/src/loaders/aggregate_loader.py", line 56, in load_from_mods
    for gene_list_of_entries in genes:
  File "/home/travis/build/alliance-genome/agr/indexer/src/mods/human.py", line 27, in load_genes
    TARFile(path, "RGD_0.6_4.tar.gz").extract_all()
  File "/home/travis/build/alliance-genome/agr/indexer/src/files/tar_file.py", line 13, in extract_all
    tfile = tarfile.open(self.path + "/" + self.tarfilename, 'r')
  File "/opt/python/2.7.12/lib/python2.7/tarfile.py", line 1678, in open
    raise ReadError("file could not be opened successfully")
tarfile.ReadError: file could not be opened successfully
make: *** [test_index] Error 1
make: Leaving directory `/home/travis/build/alliance-genome/agr/indexer'


Bikeshed {Store, Scheduler}Config -> {Store, Scheduler}Spec

This non-functional change simplifies the naming for the configuration from "Config" to "Spec". This makes it clearer when we operate on Store implementations and configuration fragments. The new naming scheme is also closer aligned with common K8s intuition and a bit shorter to type.

This change is

I think we can agree that we should delay spending a lot of cycles on this PR until we solve other more important priorities, cc @bclark8923

lol @ "bikeshed" reference. That's what it is, though.


Update README.md

CTI Search Engine(CriminalIP) Update

Hi,
I truly love the website you shared with me!
I really appreciate the fact, that there is a free option, so the user don't have to have a budget to use the app.
Just, please give me some time to implement connector on the develop branch which is going to be a new master. (Current master will be deleted).


Zuul with Java 1.7.0 Update 121 and greater causes java.util.zip.ZipException

Spring Boot 1.5x with Zuul reverse proxy
Example url passed into Zuul:

https://xxx.xx.x.x/core/api/endeavour/session?screenInfo=1

Here is the stack trace from Zuul:
Caused by: java.lang.reflect.UndeclaredThrowableException: null
at org.springframework.util.ReflectionUtils.rethrowRuntimeException(ReflectionUtils.java:317) ~[spring-core-4.3.10.RELEASE.jar!/:4.3.10.RELEASE]
at org.springframework.cloud.netflix.zuul.filters.post.SendResponseFilter.run(SendResponseFilter.java:115) ~[spring-cloud-netflix-core-1.3.2.RELEASE.jar!/:1.3.2.RELEASE]
at com.netflix.zuul.ZuulFilter.runFilter(ZuulFilter.java:112) ~[zuul-core-1.3.0.jar!/:1.3.0]
at com.netflix.zuul.FilterProcessor.processZuulFilter(FilterProcessor.java:193) ~[zuul-core-1.3.0.jar!/:1.3.0]
... 64 common frames omitted
Caused by: java.util.zip.ZipException: invalid code lengths set
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164) ~[na:1.7.0_161]
at java.util.zip.GZIPInputStream.read(GZIPInputStream.java:116) ~[na:1.7.0_161]
at java.io.FilterInputStream.read(FilterInputStream.java:107) ~[na:1.7.0_161]

Please learn how to properly format code and logs.
Is it specific to that version of java? Can you provide a sample that recreates the issue?

It seems to be specific to JDK versions higher than 1.7.0 Update 111. We do not see this behavior with JDK versions lower than and including Update 111.
I will see if I can easily reproduce this is a very simple environment.

Spencer,
we have the following configuration: Angular GUI is sending API requests to ZUUL which then forwards the request to APIs running in the Virgo application container. The Virgo application container uses Tomcat and SpringDM. We are reviewing the following:

Virgo/Tomcat is configured to use compression. So we will disable compression to see if there is a change in behavior.
We are reviewing the following JDK bug to see if that is related as well: https://bugs.openjdk.java.net/browse/JDK-8189789

Another simple test would be to use jetty instead of tomcat.
I'm going to close this as it doesn't appear to have anything to do specifically with zuul. Feel free to reopen in there is new evidence.

After disablling compression within Tomcat we no longer see the problem. It seems there is a bug in the Oracle JDK for versions between and including  1.7.0 U121 and 1.7.0 update 161.


bump react-redux to v8.1.2: Super expression must either be null or a function

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

React: 18.2.0
ReactDOM: 18.2.0
Redux:5.0.1
React Redux:8.1.3

What is the current behavior?
My current project needs to upgrade react-redux to 8.1.3.But after the upgrade, my app is inaccessible, and an error occurs: Super expression must either be null or a function. My previous version is 5.1.2, and it loads normally in 5.1.2.
But in the official documentation, I see that connect still works and is supported in React-Redux 8.x.But I got the error.
class Connector
export default class Connector {
	constructor(TheComponent) {
		bindThis(this);
		const that = this;
		this.name = TheComponent.name || TheComponent.displayName;

		const WrappedComponent = connect(
			this.mapStateToProps,
			this.mapDispatchToProps,
			this.mergeProps,
		)(TheComponent);

		class Wrapped extends WrappedComponent {
			constructor(props, context) {
				that.store = props.store;
				super(props, context);
			}
			UNSAFE_componentWillMount() {
			 	// adding resources and reducers used in a component to StoreService
			}
			componentWillUnmount() {
			 	super.componentWillUnmount();
			}

			componentDidMount() {
			 	super.componentDidMount();
			}
		}
		return Wrapped;
	}
}

class ActionsAsideConnector
export class ActionsAsideConnector extends Connector {
	mapStateToProps(state) {
		return {
			actions,
			documentId,
			userToMatching,
			userIdSuggestions,
		};
	}
	mapDispatchToProps(dispatch) {
		return {
			closeInfoHandler: () =>dispatch(asidesInstance.triggerAction(xxxxxxxxxx, CLOSE)),
		};
	}
	mergeProps(stateProps, dispatchProps, ownProps) {
		return {
			...stateProps,
			...ownProps,
		};
	}
}

export default new ActionsAsideConnector(ActionsAside)

ActionsAside
const ActionsAside = ({
	closeInfoHandler,
}) =>
		<div>
			<InfoAside
				title={infoTitle}
				isOpen={isInfoOpen}
				closeHandler={closeInfoHandler}
			/>
		</div>
	)

ActionsAside.propTypes = {
	infoTitle: PropTypes.string,
};
ActionsAside.defaultProps = {
	isInfoOpen: false,
};
export default ActionsAside;

What is the expected behavior?
The app can be loaded normally on the v8.1.2
Which browser and OS are affected by this issue?
chrome/macos
Did this work in previous versions of React Redux?

[ ] Yes

From 5.1.2 to 8.1.2 is three major versions - have you checked the release notes for each major release to make sure there's no breaking changes you've missed?

Yeah, extending other components has always been an anti-pattern - see https://legacy.reactjs.org/docs/composition-vs-inheritance.html#so-what-about-inheritance


Indicate if Task Exited

Both tasks exited, but the list to the right does not reflect this.
I would expect the checkmark and error icon to disappear.

Hmm, I think the actual issue is that deemon reports the exit code 0 when killed :(
Still, I think this feature would be very useful. By looking at the terminal overview, it should be easy to see if a task is still running or exited.

Not saying there isn't a bug in deemon... but unsure if this is related to that.
I think the list still shows simply cause the terminals are still open. The list could render something else... but that wouldn't make sense in simple compile tasks, in which you still want to see the result color in the list, after the task ended.


crafting quest objective does not register crafting an item

I cannot complete the stone torch quest despite crafting multiple stone torches using both a crafting table and a crafting station

Shouldn't be my issue, I've tested this multiple times.
Should be related to how AOF setup the quests, if the item detection mode is precise, the amount of the item crafted matters.
For example, if you craft planks, you will get 4 back, and the quest should be set up to handle exactly 4 planks.

This is on me... Will fix in alpha 2


Images are rendered incorrectly on the host app

Environment
"@callstack/repack": "^2.5.2"
"react-native": "0.68.1"
Description
I'm using Callstacks repack to build a bunch of widget apps which will be exposed as components and a rendered on the host app. The whole setup seems to be working well except that the images used in a widget are not rendered correctly on the host app; Instead it renders fallback images ( not sure where these are coming from ). I am using React Native's Image component to display the image. Here's what I mean:
Widgets app:
import {Text, View, StyleSheet, Image} from 'react-native';

<View style={[styles.container, styles.shadow]}>
      <Image source={require('./icons/leaf.png')} />
</View>

and so it renders:

Note: Used images as pngs of all sizes : 1x, 2x, 3x, 4x
But when The widget is loaded in the host app through webpack, it displays a completely different image:

Reproducible Demo
Webpack config is the same that comes out of the box. Adding the asset specific config here:
webpack.config.ts
 {
        test: ReactNative.getAssetExtensionsRegExp(
          ReactNative.ASSET_EXTENSIONS,
        ),
        use: {
          loader: '@callstack/repack/assets-loader',
          options: {
            platform,
            devServerEnabled: devServer.enabled,
            /**
             * Defines which assets are scalable - which assets can have
             * scale suffixes: `@1x`, `@2x` and so on.
             * By default all images are scalable.
             */
            scalableAssetExtensions: ReactNative.SCALABLE_ASSETS,
          },
        },
},

Any suggestions or ideas on this? Thanks

Using any kind of static assets from remote chunks is a known limitation of repack, please see that comment for more context and possible workarounds.

@syed-mustaqhim Any luck with what I've suggested in the comment above?

@syed-mustaqhim – Good news, thanks to @jbroma great work (#331) we have first-class support for remote assets. Please check it out :)


Set default prompt for ui_select to match the official doc

The doc says:

prompt (string|nil) Text of the prompt.
Defaults to Select one of:

Ty @leiserfg, looks great!
Do you know where I can test this? I tried with spell fix (z=) but it seems to not yet work with vim.ui.select - couldn’t find anything else other than code actions that uses the new menu.

I saw that https://github.com/mickael-menu/zk-nvim is using it.

https://github.com/Shatur/neovim-session-manager is also using it, maybe having a look at https://github.com/stevearc/dressing.nvim is worth it.

Merged, yysm @leiserfg for your conribution :-)


Part segmentation data

Thank you for such a wonderful project and would you mind to share the ShapeNet part segmentation dataset or data loader?

Sorry, we don't provide all experiment weights and data based on several reasons.

The ShapeNet part segmentation dataset is available on many places.
The dataloader and network for semantic segmentation can be easily modified from our current codes.
Better github page organization.


CSS prevents from moving notification to bottom

First thank you for sharing your work. I really appreciate your coding. It is clean and easy to understand.
Bug/Feature: In your CSS you force "top" definition to '-100px' which prevents moving notification to bottom of the page. Moving to bottom while not available in config option is easy. You only have to replace "top" by "bottom" in line 58 of your script
element.css('bottom', top + 'px');
element.css('right', right + 'px');

Note: I do not use LESS but SCSS, I placed https://gist.github.com/fulup-bzh/d3fe7a5e537bc5a46e3d a SCSS version of your LESS file. It is exactly the same expect that I remove dependencies to BootStrap [I'm using F5].
Request: would be nice to have an option to place notification at bottom of the page without hacking your javascript.

:+1: exactly. Would like to see an offset option as well.

#20

#21


feat: support backup packaging function

This PR adds support for the backup packaging function.
rationale
Additional files can be included, which may be user-modified configuration files. As-is, a package build using cargo-aur will overwrite any user-made changes to files that are contained in the package.
With this feature, files can be defined which may be user-modified. If a file is user-modified, the packaged file will be added as .pacnew and not overwrite any changes made by the user.
If a package is removed, and any packaged file is user-modified, a .pacsave file will be retained.
implementation
I extended the existing [package.metadata.aur] approach as to not get in the way of Cargo's default [package] and took a similar approach as to how the package() section is built up. This does duplicate that logic somewhat, but I suspect there may be other package functions that could piggy back of this approach in the future should there be a need for them.
I added relevant information in terms of usage in the README.

Thanks for this, I'll review as soon as I'm able. Note that there will likely be some merge conflicts once #30 goes in.

Should #30 get merged before this PR I'll revisit and adapt as needed, nw.


Update GremlinQuerySerializer.cs

Serialize order function not inserting the correct value.

Hi Guys,
fixed a bug with the Serialize Order function.


[plugins] When multiple projects are open in the IDE, the tool becomes unresponsive.

The issue is related to the plugins and processing the sent and received messaged in websocket.

Goals;

Web app only responds to the first project open in the IDE.

In future, we might add a feature to switch between projects OR support multiple projects.

Show a message on the web app to say which project is being analyzed.
[bonus] Disable the Mine Rules option from the context menu if the project is not the one analyzed by the tool.

Sure, will look into it.


L515 max distance overflow bug

Required Info

Camera Model
L515

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04

Platform
PC

SDK Version
2.36.0

Issue Description
I am using the L515, and as best I can tell there is a bug with distances over the 'max' showing up close to the camera. I'm guessing it's something like laser returns from a previous pulse are being measured, and thus they show up close because they have traveled farther than the 'current' pulse should have.
The included gif demonstrates what I'm trying to explain. The L515 is on a cart being pushed toward a wall. At first, the far wall shows up in roughly the middle of the hallway (based on the color of the depth map). It then gets closer and closer to the camera as the cart is pushed down the hall. Eventually the wall disappears when the sensor is at roughly its advertised max range, and then as the cart is pushed even closer, the wall reappears and snaps to the appropriate distance.
The 3D view then shows the same thing, but from the side angle it's possible to see that the 'back wall' is projected forward, floating in the middle of the hallway, and its corresponding points shrink down as the cart is moved, until they disappear and then snap to where they should be, at the appropriate size now that the projection is using the correct distance.

Hi @gwenger
It seems to me what you're seeing is expected.  There may be some tuning that can be done but it doesn't seem as though it would completely remove what you're seeing.
Adding some of our tuning documentation here:
https://www.intelrealsense.com/download/13061/
https://www.intelrealsense.com/optimizing-the-lidar-camera-l515-range/

Hi @gwenger
One other adjustment that we added in the latest FW <IP_ADDRESS> (https://dev.intelrealsense.com/docs/firmware-releases-l500?_ga=2.198145711.1816097581.1601920876-1479303487.1578600965) and SDK 2.39.0 update was the QVGA resolution.  The optimizing the lidar camera L515 range blog was updated also to include mention of this new depth resolution.  Have a go with this updated resolution to see if the situation improves for you.

Didn't have access to the device for a bit, finally got a chance to play around with it today. I installed Realsense Viewer v2.39.0 and updated the firmware to <IP_ADDRESS>. I put the device into the 'max range' preset and tested walking towards that same wall from my original gifs at the 3 possible resolutions. Basically the higher resolution, the closer that 'rollover' behavior occurs where the wall pixels snap to the correct depth.

1024x768 resolution -> rollover @ 7.5m
640x480 resolution -> rollover @ 9m
320x240 resolution -> here I actually hit the opposite wall (~14m) without rollover, but I found a longer hallway that exhibited the same behavior at the other resolutions and got the rollover to happen at about 15.5m

I guess I just don't understand why the distance rollover is expected behavior, and I especially don't understand why it's resolution dependent. If this is expected behavior, it seems like it limits the functionality of the device for things like mapping and navigation. I don't actually care about having terrific accuracy at these long ranges, but suddenly having an obstacle appear in front of my robot that's really just a projected image of a far away wall has caused some navigation failures, and I can't think of a way to get around that seeing as before the rollover occurs, the camera returns convincing data that there is an obstacle e.g. 1m in front of the device.


How do specify a last step ?

when you have just 3 steps how do i make the last step as style same as the 1st step ?

You could edit the
&:before {
  .chevron-comp(@border-color);
  right: -16px;
}
&:after {
  .chevron-comp(@wizard-background);
  right: -15px;
}

components to be the same and get the same look and feel on both sides.


 is not a valid SSR component

I'm getting
<ClickOutside> is not a valid SSR component. You may need to review your build config to ensure that dependencies are compiled, rather than imported as pre-compiled modules

Using
Sapper: 0.27.9
Svelte: 3.12.1

Installing ClickOutside as a devDependencie solve the issue.


lua: Add per filter config for Lua filter

Commit Message: Add per filter config support for Lua filter.
Make Lua filter can support route configuration. The original Lua filter can only be configured with a single Lua code. Lua filter can now configure multiple named Lua code in the filter configuration.
At the same time, in the route configuration, the user can choose to disable the Lua filter, or refer to a lua code in the filter configuration, or define the new lua code directly in the route configuration.
Additional Description:
Risk Level: Low
Testing: Added.
Docs Changes: TBA
Release Notes: Added.
Fixes: #9279  #3124

This PR is based on @dio 's work.
Lua per route config allows users to execute different Lua scripts in different routes. It also allows users to directly reference a Lua script in the global configuration.  The following is a typical configuration.
          http_filters:
          - name: envoy.lua
            config:
              inline_code: |
                function envoy_on_response(request_handle)
                  request_handle:headers():add("Global catchall","Delivery catch all")
                end
              source_codes:
                route1.lua:
                  inline_string: |
                    function envoy_on_request(request_handle)
                      request_handle:headers():add("Requested","route 1")
                    end
                    function envoy_on_response(response_handle)
                      response_handle:headers():add("Handled","route 1")
                    end
                route2.lua:
                  inline_string: |
                    function envoy_on_request(request_handle)
                      request_handle:headers():add("Requested","route 2")
                    end
                    function envoy_on_response(response_handle)
                      response_handle:headers():add("Handled","route 2")
                    end

              routes:
              - match:
                  prefix: "/route1"
                route:
                  prefix_rewrite: /anything
                  cluster: httpbin
                per_filter_config:
                  envoy.lua:
                    name: route1.lua    # Ref 'route1.lua' in global configuration.
              - match:
                  prefix: "/route2"       # No config and GLOBAL Lua script will be loaded.
                route:
                  prefix_rewrite: /anything
                  cluster: httpbin
              - match:
                  prefix: "/route4"
                route:
                  prefix_rewrite: /anything
                  cluster: httpbin
                per_filter_config:
                  envoy.lua:
                    disabled: true           # Lua filter is disabled
              - match:
                  prefix: "/route5"
                route:
                  prefix_rewrite: /anything
                  cluster: httpbin
                per_filter_config:
                  envoy.lua:
                    code:                        # Lua script embedded in the route
                      inline_string: |
                        function envoy_on_request(request_handle)
                          request_handle:headers():add("Requested","route in route")
                        end
                        function envoy_on_response(response_handle)
                          response_handle:headers():add("Handled","route in route")
                        end

@wbpcode please do not force-push in Envoy PRs. It makes reviewing your PR impossible.
Also, can you fix format errors? That will unblock the rest of CI.
Thank you!

@wbpcode please do not force-push in Envoy PRs. It makes reviewing your PR impossible.
Also, can you fix format errors? That will unblock the rest of CI.
Thank you!

Okay.

Any luck of this one getting reviewed and merged in?

I also appreciate it if you could elaborate on the changes introduced in this PR into a proper commit message. Thanks!

Thanks for your detailed review and I will try to update this PR ASAP. @dio

Thanks for your detailed review and I will try to update this PR ASAP. @dio

@wbpcode I also appreciate it if you could elaborate on the changes introduced in this PR into a proper commit message. Thanks!

I will.

I think you should do "merge master" as well. Thank you!

/retest

Force-pushed updated commit message. It should not affect the review.

It is ready now. @dio Hope you can review it again.

/wait

That's on me I ignored that comment.

A new commit has been updated. Please ignore force update. Both times are to solve the docs error introduced by modifying the field name (code -> source_code). It was a problem caused by my carelessness.
PS: Thank you very much for your patience. @dio

I am sorry that my English is very poor. Although there is no problem in reading, I have to rely on translation software for writing. If there is anything wrong with the following text, please point it out directly. I will try to make it as clear as possible.
Or there are some issues here that I haven't considered. Therefore, if you can explain in more detail what you think might be abnormal, it may help me better understand and solve this problem.
From a functional point of view, the introduction of route configuration does not bring too much management burden. If the Lua script is treated as a black box, in the past we had only one box to complete a function, and now there are multiple boxes to do different operations. Although the code/script in the box are different, the essence is not different. Both the lua script in the filter configuration and the lua script in the route configuration are ultimately abstracted as PerLuaCodeSetup objects.
From the perspective of configuration management, the route configuration of the Lua filter is not different from the route configuration of all other filters. The old lua_state is released along with the old configuration. ThreadLocalState guarantees thread safety for lua_state.
In summary, except for the different visible ranges, I did not see any difference between the Lua script in the route configuration and the Lua script in the filter configuration.
This weekend, I will strive to do more tests. If you have any scenarios that you think might be a problem, please suggest them.

Or there are some issues here that I haven't considered. Therefore, if you can explain in more detail what you think might be abnormal, it may help me better understand and solve this problem.

The issue is that I'm pretty sure you are attempting to modify TLS state from worker threads. The TLS system was not designed for this and I'm fairly sure it won't work.

This weekend, I will strive to do more tests. If you have any scenarios that you think might be a problem, please suggest them.

If you add an integration test that uses per-route config of various kinds I'm pretty sure you will find it doesn't work.

You're right. I got a lot of key things wrong. I've tested it with static configuration, but I haven't really tested it with dynamic configuration updates. I do need this feature, but it looks like it's time to rethink. Thank you very much for your reminding. @mattklein123
I'm really sorry for wasting your time and energy. Maybe a lot of things need to be reversed. @dio

You're right. I got a lot of key things wrong. I've tested it with static configuration, but I haven't really tested it with dynamic configuration updates. I do need this feature, but it looks like it's time to rethink. Thank you very much for your reminding. @mattklein123
I'm really sorry for wasting your time and energy. Maybe a lot of things need to be reversed. @dio

I'm really sorry for wasting your time and energy. Maybe a lot of things need to be reversed. @dio

It's not a waste of time, this is great work!
My suggestion is to modify this PR so that it only includes the name -> code mapping that is provided in the main filter config. Then, routes can reference the code by name. Keep the oneofs so that w can add direct code in the route later. This should "just work" because you can pre-load all of the code in the map when the main config loads. Let's land this part, and then we can work on the other part as it is more complicated?

So I looked into this and the discussion thread with @mattklein123 in the previous attempt.
This is my sketch as PoC of adding per route inline code: https://github.com/envoyproxy/envoy/compare/master...dio:lua-per-route-inline?expand=1 (still need to add tests etc).
                route_config:
                  name: local_route
                  virtual_hosts:
                    - name: local_service
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: "/VERSION"
                          route:
                            cluster: web_service
                          typed_per_filter_config:
                            envoy.filters.http.lua:
                              "@type": type.googleapis.com/envoy.extensions.filters.http.lua.v3.LuaPerRoute
                              inline_code: |
                                function envoy_on_request(request_handle)
                                  request_handle:headers():add("foo", "foo")
                                end
                                function envoy_on_response(response_handle)
                                  response_handle:headers():add("route", "1")
                                end
                        - match:
                            prefix: "/"
                          route:
                            cluster: web_service

                http_filters:
                  - name: envoy.filters.http.lua
                    typed_config:
                      "@type": type.googleapis.com/envoy.config.filter.http.lua.v2.Lua
                      inline_code: |
                        function envoy_on_request(request_handle)
                          request_handle:headers():add("foo", "foo")
                        end
                        function envoy_on_response(response_handle)
                          response_handle:headers():add("route", "global")
                        end
                  - name: envoy.filters.http.router
                    typed_config: {}

The idea is to have a map (in TLS) that tracks every function_ref that is added per Lua state in each worker.
So for every request to a specific route, when we have config_per_route:

Generate a signature.
Apply the script for that route to the current Lua state in that worker thread. It returns the function_ref for each registered function (envoy_on_request and envoy_on_response for that route). (need to handle when no request or response handler).
Track the function_ref using a map<signature, function_ref>.

The caveat is this map can grow larger (including the function that is being added to the Lua's runtime stack (as global-scoped "variables")). Probably need a timer to do sweeping.
WDYT? @wbpcode @mattklein123.

From @mattklein123:

My suggestion is to modify this PR so that it only includes the name -> code mapping that is provided in the main filter config

Yes, @wbpcode. I think we can land this one first. Let me know when you need my help. Cheers!

WDYT? @wbpcode @mattklein123.

I think this could work, but I also think that it might be better to have a callback that a filter config can register for on the main thread when the route table is updated? This would allow for pre-loading of code that can be referenced later at runtime on the worker?

/lgtm api

Thanks. In the next few days, I will be a little bit idle. I will modify this PR as soon as possible, remove the source_code from LuaPerRoute, and ensure that the code Map can work normally. Later, I will think carefully about how to implement the Inline source code in route config.

Or we can create a new Lua Script Factory Type that contains a unique TheadLocalState for each registered factory instance, which can be obtained by name, so that filter Config, and Route Config, can register their Lua Scripts with this factory instance and post a event to main thread to un-register themselves when they destruct.

'source_code' in LuaPerRoute has been removed temporarily and new integration test is added for LuaPerRoute. May be it needs to be reviewed again.  @dio @mattklein123
A new PR will be submitted after the design and implementation of inline Lua code in LuaPerRoute is completed.

It requires @envoyproxy/api-shepherds approval.

A new commit that reduced redundant code and updated integration test.

/retest

Please check CI and merge master.
/wait

/retest

hmmm, look some wrong with this windows ci.


Add non breaking space symbol to symulate space-bar space. Separate names with normal space.

Add non breaking space symbol to symulate space-bar space. Separate names with normal space.
JIRA link
TD-4177
Description
Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.
Screenshots
Attach screenshots on mobile, tablet and desktop.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:

[ ] Run the formatter and made sure there are no IDE errors
[ ] Written appropriate unit tests for the changes, including:

accessibility tests for new views
tests for new controller methods
tests for new or modified API endpoints

[ ] Manually tested my work with and without JavaScript
[ ] Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
[ ] Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:

doc_1_here

[ ] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
[ ] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

The non-breaking space symbol may be replaced with a different implementation in the future


small update to directives to use service for comparing params.

Current coverage is 37.44% (diff: 100%)

Merging #145 into develop will increase coverage by 1.39%

@@            develop       #145   diff @@
==========================================
  Files           228        257     +29
  Lines         12768      13856   +1088
  Methods           0          0
  Messages          0          0
  Branches       2159       2325    +166
==========================================
+ Hits           4603       5188    +585
- Misses         7592       7946    +354
- Partials        573        722    +149

Powered by Codecov. Last update 9e533cf...3e5d34b


RFC: Deprecate and remove RandomGenerator::generateEntropy

Affected Version
4.3.x / 5.0
Description
Currently this function takes the function random_bytes and uses it to generate 64 bytes of entropy and converts it into a 128 bytes of hexadecimal. Given that random_bytes generates the same errors as this method when there is not a genuine source of CSPRNG it seems this method is pretty useless - and also a little misleading as you get 128 bytes but only 64 bytes of entropy. Additionally the docblock indicates you get an ASCII string (implying base64?) but you actually only get base16.
Proposal
Deprecate this method
Replace usages with direct calls to random_bytes (only used in core by password encryptors AFAICT)
If this is unsuitable we should at least remove the bin2hex and indicate that it will just return random bytes.

From memory a bunch of the parts of this code are there for Windows support on older PHP versions. In SS4 (with PHP 5.6 as a minimum) we could definitely remove some of the legacy bits and introduce a more modern option, potentially with a polyfill if required

The random_compat polyfill is already a dependency 🙂 . It is true that a source of CSPRNG might be accessible on Windows but I think (from memory) PHP will throw an error in this case.

I've raised a PR at 8560 for consideration


Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[x] Android
[ ] UWP
[ ] .NET Standard

Version of Library
7.0.1
Version of OS(s) listed above with issue
Android 7
Steps to Reproduce

Create a dialog style on android
Override colorAccent in this style
Set the style as default for TimePromptConfig in the main activity

Expected Behavior
The style should change.
Actual Behavior
The style is not visibly changed.

It appears that the style id is being set on the alert dialog, but not on the child view/control rendered inside of it when building the dialog.

They have used alert dialog and setting time picker as view. Instead if they directly use time picker dialog this issue will get resolved.

Nevermind, this is an issue in our app. I'm able to change the style in the demo apps.


Add an enricher to include the contents of an existing page

Hello,
Would it be possible to create an enricher, such as @Page, that would include the contents of an existing page onto a separate journal entry?
For example, page A would have some content like:
hello I'm page A

And page B wants to not only reference page A, but repeat its contents inline so that:
this is page B, it's a cool page
@Page[<page A's ID>]

becomes:
this is page B, it's a cool page
hello I'm page A

And then, whenever the content of page A is updated, it automatically updates on page B as well.

Hey, Thank you for your feature request!
I think, that this is possible. Ill look into it, and if it is, its gonna be added to the module :)

Awesome, thanks! I can probably help, just not familiar with the foundry API yet.

So, i have implemented this feature for text, image and video pages, and it will be part of the 1.3.0 release
I have not implemented the pdf page yet, this might be added with a later update tho (depending on demand)
If you want (and know how) you can download the page-enricher branch and test the feature before official release

Outstanding, thanks very much! I'll give it a shot.


RuntimeError: Duplicate Correction name

Hi,
I am getting a correctionlib RuntimeError:
>>> import correctionlib
>>> correctionlib.__version__
'2.6.1'
>>> ceval = correctionlib.CorrectionSet.from_file('vll/scalefactors/EleMu/Muons/UL/2018/2018_trigger/Efficiencies_muon_generalTracks_Z_Run2018_UL_SingleMuonTriggers_schemaV2.json')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bockjoo/opt/cmsio2/cms/services/T2/ops/Work/AAA/vll-analysis.Coffea2024.6.1/lib/python3.12/site-packages/correctionlib/highlevel.py", line 373, in from_file
    return cls(open_auto(filename))
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bockjoo/opt/cmsio2/cms/services/T2/ops/Work/AAA/vll-analysis.Coffea2024.6.1/lib/python3.12/site-packages/correctionlib/highlevel.py", line 369, in __init__
    self._base = correctionlib._core.CorrectionSet.from_string(self._data)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Duplicate Correction name: NUM_IsoMu24_DEN_CutBasedIdMedium_and_PFIsoMedium

Here, the file used can be found from
https://gitlab.cern.ch/cms-muonPOG/muonefficiencies/-/blob/master/Run2/UL/2018/2018_trigger/Efficiencies_muon_generalTracks_Z_Run2018_UL_SingleMuonTriggers_schemaV2.json

The purpose of reading the json file was to read the trigger efficiency once the json file is read using this syntax (inputs, abseta and pt):
    sf_mu = ceval[key].evaluate(abs(mu_m.eta), mu_m.pt, "nominal")

So, I guess for now the name should be changed based on the input combinations with correctionlib 2.6.1.
But there was no RuntimeError with the correctionlib 2.3.3.
Thanks,
Bockjoo

This feature was added in #244 and the corresponding json should have failed validation. The Muon POG was notified in https://gitlab.cern.ch/cms-nanoAOD/jsonpog-integration/-/issues/32


Add ndim as a keyword argument to shapes to support creating empty layers

Description

Add ndim keyword arg
Move inferring ndim from data (from constructor to shapes utils)

Fixes issue #1257.
Currently it fails the serialization test. Not entirely sure why but I think it's expecting ndim to be a property, but it's simply a parameter.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[x] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

@sofroniewn would you mind checking the serialization test failures here? It looks like it's checking that the number of attributes is the same as the number of keyword arguments, which seems to me like it's too specific a test? But we didn't want to change it without fully understanding it.

@sofroniewn would you mind checking the serialization test failures here? It looks like it's checking that the number of attributes is the same as the number of keyword arguments, which seems to me like it's too specific a test?

Right now the serialization is checking an exact match with the __init__ and that a full round trip with the layer data reproduces the same layer. I've always thought this was quite nice, so every param in the _get_state dict appears in the main API and visa-versa.
I'd just go ahead and include ndim in the _get_state dict here https://github.com/napari/napari/blob/master/napari/layers/shapes/shapes.py#L1189 and then everything should pass fine without having to change the tests :-)

@sofroniewn

the serialization is checking an exact match with the __init__ and that a full round trip with the layer data reproduces the same layer.

I feel like the second test is the only needed one. This will be especially true once we start implementing @pwinston's refactor proposal of at-most 7 attributes per object. Having said that

I'd just go ahead and include ndim in the _get_state dict here

this is the fastest fix right now so I'm in favour of revisiting this discussion if it seems appropriate when refactoring. @DragaDoncila want to make this change and push? At which point @sofroniewn this will be ready for review!

That should be ready now @sofroniewn.


[Bug] PutObjectLegalHold and PutObjectRetention changes underlying S3 file

Calling PutObjectLegalHold and PutObjectRetention changes underlying S3 file for dockerized s3 mock.
Steps to reproduce:

Put any object in S3.
Call PutObjectRetention or PutObjectLegalHold on the object.
The contents of the object changes to the xml of the object retention request or legal hold request.

I‘m very sure we haven’t implemented that, yet, and the requests are being treated as normal PUT requests...
Would you be open for contributing that feature?

See #213
First, the S3Movk should not accept these requests, so that the local storage is not overwritten.
Then, a new handler method could be implemented that handles the requests mentioned here.
Then, several other handler methods that can modify / delete objects must respect the legal hold / object retention.

Half of this is implemented, Retention is next.

Took longer than expected, but we can finally close this issue. :)
Just released 2.6.0 adding support to handle these requests.


uno.config.mjs Error[modlue not found], import with relative path module

UnoCSS version
0.61.8
Describe the bug
Importing a module with a relative path in the configuration file gives an error module not found
Reproduction

System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It had been loading fine before, but after upgrading to the latest version it reported an error.

Yeah any updates after  0.61.4, anything in my Uno.config.js doesn't work/ not getting loaded.

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required

Yeah any updates after 0.61.4, anything in my Uno.config.js doesn't work/ not getting loaded.

As of now it's only a fallback version


Millet MIUI8 system inside open pdf link failed

Millet MIUI8 system inside open pdf link failed，
Has anyone ever met, emergency?

I have no idea what does your comment means. What failed? What error do you have?

Have found the problem, thank you

Please close resolved issue


Guid transformer

✓ Checklist:

[ ] This PR has been added to CHANGELOG.md (at the top of the list);
[ ] Tests for the changes have been added (for bug fixes / features);
[ ] Docs have been added / updated (for bug fixes / features).

Codecov Report

Merging #180 (178655a) into main (66103da) will decrease coverage by 0.66%.
The diff coverage is 29.78%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   86.83%   86.17%   -0.67%
==========================================
  Files          56       57       +1
  Lines        3989     4036      +47
==========================================
+ Hits         3464     3478      +14
- Misses        525      558      +33

Impacted Files
Coverage Δ

datanymizer_engine/src/transformers/mod.rs
100.00% <ø> (ø)

datanymizer_engine/src/transformers/uuid.rs
29.78% <29.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66103da...178655a. Read the comment docs.


convert status_dhcp_leases to fa

haven't found a good icon to differentiate between "add static mapping" & "add WOL mapping"
used 2 different types of fa-plus-square for now. (until someone has a better idea)

We need fonts-stupendous  :)
Merged.
Thanks.
Steve
Stephen Beaver | +1<PHONE_NUMBER>;239 |<EMAIL_ADDRESS>| www.netgate.com

On Nov 3, 2015, at 1:37 PM, heper<EMAIL_ADDRESS>wrote:
haven't found a good icon to differentiate between "add static mapping" & "add WOL mapping"
used 2 different types of fa-plus-square for now. (until someone has a better idea)
You can view, comment on, or merge this pull request online at:
https://github.com/pfsense/pfsense/pull/2023 https://github.com/pfsense/pfsense/pull/2023
Commit Summary
convert status_dhcp_leases to fa
File Changes
M src/usr/local/www/status_dhcp_leases.php https://github.com/pfsense/pfsense/pull/2023/files#diff-0 (20)
Patch Links:
https://github.com/pfsense/pfsense/pull/2023.patch https://github.com/pfsense/pfsense/pull/2023.patch
https://github.com/pfsense/pfsense/pull/2023.diff https://github.com/pfsense/pfsense/pull/2023.diff
—
Reply to this email directly or view it on GitHub https://github.com/pfsense/pfsense/pull/2023.


Building Neat fails with "file name too long"

Hi, thank you for this interesting project.
I tried to build the GCC and the LLVM version on Ubuntu 22.04, and for both the build process fails with this error:
/usr/bin/ld: cannot open output file .obj/macro_compiler142_module_std_macro_quasiquoting_addQuasiQuotingMacro_void_1_compiler142_module_neat_base_class_MacroState_425D990C8190F49E.77551.so: File name too long

Is there something I can try to make it work?
KR Axel

Thanks for the report! I'll try to repro this afternoon.
This is terrible, but can you try running it in a folder that's less deep in the filesystem, maybe? Like /tmp/neat? Linux's limits on filename length are surprisingly short.

Good idea and thank you for the fast answer.
Indeed, when I move the install dir to /tmp, compilation of the GCC version is successful.
Compilation of the LLVM version fails with some weird file not found error, where ld is looking in a completely unrelated directory.
/usr/bin/ld: /home/pahl/progs/swift/usr/bin/../lib/LLVMgold.so: error loading plugin: /home/pahl/progs/swift/usr/bin/../lib/LLVMgold.so: cannot open shared object file: No such file or directory
clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
command failed with 256
Assertion failed! Aborting.

But that might be due to my setup. I will try out the GCC version for now.
Thanks again for the tip.
KR Axel

Yeah I think that one is due to your setup. Swift probably ships its own LLVM that's gotten into the path..?

Should be fixed now - macro filenames should be significantly shorter.