Best practices when writing a kiara module

Since there is no other place for this yet, I'll  use this issue to add all the best practices (and other tips and tricks) I can think of for developing kiara modules here. This can then be either massaged in its own doc page, or maybe a FAQ-type page.

use imports only within the process method
Because import statements -- esp. for some of the scientific Python packages -- can take up a lot of time, it's best to not put import statements at the top of a Python module, but only within the process method (or any other method of a class if applicable). This way, the import is only called if it is actually used. Otherwise, even a kiara --help could take an extra second or two.

some useful insights are available via the review of the following PR: https://github.com/DHARPA-Project/kiara_plugin.topic_modelling/pull/4
I am trying to recap some of the points encountered via this first review (more best practices items might come over time and as more modules and reviews take place),
please correct me if needed @makkus

recommended packages for data processing are polars and duckdb (instead of pandas)

inputs need to be checked within the module with error handling, documentation of the expected input within module doc is not enough

automatic checks need to be resolved if they don't pass (a dedicated doc item to explain about these automatic checks may be useful (reminder added in #25 )

write unit tests when necessary (for example: when there is a statistical operation to test)
process not documented yet in detail via the test-related discussion item (#19), but it will be as soon as the use case is encountered

write "end-to-end module tests": this part is currently being documented via #19

inputs need to be checked within the module with error handling, documentation of the expected input within module doc is not enough
It's always good to do that, yes. Technically, kiara will check that the data type is correct (and the value is set if it is marked 'required', but there are a lot of cases where the generic validation that kiara can perform are not sufficient. So, in short: always make sure that you are getting valid input for your specific task at hand.

thanks,
I forgot to add something that was already discussed, but I don't remember what you said about type hints:
do they need to be included going forward in the context of module creation? if yes could you specify in which form (e.g. Pydantic)?  if they are not there, the checks will fail is that correct?

Well, in my opinion code in kiara plugins should be type-hinted, linted, etc. Since it's re-useable code, code quality requirements should be higher than what makes sense for Jupyter notebooks for example. But that's just my opinion.
For now, I've enabled both ruff and mypy checks by default whenever code is pushed to the 'develop' & 'main' branches on Github. I can disable them if that is the consensus.
Pydantic is a dependency, and it's using Python type hints at runtime to do some validation/schema-related stuff. That's different to what we are talking about here, mypy, which does run checks on the code and makes sure that type-hinted Python code is not doing anything it is not allowed to do. In my experience, it's a fairly good failsafe against writing stupid code, and it helped make my code better for sure.
I can't really give an introduction to Python type hints and using mypy here, but there are really good resources out there, like:

https://tushar.lol/post/mypy-guide/
https://mypy.readthedocs.io/en/stable/getting_started.html

Also, ChatGPT can help you with examples, errors, etc.
In the context of kiara plugins, everything should be setup, so as long as you have the dev_utils extras installed (pixi run install-dev-env before pixi shell, or if using pip pip install -e '.[dev_utils]) you should be able to do a mypy src/<folder> and get your code type checked.

Thanks,
Concerning the consensus, hints were discussed in #10. I had understood that hints were not to be made into a best practice item, but from more recent discussions on Slack, it seemed that it changed, this is also why I am asking here.
So, to recap: type hints are now recommended as a best practice and checks happen via mypy.

As I said, I can disable it if people think that is the right way to go about it. Should I?

As for the previous discussion, I think we only talked about type hints in the context of code examples in documentation, and I agree its a good idea to leave them out there.
Having them in re-usable plugin Python code is different though, and would need different considerations IMHO.

Ah yes indeed, perfect then, all is clear.

After doing some code reviews, I realized there is no information about how kiara does input validation, and what a module developer should validate themselves. So I'll try to summarize the situation here a bit, feel free to add your own experiences or tell me if something is unclear/doesn't make sense.
Basically, the first step that happens is the module developer creating the inputs schema. They specify the name of the input field, the type of each input, the documentation for the field (that is not important in this context), whether it has a default value if the user doesn't provide anything, and whether the field is 'optional'. Those last two interact in a way (assuming the user didn't specify an input):

if the field is not marked as 'optional' (the default if not specified in the field schema), but a default is set, the input value that arrives in the module 'process' method will have a value (the default), and the is_set propery is True  (in code, something like: if value.is_set: )
if a field is marked as 'optional' and doesn't have a default, and the user doesn't provide something, the input value will be 'not_set' (is_set is False)
if a field is marked as 'not optional', and a default is set, and no user input, the default is used (same as with before) and is_set is True
if a field is marked as 'not optional', and no default is set, and no user input, then kiara will raise an error before the 'process' method is even reached, since it's something it can verify independent of what happens within the process method

The second important thing to be aware of is that the inputs value in the process method is a map with the field name (string) as key, and a Value instance as value. This Value Python class wraps the actual data, in order to be able to record and display metadata, and to give the option to only load the actual data into memory bit by bit, or when needed. The actual (wrapped) data object can be accessed via the data property. You can get a single input value by using:
my_table = inputs.get_value_obj('table') # or whatever the field name is

You can get the wrapped data directly by either doing:
my_table_data = inputs.get_value_data('table')

Alternatively, as I said, you can use the data property (equivalent to above):
my_table_data = my_table.data

The type of my_table_data depends on the implementation of the (kiara) data type, in the case of 'table' it would be a KiaraTable instance. You can get that information using the cli:
kiara data-type explain table # or whatever data type you are interested in

Just be aware that the value is not the same as the value data.
All this has (hopefully fairly straightforward) implications on what the module developer needs to test. I'm going to split up the cases depending on what is specified in the schema for a field (in all cases, if there is a value, the developer can assume it is the correct type, so no need to check that):
field is not optional, default is set or not
The developer can assume that the field is set, otherwise kiara would have already thrown an exception.
field is optional, default is set
The developer can assume that the field is set, because if no user input happened, then kiara would have just used the default.
field is optional, no default
Here, the developer needs to do the check themselves, something like:
table = inputs.get_value('table')
if table.is_set:
   column_names = table.data.column_names
   ...
else:
   column_names = []
   ...

(what exactly happens depends on the module of course, this is just to demonstrate)
If you have an optional field with no default, you should in most cases feel the need to have a conditional like this, if you don't have one, ask yourself if you chose the right schema. In all other cases, no is_set check is needed, and you can always assume the field is set one way or another.
Sidenote: if is_set returns False, that means that the value.data property will return None, which should make it clear why you need that test, since None will never have the methods you'd like to access on your actual data.
There is a second validation step after this basic one where kiara can take over some of the work: validating that the value (which we assume is set from here on out) is in a form that makes sense for the module.
For example if you expect a table to have a specific column, you need to check that it is available, and raise an Exception if it is not, ideally with a helpful error message so the user knows what exactly is expected.
Or if you have a string, you might need to test if it's an empty one. Stuff like that, which is not really difficult to what you have to do in 'normal' Python code anyway.
Kiara can't test this, because it doesn't know what it should test for. There is a possibility to specify the data type in more detail so that kiara can take over some of that validation, so keep that in mind and let me know if you ever think this would make your code significantly more streamlined. For now, I don't want to overcomplicate things, doing it like this is in most cases sufficient.

Thanks for the additional info about data types. I had indeed misinterpreted the previous comment when it was said:

So, in short: always make sure that you are getting valid input for your specific task at hand

Concerning type hints, when would we want them present in the specific context of a Kira module?
For example, do we need something like this:
sources_data: pa.Table = table_obj.data.arrow_table
if we know from the input specification that the variable is from a user input that is a table (from input doc).

In that case you only know the 'kiara data type', not the Python one. And type hints only relate to Python ones. This is where the critical thing happens:
table = value.data

(obviously this would apply to every other data type in the same way)
If you look up the data property of the Value class, you'll see that I marked it as Any, because the data can be of any type, depending on what is configured in create_inputs_schemas, and the type checker has no way of knowing what that is. So ideally, you'll help it by giving it a hint what you expect the value to be:
table: KiaraTable = value.data

From now on the type checker assumes it's an instance of KiaraTable, and if you call a method it doesn't recognize from this class, it will complain. So, yes, in short, it's good practice I think. Compare that with this case:
table_value = inputs.get_value_obj('table')

Here, the type checker knows for sure that table_value has the Python type Value, because that is the return type of get_value_obj, so you don't need to annotate table_value: Value, since the type checker already knows. Doesn't hurt to do it, but it's not necessary. I still sometimes do it, just to make myself aware of what Python type I'm dealing with.

Thanks,
I am not sure to understand how helpful it is to add a type hint that specifies that the value is a KiaraTable, since a KiaraTable can be a variety of things.
Wouldn't it be more helpful to specify what kind of table is needed (polars/arrow etc) instead, since this is what gives information about what is expected down the road? (but doing so would clash with a recommendation in the latest code review comments)

Sorry for the misunderstanding, it's specifically the Python class KiaraTable that I linked somewhere above. It is always that (if you specifiy table in create_inputs_schema), it can't be a variety of things. And from the KiaraTable you can sorta 'export' a variety of different Python classes that all represent tabular data in their own way, as a convenience. Type hinting / the type checker is only ever concerned about actual Python classes, it does not know anything about kiara or its concepts. Only about the classes that are used in its code.

Basically, the data attribute of a Value instance will always be KiaraTable if you spefieid table. It would be a bool if you specified boolean, or KiaraArray if you specify array, there is always a one-to-one mapping.
You can see the available data-types with kiara data-type list, and more importantly, which actual Python class the data attribute would be with kiara data-type explain table (or kiara data-type explain boolean, or kiara data-type explain file_bundle, etc.

Ok, I see,
Then probably, there would be simply a two-step process in terms of type hints, first the KiaraTable type hint (which is already self-explicit from the input type doc, so hint optional)
and then the specific table format used in the rest of the module's code.
table: KiaraTable = value.data
table_polars_format: pl.DataFrame = table.to_polars_dataframe()

Yes, it's a two step process, but it's the other way around to what you wrote. Maybe think of it from the perspective of the type checker. That's a 'pure Python' think, with no knowledge of kiara, so it has no idea that the table you specify in create_inputs_schema will result in a KiaraTable Python class. There is just no way it could, right?
The only way the type checker can know what type a variable is supposed to be is either by:

the user specifying it manually, in which case the type checker just trusts that statement
by looking at the result type of the method that produced the value the variable is assigned to

The latter is when you as a user doesn't have to worry, because whoever wrote the method you are using did the work for you (by specifying the output type). Some libraries don't have type hints, in which case you have to do the work manually still. Or the result type is of type Any or a Union (Optional is also technically a Union). This is where as a user you can either decide to:

specify the type hint manually, in which case, again the type checker trusts you and from that point onwards assumes it knows the type
write some code to test the type of the variable, this is most commonly done for Optionals, something like if var is None: raise Exception(). Or you do an isinstance, or whatever els makes sense in the specific circumstance you are in (the type checker is smart enough to disregard the 'None' of an Optional`Union[None, OTHER_TYPE]` after such a test, and assumes it deals with the other type

Long story short, because the data attribute is typed as Any, and the to_polars_dataframe as pl.DataFrame, this would be the minimum you could get away with in terms of manually specifying the type hints:
table: KiaraTable = value.data
table_polars_format = table.to_polars_dataframe()

(for all practical purposes, this is equivalent to what you had)
If you didn't specify the KiaraTable hint, the type checker could not be sure that the to_polars_dataframe method is available, since Any doesn't have that.

(I thought that it was the other way around, assuming the input documentation specified the type and thought this made it unnecessary for type hinting / redundant with type indicated in input doc)

Yeah, fair enough, don't blame you to get confused, lots of types of different types floating around :)


refactor(replace nats): add proto for the volume transport

Add Volume and Nexus Proto.
Move Protocol enum to common from replica as that is seemingly used in multiple protos.

Signed-off-by: Abhinandan-Purkait<EMAIL_ADDRESS>

Why are the proto files not in the mayastor-api repo?

I was under the impression that this repo was just for Mayastor - making it convenient for other components to consume the API. The control plane proto files are only consumed by other control plane components, so it seemed simpler to keep them in the one place.

bors merge


FF issue with caret position

Good day!
I have a strange behaivor it happens only in FF 47.0.
When i first click on textbox caret position sets on a last place and when click second time it goes at first place. Ho do i fix this?

@iamxor ,
Can you provide some more info.  Which version do you use and also which mask, options?

I'm also having this issue on Firefox. Reproduced on JSFiddle: https://jsfiddle.net/v5usz3vm/
When you click inside the input, caret is set on invalid position (after the space), while it should be set on the beginning of the input.
It makes input unwriteable without using keyboard arrows to set caret manually at the beginning.

Hi there.
jquery 1.9.1
jquery ui 1.10.3
jquery.inputmask.bundle.js 3.3.2-43
Firefox 47.0.1
Windows 10
here is the demo
https://www.youtube.com/watch?v=EfjSzovOgQ4

@stil ,
Your issue is something else.  This also occurs in other browsers.  (I will fix that also)
@iamxor ,
Can you still reproduce in version 3.3.2-105?

Sorry for late answer, yep suddenly still reproduced in Version: 3.3.2-106

@iamxor ,
On which device is the win10 firefox runing?  I cannot reproduce here

Is this related to the caret position jumping to the end when you minimize and then bring back FF in the foreground? This isn't normal behavior with regular inputs.


Wip: Raz/mgmt 1231 costum namespace

did u try to deploy to psi staging?

Rebase, the code base has changed.
Consider adding the namespace option to tools/deploy_options.py

Everything looks fine.
Although I prefer explicit set of a value instead of holding a variable inside of all the yamls and replacing it. It disallows to use a yaml without a script, and I think it's messier and might cause problems.
e.g.
        data["spec"]["template"]["spec"]["containers"][0]["image"] = image_fqdn

What do you think?

I strongly agree. I thought of some more elegant ways to do it (I think this is the best one).
But then I saw the scripts already override some yaml values in a very specific way (replace), and I wanted to be aligned with what we already have without refactoring these parts. This is way I did it like that.

Everything looks fine.
Although I prefer explicit set of a value instead of holding a variable inside of all the yamls and replacing it. It disallows to use a yaml without a script, and I think it's messier and might cause problems.
e.g.
        data["spec"]["template"]["spec"]["containers"][0]["image"] = image_fqdn

What do you think?

I strongly agree. I thought of some more elegant ways to do it (I think this is the best one).
But then I saw that the scripts already override some yaml values in a very specific way (__ replace __), and I wanted to be aligned with what we already have without refactoring these parts. This is why I did it like that.

I gave you one example from tools/deploy_assisted_installer.py. All the places used to do "replace" but it doesn't mean it's recommended. I suggest that if you have a better way - Don't just align yourself but make it better :)


flutter doctor is not realizing flutter.jar has been deleted

Steps to Reproduce
Using Flutter in Linux.

Delete
$FLUTTER_SDK/bin/cache/artifacts/engine/android-arm/flutter.jar
Realize nothing will ever build again
Run flutter doctor hoping to fix the problem
See that flutter doctor is very happy nevertheless.

How to rebuild flutter.jar by the way? flutter upgrade won't work either.
Thankx,

@febs did you try to delete whole cache folder? When you start to build something it recreated while Downloading android-arm tools....
btw, I tried it on mac, an apk was build with no errors without that flutter.jar.

Hello @febs !
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the issue, if you have any more information for us; we will reopen it right away!
Thank you for your contribution.
P.S. If anyone still experience the same problem, please file a new issue with the information required in the template.
All system setups can be slightly different so it’s always better to open new issues and reference related issues.


Fixed HTTP 500 errors

Fixed HTTP 500 errors on feed when accessing out-of-bounds page indices. Update version and readme, and added tests to make sure we can detect if that problem comes up again.

@ldko, @damonkelley, this is ready for review. Just fixes the HTTP 500 error that popped up if you manually tried to get a feed page index that didn't exist, like 0 or 400,000. Once this is merged in I'll bump tag the commit and bump versions to 0.1.1

Because of the weirdly named EmptyPage exception, I was looking at the Django paginator documentation and am thinking instead of 404ing, maybe we should give the first or last page of the feed as they exemplify when the page number doesn't exist.

Can you put a link to where you saw that recommendation? Also, we can still do that, but I'm thinking it would also be wise for me to catch the InvalidPage parent exception instead of the EmptyPage exception to also catch the instance where the page isn't an integer.

I was looking at this https://docs.djangoproject.com/en/1.8/topics/pagination/#using-paginator-in-a-view. Yeah, the InvalidPage  exception might be better then.

ah, right, I was on that page too, just further down lol. anyways, I'll make both those changes.

:+1:


having problem importing pywhatkit

Description
I was making a python ai project in my vs code. The installation of Pywhatkit was successful. But I don't know why whenever I import Pywhatkin into my program it shows this error message
"Exception ignored on calling ctypes callback function: <function catch_errors..call_with_this at 0x000001F4DFE60280>
Traceback (most recent call last):
File "C:\Python310\lib\site-packages\comtypes_comobject.py", line 91, in call_with_this
File "C:\Python310\lib\logging_init_.py", line 1505, in error
File "C:\Python310\lib\logging_init_.py", line 1734, in isEnabledFor
TypeError: 'NoneType' object is not callable"
I don't know how to fix this and a search about it but didn't find any solution. I don't know if it is a bug or not can any one please help me to overcome it?
Screenshots

Version Information

OS: [ Windows 11]
Browser: [Microsoft Edge]
Python: [ 3.10.2]
PyWhatKit: [ 5.3]

@anindya127  pip install pywhatkit==5.2
try rolling back to version 5.2

Ok i will try it let you know

@anindya127 pip install pywhatkit==5.2 try rolling back to version 5.2

Thanks 🙏 it's working 😀😀

@anindya127 it is a common problem of logging library


Registering Nodes with Flux

If we want to calculate gradients with respect to input, we should start by adding
Flux.@functor ArrayNode
Flux.@functor BagNode
Flux.@functor TreeNode

This allow Flux.params to return data nodes and we can calculate gradient with respect to it.

Closing as we've already done this a long time ago


Python: Don't send default prompt exec settings to the model

Motivation and Context
We are currently sending default request params to the model, and this isn't necessary. Only send non-default values.

Description
This PR:

leverages Pydantic's exclude_defaults=True flag to not send default values as part of the payload to the model.
Updates Azure Chat Prompt Execution settings to handle the type field differently now that we aren't including all default values in the payload.
Updates the default temp value from 0.0 to 1.0 which is what OpenAI lists as their default.
Fixes #6225

Contribution Checklist

[X] The code builds clean without any errors or warnings
[X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[X] All unit tests pass, and I have added new tests where possible
[X] I didn't break anyone :smile:

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingsemantic_kernel/connectors/ai/open_ai/prompt_execution_settings   azure_chat_prompt_execution_settings.py63198%96TOTAL6122105583%
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1310
1 :zzz:
0 :x:
0 :fire:
15.936s :stopwatch:

Going to handle this change in a different PR. Closing.


[VS Code] Starting collaboration session: Cannot read property 'isActive' of undefined

Error:
Starting collaboration session: Cannot read property 'isActive' of undefined
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.419

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.35.1

platformName
MacOS

platformVersion
18.6.0

Duplicate of #2301
We have a fix in the pipeline for this issue.


Add more consistency checks

Proposed changes
Improve consistency check of PDDL domains and problems instances.
Fixes
n/a
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[X] I have read the CONTRIBUTING doc
[X] Lint and unit tests pass locally with my changes
[X] I have added tests that prove my fix is effective or that my feature works

Further comments
n/a

Codecov Report

Merging #84 (f90b899) into main (f54e187) will increase coverage by 0.10%.
The diff coverage is 93.82%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.78%   90.89%   +0.10%
==========================================
  Files          24       30       +6
  Lines        1389     1493     +104
  Branches      245      260      +15
==========================================
+ Hits         1261     1357      +96
- Misses         93      100       +7
- Partials       35       36       +1

Flag
Coverage Δ

unittests
90.89% <93.82%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pddl/definitions/base.py
85.45% <85.45%> (ø)

pddl/validation/base.py
90.47% <90.47%> (ø)

pddl/_validation.py
91.48% <100.00%> (-0.58%)
:arrow_down:

pddl/core.py
92.18% <100.00%> (+0.06%)
:arrow_up:

pddl/definitions/__init__.py
100.00% <100.00%> (ø)

pddl/definitions/constants_def.py
100.00% <100.00%> (ø)

pddl/helpers/base.py
97.72% <100.00%> (+0.32%)
:arrow_up:

pddl/logic/predicates.py
95.37% <100.00%> (+0.80%)
:arrow_up:

pddl/logic/terms.py
92.98% <100.00%> (ø)

pddl/validation/__init__.py
100.00% <100.00%> (ø)

... and 1 more


Not working

After spent some hours configuring Guest Access with these steps, finally not working.
I think there must be another step not documented in this page.
Even, waiting recommended 24 hours for configuration refresh.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2296f91f-ac66-7d38-1aae-479bbcef9b87
Version Independent ID: db8bfc32-701d-c245-08ea-ec864da86c9d
Content: Collaborate with guests in a site
Content Source: Enterprise/collaborate-in-a-site.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@darwinpou - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let us know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution so we can get the applicable information you are discovering back into the docs.


The single-header code should be a build artifact, not in the github repo

I'm not an expert in handling this, but the single-header version surely shouldn't be in the repo. It's just an artifact of the other code. It should appear when we build.
Otherwise it's going to be constantly getting changed and needing to be 'merged' as a result of people making unrelated changes elsewhere in the code base.

It is a convenience thing. If you are building a wrapper or something around the code, and you want to use the single-header code, then it is super easy if you can just pull the project and get the single-header version right there.
Building it is possible, of course, but right now this is done with a bash script (amalgamation.sh). This assumes bash a few other tools as a dependency. It won't work under Windows. It won't work as part of other build tools (pip, go, rust crate, swift package manager).
Having it in the repo is not a requirement, of course, but not having to build it yourself is super nice.

I believe he means a build artifact as in a CI build artifact. circleci/travis/appveyor can all save arbitrary files from the results of jobs, and can very easily push the results to github as a a release (looks exactly like uploading to pypi with twine). It's just as convenient since since for example on circleci I can get a URL that always points to the latest build artifact for the master branch.

Nope, I actually meant in the git sense alone.
It just adds a bit of friction to any check-in, and I'm thinking it will be a real pain to merge multiple changes. But @lemire gives a good justification for why it's that way (the Windows and other build chains). So unless there's a wonderful way of dodging this problem.
However, I think TkTech's solution is the right one - our CI system could keep this up to date, no?

@geofflangdale I am not sure I grok the difference with what we do right now.
So, right now, the single-header code only gets changed manually. You have to call a makefile target (amalgamate) and then do a commit. If you don't type make amalgamate, the single-header code does not change.
I am trying to understand what you mean by...

It just adds a bit of friction to any check-in (...)

Unless you do make amalgamate, these files should not change. If they do, then something is wrong and we should fix that.
The only benefit in scripting this through CI is that it one less thing to do when issuing releases. However, that's a tiny step in the process of issuing a release and, frankly, our releases are super easy to do right now.

OK, I think I've been Doing It Wrong. I suppose I'm always nervous about having a single-header version that's not reflective of the latest code - just in case we have a performance blip or bug in the current code. So I always wind up updating the code via amalgamate, but I guess I should stop.

Speaking for myself, I have never run the benchmarks from the single-header version, but from the make code. It is possible, I suppose, that the single-header version could have different performance, but...

I meant that I might fix (or break!) something performance-related in the
main version, then have someone clag the out-of-date single-header version
and raise an issue that seems confusing from the perspective of what I
would view the "current state of the code" to be.
It's really just a symptom of being in a 'not quite released state' and
will go away when this is more solid (thus my closing of this issue).
On Wed, Mar 6, 2019 at 2:49 PM Daniel Lemire<EMAIL_ADDRESS>wrote:

Speaking for myself, I have never run the benchmarks from the
single-header version, but from the make code. It is possible, I suppose,
that the single-header version could have different performance, but...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lemire/simdjson/issues/106#issuecomment-469957444,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjaKC5l55NIpGbs_OpT8N0YGHXQNhcx8ks5vTzqygaJpZM4bfxea
.


add CI to test node 4

to prevent things like #2

Now that this is transferred, you should be able to enable...

added


Create a new coding agent like CodeAct that uses DSPy program optimization for improving the prompts.

What problem or use case are you trying to solve?
Create a coding agent that improves itself based on benchmarks.  In addition to (potentially) getting better agent performance this will also enable it to adapt optimally when using different LLMs (because the best prompts for each use case tends to be LLM-dependent).
Do you have thoughts on the technical implementation?
Basically clone CodeAct (openhands/agenthub/codeact_agent) and reimplement using DSPy (https://github.com/stanfordnlp/dspy).  The key design aspect of the agent is using DSPy Modules (https://dspy.ai/building-blocks/3-modules/).  There is an example of a coding agent using DSPy here: https://github.com/stanfordnlp/dspy/tree/main/examples/coding

✨✨ Here's an AI-assisted sketch of how you might approach this issue saved by @jimwhite using Copilot Workspace v0.25


Add net5.0 test target

I'm not so sure about this one...

The tests have specific framework version checks, I'm not sure this even needs a .net 5 target.


Explore v0.9 feedback

Here we go again.
Sidebar

we are changing it a bit
it does not have borders all around
it does not change to bold when its active

make buy now default when you open the explore - user can than close the breadcrumbs

own filter disabled when user is not connected; maybe we can add tooltip saying: connect your wallet to use this filter?

Spacing

space between explore +buttons and the line separating content is too large, make it smaller please

gap between side bar and nft cards is too small
whole spacing is also connected with
#4857

Connected Issues

#4444

Checkbox (need to create NeoCheckbox based on Oruga checkbox)

[ ] 1px solid border
[ ] remove radius
[ ] font-weight bold when active

Filters

[ ] > make buy now default when you open the explore - user can than close the breadcrumbs
[x] > own filter disabled when user is not connected

Spacing

[x] > space between explore +buttons and the line separating content is too large, make it smaller please
[x] > gap between side bar and nft cards is too small
(I've increase it a bit)
[ ] > whole spacing is also connected with Smaller side margins #4857
Need to rework spacing helpers

Connected Issues
* [redesign: dynamic change grid card size #4444](https://github.com/kodadot/nft-gallery/issues/4444)

[ ]  1px solid border
[ ]  remove radius
[ ]  font-weight bold when active

Don't get me wrong about the bold font-weight; we're getting rid of it.

we are changing it a bit
it does not have borders all around
it does not change to bold when its active

the screenshot above shows the side bar in active and nonactive state. We might also remove the hover effect based on the complexity of implementing it.

What's outstanding for feedback?

What's outstanding for feedback?

sidebar styling


Missing pygments dependency in setup.py

Pyroma needs pygments, but it is not automatically installed when installing pyroma. Is it the wanted behavior? It looks better to me to have it installed automatically, by adding the dependency to pyroma in setup.py.
BTW, thanks for your project.
Here is the process to reproduce:
 vincent  vincent-portable  tmp  pyro  $  python3.7 -m venv venv
 vincent  vincent-portable  tmp  pyro  $  act
 venv  vincent  vincent-portable  tmp  pyro  $  pip install pyroma
Collecting pyroma
  Downloading https://files.pythonhosted.org/packages/c6/47/ed54e54ed8a0e89608070d2e3d109d2620368bfcc0940685a000e7fc93fd/pyroma-2.5-py2.py3-none-any.whl (353kB)
    100% |████████████████████████████████| 358kB 3.7MB/s
Requirement already satisfied: setuptools in ./venv/lib/python3.7/site-packages (from pyroma) (40.8.0)
Collecting docutils (from pyroma)
  Using cached https://files.pythonhosted.org/packages/36/fa/08e9e6e0e3cbd1d362c3bbee8d01d0aedb2155c4ac112b19ef3cae8eed8d/docutils-0.14-py3-none-any.whl
Installing collected packages: docutils, pyroma
Successfully installed docutils-0.14 pyroma-2.5
You are using pip version 19.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
 venv  vincent  vincent-portable  tmp  pyro  $  pyroma python-dev-tools
------------------------------
Checking python-dev-tools
Found python-dev-tools version 2019.6.2
Downloading python_dev_tools-2019.6.2.tar.gz to verify distribution
/tmp/pyro/venv/lib/python3.7/site-packages/setuptools/dist.py:475: UserWarning: Normalizing '2019.06.02' to '2019.6.2'
  normalized_version,
Found python-dev-tools
------------------------------
Your long_description is not valid ReST:
<string>:61: (WARNING/2) Cannot analyze code. Pygments package not found.
You should have three or more owners of the project on PyPI.
------------------------------
Final rating: 8/10
Philadelphia
------------------------------
 venv  vincent  vincent-portable  tmp  pyro  $  pip install pygments
Collecting pygments
  Downloading https://files.pythonhosted.org/packages/5c/73/1dfa428150e3ccb0fa3e68db406e5be48698f2a979ccbcec795f28f44048/Pygments-2.4.2-py2.py3-none-any.whl (883kB)
    100% |████████████████████████████████| 890kB 1.6MB/s
Installing collected packages: pygments
Successfully installed pygments-2.4.2
You are using pip version 19.0.3, however version 19.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
 venv  vincent  vincent-portable  tmp  pyro  $  pyroma python-dev-tools
------------------------------
Checking python-dev-tools
Found python-dev-tools version 2019.6.2
Downloading python_dev_tools-2019.6.2.tar.gz to verify distribution
/tmp/pyro/venv/lib/python3.7/site-packages/setuptools/dist.py:475: UserWarning: Normalizing '2019.06.02' to '2019.6.2'
  normalized_version,
Found python-dev-tools
------------------------------
You should have three or more owners of the project on PyPI.
------------------------------
Final rating: 9/10
Cottage Cheese
------------------------------

Ah, I see. This is because the README in question uses code syntax highlighting.
Yes, installing pygments solves that, although it's not a direct dependency of Pyroma.


🐛: Tapping on same page on mobile does not close menu

Summary
When on a mobile, specifically phone, device and you click on the menu to navigate to another page, clicking on the same page you are on does not close the menu. Instead you have to click on a new page and then click the menu again to navigate to the old page. This is tedious and bad UX.

Fixed in #46


Open mojibar when invoked, if it's already running.

This issue is a cousin of #6.
I like to use spotlight.app to open stuff. It would be cool to be able to open spotlight, type moji, hit enter, and have the mojibar window pop open. Not sure how to do this, but I'd be happy to send a PR with a little guidance if you're open to it.
PS speaking of emojis, marky-markdown has emoji support as of this morning, which means npmjs.com will support them very soon!

Ahh this is interesting. I don't really know how to do this, but I imagine there should be an event we can listen, I am guessing perhaps something like this? http://electron.atom.io/docs/v0.36.0/api/app/#event-39-activate-39-os-x

Not sure how to do this, but I'd be happy to send a PR with a little guidance if you're open to it.

So if that event does work in this case (as in it gets triggered when opening from spotlight while already opened), all we have to do I think is to listen for the event in index.js like this and call mb.showWindow(). :sparkles:


FIX: Execution problem with python>= 3.8 on windows

This PR sets the right event loop policy when using python>=3.8 on windows.
For more details see https://github.com/jupyter/jupyter_client/issues/583

Thanks for the update! You seem to have committed some unrelated auto-formatting, though.

Oops, sorry for that, must have added the whole file instead of only the important lines.
Fixed it.

Thanks @s-weigand!


"Golești" is listed in the drop-down menu

Description:
"Golești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Golești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Golești, Argeș (Ștefănești)".


Added timezone argument to run and create

Added tz to the arguments for run() and create() as per the arguments supported in podman:
https://docs.podman.io/en/stable/markdown/podman-create.1.html#tz-timezone
This appears to be a podman only cli argument, but is very useful e.g. to ensure the container runs to match the host's timezone.
Added podman only testcases to demonstrate the change working as expected.

@gabrieldemarmiesse did you want to have a look? Should be pretty uncontroversial :)


Missing device configuration: Shelly Qubino Wave 2PM

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

Which device is missing?
Shelly Qubino Wave 2PM
Manufacturer ID
0x0460
Product Type
0x0002
Product ID
0x0081
Firmware Version
FW: v10.27.0 SDK: v7.19.1
Is the device listed on the Z-Wave Alliance website?
No response
Do you have a manual?
https://kb.shelly.cloud/knowledge-base/wave-2pm

@QubinoHelp Could you help us with the integration into ZWave-JS?

@lieblinger
We're working on it, Wave 1PM is up, the Wave 1 and 2PM is work in progress. Most probably everything will be ready for the end of this week.

As PR #6326 is merged this issue may be closed as complete


MAINT: Migrate from poldracklab to nipreps orgs

Resolves: #2289.

I think we should probably push all 20.x.y tags to nipreps/fmriprep on DockerHub, to avoid having to say "well, for this version, use poldracklab/fmriprep".

Currently doing this.


554 coldp update specifications

Updates changes to the coldp schema, fixes autonym handling, and adds appended phrase

Codecov Report
Base: 86.54% // Head: 73.19% // Decreases project coverage by -13.34% :warning:

Coverage data is based on head (508f40a) compared to base (2883279).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           development    #3215       +/-   ##
================================================
- Coverage        86.54%   73.19%   -13.35%
================================================
  Files             1918     1553      -365
  Lines            68864    50560    -18304
================================================
- Hits             59595    37007    -22588
- Misses            9269    13553     +4284

Impacted Files
Coverage Δ

spec/support/concerns/controller/delete.rb
9.09% <0.00%> (-90.91%)
:arrow_down:

spec/support/concerns/request/api.rb
11.11% <0.00%> (-88.89%)
:arrow_down:

app/models/identifier/global/issn.rb
14.28% <0.00%> (-85.72%)
:arrow_down:

app/models/identifier/global/isbn.rb
8.33% <0.00%> (-85.42%)
:arrow_down:

app/controllers/concerns/token_authentication.rb
22.58% <0.00%> (-77.42%)
:arrow_down:

app/models/identifier/global/lccn.rb
11.53% <0.00%> (-76.93%)
:arrow_down:

...odels/identifier/global/gen_bank_accession_code.rb
27.27% <0.00%> (-72.73%)
:arrow_down:

app/helpers/batch_load/batch_load_helper.rb
23.07% <0.00%> (-71.80%)
:arrow_down:

app/controllers/public_contents_controller.rb
31.03% <0.00%> (-68.97%)
:arrow_down:

.../controllers/tagged_section_keywords_controller.rb
31.03% <0.00%> (-68.97%)
:arrow_down:

... and 854 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added a basic Link component

2 general comments/questions:

doesn't it need more styling/options for colors? Or how are we going to style them? Also, it now looks different when you use a button than when you use a a. The button isn't using proxima nova, but system-ui.

how can we now use the <Link> component from react-router (as we discussed yesterday).


bug: default neovim dashboard does not appear [LOW PRIORITY]

Did you check docs and existing issues?

[X] I have read all the todo-comments.nvim docs
[X] I have searched the existing issues of todo-comments.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
Windows 11
Describe the bug
The default neovim dashboard does not appear or instantly disappears when this plugin is active

Steps To Reproduce

Install and set up todo-comments
Default dashboard no longer appears
Remove todo-comments config and restart
Nvim default dashboard appears

Expected Behavior
todo-comments should be set up AND nvim default dashboard should appear..
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/todo-comments.nvim",
  -- add any other plugins here
  {
    "folke/todo-comments.nvim",
    dependencies = { "nvim-lua/plenary.nvim" },
    opts = {}
  }
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

I have a same problem.

Same here

I have this same problem. Issue #133 describes the offending lines, a brief description why, and a work around. The work around fixed the problem for me.

I have this same problem. Issue #133 describes the offending lines, a brief description why, and a work around. The work around fixed the problem for me.

Ooh.. I didn't see that issue.. should have searched for "start screen" too... Thanks will check out the solution.
Closing as duplicate


Evaluate Apps/Refs from Builtins before Env

This closes #159. The issue had nothing to do with the while, but it was easiest to observe the problem there due to the speed at which the environment accumulates. The problem was related to attempting to evaluate function application or references by looking them up in the environment instead first. The environment fills with key:value pairs for all references, functions, and local name bindings via parameters and lets. However, the environment is repeatedly filled with duplicates of all of these upon subsequent evaluations (including repeated function definitions). Normally, this leads to no visible effect due to (from what I can tell) haskell's laziness. The relevant bindings are re-declared fairly close to the front of the list, and a lookup returns very quickly without evaluating much of the list.
However, adding any builtin functions or references leads to an incrementally massive slowdown during repeated evaluations. This is due to the lookup on the environment checking the entire environment first before checking the builtins, and this seems to force all related values to evaluated as well. For even basic while loops, this creates an exponential increase in memory usage and computation time due to the full environment size as it runs, and BoGL will freeze, or fail to return a valid response. For example:
-- extremely slow (don't run this on the server please)
bad : Int -> Int
bad(x) = while and(x < 1000, x < 1000) do x+1

and2 : (Bool,Bool) -> Bool
and2(a,b) = if a then if b then True else False else False

-- finishes in a fraction of second via
good : Int -> Int
good(x) = while and2(x < 1000, x < 1000) do x+1

Flipping the order of evaluation around immediately fixed the issue, and since the builtins are finite this should be just fine from here on out. This dramatically improved performance for using any of the builtins, as well as input. This eliminates the latency related to repeated looping inputs for as much as I have tested, a surprisingly dramatic improvement 💯 .
To add briefly, with the patch the bad example runs at the same speed as the good one, there's no noticeable difference.

I'm going to open up another issue as a kind of open investigation into the environment thing. It appears to be fine for the moment, but it might be worth looking into later on.


What do error codes mean, e.g. errno=11

recv on socket 14 returns -1 (errno=11)
socket 14: 1 ( IPOLLING_READ )
recv on socket 14 returns 20 (errno=0)

Can you share your command line and operating system?
I'm 90% certain this is expected and normal for TCP mode.  errno 11 is legacy EAGAIN, which means the socket didn't have any more immediate data on it.  This is a benign error - really just a verbose info message. Not an actual error.


Create a copy of all legislator photos

These would be photos stored/served by Open States, similar to how we have photo backup now, like https://s.openstates.org/photos/small/AZL000046.jpg. These, different from the current photos, would use their Person OCD ID in their S3/HTTP URI.
Until this is done, we'll use a placeholder div.

@jamesturk, thoughts on the best way to do this? Should we just augment the current photo backup job? Create a new one, since it'd be accessing a different database (OCD, vs Billy)?

I've created an issue here https://github.com/openstates/people/issues/26


update leveldown dependency version for compatibility with iojs 2.x

With the release of io.js v2.0.0 and the associated V8 upgrade, node-gyp fails to rebuild leveldown:
 ...

  CXX(target) Release/obj.target/leveldown/src/database.o
../src/database.cc:552:11: warning: 'FatalException' is deprecated: Use FatalException(isolate, ...) [-Wdeprecated-declarations]
    node::FatalException(try_catch);
          ^
/Users/leon/.node-gyp/2.0.0/src/node.h:263:29: note: 'FatalException' has been explicitly marked deprecated here
                inline void FatalException(const v8::TryCatch& try_catch) {
                            ^
/Users/leon/.node-gyp/2.0.0/src/node.h:47:42: note: expanded from macro 'NODE_DEPRECATED'
    __attribute__((deprecated(message))) declarator
                                         ^
1 warning generated.

...

Upgrading the leveldown version solves this issue.

This module is not compatible with leveldown 1.0.0 (due to levelup 1.0.0
not being out yet). Levedown 0.10.5 should fix this issue, and it should be
already in the included range.
Can you please check again?
Il giorno mar 5 mag 2015 alle 17:25 Leon Chen<EMAIL_ADDRESS>ha
scritto:

transcranial wants to merge 1 commit into mcollina:master from
transcranial:master:
With the release of io.js v2.0.0 and the associated V8 upgrade, node-gyp
fails to rebuild leveldown:
...
CXX(target) Release/obj.target/leveldown/src/database.o
../src/database.cc:552:11: warning: 'FatalException' is deprecated: Use FatalException(isolate, ...) [-Wdeprecated-declarations]
node::FatalException(try_catch);
^
/Users/leon/.node-gyp/2.0.0/src/node.h:263:29: note: 'FatalException' has been explicitly marked deprecated here
inline void FatalException(const v8::TryCatch& try_catch) {
^
/Users/leon/.node-gyp/2.0.0/src/node.h:47:42: note: expanded from macro 'NODE_DEPRECATED'
attribute((deprecated(message))) declarator
^
1 warning generated.
...
Upgrading the leveldown version solves this issue.
You can view, comment on, or merge this pull request online at:
https://github.com/mcollina/levelgraph/pull/121
Commit Summary

update leveldown dependency version for compatibility with iojs 2.x

File Changes

M package.json
https://github.com/mcollina/levelgraph/pull/121/files#diff-0 (2)

Patch Links:

https://github.com/mcollina/levelgraph/pull/121.patch
https://github.com/mcollina/levelgraph/pull/121.diff

—
Reply to this email directly or view it on GitHub
https://github.com/mcollina/levelgraph/pull/121.


Citing featexp

Thank you very much for putting together a nice library. Would there be a better way of citing featexp than this repository?

Unfortunately, I don't have a paper or something which you can cite. Maybe be the medium blog post in the readme?

Ok, thanks, maybe for future you could obtain a doi for citing?

Here: https://zenodo.org/badge/doi/10.5281/zenodo.2616757.svg
Thanks for this!


Invalid hook call error when using hooks on customToolbar

If you pass a customToolbar that uses hooks you get 'Error: Invalid hook call. Hooks can only be called inside of the body of a function component.'.
Expected Behavior
customToolbar should support hooks.
Current Behavior
Throws error when using hooks
Steps to Reproduce (for bugs)

Write a component that uses any react hook
Pass it to customToolbar option
Throws Error.

Your Environment

Tech
Version

Material-UI
4.11.3

MUI-datatables
3.7.7

React
17.0.1

browser
chrome 89

Hi I'm having the exact same issues with customBodyRender, is there a solution that doesn't require using the withStyles api?

I think this might help:
function Toolbar() {
    return (
        <Tooltip title={"Add Something"}>
            <IconButton style={{color: 'white','&:hover': {color: "#a5a7bc"}}} onClick={handleAdd}>
                <AddIcon />
            </IconButton>
        </Tooltip>
    );
}

const handleAdd = () => {
console.log('Added');
};
const options = {
customToolbar: Toolbar,
};
<MUIDataTable
title={'My Table'}
data={datax}
columns={columnsx}
options={options}
/>


"Toggle VSCode Developer Tools" and "Developer: Inspect Context Keys" don't have access to Interactive Window/Jupyter's UI

With "Developer: Inspect Context Keys" I'm able to focus on any CSS elements without any issues... except for UI elements inside Jupyter Notebooks.  Also, "Toggle VSCode Developer Tools" doesn't have access to these elements either.
I'm guessing this limitation might be because Jupyter uses a separate CSS from the rest of VSCode's UI.
Anyway, it would be great if "Developer: Inspect Context Keys" and "Toggle VSCode Developer Tools" didn't discriminate against Jupyter.
Is there a workaround for this?  BTW:  Where is the location of the CSS file for Jupyter on Windows OS?

@mkanet I believe Jupyter Notebooks is using a webview, instead of "Toggle VSCode Developer Tools", can you try Developer: Open Webview Developer Tools?
Since it's a webview, I think it's expected that you can't inspect context keys inside of it. Can you describe what information you're trying to get from using Developer: Inspect Context Keys?

@RMacfarlane  Thanks for the quick reply.  Developer: Open Webview Developer Tools still doesn't identify any of the elements within the Jupyter's iframe; such as the icons.

@mkanet What extension are you using that adds Jupyter Notebooke support?

@RMacfarlane, I'm using Jupyter Notebook directly within VSCode; without any other extensions related to it.  I want to explore the possibility of make a custom CSS for it the same way I've done with extensions like be5invis/vscode-custom-css.  I'd like the ability to use custom icons for Jupyter within VSCode that better matches my VSCode themes.

@mkanet What steps did you take to show the Jupyter Notebook within VSCode? Is it like this:

where it's from the Python extension?

@RMacfarlane, the only way I know how to start Jupyter in Jupyter is opening a python file. then selecting, "Python:  Run the current file in Python Interactive Window.
While I have your attention, I'm hoping you might be able to answer a related question:
I'm using an unorthodox VSCode theme where the sidebar and panel are both using DARK backgrounds while the editor (and Interactive Window) use a LIGHT background (see below screenshot).  In a case like this, the base UI theme is either going to be compatible with the sidebar and panel backgrounds OR be compatible with the editor and Interactive window, not both.
I'd like to know if there's any way at all to explicitly tell Jupyter to use VSCode's "light" base UI theme and respective icons even though I'm using a "dark" base UI theme (specified in package.json as vs-dark).   That way, the icons in Jupyter will visible.
If I try to change the base UI theme to be light (in packge.json), icons in Jypyter will be visible, but then icons in the sidebar and panel won't be visible.
It would be great if you (or someone else here) know how to tell the Interactive Window to explicitly use the "light" base UI theme regardless of what's specified in package.json.

I've already spent a great deal of time on this; and, searching everywhere on Google.  Hopefully someone with more experience than me can shed some light on this and hopefully answer my question in the above post.

@mkanet To my knowledge, there's no way of explicitly specifying this. The rendering of the Jupyter Notebook is controlled by the Python extension, not VSCode. If you use the webview developer tools and look at the root element of the webview, you'll see that there are a bunch of css variables that have been set by VSCode for all of the theme colors. I haven't looked into the extension code, but I except that it's using the theme color for the editor foreground, and is checking whether the theme is light or dark to determine which set of icons to use. (Could search for something like var(--vscode-editor-foreground) to find the css setting the colors in the webview)

@RMacfarlane thank you so much for shedding some light on this.  Based on your last comment, I'm going to close this issue and open a new issue for Python on Github.  I'm going to see if they can either offer a workaround or add a setting to allow overriding the base UI theme for Jupyter.


[WIP] Use Sentry for error reporting

🤖 🤖 🤖 ✅

I realise this is WIP so perhaps it's not a concern, but is there a suitable replacement for Airbrake.notify_sync? We use it in the consistency checker to ensure the error makes it through to Errbit at the moment (as it's the last thing the process does so we found the process was terminating before sending the error). Perhaps this isn't a problem with raven-ruby.

Ignore that... I can see there is. Not sure how I missed it the first time.

Hmm, that's interesting. Raven does sync by default as far as I know, so we wouldn't need this?
Btw GOVUK::Error.notify_sync doesn't actually exist, that's sloppy review on my part.

Ah! Yeah, if it's synchronous by default then we wouldn't need it, but then I wonder if we would want that behaviour by default since it's that's different to how Airbrake.notify currently works?

I'm tempted to go with Sentry's default behaviour until we see a problem. Does that sounds allright?

Yep, fine by me 👍


Allow dashes in usernames

The validator for usernames in models.py only allows alphanumeric, underscore, and '.', but we should allow '-' as well, because Andy Blanking-Crush should have blanking-crush.andy as a username.

I can change that in #645, what do you think?

+1


warnings

warning: function Mongo.Ecto.rollback/2 is undefined or private
warning: function Mongo.Ecto.transaction/3 is undefined or private
M.E version: master
Ecto: 1.0.0
Elixir: 1.3.0

Yeah, it makes sense they are there, but I'm not sure how we could go about fixing them.
A hotfix for now would probably be to define rollback and transaction in your repo to avoid ecto generating the default implementation:
def transaction(_, _), do: raise "not supported"
def rollback(_), do: raise "not supported"

I will think of a general solution in ecto

Yeah, these wrappers sit in Ecto.Repo adapter.
No, it cannot help:) Elixir looking for those methods in Mongo.Ecto, because it's called via Ecto adapter.
I think we can wait, seems you have started new branch for 2.0., maybe it can be fixed with its release, no matter when it will be.

This is an issue in ecto itself, that is still present in master. Tracked in https://github.com/elixir-ecto/ecto/issues/1530. I'll close this issue for now.


web-ext: Include only production dependencies in build

Description of changes
Closes #273083.
Big thanks to @Rob--W for explaining!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please make an upstream PR.

I'm waiting to see if they acknowledge the issue.

@dotlambda Turns out the problem was our build process, after all.

@l0b0 I forgot to ask if you want to add yourself as maintainer.

@l0b0 I forgot to ask if you want to add yourself as maintainer.

I'm not entirely sure yet. I have a minor hobby project where I'd like to use this, but I've no experience with upstream other than this issue.


Status glossary

The Status mobile app includes a glossary with some Status and Web3 terms and definitions. This article will extend and improve this content.
We will need to update this article periodically as we introduce new terms in the rest of the Status documentation articles.

Unnecessary.


Port our downloaders to use Scrapy

Scrapy just released beta Python 3  support. It's an advanced downloader for scraping resources from various sites. I think it's a good fit for the thousands of files we have to download for a content pack!
So let's try to use scrapy the next time we have to write a downloader for content packs, and port our existing downloaders to this as well.

Not happening with the current content packs, since it's already in maintenance mode. Might be an optimization for the Studio sushi chefs though.


Missing documentation for Zend\I18n\Validator\PhoneNumber

The validator "PhoneNumber" needs some explanations and code examples.
https://github.com/zendframework/zend-i18n/blob/master/src/Validator/PhoneNumber.php

This repository has been closed and moved to laminas/laminas-i18n; a new issue has been opened at https://github.com/laminas/laminas-i18n/issues/8.


Updated logs injection indentifier to signalfx

Would it make sense to move to hex representation now?

@rmfitzpatrick  PTAL


HA: vip.sh arping parameter insuficcient

Author Name: Sledge Sulaweyo (Sledge Sulaweyo)
Original Redmine Issue: 5309, https://dev.opennebula.org/issues/5309
Original Date: 2017-08-11

In larger environments the switch of the floating IP to a different host has to be announced via a unsolicited ARP packet to ensure that the switch updates it's ARP table accordingly. Without that a leader change is not propagated to the switch and on leader change access from other networks ends up at the wrong router port.
The change needed is minimal as just the parameter of the arping command has to be switched from -A to -U (https://github.com/OpenNebula/one/pull/425)

Original Redmine Comment
Author Name: Sledge Sulaweyo (Sledge Sulaweyo)
Original Date: 2017-08-18T07:56:40Z

I have added sudo as well as arping will not send the request without sudo

It's working current version > 5.4.2. Reopen if needed


Create Relay Server for Remote IDE

What would you like to be added?
Relay server for remote IDE will reach IDE in physical instance over cluster DNS and serve the remote IDE, make it reachable from public network.
Why is this needed?
It's needed to satisfy #135, should be done after #136.

A new custom resource is defined to serve remote services named RelayServer. Docs will be updated.


use actions() in controller

I use actions() in controller , when the request action is in my controllor and it use actionXXX() the function way to definition ,but the actions() in this controller will  also be called;

Why is that a problem?

impossibility, Pls show your code

I'm closing the issue unless further information provided.


Fix create sequence for postgresql9

name: Fix create sequence for postgresql9
about: Solved an outstanding issue
title: ''
labels: Status:Discovery
assignees: ''

Environment
Liquibase Version: any
Liquibase Integration & Version: any
Liquibase Extension(s) & Version: any
Database Vendor & Version: PostgreSQL 9.x
Operating System Type & Version: any
Pull Request Type

[x] Bug fix (non-breaking change which fixes an issue.)
[ ] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Check issue #1429 for more details on the issue.
Steps To Reproduce
List the steps to reproduce the behavior.

Please be precise and ensure private information is redacted
Include things like

Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Additional Context
Check issue #1429 for more details on the issue.
Fast Track PR Acceptance Checklist:

[x] Build is successful and all new and existing tests pass
[x] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

Why is the code coverage failing? I have added a test for the bugfix.

We were experimenting with the code coverage plugin. It turned out to not be helpful.
This and a couple other similar PRs got incorporated into #1843, so closing this as a duplicate.
Thanks for the help!


[csi-manila] CSI client moved into a separate package

What this PR does / why we need it:
Part of https://github.com/kubernetes/cloud-provider-openstack/issues/714
Continuing in an effort of integrating the csi-sanity test suite into CSI Manila, this is the second patch out of 4:
This PR moves the CSI client into a separate package, which brings Node, Identity and Builder interfaces. This in turn makes it possible to have various implementations for CSI clients - e.g. creating a fake CSI client which is a prerequisite for sanity/unit tests.
Release note:
NONE

/ok-to-test

@gman0 is it good to go??
cc @tombarron @gouthampacha @tsmetana

@adisky finished and ready for reviews :)

It looks OK to me: as the description mentions -- this is only new interfaces that implement the existing logic. Most of the code has only been moved.
/lgtm

/retest

/approve
/lgtm


Bug: Testing Composition API written component library in Vue3 project

Describe the bug

I've build a component libary like custom buttons, searchfield, etc. and I am building it as a common.js library. Everything works fine when I am building but when it comes to testing, my library components are not reactive.
In my vue app I am installing my library with npm i [path] and everything works fine when it comes to package installing. Inside my code I am importing components like this import {TestButton} from "sharedvue" and everything works fine when I am building my app.
Both components (TestButton and App) are written with the composition API. When it comes to testing, TestButton is not reactive! If I change TestButton from composition API to options API, then the test is successful.
To Reproduce

I am building my library with the vue-cli command vue-cli-service build --target lib --name sharedvue src/main.ts. In my vue app I am installing my library with npm i [path] and everything works fine when it comes to package installing. Inside my code I am importing components like this: import {MyButton} from "sharedvue". Everything works fine when I am building my app.
App.vue

Source: https://www.toptal.com/developers/hastebin/ujuxorepet.xml
TestButton.vue

Source: https://www.toptal.com/developers/hastebin/ipiqupokem.xml
App.spec.ts

Source: https://www.toptal.com/developers/hastebin/atohivabuh.js
Expected behavior

Expected Output Log:

<button class="buttonToEnable" title="enableButton">Click</button>

OptionsApi Prop - World

CompositionApi Prop - World

CompositionApi Computed Prop - World

OptionsApi Computed Prop - World

OptionsApi Watch - World

CompositionApi Watch - World

Actual Output Log:

<button class="buttonToEnable" title="enableButton">Click</button>

OptionsApi Prop - World

CompositionApi Prop - Hello

CompositionApi Computed Prop - Hello

OptionsApi Computed Prop - World

OptionsApi Watch - World

CompositionApi Watch - Hello

Related information:

@vue/test-utils version:  2.0.0-rc.17
Vue version: 3.2.31
@types/jest version: 27.4.1
ts-jest version: 27.1.4
@vue/vue3-jest version: 27.0.0-alpha.4
node version: 16.14.2
npm version: 8.3.0

I tried to reproduce this issue in a new vue project and have now discovered that the problem could come from the Vue Cli. Because in my "real production code" I have the following code in my vue.config.js
	configureWebpack: {
		resolve: {
			symlinks: false,
			alias: {
				vue$: path.resolve("./node_modules/vue"),
			}
		},
	}

and I found out that if I remove this section I have the same behaviour as in my failed tests.


tenant onboard failed

2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR Error: Connection failed (RTE:[300002] OpenSSL is not available: Unresolved symbol (<IP_ADDRESS>:59506 -> 7b7d84d2-0ed2-4597-b11f-cfa5562cf233.hana.demo-hc-3-haas-hc-dev.dev-aws.hanacloud.ondemand.com:443))
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at Socket. (/home/vcap/app/node_modules/@sap/hdbext/node_modules/@sap/hana-client/lib/index.js:53:13)
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at Socket.emit (node:events:513:28)
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at addChunk (node:internal/streams/readable:324:12)
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at readableAddChunk (node:internal/streams/readable:297:9)
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at Readable.push (node:internal/streams/readable:234:10)
2023-03-21T22:47:11.44+0800 [APP/PROC/WEB/0] ERR at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)
2023-03-21T22:47:11.44+0800 [RTR/31] OUT sap-hana-cloud-hc-dev-services-demo-hc-3-test-demo-hc-31aa7dff8.cfapps.sap.hana.ondemand.com - [2023-03-21T14:47:11.391220503Z] "GET /callback/v1.0/dependencies?tenantId=e1b4951b-be22-4c3e-b9ae-b21884ba79ec HTTP/1.1" 500 0 148 "-" "Java/11.0.18" "<IP_ADDRESS>:24294" "<IP_ADDRESS>:61062" x_forwarded_for:"<IP_ADDRESS>, <IP_ADDRESS>" x_forwarded_proto:"https" vcap_request_id:"2c06b8b7-f88b-48d9-4007-3a17beb1170a" response_time:0.054276 gorouter_time:0.000054 app_id:"25867fb3-0bda-4581-801e-a61ea66ff9e7" app_index:"0" instance_id:"c6af1f62-af6c-47b4-4d69-d4d2" x_cf_routererror:"-" x_correlationid:"324c661f-37a8-437c-5b05-6cdc2982f4c4" tenantid:"-" sap_passport:"-" x_scp_request_id:"52da8324-67bb-46ea-9857-ef1b98a0afde-6419C36F-7CA9F2" x_cf_app_instance:"-" x_forwarded_host:"-" x_custom_host:"-" x_ssl_client:"-" x_ssl_client_session_id:"-" x_ssl_client_verify:"-" x_ssl_client_subject_dn:"-" x_ssl_client_subject_cn:"-" x_ssl_client_issuer_dn:"-" x_ssl_client_notbefore:"-" x_ssl_client_notafter:"-" x_cf_forwarded_url:"-" traceparent:"00-efaddcb1491e091a8e3a544689432344-13e1a909025608a5-01" x_b3_traceid:"2d8f4bd1e7692aba328d8a1fcf4c329e" x_b3_spanid:"328d8a1fcf4c329e" x_b3_parentspanid:"-" b3:"2d8f4bd1e7692aba328d8a1fcf4c329e-328d8a1fcf4c329e"
hit connection failed, when trying to subscribe the application.

@darkalex2004
Looks like there's some issue with your HANA cloud instance. The onboarding service is not able to connect with the HANA cloud instance. Can you check the logs of DB service. Also, try re-triggering the onboarding.
You can refer to this https://github.com/saphanaacademy/secure-sap-hana-client/blob/master/README.md

@darkalex2004 Looks like there's some issue with your HANA cloud instance. The onboarding service is not able to connect with the HANA cloud instance. Can you check the logs of DB service. Also, try re-triggering the onboarding. You can refer to this https://github.com/saphanaacademy/secure-sap-hana-client/blob/master/README.md

Thank you so much, I will have a check with the hana instance ,and have a retry.

it works, thanks @gopalanand333


Task- Tif files are too large to upload to Comprehensive specimen digitization

Hello,
I was hoping to upload .tif files to collection objects through Comprehensive specimen digitization. When I did this I received an error message that the file (1.6 Gb) was too large.

I was wondering if future updates will allow for uploads of larger files, such as tif files, or if I should seek out a different way to upload high resolution images.
Thank you!

1.6 GB is a huge image. It's not impossible, but I'm curious, what was the source?

I am working with tif files made with photos taken by a Canon 8.0V camera through a compound microscope. Each tif file is composed of  ~15-25 JPG images (each are a 3-5 Mb).

25 * 5 mb = 75 mb, not 1.6 GB?!

Unfortunately I am not sure where this extra size is coming from. I am using FIJI to create the tif files, and I will look into what is causing this and how I can make them smaller.

25 * 5 mb = 75 mb, not 1.6 GB?!

But if then saved with lossless compression (or no compression at all) it might be possible (like a ~572MP image or so?).

If the 5mb images are lossless then 25 lossless images shouldn't add up even to 572MP, right?
Are you changing (perhaps inadvertently) the color space to something like 16bit when the source is 8?
In theory any size is possible.  We can extend the limits. The main issue will be your upload speed, uploading that single image will take a long time.

The source images likely are lossy JPEGs, so all of them may fit perfectly in under 100MB even if 20MP each. However after composing all of them in a single TIFF with LZW compression (only compression guaranteed to be compatible with all readers) or no compression at all, then it will get may times bigger than original files combined.

Thanks @LocoDelAssembly. Does that assume image flattening in the Tiff?

Not sure if you can use layers but still use LZW or no compression, but I guess this TIFF is likely flattened with all JPEGs stitched possibly automatically.

@hah1009 is this a multi-focus or gig-pan style image?

Hello,
Thank you all for your help.
This is not a multi-focus image, and I do not believe it is gig-pan style.
I tried using a different program to convert the images into a multi tiff file where I can select for LZW compression. This has greatly reduced the size of the files (thank you all for your input!). The files I have now are within the range of 182-239 Mb.
When I first uploaded the 1.6 GB file, the error message I received said that the max file size is 256 Mib.
However, now when I try to upload a file size of 239 Mb, I receive another error message that the file is still too big. I also tried uploading a file that was 182 Mb and received the same result (see screenshot below).
Please let me know if you would prefer that I create a separate issue for this, or if it is another problem on my end.

@LocoDelAssembly @dimus nginx setting it seems.  Can we bump to 256mb?

Lets try something else before resorting to yet more upload size. @hah1009 did the program offer the possibility to compress in JPEG? (Not compliant with all readers, but I think TaxonWorks can handle it). Like https://feedback.photoshop.com/conversations/photoshop/photoshop-cant-save-tiff-with-jpeg-compression/5f5f45a34b561a3d42574568?commentId=5f5f481c4b561a3d420a2eb7 but with the program you use.

Is that lossy?

It is, but if saved at high quality the damage should be close to non-existent, given that the source images used to compose the TIFF were JPEGs already. Saving them losslessly would only serve to encode the JPEG compression artifacts explicitly in the file, without really improving anything over saving with JPEG.

Yes, I do have to option to compress in JPEG. I tried this with the file that was 182 Mb from the LZW compression. When compressed in JPEG it came out to be 1.13 Gb (the same size that FIJI produced).

@jlpereira do we know if this is solved? for now?

@hah1009 can you let us know if it's still an issue for you?


Evaluation pipelines failing GPG signing due to deep path lengths

Thank you for reporting a broken build! Please fill in the following details:

Jenkins link to the failing log: https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk20u/job/jdk20u-evaluation-linux-riscv64-temurin/29/console
Which platforms (OS+arch) are affected?: Ar least Linux/riscv64
If you look at the historic logs, does the problem appear to be specific to one machine?: No
Link to any upstream project bug report (e.g. OpenJ9/JBS): n/a

Error as follows:
18:23:55  GNUPGHOME=/home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk20u/jdk20u-evaluation-linux-riscv64-temurin/.gpg-temp
18:23:55  gpg: keybox '/home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk20u/jdk20u-evaluation-linux-riscv64-temurin/.gpg-temp/pubring.kbx' created
18:23:55  gpg: error running '/usr/bin/dirmngr': exit status 1
18:23:55  gpg: failed to start the dirmngr '/usr/bin/dirmngr': General error
18:23:55  gpg: connecting dirmngr at '/home/jenkins/workspace/build-scripts/jobs/evaluation/jobs/jdk20u/jdk20u-evaluation-linux-riscv64-temurin/.gpg-temp/S.dirmngr' failed: General error
18:23:55  gpg: keyserver receive failed: No dirmngr

Related to https://github.com/adoptium/temurin-build/pull/3361 (Alpine) and potentially related to https://github.com/adoptium/infrastructure/issues/3049#issuecomment-1564776559 (MacOS) although the solution is probably not the same as that one.

I've run into a similar issue on a jdk21u for riscv64 build: https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk21u/job/jdk21u-evaluation-linux-riscv64-temurin/90/console

Should be broadly fixed with https://github.com/adoptium/temurin-build/pull/3630


Add RealisticRemodel1x

Will fail on dependency for SigmaDimensions

Local output
|   ModuleManager.2.6.24.dll
|
+---Kopernicus
|   +---Config
|   |       System.cfg
|   |
|   \---Plugins
|           Kopernicus.Components.dll
|           Kopernicus.dll
|           Kopernicus.OnDemand.dll
|
+---RealisticRemodel-1x
|   |   SolarSystem.cfg
|   |
|   \---Compatibility
|       +---OPM
|       |       OPMKopernicus.cfg
|       |
|       +---Sigma Binary
|       |       Pallo-Chardy.cfg
|       |
|       \---Sigma Dimensions
|               ProxiAndDeedi.cfg
|
\---Sigma
    \---Binary
        |   Sigma-Binary.version
        |
        +---Configs
        |       checkMaxDistance.cfg
        |       generateBarycenters.cfg
        |       generateOrbits.cfg
        |       removeContracts.cfg
        |
        \---Plugins
                SigmaBinary.dll

Needs a dependency on ModuleManager, I think. A .cfg file that starts with this:
@Kopernicus:BEFORE[SigmaBinary]:NEEDS[!OPM]

looks like a MM script to me. The local output matches up with the included files, as far as I can see.

MM dependency added.

SigmaDimensions should be on KSP 1.1.2 pretty soon. I'm going to merge this so that when @Sigma88 releases, this will appear immediately. Like magic!

hi guys, I'm waiting for a licensing issue to be resolved before releasing SigmaDimensions for 1.1.2
I expected it to be out yesterday

Thanks for the heads up.


Implement named bindings with the 'as' keyword

 Issue by sethladd
Originally opened as dart-lang/sdk#12662

From https://github.com/dart-lang/fancy-syntax/issues/24
Consider this example:
  <template bind="{{fullName as name}}">

You can give names to expressions, like this: {{name}}

  </template>
This works with polymer.js and ExpressionSyntax.

 Comment by sethladd

Set owner to @justinfagnani.

 Comment by sigmundch

Added this to the M8 milestone.

 Comment by sigmundch

Removed this from the Later milestone.
Added this to the M9 milestone.

 Comment by clayberg

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

 Comment by justinfagnani

Added Started label.

 Comment by jmesserly

Removed this from the M8 milestone.
Added this to the Later milestone.

 Comment by justinfagnani

Removed this from the 1.1 milestone.
Added this to the 1.2 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

 Comment by jmesserly

Removed Area-Polymer label.
Added Area-Pkg, Pkg-PolymerExpressions labels.

 Comment by sigmundch

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

 Comment by jmesserly

Removed Library-PolymerExpressions label.

 Comment by sigmundch

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

 Comment by kasperl

Removed this from the 1.2 milestone.
Added this to the 1.6 milestone.

 Comment by sigmundch

Removed Polymer-Milestone-Next label.
Added PolymerMilestone-Next label.

 Comment by sigmundch

Added Fixed label.


add Snake environment

Add DataStructures package
Add Snake environment #122
Add tests and gif for Snake

Codecov Report

Merging #123 (ca54bb1) into master (dedfa11) will increase coverage by 0.20%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   76.65%   76.85%   +0.20%
==========================================
  Files          17       18       +1
  Lines         848      929      +81
==========================================
+ Hits          650      714      +64
- Misses        198      215      +17

Impacted Files
Coverage Δ

src/GridWorlds.jl
100.00% <ø> (ø)

src/objects.jl
34.04% <0.00%> (-1.68%)
:arrow_down:

src/envs/snake.jl
85.71% <85.71%> (ø)

src/envs/dynamic_obstacles.jl
97.56% <0.00%> (-1.22%)
:arrow_down:

src/envs/sequential_rooms.jl
99.11% <0.00%> (-0.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedfa11...ca54bb1. Read the comment docs.

Codecov Report

Merging #123 (ca54bb1) into master (dedfa11) will increase coverage by 0.20%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   76.65%   76.85%   +0.20%
==========================================
  Files          17       18       +1
  Lines         848      929      +81
==========================================
+ Hits          650      714      +64
- Misses        198      215      +17

Impacted Files
Coverage Δ

src/GridWorlds.jl
100.00% <ø> (ø)

src/objects.jl
34.04% <0.00%> (-1.68%)
:arrow_down:

src/envs/snake.jl
85.71% <85.71%> (ø)

src/envs/dynamic_obstacles.jl
97.56% <0.00%> (-1.22%)
:arrow_down:

src/envs/sequential_rooms.jl
99.11% <0.00%> (-0.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedfa11...ca54bb1. Read the comment docs.


Private test net: Transition to a containerised setup

Motivation
To my understanding, the current way of doing things include a number of large, heavy duty tooling to setup a local virtual network. The involved steps to accomplish this goal are fairly straight-forward, but not always trivial. Essentially, we're

configuring the infrastructure and creating the VM network and 3 machines
downloading paloma & pigeon on all machines
performing the necessary genesis steps on each machine
exporting the results

While a full virtualisation is probably closer to the real world, in my opinion it comes with a heavy cost of tooling and complexity.
Moving to a containerised solution like eks, docker swarm or even docker compose will give us reproducible builds, a much smaller footprint and a straight forward to way automating deployments.
Suggested Scope
Focus only on the local test net for now, start by keeping the existing solution as to not interfere with any ongoing ops. Mirror the most essential steps (outlined above) in Dockerfiles and supply a docker-compose.yml to spin up and tear down the network.
Anything more fancy (like replacing all ansible on the private test net or even moving towards open test net or public) should be done separately from this.
Estimation
Probably around 3-5 days, depending on your familiarity with the project and docker.

@klausklapper converting to issue and closing so that we can move to notion EPIC for a sprint insert. As an issue, it will stay here as well definitely be back.


Null Pointer When Calling up Tesla API

Issue Description:
Running a HermitPack server, and every time the system crashes (4-5 times daily) it comes up with this error... I attributed it with lag, but it seems to be happening more and more lately.
http://pastebin.com/tQ3rC3aC
What happens:
From what I can tell from the error report, it gets a null pointer error whenever enderio is trying to use the Tesla API... which makes sense because the Hermitpack doesn't include Tesla
What you expected to happen:
... the server not to crash
Steps to reproduce:

Still
Working
On this.
...

Affected Versions (Do not use "latest"):

EnderIO: 1.10.2-<IP_ADDRESS>_beta
EnderCore: 1.10.2-<IP_ADDRESS>-beta
Minecraft: 1.10.2
Forge: <IP_ADDRESS>9

Your most recent log file where the issue was present:
http://pastebin.com/tQ3rC3aC

You annoyed that you get diagnostics on what is installed after a crash?

It would appear he's trying to figure out why Ender IO is giving a Tesla error over and over, There doesn't appear to be any Tesla mod installed, and Ender IO is trying to get to check for Tesla.  Would appear to be a bug report and that he's hoping for a resolution.  I didn't get any "annoyed that you get diagnostics" from that post..   Wish I could help ya out there paulcorey, hope you can get it resolved quickly and friendly.

That was slightly rude, but I understand... what I posted wasn't an error, it was just letting me know that Tesla wasn't installed.... thank you captain obvious.
Yeah I wasn't annoyed by the report... I misunderstood the report as being part of the error reporting, my bad.

That label should explain why I'm a bit short tempered on this. Sry.


Basic Auth if Username is Empty

The API I am working with uses ONLY a password field, NOT a username field. How can I craft a Request object that has null for username?
I end up getting
Error: auth() received invalid user or password
if I try to pass in null or an empty string for user. If I ignore the username field entirely, I get:
Error: no auth mechanism defined

Looks like this works:
    headers: {
      'Authorization': 'Basic ' + new Buffer(':' + key).toString('base64')
    },


TIM10-14 OPM

You are right saying about F0 TIM14.
But I can't find any timer in RM0008 and RM0041 for F1 without OPM.

Ah, I was looking at RM008 revision 16, and in revision 17 they updated TIM10/11/13/14 CR1 to add OPM :weary:

Forgot to rebase on master. Fixed

@richardeoin I slightly reworked PR and fixed according to your review https://github.com/stm32-rs/stm32-rs/pull/684/commits/84f8b213686b8eca60858849d6d767db6029762b


[REQUEST][iOS]: Disable Image Sending on iOS

Feature Request: Disable Image Sending on iOS
Hi Clarity team,
Please implement a feature to disable sending images on iOS. This is already the default behavior on Android, where a gray placeholder and an image icon represent images in recordings. Implementing this on iOS would help conserve mobile data and provide a more data-efficient experience for users.
Thank you!

@MichalMartinu
Thanks for your suggestion!  Just to clarify, Clarity sends images on Android by default if hardware optimization is not enabled.
Here are two options to address your request using Clarity's masking featue:

Strict Masking Mode: This masks all text and images within the recordings.
Masking by ID/Class: Define specific elements (like image IDs or classes) that you don't want to be captured.

You can find detailed instructions on masking here: https://learn.microsoft.com/en-us/clarity/mobile-sdk/clarity-sdk-masking#ios
We appreciate your feedback on disabling image sending entirely on iOS. This is a valuable suggestion, and we'll consider it for future development.


Fix a compilation failure in bio_comp_test.c

Compiling with clang, --strict-warnings and enable-zlib-dynamic resulted in a compilation failure. This fixes it.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I have nothing against this fix - but just a curiosity, what's the reason why making global variables static help? Does it interfere with other global variables with the same name?

Without it clang complains as follows:
test/bio_comp_test.c:28:16: error: no previous extern declaration for non-static variable 'original' [-Werror,-Wmissing-variable-declarations]
unsigned char *original = NULL;
               ^
test/bio_comp_test.c:2[8](https://github.com/openssl/openssl/actions/runs/3310500499/jobs/5464786232#step:6:9):1: note: declare 'static' if the variable is not intended to be used outside of this translation unit
unsigned char *original = NULL;
^
test/bio_comp_test.c:29:16: error: no previous extern declaration for non-static variable 'result' [-Werror,-Wmissing-variable-declarations]
unsigned char *result = NULL;
               ^
test/bio_comp_test.c:2[9](https://github.com/openssl/openssl/actions/runs/3310500499/jobs/5464786232#step:6:10):1: note: declare 'static' if the variable is not intended to be used outside of this translation unit
unsigned char *result = NULL;
^
2 errors generated.

I can agree with urgent if at least one other approver also agrees.

I agree


Fixing dimensions problem examples

This PR fixes all the examples that needed screen size using the workaround found on #81

You are totally right, I will change that when I get the chance.
Em sáb, 29 de jun de 2019 às 15:50, Luan Nico<EMAIL_ADDRESS>escreveu:

@luanpotter commented on this pull request.
If you just await for initial dimensions, then the base game's size
property will be set correctly, won't it? In this case you don't need to
create a second control (screenSize variable ) for that. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flame-engine/flame/pull/115?email_source=notifications&email_token=AAGMAONNUULCNNOIWZNW4GDP46VG7A5CNFSM4H4KXBCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5BPQMI#pullrequestreview-256047153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGMAOMDXGNPFTMCHWTNSO3P46VG7ANCNFSM4H4KXBCA
.

--
Sent from MetroMail

@luanpotter actually, relying on size does not works on some cases, most of the examples we add Components and stuffy that depends of the size on the constructor, even when awaiting the initialDimensions on runApp, the performResize was not called yet when we are still on the constructor, and size is still null.

Couldn't you receive a size in the constructor and set this.size = size and use that??

yeah, that is a good approach.

@luanpotter I have updated this, can you take another look please?


Storybook-esque Styling

https://next--storybookjs.netlify.com/html-kitchen-sink/?path=/story/addons-a11y--default

Included as part of v1.1.0


sync/atomic: some words are redundant in package doc.

The doc for the function AddUint32:
AddUint32 atomically adds delta to *addr and returns the new value. To subtract a signed positive constant value c from x, do AddUint32(&x, ^uint32(c-1)). In particular, to decrement x, do AddUint32(&x, ^uint32(0)).

I think here, signed positive constant value should be replaced with positive value.
constant and signed are redundant.
Same problems for other AddUxxxxx functions.

  To subtract a variable value, you can simply write AddUint32(&x, -v).  That doesn't work for constant values because the resulting untyped constant can not be assigned to uint32.
Closing because I don't think we should change this.

How is it possible to call AddUint32(&x, -v) call an uint32 variable v?
Compiler will report error.

btw, there are many a uintxxx uses in sync/atomic doc.

Oh yeah, I found another way to subtract unsigned constant, if the unsigned constant is typed and its type is same as the second parameter type.
atomic.AddUint32(&n, ^(d - 1))

But if the type of the typed unsigned constant doesn't match he second parameter type, then the ^uint32(c-1) way still needs to be used.

@ianlancetaylor

That doesn't work for constant values because the resulting untyped constant can not be assigned to uint32.

but the doc says ... subtract a signed positive constant value c ..., a signed constant implies c is a typed constant, an operation with a typed constant c involved will always result a constant with the same type as c. So I think the reason of the trick ^uint32(c-1) is not for untyped constant can not be assigned to uint32.

Thanks for the comments.  Let's agree to disagree.

ok. but the docs realy doesn't mention how to subtract an unsigned constant.

Go doesn't really have the concept of an unsigned constant.  Go constants are untyped.  Numeric constants are positive or negative.  They are always signed.  See https://golang.org/blog/constants.


Cleanup dhtmltree specific calls

@dclarizio please review/test.
This PR has 2 commits first one to remove/replace dhtmlxtree selectItem calls. Second one has some other dhtmlxtree specific calls that are not in use.

Lots of UI code deletion that @jrafanie always loves!

I'm happy to see unused code get deleted :+1:


Multiple service instances created when registering services .inObjectScope( .container )

My understanding of Swinject is a lot weaker than some of you, but my understanding from the documentation at [ https://github.com/Swinject/Swinject/blob/master/Documentation/ObjectScopes.md ] is that .inObjectScope( .container ) should create singletons [with-a-small-s]. Right? Well I've just updated from beta to the stable version 2.0.0 and unfortunately one of my services is being created at least twice (I say "at least" because this is causing a crash immediately after the app launches, so I don't know yet know what happened beyond that). This is happening with code that 1. was working with the beta release; and 2. which has only been altered to change registerForStoryboard to storyboardInitCompleted, and .none to .transient
I can attach sample code, but the project I'm working on is covered by an NDA, so I'd have to spend some time rewriting it so that it doesn't expose sensitive information (...sigh...) I can do that though if it would help, just let me know.

The problem might relate to these:

https://github.com/Swinject/Swinject/pull/164
https://github.com/Swinject/Swinject/issues/158
https://github.com/Swinject/Swinject/blob/master/Documentation/CircularDependencies.md#remark

Thanks @yoichitgy I'll look into those.

No problems👍


Update to DSE 6.8.37

A new version of DSE has been released and should be used.

Superceded by #2767


Separate TextShaderEditor and ShaderEditorPlugin into different files

This PR is entirely about organization in the editor code, it has no behavior changes.
The first commit renames ShaderEditor to TextShaderEditor, because it exclusively edits text shaders. The second commit moves TextShaderEditor and its helper classes into their own file, separated out from ShaderEditorPlugin, just like how VisualShaderEditor and its helper classes are already separated into their own file.

@Paulb23 No, the class is TextShaderEditor. Look at line 107 of the header. TextShaderEditor is the big class that has all of the code for editing text shaders, while ShaderTextEditor is an internal-only helper that inherits CodeTextEditor. I know the names are kinda similar, not sure how to make this less confusing, maybe ShaderCodeTextEditor?

Oh I see, that is confusing.
Looking at it again, we could probably get rid of ShaderTextEditor by merging it with TextShaderEditor (well would rename this ShaderTextEditor I guess) and have it use CodeTextEditor directly. Then it would work similarly to ScriptTextEditor. Except for extending MarginContainer rather then ScriptEditorBase.
I can't see a way to make these names less confusing otherwise unless we go with ShaderTextEditorContainter which is starting to get a bit ridiculous.

@Paulb23 That makes sense, but that can be left to another PR. For this one I just want to give what we have a better name and move it out of the shader editor plugin file (similarly to how the visual shader editor is in its own file).

Thanks!