impossible to recover

After i put in my recovery phase, the android apps tries to authenticate in android.
If I scan my finger or I type my unlock code it just jumps back to the authenticate screen again.
Device: Xiaomi A1 (Android One) version 7.1.2

Thanks for reporting this rare bug, @sknsean, have you tried uninstalling the wallet?

No, but the phone is only 1 week old, and freshly installed. Does it work in the emulator with android 7.1.2. If you can't replicate it. I could wait for Google updating the phone...

This is a rare KeyStore bug that we've been unable to reproduce yet. We will investigate the problem, thank you. Please feel free to report any information that might help us.

I'm having the same issue with my phone
New LG K20

Updating that the issue persists on the new android beta

@bryanbecker we appreciate your feedback, have you tried uninstalling the app? The issue persists? This seems like an android KeyStore bug but we're working on finding a solution. Thanks.

I tried first deleting all application data and retrying, but that didn't work.
Just tried a complete uninstall / reinstall.  When prompted to recover wallet, after entering the 12 key words, this time I get:
Android KeyStore Error

Failed to load KeyStore(phrase). Please try to again later or enter your phrase to recover your Bread now.

This drops me back to submit the 12 key words.  After hitting submit a 2nd time, the "Authentication required" loop from the OP starts

Same incident with trying to make a new wallet on Android 7.0, LG Stylo 3

Same issue after the new update :-) Do you have one of the affected devices to test on? Are you able to reproduce the bug?

Same issue after the new update :-) Do you have one of the affected devices to test on? Are you able to reproduce the bug?

@sknsean  we do have the affected device but no luck in reproducing it whatsoever, unfortunately.

@sknsean while having breadwallet installed:

have you modified any fingerprints (add, remove)?
2)Also, have does deleting and reinstalling the wallet not help?
Does removing the screen lock all-together and reenabling it fixes the problem?
Thanks for the help in advance.

Removing fingerprints and the screen lock and reenabling it solves the problem :-)

@sknsean thanks for your help, this information will be useful, we are working on the issue.

After setup of fingerprints, closing the app and reopening, the app shows the keystore error again and we are knocked back to start again :-)

@sknsean I've come across some google docs that state a known keystore issue that is causing this, we might have a potential fix our public beta channel by the end of the week. Thanks for your help.

Hi I'm on version 165, now I don't get an error but after typing my recover words nothing happens when I press "Next".

@sknsean thank you for your help! I tend to think your phone's Keystore is in a malformed state or you're experiencing an android bug, are you willing to be a part of our closed beta so I can try and add different solutions to the wallet and you could try it? Have you saved your paper key?

@Gutyn yes i'm willing to help :-) Yes i have it backed up.

@Gutyn yes i'm willing to help :-) Yes i have it backed up.

@sknsean I very much appreciate your help. Will let you know when I have a potential solution. Have a great day.

@sknsean The research to date shows that this is a known rare android Keystore issue with some Android phones, also I ordered the Xiaomi A1 (Android One) to test it closely and come up with a possible solution. Meanwhile, you could try something for me:

Remove all fingerprints and the screen lock, then re-enable the screen lock AND add fingerprints, now when you are all done, try to reinstall Bread and use it, the point here is to not have ANY modification to the device security after you created the wallet (thus, the keys).
Please let me know if this is a working temporary solution.
Thanks for your help, @sknsean

@Gutyn just tested this, it's the same as before. It seems like the issue is related to the fingerprints, without any fingerprints stored it works just fine.

@sknsean thanks a lot for your help, yes, it does look like a Keystore problem related to fingerprints. Will keep you updated.

Hi :-) Fixed?
Where is the wallet app? I can't find it on the play store

Hi @sknsean if you don't see the app that means you're in Europe and our app was pulled off the market due to some legal issues that are fixed now so you should be able to see it as soon as google unlocks it

Issue still present... Why is it closed?

Issue still present... Why is it closed?

^ My provider nor my phone manufacturer has an update out for 8.0, so it really just passes the blame.

The issue is caused by an OS bug that we have no power over. It still remains one of our priorities to find a workaround or better instruct the user on the precaution steps.

Okay :-) Thank for your support.

One example of the Keystore being weird:
https://issuetracker.google.com/issues/69786239
The KeyStore keeps throwing an exception that the user is not Authenticated (even after authentication) that is what happens in your device that is causing an authentication loop.
There is a possible solution for your phone that I was able to use on some user:
-Uninstall the wallet.
-Remove the home lock screen
-Remove ALL fingerprints
-Install the home lock screen (PIN, Password or Pattern)
-Install all the needed fingerprints
-Install BreadWallet again
I observed this solution to help as long as you don't touch the fingerprint settings (no addition, modification or removal of fingerprints)


Show cursor on the console

Currently, in the console, the cursor is used to print text (and can be moved, but doesn't affect input location), however, it is not visible. Showing the cursor will be a great visual aid in telling the user where the cursor is. Solving this issue, however, might be challenging to implement, my idea is to draw a rectangle over the cursor position and invert the colors on the character it is positioned over. Blinking the cursor could be achieved by using the PIT or something similar.

this is no longer the kernels responsibility (and shouldn't have ever been)


Examples/Console/ConsoleApp: copy appSettings.json to the output directory so that the executable binary could locate it by default.

Fixed a minor issue on the building the Examples/ConsoleApp.  Copy appSettings.json to the output directory so that the executable binary could locate it by default.
Without this fix, the built binary could not locate the appSettings.json, so that setting the OpenAI:ApiKey with a valid key does not make it to work out of the box.

Thanks for sorting that out. When debugging I usually use the secrets file so havn't noticed this. Right click projects-> Manage User Secrets.


Improve tabs ( UI / UX )

Changes

Improve tabs style.
Add animation for active tab.

Before

After

I think this can still make it to v16 :upside_down_face: ^

@kauffj  should I close this ? ^


Docs sidebar UI bug: Navigation bar hidden under window edge

dlt version
n/a
Describe the problem
When navigating through the documentation at Reference > API > common > common.configuration, the sidebar shifts to the left, resulting in the left edge of the sidebar becoming hidden under the window edge. This affects the user's ability to navigate through the documentation as some of the options and text on the sidebar are not fully visible.

Expected behavior
The sidebar should remain fully visible with all text and navigation options easily accessible, regardless of the user's navigation path through the documentation.
Steps to reproduce

Open the https://dlthub.com/docs/
Navigate to Reference > API > common.
Click on common.configuration.

Operating system
macOS
Runtime environment
Other
Python version
3.11
dlt data source
No response
dlt destination
No response
Other deployment details
No response
Additional information
No response

A quick fix for this is to slightly widen the sidebar  (by 25 pixels) and to allow the user to hide the sidebar.
I have coded those changes.  Please assign me the issue and I will raise a PR.
The issue is caused by long module namespaces in the API, for example, common.configuration.providers., which cause wide menu items in the sidebar.   If an even wider namespace is introduced then --doc-sidebar-width could be increased again, within reason.    To mitigate the effects on usability, my change gives users the ability to hide the sidebar if it is distracting them from reading a document.
An alternative solution would be to limit/truncate API namespaces when generating the API documentation.

Hey @deanja, thanks for proposing the fix. I like it. I think it's a practical way to fix. Please submit a PR with suggested changes.


Can't get addorupdatemember to work with tags

Hi,
I am trying to add or update members to a list. Is there a problem with tags?  Because when sending tags to the API they appear like this in the JSON request:
"tags": [
{
"name": "This is a tag"
}
]
This gives a 400 Bad request in return.
This is when I use the Member.Builder() and add a List to  tags like this:
final Member member = new Member.Builder()
.emailAddress(email)
.list(list)
.tags(tags)
.build();
And adding the member with calling addOrUpdateMember on the list. If I remove tags it works and the user gets created. With tags I get 400 Bad request from the API when performing the PUT.
Is there a bug here or do I create tags the wrong way?
According to the API docs https://mailchimp.com/developer/reference/lists/list-members/list-member-tags/ it looks like you should pass a status as well (active or inactive), maybe the MemberTag class should be expanded? Didn't find any documentation on handling tags in the readme so I might be missing something.
Edit:
Tried a little bit after searching through some php examples on stackoverflow.
This is what this wrapper generates when sending MemberTag:
"tags": [
{
"name": "This is a tag"
}
]
The API expects:
"tags": [
"This is a tag"
]
Could get it to work that way in Postman.

I recommend using Member. applyTag(String tagName, TagStatus status) for the interim while we sort out the issues with tags.
e.g. member.applyTag("myTag",TagStatus.ACTIVE);

According to the current Mailchimp API documentation; tags are not supported for Members PUT and PATCH operations. Tags are supported for POST operations and the tags field has a type of array, not object as is currently implemented.
We need to modify the Members JSON generation to reflect the http verb and document how tags are applied by the various create, addOrUpdate, and update methods.

Thanks for the help, using member.applyTags suffices for now. But yeah, would be nice to get that fixed by using the builder, cleaner code.

Note that after further testing we found that this error only occurs when the addOrUpdateMember results in the creation of a new member. It does not occur for existing members or when the member has been previously archived. Tags are only applied when an underlying add operation is performed when an update operation if performed tags are ignored.


Support targeting specific browsers for org:open

Is your feature request related to a problem? Please describe.
It is not uncommon for users of the CLI (and wrappers there of) to have mulitple browsers (e.g. Edge, Chrome, Firefox, Brave) installed and each to be used for specific projects/client etc
What are you trying to do
Would be good to be able to support being able to choose the browser application to use when opening an org with org:open
Describe the solution you'd like
It seems the open package that is used by the plugin-org supports app arguments (e,g, {app: {name: 'firefox'}}) and it seems it might make sense to be able to provide these via a flag such as (note I have just used -b below as an example);
sfdx force:org:open -b firefox -u myScratchOrg

Describe alternatives you've considered
I don't believe, other than switching the OS default browser, that this can achieved any other way
Additional context
If no one else is working on this then I'd be very happy to give this a go and raise a PR as my first towards the CLI plugins :)

@toddhalfpenny - we would be happy to support your PR to the org plugin.  Thanks!

This can be resolved/closed now, no?


Clean architecture project could be better structured on packages, to show clearly the layers

Article and Module Links
Clean Architecture with Spring Boot
Describe the Issue
The article does a very good job to present classes by layers. This could be done on the project at package level too. This is for 3 reasons:

Some of the classes are not mentioned in the article, so people can reference the project as documentation.
It is not a good java practice to put all in one package
MOST IMPORTANT imo is that people can clearly see that entities package doesnt depend on anything, usecases package only has dependencies to entities package etc. This makes even more clear the rule 'a higher level must never depend on a lower one'

Expected Behavior
Similar

I have the solution ready too, if i could get granted access.


CDAP-11445 Use unique headless principal per cluster

This is a cherry-pick of #231 with no conflicts

LGTM


Implement dark mode for CARE

Implement Dark Mode for care.

Do not use the tailwind dark: classes (not worth the pain)

Convert present classes into secondary, primary and other colors. Then let javascript decide what colors they refer to.

This will allow more themes to be configured.

I write this while staring into a white screen in the middle of the night.

@shauryag2002 I will be taking this up

It should support multiple themes just like Github.

Blocked, should be taken up later on as discussed with Bodhi


Protobuf Window installation

this issue is not related to your project but I would really appreciate if you could provide the instruction to install protobuf on windows OS.
Thank you

Sorry but this is better asked on Stackoverflow.

Hi, it's not a problem related with the project, but here is an answer.

Download protoc-3.4.0-win32.zip from here
I tried with 3.6.0 and didn't work. See issue here.
Extract and move bin/protoc.exe to this project's folder.
Run
.\protoc.exe object_detection/protos/*.proto --python_out=.


Remove logging configuration from importing file

This PR intends to remove environment-dependent code
Background
The rake task outputs content to STDOUT, but if we use it from Rails console we would like to use the defaults configured in config/environments/development.rb.
Likewise, if we are in  production, we would like to use the configuration specified in config/environments/production.rb.
To summarise it, we want to get rid of any configuration code related to the the current environment.
We can configure logging per environment in the files:

config/environments/test.rb
config/environments/development.rb
config/environments/production.rb

Developer note:
If the logging information is valuable for the script user we will store it in a more reliable place (Database, filesytem...) We have chosen a quick way to get feedback from the rake task
until we have a better picture about all the issues we have when parsing the data.

Hi @chao-xian, I have updated the PR so we don't have any environment related code. Please, have a look at the commits and let me know if this is ok with you. Cheers

Closing the PR, as it is not needed after #38


EnforcePodAnnotations

Fixes #9 -
TODO:

[ ] Improve error messages (should delineate between missing key, and invalid val)
[ ] Tidy up tests
[ ] ~Consider whether this should also apply to a PodTemplateSpec (e.g. Deployments, StatefulSets) and provide tests for this~
[x] Now applies to all core/built-in Kinds with a PodSpecTemplate - Job, Deployment, StatefulSet, DaemonSet

Remaining:

[ ] Refactor AdmitFunc tests
[ ] Add handler tests for end-to-end checks

Remaining:

[ ] Add tests for other Kinds that wrap a PodSpecTemplate
[ ] Improve error messages (should delineate between missing key, and invalid val)


Introductory calls

To help you get acquainted with the team we suggest you arrange a few calls. Around 30 mins is a good time. Try and find out what they do, how it relates to product and tell a little about yourself.
https://docs.google.com/spreadsheets/d/1rycU_WVQ37-NhzNHnKE4uZzQ-i3gy53xc2n5tksaUtQ/edit#gid=0

All booked in, not yet completed all calls yet


fixed issue #90

Description
The changes made in this pull request should be briefly described.
I change the vertical style form into horizontal form , it is responsive too
Resolves: #90
Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

[x] Have you adhered to the repository's defined coding convention rules?
[x] Have you updated the 'documentation.md' file with the method/function documentation?
[x] Have you sent a message along with the result or response?
[x] Have you used the try-catch technique?
[x] Has the method/class been added to the documentation (md file)?

Screenshots

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

@Ayush-may Try to make it more good for big screens


ADFS Azure Stack storage account doesn't load resources/properties

Storage Explorer Version: 1.8.0
Platform/OS Version:win10 x64
Steps to Reproduce:
1.Install the 1.8.0 version Storage Explorer ,Import the certificate, Target the AZURE STACK.
2.Open it and log on the ADFS AAD account.
3.Randomly click one Storage account.
Expected Experience:
The corresponding blob container, table, queue, property display normally.
Actual Experience:
Nothing displays.

Fix merged to rel branch


Implement missing-blocks-guardian and include it into deb pkg

Explain your changes:

Add missing-blocks-guardian script which is inspired from download-missing-blocks
Copy script to archive debian package

Explain how you tested your changes:

local test on a healthy mainnet archive database hosted on AWS by MF
I am interested in testing it on a broken database
I am interested in testing it from the debian package

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Test on broken DB
[ ] Test from debian package

The script should always report some meaningful message be that usage, error or just info. If other behavior is noticed, please notify me.
@emberian I included you because this will be included in the maintenance replayer  package once it is done.
@dkijania could you help me come up with an idea to test it on a broken DB?

@Smorci  in order to test script against broken database I propose you to utilize archive-block app and devnet or mainnet precomputed blocks. scenario would look like below:

Create empty mainnet database with schema only
Using gsutil download precomputed blocks from o1labs bucket (mina_network_block_data) with prefix devnet or mainnet. You can skip some height (precomputed blocks name format is {network-height-state-hash.json} so you can easily avoid particular heights in order to prepare broken db
Using archive block app import into database downloaded precomputed blocks
Run guardian

I've tested script using mainnet network . Looking good

@Smorci I think we can remove src/app/rosetta/download-missing-blocks.sh script which duplicates script you just developed

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


Remove map file if it was created with the mapping

The behavior mmapbuf should be symmetric, i.e. if the underlying file did not exist before creating the memory map, the file should be deleted when the mapping is removed.

This PR was a bit overzealous I'm afraid. The idea here was that an object should not leave things (files) around when it created them (RAII-style). What I didn't consider is that RAII only applies to resources that are definitely lost if one drops all pointers to it, but files can still be reached through the filesystem, so its kinda pointless (pun intended).
The original motivation was because of the unit tests that left files lying around, cleaning that up should probably be done by the fixture instead.
I will withdraw this PR then.

Okay, I'm glad we ended up on the same page.


SLA Service added

I also modified ubuntu version to ubuntu/precise.
I usually have errors deploying sla-db: "could not install curl (locked or without permissions)". It's strange because I manually execute that line in the script and it works. So maybe it's a problem of parallels apt-gets.
Sometimes other services do not install correctly.

The issues installing mysql on ubuntu14 (libaio not installed) are maybe caused by this problem with apt-get.

@rosogon I'm testing the new yaml, I can't see the SLA core UI, when clicking on Main URI <error code="404" message="null for uri: http://<IP_ADDRESS>:18080/"/>

I must fix that. Try http://<IP_ADDRESS>:18080/providers , please. It should work.

still no luck, <providers/> is the only thing I can see? it that correct?

It's correct. There are no providers in the database.

ok @rosogon I think it is ok
let's keep in mind that we may want to extract sla-core.yaml into a separate file, so to have a better decoupling.
merging it


Is it possible to open the cashier drawer within this lib?

Hi, I've just tried your lib and it worked perfectly for my device.
I would like to know is it possible to open the cashier drawer within this lib? Because I've read the official document there's a function called void openDrawer(ICallback callback) but I don't know how to apply it. could you help please?
Thanks before

Do you have this doc to send me?

yes, here's the document
sunmi_printer_en.pdf

https://github.com/brasizza/sunmi_printer/pull/22


Contact address for code of conduct violations

Should code of conduct violations for all MDAkit projects be reported to @lilyminium ? For now it seems to be what the repo says: https://github.com/MDAnalysis/cookiecutter-mdakit/blob/main/CODE_OF_CONDUCT.md#enforcement

oh no
Happily, the MDAKit projects did have their own {{ author-email }} as replacement in the COC details.


Added details about Lifecycle Hooks

Mostly a clarification for beginners without prior knowledge about what Lifecycle hooks are. Makes it easier to understand when perhaps only knowing that the developer has a mounted() hook.
I left out the function syntax because of generality. Add if it makes more sense to add. I am not fully knowledgable in Vue yet.

Thanks! Great addition. 🙂


Adj_mode_theory Bitrot?

There doesn't seem to be such a file, despite the claims in the comment of mode_theory.ml. I can sort of guess the implementation though. Is it deleted at some point or never written?

Deleted I think. It refers to an earlier version of mitten which dealt with non-preordered mode theories where the adjoint mode theory was quite interesting. I think I have the code deciding the adjoint mode theory laying around somewhere if you're curious, but the rough idea is to capitalize on the equivalence between the walking adjunction and certain 2-categories of finite sets (see "The Free Adjunction" by Schanuel and Street)


iframes : scrolling still enabled even when "Allow scrolling" is unchecked

Environment
Docker
Version
0.15.2
Describe the problem
Scrolling stable enabled when “Allow scrolling” is unchecked
I saved and tried to restart homarr, without success

Logs
homarr    | Exporting hostname...
homarr    | Migrating database...
dash      | listening on *:3001
homarr    | yarn run v1.22.19
homarr    | $ ts-node ./migrate.ts
homarr    | Done in 1.94s.
homarr    | Starting production server...
homarr    | Listening on port 7575 url: http://7a3e42936b18:7575

Context
No response
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

Hey! :-) Whats the current status of this issue? Having the same problems. I try to implement widgets from iOBroker VIS and can't get rid of the scrollbars even if i scale the contents much smaller than the iFrame container :-(.

Hi @Kaskadeur111 , see #1993 for the current project status. We currently are busy with that but contributions are welcome

Thank, looking forward to hearing from you when solved. Thanks for the info :-)


find_framework_suppliers default change

https://trello.com/c/N6rdL6nQ/416-findframeworksuppliers-api-view-and-api-client-method-differ-on-withdeclarations-param

So I've checked the Admin FE and our only usage there explicitly calls with_declarations=False, so that's fine.
In the scripts repo however, there will be some changed behaviour in a handful of the scripts - we'll now be including declaration info in the response (so it'll be much larger!). This is fine but I think it probably warrants a major bump - 20.0.0 and a line in the CHANGLOG.md.


reqMarketRule in ibnext

Hi first of all, great work on the API wrapper. I am using it on and off to trade an ASX smaller stocks privately.
I have mostly done everything using IBApiNext and try to stay away from the normal API right now.
On a lot of contracts that I trade there are varying minimum price increments and the contract details "minTick" doesn't work for that. Apparently I need to query the reqMarketRule and extract the minTick from there somehow. However, that doesn't seem to be implemented in IBApiNext (or maybe I missed it?). I was wondering if there are any plans to add reqMarketRule in the IBApiNext project, or if its better to use the normal API for now and somehow wrap that in a request with a promise that resolves when the value is returned as event.
Thanks!
Thomas

Hello Thomas,
Thank you for bringing this to our attention.
After reviewing the situation, it appears that this call has not been implemented yet. I’ve started looking into it, and while the implementation itself seems straightforward, it has uncovered some additional issues that I’m currently addressing.
I appreciate your patience, and I’ll aim to publish the implementation by late next week.
Best regards,
Ronan


Missing a .msi file

Microsoft PowerToys version
0.53.3
Running as admin

[ ] Yes

Area(s) with issue?
Installer
Steps to reproduce

I had Powertoy before and I don't know if that has to do anything with it
✔ Expected Behavior
To be able to setup Powertoy and use it
❌ Actual Behavior
That error code came up can I could not use Powertoy
Other Software
No response

I have an open PR for updated instructions
https://github.com/MicrosoftDocs/windows-uwp/pull/3624/files Will tell you how to do fox this

I have an open PR for updated instructions
https://github.com/MicrosoftDocs/windows-uwp/pull/3624/files Will tell you how to do fox this

okay

I don't get what to rename. What is "EXECUTABLE_INSTALLER_NAME" also what do you mean rename it to what the file is actually. Do you mean "EXECUTABLE_INSTALLER_NAME"?

Please see the instructions in #14056 (comment) and #14056 (comment) and see if this is enough for you 😄
If not, feel free to let me know or email me at<EMAIL_ADDRESS>to set up a Teams call to guide you through the process if available.

If you downloaded powertoys-setup0.53.exe you would put that there. Then the bootstrapper will spit out the msi
Moving forward, the 0.53 and beyond installers shouldn’t do this.

I still could not find out how to install PowerToys. When I tried extracting the MSI it does not show a response so I don't know if it extracted the file, but I couldn't find the file on my computer, so I don't think it did. I found a different MSI file, but it was "PowerToysBootstrappedInstaller-<IP_ADDRESS>" and not"PowerToysBootstrappedInstaller-<IP_ADDRESS>.msi". Is there a way to just download the MSI file?

Use https://github.com/microsoft/PowerToys/releases/tag/v0.47.1
This is the release you are looking for

I can't run it because a previous version of PowerToys seems to be installed

Never mind I got it. Thank you for the help. This last like worked


Grunt Build in SAP Web IDE

I am running into the local grunt file error in a HTML5 module created in an MTA project.  Any ideas on how that can be fixed?  There is no Build option in the context menu for the module.

@jhornik Can you help Kathie?

Hi @kathiewright - can you provide more details and maybe a screen shot? Can you describe where exactly you right-clicked to get the context menu?
Regards,
Julia

Hi,
We are not supporting an explicit build of the HTML5 module. It's supported on MTA build level only, as a build of entire MTA application.
Thanks,
Alex

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


CSP Note: If ever we use a webview,

app.on('web-contents-created', (event, contents) => {
   contents.on('will-attach-webview', (event, webPreferences, params) => {
     event.preventDefault();
   });
});

Closing for now, as we most likely won't implement webviews. Btw, for future reference, the source of the above snippet is https://electronjs.org/docs/tutorial/security


Correction for raw affiliation IRSTEA Montpellier, UMR TETIS, 34093, Montpellier, France

Correction needed for raw affiliation IRSTEA Montpellier, UMR TETIS, 34093, Montpellier, France
raw_affiliation_name: IRSTEA Montpellier, UMR TETIS, 34093, Montpellier, France
new_rors: ;0458hw939
previous_rors:
works_examples: W2086687760;W42032790
contact: 618f60055ab4e53561c8b515b0917e18:6e20d9372ed1d5a939cae29492f404e57e1a @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Links on images in Google Docs

Does Library recognize and render links that are applied to images within Google Docs? I did some testing and noticed links attached to images were stripped after being rendered in Library.
Is there a workaround for this or did I miss something in the docs? Just curious.

Hey @thomasoide, thanks for flagging this. I think this is a bug in the interaction between Library's formatting logic and exported HTML from the Google Drive API.
Library  does have a power user feature that could function as a workaround. It enables the injection of raw HTML from a Google Doc inside <%- %> brackets which would work around this for now, but it's not enabled by default and requires an environment variable to activate.

I did some digging in the Google Drive API and this appears to be a bug on their end. The HTML in the response from the API is missing links on images, though the problem does not seem to occur for other MIME types that support links.

I've gone ahead and filed a bug report with google here - give it a star if you can!

@leranjun gave thorough steps to reproduce in #287 (closed as dupe):

Context (Environment)
An installation of Library without too much customisation. (I know I'm being vague here, but I think the context should be irrelevant XD)
Expected Behavior
Clicking on an image with a link assigned should take me to the linked site.
Actual Behavior
It does not.
In Google Docs:

Rendered DOM in Library:

No <a> tags at all.
To Reproduce

Add an image to a Google Doc.
Add a link to the image by selecting the image and going to Insert -> Link.
Click on the image in Google Docs. It should display a pop up to the web page as above.
Click on the image in Library. Nothing happens.

Didn't notice there was already an issue! 😄
A temporary workaround I'm using is just wrapping the image in an <a> tag manually, but that requires the inline code feature to be turned on.


Refactor for set idioms

Refactoring several set expressions to:

Avoid building extra intermediate sets (or other data structures)
Use more efficient functions to perform the same operations

In most cases, I think the updated versions are faster, and at least as readable as the original versions. This also addresses my comment in #158.

Can you please rebase?

@DaoWen can you please rebase this PR?

@shamsimam - I can rebase this, but I've been having issue getting the unit tests to run locally. Maybe you can help me with that tomorrow.

@shamsimam - Rebased, and Travis is green.

Waiting on green build


Hide proxy rules for the site

If the extension is disabled through a popup window - then it is better to remove the function with the rules to proxy the current site.

Fixed #507


PoC:update online movie list via intelligent recommendation

Required Info

Host Operating System & Version
{Ubuntu 20.04.2}

Kernel Version (Linux Only)
(5.x)

Branch
{ kantv-androidx }

Android Studio Version
4.2.1

NDK Version
NDK-r14b

Xcode Version
12.5

Language
{C/C++/Java }

Section
{ PoC / AI }

PoC Description
update online movie list via intelligent recommendation

remove all codes to interact with kantvserver from v1.2.1 and terminate kantvserver due to insufficient money to buy higher bandwidth and stronger computing power.


MapService Provider search text must match exactly

https://github.com/Esri/esri-leaflet-geocoder/blob/master/src/Providers/MapService.js#L57
I wonder if there's a valid reason to hard-code contains(false) into this line? When I use the MapService provider, I'd expect that typing search text and pressing enter would return all matching results. But setting contains to false forces the text to match exactly. I'd only expect an exact match if I waited for suggestions and selected one of those.
In this example I'd expect to be able to type in maine and press enter and the map would zoom to Maine. Instead, I have to type in Maine exactly as it would appear to see the result.
Is there another reason for contains(false) that I'm missing?

my first instinct is that pat was trying to make sure and isolate a single result.
we'll need to do a little testing to confirm the behavior when more than one match is returned but in general i agree that it'd probably be more appropriate to omit the contains() method call entirely and improve the fuzziness of the search.
if you can spare the time, please submit a PR and we can continue the discussion there.

Fixed by  8b68a45


New CodeLens PR

I'm going to fix this later but will work on this within the next days.

@realvictorprm can you resubmit this targeting dev15.8.

I retargeted it to 15.8, and merged it with 15.8.  I hope I didn't lose your work.

There shouldn't be any difference, as this was merged into dev15.8 a while back.

That would explain why the commits all evaporated then :-)


Add Conventional Commit to ormus repository

We want to use Conventional Commits to structure our commit message and also automate code versioning & changelog.
We follow the Angular commit message guidelines.
These are some resources that might be helpful:

https://github.com/go-semantic-release/semantic-release
https://mokkapps.de/blog/how-to-automatically-generate-a-helpful-changelog-from-your-git-commit-messages
https://www.philipp-doblhofer.at/en/blog/automatic-changelog-and-versioning-with-git/#:~:text=Commit Convention,also configure your own conventions.
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
https://github.com/marketplace/actions/auto-generate-changelog
https://github.com/cookpete/auto-changelog
https://blog.logrocket.com/automatically-generate-and-release-a-changelog-with-node-js/
https://blog.jobins.jp/generate-changelog-from-git-commit-messages

It would be great to do it without third-party tools and just using GitHub actions. But if it's not possible, the second preference is to use a tool written in Golang so this does not force us to use npm packages (installing node-related artifacts in our ci/cd infra would be a pain).

I'm not really sure but as far as I know we could enforce a tight standard on branch names, commit messages, project validity (it could be built in every commit that we check out) and many other things using github actions. I think we could use post-receive for these kind of things to make sure project is valid at any given commit (but i'm not sure, I'm not an expert).
And to make developers' lives easier we could use libraries like lefthook or husky for go which is inspired from husky.js and using these tools we can implement commitlint rules or any other custom rules. This way any developer can check if their commit is valid and won't be rejected when pushed to a remote repository.

Thanks, Ata jan, husky for go is a good option. We don't need to force this rule in every commit, we can just add it to the pull request cicd pipeline, in this way, everyone who creates a new pull request should set a valid pull commit message.

Also we'll try to keep git history linear (rebase strategy) so for every pull-request developers should squash their commit to single final commit and rebase the branch with main branch. In this way only the final pull-request commit should follow commit message guidelines.

https://github.com/ormushq/ormus/issues/7#issuecomment-1789466932
As far I discover we can define github workflows and track things like pull request at given state like(closed, sync...) here is a demo :
name: validate pull request commit message

on:
  pull_request:
    types:
      - synchronize
      - closed

jobs:
  validate:
    runs-on: ubuntu-latest

    steps:
      - name: Check commit squash commit message
        run: |
          # Fetch the pull request and checkout the merge commit
          PR_NUMBER=${{ github.event.pull_request.number }}
          git fetch origin pull/${{ PR_NUMBER }}/merge:pr-${{ PR_NUMBER }}
          git checkout pr-${{ PR_NUMBER }}

          # Define your commit message pattern (e.g., start with "test:")
          # This is where we can define our commit guidelines and check for them.
          PATTERN="^test:"

          # Get the squashed commit message
          COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD)

          if ! [[ "$COMMIT_MESSAGE" =~ $PATTERN ]]; then
            echo "Invalid squashed commit message: $COMMIT_MESSAGE"
            exit 1
          fi
        continue-on-error: true

      - name: Set Status Check
        if: failure()
        run: echo "Invalid squashed commit message" && exit 1

#7 (comment)
As far I discover we can define github workflows and track things like pull request at given state like(closed, sync...) here is a demo :
name: validate pull request commit message

on:
  pull_request:
    types:
      - synchronize
      - closed

jobs:
  validate:
    runs-on: ubuntu-latest

    steps:
      - name: Check commit squash commit message
        run: |
          # Fetch the pull request and checkout the merge commit
          PR_NUMBER=${{ github.event.pull_request.number }}
          git fetch origin pull/${{ PR_NUMBER }}/merge:pr-${{ PR_NUMBER }}
          git checkout pr-${{ PR_NUMBER }}

          # Define your commit message pattern (e.g., start with "test:")
          # This is where we can define our commit guidelines and check for them.
          PATTERN="^test:"

          # Get the squashed commit message
          COMMIT_MESSAGE=$(git log --format=%B -n 1 HEAD)

          if ! [[ "$COMMIT_MESSAGE" =~ $PATTERN ]]; then
            echo "Invalid squashed commit message: $COMMIT_MESSAGE"
            exit 1
          fi
        continue-on-error: true

      - name: Set Status Check
        if: failure()
        run: echo "Invalid squashed commit message" && exit 1

right now this workflow runs on 'closed' and 'synchronize' status of pull request. all we need is prevent merging when this script throw an error
the commit guidelines can add to the script(see the example that must begin with "test:")

Thanks @DOO-DEV jan, it would be great if you can complete this workflow on a test github repo and commit the code as a pull request for ormus.

One solution I found and work on my test repository:
:bookmark_tabs: First add workflow file under .github/workflows directory

name: PR Lint

on:
  pull_request:
    types: [opened, edited, reopened, synchronize, ready_for_review]
    branches: [main]

  workflow_dispatch:

jobs:
  pr-lint:
    name: Validate PR commit title meets commit convention
    runs-on: ubuntu-latest
    steps:
      - uses<EMAIL_ADDRESS>        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          validateSingleCommit: true
          validateSingleCommitMatchesPrTitle: true

:bookmark_tabs: Configure the repository settings like this:

Turn off "Allow rebase merging"  and "Allow merge commits"

Under Branch protection rules add this rule:

And finally this is the result of the workflow run:

This is my test repository make pull request to test the behavior of this workflow:
:link: https://github.com/DOO-DEV/learning-git-workflows
:bell: If this is ok give a signal to create a pull request @gohossein


Add dependencies to allow FITS to analyze JP2's

Fixes https://github.com/Islandora-Devops/isle-buildkit/issues/352

Thanks Nigel! We're testing this now... more soon.

Our testing is complete, and this is working very well. Thanks again!
Merging...


[$2000] https://staging.new.expensify.com/details crashed app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Was testing something and clicked on https://staging.new.expensify.com/details
Expected Result:
Our standard error page would show
https://www.screencast.com/t/cjYv4o0xprO
Actual Result:
The site/app crashed
https://www.screencast.com/t/CZWzKrlv7
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Firefox (and likely more)
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.2.75-0
Reproducible in staging?: Staging
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://www.screencast.com/t/tN52lVXhLFS3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019da6596d73718432
Upwork Job ID:<PHONE_NUMBER>398630400
Last Price Increase: 2023-03-08

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcochavezf, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

No update yet, this is my priority for tomorrow

This issue was fixed before.

Focused on the LeaveRoom command, making it External meanwhile in case someone wants to propose a solution.

Job added to Upwork: https://www.upwork.com/jobs/~019da6596d73718432

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Current assignee @marcochavezf is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when navigate to /details page directly from browser address bar
What is the root cause of that problem?
DetailsPage is expected to have query params like login or reportID
i.e. https://staging.new.expensify.com/details?login=situchan%40gmail.com
But if we just enter /details without any param, this.props.route.params returns undefined
So it crashes on 2 parts:
1.
https://github.com/Expensify/App/blob/44c19cbd1891a255394f984bab4b815c580c9e13/src/pages/DetailsPage.js#L96
this calls
    removeSMSDomain(text) {
        return text.replace(REMOVE_SMS_DOMAIN_PATTERN, '');
    },

in expensify-common repo.
Here, text is undefined which makes crash

https://github.com/Expensify/App/blob/44c19cbd1891a255394f984bab4b815c580c9e13/src/pages/DetailsPage.js#L100
I think this crash was introduced in #12364 which shows placeholder page instead of full screen loading.
What changes do you think we should make in order to solve the problem?

We should fallback to '' in lodashGet 3rd param
https://github.com/Expensify/App/blob/44c19cbd1891a255394f984bab4b815c580c9e13/src/pages/DetailsPage.js#L88
We should use lodashGet here
https://github.com/Expensify/App/blob/44c19cbd1891a255394f984bab4b815c580c9e13/src/pages/DetailsPage.js#L100

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when navigate to /details page directly from browser address bar
What is the root cause of that problem?
It crashes in the removeSMSDomain function where text is passed as undefined & then we try to do a replace on that. This crash sometimes happens in other parts of the app too, not just details page.
What changes do you think we should make in order to solve the problem?
In removeSMSDomain check for a non-null/undefined value before calling the replace function on it.

This crash sometimes happens in other parts of the app too, not just details page.

I think it's better to leave this for tracking purpose than hiding bug. If we add safety check in removeSMSDomain, it will be difficult to find the root cause of unexpected behavior in the future since crash won't happen.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when navigating to /details
What is the root cause of that problem?
We're not setting the default value for the login params. The login params is required for operations within the DetailsPage like Str.isSMSLogin. And if login is undefined, it will crash the app.
Also we're expecting the params to be defined as in this.props.route.params.reportID, it will also cause the crash here.
What changes do you think we should make in order to solve the problem?

When we're using required string props inside the page, we usually provide a default empty string value for it to make sure it doesn't crash the app. For example in here https://github.com/Expensify/App/blob/0e287b25e3453b5ef0cc1f197e7a38919c0f667c/src/components/ConfirmView.js#L47.
We need to do the same thing for the navigation params passed in the page as well. We can do this by adding
initialParams: {
        login: '',
        reportID: '',
    }

in https://github.com/Expensify/App/blob/6dc3e818e021d69b9d83bba2f59363552c1b8455/src/libs/Navigation/AppNavigator/ModalStackNavigators.js#L132
where we initialize the DetailsPage screen in the navigator.
What alternative solutions did you explore? (Optional)
We can add '' as the fallback value for login inside the render method in DetailsPage, but I don't prefer it because it's more of a case-by-case fix (not general) and is not consistent with how we're handling default value for string props in the page.
Imagine if this happens in another page, we can also just add the initialParams in the navigator rather than adding the fallback '' when we use the param on a case-by-case basis inside the page.

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when someone will navigate to /details page without actually passing any parameter.
What is the root cause of that problem?
When redirecting to /details applicationexpect you to also pass query params in the url which are later accessed in DetailsPage.js
render(){
let details = lodashGet(this.props.personalDetails, lodashGet(this.props.route.params, 'login'));

        if (!details) {
            const login = lodashGet(this.props.route.params, 'login');
            details = {
                login,
                displayName: ReportUtils.getDisplayNameForParticipant(login),
                avatar: ReportUtils.getAvatar(lodashGet(details, 'avatar', ''), login),
            };
        }
..

What changes do you think we should make in order to solve the problem?
This can be solved by adding a conditional check inside the DetailsPage screen to ensure that the required params are defined before using them.
For eg,
render() {
        if (!this.props.route.params || !this.props.route.params.login || !this.props.route.params.reportID) {
            return null; // or show an error message
        }
        let details = lodashGet(this.props.personalDetails, lodashGet(this.props.route.params, 'login'));

        if (!details) {
            const login = lodashGet(this.props.route.params, 'login');
            details = {
                login,
                displayName: ReportUtils.getDisplayNameForParticipant(login),
                avatar: ReportUtils.getAvatar(lodashGet(details, 'avatar', ''), login),
            };
        }
...

Proposal
Please re-state the problem that we are trying to solve in this issue.
The app is crashed when we access details page with no login params. We want to show not found page when that happen.
What is the root cause of that problem?
When we open the page without login params, we dismiss it inside componentDidMount. However, this does not prevent the component to be rendered. Inside the render, we access the login params and pass it to Str.isSMSLogin which will call replace function on the passed variable (which is the undefined login).
https://github.com/Expensify/App/blob/edb7bc9ebaaeabe70f599f152a319e64ab7a5327/src/pages/DetailsPage.js#L96
What changes do you think we should make in order to solve the problem?

Remove componentDidMount
Inside render get the login params and set an empty string as the default value and store it into a new variable called login. This new variable will be used to every place that we currently use.

https://github.com/Expensify/App/blob/edb7bc9ebaaeabe70f599f152a319e64ab7a5327/src/pages/DetailsPage.js#L85-L94

Inside render get the reportID params and set an empty string as the default value and store it into a new variable called reportID and pass it to shouldShowBackButton = Boolean(reportID).
Wrap the component (as ScreenWrapper children) with FullPageNotFoundView and set the shouldShow with Boolean(login)

I think we should show the error page as that's what's shown when you go to a random URL like

@mallenexpensify can you confirm if this should be a full-screen error page or it just shows in the right side modal like this?

@mananjadhav, @marcochavezf, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Checking on the expected behavior here
with the goal to update the testing guidelines  once I find out.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes on navigating the /details page without query param
What is the root cause of that problem?
As we are expecting the query param login for the details page and on missing of the same it will try to operate string function(replace) on undefined which is causing the issue.
What changes do you think we should make in order to solve the problem?
Check the login query param first in the render method and in case of unavailable make the return statement which consists of the ScreenWrapper wrapping the FullPageNotFoundView component which will help to prevent unwanted further execution.
https://github.com/Expensify/App/blob/6b2a7690ee170994f1e533473b88fb4802957b54/src/pages/DetailsPage.js#L85
With that, componentDidMount won't be required as it is dismissing the modal which is not the requirement now.
We can take the below line to the first place to decide whether to show back button or not for 'not found page'.
https://github.com/Expensify/App/blob/6b2a7690ee170994f1e533473b88fb4802957b54/src/pages/DetailsPage.js#L100
Above changes will show the Not found page on the right pane.

@mallenexpensify can you confirm if this should be a full-screen error page or it just shows in the right side modal like this?

@tienifr the error page should cover the main chat window on Web/Desktop (assuming it's not minimized) and the full page on mobile.

@mallenexpensify I'm afraid it's not possible to show it like that. The SS you provided is a not found chat and we need to be on the chat/report screen to show that, but if we open /details, we will be at the details screen.
Report screen -> Details screen (we are here).
We can either show a full page not found or just at the RHN. Looking at the other RHN screen, they all show not found page at the RHN (example https://staging.new.expensify.com/r/1/details)

https://staging.new.expensify.com/details/random shows not found page on full screen

https://staging.new.expensify.com/details?login=test shows not found page on modal (Detail page)

2nd one is quick and easy to implement

@mallenexpensify  for the /details route we already reached the right pane and there only we are validating data to decide whether to show not found page or not which ultimately shows that page in the right pane.

Thanks @bernhardoj and @Pujan92 .   If we're unable to show the error message in the main chat window, let's do RHP/RHN

@mananjadhav or @marcochavezf , if you have time can you review the above proposals?  You both might be traveling the next few days though so, apologies for any delays for the reviews

@mananjadhav @marcochavezf @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Put on hold as ExpensiConX is this week and it might take a bit to review the above

@mallenexpensify A bit confused here with all the comments, is the GH body the right expected result? Is this what should I assume the expected result to be?

With @bernhardoj mentioning FullPageNotFoundView first in the proposal I am going ahead with their proposals.

I first proposed this on Mar 3 10:51 CST
@bernhardoj proposed this on Mar 3 10:57 CST

I can't make out from the edits which one was first.  The first version if your proposal doesn't mention it, where as @bernhardoj's mentions it.

A quick note to the contributors, if you're adding any revisions of the proposals that update the logic of the proposed solution, I would recommend sending it a new comment

and hence I explicitly highlighted this.

Oh, there's no guideline about that. I noted it now and whenever I find similar case where edited proposal (without new comment with "Proposal updated") was accepted, I will report that.

Oh, there's no guideline about that. I noted it now and whenever I find similar case where edited proposal (without new comment with "Proposal updated") was accepted, I will report that.

Yeah, I think we'd need to update the guidelines about the edited proposals. Thanks for noticing that.

With @bernhardoj mentioning FullPageNotFoundView first in the proposal I am going ahead with their proposals.

Thanks @mananjadhav also the proposal LGTM. Assigning @bernhardoj 🚀

PR is ready for review.
cc: @mananjadhav

Reviewing label has been removed, please complete the "BugZero Checklist".

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mananjadhav / @marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mananjadhav / @marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mananjadhav / @marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@mallenexpensify] Determine if we should create a regression test for this bug.
[ ] [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Seems this was an unhandled edge case, and I don't think was introduced by another PR. Also, the regression tests will be enough to prevent this bug in the future, no need to update the checklist here.

Agreed with your assessment @marcochavezf.
@mallenexpensify This is due for payout. Can you please help?

Thanks @mananjadhav.  Can you and @bernhardoj can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01512148a62908748b
It doesn't appear a bonus is due as there were 6 days between hire and merge.

Accepted.
Can we take @mananjadhav approval as the merge date, because the next few days is just some discussion that requires no changes to the PR?

Yeah I think we finished the checklist within a day, and the discussion that happened didn't have any rework/changes. I think the bonus should apply.
@marcochavezf what do you think ?

@bernhardoj and @mananjadhav paid $2000 each.
I've added this issue to a new Edge Cases section of the Testing Guidelines doc - link

@mallenexpensify did you get a chance to look this comment ?

Thanks @mananjadhav , I missed that, sorry.
Usually it'd be the engineer merging the PR that is the trigger.  So, you're saying that the PR was cool but you chatted about for a while to make sure it was good, then Marco 👍 it?
My main concern here is we don't want to set precedence where others reference this issue/PR and say... "it happened here, therefore I should get the bonus to".
Let's let @marcochavezf chime in

Thanks for o

Yeah, we're ok with the bonus here. The delay here was caused by me, and @mananjadhav is correct about a post-implementation discussion that didn't happen and also delayed the merge (but the PR was already reviewed and tested within a day).


Put viz test in a script

This means that the same test used in CI can also be used on the commandline,
and with bisection, 'git bisect run parsl/tests/test-viz'
Type of change
Choose which options apply, and delete the ones which do not apply.

New feature (non-breaking change that adds functionality)
Code maintentance/cleanup

This probably has some interaction with #2078 as this PR changes travis behaviour, not github actions behaviour


 The SWNetworking.podspec states support for iOS7, but in SWRequestOperation.m you use NSString localizedCaseInsensitiveContainsString method which is not available for iOS7.
greets!

Thanks for the information and its fixed.


Setting learning phase for inception_resnet_v2

This issue leads me to believe that I simply need to insert a bit of code into the classifier method under inception_resnet_v2.py but I don't know if this is necessary since it seemed fined training initially. It's only having this problem when predicting.
Traceback (most recent call last):
  File "test_frcnn.py", line 199, in <module>
    [P_cls, P_regr] = model_classifier_only.predict([F, ROIs])
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/keras/engine/training.py", line 1573, in predict
    batch_size=batch_size, verbose=verbose)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/keras/engine/training.py", line 1203, in _predict_loop
    batch_outs = f(ins_batch)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 2103, in __call__
    feed_dict=feed_dict)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 950, in run
    run_metadata_ptr)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1173, in _run
    feed_dict_tensor, options, run_metadata)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1350, in _do_run
    run_metadata)
  File "/Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1370, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: You must feed a value for placeholder tensor 'Stem_block_conv1_bn/keras_learning_phase' with dtype bool
	 [[node Stem_block_conv1_bn/keras_learning_phase (defined at /Users/carnett/apps/python-virtual-environments/keras_fasterrcnn/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py:103) ]]

It seems if you use newer versions of Keras, this problem does not happen. I would like someone else to confirm this for me.

Updating to the latest version of this keras fixed this issue for me.


Make sure batch size is fine for consumer GPU memory with fp16 (or if it doesn't work)

Need to pick the batch size so people can do something useful with it downstream I guess

Joseph Turian, [12.03.21 07:56]
anyway, what I'm saying is we can pick a batch size that accomodates 2GB with fp32 generation
Joseph Turian, [12.03.21 07:56]
let's just say for the sake of argument it's 64
Joseph Turian, [12.03.21 07:57]
and then we profile and see if there's a big boost going to like 1024
Joseph Turian, [12.03.21 07:57]
and if so we just define the test split in such a way that it's easy to get the test split both with batchsiez 64 and with 1024

Related to https://github.com/turian/torchsynth/issues/143 if we get fp16 working for real this will help a lot.

Memory profiling on V100:
Batch size vs MiB
64 3511MiB
256 5061MiB
1024 11263 MiB
Curious what @jorshi gets on his 2080 Super


typescript support

Hey.
I'm not familiar with typescript so it will be great if you clone\fork the project and add typescript by yourself, it may help others :)


Sleep for 2ms to avoid time-sensitive test failures

Experienced this issue and tracked it down:
https://github.com/TBD54566975/dwn-sdk-js/issues/481
This might be some sort of precision bug within Temporal itself, I'm not really sure how various NodeJS systems handle time precision.
But in these cases there simply needs to be a gap in time for the testing logic, increasing the gap by an additional millisecond will make sure these tests are accurate.

@thehenrytsai I really like that idea, let me put that in this PR so we can set precedent.


Missing authentication

Go Trello is almost useless without the authentication. Priority #no 1.

Fixed in #6


Main Jitter Update

Removing the linear_jitter_model method from the Toliman instrument and instead creating a separate JitteredToliman instrument with similar functionality.
This PR supercedes #18

Would be good to add some basic tests to ensure that these changes aren't breaking things, but that should maybe be in a different PR


Create Generic Map/Set Serialisers

We should be able to serialise maps/sets by specifying the serialisers for the objects they hold, rather than creating new Map/Set serialiser every time we counter a new type/type combination.

Migration steps
If you had for example a storeType of prop.string previously you may have specified your serialiser like so :
{
"prop.string": {
"serialiserClass":  "uk.gov.gchq.gaffer.serialisation.implementation.StringSerialiser"
"aggregateFunction": {
"class": "uk.gov.gchq.gaffer.function.ExampleAggregateFunction"
}
}
}
Now you should specify the same like so:
{
"prop.string": {
"serialiser": {
"class" : "uk.gov.gchq.gaffer.serialisation.implementation.StringSerialiser"
},
"aggregateFunction": {
"class": "uk.gov.gchq.gaffer.function.ExampleAggregateFunction"
}
}
}

Merged into develop.


Updated copyright to 2016

@aqnouch thank you!

I updated that manually, because your repo was gone, and I couldn't merge it with my script :)


Error msg: HTTP Status 400, code: 400 several minutes

After several minutes without any problems it suddenly throws these errors and won't reconnect:
Event msg: error, code: 11
Debug msg: Terminating the server connection...
Error msg: HTTP Status 400, code: 400
Event msg: authenticating, code: 7
Debug msg: Connecting to server...
Event msg: auth request sent, code: 8

You should follow the library provided examples.
The error is about you are doing something wrong with your code:
1 Setting the wrong URL in the Realtime Database
https://github.com/mobizt/FirebaseClient/blob/6025703f70d25897ebfcc2d6194c16a628e8dd69/examples/RealtimeDatabase/Async/Get/Get.ino#L121

Setting the URL via url function in other Firebase service class which it is prohibited.

Docs.utl("do not set any url here");

The possible another causes are

You provided the wrong credentials in authentication/authorization class.

If you use ESP8266 WiFiClientSecure or ESP_SSLClient and the buffer size for RX and TX buffer for BearSSL you set via setBufferSizes are too small.

If you are using ServiceAuth and CustomAuth classes, the service account credentials are not valid.

Google blocks your API request due to too frequently request (Google API bandwidth limit reached) which may be happen in case your device crashed because of out of memory or stack overflow and restarted when it is trying to access the Google APIs.

In this case, you have to wait for 30 minutes and try again.
You should test with the example that works and adapt from it.


Documentation issue - associative_scan

https://github.com/google/jax/blob/e95d5701e33bda30299a8c87aa43b61a686c1b01/jax/lax/lax_control_flow.py#L2352
Hi,
It should clearly be used from lax, and not numpy + it seems that the Example format does not follow the docstring style, so it doesn't show properly in the readthedocs page.
Adrien

Thanks for raising the issue! We'll make certain this gets corrected.


Add support for VALUE inside checks (a stub for domains)

Reference: https://www.postgresql.org/docs/9.5/static/sql-createdomain.html

CHECK clauses specify integrity constraints or tests which values of the domain must satisfy. Each constraint must be an expression producing a Boolean result. It should use the key word VALUE to refer to the value being tested. Expressions evaluating to TRUE or UNKNOWN succeed. If the expression produces a FALSE result, an error is reported and the value is not allowed to be converted to the domain type.
Currently, CHECK expressions cannot contain subqueries nor refer to variables other than VALUE.

Because check constraints for domains only receive a single value, I made VALUE refer to the base context.

Current coverage is 67.21% (diff: 100%)

Merging #746 into develop will increase coverage by <.01%

@@            develop       #746   diff @@
==========================================
  Files             1          1
  Lines          9791       9803    +12
  Methods        1025       1029     +4
  Messages          0          0
  Branches       2924       2926     +2
==========================================
+ Hits           6580       6589     +9
- Misses         3211       3214     +3
  Partials          0          0

Powered by Codecov. Last update c505af9...b4394ac

Thank you for more awesome code


Consider moving to Tailwind.css

Or https://theme-ui.com/
Usage example: https://github.com/narative/gatsby-theme-novela

Result: doesn't worth currently. The project is relatively small and it's easier currently to maintain own css and don't use Tailwind which size is huge without optimization. Additionally, it increases building/rebuilding time.


Guidelines for layout module

From andrew.hankinson on September 08, 2011 11:05:46
Placeholder issue for layout module guidelines
Original issue: http://code.google.com/p/music-encoding/issues/detail?id=30

From<EMAIL_ADDRESS>on August 02, 2012 11:07:32
Labels: -Milestone-ReleaseNext Milestone-Release2013

From<EMAIL_ADDRESS>on September 17, 2012 12:39:54
Status: Fixed


Regex: support duplicated named captures

Currently we cannot use duplicated named captures by default:
/(?<foo>a)|(?<foo>b)/ # compile error!

But we can use (?J) for this:
/(?J)(?<foo>a)|(?<foo>b)/ # it can compile, but...

Unfortunately, Regex::MatchData does not support duplicated named captures, so this code is broken:
"a" =~ /(?J)(?<foo>a)|(?<foo>b)/
pp $~["foo"] # => nil (!!?)

This PR fixes Regex::MatchData to support duplicated named captures, and Regexp accepts duplicated named captures by default. Duplicated named captures are useful when writing complex regexp. Thank you.

Current crystal compiler cannot compile regexp contains duplicated named captures, so CI is failed. Should I replace regexp literal to Regexp.new "..." as work around?

I should fix this document also.

https://github.com/crystal-lang/crystal/pull/5061#issuecomment-333273257 I want some opinion to this.
/cc @asterite @mverzilli @RX14

Yeah, using Regex.new with a note to switch it back on the next release is a good idea.

@RX14 fixed this.


[@shopify/react-form-state] expose reset to support using it outside of render prop

Overview
I would like access to the reset function in private method when using <FormState />
Motivation

What inspired this enhancement? What makes you think this should be in quilt?

I am using a Modal with FormState, I would like to reset the form whenever the Modal closes.
example
<FormState>
  {formDetails => {
          const {fields, submitting, submit, valid} = formDetails;
          <Modal
              open={this.state.open}
              primaryAction={{
                content: 'Save',
                onAction: submit,
                disabled: submitting || !valid,
              }}
              secondaryActions={[
                {
                  content: 'Cancel',
                  onAction: this.handleClose(),
                },
              ]}
              onClose={this.handleClose()}
            >...</Modal>
 }}
</FormState>

 @autobind
  private handleClose() {
    this.setState({open: false});
   // how to get reset from <FormState /> ?
   reset();
}

Possible way to resolved this
After chatting with @TheMallen , she have suggested exposing reset as a public method on ` so we can access it using ref.
example
<FormState ref={this.setFormState}>
  {formDetails => {
          const {fields, submitting, submit, valid} = formDetails;
          <Modal
              open={this.state.open}
              primaryAction={{
                content: 'Save',
                onAction: submit,
                disabled: submitting || !valid,
              }}
              secondaryActions={[
                {
                  content: 'Cancel',
                  onAction: this.handleClose(),
                },
              ]}
              onClose={this.handleClose()}
            >...</Modal>
 }}
</FormState>

 @autobind
  private handleClose() {
    this.setState({open: false});
   // how to get reset from <FormState /> ?
   reset();
}

The other solution is to just let people use () => 'arrow functions ✨' in our linters, which we also want to do :p

Yeah, an inline function is the way to do this, no need for additional API.


zarf tools registry pull doesn't seem to respect --platform in newer version

Environment
Device and OS: amd64, RHEL 8
App version: 0.34.0
Kubernetes distro being used: k3s, but not relevant here
Other:
Steps to reproduce

Download both zarf 0.33.0 and zarf 0.34.0 on an amd64 native Linux machine,
Make both executable and run the following:
$ ./zarf_v0.33.0_Linux_amd64 tools registry pull --platform linux/arm64 registry.k8s.io/pause:3.9 test-0.33.0.tar
$ ./zarf_v0.34.0_Linux_amd64 tools registry pull --platform linux/arm64 registry.k8s.io/pause:3.9 test-0.34.0.tar

Expected result
-rw-r--r--. 1 root root    268288 May 31 12:21 test-0.33.0.tar
-rw-r--r--. 1 root root    268288 May 31 12:21 test-0.34.0.tar
And both image archives should contain arm64 versions
Actual Result
-rw-r--r--. 1 root root    268288 May 31 12:21 test-0.33.0.tar
-rw-r--r--. 1 root root    322048 May 31 12:21 test-0.34.0.tar
The size of 322048 happens to be the amd64 version of pause.
Visual Proof (screenshots, videos, text, etc)
Severity/Priority
Priority is up to you of course, my workaround for now is continue using 0.33.0. I have not tested 0.33.1/0.33.2 yet to see where it breaks.
Additional Context
Add any other context or screenshots about the technical debt here.
It's not just the pause image, seems to be any image, pause is just small and happened to be the first one I noticed. You can see it with nginx too for example which is a popular one:
$ ./zarf_v0.33.0_Linux_amd64 tools registry pull --platform linux/arm64 nginx nginx-0.33.0.tar
$ ./zarf_v0.34.0_Linux_amd64 tools registry pull --platform linux/arm64 nginx nginx-0.34.0.tar
-rw-r--r--. 1 root root  67664896 May 31 12:24 nginx-0.33.0.tar
-rw-r--r--. 1 root root  71000576 May 31 12:24 nginx-0.34.0.tar

Verified the issue is NOT present in 0.33.2. So this is a brand new issue with 0.34.0.

I have verified that this is a regression caused by #2460. During the refactoring of image pulling the options slice was changed from a pointer to a a value. The problem here is that the arguments are evaluated immediately and due to how the platform options are populated these are run at a later time.
I will create a PR to fix this.


Add mock_async_callable for asyncio support

Add a mock_async_callable DSL which works exactly like mock_callable but for async functions.
The decision to not patch mock_callable to support async functions was intentional and made to make it clear when reading the test what kind of code is being mocked. Just as you can't just stick async in front of a function and expect everything to work, you shouldn't rely on mock_callable just working either.

Neat! This seems in a good direction! There are a few things that we need to look over as well:

Documentation needs to be updated to explain about async usage (including test framework integration) . Tip: do make docs to build and test locally.
mock_callable() supports a lot of different configurations. I don't expect them all to work with the current implementation, we need tests for all of them.

From the top of my mind, I do expect these to "just work":

.to_return_value(value)
.to_return_values(values_list)
.to_raise(exception)
.and_assert_called_exactly(times)
.and_assert_called_once()
.and_assert_called_twice()
.and_assert_called_at_least(times)
.and_assert_called_at_most(times)
.and_assert_called()
.and_assert_called_ordered()
.and_assert_not_called()

But I have my doubts about these:

.for_call(*args, **kwargs)
.to_yield_values(values_list)
.with_implementation(func)
.with_wrapper(func)
.to_call_original()

Unfortunately Python has shown to be full of quicks and exception cases on how things work. The current tests, while hard to maintain and confusing (sorry about that), were extremely helpful in getting all corner cases in the past, we'd loose a lot if we did not have the same coverage for async.
Ideally, we'd need to duplicate all sync wyth async equivalents of the tests, but in some cases (eg: iterator, calling original) we'd need more async specific stuff. I'm happy to assist you on that if needed.

Thanks for the comments @fornellas, I'll update this PR with the requested changes

@fornellas  I'm still working on this, not ready for review yet. Just pushed my changes so far so I don't lose them.

FYI, #59 should help testing async stuff, I'm still working on it.

@jivid as we spoke, I'm gonna start working on this issue now so we can deliver it ASAP. I'm closing this PR so we don't clash, but feel free to ping me to join forces if you can spare bandwidth.
Thanks for what we have here already, I have something to grow on top :-D


Mechanism for installing additional updates from pip

Today, I'm merging a PR that requires the system to have one more Python module installed through pip (namely, vobject). Latest SD card image, though, doesn't have it available, so if a user will update ZPUI through git (the only update mechanism available for now), they'll lack the package and the part of ZPUI that requires this package will no longer work. In this case, it's an app, so it'll just fail to load and ZPUI will continue working - but it's still a 2-second message shown to the user during bootup which blocks the bootup, not too user-friendly. That's not the only problem:

Actually solving the problem (installing the module using pip install) will require user's manual intervention, not only having to log in through SSH and install the library, but also figure out which library needs to be installed.
Some crucial app might stop working if made depend on some not-yet-installed library (of course, adding hard dependencies has to be thought out by the developer if an app already has users relying on it, but it's a problem nevertheless)
In case with core ZPUI subsystems, as well as drivers, this might make ZPUI inaccessible from the user, which is a bad thing to do.

For now, I'm likely going to make a helper for this (based on this SO question), with install instructions, then test it and roll it out to users. However, is this the proper solution to this problem? For example, once this helper is used in the module, it's going to have to remain there (since there are going to be users not updating ZPUI until after the helper is removed), unless some other solution is found.

Thanks for raising the issue.
Since the update mechanism is git based at the moment, I'd recommend not adding a second layer (a.k.a. using pip in ZPUI itself). It would confuse maintainers (two place to read the update code) and add a dangerous dependency. (How do you update ZPUI using ZPUI if you broke it?)
I would recommend updating the update.sh script instead, and optionnaly putting a post-update git hook.
The good practice for PyPy dependencies is having a file called requirements.txt at the root of the project.
So the script would:

Pull the git repo
run pip install -r requirements.txt
run tests
copy to installation folder
If any point fails, return or prompt the user to ask if we need to continue.

see #35 for a concrete proposition/implementation

Your proposed update process, together with the changes I'm suggesting, will allow seamless installation of dependencies during both CLI and UI update processes, so once #35 is merged, the issue will be solved =)

Speaking about updating ZPUI while running ZPUI - I completely agree. However, 1) it's the only viable option so far - we can't have users logging through SSH just to update the UI 2) we do, in fact, need to add safeguards to the update app to make sure that ZPUI can be successfully launched again, and your proposition with running tests helps with that goal a lot.


I installed this package and my node app is not at all working!

I installed this package and I saw 2 deprecation warnings in the console (related to bodyParser). And then my perfectly functional express app never ran thereafter. I'm having trouble running my other nodejs apps also. None of them seem to work.

@Aditya-ds-1806 I have released a new version of this module and everything is working fine now. Please have a look. Please let me know if you are facing any problem.


Defining a tilemap causes Phaser.Tilemap is not a constructor error

If i try:
  create() {
    //  Creates a blank tilemap
    var map = this.add.tilemap('map');

I get the error Uncaught TypeError: Phaser.Tilemap is not a constructor -- whats the correct way to create a timemap using the generators structure?

Are you using the "no physics" build option? If so, there's no Tilemap class. You should at least choose the "Arcade Physics" build to get Tilemaps working. This is how Phaser was designed.
Check the tasks configuration (gulpfile.js/config.js) to change the Phaser build option.

Yup no physics! That would explain it. facepalm


IE11 long modal scrolling

dimmed isn't assigned/added to body when opening long modal in IE11
Steps

Open long modal in IE11

Expected Result
The modal should be scrollable

Actual Result
The modal isn't scrollable

Version
0.68.5
Testcase
Open in IE11 https://codepen.io/anon/pen/gRrPRo

duplicate? https://github.com/Semantic-Org/Semantic-UI-React/issues/1157

Yep, it's dupe of #1157.

I'm not sure. Because it's reproduced with one modal and only on IE11

c'mon guys. It not duplicate. However #1157 reproduced in every browser and this bug reproduced only in IE11. Have you tried to open ONLY ONE long modal in Chrome and in IE11 ?

I used link to codepen from #1157 to keep it alive. It might confuse you...

@sergez You're right, thanks for clarification. I've checked in IE and there is really something wrong.
Chrome

IE

We can leave this open for investigation, but highly likely that this is a CSS issue which should be fixed over at https://github.com/Semantic-Org/Semantic-UI.

It looks like the 'dimmed' class is not being added to the body element in IE11 when the modal is opened.
The problem is probably that IE11 does not support multiple parameters in classList.add().
See handlePortalMount() in Modal.js
handlePortalMount = (e) => {
    debug('handlePortalMount()')
    const { dimmer } = this.props
    const mountNode = this.getMountNode()

    if (dimmer) {
      debug('adding dimmer')

      // FIXME - needs workaround to work in IE 11?
      mountNode.classList.add('dimmable', 'dimmed')

      if (dimmer === 'blurring') {
        debug('adding blurred dimmer')
        mountNode.classList.add('blurring')
      }
    }

    this.setPosition()

    const { onMount } = this.props
    if (onMount) onMount(e, this.props)
  }

Using a classList polyfill (https://github.com/yola/classlist-polyfill) resolved this issue for me.

@zlove thanks for the investigation :+1: PR is coming

Happy to help @layershifter. Thanks for the quick fix!

This is an issue again.  The testcase in the original issue report still applies in IE11.  Opening the modal does not apply classes dimmable dimmed  or scrolling.  Cannot scroll in the resulting modal.


multiply by 2 when calculating floating-point operations?

from thop import profile
input = torch.rand((1, 6, 256, 256))
gflops,params = profile(model,inputs=(input,))
**gflops = gflops*2 / 10**9**
params = params / 10**6
print(gflops,'==============')
print(params,'==============')

 Hello, why do we need to multiply by 2 when calculating floating-point operations? @ZZZHANG-jx

The profile function in the thop library only considers the number of multiplications. If you also account for addition operations, the final FLOPs are approximately twice the result. For more details, you can refer to this link.

@ZZZHANG-jx I get it, thanks for u kind replay


Testing access to Amazon Mechanical Turk... ERROR! HTTP Error 403: Forbidden

I  create a IAM User ，but I don't know what permissions should be granted. It always shows that permissions are not granted.error like this:
Testing access to Amazon Mechanical Turk... ERROR! HTTP Error 403: Forbidden
Testing access to database server... OK
Testing access to web server... OK
AWS.NotAuthorized
The identity contained in the request is not authorized to use this AWSAccessKeyId<PHONE_NUMBER>810 s)

I used docker ,is this have some impact?

Are you using the master branch of VATIC? Do you think this error is caused by the deprecation of the Mturk API (https://docs.aws.amazon.com/AWSMechTurk/latest/AWSMturkAPI-legacy/Welcome.html)?
P.S. I'm working on a fork that will update to the new API

Are you using the master branch of VATIC? Do you think this error is caused by the deprecation of the Mturk API (https://docs.aws.amazon.com/AWSMechTurk/latest/AWSMturkAPI-legacy/Welcome.html)?
P.S. I'm working on a fork that will update to the new API

yes,thank you for your help,due to this cause!!!
Have you finished the work yet?
I am looking forward to you new update.


correcting elm version in README.md

I have just updated the elm platform version it the README.md file to reflect the source code.

Thanks


Could not calibrate magnetometer on BeagleBone Blue

Describe the bug
Could not calibrate sensors (mag, accel, gyro) on BeagleBone Blue board.
Every calibration ends up with several timeout error messages.
When installing the board to the actual frame of the drone, it is almost impossible to fly due to the huge instability and constant jerking.
To Reproduce
Steps to reproduce the behavior:

Board powered up
px4 service is started manually by using the following command:

sudo build/beaglebone_blue_native/bin/px4 -s posix-configs/bbblue/px4.config

By using WiFi QGC connects to the px4
Starting calibration of the compass or gyro from Sensors menu
Calibration failed with a timeouts

Expected behavior
Calibration succeed. Drone behaves stable when in the air.
Log Files and Screenshots
calibration_console_log.txt

Drone (please complete the following information):

standard quad 450

Additional context
OS: Debian for BeagleBone family
Kernel: 4.14.71-ti-rt-r80

Just FYI, I'm not aware of anyone currently using PX4 on the BeagleBone Blue, so you'll probably have to fix these things yourself.

Also, the plan is to deprecate the DriverFramework at some point which would mean some changes for the BBB coming up. On the flipside this would then make thinks like calibration consistent again and prevent these sorts of issues.


@W-14072135@ Add ability to wait for deployment to finish after pushing.

Deploy as usual with pwa-kit-dev push, but add the --wait flag. The script will now wait for deployment to finish before exiting!
Description

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Can you provide how to test drive this PR?

So the command to use this is pwa-kit-dev push --target someTarget --wait where target is an environment id from the project in MRT?


validations should not be run on localhost

Describe the bug
in omnia.yml
- name: Validate the cluster
  hosts: localhost
  connection: local
  gather_facts: no
  roles:
    - cluster_validation

validation should never run on localhost, only on manager and compute systems.

Validations are running on localhost (management node) for 2 reasons:

We are validating if the inventory is correctly set by user or not and we are trying to verify that from the management station itself. Running validations on manager/compute might not give desired results. Eg. In case if user doesn't add any host in manager group, the validation will get skipped and in case when there are multiple compute nodes, validations will run multiple times on all compute nodes.
In the same role we are fetching cobbler and slurm DB passwords from input_config.yml which is present on localhost (management station).

Validations are running on localhost (management node) for 2 reasons:

We are validating if the inventory is correctly set by user or not and we are trying to verify that from the management station itself. Running validations on manager/compute might not give desired results. Eg. In case if user doesn't add any host in manager group, the validation will get skipped and in case when there are multiple compute nodes, validations will run multiple times on all compute nodes.
In the same role we are fetching cobbler and slurm DB passwords from input_config.yml which is present on localhost (management station).

@sakshiarora13  localhost has a few possible roles:

a management server remotely connected to servers were the  manager and compute  roles are applied
a management server that applies the manager role to itself
a single laptop or server that that performs all 3 roles

we need to cover those cases when validating on localhost

@sakshiarora13  localhost has a few possible roles:

a management server remotely connected to servers were the  manager and compute  roles are applied
a management server that applies the manager role to itself
a single laptop or server that that performs all 3 roles

we need to cover those cases when validating on localhost

@j0hnL These scenarios will be validated correctly.
The intent of using localhost is to validate the inventory file once. If we validate on manager and compute, validations will run multiple times.
We only intend to verify if inventory has been created correctly by user.

both slurm and kubernetes should not be given in skip tags.
manager group should have 1 host.
compute group should have atleast 1 host.

Do you want to change this behaviour?

@j0hnL These scenarios will be validated correctly.
The intent of using localhost is to validate the inventory file once. If we validate on manager and compute, validations will run multiple times.
We only intend to verify if inventory has been created correctly by user.

both slurm and kubernetes should not be given in skip tags.
manager group should have 1 host.
compute group should have atleast 1 host.

Do you want to change this behaviour?

looks good to me!

looks good to me!


(BUG) Re-send isn't performed after clicking the "Try again" button in the "Link generation failed" pop-up

Steps to reproduce:

Form request to send G$ (fill name/amount of G$/message)
Click the "Confirm" button (something wrong with the transaction and appeared the "Link generation failed" pop-up )
Click the "Try again" button
Pay attention to the not working "Try again" button

Actual result: Re-send isn't performed after clicking the "Try again" button in the "Link generation failed" pop-up
Expected result: Re-send should be performed after clicking the "Try again" button in the "Link generation failed" pop-up
Checked on QA env (0.20.2)
LG V30+ // Android 8.0 // Google Chrome
Video: https://www.screencast.com/t/H4mfaeK9gDzj

Verified as fixed.
Checked on Dev env 0.20.2
Devices used:
Redmi 7 // Android 10
iPhone 6S // iOS 12.4


Save Extension Options

I would like to add the Import option to specify the save extension for LDTKLevel files as either scn or tscn, and the save extension for tilesets as either res or tres (scn and res are the defaults to align with the old behavior):

This feature aims to provide the flexibility to version control the output of the plugin as either binary or text files, without having to write custom post-import script to export resources to tscn/tres format. This follows Godot's philosophy to generate VCS-friendly and human-readable files.
Thanks for your work on this plugin!

Renamed branch to save-extension-options. See #48.


How to get the submission id of all venues?

Hi,
I tried to follow this link to get all submissions of some of the venues.
And I have tried AP1 V1 and V2. With API V1, I can only get some of them with "Blind_Submission" and "Submission", so I tried all venues, and it seems only 35%. (I also tried 'submission' and get 7 more result) And with API V2, only venues in 2023 or later have "content", so I still can't get the ''submmision_name" of venues before 2023.
Can anyone tell me how to get the ''submmision_name" of venues before 2023?
Thanks!

Hello,
content['submission_name']['value'] only works for venues that were created using API 2. We started creating venues using API 2 in 2023.
Whether or not you can get submissions also depends on the permissions and readership of that venue. If you are trying to get submissions for all venues, if submissions are not public then you will likely retrieve a small number of submissions.
If the venues did not configure the submissions to be public, submission data, even a count of submissions, is not accessible unless you are a program chair for the venue.
Best,
Rachel

Thanks for your response.


Alternative stack/pool allocator implementation based on Cray pointers compatible with Cray+AMD stack

… pointers but which works on Cray + AMD
Some problems with OMNI related to the unit tests ...

Looks good to me. Thanks for fixing the OMNI related stuff and for testing!


xrdp crashes or exits after a rogue incoming connection

I left the xrdp port exposed on the internet.
This leads to xrdp dying about every day with this written into log:
May 29 18:42:30 yv xrdp[17069]: [ERROR] SSL_accept: I/O error
May 29 18:42:30 yv xrdp[17069]: [ERROR] trans_set_tls_mode: ssl_tls_accept failed
May 29 18:42:30 yv xrdp[17069]: [ERROR] xrdp_sec_incoming: trans_set_tls_mode failed
May 29 18:42:30 yv xrdp[17069]: [ERROR] xrdp_rdp_incoming: xrdp_sec_incoming failed
May 29 18:42:30 yv xrdp[17069]: [ERROR] xrdp_process_main_loop: libxrdp_process_incoming failed
May 29 18:42:30 yv xrdp[17069]: [ERROR] xrdp_iso_send: trans_write_copy_s failed
May 29 18:42:30 yv xrdp[17069]: [ERROR] Sending [ITU T.125] DisconnectProviderUltimatum failed

Nobody was using RDP at this time, so it looks like some sort of port scanner hitting this port and xrdp crashing or exiting after this.
xrdp-0.9.22
FreeBSD 13.2

First thing to say, is:-
Never expose ANY RDP server (including xrdp) to the internet in this way. The protocol isn't safe enough to support this.
These days there's no excuse not to use a VPN of some sort to protect sensitive resources. Since you've already got point-to-point connectivity, consider either OpenVPN or wireguard as these are straightforward to set up with the server end on the xrdp machine. Then configure xrdp (and maybe other services) to listen on the VPN endpoint.
Other than that, thanks for the report but I'm not sure what we can do about this. I'll try running a fuzz test on a machine here and see if I can find anything.

See also #2040 which appears to cover the logging above.

I've now run a fuzzer on xrdp for an hour (with forking disabled) and got no crashes or similar. There are however plenty of log messages similar to the above.
I'm closing this - I think it's adequately explained by #2040 / #2505 and I can find no other immediate problems.

Worked for me after performing the following:

Commented the following line "TerminalServerUsers=tsuers" in file /etc/xrdp/sesman.ini
systemctl restart xrdp-sesman
remote desktop and login with root acoount on the remote machine

@alexandrunic - can you add more detail on exactly what the above procedure solves? By default it's not possible to log in with root to xrdp.