Unable to Delete Domain

During PDNS setup, I created the test entries for example.com (see powerdns documentation).
After I installed PowerDNS-Admin, I created all my domains and their DNS records and resolution works fine.
However, I can't delete the example.com domain. I was able to delete all records for the domain, using the web UI, but when I go to manage -> delete domain and accept the permanent deletion, I get redirected to the domain overview and example.com is still there. There's no log entry in the GUI logfile, and only the following in uwsgi/app/powerdnsadmin.log
GET /admin/domain/example.com/manage => generated 19857 bytes in 23 msecs (HTTP/1.1 200) 3 headers in 416 bytes (1 switches on core 0)
/ => generated 227 bytes in 9 msecs (HTTP/1.1 302) 4 headers in 472 bytes (1 switches on core 0)
GET /admin/domain/example.com/manage => generated 19857 bytes in 23 msecs (HTTP/1.1 200) 3 headers in 416 bytes (1 switches on core 0)

The same goes for domains I created directly in the WebUI.

Hi @fredericmohr
Can you tell me what version of PowerDNS you're using?

Hi @fredericmohr
I'm trying this on a fresh pdns-3.4.8 with the PowerDNS-Admin master and I can't replicate it. I created example.com using these queries:
INSERT INTO domains (name, type) values ('example.com', 'NATIVE');
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'example.com','localhost<EMAIL_ADDRESS>1','SOA',86400,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'example.com','dns-us1.powerdns.net','NS',86400,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'example.com','dns-eu1.powerdns.net','NS',86400,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'www.example.com','<IP_ADDRESS>','A',120,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'mail.example.com','<IP_ADDRESS>','A',120,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'localhost.example.com','<IP_ADDRESS>','A',120,NULL);
INSERT INTO records (domain_id, name, content, type,ttl,prio) VALUES (1,'example.com','mail.example.com','MX',120,25);

Do you have the LOG_FILE parameter set in config.py? Not sure if it works as I expect it to in uwsgi mode, but check for its existence and see if that log is more useful.
You can also try running PowerDNS-Admin via python run.py in it's directory (make sure to do source ./flask/bin/activate first), then connect to it directly via http://localhost:9393 and watch the console as you try to delete example.com

Strange, this problem only seems to occur in Firefox. Deleting in Chrome works fine. I added my DB Version, since I'm not using MySQL but MariaDB, but I don't think that's the problem. This looks Browser Specific (I'm on Kubuntu 16.04 btw)
ubuntu@powerdns:~$ pdns_server --version
May 14 10:33:57 PowerDNS Authoritative Server 3.4.8<EMAIL_ADDRESS>(C) 2001-2015 PowerDNS.COM BV
May 14 10:33:57 Using 64-bits mode. Built on<PHONE_NUMBER>2222 by<EMAIL_ADDRESS>gcc 4.7.2.
May 14 10:33:57 PowerDNS comes with ABSOLUTELY NO WARRANTY. This is free software, and you are welcome to redistribute it according to the terms of the GPL version 2.
May 14 10:33:57 Features: botan1.10 libdl lua
May 14 10:33:57 Built-in modules: bind gmysql gpgsql pipe gsqlite3 lua geo tinydns mydns opendbx remote random

DB: MariaDB 10.0.24 (AWS RDS Instance)

2016-05-14 10:45:31,321 - MODEL - INFO - Added domain chrometest.com successfully
2016-05-14 10:45:37,158 - MODEL - INFO - Delete domain chrometest.com successfully
2016-05-14 10:45:46,918 - MODEL - INFO - Added domain fftest.com successfully
# ff delete request doesn't show up in log file.

Current PowerDNS-Admin settings during tests (In production I use LOGLEVEL='WARNING' and debug = False)
#config.py
LOGLEVEL='DEBUG'

#run.py
app.run(debug = True,

Oh, and another thing. In chrome, the domain still shows after the redirect, until I do a page refresh...

Hi @fredericmohr
I was able to replicate both the Firefox and the Chrome issues. I've pushed a fix to this branch here: https://github.com/ivanfilippov/PowerDNS-Admin/tree/fix_domain_deletion_issues. Are you able to try it out to tell me if the issue is fixed for you as well? If it's fixed I'll merge it into the main repo.

Works perfectly in both Chrome and Firefox now :)
Since I had to switch origin url to test the patch, will this be merged into this repository? Because currently I switched to the fork, which makes me a bit uneasy on a production server ;)

Hi @fredericmohr
I've created PR #42 for @ngoduykhanh to review, once accepted you can switch back to master. :)

Hi @ivanfilippov ,
Your changes look good to me. Thank you for the PR. Merged.


setting: Test case for Guaranteed Engine CPU setting

This test case covers guarantted engine cpu setting with both valid and
invalid settings, also verifies the requests cpu value.
https://github.com/longhorn/longhorn/issues/1318
Signed-off-by: Bo Tao<EMAIL_ADDRESS>

Verified:
`$ klogs -f longhorn-test

flake8 .
py.test -v . -x -s -k test_setting_guaranteed_engine_cpu
============================= test session starts ==============================
platform linux -- Python 3.7.4, pytest-5.3.1, py-1.8.1, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /integration, inifile: pytest.ini
collecting ... collected 118 items / 117 deselected / 1 selected

test_settings.py::test_setting_guaranteed_engine_cpu PASSED
================ 1 passed, 117 deselected in 116.06s (0:01:56) =================
`


Provide documentation on a11y testing

Task Description
Some automated accessibility testing is already possible today, but it hasn’t been fully configured and documented yet.
Engineers need to know how they can write good accessibility tests and naturally integrate those into their workflow.

Some resources from the doc:
VoiceOver user guide (macOS)
ChromeVox user guide (Chromebook)
ChromeVox Classic browser extension (Google Chrome)
Web Content Accessibility Guidelines (WCAG) 2.1
Accessibility Developer Guide
Lighthouse Accessibility Audit

See #4778


With Hermes engine, certain date formats crash on production but works in debug

React Native version: RN60

new Date('Jul 18, 2018') is not supported on RN
new Date('18-07-2018 12:00') is not supported on RN
Steps To Reproduce

add date: const reproduce = new Date('Jul 18, 2018');
It will crash in production

Describe what you expected to happen:
It should return the expected date.
Snack, code example, screenshot, or link to a repository:
export function getDateFormat(date = 'Jul 18, 2018' ) {
const newDate = new Date(date);
return newDate;
}
export function getDateFormat(date = '18-07-2018 12:00' ) {
const newDate = new Date(date);
return newDate;
}

Are you testing on debug without remote debugging enabled? Because then you are using Chrome to run JS code.

@radko93 debug JS remotely is enabled. And this same format was working previously in production before Hermes.
export function getDateFormat(date = 'Jul 18, 2018' ) {
const newDate = new Date(date);
return newDate;
}

I'd recommend looking at using Moment.js. JavaScript engines differ in how they treat Date objects: https://www.freecodecamp.org/news/get-to-know-different-javascript-environments-in-react-native-4951c15d61f5/

@roydipti23 Chrome treats dates differently than Hermes. If you want to test in debug mode turn off remote Chrome debugging.

@roydipti23 try using moment js for the same

I'm seeing this also. A date in ISO format like Fri, 06 Sep 2019 18:45:29 +0000 (UTC) parses as an Invalid Date in Hermes. It works on iOS and was working in Android in 0.59. I am now using Moment as a workaround but this should be supported natively.


Avoid doing multiple dictionary lookups

Dictionary lookup involves get key hash, find bucket for hash and iterate bucket for key, so look the value up once, instead of checking if the key exists and then using the indexer to look up the value.
It also reduces the amount of duplicate hardcoded keys in the code.
Could not find any documentation for running the benchmark, so I haven't checked if it actually makes any difference. Haven't analyzed how often the code is executed.
Some places ContainsKey is used before Remove. That is not needed for Dictionary<>, as it will just return false for key not found, but I am uncertain of the specification for IDictionary<> void Remove, so I left it in place.

Thanks @Henr1k80 👍

ported to 5.x: 641df53f5fa646648bc9cfb8d14d5ef11041f30a
ported to master: c159ddffe0592bcc4e38fe8270b11905a6da9c64


Ionic cordova resources:  Uploading source images to prepare for transformations - failed! Error: Timeout of 25000ms exceeded

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Note: for build related issues you can open up an issue on the ionic-app-scripts repo
https://github.com/driftyco/ionic-app-scripts
Please ensure that you are on the latest version of the CLI.
npm view ionic@latest version
ionic -v
3.1.2
Short description of the problem:
When running ionic resources
 Uploading source images to prepare for transformations - failed!
Error: Timeout of 25000ms exceeded

What behavior are you expecting?
Steps to reproduce:

Saved icon.ps & splash.ps
Ionic cordova resources
3. Uploading source images to prepare for transformations - failed! Error: Timeout of 25000ms exceeded

insert any relevant code between the above and below backticks

Post the output of ionic info below please
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

I am having this issue, only way to workaround it is to optimize the file size of the splash and icon images. Or get into decent high speed Internet connection. Nevertheless it would be a good idea that the CLI supports a possible timeout flag for those like me with not decent connection at home a high quality splash screen images.

@nicksmithr @barroyo The resources server that does the image manipulation is hosted on Heroku, which has a hard server timeout at 30 seconds. If an image can't be uploaded in 25 seconds (keeping in mind the stock images are all lossless PNGs under 200KB, so ~64kbits/s), then it might be better to generate the various sizes manually using imagemagick or photoshop or gimp.
Still, we can implement the --no-timeout flag, but you'll see a server error 5 seconds afterwards: https://github.com/driftyco/ionic-cli/issues/2337
Perhaps also we can look into getting non-US servers, which may help.

Thank you @dwieeb, makes a lot of sense .. another improvement that will help is that the cli tell the server to only generate the assets required based on the target-device preference, so it only generates the real required ones, in some of my failed attempts the process end up generating only a few of the splash screens and then I get the timeout after some time. I have been trying to compress the splash screen but can't get it below 3mb, I guess we need to use less quality stock images.
Thanks

i'm getting the same error,will it lead to problems further in the build of the app?

It may, since some of those assets are required by the the App store to succesfully upload the build to Testflight for example.


Chrome in travis

Seems our Travis conf is pretty out-dated. If that looks good to you, I'll push same changes to the other juicy repos without PRs

I'll push same changes to the other juicy repos without PRs

That's totally fine by me. Thanks @tomalec.


Potential duplicate count issue

User Impacted
0x20e0F0d4FFfB9A8b4C6d48F68b1058A294503886
Discord ID (including number)
kakamora#2549
Workflow Impacted
Analyze
Feature Impacted
Other
Issue description
The count of values shown seems to be double
The page https://beta.metricsdao.xyz/app/market/0x280b3b748Ccc42D5062CE59111fAd08594f51d9F/request/1 shows we have 4 submission, but actual value is 2.
The page https://beta.metricsdao.xyz/app/market/0x280b3b748Ccc42D5062CE59111fAd08594f51d9F shows we have 2 challenges, but the actual value is 1.
Blocking
no it is not
Relevant log output
No response

we're on this one!  it's being tracked in issue #567


Mock modules are prioritised over node_modules

Do you want to request a feature or report a bug?
Report a bug.
What is the current behavior?
If a project has a dependency on a module with the same name as an internal file with a mock, that mock implementation is retrieved for requests of the global module, instead of the global module, requiring explicit unmocking (which then prints a warning, despite displaying a tangible change in behaviour).
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal repository on GitHub that we can npm install and npm test.

Clone https://github.com/ticky/jest-mock-bug, npm install dependencies
Run npm test

The test expecting to be able to import the global module (with no explicit opt-out › globalPad should not be a mock function) fails because the module returned is in fact the manual mock.
(Note that left-pad is used here as it’s a small module with no compilation requirements.)
What is the expected behavior?
The import statement should return the global module, as it does in explicit-opt-out.js
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.
jest version = 16.0.1
test framework = jasmine2
config = {
  "rootDir": "/Users/jessica/Repositories/jest-mock-bug",
  "name": "-Users-jessica-Repositories-jest-mock-bug",
  "setupFiles": [],
  "testRunner": "/Users/jessica/Repositories/jest-mock-bug/node_modules/jest-jasmine2/build/index.js",
  "scriptPreprocessor": "/Users/jessica/Repositories/jest-mock-bug/node_modules/babel-jest/build/index.js",
  "usesBabelJest": true,
  "automock": false,
  "bail": false,
  "browser": false,
  "cacheDirectory": "/var/folders/rl/98bml8qx57n3b6xgsgyvbxtr0000gn/T/jest",
  "clearMocks": false,
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "coverageReporters": [
    "json",
    "text",
    "lcov",
    "clover"
  ],
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "jsx",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "preprocessorIgnorePatterns": [
    "/node_modules/"
  ],
  "resetModules": false,
  "testEnvironment": "jest-environment-jsdom",
  "testPathDirs": [
    "/Users/jessica/Repositories/jest-mock-bug"
  ],
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.jsx?$",
  "testURL": "about:blank",
  "timers": "real",
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true,
  "testcheckOptions": {
    "times": 100,
    "maxSize": 200
  }
}

I think this case is similar to what happen in my project
In my case I have <rootDir>/__mocks__/left-pad.js. All tests that import left-pad will automatically import the mocked left-pad even though I didn't explicitly call jest.mock('left-pad')
My current workaround is explicitly mock and then explicitly unmock them. It's ugly, but it works
jest.mock('left-pad');
jest.unmock('left-pad');

Aha, thanks! That’s a cleaner workaround than mine, though still definitely not ideal!

Yes, manual mocks take precedence over node modules. The manual mocks system is a bit sketchy. For now, we are removing the warning in the next release, so jest.unmock('left-pad') should be all you need. See #2022
One idea we had was to make a separate system for manual node module mocks but that should likely be discussed in a separate proposal, so I'll close this issue out.


Create @huggingface/jinja for parsing and rendering Jinja chat templates

This PR introduces the @huggingface/jinja library, which is a minimalistic JavaScript implementation of the Jinja templating engine, specifically designed for parsing ML chat templates.
Although it was originally created for (and integrated into) transformers.js, it became clear that others can use this functionality too, without the overhead of the transformers.js library.
Example usage: Loading a tokenizer_config.json from the HF hub and render a list of messages
import { Template } from "@huggingface/templates";
import { downloadFile } from "@huggingface/hub";

const config = await (await downloadFile({
    repo: "mistralai/Mistral-7B-Instruct-v0.1",
    path: "tokenizer_config.json"
})).json();

const chat = [
    { "role": "user", "content": "Hello, how are you?" },
    { "role": "assistant", "content": "I'm doing great. How can I help you today?" },
    { "role": "user", "content": "I'd like to show off how chat templating works!" },
];

const template = new Template(config.chat_template);
const result = template.render({
    messages: chat,
    bos_token: config.bos_token,
    eos_token: config.eos_token,
});
// "<s>[INST] Hello, how are you? [/INST]I'm doing great. How can I help you today?</s> [INST] I'd like to show off how chat templating works! [/INST]"

TODO:

[ ] Auto-generate documentation
[x] Trigger unit tests for GH actions
[x] Add support for array slicing (e.g., messages[1:])
[x] Do trim_blocks=True, lstrip_blocks=True (needed by HuggingFaceH4/zephyr-7b-beta)
[ ] Add test cases for invalid templates
[ ] Library minification
[ ] Publish to NPM
[ ] Integration into transformers.js (will happen after this is published) as optional dependency

Regarding the above TODOs, I would appreciate some assistance from core maintainers of the repo to follow best practices (and to be aligned with the other packages) :)

Thanks @coyotte508 😇 (I don't know how I missed that guide, sorry about that).
Since the codebase was migrated from transformers.js, it's using JSDoc at the moment, and I think this might cause some issues with the current project structure. Would you recommend I switch over to using typescript? I don't mind either way. If I do switch, it will also probably help with the migration to tsup instead of vite.

Okay I've finished rewriting in typescript, and the node tests are passing in GH actions. However, the browser test seems to be timing out after 10 minutes?
"test:browser": "vitest run --browser.name=chrome --browser.headless",

any ideas @coyotte508 ?

Removing vitest from my dev dependency list indeed fixed the freezing issue 👍 The browser tests are now failing because it's unable to resolve hash-wasm. I assume vite is doing some unnecessary bundling, because we aren't using this module in the tests (we aren't uploading files > 10MB). Fortunately, it looks like there are already plans to remove it (issue).
packages/chat-templates test:browser$ vitest run --browser.name=chrome --browser.headless
packages/chat-templates test:browser:  RUN  v0.29.7 /home/runner/work/huggingface.js/huggingface.js/packages/chat-templates
packages/chat-templates test:browser:       Browser runner started at http://localhost:63315
packages/chat-templates test:browser: The following dependencies are imported but could not be resolved:
packages/chat-templates test:browser:   hash-wasm (imported by /home/runner/work/huggingface.js/huggingface.js/packages/hub/src/utils/sha256.ts)
packages/chat-templates test:browser: Are they installed?
packages/chat-templates test:browser: Failed to resolve import "hash-wasm" from "../hub/src/utils/sha256.ts?v=1700763447278". Does the file exist?
packages/chat-templates test:browser: 6:17:27 PM [vite] Internal server error: Failed to resolve import "hash-wasm" from "../hub/src/utils/sha256.ts?v=1700763447278". Does the file exist?
packages/chat-templates test:browser:   Plugin: vite:import-analysis
packages/chat-templates test:browser:   File: /home/runner/work/huggingface.js/huggingface.js/packages/hub/src/utils/sha256.ts?v=1700763447278:150:29
packages/chat-templates test:browser:   123|      }
packages/chat-templates test:browser:   124|      if (!wasmModule) {
packages/chat-templates test:browser:   125|        wasmModule = await import("hash-wasm");
packages/chat-templates test:browser:      |                                  ^
packages/chat-templates test:browser:   126|      }
packages/chat-templates test:browser:   127|      const sha2562 = await wasmModule.createSHA256();
packages/chat-templates test:browser:       at formatError (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.[14](https://github.com/huggingface/huggingface.js/actions/runs/6973087542/job/18976473121#step:11:15).6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41418:46)
packages/chat-templates test:browser:       at TransformContext.error (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41414:19)
packages/chat-templates test:browser:       at normalizeUrl (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39706:33)
packages/chat-templates test:browser:       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
packages/chat-templates test:browser:       at async TransformContext.transform (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39840:47)
packages/chat-templates test:browser:       at async Object.transform (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41685:30)
packages/chat-templates test:browser:       at async loadAndTransform (file:///home/runner/work/huggingface.js/huggingface.js/node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39479:29)
packages/chat-templates test:browser:  ❯ test/e2e.test.js  (0 test)
packages/chat-templates test:browser:  ✓ test/templates.test.js  (3 tests) 19ms
packages/chat-templates test:browser: ⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯
packages/chat-templates test:browser:  FAIL  test/e2e.test.js [ test/e2e.test.js ]
packages/chat-templates test:browser: TypeError: Failed to fetch dynamically imported module: http://localhost:63315/home/runner/work/huggingface.js/huggingface.js/packages/chat-templates/test/e2e.test.js?v=1700763447278
packages/chat-templates test:browser: ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
packages/chat-templates test:browser:  Test Files  1 failed | 1 passed (2)
packages/chat-templates test:browser:       Tests  3 passed (3)
packages/chat-templates test:browser:    Start at  18:[17](https://github.com/huggingface/huggingface.js/actions/runs/6973087542/job/18976473121#step:11:18):13
packages/chat-templates test:browser:    Duration  14.84s (transform 0ms, setup 0ms, collect 60ms, tests [19](https://github.com/huggingface/huggingface.js/actions/runs/6973087542/job/18976473121#step:11:20)ms)
packages/chat-templates test:browser: Failed

you should change this line to use @huggingface/hub then: https://github.com/huggingface/huggingface.js/pull/352/files#diff-a22101bc7201b13f434e24905cd2b71d26dd97e31276eee1229f765f1df0b980R5

I did try that, but I got:
 RUN  v0.29.7 D:/joshu/Xenova/Projects/huggingface.js/packages/chat-templates

 ❯ test/e2e.test.js (0)
 ✓ test/integration.test.js (1)
 ✓ test/templates.test.js (3)

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
 FAIL  test/e2e.test.js [ test/e2e.test.js ]
Error: Failed to resolve entry for package "@huggingface/hub". The package may have incorrect main/module/exports specified in its package.json.
 ❯ packageEntryFailure ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:22005:11
 ❯ resolvePackageEntry ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:22002:5
 ❯ tryNodeResolve ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:21737:20
 ❯ Context.resolveId ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:21488:28
 ❯ Object.resolveId ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41612:46
 ❯ TransformContext.resolve ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41363:23
 ❯ normalizeUrl ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39698:34
 ❯ TransformContext.transform ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39840:47
 ❯ Object.transform ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41685:30
 ❯ loadAndTransform ../../node_modules/.pnpm/vite@4.1.4_@types+node@18.14.6/node_modules/vite/dist/node/chunks/dep-ca21228b.js:39479:29

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 2 passed (3)
      Tests  4 passed (4)
   Start at  21:25:55
   Duration  918ms (transform 283ms, setup 0ms, collect 352ms, tests 15ms)

👀

Great! 🚀 I'm just adding a bit more functionality first: mainly array slicing (needed by llama), and I'll add some more e2e tests.
Looking forward to the first release! 🔥

The library is now working for all chat templates in transformers, as well as zephyr, which is more complicated.
Before launch, I'd like to add unit tests for invalid templates (and perhaps add more chat template examples; cc @Rocketknight1?).
Also, I think we can defer docs to a later date once more people have tested it and things are more finalized (hopefully no issues, but you never know 😉).

IMO we could restrict the scope of Jinja features that can be used in transformers (and our other OS libraries)
i.e. The full power of Jinja expressivity is probably not needed, and it will be simpler to support a subset

Strongly agree - I want to keep the system open enough to support other use cases besides just ('system', 'assistant', 'user') in the future, but many of Jinja's tools are not really relevant for chat templating at all, and we could definitely 'ban' them. We could also enforce other restrictions in Python (e.g. everything outside blocks is removed during preprocessing) that might make it much simpler to implement parsers.

Will take a look at the tests today!

Hi @xenova - the test suite looks great! The range of templates is good, and honestly if you're rendering the very complex llama one correctly then I'm 99% sure the implementation is good.
One question, since I'm not too good at reading JS test suites - are the templates tested with add_generation_prompt set and unset, to make sure the behaviour changes appropriately?

are the templates tested with add_generation_prompt set and unset, to make sure the behaviour changes appropriately?

Sure, I added a test case for this (from this page). :) Ultimately, it doesn't test much more than those in templates.test.js (since that tests the core jinja functionality), but it's nice to have an end-to-end test case like that.
I'll also make sure that when integrating into transformers.js, the code (and output) will be identical to the python version.

@coyotte508 I've put together a simple demo for the library:
https://github.com/huggingface/huggingface.js/assets/26504141/5c28d0e6-cd3f-4909-8cc5-617d1d05d677
Is it advised to publish the demo source code here too, or will that add unnecessary bloat? If the latter, I'll publish it to a separate repo.

It can be done in a later PR if you want.

Yes let's do it in a follow-up PR! I'd like to get this published (at least a v0.0.1) to unblock chat templates in transformers.js 🔥
Is there anything else needed to be done before publishing?

Great! So if I merge, now, will a new release be published? Or is that a separate thing to be done?


Fix efficacy summary markup

Implemented Efficacy Summary page with stylings and correct calculations.  Also fixed the button enabling on the Efficacy Survey page
Testing

Implemented Efficacy Summary page
Fixed Efficacy Survey page button enablings

"I'm done adding studies" always enabled (till you click it)
"Continue to Summary" enabled once "I'm done adding studies" is clicked
If two strong studies exist when clicking "I'm done adding studies" you see Criterion 2.  If not you see a green warning saying you can continue to summary

Review

@dcmouyard

Preview this PR without the whitespace changes

Rebased ontop of master after other PR merged


Add parent group entity for GitHub org

Signed-off-by: Spencer, Morgan [USA]<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Added a parent group for the GitHub MultiOrg Processor to create better hierarchy among groups. Links org team groups to new parent org group by creating a group with spec.type of organization. Should link all org users and all team groups to the parent org.
Closes #7619
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Any updates on this?

Not from our side, and the committer went silent.
I have not looked through this personally yet, but spontaneously it does feel kind of scary to make "virtual" groups that actually don't exist. Reserving judgment before full review though.


Propose increasing number of columns to 800

80 columns in HTML is a very small number given current standards. Especially that browser creates horizontal scroll bar when displaying an object. This should not have a big impact on performance either.
I think leaving 30 lines is OK.

CC @nalimilan @ronisbr

@stevengj - do you have an opinion on this proposal? Thank you!

It would be good to have a decision on this PR before JuliaCon so that Jupyter based materials presented there could take advantage of this change (if it were approved). Thank you!

I'm happy to merge it, but do you have a MWE just so I can try it out?

For something like a rand(1000, 1000) this doesn't look very nice (text/plain output) and doesn't give a scrollbar. For a DataFrame it looks ok though (text/html I suppose?)

A good point. The MWE is rand(100, 100) and it shows we have a problem.
The issue is that if I e.g. do:
using DataFrames
DataFrame(rand(100, 100), :auto)

all is good and horizontal scroll bar is automatically added.
However, if I do:
rand(100, 100)

I get (after setting "COLUMNS" to 800):

This is bad and the problem is that for some reason in this case Jupyter Notebook does not insert a horizontal scroll bar. Most likely (I am not 100% about the reason) is that when we do rand(100, 100) the display is always plain text.
This means that before merging this PR we should first understand in what circumstances Jupyter Notebook inserts a horizontal scroll bar.
This would probably also affect display of things like:

which currently use whole window width and "wrap around".
The issue is discussed on SO.

In summary: things are more complex than they seemed :( and this PR should not be merged as is.
@nalimilan @ronisbr : what do you think we should do for DataFrames.jl given this context?
In essence the problem is:

user cannot have both wide Matrix and DataFrame nicely displayed. If we set "COLUMNS" to a large value DataFrame will be displayed nicely, but Matrix will be a mess. If we keep "COLUMNS" as it is now (80) then Matrix is OK, but DataFrame is not good

So it seems that the only solution is to have our own configuration parameter for HTML display width/height?

You could perhaps insert this change more surgically for text/html

My feeling was that if we anyway need two separate values then the least problematic approach is to have a custom DataFrames.jl specific configuration option. In DataFrames.jl we could just use get(ENV, "TABLE_COLUMNS", 800) instead of using ENV["COLUMNS"]. Or maybe this should be PrettyTables.jl setting? @ronisbr - what do you think?

AFAICT the option should be HTML-specific rather than DataFrames/PrettyTables-specific? Or maybe let's just hardcode the value of 800 in DataFrames? I mean, scrolling until the 800th column is totally impractical anyway. Does IJulia set the :limited=>true IOContext property when printing HTML?
It's hard to find a good solution because none of these choices is ideal IMO. What should ideally happen is that only the columns that fit on screen should be visible, but users would be able to see other columns by clicking on scroll buttons that would load the next block of columns (or by scrolling indefinitely). Other approaches are just stopgaps.

Other approaches are just stopgaps.

I agree, but this would be a big project to do it right (if practically possible at all).
What you propose is roughly the target functionality of VSCode extension for viewing tables AFAICT.

Or maybe let's just hardcode the value of 800 in DataFrames?

So this is my proposal essentially. But I want to allow this 800 to be changed by setting a proper ENV entry.
I would name property (in order from more specific to more general):

"DATAFRAME_COLUMNS" if we want it to be DataFrames.jl specific (then only DataFrames.jl needs to be aware of it)
"TABLE_COLUMNS" if we want it to be PrettyTables.jl specific (then PrettyTables.jl has to be aware of it and in consequence also DataFrames.jl)
"HTML_COLUMNS" if we want it to be any HTML output specific (then it should be mentioned in IJulia.jl developer documentation)

OK. Then could IJulia set the displaysize IOContext property for HTML output?

Hi! Sorry for the delay.
In PrettyTables, the maximum number of rows or columns that will be printed is just a keyword parameters. Hence, DataFrames can select an environment variable and we use this value when calling pretty_table.

Hence, DataFrames can select an environment variable and we use this value when calling pretty_table.

OK - let us discuss it then when you open a PR to DataFrames.jl. Thank you!

Closing as this solution is problematic per the comments above. In DataFrames.jl we will use separate values to control display size.


Very unusual (and inconsistent) time sequence information from fingerprinting

So my goal is to identify when a snippet from an audio file occurs. This has the pretty straightforward and basic code (not everything is shown, but what isn't should be quite obvious):
public void FindTag(string tagFile)
{
    IModelService modelService = new InMemoryModelService();
    IAudioService audioService = new NAudioService();

    // Create fingerprints for the tag
    var hashedFingerprints = new FingerprintCommandBuilder()
            .BuildFingerprintCommand()
            .From(tagFile)
            .UsingServices(audioService)
            .Hash()
            .Result;
    var trackReference = modelService.InsertTrack(new TrackData());
    modelService.InsertHashDataForTrack(hashedFingerprints, trackReference);

    // Find the tag in the full file
    var queryResult = new QueryCommandBuilder()
            .BuildQueryCommand()
            .From(this.File)
            .UsingServices(modelService, audioService)
            .QueryWithTimeSequenceInformation()
            .Result;

    if (queryResult.IsSuccessful)
    {
        Console.WriteLine($"Found match at {queryResult.BestMatch.SequenceStart} (confidence: {queryResult.BestMatch.Confidence})");
    }
}

I've been getting highly unusual results for SequenceStart of the best match, though. Even though the snippet is perfectly extracted from the middle of the file, soundfingerprinting is always claiming it comes from somewhere near the beginning. Eg, one time it gets 2.79 and confidence 0.047. And it's very inconsistent. Next time I run I get the timestamp of 4.64 and confidence 0.047. The snippet is a 15 second snippet from 0:30 to 0:45.
I've tried this with other files, so I don't believe it's an issue of the file. The files are all MP3s extracted from very talky youtube videos. The points that are misidentified are by no means even close to right. And if I try to make the query look at only the right area of time, it won't find any matches! I tried a much longer file (full thing except for the first 30 seconds). It gets the time completely wrong, but the confidence is much higher (~0.8).
I assume that there must be something I'm missing or a bug somewhere.
This is with version 2.2.0 from NuGet. I've also tried 2.0.0 (same issue).

Hi  KatrinaHoffert,
I am having same issue, did you find any solution to this? I my case service recognizes a very small snippet from a 50sec audio file but that match occurred on 43minutes and 22 seconds(43.22) and was not longer than 4 seconds once it returned SequenceStart43.59 and second time it returned me 44.00
Can you please help?

Will be fixed in 3.0

is there any expected time frame for release of 3.0?
On Fri, Nov 18, 2016 at 3:44 AM, Sergiu Ciumac<EMAIL_ADDRESS>wrote:

Will be fixed in 3.0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AddictedCS/soundfingerprinting/issues/60#issuecomment-261513424,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATvzbKVOLZmJtTT_nhzJgWTr9ZfyWt2tks5q_Y-kgaJpZM4JSN_d
.

--
Regards,
Zameer Faiz
Contact
+92302-5477923<EMAIL_ADDRESS>Linked In https://pk.linkedin.com/in/zameerfaiz
Portfolio http://zameerfaiz.branded.me/
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you are not the named addressee you should not disclose, disseminate,
distribute or copy this e-mail. Please notify the sender immediately by
e-mail if you have received this by mistake, and delete this e-mail from
your system.

It's going to be released this or the next week.

great thanks.
On Mon, Nov 21, 2016 at 2:27 AM, Sergiu Ciumac<EMAIL_ADDRESS>wrote:

It's going to be released this or the next week.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AddictedCS/soundfingerprinting/issues/60#issuecomment-261899771,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATvzbCoBVbs-jt2cAo-k-_WinnoTXdDwks5rAXIbgaJpZM4JSN_d
.

--
Regards,
Zameer Faiz
Contact
+92302-5477923<EMAIL_ADDRESS>Linked In https://pk.linkedin.com/in/zameerfaiz
Portfolio http://zameerfaiz.branded.me/
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you are not the named addressee you should not disclose, disseminate,
distribute or copy this e-mail. Please notify the sender immediately by
e-mail if you have received this by mistake, and delete this e-mail from
your system.

3.0.0-beta release available on NuGet. You will be able to get time sequence information from the newly updated interfaces.

Closing since its fixed in v3.0.0


Shapeshifting does not change affected token

Describe the bug
Shapeshifting does not change affected token in scene.
Error message on desktop and in console: "Required field "x" not present in TokenData"
Screenshots

Desktop

OS: Windows 10
Browser: Chrome
Foundry version: 0.8.8
DSA system: 2.0.4

Remarks
I'm not sure if it's important but it might be worth to mention that the actor was converted from Foundry 0.7. to Foundry 0.8

Was this an already transformed actor?

Already transformed Tokens are problematic. Foundry 0.8 changed to much. The shapeshifting from 0.7. is very different. So your remark is probably right.
Does this error also occur if you start a new transformation?

Tried shapeshifting in 0.8. the first time, but there seem to be an issue with the (self-created) creature I used for it. All works well when using a creature coming with one of the modules. Will try to figure it out.


[Bug]Add a New query-> There is red thin line displayed click on the textbox inside the Debug pop up debug button is not clickable

Description
Add a New query-> There is red thin line displayed click on the textbox inside the Debug pop up debug button is not clickable
Steps to reproduce the behaviour:
1.Drag and drop a table and form widget
2.Select mongo DB as Data Source
3.Click on create query
4.Add the Collection and Query
5.Click on the Textbox Inside the pop up click on Debug button
5.Verify the functionality
expected result:
The debug Button displayed inside the pop up when there are error is not clickable
Actual Result:
Add a New query-> There is red thin line displayed when the user hover on it a pop up is displayed with debug button but that debug button is disabled

Important Details

Version: [Cloud ]
OS: Windows
Browser Chrome
Environment  deploy preview

@ApekshaBhosale is someone looking into this?

Can you reconfirm this @RakshaKShetty


test: trying out submodule PR

closing this out, as this was just a test to see if I can get to a PR for this repo


feat: new pod pending counter metric

The workflow controller is a kubernetes controller creating pods. Sometimes those pods do not start, and will remain in pending.
This metric counts the number of pods that may have been observed as pending, by namespace and truncated reason. The reason is the first part of the kubernetes pod pending Reason up to the first : if
present.
It ignores all pods in the PodInitializing state as this I consider unremarkable and temporary.
This is intended for users to create alerts on particular reasons or if this metric is climbing unusually rapidly.
Note to reviewers: this is now a standalone commit

It ignores all pods in the PodInitializing state as this I consider unremarkable and temporary.

IIRC there are some cases where users had Pods stuck in this state, so it might be useful for detecting those.


feat: secure admin routes, clean todo, ts

#66

:tada: This PR is included in version 1.28.0 :tada:
The release is available on:

GitHub release
v1.28.0

Your semantic-release bot :package::rocket:


Fetching community numbers from the API

Our home page takes a few seconds to render, technically because we are using APIs and web scraping to fetch 4 numbers -

YouTube subscriber count
Twitter follower count
Discord member count
Hashnode follower count

We fetch these values when the page is getting loaded from the views. Instead, we could bring them from the APIs (api.py) and update the numbers by making a get request to the API we create to improve the speed of the page.

yes, I think this is the reason of high initial server response time as mentioned in the page speed insights which is taking almost 3 seconds to load


[BUG] Inconsistent information about /aasx/aasx-origin

Describe the bug
The information about the content of the /aasx/aasx-origin file is inconsistent.
Where
In chapter 5.3, page 18, it says

This relationship targets an aasx origin file which shall be an empty file or a plain text file containing the text "Intentionally empty"8.

In chapter 5.4, page 20, it says:

/aasx/aasx-origin shall be the target of the aasx-origin relationship without content (empty file),

This sentence could also be interpreted in a way that the name may be different in case the content is "Intentionally empty" and it must only be /aasx/aasx-origin if it is empty.
Screenshots
See above.
Additional context
None.

Thank you for your findings, your are right, this should be fixed.

issue will be transferred to Part 5


Does this wrapper support Astra Pro ?

Does this wrapper support Astra Pro depth camera?
I bought it but have not tested it yet with this wrapper?

did u get an answer for the question, could u say me? I try to use pyorbbec sdk on jetson nano, and i face some problems.

Does this wrapper support Astra Pro depth camera? I bought it but have not tested it yet with this wrapper?


How to handle large amount of data in increments

I was told to post my question in this github.
I am using Spark Structured Streaming with asuze-cosmos-spark_3-1_2-2 % "4.16.0"
I need to cap how much data I can read.
Tried setting the following:

spark.cosmos.changeFeed.itemCountPerTriggerHint = 10

spark.cosmos.read.maxItem = 10
spark.cosmos.changeFeed.startFrom = "Beginning"

spark.cosmos.changeFeed.mode = "Incremental"
Using

val changeFeedDF = spark.readStream
.schema(customSchema)
.format("cosmos.oltp.changeFeed")
.options(readConfig)
.load
This is their response.

_Hi, itemCountPerTriggerHint will allow you to modify the max. memory/resource consumption per micro batch. it is only a hint because change feed in Cosmos DB will always include at least all documents of a single atomic transaction (all sharing the same LSN - log sequence number, because they were modified in the same atomic transaction). So, you will always get at least the documents for a single atomic transaction per physical partition. But from a memory footprint/resource consumption perspective that should be more than sufficient - because the number of document updates in a transaction is also capped (worst case a single bulk/batch might update around 1-5 thousand documents if they are really very small)
The right repository for the Cosmos Spark Connector for Spark 3.* is this repo. https://github.com/Azure/azure-sdk-for-java
Config details can be located here: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos-spark_3_2-12/docs/configuration-reference.md_
In my case I have 2.5 million records of history to retrieve and I only have a two hour window per day to work with. So can I stop my job at the end of the window and based on the last saved checkpoint it will continue where it left off next time I run it.

Yes - you can use the Spark Streaming checkpointLocation - once provided Spark streaming will update the offset stored in this location with each MicroBatch. When you start processing after a "break" processing would recontinue at this offset. If the concern is that during business hours change feed processing should not use too many RUs, you could also use client throughput control and specify that the change feed processing job should take no more than x percent of RUs - or you could point the change feed processing job ata remote region (in case you use single master with at least one fail-over region).

Thanks for the response.
Regarding take no more than x percent of RUs
are these the settings.
"spark.cosmos.throughputControl.enabled" -> "true",
"spark.cosmos.throughputControl.targetThroughputThreshold" -> "0.95",
but looks like I have to add these; they are very restrictive on creating other resources.
"spark.cosmos.throughputControl.globalControl.database" -> "database-v4",
"spark.cosmos.throughputControl.globalControl.container" -> "ThroughputControl"
"spark.cosmos.throughputControl.name" -> "SourceContainerThroughputControl",

Correct - at least anther container is needed (could be under same account and database) to be used for the metadata the client-throughput control feature will persist.


Possible Enhancement: DateTransform could/should handle epoch time in milliseconds

I'm dealing with an API returning a date like so:<PHONE_NUMBER>000
http://www.epochconverter.com/ handles this fine and converts it to the proper date of: Thu, 28 May 2015 14:00:00 GMT assuming that is is in milliseconds.
Wondering if DateTransform should be smart enough to deal with a date like this and divide by 1000 to give it a chance at being the correct date.
Thoughts?

This sounds like a perfect case for using a Custom transform


from_cte not working. What am I doing wrong?

some_users = User.from_cte("some_users", User.where(type: "Admin"))
some_users.count doesn't work and fails with
NoMethodError: undefined methodarel_engine' for #CTEProxy:0x00000005c910a8`.
I'm running:
'rails', '4.0.5'
activerecord (4.0.8)
arel (4.0.2)
pg_array_parser (0.0.9)
and
postgres_ext (2.4.1) with these dependecies:
activerecord (>= 4.0.0)
arel (>= 4.0.1)
pg_array_parser (~> 0.0.9)

@pnpranavrao Running into this myself. Did you end up finding an answer?

I think this is because you have Squeel in your project. The backtrace is in a squeel library file.


doc: remove unused import

The Circle component is unused in this example.

I successfully signed the Shopify’s CLA https://cla.shopify.com/
Any idea whats wrong !?

Hi, @YahiaJabeur, I reran the CLA test, but it still fails with the following error:
CLA: 11293d42d7a50e79310140c96bf110d0cff215fc Not all authors have signed a CLA or have a GitHub account associated with their email. Failing check
[9](https://github.com/Shopify/react-native-skia/actions/runs/4079314890/jobs/7036859287#step:2:10)

Not sure why this is happening - does any of the above make sense (the email part etc.)?

I think what I did wrong that I wrote in the CLA form my GitHub email using point between first and last name<EMAIL_ADDRESS>I added it to my Github emails now.
Can you please rerun the CLA test ? @chrfalch


Switch main and side column

I was wondering if it was possible to switch the side bar (with contact, skills and language) to the left hand side of the page?
I guess it is something that has to do with the \iscvsidebar variable in the bubblecv.sty but I cannot make it work properly

Hi, unfortunately this is currently impossible. The template is designed so that the sidebar is on the right side. The position of the timeline is hardcoded and swapping the columns will take some effort. Additionally, in my opinion, the time range of events will look a bit strange in the middle of the page (between the columns).


[PE-D][Tester C] If a special character is added to ID in addressbook.json, view command for that contact does not work

Steps to reproduce with an empty address book:

add -name Xiao Ming -address 13, Computing Dr, 117417 -email<EMAIL_ADDRESS>-phone 88888888 -subject Math
close application
open data/addressbook.json
change uniqueId from 000001 to *000001
open application
input view -id *000001

It shows invalid command format however *000001 is an ID for the contact

Labels: severity.Medium type.FunctionalityBug
original: martinng01/ped#5

This is part of application security, not fixing it

Realised that this is a bug and the expected outcome should be addresbook deems the data to be invalid and reloads with blank page as per original AB3 UG under editing the data file

Fixed by #207

https://github.com/nus-cs2103-AY2324S2/forum/issues/811#issuecomment-2053553793
Meets current level as  'if you edit the file correctly, things will work. But if you edited it wrongly, there's no guarantee that things will work'. So, I assume you already meet this bar?"
so not allowed to fix


Stuck in deno installation

Installed latest deno (1.5.1) on Windows 10 according the instructions on Install/Deno
The installation phrase does not work (anymore?) on the command arguments:
deno install -f --name silverbullet  --unstable-kv --unstable-worker-options -A https://get.silverbullet.md
deno install --help only mentions --unstable             Enable unstable features and APIs
so I tried deno install -f --name silverbullet  --unstable -A https://get.silverbullet.md
then deno starts to download the get.silverbullet.md file but chokes:
error: Unexpected token =. Expected this, import, async, function, [ for array literal, { for object literal, @ for decorator, function, class, null, true, false, number, bigint, string, regexp,  for template literal, (, or an identifier at https://get.silverbullet.md/:2:6207
any tips? would like to check it out... thanks

SilverBullet requires Deno 1.40 at the least, 1.5 is extremely old. You're sure you installed the latest version?

Ah Sorry. Installed Deno with winget, even if I uninstall first it will get me this version. Then I used the method with PowerShell and this worked. Thank you and closed


additional maintainers

@SorooshMani-NOAA would you mind if I added you as a maintainer in searvey-feedstock?

@pmav99 sure, no problem, please add me as well. I'm not very familiar with the feedstock maintenance. Is there anything I need to update for every release after releasing on the main dev repo?

I am not particularly familiar with conda packaging either.
The general idea is that every time we create a tag (or maybe github release?) in searvey a new PR is automatically made in the current repo. If there are no major changes in the package (e.g. no new dependencies etc), then usually just merging the PR is enough.
If there are changes, then we may need to add additional commits on top of the automatically created ones. Each time you push a commit in the PR, the CI runs and builds the package. The fact that the package is being built, does not necessarily mean that the package is OK, too, so you need to test the package, too.
Anyhow, maintaining python packages on conda it is not anything too complicated, just (as everything else related with CI) potentially time consuming.

@conda-forge-admin, please add user @SorooshMani-NOAA

Hmm... according to this issue #10 should make a PR which would add you as a maintainer. It doesn't work though. @brey any ideas?

From the wording, I would expect that it was automatic. Anyhow, no real hurry here.

I have posted a question on Gitter and this was the response:

I think this is a bug in the bot that has been plaguing us lately. Could you try editing the issue? What you change doesn't seem to be important, but people had luck with removing the comma in the title.

Removing the comma worked.

Next time we need to change the README to add Soroosh. I leave the issue open as a reminder.

Apparently there was an issue with the PR and I have missed it.

@SorooshMani-NOAA Do you have a pending invite for becoming a maintainer of searvey feedstock?

@brey I just noticed an invite to join @conda-forge and accepted it. Thanks for following up.

Now Soroosh is listed here as well. I expect that next time the README will be updated as well. Closing for now.


Conditional loading seems to cause duplicate dependencies to be bundled

Here is console output for building the canjs site, showing the same version of flexibility being opened five times.

CC @matthewp

It displays multiple dependencies but they are not actually built more than once. A problem with the display. I see this in donejs-chat now in DoneJS 2.0:
OPENING: /Users/matthew/dev/donejs2-test/donejs-chat/package.json!npm
OPENING<EMAIL_ADDRESS>OPENING: donejs-chat<EMAIL_ADDRESS>OPENING<EMAIL_ADDRESS>OPENING<EMAIL_ADDRESS>OPENING<EMAIL_ADDRESS>OPENING<EMAIL_ADDRESS>