Fix: grpc probe is not working with ipv6

Please provide a description of this PR:
We should not use net.JoinHostPort to build destination addr, otherwise there would be 2 brackets since the appProbersDestination has already been wrapped with "[]"
https://github.com/istio/istio/blob/7c6403332f5044f78d8f541ce983066c8357bd90/pilot/cmd/pilot-agent/status/server.go#L186
https://github.com/istio/istio/blob/7c6403332f5044f78d8f541ce983066c8357bd90/pilot/cmd/pilot-agent/status/server.go#L841-L851
Fix the failing test

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4223f5445d1cf934f5438851f0f0cad07dca8ce6
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@dddddai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4223f5445d1cf934f5438851f0f0cad07dca8ce6
link
unknown
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


[ldd-spectral] Remove "nillable" on optional attributes

In upgrading LDDTool processing, Steve Hughes noted that there are two attributes that are nillable but are not required in any class, which violates one of the proposed rules for discipline dictionaries. This should have no noticeable affect on users.

A manual search turned up two attributes that were marked as "nillable" but not required to be present in any class:
body_positive_pole_position_angle
celestial_north_position_angle
The nillable flag will be set to "false" with version <IP_ADDRESS> of the Spectral Dictionary for these two attributes.

This was done and released with IM <IP_ADDRESS>


it8xxx2_evb: tests/kernel/sleep failed

Describe the bug
The test: "tests/kernel/sleep" failed.
To Reproduce
Steps to reproduce the behavior:

source zephyr-env.sh
twister -p it8xxx2_evb --device-testing -T tests/kernel/sleep/ --west-flash="$HOME/itetool/loader.sh" --device-serial=/dev/ttyUSB0
See error

Expected behavior
The test should pass.
Impact
No serious impact.
Logs and console output
***** delaying boot 1ms (per build configuration) *****
*** Booting Zephyr OS build zephyr-v3.0.0-808-gd74cb2a3df23  (delayed boot 1ms) ***
Running test suite sleep
===================================================================
START - test_sleep
Kernel objects initialized
Test thread started: id = 0x801010f8
Helper thread started: id = 0x80101050
Testing normal expiration of k_sleep()
Testing: test thread sleep + helper thread wakeup test
Testing: test thread sleep + isr offload wakeup test
Testing: test thread sleep + main wakeup test thread
Testing kernel k_sleep()
PASS - test_sleep in 2.34 seconds
===================================================================
START - test_usleep
elapsed_ms = 5750
Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/sleep/src/usleep.c:95: test_usleep: (elapsed_ms <= UPPER_BOUND_MS is false)
overslept
FAIL - test_usleep in 57.516 seconds
===================================================================
START - test_sleep_forever
Kernel objects initialized
PASS - test_sleep_forever in 0.4 seconds
===================================================================
Test suite sleep failed.
===================================================================
PROJECT EXECUTION FAILED

Environment (please complete the following information):

OS: Ubuntu
Toolchain Zephyr SDK 0.13.2
Commit d74cb2a3df23

It looks like the CONFIG_SYS_CLOCK_TICKS_PER_SEC on ITE81xxx2 platform is different from others. If we change the code like this, the test can pass:
ztest@ztest-NUC7i7BNH:~/zephyrproject/zephyr$ git diff soc/riscv/riscv-ite/it8xxx2/Kconfig.defconfig.series
diff --git a/soc/riscv/riscv-ite/it8xxx2/Kconfig.defconfig.series b/soc/riscv/riscv-ite/it8xxx2/Kconfig.defconfig.series
index 2d0aa304b9..d105f1ffed 100644
--- a/soc/riscv/riscv-ite/it8xxx2/Kconfig.defconfig.series
+++ b/soc/riscv/riscv-ite/it8xxx2/Kconfig.defconfig.series
@@ -23,7 +23,7 @@ config SYS_CLOCK_HW_CYCLES_PER_SEC
default 32768
config SYS_CLOCK_TICKS_PER_SEC

  default 32768

  default 5800

config UART_NS16550
default y
I do not check the ITE spec and the value of 5800 is an estimated value.


Diffrax backend

Diffrax backend does not work with batch size greater than 1. Sampler throws an error:
 File "/home/user/ComfyUI/custom_nodes/comfyui_overly_complicated_sampling/py/step_samplers.py", line 1908, in odefn_ RuntimeError: shape '[1, 49152]' is invalid for input of size 147456

thanks for the bug report! i might have just forgotten to implement it. i will look into that.
just a note though: Diffrax doesn't support solving as a batch so the way it will have to work is like the torchdiffeq backend: split the batch up and sample each batch item, switch to the next, etc. in other words, there basically won't be any benefit to batches if you're using the Diffrax solver. (torchsde is the only solver that actually supports batches internally, but it also is less maintained/has less features so i wouldn't really recommend using it instead.)

@wcde just pushed a change that should fix this (i also found and fixed some other issues related to batches and the solver samplers). note: i still wouldn't really recommend using batches with those samplers since there isn't really an advantage and there's more chance of stuff breaking/not working properly.
can you confirm the latest version solves your problem?

this should be fixed now. i'm going to close this issue. if you are still having the same issue, feel free to comment in here and we can reopen it.


Branches for different walkthrough stages

Create branches for stages in the walkthrough so that people can catch up / skip ahead to a known point.
e.g. .a branch with an additional command or inventory items.

Updated code has one custom command and unit tests.. more?


Showing "(Apps, bots, & connectors)[deploy-apps-microsoft-teams-landing-page.md]" (Markdown notation)

en-us:"https://docs.microsoft.com/en-us/microsoftteams/enable-features-office-365"
"(Apps, bots, & connectors)[deploy-apps-microsoft-teams-landing-page.md]"
ja-jp:"https://docs.microsoft.com/ja-jp/microsoftteams/enable-features-office-365"
"(アプリ、ボット、およびコネクタ) [deploy-apps-microsoft-teams-landing-page.md] "

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c9b7f77-061d-a224-ff1c-8d3e15d21221
Version Independent ID: 00fa9550-c4c4-3398-ffbb-271cc724048f
Content: Manage Microsoft Teams settings for your organization
Content Source: Teams/enable-features-office-365.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

Duplicated #1894

@hyoshioka0128 Since this is a duplicated issue and a solution has been implemented and just waiting to be approved I am going to go ahead and close this issue.
Thanks,
Manuela

@officedocsbot close


All net.bridge tasks are being skipped

Looks like all the net_bridge tasks are being skipped.  I noticed in the playbook there is a conditional that shows the task will run if the Ansible dist is not Debian or the major version is less than 10.  This is what I have,  I installed Raspberry Pi OS Lite (64 bit) a port of Debian that is compatible for Pi 3/4/400. Is any of this my problem.  My nodes are not able to connect to the master and I think this is the cause.
ansible [core 2.12.3]
config file = None
configured module search path = ['/home/pi/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python3.9/dist-packages/ansible
ansible collection location = /home/pi/.ansible/collections:/usr/share/ansible/collections
executable location = /usr/local/bin/ansible
python version = 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110]
jinja version = 3.1.1
libyaml = True

I resolved this by changing major version is < 10 to major version is > 10.

@sdaynjax - Was that a change you needed to make to this project's code? If so I can work on fixing it in the project too.


pull request for e2e test at 01/22/2017 13:45:17

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Is this production ready?

Hey!
I am considering KVRocks, however the manual cluster setup, the missing failover feature and the 1 by 1 slot migration is a big obstacle (I will often scale up and down the cluster).
Is this kvrocks controller meant to be ready for production to support these or it is still under development?

@MrBlaise Yes, it's production ready now. Will publish a formal release soon.

Come on ,come on.


Adds the v2 build to all deploys

Should appear in pr/staging/prod builds under /v2/ in the URL

Cool, https://typescript-site-79.ortam.now.sh/v2


Prepared winit for glutin porting

For https://github.com/tomaka/glutin/issues/813

Looks good.

Yay! Can you update crates.io version? I will fix Cargo.toml in https://github.com/tomaka/glutin/pull/819 then.


validate paas when switchState.dataConditions.transition is empty

What happened:
when remove the test example's https://github.com/serverlessworkflow/sdk-go/blob/main/parser/testdata/workflows/applicationrequest.json#L35 transition field，the ut still pass.
What you expected to happen:

The unit test report failed

How to reproduce it:
Anything else we need to know?:
 If not, I can provide the fix :)

@lsytj0413, are you submitting a PR for this? If not, I can provide the fix :)

I'm working on the fix for it，and the i will post the plan for discuss under the issue.

For fix this issue, I proposal to replace go-playground/validator/v10 with all custom validate function.
How do we use validator:

we only use five tags: required、omitempty、min、max、dive
use StructLevelFunc for addtional validate
the error message will contains struct & field names

From the above description it can be known that we only use a few feature in validator.
disadvantage:
In the implemention of workflow validation, i have noticed some scenarios which difficult to implement or mis-used:

invalid tag:

Example: ActionExecTimeout string json:"actionExecTimeout,omitempty" validate:"omitempty,min=1"``
This field is taged as omitempty, so it could be empty string(min = 0), and min=1 is unneeded

It's hard to implement ExpressionLang validationg

This validation function depend on workflow's configuration, so it should paas-to all under StructLevelFunc
within validator framework, we only pass it in ctx

A lot Custom Validate function should be defined

such as []Retry，we should validate the retry's name is unique, so we must add Custom Type for validation function
Jitter floatstr.Float32OrString json:"jitter,omitempty" validate:"omitempty,min=0,max=1"``, is validate in invalid

Use dive on workflow.States cause a lot of validate error

For example, this will bring Workflow.States[0].Timeouts.StateExecTimeout.Total，Workflow.States[0].BaseSwitchState.DefaultCondition.End.ContinueAs.WorkflowRef.WorkflowID validate error

imo，the go-playground/validator/v10 is powerful, but it brings some limitations, specifically we need a lot contextual validation. So i proposal to replace go-playground/validator/v10 with self-implemented validate function.
cc @ricardozanini

@lsytj0413 the proposal is good, but I think that even with the limited scope we are using, it still is something we didn't have to do for ourselves.
We can review the tags, add more appropriate ones/fix the existing and create custom validation within the framework.


Add spec for m.room.pinned_events

I don't actually know if this is correct, as I can't build matrix-doc. Please let me know if I've done it wrong, and how to fix it.
Addresses https://github.com/matrix-org/matrix-doc/issues/550

the spec looks fine to me (modulo the https://github.com/vector-im/riot-web/pull/5142#issuecomment-336670536 comment that in future we might want to consolidate pinning with general event tagging - e.g. upvoting/downvoting).  @richvdh, you are probably best positioned to say if it for spec/syntax validity?

@matrixbot: test this please

@richvdh updated. I have no way of testing this and am going off of what code in the area looks like, so please pardon my mistakes if they're present.

This is brilliant, thank you!
(writing some notes on how to build the spec locally is on my todo list...)


Optional properties fail types that do not have those properties

Flow version: 0.98.1
Expected behavior
Width subtyping should allow types that do not have optional properties of other type to be used in place of other type.
Actual behavior
Types that do not have optional properties fail type checking even though the property is optional.
I expect this to be valid because Thing's notRequired is optional so OtherThing shouldn't need it.
type Thing = {
  notRequired?: string
}

type OtherThing = {
   name: string,
}
const otherThing: OtherThing = {
}

function doit(thing: Thing) {
}

doit(otherThing);

Link to Try-Flow or Github repo: https://flow.org/try/#0C4TwDgpgBAKgFgSwHYHMoF4oG8BQUpID2wAShAI4CuCAThACYD8AXFAM7A3Io4C+OOUJCgB5YHAg143DNjz4kAQwC2EVhy6oANFD44AxoSQcoxCVMSpWY89NSzc-AQDNKSfcARGo9QgmAAFOLcrHYoAJRy+Ho4vv4BZpJh4QDcQA

This is not a bug. You can think about option properties has having type T | void. That is, { x? : T} is roughly equivalent to { x : T | void}. If we allowed you to use width subtyping in the way you suggest, that would lead to the following unsound behavior:
https://flow.org/try/#0C4TwDgpgBAKgFgSwHYHMoF4oG8BQUpID2wAShAI4CuCAThACYD8AXFAM7A3Io4C+OOUJCgB5YHAg143DNjz4kAQwC2EVhy6oANFD4CAxoSQcoxCVMSpWY89NSysBYmSq0GUVgBYdS1R6gARIps9ABmAVD8AqGUSPrACEZQ9IQIwAAU4tysdigAlHL4ejgpaelmkrl5ANxAA

If we allowed you to use width subtyping in the way you suggest, that would lead to the following unsound behavior:

How is this unsound?

Within the body of doIt, the type system believes that the notRequired property of thing is optionally a string. However, when we created otherThing, we set it to a number. If we were able to pass otherThing in to doIt, we would be in a situation where the type system believes notRequired is a string, but it's actually a number. If the implementation of doIt used a function that only worked on strings, there would be a runtime error. See https://flow.org/try/#0C4TwDgpgBAKgFgSwHYHMoF4oG8BQUpID2wAShAI4CuCAThACYD8AXFAM7A3Io4C+OOUJCgB5YHAg143DNjz4kAQwC2EVhy6oANFD4CAxoSQcoxCVMSpWY89NSysBYmSq0GUVgBYdS1R6gARIps9ABmAVD8AqGUSPrACEZQ9IQIwAAU4tysdigAlHIAkAihmZYoAHREpBTUdPR5uPj4hVmoVc61bvSybZXVLnUMFcCEADKEAO6SAMLBEOl5ANzy+PxRKWnpZpK5y0A for an example

Thank you for the explanation, I understand now.


[Question] good practices of handling BLE Connection.

This is not a bug, but a discussion.
I wonder what the best practices are for handling the connection to a BLE device,
do you connect when the app is open and only close the connection when the app closes ?
do you connect/disconnect every time an action (read/write) is performed ?
the first seems way easier to implement (no need for connection locks etc), but what's the effect on the batteries ?
P.S: I can not remove the bug label

Good question!!
I was wondering the same. I ask every time to the user about it but it would be more confortable if i could reconnect it automatic.
I mean, every time i need to start reading, i show the prompt to connect the device but if he change or close the mine, he lost the connectiong.

The question is definitely much better answered for a specific case, because in general "it depends" 🙂
Connection duration has less effect on battery life than you might think, as it really depends on what the connection intervals are.
In general, connecting consumes a fair amount of power (as scanning is required) compared to a long running idle connection.
Given no other background context, my recommendations would be:

automatic connect on launch
keep the connection open while the app is open
measure the battery impact of your app

This is by far the least error prone and most reliable way to get data with mobile phones 🙂


QrCode is not scanning

This code is not working in android version 12 , qr code is not scanning

Hello, the application supports devices up to Api level 33. However, as a result of my research, I came to the conclusion that the library I used for the QR code in the application does not work on some devices. It won't work on some devices because of this library. To resolve this situation, the library needs to be updated. :'(

okay, can you suggest me any library which works on above android 12

I don't know what library you are looking for. You can search android libraries for android level 32.


Add snowflake support

Simply adding support for the Snowflake driver.  I hope I added the dependency correectly.

Think we could get this merged soon? I would love to be able to use the official sql_exporter image rather than have to build from source and host my own...

Hi @free, it sounds like there's at least two parties looking for this feature.  Need anything else from me to facilitate reviewing this PR?

Hey @free! Any updates here? Would really love to be able to use the hosted sql_exporter image.  Please let me know if there is anything you need from me to help get this pushed through and a new release cut!

Hey @free! Any updates here? Would really love to be able to use the hosted sql_exporter image.  Please let me know if there is anything you need from me to help get this pushed through and a new release cut!

Hey @free, @burningalchemist.  It looks like maybe this repo is losing support, as it has not been updated in quite some time now.  Is there anything we can do to help support it? I know this is a widely used tool in various locations, but we are in a place where im guessing most people are forking and managing their own, versus just using the open source version.
What can we do to get some of these PRs approved/merged?

Hey @nomeelnoj, you can take a look at the fork I maintain for the moment: https://github.com/burningalchemist/sql_exporter
It's compatible, has some updates, and I keep using it myself, so happy to look into the issues, if there are any.
It might be that at some point we can merge things back to the original repo, or maybe not. 🙂
If this works for you, give it a shot. 👍

@burningalchemist thanks! ill definitely take a look.  Seems that the original maintainers of sql_exporter have gone MIA...sadly.

@nomeelnoj feel free to leave a comment, if there's an issue with it. 👍 I updated the latest snowflake driver version recently.
It's a bit tricky to test it with snowflake without creating an account, but I'm happy to look into it if anything. 🙂

why is this not merged? we are currently using it, and works as expected.

Any update on this? Why has it not been merged?


Newsletter doesn't seem to be working

Firstly thanks a lot for your awesome template!!
I have followed https://bael-theme.jake101.com/blog/2018-07-08-email-newsletter-setup-instructions
I can get the newsletter sign up confirmation email working. However, when I tested update notification through email by creating a new article, no updates were received on the registered emails. Am I missing something? Am I supposed to send out blog updates manually through SendGrid dashboard?
FWIW my repo is https://github.com/tejasvi/blog.mefyi.com hosted on blog.mefyi.com

There were some issues with IP.


[iOS only]multi-line comment works well,and single line comment does not .

When my code is
import {masterData} from './masterData';
// import {mobileModification} from './mobileModification'
import {isFetching} from './isFetching';
The iOS app crashed and showed this:

It seems like the comment doesn't work,the import command still be explained.
But when I use multi-line comment instead,it works well.
import {masterData} from './masterData';
/* import {mobileModification} from './mobileModification'*/
import {isFetching} from './isFetching';
What's more ,I can use single line comment on Android.
Finally,my react native version is 0.2.0

@lavystord: I can't reproduce your problem, when you say your version of react-native is 0.2.0 did you mean 0.20.0 ?

@facebook-github-bot label ios

@magrinj yeah,it's 0.20.0,maybe because my machine is windows? But my colleague who uses mac encounter the same problem with the same code repository.

Yes that's sound really strange, I'm on 0.22 and I don't have this problem, maybe try updating your project.
I don't think that gonna change anything, but try to put a ; at the end of your comment...

@magrinj thanks.It really sounds strange.I put a semi-colon at the end of my comment,but it still doesn't work.
This problem is really to reproduce to the people who don't have the same code.But I trigger this problem 100% on iOS . Then the same code android works well,so I guess it has nothing to do with my code.It maybe the bugs of react native.So I create a  issue here,hope someone has some ideas about possible reason to incur this problem.
Maybe until I upgrade the react native,this problem will be missing.

@lavystord I've no more ideas at the moment...
You're right, but I can't reproduce it on 0.22, so if this problem existed before, I think it's solved now :)

@magrinj  I fixed this by upgrading the RN version to 0.23.1.

@lavystord Ok perfect :)

@facebook-github-bot answered

Closing this issue as @geirman says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.


Is PWACompat recommended for production projects?

Is PWACompat recommended for production projects?
As I see it in the GoogleChromeLabs GitHub organization I'm not sure.

As an update (and I'm closing this): we see lots of use now.
v8.dev uses us as a lazy load just for iOS, via unpkg, with no specific version in mind, which is good practice to always get the latest fixes.


[WIP] local setup docs

Pull Request Test Coverage Report for Build 284

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.566%

Totals

Change from base Build 279:
0.0%

Covered Lines:
1073

Relevant Lines:
1254

💛  - Coveralls

The information was extracted and used in documentation.


[#2471] Failed to find OpenSSL development headers on MacOS

signed-off-by: Thomas Diesler<EMAIL_ADDRESS>

@tdiesler, I've fixed the issues causing the Jenkins builds to fail (https://github.com/hyperledger/indy-sdk/pull/2470).  If you rebase your PRs on the latest from the main branch the builds should work and we can get your PRs merged.

merci

I rebased - samples/java/README.md is not touched by this PR any more


AlbTargetGroupResponse automatically base64 encodes data

I'm using this to return some image data from a lambda:
    let resp = AlbTargetGroupResponse {
        status_code: 200,
        body: Some(Body::Binary(buf)),
        headers: HeaderMap::new(),
        is_base64_encoded: true,
        multi_value_headers: HeaderMap::new(),
        status_description: Some(String::from("200 OK")),
    };

It appears that when using body: Some(Body::Binary(buf)), this library automatically encodes the payload in base64.
In this case, is_base64_encoded should be set to true. However, it might make sense to drop the is_base64_encoded field entirely, and auto-generate that based on the type of body:

If body is Body::Text -> is_base64_encoded = false.
If body is Body::Binary -> is_base64_encoded = true.
If body is Body::Empty -> irrelevant...?

Given that most of the code around this is auto-generated, I'm not sure if this is even possible.
Are there any fields that are auto-generated based on other's value? Do you think my suggestion makes sense, or is it simpler to just add a note in the docs explaining that binary content is always base64 encoded?

Hmmm, I'll have to think about this. I think we can support this case but it will take some refactoring.

Somewhat related: If when returning Some(Body::Empty) from a lambda the ALB then yields 502. Returning None works though. If I understand the source correctly, Some(Body::Empty) is converted to body: null, but None merely results in the field being committed when serialising.
I'm using this in a helper for now (I takes body: Body as input):
    let (is_base64_encoded, body) = match body {
        Body::Empty => (false, None), // Body::Empty results in ALB returning 502.
        Body::Text(_) => (false, Some(body)),
        Body::Binary(_) => (true, Some(body)),
    };

Is the go code correct in this case? Does it have omitempty?

It does not: https://github.com/aws/aws-lambda-go/blob/1ba09afd7523e0d5a8a2e2fb58ddb8ec8b92ebb7/events/alb.go#L13
I guess it should tho. Will report that there, thanks.

Go code is now correct:  https://github.com/aws/aws-lambda-go/pull/408
I think it's a matter of re-generating the auto-generated code?

The Alb code is no longer under the generator, so we can make any adjustments we'd like to improve the experience of using that type, like the automatic encoding selection that you mention in the description.
Feel free to make changes in that module: https://github.com/LegNeato/aws-lambda-events/blob/master/aws_lambda_events/src/alb/mod.rs


refactor(storagenode): add a category to storage flags

What this PR does
Add the category "Storage" to the storage flags.

Current dependencies on/for this PR:

main

PR #528

PR #529

PR #530

PR #531   👈

This comment was auto-generated by Graphite.

Codecov Report
Patch coverage has no change and project coverage change: -0.19 :warning:

Comparison is base (6505980) 62.33% compared to head (1396a1a) 62.14%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                  Coverage Diff                  @@
##           storage_trim_rate     #531      +/-   ##
=====================================================
- Coverage              62.33%   62.14%   -0.19%
=====================================================
  Files                    133      133
  Lines                  18512    18512
=====================================================
- Hits                   11539    11504      -35
- Misses                  6407     6430      +23
- Partials                 566      578      +12

see 6 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ijsong started a stack merge that includes this pull request via Graphite.


Potion NamespacedKey. again...

Continued from https://github.com/pl3xgaming/Purpur/pull/710
Sorry for closing and reopening a new pr again, i was having issue with my previous fork and I'm not too experienced with pr and fork stuff so i deleted it and forked again to make the changes needed.
I've had these changes in use on a production server for about a month or so with no more issues so it should be all good with plugins and what not.

I've fixed an issue that caused  serialized potion effects to cause null issues etc
Now custom potion effects on CraftMetaPotion have the namespacedKeys too
No longer serialize null namespaces for potions
Added some annotations
Probably other misc stuff too

Should I reapply this to the 1.18 branch and make a pull request from there as it seems the 1.17.1 branch has had its final updates

Once our 1.18 release is ready, yes. We're currently in a feature freeze as the update takes place

Superseded by #783


#4 and #5 Completed

@rultor merge

@rultor merge

@driver733 I'm sorry, I don't understand you :( Check this page and try again please

@rultor merge

@driver733 The pull request is closed already, so I can't merge it

Coverage increased (+1.9%) to 21.234% when pulling d843bc5b046718bdb4400592fca826d8ecaaef17 on #4 into 0820c7d72569ffa9fcfba7a487567c1609ad040d on master.

Coverage increased (+1.9%) to 21.234% when pulling d843bc5b046718bdb4400592fca826d8ecaaef17 on #4 into 0820c7d72569ffa9fcfba7a487567c1609ad040d on master.


Add/modify tests for changed idp discovery flow.

When login_hint is provided and it does not match an idp, redirect to login page of that zone, instead of email page.
When idp discovery is enabled and the email domain does not match an idp, redirect to login page of that zone instead of email page.

Sometimes the username and email of a user do not match and the current implementation assumes that they are always the same.
Signed-off-by: Henry<EMAIL_ADDRESS>

Coverage decreased (-20.6%) to 65.269% when pulling c9821b611b056ee58ac196f9ede0afe1159e5771 on GESoftware-CF:bug/idp_discovery_login_hint into 32c2b809f6bcbb069fc9967053d6d53301753272 on cloudfoundry:develop.

Coverage decreased (-20.6%) to 65.269% when pulling c9821b611b056ee58ac196f9ede0afe1159e5771 on GESoftware-CF:bug/idp_discovery_login_hint into 32c2b809f6bcbb069fc9967053d6d53301753272 on cloudfoundry:develop.

Coverage decreased (-20.6%) to 65.269% when pulling c9821b611b056ee58ac196f9ede0afe1159e5771 on GESoftware-CF:bug/idp_discovery_login_hint into 32c2b809f6bcbb069fc9967053d6d53301753272 on cloudfoundry:develop.

Coverage decreased (-20.6%) to 65.269% when pulling c9821b611b056ee58ac196f9ede0afe1159e5771 on GESoftware-CF:bug/idp_discovery_login_hint into 32c2b809f6bcbb069fc9967053d6d53301753272 on cloudfoundry:develop.

Coverage increased (+0.006%) to 85.839% when pulling 2df50ce987dedd2c74d65bf289cabd8ce211bfc0 on GESoftware-CF:bug/idp_discovery_login_hint into 32c2b809f6bcbb069fc9967053d6d53301753272 on cloudfoundry:develop.

We have plans to address this by prompting the user for a username if the username and email are not the same. We will do so by updating the page which collects the password only today


Hover effect on Logo in Landing page

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
When someone hover over the logo image "B" it will slightly rotate sideways and appear little bit bigger in size giving enhanced UI effect.
Screenshots

Code of Conduct

[X] I follow Contributing Guidelines of this project.

hey i can work on this issue please assign this task to me it would be great help.
thank you

Yo! I have already fixed this issue. Can you review it? :)

can I work on this issue if it is not resolved yet?

Not needed. Pls work on other good issues @Prachurya-Ray


fix: Store LiveData & Listeners as global variables in SpeakerListFragmentViewModel

Fixes #2061
Changes: LiveData and onChangeListeners for Realm are now stored as global variables in SpeakerListFragmentViewModel. Instances are cleared in onCleared.
Screenshots for the change: NA
@iamareebjamal Please review

Changes: Creating new LiveData only when it's null.
@iamareebjamal Please review.


chore(release): :rocket: publish v3.0.0

Description
Publish v3 of this Chart, with a configurable traefik port and smoother integration for handling Static Configuration.

Hello,
With v2.0.0 we added some breaking changes but we need to check the port definition for TraefikEE proxies.
Previously we could define port 80 and 443, which is not possible anymore (I approve that choice), but following an attempt to upgrade a value definition and a deployment from v1.X.Y to v2.0.0 I can see one issue implied by this change.
By simply removing the possibility to use ports 80 and 443, users will have to change entryPoint definition within their static.
The customers doing a simple patch update v2.10.4 to v2.10.5 through Helm may have surprises (and hear me out they are not looking at the release notes we are doing).
What do you think, would it be a wrong idea to get back port 80 and 443?

For me the problem is that we are forcing port upper than 1024 within the proxy deployment (which in terms of security make sense):
          {{- range $port := .Values.proxy.ports }}
            {{- $containerPort := ($port.targetPort | default $port.port) }}
            {{- if lt (int $containerPort) 1024 }}
              {{ fail "ERROR: Cannot set a privileged port on a non-root container" }}
            {{- end }

Maybe setting a warning instead of a fail with error should be sufficient.

For me the problem is that we are forcing port upper than 1024 within the proxy deployment (which in terms of security make sense):
          {{- range $port := .Values.proxy.ports }}
            {{- $containerPort := ($port.targetPort | default $port.port) }}
            {{- if lt (int $containerPort) 1024 }}
              {{ fail "ERROR: Cannot set a privileged port on a non-root container" }}
            {{- end }

Maybe setting a warning instead of a fail with error should be sufficient.

There is a securityContext in v2 setting unprivileged user.
Unprivileged user cannot open a port < 1024.

Then do you think we need a mechanism to explicitly disable security principles ?

If user needs unsecure setup, we will need to implement to option to remove securityContext, use root user and privileged ports. I guess it can be done in an issue, and not this PR.

@darkweaver87 if you agree with @mloiseleur, do you think such a PR needs to be done before v3.0.0 is released ?


Amplify.Datastore.clear() doesn't clear out local store after switching the environment

Describe the bug
I have two environments: dev and prod. After switching the environments with amplify CLI, Amplify.Datastore.clear() does not clear local store from the previous environment. Restarting XCode and rebuilding the project does not help.
The only thing that works is to remove the app from the simulator (device), so it is installed fresh by XCode.
Steps To Reproduce
Steps to reproduce the behavior:

1. Run 'amplify env checkout dev'
2. Run iOS app with Amplify.Datastore
3. Run 'amplify env checkout prod'
4. Run iOS app
4a. Call Amplify.Datastore.clear()
4b. Call Amplify.Datastore.query()
5. Get DataStore results from 'dev' environment.

Expected behavior
I expect that clear() will clear out 'dev' data.
Amplify Framework Version
1.13.4
Amplify Categories
DataStore
Dependency manager
Swift PM
Swift version
5.3
CLI version
5.3.1
Xcode version
12.5.1
Relevant log output
No response
Is this a regression? (i.e. was this working before a version upgrade)
No response
Device
iPhone11-simulator
iOS Version
14.5
Specific to simulators
No response
Additional context
No response

@skryshi are you calling DataStore.clear as the very first DataStore operation?
If so, there's a chance the underlying engine hasn't fully started and the .clear operation gets just ignored.

@diegocstn Yes, I am calling DataStore.clear as the very first DataStore operation. If that's not right, then what is the recommended sequence of calls to get DataStore started and ready? It's not in the docs.
ATM, I have this:
        let models = AmplifyModels()
        let apiPlugin = AWSAPIPlugin(modelRegistration: models)
        let dataStorePlugin = AWSDataStorePlugin(modelRegistration: models)
        do {
            try Amplify.add(plugin: apiPlugin)
            try Amplify.add(plugin: dataStorePlugin)
            try Amplify.add(plugin: AWSCognitoAuthPlugin())
        } catch {
            assert(false, "Could not initialize Amplify: \(error)")
        }
        DataStore.clear { _ in }

@skryshi I think the DataStore.clear operation shouldn't strictly depend on the status of the underlying engine.
We'll take this as a bug/enhancement, dive deep and evaluate possible solutions aligned with the other platforms.
You can perhaps start DataStore first by using .start and if succeeded call .clear, but this approach has the unwanted side effect of kicking-off the sync engine.

@skryshi we've released a fix for this in Amplify v1.22.0


Change GalSim WCS so that world coords are in degrees

This matches the SDSS WCS and makes the hard-coded default loc_width work.
I've also changed things to account for the fact that e_scale is in pixel coords.

Looks really good, Steve. I like those @galsim_test_case decorators.
Does this PR close #293?

Sure, I closed the issue.
On Sat, Nov 26, 2016 at 12:48 PM Jeffrey Regier<EMAIL_ADDRESS>wrote:

Merged #434 https://github.com/jeff-regier/Celeste.jl/pull/434.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeff-regier/Celeste.jl/pull/434#event-872690284, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABC_kIX6kTYG9ZLLloRU1hXWT602oK3Lks5rCJsWgaJpZM4K8-pv
.

I uploaded the latest FITS image to portal.nersc.


Appstudio update test-annotations-xaot

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-mbrb-on-pull-request-
creating pipelinerun test-simple-build-mbrb-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-efea-on-pull-request-
creating pipelinerun test-simple-build-efea-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nycf-on-pull-request-
creating pipelinerun test-simple-build-nycf-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-ckox-on-pull-request-
creating pipelinerun test-simple-build-ckox-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-fuha-on-pull-request-
creating pipelinerun test-simple-build-fuha-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-phhr-on-pull-request-
creating pipelinerun test-simple-build-phhr-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-gsnx-on-pull-request-
creating pipelinerun test-simple-build-gsnx-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-pmki-on-pull-request-
creating pipelinerun test-simple-build-pmki-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-igaw-on-pull-request-
creating pipelinerun test-simple-build-igaw-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-fglt-on-pull-request-
creating pipelinerun test-simple-build-fglt-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-wipu-on-pull-request-
creating pipelinerun test-simple-build-wipu-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-xtci-on-pull-request-
creating pipelinerun test-annotations-xtci-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-izee-on-pull-request-
creating pipelinerun test-simple-build-izee-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-jpia-on-pull-request-
creating pipelinerun test-simple-build-jpia-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-qezd-on-pull-request-
creating pipelinerun test-simple-build-qezd-on-pull-request- in namespace build-e2e-hsge-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI/test-annotations-xaot-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
4 minutes
inspect-image

✅ Succeeded
4 minutes
deprecated-base-image-check

✅ Succeeded
49 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
23 seconds
label-check

✅ Succeeded
5 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-annotations-xaot-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
4 minutes
inspect-image

✅ Succeeded
4 minutes
deprecated-base-image-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
49 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
23 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary


Add --cf to cancel of task

We all know what +cancel does now and we all know --cf will confirm that action, combine them.

Done in next update


OIDC4VC draft 22 : remove client_id_scheme and turn it into a prefix of the client_id; this addresses a security issue with the previous solution

With Draft 22 and above the client_id_scheme is removed  from the authorization request but the value is added to the client_id to be the new client_id value
in the client_id Authorization Request parameter and other places where the Client Identifier is used, the Client Identifier Schemes are prefixed to the usual Client Identifier, separated by a : (colon) character:

<client_id_scheme>:<orig_client_id>

We dont need to change the logic if the wallet recalculates the previous value of the client_id_scheme based on the above rules.
Examples:
 client_id=redirect_uri:https://client.example.org/     -> previous client_id_scheme = redirect_uri and client_id = https://client.example.com
client_id = did:web:talao.co  -> previous client_id scheme = did and client_id = did:web:talao.co be careful to this one as did must be replicated
 client_id = verifier_attestation:example.com  -> client_id_scheme = verifier_attestation and client_id = example.com
client_id = x509_san_dns:client.example.org -> client_id_scheme = x509_san_dns

Test OIDC4VP Test 3 with PID
Attention : the client id scheme is X509, so wallet must decode the x509 certificate and ask user consent with the dns_name of the X509 certificate. it was fine a few months ago.
so in this test client_id =  x509_san_dns:talao.co


Version 1.0 of python lab 2

Merge develop into master

Completed version 1.0 of python lab 2
Added a contacts module and main module

Version 1.0 of python lab 2 looks ready to merge to master.


how to save the stream in to mp4

Hi,
is there a option to save the stream in 10-30 min video files ?
BR,
Sahin

Hello.
Thanks for this idea. There is no such option for now.
This viewer was created to show cameras on a slow machines with traffic optimization.
That's why it was called "viewer".
It would be a great ability of program, but switching to vlc 3 is more important, but I have no time for that, sorry.


Url validation error

Url validation error

manifests\c\cheat-engine\cheat-engine\7.4.0

https://github.com/cheat-engine/cheat-engine/releases/download/7.4/CheatEngine74.exe

This URL has previously been reported as Malware to Microsoft Defender SmartScreen
If you believe this is in error, you may file a report

Originally posted by @wingetbot in https://github.com/microsoft/winget-pkgs/issues/52246#issuecomment-1065894875

How can I solve this problem?

You can report the URL as not malware in the link provided. After that you just have to wait and see if the SmartScreen team unblocks it. Until they unblock it, there isn’t anything you can do

You can report the URL as not malware in the link provided. After that you just have to wait and see if the SmartScreen team unblocks it. Until they unblock it, there isn’t anything you can do

Thank you!


Update IpVerse to ipverse-rir-ip

The IpVerse domain is unavailable and is redirected to https://github.com/ipverse/rir-ip where new aggregate ip's are provided. This modification updates the referring url.

Thanks for the patch!


Tiff - Transparency - Request

Hi I found your script which I think is awesome and definitely adds to photoshop.
Photoshop used to have a feature in their "layers to files export" that allowed you to export tiff images - this has since been removed - 2021 / 2022 versions.
I found your script looking for a solution to this. I need to export tiff's as transparent tiff's. Png is an option - but I want to retain the 300 dpi of a tiff.
Currently my work around is export using your script as psd, then save as tiff. It's a long way around. Definitely
would appreciate a transparent checkbox saving a few minutes in a process.
Well done on the coding of this so far. Your script is brilliant.

This is now part of the latest release (2.5.0)!

Thank you so much. That is a wonderful to here. I hope you have an awesome week!


Mojang error with "dark_latex_wolf_partial"

when I was trying to run this mod, it kept giving me the error "java.lang.IllegalArgumentException: No model for layer changed:dark_latex_wolf_partial#main" at which I decided to send this issue here hopefully it'll be fixed, if not its fine.

Please see #943


[Excel, PowerPoint, Word] (equivalent COM) correct erroneous note abo…

…ut support for equivalent COM add-ins

Docs Build status updates of commit 93844cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/make-office-add-in-compatible-with-existing-com-add-in.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5b79297:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/make-office-add-in-compatible-with-existing-com-add-in.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Remove print from implementation of combineLatest

These calls to print caused unexpected output to appear in apps using Async Algorithms.

cc @FranzBusch


Inspire: note in bibtex

Originally by annetteh on 2012-04-16
The 500 note field should not be included in the bibtex output

Done


Use Python 3.8 on OSX for Foxy

Replaces https://github.com/ros2/ros2_documentation/pull/641, which has more context.

We should probably also update the building from source instructions too

Added in 1762143

I think we can remove python3 from this line.

deleted python3 from that line in 820b205


python sdk 1.6.3 release notes added

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: \ python sdk 1.6.3 release notes added
Jira/GitHub Issue numbers (if any): \ FFM-11762
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[X] Successful preview build.
[X] Code owner review.
[X] No merge conflicts.
[X] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669650910dc845f8414dbdd9--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669650da0dc845f8644dbf38--harness-developer.netlify.app


Parse evaluate hook does not capture all expression evaluations

What is the expected behavior?
The hook seems to miss quite a few events, the following should work
What is motivation or use case for adding/changing the behavior?
evaluate hook should capture all expression events
How should this be implemented in your opinion?
walkExpression(expression) {
   this.hooks.evaluate.for(expression.type).call(expression)
   ...
}

and removing it from evaluateExpression ()
Thought I am not quite sure on the internals of walkExpression vs evaluateExpression, so maybe just a new hook type would be better
Are you willing to work on this yourself?
yes, with guidance

Updated original post

/cc @ooflorent

Can you give an example of what you are trying to do and how you use the evaluation feature of the parser?

file_to_parse.js:
calling()

class TestPlugin {
  apply (compiler) {
    compiler.hooks.normalModuleFactory.tap('TestPlugin', factory => {
      let handler = (parser, options) => {
        parser.hooks.evaluate.for("CallExpression").tap('TestPlugin', node => {
          if (node.callee.type === 'MemberExpression') {
            console.log('CALL', `${node.callee.object.name}.${node.callee.property.name}`)
          } else {
            console.log('CALL', node.callee.name)
          }
        })
      }
      factory.hooks.parser.tap('javascript/auto', 'TestPlugin',  handler)
      factory.hooks.parser.tap('javascript/dynamic', 'TestPlugin',  handler)
      factory.hooks.parser.tap('javascript/esm', 'TestPlugin',  handler)
    })
  }
}

If you add the call in walkExpression the above works

Are you sure that evaluate is what you are looking for? evaluate hook is called when an expression needs to be evaluated. In the above example, webpack won't try to evaluate calling(). However, you can catch the call using call hook.

The hooks are only useful if you know what you are looking for, e.g the name of the method "calling", e.g hooks.call.for("calling")... however if you want to parse all calls in the module this can't be done this way.
Also I was assuming the evaluate hook meant walking into an expression? If this is not the case what does "evaluating" mean in the context of parsing and walking the ast ?

If this is not the case what does "evaluating" mean in the context of parsing and walking the ast?

When walking the AST, webpack tries to optimize which branches must be traversed by pruning the dead ones. Let's consider the following program:
if (calls > 2) {
  // …
} else {
  // …
}

webpack will evaluate the test:

Enters walkIfStatement
Calls this.hooks.statementIf

ConstPlugin hook get called
Uses Parser#evaluateExpression to get a basic evaluator
Optimizes the output source code is possible

If a decision has been made, ignore the dead branch

Parser#evaluateExpression is what is starting the evaluation. If the method isn't called, nothing gets evaluated. If you call it over a CallExpression, then hooks.evaluate.for("CallExpression") is fired.

Also an unrelated question, does modifying the ast (from hooks.program) get propagated down stream, so e.g babel/uglify will pick up changes?

Yes and no. webpack parses your file twice, at most. The first parsing retrieves the AST and traverses it to apply source changes. The AST is memoized but it isn't modified. Every change happens on the source code to avoid recasting the AST. When module concatenation is enabled, the newly generated file is parsed to enable scope analysis.
So let's recap:

If you change the AST, it will be picked up by post loaders (Babel runs before Parser)
Modifying the AST affects the traversal but would most likely break the codegen

Cool thanks for taking the time in explaining evaluate!
I am guessing then that Babble does it's own parsing with it's own internal AST as it is run before Parser?
How would you go about modifying the source in response to Parser events? I am guessing there is some dirty watch that triggers a 2nd AST pass if the source is modified during the 1st pass?

I am guessing then that Babble does it's own parsing with it's own internal AST as it is run before Parser?

That’s correct.

How would you go about modifying the source in response to Parser events?

Having a look at lib/ConstPlugin.js may be a good start. I’m closing this issue since the answer to the original question has been provided. Feel free to continue the conversation here if it does not turn into a dedicated support channel :wink:


Support LiveSync Debugging

The NativeScript CLI now supports LiveSync debugging through tns debug ios|android --watch, however, that same functionality does not appear to be available through Visual Studio Code. As soon as I perform one LiveSync the debugger no longer works as expected.

thanks, @tjvantoll.
We have plans on making this happen in VSCode but it requires some synced dancing between vscode + debug adapter + client app that will take time.
Right now you can rely on the fast Sync option to manually push the changes to your app directly from within VSCode. (without starting livesync on a console window). This will push only the changed file and will restart the app with debugger attached.

This option should be available when you add a new launch.json to your project. Make sure you recreate this file on existing projects.

Hey @blagoev,
I see the new “Sync” options, but I’m confused about what the workflow is supposed to be. When I run “Sync” the debugger starts as expected, but it does not setup a watcher. So if I want to see my changes I have to go to a terminal and run livesync manually, which kills the debugger.

the workflow is manually clicking that option when you make a change. It is equivalent of running livesync (w/o watch) + debug from a console.
The idea is that the user knows when to do a sync run or debug run. Sync does not rebuild so if you change a AndroidManifest.xml for example you need full debug run (which will do rebuild) and Sync is only for js/xml/css or other changes that do not require rebuild/repackage.

@blagoev Ok thanks, that does make sense. Is the plan to change the Sync open to also watch so that the manual step is no longer necessary?

yep I believe it is

I am closing this in favour of https://github.com/NativeScript/nativescript-vscode-extension/issues/78


Redux 4 Global Argument Error

Hi team redux,
I have found an error on the global argument database ( theme_mods, theme_mods_expanded ).
When I add the database like theme_mods or theme_mods_expended, I have found an error on saving of redux options and error is Ajax:warning.
And here is the errors list by actions.
PHP Warning:  Illegal offset type in ReduxCore\framework.php on line 661.
PHP Stack trace:
PHP   1. {main}() wp-admin\admin-ajax.php:0
PHP   2. do_action() wp-admin\admin-ajax.php:173
PHP   3. WP_Hook->do_action() wp-includes\plugin.php:465
PHP   4. WP_Hook->apply_filters() wp-includes\class-wp-hook.php:310
PHP   5. Redux_AJAX_Save->save() wp-includes\class-wp-hook.php:286
PHP   6. Redux_Options->validate_options() ReduxCore\inc\classes\class-redux-ajax-save.php:80
PHP   7. ReduxFramework->set() ReduxCore\inc\classes\class-redux-options.php:923
This error was so hard to find out for me. Because, I thought that error is in my PHP code. So, I sorted my PHP so many times. Before this ticket, I created a ticket, name by Dismisions Field Type Error and after realize that error is not in this field, I close the ticket.

Hey, could you post on the repo for the version of Redux you're using? This is the Doc site.
https://github.com/reduxframework/redux-framework = Redux 3.x
https://github.com/reduxframework/redux-framework-4 = Redux 4.x

Hey, could you post on the repo for the version of Redux you're using? This is the Doc site.
https://github.com/reduxframework/redux-framework = Redux 3.x
https://github.com/reduxframework/redux-framework-4 = Redux 4.x

Sorry I got it.


#121 WorkWeek view FirstDayOfWorkWeek param

Improvement to:
https://github.com/danheron/Heron.MudCalendar/issues/121

Thank you for your time on this 👍 @gabriuz


Add checkbox to windows

I'm quite new to Nim and GUI development in general (mostly a web dev), but I really love working with NiGui and would like to contribute.  I don't know if you are willing to break parity between Win32 and GTK3 (I only work on Windows), but I added some simple checkboxes to NiGui for an application I am working on.
I used your existing Button code as a jumping off point so the code is quite identical.  I'm sure I could add a "button type" feature into the existing button code, but for now checkboxes are a separate entity.  I also added a "getState" method to check on the state of the checkbox:   myCheckbox.getState() will return a 0 (BST_UNCHECKED) or 1 (BST_CHECKED).
I hope this can help improve this awesome GUI :)
So here goes my first ever pull request!

Thank you and congrats to your first PR :). I will review it the next days.

See also: https://github.com/trustable-code/NiGui/pull/17

From a quick read through his PR, it does appear to be a better implementation as I don't have any events, etc.  I'd suggest we use the PR citycide has proposed.  I'm also currently working on implementing the combobox/dropdown feature that I hope to submit soon.

I'm finally :)
I have extended your implementation in https://github.com/trustable-code/NiGui/commit/9d9babe7491f791545ddb7730a573e9b21cd3fa6.
Now it works very well for me (Gtk and Windows).

Excellent work, thank you again for NiGui :)


HIVE-28514: Addendum: Fix new added iceberg class code style

What changes were proposed in this pull request?

Fix new added iceberg class code style
Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

@ayushtkn Sorry i forget to rebase HIVE-28514 to cover the latest iceberg handler class.
This change fix the new added iceberg class code style.

mvn check passed. I merge this change first to avoid CI pipeline blocking.


Funding goal clears when logging in

When logging in I've noticed my funding goal clears.
Repro steps:

Log in
Set funding goal
Log out
Log in
Check funding goal

Video: https://9k1.us/xV@!/Screencast_2015-01-04_14:08:33.mp4

Ah, this is the ticket I was thinking of at IRC.

should there be a test for that?

@techtonik Yes! Want to write it? :-)

We already have a regression test, it was with the fix in #3051.


Add header blocking and filtering

Suggested changes have been committed, along with the patch fixture from h-viahtml


fix(evm): the EVMLA pipeline

What ❔
Fixes the EVMLA pipeline for EVM target.
Why ❔
Some deploy code functions were unsupported.
Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via cargo fmt and checked with cargo clippy.

Hey @PavelKopyl, could you allow : in buffer_ids for linking?
In EVMLA, these IDs are {path}:{name}.sol[_deployed].

Hey @PavelKopyl, could you allow : in buffer_ids for linking? In EVMLA, these IDs are {path}:{name}.sol[_deployed].

Hey @hedgar2017, sure. It looks like we also need to used keccak256(buffer_ids) hex string internally to overcome an issue with invalid symbol names.

To merge after merging the branch from LLVM.lock.

LGTM, don't occasionally forget to change the branch back to main before merge.

Hehe, already done! Will fix.


fix(DCOS-14334): Update CLI setup script

DCOS-14334 Well, the title explains a lot.
before

after

Checklist

[x] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

@tamarrow Can you review and confirm we have removed the login command please?
dcos auth login

LGTM

No problem @MatApple thanks for the review


allow user to not import previous annotations

I think it would be really swell if use_annotations T/F was surfaced to the end user with a prettyCheckboxInput, with the default being TRUE. This will allow the user to start from a blank slate if it is for some reason necessary to do.
I'd guess this is a low priority, quality of life type improvement.

This is still a relevant thought! We are going through the DCA with the design team for UI improvements - we will see how to incorporate that user story.


Update some tasks  status to pass before remove ad to REL PREP

Hi @rioliu-rh  updated according our discussion before, please check it, thanks

/lgtm


RN GoogleSignin native module is not correctly linked

I get next error when add module to project:

I get that problem when install pkg whitout linking (waiting autolinking RN^0.61.2)
When trying manual linking doesn't build and app's broke
Similar: #770
Steps to Reproduce:

yarn add @react-native-community/google-signin

react-native run-android || react-native run-ios

import { GoogleSignin, GoogleSigninButton } from '@react-native-community/google-signin'; render() { <GoogleSigninButton  ... />}

Environment
Please provide

RN^0.61.2
<EMAIL_ADDRESS>

I'm having the same issue, but still don't try the manual linking, will be my next step. If i got any update, i will put here.

this and many other libraries are not compatible with rn0.6 and it is extremely painful to upgrade

@fabriziobertoglio1987 let me just say that this library is compatible with 0.60 and newer. As for the issue-
Sorry you're having an issue. As the issue template explains, we require that you provide a runnable example (please try reproducing the bug with our example app) that reproduces your issue in a github repository. Please try to minimize the superfluous code and focus only on reproducing the bug.
please create a new issue with this and we'll be happy to review it!


Using Invalid instead of BadRequest or Forbidden in admission plugins

How to categorize this issue?
/area control-plane
/kind enhancement
/priority normal
What would you like to be added:
Currently the error handling in most admission plugins is both wrong and inconsistent, since errors due to invalid field values are reported either as BadRequest (400) or as Forbidden (403). Neither of these HTTP errors is appropriate for this situation.
Instead, such errors should be reported as Invalid (413) with a list of field errors as a parameter. The only admission plugin written in this way currently is the ManagedSeed admission plugin (not yet merged, see #3416), as this was the proper way identified during the review of #3177.
Why is this needed:
Reporting errors appropriately would improve the user experience when an admission fails for some reason:

The error message would better reflect the root cause of the error (invalid value of a field instead of e.g. bad request).
Multiple invalid fields could be collected and reported together, instead of reporting just the first error that has been encountered, as is the case already in the ManagedSeed admission plugin.

@timebertt Opened this one as discussed. Do you have any comments?

@timebertt Opened this one as discussed. Do you have any comments?

Nope, sgtm

Nope, sgtm

/priority 4

I looked into the issue,
The 413 HTTP error is defined as follow -
StatusRequestEntityTooLarge        = 413 // RFC 7231, 6.5.11
15.5.14.  413 Content Too Large

   The _413 (Content Too Large)_ status code indicates that the server
   is refusing to process a request because the request content is
   larger than the server is willing or able to process.  The server MAY
   terminate the request, if the protocol version in use allows it;
   otherwise, the server MAY close the connection.

I don't find this very nice to use error 413 for errors due to invalid field values, as this indicates Content Too Large.
Also,
apierrors.NewInvalid() return the StatusUnprocessableEntity i.e 422 http error code.
which is defined as follows -
15.5.21.  422 Unprocessable Content

   The 422 (Unprocessable Content) status code indicates that the server
   understands the content type of the request content (hence a 415
   (Unsupported Media Type) status code is inappropriate), and the
   syntax of the request content is correct, but was unable to process
   the contained instructions.  For example, this status code can be
   sent if an XML request content contains well-formed (i.e.,
   syntactically correct), but semantically erroneous XML instructions.

The 422 seems more reasonable. WDYT? @stoyanr

cc - @stoyanr @rfranzke @ialidzhikov

I think this 413 was a typo. Let's use apierrors.NewInvalid as suggested in the prose of the description.

/touch
/assign


latest kornia caused some trouble

In both of the following settings, I had to use an old version (v0.2) of kornia and install it via pip install kornia==0.2.
Running pip install -r requirements.txt
I think always wants to install the latest kornia (currently 0.5.2) which in turn wants the latest pytorch (currently 1.8.1).
local
➜ conda list | grep cud
cudatoolkit               9.2.148              h80a95b2_6    conda-forge
cudatoolkit-dev           9.2                      py36_2    conda-forge
cudnn                     7.6.5                 cuda9.2_0
pytorch                   1.1.0           cuda92py36h65efead_0
torchvision               0.3.0           cuda92py36h0601742_0

server
- boost/1.73.0
- cmake/3.16.5
- cuda/10.1.243
- cudnn/7.6.4
- gcc/6.3.0
- nccl/2.7.8-1
- openblas/0.2.20
- python_gpu/3.8.5

❯ pip list | grep torch
torch                           1.4.0
torchvision                     0.5.0

Hi @MartinHahner, since Kornia is a functional lib that used latest Pytorch functions, we cannot fully be fully compatible with previous versions. Basically, we are supporting torch versions after 1.6.0.
/cc @edgarriba @ducha-aiki

You can fix that via --no-deps flag. I believe, it works for the most of functions

Hi @MartinHahner, since Kornia is a functional lib that used latest Pytorch functions, we cannot be fully compatible with previous torch versions. Basically, we are supporting torch versions after 1.6.0.
/cc @edgarriba @ducha-aiki

Yes, I understand. It is just that upgrading pytorch to 1.6.0 or higher breaks other things for me.
The reason I posted this issue is to help others that might run into the same problem.


Update defaults.py

This is a small change to sort the TMS list. When registering some (50+) planetary TMS, it is really nice to have a sorted list available in the docs dropdown.

It seems to quite dislike the sort in the list comprehension!
>>> x = ['c', 'b', 'a']
>>> [i for i in x.sort()]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'NoneType' object is not iterable
>>>

But then is okay with:
>>> x.sort()
>>> [i  for i in x]
['a', 'b', 'c']

Okay to revert back to sort() on it's own line?

@jlaura maybe using sorted 🤷♂ (do whatever you want 😄 )
In [2]: x = ['c', 'b', 'a']

In [3]: [i for i in sorted(x)]
Out[3]: ['a', 'b', 'c']

Hopefully CI is happy with this and all is good to merge.

🥳


Add active projects

For each of the following, we need a one-sentence description and any non-github link that may be important:
✅  https://github.com/open-austin/budgetparty
https://github.com/open-austin/awesome-reports @patrickm02L
https://github.com/open-austin/liberate-appraisal-data @johnclary
✅  https://github.com/open-austin/lobbying-in-austin
✅  https://github.com/open-austin/harris-county-bookings
✅  https://github.com/open-austin/fake-the-news

Budget Party is a web app design for mobile devices that teaches you about the City Budget and invites you to remix how departments and services are funded. The app is part of larger project in partnership with the Austin Monitor and funded by a grant from the Mozilla Gigabit Fund to teach high schoolers about civic priorities.
Award Announcement: https://www.open-austin.org/blog/2017/02/08/budget-party-mozilla-gigabit-grant-announcement
Live URL: https://austinbudget.party

Fake the News is a web literacy project designed to help educators and teens evaluate online news for credibility and trust to strengthen their communities’ resilience to fake news and misinformation.
More info: https://fakenews.open-austin.org/
Not yet live URL: missionfake.news

Harris County Bookings is a scrapper that runs daily to aggregate data from the Harris County Justice Information and Management System reports. This information is intended for researchers and non-profits looking to do studies on policing in Harris County.
The data exists as searchable CSV via the Github repository.
https://github.com/open-austin/harris-county-bookings

lobbying-in-austin was an experiment with data visualization for the city's lobbyists registration database. It went dormant because we failed to find an interesting narrative in the limited data available. I think it's still in good enough shape that any future project with the lobbyist datasets should reuse this work rather than starting over.
The main product of the experiment was a chart (with no navigation) showing how many lobbyists were employed by various clients at any given time:
https://www.open-austin.org/lobbying-in-austin/

lobbying-in-austin was a success! It turned into a great blog post prodiving analysis for the community. I would love if we could do more experiements like this that result in an article about the methodology and analysis. https://www.open-austin.org/blog/2016/06/12/finding-a-story-in-austins-lobbying-data

@patrickm02L has been MIA here and Slack for a few days. Any other way to contact him? Or someone wanna make a provisional one-liner until he responds?
And I PM'd @johnclary on Slack, waiting on him to respond too

@werdnanoslen thanks for staying on top of this.
Liberate Appraisal Data is an effort to open up the Travis County Appraisal District (TCAD) appraisal roll data. The annual appraisal roll consists of valuations of every parcel in the county, and includes details about the age and square footage of property improvements, the size and value of lots, jurisdictional taxing authorities, and much more.
We are asking TCAD to make the data available in an open, usable format. Key issues with the current data delivery process are as follows:

To obtain the appraisal roll data citizens must pay $80 per appraisal year. Electronic records are available dating back to 2007.

The data are delivered to citizens in an MS database. This is an arcane, proprietary format that requires special software to view.

TCAD's own documentation explicitly states that some of the data are not available at all (even with purchase), due to the limitations of the MS Access format.

Other entities (including the City of Austin) have managed to obtain copies of the data in a format other than MS Access, yet the TCAD records office insists that the data are exclusively available in the MS Access format.

Neighboring appraisal districts have managed to provide this data for free, in an open format. For example, WCAD: http://www.wcad.org/public-data/downloads?id=343

We (Open Austin) have proposed a few solutions:

Publish the appraisal roll data on our own website for the public to download.

TCAD could partner with the City of Austin to have the data published on the city’s open data portal. I am a City of Austin employee and would be happy to connect TCAD staff with the City’s Open Data Team.

We communicated these issues to TCAD Board of Directors chairperson Dick Lavine and the Chief Appraiser's executive assistant. Although Dick Lavine has expressed an interest in working with us, we have so far been unable to set up a follow-up meeting or get any response from the Chief Appraiser.
The obvious next step is to attend a TCAD board meeting, but unfortunately these take place monthly on a weekday in an inaccessible part of town. Another approach would be to raise money to buy all the data, reformat it, and host it.

@patrickm02L deleted the awesome-reports repo because he said it was only a placeholder with no code, and he wasn't excited about it anymore.
So, now that the info's all here, i'll start making updates...

To get this on https://www.open-austin.org/projects/, we'll need the following info:

type:         ????
categories:   [ ????, ???? ]
thumb:        ????
screenshot:   ????
featured:     ????

@werdnanoslen can you expand on 'type' and 'categories'? what are you looking for there?

Heya, sorry this was actually more of a note to self, should have mentioned that. I'm not 100% sure either. It's the template our projects page seems to use.

Added:

[x] budget-party
[ ] liberate-appraisal-data
[ ] lobbying-in-austin
[ ] harris-county-bookings
[ ] fake-the-news


add language hash tag in the tweet

@musically-ut Hello! Had my first few PRs because of the awesome bot! Thanks for your work 💯
Didn't wanted to hijack the issue @hiimbex mentioned in #4 So, created a new one.
While we are at #4, is it possible to add the language hash tag as well ?
We need to query the primary 2/3 languages on the repo and add it as hash tag to tweet body.

Github provides the api to query language of the repo.
https://developer.github.com/v3/repos/#list-languages
I think I can pickup and work on it. Let me know if that's ok :)

I'm very happy to know that this bot got you interested in OSS. 🎉
I remember the language tag being slightly tricker to get right while caching values and respecting the rate limits. I think it's a great feature even if it ends up crowding out the issue text a bit more. However, with Twitter providing context boxes with the tweets almost on all platforms, that shouldn't be a major issue.
If you want to, please go for it; I'll guide you along the way. :-)

Thanks for the assignment.
We can get the languages of the repo using
https://api.github.com/repos/musically-ut/first-timers-only-bot/languages
I already implemented that but the return value is a little verbose
{
  "Python": 7227,
  "Shell": 119
}

To make sure we are in the text count limit we need to improve the language hash tags.
#js for Javascript and #py for Python so on...
Here is the approach am thinking of...
I will get all the languages supported by github and added them to a json.
We need to create the standard hash tag for each of the language, which is not humanely possible for me to edit for all the languages. Right now I will added for a couple of the most popular ones. Rest I just copied the name itself. Slowly we can keep improving it...
Q1: So, once I get python as the primary language(the language with high byte count given by github) I will query the tag for it py and add it to the list of hash tags. Is that OK ?
Q2: Do you think we should add two primary languages or just stick to one ?
Q3: Do you think we need #github tag ?
Let me know if you have any better suggestion.
Feel free to correct me and point me in the right direction.

Getting all languages in a JSON file sounds good.
It doesn't have to be exhaustive either: we don't need to include very arcane abbreviations in the JSON; in case the language is not very commonly known, we can just not add a language tag.
I'd just stick to one tag: the only cases this may be misleading is if build-files are included in the repository (i.e. mostly for languages which compile down to Javascript). I think even tagging the target language in that case will be alright.
As for the #github tag: we can get rid of it; I don't think I'll be adding support for BitBucket anytime soon. :)

@musically-ut, @cg-cnu
Is this issue still open? And open for contribution?

@musically-ut, @cg-cnu
Is this issue still open? And open for contribution?

@kgashok yes! Would you like to work on it?

@kgashok yes! Would you like to work on it?


fix absolute path

to fix CI.
If the model is different in ferrum, something a bit more clever might need to be used

I cannot merge this...

what about now ?

Still not able to merge :/

@NahuelVilla : you might still need to accept the invite: https://github.com/Gepetto/aig/invitations

Yes, sorry,


AzureNamingTool: Globally optional in version 2.5.0 does not apply when generating multiple resource type names

After migrating optional components to new globally optional type in version 2.5.0 we have run into an issue when generating multiple resource type names at once. The component is not optional when generating multiple resource type names, but is optional when generating single resource type name.
First image showing that the component is optional when generating single resource type name:

As you can see it is optional and we can click generate whitout selecting a value for the component.
Second image showing that the component is not optional when generating multiple resource type names:

As you can see it is not optional and we cant click generate without selecting a value for the component.
Third image showing that we can click generate if a value is set in the component:

Hope to see this fixed in next version.

Hi @erlendjd,
Thank you for your feedback. This is a current limitation of the tool due to the way it handles optional components. We have a backlog item to update this, and we will address it in a future. release.
Thank you!
-Bryan

Great, thanks for the fast response!


Complex object lists not working

@Getter @Setter
@EqualsAndHashCode(of="id", callSuper=false)
public class Car {
	private Long id;
	private String description;
}
public class Cars {
	private List<Car> cars;
}
Validation error of type SubSelectionRequired: Sub selection required for type null of field cars @ 'Cars/cars

Does Cars really have no public fields/properies? That's unlikely to work.
What query are you trying to execute?
And how do you setup the generator?
Btw, object lists are most definitely working as that's a very basic case. So the problem is either with the configuration somewhere or with Lombok. SPQR is generally not very Lombok-friendly as it doesn't look at private fields/methods, so if you need any annotations you'll have to work around that fact. But in this example there's no annotations, so it should work.

`I will do the test removing lombok, but my scenario is this:
@Getter @Setter
@EqualsAndHashCode(of="id", callSuper=false)
public class Car {
private Long id;
private String description;
}
@Getter @Setter
public class Dealership {
private List cars;
}
{
dealership(id:1) {
cars{
id,
description
}
}
}
GraphQL.newGraphQL(new GraphQLSchemaGenerator()
.withTypeTransformer(new DefaultTypeTransformer(true, true))
.withBasePackages(ApiModel.class.getPackage().getName())
.withOperationBuilder(new DefaultOperationBuilder(DefaultOperationBuilder.TypeInference.LIMITED))
.withOperationsFromSingleton(graphQLService).generate())
.build();
@GraphQLQuery(name = "dealership")
public Dealership cars(@GraphQLArgument(name = "id") Long id) {
return dealershipService.findById(id);
}
"message": "Validation error of type SubSelectionRequired: Sub selection required for type null of field cars @ 'dealership/regimesDoPcarsroduto'",`

Any news on this?

I discovered the problem, when I was mounting the request I was not sending the complex object fields. thanks!!


Trusted Types compatibility

https://web.dev/trusted-types/ disallows string assignments to innerHTML. This change makes the code compatible by converting the string to TrustedHTML if the browser supports Trusted Types.
Checklist

[X] Added markup tests, or they don't apply here because the change is not markup related.
[X] Updated the changelog at CHANGES.md

(typeof trustedTypes != 'undefined')

Is this truly the best/only way to check for compatibility?

Ref: https://w3c.github.io/webappsec-trusted-types/dist/spec/
This seems very, very new.  Is this currently only a Chrome thing? I'm not sure we should add features that only a single browser supports.   I don't think a Chrome only world is a good world and I'm hesitant to do things that might encourage [or hasten] that... are there indications that other browsers engines also plan to adopt this?
CC @highlightjs/core

From Draft spec:

Note: Trusted Type objects wrap values that are explicitly trusted by the author. As such, creating a Trusted Type object instance becomes a de facto injection sink, and hence code that creates a Trusted Type instances is security-critical.

Also if we're considering  ratcheting up the security here it's worth discussing how this relates to plugins.  We're very safe with our own HTML generation, but a plugin can VERY easily replace result.value with any value, such that we could no longer make any guarantees about... so what is the correct behavior in that case?
I assume the plugin would itself need to certify it's HTML with it's own Trust Type policy... in which case I think this is the wrong layer to add this - it would truly belong in perhaps html_renderer.js, etc... and this PR would then also require documentation updates explaining this, etc...

No Firefox or Safari support is a hard pass for me. Once there's greater browser adoption, then I'd be open to this. I don't see the benefit of hardening XSS protection on a single browser and leaving the rest to need bulky polyfills.

Is this truly the best/only way to check for compatibility?

Looks like that's whey offer as a tiny polyfill but they do have a complete (but heavier) polyfill.

While Chromium based browsers (Chrome, Edge, Opera) are the only ones currently supporting Trusted Types, it's still a valid defense against DOM XSS in these browsers. My code is written in a way that it doesn't require a specific browser. If the browser doesn't support Trusted Types then the code will work the same as before - a string will be simply assigned to innerHTML. There's no need for using a polyfill here.
You are right that this code doesn't improve the security of Highlight.js. The main purpose is to unblock projects using Highlight.js wishing to adopt Trusted Types. Until all dependencies are compatible with TT, a project can't enforce them. It means that a future code in the project might introduce a vulnerability because TT couldn't be enforced.
You are also right that adding the createHTML call to HTMLRenderer would be better because the code there is very simple and almost provably safe (except not escaping className in span()). I've considered that option but decided against that because calling it here is less intrusive. If someone is expecting that HTMLRenderer.value() would return a string then returning TrustedHTML from it would break that code. TrustedHTML stringifies well but it doesn't support calling string methods like trim(). However, if you are willing to take this more complicated path then I'd be happy to move the code there.
For projects depending on Highlight.js wishing to adopt TT (which currently happens in multiple projects at least in Google) there are these options:

Do not adopt TT. (doesn't improve security posture of the project while accepting that there still might be a risk in Highlight.js or its plugins)
Patch Highlight.js. (complicating updates)
Remove the dependency on Highlight.js.

Accepting this PR seems like the best option - it adds only a tiny amount of code, it's backwards compatible and it works in all browsers.

Is this truly the best/only way to check for compatibility?

Do you have something specific in mind? I can e.g. add && trustedTypes.createPolicy.

If the browser doesn't support Trusted Types then the code will work the same as before

Unless the spec changes, which is quite possible (as the draft itself says).

There's no need for using a polyfill here.

There is technically (IMHO), only it's a very tiny one.  But my issue here isn't with the size of the change.

except not escaping className in span()

Thanks for pointing this out.  I may make a separate issue to track this but as all grammars are themselves fully executable JS code we already sort of consider them a "fully trusted" context - if someone does not fully trust a 3rd party grammar they should not use it - period.  Perhaps Trusted Types might allow better granularity here in the future though... (I hadn't read the whole spec).

I've considered that option but decided against that ... If someone is expecting that HTMLRenderer.value() would return a string then returning TrustedHTML from it would break that code.

This is a private/internal API so I don't think this is an issue.   But I'd also be fine adding a trustedHTML getter or something long term that simply returned the TrustedHTML wrapped value.

Thanks for the detailed response, but for now I say we wait for the spec to mature and to be implemented by additional browser engines.  We do not generally rush to add bleeding edge features supported by a single browser - even if the change appears minimal. As mentioned above I also worry a draft spec is a "moving target"... having Highlight.js potentially break if things should change out from under us does not seem like much fun.
I'd suggest 2. Patch Highlight.js if this is an absolute necessity for Google.  Such a tiny patch should be easy to manage and maintain until the spec matures and perhaps this lands in the core library.

You also might consider a plugin that hooked after:highlightElement though I'm not sure if that would be helpful in your use case or not... we'd still call element.innerHTML...  so if that is going to raise of blow up then that might be a problem... if it would instead just silently log (or do nothing) then you could set the innerHTML using TrustedTypes from within the after callback - preventing any need to maintain a patched library.

There is technically (IMHO), only it's a very tiny one.

This code works as is, there's really no need for a polyfill anywhere.

Thanks Josh! That's fair, we'll look into internal patches or the after:highlightElement hook.
To respond to your concern though regarding the API volatility, it's of course probable that the API will evolve and change (even HTML is now a living standard), though it's highly unlikely that it would in a backwards-incompatible way. To protect against that, every integration feature tests the API before using it (in this particular patch, we probably could also test for trustedTypes.createPolicy existence or wrap the API usage in try..catch, falling back to regular innerHTML assignment to be extra sure).
Backwards compatibility is of a huge concern to us (and I'm speaking here as TT editor), for principled, but also practical reasons. Quite large existing integrations and applications use TT API already.

Hi Josh, thank you for taking the time for reviewing this request.
As koto said, we can definitely patch internally and are not blocked on this change. But we'd like to address this issue for all highlight.js users so they're not running into the same issues as we did.
I'd also love to see Trusted Types be supported natively by more browser engines as I strongly believe it's the best tool against DOM-based XSS we currently have.
Even though Trusted Types is right now only natively supported by Chromium based browsers it is already broadly used (see https://mitigation.supply/#trusted-types, a prominent example is VSCode) and supported in popular frameworks like React and Angular (blogpost about using Trusted Types in SPAs: https://auth0.com/blog/securing-spa-with-trusted-types/). Therefore only non-breaking API changes should be expected.
Developers interested in Trusted Types can also unlock many of the benefits by just using the polyfill, runtime enforcement by the browser is just one of the Trusted Types benefits.
The downside of this change is rather small and the risk of breakage in the unlikely case of an API change can be fully mitigated by testing for trustedTypes.createPolicy existence or wrap the API usage in a try..catch as @koto wrote above.
But the upside is really substantial as it would unblock also users of highlight.js from adopting Trusted Types and would help them to get rid of DOM-based XSS.


Optional configuration for HTTP request parameters - max request length, max header size and chunk size

It is found that LittleProxy is hard coding header size to 16KB which might be a limiting factor in few cases. We have seen in few Kerberos based environments that the token, which is sent as HTTP header can grow bigger due to large number of active directory group memberships and LittleProxy fails to serve such requests with below exception.
Reading: DefaultHttpResponse(decodeResult: failure(io.netty.handler.codec.TooLongFrameException: HTTP header is larger than 16384 bytes.))
Keeping the current standard values as default, this PR adds the capability to accept the configuration (also, max request length and chunk size) via properties file.

This looks good to me. The fields in DefaultHttpProxyServer should be final, but we can put that in a subsequent minor PR.
Thanks @techpavan!


Instruction says Privileged Access where it should say Privileged Identity Management.

[Enter feedback here]
Under "Create the security group in Microsoft Entra ID for elevated permissions", step 5 is:
Go back into the group you've just created, and select Privileged Access > Enable Privileged Access.
This is incorrect.  The line should say:
Go back into the group you've just created, and select Privileged Identity Management> Enable PIM.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8c1b40f7-129f-5fb9-cdde-42e35a8819f7
Version Independent ID: 8c1b40f7-129f-5fb9-cdde-42e35a8819f7
Content: Use Azure Privileged Identity Management (PIM) in Microsoft Defender for Office 365 to limit admin access to cyber security tools.
Content Source: microsoft-365/security/office-365-security/pim-in-mdo-configure.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@RSKadish Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/13178
Once the author approves. the changes will be live.
Thanks
Sri


[backport] Move should_use_cudnn and should_use_cudnn_tensor_core to chainer.cuda

Backport of #3851

Note: Code related to Tensor Core is removed from original PR.

Please remove original code from chainer/__init__.py.

Thanks for pointing that out, fixed.

LGTM!


Name Change: Grid -> PyGrid

Thoughts? Seems like this is a better name given that there's a good chance we'll have multiple grid libs.

I always wondered why it isn't pygrid or opengrid in the first place.

As one of the authors of grid.js - I'd love to see this.  😉

I definitely support it!

I support this game change, but I don't think this should be done before October. We have a lot of links (some important ones) that will break if we rename the repo.

@mari-linhares which links are you referring to specifically?  If you're worried about people's git links being broken, Github automatically forwards traffic from the old URL: https://help.github.com/en/articles/renaming-a-repository

Given @cereallarceny 's input to Marianne's concerns, I have updated the name.


ci: automatically run CI tests when PR open

hi @phuslu please let me know if we also want to apply this to memory test or gcscan test.

thanks! memory & gcscan is nice to have~


change simple slideAdminHash with sha256

Standards checklist:

[ ] The PR title is descriptive.
[ ] The PR doesn't replicate another PR which is already open.
[ ] The PR has self-explained commits history.

[ ] The code is mine or it's from somewhere with an Apache-2.0 compatible license.
[ ] The code is efficient, to the best of my ability, and does not waste computer resources.
[ ] The code is stable and I have tested it myself, to the best of my abilities.
[ ] If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

[...]

Other comments:
...

@andyoknen is brangr your git profile? Please, consider using the andyoknen email to link your contribution to your profile. It is better not only for the team and for your GitHub profile stats. Commits made from not associated profile are not affect your stats.


Update downloaded version to latest stable (0.7.0)

0.5.2 is getting a bit old now. This bumps the default version to the currently stable one.

Thanks!


Bulk hashing code path for 64KB+ strings

Verneuil likes to fingerprint 64KB chunks. Let's start by accelerating hashing of 64KB inputs. The code's a bit simpler, but some of the ideas should port over.

64 KB hashes went from 10100 cycles (41939cf6a399bd4ad17a8ba8ea6d780b5fc362c4 at -O3) to 8820 (78912ddf2798433b42ddf1a9d2778adaa4a98007 at -O2) cycles on a EPYC 7713.

[(65536,
  {'mean': Result(actual_value=-1328.918918918919, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.989763995, judgement=1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=-1620.0, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99_sa': Result(actual_value=-1620.0, judgement=-1, m=20000, n=20000, num_trials=2750000)})]

If we also enable the AVX2/VPCLMULQDQ code path in 78912ddf2798433b42ddf1a9d2778adaa4a98007, we find 10100 cycles to 5740 cycles.

[(65536,
  {'mean': Result(actual_value=-4382.783783783784, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.99935073, judgement=1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=-4380.0, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99_sa': Result(actual_value=-4380.0, judgement=-1, m=20000, n=20000, num_trials=2750000)})]

64 KB fingerprints went from 18400 cycles (41939cf6a399bd4ad17a8ba8ea6d780b5fc362c4 at -O3) to 13200 cycles (78912ddf2798433b42ddf1a9d2778adaa4a98007 at -O2) cycles on an EPYC 7713.

[(65536,
  {'mean': Result(actual_value=-5315.039039039039, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.99820331, judgement=1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=-5300.0, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99_sa': Result(actual_value=-5300.0, judgement=-1, m=20000, n=20000, num_trials=2750000)})]

If we also enable the AVX2/VPCLMULQDQ code path in 78912ddf2798433b42ddf1a9d2778adaa4a98007, we find 18420 cycles to 9080 cycles.

[(65536,
  {'mean': Result(actual_value=-9687.184184184183, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'lte': Result(actual_value=0.99900249, judgement=1, m=20000, n=20000, num_trials=2750000),
   'q99': Result(actual_value=-10620.0, judgement=-1, m=20000, n=20000, num_trials=2750000),
   'q99_sa': Result(actual_value=-10620.0, judgement=-1, m=20000, n=20000, num_trials=2750000)})]

With boost enabled, 64-bit UMASH throughput is 40.9 GB/s, and 128-bit 27.4 GB/s. xxh3 achieves 48.6 GB/s (in 64 or 128 bit mode), and halftime hash 256 45.3 GB/s.
The 64-bit hash is in pretty good company, and the 128-bit fingerprint, does show it can be more efficient than computing two 64-bit UMASHes in parallel: the fingerprint achieves 67% of the base UMASH throughput, i.e., 33% more than what we'd expect from computing two independent hashes in parallel.


Order of "(Default)" in Windows installer

In the Windows installer it seems strange the options for key remapping and mouse behavior is not in the same order.
"(Default)" is first in key mapping but last in mouse behavior.

It is just based on installer.exe (dosinst.c).

This is no more applicable in v8.1.0616. Closing.