C# return types are not highlighted in method/function declaration

when you have a method that returns a type it is not highlighted.
for example "public Customer GetCustomer()"
the word "Customer" which comes right before the Method name should be highlighted Green like any Type that is not a keyword.

Can you provider a fuller examples and context showing other types in other locations and how they are colored currently?  A screen capture of a simple example would be great.  Showing both types elsewhere and this particular failing case.
Or a https://jsfiddle.net, etc.

Ping.

Closing due to inactivity.  If this is still an issue please response and we an re-open.


Internet Explorer Support

I'm currently working on a project that requires us to support IE. I want to use this library for the modals but I didn't find anything about the browser support.
Does this library support IE9+?

@clobo-nativapps There is an issue with some releases of react-modal due to some missing transforms (babel).
You can follow #465 for more information.

I'm tagging this as duplicated so we can discuss this on #465.
Thank you.


Code review

this does not add any functionality
auto-reindent of the code
change some syntax to make the auto-indent work
remove some escaping by switching quotes
put quotes around variables (if [[ $x == "something" ]] -> "$x")
other assorted rewrites

Thank you for cleaning up the code! It seems good :)
I will do final QA and the merge this into master. Please give me a time a little bit.


Fails to reindex documents that have parents

If you set up a parent-child relationship between documents, the child documents fail to be reindexed.
PUT /company
{
"mappings": {
"branch": {},
"employee": {
"_parent": {
"type": "branch"
}
}
}
}
In this case, any employee documents will not be reindexed.

see https://github.com/garbin/elasticsearch-reindex/pull/3 , I think you should pass -p ParentField instead.


refactor: modify VerifyUpgradeAndUpdateState to set upgraded client and consensus state

Description
Removes the client and consensus state from the return values in VerifyUpgradeAndUpdateState client state interface function. Updates light client implementations to set client and consensus state in client store.
closes: #286

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #598 (2122cc9) into main (33e7a4b) will increase coverage by 0.00%.
The diff coverage is 58.62%.

@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   78.90%   78.90%
=======================================
  Files         120      120
  Lines        9676     9677    +1
=======================================
+ Hits         7635     7636    +1
  Misses       1655     1655
  Partials      386      386

Impacted Files
Coverage Δ

modules/core/02-client/legacy/v100/solomachine.go
6.55% <0.00%> (ø)

...light-clients/06-solomachine/types/client_state.go
62.35% <0.00%> (ø)

...s/light-clients/09-localhost/types/client_state.go
91.94% <0.00%> (ø)

...dules/light-clients/07-tendermint/types/upgrade.go
74.15% <56.25%> (+0.29%)
:arrow_up:

modules/core/02-client/keeper/client.go
98.34% <100.00%> (-0.04%)
:arrow_down:

modules/light-clients/07-tendermint/types/store.go
79.18% <100.00%> (+0.43%)
:arrow_up:


Keep the OrbStack menu bar icon (greyed out) after OrbStack is quit

Is your feature request related to a problem? Please describe.
I want to be able to start OrbStack from the menu bar, the same way I can do so after bootup (when OrbStack Start at login is enabled).
Describe the solution you'd like
Therefore, I would like the OrbStack menu bar icon to keep running in the menu bar (greyed out), after OrbStack is quit.
Additional context
I usually quit OrbStack when not using containers to save memory. Being able to relaunch OrbStack from the menu bar would be more comfortable. It would also be a benefit in terms of UX consistency with the Start at login behaviour.

hi! if you run orbctl stop in terminal, OrbStack will stop but the icon will remain in the menubar

So maybe a "Stop" button can be added to the OrbStack menu bar menu right above the "Quit" buttom?


Wrong quality is selected

Possibly caused by: "server did not return a valid playlist", meaning the stream haven't started yet.
Found: 32

It seems that some streams start without 3Mbps available. Increase default setting waitForQualityMaxTries to 20 ~= 5 minutes.


Rename labels to increase user-friendliness

Describe the improvement
Some labels could be renamed to increase user-friendliness or avoid confusion (e.g. "Send for review" instead of "Publish to Biblio").
Once it is possible to configure this on the front-end, assess which labels need to be changed and suggest alternative names in collaboration with biblio reviewers team.

[ ] #152

I'm going to close this, there are concrete actionable issues now


Interface comments are ommitted in implementation class

TypeScript Version: 1.8.10
Have an interface in one file
interface IFooController {
    /**
     * random comment
     * @returns {string} Returns a string
     */
    test(): string;
}

export default IFooController;

In another file have a class that implements that interface

import IFooController from "../Interfaces/Controllers/IFooController";

export default class FooController implements IFooController {
    test(){

    }
}

Expected behavior:
See the comments of the interface when hover over the class method
Actual behavior:
See nothing.
This doesn't happen with functions and class comments.
This only happens when interface is imported.
Using Microsoft Visual Studio Professional 2015
Version 14.0.25123.00 Update 2

I don't know if the complexity is warranted here, but I'll leave this open for input.


Skip setting proxy on subscription module, if satellite is part of no_proxy

Description of changes:
Ansible Redhat subscription module does not support a no_proxy field. If the user wants to use proxy, but wants to avoid using proxy to access the Redhat Satellite for registration, they can do so by providing the satellite hostname on the provider configuration json using the no_proxy field.
This change, checks if the redhat satellite hostname matches with one of the no_proxy endpoints and if so, skips setting proxy on the subscription module.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherrypick release-0.18


Feature request: Quick Settings Tile 7.0+

Please consider adding a quick settings tile to activate/deactivate the service. This would also allow for a "hide icon from app drawer" option since the service could be activated without it.

Thanks for the suggestion. Will be looking at a quick settings option for a future version in addition to a number of other changes that I've been slowly working on. I'm unsure on implementing hiding from app drawer as this could be something that is better left to the user to customize with a launcher app. The default app icon launch action will also probably be changing to open a settings UI with other options for starting and stopping the service.


Switching to support React 14 on master.

@byronmwong allow react .13 and .14

@byronmwong ok so little twist now we are gonna support only react 14 in master and support react 13 in a new branch.

looks good! thanks


Chase_Auto Buy/Sell issue

Hello. For starters, this is awesome. I really appreciate the work you have done here. You have already saved me a bunch of time with the limited use I have gotten out of it.
The only issue I have had that I couldn't figure out was with Chase_Auto.side.
For some reason the line:
let accounts = ${accounts}; return accounts[${index}].slice(accounts[${index}].indexOf(${target}) + 1);
is returning:
Failed: Cannot read properties of undefined (reading 'slice')
I have tried changing the format of my account numbers in the .env with no luck. Think you could help me figure this out?
Are there any future revisions to update the chase side to work with the new version of the trading experience?
Thanks!
EDITED: I was able to figure out my mistake. I was accidentally reading the array for CHASE_AI improperly. Sorry about that.

Hello CUBrobocop,
I'm glad you were able to figure out the issue.
From what I can tell, switching to the new trading experience on Chase would slow down the automation and leave it vulnerable to errors more often compared to using the classical version. However, I might add an option to support it for those who prefer the new trading experience sometime in the future.
With the problem resolved, I will close the issue with this comment. Feel free to contact me or open another if you run into any other issues.
Thanks for your support!


Emit LUIS Trace Info from the LUIS Recognizer

@cleemullins are we good to go? I made the changes you requested, would like to get this checked in today if possible


Document how to set service.environment

Should be as easy as setting the env-var before initializing the agent.

added in release v0.5.0 : https://github.com/elastic/apm-agent-ios/blob/main/docs/configuration.asciidoc#resource-attribute-injection


FLOE-435: Add link to chart authoring tool

We talked about not actually merging this pull request until the chart authoring tool have been updated a bit, but it could be reviewed in the meantime.

Very minor: perhaps add the word "audio" somewhere in the updated text. Just helps with visibility on search engines.


Revert "Bump golang.org/x/net from 0.15.0 to 0.17.0"

Reverts transcom/mymove#11485
https://ustcdp3.slack.com/archives/C047F0N6LDV/p1699461704982549?thread_ts=1699391944.221969&cid=C047F0N6LDV

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 2968bdef2a6d98dfffa1b1d6166da31ae9c41640


⚠ GG2RDF Service has degraded performance

In 8df9b09, GG2RDF Service (https://gg2rdf.ld.plazi.org/status) experienced degraded performance:

HTTP code: 200
Response time: 997 ms

Resolved: GG2RDF Service performance has improved in f720050 after 1 hour.


Supported OS?

In the section "Limitations and Constraints", only WIN2016 and WIN2012R2 are listed as supported OS for accelerated networking.  Can you confirm whether WIN2019 is also supported now?
The reason why I ask is that when I provision a Win2019 Azure VM in the D_v2 range with 2 or more CPU, I see that the Accelerated Networking option is enabled by default.  If WIN2019 is suported, can we please add it to the list of supported OS?
Thanks.. JD

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e4be8e45-460a-fab4-519b-32d83382005c
Version Independent ID: 36a002a6-5813-da00-0a57-068eeaf491cf
Content: Create an Azure virtual machine with Accelerated Networking
Content Source: articles/virtual-network/create-vm-accelerated-networking-powershell.md
Service: virtual-network
GitHub Login: @gsilva5
Microsoft Alias: gsilva

@julesman101, Thanks for your feedback. We are looking into this query and will update you as soon as possible.

@julesman101 , Generally Accelerated Networking is supported on most general purpose and compute-optimized instance sizes with 2 or more vCPUs. These supported series are D/DSv2 and F/Fs.
I have checked with Win2019 and it looks like it supports it with the above-mentioned CPU configuration. I have updated the document accordingly and it will take some time to get reflected.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Many thanks for the very prompt response. Much appreciated!


Cannot read property 'getDOMNode' of undefined [...]/app/src/text-editor-component.js

Uncaught TypeError: Cannot read property 'getDOMNode' of undefined /Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:1486
Copying something off a file using CMD-c (with another file open), not letting go of CMD before pressing CMD-w, fires this error.
http://cl.ly/363E3c3d1o2F
I'm on Mac OS X, 10.9.5, using Atom 0.136.0.

Closing as it is likely fixed. If you can still reproduce, please reopen.


deploy releases to ossrh

This looks good @ajayj89, thank you! I've removed the gpg.useagent property since the GPG plugin is already configured to use an agent. Let me know if I've missed anything.


Make tags clickable - add a search by tag feature

Problem

Currently, the tags for single media result are not clickable. It breaks users' expectations.
Description

The API provides the ability to search media by tags. We need to design for the Search by tag search page, and implement it.
Alternatives

Leave the tags not interactive.
Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

I'm going to close this as it is included in the #410 project.


Move to msgpack 2

I am trying to use the autobahn-cpp library in a Visual Studio 2015 project. After including both msgpack-c and autobahn-cpp, I get the following compiler error. I have already enabled the preprocessor flags MSGPACK_DISABLE_LEGACY_NIL and MSGPACK_DISABLE_LEGACY_CONVERT, as suggested in the msgpack-c readme for header-only mode. I'd appreciate any hints!
1>------ Build started: Project: X, Configuration: Debug x64 ------
1>  X.cpp
1>d:\autobahn-cpp\autobahn\wamp_call_options.ipp(66): error C2593: 'operator >>' is ambiguous
1>  d:\msgpack-c\include\msgpack\v2\adaptor\adaptor_base.hpp(48): note: could be 'const msgpack::v1::object &msgpack::v2::operator >><std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(const msgpack::v1::object &,T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v1\adaptor\adaptor_base.hpp(53): note: or       'const msgpack::v1::object &msgpack::v1::operator >><std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(const msgpack::v1::object &,T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\autobahn-cpp\autobahn\wamp_call_options.ipp(66): note: while trying to match the argument list '(const msgpack::v1::object, std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object
1>          ]
1>d:\autobahn-cpp\autobahn\wamp_call_options.ipp(111): error C2593: 'operator <<' is ambiguous
1>  d:\msgpack-c\include\msgpack\v1\object.hpp(611): note: could be 'void msgpack::v1::operator <<(msgpack::v1::object &,const msgpack_object &)' [found using argument-dependent lookup]
1>  d:\msgpack-c\include\msgpack\v1\object.hpp(721): note: or       'std::ostream &msgpack::v1::operator <<(std::ostream &,const msgpack::v1::object &)' [found using argument-dependent lookup]
1>  d:\msgpack-c\include\msgpack\v2\adaptor\adaptor_base.hpp(66): note: or       'void msgpack::v2::operator <<<std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object::with_zone &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v2\adaptor\adaptor_base.hpp(60): note: or       'void msgpack::v2::operator <<<std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v1\adaptor\adaptor_base.hpp(65): note: or       'void msgpack::v1::operator <<<std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v1\adaptor\adaptor_base.hpp(71): note: or       'void msgpack::v1::operator <<<std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object::with_zone &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object,
1>              T=std::unordered_map<std::string,msgpack::v1::object,std::hash<std::string>,std::equal_to<std::string>,std::allocator<std::pair<const std::string,msgpack::v1::object>>>
1>          ]
1>  d:\autobahn-cpp\autobahn\wamp_call_options.ipp(111): note: while trying to match the argument list '(msgpack::v1::object::with_zone, std::unordered_map<std::string,msgpack::v1::object,std::hash<_Kty>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=msgpack::v1::object
1>          ]
1>d:\autobahn-cpp\autobahn\wamp_subscribe_options.ipp(126): error C2593: 'operator <<' is ambiguous
1>  d:\msgpack-c\include\msgpack\v1\object.hpp(611): note: could be 'void msgpack::v1::operator <<(msgpack::v1::object &,const msgpack_object &)' [found using argument-dependent lookup]
1>  d:\msgpack-c\include\msgpack\v1\object.hpp(721): note: or       'std::ostream &msgpack::v1::operator <<(std::ostream &,const msgpack::v1::object &)' [found using argument-dependent lookup]
1>  d:\msgpack-c\include\msgpack\v2\adaptor\adaptor_base.hpp(66): note: or       'void msgpack::v2::operator <<<std::map<std::string,std::string,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object::with_zone &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=std::string,
1>              T=std::map<std::string,std::string,std::less<std::string>,std::allocator<std::pair<const std::string,std::string>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v2\adaptor\adaptor_base.hpp(60): note: or       'void msgpack::v2::operator <<<std::map<std::string,std::string,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=std::string,
1>              T=std::map<std::string,std::string,std::less<std::string>,std::allocator<std::pair<const std::string,std::string>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v1\adaptor\adaptor_base.hpp(65): note: or       'void msgpack::v1::operator <<<std::map<std::string,std::string,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=std::string,
1>              T=std::map<std::string,std::string,std::less<std::string>,std::allocator<std::pair<const std::string,std::string>>>
1>          ]
1>  d:\msgpack-c\include\msgpack\v1\adaptor\adaptor_base.hpp(71): note: or       'void msgpack::v1::operator <<<std::map<std::string,std::string,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>>(msgpack::v1::object::with_zone &,const T &)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=std::string,
1>              T=std::map<std::string,std::string,std::less<std::string>,std::allocator<std::pair<const std::string,std::string>>>
1>          ]
1>  d:\autobahn-cpp\autobahn\wamp_subscribe_options.ipp(126): note: while trying to match the argument list '(msgpack::v1::object::with_zone, std::map<std::string,std::string,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>)'
1>          with
1>          [
1>              _Kty=std::string,
1>              _Ty=std::string
1>          ]
1>d:\autobahn-cpp\autobahn\wamp_auth_utils.hpp(84): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
1>d:\autobahn-cpp\autobahn\wamp_auth_utils.hpp(116): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
1>d:\autobahn-cpp\autobahn\wamp_auth_utils.hpp(119): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
1>d:\autobahn-cpp\autobahn\wamp_auth_utils.hpp(164): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

A dirty solution is to define MSGPACK_DEFAULT_API_VERSION=1 in project settings.  That will effectively disable v2 namespace.  It will compile and run fine.

Thanks, that fixes compilation. However, I'm not able to set up a connection to a crossbar.io server (see also #2). Question: Has anyone ever managed to use Autobahn|Cpp with VS 2015?

It compiles with VS2015, runs, connects and authenticates with crossbar.io 0.12.1.  After fixing auth flow, I have not tried anything beyond authenticating and receiving a WELCOME.   If you are running crossbar.io on windows, disable unix socket listener from crossbar config.  I'll commit .sln and .vcxproj along with #46

Ah, nice! That's good news. If it can authenticate (eg https://github.com/crossbario/autobahn-cpp/blob/master/examples/wampcra.cpp), chances are high "it just works" (RPC and PubSub).
We should probably have a variant of above example that combines that with actually doing something. On the other hand: it's trivial to copy-paste code from the other examples.

Just noticed, part of my fix for wampcra got overwritten by most recent merge.  break missing for CHALLENGE again.
           case message_type::CHALLENGE:
               process_challenge(std::move(message));
 +             break;
           case message_type::AUTHENTICATE:

Thanks for your answers. I'm glad to hear that VS2015 appears to be supported now; however, I'm not able to get it running. I've done the following:

Create crossbar.io's hello example app and add an additional rawsocket transport on Port 8000: {  "type": "rawsocket",  "endpoint": {  	"type": "tcp",  	"port": 8000  } }
Use  this example from Autobahn|cpp:

̀int main(int argc, char** argv)
{

	try {
		const tcp::endpoint endpoint = tcp::endpoint(address::from_string("<IP_ADDRESS>"), 8000);

		boost::asio::io_service io;
		auto transport = make_shared<autobahn::wamp_tcp_transport>(io, endpoint);
		auto session = make_shared<autobahn::wamp_session>(io, true);
		transport->attach(static_pointer_cast<autobahn::wamp_transport_handler>(session));

		boost::future<void> connect_future;
		boost::future<void> start_future;
		boost::future<void> join_future;
		boost::future<void> call_future;
		boost::future<void> leave_future;
		boost::future<void> stop_future;

		connect_future = transport->connect().then([&](boost::future<void> connected) {
			try {
				connected.get();
			}
			catch (const exception& e) {
				cerr << e.what() << endl;
				io.stop();
				return;
			}
			cout << "transport connected" << endl;

			start_future = session->start().then([&](boost::future<void> started) {
				try {
					started.get();
				}
				catch (const exception& e) {
					cerr << e.what() << endl;
					io.stop();
					return;
				}

				cerr << "session started" << endl;

				join_future = session->join("realm1").then([&](boost::future<uint64_t> joined) {
					try {
						cerr << "joined realm: " << joined.get() << endl;
					}
					catch (const exception& e) {
						cerr << e.what() << endl;
						io.stop();
						return;
					}
[...]

However, when I try to run this program, it says
starting io service
stopped io service
async_read: The system cannot find the file specified.

When debugging with VS2015, a lot of exceptions of type boost::exception_detail::clone_impl<std::system_error> are thrown. In addition, the crossbar logs an autobahn.wamp.exception.TransportLost.

Just an addition: With autobahn-python, I can connect to the router (using websocket, not rawsocket which doesn't appear to be supported by the python package) and call the example "add2" method without problems.

Sorry for the spam, I figured out that the problem was msgpack-python not being installed on the crossbar side, while autobahn|cpp doesn't support json (does it?). After installing msgpack-python, everything works. To recap the steps necessary for others trying to get this running:

Make sure to install msgpack-python on the crossbar server, and add a rawsocket transport in .crossbar\config.json on a different port than the websocket transport, as described above.
Add the MSGPACK_DEFAULT_API_VERSION=1 preprocessor define to workaround the issue above (I still think this should be considered a bug, and using API version 2 is probably preferable?)
Be sure to connect to the correct port of the rawsocket transport.

I still think this should be considered a bug, and using API version 2 is probably preferable?

It works on gcc and clang, so if so, I'd consider it a VS bug. Ask MS to fix their compilers.

@supermihi

rgd (1): missing msgpack-python: I have expanded the examples README https://github.com/crossbario/autobahn-cpp/tree/master/examples#run - installing via pip install crossbar[all] will automatically install msgpack support as well. I also added links to other router implementations.
rgd (3): missing rawsocket TCP transport in the Crossbar.io examples config (to make it work on Windows): I have expanded the config so that it starts rawsocket transports both on UDS and TCP. @DZabavchik is working on a PR to fix the Windows issues, and that also includes a Crossbar.io config without UDS (which doesn't work on Windows).

Sorry l, forgot to mention msg pack on server side. I stepped on that rake also.
MSGPACK_DEFAULT_API_VERSION=1 is now defined in the headers for _WIN32
Regards,
Denis

On Feb 19, 2016, at 05:20, Michael Helmling<EMAIL_ADDRESS>wrote:
Sorry for the spam, I figured out that the problem was msgpack-python not being installed on the crossbar side, while autobahn|cpp doesn't support json (does it?). After installing msgpack-python, everything works. To recap the steps necessary for others trying to get this running:

Make sure to install msgpack-python on the crossbar server, and add a rawsocket transport in .crossbar\config.json on a different port than the websocket transport, as described above.
Add the MSGPACK_DEFAULT_API_VERSION=1 preprocessor define to workaround the issue above (I still think this should be considered a bug, and using API version 2 is probably preferable?)
Be sure to connect to the correct port of the rawsocket transport.

—
Reply to this email directly or view it on GitHub.

I think this should be addressed by @DZabavchik recent contributions now. Closing (though I didn't test it .. lack of Windows).

Thanks a lot! I'll test on monday if it works out-of-the-box with VS2015 now but from what you mention I'm pretty sure it should.

There is a pre-build step that will complain about setting missing boost, msgpack and OpenSSL directories or updating project settings, it is pretty much self explanatory.
Regards,
Denis

On Feb 20, 2016, at 06:11, Michael Helmling<EMAIL_ADDRESS>wrote:
Thanks a lot! I'll test on monday if it works out-of-the-box with VS2015 now but from what you mention I'm pretty sure it should.
—
Reply to this email directly or view it on GitHub.

Since we probably don't want to be stuck on v1, I have submitted a defect to msgpack-c for this issue. I was able to provide a simple program demonstrating the issue and isolate it to a specific commit:
https://github.com/msgpack/msgpack-c/issues/442
I think that we should re-open this issue for the time being and revert hardcoding to v1 once msgpack is patched.

@davidchappelle agreed. reopened and changed title

@CanNuhlar yes indeed, sounds good!


Unable to continue with update: CustomResourceDefinition "applications.argoproj.io" in namespace "" when upgrading to v4.32.1

While currently updating the version of eks blueprints from v4.15 to latest version of v4.32.1, I am receiving the following terraform error.
╷
│ Error: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "applications.argoproj.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "argo-cd"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "argocd"
│
│ with module.eks_blueprints_kubernetes_addons.module.argocd[0].module.helm_addon.helm_release.addon[0],
│ on .terraform/modules/eks_blueprints_kubernetes_addons/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
│ 1: resource "helm_release" "addon" {
│
╵
Operation failed: failed running terraform apply (exit 1)�
Current TF Version: 1.3.4
Current Blueprint Version: 4.15
Desired Blueprint Version: 4.32.1

Current Blueprint Version: 4.6.2
Desired Blueprint Version: 4.32.1

Any update on this? Bryant and some one in the team needs to look into this as its stopped our upgrades at this time.


Switch from isparta to babel-plugin-istanbul for coverage

This follows up #579 by replacing isparta with babel-plugin-istanbul. The advantage of this is that it reports coverage on the original pre-transpiled ES6 code without invisible ignore statements. The reports are fully accurate now which is awesome.

CI fails because:
/home/travis/build/mxstbr/react-boilerplate/internals/webpack/webpack.test.babel.js
  5:7  error  'path' is defined but never used  no-unused-vars

D'oh, should've spotted that. Thanks.

Coverage decreased (-6.5%) to 91.781% when pulling 1844cdc0713b9097782f3c8994855047e080ec03 on kane-c:istanbul-coverage into 236fb3f36c17563c265e69159a9d05d00871f98e on mxstbr:master.

Coverage decreased (-6.5%) to 91.781%

Any idea why that could be? What files are added to coverage that weren't there before/are we maybe not ignoring certain things we didn't before?

It looks like isparta counts more things as valid lines that the istanbul plugin doesn't, such as imports at the start of a file.
isparta doesn't seem to look quite as accurate for saga coverage either.
Comparison
Home page
isparta vs istanbul plugin
Notice how imports count in the former.
Home page sagas
isparta vs istanbul plugin
Notice isparta doesn't seem to pick up all the yields

Absolutely, this is awesome @kane-c, thanks so much! I'll take this and merge it with some test updates :+1:

Continued in #795!


tfrag improvements

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 564 (0.0%)  changed or added relevant lines in 8 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.4%) to 55.676%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

game/graphics/pipelines/opengl.cpp
0
1
0.0%

game/graphics/opengl_renderer/DirectRenderer.cpp
0
3
0.0%

game/graphics/opengl_renderer/Shader.cpp
0
3
0.0%

game/graphics/opengl_renderer/tfrag/program6_cpu.cpp
0
4
0.0%

game/graphics/texture/TexturePool.cpp
0
4
0.0%

game/graphics/opengl_renderer/tfrag/TFragment.cpp
0
14
0.0%

game/graphics/opengl_renderer/tfrag/BufferedRenderer.h
0
103
0.0%

game/graphics/opengl_renderer/tfrag/BufferedRenderer.cpp
0
432
0.0%

Files with Coverage Reduction
New Missed Lines
%

game/graphics/opengl_renderer/Shader.cpp
1
0%

game/graphics/opengl_renderer/tfrag/TFragment.cpp
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
40389

Relevant Lines:
72543

💛  - Coveralls


Update Intellij IDEA EAP to build 142.3230.1

Signed-off-by: Koichi Shiraishi<EMAIL_ADDRESS>

@vitorgalvao ping


Export of a non-defined predicate, empty_context/1, in module "ask"

https://github.com/terminusdb/terminus-server/blob/ccf9556f144ab2cc4f4adfd4e0dd600607cc6480/core/query/ask.pl#L8
Found while looking into a Logtalk compiler error:
!     Permission error: modify uses_object_predicate empty_context/1
!       in directive use_module/2
!       in file /Users/pmoura/terminus-server/core/query.pl at or above line 94

The error occurs due to the query module using:
:- use_module(query/ask).
:- use_module(query/woql_compile).

and both ask and woql_compile modules exporting an empty_context/1 predicate (only defined in the second module).

This should be fixed now.


Fix reset of layout when changing breakpoints.

It seemed like the grid would sometimes reset the layout for the breakpoint when changing browser width. This code somewhat resolves that problem.
It would probably be good to try to merge the existing coordinates and sizes that have already been set with new additions that do not yet exist in the layout for the new breakpoint.

Yes I can see I made mistake with this comparison layout to breakpoint and it's maxlength of layouts to breakpoint. Ill fix it on dev branch for now, beacause I'm preparing this branch to merge it on master. There are events fixes and some async synchronizations done with promises which actually are making reactivness back for vuex support.
If you can please try now dev branch for your issues. I'll prepare some changes and tomorrow will merge them all if evverything will be correctly done.

Thanks,
I've tested the dev branch and it seems to work really well. Some small adjustments needed to upgrade, but nothing major and I haven't found any bugs so far.
Looking pretty good!

Thank you for you support with that issue. You was right there was the problem with this breakpoint check as well. I have already merged my dev branch into master. Please check changelog for details.


keyring.backends.macOS.api.Error: (-25244, 'Unknown Error')

I get a Mac keychain error when running jwst_query.py out of the box with Python 3.8.11, astroquery=0.4.5,keyring=23.5.0 on an M1pro mac with MacOS Monterey 12.0.1. It works without an error in a different environment that has Python 3.6.7, astroquery='0.4.2.dev0' and some intel Rosetta thing. It says "python3 wants to use your confidential information stored in astroquery:mast.stsci.edu.token in your keychain. After that, I get an error
Here is the full traceback:

python jwst_query.py
Loading config file /Users/~/outside_progs/jwst_mast_query/jwst_mast_query/jwst_query.cfg
INSTRUMENT: nircam
Traceback (most recent call last):
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/backends/macOS/__init__.py", line 40, in set_password
    api.set_generic_password(self.keychain, service, username, password)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/backends/macOS/api.py", line 151, in set_generic_password
    delete_generic_password(name, service, username)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/backends/macOS/api.py", line 172, in delete_generic_password
    Error.raise_for_status(status)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/backends/macOS/api.py", line 114, in raise_for_status
    raise cls(status, "Unknown Error")
keyring.backends.macOS.api.Error: (-25244, 'Unknown Error')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "jwst_query.py", line 959, in <module>
    query.login(raiseErrorFlag=False)
  File "jwst_query.py", line 302, in login
    self.JwstObs.login(token=token, store_token=True)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/astroquery/query.py", line 150, in login
    bases[0].login(*args, **kwargs)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/astroquery/query.py", line 514, in login
    self._authenticated = self._login(*args, **kwargs)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/astroquery/mast/core.py", line 66, in _login
    return self._auth_obj.login(token, store_token, reenter_token)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/astroquery/mast/auth.py", line 76, in login
    keyring.set_password("astroquery:mast.stsci.edu.token", "masttoken", token)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/core.py", line 60, in set_password
    get_keyring().set_password(service_name, username, password)
  File "/Users/~/miniconda3/envs/m1py3p8/lib/python3.8/site-packages/keyring/backends/macOS/__init__.py", line 44, in set_password
    raise PasswordSetError("Can't store password on keychain: " "{}".format(e))
keyring.errors.PasswordSetError: Can't store password on keychain: (-25244, 'Unknown Error')

A way around it is to change this line in jwst_query.py
self.JwstObs.login(token=token, store_token=True)

to
self.JwstObs.login(token=token, store_token=False)

Good idea, I made a pull request to add a simple switch that sees if the processor is "arm". See:
https://github.com/spacetelescope/jwst_mast_query/pull/8
I don't think you need to store the token if you use the $MAST_API_TOKEN but maybe some users like to do it with a keyring which might be more secure.

I also got the keyring error this morning, when attempting to download the nrc-35 data using a linux machine. So maybe we should just set store_token to False all the time so that we don't have to find new logic to deal with each case?


Update output_processing.py

matched the possible input with the error code message displayed

Thanks @ky7yk I will pull this at the end of the semester to avoid breaking students' builds.


chore: Fix typo on command in readme

Command
python3.7 -m pip install -U checkovpython3.7 -m pip install -U checkov

is probably a typo with one command being pasted twice.

Good catch, @serkef !


Requesting a quick patch to 6.5.8 to fix fatal error if guzzle 6.x and 7.x exist concurrently

Guzzle version(s) affected: 6.5.8
PHP version: 8.1.2-1ubuntu2.14
cURL version: 7.81.0
Description
Aloha, we are requesting a quick patch release to legacy guzzle 6.5.8. If guzzle 6.x and 7.x are installed concurrently (e.g., many WordPress plugins use composer to include guzzle, but some plugins use 6.x and some use 7.x), a fatal error is triggered.
Example:
[02-May-2024 19:04:01 UTC] PHP Fatal error:  Cannot redeclare GuzzleHttp\describe_type() (previously declared in /var/www/html/wp-content/plugins/authorizer/vendor/guzzlehttp/guzzle/src/functions.php:16) in /var/www/html/wp-content/plugins/custom-facebook-feed-pro/vendor/guzzlehttp/guzzle/src/functions.php on line 41

More context from a WordPress plugin ticket: https://github.com/BoldGrid/w3-total-cache/issues/642
(I'm the developer of the plugin Authorizer, which includes guzzle 7.x, and reported the issue to the w3-total-cache plugin maintainers, who include guzzle 6.x).
How to reproduce
Run a php environment with guzzle 6.5.8 and guzzle 7.8.1 installed concurrently.
Possible Solution
Quick fix is to change the function_exists() check in functions_include.php to match the 7.x version. Here is the merged pull request from issue referenced above showing this change: https://github.com/BoldGrid/w3-total-cache/pull/643/files
Additional context
For reference, here is the 6.x and 7.x version of functions_include.php:

6.5.8: https://github.com/guzzle/guzzle/blob/6.5.8/src/functions_include.php
7.8.1: https://github.com/guzzle/guzzle/blob/7.8.1/src/functions_include.php

Thanks for considering this change! As a maintainer of a project that relies on guzzle 7.x I see these bug reports every so often, and normally I urge the other maintainers to upgrade to guzzle 7.x, but that's not always easy for everyone.

Thanks for getting in touch. Guzzle 6 has been out of bug-fix support for some time, and completely EOL since the end of October 2023, which is more than 6 months ago. For this reason, we won't be making such a change. The maintainer of the package can either edit the code they are bundling or upgrade to Guzzle 7. We intentionally made the upgrading path as easy as possible.

100% sympathize with your decision. Just want you to be aware that the decision does harm folks using Guzzle 7 (because there are other folks out there that refuse to upgrade for whatever reason). Only reason I opened the issue is because it's a one-line change that's already been tested and deployed in w3-total-cache (over 1 million active installs), so I thought the burden on you as maintainers was minimal. But I can understand it might open the flood gates for other backported fixes.
Carry on, thanks for maintaining an awesome library!


Adding Anna.Json library

I've added a couple extension methods that make it easier to send and receive JSON objects. I also updated the build and added a new nuspec file.
// Get T using UriArguements, QueryString and Json POST data
public static T GetAs<T>(this RequestContext ctx)
// Respond to request with a strong typed instance
public static void RespondAs<T>(this RequestContext requestContext, T tReturn, int statusCode = 200, IDictionary<string, string> headers = null)
// Subscribe handler that takes a strongly typed model
public static IDisposable SubscribeAslt;T>(this IObservable queryable, Action handler)
// Subscribe handler that takes strongly typed model and returns strongly typed model
public static IDisposable SubscribeAs<T,TReturn>(this IObservable queryable, Func<T,TReturn> handler)

This looks interesting, though it would be nice if those extensions would not be bound to a specific serializer. Json.NET is known to be the most popular, but not the fastest and not that good at dealing with the LoH.

I really like where this is going well done.
Not sure about the extension method names.. I'd prefer something more specific instead of req.GetAs<Person> maybe req.GetBodyAs<Person>  or something like that.
@kawazoe  Regarding the serializers, you will have to excuse me I haven't been doing .Net in a long time now, and I don't know the current state. Maybe using the one that comes with .net as default?

@jfromaniello Not necessarily. My point is that the choice should be left to the user. Anna should not impose a specific implementation to serialize the data. If the users wants to use the build in serializers, they should be able to. If they want to use Json.NET, FastJSON or maybe even the Daishi.Microservices.Component.Serialization library, they should also be able to.
Also, since you mentioned naming, considering that none of the method names directly implies json serialization, maybe the user might want to use them with other kinds of serializers like an XML serializer or a binary serializer.

Yes, I understand.. rough idea maybe we can have an interface like:
server.RegisterSerializer('json', Anna.JsonNetSerializer);
server.RegisterSerializer('xml', Anna.XmlSerializer);

and request.GetBody<Person>() uses the Content-Type header.
@kawazoe  Is this the kind of api you are looking for?

Yes, pretty much. Also, I really like the idea of using the Content-Type header.

So something that might have been over looked is that it's not just getting values from the body. It's also getting values from the QueryString and UriArguements. The Json.Net library offers a JObject that does all of the heavy lifting for you.
So while deserializing the body is relatively easy it becomes much harder if you want to mix in the other parts of the request. For what I'm doing I happen to really like the mix in especially when looking to have a strong type for GET where there is no body.
I do like the ideas you guys are throwing out but I actually don't have much time I can give towards this project.
Would it be possible to just implement the small change to the ArgumentsDynamic class the add the IEnumerable<KeyValuePair<string,string>> interface. That way it makes it easier for someone to do what I'm doing?

Well, I have a lot of time on my hands so I could implement this whole thing in a fork and submit a new pull request later this week (if that's ok with you @jfromaniello ?).
As for ArgumentDynamics, I don't see any problem in doing this now if we are to build on your idea. As a disclaimer, I am just a user and not a collaborator yet so that is to be taken with a grain of salt.

With that in mind may I suggest this PR gets closed and @kawazoe can take a stab at a more flexible implementation.
I can do a separate PR for the ArguementDynamics change or wait for the change from @kawazoe. It's up to you guys.
thanks
-Ian

Thank you guys for this discussion, I think it has been really useful!
so yes, lets way to @kawazoe
I am very thankfully how you guys are taking this to the next level,
Maybe we should put this repository under an github organisation?

That will definitely help to improve the visibility of the serialization utilities. Is it ok if I let you setup the repo for the Anna.Serialization.NewtonsoftJson? That way you'll be able to add it to your AppVeyor account and get nuget publishing running.


[8.x] Support dot notation in request query method

Hey,
This is a follow up to https://github.com/laravel/framework/issues/34021#issuecomment-749497945, a conversation to better understand if there was specific reason why dot notation for the request()->query method isn't supported?
Like mentioned in the issue I like to be explicit with where my data is coming from, and in this instance I'm unable to do so as the query method doesn't support dot notation. I'm currently using the input method but this doesn't accurately represent where I'm retrieving the data from.
Thanks for your time,
Sam

A little concerned about this being a breaking change with little user benefit.


Add My lycee FR

Official Website : https://lycee-coetlogon.ac-rennes.fr/
Mail studients : @lyceecoetlogon.fr

@Lhy-x I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host lyceecoetlogon.lyceecoetlogon.fr not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


[Snyk] Upgrade graphql from 15.4.0 to 15.5.0

Snyk has created this PR to upgrade graphql from 15.4.0 to 15.5.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2021-01-26.

Release notes

Package name: graphql

15.5.0 - 2021-01-26v15.5.0 (2021-01-26)
Bug Fix 🐞

#2852 introspectionFromSchema: enable 'specifiedByUrl' by default (@ IvanGoncharov)
#2855 introspection: Add missing support for deprecated input values (@ IvanGoncharov)
#2859 separateOperations: distinguish query and fragment names (@ IvanGoncharov)
#2876 Replace 'localeCompare' with function independent from locale (@ IvanGoncharov)
#2893 Fix handling of input objects with 'length' property (@ IvanGoncharov)

Docs 📝

#2849 README: add instructions on using experimental features (@ robrichard)

Polish 💅

 7 PRs were merged

#2847 Add tests for supporting Iterable collections across the lib (@ IvanGoncharov)
#2851 tests: update 'getIntrospectionQuery' tests to use custom matchers (@ IvanGoncharov)
#2858 separateOperations-test: refactor tests to look like snapshots (@ IvanGoncharov)
#2868 Extract types for normalized configs into named types (@ IvanGoncharov)
#2878 fix: type annotation cannot appear on a constructor declaration (@ saihaj)
#2879 fix: no need to mark param optional if default value is given (@ saihaj)
#2889 Simplify isAsyncIterable (@ IvanGoncharov)

Internal 🏠

 7 PRs were merged

#2831 build: add support for experimental releases (@ IvanGoncharov)
#2836 CI: test on node 15 (@ IvanGoncharov)
#2837 Flow: remove support for measuring Flow coverage (@ IvanGoncharov)
#2838 TS: exclude integration tests from root tsconfig.json (@ IvanGoncharov)
#2840 resources: use named groups in RegExp (@ IvanGoncharov)
#2886 Use correct flags for rmdir/mkdir functions (@ IvanGoncharov)
#2891 benchmark: fix temp dir creation (@ IvanGoncharov)

Dependency 📦

 5 PRs were merged

#2835 Update deps (@ IvanGoncharov)
#2844 Update deps (@ IvanGoncharov)
#2850 Update deps (@ IvanGoncharov)
#2884 Update deps (@ IvanGoncharov)
#2890 Update deps (@ IvanGoncharov)

Committers: 3

Ivan Goncharov(@ IvanGoncharov)
Rob Richard(@ robrichard)
Saihajpreet Singh(@ saihaj)

15.4.0 - 2020-10-26 Read more

    from graphql GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Pull Request Test Coverage Report for Build 573001828

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.143%

Totals

Change from base Build 538548209:
0.0%

Covered Lines:
236

Relevant Lines:
238

💛  - Coveralls


Remove testserver from block_writer.

A running cockroach node or cluster is required.
Added readme with instructions on how to run it against:

single dev node
insecure node or cluster
secure node or cluster

My plan is to do this for all examples. Specifically:

no more dependency on cockroach/server (makes binaries and compile
times huge)
identical flags (--db-url, although I may change this)
readme with short description and usage

circle-ci is failing on lack of tests. Awaiting https://github.com/cockroachdb/examples-go/pull/20

LGTM


json.Unmarshal not reporting on skipped fields

When un-marshalling the json decoder will skip fields if it does not match the name.
This can be problematic if you have a typo or have a new field in the json. Would like some feedback from the decode modules when this happens.
Originally described in #10134
See also on stack overflow
http://stackoverflow.com/questions/20509444/go-json-unmarshal-not-picking-up-a-single-attribute-value
http://stackoverflow.com/questions/20943963/json-unmarshal-doesnt-seem-to-pay-attention-to-struct-tags
Proposed solution is to add this line to report unmatched fields
d.saveError(fmt.Errorf("json: unmatched field %s for %v", key, v.Type()))
https://github.com/h4ck3rm1k3/google-go/commit/3befeea4f59745624af7ae18d1119ee175871df2#diff-4299c3082a8bb7e546723132c992fa4cR586

It's a feature of encoding/json that you can drop fields you're not
interested in, and that you can have more fields in the destination struct
than are in the source JSON object. Reporting unmatched fields as an error
breaks that feature, and it also breaks backward-compatibility (See
https://golang.org/doc/go1compat).
I could imagine writing a little tool to take some source JSON and a
destination struct (and vice versa) and check that they fit together, but
the mismatch certainly should not be an error condition for the package.
On 12 March 2015 at 12:42, James Michael DuPont<EMAIL_ADDRESS>wrote:

When un-marshalling the json decoder will skip fields if it does not match
the name.
This can be problematic if you have a typo or have a new field in the
json. Would like some feedback from the decode modules when this happens.
Originally described in #10134 https://github.com/golang/go/issues/10134
See also on stack overflow
http://stackoverflow.com/questions/20509444/go-json-unmarshal-not-picking-up-a-single-attribute-value
http://stackoverflow.com/questions/20943963/json-unmarshal-doesnt-seem-to-pay-attention-to-struct-tags
Proposed solution is to add this line to report unmatched fields
d.saveError(fmt.Errorf("json: unmatched field %s for %v", key, v.Type()))
h4ck3rm1k3/google-go@3befeea#diff-4299c3082a8bb7e546723132c992fa4cR586
https://github.com/h4ck3rm1k3/google-go/commit/3befeea4f59745624af7ae18d1119ee175871df2#diff-4299c3082a8bb7e546723132c992fa4cR586
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/10140.

It would be great to have an optional warning if possible, or some callback routine that could be installed. I found this patch greatly useful in developing. Otherwise I ended up re-implementing the decoding routine to find the problem.

There's nothing wrong with copying and pasting code. The hypothetical tool
could include the modified json package.
On 12 March 2015 at 12:54, James Michael DuPont<EMAIL_ADDRESS>wrote:

It would be great to have an optional warning if possible, or some
callback routine that could be installed. I found this patch greatly useful
in developing. Otherwise I ended up re-implementing the decoding routine to
find the problem.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/10140#issuecomment-78410167.

I found it quite difficult to copy and paste the code because I had to copy the entire module because of uncased functions. In any case this would be a simple feature to add and would not break any compatibility to have an optional warning or strict mode.

I agree that this would be a useful option.
This issue has been brought up before and is already tracked by #6901.

Closed as a dupe

@h4ck3rm1k3 I meant literally copy the encoding/json directory somewhere else.

yes that is what I had to do. My patch was based on that effort. @adg . thanks for the feedback


MVP

MVP
Summary
This pull request evolves the project from scratch to a basic implementation of Conway's Game of Life. It includes the game logic, visual rendering, and some utilities for validation and testing.
Changes
Game Logic Implementation

Added the Game struct to represent the state of the game.
Implemented the core game functions:

new: Initializes a new game with a random state.
get_index: Computes the index for a given cell position ((x,y) coordinates).
count_neighbors: Counts the number of live neighbors for a given cell.
update: Applies the rules of the game to update the grid.
draw: Renders the game state to the screen.

Game Initialization and Rendering:

Created a start function to handle game initialization and rendering using the macroquad library.
Added parameter validation in validate_start_parameters to ensure valid game settings.

Testing:

Added unit tests for core game functions, including:

Validating start parameters.
Verifying index calculations.
Testing neighbor counting and game state updates.

These include handling edge cases to ensure correct functionality.
Fixed Clippy warnings and applied cargo fmt for code consistency and to prevent future bugs.

I made several changes based on the comments you provided. These include:

Turning cells to a matrix (Vec<Vec<bool>>) like you proposed in order to get more understandability and to avoid unnecessary calculations.
Moving the game's main loop (start function) inside Game as a struct method. Refers to this comment.
Fixing the grid size issue.

Please check them out and if everything looks fine for you I would suggest merging this PR and start working on the next features.


feat: Store inout flags in FunctionType

Adds a new InputFlags enum that is paired up with each input in FunctionType.  See #311 for context.
Closes #313

the number of tuple unpackings is a bit unsatisfying, consider making a new dataclass holding type and flag

I added the dataclass as suggested. It makes constructing FunctionTypes more verbose, but iterating over the inputs nicer. Do you prefer it this way?


Improve the text at the top of the home page

Received the latest home page text from the product team.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ssimmonsDCFOITS sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


arch: arm: introduces sync barriers in _arch_irq_unlock()

The ARM Cortex-M 321 application note is stressing that
when enabling interrupts by executing CPSIE i(f), or by MSR
instructions (on PRIMASK, FAULTMASK, or BASEPRI registers),
there is a need for synchronization barrier instructions,
if there is a requirement for the effect of enabling
interrupts to be recongnized immediately. _arch_irq_unlock()
is invoked in several places, therefore, we add the
barriers to make the interrupt enabling function
applicable to all usage scenarios.
Signed-off-by: Ioannis Glaropoulos<EMAIL_ADDRESS>

This is a bit of an RFC, so I would like your input here. The synchronization barriers are certainly no-harm in terms of functional behavior. I wonder, though, if they add a slight overhead in _arch_irq_lock, and what the effect of this is in critical parts of the code.
@cvinayak @agross-linaro @pizi-nordic FYI.

Codecov Report

Merging #14116 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14116   +/-   ##
=======================================
  Coverage   52.61%   52.61%
=======================================
  Files         307      307
  Lines       45473    45473
  Branches    10530    10530
=======================================
  Hits        23925    23925
  Misses      16666    16666
  Partials     4882     4882

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b7fde...4038591. Read the comment docs.

@agross-linaro , could you take a quick look here?


[Packages] Added webpack and typescript as deps

Closes #94 and #93

@AleksandarDev please resolve conflicts.


assign and map create storage keys of long running arcs

manual copybara import: cl/305571407, merging.


master

· add "experimentalDecorators" in tsconfig.json;
· fix resolve from reject in ChatRoom;
· add a build-in AdminRoom usage template and static admin client page like Smartfox Server 2X does.

Hi @GAMEKON, thanks for your pull-request.
Having an administration panel would be nice as an external module, not on Colyseus' core. There's one external module currently available called colyseus-monitor.
Feel free to create your own!
Cheers


refactor: create common.execPath

Switch to using common.execPath instead of process.execPath directly and warn
electron users if we were unable to find the correct path to NodeJS.
This should be safe to merge into master because exec didn't work before anyway.
Fixes #633

@freitagbr PTAL

Blocked on #641. I'll update this after that's merged.

#641 is merged, so this can go through now.

Updates:

common.execPath ➡ common.config.execPath
Error message for invalid execPath is changed: Please manually set common.execPath ➡ Please manually set config.execPath

📜 I didn't document the change in the README because it affects very few people. I'll document it in the wiki page for electron support after merge

CI failures are unrelated, so LGTM.


Dashboard tag API

Summary of Changes
Added:

Dashboard Tag API

Updated:

Consolidated Tag logic into one.

Tests
Unit test has been added. Integration test has been done.
Documentation
docstring
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes make test

Codecov Report

Merging #118 into master will increase coverage by 0.75%.
The diff coverage is 97.67%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   70.86%   71.62%   +0.75%
==========================================
  Files          24       24
  Lines        1088     1117      +29
  Branches      107      110       +3
==========================================
+ Hits          771      800      +29
  Misses        291      291
  Partials       26       26

Impacted Files
Coverage Δ

metadata_service/proxy/neo4j_proxy.py
74.93% <83.33%> (ø)

metadata_service/api/dashboard.py
73.33% <100.00%> (+23.33%)
:arrow_up:

metadata_service/api/table.py
100.00% <100.00%> (ø)

metadata_service/api/tag.py
92.59% <100.00%> (+25.92%)
:arrow_up:

metadata_service/proxy/atlas_proxy.py
83.59% <100.00%> (ø)

metadata_service/proxy/base_proxy.py
67.18% <100.00%> (ø)

metadata_service/proxy/gremlin_proxy.py
45.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39a006...5470d45. Read the comment docs.

lol, I saw I disable the setting the +1 won't got away even the pr is updated....not sure if it is a global setting from lyft open source which overrides it...


155 make web requests async

all web requests are now async
changed files are:

dalle (working)
xkcd (working)
tex (working)
event sync
roomsearch (working)
fact (now moved to unused)

pretty sure most of this works but idk. things that felt iffy were the roomsearch requireing headers and tex/eveny sync (as i didnt write them)

Looks good and I've tested everything. Couple of tiny fixes to the requests, and one to the room API since that seems to have changed slightly and i cba to make a branch for that


Issue 1197 turn comments into javadoc

Turns $comment fields in the json-schema into javadoc comments. Similar to how the description field works.

I'm clearly terrible at git =(


add support for k8s v1.12.0-beta.1

What this PR does / why we need it: Adds the latest 1.12 beta build
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

add support for k8s v1.12.0-beta.1

/lgtm if E2E tests agree


make install dependencies dynamic

The problem:  when a library is created we are installing the swag cmd and initializing it (swag init) which is not required there.
The below snippets should fix the issue but then we need to also run Example-> swag init in the project dir. we can pass a flag to remedy that by checking if it's a project or library 🤪
Eg. requiredPackages := []string{"github.com/swaggo/swag/cmd/swag"}

func InstallDependencies(projectName string, flag string, packages ...string) {
   os.Chdir(projectName)
   RunCommand("go", "mod", "tidy")

   if packages == nil || len(packages) == 0 {
   	return
   }

   for _, pkg := range packages {
   	if err := RunCommand("go", "get", "-u", pkg); err != nil {
   		log.Fatalf("Failed to install package %s: %s", pkg, err)
   	}
   }

     // if flag == "p" init swag else do something like printing I am done here 😅

}

Sure,
I'll fix that.


Release 0.6.0 - FHIR, User Identifier, Filters

Release ONDEWO Survey Angular Client 0.6.0
Improvements

Keeps track of ONDEWO Survey API 0.6.*
Updated generation with of ONDEWO Survey API 0.6.*
Improved build scripts

Release ONDEWO Survey Angular Client 0.6.0
Improvements
Keeps track of ONDEWO Survey API 0.6.*
Updated generation with of ONDEWO Survey API 0.6.*
Improved build scripts


generator: focus-visible support deprecation

Is your feature request related to a problem? Please describe.
The generator assumes that focus-visible is not a supported feature and requires a polyfill for all browsers. This is not the case.
This pull request for auro-button removes that assumption.
Describe the solution you'd like
The update from the auro-button PR should be applied to WC-Generator to remove this assumption from future elements.
Be sure to update this doc
https://auro.alaskaair.com/support/polyfills/focusvisible

I am not sure how we want to address this, but there is something to be done with this update and the issues behind https://github.com/AlaskaAirlines/WebCoreStyleSheets/issues/69
I am using this issue to reference the other to ensure that there is a conclusion to both.


Hive Diagrams not showing FKs

Hi,
starting from version 0.8 Hive supports constraints PK and FK.
PK are well displayed in dbeaver not FK.
Is there a particular reason why not? JDBC Driver?
It would be great to have it to leverage the diagram functionality very useful for the users.
Thanks

I didn't actually try this but most likely JDBC driver just doesn't provide information about FKs. Perhaps it can be fixed by upgrading the driver version.


Private Cluster document does not create a private cluster but a public one.

The command - apiServer=$(az aro show -g $RESOURCEGROUP -n $CLUSTER --query apiserverProfile.url -o tsv)
Returns a public IP and not a private one.
The az aro create is missing the trigger   --apiserver-visibility Private which makes the apiserver private.
The current document does not achieve the ask for our customers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1298493d-9534-ef27-8102-f9b286494370
Version Independent ID: 5c974c35-4c34-afb6-5cbc-6e9f1d290148
Content: Create an Azure Red Hat OpenShift 4 private cluster
Content Source: articles/openshift/create-private-cluster.md
Service: container-service
GitHub Login: @ms-jasondel
Microsoft Alias: jasondel

@msftnadavbh
Thanks for the feedback! We are working on the document update and will get back on this.

@msftnadavbh The document is updated, changes will go live soon.


bemenu: 0.6.12 -> 0.6.13

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Cloudef/bemenu/releases.
meta.description for bemenu is: "Dynamic menu library and client program inspired by dmenu"
meta.homepage for bemenu is: "https://github.com/Cloudef/bemenu"
meta.changelog for bemenu is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.6.13 with grep in /nix/store/ifa84z9a06rfi7kxyfd7z9ic4nh37n95-bemenu-0.6.13
found 0.6.13 in filename of file in /nix/store/ifa84z9a06rfi7kxyfd7z9ic4nh37n95-bemenu-0.6.13

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
bemenu
mepo
pinentry-bemenu
tessen

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ifa84z9a06rfi7kxyfd7z9ic4nh37n95-bemenu-0.6.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bemenu https://github.com/r-ryantm/nixpkgs/archive/12ac8bc7adb31d49218367440b1a07ff2cee9dfc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ifa84z9a06rfi7kxyfd7z9ic4nh37n95-bemenu-0.6.13
ls -la /nix/store/ifa84z9a06rfi7kxyfd7z9ic4nh37n95-bemenu-0.6.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

bemenu
mepo
pinentry-bemenu
tessen

Maintainer pings
cc @lheckemann for testing.

Result of nixpkgs-review pr 195548 run on x86_64-linux 1

4 packages built:

bemenu
mepo
pinentry-bemenu
tessen


Support for whole organisation

Hi @vegasbrianc, thanks for the great tutorial!
It is working like a charm. I'm one of the maintainer of https://github.com/voxpupuli. Displaying a single repo, or a few, is pretty easy with your template. I would like to see some accumulated value. Like open Issues/PR/Stars for the whole org. It is probably easy to add up all values for an organisation?
Also do you think it is possible to get all the graphs you have right now generated for each repository? Maybe one dashboard for each? Creating them by hand takes a huge amount of time since we have more than 100 repos.

Hi @bastelfreak I'm happy you are finding the project useful. I used the https://github.com/infinityworksltd/github-exporter to grab the metrics from GitHub. If you edit the docker-compose.yml file go to the metrics section. Replace REPOS with ORGS you will see all Repos. This will show all Repos in the Org. You can then easily do some Top 10 queries etc.
  metrics:
tty: true
stdin_open: true
expose:
  - 9171
ports:
  - 9171:9171
image: infinityworks/github-exporter:latest
environment:
   - ORGS=docker

I also uploaded a new dashboard that totals all GitHub stars for and an example top 5 query. Just import the JSON into Grafana and it should work if your data source is named prometheu. Otherwise, update the query. - https://github.com/vegasbrianc/github-monitoring/blob/master/Grafana-Org-Stats.json
Let me know if this works for you or not.
Cheers.


Strange conflict with miniyank

Description
With miniyank, I have p mapped to <Plug>(miniyank-autoput):
:map p
  p             <Plug>(miniyank-autoput)

Then, for example when completing this snippet:
snippet fn "Function definition"
	fn ${1:function_name}(${2})${3} {
		${0}
	}

and pressing p to type the first character of function_name, neovim appears to run the miniyank-autoput command instead of inserting the p character.
See this demo where I first yank foobar and then complete the snippet with fn<tab>, and insert p as the first character of the function name, and then press p repeatedly.
Every other character works normally, and even p works if I type something else as the first character of the function.

If I unmap p, the problem goes away.
Any ideas? Thank you!
Steps to Reproduce
See description.
Expected Result
See description.
Actual Result
See description.
Additional Context
No response

Creating the miniyank mapping for normal mode (nmap) only seems to have fixed the issue for me.
I'm not sure why the author recommends map in the README, as I don't think the plugin is used in insert mode.
Perhaps this is the correct fix, if so, feel free to close.

I'm not sure why the author recommends map in the README, as I don't think the plugin is used in insert mode.

map maps in normal, visual (which includes select) and operator-pending modes. In your case, nvim is in select mode when you press p, so this seems to be the problem.


Backport #58 #62 to 1.x branch

Description
Backport #58 #62 to 1.x branch
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #64 (b041192) into 1.x (b1b116a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.x      #64   +/-   ##
=========================================
  Coverage     82.48%   82.48%
  Complexity      475      475
=========================================
  Files            69       69
  Lines          1821     1821
  Branches        178      178
=========================================
  Hits           1502     1502
  Misses          257      257
  Partials         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b116a...b041192. Read the comment docs.


Docs: Missing pages in new website

Describe the bug
https://adminbro.com/ > https://softwarebrothers.github.io/adminjs-dev/
Custom adapters page is missing.
Design System page is missing.
Modules page is missing.

The correct URL is: https://adminjs.co/ (links should work there)

The correct URL is: https://adminjs.co/ (links should work there)

The repo still links to adminbro.


feat: vapor component base

related: #4

I have implemented some foundational aspects of components.
I've made changes to manage setup~render execution, which was on the playground side in the existing implementation, and effectScope, which was a local variable in the render function, as component instances.
These instances are planned to be implemented in the future to register lifecycle hooks and manage provides, similar to traditional components.
Also, regarding the setup and render options, they are treated only as compile outputs this time and were not intended to be public for users, so I have named them InternalOption.
Please let me know if these APIs (Options) were supposed to be treated as public, and I will make the necessary adjustments.

Some points of uncertainty:

How to write tests regarding runtime
When using existing Vue packages, should I use @vue/* or vue?

The design of the components has not yet been discussed. We have to put this PR on hold.

I get an error
NotFoundError: The node to be removed is not a child of this node.


Handle in-memory segment metadata for index checking

When checking if pre-processing is needed during segment load, the segment metadata might not be loaded from the local file, and segment properties might not be available. This PR fixes the logic by not using the segment properties when checking if pre-processing is needed.

Codecov Report

Merging #10017 (9cc1363) into master (f2972c9) will decrease coverage by 14.42%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10017       +/-   ##
=============================================
- Coverage     28.05%   13.63%   -14.43%
- Complexity       53      176      +123
=============================================
  Files          1979     1936       -43
  Lines        106930   104841     -2089
  Branches      16277    16026      -251
=============================================
- Hits          30001    14295    -15706
- Misses        73993    89414    +15421
+ Partials       2936     1132     -1804

Flag
Coverage Δ

integration1
?

integration2
?

unittests2
13.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


New component - Search

Is your feature request related to a problem? Please describe.
Creating a Search focused component with autosuggest dropdown.
Essentially it's a combination of Combobox with NavigationMenu style keyboard navigation.
Describe the solution you'd like
Although this is similar to the feature bloated combobox, there are interaction differences:

Debouncing and throttling suggestions
Display loading state
Clear input
More complex portal navigation - like NavigationMenu

Here are some examples of that may look like:

Loading state: https://react.semantic-ui.com/modules/search/#variations-input
Could be build on something like this: https://cmdk-solid.vercel.app/

I can think of 2 approaches to creating this component:

Create from scratch with inspriation from Combobox and NavigationMenu
Build on top of cmdk-solid

Describe alternatives you've considered

Combobox is feature bloated and too restrictive for some search type operations.
cmdk-solid  is good UI-wise, but keyboard nav has some issues:

using tab stops keyboard navigation afterwards - maybe could make a PR here instead?

Search component implemented in PR #506
Preview here: https://deploy-preview-506--kobalte.netlify.app/docs/core/components/search
Key points:

Inherits the features if combobox with search focused defaults
Debouncer and loading indicator
List navigation - since menu navigation is very uncommon
Search focused examples for different use cases

Potential additions:

There is no clear button added

PR #506 currently merging


erreur dans Svayambhu

vois-tu ce qui est la cause de cette présentation aberrante de la stance et des appels de note?

It should be resolved. Since I had to touch the css it can take several hours to be applied though

Thanks. Now do you understand why the last <l> in <listApp type="parallels"> is not displayed with the preceding <l>? See screenshot.

I have given the more width for a line, it should resolve this. Once the css is updated


feat: change KameletBinding name to Binding

With this PR we aim to change the name of KameletBinding to a more generic Binding. The change are simple string replacements and in one case changing a struct which collided.
Closes #2625

Release Note
feat: change KameletBinding name to Binding

@oscerd @lburgazzoli @christophd this PR can change other dependencies around Kamelets world. Once we agree if this is okey, we should also promote the API to v1 so that the preiovus v1alpha1 can be still used by users of Camel K 1.x versions.

+1 from my side

no objections on that renaming. The reason for the renaming is a more generic approach where the binding is also there to bind non-Kamelet (Knative, Kafka) resources with each other, is that correct?

no objections on that renaming. The reason for the renaming is a more generic approach where the binding is also there to bind non-Kamelet (Knative, Kafka) resources with each other, is that correct?

Yes, that's correct. Mind that we'll need to update Yaks configuration to let the tests here to pass. However I'm not sure how we can do this ahead of time as we have a circular reference between Camel K and Yaks.

I can take care of updating Yaks and releasing a new version that uses Binding. I think it will be a matter of hours to align with that

@squakez are removing KameletBinding or making it deprecated ?

@squakez are removing KameletBinding or making it deprecated ?

As we are moving to a new version (I still need to create either v1beta1 or promote to v1 directly - to be discussed) I don't think it makes sense to deprecate.

@squakez are removing KameletBinding or making it deprecated ?

As we are moving to a new version (I still need to create either v1beta1 or promote to v1 directly - to be discussed) I don't think it makes sense to deprecate.

the main issue would be that you cannot upgrade an operator to v2 so I think we should either support KameletBinding and Binding for some time or having an automated upgrade strategy (maybe via a webhook) ? @astefanutti WDYT ?

what about using new Binding for apiVersion v1 and existing KameletBinding is still valid for v1alpha1 apiVersion

That's correct. Right now I am not really thinking in any upgrade strategy. A new major installation has to be performed from scratch. I understand this can result in some problem for any running integration, let me open a separate issue to discuss about a possible solution to this problem.

the main issue would be that you cannot upgrade an operator to v2 so I think we should either support KameletBinding and Binding for some time or having an automated upgrade strategy (maybe via a webhook) ? @astefanutti WDYT ?

@lburgazzoli changing resource names in Kubernetes isn't possible (the name field is immutable after creation), which makes existing versioning and conversion mechanisms inapplicable to this case, e.g., for CRD conversion webhook:
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#permissible-mutations
Practically, simply changing the CRD name will create a new type, and leave the existing CRD as is, along with its instances, which will be ignored by the v2 operator.
To provide a smoother migration path, the simplest option would be to support both KameletBinding and Binding resource types as you suggested. It may also be possible to write an ad-hoc conversion controller as a more advanced strategy.

@squakez YAKS 0.15.0 has been released with support for the new Binding resources (I hope it works).
Could you please update the YAKS version in this PR in GitHub workflow action (https://github.com/apache/camel-k/blob/main/.github/actions/e2e-knative-yaks/action.yml#L109). As YAKS needs to support both KameletBinding and Binding for a while you also need to set an env var when running the tests (YAKS_CAMELK__KAMELET_BINDING_API_VERSION=v1) maybe here https://github.com/apache/camel-k/blob/main/.github/actions/e2e-knative-yaks/exec-tests.sh#L126
The __ in the env var name is a bug that I will fix in 0.15.1

I am starting to think that, in order to ease the upgrade from v1 to v2, it really makes sense to keep both v1 and v1alpha1, at least for the first release (deprecating v1alpha1, of course). Right now, I'm exactly having issues in the upgrade scenario.
@christophd probably we will need to update Yaks again accordingly. Let's wait until this aspect is clarified, and once the other checks are green, we can have a new release of Yaks as well.

@squakez YAKS 0.15.0 should be able to work with both KameletBindings and Bindings already. It is based on the apiVersion you set via env var. In order to use the new Binding you have to use v1 in this setting already regardless of the fact that the CRD for the Binding resource still uses v1alpha1 at the moment

I am starting to think that, in order to ease the upgrade from v1 to v2, it really makes sense to keep both v1 and v1alpha1, at least for the first release (deprecating v1alpha1, of course). Right now, I'm exactly having issues in the upgrade scenario.

+1
I understand the complexity but I think is quite not realistic that everyone consuming camel-k APIs would be able to migrate it to v2 straight away

It seems, for a reason that is yet to be identified, with v1 version, the object type validation is stricter.
If the type: object definitions are removed, and only x-kubernetes-preserve-unknown-fields is left, it works, that is equivalent to any types, e.g.:
properties:
    additionalProperties:
      properties:
        default:
          description: default is a default value for undefined object
            fields.
#         type: object
          x-kubernetes-preserve-unknown-fields: true
        deprecated:
          type: boolean
        description:
          type: string
        enum:
          items:
            description: 'JSON represents any valid JSON value. These
            types are supported: bool, int64, float64, string, []interface{},
            map[string]interface{} and nil.'
#            type: object
            x-kubernetes-preserve-unknown-fields: true
          type: array
        example:
          description: 'JSON represents any valid JSON value. These
          types are supported: bool, int64, float64, string, []interface{},
          map[string]interface{} and nil.'
#         type: object
          x-kubernetes-preserve-unknown-fields: true

Interestingly, that was the intent of #1914, with using the +kubebuilder:validation:Type="" marker on those fields.
Something added those type: object lines afterwards, maybe an upgrade of kubebuilder?

May I please ask, how should be tested status of KameletBinding/Pipe in case of upgrade scenario? It needs the prior naming for released operator...

I think the best upgrade strategy is to leave the KameletBinding type to run from v1 to v2. Then, the user should upgrade from KameletBinding to Pipe manually if this is required, ie, stopping the old KameletBinding and starting a new Pipe with the same KLB spec.

Maybe wouldn't it be useful to have something like a kamel "convert" subcommand which would prepare Pipe from the Kameletbinding?


DIST-S1 Interface SAS 0.0.3 Acceptance Test

Acceptance Test Procedure Steps

[x] Download the delivered SAS Docker image from Github on PGE development machine

docker pull ghcr.io/opera-adt/dist-s1:0.0.3

[x] Execute the unit test suite for dist-s1 from within the SAS container

docker run dist-s1:0.0.3 bash -l -c 'cd dist-s1 && pytest tests'

[x] Create/Update Acceptance Testing Procedure wiki page

Be sure to include any changes to test data structure, file permissions, RunConfig changes etc.

[x] Include the results of Quality Assurance check at the bottom of the wiki page

Include any details on known failures or workarounds, and include a sample of the expected output from the comparison script
If the results of the comparison step are contingent on a particular instance type or chip family, be sure to note that as well

Acceptance testing complete, procedure is now available here: https://github.com/nasa/opera-sds-pge/wiki/DIST‐S1-Interface-Acceptance-Testing-Instructions


Code (style) cleanup

After the major refactors are done, clean up the code, so pylint doesn't produce warnings which in turn fail the tests. This contains sticking to PEP8, removing unused imports, etc. This should leave us with readable and beautiful code.
We also need to disable pylint warnings for using tabs instead of spaces and other things, if they're unsolvable or just pylint is wrong.
This should also solve #7 (we'll see).

Print a message when falling back to the Desktop device platform - it can be very confusing!
Maybe get rid of the fallback so users can see the errors on import and can decide to manually set other platform.


Several updates to make some part of the code reusable for the clinical significance and evidence status

Thanks Laurent!


[Feature Request][txs] Create validator-config subcommand to txs app so validators can update on-chain discovery info

Validators need a tool to be able to update their on-chain configuration such as networking.
The Move tx scripts is ValidatorAdministrationScripts::register_validator_config
https://github.com/OLSF/libra/blob/1292f55fe8ddd6ab5255094364cc10dd9d194b8e/language/diem-framework/modules/ValidatorAdministrationScripts.move#L140-L155
The ol txs sending tool is the CLI tool to send transactions to network.
An unrelated subcommand, which serves as an example is the authentication key rotation subcommand. Seen here:
https://github.com/OLSF/libra/blob/3b2e34cb794ca3f4a7da8e0b1a4e3b211e8d7759/ol/txs/src/commands/authkey_cmd.rs#L22-L41

Hi @Leibniz137 - I continued on this topic and made a commit in my repository:
https://github.com/mortonbits/libra/pull/new/feature/mb-change-vlad-ip
Can you have a look on this? I changed it to ask interactively for the new IP by re-using the dialogue from the "ol init" command.
@0o-de-lally - the method register_validator_config expects 2 addresses, one for the validator and one for the full node. Is it ok to take the same IP for both? Or should we let the user specify the VFN address for the fullnode_network_address?

@mortonbits  and @leibniz137 I have a PR that does this, its a little more involved than taking an IP address. See here: https://github.com/OLSF/libra/pull/938


md5sum never matches

I have confd configured to watch an etcd2 cluster for key changes and the config gets written every 10 seconds and never end. But what seems to be the most strange is that the MD5SUM reported is always one permutation behind.
LOG:
2015-09-17T20:46:03Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum b9dcaa8318b66ff3475f09cd6319e2eb should be 3ff74082d372c68c2f91eaa55e87d0f4
2015-09-17T20:46:03Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:03Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated
2015-09-17T20:46:13Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum 3ff74082d372c68c2f91eaa55e87d0f4 should be b6a5f7c28f5b3d16ef227a964311ad90
2015-09-17T20:46:13Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:13Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated
2015-09-17T20:46:23Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum b6a5f7c28f5b3d16ef227a964311ad90 should be e38aa87af449d44b27cb63a063c57428
2015-09-17T20:46:23Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:23Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated
2015-09-17T20:46:33Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum e38aa87af449d44b27cb63a063c57428 should be a414d17a0c8ac7cc4887e058ad9ac63e
2015-09-17T20:46:33Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:33Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated
2015-09-17T20:46:43Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum a414d17a0c8ac7cc4887e058ad9ac63e should be 1b57910cc9b3debc16e2e7e6b3bb68e0
2015-09-17T20:46:43Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:46Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated
2015-09-17T20:46:56Z 80c1c3ca67d5 confd[35]: INFO /etc/nginx/conf.d/app.conf has md5sum 1b57910cc9b3debc16e2e7e6b3bb68e0 should be 4a95cf02d75dae4dfcd78a28815e1968
2015-09-17T20:46:56Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf out of sync
2015-09-17T20:46:56Z 80c1c3ca67d5 confd[35]: INFO Target config /etc/nginx/conf.d/app.conf has been updated

TOML
[template]

# The name of the template that will be used to render the application's configuration file
# Confd will look in `/etc/conf.d/templates` for these files by default
src = "nginx.tmpl"

# The location to place the rendered configuration file
dest = "/etc/nginx/conf.d/app.conf"

# The etcd keys or directory to watch.  This is where the information to fill in
# the template will come from.
keys = [ "/services/dev/phpfpm/" ]

# File ownership and mode information
owner = "root"
mode = "0644"

# These are the commands that will be used to check whether the rendered config is
# valid and to reload the actual service once the new config is in place
check_cmd = "/usr/sbin/nginx -t"

# reload http://wiki.nginx.org/CommandLine#Stopping_or_Restarting_Nginx
reload_cmd = "kill -HUP $( cat /var/run/nginx.pid )"

TMPL
# Generated by confd {{datetime}}

upstream php {
  {{ range gets "/services/dev/phpfpm/*" }}
  {{ $server := split (.Value) "," }}
  server {{index $server 0}}:{{index $server 1}};
  {{end}}
}

server {
  server_name _;

  ## Your only path reference.
  root /php;
  ## This should be in your http block and if it is, it's not needed here.
  index index.php;

  location = /favicon.ico {
    log_not_found off;
    access_log off;
    }

  location = /robots.txt {
    allow all;
    log_not_found off;
    access_log off;
    }

   location / {
     # This is cool because no php is touched for static content.
     # include the "?$args" part so non-default permalinks doesn't break when using query string
     try_files $uri $uri/ /index.php?$args;
     }

   location ~ \.php$ {
     #NOTE: You should have "cgi.fix_pathinfo = 0;" in php.ini
     include fastcgi.conf;
     fastcgi_intercept_errors on;
     fastcgi_pass php;
     }

   location ~* \.(js|css|png|jpg|jpeg|gif|ico)$ {
     expires max;
     log_not_found off;
     }
}

Could be the datetime will always change on the polling interval? Which will change the MD5SUM. I'd try removing that to see what happens.

Yes, its the date time feature. I think this is a duplicate issue

That was it! Thanks guys


href in router is undefined

I tried to configure me route as follow:
this.dynamicMap=[ {route : 'dashboard', name: 'dashboard', moduleId : 'dashboard', nav : true, title:'Dashboard'},
        {route : 'logout', name : 'logout', moduleId :'logout', nav : true, title : 'Logout'}];
this.theRouter.configure(config=>{
                      config.map(this.dynamicMap);
                  });

I have the same situation if try this one:
this.theRouter.addRoute({route : 'dashboard', name: 'dashboard', moduleId : 'dashboard', nav : true, title:'Dashboard'});

It  works, I see  items in nav-bar, but when I try to click on link I get "undefined " in url.
The console shows me that 'href' property for this items  is "undefined "
Maybe somebody knows what is the problem?

It looks like hrefs in the navigation array aren't set until the router actives & determines its current location, so my guess is that you're trying to render nav links before the router has been activated.
The root router will activate automatically when a viewport is registered (when you render a <router-view> element). I would suggest using a configureRouter() method on your root view model and a <router-view> element in your view. If you can't do that for some reason, you could try calling router.active() manually, but I'm not sure it will work right without any viewports to render to.
If my guess is incorrect then I'll need a little more context to help. Let me know if that solves your problem.

Unfortunately it didn't solve my problem.
Thanks for help

Are you able to post a more complete code sample? Seeing the whole view
model & view would be helpful.
On Sun, Nov 8, 2015 at 5:27 AM VladCherniavsky<EMAIL_ADDRESS>wrote:

Unfortunately it didn't solve my problem.
Thanks for help
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/router/issues/239#issuecomment-154826502.

@VladCherniavsky I had the same issue. You can fix it with with a refeshNavigation call to update the href property which in used in the nav-bar.
this.router.configure(config);
this.router.refreshNavigation();

@bryanrsmith I got the same issue when trying to register a route from a feature/plugin following @EisenbergEffect suggestion
import {AppRouter, RouterConfiguration} from "aurelia-router";

export function configure(aurelia) {
  const router = aurelia.container.get(AppRouter);
  const routerConfig = aurelia.container.get(RouterConfiguration);
  routerConfig.map([
    { route: "parts", moduleId: "features/parts/parts", name: "parts", nav: true, title: "parts" }
  ]);
  routerConfig.exportToRouter(router);
  router.refreshNavigation();
}

However this yields in a
ERROR [app-router] Error: Route not found: /parts(…)

when clicking on the href. Looking in the AppRouter when debugging the recognizer hasn't registered it so I guess I have multiple instances of AppRouter

@stoffeastrom Are you on the latest versions? There was a bug that could enable multiple instances of AppRouter. That was fixed in the last release.

Good question, let me verify that :)

:+1: works


Improve choose-category in form-group

Need to improve this component: choose-category
Improvements required :
Make three different in size as given in the Figma file
Any reference image?

Please assign me @Rajdip019