Associate Search Console w Analytics

Description
https://search.google.com/search-console/settings/associations?utm_source=sci&utm_medium=sci&utm_campaign=sci&resource_id=sc-domain:wargabantuwarga.com

I can't do it because I don't own the GA property.
I think we need Mas @baraeb92's help with this, but he needs to "own" the search property by verifying himself.

Will do this tomorrow morning, because I need infra team to add the TXT to the DNS. @zainfathoni

Unfortunately, it cannot be done using GA4 at the moment, any specific reason as to why this is necessary?
See: https://support.google.com/webmasters/thread/77936816/linking-search-console-to-ga4?hl=en
@zainfathoni @mazipan


1.3.0 release broke role based s3 authentication

https://github.com/ahmedkandel/nova-s3-multipart-upload/commit/695f95221e6c38c99f7e52ce8510ddf9a2954453#diff-d381368b790cbf818204c612d2985bfbac9f3bffd3466c426ff1ffb7f02e9ae2R56-R63
Any application that uses role-based authentication would have worked prior to this change. The new version of this module discards the existing s3 client connected to the filesystem adapter, and constructs a new one, assuming key + secret authentication instead.
When we updated to 1.3 this of course immediately broke. :)
Could the current code work the same if we restore this line?
$this->s3Client = Storage::disk($this->tool->disk)->getDriver()->getAdapter()->getClient();

Laravel 9.x has migrated from Flysystem 1.x to 3.x so the Storage::disk($this->tool->disk)->getDriver()->getAdapter()->getClient() which works for Laravel 8.x is not available anymore starting from Laravel 9.x and will be Storage::disk($this->tool->disk)->getClient() here.
In order to support Laravel 8.x and 9.x we found it is more convenient to decouple from Laravel storage and instantiate S3Client using the disk config.

To solve your problem either you get the client from Laravel filesystem depending on the Laravel version or to use the S3Client directly but with optional credentials as discussed here.
PRs are welcome.

Thanks for the explanation. It makes sense to me. I'll see about writing up a PR to address.
Is likely we could still manually construct the client the way you are now, but tweak the credentials.

Please see https://github.com/ahmedkandel/nova-s3-multipart-upload/pull/25. Hope you find it helpful :)


Write module to sort uGMT input muons

Write a module to sort the ugmt input muons in the format we expect them to have correct inputs for the test pattern generation

https://github.com/thomreis/cmssw/blob/l1t-muon-CMSSW_8_0_0_pre6_cancel-out_patterns/L1Trigger/L1TMuon/plugins/L1TRegionalMuonCandSorter.cc does that


Cypress detected that you returned a promise in a test, but also invoked one or more cy commands inside of that promise

When running Cypress tests via the cypress-cucumber-preprocessor I saw a number of these warnings. It is not causing my tests to break but I wanted to eradicate the warnings nevertheless.  However, when I went through my scenarios and steps I could not find anything that would cause it.
If I put a breakpoint on the warning and look at the call stack it seems to be caused by code in the preprocessor (createTestFromScratch.js), firstly in:
const runTest = (scenario, stepsToRun, rowData) => {
  const indexedSteps = stepsToRun.map((step, index) =>
    Object.assign({}, step, { index })
  );

  // should we actually run this scenario
  // or just mark it as skipped
  if (scenario.shouldRun) {
    // eslint-disable-next-line func-names
    it(scenario.name, function() {
      const state = window.testState;
      return cy
        .then(() => state.onStartScenario(scenario, indexedSteps)). <<<<< HERE

and then here
// eslint-disable-next-line func-names, prefer-arrow-callback
  after(function() {
    cy.then(() => testState.onFinishTest()).then(() => {            <<<<<< HERE
      if (window.cucumberJson && window.cucumberJson.generate) {
        const json = generateCucumberJson(testState);
        writeCucumberJsonFile(json);
      }
    });
  });

Current behavior
Cypress noisy warnings in console
Desired behavior
No Cypress warnings in console
Test code to reproduce
Any test scenario will produce this result
Versions

Cypress version:  4.9.0
Preprocessor version: 2.5.2
Node version: 10.9.0
Platform: Ubuntu

Not able to reproduce. Where do you encounter there warnings? Provide us with an example repostory.

You have asked for an example and then closed the issue?

You have asked for an example and then closed the issue?

I don't personally care so mcuh about the issue-status, tt wasn't very deliberate. Do you want to argue about it or do you rather want to just provide what I asked you for?

It's just a cleanup... if we can't reproduce and there is no reproduction provided we need to consider an issue closed, as we are doing this for free and have super limited resources (basically me and badeball, and recently it's more like 90% badeball), for ~150k weekly installs (which is almost 10% of all cypress users, which itself is a tool from a for-profit company providing paid services.)
It might be a bit nicer to wait a few days for a reproduction, I agree.. 😅 But most people never come back and I assume badeball closing the issue basically marked it for himself as "checked". It's easy to reopen things.  Please do provide a small repro where you are positive that the issue shows up.
A hunch - are you testing on windows?

Do you want to argue about it or do you rather want to just provide what I asked you for?

Why the aggressive attitude?   I wasn't being unreasonable in assuming "closed" = "Not going to look at it anymore".
How was I supposed to automatically know that the issue status is irrelevant on this project.
People are taking the time to log questions and issues because they want to help the developers improve the package. We aren't doing it to try to irritate you. Passive/aggressive responses will simply discourage that level of interaction.

....But most people never come back .....
Understood. I will of course endeavour to boil it down into a manageable reproducible repo.  It will take some time as these Cypress tests are embedded in a monolithic proprietary application/repo that I am not at liberty to share.  Doing so may actually give me more insight into the cause. Either way I will report back.

A hunch - are you testing on windows?

Actually no, it is on Ubuntu.

People are taking the time to log questions and issues because they want to help the developers improve the package. We aren't doing it to try to irritate you. Passive/aggressive responses will simply discourage that level of interaction.

That's hilarious, but honestly it would be nice if that was the reality. The reality however is much, much sader. Most issues filed are unfortunately characterized by one or more of the following

Author having done no debugging on their own
Not providing enough information to reproduce a problem
Containing large bodies of code instead of a clonable repository, making the job suck just a little bit more
Having basic issues with npm / node
Having issues with Cypress
Having not read the readme
Being a duplicate, IE. author hasn't even searched beforehand
Just looking for testing advice / support

Maintaining the package at this point mostly entail debugging on behalf of other people (who either aren't capable of it themselves or haven't bothered) and explaining them how they're wrong. It's an exhaustive and unappreciative job.
People might have the best intentions, but most do nothing to help improvide the package and are really just wasting my time. Hence, I believe some level of aggressiveness is warranted. Your desire to be treated differently is understandable, but it's not my priority.

It will take some time as these Cypress tests are embedded in a monolithic proprietary application/repo that I am not at liberty to share. Doing so may actually give me more insight into the cause.

You're right that doing so would provide more insight. It's exactly what either of the maintainers would have had to do on your behalf. Why would you not just do this for us beforehand?

Why would you not just do this for us beforehand?

Because I believe(d) I had provided enough information already by debugging the tests down to providing the exact line(s) of code that threw the error. I didn't just post a throwaway remark on an issue without any investigation. It seemed very easily reproducible. Your feedback (inability to replicate based on the information provided) indicates that I was wrong in my assertion and need to dig deeper.  That is the way these things usually work - right?
But honestly, your reaction and comments genuinely have discouraged me from doing so.  I have no wish to make the maintainers life a misery, and I have no wish to be reprimanded if my next effort still fails to meet with your approval.
Feel free to leave it closed.


Fix typo from naive to naïve

In English, it is okay to spell 'naive' without the diaeresis.
https://www.merriam-webster.com/dictionary/naive

Agreed.
Thanks for the patch though; I really appreciate the thought!


IAM - Add all valid TrustPolicy actions

Fixes #5750

Codecov Report

Merging #5751 (3f01aec) into master (9be9edf) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5751   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files         751      751
  Lines       73612    73624   +12
=======================================
+ Hits        70813    70825   +12
  Misses       2799     2799

Flag
Coverage Δ

servertests
36.93% <ø> (-0.01%)
:arrow_down:

unittests
96.13% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/iam/policy_validation.py
98.19% <ø> (ø)

moto/elb/models.py
91.64% <0.00%> (-0.03%)
:arrow_down:

moto/emr/models.py
97.48% <0.00%> (-0.02%)
:arrow_down:

moto/ecs/models.py
93.08% <0.00%> (-0.01%)
:arrow_down:

moto/core/responses.py
95.98% <0.00%> (-0.01%)
:arrow_down:

moto/s3/models.py
96.87% <0.00%> (-0.01%)
:arrow_down:

moto/emr/responses.py
99.46% <0.00%> (-0.01%)
:arrow_down:

moto/route53/models.py
96.53% <0.00%> (+0.13%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: adds the python_type property.

This implements the python_type property for DateTimeUTC.
This is used by other libraries such as polyfactory.  It was previously raising a NotImplementedError instead of returning a datetime type.

Thanks for jumping on this so quickly!


Add x-region support

What kind of change does this PR introduce?

Add x-region support, which allows for the specification of an edge region.
Tiny code optimization/reordering, check for invoke_options only once.

Codecov Report
Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.29%. Comparing base (a809e98) to head (d2aba7d).
Report is 51 commits behind head on main.

Files
Patch %
Lines

supabase_functions/_async/functions_client.py
81.81%
2 Missing :warning:

supabase_functions/_sync/functions_client.py
81.81%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   85.21%   86.29%   +1.07%
==========================================
  Files           7        7
  Lines         115      124       +9
==========================================
+ Hits           98      107       +9
  Misses         17       17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Replace send_traffic_control_device_types script with import_traffic_control_device_types management command

This PR replaces the send_traffic_control_device_types script a Django management command import_traffic_control_device_types.
We also rename the file traffic_sign_codes.csv to traffic_contrl_device_types.csv
Refs: LIIK-151

Codecov Report

Merging #93 into master will increase coverage by 0.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   96.38%   96.95%   +0.56%
==========================================
  Files          87       88       +1
  Lines        5205     5215      +10
  Branches      191      193       +2
==========================================
+ Hits         5017     5056      +39
+ Misses        172      143      -29
  Partials       16       16

Impacted Files
Coverage Δ

...control/management/commands/import_portal_types.py
100.00% <100.00%> (ø)

...nt/commands/import_traffic_control_device_types.py
100.00% <100.00%> (ø)

...mmands/test_import_traffic_control_device_types.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d9f9f...f1dac16. Read the comment docs.


Two errors when trying to launch PowerToys Run from keyboard shortcut

ℹ Computer information

PowerToys version: <IP_ADDRESS>
PowerToy Utility: PowerToys Run
Running PowerToys as Admin: No
Windows build number: 20H2 build 19042.804

📝 Provide detailed reproduction steps (if any)

Upgraded PowerToys to v0.33.1, did not restart computer
Tried to launch PT Run using alt+space shortcut
Received 2 error popups

✔ Expected result
PowerToys Run should launch and allow typing input
❌ Actual result
Received 2 error popups:
📷 Screenshots

Attachments
2021-03-10.txt

When trying to copy the error message, I received a 3rd error popup. Then the error popups froze and eventually crashed.
After they crashed, I am able to launch PT Run with the keyboard shortcut as expected.

I just got the same errors when attempting to use the shortcut (Alt-Space).
My Windows build is 20H2 19042.844.
I disabled the re-enabled the power toy, and it's working again.
2021-03-11.txt


Server ability for the NetworkChannel

At the moment the NetworkChannel is intended for simple client use. We need some form of server functionality to be able to actually open a server and listen for connections.

Done.


iD's error message when OSM is busy is incorrect

Hey folks,
It looks like iD isn't properly parsing the error message when OSM is busy:
openstreetmap.org right now
This website is under heavy load (queue full)
We're sorry, too many people are accessing this website at the same time. We're working on this problem. Please try again later.

iD error shown in the netlify deploy:

Thanks, I think this is #7796.

Certainly is. Thanks


[BUG] - Update port for conda-store-server

Describe the bug
This has recently landed https://github.com/conda-incubator/conda-store/pull/642.
conda-store-ui still assumes port 5000 for conda-store-server.
This is easy to repro by clicking on the Login button in localhost:8080, it does nothing because the generated URL contains port 5000.
Expected behavior
Being able to log in.
How to Reproduce the problem?
See above.
b4a5b46732f3441084fff4ff5537d494f0f3f09e - conda-store-ui
0760fa2b386bc207936df89f52b4df83f61e8af8 - conda-store
Output
No response
Versions and dependencies used.
No response
Anything else?
No response

I'm also not sure whether the current design allows having the same port for both the UI and the server. The UI has been using 8080 for a while, the server was using 5000 before but now uses 8080 as well.

Currently the docker-compose.yml and docker-compose-dev.yml files reference the latest release of conda-store-server. So running docker-compose -f docker-compose-dev.yml up and then yarn run start works fine. We should probably pin to a specific version rather than simply latest though.
If we pin to a specific version then this  will mean that a conda-store-server release won't break conda-store-ui. It will  working because it means that the projects are loosely coupled as they should be. With conda-store-server being a dependency for conda-store-ui, a release of conda-store-ui will need to ensure whatever version of conda-store-server that is pinned to works, so that will need to be tested on a release. However, the point is though that each individual project can release independently because they are loosely coupled. This is a good thing.
Now obviously, we want to be able to support the latest changes to conda-store-server. This change only changed the default port that conda-store-server runs on. To allow this repo to work with that change, I propose that we explicitly set a port for conda-store-server that is compatible with conda-store-ui.
My suggestion would be to specify a port like 8000 for conda-store-server in the docker-compose-dev.yml and docker-compose.yml file so it doesn't conflict with 8080 that conda-store-ui is using.
If this sounds good, I can go ahead and make those changes. @kcpevey thoughts here?

Pulling the latest version that includes the default port changes still works as well, since the provided config file sets the conda-store-server port explicitly. So I don't think this actually needs a fix.

I think this does need fixing on the UI side because it expects the server to be running on a certain port.
If you search for 5000 in this (UI) repo, there are matches, which probably need to be updated.
Steps to repro:

start conda-store-server as standalone with this config.py (it uses port 8080):

 python -m conda_store_server.server --standalone  --config config.py

start conda-store-ui
go to homepage with UI port (localhost:8080 -- this is served by UI), try to log in
here's where you get redirected after clicking on the Login button:
http://localhost:5000/conda-store/login?next=http://localhost:8080/
since the server is not running on port 5000, this fails
change the port to 5000 in the config, restart the server, you're able to log in.

yes, running a conda-store-server instance configured on port 8080 will fail if the conda-store-ui is configured to look at port 5000. That doesn't seem like a bug, it seems like they are both doing what they were configured to do. However, if we want to make sure that conda-store-ui's default port is compatible with conda-store-server's default port, I suggest we move conda-store-ui to port 8000 or port 8008.


Kindly Show The Implementation

Kindly Show The Implementation of this project because it is show hard to understand file directory
Anyway The Code and complexity acc. to me is much much good than other
appreciate your hardwork
it would be beneficial if you show us Implementation

Could you please be more specific what you are looking for? Are you looking for documentation how to use this in your own code? Do you want to understand the coding algorithm?

sorry for the inconvenience...
Yes I want to use this in my own code
How Can i Use This

See https://github.com/cfeck/imagezero/issues/5


Allow grouping servers

Context
Current Server Object is identified by the key on servers map. E.g.:
servers:
  production: # 'production' is the name of the server.
    url: localhost:8080

In the previous example, the word production identifies the server. We could also call it by it's server machine name or service name, e.g. yavin04.yavin.systems.
No matters what name do we use for the server as far as are unique in the servers map.
One common pattern (See https://github.com/asyncapi/spec/issues/628) is to declare reusable servers in common AsyncAPI files, then reference them in the specific AsyncAPI files. E.g.
# common.asyncapi.yaml
components:
  servers:
    yavin04.yavin.systems:
      url: https://yavin04.yavin.systems:8080
      protocol: http

# app.asyncapi.yaml
servers:
  production:
    $ref: 'common.asyncapi.yaml#/components/servers/yavin04.yavin.systems'

What if a server exposes multiple ports with different protocols? Current Spec forces to create a different Server Object for this matter, since only one protocol is allowed per server. E.g.:
# common.asyncapi.yaml
components:
  servers:
    yavin04.yavin.systems-http:
      url: https://yavin04.yavin.systems:8080
      protocol: http
    yavin04.yavin.systems-websocket:
      url: https://yavin04.yavin.systems:5000
      protocol: ws

# app.asyncapi.yaml
servers:
  productionHTTP:
    $ref: 'common.asyncapi.yaml#/components/servers/yavin04.yavin.systems-http'
  productionWebsocket:
    $ref: 'common.asyncapi.yaml#/components/servers/yavin04.yavin.systems-websocket'

Just as side note, I wouldn't say no to evaluating the idea of allowing several protocols to be declared (linked to ports). But this is for another issue :)

The problem
How can a user answer the question: "How can I identify the list of real/physical servers or service names in my system?", where system refers to the infrastructure around this or all my applications.
Also from the point of view of code generators, the same answer could be formulated. For example. "Generate all servers from service name yavin04.yavin.systems". This will end up generating one for http protocol, and another one for ws.
Another example is for tooling like the Event-Gateway, where several servers relate to the same service. See this.
Possible solutions
Solution 1: Use the url field
By using the url field, we could group all described servers. Of course getting rid of any variable on it such as the port, etc.
This seems a quick and easy solution, but it has some important drawbacks; the most important to me is that URLs can differ from one protocol to another. Not only the port but also the DSN on it. E.g.:
# common.asyncapi.yaml
components:
  servers:
    yavin04.yavin.systems-http:
      url: https://api.yavin.systems:8080
      protocol: http
    yavin04.yavin.systems-websocket:
      url: https://ws.yavin.systems:5000
      protocol: ws

Having reached this point, there is no way to identify the real server behind, unless we play with some particular server name format. More in next bullet.
Solution 2: Use a custom name format
The user could set a known format for the server name, e.g. {servername}-{protocol}-{port}, which will look like yavin04.yavin.systems-http-8080 and yavin04.yavin.systems-ws-5000. This way, we could identify the physic/real server behind by extracting it from the name, in this case {servername} section.
Even though I consider this a really good practice that should be followed anyway, there is a clear drawback: not supported by tooling. As it is no a standard in the spec, tooling won't care that much about the name following a format. Grouping Server Objects by real/physic servers when for example generating documentation won't be a thing.
Solution 3: Add a new field on Server Object.
Supporting a new optional field on Server Object, such as service, serviceName or just group. E.g.:
# common.asyncapi.yaml
components:
  servers:
    yavin04.yavin.systems-http:
      url: https://api.yavin.systems:8080
      group: yavin04.yavin.systems
      protocol: http
    yavin04.yavin.systems-websocket:
      url: https://ws.yavin.systems:5000
      group: yavin04.yavin.systems
      protocol: ws

This new field would be totally optional and won't act as a object identifier.
Thanks to this new field, we could generate some cool documentation, grouping servers by their serviceName, or rather just add a new tag to those with a value on it. I generated a simple mock of the most simple solution, but I think we could do much better 😅

Suggestion
I would prefer following Solution 3 and adding a new field to the Server Object.
What do you all think? Do you find it useful?

How can I identify the list of real/physical servers or service names in my system?

A server, to the application, is in most cases an endpoint (for WS and HTTP, it is a little bit more), that the application can connect to. In my mind, it should not know anything about the physical infrastructure (physical servers) as that has a tendency to be volatile. So defining the endpoint has always been enough for my use case when designing the API.
So even though it is not possible to explicitly describe the physical servers, my rebound question would be why do you really want to describe them? 🤔

Generate all servers from service name yavin04.yavin.systems

Sorry, I think you need to specify this one a bit further, as I don't see the use-case 😅

I'm surprised you didn't play the "environment" card. Some people already requested we add a way to group servers by the environment, e.g., production, staging, development, etc. This way, you could have generators or Glee to run the code for production or for development, without having to change which servers it should use/create.
Since there are a myriad of cases, I'm wondering if we shouldn't just allow tags inside the server objects. This way, people can name their tags as environment, boundedContext, serviceName, or whatever they mean with the grouping. Furthermore, they could be adding more "filters" like "use all the servers from the X bounded context of Y environment". It adds flexibility but lacks specific meaning. What do you think? Sounds better or worst?

I'm surprised you didn't play the "environment" card.

Yeah, after the simplification I made, this is mostly the same as https://github.com/asyncapi/spec/issues/623 (different fashion).
I like the tags approach. In fact, tooling could use some kind of selectors for filtering as input, like serviceName: 'foo' , or even more advanced one with mathers like serviceName in ('foo', 'bar'). Just thinking in far feature possibilities. (something like https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements).

I'm surprised you didn't play the "environment" card.

Yeah, after the simplification I made, this is mostly the same as https://github.com/asyncapi/spec/issues/623 (different fashion).
I like the tags approach. In fact, tooling could use some kind of selectors for filtering as input, like serviceName: 'foo' , or even more advanced one with mathers like serviceName in ('foo', 'bar'). Just thinking in far feature possibilities. (something like https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements).
The downside is that tooling won't be able to assume any those tags are present, nor set an expected tag name. For example, the html-template won't be able to group by environment but just by tags, which loses a bit the context and perhaps some specific logic (we might want to do in the future) behind.
I think going with a generic approach makes total sense; making servers be discoverable, filtered, and categorized by anything is the best extendable approach.
Not adding anything you didn't mention already @fmvilas.

@fmvilas there is also this proposal https://github.com/asyncapi/spec/issues/527 which won't be able to take profit of the tags mechanism, so it will require a dedicated field (I mean, we could somehow reuse it but IMHO will look complex).

I think they're unrelated. This proposal is suggesting a way to prefix channel names, which I'd highly discourage now that we can associate channels with servers. And in v3 you'll be able to fully reuse channels so no need for it IMHO. But yeah, not sure what does it have to do with this proposal here 🤔

I think they're unrelated. This proposal is suggesting a way to prefix channel names, which I'd highly discourage now that we can associate channels with servers. And in v3 you'll be able to fully reuse channels so no need for it IMHO. But yeah, not sure what does it have to do with this proposal here 🤔

The fact that just one field could work for both features. I just wanted to mention it here. Of course, it could be done by selecting a tag for the prefix. But not important to this issue.

🤔 If we ever implement support for channel prefix, I don't think it should be a tag. That would be super unexpected 😅

I would prefer to go in the direction of something more generic like the mentioned tags, but there is one problem, because currently tags work like classic tags, so their key (the name field) is treated as a value. What do you think about adding an optional values field, which would specify what value is under a given key. Example:
- name: environment
  values: [production, ...]

Note: we can also introduce it in the 2.x.x, because it won't be breaking change.

Why a list of values and not a single value? In the case of the environment it's not that necessary, but for other keys there may be a need to define several values for better filtering, e.g. adding a given server etc to the given groups.
Thanks to such solution it would be possible to filter (in Studio and html-template) by given type of object (server/operation etc) and key and tag value.
Additionally, we could always create official tags (just like Kubernetes has created official labels, which can be overwritten, but then the tooling stops working) - like this one channelContext, which would define appropriate behavior? What do you think about it?

I would prefer to go in the direction of something more generic like the mentioned tags, but there is one problem, because currently tags work like classic tags, so their key (the name field) is treated as a value. What do you think about adding an optional values field, which would specify what value(s) for given tag. Example:
- name: environment
  values: [production, ...]

Note: we can also introduce it in the 2.x.x, because it won't be breaking change.

Why a list of values and not a single value? In the case of the environment it's not that necessary, but for other keys there may be a need to define several values for better filtering, e.g. adding a given server etc to the given group(s).
Thanks to such solution it would be possible to filter (in Studio and html-template) by given type of object (server/operation etc) and key and tag value.
Additionally, we could always create official tags (just like Kubernetes has created official labels, which can be overwritten, but then the tooling stops working) - like this one channelContext, which would define appropriate behavior? What do you think about it?

The reality is that with current tags you can make it work by composing a unique tag, such as name: "env:prod". The same could work for multiple values, i.e. name: "owner:platform,product" or declare multiple tags with different names (one for owner:platform, another with owner:product.
However, this gives too much flexibility to users, but it will penalize tooling and it's UX since no format standard will be in place. Especially hard when displaying those tags in documentation, or when filtering by any of those tags. For example, filtering by the owner tag above.
Regarding your suggestion @magicmatatjahu, I like the idea of adding a new field for declaring the value. We should be mindful that by allowing multiple values, filters/selectors will be harder to implement because you will need to specify which strategy the user wants to follow (so implementation as well), especially around inclusion/exclusion of values.
For example, let's say I have the following tags:
- name: privacy-policy
  values: [soc, soc1, soc2, gdpr]

Scenario: I want to select servers with only the policy gdpr
Scenario: I want to select servers that at least  have the policy gdpr

Another alternative solution for not having an array in there will be to declare the same tag multiple times but with different value. But this is just the same afaik.

Yeah, but have in mind that this "problem" is in tooling side, not in the spec itself.

Yes, totally agree.

I created the following PR's for adding the values field to the Tag Object:

Spec: https://github.com/asyncapi/spec/pull/744
spec-json-schemas: https://github.com/asyncapi/spec-json-schemas/pull/191

If we finally move forward, I will then create a new PR allowing Tags to be defined at server level.
cc @magicmatatjahu @fmvilas @ekozynin @dalelane

Well, yes, I know, I'm pretty late in this convo, but still.. 😄
After looking on the PR and also this issue I'm not sure what use case are we exactly solving. I saw description about concept with file with common servers, I also saw this:
# common.asyncapi.yaml
components:
  servers:
    yavin04.yavin.systems-http:
      url: https://api.yavin.systems:8080
      group: yavin04.yavin.systems
      protocol: http
    yavin04.yavin.systems-websocket:
      url: https://ws.yavin.systems:5000
      group: yavin04.yavin.systems
      protocol: was

but I do not understand how it helps. Would you expect a kind of possibility to reference from my asyncapi file to common.asyncapi.yaml with something like common.asyncapi.yaml#/components/servers/yavin04.yavin.systems or common.asyncapi.yaml#/components/servers/#group/yavin04.yavin.systems (this one seems to be odd). And how would that be resolved?
The only use case I see is from a documentation perspective, that you can somehow mark a set of servers as test so it is visible clearly in documentation. Then during generation, I can also say, do not generate code for given server name but server environment. Reusing current Tag object is not much useful IMHO. How about getting inspiration from Open Service Broker API Spec? They have a dedicated metadata blob object that users can use for whatever they want, but there is some official convention. Maybe Tag object could have a type property and agreed convention would be any or environment.
Anyway, my entire convo is about the fact that I can see only one use case - environments, that some time ago was already brought in, when we talked about connecting "servers" with specific "channels"

Would you expect a kind of possibility to reference from my asyncapi file to common.asyncapi.yaml with something like common.asyncapi.yaml#/components/servers/yavin04.yavin.systems or common.asyncapi.yaml#/components/servers/#group/yavin04.yavin.systems (this one seems to be odd). And how would that be resolved?

No, I wouldn't expect that at all. If we wanted to somehow do that we would need to change how servers are defined, like:
servers:
  development:
    server1:
      url: https://api.foo.systems:8080
      protocol: http
    server2:
      url: https://ws.foo.systems:5000
      protocol: was

Which I don't think it is ideal nor needed.

The only use case I see is from a documentation perspective, that you can somehow mark a set of servers as test so it is visible clearly in the documentation. Then during generation, I can also say, do not generate code for given server name but server environment.

Exactly, that's the right case at this moment. As you can see, we just need a way of marking servers with a tag or label, that can be added to any servers.

How about getting inspiration from Open Service Broker API Spec?

I took a look at it. Even though I see Metadata-style object could be a fit, it seems that Metadata's purpose is not categorize or group things together. However, I we read the tags description beginning:

Tags provide a flexible mechanism to expose a classification, attribute, or base technology of a service...

Which made me give another think to this. See below.

Reusing current Tag object is not much useful IMHO.

At this moment, and after giving several thoughts, I'm more convinced than ever about the fact Tags are enough for what we need here. Let me explain it.
By reading our current description or what Tags are for, it reveals the nature of it, which is adding metadata to resources that can be used for grouping:

At the AsyncAPI level:

A list of tags used by the specification with additional metadata.

At Operation level:

A list of tags for API documentation control. Tags can be used for logical grouping of operations.

At Message level:

A list of tags for API documentation control. Tags can be used for logical grouping of messages.

The question I'm doing myself is: Should we really add this new values field?
I pronounced earlier about this with:

The reality is that with current tags you can make it work by composing a unique tag, such as name: "env:prod". The same could work for multiple values, i.e. name: "owner:platform,product" or declare multiple tags with different names (one for owner:platform, another with owner:product.
However, this gives too much flexibility to users, but it will penalize tooling and it's UX since no format standard will be in place. Especially hard when displaying those tags in documentation, or when filtering by any of those tags. For example, filtering by the owner tag above.

But the reality is that everything is possible. For most of the use cases, composable tags (i.e. owner: team_a, team_b) are not needed. Grouping by environment, service name, or other value can be done by setting the tag -name: "env:prod". In the case we need to add multiple values, multiple tags can be added:
- name: "env:prod"
- name: "env:dev"

However, In the case we need composable tag names, such as  owner: team_a, team_b, people will need to look for a workaround such as:
- name: "owner:team_a"
- name: "owner:team_b"

In summary, I would say we could go a discard this PR, and rather write some examples or even an optional format convention (like the one I suggested in my examples above) that can be later on supported by tooling.
Do you think it makes more sense to use Tags now @derberg ? cc @magicmatatjahu  @fmvilas @dalelane

For reference: Maybe there are more use cases or needs for Tags. https://github.com/asyncapi/spec/pull/744

I'm going to create an RFC adding Tags to the Server Object. Candidate for 2.5.0 version of the spec.

PRs adding support for Tags at Server level:

Spec https://github.com/asyncapi/spec/pull/809
JSON Schemas: https://github.com/asyncapi/spec-json-schemas/pull/232
Parser-JS: https://github.com/asyncapi/parser-js/pull/565

Recent comments about the release from the bot were added by mistake. More details in https://github.com/asyncapi/spec/issues/899


Allow setting custom line numbers

This is a bit of an edge case ... In C there is a #line macro that allows setting the current line number, it looks like this:
void f();
int main() {
    #line 1
    return f();
}
<stdin>:1:12: error: returning 'void' from a function with incompatible result type
      'int'

Note how the error message says the error occurs on line 1, not line 4.
Currently, it looks like the lines in a file are calculated once and can't be modified. Would it be possible to make the line numbers configurable?
This has the unfortunate complication that there's no longer a 1-1 mapping between the line numbers displayed to the user and the lines in a file: in my example above, there are 2 lines with line number 1. However, this corresponds pretty closely to the current difference between LineIndex (internal) and LineNumber (user-facing) so I don't forsee it being a giant deal.

Ahh wow! That is a pretty challenging use case? Any idea how we might be able to support this?

It looks like currently we store a Vec, where finding the start of the line is found by indexing into the vec using the line index. I think this is fine: the frontend wants to know the span for the physical line, not for the logical line.
The only thing that needs to change is LineIndex::number(). Currently that just returns self.0 + 1. Maybe instead we could store a BTreeMap of physical lines -> offsets, where the offset records the difference between the physical line and the logical line (line changes within a column is way more than I need and would be harder, I don't think we need to support it). For example, given the following code:
// blank
#line 1
int main() {}
#line 10
int f() {}

the offsets would look like { 2: -1, 4: 6 }. Then to find the logical line for a physical line, you look up the first entry before and add that value to the physical line. So to get the logical line for physical line 6 (int f() {}), we'd find the first entry before was 4: 6 and return 6 + 6 = 12 for the logical line.
Let me know if that sounds doable.

Oh forgot to mention: the API would look something like Files::add_line_offset(&mut self, file: FileId, byte_index: ByteIndex) and we would look up the appropriate line number for that index. I have no opinions on what should happen if it's called multiple times for the same line, maybe just overwrite the existing offset?

@Marwes would this help you out with macro support on Gluon?

Wondering if we could have a Files::line_number method:
pub trait Files {
    ⋮
    /// The line number of the line at the given line index.
    fn line_number(&self, id: Self::FileId, line_index: usize) -> Option<usize>;
    ⋮
}


Ansible guide improvements

The zulu addition fails on the test Vagrant with:
fatal: [localhost]: FAILED! => {"failed": true, "msg": "An unhandled exception occurred while running the lookup plugin 'file'. Error was a <class 'ansible.errors.AnsibleError'>, original message: could not locate file in lookup: /Vendor_Files/keys/id_rsa.pub"})`

Azul ppa fails for me as well not related to this PR though

@neomatrix369 we should try to resolve the:
fatal: [localhost]: FAILED! => {"failed": true, "msg": "An unhandled exception occurred while running the lookup plugin 'file'. Error was a <class 'ansible.errors.AnsibleError'>, original message: could not locate file in lookup: /Vendor_Files/keys/id_rsa.pub"})

issue, so we've got a confirmed test in the Vagrant'd test host.

@karianna I did get this as well, yes lets try to resolve this before we merge the PR

@karianna did you have any luck finding out what the issue is?

@neomatrix369 Not yet no sorry, let's discuss in Slack

@neomatrix369 I think this is good to go again as this is just doc changes now.  We can raise a separate issue for the failing test ansible vagrant thing

In https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/58#issuecomment-347155454, you mean the vagrant instance is our test host?
https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/58#issuecomment-347463749 - Agree, lets rasie a separate issue for this

Yes vagrant as test image - are you able to set this review to approved?

@karianna I don't have rights to approval/merge PRs, will merge PR is added to reviewers list


AzCopy keep handling some files after those are transferred

When I transferred 20,000 files to Azure Files by AzCopy, I found that AzCopy process keep handling some files after those are transferred. I confirmed that the resource lock was finished after AzCopy transferred all of 20,000 files. I think this behavior is very inconvenient because we can not open those files during transfer. If the number of files is so many and the volume is big, the period of the release lock will be too long. I also confirmed that robocopy is different behavior. It releases the lock immediately after transferred but its performance is worse than AzCopy. I hope AzCopy will be enhanced this behavior.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd2ee3a6-a4ae-068a-1a7e-9a81877e1a21
Version Independent ID: 57abfa84-1c27-6dcc-f757-bc3c90e6e6b0
Content: Transfer data to or from Azure Files by using AzCopy v10
Content Source: articles/storage/common/storage-use-azcopy-files.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@ms-ishiyam
Thanks for your feedback! We will investigate and update as appropriate.

@ms-ishiyam  Firstly apologies for the delay in responding here!
Find errors and resume jobs by using log and plan files in AzCopy](https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-configure)
Troubleshoot problems with AzCopy v10
Optimize the performance of AzCopy with Azure Storage
I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Replace all wget with curl

Summary
wget is missing from some system (like macOS and Windows native), it's better to use curl to simplify build environment.
Impact
None
Testing
Test build with stm32f429i-disco on Mac

@no1wudi please do the same replacement in nuttx too.

please add commit description (the same as the PR message should be ok )

Any other uses of wget anywhere else on NuttX? If not, you could look into removing any reference to wget from documentation.

curl should be added to the required tools in the top-level README.md file.  That provides the "getting started" info that people need to know.
I am not sure if there are other tools lists under Documentation/ because I am no long familiar with that.  It is worth checking.

How about in the windows native environment?  Would the user need to install something like:
https://curl.se/windows/
https://develop.zendesk.com/hc/en-us/articles/360001068567-Installing-and-using-cURL

The Windows native build has other problems more significant that this.  It is probably sufficient to know that some solution exists.  Cygwin or MSYS are more typical environments and curl is available under Cygwin (don't know about MSYS).

How about in the windows native environment? Would the user need to install something like:
https://curl.se/windows/
https://develop.zendesk.com/hc/en-us/articles/360001068567-Installing-and-using-cURL

The Windows native build has other problems more significant that this. It is probably sufficient to know that some solution exists. Cygwin or MSYS are more typical environments and curl is available under Cygwin (don't know about MSYS).

Now curl is installed on Windows native by default (tested on my Windows 20H2).

please add commit description (the same as the PR message should be ok )

commit message updated

curl is much better than wget from compatibility perspective:

let's merge it.


Throw an error if provided with non-modifier keys

Fixes #4.
Idea: check if the value is not a single-length character, not in MODIFIERS, not inALIASES and not in CODES.
If all these conditions are true, throw a TypeError.
This is a potentially breaking change, but the code which would trigger this error is already (silently) broken.

Hey @markogresak, how does this work with the byKey option for things like the page down key? I haven't looked deeper to see if it still supports that.

@ianstormtaylor yes it does. I have updated the test to make sure.
Force pushed a bit after the initial change to amend a small typo.

Thank you @markogresak! I'm sorry I must have missed the notification on this so long ago. But this is a great PR, I appreciate it.


bigtable appengine standard

I have not seen examples of use bigtable from appengine standard can it be used?

@lesv Do you know the status of this?

I haven't tried Go, it seems like it should work.  (Unlike Java or Python).
The issue should be making sure the AppEngine context is passed to gRPC.  I've heard that it does.
@broady Care to confirm?
@albertog Do you need an example to move forward?

It will be usable, but it's likely quite slow.


operator bool

Not sure if it's a bug (maybe it's expected behavior because of bool?), but if you define a custom data type with operator bool (regardless of return value) and operator <<, then formatting doesn't work.
Example code:
#include <iostream>
#include <string>
#include "cppformat/format.h"

struct Date {
    operator bool() const { return true; }
    friend
    std::ostream& operator << (std::ostream& os, const Date& date) { return os << "1.1.1970"; }
};

int main() {
    std::cout << "date is " << Date{} << "\n";
    std::cout << fmt::format("date is {}\n", Date{}); // prints "date is 1"
}

I think this has been fixed already in https://github.com/cppformat/cppformat/commit/6cff6d81374fef37bedc3f82eefb9a01ee48e60b. The commit message mentions enums but the same applies for any type implicitly convertible to int. Using the current master branch I get:
date is 1.1.1970
date is 1.1.1970

Ah yes, apologies. I wasn't using the latest version. It's working with operator bool defined. Thanks.

No problems. Thanks for the confirmation.


Prevent refreshing the SecurityContext on OAuth Logins

changes from #2016 to refresh the SecurityContext when updating the current UserInfo object are causing a stack overflow when users authenticate using a 3rd party OAuth provider.  Refreshing the SecurityContext is unnecessary in this scenario and should not be attempted.

PR: #2019


Can't get FireFox to start with cmdline args (custom profile) (Win10)

Eel version
Main, latest commit https://github.com/python-eel/Eel/commit/505176162e0bc339be843e6e9a5d205fa20c0837
Describe the bug
Firefox won't run with flag commands. Following the instructions I've see I should be doing (this is from an edited file_access example):
import eel, os, random
import eel.browsers
eel.browsers.set_path('firefox', 'C:\Program Files\Mozilla Firefox\firefox.exe')
brmode = 'firefox'
...
eel.start('file_access.html', size=(320, 120), mode=brmode, cmdline_args=["--new-instance ", "-P 'app' ", "--new-window"])
To Reproduce
Steps to reproduce the behavior, start eel on windows 10 with Firefox 109.0.1 and make a custom profile (I am using one with a modified userChrome.css so that I can recreate a windows xp styled window.)
Expected behavior
Firefox should be able to receive the cmdline arguments just as it does when these arguments are ran from the command line or Win+R.
System Information

OS: Windows 10 x64
Browser: Firefox 109.0.1 (64-bit)
Python Distribution: Python 3.7.9

Hello,
So I got Firefox to open using custom as the mode, this then runs the cmdline_args specified
eel.start(
    "main.html",
    mode="custom",
    port=8000,
    cmdline_args=[
        r"C:\Program Files\Mozilla Firefox\firefox.exe",
        "https://localhost:8000",
        "--new-instance ",
        "-P 'app' ",
        "--new-window",
    ],
)

The above opened my "Hello World" page in Firefox, not sure if the other args worked, "--kiosk" does make it Fullscreen so they are being passed to Firefox but I'm not exactly sure what the profiles do in Firefox.
Thanks

Doug


Prevent UI lockup caused by PubSub race condition

When running tests multiple times, occasionally we see an error "HTTP request for phase descriptors failed." in the web UI when a test completes, preventing us from starting the test again.
From some sleuthing in the web ui console, I noticed that the PubSub websocket publishes (what it believes to be) the test UID of the currently running test. The web ui then requests tests/<test_uid>/phases, which should return the phase info for that test. However, when we see this error, I noticed that it's sending the request of the previous test. The python only stores the information of the currently running test, and so the request for the previous test info fails.
The issue here (I believe) is that when a test is finishing and a new test is started, the event for the previous test finishing arrives after the notification for the new test starting. This means we store the UID of the previous test in StationPubSub, and incorrectly report that test UID to the webui, causing it to request the phase info for the old test.
My hacky workaround for this is to only allow changing the UID for the test when we've never seen the test UID before. If we see an update for an old test, we refuse to update the uid.

Damn, I've managed to still encounter the error :disappointed:
Will keep investigating as this affects us a lot

Damn, I've managed to still encounter the error 😞 Will keep investigating as this affects us a lot

Should we just change the front end to re-request the current id when this failure occurs? I can have a look at this after the festivities.


Refactor enzyme to use Adapters, initial React 16 support

to: @ljharb @aweary @nfcampos @blainekasten
cc: @sebmarkbage @developit @bvaughn
This PR is effectively a rewrite of Enzyme's internal machinery, per the discussion outlined in https://github.com/airbnb/enzyme/pull/742
I attempted to make this as small of a breaking change as pragmatically possible, and minimize the amount our current unit tests needed to be changed across the refactor.
Motivation
This PR attempts to address a handful of pain points that Enzyme has been
subject to for quite a while.
The desired results are the following:
Cleaner code, easier maintenance, less bug prone.
By standardizing on a single tree specification, the implementation of Enzyme would no longer have
to take into account the matrix of supported structures and nuanced differences between different
versions of React, as well as to some extent the differences between mount and shallow.
Additional libraries can provide compatible adapters
React API-compatible libraries such as preact and inferno will be able to provide adapters to Enzyme
for their corresponding libraries, and be able to take full advantage of Enzyme's APIs.
Better user experience (ie, bundlers won't complain about missing deps)
Enzyme has had a long-standing issue with static-analysis bundlers such as Webpack and Browserify because
of our usage of internal React APIs. With this change, this is minimized to the adapter implementations only, which will be imported separately, so bundlers will not have any of these problems.
Standardization and interopability with other tools
With an agreed on tree format, other tools can start to use and
understand this format as well. Standardization is a good thing, and could allow tools to be built that maybe
don't even exist yet.
Things left to do before merging this PR:

[ ] clarify changes in documentation
[ ] complete migration guide
[ ] add in support for keys

Things left to do before publishing Enzyme 3.0:

Followup PR moving the adapters into their own packages
Publish alpha(s), get enzyme users to try it out and report back any issues (Airbnb at least will have to do this)
Implement new configurable top level API (debatable whether or not this is needed to publish 3.0)

What do you all think about adding pointers for nextSibling and prevSibling? I found that having sibling pointers made it much easier when doing later traversal. For example, checking adjacent or general siblings. Since we're already traversing the whole tree, it should just require a constant amount of extra time to attach these pointers.

@aweary doesn't that open up the possibility that nextSibling or prevSibling could be wrong? In other words, it gives the adapter the ability to hijack the traversal algorithm (or am I misunderstanding)

@ljharb we already trust that the adapter is returning an accurate RSTNode, so that doesn't sound like a problem to me. If we update the RSTNode type to include sibling pointers we're just extending the contract we're already requiring of adapters.

@lelandrichardson I tried this out on my tests and I ran into a couple of issues:

I had to call Enzyme.configure. I don't think users should be forced to call Enzyme.configure by default. Enzyme should work out-of-the-box. Also, require('enzyme/setupAdapters') in my test helper file didn't work for some reason.

Explicitly calling update looks like it isn't updating child props correctly (haven't really dug into this)

simulate (on a non-root node) is throwing an error Error: ReactWrapper::update() can only be called on the root

@TiraO "working out of the box by default" is the current state, and it's why we have issues with dependencies. It's important that users explicitly choose the version of React (or "not React") they're using.

@ljharb Fair enough. Would there be both a react 16 native adapter and a react 16 dom adapter?

@TiraO it would be possible to create one for each; i'm not sure what we're planning on releasing with, but the whole concept is that it's extensible.

Is<EMAIL_ADDRESS>based on this PR?
What about merging this PR into a branch like v3 and releasing alpha or beta versions from the branch?
It's helpful to track the progress of supporting React v16 and I can work on supporting React v16.

Is fragments support in TODOs?
The code including fragments seems not to work.

Any sense when a release might be made available with this change?

None yet.

any update on release with these changes?


Quick explanation in README/documentation?

I know it's probably a case of "if you don't know what it is, you don't need it", but I ran across this in the new webpack docs and have no idea what it does or how I could use it. Maybe a one or two sentence summary in the readme could clear that up. Something to do with the now deprecated component.js project?

I agree wholeheartedly.  I have no idea what this does at all.


[website][pulsar-client/pulsar-perf] pulsar-client and pulsar-perf cli doc command flag duplicated

Master Issue: #10040
Motivation
Support auto generate HTML page for pulsar client cli tool, for example: https://github.com/apache/pulsar/tree/asf-site/content/tools/pulsar-admin
Modifications
fix duplicated long and short command line parameter names for pulsar-client cli docs
fix duplicated long and short command line parameter names for pulsar-perf cli docs
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)
Documentation
Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Anonymitaet  @tuteng PTAL, thanks

/pulsarbot rerun-failure-checks

@urfreespace thanks for your contribution!

/pulsarbot rerun-failure-checks

@315157973 PTAL

/pulsarbot rerun-failure-checks

Unrelated test failures
Error:  testTokenProducerAndConsumer(org.apache.pulsar.client.api.TokenAuthenticatedProducerConsumerTest)  Time elapsed: 0.144 s  <<< FAILURE!
org.apache.pulsar.client.admin.PulsarAdminException$NotAuthorizedException: HTTP 401 Unauthorized
	at org.apache.pulsar.client.admin.internal.BaseResource.getApiException(BaseResource.java:228)
	at org.apache.pulsar.client.admin.internal.BaseResource$1.failed(BaseResource.java:130)
	at org.glassfish.jersey.client.JerseyInvocation$1.failed(JerseyInvocation.java:882)
	at org.glassfish.jersey.client.JerseyInvocation$1.completed(JerseyInvocation.java:863)

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

@tuteng Was automatically cancelled due to timeout?

/pulsarbot rerun-failure-checks

@tuteng Was automatically cancelled due to timeout?

Because the test run time exceeds 120 minutes


example_3 import error

Trying to run example_3.py with sample_mode="cpu", getting
$ python example_3.py --sample_mode cpu

Traceback (most recent call last):
  File "example_3.py", line 80, in <module>
    n_parallel=args.n_parallel,
  File "example_3.py", line 30, in build_and_train
    Sampler = CpuParallelSampler
NameError: name 'CpuParallelSampler' is not defined

I guess https://github.com/astooke/rlpyt/blob/master/examples/example_3.py#L30 should be
Sampler = CpuSampler

and https://github.com/astooke/rlpyt/blob/master/examples/example_3.py#L33
Sampler = GpuSampler

but not entirely sure since CpuParallelSampler does appear in some code

Yes that's right, thanks!  Have fixed these.
CpuParallelSampler was an old name I should go through and clean up...the experiments folder has many old scripts in it.

Thanks, looks fixed!


Multiple definition issue due to explicit function template specialization

On AVX512 builds there are multiple definitions of some functions, e.g. avx512_qsort, see https://github.com/numpy/numpy/issues/25274
Reason is that the explicit specialization of the function template is not declared inline. See cppreference:

Whether an explicit specialization of a function [...] template is inline/constexpr(since C++11) [...] is determined by the explicit specialization itself, regardless of whether the primary template is declared with that specifier

And e.g. template <> void avx512_qsort(_Float16 *arr, arrsize_t arrsize, bool hasnan) has no inline and hence could be define by multiple translation units, see the source: https://github.com/intel/x86-simd-sort/blob/d9c97379049cd549d5e386849d744c31f21a2f83/src/avx512fp16-16bit-qsort.hpp#L180
The issue seems to also apply to pretty much every explicit function specialization, so it looks like a major fixup is required searching for "template <>" and marking all those functions defined in headers inline.

Hello @Flamefire Are you seeing this multiple definition problem outside of NumPy? The build problem reported in https://github.com/numpy/numpy/issues/25274 requires a fix in NumPy and not here (making those template initializations inline does not fix it).

@r-devulap Thanks for your reply and indeed I was referring to that numpy issue which is blocking a deployment on our new HPC partition. Although there might be an additional bug in numpy I think my argument is still valid and this is a bug in this library as I tried to show with the cppreference quote. So the issue I described causing multiple definitions happens whenever linking together 2 translation units that included x86-simd-sort/src/avx512fp16-16bit-qsort.hpp
See this reduced example:
$ cat a.cpp
#include "foo.hpp"
$ cat b.cpp
#include "foo.hpp"
$ cat foo.hpp
template<typename T>
int foo(T x){ return x; }

template<>
int foo(unsigned x){ return x + 1; }
$ g++ -c -fPIC a.cpp -o a.o && g++ -c -fPIC b.cpp -o b.o && g++ -shared -o lib.so a.o b.o
/usr/bin/ld: b.o: in function `int foo<unsigned int>(unsigned int)':
b.cpp:(.text+0x0): multiple definition of `int foo<unsigned int>(unsigned int)'; a.o:a.cpp:(.text+0x0): first defined here
collect2: error: ld returned 1 exit status

So merely including the header not even using the function causes the double definition.

I just tested the numpy bug and marking those 2 functions inline avoided the double definition issue, i.e. with this patch:
diff --git a/src/avx512fp16-16bit-qsort.hpp b/src/avx512fp16-16bit-qsort.hpp
index 8a9a49e..1206f82 100644
--- a/src/avx512fp16-16bit-qsort.hpp
+++ b/src/avx512fp16-16bit-qsort.hpp
@@ -145,7 +145,7 @@ replace_inf_with_nan(_Float16 *arr, int64_t arrsize, int64_t nan_count)
 }

 template <>
-void avx512_qselect(_Float16 *arr, int64_t k, int64_t arrsize)
+inline void avx512_qselect(_Float16 *arr, int64_t k, int64_t arrsize)
 {
     if (arrsize > 1) {
         int64_t nan_count = replace_nan_with_inf(arr, arrsize);
@@ -156,7 +156,7 @@ void avx512_qselect(_Float16 *arr, int64_t k, int64_t arrsize)
 }

 template <>
-void avx512_qsort(_Float16 *arr, int64_t arrsize)
+inline void avx512_qsort(_Float16 *arr, int64_t arrsize)
 {
     if (arrsize > 1) {
         int64_t nan_count = replace_nan_with_inf(arr, arrsize);

However this could lead to ODR violations in the numpy case as the functions are (there) compiled in different TUs with different AVX-flags enabled and hence are not "the same under ODR" anymore.
In the commit 85fbe7d1abca3b9a224ba1c62d52afe9a180f8ef used by numpy I see many functions marked with X86_SIMD_SORT_INLINE i.e. static inline. That yields a unique definition per TU and hence the multiple differently compiled functions are not merged and hence are valid when linked together.

I assume I can close this now.


crvd fails with TotalPartsExceeded on very large S3 objects

Steps to reproduce:
Execute the command below:
cos crvd -v s3://<BUCKET>/ --endpoint https://s3.us-west-2.amazonaws.com/ --size 1T

Expected:
Upload completes in about 4 hours (assuming a fast client network)
Actual
Upload fails at 50G with:
Error: MultipartUpload: upload multipart failed
	upload id: iuCCRxEvNJGjfH_ZoA30A1JyUqUxrZkyGJpymOIb8VWq1Yb.ysFPqMaGZQgvRDR4PjFdgsoKn8TvH.ZfoKTdyRMTkx442X9_gD8N5oMiHyLtoVSlPm_nfxY1o3Km.42le_ZTxp_1ZYwpOoqb4SbWcQ--
caused by: TotalPartsExceeded: exceeded total allowed configured MaxUploadParts (10000). Adjust PartSize to fit in this limit

I put in a fix to set PartSize to make sure MaxUploadParts isn't exceeded. It looks, though, like the S3 SDK wants to keep the entire part in memory, which means the maximum object size we can upload is still limited by available RAM.
On a smallish EC2 instance with 2 GB RAM, it seems like a 128 MiB PartSize is OK, but 1 GiB leads to OOM errors after uploading a few gigabytes. At 128 MiB and a maximum of 10K parts, we'd be limited to about 1.22 TiB or 1.34 TB.
It would be good to keep digging in the API and see what facilities there are for explicit multipart uploads.


Output needed from exec plugin

Hi guys!
I tried to write a script to send metrics via exec plugin, but i didn't fund the correct JSON output format.
Can you add in documentation an example with JSON output?

@jpalay @alvaromorales Could one of you guys take care of this? And don't forget to sign up for Hacktoberfest https://hacktoberfest.digitalocean.com/ ;-)


Fix #10478: tags updation issue for schemaFields and tasks

Describe your changes :

I worked on fixing #10478
Added unit tests and cypress tests for the same
For issues with adding tags to the tasks for pipeline entities, the API response for the PATCH API is received as successful but the tags are not actually being added to the tasks. I have raised an issue for the same here -> #10482

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :

https://user-images.githubusercontent.com/51777795/224067052-e2e74214-a94a-4189-95c4-7f116480c4a8.mov

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

@aniketkatkar97 initial testing looks good to me. I need more time to test it with lot more data and filters. But lets merge it in for now and we can incrementally address it cc @chirag-madlani


Add pxe_tag feature to allow tagging of pxe_servers and all children that support it

pxe/tagging_edit is the entrypoint route for all tagging on pxe servers, etc.:
rake routes |grep -E "pxe.+tag"
                                                              GET              /pxe/tagging_edit(/:id)(.:format)                                                                pxe#tagging_edit
                                                              POST             /pxe/tagging_edit(/:id)(.:format)                                                                pxe#tagging_edit

tagging_edit defaults to looking for a product feature built from the controller
for common methods followed by "_tag" or in this case, pxe_tag:
https://github.com/ManageIQ/manageiq-ui-classic/blob/7f0739dd6bfb98027af227f59210b9d2c30acd2c/app/controllers/application_controller/tags.rb#L6
Followup to #21222
This will fix the last failure on https://github.com/ManageIQ/manageiq-ui-classic/pull/7740

Backported to lasker in commit 110a6268a8ec8be593346dae9159d7e19c3f5d61.
commit 110a6268a8ec8be593346dae9159d7e19c3f5d61
Author: Jason Frey<EMAIL_ADDRESS>Date:   Fri May 21 10:23:12 2021 -0400

    Merge pull request #21230 from jrafanie/add_higher_level_pxe_tag_to_allow_tagging_for_children

    Add pxe_tag feature to allow tagging of pxe_servers and all children that support it

    (cherry picked from commit 111d625b504ea89edf5a785f803d4e3f0c50d7cc)


Make the API closer to TF

We want to have an improved API for TFE. The goal is to be as close as possible to TF, so people don't have to learn another API on top of TF.
More precisely this issue focus on transforming the TFE logistic regression example so it looks the same as the TF example.
This include:

[ ] Allows define_private_input to accept a TF.Tensor directly (add a warning for security implication)
[ ] Allows define_private_variable to accept a shape and a random algo name directly to avoid importing TensorFlow
[ ] Add a default LocalConfig that will be used by a protocol (Add a warning)
[ ] Add a default protocol that will be used by default when calling operations (tfe.matmul ...)

some ideas in https://github.com/mortendahl/tf-encrypted/issues/149 as well

Allows define_private_input to accept a TF.Tensor directly (add a warning for security implication)

My main concern here is that it's ignoring the main difference between TF and TFE: that in TFE it's important who knows which values. However, if the warning is big enough then maybe this is okay as a way of quickly prototyping stuff. See also #149 though for ideas on how to make the InputProvider interface simpler to work with, although it doesn't remove the need for some computations to be moved under a function.
Another issue that's not clear here is how we'll mix in numpy (used eg by keras datasets), as that's a popular way of loading/preprocessing data. In the mnist demo for instance, I had to manually convert the simple keras data loading into something that works directly with tf.tensors.

Allows define_private_variable to accept a shape and a random algo name directly to avoid importing TensorFlow

Makes a lot of sense! We need to make it clear whether the initial value is public or private but that's a minor detail.

Add a default LocalConfig that will be used by a protocol (Add a warning)

Like it! We can even allow people to specify it up front with eg tfe.set_config() to also make it easier to use remote configs

Add a default protocol that will be used by default when calling operations (tfe.matmul ...)

Yes!


Consume Catch2 nuget package instead of as a submodule

Closing this, as the Catch2 nuget version is old and has bugs. So we will continue to use as submodule.


Example:
{{#foo}}

{{/foo}}

Will report a TextNode inside the BlockStatement with chars: '\n' while this should be chars: '\n\n'.
I would also accept the start location of the TextNode to be on the new line.

It is actually "correct". A block statement or mustache statement will "eat" a newline if it follows directly after the mustaches.

This is a default feature of the Handlebars parser. We can disable it but it is a breaking change. See
https://github.com/wycats/handlebars.js/issues/1072 and https://github.com/wycats/handlebars.js/commit/ea3a5a1.


⚠ Fetchers has degraded performance

In e9796a4, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 315 ms

Resolved: Fetchers performance has improved in f501f86.


Page not founded (404) on javascript cli quickstart link

When switched to "Angular for Javascript", the CLI QuickStart link points to a 404 page (https://angular.io/docs/js/latest/undefined)

We don't have documentation for that, so it is normal it gives undefined.
We are about going to a new site so I am closing this


AKS: VNET and NSG not listed with resource-group option

Describe the bug
Sometimes, the commands for listing VNETs and NSGs return empty for up to 20min. after (aks automatic) creation, if --resource-group is used - at the same time the respective resources are included (with the correct resource-group) listed within all VNET resources, e.g. with just az network vnet list or az network nsg list
To Reproduce

Create AKS cluster using the cli and az aks create
Get kubeconfig with az aks get-credentials
Wait for nodes to become ready
try to get the NSG name with az network nsg list --resource-group=$AZ_MC_RG_NAME

> az network vnet list
[
  {
    "addressSpace": {
      "addressPrefixes": [
        "<IP_ADDRESS>/8"
      ]
    },
    "bgpCommunities": null,
    "ddosProtectionPlan": null,
    "dhcpOptions": null,
    "enableDdosProtection": false,
    "enableVmProtection": null,
    "etag": "*******",
    "extendedLocation": null,
    "flowTimeoutInMinutes": null,
    "id": "/subscriptions/*******/resourceGroups/MC_test-test1-aks_test_eastus/providers/Microsoft.Network/virtualNetworks/aks-vnet-12345678",
    "ipAllocations": null,
    "location": "eastus",
    "name": "aks-vnet-12345678",
    "provisioningState": "Succeeded",
    "resourceGroup": "MC_test-test1-aks_test_eastus",
    "resourceGuid": "*********",
    "subnets": [
...
    "tags": null,
    "type": "Microsoft.Network/virtualNetworks",
    "virtualNetworkPeerings": []
  }
]

... just works without -g option.
> az network vnet list -g MC_test-test1-aks_test_eastus
[]

... and this can succeed right away, but often takes between 10-20min.,
until the correct content is shown, like above.
Expected behavior
automatically created VNET or NSG get listed for the given MC_Resource-Group, e.g. aks-agentpool-12345678-nsg when they are available
Environment summary
azure-cli-2.26.1-1.el7.x86_64 on openSUSE Leap 15.3

route to service team


Crossbow Cavalry Perk doesn't work

I have the perk Crossbow Cavalry which is supposed to allow me to reload any crossbow on horseback, but nothing happens when I try to reload mine.

 No wonder it wasn't working...


error while fetching extensions XHR failed

I don't install extensions, because always "error while fetching extensions XHR failed".

Seems like it is your network issue connecting to the Marketplace. Please open the network tab (F1 > Toggle Developer Tools) and check the network error.

thank you. after that, what should I do?

Can you please click on the row and let us know the complete error

ok, here's to more details

Seems like you are behind a Proxy set up and it is preventing to connect to MP.
@chrmarti @deepak1556 Can you please help user to fix the proxy issue.

thank you, can you help with the proxy?

@FahmiMaulana98 Could you post the full error message here? In the screenshot some of it isn't visible.

This is for the detailed message. is there anything else, that I should show for details?

Bump. Currently facing the same issue

@FahmiMaulana98 This looks like https://github.com/microsoft/vscode/issues/34385.
@Fortranibal Does this always occur or does, e.g., restarting VS Code help?
One test you could do is: Install the Network Proxy Test extension (https://marketplace.visualstudio.com/items?itemName=chrmarti.network-proxy-test) and check the output of F1 > Network Proxy Test: Test Connection in VS Code.
If you cannot install the extension through the Extensions viewlet in VS Code, you can use the Download Extension link on the above linked page and then install the downloaded VSIX with F1 > Extensions: Install VSIX....

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


use of map in configuration.cpp

in configuration.cpp line187:
pSection = &it.first->second;
I think it should change to as follow:
pSection = &it->second

Hi tingxun,
Thanks for your submitted issue. The current code runs ok, but you may try your idea and see whether it compiles and works.
Thanks,
Zhenyu


BJ266-1

Ⅰ. Describe what this PR did
write unit test 1913
Ⅱ. Does this pull request fix one issue?

fix #1913
Ⅲ. Describe how you did it
我写了测试用例
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

We have merged  a PR which solve the same problem
Thanks for your work
Close this now :)


[fix] (inverted index) fix the error result in the query when using count on index (#42346)

Proposed changes
pick from master #42346

run buildall

run buildall


[EASY] Consistent file naming conventions

Simplifies naming scheme to make things more clear and avoid repeating the full tree in the file names. Also moves aliases to import statements to simplicity.
Test plan
All unit tests still passing.

@bhancock8 ready for another look! Also moved Dask out of module init.py imports since it's not a core dependency.


Chapter with broken images can't be rendered

When zip.js trys to uncompress these broken images, it will throw header error. But foliate.js doesn't properly catch these error which aborts the whole rendering process.
The example files:
Richard.W.Hamming.-.The.Art.Of.Probability-CRC.Press.2018.1.zip
How to reproduce:

Import this book in https://johnfactotum.github.io/foliate-js/reader.html
Click Chapter 1 Probability

Perhaps one should just catch this in the loadBlob function and return an empty Blob (or even a custom placeholder image, if you're feeling fancy)?


jlab4 updates | doc updates

code updates to support jlab4 API changes
added new docs
updated package dependencies to latest/near-latest versions
updated README install instructions
integrated playwright framework for UI testing

Package published to testPyPi:
pip install -i https://test.pypi.org/simple/ maap-user-workspace-management-jupyter-extension

Waiting to accept this PR until the get presigned url bug is fixed: https://github.com/MAAP-Project/Community/issues/979#issuecomment-2130308369


feat: delete scm webhook when disable repo.

when disable repo, drone delete scm webhook.
for this issue: https://discourse.drone.io/t/disabling-repo-on-drone-does-not-delete-webhook/5146

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for the pull request.  a few comments

deleting the webhook should probably come after the database update
if deleting the webhook fails it should output warning logs, but should not fail the API call. There are valid scenarios where we expect deleting the webhook to fail (for example, repo was deleted in github)
the repo owner should be used when making the API call. see https://github.com/drone/drone/blob/master/handler/api/repos/builds/create.go#L52. If returning the owner from the database fails, it should not fail the api call, and deleting the webhook should be skipped.

thanks for the pull request. a few comments

deleting the webhook should probably come after the database update
if deleting the webhook fails it should output warning logs, but should not fail the API call. There are valid scenarios where we expect deleting the webhook to fail (for example, repo was deleted in github)
the repo owner should be used when making the API call. see https://github.com/drone/drone/blob/master/handler/api/repos/builds/create.go#L52. If returning the owner from the database fails, it should not fail the api call, and deleting the webhook should be skipped.

also please be sure to sign the CLA

thanks for reply.
i will check the code and

move delete func after update the database updated.
delete the return statement when webhook delete failed.
refer to the link and check the repo owner.
signed the CLA.

if there is any mistakes in comprehension, let me know.

This PR has been automatically closed due to inactivity.


Package import issue in ESmodule app

First of all, thanks for create this package =)
I'm beginner programmer of javascript.
So maybe not issue in this package...
My project is in service on ESmodule
I wanna use the class "TSIDGenerator"

So I imported like

import { TSIDGenerator } from 'tsid-ts';
but I confront error
======
/packages/tsid/lib/tsid.js:4
import { TSIDGenerator } from 'tsid-ts';
^^^^^^^^^^^^^
SyntaxError: Named export 'TSIDGenerator' not found. The requested module 'tsid-ts' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from 'tsid-ts';
const { TSIDGenerator } = pkg;
at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

Node.js v18.17.0

So I fixed my code as guidance

import pkg from 'tsid-ts'; const { TSIDGenerator } = pkg;
but this time is I have another problem like
=====
(node:787102) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use node --trace-warnings ... to show where the warning was created)
Waiting for the debugger to disconnect...
/node_modules/.pnpm/tsid-ts@0.0.6/node_modules/tsid-ts/dist/index.js:1
export * from './tsid';
^^^^^^
SyntaxError: Unexpected token 'export'
at internalCompileFunction (node:internal/vm:73:18)
at wrapSafe (node:internal/modules/cjs/loader:1178:20)
at Module._compile (node:internal/modules/cjs/loader:1220:27)
at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
at Module.load (node:internal/modules/cjs/loader:1119:32)
at Module._load (node:internal/modules/cjs/loader:960:12)
at ModuleWrap. (node:internal/modules/esm/translators:169:29)
at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
Node.js v18.17.0
======
My project already use "type": "module"

I couldn't understand that, so I tried to use to this package, several methods.

but I can't find to use this package without edit "tsid-ts"

I can use this package by editing like this,

first line is import { decode, encode, uniformInt } from './utils'; of dist/tsid.js
I just added ".js" like import { decode, encode, uniformInt } from './utils**.js**';
and I import like import { TSIDGenerator } from 'tsid-ts/dist/tsid.js';

I wanna use this pacakge without edit, just Warts and all

what can I do?

Hi @LeoniceHan,
The tsid-ts library was originally developed for TypeScript projects, but I've made some adjustments, and now it can also be used for regular JavaScript project as well.
Please upgrade tsid-ts to version 0.0.8 or above.

if the type of your JavaScript project is module
import { TSIDGenerator } from "tsid-ts";

const tsidGenerator = new TSIDGenerator();
const tsid = tsidGenerator.create();

console.log(tsid.toString());

if the type of your JavaScript project is commonjs
const { TSIDGenerator } = require("tsid-ts");

const tsidGenerator = new TSIDGenerator();
const tsid = tsidGenerator.create();

console.log(tsid.toString());

It works well!
Thanks yubin, I appreciate it.


FAQ's color is off for the dropdown questions

On the page https://docs.blockstack.org/references/faqs/general-information
Each of the questions is in a gray block with white text (very hard to read). It doesn't appear any css/js is missing/not loaded from the console either.
screenshot:

this seems fixed


Create 1822-sign-of-the-product-of-an-array.cpp

Efficient Solution of the 1822 number problem of the leetcode

File(s) Modified: 1822-sign-of-the-product-of-an-array.cpp
Language(s) Used: C++
Submission URL: _https://leetcode.com/problems/sign-of-the-product-of-an-array/submissions/980212472/_

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

This solution is similar to the existing solution


Making Home-Page more appealing

The "About ML Fusion Labs" section in homepage is very dull and not appealing.
Please assign me this issue under GSSoC-ext tag. I will also improve the Header since it is not same for all the pages and it is also not responsive.

@devanshaggarwal03 now it is looking good.
So i am closing this issue.


What are in the new versions?

Recently there was a shotgun of new versions - 0.71, 0.72, 0.8, 0.9; but the changelog only has 0.7 as the latest.  What is in the new versions, and why does it look like they were created without the standard commit/prepare?

https://github.com/square/sqldelight/blob/master/RELEASE_CANDIDATE.md


hal/nrf_i2s.h - No such file or directory

Trying to compile hello_world I get:
??????/libraries/Arduino_TensorFlowLite/src/peripherals/i2s_nrf52840.cpp:22:10: fatal error: hal/nrf_i2s.h: No such file or directory
#include <hal/nrf_i2s.h>
^~~~~~~~~~~~~~~
compilation terminated.
exit status 1
Error compiling for board Raspberry Pi Pico.

@ktorimaru
Thank you for bringing this issue to our attention.  Currently, the arduino-examples repository only has official support for a single board.  That board is the Arduino Nano 33 BLE Sense (using the NRF52840 SOC).  No other board or platform is currently officially supported by the codebase.
You are welcome to make modifications to your clone/fork of the codebase in order to use the platform or board of your choice.
I would suggest, as a quick solution to your issue, wrapping the code in i2s_nrf52840.cpp with the following preprocessor directive: #ifdef ARDUINO_ARCH_NRF52840
An example of such a modification can be found here: https://github.com/ddavis-2015/tflite-micro-arduino-examples/blob/25b752ea34ef10ba5dd01b1c279e9430d091325d/src/peripherals/i2s_nrf52840.cpp


Unable to open Kudu Debug Console Suddenly

Good Afternoon,
I have been setting up a few functions applications and today I noticed I wasn't able to open/access the files through kudu for my functions on my subscriptions.
When I go directly to the url for the hosted applications (Hosted in Southeast Asia) it shows the directories as being empty despite there being functional and operating functions.
When I click through the function to the kudu interface and I attempt to click on the 'Debug Console' menu item, nothing happens and the url just adds a '#' to the end.
I have attempted to see my kudu files in multiple browsers, addons turned off, etc. I've created new applications and still haven't been able to use kudu to access my files. I've tried clicking on the "old console" option below to no avail.
Opening Page: https://gyazo.com/73e90cfc05a3b39664bc9dd09e53ee42
Environment Page: https://gyazo.com/2631f37c0210bc570acb4070ac6ba257
Link to msdn post: https://social.msdn.microsoft.com/Forums/azure/en-US/1cdf11f3-a264-4b3e-9295-343b636a80af/unable-to-open-kudu-debug-console-suddenly?forum=AzureFunctions#1cdf11f3-a264-4b3e-9295-343b636a80af

You wrote on MSDN thread that you are getting the same errors as in #2727, so let's use that one for discussing this.


Increase test timeout

Jon noticed this, test just needs a bit longer, this commit has been cherry picked in a couple PR's but going to try and get it into main before it confuses anyone else.

I forget to check up on this one, and now lee's merged his branch so it's redundant.


optimized checks in rules

@rultor release, tag is 0.0.50

@rultor release, tag is 0.0.50

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.50

@yegor256 Done! FYI, the full log is here (took me 9min)


Small NPM shortcut improvements

Please have a look at the individual commit messages for the details.

FYI @neubs-bsi.


zinnia does not support customisation of django.contrib.comments

As described at https://docs.djangoproject.com/en/1.3/ref/contrib/comments/custom/ , django.contrib.comments has a customisation feature that allows developers to replace comment model and form with their own versions. The working model class can then be obtained via django.contrib.comments.get_model(). Almost all of django.contrib.comments own code calls get_model(), instead of referring to its own comment model directly.
Zinnia does not support that, because it has "from django.contrib.comments.models import Comment" hardcoded in multiple places.

Hi izelli,
I see the problem...
I don't rememer well why I need to use raw SQL, but I will take a look on it asap.
Fork and submit me patch if you have the time.

Another issue with custom comments:
Entry() have the property discussions that makes use of the for_model manager of the django comment model Comment. So I think the user should be warned that if he uses a custom comment app, he must also use this manager on his custom comment model.
Without doing so, there are litle errors on the admin, at least that I noted.

Ok thank you izelli for these feedbacks.
I will try your code asap, and modifiy the documentation accordingly.

A very related issue is #83 ;)


Update content related to applicant already being in DQT

This updates the content we show to teachers when they've already got a match in DQT as requested by the TRA.

This will be picked up again later.


Changed the cluster name to manual

The automatic pet name for both the cluster and nodes felt like overkill and I did not feel comfortable with them. Now setting the cluster name manually makes more sense, as the cluster is here to stay, its name can be meaningful. As the random pets are really random and meaningless, that suits more the ephemeral nature of nodes.
It defaults to "k3s" but can be anything like "k3s-cluster-xyz" as long as it is hostname compatible. It has the right checks for that.

I agree with you. LGTM


Using new AlertController inside provider (Injectable)

Short description of the problem:
I have a global Unknown error reporting service in my app which opens an alert asking the user if he wants to report the error. I used to open the alert by injecting App and then doing so :
let alert = Alert.create(...);

this.app.getActiveNav().present(alert);

When I try to inject AlertController, it triggers this error :

Cannot resolve all parameters for 'UserReport'(TranslateService, undefined). Make sure that all the parameters are decorated with Inject or have valid type annotations and that 'UserReport' is decorated with Injectable.

Where undefined is supposed to be AlertController.
What behavior are you expecting?
AlertController to properly inject.
Which Ionic Version? 2.x
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.1.1
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10-201606302045
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.6
ios-sim version: 5.0.6
OS: Mac OS X El Capitan
Node Version: v5.0.0
Xcode version: Xcode 7.3.1 Build version 7D1014

I have test this with a Toast that I have when the user gets out of connection and seems to be working.
That nightly doesn't contain AlertController, LoadingController, ToastController. This where my steps (don't know if there is something better):
1 - git clone git@github.com:driftyco/ionic.git
2 - cd ionic
3 - npm install
4 - gulp build.release && gulp tests && gulp package
5 - Update your [PROJECT]/package.json to:
    "@angular/common": "^2.0.0-rc.4",
    "@angular/compiler": "^2.0.0-rc.4",
    "@angular/core": "^2.0.0-rc.4",
    "@angular/http": "^2.0.0-rc.4",
    "@angular/forms": "0.2.0",
    "@angular/platform-browser": "^2.0.0-rc.4",
    "@angular/platform-browser-dynamic": "^2.0.0-rc.4"

6 - npm install on your project directory
7 - copy ionic/dist contents to [PROJECT]/node_modules/ionic-angular
```

Hello @Bouzmine this is caused by the fact that AlertController Is now a service, and in Angular 2 a service cannot be injected into another service. I would recommend converting your error service to a component. Thanks for using Ionic! Also, @ZiFFeL1992 it seems as if your on an older nightly. You can run npm install ionic-angular@nightly to install the latest one. Thanks everyone!

Hello all, I am going to reopen this issue as it exposed an underlying issue with AlertController and is something we want to explore more.

@jgw96 The latest nightly is currently I bit old, that's why I compile master.
'2.0.0-beta.10-201606302045': '2016-06-30T20:46:03.098Z'
As I said before seems like everything is working fine, but if someone else could test will be great.

@ZiFFeL1992 you're right, it works after following the steps above. Closing this.


Document AWS_PROFILE support

What does this PR change? What problem does it solve?
Since restic (or whatever library it is using) seems to respect/use AWS_PROFILE, it's worth documenting this.

Was the change previously discussed in an issue or on the forum?
I don't think so.

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[x] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

@ahmgithubahm Any progress here?


update schemachange to use master token and allow empty snowflake user, role, and warehouse

port changes from v3.6.1-oauth-file

not intended to push back to upstream


Bugfix/tb bugfix 112001

这个 PR 实现什么功能/修复什么问题:
*redis acl update bugfix
*redis backup restore bugfix
*eip associate bugfix
是否需要 backport 到之前的 release 分支:

release/2.13
release/2.12

/area region
/cc @swordqiu @yousong @ioito

Codecov Report

Merging #3806 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3806      +/-   ##
=========================================
+ Coverage    6.93%   6.93%   +<.01%
=========================================
  Files         499     499
  Lines       84296   84307      +11
=========================================
+ Hits         5848    5850       +2
- Misses      77951   77961      +10
+ Partials      497     496       -1

Flag
Coverage Δ

#aFlag
6.93% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)
:arrow_up:

pkg/compute/models/elasticcache_acls.go
5.29% <0%> (-0.17%)
:arrow_down:

pkg/compute/guestdrivers/aws.go
4.76% <0%> (-0.15%)
:arrow_down:

pkg/appsrv/response.go
69.23% <0%> (+3.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6de14...5f02bed. Read the comment docs.

/lgtm

/lgtm

/lgtm

/approve