3D billboards mesh shadows face light source instead of facing camera

Hi,
Godot RC1, win64, windows8.1.
When you set the BillBoard option of a MeshInstance, the shadow is calculated with the MeshInstance facing the light source, instead of facing the active Camera.

Into this capture, the top mesh is rotated manually to face the camera. Its shadow is correct.
The bottom mesh has its Billboard option set to On. Its shadow is incorrect.
The bottom shadow should looks like the top shadow.
The light source is Directional Light with a rotation vector set to -90, 45, 90.
The camera is looking top-down.

Hi, could you provide a scene that reproduces this issue if still valid in the current master branch?

Ping.

Sorry for the delay. I did to used godot for a while and had thousands of github notifications since then.
The bug seems still present into 2.0.2.stable official release.
HEre is a scene that I created back godot RC1 that you can import into 2.0.2.
It show a billboarded cube exhibiting the shadow bug.
bugs - 3d billboard and shadows.zip

I can confirm the bug using the above project. Tagging for the 3.0 milestone so that it's fixed at the latest then when shadows will be reworked, but if someone wants to fix it before that, don't hesitate :)

I don't think this is really a bug.
In many cases, you want the shadows to face the light source and not the camera.
See this video for an example: https://www.youtube.com/watch?v=8Ij56E9qudI
the entire forest is made of billboard trees, and it wouldn't make any sense to have the shadows align with the camera.
Perhaps there are many different use cases for billboards, so maybe a toggle-able option that would allow both kind of shadows would be the best solution

This was fixed in 3.1. Besides facing the proper side, billboards are now in the vertex shader and enabled via material toggle.

err in 3.0 i mean

This actually still happens on my end, albeit not with meshes, rather with bill-board 3D sprites.


Improve Page Loading

Issue:

bcgov/entity/issues/22973

Description of changes:

Optimize API calls and session storage to speed up page loading

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-114-u6bqk57h.web.app

BTW, if the SonarCloud issue reported is a non issue, you can label it as such by setting the status form "Open" to "Accepted". That way we won't see it reported again.

Looks good, except for the first time you got to the main url, a very lengthy wait. That might be just the nature of the beast.

@rstens yes, the first time it needs all the data (to be stored in session), so it will be slower a bit. Once we have loading indicator , spinner, it will look better for the user.

/gcbrun

Temporary Url for review: https://strr-ui-dev--pr-114-u6bqk57h.web.app


Speech Recognition Continuos mode

Hi, is it possible a Speech Recognition Continuos?
Thanks in advance!

It is possible on iOS

I'm interested on Android... Like a "ok Google"

@Danyzzz  The speech recognizer doesn't offer such a continuous mode. However i've achieved to make a "continuous mode" in the same way that everybody does (and with acceptable results) with the Speech Recognition API in the browser : once the speech finishes, restart it again.
However i've faced the 2 obvious problems:

The success callback is executed only once (read how to solve it here).
As we need to use the same success callback to send results, we need to filter someway with Javascript when the result is sent from Java to Javascript (to know wheter the plugins says that the speech recognition ends or the results were retrieven). We can simply send an object from Java to JS with the structure:

{
    "event":"event-name",
    // Only for the onResult event
    "matches": ["Recognized text","Recognized text","Recognized text"]
}

Then, the RecognitionListener events of the Java code should be modified too as follows (returns the previously mentioned structure):
@Override
public void onEndOfSpeech() {
    try {
        JSONObject response = new JSONObject();
        response.put("event", "speech.onend");
        callbackContext.success(response.toString());
    } catch (Exception e) {
        e.printStackTrace();
        callbackContext.error(e.getMessage());
    }
}

@Override
public void onResults(Bundle results) {
    ArrayList<String> matches = results.getStringArrayList(SpeechRecognizer.RESULTS_RECOGNITION);
    Log.d(LOG_TAG, "SpeechRecognitionListener results: " + matches);

    try {
        JSONObject response = new JSONObject();
        // Send type of event "on result"
        response.put("event", "speech.onresults");
        // Send recognized text
        response.put("matches", new JSONArray(matches))
        callbackContext.success(response.toString());
    } catch (Exception e) {
        e.printStackTrace();
        callbackContext.error(e.getMessage());
    }
}

And with Javascript (speechRecognition.js) would be now:
startListening: function (successCallback, errorCallback, options) {
    options = options || {};
    cordova.exec(function (data) {
        var response = JSON.parse(data);

        // Note that you need to add some way of conditional to know wheter the continuous mode is used or the simple mode
        if (response.event == "speech.onend") {
            // Note that you need to wait 500ms, otherwise the error "recognition busy" will be triggered.
            setTimeout(function () {
                // Restart the recognition with the callbacks
                window.plugins.speechRecognition.startListening(successCallback, errorCallback, options);
            }, 500);
        } else if (response.event == "speech.onresults") {
            console.log("Hey something was recognized, check out : ", response.matches);
        }

    }, errorCallback, 'SpeechRecognition', 'startListening', [options.language, options.matches, options.prompt, options.showPartial, options.showPopup]);
},

However i won't make a pull request because that would modify the entire structure in which the plugins works, i just let the idea here in case that someone really needs to make it work in continuous mode. Note that you need figure out how to set a "continuous option" to know when to start the plugin in continuous mode or normal mode.

looking at the google docs it looks like they support continuous speech, will this get implemented?

@sdkcarlos Thank you very much, I really needed to leave in continuous mode. I need some help to implement. I have modified the code but it is giving the following error:
..\pbakondy\S
peechRecognition.java:279: error: cannot find symbol
            JSONObject response = new JSONObject();
            ^

There are news for use continuos mode?

You are better off using your own wake-word solution. Then kicking off this service. I wonder if you could purchase something from mycroft called mycroft-precise (open-source). You would have to purchase the wake word modules and have it compiled to emscripten / llvm. You can ask more info on their forum.

also how does it work on iOS?

I need to develop an app where speech recognition will be continous in order to detect hotword for both iOS and Android platforms , Does Speech Recognition Continuos mode is supported in Ionic v5?

@hiteshtare Bro did you get any solution for this bro?

I was also looking to continuous speech recognition, unfortunately it's still not supported and consumes a lot of power to restart speech recognition every time (see: https://developer.apple.com/documentation/speech/sfspeechrecognizer with the part on Create a Great User Experience for Speech Recognition).
I will try the wake word service of Porcupine : https://picovoice.ai/docs/porcupine/. The drawback is that it's a paid service if you have more than 3 users that use the service.


A specification missing

Hi TyOverby, thank you for the great work on this crate!
I was wondering if bincode has any written specification. I searched the repository and googled a bit but I couldn't find any written spec.
I wanted to use this crate for serializing/deserializing basic protocol network messages, but then realized that I might have difficulty writing a client in another language (Like javascript or python) to communicate with my rust server. A spec could really help with the task of writing a minimal serializer on the client side.
It is possible that bincode was written with the intent of only being used internally by Rust programs, and in that case my question is probably not relevant. What do you think?

Hi @realcr; great question!
I do have plans for releasing documentation on how bincode works internally, but not for people to use to implement decoders/encoders in other languages.
This is because bincode depends precisely on your structs are laid out and how the serde serialize/deserialize impls are generated.
I think you put it well in that this is mainly supposed to be used internally by Rust programs;  I might go further and say that it should only be used by the same program because you must be sure that the serialization and deserialization must be implemented exactly the same.
Hope that answers your question!  If I were you, I'd take a look at bson, it also uses serde and has libraries in many other languages.

Thank you for your quick reply!
bson is probably not a good solution for me, as I need to have really small message size. I can't afford having field names in my messages.
I have not decided yet what to do. the bincode approach was very compelling as it works nicely and results in very small messages. I think that I will use some parser like https://github.com/Geal/nom to parse the messages I'm receiving.
Regarding the spec, even if bincode is not going to be used by other languages, I agree with you that it is probably a good idea to have a spec.

@realcr: the only other recommendation that I would have for you would be to check out protobuf or captain-proto.  Very fast serialization / deserialization, and I believe that the messages are quite small (they definitely don't include the field names).

Hi! Congratulations with bin-code 1.0.0 official  zeroth birthday 🎉 🍰!
👍 to the idea of providing a language-independent specification. I believe there is a particular niche for cross-language serialization, which, surprisingly, is better served by bincode than by other existing formats. This use case came up in exonum.
Specifically, exonum serializes various user-defined messages to binary, and then cryptographically signs the binary data. For this use-case, it is very desirable that the serialization format is canonical: that is, that each message has exactly one valid encoding. Or, more formally forall m1: Vec<u8>, m2: Vec<u8>. (m1 != m2) => decode(m1) != decode(m2). This is needed to make sure that signatures on various ends of the system actually match, and to protect from various replay-based attacks (you may fail to detect a replay if hashes of two semantically equivalent messages differ).
So, self-describing and forwards-compatible properties of formats like protobuf, cap'n'proto, JSON or CBOR are actively harmful for this use case: if you can reorder or add fields, it's hard to get canonical property. Not that cap'n'proto supports canonicalization, but it is not an intrinsic property of the format.
In contrast, there's by construction only one way to serialize the data in bincode, and this is a real unique competitive advantage of this format :)

should only be used by the same program because you must be sure that the serialization and deserialization must be implemented exactly the same

Is this documented somewhere?

Something important to document, that doesn't necessarily require documenting the protocol but would likely be a part of the specification is compatibility guarantees.

Compatibility between different platforms.

Endianness
Integer sizes

Compatibility between different versions:

Rust compiler/LLVM version.
bincode crate version.
Application version:

Different struct definitions.
Different Serialize/Deserialize definitions.
Same struct definitions but other changes in the codebase (AKA optimizer dependent).

It would be nice to know which of these (if any) are guaranteed to be compatible, if they have any well-defined degradation or if it is undefined.

I'm still confused on two points worth addressing:
Backward compatibility: Can I read bytes saved years or decades ago?  Maintainability: Can I easily manage different versions of my structs as they change?
I'm looking into other options, given these two items are not well explained in this issue.

@cheako since 1.0 the bitstream should be stable. (pending an answer on https://github.com/serde-rs/serde/issues/1756). I haven't evaluated struct changes in depth but they are very fragile at the least.


1166 - Adding Project-specific Controls.

What does this PR do?
This PR adds a Control model to the Catalog app and when a Catalog is added, writes all of the Controls in the Catalog to the Control table.
It also adds a Project Controls model to the Projects app. When  a Project is created the Controls associated with the Project's Catalog (from the catalogs.Controls) table are associated with the Project through the ProjectControls model. This allows us to update the Control status per project.
Jira ticket number?
ISPGBSS-1166
Changes

Added Controls model to catalogs
Added hook to write Catalog controls to the Controls table upon Catalog creation
Added ProjectControls model to projects
Added hook to associate Controls with a Project upon Project creation

Testing

[ ] Step 1
[ ] Step 2

@TMCamp This is looking great! I like this direction


Add script to use serving certificates

A small hack script to secure the communicate between API and webhook endpoint for OpenShift users.

/lgtm


Update sql-server-configuration-manager.md

Small misspelling

@noonand : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@noonand Thanks so much for finding and correcting this. When I was looking at the files changed tab, it was a bit like a needle in the haystack to find what had changed, but I found it. Appreciate any quality improvements like this that you spot. #sign-off


Is there a function to calculate the fugacity of each component in a multi-component mixture?

Is there a function to calculate the fugacity of each component in a multi-component mixture?

Hi,
This is absolutely possible. Flash calculations use fugacities. The following code shows how to obtain fugacities in a binary mixture with the Peng-Robinson equation of state, for both a liquid and a gas phase.
from thermo import ChemicalConstantsPackage, PRMIX, CEOSLiquid, CEOSGas
constants, correlations = ChemicalConstantsPackage.from_IDs(['water', 'toluene'])
eos_kwargs = dict(Tcs=constants.Tcs, Pcs=constants.Pcs, omegas=constants.omegas)
liquid = CEOSLiquid(PRMIX, HeatCapacityGases=correlations.HeatCapacityGases, eos_kwargs=eos_kwargs)
gas = CEOSGas(PRMIX, HeatCapacityGases=correlations.HeatCapacityGases, eos_kwargs=eos_kwargs)

(liquid.to(T=300, P=1e4, zs=[.2, .8]).fugacities(), gas.to(T=300, P=1e4, zs=[.2, .8]).fugacities())

Sincerely,
Caleb

Thank you very much for your reply. What I need to calculate is the fugacity of a component of a gas mixture. For example, a gas mixture of hydrogen, carbon monoxide, CO2 and water. I would like to obtain the fugacity of hydrogen.
------------------ 原始邮件 ------------------
发件人:                                                                                "CalebBell/thermo"                                                                                @.>;
发送时间: 2021年12月5日(星期天) 上午10:08
@.>;
<EMAIL_ADDRESS>主题: Re: [CalebBell/thermo] Is there a function to calculate the fugacity of each component in a multi-component mixture? (Issue #92)
Hi,
This is absolutely possible. Flash calculations use fugacities. The following code shows how to obtain fugacities in a binary mixture with the Peng-Robinson equation of state, for both a liquid and a gas phase.
from thermo import ChemicalConstantsPackage, PRMIX, CEOSLiquid, CEOSGas constants, correlations = ChemicalConstantsPackage.from_IDs(['water', 'toluene']) eos_kwargs = dict(Tcs=constants.Tcs, Pcs=constants.Pcs, omegas=constants.omegas) liquid = CEOSLiquid(PRMIX, HeatCapacityGases=correlations.HeatCapacityGases, eos_kwargs=eos_kwargs) gas = CEOSGas(PRMIX, HeatCapacityGases=correlations.HeatCapacityGases, eos_kwargs=eos_kwargs) (liquid.to(T=300, P=1e4, zs=[.2, .8]).fugacities(), gas.to(T=300, P=1e4, zs=[.2, .8]).fugacities())
Sincerely,
Caleb
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Hi,
You can change the component names and mole fractions and add more components in the above example. The fugacities returned are ordered in the same way as you enter the component names.


Update toyota_nodsu_pt_generated.dbc

this would apply to all toyotas but i dont know how to make a separate dbc file to access for just one OP EDIT param. set to corolla_use_indi and it allows a 53 safetyparam? for a safety param to apply it requires a dbc edit and a interface edit, can corolla tss2 have its own dbc file on your fork?

Working on this in https://github.com/ShaneSmiskol/openpilot/pull/286


Enabling Flash Mode

How to enable Flash mode properties to the AVCaptureDevice.
When calling [filter imageFromCurrentlyProcessedOutput]; the flashMode is not working when capturing an Image.
Please provide some inputs to resolve this issue
Thanks

Thanks Brad, Its Working.


dummy commit, testing CI, #2

Signed-off-by: Nicolas Dechesne<EMAIL_ADDRESS>

run tests

run tests!


[Bug] Nonexistent function 'init' in base 'JNISingleton'

I'm using godot 3.4.4 and testing on an Android 12 device.
The test run returns " Nonexistent function 'init' in base 'JNISingleton' ".
Since init is present in ths plugin:
 override fun getPluginMethods(): MutableList<String> {
        return mutableListOf(
            "isGooglePlayServicesAvailable",
            "init",
...
}

and:
fun init(enablePopups: Boolean, requestEmail: Boolean, requestProfile: Boolean, requestToken: String) {
        initialize(false, enablePopups, "DefaultGame", requestEmail, requestProfile, requestToken)
    }

I think it's a godot version related issue? Is this plugin still being maintained?

The plugin was getting me a big crashrate no matter what I did on both Godot 3.4.3 and 3.4.4. Recompiling it didn't help much as well, so I stopped using it (and crashrate reduced significantly after I did). It doesn't look like the author is still maintaining the plugin.


RX65N-CK CCRX aws_tests: Build failed

E0562310:Undefined external symbol "_xSemaphoreFlashAccess" referenced in ".\vendors\renesas\boards\rx65n-cloud-kit-uart-sx-ulpgn\ports\ota\aws_ota_pal.obj"
E0562310:Undefined external symbol "_xSemaphoreFlashAccess" referenced in ".\vendors\renesas\boards\rx65n-cloud-kit-uart-sx-ulpgn\ports\pkcs11\core_pkcs11_pal.obj"

I think the application_code folder in the aws_tests project should be the same as the one in the aws_demos project.
Current
application_code
|- main.c

Proposal
Copy from the aws_demos project.
application_code
|- renesas_code
|  |- utility
|  |  |- r_simple_filesystem_on_dataflash_if.h
|  |  |- r_simple_filesystem_on_dataflash_if.c
|  |- main_task.c
|- main.c


Bloom breaks on fullscreen

Framebuffer is a fixed size which causes this to break

Disable post processing entirely.


EVA-808 New Open Targets trait mapping pipeline

New script to map trait names in ClinVar records against ontology terms present in EFO.

First queries Zooma and uses any high confidence mappings in EFO
Outputs any non-high confidence EFO mappings for manual curation
Uses any high confidence non-EFO mappings to query OxO
Uses any OxO mappings with a distance of 1 and in EFO as a finished mapping
Outputs any OxO mappings in EFO with a xref distance greater than 1 for manual curation

Coverage remained the same at 78.67% when pulling ff2e55c868ac09eeda566fe8625a0202e52f0b97 on tomdcsmith:trait_mapping_pipeline_v2 into 5c7a4033662c16596138c7fb9c846ee34c432e71 on EBIvariation:master.

Coverage remained the same at 78.67% when pulling 5e2e3077df9b465a670286639051b4376cd14bae on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage remained the same at 78.67% when pulling 289dd8624d91b54ca03f248d288ef52fb9bfcc06 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage remained the same at 78.67% when pulling 645bcf4060dcf3cda54801ad529cfbed45d52461 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-26.9%) to 51.733% when pulling 5fea2cfbb5f6f2fed44b83f1b10a8caf45187210 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-12.4%) to 66.314% when pulling 8f433fa34db1b524860862caef55999bf033d7dd on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-10.9%) to 67.779% when pulling 5baa680bf873de467586138b77255119ca33d2fb on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-11.0%) to 67.695% when pulling 6b692b05a253c9c3fb31ab2f95c1008874230f49 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-10.8%) to 67.857% when pulling 51931680c8fb20b5732ae8377e608d79a74f5f60 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-10.8%) to 67.857% when pulling abbb677559a706873ebcb70ceed8db4362be8960 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-10.8%) to 67.857% when pulling a8b19e74b6d2c08ee88ddf0ee5f4d2767f521553 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-10.8%) to 67.857% when pulling 45907ed4f9d9d94480a58a91651200929977f840 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-9.5%) to 69.205% when pulling bd189474446ab8ce82c918d37b97f3afb2c2130c on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-9.4%) to 69.237% when pulling a1506093d87aaed9949cbe116125c4d223954d22 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-9.3%) to 69.32% when pulling 82cfa8b036b8af381fb0868409e75ee47953a9e5 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-9.3%) to 69.32% when pulling 28ce2d7c813e5abd4c13f60d97aa50ea5dfea602 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-8.9%) to 69.783% when pulling e2b3631d84d6983f7cf21424fbe03e4c8bb76b85 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-4.3%) to 74.353% when pulling ec535b65fd5243acea7b9cf03a7fb5f981660ef9 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-4.2%) to 74.456% when pulling 2e1b8a09e7b5ad0bbb04c8adee2e3621482bc681 on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.

Coverage decreased (-4.2%) to 74.477% when pulling 11fc7aba0b2db51268689f50e8fbc7460a5f66bf on tomdcsmith:trait_mapping_pipeline_v2 into f2f111050ac8cae65ef55be8abe1abd3d500e85c on EBIvariation:master.


[DRAFT] CVE and static security scanning

NOTE. This PR is still work in progress and probably needs some discussions before being merged.
Adding 3 GitHub Actions to:

Scan CVEs across direct and transitive dependencies, for Maven and NodeJS; see https://github.com/maoo/vuu/actions/runs/3281627965 and https://github.com/maoo/vuu/actions/runs/3281510178 . Some CVE were spotted, and some Node package builds are skipped, so more work is needed here.
Run static code analysis using Semgrep (more info on https://github.com/finos/security-scanning#static-code-analysis), see https://github.com/maoo/vuu/actions/runs/3281627963 ; 42 issues have been found
Generate a dependency report that can be (manually) scanned to ensure that no Category X licenses, see https://github.com/maoo/vuu/actions/runs/3281627955 . No Category X licenses were spotted, so the license scanning have passed.

To check VUU contribution process, see https://github.com/finos/community/issues/206 ; to know more about FINOS Security scanning, visit https://github.com/finos/security-scanning

@maoo - Update Node CVE scanning to use yarn, launch install command from vuu-ui top level folder, ignore project matrix.

@chrisjstevo - fixed CVE scanning using yarn.lock, see https://github.com/maoo/vuu/actions/runs/3361593908/jobs/5572185684 . I've also run license scanning on Node code and couldn't find any issue, see https://github.com/maoo/vuu/actions/runs/3361604190

@chrisjstevo - conflicts resolved, this PR is ready to be merged. TY!


Update README.md

made headings look  better

@anilkarela : Please can you let us know which issue under k/website this fixes?
Also, if you need your PR to be reviewed please sign the CLA.

Hey there! @anilkarela, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

@anilkarela : Thank you for the PR. However since there has been no response on this PR from your end for ~ 2 months, we will be closing it off. Kindly consider reopening it if & when you feel ready to contribute.
Please note: Kindly sign CLA before you start contributing since it helps with expediting the review process.

/close


Error while reading from unidirectional stream

I'm designing a QUIC client - server architecture where the client sends a "client hello" message using a QUIC unidirectional channel.
What happens is:

client performs a QUIC connection with the server
client opens an unidirectional stream using conn.OpenUniStream()
client sends its "client hello" data with a fixed length XYZ
client closes the unidirectional stream
server accepts the unidirectional stream using conn.AcceptUniStream()

However, in the server, when I call Read() on the accepted unidirectional stream, it returns the correct XYZ as the n value and io.EOF as the error.

Is it correct that I receive an error even if I have read all the data I needed? In my case I used an exception where I skip the error if the read n is correct. Initially, I didn't expect this behavior, but then I found the docs where it's stated that EOF is returned, so is it enough for me to just handle it this way?
Is my approach correct or am I risking any race condition by closing the uni stream immediately after having sent the data?

However, in the server, when I call Read() on the accepted unidirectional stream, it returns the correct XYZ as the n value and io.EOF as the error.

This is exactly how an io.Reader is supposed to behave. From the documentation of io.Reader:

When Read encounters an error or end-of-file condition after successfully reading n > 0 bytes, it returns the number of bytes read. It may return the (non-nil) error from the same call or return the error (and n == 0) from a subsequent call.

Therefore, the correct behavior (not only for streams, but for every io.Reader) is: First handle data read (if n > 0), then check for the error.

Ok, thank you


.spelling should not use "whitelist" and "blacklist"

Where to find the issue
https://github.com/corona-warn-app/cwa-documentation/blob/441b3ed5a5fce093b26dba0bbd1e739742830713/.spelling#L13
https://github.com/corona-warn-app/cwa-documentation/blob/441b3ed5a5fce093b26dba0bbd1e739742830713/.spelling#L122
Describe the issue
The terms white- and blacklist should not be used anymore.
Suggested change
Use allow-list and deny-list instead.
Additional information
I will provide a PR for this.

@dsarkar
Before I provide a PR, could you clarify internally:
Should we use:
allowlist & blocklist
allowlist & denylist (w/o hyphen)
allow-list & deny-list (with hyphen)
Thank you!

@Ein-Tim
In the workflow script https://github.com/corona-warn-app/cwa-documentation/blob/master/.github/workflows/checks.yml
npm run-script spellcheck
is commented out.
If you run npm run-script spellcheck on a clone of the master branch of the repository by hand, the result is:

206 spelling errors found in 14 files

So my conclusion is that the file https://github.com/corona-warn-app/cwa-documentation/blob/master/.spelling is not being maintained or used in any formal way at this time.

Thank you @MikeMcC399!
Although .spelling is not used in any automatic checks, @mlenkeit recently referred to it.
Also, if there was an internal decision to not use these terms anymore, IHMO they should be updated to not make anyone think that we're still using these terms.
But if the team descides to not change it, it's also ok for me.

@Ein-Tim

Also, if there was an internal decision to not use these terms anymore, IHMO they should be updated to not make anyone think that we're still using these terms.

I don't know if there was an SAP internal decision about it.
The post you quoted https://github.com/corona-warn-app/cwa-website/issues/952#issuecomment-791924528 doesn't mention it, however one post later https://github.com/corona-warn-app/cwa-website/issues/952#issuecomment-791927211 was from me where I wrote 'The term these days is now "allowlisted"' and I wrote that because Google had changed their Exposure Notifications implementation guide to refer to Glossary - Allowlisted accounts.
On a related topic: GitHub is moving to change the default repository branch from master to main (see https://github.com/github/renaming) for newly created repositories. In fact some of the repositories in the https://github.com/corona-warn-app organisation have been modified too. Unfortunately this broke links in the past and so I would not want to see this cwa-documentation repository to be changed similarly at this time.

The post you quoted corona-warn-app/cwa-website#952 (comment) doesn't mention it,  [...]

I think yes it does, @dsarkar wrote:

[...] For the RKI survey routers should include in their domains access-list (apparently we shall not use the word whitelist):

Also @heinezen commented here (the fact that his statement was unrelated to this PR doesn't mean that what he commented there isn't true, IHMO):

Correct terminology is "allowlist" (prev known as "whitelist"). no space or separator in beween. Also, use the same word in German, but capitalized ("Allowlist")

I agree with you that we had quite a few broken links because of renaming master to main, but I don't see where a little change in this file would cause something like this.

@Ein-Tim
I stand corrected! Sorry for misreading!
Of course changing the .spelling file will not cause any links to break.

@MikeMcC399
Thanks 👍
But I want to mention that I definitely don't consider this issue here at a high priority (only speaking about me, maybe others do), so if it would be really something that has to be discussed internally please don't let it block the development in any form!

@dsarkar The https://github.com/corona-warn-app/cwa-documentation/labels/in review label is applied here since 12.04.2021. Is the review still not finished? If it is finished, what was the result?

This issue became stale. I will close it now.

@Ein-Tim

See my suggestion in https://github.com/corona-warn-app/cwa-documentation/issues/891 to remove the file .spelling completely as it has not been actively used in the last two years.


Only output dev packages for pipenv lock -r -d

The issue
The pipenv lock -r should only output all default packages. The pipenv lock -r -d should only output all dev packages. But currently master branch will ouput both default and dev packages for pipenv lock -r -d. This behaviour is different with any released versions.
For example, following Pipfile currently would output all packages by pipenv lock -r -d.
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[dev-packages]
requests = "*"

[packages]
flask = "*"

[requires]
python_version = "3.6"

D:\test>pipenv lock -r -d
-i https://pypi.org/simple
certifi==2018.10.15
chardet==3.0.4
click==7.0
flask==1.0.2
idna==2.7
itsdangerous==1.1.0
jinja2==2.10
markupsafe==1.1.0
requests==2.20.0
urllib3==1.24.1
werkzeug==0.14.1

Actually it should only output dev packages as followings.
(D:\test>pipenv lock -r -d
-i https://pypi.org/simple
certifi==2018.10.15
chardet==3.0.4
idna==2.7
requests==2.20.0
urllib3==1.24.1

The fix
I believe only in get_requirements means only include dev packages without default packages. But the only in do_install_dependencies means only install deps without locking. So only para in get_requirements should not inhericated from do_install_dependencies but pin to False to only output dev packages or default packages.
The checklist

[ ] Associated issue
[ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

How are you keeping up with all of this? I wrote a lot of it and I'm having trouble :|
Granted, I didn't write the lock output section, I find it a bit confusing. You're spot on. Thanks for catching this (again) (why don't we have a test for this)

I really need to cut a release, but it's probably worth creating a triage permission level at the very least for anyone who wants to help go through and tag out everything we merged but didn't write tests for yet / needs protection against regressions

I use pipenv for my daily development for my own/company projects, so it is easy for me to find any breaking changes in APIs and definitely happy to make a PR for that, only if I can.
Yes, I can see pipenv is still in active development and regressions often happens. Probably the test coverage is still not good enough.
Maybe it worth to consider release beta/pre-releases? So some users can try that and have feedbacks, then developers could fix the regressions, and finally cut the release。


Support organization resource access with tenant & organization perspective

Describe the issue:
The organization resources should be accessible in tenant perspective and organization perspective.

The tenant perspective resource access - /t//api/server/v1/applications
The organization perspective resource access - /t//o/api/server/v1/applications

Each perspective has separate personas and use cases. Identity server should support for these cases.

In the on-prem console for the primary org (super tenant), currently endpoint paths are in the format o/10084a8d-113f-4211-a0d5-efe36b082211. Internally there can be logics that is written to fetch the organization ID from context (with the aforementioned improvement this would be null for super tenant). If so those flows might be impacted due to this. Therefore let's confirm that there are no breaking changes due to this.


xrange() was removed in Python 3 in favor of range()

Reference issue

What does this implement/fix?

Remove all instances of from scipy._lib.six import xrange and
convert all calls to xrange() into calls to range().
Additional information

Looks reasonable modulo a possible backcompat break. I'd suggest to consider it separately and remove from this PR.
Also, I've labelled it Py3K (after numpy), so that we can group these rip-out-py2 PRs.


Rename init_component & friends

Objective

Fixes #15451

Migration Guide

World::init_component has been renamed to register_component.
World::init_component_with_descriptor has been renamed to register_component_with_descriptor.
Components::init_component has been renamed to register_component.
Components::init_component_with_descriptor has been renamed to register_component_with_descriptor.

@MichalGniadek can I get your review here? Do you like the rename?

Thanks @hooded-shrimp :D This change looks good, but needs a simple Migration Guide still. Let me know if you'd like a hand writing one :)

All the breaking changes should be recorded now.

This should probably also rename World::init_bundle to World::register_bundle?

This should probably also rename World::init_bundle to World::register_bundle?

I could do that.
World::init_bundle calls Bundles::init_info should that be renamed as well? There are also comments that might need to be updated to say "register" instead of "initialize".

Searched through init_ in the repo and:

Components::init_component_inner could also be renamed as it's only used in the now renamed register_component and register_component_with_descriptor
Components::init_resource, Components::init_non_send could also could be renamed (not the World methods though as these insert the resources automatically and not just register them)


bug(mat-progress-bar): Progress jumps from 100 to 0, even if 0 was set and ngIf hides/shows the component

I'm resurrecting issue #3502.
We use a table component which on pagination, uses mat-progress-bar. when an API call is in progress, an ngIf shows mat-progress-bar, and progress increments to 100. When done, progress is set to 0, and ngIf hides the component.
When the first call is made, everything is fine. But on subsequent api calls, the progress bar after appearing suddenly slides down from 100 to 0 when it appears, even through progress was set to 0 before it showed. This is very jarring. It breaks UI conventions in a pretty fundamental way and I think needs at least a suggested workaround by the team so I can mitigate it somehow

Same here +1!

any update on this?

Can't figure this out either.  When the parent component is constructed, I see the three progress bars in one child component jump from 100 to 0, but another child component (w/ progress bar) does not.  I'm failing to see what I'm doing differently.

Not sure what made me test position in the parent template, but when the child component that jumps is above the one that doesn't, they both don't jump!  smh

seems to be fixed in angular-13: demo

Had the same issue and was able to fix it in Angular 11 (haven't tried 13 yet) by adding *ngIf:
<mat-progress-bar
    *ngIf="progress !== undefined"
    mode="determinate"
    [value]="progress"
></mat-progress-bar>

Strangely, giving the progress an initial value of 0 had no effect.

Hello jpike88,
Does the issue still happen for you in v15?
-Zach


When I die, I can't come back to life

I have a problem that when I die I can't come back to life (and this with mods)

same here

This is a duplicate of #10. Please first search for similar issues to see if someone has already reported a bug, before submitting an issue yourself.

Is there a solution to this problem?


Base: merge two identical CPP cases

The two cases are identical.  Merge them to avoid the unnecessary duplication.

CC @phausler @parkera

This might pose some merging issues for us in the actual Darwin version. I will have to double check if the branches collapse correctly (they used to not)

After looking at this; I think we can easily do this. Looks like this was unified in the most recent major releases of those deployment targets.


Add to nuttx apps a simple app to test spi slave driver.

Summary
This app can be used to test spi slave driver. Using this app will be more fast to users test and verify spi slave driver.
For instance whats happened here: https://github.com/apache/nuttx/issues/13855#issuecomment-2426461702
Impact
No impact, new feature.
Testing
This app was used to test lower half changes done in this PR: https://github.com/apache/nuttx/pull/14420

[Experimental Bot, please feedback here]
Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
The PR summary is missing some key details. While it mentions testing the SPI slave driver, it doesn't explain how the app achieves this. Here's a breakdown of what's missing and how to improve the PR:
Summary:

Missing:

Functional part:  Which part of the codebase is this app being added to? Is it a new directory under apps/, or is it extending an existing application?
Exact functionality:  Be specific. Does the app send pre-defined SPI messages? Does it allow the user to input custom messages? Does it analyze the responses from the slave device?

Improvement:
"This PR adds a new application under apps/testing/tools/spislave_test  (or similar). The application provides a command-line interface for sending and receiving SPI data, allowing developers to test various aspects of the SPI slave driver, such as data transfer, interrupt handling, and error conditions."

Impact:

Inaccurate:  While the app itself might be a new feature, it's likely interacting with existing code (the SPI driver). This interaction could have unforeseen impacts.
Missing:

Hardware: If the app requires specific hardware configurations (e.g., SPI pins), this needs to be documented.
Documentation:  A new application will require documentation explaining how to use it.

Improvement:

"This PR adds a new application, so it has no direct impact on existing functionality. However, it relies on the SPI driver and might reveal hidden issues. This PR includes updated documentation for the application in the apps/testing/README.md file."

Testing:

Insufficient: Simply stating the app was used in another PR is not enough.  The testing section should stand on its own.
Missing:

Build Hosts:  List the operating systems and compilers used to build the application.
Target(s): Be specific about the target hardware and configurations used for testing (e.g., "STM32F4 Discovery board with the following SPI configuration...").
Logs:  Provide snippets of the testing logs showing the app working as expected. Describe the test cases that were executed.

Improvement:
Provide concrete examples of test commands used with the app and the expected output. For instance:
"The following command was used to send a 16-byte message to the slave device: spislave_test -s /dev/spi0 -m 0x12 0x34 ... 0xab 0xcd. The slave device responded with 0xef 0x01 ..., confirming correct data transfer."

In conclusion, the PR does not fully meet the NuttX requirements. It needs significant improvements in clarity, completeness, and especially the testing section to be considered for merging.

please add this new example to documentation: https://github.com/apache/nuttx/tree/master/Documentation/applications/examples
so that it appears on the list here: https://nuttx.apache.org/docs/latest/applications/examples/index.html

Hello @cederom, commit msg done and PR with documentation opened: https://github.com/apache/nuttx/pull/14457


Creation of JALSE-Defaults project

Defaults:

EntityTypes (inheritence)
Attributes (Quadtree, behaviour/state machine)
Attribute listeners
Actions
Combined utilities for the above

Could cove movement and common simulations (Blocking, Animal, FlyingAnimal, etc). Will need some sort of documentation with it.

Quadtree
Behaviour / state machine

NPCBuilder.newBuilder().setParent(jalse).setPosition(x, y).setBlocking().setSize(50, 50).build();


Cannot read property 'getRemainingTimeInMillis' of undefined

My lambda function on prod ends in a TypeError:
export const lambdaHandler: SNSHandler = async (event: SNSEvent, context: Context): Promise<void> => {
   // ...
}

At the end this error occurs:
```json
{
  "errorType": "TypeError",
  "errorMessage": "Cannot read property 'getRemainingTimeInMillis' of undefined",
  "trace": [
    "TypeError: Cannot read property 'getRemainingTimeInMillis' of undefined",
    "    at <anonymous> (/opt/nodejs/node_modules/@bugsnag/plugin-aws-lambda/dist/src/index.js:62:24)",
    "    at null.createMatchingForUnmatchedFreelancersWithSpecificJob (/var/task/src/handlers/ts/xxx/xx-xxx.ts:346:30)",
    "    at processTicksAndRejections (internal/process/task_queues.js:95:5)",
    "    at Runtime.lambdaHandler (/var/task/src/handlers/ts/xxx/xx-xxx.ts:393:3)"
  ]
}

It's interesting that the plugin-aws-lambda code contains exactly this problem at https://github.com/bugsnag/bugsnag-js/blob/13cd9d3e45affaf37e3e8098fff6fe7d6a9a486d/packages/plugin-aws-lambda/src/index.js#L60-L64

Hi @ldaume, in your case it looks like context itself is undefined, rather than getRemainingTimeInMillis, which is what that code is guarding against. Can you share how you are initialising Bugsnag and wrapping your handler in your Lambda function?

Closing this for now as we haven't been able to reproduce but if you're able to provide a full reproduction example we'd be happy to investigate further.


[BUG] List order caused full backup image data transfer when no resource updated.

Describe the bug
Similar to https://github.com/longhorn/longhorn/issues/2646.
To Reproduce
Steps to reproduce the behavior:

Create 10 Backup Images.
Inspect Network and payload with browser inspect tool.

Expected behavior
Should not have data sent over WS if no update.
Log
If applicable, add the Longhorn managers' log when the issue happens.
Environment:
n/a
Additional context
https://github.com/longhorn/longhorn/issues/2372

Validation - Passed
Verified with v1.1.2-head(0616) images, with more than 10+ backup imaging.
While the image is being downloading the backignimages connection will constantly gets update, once it's done there is no WS data flow observed.

This is was reopened by mistake. Closed it now.


feat: update golang-golang-x-sys to 0.20.0

Low-level interaction with the operating system
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

/lgtm
/approve

/lgtm
/approve


Document snag with stringData and server-side apply

try to fix: https://github.com/kubernetes/website/issues/42603


Prepare testing for v0.20.1

launch jenkins all daint

tsa
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:cdo-spack_info :green_circle:cdo-spack_spec :green_circle:clang-format-spack_info :green_circle:clang-format-spack_spec :green_circle:claw-spack_info :green_circle:claw-spack_spec :green_circle:cosmo-dycore-spack_info :green_circle:cosmo-dycore-spack_spec :green_circle:cosmo-dycore_+cuda_+gt1_+build_tests-spack_spec :green_circle:cosmo-dycore_~cuda_+gt1-spack_spec :green_circle:cosmo-eccodes-definitions-spack_info :green_circle:cosmo-eccodes-definitions-spack_spec :green_circle:cosmo-spack_info :green_circle:cosmo-spack_spec :green_circle:cosmo_cosmo_target=gpu_+serialize_+claw_+zlib_ng_+oasis-spack_spec :green_circle:cosmo_cosmo_target=gpu_~cppdycore-spack_spec :green_circle:dawn-spack_info :green_circle:dawn-spack_spec :green_circle:dawn4py-spack_info :green_circle:dawn4py-spack_spec :green_circle:dusk-spack_info :green_circle:dusk-spack_spec :green_circle:eccodes-spack_info :green_circle:eccodes-spack_spec :green_circle:eckit-spack_info :green_circle:eckit-spack_spec :green_circle:fckit-spack_info :green_circle:fckit-spack_spec :green_circle:fdb-flexpart-spack_info :green_circle:fdb-flexpart-spack_spec :green_circle:fdb-fortran-spack_info :green_circle:fdb-fortran-spack_spec :green_circle:fdb-spack_info :green_circle:fdb-spack_spec :green_circle:flexpart-ifs-spack_info :green_circle:flexpart-ifs-spack_spec :green_circle:gridtools-spack_info :green_circle:gridtools-spack_spec :green_circle:gridtools_+cuda-spack_spec :green_circle:gridtools_~cuda-spack_spec :green_circle:icon-ham-spack_info :green_circle:icon-ham-spack_spec :green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle:icontools-spack_info :green_circle:icontools-spack_spec :green_circle:infero-spack_info :green_circle:infero-spack_spec :green_circle:int2lm-spack_info :green_circle:int2lm-spack_spec :green_circle:int2lm_+parallel-spack_spec :green_circle:libcdi-pio-spack_info :green_circle:libcdi-pio-spack_spec :green_circle:libfyaml-spack_spec :green_circle:libgrib1-spack_info :green_circle:libgrib1-spack_spec :green_circle:libxml2-spack_info :green_circle:libxml2-spack_spec :green_circle:metkit-spack_info :green_circle:metkit-spack_spec :green_circle:nvidia-blas-spack_info :green_circle:nvidia-blas-spack_spec :green_circle:nvidia-lapack-spack_info :green_circle:nvidia-lapack-spack_spec :green_circle:oasis-spack_info :green_circle:oasis-spack_spec :green_circle:omni-xmod-pool-spack_info :green_circle:omni-xmod-pool-spack_spec :green_circle:py-black-spack_info :green_circle:py-black-spack_spec :green_circle:py-boltons-spack_info :green_circle:py-boltons-spack_spec :green_circle:py-cytoolz-spack_info :green_circle:py-cytoolz-spack_spec :green_circle:py-devtools-spack_info :green_circle:py-devtools-spack_spec :green_circle:py-editables-spack_info :green_circle:py-editables-spack_spec :green_circle:py-factory-boy-spack_info :green_circle:py-factory-boy-spack_spec :green_circle:py-fprettify-spack_info :green_circle:py-fprettify-spack_spec :green_circle:py-frozendict-spack_info :green_circle:py-frozendict-spack_spec :green_circle:py-gridtools-cpp-spack_info :green_circle:py-gridtools-cpp-spack_spec :green_circle:py-gt4py-spack_info :green_circle:py-gt4py-spack_spec :green_circle:py-hatchling-spack_info :green_circle:py-hatchling-spack_spec :green_circle:py-icon4py-spack_info :green_circle:py-icon4py-spack_spec :green_circle:py-inflection-spack_info :green_circle:py-inflection-spack_spec :green_circle:py-lark-spack_info :green_circle:py-lark-spack_spec :green_circle:py-pathspec-spack_info :green_circle:py-pathspec-spack_spec :green_circle:py-poetry-core-spack_info :green_circle:py-poetry-core-spack_spec :green_circle:py-pytest-factoryboy-spack_info :green_circle:py-pytest-factoryboy-spack_spec :green_circle:py-pytest-spack_info :green_circle:py-pytest-spack_spec :green_circle:py-setuptools-spack_info :green_circle:py-setuptools-spack_spec :green_circle:py-toolz-spack_info :green_circle:py-toolz-spack_spec :green_circle:py-typing-extensions-spack_info :green_circle:py-typing-extensions-spack_spec :green_circle:rttov-spack_info :green_circle:rttov-spack_spec :green_circle:scales-ppm-spack_info :green_circle:scales-ppm-spack_spec :green_circle:tensorflowc-spack_info :green_circle:tensorflowc-spack_spec :green_circle:yaxt-spack_info :green_circle:yaxt-spack_spec :green_circle:zlib_ng-spack_info :green_circle:zlib_ng-spack_spec :red_circle: system testTest:green_circle:Cdo-install_default :green_circle:ClangFormat-install_default :green_circle:Claw-install_default :green_circle:Cosmo-install_version_6_0_cpu :green_circle:Cosmo-install_version_6_0_gpu :green_circle:CosmoDycore-install_c2sm_master_cuda :green_circle:CosmoDycore-install_c2sm_master_no_cuda :green_circle:CosmoDycore-install_version_6_0 :green_circle:CosmoEccodesDefinitions-install_version_2_19_0_7 :green_circle:CosmoEccodesDefinitions-install_version_2_25_0_1 :green_circle:Eccodes-install_2_19_0 :green_circle:Eckit-install_1_20_0_gcc :green_circle:Eckit-install_1_20_2_gcc :green_circle:Eckit-install_1_20_2_nvhpc :green_circle:Fckit-install_default :green_circle:Fdb-install_5_10_8_gcc :green_circle:Fdb-install_5_10_8_nvhpc :green_circle:FdbFlexpart-install :green_circle:FdbFortran-install :green_circle:FlexpartIfs-install_latest :green_circle:GridTools-install_version_1_1_3_gcc :green_circle:GridTools-install_version_1_1_3_nvhpc :green_circle:Icon-install_2_6_6_gcc :green_circle:IconTools-install_2_5_2 :green_circle:Infero-install :green_circle:Int2lm-install_c2sm_master_gcc :green_circle:Int2lm-install_c2sm_master_nvhpc :green_circle:Int2lm-install_version_3_00_gcc :green_circle:Int2lm-install_version_3_00_nvhpc_fixed_definitions :green_circle:LibCdiPio-install_default :green_circle:LibXml2-install_default :green_circle:Libfyaml-install_default :green_circle:Metkit-install_1_9_2_gcc :green_circle:Metkit-install_1_9_2_nvhpc :green_circle:NvidiaBlas-install_default :green_circle:NvidiaLapack-install_default :green_circle:Oasis-install_master_nvhpc :green_circle:OmniXmodPool-install_version_0_1 :green_circle:PyBlack-install_default :green_circle:PyBoltons-install_default :green_circle:PyCytoolz-install_default :green_circle:PyDevtools-install_default :green_circle:PyEditables-install_default :green_circle:PyFactoryBoy-install_default :green_circle:PyFprettify-install_default :green_circle:PyFrozendict-install_default :green_circle:PyGridtoolsCpp-install_default :green_circle:PyGt4py-install_version_1_1_1 :green_circle:PyGt4py-install_version_1_1_2 :green_circle:PyHatchling-install_default :green_circle:PyIcon4py-install_version_0_0_5 :green_circle:PyIcon4py-install_version_0_0_6 :green_circle:PyInflection-install_default :green_circle:PyLark-install_default :green_circle:PyNumpy-install_default :green_circle:PyPathspec-install_default :green_circle:PyPoetryCore-install_default :green_circle:PyPytest-install_default :green_circle:PyPytestFactoryboy-install_default :green_circle:PySetuptools-install_default :green_circle:PyToolz-install_default :green_circle:PyTypingExtensions-install_default :green_circle:Rttov-install_version_13_1_gcc :green_circle:Rttov-install_version_13_1_nvhpc :green_circle:ScalesPPM-install_default :green_circle:TensorflowC-install_2_6_0 :green_circle:Yaxt-install_default :green_circle:ZLibNG-install_version_2_0_0 :red_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

launch jenkins daint icon

tsa
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc

balfrin
:green_circle: unit testTest:green_circle:summary

balfrin
:green_circle: unit testTest:green_circle:summary

launch jenkins icon daint

tsa
:green_circle: unit testTest:green_circle:summary

balfrin
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :red_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :red_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

launch jenkins icon daint

tsa
:green_circle: unit testTest:green_circle:summary

balfrin
:green_circle: unit testTest:green_circle:summary

launch jenkins icon daint

balfrin
:green_circle: unit testTest:green_circle:summary

tsa
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc
WARNING: Serial tests did not run for system tests

launch jenkins icon daint

balfrin
:green_circle: unit testTest:green_circle:summary

tsa
:green_circle: unit testTest:green_circle:summary

daint
:green_circle: unit testTest:green_circle:summary :green_circle: integration testTest:green_circle:icon-spack_info :green_circle:icon-spack_spec :green_circle:icon_serialization=create_claw=std-spack_spec :green_circle: system testTest:green_circle:Icon-install_2_6_6_gcc :green_circle:daint_cpu_cce :green_circle:daint_cpu_gcc :green_circle:daint_cpu_nvhpc :green_circle:daint_cpu_nvhpc_out_of_source :green_circle:daint_gpu_nvhpc :green_circle:daint_dsl_nvhpc

In the logfile for Icon-install_2_6_6_gcc we get: Warning: Cannot find test.py -> skipping tests Is this a cause for concern?

This is a warning we emit on purpose to indicate that testing is not possible w/o test.py.
Nothing to worry about.

I added the upper limit because of the 7 icon tests that cannot run on compute nodes atm.
Previously I limited the number of build-threads to 4, but this made the builds very slow.
I thought that limiting the number of parallel workes, but each worker compiling on 12 threads would be faster.
Maybe we see a slow down in case of launch jenkins all, but for the tests run the most like ICON, we have a speedup.


MNT: Re-rendered with conda-smithy 2.2.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Replaced by PR ( https://github.com/conda-forge/pylint-feedstock/pull/6 ).


update marked dependency

Thanks for this great tool!
Purpose: This PR updates the marked dependency by bumping its patch version.
Background<EMAIL_ADDRESS>has two security vulnerabilities (https://nvd.nist.gov/vuln/detail/CVE-2017-1000427, https://nvd.nist.gov/vuln/detail/CVE-2017-17461). While these are not exposed given how typedoc uses marked - the vulnerability warning is passed through to all repos that depend on typedoc. This creates a burden of keeping track of what vulnerabilities are actual - and desensitizes the github tool.

It is unclear why files beyond package.json changed. I noticed the same changes simply by cloning the repo and installing - so they don't seem related to this PR. If you'd like me to remove them from this PR, I'd be happy. Just let me know!

Thanks for merging this. Please ship a release post-haste!

@chriskrycho this should be included in the 0.10.0 release. Another release is needed to fix an issue with the exclude not exported flag

Hmm. I just updated to 0.10.0, and that's when GitHub flagged up the issue. 🤔

Interesting. Looks like all versions of marked have a Regex DOS vulnerability. See chjj/marked#1039 for more details. We can update when a fix is issued.
For reference, marked should currently be at version ^0.3.12.


After upgrading to version 0.13.0 and compiling ts, an error is reported. Argument of type '{ sinkId: string; }' is not assignable to parameter of type 'AudioContextOptions'.

Hey, sorry for the late reply, it seems that the TS types are generated from the published API (https://www.w3.org/TR/webaudio/) while sinkId is still only in editors draft (https://webaudio.github.io/web-audio-api/)
Not really a user of typescript myself so I don't really know how to solve the issue, maybe adding the AudioContextOptions manually in the index.d.ts file? Any help welcome here


cursor disapper at the input position.

I found the cursor can be disapper, and i could not distinguish the cursor color.just as:

Is the colorscheme set or my vimrc config is not so correct?

This depends on your terminal. I have answered a similar issue in ayu-theme/ayu-vim#65.
What terminal are you using? Have you tried changing your terminal's cursor color?

Thanks, I use alacrity as the terminal. I use dracula colorscheme on this terminal, after i use the default color, the cursor can be seen.


Swift 6 build error: Static property 'schema' is not concurrency-safe

Environment information
System:
  OS: macOS 15.0
  CPU: (8) arm64 Apple M2
  Memory: 118.66 MB / 24.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 22.9.0 - /opt/homebrew/bin/node
  Yarn: undefined - undefined
  npm: 10.8.3 - /opt/homebrew/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/auth-construct: 1.3.1
  @aws-amplify/backend: 1.2.2
  @aws-amplify/backend-auth: 1.1.5
  @aws-amplify/backend-cli: 1.2.7
  @aws-amplify/backend-data: 1.1.4
  @aws-amplify/backend-deployer: 1.1.3
  @aws-amplify/backend-function: 1.4.1
  @aws-amplify/backend-output-schemas: 1.2.0
  @aws-amplify/backend-output-storage: 1.1.2
  @aws-amplify/backend-secret: 1.1.2
  @aws-amplify/backend-storage: 1.1.3
  @aws-amplify/cli-core: 1.1.3
  @aws-amplify/client-config: 1.3.1
  @aws-amplify/deployed-backend-client: 1.4.1
  @aws-amplify/form-generator: 1.0.2
  @aws-amplify/model-generator: 1.0.7
  @aws-amplify/platform-core: 1.1.0
  @aws-amplify/plugin-types: 1.2.2
  @aws-amplify/sandbox: 1.2.2
  @aws-amplify/schema-generator: 1.2.3
  aws-amplify: 6.6.2
  aws-cdk: 2.159.0
  aws-cdk-lib: 2.159.0
  typescript: 5.6.2
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Describe the bug
I updated my iOS app from Swift 5 to Swift 6, and the build fails due to this error in the generated +Schema.swift files:
/Users/concaveusr/Projects/Kanai/Kanai/AmplifyModels/KanaiUserInfo+Schema.swift:23:21 Static property 'schema' is not concurrency-safe because non-'Sendable' type 'ModelSchema' may have shared mutable state

Note that putting @preconcurrency at the top of the generated Schema files suppresses the error, but I'm creating this issue to either add that automatically, or to even better find a way to make schema concurrency-safe.
Reproduction steps
Make any model in Amplify Gen 2 and put it in your Swift 6 Xcode project and try to build it.

ModelSchema actually is defined in the Amplify Swift library, so I think this issue will be solved there.


fix(empty-entity-relations): added message if no relations available

:tada: This PR is included in version 2.3.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Add GCC 13.2 shards to BB

Is this mergeable?

I'd still like to see the corresponding PR in Yggdrasil, I don't like merging PRs here if we don't have the companion too

BTW, I think we should first get #318 merged.  @staticfloat any reason why that hasn't been done yet?

Nope, just crazy busy.  Sorry.

Do I need to rebuild then?

If you were after https://github.com/JuliaPackaging/Yggdrasil/pull/7136 on Yggdrasil, you should be good.


Please provide a way to install the scheduler cli without sudo

A proper pip package is probably the way to go here, but I'll take anything that lets me install locally to my home directory since I'm using pyenv.

This would be fantastic feature. How do I upvote?

You can upvote using the thumbs-up emoji on the original post.

related to https://github.com/aws-solutions/aws-instance-scheduler/issues/408


describe is not defined

import 'steal-mocha'

describe("Foo", function(){
  it("bar", function(){
    assert("yay!");
  });
});

describe is not defined in console

You're probably missing setting the interface, adding data-mocha="bdd" to the script tag (this is on the readme too) and that should fix it.

hah, ok) or should setup right mocha.setup("bdd");


CDPSDX-518 - Add the get_keytab API to the FreeIPA API server

Add the get_keytab API to the FreeIPA API servier. The API was added
to the FreeIPA API server as a plugin. Since FreeIPA is GPL, the
plugin must also be licensed as GPL. As a result, the FreeIPA
bootstrapping process was updated so that the get_keytab is installed
from a separate directory rather using the existing bootstrapping
process which only uses resources that are packaged inside the
FreeIPA management service's JAR.
This was manually tested by logging into to the FreeIPA server and
using the the ipa command line utility to call the get_keytab API.
Closes CDPSDX-518

lgtm, but as @doktoric mentioned you should rebase to master and hopefully that will fix the int tests


Convert master to firebase clean up system

Should function like normal, may be some merge issues.
Now uses general firebase functions:
create/edit/log into profile, create/edit/delete listing, add enquiry about listing, add/remove pin, add/remove wishlist
Note: Wishlist needed custom function due to how it is stored.

Looks good but make sure to resolve the conflicts. Also be careful when passing in listingId to appendArray because sometimes it is passing in the collection_name (which is "listingId") instead of the actual listing ID


Add Workspace audit logs sink to FAST

https://cloud.google.com/logging/docs/audit/gsuite-login-samples
    workspace-audit-logs = {
      filter = "logName:\"/logs/cloudaudit.googleapis.com%2Fdata_access\"
      type   = "logging"
    }

+1, we should then either export all data access logs (the filter above), or finding a way to further refine the filter to only capture CI logs

workspace-audit-logs = {
  filter = "logName:\"/logs/cloudaudit.googleapis.com%2Fdata_access\"  and protoPayload.serviceName = \"login.googleapis.com\""
  type   = "logging"
}


Fix bug in roman numeral parser

Some non-roman numerals like XIIV were wrongly parsed as true
Add test cases

i think this works


fix(renovate): pin digest only for dockerfile

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.99%. Comparing base (2565445) to head (3be20f4).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   50.99%   50.99%
=======================================
  Files          73       73
  Lines        4334     4334
=======================================
  Hits         2210     2210
  Misses       1935     1935
  Partials      189      189

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Freezer-js solution

Hi Andre,
I have created a solution that uses freezer-js.
I hope it works ok and you like it :)
Cheers

Your solution should be executable by opening submissions/username/index.html in the browser with no build steps.

Works nicely, thanks!


Jumbotron Variants

Just added mixin for jumbotron and basic set of variants.
for a sake of backward compatibility:
.jumbotron = .jumbotron .jumbotron-default

I think for the time being, since we're not adding new features to v3.x and v4 is soon to land in alpha (soon, I swear), we'll punt on it for now.

Thanks though!

:+1:
Should we have the same treatment for Wells?  Seems reasonable.

:+1:
Fair enough :)

As mentioned previously elsewhere, there's a new widget in v4 that replaces & consolidates Alerts, Wells, and Panels.


Fix depends for rpms

This fixes the way dependencies are set in RPMs.  It seems like the previous changes actually broke something and left 2 places where dependencies were dealt with and that lead to depends being broken.  Here's an example (using the same test package from the previous PR).
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'zlib > 1.2' --depends 'zlib-devel > 1.2' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
zlib-devel >
zlib > 1.2
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'zlib > 1.2' --depends 'zlib-devel > 1.2' --depends foo tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
foo
zlib-devel > 1.2
zlib > 1.2

notice how sometimes the version is missing and that /bin/sh is not included in them all (even though it is supposed to be).
Here's the same commands with the fix.
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'zlib > 1.2' --depends 'zlib-devel > 1.2' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
zlib > 1.2
zlib-devel > 1.2
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'zlib > 1.2' --depends 'zlib-devel > 1.2' --depends 'foo' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
zlib > 1.2
zlib-devel > 1.2
foo

In this case all the dependencies seem to be correct.

Same suse setup, the commands from above with master
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'libz1 > 1.2' --depends 'zlib-devel > 1.2' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
zlib-devel >
libz1 > 1.2
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'libz1 > 1.2' --depends 'zlib-devel > 1.2' --depends 'foo' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
foo
zlib-devel > 1.2
libz1 > 1.2

So same behavior, now with the patch.
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'libz1 > 1.2' --depends 'zlib-devel > 1.2' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
libz1 > 1.2
zlib-devel > 1.2
> ../epm.erl -f -t rpm -n test -v 1.1.0 -a x86_64 --depends 'libz1 > 1.2' --depends 'zlib-devel > 1.2' --depends 'foo' tmp etc
> rpm -qp --requires test-1.1.0-1.x86_64.rpm
/bin/sh
libz1 > 1.2
zlib-devel > 1.2
foo

And trying to install the one with 'foo' results in
> sudo rpm -i test-1.1.0-1.x86_64.rpm
error: Failed dependencies:
        foo is needed by test-1.1.0-1.x86_64

But installing the one without (but with the zlib deps, works as expected)
> sudo rpm -i test-1.1.0-1.x86_64.rpm
>
> sudo rpm -e test zlib-devel
> sudo rpm -i test-1.1.0-1.x86_64.rpm
error: Failed dependencies:
        zlib-devel > 1.2 is needed by test-1.1.0-1.x86_64
> sudo zypper install zlib-devel
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following NEW package is going to be installed:
  zlib-devel

1 new package to install.
Overall download size: 106.6 KiB. Already cached: 0 B. After the operation,
additional 374.1 KiB will be used.
Continue? [y/n/? shows all options] (y): y
Retrieving package zlib-devel-1.2.8-10.1.x86_64
                                       (1/1), 106.6 KiB (374.1 KiB unpacked)
Retrieving: zlib-devel-1.2.8-10.1.x86_64.rpm .........................[done]
Checking for file conflicts: .........................................[done]
(1/1) Installing: zlib-devel-1.2.8-10.1.x86_64 .......................[done]
> sudo rpm -i test-1.1.0-1.x86_64.rpm
> echo $?
0


[RFC] As a developer, I can have a CD process to build and deploy the Android app to Firebase App Distribution

Why
As a developer, we need to prepare a CD process to build and deploy the Android app to Firebase (most selected).
Update CD script to build and deploy on each branch:

develop: deploy Staging build to Firebase

release: deploy UAT build to Firebase

main: deploy Production build to Firebase

Who Benefits?
Developers

@luongvo is this to deploy the template_releases or the example/ or the flaggable feature? 🤔

I expect to build and deploy the template app into Firebase. Not sure what's it being called? 🤔

@luongvo our template itself is a project that started with the python script, so it means the template app like you mentioned. As you can see, we don't have to deploy to firebase anything from this template app.
The other part is the templated app (-ed) - that is a flutter project which will be initialized from this template, and we will definitely need Deployment config for it (to Firebase), and Continuous Deployment (CD) could be another extra configuration via bitrise or github action. As you can see, there will be many things to manage when we break them down into smaller requirements that we can 'plug' into a templated app FROM this template script.
So, could you please finalize your plan accordingly so we can vote and proceed?

@luongvo @sleepylee from my understanding, deploying to Firebase is a must-have feature (most of our projects use Firebase for the app distribution), so we will implement this task into .project dir aka templated app as mentioned in #58 .  Please correct me if I'm wrong 🙇  If it is correct, we can proceed with this task in 0.7.0 imo 😄

that works, @manh-t. btw .project sounds like a bad name to me 😄  why wouldn't we use .template like rails-template, elixir-template, react-template tho 😛

@sleepylee ah yes, that sounds better 😂  I will update .project to .template in the related tasks, many thanks 💅

@manh-t that's correct. Also, we need to add a new Action workflow in the root template to generate, execute and test our CD workflow in .template project

that works, @manh-t. btw .project sounds like a bad name to me 😄 why wouldn't we use .template like rails-template, elixir-template, react-template tho 😛

So how can we mention the template project and the project to be generated in .template folder? Would they confuse together?


update broken link in web-pubsub-client and web-pubsub-client-protobuf

##[error][404] broken link https://nodejs.org/about/releases/
Checking 1 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/review/web-pubsub-client-protobuf.api.md
Checking 4 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/samples/v1-beta/javascript/README.md
Checking 5 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/samples/v1-beta/typescript/README.md
Checking 0 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/CHANGELOG.md
Checking 11 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/README.md
##[warning]broken link https://nodejs.org/about/releases/
Checking 1 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-express/review/web-pubsub-express.api.md
Checking 5 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-express/samples/v1/javascript/README.md
Checking 6 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-express/samples/v1/typescript/README.md
Checking 2 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-express/CHANGELOG.md
Checking 15 links found on page file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-express/README.md
Summary of broken links:
'file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client/README.md' has 1 broken link(s):
  https://nodejs.org/about/releases/
'file:///mnt/vss/_work/1/s/sdk/web-pubsub/web-pubsub-client-protobuf/README.md' has 1 broken link(s):
  https://nodejs.org/about/releases/
Checked 138 links with 2 broken link(s) found.

ci link: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3197805&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=aea0e0e1-1e00-5c1b-bba8-b2b238976da3

API change check
API changes are not detected in this pull request.


boot to camera

write a script so that, upon startup, open the camera.
put scripts in the public github repository (/camerasoftware directory).

Somewhat got it to work, still having issues on pulling up terminal to specify folder

@jacobstasiewicz — are you ok if i write some code (via cron) so that the shell script runs as soon as the camera is booted?

Yes I am, although I couldn't get the script to run via cron

i will try, and likely fail...

I did not try yet. in many ways the its fine at this stage if the users need to double tap the shell script to make the camera run.. i say this because debugigng is easier if the script does not run immediately


[FR] Improve Ability to detect if App has been Initialized

Is your feature request related to a problem? Please describe.
Currently there is not a way offered by the library to check if firebase_admin.initialize_app(...)(source) has been called and an app has been initialized besides catching an exception. This can result in library users seeing the following exception:

ValueError: The default Firebase app already exists. This means you called initialize_app() more than once without providing an app name as the second argument. In most cases you only need to call initialize_app() once. But if you do want to initialize multiple apps, pass a second argument to initialize_app() to give each app a unique name.
source

From the discussion in this Stackoverflow post, there are two main approaches library users have implemented:
1. use a try/except block on ValueError to get the app and initialize it if there is an exception
try:
    app = firebase_admin.get_app()
except ValueError as e:
    cred = credentials.Certificate(CREDENTIALS_FIREBASE_PATH)
    firebase_admin.initialize_app(cred)

source
Pros: simple
Cons: ValueError is a general error so theoretically the use does not know for sure the error is regarding initialization, so further inspection is needed to verify that the error is related to app initialization, e.g. a string check on "already exists".
2. check the "private" _apps variable
if not firebase_admin._apps:
    cred = credentials.Certificate('path/to/serviceAccountKey.json')
    default_app = firebase_admin.initialize_app(cred)

source
Pros: not relying on try/except flow
Cons: accessing a "private" variable, as the library owners now if you change this variable it will cause breaking changes for many library users.
Describe the solution you'd like
Option 1: Implement a function like is_initialized(name=_DEFAULT_APP_NAME)
This could check _apps for the given name and return true / false for whether it is initialized.
Option 2: Raise a specific error
Implement a new error that extends ValueError for backwards compatibility and raise the error with this new type.
For example:
class AppInitializedError(ValueError):
    def __init__(self, message):
        super().__init__(message)

This could then be used:
try:
    app = firebase_admin.get_app()
except AppInitializedError:
    cred = credentials.Certificate(CREDENTIALS_FIREBASE_PATH)
    firebase_admin.initialize_app(cred)

These implementations could be done in conjunction, however option 1 is safest as it only adds new behavior and changes no existing behavior. Furthermore there will still be those against using try / except as the "expected" way to check if the app is initialized as offered in option 2.
Describe alternatives you've considered
The alternatives are described in the stackoverflow post above (link) as well as in this issue.

Yo we need this implemented. Having massive issues in production, most of notifications are not working due to this shitty handling of initialization


"spawn /conda" does not use CONDA_PREFIX, resulting in ENOENT

My installation:
Version: 1.74.2
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:32:21.587Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.2.0
Sandboxed: No

I have a miniconda installation, which the Python extension (v2022.20.1) is able to see and use. However, when I try to run a Jupyter notebook, vscode prompts me to install the jupyter package, and then exits with the following error:
info 19:18:31.445: Process Execution: > /conda install -c conda-forge --name base jupyter -y
> /conda install -c conda-forge --name base jupyter -y
error 19:18:31.446: Error in execution Error: spawn /conda ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn /conda',
  path: '/conda',
  spawnargs: [ 'install', '-c', 'conda-forge', '--name', 'base', 'jupyter', '-y' ]
}

To my understanding, it tries to run /conda (which of course doesn't exist). However, $CONDA_PREFIX exists in the terminal and is set to the correct path. If it were added before /conda, it would probably work.
So, how can I check why it's adding that leading slash and how to force it to use the correct prefix?
Thanks

@karrtikr Thanks for your reply. I will try setting python.condaPath.
Anyway, I don't think it is a Jupyter-specific issue. The problem happened in this specific case because the Python extension tried to install Jupyter by running conda. It probably would have given the same error for any other package.

In that case please use the 'Python: Report Issue' command to open an issue on the Python extension, and make sure to include the logs.

That's what I meant to do, but among all "Python: ..." commands in the palette, the "Report issue" one is missing.

@karrtikr We use the conda executable returned by Python extension, hence not sure what we're doing wrong here, I think this issue was prematurely moved to the Jupyter extension. Lets leave this here for now.

@simopal6
Please could you install the latest pre-release version of the Jupyter extension.
& then please could you enable logging as follows:

Open settings & go into Jupyter->Logging
Change the value to verbose
Reload VS Code,
Attempt to repro the issue & then copy the output from the Jupyter output panel.

@DonJayamanne I actually already installed Jupyter from the command line. Is there any other operation I can perform that would elicit a call to conda from VSCode?

thanks, I'd like you to try out the pre-release version with vscode insiders, we fixed at least one issue with conda paths. is possible that fix will work for you too.
if not please could you enable verbose logging and provide the logs as mentioned previously.

Closing this issue as its been over 4 weeks, since the information was requested.
We'll be happy to reopen the issue when the requested information has been provided.


libcxxrt: unstable-2022-08-08 -> unstable-2023-10-11

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libcxxrt is: Implementation of the Code Sourcery C++ ABI
meta.homepage for libcxxrt is: https://github.com/libcxxrt/libcxxrt
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found unstable-2023-10-11 in filename of file in /nix/store/nlikhbffb2cqbk4p1r9hpayi55xk98qd-libcxxrt-unstable-2023-10-11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
libcxxrt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nlikhbffb2cqbk4p1r9hpayi55xk98qd-libcxxrt-unstable-2023-10-11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libcxxrt https://github.com/r-ryantm/nixpkgs/archive/b6630313824786cbb92cb998fd7acf5bd1a7ee65.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b6630313824786cbb92cb998fd7acf5bd1a7ee65#libcxxrt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nlikhbffb2cqbk4p1r9hpayi55xk98qd-libcxxrt-unstable-2023-10-11
ls -la /nix/store/nlikhbffb2cqbk4p1r9hpayi55xk98qd-libcxxrt-unstable-2023-10-11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

libcxxrt

Maintainer pings
cc @alyssais for testing.

@OfBorg build pkgsCross.x86_64-freebsd.boost


Sync with https://github.com/practicalswift/swift-compiler-crashes

Add 5 compiler crashes (+ 1 fixed crash).

I will run tests and merge.

Tests passed on OS X.


[Ops-recipe] reportchangerequests.kyverno.io deletion

Task
Add ops-recipe to explain how to delete reportchangerequests.kyverno.io resources directly form etcd.

Old issue. I no longer have the exact context of what happened.


ShareReplayConfig['refCount'] typing does not accept a function

Describe the bug
According to the docs, shareReplay configuration should accept a function refCount that allows controlling unsubscription, but the ShareReplayConfig interface defines refCount as boolean only.
https://github.com/ReactiveX/rxjs/blob/630d2b009b5ae4e8f2a62d9740738c1ec317c2d5/src/internal/operators/shareReplay.ts#L5-L10
Expected behavior
ShareReplayConfig['refCount'] should have the same type as ShareConfig['resetOnRefCountZero'].
Reproduction code
// Typing issue, functionality is not affected.

Reproduction URL
No response
Version
7.8.0
Environment
No response
Additional context
No response

According to the docs

Not sure which part of the docs refers it. Mind elaborate?

It doesn't explicitly mention what signature but this part is what I'm referring to:

As of RXJS version 6.4.0 a new overload signature was added to allow for manual control over what happens when the operators internal reference counter drops to zero.

Since refCount is actually passed as a resetOnRefCountZero property to share, their types should be identical.

That sentence is backed up by

If refCount is true, the source will be unsubscribed from once the reference count drops to zero, i.e. the inner ReplaySubject will be unsubscribed. All new subscribers will receive value emissions from a new ReplaySubject which in turn will cause a new subscription to the source observable.

Nothing explicilty said config will accept user function.

Boolean values don't allow to define manual control of the unsubscription, which is allowed by share (as shown in this https://rxjs.dev/api/operators/share#example-with-notifier-factory-delayed-reset) but not by shareReplay.

@kwonoj why did you close this issue? This issue is totally valid. It's totally valid to wish to have the same configuration options that the share() operator offers. I would also like to be able to use shareReplay() and configure it to resetOnRefCountZero using a delay of a couple seconds.


Update the browser tab title to be Homeward Tails

Please update so browser tabs say Homeward Tails

I would like to work on this issue


Hdf5 universal long double

@thewtex @dzenanz do you know what git thing I'm screwing up that I see 38 commits in this PR instead of just the 1 expected?  And how do I fix it?

It looks like you local master has diverted from the origin.

Could be, but things look in-sync to me:
leprechaun:ITK sean$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

leprechaun:ITK sean$ git push
Everything up-to-date

leprechaun:ITK sean$ git pull
Already up to date.

What does git pull upstream/master do?

leprechaun:ITK sean$ git pull upstream/master
fatal: 'upstream/master' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

leprechaun:ITK sean$ git remote -v
origin	https://github.com/seanm/ITK.git (fetch)
origin	git@github.com:seanm/ITK.git (push)
upstream	https://github.com/InsightSoftwareConsortium/ITK.git (fetch)
upstream	https://github.com/InsightSoftwareConsortium/ITK.git (push)

leprechaun:ITK sean$ git branch -vv
  hdf5-universal-long-double cae6629caa [origin/master: ahead 1] COMP: cherrypicked HDF5 upstream changes for macOS universal binary support
* master                     9b26b5deba [origin/master] Merge remote-tracking branch 'upstream/master'

I just cleanly rebased your branch on top of current master. Your branch had a long history with multiple merges with the master.

Thanks. Though I worry this will happen to me every time... I have another patch coming, so we'll see...

Your branch is up to date with 'origin/master'.

When git says this, it is only relative to the last time a fetch / pull occurred -- if the remote repository has advanced, it could not be out of date.

git pull upstream/master

We want git pull upstream master.

I usually use TortoiseGit, so my command line git-fu is rusty.

We want git pull upstream master.

OK, that certainly did something!  It gave conflict after conflict, in files that I really don't think I've ever touched, but I think I've got them all resolved.  Now my status is:
$ git status
On branch master
Your branch and 'origin/master' have diverged,
and have 13 and 37 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

I'm hesitant that I want git pull as it suggests since I just did git pull upstream master...

You don't need any further rebasing for this PR.

I know, it's my local master branch I'm trying to fix up though.

I know, it's my local master branch I'm trying to fix up though.

The most explicit command includes specifying only doing a fast forward merge:
git pull upstream master --ff-only

Frankly my repository are rather inconsistent these days with upstream/origin and master/main being common, so I am finding myself being explicit more frequently.

I know, it's my local master branch I'm trying to fix up though.

When you are in between pull requests, and if the main code repository is known as upstream according to git remote -v then you can get your master back in sync with
git checkout master && git fetch upstream && git reset --hard upstream/master

If you want to update your personal fork as well, and if it is called origin according to git remote -v then you follow those with:
git push origin +master


Switch is not compatible with fastclick

This is not a bug within react-toolbox.
The Switch element in react-toobox is basically: <label><input></label>.
There are issues in FastClick under this situation: https://github.com/ftlabs/fastclick/issues/60
FastClick is still pretty popular so it's worth it to take a look.
Even though this is not an bug in react-toolbox there's an easy fix that react-toolbox could apply:
Right now this is how I fix it:
@import 'node_modules/react-toolbox/lib/switch/theme';
//FastClick does not work well with react-toolbox Switch since a switch has a label + input inside
//https://github.com/ftlabs/fastclick/issues/60
.field {
  & > * { pointer-events: none; }
}

As you can see Switch works well with fastClick when adding that:  & > * { pointer-events: none; } on the field class.
@javivelasco close this issue if you think it's not worth it adding that style just for the sake of some compatibility. At least the issue will be here for anyone that searches and finds the problem in the future.
EDIT: The Ripple fx stops working when applying that fix. So I definitely think it's not idea to fix it as is unless you come with a better idea.

Thanks for reporting @landabaso, I think it's going to be useful for people digging into this.
I didn't know fastclick but if the solution can come with CSS you can always pass a theme down to apply the patch so thanks for your comment. I also think that applying the patch in react-toolbox would be a little out of scope. This shouldn't be rt responsibility :)
Thanks!


PANIC: called Result::unwrap() on an Err value: Any { .. } in query-engine/connectors/sql-query-connector/src/error.rs:58:51

Hi Prisma Team! My Prisma Client just crashed. This is the report:
Versions

Name
Version

Node
v16.13.0

OS
linux-arm64-openssl-1.1.x

Prisma Client
3.4.2

Query Engine
0.1.0

Database
postgresql

Logs
prisma:tryLoadEnv Environment variables not found at null
prisma:tryLoadEnv Environment variables not found at undefined
prisma:tryLoadEnv No Environment variables loaded
prisma:tryLoadEnv Environment variables not found at null
prisma:tryLoadEnv Environment variables not found at undefined
prisma:tryLoadEnv No Environment variables loaded
prisma:client clientVersion: 3.4.2
prisma:client:libraryEngine internalSetup
prisma:client:libraryEngine Search for Query Engine Library in /app/home/node_modules/.prisma/client
prisma:client:libraryEngine loadEngine using /app/home/node_modules/.prisma/client/libquery_engine-linux-arm64-openssl-1.1.x.so.node
prisma:client prisma.queryRaw(
  SELECT "Package"."content", "InstallContext"."value"
  FROM
    "Package" INNER JOIN "App" ON "Package"."appId" = "App"."id"
    INNER JOIN "Installation" ON "Package"."id" = "Installation"."packageId"
    INNER JOIN "InstallContext" ON "InstallContext"."id" = "Installation"."installContextId"
    WHERE
        "InstallContext"."key" = 'subreddit'
        AND "App"."appTypeId" IN ('PostRender')
        AND "InstallContext"."value" = $1
  , [["popular","redditdev","devvittests","u_testabledevvit"]])
prisma:client Prisma Client call:
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine graphQLToJSError
prisma:client:fetcher Error: called `Result::unwrap()` on an `Err` value: Any { .. }
    at Object.prismaGraphQLToJSError (/app/home/node_modules/@prisma/client/runtime/index.js:36310:12)
    at Object.request (/app/home/node_modules/@prisma/client/runtime/index.js:36325:22)
    at async cb (/app/home/node_modules/@prisma/client/runtime/index.js:38472:26)
    at async eval (webpack-internal:///./pages/listing.tsx:64:16)
prisma:client prisma.queryRaw(
  SELECT "Package"."content", "InstallContext"."value"
  FROM
    "Package" INNER JOIN "App" ON "Package"."appId" = "App"."id"
    INNER JOIN "Installation" ON "Package"."id" = "Installation"."packageId"
    INNER JOIN "InstallContext" ON "InstallContext"."id" = "Installation"."installContextId"
    WHERE
        "InstallContext"."key" = 'subreddit'
        AND "App"."appTypeId" IN ('PostRender')
        AND "InstallContext"."value" IN ($1)
  , [["popular","redditdev","devvittests","u_testabledevvit"]])
prisma:client Prisma Client call:
prisma:client:libraryEngine sending request, this.libraryStarted: true

Client Snippet
// PLEASE FILL YOUR CODE SNIPPET HERE

Schema
// PLEASE ADD YOUR SCHEMA HERE IF POSSIBLE

Prisma Engine Query
{"X":{}}

Hey @fizx, can you share the SQL schema of Package, Installation and InstallContext so we can reproduce this query? Does the data you have in those tables possible play a role?


file protocol support

I found that if I pass a file protocol string as the first parameter, it shows 'Invalid URI' as error.
example:
request('file://skysun/Download/1.txt', (err, response, body) => {
        if (err) {
            callback(err);
        } else {
            callback(null, body);
        }
    })

Dose Request not suppert file protocal? Or any other solution?
thanks!

Not sure if it'll fix, but file protocol URLs should generally be three '/'s and an absolute path, not two.

@sporkmonger the path is an shared path, and two '/'s works well when I open it in Chrome.

Why was this closed? The issue is not resolved, file:/// paths currently result in an error being thrown such as
Error: Invalid URI "file:///Users/tommedema/Drive/projects/forks/tm-web-resource-inliner/test/cases/assets/export.js"


Refactoring

Refactor the whole project before releasing 0.3.0. The project structure and documentation are improving (hopefully), but we should have a proper look once more functionality is added.
First, finish the refactoring introduced in branch dev-sam-refactoring. Since some of the things were already implemented, and the project changed a lot lately, it would probably be easiest just to check for the changes and directly implement them (instead of merging and making a PR).
Also, there are some further changes to consider:

Make a struct for typesafe names of variables, propositions, etc. Currently, we utilize strings everywhere, which might cause some readability issues in future.
Add type aliases or new structs instead of using really complex types, for example, the type used for cache and so on. This should definitely help with the readability.
In some cases, instead of using structs with public fields, try to rely on public methods.

Large part of the issues addressed by #17. Need to refactor further remains.

Most of the remaining things relevant for this issue were addressed by 1e893fa and are now integrated in version 0.3.0. The refactoring of some parts would still be nice, but it does not make sense before more new features are added first. Therefore, I am closing this.


When action fails, no log is provided

Describe the bug
When an operation fails (returns a failed future, or throws without returning), the information about the error is available in the downstream. However, TaskEngine does not log or provide this information in any way.
To Reproduce
Steps to reproduce the behavior:
Create an action that throws an exception or returns a failed failure. Invoke TaskEngine on it.
Expected behavior
The information is available in event log.
Actual behavior
The error information is lost
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
TaskExecutionContext actually logs the error:
    if (isFatal(error)) {
      handleFatalError((NodeFatalException) error);
    } else {
      handleRegularError(error);
    }
    FragmentEvent fragmentEvent = fragmentEventContext.getFragmentEvent();
    return Single.just(new FragmentResult(fragmentEvent.getFragment(), ERROR_TRANSITION,
        prepareErrorActionLog(error)));
  }

  private JsonObject prepareErrorActionLog(Throwable error) {
    return new JsonObject()
        .put("error", error.getMessage());
  }

However, it does not get written to the event log, and node log will not be preserved later (perhaps this is an issue too?)

Hi @marcinus, I checked this issue. You are right, this is not valid situation. I am verifying how to combine this data with ActionLog to have a single clear "invocation" syntax.

The case: HTTP Action handles an exception and adds errors to the node log (response.log.logs.errors). As you can see response.errors is empty as the fragment operation (HTTP Action) has ended without an exception. @marcinus what do you think?

@tomaszmichalak Not sure how this relates to the issue? Do you think that HTTP action should propagate exception in this case?
#132 - an issue to control success response codes from HTTP Action