Format inconsistency between graphs constructed by pdb_code and pdb_path?

Hi Arian! Seems there is format inconsistency between graphs constructed by pdb_code and pdb_path:
from graphein.protein.config import ProteinGraphConfig
from graphein.protein.graphs import construct_graph
from graphein.protein.visualisation import plot_protein_structure_graph
from graphein.protein.edges.distance import (add_peptide_bonds,
                                             add_hydrogen_bond_interactions,
                                             add_disulfide_interactions,
                                             add_ionic_interactions,
                                             add_aromatic_interactions,
                                             add_aromatic_sulphur_interactions,
                                             add_cation_pi_interactions
                                            )
from graphein.protein.features.sequence.embeddings import esm_sequence_embedding
import pickle
import matplotlib.pyplot as plt
import os
import glob
from graphein.protein.subgraphs import extract_subgraph_from_chains

new_funcs = {"edge_construction_functions": [add_peptide_bonds,
                                              add_hydrogen_bond_interactions,
                                              add_disulfide_interactions,
                                              add_ionic_interactions,
                                              add_aromatic_interactions,
                                              add_aromatic_sulphur_interactions,
                                              add_cation_pi_interactions],
              # "graph_metadata_functions": [esm_sequence_embedding]
            }

config = ProteinGraphConfig(**new_funcs)

# construct graph
g_pdbcode = construct_graph(config=config, pdb_code="1ema")
g_pdbpath = construct_graph(config=config, pdb_path="1ema.pdb")

# same?
print(g_pdbcode == g_pdbcode)
print(g_pdbpath == g_pdbpath)
print(g_pdbcode == g_pdbpath)

DEBUG:graphein.protein.graphs:Deprotonating protein. This removes H atoms from the pdb_df dataframe
DEBUG:graphein.protein.graphs:Detected 221 total nodes
INFO:graphein.protein.edges.distance:Found 78 hbond interactions.
INFO:graphein.protein.edges.distance:Found 2 hbond interactions.
INFO:graphein.protein.edges.distance:Found 2 disulfide interactions.
INFO:graphein.protein.edges.distance:Found 1645 ionic interactions.
INFO:graphein.protein.edges.distance:Found: 36 aromatic-aromatic interactions
DEBUG:graphein.protein.graphs:Deprotonating protein. This removes H atoms from the pdb_df dataframe
DEBUG:graphein.protein.graphs:Detected 221 total nodes
INFO:graphein.protein.edges.distance:Found 78 hbond interactions.
INFO:graphein.protein.edges.distance:Found 2 hbond interactions.
INFO:graphein.protein.edges.distance:Found 2 disulfide interactions.
INFO:graphein.protein.edges.distance:Found 1645 ionic interactions.
INFO:graphein.protein.edges.distance:Found: 36 aromatic-aromatic interactions
True
True
False

Hi @johnnytam100 I don't believe this is a bug. I don't think checking for equality with == is supported by NetworkX. They are different python objects - we can see this with the following example:
class Test:
    val = 1

a = Test()
b = Test()
a == b
# Output: False

Instead, we should check if the graphs are the same, rather than if the python objects are the same.
You can do this with nx.is_isomorphic():
import networkx as nx

nx.is_isomorphic(g_pdbcode, g_pdbpath)
# Output: True

The nx.is_isomorporhic function lets you define some custom functions to determine whether or not the node and edge attributes are equal between the two graphs. If you would like to work on this - that would be great and I'd be super happy to help! I think it would be a useful feature to have a simple equality function in Graphein.

Arian, I am sorry for the silly testing using ==...
I see your tests, so you confirmed the graph from pdb_code is identical to pdb_path.
Why I raised this question was because when I used graphs constructed from pdb_code and fed them into the machine learning example you provided, it worked.
However, when I used graphs constructed from pdb_path, type error appeared (possibly, somewhere requested a tensor but a list was given):
import pickle
import networkx as nx
import os
import glob
import torch
from torch_geometric.data import Data
from torch_geometric.loader import DataLoader
from graphein.ml.conversion import GraphFormatConvertor
from tqdm.notebook import tqdm
import numpy as np
from torch_geometric.data import DataLoader
from torch_geometric.nn import GCNConv, GATConv, SAGEConv, global_add_pool
from torch.nn.functional import mse_loss, nll_loss, relu, softmax, cross_entropy
from torch.nn import functional as F
from torchmetrics.functional import accuracy
from pytorch_lightning.callbacks import ModelCheckpoint
import os
import random
import pytorch_lightning as pl
import torch.nn as nn
import pandas as pd

# Load
fp_df = pd.read_csv("./target_mapping.csv")

# MAE loss
mae_loss = nn.L1Loss()

# collect graphs
path_list = []
graph_list = []

for path in glob.iglob('./selected_grep-ATOM/*.p'):
  path_list.append(path)

path_list.sort()

for path in path_list:
    with open(path, 'rb') as f:  # notice the r instead of w
        graph = pickle.load(f)
        graph_list.append(graph)

# nx2pyg
format_convertor = GraphFormatConvertor('nx', 'pyg',
                                        verbose = 'gnn',
                                        columns = None)

pyg_list = [format_convertor(graph) for graph in tqdm(graph_list)]

# assign target
for (idx, g), p in zip(enumerate(pyg_list), path_list):

    if not fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].isnull().values[0]:

        # g.y = y_list[idx]             # original
        g.y = int(fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].values[0])  # regression
        g.coords = torch.FloatTensor(g.coords[0])

# other formatting (?)
for i in pyg_list:
    if i.coords[0].shape[0] == len(i.node_id):
        pass
    else:
        print(i)
        pyg_list.remove(i)

# train, val, test split
np.random.seed(42)
idx_all = np.arange(len(pyg_list))
np.random.shuffle(idx_all)

train_idx, valid_idx, test_idx = np.split(idx_all, [int(.8*len(pyg_list)), int(.9*len(pyg_list))])
train, valid, test = [pyg_list[i] for i in train_idx], [pyg_list[i] for i in valid_idx], [pyg_list[i] for i in test_idx]

# compile model
config_default = dict(
    n_hid = 8,
    n_out = 8,
    batch_size = 4,
    dropout = 0.5,
    lr = 0.005,
    num_heads = 32,
    num_att_dim = 64,
    model_name = 'GAT'
)

class Struct:
    def __init__(self, **entries):
        self.__dict__.update(entries)

config = Struct(**config_default)

global model_name
model_name = config.model_name

class GraphNets(pl.LightningModule):
    def __init__(self):
        super().__init__()

        if model_name == 'GCN':
            self.layer1 = GCNConv(in_channels=3, out_channels=config.n_hid)
            self.layer2 = GCNConv(in_channels=config.n_hid, out_channels=config.n_out)

        elif model_name == 'GAT':
            self.layer1 = GATConv(3, config.num_att_dim, heads=config.num_heads, dropout=config.dropout)
            self.layer2 = GATConv(config.num_att_dim * config.num_heads, out_channels = config.n_out, heads=1, concat=False,
                                 dropout=config.dropout)

        elif model_name == 'GraphSAGE':
            self.layer1 = SAGEConv(3, config.n_hid)
            self.layer2 = SAGEConv(config.n_hid, config.n_out)

        self.decoder = nn.Linear(config.n_out, 1)

    def forward(self, g):
        x = g.coords
        x = F.dropout(x, p=config.dropout, training=self.training)
        x = F.elu(self.layer1(x, g.edge_index))
        x = F.dropout(x, p=config.dropout, training=self.training)
        x = self.layer2(x, g.edge_index)
        x = global_add_pool(x, batch=g.batch)
        x = self.decoder(x)
        # return softmax(x)     # original
        return x

    def training_step(self, batch, batch_idx):
        x = batch
        y = x.y
        y_hat = self(x)
        # loss = cross_entropy(y_hat, y)    # original
        loss = mae_loss(y_hat, y.float())
        # acc = accuracy(y_hat, y)            # original

        self.log("train_loss", loss)
        # self.log("train_acc", acc)          # original
        return loss

    def validation_step(self, batch, batch_idx):
        x = batch
        y = x.y
        y_hat = self(x)
        # loss = cross_entropy(y_hat, y)    # original
        loss = mae_loss(y_hat, y.float())
        # acc = accuracy(y_hat, y)          # original
        self.log("valid_loss", loss)
        # self.log("valid_acc", acc)        # original

    def test_step(self, batch, batch_idx):
        x = batch
        y = x.y
        y_hat = self(x)
        # loss = cross_entropy(y_hat, y)    # original
        loss = mae_loss(y_hat, y.float())
        # acc = accuracy(y_hat, y)            # original

        # y_pred_softmax = torch.log_softmax(y_hat, dim = 1)    # original
        # y_pred_tags = torch.argmax(y_pred_softmax, dim = 1)    # original
        # f1 = f1_score(y.detach().cpu().numpy(), y_pred_tags.detach().cpu().numpy(), average = 'weighted')   # original

        self.log("test_loss", loss)
        # self.log("test_acc", acc)         # original
        # self.log("test_f1", f1)           # original

    def configure_optimizers(self):
        optimizer = torch.optim.Adam(self.parameters(), lr=config.lr)
        return optimizer

GraphNets()

file_path = './graphein_model'
if not os.path.exists(file_path):
    os.mkdir(file_path)

checkpoint_callback = ModelCheckpoint(
    monitor="valid_loss",
    dirpath=file_path,
    filename="model-{epoch:02d}-{val_loss:.2f}",
    save_top_k=1,
    mode="min",
)

# data loader
train_loader = DataLoader(train, batch_size=config.batch_size, shuffle = True, drop_last = True)
valid_loader = DataLoader(valid, batch_size=32)
test_loader = DataLoader(test, batch_size=32)

# train model
model = GraphNets()
trainer = pl.Trainer(max_epochs=400, gpus=-1, callbacks=[checkpoint_callback])
trainer.fit(model, train_loader, valid_loader)

# evaluate on the model with the best validation set
best_model = GraphNets.load_from_checkpoint(checkpoint_callback.best_model_path)
out_best_test = trainer.test(best_model, test_loader)[0]

100%
26/26 [00:00<00:00, 247.86it/s]
/usr/local/lib/python3.7/dist-packages/torch_geometric/deprecation.py:12: UserWarning: 'data.DataLoader' is deprecated, use 'loader.DataLoader' instead
  warnings.warn(out)
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]

  | Name    | Type    | Params
------------------------------------
0 | layer1  | GATConv | 12.3 K
1 | layer2  | GATConv | 16.4 K
2 | decoder | Linear  | 9
------------------------------------
28.7 K    Trainable params
0         Non-trainable params
28.7 K    Total params
0.115     Total estimated model params size (MB)
Data(edge_index=[2, 312], node_id=[226], coords=[226, 3], name=[1], dist_mat=[1], num_nodes=226, y=511)
Data(edge_index=[2, 304], node_id=[231], coords=[231, 3], name=[1], dist_mat=[1], num_nodes=231, y=538)
Data(edge_index=[2, 313], node_id=[226], coords=[226, 3], name=[1], dist_mat=[1], num_nodes=226, y=516)
Data(edge_index=[2, 314], node_id=[225], coords=[225, 3], name=[1], dist_mat=[1], num_nodes=225, y=500)
Data(edge_index=[2, 328], node_id=[236], coords=[236, 3], name=[1], dist_mat=[1], num_nodes=236, y=609)
Data(edge_index=[2, 304], node_id=[231], coords=[231, 3], name=[1], dist_mat=[1], num_nodes=231, y=633)
Data(edge_index=[2, 319], node_id=[239], coords=[239, 3], name=[1], dist_mat=[1], num_nodes=239, y=440)
Data(edge_index=[2, 332], node_id=[236], coords=[236, 3], name=[1], dist_mat=[1], num_nodes=236, y=596)
Data(edge_index=[2, 338], node_id=[234], coords=[234, 3], name=[1], dist_mat=[1], num_nodes=234, y=516)
Data(edge_index=[2, 292], node_id=[222], coords=[222, 3], name=[1], dist_mat=[1], num_nodes=222, y=519)
Data(edge_index=[2, 318], node_id=[238], coords=[238, 3], name=[1], dist_mat=[1], num_nodes=238, y=509)
/usr/local/lib/python3.7/dist-packages/pytorch_lightning/callbacks/model_checkpoint.py:631: UserWarning: Checkpoint directory /content/google_drive/MyDrive/Colab Notebooks/AlphaFold_graph/graphein_model exists and is not empty.
  rank_zero_warn(f"Checkpoint directory {dirpath} exists and is not empty.")
/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/data_loading.py:133: UserWarning: The dataloader, val_dataloader 0, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 8 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  f"The dataloader, {name}, does not have many workers which may be a bottleneck."
/usr/local/lib/python3.7/dist-packages/torch/nn/modules/loss.py:96: UserWarning: Using a target size (torch.Size([1])) that is different to the input size (torch.Size([1, 1])). This will likely lead to incorrect results due to broadcasting. Please ensure they have the same size.
  return F.l1_loss(input, target, reduction=self.reduction)
/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/data_loading.py:133: UserWarning: The dataloader, train_dataloader, does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` (try 8 which is the number of cpus on this machine) in the `DataLoader` init to improve performance.
  f"The dataloader, {name}, does not have many workers which may be a bottleneck."
/usr/local/lib/python3.7/dist-packages/pytorch_lightning/trainer/data_loading.py:433: UserWarning: The number of training samples (3) is smaller than the logging interval Trainer(log_every_n_steps=50). Set a lower value for log_every_n_steps if you want to see logs for the training epoch.
  f"The number of training samples ({self.num_training_batches}) is smaller than the logging interval"
Epoch 0: 0%
0/4 [00:00<?, ?it/s]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[<ipython-input-134-9bf1e531b586>](https://localhost:8080/#) in <module>()
    188 model = GraphNets()
    189 trainer = pl.Trainer(max_epochs=400, gpus=-1, callbacks=[checkpoint_callback])
--> 190 trainer.fit(model, train_loader, valid_loader)
    191
    192 # evaluate on the model with the best validation set

26 frames
[/usr/local/lib/python3.7/dist-packages/torch_geometric/data/collate.py](https://localhost:8080/#) in <listcomp>(.0)
    129         if cat_dim is None or elem.dim() == 0:
    130             values = [value.unsqueeze(0) for value in values]
--> 131         slices = cumsum([value.size(cat_dim or 0) for value in values])
    132         if increment:
    133             incs = get_incs(key, values, data_list, stores)

AttributeError: 'list' object has no attribute 'size'

Do you know what could be the possibility that caused the difference between input graphs from pdb_code and pdb_path?

In particular, I want to understand this part, what does it do?
# other formatting (?)
for i in pyg_list:
    if i.coords[0].shape[0] == len(i.node_id):
        pass
    else:
        print(i)
        pyg_list.remove(i)

Hey @johnnytam100, no problem at all. I’ll take a closer look at your code later today.
With respect to the code block you quoted:
# other formatting (?)
for i in pyg_list:
    if i.coords[0].shape[0] == len(i.node_id):
        pass
    else:
        print(i)
        pyg_list.remove(i)

This loops over the list of converted graphs, and simply checks if the shape of the coordinate array matches the number of nodes in the graph. E.g. do we have a coordinate for each node and do we have a node for each coordinate.

So, I'm not sure why this would be different between the graphs created from pdb files and from pdb codes but I think the problem is here:
for (idx, g), p in zip(enumerate(pyg_list), path_list):

    if not fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].isnull().values[0]:

        # g.y = y_list[idx]             # original
        g.y = int(fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].values[0])  # regression
        g.coords = torch.FloatTensor(g.coords[0])

From what I understand, you're checking to see if the dataset has a label. If it does, you assign the label to g.y and you convert the coordinates to FloatTensors. The problem is that your list of graphs (pyg_list) still contains graphs that don't have a label. You've converted the graphs that have a label correctly but you haven't removed the graphs that don't have a label and so some of them will have list types for g.coords. This is what causes the problem when calling F.dropout() in the model.
I think the correct way to do this is a very simple fix:
for (idx, g), p in zip(enumerate(pyg_list), path_list):

    if not fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].isnull().values[0]:

        # g.y = y_list[idx]             # original
        g.y = int(fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].values[0])  # regression
        g.coords = torch.FloatTensor(g.coords[0])
    else:
        pyg_list.remove(g)

@a-r-j Thank you so much for helping out!!! Yes, you exactly described what I was trying to do. I wrote something very similar before, but then there is another error:
100%
104/104 [00:00<00:00, 338.44it/s]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[<ipython-input-87-49aa837a2ea3>](https://localhost:8080/#) in <module>()
     64 # other formatting (?)
     65 for i in pyg_list:
---> 66     if i.coords.shape[0] == len(i.node_id):        # <---- here
     67         pass
     68     else:

AttributeError: 'list' object has no attribute 'shape'

However, I now got a fix that I don't know why: by writing two consecutive loops to remove the graph without y.
# Load
fp_df = pd.read_csv("./20220307_fpbase_all.csv")

# Label col
label_col = "states.0.em_max"

# MAE loss
mae_loss = nn.L1Loss()

# graphs from pdb_path
path_list = []
graph_list = []

for path in glob.iglob('./selected_grep-ATOM/*.p'):
  path_list.append(path)

path_list.sort()

for path in path_list:
    with open(path, 'rb') as f:  # notice the r instead of w
        graph = pickle.load(f)
        graph_list.append(graph)

# nx2pyg
format_convertor = GraphFormatConvertor('nx', 'pyg',
                                        verbose = 'gnn',
                                        columns = None)

pyg_list = [format_convertor(graph) for graph in tqdm(graph_list)]

# assign target
for (idx, g), p in zip(enumerate(pyg_list), path_list):

    if not fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].isnull().values[0]:

        # g.y = y_list[idx]             # original
        g.y = int(fp_df.loc[fp_df["uuid"]==p[21:26]][label_col].values[0])

    g.coords = torch.FloatTensor(g.coords[0])

# other formatting (?)
for i in pyg_list:
    if i.coords.shape[0] == len(i.node_id):
        pass
    else:
        print(i)
        pyg_list.remove(i)

for i in pyg_list:
    if i.y == None:
        print(i)
        pyg_list.remove(i)

# still have one graph don't have y, I don't know why

for i in pyg_list:
    if i.y == None:
        print(i)
        pyg_list.remove(i)

# now all graphs have y


Doc: Mention the differences to the existing vscode-tslint

Testing: https://github.com/Microsoft/vscode/issues/62092
To ease the migration the Readme should document the difference to vscode-tslint.
I tried to do this an older version of the extension
https://github.com/Microsoft/vscode-ts-tslint#differences-between-vscode-tslint-vnext-and-vscode-tslint

The TSLint extension bundles a tslint and typescript version.

@mjbvz this is no longer true, the tslint version is now loaded either locally from the workspace or globally. I´ve already deleted the bullet in the Readme, but the Readme should explain how tslint and typescript are located.

The extension requires that the tslint and typescript modules are installed either locally or globally. The extension will use the tslint module that is installed closest to the linted file. To install tslint and typescript globally you can run npm install -g tslint typescript.


GSB: Refactor away some usages of removeSelfDerived()

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Section 18.3.8 Decline Reply message

OLD:
The client includes a Status Code option (see [Section 21.13](https://datatracker.ietf.org/doc/html/rfc8415# section-21.13))
with the value Success, a Server Identifier option (see [Section 21.3(https://datatracker.ietf.org/doc/html/rfc8415#section-21.3)) with the server's DUID, and a Client Identifier option (see Section 21.2) with the client's DUID.
NEW:
The server includes a Status Code option....

Hi … not sure what or why this was generated, but this was fixed in 8415bis already.- Bernie (from iPad)On Mar 9, 2023, at 9:55 AM, Timothy Winters @.***> wrote:
OLD:
The client includes a Status Code option (see [Section 21.13](https://datatracker.ietf.org/doc/html/rfc8415# section-21.13))
with the value Success, a Server Identifier option (see [Section 21.3(https://datatracker.ietf.org/doc/html/rfc8415#section-21.3)) with the server's DUID, and a Client Identifier option (see Section 21.2) with the client's DUID.
NEW:
The server includes a Status Code option....
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Already fixed.


How to render text with html element

I want to render Sweetalert with text having HTML elements, How can I fo that? Right now I am rendering the Sweetalert like this
<SweetAlert
  show={showConfirm}
  title={title}
  text="Are you sure you want to remove task Rolling?"
  showCancelButton
  confirmButtonText="Confirm"
  customClass="confirm-modal confirm-delete-modal"
  onConfirm={this.handleConfirmClick}
  onCancel={this.hideConfirm}
/>

So here, instead of showing Rolling in bold letters it is rendering text as Are you sure you want to remove task Rolling?

use html={...} instead of text={...}


CRC setup helper

optional step to add CRC setup helper target.

not, this also includes the commit for https://github.com/dprince/install_yamls/pull/1


Wrong Safari requirements

If I go to keyboot.org with desktop Safari 8.0 on Yosemite 10.10.1, I get the following message:

Sorry, your browser doesn't support web crypto. You will need at least:
Internet Explorer 11
Firefox 35
Chrome 37
Safari { Desktop: 7.1, iOS: 8 }

I'd expect either the app to run, or the version requirement to be consistent and tell me that desktop Safari 8 is not supported.

Safari, v8 at least, exposes subtle under crypto.webkitSubtle.


bug/'isalnum' referenced before assignment

Describe the bug
if char.isalnum() != isalnum:
UnboundLocalError: local variable 'isalnum' referenced before assignment
To Reproduce
Provide a code snippet that reproduces the issue.
from langchain.document_loaders import UnstructuredPDFLoader
loader = UnstructuredPDFLoader(file_path, mode = "elements", strategy = "hi_res", pdf_infer_table_structure = True, hi_res_model_name = "chipper")
elements = loader.load()
Expected behavior
Expected for the contents of the PDF to load.
Screenshots

Environment Info
Please run python scripts/collect_env.py and paste the output here.
This will help us understand more about the environment in which the bug occurred.
Additional context
Add any other context about the problem here.

Hi @nikunjgoel95! if possible, would you mind sharing the document you were working on?

I experienced the same issue and reported it here: https://github.com/langchain-ai/langchain/discussions/11247
It worked yesterday with my PDF sets and this has become an issue just in the previous hours.

Yes, I just experienced the same issue. It worked a few days ago, and now it doesn't (no changes' made)

Having the exact same issue

@Klaijan Hi, it is failing on this pdf. Hope it helps.

here's an error trace -- https://gist.github.com/pchalasani/802c91e897b6433551106ec51942a626

I have the same problem as well.

FYI fix is almost in over here: https://github.com/Unstructured-IO/unstructured/pull/1586

Fix is merging real soon https://github.com/Unstructured-IO/unstructured/pull/1586/! Thank you all for reporting the issue!

@Klaijan Thank you so much for your help!

It is merged now!

Upgraded to  0.0.312 but still getting the error "An error occurred: cannot access local variable 'isalnum' where it is not associated with a value" when i try to load a pdf using DirectoryLoader

Upgraded to langchain 0.0.312 but still getting error "An error occurred: cannot access local variable 'isalnum' where it is not associated with a value" when i try to load a pdf using UnstructuredPDFLoader

Hi @asharda , can you make sure unstructured gets updated as well? pip freeze should show version 0.10.21. I'm not sure if langchain will pull in the latest automatically.


props spread?

Is there a plan to allow a generic props spread, a la
<SomeComponent {...props} />

?

Hi, props spread is supported. Eg:
In
const App = (props) => pug`
  .app(...props) Contents
`

Out
const App = (props) => {
  return <div {...props} className="app">Contents</div>
}

Ah, great.

Please reopen this issue.
Prop spread doesn't work in conjunction with any other props (which is used for Animation in conjunction with gestures) i.e.
<Animated.View
            key={item.id}
            style={[this.getCardStyle(), styles.cardStyle, { zIndex: 99 }]}
            {...this.state.panResponder.panHandlers}
          >
            {this.props.renderCard(item)}
</Animated.View>

Could you provide an example of when it doesn't work in conjunction with other props?
If you try the following, it should work:
import { Animated } from 'react-native';
const AnimatedView = Animated.View;

// rest of code

const viewStyles = [this.getCardStyles(), styles.cardStyle, {zIndex: 99}])

pug`
  AnimatedView(key=item.id, style=viewStyles, ...this.state.panResponder.panHandlers)
`

I believe it's another issue causing the problem as the Animated.View doesn't work when used in conjunction with pug, this is because it conflicts with the way class names are defined. i.e.
pug`
  Animated.View
`

will become:
<Animated className="View" />


Delete EPerson from "Edit EPerson" form

References

Fixes #2291

Description
There has been a refactor of the methods participating in EPerson delete action, including avoiding nested subscriptions and removing unnecessary events.
Instructions for Reviewers
List of changes in this PR:

First, refactor the delete() method of EPersonFormComponent, in order to avoid nested subscriptions and manage of disabling the delete button when the delete of the entity is confirmed (since the request takes a whole and the button can be clicked again). After the delete has finished successfully, we only need to notify the user for the status of the deletion, there is no need to trigger a submit of the form. So the this.submitForm.emit() is removed.
Second, thereset()method of EPeopleRegistryComponent is refactored for the same reason, to avoid nested subscriptions.
Another change would include removing the call of onCancel() method on destroy of EPersonFormComponent. This method is called also when going back from the "edit" form to the list and the logic this method contains is also used when needed in other methods, so there is no need for an extra execution of the logic inside onCancel() method.

Include guidance for how to test or review your PR.
Steps to reproduce the bug are the same as the ones mentioned in #2291 .
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

@tdonohue , ok, I will open a new issue for this "bug". I was wondering why the two implementations (epeople and group administration) do not have the same base components, e.g. a common list component.

👉 https://github.com/DSpace/dspace-angular/issues/2302


Sidekick may not launch in Windows 11 Insiders build

Current workaround is to run the portable or unsiged version of Sidekick in Windows 8 Compatibility mode, unknown cause.

How can it be run in compatibility mode for Windows 8? I'm not seeing this option on right click.

Properties> Compatibility> Windows 8

Can you go to the event viewer Windows Logs > Application and see what error is causing the app to crash?

Can you go to the event viewer Windows Logs > Application and see what error is causing the app to crash?

Sure thing. See the information below.
I have uploaded the Report.wer file here
1: Information from the error event
Log Name:      Application
Source:        Application Error
Date:          6/22/2022 10:15:54
Event ID:      1000
Task Category: Application Crashing Events
Level:         Error
Keywords:
User:          KENICE-X360\kenic
Computer:      Kenice-x360
Description:
Faulting application name: sidekick.exe, version: <IP_ADDRESS>, time stamp: 0x627cfcda
Faulting module name: sidekick.exe, version: <IP_ADDRESS>, time stamp: 0x627cfcda
Exception code: 0xc000041d
Fault offset: 0x00000000000058a0
Faulting process id: 0x0xAAD0
Faulting application start time: 0x0x1D8864293C6006C
Faulting application path: C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe
Faulting module path: C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe
Report Id: 45ad9240-6a85-42fb-a077-a844977faaeb
Faulting package full name: 44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2
Faulting package-relative application ID: sidekick
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">   <System>     <Provider Name="Application Error" Guid="{a0e9b465-b939-57d7-b27d-95d8e925ff57}" />     <EventID>1000</EventID>     <Version>0</Version>     <Level>2</Level>     <Task>100</Task>     <Opcode>0</Opcode>     <Keywords>0x8000000000000000</Keywords>     <TimeCreated SystemTime="2022-06-22T14:15:54.4148129Z" />     <EventRecordID>8981</EventRecordID>     <Correlation />     <Execution ProcessID="37300" ThreadID="4824" />     <Channel>Application</Channel>     <Computer>Kenice-x360</Computer>     <Security UserID="S-1-5-21-2056601378-3457062421-2058283205-1001" />   </System>   <EventData>     <Data Name="AppName">sidekick.exe</Data>     <Data Name="AppVersion"><IP_ADDRESS></Data>     <Data Name="AppTimeStamp">627cfcda</Data>     <Data Name="ModuleName">sidekick.exe</Data>     <Data Name="ModuleVersion"><IP_ADDRESS></Data>     <Data Name="ModuleTimeStamp">627cfcda</Data>     <Data Name="ExceptionCode">c000041d</Data>     <Data Name="FaultingOffset">00000000000058a0</Data>     <Data Name="ProcessId">0xaad0</Data>     <Data Name="ProcessCreationTime">0x1d8864293c6006c</Data>     <Data Name="AppPath">C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe</Data>     <Data Name="ModulePath">C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe</Data>     <Data Name="IntegratorReportId">45ad9240-6a85-42fb-a077-a844977faaeb</Data>     <Data Name="PackageFullName">44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2</Data>     <Data Name="PackageRelativeAppId">sidekick</Data>   </EventData> </Event>

Information from the Information log event

`Fault bucket<PHONE_NUMBER>754254672, type 5
Event Name: MoAppCrash
Response: Not available
Cab Id: 0
Problem signature:
P1: 44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2
P2: praid:sidekick
P3: <IP_ADDRESS>
P4: 627cfcda
P5: sidekick.exe
P6: <IP_ADDRESS>
P7: 627cfcda
P8: c000041d
P9:<PHONE_NUMBER>0058a0
P10:
Attached files:
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.8925dd53-52ac-47bc-b9cb-2c1e44a878a7.tmp.mdmp
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.cb9fc526-667f-4c7e-8412-c929a467ded6.tmp.WERInternalMetadata.xml
WPR_initiated_DiagTrackMiniLogger_OneTrace_User_Logger_20220619_1_EC_0_inject.etl
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.904c0961-4c6f-4f25-9686-f72358779edd.tmp.etl
WPR_initiated_DiagTrackMiniLogger_WPR System Collector_inject.etl
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.f48c394a-a5a5-4593-9462-f62d4d913b05.tmp.etl
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.360b720b-8e9a-4781-ae0e-1015d5cd36a3.tmp.csv
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.c7dc90d8-7d1e-40fc-bfe5-bdb84868e545.tmp.txt
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER.82b97aeb-3d96-4b6b-aa1f-0b52dbfd9e1f.tmp.xml
These files may be available here:
\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_44484EduardoM.Si_846aae847231d21628da4b4b0f6ca6b6621334a_f814c776_915fd0c7-0508-4983-99f3-f52ac54c1354
Analysis symbol:
Rechecking for solution: 0
Report Id: 45ad9240-6a85-42fb-a077-a844977faaeb
Report Status: 268435456
Hashed bucket: 249d375036c61da80b7e6274899f7750
Cab Guid: 0`

Have you tried the execuatble in compatibility mode or just the MS Store app?

Ok, well at least you got it running. Still not sure what the issue is. I'm inclined to think it's Flutter's fault but other Flutter apps do indeed run fine on Windows 11 Insider builds...

Hey! Are you still having issues? It's opening fine on my computer.

Closing as it seems the release is working fine now on Insider builds

Version	22H2
Installed on	7/19/2022
OS build	22621.382
Serial number	PF20D0BS
Experience	Windows Feature Experience Pack 1000.22632.1000.0

installed sidestick from Microsoft Store latest one not opening

@Shiba-Kar can you send the event viewer details?

I got the same event message when it crashed. It looks like the crash only happens on Windows 11 Insider Beta (22621 or 22622) and not the current Dev channel (build 25169+).
Here's the event from Event Viewer:
Faulting application name: sidekick.exe, version: <IP_ADDRESS>, time stamp: 0x627cfcda
Faulting module name: sidekick.exe, version: <IP_ADDRESS>, time stamp: 0x627cfcda
Exception code: 0xc000041d
Fault offset: 0x00000000000058a0
Faulting process id: 0x0x1BB8
Faulting application start time: 0x0x1D8C2629A866D20
Faulting application path: C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe
Faulting module path: C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe
Report Id: f44cd76f-c1da-42f4-9027-05e2b9af87fc
Faulting package full name: 44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2
Faulting package-relative application ID: sidekick

Here's the information from Windows Problem Reports:
Source
A new Flutter project.

Summary
Stopped working

Date
07/09/2022 9:36

Status
Report sent

Description
Faulting Application Path:	C:\Program Files\WindowsApps\44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2\sidekick.exe

Problem signature
Problem Event Name:	MoAppCrash
Package Full Name:	44484EduardoM.SidekickFlutter_<IP_ADDRESS>_x64__s75e7293cm0w2
Application Name:	praid:sidekick
Application Version:	<IP_ADDRESS>
Application Timestamp:	627cfcda
Fault Module Name:	sidekick.exe
Fault Module Version:	<IP_ADDRESS>
Fault Module Timestamp:	627cfcda
Exception Code:	c000041d
Exception Offset:<PHONE_NUMBER>0058a0
OS Version:	10.0.226<IP_ADDRESS>.256.164
Locale ID:	14345
Additional Information 1:	86e7
Additional Information 2:	86e714a62d54964f44e802ab89184503
Additional Information 3:	f855
Additional Information 4:	f8557989c6c829b6ae244394a237164c

Extra information about the problem
Bucket ID:	249d375036c61da80b7e6274899f7750<PHONE_NUMBER>754254672)

All crashes have the exact same stack trace attached. It seems

Frame
Image
Function
Offset

0
sidekick.exe
null
0x00000000000058A0

1
sidekick.exe
null
5B5E

2
sidekick.exe
null
0x00000000000061E9

3
comctl32.dll
CallNextSubclassProc
0x00000000000000B8

4
comctl32.dll
MasterSubclassProc
EC

5
user32.dll
UserCallWinProcCheckWow
0x000000000000036C

6
user32.dll
DispatchClientMessage
0x000000000000009C

7
user32.dll
__fnINOUTNCCALCSIZE
0x0000000000000045

8
ntdll.dll
KiUserCallbackDispatcherContinue
0x0000000000000000

9
win32u.dll
ZwUserCreateWindowEx
0x0000000000000014

10
user32.dll
VerNtUserCreateWindowEx
0x0000000000000310

11
user32.dll
CreateWindowInternal
0x00000000000001D1

12
user32.dll
CreateWindowExW
0x0000000000000082

13
sidekick.exe
null
2DA1

14
sidekick.exe
null
0x0000000000002114

15
sidekick.exe
null
0x00000000000057C2

16
kernel32.dll
BaseThreadInitThunk
0x000000000000001D

17
ntdll.dll
RtlUserThreadStart
0x0000000000000028

I'm going to continue ivestigating to see why this may be happening. Thank you to everyone who has submitted their reports to MS, they are helping a lot :)

Experiencing the same with a fresh install of Windows 11 and fresh install of Sidekick from Windows Store.
Edition	Windows 11 Pro
Version	22H2
Installed on	23/09/2022
OS build	22621.521
Experience	Windows Feature Experience Pack 1000.22634.1000.0

@nicodumdum does it work with compatibility mode?

Hi @aguilaair , yes I tried running it in Windows 8 compatibility but no luck. :(

Ok, I will take a look ASAP
I currently don't have a W11 device

Facing the same issue in

Properties> Compatibility> Windows 8

Thanks @aguilaair :) with compatibility mode on Window 8 it's starting again on 22h2 update :)

Ok, that's good to know, but what exactly is casuing the issues? I'm honestly very lost...

Facing the same issue, running in compatibility mode did not work :(

Running in windows 8 compatibility mode worked only once

Okay, I now have a device with the W11 H2 Update, let's see what's going on...

Also facing the same issue. Installed Windows 11 Pro 22H2 yesterday and Flutter Sidekick doesn't start (Windows Store version).

@Rexobias the new release is currently under review in the Microsoft store, as soon as this gets approved it will start working again.
In the meantime, please download and install the latest version from the releases tab


Include this video somehow.

https://www.youtube.com/watch?v=txuWGoZF3ew
As requested by Mr. Mike.

Fixed here https://github.com/stronglifters/surface/pull/29


HTTP Error 503: Service Unavailable

I am using this service(TextBlob version 0.11.1) an year ago. But facing 503 error code in response from last few days. Please tell either the service is down or my IP address is blocked or the free version of this service is no longer available. Thanks

It appears Google is shutting down the API that this depends on. See #137 for further discussion.


Use lockfile to determine package manager. Or use https://github.com/antfu/ni

I had an issue where it wasn't using pnpm even thought I had a pnpm lockfile. I was able to overrie the npm_agent_... env var but I think it would be better if that was picked up from the lockfile. Can make a PR if you want. Might be easier to use antfu's lib which has some of this logic.

Yeah we're using npm_config_user_agent. Is there a way I can reproduce above? Happy to accept a PR with lockfile detection.

This happens if you install the package globally and use with without npx

I am using<EMAIL_ADDRESS>and this library is trying to install dependencies by yarn. The only way to fix it is upgrading antfu/ni and changing logic on packages/cli/src/utils/get-package-manager.ts

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


WIP [HAWKULAR-3] Directory structure and architecture changes. Don't merge

Everything should be good to go in this repo. The bower package generated from hawkular-console is not being built quite right as can be seen in libs/hawkular-console.
I'll finish tomorrow or someone else can also look.

This has been merged. Everything good.


Material Components redesign tracker

[ ] TunnelCreatorActivity has no action bar to save items
[x]  AMOLED/Dark themes have zero distinction between bottom bar and window background (f17847dc978f72138dcef411bc66b460de47787d)
[ ] Is adding a bottom margin really the best way to ensure bottombar doesn't overlap with peers in Tunnel{Editor,Creator} flows?
[ ] Snackbars need to be readjusted to show above the BottomAppBar
[ ] Navigation button needs to be change to a back button when we move to inner fragments

The bottombar redesign is abandoned for now


Docs: add indeterminate disabled checkbox example

Based on the work of @louismaximepiton this PR proposes to add a "Disabled indeterminate checkbox" example in Forms > Check & radios > Disabled.
Live preview

Would we ever want to add a custom indeterminate attribute to use as a selector? If not, I think a class might make most sense.

Would we ever want to add a custom indeterminate attribute to use as a selector? If not, I think a class might make most sense.

You mean in the library itself (by having let's say as an example an .indeterminate class that will automatically launch the JS and then remove the class) or just for the documentation?
For the documentation I tried to avoid having an extra-class so that it is still understandable for the user (when copy/pasting or editing via StackBlitz) that the indeterminate state can only be set by JavaScript.

That all sounds good. I appreciate the goal of keeping the source code lean for the end user.


Missing shims for IE

Angular2 beta 7 currently requires several shims to work with IE.  If you build and run the project as-is in IE11, it will throw several exceptions and fail to start:
Line: 38
Error: Object doesn't support property or method 'keys'
Line: 422
Error: Unable to get property 'createFromList' of undefined or null reference

To fix, I modified vendor.ts to add the following lines at the top:
// fixes for IE
import 'es6-shim/es6-shim.js';
import './shims_for_IE.js';

The shims_for_IE.js file is located in node_modules/angular2/es6/dev/src/testing/shims_for_IE.js.  However, I was not able to import directly from this path.  Webpack kept claiming that it could not find the file/directory.  I'm not sure if a package.json file somewhere along the path is confusing things, or  why that doesn't work.  I finally gave up and copied shims_for_IE.js to the my-app\src folder so that it sits next to vendor.ts.

Thanks, I added the missing shims.
You were right that it doesn't import from node_modules/angular2/es6/dev/src/testing/shims_for_IE.js, but I don't know why though...
@Foxandxss any idea ?

I have no idea.

@ocombe @Foxandxss according to the finding of the user in this issue https://github.com/angular/angular/issues/7259 the problem is because of exclude : ["node_modules"] in tsconfig.json as you have here https://github.com/preboot/angular2-webpack/blob/master/tsconfig.json#L11

That is pretty much what I thought (I tried without it, but takes waaaaay longer and lot of errors). I got confused because you can do import 'angular2/bundles/angular-polyfills.js and not that one.
So I thought about all of them on node_modules are UMD bundles so it works and the ignore is not applied for them.
Too much coincidences I thought.
So yeah, I don't think removing that is an option.


FTT-5: add the possibility to find flights

https://github.com/Olegushak/flight-tickets-telegrambot/pull/14


Cards for /member become massive on laptop screen

About
The cards for members become really huge on a laptop screen. This is in the /members route. Please implement a limit to how big these cards can grow
Bounty 25

Hey @anuragrao04
I can help you with this task, kindly assign it to me

Hey! I really appreciate your interest but this issue is part of an internal hacktoberfest event. I'm sorry but I can't assign it to you

Anurag fixed it


HTML5 export fails to run with error "USER WARNING: Could not create 3D renderbuffer, status: 36054"

Godot version
v4.0.alpha.custom_build [ad247899a]
System information
Chrome, GLES3
Issue description
At the moment, 3D projects exported to HTML5 will fail to run (right after loading) with the error:
USER WARNING: Could not create 3D renderbuffer, status: 36054

I suspect that it's related to the changes from PR #63901, but I don't really know.
Steps to reproduce
Steps to reproduce

Create a new project
Go to "Project settings..." and turn on "Advanced Settings"
In "Rendering" -> "Driver" set the "Driver Name" to "opengl3"
Restart the editor
Create a new scene with a Node3D as the root
Add a MeshInstance3D with a box mesh
Add a Camera3D that is pointing at the Cube, and set it to current
Save the scene, run the project, and use the current scene as the main scene when prompted
Verify that you can see the cube when running on the desktop!
Export the game to HTML5
Use the "Run exported HTML the system's default browser" button in the upper-right (the one that looks like the HTML5 logo, but the normal run button)
You'll see the loading bar and then blackness
If you look in the browser's developer console, you'll see the error message mentioned above

Minimal reproduction project
godot4-gles3-rb.zip

Not sure what changed that could have caused this because I don't think I've changed how render buffers are created on GLES3, only some organizational things changed. The big changes were all in the RenderDevice side.
Especially seeing it all still works on desktop, I'm not too familiar with the HTML side of things, maybe @clayjohn can have a look? Hopefully it's something simple.

Not sure what changed that could have caused this because I don't think I've changed how render buffers are created on GLES3, only some organizational things changed. The big changes were all in the RenderDevice side.

It was just a guess! It could be something else entirely. Weird things can break WebGL - it's closer to GLES than OpenGL, and can be stricter (or just different) than OpenGL. But rendering is one of my weaker areas so I'm a little bit out of my depth here :-)


add Validating GraphML writer

similar to ValidatingXmlWriter,
ensure that the structure of GrapML as defined in the spec/DTD is respected.
Check for the order of elements according to DTD.
DTD: http://graphml.graphdrawing.org/specification/dtd.html

Full structural DTD validation (element nesting, element order, element cardinality) turns out to be too complex.
We rely on DTD streaming validation for that ->

[ ] Max

Open issues fir this task:

[ ] validate only nesting rules (ignoring order, ignoring optional)
[ ] validate what the DTD cannot do:

[ ] hyperedges have at least 2 endpoints
[ ] edges refer only ids of existing nodes -> require set of all nodesIds, require set of all used edgeIds; resolve edges at runtime & at the end


Support for conduits?

Many *-enumerator packages have been ported to use conduits http://www.yesodweb.com/book/conduit.  Is there any plan to do this with csv-enumerator?

I certainly dont oppose it in principle, but do not have the time to immediately jump on every bandwagon that comes our way. I havent invested the time into conduits yet to judge what additional capabilities it would allow csv-enumerator specifically over the currently working enumerator implementation either.
It sounds like the major benefit would be easy embedding into conduit contexts. I'm not sure if we have a ton to gain from the resource concept.
I'd certainly be happy to hear your feedback if you think we are missing out on something.
Cheers,
Oz
On Jan 30, 2012, at 11:56 AM<EMAIL_ADDRESS>wrote:

Many *-enumerator packages have been ported to use conduits http://www.yesodweb.com/book/conduit.  Is there any plan to do this with csv-enumerator?

Reply to this email directly or view it on GitHub:
https://github.com/ozataman/csv-enumerator/issues/2

I can certainly understand not jumping too quickly; it looks like conduit will have a non-backwards-compatible API change this week:  http://www.yesodweb.com/blog/2012/01/conduit-changes-0-2
The main benefit I'm interested in is interop with other libraries which are switching to conduit.  It appears that it's possible to wrap an Iteratee to become a conduit Sink, but not possible to wrap an Enumerator to act as a conduit Source.  Since I'm using csv-enumerator for ETL type tools, it's a CSV file as a Source that I need.  For now I'm working around by reading the whole lot into RAM, which is good enough at my current scale.
If it bites me hard enough, and I have the time, I may attempt a port myself.
Cheers,
John


Add Error page in case of ElasticSearch is unavailable

We need to add timeout handler to core/lib/search and display some safe error while in SSR mode and Elastic is down (therefore page cannot be rendered)
Currently in such a  case, asyncData returns Promise which is never resolved.

We should also tweak + use config/local.json for having the Elastic query timeouts - in the SSR mode (Vue.prototype.$isServer === true)  we should have much shorter timeouts (around max. 1s)

Checklist:

[ ] ES queries: https://github.com/DivanteLtd/vue-storefront/blob/b3025f6c9675d30f7d1b7ccae46f4366024d96cd/core/store/lib/search.js#L49
[ ] Task execution engine: https://github.com/DivanteLtd/vue-storefront/blob/b3025f6c9675d30f7d1b7ccae46f4366024d96cd/core/store/lib/task.js#L39
[ ] User actions - https://github.com/DivanteLtd/vue-storefront/blob/86799892b9d1e9f94ff1af3603a94a65a469ce13/core/store/modules/user/actions.js

I've added 500 error in this case - we need to create a better looking error page anyway :)


Fix documentation issues

Corrected the order of the summaries for the guideline color values.

are you still working on this or is this put on hold, cause id really like to close this pull request

This PR is still open so that he can work on more documentation issues instead of merging every single small fix.

To be honest I completely forgot about this thing. I made those changes while doing research for the savefile video. I likely won't be working on this any time soon unless I stumble upon another issue.

Outdated PR, issue already fixed, guideline colors are also updated


批量模式空行 bug

当 list.txt 中出现空行时
https://github.com/WeepingDogel/TitleGetter
https://github.com/piggy-moe/subtitle
https://www.bilibili.com/

就会报错
weepingdogel@WeepingDogel ~/写/P/TitleGetter (master) [1]> proxychains -q python titlegetter.py

╭━━━━╮╭╮╭╮╱╱╱╱╭━━━╮╱╱╭╮╱╭╮
┃╭╮╭╮┣╯╰┫┃╱╱╱╱┃╭━╮┃╱╭╯╰┳╯╰╮
╰╯┃┃┣╋╮╭┫┃╭━━╮┃┃╱╰╋━┻╮╭┻╮╭╋━━┳━╮
╱╱┃┃┣┫┃┃┃┃┃┃━┫┃┃╭━┫┃━┫┃╱┃┃┃┃━┫╭╯
╱╱┃┃┃┃┃╰┫╰┫┃━┫┃╰┻━┃┃━┫╰╮┃╰┫┃━┫┃
╱╱╰╯╰╯╰━┻━┻━━╯╰━━━┻━━┻━╯╰━┻━━┻╯

Version: 1.0.1

Type a filename: try2
Requested Successfully
[GitHub - WeepingDogel/TitleGetter: 用来获取链接标题的小爬虫...](https://github.com/WeepingDogel/TitleGetter)
Requested Successfully
[GitHub - piggy-moe/subtitle: a command line tool for extracting hard-coded subtitles from videos](https://github.com/piggy-moe/subtitle)
Requested Successfully
[哔哩哔哩 (゜-゜)つロ 干杯~-bilibili](https://www.bilibili.com/)
Traceback (most recent call last):
  File "titlegetter.py", line 68, in <module>
    response = session.get(url,headers=headers)
  File "/usr/lib/python3.8/site-packages/requests/sessions.py", line 543, in get
    return self.request('GET', url, **kwargs)
  File "/usr/lib/python3.8/site-packages/requests/sessions.py", line 516, in request
    prep = self.prepare_request(req)
  File "/usr/lib/python3.8/site-packages/requests/sessions.py", line 449, in prepare_request
    p.prepare(
  File "/usr/lib/python3.8/site-packages/requests/models.py", line 314, in prepare
    self.prepare_url(url, params)
  File "/usr/lib/python3.8/site-packages/requests/models.py", line 388, in prepare_url
    raise MissingSchema(error)
requests.exceptions.MissingSchema: Invalid URL '': No schema supplied. Perhaps you meant http://?

目前暂时只能先检测有没有空行然后直接结束程序提醒用户自己去掉了...
# empty line checking
if url == '':
    print(empty_line_warning)
    urlist.close()
    os.remove("./out/" + filename + file_format)
    os._exit(0)
# mpty line checking

太晚了，以后再想想怎么跳过吧...

已提交


Add SDTM TS and M11 parameters to population and indication classes [CT]

See feature ticket #153:
Add flag to PopulationDefinition. This will be inherited by studyCohort and StudyDesignPopulation.
includesHealthySubjects
Add flag to indication: isRareDisease -> boolean

It took me a few minutes to work out what was being asked for. Just for clarity @BSnoeijerCD @EMuhlbradt @czwickl I think the changes are:

Class PopulationDefinition: Add attribute 'includesHealthySubjects' of type Boolean
Class indication: Add attribute 'isRareDisease' of type Boolean

NOTE: Class PopulationDefinition is inherited by studyCohort and StudyDesignPopulation

Yes. Thank you for the clarification.


0.7.0 rc Rebase

Modulus Pull Request
Description
Pull changes from the 0.7.0-rc branch
Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


chore(eval): remove many unnecessary dependencies

This greatly cleans up our flake.lock file, removing any unnecessary locks and duplicates and speeds up eval time significantly (at least 20 seconds). In addition, I've minified the transitive dependencies we had inherited through the CTL.
originally part of https://github.com/input-output-hk/partner-chains-smart-contracts/pull/87
Prereview checklist

[ ] The CHANGELOG.md has been updated under the # Unreleased header using the appropriate sub-headings with links to the appropriate issues/PRs.
[ ] All tests pass in CI
[ ] PR was self-reviewed

Unfortunately this is once again failing with the error that we had before:
building '/nix/store/m1d4r6n2050l38x8g03bjd0jw3vxxs27-combined-check.drv'...
combined-check> /nix/store/bf1cms8x178cp7mjcc9spzkrj4hw8w7x-image-sidechain-main-cli-docker.json: line 110: syntax error: unexpected end of file
error: builder for '/nix/store/m1d4r6n2050l38x8g03bjd0jw3vxxs27-combined-check.drv' failed with exit code 2;
       last 1 log lines:
       > /nix/store/bf1cms8x178cp7mjcc9spzkrj4hw8w7x-image-sidechain-main-cli-docker.json: line 110: syntax error: unexpected end of file

@tgunnoe I forgot what you said that one was about

Unfortunately this is once again failing with the error that we had before:

this is mitigated


Improve accuracy of get_equation predictions (x_value)

Check accuracy of prediction x values

against jetdnn.predict.build_and_test_single
against actual table values

Check accuracy of written equation

Check that predicted value matches value given by written equation!! e.g. first predicted value


[Bug] Chatbox is too long

Description
The whole chatbox is not visible due to the navbar
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 please assign this issue to me under GSSoC'24

@Rakesh9100 check it

@Rakesh9100
Chatbox need to be smaller.


Default Span attributes

Hi,
It would be very useful to set a default set of attributes that are applied to all traces. For example, we would like to be able to add availability zone, environment, etc... that go out on all traces. I don't believe there is a way to do this? Or I am missing it?
Thanks!

I think this should be supported in the exporter configuration. When you register the exporter you pass a map of <key, value> for attributes that will be added to all the Spans.

I'd really like to have this feature, so I added a possible implementation.
Not sure if the exporter config is the right place to put this.
One caveat in this implementation is that the exporter attributes override normal span attributes in case of key conflicts. (Not a big issue for my use case but maybe for others)

Once way to do this without adding the functionality to every exporter would be to implement a wrapper exporter. Perhaps we could add this wrapper to an exporters/exporterutil package?
So something like:

enhancer := exporterutil.NewSpanEnhancer(myExporter)
enhancer.DefaultAttributes = append(wrapper.DefaultAttributes, trace.StringAttribute("xxx", "xxx"), ...)
enhancer.SpanNameTemplate = "{{.SpanKind}} {{.Attribute "http.route"}}"
enhancer.ComputedAttributes = func(sd *trace.SpanData) []trace.Attribute {
  dur := sd.EndTime.Sub(sd.StartTime)
  if dur > 5*time.Second {
    return []trace.Attribute{ trace.BoolAttribute("slow", true) }
  }
  return nil
}
trace.RegisterExporter(enhancer)

(Threw in a bunch of other random ideas that a span "enhancer" might want to do before the Span is exported)


E2E tweaks

Reset manifests after apply
Remove debug logs from E2E test
Set the default container for kubectl logs
Update kind-with-registry.sh to be reusable

What is the KEY to fix seccomp issue?

What is the KEY to fix seccomp issue?

I need to look into that also. I'm not sure, especially since it sounds like we might need to do different things for different versions of Openshift (and/or Kubernetes)? I need to read up on what all SecComp entails...


XML Schema Definition Tool (Xsd.exe) source code

Is it possible to get the source code for XSD.exe ?
I am in the process of migrating a WCF application to REST and .NET core - and the ability to generate classes that de/serialize to both JSON and XML is required.
I have succeeded in doing this by hand (a huge effort) - but it would be extremely useful to have a tool like XSD.exe to generate the combined JSON / XML classes from the existing XSD files.
I am writing such a tool using c# - but it is re-inventing the wheel - source code for XSD.EXE would be very useful to me.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d4cba5c-4b4c-5697-7f6c-7bd0b91c1b8f
Version Independent ID: 29a29ddf-74db-2369-701d-c975c163c093
Content: XML Schema Definition Tool (Xsd.exe)
Content Source: docs/standard/serialization/xml-schema-definition-tool-xsd-exe.md
Product: dotnet
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

cc @StephenMolloy @HongGit

I'm working on a workaround.  I just want to join the group, for now.

As mentioned https://developercommunity.visualstudio.com/t/better-xsd-xml-tooling/426740, the xsd.exe source code is available here: https://github.com/microsoft/referencesource/blob/master/xsd/microsoft/devapps/xsd/xsd.cs


Autogyro takeoff mode

After our ThunderFly devcall with @kaklik and @slimonslimon we agreed on the following implementation of takeoff mode for the autogyro.
Why:

FW takeoff (from runway) sequence is different from the autogyro sequence
We want takeoff from some moving platform (car roof or running man)

How to do takeoff with an autogyro

At the beginning, it is assumed that someone pre-rotates the rotor to the minimum speed for the prerotator. These conditions will be set in some parameter
Then it starts prerotator and it is waiting for obtaining flight RPM of rotor. (Prerotation can be done by some prerotator driver or with forwarding movement). Rotor (pitch) is at some maximal setpoint value.
Now, autogyro is in flight parameters. Until this point, integrators are inactive. Now, the release command is transmitted (it can be mavlink command or some sound signal for running man)
Stage of climbing, it is similar to FW. Controlled by TECS with limited setpoints range.

Implementation
Because VTOL autogyro is not assumed (VTOL in the sense that vertical and horizontal flight is controlled by different actuators, as VTOL plane). We will create a new controller, which will be based on the current FW runway takeoff driver.
Programming will take place in our out-of-tree repository and we will build it above the current master version of the firmware. Then I merge it with the upstream/master and I will create PR.
Testing:
Because it is better to perform the first tests in the simulator, @kaklik will prepare a modification of the TF-G2 autogyro model it will contain dummy (very heavy) weights that is possible to switch off with some keyboard command. It will simulate takeoff from running man. (more details in own issue)
Then we try to perform some real test flights from a hand or from the car roof. Here we are missing a piece of SW and HW, which will disconnect the autogyro from the roof by a command from the mavlink message.

The issue has been almost solved. There is needed only protection of rotor overspeed which could happen in the case where the autogyro does not been released from platform promptly and platform speed increases.
The protective algorithm should lean forward the rotor and interrupt the takeoff if applicable.

The flight-tested performance of the current implementation of the takeoff procedure is perfect! It could also be documented by several flight logs and video recordings.
Therefore merging that to upstream is mandatory, until there are no changes that affect the functionality. :)

I am closing this issue, as the main discussion already moved to PX4 upstream PR: https://github.com/PX4/PX4-Autopilot/pull/18582

Nějak se zadrho přijetí pull-requestu, takže to zřejmě bude potřebovat ještě nějakou péči.


Enable Circle CI and restructure / improve some tests for CI

Enable Circle CI
Add a number of initial tests to Circle
Restructure K8s tests
Move Vamp into its own location

@rgardler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


DBM-1269: Track method execution statistics

What does this PR do?

Decorates postgres methods to track performance with the new tracked_method decorator.
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Hi @alexbarksdale  👋 Sorry for the delay but do we want this to be released with 7.40?

Closing this PR since it's pretty old, feel free to re-open it if needed 🙂


Make standalone to advertise "localhost" to avoid failure when hostname is not resolvable

Motivation
The standalone service is failing to startup when the hostname is not resolvable to an IP. This is common in laptops.
The reason is that the function worker in standalone is trying to connect to the advertised address rather than "localhost".
To fix this, we should make the standalone to always advertise "localhost" as the the broker address.


chore: potential nontermination at simp

Using simp [forIn] may cause nontermination with different simp reduction strategies. We have the following theorem
@[simp] theorem forIn_eq_forIn [Monad m] : @List.forIn α β m _ = forIn := rfl

Then, executing simp [forIn] in a term containing forIn iterating over a List may cause nontermination since the theorem above will fold it again.
Remark: the reduction strategy implemented
https://github.com/leanprover/lean4/pull/3118 triggers the nontermination.

Why wasn't this already nonterminating before?

In general this seems like it will be a problem with any use of simp lemmas for re-folding an unfolded notation, e.g. Nat.add a b = a + b (which are important for cleaning up a goal state when these appear due to some other tactic). Is there something we can do with tagging them specially or detecting that they are the inverse of a definitional equation and turning them off when the user explicitly uses simp [(. + .)] or the like?

I noticed these lemmas also had non-terminal simp, so I went ahead and cleaned that up.
I think there are a ways this could be improved.  Ultimately, I think it'd be nice if we had some sort of simp modulo some limited equations so that, for example, Nat.add and @Add.add Nat instAddNat were equal for simp.  That's a ways off though.


[BEAM-8507] Fix 'flink_master' parameter for the upcoming release

Add '[auto]' as a supported execution mode for Python FlinkRunner
The [auto] mode would work if the Flink job server had a config with the cluster
address. Change default back to '[local]' until it is clear how exactly '[auto]'
would be used.
Support http protocol scheme for Flink master address
Python uses the requests library to communicate with the Flink master via the
REST API and requires a protocol scheme.
Despite also using the REST API, the Java client does not expect the master
address to contain a protocol scheme. In order to support Python specifying one
in Python, we can remove it in Java.

Run Python PreCommit

Thanks!

This change seems to have undone https://issues.apache.org/jira/browse/BEAM-8396 .

This change seems to have undone https://issues.apache.org/jira/browse/BEAM-8396.

I doubt it since only the following line was removed:
https://github.com/apache/beam/blob/49ef57be306096e54ef5527beb764d6b7f115aae/sdks/python/apache_beam/runners/portability/flink_runner.py#L39
This line is ineffective and even if there was only one =, it would still not work properly (I tested that). We need to set the loopback environment earlier for it to work (also tested that).

It never seemed to have worked, but of course we can can/could still fix this.


Revise how we bootstrap (aka import) content for development

TL;DR: we need a new way of loading test content (talks, pubs, projects, news, etc.) into the dev environment.
Currently, we have some awesome content bootstrapping code (originally written by @Jamjarman and then updated by me) that parses the bibtex and XML files on my UMD website and then uses that to auto-load content into the Django site. We originally wrote this to avoid the pain of manually loading data into the production website but it's become a more useful tool for loading your development environment with data.
However, this will need to change--for two big reasons: (1) my UMD website is going away. Yes, I could host the same data on my CS UW website--and perhaps I will; however, see second point; (2) I would prefer not to continue to maintain two backend sources of data (my academic website and the ML website) and I would like the ML website to be the sole source of data.
So, I think future bootstrapping code should actually simply download some content from the production site and load them into the database (e.g., the 5 most recent papers, news items, talks, etc.). I'm not sure what the best way is to do this...

We culd use a REST API to put all the data on the production site into a JSON format and then have individual developers then query the API and retreive that data and build a test database in that way.

Oh yes, I like that. And we need to build out that API anyway.
Sent from my iPhone

On Jul 11, 2018, at 9:46 AM, johnsonkuang<EMAIL_ADDRESS>wrote:
We culd use a REST API to put all the data on the production site into a JSON format and then have individual developers then query the API and retreive that data and build a test database in that way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Despite @johnsonkuang's work on this, it's still not working. Need to keep testing and build test app that actually uses API (perhaps test app will be my webpage). Moving out of milestone for now.

@johnsonkuang said he's going to look into this.

@johnsonkuang, have you been able to work on this as expected? If not, I'm going to unassign you.

I’ve been working on it, will push the code once I’m finished.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jon Froehlich<EMAIL_ADDRESS>Sent: Friday, December 14, 2018 11:19 AM
To: jonfroehlich/makeabilitylabwebsite
Cc: johnsonkuang; Mention
Subject: Re: [jonfroehlich/makeabilitylabwebsite] Revise how we bootstrap content (#420)
@johnsonkuanghttps://github.com/johnsonkuang, have you been able to work on this as expected? If not, I'm going to unassign you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jonfroehlich/makeabilitylabwebsite/issues/420#issuecomment-447427252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfdHHAYbpqDV1PSwaYc8GwSIV3rIFRsPks5u4_nVgaJpZM4VKTE0.

Great! Do you have an ETA?
Sent from my iPhone

On Dec 16, 2018, at 12:03 PM, johnsonkuang<EMAIL_ADDRESS>wrote:
I’ve been working on it, will push the code once I’m finished.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jon Froehlich<EMAIL_ADDRESS>Sent: Friday, December 14, 2018 11:19 AM
To: jonfroehlich/makeabilitylabwebsite
Cc: johnsonkuang; Mention
Subject: Re: [jonfroehlich/makeabilitylabwebsite] Revise how we bootstrap content (#420)
@johnsonkuanghttps://github.com/johnsonkuang, have you been able to work on this as expected? If not, I'm going to unassign you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jonfroehlich/makeabilitylabwebsite/issues/420#issuecomment-447427252, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfdHHAYbpqDV1PSwaYc8GwSIV3rIFRsPks5u4_nVgaJpZM4VKTE0.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Coming back up to say that Option 2 is best.

Talk to @mechanicjay about how to get a PostgreSQL dump of the -test server + copy all of the static files

To copy files from host to a Docker container, see: https://www.arungudelli.com/tutorial/docker/copy-files-folders-from-host-to-docker-container/

There is actually some functionality to export/import a database from Django. See this discussion, for example: https://stackoverflow.com/questions/7002194/how-to-copy-database-in-use-to-other-database-in-django
Would have to have Jason's help.

I'm trying locally in my WSL2 environment now. When you create bash shell into container, you need to be sudo to run the command:
apache@43cd75e1d80c:/code$ python manage.py dumpdata > dumped_data.json
bash: dumped_data.json: Permission denied
apache@43cd75e1d80c:/code$ su
Password:
root@43cd75e1d80c:/code# python manage.py dumpdata > dumped_data.json
root@43cd75e1d80c:/code#

OK, I wrote up a Wiki page on how to do this. Hopefully, @mechanicjay and I can test soon.


How to replace NativeModules.SourceCode under Fabric architecture?

Description
Hello,
I'm currently transitioning to the new React Native Fabric architecture and I'm looking for a way to replace the functionality provided by NativeModules.SourceCode. In the legacy architecture, we used NativeModules.SourceCode to obtain information about the running JS bundle, such as its URL.
Could you please provide guidance or point me towards the recommended approach for accessing this kind of information within the context of the Fabric architecture? Is there a new API or an alternative method that we should use now?
Thank you for your assistance.
Best regards,
Steps to reproduce
console.log("NativeModules.SourceCode:" + NativeModules.SourceCode + "; scriptURL" + NativeModules.SourceCode.scriptURL);
React Native Version
0.72.5
Affected Platforms
Runtime - Android
Areas
TurboModule - The New Native Module System
Output of npx react-native info
nfo Fetching system and libraries information...
System:
  OS: macOS 12.5
  CPU: (8) arm64 Apple M1 Pro
  Memory: 106.81 MB / 16.00 GB
  Shell:
    version: 5.8.1
    path: /bin/zsh
Binaries:
  Node:
    version: 16.20.1
    path: ~/node/node-16.20.1/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 9.8.0
    path: ~/node/node-16.20.1/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.13.0
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 21.4
      - iOS 15.5
      - macOS 12.3
      - tvOS 15.4
      - watchOS 8.5
  Android SDK:

Stacktrace or Logs
ERROR  TypeError: null is not an object (evaluating '_reactNative.NativeModules.SourceCode.scriptURL')

Reproducer
https://git.corp.com/GP_APPMAIN_RN/react-native-auto.git
Screenshots and Videos
No response

@sailor1861 , try using
SourceCode.getConstants().scriptURL

try using TurboModuleRegistry.getEnforcing('SourceCode').getConstants().scriptURL or SourceCode.getConstants().scriptURL

TurboModuleRegistry.getEnforcing('SourceCode').getConstants().scriptUR is OK；thanks @arunrajput


Add custom CA bundle globally

This will allow access services that use certificates provided by self-hosted PKIs.

/test appstudio-e2e-tests

/test appstudio-e2e-tests


Add availableShippingMethods to Shop type

Allow fetching availableShippingMethods from Shop type, for given address.
Linked task: SALEOR-1630

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1630 Add minimal order total for free shipping for API


Add commas

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@sodamaco1 Thanks for submitting a PR! However, we are not going to accept this change.
Take a look at the contributing to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. :sparkles:


Add more placeholders for displaying highest weight group prefix and displayname.

As of right now, to my knowledge, there aren't any placeholders that would display the prefix or display name of the highest weight group user is in, there's only %luckperms_highest_group_by_weight%.
The reason, why I am asking for this, is because when for an example main track contains default and expands to donator ranks when I try to display staff ranks as the primary with current placeholders being offered it often switches showing donator ranks.
So, if you could please make something like %luckperms_highest_prefix_by_weight% and %luckperms_highest_group_displayname_by_weight% I'd be more than happy.

%luckperms_highest_group_by_weight% returns the display name.
%luckperms_highest_prefix_by_weight% would be the same as %luckperms_prefix% or %luckperms_prefix_element_highest%
Only other thing is: make sure you're using the latest version of the expansion.
https://ci.lucko.me/job/LuckPermsPlaceholders/


MariaDB: RENAME TABLE is not a supported statement

RENAME TABLE table TO ... is missing for MariaDB. Unfortunately ALTER TABLE table RENAME TO ... does not work either.
https://mariadb.com/kb/en/rename-table/
Steps to reproduce:

Add SQL script to rename a table. For example, RENAME TABLE IF EXISTS xyz TO zyx;
Parse the SQL... Statements statements = CCJSqlParserUtil.parseStatements(sqlString);

Exception:
Caused by: net.sf.jsqlparser.parser.ParseException: Encountered unexpected token: "RENAME" "RENAME"
    at line 344, column 1.
Was expecting one of:
    "("
    ";"
    "ALTER"
    "BEGIN"
    "CALL"
    "COMMENT"
    "COMMIT"
    "CREATE"
    "DECLARE"
    "DELETE"
    "DESCRIBE"
    "DROP"
    "EXEC"
    "EXECUTE"
    "EXPLAIN"
    "GRANT"
    "INSERT"
    "MERGE"
    "REPLACE"
    "RESET"
    "ROLLBACK"
    "SAVEPOINT"
    "SET"
    "SHOW"
    "TRUNCATE"
    "UPDATE"
    "UPSERT"
    "USE"
    "VALUES"
    "WITH"
    <EOF>
    <K_SELECT>

PRs are welcome. Look into the Replace production. You could do something similar.


Histogram Transport Implementation

These changes implement the "First Lower Bound" from the paper "Gromov–Wasserstein Distances and the Metric Approach to Object Matching" (Memoli 2011). The algorithm as implemented is faster than the entropic GW computation, and sometimes even outputs a coupling that is more optimal than the one found via entropic GW.
We refer to the method as "Histogram Transport," which is short for "Histogram Transport between Local Distributions of Distances" in the hope of being vaguely descriptive. The actual algorithm is implemented in src/ott/solvers/quadratic/histogram_transport.py. Additionally, because of the value added by initializing GW from the Histogram Transport coupling, we have implemented the FixedCouplingInitializer to allow GW initialization from any starting point.
Two tests have also been implemented to check that the distance works, and that it has the correct gradients.

Additionally, I have a brief notebook that shows the efficacy of the implementation, which I can't seem to copy/paste here.
I've uploaded an html export of it here:
https://www.asc.ohio-state.edu/packer.61/lower_bound_test.html
And the actual notebook here:
https://www.asc.ohio-state.edu/packer.61/first_lower_bound_tests.ipynb
Let me know if there's a better place for me to put it!

maybe epsilon_sort ?
On Fri, Oct 20, 2023 at 21:42 Daniel Packer @.***>
wrote:

@.**** commented on this pull request.
In src/ott/solvers/quadratic/histogram_transport.py
https://github.com/ott-jax/ott/pull/444#discussion_r1367427530:

rng: Random number key.

Returns:
The Histogram Transport output.
"""
rng = utils.default_prng_key(rng)

dists_xx = prob.geom_xx.cost_matrix
dists_yy = prob.geom_yy.cost_matrix
m, n = dists_xx.shape[0], dists_yy.shape[0]
min_num_pts = min([m, n])
small_indices = jnp.arange(min_num_pts)
x_indices = jnp.round(small_indices * (m / min_num_pts)).astype(int)
y_indices = jnp.round(small_indices * (n / min_num_pts)).astype(int)

if self.softness < 0:

Sounds good! I'm going to go with epsilon_1d, but you have more precise
suggestions, I'm happy to hear it.
—
Reply to this email directly, view it on GitHub
https://github.com/ott-jax/ott/pull/444#discussion_r1367427530, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFMWFTPMPOC4HCEOAYQXNELYALHYBAVCNFSM6AAAAAA6HUUKNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJQHAYDSOBYGI
.
You are receiving this because you commented.Message ID:
@.***>

since this is a solver that can also return a coupling, or potentials, i
think it’s better to call it
solvers.linear.univariate
and to ensure it takes a [n,d] matrix as input. when d=1 this is your
implementation. when d is larger this just runs the univariate matchings
independently, returning sum of couplings and 1d distances. this way this
could work for sliced
On Sun, Oct 22, 2023 at 19:28 Daniel Packer @.***>
wrote:

@.**** commented on this pull request.
In src/ott/solvers/quadratic/histogram_transport.py
https://github.com/ott-jax/ott/pull/444#discussion_r1367941775:

 case 1.0:

   cost_xy = jnp.sum(

       jnp.abs(sorted_dists_xx[:, None, :] - sorted_dists_yy[None, :, :]),

       axis=-1,

   )

 case 2.0:

   cost_xy = jax.lax.sqrt(

       jnp.sum(

           jnp.square(

               sorted_dists_xx[:, None, :] - sorted_dists_yy[None, :, :]

           ),

           axis=-1,

       )

   )

 case _:

   cost_xy = jnp.power(

Good idea! I put it in wasserstein_1d.py--might make sense to rename it,
though.
—
Reply to this email directly, view it on GitHub
https://github.com/ott-jax/ott/pull/444#discussion_r1367941775, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFMWFTKUP25RWOEVDWYU6Z3YAVJTFAVCNFSM6AAAAAA6HUUKNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJRGQ3DONBQHA
.
You are receiving this because you commented.Message ID:
@.***>

Regarding making this point:

not sure this should be a new quadratic solver class. I think quadratic initializer should be enough? Since there's no randomness, I think the lower bound fits better as an initializer.

I think there's some intuition here about what makes a Quadratic Solver that I don't have.
To me, it seems like it should be a solver because there are reasonable applications (see the notebook) where one would use this solver instead of a GW solver, since it is sometimes faster and better at finding an optimal quadratic coupling.
But it seems like this point might be unrelated to the main point that you have in mind about what makes a Quadratic Solver. Let me know!

the reason this is not a quadratic solver is that ultimately this solves a
linear problem 😅 that is all!
Sent from my iPhone
On Sun, Oct 22, 2023 at 19:36 Daniel Packer @.***>
wrote:

Regarding making this point:
not sure this should be a new quadratic solver class. I think quadratic
initializer should be enough? Since there's no randomness, I think the
lower bound fits better as an initializer.
I think there's some intuition here about what makes a Quadratic Solver
that I don't have.
To me, it seems like it should be a solver because there are reasonable
applications (see the notebook
https://www.asc.ohio-state.edu/packer.61/lower_bound_test.html) where
one would use this solver instead of a GW solver, since it is sometimes
faster and better at finding an optimal quadratic coupling.
But it seems like this point might be unrelated to the main point that you
have in mind about what makes a Quadratic Solver. Let me know!
—
Reply to this email directly, view it on GitHub
https://github.com/ott-jax/ott/pull/444#issuecomment-1774153722, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFMWFTPG4TUNVT4FQBZCXNLYAVKSNAVCNFSM6AAAAAA6HUUKNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGE2TGNZSGI
.
You are receiving this because you commented.Message ID:
@.***>

since this is a solver that can also return a coupling, or potentials, i think it’s better to call it solvers.linear.univariate and to ensure it takes a [n,d] matrix as input. when d=1 this is your implementation. when d is larger this just runs the univariate matchings independently, returning sum of couplings and 1d distances. this way this could work for sliced
…
On Sun, Oct 22, 2023 at 19:28 Daniel Packer @.> wrote: @.* commented on this pull request. ------------------------------ In src/ott/solvers/quadratic/histogram_transport.py <#444 (comment)>: > + case 1.0: + cost_xy = jnp.sum( + jnp.abs(sorted_dists_xx[:, None, :] - sorted_dists_yy[None, :, :]), + axis=-1, + ) + case 2.0: + cost_xy = jax.lax.sqrt( + jnp.sum( + jnp.square( + sorted_dists_xx[:, None, :] - sorted_dists_yy[None, :, :] + ), + axis=-1, + ) + ) + case _: + cost_xy = jnp.power( Good idea! I put it in wasserstein_1d.py--might make sense to rename it, though. — Reply to this email directly, view it on GitHub <#444 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMWFTKUP25RWOEVDWYU6Z3YAVJTFAVCNFSM6AAAAAA6HUUKNCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJRGQ3DONBQHA . You are receiving this because you commented.Message ID: @.***>

I'm a bit confused by this discussion. With its current implementation, the solver only returns a cost. Should I implement it to optionally return couplings and dual variables? Also, can't the sliced implementation be done simply with a vmap?

Oh yup! I agree with that point about the linear solver. So I should put it in with the Quadratic Initializers?

I'm a bit confused by this discussion. With its current implementation, the solver only returns a cost. Should I implement it to optionally return couplings and dual variables? Also, can't the sliced implementation be done simply with a vmap?

yes, to me this is the problem, but maybe you can indeed pass it that way.
ultimately, a solvers.linear.univariate solver should return costs / potentials and or transport matrix. Given you are thinking of passing a epsilon_sort, this would require being careful to vmap (i.e. pass a unified number of iterations, as discussed in https://github.com/google-research/group_testing)
but it's ok, i think this can be left for future work :)

Okay--I think I have addressed most comments, although some things may have slipped through the cracks.
An important thing I have not figured out:

I can't get the implementation to pass any differentiability tests. I suspect that this is for two reasons:

The implementation with hard-sorting is not differentiable
I don't really know how to make sure that jax's implicit differentiation tracks everything correctly.

Otherwise, what other issues do y'all want resolved?

Okay, I have made all the requested changes aside from the obj:None one, which I don't think I understood. Otherwise, we still need to decide if solvers.quadratic is where the solver should live. And also what name to give it.

@Daniel-Packer I've made some modifications how sorting function is passed to the UnivariateSolver, I think it cleans much of the arguments!.
Furthermore, I've renamed the HistogramTransport -> LowerBoundSolver per our discussions and added a differentiability tests.
From my side it's ready to be merged once all the tests pass, thanks a lot for the PR!
If you want, would be great to include the notebook that you've linked in a separate PR (after this PR is merged).
Alternatively, we can add a new section to the GW notebook; slightly prefer the latter, but pinging @marcocuturi .

@michalk8 Thank you so much for all the edits. I'll add a PR for editing the GW notebook once this one is merged. Also, I think there might be another PR for a weighted univariate solver too upcoming.


Optimize layout for mobile, unhide CTAs

Replaces #69 with a conflict resolution
This optimizes the layout for mobile, and un-hides the call-to-action buttons to the Download pages (per Jason's request) for the mobile experience.

Without this PR after reducing the browser size, I get

With this PR included

Looks good to me unless there is any specific testing to be done in addition @lunson

@seb No specific testing needed. All the Download buttons are now showing on the Product pages. I just need to un-hide the buttons from the actual Download pages, but will do so in a separate PR after this merges.


[1.14.4] Item tooltips hidden in Kitchen Counter/Cabinet  GUI

Items do not have tooltips inside the Kitchen Counter/Cabinet GUI.
Additionally, both GUIs are named Kitchen Counter.
All other GUIs from the mod work just fine.

Version

CookingForBlockheads_1.14.4-7.4.0

Thank you :)


[WIP] add travis ci support for the project

configure continuous integration  platform  to test and build the application

All right I'm okay with the simplest thing for now 👼. When/If we want to tests against multiple docker host version, we'll update the CI configuration/scripts.
Let's wait for it to be activate on the repos and ran for this PR before merging :stuck_out_tongue_closed_eyes:.
/cc @FaustXVI 👼

@FaustXVI  you have to configure this repo to not be ready to merge in master if CI checks failed

We will need docker to be available. Check https://docs.travis-ci.com/user/docker/

okay

@FaustXVI test failures 👼
You need to set a lower api version in tests too 😝

hum , we will fix that tomorrow  😄

@FaustXVI you need to fix your tests :angel: (when nginx or other images are not present, it should pull them :stuck_out_tongue_closed_eyes: — which does not seems the same for now)

Fixed on my branche :p
I will push soon
Xavier Detant
On 5 Aug 2016 13:40, "Vincent Demeester"<EMAIL_ADDRESS>wrote:

@FaustXVI https://github.com/FaustXVI you need to fix your tests 👼
(when nginx or other images are not present, it should pull them 😝 —
which does not seems the same for now)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FaustXVI/junit5-docker/pull/2#issuecomment-237829585,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-EH5js532j1h_WOoJrdTp0dhOovqExks5qcyEZgaJpZM4Jcd9S
.


[BEAM-10708] Added beam_sql magics

Added a beam_sql cell magic that applies a SqlTransform based on a
given Beam SQL query in the notebook.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @rohdesamuel
PTAL

Run Portable_Python PreCommit

Run Python PreCommit

Run Python PreCommit

Run Python PreCommit

Congratulations and thank you!
Is there a documentation, examples, or an announcement about this? We could share this in a blog.
/cc @KevinGG @kennknowles @TheNeuralBit

Congratulations and thank you!
Is there a documentation, examples, or an announcement about this? We could share this in a blog.
/cc @KevinGG @kennknowles @TheNeuralBit

There will be a notebook example in the hosted notebooks. We could also share a batch example in the repo that doesn't query PubSub.
There is still some additional work to be done. See latest comments in BEAM-10708.

Congratulations and thank you!
Is there a documentation, examples, or an announcement about this? We could share this in a blog.
/cc @KevinGG @kennknowles @TheNeuralBit

There will be a notebook example in the hosted notebooks. We could also share a batch example in the repo that doesn't query PubSub.
There is still some additional work to be done. See latest comments in BEAM-10708.

This sounds good. (Both hosted example and the batch example in the repo.) I would also suggest writing a Beam blog post. I think this is worth of sharing widely.


[RFC] Avatar Component

Avatar API RFC
Components

Avatar
AvatarGroup - Stack for holding multiple avatars
AvatarBadge (optional) maybe we can use our badge component.

Props

src string - Image URL
name string - Alt for the image, will also be used for placeholder initials
size string - Size of the Avatar
onError - Function called when image failed to load
fallback React.ReactNode - custom fallback element

API
<Avatar src="https://bit.ly/dan-abramov" size="md" name="Dan Abrahmov" />

When the image is loading we will show the placeholder initials
Usage with icon
<Avatar><UserIcon/><Avatar/>

fallback
If there is an error loading the avatar image, the component falls back to an
alternative in the following order:

the provided fallback
the initials which is calculated from name prop
a generic avatar icon

<Avatar
  fallback={<GenericUserIcon />}
  src="https://bit.ly/dan-abramov"
  size="md"
  name="Dan Abrahmov"
/>

AvatarGroup
Avatar group is a stack or flex container to hold multiple avatars in a group.
Props

limit number - Max number of avatars to show inside the group, rest of them
will get sliced.

API
<AvatarGroup limit={3}>
  <Avatar name="Remy Sharp" src="..." />
  <Avatar name="Travis Howard" src="..." />
  <Avatar name="Cindy Baker" src="..." />
  <Avatar name="Agnes Walker" src="..." />
  <Avatar name="Trevor Henderson" src="..." />
</AvatarGroup>

Like we already discussed about the Image logic.
Seems we can use useImage hook from Chakra UI for the fallback logic here.

Like we already discussed about the Image logic.
Seems we can use useImage hook from Chakra UI for the fallback logic here.

Yes we will be using that.


Remove useless export for TS

export declare function idx
means that you can use
import { idx } from 'idx'
in TypeScript but would failed with TypeError: idx_1.idx is not a function.

Thanks for your contribution nonetheless, @malash!
This change has been superseded by #59.


"Exposure check failed" card: "Restart" button does nothing if the device is not connected to the internet

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug affects both Android and iOS, for specific issues / questions that apply only to one operating system, please raise them in the respective repositories:

Android repository
iOS repository

[X] Bug is not already reported in another issue

Technical details

Device name: iPhone 6s & Huawei P Smart 2019
iOS/Android version: iOS 15.0.2/Android 11
App version: 2.11.1 (iOS) 2.11.2 (Android)

Describe the bug
The button "Restart" (iOS) / "RESTART" (Android) on the "Exposure check failed" card does not do anything.
Here are two screen recordings:
https://user-images.githubusercontent.com/67682506/137533002-90d1ab1d-a80c-49ad-acac-07ea4de217e8.MP4
https://user-images.githubusercontent.com/67682506/137533029-9555822d-8d11-4765-af3d-45d561ae761e.mp4
Steps to reproduce the issue

Open the Corona-Warn-App without an active internet connection
Check in to an event
Close the app
Open the app
See the "Exposure check failed" card with the "Restart" button
Click on "Restart"/"RESTART"
See that the button does nothing

Expected behaviour
The "Restart"/"RESTART" button should either do something or present an error message
Possible Fix
If https://github.com/corona-warn-app/cwa-app-ios/issues/3188 would be fixed this sowed probably be fixed too.
Related Issues

https://github.com/corona-warn-app/cwa-app-ios/issues/3188
https://github.com/corona-warn-app/cwa-wishlist/issues/662

Internal Tracking ID: EXPOSUREAPP10998-

@Ein-Tim Thanks. Internal Tracking ID: EXPOSUREAPP10998-

Corona-Warn-App Open Source Team

FYI PR https://github.com/corona-warn-app/cwa-app-ios/pull/4017

The behavior of the iOS app was aligned to the behavior of the Android app.
https://user-images.githubusercontent.com/67682506/149987976-d6d12286-6f0e-48a4-bfe9-df4114546c21.mp4
Not a real great improvement IHMO, a pop up screen which informs why the check failed (missing connection to the internet) is still not shown.

I will follow up with another issue. This one is closed as resolved.


Reproducing paper results

@gaurav16gupta Thanks for open sourcing your implementation!
I followed the steps provided in the readme and got the the following output:
$ python3 query.py --index='glove_epc20_K2_B4096_R4' --topm=50
model loaded
params: 4 1183514 4097 2
Deserialized
queries loaded  (1000, 100)
dense vectors loaded
[...]
167
 topm:  50  mf:  2
overall Recall for 0 points: 0.5301301301301302
Avg can. size for 0 points: 57368.51251251251
Inf per point:  0.003662752099784024
Ret+rank per point:  0.03862191299836799
per point to report:  0.009769939252710247

Compared to your paper (Figure 3 right at https://dl.acm.org/doi/pdf/10.1145/3534678.3539414), the recall seems much worse than what you got (for B=5000 (your paper)  vs. B=4096 (your readme)), with many more distance computations.
Are you getting better results? What could be going wrong?

Hi @gaurav16gupta, I followed your instructions to reproduce the results as well and got different results from Martin:
python3 query.py --index='glove_epc20_K2_B4096_R4' --topm=50
model loaded
params: 4 1183514 4097 2
Deserialized
queries loaded  (1000, 100)
dense vectors loaded
 topm:  50  mf:  2
overall Recall for 0 points: 0.8539539539539512
Avg can. size for 0 points: 57372.66066066066

this doesn't seem to correspond to Figure 4a in https://dl.acm.org/doi/pdf/10.1145/3534678.3539414.
Should the outputs of construct.py, index.py, and query.py be the same across runs (i.e., are you fixing the seed?) or is there any other reason I couldn't reproduce your results?

Following up on those, this is what I got for the glove experiment:
 topm:  50  mf:  2
overall Recall for 0 points: 0.8565565565565548
Avg can. size for 0 points: 57372.73073073073
Inf per point:  0.0008302612170096367
Ret+rank per point:  0.03303939873172391
per point to report:  0.008285795345962528
params: 4 1183514 4097 2