Add fakebinary for acommodating testing the child process management

This adds the internal/test/fakebinary package allowing us to test running a fake func-e process that spawns a fake envoy. This allows us to isolate the process control angle and can lead to quicker diagnosis of platform-specific behaviors, as well as show potential for future process abstraction. For example: to check the behavior of func-e when we send SIGKILL to it (in Linux, we need to make sure the child dies and receive SIGTERM configured in SysProcAttr.Pdeathsig).
This also abstracts away the process for building any fake binary that optionally uses some of func-e internal packages. For example, in this change, we can isolate the build for fake func-e to use internal/moreos package (to check on moreos.ProcessGroupAttr()) only and no more than that what it requires.
Signed-off-by: Dhi Aurrahman<EMAIL_ADDRESS>

@codefromthecrypt do you want me to continue this or you to create a PR from your branch?

@codefromthecrypt when you have time, please take a look. Mostly I migrated everything you have done to this branch, so mostly you have seen all of these before 😅.

@mathetake if you have some other notes of interest, feel free to review also. Otherwise, with things already said LGTM!


Quasar client wont connect

I logged into my router through my gateway IP and added a port forwarding rule: port 500 external -> 500 internal on tcp and udp. I used https://canyouseeme.org/ before I started to listen in on the port and it said "Error: I could not see your service on XX.XX.XXX.X on port (500) Reason: Connection timed out" then started to listen in on the port and got the same error. I ran the netstat -a command and got [::] both during and before listening on port 500. I have entered in the gateway ip into the connection tab in the build client as well. Any help would be appreciated.

Be sure to enter the correct LAN IP of your PC (e.g. <IP_ADDRESS>) where Quasar server is running in the port mapping, e.g. external port 500 -> internal port 500, IP <IP_ADDRESS>.

Does ipv6 need to be enabled

Depends if you want to use IPv6.


ambiguous behavior of limit parameter in sql query search

According to my understanding, limit parameter => maximum number of results to be displayed
But in sql query serach, when limit is kept 100 then results are displayed (20+ results) whereas if limit =10 no results display.
If results are present (20+) for that query then txtai should return 10 results when limit =10.
The limit parameter works as expected in text search (no sql query).
Request Body for /batchserach
{
"queries": [
"SELECT id, filename, text, score from txtai WHERE similar(' TOXICITY OF HEXANEDIOIC ACID DILITHIUM SALT ') AND project='test'"
],
"limit": 10
}

Depending on your data distribution and filters used, you may need to increase the candidate list for the similar clause.
For example:
SELECT id, filename, text, score from txtai WHERE similar(query, 500) AND project='test'

More can be read on this here: https://neuml.github.io/txtai/embeddings/query/#similar-clause

Thanks, It helped.
For reference :-
similar("query", "number of candidates")
The txtai query layer has to join results from two separate components, a relational store and a similarity index. With a similar clause, a similarity search is run and those ids are fed to the underlying database query.
The number of candidates should be larger than the desired number of results as additional filtering could occur. If this is not specified, it defaults to 10 times the number of desired results.


Reland double gzip wrapping NOTICES to reduce on-disk installed space

Reland the revert at #71899 to fix #71102
The difference between this and the last PR is that it now first compares uncompressed strings against the existing entry first before doing any work to avoid taking a performance hit.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jonahwilliams did I get what you were telling me last time right?

Seems to do the job, thank you @xster

Note: I took the unzipping part out of the framework's AssetBundle and just put it into the service binding's implementation to reduce the API break surface area.

Not sure why my frob cls were deleted. But it's also expected to fail. I'll submit a g3fix


Add the "@Override" annotation above this method signature

Describe the technical debt
There was a missing annotation(@Override) in the code.
FileLocation: src/main/java/de/dennisguse/opentracks/fragments/ChooseActivityTypeDialogFragment.java
Proposed solution
Fixed.
If applicable:

Technical information

Device: [Android Emulator]
OS: [e.g. AndroidOS 13]
OpenTracks version: [e.g. v3.2.4]

PR Generated: 18


create a 1D hyperslicer

Problem
It would be nice to plot a line or many lines of an array a la hyperslicer.

Proposed Solution
make a new function hyperslicer_1d. Probs a new function because otherwise the keyword arguments would become a nightmare on hyperslicer. I think it requires at least two more kwargs:

lines (or 1D or something)
many_lines

Additional context
@jrussell25 thoughts?

Cant heatmap slicer basically do this? Like if you just didnt show the heatmap?

i guess kinda. but thats super wrapped up in mouse movements and mouse positions. this feels like the 1D version of what hyperslicer does, except you show a line rather than an image.
I basically want this:
shape: (8, 150)

and for an array with shape like (8, 2, 150)

What about iplt.plot(lamda i: my_arr[i])

sure, but why not: iplt.imshow(lambda i: my_image[i])

so i actually did a bunch of this lambda nonsese while i was trying to work with xarrays. In general, i dont think its a bad way to go (especially if supporting xarray is something you want to do). Like maybe we could refactor by taking and expanding the logic that I wrote to parse the dimensions in hyperslicer and make a more general purpose array -> callables that would feed into both hyperslicer and it would make this easier. Probably should discuss whether this is sane.

Probs best to extract all the naming stuff into a private hyperslicer helper function that should be shared between hyperslicer_2d (to stay named hyperslicer and hyperslicer_1d and then pass all kwargs on to the approriate iplt function like this 1d implementation. Or hyperslicer could have a dims arg that defaults to 2D
Here is 1d without any fancy axis naming
def hyperslicer_1d(arr, **kwargs):
    arr = np.asanyarray(arr)
    axes = {}
    for i, s in enumerate(arr.shape[:-1]):
        axes[f"axis_{i}"] = np.arange(s)
    slices = [0 for i in range(arr.ndim-1)]
    slices.append(slice(None))
    def picker(**kwargs):
        for i in range(arr.ndim-1):
            slices[i] = int(kwargs[f"axis_{i}"])
        return arr[tuple(slices)]
    return iplt.plot(picker, **axes, **kwargs)

and with the ability to split over one of the dimensions: (could probs exten this to allow splitting over multiple dimensions in which case you'd flatten those axes:
def hyperslicer_1d(arr, split_dim = None, **kwargs):
    arr = np.asanyarray(arr)
    if split_dim == -1 or split_dim==arr.ndim:
        raise ValueError("nope split_dim must not be the last axis")
    axes = {}
    for i, s in enumerate(arr.shape[:-1]):
        axes[f"axis_{i}"] = np.arange(s)
    slices = [0 for i in range(arr.ndim-1)]
    slices.append(slice(None))
    def picker(**kwargs):
        for i in range(arr.ndim-1):
            slices[i] = int(kwargs[f"axis_{i}"])
        if split_dim is not None:
            slices[split_dim] = slice(None)
        return arr[tuple(slices)].T
    return iplt.plot(picker, **axes, **kwargs)

another slightly different implementation. Allows choosing the x_axis dynamically:
def xarray_1d(arr, ax=None):
    if ax is None:
        ax = plt.gca()
    dims = list(arr.coords)
    def f_y(x, x_axis, **kwargs):
        return arr.sel(**{k:v for k,v in kwargs.items() if k!= x_axis}, method='nearest').squeeze()
    ctrls = Controls(x_axis= set(dims), **{k:v.values for k,v in preds_xtal_rot.coords.items()})
    def f_x(x_axis, **kwargs):
        return arr.coords[x_axis]
    iplt.plot(f_x, f_y, controls=ctrls, ax=ax,xlim='auto')
    return ctrls


Update prevent-changes-to-security-settings-with-tamper-protection.md

Removed the option that says devices must be onboard to Microsoft defender for endpoint as you can enable with with MEM. While to have the ability to continually review the org security posture, it is recommended to subscribe to MDE Afaik this is not a must to enable or manage tamper protection in MEM.

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/9054


FIX issue #143

first received WM_NCCALCSIZE message params->lppos may be null

A duplicate of #134

Also fixed by #100.

Fixed in https://github.com/bitsdojo/bitsdojo_window/pull/197


Options

added examples/test for options
added descriptor for the options, to allow compilation by other compilers, such as, protoc
hooked up the existing options

Spring cleaning tasks that I haven't had the time to work on.

You should have just merged them as your comments are subjective.
It would have been much easier for you, benefit to end users and we all could have just moved on.

First commit looks OK.
Second commit should not be there, it should have been rebased into the previous one.
Third commit does not take into account the true nature of expandable options. It was a long time since I read the spec on how to handle these options but simply removing them like that can bite someone in the future.
Forth commit will naively pass through any escape sequence. I would expect the escaped value to be added to the string rather than the escape sequence.
I'm not against adding the original intended functionality but as the pull request looks now it is not acceptable. If updates arrive I'm willing to reopen or merge them directly but I won't personally fix this so I leave it closed until anything else happens.


Paste github URL into collaboration document on hackmd

Slack > general > pinned on top

Pasted it as required


Having problems. Could not download file (error code: -1)

Whenever I click, "install theme"
I get the following error, trying to debug now --> but I think --> $_POST['install'] == undefined.
Could not download file (error code: -1)

hey @vince-lynch
unfortunately I did not have enough time to do anything related to bludit in the past few months.
I will check this error shortly 😉

Oh hey,
Your online.
I commented out this line(71) in plugin.php
if(data.download_url_v2 != ""){
//var theme_download = data.download_url_v2;
}
Thankyou for creating this software btw. Bludit is the best static site generator by far!

great! thank you very much 😊
will push this along with some more changes in a few minutes, stay tuned 😇

@vince-lynch the fixed version is now available!


Add Grouping in shorting

Describe your suggested feature
In Grouping manga or anime should be grouped according to CATEGORIES, SOURCES, STATUS, UNGROUPED etc. By grouping manga or anime it will be quite helpful.
Other forks of tachiyomi have this setting.

Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

Duplicate of #87


Package request: streamrip

Project description
A scriptable stream downloader for Qobuz, Tidal, Deezer and SoundCloud.
Metadata

homepage URL:
source URL: https://github.com/nathom/streamrip
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

Add a :+1: reaction to issues you find important.

I already made a package request at #305034
and there is a open pull request for streamrip here #280725

Closing as duplicate


[WIP] Changes for non-human workflow

Getting rid of BQSR, fingerprint checks, contamination checks, ALT contigs, and variant calling metric collection

You would need to change paths to inputs based on storage account & data, as well as import statements.


Search bookmarks

Add the possibility to search among the bookmarks lists

Unlikely to be needed unless most users bookmark hundreds of songs and want to search the list


don’t request unnecessary nodes on sys.nodes

queries if a name filter is provided in where clause

lgtm otherwise


[doc] Align agents logs documentation

update logs docs for java agent, part of https://github.com/elastic/apm/issues/800

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-05-25T09:12:35.394+0000

Duration: 5 min 7 sec

:grey_exclamation: Flaky test report
No test was executed to be analysed.
:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine run elasticsearch-ci/docs


Store MCAP metadata in Base64 format

After:

https://github.com/eProsima/dev-utils/pull/79

Codecov Report
Patch has no changes to coverable lines.

Files Changed
Coverage

...participants/src/cpp/recorder/mcap/McapHandler.cpp
0.00%

ddsreplayer/src/cpp/tool/DdsReplayer.cpp
0.00%

:loudspeaker: Thoughts on this report? Let us know!.


[Feature Request]: Greeting on Issue Closure

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Implementing a greeting message upon issue closure would add a touch of personalization and acknowledgment to the collaboration process within a project's issue tracker. This feature would automatically post a message, acknowledging the closure of an issue and thanking the contributors involved in the resolution.
Use Case
This feature would enhance the user experience by adding a human touch to the automated processes within the project's issue tracking system. Upon issue closure, contributors and stakeholders would receive a warm acknowledgment, fostering a sense of appreciation and recognition for their efforts. Additionally, it would help maintain positive engagement and morale within the project community by celebrating milestones, such as issue resolutions, in a friendly and welcoming manner. Overall, this feature would contribute to a more inclusive and supportive environment for collaboration, encouraging continued participation and contribution from all project members.
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
Implementing a greeting message upon issue closure would add a touch of personalization and acknowledgment to the collaboration process within a project's issue tracker. This feature would automatically post a message, acknowledging the closure of an issue and thanking the contributors involved in the resolution.
Use Case
This feature would enhance the user experience by adding a human touch to the automated processes within the project's issue tracking system. Upon issue closure, contributors and stakeholders would receive a warm acknowledgment, fostering a sense of appreciation and recognition for their efforts. Additionally, it would help maintain positive engagement and morale within the project community by celebrating milestones, such as issue resolutions, in a friendly and welcoming manner. Overall, this feature would contribute to a more inclusive and supportive environment for collaboration, encouraging continued participation and contribution from all project members.
Benefits
No response
Add ScreenShots
No response
Priority
Medium
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @thevijayshankersharma , Go for it
All the Best


404 error if you click on "unsubscribe" in maintenance emal

If you subscribe incidients in https://demo.cachethq.io/ and you receive an email about a new one and click unsubscribe in the email you will get a 404 error (https://demo.cachethq.io/unsubscribe).
See picture.

I'll try and look at this a bit later. @joecohens I think the unsub link isn't working.

Yeah I think we are not getting the ?code= part.

Weird though since we're passing through the code value.

My unsubscribe link looks like http://mandrillapp.com/track/click/30254010/demo.cachethq.io?p=eyJzIjoiTENRemRIREJDNU5ESFJWQlRmc1hLbERyT19BIiwidiI6MSwicCI6IntcInVcIjozMDI1NDAxMCxcInZcIjoxLFwidXJsXCI6XCJodHRwczpcXFwvXFxcL2RlbW8uY2FjaGV0aHEuaW9cXFwvdW5zdWJzY3JpYmVcIixcImlkXCI6XCJhZTUzYmE0NmQzNmE0YjMzYmNkYmVmODgzOWZmOTExZFwiLFwidXJsX2lkc1wiOltcImIyNDk3MGJkZjFmNWYyZThmMDQ3MWM5MmQ3NjkwODVlMjYyNGJkY2RcIl19In0

I think that the p parameter is Mandrill's doing.

Instead of using a query string, we should just use a url parameter.

I don't think we're using a query string @GrahamCampbell?

Yeah I think we are not getting the ?code= part.

?

https://github.com/cachethq/Cachet/blob/master/app/Http/Routes/StatusPageRoutes.php#L48
We're not using a param :)

Sure. :P


how to access Done button

hey! this library is really great.. i have been using it lately and i need to override done button, could you help me if there is any possible solution to it.
I tried to do it like this
public class MyWelcomeActivity extends WelcomeActivity
{
@Override     protected WelcomeScreenConfiguration configuration()
 {         DoneButton done = new DoneButton(findViewById(R.id.button_done));         done.setOnClickListener(new View.OnClickListener() {             @Override
public void onClick(View v) {                 Log.e("SahajLOG", "Done Button Called ");                 completeWelcomeScreen();             }         });
return new WelcomeScreenBuilder(this)                 .theme(R.style.CustomWelcomeScreenTheme)                 .defaultTitleTypefacePath("Montserrat-Bold.ttf")                 .defaultHeaderTypefacePath("Montserrat-Bold.ttf")                 .titlePage(R.drawable.traffic_sign, "Welcome", R.color.SwipeScreen1)                 .page(new WelcomeFragmentHolder()  {                     @Override                     protected android.support.v4.app.Fragment fragment() {                         return new WelcomeProfileFillFragment();                     }
}, R.color.material_green)                 //.swipeToDismiss(true)                 .build();     }
}

Thanks,
What exactly do you want to change about the done button? Do you just want to change the text/style? Or do you want to use a button you've included in a custom fragment instead?

I have actually added a fragment which is like a Form Filling so, when the done button is pressed i want to check if the entered information is correct and is not empty.

That's actually the next feature I'm going to add, for now the easiest thing to do is to put a button in your fragment layout and handle the click and validation in your fragment, and call .useCustomDoneButton(true) on the WelcomeScreenBuilder. To finish the welcome screen, add the following to the end of your new click listener:
new WelcomeScreenFinisher(WelcomeProfileFillFragment.this).finish()

okie thanks! I will try doing this thing.


Add ECS service and task definition resource type

It would be really nice to be able to use this with EC2 Container Service.

Bumping this.


CMS-Shape distribution

Closes #97

Hi Hans,
Could you please explain how alpha and peak can be replaced by one single "loc" parameter without changing anything? Since alpha and peak refer to the differerent centers of the exponential and the erfc terms respectively, doesn't replacing them by a single "loc" parameter reduce the degrees of freedom by 1 when someone is going to attempt to fit with this distribution?

It comes out this way when you normalize the density analytically. The exponential decay is scale invariant, an offset is compensated by renormalization.

Well I know other people have been able to use it in roofit and I'm just trying to translate it into python by using the numba-stats pdf you developed.
The fit doesn't seem to converge though when I'm trying to fit a Z peak with cmsshape + crystalball_ex. It's extremely sensitive to starting parameter values and never gives a good fit. I will dig around. Perhaps this combination doesn't describe the Z-peak well.
On another note, the things I was talking about convolutions, pdfs from histograms and stuff, seem to be already there on probfit which is now unmaintained sadly.


Python virtualenv wrapper fns - virtualenv vs venv

I'm discovering as I play with Jupyter & matplotlib on a macOS machine, that virtualenv is suboptimal, because it copies Python binaries, which then are no longer macOS Frameworks, and so matplotlib doesn't work when called from inside another application such as a jupyter-enabled virtualenv.
Also tools like MS-VS Code seem to advocate the Python standard virtual environment system (since 3.6) of venv.
Also, I've been using "venv" in my bash fns as a short-hand for "virtualenv" (much like pipenv does, apparently) and so that'll be a bit confusing.
I need to rethink how / if my mkvenv, lsvenv, rmvenv fns work with virtualenv and venv; maybe switch them to venv and refactor the virtualenv-aware fns to mkpyv or something?
See:

Difference between venv, pyvenv, pyenv, virtualenv, virtualenvwrapper (Stack Overflow)
Python virtual environments - a primer (realpython.com)
venv - Creation of virtual environments (Python docs)
pipenv (github), which uses virtualenv, that may or may not be a problem ?
Pipenv and virtual environments (Python-Guide.org)

More points to note:

venv is only available in Python 3.5+, so if a project must use Python < 3.5, it must use virtualenv
venv has mixed reception, though it appears to be the "best" solution on macOS and the recommended solution for VS Code
virtualenv isn't going away any time soon, and pipenv is built around it.  If pipenv has any merrit (which it seems on skimming that it does), then I may want to write tooling around both
I don't like the virtualenvwrapper stuff, that's why I wrote my fns in the first place
Where does Anaconda sit within all this?  I think it's can remain on the side as it currently is handled by my existing fns.

More notes:
This answer to the SO question above recommends venv over everything.
A work colleague recommends pyenv (yet another "only one obvious way to do it"). pyenv manages multiple Pythons much like rbenv/Node.js (forked from rbenv) and it has a plugin for virtualenv, called pyenv-virtualenvhttps://github.com/pyenv/pyenv-virtualenv, which automatically will use python -m venv when available, and virtualenv is unavailable.
It also supports Anaconda/Miniconda.
Perhaps I should abandon my wrapperns or switch them to this?

more to read:

https://docs.python-guide.org/dev/virtualenvs/
https://packaging.python.org/tutorials/installing-packages/#creating-virtual-environments
https://docs.python.org/3/library/venv.html#venv-def


TTS.google_say wont play on SONOS (SSL)

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.35.2
Python release (python3 --version):
3.4.2
Component/platform:
tts.google_say
Description of problem:
My issue is almost exactly as in #4979, however I've updated to HASS 0.35.2.
After updating I was hoping I would be able to get Google TTS working on my Sonos, but still no luck.
My Sonos app still says "(...) - connection to 192.168.XX.XX:8123 was lost". On version 0.35.0 it was giving a generic <IP_ADDRESS>:8123. Voice mp3's are being downloaded correctly, so I think it's just the link between HASS/RPi and Sonos that appears to be somehow broken.
I am running SSL with DuckDNS, just like @beanian.
Expected:
TTS should play audio on SONOS

Make sure you add your duckdns domain as base url for the HTTP component as described in the change log:
http:
  base_url: vilre.duckdns.org


Simulation

Is this just a test of the issue tracker?  I'm closing it as it doesn't seem to provide anything actionable.

Is this just a test of the issue tracker?  I'm closing it as it doesn't seem to provide anything actionable.


Unable to "mopsize" a package

Trying to switch from Vessel to MOPS in my package, I receive an unclear error message:
$ git clone https://github.com/vporton/NacDB
$ cd NacDB
$ mops init
...
Dependency https://github.com/kritzcreek/motoko-matchers#v1.2.0 (global cache)
dhall-to-json error: Command failed with exit code 1: dhall-to-json --file /home/porton/Projects/NacDB/.mops/_github/matchers#v1.2.0/package-set.dhall

There is a known issue with matchers v1.2.0. You can skip it and it should work
I tried to migrate your package, and this is mops.toml that I think should be after the migration:
[dependencies]
base = "0.9.0"
btree = "https://github.com/canscale/StableHeapBTreeMap#v0.3.1@d4540d1342843bcc7b5d6250c388dc710cce2fec"
stable-rbtree = "https://github.com/canscale/StableRBTree#v0.6.1@465e86cd7c7755722bffda47fd707021da344956"
stable-buffer = "https://github.com/canscale/StableBuffer#v0.2.0@1af0e8814bac5ca7ed23a6c094204b46d9056c2e"
sha = "https://github.com/enzoh/motoko-sha#master@9e2468f51ef060ae04fde8d573183191bda30189"

[dev-dependencies]
matchers = "https://github.com/kritzcreek/motoko-matchers#3dac8a071b69e4e651b25a7d9683fe831eb7cffd@3dac8a071b69e4e651b25a7d9683fe831eb7cffd"

and after you populate the [package] section you will be able to publish it to the mops registry.
Example https://github.com/ZenVoich/test/blob/main/mops.toml


Sharding the llama2 70b on v5e-16 more efficiently.

https://arxiv.org/pdf/2211.05102
https://arxiv.org/pdf/1909.08053

Talked off line, George is OOO soon and doesn't time right now. He can make these changes once he is back in 2 weeks. I'm ok with merging this as a short-term fix, will let @gobbleturk decide.

Thanks for the review, Matt, Vipan and Morgan!


msg.input missing

I just updated to v5.11.0 and the 'Modbus Flex Getter' node is no longer passing the input message through (it used to get passed through as msg.input)?
Running node v12.16.1 on a RPi 3 running Raspian Stretch.

Please, try the new option 'keep msg properties' or build the input yourself. The new concept is merging msg data in the flows to kee property positions and to have less doubled properties. If you get in trouble with the new concept, then please describe it a bit more and fill out the issue template, please!

#194

reopen if there is more, please


poppler: Include poppler encoding data by default

Motivation for this change
poppler-data contains encoding data needed to view some PDF documents. Without it, some characters will not  be rendered unless the fonts are embedded into the document. This includes CJK characters, so many documents written in those languages is unviewable with the current defaults. Since many popular packages depend on poppler for PDF rendering, multi-language support should be enabled by default.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks!


host private API is not being shared on live share session

Describe what happened:
host private API is not being shared on live share session
What was your system configuration?
Product and Version [VS/VSCode]:
Version: 1.51.1
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-11T01:11:34.018Z (4 wks ago)
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.1.0
OS Version[macOS/Windows]:
macOs (client) , Windows (host)
Live Share Extension Version:
v1.0.3303
Target Platform or Language [e.g. Node.js]:
ReactJs
Steps to Reproduce / Scenario:

Share a React application code running on 3000 port, which is consuming some local Intranet API which private to host
Share server port 3000
When client open localhost:3000
Application is failing due to non-availability of private API

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
There is no log, its only application is not able to access host private API
Screenshots
If applicable, add screenshots to help explain your problem.
Can't share, its confidential client project

Could the port of the private API be shared with the guest? Or is the React app calling the API by a hard-coded hostname that wouldn't resolve by the guest?

Hey! Per my previous comment, you should be able to resolve this issue by simply sharing the port of the internal API with the guest. That said, I'm going to close this as resolved for not, but please re-open the issue if that solution doesn't work for you. Thanks!


Client Exemple for Express server

Depends on #12
Adress issue #3
To test the server run at root/api
bash all_file_req

The files in the file-mocks folder should be 'copied' to api/uploads folder.

#16 alreadey has a client exemple


Cotary Create: Master Branch

This PR is for issue: https://github.com/dOrgTech/DAOcreator/issues/246

Currently we are trying these 2 css component libraries:
https://chakra-ui.com
https://react-rainbow.firebaseapp.com

This PR is for issue: https://github.com/dOrgTech/DAOcreator/issues/246

Would you all say we're ready to merge into dev? @mrrobot16 @Flash-Git @cbrzn


[Popper][base] Drop component prop

[x] I have followed (at least) the PR section of the contributing guide.

BREAKING CHANGE
part of https://github.com/mui/material-ui/issues/36679
It will be covered by codemod, see https://github.com/mui/material-ui/pull/36831
For Base UI components, the component prop value should be moved to slots.root:
<Popper
-  component="span"
+  slots={{ root: "span" }}
 />

If using TypeScript, you should add the custom component type as a generic on the TabsList component.
-<Popper
+<Popper<typeof CustomComponent>
   slots={{ root: CustomComponent }}
   customProp
 />

one problem left unsolved, running yarn docs:typescript:formatted changes Button.proptypes like the image below. Adding /* @typescript-to-proptypes-ignore */ doesn't seem to solve the issue. Will try to fix in the following days.

Thanks a lot for your contribution. @nicolas-ot We need to support dropping component prop throught all Base UI components in today's release, and as you know, Popper is the only remaining component left. Aside from the TypeScript issues we encountered, we can't actually drop component prop yet for Base Popper because this component is used in some of Joy UI and Material components. I will close this PR. Again, thanks for your hard work.


Loki silently rejects data when chunks dir is too large

Bug Description
When the chunks dir contains too many files, loki stops ingesting new data. (Setting tune2fs -O large_dir /dev/vda2 resolved it.)

Should have an alert fired in that scenario. If loki doesn't have metrics for this then think about pebble checks/notices or node exporter.
Need to think if there's anything generic we could modify with the chunks config.

To Reproduce
See https://github.com/canonical/cos-proxy-operator/issues/130.
Environment
See https://github.com/canonical/cos-proxy-operator/issues/130.
Relevant log output
See https://github.com/canonical/cos-proxy-operator/issues/130.

Additional context
Observed by @dnegreira.

@sed-i maybe relevant: https://github.com/grafana/loki/issues/364

Some context from https://github.com/grafana/loki/issues/1502
Firstly, we need to be careful not to enable large_dir as a workaround on a /boot device (including where /boot is stored on /)

As @wschoot points out EXERCISE CAUTION before you run tune2fs -O large_dir /dev/... if the device uses grub to boot it will fail to boot on the next reboot. This is true for any system using < grub-2.12 (which was only released (Wed, 20 Dec 2023) and will take a while to rollout via the distros.

Secondly they moved away from this single large directory in v2.5, in these issues:
https://github.com/grafana/loki/issues/364
However to take advantage of that we need to use Schema v12, and looking at the charm we are possibly still using v11:
https://github.com/canonical/loki-k8s-operator/blob/6c26adf5a7c850e5ea520eee40f2adc5a2865f56/src/config_builder.py#L104
    @property
    def _schema_config(self) -> dict:
        return {
            "configs": [
                {
                    "from": "2020-10-24",
                    "index": {"period": "24h", "prefix": "index_"},
                    "object_store": "filesystem",
                    "schema": "v11",
                    "store": "boltdb",
                }
            ]
        }

We need to check if we can still reproduce this once we have compaction. We should likely do tune2fs ... in our charm if so.

To help narrow doing our options on this issue, here are some potential approaches we could explore
Approach 1: Configuring ingester config
we might consider playing around with the ingester configs to optimize chunk size and idle period. Increasing chunk size and extending the idle period can potentially reduce the number of chunks and mitigate the large number of files, yet could potentially lead to increased memory usage, longer query latencies, losing more data that hasn't been flushed to disk yet and less efficient storage usage if chunks are significantly larger than the data they contain
Approach 2: Using tune2fs large_dir
Enable large_dir but this will come with it's own implications which is in a nutshell if the device uses grub to boot it will fail to boot on the next reboot
Approach 3: TSDB with v12 schema

In v12 not all chunks are stored in a flat dir like older schemas see upstream#5291

we could benefit from this but migration is a bit tricky, Loki requires setting a future date for when to start using this schema, to understand this imagine we set this date to 25/04/2024 and a customer decided to upgrade the charm on the 25/05/2024, this would mean that loki would understand that all data in that period are written in v12 and will use v12 in queries which will result in data corruption for data in that period

Since TSDB won't replace boltdb-shipper, adding a new PVC for it might disrupt the upgrade path as juju doesn't currently support this, (maybe let data live inside /loki/boltdb-shipper-active??)

ERROR Juju on containers does not support updating storage on a statefulset.
The new charm's metadata contains updated storage declarations.
You'll need to deploy a new charm rather than upgrading if you need this change.

TSDB v12 seems like the right path forward.
I wonder if we could decide what to render in the "from": config section on install/upgrade.
What if we dump a copy of the loki config to persistent storage on "remove" hook? Next time we go through startup/upgrade we check if the file is there and render the v12 "from" to be e.g. tomorrow.

If you dive into the already referenced https://github.com/grafana/loki/issues/1502, or particularly my comment about using a hashing approach to avoid having insane amounts of files: https://github.com/grafana/loki/issues/1502#issuecomment-2051226585
This is what has been used since forever for other services like EMail services which store a larger count of files and it should not be much of a problem to implement for Loki when regular file storage.


Apply default styles per the style guide

The GamePath Style Guide has clean colors and typefaces.
Let's apply these styles as our default choices for font, colors, links, and text.

Have committed the first round of changes per this ticket to branch smc-mozilla.
It looks cleaner already.

Will continue and add comments here re additional updates.

Made all my changes in branch smc-mozilla.
Pushed the latest to origin/smc-mozilla
Things look much more cohesive by default.
So far, the overall changes
App default (header, intro) - Ubuntu
'System Messages' (e.g. Question Count, Instructions, Sponsor) - 'Ubuntu Mono'
Body / default - 'Open Sans'
answerOption - 'Open Sans Condensed' (gives use a bit more space)


PickTag() fails when vim 'tags' variable includes stop directories (upwards search)

The PickTag() function treats the vim 'tags' variable as a comma separated list of simple tag files. And it calls 'cat' on this list to generate input for 'pick'. However, if the 'tags' variable includes stop directories (see vim help 'file-searching) they are appended with a ';' and this will cause the expression returned by TagCommand() to be wrong.
E.g. say the 'tags' variable is 'tags = ./tags;' with ';' appended to indicate upwards search until the root directory. That will make the expression returned by TagCommand() to be:
cat ./tags; 2> /dev/null | awk -F$'\t' '{print $1}' | sort -u | grep -v '^!'
and the final command piping into 'pick'
cat ./tags; 2> /dev/null | awk -F$'\t' '{print $1}' | sort -u | grep -v '^!' | pick
But the ';' after 'cat ./tags' will then be treated by the shell as a command separator, so now the first command cat's the tags file and the second command calls pick but with no valid input. I guess somehow the 'tags' variable should be expanded/parsed to a proper list of simple file names without search patterns.

Seems that the builtin tagfiles() function will do the trick. From vim help :
tagfiles()      Returns a List with the file names used to search for tags
for the current buffer.  This is the 'tags' option expanded.

The following fix in the TagCommand() function seems to do the trick:
function! s:TagCommand()
-  let l:tag_files = join(split(&tags, ","), " ")
+  let l:tag_files = join(tagfiles(), " ")

Thanks for reporting this @hejersbo! Your solution looks great. I'll merge #5 right away.


20318 - Slavic Macedonian - Suggest reassigning songs 9415 and 9157

Songs 9415 and 9157 are both in Greek, from the Greek part of Macedonia, from albums of Greek music. So, I suggest reassigning these songs to society 62314, Greek Macedonian.

Suggestion implemented


hidden friendship for tag_invoke

overloads of tag_invoke should be hidden friends of the rule type.
The documentation can look to this paper for wording tips:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1601r0.pdf

I think I did this, but it needs checking


componentWillMount called more than once, componentWillUnmount not called on scene change

Hi all, I am running into an issue with react-native-router-flux where componentWillMount for one of my components is being called more than once.
I am using  react-native-router-flux: "^2.3.12"
so if I switch from Component1 (Groceries) to Component 2 (Detail) and switch back to Component1, componentWillMount for Component1 is called again for that first component.
I have some important listeners that I don't want to register twice in componentWillMount
and for some reason componentWillUnmount isn't called either
I am using redux, anyone have this issue also?
Here's my code snippet of my two tabs (tabbarGrocerties and tabberDetail)
class Application extends Component {
  render() {
    return (
          <Router hideNavBar={true} name="root">

              <Schema name="withoutAnimation"/>

              <Route name="signin" component={SignIn} title="Register"/>
              <Route name="tabbar">
                  <Router footer={TabBar} hideNavBar={true}>
                      <Route name="tabbarGroceries" schema="tab" title="Groceries TODO" component={Groceries} hideTabBar={true}/>
                      <Route name="tabbarDetail" schema="tab" title="Detail" component={Detail} />
                  </Router>
              </Route>
          </Router>
    );
  }
}

Groceries render contains:
<Text onPress={Actions.tabbarDetail}> Click here to go to detail </Text>

Detail.js  render contains
<Text onPress={Actions.tabbarGroceries}>Click to go to groceries</Text>

Both Action is imported like this:
var Actions = require('react-native-router-flux').Actions;

Are you sure that all route have 'switch' type, check Example project for details? Anyway 2.x is not supported anymore, you need to use 3.0 release


Hide carousel navigation arrows

As requested in issue #3947 now you can hide arrows in carousel using option hide-arrows

            <carousel interval="myInterval" hide-arrows="true">
                <slide ng-repeat="slide in slides" active="slide.active">

Slide {{$index}}

{{slide.text}}

                </slide>
            </carousel>

I didn't request arrows to be hidden, but indicators ;) But both options would be very good to have!

Sorry @demiro, I got confused. Bad day.
As requested now you can hide Indicators and with bonus, hide arrows.

            <carousel interval="myInterval" hide-arrows="true" hide-indicators="true">
                <slide ng-repeat="slide in slides" active="slide.active">

Slide {{$index}}

{{slide.text}}

                </slide>
            </carousel>

Thanks! You are "da man"

If one wants to hide the arrows or indicators, I think it would make sense to use ng-class on the carousel element and use CSS - it would also be more performant.
Thoughts?

It's how I did it...but its not a good solution since there are still unused elements in the DOM that have event listeners that are just there for no reason...
Proper way is to not includ them at all
Sent by Outlook for Android
On Fri, Jul 17, 2015 at 8:13 AM -0700, "Wesley Cho"<EMAIL_ADDRESS>wrote:
If one wants to hide the arrows or indicators, I think it would make sense to use ng-class on the carousel element and use CSS - it would also be more performant.
Thoughts?

Reply to this email directly or view it on GitHub:
https://github.com/angular-ui/bootstrap/pull/3949#issuecomment-122307492

But modifying ng-show for this doesn't change this situation - this implementation is wholly inferior in approach to my suggested solution, and does not buy anything except minor convenience.
I am inclined to reject this unless it adds a performance benefit, as this is something that can be done already without a hack on the developer side.

@wesleycho You right about performance, but I think that we can provide some option to remove this controls.
How about detach this elements from DOM?

If it uses ngShow...than it is good only to hide stuff on the fly (dependi g on the controller) otherwise it is not what I was actually looking for
Sent by Outlook for Android
On Fri, Jul 17, 2015 at 8:54 AM -0700, "Wesley Cho"<EMAIL_ADDRESS>wrote:
But modifying ng-show for this doesn't change this situation - this implementation is wholly inferior in approach to my suggested solution, and does not buy anything except minor convenience.
I am inclined to reject this unless it adds a performance benefit, as this is something that can be done already without a hack on the developer side.

Reply to this email directly or view it on GitHub:
https://github.com/angular-ui/bootstrap/pull/3949#issuecomment-122323635

After reading the original issue, I am closing this, as this has a simple solution currently & only would serve to mislead developers as to the best course of action for their applications.


Add contributors

@all-contributors please add @jhicken for code

@all-contributors please add @jhicken for code and ideas

@all-contributors please add @janineahn, @xtroncode, @TomaszG and @coreyshirk for code and documentation

@all-contributors please add @xtroncode, @TomaszG and @coreyshirk for code and documentation

@all-contributors please add @TomaszG for code and documentation

@all-contributors please add @janineahn for code and documentation

@all-contributors please add @xtroncode  for code and documentation

@all-contributors please add @hanicker  for code

@all-contributors please add @abhidp for documentation

@all-contributors please add @coreyshirk  for documentation

@all-contributors please add @TomaszG for code and documentation

@all-contributors please add @abhidp for documentation

@all-contributors please add @xtroncode for code and documentation

@all-contributors please add @janineahn for code and documentation

@all-contributors please add @nickcox for documentation

@all-contributors please add @nickcox for documentation

@all-contributors please add  @MeStrak for documentation and code

@all-contributors please add @mlsad3 for documentation and code

@all-contributors please add @KyleThenTR for documentation

@all-contributors please add @redaxmedia for ideas

@all-contributors please add @huskywhale for documentation

@all-contributors please add @adityatr for content


E-01-S02 Domain registration

We need a new Domain for bloodconnect and have it registered in route53. As it's an opensource project, it should be .org domain. It can be bought from AWS or any other 3rd party services. If it's bought from somewhere else, we wanna manage it via route53.
Acceptance criteria:

Domain bought and configured with route53
HTTPS with auto reniewal.
Integration with a front-end application or backend API.

From our stand-up discussion I came to know that the has been purchased and set to route53. I am planning to go forward with another parts of these task.


CSRF validation missing - enhanced rule forked from main CodeQL queries

Improvement from existing cs/web/missing-token-validation rule.
I also don't want to take the same shortcut checking that at least one other HttpPost is validated before flagging those that aren't, since that leads to loads of FNs.
I plan to make one version that is just an update of the original, adding AspNetCore, but this is an attempt to be much more thorough on spotting anti-CSRF devices.

This repo has been merged with the Security Lab one into the new community-codeql-packs repo which we plan to make public and promote soon. If you would like this PR to be applied to the new repo, please open a new PR there so it can get merged in the new QLPacks.


Get API docs on pydoc.io

Getting travis to run pydoc seems to be hard. Readthedocs is about prose docs rather than API docs. pydoc itself seems to need to actually import the code, rather than working from an AST, which makes it more fragile.
Proposal: When we move to python3 try again with pydoc.io, and until then don't worry about building API docs: just read comments in the code.

Packaging as a wheel made this possible, and the README now links to the built docs.


Remove junk lines in common.md

During the translation of common.md, I found three lines that were clearly junk, so I removed them.

Wow nice find, thanks!


Shopify Cart API, custom fields & improvements

[x]  implement Shopify Cart API
[x]  update Shopify GraphQL schema
[x]  refactor Shopify utils files structure & several fixes
[x]  implement custom fields
[x]  update product image on the variant change
[x]  update product price on the variant change

https://commerce-git-cart-api-cond0r.vercel.app/product/vans-era-59-moroccan-geo-dress-blues

@muhammad-saleh I closed it because I decided to make it in smaller batches. Some parts are open in other PRs some will be reopened in near future.


Add support save images

Add support save images

ping @aluzzardi @vieux @abronan

@vieux You are way more familiar than me with what's that supposed to do, could you take a look?
What kind of things should be tested? Maybe a load afterwards on a third (clean host, without even busybox, just start_docker), run images on it and make sure both test1 and test2 are there?

Regarding my previous comment on saving images which are on different machines:
1/ If it's something we want to support, we should add a test
2/ If it's something we don't want to support, we should add a test anyway and verify that it fails properly

@jimmyxian @aluzzardi I say we don't support save on multi machine (at least for now) so we it would be nice to add a proper error and a test.

Also, can we then rmi busybox and testimage; load the tar file; and do a images again ?

@aluzzardi  @vieux Yeah. I will update by the comments.

ping @aluzzardi @vieux @chanwit Modified by the comments, check again, thks


Wpf integration

Could anyone tell how I can integrate Raylib in WPF through its handle.
I am using Raylib-cs 3.0 version.

I was looking towards this thing too, I've tried embedding it using HwndHost previously, but it's a really hacky and shaky way which causes some syncing issues, especially when resizing an app.
The only thing I can suggest is creating a separate WPF control, rendering to RenderTexture, drawing it in app using WPF API and rerouting inputs to Raylib. It's still hacky, adds overhead, but that's a constant issue when dealing with both DirectX & OpenGL at the same time.
I also thought of custom platform initially, but it would only make less mess if you implement DirectX rendering (or use a fork which implements it), otherwise, you'll still have the same messy rendering scheme as described previously. And you'd have to make changes to Raylib itself, which is past the C# at this point.
IMO, this looks like an out of scope issue to be resolved by another library rather than wrapper itself, especially due to WPF being a Windows-only framework.


BiLock assertion failure and segfault in --release mode (single-threaded!)

Consider the following program (which has been minimized from a much more complex situation):
# Cargo.toml
[package]
name = "crash"
version = "0.0.1"

[[bin]]
name = "crash"
path = "crash.rs"

[dependencies]
futures = "=0.1.6"
tokio-core = "=0.1.1"
mio-uds = "=0.6.0"

// crash.rs
extern crate futures;
extern crate tokio_core;
extern crate mio_uds;

use futures::{Async, Future, Poll};
use futures::sync::oneshot;
use tokio_core::io::Io;

enum State<W> {
    Writing(W, oneshot::Sender<()>),
    BetweenWrites(W),
    Empty,
}

pub struct WriteQueue<W>  {
    pending: Option<oneshot::Sender<()>>,
    state: State<W>,
}

impl <W> WriteQueue<W> {
    pub fn new(writer: W) -> WriteQueue<W>
    {
        let (complete, _) = futures::oneshot();
        WriteQueue {
            pending: Some(complete),
            state: State::BetweenWrites(writer),
        }
    }
}

enum IntermediateState<W> {
    WriteDone(W),
    StartWrite(oneshot::Sender<()>),
    Resolve,
}

impl <W> Future for WriteQueue<W> {
    type Item = ();
    type Error = ();

    fn poll(&mut self) -> Poll<Self::Item, Self::Error> {
        loop {
            let next: IntermediateState<W> = match self.state {
                State::Writing(_, _) => return Err(()),
                State::BetweenWrites(ref mut _writer) => {
                    let front = self.pending.take();
                    match front {
                        Some(complete) => {
                            IntermediateState::StartWrite(complete)
                        }
                        None => {
                            IntermediateState::Resolve
                        }
                    }
                }
                State::Empty => unimplemented!(),
            };

            match next {
                IntermediateState::WriteDone(_w) => unimplemented!(),
                IntermediateState::StartWrite(c) => {
                    let new_state = match ::std::mem::replace(&mut self.state, State::Empty) {
                        State::BetweenWrites(w) => {
                            State::Writing(w, c)
                        }
                        _ => unreachable!(),
                    };
                    self.state = new_state;
                }
                IntermediateState::Resolve => {
                    match ::std::mem::replace(&mut self.state, State::Empty) {
                        State::BetweenWrites(_w) => {
                            return Ok(Async::Ready(()))
                        }
                        _ => unreachable!(),
                    }
                }
            }
        }
    }
}

pub fn main() {
    let mut core = ::tokio_core::reactor::Core::new().unwrap();
    let (_, server_stream) = ::mio_uds::UnixStream::pair().unwrap();
    let handle = core.handle();
    let (_, server_writer) = ::tokio_core::reactor::PollEvented::new(server_stream, &handle).unwrap().split();
    let _ = core.run(WriteQueue::new(server_writer));
}

If I run it in debug mode, it exits without error, as I would expect. If I run in in release mode, I see, to my surprise:
$ RUST_BACKTRACE=1 ./target/release/crash
thread 'main' panicked at 'assertion failed: `(left == right)` (left: `1`, right: `0`)', /Users/dwrensha/.multirust/toolchains/stable/cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.6/src/lib.rs:195
stack backtrace:
   1:        0x100960408 - std::sys::backtrace::tracing::imp::write::h6f1d53a70916b90d
   2:        0x10096256f - std::panicking::default_hook::{{closure}}::h137e876f7d3b5850
   3:        0x1009616c5 - std::panicking::default_hook::h0ac3811ec7cee78c
   4:        0x100961c16 - std::panicking::rust_panic_with_hook::hc303199e04562edf
   5:        0x100961ab4 - std::panicking::begin_panic::h6ed03353807cf54d
   6:        0x1009619d2 - std::panicking::begin_panic_fmt::hc321cece241bb2f5
   7:        0x10095261f - <alloc::arc::Arc<T>>::drop_slow::h94a0b56e89cad006
   8:        0x100953dfb - crash::main::hddfbd08facd330e5
   9:        0x100962b2a - __rust_maybe_catch_panic
  10:        0x100961206 - std::rt::lang_start::h538f8960e7644c80
Segmentation fault: 11

The assertion being tripped is in BiLock::drop()

Minimized to not use mio-uds or tokio-core, still working on it.

Looks like this may be a compiler bug :(

Thanks for looking into this. In https://github.com/rust-lang/rust/issues/38437 you seem to be suggesting that the problem only exists on nightly. Note, however, that the program that I pasted in my original comment above also behaves weirdly on stable and beta.

Yeah that's why I want to leave this open. I think that they're all related to the same bug, and my guess is that codegen changed between stable/beta/nightly to hide the bug of the reduced test case on stable/beta but leave it exposed on nightly.
Put another way, my hope (and assumption) is that fixing rust-lang/rust#38437 will fix this test case on all three channels. If that isn't the case though I'll keep digging into the stable/beta versions.

Ok I just confirmed that https://github.com/rust-lang/rust/pull/38600 fixed this, so closing now that it's landed.


Invalid PS code getting user objectId into variable

The line:
azureaduser=$(az ad user list --filter "userPrincipalName eq '<user-principal-name>'" --query [].objectId --output tsv)
Should be:
$azureaduser = (az ad user list --filter "userPrincipalName eq '<user-principal-name>'" --query [].objectId --output tsv)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31b0d33c-f88e-d50c-2926-7933940f3b92
Version Independent ID: 4aaef906-f501-6947-5d23-1b704470f09d
Content: Secure SQL Database connection with managed identity - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-connect-msi.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@larsathle , Thank you for sharing the query. We are looking into this and will get back to you on this thread soon.

@larsathle , is this regarding the section - https://docs.microsoft.com/en-us/azure/app-service/app-service-web-tutorial-connect-msi#grant-database-access-to-azure-ad-user?

@DashleenBhandari-MSFT , Yes.
I also spotted the same syntax here.
https://docs.microsoft.com/en-us/azure/app-service/app-service-web-tutorial-connect-msi#add-managed-identity-to-an-azure-ad-group
It fails with this message when running in shell.azure.com.
WARNING:
The specified wildcard character pattern is not valid: azureaduser=$(az ad user list --filter "userPrincipalName eq ''" --query [].objectId --output tsv)
azureaduser=$(az ad user list --filter "userPrincipalName eq ''" --query [].objectId --output tsv) : The term 'azureaduser=$(az ad user list --filter "userPrincipalName eq ''" --query [].objectId --output tsv)' is notrecognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1

azureaduser=$(az ad user list --filter "userPrincipalName eq '<user-p ...

CategoryInfo          : ObjectNotFound: (azureaduser=$(az ad\u2026ectId --output tsv):String) [], CommandNotFoundException
FullyQualifiedErrorId : CommandNotFoundException

@larsathle The snippets in the tutorial are written for the Bash window in the Cloud Shell. If you use the PowerShell window then definitely changes are required.
#please-close

@cephalin - I suggest an edit to the header of the mentioned examples from "Azure CLI" to "bash". Then it'd be clear for those that aren't fluid in both bash and PowerShell, and it'd match the other parts of the same page.
Thanks.


[20.03] documentation: minor spelling and stylistic fixes

Make sure this goes on master as well.

Yeah, makes sense. Better to put in master and cherry-pick. I've opened #84395 instead.


HttpServer path matching uses too much storage

In the current implementation of path matching, we always use Regular Expressions.  A regular expression path match uses between 600 and 1500 bytes.   This is too much.  We want to add an alternate mechanism that will simply use a string for pattern matching.

Changed code to handle either static paths or regular expressions.


Declaring "interface" variable prevents file to be included into coverage

Link to bug demonstration repository
https://gitlab.com/GreaterV/nyc-interface-issue
Expected Behavior
Nyc should take "g.js" file into an account while calculating the coverage.
Like this:
-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------|---------|----------|---------|---------|-------------------
All files  |     100 |      100 |     100 |     100 |
 f.js      |     100 |      100 |     100 |     100 |
 g.js      |     100 |      100 |     100 |     100 |
 script.js |     100 |      100 |     100 |     100 |
-----------|---------|----------|---------|---------|-------------------

Observed Behavior
Nyc ignoring "g.js" file if it has a variable named "interface":
// g.js
const interface = 1; // remove file from coverage

function g() {
    return 10;
}

exports = module.exports = g;

Like this:
-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------|---------|----------|---------|---------|-------------------
All files  |     100 |      100 |     100 |     100 |
 f.js      |     100 |      100 |     100 |     100 |
 script.js |     100 |      100 |     100 |     100 |
-----------|---------|----------|---------|---------|-------------------

Removing or renaming "interface" variable fix this issue.

nyc operates in strict mode by default.  interface is a reserved keyword in strict mode so you can either configure "es-modules": false on nyc or stop using interface.  nyc 16 will be clearer about there being an error, see #1280.


[FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment

What is the purpose of the change
In the long run we want to have a single self-contained unified TableEnvironment equivalent to ExecutionEnvironment & StreamExecutionEnvironment with execute method. Moreover Blink planner translates queries lazily when the execute method is called on TableEnvironment This PR enables creating an instance of the unified TableEnvironment. It also implements the lazy translation schema.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @godfreyhe @twalthr

hi @dawidwys , i'm trying to adapt blink planner to unified table environment + this pr. in blink planner, there are many kinds of plan tests, such as: rule test(LogicalUnnestRuleTest), logical plan test(SubQueryAntiJoinTest), physical plan test(CalcTest), and so on. and plan test result contains planBefore (the original RelNode tree) and planAfter(the optimized RelNode tree). so, i want to expose bufferedModifyOperations as protected or add a get method for testing.

Hi @godfreyhe, I would like to propose the following solution to keep the reworking efforts of the tests low and avoid changes of the API classes just for tests. As far as I know, all test classes extend from some test base, right? The test base can provide a mocking table environment TestingTableEnvironment implements TableEnvironment that allows for arbitrary testing logic. E.g. buffering ModifyOperations. What do you think?

@twalthr thanks for your suggestion. yes, all test classes extend from TableTestBase in blink planner.      we could add a TestingTableEnvironment which extends TableEnvironmentImpl, and override insertInto, sqlUpdate, execute methods. (insertInto method and sqlUpdate method in TestingTableEnvironment are same with TableEnvironment's)

CI report for commit 0aa1e39f2100670115c4ebf91346e573a55a1762: SUCCESS Travis


Code structure makes it hard to contribute

As the codebase grew, the structure became unwieldy for modifications.

When I browse over the source, a couple of things I feel could be improved along the lines of this issue.  Names of fields and variables are a bit cryptic and little commentary exists. It may seem tedious and not very beneficial, but I think small improvements to these two could be very beneficial to those looking to contribute in some way.

Code should be a lot more approachable now. Will be considering further improvements in the future, in order to make it easy for devs to use chart programatically, by importing the packages.


Verification of the search bar functionality with special characters ,, ###$$%%(( "

ENVIRONMENT:
URL: https://admin.peviitor.ro/
Browser: Chrome
Device: PC
OS: Windows 10
STEPS TO REPRODUCE:
Enter URL "https://admin.peviitor.ro/" in to the browser
Press ENTER Main page opens
Type in the search bar special characters like ,, ###$$%%(( "
Expected result: No companies should appear
Actual result: All the companies appear
Type again in the search bar special character like " !$%%%%%% "
Expected result: No companies appear

Fixed..


After deleting primary IP from device, no way to set other predefined IPs as primary

Probably need the ability to edit any/all IPs assigned to a device. At the very least, the option to set/unset IP as primary for device.
I'm on 1.2.1, though it doesn't appear this was fixed in the 1.2.2 release (I'll confirm later this weekend), and I didn't see an open issue about it.
Had no issue updating the DB manually to reflect the change (deleted old primary IP, set old secondary to primary).

You can edit the device and select a new primary IP from the list of assigned IPs.


Month View 'Days' - no color option

Expected Behavior
Setting the Month View 'color' Input Parameter should change ALL text coloring
Current Behavior
Setting the Month View 'color' Input Parameter does not change the Day text color or the navigation icon colors
Possible Solution
Steps to Reproduce (for bugs)

searchType: frontmatter
searchTarget: Gym
datasetName: " "
folder: • Calendar/Journal/Daily
fixedScale: 0.5
month:
    startWeekOn: mon
    color: "#C4B1E6"

Output renders as:

I can see parameters for the Month and Year color individually but no option for the remaining text/nav

I suspect there is another parameter you need to set for the color of the days. I'll need to look through code again and then we'll have to update the docs


Mass bug: architecture_independent tag verification

With the addition of noarch support for RPMs in bloom (https://github.com/ros-infrastructure/bloom/pull/270), I found a couple of packages that incorrectly marked architecture_independent when they were, in fact, not so. These packages were notified and the appropriate package.xmls updated.
Inversely, there are MANY packages that do not mark architecture_independent when they should. This is mostly because the current debian buildfarm is unable to leverage this.
My experimental RPM buildfarm (http://csc.mcs.sdsmt.edu/jenkins/) has the capability to both utilize this and to check when it is missing, so I'm compiling a list of packages that should be updated.
Hopefully this will act as a first step in implementing this functionality on the debian buildfarm, and to produce smaller, more accurate builds on the RPM buildfarm.
Thanks!
Originally https://github.com/ros/catkin/issues/623
Package List (work-in-progress):
After compiling the list, I've decided that there are just too many packages to target all of Hydro. Instead, I'll try to catch Indigo packages as they come in.
This is a preliminary list. Some of these may be false positives.

[x] ackermann_msgs https://github.com/jack-oquin/ackermann_msgs/pull/3
[x] actionlib_msgs https://github.com/ros/common_msgs/pull/35
[x] angles https://github.com/ros/angles/pull/4
[x] bond https://github.com/ros/bond_core/pull/4
[x] bondpy https://github.com/ros/bond_core/pull/4
[x] calibration_estimation https://github.com/ros-perception/calibration/pull/24
[x] calibration_launch https://github.com/ros-perception/calibration/pull/24
[x] calibration_msgs https://github.com/ros-perception/calibration/pull/24
[x] camera_calibration https://github.com/ros-perception/image_pipeline/commit/dac6e56c46b19474f7a18fbb40b312c6173a8ad8
[x] capabilities https://github.com/osrf/capabilities/pull/76
[x] catkin https://github.com/ros/catkin/pull/625
[x] cmake_modules https://github.com/ros/cmake_modules/pull/18
[x] concert_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[x] concert_service_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[x] control_msgs https://github.com/ros-controls/control_msgs/pull/11
[x] diagnostic_msgs https://github.com/ros/common_msgs/pull/35
[ ] driver_base https://github.com/ros-drivers/driver_common/pull/6
[ ] ecl_build
[ ] ecl_concepts
[ ] ecl_converters_lite
[ ] ecl_eigen
[ ] ecl_license
[ ] ecl_linear_algebra
[ ] ecl_math
[ ] ecl_mpl
[ ] eigen_stl_containers
[ ] flir_ptu_description
[ ] flir_ptu_viz
[x] gateway_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[x] gencpp https://github.com/ros/gencpp/pull/19
[ ] geneus
[ ] genlisp
[x] genmsg https://github.com/ros/genmsg/pull/71
[x] genpy https://github.com/ros/genpy/pull/27
[x] geometry_msgs https://github.com/ros/common_msgs/pull/35
[ ] household_objects_database_msgs
[ ] joint_state_publisher
[ ] librviz_tutorial
[ ] manipulation_msgs
[ ] map_msgs
[ ] media_export
[ ] message_generation
[ ] message_runtime
[ ] mk
[ ] moveit_commander
[ ] moveit_ikfast
[ ] moveit_msgs
[ ] moveit_resources
[x] nav_msgs https://github.com/ros/common_msgs/pull/35
[ ] nmea_msgs
[ ] nodelet_topic_tools
[x] object_recognition_msgs
[ ] octomap_msgs
[ ] pcl_conversions
[ ] pcl_msgs
[ ] pr2_mechanism_msgs
[ ] python_qt_binding
[ ] qt_dotgraph
[ ] qt_gui_app
[ ] qt_gui
[ ] qt_gui_py_common
[ ] rail_maps
[x] rocon_app_manager_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[ ] rocon_bubble_icons
[ ] rocon_console
[x] rocon_device_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[ ] rocon_ebnf
[ ] rocon_gateway
[ ] rocon_gateway_tests
[ ] rocon_gateway_utils
[ ] rocon_hub_client
[ ] rocon_hub
[ ] rocon_icons
[x] rocon_interaction_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[ ] rocon_interactions
[ ] rocon_launch
[ ] rocon_master_info
[ ] rocon_python_comms
[ ] rocon_python_redis
[ ] rocon_python_utils
[ ] rocon_python_wifi
[ ] rocon_semantic_version
[x] rocon_service_pair_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[x] rocon_std_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[ ] rocon_test
[x] rocon_tutorial_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[ ] rocon_uri
[ ] rosapi
[ ] rosbag_migration_rule
[ ] rosbash
[ ] rosboost_cfg
[ ] rosbridge_library
[ ] rosbridge_server
[ ] rosbuild
[ ] rosclean
[ ] roscpp_traits
[ ] roscreate
[ ] rosdoc_lite
[x] rosgraph https://github.com/ros/ros_comm/pull/391
[ ] rosgraph_msgs
[ ] roslang
[x] roslaunch https://github.com/ros/ros_comm/pull/391
[ ] roslint
[ ] roslisp
[ ] rosmake
[x] rosmaster https://github.com/ros/ros_comm/pull/391
[x] rosmsg https://github.com/ros/ros_comm/pull/391
[x] rosnode https://github.com/ros/ros_comm/pull/391
[x] rosparam https://github.com/ros/ros_comm/pull/391
[x] rospy https://github.com/ros/ros_comm/pull/391
[ ] rospy_tutorials
[x] rosservice https://github.com/ros/ros_comm/pull/391
[x] rostest https://github.com/ros/ros_comm/pull/391
[ ] rostopic
[ ] rosunit
[x] roswtf https://github.com/ros/ros_comm/pull/391
[x] rqt_action https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_bag https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_bag_plugins https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_console https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_dep https://github.com/ros-visualization/rqt_common_plugins/pull/254
[ ] rqt_gui
[ ] rqt_gui_py
[x] rqt_graph https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_launch https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_logger_level https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_msg https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_plot https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_publisher https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_py_common https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_py_console https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_reconfigure https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_service_caller https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_shell https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_srv https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_top https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_topic https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rqt_web https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] rviz_python_tutorial https://github.com/ros-visualization/rqt_common_plugins/pull/254
[x] scheduler_msgs https://github.com/robotics-in-concert/rocon_msgs/pull/95
[x] sensor_msgs https://github.com/ros/common_msgs/pull/35
[x] shape_msgs https://github.com/ros/common_msgs/pull/35
[ ] smach
[ ] smach_msgs
[ ] smach_ros
[ ] smach_viewer
[x] smclib https://github.com/ros/bond_core/pull/4
[ ] std_capabilities
[ ] std_msgs
[ ] std_srvs
[x] stereo_msgs https://github.com/ros/common_msgs/pull/35
[ ] tf2_bullet
[ ] tf2_geometry_msgs
[ ] tf2_kdl
[ ] tf2_msgs
[ ] tf2_py
[ ] tf2_tools
[ ] timestamp_tools https://github.com/ros-drivers/driver_common/pull/6
[x] trajectory_msgs https://github.com/ros/common_msgs/pull/35
[x] unique_id https://github.com/ros/rosdistro/issues/4037#issuecomment-41842366
[ ] urdfdom_headers
[ ] urdfdom_py
[ ] urdf_parser_plugin
[x] uuid_msgs https://github.com/ros/rosdistro/issues/4037#issuecomment-41842366
[x] visualization_msgs https://github.com/ros/common_msgs/pull/35
[x] xacro https://github.com/ros/xacro/pull/32
[x] xdot https://github.com/jbohren/xdot/pull/4
[x] zeroconf_msgs https://github.com/stonier/zeroconf_msgs/pull/1

@cottsay Is this still of interest ? Is the aforementioned fedora buildfarm still active (for testing, if we keep adding the architecture independant tag to packages) ?

The Fedora buildfarm is not currently active. Maybe I'll have cycles to get things running again some day, but not now.

I recently noticed a ROS2 pull request to remove <architecture-independent/> from one of the unique_identifier packages.
Is there opposite motion going on?

While this tag is used only in the RPM metadata generated by bloom, I think it's valuable information and maybe the ROS buildfarm will leverage it some day. So we do not encourage users to get rid of it in ROS2.
One thing to keep in mind though is that ROS2 message packages do compile code and libraries so cannot be considered architecture-independent anymore. Only pure python packages (build type ament_python in the ROS2 world) and header-only packages can be considered architecture independent.

@cottsay We've turned on RPM builds on ROS 2 rolling and we've shipped Noetic already which is the last ROS 1. To that end this seems like it should be caught now in rolling and we're not likely to turn on for Noetic so can we close out this long running ticket as enough for now?

this seems like it should be caught now in rolling

The new buildfarm code doesn't have support for RPM linting yet, so we won't catch packages that are missing the tag but should have it. We'll still catch packages that claim to be architecture-independent but actually aren't.
I have a hunch that ROS 2 is in pretty rough shape as far as this flag is concerned. There are advantages to doing noarch right, but we still don't have any capability in the buildfarm to build noarch packages only once, so we can't take full advantage of it even if it's declared correctly in the packages.
I think we should close this bug now - it was intended for tracking the feature in ROS 1, and like you said, it's unlikely that we'll ever see Noetic RPMs on the buildfarm. We can always re-open it if things change.


[decompiler] fix crash when top level fails to decompile.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 65.538%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/analysis/find_defstates.cpp
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
39515

Relevant Lines:
60293

💛  - Coveralls


FT300 never connects on ROS Kinetic/Ubuntu 16.04 using robotiq/jade-devel or kinetic-devel

I posted this on ROS answers and was told to bring it here.
Our lab is using Kinetic on Ubuntu 16.04 and we can't connect to our FT300 sensor with this package. Using just the instructions in the FT300 manual (under the Development Package section), I was able to get sensor readings to show up in the terminal, so I do at least know my computer can make the connection. But rosrun robotiq_force_torque_sensor rq_sensor, which should do the same thing, just gives me lines and lines of "Waiting for sensor connection..." indefinitely. I've tried the following in various combinations:

Using both the jade-devel and kinetic-devel branches of the Robotiq repository
Specifying the exact \dev\ttyUSB* device that the sensor shows up as
Modifying my files using TheDash's pull request that allows FT300 support

Unfortunately I lack the technical knowledge to know what the source of this problem is. As far as I can tell, the only fix is to downgrade to Ubuntu 14.04 and Indigo, since another lab has been able to get their FT300 working that way. Has anyone else run into this problem and managed to solve it somehow? Are there any tests I can run to figure out if ros-industrial/robotiq is actually the problem here? Otherwise, can anyone give me a rough idea of how much headway has been made towards making this possible?
Thanks for your attention.

Update: it appears the problem was one of permissions. Adding myself to the dialout was not enough to allow me to connect; I had to run sudo chown [me] /dev/ttyUSB1. I would close this issue except I don't know if it's one that can be fixed within the package itself or if this is an expected step in this type of connection.

Update: it appears the problem was one of permissions. Adding myself to the dialout was not enough to allow me to connect; I had to run sudo chown [me] /dev/ttyUSB1. I would close this issue except I don't know if it's one that can be fixed within the package itself or if this is an expected step in this type of connection.
I think at the very least a line should be added to the wiki page for installation warning users of this.

I believe the reason this is not documented somewhere is that adding the user to the dialout group should be sufficient.
Perhaps @jproberge can comment on how he sets up his machines.

Hello @otolithic and @gavanderhoorn ,
First of all, I'm sorry for the delay, I was out of office and didn't see your post until now.
I frequently get emails from Robotiq customers with the exact same problem. Hence, this is indeed an issue many people encounter and I'll make sure to document it better in the wiki page. I'll start to significantly update the wiki page starting this week or next and I'll make sure to properly address this point.
So, as @gavanderhoorn already pointed out, this is solved by adding the $USER to the dialout group. This can be achieved normally simply by typing "sudo usermod -a -G dialout $USER". This is what I've done on my machine and this fix prevents you from having to give back read and write permissions each single time the device is plugged back in. I suggest you eventually use that solution over using commands of the kind "sudo chmod 666 /dev/ttyUSBX" because "X" will not be static and rather depends on the order in which ttyUSB devices are plugged in, and also, the permissions you give will be "forgotten" by the OS if you turn off your computer or even if you just unplug and re-plug in the FT300.
I'll make sure to add more details about that issue on the wiki page in the upcoming 5-7 days in an effort to minimize the number of people affected by this issue in the future. Thanks!

Thanks @jproberge.
Would it perhaps be an idea to add some udev rules to the repository as well?
Those could help with this issue.

@gavanderhoorn ,
Very good point and I totally agree with that idea! In fact, my initial answer to this issue was exactly to create proper udev rules. udev rules could fix non-persistent permissions and non-static device ID at the same time. I'll take the time to take a look at how this can be done properly within a ros package and I might indeed propose a pull request to add them. An eventual PR with valid udev rules could address this problem, but also indirectly address issues such as #107 .

I'm closing this issue, as suggested by @otolithic , more explicit information on how to resolve this issues has been added to the wiki page.

Hi all:
I have plug the force sensor on my computer and follow the instruction of @jproberge by adding the user dialout and gave the permission of the USB port. Then I run the code:
rosrun robotiq_ft_sensor rq_sensor
It shows
[ INFO] [1625843512.095571884]: No device filename specified. Will attempt to discover Robotiq force torque sensor. [ INFO] [1625843513.316304590]: Waiting for sensor connection...
My system is Kinetic (16.04), any ideas for getting connected to the force sensor?
Best,
Gloria


bazel: 0.18.0 -> 0.20.0

Motivation for this change
Upgrading Bazel. Tested bazel, bazel_jdk11, bazel-watcher, bazel-deps, pythonPackages.tensorflow, pythonPackages27.tensorflow, pythonPackages36.tensorflow.
bazel-watcher requires https://github.com/NixOS/nixpkgs/pull/51723.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

We have a second PR in https://github.com/NixOS/nixpkgs/pull/51783.

Yeah #51783 avoids a lot of complexity by deleting some stuff, I think that's good assuming we're ok with deleting it.

@mboes What do you think? I'm happy for either one to go through.

I merged https://github.com/NixOS/nixpkgs/pull/51783, because it removes more lines than it introduces (by disabling a superfluous test).

@uri-canva could you make a new pull request that switches to BAZEL_BOOTSTRAP_STARTUP_OPTIONS?


Update "System Assigned" to "Identity-based"

The UI option is called "Identity-based" and not "System Assigned".

@avranju : Thanks for your contribution! The author(s) have been notified to review your proposed change.

LGTM #sign-off


Purpose of ansibleuser not obvious

In the all.yml file that defines all the variables to use, it wasn't immediately obvious to me what ansibleuser was for. At first I was thinking this was the user I am running ansible as. Which didn't make sense, so i commented it out. I have my controlplane and nodes set up in my ~/.ssh/config so the playbook was able to install stuff. But the kubeconfig file was getting copied to nowhere. That was my clue. So maybe clarify that ansibleuser is the user you are ssh'ing into the master and nodes. So on an ubuntu box, it may be ubuntu.

Thanks, added a comment https://github.com/techno-tim/k3s-ansible/commit/24225c69c9f4b8fe75ab178774abc9d8a98c7330


Some memory optimizations

I changed a single line, so that calling associations will be lazily evaluated.
I don't know if it's a breaking change, however specs are working.
I discovered it while inspecting memory leaks using derailed gem.
Pings:
@cheerfulstoic
@subvertallchris

[Current coverage][cc-pull] is 97.34%

Merging [#1221][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master      #1221   diff @@
==========================================
  Files           184        184
  Lines         11100      11100
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          10805      10805
  Misses          295        295
  Partials          0          0

Powered by Codecov. Last updated by [c268010...ee9edb5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/neo4jrb/neo4j/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/neo4jrb/neo4j/compare/c2680108df1efad499a0bcd9c8e181a01f31d411...ee9edb57863431d575db7acb8da3f125f09a1e50
[cc-pull]: https://codecov.io/gh/neo4jrb/neo4j/pull/1221?src=pr

Definitely no, it's not working.
Here's an example of failure:
class Parent
  include Neo4j::ActiveNode
  has_one :out, :person, type: some
end

class Child < Parent
  validates :person
end

Tests:
irb(main):001:0> Child.associations
{}
irb(main):001:0> Child.create!

NoMethodError: undefined method `target_classes_or_nil' for nil:NilClass
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:483:in `association_target_class'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:465:in `association_query_proxy'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:166:in `association_query_proxy'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:196:in `fresh_association_proxy'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:188:in `block in association_proxy'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:160:in `block in association_proxy_cache_fetch'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:159:in `fetch'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:159:in `association_proxy_cache_fetch'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:176:in `association_proxy'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/has_n.rb:426:in `block in define_has_one_getter'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/shared/validations.rb:9:in `read_attribute_for_validation'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-4.2.6/lib/active_model/validator.rb:149:in `block in validate'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-4.2.6/lib/active_model/validator.rb:148:in `each'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activemodel-4.2.6/lib/active_model/validator.rb:148:in `validate'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:455:in `public_send'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-4.2.6/lib/active_support/callbacks.rb:455:in `block in make_lambda'
... 12 levels...
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/shared/validations.rb:24:in `valid?'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/validations.rb:12:in `valid?'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/shared/validations.rb:37:in `perform_validations'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/shared/validations.rb:18:in `save'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/persistence.rb:51:in `save!'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/persistence.rb:116:in `block in create!'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/persistence.rb:114:in `tap'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-ee9edb578634/lib/neo4j/active_node/persistence.rb:114:in `create!'
	from (irb):17
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/railties-4.2.6/lib/rails/commands/console.rb:110:in `start'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/railties-4.2.6/lib/rails/commands/console.rb:9:in `start'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:68:in `console'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/railties-4.2.6/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
	from /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/railties-4.2.6/lib/rails/commands.rb:17:in `<top (required)>'
	from bin/rails:4:in `require'
	from bin/rails:4:in `<main>'

I'll try to fix soon

Ok, I think I fixed. Please take a look!

@cheerfulstoic Indeed I was introducing a bug!
Since parent_associations was assigned tu associations, when defining new associations in the child, also the parent got it, since it's the same object. I fixed adding a .dup.

Excellent, thanks!  Thinks seems like a good way forward and I say merge it if you think it's ready!

👍


Bug(docs): the link to Learn more about Nimbella's integration for Netlify from in the readme results in 404

As a part of reviewing https://github.com/netlify/plugins/pull/155 I noticed the link to learn more about the integration is broken.

Thanks for opening the issue, @erezrokah! The page was planned to be rolled out in a couple of days but I've removed it for now. I'll add it back once it's ready.


Vulkan: enable sRGB backbuffer and sRGB textures

This PR adds support for BGFX_RESET_SRGB_BACKBUFFER and BGFX_TEXTURE_SRGB on the Vulkan backend.
Support for sRGB textures was already 99% there, just needed to select the correct format based on the texture flags. Maybe there's a reason it wasn't done by default? Pinging @rinthel just to make sure
Also removed instance layers during device creation, those are deprecated and ignored.

@pezcode Hello! I put the pixel formats in the list just because BGRA or RGBA formats are supported in most of devices. So it looks to me!

@pezcode Hello! I put the pixel formats in the list just because BGRA or RGBA formats are supported in most of devices. So it looks to me!

Yeah, that made perfect sense since the default framebuffer should be non-sRGB. What I pinged you about is this code. My change selects s_textureFormat[m_textureFormat].m_fmtSrgb if BGFX_TEXTURE_SRGB is requested but it seems a bit simple, so I just wanted to make sure it wasn't missing for an important reason.

@pezcode I think that your code is reasonable and there was no important reason not to choose SRGB during texture creation stage, just I might forget to consider it before :)

@pezcode I think that your code is reasonable and there was no important reason not to choose SRGB during texture creation stage, just I might forget to consider it before :)

OK, great 👌 Thanks for taking the time to look at it!


[GOBBLIN-2092] updated all the columns during flow_spec update

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA"

https://issues.apache.org/jira/browse/GOBBLIN-2092?j

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Updated the SPECIFIC_INSERT_STATEMENT sql statement, to include all the columns in case of update

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Might want to squash all the commits into 1 commit. Reference: https://stackoverflow.com/questions/14534397/squash-all-my-commits-into-one-for-github-pull-request

Might want to squash all the commits into 1 commit. Reference: https://stackoverflow.com/questions/14534397/squash-all-my-commits-into-one-for-github-pull-request

the final merge into apache gobblin can squash all commits, but when working on a PR, please don't do that.  after you do, it's no longer possible for reviewers to select "all commits since [their] last review"

Might want to squash all the commits into 1 commit. Reference: https://stackoverflow.com/questions/14534397/squash-all-my-commits-into-one-for-github-pull-request

the final merge into apache gobblin can squash all commits, but when working on a PR, please don't do that. after you do, it's no longer possible for reviewers to select "all commits since [their] last review"

Got it, I got confused with the Commit heading in checklist as it says to squash the commits, but I didn't realize it is for the final merge.


liblzma

+Build+error+on+x64-windows&body=Copy+issue+body+from+E%3A%2Fsrc%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

See #30604 on how to properly report an issue.


Get publicKeys from Bundle.main

We wanted to use latest release of Alamofire with latest Xcode 10.2 and Swift 5. We had ServerTrustPolicy.publicKeys(in: Bundle.main) this code before to get public keys from main Bundle but looks like ServerTrustPolicy has been obsoleted. So I tried a lot but not able to get any help. Can you take a look at this?
Alamofire Environment
Alamofire version:5 beta 4
Xcode version:10.2
Swift version:5
Platform(s) running Alamofire:iOS
macOS version running Xcode:Mojave

ServerTrustPolicy has been refactored into the ServerTrustEvaluating protocol, and the various policies ported to types conforming to that protocol. You can replace your usage of ServerTrustPolicy.publicKeys(in: Bundle.main) with PublicKeysTrustEvaluator(), which will find the keys in certificates from Bundle.main automatically.
Also, make sure to update to the latest beta, there have been some nice bug fixes since beta 4.

Does PublicKeysTrustEvaluator() return back [SecKey] the way it did return for ServerTrustPolicy.publicKeys(in: Bundle.main)?

Does PublicKeysTrustEvaluator() return back [SecKey] the way it did return for ServerTrustPolicy.publicKeys(in: Bundle.main)?

If you're looking for that functionality only, we've made public extensions on Bundle that can be used: Bundle.main.af.publicKeys.

@jshier following solution works pretty well for Alamofire < 5 but since there are big changes in v5, I can't seem to figure out the right way to implement the cert pinning (using public keys)
// 1 - provider creation
let provider = MoyaProvider<MyRouter>(
    manager: AlamofireSessionManagerBuilder().build()
)

// 2 - session manager builder
class AlamofireSessionManagerBuilder {

    var policies: [String: ServerTrustPolicy]?
    var configuration = URLSessionConfiguration.default

    // 3 - builder initializer
    init(includeSSLPinning: Bool = true) {
        if includeSSLPinning {
            let allPublicKeys = ServerTrustPolicy.pinPublicKeys(
                publicKeys: ServerTrustPolicy.publicKeys(),
                validateCertificateChain: true,
                validateHost: true
            )

            self.policies = [
                "firstsubdomain.mycompany.com": allPublicKeys,
                "secondsubdomain.mycompany.com": allPublicKeys
            ]
        }
    }

    //4 - Example function that configures alamofire's session manager
    //to increase timeout interval, useful for upload requests.
    func prepareForFileUpload() -> Self {
        configuration.timeoutIntervalForRequest = 300
        configuration.timeoutIntervalForResource = 300
        return self
    }

    // 5 - session manager creator
    func build() -> Manager {
        var serverTrustPolicyManager: ServerTrustPolicyManager?
        if let policies = self.policies { serverTrustPolicyManager = ServerTrustPolicyManager(policies: policies) }

        let manager = Manager(configuration: configuration,
                              serverTrustPolicyManager: serverTrustPolicyManager)
        manager.startRequestsImmediately = false

        return manager
    }
}

Can you help me out with this? Thanks :)

@akashnimare did you find the solution? I have exactly the same problem.

@jshier

You can replace your usage of ServerTrustPolicy.publicKeys(in: Bundle.main) with PublicKeysTrustEvaluator()
When I try to replace
ServerTrustPolicy.publicKeys()
with
PublicKeysTrustEvaluator()
i have an error:
Request failed with error: Server trust evaluation failed due to reason: No public keys were found or provided for evaluation.
I am doing something wrong?