Auto Deliver is not working.

Hello. Thank for your great jo.
I set kindleear to auto-deliver at 6am.

But it doesn't work.
If I manually hit Delivery in the Advanced Menu, it works fine.
Kindlear is installed on GAE.
Is there any way to resolve the issue?
Have a nice day.

go to GAE cron console to confirm that the APP ENGINE CRON job has been deployed successfully.
go to GAE logs console to confirm that there are logs for the automatic execution of /deliver, or to check if exists some exception records.

Thank you for your reply.
I think that that the APP ENGINE CRON job has been deployed successfully.

But I can't interpret GAE log. Can you help me?

cron works all.

Show all logs in here.
Try to set 'Oldest article' to 'No limit' or '7 Days' for testing.
Which RSS did you use for?

I can confirm that auto-delivery isn't working.
大佬，更新了最新版本，今天还是没有自动投递。

Found the bug.
This bug doesn't exist in the Docker deployment, I didn't pay attention to it and assumed it was due to your configuration or other issues.
The code has been updated. Please redeploy and test again.

downloaded-logs-20240524-085139.csv
我的也是自动推送老是不行，我已经更新到最新版本啦

I updated kindle ears. But It was not working.

Logs
downloaded-logs-20240525-091014.json

feed
https://ok97465.github.io/feed.xml
https://makersweb.net/rss
https://soooprmx.com/feed/
https://ghebook.blogspot.com/feeds/posts/default
http://moordev.tistory.com/rss
http://feeds.feedburner.com/crazytazo
https://news.hada.io/rss/blog
https://v2.velog.io/rss/mythos
http://feeds.feedburner.com/DougHellmann
https://github.com/naver/fe-news/commits/master.atom
http://feeds2.feedburner.com/rss_outsider_dev
http://jeremykun.wordpress.com/feed/
http://feeds.feedburner.com/slownews
http://pinkwink.kr/rss

Calibre recipe

import re

from calibre.web.feeds.recipes import BasicNewsRecipe

# Comment out sections you are not interested in
sections = [
    ("정치", "politics"),
    ("사회", "national"),
    ("경제", "economy"),
    ("국제", "international"),
    ("사설칼럼", "editorials"),
    ("의학과학", "science"),
    ("문화연예", "culture"),
    ("스포츠", "sports"),
    ("사람속으로", "inmul")
    # Following sections are marked as marked optional
    # as default. Uncomment to enable.
    # , (u'건강', 'health')
    # , (u'레저', 'leisure')
    # , (u'도서', 'book')
    # , (u'공연', 'show')
    # , (u'여성', 'woman')
    # , (u'여행', 'travel')
    # , (u'생활정보', 'lifeinfo')
]

class Donga(BasicNewsRecipe):
    language = "ko"
    title = "동아일보"
    description = "동아일보 기사"
    __author__ = "Minsik Cho"
    ignore_duplicate_articles = {"title", "url"}
    compress_news_images = True
    no_stylesheets = True
    oldest_article = 2
    encoding = "utf-8"

    # RSS Feed in syntax:
    # https://rss.donga.com/[sections].xml
    feeds = [(title, "https://rss.donga.com/" + section + ".xml") for (title, section) in sections]

    # Remove logo and print buttons
    remove_tags = [
        dict(name="div", attrs={"class": "popHeaderWrap"}),
        dict(name="div", attrs={"class": "etc"}),
    ]

    def print_version(self, url):
        # Original url in syntax:
        # https://www.donga.com/news/[sections]/article/all/[date]/[gid]/1
        # Return print version url with syntax:
        # https://www.donga.com/news/View?gid=[gid]&date=[date]
        reobject = re.search("(?<=/all/)([0-9]*)/([0-9]*)", url)
        date = reobject.group(1)
        gid = reobject.group(2)

        return "https://www.donga.com/news/View?gid=" + gid + "&date=" + date

Most of these RSS feeds have their published/updated times more than a week ago, so you need to set Oldest_articles to Unlimit in order to push these RSS feeds.
Some of them can be pushed.
I tested them with auto-push, and successful.

Thank you for your efforts.
The auto deliver is working now.


admin_generator broken in 1.9

Running the admin_generator command gives me the following error:
LookupError: No installed app with label '<module 'myapp.models' from '/path/to/myapp/models.pyc.
It looks like the command is trying to use the repr of the models module, rather than the app name.
I'm using 1.6.1 BTW

The same problem/

Python==3.4, Django==1.9.1.
# 328 lineno
installed_apps = dict((a.__name__.rsplit('.', 1)[0], a) for a in get_apps())

returns a dict like {'service_rest_api': <module 'service_rest_api.models'}
But AdminApp in __iter__ uses get_models_compat that seems take an app name.
I don't know what's inside django-extensions box, so i fixed it inplace with:
self.app.__name__.split('.')[0] as argument for get_models_compat

+1

I can confirm same issue.
manage.py admin_generator nhic.ingest gets me the error (truncated) of:
File "/Users/carl/.virtualenvs/oxford-processing/lib/python3.5/site-packages/django/apps/registry.py", line 155, in get_app_config
    raise LookupError(message)
LookupError: No installed app with label 'nhic.ingest'. Did you mean 'ingest'?

Whereas the command manage.py admin_generator ingest gets me the feedback of...
This command requires an existing app name as argument
Available apps:
    django.contrib.admin
    django.contrib.auth
    django.contrib.contenttypes
    django.contrib.sessions
    django.contrib.sites
    django_extensions
    nhic.ingest

... so you can see the circular logic here suggesting there's a bug. Unfortunately I don't have time presently to investigate and debug this (this is my first time trying to use this extension), but if you want a practice project/model, you can see the current state of what I'm using this with at https://github.com/nhic-tra/oxford-processing/tree/1748b5406b9d17397b235ccd464016dc3327060c
This is under:

Django (1.9.6)
django-extensions (1.6.7)
Python 3.5.1

@marshalc Does any of the two commits above fixes the problem for you ?
@all, anybody wants to put a PR together ?

Hi @trbs, my commit was already merged since version 1.6.2 and fixes the initial issue. The bug that @marshalc refers is that admin generator don't work if you are working with nested apps like nhic.ingest. I'll try to find the solution asap.
Maybe we can open a new issue and close this.

@marctc ack yeah please open a new issue, thanks for the help !


PDF rendered is super blurry

Attach (recommended) or Link to PDF file here:
super blurry PDF.pdf
Configuration:

Web browser and its version: Chrome - Version 120.0.6099.71 (Official Build) (64-bit)
Operating system and its version: Windows 11 Business 23H2
PDF.js version: Latest
Is a browser extension: No

Steps to reproduce the problem:

Rendering the attached PDF in browser using PDF.js
In any browser or OS.

What is the expected behavior? (add screenshot)
It should render perfectly
What went wrong? (add screenshot)
PDF is blurry and many texts are breaking when opened using PDF.js library. However, if this PDF rendered locally then it works fine.

PDF.js version: Latest

Please note that "latest" isn't a valid version number.

PDF is blurry and many texts are breaking when opened using PDF.js library.

Please note that your PDF document contains almost no actual text, but instead lots of images of text hence this won't look perfect e.g. at higher zoom levels.
It's also possible that this looks worse than in Chrome because of hardware accelerated rendering of canvases, something that we've previously seen in a number of cases (which points to bugs in the Chrome browser itself).

WFM, as good as it realistically can given that the PDF document itself is badly created, when using PDF.js version 4.0.321 [f54cfe065] in Firefox Nightly 122.0a1 on Windows 11.
(Please keep in mind that the built-in Firefox PDF Viewer is the primary development target for this library.)


Add project to projectile after magit-clone

After doing magit-clone (C-c g c) magit-status buffer is
automatically open. This however doesn't add it to projectile's known
projects. It stays this way until a file from a fresh clone is open. When in
this state it's not possible to quickly go to the project with
C-c H (i.e., helm-projectile).
This commit adds advice to automatically add a project to a list of
projectile's know projects after magit-clone.

Good idea.

That’s a good idea.

sdowney@kit:~/src/exordium
$ diff -u   <(ls  exordium/elpa/) <(ls  use-package/elpa/)
--- /dev/fd/63	2020-03-22 13:25:14.293618751 -0400
+++ /dev/fd/62	2020-03-22 13:25:14.294618747 -0400
@@ -8,6 +8,7 @@
 auto-complete-20170125.245
 auto-complete-c-headers-20150912.323
 avy-20200311.1106
+bind-key-20191110.416
 cider-20200319.1706
 clojure-mode-20200321.1035
 closql-20191229.1814
@@ -23,7 +24,6 @@
 epl-20180205.2049
 eval-sexp-fu-20191128.825
 evil-20200304.1421
-exec-path-from-shell-20191229.112
 expand-region-20200304.1839
 f-20191110.1357
 fill-column-indicator-20191109.10
@@ -90,6 +90,7 @@
 treepy-20191108.2217
 undo-tree-0.7.4
 undo-tree-0.7.4.signed
+use-package-20191126.2034
 vlf-20191126.2250
 with-editor-20200217.1015
 yasnippet-20191222.2206

exec-path-from-shell is OSX, but it looks like it should be downloaded now in the init-osx module. use-package itself is new, and bind-key is a dependency used by use-package for :bind .
The init-test.sh script is quite useful for checking that clean download works. Copying my prefs.el means it's even a working editor for me.

(sorry, wrong PR for that last now deleted comment)


Update call_number_display in traject for Alma

https://github.com/pulibrary/marc_liberation/blob/a691bf10e8f475172a586921d003f8f280329589/marc_to_solr/lib/traject_config.rb#L1262-L1265

Opened https://github.com/pulibrary/marc_liberation/issues/947 for the call_number_browse_s field

Feedback from @mzelesky for the call_number_display field.
Subfield c currently is used as a sub-location. In Alma, subfield c is no longer part of the call number. Subfield k replaces the function of subfield c.

closed by #948


pkg/lolcat-rs

Description of changes
Rust implementation of lolcat for speed (in my machine I get something like 26x faster results).
Things done

Built on platform(s)

[x] x86_64-linux

[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 258479 run on x86_64-linux 1

1 package built:

lolcat-rs

Would be great if you can squash the commits so there's one for the maintainer and one for the package

There already is a faster lolcat https://github.com/NixOS/nixpkgs/blob/fe0b3b663e98c85db7f08ab3a4ac318c523c0684/pkgs/tools/misc/clolcat/default.nix it's repo hasn't been updated since 2018
There is also one rust lolcat already https://github.com/NixOS/nixpkgs/blob/fe0b3b663e98c85db7f08ab3a4ac318c523c0684/pkgs/tools/misc/dotacat/default.nix
Please discuss with their maintainers @felipeqq2 and @traxys  to decide which one should be kept to not have  4 novelty program lolcats

I disagree about having too many lolcats. https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md says the following:

How realistic is it that it will be used by other people? It's good that nixpkgs caters to various niches, but if it's a niche of 5 people it's probably too small.

https://github.com/ur0/lolcat repository on GitHub has 87 stars, and https://lib.rs/crates/lolcat counts 3 downloads per day from crates.io. It's also packaged on AUR by two different people: https://aur.archlinux.org/packages/rust-lolcat-git and https://aur.archlinux.org/packages/lolcat-rs.
I don't think this specific package is too niche for nixpkgs, personally.

Not too niche but it's a novelty program and do we need 4 lolcat implementations

By nature, lolcat is human interaction software (I like using it in my shell prompt and motd).  Latency matters for interaction because it produces annoyance; the experimental limit for perception is as low as 2ms, with 10ms response latency getting annoying for gamers, and 100ms for human beings.[1]  With the original ruby lolcat, sh -c 'echo "hello world" | lolcat on a 2022 Thinkpad T14s on a fresh NixOS install takes 105ms, making it completely unusable, likely to send the system into trashing, and a significant contributor to global warming.[2]
Having commited to adding cutting-edge 1989 technology to my terminals,[3] I decided to take upon the task of benchmarking various lolcat rust implementations.  To test performance in a slower system as well as compilation outside x86, I used my Raspberry Pi 4 (Armbian).  Because I think for typical lolcat use, latency to repeated operation matters more than throughput, but to also add some heft, I did the following test:
for i in $(seq 1 500); do cat /usr/share/common-licenses/GPL-3 | $lolcat ; done

(A tad more complicated than that cos some of them need "--force" options when outputing to a nonterminal.)  Results:
cat:         1.09user 1.39system 0:01.38elapsed 179%CPU (0avgtext+0avgdata 1700maxresident)k
lolcat-rs:   43.98user 65.34system 1:52.65elapsed 97%CPU (0avgtext+0avgdata 2488maxresident)k
clolcat:     1.65user 2.46system 0:03.21elapsed 128%CPU (0avgtext+0avgdata 2124maxresident)k
lcat:        14.46user 7.20system 0:24.29elapsed 89%CPU (0avgtext+0avgdata 2548maxresident)k
dotacat:     42.52user 7.71system 0:53.40elapsed 94%CPU (0avgtext+0avgdata 3624maxresident)k
lolcrab:     14.51user 6.79system 0:23.08elapsed 92%CPU (0avgtext+0avgdata 2504maxresident)k
lolcat:      2.21e+08user 6e+07system 3679230:13.12elapsed 90%CPU (0avgtext+0avgdata 14588maxresident)k)[4]

Somewhat disappointingly to my Rust fangirl ass, not only did lolcat-rs performed poorly, but it seems like no one can even approach clolcat for speed (due to better concurrency?).  In fact it's almost spooky how close clolcat comes to regular cat; I had to triple-check it wasn't turning off colorization due to the pipe.
Another feature to consider in a drop-in replacement is option parity.  Do the options match the original lolcat?
lolcat-rs    no
clolcat      partially
lcat         no
dotacat      partially
lolcrab      partially

Other considerations:

lcat features better colour spaces and Unicode support.
lolcrab forks lcat to add random noise patterns.  It also seems to be the only one to implement the original's animation mode.
By downloads and recency on crates.io, lcat wins, lolcrab second.

In conclusion: I'm closing my own PR; I don't think lolcat-rs is worth it when it brings nothing new to the table, and clolcat soundly beats it on every regard as a drop-in replacement.  I'm not sold on dotacat either, to be honest.  There's a good argument to be made for lcat, in my opinion, since it has better colours and compability, and is both popular and active.
1: https://danluu.com/input-lag/
2: for clarity: this is hyperbole for the sake of humour (as is this whole overcommitment to the bit, I don't care about lolcat all that much).
3: 24-bit colour.
4: Actually it was like, 22 minutes.


Allow minimized attribute completions anywhere in the attribute

Fixes https://github.com/dotnet/razor-tooling/issues/6578

I tested manually with the Title attribute of Survey prompt, but I'll double check that case too when I'm next at a computer. Thanks for the suggestion.

I tested manually with the Title attribute of Survey prompt

Did you test case, when there is a Title value as I showed in the issue, e.g. <SurveyPrompt Tit$$le="Test />". I have a suspicion is that this can break because only minimalized attributes are considered. Would like to see such test in the codebase.

Would like to see such test in the codebase.

Thank you, I missed this scenario, and in fact there is a test that covers it but of course it is expecting the wrong thing. Works like this with the fix:

Expanded this to more attribute types, and updated the tests. The tests that I've changed don't seem problematic to me, but I might be missing something. It appears the previous logic was added in https://github.com/dotnet/razor-tooling/pull/3839 but that PR and linked issue only talks about tags, not attributes, and I haven't changed them, so maybe the restriction on attributes was less intentional? @NTaylorMullen?

It appears the previous logic was added in https://github.com/dotnet/razor-tooling/pull/3839 but that PR and linked issue only talks about tags, not attributes, and I haven't changed them, so maybe the restriction on attributes was less intentional? @NTaylorMullen?

So the intention was for all completions (including attributes) but this was under the impression that HTML similarly would not return completions in "middle of word" for attributes. Given that seems to not be true this falls in line with what we'd want.

Thanks for the reviews and comments. Gonna merge it, but happy to follow up if more issues are found. I'm sure you're all better at finding them than me :)


Use walker

filepath.Walk is bits slow since it call os.Stat for each files. This pull-request use github.com/saracen/walker instead.
$ ghq list | wc -l
2838

Before
real    3.537
system  2.652
user    0.608

After
real    1.054
system  2.043
user    0.374

Hmm, I changed behavior for permission error while walking directories. saracen/walker stop walking when non-permitted directory found. If you are okay, please merge this.

Hmm, unfortunately when this is merged, the issue #173 will recur.
I also want to solve the issue #187, so I can't merge this.

How about copying codes of fastwalk ?

That's a good idea, but before that, we should make a suggestion to saracen/walker that it can do handle unpermitted files.
Also, even if we'll use fastwalk, it's not a good idea to have source code in this repository, but it is better you fork it and utilize it in it.


Defense against hacks

###User story
As a [driver], I want to be able to defend myself in a takeover attempt (both challenger and defender) in a 1-on-1 mini-game, so that the hacking does not feel too easy.
Alternative idea
Make the hacking attempt challenging for the attacker. For example the attacker has to be close to the victim for a certain amount of time, the attacked player has to escape using driving maneuvers.

to be defined how this should be implemented according to #67


Support for GtkCssProvider

I couldn't find any mention around here and I think this would be a useful component to implement for making more complete looking applications.
https://developer.gnome.org/gtk3/stable/GtkCssProvider.html
Are there plans to support this feature?

go-gtk is binding of gtk2 not gtk3

Sorry for the confusion


Bump assorted dependencies

Changes
As per title, this bumps a few assorted dependencies. I left the Google deps alone, since I have too little context on those.
/assign @n3wscott

/lgtm
/approve


 U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 11s
master passed

+0 :ok:
refguide
3m 43s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
the patch passed

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 37s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

18m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3048

Optional Tests
dupname asflicense shellcheck shelldocs refguide

uname
Linux f7c757822cc3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 876fec1648

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
66 (vs. ulimit of 30000)

modules
C: . U: .

 U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 56s
master passed

+0 :ok:
refguide
3m 57s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
the patch passed

-0 :warning:
shellcheck
0m  1s
The patch generated 8 new + 23 unchanged - 15 fixed = 31 total (was 38)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m  1s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

21m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3048

Optional Tests
dupname asflicense shellcheck shelldocs refguide

uname
Linux 115579193aa2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / aeec8ca64b

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/2/artifact/yetus-general-check/output/branch-site/book.html

shellcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
65 (vs. ulimit of 30000)

modules
C: . U: .

 U: .

 U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
master passed

+0 :ok:
refguide
3m 42s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 51s
the patch passed

-0 :warning:
shellcheck
0m  1s
The patch generated 10 new + 21 unchanged - 17 fixed = 31 total (was 38)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
3m 46s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

19m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3048

Optional Tests
dupname asflicense shellcheck shelldocs refguide

uname
Linux eb68fe62b697 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8337fb2a72

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/artifact/yetus-general-check/output/branch-site/book.html

shellcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/artifact/yetus-general-check/output/diff-patch-shellcheck.txt

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
65 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/3/console

versions
git=2.17.1 maven=3.6.3 shellcheck=0.4.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3048 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3048

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3048 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3048

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3048 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3048

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3048/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@javierluca  Thank you for taking a look.
Looks like the stripServer needs to handle 'localhost'. Let me make an addendum....

Or, let me just revert this and commit your patch; it works for you.

@saintstack In my opinion, your change was better because we could use "localhost" as argument, and that will work very well with regionservers.sh which will bypass the ssh section that does not work well with secured clusters:
https://github.com/apache/hbase/blob/59ec375d679dcbf1701a92d4206ecc676a8fb069/bin/regionservers.sh#L61-L64
Just needed to address the stripServer issue.
May be something like this will do it?
unload_hostname="$hostname"
if [[ "$hostname" == "localhost" ]]; then
  unload_hostname=`/bin/hostname -f`
fi
unload_args="--filename $filename --maxthreads $maxthreads $noack --operation unload \
--timeout $movetimeout --regionserverhost $unload_hostname"

If you don't mind, I would like to submit a patch including the changes of this PR + above fix for the RegionMover.

@saintstack addressing it at https://github.com/apache/hbase/pull/3053. Please have a look 🙇


Powertoys Run: Something went wrong.

Microsoft PowerToys version
0.67.1
Installation method
Other (please specify in "Steps to Reproduce")
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
trying to launch powertoys run with Win+Space
Installation method: No idea right now how exactly I installed powertoys. Probably downloaded via GitHub?
✔ Expected Behavior
powertoys run should work as expected and show the search bar and let me launch applications.
❌ Actual Behavior
error window popped up, instructing me to file a bug report and add the log file:
2023-03-02.txt
error message:
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22621.0
IntPtr Length: 8
x64: True
Date: 02/03/2023 15:39:26
Exception:
System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Other Software
No response

/dup #18166
Can you please add some notes there in case you suspect there's a reason why the case seems different to you? Did it happen only once or does it happen consistently?

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


feat: Local Development Environment Support for Apple Silicon

Purpose of PR?:
Local dev environment support for apple silicon
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
I set up a local development environment on my M1 Pro Mac. I encountered some problems along the way, but I was able to resolve them. I have attached screenshots for your reference.
Additional information for reviewer? :
I have not been able to test my changes on a linux amd64 machine, so I cannot be sure whether they have broken the existing development environment. Please could you check this for me?

Checklist:

[ ] Bug fix. Fixes #
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@nyrahul kindly review this PR.


rolling with custom function

I tried to apply my custom function on koalas rolling
but it could not be applied.
The method pandas.core.window.Rolling.apply() is not implemented yet.
or
Is there any difference between koalas and pandas?

Yeah, Koalas doesn't support RollingGroupby.apply() yet.

when can i use??  should i use dask instead?


On force_ascii and support for Unicode characters

The force_ascii option is useful, reportedly, to Force ASCII characters for plotting only. This can be useful for compatibility, for example when using uniplot inside of CI/CD systems that do not support Unicode. Defaults to False.

Finally, and however, I got to access a docker image where I can update locales, etc. I am trying to install some fonts and set LC_ALL etc., but I still cannot get the output appear as expected. See also  : https://github.com/pawamoy/markdown-exec/discussions/45#discussioncomment-9217987. What can I do to ensure uniplot/s are rendered correctly ?

Hi @NikosAlexandris could you post an example of the uniplot function you are calling, and the output you are seeing?
With force_ascii=True and perhaps color=False you should not have any problems, but I'd be curious to see your case

Hi @NikosAlexandris could you post an example of the uniplot function you are calling, and the output you are seeing?
With force_ascii=True and perhaps color=False you should not have any problems, but I'd be curious to see your case

Thank you for the reply. Struggling here to understand how I should set up the CI/CD environment to make things looks okay. Locally, I see no problems. "Remotely" I see things (exactly actually) like in this page : https://nikosalexandris.github.io/rekx/how_to/help/#help (see end of code block rekx --help).
I have even set now both locally and for CI/CD build (not the rekx example above, but another project)
theme:
  font: false

in mkdocs.yml.
For Uniplot/s, I use something like
    import shutil
    from functools import partial
    from uniplot import plot as default_plot

    terminal_columns, _ = shutil.get_terminal_size()  # we don't need lines!
    terminal_length = int(terminal_columns * terminal_width_fraction)
    plot = partial(default_plot, width=terminal_length)

then using this somewhere
# some code
        plot(
            # xs=timestamps,
            ys=y_series,
            legend_labels=legend_labels,
            lines=lines,
            title=title if title else supertitle,
            y_unit=' ' + str(unit),
            # force_ascii=True,
        )

to renders plots fine locally (with or without explicitly export FORCE_COLOR=1)

but not when the documentation is build through the CI/CD image

It does look like a font issue. Could you try 2 things:

Use force_ascii=True, then the output should display identically. Though of course you loose the Unicode-powered high resolution.
Use color=False and see what you get.

Thanks!

It does look like a font issue. Could you try 2 things:
1. Use `force_ascii=True`, then the output should display identically. Though of course you loose the Unicode-powered high resolution.

2. Use `color=False` and see what you get.

Thanks!

@olavolav This is about uniplot and color=False, and not about the problem I am trying to resolve.
While testing locally, I get

Maybe the "legend" slips away the color=False option ?

@NikosAlexandris Thanks for pointing this out! Indeed, that's not correct behavior, have opened #33 to track that. I have a fix locally already.

@NikosAlexandris Now that #33 is closed, can we close this ticket here as well?

@NikosAlexandris Closing this for now, let me now if there is anything else you need.

Thank you, it works.

Multiple all-white series are then not easy (or possible) to differentiate.  Adding force_ascii=True does the following

The combination of color=False and multiple series should maybe force force_ascii=True ?


zsh: Depends on ncurses for Linuxbrew

zsh depends on ncurses.
configure: error: in `/home/bob/tmp/zsh20160324-12221-1iabe4a/zsh-5.2':
configure: error: "No terminal handling library was found on your system.
This is probably a library called 'curses' or 'ncurses'.  You may
need to install a package called 'curses-devel' or 'ncurses-devel' on your
system."
See `config.log' for more details

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you included a log of the failed build without your patch using brew gist-logs <formula>?
[ ] Does your submission pass
brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
[x] Have you built your formula locally prior to submission with brew install <formula>?

There are unresolved issues building ncurses on my machine at the moment; I'm going to leave this PR open until those are resolved.
Similarly, zsh doesn't pass a strict audit, but that should be fixed upstream.

Another zsh error from LinuxbrewTestBot:
** Cannot --enable-pcregrep-libz because zlib.h was not found

Ach, that's totally my fault for not giving enough log context. Sorry, Bob.
It was pcre that failed to build, not zlib. So you can remove the zlib dependency from here, and add it to pcre.
** Cannot --enable-pcregrep-libz because zlib.h was not found
==> Formula
Path: /home/linuxbrew/.linuxbrew/Library/Formula/pcre.rb


selenium.commmon.exceptions.WebDriverException: Message: tab crashed

When I run these code on ec2 instance, selenium crashes with tab crashed message.
Exception in thread Thread-1 (scrape):
Traceback (most recent call last):
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/threading.py", line 946, in run
    self._target(*self._args, **self._kwargs)
  File "/home/ec2-user/airline-ops/airline_operation_watcher/data_collector/data_collector_caller.py", line 30, in scrape
    collector = class_()
  File "/home/ec2-user/airline-ops/airline_operation_watcher/data_collector/data_collector.py", line 93, in __init__
    super().__init__()
  File "/home/ec2-user/airline-ops/airline_operation_watcher/data_collector/data_collector.py", line 31, in __init__
    self.browser = webdriver.Chrome()
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/chrome/webdriver.py", line 45, in __init__
    super().__init__(
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/chromium/webdriver.py", line 61, in __init__
    super().__init__(command_executor=executor, options=options)
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 209, in __init__
    self.start_session(capabilities)
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 293, in start_session
    response = self.execute(Command.NEW_SESSION, caps)["value"]
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py", line 348, in execute
    self.error_handler.check_response(response)
  File "/home/ec2-user/.pyenv/versions/3.10.4/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py", line 229, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: tab crashed

I don't know why detail, but when I changed the part i use thread, this issue was fixed.
see 186a4d848a838384560b65b203f16cb20a4944fd for detail.


Update Invite to new vanity one

Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[ ] Internal code
[ ] Library interface (affecting end-user code)
[ ] Documentation
[x] Other: README.md change

Closes Issue: NaN
Description
Since the JDA discord is now verified and has a vanity URL would it be the best to update the one on the readme, no?

We want to keep the current invite.

We don't want to upgrade the invite link because it is unclear if it will break at some point in the future.


fix(deps): downgrade semantic release github plugin

This could be the cause of failed releases lately.

:tada: This issue has been resolved in version 1.11.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Choose UUID + Wrap/Unwrap Signaling Data

Added generic wrapping and unwrapping functions and the ability to manually set the UUID.
Together that can be used to implement a whitelist and/or encryption of the signaling data.
After playing around a while mainly trying to authenticate peers and encrypt signaling data this seems to be the most generic but still workable implementation.
New options at one glance:
opts = {
  uuid: 'string',
  wrap: function (data, channel),
  unwrap: function (data, channel)  // if return value falsy: data gets dropped
}

There is no debug message when unwrap fails. I thought that message can/should be thrown by the unwrap function itself.
All changes are backward compatible.

2.3.0 - happy new year :tada:

2.3.0 - happy new year :tada:

Happy new year  :tada:

Happy new year  :tada:


Tag most of the the Browser Upload tests as AWSv2 specific.

Altough most of the Browser Upload tests are truly specific to AWSv2, they were being executed also in AWSv4 runs causing many false-positives. The patch tag them appropriately and prevents from being executed when S3_USE_SIGV4=1 is specified.
Signed-off-by: Radoslaw Zarzynski<EMAIL_ADDRESS>

@rzarzynski I think we're mixing here two different issues. We should be able to do browser upload in conjuction with aws4. Preferably these should be the same tests doing it. So I think the correct fix for these specific tests that fail would be to adapt the tests to support both aws2 and aws4, and not limit these to aws2.

@rzarzynski that been said, there probably are tests that we want to limit to aws2, and your cleanup looks good,.

We should be able to do browser upload in conjuction with aws4.

Fully agreed. We really need to have such tests also for AWSv4.

Preferably these should be the same tests doing it.

Personally I perceive this as a detail. We could cover both v2 and v4 in a single test (with internal branch) or, alternatively, have two different tests named appropriately (e.g. test_post_object_authenticated_request_bad_access_key_aws2 and test_post_object_authenticated_request_bad_access_key_aws4). The first approach looks compliant with DRY principle.

I think the correct fix for these specific tests that fail would be to adapt the tests to support both aws2 and aws4, and not limit these to aws2.

Absolutely. Skipping these tests is only a makeshift solution to be more explicit. Currently, they are named in a way that doesn't reflect that only AWSv2 is verified.

@rzarzynski I'm afraid that if we're going to skip these tests now, we'll never get to fix the tests.

@yehudasa: yeah, that's possible, unfortunately. Looks like we need to judge what's the lesser evil for now. :-(
I can take fixing them but, preferably, would finish the Keystone/Tempest integration stuff first.


ESLint Rules addition to the readme

Since this has now worked stable for quite some time without any complaints, I think it can be safely added to the readme.
Resolves #56

Codecov Report

Merging #535 (2242d52) into master (c01dc14) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 2242d52 differs from pull request most recent head def7598. Consider uploading reports for the commit def7598 to get more accurate results

@@            Coverage Diff            @@
##            master      #535   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            8         8
  Branches         1         1
=========================================
  Hits             8         8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01dc14...def7598. Read the comment docs.


Filter by status in report

Trello card
User need
As a content auditor
I need filter the audit progress tab and csv export by audit status
So that I can efficiently prioritise audited items for improvement
Background
This has been requested by HMRC. At present they can filter the audit
progress report (and therefore the csv export) by Assigned to, Organisation(s),
Content Type.
This PR will allow them to download the CSV that represent the status
of the filter including the Audit Status.

 (3) Filter the export by audit status

@alecgibson, thank you for your review; I have addressed your comments.


qt: Fix Repair tab

It was broken by https://github.com/dashpay/dash/pull/4586/commits/7b8ddda8ea784f764e8790a27d7133251aec3ac5. To reproduce the issue: open testnet wallet (via --testnet in cmd line), open Repair tab, click "Upgrade wallet" (the less harmful one) - wallet restarts with -upgradewallet but no --testnet so it's a mainnet wallet now.

Ahah, this probably explains why my attempt to reindex a devnet recently resulted in a mainnet reindex :man_facepalming:


feedback on this page not working as intended

Prerequisites

[X] Write a descriptive title.
[X] Search the existing issues.
[X] I am reporting the documentation problem for the current version of Azure CLI.

Azure CLI version being used
2.37
Link to affected document
https://github.com/MicrosoftDocs/azure-docs-cli/issues
Description of the documentation error
when reporting a doc issue:

it is not doing it's normal thing:

that breaks features like this:

https://github.com/MicrosoftDocs/azure-docs-cli/issues?utf8=✓&q="a21e188b-4ff4-0aca-531b-d4b179665be1"&in=body
Suggested fix
no clue

@spottedmahn Thanks for your feedback. We will investigate and update the thread.

spottedmahn,  Thanks for providing feedback that helps improve our documentation.  This issue has been corrected.


openurl method not jumping back to app

Everything in the plugin is working for me except the part where the share extension plugin is supposed to jump back to my app to show the share dialogue.  If i manually go back to the app, the data is waiting for me there...so the openurl method in ShareViewController.m isnt working.  After a bunch of research it looks like apple doesnt want this to happen.  Is there a way this can be modded to include some basic UI functionality without having to jump back to the app?  Not sure what the best option for that is...Any help would be great!

@tbassett44 have you found a solution for this?

Make sure there is a URL Types entry. Enter the custom URL Schemes you set when installing the plugin.


Docs: "Getting started" doesn't show you how to get started

The getting started section is really just a light overview of the syntax. It doesn't actually show you how to import the module or other crucial stuff for getting started.

PRs welcome! (also let's move this to the website repo?)

I've opened an issue regarding this already: https://github.com/styled-components/styled-components-website/issues/60
So maybe you're open to contribute to it there? :)


safeeyes: 2.1.9 -> 2.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for safeeyes is: Protect your eyes from eye strain using this simple and beautiful, yet extensible break reminder. A Free and Open Source Linux alternative to EyeLeo
meta.homepage for safeeyes is: http://slgobinath.github.io/SafeEyes
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.2.1 with grep in /nix/store/d11d5r80yhlycmdm1vnb4a424dp52c38-safeeyes-2.2.1
found 2.2.1 in filename of file in /nix/store/d11d5r80yhlycmdm1vnb4a424dp52c38-safeeyes-2.2.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

safeeyes

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/d11d5r80yhlycmdm1vnb4a424dp52c38-safeeyes-2.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A safeeyes https://github.com/r-ryantm/nixpkgs/archive/25f50c34549907724d60de0b68f42743d2026fb3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/25f50c34549907724d60de0b68f42743d2026fb3#safeeyes

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/d11d5r80yhlycmdm1vnb4a424dp52c38-safeeyes-2.2.1
ls -la /nix/store/d11d5r80yhlycmdm1vnb4a424dp52c38-safeeyes-2.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

safeeyes
safeeyes.dist

Maintainer pings
cc @srghma for testing.

Missing dependencies. Needs a manual upgrade.

Thank you @DamienCassou


[Bug] "Cannot read property 'substring' of undefined" when launching workspace

Describe the bug
When starting a workspace, the workspace fails to create with the error "Cannot read property 'substring' of undefined".
To Reproduce
Steps to reproduce the behavior:

Go to Workspaces
Click on Create Research Workspace
Select a Compute option, eg. EC2 Linux-v1
Enter a name, choose a project and configuration, and enter a description
Click Create Research Workspace
Wait 2-3 minutes for the workspace to switch from Pending to Failed, with the above error

Expected behavior
Expected the workspace to launch, or - for a more specific or detailed error to be returned.
Screenshots

Versions:

5.0.0

Additional context
This is on a fresh install of Service Workbench 5.0.0, however I did add a new version (provisioning artifact) to the relevant Service Catalog product, with a modified volume size (as suggested at https://github.com/awslabs/service-workbench-on-aws/issues/866#issuecomment-1024572890). Launches are failing to work however with both the new and old template - they seem to not be making it to Service Catalog, or CloudFormation, at all.
It's difficult to track down where in the source this error is coming from, but I was able to find 12 places (outside of tests) that use substring:
https://github.com/awslabs/service-workbench-on-aws/blob/35f6cce3ccc301921ead742240c15c1a7e332f0c/addons/addon-base-raas/packages/base-raas-services/lib/helpers/s3-arn.js#L44 https://github.com/awslabs/service-workbench-on-aws/blob/546da18968fe2b802d418278a09bc9b153c235e1/addons/addon-base/packages/services/lib/s3-service.js#L116 https://github.com/awslabs/service-workbench-on-aws/blob/546da18968fe2b802d418278a09bc9b153c235e1/addons/addon-base-raas/packages/base-raas-services/lib/helpers/utils.js#L35 https://github.com/awslabs/service-workbench-on-aws/blob/35f6cce3ccc301921ead742240c15c1a7e332f0c/addons/addon-base-workflow/packages/workflow-engine/lib/helpers/utils.js#L28 https://github.com/awslabs/service-workbench-on-aws/blob/2b285b724cbdb3c361232b932b524dae8ba53d60/addons/addon-base-ui/packages/base-ui/src/helpers/utils.js#L191 https://github.com/awslabs/service-workbench-on-aws/blob/33a4346f34c79c1bce2ea57d445efd78b65fe705/addons/addon-base-raas/packages/base-raas-services/lib/environment/environment-mount-service.js#L678 https://github.com/awslabs/service-workbench-on-aws/blob/33b53da9a2793b5823bc979301468500d4f01289/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js#L319 https://github.com/awslabs/service-workbench-on-aws/blob/33b53da9a2793b5823bc979301468500d4f01289/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/terminate-launch-dependency/terminate-launch-dependency.js#L433 https://github.com/awslabs/service-workbench-on-aws/blob/1999b269b8113a621a5b693802bf5d1bb406c983/addons/addon-base-raas/packages/base-raas-services/lib/user/user-service.js#L279 https://github.com/awslabs/service-workbench-on-aws/blob/35f6cce3ccc301921ead742240c15c1a7e332f0c/addons/addon-base/packages/services/lib/helpers/utils.js#L26 https://github.com/awslabs/service-workbench-on-aws/blob/35f6cce3ccc301921ead742240c15c1a7e332f0c/addons/addon-base-workflow-ui/packages/base-workflow-ui/src/models/workflows/Workflow.js#L147 https://github.com/awslabs/service-workbench-on-aws/blob/3b04636c94effa4ead0747d118efaa930b93bc4b/addons/addon-base-raas/packages/base-raas-services/lib/environment/service-catalog/environment-sc-service.js#L573

Ah - I realised how I can track it down, at least. It appears to be coming from this line:
https://github.com/awslabs/service-workbench-on-aws/blob/33b53da9a2793b5823bc979301468500d4f01289/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js#L319
based on this fail state in the ...-workflow Step Function:
      "error": {
        "stpIndex": 4,
        "stpTmplId": "st-check-launch-dependency",
        "stpTmplVer": 1,
        "wfInstId": "7X8PNwK0PDuu2_1ZTe7JM",
        "wfId": "wf-provision-environment-sc",
        "wfVer": 1,
        "msg": "Cannot read property 'substring' of undefined",
        "stack": "TypeError: Cannot read property 'substring' of undefined\n    at CheckLaunchDependency.parseS3DetailsfromUrl (/var/task/src/lambdas/workflow-loop-runner/webpack:/home/ec2-user/service-workbench-v5.0.0/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/check-launch-depend"
      }

So it looks like this might be caused by some assumptions made in this regex:
https://github.com/awslabs/service-workbench-on-aws/blob/33b53da9a2793b5823bc979301468500d4f01289/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js#L310
in particular, that the S3 template URL is always going to follow that exact pattern. However, there are multiple patterns it could follow - at least https://s3.amazonaws.com/bucket-name/path/to/key.yaml and https://bucket-name.s3.amazonaws.com/path/to/key.yaml.

Hi @tdmalone ! Thank you for reaching out and providing so many details about this bug. Would you be able to share the templateUrl that is being passed to this method that is causing it to fail? I have not been able to reproduce the error, but believe that the custom SC provisioning artifact is what is leading to this error. The templateUrl is being queried from the SC Client in
https://github.com/awslabs/service-workbench-on-aws/blob/33b53da9a2793b5823bc979301468500d4f01289/addons/addon-environment-sc-api/packages/environment-sc-workflow-steps/lib/steps/check-launch-dependency/check-launch-dependency.js#L265-L276
You can check what the method above is returning by using the aws cli and running this command after configuring your .aws/config and .aws/credentials files for a certain profile (or default if you only have one profile in each file). Replace the elements in <> with your values. If you are using your default profile, the --profile param is not required:
aws servicecatalog describe-provisioning-artifact --provisioning-artifact-id pa-<id> --product-id prod-<id> --profile <profilename>

My response looks like this:
{
    "ProvisioningArtifactDetail": {
        "Id": "pa-<id>",
        "Name": "v3",
        "Description": "* An EC2 Linux instance with SSH access \n* Secure compute in the cloud",
        "Type": "CLOUD_FORMATION_TEMPLATE",
        "CreatedTime":<PHONE_NUMBER>.0,
        "Active": true,
        "Guidance": "DEFAULT"
    },
    "Info": {
        "TemplateUrl": "https://<account-id>-<stage>-<region-short-name>-<solution-namespace>-artifacts.s3.amazonaws.com/service-catalog-products/ec2-linux-instance.cfn.yml"
    },
    "Status": "AVAILABLE"
}

Your input will help me debug if our check in the method you linked above is correct or not. Thank you!

@tdmalone I think you're right, with your root cause. I think the issue is the expected S3 URL format.
I tested the following code and was able to reproduce the error.
const url = require('url');
// const stuff = ['a', 'b', 'c'];
//
// for (letter of stuff) {
//     if (letter === 'b') {
//         continue;
//     }
//     console.log(letter);
// }

function parseS3DetailsfromUrl(templateUrl) {
    const ENDPOINT_PATTERN = /^(.+\.)?s3[.-]([a-z0-9-]+)\./;
    const uri = url.parse(templateUrl);
    const matches = uri.host.match(ENDPOINT_PATTERN);
    if (!matches) {
        throw new Error(`Invalid S3 URL: ${templateUrl}`);
    }
    const prefix = matches[1];
    // remove last . from prefix
    const bucketName = prefix.substring(0, prefix.length - 1);
    const key = uri.pathname.substring(1);
    return { bucketName, key };
}
const workingS3Url = "https://0123456789012-dev-va-swb-artifacts.s3.amazonaws.com/service-catalog-products/ec2-linux-instance.cfn.yml"
// const s3UrlThatResultInError = "https://s3.amazonaws.com/0123456789012-dev-va-swb-artifacts/service-catalog-products/ec2-linux-instance.cfn.v2.yml"

console.log(parseS3DetailsfromUrl(workingS3Url));

I'm curious as to why your S3 url is different from the expected format. When I tested my deployment, my url was also in the expected format "https://<account-id>-<stage>-<region-short-name>-<solution-namespace>-artifacts.s3.amazonaws.com/service-catalog-products/ec2-linux-instance.cfn.yml".
Did you add any custom setup to your SWB deployment?

Did you add any custom setup to your SWB deployment?

I did, yes - see the 'additional context' section in my original report above.


Repair Sonar build and address some issues remaining from #130

Extend the scope of this issue to include refactoring of all builds. It's straightforward enough. I'll remove some config stuff and use static PNG configs and then make the lib-structures more similar to how the original JPEG stuff was set up. Take another day or so.
Cc: @S-Streulicht


QG4: TRG 7.02 - License and Copyright header

Hi @evegufy, issue related to Copyright headers for certain files, below result of the check:
Testing Quality Guideline: TRG 7.02 - License and Copyright header

Failed! Guideline description: Where possible, all source code should contain appropriate copyright and license notices as well as information on each contribution.

Can't find copyright headers at:

.tractusx
<EMAIL_ADDRESS><EMAIL_ADDRESS>src/components/overlays/IDPDelete/idpdelete.scss
src/components/overlays/IDPDelete/index.tsx
src/components/overlays/IDPStatusChange/index.tsx
src/components/overlays/IDPTestRun/index.tsx
src/components/overlays/IDPTestRun/style.scss
src/components/overlays/UpdateCompanyRole/style.scss
src/components/pages/Home/components/StageSection/stage-section.scss
src/components/pages/UserManagement/StageSection/stage-section.scss
src/components/shared/basic/CertificateCard/style.scss
src/components/shared/basic/ReleaseProcess/components/ComponentStyles.scss
src/components/shared/basic/UserRoles/UserRole.scss
src/utils/downloadUtils.ts

More infos: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-02

License and Copyright header were added.


Fix multi-threaded use of HttpUrlConnection

fixes elastic/apm-agent-java#467

Does it fix the Tomcat 7 IT?

Does it fix the Tomcat 7 IT?
No, I don't think so. The Tomcat test failure was related to the Executor instrumentation.


Add draft

https://github.com/aquaproj/aqua-registry/issues/858
https://github.com/kristoflemmens/asdf-draft
https://github.com/Azure/draft

Added https://github.com/aquaproj/aqua-registry/pull/7290


Button for close all plots/images

Description of your problem
I am using spyder for scientific simulation. As a result I need to plot many data at the end of the simulations.
Can you provide an option or shortcut to close all the figures. It would be easy to close 10-15 figure at one shot.

To close all figures you need to run
import matplotlib.pyplot as plt
plt.close('all')

You can also get this behavior if you execute your code in a dedicated console. You can do that by giving focus to the file you want to run in the Editor, then going to the menu
Run > Configuration per file

and activating the option called
Execute in a dedicated console

Ok. Thank you.

I tried this solution you metioned ccordoba12, but this is just a workaround in my opinion. Isn't there a function built in as in MATLAB "clear all", which deletes every figure at the beginning of the code execution?


Need better documentation on libspdm_encode_secured_message()

libspdm_encode_secured_message() will modify the input app_message buffer before and after.
Need better documentation on that.
        enc_msg_header =
            (void *)((uint8_t *)app_message - sizeof(spdm_secured_message_cipher_header_t));
...
        result = libspdm_get_random_number(rand_count,
                                           (uint8_t *)enc_msg_header +
                                           sizeof(spdm_secured_message_cipher_header_t) +
                                           app_message_size);

Since we redesign IO function, we may need document all assumptions for those APIs.


Provision PHP 8.2

Is there a prevision to enable PHP 8.2  on provision?

set('php_version', ‘8.2’);

I've tried, but failed.

Reading package lists... Building dependency tree... Reading state information... E: Unable to locate package php8.2-bcmath E: Couldn't find any package by glob 'php8.2-bcmath' E: Couldn't find any package by regex 'php8.2-bcmath' E: Unable to locate package php8.2-cli E: Couldn't find any package by glob 'php8.2-cli' E: Couldn't find any package by regex 'php8.2-cli' E: Unable to locate package php8.2-curl E: Couldn't find any package by glob 'php8.2-curl' E: Couldn't find any package by regex 'php8.2-curl' E: Unable to locate package php8.2-dev E: Couldn't find any package by glob 'php8.2-dev' E: Couldn't find any package by regex 'php8.2-dev' E: Unable to locate package php8.2-fpm E: Couldn't find any package by glob 'php8.2-fpm' E: Couldn't find any package by regex 'php8.2-fpm' E: Unable to locate package php8.2-gd E: Couldn't find any package by glob 'php8.2-gd' E: Couldn't find any package by regex 'php8.2-gd' E: Unable to locate package php8.2-imap E: Couldn't find any package by glob 'php8.2-imap' E: Couldn't find any package by regex 'php8.2-imap' E: Unable to locate package php8.2-intl E: Couldn't find any package by glob 'php8.2-intl' E: Couldn't find any package by regex 'php8.2-intl' E: Unable to locate package php8.2-mbstring E: Couldn't find any package by glob 'php8.2-mbstring' E: Couldn't find any package by regex 'php8.2-mbstring' E: Unable to locate package php8.2-mysql E: Couldn't find any package by glob 'php8.2-mysql' E: Couldn't find any package by regex 'php8.2-mysql' E: Unable to locate package php8.2-pgsql E: Couldn't find any package by glob 'php8.2-pgsql' E: Couldn't find any package by regex 'php8.2-pgsql' E: Unable to locate package php8.2-readline E: Couldn't find any package by glob 'php8.2-readline' E: Couldn't find any package by regex 'php8.2-readline' E: Unable to locate package php8.2-soap E: Couldn't find any package by glob 'php8.2-soap' E: Couldn't find any package by regex 'php8.2-soap' E: Unable to locate package php8.2-sqlite3 E: Couldn't find any package by glob 'php8.2-sqlite3' E: Couldn't find any package by regex 'php8.2-sqlite3' E: Unable to locate package php8.2-xml E: Couldn't find any package by glob 'php8.2-xml' E: Couldn't find any package by regex 'php8.2-xml' E: Unable to locate package php8.2-zip E: Couldn't find any package by glob 'php8.2-zip' E: Couldn't find any package by regex 'php8.2-zip'

Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package php8.2-bcmath
E:
Couldn't find any package by glob 'php8.2-bcmath'
E: Couldn't find any package by regex 'php8.2-bcmath'
E: Unable to locate package php8.2-cli
E: Couldn't find any package by glob 'php8.2-cli'
E: Couldn't find any package by regex 'php8.2-cli'
E: Unable to locate package php8.2-curl
E: Couldn't find any package by glob 'php8.2-curl'
E: Couldn't find any package by regex 'php8.2-curl'
E: Unable to locate package php8.2-dev
E: Couldn't find any package by glob 'php8.2-dev'
E: Couldn't find any package by regex 'php8.2-dev'
E: Unable to locate package php8.2-fpm
E: Couldn't find any package by glob 'php8.2-fpm'
E: Couldn't find any package by regex 'php8.2-fpm'
E: Unable to locate package php8.2-gd
E: Couldn't find any package by glob 'php8.2-gd'
E: Couldn't find any package by regex 'php8.2-gd'
E: Unable to locate package php8.2-imap
E: Couldn't find any package by glob 'php8.2-imap'
E: Couldn't find any package by regex 'php8.2-imap'
E: Unable to locate package php8.2-intl
E: Couldn't find any package by glob 'php8.2-intl'
E: Couldn't find any package by regex 'php8.2-intl'
E: Unable to locate package php8.2-mbstring
E: Couldn't find any package by glob 'php8.2-mbstring'
E: Couldn't find any package by regex 'php8.2-mbstring'
E: Unable to locate package php8.2-mysql
E: Couldn't find any package by glob 'php8.2-mysql'
E: Couldn't find any package by regex 'php8.2-mysql'
E: Unable to locate package php8.2-pgsql
E: Couldn't find any package by glob 'php8.2-pgsql'
E: Couldn't find any package by regex 'php8.2-pgsql'
E: Unable to locate package php8.2-readline
E: Couldn't find any package by glob 'php8.2-readline'
E: Couldn't find any package by regex 'php8.2-readline'
E: Unable to locate package php8.2-soap
E: Couldn't find any package by glob 'php8.2-soap'
E: Couldn't find any package by regex 'php8.2-soap'
E: Unable to locate package php8.2-sqlite3
E: Couldn't find any package by glob 'php8.2-sqlite3'
E: Couldn't find any package by regex 'php8.2-sqlite3'
E: Unable to locate package php8.2-xml
E: Couldn't find any package by glob 'php8.2-xml'
E: Couldn't find any package by regex 'php8.2-xml'
E: Unable to locate package php8.2-zip
E: Couldn't find any package by glob 'php8.2-zip'
E: Couldn't find any package by regex 'php8.2-zip'

I've found the problem, 8.2 it's not running on Ubuntu 22.04

Thanks @antonmedv


[BUG] error after build

🐛 Bug Report

Lib version: ^4.2.0
react: ^16.13.1
In dev env, everything is ok. In prod env, it throw an error.
react-dom.production.min.js:5058
TypeError: Super expression must either be null or a function
at exceljs.min.js:19876
at exceljs.min.js:19875
at Object.e.exports.119.../../utils/xml-stream (exceljs.min.js:19874)
at a (exceljs.min.js:23)
at exceljs.min.js:24
at Object.e.exports.134.../../../doc/enums (exceljs.min.js:22566)
at a (exceljs.min.js:23)
at exceljs.min.js:24
at Object. (exceljs.min.js:24001)
at Object.e.exports.141.../utils/browser-buffer-decode (exceljs.min.js:25136)
similar issue #1342

Seeing this as well with "react": "^16.6.3" and "exceljs": "^4.2.0".

@lph666 for what it's worth, we encountered this too. We were able to get around it by importing directly from "exceljs/dist/exceljs". We use typescript, and we were able to keep our type declarations intact by defining our own types.d.ts file with the classes we needed. Hopefully that helps!

@lph666 for what it's worth, we encountered this too. We were able to get around it by importing directly from "exceljs/dist/exceljs". We use typescript, and we were able to keep our type declarations intact by defining our own types.d.ts file with the classes we needed. Hopefully that helps!

Thanks you, after these two steps, it works in prod env.

@lph666 for what it's worth, we encountered this too. We were able to get around it by importing directly from "exceljs/dist/exceljs". We use typescript, and we were able to keep our type declarations intact by defining our own types.d.ts file with the classes we needed. Hopefully that helps!

Thanks you so muchhhhh.

I've troubled with this too.
Temporarily it is solved by changing the path of it, but it is not good to see... :)
I hope it to fix ASAP~!
for Korean who is like me,
일단 경로를 바꿔서 import {..} from 'exceljs/dist/exceljs'로 해서 빌드하면 해결은됩니다~~

I've troubled with this too.
Temporarily it is solved by changing the path of it, but it is not good to see... :)
I hope it to fix ASAP~!
for Korean who is like me,
일단 경로를 바꿔서 import {..} from 'exceljs/dist/exceljs'로 해서 빌드하면 해결은됩니다~~

@alubbe would you be open to reopening this issue? We ran into the same issue in prod env as well, this issue should be reopened IMO since it is not fixed. Our team could help update the docs at least so others can find this issue faster.

Hope the authorities fix it.

Also faced this issue on Angular prod build. Turning "optimization: false" in angular.json seems to have fixed it. Also somewhere seen that removing Uglify plugin for React also helped.

My solution：
Project tech stack: React + TypeScript
Add an exceljs.d.ts file in directory where the file import exceljs, the exceljs.d.ts file content is
declare module 'exceljs/dist/exceljs';

in the file which import exceljs, code is:
import ExcelJS from 'exceljs/dist/exceljs';

these above save my build problem

일단 경로를 바꿔서 import {..} from 'exceljs/dist/exceljs'로 해서 빌드하면 해결은됩니다~~

we are not using Typescript.  In this case, wHere do we need to change the path ?

Experience that as well
on dev everything ok.
on prod build got: "Super expression must either be null or a function"
Changing:
const Excel = require("exceljs");
to
const Excel = require("exceljs/dist/exceljs");
Solved it

Have the same problem.
When the import is switched from exceljs to exceljs/dist/exceljs the problem disappears.
Looking forward to resolution.

My solution：
Project tech stack: React 16.12.0 + TypeScript 3.8.3 + exceljs4.2.1
Add an exceljs.d.ts file in directory where the file import exceljs, the exceljs.d.ts file content is
declare module 'exceljs/dist/exceljs';

in the file which import exceljs, code is:
import ExcelJS from 'exceljs/dist/exceljs';

these above steps save my build problem

Excelent. Thanks 🥇


2.6.x Build fails with GCC 12.1.0 (Arch Linux)

2.6.x Build fails with GCC 12.1.0 (Arch Linux)
Building SFML from source (2.6.x branch) fails with GCC 12.1.0.
Environment

Arch Linux, upgraded with sudo pacman -Syu
2.6.x branch
GCC 12.1.0

Steps to reproduce

Upgrade latest packages with sudo pacman -Syu
Install ninja and cmake if necessary
Build with:

git clone -b 2.6.x https://github.com/SFML/SFML.git
cd SFML
mkdir build
cmake -G Ninja -DCMAKE_C_COMPILER=/usr/bin/gcc -DCMAKE_CXX_COMPILER=/usr/bin/g++ -DCMAKE_BUILD_TYPE=Release -S . -B build

# Will fail, but keep going until any possible files are built
cmake --build build -j 8 -- -v -k 0

# Run a second time to see the error in question
cmake --build build -j 8 -- -v -k 0

Expected behavior
It should build.
Actual behavior
It did not build. :(
It fails on src/Network/SFML/Http.cpp:264 with:
/usr/bin/g++ -DSFML_NETWORK_EXPORTS -I/home/username/dev/tmp/SFML/include -I/home/username/dev/tmp/SFML/src -Wno-error -O3 -DNDEBUG -fPIC -fvisibility=hidden  -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wcast-align -Wunused -Woverloaded-virtual -Wconversion -Wsign-conversion -Wdouble-promotion -Wformat=2 -Wnull-dereference -Wold-style-cast -Wpedantic -Werror -Wmisleading-indentation -Wduplicated-cond -Wlogical-op -Wduplicated-branches -MD -MT src/SFML/Network/CMakeFiles/sfml-network.dir/Http.cpp.o -MF src/SFML/Network/CMakeFiles/sfml-network.dir/Http.cpp.o.d -o src/SFML/Network/CMakeFiles/sfml-network.dir/Http.cpp.o -c /home/username/dev/tmp/SFML/src/SFML/Network/Http.cpp
In file included from /usr/include/c++/12.1.0/ios:43,
                 from /usr/include/c++/12.1.0/istream:38,
                 from /home/username/dev/tmp/SFML/include/SFML/Network/IpAddress.hpp:33,
                 from /home/username/dev/tmp/SFML/include/SFML/Network/Http.hpp:32,
                 from /home/username/dev/tmp/SFML/src/SFML/Network/Http.cpp:28:
In member function ‘std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::egptr() const [with _CharT = char; _Traits = std::char_traits<char>]’,
    inlined from ‘std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]’ at /usr/include/c++/12.1.0/streambuf:324:49,
    inlined from ‘std::istreambuf_iterator<_CharT, _Traits> std::istreambuf_iterator<_CharT, _Traits>::operator++(int) [with _CharT = char; _Traits = std::char_traits<char>]’ at /usr/include/c++/12.1.0/bits/streambuf_iterator.h:187:30,
    inlined from ‘void sf::Http::Response::parse(const std::string&)’ at /home/username/dev/tmp/SFML/src/SFML/Network/Http.cpp:264:37:
/usr/include/c++/12.1.0/streambuf:493:30: error: potential null pointer dereference [-Werror=null-dereference]
  493 |       egptr() const { return _M_in_end; }
      |                              ^~~~~~~~~
In member function ‘std::basic_streambuf<_CharT, _Traits>::char_type* std::basic_streambuf<_CharT, _Traits>::gptr() const [with _CharT = char; _Traits = std::char_traits<char>]’,
    inlined from ‘std::basic_streambuf<_CharT, _Traits>::int_type std::basic_streambuf<_CharT, _Traits>::sbumpc() [with _CharT = char; _Traits = std::char_traits<char>]’ at /usr/include/c++/12.1.0/streambuf:324:33,
    inlined from ‘std::istreambuf_iterator<_CharT, _Traits> std::istreambuf_iterator<_CharT, _Traits>::operator++(int) [with _CharT = char; _Traits = std::char_traits<char>]’ at /usr/include/c++/12.1.0/bits/streambuf_iterator.h:187:30,
    inlined from ‘void sf::Http::Response::parse(const std::string&)’ at /home/username/dev/tmp/SFML/src/SFML/Network/Http.cpp:264:37:
/usr/include/c++/12.1.0/streambuf:490:30: error: potential null pointer dereference [-Werror=null-dereference]
  490 |       gptr()  const { return _M_in_cur;  }
      |                              ^~~~~~~~~
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

The lines in question:
            std::istreambuf_iterator<char> it(in);
            std::istreambuf_iterator<char> itEnd;
            for (std::size_t i = 0; ((i < length) && (it != itEnd)); i++)
->              m_body.push_back(*it++);

Looks to be dereferencing the past-the-end iterator.

error: potential null pointer dereference

If GCC is unsure and this is a potentially a false positive, then a slight rearranging of the code might be sufficient to no longer trigger this warning. The code is more readable if ++it is included after i++ in the for declaration. If you make that change and the error persists then we know to dig deeper.

Any updates on this?

Sorry for the delay. Had to clean up my local fork...
See PR: https://github.com/SFML/SFML/pull/2106

Fixed with #2106

Note: this bug is present on master with the latest version of MSYS2. @eXpl0it3r could you cherry-pick this commit onto master?

Maybe it's time for another back merge then?

No cherry-picking, otherwise we unnecessarily duplicate the history, but I can create another backmerge 🙂


Add checks for Thursday Afternoon with new messaging

Add checks for Thursday Afternoon with new messaging

Avoids messaging that suggests Friday deployments.
Keeps suggestions for Monday deployments.
Fixes #102

Also remove "Tomorrow?" from the list of reasons for Friday.

We don't want to deploy on Saturday!

Ooops, thanks! Fixed that, should be good now.


Reparenting node in Area.body_entered causes crash

Godot version:
3.1.2.stable.custom_build

OS/device including version:
Linux 5.4.2-arch1-1 x86_64 GNU/Linux

Issue description:
If you reparent a Node while handling the Area.body_entered signal, godot crashes.
My use case was an object that can "grab" another object like a magnet.
Steps to reproduce:

Create an Area with this script:

extends Area

func _ready():
	connect("body_entered", self, "on_body_entered")

func on_body_entered(body: Node):
	body.get_parent().remove_child(body)
	add_child(body)

Move a KinematicBody into the area

Running: /usr/bin/godot --path /tmp/example --remote-debug <IP_ADDRESS>:6007 --allow_focus_steal_pid 71021 --debug-collisions --position 448,240 res://Spatial.tscn
Godot Engine v3.1.2.stable.custom_build - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GTX 970/PCIe/SSE2
ERROR: build: Condition ' O == __null ' is true. Continuing..:
   At: core/math/quick_hull.cpp:402.
ERROR: build: Condition ' O == __null ' is true. Continuing..:
   At: core/math/quick_hull.cpp:402.
ERROR: build: Condition ' O == __null ' is true. Continuing..:
   At: core/math/quick_hull.cpp:402.
ERROR: build: Condition ' O == __null ' is true. Continuing..:
   At: core/math/quick_hull.cpp:402.
ERROR: get_tree: Condition ' !data.tree ' is true. returned: __null
   At: scene/main/node.h:263.
handle_crash: Program crashed with signal 11

I can try to repro with debug bits if desired.
Minimal reproduction project:
example.zip

remove_child is fine, the crash occurs at add_child. You can avoid the crash with 	call_deferred("add_child", body).

I have stack overflow when running project in 3.2 beta 3

I have stack overflow when running project in 3.2 beta 3

Me too. The newly added body is detected again and enters a loop.
This is weird though. Using add_child inside signals should be disallowed. I had an error about this multiple times, but it doesn't seem to be triggered here,

ReparentBug.zip
Adding another test project that I believe is related, but shows some interesting differences. This was tested with v3.2.stable.mono.official.

The crash happens on add_child() as mentioned above, but it only crashes if the remove_child() was triggered by an area_entered signal. When you run the project at first, it will remove the item using a timeout signal from a Timer node, and it will later call add_child() without error. You can then edit the script to use the area_entered signal (commenting out the timeout connection. See this section:

	## CHOOSE ONLY ONE OF THESE PICKUP METHODS
	##   - picking up by area_entered signal will crash when re-added
	##   - picking up by timeout signal will *NOT* crash when re-added
#	get_node("Character/PickupArea").connect("area_entered", self, "pickup_item")
	get_node("PickupTimer").connect("timeout", self, "pickup_item", [ get_node("AreaItem") ])

Technically the removed node is not being reparented. It is being temporarily removed and added back to the same parent.
Using call_deferred() does not resolve the issue. It still crashes.
The crash can be triggered even when the reparented node is not added in a position where it triggers an infinite add/remove loop.

I'm getting this on 3.2.3 stable. In my case, add_child is called later in the stack inside a different function. The stack starts with a body_entered signal and using call_deferred as suggested by @rcorre doesn't work. I disagree that adding children from a signal should be disallowed as suggested by @KoBeWi , even though there's a good explanation for the issue it can still be solved within the engine. A game developer or light script user shouldn't have to worry about engine threads, an engine developer should.
@ericrybick 's solution of checking get_parent() against the new parent worked for me.

Just run into this, confirmed still occurring in 3.5 rc7.
From my testing, deferring the add_child() call within body_entered triggers the call stack overflow all the same, I had to conditionally skip the entire codepath by checking whether the body is already re-parented as intended to work around the issue.


Map projection

Support of map-projections like MATCH (n) RETURN n {.* , name:"Bob"}

Can you do another rebase? We merged a fix for the flaky Hive tests, would be great to have this build green, too.


Unable to select role with Snowflake

I am adding Snowflake. After I select an user the Select Role tile is greyed out. Why? If at this stage the real app's link is not yet given then how does AAD knows which roles are supported by the app? thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 163a1f88-c268-18aa-a1e6-89b4a11bfb01
Version Independent ID: 1136a613-48f8-fb67-39d3-d9abdd351a0f
Content: Assign a user or group to an enterprise app in Azure AD
Content Source: articles/active-directory/manage-apps/assign-user-or-group-access-portal.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @msmimart
Microsoft Alias: mimart

@smoms
Thanks for your feedback! We will investigate and update as appropriate.

Make sure that you are signed in as a global administrator, application administrator, cloud application administrator, or the assigned owner of the enterprise app to manage groups.
To assign administrator roles you need to be a global admin or a PIM admin.
To assign other roles you need:
Microsoft.Authorization/roleAssignments/write and Microsoft.Authorization/roleAssignments/delete permissions, such as User Access Administrator or Owner
https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-portal

Hope this helps! If you're still having trouble feel free to open a case in Q&A or email me at<EMAIL_ADDRESS>

@MarileeTurscak-MSFT I am bit surprised you close the ticket without waiting a feedback. Of course I am Global Admin in my tenant. I would say your suggestion is not the solution. Thanks.


[Enhancement] Slider: use clientX to calculate delta, if movementX is 0

This is to address MouseEvent movementX property not supported in internet explorer
A fix for kepler.gl tableau plugin

Since this is a fix for Tableau and IE, perhaps we should state that in the PR title?

The build failure is related to fossa, doesn't seem to have anything to do with the code changes

Asking fossa team on build failure. it is not a merge blocker


InvalidOrder: now mentioned in the Manual

Since it was missing from the Manual I started to implement it myself... until I stumble upon it.
If I had a right to vote I'd wish it to be renamed to OrderNotFound (as it's already thrown upon order cancellation in a variety of places).
InvalidOrder feels as something is wrong with order parameters when you try to create it (like negative amount, misspelled symbol, zero price, out of limits etc).

@mkutny I agree, but, unfortunately, some exchanges don't distinguish between these two types of errors. We may finally end up adding OrderNotFound as well. BTW, what do you think of deriving it from InvalidOrder ?

@kroitor it'd be a nice workaround.

@mkutny i'm doing it already ;) Should arrive very soon!


Fix adding duplicate edge to AdjMatrix

AdjMatrix::add_edge now adds 1 to the internal edge counter unconditionally. However, adjacency matrix does not support multiple edges between two vertices and a new edge always replaces the previous one. In such case, the internal edge counter must remain unchanged.

An alternative behavior to replacing the edge is to return an error once #34 is implemented.


UWP fix for allowing subclasses of OAuth2Authenticator

Xamarin.Auth Pull Request
Fixes #280  .
Checklist

[ ] I have included examples or tests
[ ] I have updated the change log
[ ] I am listed in the CONTRIBUTORS file
[ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

updated WebRedirectAuthenticator check in UWP WebAuthenticatorPage.Events.xaml.cs to allow all subclasses of correct type

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: NLorchy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Please released a version with this fix.

I have also run into this issue and it is blocking development on a current project.

What version is will this be fixed? or is there a workaround in adding resource identifier on the query?
`public class AADOAuth2Authenticator : OAuth2Authenticator
{
public AADOAuth2Authenticator(string clientId, string scope, Uri authorizeUrl, Uri redirectUrl, GetUsernameAsyncFunc getUsernameAsync = null) :
base(clientId, scope, authorizeUrl, redirectUrl, getUsernameAsync)
{
}
    public AADOAuth2Authenticator(string clientId, string clientSecret, string scope, Uri authorizeUrl, Uri redirectUrl, Uri accessTokenUrl, GetUsernameAsyncFunc getUsernameAsync = null) :
        base(clientId, clientSecret, scope, authorizeUrl, redirectUrl, accessTokenUrl, getUsernameAsync)
    {
    }

    protected override void OnCreatingInitialUrl(IDictionary<string, string> query)
    {
        base.OnCreatingInitialUrl(query);

        query.Add("resource", AzureLoginPage.ClientId);

    }

}`


Level 5 tips

Hi!
In level 5 I realised that map has to be lazy,
if map is lazy, this means that we cannot use supplier.get() in the method until the return statement right?
However, I'm a bit stuck on the how do we add onto the list of logs that keeps track of our changes?
In my map method, I store the old value and new value as strings in a list so that the change log can be carried on, but if we cannot use mapper.apply(supplier.get()) to get the new value then how do we update the list of logs?
Thank you!!

Everytime you map, add the supplier of the new log line instead of just the line. Once you call toString(), open all the suppliers using .get() method.

You can use supplier.get() within the map method. It is still lazy if you wrap this supplier.get() within another Supplier. For example, Supplier<T> s = () -> { T newValue = mapper.apply(supplier.get()); ...}; will not be evaluated until needed.

For the log, u could use an ArrayList of Supplier to store all your suppliers. When u map() or flatmap(), copy the old list and add the new supplier into the list. Just move the supplier.get() part into toString(). Take note every supplier should only be get() once, otherwise will cause double print of "sub1".


Prep for PyPI submission

There's some cleanup we should probably do when ready to submit to PyPI. Off the top of my head:

[x] choose an OSS license and create a LICENSE.md file (closed by #48)
[x] go through MANIFEST.in and make sure we're including/excluding what we want (closed by #48)
[x] go through README and clean it up (some instructions might not match recent changes) (closed by #40)

All of these have been addressed.


Update README.md

The one with <? didn't work for me, so i appended <?php and it worked. Anyhow, it would be good to add that one too, just in case. Take a look at POCs.
Best regards, Milan
понедељак, 19. новембар 2018. 13:27:42 CET, Swissky<EMAIL_ADDRESS>је написао/ла:

Can you confirm it is working with <?php instead of <?, I based mine on this one http://i.imgur.com/vMZKf.png :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok thank you for your time :)


Icon Hides/Appears When Scrolling Desktops

When I change from one desktop to another and watch the icon, it appears to flicker colour or even hide/reappear completely when changing desktops using the gesture while nothing else I have in the menu bar does this.
I know this is a minor UI bug but would be cool to fix this if it is easy.

I'm closing this issue because I can't reproduce it and haven't received similar reports.


Ability To Interact With Root Tags Directly

Hey it would be really nice if I could create a filter or directly configure the "tags" array in the OpenApi spec after controller evaluation has occurred. I've been trying to get my resources to show up in alphabetical order for a few days and there doesn't seem to be a solution with the combination of things in my team's app.
We have a separate directory for deprecated API while they are still supported and we currently host a swagger UI with all combined, current versions using the ResolveConflictingActions() feature you provide. This works great except that it leaves behind orphaned tags of resources that weren't included. I tried using the TagActionsBy() feature, but it adds tags to the operation's tags arrays and does not remove existing ones. It also does not support descriptions like SwaggerTag does.
After digging through this, I believe that the reason my tags are out of order now is either because I have two directories of controllers (therefore changing the natural order during evaluation) or it just happens to be the order they end up in after ResolveConflictingActions() has taken place.
This and the orphaned tags left behind both leave me thinking that a new feature allowing the ability to interact with the root tags array rather than modifying existing features around an operation's tags array would be preferred. Thoughts, @domaindrivendev?

Ha I assumed that there would be an issue related to this, but never checked your README. For anyone else who runs into this:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore#document-filters
using Microsoft.OpenApi.Models;
using Swashbuckle.AspNetCore.SwaggerGen;
using System.Linq;

namespace Platform.Pricing.API.Application.DocumentFilters
{
    public class TagsDocumentFilter : IDocumentFilter
    {
        public void Apply(OpenApiDocument swaggerDoc, DocumentFilterContext context)
        {
            swaggerDoc.Tags = swaggerDoc.Tags.OrderBy(t => t.Name).ToList();
        }
    }
}


whitespace in .gitattributes linguist-language

In the .gitattributes file, how do we set the linguist-language attribute to a language name that contains whitespace, such as  Ant Build System?

Good question @c-lipka. It doesn't seem to work currently. I'll try and investigate a solution to this.

@c-lipka Whitespaces in .gitattributes do not seem to be the issue here. I tried with AGS Script and it works fine.
Maybe this has to do with Ant Build System being a data language in Linguist? As a consequence it will not appear in statistics, even with a .gitattributes.

Flagging as stale :flags: