C++: FP in cpp/large-parameter with overloaded binary oeprators

In C++, one pattern for implementing operator+ and other overloaded binary operators is the following:
Type operator+(Type lhs, Type const& rhs ) {
   lhs += rhs;
   return lhs;
}

Exactly how this is compiled depends on both compiler version and optimization level, but it seems not to involve an additional copy at -O2 or -O3 on recent versions of the major compilers. See https://godbolt.org/z/W7BXKk for some experimentation with this.

I'm starting work on a PR that will add tests and possibly a fix for this.

To check whether a parameter (or some other variable) may be modified, I think the EscapesTree.qll library can do most of the work. If variableAccessedAsValue(param.getAnAccess(), e.getFullyConverted()) and e is on the LHS of an Assignment or CrementOperation, then the parameter is directly modified. If param.getAnAccess().isAddressOfAccessNonConst(), then the parameter may be modified indirectly because its address escapes.
Using EscapesTree.qll should ensure that complicated expressions and edge cases are handled correctly. For example, x.a[i]++ is a modification of x if it has type struct { int a[8]; } but not if it has type struct { int *a; }.

I've created https://github.com/Semmle/ql/pull/1279 but I'd like to encourage a bit more discussion around it rather than a quick merge.
I didn't figure out how to use variableAccessedAsValue to any particular advantage.

I recently watched parts of a CppCon talk by Herb Sutter, who is a well-known C++ guru. He advises against passing non-trivial parameters by value since it makes it easier to make certain mistakes and since performance suffers in some important cases.
The advice has made it into the C++ Core Guidelines (https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#fcall-parameter-passing), where it's suggested that a static analysis tool should:

Warn when a parameter being passed by value has a size greater than 2 * sizeof(void*). Suggest using a reference to const instead.

Our query is certainly on the conservative side of that.

https://github.com/Semmle/ql/pull/1279 has been merged and resolves the situation described here.  It's true that passing large parameters by value can be considered an undesirable pattern regardless - if anybody has strong feelings about this we could create a non-default query to report the other cases.

The CLang linter actually encourages pass by value in these cases. The reasoning is as follows:
struct C {};

C op1(C const& c1, C const& c2) {
   C out = c1;
   out += c2;
   return out;
}

C op2(C c1, C const& c2) {
   c1 += c2;
   return c1;
}

int main() {
   C c1, c2;
   C c3 = op1(c1, c2);  // case 1: call with values on the stack
   C c4 = op1(c1, c2);
   C c5 = op1({}, {});  // case 2: call with temporaries
   C c6 = op2({}, {});
}

In any case, thank you for implementing this!
In case 1, both op1 and op2 make a copy of c1, add c2 to it, and the result is assigned into a new variable (note C++'s return value optimization, not sure what it's called nowadays, but it's mandated in the standard that return by value does not incur a copy nor a move).
In case 2, op1 makes a copy of the temporary, which is passed by reference, and works just like before. However, op2 takes the temporary, adds the other value to it, and assigns it into c6. In this case there is no 3rd object created ever.
Thus, op2 saves a copy in this case over op1.
Another very common construct in C++ is the "take by value and move" paradigm in constructors:
class LargeData {};

class C {
   C(LargeData data) : data_(std::move(data)) {}
private:
   LargeData data_;
};

The reasoning here is the same. We can construct an object of class C using a temporary value of type LargeData, without actually copying that data.
Whenever a copy needs to be made of data within a function, it is better to let the compiler make the copy of the input argument, because it can avoid the copy if the input value is a temporary.
I believe the right logic is:

Use the large value only for reading: pass by const reference.
Make a copy of the large value: pass by value.
Modify the value: pass by reference.


Change links in usage certificate to kubectl plugin #renew to be relative

Same as #718
/assign @jakexks
This PR changes references in release-1.5/usage/certificate to usage/kubectl-plugin/#renew to use a relative path. When using an absolute path, it looks like it will reference the latest docs, which will no longer exist after this PR #715. Changing to the relative path should now link to the page within the correct version.

/retest


Add support for model o1

Issue
please add support for o1
Version and model info
No response

Thank you for filing this issue.
aider supports o1 models since 0.57.0, see here -> https://aider.chat/HISTORY.html#aider-v0570


Inconsistent behaviour with redux-saga 1.0.0 and next-redux-saga patched for this version

I patched next-redux-saga to satisfy the requirements for the new version (1.0.0) of redux-saga, that is, I changed references o done to toPromise(), and symlinked the patched version to my project.
Since then the behaviour is very inconsistent.  While my app will often function on first build and load, page reloads will not load the data correctly -- it would appear that the saga, while called, is not returning before the rest of the page is loaded.  I attach a log below (a combination of my console.logs and next-redux-wrapper's logging), to show, more or less, what is going on.
If I un-symlink next-redux-saga (that is, use the current version) and change redux-saga to version 0.16.0, my app works fine.  So that led me to think that there's something going on with the interaction between next-redux-saga and the app.   For what it's worth, a recent change in next-redux-wrapper -- to v. 2.1.0 - appears to involve creating the store multiple times.  I don't know if this has anything to do with it.
Log: note: I've edited the actual data, for brevity, that is it's printed out on screen.  I have indicated, however, when it was received correctly, and when not.
creating store::::
1. WrappedApp.getInitialProps wrapper got the store with state { home: {} }
_app.js getInitialProps
calling Component.getInitialProps
index.js, getInitialProps isServer =  true
index.js, dispatching saga loadData inside index.js getInitialProps, isServer =  true
fetching data in saga from route home:  http://something.else.com/api/es/
returning Component.getInitialProps
storing data in store { name: 'Home',
 published: true,
 draft: false,
 layout_id: 1,}
3. WrappedApp.getInitialProps has store state { home:
  { data:... } // data received correctly
4. WrappedApp.render created new store with initialState { home:
    { data:... } // data received correctly
creating store::::
rendering _app.js, main render, props =  { Component:
  { [Function: Connect]
    WrappedComponent: { [Function: Index] propTypes: [Object] },
    displayName: 'Connect(Index)' },
 router:
  Router {
    onPopState: [Function],
    route: '/index',
    components: { '/_app': [Object] },
    events: EventEmitter { listeners: {} },
    pageLoader: undefined,
    prefetchQueue:
     PQueue {
       queue: [Queue],
       _pendingCount: 0,
       _concurrency: 2,
       _resolveEmpty: [Function] },
    ErrorComponent: undefined,
    pathname: '/index',
    query: {},
    asPath: '/',
    subscriptions: Set { _c: Set {} },
    componentLoadCancel: null,
    _beforePopState: [Function] },
 isServer: true,
 store:
  { dispatch: [Function],
    subscribe: [Function: subscribe],
    getState: [Function: getState],
    replaceReducer: [Function: replaceReducer],
    runSagaTask: [Function],
    sagaTask:
     { '@@redux-saga/TASK': true,
       id: 10,
       meta: [Object],
       isRoot: true,
       context: {},
       joiners: null,
       queue: [Object],
       cancel: [Function: cancel],
       cont: [Function],
       end: [Function: end],
       setContext: [Function: setContext],
       toPromise: [Function: toPromise],
       isRunning: [Function: isRunning],
       isCancelled: [Function: isCancelled],
       isAborted: [Function: isAborted],
       result: [Function: result],
       error: [Function: error] },
    [Symbol(observable)]: [Function: observable] } }
in header.js selector, state =  { home:
    { data:... } // data received correctly
rendering Header.js, props =  { headerData:...} // props received correctly
rendering index.js, props =  {...,} // props received correctly
rendering Footer.js, props =  {...,} // props received correctly
creating store::::
1. WrappedApp.getInitialProps wrapper got the store with state { home: {} }
_app.js getInitialProps
calling Component.getInitialProps
index.js, getInitialProps isServer =  true data =  undefined
index.js, dispatching loadData inside index.js getInitialProps, isServer =  true
returning Component.getInitialProps
3. WrappedApp.getInitialProps has store state { home: {} }
4. WrappedApp.render created new store with initialState { home: {} } // store is EMPTY
creating store::::
rendering _app.js, // props are NOT received correctly

@robert-barcelona I think we're removing sync-mode. Keep track of this pull-request.


Integrate Christian's suggestions

If needed, break this into multiple issues or delete it if it's captured in other issues.
"game count? also when you score a goal maybe start a new timer for putting the next ball into play. By extension when a game ends start a 90 second timer."

Created separate issues for each item.


Warning when using text-based Bun lockfile

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
https://github.com/robertherber/repro-turbo-with-bun-text-based-lockfile
Which canary version will you have in your reproduction?
2.3.4-canary.3
Enviroment information
CLI:
   Version: 2.3.3
   Path to executable: /Users/robertherber/code/_play/turbo-bun-text-based/node_modules/turbo-darwin-arm64/bin/turbo
   Daemon status: Running
   Package manager: bun

Platform:
   Architecture: aarch64
   Operating system: macos
   WSL: false
   Available memory (MB): 25846
   Available CPU cores: 10

Environment:
   CI: None
   Terminal (TERM): xterm-256color
   Terminal program (TERM_PROGRAM): WarpTerminal
   Terminal program version (TERM_PROGRAM_VERSION): v0.2<IP_ADDRESS>.55.stable_03
   Shell (SHELL): /bin/zsh
   stdin: false

Expected behavior
I expect it to work without a warning.
Actual behavior
Getting a very noisy warning whenever I run a turbo command:
 WARNING  Issues occurred when constructing package graph. Turbo will function, but some features may not be available:
   × could not resolve workspaces
  ╰─▶ unable to parse: Parsing Error: Error { input: "one-plus-one@^workspace:packages/one-plus-one:\n  version \"workspace:packages/one-plus-one\"\n  resolved \"workspace:packages/one-plus-one\"\n  devDependencies:\n    \"@types/bun\" <EMAIL_ADDRESS>      \n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo/-/turbo-2.3.3.tgz\"\n  integrity sha512-DUHWQAcC8BTiUZDRzAYGvpSpGLiaOQPfYXlCieQbwUvmml/LRGIe3raKdrOPOoiX0DYlzxs2nH6BoWJoZrj8hA==\n  optionalDependencies:\n    turbo-darwin-64 \"2.3.3\"\n    turbo-
      darwin-arm64 \"2.3.3\"\n    turbo-linux-64 \"2.3.3\"\n    turbo-linux-arm64 \"2.3.3\"\n    turbo-windows-64 \"2.3.3\"\n    turbo-windows-arm64 \"2.3.3\"\n\nturbo-darwin-64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-darwin-64/-/turbo-
      darwin-64-2.3.3.tgz\"\n  integrity sha512-bxX82xe6du/3rPmm4aCC5RdEilIN99VUld4HkFQuw+mvFg6darNBuQxyWSHZTtc25XgYjQrjsV05888w1grpaA==\n\nturbo-darwin-arm64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-darwin-arm64/-/turbo-darwin-arm64-
      2.3.3.tgz\"\n  integrity sha512-DYbQwa3NsAuWkCUYVzfOUBbSUBVQzH5HWUFy2Kgi3fGjIWVZOFk86ss+xsWu//rlEAfYwEmopigsPYSmW4X15A==\n\nturbo-linux-64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-linux-64/-/turbo-linux-64-2.3.3.tgz\"\n  integrity
      sha512-eHj9OIB0dFaP6BxB88jSuaCLsOQSYWBgmhy2ErCu6D2GG6xW3b6e2UWHl/1Ho9FsTg4uVgo4DB9wGsKa5erjUA==\n\nturbo-linux-arm64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-linux-arm64/-/turbo-linux-arm64-2.3.3.tgz\"\n  integrity sha512-NmDE/
      NjZoDj1UWBhMtOPmqFLEBKhzGS61KObfrDEbXvU3lekwHeoPvAMfcovzswzch+kN2DrtbNIlz+/rp8OCg==\n\nturbo-windows-64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-windows-64/-/turbo-windows-64-2.3.3.tgz\"\n  integrity sha512-O2+BS4QqjK3dOERscXqv7N2GXNcqHr9hXumkMxDj/
      oGx9oCatIwnnwx34UmzodloSnJpgSqjl8iRWiY65SmYoQ==\n\nturbo-windows-arm64@2.3.3:\n  version \"2.3.3\"\n  resolved \"https://registry.npmjs.org/turbo-windows-arm64/-/turbo-windows-arm64-2.3.3.tgz\"\n  integrity sha512-dW4ZK1r6XLPNYLIKjC4o87HxYidtRRcBeo/hZ9Wng2XM/
      MqqYkAyzJXJGgRMsc0MMEN9z4+ZIfnSNBrA0b08ag==\n\ntypescript@^5.0.0:\n  version \"5.7.2\"\n  resolved \"https://registry.npmjs.org/typescript/-/typescript-5.7.2.tgz\"\n  integrity sha512-i5t66RHxDvVN40HfDd1PsEThGNnlMCMT3jMUuoh9/0TaqWevNontacunWyN02LA9/fIbEWlcHZcgTKb9QoaLfg==\n\nundici-types@~5.26.4:\n
      version \"5.26.5\"\n  resolved \"https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz\"\n  integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==\n", code: Eof }

• Packages in scope: one-plus-one
• Running typecheck in 1 packages
• Remote caching disabled
one-plus-one:typecheck: cache miss, executing 284ac7686cc4f234
one-plus-one:typecheck:
one-plus-one:typecheck: $ tsc --noEmit

 Tasks:    1 successful, 1 total
Cached:    0 cached, 1 total
  Time:    706ms```

The command still works though.

### To Reproduce

Here's a simple repo reproduction:
https://github.com/robertherber/repro-turbo-with-bun-text-based-lockfile

Just run `bun typecheck` in the root and the warning is there (as above).

### Additional context

Using bun 1.1.39 with a text-based lockfile.

Having the same problem here.


Fixed C Windows reverse shell

This Pull Request fixes the error  error C2198: 'strcpy_s': too few arguments for call in the C  Windows generated reverse shell C code.

@all-contributors

@all-contributors please add @StarNumber12046 for fixing a bug


[clangd] autocomplete on method name deletes method name instead of completing it

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Announcement

[X] I have checked Breaking change announcement.

Minimal reproducible full config
require('packer').startup(function(use)
  use 'wbthomason/packer.nvim'

  use 'neovim/nvim-lspconfig'

  use 'hrsh7th/cmp-nvim-lsp'
  use 'hrsh7th/cmp-buffer'
  use 'hrsh7th/cmp-path'
  use 'hrsh7th/cmp-cmdline'
  use 'hrsh7th/nvim-cmp'
end)

vim.cmd([[
	set completeopt=menu,menuone,noselect
]])

local on_attach = function(client, bufnr)
end

local cmp = require('cmp')
cmp.setup({
    snippet = {
      expand = function(args)
      end,
    },
    mapping = cmp.mapping.preset.insert({
      ['<C-b>'] = cmp.mapping.scroll_docs(-4),
      ['<C-f>'] = cmp.mapping.scroll_docs(4),
      ['<C-Space>'] = cmp.mapping.complete(),
      ['<C-e>'] = cmp.mapping.abort(),
      ['<CR>'] = cmp.mapping.confirm({ select = true }), -- Accept currently selected item. Set `select` to `false` to only confirm explicitly selected items.
    }),
    sources = cmp.config.sources({
      { name = 'nvim_lsp' },
    }, {
      { name = 'buffer' },
    })
  })

local capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())
require('lspconfig').clangd.setup({
  single_file_mode = false,
  cmd = { 'clangd', '--background-index', '-j', '6', '--clang-tidy', '--clang-tidy-checks=modernize-*,-modernize-use-trailing-return-type', '--limit-results=0' },
  on_attach = on_attach,
  capabilities = capabilities,
})

Description
A more detailled analysis of #1158
With the init.lua in the ticket, opening up a C++ file will correctly initialize LSP & completion, but given the following program:
int main(int argc, char** argv)
{
    std::string test;
    test.append("test");
    return 0;
}

Adding another line and entering test.ap will correctly show a dropdown menu with all methods that begin with ap. Selecting one of them and pressing CR (or C-Space) will remove the dropdown menu and delete everything in the method name, so the line now reads test..
For Python using the pyright LSP server, completion works as expected.
Steps to reproduce
See description
Expected behavior
Completion behaviour like for Python/pyright
Actual behavior
Written portion of method name gets removed.
Additional context
No response

Update: Removing the capabilities from the clangd setup seems to fix the issue

Another potential workaround is to disable just snippetSupport:
local capabilities = vim.lsp.protocol.make_client_capabilities()
capabilities = require('cmp_nvim_lsp').update_capabilities(capabilities)
local capabilitiesClangd = vim.deepcopy(capabilities)
capabilitiesClangd.textDocument.completion.completionItem.snippetSupport = false

require('lspconfig').pylsp.setup {
  capabilities = capabilities
}

require('lspconfig').clangd.setup {
  capabilities = capabilitiesClangd
}

@przemkovv That fixed the issue, many thanks!
I don't rightly understand the "why", though. Am I providing a wrong snippet "expand" function? Are there known issues with clangd and snippets? I did not find anything about that, unfortunately.


RequestListener does not collect user-data

There are cases where line 72 in RequestListener fails, even if an user is authenticated (for example, when dealing with more than one firewall). Symfony throws an Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException in that case. I suggest changing that line to check, if an user is given in $token.

Solved with #265.


Zookeeper client version so zookeeper client will re-resolve hosts when IP has changed

We have the same situation as mentioned in Zookeeper bug here . Simple version is, we will replace zookeeper servers with a new host that has new IP address, but still keep the host name in the DNS.
This bug in Zookeeper client is fixed in 3.4.13+ or 3.5.5+, or 3.6.0+ and pinot is using 3.4.11
Can we upgrade at least the minor version to 3.4.13?

I'm seeing an issue of zk client connection for jdk14+ after the upgrade.
Will investigate this.


[dvsim] Add control of max job submission per second

default is up to 20 jobs per second
This will fix the bsub error due to submitting too many jobs at the same time
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

Wouldn't it be easier to set up a job array for this? Then you can submit 1000 jobs at once or whatever and you won't have a whole load of bsub processes sitting around. At least, I think that's how you're supposed to do it with LSF.


[ISSUE] Since 10.0.3 Elasticsearch Host is no longer overwritten in operate-configmap

Describe the issue:
Since version 10.0.3, the variable 'global.elasticsearch.url.host' no longer replaces the value under camunda.operate.elasticsearch.host and camunda.operate.elasticsearch.url in the operate-configmap. The helpers.tpl seems not to work correctly anymore.
Actual behavior:
    camunda.operate:
      [...]
      # ELS instance to store Operate data
      elasticsearch:
        # Cluster name
        clusterName: elasticsearch
        username: "test-user"
        # Host
        host: release-name-elasticsearch
        # Transport port
        port: 9200
        # Elasticsearch full url
        url: "http://release-name-elasticsearch:9200"

Expected behavior:
    camunda.operate:
      [...]
      # ELS instance to store Operate data
      elasticsearch:
        # Cluster name
        clusterName: elasticsearch
        username: "test-user"
        # Host
        host: my-fancy-es-host
        # Transport port
        port: 9200
        # Elasticsearch full url
        url: "http://my-fancy-es-host:9200"

How to reproduce:
Try to override the global.elasticsearch.url.host value
Logs:

Environment:
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform: GCP
Helm CLI version: 3.14.3
Chart version: >= 10.0.3

Experiencing the same and can say that this happens for Tasklist as well.

@aabouzaid is there any ETA on getting this fix out in a 10.X.X-release? End of the week? 😄 🙏

Customer reported it in https://jira.camunda.com/browse/SUPPORT-21850

@aabouzaid is there any ETA on getting this fix out in a 10.X.X-release? End of the week? 😄 🙏

It's out today: 10.0.5 :raised_hands:


Script to auto-generate docs issues from release notes file

@knz and/or @benesch, this is ready for a review.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/871b4655d4ead0ce85d2048aae71c4624625ba6b/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b895ce973bd2a6d0055b8512d5d6d29cbd8ea2a7/

TFTR, @benesch!

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/169b454cf243a48ac25f4d805295486bc742cf19/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/09967a22a197d8f51baff0bc89ce85bdaf677b4e/


Use launch arguments in XCTestCase directly

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Hi, i'm trying to pass the launch arguments of snapshot directly to the XCTestCase, to perform different tests based on the configuration. My snapfile contains the following arguments
launch_arguments([
  "-hide_login false -login_type "
])

In the XCTestCase is use the following code to retrieve the variables:
`
    let hideLogin = NSUserDefaults.standardUserDefaults().stringForKey("hide_login") ?? "not_found_hide_login"
     snapshot(hideLogin)
    let loginType = NSUserDefaults.standardUserDefaults().stringForKey("login_type") ?? "not_found_login_type"

    snapshot(loginType)`

When i run snapshot, the program can't find the variables. What am i missing? :)

Does this help? https://github.com/fastlane/fastlane/issues/3745#issuecomment-196561294

I already saw that ticket. I used the following method:
func argValueForKey(key:String, app:XCUIApplication) -> String? {
        if let index = app.launchArguments.indexOf(key) {
            return app.launchArguments[index+1]
        } else {
            return nil
        }
    }

//Fetch launch argument
let app = XCUIApplication()
setupSnapshot(app)

let testcase = argValueForKey("-testcase", app:app) ?? "0"

And that worked :)


Removed package.json to avoid installing outdated node-sass

With this package.json in the repository any Meteor application making use of this package will install an outdated version of node-sass, causing the bundle to grow with several megabytes (to include an outdated version of phantomjs).

Oh, I didn't know Meteor is traversing a package tree to find a package.json.
But that'll break the example app – would you mind renaming the directory to .example instead? That'll hide it from Meteor.

@brookback any thoughts to accept this?
just linking here https://github.com/lookback/meteor-emails/issues/96

@adamgins I'll have a look asap.

Thanks @brookback

Any movement on this? Trying to install lookback and its failing my entire build with the 404 on the node-sass even though node-sass is installed as a dependency in my package.json.  Would appreciate any help asap.  Thanks!

@bduff9 Feel for trying this branch: fix/hide-example-app, if you clone down this package into the packages dir in your app. I've renamed the example dir to .example to make Meteor ignore it and its package.json file. Thanks!

@brookback but that branch still has https://github.com/lookback/meteor-emails/blob/3575685773f8700d55ea92144c84fada999f08cb/package.js#L16
Won't that still include node-sass?


Code Insiders: No installation of Visual Studio Code insider was found in Command-line

Type: Bug

installing or add PATH environments for code-insiders
observe to type code-insider is installed or not in terminal as cmd, shell, etc.

Expected: type code-insiders will working
actual: Error and It says "No installation of Visual Studio Code insider was found"
VS Code version: Code - Insiders 1.92.0-insider (89690b9d76a88fab676d26651134a1ffa4562732, 2024-07-19T05:03:57.939Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Pentium(R) CPU N4200 @ 1.10GHz (4 x 1094)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: unavailable_softwarewebnn: disabled_off

Load (avg)
undefined

Memory (System)
3.83GB (0.93GB free)

Process Argv
--crash-reporter-id cbbe804e-79b2-4e58-a4de-8bac5e7557ee

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

increment-selection
alb
0.2.0

chronicler
arc
0.1.16

multi-cursor-case-preserve
Car
1.0.5

vscode-office
cwe
3.3.9

jumpy2
Dav
1.7.0

prettier-vscode
esb
10.4.0

codespaces
Git
1.17.2

warm-up-typing-test
Jeu
1.1.0

vscode-insertdatestring
jsy
2.3.1

remote-explorer
ms-
0.5.2024070409

remote-server
ms-
1.6.2024070809

batch-runner
Nil
1.3.1

sourcepawn-vscode
Sar
8.0.2

vscode-fileutils
sle
3.10.3

file-size
zh9
1.0.0

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vsc_aacf:30263846
vscod805cf:30301675
vsaa593:30376534
py29gd2263:31024238
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythonregdiag2:30926734
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
g316j359:31013175
a69g1124:31018687
dvdeprecation:31040973
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31057980
nativerepl1:31093711
refactort:31084545
pythonrstrctxt:31093868
0c838689:31088353
1iic9185:31091668

Have you tried to restart cmd or even PC?
Also can you try to move it up in the order?

Fixed by removed cli zip was conflict in path env. thank you for your suggest. sorry I double checked read my list of path env. this is closed case now.


isolate packet fee distribution for on acknowledgement and on timeout into separate functions

Description
Reduces the complexity contained in DistributePacketFees and DistributePacketFeesOnAcknowledgement in anticipation of #1251
closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #1253 (7a9ad20) into main (e59a6d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   80.15%   80.16%
=======================================
  Files         166      166
  Lines       11943    11949    +6
=======================================
+ Hits         9573     9579    +6
  Misses       1912     1912
  Partials      458      458

Impacted Files
Coverage Δ

modules/apps/29-fee/keeper/escrow.go
88.88% <100.00%> (+0.60%)
:arrow_up:


southxchange & bleutrade fetch_balance error (ccxt v. 1.9.174, Python 2.7)

The fetch_balance() function in southxchange and bleutrade seems to result in this error:
Traceback (most recent call last):
  File "C:\xampp\cgi-bin\TheChankReport.py", line 71, in <module>
    fetch_wallet()
  File "C:\xampp\cgi-bin\TheChankReport.py", line 22, in fetch_wallet
    balance = x.fetch_balance()
  File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5482, in fetch_balance
    account['used'] = balance['Balance'] - balance['Available']
TypeError: unsupported operand type(s) for -: 'unicode' and 'unicode'

I have bittrex, anxpro and hitbtc working with the same code.

@PhinixPhire got it, will fix it... Unfortunately, Python is very sensitive... No problem, just a sec.

I did a fix for bleutrade, should be ready soon. In the meantime, can you please paste verbose output for the error you were getting with southxchange?

('https://www.southxchange.com/api/markets', 'GET', 'https://www.southxchange.com/api/markets', '\nRequest:', {'Accept-Encoding': 'gzip, deflate', 'User-Agent': 'ccxt/1.9.174 (+https://github.com/ccxt-dev/ccxt) Python/2.7.14'}, None)
('GET', 'https://www.southxchange.com/api/markets', '\nResponse:', 'Date: Wed, 18 Oct 2017 10:39:03 GMT\r\nContent-Type: application/json; charset=utf-8\r\nTransfer-Encoding: chunked\r\nConnection: close\r\nSet-Cookie: __cfduid=[REMOVED]; expires=Thu, 18-Oct-18 10:39:03 GMT; path=/; domain=.southxchange.com; HttpOnly\r\nCache-Control: no-cache, no-store, must-revalidate\r\nPragma: no-cache\r\nExpires: -1\r\nSet-Cookie: _culture=en-US; path=/\r\nX-AspNetMvc-Version: 5.2\r\nAccess-Control-Allow-Origin: *\r\nX-AspNet-Version: 4.0.30319\r\nX-Powered-By: ASP.NET\r\nX-Frame-Options: DENY\r\nSet-Cookie: ARRAffinity=[REMOVED];Path=/;HttpOnly;Domain=www.southxchange.com\r\nServer: cloudflare-nginx\r\nCF-RAY: 3afadf1f0eab2501-ORD\r\nContent-Encoding: gzip\r\n', u'[["BCH","BTC"],["BSD","BTC"],["BTA","BTC"],["CHA","BTC"],["DASH","BTC"],["DOGE","BTC"],["ETH","BTC"],["FLB","BTC"],["GRT","BTC"],["ICE","BTC"],["LTC","BTC"],["MINT","BTC"],["MRN","BTC"],["MSR","BTC"],["NMC","BTC"],["NXT","BTC"],["PPC","BTC"],["PTC","BTC"],["STRAT","BTC"],["SUP","BTC"],["VTC","BTC"],["VUC","BTC"],["XMR","BTC"],["XVG","BTC"],["ZEIT","BTC"],["CHRC","LTC"],["ZEIT","LTC"],["BCH","USD"],["BTC","USD"],["DASH","USD"],["ETH","USD"],["GRT","USD"],["ICE","USD"],["LTC","USD"],["MRN","USD"],["MSR","USD"],["STRAT","USD"],["USNBT","USD"],["XMR","USD"],["BTC","USNBT"]]')
('https://www.southxchange.com/api/listBalances', 'POST', 'https://www.southxchange.com/api/listBalances', '\nRequest:', {'Hash': '[REMOVED]', 'Content-Type': 'application/json', 'Accept-Encoding': 'gzip, deflate', 'User-Agent': 'ccxt/1.9.174 (+https://github.com/ccxt-dev/ccxt) Python/2.7.14'}, '{"nonce":1508323142,"key":"[REMOVED]"}')
('POST', 'https://www.southxchange.com/api/listBalances', '\nResponse:', 'Date: Wed, 18 Oct 2017 10:39:04 GMT\r\nContent-Type: application/json; charset=utf-8\r\nContent-Length: 2\r\nConnection: close\r\nSet-Cookie: __cfduid=d8b9e25e3714308ab52b7edf5cab6b51e1508323143; expires=Thu, 18-Oct-18 10:39:03 GMT; path=/; domain=.southxchange.com; HttpOnly\r\nCache-Control: no-cache, no-store, must-revalidate\r\nPragma: no-cache\r\nExpires: -1\r\nSet-Cookie: _culture=en-US; path=/\r\nX-AspNetMvc-Version: 5.2\r\nAccess-Control-Allow-Origin: *\r\nX-AspNet-Version: 4.0.30319\r\nX-Powered-By: ASP.NET\r\nX-Frame-Options: DENY\r\nSet-Cookie: ARRAffinity=[REMOVED];Path=/;HttpOnly;Domain=www.southxchange.com\r\nServer: cloudflare-nginx\r\nCF-RAY: [REMOVED]-ORD\r\n', u'[]')

Traceback (most recent call last):
  File "C:\xampp\cgi-bin\TheChankReport.py", line 71, in <module>
    fetch_wallet()
  File "C:\xampp\cgi-bin\TheChankReport.py", line 22, in fetch_wallet
    balance = x.fetch_balance()
  File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5500, in fetch_balance
    account['used'] = balance['Balance'] - balance['Available']
TypeError: unsupported operand type(s) for -: 'unicode' and 'unicode'
>>>

@PhinixPhire sorry, but File "C:\Python27\lib\site-packages\ccxt\exchanges.py", line 5500, in fetch_balance is the location of bleutrade, not southxchange... I can't find any problem with southxchange currently... In fact their calls should look completely different, so your output does not seem to be the output for southxchange... Are you sure that your code calls from southxchange  correspond to that verbose output?

Oh, now I see. No problem, that happens. My advice is: put an explicit line "empty balance" there instead of nothing, when the balance is empty, following that rule for all undefined variables will save you hours of debugging, really. ;)
So, I guess, the only problem is bleutrade and it should be fixed by the upcoming build in 5 minutes, right? Let me know if it works for you or not, please. )

Yep, that should be it. I'll confirm if working as soon as the update comes through. Thank You so much!

It's there, will stand by to hear from you.

Working great! I appreciate the help, as always.


Fix issue #35 - false positive for blank lines around functions with comments

This PR

adds a comment detection regex to the blank-lines rule, allowing functions to be preceded by comments with form //, ///, and /** ... lines  ...*/
adds a function preceded by a block of asterisk-style comments to the test's solidity file.
lets this test pass

Awesome!

This linter is awesome! Thanks for writing it.


Vue 2.7+ no longer fails on and report type errors in build and serve commands

Version
2.7.8
Reproduction link
github.com
Steps to reproduce
Based from the vuejs-type-bug-demo root folder:

cd ./hello-world-2.6 && npm install && npm run build
cd ./hello-world-2.7 && npm install && npm run build

What is expected?
In 2.7 I expect the errors in typing to fail the build as it does in 2.6
What is actually happening?
Succeeding the build without any errors thrown

This seems to be a compiler-sfc issue that causes the ForkTsCheckerWebpackPlugin to not get the correct script.

This relies on ts-loader to fix its compatibility with Vue 2.7.
The latest recommendation, however, is to avoid doing type check as part of the webpack build, and instead using vue-tsc. You can start it in a separate process in watch mode.

Will try that, but it would be nice if this got mentioned in the upgrade to vue 2.7+. So users can determine if they can spare the extra time invested to setup vue-tsc and disable type checking in webpack during serve and build commands.

I can confirm that this particular problem is fixed in 2.7.11


xSQLServerSetup: Fixes tests for SQLSysAdminAccounts

The test now properly evaluates the setup argument for SQLSysAdminAccounts. This is for PR #370
This Pull Request (PR) fixes the following issues:
n/a

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

This change is

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

As soon as this passes the test I will merge it. This will fix the tests so that the code in the previous merged PR #370 can be tested.


Need to trim small RNA adapter

The pipeline doesn't currently trim the small RNA adapter. TrimGalore command should be:
trim_galore --gzip --adapter ATGGAATTCTCG --fastqc_args "-q" ${reads}

Current data has this as overrepresented sequence, (end is the reverse complement of the above adapter):
GTTTCCGTAGTGTAGTGGTTATCACGTTCGCCT

Ignore this - latest version of TrimGalore does this automatically (and better actually).


fix: paragraph may be null in HitTest

Hi, in textpainter, paragraph might be null in some cases (hitTest), so I postponed the timing of its emptying (just before layout).
https://github.com/flutter/flutter/issues/84650
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@endless7 There used to be a bug where the TextPainter in RenderParagraph was incorrectly marked dirty when the RenderParagraph itself is not dirty that could cause the same type of crash and it was fixed not long ago, and I'd expect that to fix some crashes reported in #84650.
I think the asserts (_paragraph != null) exist to catch programmer errors where people try to query the text layout while the text layout is not yet done or needs updating. This doesn't seem to be particularly wrong: you don't want to perform hittesting on text that's potentially no longer there.

On a second thought, I feel it's the owner RenderObject's responsibility to avoid invalidating/updating its TextPainter until performLayout is called, if it needs the text layout info from the last frame, for hit-testing for example. IOW it should "freeze" the TextPainter once the text layout is done so that the TextPainter's properties faithfully and consistently represent the current text layout.

Since as a low-level text API, TextPainter is just enforcing the correct usage and isn't doing anything obviously wrong here, I'm going to close this pull request to reduce the backlog.  @endless7 feel free to reopen the pull request if you still think this should be fixed in TextPainter.

@LongCatIsLooong I agree with the reasoning you presented, however that still leaves a big problem : we have absolutely no idea which widget causes the error. So we're just going to keep getting crashes without ever solving the root cause, and I don't think ignoring the problem is a good idea. Any way of getting info the problematic widget ?

@TheCarpetMerchant are you still seeing this error on recent versions of Flutter? The stack trace should tell you what RenderObject caused the crash during hit testing. RenderObject.debugCreator should tell you which widget created the RenderObject.

@LongCatIsLooong I'm in the same situation as the OP, I cannot reproduce the problem but have hundreds of crashes in production.
I'll post my logs in the issue itself so as to not pollute this.

Same issue here, can't reproduce and hundred of crashes in prod reported by Crashlytics

@LongCatIsLooong Hi, maybe the textpainter.markNeedsLayout should be changed to markNeedsLayout ?

super.systemFontsDidChange() calls markNeedsLayout AFAIK.


Wrong dependency reactive resilience4j name in https://spring.io/projects/spring-cloud-circuitbreaker

In documentation  https://spring.io/projects/spring-cloud-circuitbreaker, the dependency name for
Reactive Resilience4J is misspelled: org.springframework.cloud:spring-cloud-starter-circuitbreaker-reator-resilience4j

Fixed thanks!


Better messageset not found handling

Doesn't handle messageset not being found gracefully. See: http://sentry.mama.ng.p16n.org/sentry/hellomama-ng-qa-registration-c/issues/20/

Also make this change in familyconnect-registration


Auto Saving with Draft.js and Redux

Hi!
I have recently came across draft.js and love it! I just have one small little speed bump. I want to build an auto save like google doc. I was thinking whenever onChange is triggered, I store a raw content state and send it up to the server. But doing so hits performance pretty hard and seems inefficient. How can I get incremental saves? Should I just use a setInterval()? I'm sure there is a smarter way to do this...

I would probably "debounce" the callback so that changes get saved after the user stops typing for, say, 3 seconds. What sort of smarter logic would you want?

I remember watching the draft.js video and the person talked about how the undo and redo was able to throw out intermediate states in the stack and only keep the important ones. Is there a way I can tap into this logic and trigger saves at these increments?

Hey So I am currently using the debounce callback. I just have a small issue. I need to still store the editor state in the component. So in my on change function i have
()=>{debounce(this.save,3000)();this.setState({...});}
the problem is if the onChange is triggered twice, the debounce would wait 3s and trigger twice. Instead of once. What am I doing wrong?

Closing Issue, I looked up how debounce works and placed it in the state so the scope is consistent. Thanks @spicyj!

@dave4506 Could you share your solution please? Did you also try the strategy mentioned in your second comment above?

Hey! I simply used the debounce method. I didn't look into the second method as the debounce is already effective and can't find what I was talking about in the docs.I pulled off the debounce by...
this.state = {saveEditorState:debounce(this.save,3000)} and within the onChange function that is called, i have it execute this.state.saveEditorState(params).

Whilst the debounce will surely ensure that a save endpoint is not spammed... the issue that I am seeing is that the editor's onChange event is triggered for many non-editing scenarios that I would like to ignore. For example, as the cursor location changes, the onChange method will trigger a save.
Is there a way to ignore selection changes in triggering onChange?

Just found an answer for my above question by @hellendag in https://github.com/facebook/draft-js/issues/233#issuecomment-201702255:
onChange(editorState) {
  if (editorState.getCurrentContent() !== this.state.editorState.getCurrentContent()) {
    // content has changed
  }
  if (editorState.getSelection() !== this.state.editorState.getSelection()) {
    // selection has changed
  }
}

@hadynz @dave4506 How do you get the incremental saves in your solutions? Or did you save the whole editor state every time?


Replace TemporaryFile with io.BytesIO in update_result

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

I just checked the refactor-intermediate branch, and it seems there in refactor/upload_pkl_file.py I'm using,
response = requests.post(
    url=url_endpoint, files={"result_pkl_file": BytesIO(pickle.dumps(result_object))}
)

to send the file to the result service, that endpoint expects UploadFile type object (can be seen in refactor/results/app/api/api_v0/endpoints/workflow.py) and that seems to work.
And as we can see in refactor/data/app/api/api_v0/endpoints/fs.py the upload_file also expects UploadFile, so shouldn't BytesIO work for uploading a file as well?


Support for tasks that depend on previous results.

 Unfortunately, this means that Queue doesn’t really help you escape callback hell if each task depends on the previous task. For example, if you had this:
function complexTask(callback) {
  computeOne(function(error, one) {
    if (error) return void callback(error);
    computeTwo(one, function(error, two) {
      if (error) return void callback(error);
      computeThree(two, function(error, three) {
        if (error) return void callback(error);
        callback(null, three);
      });
    });
  });
}

Queue doesn’t really help you… I mean, you could do something like this, but it’s a hideous hack, and it’s so verbose I don’t think it qualifies as “helping”:
var one,
    two,
    three;

function complexTask(callback) {
  d3.queue(1)
      .defer(function(callback) {
        computeOne(function(error, result) {
          if (error) return void callback(error);
          one = result;
        });
      })
      .defer(function(callback) {
        computeTwo(one, function(error, result) {
          if (error) return void callback(error);
          two = result;
        });
      })
      .defer(function(callback) {
        computeThree(two, function(error, result) {
          if (error) return void callback(error);
          three = result;
        });
      })
      .await(function(error) {
        if (error) return void callback(error);
        callback(null, three)
      });
}

There was a nice suggestion in #20 of a clone of promise.then, which might look like this:
d3.then(function(callback) {
  d3.queue(1)
      .defer(getSettings)
      .defer(gitInit)
      .defer(gitRemoteOriginDoesNotExist)
      .defer(gitListUntrackedFiles)
      .await(callback);
}).then(function(settings, _, _, files, callback) {
  d3.queue(1)
      .defer(confirmFiles, files)
      .defer(gitAdd, files)
      .defer(gitCommit)
      .defer(createGist, settings.token)
      .await(callback);
}).then(function(_, _, _, id, next) {
  d3.queue(1)
      .defer(gitRemoteAdd, id)
      .defer(gitPush)
      .defer(openBrowser, id)
      .await(callback);
});

But, there are some related questions:

[ ] Does d3.then return a Promise? (Probably not, see below…)

[ ] Does d3.then take a onfulfilled handler and an optional onrejected handler like promise.then? Or does it take a single callback, which receives the error as the first argument? Or does d3.then return an object with a promise.catch-like function?

[ ] Does it allow the callback to receive multiple values? (Probably it must, based on the above example…)

[ ] Does d3.then return an object with an abort method? Does it then perhaps call abort on the return value of then function passed to d3.then? Is there a way to abort a then sequence like you can abort a queue?

As much as I struggle with adopting Promises (because they are not yet available everywhere and I don’t see a safe adoption strategy), I’m also wary of re-inventing nonstandard Promises. So I think it’s best to avoid wading into these waters and leave d3-queue to focus only on the configurable concurrency aspect. Plus, in practice I’ve never felt a strong need for the API proposed in this issue to implement a D3 visualization.


Adds Endpoint.toString in json form

This is helpful for debugging instrumentation, particularly their local
endpoints.
See https://github.com/openzipkin/brave/pull/245

cc @schlosna this is a nicer way to fix brave, imho.. just convert brave's endpoint to this, then toString it.


upgrade to rustls 0.22.1, tokio-rustls 0.25.0

I'm not sure if there's any interest in doing this, because it would be a major breaking change and the 0.6 release just went out a few weeks ago.
But since I went through the motions of making it work, I figured I'd at least post this so others could decide whether this change was desirable.
I have tested it in my own axum project, and it seemed to work, but I can't attest to more than that.

What is the status of this thing? I had to revert to rustls 0.21 because of the incompatibilities.

rustls 0.23 is out now, so this PR is probably not of much use except as a starting point for working on the next upgrade.

Thanks for this; we are adopted these changes as a patch in our crate graph during our process of upgrading to<EMAIL_ADDRESS>Major parts of the ecosystem haven't upgraded to 0.23 yet (including crates like reqwest and hyper-rustls), and if others have a relatively deep integration with rustls like us, they will have issues with client and server TLS configs being incompatible. Because of this, there is value in merging this so there is a version of axum-server published on crates.io that uses<EMAIL_ADDRESS>But maybe this is a problem experienced only by a marginal number of users which happens to include us. We've worked around it anyhow; just sharing our perspective.


Modified the log level of RocketMQProducerMessageHandler.

The log level here should be debug.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM.


Documentation tidy

Re formats the api reference in init.py. Fixed up support link to point to forums.
Fixes examples and related documentation with new information/workarounds for changes in vehicle behaviour in AC3.3.

@tcr3dr This is a bunch of fixes to docs. I still haven't retested all of the examples ...but you can choose to merge this earlier if it makes things easier for other work you're doing.


Added project management section to README

Project management section added to the code. Please review @lford93.

I have added further detail to the README with commit 2b76a. Happy for pull request.


Ll zip

[x] Write a function called zipLists which takes two linked lists as arguments. Zip the two linked lists together into one so that the nodes alternate between the two lists and return a reference to the head of the zipped list.
[ ] try and keep additional space down to O(1). You have access to the Node class and all the properties on the Linked List class as well as the methods created in previous challenges.


Put templates in another folder and reference from Angular code

Potentially a partials folder in resources/static.  Figure out how to reference correctly from angular.

Root for the templates is resources/static


[Griff's feedback] For badgholders: Show modal on categories page and add update ballot to success attestation.

[ ] Modal for guiding bagholders from categories page: https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6-->-Voting-App?node-id=2244-85883&t=Fp3yTlMadXVi0DGb-1 (it's the high fidelity link @markoprljic )

Ready for review https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6-->-Voting-App?node-id=2244-85883&t=Fp3yTlMadXVi0DGb-1

@Meriem-BM please take a look.
The second to-do item  might be done by @HrithikSampson , the difference is if we detect user is bagholder we should have that button after success attestation and farcast suggestion. Please double check with @Meriem-BM

Hey @maryjaf this is ready for test, thanks

There is a problem related to login with email , when I got an error in connecting email flow, by closing the modal i can continue ranking
please take a look on below screen record : @Meriem-BM https://github.com/user-attachments/assets/3eef9b1c-8414-4875-aef0-e62c743a53f3

Thanks, made a fix, if you can check

I've tested again, but by closing the below modal , I can continue voting

https://github.com/user-attachments/assets/55f3b797-8282-474a-b9a1-fb948fb4023d
@Meriem-BM

I've tested again, but by closing the below modal , I can continue voting

Thanks, made a fix if you can test again

Thanks, @Meriem-BM!
Currently, users are unable to close this modal, and there's no option to navigate back to the allocation page or the connect email modal. This feels like a UX issue that needs to be addressed.

Can you test this @maryjaf

Thanks @Meriem-BM it works correctly
If user select a wrong email, they can close the modal by tapping on close icon, and the connect email modal will repon by tapping on any button in ranking page
this is new behavior, is this acceptedin point of your view? @MoeNick @markoprljic
https://github.com/user-attachments/assets/d00c1182-62e0-4f03-8640-ee7a14be0584


Some algorithm parameters have incorrect ids in the simulators database

Ids should have the pattern KISAO_000... rather than 000.... This is why some of the links are working (#1299).

The BioNetGen and COPASI metadata were missing KISAO_ prefixes. I fixed this in the simulator container repos.

I tried to use the simulators API to update the database. But I received this error:
{
  "statusCode": 409,
  "message": "Conflict",
  "error": "Database Error"
}

Used API to retrieve info about BioNetGen
Extracted the single record from the returned array
Added missing KISAO_ prefix
Authenticated to API with Google credentials
Tried to used the POST /simulators endpoint to submit the single entry

These have been updated. I was unable to reproduce the error you got. If a simulator with the same id/version already exists it should give you a 409. However the error should be more descriptive.
I believe this error may have been caused by the incorrect structure for the citations as mentioned in #1311

This is now fixed. I guess you replaced the metadata in the database.
Its hard to understand exactly what's going because the data in the databases didn't match the data model and the error message isn't informative.


[bug] when i send link bot brokes.

(node:12232) UnhandledPromiseRejectionWarning: Error: Evaluation failed: TypeError: Cannot read property 'href' of undefined
at puppeteer_evaluation_script:3:38
at ExecutionContext._evaluateInternal (/root/tiktok/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:217:19)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async ExecutionContext.evaluate (/root/tiktok/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:106:16)
(Use node --trace-warnings ... to show where the warning was created)
(node:12232) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:12232) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

can you please fix this <3 @juuyokka


Add colour scheme a la gapminder

The gapminder data package offers only 2 functions, one for calling a data frame visualizing names and prefixes and, the other, for state colors code to be used with ggplot2.  We should look into the functions as possible ideas for our data packages.

Update 18.01.2021
Looked into the issue and read various book chapters (namely this one which is a reference for mapping in R) and found this issue to be more on the user level. In my view, users will define colors in the analysis step based on the final table they will have analyzed by using one or more datasets from our packages.
What I could do at this stage is to generate a vector of random unique colors but I am not sure that this will be really useful for the user. It would be really useful to have a use case for this issue before moving on.

Update 18.01.2021
Looked into the issue and read various book chapters (namely this one which is a reference for mapping in R) and found this issue to be more on the user level. In my view, users will define colors in the analysis step based on the final table they will have analyzed by using one or more datasets from our packages.
What I could do at this stage is to generate a vector of random unique colors but I am not sure that this will be really useful for the user. It would be really useful to have a use case for this issue before moving on.


Sample circle point in a Bitcoin-friendly way and reenable large blowup

This PR first replaces the circle point sampling algorithm with one that is Bitcoin-friendly. Then, separately, it reverts two changes in stwo that limits the blowup factor to 2^1.

Note that this PR mainly reverts two PRs on stwo, and we are mainly waiting for stwo to move into an implementation that supports larger blowup factors.
https://github.com/starkware-libs/stwo/pull/598
https://github.com/starkware-libs/stwo/pull/619


Update AKS locations

What kind of request is this (question/bug/enhancement/feature request):
enhancement
Steps to reproduce (least amount of steps as possible):
Update list of locations for AKS

Version: master 2.2 (1/2/19)
Confirmed enhancement.
The new locations have now been added to the "Location" drop-down when creating an AKS cluster:
East Asia, South India, Southeast Asia, and UK West
I made sure the previous were also listed and validated HTTP. I smoke tested creating AKS clusters with some of these locations.


fix no-redundant-story-name

Issue: #
What Changed

Fix scenario where users use CSF3 + spread operator
Checklist
Check the ones applicable to your change:

[x] Tests are updated
[ ] Documentation is updated

Change Type
Indicate the type of change your pull request is:

[ ] documentation
[x] patch
[ ] minor
[ ] major

self merging @shilman


Wrong URI leads to misleading error message in lpadmin

Hi,
I use a wrong URI with lpadmin. I got the error

Unable to create PPD file: No such file or directory

but basically it was the wrong URI, that lead to an maybe unexpected return value in the ippserver.

Get-Printer-Attributes client-error-not-found ("printer-uri" 'ipp://<IP_ADDRESS>:8000/print/ipp' not found.

# lpadmin -p myIppPrinter2 -v ipp://<IP_ADDRESS>:8000/print/ipp -m everywhere
lpadmin: Unable to create PPD file: No such file or directory
# lpadmin -p myIppPrinter2 -v ipp://<IP_ADDRESS>:8000/ipp/print -m everywhere

[use@test server]# ./ippserver -v -c cat "test"
2018-08-06T10:19:33.992Z  Using default configuration with a single printer.
2018-08-06T10:19:34.006Z  Using default data directory "/tmp/ippserver.2177".
2018-08-06T10:19:34.007Z  Using default spool directory "/tmp/ippserver.2177".
2018-08-06T10:19:34.008Z  Using default listeners for test:8000.
2018-08-06T10:19:34.022Z  [Printer test] printer-uri="ipp://test:8000/ipp/print"
2018-08-06T10:19:52.820Z  [Client 1] Accepted connection from "<IP_ADDRESS>".
2018-08-06T10:19:52.823Z  [Client 1] POST /print/ipp
2018-08-06T10:19:52.825Z  [Client 1] Continue
2018-08-06T10:19:52.826Z  [Client 1] Get-Printer-Attributes client-error-not-found (\"printer-uri\" \'ipp://<IP_ADDRESS>:8000/print/ipp\' not found.)
2018-08-06T10:19:52.827Z  [Client 1] OK
2018-08-06T10:19:52.831Z  [Client 1] Client closed connection.
2018-08-06T10:19:52.831Z  [Client 1] Closing connection from "<IP_ADDRESS>".

This is basically the line printing the error.
Unable to create PPD file
Maybe we can get something out of the _ipp_t response to produce a better error message.

I'll take a look at our options - lpadmin should be reporting the error message from the Get-Printer-Attributes request and not the generic one we currently have.


Compute forward difference with Dask DataFrame

I'm really excited about Dask.  A huge THANK YOU to all the contributors :)
I'd like to make a feature request for a new method: dask.DataFrame.diff(). It would work like pandas.DataFrame.diff().
Mathematically, the operation is very simple: subtract a column vector from a copy of itself shifted by one or more rows.
I have tried implementing diff() using Dask in the following ways, none of which works (yet):

df - df.shift(periods=1) works in Pandas.  But Dask DataFrame doesn't have a shift() method.
df.values[:-1] - df.values[1:] works in Pandas.  But I can't see how to index into a Dask DataFrame by position.

My current best idea for implementing diff would be to wrap some custom code in dask.dataframe.rolling.wrap_rolling, as suggested in this stack overflow answer (although I haven't been able to find any documentation on how to do this).  Or wrap some custom code using Dask Delayed?  Any other thoughts?

It would be nice to have a higher level function around rolling that accepted user defined functions, much in the same way we do for reduction today.

That would be amazing!  The project I'm working on (NILMTK) requires quite a few custom 'rolling' functions.  So it would be amazing to be able to supply these custom functions to Dask in a simple way, without having to reach into Dask's innards for each new function.

Sure, I can take this on. Definitely agree that a general purpose function would be good here.

See #1769.


Bump to the latest tc artifacts

Unable to merge, build status not reported (FYI @akomakom @chrisdennis you might want to force the merge).


AutoForm.find undefined after update to AutoForm 5.0

I updated my project to AutoForm 5.0 and I'm using this package to upload files but i'm having this problem for the three field that are included in my form:
Exception from Tracker afterFlush function: undefined is not a function
TypeError: undefined is not a function
    at Template.cfsFileField_bootstrap3.rendered.Template.cfsFilesField_bootstrap3.rendered

I debug the problem and I track it until this code in cfs-autoform.js
  Template["cfsFilesField_bootstrap3"].rendered = function () {
    var d = AutoForm.find(); <-------

I checked the version and it's the latest 2.1.1, is there a way to get this working or should i wait to update my package until this is fixed??
Thanks in advance...

Have not yet updated this pkg for 5.0. Can probably remove that line and do var formId = AutoForm.getFormId().

Is there an ETA for the update??

I have the same problem. No Uploads anymore.

+1 on an update to 5.0

I still need to coordinate with @aldeed on the official release, but I've been working on an enhanced 5.0 version.  It's not ready for prime time yet, but it could use some beta testing to work through uses cases, etc..  I'm sure there are use cases that I have not considered.  If you're interested in testing it, the repo is [here][https://github.com/dpankros/meteor-cfs-autoform] (Eventually, it should be pushed back into this repo.)  Sorry, but I have not updated the docs, but they should be pretty close.
You can also check out the [testing app][https://github.com/dpankros/cfs-autoform-test] for some more information and for use as an example.  You'll have to test it as if you are developing a package because I don't want to publish it officially in atmosphere yet.  This is really beta (or alpha) right now.  In other words, expect quirky behavior at times.
As a teaser, the new version supports asynchronous uploads or "on submit" uploads, as well as thumbnails for images, dedicated thumbnail stores (in mongo).  Individual files can be removed or added for collections of files (using cvs-files) too.

Feedback:  I've tested @dpankros package in our local, test and UAT environments and it performed well for each of our uses.

@dpankros does your fork support uploading multiple files? ( issue #20)

@dpankros Is it possible to implement a progress bar with your fork?

@theduke It should.  I have done this in the testing app and it works, but I have not compared with the current release of cfs-autoform to see if the behavior is different.

@mdebus Yes, that should be possible.  Currently, text will appear when uploading showing percent complete.  When it completes, the text disappears.  This should be able to be swapped out for a progress bar.  To be honest, I looked at this for a few minutes and decided to focus on functionality over design right now.  I won't be spending time on adding a progress bar until after it is officially released, however.

@careerlister Great.  Thanks for the feedback.

@dpankros In your new package, Cancel of the file picker after it has already been used (input control has a file name) triggers a change event with no files.   Easy to repro.  Upload a file.  Relaunch the file picker but cancel the dialog.  A change event is raised and CfsAutoForm.singleHandler does not deal with it  well (infinite loop trying to process a file that is not there).   I put a simple guard in
if(files.length === 0)
return
and it seems fine.  I couldn't get multiple files to work (type="cfs-files' didn't work) so I didn't test .multipleHandler,  though I suspect it has the same problem.
Thanks for your work ... its really needed!

@stocksp Interesting.  The quick form version of an insert form doesn't have a cancel button and so I never tried it as I was using a quick form in my testing app.  You must be using an autoform, right?  I'll try to put in a fix in this weekend, if I have time.
On another note, it wasn't my intent to hijack this thread, though it seems that was the net-effect.  (Sorry, @aldeed) For other comments about my fork, bugs, etc, please comment directly on my forked repo.  I don't want to create more noise here than is necessary and I want to keep the discussion on track, if possible.  If bugs need to be recreated after a merge (i.e. bugs submitted on my fork that may be applicable after a merge back to this repo), then I'll recreate them at that time (probably not with a full message history, however).  Thanks!

@dpankros  I don't see an 'issues' button in your forked repro or I would have posted there.  Yes, my template uses the autoform html found in the sample.  When I say cancel button,  I'm talking about the file picker dialog the browser puts up ... which always has I cancel button.

@stocksp I didn't realize that was an option I had to turn on.  You should be able to report issues directly now.  Sorry about that. facepalm

Original issue should be fixed in 2.1.2 release.


add security manager test

What type of PR is this?
/kind feature

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@lec-bit You should rebase

TestFileSecrets ?  Can you name it with real meaning


Is it possible to run 2 instances of wsld?

Hello! I've been using WSLD on Ubuntu 20.04 and it's been working wonderfully! I'm wondering though if it is at all possible to run 2 instances of VcXsrv Server corresponding to 2 different distros?
I'm asking because I'm just recently trying Arch on WSL 2 and as I'm playing around with both instances of WSL, I was wondering if I could make wsld work for both instances simultaneously?
So far, I tried setting the DISPLAY of the first instance (Ubuntu) to =:0 and the 2nd instance (Arch) to =:1, but I could not make it work for the Arch instance.
One thing I checked though is that /tmp/.X0-lock for the Arch instance is not corresponding to the PID of wsld. So I'm assuming I'm doing something wrong with the setup. Or perhaps it's not possible?
Thank you and you have a great day!

There shouldn't be any blockers preventing multiple instances of wsld being used. I don't have multiple distros installed so I am not certain what's wrong there.
How did you configure .wsld.toml and environment variables in Arch?

Hello Gary,
I wasn't able to correctly configure both distros to run side-by-side with 2 WSLD's. I can only manage to run one correctly. I was able to migrate all the things I needed from Ubuntu to Arch on that same day, so I didn't need to run X on the Ubuntu distro anymore (I'm still running Ubuntu in a terminal to run some services because I had issues with WSLArch and Systemd). But as far as Arch and WSLD, they are both running perfectly ever since! In fact, it's running even better now probably because of your latest updates and me understanding even better how WSLD works with these distros. :D
I will, however, re-visit this when I install another distro which I'm planning to do in the next couple of months and see if I can indeed run multiple instances of WSLD's and distros. I'll let you know when that time comes. :)

Hello Gary,
I wasn't able to correctly configure both distros to run side-by-side with 2 WSLD's. I can only manage to run one correctly. I was able to migrate all the things I needed from Ubuntu to Arch on that same day, so I didn't need to run X on the Ubuntu distro anymore (I'm still running Ubuntu in a terminal to run some services because I had issues with WSLArch and Systemd). But as far as Arch and WSLD, they are both running perfectly ever since! In fact, it's running even better now probably because of your latest updates and me understanding even better how WSLD works with these distros. :D
I will, however, re-visit this when I install another distro which I'm planning to do in the next couple of months and see if I can indeed run multiple instances of WSLD's and distros. I'll let you know when that time comes. :)

Could u please help me to config wsld in arch or manjaro. Wsld doesn't work well in my computer.

Hello Gary,
I wasn't able to correctly configure both distros to run side-by-side with 2 WSLD's. I can only manage to run one correctly. I was able to migrate all the things I needed from Ubuntu to Arch on that same day, so I didn't need to run X on the Ubuntu distro anymore (I'm still running Ubuntu in a terminal to run some services because I had issues with WSLArch and Systemd). But as far as Arch and WSLD, they are both running perfectly ever since! In fact, it's running even better now probably because of your latest updates and me understanding even better how WSLD works with these distros. :D
I will, however, re-visit this when I install another distro which I'm planning to do in the next couple of months and see if I can indeed run multiple instances of WSLD's and distros. I'll let you know when that time comes. :)

Could u please help me to config wsld in arch or manjaro. Wsld doesn't work well in my computer.

Hey @JYInMyHeart , the defining moment for me was applying the autostartup  setup. Once I did that, things have been working correctly. In my Arch install, I added the codes in this sample to my .bash_profile. Then I just made sure that both of these following files have the ownership and group to my user name: /tmp/.X0-lock and /tmp/.X11-Unix/X0. I also gave /tmp/.X11-Unix/X0 file the full 777 permission.


Function _get_source doesn't work in the python console of PyCharm

If I try running the following in the python console in PyCharm
from lf import lf
lf.trans(lambda x: x)

I get the error
Traceback (most recent call last):
  File "/Users/sebastianlee/Aleph-One-Gmbh/lf/lf/lf.py", line 204, in _wrap_lambda
    full_source = caller_frame.f_globals['_lf_source']
KeyError: '_lf_source'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/Users/sebastianlee/Aleph-One-Gmbh/lf/lf/lf.py", line 62, in _get_source
    return ''.join(linecache.cache[filename][2])
KeyError: '<input>'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/sebastianlee/Aleph-One-Gmbh/lf/lf/lf.py", line 250, in trans
    return _wrap_lambda(fun_or_cls)
  File "/Users/sebastianlee/Aleph-One-Gmbh/lf/lf/lf.py", line 206, in _wrap_lambda
    full_source = _get_source(caller_frame.f_code.co_filename)
  File "/Users/sebastianlee/Aleph-One-Gmbh/lf/lf/lf.py", line 65, in _get_source
    with open(filename) as f:
FileNotFoundError: [Errno 2] No such file or directory: '<input>'

This works with the current version of PADL, with no changes required.


Handle 401 Not Authorized Response

This was mentioned in #135. This PR provides support for surfacing the fact that the server returned a 401.

Thanks!

Cheers @chingor13 !


compress() not working

Summary

the .compress(size) function is not working. It is returning image with orignal size
Code to reproduce

 ImagePicker.with(this)
            .crop() //Crop image(Optional), Check Customization for more option
            .galleryOnly()
            .compress(512)            //Final image size will be less than 1 MB(Optional)
            .maxResultSize(
                1080,
                1080
            )    //Final image resolution will be less than 1080 x 1080(Optional)
            .start

Android version

Android 10
Impacted devices

RedMi 9
Installation method

  //Android Image Cropper
    implementation 'com.github.dhaval2404:imagepicker:1.8'
    implementation 'com.github.CanHub:Android-Image-Cropper:2.1.1'
    implementation 'com.github.florent37:inline-activity-result-kotlin:1.0.4'

SDK version

30
Other information

@chnouman This is a known issue in v1.8 and has been resolved now in v2.0. Please give it a try.


Brightness swipe guesture behavior on Fairphone 4 not straight forward

Sometimes during video watching I like to drop the brightness to minimum. On Fairphone 4 5G (FP4) the brightness drops as I swipe down on the left side of the screen until a few millimeters before the bottom edge and then suddenly raises again. It is not at maximum but still quite brighter then before. That makes it tedious to use.
The reason for me to drop the brightness in the first place is a) to not blind me in when I am sitting in the dark b) to reduce keeping me awake when I watch video before going to sleep and c) to reduce energy consumption.
I don't have this issue on my old device. The main differences between both devices are that the new FP4 has an LCD and runs android 11 while the old device has an OLED and runs android 6.0 .
I hope that the bug(?) will be fixed so that the behavior of the swipe gesture will be straight forward, meaning that the brightness continually drops as I swipe down on the left side of the display without suddenly brightness going up.
Thanks in advance. :)

I cannot reproduce this on my test device and will check the emulators.

Finally: The Oneplus 3 shows the same bahaviour - this is a task for my next debugging session.

This seems to be a device specific android bug. Setting WindowManager.LayoutParams.screenBrightness to 0 may cause the screen on some devices to get brighter. Zapp has no means to know, which devices are affected.
So we habe two options here:

Limit the screen brightness to 1% minimum for all devices (like VLC)
Use the "correct" behaviour and accect the bug on some devices

I am not an Android developer but AFAICS there is no bug filed for this:
https://issuetracker.google.com/issues?q=screenbrightness componentid:(192786 | 192805 | 192705 | 192792 | 192644 | 192694 | 192710 | 192810 | 192634 | 192698 | 192706 | 470386 | 192815 | 192715 | 192720 | 192711 | 192629 | 192643 | 192693 | 192639)

So we habe two options here:
1. Limit the screen brightness to 1% minimum for all devices (like VLC)

2. Use the "correct" behaviour and accect the bug on some devices

I found that the Sony ZX1 or XZ1 is also affected. I can't see a pattern by display technology so I think we can't estimate how many devices are affected. Hence it would be hard to say how many users will face this issue. I guess only a minority of users will drop the brightness so far. Under that assumption proposal No. 2 would not be optimal but not catastrophic.
Regarding proposal No. 1 I would ask: How big is the difference between brightness of 0% and brightness of 1% for energy consumption, blending users in the dark and keeping them awake when they use Zapp before going to sleep. If the differences in these criteria are minor this approach might be better to cover all users.
What does minimum brightness actually mean? The answer might depend on display technology. Doesn't LCD IPS displays have LEDs behind the panel so bright that they shine through? A minimum value for those LEDs might mean to switch them off. In that case external lights would be needed to recognize something on the screen. Doesn't OLEDs miss those LEDs because the OLED pixels shine themselves? Can they be switches off, too? That are just questions that came to my mind when thinking about the API.

I am not an Android developer but AFAICS there is no bug filed for this

This is because even Android developers have no idea in which of the many bugtrackers exactly to file bugs ;)

Regarding proposal No. 1 I would ask: How big is the difference between brightness of 0% and brightness of 1% for energy consumption.

This last step (from 1% to 0%) is quite substantial - at least visually. It might be desired to have a very, very dark screen when watching in very dark environments.

Okay, I'll leave it as it is now. The few affected users can easily work araound this bug.


Change Docker Hub link to a public URL

The current one takes me to a login page, and seems a bit unusual for Docker Hub.

Nice, thank you!


sprockets v4 breaks asset pipeline; pin for now, work through later

Fixes # .
Changes proposed in this PR:

sprokets v4 breaks current asset pipeline, as temp fix pin to v3 and then add issue to work through changes later

tests are failing but that's because of brakeman issues in the branch (not just the PR)

closing this out since master's tests are broken at the moment and will not allow the merge. Submitted https://github.com/DMPRoadmap/roadmap/pull/2348 instead to development


compilation log

hellow harpywar download log
http://www.mediafire.com/download/0udh17b8mf2l2t5/log.rar
regards

I can't figure out what's wrong from these logs - these are not enough. I've tested Magic Builder on both x86 and x64 Windows 10 and it worked without any problems.
May be this error occured due an unfinished Visual Studio installation. Try repeat install to repair it.
If the issue related to https://github.com/pvpgn/pvpgn-server/issues/174 then you should attach two more log files according to the info https://github.com/pvpgn/pvpgn-magic-builder/wiki/Diagnosis-of-problems.


USHIFT-1520: show LVMS bundle source in rebase output for debugging

The ART pipeline does not report which inputs it passes to the rebase
script on its own, so we need to add details to aid in debugging build
failures.
/assign @copejon

/lgtm


feat(pg): enable COPY FROM STDIN

This PR adds support for PostgreSQL's COPY FROM STDIN command.
$ psql -h <IP_ADDRESS> -U mysql db01

db01=> \copy t from './t.csv' WITH DELIMITER ',' CSV HEADER;
COPY 12
db01=> select * from t;
 id |  s   |  j
----+------+------
 11 | aa   |   12
 12 | bb   |   23
 13 | cc   |   34
 14 | dd   |   45
 15 | ee   |   56
 16 | ff   |   67
 17 | gg   |   78
 18 | hh   |   89
 19 | ii   |  100
 20 | jj   | 1011
 21 | k\tk | 1213
 22 | l\tl | 1415

How about adding some tests for this feature?

@TianyuZhang1214 Done. I have added a basic test. In the next step, we should introduce some sqllogictest-like tools.


Add clinic & DCAF pledge amount to Pledge Fulfillment page

This pull request makes the following changes:

Adds clinic name & DCAF soft pledge to the pledge fulfillment form for less short-term memory exhaustion when processing pledge fulfillment forms. :thinking:

Here's what it looks like:

It relates to the following issue #s:

Fixes #905

This is a nice little add for our accountant. Thanks! cc: @eheintzelman

@lilliealbert want you to know that I entered a set of fulfillments the other day and this improved my experience a LOT. Thank you!


docs: fix adeo-kafka-request-reply-asyncapi.yml

Replace example with examples
Reference: https://github.com/asyncapi/spec/issues/1031

/rtm


chore(deps): update curl

@CASician this should fix your issue

Yes! Thank you!

:tada: This PR is included in version 1.34.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Views] - Implement Shadow widget (resolves #31)

This PR adds a Shadow widget to mimic the behavior of the SwiftUI .shadow modifier method. The reason for implementing Shadow as a composable Widget rather than a property on a shape is that SwiftUI's shadow is a View modifier method. You can add a shadow to anything in SwiftUI, not just a shape.
You can see the results below. SwiftUI is first and Flutter second:

Because non-rectangular shapes can have shadows, I wasn't able to use Flutter's BoxShadow.
Shadow itself is a composite of a few new widgets:

Blur
Tint
Desaturate

I haven't exported those widgets yet, but tint is another SwiftUI property, so we may want to export this widget as well in the future.
I discovered I had made a mistake on the Rectangle stroke. It actually is centered on the edge line, not contained completely within the rectangle. I had missed that before because of SwiftUI's clipping behavior. This means that Ellipse and Rectangle have the same stroke behavior. I snuck this fix into this PR since it related to drawing shadows. You can see the width of the rectangle with the thick stroke is wider than the other rectangles. This is the proper behavior:

@matthew-carroll Pinging you on this in case you didn't see it earlier.

@matthew-carroll Ready for another review.


Fix issues related to transaction displaying

This PR is fixing three different problems:

two of them were missed in #1706  (one of them was previously fixed in #1658)

transactions with AE token symbol was showed as AE coin
there were no labels for token transfer transaction

there we no labels for the pending transfer transactions

LGTM.


BACKPORT: Add support for setting sysctls

BACKPORT: Add support for setting sysctls
This patch will allow users to specify namespace specific "kernel parameters"
for running inside of a container.
Signed-off-by: Dan Walsh<EMAIL_ADDRESS>

LGTM

LGTM


Converter ignores prefixes, enums and sign leading separate pics

The following will be ignored (tolerated):
a) Prefixes: 00 'Prefix-'NAME PIC ...
b) Enums: 88 ...
c) ... PIC S9(5) SIGN LEADING SEPARATE

I've just learned that we want SIGN LEADING SEPARATE not only ignored, but handled. An update is following.

We've found a different solution for our problem, so we dont need that changes anymore.


feat: Extract useInfiniteQueries / useQuery to custom hook

Describe the feature you'd like to request
Refactor react queries with custom hooks.
Describe the solution you'd like to see
Use custom hook like https://github.com/ArkProjectNFTs/ark-market/blob/main/apps/arkmarket/src/hooks/useCollection.tsx .
Additional information
No response

Hello @gershon please i will like to work on this by tomorrow when the OD hack begins

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi!! I'm a fullstack dev focused on frontend development, with 4 years of experience building web and mobile apps and a couple months into web3 development. I have build some next.js apps in the past of course using react query.
How I plan on tackling this issue
I will look for all "not-hooked" implementations using vscode search functionality (example in image)

Then, I will start creating the corresponding hooks into apps/arkmarket/src/hooks/ folder
Of course I will pay special attention to make code as reusable as possible, for example, the queries on "mobile-global-search.tsx" and "global-search.tsx" looks almost identical, so I can create a single hook "useSearchCollection" that work for both implementations.
This is a quick summary of the hooks I'll be implementing, based on useQuery usage:
For useQuery implementation:

useCollection (I saw it's already into a hook on the issue description example)
useCollectionTraits
useTokenMarketData
useSearchCollection
useSystemStatus

And for useInfiniteQuery:

useCollectionActivity
useTokenActivity
useTokenOffers
useWalletActivity
useWalletCollections
useWalletOffers
useWalletTokens

And any other if I forgot someone
Stimated time to complete the issue -> less than 1-2 days, this should be ready for weekend or even before.
🚀I look forward to contribute, I'm attentive🚀

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have a solid background in TypeScript and React development, with experience in creating custom hooks for efficient state management and data fetching. This expertise will enable me to effectively refactor the existing queries into reusable hooks, enhancing the project's maintainability.
How I plan on tackling this issue
I would start by analyzing the current implementation of useInfiniteQueries and useQuery to understand their functionalities. Then, I’d create custom hooks similar to the provided example, ensuring they handle the necessary parameters and return values. I would test the hooks thoroughly to confirm they integrate seamlessly with the existing components

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have a strong background in React development, focusing on state management and custom hooks. I am experienced in optimizing data fetching and managing server state using React Query.
How I plan on tackling this issue
Review Existing Queries: Analyze the current React queries in the codebase to identify areas for refactoring.
Design Custom Hooks: Create custom hooks similar to useCollection.tsx to encapsulate data fetching logic and improve reusability.
Implement Hooks: Replace existing queries with the new custom hooks across components.
Test Functionality: Ensure that the new hooks work as expected and maintain the same functionality.
Document Changes: Update documentation to reflect the new custom hooks and their usage.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I'm Qudus Adeyemi, a front-end developer with 2 years of experience in React, TypeScript, and JavaScript, specializing in building pixel-perfect, interactive user interfaces. During the previous OD Hackathon, I contributed by enhancing the Starknet React documentation and implementing the useWatchAssets hook to improve wallet tracking. I also have strong experience with React Query and have successfully applied it in various projects to handle complex use cases.
I’m genuinely excited about this opportunity to deepen my knowledge of Web3 technologies and to contribute to your project. I believe my experience, enthusiasm for learning, and problem-solving skills would make me a strong fit for this task.
I estimate the task will take around 2-3 days to complete and I would love the chance to collaborate with the team. Thank you for considering my application!
How I plan on tackling this issue

Clone the project to my local machine.
Set up the project by following the provided documentation.
Review the existing codebase to understand how current hooks are implemented, particularly focusing on the useCollection hook as a guide.
Plan the extraction process and identify all necessary queries to be included in custom hooks.
Implement the custom hook.
Thoroughly test the hook to ensure it functions as expected.
Document the hook for future reference and ease of use.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have experience with React, TypeScript, and React Query. I’ve worked on refactoring components and extracting logic into reusable custom hooks for better code maintainability.
How I plan on tackling this issue
I’d start by analyzing the current implementation of useInfiniteQueries and useQuery. I’d then refactor the logic into a custom hook, ensuring it’s reusable and follows best practices, similar to the approach used in the provided example.

Hi! @gershon is this issue still available?

@gershon Hi, can I pick this up?

@jorgezerpa I just assigned you 👍🏽 Please also take into consideration useInfiniteQuery, useSuspenseQuery and useSuspenseInfiniteQuery 🙂

@YohanTz Thanks🙂 I got it! I'll start working

Hello @YohanTz
should I have to replace the queries with the created hooks (example: create useCollection hook and then use it where is appropriate) or just create the hooks without implementing them?

Hello @YohanTz
should I have to replace the queries with the created hooks (example: create useCollection hook and then use it where is appropriate) or just create the hooks without implementing them?

Hi @YohanTz @gershon  I created all these hooks:
useQuery:

(was already implemented) useCollection
useCollectionTraits
(was already implemented) useTokenMarketData
useSearchCollection
useSystemStatus
(was already implemented) useBalance
(was already implemented) usePortfolioStats
(was already implemented) usePrices

useInfiniteQuery:

useCollectionActivity
useTokenActivity
useTokenOffers
useWalletActivity
useWalletCollections
useWalletOffers
useWalletTokens

useSuspenseQuery:

useCollectionTraits --> renamed to useCollectionTraitsSuspense (there are another hook called useCollectionTraits but with useQuery instead of useSuspenseQuery)

useSuspenseInfiniteQuery:

[DONE] useCollectionTokens

Please confirm if I have to implement them where is needed. If not, I think this is ready for a PR, thanks🙂

Hi @jorgezerpa, looks good, let's go for a PR 🚀 .

PR done! I'm attentive for any correction🙂


Abstract AiHandler to BaseAiHandler

In many organization, accessing directly to LLM provider is not permit. By abstracting implementation of AiHandler to an interface, this allows developer to have more freedom in customizing how each function could work with organization's own way of integrating with LLM

/review

/update_changelog

/generate_labels

/review

/auto_review

Hi @brianpham93
The base idea is solid - enabling multiple ai handlers.
However, this PR needs more work and changes before it can merged:

Not every tool was adapted to the new format. hence, they will crash. This is beyond crucial to fix it fully. Triple-check that there are no instances of AiHandler() remaining, and that every tool still runs successfully.

with only one implementation of BaseAiHandler, it will be hard for other people to understand how to use it. You should provide at least one other implementation. The current AiHandler() should be renamed to LMAiHandler() (LM == LiteLLM), and you need to add another handler - OpenAIHandler(). Its not hard, since they have the same interface.
Make sure you can actually test both handlers, and that they work.

As a side note, in contrast to the PR description, the current handler does not access directly the LLM provider ("In many organization, accessing directly to LLM provider is not permit") - it uses LiteLLM interface.

thanks @mrT23 . i'll improve this PR further

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/b6409929d242b17ed695a71cf045b7f03f4dd1dc

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/b6409929d242b17ed695a71cf045b7f03f4dd1dc

/review

/update_changelog

Hi @brianpham93 , good work.
i tested 'LangChainOpenAIHandler' and 'OpenAIHandler' (in addition to 'LiteLLMAIHandler') and they all worked.
I hade some issues with the structure and where to give the default values. In general, I don't recommend initializing things on the main path
I made some corrections and simplifications, nothing that changes the behavior. please merge this PR to yours:
https://github.com/Codium-ai/pr-agent/pull/525
I did move the 'LangChainOpenAIHandler' to be optional, since this is quite an heavy installation, and currently I don't see an advantage it has over plain OpenAIHandler. if you think otherwise, let me know
after you merge my PR to yours, we can merge to main

thank @mrT23 , i've merged your PR's changes to my branch

great work @brianpham93


chore(deps): update envoyproxy/envoy-alpine docker tag to v1.20.1

This PR contains the following updates:

Package
Update
Change

envoyproxy/envoy-alpine
minor
v1.13.7 -> v1.20.1

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (v1.20.1). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


The task that inputs T-SQL file is not idempotent

It is hard to process the output of sqlcmd to make this task report states SUCCESS, CHANGED, FAIL.
The difficulty is that the behavior is inconsistent.
What I came up so far:

When modifying data inside an existing database, when applying the -m -1 flag with sqlcmd, sqlcmd returns 1 row affected messages if something inside a database is changed.
E.g. consider this query:

CREATE DATABASE ExampleDB1
GO
USE ExampleDB1
CREATE TABLE Inventory (id INT, name NVARCHAR(50), quantity INT)
INSERT INTO Inventory VALUES (1, 'apple', 100)
INSERT INTO Inventory VALUES (2, 'orange', 150)
INSERT INTO Inventory VALUES (3, 'banana', 154)
INSERT INTO Inventory VALUES (4, N'バナナ', 170)
GO

When running it for the first time:
    "__mssql_sqlcmd_input_file.stdout_lines": [
        "Msg 5701, Level 0, State 1, Server ibm-p8-kvm-03-guest-02, Line 1",
        "Changed database context to 'ExampleDB1'.",
        "",
        "(1 rows affected)",
        "",
        "(1 rows affected)",
        "",
        "(1 rows affected)",
        "",
        "(1 rows affected)",

When running the same for the second time:
        "Msg 1801, Level 16, State 3, Server ibm-p8-kvm-03-guest-02, Line 3",
        "Database 'ExampleDB1' already exists. Choose a different database name.",
        "Msg 5701, Level 0, State 1, Server ibm-p8-kvm-03-guest-02, Line 1",
        "Changed database context to 'ExampleDB1'.",
        "Msg 2714, Level 16, State 6, Server ibm-p8-kvm-03-guest-02, Line 2",
        "There is already an object named 'Inventory' in the database.",

When creating logins, users, and databases, sqlcmd does NOT return any success message that the entity is created. However, it does return an error when the entity that we try to create exists already.
Consider the following query:

CREATE LOGIN MyLogin WITH PASSWORD = 'p@55w0rD'
CREATE USER MyUser FOR LOGIN MyLogin
CREATE DATABASE ExampleDB1
GO

First run - no output.
Second run:
        "Msg 15025, Level 16, State 1, Server ibm-p8-kvm-03-guest-02, Line 1",
        "The server principal 'MyLogin' already exists.",
        "Msg 15023, Level 16, State 1, Server ibm-p8-kvm-03-guest-02, Line 2",
        "User, group, or role 'MyUser' already exists in the current database.",
        "Msg 1801, Level 16, State 3, Server ibm-p8-kvm-03-guest-02, Line 3",
        "Database 'ExampleDB1' already exists. Choose a different database name.",

We can process this output by searching different strings in the output, but we need to know all the possible scenarios that might occur first.

Running sqlcmd with -m -1 to print all messages:
/opt/mssql-tools/bin/sqlcmd   -U sa -P p@55w0rD -i /tmp/ansible.6znrsg1o -m -1

Here is an example of a real T-SQL script. Unlike the previous example, this script is idempotent by itself:
IF NOT EXISTS (

        SELECT *

        FROM sys.databases

        WHERE name = 'testdb'

        )

BEGIN

    CREATE DATABASE testdb

END

GO

USE testdb

GO

IF NOT EXISTS (

        SELECT 1

        FROM sys.tables

        WHERE name = 'test'

            AND type = 'U'

        )

BEGIN

    CREATE TABLE test (

        Id INT PRIMARY KEY IDENTITY(1, 1)

        ,Name VARCHAR(100)

        )

END

The role cannot run T-sql scripts idempotently because sqlcmd does not report results in an idempotent manner. README mentions it in https://github.com/linux-system-roles/mssql/blob/master/README.md?plain=1#L143.


abstraction of text decoration

this isn't fully formed in my head yet but I wanted to make a note of it while I'm thinking of it.  It might be interesting to see if we can abstract the colorizer functionality into a more general text decoration capability. This will be particularly useful when we start working with multiple documents.  For example, Marie-Claire would like the ability for metrical attributes on segments in a TEI document to be visible both in the TEI text view and the tree. I'm not sure, but it seems to me that this is analagous in alot of ways to the way the colorizer functionality is currently handled, in that different plugins can define aspects of text decoration, and then the user can choose which to show at any time.

Yes I agree that we want something that compares to colorizers here - there are a couple of open questions with this though:

Where do we obtain metric information?

It is either encoded in a document as information to a whole line/verse
But also every word naturally has metric information defined by its lengths and shorts

Metric analysis could be an own plugin all together. It would define additional token stylings and allow inspection of the meter present, with additional resources about it, with the ability to define the meter etc etc.

There is more, will think about this and then follow-up.

@LFDM I agree there is lots to think about here.  And I think it's not limited to meter, this is just one example of the type of data that can come in from a plugin or document that might be used to decorate a token throughout the interface.  As you note, the meter case was interesting because it also cascades down to tokens from a higher-up element in the source document (i.e. the line) -- in the demo code we wanted to decorate just the first word of the line on which the meter was actually encoded in the source document.  Note that code I pushed for this is not at all intended to be something we build on, just a way of demonstrating the type of functionality and providing a way to produce a screenshot :)


Make Tween::stop() consistent with AnimationPlayer API

This consistency is slightly related to https://github.com/godotengine/godot-proposals/issues/6043.
Whether the AnimationPlayer has a pause() method or not continues to be discussed in #56645. It may seem to be bikesheded, but the current inconsistent APIs is definitely not good.
IMO, I recommend making it the default to have reset as an argument to stop() for now.
This way, if we implement pause() methods in the future, it can be easily implemented in all classes as a wrapper function by using the same procedure. CC @KoBeWi

lol no
The reason #56645 is controversial is that it does more than stop() and pause(). But the fact that this issue is alive for so long and has support means that the API is not great. Making Tweens "consistent" in this case is a downgrade. Especially when they were already backported to 3.x and this PR would make 4.0's API worse xd

"lol no" is a bad beginning to an answer. Personally I am on the fence, I can see both advantages and disadvantages of this idea.
But I agree that changing things after they were backported to 3.x is not necessarily the best idea

I opened an opposite PR: #71218
Note that both these PRs break compat, so we can pick either.

https://github.com/godotengine/godot/pull/71218

Ah, I just tried to do the exact same thing with that PR when I saw your reply.

Superseded by #71218.


missing   SPAC110.06, SPAPB1A11.06, SPCC4G3.20,

This is only a heads up, in case of any confusion (like protein numbers not adding up etc)
These 3 proteins are in  P2 but don't appear to have made it into Ensembl yet...
(and consequently there are no image maps for them)
No action requred

info only