Disk cache grows beyond the limit

I've done a load test on my installation with this configuration (there is some options from my fork):
/usr/bin/imageproxy -addr=localhost:8980 -cacheDir=/data/imageproxy/cache -cacheSize=1024 -log_dir=/data/imageproxy/log -filetypes=png,PNG,jpg,JPG,jpeg,JPEG,gif,GIF -signatureKey=xxx -logrotatecompatible=true

In front of that there is a nginx with a disk cache (who doesn't work the same than imageproxy cache as imageproxy still make a head request to the original server).
I've requested lot of different files and the imageproxy cache is now 3,2GiB with 56197 files. That's far beyond of the 1014MB given on the command line. Am I missing something ?
Since I already have a cache with nginx, it is possible to add an option to disable imageproxy cache ?

Another thing, the cache files are stored flat on the filesystem (that's the default option for the diskv
module), this can be a performance problem for large cache. Most of the cache systems use 2 or 3 levels of subdirectories.

I don't understand this code neither:
var cacheDir = flag.String("cacheDir", "", "directory to use for file cache")
var cacheSize = flag.Uint64("cacheSize", 100, "maximum size of file cache (in MB)")
...
	var c httpcache.Cache
	if *cacheDir != "" {
		d := diskv.New(diskv.Options{
			BasePath:     *cacheDir,
			CacheSizeMax: *cacheSize * 1024 * 1024,
		})
		c = diskcache.NewWithDiskv(d)
	} else if *cacheSize != 0 {
		c = httpcache.NewMemoryCache()
	}

Maybe to do something like this ?
    var c httpcache.Cache
    if *fileCache {
        if *cacheDir != "" {
            d := diskv.New(diskv.Options{
                BasePath:     *cacheDir,
                CacheSizeMax: *cacheSize * 1024 * 1024,
            })
            c = diskcache.NewWithDiskv(d)
        } //TODO else error ?
    } else if *memCache {
        c = httpcache.NewMemoryCache()
    } else {
        c = nil
    }

Done it there https://github.com/Toubib/imageproxy/commit/6a0c813390793225a16ba28129b2812c8fd514b1, no cache mode added.

filed #50 to track modifying the diskv structure.  Making the no-cache mode simpler to use will be covered by #49.  I'll leave this open to track the original reported issue of the disk cache growing too large.

okay, so I figured out why this is happening.  It's because I completely misunderstood what the CacheSizeMax option in the diskv library is for. :disappointed: diskv has its own in-memory cache of the files that it stores on disk, and CacheSizeMax controls the size of that cache, not the files on disk.  Which, now that I think more about it, completely makes sense... diskv is designed to be an arbitrary key-value store, so you wouldn't want it randomly deleting files on disk.
This means that we don't actually have a way to limit the size of the image cache at this time.  I'm going remove the cacheSize related code, since it's not doing anything meaningful.  I'll leave the flag for the time being so that it doesn't cause panics, but it should no longer be used.


I added your article as reference

Guys,
Amazing work! I am a popular data science/technology writer on Medium and I wrote a piece a few weeks back on general SEIR model coding in Python. Not necessarily with COVID-19 parameters but just to give a demo of how easily one can code the curves and peaks etc.
I added your article as a reference inside my article if that is alright.
"Simple modeling of “flattening the curve” and “lifting lockdown”

If it's okay to promote similar work, please see http://leakylockdown.com


More info
environment
$ terraform --version && ../terraformer/terraformer-aws --version && tree .terraform/
Terraform v1.3.5
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v4.43.0
version v0.8.22
.terraform/
└── providers
    └── registry.terraform.io
        └── hashicorp
            └── aws
                └── 4.43.0
                    └── linux_amd64
                        └── terraform-provider-aws_v4.43.0_x5

6 directories, 1 file

plan works fine
$ ../terraformer/terraformer-aws plan aws --resources="securityhub" --regions=us-east-1 --profile="ipi"
2022/11/30 07:12:53 aws importing region us-east-1
2022/11/30 07:12:55 aws importing... securityhub
2022/11/30 07:12:58 aws done importing securityhub
2022/11/30 07:12:58 Number of resources for service securityhub: 3
2022/11/30 07:12:58 Refreshing state... aws_securityhub_standards_subscription.tfer--arn-003A-aws-003A-securityhub-003A-us-east-1-003A-994276127279-003A-subscription-002F-cis-aws-foundations-benchmark-002F-v-002F-1-002E-2-002E-0
2022/11/30 07:12:58 Refreshing state... aws_securityhub_account.tfer--994276127279
2022/11/30 07:12:58 Refreshing state... aws_securityhub_standards_subscription.tfer--arn-003A-aws-003A-securityhub-003A-us-east-1-003A-994276127279-003A-subscription-002F-aws-foundational-security-best-practices-002F-v-002F-1-002E-0-002E-0
2022/11/30 07:12:59 Filtered number of resources for service securityhub: 3
2022/11/30 07:12:59 Saving planfile to generated/aws/terraformer/plan.json

import plan got error
2022/11/30 07:13:47 aws Connecting....
2022/11/30 07:13:47 aws save securityhub
2022/11/30 07:13:47 At 3:2: object expected closing RBRACE got: EOF

terreform says those files are well-formed, but terraformer has parsing error.
$ terraform plan

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
$ terraform validate
Success! The configuration is valid.


nsc-events-nextjs_8_447_editing-metadata

Resolves #447
Previously, the metadata object in this application was using the defaults so the title was this:

And the description was this:

By editing the metadata object in this pull request:
Title:

Description:

You can test this by running this branch locally. Then you can view the title change above the page and by inspecting the page you can view the description change.

We need this merged by 5 PM 6/10 for the showcase. Thanks!


Draft RPC Doc

WIP. previous pr: https://github.com/xf6wang/ts-docs/pull/1

looks different between svg and png...

Overall comment - this needs to be moved to doc/developer-guide/internal-libraries - it's not really part of the documentation of the documentation.

This is just a first pass. I'll have more to say later.

updated it to address the comments.

Also, you'll need to add type definitions to doc/developer-guide/api/types/SystemTypes.en.rst to remove the doc generation warnings like
/home/amc/git/pr/doc/developer-guide/internal-libraries/RPC.en.rst:118: WARNING: cpp:typeOrConcept reference target not found: ssize_t

I think once that's done we can put it to ASF.

You also need to update the index.en.rst file in the directory to include RPC.en.

@SolidWallOfCode did a few things and squashed everything. If you could give it one more scan and if it looks good, I'll put it up on open-source.

Added TSMgmtTypes and moved macros there
Moved rpc.en.rst into a new folder core-architecture (I think you mentioned this in the previous doc PR I had)
Updated it to reflect the PR that removes the delay from traffic_ctl.

Looks good enough for public review, close this and put it on the ASF github.


feat(release): Removed generate-changelog.

Coverage remained the same at 100.0% when pulling fe1e9254c06bc8331177ec49948de876c79eb00a on remove-generate-changelog into f750e09c9f1a331eeab095d702fd182be4582b77 on master.

Coverage remained the same at 100.0% when pulling fe1e9254c06bc8331177ec49948de876c79eb00a on remove-generate-changelog into f750e09c9f1a331eeab095d702fd182be4582b77 on master.


also return classes when caling goToDef on a constructor call

maybe fixes?? #59241
In particular, this PR does this.
When requesting definition on a non-extended class,
class Foo {
    /*
     * possibly a lot of code
     */
    constructor()
}
const foo = new /*goToDefinition*/Foo()

we now also return the class definition, in addition to the constructor.

@typescript-bot pack this


[5.4] Refactor - Save a count and a test

Save a count and a test with. array_shift has a O(1) complexity.

Just found the same in Builder::value() ;)

After a few tries on PHP 5.6, it seems to actually have a O(N) complexity, and is a little slower than previous method.
I also tried reset($result) ?: null, also O(N) but this time it is marginally faster. Still, worth the pick for large arrays.


Exposing tests as separate jars

Some (mock) test classes are useful to those dependent on "Ambry". So this patch exposes tests as separate jars.
SLA: 5 mins
Reviewers: Priyesh, Casey
Build succeeded

oops. Removed them


Upload to coveralls

+r

LGTM :+1:

The build is good and I'm seeing 1 +1s from the following folks:

wilsonianb

As such, I'll attempt to merge and close this pull request.


change Epoch.dt and Deme.dt properties to time_span

I think having a more explicit name would be better.

+1

Good idea


Error while trying examples

(WindowsNoEditor) D:\Carla\WindowsNoEditor\PythonAPI\examples>python spawn_npc.py
destroying 0 vehicles
destroying 0 walkers
done.
Traceback (most recent call last):
File "spawn_npc.py", line 301, in
main()
File "spawn_npc.py", line 109, in main
world = client.get_world()
RuntimeError: time-out of 10000ms while waiting for the simulator, make sure the simulator is ready and connected to <IP_ADDRESS>:2000
I am facing this issue and couldn't find the port connection. Kindly help me to resolve this issue.

I have also tried with python spawn_npc.py -n 80
But again getting the same error

@Mano2610 Couple of times I was experiencing the same issue. I think that could be related to the overall performance of your system. Can you try to run Carla with -quality-level=Low key?

@ar4development - Do I need to run Carla4UE.exe-quality-level=low, while running the Carla environment.

I have tried, but again getting the same error as below,
(WindowsNoEditor) C:\Users\kvman\Downloads\WindowsNoEditor>CarlaUE4.exe -quality-level=Low
(WindowsNoEditor) C:\Users\kvman\Downloads\WindowsNoEditor>cd PythonAPI\examples
(WindowsNoEditor) C:\Users\kvman\Downloads\WindowsNoEditor\PythonAPI\examples>python spawn_npc.py
destroying 0 vehicles
destroying 0 walkers
done.
Traceback (most recent call last):
File "spawn_npc.py", line 301, in
main()
File "spawn_npc.py", line 109, in main
world = client.get_world()
RuntimeError: time-out of 10000ms while waiting for the simulator, make sure the simulator is ready and connected to <IP_ADDRESS>:2000

@Mano2610 does your simulator look responsive before you try to spawn the actors? I mean can you "fly" over the map using w/a/s/d/e/q ?

Yes, I am able to move with my keys w,a,s,d

@Mano2610 are you running the examples on a CARLA map or custom? What version of CARLA are you using?
@bernatx could you have a look at this please?

First I opened the Carla simulator and then I tried to run the example scripts like spwan_npc, manual_control_carsim, but I am unable to run those scripts. I am getting the runtime error like the simulator is not connected to the required port.
RuntimeError: time-out of 10000ms while waiting for the simulator, make sure the simulator is ready and connected to <IP_ADDRESS>:2000
I am using the latest version of Carla 0.9.11. I have also tried version 0.9.10, but no luck. I am getting the same error.
Can you please help me to find the port connection of Carla?


Something wrong in the menu bar like this NewFile(N) version 1.28.0

Use Alt to toggle focus on menu bar
Open any menu

VS Code version: Code - Insiders 1.28.0-insider (a3f9f2e7240106aeec2f1d4bc03d7876bd42e2e4, 2018-09-07T05:20:29.346Z)
OS version: Windows_NT x64 10.0.17134

Saw this and resolved this morning. Should be fixed in the next insiders build. For the day since this is very ugly, you can disable menu bar mnemonics with window.enableMenuBarMnemonics: "false"

fixed with 4ca21ffb190842ae594c98d83cb01f2929bca8c7


fix(logger): add xray_trace_id to every log

Description of your changes
As reported by user @humanzz in #773 the Logger utility was not including the xray_trace_id key in logs. This field is listed in the documentation as a standard key that should appear in each log.
The user reporting the issue was helpful in detailing the fact that the _X_AMZN_TRACE_ID environment variable used to retrieve the value changes at every invocation while Logger was instead attempting to read this value when instantiated (see constructor -> setOptions -> setPowertoolLogData).
This PR changes this behaviour and appends the xray_trace_id key when the log entry is created and populated instead (createAndPopulateLogItem function). This behaviour is consistent with the implementation also used in the Python version of Powertools.
As additional notes:

This was not caught in unit tests because the environment variable is set by packages/logger/tests/helpers/populateEnvironmentVariables.ts which is imported before tests are run. So when running the tests the xray_trace_id would always be present.
This was not caught in the e2e/integration tests either because no assertion was made on the presence of this key in the logs (this PR adds a test case to check this).
The documentation erroneously stated that this key should be set only when Active Tracing is enabled. This is not true as the _X_AMZN_TRACE_ID  environment variable is always set in the Lambda execution environment, regardless of whether tracing is enabled or not. This means the key will always be present in each log. AWS Lambda Powertools for Python makes the same statement and I have tested the latest version available of the library on a Lambda function with Active Tracing disabled and the key is also always present in each log.

How to verify this change

See unit test results in this PR
See result of e2e tests here
See example of CloudWatch logs generated after this change (below)

Related issues, RFCs

#773
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[x] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] The code coverage hasn't decreased
[x] I have added tests that prove my change is effective and works
[x] New and existing unit tests pass locally and in Github Actions
[x] Any dependent changes have been merged and published in downstream module
[x] The PR title follows the conventional commit semantics

Breaking change checklist
N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

See e2e test result here (passing): https://github.com/awslabs/aws-lambda-powertools-typescript/runs/6041778790?check_suite_focus=true


test suite failure with servant-0.18.2

The servant-elm-0.7.2 test suite appears to fail when compiled against servant-0.18.2 (et al. Servant 0.18.x supporting libraries).
The errors are as follows:
    /var/stackage/work/unpack-dir/unpacked/servant-elm-0.7.2-4b10f1da950fea1a0bcaf74a9e68dc0a1c01
36e8c09a136b9c3f6c89e09ad21a/test/Common.hs:41:13: error:
        • Expected kind ‘[*] -> * -> *’, but ‘PostNoContent’ has kind ‘*’
        • In the second argument of ‘(:>)’, namely
            ‘PostNoContent '[JSON] ()’
          In the second argument of ‘(:>)’, namely
            ‘ReqBody '[JSON] Book :> PostNoContent '[JSON] ()’
          In the first argument of ‘(:<|>)’, namely
            ‘"books" :> ReqBody '[JSON] Book :> PostNoContent '[JSON] ()’
       |
    41 |          :> PostNoContent '[JSON] ()
       |

    /var/stackage/work/unpack-dir/unpacked/servant-elm-0.7.2-4b10f1da950fea1a0bcaf74a9e68dc0a1c01
36e8c09a136b9c3f6c89e09ad21a/test/Common.hs:43:13: error:
        • Expected kind ‘[*] -> * -> *’, but ‘GetNoContent’ has kind ‘*’
        • In the second argument of ‘(:>)’, namely
            ‘GetNoContent '[JSON] ()’
          In the first argument of ‘(:<|>)’, namely
            ‘"nothing" :> GetNoContent '[JSON] ()’
          In the second argument of ‘(:<|>)’, namely
            ‘"nothing" :> GetNoContent '[JSON] ()
             :<|>
             "nothing" :> Put '[JSON] ()
             :<|>
             "with-a-header"
             :>
             Header "Cookie" String
             :>
             Header "myStringHeader" String
             :>
             Header "MyIntHeader" Int
             :>
             Header' '[Required] "MyRequiredStringHeader" String
             :>
             Header' '[Required] "MyRequiredIntHeader" Int :> Get '[JSON] String
             :<|>
             "with-a-response-header"
             :> Get '[JSON] (Headers '[Header "myResponse" String] String)’
       |
    43 |          :> GetNoContent '[JSON] ()
       |             ^^^^^^^^^^^^^^^^^^^^^^^

Fixed in master, thanks!


Having issues with provisioning profiles

New Issue Checklist

[y ] Updated fastlane to the latest version
[ y] I read the Contribution Guidelines
[ y] I read docs.fastlane.tools
[ y] I searched for existing GitHub issues

Issue Description
There's a conflict with provisioning profiles, not sure why its creating one, it should pull the one from Appstore, i already have this app up and running
Command executed
bundle exec fastlane beta
Complete output when running fastlane, including the stack trace and command used

 [✔] 🚀
[18:32:30]: ------------------------------
[18:32:30]: --- Step: default_platform ---
[18:32:30]: ------------------------------
[18:32:30]: Driving the lane 'ios beta' 🚀
[18:32:30]: ------------------------------------
[18:32:30]: --- Step: increment_build_number ---
[18:32:30]: ------------------------------------
Current version of project App is:
    5
/Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App
[18:32:30]: $ cd /Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App && agvtool next-version -all && cd -
[18:32:30]: ▸ Setting version of project App to:
[18:32:30]: ▸ 6.
[18:32:30]: ▸ Also setting CFBundleVersion key (assuming it exists)
[18:32:30]: ▸ Updating CFBundleVersion in Info.plist(s)...
[18:32:30]: ▸ Updated CFBundleVersion in "App.xcodeproj/../App/Info.plist" to 6
[18:32:30]: ▸ /Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App
[18:32:30]: ------------------------------
[18:32:30]: --- Step: get_certificates ---
[18:32:30]: ------------------------------
+---------------------------------------------------------------------------------+
|                            Summary for cert 2.219.0                             |
+-------------------------+-------------------------------------------------------+
| development             | false                                                 |
| force                   | false                                                 |
| generate_apple_certs    | true                                                  |
| username                | REDACTED                             |
| team_id                 | REDACTED                                            |
| keychain_path           | /Users/macbookpro/Library/Keychains/login.keychain-db |
| skip_set_partition_list | false                                                 |
| platform                | ios                                                   |
+-------------------------+-------------------------------------------------------+
[18:32:30]: Starting login with user 'REDACTED'
[18:32:33]: Successfully logged in
[18:32:34]: Found the certificate REDACTED (REDACTED) which is installed on the local machine. Using this one.
[18:32:34]: Verifying the certificate is properly installed locally...
[18:32:34]: Successfully installed certificate REDACTED
[18:32:34]: Use signing certificate 'REDACTED' from now on!
[18:32:34]: --------------------------------------
[18:32:34]: --- Step: get_provisioning_profile ---
[18:32:34]: --------------------------------------
+--------------------------------------------------------------------+
|                      Summary for sigh 2.219.0                      |
+-------------------------------------+------------------------------+
| filename                            | provisioning.mobileprovision |
| adhoc                               | false                        |
| developer_id                        | false                        |
| development                         | false                        |
| skip_install                        | false                        |
| force                               | false                        |
| include_mac_in_profiles             | false                        |
| app_identifier                      | rs.boost                     |
| username                            | REDACTED    |
| team_id                             | REDACTED                   |
| ignore_profiles_with_different_name | false                        |
| cert_id                             | REDACTED                   |
| skip_fetch_profiles                 | false                        |
| include_all_certificates            | false                        |
| skip_certificate_verification       | false                        |
| platform                            | ios                          |
| readonly                            | false                        |
| fail_on_name_taken                  | false                        |
+-------------------------------------+------------------------------+
[18:32:34]: Starting login with user 'REDACTED'
[18:32:36]: Successfully logged in
[18:32:36]: Fetching profiles...
[18:32:37]: Verifying certificates...
[18:32:37]: Found 1 matching profile(s)
[18:32:37]: Downloading provisioning profile...
[18:32:37]: Successfully downloaded provisioning profile...
[18:32:37]: Installing provisioning profile...
/Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App/builds/provisioning.mobileprovision
[18:32:37]: Setting Provisioning Profile type to 'app-store'
[18:32:37]: -----------------------------------------
[18:32:37]: --- Step: update_project_provisioning ---
[18:32:37]: -----------------------------------------
[18:32:37]: You’re updating provisioning profiles directly in your project, but have you considered easier ways to do code signing?
[18:32:37]: https://docs.fastlane.tools/codesigning/GettingStarted/
[18:32:37]: Parsing mobile provisioning profile from './builds/provisioning.mobileprovision'
[18:32:37]: Going to update project 'App.xcodeproj' with UUID
[18:32:37]: Updating target App...
[18:32:37]: Skipping configuration Debug as it doesn't match the filter 'Release'
[18:32:37]: Updating configuration Release...
[18:32:37]: Successfully updated project settings in 'App.xcodeproj'
[18:32:37]: ---------------------------------
[18:32:37]: --- Step: update_project_team ---
[18:32:37]: ---------------------------------
[18:32:37]: Updating development team (REDACTED) for target App in the project 'App.xcodeproj'
[18:32:37]: Successfully updated project settings to use Developer Team ID 'REDACTED' for target App
[18:32:37]: -----------------------
[18:32:37]: --- Step: build_app ---
[18:32:37]: -----------------------
[18:32:37]: Resolving Swift Package Manager dependencies...
[18:32:37]: $ xcodebuild -resolvePackageDependencies -workspace App.xcworkspace -scheme App
[18:32:39]: ▸ Command line invocation:
[18:32:39]: ▸     /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -workspace App.xcworkspace -scheme App
[18:32:39]: ▸ User defaults from command line:
[18:32:39]: ▸     IDEPackageSupportUseBuiltinSCM = YES
[18:32:39]: ▸ resolved source packages:
[18:32:39]: $ xcodebuild -showBuildSettings -workspace App.xcworkspace -scheme App 2>&1
[18:32:42]: Detected provisioning profile mapping: {:"rs.boost"=>"rs.boost AppStore"}
+------------------------------------------------------------------------+
|                        Summary for gym 2.219.0                         |
+----------------------------------------------+-------------------------+
| workspace                                    | App.xcworkspace         |
| scheme                                       | App                     |
| clean                                        | true                    |
| export_method                                | app-store               |
| export_options.provisioningProfiles.rs.boost | rs.boost AppStore       |
| build_path                                   | ./builds                |
| output_directory                             | ./builds                |
| output_name                                  | App                     |
| silent                                       | false                   |
| skip_package_ipa                             | false                   |
| skip_package_pkg                             | false                   |
| result_bundle                                | false                   |
| buildlog_path                                | ~/Library/Logs/gym      |
| destination                                  | generic/platform=iOS    |
| xcodebuild_formatter                         | xcpretty                |
| build_timing_summary                         | false                   |
| skip_profile_detection                       | false                   |
| xcodebuild_command                           | xcodebuild              |
| skip_package_dependencies_resolution         | false                   |
| disable_package_automatic_updates            | false                   |
| use_system_scm                               | false                   |
| xcode_path                                   | /Applications/Xcode.app |
+----------------------------------------------+-------------------------+
[18:32:42]: $ set -o pipefail && xcodebuild -workspace App.xcworkspace -scheme App -destination 'generic/platform=iOS' -archivePath ./builds/App\ 2024-02-13\ 18.32.42.xcarchive clean archive | tee /Users/macbookpro/Library/Logs/gym/App-App.log | xcpretty
[18:32:44]: ▸ Clean Succeeded
[18:32:49]: ▸     Run script build phase '[CP] Embed Pods Frameworks' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'App' from project 'App')
[18:32:49]: ▸ ** ARCHIVE FAILED **
▸ Clean Succeeded
Run script build phase '[CP] Embed Pods Frameworks' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'App' from project 'App')
** ARCHIVE FAILED **
[18:32:49]: Exit status: 65
+-----------------------------------------+
|            Build environment            |
+---------------+-------------------------+
| xcode_path    | /Applications/Xcode.app |
| gym_version   | 2.219.0                 |
| export_method | app-store               |
| sdk           | iPhoneOS17.2.sdk        |
+---------------+-------------------------+
[18:32:49]: ▸ Build description signature: 99e5e439f7681a3eaf194bf0da287938
[18:32:49]: ▸ Build description path: /Users/macbookpro/Library/Developer/Xcode/DerivedData/App-dqqkdgrckwlkgxcvfmrnclczwmvr/Build/Intermediates.noindex/ArchiveIntermediates/App/IntermediateBuildFilesPath/XCBuildData/99e5e439f7681a3eaf194bf0da287938.xcbuilddata
[18:32:49]: ▸ /Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App/App.xcodeproj: error: App has conflicting provisioning settings. App is automatically signed, but provisioning profile rs.boost AppStore has been manually specified. Set the provisioning profile value to "Automatic" in the build settings editor, or switch to manual signing in the Signing & Capabilities editor. (in target 'App' from project 'App')
[18:32:49]: ▸ warning: Run script build phase '[CP] Embed Pods Frameworks' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'App' from project 'App')
[18:32:49]:
[18:32:49]: ⬆  Check out the few lines of raw xcodebuild output above for potential hints on how to solve this error
[18:32:49]: 📋  For the complete and more detailed error log, check the full log at:
[18:32:49]: 📋  /Users/macbookpro/Library/Logs/gym/App-App.log
[18:32:49]:
[18:32:49]: Looks like fastlane ran into a build/archive error with your project
[18:32:49]: It's hard to tell what's causing the error, so we wrote some guides on how
[18:32:49]: to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/
[18:32:49]: Before submitting an issue on GitHub, please follow the guide above and make
[18:32:49]: sure your project is set up correctly.
[18:32:49]: fastlane uses xcodebuild commands to generate your binary, you can see the
[18:32:49]: the full commands printed out in yellow in the above log.
[18:32:49]: Make sure to inspect the output above, as usually you'll find more error information there
[18:32:49]:
+--------------------------------------------------------------------------------------------------------------------------+
|                                                       Lane Context                                                       |
+---------------------+----------------------------------------------------------------------------------------------------+
| DEFAULT_PLATFORM    | ios                                                                                |
| PLATFORM_NAME       | ios                                                                                |
| LANE_NAME           | ios beta                                                                                |
| BUILD_NUMBER        | 6                                                                                |
| CERT_FILE_PATH      | /Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App/builds/REDACTED.cer                  |
| CERT_CERTIFICATE_ID | REDACTED                                                                                |
| SIGH_PROFILE_PATH   | /Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App/builds/provisioning.mobileprovision    |
| SIGH_PROFILE_PATHS  | ["/Users/macbookpro/dev/workspaces/smartedv2_frontend/ios/App/builds/provisioning.mobileprovision  |
|                     | "]                                                                                |
| SIGH_UDID           | a146db58-f5ee-4b9b-8a10-b96e618ead7a                                                               |
| SIGH_UUID           | a146db58-f5ee-4b9b-8a10-b96e618ead7a                                                               |
| SIGH_NAME           | rs.boost AppStore                                                                                |
| SIGH_PROFILE_TYPE   | app-store                                                                                |
+---------------------+----------------------------------------------------------------------------------------------------+
[18:32:49]: Error building the application - see the log above
+--------------------------------------------------+
|                 fastlane summary                 |
+------+-----------------------------+-------------+
| Step | Action                      | Time (in s) |
+------+-----------------------------+-------------+
| 1    | default_platform            | 0           |
| 2    | increment_build_number      | 0           |
| 3    | get_certificates            | 4           |
| 4    | get_provisioning_profile    | 2           |
| 5    | update_project_provisioning | 0           |
| 6    | update_project_team         | 0           |
| 💥   | build_app                   | 12          |
+------+-----------------------------+-------------+
[18:32:49]: fastlane finished with errors
[!] Error building the application - see the log above

Environment

 ✅ fastlane environment ✅
Stack

Key
Value

OS
14.2.1

Ruby
3.2.2

Bundler?
false

Git
git version 2.39.3 (Apple Git-145)

Installation Source
~/.rbenv/versions/3.2.2/bin/fastlane

Host
macOS 14.2.1 (23C71)

Ruby Lib Dir
~/.rbenv/versions/3.2.2/lib

OpenSSL Version
OpenSSL 3.1.2 1 Aug 2023

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
15.2

Swift Version
5.9.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Push a new beta build to TestFlight"
  lane :beta do
    increment_build_number(xcodeproj: "App.xcodeproj")
    get_certificates( # Create or get certificate, and install it
      output_path: "./builds" # Download certificate in the build folder (you don't need to create the folder)
    )
    get_provisioning_profile( # Create or get provisioning profile
      output_path: "./builds",  # Download provisioning profile in the build folder
      filename: "provisioning.mobileprovision" # Rename the local provisioning profile
    )
    update_project_provisioning( # Set the project provisioning profile (related in Xcode to the General > Signing Release section)
      xcodeproj: "App.xcodeproj",
      target_filter: "App", # Name of your project
      profile: "./builds/provisioning.mobileprovision",
      build_configuration: "Release"
    )
    update_project_team( # Set the right team on your project
      teamid: CredentialsManager::AppfileConfig.try_fetch_value(:team_id)
    )
    build_app(
      workspace: "App.xcworkspace",
      scheme: "App",
      clean: true,
      export_method: "app-store",
      export_options: {
        provisioningProfiles: {
            CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier) => CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier) # Value of this parameter is the name of the Provisioning Profile. By default, it will be "{bundleId} AppStore"
        }
      },
      build_path: "./builds",
      output_directory: "./builds")
      upload_to_testflight
  end
end

`./fastlane/Appfile`
app_identifier("rs.boost") # The bundle identifier of your app
<EMAIL_ADDRESS># Your Apple Developer Portal username

itc_team_id("123232626") # App Store Connect Team ID
team_id("7PSS25J77P") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.219.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

error_highlight
0.5.1

did_you_mean
1.6.3

syntax_suggest
1.0.2

artifactory
3.0.15

babosa
1.0.4

CFPropertyList
3.0.6

colored
1.2

highline
2.0.3

commander
4.6.0

dotenv
2.8.1

emoji_regex
3.2.3

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.3

faraday_middleware
1.2.0

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

gh_inspector
1.1.3

google-apis-playcustomapp_v1
0.13.0

google-cloud-env
1.6.0

jwt
2.7.1

mini_magick
4.12.0

naturally
2.2.1

rubyzip
2.3.2

security
0.1.3

simctl
1.6.10

terminal-notifier
2.0.0

unicode-display_width
2.5.0

terminal-table
3.0.2

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

set
1.0.3

public_suffix
5.0.4

addressable
2.8.6

aws-eventstream
1.3.0

aws-sigv4
1.8.0

aws-partitions
1.889.0

jmespath
1.6.2

aws-sdk-core
3.191.1

aws-sdk-kms
1.77.0

aws-sdk-s3
1.143.0

bundler
2.4.21

rexml
3.2.6

excon
0.109.0

multipart-post
2.4.0

domain_name
0.6.20240107

fastimage
2.3.0

httpclient
2.8.3

multi_json
1.15.0

signet
0.18.0

os
1.1.4

googleauth
1.8.1

mini_mime
1.1.5

retriable
3.1.2

trailblazer-option
0.1.2

declarative
0.0.20

uber
0.1.0

representable
3.2.0

google-apis-core
0.11.3

google-apis-androidpublisher_v3
0.54.0

rake
13.1.0

digest-crc
0.6.5

google-apis-storage_v1
0.31.0

google-apis-iamcredentials_v1
0.17.0

google-cloud-errors
1.3.1

google-cloud-core
1.6.1

google-cloud-storage
1.47.0

json
2.7.1

optparse
0.4.0

plist
3.7.1

tty-screen
0.8.2

nanaimo
0.3.0

colored2
3.1.2

claide
1.1.0

atomos
0.1.3

xcodeproj
1.24.0

forwardable
1.3.3

logger
1.5.3

pathname
0.2.1

shellwords
0.1.0

cgi
0.3.6

date
3.3.3

timeout
0.3.1

securerandom
0.2.2

uri
0.12.1

openssl
3.1.0

digest
3.1.1

ipaddr
1.2.5

resolv
0.2.2

time
0.2.2

stringio
3.0.4

open-uri
0.3.0

mutex_m
0.1.2

net-http
0.3.2

net-protocol
0.2.1

ostruct
0.5.5

english
0.7.2

erb
4.0.2

abbrev
0.1.1

tempfile
0.1.3

delegate
0.3.0

fileutils
1.7.0

tmpdir
0.1.3

base64
0.1.1

singleton
0.1.1

open3
0.1.2

nkf
0.1.2

prettyprint
0.1.1

pp
0.4.0

find
0.1.1

yaml
0.2.1

psych
5.0.1

generated on: 2024-02-13

This is probably not a bug in fastlane. I see that you opened a discussion here https://github.com/fastlane/fastlane/discussions/21873, so let's discuss it there.


[FLINK-13433][table-planner-blink]  Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

What is the purpose of the change
For LookupJoin, if joinKey in left side of a LeftOuterJoin/InnerJoin contains null values, there is no need to fetch data from LookupableTableSource.
However, we don't shortcut the fetch function under the case at present, the correctness of results depends on the TableFunction implementation of each LookupableTableSource.
Brief change log

correct the behavior of LookupJoin where lookupKeys contains null.
Add more testcases.

Verifying this change
testcases
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature?  no
If yes, how is the feature documented? not applicable

cc @wuchong @lincoln-lil

I am interested to sql: SELECT T.id, T.len, T.content, D.name FROM T JOIN userTable for system_time as of T.proctime AS D ON T.id = D.id OR (T.id is null and D.id is null).
Does it work?

@JingsongLi At first glance, I guess the query is not supported.
However, after run it actually, The query could be executed, but results in error outputs……
Good catch, I will looks into the problem.

@wuchong

could you also update InMemoryAsyncLookupFunction#eval and InMemoryLookupFunction#eval to throw exception when one of the argument is null？
Hi, JarkWu, InMemoryAsyncLookupFunction and InMemoryLookupFunction lookup records with null value on the lookup key field when argument contains null, which complies with the contract mentioned in https://github.com/apache/flink/pull/9335/files, I think the behavior is also reasonable.

I agree with you @beyond1920 , however, I want to have some test to cover we didn't push any nulls into LookupFunction. That's why I want to add such check in InMemoryLookupFunction. We can remove the check when we support push is null into LookupFunction?

@wuchong , Ok

Thanks @beyond1920 , looks good to me now.

BTW, could you also open a jira for empty key for hbase lookup function? hbase forbidden empty row key.

@KurtYoung The hbase lookup function is updated in https://github.com/apache/flink/pull/9335.


Use Virtualized Lists instead of loading all content at once

Description
Currently there are 115 gradients stored in the code and in the future this value would be a lot more, probably 1000, and right now, when somebody loads the website, all the content loads all at once, and already with just 115 gradients, the website freezes for a very tiny amount of time before it becomes interactive. This is because there's a huge amount of content that gets loaded at once which might become heavy for users with not as powerful computers.
Steps to reproduce the behavior:
Just visit the website
Expected behavior
The website loads immediately without freezing at the first place, this is important to have a good UX.
Desktop (please complete the following information):

OS: Windows 10 Home
Browser: Brave (Chromium based)

Solution
The solution to this issue would be to use react-virtualized, which allows us to only load the content that is in users' reach/view. It hence loads the latter gradients as the user scrolls through the website. This will not only make the UX better by loading the website and making it interactive faster but it will also make it easy for us to load a huge amount of content in the future without the website freezing.
PageSpeed Insights

As you can see in the above image, time to interactive is 1.2s which is pretty good, but still slow considering there's only 115 gradients to load, this might vary on other computers.
Further on, it's worse on mobiles with 115 gradients takes 7.6s to load (may vary on different phones),

This looks pretty amazing, glad to see your PR on this. react-virtualized in indeed great, I loved the concept


Update DESIGN.md

PR Test

Nice test, it worked. But I'm sadly going to reject :)

Sorry about that! Wrong repo!


Suggestion: pico_display API

Since the display needs a call to init() to be usable, can we consider setting set_pen(0,0,0) and calling clear(), internally, the first time init is called?
Not really a big deal.
I am trying to figure out what it takes to make a pull request, but a complete n00b at Micropython build environment. Still trying to wrap my head around how to test my changes :-)

Personally, I would suggest that a overloaded call to init, with RGB values for the background would be preferable. If you look at the display demo code, that uses a rather nasty brownish colour for the background, so a black background, while likely to be the most common, is certainly not an automatic choice in all cases.

Closing as relates to old pico_display API.
New shininess here!: https://github.com/pimoroni/pimoroni-pico/blob/main/libraries/pico_graphics/README.md


Frequently exceeding GH API rate limits

On Servo, we're seeing homu die every couple of days due to exceeding GH API rate limits. Are there any solutions to this problem that we can do on our side? I see a bunch of stuff about Conditional Requests, etc. here: https://developer.github.com/v3/#conditional-requests, and we could certainly help with some patches.
Otherwise, should we be using account-per-repo or something?
cc @jdm, @metajack, @edunham

Even just being able to have homu respect the rate limit would probably help a lot.

@barosl We are hitting this roughly hourly on Servo. halp.

Hahaha! This was us, overusing the account for something else. Na'ermind :-)


API Refactor UploadField, FileField and AssetField into traits

This is done in preparation for a new FileField which will be used within react, provided by the silverstripe/asset-admin module.
Behaviour which handled the upload of user-submitted files has been refactored into an "Uploadable" trait.
Additional behaviour which handled the upload of user-submitted files, specifically for saving into File dataobjects within has_one / has_many / many_many relations has been refactored into FileUploadable, which extends this base trait.
AssetField and UploadField now no longer extend FileField, but instead directly extend FormField, and have the necessary traits.

I think the trait Uploadable could be named better. These objects are not "Uploadable" they are "upload handlers" no one can upload a FileField but they can upload to it.

Ok, UploadHandler?

Rebased and renamed. Uploadable -> UploadReceiver

constructUploadable :(

oops

Sorry I commented on intermediary commits, shown as "chillu commented on outdated diff"


Prepare mix info for hex release

Submit as a draft so we have a place to track remaining work.

Dropping for now as we need some 3rd party dependencies


Update grunt-ng-annotate to 0.10

The build task fails under Node 0.12 unless grunt-ng-annotate is upgraded to 0.10. This addresses bug #102.

+1

+1
It also works with 1.0.1

+1

Guys, I forked this repo last August and updated all dependencies plus optimized the grunt tasks for better usability & speed and added a few more features. See all changes and improvements here.
I was thinking to add more features to it, like Angular 1.5 Components/Router, Material Design, Flexbox, RxJs, maybe prebuilt components like user authentication and some others but since there was not so much activity on that repo I decided to keep those for myself :)


chore(pinia-orm): Remove deprecated tsconfig suppressImplicitAnyIndexErrors

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
MInor updates are not working cause of typscript update

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (585b6f6) 99.64% compared to head (8eb06ec) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   99.64%   99.64%
=======================================
  Files          88       88
  Lines        5882     5884    +2
  Branches      538      538
=======================================
+ Hits         5861     5863    +2
  Misses         19       19
  Partials        2        2

Impacted Files
Coverage Δ

...pinia-orm/src/composables/collection/useGroupBy.ts
100.00% <100.00%> (ø)

.../pinia-orm/src/composables/collection/useSortBy.ts
100.00% <100.00%> (ø)

packages/pinia-orm/src/model/Model.ts
100.00% <100.00%> (ø)

...rm/src/model/attributes/relations/BelongsToMany.ts
100.00% <100.00%> (ø)

...-orm/src/model/attributes/relations/MorphToMany.ts
100.00% <100.00%> (ø)

packages/pinia-orm/src/query/Query.ts
99.52% <100.00%> (ø)

packages/pinia-orm/src/support/Utils.ts
97.83% <100.00%> (+0.01%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fetch project card data from json

Feature Request
Describe your problem
Fetch project card data from the JSON file like team page.
team page

Hi @garvitchittora @Tlazypanda
Shall i work on this issue?Could you assign this issue to me?

@Thilagavathi1 sure, go ahead.

Have raised my PR.Please check this and let me know.


Fix generating path to placeholder

Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

@artursmet I'm afraid this could break CloudFront and result in the storefront linking directly to S3.

There is a similar issue with #1999 if you look at the end of the issue, on the screenshots. But I'm thinking about opening a PR that will include/ copy the SVG file into the mail source if that's sound okay, I never got any feedback.

@patrys I think it should solve the issue for now. If this is not the right approach, then we have a more general problem since this is the standard way to how we currently reference static files.


Fix mock issue when running db_dev_e2e_populate

Summary
In #8226, I partially turned off the payment request cache because it could lead to incorrect pricing in some scenarios (plus it didn't seem to be having the performance impact we had first thought).  Unfortunately, I didn't realize that we limit mock calls in one spot in some E2E test data setup for a payment request, so make db_dev_e2e_populate started to fail in master.  I'm not exactly sure the reasoning behind why we have the limits there, but I didn't want to remove all the limits entirely without digging in further.  So, to get us moving again, this PR just increases the limits on two distance calls (when the zip3s match) to be the minimum threshold required for a successful run.
Setup to Run Your Code
Run make db_dev_reset db_dev_e2e_populate and verify that it completes successfully.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 2f98929baf19b71e27d8863ea501d555a0485d9d


Please provide alternative to optaining compressed firebug light from https://getfirebug.com/

In the past I could inlude a link to http://getfirebug.com to retrieve a compressed version of firebug light:

Hello world

That does not work anymore.
=>Please provide a compressed version in this github repo.
Also see
https://stackoverflow.com/questions/58521474/how-to-include-firebug-light-without-access-to-http-getfirebug-com

Try<EMAIL_ADDRESS>


Issue with SA1003 cast and ':' operator must not appear at the end of a line.

Such code:
var loggerFactory =
                (ILoggerFactory)
                GlobalConfiguration.Configuration.DependencyResolver.GetService(typeof(ILoggerFactory));

gives error:
Error	SA1003	Operator '(ILoggerFactory)' must not appear at the end of a line.
and this code:
class SomeClass : SomeBaseClass
{
    public NullExpiryYearMonth() :
        base(
        null,
        null)
    {
    }
}

gives error:
Error	SA1003	Operator ':' must not appear at the end of a line.
In both cases it didn't give error in StyleCop Classic. I think we should change it to comply with StyleCop classic.

This is an duplicate of #1300 (which I was surprised to see, considering you reported two separate items).

Sorry about that!
I was so happy to finish migration of existing project to StyleCop.Analyzers that I quickly wanted to give feedback about this rule I had issues with. I forgot to check if it was already mentioned before. Stupid me :(
I agree with with what was discussed in #1300.
BTW thanks for working on this project! I was able to migrate exisiting solution with old StyleCop and now I can use VS2015 with new c#6 features and Stylecop rules. Great work!

@mpawelski Duplicates are not a problem, I just didn't want to see your feedback get lost. :smile:


AI deploy llama 2 streamlit

Here is a new tutorial dedicated to the deployment of LLaMA 2 Models on OVHcloud AI Deploy product.
LLaMA 2 will be run in a Streamlit application.
To work properly, you need to follow the requirements (request access to models, create a token).
Once granted access, please make sure to have enough memory in your AI Deploy environment to run the model. (For example 1 GPU will be enough for the Chat 7b parameters version, but not for the 13 B parameters one).
The app allows use to use any model, but please make sure you use LLaMA 2 Chat version. These models have been fine tuned for dialogue use-cases, which is what we use in this app.
@eleapttn Tell me if you would like to try the code before merging this PR.

@philippart-s For your information, here is a new app about LLaMA 2 😉.

✅ Pushed code cloned and successfully deployed on AI Deploy


Need to add CVE value to 3 existing GHSA advisories which have no CVE values

Since the normal "Suggest improvement" process does not

let me add a CVE value to an existing GHSA advisory or

just add a comment requesting a CVE value be added,
I have created this issue to request that GHSA add this CVE value: "CVE-2021-41275" to these 3 no-CVE value GHSA advisories:

GHSA-6mqr-q86q-6gwr.yml (no CVE)

GHSA-8xfw-5q82-3652.yml (no CVE)

GHSA-gpqc-4pp7-5954.yml (no CVE)

References:

https://github.com/rubysec/ruby-advisory-db/blob/master/gems/spree_auth_devise/CVE-2021-41275.yml
https://github.com/advisories/GHSA-26xx-m4q2-xhq8 (yes CVE)

We will deal with this limitation of not being able to add a CVE # to an existing advisory on our side.


Permission APIs

Agreed. I'm experimenting with some stuff, I might remove it and just use sole on Apple platforms too if it doesn't pan out.

Oh, that makes sense. I was going to ask if there were different rules for RAII inside copy constructors, but what you said makes more sense.

I'll take care of these review comments today & tomorrow (inc. adding tests for Any).

I am aware the build is broken on Linux. I'm bringing up another VM to debug it and will fix it by tomorrow morning. Development on macOS platforms should not be affected.

I'm happy to continue addressing comments in follow-up PRs, if anyone has any.


Fix errors detected by go vet. [phab:D745]

Created by fromberger at 2016-02-25 21:13:31:

zarko accepted this revision at 2016-02-25 21:20:58

fromberger closed via commit bf9967b1728483827131dfd27855845cf159fa5c at 2016-02-25 21:25:21


[python3] Build failure on arm64-osx

Package<EMAIL_ADDRESS>Host Environment

Host: arm64-osx
Compiler: AppleClang <IP_ADDRESS>00309
vcpkg-tool version: 2024-06-10-02590c430e4ed9215d27870138c2e579cc338772
vcpkg-scripts version: b2fd29fec 2024-07-16 (7 hours ago)

To Reproduce
vcpkg install
Failure logs
CMake Warning at /Users/aliddell/.cache/vcpkg/registries/git-trees/24bb8d2b3db0a12a7ca7f04061f632f0e94abcc2/portfile.cmake:7 (message):
  python3 currently requires the following programs from the system package
  manager:

      autoconf automake autoconf-archive

  On Debian and Ubuntu derivatives:

      sudo apt-get install autoconf automake autoconf-archive

  On recent Red Hat and Fedora derivatives:

      sudo dnf install autoconf automake autoconf-archive

  On Arch Linux and derivatives:

      sudo pacman -S autoconf automake autoconf-archive

  On Alpine:

      apk add autoconf automake autoconf-archive

  On macOS:

      brew install autoconf automake autoconf-archive

Call Stack (most recent call first):
  scripts/ports.cmake:192 (include)

-- Using cached python-cpython-v3.11.8.tar.gz.
-- Cleaning sources at /Users/aliddell/repos/vcpkg/buildtrees/python3/src/v3.11.8-31d17ab840.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/aliddell/repos/vcpkg/downloads/python-cpython-v3.11.8.tar.gz
-- Applying patch 0001-only-build-required-projects.patch
-- Applying patch 0003-use-vcpkg-zlib.patch
-- Applying patch 0004-devendor-external-dependencies.patch
-- Applying patch 0005-dont-copy-vcruntime.patch
-- Applying patch 0008-python.pc.patch
-- Applying patch 0010-dont-skip-rpath.patch
-- Applying patch 0012-force-disable-modules.patch
-- Applying patch 0014-fix-get-python-inc-output.patch
-- Applying patch 0015-dont-use-WINDOWS-def.patch
-- Applying patch 0016-undup-ffi-symbols.patch
-- Applying patch 0018-fix-sysconfig-include.patch
-- Applying patch 0002-static-library.patch
-- Using source at /Users/aliddell/repos/vcpkg/buildtrees/python3/src/v3.11.8-31d17ab840.clean
-- Getting CMake variables for arm64-osx-dbg
-- Getting CMake variables for arm64-osx-rel
CMake Error at scripts/cmake/vcpkg_configure_make.cmake:721 (message):
  python3 requires autoconf from the system package manager (example: "sudo
  apt-get install autoconf")
Call Stack (most recent call first):
  /Users/aliddell/.cache/vcpkg/registries/git-trees/24bb8d2b3db0a12a7ca7f04061f632f0e94abcc2/portfile.cmake:274 (vcpkg_configure_make)
  scripts/ports.cmake:192 (include)

Additional context
vcpkg.json
{
  "dependencies": [
    {
      "name": "blosc",
      "version>=": "1.21.5"
    },
    {
      "name": "nlohmann-json",
      "version>=": "3.11.3"
    },
    {
      "name": "pybind11"
    },
    {
      "name": "python3"
    }
  ]
}

I get this same exact issue, except I'm trying to install the Boost library. Using C++ in a MacOs environment is proving to be a pain.

Still happening

@aliddell what did you do to fix this? Is there a patch that's needed or a workaround?

@SpiritDogstar This issue had a clear error message and instruction:
CMake Error at scripts/cmake/vcpkg_configure_make.cmake:721 (message):
  python3 requires autoconf from the system package manager (example: "sudo
  apt-get install autoconf")

This issue is still happening on OSX.
eg:
https://github.com/microsoft/vcpkg/issues/41055
These are already brew installs:
python3 currently requires the following programs from the system package
manager:
  autoconf automake autoconf-archive

On Debian and Ubuntu derivatives:
  sudo apt-get install autoconf automake autoconf-archive

On recent Red Hat and Fedora derivatives:
  sudo dnf install autoconf automake autoconf-archive

On Arch Linux and derivatives:
  sudo pacman -S autoconf automake autoconf-archive

On Alpine:
  apk add autoconf automake autoconf-archive

On macOS:
  **brew install autoconf automake autoconf-archive**

Call Stack (most recent call first):
scripts/ports.cmake:192 (include)

eg:
#41055

No, this is a different problem.

Should I open a new issue for this not working on OSX?

Hmm.. well, if anyone else comes across this and has a fix for the OSX version, please comment! It's still broken for me.

This might not solve anything directly, but provides a work around. I noticed that pybind11 started requiring python3 as a dependency a few months back:
https://github.com/microsoft/vcpkg/commit/e338d66dcdf3fb22b1fa2563b8318446c1e1f9c6
So, using pybind11 at version 2.12.0 doesn't pull it in to fail to build. It doesn't resolve why python3 won't build on arm64-osx, but it's a work around for now for those using pybind11 in vcpkg.

got same problem here, and I think the bug occurs recently. I reinstalled the vcpkg things early this morning, and now all the related-python stuff in vcpkg cannot work properly, especially the failure for building pybind11 and boost. However, I am pretty sure that before this reinstallation, everything works well on my mac.
run 'brew install boost' and manually install pybind11 from their github page can solve my problem temporarily.
error: building python3:arm64-osx failed with: BUILD_FAILED
See https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Elapsed time to handle python3:arm64-osx: 4.9 s

@yulu0131 Open a new issue with all relevant information.
READERS, this issue was for missing tools from the host. And the output clearly show how to install the missing tools. Read it, do it.


hls_time: Invalid chars on ffmpeg version 3

Describe the bug
HlsOutputBuilder is incompatible with the hls format used in ffmpeg version 3.
FFmpeg switched from second based value (eg. 120) to the format we use (2:00, hh:mm:ss) in version 4.
Therefore, the hls output is partially incompatible with version 3 (and probably lower)
To Reproduce
Running FFmpegHlsOutputBuilderTest while using ffmpeg version 3.
Expected behavior
To avoid this, we should probably use the second based representation instead.
Alternatively, I could stop testing on ffmpeg version 3.
Version (if applicable):

OS: any
Java Version 8+
FFmpeg version 3 (Not affecting 4 and higher)

Additional context
Console:
ffmpeg -y -v error -i src/test/resources/net/bramp/ffmpeg/samples/big_buck_bunny_720p_1mb.mp4 -f hls -b:v 1000 -hls_time 00:00:05 -hls_segment_filename tmp/file%03d.ts -hls_init_time 00:00:00.003 -hls_list_size 3 -hls_base_url test1234/ tmp/output.m3u8
[hls muxer @ 0x5315b00] [Eval @ 0x7ffe7282f2d0] Invalid chars ':00:05' at the end of expression '00:00:05'
[hls muxer @ 0x5315b00] Unable to parse option value "00:00:05"
[hls muxer @ 0x5315b00] Error setting option hls_time to value 00:00:05.

Reverted the commit due to unexpected compatibility issues.
I can't provide a more sophisticated fix until async is merged.


Migrate the ./sway-lib-std/tests into the E2E stdlib directory and get them all working

Follow-up to #1052.
Previously under the sway-lib-std repo the tests within the tests directory weren't actually run under CI. Now that we've moved them into the sway repo, it would be nice if we could migrate these tests into the existing E2E test harness, I'd imagine under should_pass/stdlib might make sense.
@nfurfaro would you be interested in having a go at this? I haven't yet looked closely at how the sway E2E harness and the sway-lib-std harnesses differ just yet, but perhaps you're already a little more familiar and might already have an idea on how to go about this?

@mitchmindtree I could work on this, yes.
I think it's worth discussing the best approach, as the 2 test harnesses are quite a bit different.
FWIW, I was actually thinking about migrating the remaining stdlib tests out of the e2e harness and into the stdlib one (there aren't too many left as I've already ported some).
It would be good to have @sezna or @otrho chime in here as well, but I quite like the stdlib harness for working with contracts and the SDK. The e2e harness is not currently adequate for testing contracts (unless it has changed since I last worked with it) .
Could we keep the tests separate, and have CI run them both?

Could we keep the tests separate, and have CI run them both?

I think I'd be fine with either approach as long as it's all tested via CI.
That said, if the E2E test suite is lacking w.r.t. contract testing, maybe that's something that could be improved there? I believe there are a few contract tests in there though, so it might have indeed evolved a little since you last worked with it.
Also of note: the tests were recently split into should_pass and should_fail, each with sub-directories for the different kinds of tests (e.g. stdlib, language, forc, test_contracts, etc), so if we do have the std lib tests separate it would be a bit of an outlier.

There's both #685 and #723 (and others probably) which are both asking these questions.  Contract tests definitely need improving and if the lib harness can address that it'd be great.

I'm wondering if we can start by getting the tests under sway-lib-std/tests running under CI as a first step

Yeah I think I might have underestimated how involved this merger-of-tests might be. I'm happy to add a new CI job to run the sway-lib-std tests independently in the meantime. The README added in #1097 should help with this - I'll open a PR shortly!

Just bikeshedding some ideas here...
What if we:

Move all std-lib tests  into the sway/test repo
Sort all tests primarily by which harness they're using (original or sdk-harness)
Continue to run the tests which are currently in the test dir with the original harness
Continue to run the stdlib tests with the sdk-harness
Migrate the existing stdlib tests in the test dir from the original harness to the sdk-harness

Moving forward, the original harness can be improved with regards to contracts, or tests that need to use contracts can opt to use the SDK harness. An alternate approach would be to just use the sdk-harness for everything, but that seems a bit heavy when you just need to run a tiny sway script as in many of the core language tests.
cc @mitchmindtree @sezna @otrho


[NETBEANS-1733] Ask when downloading nbjavac - backport to 10.0 release

When an ergonomics feature is installed while opening a project, it could download a (GPL licensed!) Javac without asking the user.
This change shows a dialog and let's user confirm or cancel the action.
This request merges into release100 branch - this is a convenience request. It should be merged once #1035 is merged and verified into master branch.

Cancelling the nb-javac installation also cancels the activation on JavaSE feature.

So JavaSE can only be enabled with nb-javac? If I remember correctly @jlahoda put effort into enabling  at least basic IDE features with the JDK javac. If this really makes that work unusable, there should be a followup reinstating the vanilla javac work.

I'd say the current state is good enough for 10.0 - it fixes the licensing blocker. Fine tuning can happen for next version.

Sure ... I'm a bit tired of removing fallout from rash implementations (we are still suffering from the directory reorganisation ...).

JavaSE still can be enabled without nb-javac. See my comments on https://issues.apache.org/jira/browse/NETBEANS-1733

Hmmm, I find the UI to be fairly "not good". It does not say why it is trying to install the plugins, how to recover from the Cancel, etc.
But, can we please make this at least a little bit better for those that run on JDK where we can run without nb-javac? Something along the lines of https://github.com/apache/incubator-netbeans/pull/1037.

Hi all,
Should we doing this for JUnit as well or not? I recall having to download the JUnit jar in previous IDE releases (Oracle era, I think), but I cannot remember why.
Thanks!

@vieiro JUnit was CPL according to wikipedia that license is deemed incompatible with the GPL, so that would have prevented combination. JUnit was relicensed to EPL. EPL v1 + v2 are both cleared by apache legal and that is reflected in the existens of the platform/libs.junit4 and platform/lib.junit5 modules.

Thanks for the explanation @matthiasblaesing !


Render Hidden Row values are undefined

renderHiddenItem={(item, secId, rowId, rowMap) => (

<TouchableOpacity
onPress={() => {
console.log("AAB", rowMap);
....
When I tried to print out the contents of secId, rowId, and rowMap, they were all undefined

Hey @Messi10AP I just tried the above code and I'm not seeing any issues. Can you post a full example of how you're using the SwipeList and I can give it another look? Thanks!

you mean renderHiddenRow? it's deprecated, using renderHiddenItem = (rowData, rowRef) instead. See the latest docs

@Messi10AP I ran into an issue like this where rowMap/rowRef was undefined, and it turned out my keyExtractor in the SwipeListView was not setup properly, and was using undefined values for IDs.

yep, forgot to update this, but I fixed it by adding a properly defined keyextractor


python311Packages.pyenphase: 1.18.0 -> 1.19.0

Diff: https://github.com/pyenphase/pyenphase/compare/refs/tags/v1.18.0...v1.19.0
Changelog: https://github.com/pyenphase/pyenphase/blob/v1.19.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 284463 run on x86_64-linux 1

2 packages built:

python311Packages.pyenphase
python311Packages.pyenphase.dist

Result of nixpkgs-review pr 284463 run on x86_64-linux 1

2 packages built:

python311Packages.pyenphase
python311Packages.pyenphase.dist


infra: Docker images with version tags not being published because of failing builds

Bug Report
Description
Bug Summary:
I tried pulling ghcr.io/open-webui/open-webui:0.2.0 but it doesn't exist and neither does v0.2.1 because these builds are failing with the error ERROR: registry cache exporter requires ref when docker buildx build is being run.
Logs and Screenshots
v0.2.0
https://github.com/open-webui/open-webui/actions/runs/9335788157
v0.2.1 (same error)
https://github.com/open-webui/open-webui/actions/runs/9341217307
Installation Method
Docker
Additional Information
The command line in the logs does indeed seem to be missing the ref value because two of the command line args look like this.
--cache-from type=registry,ref= --cache-to type=registry,ref=,mode=max

Immediately after submitting this issue I noticed PR #2737 which may be fixing this issue, the images still need to be published though.

One way to find out 😂

I spent the last 30 minutes trying to make sense of these build steps, but I have never used these docker actions before and find the documentation lacking so take this info with a grain of salt.
But looking at the logs it seems that one of the build steps failed because latest was used for caching, The PR #2737 solves this by setting latest to false in the flavor input which seems correct.
However, it seems to me like type=ref,event=tag should still be used, and I can't figure out what ${{ github.ref_type == 'tag' && 'type=raw,value=main' || '' }} is supposed to be doing. That said, you might be able to omit the tags part entirely because it uses these values by default:
tags: |
  type=schedule
  type=ref,event=branch
  type=ref,event=tag
  type=ref,event=pr

Or maybe you could use semver type=semver,pattern={{version}}.
So maybe like this since you run that workflow for both branches main and dev as well as for semver tags, but at this point I'm guessing:
tags: |
  type=ref,event=branch
  type=semver,pattern={{version}}

@justinh-rahb can I ask why you closed this issue? This still appears to be an issue with the latest commit to both the main and dev branches failing tests and when I try and install it goes back to 0.1.124

Alright, re-opened. Got anything to add? We have a v0.2.2 tag now, so I took that to mean the issue was resolved.

can I ask why you closed this issue? This still appears to be an issue with the latest commit to both the main and dev branches failing tests and when I try and install it goes back to 0.1.124

Alright, re-opened. Got anything to add? We have a v0.2.2 tag now, so I took that to mean the issue was resolved.

I just pulled the image with version tag 0.2.2 and it seems to be working fine here.

@justinh-rahb @DavidZidar That could be the issue. I am pulling from :main instead of :0.2.2. Currently pulling, dont have great wifi right now so going to take a little bit.

@justinh-rahb @DavidZidar Didnt work, still 0.1.124. I ran sudo docker ps -a and sudo docker images -a and nothing shows up for either. Then I run these and nothing is updated
sudo docker pull ghcr.io/open-webui/open-webui:0.2.2
sudo docker run -d -p 3000:8080 --add-host=host.docker.internal:host-gateway -v open-webui:/app/backend/data --name open-webui --restart always ghcr.io/open-webui/open-webui:0.2.2

@justinh-rahb That weird, I forgot about the site and cleared all cached items in my browser (FF dev edition) and its still 0.1.124. I run sudo docker ps -a  and sudo docker images -a and they both show it being 0.2.2.

With some more experimentation I relised its a different issue (I think). I removed all of the open web ui stuff and closed my WSL terminal (and quit everything in task manager), forgot locatlhost:8080 and cleared cache. Then I refreshed the page and I got Unable to Connect (expected). Opened my WSL terminal and I could access localhost:8080 again without running any commands.
I ran ps aux and I dont see anything that has open-webui or anything along the name of that. I do have some other docker stuff though (see below)
USER        PID  %CPU %MEM    VSZ        RSS             TTY  STAT   START   TIME COMMAND
root         277  0.1       0.5          2801196 93012         ?       Ssl  15:46   0:00       /usr/bin/dockerd -H fd:// --containerd=/run/containerd/conta
root        1344  0.0      0.0          1156276 5252           ?       Sl   15:46   0:00       /snap/docker/2915/bin/docker-proxy -proto tcp -host-ip 0.0.0
root        1351  0.0      0.0          1230008 7132           ?       Sl   15:46   0:00       /snap/docker/2915/bin/docker-proxy -proto tcp -host-ip :: -h
root        1366  0.0      0.0          719564  9788           ?        Sl   15:46   0:00      /snap/docker/2915/bin/containerd-shim-runc-v2 -namespace mob

Alright it seems clear now your issue is unrelated to this thread, and the original poster seems to have had their issue resolved to their satisfaction. I'm closing this again, but please open a thread in the Discussions area or jump into our Discord #troubleshooting channel if you would like more assistance.


Update docs to match changes

Bump to 4.0.1

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          85     85
  Branches       21     21
=====================================
  Hits           85     85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7927510...d48319b. Read the comment docs.


feat: add tag support

it can build on special tag or branch when called
Log: add tag support

/merge


Forgified portals

Would it be possible to make a forge port, preferably for 1.20.1, I know you may receive many suggestions like this one, but I really feel that many people would benefit from a forge port, I can't get connector to work.

Please stop spamming our trackers. My reason has been outlined many times before, please just accept it. Either switch to Fabric or update. We do not have the resources to support multiple outdated versions.


Require validateCode when requesting replacement cards

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/434460
$ https://github.com/Expensify/Expensify/issues/434468
Tests

[ ] Verify that no errors appear in the JS console

First checkout this Auth PR, and then hardcode these lines:

https://github.com/Expensify/Web-Expensify/blob/4fccc5d6258fc9d7879d5cea6c0ced5663cd3334/lib/CardAPI.php#L652 => $response = Auth::requestReplacementExpensifyCard($authToken, $cardID, $reason, validateCode: $validateCode);

https://github.com/Expensify/Web-Expensify/blob/4fccc5d6258fc9d7879d5cea6c0ced5663cd3334/lib/CardAPI.php#L405 => Auth::requestReplacementExpensifyCard($authToken, $existingVirtualCardID, Card::CARD_REPLACEMENT_REASON_STOLEN, validateCode: $validateCode, skipVirtualCardCreation: true);

Have an account with a physical and virtual card.

Report virtual card for fraud, make sure you're asked to enter a validateCode.

Enter a wrong validate code and make sure the request doesn't go through.

Enter the correct magic code and make sure you're redirected to the new card page.

Repeat the same steps by requesting a replacement physical card.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

Have an account with a physical and virtual card.
Report virtual card for fraud, make sure you're asked to enter a validateCode.
Enter a wrong validate code and make sure the request doesn't go through.
Enter the correct magic code and make sure you're redirected to the new card page.
Repeat the same steps by requesting a replacement physical card.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/798915f3-5a26-4ad3-b6d3-7e0d379572c9

MacOS: Desktop

@jjcoffee this needs an internal review due to some backend changes that aren't live and we can't make them live until this PR is deployed.

Let us know when you have screenshots ready to review, cc @Expensify/design

Added a recording @shawnborton!

@thienlnam I've updated the test steps as it's necessary to hardcode some stuff in web-e to test this

Yup I found it weird too. I haven't touched this part in my changes.

Fixed. This was using OfflineWithFeedback which by default shows the error below, but it has an option to display the error above.
https://github.com/user-attachments/assets/0c64b460-6cda-41cf-a3fe-a5afedca4ab4

Good shout Danny, I agree seeing the error below the footer button felt weird - glad we have the option to easily add it above!

Looks like there are some lint failures

Ah, I need to remove usage of withOnyx. Will do tomorrow.

Fixed @thienlnam

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@youssef-lr @francoisl we don't have physical card and we can verify with virtual card only.

@youssef-lr is there a way to test with physical cards without actually requesting a replacement on each platform?

I'm not sure there is, cc @NikkiWines. I think we can check this off for now, nothing has changed once a validateCode is valid, things should work the same as before

🤔 I don't think we have a flow for that. Except maybe you could request a replacement then cancel the request internally which might be tricky timing wise and I'm not to sure exactly how you'd do that.
It's a little dicey to not test the success flow at all on staging or prod, but I'm not sure how to bypass that here

Maybe we could follow the same / similar steps from when this command was initially added here?


GPU Particles have very slow framerate on Wayland

Tested versions

Reproducible in: Godot v4.3.dev3

System information
Godot v4.3.dev3.mono - Fedora Linux 39 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (RADV NAVI22) () - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
Issue description
GPU particles seem to run at something like 1/100 speed.
https://github.com/godotengine/godot/assets/15041324/7f55ec30-684d-4095-b2eb-878529415295
Steps to reproduce

Open Godot with  --display-driver wayland.
Open MRP
Observe Particle systems

Minimal reproduction project (MRP)
mrpwp.zip

That's curious because they literally can't run asynchronously from the rest of the rendering loop, and clearly your frame rate is fine. Perhaps the time where it sources the data from is broken in Wayland?

That's curious because they literally can't run asynchronously from the rest of the rendering loop, and clearly your frame rate is fine. Perhaps the time where it sources the data from for running the compute shader is broken in Wayland?

I was thinking that it wasn't performance related by deltatime related.

This is likely delta time not being set correctly. Can you test https://github.com/godotengine/godot/pull/87750 locally?

This is likely due to the same cause as #87963. Can you test #87750 locally?

I am building this branch now.

Hi @Calinou, I can confirm that particles runs as expected with this branch under wayland.

I tested both master and `#87750, and strangely enough I can't reproduce the bug with the MRP here (but I could reproduce the bug from #87963).
Either way, if it works for @pracedru it's likely good to go anyway :)

@akien-mga uh right, that's another thing of that issue, it's metastable lol. It will fall in into either state: consistently refresh rate or into the tickrate for some reason.
Edit: Oh wait you said that you could reproduce the TIME thing though. Not sure what's goung on the, as long as it works 🤷

Could my recent change in hardware be the reason why it works on my end?

No I just reproduced the issue with the official dev3 build on my current setup.
So it seems to have been fixed with this branch.


Sorted snippets in alphabetical order for sort test

What Changed
Sorted snippets in alphabetical order
Why
fixing test
fixes #53
Todo:

[ ] Add Semantic Version Label
[ ] Add tests
[ ] Add docs

We should add the test + have testing run on prs

yup next on it! adding script to automate pr testing


Best place to add code that will act as "callbacks"?

I'm interested in extending continual_rl by implementing some of my group's own continual RL algorithm ideas. However, there has been some incompatibilities from what I can see so far. I was wondering if anyone had any advice on some of these issues. In particular, I'm interested in running code related to the policy once a task completes (i.e., code that would normally be put inside the policy class). As I mentioned, from what I can tell, there doesn't seem to be a great way of doing this so I figured I'd ask a few questions before proceeding.
First, are there any recommended ways of doing this from the policy side without editing any source code? Meaning, solely from my own custom policy class which inherits from PolicyBase.
Second, would editing the experiment and policy base classes be a reasonable method for approaching this. Essentially, I'd add "callbacks" to the experiment loop that call methods from the policy before a cycle, after a cycle, before a task, and after a task. This is currently the approach I'm learning towards.
If you have any other suggestions or questions feel free to let me know.

In general we discourage having task-specific things, since the direction we prefer is for the whole process to be task-agnostic. That said, we also want this repo to be as useful as possible for as many use cases as possible.
If I'm understanding you correctly, the easiest way to achieve what you want is to look at the task_id, and see if it has changed. We do something like this in progress_and_compress_monobeast.py, compute_loss, to determine when to reset the active column.
If this works for you, this method would be preferred over more callbacks that encourage task-boundary-based logic. Let me know if this won't work, however.

In general we discourage having task-specific things, since the direction we prefer is for the whole process to be task-agnostic.

The current idea is task invariant but requires some extra computation that conveniently fits nicely when transitioning between two tasks (one could think of this as the naive implementation). Theoretically, computing every so many time-steps, similar to how normal RL network training is done, could work too, but I want to try that later down the road.

If I'm understanding you correctly, the easiest way to achieve what you want is to look at the task_id, and see if it has changed.

I didn't think about the task_id, that could possibly work. The only place we have access to the task_id is inside the policy in the compute_action() method, correct?

We do something like this in progress_and_compress_monobeast.py, compute_loss, to determine when to reset the active column.

I'll have to take a closer look at this code and see if I can find what you are referring to.

Yeah, right now the task_spec is passed into the environment_runner, which, if you're using the batch or sync runners, just passes the task_id into compute_action. (The impala_environment_runner is kind of special, for various reasons...but that doesn't seem relevant here.)
I'm not necessarily averse to passing the task_id into train() as well, if it is sufficiently useful (again, I have my task-specific code hesitations but...practicality).
Let me know if you have further questions, about progress and compress or anything else.
(Depending on what you're doing, writing your own environment runner might be a good solution as well, if you want more control over how collecting data and training are intertwined.)

I think for now, using the task_id within the compute_action() method will suffice. I can simply check for when the task_id has changed to know we have moved onto a new task. Conceptually, one can think of the computation I'm trying to do similar to how  evaluation is ran after a task. I simply need to know if a task has ended, nothing else about it. Likewise, eventually, this can be done in a more continual manner, based on total time-steps or something else.
With that, this issue has roughly been resolved. I appreciate all the help! Does this package have a slack channel or some other forum where more basic questions can be asked? If not, I assume opening issues regarding questions is preferred then?

A slack or discord channel is a good idea. I'll set one up over the weekend (probably discord as that's my preferred, but I'll consider). I'll post here and update the README once it's created. I'll close this afterwards.
But posting issues is also fine.

I'll keep an eye out for the link! If it matters at all, I too would support the discord server idea.

Discord created: https://discord.gg/VcNpAspbPm
I'll add it to the README after I've fleshed it out a touch more.