Conditional spread results in weird union type, with duplicates

interface Animal {
    name: string;
    kind: string;
    age: number;
    location: string;
    owner: object;
}

function clonePet(pet: Animal, fullCopy?: boolean) {
    return {
        name: pet.name,
        kind: pet.kind,
        ...(fullCopy && pet),
    }
}

Expected: clonePet returns type { name: string, kind: string, age?: number, location?: string, owner?: object }
Actual: clonePet returns the following type:
{
    name: string;
    kind: string;
} | {
    name: string;
    kind: string;
} | {
    name: string;
    kind: string;
    age: number;
    location: string;
    owner: object;
}

Any clue if this is working as intended @ahejlsberg @weswigham?

Another example that @sandersn had come up with
interface Animal {
    name: string;
    owner?: string;
}
function billOwner(pet: Animal) {
    return {
        ...(pet.owner && pet),
        paid: false
    }
}

I'm a bit surprised the same type is in there twice, but otherwise it's an effect of us not performing union subtype reduction in object literal spreads.

Right - I actually thought that that was where the slowdown originally came from: creating every combination of types of spreads, followed by subtype reduction on extremely similar types. I guess it was just creating the combnations, which is still factorial.

The multiple-of-the-same-object-type thing is something that's always been an unfortunate possibility in a spread. That example you have there gives the same output in older TS, too.

The second output seems more correct to me (ignoring the duplicate union element).
Because I doubt this is desired,
const clone = clonePet(pet, true)
clone.location = undefined //probably not desired?

The duplicate is just "unfortunate" but it's a distraction. I think this behavior is pretty inconsistent otherwise because the real thing I'm reporting is that we're not getting optional properties, and I can't coherently explain this behavior.

The duplicate is directly the cause of the behavior (which also exists in older TS versions provided you use single-property additions). This is because our spread object-combining logic only permits combining exactly two types, so if you have three types (even if two are identical), we skip the whole simplification process and do the big union-all-the-possibilities plan.


Update ev5-esv5-series.md

Fixing one small typo in uncached burst on the E104is size from 80000 to 120000
@mimckitt

@joelpelley : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@joelpelley: I'm sorry - only the author of this article, @styli365, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

#sign-off


Privacy issue

There is no option for privacy ... I found a connection to this IP: <IP_ADDRESS> when I am connecting to my website. Which IP is this ? Does this app collect user data ?

You can inspect the code in this repo yourself, there is no user data collection. The connection to that IP could be from a background app, or from a webapp that's loaded, etc.


Long delay when importing a 5MB file

Describe the bug
I experience a longer delay than expected when loading a file using a JavaScript import :
const start = performance.now()

import data from "5mb-file.json"

const end = performance.now()
console.log(`Delay : ${end-start}ms`) // about 5s

The ~5s delay seems unreasonnable considering the size of the file.
For comparaison using JSON.parse and fs.readFileSync on the exact same file, I'm able to retreive the data in about ~0.1s.
Reproduction
https://github.com/mquandalle/large-import-delay-vitejs-repro
The reproduction contains 2 server-side endpoints showcasing the two import methods (ES module or JSON.parse/fs.readFileSync), and a minimal UI to explain the issue a bit more.
Logs
No response
System Info
System:
    OS: Linux 5.13 Pop!_OS 21.04
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
    Memory: 1.63 GB / 15.40 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.11.0 - ~/.nvm/versions/node/v16.11.0/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v16.11.0/bin/yarn
    npm: 8.0.0 - ~/.nvm/versions/node/v16.11.0/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Firefox: 94.0

Severity
serious, but I can work around it
Additional Information
This issue occurs both on development mode and when the app is deployed and the import called for the first time (example: cold starts on Vercel lambdas)

This is expected because you're transferring a 5MB file over the network. Both in the local server and prod server. Using fs is faster because everything stays locally and there's no intermediate step, so it's a caveat of web dev in general. Closing with the above explanation.

Unless I miss something, I don't see why the import would involve a netwok transfer, as the following lines are executed only on the server:
import data from "data-5mb.json";
console.log(data.length)

and are taking ~5s in the context of ViteJS / SvelteKit. The same script executed with node (with --experimental-json-modules) is nearly instant.

I see. I'll re-open this at the meantime, until we've figured out why the imports are slower on the server side.

The issue seems to only happen in dev mode, not in production or preview.
So it's probably related to Vite processing the import in dev mode.They may be way to opt-out from that behaviour, but I was unlucky with vite.optimizeDeps.exclude.

I've checked the repro out today, filed an issue with Vite at https://github.com/vitejs/vite/issues/6154. It's because Vite has special transforms for JS files during dev mode for HMR, which impacted the loading time for this. However, I don't think JSON files should be impacted by this, since it's just JSON (perhaps I'm wrong but we'll see). Thanks for making a comprehensive repro btw! I'll close this and track the progress over at Vite.


feat: add plugin scroll-snap

Hi @voorjaar thankyou bro) you created powerfully tooling 💪

By the way, the corresponding documents should be updated too.

yup, working 📚


A way to ignore return values of functions that you do not need

Description
Take the following function that removes one element from an array and returns the result:
#let doSomeTest(x) = {
    x.remove(1);
    x
}

#doSomeTest((1,2,3,4))

it fails becaus it cannot join integer with array. As far as I know, you have to place the return of remove into a variable to fix the error like
#let doSomeTest(x) = {
    let unused = x.remove(1);
    x
}

#doSomeTest((1,2,3,4))

Is there any trick? In pure rust, the placement of semicolon decides if the value is returned...
Use Case
Make code more readable.

The cleanest and intended way is let _ = x.remove(1). I think that's fine honestly, I wouldn't say that the placement of a tiny semicolon is any clearer, even if shorter.

Is it expected?
#let doSomeTest(x) = {
    x.remove(1);
    return x
}

#repr(doSomeTest((1,2,3,4))) // -> (1, 3, 4)

let _ = x.remove(1)

I think this would be ok. We might place a hint to that somewhere in the documentation.

return

I'm so into rust, that i did not think about explicitly calling return...


Change object detection use TensorFlowLiteTaskVision

Please remove all code that aren't necessary anymore (e.g. all code under the Extensions folder).

Please also update the RunScripts/download_models.sh to download this model https://tfhub.dev/tensorflow/lite-model/efficientdet/lite0/detection/metadata/1?lite-format=tflite to the Xcode project. This git repo is setup so that .tflite files are not added to the repo to save space. The script is run in the Run Script step of the project's Build Phases

Please also fix all build warnings.


Fixes #1432: catchThrowableOfType - stack trace of the original exception is lost

Check List:

Fixes #1432
Unit tests : YES
Javadoc with a code example (API only) : NA

Integrated thanks @ssmyth2!


[BUG] BlockBlobWriteStream does not implement IAsyncDisposable

Library name and version
Azure.Storage.Blobs <IP_ADDRESS>
Describe the bug
When using
await using (var stream = await blockBlob.OpenWriteAsync(true))

await stream.WriteAsync(new byte[4]);

Because of missing DisposeAsync implementation in BlockBlobWriteStream, generic implementation is called on Stream base class. This implementaiton calls sync Dispose()  witch consequently calls Flush() - synchronous
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Common/src/Shared/StorageWriteStream.cs#L227
 public override void Flush()
            => FlushInternal(
                async: false,
                cancellationToken: default).EnsureCompleted();

and in this FlushInternal there is StagingBlock if needed. And then block ids are always commited. - synchronous
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Blobs/src/BlockBlobWriteStream.cs#L87
There is no way to avoid it, if I manually call FlushAsync() before DisposeAsync(), then in FlushInternal no blocks are staged, but I cannot avoid synchronous call for commiting block ids.
Am I missing something?
Expected behavior
DisposeAsync is properly implemented, so there is no sychronous call when using async API.
Actual behavior
DisposeAsync is not implemented/overriden, so when DisposeAsync is called, sychronous call from Stream base class to store block ids is done.
Reproduction Steps
await using (var stream = await blockBlob.OpenWriteAsync(true))

await stream.WriteAsync(new byte[4]);

Environment
No response

Any update?

Adding Service team to look into this.

Hello, any update? Is anyone there? @jsquire

@klesta490:  I apologize that this has not been followed-up on.  Unfortunately, I do not have direct insight here.  We'll need the folks that own the Storage library to offer thoughts.
//cc: @seanmcc-msft, @amnguye
//fyi: @schaabs

Hello, is there any progress? @jsquire

@mkopsa-quadient : The answer is the same as the one right above your comment.  This is not an issue that I will have insight on and requires the owners of the issue to offer thoughts.

OK. Can @seanmcc-msft or @amnguye answer?


Replace calls to django.conf.urls.url with path and re_path

Fixes #4433
This is a (very large) PR that will replace calls to django.conf.urls.url() with django.urls.path() or django.urls.re_path() where appropriate.
path() introduces simpler routing syntax and was introduced in Django 2.0: https://docs.djangoproject.com/en/3.0/releases/2.0/#simplified-url-routing-syntax
TODO:

[x] Fix import sorting issues
[x] Simplify regexes to use path converters where possible.

I think especially the fairly complex url patterns benefit from this new syntax. It's much clearer although more verbose now.
I'd love to get a review and input on this!

Replaced by #6210

Thanks for completing this @gasman :slightly_smiling_face:


Channel icons missing at smaller window sizes for app/lbry.tv

Channel icons at frontpage disappear in 3-in-row layout - and are present at 4-in-row one. Former having larger items, so way more space available...

Thanks for filing! Also, since we show 8 items, there's a seemingly missing tile in the last row that looks strange.

Ah yes, forgot to mention that. Some sections also had like 4 - mostly had multiples of 4, tailored for 4-in-row layout. Trending from my tags has 7 at the moment, trending from lbry the same. That could be made layout-dependant, so no short rows, no matter which layout variant is in use.


clarify upstream is a preview feature.

@vwxyzh : Thanks for your contribution! The author(s) have been notified to review your proposed change. @chenyl

Hi @zackliu - Would you review this update to your article? Also, to support PRMerger automated notification of contributions made in the public repo, would you change the metadata author attribute to your GitHub alias? Thanks.

@ktoliver  Yes, it's a preview feature. For the author attribute, I can create another PR to change it.

Thanks.


Spring5

Experimental branch to support Spring5
✅ Unit tests working
✅ Integration tests working
🔲 Clean up warnings
🔲 Update AWS DynamoDB SDK
🔲 Add consistent header/formatting to the source code file
Feel free to pull & build locally to test it out: mvn install

Codecov Report

Merging #100 into master will increase coverage by 0.42%.
The diff coverage is 46.87%.

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     40.49%   40.92%   +0.42%
- Complexity      337      338       +1
============================================
  Files            64       64
  Lines          1768     1757      -11
  Branches        348      344       -4
============================================
+ Hits            716      719       +3
+ Misses          944      927      -17
- Partials        108      111       +3

Impacted Files
Coverage Δ
Complexity Δ

...pository/config/DynamoDBRepositoriesRegistrar.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...data/dynamodb/query/QueryExpressionCountQuery.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...dynamodb/mapping/DynamoDBPersistentEntityImpl.java
41.66% <ø> (ø)
3 <0> (ø)
:arrow_down:

...ository/support/DynamoDBRepositoryFactoryBean.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...mapping/event/ValidatingDynamoDBEventListener.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...tory/config/DynamoDBRepositoryConfigExtension.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../data/dynamodb/query/ScanExpressionCountQuery.java
81.81% <ø> (ø)
3 <0> (ø)
:arrow_down:

...namodb/mapping/AbstractDynamoDBDateMarshaller.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...rt/DynamoDBHashAndRangeKeyMethodExtractorImpl.java
60.46% <ø> (ø)
6 <0> (ø)
:arrow_down:

...DBHashAndRangeKeyExtractingEntityMetadataImpl.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16aa4b6...5a7ef94. Read the comment docs.


[upb] cast to (upb_Message*) when calling upb functions

upb currently defines upb_Message to be void, which has allowed us to be lax with the types when calling upb functions that take a (upb_Message*) as an arg.
If that ever changes (which may happen quite soon) things will break, so this is a pre-emptive patch to protect against such a change.

Please use C++-style cases instead of C-style casts.

Will do. Closing for now.


Unstable test on Travis: BufferingTargetWrapperAsyncTest1

See https://travis-ci.org/NLog/NLog/builds/250136516
and
https://travis-ci.org/NLog/NLog/builds/284469275

Could be solved by adding AsyncOperationCounter to the test-target MyAsyncTarget

could you give me a hint how to use the AsyncOperationCounter (https://github.com/NLog/NLog/blob/master/src/NLog/Internal/AsyncOperationCounter.cs) here?

See MyAsyncTarget in AsyncTargetWrapperTests

@snakefoot if you find some time in fixing this, then please. it's really delaying the merge of PRs and the release.


fix: remove scale logic in getBoundingClientRect

Fixes issue with elements of non-integer sizes (https://github.com/popperjs/popper-core/issues/1351#issuecomment-918015006)
The logic for the scaleX / scaleY is faulty as explained in the comment, I can't quickly think of a solution but positioning is broken for all elements that aren't an integer of width or height. I think it takes priority over the scaling based on the issues I've been receiving for Tippy

Thanks, too bad we need to revert that feature.


Enable CORS

It sure would be nice if there was a bit more explanation around the --namespace Microsoft.Web and --resource-type config parameters given that I tried what's there and got an error. I have NO IDEA how I'm supposed to know what this magic "provider" namespace is supposed to be. Also, "provider"?! Okay, provider of WHAT exactly?!  :facepalm: :(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbcc24f0-9856-a7db-f229-c383e5e5c57d
Version Independent ID: 55d51b2a-c8fe-086e-a1c2-b0592f57967c
Content: Tutorial: Host RESTful API with CORS - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-rest-api.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Actually, I think I found the answer on this page: https://docs.microsoft.com/en-us/cli/azure/webapp/cors?view=azure-cli-latest
Will test it first thing in the morning.

@CmdrBeavis Thanks for the feedback! We are currently investigating and will update you shortly.

Okay, so yeah, this az resource update --name web --resource-group myResourceGroup --namespace Microsoft.Web --resource-type config --parent sites/<app_name> --set properties.cors.allowedOrigins="['http://localhost:5000']" --api-version 2015-06-01 command was way too problematic and didn't have enough explanation about all the moving parts, so I went with az webapp cors add -g MyResourceGroup -n MyApiApp --allowed-origins http://localhost:5000 instead, which worked great and was way less complicated.

@CmdrBeavis Glad to hear that you got it working. Appreciate for sharing the steps which helped you, this would certainly benefit other community members.
To add to this the details of az resource update command is here in which --namespace is Provider namespace (Ex: 'Microsoft.Provider') and here provider means Azure resource provider and types, when deploying resources, you frequently need to retrieve information about the resource providers and types. For example, if you want to store keys and secrets, you work with the Microsoft.KeyVault resource provider. This resource provider offers a resource type called vaults for creating the key vault.
You may refer to this article which shows how resource provider namespaces map to Azure services. Search for Microsoft.Web which is for App Services and Function.
Hope this helps.

@CmdrBeavis We will close this out but if you feel you need more information please just let us know.


[RFE] OS reset helper

Current situation
Factory reset is something common for consumer devices but it also is useful for servers when we follow the idea of immutable infrastructure and want to "reprovision" to apply a config change but newly installing the OS takes too long or is too disruptive due to local data.
We have example usage with terraform helper scripts in the without-instance-replacement variants of https://github.com/flatcar/flatcar-terraform
Impact
It's not easy for users to discard local changes. The Ignition reformat hammer is not bad but requires special knowledge and a custom ignition config entry and loses local data.
Ideal future situation
We have a flatcar-reset helper that allows to either fully or selectively reset the OS.
The full reset is by wiping the rootfs (could be rm -r, or could be by triggering the systemd-repart factory reset mode with some special GPT disk uuid), and creates the first boot flag file for Ignition to run.
The partial reset is by doing a recommended wildcard removal before reboot (allow or deny mode, preferred is allow), then creating the first boot flag file for Ignition to run. It should preserve the machine id by writing it to grub.cfg because keeping /etc/machine-id is not allowed with Ignition.
Implementation options
Additional information

Finally done and should be part of the next Alpha


Update Vitest to 1.6.0

This PR is targetting #1846.
Description
This PR updates the Vitest version used in the monorepo to the latest version instead of the initial 1.4.0 bump due to a test failure.
Why was this test failing when upgrading to at least Vitest 1.5.0?

Vitest 1.5.0 introduced a change to the workspace feature current working directory (cwd) making it the config directory.

Using version 1.4.0, the current working directory would be packages/starlight/
Using version 1.5.0, the current working directory would be packages/starlight/__tests__/i18n-non-root-single-locale/ for the i18n-non-root-single-locale test suite.

Our tests use getViteConfig() which will internally call resolveConfig() which calls resolveRoot() with an undefined argument which would end up using process.cwd().
With Astro now using packages/starlight/__tests__/i18n-non-root-single-locale/ as the root, packages/starlight/__tests__/i18n-non-root-single-locale/src/content/i18n/fr.json would be automatically loaded when we call getCollection() which was not the case before.

Why is only the i18n-non-root-single-locale test suite failing and not the i18n test suite which uses a similar setup?

The i18n test suite is not impacted because the default locale is en but is configured with a lang using a regional subtag (en-US) which means the user config overrides needs to be in for en-US and thus not being impacted by en.json being loaded.

How is this PR fixing the issue?

This PR updates the i18n-non-root-single-locale test suite to use the fr-CA for the lang of the default locale to use the same setup as the i18n test suite.

What alternatives were considered?

Using Astro 4.8.0 getViteConfig() new second argument to specify the root in the inline Astro config to fallback to the previous behavior and avoid using process.cwd() but I think this is wrong to just assume the CWD is not the root of the test suite.
Moving out the packages/starlight/__tests__/i18n-non-root-single-locale/translations-fs.test.ts to another dedicated suite (where we do not mix real CC files and CC mocking). I think this is a valid one but we would need I think to do the same for the i18n test suite which is not failing. I think it's better to have a consistent setup for all the test suites but I'm open to feedback on this.

Why are the .gitignore changes in this PR required?
By Astro now using the proper root, and getViteConfig() somehow triggering someting close to astro sync, we end up with all the extra files in each test suites instead of just packages/starlight/ like before when this folder was considered the CWD.

One question: do you think it makes most sense to merge this into the MDX v3 branch or is it better to target main and then I can rebase the MDX v3 branch on top of these changes?

I initially targeted the MDX v3 branch as it's the one that needed the Vitest update (due to Vite 5.1 changes with the Astro bump) but technically, I guess this could also makes sense to target main as it kinda ends up being an unrelated issue :thumbsup: Up to you, I'm fine with either way, let me know if you want me to update it so that it can target main.

Let's target main then if you have time to do that — helps us avoid bundling up too many changes in one PR. Thank you!

This should be good, also pushed an empty commits to re-run all the workflows as I think there is still no event so that the workflows can be triggered after the base branch change.


VS Code shows lint errors for getters and setters: "Accessors are only available when targeting ECMAScript 5 and higher" for new RC.0 projects

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 10

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
@angular/cli: 1.0.0-rc.0
node: 6.10.0
os: win32 x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

ng new test-app (Angular CLI RC.0)
Open with VS Code
Add getter/setter inside app component

The log given by the failure.

Normally this include a stack trace and some more information.
Shows lint error: "Accessors are only available when targeting ECMAScript 5 and higher"

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

@ogix I think you needs to add es5 in tsconfig.json at root conf file
...
"lib": [
   ...
   "es5",
   ...
 ]
...

Actually only adding "target": "es5" at root tsconfig.json helped. I wonder if it is the only solution.

Added "target": "es5" to tsconfig by default https://github.com/angular/angular-cli/pull/5060


fix: better fix for io blocking

Proposed change

Better fix for IO blocking issue
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR is related to issue: #906 #908

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.44%. Comparing base (8608d22) to head (001bfe2).
Report is 5 commits behind head on dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #921      +/-   ##
==========================================
- Coverage   95.07%   94.44%   -0.63%
==========================================
  Files           8        8
  Lines        1482     1530      +48
==========================================
+ Hits         1409     1445      +36
- Misses         73       85      +12

Files
Coverage Δ

custom_components/mail_and_packages/__init__.py
93.54% <100.00%> (+1.44%)
:arrow_up:

custom_components/mail_and_packages/const.py
100.00% <ø> (ø)

custom_components/mail_and_packages/helpers.py
93.08% <100.00%> (-1.64%)
:arrow_down:

... and 2 files with indirect coverage changes


RPM not installing current version

Sonarqube is no longer supporting RPMs with the current version.
https://community.sonarsource.com/t/is-a-native-packages-repository-still-maintained/1228
Fix recommendation:
Revert back to the .zip install method
or
generate RPM in house.

generate RPM in house.

See pkg-sonarqube. Could incorporate into a Jenkins job ...only downside would be that RPMs wouldn't be signed. Basically:

Clean deploy environment
Fetch sources and build/store RPM
Build EC2 — referencing new RPM's storage-location


Does this module support auto adjusting column width?

Does this module support auto adjusting column width?

Nope, but check #36 to read the author vision


[Doc]: Contributor update

Describe your documentation update
@all-contributors please add @zhangshixuan1987 for code and test

@all-contributors please add @zhangshixuan1987 for code

@all-contributors please add @kristinchang3 for code


do not allow qualification of member variables with this

Description
Code like this.foo = foo is common elsewhere in the Java ecosystem, but pinot prefixes member variables with an underscore. Style violations like this._foo = foo frequently come up in code review, and this PR automates enforcement of this style.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Thank you so much for taking care of these things.
This will allow us to focus on reviewing code logic vs formatting and style

flaky test

MetadataAndDictionaryAggregationPlanClusterIntegrationTest.setUp:67->ClusterTest.uploadSegments:356


I see that,WE ARE LOOKING FOR CONTRIBUTORS.

How to join ramme.

Just send some PR to fix opened issues :+1:


Normalize output

Currently if I look up "diabetes" I get both HP and MONDO terms for T2D.  But in Translator, we've unified these things.   So you should only get back the MONDO term.  In other words, the results should be normalized.
However, you still want to search the HP lexical synonyms.
Probably the eventual solution will involve #7 but for now we could call the node norm service.

Yes, I believe this is complete


[Feature]: Support Quick-Copy/Drag-and-Drop for Annotations

Debug log ID
HL9V2ZBK-refs-euc
What happened?
Basically what I'd like to achieve is dragging and dropping notes from Zotero to VSCode to insert a citation that is also containing the page number.
What is working fine for me, is dragging and dropping the whole library entry to insert a citation key as defined in Edit -> Preferences -> Better BibTex -> Export -> Quick-Copy.  In my case, this will yield \footcite[\vglf][\pagef]{russell2020} since that's the command that I have defined for the LaTeX citation Quick-Copy format.
What I'd like to do though, is mark something in a pdf, do an Add notes from Annotations and then drag and drop a single annotation into my text editor to get \footcite[\vglf][\pagef1]{russell2020} (note the page number here).
Expected:
\footcite[\vglf][\pagef1]{russell2020}

What I got:
â€œIntroductionâ€ ([Russell and Norvig, 2020, p. 1](zotero://select/library/items/CCC6AHWQ)) ([pdf](zotero://open-pdf/library/items/EYZYFJB9?page=29&annotation=DTQM433Y))

In the 2nd item of HL9V2ZBK-refs-euc, would the correct page number be 1423, or 1450?

Well, that's a bit of question of definition. Zotero supports manually adjusting page numbers, such that it matches the number that is printed/visible on the page you are citing. I think I did that here and accordingly the 1423 is the page number that I wanted in the citation.

What would be the page number you would want to see between those two?


Add resource labels to metrics

Description
Add, by configuration, scanned resources labels into the prometheus metrics with a configurable prefix.
Related issues

Close #478

Checklist

[x] I've read the guidelines for contributing to this repository.
[x] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.hector.arranz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

The biggest changes have been in the collector.go file.
I had to do a little refactor to make it workable. I have moved all the prometheus descriptors, labels and severities that were in global variables, to a struct that will go inside the ResourcesMetricsCollector.
This is because the labels are no longer fixed, but instead vary according to the configuration, so they must be generated once we have the configuration data.
I have added a constructor for ResourcesMetricsCollector to build the labels and the descriptors based on the configuration.
I don't know if I have added enough tests, or if I should add any integration tests.
I haven't added any documentation yet until I'm sure the implementation will look like this.
I have tried to make small meaningful commits instead of one big one, to be able to see the evolution of the code. (even knowing that in the end there will be squashed).
First time using Conventional Commit.
And last but not least, yes, the names I have chosen are probably not the best, so I am totally open to changing them if there are suggestions.


How to get help section added

Hello @aytida0606,
How to help section with information and verified links added in the single.html file
Under #122 issue
Screenshots as follows:

Let me know if any changes need to be made. Thankyou.

@Parul-Mann fetch the changes and resolve the conflicts


Crashing Upon Opening

I use Fedora if that means anything. Whenever I'd try to open the game, it would just crash. So I ran it in the terminal flatpak run sh.ppy.osu and this popped up as the error:
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at osu.Framework.Input.Handlers.Tablet.OpenTabletDriverHandler.Initialize(GameHost host)
   at osu.Framework.Platform.GameHost.initialiseInputHandlers()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at osu.Desktop.Program.Main(String[] args) in /home/runner/work/osu-auth-client/osu-auth-client/osu/osu.Desktop/Program.cs:line 120

I didn't know if it was just my computer or the flatpak itself so I asked my friend if they could run lazer on their flatpak and they also got the same error. I'm not a very tech savvy person so if I'm requested to do anything, I'm most likely not going to know how to do it.

You may not be tech savvy, but please at least learn to search. https://github.com/ppy/osu/discussions/23900


Metastore possibly becomes corrupt when Quasar gets JVM OutOfMemoryError

This is more of a suspicion than a known fact, but since it has happened at least one verifiable time before, and several suspected other times, I think it needs addressing.
To reproduce, I would imagine that giving the JVM a very constrained memory profile (-Xms128m -Xmx256m) would cause this pretty quickly, given a large dataset and a complex query.
While this has proven to corrupt the metastore with at least one customer, I'm curious if it might also corrupt the quasar-config.json file in the Community Edition as well somehow.
If this is difficult to reproduce or determine, let me know and I'll spend the time gathering data, setting up an environment, etc.  Too important to not address, even if I'm wrong in my description.

@damonLL When you get a chance, please try to reproduce to save engineering time in fixing it.

In an effort to reproduce the issue I've repeatedly run the JVM out of memory without seeing metastore corruption. Perhaps this happened to coincide with one the the other corruption issues that has been addressed. @damonLL have you seen this occur recently or been able to reproduce?

@drostron I have not seen it recently, no. The last time was several months ago so if you've tried unsuccessfully to corrupt it via OutOfMemoryError then I would say there isn't much left to do. Perhaps all of the metastore resilience changes recently have addressed it.

@damonLL Ok, closing for now. Please reopen with any additional context if you happen to see this again.


Allow NULL pointer for mrbc_raw_free() when NDEBUG

Actual
if you call mrbc_raw_free(NULL);, SEGV happens
Expected
Nothing happens

Background
In the section <IP_ADDRESS> of ISO/IEC 9899:1999, free() is allowed to be passed NULL:

If ptr is a null pointer, no action occurs.

See http://www.man6.org/lib/pdfjs/web/viewer.html?file=/blog/PdfFile/c99InternationalStandard.pdf
The above would be why some libraries (eg: ruby/prism) that comply with C99 call the free() without NULL-check.
In that case, when MRBC_DEBUG is undef, there should be no warning, much less a SEGV.

I knew that free(NULL) didn't need to do anything.
But mruby/c repeats malloc/free more frequently than other typical C programs.
So I intentionally ignored that specification because I thought it might affect speed.
But I check speed down using Hanoi Tower benchmark programs and the impact on the results was very small.
I think I can accept your request.


Request for v11

Do you think you will update this module to V11?
Thank you!

Hi hi, life has a habit of getting in the way. To my knowledge, there are no specific plans for discontinuation.
Currently, we are relying a bit on community contributions as both the owner (@Kekilla0 ) and the maintainer (myself) have very limited time on our hands for hobby development.
World Scripter is still loved and not forgotten, I can offer that 💖.  I am going to leave this issue open for others as well.

What needs to change for the module to properly work in V11?

Will this ever be updated, or is it dead?

I will get around to it soon. I didn't know if anyone still used it.

I'm trying to use it. Great module o/

Yes, there are still people who use this module, it is the only one that has this functionality.
Waiting for version 11 and 12
congratulations!

Would really love to see a V12 version one day!


[Event Request] Skip ReturnRcptLine.TestField("Job No.", SalesLine."Job No."); in the PostItemTrackingForReceipt procedure of codeunit "Sales-Post"

Describe the request
Hi there,
We need to skip this testfield in codeunit "Sales-Post":
procedure PostItemTrackingForReceipt(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; TrackingSpecificationExists: Boolean; var TempTrackingSpecification: Record "Tracking Specification" temporary)
    var
        [...]
    begin
        [...]
                    UpdateChargeItemReturnRcptLineGenProdPostingGroup(ReturnRcptLine);
                    ReturnRcptLine.TestField("Sell-to Customer No.", SalesLine."Sell-to Customer No.");
                    ReturnRcptLine.TestField(Type, SalesLine.Type);
                    ReturnRcptLine.TestField("No.", SalesLine."No.");
                    ReturnRcptLine.TestField("Gen. Bus. Posting Group", SalesLine."Gen. Bus. Posting Group");
                    ReturnRcptLine.TestField("Gen. Prod. Posting Group", SalesLine."Gen. Prod. Posting Group");
                    >>>>>>>>>>>>>>>>>>>
                    ReturnRcptLine.TestField("Job No.", SalesLine."Job No.");
                    <<<<<<<<<<<<<<<<<<<
                    ReturnRcptLine.TestField("Unit of Measure Code", SalesLine."Unit of Measure Code");
                    ReturnRcptLine.TestField("Variant Code", SalesLine."Variant Code");
        [...]
    end;

This is already done in codeunit "Purch.-Post" and we just need the same:
local procedure PostItemTrackingForReceipt(PurchHeader: Record "Purchase Header"; PurchLine: Record "Purchase Line"; TrackingSpecificationExists: Boolean; var TempTrackingSpecification: Record "Tracking Specification" temporary)
    var
        [...]
    begin
        [...]
                    UpdateRemainingQtyToBeInvoiced(RemQtyToInvoiceCurrLine, RemQtyToInvoiceCurrLineBase, PurchRcptLine);
                    UpdateChargeItemPurchaseRcptLineGenProdPostingGroup(PurchRcptLine);
                    >>>>>>>>>>>>>>>>>>>
                    CheckPurchRcptLine(PurchRcptLine, PurchLine);
                    <<<<<<<<<<<<<<<<<<<
        [...]
    end;

local procedure CheckPurchRcptLine(var PurchRcptLine: Record "Purch. Rcpt. Line"; PurchLine: Record "Purchase Line")
    var
        IsHandled: Boolean;
    begin
        >>>>>>>>>>>>>>>>>>>
        IsHandled := false;
        OnBeforeCheckPurchRcptLine(PurchRcptLine, PurchLine, IsHandled);
        if IsHandled then
            exit;
        <<<<<<<<<<<<<<<<<<<

        PurchRcptLine.TestField("Buy-from Vendor No.", PurchLine."Buy-from Vendor No.");
        PurchRcptLine.TestField(Type, PurchLine.Type);
        PurchRcptLine.TestField("No.", PurchLine."No.");
        PurchRcptLine.TestField("Gen. Bus. Posting Group", PurchLine."Gen. Bus. Posting Group");
        PurchRcptLine.TestField("Gen. Prod. Posting Group", PurchLine."Gen. Prod. Posting Group");
        PurchRcptLine.TestField("Job No.", PurchLine."Job No.");
        PurchRcptLine.TestField("Unit of Measure Code", PurchLine."Unit of Measure Code");
        PurchRcptLine.TestField("Variant Code", PurchLine."Variant Code");
        PurchRcptLine.TestField("Prod. Order No.", PurchLine."Prod. Order No.");
    end;

Additional context
Skip ReturnRcptLine.TestField("Job No.", SalesLine."Job No."); in the PostItemTrackingForReceipt procedure of codeunit "Sales-Post".

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14041.


Added recipe to replace Optional#isPresent to Optional#ifPresent

Closes #3043

Thanks a lot so far @srmalkan ! I've pushed a few small improvements (formatting & conventions) but also found two test cases that were not correctly handled yet. Would be great if you could look into those!
@yeikel originally opened #3043 , so perhaps he also has some insights to share here to influence the implementation.

Hi Tim,
Thanks for highlighting edge cases and adding new test cases, what are your thoughts on nested Optional#IsPresent, should we skip it or should we handle it ?

Hi Tim,
Yes we do have utility named VariableNameUtils, but I am facing problem to generate unique name since it asks for a cursor hence do not take into account the changes made by recipe while evaluating names.

I didn't review the code, but unless we check the accessed parameters and arguments for final or effectively final, we cannot safely apply this refactoring. Take this code for example:
                int x = 0;
                if (Optional.of("foo").isPresent()) {
                    System.out.println(x);
                }
                x = 1;

Converting to Optional#ifPresent() would yield a compiler error, unless we also introduce a new effectively final variable declaration in a preceding statement. This would be kind of ugly, so I think instead we need to have effectively final calculation in place, so that we don't produce uncompilable code.

Hi,
I have added a visitor to validate if the given block is lambda convertible or not. please have a look at it.
And also added a fix to handle nested optional#IfPresent but the unit test case is failing because, after each execution cycle, inner J.if becomes eligible for the transformation. I am not able to figure out what should I do in this case?

I have added a visitor to validate if the given block is lambda convertible or not. please have a look at it.
And also added a fix to handle nested optional#IfPresent but the unit test case is failing because, after each execution cycle, inner J.if becomes eligible for the transformation. I am not able to figure out what should I do in this case?

I think you should not use SearchResult#found() to markup the Optional#isPresent() call in the if-condition. This could end up leaking out of the recipe. E.g. for the following example the marker would remain after applying the recipe:
if (o.isPresent() && false) {
    list.add(o.get());
}

Instead you could here use cursor messaging, but in this case I would probably just inline the check of the if condition into visitIf() like so:
            if (!OPTIONAL_IS_PRESENT.matches(__if.getIfCondition().getTree())) {
                return super.visitIf(_if, context);
            }

If you now remove the isParentWithOptionalIsPresentMi() check, I think it should basically work. One problem is that the VariableNameUtils#generateVariableName() utility won't quite work here, as it won't be able to find the newly created optionals, as they haven't been added to the parent LST yet. I think this is a limitation we should address in VariableNameUtils. Until then you could for example maintain your own set of variable names you have already assigned.

Hi @knutwannheden,
Thanks for reviewing the code and suggesting improvements, the task looks challenging, will try to make it work.

@srmalkan Yes, it is rather challenging at the moment. We plan to add features which will make recipes like this one simpler, by allowing the recipe to query whether a variable is final or not.
FWIW, VariableNameUtils#generateVariableName() will now check the LST element represented by the cursor, so that a recipe like yours works properly. See this commit for details and an example: https://github.com/openrewrite/rewrite/commit/1afee4c5097c94bc4e8c62ba6cc14d76ce121458

Quick note that this is pull request a likely candidate to move to the new https://github.com/openrewrite/rewrite-static-analysis repository after the upcoming 8.0 release, and might best be recreated there, referring back here for some of the discussion items.

@srmalkan, thanks a lot for your contribution! I believe this recipe will be useful,   I made some upgrades based on this PR and moved this to the repo rewrite-static-analysis in this PR. All the comments are addressed there so we can close this here.


Feature request: standard library definitions for Go

There has been some excellent progress on handling Go binaries in the latest releases of Ghidra. However, as of now, Ghidra is left to deduce the types of function arguments. A good chunk of them come from the standard library and are therefore known ahead of time. A good chunk of internal functions are also directly exposed in decompiled code when exported functions are small one-two line wrappers for unexported functions.
I made a small plugin for Ghidra before these updates composed of these parts:

the actual plugin (written in Python) that somewhat fixes up the calling conventions of functions (unneeded now) based on function name and fills in the type parameters on functions (and creates type definitions as needed)
a Go binary that parses the Go source code and generates the above-mentioned json file with type info (e.g function signatures/struct definitions) from the official Go source code, for each of the Go "first-class" target architectures, with deduplication between them
helper scripts to run the binary on all tagged Go versions starting with 1.14 and dedupe output
There is also some deduplication between the json files corresponding to the different Go versions, and some logic in the plugin to reconstruct the data corresponding to some version foo from these deltas.

The work I did could be considered "proof-of-concept" level, though it does end up with a <1MB .zip file (<10MB unzipped) with the type definitions and function signatures for everything in the Go standard library from go1.14 up to go1.22.0.
If function/type definitions based on this work were to be introduced in Ghidra, in a similar way to generic_clib for C, then it would make unobfuscated Go binaries simpler to analyze with Ghidra.
An alternative implementation of this idea is fully welcome, though I think this general idea is workable and there is a proof of concept already.
Link to my PoC repository.
It also generates the .zip files with GitHub Actions, as can be seen here.

Interesting.
There has been some work toward a similar goal, which can be seen in https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Features/Base/data/typeinfo/golang/runtimesnapshot.go.
At first glance your code seems to generate signatures without all the manual work that runtimesnapshot.go takes.  That seems nice.  I will take a closer look during the week.


Changes made fail to save due to hit 500 Internal Error

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Changes made fail to save due to hit timeout.
To Reproduce
Steps to reproduce the behavior:

Make changes towards the worksheet
The 'Saving' label load for long time
Error displayed in red label saying that it hit timeout
After several saving attempt, error message is prompted

Expected behavior
No saving issue while editing document
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version [13.3.0]

Desktop (please complete the following information):

OS: [Window]
Browser [Chrome]
Version [Version 83.0.4103.106 (Official Build) (64-bit)]

Smartphone (please complete the following information):

Device: [N/A]
OS: [N/A]
Browser [N/A]
Version [N/A]

Additional context
N/A

This issue seems to resolve after I made my worksheet as a copy and make my changes on the copy.


Make the root test target use sub targets' nx cache

Currently, if we run
pnpm test-linter at the root of the workspace, then run pnpm test, the test target does not make use of the test-linter nx cache.
We could remove the test target in workspaces, and keep the test target in root, which would only call
 nx run-many --targets=test-linter,test-type,test-circular,test-unit --all

relevant nx example (last one)
What do you think ?

That is a good point. However, I often use the test target in workspaces, and I believe it can be useful.
We could instead use the Nx test-* targets to build the test target inside workspaces, and remove the test target from nx.json to prevent the cache to be stored twice.
WDYT?

We could instead use the Nx test-* targets to build the test target inside workspaces, and remove the test target from nx.json to prevent the cache to be stored twice.

@fargito I do not really understand the implications, how will this work? Could you write a quick example of what this will look like?

I would mean for example in the package.json in serverless-helpers, set "test": "nx run-many --targets=test-linter,test-type,test-circular,test-unit --project=serverless-helpers".
That way we can still use the test target in the packages with the same configuration.
WDYT?

Same as @fargito I use test target in the projects quite a lot
His solution requires that we specify in every package.json the name of the project associated with that package.json which is quite constraining
We could instead make use of nx run and define :
"test": "nx run test-linter && nx run test-type && nx run test-unit && nx run test-circular"

wdyt?

That would be even better @guillaumeduboc !


Improve errors for JSON parser

I just spent a while tracking down a bug, and it came from invalid JSON. Despite the server running in the debug environment, I was only getting the generic 500 error. I believe this is due to the recent switch to JSONSerialization instead of Jay (as JSONSerilization throws NSErrors).
I propose we either add support for NSError to ErrorMiddleware, or wrap any errors thrown by this framework in a custom JSONError that supports the Debuggable protocol.

Maybe we should do both for maximum usability?

@hhanesand can you paste the exact error you are getting (from debug mode so we get the identifier).

Closing due to inactivity. Please feel free to re-open.


remove code not intend to be merged.

Just realize my last pull request contains two lines not intent to be merged.

Thanks, I didn't notice those.


Incorporate auth param for oci-copy task

The use case for this is copying artifacts into the OCI registry from locations that require some authentication, in particular https://huggingface.co/mistralai/Mixtral-8x7B-Instruct-v0.1

@chmeliik thank you for the thoughtful reviews.

@ralphbean The push plr https://github.com/konflux-ci/build-definitions/runs/27067818667 fails for this latest merged PR https://github.com/konflux-ci/build-definitions/commit/main

Thanks @hongweiliu17! I just saw it too and made my way back here and found your comment. I'm attempting /retest of 12f31d38fcc241598c7abc3e054e0425ee61c0ac (latest on main) to analyze.

Well, that seemed to work: https://github.com/konflux-ci/build-definitions/runs/27098685636


Time-out on Google Doc for SHARE Project

Specific to this project at the moment: https://osf.io/68ymx/
Steps
Under Google Drive, in the meeting notes folder, click to open this file "2015-03-09 Joint WG Meeting Notes.gdoc"
Expected
File will render and be readable
Actual
Error occurs: "Timeout occurred while loading, please refresh the page"
The original file set to “anyone with the link can view" is here:
https://docs.google.com/document/d/1oWFr_OyoCjERqFSLdl_9Fp_TM8lYpLBb28CMK3ODUa0/edit?usp=sharing

@sloria or @kushG ? Thanks -

Looking into it now.
@lbanner Are you able to render other gdoc files?

@lbanner seems to be working correctly on my system.

Interesting ... @erinspace did replicate the SHARE issue, and I am having the same 'time-out' error with this project just setup: https://osf.io/n68yt/files/
@nicipfeiffer -- when you get a chance can you check + replicate?

I am experiencing the same thing that @lbanner is.  I tried another Google Doc and also received a time out.
Google Sheet is rendering fine, as @kushG pointed out.

@lbanner and @sloria I replicated the issue.  Even creating a new gdoc, giving permission, then upload to a project on osf persists with render time out.

Replicated this locally and got a traceback:
Traceback (most recent call last):
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/sloria/projects/cos-projects/osf/framework/routing/__init__.py", line 96, in wrapped
    data = fn(*args, **kwargs)
  File "/Users/sloria/projects/cos-projects/osf/website/views.py", line 397, in resolve_guid
    return proxy_url(url)
  File "/Users/sloria/projects/cos-projects/osf/framework/routing/__init__.py", line 231, in proxy_url
    response = app.view_functions[match[0]](**match[1])
  File "/Users/sloria/projects/cos-projects/osf/framework/routing/__init__.py", line 96, in wrapped
    data = fn(*args, **kwargs)
  File "/Users/sloria/projects/cos-projects/osf/website/project/decorators.py", line 52, in wrapped
    return func(*args, **kwargs)
  File "/Users/sloria/projects/cos-projects/osf/website/project/decorators.py", line 132, in wrapped
    return response or func(*args, **kwargs)
  File "/Users/sloria/projects/cos-projects/osf/website/addons/base/views.py", line 308, in addon_view_or_download_file
    return addon_view_file(auth, node, node_addon, file_guid, extras)
  File "/Users/sloria/projects/cos-projects/osf/website/addons/base/views.py", line 326, in addon_view_file
    'rendered': get_or_start_render(file_guid),
  File "/Users/sloria/projects/cos-projects/osf/website/addons/base/views.py", line 233, in get_or_start_render
    file_guid.public_download_url
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/celery/local.py", line 167, in <lambda>
    __call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/celery/app/task.py", line 420, in __call__
    return self.run(*args, **kwargs)
  File "/Users/sloria/projects/cos-projects/osf/framework/render/tasks.py", line 75, in _build_rendered_html
    render_result = mfr.render(temp_file, src=public_download_url)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/mfr/core.py", line 124, in render
    return handler.render(fp, renderer=renderer, *args, **kwargs)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/mfr/core.py", line 231, in render
    return render_func(fp, *args, **kwargs)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/mfr/ext/docx/render.py", line 16, in render_docx
    content = Docx2Html(fp).parsed_without_head
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/pydocx/parsers/Docx2Html.py", line 36, in parsed_without_head
    content = super(Docx2Html, self).parsed
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/pydocx/DocxParser.py", line 778, in parsed
    self._load()
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/pydocx/DocxParser.py", line 219, in _load
    self.page_width = self._get_page_width(main_document_part.root_element)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/pydocx/DocxParser.py", line 249, in _get_page_width
    pgSz = int(pgSzEl.attrib['w'])

This seems to have been fixed recently by https://github.com/CenterForOpenScience/pydocx/pull/113 .
We are currently pinning MFR's DocX renderer to @mfraezz 's fork of pydocx (which does not have that fix).
@mfraezz Are there any barriers to using the latest version of pydocx (esp. since https://github.com/CenterForOpenScience/pydocx/pull/95 has been addressed)?

Ok, looks like the only barrier is removing the inline styling (see https://github.com/CenterForOpenScience/pydocx/issues/102), but we can get away with the workaround described in that issue.
I've updated mfr to use the latest version of pydocx. Will send a hotfix with the version update shortly.

Nice work!

Should be fixed now.

Looks good! TY


Update app-governance-get-started.md

#sign-off

Docs Build status updates of commit 1ccf5dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

CloudAppSecurityDocs/app-governance-get-started.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@dcurwin

Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


font-awesome-sass / Font Awesome 5 support

Updated font-awesome-sass to latest which is font awesome 5.  Changed fa class to fas.

I would love to see this pulled in, as my project uses FA5 and will need to use a different wysiwyg editor if it's not. I've not complaints about wysiwyg-rails so far other than the above.

@jason-hobbs could you please limit your PR to the wysiwyg-rails.gemspec changes?

I reverted it back to the .gemspec only.

Does this PR got released it yet? Look like it haven't.


Anonymous object - multiple levels deep?

Hello,
I'm trying to render a template with an anonymous object that is multiple levels deep.
For some reason, I'm getting errors that property X on Y does not exist.
What is the appropriate way of rendering a template with a dynamic/anonymous object that has multiple levels?
This is how I'm trying this:
public void MyFunction(object dataObject)
{
  var output = tpl.Render(new { dataObject });
}

dataObject is populated by asp.net core. I have a controller that is like:
public async Task<IActionResult> TestTemplate(string templateuuid, [FromBody] object requestBody)
        {
            GetTemplateOutputForDataObjectCommand cmd = new GetTemplateOutputForDataObjectCommand(templateuuid, requestBody);

            string result = await _mediator.Send(cmd);

            return Response(result, true);
        }
}

Thanks!

it's difficult to say from your sample, but keep in mind that properies are being renamed by default (e.g "SomeProperty" becomes "some_property") See MemberRenamer doc for more details


[no ticket] chore: move <Link> to osf-components

Purpose
We use a variety of link components (link-to, global-link-to, hyper-link, link...). It would be good to choose one that meets our needs and use it consistently. I think <Link> is our best bet.

Summary of Changes
Move <Link> from registries into osf-components. Add a handbook page.
If others agree, we should use <Link> for new links and eventually remove the other link components. Maybe even add a lint rule to warn against using link-to.

Side Effects
n/a

Feature Flags
n/a

QA Notes
n/a

Ticket

n/a
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 2090

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.27%

Totals

Change from base Build 2082:
0.0%

Covered Lines:
4779

Relevant Lines:
6268

💛  - Coveralls

You new interface is pretty cool at finding when people don't use the component correctly. Speaking of: you have a failing test.


Fix file list in FileDialog not updating on first run

Fix another issue in #33533.
Fix Ctrl+H not working when using show instead of popup*.

EditorFileDialog has the same code, probably needs the same change?

I'm also not sure if EditorFileDialog will be displayed via show instead of popup*. Just in case, the same modification was made to the EditorFileDialog.
For EditorFileDialog, Ctrl+H also seems to be bound to the action of timed hiding the dialog.

Fix Ctrl+H not working when using show instead of popup*.

Popups and Dialogs should not be made visible via show, when does that happen? If this is something the user does, it's an error in user code.

Ok, now only part of the code for previewing in the editor is kept.

Otherwise seems fine.

Thanks!


sceneNN

Thank you for your contribution!I have a question.
If I use a dataset like sence NN, Do I need to turn room into block in prepareh5. py？

Have you solved this problem now

Thank you for your contribution!I have a question.
If I use a dataset like sence NN, Do I need to turn room into block in prepareh5. py？

Yes. You can download the ply files from SceneNN, extract the point clouds and run through preprocessing.


Implement Speech Synthesis with Azure AI Speech Service 💬🗣

What is Needed
Contributors are needed to implement a speech synthesis (text-to-speech) function using Azure AI Speech Service. Work to fine-tune the existing speech_io.py script. Also check out the resources at the end of the Contribution Guidelines to learn how to use the speech synthesis API.
How to Contribute

Get familiar with the scripts and documentations already provided in the repository.
Test your code: It is pertinent that you check your code runs smoothly before making a pull request.
Create a Pull Request: Submit a pull request to the repository with your code in the appropriate script and include any necessary documentation.

Getting Started
Before you begin, ensure you have read the Contribution Guidelines in the repository
We are excited to see your contributions! Happy Hacking! 🎉

Can I get assigned to this? I'll integrate it into the streamlit script

Can I get assigned to this? I'll integrate it into the streamlit script

Thank you @KeneNwogu. You can go ahead to work on this issue. The speech synthesis has already been implemented in the speech_io.py script. So all that's needed is the integration to the chat interface of Streamlit which you can work on. Please when making your PR on this, include a video snippet/screenshot of your tests and how it looks in the Streamlit UI. Thank you very much.

Thank you very much. I'm on it


increment version to 1.0.0-preview.2

Closing in favor of https://github.com/Azure/azure-sdk-for-c/pull/770


Triton Thread Pool

Within PyTorch torchinductor we are JIT compiling many triton functions, often 100+. We currently have a mechanism that will initialize a pool of forked processes in order to parallelize triton compilation.
However, this comes with downsides. Each fork in python duplicates all of its parent process' memory, including things like locks. Depending on the parent process, it can be unsafe to fork. We have had difficulty enabling the parallel compilation in long-running production environments.
It would be great to switch to a lighter weight mechanism. I'm proposing to add an api to triton to initialize a C++ thread pool. When we call into C++ for a compilation step we would use the thread pool and release the gil.
If this is acceptable I/PyTorch team can submit the PR.

The most efficient may be for having a shared MLIRContext (the types and attributes would be shared) and use the existing thread pool facilities there. Happy to help if you'd like.

yea, help would be great ! waiting for confirmation from triton folks that they'd accept this PR first, I think.

This was still causing problems for us, so we ended up adding a workaround to make sure that Triton compilation doesn't run  when parallel dataloaders are active, etc. It'd be nice to get this bug fixed. Heard anything back from the Triton folks? Who did you reach out to?


Hash-Pinning Dependencies

Regarding #8438

Yes it is ready, I was waiting for some actions to run before changing it to ready.
I decided to break it into more PRs, because I'm still trying to understand the best approach to deal with the Dockerfiles and the python dependencies mentioned in the actions/dockerfiles, I'm concerned that they would be relevant to tests and pinning it would affect the tests.
So at first we should only pin these safe ones and later when I got more details on what can or cannot be pinned I can open another issue to continue.
Thank you for the concerns in the issue discussion, all of them were pretty relevant.


argcomplete.egg-info/requires.txt |  make issue with customized python

Hi Team,
We been using python module argcomplete - 1.12.3 that required for module"yq".
The problem is we been using customized python [ that is for our environment pupose]
Ex;
python -- would point python 2.x
python3 -- would point to python 3.x
the problem is when we try to build and use  the module argcomplete with python3 [python 3.8.1]  we facing below issue

[root@linsee-automation-abinaya argcomplete-1.12.3-py3.7.egg-info]$ yq
Traceback (most recent call last):
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 583, in _build_master
ws.require(requires)
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 900, in require
needed = self.resolve(parse_requirements(requirements))
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 791, in resolve
raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (importlib-metadata 0.0.0 (/opt/python3-importlib-metadata/noarch/4.5.0.p375-1/lib/python3.7/site-packages), Requirement.parse('importlib-metadata<5,>=0.23'), {'argcomplete'})
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/python3-yq/noarch/2.12.0.p375-1/bin/yq", line 6, in
from pkg_resources import load_entry_point
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 3250, in
@_call_aside
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 3234, in _call_aside
f(*args, **kwargs)
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 3263, in _initialize_master_working_set
working_set = WorkingSet._build_master()
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 585, in _build_master
return cls._build_from_requirements(requires)
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 598, in _build_from_requirements
dists = ws.resolve(reqs, Environment())
File "/opt/python3/x86_64/3.7.5/lib/python3.7/site-packages/pkg_resources/init.py", line 786, in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'importlib-metadata<5,>=0.23' distribution was not found and is required by argcomplete

importlib_metadata already installed in our environment that pointed with PYTHONPATH env variable
on further investigation we understand that this is because of argcomplete/requires.txt is in below python specific format
[root@linsee-automation-abinaya argcomplete-1.12.3-py3.7.egg-info]$ cat requires.txt
[:python_version == "2.7"]
importlib-metadata<5,>=0.23
[:python_version == "3.5"]
importlib-metadata<5,>=0.23
[:python_version == "3.6"]
importlib-metadata<5,>=0.23
[:python_version == "3.7"]
importlib-metadata<5,>=0.23
Since our version of python is mentioned as python3.
when we manually changed to requires.txt to be [:python3_version == 3.7] and no issue.
So please let us know why there is version specific information for argcomplete, how can we avoid this further.
also we been using 500+ python modules in this same way and no issue so far.
issue only observed on argcomplete only.
would be great if anyone help/suggest here.
Thank you!!!

Hi, this issue tracker is for issues with the codebase behind pypi.org itself, not the projects hosted on PyPI.
You should report this issue to the tracker for the project in question instead.

Hi,
Sorry for this and thanks!


client - update queryspec calculations

Adds missing RATE_AVG, RATE_MAX, and RATE_SUM
Resolves #87

Codecov Report

Merging #92 (4aa553b) into main (1cfe539) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   84.10%   84.13%   +0.02%
==========================================
  Files          25       25
  Lines        1642     1645       +3
==========================================
+ Hits         1381     1384       +3
  Misses        206      206
  Partials       55       55

Impacted Files
Coverage Δ

client/query_spec.go
91.11% <100.00%> (+0.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfe539...4aa553b. Read the comment docs.


feat/numpy_2

Is your feature request related to a problem? Please describe.
Add support for Numpy 2.0
Describe the solution you'd like
Update to onnxruntime 1.19 then change requirements/base.into support Numpy 2, and change any code as necessary to fix changes in types and sorting algorithms (add stable=True if required)
Describe alternatives you've considered
N/A
Additional context
The lack of support in onnxruntime mentioned in the requirements file comment has been resolved:
requirements comment: https://github.com/Unstructured-IO/unstructured/blob/main/requirements/base.in#L14
onnx change: https://github.com/microsoft/onnxruntime/issues/21063
onnxruntime added support for Numpy 2.0 in 1.19

to fix your trouble check this solution click
maybe this will solve your problem.

I would submit a PR, but I can't make the dependencies.
$ cd requirements
$ make
# ...
pip._internal.exceptions.DistributionNotFound: No matching distribution found for paddlepaddle==3.0.0b1
make: *** [compile-all-base] Error 1

+1


Non standard ASCII formating does not compute

If you have "fancy" servernames or channel names Voltair cant find the channel or even the server. As an example if a channel is named ỼօӀէąìɾ it wont work even if you copypaste it into DM. Not really an issiue but worth noted were many servers use this kinds of names for channels, same goes for any non standard ascii text and emojis. "bugtested" this by trying diffrent combinations and its reacting even if its just one symbol.

Thanks for the report! Its surprising that the command string would be coming in with different encoding than the api returns for channel/server names, but it is possible. There must be something weird going on. Hopefully this is easy to normalize.

@zedansk - I'm having trouble recreating. With a server and channel name of "ỼօӀէąìɾe", the following works:

Could there be any other special conditions that are causing this to fail?

write to me on Discord boof#1312 I have tried multible configs without success. also the way the output from the bot in konsole speaks the same language

unable to recreate, closing for now


Fix examples test for v1.31

This PR updates the test case for manifest examples. The test case is there to ensure all example manifests can pass the API validation for v1.31.

/lgtm

/approve


Refactor command parser

Remove types redundancy, and make protocol-parser.ts responsible only for parsing.

Tests are failing

Tests are failing

fixed

Much better!


Support for new Govee TV Backlight 3 Lite

Govee Device SKU
H6097
Govee2MQTT Version
2024.07.13-82ddc6e9
Describe the issue
The device appears in the UI but is unable to control it
Startup Diagnostics
[2024-08-04T13:57:16 INFO  govee::commands::serve] Starting service. version 2024.07.13-82ddc6e9
[2024-08-04T13:57:16 INFO  govee::commands::serve] Querying platform API for device list
[2024-08-04T13:57:16 INFO  govee::commands::serve] Querying undocumented API for device + room list
[2024-08-04T13:57:18 INFO  govee::service::iot] Connected to IoT: CONNACK code 0: Connection Accepted.
[2024-08-04T13:57:18 INFO  govee::commands::serve] Starting LAN discovery
[2024-08-04T13:57:18 INFO  govee::service::iot] IoT (re)connected with status CONNACK code 0: Connection Accepted.
[2024-08-04T13:57:18 INFO  govee::commands::serve] Waiting 10 seconds for LAN API discovery
[2024-08-04T13:57:28 INFO  govee::commands::serve] Devices returned from Govee's APIs
[2024-08-04T13:57:28 INFO  govee::commands::serve] H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:57:28 INFO  govee::commands::serve]   Undoc: room=None supports_iot=true ble_only=false
[2024-08-04T13:57:28 WARN  govee::commands::serve]   Unknown device type. Cannot map to Home Assistant.
[2024-08-04T13:57:28 INFO  govee::commands::serve]
[2024-08-04T13:57:29 INFO  govee::service::http] http server addr is <IP_ADDRESS>:8056
[2024-08-04T13:57:48 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) None
[2024-08-04T13:57:50 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:57:50 INFO  govee::service::hass] Wait 60ms for hass to settle on 6 entity configs
[2024-08-04T13:57:51 INFO  govee::service::hass] MQTT connected with status=CONNACK code 0: Connection Accepted.
[2024-08-04T13:57:55 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:57:55 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) None
[2024-08-04T13:58:19 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:58:24 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:58:24 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: false, light_on: Some(false), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:58:12.658702012Z })
[2024-08-04T13:58:24 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:58:29 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:58:29 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: false, light_on: Some(false), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:58:12.658702012Z })
[2024-08-04T13:58:58 ERROR govee::service::http] err: Unable to control color for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:59:03 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:59:03 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: false, light_on: Some(false), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:58:12.658702012Z })
[2024-08-04T13:59:27 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:59:32 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:59:32 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: true, light_on: Some(true), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:59:03.721135685Z })
[2024-08-04T13:59:35 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:59:40 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:59:40 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: true, light_on: Some(true), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:59:03.721135685Z })
[2024-08-04T13:59:41 ERROR govee::service::http] err: Unable to control power state for H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097)
[2024-08-04T13:59:46 INFO  govee::service::state] Polling H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) to get latest state after control
[2024-08-04T13:59:46 INFO  govee::service::state] requesting update via Platform API H6097_1A19 (0E:02:CD:2A:02:86:1A:19 H6097) Some(DeviceState { on: true, light_on: Some(true), online: None, kelvin: 0, color: DeviceColor { r: 255, g: 127, b: 0 }, brightness: 50, scene: None, source: "AWS IoT API", updated: 2024-08-04T11:59:38.950558498Z })
Additional Logs
No response
Home Assistant Logs
No response
Anything else?

I will be interested too

I'd love to see support for this!

Also waiting for support :)

I am also interested

Oh yes <3

For me, it is working now, I guess it was an issue on Govee's side, it took them some time to add the device in the API.


Add http-proxy.yml

in order to install concourse behind HTTP proxy ...

Makes sense. One question though: is setting the properties on Garden necessary? They should only be needed for rootfs_uri: in a task, which has been deprecated/discouraged for years.
If we don't have to set those, configuring this will be a bit easier, since then you only need one form of no_proxy.

Thank you for your comment!
I was thinking that the properties on Garden is necessary.
After checking it works without these for sure, I'll update this PR.

Confirmed garden was not required and updated PR

Thanks!


[BUG] Buildings not collecting, energy not filling up since server change

Since the server change the energy isnt re-filling and the buildings are not paying out.

I can't reproduce the energy not re-filling. When I go resting, it fills up normally. The buildings were caused by badly set-up CRON, it should be fixed now.


Flaky test: test.ajax.js-http #5061 ajax returns ETIMEDOUT error on timeout:

seen it on travis and locally, tested with Node v6 and v7
  1) test.ajax.js-http #5061 ajax returns ETIMEDOUT error on timeout:

     Uncaught AssertionError: expected 'ESOCKETTIMEDOUT' to match /(ETIMEDOUT|ENETUNREACH|EAGAIN|ECONNREFUSED)/
      at tests/integration/test.ajax.js:19:25
      at Request._callback (node_modules/pouchdb-ajax/lib/index.js:79:14)
      at self.callback (node_modules/request/request.js:187:22)
      at ClientRequest.<anonymous> (node_modules/request/request.js:779:16)
      at Socket.socket.once (_http_client.js:566:38)
      at Socket._onTimeout (net.js:339:8)

We have updated the tests in PouchDB's codebase to include ESOCKETTIMEDOUT. Unfortunately this is one of the problems with copy-pasta'ing the tests.


Update pipeline alerts to include more error info

Is your feature request related to a problem? Please describe.
I would like to see more information in slack when the pipeline fails. I can of course click the link and check what went wrong, but it would be nice with a small summary directly in slack. Especially so you can quickly see if some new feature broke the pipeline or if it was one of our regular "random" errors that sometimes occurs (which we can't really control).
Describe the solution you'd like
When a pipeline fails I would like to see which job failed, which step in that job failed, and around the last 10 log lines from the failed step. That is hopefully enough to identify the general error, but feel free to alter this.
There is sometimes several steps that fails because the error cascades. So it is probably enough to just show the first failed step in a job, but that can be discussed.
Describe alternatives you've considered
Skip this and continue to always check the error in github.
Additional context
Definition of done:
The alerts contain more information when there is an error.

This task may be best suited for someone that is in control of the pipeline end-to-end.

@crssnd are you still working on this?

@viktor-f yes, I need to fix a regex in my code and test it. I hope I will create a PR for this tomorrow.


Adding Play Options operationalContext

Adding PlayOptions including loop and the new operationContext fields.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Please be aware of the conflict. I have changed the swagger/README.md last night to remove event models in the implementation/models folder.


MillBuildRootModule: Disable the default-use of <projectDir>/src

This breaks the single-source-of-thruth concept of Mill.
Instead, we should support importing a directory with either import $file or by inventing some new $-import type.

$import file doesn't seem correct since it is currently used for .sc files while the src directory contains vanilla .scala files.

In general, I don't see the big difference, both are source files. But in Mill context, we treat .sc files special, e.g. we wrap them and also infer the .sc from the import statement, so I agree. We could use $source. It has the exact same semantics as def sources (but for single path) and is also being watched like T.source/T.sources.

Looks like I misunderstood something when opening this issue. I think it's invalid.
I thought, when compiling the build.sc, we also use source files from <projectDir>/src, but this is not the case. Instead, we use <projectDir>/mill-build/src, which is indeed another topic (#2461).
@lihaoyi About your last comment. I think it is more suited to issue #2461. We should discuss it there.


Create Ehcache Kit

Building on the Voltron skeleton kit, we will need to create an Ehcache specific kit that bundles the Voltron kit with the Ehcache specific code that needs to reside on the server, along with the client side Ehcache libraries.

Waiting on Jeff to complete the integration/kit testing framework so that we can add some automated kit testing before this issue is closed.


Make trivy external

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The plugin code for scanning is located here.

https://www.howtogeek.com/devops/how-to-use-trivy-to-find-vulnerabilities-in-docker-containers/
Pls look for this section ...
Server Mode

Trivy can run in client-server mode. This moves the vulnerability database to the server, so clients don’t need to maintain their own versions.

Here is another service that can run remotely.
https://docs.clamav.net/manual/Usage/Services.html

I have been inspired by this proposal from goharbor which is exhaustive. There are also some very good ideas here about plugin discovery. My current zot-scan proposal is very similar to the official Trivy scanner plugin for goharbor which is short it uses the Zot API to scan remotely the images. I don't think the client-server model from Trivy is all that relevant in our case since half of the scanning process is done by the client and this is not possible in our general, plugin oriented design.


Documentation: When the table var step ends early for important reasons

[x] The continue button is pressed, but the user can't continue - they get a validation message or a system error.
[ ] [This might be handled by the page taking too long to continue. Not sure.] The code tries to hit the continue button, but it doesn't exist.
[ ] The code tries to set a variable [for which an element exists on the page], but its element can't be interacted with (it's hidden or something).
[x] Something hangs (the page takes too long to load or something).

Maybe this documentation should be added to the code.

Regarding the third item on the list about not finding the right element to set on the page for a Step:
Actually, this is a good point - right now everything is set with the story table loop, so if a variable can't be found on the page, it isn't noted. On the other hand, the reports do say what variables were set. This is a huge question. Should we halt Step tests there? Should we store what variables were not set? Maybe this needs its own issue.

I'm not sure we created an issue for that last comment - when a variable is found on the page, but can never be set, we should error (I think that was the behavior we agreed on in #351, but I'm not sure).


Bump onflow/cadence-tools/test to v0.10.0

Description
Bumps the cadence-tools/test dependency to latest version.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

@m-Peter https://github.com/onflow/cadence-tools/releases/tag/languageserver%2Fv0.31.0

Updated the languageserver dependency as well.


HacktoberFest: Prepare to participate to get new contributors

Identify issues suitable for Hacktoberfest (new comers)
Tag those issues
Create a Landing Page

@sbtaylor15  I can probably work on this issue with your guidance.

Hacktoberfest is now over


enhancement: add support for Arguflow

This is the Arguflow team’s submission to the “best contribution to vectara-ingest” part of the hackathon. We really admire the work that has gone into this repository, and want to start a trend of making it compatible with more varied services.
This PR adds support for Arguflow to the crawler such that users are able to add documents/chunks to Arguflow, Vectara, or both.
Internally, we were motivated to add this support so that we can stand up more Arguflow demos by using the crawlers, however, we are PR’ing it because we think it can also offer Vectara users value.
Arguflow has support for a few things that Vectara does not which users may desire:

self-host option for E2E data ownership
support for arbitrary LLM’s and text-embedding models
RAG options beyond summarization (both fully managed and search-before-generate)
enhanced duplicate detection beyond UPSERT

Arguflow also ships with a default search and chat UI in addition to its OpenAPI spec which makes it a bit easier to get going with a deployment you can share and reverse-engineer to build your own applications.
This repository is great, and we really admire @ofermend’s work on it especially. Excited to enhance it and bring it more into the lens of the open source AI world! We also edited the documentation in all the right places, let us know if may have missed a few spots.
Happy to address any review comments or change requests in a timely manner.

Hi there!  Thank you for offering the contribution.  However, the vectara-ingest project is not intended to be a general-purpose ETL tool for arbitrary destinations.  There are a variety of generic ETL tools on the market, and the reason vectara-ingest is separate is in the name: to optimize data loading into Vectara.  A couple thoughts:

If you want to submit a PR to a generic ETL tool to load data into your product, you could do so.
To maintain the spirit of this repository, we would consider a PR that exports data from Arguflow and ingests it into Vectara if such an API exists on the Arguflow side.

Closing this PR as won't merge


Fix UIDragger's onDrop event

Fixes #63
@williamngan, I had a closer look and you did re-implement drag/drop in the UIDragger for a reason. Space's drag/drop doesn't work as soon as the mouse becomes faster that the UI repositioning since the space's event happen out of the UI element.
For drag, you correctly separated drag and uidrag, I've made changes so the same applies to drop and the newly added uidrop. This fixes 2 things: the double drop event issue that I reported in #63, as well as the missed drop event if you're dropping while moving your mouse fast and the drop happens while the mouse is out of the UI element.
Hope this is good to go, let me know if it needs changes.
PS: I've added a code comment so we can remember why this exists next time ;).

This is awesome! Thank you so much @tibotiber 🙏


stop clone-ing serializers

Change Summary
In general, cloning serializers is a potentially expensive runtime operation; we should instead store Arc<CombinedSerializer> and cheaply clone that where needed.
Related issue number
N/A
Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

While the offer is welcome, actually I did a similar change already for validators in https://github.com/pydantic/pydantic-core/pull/992/commits/5f149731ea7c057f98be853836edba891687cba1
Though in the same line, what we should try to work towards is resolving this TODO: https://github.com/pydantic/pydantic-core/blob/7368c1f760748349c6eb8a02438e1c4b9aa95314/Cargo.toml#L30-L32
Last I checked the hard bit is that we clone error values; we might be able to restructure errors to remove the need.


Import error

try to user...and...
Unsupported import(s): (package:open_file/open_file.dart, package:path_provider/path_provider.dart, dart:io, package:dio/dio.dart)

Hi @deppimaracanau, thanks for opening an issue.
Since DartPad runs on the web platform, dart:io and packages, such as package:path_provider, which depend on it are not supported. DartPad also has a specific set of packages that are supported, which doesn't currently include the packages you are trying to use. To see a list of supported packages, you can click the "i" (information) icon in the bottom right corner of DartPad.
If you'd like to see other packages supported, you can open a new issue with why you'd like to see a specific package supported.
Thanks again and let us know if you need any further help!

Hi @deppimaracanau, thanks for opening an issue.
Since DartPad runs on the web platform, dart:io and packages, such as package:path_provider, which depend on it are not supported. DartPad also has a specific set of packages that are supported, which doesn't currently include the packages you are trying to use. To see a list of supported packages, you can click the "i" (information) icon in the bottom right corner of DartPad.
If you'd like to see other packages supported, you can open a new issue with why you'd like to see a specific package supported.
Thanks again and let us know if you need any further help!

DartPad is useless if it can't import packages people want to try on it.


CGAL Library update

Please update the CGAL library to version 4.14.
cgal  4.13-2           The Computational Geometry Algorithms Library (CGAL) is a C++ library that aim
https://www.cgal.org
Many thanks in advance.

PR #5734

The command "vcpkg upgrade cgal" doesn't update CGAL to 4.14. How can I update CGAL?

I think you need to call vcpkg update before vcpkg upgrade. And as far as I know, vcpkg upgrade does not talk the package name as option. I think you can upgrade one package by using: vcpkg install cgal (and it will install the update if needed).

Thanks for your help. VCPKG installs the version 4.13-2.
vcpkg remove cgal
vcpkg install cgal           (x64-windows)

Unfortunately, an update to 4.14 doesn't work.

Does not work, how so?

I get this output.

Should not you call 'git pull' to get the refreshed version of the vcpkg repository?

It works now. git pull helped. Thx again.


Add coverage step to the GitHub action CI workflow

For #9842

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #10076 into master will decrease coverage by 61.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #10076       +/-   ##
===========================================
- Coverage   61.23%       0%   -61.24%
===========================================
  Files         564       10      -554
  Lines       30196       31    -30165
  Branches     4569        4     -4565
===========================================
- Hits        18490        0    -18490
+ Misses      10673       31    -10642
+ Partials     1033        0     -1033

Impacted Files
Coverage Δ

src/client/debugger/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/common/platform/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/interpreter/locators/services/conda.ts
0% <0%> (-100%)
:arrow_down:

src/client/common/process/constants.ts
0% <0%> (-100%)
:arrow_down:

src/client/constants.ts
0% <0%> (-80%)
:arrow_down:

...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts
0% <0%> (-60%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
0% <0%> (-50%)
:arrow_down:

src/client/language/textRangeCollection.ts

.../application/diagnostics/commands/launchBrowser.ts

...c/client/interpreter/autoSelection/rules/system.ts

... and 551 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6865176...cc03102. Read the comment docs.


Update to rustc 2015-01-04

To enable build with recent rustc, changes within rust had to be followed, and also rustc-serialize needed to be bumped from 0.1.x to 0.2.x, which implied further modifications.
Build succeeds and all tests pass on x86_64-unknown-linux-gnu and on aarch64-unknown-linux-gnu.

Unfortunately a dupe of https://github.com/rust-lang/cargo/pull/1123, but thanks!

Just for the sake of argument: mine has no conflicts ;)
(Decision accepted, no offense meant, ofc.)


Add 'Sidebar settings' and 'Secondary links' sections

Trello cards: https://trello.com/c/h6Oj4hno/46-move-sidebar-settings-and-secondary-links-inside-the-summary-component
Dependent on https://github.com/alphagov/collections-publisher/pull/703
What

Uses summary_list component to render new sections on the 'step by step' admin page:

'Sidebar settings' (and Edit/View link)
'Secondary links' (and Edit/View link), with guidance content taken from the secondary links page

Adds tests to verify that the correct content is appearing on this page.

Here are the additional sections added to the bottom of the page:

@leenagupte thanks for the approval. I've added a feature to conditionally display 'Edit' or 'View' depending on the editable status of the step by step. Could you re-review please?
As before, this is branched off update-govuk_publishing_components as it needs the latest gem, but I intend for it to be approved & merged separately (I'll change the base branch of the PR to master once the parent branch has been merged).

I've reworded the first commit 👍

Have reworded it again 👍