use node-pre-gyp to pre-build apm-bindings

notable items

appoptics-bindings => @appoptics/apm-bindings
extend some test timeouts/ranges for slow gh-actions
use package-lock.json again
restructure github actions for multiple actions

the action chooses the script to run

details
This will be published to the @appoptics namespace under the name apm-bindings as it is a major change. It will maintain the version sequencing of appoptics-bindings, the non-namespaced predecessor. Because this is a new name and a scoped namespace, a new version of the agent will be required in order to use it. That release can be either namespaced or not (or there can be both a namespaced and non-namespaced version that use this release).
The biggest change is that this will use node-pre-gyp. Most of the changes in this PR are to modify the github actions. github actions were previously used only for testing; now there is a publish action as well. It must be manually triggered. One item that must be resolved before merging this PR is to decide the name of the bucket that node-pre-gyp will target for the production binaries as well as appropriate properties for that bucket (versioning, object-lock, etc.). The bucket must be public or it is not possible for node-pre-gyp to read from it. node-pre-gyp adds '--acl public-read' to the s3 put-object api call.
At this moment the node-pre-gyp dependency is tied to a specific github commit as features required by our release are not in the existing node-pre-gyp codebase.
Testing the publishing is done by manually executing the publish using node-pre-gyp for pre-built glibc and musl versions workflow. you must enter two inputs: the branch/tag and whether to publish to production or not. at the time of this comment production is just another bucket with no special characteristics.
manual tests that have been performed:

no public access for bucket (publishing fails)
public access empty bucket (publishing succeeds)
public access but version already published (publishing fails)

open items

decide the name of the bucket that will be used for the production binaries as well as appropriate properties for that bucket (versioning, object-lock, etc.)
running the publish script with the staging target does not automatically delete an existing target with the same spec. if the same version has been published the publish script will fail; in order to verify that publishing is working correctly use the s3 console or s3 cli to delete the conflicting targets.
see if node-pre-gyp can be released (or just keep commit hash and github install)

this visual overview of how the github actions work might be helpful

this visual overview of how the github actions work might be helpful

i've added some minor cleanup - extended the test timeouts when running in a CI environment and moving my global eslintrc file into the repo.

i've added some minor cleanup - extended the test timeouts when running in a CI environment and moving my global eslintrc file into the repo.

if you want to pull from docker hub you can. the negative for that is that the dockerfiles for those images are disconnected from the process. right now pretty much everything you need to know about testing/publishing is here.
it's possible to keep the dockerfiles here and create a script to update them when changes are needed but is just another step that needs to be coordinated. my two bits.

if you want to pull from docker hub you can. the negative for that is that the dockerfiles for those images are disconnected from the process. right now pretty much everything you need to know about testing/publishing is here.
it's possible to keep the dockerfiles here and create a script to update them when changes are needed but is just another step that needs to be coordinated. my two bits.


Exception: Full Account Request failed with status code 503: {"message":"Service Unavailable"}

It seems as though when there is an existing pkl that shouldn't be expired is loaded (this can occur from logging into the account from mobile and getting a new email code) then it moves forward without checking authentication somehow. I have not debugged this, and it could be a local modification I have made that is leading to this, so sorry for the poor issue, I just wanted to bring it up in case it's something others have noticed and fixed or noticed and worked around thinking it was just happening to them.
Fix: By deleting the .pkl file it prompts for a new 2FA and everything is normal.
Suggestion: If a 503 [or 401, 403] is received, start auth over - this could obviously be handled on the implementation side, and if it were implemented at the wrapper level, then the auth would need to timestamp the previous attempt or in some other way handle an inf loop of 503s due to actual unavailability.

Someone else also reached out with this issue today, and I'm very curious why it is occurring. Perhaps you could share a whole trace so I can see exactly what line is throwing the error? The other person's error occurred after login when trying to run get_full_accounts(), which suggests that login occurred normally, then the error occurred, which is very weird.
The way login works currently is that it loads the pkl file, then checks it using _verify_login(). This function hits a protected endpoint (account_ids) to see if the cookies are valid. If not, it tries to refresh them and then tries again. Finally, if the refresh fails or an Exception occurs, it clears the cookies and continues logging in as normal (at least it's supposed to). Perhaps there's an edge case that is sneaking through :(

I believe this is fixed in newer/current versions. If not please reopen this issue


Exporting large issues not yet possible.

I'm sure you're aware of it and that's why the previews don't work yet, but this would be a great feature. I'm dying to have a look at those map files. Good job, loving this games modding culture.

Exporting large textures is supported in 0.2.0, though the performance is poor. Previewing is not in the plan, anyway.


dpdk_port_flapping_with_link_ports

Signed-off-by: Hiren Thakkar<EMAIL_ADDRESS>

Result:FAILURE JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-1/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/1683c5effd26d0adb7b60937e8e9746d3a1a9b77

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-2/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/93fa34f561cb68cf45c8ee174af9b7bc5f3b9168

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-3/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/93fa34f561cb68cf45c8ee174af9b7bc5f3b9168

Targeted all Dwaipayan's comments. Please find attached logs after changes.
ptf_dpdk_flapping_test_run.log

Result:FAILURE JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-5/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/f3767c24a139f15bae1fbb37f568a1e5e741d5d2

Result:FAILURE JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-6/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/f3767c24a139f15bae1fbb37f568a1e5e741d5d2

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-7/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/f3767c24a139f15bae1fbb37f568a1e5e741d5d2

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-8/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/8a6759814e2019f07f481bac2a2776e5f2a1b9f4

Result:SUCCESS JenkinsConsole:https://s3.ipdk.io/ovs/PR-65-10/index.html GitCommit:https://github.com/ipdk-io/ovs/commits/4f06eeb7d7fd332dc21b69cc6d20c9d2c2677d88


A new command to add K8s component to the Devfile from file

/kind feature

Which functionality do you think we should add?
Add a new command to odo that will add K8s component to the Devfile from a file.
odo add component --type k8s --from-file <file>

Why is this needed?
This command might be helpful in cases where you need to modify the Devfile to add a K8s resource without doing so manually.
For e.g., defining a DB microservice inside Devfile that the application can connect to via ServiceBinding; odo will ensure the microservice is created for a successful bind.
Using the command will avoid having to use kubectl or oc client to create the service as well.

/remove-lifecycle rotten
/remove-lifecycle stale
/lifecycle frozen
/priority Low
/reopen
Still relevant.


/proc/fbX not created

I can't forward image because of not created /proc/fbX
# ./vcam-util -l
Available virtual V4L2 compatible devices:
1. vcamfb0(640,480,rgb24) -> /dev/video0
2. vcamfb1(640,480,rgb24) -> /dev/video1
3. vcamfb2(640,480,rgb24) -> /dev/video2

# ls -al /proc/fb*
-r--r--r-- 1 root root 0 Jul  4 06:01 /proc/fb

will create vcamfbx in /proc/

will create vcamfbx in /proc/

@WayneLin1992, can you provide the documentation fix?

Close via commit 3fe27eb9b1bf448ade667e310760f98eb8f20ed7


OnUnitIdle override not working

I am following the tutorial here  but when I try to print a simple string after overriding OnUnitIdle nothing happens.
This is what I use:
virtual void OnUnitIdle(const Unit* unit) final { std::cout << "TEST" << std::endl.......
Then I create a worker and let it do nothing, but there is no message in the console window.

I have find out that acquiring of observation is broken because the game sets flag "has_cloak" for some units, but set CloakState to CloakUnknown. sc2api considers this value as error and stops receiving observation.
So, naive solution is to update the convertion routine for CloakState in the sc2_proto_to_pods.cc file.
I'm not sure what the reason of this changes in protocol and don't know if it is a correct solution. But you can try to cherry pick the observation-fix branch from my fork

Cool, I will try it out.

The fix worked for OnUnitIdle, but now OnGameStop() don't get called
    virtual void OnGameStop() final {
        cout << "TEST " << endl;
        Control()->SaveReplay("LastSave.SC2Replay");
    }


TST: Test that exceptions are included in mds object API.

The main point of making this a formal unit test is ensuring that other MDS implementations don't forget to expose the exceptions as attributes.

Not as obsessed about coverage as @tacaswell lol

Current coverage is 89.70% (diff: 100%)

Merging #250 into master will increase coverage by 0.63%

@@             master       #250   diff @@
==========================================
  Files             4          4
  Lines           476        476
  Methods           0          0
  Messages          0          0
  Branches         75         75
==========================================
+ Hits            424        427     +3
+ Misses           37         34     -3
  Partials         15         15

Powered by Codecov. Last update 54c2c0d...acfc132

Haha, no problem, @arkilic. I only added these because I realized I want them for portable-mds. This kind of coverage doesn't mean much for metadatastore itself.

I imported them in mdclient like a crazy person as well. mdclient has mds as a requirement just because of these exceptions.

As soon as this is merged I will kick off a PR into portable-mds that depends on this being in MDS master.

I will do the same in mdclient


cluster creation with existing FSx throws traceback

Environment:

AWS ParallelCluster :aws-parallelcluster-2.2.1
OS: alinux
Scheduler: SGE
Master instance type: t2.micro
Compute instance type: t2.micro

Bug description and how to reproduce:
Creating a cluster with a pre-existing FSx file system fails with a traceback:
[ec2-user@ip-172-31-41-28 ~]$ pcluster create cromwell
Beginning cluster creation for cluster: cromwell
Traceback (most recent call last):
  File "/usr/bin/pcluster", line 11, in <module>
    load_entry_point('aws-parallelcluster==2.2.1', 'console_scripts', 'pcluster')()
  File "/usr/lib/python2.7/site-packages/pcluster/cli.py", line 354, in main
    args.func(args)
  File "/usr/lib/python2.7/site-packages/pcluster/cli.py", line 27, in create
    pcluster.create(args)
  File "/usr/lib/python2.7/site-packages/pcluster/pcluster.py", line 76, in create
    config = cfnconfig.ParallelClusterConfig(args)
  File "/usr/lib/python2.7/site-packages/pcluster/cfnconfig.py", line 99, in __init__
    self.__init_fsx_parameters()
  File "/usr/lib/python2.7/site-packages/pcluster/cfnconfig.py", line 827, in __init_fsx_parameters
    self.__validate_resource("fsx_fs_id", (value, self.__master_subnet))
  File "/usr/lib/python2.7/site-packages/pcluster/cfnconfig.py", line 281, in __validate_resource
    self.__resource_validator.validate(resource_type, resource_value)
  File "/usr/lib/python2.7/site-packages/pcluster/config_sanity.py", line 517, in validate
    self.__validate_fsx_parameters(resource_type, resource_value)
  File "/usr/lib/python2.7/site-packages/pcluster/config_sanity.py", line 195, in __validate_fsx_parameters
    self.__check_fsx_fs_id(ec2, fsx, resource_value)
  File "/usr/lib/python2.7/site-packages/pcluster/config_sanity.py", line 173, in __check_fsx_fs_id
    "inbound and outbound TCP traffic from <IP_ADDRESS>/0 through port 988." % resource_value[0]
TypeError: __fail() takes exactly 2 arguments (1 given)

Additional context:
Config file is:
[aws]

[cluster cromwell]
vpc_settings = public
key_name = ********
initial_queue_size = 2
maintain_initial_size = true
fsx_settings = fs

[fsx fs]
shared_dir = /cromwell_root
fsx_fs_id = fs-0f0ddbaf5d3781422

[vpc public]
master_subnet_id = subnet-c264e1a5
vpc_id = vpc-461dcc3c

[global]
update_check = true
sanity_check = true
cluster_template = cromwell

[aliases]
ssh = ssh {CFN_USER}@{MASTER_IP} {ARGS}

The FSx Lustre file system is in us-east-1 where the cluster is created.

@wleepang This is because the default base_os = alinux which isn't currently supported. Fix it by switching to centos:
[cluster cromwell]
...
base_os = centos7

I know this is confusing, so I wrote validation to check before cluster create, in https://github.com/aws/aws-parallelcluster/pull/904 but it hasn't been released yet.
Also stayed tuned for amazon linux support in the very near future ;-).

@sean-smith - Thanks!  I did eventually figure this out by reading a blog by Jiawei Zhuang.  Looking forward to the update!


Event Dashboard Attendance/Tickets Sold Display Error

On Event Dashboard page Total tickets value is incremented in place of Attendance value as check in is done.

@mejariamol Should this one be reported to the server issue tracker? Or can this be solved entirely in the app?

@mariobehling Nothing wrong with the server. It was an app issue.


Mysterious line that doesn't do anything

Should there be something happening here?  It would appear that this line probably doesn't accomplish what the comment above it says it should.
https://github.com/defunkt/jquery-pjax/blob/master/jquery.pjax.js#L495

It does accomplish what the comment describes. Simply accessing the clientLeft property triggers a reflow in browsers. Please see http://mislav.uniqpath.com/2014/02/hidden-documentation/


Example events include extraneous fields

The sample messages for the NewKubernetesVersionAvailable  event include these fields
    "EventProcessedUtcTime": "2021-07-02T04:40:04.1049205Z",
    "PartitionId": 1,
    "EventEnqueuedUtcTime": "2021-07-01T04:52:58.8650000Z"

These fields are neither part of the Event Grid nor the CloudEvents schema  and should be removed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6e388fd-e73a-146c-de9f-7c58e83c63e9
Version Independent ID: 458b288c-894e-ab62-9a75-cb306e6817ae
Content: Azure Kubernetes Service as Event Grid source (Preview) - Azure Event Grid
Content Source: articles/event-grid/event-schema-aks.md
Service: event-grid
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

@zr-msft - could you look into this GitHub issue when you get a chance? Thanks!

Confirmed with the product team and clean it up. Thanks.
#please-close


is there any latest productvity tool like 2.5

https://www.microsoft.com/en-in/download/details.aspx?id=30425
is there any latest?

https://github.com/OfficeDev/Open-XML-SDK/releases/tag/v2.5

UPDATE: while we have made available (see above post) the 2.5 version of the productivity tool, we have been discussing updating it for the latest SDK version but currently have no immediate ETA on this.  We plan to revisit the subject after v3.0 releases.


Rework the "status" behaviour during startup

Smapp is currently a bit missleading with the status that it displays.

But the node actually was "initializing tortoise"
below full log from startup to the moment of that output
2024-02-12T09:27:16.964+0100	INFO	App version: v1.3.9. Git: -dirty - 74170d917d947065543bb383e4137d8fcac3d3ba . Go Version: go1.21.5. OS: darwin-arm64 . Genesis 0x9eebff023abb17ccb775c602daade8ed708f0a50
2024-02-12T09:27:16.964+0100	INFO	Welcome to Spacemesh. Spacemesh full node is starting...
2024-02-12T09:27:16.964+0100	INFO	Looking for identity file at `/Users/nj/post/7c8cef2b/key.bin`
2024-02-12T09:27:16.965+0100	INFO	Loaded existing identity; public key: 0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2
2024-02-12T09:27:16.965+0100	INFO	starting spacemesh	{"data-dir": "/Users/nj/Library/Application Support/Spacemesh/node-data/7c8cef2b", "post-dir": "/Users/nj/post/7c8cef2b", "hostname": "mm-2.local", "name": ""}
2024-02-12T09:27:16.965+0100	INFO	0ebef.clock	converting genesis time to local time	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "clock", "genesis": "2023-07-14T08:00:00.000Z", "local": "2023-07-14T10:00:00.000+0200", "name": "clock"}
2024-02-12T09:27:16.965+0100	INFO	0ebef	initializing p2p services	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2"}
2024-02-12T09:27:16.965+0100	INFO	0ebef.clock	starting global clock	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "clock", "now": "2024-02-12T09:27:16.965+0100", "genesis": "2023-07-14T10:00:00.000+0200", "layer_duration": "5m0s", "tick_interval": "1s", "name": "clock"}
2024-02-12T09:27:16.977+0100	INFO	0ebef.stateDbStore	running migrations	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "stateDbStore", "uri": "file:/Users/nj/Library/Application Support/Spacemesh/node-data/7c8cef2b/state.sql", "current version": 10, "target version": 10}
2024-02-12T09:27:16.977+0100	INFO	starting cache warmup
2024-02-12T09:28:16.087+0100	INFO	cache warmup	{"duration": "59.109612708s", "name": ""}
2024-02-12T09:28:16.087+0100	INFO	0ebef.cachedDB	initialized datastore	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "cachedDB", "config": {"ATXSize":3000000,"MalfeasanceSize":1000}, "name": "cachedDB"}
2024-02-12T09:28:16.090+0100	INFO	0ebef.stateDbStore	running migrations	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "stateDbStore", "uri": "file:/Users/nj/Library/Application Support/Spacemesh/node-data/7c8cef2b/node_state.sql", "current version": 2, "target version": 2}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator	starting post verifier	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator	scaling post verifier	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator", "current": 0, "new": 6}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator	started post verifier	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-2	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-0	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-1	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-3	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-4	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.493+0100	INFO	0ebef.nipostValidator.worker-5	starting	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "nipostValidator"}
2024-02-12T09:28:16.494+0100	INFO	0ebef.beacon	registered signing key	{"node_id": "0ebef94da720236bc9e1529ef0f33e4f6e340f29ba4969500546ab992d5474c2", "module": "beacon", "id": "0ebef", "name": "beacon"}
2024-02-12T09:28:16.494+0100	INFO	initializing tortoise

I think we should display something like "loading node state" instead.
Then the second weird behaviour is:

I wonder why it's there. The node is started and operational. I think smapp is somewhat confused.

So, display "loading node state" on "initializing tortoise" message? :)

Regarding "syncing activations..." it is displayed after having "syncing atx" message in the logs.
Then it should change to the ready state (displaying layers) after having one of these messages:

app started
atxs synced
malicious IDs synced

So probably something changed in the logs (or goes in a different order for some reason, which is weird)...
Do you have spacemesh-logs for this case?

So, display "loading node state" on "initializing tortoise" message? :)

I think so, but why does it say "running database migrations"?

Regarding "syncing activations..." it is displayed after having "syncing atx" message in the logs.
Then it should change to the ready state (displaying layers) after having one of these messages:

spacemesh-log-7c8cef2b.txt log and screen

spacemesh-log-7c8cef2b.txt

So, display "loading node state" on "initializing tortoise" message? :)

I think so, but why does it say "running database migrations"?

Regarding "syncing activations..." it is displayed after having "syncing atx" message in the logs.
Then it should change to the ready state (displaying layers) after having one of these messages:

spacemesh-log-7c8cef2b.txt log and screen
spacemesh-log-7c8cef2b.txt

I think so, but why does it say "running database migrations"?

Because latest known log message in the attached logs was "running migrations" :)

Ok so we need to extend the "known" list :)

Another thing to add:
2024-02-14T11:48:56.805+0100	INFO	starting cache warmup


Avoid expensive style recalculations and layouts changes during loading

Mostly visible on the homepage.
Maybe by fixing some size in the HTML, see some hints on https://www.ampproject.org/learn/how-amp-works/.

Mostly ok after @javamind changes so I close it.


pkg-config with goav cannot find where to set path

Hi apologies for the noob question, I have tried reading documentation and web search.
No matter what i try i keep getting the following error:
pkg-config --cflags  -- libswresample libswresample
error $GOPATH: no library found in $GOPATH: libswresample
error github.com: PKG_CONDIF_GITHUB not exported, skipping github.com lookup
error $PKG_CONFIG_PATH: open libswresample.pc: The system cannot find the file specified.
error : no library found in $GOPATH: libswresample
pkg-config: exit status 1
please help or point to a tutorial

I think that I encountered a similar issue: pkg-config was not able to find the .pc file even with the $PKG_CONFIG_PATH env var properly set (pkg-config ignore the value and always search in /usr/local/share/pkgconfig). I ended up by creating a sym link from the real path to the one which is configured by default for pkg-config.
ln -s /usr/lib/x86_64-linux-gnu/pkgconfig /usr/local/share/pkgconfig

This worked for ubuntu-22.04.


Mark TestBiasCorrection as slow

Resolves #179.
After this PR, tests/agents_tests/test_acer.py will contain

non-slow tests: Ran 290 tests in 26.788s, and
slow tests: Ran 132 tests in 772.546s.

(All the tests in the file run without gpus.)

LGTM


Firefox issue

I think the package does not detect firefox last version

Confirmed it thinks the OS is Linux on Mac with the latest Firefox.


Hi, can I have the code for motion switching published?

Your work is so wonderful!

Sorry that we provide only the fundamental implementation of our approach here.
To perform policy switch, you may need to set up an environment with multiple policy models loaded. After receiving the policy switch command (from an external controller or from an internal variable in the program),  fetch a score from the target policy's discriminator using the current state of the character and then directly take the target policy to control the character if the score is higher than a threshold. You may need some trials to find a proper value for the threshold. There is some engineering work to ensure the whole process works well and thus we have not included it in this code.
We are reimplementing our approach using another physics simulator and may release the policy switch code then.

I understand. I look forward to the release of that work. Thank you.


Make chain owners regular by default

Motivation
All chains, including the admin and faucet chains used to be created with a single super owner by default. Such chains are easy to brick if the owner makes a mistake.
Proposal
This PR changes ChainOwnership::single to define the single owner as a regular one instead of as a super owner. This way all chains will be created with a regular owner by default. If a super owner is desired, it is still easy to change ownership manually (and it's actually done in one of the tests).
Test Plan
Current tests had to be adjusted slightly as there are some that assert whether the rounds are as expected - now they still do, only they assert that the first round is not a fast one.
There is also a test that exercises a change of ownership into one including a super owner, which ensures that this functionality also works correctly.
Release Plan

Nothing to do / These changes follow the usual release cycle.

Links

Closes #2819
reviewer checklist

Please make sure to keep using fast blocks in the CLI command linera benchmark.


#4 Mutations sync error handling

Towards #1809
Towards https://github.com/google/ground-android/issues/1691
Remove global exception handling when applying mutations. This is no-op as DatastoreException isn't thrown during that process

This branch is forked from #1810, please review it once that is merged.
@... PTAL?

/gcbrun

@gino-m @JSunde ping!


Base images on F32

Since we removed worker probes let's try whether it's feasible to base images on F32 or Zuul would still object.

recheck

It's green so once a new base image is built, I'll remove the last commit and merge (if someone approves this)

recheck


Power ups

Power Ups implemented and AI is using them.
They differ a bit from the description on the How To. << needs to be changed.
Also there is a bug with ball passing through paddle i made an issue about it.
This pull request introduces a significant update to the game, adding a power-up system that enhances gameplay. The changes include importing new modules, modifying game logic to handle power-ups, and updating various classes to support the new features.
Power-Up System Implementation:

frontend/scripts/game/Game.js: Added power-up handling in the game, including creating power-ups, checking for power-up collection, and activating power-ups. [1] [2] [3] [4]

Player and Controller Updates:

frontend/scripts/game/controllers/AIController.js: Added an ai flag to the AIController class and adjusted the ball prediction difficulty. [1] [2]
frontend/scripts/game/controllers/HumanController.js: Added an ai flag to the HumanController class.
frontend/scripts/game/models/Player.js: Updated the Player class to manage power-ups, including methods for drawing inventory, adding, removing, and activating power-ups. [1] [2]

Collision and Ball Management:

frontend/scripts/game/managers/CollisionManager.js: Updated the collision manager to track the last player who touched the ball.
frontend/scripts/game/models/Ball.js: Added a lastTouchedPlayer attribute to the Ball class and adjusted the ball's speed settings. [1] [2]

Power-Up Model:

frontend/scripts/game/models/powerups/PowerUp.js: Defined new power-up types and their effects, and implemented the PowerUp class to handle power-up collection and effects.

These changes collectively enhance the game's dynamics by introducing power-ups that can significantly alter gameplay, providing players with additional strategic options.

Question ?
If there is still a bug woukdn't it be better to merge to main after it is fixed ?

Question ?
If there is still a bug wouldn't it be better to merge to main after it is fixed ?

The bug is in main from beginning, it's not connected to this branch. I just mentioned it here cause it needs to be fixed for eval


[loader] SDF support

This is a proposition to add support for SDF models in pinocchio >= 2.9.2 in RobotLoader

I was assuming that we will never have a model with both an URDF model and a SDF model

ping :)
Could we please finish this PR, so that #100 could also be handled?


Change enum to union type

Describe the bug
I am attempting to programmatically reset the component path state. I found the dispatchPathAction function on the instance of the component, and I can see there is a convenient action to reset defined in the enum pathActions.
I am having a bug when importing pathActions into my app to use the dispatch function. Due to the way enums work the string "RESET" does not match the enum RESET = "RESET" so I am forced to import the original enum from the lib directory like so:
import {pathActions} from "react-lasso-select/lib/pathReducer";
This import fails when running the app. From a little research this is an issue with enums (see here), that they cannot be imported from *.d.ts files.
This could be solved by simply changing the enum into a union type similar to this:
export type pathActions {
    "ADD" | "DELETE" | "MODIFY" | "MOVE" | "RESET" | "CHANGE"
}

This would be exportable, and would also have the benefit of allowing dispatch to work with string literals e.g. dispatchPathAction({type: "RESET"}).
To Reproduce
Steps to reproduce the behavior:

Import pathActions into a component (eg import {pathActions} from "react-lasso-select/lib/pathReducer";)
Attempt to use pathActions.ACTION in the dispatchPatchAction function (eg lassoRef.current.dispatchPathAction({type: pathActions.RESET}))
npm/yarn start
See error

Expected behavior
Type/enum should be imported successfully, and code should run
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome 91
Version<EMAIL_ADDRESS>

Hello,
I do not recommend accessing the internal methods of the component in this case. The best way to reset a component is to set the "value" param to an empty array.
const [points, setPoints] = useState([]);
return (
  <div className="App">
    <ReactLassoSelect
      value={points}
      src="./demo.jpg"
      onChange={(path) => {
        setPoints(path);
      }}
    />
    <button onClick={() => setPoints([]) }>Reset</button>
  </div>
 );

However, if you want to use the dispatcher you can use little typescript trick:
import { pathActions } from "react-lasso-select/lib/pathReducer";
// ...
lassoRef.current.dispatchPathAction({
  type: "RESET" as pathActions.RESET
});

Thanks for your response.
I ended up using your idea to use the values prop to control the Lasso component. Works perfectly.
As far as the TypeScript trick, I didn’t know about that, appreciate you sharing it!


Add filter function

What would you like to be added?
Would you like to add filter function in the plugin?
So we can filter notes just in the table view without opening the settings to change the Query code
Why is this needed?
Because of  too many tags and notes in one project，when I want to search for notes with a specific tag，I have to open the projects' setting to change the Query.  It's a quite unconvenient.
It would be better if we add a filter function.

Duplicate of #80.

Closing in favor of existing issue. Feel free to add your suggestions to it!


How to create alive notification url

After testing with ngrok, how do I create a live notification url? I am pretty new to this and the notification url does not seem to have a great deal of documentation. Could you please point me to the documenations or give me ideas of how can I host/create a notification url?

The notification URL is just pointing to a publically accessible HTTP API endpoint. NGrok just makes this easier to test locally. You could use Azure web apps or Azure Functions. Either way, the code in the lab can be used to do this.
Check the Azure docs for more details: https://docs.microsoft.com/en-us/azure/azure-functions/functions-create-serverless-api


Window is not defined for preact pre-render

Preact pre-render throws an error because window doesn't exist on the render environment :
`
/node_modules/form-data/lib/browser.js
ReferenceError: window is not defined`
`
This is most likely caused by using DOM or Web APIs.
Pre-render runs in node and has no access to globals available in browsers.
Consider wrapping code producing error in: 'if (typeof window !== "undefined") { ... }'
`
I could use the --no-prerender tag on the build command but I really didn't want to use it, is there a work-a-round for this? or should I create a pull-request to add "if (typeof window !== "undefined")..."  ?

Getting the same error on version 3.0.0 when performing SSR.
Updating browser.js to this solves the problem but it would be good is this was shipped.
/* eslint-env browser */
module.exports = typeof self == 'object' ? self.FormData : typeof window !='undefined' ? window.FormData : undefined;

Getting the same error on version 3.0.0 when performing SSR.
Updating browser.js to this solves the problem but it would be good is this was shipped.
/* eslint-env browser */
module.exports = typeof self == 'object' ? self.FormData : typeof window !='undefined' ? window.FormData : undefined;

For me, this was caused by the self object not being present globally in the server rendering context.
browser.js in form-data is already set up to check for self in the global context – presence of self means we are in SSR. In that case it provides self.FormData instead of window.FormData. This is where window is undefined comes from when self is undefined.
I fixed this by defining var self = self || this in the global SSR context.
I'm using react_on_rails for server rendering so for me the fix was to monkey patch ReactOnRails::ServerRenderingPool::RubyEmbeddedJavaScript like so:
ReactOnRails::ServerRenderingPool::RubyEmbeddedJavaScript.class_eval do
  def self.console_polyfill
    <<~JS
      var debugConsole = console;
      var console = { history: [] };
      ['error', 'log', 'info', 'warn'].forEach(function (level) {
        console[level] = function () {
          var argArray = Array.prototype.slice.call(arguments);
          if (argArray.length > 0) {
            argArray[0] = '[SERVER] ' + argArray[0];
          }
          console.history.push({level: level, arguments: argArray});
        };
      });
      // patched self and global definitions ------------------
      var global = global || this
      var self = self || this
      // ----------------------------
    JS
  end
end

This won't be relevant for everyone but hopefully provides a clue.


[wrt] Remove 2 manual TCs due to improve to auto tests

Impacted TCs num(approved): New 0, Update 0, Delete 2

The improved auto TCs pr link: https://github.com/crosswalk-project/crosswalk-test-suite/pull/1593

LGTM


Add addToTransactions to Attachment

See https://github.com/getsentry/sentry-cocoa/issues/1606

Currently blocked by https://getsentry.atlassian.net/browse/INGEST-815

dup of https://github.com/getsentry/sentry-dart/issues/649


Environment
moon 1.8.1

@ilyasotkov This is kind of by design right now, but I agree it's not ideal and I need to rebuild it.
moon run works because we abort on the 1st failure, so subsequent targets are not run. moon ci runs everything and never aborts, so that all failing targets can be aggregated and reviewed.

Fixed in v1.10!


vite config conflict

This vue component has the file inclusion without the ending of .vue

With vite setup there is conflict on the import as these files have to be ending with .vue
This is the error I get

when updated to .vue the conflict disappears, as shown here

Was wondering if there could be a flag setup on the install of this package so it could switch it in case someone is using the vite config. Or any other ideas on this?

Hello, if you look at it, I am thinking of updating the structure completely at the first opportunity. I will post more icons with a neater structure. I did not encounter the error you mentioned before, I will pay attention to this error after the update. Thank you

Oh and heads up for spam also tagged you on Twitter lol
On Wed, Aug 10, 2022, 11:04 AM Alberto Cuevas @.***>
wrote:

Hello, that sounds great I appreciate the help, if there is something I

could do I'd be happy to assistMessage ID:
@.***>

I fixed the error and released a new version so that it does not interfere with use. You can continue to use it by installing version 1.1.5

Awesome, thanks!
On Wed, Aug 10, 2022, 11:37 AM Mehmet Sağır @.***>
wrote:

I fixed the error and released a new version so that it does not interfere
with use. You can continue to use it by installing version 1.1.5
—
Reply to this email directly, view it on GitHub
https://github.com/mehmetsagir/v-svg-icons/issues/3#issuecomment-1210969868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALEOQSKDDEVDA4YVYYSKNHTVYPLEBANCNFSM52J5EXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


use correct perk in Roguery.MerryMen

Currently Roguery.MerryMenPatch is referring to BowMerryMen perk, because it has the same name as RogueryMerryMen perk.
This RogueryMerryMen is indeed rogue as it doesn't even have a property in DefaultPerks so had to find it by StringId.
The workaround is quite ugly but I could not find any better way, maybe you can help with this?
Btw TW has also BowMountedArcher and RidingMountedArcher with the same problem.

I think we could change the PerkPatchBase._perk accessibility to protected, and then you override the Reset function with  Reset() => _perk = PerkObject.FindFirst(x => x.StringId == "RogueryMerryMen").
We could also change the constructor argument from "Id" to "StringId", but that would require refactoring a bunch of stuff so I think the first option is better for the few perks that need it.

PerkPatchBase should have a 2nd protected constructor that allows you to specify the perk finder Func<PerkObject>
One of the reasons to use the perk's localization ID is to ensure the perk is initialized if they change the way serialization works (and break something) - special cases are fine though I'd recommend the finder check both the StringId and Id.

Thanks guys, looks much better now.


[BUG] "Goal Indicator Warning Color" is illegible when using YNAB dark mode

Describe the bug
Instead of a saturated blue to match the red, yellow, and greens of dark mode, underfunded categories are highlighted in a more pastel blue that makes perfect sense in light mode but is illegible in dark mode.
To Reproduce
Steps to reproduce the behavior:

Enable "Goal Indicator Warning Color" in the Budget Screen settings.
In YNAB, create a category with a funding goal.
Budget less money to that category than the goal requires.

Expected behavior
The underfunded color is a more saturated blue.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox v89
Toolkit Version 2.33.0

Setting Export
Please replace the text below with your exported Toolkit settings. You can export these by going to the Toolkit Options page, click the Import/Export Settings button at the bottom left and copying the text in the modal which appears.
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":false},{"key":"AccountsStripedRowsColor","value":"#fafafa"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BottomNotificationBar","value":false},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"CategorySoloMode","value":"0"},{"key":"ChangeEnterBehavior","value":false},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"ConfirmKeyboardCancelationOfTransactionChanges","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CtrlEnterCleared","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomFlagNames","value":false},{"key":"DateOfMoney","value":false},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingDate","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"3"},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"FilterCategories","value":false},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":false},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":false},{"key":"HoveredBudgetRows","value":false},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"LastReconciledDate","value":false},{"key":"LinkToInflows","value":false},{"key":"MasterCategoryRowColor","value":false},{"key":"MemoAsMarkdown","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"NotesAsMarkdown","value":false},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconcileBalance","value":false},{"key":"ReconcileConfetti","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":false},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SplitTransactionAutoFillPayee","value":false},{"key":"SplitTransactionTabExpand","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"StripedBudgetRows","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"0"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":false},{"key":"ViewZeroAsEmpty","value":false},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":true}]

How does this look?
I've left the goal progress bars the same colour as before, but they could also be colour swapped pretty easily - I'm not sure if it makes sense, but it would make things look nicer.

That looks perfect! I'm not so sure about the last image but I'd say since it aligns with the rest of the palette it's good.

Hey @icorbrey  the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browsers can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".

Wonderful, thank you all!


URI in RedirectURI isn't accepted

When configuring the OAuth component with a redirect URI, instead of a redirect URL, the authentication fails with invalid or missing redirect_uri, which in the context of a redirect URI - instead of a redirect URL - is wrong.
As the name suggests, one can use redirect URIs (i.e. protocol:action), which is just as valid as a redirect URL with protocol://authority.
Been redirected here from ownCloud/ocis, as it is used in the Embedded Identity Provider there.
Checking https://github.com/libregraph/lico/blob/master/oidc/payload/authentication.go#L335-L337, leads to the main culprit: As a URL is a URI, you only need to check for RedirectURI and Protocol being set. The host-component is part of a URL, which not every URI has.
When enforcing redirect URIs to be URLs all other forms of URIs are excluded (i.e. urn:, x-custom-protocol:action, etc.).
Also: owncloud/ocis#10159

I guess we can improve this check and only fail if both Host and Scheme are empty.
https://play.golang.com/p/uL442LPu4cx

I'd even go as far as just checking IsAbs().

Good suggestion thanks :+1:


Bad Reset-Password Email

The Email when trying to reset a password doesn't actually contain a link, just the 'token'
I let it slide in #47 but we gotta get it fixed

We're not doing emails anymore. In fact so much stuff has changed we might as well call this Stale


Publish to AWS Lambda uses Stale Credentials

Describe the bug
I login to AWS using temporary credentials obtained through federation and written to the default profile in .aws\credentials.
It appears these are cached and not re-read when expired. I've noticed with at least the publish function.
To Reproduce

Open a Lambda project in Visual Studio 2019 while having valid AWS credentials.
Publish lambda function.
Wait until credentials expire.
Attempt to publish lambda function again, get error about credentials being expired.
Obtain new credentials using federation.
Attempt to publish again.

Expected behavior
New credentials should be read from the default profile without needing to restart Visual Studio.
Screenshots

Computer (please complete the following information):

Windows 10
Visual Studio 2019 16.4.5
AWS Toolkit for Visual Studio Version:<IP_ADDRESS>

Additional context

even am getting the same issue. any resolution please???

Changes to how credentials are handled were made in version <IP_ADDRESS> of the Toolkit:

The Toolkit now refreshes when it detects changes in the credentials files
Each time the Publish Lambda dialog is opened, the credentials are validated before you can proceed to deploy

Also, the Toolkit supports AWS SSO based credentials, which you might be interested in trying out - Blog post
Please try these out, and file a new issue if you are still encountering issues.


Minor change to patch subject

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kschumy
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kschumy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kschumy: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit-tests
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit-tests
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit-tests

kubernetes-1-20-presubmit
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit

kubernetes-1-20-presubmit-tests
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/test kubernetes-1-20-presubmit

/retest

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit-tests
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit-tests

kubernetes-1-20-presubmit
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit

kubernetes-1-19-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-19-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-20-presubmit
d932d22da4b7c33a8e6d26e0ad4fe95301598566
link
/test kubernetes-1-20-presubmit

kubernetes-1-19-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-19-presubmit

kubernetes-1-18-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-18-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-19-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-19-presubmit

kubernetes-1-18-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-18-presubmit

kubernetes-1-20-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-20-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kschumy: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

kubernetes-1-19-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-19-presubmit

kubernetes-1-18-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-18-presubmit

kubernetes-1-20-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-20-presubmit

kubernetes-1-21-presubmit
5978e652e1a8ca7e4dc1cdb2c0132d8e2622f713
link
/test kubernetes-1-21-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jaxesn, kschumy
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jaxesn,kschumy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Move to ramda

Current version of redux-crud uses:
"lodash.assign": "^4.2.0",
"lodash.every": "^4.6.0",
"lodash.find": "^4.6.0",
"lodash.foreach": "^4.5.0",
"lodash.isarray": "^4.0.0",
"lodash.isobject": "^3.0.2",
"lodash.omit": "^4.5.0",
"lodash.reject": "^4.6.0",
"lodash.values": "^4.3.0"

All this minified using webpack takes 50KB
All lodash minified takes 72 KB
All ramda minified using webpack takes 57 KB
So there is not a big advantage in using individual lodash modules. As ramda is nicer let's switch to ramda and remove all this small deps.

Done in 3


Documentation typos

description of z3d module describes 2D
bounded and wrapped fill descriptions appear to be swapped

Also, on next edit, add link to crates.io to readme


Add non-ambient doc

First version.
Will add the How part later.

Changed idea. The how to part will be included in how-to-write-typings.md instead.

Can we standardize and say external module format instead of "non-ambient"?

Let me update the doc and resent the PR


Release of dev-master having Samesite cookie issue fixes

Hi @osiset, @jedimdan
First of all many many thanks to all of you for your contribution in this project.
I have used this project to build an embedded shopify app. In Feb 2020, I upgraded the package to the 10.3.1 due to samesite cookie issues. After this upgrade I am continuously facing some issues like "Unable to get shop domain.". It seems that this has been fixed in the dev-master branch, but this branch does not have samesite cookies issue fixes.
So could you please give me an idea about when you guys have planned to make a release of this dev-master branch having samesite cookie issue fixes.
Thanks in advance
Faisal Saeed

Unit/functional testing is complete.Physical tests are going well, I have many many edge cases I have to test for so I am hoping by end of next week or week after I can release it.If that solves your questions please close the issue :)On Mar. 12, 2020 12:20, Faisal Saeed<EMAIL_ADDRESS>wrote:
Hi @osiset, @jedimdan
First of all many many thanks to all of you for your contribution in this project.
I have used this project to build an embedded shopify app. In Feb 2020, I upgraded the package to the 10.3.1 due to samesite cookie issues. After this upgrade I am continuously facing some issues like "Unable to get shop domain.". It seems that this has been fixed in the dev-master branch, but this branch does not have samesite cookies issue fixes.
So could you please give me an idea about when you guys have planned to make a release of this dev-master branch having samesite cookie issue fixes.
Thanks in advance
Faisal Saeed
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you for your kind response. I am closing this issue and will wait for your next release.

@faisal-saeed-brainx I've personally not experienced this myself. Just out of curiosity, can you share with us in what scenario does this occur, and what is the fix that's in the master branch that addressed it?
Glad that @osiset know's what you're talking about, but I think it's useful for the rest of us to know as well, so we can find out if we have the same problem.

@jedimdan
As I am facing issue with cookies myself, I found this.
https://github.com/osiset/laravel-shopify/pull/382


xpipe: init at 1.6.0

Description of changes
New package for https://github.com/xpipe-io/xpipe
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Feel free to mark the comments as resolved, and squash the fixups into xpipe: init at 1.6.0

So I guess this is ready to be merged or this anything else that needs to be done?

So I guess this is ready to be merged or this anything else that needs to be done?

I'm not able to find much more. But I don't have the commit bit either. I think you'll just have to wait, ask for more reviews, or ask someone with commit rights to look at it.
Have you built and tested the binaries by the way? I know it was marked as such, but lots of small changes has happened since then.

Oh, and by the way, I think you squashed a bit too much. The commits are usually supposed to look like this:
maintainers: add crschnick
xpipe: init at 1.6.0

Alright so I confirmed that it builds correctly for me and resquashed everything properly. In order to get this merged, I will just have to wait?

Yeah, unfortunately. As you can see from the PR backlog, that can sometimes take quite a while. There are a few ways you can ask for help though, namely through a few discourse threads names "PRs ready for review/testing/already reviewed", or maybe ask someone in the relevant matrix channels. Alternatively, you could help everyone speed up the process by reviewing some PRs yourself.

I just built and had a look at it - while I don't see it marked as obligatory anywhere, I'm pretty sure you'll have to move or link the binary to $out/bin/xpiped. Everything in nixpkgs expects this location for binaries. Probably the same for share

Oh I see, fixed that

Still having some trouble...
[nix-shell:~/.cache/nixpkgs-review/pr-259855-1/results/xpipe]$ bin/xpipe version
java.io.IOException: Cannot run program "/nix/store/n3lxnih9wxx49fr0jhzjdiv8rb25rswq-xpipe-1.6.0/opt/xpipe/app/bin/xpiped": error=2, No such file or directory
        at java.base@21/java.lang.ProcessBuilder.start(ProcessBuilder.java:1170)
        at java.base@21/java.lang.ProcessBuilder.start(ProcessBuilder.java:1089)
        at io.xpipe.core.util.XPipeInstallation.queryLocalInstallationVersion(XPipeInstallation.java:192)
        at io.xpipe.cli.meta.VersionCommand.call(VersionCommand.java:50)
        at io.xpipe.cli.meta.VersionCommand.call(VersionCommand.java:15)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at io.xpipe.cli.XPipeCommand.execute(XPipeCommand.java:57)
        at io.xpipe.cli.Main.mainInternal(Main.java:31)
        at io.xpipe.cli.Main.main(Main.java:12)
        at java.base@21/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)
Caused by: java.io.IOException: error=2, No such file or directory
        at java.base@21/java.lang.ProcessImpl.forkAndExec(Native Method)
        at java.base@21/java.lang.ProcessImpl.<init>(ProcessImpl.java:295)
        at java.base@21/java.lang.ProcessImpl.start(ProcessImpl.java:225)
        at java.base@21/java.lang.ProcessBuilder.start(ProcessBuilder.java:1126)
        ... 16 more

hm ... does the app/bin/xpiped at least work for you?

Nope
[nix-shell:~/.cache/nixpkgs-review/pr-259855-1/results/xpipe]$ opt/xpipe/app/bin/xpiped
bash: opt/xpipe/app/bin/xpiped: cannot execute: required file not found

okay I will investigate this, I suspect that the cli executable launched the other normal deb installation in the system /opt/xpipe path for me

so I'm a little bit confused here. I'd retried it for me and both executables launched. In your case it seems like one executable is missing? For me the result looks like this:

[nix-shell:~/.cache/nixpkgs-review/pr-259855-1/results/xpipe]$ strace opt/xpipe/app/bin/xpiped
execve("opt/xpipe/app/bin/xpiped", ["opt/xpipe/app/bin/xpiped"], 0x7ffcb6721560 /* 155 vars */) = -1 ENOENT (No such file or directory)
strace: exec: No such file or directory
+++ exited with 1 +++

Would you mind creating a room on matrix, so we could figure this out without going back and forth over github?

This is ready to be merged. Since this takes quite a while now, there are frequent merge conflicts caused by other packages being added, which probably draws out the process even longer.


Multiple "regression" on 10.7.0 (wait strategy) and 10.8.0 (image substitution) when running using kubedock environment

Hi,
I already posted some details on https://github.com/joyrex2001/kubedock/issues/84 because I'm not sure where is located the issue.
We noticed behavior/regression changes when upgrading from 10.6 to 10.8.1 when running using kubedock on Kubernetes
We have the same setup with Testcontainer java (version 1.19.7) and testcontainer .NET (version 3.7.0) and all works fine
But for some reason node module is not working post 10.6
I noticied 2 PR that could have cause such changes
https://github.com/testcontainers/testcontainers-node/pull/712 (released on 10.7)
https://github.com/testcontainers/testcontainers-node/pull/729 (release on 10.8)
The issue is not producible using a "real" docker socket with Rancher Deskop
Expected Behaviour
Should work
Actual Behaviour
Container is started like this
    wireMockContainer = await new GenericContainer("wiremock/wiremock:3.3.1-2")
      .withExposedPorts(8080)
      .withCommand(["--verbose"])
      .withWaitStrategy(Wait.forLogMessage(/port:.*8080/))
      .withStartupTimeout(120000)
      .start();

On 10.7
[11:33:21.886+02:00] - 2024-04-03T09:33:21.059Z testcontainers [ERROR] [283b40bf8ce7] Container failed to be ready: Error: Log stream ended and message "/.+ Started!/" was not received

[11:33:21.885+02:00] - 2024-04-03T09:33:20.978Z testcontainers [DEBUG] [283b40bf8ce7] Waiting for container to be ready...
[11:33:21.885+02:00] - 2024-04-03T09:33:20.979Z testcontainers [DEBUG] [283b40bf8ce7] Waiting for log message "/.+ Started!/"...
[11:33:21.885+02:00] - 2024-04-03T09:33:20.979Z testcontainers [DEBUG] [283b40bf8ce7] Fetching container logs...
[11:33:21.885+02:00] - 2024-04-03T09:33:20.982Z testcontainers [DEBUG] [283b40bf8ce7] Demuxing stream...
[11:33:21.885+02:00] - 2024-04-03T09:33:20.982Z testcontainers [DEBUG] [283b40bf8ce7] Demuxed stream
[11:33:21.885+02:00] - 2024-04-03T09:33:20.982Z testcontainers [DEBUG] [283b40bf8ce7] Fetched container logs
[11:33:21.886+02:00] - 2024-04-03T09:33:21.058Z testcontainers [ERROR] [283b40bf8ce7] Log stream ended and message "/.+ Started!/" was not received
[11:33:21.886+02:00] - 2024-04-03T09:33:21.059Z testcontainers [ERROR] [283b40bf8ce7] Container failed to be ready: Error: Log stream ended and message "/.+ Started!/" was not received
[11:33:21.886+02:00] - 2024-04-03T09:33:21.059Z testcontainers [DEBUG] [283b40bf8ce7] Stopping container...
[11:33:21.886+02:00] - 2024-04-03T09:33:21.202Z testcontainers [DEBUG] [283b40bf8ce7] Stopped container
[11:33:21.886+02:00] - 2024-04-03T09:33:21.202Z testcontainers [DEBUG] [283b40bf8ce7] Removing container...
[11:33:21.886+02:00] - 2024-04-03T09:33:21.205Z testcontainers [DEBUG] [283b40bf8ce7] Removed container
[11:33:21.886+02:00] - 2024-04-03T09:33:21.205Z testcontainers [DEBUG] Releasing lock file "/tmp/testcontainers-node.lock"...
[11:33:21.886+02:00] - 2024-04-03T09:33:21.206Z testcontainers [DEBUG] Released lock file "/tmp/testcontainers-node.lock"

This was working fine on 10.6
On 10.8.1
Basically it hangs on Acquiring lock file
[11:23:05.306+02:00] - 2024-04-03T09:23:05.264Z testcontainers [DEBUG] Acquired lock file "/tmp/testcontainers-node.lock"
[11:23:05.306+02:00] - 2024-04-03T09:23:05.264Z testcontainers [DEBUG] Listing containers...
[11:23:05.306+02:00] - 2024-04-03T09:23:05.267Z testcontainers [DEBUG] Listed containers
[11:23:05.306+02:00] - 2024-04-03T09:23:05.268Z testcontainers [DEBUG] Creating new Reaper for session "4985d02b214e" with socket path "/var/run/docker.sock"...
[11:23:05.306+02:00] - 2024-04-03T09:23:05.268Z testcontainers [INFO] Applying changes to image testcontainers/ryuk with tag 0.5.1: added registry r-docker-registry-1-docker-io.artifactory.******/
[11:23:05.306+02:00] - 2024-04-03T09:23:05.268Z testcontainers [DEBUG] Checking if image exists "r-docker-registry-1-docker-io.artifactory********//testcontainers/ryuk:0.5.1"...
[11:23:05.306+02:00] - 2024-04-03T09:23:05.270Z testcontainers [DEBUG] Checked if image exists "r-docker-registry-1-docker-io.artifactory*******//testcontainers/ryuk:0.5.1"
[11:23:05.306+02:00] - 2024-04-03T09:23:05.270Z testcontainers [DEBUG] Image "r-docker-registry-1-docker-io.artifactory.******//testcontainers/ryuk:0.5.1" already exists
[11:23:05.306+02:00] - 2024-04-03T09:23:05.270Z testcontainers [DEBUG] Acquiring lock file "/tmp/testcontainers-node.lock"...
[11:24:41.996+02:00] -  ❯ src/ts/api.test.ts  (5 tests) 90133ms
[11:24:41.996+02:00] -
[11:24:41.996+02:00] - ⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯
[11:24:41.996+02:00] -
[11:24:41.996+02:00] -  FAIL  src/ts/api.test.ts > api
[11:24:41.996+02:00] - Error: Hook timed out in 90000ms.

Since 10.6 I was using environment (but didn't realized it was not used before https://github.com/testcontainers/testcontainers-node/pull/729)
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX  = 'r-docker-registry-1-docker-io.artifactory.*********/'

Noticed the double // on the logs. I tried also with no trailing slash and behavior is the same.
Any hints is appreciated!
Thanks!
I'm more happy to give more detail/logs if needed

Made a PR with the fix here - https://github.com/testcontainers/testcontainers-node/pull/748

I don't think this will fix the problem. The root-cause for https://github.com/joyrex2001/kubedock/issues/84 is this constant being compared with a rewritten image. Because the isReaper detection fails, it tries to create another lockfile (which fails, because it is locked already).
My suggestion would be to prefix the default value for REAPER_IMAGE with TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX environment variable (but there might be a better solution).

Please try version 10.8.2

Tried with our proxy and env variable having a form export TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX=domain.com/docker-virtual/ and it worked.

Will give some time for @jonesbusy or @joyrex2001 to confirm, and then will close this issue.

Thanks, I will try to test tomorrow

Hi,
Thanks again for the fix and help of @joyrex2001
I confirm issues I was facing are fixed with 10.8.2
Regards,


Site won't open because of phishing

I was sent to this site by the Viction support team to track down my missing tokens.
I can't enter the site because of the phishing warning.
I need to follow their directions to get back my missing TOMO tokens.

I was sent to this site by the Viction support team to track down my missing tokens.
I can't enter the site because of the phishing warning.
I need to follow their directions to get back my missing TOMO tokens.

Can you tell us what that site is? If it is marked as phishing, it is almost 100% malicious, but we can always make mistakes, so please tell us which site you are referring to.


Ensure that the routers can receive form data

Current limitations:

We can only process base64 for now (need to be able to derive base64/binary from OpenAPI)
Express not supported yet

Actually let's just use koa-body instead of body-parser and multer. Seems more simple.


Feature request. Creating opengl context after creating a window.

Hi, I went into a trouble when trying to create cross-api (cross-graphics) engine. The problem is when glfw creates a window without context(glfwWindowHint(GLFW_CLIENT_API, GLFW_NO_API)), I can create it, only using glfw3native.h and platform specific calls. I am suggesting creating a few functions, like void glfwCreateWindowContext(GLFWWindow*), which would work for windows, created without context, and void glfwDestroyWindowContext(GLFWWindow*).

There is a PR I have made for creating secondary user contexts for windows, however this depends on the window having been already created with a current context.
It might be possible to use this PR as a base to create the functionality you need for your request, however I do not have the time to do this personally.

I think this is a great idea. Actually, I think it could be a good idea to go as far as deprecating glfwWindowHint, and let the user create rendering context(s) after window creation, similarly to glfwCreateWindowSurface. It also aligns with added support for software renderer as fallback: https://github.com/glfw/glfw/issues/2528
My usecase would be:

Create a window (if it fails, write message to stderr)
Try to create a context (if it fails, use the current window to display an image rendered on the CPU)

If the application does have a fallback, step 3 would be to initiate a software renderer. It could also be that the user prefers to use a software renderer, because it has a slightly different look.
If the context is created as part of glfwCreateWindow, an exception would have to be handled, and glfwCreateWindow needs to be called again in the catch block. Awkward.


build: speed up clippy check

What have you changed?
This PR speeds up clippy check by reducing running rounds.
What is the type of the changes?

Improvement

How is the PR tested?

Manual test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.

Tests show that test time is reduced by about 4 minutes.


Added ProductCode and x86 version of Transmission

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

I have a feeling this will fail


Control EXECUTOR_THREAD_POOL_SIZE

https://github.com/couchbase/couchbase-lite-java-core/blob/master/src/main/java/com/couchbase/lite/replicator/ReplicationInternal.java#L72
The number of threads should be a parameter when a replicaiton object is created.
One reason is that I noticed that each thread makes a PUT request (_local/...) when it's done, to save the lastSequence.
This may be a costly overhead, in case you don't care about the replication speed and the documents are fetched in bulks (using _all_docs or _bulk_get).

Currently PR is under review. After PR is merged into master, EXECUTOR_THREAD_POOL_SIZE will be configurable with using ManagerOptions.
ManagerOptions options = new ManagerOptions();
options. setExecutorThreadPooSize(10); // set 10 for pool size
Manager manager = new Manager(..., options);


Agent Name confusing and not consistent

[Enter feedback here]
What is reference in this page as Log Analytic Agents is referred a MicrosoftMonitoringAgent when deployed as Windows Extension and In the Heartbeat record in Log Analytic Workspace, the Category field as a value of Direct Agent.
Totally inconsistent across the various system and very confusing to endusers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e57fdf8-ece5-2bf1-200e-f089691de53f
Version Independent ID: cd84fac1-b179-6158-e61d-d85d797efdf3
Content: Overview of the Azure monitoring agents - Azure Monitor
Content Source: articles/azure-monitor/agents/agents-overview.md
Service: azure-monitor
Sub-service: agents
GitHub Login: @bwren
Microsoft Alias: bwren

@ramganesh19, thank you for sharing this feedback.
I understand the confusion you are going through regarding these terminologies. The following information should help clarify them.

The very earlier version of "Agent" that could connect to Log Analytics workspace was the same as used by SCOM (System Center Operations Manager). The SCOM agent, renamed to "Microsoft Monitoring Agent" had the capability to send data to SCOM management group as well as Log Analytics Workspace. Therefore, the same agent came to be also known as Log Analytics agent (when used for Log Analytics workspace reporting only, where SCOM is not present). Please refer to the note section of this link which states "You may also see the Log Analytics agent referred to as the Microsoft Monitoring Agent (MMA)."
Regarding the "Direct Agent" in Log Analytics's Heartbeat table, it is the category which means that the agent is installed on the Machine from where the data is being collected. It is not related to "MMA/LA agent" specifically.

Please note that The Log Analytics agents are on a deprecation path and will no longer be supported after August 31, 2024. If you use the Log Analytics agents to ingest data to Azure Monitor, make sure to migrate to the new Azure Monitor agent prior to that date.
Please let me know if you have any questions.

@ramganesh19, We will now proceed to close this thread as we have not heard back from you. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.

Direct Agent is the (legacy) Log Analytics agent aka. Microsoft Monitoring Agent (it is deprecated but still working as of today for your Windows Server 2008 R2 / Windows Server 2012 / Windows Server 2012 R2 workloads).
As per this page - https://learn.microsoft.com/en-us/azure/azure-monitor/agents/agent-windows?tabs=setup-wizard -
the KQL query for MMA / LA heartbeat should look for Category == "Direct Agent":
Heartbeat
| where Category == "Direct Agent"
| where TimeGenerated > ago(30m)

Contrast with Azure Monitor Agent - https://learn.microsoft.com/en-us/azure/azure-monitor/agents/azure-monitor-agent-windows-client#verify-successful-setup - "the Category column should say 'Azure Monitor Agent'"


Save chat input in chatModel for restoring later

This fixes restoring chat input on transferring to a new workspace.
Also handles case where chat is transferred from the panel to the editor.

I don't like this approach because IChatModel seems like the wrong place for this data, and that interface is read-only for all other content. I'd have to think about a better way to transfer some view state along with the session data. The idea is to keep the same input in the input box after you click the button to open the new project, in case I started typing a question? That's ok, it doesn't sound like a common scenario though.

The idea is to keep the same input in the input box after you click the button to open the new project, in case I started typing a question? That's ok, it doesn't sound like a common scenario though.

Yes. After we've transferred the session over to a new workspace, we'd like to preserve the /createWorkspace in the input.
The other scenario is moving from the panel chat to the editor.
Currently we store and restore the input state in the chatViewPane at a WORKSPACE level. I'll check to see there's a change I can make there.


Headlines and trailing slashes

Added spaces before headlines to remove the hashes from the headlines in Atom preview.
Also, auto-formatted the doc to remove trailing spaces.

So awesome! Thanks 😄


CB-6412 Tie balanced dns to app version

I think another check is needed in StackToDescribeFreeIpaResponseConverter::convert() for the load balanced DNS names.


Add the possibility to clear the search cache

In order to make benchmark as fair as possible, it would be nice to have a rest handle that would clear our two caches:

the split footer cache
the fast_fields_cache

@fmassot
If the caches should be cleared after every benchmark iteration is run, even the overhead of clearing the cache would be in the benchmark right and also the overhead of creating the cache?
So instead is there a way to not cache itself so that we get a more fair benchmark.

@Abhicodes-crypto your comment is indeed very relevant. Currently, it's possible to set Quickwit the size of the cache to 0 bytes, I was not aware of that when I opened the issue. This is a good setup from a benchmark perspective.
Having an endpoint for clearing the cache is still interesting when you don't want to restart the server with a different config for example.

Currently, it's possible to set Quickwit the size of the cache to 0 bytes, I was not aware of that when I opened the issue.
@fmassot Should I go ahead and set cache to zero on. benchmarks wherever applicable.

Having an endpoint for clearing the cache is still interesting when you don't want to restart the server with a different config for example.
I can take up this task after addressing this issue, if that's okay.

Should I go ahead and set cache to zero on benchmarks wherever applicable ?

This is not needed in the codebase. We could add a word in the docs, like "To disable search caching, set to 0 those parameters".

I guess the rest handle would clear the cache in the server that processes the current request. Would it be possible to add a rest handle for clearing the cache across all servers, rather than just the one processing the current request?

Clearing the cache on one node is sufficient for now and a good start.
If you want to assist on this, can you propose a detailed plan before opening a PR?

If you want to assist on this, can you propose a detailed plan before opening a PR?

Sure.

Hi @fmassot ,
I was not able to give attention to this. It's been a long time. Apologies for that.
I've planned to implement this in the following way.

Create a /cache/clear endpoint in quickwit/quickwit-serve/src/cache_api
There is a trait Cache at quickwit/quickwit-storage/src/cache/mod.rs:61 . I would add a function clear to it.
Will be using the lru_cache's clear method to implement the clear functionality for cache.
From the /cache/clear endpoint call the clear functionality on the cache object.

Things I am not sure about :

Where to get the cache object from.

Please let me know your thoughts.

we now also have a partial_request_cache now, which should probably be cleared too, although setting searcher.partial_request_cache_capacity: 0 is already enough to disable it.

So can this issue be closed ?

Hi @Abhicodes-crypto sorry for the late answer. While we can disable the cache with the config, I still think it's nice to have an endpoint to clear the cache as you don't want to restart the instance each time to clear some cache. Could be very useful when making tests, demo, etc.
Let me come back to you later today to confirm you can can work on this and give you more insights.

Sure @fmassot , Looking forward.

Hi @fmassot , any update on this.


Scaling out and back in from one slide to another

When going from one slide to another, does anybody know how to scale out from first slide, have the presentation move to second slide, then scale back in?
Example: Slide one and two would have scale 1 but at the center point of the transition the scale would be 2

Hi @WonderboyPark  and @inlandyears , in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.
To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older issues like this one to see if the OP is still interested in keep it going.

Closing due to the lack of feedback from the OP. Feel free to comment here to open up the discussion again


subjs on Windows

Hi,
I have been trying this out on Windows and I cant seem to make it work.
subjs.exe -h  will display the help content correctly
but when i try subjs.exe -i url.txt it doesnt work. Nothing happens. This is what I see on my terminal.
Path\to\subjs>subjs.exe -i urls.txt
Path\to\subjs>

Go is installed. Version go1.16.2 windows/amd64
Is there anything else that needs to be done?

Figured it out. Had nothing to do with windows.
In the url.txt I had typed the site without http:// or https://
Once I added it the issue was fixed


EF: Rewrite Setup.CheckIncludes()

This takes too long to run when the employee table gets large.
We need to find a smaller table or otherwise change it so that we're not pulling back so many records.

Also affects EF Core


Default values in the menu sliders on the first run and

First, thank you! It was a gaping hole in MacOS, thank you for making our lives better!
When I first run MC, all the sliders in the menu defaulted to 0 (leftmost position). The monitor volume, brightness and contrast definitely were not at 0.
I'd love to a) initially see what were the values in the beginning, and b) be able to reset back to monitor defaults (if such a thing as monitor defaults exists).
I'm not a color profile specialist, so I don't know what are the optimal settings for the monitor.

Do you mean when you launched the app, it actually set the brightness and contrast to its minimum setting on your monitor, or just the UI?
For finding initial values you might have to change the settings if not supported (increase brightness +1, then back -1 etc.)
Monitor "default" settings definitely are a thing, but what those defaults are, and in turn the usefulness of those settings, vary.
Consumer displays often have the "Reset Picture Settings" option in their OSD that blows away any adjustments you made to the factory defaults. Decent panels are calibrated at least to some level at the factory, and the result normalized so the default values are consistent between units (i.e. all units have default "50" for contrast slider, not 48 or 52 depending on calibration.) Less commonly, the calibrated values themselves are programmed in as the defaults. Whether the reset command can be issued inband depends on the display.
If you have a "monitor" monitor, the defaults would be the détente on the knobs I guess? But those have no other meaning than the mid-range value, and their behavior is a bit different as far as connection goes, I've never tried using  the DisplayPort input to control brightness, but I'd assume it'd be ignored. They're controlled by proprietary protocols in channels such as ethernet or RS485, that would be a completely new app if someone was to implement a software solution.

I mean just the UI.
I'm not asking as much as resetting to a factory settings or reading them. That would be too complicated. But, if the monitor responds to a respective CEC command, to position the settings' knobs to the amount they were set to before the app was launched. If it doesn't, maybe 50% would be a more reasonable default for brightness and contrast than 0.
And yes, I can control the brightness and contrast of my USB-C monitor with MonitorControl.

That sounds like a pretty annoying bug though, I was asking if I understand correctly, so if MonitorControl is ever relaunched, your screen turns black?

Nope, it's just the sliders in the UI that default to 0.
I suggest defaulting them to a current setting, or to 50% (except for the volume).
But when I start dragging the brightness/contrast after the first launch (when they were at 0), the screen is naturally getting quite dark, close to 0.

It should not be doing that in the first place though, which display do you have? USB-C is most likely alt mode DP and CEC is not involved.

USB-C, Dell U3818DW.

MonitorControl should use the last known values for each display if it’s unable to read them from the display itself and then set slider values to those values, that’s the current solution, just not sure why it’s not working on your setup.
Could you perhaps run the app through Xcode and post the debug output?

I can try it.

@singalen What do your settings look like, btw (for MonitorControl)?

@singalen My best guess is that perhaps when reading your values through DDC, 0 is being returned instead of the actual values? This would also explain why the fallback to last known value isn't working.
You could try going to Settings > Advanced and setting Polling Mode to None. In that case it won't try to read your values and will use the last known values anyways.

This issue should be resolved by setting Polling Mode to None. Since there was no response for a long time, I'll close this issue for now, but feel free to comment if this is still a problem and we'll reopen the issue! Thank you!


Camera on port 82 instead of 80

Hi,
Is there a way I can configure this addon to support connecting to the camera on an other port than 80 (for http).
(for streaming standard ports are ok for me, for now at least - but I guess they could be configurable also).
/Magnus

At this moment integration connects to the camera on the default port. But for streaming, port numbers are read from your camera config (Network tab).

Please check v0.8. Should be fixed!


Some fonts show up with the bottom cut off

Is this because of the errors with freetype heights? Is there a way to fix this manually, such as specifying a custom offset of some sort? Here's an example of some text rendered which causes problems:

This is rendered with debug mode on. It seems like the bounding rect is above the full text?

NewTruetypeFontConfig now has a parameter that allows you to adjust the height.  If you add height, this will hopefully resolve itself.

That's very helpful - thank you!


Allow reading from a relay with filters

i would love to read the last 20 entries or so of profiles :-)
your work is amazing

See #55 and #57 now released in 1.3.0.


Feature/wjiang/optimized writing node

The way how to choose a processor to write data is changed. Previously, a writing processor is chosen as long as it is idle. That may lead to a situation that some nodes are crowded but some others are idle.  Now, an idle processor is chosen from a node with the most idle processors. This is the first step to optimize the o-server. The next step would be using memory size as a criteria to choose writers.
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[x] I have tested this change with a run of GEOSgcm (if non-trivial)
[x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[x] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang  Is there any danger here:
https://github.com/GEOS-ESM/MAPL/blob/feature/wjiang/optimized_writing_node/pfio/MultiGroupServer.F90#L486
since technically the "first" node has one less writer. I presume this works but it's getting late in the day. I'm trying to do something similar in my ESMF server prototype and was looking at your code when I saw this.


[PartEditor] Close PartGraphSelector

This will close PartGraphSelector when PartEditor is closed.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #641, from draft #647
As PartGraphSelector depends on PartEditor, PartGraphSelector is also closed when PartEditor is closed.


deprecated CRD api to v1 changes

Closing this as it is duplicate of https://github.com/IBM/ibm-monitoring-exporters-operator/pull/76


reqcheck: add comparison of test deps

Currently reqcheck is comparing only runtime dependencies:

usage: rdopkg reqcheck [-h]
inspect requirements.txt vs .spec Requires

As %check is enabled to run unit tests during  the build, we need tools to keep up with changing upstream test requirements. One tool would be comparing test-requirements.txt vs .spec BuildRequires
and the other one comparing pip freeze from actual venv where unit tests were executed (tox -epy27) vs rpm -qa python-* from rpm buildroot.
CLI-wise, both could be additional options for reqcheck but feel free to propose better UX:

usage: rdopkg reqcheck [-h] [ --test ]
inspect requirements.txt vs .spec Requires
With --test inspect test-requirements.txt vs .spec BuildRequires and also compare
Python packages in actual virtualenv vs Python RPMs in buildroot

About the path-to-venv, maybe rdopkg could itself try to generate it using pip install -r on a temporary directory?

@javierpena good idea, rdopkg could simulate both venv and buildroot!
That would simplify UX, I've updated proposed CLI in description accordingly.

Someone wanted to help with this so I created pseudo-review with general instructions on howto get this done:
https://review.rdoproject.org/r/#/c/5764/


add unit tests of scipy-based qualitative alpha and beta diversity metrics

Improvement Description
To confirm that feature tables are converted to presence/absence data before the metric is applied (sklearn handles this for a lot of methods, so we need tests to ensure that we know if that ever changes).
References
See https://github.com/qiime2/q2-diversity/issues/189 for more context.

I am going to close this because it doesn't seem to have traction. Please re-open if you disagree


Relationship mapping not working with manual mapper operation from JSON

Please see this Stackoverflow post (http://stackoverflow.com/questions/29354599/restkit-relationships-not-mapping-when-manually-mapping-json-object). I'm having trouble with a manual mapping where my entity object is created, but the relationships aren't created.

GitHub Issues is for reporting bugs in RestKit and discussing changes to RestKit itself. Please check the documentation, wiki, and existing issues before opening a new issue.
Additionally, please do not post general usage questions to Issues, but instead take them to Stack Overflow.


Add 'HttpRequest.get_full_path_info'

Hi, the first step toward proposing a new feature is to create a Trac ticket. Also, see our patch review checklist.

Thanks for pointing this out. I created a ticket and added a "versionadded" directive.


Update jms.rst

JMS is not a protocol. It is an API.

Of course it is.
But then, all the load test tools that came before Gatling have been using for ages the word "protocol" for the communication thingies that's they support for generating load against a remote application, for lack of a better word. As a consequence, so do we. Here, we mean "our component that let you generate load with JMS".

I see now. Thanks for the clarification!


broken imported roam lists - help!

There is some mystery problem with all the imported roam lists in my vault.
The (native) vertical indentation guides misalign slightly (see screenshot lines 6-7) but also Outliner doesn't work on them!
See test screenshot below and attached file - the blocks are identical (?) but the two block lists behave different—Outliner only works for the bottom one? What gives?
Can anyone help me? I'm baffled.

test (1).md
Things I have tried

disabled all theme and plugins (obviously).
turned (obsidian) indentation setting off and on again
find and replaced the “ -” spacing in the document to be exactly what obsidian itself produces

Forgot to attach the logs!
parseList Unable to parse list: expected indent "T", got "S"
What do T and S mean? I can't find anything on the interwebs.
obsidian.md-1661591696570.log

@fightme-cmd Thank you for the feedback.
Yes, it's not clear at all. "T" means tab, "S" means whitespace.
Your document contains a mix of tabs and whitespaces. The plugin can't handle that.
To fix the issue you can convert everything to a single format.

Solution: https://github.com/vslinko/obsidian-outliner/discussions/485#discussion-5691533


Cannot deobfuscate private fields

Hello! I try to deobfuscate a file that have private fields (hash char #):
here docs on mozilla
..............node_modules\shift-parser\dist\tokenizer.js:1536
        throw this.createILLEGAL();
        ^
Error: [1:6801]: Unexpected "#"
Console error:
  index: 6800,
  line: 1,
  column: 6801,
  parseErrorLine: 1,
  parseErrorColumn: 6801,
  description: 'Unexpected "#"'

I guess it's a problem related to shift-parser that not support those new spec.

Yeah it is, only option to fix that would be rewriting the repo using another parser lib which I don't have time to do currently sadly

I, too, was uninspired when choosing a parser for a more targeted deobfuscator. I went with esprima, which doesn't support a lot of newer language features as well. As a workaround I found that transpiling the code to a compatible version via babel before deobfuscation works well and removes the need of rewriting with another parser.


Convert and check timestamp

checks if incoming timestamp has a valid and realistic value
convert unix time to human readable timestamp
notify user if incoming JSON is correctly structured but has invalid values

No remarks for now - your TODO points are all valid (remove hard coded datastore name, make it configurable etc.). Feel free to merge.


Fix TODO for tour exercise

Closes #49. This pull request fix TODO for tour exercise putting a more clear message.

Merged in d826227a06928678e1615e9eae5a3fe847120065


Upgrade terraform-provider-aiven to v4.3.0

This PR was generated via $ upgrade-provider pulumi/pulumi-aiven.

Upgrading terraform-provider-aiven from 4.2.1  to 4.3.0.
Upgrading pulumi-terraform-bridge from v3.44.3 to v3.46.1.

Did not expect this many changes....

@aq17 something is off here
Do we know why tests are failing?
Can we trace the top Resource breaking changes to an upstream change?
Resource "aiven:index/serviceIntegrationEndpoint:ServiceIntegrationEndpoint" missing input "signalfxUserConfig"
Resource "aiven:index/serviceIntegrationEndpoint:ServiceIntegrationEndpoint" missing output "signalfxUserConfig"
Resource "aiven:index/kafka:Kafka" missing input "kafka"
Resource "aiven:index/kafka:Kafka" missing output "kafka"
Resource "aiven:index/kafka:Kafka" property "kafka" is no longer Required
Resource "aiven:index/flinkApplicationVersion:FlinkApplicationVersion" missing input "sink"
Resource "aiven:index/flinkApplicationVersion:FlinkApplicationVersion" missing input "source"
Resource "aiven:index/flinkApplicationVersion:FlinkApplicationVersion" missing output "source"
Resource "aiven:index/flinkApplicationVersion:FlinkApplicationVersion" missing output "sink"

@t0yv0 it does look like they significantly updated their docs for that resource serviceIntegrationEndpoint (changelog, docs
so maybe they aren't really breaking changes but our schema detects them as so


Error: could not get runtime: could not find a working conmon binary

I installed podman on Centos 7. I started integration tests and get an error.
[root@localhost libpod]# GOPATH=~/go ginkgo -v test/e2e/.
Failed to compile e2e:
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>invalid version: git fetch --unshallow -f https://github.com/docker/go-connections in /root/go/pkg/mod/cache/vcs/d4d85c75c05a73a49903227d5abc01a97e2af98bb40d3e0568d93c9e52de9e77: exit status 128:
fatal: git fetch-pack: expected shallow list
Ginkgo ran 1 suite in 46.801339442s
Test Suite Failed
[root@localhost libpod]# podman info --debug
Error: could not get runtime: could not find a working conmon binary (configured options: [/usr/libexec/podman/conmon /usr/local/libexec/podman/conmon /usr/local/lib/podman/conmon /usr/bin/conmon /usr/sbin/conmon /usr/local/bin/conmon /usr/local/sbin/conmon /run/current-system/sw/bin/conmon]): invalid argument
[root@localhost libpod]# podman --version
podman version 1.8.0-dev
How to fix it ?

how have you installed podman?
You also need to make sure conmon (https://github.com/containers/conmon/) is installed

I don't see this as an upstream issue.  Hopefully @Dmitriy-Chilikin has it working.  Might want to have conversation on email list at podman.io.  Or join us on IRC on #podman on freenode.


Implement 'wipe_after_delete' flag for a volume

@abenari: Did you have some time to have a look into this?

:+1: