cmd/link: go install -buildmode=shared -linkshared std doesn't work as expected

What version of Go are you using (go version)?

The problem appears in all versions after 1.9.1 including 1.9.1. All versions before 1.9.1 work as expected.

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go-src"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build001874867=/tmp/go-build"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
I run "go install -buildmode=shared -linkshared std" to generated a shared library for the std.
I have run the above on all recent go version from 1.6 to 1.11.
Since 1.9.1 the above doesn't work anymore and producses a warning.
As a result we cannot dynamically link our code to std library in any version more than 1.8.7.
What did you expect to see?
success without any warning.
What did you see instead?
/usr/bin/ld: warning: .init_array section has zero size

It is the one that comes with Centos 6.
GNU ld version <IP_ADDRESS>.2-5.48.el6 20100205
Copyright 2009 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.

Hmmm, that's an 8 year old linker.  This is just a warning, right?  The program still completes and works?


Rename the repo: test-infra -> infra

Renames a few things to new repo.
Adds an empty toolbox image to rebuild prow test when new changes happen to toolbox
shellchecked presubmit.sh
fixes prow test image to use toolbox

go: knative.dev/toolbox/kntest/cmd/kntest@latest (in knative.dev/toolbox/kntest@v0.0.0-20230406165419-0318b24a34cf):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.
The command '/bin/sh -c go install knative.dev/toolbox/kntest/cmd/kntest@latest' returned a non-zero code: 1

Known issue with kntest which we are trying to remove. @upodroid has a PR scheduled to address this next week.

/override "pull-knative-infra-prow-tests-image-build"


don't close bugs for intermittents if there are classifications for it in the current week (= no bugbot comment yet)

Example: https://bugzilla.mozilla.org/show_bug.cgi?id=1867054
There is a classification for this bug from July 17 but the bug got closed today (July 19) because the comment about the classification is done one a weekly schedule on Monday.

Given that I observe intermittent failure bugs for all the Remote Protocol components (Marionette, geckodriver, WebDriver BiDi, CDP) I notice this problem kinda often in our area.

@Archaeopteryx can we use Treeherder API in the bot to know? I guess it might be easy to fix if there's an easy to use API to go from bug # to number of classifications for a given week


no module named flask

after entering "python app.py", confirming that i am using python version 2.x
terminal shows:
"Traceback (most recent call last):
File "app.py", line 3, in
from flask import Flask, render_template, request, url_for, redirect, Markup, jsonify, make_response, send_from_directory, session
ImportError: No module named flask"
I can't edit the code. What should I do?

Hey,
You should try any of the following commands in the terminal
Pip install flask
Pip3 install flask
On Thu, Jul 22, 2021 at 5:26 AM ddcc3388 @.***> wrote:

after entering "python app.py", confirming that i am using python version
2.x
terminal shows:
"Traceback (most recent call last):
File "app.py", line 3, in
from flask import Flask, render_template, request, url_for, redirect,
Markup, jsonify, make_response, send_from_directory, session
ImportError: No module named flask"
I can't edit the code. What should I do?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/theriley106/SneakerBotTutorials/issues/24, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJ23WK2KSW2CQEHX5OXE6DTY7P4DANCNFSM5AZTVKMA
.

--
Aiden Owens
CEO of Afidgety
Email: @.***
Phone:330-221-6171

Thanks for the reply Aiden!
(im a noob at coding, so please correct me if im wrong)
Your advice did help but i needed to slightly adjust a little bit. In the youtube video, chris tells us to type: "pip install -r requirements.txt" in terminal, try testing "pip3 install -r requirements.txt"; this should work. Now if you have an issue with "python app.py" and you receive no module flask, try commanding: "python -m pip install flask" or "pip install flask". continue using the same format to install the other modules.
Side note, a question from me, after commanding: "python app.py"
terminal displays this:
[]
It looks like you didn't input any Proxies.
It is HIGHLY recommended that you use proxies.  Continue without? [Y/N]
is this response meant to be like this? is this the point where i am meant to buy proxies?

Yeah that’s the way to install the modules. With the proxies your are on
the right track. If you don’t want to buy proxies. Just type in “y”. As in
yes I want to continue.
On Sat, Jul 24, 2021 at 9:33 AM ddcc3388 @.***> wrote:

Thanks for the reply Aiden!
(im a noob at coding, so please correct me if im wrong)
Your advice did help but i needed to slightly adjust a little bit. In the
youtube video, chris tells us to type: "pip install -r requirements.txt" in
terminal, try testing "pip3 install -r requirements.txt"; this should work.
Now if you have an issue with "python app.py" and you receive no module
flask, try commanding: "python -m pip install flask" or "pip install
flask". continue using the same format to install the other modules.
Side note, a question from me, after commanding: "python app.py"
terminal displays this:
[]
It looks like you didn't input any Proxies.
It is HIGHLY recommended that you use proxies. Continue without? [Y/N]
is this response meant to be like this? is this the point where i am meant
to buy proxies?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/theriley106/SneakerBotTutorials/issues/24#issuecomment-886054388,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJ23WLKZPD4XCFQEB54JJDTZK6LVANCNFSM5AZTVKMA
.

--
Aiden Owens
CEO of Afidgety
Email: @.***
Phone:330-221-6171

Hey Aiden,
Thanks for your swift reply!
Was just wondering, when I added my own ip address into the command line, it didnt work and ended up like this:
$ python app.py <IP_ADDRESS>
[]
Successfully added <IP_ADDRESS>
Initiating Bot with Proxy: <IP_ADDRESS>
['<IP_ADDRESS>']

Serving Flask app "app" (lazy loading)
Environment: production
WARNING: This is a development server. Do not use it in a production deployment.
Use a production WSGI server instead.
Debug mode: off
Running on http://<IP_ADDRESS>:8000/ (Press CTRL+C to quit)
testing proxy: <IP_ADDRESS>
'str' object has no attribute 'get'
proxy: <IP_ADDRESS> failed
Done mass test

Do you know how I can fix this??
Thanks!

It is working,
All you do is go to the link on your webbrowser
Http://<IP_ADDRESS>:8000
On Sat, Jul 24, 2021 at 12:31 PM ddcc3388 @.***> wrote:

Hey Aiden,
Thanks for your swift reply!
Was just wondering, when I added my own ip address into the command line,
it didnt work and ended up like this:
$ python app.py <IP_ADDRESS>
[]
Successfully added <IP_ADDRESS>
Initiating Bot with Proxy: <IP_ADDRESS>
['<IP_ADDRESS>']

Serving Flask app "app" (lazy loading)
Environment: production
WARNING: This is a development server. Do not use it in a production
deployment.
Use a production WSGI server instead.
Debug mode: off
Running on http://<IP_ADDRESS>:8000/ (Press CTRL+C to quit)
testing proxy: <IP_ADDRESS>
'str' object has no attribute 'get'
proxy: <IP_ADDRESS> failed
Done mass test

Do you know how I can fix this??
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/theriley106/SneakerBotTutorials/issues/24#issuecomment-886076686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJJ23WP3EGWUKPW4QR7J4RLTZLTGRANCNFSM5AZTVKMA
.

--
Aiden Owens
CEO of Afidgety
Email: @.***
Phone:330-221-6171


ahmedyassen017.md

i still don't know what i am doing
I might understand a little

what was that

what should i do now


Incorrect text cursor position in TextBox during text input.

Describe the bug
Incorrect text cursor position in TextBox during text input.
To Reproduce
Steps to reproduce the behavior:
Select "First1" from a ComboBox.
Enter some text at the end of the "First1" string in the TextBox.
Switch the ComboBox to "First2".
Enter text at the end of the "First2" string in the TextBox.
Observe that upon the first key press, the text cursor takes an incorrect position.
Expected behavior
The text cursor should maintain the correct position relative to the text input, regardless of ComboBox selection changes.
Screenshots
https://github.com/AvaloniaUI/Avalonia/assets/19895415/849b4772-43fd-4cc2-a444-f1d86c869b02
Environment
OS: [Windows 10, Linux]
Avalonia-Version: [11.0.6 and 11.1.999-cibuild0042781-beta]
Additional context
This issue seems to be related to how the TextBox handles cursor positioning in conjunction with dynamic content changes, possibly linked to the ComboBox selection logic.
The example is here: https://github.com/Jackhammer88/AvaloniaTextBoxTest

Related? #13648

Related? #13648

I'm not sure. It doesn't seem to be related.

In Avalonia 11.0.7, the issue does not appear to be present

In Avalonia 11.0.7, the issue does not appear to be present

It appears in 11.0.7 too. I've just tested it.

It's still actual in 11.0.10.
This code doesn't seem buggy... Why does carret position sets to seventh index in the described scenario, but actually it looks like sixth?
And the most important fact that you don't need to manipulate moreover than in the video. Just edit first textbox, select second item in the combobox, add a char to the first textbox and caret position will look incorrect.
public class MainWindowViewModel : ReactiveObject
{
    public MainWindowViewModel()
    {
        var command = ReactiveCommand.Create(() =>
        {
            Counter++;
        });

        var obs2 = this.WhenAnyValue(vm => vm.SelectedItem)
            .Where(i => i != null)
            .Select(item =>
            {
                return Observable.Merge(
                    item.WhenAnyValue(i => i.FirstName),
                    item.WhenAnyValue(i => i.LastName)
                    );
            })
            .Switch()
            .Select((_, _) => Unit.Default)
            .Throttle(TimeSpan.FromMilliseconds(200))
            .InvokeCommand(command);

        Items = new List<Item>
        {
            new Item { FirstName = "First1", LastName = "Last1" },
            new Item { FirstName = "First2", LastName = "Last2" },
            new Item { FirstName = "First3", LastName = "Last3" },
        };

        SelectedItem = Items.FirstOrDefault();
    }

    private int _counter = 0;
    public int Counter
    {
        get => _counter;
        set => this.RaiseAndSetIfChanged(ref _counter, value);
    }

    public List<Item> Items { get; }

    private Item? _selectedItem;
    public Item? SelectedItem
    {
        get => _selectedItem;
        set => this.RaiseAndSetIfChanged(ref _selectedItem, value);
    }
}

public class Item : ReactiveObject
{
    private string _firstName = "";
    public string FirstName
    {
        get => _firstName;
        set => this.RaiseAndSetIfChanged(ref _firstName, value);
    }

    private string _lastName = "";
    public string LastName
    {
        get => _lastName;
        set => this.RaiseAndSetIfChanged(ref _lastName, value);
    }
}


Add tests for packet_alert_max - v3

Previous PR: https://github.com/OISF/suricata-verify/pull/694
Changes:

Add invalid config value (0) for PACKET_ALERT_MAX in suricata.yaml to test that it will fallback to defaults.

Related to https://redmine.openinfosecfoundation.org/issues/4207
and https://redmine.openinfosecfoundation.org/issues/4942
Also reworded (and changed!!) first commit a bit, (sorry, that shouldn't have been done, right).
Goes with Suricata PR https://github.com/OISF/suricata/pull/7000

Related work still needed: test to ensure alert order doesn't change. (but the S-V tests in this PR work on its on)


feat: pythonw support on gui scripts

Summary
Closes https://github.com/astral-sh/uv/issues/2956
This changes the bootstrap launcher script to use pythonw.exe instead of python.exe on gui_scripts via a helper fn both in the shebang and the python exe path encoded before UVUV magic, that way uv-trampoline's find_python_exe can use the right pythonw executable.
Test Plan
New unit tests for the helper was added.
Tested on example from #2956 on Windows to make sure it works as expected.
Questions
I noticed the docs in fn windows_script_launcher says The launcher will look for `python[w].exe` adjacent to it in the same directory to start the embedded script. but I didn't find such functionality when I looked in uv-trampoline.
I only saw clear_app_starting_state getting called when is_gui is set.
Was the intention to do this in uv-trampoline at some point instead?

I noticed the docs in fn windows_script_launcher says The launcher will look for python[w].exe adjacent to it in the same directory to start the embedded script. but I didn't find such functionality when I looked in uv-trampoline.

Thanks, that's indeed wrong, i removed it.

Nice, thank you for this @samypr100!


PortMaster: Heart of Darkness shooting instead of moving when analog stick maxed to the right

Describe the Issue (If applicable)
Hi, when trying to move to the right with the analog stick, the character starts shooting instead of moving.
This happens only when analog stick is sending larger value, like 0.8+
Does not happen when trying to move to the left, with input 1.0 even, everything works as expected.
How can the issue be reproduced? (If applicable)

Few days old fresh installation of clean ArkOS on OGA 1.1
Updated both the OS and PortMaster
Installed Heart of Darkness through PortMaster
Copied all required game files to the gamedata folder (*.lvl, *.mst, *.sss etc.)
Restarted EmulationStation
Started the game
Pressed New Game
No cinematics are played (weird, but I can live with that)
Jump out of the broken ship which then explodes
Try moving right "at max speed", using analog stick
Observe the issue, characters shoots instead of moving
Try moving slowly to the right, or use d-pad to move right, character moves as intended

What device are you using?
OGA 1.1
What version of ArkOS are you on?

2.0 (09052022)

Anything else you'd like to include that may help to review this issue or feature request?

The Heart of Darkness port package has been updated that should resolve this for you.  Just reinstall it through PortMaster.  Thank you for reporting this issue.


Added the code for Converting decimal number to binary in C++ Problem

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
yes
Description
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#2612

@SrishtiArya07 Update the readme file.

I've already updated the readme file 11d24c26e8bc9beaf0aa03a77b33569ec2e990a0

@all-contributors bot please add @SrishtiArya07 for code


If there is only 1 module, automatically assign it to a cohort upon creation

#1733  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


Changes in the Footer

Instead of having a Resources section that is not even related to the website we can add a Who We Are Section:
Who We Are-
About us
Contact us
Blog
FAQ's

please assign this issue to me


Recognisiton using cnn

closes #8

@akshitagupta15june  Plzz review it ,I had made the changes

great work @Halix267 can you tell me the process of running this cnn pr
like which code should i run in which order to check your results.

So that i can have a look at your output

and @Halix267 can you also create a readme file like what steps you have performed and what output you have got.
So that if anyone will have a look at this they will get to know whole process as well as output.

u can jst cpy the cde in your vsc or colab and create the dataset

the  just train the model  and whn the training complete  a file name final_model.py create on yr the folder where the the images save than run displaying resut.py

So basically the order is Create dataset.py , Training the model, Displaying results

And one mre thing bfre traing the model  Split the dataset into train and test set , Basically I am saying that u should split the images into to folders Train and Test than u go for training

Can you send me working of this feature like any screenshots or something

ok

This is the output @akshitagupta15june . Is this is fine

It is perfect 👍

So any changes needed?

and how much points do i get for this issue :)

You will get 15+5 =20 points

Can I work on other face recognition models also??

@Halix267 I am merging this pull request.
It will be great if you also add a readme in this like the process you did while training and testing using CNN as this will be informative for fellow students.

I have merged your pr and updated your points.

Can I work on other face recognition models also??

Yes ofcourse you can work

@akshitagupta15june but it is not shown in leaderboard. How much points u gave me?

your points were 5 and i incremented it to 25

no that not my points @akshitagupta15june  look above in leaderboard I have 40 points

I hope u got it

there is problem in lederboard , The leaderboard showing my  previous points also @akshitagupta15june . Plzz update the points where I have 40 points in leaderboard

In leadeboard i can see 5 pints only.
I only have rights to update your points which are in this projects.
For that increment you have to contact other project admins to update.

See @akshitagupta15june

ok @Halix267 i am updating it 65 means 40+25.

@Halix267 can u check is it updated to 60?

wait

or i have updated it in the sheet maybe it will take time.

Yes I think so bcz it is not shown yet

i have checked just now its updated to 60.
Good work @Halix267

Also I have told raised this issue in nwoc gitter channel also . May be they do something about my name showing twice in leaderborad bcz it confuses the mentors

yes your name is twice

All thanks to you @akshitagupta15june :)

Its your efforts!!


Added docs and longer test for vault-k8s image.

Test looks good - here's run from my fork: https://github.com/amouat/images/actions/runs/5178074495/jobs/9329061729


Add examples with other frameworks

This was brought up on the google group. It would be really good to have working examples of using dex with other authorization frameworks. At the very least, it's good to make sure dex works with other OpenID Connect client implementations.
Suggested frameworks:

[ ] Node.js passport-openidconnect
[ ] Python django-oidc-provider

I was able to get a node express app + passport-openidconnect working with Dex by modifying the passport module slightly in my client app.
I captured the request from the passport-openidconnect and the go client app and they look slightly different. I believe Dex expects authorization header (encoded clientid and secret) as part of the request to the "/token" endpoint:

The passport request wasn't including the authorization header as part of the request.

Interesting. This may be a bug on our end. Do you know how the credentials are begin sent by passport-openidconnect?

Passport-openidconnect sample Req:
https://gist.github.com/davidyum/d73609dc7125cc23a6f8
Go Client sample Req:
https://gist.github.com/davidyum/693cbf70b53dc2ec1122

Sorry what is this a dump of? The dex logs?
(EXTRA *http.Request=&{POST /token HTTP/1.1 1 1 map[User-Agent:[Node-oauth] Content-Length:[286]
Connection:[close] Content-Type:[application/x-www-form-urlencoded]] 0xc820523b80 286 [] true localhost:5556
map[grant_type:[authorization_code] redirect_uri:[http://<IP_ADDRESS>:3000/callback]<EMAIL_ADDRESS>client_secret:[hUdVk1Pz-A97FcfQ9W6OopfFWOgmU2lMfCcjV3Mi6GUvjZPXB5CzxsgYYbokFyCysrDi3KfmT4jQWkqePbaSAdE0PXmdCmF- ] code:[ARAbQ3dc4Fw=]] <nil> map[] <IP_ADDRESS>:59367 /token <nil> <nil>})

It looks like the auth might be in the body from Content-Type: application/x-www-form-urlencoded

Yes, I placed logs in dex to capture the two requests.
It seems like Dex is decoding the Authorization header from the request and setting the username as the client id and setting the password as the client secret.
This is in the server/http.go file handleTokenFunc() .

It looks like the oauth2 does allow you to pass creds via the request body.

Alternatively, the authorization server MAY support including the
client credentials in the request-body using the following
parameters:

client_id
REQUIRED.  The client identifier issued to the client during
the registration process described by Section 2.2.

client_secret
REQUIRED.  The client secret.  The client MAY omit the
parameter if the client secret is an empty string.

Including the client credentials in the request-body using the two
parameters is NOT RECOMMENDED and SHOULD be limited to clients unable
to directly utilize the HTTP Basic authentication scheme (or other
password-based HTTP authentication schemes).  The parameters can only
be transmitted in the request-body and MUST NOT be included in the
request URI.

https://tools.ietf.org/html/rfc6749#section-2.3 (emphasis my own)

Yeah, the oauth package that the passport-openidconnect does this https://github.com/ciaranj/node-oauth/blob/ec6a1b2eafd2206f248d83e5ddccf911f68cb3fe/lib/oauth2.js#L164-L176

Thanks for looking into it Eric. It seems like an open issue for the node-oauth package:
https://github.com/ciaranj/node-oauth/issues/175
Adding the line below to the node-oauth oauth2.js line 155-159 fixed the issue:
  var post_data= querystring.stringify( params );
  var post_headers= {
       'Content-Type': 'application/x-www-form-urlencoded',
       'Authorization': 'Basic ' + new Buffer(this._clientId + ':' + this._clientSecret).toString('base64')
   };

Maybe dependent on https://github.com/coreos/dex/issues/376?


🎉 Initial forking action implementation

Adds

Initial implementation of forker action - see README.md for details on how it works!

Checklist

[x] Get Actions CI passing (build + test)
[x] Integration test with local Github repository
[x] Integration test with external Github repository
[x] Add Jest test for required action inputs
[x] Finish updating README

Other TODOs from discussion with @draco2003:

[ ] Consider only running the npm build job (which uses an API token) upon PR approval
[ ] Investigate whether the builtin GITHUB_TOKEN can be used in place of GH_API_TOKEN

Other TODOs from discussion with @draco2003:

[ ]  Consider only running the npm build job (which uses an API token) upon PR approval
[ ]  Investigate whether the builtin GITHUB_TOKEN can be used in place of GH_API_TOKEN

Relevant reading:

https://github.community/t/github-actions-manual-trigger-approvals/16233/64
https://docs.github.com/en/actions/reference/authentication-in-a-workflow#using-the-github_token-in-a-workflow

Other TODOs from discussion with @draco2003:

[x]  Consider only running the npm build job (which uses an API token) upon PR approval
[x]  Investigate whether the builtin GITHUB_TOKEN can be used in place of GH_API_TOKEN

Updates:

Tested out the run-job-upon-PR-approval workflow in a separate repository with a dummy PR, I can't self-approve a PR there, but I was able to confirm that only the job which does not use a github.event.review.state conditional runs prior to approval.
Confirmed the builtin GITHUB_TOKEN does not appear to have sufficient permissions for forking (I believe this is due to a blanket read-only policy for anything pertaining to repo forks), so will be reverting to the original GH_API_TOKEN and updating the README to provide clarity on the use of GITHUB_TOKEN.

Good news is, forker behaved correctly and exited with a useful error message about insufficient permissions!

Upon further thought, it turns out the Jest test which runs during the build step does not actually need the GH_API_TOKEN since it's only testing action inputs, and is not meant to be a functional test. So, this is a rare occasion where the builtin GITHUB_TOKEN is actually valid for use, and feels a little safer to potentially 'expose' since these tokens are only generated as-needed and expire immediately after the job runs, if my understanding is correct.
The downside to keeping the github.event.review.state == 'approved' conditional in place is that users will not receive any continuous feedback on the node+typescript lint/build/package process unless they run all the steps locally. This could potentially set us up to approve PRs that actually break the build once the npm steps are allowed to run. 😅
Given the significant downsides, and lower-than-previously-thought upsides, I'm wondering if we compromise here by using the safer GITHUB_TOKEN during the npm steps, and run it unconditionally against PRs as before.

Other TODOs from discussion with @draco2003:

[ ]   Consider only running the npm build job (which uses an API token) upon PR approval
[ ]   Investigate whether the builtin GITHUB_TOKEN can be used in place of GH_API_TOKEN

Relevant reading:

https://github.community/t/github-actions-manual-trigger-approvals/16233/64
https://docs.github.com/en/actions/reference/authentication-in-a-workflow#using-the-github_token-in-a-workflow

Other TODOs from discussion with @draco2003:

[x]   Consider only running the npm build job (which uses an API token) upon PR approval
[x]   Investigate whether the builtin GITHUB_TOKEN can be used in place of GH_API_TOKEN

Updates:

Tested out the run-job-upon-PR-approval workflow in a separate repository with a dummy PR, I can't self-approve a PR there, but I was able to confirm that only the job which does not use a github.event.review.state conditional runs prior to approval.
Confirmed the builtin GITHUB_TOKEN does not appear to have sufficient permissions for forking (I believe this is due to a blanket read-only policy for anything pertaining to repo forks), so will be reverting to the original GH_API_TOKEN and updating the README to provide clarity on the use of GITHUB_TOKEN.

Good news is, forker behaved correctly and exited with a useful error message about insufficient permissions!

Upon further thought, it turns out the Jest test which runs during the build step does not actually need the GH_API_TOKEN since it's only testing action inputs, and is not meant to be a functional test. So, this is a rare occasion where the builtin GITHUB_TOKEN is actually valid for use, and feels a little safer to potentially 'expose' since these tokens are only generated as-needed and expire immediately after the job runs, if my understanding is correct.
The downside to keeping the github.event.review.state == 'approved' conditional in place is that users will not receive any continuous feedback on the node+typescript lint/build/package process unless they run all the steps locally. This could potentially set us up to approve PRs that actually break the build once the npm steps are allowed to run. 😅
Given the significant downsides, and lower-than-previously-thought upsides, I'm wondering if we compromise here by using the safer GITHUB_TOKEN during the npm steps, and run it unconditionally against PRs as before.

I think the GITHUB_TOKEN usage for this makes sense and the remove of the approval conditional for now.
Was under the impression that approval conditionals didn't prevent other steps from running but something we can investigate more when we actually need it.


DECO-127 AWS connection

PLEASE CHECK WHAT IS LEFT AFTER DECO-88/DECO-90 is merged. It is probably nothing.

I see there are no changes anymore.


[Bug] keyword beginning with @ does not work anymore

Expected behavior
replace keyword with snippet
Actual behavior
do nothing
Steps to reproduce the behavior
create a new combo with any keyword beginning with a "@"
add snippet
try it
eg. keyword " @g ", snippet " @gmail.com "
replace the "@" with a dot for example, and it works.
it was working in 11.1 (just tested)
Beeftext version (e.g. Beeftext v7.0 Portable Edition).
Beeftext v12.0
Operating system version (e.g Windows 10)
Windows 10

Hi.
The issue is known and has already been fixed. The fix will be included in v13.0, due soon. Tests builds can be found in the comments of issue #443

Hi,
I had searched for an existing topic, but didn't do it well.
Sorry.
Le jeu. 13 janv. 2022 à 19:56, Xavier Michelon @.***> a
écrit :

Hi.
The issue is known and has already been fixed. The fix will be included in
v13.0, due soon. Tests builds can be found in the comments of issue #443
https://github.com/xmichelo/Beeftext/issues/443
—
Reply to this email directly, view it on GitHub
https://github.com/xmichelo/Beeftext/issues/460#issuecomment-1012418616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO3GRAUTWQG22AEGCWSSFJLUV4N7JANCNFSM5L3N5VNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Adding release-note for 0.13.2

Signed-off-by: Maayan Friedman<EMAIL_ADDRESS>

@dfarrell07 once this PR is merged, let's announce the release :)


Added missing rules for upgrade to<EMAIL_ADDRESS>

Added missing rules for upgrade to<EMAIL_ADDRESS>Thanks for catching them @VelinGeorgiev!

Coverage remained the same at 100.0% when pulling 95704f5a47df38050958fa10269263c4dcdb06c2 on waldekmastykarz:fix-upgrade-150 into 2f239328e5447bd180cde9f236210255b45a7ebe on SharePoint:dev.


Evolving conditions and initial conditions are not correctly synchronized

The attached configuration has initial conditions for time 0 in the evolving conditions. They seem to be ignored.
config 2.zip
#Acceptance criteria

A simple test configuration containing both evolving and initial conditions are created

Initial conditions should valid
Evolving conditions should set something at time 0 as well as something in between chemistry time steps

The initial values from the initial conditions are overwritten by the evolving conditions

#Ideas

Modify the attached configuration. Make it run for only a few time steps, but enough to test the above conditions

#222 may be related to this issue


Saving Multiple Runs to Tracker

Iteration vs Error: runs can be as averages or with all runs separately
Runtime vs Error: individual runs can be plotted

may consider interpolating values and plotting that, but it may lead to "spikyness", particularly due to differences in initialization speed

bumping this to get merged


'TXLED1' was not declared in this scope

Does this need to be defined up above with the reset of the defines?
Or does something need to be imported?
Full error message:
Arduino: 1.6.9 (Mac OS X), Board: "Arduino/Genuino Uno"
WARNING: Category '' in library UIPEthernet is not valid. Setting to 'Uncategorized'
/Users/teewuane/Projects/rccar/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter.ino: In function 'void setup()':
/Users/teewuane/Projects/rccar/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter.ino:143:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
flash_led(5, 100, 500);
^
/Users/teewuane/Projects/rccar/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter.ino: In function 'void loop()':
rc_car_throttle_limiter:205: error: 'TXLED1' was not declared in this scope
TXLED1;
^
rc_car_throttle_limiter:207: error: 'TXLED0' was not declared in this scope
TXLED0;
^
rc_car_throttle_limiter:218: error: 'TXLED1' was not declared in this scope
TXLED1;
^
rc_car_throttle_limiter:247: error: 'TXLED1' was not declared in this scope
TXLED1;
^
rc_car_throttle_limiter:266: error: 'TXLED1' was not declared in this scope
TXLED1;
^
/Users/teewuane/Projects/rccar/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter.ino:271:34: warning: large integer implicitly truncated to unsigned type [-Woverflow]
flash_led(5, 100, 500);
^
rc_car_throttle_limiter:287: error: 'TXLED0' was not declared in this scope
TXLED0;
^
rc_car_throttle_limiter:291: error: 'TXLED1' was not declared in this scope
TXLED1;
^
/Users/teewuane/Projects/rccar/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter/rc_car_throttle_limiter.ino: In function 'void flash_led(uint8_t, uint8_t, uint8_t)':
rc_car_throttle_limiter:404: error: 'TXLED1' was not declared in this scope
TXLED1;
^
rc_car_throttle_limiter:406: error: 'TXLED0' was not declared in this scope
TXLED0;
^
exit status 1
'TXLED1' was not declared in this scope
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I just created some functions called TXLED1 and TXLED0 which tell the LED on pin 13 to turn on and off. Next step is to make the braking feature optional since one of my ESCs does not have braking. It just goes straight to reverse.

TXLED1 and TXLED0 are defines available on some Arduino boards, such as the Micro.
I forked the original sources and added support in the same way for Nano bards.
On Nano board the inbuilt led on pin 13 is used correspondingly, see:
https://github.com/Trickx/rc_car_throttle_limiter/commit/5dfeef85319b328d016355a7e824159b68890dd4
Additionally, I pull request was originated.


Elk ILP Support

Elk pools pay ILP (impermanent loss protection) on withdraw. New strategy to reinvest should claim any pending ILP. We should consider an additional reinvest in the withdraw flow. The goal is to pay YY depositors their "fair share" of the ILP.

I created this PR  for this issue . Feedback welcome : )


'next' acts like 'continue' with mechanize

I've had this issue for a while, and I just live with it by making sure to stop before each mechanize call and put a breakpoint right after it. As you can imagine, it's quite painful.
This shows the problem.:
require 'mechanize'
agent = Mechanize.new
agent.get 'http://www.google.com'
puts "When I tell byebug 'next' from the line above, I expect to stop before executing this line, but it does not."
puts "If fact it doesn't stop here either. It acts as though I asked to 'continue'. Whatddup?"

Hi @timscott, I've further isolated this to
require 'domain_name'
domain = DomainName.new('google.com')

puts "When I tell byebug 'next' from the line above, I expect to stop before executing this line, but it does not."
It seems like a bug in the TracePoint API, so I've reported to ruby-core: https://bugs.ruby-lang.org/issues/10724

Hi again @timscott, I've found a minimal program to reproduce your issue.
class A
  def initialize
    loop { return }
  end
end

A.new
puts "'next' should stop here, but it doesn't...."

Hopefully it'll be fixed soon! :)

Fixed in ruby-core! :smile:

This has been backported to Ruby 2.2 and Ruby 2.1, but won't be fixed for 2.0.
After 2.1.7 and 2.2.3 are released, I´ll start recommending those versions in the README and close this issue.

Here you go, closing!


make mongoserver not working

within ubuntu 64bit , on the latest build 6.8, tried "make mongoserver" but it is not building, giving error relating to curl. I have installed curl using standard linux libraries though.
even other "make" commands for linux are not working.

problem was the libmongoc repository installed on the server. But then used a stable release and it worked. Also for DBinsert the command is "mongoinsertdocument" instead of "mongoinsert" and so on.
But we have a db connection and its working.


grunt-contrib-compress throws 'No “compress” targets found' and does nothing

Originally posted on SO (http://stackoverflow.com/questions/36561902/grunt-contrib-compress-throws-no-compress-targets-found-and-does-nothing) but after a week of very low views and no answers I'm posting it here in the hope that maybe it's a bug.
When the compress task is called the output is consistently the following error message:

$ grunt squeeze >> No "compress" targets found. Warning: Task "compress" failed. Use --force to continue.
Aborted due to warnings. Process finished with exit code 3

Config info:
compress:{
    main:{
        options:{
            mode:'gzip',
            level:2
        },
        files:[
            {expand:true, cwd:'E:/s3/', src:['**'], dest:'E:/gz/s3/'}
        ]
    }
}

Grunt task:
grunt.registerTask('squeeze', ['compress']);
All folders are known to be present (they are able to be used by a different task just fine.) I've tried the path with both frontslash and backslash, but I get the same result. This is running on W10, Node 4.x, and current version of Grunt and grunt-contrib-compress (1.2.0).

Did you forget to load the task inside Gruntfile ?
I mean adding this line to your Gruntfile as shown in README:
grunt.loadNpmTasks('grunt-contrib-compress');

No, it's there. I'll admit that I did have to look at the project to make sure, but yes, it's there. That line is after the grunt.initConfig section, but I've never had troubles with that placement for other modules.

I can't reproduce your issue on win7 and Linux. Maybe you have done something wrong or something goes wrong during npm install.
Can you show us the content of your Gruntfile.js ?

The system in question is W10, upgraded from W7 Pro, which was upgraded from XP Pro. I'm not sure how I could do something wrong by typing

npm install grunt-contrib-compress

but I've managed to screw up simple things before so it's always best to check things. Therefore, and just to be thorough, I uninstalled and re-installed the module and still get the same results. The uninstall and install both ran fine, no errors or warnings. My Gruntfile.js is as follows:
'use strict';
module.exports = function (grunt) {
// Load grunt tasks automatically
var log = 'C:/Users/Michael/Desktop/BackupLog.txt';
require('load-grunt-tasks')(grunt);
require('logfile-grunt')(grunt, { filePath: log});
// Define the configuration for all the tasks
grunt.initConfig({
    aws: grunt.file.readJSON('grunt-aws.json'),
    aws_s3:{
        options: {
            debug:false,
            region:'us-west-1',
            access:'bucket-owner-full-control',
            overwrite:true,
            displayChangesOnly:true,
            maxRetries:3,
            httpOptions:{
                timeout:12000000
            },
            uploadConcurrency: 5, // 5 simultaneous uploads
            downloadConcurrency: 5, // 5 simultaneous downloads
            differential: true, // Only uploads the files that have changed
            gzipRename: 'swap' // when uploading a gz file, swap the original extension with the .gz extension
        },
        backup:{
            options: {
                accessKeyId: '<%= aws.backup.key %>',
                secretAccessKey: '<%= aws.backup.secret %>',
                bucket: '<%= aws.backup.bucket %>'
            },
            files: [
                {'action':'upload', expand:true, cwd:'E:/s3/', src:['**'], dest:'s3/'},
                {'action':'upload', expand:true, cwd:'E:/quest/', src:['**'], dest:'quest/'},
                {'action':'upload', expand:true, cwd:'E:/Backups/', src:['**'], dest:'Backups/', stream:true},
                {'action':'upload', expand:true, cwd:'E:/Data/2g memory card/', src:['**'], dest:'Data/2g memory card/'},
                {'action':'upload', expand:true, cwd:'E:/Data/2gig drive/', src:['**'], dest:'Data/2gig drive/'},
                {'action':'upload', expand:true, cwd:'E:/Data/ARTracker/', src:['**'], dest:'Data/ARTracker/'},
                {'action':'upload', expand:true, cwd:'E:/Data/2g memory card/', src:['**'], dest:'Data/2g memory card/'},
                {'action':'upload', expand:true, cwd:'E:/Data/books/', src:['**'], dest:'Data/books/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Butch/', src:['**'], dest:'Data/Butch/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Calibre Books/', src:['**'], dest:'Data/Calibre Books/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Camera Videos/', src:['**'], dest:'Data/Camera Videos/'},
                {'action':'upload', expand:true, cwd:'E:/Data/CD/', src:['**'], dest:'Data/CD/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Documents/', src:['**'], dest:'Data/Documents/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Facebook Picts/', src:['**'], dest:'Data/Facebook Picts/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Fonts/', src:['**'], dest:'Data/Fonts/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Food Things/', src:['**'], dest:'Data/Food Things/'},
                {'action':'upload', expand:true, cwd:'E:/Data/From Laptop/', src:['**'], dest:'Data/From Laptop/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Kelley/', src:['**'], dest:'Data/Kelley/'},
                {'action':'upload', expand:true, cwd:'E:/Data/minecon/', src:['**'], dest:'Data/minecon/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Music/', src:['**'], dest:'Data/Music/'},
                {'action':'upload', expand:true, cwd:'E:/Data/My Music/', src:['**'], dest:'Data/My Music/'},
                {'action':'upload', expand:true, cwd:'E:/Data/NoInk/', src:['**'], dest:'Data/NoInk/'},
                {'action':'upload', expand:true, cwd:'E:/Data/old drive/', src:['**'], dest:'Data/old drive/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Paystubs/', src:['**'], dest:'Data/Paystubs/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Pictures/', src:['**'], dest:'Data/Pictures/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Software/', src:['**'], dest:'Data/Software/'},
                {'action':'upload', expand:true, cwd:'E:/Data/Web Projects/', src:['**'], dest:'Data/Web Projects/'},
                {'action':'upload', expand:true, cwd:'E:/Data/work/', src:['**'], dest:'Data/work/'}
            ]
        },
        restore:{
            options: {
                accessKeyId: '<%= aws.restore.key %>',
                secretAccessKey: '<%= aws.restore.secret %>',
                bucket: '<%= aws.restore.bucket %>'
            },
            files:[
                {cwd:'E:/quest/', dest:'quest/', action:'download'}
            ]
        },
        compress:{
            main:{
                options:{
                    mode:'gzip',
                    level:2
                },
                files:[
                    {expand:true, cwd:'E:/s3/', src:['**/*'], dest:'E:/gz/s3/'}
                ]
            }
        }
    },
    open:{
        log:{
            path:log
        }
    }
});

grunt.loadNpmTasks('grunt-aws-s3');
grunt.loadNpmTasks('grunt-open');
grunt.loadNpmTasks('grunt-contrib-compress');

grunt.registerTask('default', ['aws_s3:backup','open:log']);
grunt.registerTask('restore', ['aws_s3:restore']);
grunt.registerTask('squeeze', ['compress']);

};
Also, in case it helps, my package.json contains:
{
"name": "backup",
"version": "0.0.0",
"dependencies": {},
"devDependencies": {
"grunt": "~0.4.1",
"grunt-aws-s3":"~0.14",
"grunt-contrib-compress":"~1.2",
"load-grunt-tasks":"~3.4",
"logfile-grunt":"~0.2",
"grunt-open":"~0.2"
},
"engines": {
"node": ">=0.8.0"
}
}
Thanks very much for looking into this.

Why is compress under aws_s3? double check that

BINGO!
(Insert bad words here)
Like I said, I've managed to screw up simple things before. Much thanks vladikoff. Please close this issue.


Should .vscode/.ropeproject be committed to vcs?

Environment data
VS Code version: 1.18.1
Python Extension version:  Python 3.6.3 | packaged by conda-forge | (default, Oct  5 2017, 19:18:17)
Python Version:
OS and version: macOS 10.12.6
Unclear to me whether the .vscode/.ropeproject directory and its contents should be committed to version control ...?

No it isn't necessary.

Is it possible/desirable for this directory to live somewhere else?
The .vscode directory in my experience appears to generally be designed in a way that allows it to be committed in whole cloth to version control and have good/sane behavior — this as contrasted against the configuration directories for many other ide’s.
If sane vcs behavior by default for .vscode directory is a design goal of vscode — then I wonder if this location is appropriate place for the .ropeproject/ directory ...?
For now I’ve added .vscode/.ropeproject to gitignore — but I’m hoping a long list of .vscode related rules doesn’t become the norm for vscode over time ...

@breathe agreed.

What can we do about this? It's mildly annoying. I am a total newbie to python but already familiar with vscode.
Where should the folder live?

We're not planning to address this issue as we're planning to move away from rope at some point.


BUILD: add initial release notes

Should we do it in reverse chronological order?

Good point. Will do.


Objects not discovered as dependent, but parent-object discovered as dependency

Hey @tohjustin :wave: :)
I think I've experienced a bug and hope this report helps improving your wonderful tool.
Please let me know if you want more info or something else!
Story time
I've installed package-operator which brings its own CRDs which are strictly organized in a hierarchy.
After installation of the operator [1], there is a tree of objects, glued together by ownerReferences that looks like this:
ClusterPackage/package-operator
-> ClusterObjectDeployment/package-operator
  -> ClusterObjectSet/package-operator-$hash
    -> Actual kubernetes objects

But some object relations are missing from kubectl-lineage's output. This is the output for kubectl lineage clusterpackage package-operator:
NAME                                                                                READY   STATUS   AGE
ClusterPackage/package-operator                                                      -                3m35s
└── ClusterObjectDeployment/package-operator                                         -                3m34s
    └── ClusterObjectSet/package-operator-56496479f6                                 -                3m33s
        ├── ClusterRole/package-operator-remote-phase-manager                        -                3m17s
        ├── ClusterRoleBinding/package-operator                                      -                3m44s
        ├── CustomResourceDefinition/clusterobjectdeployments.package-operator.run   -                3m37s
        ├── CustomResourceDefinition/clusterobjectsetphases.package-operator.run     -                3m37s
        ├── CustomResourceDefinition/clusterobjectsets.package-operator.run          -                3m37s
        ├── CustomResourceDefinition/clusterobjectslice.package-operator.run         -                3m37s
        ├── CustomResourceDefinition/clusterobjecttemplates.package-operator.run     -                3m37s
        ├── CustomResourceDefinition/clusterpackages.package-operator.run            -                3m37s
        ├── CustomResourceDefinition/objectdeployments.package-operator.run          -                3m37s
        ├── CustomResourceDefinition/objectsetphases.package-operator.run            -                3m37s
        ├── CustomResourceDefinition/objectsets.package-operator.run                 -                3m37s
        ├── CustomResourceDefinition/objectslice.package-operator.run                -                3m37s
        ├── CustomResourceDefinition/objecttemplates.package-operator.run            -                3m37s
        ├── CustomResourceDefinition/packages.package-operator.run                   -                3m37s
        └── Namespace/package-operator-system                                        -                4m22s

I know that there is a missing ServiceAccount which I can reverse query for its dependencies with kubectl lineage -D -n package-operator-system ServiceAccount/package-operator:
NAMESPACE                 NAME                                                             READY   STATUS   AGE
package-operator-system   ServiceAccount/package-operator                                  -                5m31s
                          ├── ClusterObjectSet/package-operator-56496479f6                 -                5m20s
                          │   └── ClusterObjectDeployment/package-operator                 -                5m21s
                          │       └── ClusterPackage/package-operator                      -                5m22s
                          ├── ClusterRoleBinding/package-operator                          -                5m31s
                          │   ├── ClusterObjectSet/package-operator-56496479f6             -                5m20s
                          │   └── ClusterRole/cluster-admin                                -                6m56s
                          ├── ClusterRoleBinding/system:basic-user                         -                6m56s
                          │   └── ClusterRole/system:basic-user                            -                6m56s
                          ├── ClusterRoleBinding/system:discovery                          -                6m56s
                          │   └── ClusterRole/system:discovery                             -                6m56s
                          ├── ClusterRoleBinding/system:public-info-viewer                 -                6m56s
                          │   └── ClusterRole/system:public-info-viewer                    -                6m56s
                          └── ClusterRoleBinding/system:service-account-issuer-discovery   -                6m56s
                              └── ClusterRole/system:service-account-issuer-discovery      -                6m56s

and also a deployment kubectl lineage -D -n package-operator-system Deployment/package-operator-manager:
NAMESPACE                 NAME                                               READY   STATUS   AGE
package-operator-system   Deployment/package-operator-manager                1/1              11m
                          └── ClusterObjectSet/package-operator-56496479f6   -                11m
                              └── ClusterObjectDeployment/package-operator   -                11m
                                  └── ClusterPackage/package-operator        -                11m

I'll link the Package sources for reference [2]. The full list of missing dependent objects should be:

Deployment/package-operator-manager
ServiceAccount/package-operator

All objects have proper ownerReferences set up. I've tried to include all relevant object manifest in the attached dump. [3]

[1]
kubectl apply -f https://github.com/package-operator/package-operator/releases/download/v1.6.5/self-bootstrap-job.yaml

[2] https://github.com/package-operator/package-operator/tree/v1.6.6/config/packages/package-operator
[3] package-operator-objectdump.tar.gz

Hi @erdii! Really glad that you found this tool useful for you & thanks for writing this comprehensive bug report 🙏
Can I also trouble you to share the example outputs shared above but including the  --output=wide flag? That would help me get a better idea of the list of relationships that the tool as resolved from scanning through all the resources fetched from your cluster.
I'll try to make some time to take a good look at this soon 🙏


Fix: Issues with remove command

Resolves #289
I've used the wrong object during the refactor phase, causing this issue.
Also discovered that removing user does not update the database (which I also missed).
So now, this command should work as intended.

Have you tried your code, by the way?

ye, should work

I renamed the milestone 3.3.0 instead of 5.3.0

I'll push the version


Space Traveller's Hub Project

In this project we were two coding partners; @lucy-sees  and @siddghosh108. We worked on the following tasks together,

[x] Created React App
[x] Installed React Redux.
[x] Created routes and view components: rockets, missions, my profile.
[x] Created directories for all Redux state slice files:rockets and missions.
[x]  Fetched data and updated the Redux store
[x] Wrote actions and reducers for booking rockets and joining missions.
[x] Wrote actions and reducers for cancelling rockets and leaving missions.
[x] Rendered UI: Missions page, Rockets page and our Profile section

Dear Senior,
For QC purposes, we have the second student collaboration here.


[Bug]: "submit item" non-functional

Bug Description
can't submit items or claim rewards if items say 100%
How to Reproduce?
create tasks to submit items
create reward for items
change tasks for item submission.
try to submit items and try to claim rewards
Expected Behavior
submitted items are removed from inventory before marked green and 100%
when all tasks completed and "1 reward left" claim rewards button is clickable.
Version
1.1.9
Mod Loader Version
1.20.1 - 47.2.18
Mod Loader
Forge
Logs or additional context
video of bug
https://github.com/terrarium-earth/Heracles/assets/138266442/16e05bae-9d1d-43f1-93d3-575265fcd47d
Code of Conduct

[X] I have searched the issue tracker and confirmed that the issue has not been reported
[X] I have checked the FAQ (if one is present) and my issue is not listed
[X] I have verified that I am using the latest version of the mod
[X] I have verified that I have installed all the required dependencies for the mod
[X] I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.

This is really only an issue with editing quests. You should use the /heracles reset to reset progress and fix this issues for your players.


Update 7_open_functions_v2.html with the right url

The Openfunctions-v2 blog workflow was recommending the http endpoint on port 8000. Since, we migrated to https, the end-point needs to be fixed.
Latest end-point: https://luigi.millennium.berkeley.edu/v1
This PR does not affect the BFCL Leaderboard.

@HuanzhiMao good point. Done.


Is there pre-trained weight?

Hi,
ViT seems to perform better with large dataset pre-trained.
Will pre-trained weights provided in the future?
Thanks.

@b02202050 not yet, the paper is still under review :)


webhook: fix npe

Pulling this out of #1635 to just fix the webhook npe.
Fixes #1634

/lgtm
/approve

/retest


[DOCS] Add a copy code button for all code blocks in Quickstart

Description
To improve UX, add a copy code button/icon to the top right of each code block in the LInkfree quikstart
https://linkfree.eddiehub.io/docs/quickstart
Screenshots
No response
Additional information
No response

I'm happy to be assigned this issue to work on, if that's alright with everyone?

This seems like a great idea! I would like to work on this.

Sure I have assigned it to you @ChinmayMhatre

Hey @amandamartin-dev , Do you know where I could get started on this? is there a library ? If not do you know how I could go about this?
I found this resource https://philstainer.io/blog/copy-code-button-markdown . but I am unable to implement it here

This blog looks useful https://blog.logrocket.com/implementing-copy-clipboard-react-clipboard-api/

Hey Eddie, I wasn't able to understand how to wrap the component around the mdx code block. Since we navigate to the mdx file using a link, I am confused how to pass the custom component to the mdx file. do I just import it?

Hey Eddie, I think I figured it out. Could you check if the PR is good?

yes I got the PR notifications and left some comments


A case for synchronous IsEnabled signatures to be provided next to asynchronous ones

Very nice that querying feature flag values async is supported, but the complete removal of synchronous signatures has one big downside: it is no longer possible to use the IServiceCollection APIs together with feature flags to inject alternate implementations.
Something like:
services.AddScoped<IFooService>(provider =>
{
   var features = provider.GetRequiredService<IFeatureManagerSnapshot>();
   return features.IsEnabled("except-really-inject-bar")
     ? ActivatorUtilities.CreateInstance<BarService>(provider)
     : ActivatorUtilities.CreateInstance<FooService>(provider);
})

-- is no longer possible.
Sure, it's possible to write:
services.AddScoped<IFooService>(provider =>
{
   var features = provider.GetRequiredService<IFeatureManagerSnapshot>();
   return features.IsEnabledAsync("except-really-inject-bar").Result
     ? ActivatorUtilities.CreateInstance<BarService>(provider)
     : ActivatorUtilities.CreateInstance<FooService>(provider);
})

-- but that's not really how you should be using async tasks and it's dangerous in the general case.

This pattern here would require more than a synchronous signature. The entire feature management pipeline would have to be customized to only use synchronous signatures. I.e. sync feature definition provider and sync feature filters. Is that the desire here?

The entire thing used to be synchronous, didn't it? It was specifically changed to be asynchronous to facilitate async providers and filters, in the process discarding the sync signatures entirely. Would've been a better idea to have both co-exist; and to optionally wrap a thin layer of .Result access around only the individual async providers or filters if you really, really have to and can't avoid it in any other way. (Or have providers and filters implement both a sync and an async interface and use the appropriate one for the type of call, pushing the responsibility further down.)

It used to be synchronous. The most feedback we received in preview was to provide an async pipeline for feature evaluation. The async pipeline doesn't prohibit synchronous usage.

Would've been a better idea to have both co-exist
That's a lot to juggle as a user of this library. The user would have to know about synchronous and asynchronous evaluation of features. If synchronous evaluation was used, they would have to ensure they didn't use feature providers | feature filters that required asynchronous execution.

I know there is a value of having a fully synchronous pipeline. The tradeoff for complexity of maintaining a fully sync and fully synchronous feature evaluation pipeline wasn't something we were willing to take.
For now, synchronous behavior can be achieved by ensuring that all of the pluggable feature manager services (i.e. IFeatureDefinitionProvider, IFeatureFilter) are completing synchronously. The built-in services do complete synchronously.

The built-in services do complete synchronously.

In other words: IsEnabledAsync("foo").Result is safe because the task should come out as pre-completed?

In other words: IsEnabledAsync("foo").Result is safe because the task should come out as pre-completed?

That depends on what types are being used to implement the feature management interfaces. If none of the default interface implementations are substituted, and no asynchronous feature filters are used then the pipeline is synchronous. In that case, that snippet would be "safe", meaning it would not block a thread.
Please feel free to re-open if there are any more questions.


Make attributes pretty

The design of the sheet is virtually entirely textual.  Getting some interesting iconography to hold the attribute values/mods could make the sheet look a lot better.
Ideas:

Fist for STR
??? for AGI (winged/running boot maybe?  Don't know how it would contain the numbers well though)
Torso for STA
Head for PER
Book for INT
4 leaf clover for LUC

The ideas above were for the 6 core attributes.  If they look good using iconography, then the same could be done for the saves and other attributes (HP, MOV, AC, INI).


Fix broken link in Validator page in SDK docs v4

Link to Lisk protocol in the Validator page is broken.

PR #1138 This issue has been completed


Added hooks method_added and method_removed

Please see #1065. This is implementation of it.
If you have an argument of method_added and method_removed specification, please post a comment to #1065. But if you have an argument of this implementation, please post there.

@MakeNowJust Awesome!! I don't have time to take a look at this, but I'll do it during this week. It's amazing that you modified type_inference.cr, I don't think that code is very clear, but you found a way :-)
I think undef will be gone, so maybe method_removed won't be needed.
I read in crystal-jp that after this change, the compiler takes 7s more to compile. Did you try compiling the new compiler with --release? If it's slow, maybe it's because you always create a Call node, even if there are no hooks, so maybe creating it lazily will speed up things (but I don't want to guess much, profiling is bette)

@asterite  I wrote benchmark script and run it.
According this result, added method_added version is faster rather than old version.  Why? Please check benchmark script.

@MakeNowJust Oh, to check the time it takes to compile the compiler, we usually don't use the --release flag. It's a bit confusing:

Compile the new compiler using the --release flag, so the compiler is optimized.
With the new compiler, compiler another compiler not using the --release flag.

The problem is, --release will turn on LLVM optimizations, and this is where most of the time is spent (about a minute or more).
To make it clear:
Parse: 00:00:00.1067890               # to parse the whole program
Type inference: 00:00:05.3825190      # the whole type checking, we are ready for codegen after this
Codegen (crystal): 00:00:01.6943680   # generate LLVM IR code
Codegen (bc+obj): 00:00:08.1608280    # turn that LLVM IR code into .o files (!!)
Codegen (clang): 00:00:01.0178690     # run `clang ...` with all the .o files

In the above stats you can see that 8 seconds are gone turning LLVM IR code into .o files (the !! part). And that is taking more than anything else we are doing (parsing and type inference). The next time you compile your program we try to reuse those .o files if they didn't change, so that time is usually reduced to zero:
# second compile, no change
Parse: 00:00:00.1095250
Type inference: 00:00:04.1833090
Codegen (crystal): 00:00:01.7189030
Codegen (bc+obj): 00:00:00.8762690 # time is reduced A LOT
Codegen (clang): 00:00:01.0008120

You can also see the second part, "type inference" is a bit faster too. That's because the compiler uses the "ecr" run macro, and that program is already compiled so there's no need to recompile it (we actually compile it, but the .o files are already there so there's no need to regenerate them... so... it's recursive).
Now, I compile with --release:
Parse: 00:00:00.1037790
Type inference: 00:00:05.0788610
Codegen (crystal): 00:00:01.5548660
Codegen (bc+obj): 00:03:59.5582060   # <--- 4 minutes!!
Codegen (clang): 00:00:00.6108890

Now it takes 4 minutes for that long phase, because before generating the .o files we optimize the LLVM IR.
Because of this, if you make changes to the type inference phase and want to check difference in performance, you have to check the second phase only, because the 4 minutes phase sometimes takes 4.05s, sometimes 3.55s, etc. (easier to small relative variations here).
As a closing comment, I tried your branch and didn't see any impact in the performance of the type inference :-)

@asterite Thanks for detailed comment!
I am going to remove method_removed, and I will add it again if decided undef alternative. OK?
BTW, how do you show those seconds?

@MakeNowJust Oh, sorry! I removed the first line. You use the --stats or -s flag:
$ bin/crystal build samples/mandelbrot.cr -s
Parse: 00:00:00.0317140
Type inference: 00:00:00.0652610
Codegen (crystal): 00:00:00.0188620
Codegen (bc+obj): 00:00:00.0841730
Codegen (clang): 00:00:00.0562710

@MakeNowJust You can leave method_removed for now. If we later decide to remove undef, we also remove that hook.

@asterite OK. I leave method_removed for now.

@asterite When this PR is merged? Or you have a reason not to merge it?

You might want to rebase to keep it easily mergable, right now there are conflicts ;)

@jhass Ok. I rebased!

@MakeNowJust Thanks! We'll probably merge this. But what are the uses cases for this? If you can't have state in macros, what would you use method_added for?

Since included can't catch all method definitions, especially when reopening classes no matter how we change it, it can be useful to dynamically wrap all method definitions for some instrumentation for example. Or sometimes the state doesn't need to be available at compile time and you can do very well build runtime state in macros.

@jhass Thanks! I considered same problems and examples too.

@MakeNowJust Could you rebase this pull request? Many things have changed, for example "undef" was removed and I also changed some arguments order for "expand_macro". After that we'll merge this. Thanks!

@asterite I rebased this branch.  Ok?

Thanks @jhass.  I removed all Undef from this branch.

LGTM, but I think it's fine as a single commit. Could you squash them together please?
git remote add upstream https://github.com/manastech/crystal.git
git fetch upstream
git checkout feature/method_added
git rebase -i upstream/master
# Choose fix or squash for all but the first commit
git push -f origin feature/method_added # assuming origin is your fork

Thank you!


get and reset as properties of createSuite result

Q
A

Bug fix?
✖

New feature?
✔

Breaking change?
✖

Deprecations?
✖

Documentation?
✖

Tests added?
✔

Fixed issues
#315

Hi, I followed your advice and load the properties into the function that is beign returned by createSuite, I'm a bit insecure about the changes in the definition file since it's my first contribution to an open source project and I couldn't find any type definition for the reset and get functions. Hope that it helped somehow

Oh, you're right. I missed those types in the declarations file.
I just added them, so you can re-use.
https://github.com/ealush/vest/pull/333

Thanks for the feedback, I will add the changes asap

Very nice, @vligas. Thank you again for helping out 💯


Add support for uwp targets

Hi,
This MR is related to rust-lang/rust#60260, and allows the use of "uwp" as part of the target.
I'm unsure what the best way is, when it comes to cross dependent MRs, so I'll gladly change things according to your reviews!
As noted in the rust-lang MR, the i686 target isn't fully functional, due to a mismatch in the stack unwinding model (LLVM's libunwind assumes SjLj when targeting i686, rust-lang assumes SEH will be available)
Thanks,

Thanks! I'm gonna try to centralize conversation on https://github.com/rust-lang/rust/pull/60260, so I'll comment there soon.

Updated the PR with the new triplet

Ok the naming is final enough now that I'm gonna go ahead and merge this.


Definition of the mass matrix

There are many ways to write down the equations of motion of a floating-base rigid-body system, which differ primarily by whether they are of the form
M(q) ddq + b(q,dq) = tau
or
M(q) dv + b(v,dq) = tau,
where q are the generalized positions, dq the generalized velocities and ddq the generalized accelerations. v contains the velocity and the angular velocity of the floating-base as well as the joint velocities and dv is the derivative of v w.r.t. time.
Which of those mass matrices does pinoccio provide?

Pinocchio provides the second version, meaning that in Pinocchio orientations in the configuration vector are represented as quaternions and the corresponding angular velocities as 3D vectors.
I guess in

M(q) dv + b(v,dq) = tau,

You wanted to write M(q) dv + b(q,v)= tau.
We made this choice to avoid singularities when relying on Euler angles.
Does is answer your question?

Thank you very much for your fast response! Yes this answers my question and yes I wanted to write b(q,v) instead of b(v,dq) indeed. This issue can be closed from my side.
I'm sorry for this being offtopic, but can you recommend a resource which explains how to derive the second form? I would be able to derive the first form myself, but I struggle to familiarize myself with the second one. I found this document:
https://pure.tue.nl/ws/portalfiles/portal/25753352/Traversaro_en_Saccon_DC_2016.064.pdf
which roughly sketches how the second form can be obtained, however it points to resources which make extensive use of Lie groups/algebras and very advanced mathematical tools, which I fear to be a bit overkill.

I think the best reference is the book of Roy Featherstone called Rigid Body Dynamics Algorithms on which Pinocchio is based. The first four chapters will help you to really capture the essence, without too much difficulty.