Updated

Thank you for your PR. However at this point of time, we don't think it is strictly relevant to the subject matter at hand or significantly improves the user experience. We hope to see more contributions from you in the future!


Append(!! ) command

Overview
This command allows the user to append text to their previous message. The bot will resend the new message back to them.
Example:
User: http://google.
User: !!com
Bot: http://google.com
If the new message is a command, the bot will also run it. This is useful if you forget a parameter of a command.
Example:
User: !gif
User: !! cats
Bot: !gif cats

Test case still doesn't like the lines
+import commands from '../index';
+import { callCmd } from '../../index';

In the source file. Removing these from /commands/useful/append.js will stop the error from happening when running npm run mocha

@dustinblackman Sorry I had to create a new PR, this one should be up to date with master.

@dustinblackman Finally had some free time to try to finish this up. Since the problem seemed to be with getting the command list from commands/index.js while running the test case, the append module now just keeps it's own copy. Let me know what you think.

Looks great, thanks a lot!


Getting empty response for lineage put api

https://user-images.githubusercontent.com/59080942/148949715-17440632-41b0-4eb5-9446-a45400707397.mov

@Sachin-chaurasiya, what are you expecting in terms of response. It is the lineage that you pass in the request that gets added.

@Sachin-chaurasiya, what are you expecting in terms of response. It is the lineage that you pass in the request that gets added.

@sureshms, Earlier we were getting responses like this
{
data:'',
statusText:"Ok",
code:200
...
}

we were using this response code to validate the response, but now we are getting an empty response.


[Event Request] Codeunit 13 OnBeforeCommit

Codeunit 13 Gen. Jnl.-Post Batch in Procedure ProcessLines
OnBeforeCommit(GLRegNo)

Can GlobalVarAccess is set to Yes on this as well ?  So that potentially the event subscriber can access valuables from codeunit 13 at the same time.


pytz version requirement

Is there a reason that dirty-equals requires a semver version of pytz or would you be happy to accept a PR to change the requirement to *?
I assume it was just added with poetry add or something.

Happy to relax the requirement. I just chose the most recent version out of habit.

I just had to drop dirty-equals out of a project because I couldn't get it installed w/ some of the other reqs that got updated. Would be nice to see the PR merged!
Also, Thank You for the project -- it's really nice 👍


Update printopia to 3.0.8

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

https://www.virustotal.com/#/file/458585dbcd0aa683801c8ad9020c57e0f407cc98d3f74a5ea1558ddf4254e73c/details


Redirect obm api calls to obmd

This is built on top of the work in #1002. See the commit message for  d1e7ec1.
One nagging thing that makes testing a bit annoying is that when dry_run is enabled, enable_obm is a no-op, which means calls like power_off etc. fail even if you've correctly enabled the obm. In the most recent commit I deal with this by just shoving a bogus token in the field, which I think for the self-contained tests s a reasonable strategy.
For the client tests though, because they actually spawn a whole web-server, it's a bit more of a pain. Probably the easiest thing to do there is just bite the bullet and say you need obmd available to run those tests as well (the same as with tests/integraton/obmd.py). For better or worse, they really are integration tests, and they have caught a few things not directly related to client library. So while the current desgn isn't super clean, it has value, and maybe the thing to do is just embrace the fact that they're integraton tests and go with it? I'd like to have a clear stance on the issue.

I think we should just move the client library tests to tests/integration/. That will also help us run all our integration tests in a separate Travis build on parallel with the rest of the tests.

Makes sense to me. Should we do the directory move as a separate pr?

Yeah, that should be a separate PR.

Sounds good.

A small part of me is tempted to just make obmd a hard-dependency for running the tests, and get remove the dry_run decorator from obm_enable/obm_disable. I have an instinctive aversion to this, but it's also not like there's a lot of setup involved -- you just need the obmd executable in your $PATH.

because the client tests do a bunch of work registering switches using the real hardware drivers -- so disabling dry-run would cause a bunch of problems there.

Sorry, I don't understand. We don't use dry_run for switches. I think only the headnode code and ipmi code uses that. And, the client library tests work just fine with dry_run disabled.
On a slightly related note, I'll try to refactor some of the client library code once my other 2 PRs are in  (things I have in mind: load a minimal config file, register mostly mock stuff, mock authentication, and populate the db by directly inserting into the db).

Quoting Naved Ansari (2018-05-03 16:48:08)

Sorry, I don't understand. We don't use dry_run for switches. I think
only the headnode code and ipmi code uses that. And, the client library
tests work just fine with dry_run disabled.

Ah, dug into it a bit further; I saw both the presence of
deferred.apply_networking() and creation of nexus/powerconnect/brocade
switches and made an assumption, but we never actually do any real
networking operations in those tests, except for with the mock switch --
so you're right, it's fine without dry run.
Opinions on just requiring an installed obmd for those tests to work?

On a slightly related note, I'll try to refactor some of the client
library code once my other 2 PRs are in (things I have in mind:
[...]
and populate the db by directly inserting into the db).

So, as much as this feels like it would be a bit cleaner, going through
the HTTP api is something that right now only the client tests exercise
thoroughly actually going through the HTTP api. I'd love to factor stuff
out and clean stuff up, but I want to be careful not to lose the value
we're getting from what it's exercising. Everything else you suggest
sounds great.

Opinions on just requiring an installed obmd for those tests to work?

I am fine with it since we agree on calling the client lib tests as integration tests, it makes sense to make sure to test we can follow redirects etc.
Btw, I was looking to see where we currently test the rest of the obm calls (even if with a mock driver) and I couldn't find it in tests/unit/api/main.py (it was only testing, power_cycle to test dry_run). Right now, only the client library is actually testing those APIs. Do you think we should have been testing those in tests/unit/api/main.py with a mock driver. And if you were to add it now with the new OBMd stuff, I think we would have to use the dry run decorator in more places then.

The relevant coverage in the client tests for the obm calls is pretty good; it would have been good to have that stuff tested in api.py, but I don't know that I think it makes sense to add stuff there, at least while everything is in flux. In terms of actual coverage, I'm pretty comfortable with what's in the client integration tests.

@naved001, I think this is ready for review; I've removed the WIP tag. The history is rather messy, and I would be amenable to spending some time cleaning it up, but the diff isn't too bad I think. Note that this includes the patch from #1009, since that is required for the tests; #1009 should be merged first (as well as #1002).
I ended up backing out the change to show_console, since due to the change in the api (streaming vs. just returning a current buffer), it's a bit bigger change than the others -- I thought it made sense to do it as a separate pr, so my plan is to do that next. After that, all that will be left will be to delete the old obm support.

@naved001, done.

The travis failures are due to the fact that https://github.com/CCI-MOC/obmd/pull/18 hasn't been merged yet; once that lands they should clear themselves up.

@naved001, your comments have been addressed.

The pattern of failures looks like it's because we're running two tests at a time, and they're fighting over the port number. It passes locally if I don't run the tests in parallel, but it would be nice to be able to do that, so I'd prefer not to disable it. I wish there were a nice way of figuring out which of pytest's "worker process" we're running in.

The sqlite errors could be because we are running the client tests in parallel and that is taken care of in #1008

Looking around a bit it seems there are a couple relevant environment variables. I'll tweak it to do the right thing if I can.

By taken care of I mean, we only run unit tests with sqlite, and integration tests are run serially. So you may not have to worry about fixing anything here.

Ok -- I think I have a solution anyway, but maybe we'll let #1008 land and then I can submit that as a further improvement.

@zenhack I just merged #1008, so we're all set there

Fixed the typos and rebased.

Some real test failures; working on fixing.

I am at a little bit of a loss re: the test failures. I've got some other work I need to focus on today, but will dig back in later in the week.

@naved, @Izhmash, travis is passing now.

Fixed the typo and merged master back in.

I am not sure why can't we start obmd? I thought I did it the right way in #1019

@naved, see my most recent commit message; hopefully that will fix it.

@naved001 I'll let you merge this one since your +1 is a bit outdated now.

@zenhack thanks for the fix. Merging


Native exceptions on iOS are not being reported

Testing things here and if I create a case where the native runtime crashes, nothing is reported to the console. I am using MAUI, but I have created this test code.
The last parameter is supposed to be a pointer to some function, but if I stick random things in there it explodes.
public partial void QueueInvalidOperation()
{
    var ns = (ulong)TimeSpan.FromSeconds(1).TotalNanoseconds;
    var queue = DispatchQueue.MainQueue;

    dispatch_after_f(ns, queue.Handle, IntPtr.Zero, 12345);
}

[DllImport(Constants.libcLibrary)]
static extern void dispatch_after_f(
    /* dispatch_time_t */ ulong time,
    IntPtr queue,
    IntPtr context,
    // delegate* unmanaged<IntPtr, void> dispatchBlock);
    IntPtr dispatchBlock);

Likely related to #12 which means it should be fixed on the 1.4.2-pre-1 release for Raygun4Maui https://www.nuget.org/packages/Raygun4Maui/1.4.2-pre-1

We've released Raygun4Maui v2 now which brings along the changes from 1.4.2 so this should be addressed


Feature: Import subdirectory/file from packages

I'm looking for a way to import subdirectories within a package without explicit exports in the index file. Unfortunately without any luck so far.
packages/a/foo.ts
export const FOO = 42;

packages/b/index.ts
import { FOO } from '@namespace/a/foo';

The only workaround I found was to import everything within the index file
packages/a/index.ts
export * from './foo'

Did you find any workaround for this?

Did you find any workaround for this?

@dunklesToast
Unfortunately not. I tried out aliases and paths but none of them worked for me

@dunklesToast
Unfortunately not. I tried out aliases and paths but none of them worked for me

Okay I found a working config:
tsconfig.json
"paths": {
  "@dt/somecomponent/*": [
    "modules/somecomponents/src/*"
  ],
  "@dt/somecomponent": [
    "modules/somecomponents/src"
  ]
},

Only problem I currently have is fixing my ESLint Config

Okay I found a working config:
tsconfig.json
"paths": {
  "@dt/somecomponent/*": [
    "modules/somecomponents/src/*"
  ],
  "@dt/somecomponent": [
    "modules/somecomponents/src"
  ]
},

Only problem I currently have is fixing my ESLint Config

I fixed ESLint:
settings: {
    'import/resolver': {
      alias: {
        map: [
          ['@dt/somecomponent', './modules/somecomponents/src/']
        ],
        extensions: ['.ts', '.js', '.jsx', '.json'],
      },
      node: {
        extensions: ['.js', '.jsx', '.ts', '.tsx'],
      },
    },
    react: {
      pragma: 'React',
      version: 'detect',
    },
  },

Using this ESLint Addon

I fixed ESLint:
settings: {
    'import/resolver': {
      alias: {
        map: [
          ['@dt/somecomponent', './modules/somecomponents/src/']
        ],
        extensions: ['.ts', '.js', '.jsx', '.json'],
      },
      node: {
        extensions: ['.js', '.jsx', '.ts', '.tsx'],
      },
    },
    react: {
      pragma: 'React',
      version: 'detect',
    },
  },

Using this ESLint Addon

@dunklesToast
But this means that you have to add an alias for each submodule/subfolder, right?
I would love to have some wildcard like
"paths": [
  "@dt/**/*": [
    "modules/src/**/*"
  ]
]

@dunklesToast
But this means that you have to add an alias for each submodule/subfolder, right?
I would love to have some wildcard like
"paths": [
  "@dt/**/*": [
    "modules/src/**/*"
  ]
]

Hmm thats correct. I know that you can use one Wildcard in the Paths but I don't know if multiple will work

Hmm thats correct. I know that you can use one Wildcard in the Paths but I don't know if multiple will work


⚠ Processors has degraded performance

In 2f0c7f9, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 118 ms

Resolved: Processors performance has improved in 70e4721.


How to prevent unexpected validation in vee-validate?

Versions

vee-validate: 2.2.7
vue: 2.5.11

Describe the bug
I've two fields: unique and unique1. Both fields are validate on blur.
unique is required.
unique1 have three rules - required, speicalRule and is_not: unique.
To reproduce
Steps to reproduce the behavior:

Type something in unique1
Type something in unique
Fired unexpected "speicalRule" on change unique field.

Expected behavior
speicalRule is not fired when unique field changing.
Demo link
https://jsfiddle.net/392uxowr/6/
Desktop (please complete the following information):

OS: [Mac OS Siera, Ubuntu 16.04]
Browser [chrome, safari, mozilla]
Version [e.g. 22]

VeeValidate always re-runs validation when rules parameters change, so that is by design and not a bug. and yes it runs all the rules each time, not just the ones changed.
If you want to prevent your rule from running when both fields have the same value you could do: specialRule: unique !== unique1 instead of specialRule: true

okay, I've added rule like you send me specialRule: unique !== unique1
And how can I get result of comparison "unique !== unique1" in function speicalRule?
const speicalRule = function speicalRule(unique, unique1) {
      debugger;

    // unique - value of unique1,  and unique1 is the array.
    // How can I get a boolean type of the result of comparison that was declared?

	return new Promise(function (resolve) {
          return resolve({
            valid: true,
            data: {
              message: 'incorrect'
            }
          })
	 });
	};


Runaway exception "A fatal error occured.  Zcoin can no longer continue safely and will quit".

Windows (10) / Running a node via VPS with 55GB SSD and 2048MB memory / OS Ubuntu 19.04 x64
I have deleted and reinstalled the wallet several times.  I have tried ./zcoin-qt.exe -reindex and thats when I get the error message.  When I click on the wallet.exe it shows the wallet is trying to load however, then it disappears.  The wallets block status in putty is up to date.   Even though the wallet startup display disappears after I receive the error message, I can see,
"Zcoin Core (GUI node for Zcoin)" running in task manager.

This is an issue with the Zcoin-QT wallet, not the new Zcoin Client wallet. @riordant Can you transfer the issue there please?


Precompute looking up indices for all variables in update_auxvars

Looking up the index for a single variable is quite expensive since
we need to find that variable in a vector. The current method ended up
calling indexin which is not optimized well for finding a single value
since it does quite a bit of expensive stuff under the hood (like creating
a dictionary).
Instead, in this PR, we precompute a variable => index mapping for all variables
which is done via a simple loop and then use that mapping when an index is needed.
This takes the time for solving the FRB-US model (following the tutorial in TutorialsEcon and using
the @btime macro from BenchmarkTools.jl) from
julia> @btime simulate(m, p_0, ed_0; verbose=true, tol=1e-12);
  472.368 ms (1646933 allocations: 3.80 GiB)

to
julia> @btime simulate(m, p_0, ed_0; verbose=true, tol=1e-12);
  148.714 ms (1389881 allocations: 946.72 MiB)

Codecov Report

Merging #41 (fff9099) into master (7a7dfa8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   94.43%   94.44%   +0.01%
==========================================
  Files          15       15
  Lines        1671     1675       +4
==========================================
+ Hits         1578     1582       +4
  Misses         93       93

Impacted Files
Coverage Δ

src/model.jl
96.65% <100.00%> (+0.02%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Load credentials from SBT_CREDENTIALS

This addresses #6718. I'm not sure this is the right place to load that. Let me know what you think. If you say that's okay, I'll add in the tests.

@daddykotex I think overall this is good.


unexpected behevior of  result occurs

Steps to reproduce the issue
Consider the following piece of code:
module top  (y, clk, wire3, wire2);
  output wire [(32'h50):(32'h0)] y;
  input wire [(1'h0):(1'h0)] clk;
  input wire signed [(5'h15):(1'h0)] wire3;
  input wire signed [(2'h3):(1'h0)] wire2;
  reg signed [(5'h15):(1'h0)] reg10 = (1'h0);
  assign y = {reg10};
  always
    @(posedge clk) reg10 <= (-$signed((-(wire2 << {wire3}))));
endmodule

Run with yosys version
   Generated by Yosys 0.9+4081 (git sha1 UNKNOWN, clang 10.0.0-4ubuntu1 -fPIC -Os)

and the following command
 yosys -p 'read_verilog  rtl.v; synth; write_verilog  syn_yosys.v'

Expected behavior
when Executing CHECK pass and Verilog backend,get a corresponding Write Design to Verilog file

Actual behavior
The corresponding Verilog file is an empty function

`/* Generated by Yosys 0.9+4081 (git sha1 UNKNOWN, clang 10.0.0-4ubuntu1 -fPIC -Os) */
module $abstract\top ();
endmodule`
We think this should be a bug.

Yosys 0.9+4081 is nine months old or so, could you retry with latest Yosys?

这是来自QQ邮箱的假期自动回复邮件。收到。                  祝好！                  张漪

Yosys 0.9+4081 已经九个月左右了，你能用最新的 Yosys 重试吗？

The latest yosys has been tried, and the result is expected, but the above situation occurs in the 0.9 version, does it indicate that there is a bug in the yosys 0.9+4081

More generally you probably need to run synth -top top rather than synth.

synth -top top
Yes, executing "synth-top top" on Yosys 0.9+4081 can get   desired results, but can you tell me what is causing the problem when executing the command 'synth' directly?

@1353369570 In exactly that time there were multiple PRs to refactor and  improve hierarchy pass, so you probably have some non-stable build in middle of these change. Closing issue since this is not present any more.

这是来自QQ邮箱的假期自动回复邮件。收到。                  祝好！                  张漪


NirSoft.AdvancedRun version 1.51

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="{jjong}"]

@microsoft-github-policy-service agree


Bug Fix: Wrong error heandling in styles (SCSS)

Bug Fix: Changing place for error handler so wrongly formated SCSS will not stop running watcher

Hello, thank you for PR.
I'm curious why it doesn't work for you, because it works just fine in my environments (OS X, W7). I will check it out in next iteration, which will by coming soon.


Gradle Sandbox Mode

Current situation
Tasks which use undeclared inputs are problematic because Gradle cannot keep track of them and thus they can cause builds to become incorrect. When one of the undeclared inputs changes, Gradle will still believe that the task is up-to-date and won’t rebuild the task - resulting in an incorrect build. A test which doesn't declare its inputs properly might have an incorrect up to date check and thus cause the test not to re-run in a situation where it should have rerun.
Many tests and tasks in the Gradle ecosystem were not written with caching in mind.
See SqlDelight for an example (sorry for picking on SqlDelight, its an amazing library)
In this example, dependencies.gradle is not declared as an input. Changes to dependencies.gradle could cause the test to fail, but not be re-run and therefore succeed. This false positive can be extremely dangerous.
Proposal
Gradle tasks should run in sandbox mode. The sandbox mode restricts the access rights of the task to only be able to touch files which are declared as inputs. Touching files outside the sandbox should fail the task and the build.
Other build systems such as Bazel have a sandbox so that developers do not need to worry about build correctness:

We believe that developers should never have to worry about correctness, and that every build should result in the same output, regardless of the current state of the output tree. If a compiler or tool reads a file without Bazel knowing it, then Bazel won't rerun the action if that file has changed, leading to incorrect incremental builds.

Sources:
Most of the information in this ticket is copied from:
Bazel Sandboxing
Bazel Updated Sandbox
This ticket is a follow up to the discussion on:
https://github.com/gradle/gradle/issues/9151

Thanks for writing this up @runningcode. We are investigating how we could help users make sure they declare their inputs and outputs properly. Sandboxed mode is one of the ideas we are looking at.

Implementing tools to shake out undeclared inputs/outputs are among our goals for the not-too-distant future, though there are no concrete plans or roadmap at this time. I'll update this issue once we get to something more concrete.

If you implement a sandbox, please allow us to turn it off to optimize the build times, since having sandbox will have a non-zero execution time.

A sandbox would be an opt-in feature if we implement it. It's not on our immediate roadmap, though.

Is this issue something an Android app developer is likely to encounter? ie. Is it common for Android unit tests to use undeclared inputs?


feat: add a option to pass a custom tsconfig in CLI

I'm submitting a...
[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

[x] Commit Messages follow the Conventional Commits pattern

A feature commit message is prefixed "feat:"
A bugfix commit message is prefixed "fix:"

[ ] Tests for the changes have been added

Description
A new argument has been added so that one can provide a custom tsconfig when using the CLI
Example:
ng-packagr --config tsconfig.lib.json --p ng-packagr.json
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Thoughts @dherges


Update nf-gdipluspen-pen-pen(constcolor__real).md

This is to address an incomplete explanation of what happens when width is set to 0.

@BigB9898 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


publish: Add link to wiki

generated from commit 19d651a65aa822f3777f71635cf21cde737070ee

@timsaunders not sure what this is? Doesn't seem to be changing the wiki at all.
Sorry for the slow reply!


Add transform-es2015-function-name to the react-native babel preset. Fixes #6716

Stateless function components (at least those using arrow functions) are not assigned names when this transform is omitted.
Fixes #6716

cc @martinbigio @skevy

cc @bestander

No objections from me.
The tests are failing because trunk was broken at night.

Just in case we need to make sure this works fine internally :)

@dantman Can you rebase against master?

Any updates on this?

Closing in favor of #6794 . I kept the original author.


Error: could not parse state: json: cannot unmarshal array into Go struct field terraformOutput.outputs.value of type string

I hit the following issue when I added a Terraform output of type array.
Terraform Cloud Plan & Apply passes successfully and I can see array output.
But kvrhdn/tfe-run action fails with
Run<EMAIL_ADDRESS>...
Run has been applied!
Error: could not parse state: json: cannot unmarshal array into Go struct field terraformOutput.outputs.value of type string

My Terraform output
terraform output
name = [
  "my-name",
]

Okay this if unfortunate... after applying the config, this action will fetch the outputs and expose them as outputs in GitHub Actions. This implementation is basic but good enough, until now I guess.
The terraformOutput struct in the following code should be adapted to handle arrays:
https://github.com/kvrhdn/go-tfe-run/blob/104d8cce779fddd82ad7a9e81fe74090b02742a9/tferun.go#L283-L317
Even better would be to get rid of this code and use an external library or Terraform itself for this.

The following steps maybe useful for others. Uses terraform output -json and jq
      - name: Setup Terraform
        uses: hashicorp/setup-terraform@v1
        with:
          terraform_version: 1.0.2
          cli_config_credentials_token: ${{ secrets.TFC_ACCESS_TOKEN }}
          terraform_wrapper: false   # required to use terraform cli

      - name: Terraform Output
        run: |
          TF_OUT=$( terraform output -json )
          echo "TF_OUT=${TF_OUT}"

          LOCATION=$( jq '.location.value' <<< ${TF_OUT} )
          echo "::set-output name=location::$LOCATION"
        id: tfout

Created a PR for this https://github.com/kvrhdn/go-tfe-run/pull/19
it will just skip trying to output complex types. Only primitive types will be output


Recent PR breaks requests to modify Assistant (breaks our production deployment)

Describe the bug
An bug was introduced with https://github.com/sashabaranov/go-openai/pull/669 when modifying an Assistant, we now regularly get this error Invalid type for 'tools': expected an array of tools, but got null instead. That's because an uninitialized Slice in Go equates to nil even if it's not a pointer.
The Linked PR suggests that an empty list will be supplied by default, however null is being sent instead which is not allowed in the API.
In fact the linked PR isn't necessary. By the nature of Golang, initializing a slice with Make() will not be omitted by the json encoder, and will effectively delete all of the tools.

To Reproduce

create an assistant with instructions and tools
modify the assistant without any tools specified

req := openai.AssistantRequest{Instructions: &instructions}
	if _, err := h.OpenAIClient.ModifyAssistant(ctx, assistantID, req); err != nil {
		panic(err)
	}
// panic " Invalid type for 'tools': expected an array of tools, but got null instead."

Expected behavior
The API clearly demonstrates that the Tools payload parameter is an optional field and if none is provided, an empty tools array is used. The linked PR breaks with the API by requiring an empty array of tools to always be initialized using make()
Screenshots/Logs
screenshot of API above
Environment (please complete the following information):

go-openai version: [e.g. v1.20.3]
Go version: [e.g. 1.21]
OpenAI API version: [latest]
OS: [Linux]

If the linked PR worked, it would automatically delete all tools anytime instructions are updated which is not how the API works, and would have been a much more disastrous breaking change
More repro to show how the API works:
original Assistant
{
instructions:  "original instructions",
tools: [{...tool1}, {...tool2}]
}
curl --request POST \
  --url https://api.openai.com/v1/assistants/{assistantId} \
  --header 'Content-Type: application/json' \
  --header 'authorization: bearer {token} \
  --header 'openai-beta: assistants=v1' \
  --data '{
	"instructions": "new instructions",
}'

returns
{
   instructions:  "new instructions",
   tools: [{...tool1}, {...tool2}]
}

delete tools
curl --request POST \
  --url https://api.openai.com/v1/assistants/{assistantId} \
  --header 'Content-Type: application/json' \
  --header 'authorization: bearer {token} \
  --header 'openai-beta: assistants=v1' \
  --data '{
	"instructions": "new instructions",
        "tools": []
}'

returns

{
instructions:  "original instructions",
tools: []
}


Update Governance and Contributing doc

See discussion in #2292

I see the following usage of the GitHub group
* Admin = Advisory Committee

* Contributor =  Org member Contributors

* Maintainers = currently not used.

* Outside Collaborators =  used for Weblate integration

I think we need to completely remove the mention of Advisory Committee from GitHub operations.
I think what we are really trying to frame up inside the Governance document is that:

The role Admin on GitHub is a privileged role
We want to have a documented decision process for voting folks into that Admin role
In general, I think we want to say something like other projects do (take a look at the entire page for the Rust Compiler Team or Node.js for a good guideline):

I really like this note from Rustc Compiler Team:

Membership is both a recognition but also an obligation: compiler team members are generally expected to help with upkeep as well as doing reviews and other work.

I think something like this should be added somewhere:

Individuals identified by the OpenRefine Steering/Advisory Committee who have made significant and valuable contributions to OpenRefine and its design may be added to the Admin team or Core Contributors team and given commit access to the project.

Furthermore, I personally really like the activities that Node.js lists and that we could borrow from

Activities taken into consideration include (but are not limited to) the quality of:
code commits and pull requests
documentation commits and pull requests
comments on issues and pull requests
contributions to the Node.js website
assistance provided to end users and novice contributors
participation in Working Groups
other participation in the wider Node.js community

If individuals making valuable contributions do not believe they have been considered for commit access, they may log an issue or contact a TSC member directly.

ping @OpenRefine/contributors for your feedback on this draft

The concept of "guest contributor" doesn't make much sense to me. I see basically two levels: contributors & committers. Admin should be separate from code-related stuff and small, with just a few day-to-day admins and a failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did originally, so we should make use of those finegrained permissions to allow a bigger group of committers, for those who have demonstrated merit, while still keeping the list of people who can delete/rename repos and do other destructive things small.
As an aside, since I'm an organization owner, I have admin privs even though I'm not part of of the admins team. I guess I can add myself to make that more transparent.

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

I will close the doodle pool in 3h from now.
--
Martin Magdinier
+1<PHONE_NUMBER>
On Fri, Jan 22, 2021 at 4:46 PM Martin Magdinier<EMAIL_ADDRESS>wrote:

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

I will close the doodle pool in 3h from now.
--
Martin Magdinier
+1<PHONE_NUMBER>
On Fri, Jan 22, 2021 at 4:46 PM Martin Magdinier<EMAIL_ADDRESS>wrote:

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

The call is scheduled for Wed Jan 27 at  5PM UTC. You can join using this
link: https://meet.google.com/fnn-zgra-ado
--
Martin Magdinier
+1<PHONE_NUMBER>
On Mon, Jan 25, 2021 at 2:34 PM Martin Magdinier<EMAIL_ADDRESS>wrote:

I will close the doodle pool in 3h from now.
--
Martin Magdinier
+1<PHONE_NUMBER>
On Fri, Jan 22, 2021 at 4:46 PM Martin Magdinier <
<EMAIL_ADDRESS>wrote:

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

The call is scheduled for Wed Jan 27 at  5PM UTC. You can join using this
link: https://meet.google.com/fnn-zgra-ado
--
Martin Magdinier
+1<PHONE_NUMBER>
On Mon, Jan 25, 2021 at 2:34 PM Martin Magdinier<EMAIL_ADDRESS>wrote:

I will close the doodle pool in 3h from now.
--
Martin Magdinier
+1<PHONE_NUMBER>
On Fri, Jan 22, 2021 at 4:46 PM Martin Magdinier <
<EMAIL_ADDRESS>wrote:

I think it will more effective to discuss and resolve them in a call. Who
would like to participate ?
I think it would be more effective to discuss proposed changes in a call.
I created a doodle to gather availability (between Jan 25 and 30 2021)
https://doodle.com/poll/zisrtcbqpa7e6ggk?utm_source=poll&utm_medium=link
On Tue., Nov. 3, 2020, 1:03 p.m. Tom Morris<EMAIL_ADDRESS>wrote:

The concept of "guest contributor" doesn't make much sense to me. I see
basically two levels: contributors & committers. Admin should be separate
from code-related stuff and small, with just a few day-to-day admins and a
failsafe backup admin like CS&S.
Github has a much more fine grained permission structure than it did
originally, so we should make use of those finegrained permissions to allow
a bigger group of committers, for those who have demonstrated merit, while
still keeping the list of people who can delete/rename repos and do other
destructive things small.
As an aside, since I'm an organization owner, I have admin privs even
though I'm not part of of the admins team. I guess I can add myself to
make that more transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/pull/3198#issuecomment-721289810,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATYHEAQXSM6TIHPHQZKES3SOBAYRANCNFSM4RUQW46Q
.

I updated the document with today's discussion.
Next:

Define how we are part of the advisory committee
Define how we name the release manager
Clarify who is Github owner how they are added/removed.
Update the GitHub permission and especially the team/contributors  to reflect this document

I updated the document with today's discussion.
Next:

Define how we are part of the advisory committee
Define how we name the release manager
Clarify who is Github owner how they are added/removed.
Update the GitHub permission and especially the team/contributors  to reflect this document


Values out of bounds

"Values are out of bounds. cnyield has Inf values, harvest years can reach 2101, biomass has small negative numbers, ..."

Do we have a list of all the out of bounds values?

Do we have a list of all the out of bounds values?

Yes, here is the report file with rows labeled as "outside valid range".
DSSAT-Pythia_data_issues.txt


Roll Flutter Engine from ea7730c16301 to a60af6b31dfb (2 revisions)

https://github.com/flutter/engine/compare/ea7730c16301...a60af6b31dfb
2023-08-10<EMAIL_ADDRESS>Roll Skia from<PHONE_NUMBER>71 to 92e6f52b0fa8 (1 revision) (flutter/engine#44592)
2023-08-10<EMAIL_ADDRESS>Roll Skia from f39fd2de8f10 to<PHONE_NUMBER>71 (1 revision) (flutter/engine#44590)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


fix NotImplementedError. Followed diffusers CrossAttention

Hi thanks for the great implementation of paint with words.
self.to_out is a Module_List which does not have forward function (as far as i know).
I followed the original implementation CrossAttention in diffusers and it works great.

Interesting I did not have this problem, and turns out I was using diffuser version 0.6.0. I will update req.txt as well

Thank you for your contribution!

Interesting I did not have this problem, and turns out I was using diffuser version 0.6.0. I will update req.txt as well

Thanks for the clear answer for root cause of the problem.


xfail test that always fails

This consistently fails.
In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.
Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

I think this is wrong and it's actually these?
=========================== short test summary info ============================
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_cmp_local_file - ...
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_dask - webob.exc....
FAILED xarray/tests/test_backends.py::TestPydapOnline::test_compatible_to_netcdf

In general I think as soon as we see this happening, we should either fix immediately (but probably not that easy) or xfail it and if necessary open an issue. That keeps the main branch green, such that we can reliably use passing tests as an indicator of PRs.
Though as ever, very open to other thoughts. There's a reasonable argument that "keeping master green by removing any failing tests is missing the point a bit"...

👍
It does look like the "TestPydapOnline" tests are still a culprit here...

It does seem this is happening a fair amount, so I'll merge this — feel free to revert if I'm mistaken. I think it may be worth also xfailing the Pydap tests?


"onSave" formats but doesn't save the file

File is being formatted correctly but the file is still in an unsaved state - I would expect the process to be done in one.

I had the same problem for ages. I could not work out why every time I save the file is still in an unsaved state. This explains it.
Meanwhile I had to set onSave to false, because I had to save the file twice every single time.

'Save twice' is a bad experience, and I find that it will change 'save-state' endlessly sometimes.

Exactly... that's the problem.

I have the same issue, as described from Arrow7000 with latest release of vscode and your plugin. I deinstalled the plugin now saving is working again as expected. It would be nice if you can fix this issue.

There may be another issue related to this, I've seen one file be intermittently overwritten with the contents of another open file when I save and it does the auto-format before saving for both files, can't pin it down to the extension or the editor itself but I've disabled format on save and will monitor it.

I have mistaken reported the same issue here to vscode.
https://github.com/Microsoft/vscode/issues/16510

After disabling this plugin, I no longer see the issue with autosave settings

@thekalinga what's the version of your vscode and extension？

vscode:
Version 1.8.0-insider
Commit 7499a9f3c565f4fbe5205e30c8664e5a5a11ae94
Date 2016-12-06T16:09:29.346Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0
Extension version
0.2.2


[Feature]: Add override for noEmit specified in TSConfig

What problem does this feature solve?
When using Modern.js alongside @total-typescript/tsconfig, noEmit: false has to be specified explicitly within tsconfig.json, otherwise modern build fails:
error   ModuleBuildError:

bundleless DTS failed:

error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

Unfortunately, though, when I have noEmit: false specified (either implicitly or explicitly) alongside allowJs: true, IDEs like VS Code show an error message as follows when viewing tsconfig.json while having any JS files within the source directory:
Cannot write file '…/project/src/something.js' because it would overwrite input file.

Therefore, it’d be convenient to allow specifying noEmit: true within the userTsconfig, possibly overriding it by appending --noEmit false to the CLI arguments over here.
What does the proposed API look like?
N/A

Unfortunately, I can’t provide the project itself, as it’s a private one. This is the TSConfig I’m using.

Thanks for your response!
Unfortunately, I can’t provide the project itself, as it’s a private one. This is the TSConfig I’m using.

Thanks for your response!
Unfortunately, I can’t provide the project itself, as it’s a private one. This is the TSConfig I’m using.

What library are you using? @modern-js/app-tools or @modern-js/module-tools?

@modern-js/module-tools, but I also gave Vite’s library mode a go in the meantime and sticked with it for the time being.

I created a project  as described to try to reproduce the problem, but it didn't reproduce the problem.

Thanks for creating that!
I forgot to mention I had 'npm-component-es2017' configured as the buildPreset in modern.config.ts. Running your project with that change results in a reproduction.

Thanks for creating that!
I forgot to mention I had 'npm-component-es2017' configured as the buildPreset in modern.config.ts. Running your project with that change results in a reproduction.

Can't reproduce the error even adding 'npm-componnet-es2017', the error seems quite like a pure TypeScript misconfiguration, could you check your tsconfig by refering https://stackoverflow.com/a/48798945/8063488.


Fixed add withKey method

In order to specify a different key than the model's one to be the parent key, you can use the ->withKey('name') method.
For example: you have id, code and parent_code in your model.
Your model uses id as key, but the parent-child relation is established between code and parent_code
In order to make SelectTree work with this model, you need to call the function ->withKey('code')
This PR fixes the problem introduced by https://github.com/CodeWithDennis/filament-select-tree/pull/70 and keeps using the ->getKey() function from the model if no custom key is specified

Done!

This is breaking every page that uses the SelectTree;
Maximum execution time of 30 seconds exceeded

I'm using it in my local installation and works. I don't know how to replicate the problem you're facing :(
 "codewithdennis/filament-select-tree": "dev-with-key",

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/buzkall/filament-select-tree"
    }
],

@buzkall Try to make an example with the "normal" way of using the field and you probably will get the same issue.

I've seen what you meant.
I've modified the getCustomKey function to work in both situations


[Investigate] default entpoints to querying metadata

Summary
The Swagger UI shows in the category "default" some endpoints to quering metadata. It should be investigated if they are implemented and how they can be used.
Details
Some endpoints provide the possibiltity to query metadata. For instance:

/{version}/{context}/metadata-catalog/query/{queryName}
/{version}/{context}/metadata-catalog/entity/{entityName}
/{version}/{context}/metadata-catalog
/{version}/{context}/metadata/query/{queryName}
/{version}/{context}/metadata/entity/{descriptorAlias}
....
This endpoinds should be investigated. It has to be clearified if they are already implemented and what data they will be deliver. Futhermore, it has to be investigated how they can be used. What variabale is to be set for the context to use this endpoint?

Acceptance criteria
An answer here which includes:
[ ]  which of this metadata endpoints are implemented
[ ] how to use the endpoints.
[ ] JSON sample output of the call of the endpoints
[ ] meaning of the path variables like "context"

The metadata endpoinds are not implemented. It looks like they are just shown due to some side effefts. Nevertheless, the default endpoints:
GET
/{version}/ldapusers
POST
/{version}/ldapusers
PUT
/{version}/technicalservices
are implemented but not yet documented.


Get rid of keys_with_prefix and use a iterator for (Key,Value) pairs instead (using Working Set) in the Auction

The auction currently uses keys_with_prefix to get all of the bids keys and then all of their values.  This is inefficient; iterators through global state already get the values as they get the keys.  This means the code walks everything twice.  The keys_with_prefix method should be replaced with a method that returns impl Iterator<Item=Result<(Key,Value), Error>>, and the auction code should be cleaned up.  Note that RocksDb provides a prefix iterator that will be leveraged by WorkingSet that is suited to this, and the existing iterator using the trie will be sun-setted (or perhaps just used in test).

SME: @EdHastingsCasperLabs @xcthulhu @mpapierski @dwerner

Closing as wont-do.


Molecule Archives with no molecules throws NPE

When Molecule Archive windows open with no items after running the Build DNA Archive command, they throw an error.
Maybe no archive should open when no molecules are found. For that I created an issue at mars-core.
But Molecule Archive windows also should not throw errors when empty:

I believe I have now found all locations where NPEs occurred due to no metadata or molecule records being in the archive. I have also made sure yama and rover files save correctly for archives with no record entries. This might be useful when you want to work with the rover or bdv without needing specific records.
All these NPEs when no records are present are an unfortunate consequence of keeping mars-core separate from mars-fx. This strict separation ensures archive files and commands could be used with an entirely different gui in the future and allows for only mars-core to be used in headless mode. There are many other benefits. However, it also means mars-core can't have any javafx dependencies. As a result, there are many places where events are fire that 'set' records into the gui panels. Typically javafx along would reinforce better patterns that would completely avoid NPEs and gracefully handle the situations when there are no records. But tying mars-core to javafx is not worth the benefits and there are many other downsides and limitations to the javafx data model. It is great for guis but not great in general for the MoleculeArchive format overall.
I am closing this for now since everything appears fixed. We can reopen when another NPE comes up.


About focus after closing in IE11

Version
vue-final-modal: 2.4.1
vue: 2.6.14
OS
Windows
Browser
IE11
Steps to reproduce

Create a modal
Create a button to open the modal
Click the button to open the modal
Click off screen to close the modal (you can also use the close button inside the modal)
Press the tab key
The focus element at the top of the page is in focus

What is Expected?
In IE11, like other browsers, if you press the focus key after closing the modal, you want to focus on the element that opened the modal.
Is ie11 unsupported?

what is Press the focus key mean?

sorry, it's the tab key

please checkout focustrap prop


OpenAPS enacting temp basal with old bg data

glucose.json.txt
Attached is my glucose.json file.  This file resulted in openaps running a temp basal even well after the 15 old threshold.  I've had old data from hours ago that openaps still thinks is current data.
Obviously, this is a major concern as if his last bg was high or low it could cause a serious problem

I think this is related to the old xdrip date string issue, I see "dateString": "04/30/2016 20:56:43 PM", maybe we can detect that and fallback to using date.  Also you might want to process the file.  Need to figure out the exact json -e, but the idea would be to set dateString = new Date(date).toISOString(), but that might still need to be zoned.

Thanks for looking into this Jason.  Not sure if it is worth fixing it in oref0 since it seems like an edge case although a particularly dangerous one.  I'll look into fixing it on my end.

I expect it to happen again, and since the correct data is there we should be able to make it work, but it might need to fixed in multiple places


TP2000-1083: Quota order number create

TP2000-1083: Quota order number create

What

Adds a link to the create quota form from the workbasket page and the quota search page
Adds the quota create form and confirmation page
Confirmation page links to the quota origin create form

Codecov Report
Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (798ae96) 92.80% compared to head (02a60f8) 92.79%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

workbaskets/views/ui.py
82.19%
8 Missing and 5 partials :warning:

importer/views.py
80.95%
1 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
- Coverage   92.80%   92.79%   -0.01%
==========================================
  Files         460      460
  Lines       34941    35083     +142
  Branches     2674     2692      +18
==========================================
+ Hits        32426    32557     +131
- Misses       1992     1995       +3
- Partials      523      531       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Customize the key for "open to side" in quickopen window

Currently, <Ctrl+Enter> seems the only way to "open to side" inside a quickopen window (e.g. after using <Ctrl+P>).
I would like to customize the key to have unified experience with other editors I've used. Such feature is possible in ctrlp.vim or ivy (for emacs). Or even better, have different keys to open it to vertical side or horizontal side.

This is now possible via the new workbench.action.alternativeAcceptSelectedQuickOpenItem command.

Verification
Ensure that you can change the workbench.action.alternativeAcceptSelectedQuickOpenItem command key and that it allows to open an editor (e.g. from Cmd+P) to the side.


React to the new StackExchange.Redis v2.0 package

StackExchange released a new Redis library StackExchange.Redis V2.0.x
We'll be creating a new package: Microsoft.AspNetCore.SignalR.StackExchangeRedis which uses that.
cc @anurse @Tratcher @DamianEdwards @Eilon

Done in https://github.com/aspnet/SignalR/pull/3089


[enhancement]: update git version in the agent for security vulnerabilities

Describe your feature request here
Git used on the current devops agent release is version 2.45 that has openssl (<IP_ADDRESS>) vulnerabilities (CVE-2024-5535, CVE-2024-4741,
CVE-2024-4603, CVE-2024-2511).
Seems git version 2.47 is not containing this issue because openssl version is <IP_ADDRESS>.
Please upgrade the git version contained in the agent.

Hi @lombardialess, thank you for the report.
We aware of this issue and updated the git version in scope of this PR - https://github.com/microsoft/azure-pipelines-agent/pull/5026 (Included in agent 3.248.0)
It has been deployed on the last week, so I'm closing this issue. Please feel free to reopen it in case if you have additional questions.


No distributions matching the version for future==0.13.dev

When doing a "pip install redis-limpyd" on a fresh virtualenv with python3.4:
No distributions matching the version for future==0.13.dev (from redis-limpyd)

I see that there is a 0.14.3 version out there, can we just upgrade?

@yohanboniface This is fixed, and merged, please upload a new package on pypi and update the documentation ;)


Video Url dont need to download video

HI
first of all nice library really like it.
My question is that i need to get the video url rather than downloading how i can do that. because i try to do but it download the video on server which i dont want to do
any help ?

--get-url.

But when i give this command it download the video oj server as well
On 13 Oct 2015 9:34 pm, "Jaime Marquínez Ferrándiz" <
<EMAIL_ADDRESS>wrote:

Closed #7164 https://github.com/rg3/youtube-dl/issues/7164.
—
Reply to this email directly or view it on GitHub
https://github.com/rg3/youtube-dl/issues/7164#event-434495681.

You must be doing something wrong:
$ 'http://www.youtube.com/watch?v=BaW_jenozKcj' --get-url
https://r9---sn-h5q7ener.googlevideo.com/videoplayback?id=05a5bf8de9e8cca7&itag=137&source=youtube&requiressl=yes&mv=m&ms=au&mm=31&mn=sn-h5q7ener&pl=19&nh=IgpwcjAyLm1hZDAxKgkxMjcuMC4wLjE&ratebypass=yes&mime=video/mp4&gir=yes&clen=2208750&lmt=1387961822987808&dur=9.800&mt=1444768524&upn=6vpWMeiUWD8&key=dg_yt0&signature=97770FE548C0BE0EE0D51FA57543498997315F08.4BEFED994072A85AA2667EF3562F4569A13E8CF3&sver=3&fexp=9406009,9407156,9408710,9413311,9414764,9416126,9416729,9417707,9418400,9419058,9419426,9419788,9420348,9420531,9420929&ip=<>&ipbits=0&expire=1444790295&sparams=ip,ipbits,expire,id,itag,source,requiressl,mv,ms,mm,mn,pl,nh,ratebypass,mime,gir,clen,lmt,dur
https://r9---sn-h5q7ener.googlevideo.com/videoplayback?id=05a5bf8de9e8cca7&itag=141&source=youtube&requiressl=yes&mv=m&ms=au&mm=31&mn=sn-h5q7ener&pl=19&nh=IgpwcjAyLm1hZDAxKgkxMjcuMC4wLjE&ratebypass=yes&mime=audio/mp4&gir=yes&clen=315992&lmt=1387961817988214&dur=9.891&mt=1444768524&upn=6vpWMeiUWD8&key=dg_yt0&signature=4DD4635D5EAB7823CECE33416877BB6303E195DD.1047B08A583D691356E7C872D66B4A6C78BC53E2&sver=3&fexp=9406009,9407156,9408710,9413311,9414764,9416126,9416729,9417707,9418400,9419058,9419426,9419788,9420348,9420531,9420929&ip=<>&ipbits=0&expire=1444790295&sparams=ip,ipbits,expire,id,itag,source,requiressl,mv,ms,mm,mn,pl,nh,ratebypass,mime,gir,clen,lmt,dur

As explained in the bug reporting instructions, we can only help you if you post the required info to reproduce the problem.


react-hot-loader is deprecated

The package.json is using react-hot-loader. However this has been deprecated (Sept 27 - 3months ago) and points to react-transform-boilerplate as an example of how to replace it.
Admittedly I'm too new to webpack hot loading to put it all together for a cordova example for myself.

I was thinking on updating to babel 6, will update react-HMR once Dan will support babel 6

Now there is support for babel 6 :)

Fixed and actually builds faster :)


Update the example to fit the latest environment & AFL++

[ 2020/12/16 ]
Try make the code works in the following environments:

Ubuntu 20.04
Clang 11
AFL++ 3.0.0c

If I have time though ... Orz

Done via #5

now make a tweet :)


Cotary Create: Step 2 Advanced Mode Improvements

[ ] Advanced mode:

[x] The X to cancel changes made is ambiguous. It's not clear to a user whether or not this saves the changes made.
[x] Saving the config and then opening and closing the mode disables it.
[x] Locking the simple toggles when saving an advanced config without changing their values is misleading as they are not only locked but ignored completely.
[ ] The hour values do not seem to work at all.
[x] Changes made to the advanced mode do not persist to deployment.
[x] Form validation and error handling is inconsistent. Only some errors are detected (and prevent failed saving).
[x] Error messages persist after the issue has been resolved and do not disappear even after closing and reopening the advanced config.
[x] Disabling the advanced config wipes it. There should be a reset button rather than this being the default behaviour.
[x] When the advanced mode is being used, the overview after moving to subsequent steps shows potentially incorrect information.

[x] A lot of typing is missing.

@cbrzn Could you tackle this last bit?

[ ] The hour values do not seem to work at all.

Some combinations of parameters cause deployments to fail.

After extensive testing I found that changing duration fields or percentage fields cause the deployments to fail because it causes the modified migration parameters to have the wrong types.
The percentage fields accept number inputs but the params show them as strings.


impleneted testcase for new object sets

changes -

made entire testcase Thread safe.  Pytest provides a mechanism by which tests can be run in parallell using multiple thread workers. hence i decided to implement syncronization of common functions such as create_volume(),delete_volume() etc.
Although as of today we will not leverage threading as it won't provide much of a performance difference. but in future if more tests are added and ,say,the tests take half an hour to complete , then we can use threading to acheive faster results.
for running pytest with multiple thread worker we need to install a new module called "pytest-xdist"
testcase related to volume, snapshot, volcoll have few common functionality and they should be made thread safe .

-impleneted testcase for new object sets -
README.md            test_access_control_records.py       test_arrays.py       test_events.py
config.ini           test_active_directory_membership.py  test_audit_log.py    test_master_key.py
conftest.py          test_alarms.py                       test_chap_users.py    test_application_categories.py       test_controllers.py
test_application_servers.py          test_disks.py
-Have written the readme file

due to some unwanted files being shown i am closing this PR.. will raise a new one


the stop() function freezes the execution and the sound is disturbed

Hi! I started to use the sounddevice for an implementation of a system that trig the sound when an event occurs and stops when for an other event.
I noted that the stop() function freezes the execution. This happen only on Ubuntu while on Macbook works fine. I didn't understand why.
Moreover,  on Ubuntu when the sounddevice is running in an implementation the sound played is disturbed, i.e. not continuously.  If I use the wait() function works but I can't use it since I need to stop the sound by an event.
On Mackbook everything works with the same code, so I think that the problem is related with Ubuntu.
Can you help me?

the stop() function freezes the execution

Are you calling the stop() function from the same thread as play()?

the sound played is disturbed, i.e. not continuously.

What else happens during playback?
Could you try to come up with a minimal code example that shows those problems?
Without seeing the code and without being able to reproduce it, it's hard to find the cause of those problems.

Hi,
here is a simple code

import sounddevice as sd
import numpy as np

fs = 44100
data = np.random.uniform(-1, 1, 44100*5)
sound = np.int16(data / np.max(np.abs(data)) * 32767)
sd.default.samplerate = fs
sd.play(sound, blocking=False)
sd.stop()

The stop() function freezes the application if the sound doesn't finish playing.

@UmSenhorQualquer Thanks for the code example!
This exposed another error (invalid stream pointer) which was introduced in #75 which I hopefully fixed in 73b260cb4f3f1240de636e29ccf6e0ca90f03d8b.
The error described in this issue seems to only occur with older PortAudio versions.
This should be fixed with #88.
@azi92rach, @UmSenhorQualquer: Can you please check if that works for you?
@azi92rach: I don't know what you mean by "sound played is disturbed", can you please describe this problem in more detail and provide code to reproduce it?

@mgeier thanks to fix the stop() issue. I tested it and it works. @UmSenhorQualquer also for you?
Actually I cannot provide you some example about the "sound disturbed" problem because I running it using hardware that you haven't.
I let you know if I find some example to show you. Anyway now the problem occurs less times than before, maybe fixing the stop() problem you fix also this one. Only some times the sound it is discontinuous.  In attach an example, but I am using an other hardware and other libraries instead of the keyboard.
CODE EXAMPLE:
import sounddevice as sd
import numpy as np
import cv2
fs = 44100
data = np.random.uniform(-1, 1, 44100*5)
sound = np.int16(data / np.max(np.abs(data)) * 32767)
sd.default.samplerate = fs
while(1):
im = np.random.rand(800,800,3)
cv2.imshow('im',im)
a = cv2.waitKey(1) & 0xff
if a == ord('q'): break
elif a == ord('z'):
sd.play(sound, blocking=False)
elif a == ord('x'):
sd.stop()

@azi92rach So you're using OpenCV through the python bindings? This could be the source of your problem. Are you experiencing pauses (momentary silence) in the audio playback? Or is the audio being 'disturbed' in some other way?

@azi92rach Thanks for testing!
As you suspected, your example works fine on my computer.
I'm leaving this issue open for now until we know more about the "disturbed" problem.

@tgarc it was just an example! Actually on my script I am not using openCV.
@mgeier thanks for your time. I hope to resolve it because it is very important for our project.
I will try to explain you my code.
I am using the pybpod-api ibrary (http://pybpod-api.readthedocs.io/en/latest/) to control the Bpod (a hardware used for behavioural experiments).
Actually, when the Bpod catch an event, it send to the computer a byte (a code, e.g. 55). In this case the sound starts to play. Then for an other event (e.g. 66) it stops.
This is the code:
IRtest_sounddevice.txt
I am not sure that this could be useful because you need the hardware to use it.
The problem is that it works perfectly on Macbook, but on Ubuntu there are these very small pauses (momentary silence) in the audio playback. It looks like that the computer is busy some times.

@tgarc it was just an example! Actually on my script I am not using openCV.

It still may be the same issue, especially since you say you have pauses in the audio. I'm wondering if you're not experiencing the same issue as the one reported in #77: namely that some method in your program is holding onto the Python Global Interpreter Lock without letting anyone else interrupt until it is complete (therefore blocking the audio callback).
If you're using python bindings that call into a compiled extension (like a C library), this is likely to be the cause of your issue.

Thank you @tgarc! I will check it.
One thing more is that using the library "pygame" (https://github.com/pygame/pygame) it works fine.
The unique problem is that is slow for my application. The time between an event and the triggering has to be less than 15ms. @mgeier  I saw that sounddevice can play the sound before 15ms.
Moreover, why does this happen only on Ubuntu while on Macbook works fine? I didn't understand it.

why does this happen only on Ubuntu while on Macbook works fine?

If the problem is what I was speculating that could be due to a large variety of reasons. Bad concurrent/multi-threaded code will show different effects on different platforms. It's likely that in a slightly different program mac os would experience the same issue you describe.
I can't really speak to why your program works on pygame since I don't know exactly how the audio streaming works there, but it's perfectly possible and even likely that pygame handles all the audio streaming outside of python. With sounddevice, the audio data is fed directly from python so the audio backend needs access to python at regular intervals.

I would also assume that pygame's audio callback is running without ever directly invoking the Python interpreter. And I guess (but I don't really know) that in order to communicate with Python, it does some buffering on its own, which causes the additional delay.
@azi92rach
You might be able to fine-tune pygame's settings to reduce its buffer sizes?
To avoid the GIL problem, I started implementing https://github.com/mgeier/python-rtmixer/.
This is still quite experimental, but you might try if it works for your use case?

I found the problem on the other library. Thanks!

@azi92rach could you give a brief explanation of how you were able to fix your problem? Just in case someone else runs into the same/similar issue

yes of course! The other library had a loop and it has a function that sleep(0.2) to free the CPU a bit.
So, now I am playing the sounddevice in an other process and it works.


[fix][alpine] thread stack size

Fixes 23348
Main Issue: #23348
Motivation
Alpine pthread stack size is too small. In some cases, the pod will be oomkilled due to "cannot create native thread".
Modifications
Add ENV in dockerfile
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[x] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Alpine pthread stack size is too small. In some cases, the pod will be oomkilled due to "cannot create native thread".

Please share more details of the error message so that it would be possible to find this PR by searching with the error message. It would be great to have a way to reproduce.
Please also share more context for reviewers so that a reviewer could read from some reference what this is about.

This would become obsolete with #23366


POW DNS routing breaks Docker

All my Docker containers couldn't connect to the internet. It took a while to figure out it was POW.

:+1:
Conversely, installing the mac docker beta seems to have broken pow :/

Yes, we have had a lot of reports of issues with pow. If anyone needs a fast track invite to help fix this let me know.

Ooh, I was wrong - docker didn't break pow, that was my VPN.
But pow definitely breaks docker :stuck_out_tongue:

I have an inverse issue, which I'm presuming is related. After starting or stopping Docker for Mac Beta Version 1.11.0-beta6 (build: 5404), Pow port forwarding doesn't work.
I.e., running curl -vH host:pow "<IP_ADDRESS>/status.json" fails with "Connection refused" after starting or stopping Docker.
I found a workaround (from the Troubleshooting guide) to reload packet filter rules fixes Pow, without breaking docker:
sudo pfctl -f /etc/pf.conf; sudo pfctl -e

FYI, I tried using the default packet filter namespace from #521, and that didn't fix broken Pow rules after starting/stopping docker. My pfctl-fu is too weak to debug further.
Also, seems fair to link to the corresponding Docker for Mac forum discussion about Pow.
Both Pow & Docker modify OS X network settings; and it has not (yet) been established what app change could mitigate/resolve the conflict.

any updates on this?

@stereodenis WFM w/ recent Docker for Mac betas: https://forums.docker.com/t/dns-issue-with-building-ruby-image/8060/9

I think this is not directly related to Docker, as I use Veertu for virtualization, which uses native hypervisor.framework from OS X, and I have similar problems with Pow.
As Docker relies on osx native virtualization, I really think the problem is elsewhere.

I have similar problem on Sierra.
It seems it happens when I interrupt program that runs as docker by ^C.
It seems docker does not close something correctly in this case and pow breaks.
None of recipes here worked for me to fix it.
Thing that works for me was to unload and load pow again with these commands:
launchctl unload ~/Library/LaunchAgents/cx.pow.powd.plist
launchctl load     ~/Library/LaunchAgents/cx.pow.powd.plist


Order by id

Hey!
My question, can I messages order by ID?

You are able to call the Thread model any way you'd like. So something like this would work:
$threads = Thread::orderBy('id', 'DESC')->get();

Hey! I mean the the messages in the threads...

Same answer like @cmgmyr, yes you can:
$thread->messages()->orderBy('id', 'desc')->get()

Thanks @Gummibeer I can't find
$messages = $thread->messages()->get()
that I can edit it?...


Switch branches so ODES work is on master

Create new branch to keep current master around for posterity, call it data-pages.
Merge from master to odes-client using “ours” merge strategy so current master is present in history, but clobbered.
Push odes-client to master.
Destroy odes-client branch.
Update Heroku deploy config with new branch location.

master branch now has the ODES work.
This repo is now connected to the Heroku pipeline.
Previous data-pages work is now in date-pages branch.

The odes-client branch is still around, since there are a few PRs connected to it.


RFE: make dnf-json cache garbage collection size rather than time based

Currently dnf-json cleans up caches that are older than 24 hours. This is a good approximation, but we risk deleting useful caches too soon as well as not deleting large caches soon enough, depending on the usage patterns.
Suggestion:
After each depsolve, delete the least recently used cache entries until the total disk usage of the caches fall below a certain threshold.
Implementation suggestion:

Maintain a least recently used list containing the total space usage of each cache entry and its location.
In update_used(), touch() the directory entry on disk and update the LRU (time and size).
In clean_unused() delete the least recently used entries until the total usage falls below a configured threshold.
In CacheState.load() instantiate the LRU by iterating the cache entries in the cache dir (if it exists), read the mtime from the dirent and sum up the file sizes.
Drop CacheState.store().

@lavocatt @achilleas-k @gicmo @Gundersanne @ondrejbudai (and I'm sure others), any thoughts on this? I was having a look at dnf-json to better understand its performance and thinking ahead for supporting both Fedora and 3rd party repos where the behaviour might be quite different from what we saw so far.

I think this makes sense, especially for on-prem situations where a user might not be building things that frequently.


How to add text color in CATextLayer()?

want to apply swift theme color on CATextLayer how to do it?

Just add textLayer.theme_foregroundColor property.


Issue with the Nav bar

In the link https://anveshreddy18-collab.github.io/ there is this issue with the navigation bar at the break points.
To be more clear ,...1) When i minimise the tab to a mobile view, a toggle appears ,When you click on it and maximise the tab to desktop view ,IT WORKS FINE....2) Now when I minimise the Maximised tab (as mentioned in the previous step) then when i click on the toggle bar again ,it goes of as usual , but then comes the real problem ( at least for me!  ) Now try maximising the Tab slowly and y'll notice that the navigation bar disappears..( ushhh ! God knows where it went ).And I want my Navigation bar.So , I think i made my issue clear. Please look into it lemme know where the problem is. Thank you  :) :+1:
Edit: Don't worry about the second page though,It's incomplete.

The mistake has been found and This issue will no longer be active.Thank you :+1:


Labels inside bars; mobile responsive formatting for all labels

closes #1290

got it working (with hard coded cutoff)

Now working using JS to calculate the breakpoint (set at 1/3 of the max value from the dataset). There is a likely a way to do it via Vega using aggregate but I just did it with JS instead

Added same logic to the disparity bar chart... might be worth considering. These labels are longer so compress it horizontally even more, particularly on mobile. This helps with that issue quite a bit.

A few small tweaks to allow labels to display on smallest mobile screens incl multiline titles and small alignment adjustments (on mobile only)

[ ] disable “nice” on mobile to maximize horizontal space


Cookies are not destroyed

Cookies - like session ID cookies - are not destroyed when asked by the server.
Example
After sending a 'log out' request, the server response contains the following header:
Set-Cookie: session=; Max-Age=-86400; Expires=Wed, 08 Jun 2016 09:50:30 GMT; Path=/; HTTPOnly
Expected outcome
The 'session' cookie should be destroyed and not be sent with the next requests.
Actual outcome
Following requests contain the 'session' cookie.
Versions
App: <IP_ADDRESS>-stable
Chrome: 51.0.2704.84
Platform: Windows (10)

Hi,
Thank you for issue report.
It looks like the cookie store do not remove cookies when the time expired. It should be fixed.

This issue seems to be in the latest version again.
Set-Cookie header with expire date some when in the past are not destroyed and resend with the next request.
App: <IP_ADDRESS>5-stable
Chrome: 59.0.3071.115
Platform: Windows (10)


All target incorrect for Xcode

I'm not sure if this is the case across-the-board, but in my experience so far the default 'all' target for Xcode projects produced by CMake is ALL_BUILD, just like with Visual Studio. However on common.ts the function 'get allTargetName()' only returns ALL_BUILD for VS and all otherwise, with:
return (gen && /Visual Studio/.test(gen)) ? 'ALL_BUILD' : 'all';
Perhaps this needs an OR with /Xcode/.test(gen) or however the extension refers to Xcode?

So sorry for the delay! I've been busy.
Thanks for investigating this issue. I'll get on it as soon as possible.

Thanks so much, I really appreciate your work.

Also seeing this. Xcode project definitely has ALL_BUILD instead of all as the target.
xcodebuild: error: The project 'hello-vsc.xcodeproj' does not contain a target named 'all'.


CanvasKit renderer will permanently crash if an error is encountered while rendering a frame

Steps to reproduce
Cause the renderer to experience issues rendering a frame.
While investigating #145134, I tried to stress the GC and a bit by intentionally forcing temporary low memory conditions and see if forcing the use of the FinalizationRegistry would surface the table index out of bounds error that we occasionally see.
The sample code here will force low memory conditions temporarily, which the FinalizationRegistry will eventually clean up. When these temporary low memory conditions cause a single frame to have an error, the rendering for the app will permanently stop.
The next frame should always be scheduled in the renderer, even if the current frame fails to render.
Expected results
Rendering should not crash permanently
Actual results
Rendering will stop and never resume
Code sample
Code sample
// Copyright 2019 the Dart project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:flutter/src/painting/binding.dart';
import 'package:google_fonts/google_fonts.dart';

void main() {
  Future.delayed(Duration(seconds: 5), () {
    paint();
    updateFonts();
  });
  runApp(const MyApp());
}

final lines = <TextPainter>[];
final random = Random();

void paint() {
  try {
    final pr = PictureRecorder();
    final c = Canvas(pr);
    for (var i = 0; i < 10000; i++) {
      final tp = TextPainter(
          text: TextSpan(text: ' ', style: GoogleFonts.heebo()),
          textDirection: TextDirection.ltr,
          strutStyle: StrutStyle.fromTextStyle(GoogleFonts.heebo(),
              forceStrutHeight: true));

      tp.text = const TextSpan(text: "test2");

      tp.preferredLineHeight;

      tp.layout();

      tp.paint(c, Offset.zero);
      lines.add(tp);
    }
    pr.endRecording();
  } catch (err) {
    lines.clear();

    print(err);
  }

  Future.delayed(Duration(milliseconds: random.nextInt(1000)), paint);

  //updateFonts();
}

void updateFonts() {
  try {
    PaintingBinding.instance.handleSystemMessage({"type": "fontsChange"});
  } catch (err) {
    lines.clear();

    print(err);
  }
  Future.delayed(Duration(milliseconds: random.nextInt(10000)), updateFonts);
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  final String title;

  const MyHomePage({
    super.key,
    required this.title,
  });

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Container(),
      ),
      body: Stack(children: [
        for (var i = 0; i < 10; i++)
          Positioned(
              top: i * 30,
              width: 100,
              height: 30,
              left: 0,
              child: Container(
                  decoration: const BoxDecoration(color: Colors.white),
                  //clipBehavior: Clip.none,
                  child: OutlinedButton(
                      onPressed: () {}, child: const Text("test")))),
      ]),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

Should only take a couple minutes to run into the problem with this code.

Thanks for the report. I was able to replicate this using latest stable and master versions and it gives below log in console:
A Dart VM Service on Chrome is available at: http://<IP_ADDRESS>:53371/PHKoG3q8hVM=
The Flutter DevTools debugger and profiler on Chrome is available at: http://<IP_ADDRESS>:9100?uri=http://<IP_ADDRESS>:53371/PHKoG3q8hVM=
Aborted()
RuntimeError: Aborted(). Build with -sASSERTIONS for more info.
Aborted()
RuntimeError: Aborted(). Build with -sASSERTIONS for more info.
Aborted()
RuntimeError: Aborted(). Build with -sASSERTIONS for more info.
 Flutter (Channel stable, 3.19.3, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.19.3 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ba39319843 (5 days ago), 2024-03-07 15:22:21 -0600
    • Engine revision 2e4ba9c6fb
    • Dart version 3.3.1
    • DevTools version 2.31.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.21.0-9.0.pre.33, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.21.0-9.0.pre.33 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dd865ce476 (5 hours ago), 2024-03-17 20:24:27 -0400
    • Engine revision 89c7759639
    • Dart version 3.4.0 (build 3.4.0-242.0.dev)
    • DevTools version 2.33.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

TextPainter expects that dispose is called when you're done with it. Does the issue still happen if you dispose of the painter after you call tp.paint(...)?

I'd be also curious if the leak tracking functionality in package:flutter_test would catch this for numbers much smaller than 10000.

@yjbanov yes, it will still happen because the problem here is that any exception inside the renderer will cause bad behavior. In practice dispose should be called, but the finalization registry is successfullly disposing the objects when the GC kicks in and the memory does get freed so for the purpose of the sample the behavior is the same. This code has been useful to me to track down a lot of issues where the renderer only handles happy path and leaks or entirely crashes without scheduling a new frame. For example, PictureRecorder doesn't even implement dispose, which means you can't even properly throw away a PictureRecorder if endRecording fails due to OOM. In this sample, the OOM is temporary and the client eventually cleans up it's state, but once the memory frees back up the renderer is totally broken because it doesn't even attempt to handle exceptions or ensure that things like PictureRecorder always get deleted in a finally block.

I can see how adding more ways to clean-up the C++ heap can help with this situation, such as dispose() methods on PictureRecorder, Path, Paint, etc. However, I don't yet see a clean catch-all solution that would handle this automatically, other than the FinalizationRegistry wired up for all disposable objects. The only practical way to reduce the risk of getting into the "permanently crashed" situation is to identify individual resources that are the biggest contributors to this issue and wiring them up one by one, until the risk becomes low enough to not matter any more.
To that end I recommend filing individual issues similar to https://github.com/flutter/flutter/issues/146278, and fixing them one by one. I'm going to close this issue as I don't think it's practical to address it in one fell swoop.


[BUTTON IDEA]: Icon Fill Button

1. Name of button:
Icon Fill Button
2. Description:
White Button with colored Icon and Border and black text. On Hover the text fills up with the color of the Icon.
3. Button Type (Animated, Special, etc...):
Icon / Animated
4. Will you work on it?:
yes

should we do this with less itself or css and html, if its with less, i could try to do it, please assign it to me

Hello @BeniB98 I'm not sure about what the icon will look like, so either show me a pic or video of it or submit a PR and I'll have to decide then if I can accept it or not.
Either way I'll assign you

https://user-images.githubusercontent.com/49996504/107936628-29588c80-6f83-11eb-86a1-91ecb550b474.mp4
Hey @shahednasser, thanks for assigning me! I thought of something like this. What do you think about it?

I think the button looks good without the icon and maybe with some padding. If you can make the button but with different colors like in the website then that would be great.

Hey @shahednasser, i'm sorry but currently i don't have the time to work on the Issue. Maybe @alok1929, or anyone else, still want to work on it?

Sure I'll leave it open if anyone else wants to work on it

I could try to do it , would like to be assigned for this @shahednasser

Sure @alok1929 I'll assign you

Hello @alok1929 are you still working on this?

No I am not ,I have my exams going on ,so I might not be able to do it . .
....
On Sat, 6 Mar, 2021, 1:48 am Shahed Nasser<EMAIL_ADDRESS>wrote:

Hello @alok1929 https://github.com/alok1929 are you still working on
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sButtons/sbuttons/issues/1294#issuecomment-791659686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMIBOVVDN7LHHUYM3EWM6VLTCE4CTANCNFSM4XLPHIGQ
.

Alright I'll be unassigning you in case someone else can take this up

Alright I'll be closing this for now then


[FX-1332] Typed SDK response helpers

What
Introduce: toPaymentMethod(), toBalance, toPayment

Introduce types/helpers for casting SDK responses (JSON string -> PaymentMethod, Balance, Payment, ...) ; non-breaking!
Added Kdoc comments
Update existing internal code + tests to be compatible
[x] Add more unit tests

The new toPaymentMethod, toBalance, toPayment are primarily intended for e-commerce use, and similar methods can be introduced for POS-specific types and differences (refunds, ...)

Why

Used sealed classes for Balance + Card, like we do for ebt_error_51, to make the interfaces extensible to other payment method types

Used Parcelable to help serialize responses ; seems conventional

Technical Design Document

Test Plan

✅ Updated unit tests
✅ Call toPaymentMethod, toBalance, toPayment

How

MINOR-level version change

Thanks for all your effort in this PR, Danilo. My remaining questions are:

were the .idea/ files intentionally included in the PR?
Is it necessary to include the empty interface Balance right now?
can we drop EbtBalance.fromSdkResponse(data as String) with another constructor?

@devinmorgan

bb596f3665535f306e5c82ff39cc8f7b73bc0c6b nice catch ; accident

replied: https://github.com/teamforage/forage-android-sdk/pull/249#discussion_r1592622026

replied: https://github.com/teamforage/forage-android-sdk/pull/249#discussion_r1592594254

The only point I'd like clarity on is the null-safety when parsing each of the models using jsonObject.get<type>(). Will this potentially introduce the same issue just seen in iOS in the future?

@dleis612 Great point! Correct, we'll always have this concern of typed responses + strictness in our mobile SDKs. However, to de-risk this issue:

I've refactored the internal GET /payments/ call to only grab the data that is needed (paymentMethodRef) for the preliminary requests
I've only exposed fields that are meaningful to SDK consumers.
I've written unit tests in this PR to cover all of the cases where fields are missing to prevent regressions.
Our E2E tests will cover + prevent issues with "empty/thin" Payments. Linear ticket


[BUG] swiping does not take to next image after current image is deleted

Describe the bug
swiping does not take to next image after current image is deleted.
To Reproduce
Steps to reproduce the behavior:

Open an image
Delete using the delete button
Image us deleted and next image is shown
Swipe right to see the next image

Expected behavior
Next image is shown after a single right swipe.
Actual behavior
Next image is shown after two swipes, first swipe shows the image that was automatically brought when current image ws deleted.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: Google Pixel 8
Android 14
Version 3.0.1

Additional context
Add any other context about the problem here.

latest image from github didn't have this issue. closing. the one from f-droid has it though.