No module named 'tensorrt_bindings'

Expected Behavior
When I try to create a TensorRT Engine out of SDXL model I expect that the TensorRT module will be installed and the engine will be generated.
Actual Behavior
The mail issue is the errors in the console and no results in the engine generation.
Also SwarmUI for some reason doesn't see that TensorRT was not installed in ComfyUI, and it prompts user to generate the engine after the failed installation.
Steps to Reproduce

Click on SDXL model menu and choose Create TensorRT Engine. The following message will appear:

Click the Install button.
ComfyUI will be reloaded. The error will appeared in the console. See the log
The following dialog will be displayed:

Debug Logs
2024-08-08 00:22:04.386 [Init] === SwarmUI v<IP_ADDRESS> Starting at 2024-08-08 00:22:04 ===
2024-08-08 00:22:04.408 [Init] Prepping extension: SwarmUI.Builtin_ScorersExtension.ScorersExtension...
2024-08-08 00:22:04.413 [Init] Prepping extension: SwarmUI.Builtin_ImageBatchToolExtension.ImageBatchToolExtension...
2024-08-08 00:22:04.414 [Init] Prepping extension: SwarmUI.Builtin_GridGeneratorExtension.GridGeneratorExtension...
2024-08-08 00:22:04.414 [Init] Prepping extension: SwarmUI.Builtin_DynamicThresholding.DynamicThresholdingExtension...
2024-08-08 00:22:04.414 [Init] Prepping extension: SwarmUI.Builtin_ComfyUIBackend.ComfyUIBackendExtension...
2024-08-08 00:22:04.415 [Init] Prepping extension: SwarmUI.Builtin_AutoWebUIExtension.AutoWebUIBackendExtension...
2024-08-08 00:22:04.435 [Init] Parsing command line...
2024-08-08 00:22:04.436 [Init] Loading settings file...
2024-08-08 00:22:04.449 [Init] Re-saving settings file...
2024-08-08 00:22:04.460 [Init] Applying command line settings...
2024-08-08 00:22:04.475 [Init] Prepping options...
2024-08-08 00:22:04.503 [Init] Current git commit marked as date 2024-08-07 19:26:26
2024-08-08 00:22:04.563 [Init] Loading models list...
2024-08-08 00:22:04.576 [Init] CPU Cores: 28 | RAM: 63.71 GiB total, 52.40 GiB available
2024-08-08 00:22:04.576 [Init] GPU 0: NVIDIA GeForce RTX 4080 SUPER | Temp 49C | Util 9% GPU, 4% Memory | VRAM 15.99 GiB total, 13.29 GiB free, 2.38 GiB used
2024-08-08 00:22:04.578 [Init] Loading backends...
2024-08-08 00:22:04.579 [Init] Loading backends from file...
2024-08-08 00:22:04.581 [Init] Prepping API...
2024-08-08 00:22:04.581 [Init] Initializing backend #0 - ComfyUI Self-Starting...
2024-08-08 00:22:04.582 [Init] Prepping webserver...
2024-08-08 00:22:04.584 [Init] Backend request handler loop ready...
2024-08-08 00:22:04.669 [Init] Scan for web extensions...
2024-08-08 00:22:04.671 [Init] Readying extensions for launch...
2024-08-08 00:22:04.671 [Init] Launching server...
2024-08-08 00:22:04.671 [Init] Starting webserver on http://localhost:7801
2024-08-08 00:22:05.155 [Init] Swarm is up to date! You have version <IP_ADDRESS>, and 0.9.1-Beta is the latest.
2024-08-08 00:22:05.155 [Init] Program is running.
2024-08-08 00:22:05.658 [Init] Launch web browser...
2024-08-08 00:22:05.947 [Info] Creating new admin session 'local' for ::1
2024-08-08 00:22:05.954 [Init] Self-Start ComfyUI-0 on port 7821 is loading...
2024-08-08 00:22:08.105 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
2024-08-08 00:22:08.105 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\nodes.py", line 1941, in load_custom_node
2024-08-08 00:22:08.106 [Warning] [ComfyUI-0/STDERR]     module_spec.loader.exec_module(module)
2024-08-08 00:22:08.107 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
2024-08-08 00:22:08.107 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
2024-08-08 00:22:08.107 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT\__init__.py", line 1, in <module>
2024-08-08 00:22:08.108 [Warning] [ComfyUI-0/STDERR]     from .tensorrt_convert import DYNAMIC_TRT_MODEL_CONVERSION
2024-08-08 00:22:08.108 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT\tensorrt_convert.py", line 7, in <module>
2024-08-08 00:22:08.108 [Warning] [ComfyUI-0/STDERR]     import tensorrt as trt
2024-08-08 00:22:08.109 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded\Lib\site-packages\tensorrt\__init__.py", line 18, in <module>
2024-08-08 00:22:08.110 [Warning] [ComfyUI-0/STDERR]     from tensorrt_bindings import *
2024-08-08 00:22:08.110 [Warning] [ComfyUI-0/STDERR] ModuleNotFoundError: No module named 'tensorrt_bindings'
2024-08-08 00:22:08.110 [Warning] [ComfyUI-0/STDERR]
2024-08-08 00:22:08.111 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
2024-08-08 00:22:08.111 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\nodes.py", line 1941, in load_custom_node
2024-08-08 00:22:08.111 [Warning] [ComfyUI-0/STDERR]     module_spec.loader.exec_module(module)
2024-08-08 00:22:08.112 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
2024-08-08 00:22:08.112 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
2024-08-08 00:22:08.112 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT\__init__.py", line 1, in <module>
2024-08-08 00:22:08.113 [Warning] [ComfyUI-0/STDERR]     from .tensorrt_convert import DYNAMIC_TRT_MODEL_CONVERSION
2024-08-08 00:22:08.113 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT\tensorrt_convert.py", line 7, in <module>
2024-08-08 00:22:08.113 [Warning] [ComfyUI-0/STDERR]     import tensorrt as trt
2024-08-08 00:22:08.114 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded\Lib\site-packages\tensorrt\__init__.py", line 18, in <module>
2024-08-08 00:22:08.114 [Warning] [ComfyUI-0/STDERR]     from tensorrt_bindings import *
2024-08-08 00:22:08.114 [Warning] [ComfyUI-0/STDERR] ModuleNotFoundError: No module named 'tensorrt_bindings'
2024-08-08 00:22:08.115 [Warning] [ComfyUI-0/STDERR]
2024-08-08 00:22:09.042 [Init] Self-Start ComfyUI-0 on port 7821 started.
2024-08-08 00:22:43.417 [Info] ComfyUI backend 0 shutting down...
2024-08-08 00:22:43.417 [Info] Shutting down self-start ComfyUI (port=7821) process #6400...
2024-08-08 00:22:43.446 [Info] Self-Start ComfyUI-0 exited properly from disabling.
2024-08-08 00:22:45.181 [Init] Initializing backend #0 - ComfyUI Self-Starting...
2024-08-08 00:22:46.621 [Init] Self-Start ComfyUI-0 on port 7822 is loading...
2024-08-08 00:22:48.744 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
2024-08-08 00:22:48.745 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\nodes.py", line 1941, in load_custom_node
2024-08-08 00:22:48.746 [Warning] [ComfyUI-0/STDERR]     module_spec.loader.exec_module(module)
2024-08-08 00:22:48.746 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
2024-08-08 00:22:48.746 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
2024-08-08 00:22:48.746 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT\__init__.py", line 1, in <module>
2024-08-08 00:22:48.746 [Warning] [ComfyUI-0/STDERR]     from .tensorrt_convert import DYNAMIC_TRT_MODEL_CONVERSION
2024-08-08 00:22:48.747 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT\tensorrt_convert.py", line 7, in <module>
2024-08-08 00:22:48.747 [Warning] [ComfyUI-0/STDERR]     import tensorrt as trt
2024-08-08 00:22:48.747 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded\Lib\site-packages\tensorrt\__init__.py", line 18, in <module>
2024-08-08 00:22:48.747 [Warning] [ComfyUI-0/STDERR]     from tensorrt_bindings import *
2024-08-08 00:22:48.748 [Warning] [ComfyUI-0/STDERR] ModuleNotFoundError: No module named 'tensorrt_bindings'
2024-08-08 00:22:48.749 [Warning] [ComfyUI-0/STDERR]
2024-08-08 00:22:48.750 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
2024-08-08 00:22:48.750 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\nodes.py", line 1941, in load_custom_node
2024-08-08 00:22:48.750 [Warning] [ComfyUI-0/STDERR]     module_spec.loader.exec_module(module)
2024-08-08 00:22:48.750 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap_external>", line 940, in exec_module
2024-08-08 00:22:48.751 [Warning] [ComfyUI-0/STDERR]   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
2024-08-08 00:22:48.751 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT\__init__.py", line 1, in <module>
2024-08-08 00:22:48.751 [Warning] [ComfyUI-0/STDERR]     from .tensorrt_convert import DYNAMIC_TRT_MODEL_CONVERSION
2024-08-08 00:22:48.752 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT\tensorrt_convert.py", line 7, in <module>
2024-08-08 00:22:48.752 [Warning] [ComfyUI-0/STDERR]     import tensorrt as trt
2024-08-08 00:22:48.752 [Warning] [ComfyUI-0/STDERR]   File "E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded\Lib\site-packages\tensorrt\__init__.py", line 18, in <module>
2024-08-08 00:22:48.753 [Warning] [ComfyUI-0/STDERR]     from tensorrt_bindings import *
2024-08-08 00:22:48.755 [Warning] [ComfyUI-0/STDERR] ModuleNotFoundError: No module named 'tensorrt_bindings'
2024-08-08 00:22:48.755 [Warning] [ComfyUI-0/STDERR]
2024-08-08 00:22:49.665 [Init] Self-Start ComfyUI-0 on port 7822 started.
2024-08-08 00:22:04.467 [Debug] [Load Time] Initial settings load took 0.08s (0.08s from start)
2024-08-08 00:22:04.475 [Debug] [Load Time] Extension PreInit took 0s (0.08s from start)
2024-08-08 00:22:04.537 [Debug] [Load Time] Prep Objects took 0.06s (0.14s from start)
2024-08-08 00:22:04.537 [Debug] [Load Time] Web PreInit took 0s (0.14s from start)
2024-08-08 00:22:04.543 [Debug] [Load Time] Extensions Init took 0s (0.14s from start)
2024-08-08 00:22:04.543 [Debug] [Load Time] Prep Utils took 0.02s (0.16s from start)
2024-08-08 00:22:04.563 [Debug] [Load Time] Languages load took 0.02s (0.17s from start)
2024-08-08 00:22:04.578 [Debug] [Load Time] Model listing took 0.02s (0.19s from start)
2024-08-08 00:22:04.580 [Debug] [Load ComfyUI Self-Starting #0] Waiting to load...
2024-08-08 00:22:04.581 [Debug] [Load Time] Backends took 0s (0.19s from start)
2024-08-08 00:22:04.581 [Debug] [Load ComfyUI Self-Starting #0] Will now load...
2024-08-08 00:22:04.582 [Debug] [Load Time] API took 0s (0.19s from start)
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Starting init...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Will emit comfy model paths file...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Done emitting comfy model paths file.
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Will add args:  --extra-model-paths-config E:\Soft\AI\Images\SwarmUI\Data/comfy-auto-model.yaml --preview-method latent2rgb
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Will track node repo load task...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Will track comfy git pull auto-update task...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Waiting on git tasks to complete...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Running git pull in comfy folder...
2024-08-08 00:22:04.583 [Debug] [Load ComfyUI Self-Starting #0] Will ensure all node repos...
2024-08-08 00:22:04.584 [Debug] [Load ComfyUI Self-Starting #0] Will ensure node repo 'https://github.com/mcmonkeyprojects/sd-dynamic-thresholding'...
2024-08-08 00:22:04.584 [Debug] [Load ComfyUI Self-Starting #0] Will ensure node repo 'https://github.com/Stability-AI/ComfyUI-SAI_API'...
2024-08-08 00:22:04.584 [Debug] [Load ComfyUI Self-Starting #0] Node folder 'sd-dynamic-thresholding' exists, will git pull it...
2024-08-08 00:22:04.584 [Debug] [Load ComfyUI Self-Starting #0] Node folder 'ComfyUI-SAI_API' exists, will git pull it...
2024-08-08 00:22:04.608 [Debug] [Load Time] [Web] WebApp builder prep took 0.03s (0.03s from start)
2024-08-08 00:22:04.637 [Debug] [Load Time] [Web] WebApp build took 0.02s (0.05s from start)
2024-08-08 00:22:04.637 [Debug] [Load Time] [Web] exception handler took 0s (0.05s from start)
2024-08-08 00:22:04.637 [Debug] [Load Time] [Web] StartStop handler took 0s (0.05s from start)
2024-08-08 00:22:04.637 [Debug] [Load Time] [Web] static files took 0s (0.05s from start)
2024-08-08 00:22:04.668 [Debug] [Load Time] [Web] core use calls took 0.03s (0.08s from start)
2024-08-08 00:22:04.669 [Debug] [Load Time] [Web] core maps took 0.02s (0.09s from start)
2024-08-08 00:22:04.671 [Debug] [Load Time] [Web] end took 0s (0.09s from start)
2024-08-08 00:22:04.671 [Debug] [Load Time] Web prep took 0.09s (0.28s from start)
2024-08-08 00:22:04.671 [Debug] [Load Time] Extensions pre-launch took 0s (0.28s from start)
2024-08-08 00:22:04.693 [Debug] [Load Time] Web launch took 0.02s (0.3s from start)
2024-08-08 00:22:05.236 [Debug] [Load ComfyUI Self-Starting #0] Node pull response for ComfyUI-SAI_API: Already up to date.
2024-08-08 00:22:05.237 [Debug] [Load ComfyUI Self-Starting #0] Comfy git pull response: Already up to date.
2024-08-08 00:22:05.246 [Debug] [Load ComfyUI Self-Starting #0] Node pull response for sd-dynamic-thresholding: Already up to date.
2024-08-08 00:22:05.247 [Debug] [Load ComfyUI Self-Starting #0] Ensure node repos - Will git pull for ComfyUI-SAI_API...
2024-08-08 00:22:05.247 [Debug] [Load ComfyUI Self-Starting #0] Ensure node repos - Will git pull for ComfyUI_TensorRT...
2024-08-08 00:22:05.247 [Debug] [Load ComfyUI Self-Starting #0] Ensure node repos - Will git pull for sd-dynamic-thresholding...
2024-08-08 00:22:05.910 [Debug] [Load ComfyUI Self-Starting #0] Node pull response for sd-dynamic-thresholding: Already up to date.
2024-08-08 00:22:05.930 [Debug] [Load ComfyUI Self-Starting #0] Node pull response for ComfyUI-SAI_API: Already up to date.
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] Node pull response for ComfyUI_TensorRT: Already up to date.
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] Done ensuring all node repos.
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] All tasks done.
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] Will validate required libs...
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] Done validating required libs.
2024-08-08 00:22:05.949 [Debug] [Load ComfyUI Self-Starting #0] Starting self-start ComfyUI process...
2024-08-08 00:22:05.950 [Debug] [Load ComfyUI Self-Starting #0] Requested generic launch of dlbackend/comfy/ComfyUI/main.py on GPU 0 from ComfyUI-0
2024-08-08 00:22:05.951 [Debug] (ComfyUI-0 launch) Adding path E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded
2024-08-08 00:22:05.952 [Debug] [Load ComfyUI Self-Starting #0] (ComfyUI-0 launch) Will use python: E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\python_embeded\python.exe
2024-08-08 00:22:05.952 [Debug] [Load ComfyUI Self-Starting #0] Will start process...
2024-08-08 00:22:06.922 [Debug] [ComfyUI-0/STDERR] Total VRAM 16376 MB, total RAM 65244 MB
2024-08-08 00:22:06.922 [Debug] [ComfyUI-0/STDERR] pytorch version: 2.3.1+cu121
2024-08-08 00:22:06.922 [Debug] [ComfyUI-0/STDERR] Set vram state to: NORMAL_VRAM
2024-08-08 00:22:06.922 [Debug] [ComfyUI-0/STDERR] Device: cuda:0 NVIDIA GeForce RTX 4080 SUPER : cudaMallocAsync
2024-08-08 00:22:06.959 [Debug] [Load ComfyUI Self-Starting #0] Will attempt to load value set...
2024-08-08 00:22:07.439 [Debug] [ComfyUI-0/STDERR] Using pytorch cross attention
2024-08-08 00:22:07.942 [Debug] [ComfyUI-0/STDERR] [Prompt Server] web root: E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\web
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path checkpoints E:\Soft\AI\Images\SwarmUI\Models\Stable-Diffusion
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path vae E:\Soft\AI\Images\SwarmUI\Models\VAE
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path vae E:\Soft\AI\Images\SwarmUI\Models\VAE
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path loras E:\Soft\AI\Images\SwarmUI\Models\Lora
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path loras E:\Soft\AI\Images\SwarmUI\Models\Lora
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path loras E:\Soft\AI\Images\SwarmUI\Models\LyCORIS
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path upscale_models E:\Soft\AI\Images\SwarmUI\Models\ESRGAN
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path upscale_models E:\Soft\AI\Images\SwarmUI\Models\RealESRGAN
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path upscale_models E:\Soft\AI\Images\SwarmUI\Models\SwinIR
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path upscale_models E:\Soft\AI\Images\SwarmUI\Models\upscale-models
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path upscale_models E:\Soft\AI\Images\SwarmUI\Models\upscale_models
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path embeddings E:\Soft\AI\Images\SwarmUI\Models\Embeddings
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path embeddings E:\Soft\AI\Images\SwarmUI\Models\embeddings
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path hypernetworks E:\Soft\AI\Images\SwarmUI\Models\hypernetworks
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path controlnet E:\Soft\AI\Images\SwarmUI\Models\controlnet
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path controlnet E:\Soft\AI\Images\SwarmUI\Models\ControlNet
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path clip_vision E:\Soft\AI\Images\SwarmUI\Models\clip_vision
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path clip_vision E:\Soft\AI\Images\SwarmUI\Models\clip_vision
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path clip E:\Soft\AI\Images\SwarmUI\Models\clip
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path unet E:\Soft\AI\Images\SwarmUI\Models\unet
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path gligen E:\Soft\AI\Images\SwarmUI\Models\gligen
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path ipadapter E:\Soft\AI\Images\SwarmUI\Models\ipadapter
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path yolov8 E:\Soft\AI\Images\SwarmUI\Models\yolov8
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path tensorrt E:\Soft\AI\Images\SwarmUI\Models\tensorrt
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path clipseg E:\Soft\AI\Images\SwarmUI\Models\clipseg
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path custom_nodes E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes
2024-08-08 00:22:07.944 [Debug] [ComfyUI-0/STDERR] Adding extra search path custom_nodes E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\ExtraNodes
2024-08-08 00:22:08.111 [Debug] [ComfyUI-0/STDERR] Cannot import E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT module for custom nodes: No module named 'tensorrt_bindings'
2024-08-08 00:22:08.115 [Debug] [ComfyUI-0/STDERR] Cannot import E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT module for custom nodes: No module named 'tensorrt_bindings'
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR] Import times for custom nodes:
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.0 seconds: E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\websocket_image_save.py
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.0 seconds: E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\sd-dynamic-thresholding
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.0 seconds: E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI-SAI_API
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.0 seconds (IMPORT FAILED): E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\DLNodes\ComfyUI_TensorRT
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.0 seconds (IMPORT FAILED): E:\Soft\AI\Images\SwarmUI\dlbackend\comfy\ComfyUI\custom_nodes\ComfyUI_TensorRT
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.1 seconds: E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\ExtraNodes\SwarmComfyCommon
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]    0.6 seconds: E:\Soft\AI\Images\SwarmUI\src\BuiltinExtensions\ComfyUIBackend\ExtraNodes\SwarmComfyExtra
2024-08-08 00:22:08.808 [Debug] [ComfyUI-0/STDERR]
2024-08-08 00:22:08.810 [Debug] [ComfyUI-0/STDERR] Starting server
2024-08-08 00:22:08.810 [Debug] [ComfyUI-0/STDERR]
2024-08-08 00:22:08.810 [Debug] [ComfyUI-0/STDERR] To see the GUI go to: http://<IP_ADDRESS>:7821
2024-08-08 00:22:09.040 [Debug] [Load ComfyUI Self-Starting #0] Got valid value set, will parse...
2024-08-08 00:22:09.040 [Debug] Comfy backend 0 using model folder format: backslash \ due to model Flux\flux1-dev-fp8.safetensors
2024-08-08 00:22:09.042 [Debug] [Load ComfyUI Self-Starting #0] Done parsing value set.
2024-08-08 00:22:09.042 [Debug] [Load ComfyUI Self-Starting #0] Done!  Started!
2024-08-08 00:22:49.667 [Debug] [Load ComfyUI Self-Starting #0] ComfyUI-0 self-start port 7822 loop ending (should now be alive)
2024-08-08 00:22:51.447 [Debug] [Load ComfyUI Self-Starting #0] Got valid value set, will parse...
2024-08-08 00:22:51.447 [Debug] Comfy backend 0 using model folder format: backslash \ due to model Flux\flux1-dev-fp8.safetensors
2024-08-08 00:22:51.447 [Debug] [Load ComfyUI Self-Starting #0] Done parsing value set.
2024-08-08 00:22:51.449 [Debug] Data refreshed!

Other
No response

This is an upstream error with the tensorrt lib
@maedtb PR'd a fix https://github.com/comfyanonymous/ComfyUI_TensorRT/pull/56 which got pulled but then removed for some reason??


How can I add None Selected value to Single Select?

I think the question describes all.

Hi @vicheanak ,
Sorry for the late reply. Unfortunately you'll need to modify the code yourself to do this.

@isteven, why can't this feature be added to this project?
This is just a matter of a line.
isteven-multi-select.js#L940


fix: networkinterfacenetwork set nil virtual object

这个 PR 实现什么功能/修复什么问题:
修正：networkinterfacenetwork nil pointer导致region启动失败
是否需要 backport 到之前的 release 分支:

release/2.11.0

/area region
/cc @ioito @yousong @Zexi

Codecov Report

Merging #1898 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #1898   +/-   ##
======================================
  Coverage    7.53%   7.53%
======================================
  Files         418     418
  Lines       64735   64735
======================================
  Hits         4875    4875
  Misses      59450   59450
  Partials      410     410

Flag
Coverage Δ

#aFlag
7.53% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/networkinterfaces.go
6.04% <ø> (ø)
:arrow_up:

pkg/compute/models/networkinterfacenetwork.go
0.98% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2884035...2a0179b. Read the comment docs.

/lgtm
/approve


Update dep for Browserify 12.x.x

Please and thank you :)

done<EMAIL_ADDRESS>

Thank you kindly :)


🐛 [firebase_auth] user doesn't seem to be persistent in local storage

I am using firebase on web. I have the following auth provider, and I can sign the user in and the app state changes. But when I do a sign in I notice that nothing is stored in the local storage and when I refresh the page the authStateChanges gives null for the user. I also just tried tho get the current user as a Future which also returns null. What am I doing wrong?
    const String oneTimePasswordFunctionName = "requestOneTimePassword";
    const String signInWithOneTimePasswordFunctionName = "signInWithOneTimePassword";

    class FirebaseAuthProvider extends AuthProvider {
      final FirebaseAuth _firebaseAuth = FirebaseAuth.instance;
      final FirebaseFunctions _firebaseFunctions = FirebaseFunctions.instance;

      Stream<AuthUser> get user {
        return _firebaseAuth.authStateChanges().asyncMap((firebaseUser) {
          //firebaseUser is always null on refresh
          return firebaseUser == null ? AuthUser.empty : firebaseUser.toUser();
        });
      }

      Future<void> requestOneTimePassword({required String email}) async {
        final data = {"email": email};
        final cloudFunction = _firebaseFunctions.httpsCallable(oneTimePasswordFunctionName);
        await cloudFunction.call(data);
      }

      Future<void> signInWithOneTimePassword({required String email, required String oneTimePassword}) async {
        final data = {"email": email, "oneTimePassword": oneTimePassword};
        final cloudFunction = _firebaseFunctions.httpsCallable(signInWithOneTimePasswordFunctionName);
        final result = await cloudFunction.call(data);
        final jwt = result.data["data"]["jwt"] as String;
        if (jwt.isEmpty) return;
        await FirebaseAuth.instance.setPersistence(Persistence.LOCAL);
        await _firebaseAuth.signInWithCustomToken(jwt);
      }

      Future<void> signOut() async {
        try {
          await _firebaseAuth.signOut();
        } on Exception {
          throw SignOutException();
        }
      }
    }

    extension on User {
      FutureOr<AuthUser> toUser() async {
        final tokenResult = await this.getIdTokenResult(true);
        final claims = tokenResult.claims?.map<String, String>((key, value) => MapEntry(key, value.toString()));

        return AuthUser(
          id: uid,
          email: Email.dirty(email ?? ''),
          name: displayName ?? '',
          photoURL: Uri.parse(photoURL ?? ''),
          claims: claims ?? const {},
        );
      }
    }

I really need it to work with the authStateChanges stream, because I want it also to work when the user does a sign out.
I am using the firebase auth emulator. This is my main
void main() async {
   WidgetsFlutterBinding.ensureInitialized();

   await FirebaseAuth.instance.useAuthEmulator("localhost", 9099);

   FirebaseFirestore.instance.settings = Settings(
     host: "localhost:8080",
     sslEnabled: false,
     persistenceEnabled: false,
   );

   FirebaseFunctions.instance.useFunctionsEmulator("localhost", 5001);

   Future<dynamic> Function() initializeFirebase = () async {
     if (Firebase.apps.length == 0) await Firebase.initializeApp();
   };

   await Future.wait([
     initializeFirebase(),
     EasyLocalization.ensureInitialized(),
   ]);

   runApp(_buildAppWithDependencies());
 }

I am testing in the latest version of google chrome
Versions
flutter: 2.5.3 (stable)
firebase_core: ^1.10.0
firebase_auth: ^3.2.0

@michael-ottink
I think you are hitting https://github.com/FirebaseExtended/flutterfire/issues/3356. Please check underlying comments in that issue and see if any of them help, else, you can also share this finding in that issue for better tracking.
I am going ahead and closing this as duplicate. If you disagree, write in comments and I'll reopen it.


Replace ESCAPE by DOWN key to re-show picker (test)

Test update for  #1300.
Changes :
Escape when hidden --> does not show the picker anymore
Down when hidden --> show the picker

Thanks @fabdouglas see #1305 for the full PR!


Assign monitor to pool

The feature allows you to add a monitor to a pool. The changes I made to the Vagrantfile and the gemfile were to get the repo to run with the latest version of vagrant.

Awesome, thanks for this fix. Couple of small things to talk about. Thanks again!


feat: download option for gen art

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10028

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

One wish @Jarsen136 can we make that downloaded file won't be called download.png
but something like
<collection_name>_<item_name> ?
🫡

One wish @Jarsen136 can we make that downloaded file won't be called download.png
but something like <collection_name>_<item_name> ?
🫡

Sure yes 🫡

pay 25 usd

😍 Perfect, I’ve sent the payout
💵 $25 @ 8.25 USD/DOT ~ 3.03 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x194444608c49fd6078f7a5d2a2d1e3065e6c23d6c64cbb3a8c22cb8f0a0f9640
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


deps: update wasm-clients to sdk50

feat: add wasm light client module to feat/wasm-clients branch (#3486)
linting
Migrated the errors to new package (#4058)
imp: make separate go.mod for 08-wasm (#4026)
imp: remove code id key from genesis contract (#4032)
fix imports
bump wasmvm (#4086)
build and test wasm client on PR (#4095)
add authority param to wasm NewKeeper (#4092)
Merge storeWasmCode and importWasmCode functions (#4088)
Pin code to the wasm VM cache (#4093)
just some renaming
renaming to align with x/wasm naming (#4091)
imp: disallow submessage execution (#4130)
use sudo (#4131)
fix wrapf warning (#4172)
Add linting for 08-wasm module (#4206)
add 08-wasm global store key (#4185)
imp: delegate store operation of clientState and consensusState in initialize to contract (#4033)
imp: remove timestamp from consensusState and query contract to retrieve it (#4034)
imp: remove height from header and merge header with misbehaviour (#4049)
imp: add query and sudo message types to encapsulate all variants of calls (#4133)
add 08-wasm Keeper constructor that accepts pointer to Wasm VM instance (#4109)
Allow same VM to be assigned to the global vm. (#4236)
Disallow events, attributes being returned from a contract. (#4222)
Clean up vm entry points (#4279)
add halborn audit report
Add files via upload
add wasm client audit reports (#4351)
Document contract api. (#4283)
oh linter you. (#4369)
deps(08-wasm): bump SDK v0.47.5 (#4540)
add 08-wasm to dependabot
cherry pick commit fixing broken links
Fix dependabot file.
Add new cmd to store code via a gov proposal. (#4565)
update wasmVM
use go 1.21 for wasm client
update expected values
rebuild protos
Revert "update expected values"
update Dockerfile with correct wasmvm
Implement appmodule.AppModule interface
update wasm clients branch linter to match main (#4609)
Unit tests: temporarily disable grandpa testing, update TestInitializeTendermint(), remove unnecessary test from TestConsensusStateValidateBasic(), change the update state result's height type.
TestVerifyMembershipGrandpa working again
TestVerifyNonMembershipGrandpa, TestInitializeGrandpa, TestStatusGrandpa, and TestExportGenesisGrandpa working again
TestCheckSubstituteAndUpdateStateGrandpa, TestVerifyHeaderGrandpa, TestUpdateStateGrandpa, TestVerifyUpgradeGrandpa working again
Run linter
Add instructions for re-creating grandpa test data
Add space after comment delimiter
tidy, please the linter

Description
This PR updates wasm-clients to sdk v0.50.x and is targeted at main to test another strategy.  Currently everything works except for misbehaviour tests.
Commit Message / Changelog Entry
deps: update wasm-clients to sdk v0.50.x

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #4616 (4b873d7) into main (e192899) will decrease coverage by 0.09%.
Report is 2 commits behind head on main.
The diff coverage is 30.00%.

:exclamation: Current head 4b873d7 differs from pull request most recent head d4b401b. Consider uploading reports for the commit d4b401b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
- Coverage   79.27%   79.18%   -0.09%
==========================================
  Files         188      188
  Lines       13046    13061      +15
==========================================
+ Hits        10342    10343       +1
- Misses       2270     2282      +12
- Partials      434      436       +2

Files Changed
Coverage Δ

modules/apps/29-fee/keeper/msg_server.go
97.14% <ø> (ø)

modules/core/02-client/types/params.go
100.00% <ø> (ø)

modules/core/keeper/keeper.go
91.48% <ø> (-0.18%)
:arrow_down:

modules/core/02-client/keeper/keeper.go
78.57% <22.22%> (-4.01%)
:arrow_down:

modules/core/03-connection/keeper/handshake.go
88.58% <100.00%> (ø)


Export SYMBOL_STORE_TARGET

@fabiospampinato My app uses additional proxies on top of stores. Having access to the symbol by which I can get the target out the the oby proxy makes things a bit simpler to do some unwrapping. Do you have any objections to exporting SYMBOL_STORE_TARGET?

mmm can you explain the use case a little more in depth? There's isStore to check if something is a store, and store.unwrap for unwrapping the store, I'm not sure exporting that symbol enabled anything? 🤔 maybe some get gets a bit cleaner?

That's pretty much it. It just makes things a bit cleaner. It lets me use the same symbol for unwrapping my proxy. Otherwise I have to be aware of whether I have an oby proxy or one of my proxies or a double-wrapped proxy. So, it's perfectly possible without the symbol. It just requires more checks.

Alright. Shipped in v14.3.4 👍


Nodes are still causing an infinite loop

#81

Infinity loop or crash? How much time passes after starts the citizens script and infinity loop (or crash)?

Infinite loop AFAIK.
Well I use my own script (edited citizens) .. like 52 npcs. And barely an hour passes.

Please update the plugin to 1.7.6 and check again.

Thanks.
You know, maybe it could've been related to https://github.com/ziggi/FCNPC/commit/b72a403d4baf3d796deea7aef5b413a72557f086!
I will provide feedback, if it's still happening I'll provide the script.
Also I only found the issue on linux so far (ubuntu 16 and debian 8)

Fixed.
http://forum.sa-mp.com/showpost.php?p=3942104&postcount=3429


Patterns, parse empty record type annotation

See co19/LanguageFeatures/Patterns/parenthesized_A01_t01, code like:
  var (() c) = empty;

Also
String test(Record record) {
  return switch (record) {
    (: final Record case7 as ()) => "case7 = $case7",
    _ => "default"
  };
}

and
    case (: final () case11?):
      return "case11 = $case11";

I have verified that all the examples in this issue are now correctly parsed.  But there was a gap in testing (we didn't have any parser tests of variable patterns whose type was a record pattern).  I'll follow up with a CL that tests that scenario.


Create conversion to ROS2 bag script

Created a script to convert NuScenes dataset into ROS2 bags

Based on nuscenes2mcap and nuscenes2bag

Ros2bags or mcap? or does it do both?

Ros2bags or mcap? or does it do both?

The new script I added makes mcap files that are compatible with ros2. I also left the original functionality untouched, so it the script to convert to mcap that are not playable by ros2 is still there.


CSP issue with inline-style

According to the documentation, to support the CSP header, a nonce needs to be added to the style-src directive (https://mui.com/guides/content-security-policy/). However, a number of Material-UI components make use of inline style attributes (e.g. Tabs - https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Tabs/Tabs.js#L433). These require the 'unsafe-inline' source (or a hash for each style although this isn't practical). The 'unsafe-inline' source is ignored if a hash or nonce source is set, thus necessitating the removal of the nonce.
So generally for Material-UI as I see it, I think one of two things are needed:

Update the CSP documentation for a setup to allow inline style attribute setting (not a great CSP, but would make Material-UIs stance clear on styling then).
Set a standard of no inline style attribute setting and we fix them all as bugs.

What do you think? I did an issue search and found this (https://github.com/mui-org/material-ui/issues/13364) suggesting that Material-UI as a whole allows inline style attributes and thus are happy with necessitating a non strict CSP setting. Is this still the case and we're happy with what this means for CSP?

Generally I think we shouldn't use inline styles to begin with since they make customizing harder. So ideally we wouldn't use inline styles at all.
In the meantime we should add this notice to the docs.

This concern seems important for the usage of the components in high demanding environments, e.g; #13364 coming from SnapChat Inc.? However, from our issue history, most loosen the CSP for it.
We do have a couple of components that rely on inline style:

SpeedDial
Skeleton
Autocomplete
TextareaAutosize
Tabs
SwipeableDrawer
Slider
Modal
LinearProgress
CircularProgress
GridList
Collapse
Fade
Grow
Zoom
CardMedia
ButtonBase

Wow, ok, actually, it's much more than I thought.
I think that it would be interesting to explore:

What's the alternative? (cost)
How much better is it without inline-style? Who actually needs it? How does it play with CSS-in-JS libs? (value)

Thanks for the input @eps1lon and @oliviertassinari . I'll loosen the CSP in my application for now, but exploring the removal of all inline style attributes would be great and would be something I'd support.

Just coming here as I was surprised to find out I still had CSP errors after following the docs: https://material-ui.com/styles/advanced/#content-security-policy-csp
It looks like the docs were never updated as suggested, so I opened a PR. Hopefully someone has an updated list of the "non-csp" components.
https://github.com/mui-org/material-ui/pull/21479/files

https://developers.google.com/web/fundamentals/security/csp/#inline_code_is_considered_harmful make a case in favor of removing all inline style.

@razor-x It seems that we have lost your contribution (#21479) along the way in v5: https://next.material-ui.com/guides/content-security-policy/. There are no more mentions of inline-styles and what needs to be done to handle them. We will also likely need to update the guide for emotion, our new default style engine for v5.

@oliviertassinari  just happen to be checking in on the progress towards MUI v5 and remembered about this update. Ideally in v5 CSP would be fully supported by all the hard work done on switching everything to emotion 🤞🏻 .
That said, I do believe my update to the docs in https://github.com/mui-org/material-ui/pull/21479 should have been pushed to the v4 docs and not bumped to v5. After all, my original goal with that update was to save time for any CSP users on v4 by letting them know of this edge case. I'm sure there will still be quite some time before all v4 users are moved to v5, so I'd like to get that back in if possible. Best.

Multiline TextFields are still broken in MUI 5.4.1 with a nonce-based CSP, unfortunately. Any plans on fixing this?

we have the same issue on cssinjs here [https://github.com/cssinjs/jss/issues/814]. we have any updates here? 👍

Bigger picture 2¢: Why wasn't CSS-in-CSS the default option? If CSS-in-JS wasn't a trend, we wouldn't see these issues popping up that require non-trivial workarounds.

@toastal The issue we track here is the use of inline-style. For example, if we consider:
https://github.com/mui/material-ui/blob/3aa59189e566baa225a89f962214441f02787abc/packages/mui-base/src/TextareaAutosize/TextareaAutosize.js#L171-L177
How do we replace this to be compatible without style-src: 'unsafe-inline' https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src#unsafe_inline_styles?
CSS-in-CSS vs. CSS-in-JS is not really a variable on the problem faced, at best CSS-in-JS could be a solution because it allows dynamic values.
There are some discussions about this root issue in the standard working group, e.g. https://github.com/w3c/webappsec-csp/issues/45 but I couldn't find really anything concrete to help.
The option to use CSS-in-JS in the above example would mean that we should add to the unstyled component a dependency on a styling library, e.g. emotion, IMHO, it doesn't fly.
https://github.com/rrweb-io/rrweb/issues/816#issuecomment-1051065366 is encouraging. It suggests that approved JS scripts can use the CSSOM API so some of this list https://github.com/mui/material-ui/issues/19938#issuecomment-593618428 could be solved. If anybody has the bandwidth, feel free to dive deeper.
I suspect that there are components that we won't be able to migrate, hence it would be great to document this problem in https://mui.com/guides/content-security-policy/.

How do we replace this to be compatible without style-src: 'unsafe-inline' https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src#unsafe_inline_styles?
CSS-in-CSS vs. CSS-in-JS is not really a variable on the problem faced, at best CSS-in-JS could be a solution because it allows dynamic values.

I wonder if this library can take a similar approach to what Next.JS does to solve this issue: hoist the dynamic CSS into a <style> block with a nonce that the CSP can reference: https://github.com/vercel/next.js/issues/18557 (implemented in https://github.com/vercel/next.js/pull/19150). Then, none of the CSS is actually rendered inline, but the developer experience is pretty similar (vs. static CSS-in-CSS).
Note that this approach shifts some security responsibility to the library that's inserting the dynamic CSS into the nonce-having <style> block. If the library allows untrusted user input to make it into the <style> block, then it's vulnerable to the same issues as style-src 'unsafe-inline'.
It's probably going to require a fair amount of work to migrate all of the current inline styles into hoisted dynamic <style> styles, but I'd strongly suggest moving in that direction since attacker-manipulated inline styles can lead to exfiltration of private user data: https://scarybeastsecurity.blogspot.com/2009/12/generic-cross-browser-cross-domain.html. Having a CSP without style-src 'unsafe-inline' significantly reduces the portion of a site's code that can insert an attacker's malicious CSS into the page, since only the code that directly maintains the <style> blocks needs to be trusted. Without CSP, or with style-src 'unsafe-line', essentially any buggy code on the page could provide an attack vector for inserting untrusted CSS into the page.

[TextareaAutosize.js] example; “dynamic values”

This could easily be a utility class that is pushed/popped instead of needing to edit the CSS “dynamically” (e.g. .MUITextarea.shouldHideOverflow { overflow: hidden }) (or if CSS variables where on the allowlist for CSP). JavaScript is allowed to dynamically add/remove items from the classList with a CSP concern so why is this not the first solution option? I don’t see what CSS-in-JS gives you other than slower processing speeds and extra complexity.

<style> block with a nonce

This is in the category of “non-trivial workarounds”… Needing to add complicated steps to the build pipeline is adding more complexity to the issue. This is a band-aid for what seems like a poor architecture decision. Users should not be required to whip out heavy guns like webpack to calculate nonces when there are simpler alternatives (see above).

I’m open to being wrong, but I am really not ‘getting it’ when it comes to CSS-in-JS. Currently in my multiple consulting gigs I’m suggesting clients migrate away from anything using CSS-in-JS  now and has anecdotally appeared to have simplified the setup and tooling after a little CSS guidance.

also interested in knowing if there are any updates to this.
is there a list of components that have/have not been migrated?

Any updates on this? Is there any date when mui won't have inline-styles or put them into

@oliviertassinari Not sure if the issue is related to my setup or not, but for some components that rely on inline style such as textField, the style attributes are missing on SSR. I'm facing a style mismatch between SSR and CSR after hydration.
Before hydration:

After hydration:

Maybe they are being added at a later stage after rendering is done?

I think some dynamic styling is unavoidable, in the case of images. When you want to provide a pleasant loading experience you need to tell the browser what the aspect ratio is, and if you have a lot of images that means a lot of possible aspect ratios.
Currently I pass the ratio as a CSS variable in a style attribute on the wrapping component. How to solve this, especially when you have a SPA that needs to dynamically insert images?

Any updates on this? We are also blocked from using material UI for our project because of strict CSP policies mainly unsafe-inline.

Could someone provide a reproduction? I have tried with TextareaAutosize, but couldn't reproduce: https://codesandbox.io/p/sandbox/throbbing-browser-rkms3j?file=/next.config.js:33,18.

not sure why this is an issue when emotion is available. Isn't the OP code trivially
 css={css`
   overflow: ${scrollerStyle.overflow};
   ${!visibleScrollbar
     ? (vertical
       ? `margin-${isRtl ? "left" : "right"}`
       : 'margin-bottom') + `: ${-scrollerStyle.scrollbarWidth};`
     : "" }
 `}

?

Agree, inline styles break SSR as well.

We've dropped MUI in favor of https://github.com/rmwc/rmwc

Does rmwc allow to pass CSP without 'unsafe-inline'?

Any plans to mitigate this issue? This makes a portion of MUI basically unusable to a lot of potential users :/


Can zappa deploy without an URL suffix after the domain?

I am loving my early experiments with Zappa but there's a fundamental question I'm having trouble getting the answer to. Can I create an API gateway on Amazon with zappa that doesn't have "dev" or "production" or anything at all after the root domain? Right now I get something like: https://<amazon_url>/<zapp_env_name>
I'd like to ultimately map my application to a custom domain and I don't want to have to have the two things work the same way with the domain name followed by the active URLs with no env indicator inbetween.

Custom domains work without the <env_name> suffix, <amazon_url> urls don't.


Errors pulling when repository of origin is bigger than 100G.

Error pulling image (59882a691179728f576b972a8af29f9ec6936196) from $myPrivateV1Repo/image, ApplyLayer exit status 1 stdout:  stderr: open
/usr/include/openssl/stack.h: read-only file system
This error pops when the machine executing the script reaches 100G of used space by this process.
I tried running the migrator.sh script instead of the docker thinking that maybe I will be able to see something more but to no avail.

Sorry, it was my own foolishness. The docker daemon is configured with loops devices so it can't grow more than 100G for all images and running dockers.


9anime does not work still, after new update

Source information and language
9anime
Steps to reproduce
Click on any stream, and it just says "bruh"
Expected behavior
Play the stream
Actual behavior
spats out "bruh"
Aniyomi version
<IP_ADDRESS>
Android version
Android 10
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.13.5.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Thank you for reporting this!! I really hope they can notice it and they try to fix it, if possible. Wishing them luck.

having the same issue, gets a update still does not work.


Ollama could use LLM QA but could not access internet

Ollama could use LLM QA but could not access internet

but

I have the same problems , guys ~


Bower doesn't close itself after running bower install

When I run bower install, everything installs as expected, however bower doesn't close itself and I have to manually exit. Any idea how to fix this?

@ajoys can you please upload the bower.json file that you are trying to read? May be there is something wrong with one  dependency.

@ajoys please upload the bower.json file in question.

Hi sorry about the delay. Here is the bower.json file that I am currently using.
{
  "name": "app",
  "version": "0.0.0",
  "dependencies": {
    "angular": "1.5.0",
    "bootstrap": "^3.2.0",
    "angular-animate": "^1.4.9",
    "angular-cookies": "^1.4.0",
    "angular-resource": "^1.4.0",
    "angular-route": "^1.4.0",
    "angular-sanitize": "^1.4.0",
    "angular-touch": "^1.4.0",
    "angular-socket-io": "~0.7.0",
    "angular-ui-router": "~0.2.15",
    "angular-timeago": "~0.2.4",
    "ment.io": "~0.9.24",
    "material-design-icons": "~2.1.3",
    "animate.css": "~3.5.1",
    "angular-moment": "^0.10.3",
    "moment": "^2.11.1",
    "ngMorph": "angular-morph#^0.1.0",
    "angular-emoji": "angular-emoji-filter#^0.0.2",
    "angular-web-notification": "^0.0.60",
    "angular-jwt": "^0.0.9",
    "angular-environment": "~1.0.3"
  },
  "resolutions": {
    "angular": "1.5.0",
    "moment": "2.10.6"
  },
  "devDependencies": {
    "angular-mocks": "^1.4.0"
  },
  "appPath": "app",
  "moduleName": "appApp",
  "overrides": {
    "bootstrap": {
      "main": [
        "less/bootstrap.less",
        "dist/css/bootstrap.css",
        "dist/js/bootstrap.js"
      ]
    }
  }
}

@faceleg @echavezNS I have included my bower file above. Thanks!

Works for me. However material-design-icons is a HUGE package and you may just have to wait for it in the install process. The download alone is ~30MB and installation took forever. Also note that there are version conflicts with angular, which you might want to resolve manually.

@ajoys can you confirm that it's not just hanging because of the rather long installation mentioned above?

That seems to be the issue, removed it and my install time drastically changed. Thanks @BenMann !


OIDC authenticator

Pull Request Test Coverage Report for Build 302

0 of 60 (0.0%)  changed or added relevant lines in 2 files are covered.
708 unchanged lines in 20 files lost coverage.
Overall coverage decreased (-56.9%) to 28.539%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

authentication/oidc/types.go
0
3
0.0%

authentication/oidc/odic.go
0
57
0.0%

Files with Coverage Reduction
New Missed Lines
%

api/osb/logic.go
1
97.2%

rest/interfaces.go
4
0.0%

api/info/info_controller.go
4
0.0%

types/credentials.go
8
0.0%

api/info/info.go
11
0.0%

rest/util.go
11
38.89%

types/broker.go
12
0.0%

types/platform.go
12
0.0%

util/util.go
15
0.0%

api/common/common.go
16
40.74%

Totals

Change from base Build 288:
-56.9%

Covered Lines:
381

Relevant Lines:
1335

💛  - Coveralls


gyp: vendor in GYP3 6.0.3

https://github.com/refack/GYP/commit/8806c633810730d0a78138a550f0ce3e5047abfb

Checklist

[X] npm install && npm test passes
[X] tests are included
[X] documentation is changed or added
[X] commit message follows commit guidelines

Description of change

Heyhey! Welcome back @refack, I hope. Can you give us a status update? I'd love to have you maintain refack/GYP and vendor it in here but it'd be nice to know whether you're going to be around to maintain it. Have you just been taking time off?

Have you just been taking time off?

Yep. Taking a bit of time off.

Can you give us a status update? I'd love to have you maintain refack/GYP and vendor it in here but it'd be nice to know whether you're going to be around to maintain it.

I do hope to keep maintaining GYP3 for foreseeable future (Independent of my contributions to node related stuff).

A few conflicting files...

I think the README should be updated to reflect that we are now bundling GYP3, and not gyp.

Closing.  The requested rebase above did not happen and I sense we are beyond the point of no return on this one.


How can I order by count(somecolumn)?

I was confused as I was trying to query and  order by some column but failed.
select count(uuid) from mt group by ip order by count desc

@airyland you need to make an alias of the column in order to by it .
I.E: `select count(uuid) AS total from mt group by ip order by total [DESC|ASC]

I tried but still fail.
I'm using<EMAIL_ADDRESS>does it support?

@airyland I was talking about 0.9. I have no idea how to do it in 0.8

Could not order by anything but time in 0.8.x versions.

Hello @beckettsean, right now when trying to order by an alias of the column it also returns: "only ORDER BY time supported at this time".
Was this feature removed?

@adriancuadros the functionality did not survive to the official 0.9.1 release and is not part of any 0.9 or 0.10 official release.

sad to hear, found a workaround but this would have been pretty sweet. hope it turns up sometime soon.

... order by numMappers
ERR: error parsing query: only ORDER BY time supported at this time

@deepujain see https://github.com/influxdata/influxdb/issues/5688, https://github.com/influxdata/influxdb/issues/3954, and https://github.com/influxdata/influxdb/issues/4794

@adriancuadros - Can you please let us know what was the workaround ?  Thanks


async support for subscribed response.resolved() also dead links in the readme.md

there seems to be a few dead links ...
one of which im trying to find,
the Async process after returning data in the callback function
as im trying to find a async example of the on_payload_event/subscription_callback
only one i could find is this non async,
    def subscription_callback(self, event):
            logging.info('Subscription Event data results: '.format(event['data']))
            if 'expired' in event['data'] or 'signed' in event['data']:
                # payload is resolved return the data
                return event['data']

trying to convert this to async, seems to fail, as it returns anything which ends subscription
Also it says in docs
If a callback function is not provided, the subscription will stay active until the <PayloadSubscription>.resolve() method is called manually, eg. based on handling <PayloadSubscription>.websocket.onmessage events.
but it errors out if you try to use response.websocket.onmessage
(have also tried many others that are there after i dir() like _on_message, but is always None)
Additionally, in the docs it states;
Alternatively, the (by the sdk.payload_subscribe() method) returned raw websocket can be used to listen for WebSocket onmessage events.
and sdk.payload_subscribe() also doesn't seem to be a thing ? if thats a typo, still doesn't show the working onmessage endpoint.

Does this work for you?
https://github.com/XRPL-Labs/xumm-sdk-py/blob/main/samples/payload.py

Just to be clear you want the callback to be async as well? What exactly are you doing in the callback? Can you share your full code and what you're attempting to achieve?

Just to be clear you want the callback to be async as well? What exactly are you doing in the callback? Can you share your full code and what you're attempting to achieve?

Having the awaiting subscription.resolved() to be async, so when you "await" this it doesn't halt the code...
(The initially 'sdk.subscribe(uuid, callback)' and its callback is OK within its own asyncio thread)
And yes the code in the link you posted does work, but halts on the awaiting resolved()
I didn't initially realise...
I did try putting  the resolved() in its own asyncio thread etc, but that didn't work (as its other coroutines that hold the code up, payload.py it errors/reports at)...
I can post code I have once home, in like 4+ hours...

Ok if you can make a simple example that will help and I will fix it to do what you want.
If you don't want it to await, then just remove the await subscription.resolved() etc, and handle everything in the callback... I think I made some examples long ago but never pushed them into the repo.

Tbh it's more or less as the link you posted ...
I did want to keep it within the same function, (as its hard to reconnect to discord slash commands cleanly)
I did try and get suitable feedback from the subscription function, but wasn't able to find how to use the subscription.websocket.on_message as the docs (I did try dir() to try and find it but some seem to need undocumented arguments (json or a dict when I trial and errored a few)...

Ahh I figured this is discord bot. subscription.websocket.on_message is documented incorrectly I think. I will look into that.


Update versioneer to 0.29

mp-api 0.37.1 has requirement emmet-core>=0.69.2, but you have emmet-core 0.68.0.


oui.txt update

updated oui.txt with 3,102 more MAC prefixes
used sort on file so future additions are easier to diff and see changes

Thanks for the PR. I like the sort idea too. I'll double-check it when I get home, and assuming I see no issues, I'll get this merged in.


Every time the constructor is called, an HTTP request is sent to Loki asking it for it's version

Bug Description
Every time the constructor is called, an HTTP request is sent to Loki asking it for its version. This information is then logged into the debug logs, spamming them with unneeded log lines.
To Reproduce

juju deploy loki-k8s --channel edge
look in the debug logs

Environment
charm version: latest/edge
Relevant log output
N/A

Additional context
No response

The _provide_loki() method  queries the Loki server version using a HTTP API call and raise different types of exceptions depending on the success or failure of this call. This method is only being used to set a status message by the Loki provider charm depending on if the Loki server is active and reachable or not. The docstring of the LokiPushApiProvider object also recommends the use of such a _provide_loki() method in this manner. However neither the docstring nor the Loki charm use the exceptions raised by the _provide_loki() to conditionally instantiate the LokiPushApiProvider object only if the Loki server is active and reachable. The LokiPushApiProvier object does use the Loki HTTP API in its _check_alert_rules method. This method is invoked in response to any changes in the relation with the consumer object and in response to a pebble ready method (see PR 132 ). Hence instantiating the LokiPushApiProvider object can lead to false negative result in _check_alert_rules just because the Loki HTTP API is not responsive. In view of these observations it is proposed that

The _provide_loki() method be renamed to something like _is_loki_active(). Instead of raising exceptions this method may return a boolean that asserts if the Loki server HTTP API is responsive or not.
Instantiation of the LokiPushApiProvider be guarded by check for _is_loki_active().

There may be a few concerns here. For example how should such a scenario be handled

The Loki charm receives a relation changed event but its workload container is not yet alive so this event is ignored (as per PR 132 ).
Subsequently on pebble ready the Loki charm fails to see an active loki server because of the time lag between the workload container becoming active and the time it takes a Loki HTTP API to become responsive. hence the Loki charm does not instantiate the LokiPushApiProvider . Hence the pending relation changed event is still not handled. In fact it will never be handled.

What is missing here is the functionality of a "Readyness Probe" and the Loki charm being informed through a suitable event when the status of such a readyness probe changes. In the absence of such functionality one approach to solving the problem is to use the periodic update-status event to check for active status of Loki server (i.e. responsiveness of its HTTP API) and update all related consumers.

I think renaming the method and guarding the instantiation of LokiPushApiProvider is a good idea.
Let's keep in mind that we will need to observe the on.loki_push_api_alert_rules_changed event inside the guard, for instance:
if self._is_loki_active():
    self.loki_provider = LokiPushApiProvider(
            self,
            address=external_url.hostname or "",
            port=external_url.port or self._port,
            scheme=external_url.scheme,
            path=f"{external_url.path}/loki/api/v1/push",
     )
    self.framework.observe(self.loki_provider.on.loki_push_api_alert_rules_changed, self._loki_push_api_alert_rules_changed)

I think renaming the method and guarding the instantiation of LokiPushApiProvider is a good idea. Let's keep in mind that we will need to observe the on.loki_push_api_alert_rules_changed event inside the guard, for instance:
if self._is_loki_active():
    self.loki_provider = LokiPushApiProvider(
            self,
            address=external_url.hostname or "",
            port=external_url.port or self._port,
            scheme=external_url.scheme,
            path=f"{external_url.path}/loki/api/v1/push",
     )
    self.framework.observe(self.loki_provider.on.loki_push_api_alert_rules_changed, self._loki_push_api_alert_rules_changed)

As mentioned earlier, we have to be very, very careful with this.
The actual Loki charm does not listen to relation_* events, but they will still be emitted as it is part of the relation. If there are no observers, they will simply disappear.
In the case of, say, a bundle deployment, where a relation-joined event may occur before Loki is actually ready, this means that relation-joined simply disappears into the ether, never to be seen again. Any data which is expected to be set in relation_joined will not be.
The alternative to this is quite literally the "common exit hook" which we have a number of issue about moving away from. If the charm/library looks at every relation data bag on every event to compare the state of the charm, we should probably try to hash absolutely everything.
In order to protect the validity of relation-* events in this case, I'd suggest waiting until after container operations are moved into the charm itself, so the provider can manage relation data only.

I honestly do not see why we need to have Loki active in order to create the rules in the container. For that, we need only Pebble.
I am also very conflicted about providing the URL via LokiPushApiProvider ONLY if Loki is active, as relation changes have a lag to propagate to the other side. Interestingly enough, if Loki is not active, we do NOT remove the URL from LokiPushApiProvider, which is at very least least inconsistent.

Interestingly enough, if Loki is not active, we do NOT remove the URL from LokiPushApiProvider, which is at very least least inconsistent.

How can a Provider charm let the Consumer know that its workload endpoint is temporarily not in service (due to say upgrade or maintenance etc) ? This is to prevent errors in the Consumer charm should it try to connect to the workload endpoints of the Provider charm during this process. There was previously an attempt to cater to this issue using ready() and unready() methods in the Operator Framework through an relation management object that was removed as it was not being used as intended.

Closed PR https://github.com/canonical/loki-k8s-operator/pull/135 since fix is moved to https://github.com/canonical/loki-k8s-operator/pull/151


Duplicate command under View to toggle fullscreen

Version: built from master as of 24aa929ae23746a41d3cd094bf382610270cc3af
OS: OSX 10.11.1

It seems Electron is adding it's own "Enter/Exit Full Screen" commands to the View menu, along with the "Toggle Full Screen" command YakYak defines itself.

can't see this one now.


Raster to h3 table import script

This PR adds a dockerized script to download a raster dataset, convert it to h3, and import it into the database.
The script is documented at data/h3_raster_importer/README.md
Jira
This is a proof of concept for: https://vizzuality.atlassian.net/browse/LANDGRIF-207
Test
Follow the instructions to run the script at data/h3_raster_importer/README.md
You should end up with a table h3_grid_spam2010v2r0_global_prod with 43 columns, one for each crop in the database.

Thank you @fgassert for taking the time for this. I just tested it locally and table is created and data is imported as expected.
Nevertheless, I have some questions / doubts about it. I left some comments that I'd need to clarify
I am not sure if this is a temporary solution / patch for us to keep going forward, or it is a permanent solution, but I'd love to have a chat about it, since this kind of stuff (h3 etc) is totally new for me and I'm probably missing parts here
Thanks!

Haha good. I was hoping to have this conversation. I agree with you in principle, and in the short term it would even make things easier. But over the long term, I think we want the GIS table(s) and their schemas to be flexible.
I'm think we should follow a pattern similar to how PostGIS handles rasters or even how CARTO handles user data. Essentially, these tables are more akin to binary blobs than entities (its only by making them into tables, we get to take advantage of postgres magic). There is then another nicely structured table that tracks all of these GIS data tables, which we can use to track FK relations etc.

The goal here is not to hinder flexibility, it's about centralizing as much as we can under a single source of truth.
My opinion is that, if we're going to build an API endpoint that that serves this data, it will be closely tied to the data structure we have. Also, we already have TypeORM as the DB/data format management for the rest of the tables, so this is why I think we should use it also to maintain the structure. Note that this does not mean we need an entity-like table - I'm happy with an "id + blob" table if that's what makes sense.
Ultimately what I see as the best solution is having as much "truth" as possible on TypeORM's side, and this script being as barebones as it can be - so for example, it can make a lot of assumptions (db exists, table exists, has a given structure) and if any of them fails, the script itself fails fast, instead of trying to correct them. This makes this script easier to maintain, while also ensuring we avoid any sort of problems from having potentially 2 sources of truth.
As for flexibility, moving this truth ownership into the API code does add a barrier to you, in case you want to modify the table structure. So if you need to change something, we commit to helping you with it on the app side, so we can continue to be flexible as the project evolves.

just made a small change to decouple this app from docker. By having python deps defined inside the dockerfile, we are making native setup a bit harder, so we should have the deps defined separately from the dockerfile

@tiagojsag I've addressed your changes, thanks!
@alexeh I've updated the script to add rows to the H3 master table. I also updated the table to have one row per h3_grid column, so you should get 42 rows each corresponding to an individual crop or crop group.


Use pure-java Air-Compressor instead of JNI based libraries

Motivation
Right now we're using JNI based libraries to perform data compression. These libraries are do have an overhead in terms of size (7Mb out of 20Mb of Pulsar-Client lib) and are incurring the JNI overhead which is typically measurable when compressing many small payloads.
We can replaces compression libraries for LZ4, ZStd and Snappy with AirCompressor (https://github.com/airlift/aircompressor), which is a pure Java compression library used by Presto.
Microbenchmarks
Microbenchmark code is available at https://github.com/merlimat/compression-benchmark
The results are on-par with the JNI version in most cases.

Recently we have seen failure when consumer tries to decode LZ4 compressed message. and we want to avoid any unknown compatibility issue.
net.jpountz.lz4.LZ4Exception: Malformed input at 367
	at net.jpountz.lz4.LZ4JavaUnsafeFastDecompressor.decompress(LZ4JavaUnsafeFastDecompressor.java:172)
	at org.apache.pulsar.common.compression.CompressionCodecLZ4.decode(CompressionCodecLZ4.java:74)
	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.internalPeekNthMessage(PersistentTopicsBase.java:1118)
	at org.apache.pulsar.broker.admin.v1.PersistentTopics.peekNthMessage(PersistentTopics.java:435)

@rdhabalia There's a test to double-check that the format is the same as the current compression codecs: https://github.com/apache/pulsar/pull/5390/files#diff-5d40386eaa90a0ce27694830c4fa940cR41

I see.. instead only keeping static output in test, can we also keep pervious dependencies for a release and add real tests with different payload size. we can remove it next release once we have proof of successful tests for a release.?

run java8 tests
run integration tests

@merlimat there is genuine issue here.
Error Message
Could not initialize class io.airlift.slice.Slices
Stacktrace
java.lang.NoClassDefFoundError: Could not initialize class io.airlift.slice.Slices
	at io.airlift.compress.zstd.ZstdFrameCompressor.writeChecksum(ZstdFrameCompressor.java:133)
	at io.airlift.compress.zstd.ZstdFrameCompressor.compress(ZstdFrameCompressor.java:156)
	at io.airlift.compress.zstd.ZstdCompressor.compress(ZstdCompressor.java:93)
	at org.apache.pulsar.common.compression.CompressionCodecZstd.encode(CompressionCodecZstd.java:77)
	at org.apache.pulsar.common.compression.CompressorCodecTest.testCompressDecompress(CompressorCodecTest.java:64)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@rdhabalia Added tests to prove compress/decompress compatibility with current JNI implementations.

@merlimat Could you please resolve the conflicts?


[Scratch Buffer] Creating a scratch buffer with the JSON syntax throws an error.

Mainly because of this
{
    "caption": "Scratch Buffer: JSON",
    "command": "scratch_buffer",
    "args": { "syntax": "Packages/JavaScript/JSON.sublime-syntax" }
},

Since JSON.sublime-syntax is now moved into it's own folder in Packages, it should be
{
    "caption": "Scratch Buffer: JSON",
    "command": "scratch_buffer",
    "args": { "syntax": "Packages/JSON/JSON.sublime-syntax" }
},

@Ultra-Instinct-05 Thanks for the report!

@Ultra-Instinct-05 Thanks for the report!


Include warning if CSV download is over a certain MB size

Update the description of the Dataset by Geography indicating that the file sizes could be large depending on the combination a user chooses. Include warning about file size depending on what the combination of geographies is, along with a warning if the user downloads the nationwide dataset.

data-browser-api now includes a /count endpoint where CSV list of msamds, states, or both can be passed in to fetch the row count. Example: /view/count?msamds=11260&years=2018

"each Worksheet can support up to 1,048,576 rows" @wpears


cmake: FindZephyr-sdk: Find newest SDK version

This improves the version checking for the zephyr SDK by searching for newer versions that the version that was detected. This works around the issue whereby the versions are contained in files with MD5 hashes which might be in any order.
Fixes #52234

also, what would happen in the event that the newer SDK version is not compatible with current Zephyr SDK ?

I wast thinking about only finding the highest version with the patch e.g. if 0.15 is specified then the highest 0.15.x version, but alternatively we could specify a maximum supported version in a separate variable and update that for each release.
I think really this is a bit hackish and would be better for cmake to handle it but don't think that would be likely or if it was, to happen within a short timeframe.

I wast thinking about only finding the highest version with the patch e.g. if 0.15 is specified then the highest 0.15.x version

The I guess I did a good test, as it jumps to higher minor version.

but alternatively we could specify a maximum supported version in a separate variable and update that for each release.

That would be find_package() implementation itself.
A package must report if it is not compatible with a required version, so that a 0.16.x can report FALSE if it is incompatible when a 0.15.x is requested. Not sure this is handled either in this PR 😉
So if a package is backwards incompatible, then it should set PACKAGE_VERSION_COMPATIBLE to False.
Ref: https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#package-version-file

I think really this is a bit hackish and would be better for cmake to handle it

I completely agree. There are several use-cases we must ensure are working if we decide to make a fully working solution.
A trick we are using in Zephyr package is to look for version 0.0.0 with EXACT, cause that will always fail, and then we use the variable <package>_CONSIDERED_CONFIGS to select the Zephyr.
Maybe something similar wrt. Zephyr SDK can be done.
Get all versions by asking for 0.0.0, and then work our way backwards from highest till lowest until there is a working match.
Ref:
https://github.com/zephyrproject-rtos/zephyr/blob/80f87b94806bef4f893b18f1dc8cea070382dd6b/share/zephyr-package/cmake/zephyr_package_search.cmake#L72
https://github.com/zephyrproject-rtos/zephyr/blob/80f87b94806bef4f893b18f1dc8cea070382dd6b/share/zephyr-package/cmake/zephyr_package_search.cmake#L82

Then I guess I did a good test, as it jumps to higher minor version.

I think you managed to stumble into a crafty bug! 0.15.2 searches for 0.15.3 or above and finds 0.16.0, which is actually a higher version, but it only checks the minor part - 3 vs 0... Should probably have used the version_compare one instead.
That 0.0.0 one looks like a good way to do it, I did read that I think it can return at most 4 versions in the list, need to test that and see if it is configurable

I think it can return at most 4 versions in the list

I have not noticed such limitation, but if you find such mentioning then please share.
But as it is a CMake list then I don't see why it should limit to 4.
That would be like CMake specifying that if it haven't found a matching package in the first 4 tries it then it will give up further tests.

Have updated to search based on version 0.0.0

If application is configured, then reconfigured e.g. with cmake . then the zephyr-sdk find function is not called again (i.e. cached value is used)

@stephanosio is this something we want in for 3.3 so that if someone has e.g. sdk-ng 0.15.0 and 0.15.2 it will use 0.15.2 instead of 0.15.0, or should it wait for 3.4?

This is not fixing a bug. It will need to wait for 3.4.

@stephanosio can we revisit this? This is fixing a bug for me at least. I have sdk-ng 0.15.0 with just the arm tools, and 0.15.2 with all the tools, whenever I configure anything that is not for the arm platform, it fails with:
CMake Error at /tmp/aa/zephyr/cmake/compiler/gcc/target.cmake:12 (message):
  C compiler
  /opt/zephyr-sdk-0.15.0/riscv64-zephyr-elf/bin/riscv64-zephyr-elf-gcc not
  found - Please check your toolchain installation

Which kind of is a bug

@stephanosio can we revisit this? This is fixing a bug for me at least. I have sdk-ng 0.15.0 with just the arm tools, and 0.15.2 with all the tools, whenever I configure anything that is not for the arm platform, it fails with:
CMake Error at /tmp/aa/zephyr/cmake/compiler/gcc/target.cmake:12 (message):
  C compiler
  /opt/zephyr-sdk-0.15.0/riscv64-zephyr-elf/bin/riscv64-zephyr-elf-gcc not
  found - Please check your toolchain installation

Which kind of is a bug

I leave the decision on whether that should be considered a bug up to @tejlmand since he is the maintainer for the build system and, IIRC, he had a different view on this matter. If he considers this a bug, I have no objection to merging this.

Has this been tested for situations where a given Zephyr SDK version is marked as not compatible to the requested one ?

There is no such system at present, this is the code from the 0.15.2 sdk-ng cmake file:
file(READ ${CMAKE_CURRENT_LIST_DIR}/../sdk_version SDK_VERSION)
string(STRIP ${SDK_VERSION} PACKAGE_VERSION)

if(PACKAGE_VERSION VERSION_LESS PACKAGE_FIND_VERSION)
  set(PACKAGE_VERSION_COMPATIBLE FALSE)
else()
  # Currently, this Zephyr SDK is expected to work with any Zephyr project
  # requiring this version or any older version.
  #
  # In case this version is no longer backward compatible then this is the place
  # to test, for example as
  # set(ZEPHYR_MINIMUM_COMPATIBLE_VERSION 0.11)
  # if(PACKAGE_FIND_VERSION VERSION_LESS ZEPHYR_MINIMUM_COMPATIBLE_VERSION)
  #   set(PACKAGE_VERSION_COMPATIBLE FALSE)
  #   return()
  # endif()

  set(PACKAGE_VERSION_COMPATIBLE TRUE)
  if(PACKAGE_FIND_VERSION STREQUAL PACKAGE_VERSION)
    set(PACKAGE_VERSION_EXACT TRUE)
  endif()
endif()

There is no such system at present

Of course not, just hack together an unofficial Zephyr SDK where you take a real Zephyr SDK and manipulates it's version file and even mark it as incompatible.
That's what I have done when testing your PR, no need to wait till an official Zephyr SDK release for testing code flow 😉

Has this been tested for situations where a given Zephyr SDK version is marked as not compatible to the requested one ?
Cause to me, this code seems to always just pick latest Zephyr SDK, compatible or not.

Tested, works fine.
Normal:
Loading Zephyr default modules (Zephyr repository).
-- Application: /tmp/aa/zephyr/samples/hello_world
-- CMake version: 3.25.2
-- Found Python3: /usr/bin/python3.10 (found suitable exact version "3.10.9") found components: Interpreter
-- Cache files will be written to: /home/jamie/.cache/zephyr
-- Zephyr version: 3.2.99 (/tmp/aa/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.7.1")
-- Board: nrf52840dk_nrf52840
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.15.2 (/opt/zephyr-sdk-0.15.2)
-- Found toolchain: zephyr 0.15.2 (/opt/zephyr-sdk-0.15.2)
-- Found Dtc: /opt/zephyr-sdk-0.15.2/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /tmp/aa/zephyr/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts

With following change to /opt/zephyr-sdk-0.15.2/cmake/Zephyr-sdkConfigVersion.cmake:
   set(ZEPHYR_MINIMUM_COMPATIBLE_VERSION 4.11)
   if(PACKAGE_FIND_VERSION VERSION_LESS ZEPHYR_MINIMUM_COMPATIBLE_VERSION)
     set(PACKAGE_VERSION_COMPATIBLE FALSE)
     return()
   endif()

gives:
Loading Zephyr default modules (Zephyr repository).
-- Application: /tmp/aa/zephyr/samples/hello_world
-- CMake version: 3.25.2
-- Found Python3: /usr/bin/python3.10 (found suitable exact version "3.10.9") found components: Interpreter
-- Cache files will be written to: /home/jamie/.cache/zephyr
-- Zephyr version: 3.2.99 (/tmp/aa/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.7.1")
-- Board: nrf52840dk_nrf52840
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.15.0 (/opt/zephyr-sdk-0.15.0)
-- Found toolchain: zephyr 0.15.0 (/opt/zephyr-sdk-0.15.0)
-- Found Dtc: /opt/zephyr-sdk-0.15.0/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /tmp/aa/zephyr/boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts
-- Generated zephyr.dts: /tmp/aa/zephyr/samples/hello_world/_AA/zephyr/zephyr.dts

Just to be sure - do I understand right that we don't change the behavior if we select SDK via ZEPHYR_SDK_INSTALL_DIR?
So the exact version which is specified in ZEPHYR_SDK_INSTALL_DIR will be used?

So the exact version which is specified in ZEPHYR_SDK_INSTALL_DIR will be used?

Correct, ref: https://github.com/nordicjm/zephyr/blob/96182d1ff55e3766eb72b9fc3322414005a6f701/cmake/modules/FindZephyr-sdk.cmake#L51-L58


refactor: remove unnecessary overrides of superclass init

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 96.996%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
938

Relevant Lines:
960

💛  - Coveralls


annotations reliability

[ ] VTC reliability
[ ] inter-rater reliability
[ ] self-reliability

Does not belong to this package


Disable L3HA as default setting

Based on many open Neutron issues around L3HA RPC-O currently
disables L3HA until the known issues like
https://bugs.launchpad.net/neutron/+bug/1590845
Neutron community.
The HA functionality will be still served by the neutron-ha-tool script.
Connects: #1149

👎 the variable is being added to the wrong file, it should be added to rpcd/etc/openstack_deploy/user_osa_variables_defaults.yml
Would also like to see opinions on whether or not this is appropriate for Mitaka. The referenced upstream bug is likely to be fixed in Mitaka but is only one of a number that were highlighted when this change was discussed for Liberty. Is this functionality still considered to be so broken that it should also be disabled in Mitaka?

Sorry, for some reason I thought overrides that are specific to the RPCO product go in rpco_variables. Now I see that only variables used in the rpc playbooks go in rpc_variables.

RPC-AIO-Liberty-PR: Fail

RPC-AIO-Ceph-Liberty-PR: Fail

Going to also make a PR to docs before it's merged in.

Docs patch is here:
https://github.com/rackerlabs/docs-rpc/pull/496

Looks good. Maybe once the docs PR merges we should reference the appropriate section here too? Certainly not required though, since the docs PR is linked in the comments above.
👍


PostgreSQL and auto-generated databases

As promised in the proposal “JPA, PostgreSQL and DDL-Scripts” (passed on
Oct 29, 2019) we worked on replacing the current set of MariaDB based
DDL scripts with a proper auto-generated database. These changes are
now merged into the Opencast codebase so that we do not need the DDL
scripts any longer.
This patch brings these changes to an end, removing the DDL scripts and
updating the documentation to reflect the auto-generated database and
the newly added – for now, still marked as experimental – support for
PostgreSQL.
OAI-PMH with it's weird – and somewhat problematic – database usage
still needs a manual set-up of one table. This has been added to the
documentation but is only necessary if you actually configure and use
OAI-PMH which is not the case in a default installation.
To avoid confusion: We still need upgrade scripts. This is only about
the initial database setup.

While this is basically just documentation and the topic has already passed as proposal, it would be great if someone else could read through this before it gets merged.
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch (features can only go into develop)
[x] include migration scripts and documentation, if appropriate
[x] pass automated testing
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits
[x] have appropriate tags applied

Docs are updated.


Imcomplete transaction history

Version
2.0.4
Description
Hey guys
when I check for my transaction history in the wallet with the latest version. The history ends with the latest updated of the wallet. Is this a bug? How can I get the complete transaction history?
Expected behaviour
Complete list of transactions.
Actual behaviour
List with the transactions since the latest update.
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
No response
Operating System
Windows
Diagnostics
No response
Developer Profile
No
Profile Type
Software (Stronghold)
Staking
Previously staked
Crash Status
None of the above
Error Messages
No response
Error Logs
No response
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The wallet is not intended to hold the full transaction history because it uses normal nodes which do pruning. If you want to check your transaction history you should use the explorer.

Stardust (post merge October 4 2023): https://explorer.iota.org/mainnet
Chrysalis (pre merge): https://explorer.iota.org/chrysalis-mainnet


Proposal: Auto-polyfilling

Using new ES5 and ES6 features should be seamless. And they aren't today using TypeScript, because developers need to manually polyfill themselves. The TypeScript compiler have all the information it needs to enable auto-polyfilling(the type and the script target). In fact, it might be the only JS-to-JS compiler that can do auto-polyfilling, because it supports type annotations. It could clearly get an edge over other JS-to-JS compilers.
Here are some examples.
let names = ['emma', 'john', 'eric'];
if(names.includes('emma')) {
  console.log('hi');
}

will be compiled into ES5 target.
if (![].includes) {
  Array.prototype.includes = function(searchElement /*, fromIndex*/ ) {
    'use strict';
    var O = Object(this);
    var len = parseInt(O.length) || 0;
    if (len === 0) {
      return false;
    }
    var n = parseInt(arguments[1]) || 0;
    var k;
    if (n >= 0) {
      k = n;
    } else {
      k = len + n;
      if (k < 0) {k = 0;}
    }
    var currentElement;
    while (k < len) {
      currentElement = O[k];
      if (searchElement === currentElement ||
         (searchElement !== searchElement && currentElement !== currentElement)) {
        return true;
      }
      k++;
    }
    return false;
  };
}

var names = ['emma', 'john', 'eric'];
if(names.includes('emma')) {
  console.log('hi');
}

Auto polyfilling is a bad idea.  Generally I believe polyfilling is a bad idea, as it modifies the global context in a way that maybe very unexpected for any other code running in that environment.  While you might be doing something to make your life easier, other developers likely won't be expecting that.  Polluting or modifying the global context has led to all sorts of tears over the years.
If you will, shimming, is a much better approach in the long term, if defined as a module returning an object which has only been modified in your context to include the missing feature functionality, and that module figures out if there is native code to handle the missing feature, giving you a consistent API.
My opinion is that if the ES6 feature cannot be cleanly degraded to ES6, then TypeScript shouldn't touch it.  Polyfills would be challenging for TypeScript to maintain, let alone to agree upon which polyfills to include, and debates over code an approach.
If you are 100% confident that in your environment that polyfills are safe, then there are certainly enough of them out there to utilise, most of which have appropriate typings that you can include in your project.  There are also increasingly a number of libraries built on TypeScript becoming available which are starting to close the gaps that are being introduced in ES6, ES7, ES.Next...

Auto polyfilling is a bad idea. Generally I believe polyfilling is a bad idea, as it modifies the global context in a way that maybe very unexpected for any other code running in that environment. While you might be doing something to make your life easier, other developers likely won't be expecting that. Polluting or modifying the global context has led to all sorts of tears over the years.

I can see a negative side effect with auto-polyfill. If let say that one third library have added a support for Array.prototype.includes but with a different API then specified in the ES spec and you as a consumer doesn't know about it. Your application would crash. But how often does it happen? I think not that often. The benefits outweighs the risks here. Many people don't use new JS features because it is not simple to add them. TS is one of few projects that could implement a seamless support.

If you will, shimming, is a much better approach in the long term, if defined as a module returning an object which has only been modified in your context to include the missing feature functionality, and that module figures out if there is native code to handle the missing feature, giving you a consistent API.

I can't see the difference with polyfill? Could you give me an example of Array.prototype.includes?

My opinion is that if the ES6 feature cannot be cleanly degraded to ES6, then TypeScript shouldn't touch it. Polyfills would be challenging for TypeScript to maintain, let alone to agree upon which polyfills to include, and debates over code an approach.

That's the problem they already have with the core language. Why would polyfills be challenging to support? And why would it be hard to agree upon which to support? And would this new challenges be more challenging then the core language? Babeljs polyfill support(although very simple) is maintained by one guy?

There are good, straightforward solutions (namely: ES6 polyfill libraries) to this already.
Having the compiler try to figure out which ES6 methods you need, and where to emit them, and when, with controls for people who don't want the polyfills emitted, and ways to change where those polyfills come from, etc, is a big mess that isn't justified by the potential gains over simply including a normal ES6 polyfill library in your script context.

There are good, straightforward solutions (namely: ES6 polyfill libraries) to this already

That is not the same solution as auto-polyfill. I don't want to polyfill things I don't use.

Having the compiler try to figure out which ES6 methods you need, and where to emit them, and when, with controls for people who don't want the polyfills emitted, and ways to change where those polyfills come from, etc, is a big mess that isn't justified by the potential gains over simply including a normal ES6 polyfill library in your script context.

I think most people wants them emitted them before the "main" is run. Why can't this be behind a command line flag? Then people can decide whether they want it to be auto-polyfilled or not.

What happens when your code is an external module? We have no way of knowing which module is "first" and there's no "main" function.
What happens you write code that invokes a should-be polyfilled method through an any instance? We have no way of knowing which method needs to be filled in.
What happens when you have a function that requires that an includes method be present on the passed-in object? Do we always polyfill in includes, then? What distinguishes that case from any array-accepting method?
What about code that says var x = arr.includes; ? Is that an ES6 check and we shouldn't polyfill it, or maybe it's actually a usage of includes in some other location?

What happens when your code is an external module? We have no way of knowing which module is "first" and there's no "main" function.

If you run tsc filename isn't it the root file? The "main" is that file.

What happens you write code that invokes a should-be polyfilled method through an any instance? We have no way of knowing which method needs to be filled in.

Couldn't he just cast it back to a polyfill object?
let a: string = 'a';
let b: any = a;
(<string>b).codePointAt(0);// ES6 feature

What happens when you have a function that requires that an includes method be present on the passed-in object? Do we always polyfill in includes, then? What distinguishes that case from any array-accepting method?

If it is derived from a polyfilled type, then polyfill? If it is derived from a custom class that has the same method name, then don't polyfill.

What about code that says var x = arr.includes; ? Is that an ES6 check and we shouldn't polyfill it, or maybe it's actually a usage of includes in some other location?

If you run a polyfill command and if arr is derived from the array type then it should be polyfilled. The dev should know that there is no need to have polyfill checks in his code when running autopolyfill. Even though he polyfills his code – it won't break as long as the auto-polyfill do the same as his polyfill.

Your application would crash because your 3rd party library doesn't work, because you modified the polyfill. But honestly how often does it happen? I think not that often.

My experience, especially with the scope you are talking about, is a lot more than you would think.  Very few commercial projects I am aware of are single framework ones.  The commercial reality is you get all sorts of pressure from sales and marketing to include ad-tracking software, you get your own dev pressures to maybe include MVT tooling, etc.  I agree wholeheartedly @RyanCavanaugh that it would be a nightmare to maintain, especially because it has to be delivered with the tooling to turn it off.

I can't see the difference with polyfill? Could you give me an example of Array.prototype.includes?

Well, Array is the bugger, not because of the concept, but because of the way Arrays work in ES, in that at the moment you can't subclass them and you can't recreate them fully in ES.  For an example of what I would call a TypeScript ES6 shim, check out dojo-core's WeakMap.ts.  Notice that it does not change the global namespace.  It either returns a functionally complete shim or it returns the native interface.  From a user's perspective, you just include the module and whatever you require in will be the most "efficient" implementation supported in your environment and you haven't suddenly added something to the global namespace that some other code isn't expecting.  I know the terms get conflated a lot.
Array shims have to take a different approach, because you cannot return a fully functional Array type constructor object.  So what you can do though is return an object which requires an Array as an argument, like dojo-core's array.ts.
(For full disclosure, I am part of the Dojo team)

Thanks @kitsonk for clarification between shim and polyfill. Never really understood the difference before, but now I do.