Weird messages output on urxvt

I noticed that on urxvt terminal the output is messed up, see following screencast.
Maybe it's a bug on urxvt?
I'm using archlinux distro and urxvt terminal.

We have the same bug using PowerShell with Windows. I think is something about the caracters of endline finishing: \r\n and \n.  This is defined here: https://github.com/ryukinix/decorating/blob/master/decorating/stream.py#L63

I guess it's https://github.com/ryukinix/decorating/blob/master/decorating/stream.py#L108.
Maybe '\r' deletes the new-line and therefore goes one line up.
How can I change and test it easily?
I was thinking of trying this.

@AlexK-IL You can do this:

clone the repo locally;
setup a virtualenv on root of repo:  "pyvenv env && source env/bin/activate"
call 'python setup.py develop' to install mal using symlink

Now the mal is installed on isolated environment and you can modify the source and test calling "env/bin/mal". That's a pretty easy way.

@ryukinix Wow, this thread is on decorating, sorry. I messed up. You can do the same about installation and try some usage case of @animated decorator on readme. I suggest to try first replicate the bug with a simple usage and fix the based on this simple case.

Thanks I'll try.

I'm a little stuck here.
I wrote a script to test the @animated decorator which I put in the same folder as animation.py.
It's content is:
#!/usr/bin/env python
# coding=utf-8

from decorating import animated
from time import sleep

@animated('test')
def main():
    sleep(3)

if __name__ == '__main__':
    main()

By running the script above I can reproduce the bug, however if I make changed to animation.py nothing changes.
The change I did was a simple one, I changed https://github.com/ryukinix/decorating/blob/master/decorating/animation.py#L207 so the message will contain something else then 'test'.
Maybe it's loading the installed decorating package instead of loading from local directory?
I don't know how to test it otherwise.

Maybe it's loading the installed decorating package instead of loading from local directory?

Yes, is possible. The easilly way to avoid confusing about multiple versions is using virtual enviroments and MAKE SURE you are installed as symlink python setup.py develop. If you try install directly using python setup.py install this is a problem, because all the source is packaged and installed as it is in that moment, so any modification later doesn't have any effect.
Are you using virtual enviroments and symlinks for install?
Check pip list and send the output to here.

The problem with executing python setup.py develop is that I'm using a package manager to handle the files and it messes up with them, which leaves me with untracked files on my machine...
There should be a way to execute the scripts without installing them.

This is exactly the reason of the suggestion about use a virtual environment. You get the package installed without fuckup you system (yes, I'm agreed about install things without package manager is pretty bad too). Using venv all installed files will be in just in a simple directory that you can delete later.
Some python packages is really hard execute without installing because the package data model of python. In the most cases, when I'm trying figure out how this works in another packages, this is really a big problem.
However, you did execute the package without installing, right? Ok. The python docs makes clear when two packages, one local and installed, has the same names the priority is executing the local.
Are you considering your modification just don't have any effect? You can try modify really hard the code to break up and see if the REAL executed package is the local decorating.

BTW, I recommend use autoenv too. Using virtualenv and autoenv is really simple. You just enter in the directory and the env automagically is set after setup. Actually, the autoenv just wrapps cd command to execute (when exists) a local script .env. In general my .env is just this:
source env/bin/activate

As mentioned in https://github.com/ryukinix/mal/issues/17, running it like so works and shows changes too:
 PYTHONPATH=. python decorating/test.py

Created PR: https://github.com/ryukinix/decorating/pull/18, if you can review please :+1:

@AlexK-IL Thanks for find that trip! ❤

Fixed after merge #18


short-circuit retry code when retries not configured

Pulling this out of #26766.
When the full retry code-path is enabled, users of the C++ API that fail to call Finish() before unreffing a call will see a memory leak.  This is a bug in the user's code, not a bug in gRPC, but until now the consequences of that bug have not been as severe.
To avoid immediate problems caused by this, this PR adds a short-circuit that bypasses the vast majority of the retry code if retries are not actually configured, even if the retry filter is enabled via the channel arg (which will soon be on by default).  This will limit the set of users affected by this problem: it will be a problem only for those that both (a) fail to call Finish() and (b) explicitly configure retries.
Note that this short-circuit will need to be removed when we implement transparent retries.  Before that happens, we will need to warn users that they need to make sure they are calling Finish() on every call.
CC @ctiller

The "Basic Tests C# Windows" failure is an infrastructure timeout.
Known issues: #26842 #26595

The C++ API does mandate invoking Finish().  Any application failing to do so is violating the API contract.  However, the consequences of doing that were not as bad prior to this change.
Unfortunately, it's not trivial to handle this in core in the C++ async API, in part because once the application unrefs the call, we have no guarantee that they will poll the CQ again.


Related picture

The picture that is related to a specific story is not always actual. Sometimes there is an icon of the Mrakopedia-specific bar.

https://github.com/pokatomnik/mrakopedia-api/pull/33


Import error encountered in jax_triton

Hello, I was running jax_triton on A100 and CUDA 12.2, but when I run the command python -c 'import jax_triton as jt', error occurs:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/lustre/grp/gyqlab/liyh/debugs/jax-triton/jax_triton/__init__.py", line 19, in <module>
    from jax_triton.triton_lib import triton_call
  File "/lustre/grp/gyqlab/liyh/debugs/jax-triton/jax_triton/triton_lib.py", line 50, in <module>
    from triton._C.libtriton import ir as tl_ir
ImportError: cannot import name 'ir' from 'triton._C.libtriton' (/lustre/grp/gyqlab/liyh/anaconda3/envs/jax_triton3/lib/python3.10/site-packages/triton/_C/libtriton.so)

My jax_triton was installed following https://github.com/google/jax/issues/18603

Hi @egg5154, which version of jax_triton and triton do you have?

Hi @egg5154, which version of jax_triton and triton do you have?

Hello, jax_triton is 0.1.4 and triton(triton-nightly) is 2.1.0.post20231216005823

I suspect you might need the main version of jax_triton. There was a number of refactorings in the Triton Python APIs, and the main version should be up to date, but 0.1.4 is definitely stale.

Ouch, sorry you have to deal with this. It is indeed quite tricky to find a working jax, jax_triton and triton combination.
If you are open to using Pallas instead of Triton directly, google/jax#19890 changed how Pallas-produced Triton kernels are compiled. We no longer need neither jax_triton, nor triton, as long as you install the nightly jaxlib and jax (starting tomorrow).

Ouch, sorry you have to deal with this. It is indeed quite tricky to find a working jax, jax_triton and triton combination.
If you are open to using Pallas instead of Triton directly, google/jax#19890 changed how Pallas-produced Triton kernels are compiled. We no longer need neither jax_triton, nor triton, as long as you install the nightly jaxlib and jax (starting tomorrow).

Thanks! Actually I want to use flash-attention in jax, it seems that Pallas can be used instead of Triton?


MyApp authentication does not work

Hi
I love rnplay to test react native component and have an idea of the behavior on my phone.
But I don't manage to get authenticated into the ios rnplay application to play my react native apps.
Any idea ?
Best
jeangui

Hello! Are you using the 'login with github'? What's your email?

Hello  @jsierles,
Yes I am using my github account (jeangui) and my mail is<EMAIL_ADDRESS>Just want to say that reactnative is awesome :)
And rnplay is too !!!
best
JG


Replace Tokens does not replace User ID token for web.config connection string

I have ran the Replace Tokens task many times for my config files and a common issue that ALWAYS happens is the task will not replace the user Id token in the connection string.
e.g. Data Source=dbServer;Initial Catalog=dbName;User=dbUser;Password=dbPassword
In this example, all tokens get replaced EXCEPT dbUser. There is nothing special with the user name and this happens 100% on all my projects. It only happens with the user id token as well.
I have tried renaming, using different token patterns with no luck. It is ONLY that token (after User Id =).
Does anyone know why this is happening? I am getting around it by hard-coding just the username but i would prefer to know why the user id doesn't get replaced.

Hi @quynhftw can you please add a variable called system.debug and set the value to true? Then post the logs here so that I can see them.

Closing due to inactivity - re-open if required!


Not getting face/object detection: ESOCKETTIMEDOUT

I'm following the quickstart in the docs for Docker Compose install. Everything seems to work properly, apart from the face/object detection. In the logs, I'm seeing lines like the ones below:
[2023-12-18 16:04:53.487]: index Updated file index for directory /data/Photos
[2023-12-18 16:04:53.545]: cli.spawn Run cli with extract --index /data/config/Photos.idx --storage /data/storage --api-server http://home-gallery-api-server:3000 --api-server-timeout 30 --api-server-concurrent 5 --journal 1218-gBOK
[2023-12-18 16:05:00.378]: index.readStream Reading file index journal /data/config/Photos.idx.1218-gBOK.journal
[2023-12-18 16:05:01.870]: extractor.image.resize Use sharp to resize images
[2023-12-18 16:05:32.472]: extractor Processed 5 entries (#5, +5, processing 11 and queued 0 entries)
[2023-12-18 16:05:32.720]: extractor.apiEntry warn Could not get face detection of 348c242:Photos:Sponsor/20220910134336_IMG_2449.JPG from URL http://home-gallery-api-server:3000/faces: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.737]: extractor.apiEntry warn Could not get face detection of 848f93b:Photos:Sponsor/20220910134337_IMG_2450.JPG from URL http://home-gallery-api-server:3000/faces: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.741]: extractor.apiEntry warn Could not get face detection of 1168991:Photos:Sponsor/20220910134338_IMG_2451.JPG from URL http://home-gallery-api-server:3000/faces: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.745]: extractor.apiEntry warn Could not get object detection of 904b76c:Photos:Sponsor/20220910134338_IMG_2452.JPG from URL http://home-gallery-api-server:3000/objects: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.749]: extractor.apiEntry warn Could not get object detection of ffee249:Photos:Sponsor/20220910134353_IMG_2453.JPG from URL http://home-gallery-api-server:3000/objects: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.754]: extractor.apiEntry warn Could not get similarity embeddings of 559147c:Photos:Sponsor/20220910134406_IMG_2455.JPG from URL http://home-gallery-api-server:3000/embeddings: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.759]: extractor.apiEntry warn Could not get similarity embeddings of 3bc48a0:Photos:Sponsor/20220910134417_IMG_2456.JPG from URL http://home-gallery-api-server:3000/embeddings: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.763]: extractor.apiEntry warn Could not get object detection of ec94438:Photos:Sponsor/20220910134405_IMG_2454.JPG from URL http://home-gallery-api-server:3000/objects: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.771]: extractor.apiEntry warn Could not get similarity embeddings of 7cc7c38:Photos:Sponsor/20220910134423_IMG_2457.JPG from URL http://home-gallery-api-server:3000/embeddings: Error: ESOCKETTIMEDOUT
[2023-12-18 16:05:32.777]: extractor.apiEntry warn Could not get similarity embeddings of b1cc51a:Photos:Sponsor/20220910134426_IMG_2458.JPG from URL http://home-gallery-api-server:3000/embeddings: Error: ESOCKETTIMEDOUT
[2023-12-18 16:06:02.878]: extractor.apiEntry warn Could not get face detection of 904b76c:Photos:Sponsor/20220910134338_IMG_2452.JPG from URL http://home-gallery-api-server:3000/faces: Error: ESOCKETTIMEDOUT
[2023-12-18 16:06:02.890]: extractor Processed 10 entries (#10, +5, processing 6 and queued 0 entries)
home-gallery-api-server is the name of the api container. This container is available and I can ping it from inside the homegallery container just fine:
$ docker exec -it home-gallery /bin/sh
~ $ ping home-gallery-api-server
PING home-gallery-api-server (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=42 time=0.461 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=42 time=0.342 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=42 time=0.300 ms
64 bytes from <IP_ADDRESS>: seq=3 ttl=42 time=0.315 ms
^C
--- home-gallery-api-server ping statistics ---
4 packets transmitted, 4 packets received, 0% packet loss
round-trip min/avg/max = 0.300/0.354/0.461 ms
I did try with the original http://api:3000 before, with the same result.
Any Idea what causes this?
Johan

Hi @JohanE67
thank you for reporting your issue.
I tested the docker compose installation instruction and was not able to reproduce your behavior. My setup worked out of the box.
What does docker compose logs api (replace api by your container setup) tells you? Can you post your docker-compose.yml as reference?
Which hardware and OS are you using?

Thanks for responding.
Here's the api container log (first lines):
home-gallery-api-server  | Loading tensorflow and models
home-gallery-api-server  | Load tensorflow width wasm backend in 406ms
home-gallery-api-server  | Loading model from /app/models/mobilenet-1-100/model.json
home-gallery-api-server  | Loaded mobilenet model in 2325ms
home-gallery-api-server  | Loaded faceapi model in 3292ms
home-gallery-api-server  | Loading model from /app/models/coco-ssd-mobilenet_v2/model.json
home-gallery-api-server  | Loaded coco ssd model in 6926ms
home-gallery-api-server  | Starting server
home-gallery-api-server  | Listen on port http://localhost:3000
home-gallery-api-server  | Setup api routes
home-gallery-api-server  | Server is up and running
home-gallery-api-server  | Read binary body with 76256 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 8190.299 ms - 148^[[0m
home-gallery-api-server  | Read binary body with 71199 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 8062.640 ms - 10514^[[0m
home-gallery-api-server  | Read binary body with 68219 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 5693.950 ms - 148^[[0m
home-gallery-api-server  | Read binary body with 85884 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 16388.810 ms - 104661^[[0m
home-gallery-api-server  | Read binary body with 50292 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 5546.344 ms - 148^[[0m
home-gallery-api-server  | Read binary body with 43491 bytes
home-gallery-api-server  | ^[[0mPOST /objects ^[[32m200^[[0m 3602.593 ms - 1204^[[0m
home-gallery-api-server  | Read binary body with 69313 bytes
home-gallery-api-server  | ^[[0mPOST /objects ^[[32m200^[[0m 3385.593 ms - 1330^[[0m
home-gallery-api-server  | Read binary body with 65406 bytes
home-gallery-api-server  | ^[[0mPOST /objects ^[[32m200^[[0m 3678.274 ms - 798^[[0m
And it goes on like this for 3839 lines up until now.
This is running on a Rock64, OS is ArmBian.

Docker-compose.yml:
version: "3.9"
services:
api:
# custom build via
#build: packages/api-server
image: xemle/home-gallery-api-server
container_name: home-gallery-api-server
environment:
# TensorflowJS backends
# - cpu: slowest and best support
# - wasm: good perfromance for arm64 and amd64 platforms
# - node: best performance on amd64 platform
#- BACKEND=cpu
- BACKEND=wasm
#- BACKEND=node
restart: unless-stopped
gallery:
# custom build via
#build: .
image: xemle/home-gallery
container_name: home-gallery
restart: unless-stopped
environment:
- GALLERY_API_SERVER=http://api:3000
#- GALLERY_API_SERVER_CONCURRENT=1 # On low powered devices
#- GALLERY_API_SERVER_TIMEOUT=60 # On low powered devices
- GALLERY_OPEN_BROWSER=false
# Use polling for safety of possible network mounts. Try 0 to use inotify via fs.watch
- GALLERY_WATCH_POLL_INTERVAL=300
volumes:
- ./data:/data
- /mnt/ssd/homegallery/storage:/data/storage
# Mount your media directories below /data
- /mnt/ssd/media/Photos:/data/Photos
#- ${HOME}/Pictures:/data/Pictures
ports:
- "3030:3000"
user: "${CURRENT_USER}"
entrypoint: ['node', '/app/gallery.js']
command: ['run', 'server']
networks:
default:
name: rommenet
external: true

Changes to gallery-config.yml:
sources:

dir: '/data/Photos'
#index: '{configDir}/{configPrefix}{basename(dir)}.idx'
excludes are using gitignore patterns
excludes:

'**/.filerun.thumbnails/'
#- .DS_Store
#- ._
#- '*.tmp'
'cache'
#excludeIfPresent: .galleryignore

apiServer:
url: http://home-gallery-api-server:3000
timeout: 30
concurrent: 5

Here's the api container log (first lines):
home-gallery-api-server  | Loading tensorflow and models
...
home-gallery-api-server  | Read binary body with 76256 bytes
home-gallery-api-server  | ^[[0mPOST /faces ^[[32m200^[[0m 8190.299 ms - 148^[[0m
...

And it goes on like this for 3839 lines up until now.

So this looks good so far. So there are some requests to the internal docker api-server.
However it is a bit tricky to configure the gallery between docker environment and the configuration. The environment should overrule the configuration. So setup the api host in the docker-compose.yml would be a better place with
    environment:
      - GALLERY_API_SERVER=http://home-gallery-api-server:3000
      - GALLERY_API_SERVER_CONCURRENT=1 # On low powered devices
      - GALLERY_API_SERVER_TIMEOUT=60 # On low powered devices

than in the gallery.config.yml.
Apparently the configuration of gallery.config.yml is taken instead of the environment... Which is more a bug than a feature IMHO.

This is running on a Rock64, OS is ArmBian.

Are there any ...-faces.json, ...-objects.json or ...-similarity-embeddings.json files in the data/storage directory? I guess so. On low powered SoC systems like your congestion will appear. The extractor is pushing to fast new images to the api-server which needs time to process. So after some time the api-server slows down and the timeout on the extractor happens.
The log shows:
[2023-12-18 16:04:53.545]: cli.spawn Run cli with extract --index /data/config/Photos.idx --storage /data/storage --api-server http://home-gallery-api-server:3000/ --api-server-timeout 30 --api-server-concurrent 5 --journal 1218-gBOK

where --api-server-concurrent 5 is set to a high value for an embedded CPU system. Please set it to 1. Also increase the timeout to 60 as the comments in the docker-compose.yml in the docs suggests.
Please finalize all your imports and run docker compose run gallery run import at the end to fix all missing import steps and face detections. By default the import is executed by smaller chunks. If you run docker compose run gallery run import in between it will import all files in once which might be take time (e.g. for video previews) until you see any results. run import is a command to recheck that everything is in place.

Ok, thanks for the explanations. Maybe it would be a good idea to provide in the docs some more explanation on what a "low powered device" exactly means. Since the docs start with the software being built for Raspberry Pi type systems, I didn't consider mine (quad-core, 4GB mem) as particularly low-powered...

Are there any ...-faces.json, ...-objects.json or ...-similarity-embeddings.json files in the data/storage directory? I guess so.
Yes there are!

I will follow your suggestion, let the current import run to completion, then change the configurations and run a full import again. I will report results here. Thanks again for the help.
Johan

@JohanE67 I've updated the docker-compose.yml to clarify the options. Also the compose env now overwrites the config (3da6389).
These fixes are released in v1.14.5

@JohanE67 I've updated the docker-compose.yml to clarify the options. Also the compose env now overwrites the config (3da6389).
These fixes are released in v1.14.5

Thanks for the updates.
I guess I was confused by the statement "on low-powered SoCs". This led me to believe there would be a distinction between hi-powered (e.g. Pi 3b/4) and low-powered (e.g Pi1/2, Pi Zero) SoCs. I never took PCs/Servers into account here. So yes, I think this change in the docker-compose.yml is an improvement.
Meanwhile, the initial import had finished. I updated the config, pulled the new image and am now running a full import. Not seeing error messages, so it's looking good!

Meanwhile, the full import had completed successfully and everything appears to be in order now. I'm closing this issue. Thanks again for the help.

Awesome. Thank you for your feedback.


IWYU fixes for QueryExecutionUtil.

Assigned to @hbdeshmukh.
Minor fixes to the file QueryExecutionUtil.hpp, including iwyu.

Looks good to me. Merging.


Bump up version to 0.2.11

Codecov Report
Base: 99.38% // Head: 99.38% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (12af9e6) compared to base (64af351).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   99.38%   99.38%   -0.01%
==========================================
  Files          20       18       -2
  Lines         648      646       -2
==========================================
- Hits          644      642       -2
  Misses          4        4

Flag
Coverage Δ

unittests
99.38% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

runtime/databricks/__init__.py

...ime/databricks/automl_runtime/forecast/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


"Invalid json format" syslog output

While running sudo journalctl -xef --no-pager during a HDD_db script update (after a DSM update).. i see these logs:

synostgdisk[13736]: disk/disk_sb_firm_status_get.cpp:141 Invalid json format: {"compatibility_interval":[{"barebone_installable":true,"compatibility":"support","fw_dsm_update_status_notify":false,"not_yet_rolling_status":"support","smart_attr_ignore":false,"smart_test_ignore":false}]}

The logged string is valid JSON as far as I can tell... So I'm not sure what thats about. Thoughts?
(About to reboot so we'll see if anything persists on the other side)
This was after an update from DSM 7.2.0-XXXXX Update 3 to DSM 7.2.1-69057 Update 4

Some logs from right after the restart as bootup was finishing:

everything looks fine otherwise.
but perhaps there's a rogue hdd db entry that's missing something key?

I get those log entries as well. I couldn't find anything invalid with the string.

Which version of the script did you use?
Which Synology NAS do you have? And does it have a M2D20, M2D18 or E10M20-T1 with NVMe drives installed?
I just checked all my DS1821+ .db files and ds1821+_e10m20-t1_v7.db contains an extra } on the 3rd last line (when the file is formatted).
It has this:
        }
    }
}, "nas_model": "ds1821+"
}

when it should have this:
        }
    }, "nas_model": "ds1821+"
}

Before editing the M2D20, M2D18 and E10M20-T1 db files are what I call empty db7 files:
{
    "disk_compatbility_info": {},
    "nas_model": "ds1821+"
}

I've released a new version that fixes the invalid json string issue.
https://github.com/007revad/Synology_HDD_db/releases/tag/v3.4.87
It won't replace the existing invalid ]}}}}, in your db file(s) with the correct ]}}},
To fix them you can run the script with the --restore option, then run it with your preferred options.

I'm still getting those log entries after I run synostgdisk --check-all-disks-compatibility
What is strange is that none of the files in /var/lib/disk-compatibility contain the string in the log, which has the key value pairs sorted:
{
    "compatibility_interval": [{
            "barebone_installable": true,
            "compatibility": "support",
            "fw_dsm_update_status_notify": false,
            "not_yet_rolling_status": "support",
            "smart_attr_ignore": false,
            "smart_test_ignore": false
        }
    ]
}

All of the .db files in my /var/lib/disk-compatibility contain the string with key value pairs in the following order:
{
    "compatibility_interval": [{
            "compatibility": "support",
            "not_yet_rolling_status": "support",
            "fw_dsm_update_status_notify": false,
            "barebone_installable": true,
            "smart_test_ignore": false,
            "smart_attr_ignore": false
        }
    ]
}

I get one of those log entries for each drive around 5:30am every day, and then 2 more time about 13 minutes apart.
It looks like DSM checks drive compatibility every morning, as well as a boot and when a new drive is installed.


feat(minimal inputdropdown): update Minimal Dropdown Style

Summary
Structural Element (Base, Gene, DNA, Chromosome or Cell)
Ticket: #337
Component Name: InputDropdown
Component Requirements: - New component variation, specific parameters as below
sdsType: single-select
sdsStyle: minimal
Details: on
Design link: https://www.figma.com/file/v8T3vabzkmbvH71sQ1EXzh/Kevin---Heatmap-Filters-Redesign?node-id=1047%3A35901&t=8JY2ukyrEk5NnJ6M-1
Team(s) Requesting: CZID
Component Needed By: This is part of the Heatmap - Move Filters to the left project. I will share the eng point of contact after handoff
Plan Details:
There is a version of this that exists but does not match the full requirements, we will take what exists in the code and updating it
Checklist

[x] Default Story in Storybook
[x] LivePreview Story in Storybook
[x] Test Story in Storybook
[x] Tests written
[x] Variables from defaultTheme.ts used wherever possible
[x] If updating an existing component, depreciate flag has been used where necessary
[ ] Chromatic build verified by @chanzuckerberg/sds-design

@clarsen-czi The label size should be updated now!

@masoudmanson We have made the update requested by Connor if you want to check! Thanks!

Before committing any code changes, it's important to run yarn test -u to update the previous test snapshots. The current error in GitHub checks (Push Tests failure) is likely occurring because the test snapshots are outdated. @liaprins


Remove content on installing Microsoft.Identity.Web.ProjectTemplates

This topic has the same issue as https://github.com/MicrosoftDocs/azure-docs/issues/104955.
The bit that asks the reader to install the Microsoft.Identity.Web.ProjectTemplates templates can be removed. They're at 5.0 anyway, which is quite stale at this point. The command will use the template from the SDK anyway. They get numbered when the CLI tries to install them from separate packages with the same name ... blazorserver, blazorserver2, blazorserver3, etc. The command to create the app uses blazorserver, so it will use the SDK template, which we presume will be the first one installed (not numbered) if the reader is following the topic steps in order.
Recommend deleting this bit ...

Run the following command to download the templates for Microsoft.Identity.Web, which we'll make use of in this tutorial.
.NET CLI
dotnet new --install Microsoft.Identity.Web.ProjectTemplates

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e1279b6d-8210-1751-8e37-cf544cd3695d
Version Independent ID: 6dc2d359-8d50-1df3-7983-29fb06bfdbb6
Content: Tutorial - Create a Blazor Server app that uses the Microsoft identity platform for authentication - Microsoft Entra
Content Source: articles/active-directory/develop/tutorial-blazor-server.md
Service: active-directory
Sub-service: develop
GitHub Login: @henrymbuguakiarie
Microsoft Alias: henrymbugua

@guardrex
Thanks for your feedback! We will investigate and update as appropriate.

Thanks ... I'll just note here that it's for both topics. The Blazor Server topic requires the same update ...
https://learn.microsoft.com/en-us/azure/active-directory/develop/tutorial-blazor-server

@guardrex
I'm going to assign this to the document author so they can take a look at it accordingly.

@henrymbuguakiarie
Can you please check and add your comments on this doc update request as applicable.

Hello @guardrex,
Thank you for your efforts in improving our content. You were correct, and there's no need to run the command dotnet new --install Microsoft.Identity.Web.ProjectTemplates as the project templates are already integrated into .NET 7. I have resolved the issue.

Thanks @henrymbuguakiarie ... What PR was the update performed on?

Hello @guardrex,
Here are the PRs:

https://github.com/MicrosoftDocs/azure-docs-pr/pull/226829
https://github.com/MicrosoftDocs/azure-docs-pr/pull/226813

Note:
I will take action to improve this tutorials by making some enhancements in the near future.

That seems strange to me because that isn't a public repo and isn't where the content resides AFAICT ...

https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/active-directory/develop/tutorial-blazor-server.md
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/active-directory/develop/tutorial-blazor-webassembly.md

I'm not familiar with the process over here. I guess what you meant by your last remark is that those files will be updated later.
This isn't a major problem as long as they install the SDK first. If they don't install it or don't install it first, these docs should be considered ... IMO ... broken 💥. I recommend updating the topic quickly, but it's your call ... of course. Thanks again for your help. I'm good. 😄

Hello @guardrex,
You're right, it's not a big deal, and the SDK in the prerequisites will resolve the problem.
Thank you again for contributing and enhancing our content.


Pytorch Issue Windows

I try to install pytorch and after days of trying Im here with a big, big problem. I read a lot of articles of "how to install pytorch" I try to install with pip install but dont work for me and after I install it with Anaconda, but in anaconda is pytorch install, when I type: conda list, he is there like this form: pytorch                   1.0.1           py3.7_cuda100_cudnn7_1    pytorch, I have python 3.7, when I run a code with import torch this show me a message like this:

And when i try to import torch in python 3.7:

Pip install error:

How to pass this errors? Please Help, thx.

Hi,
PyTorch isn't needed to use kglib! All of the dependencies for kglib will be installed automatically when you pip install grakn-kglib, using Python 3.6. For installation instructions please follow the Quickstart in the READMEs.
If you encounter issues installing kglib in this way then please open a new issue. Since PyTorch isn't required for kglib I will close this issue.

Don`t work.


High contrast

Could you generate colors with high contrast for accessibility?
CSS has prefers-contrast media feature for the colors.
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-contrast
The web needs the colors for light and dark theme.
You can add the colors to requested export https://github.com/material-foundation/material-theme-builder/issues/25
html.high-contrast {
}

html.dark.high-contrast {
}

https://web.dev/building-a-color-scheme/
demo https://unifyned.com/colors.html

Thanks for the feedback! Definitely want to support this feature but waiting on guidance for the values


Adding Animated Buttons - GSSoC'23

This is a(n):

[x] Update to an existing Animated Button
[x] Any Error
[ ] Proposal to the Repository
[ ] Documentation / README.md changes

Details:

I want to work on this issue as a contributor.
Pleasure Assign so that I can show my skills under GSSoC'23.

I have made a new animated button and sent the PR. Kindly check and do the needful.

I have made the desired changes. Please accept my PR

Have made the button. Please have a look to merge the branch


Fixed fail of "git check-attr" file path

When filename contains brackets or apostrophes:
Jonh's test.txt
Old test (check later).txt

the "git check-attr" command fails and stops the whole process
/bin/sh: 1: Syntax error: "(" unexpected

The fix is simple and easy - use quotes on file path.

Thank you for pointing to the problem.

Closed in favor of #50.


request the clusterclaim docs

Below was the current docs this repo have.
% tree docs
docs
├── clusterhealthcheck.md
├── clusterjoinprocess.md
├── clusterset.md
├── design.md
├── development.md
└── manifestwork.md

0 directories, 6 files

@qiujian16 do we have any docs to describe the clusterclaim

the design doc is here https://github.com/open-cluster-management-io/enhancements/tree/main/enhancements/sig-architecture/4-cluster-claims. But it will be good if we also have doc here to briefly describe it.
FYI @elgnay


Add path-specific error handlers

This allows to have specific error handlers based on paths.
The paths can be inclusive (meaning that the error handler will be executed when any path matches as root of the file the error occurred in) or exclusive (meaning that the error handler will be executed when no path matches as root of the file the error occurred in)
This allows to initialize the library with ErrorHandlers that will only be triggered for Errors coming from certain folders or that are not triggered within certain folders,
\Org_Heigl\ErrorFocus\ErrorFocus::init([], [
    [
        'paths'     => [__DIR__ . '/../vendor'],
        'paths_are' => 'inclusive',
        'handler'   => [$myErrorHandlerInstance, 'myErrorHandlerMethod'],
    ], [
        'paths'     => [__DIR__ . '/../src', __DIR__ . '/../lib'],
        'paths_are' => 'exclusive',
        'handler'   => $myInvocableInstance,
    ], [
        'paths'     => [__DIR__ . '/../src'],
        'paths_are' => 'inclusive',
        'handler'   => [MyStaticErrorHandler::class, 'myStaticErrorHandlerMethod'],
]);

$myErrorHAndlerInstance->myErrorhandlerMethod will be callend for all errors that originate in the vendor-folder,
$myInvocalbeInstance() will be called for all errors that originate outside the src or the lib folder and
MyStaticErrorHandler::myStaticErrorHandlerMethod will be called for all errors that originate in the src folder.
All possible handlers will be called.

@Jan0707 would this have helped you?


Reimage Support for Non-Ephemeral VMs

@srcharug looks good. just resolve PrettierCheck failure

looks good !


In jazzer,when i run "bazel coverage ",throws ClassNotFoundException.

I want to use build coverage in jazzer.When I run “bazel run //examples:ExampleFuzzerWithUBSan”,got success.But  when I run “bazel coverage //examples:ExampleFuzzerWithUBSan”,the testlog print out:
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //examples:ExampleFuzzerWithUBSan
-----------------------------------------------------------------------------
singlejar_local: ./src/tools/singlejar/mapped_file_posix.inc:42: open /private/var/tmp/_bazel_xyt/b041260c26ede733a242223b95e6c3b7/sandbox/darwin-sandbox/1117/execroot/jazzer/bazel-out/darwin_arm64-opt/bin/examples/ExampleFuzzerWithUBSan.runfiles/fmeum_rules_jni/jni/tools/libjvm_stub/coverage/CoverageAgent.jar:: No such file or directory
singlejar_local: src/tools/singlejar/input_jar.cc:23: Cannot open input jar /private/var/tmp/_bazel_xyt/b041260c26ede733a242223b95e6c3b7/sandbox/darwin-sandbox/1117/execroot/jazzer/bazel-out/darwin_arm64-opt/bin/examples/ExampleFuzzerWithUBSan.runfiles/fmeum_rules_jni/jni/tools/libjvm_stub/coverage/CoverageAgent.jar: No such file or directory
OpenJDK 64-Bit Server VM warning: CriticalJNINatives specified, but not supported in this VM
INFO: Loaded 147 hooks from com.code_intelligence.jazzer.runtime.TraceCmpHooks
INFO: Loaded 4 hooks from com.code_intelligence.jazzer.runtime.TraceDivHooks
INFO: Loaded 2 hooks from com.code_intelligence.jazzer.runtime.TraceIndirHooks
INFO: Loaded 4 hooks from com.code_intelligence.jazzer.runtime.NativeLibHooks
INFO: Loaded 8 hooks from com.code_intelligence.jazzer.sanitizers.Deserialization
INFO: Loaded 5 hooks from com.code_intelligence.jazzer.sanitizers.ExpressionLanguageInjection
INFO: Loaded 70 hooks from com.code_intelligence.jazzer.sanitizers.LdapInjection
INFO: Loaded 50 hooks from com.code_intelligence.jazzer.sanitizers.NamingContextLookup
INFO: Loaded 1 hooks from com.code_intelligence.jazzer.sanitizers.OsCommandInjection
INFO: Loaded 48 hooks from com.code_intelligence.jazzer.sanitizers.ReflectiveCall
INFO: Loaded 8 hooks from com.code_intelligence.jazzer.sanitizers.RegexInjection
[rules_jni] Failed to collect coverage for native libraries:
java.lang.ClassNotFoundException: javax/com/github/fmeum/rules_jni/gen/jazzer_driver_2690633507
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at com.code_intelligence.jazzer.bootstrap.com.github.fmeum.rules_jni.CoverageHelper.callHelperMethod(CoverageHelper.java:160)
	at com.code_intelligence.jazzer.bootstrap.com.github.fmeum.rules_jni.CoverageHelper.initCoverage(CoverageHelper.java:39)
	at com.code_intelligence.jazzer.bootstrap.com.github.fmeum.rules_jni.RulesJni.loadLibrary(RulesJni.java:121)
	at com.code_intelligence.jazzer.bootstrap.com.github.fmeum.rules_jni.RulesJni.loadLibrary(RulesJni.java:93)
	at com.code_intelligence.jazzer.runtime.TraceDataFlowNativeCallbacks.<clinit>(TraceDataFlowNativeCallbacks.java:26)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at com.code_intelligence.jazzer.api.Jazzer.<clinit>(Jazzer.java:49)
	at com.code_intelligence.jazzer.sanitizers.RegexRoadblocks.<clinit>(RegexRoadblocks.java:72)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at com.code_intelligence.jazzer.instrumentor.Hooks$Companion$HooksLoader.loadHooks(Hooks.kt:85)
	at com.code_intelligence.jazzer.instrumentor.Hooks$Companion$HooksLoader.load(Hooks.kt:67)
	at com.code_intelligence.jazzer.instrumentor.Hooks$Companion.loadHooks(Hooks.kt:61)
	at com.code_intelligence.jazzer.agent.Agent.install(Agent.kt:102)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.code_intelligence.jazzer.agent.AgentInstaller.install(AgentInstaller.java:59)
	at com.code_intelligence.jazzer.driver.FuzzTargetRunner.<clinit>(FuzzTargetRunner.java:55)
	at com.code_intelligence.jazzer.driver.Driver.start(Driver.java:88)
Did expect a crash, but Jazzer exited with exit code 1
--
Coverage runner: Not collecting coverage for failed test.
The following commands failed with status 1
/private/var/tmp/_bazel_xyt/b041260c26ede733a242223b95e6c3b7/sandbox/darwin-sandbox/1117/execroot/jazzer/bazel-out/darwin_arm64-opt/bin/examples/ExampleFuzzerWithUBSan.runfiles/jazzer/examples/ExampleFuzzerWithUBSan driver/jazzer_driver_ubsan agent/jazzer_api_deploy.jar examples/ExampleFuzzerWithUBSan_target_deploy.jar  True False True  --jvm_args=-Djazzer.native_lib=native_ubsan

In jazzer/bazel-out/darwin_arm64-opt/bin/examples/ExampleFuzzerWithASan.runfiles/fmeum_rules_jni/jni/tools/libjvm_stub/coverage/ ,just have a coverage_deploy.jar,so it build failed.

Jazzer is unfortunately a bit of a tricky case as it contains two shaded copies of rules_jni and appends a jar using it to the bootstrap classpath. We are currently working on simplifying the architecture further. When that is done, I will look into whether this use case is still broken.
If what you are really interested in is fuzz test coverage, I would instead guide you to use https://github.com/bazelbuild/rules_fuzzing, to which I intend to add Java coverage soon after the Jazzer refactoring is done.


update readme

Reasons

having difficulties running on windows machine
unable to launch air hot reload server

Description

added a side note section for Windows users on things they have to be aware of when running the app using task dev or air

@bmdavis419 can have a review. thank you


Update ChatPopout to Foundry VTT 0.7.9

Which class should be updated?
ChatPopout
For which version should the class be updated?
Foundry VTT 0.7.9

Taking this.


After deploying catalog getting error every other time I go to Apps page

Rancher versions: 5/22
Steps to Reproduce:

Deploy my load balancer template from catalog
After deploying, go back and forth to Apps page

Results:  Error page comes up.

Version - 5/25
Verified fixed


Is it possible to configure an ALB?

Is it possible to configure an Application Load Balancer and expose the container via public DNS?
Thanks

See my answer here: https://github.com/eddmann/serverless-fargate/issues/13#issuecomment-1498648378

@QAnders Thanks for the answer :)


Publication shouldn't fail if no build scans to publish

It can happen that there is no build scans to publish even if the previous workflow was a success (typically if you only push build scans on failure or, in the case of Quarkus, if the build actually runs only if not a draft PR).
The publication shouldn't fail in this case.
See for instance:
https://github.com/quarkusio/quarkus/actions/runs/6811712001/job/18522603921

Fixed by not failing if artifact is not found


[BUG] Automobiles glitching out on contraptions (Create)

What is the issue?
Automobiles glitch out on many types of contraptions, a good example of this are trains. Elevators and other types of contraptions behave the same and rarely work. If the contraption moves vertically it can even kick the player in the automobile as Minecraft considers them flying.
Screenshots

It's an entity synchronization problem.


Towards Head Pose Recognition

I was able to compile OpenCV solvePnP to wasm and identify head pose using the facial landmarks provided by face-api.
I would appreciate if the confidence of the points were informed so that I'm only using "good" points to solve the PnP and I'm able to ignore occluded points.

Is that a low hanging fruit or would a new network be needed?

And as far as work should be done...

Would this project be willing to support this approach to solving head pose as "oficial"? Should I focus my efforts on a fork to be potentially accepted as PR here or should I work on a library to be used along face-api.js?

OpenCV solves the pnp really fast (16fps on webcam example with it disabled to 15fps with it enabled) but it is a HUGE to download (I was able to trim it down to 2MB -no compression- and I believe it could decrease more)
Try it on my fork, run browser examples and check webcam landmark demo (beware: really BAD UGLY code just for experimenting right now)
Here is a demo of cv.solvePnPRansac(solver=SOLVEPNP_UPNP)  + cv.solvePnPRefineVVS + kalman filter on the lowest resolution using tinynet for both networks.

I ended up training an AI that solves the PnP problem.
It's being used to run my project: https://filtrou.me
The project is open sourced here: https://github.com/lucasavila00/filtroume
Feel free to use my code and AI any way you would like!
@justadudewhohacks would you be willing to integrate it with face-api.js?
I wrote a blog post explaining how stuff works: https://filtrou.me/build-one-yourself/
If you're curious as to how to train the AI there is a notebook explaining everything here: https://github.com/lucasavila00/filtroume/blob/master/tf/all.ipynb


chore: created shared utils package and moved objectKeys function to it

Description
Created a shared utils package to move common util functions to it. This PR currently handles the objectKeys function which was earlier being used from design-system package.
This PR also introduces a way to create your own eslint custom rule for the project. All the steps are mentioned in the Readme for the same in packages/eslint-plugin.
Fixes #35508
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10496264195
Commit: 75ac33d022dd3670d6d20a92e66fc671d4c50572
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:
cypress/e2e/Regression/ClientSide/ProductRamps/PrivateEmbedRamp_spec.ts
List of identified flaky tests.
Wed, 21 Aug 2024 20:51:40 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Introduced a new utility package (@appsmith/utils) to enhance functionality across the application.
Added an ESLint plugin to enforce the use of objectKeys, improving coding practices.
Implemented Jest configuration for testing TypeScript files, facilitating a robust testing environment.

Bug Fixes

Resolved redundancy in @appsmith/utils dependencies to streamline package management.

Documentation

Created essential configuration files for the ESLint plugin and Jest, enhancing integration and usage guidelines.

Chores

Established ESLint configuration for the new utility package and improved overall code quality through consistent coding standards.

@AmanAgarwal041 Can we merge this? Are there any pending comments to be resolved?

@AmanAgarwal041 Can we merge this? Are there any pending comments to be resolved?

It was some client linting error that were coming. I have fixed those. Waiting for the test to pass.

@AmanAgarwal041 Can we merge this? Are there any pending comments to be resolved?

It was some client linting error that were coming. I have fixed those. Waiting for the test to pass.

Looks like all of them have passed.


[mac] enable Beacon Payload in outgoing beacons

Supplement PR to 7736
This PR enables beacon payloads on outgoing beacons to prevent backward compatibility issues with existing devices in the market.

I can't see how this PR fixes backward compatibility issues. There are four scenarios:

Old joiner and old network
Beacons contain payload and joiner uses it for commissioning purposes. MLE Discovery can be used as well.
Old joiner and new network
Backwards compatibility is broken since the joiner expects beacons payload which is not present. But this PR doesn't fix it.
New joiner and old network
Beacons contain payload but joiner has no code to parse it. Anyway, since it's a new development the joiner can be adapted for using MLE Discovery instead.
New joiner and new network
No payload in beacons, MLE Discovery must be used.

Am I missing something?

@edmont Thank you for your response. The scenarios you list are correct, and this PR tries to mitigate an issue close to 3rd scenario that you list. We have an issue with a joiner not being able to parse the beacons from old network.
The issue is that if the joiner is not a new development but instead has an established business logic and application state machine, and just wants to update the stack, the joining won't work. It would be troublesome to change the logic now and when we try to upgrade the stack we see that the joining won't work anymore.

@hemanth-silabs is this issue related to a device that doesn't actually use meshcop joining? I ask because I discovered a commercially available Thread device that I know uses Silabs and can not attach to my border router with the beacon payload changes. If so, this set of changes don't appear to actually resolve it (I built with these commits and still saw the issue).

@jwhui @abtink @edmont Please have a look at this PR. This Pr enables beacon payload in beacons to avid backward compatibility issues for old devices trying to join new networks.
This is the conversation we had on the previous PR.

@romacdon @suveshpratapa @gabekassel This PR is to address the other backward compatibility issues we were seeing on existing devices in the market trying to join new networks. Changes are disabled by default and can be enabled by passing the that OPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_ENABLE=1 while building.

@gabekassel it would be great if you could try out the changes in this PR and verify that it fixes the issue you are experiencing.

@hemanth-silabs , can you help rebase this PR to fix some of the CI failures?

@hemanth-silabs , can you help rebase this PR to fix some of the CI failures?

Thanks @jwhui. Just did a rebase hopefully this fixes the failures.

@gabekassel it would be great if you could try out the changes in this PR and verify that it fixes the issue you are experiencing.

@romacdon I built this with -DOPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_ENABLE=1 defined in my cmake args and still see failure with the commercial device in question.

@gabekassel it would be great if you could try out the changes in this PR and verify that it fixes the issue you are experiencing.

@romacdon I built this with -DOPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_ENABLE=1 defined in my cmake args and still see failure with the commercial device in question.

Thanks @gabekassel. Can you provide a packet trace so that @hemanth-silabs and @suveshpratapa can debug it.

@gabekassel it would be great if you could try out the changes in this PR and verify that it fixes the issue you are experiencing.

@romacdon I built this with -DOPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_ENABLE=1 defined in my cmake args and still see failure with the commercial device in question.

Thanks @gabekassel. Can you provide a packet trace so that @hemanth-silabs and @suveshpratapa can debug it.

Attached, though not sure I'm capturing everything desired. This is wireshark using pyspinel setup with the network key. On the OTBR logging side, I just see continual beacon requests.

@gabekassel it would be great if you could try out the changes in this PR and verify that it fixes the issue you are experiencing.

@romacdon I built this with -DOPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_ENABLE=1 defined in my cmake args and still see failure with the commercial device in question.

Thanks @gabekassel. Can you provide a packet trace so that @hemanth-silabs and @suveshpratapa can debug it.

Attached, though not sure I'm capturing everything desired. This is wireshark using pyspinel setup with the network key. On the OTBR logging side, I just see continual beacon requests.

beacon_payload.pcapng.zip

Thanks again @gabekassel - I'll defer to @suveshpratapa and @hemanth-silabs now to see if this is enough info to figure why the change did not solve the issue.

@edmont @abtink Can you guys please review this PR as well?

Silabs team and I did some live testing today, and these changes resolve the interop issues I've observed in ToT before these changes. cc: @jwhui @ndyck14

Silabs team and I did some live testing today, and these changes resolve the interop issues I've observed in ToT before these changes. cc: @jwhui @ndyck14

Thanks @gabekassel for testing this again!!

@edmont @jwhui @gabekassel @abtink - I know this may be asking a lot but it would help the Silabs folks meet some internal deliverables if we could get this reviewed and merged today.  I'm hoping the successful testing we did with Gabe gives you confidence in the changes as you review the PR.

The change in this PR look fine.
I noticed one possible situation with mNetworkName field in BeaconPayload. I think it may not be null terminated in all cases (if we have max length network name) so treating it as a C string may not be correct in all cases.
Added some suggestions below:

@abtink I have reverted the changes that was using network name as c string and now it uses NameData as it was done before. Please have a look.

@edmont Do you have any inputs on this PR?

@edmont Do you have any inputs on this PR?

In general I'm okay with the change, still I'd prefer to have the beacon payload configurable even when defaults to 1, since it's an out of spec feature now.

@edmont Do you have any inputs on this PR?

In general I'm okay with the change, still I'd prefer to have the beacon payload configurable even when defaults to 1, since it's an out of spec feature now.

@edmont I have added the beacon payload creation under a new macro which is enabled by default. Can you have a look please?

@jwhui Looks like we have a consent here. @gabekassel yesterday confined the fix and @edmont okayed the changes with a request to provide a way to disable beacon payload if needed. I have updated the PR with a new configuration, that is enabled by default but can be disabled if needed.
Can you have a look and if the changes are OK, can you merge the PR?

Can you have a look and if the changes are OK, can you merge the PR?

@hemanth-silabs , it appears that some CI tests are failing.
======================================================================
ERROR: test (__main__.Cert_5_8_04_SecurityPolicyTLV)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/thread_cert.py", line 304, in tearDown
    self._verify_packets(test_info_path)
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/thread_cert.py", line 333, in _verify_packets
    self.verify(pv)
  File "./tests/scripts/thread-cert/Cert_5_8_04_SecurityPolicyTLV.py", line 352, in verify
    pkts.filter_wpan_src64(LEADER).\
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/pktverify/packet_filter.py", line 234, in must_next
    raise errors.PacketNotFound(self.index, self._stop_index)
pktverify.errors.PacketNotFound: ((190, 190), (275, 275))

----------------------------------------------------------------------

I believe this test is checking whether the beacon payload is properly excluded when the B flag is not set in the Security Policy TLV. Of course, this PR includes this beacon payload without respecting the B flag. We could simply remove the check from the CI here. But the CI test implements Thread Certification Test 5.8.4, which includes a check that the Beacon payload is not included when the B flag is cleared. Unless the Thread Certification Test Specification is updated, I expect a similar failure in the Thread Test Harness as well. Thoughts?

Can you have a look and if the changes are OK, can you merge the PR?

@hemanth-silabs , it appears that some CI tests are failing.
======================================================================
ERROR: test (__main__.Cert_5_8_04_SecurityPolicyTLV)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/thread_cert.py", line 304, in tearDown
    self._verify_packets(test_info_path)
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/thread_cert.py", line 333, in _verify_packets
    self.verify(pv)
  File "./tests/scripts/thread-cert/Cert_5_8_04_SecurityPolicyTLV.py", line 352, in verify
    pkts.filter_wpan_src64(LEADER).\
  File "/home/runner/work/openthread/openthread/tests/scripts/thread-cert/pktverify/packet_filter.py", line 234, in must_next
    raise errors.PacketNotFound(self.index, self._stop_index)
pktverify.errors.PacketNotFound: ((190, 190), (275, 275))

----------------------------------------------------------------------

I believe this test is checking whether the beacon payload is properly excluded when the B flag is not set in the Security Policy TLV. Of course, this PR includes this beacon payload without respecting the B flag. We could simply remove the check from the CI here. But the CI test implements Thread Certification Test 5.8.4, which includes a check that the Beacon payload is not included when the B flag is cleared. Unless the Thread Certification Test Specification is updated, I expect a similar failure in the Thread Test Harness as well. Thoughts?

@jwhui @hemanth-silabs Sounds like we should not enable OPENTHREAD_CONFIG_MAC_BEACON_PAYLOAD_PARSING_ENABLE for the test.

I agree. I think for all certification builds, we can and should safely turn this feature off. This should only be included for production devices to enable backward compatibility. Is there a macro that defines the build is for a test device? If so, maybe we can link both the macros in mac.h

I agree. I think for all certification builds, we can and should safely turn this feature off. This should only be included for production devices to enable backward compatibility. Is there a macro that defines the build is for a test device? If so, maybe we can link both the macros in mac.h

@jwhui @suveshpratapa What if we disable the beacon payload if OT_REFERENCE_DEVICE is defined?

I agree. I think for all certification builds, we can and should safely turn this feature off. This should only be included for production devices to enable backward compatibility. Is there a macro that defines the build is for a test device? If so, maybe we can link both the macros in mac.h

@jwhui @suveshpratapa What if we disable the beacon payload if OT_REFERENCE_DEVICE is defined?

This sounds good to me.

I agree. I think for all certification builds, we can and should safely turn this feature off. This should only be included for production devices to enable backward compatibility. Is there a macro that defines the build is for a test device? If so, maybe we can link both the macros in mac.h

To clarify, I believe any DUT with this feature enabled will currently fail Thread Certification with the current Thread Test Specification.

I agree. I think for all certification builds, we can and should safely turn this feature off. This should only be included for production devices to enable backward compatibility. Is there a macro that defines the build is for a test device? If so, maybe we can link both the macros in mac.h

To clarify, I believe any DUT with this feature enabled will currently fail Thread Certification with the current Thread Test Specification.

The only way out then is just disable it by default and enable it in specific applications @romacdon @gabekassel.

@jwhui @suveshpratapa @romacdon @gabekassel I have disabled including beacon payload by default. And letting the applications enable the feature as necessary. This is due to the fact that it impacts thread certification tests.

Sorry, I'm late to the discussion, but I agree with the changes.

Sorry, I'm late to the discussion, but I agree with the changes.

No issues @edmont and thank you for your feedback!!


provide a command for just getting fileId

In relation to @canpolat 's comment here https://github.com/odeke-em/drive/issues/530#issuecomment-167234978 where he had to link to StackOverflow and use the Google Drie UI, it might be beneficial for drive to have a command to just solely list fileIds outside of stat or list calls.
$ drive list --long [paths...]

can already cut the deal but by the time a frequent user hasn't discovered this shows that there is a need to make this a more visible command so that users won't have to stress opening and copying fileIds.

@odeke-em, thank you for the feature.
I'm a frequent (daily) user, but I cannot say I use (or even know) many features of drive. I basically have a working flow where all drive commands are hidden in scripts, and I only occasionally use drive manually. So, please don't consider me as a power user for drive :)
I have been thinking about contributing to the documentation recently, but unfortunately could not find the time. Maybe doing so will help me use more advanced features and provide better support when I stumble upon questions here ;) It's in my TODO list. But we will see when I can have a look at it.

Thank you thank you @canpolat. No worries, that power usage is gonna come through soon. I appreciate the contributions  and ideas👏🏾.
Aha I know why it showed up in your inbox, when making release notes for @canpolat last Sunday, I fixed a mis-spelling of your Github handle in an issue so I guess that's when Github pinged you.


citation integration via bibtex

I was wondering whether there is a way of getting references to display correctly in the generated html file. I'm not sure whether sublime-markdown-preview uses pandoc to generate the html from the markdown file. If so, it would be great if it was possible to update the pandoc command so as to include a reference to a bibtex file.

Nope, doesn't use pandoc.  Not sure which Markdown parser you are using (github or markdown), but if it is GitHub, you get what GitHub returns as we use their API.   If you are using the markdown (Python Markdown) parser, it can be extended with custom extensions.  You'd have to write your own and then add it in the settings appropriately.

ok, thanks! if this feature could be implemented in a way that's easy to use, that would be great.

This seems out of scope, but possible for a 3rd party to do.  I'll go ahead and close.


make testReset() check .equals instead of ==

@BrandonArp : Github notified me that you left a comment, but I don't see it here! I'll proceed assuming that you two hashed it out behind the scenes.


Build ... The file is locked

I'm just starting with Tye
With tye run --watch (or just tye run) if I edit a file then build my Asp Net Core Web Api the output fills with errors
Error
MSB3027	Could not copy "C:\Neil\Gits\MyApp\MyAppHost\obj\Debug\net5.0\apphost.exe" to "bin\Debug\net5.0\MyAppHost.exe". Exceeded retry count of 10. Failed. The file is locked by: "MyAppHost (16556)"
If I stop Tye and build it's fine.
I'm not using containers.
What am I doing wrong?  I've obviously misunderstood something here.

ah, you code then run.


BUG: Sharing Credentials as VP does not work for certain @context's

Using:

Android 11
LCW v1.4.1

Issue:
When trying to share a credentials via the "Share" page that contains one of those context uris ("http://home.in.tum.de/~sehlke/elmoLearner.json", "https://w3id.org/vc-revocation-list-2020/v1") the app simple does nothing.
Expectation:
When pressing the "Send" button in the "Share Preview" Page the app should create a presentation with the selected credentials and open Android's share menu as it does for other credentials (that do not contain any of the listed context uris).
Currently only very specific credentials can be shared and be presented to a verifying party and for all others it simple does not work (yet).
Steps to reproduce:

load the credential into the wallet via a QR-Code (dccrequest://request?&auth_type=bearer&issuer=example.org&vc_request_url=http://localhost:3000/credential&challenge=123)
open the "Share" page in the app
select the just added credential
press "Share Selected Credential"
press "Send"

For following credential
{
    "@context": [
        "https://www.w3.org/2018/credentials/v1",
        "https://w3id.org/security/suites/ed25519-2020/v1"
    ],
    "id": "http://localhost:8082/credentials/29",
    "type": ["VerifiableCredential"],
    "issuer": "did:key:z6MkqVmUBC49F98kvo5bC2Me6PpT3C1YjMGNRXi1Ci312zms",
    "issuanceDate": "2022-06-15T15:05:01Z",
    "credentialSubject": {
        "id": "did:ethr:0x1844d35477a3eea17dece6d1ac6a9f91d20a5140"
    }
}

Android's share menu appears with a presentation containing the selected credential ✔

And for the following credential
{
    "@context": [
        "https://www.w3.org/2018/credentials/v1",
        "https://w3id.org/vc-revocation-list-2020/v1",
        "https://w3id.org/security/suites/ed25519-2020/v1"
    ],
    "id": "http://localhost:8082/credentials/29",
    "type": ["VerifiableCredential"],
    "issuer": "did:key:z6MkqVmUBC49F98kvo5bC2Me6PpT3C1YjMGNRXi1Ci312zms",
    "issuanceDate": "2022-06-15T15:05:01Z",
    "credentialSubject": {
        "id": "did:ethr:0x1844d35477a3eea17dece6d1ac6a9f91d20a5140"
    }
}

simply nothing happens ❌

@dmitrizagidulin - is this issue because the LCW is only working with open badges 3.0 currently?

Assigning for testing by our team.

Tested and no issues found.

Thanks @IsaacAirmet1