[BUG] rapids_export Does Not Work if the Variable RAPIDS_VERSION Exists

Describe the bug
If you have the cache variable RAPIDS_VERSION set before calling rapids_export(), the version it chooses can be incorrect if you omit the VERSION argument or set VERSION with no value. In these situations, the documentation states it will default to use PROJECT_VERSION. Instead it simply uses the value in RAPIDS_VERSION.
We ran into this in SRF and needed to explicitly set the version to get around the bug (here is the PR with the workaround: https://github.com/nv-morpheus/SRF/pull/30). In SRF, we use the cache variable RAPIDS_VERSION to indicate which version of RMM, RAPIDS CMake, etc. we are using to build with. It took a while to discover why the generated srf-config-version.cmake was using the incorrect version value.
Steps/Code to reproduce bug
The following pseudocode should reproduce the bug:
project(my_project
  VERSION 22.06.00
  LANGUAGES C CXX
)

# Need to set the RAPIDS_VERSION cache variable
set(RAPIDS_VERSION "21.10" CACHE STRING "RAPIDS Libraries Version")

# This will create a version file with 21.10 as the version, not 22.06
rapids_export(INSTALL ${PROJECT_NAME}
  EXPORT_SET ${PROJECT_NAME}-core-exports
  GLOBAL_TARGETS libmy_project
  VERSION
  NAMESPACE my_project::
)

Also ommitting the VERSION argument will hit the bug as well.
Expected behavior
As indicated by the documentation, when VERSION has no value or is ommitted as an argument, rapids_export should default to using PROJECT_VERSION.
Environment details (please complete the following information):

CMake version 3.22

Additional context
This issue can be quickly fixed by changing the prefix used for cmake_parse_arguments. Currently the code uses cmake_parse_arguments(RAPIDS ...) which creates too common of variable names like RAPIDS_VERSION, RAPIDS_NAMESPACE, RAPIDS_DOCUMENTATION, etc. Instead the prefix should be something like _RAPIDS to prevent collisions.

Couple of notes:

set VERSION with no value.
This is unsupported. As noted in the docs [VERSION <X.Y.Z>] if you provide the VERSION keyword a value must also be provided. It can be OFF or explicit numeric version value.

I am open to any changes to the API docs to make this more clear.

This issue can be quickly fixed by changing the prefix used for cmake_parse_arguments. Currently the code uses cmake_parse_arguments(RAPIDS ...) which creates too common of variable names like RAPIDS_VERSION, RAPIDS_NAMESPACE, RAPIDS_DOCUMENTATION, etc. Instead the prefix should be something like _RAPIDS to prevent collisions.

I think this is the correct solution, and will need to be applied project wide so we don't run into this issue with other commands.


Set the request dimension limit of get or post visualization configurable and not limited to 5 Mbytes

Is your feature request related to a problem? Please describe.
Sometimes I have some requests under 10 Mbytes and I would like to see it. Many times when I try to download the result the file is everytime empty.
Describe the solution you'd like
I would like if is possible to setup the limit of the download and show of the reponse, normally I opened with vscode file of 10 Gbytes of dimension without problem.
Describe alternatives you've considered
Fix the download of the file to prevent to have empty file
Screenshots
This is the problem

When I save the file

this is the result an empty content

Hi @FrancoTampieri
Thank you for using the Fetch Client extension. This feature has added in the latest version Fetch Client v1.5.1
Please update the Fetch Client and let me know if you have any queries/feedback.


Messages from files spool won't be sent

Hello,
I have faced with strange issue - some messages from files spool aren't sending.
Such issue occurs randomly in cases if I manually set setSenderName() or setFromEmail().
So when cron task runs it is adding .sending extension to the file but message is not sent and console log output says that 0 messages were sent.
Issue #127 seems to be related to this, but information described there didn't help me.
Does somebody know why this issue could occur?
P.S. no errors passed to logs, it worked as expected for few months and now it is broken somewhy.
P.P.S sorry, this issue is duplicate from https://github.com/symfony/swiftmailer-bundle/issues/158
Best regards, Viktor.

Close issue because lack of attention and it doesn't relevant for me now.


Add Calendar fixes for Swift 3

These fix a crashing bug with Calendar when more than four instances are created and destroyed, and adds support for ISO8601 Calendars and others.

@swift-ci please test


Automatically apply a label and a milestone to future release branches

This is a Feature Request

What would you like to be added

As SIG release docs team, a few of our responsibilities include manually applying a milestone to every PR created against the future release branch and putting hold label in all PRs until k/k PR(s) corresponding with the docs PR are merged in.
I like to automate the two processes so that every PR created against the future release branch gets milestone and label automatically applied.
Why is this needed
This will remove

Manual toil to add milestones/labels from the release team and SIG Docs team
Prevent accidental merge against the future release branch since hold must be removed intentionally after checking on the status of k/k PRs

Comments

Was discussed during the SIG Docs quarterly planning meeting
Creating an issue to capture feedback / ideas suggested in the PRs

Original PR https://github.com/kubernetes/website/pull/24784 led to separating a PR for milestone and hold.
New PR for just applying the hold label was created https://github.com/kubernetes/website/pull/24835
New suggestion on using prow led to closing out previous PR and opening a PR against k/test-infra https://github.com/kubernetes/test-infra/pull/19877 and k/sig-release https://github.com/kubernetes/sig-release/pull/1325

Topics to discuss:

Applying hold label automatically against the future release branch

https://github.com/kubernetes/website/pull/24784#issuecomment-719566601

Change to k/website label strategy (prefix with v) to match other Kubernetes repos

https://github.com/kubernetes/test-infra/pull/19877#issuecomment-723462034

/triage accepted

/sig release
/area release-team
/assign

Update:
Looks like the milestone applier that we configured for the dev-1.20 branch recently isn’t working. For example, https://github.com/kubernetes/website/pull/24990 was just opened against dev-1.20 branch but the milestone wasn’t applied automatically. I just wanted to share that to let the team know I am aware and am putting it on my todo list to take a look.

/remove-lifecycle rotten
I saw that the bot was applying milestones automatically in some PRs. Let me verify and if needed, I'll close this out.

/remove-lifecycle stale

Confirmed that bot is automatically applying the milestone dev-1.21 branch (https://github.com/kubernetes/website/pulls?q=is%3Aopen+is%3Apr+milestone%3A1.21)
/close


Active and Duplicatable in the Search field are very unintuitive

Add titles to the Active and Duplicatable dropdowns in the box?

branch changes fix issue


schema-revision: core/entityToEntity.schema.json

this should only be used between entities from different sources
I'm not sure if confidence should be a number, because this could also be only semantic

Agreed.
Not sure if numbers will be the best, but maybe we should rather ask: How should we define the confidence and what should it describe? Should this be as Ingvild is doing to describe how well areas are related to each other ("identical", "overlapping", etc.)? This would mean that entityToEntity is more of a check how well the attached annotation reflects another with the same name from a different source (e.g. Paxinos Hippocampus to Swanson Hippocampus)?

summary of what need to be done; properties:

anatomicalEntityObject (anatomicalEntity, count 1)
anatomicalEntitySubject (anatomicalEntity, count 1)
relationType (controlledTerm, count 1) ["identical", "subset", "superset] (match with Ingvild's list)
procentualOverlap (integer (0 - 100), count 0 - 1)
confidence (controlledTerm, count 1)

@UlrikeS91 based on a discussion with @olinux this schema and the anatomicalEntity.schema.json need some changes.
Here the TODOs:
entityToEntity.schema.json

rename to anatomicalEntityRelation.schema.json
delete anatomicalEntitySubject
rename anatomicalEntityObject to inRelationTo

anatomicalEntity.schema.json

add property otherAnatomicalRelations [expects: anatomicalEntityRelation.schema.json, count: 0 - N]

@UlrikeS91 could you take this over?

I can do that. This makes it far easier to understand the exact relation between object and subject (which a bunch of people had problems with :D).
I've added it to my checklist #86

Revisions finished.


how can i set proxy-property-sources: true when i custom encryptor bean

like:
jasypt:
encryptor:
password: 123
proxy-property-sources: true
algorithm: PBEWITHHMACSHA512ANDAES_256
saltGeneratorClassName: org.jasypt.salt.RandomSaltGenerator
ivGeneratorClassName: org.jasypt.iv.RandomIvGenerator
stringOutputType: base64
if i use bean to create is lack of proxy-property-sources: true, i can not find how to set it
@Bean("jasyptStringEncryptor")
public StringEncryptor stringEncryptor() {
PooledPBEStringEncryptor encryptor = new PooledPBEStringEncryptor();
SimpleStringPBEConfig config = new SimpleStringPBEConfig();
config.setPassword("123");
config.setAlgorithm("PBEWITHHMACSHA512ANDAES_256");
config.setKeyObtentionIterations("1000");
config.setPoolSize("1");
config.setProviderName("SunJCE");
config.setSaltGeneratorClassName("org.jasypt.salt.RandomSaltGenerator");
config.setIvGeneratorClassName("org.jasypt.iv.RandomIvGenerator");
config.setStringOutputType("base64");
encryptor.setConfig(config);
return encryptor;
}
i can not set proxy-property-sources: true, if haven't set this value, my framework which use j2cache is fail(why？)，i use yaml config is success but use custom StringEncryptor is fail because it can not set  proxy-property-sources: true

proxy-property-sources is not a property of the StringEncryptor because it doesn't affect how the StringEncryptor works. It affects how the StringEncryptor is applied by this starter.
You should be able to set proxy-property-sources to true via any of the other means e.g. a system property, whilst still providing the configuration for the encryptor as a custom bean.
Alternatively, you could provide all of this configuration via a property file instead of as a custom bean, given that, in your example, you aren't doing anything that couldn't be set as a property.
@ulisesbocchio you may wish to consider separating properties according to how and when they can be applied to avoid this confusion. For example, reserve jasypt.encryptor. only for those properties that are set on the encryptor directly, move the resolver properties to jasypt.resolver. and move properties that affect the starter itself up to jasypt.


Pipx Upgrade Command from 3.8.5 to 3.8.7 Fails and Displays Error

Describe the bug
When running pipx upgrade ofscraper the script errors out and fials to update.
To Reproduce
Run the upgrade command on a pipx environment
Expected behavior
Update scripts works and upgrades ofscraper to the latest release.
Screenshots/Logs
error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "C:\Users\user\.local\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\user\.local\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\user\.local\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\user\AppData\Local\Temp\pip-build-env-gw4tsykx\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\user\AppData\Local\Temp\pip-build-env-gw4tsykx\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\user\AppData\Local\Temp\pip-build-env-gw4tsykx\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 8, in <module>
      RuntimeError: uvloop does not support Windows at the moment
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
'C:\\Users\\user\\.local\\pipx\\venvs\\ofscraper\\Scripts\\python.exe -m pip install --upgrade ofscraper -q' failed

Desktop

OS: Windows
Version: 3.8.5 upgrading to latest verion (3.8.7 as of submitting)
Python - pipx

This seems to have been fixed in 3.8.7, installing with pipx gets the latest version from pypi which is 3.8.6 at this moment. You can update directly from the github release using:
pipx install git+https://github.com/datawhores/OF-Scraper.git@180f291bfda0e24583fc8d9d81cd870b67d7cd8e

pypi has been updated

pypi has been updated

That fixed it. Thanks!


[root] disable no-useless-rename

Should fix the broken build on master https://travis-ci.org/hshoff/vx/builds/591675984
:house: Internal

[eslint] disable no-useless-name

thanks for the fix 🙌


Create a mockup of bill push/approval system (requesting/getting approval)

Please do work for this task in a branch called issue-12.

Feature is no longer necessary.


updates readme on using v1.0.0

Thought it would be helpful to include information on using v1.0.0 if others are getting the same deprecation warning.

To use newest version gem is nothing special.
I think changing version on README.md seems sufficient to avoid deprecation alert.
- gem "haml-rails", "~> 0.9"
+ gem "haml-rails", "~> 1.0.0"

Sure that makes sense, but I was assuming that there was a reason for still keeping that there.


release/2.2.0

@dndx can you add the new docs version to the kong_versions.yaml? It's not displaying as the latest version right now.

@dndx can you add the new docs version to the kong_versions.yml? It's not displaying as the latest version right now.

@dndx can you add the new docs version to the kong_versions.yml? It's not displaying as the latest version right now.

@dndx, @gszr, @kikito can someone please get the version file updated for 2.2? We can't merge until that happens.

@dndx can you add the new docs version to the kong_versions.yml? It's not displaying as the latest version right now.

@dndx, @gszr, @kikito can someone please get the version file updated for 2.2? We can't merge until that happens.

The file in question that needs a new entry for 2.2: https://github.com/Kong/docs.konghq.com/blob/release/2.2/app/_data/kong_versions.yml
I'd do it, but I don't know what dependencies need to be bumped.


Add initialize.py

Adds an initialize file to tests/azure to automate the creation of the host_vars configuration files

@costrouc I'm still confused at how slurm sockets are configured. For our testing cluster, this is the first several lines of the output from lscpu:
'Architecture:': 'x86_64',
 'CPU op-mode(s):': '32-bit, 64-bit',
 'Byte Order:': 'Little Endian',
 'Address sizes:': '46 bits physical, 48 bits virtual',
 'CPU(s):': '4',
 'On-line CPU(s) list:': '0-3',
 'Thread(s) per core:': '2',
 'Core(s) per socket:': '2',
 'Socket(s):': '1',
 'NUMA node(s):': '1',
 'Vendor ID:': 'GenuineIntel',
 'CPU family:': '6',
 'Model:': '85',
 'Model name:': 'Intel(R) Xeon(R) Platinum 8168 CPU @ 2.70GHz',
 'Stepping:': '4',
 'CPU MHz:': '2693.676',
 'BogoMIPS:': '5387.35',
 'Virtualization:': 'VT-x',
 'Hypervisor vendor:': 'Microsoft',

However, this is the currently working host_vars/worker-node.yaml config for one of the workers:
slurm_cpus: 4
slurm_sockets_per_board: 2
slurm_memory: 7658
slurm_threads_per_core: 2

We can see from the output of lscpu that there is actually one socket, but the config suggests there are two sockets. According to slurm a socket is the physical interface for a chip and the motherboard (see these docs
While things are working, I don't think Slurm is getting the correct information about the server architecture.

While things are working, I don't think Slurm is getting the correct information about the server architecture.

Yeah I agree. I "think" that slurm is getting it wrong here and it wouldn't make much sense for azure to be giving you 1 core (2 threads) per socket. Here are the slurm docs https://slurm.schedmd.com/mc_support.html.
I'd say ignore the slurm recommended settings and follow what lscpu provides.

I'd say ignore the slurm recommended settings and follow what lscpu provides.
I don't think we were following the slurm recommended settings, this was how we had discussed to configure things.

It seems like I would need to add another value for the config to make sense. Based on the docs, I'd think it should be:
slurm_cpus: 4
slurm_sockets_per_board: 1
slurm_cores_per_socket: 2
slurm_memory: 7658
slurm_threads_per_core: 2

Let me know if that sounds sane

@tylerpotts yes exactly. Feel free to add that and I've approved it for when you need to merge.


ci: split PR comment into separate workflow

After testing in #394 what happens when a PR from a fork is opened, found out the bundle size PR comment job doesn't work.
Which makes sense, and is stated in the create-or-update-comment GH Action README
Reason is that by default PRs from forks come with read-only GitHub tokens set in workflows. To prevent malicious PRs attacking the repository: stealing secrets, change the repo contents without consent, ...
As stated in a post from GitHub Security Labs, solution is to use either:

pull_request_target event: targets the base branch instead of PR branch
workflow_run event: to run after an unprivileged workflow is ran

Given we need access to artifacts (markdown bundle size report), second is chosen. Example is adapted to use download-artifact GH Action's run-id instead of a GitHub script.
Let's see how it goes

#395  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite

We can't test it here, since workflow_run only runs if it's in default branch (main). So merging it and testing directly with #394

Finally it was a bit more difficult. Specifically, to get the PR number safely in the on.workflow_run workflow.
See https://github.com/orgs/community/discussions/25220
Also, seems we can't refer to a reusable workflow in on.workflow_run.workflows. Using Pull request then (using name, as file doesn't work either)


Fine-Tuning specifications for MNLI/XNLI

Hey! What batch size, learning rate, max_seq_length, # of epochs, etc. was used to achieve the reported MNLI & XNLI results?
Thank you.

@SinghJasdeep were you able to find out the hyper-params for MNLI?

I am not sure what exact hyperparameters were used to achieve the reported MNLI results, but if you want to run the classification, you want to switch the task name and the data dir so you should play around with something like this:
python run_classifier.py   --task_name=MNLI   --do_train=true   --do_eval=true   --data_dir=$GLUE_DIR/MNLI   --vocab_file=$BERT_BASE_DIR/vocab.txt   --bert_config_file=$BERT_BASE_DIR/bert_config.json   --init_checkpoint=$BERT_BASE_DIR/bert_model.ckpt   --max_seq_length=128   --train_batch_size=32   --learning_rate=2e-5   --num_train_epochs=3.0   --output_dir=/tmp/mnli_output/


Review: Browse Opportunities by Category and Volunteer Signup Page

Overview
The focus for this code review will be centered around the landing and volunteer sign up page.
Please pay attention too:

Javascript issues
React components

Review Branch
main
Files to review
LandingOpportunitiesByCategorySection.jsx
VolunteerSignup.jsx
Checklists

Architecture
Design
JS
React
UI

Due date
02/01/2022
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

LandingOpportunitiesByCategorySection.jsx
AR-03: Is this file in the right directory? Do we want to separate the
components? (e.g. imports/ui/components/landing). Then we can shorten
the name of the Component.
JS-07: L4: Don't use /** comments and the comment is wrong.
L14,15: Why are we using className? Can't we use a semantic-ui-react
component?
L16, 19: Why are we using className? Can't we use the properties of
Image?
DE-07: L14-21: This should be a component we import and instantiate.
VolunteerSignup.jsx
L14: Comment is misleading.
JS-04: L41, 48, 97, 108, 119, etc. Prefer arrow functions.
L233: Why do volunteers have an owner?
L270-721: Should we be using Uniforms and a schema?

JS-08: in browse by category, update javaDoc comment to reflect
Design-01: make catagory card component for the browse by catagory "category card" and a category collection containing name and images to populate as categories are updated or do we just have an other category for those that do not match a preset one
Design-01: do we have a make category page for the admin to add a category as new things arise
Design-01: we probably want a organization collection that can be used to store badges/images/logo/events/etc and to populate organization related components
UI-03: component needs to be a link to a page that renders events by the category that was selected

LandingOpportunitiesByCategorySection.jsx:
Design-05: Unnecessary comment on line 4
VolunteerSignup.jsx:
ESLINT-01: Typo on Line 22 setDateOfBrith should be setDateOfBirth
Typo on Line 25 setfirstName should be setFirstName
Typo on Line 26 setlastName should be setLastName

Architecture
Arch-01: both files need to follow camel case naming convention
Design
Design-03: VolunteerSignup.jsx has commented out code that isnt being used
JS
JS-07: get rid of the commented out console.logs in VolunteerSignup.jsx
UI
UI-07: some console logs in VolunteerSignup.jsx

Volunteer Sign Up:
Repetitive Code
Comment Irrelevant
Land Opportunities:
Repetitive Code
Possible to do Destructuring

VolunteerSignUp.jsx:
Design-01: Line 101, possible grammatical error. "setError('Please make sure the both passwords match');" Could use reference from webpage, it says "Your passwords do not match"

VolunteerSignUp:
line 48 isValidData, switch from string input to calender selection?

VolunteerSignUp.jsx:
UI-02: mobile screen sizes, some text goes beyond the border.


Remove mandatory email from server settings

This is similar to https://github.com/spotify/docker-maven-plugin/issues/89

We use Config File Provider Plugin and Credentials Plugin for managing the Maven settings.xml file in our build farm. Those plugins will stitch credentials into a settings.xml at the beginning of a build, but the XML stanzas they stitch into the settings.xml file look like this:

<server>
<id>server_id</id>
<username>...</username>
<password>...</password>
</server>

No <configuration><email>...</email></configuration> entries are created.
However, since the issue was resolved, docker login no longer require the email address. See
https://github.com/docker/docker/pull/16183 (merged in docker 1.11)
Could we relaxed the email restriction as we are not currently able to use Jenkins + Credentials Plugin + Spotify Maven Plugin.

If compatibility will older versions is an issue, it could perhaps be possible  to set a default email in the plugin configuration.


Build failed to complete successfully. Reason: Build container ran out of memory [vite build]

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting questions.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d5wnfx63di45l
AWS Region
us-east-1
Amplify Hosting feature
Build settings
Question
I saw that there are issues similar to mine but the solution for them:
"NODE_OPTIONS=--max-old-space-size=4096 "
doesn't work for me, the instance still runs out of memory and I can't figure out why, the only things I run is pnpm install and vite build
My amplify.yml settings:
version: 1
applications:
  - frontend:
      phases:
        preBuild:
          commands:
            - npm install -g pnpm
            - cd apps/client-app && pnpm install --no-frozen-lockfile
        build:
          commands:
            - pnpm build
      artifacts:
        baseDirectory: apps/client-app/dist
        files:
          - '**/*'
      cache:
        paths:
          - node_modules/**/*
      buildPath: /
    appRoot: apps/client-app

that solved it for me https://github.com/sveltejs/kit/issues/2991#issuecomment-988791329

Hi @parkournick00110010 👋 , thanks for raising this and for sharing the minification workaround!
We are also tracking the feature request for customizable build containers/instances here: https://github.com/aws-amplify/amplify-hosting/issues/654.


Prepare for K2

Filed this issue for the lint failure https://issuetracker.google.com/issues/323703301


Move abel.benchmark.py to the tools directory?

I there a reason that abel.benchmark.py remains in the main abeldirectory with all the transform methods? It may be more at home in the (subsequently created) tools  directory, since it is used by the unit testing functions. However, my attempt to move it caused all sorts of dependency issues, in __init__.py that someone more knowledgeable, and skilled, may be better placed to resolve. I am looking at you @DanHickstein.

I don't object to moving it, but it's going to be a bit tedious and perhaps not worth your time at this point.
You would need to remove the line from . import benchmark from __init__.py...

I'll close this for now. You can re-open if you feel that this is something that we should do.


update dep march

fix #199

Coverage remained the same at 100.0% when pulling ac31c0128c2d3e0aa8a50dcaefb06708cb7778f4 on update-dep-march into b7eb5db7f28711c385b4642af5983b2f01d068b2 on master.


vim syntax after 'startinsert' looks incorrect.

Steps to reproduce

Expected behaviour
highlight correctly.
Operating system
linux
Version of Vim
vim 8.2.3568
Logs and stack traces
No response

problem should be here:
syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=starti\%[nsert]$"	matchgroup=vimCommand end="^\.$""

// syntax/vim.vim
@cecamp

Even though :startinsert contains the keyword insert, it does not serve the same purpose as :insert.  In particular, it does not read the following text (until a dot alone on a line) as a string to insert into the buffer;  it just switches the current mode to insert mode.  I think the last rule can be dropped:
diff --git a/runtime/syntax/vim.vim b/runtime/syntax/vim.vim
index 1fd94752b..8f4df6ad4 100644
--- a/runtime/syntax/vim.vim
+++ b/runtime/syntax/vim.vim
@@ -192,7 +192,6 @@ syn keyword vimCommand  contained	in
 syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
 syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
 syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=starti\%[nsert]$"	matchgroup=vimCommand end="^\.$""

 " Behave! {{{2
 " =======

it is not a specific issue to 'starti[nsert]' only, but append/change/insert too.

it is not a specific issue to 'starti[nsert]' only, but append/change/insert too.

No, the issue is specific to :startinsert.  For :append, :change, :insert, the highlighting is correct.

There is nothing wrong in this screenshot.  echo 'bar' is highlighted as a string, because it's treated as data/text (!= code), whose purpose is to be written in the buffer.  It ends with a dot alone on a line; like this:
echo 'this is a string before :append'
append
this is a literal text
which is appended by :append
in the buffer
.
echo 'this is a string after :append'

Again, the highlighting (vimInsert) is correct.  See :help :append for more info.

yes, sort of correct..
just 'startinsert' is more clear issue, since not req had a 'dot' at end.
but incorrect if those in cmd window (e.g cmd hist).

but incorrect if those in cmd window (e.g cmd hist).

No, the highlighting after :append is still correct, even in the command-line window.
FWIW, I don't like :append, :insert, and :change, because a small typo can mess up the highlighting of all the subsequent text, but it's technically correct.
Vim9 script does not support these commands, so no issues there; one more reason to prefer Vim9 over legacy.

ok, but IMO looks append/insert/change in cmd window looks meaningless..
or anyway, i actually did not use those 3, but 'startinsert' without 'dot' was a common usage in script, wish to be correct soon.

ok, but IMO looks append/insert/change in cmd window looks meaningless..

Yes, maybe.  My commands in the command-line window are often completely wrongly highlighted because of :append, :insert, or :change; especially since they can abbreviated into :a, :i, :c which can be typed by mistake.  And then, there is no easy way to fix the issue; you can remove the offending command, but then, as soon as you quit the command-line window and re-open it, the issue appears again.  I guess you have to quit Vim and edit the .viminfo file.
As a workaround, maybe you could clear the syntax with an autocmd:
autocmd CmdwinEnter * syntax clear vimInsert

but 'startinsert' without 'dot' was a common usage in script, wish to be correct soon.

Yes, the text after :startinsert is definitely wrongly highlighted right now.

but incorrect if those in cmd window (e.g cmd hist).

ok, but IMO looks append/insert/change in cmd window looks meaningless..

Actually, you might be right.  If I execute an :insert command interactively, the string data is not logged in the history.  As a suggestion here is a new patch, which does 2 things:

remove the wrong rule about :startinsert
check we are in a regular file (and not in the command-line window) before installing the rules about :insert, :append, :change

diff --git a/runtime/syntax/vim.vim b/runtime/syntax/vim.vim
index 1fd94752b..7a94a47e6 100644
--- a/runtime/syntax/vim.vim
+++ b/runtime/syntax/vim.vim
@@ -189,10 +189,12 @@ syn keyword vimCommand  contained	in

 " Insertions And Appends: insert append {{{2
 " =======================
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=starti\%[nsert]$"	matchgroup=vimCommand end="^\.$""
+" only in regular file; not in the command-line window
+if &buftype != 'nofile'
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
+endif

 " Behave! {{{2
 " =======

Comparing 'buftype' to an empty string should be easier to understand and give the same result:
diff --git a/runtime/syntax/vim.vim b/runtime/syntax/vim.vim
index 1fd94752b..7a94a47e6 100644
--- a/runtime/syntax/vim.vim
+++ b/runtime/syntax/vim.vim
@@ -189,10 +189,12 @@ syn keyword vimCommand  contained	in

 " Insertions And Appends: insert append {{{2
 " =======================
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
-syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=starti\%[nsert]$"	matchgroup=vimCommand end="^\.$""
+" only in a regular file; not in the command-line window
+if &buftype == ''
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=a\%[ppend]$"		matchgroup=vimCommand end="^\.$""
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=c\%[hange]$"		matchgroup=vimCommand end="^\.$""
+  syn region vimInsert	matchgroup=vimCommand start="^[: \t]*\(\d\+\(,\d\+\)\=\)\=i\%[nsert]$"		matchgroup=vimCommand end="^\.$""
+endif

 " Behave! {{{2
 " =======

'startinsert' had been fixed in last patch. so closing this.
// though others 3 still there.


Send message templates to Seq

Resolves #8. Also enables the Seq writer on .NET Core (configuration extension method was excluded).

The natural name for the property on FormattedString would have been Format, but that name is already used for the method. I went with Template (Text may be another option).
A lot of the tests fail on my machine before and after the change (but not the changed code) - guessing there are a few environment-specific dependencies that aren't present for me.

Just checked out the CI failure, the test failures are like:
[xUnit.net 00:00:01.3511400]         SmokeAndMirrorsLogging.cs(12,0): at LogMagic.Test.AzureBlobWriterTest..ctor()
Failed   LogMagic.Test.AzureBlobWriterTest.Smoke_SomethingSimple_DoestCrash
Error Message:
 System.ArgumentException : The argument must not be empty string.
Parameter name: accountName
Stack Trace:
   at Microsoft.WindowsAzure.Storage.Core.Util.CommonUtility.AssertNotNullOrEmpty(String paramName, String value)
   at Microsoft.WindowsAzure.Storage.Auth.StorageCredentials..ctor(String accountName, String keyValue, String keyName)
   at Storage.Net.Microsoft.Azure.Blob.AzureBlobStorage..ctor(String accountName, String key, String containerName)
   at LogMagic.Test.SmokeAndMirrorsLogging..ctor(String receiverName) in C:\projects\logmagic\test\LogMagic.Test\SmokeAndMirrorsLogging.cs:line 77
   at LogMagic.Test.AzureBlobWriterTest..ctor() in C:\projects\logmagic\test\LogMagic.Test\SmokeAndMirrorsLogging.cs:line 12

Seems like they began with this build: https://ci.appveyor.com/project/aloneguid/logmagic/build/2.4.23
HTH!

@nblumhardt this is brilliant thanks, could do it better myself. That test failure is my fault, it's an integration with another library - storage.net failed after upgrading to the next major version, but it doesn't affect core library. I'll accept the pull request and fix this test.

Great, thanks Ivan! Nice to see how the project is coming together.
(I notice the linked issue was reopened - if you hit any issues with the PR'd changes let me know, happy to dig in. Cheers!)


Can we read a bit between rising and falling clock edges?

https://github.com/endail/hx711-pico-c/blob/05e3c7fff96031be59e61da0ccd514b6a528b34e/src/hx711_noblock.pio#L100
Also possible sidesetting opportunity on the jump.

Two benefits with this:

slight reduction in instruction count; and
autopush will occur slightly sooner.


Git extension fails with EOL because it cant access git.exe

Does this issue occur when all extensions are disabled?: Yes

Version: 1.73.1 (user setup)
Commit:<PHONE_NUMBER>f055b99068d3688932416f2346dd3b
Date: 2022-11-09T04:27:29.066Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
Steps to Reproduce:

Click on the git panel on the left

Access any file:

It doesnt matter what I put into my settings under "git.path". It will always try to find git at this place.
Which would be ok, because git is indeed at this location:

It is also accessible from any shell:

Even other extensions seem to find it:

So, anyone knows whats going on here?

@Fuzzyma, could you please share the contents of the git output channel? Thank you!

@lszomoru sure. Here you go:

Hey @lszomoru, this issue might need further attention.
@Fuzzyma, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Live Demo

Is there a live demo anywhere we can have a look at?

Right now there is no live demo available because it would be a lot of work to maintain a secure public instance. The Docker image of the new v1.0.0-beta-1 image is really easy to setup and try out though, so at this point I'd recommend checking that out.


Add OpenJ9 XL builds to 16 pipeline

For some reason, OpenJ9 XL builds are absent from the 16 pipeline. I've confirmed with the OpenJ9 folks that they aren't ready to abandon the XL variants in 16.

Odd. Will handle this.

Ok, I think this todo list will resolve this issue:
Step 1) Merge this and wait for the relevant build jobs to be automatically generated:
https://github.com/AdoptOpenJDK/openjdk-build/pull/2251
Step 2) Run this to generate test jobs for the new XL builds:
https://ci.adoptopenjdk.net/job/Test_Job_Auto_Gen
Step 3) Run this to regenerate the top-level pipeline job for jdk16:
https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/build-pipeline-generator/

You'll also need to run https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk/ to generate the new XL downstream jobs (once the top level pipeline one has completed).

@M-Davies - Does that job not run automatically once Step 1 is complete?

So does https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/build-pipeline-generator/ (at least, it should do).

Oh. What about test job auto gen? If that runs as well, it'd complete the set.

I don't think so as GitHub hook trigger for SCM polling isn't enabled. That would have to be executed manually by @smlambert or another member of the test team with access


Bump to Quarkus 3.4.0 - Replace VertxRecorder with VertxEventBusConsumerRecorder

Fixes VertxRecorder removal in 3.4
In 3.5 we will use https://github.com/quarkiverse/quarkus-vault/pull/167, benefiting from https://github.com/quarkusio/quarkus/pull/35949
cc @kdubb @gsmet @geoand
Fixes https://github.com/quarkiverse/quarkus-vault/issues/165

waiting for @vmargerin's test results
if ok, I will merge and release

Ideally, we would need a release by 1pm as the Platform is very broken.
When it is released, please ping me and I will include the update in the PR updating to 3.4.1 to only have one CI run for both.

@vsevel
Our tests works with Quarkus 3.4.0, I also tested with this issue https://github.com/quarkiverse/quarkus-vault/issues/78#issuecomment-1413928199 and it works too.


Generated stub files fails to compile

Description:
The following tests are failing in the grpc tooling tests due to compile errors.

testHelloWorldWithDependency - ERROR [helloWorldWithDependency_pb.bal:(13:36,13:48)] unknown type 'HelloRequest'
testHelloWorldWithReservedNames - ERROR [helloWorldWithReservedNames_pb.bal:(170:12,170:17)] redeclared builtin symbol 'json'
testHelloWorldChild - ERROR [parent_pb.bal:(10:46,10:68)] undefined symbol 'ROOT_DESCRIPTOR_PARENT'
testExternalImportPaths - ERROR [child_pb.bal:(126:1,148:2)] redeclared symbol 'ParentMessageStream'

Steps to reproduce:
Generate and compile the stub files related  to the above tests.
Affected Versions:
slbeta4
Related Issues (optional):
https://github.com/ballerina-platform/ballerina-standard-library/issues/2395

The failure 2 is due to https://github.com/ballerina-platform/ballerina-lang/issues/33948.
Need to evaluate on failure 1 more -> https://github.com/ballerina-platform/ballerina-standard-library/issues/2427


Update development branch to latest docs

Coverage decreased (-0.1%) to 91.378% when pulling 4e73ab0d40333f94e6ba3a9e633bc4aefc6665c6 on master into ae76ed700031c5fc6e6aba06a276603216ca9824 on development.

Coverage decreased (-0.1%) to 91.378% when pulling 4e73ab0d40333f94e6ba3a9e633bc4aefc6665c6 on master into ae76ed700031c5fc6e6aba06a276603216ca9824 on development.


Fix: Floating point imprecision could break vertical text gradient generation

Description of change
In Chrome, I'd noticed some of my text in a project didn't always have the same gradient on each line. Turns out the seams between tiled gradients could sometimes have floating point imprecision, effectively swapping the start/end gradient colours around and messing a line or two up. This PR caps the gradient to the last value (as color stops are generated in order anyway) to prevent this happening.
Playground demo (Open in chrome, change bool at start to toggle fix)
Happy to backport this for v4 as well if wanted.
Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
Demo provided.
Do we have a way of testing visual stuff?
[x] Lint process passed (npm run lint)
[ ] Tests passed (npm run test)
Can't verify, tests currently failing already.

Codecov Report

Merging #6423 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6423   +/-   ##
=======================================
  Coverage   78.33%   78.33%
=======================================
  Files          57       57
  Lines        2820     2820
=======================================
  Hits         2209     2209
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec1dfa...5d272c4. Read the comment docs.

Hello @TheWyo ! Thanks for the PR and for the playground
When I try to use your playground, in the console I see
"Uncaught TypeError: Failed to execute 'createLinearGradient' on 'CanvasRenderingContext2D': The provided double value is non-finite."
Could you fix this please? Code looks good, would just like to see for myself :)

Hello @TheWyo ! Thanks for the PR and for the playground
When I try to use your playground, in the console I see
"Uncaught TypeError: Failed to execute 'createLinearGradient' on 'CanvasRenderingContext2D': The provided double value is non-finite."
Could you fix this please? Code looks good, would just like to see for myself :)

My bad, I was curious if the same code worked in v4, didn't realise saving that setting saved it to the same url as opposed to making a copy. Should work for you now.


Custom components installation

Hello,
I would like to test this component with my HA setup. please advise how it can be installed. I attempted adding the git url via hacs custom repo option but that didnt work.

I also could not make it work. Via hacs or custom_components folder

Same here, could not get uHoo Air integration to load after dropping the files in config/custom_components/uhooair/ directory. This resulted in the following error when validating configuration: "Platform error sensor.uhooair - Integration 'uhooair' not found." Also could not see if in hacs or integrations as install option after restarting HA. Please advise.

I haven't maintained these components in a while, so unfortunately they are not working with any recent version of HA.
I am setting up a new instance of HA at the moment,  so hopefully, I can resolve that soon. I don't have access to a uhooair device any more, so anyone wants to volunteer to test, once I get time, then that would be great!

I am happy to test, I just got my uHoo device setup and am running the latest HA. I can also take a look at the code once I have some time.


Revive Deeper Network Open Grant application

Project Abstract
This application is a follow-up to the previous deeper network open grant, https://github.com/w3f/Grants-Program/pull/141
The previous application was terminated recently due to lack of update and response from the team. The reason was the Chao Ma who submitted the original application left the team in May and the application has been overlooked. And the team has been busy preparing deeper network mainnet launch and didn't respond the termination warning in time.
For which grant level are you applying?

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $50,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledged the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @fyang1024. Could you please sign the CLA, and update the costs to be denominated in USD? We can still pay out in BTC or USDT/DAI if you prefer, but the amount now needs to be in USD.

Thanks @fyang1024. Could you please sign the CLA, and update the costs to be denominated in USD? We can still pay out in BTC or USDT/DAI if you prefer, but the amount now needs to be indicated in USD.
Besides, please explicitly mention that the starting date will be that of the amendment, and as @Noc2 mentioned briefly share the reasons behind the current delay.

Hi @alxs, I have signed the CLA, updated the costs to be in USD, and also added a note about the starting date and reasons of delay. Thank you.


getEditsForFileRename: Avoid changing import specifier ending

Fixes #26028

Latest commit exposes the ending option in UserPreferences, fixing #24779 (and doing the same task as #25073). Thanks @Kingwl for getting this started.

@sheetalkamat Please re-review


Feature: Add a project launcher

This will manage the platform specific configuration/installation of dependencies. It should automatically update config.json file so that we can avoid adding a separate field for each platform and dependency that the user has to verify and maintain.
This will also introduce more flexibility in how start our applications built on top of MediaProcessor.
The launcher should not assume the current web-based application will be the only use case. In the future we might provide a desktop GUI, and potentially other standalone applications.
The goal is to achieve a cross-platform seamless user experience.

Could you please elaborate it more

Hey @nikhiljangra264, thanks for the question!
What we're aiming for here is to :

Provide a better first-time experience by finding/installing dependencies,
Transform the config.json into a dynamic config file that will be updated wrt platform,
Ensure to keep the current ease of use while being easily extensible in the future for other applications.

I was thinking of a script (or a few small scripts) that would try to locate the dependencies and install missing ones, update the config.json file accordingly and provide means to start applications built on top of MediaProcessor. Currently we only have the Web app, but it should be extensible; it could just take args, e.g. --web or --gui, for now and that would be OK.
We should of course handle C++ specific dependencies within the existing CMake files as much as we can, and we could introduce other tools where they make sense, but I hope this gives a better view of what I'm looking for here.
Does this help? Please let me know in case of any questions/feedback!

we could add two scripts like .sh for linux and mac and .bat for windows

I will do this.
Please assign me.

we could add two scripts like .sh for linux and mac and .bat for windows

Or we could go with python, it's already a project dependency. So, it's not like it'd cost us anything.

Please assign me.

All yours ! : ))


Remove commons-lang builders

This commit removes usages of commons-lang builders for equals,
hashCode and toString methods.

Codecov Report

Merging #2243 into master will decrease coverage by 1.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   69.09%   68.03%   -1.07%
==========================================
  Files         230      230
  Lines        7993     8118     +125
  Branches      999     1014      +15
==========================================
  Hits         5523     5523
- Misses       2085     2210     +125
  Partials      385      385

Impacted Files
Coverage Δ

.../netflix/eureka/server/EurekaServerConfigBean.java
21.07% <0%> (-8.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace95a3...faabe2a. Read the comment docs.


Update Eclipse packages to the 4.5 aka Mars release

There is no Eclipse for PHP Developers 4.5 package yet
Support for 32bit packages is dropped in Mars release

Thank you for the contribution. It needed some fixes, so they were made in dbe497bc437a29e16d476bef8cb4597d1d4f78fd. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Hi Vítor! Thanks for the merge.


Support for version older than ios 9.1?

First of all, thanks for this amazing project.
I'm trying to use SwiftSiriWaveformView on a personal project with a deployment target of 9.0 (and possibly older...not sure yet) and I'm getting an error
Module file's  minimum deployment target is ios9.1 v9.1 on the following line
import SwiftSiriWaveformView
I'm using version 0.0.3 (according to Podfile.lock)

My Bad, I just found how to do this.
I change the deployment target in the pod folder.
Sorry!

Perfect! Glad you found a fix. If you need any other help, do let me know.
Best,

On Dec 4, 2015, at 9:56 PM, Sergio Rafael Gianazza<EMAIL_ADDRESS>wrote:
My Bad, I just found how to do this.
I change the deployment target in the pod folder.
Sorry!
—
Reply to this email directly or view it on GitHub.


Add a third drag speed to KeyboardDragListener

In https://github.com/phetsims/faradays-electromagnetic-lab/issues/54#issuecomment-1911171929, there is a request to have 3 speeds for moving Nodes via the keyboard.   KeyboardDragListener currently only supports 2 speeds, via options dragVelocity and shiftDragVelocity.
AccessibleValueHandler (e.g. Slider) supports 3 drag speeds via options keyboardStep, shiftKeyboardStep, and pageKeyboardStep.   So there is prescedent for 3 speeds.
Questions:
(1) Would it be possible to add a third drag speed to KeyboardDragListener? Estimate of effort?
(2) Using the same naming schema as AccessibleValueHandler, should it be named pageDragVelocity, and by convention be faster than dragVelocity?
(3) Would "page" work for 2D dragging, which requires all 4 arrow keys, or would some other modifer be more usable?
I'll start by assigning to the authors of KeyboardDragListener.
@arouinfar @kathy-phet @ariel-phet FYI.

In https://github.com/phetsims/scenery/issues/1603, it's noted that dragVelocity and shiftDragVelocity are incorrectly named.  Velocity is a vector; speed is a scalar.  So the options for drag speed should have "dragSpeed" in their names, not "dragVelocity".

I also like renaming to "speed".
I'm very happy to talk through adding a third possible speed to keyboard drag listener. That seems like an improvement, especially if there is a sim that is desiring that design. I'm a bit confused about what the interaction would be for the third speed. Yes there is a third case in sliders where you can jump in ~1/10 the range with page keys, but as you said that doesn't map too well into 2-d dragging. We have arrow keys and shift+arrow keys, but what would the third speed be triggered by? Holding pageup/down as a modifier key to the arrow keys doesn't really make a lot of sense to me. Perhaps ctrl+arrow keys, but I have no idea about the ramifications of that. To me it is a question for the designers of FEL. I don't think it is on @jessegreenberg and I to decide on what the keys should be.
In terms of the effort of adding this feature. I don't think it a quick and dirty addition of the feature would be too hard as it would be easy enough to follow the pattern used by the shiftDragVelocity/Delta, but here are some questions that come up:

I wish that https://github.com/phetsims/scenery/issues/1570 could happen before we continue to work on and improve the current KeyboardDragListener implementation.
We have two different apis in KeyboardDragListener speed (aka velocity) and delta (per key press instead of time-based). We would likely want to support this third speed for both cases as well.

Adding a third speed for KeyboardDragListener seems reasonable. As described above we should identify which modifier key we should use. "Page" isn't a modifier key it is a specific key press often assigned to arrow keys when the function key is pressed. @pixelzoom will follow up with the design team.

I asked about accessibility guidelines/conventions for use of modifier keys at dev meeting today, and no one was aware of general guideline.  Shift was apparently used in AccessibleSlider for "smaller increment" because that the HTML convention for something with role "slider".
Microsoft's Guidelines for Keyboard User Interface Design says this about modifier keys:

...

Use a shortcut with the CTRL key for actions that represent a large-scale effect, such as CTRL+S for save current document.
Use the SHIFT+ key combination for actions that extend or complement the actions of the standard shortcut key. For example, the ALT+TAB shortcut key displays the primary window of a running application. Alternatively, the SHIFT+ALT+TAB key combination allows you to navigate backward through currently running applications that have been previously accessed.
...

Apple's macOS HIG has this to say about design for Keyboards

...
Let people use modifier and other keys to adjust the behavior of some interactions. For example, pressing Command while dragging moves items as a group, and pressing Shift while drag-resizing constrains resizing to the item’s aspect ratio. In addition, holding an arrow key moves the selected item by the smallest app-defined unit of distance until people release the key.
...
Prefer the Command key as the main modifier key in a custom keyboard shortcut. Most standard keyboard shortcuts use the Command key, so people are familiar with it.
Prefer the Shift key as a secondary modifier when the shortcut complements another shortcut. For example, Command-P displays the Print dialog in most apps. The standard shortcut for the Page Setup dialog, which complements printing, is typically Shift-Command-P.
Use the Option modifier sparingly. For example, you might use Option in the shortcut for a less-common command or a convenience or power feature. For example, the Finder uses Option-Command-W for Close All Windows and Option-Command-M for Minimize All Windows.
As much as possible, avoid using the Control key as a modifier. The system uses Control in many systemwide features, like moving focus or capturing screenshots.
...

That last point for macOS is worth noting -- Apple recommends avoiding the Control modifier.

ARIA's Best Practices for Developing a Keyboard Interface has no relevant recommendations for the use of modifier keys.  It only describes the focus behavior of Shift+Tab, and includes a table of key assignments for common function.

Next step is to identify the desired modifier key, to be used with the arrow keys for "drag faster".   I did some research (see the previous comment) and came to no conclusion.  @zepumph and @jessegreenberg felt that the choice of key should be a designer's call.  Since we'd like this feature in FEL, assigning to @arouinfar.

Is it possible to use ctrl for Windows and cmd on Mac? These are keys that are frequently used in shortcuts, so users likely have some muscle memory when it comes to using them, even if they don't map perfectly to the Windows/Apple guidelines.
I would like to avoid multi-key modifiers as much as possible, so something like page up/down won't work because keys are accessed with fn+left/right on most laptops. Maybe fn by itself would work? It's a standard key on Macbooks, but not sure about how that would work in a Windows environment.

I don't have any info on what has been done in other sims (or common code) so I can't recommend a modifier key for this.  @jessegreenberg or @zepumph are probably more familiar with prior work.  What do you suggest for the "move faster" modifier key?

I do not know if we have any precedent in the project for using "ctrl" on windows and "cmd" on mac, even though that is clearly a reasonable path. In fact, in studio we awkwardly are using just the ctrl, which I believe is awkward on a mac since it isn't the cmd key:
https://github.com/phetsims/studio/blob/ea0c18b2a74ae86335388ae3d3a24ef022a099ed/js/Select.ts#L99-L115
I'll let @jessegreenberg weigh in a bit more.

using "ctrl" on windows and "cmd" on mac,

We do that for zoom commands to mimic default browser behavior. But "cmd + arrow keys" is the native Mac command to go forward/backward a page. If we use that here we would have to prevent that default behavior.
Do we need shift to always make dragging slower? We could open it up to any speed if some sims just need a faster modifier.
I think alt on windows/option for mac could also work well.
@terracoda do you have any opinions about this issue?

I have posted in more than one issue a resource about deciding on appropriate modifier and shortcut keys. I think it might be time to develop a more general understanding of what keys we already use and how and why they came about.
I am sorry I wasn't at dev meeting. I do have some understanding of modifier keys.
One of the main challenges the Inclusive Design team was up against in the beginning was avoiding conflicts with screen reader software - software that uses a huge number of modifier keys.
In addition, browsers have their own modifier and shortcuts, operating systems have their own modifiers and shortcuts. Almost every piece of software has modifiers and shortcuts. In fact, we found an odd conflict for the Result All shortcut in a web-based software that the QA team uses.
This article on Medium, J, K, or How to choose keyboard shortcuts for web applications is the article that helped me decide on the shortcuts we designed to jump the balloons to different locations in Balloons and Static Electricity.
I think all the devs should read this article.
Jesse and I recently agreed that we need a resource - in PhET Docs - that lists out all the shortcuts we have already designed. There are patterns already established that can help us maintain a systematic approach to designing and re-using shortcuts for an intuitive and efficient keyboard experience across sims.
Can we connect PhET Docs issue to this issue?

Found it - https://github.com/phetsims/phet-info/issues/211
We need to create a list of our current hot keys.

As Sasha Maximova points out in the article, using letter keys can be a good way to reduce conflicts with other systems. And it's also important to create consistency across your application, or applications in our case.

Honestly, I do not fully understand the request or need for a third drag speed for the KeyboardDragListener.
I don't think the shortcut keys for AccessibleValueHandler set a precedent for 3 step sizes (or speeds), that's just the way sliders work in the world.
Is KeyboardDragListener what you use for custom objects like the Bar Magnet in FL and the Balloons in BASE?
How are the needs for KeyboardDragListener the same or different than that of AccessibleValueHandler?
One of the issues around using lots of modifier keys is that they have no meaning and can be difficult to learn.
1-2-3 for slow, medium and fast is pretty straight forward.
If we currently have [shift] for "faster", what about  [f] for "fastest"?
What is the implementation of the Bar Magnet in FL?

Found it - https://github.com/phetsims/phet-info/issues/211
We need to create a list of our current hot keys.

I very much agree! This has been a problem every time I've need to add hotkeys to a sim. And we've been kicking that can down the road for almost 2 years. https://github.com/phetsims/phet-info/issues/211 was broken out of https://github.com/phetsims/scenery/issues/1445, which was broken out of https://github.com/phetsims/phet-info/issues/188 where I said:

There's currently no "global shortcuts" list, and it's impractical to expect code reviewers (or even the sim developer) to search the code. So a list would be useful during development, to prevent collisions in the first place.

To answer a couple of @terracoda's questions:

Is KeyboardDragListener what you use for custom objects like the Bar Magnet in FL and the Balloons in BASE?

Yes.

How are the needs for KeyboardDragListener the same or different than that of AccessibleValueHandler?

KeyboardDragListener changes a position, which is a vector.  It's also responsible for constraining that position to optional drag bounds, and transforming the position between model and view coordinate frames.
AccessibleValueHandler changes a number (scalar).

To answer a couple of @terracoda's questions:

Is KeyboardDragListener what you use for custom objects like the Bar Magnet in FL and the Balloons in BASE?

Yes.

How are the needs for KeyboardDragListener the same or different than that of AccessibleValueHandler?

KeyboardDragListener changes a position, which is a vector.  It's also responsible for constraining that position to optional drag bounds, and transforming the position between model and view coordinate frames.  It is implemented as a class.
AccessibleValueHandler changes a number (scalar).  It is implemented as a trait (not a class).

@terracoda asked:

What is the implementation of the Bar Magnet in FL?

I'm not sure if I understand the question, so ask again if I'm not answering it.  If you're asking what the FEL bar magnet is using for alt input... All draggable objects (including the bar magnet) are using KeyboardDragListener, with values for dragSpeed and shiftDragSpeed still to be fine-tuned in https://github.com/phetsims/faradays-electromagnetic-lab/issues/54#issuecomment-1911171929.

Ok, I need to retract a couple of things I said.

It seems using the Shift key for a slower speed or smaller steps is a  PhET thing - something we decided we wanted for BASE's balloons. It's not something that we got from how sliders work by default.

The Shift key is always for slower, i.e. for smaller steps.

Given that, I feel the f-key is a good modifier for a "faster" quasimode, i.e. bigger steps. The f-key is a marked home key on QWERTY keyboards, and is a good mnemonic, at least in the English language, for "faster" speed or faster/bigger steps.
It might be nice to have a bit of design meeting time to openly discuss this idea.
Implementing the f-key would not exclude using keys like 1-2-3 for interactions where experimenting with controlled velocities is important.

Thanks @pixelzoom, for your explanation in https://github.com/phetsims/scenery/issues/1601#issuecomment-1919438795
It is good to know that all draggable things use KeyboardDragListener.

a faster speed or bigger step size with [F] + Arrow key

I'm familiar with using letters as shortcuts -- the Sasha Maximova's article: that you referred to recommends this.  But I'm not familiar with using letters as modifier keys.  Is there precedence for that?

I am fine with @terracoda's proposal to use the F-key as a modifier for fast speed.
That said, this feature is not required for FEL. The design team thought it could be a useful feature, broadly speaking, so we asked @pixelzoom to create this issue. However, the learning goals for FEL are satisfied with the 2 existing drag speeds in KeyboardDragListener.

@pixelzoom, using letter keys as modifiers is not new. I did it my first sim Balloons and Static Electricity to avoid conflicts with screen reader software shortcuts.
Also Sasha Maximova suggests pairing letter keys as well.
For us we’ll be pairing f with arrow keys and f with WASD keys.

@terracoda said:

Also Sasha Maximova suggests pairing letter keys as well.
For us we’ll be pairing f with arrow keys and f with WASD keys.

Can you elaborate on what you mean by "pairing"?  Will 'f' be held down, while arrow keys of WASD keys are pressed.  If not, that will be different that Shift.  If so, it does not seem to match Sasha's description of how to use letter keys.
I've read J, K, or How to choose keyboard shortcuts for web applications as you recommended.  Can you point me to where Sasha suggests using a letter as modifier, to be held down while a second key is pressed?
Sasha suggests quite the opposite -- that letter keys should NOT be held down, but should be pressed/released in a sequence, with a delay between them.  And the first letter should access the feature, while the second letter should be the restriction of that feature.

Combining one and two letter shortcuts
It’s better not to use both one and two letter shortcuts if they start with the same letter. For instance, you want to use c for comments, and cr for comment restrictions. The first keystroke will bring up the first action. Technically, you can add a delay after the first letter, to wait for a (probable) second key press.

How does our proposed use of f-arrow and f-WASD match Sasha's recommendation?

Thanks @pixelzoom, good point, but the examples in the articles for 2 consecutive key presses are for a completely different category of interaction. Pressing a letter to bring up a comment box or menu, then doing something else.
We need an intuitive way to move an object at a different speed or step size in any direction.
I am building off my research and design experience with BASE, and with what we already have for the slower speed.
I actually tried a modal approach with consecutive key presses in interviews with blind learners. JAWS has a by-pass key, so we explored using the by-pass key then the jump location key in BASE and it was NOT AT ALL intuitive.
I think I even tried j-key, then location key, but I do not remember at this point.
For BASE, the j-key as a modifier key to enter a quasimode for jumping and adding a second key for the location of the jump was VERY intuitive and memorable for learners using BASE.
Example from BASE for reference:

Now for custom dragging...
Since we already have a quasimode for slow, Shift + Arrow key, I was suggesting we also have a quasimode for fast, and use the f-key as a modifier key to enter that quasimode.
A quasimode is harder for people with limited dexterity, that's why the 1-2-3 shortcuts are really handy for certain interaction scenarios, like the Bar Magnet in FL.
Using the f-key as modifier rather than a single shortcut to make a bigger step should avoid conflicts with other software that might use the f-key as some other shortcut.
Quoting from the article:

There are hardly any standards in this field, but if we wish to flatten the learning curve for our customers, we must consider current conventions.

I feel, the j-key in BASE started a PhET convention.
The article also says a lot of other things like documentation is important. That is currently lacking and part of another open issue.
If we need to discuss this more, we should do it in design meeting tomorrow.

Thanks for the clarification @terracoda.
In https://github.com/phetsims/scenery/issues/1601#issuecomment-1922512307, @arouinfar said:

That said, this feature is not required for FEL. The design team thought it could be a useful feature, broadly speaking, so we asked @pixelzoom to create this issue. However, the learning goals for FEL are satisfied with the 2 existing drag speeds in KeyboardDragListener.

@arouinfar and I discussed this issue in our standup meeting this morning.  Since this feature is not needed for FEL, or any other sim in development, we're going to label this issue as deferred.  If another team needs this feature, they can resume the discussion and decide how/whether to implement.

Given how this issue had great discussion, and a reasonable potential path forward, but wasn't adopted, I think the best path forward is to close this issue. When there is a need for a third speed. We will still be able to find this issue and recall this discussion. To me it comes down to the value added vs the challenge to learn a new input combo. I think it is unlikely that a third drag speed will be that valuable in the near future.


Integrate with zkitter-js

this should refactor away:

gun service
arbitrum service

Target:

deploy to a testnet
social posting should work
test on auti.sm


Add & fix phone number validation to VolunteerForm

Currently only the BaseHelpForm has phone number validation.
This validation should occur in VolunteerForm as well.
Also, this sort of validation does not seem like it would capture all phone numbers. We need to rethink this - maybe it should be a freeform combination of numbers, plus and minus signs limited to a certain amount of characters (see #49)

Don't do before #45 is merged as the phone number validation should be similar to how the ID number validation was done in said issue.

Hi, I would be happy to solve this issue 😄.
Could you make me a collaborator? So I could assign myself to this issue.


Unclear URLs and no usage of Proxy App?

[Enter feedback here]
it is not clear what URLs are used.
In the EA Provisioning Page we are entering the URL of the SAC, at the same time this documentation says we have to create a proxy system in IPS.
Let's assume IPS Proxy System is created, then why aren't we using the URL of the Proxy system which starts is like this one
https://TenantID.accounts.ondemand.com/ipsproxy/service/api/v1/scim/ProxyAppID/
instead we are putting there the URL of the SAC System as follows:
https://TenantID.eu10.hcs.cloud.sap/api/v1/scim
We also get a bearer Token with Postman using the URL of the OAuth2TokenServiceURL which is again an SAC URL
Like https://TenantID.authentication.eu10.hana.ondemand.com/oauth/token?grant_type=client_credentials
As you see there are a lot of URL Tenants, it would be beneficial to specify whicht Tenant URL to use where.
Now the question is: if we are getting the Bearer Token via Postman from a SAC URLs, and are giving to the EA provisioning the URL of the SAC System with the /api/v1/scim suffix. How does EA provisioning make use of the Proxy App that we created on IPS?
The problem is if we are connecting the EA directly to the SAC URL and use OAuth Client ID and Secret from SAC, and get the bearer Token from SAC too and configure our EA it works fine. But after the token validity expires in one hour, the EA Provisioning is quarantined.
I believe the IPS Proxy system should solve the issue, but don't get the article here since it is not providing information on how to use IPS Proxy.
BR
Kairat Alaichiev

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f787b194-a8ad-2941-0744-d40342f23bd3
Version Independent ID: 9b66a6da-d0db-8cf2-ad09-1c39ebfa9843
Content: Tutorial: Configure SAP Analytics Cloud for automatic user provisioning with Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/saas-apps/sap-analytics-cloud-provisioning-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @twimmers
Microsoft Alias: thwimmer

@cavaliere312
Thanks for your feedback! We will investigate and update as appropriate.

#reassign:owinoakelo

Doc has been updated to link to SAP documentation.

#please-close


Uninstall Seti Syntax Error + No Syntax Highlighting

Hi,
I am trying to uninstall Seti syntax but I keep getting this error:

This is what Seti looks like on a python file:

Thank you.

Same error during the day, but when I restarted Atom, the package wasn't installed anymore (I needed that to reinstall).

That fixed it. Thank you.

I've been getting this error a lot lately anytime I uninstall a package. I think it's a general Atom bug (though haven't checked that it's filed).

yeah, here it is
https://github.com/atom/atom/issues/11464#issuecomment-219902806


Snapshot property warnings work incorrectly with helper functions

Using the example code from @Ogurecher I also get the warnings, despite them not being prefixed by await.
I am honestly baffled how a super hacky method like checking line numbers ever got merged. Not least because autoformatters such as Prettier will force the expect and selector to be on the same line in most cases. Adding a warning of this kind is fine but not with this implementation. I have made a hacky fix by putting my selectors on different lines for now but I hope this is changed in a future release.
Regardless, for me personally it is failing even with selector and expect on the same line and I've forked @Ogurecher 's sample repo and made a reproducable sample: https://github.com/favna/warning-example
Simply run npm run test to run testcafe here
Originally posted by @Favna in https://github.com/DevExpress/testcafe/pull/5250#issuecomment-678322252

@Favna, Thank you for the example. I've reproduced the issue on my side.

Thanks for migrating my comment to an issue and trying my sample. Looking forward to see progress here.

Can this be solved already?
Makes looking through logs a nightmare I have to scroll thousands of lines of this useless warning to find what actually failed.
At least give an option to disable the warning.

I set the critical status for this issue. We are trying to find a solution as soon as possible, stay tuned for updates.

https://github.com/DevExpress/testcafe/issues/5389#issuecomment-698184934

@xorxero: I just stumbled upon this issue. A workaround is described here

For the team:
This issue is caused by the same reason as #5389.
When the snapshot property promise is resolved, its callsite is saved to a callsite storage. We check this storage in the .expect assertion call. If the storage contains a callsite with the same filename and lineNumber as the .expect's callsite, we delete it and raise a warning.
If the property was not awaited, the .expect would execute before the property promise's .then method. Thus, some callsites would remain in the storage after they were asserted (we delete them only in .expect). It works fine if we use our assertion only once, but causes the warnings to raise if we call .expect from the same line of code again.

Hello I have a helper class with a method that asserts a few things and this helper class extends a different helper class because it uses some of its functions.
async fillField(field) {
    let fieldSelector = await this.getInputSelector(
      field.fieldType,
      field.fieldKey
    )
    await t
      .expect(fieldSelector.textContent) //this flags the warning
      .notContains(field.name, { timeout: 20000 })
     //More stuff

raises that warning above.
The structure of the logic is that (inherited).getInputSelector(value,value) uses that value to determine the function to be used then returns the Selector passed by the other function thus resulting in a chain of await's per function reference like so:
targetSelector = await getInputSelector(string data, returns the Selector returned from next function) -> await getTypeSelector(string data, returns the Selector returned from next function) -> await fieldTypeSelector(string data and returns the selector)

It is not the case that at each return the data is wrapped in Selector() as it only gets returned as a Selector from fieldTypeSelector() function propogated downward.
TestCafe version 1.16.1

@kflore16
This issue is closed. Please create a separate issue and share an example that we can run without any additional setup.


Fix the handing of SCSS by ESLint in Svelte files

I meant setting it to true unconditionally:
'svelte3/ignore-styles': true


Serverless offline not working

Hi,
When i invoke the function locally with something like this, it works.
serverless invoke local -f get --path events/get-event.json
However when i try to do serverless offline it seems to screw up on the dynamoDB part and returns back a 500, { status: false}.
Also i deployed the resources and api as the guide suggested, and when i try hit the api gateway endpoint using postman i get the same 500, { status: false}. When i look on Xray to see whats wrong it says userId expected: S actual: NULL.
My guess is when i try postman the endpoint im not passing through the correct credentials. My header has a cognito-identity-id. In my authorisation i also have my aws access and secret key in it.
Can't seem to figure out the problem.

Hmmm might be a good idea to ask the folks over on the serverless-offline repo?

@Paul4912 since it is working with serverless invoke, and since you know it is hitting a dynamo db table of some sort, my best guess is that there is an issue with how you or postman forms the request. The easiest way to check if this is the case would be to adding logging to the get function to see if your params are set properly. In the get function on line 15, try adding console.log(params) or something to that effect to see if the params are set as you would expect.


use t4_dataset for all evaluations

Currently, the data folder configuration changes depending on whether t4_dataset is used or not.
https://tier4.github.io/driving_log_replayer/overview/setup/#data-folder
All evaluations should use t4_dataset.
Make it easier to work with WebAuto Evalutor
https://docs.web.auto/en/user-manuals/evaluator/introduction

Merged into the log-evlauator branch.
The branch has also been cut out to the following repository.
https://github.com/tier4/log_evaluator


Make slider thumb label always visible

Bug, feature request, or proposal:
Feature request
What is the expected behaviour?
I would like the thumb label to remain visible, not just when the slider is being changed.
What is the current behaviour?
The slider thumb label will only show when the slider is being moved.
https://material.angular.io/components/component/slider
What is the use-case or motivation for changing an existing behaviour?
I don't think existing behaviour should be changed, but maybe an input can be given to <md-slider> which tells it whether to always display the thumb label.
From a design point of view, it is nice to be able to let the user know what the current value is for the slider.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
TypeScript 2.3.3
Angular 4.1.3
Angular Material 2.0.0-beta.5

The slider is following the MD specs https://material.io/guidelines/components/sliders.html#sliders-discrete-slider

The slider is following the MD specs https://material.io/guidelines/components/sliders.html#sliders-discrete-slider

@michaelpwilson you can override it with css for now if you wish
.mat-slider-thumb-label {
  transform: rotate(45deg) !important;
  border-radius: 50% 50% 0 !important;
}

.mat-slider-thumb {
  transform: scale(0) !important;
}

.mat-slider-thumb-label-text {
  opacity: 1 !important;
}

Not in the spec, but seems reasonable

Thanks @willshowell! This works apart from when the value is 0.

Hi @michaelpwilson , could you share your method ?
Because I've try to override the css but not work at all, thanks.

@CDMU You should try to wrap the @michaelpwilson method with : ::ng-deep { }
`::ng-deep {
.mat-slider-thumb-label {
transform: rotate(45deg) !important;
border-radius: 50% 50% 0 !important;
}
.mat-slider-thumb {
transform: scale(0) !important;
}
.mat-slider-thumb-label-text {
opacity: 1 !important;
}
}`

Is there a way to make the thumb label appear at the bottom instead?

Rather than add an option for this to the mat-slider, we will create a cdk-slider that people can use if they want to be able to customize beyond what the mat-slider supports. Follow #10774

add class 'cdk-focused'

Add cdk-focused and cdk-mouse-focused classes to the mat-slider tag:
<mat-slider class="cdk-focused cdk-mouse-focused" tickInterval="1" min="0" max="10"></mat-slider>


Add verify otp component to React package

Current dependencies on/for this PR:

main

PR #169

PR #170

PR #171

PR #172   👈

This comment was auto-generated by Graphite.


Add Portfolio/Dashboard Section

Description
When a user logins he/she redirected to the portfolio page. following things are shown in the portfolio page

Favorite stocks section

Profit/Loss/Current-Balance section (with a button to add balance)

Owned Stocks section (with the option to view and sell them)

Suggestions and Tips
First, use dummy data (lorem ipsum) and design frontend and the routes.
Additional context
You have to work on both the frontend and the backend

portfolio_dashboard.zip

tailwind css used

Issues Resolved By @fabcodingzest and @garimasingh22


[RELAY] Copy subfunction arguments to output tuple field

As discussed in https://discuss.tvm.ai/t/relay-injective-ops-do-not-work-with-tuple/1526, the tuple output of subfunction may be incorrect because currently storage allocator doesn't support inplace operations.
First, we have issue in codegen for the assert added by ArgBinder if the input and output buffer are the same (the testcase doesn't compile before this patch).
Second,  in the below example,
  %0 = fn(%p0: Tensor[(100, 5), float32],
          %p1: Tensor[(100, 7), float32])
          -> Tuple[Tensor[(100, 5), float32], Tensor[(7, 100), float32]] {
    %1 = transpose(%p1, axes=None)
    %2 = (%p0, %1)
    %2
  }
  %3 = %0(%data_0, %data_1)

The function param %p0 is returned as one of the output tuple fields. However, new storage tokens are allocated for each output field (it should have the same storage token as the first argument).
In OpFusion, we copy the function argument to the output field. Since tuple output is only used in a few cases, memory copy won't cause great performance regression.
Please review @tqchen @masahi

Thanks @vinx13 @masahi , this is now merged


Ignition plugins and modularization of doors and slotcar

This PR adds ignition support for doors and robot vehicles and splits the building_gazebo_plugins package into three separate ones:

building_sim_common: A library that contains all the functionality that is agnostic of the simulator being used.
building_sim_gazebo: The gazebo plugins, depending on the common library.
building_sim_ign: The ignition plugins, depending on the common library as well.

Since the plugins are moved from building_gazebo_plugins package to building_sim_gazebo downstream packages (and launch files) would have to change the package they are using for their plugins.

Yap! I tested as far as I could on the matching rmf_demos branch. Another pair of eyes is always appreciated

sure thing, I'll take a look at it. we can probably pull in master again and resolve any merge conflicts after #139 is merged

Feel free to merge #139 first and I'll port the changes

#139 changes ported

it looks great! thanks for modularizing the plugins, one tiny recommendation would be to parameterize the topics instead of hardcoding, eg. /door_states and /door_requests in door_common.cpp, but that is not critical and should not hinder any merging. thanks again!

Do you mean changing to a class static constexpr std::string or make them actual variables? Who is in charge of defining their values then?

Do you mean changing to a class static constexpr std::string or make them actual variables? Who is in charge of defining their values then?
Sorry I meant allowing them to be modified and defined in the the model SDF, for example.

Do you mean changing to a class static constexpr std::string or make them actual variables? Who is in charge of defining their values then?

Sorry I meant allowing them to be modified and defined in the the model SDF, for example.

Yea I guess it can be done in a second moment then (this PR doesn't really add any functionality). What would be the use case? Iirc rmf_core uses a global topic for avoid having too many topics and making discovery tricky.

Noticed (thanks @Yadunund !) that merging this PR introduces the necessity for every user to install the latest ignition from source which can be quite troublesome, especially if they only want to use gazebo classic.
Added a change in CMakeLists to avoid this and make the compilation quit early (without breaking the whole build) if the correct version of ignition is not detected.


Disable default-features of reqwest

What changes are proposed in this pull request?

Reqwest is part of default-engine, so is included by default by engines. This enables reqwest with default features, which will include a dependency on openssl. Having a dependency on openssl requires some system libraries to be present in the runtime environment, so it's better to have it be optional.

How was this change tested?

hi @jkylling thanks for opening this! I think we had a very similar issue and to resolve it I've got a PR up to remove default-features and let us pull in rustls instead of relying on openssl/system libs: #572
with that PR instead of using default-engine, you'll instead use default-engine-rustls. Let me know if that's what you're looking for!

Thank you! I'll close this one in favour of #572


[feature request] Enable/disable "Multiplane Overlay"

Is your feature request related to a problem? Please describe
Multiplane Overlay: MPO
"Multiplane Overlay" (MPO) in Windows (https://learn.microsoft.com/en-us/windows-hardware/drivers/display/multiplane-overlay-support) at first sounds like a good thing:

Multiplane overlay (MPO) support is a WDDM feature that allows the graphics hardware to compose multiple layers of content into a single image that it can then display on a screen. It's essentially a hardware-accelerated method of compositing different "planes" of content - where a plane can be a video, the desktop, an application window, etc. - without having to involve the CPU or use up other system resources to do the blending in software.
The MPO feature is available starting in Windows 8.1 (WDDM 1.3). This article describes how to implement this capability in your driver.

MPO related issues
But, the reality is that people around the internet and people I am directly in contact with are having issues with MPO. Depending on their specific setup it is either better to leave the feature enabled or turning it off via a registry key: https://www.reddit.com/r/Amd/comments/yvyqc7/disabling_multiplane_overlay_mpo_fixed_all/
WoW + RDR2 crashes, but GPU drivers are not to blame
I first hand experienced an issue with a friend's rig of the following specs:

Windows 11
Radeon RX 5700 XT
Intel i5-13600KF
Some ASUS motherboard I can't remember the name/model of

To remove any pre-existing driver issues, I did the following:

Download and extract DDU
Reboot into safe mode
Run DDU to remove everything related to AMD
Ensure that Windows Update will never install any drivers
Reboot normally
Run Windows Update
After successful Windows Update, wait 20 minutes more to ensure no AMD drivers are being installed
Reboot normally
Open AMD Adrenaline software and click "Reset shader caches"

Even after ensuring a clean GPU driver setup, the specific issue still presented itself: during gameplay of World of Warcraft Classic (and therefore other games using the same engine I presume) the GPU driver would just crash for seemingly no reason, turning off all the displays:

Sometimes the displays would light up again after a couple of seconds and WoW would just continue like nothing happened, which I found kinda fascinating to be honest. Other times the displays would stay off, leaving me to assume that Windows couldn't recover the GPU driver (state) or something like that.
We also tried Red Dead Redemption 2 to rule out any WoW engine weirdness. There, sometimes the GPU driver would crash after the game apparently successfully exited to the desktop. Sometimes not. Gameplay was fine though.
Everything hints at MPO
After doing a little bit of research, I tried disabling XMP, because that sounded reasonable. Maybe the GPU was too and the CPU/RAM/XMP combination "expected" something faster. But neither disabling or enabling XMP solved the issue. There was some post about 4G Decoding / Resizable Bar / Smart Memory Access being the issue, but 1) the GPU in question doesn't even support SMA and 2) same thing as with XMP - enabling/disabling didn't help.
After doing some more research, I found the Reddit post I linked above, added the registry key/value pair just to see what's gonna happen, and rebooted. And would you believe... no GPU crashes ever since!
Even NVidia themselves have posted the exact same fix online, albeit the issue manifested itself differently: https://nvidia.custhelp.com/app/answers/detail/a_id/5157/~/after-updating-to-nvidia-game-ready-driver-461.09-or-newer%2C-some-desktop-apps. The contents of the reg file(s) are identical to the registry key/value pair of the Reddit post.
Describe the solution you'd like
Since there is no clear way of saying that MPO is good or bad, I would love a simple checkbox in the Tweas section. Not sure where it should be located but it should say something like Disable Multipane Overlay and a tooltip describing what MPO is and stating that

The user should try this option if they experience GPU driver crashes, also noting that it might cause lower performance during gameplay (at least according to my personal understanding of Microsoft's description of the feature)
The user should reboot their system after the option is ticked
The user should revert this option (enabling MPO again) if GPU driver crashes persist

Be aware that Windows feature updates might override the specific registry setting. I couldn't check that yet because I literally tested all of this like 2 weeks ago for the first time. I'm not sure if winutil already has a way of dealing with feature updates and registry overrides etc.
Describe alternatives you've considered
N/A
Additional context
N/A
Issue validation

[x] I checked for duplicate issues.
[x] I checked for already existing discussions.
[x] I checked for an already existing pull request addressing the issue.

Ah dang, there already is issue #564. But it's closed? Why is that?

Ah dang, there already is issue #564. But it's closed? Why is that?

It was closed due to no answer via Git Actions.

Ah gotcha thanks.

This would be nice, I already have it disabled via doing a NVCleanstall installation of my Nvidia GPU Driver but having a toggle or such in WinUtil would be lovely.

@Squtzy yeah bet! A toggle would be nice. The harder part would be figuring out the group policy that corresponds to the registry key - the policy would be kept across Windows updates whereas registry keys all by themselves, Windows sometimes happily overrides them as part of a feature/cumulative update.
I tried to Google around but I have yet to find a group policy unfortunately. Maybe a custom AMX file would be required, not sure though.


[Feature]: k3s container - configurable port

Module
K3S
Problem
I want to start k3s containers in parallel so that I can run integration tests for my Quarkus-based Kubernetes operator with one k3s for each test suite.
Solution
Make the kube port configurable in the constructor of K3sContainer (with 6443 being the default of course) and set the --https-listen-port in the k3s command. Adapt all other portions of K3sContainer that use the static port number so that they use the configured one.
Benefit
Being able to run parallel k3s containers:

The k8s resources of different test suites do not interfere with each other if there is one k3s container per suite.
The test setup is horizontally scalable.

Alternatives
Keep on running sequential tests or run all tests against one k3s container in parallel and write more boilerplate code in order to keep the k8s resources clean.
Would you like to help contributing this feature?
Yes

Hi @Obirah, I think you have raised in the issue in the wrong repo. Testcontainers main feature is being able to run multiple containers in random ports and this is applied to our preconfigured modules. You can see that K3sContainer expose port 6443 from the container side but in the host a random will be provided. You need to ask about it on Quarkus, see their implementation

Hi @Obirah, I think you have raised in the issue in the wrong repo. Testcontainers main feature is being able to run multiple containers in random ports and this is applied to our preconfigured modules. You can see that K3sContainer expose port 6443 from the container side but in the host a random will be provided. You need to ask about it on Quarkus, see their implementation

Thank you for the quick response! I'm not using Quarkus devservices. I'm following the approach from this article and hence would like to create K3sContainers with differents ports in my K3sResource class.

As I mentioned, K3sContainer already works on random ports, you don't need to configure anything else. However, this could be how Quarkus managed things. You can ask in the proper channel but definitely not an issue in Testcontainers.

As I mentioned, K3sContainer already works on random ports, you don't need to configure anything else. However, this could be how Quarkus managed things. You can ask in the proper channel but definitely not an issue in Testcontainers.

Can you point me towards where the random ports are determined/set? This might help me to debug where Quarkus might interfere.


reorder_imports does not respect comments

// Comment 1
use std::mem;
use std::marker;

// Comment 2
use std::iter;

pub fn main() {}

rustfmt produces
// Comment 1

// Comment 2
use std::iter;
use std::marker;
use std::mem;

pub fn main() {}

The comment 1 lost their context. I would expect something like:
// Comment 1
use std::marker;
use std::mem;

// Comment 2
use std::iter;

pub fn main() {}

Maybe related with https://github.com/rust-lang-nursery/rustfmt/issues/1137

This needs some kind of discussion.
Currently there's a test that expects the behavior that comments moves together with the code below; this one doesn't follow the rule.
Example:
/// sticky
use b;
use a;

to:
use a;
/// sticky
use b;

@ishitatsuyuki I'm not clear - are you saying the example is expected but doesn't happen or happens but shouldn't? It looks correct to me (that is the 'sticky' comment sticks to the import of b).

@nrc this is the current behavior and it clearly conflicts with the example posted by OP.

Ah ok, so I guess the question is whether the first comment should be special-cased and kept at the top of the imports instead of sticking to the import it is 'on top of'? At the moment, it seems that the comment is left and newlines are inserted? There also seems to be some confusion about whether we maintain grouping of imports.
So, I think that

we should fix the extra newlines - that looks like just a bug
If there is a newline between comments and the first use, leave the comment where it is. If not, the comment should stick to the use
No grouping for of imports for now (at least, not by using newlines).

Triage: the first issue is fixed, closing in favor of #2185.


[AutoPR reservations/resource-manager] Updating swagger spec to fix billing plans schema in catalogs response.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7541

(message created by the CI based on PR content)