Hardcoded reference to Riot Games

https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L606
Seeing as this is a netflix product, the only hardcoding I would expect would be for Netflix.
Either way. This should probably be configurable

That should be configurable. Please feel free to submit a PR to fix it.

That should be configurable. Please feel free to submit a PR to fix it.

Can I create a PR for this? I think we can make it configurable by passing one extra argument like -o to mention the company name similarly what is being done for $website using positional parameter -w|--website . If the value is not set we can set it to some default value during the creation of ssl certification. Let me know if my understanding is correct.

@mikegrima  here is the which I am referring to https://github.com/Netflix/security_monkey/blob/4d198ad29b2f7a828ce130d222c6e76e71b9ce11/scripts/secmonkey_auto_install.sh#L167

https://github.com/Netflix/security_monkey/pull/1232  👍🏻


Add support of bin, data, and env type to trigger node

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

Trigger node lacks support of binary buffer, timestamp, and environment variable for typedInput fields.
This PR fixes this problem.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-0.05%) to 75.094% when pulling b9733e3dfa1b5b3d2d3f7a460547b0222811acfe on node-red-hitachi:add-types-to-trigger-node into 8226f1fa7529fa3e70ef4d4337344013216c1dde on node-red:master.


Scala Native

So Scala Native 0.4 has been released, allowing for openstrat to add it as a target.

I don't think a GUI target for Native is realistic in the immediate future so I'm closing this.


DiskPart/import: use correct URL

Description:
As reported in issue ticket #3844 (The link for the diskpart import command actually points to the diskshadow import command), there are 2 similar valid link addresses available in the same folder with _1 as the only difference between them. The DiskShadow import command has been linked from the DiskPart page (described as the link to the DiskPart import command) for quite some time, but the correct link has also been available in the TOC list in the sidebar on the left side.
Thanks to @darwin-msft for noticing and reporting this issue.
Proposed change:

replace the DiskShadow URL (import.md) with the DiskPart URL (import_1.md)

Ticket closure or reference:
Closes #3844

@illfated : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@illfated: I'm sorry - only the author of this article, @jasongerend, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I know, I know. I just wanted to get this out of the way so I can plan on changing more in the same page (rewrite all the URLs and page names).


Zoom map

Enable zoom in/out.
Swipe down - in.
Up - out.
Select click - zoom in till max, then out to min level (similar to built-in maps).
Different zoom levels require different tiles. While new tiles are loaded we should rescale the current render.

I'm kind of done. Just want to refactor my code a bit. Then we'll get to 2.0.


Google speech recognize unable to transcribe the audio which is in Indian English (en-IN) format from other regions like US.

Steps to reproduce
I have a audio file which is in Indian English format. When I am running the following code from from local system this code runs perfectly and transcribes successfully but if I run the same piece of code from AWS which is US region it throws the following exception.
I tried to include the language code in recognize_google() but the same issue.
I had looked the 383
speech = r.recognize_google(audio, language = 'pt') File "/Library/Python/2.5/site-packages/speech_recognition/init.py", line 858, in recognize_google if not isinstance(actual_result, dict) or len(actual_result.get("alternative", [])) == 0: raise UnknownValueError() speech_recognition.UnknownValueError
`def recording():
r = sr.Recognizer()
file = sr.AudioFile('qa_full_recording.wav')
with file as source:
r.adjust_for_ambient_noise(source, duration = 0.5)          # for removing noise
audio = r.record(source, duration = 150) #remove the 'duration' argument to transcribe complete audio file
txt = r.recognize_google(audio,language="en-IN")
text = repr(txt)
print (text)
return text`

System information
My system is  "Ubuntu 16.04 LTS x64" both local and aws
My Python version is 3.5 both on local and aws
My SpeechRecognition library version is 3.8.1

Have you verified the Language (try changing from en-IN to UK based)
, Additionally, why would you try to turn on aws specific machine(EC2) microphone for this task?


stats: 2.10.19 -> 2.11.1

Description of changes
Changelog: https://github.com/exelban/stats/releases/tag/v2.11.1
Diff: https://github.com/exelban/stats/compare/v2.10.19...v2.11.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 327148 run on aarch64-darwin 1

1 package built:

stats


Scroll issue on vue i18n service in vue ui

vue-i18n, vue-cli-plugin-i18n version
ex: 8.11.2, 0.6.0
Steps to reproduce
Run vue ui go to Localizations tab create some item until to the end of the page you can see the page doesn't scroll
For a fix, add overflow: auto to class project-localizations router-view
@kazupon

I am doing that manually in order to scroll. It would be great to solve!

Hi @kazupon
im using vue ui and inspect to class "project-localizations".
That class dont have overflow:auto like this commit  https://github.com/kazupon/vue-cli-plugin-i18n/commit/6918d76
I already use latest version "vue-cli-plugin-i18n": "^0.6.0"
Please help, how can get scroll like that?
Thanks


V9.1 XrmApp.GlobalSearch.Search not working as intended

The Search String in the above method is not entered in the search input field of the global search area which is against the intended function.
Class: Microsoft.Dynamics365.UIAutomation.Api.UCI.XrmApp
Please rectify the issue asap.

waiting for a resolution on this issue. Please let know

@tyler olson - Any updates on fixes for this issue

@dtu11 @TYLEROL  & team - Request you to Please do the needful by providing a appropriate resolution/fix

Hi @Bala-Ramadoss ,
The fix is in PR #546 . This added the following changes:

ChangeSearchType (either CategorizedSearch or RelevanceSearch)
Filter
GlobalRelevanceSearchTest
Updated the following API's
Updated GlobalSearch to handle both search types
Updated OpenRecord to handle both search types

Please see the new test sample, UCITestGlobalRelevanceSearch, made available last night via the latest changes in releases/v9.1 branch - or via the <IP_ADDRESS>29 NuGet package.
If you have any issues with these changes, please raise new issues as required.
Warm Regards,
Tyler


Wrong tsconfig passed to typescript.transpileModule

source: https://github.com/thomaschaaf/esbuild-plugin-tsc/blob/main/src/index.js#L54
In typescript compiler api d.ts, the second param of transpileModule is:
interface TranspileOptions {
        compilerOptions?: CompilerOptions;
        fileName?: string;
        reportDiagnostics?: boolean;
        moduleName?: string;
        renamedDependencies?: MapLike<string>;
        transformers?: CustomTransformers;
}

So it should not directly pass the parsedTsConfig to it or it will use default empty config for transpiling. The correct way is:
const program = typescript.transpileModule(ts, { compilerOptions: parsedTsConfig.options });

I created a PR with fix. https://github.com/thomaschaaf/esbuild-plugin-tsc/pull/8

I published my fork on npm @emarketeer/esbuild-plugin-tsc which could be used until https://github.com/thomaschaaf/esbuild-plugin-tsc/pull/8 is merged.


Get object by ID

Let's say I have ID of the object (Linode, Disk, etc) I have found no way to get object by ID
For now I am doing like this
linode_result = _linode_client.get(Linode.api_endpoint.format(id=server_id), model=Linode)
server_object = Linode(_linode_client, linode_result['id'], linode_result)

linode_result = _linode_client.get(Disk.api_endpoint.format(linode_id=server_object.id, id=disk_id), model=Disk)
disk_object Disk(_linode_client, linode_result['id'], server_object.id, linode_result)

which looks like missing API method, because init parameters vary and for me looks like managements objects are meant to be instantiated by factories, not directly.
Did I miss a way to do this or is it really missing?

You can just construct the object with client and the ID and we do here:
from linode import Linode

server_object = Linode(_linode_client, server_id) # make a Linode object
# server_object will make an API request to load the object data the first time it is accessed

# derived objects are a little harder - anything with two IDs in its URL needs both in its constructor
disk_object = Disk(_linode_client, disk_id, server_id) # use the object's ID first, then the parent object's ID

# or you can access it via the relationship on the parent object
disk_object = server_object.disks[0] # or another index

Not quite the same. Is there a good way to force load without accessing any property? I mean, I can construct Linode, Disk or any other object with (already) non-existent ID and have no good way to get "not found" exception as soon as possible. I use _api_get() for now but taking into account underscore that method is not meant to be public API.

The best way to load it up immediately is to immediately access an attribute of it.. something like
try:
   l = Linode(client, 123)
   l.label
except ApiError:
  logger.warning("Linode not found!")

Exactly, and this is very non-intuitive. I think something like
def ensure_loaded(self):

would be nice

I think I can make that happen, I'll play with it tonight

I pushed this in v4.1.4b3


Fix content in Customer Benefits Record step of tasklist

A small bit of content was missed in #796

Side by side view

@karlchillmaid  FWIW I wonder if “They [CCS] will contact you if they find any issues with the supplier” sounds potentially a little ominous, given that people will have already awarded the contract by the time they get around to talking to CCS :-)

@galund I left a reply in Slack just before it went down.
I totally agree with that possible interpretation of the line, although I did try to make it sound as friendly as possible.
In our discussion with CCS this was the (only) buyer benefit that was identified as an incentive for the CBR form.
I'm tempted to put it out there and see how it performs. FWIW no one objected to it in user testing, but the number of participants was too low to be sure either way.
:)


Feature Request: Command Line switch to force specific extractor

Please follow the guide below
Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.08.09. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.08.09

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
Sometimes, youtube-dl fails to download a video which would normally be supported because it does not recognize the URL and falls back on the generic extractor. Although youtube-dl already has a --force-generic-extractor  switch, users cannot force a specific extractor other than the generic one.
I'd appreciate a command line switch such as --force-extractor <extractor>. This would allow me to work around #13890 by adding --force-extractor cbs.com to the command line, and would allow users to work around similar problems in the future.

Forcing concrete extractors is impossible and does not make any sense since each concrete extractor is bound to concrete URL pattern.

Sometimes the domain name varies, but the URL pattern stays the same. I really hope this can be implemented after all.

I too would like this feature.  The particular example I have in mind is for the "Wistia" extractor.  Because they provide the underlying streaming technology to many different customers each using their own domain names we need some way of telling youtube-dl to use that extractor.

Please add this feature!


Unmatching dimensions are allowed in multidimensional arrays

Describe the bug
PG checks the dimensions when constructing, concatenating and aggregating multidimensional arrays, but we currently don't.
To Reproduce
# constructing
select array[array[1,2], array[3]];

# concatenating
select array[array[1,2]] || array[array[3]];

# batch aggregating
select array_agg(a) from (values (array[array[1,2]]), (array[array[3]])) t(a);

# streaming aggregating
create table t (a int[][]);
insert into t values (array[array[1,2]]), (array[array[3]]);
create materialized view mv as select array_agg(a) as agg from t;
select * from mv;

Expected behavior
These queries all fail on PG, but succeed on RW.
Additional context
https://github.com/risingwavelabs/risingwave/pull/5060#discussion_r962014998

Ah, seems to be duplicate with #3811. Close this for now.


🧑💻: Image captioning model

Image captioning model is Deep learning model based on GAN which generates captions based on image provided by user
It generates conditional and unconditional captions.
user will provide image and the model will generate captions for that.

@BhavyaFattania I am closing this issue and please use Feature Addition issue template for adding new features and for now work on 1 issue at a time

I have made a streamlit app to solve this, please guide me as I am doing this for first time @UTSAVS26

I have made a streamlit app to solve this, please guide me as I am doing this for first time @UTSAVS26

Go to the issues sections and raise a new issue then on that select Feature Addition and then fill all the details that are asking in that template.


Syntax of attribute-seq and calling conventions inconsistent. Following Summary of Declarations causes error C2165

Is the placement of the attribute-seq nonterminal incorrect or incomplete in the declaration production in the Summary of Declarations page?
declaration:
     declaration-specifiers attribute-seqopt1 init-declarator-listopt;
     static_assert-declaration
The attributes in the attribute-seq include the calling conventions, e.g. __stdcall, but MSVC compilers will not accept calling conventions in that position. Since the * punctuator is unambiguously part of the init-declarator-list per standard C/C++ grammar and the grammar on the same page (and not declaration-specifiers), the following would be valid:
void __stdcall * test(void); // fails to compile with error C2165: 'left-side modifier': cannot modify pointers to data
This is the valid syntax:
void * __stdcall test(void); // compiles/correct
which makes it seem like the calling convention should be part of the declarator or direct-declarator production:
direct-declarator:
     attribute-seqopt identifier // my interpretation based on the individual calling convention pages, e.g. __stdcall
     ( declarator )
     direct-declarator [ type-qualifier-listopt assignment-expressionopt ]
     direct-declarator [ static type-qualifier-listopt assignment-expression ]
     direct-declarator [ type-qualifier-list static assignment-expression ]
     direct-declarator [ type-qualifier-listopt * ]
     direct-declarator ( parameter-type-list )
     direct-declarator ( identifier-listopt )3

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1abaf3f7-3beb-75b0-f38d-c8755d1d22bb
Version Independent ID: 33d4338b-4627-6bf8-8d3d-52d5c6d29f9a
Content: Summary of Declarations
Content Source: docs/c-language/summary-of-declarations.md
Service: visual-cpp
Sub-service: c-language
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


Plugin instance is ignoring new path function set with InfiniteScroll.prototype.option method

What it says in the description. My case is a form where a user can enter a search term for an api request. Every new form submission I need to reset path option to generate proper URL with query param.
Made a simple live example where after infScroll.option({path() {}}) the instance is still using the path function that it was initialized with. Here's a link to CodePen.
PS: Under the hood option method is using Object.assign and it actually works fine with other options, but for some reason ignores new path function.
PSS: Perhaps I'm supposed to destroy and reinitialize a new instance on every form submission?

Thanks for reporting this issue! You are correct, the path behavior will not be changed after you re-set path. You actually need to trigger an undocumented method updateGetPath to have your change take effect. That's the technical solution
// set new path option
infScroll.option.path = 'new path';
// update behavior
infScroll.updateGetPath();

Since your demo is already using a function, another solution is to update variables used within the function, so the same function could be used. See CodePen

Thanks for reporting this issue! You are correct, the path behavior will not be changed after you re-set path. You actually need to trigger an undocumented method updateGetPath to have your change take effect. That's the technical solution
// set new path option
infScroll.option.path = 'new path';
// update behavior
infScroll.updateGetPath();

Since your demo is already using a function, another solution is to update variables used within the function, so the same function could be used. See CodePen

Since your demo is already using a function, another solution is to update variables used within the function, so the same function could be used. See CodePen

So what you are saying is I basically need a global variable, which will work in this case for sure. But what if instance initialization is done in a separate file inside a function where I have no way to access anything global. I can «hack» it with object reference and а function that accepts options object.
// this lives in some initscroll.js
export default function initiInfScroll(options) {
  return new InfiniteScroll(".js-container", {
    path() {
      return options.pathUrl;
    }
  });
}

// app.js
const infScrollOptions = {
  pathUrl: 'https://jsonplaceholder.typicode.com/todos/1'
}
const infScroll = initiInfScroll(infScrollOptions);

document.querySelector(".js-change-path-btn").addEventListener("click", () => {
  infScrollOptions.pathUrl = "https://jsonplaceholder.typicode.com/todos/2";
});

But this just feels so wrong. Mutating cross-module object reference is not exactly safe.
Actually doing some monkey patching feels better and kinda ok, given the situation.
// Adding pathUrl field to this instance, so there will be no prototype pollution
// and then using it on the instance
const instance = new InfiniteScroll(".js-container", {
    path() {
      return this.pathUrl ?? '/1'
    },
})

// And then just change it when needed
instance.pathUrl = '/2'

Are there any plans in the API to support this case (which is very common to be honest) or monkey patching is the way?

Since your demo is already using a function, another solution is to update variables used within the function, so the same function could be used. See CodePen

So what you are saying is I basically need a global variable, which will work in this case for sure. But what if instance initialization is done in a separate file inside a function where I have no way to access anything global. I can «hack» it with object reference and а function that accepts options object.
// this lives in some initscroll.js
export default function initiInfScroll(options) {
  return new InfiniteScroll(".js-container", {
    path() {
      return options.pathUrl;
    }
  });
}

// app.js
const infScrollOptions = {
  pathUrl: 'https://jsonplaceholder.typicode.com/todos/1'
}
const infScroll = initiInfScroll(infScrollOptions);

document.querySelector(".js-change-path-btn").addEventListener("click", () => {
  infScrollOptions.pathUrl = "https://jsonplaceholder.typicode.com/todos/2";
});

But this just feels so wrong. Mutating cross-module object reference is not exactly safe.
Actually doing some monkey patching feels better and kinda ok, given the situation.
// Adding pathUrl field to this instance, so there will be no prototype pollution
// and then using it on the instance
const instance = new InfiniteScroll(".js-container", {
    path() {
      return this.pathUrl ?? '/1'
    },
})

// And then just change it when needed
instance.pathUrl = '/2'

Are there any plans in the API to support this case (which is very common to be honest) or monkey patching is the way?

But what if instance initialization is done in a separate file inside a function where I have no way to access anything global.

In this case, I recommend you trigger updateGetPath after setting a new path.

But what if instance initialization is done in a separate file inside a function where I have no way to access anything global.

In this case, I recommend you trigger updateGetPath after setting a new path.

In this case, I recommend you trigger updateGetPath after setting a new path.

Will try and get back to you with results.

In this case, I recommend you trigger updateGetPath after setting a new path.

Will try and get back to you with results.

Hi. Got same issue, and add another problem about currentIndex
My index have form, loading content thrue Ajax. I update path like this :
        $(document).on('loaded.index.app', (event, body) => {
            if (body.path) {
                console.log("new path=" + body.path);
                this.infinite.options.path = body.path;
                this.infinite.updateGetPath();
            }
        })

Here the process
first load, Initialize infinite-scroll
optPath=/fr/bands/France.json?page={{#}}; nextIndex=2
core.js:207 optPath=/fr/bands/France.json?page={{#}}; nextIndex=2
core.js:153 [InfiniteScroll] initialized. on card-index bands

Add ar in query search and press button.
infinite.js:23 new path=/fr/bands/France.json?q=ar&page={{#}}

Scroll down
core.js:153 [InfiniteScroll] scrollThreshold
core.js:207 optPath=/fr/bands/France.json?page={{#}}; nextIndex=2
core.js:153 [InfiniteScroll] request. URL: /fr/bands/France.json?page=2
core.js:153 [InfiniteScroll] load. Annuaire des groupes - France. URL: /fr/bands/France.json?page=2

Scroll up, change query search to b Setting new path
infinite.js:23 new path=/fr/bands/France.json?q=b&page={{#}}
core.js:153 [InfiniteScroll] scrollThreshold
core.js:207 optPath=/fr/bands/France.json?page={{#}}; nextIndex=3
core.js:153 [InfiniteScroll] request. URL: /fr/bands/France.json?page=3
core.js:153 [InfiniteScroll] load. Annuaire des groupes - France. URL: /fr/bands/France.json?page=3

getPath and index are not reset.
Maybe a reset() method would be cool ?


Reading EDF file yields incorrect scaling

Reported on the forum:
https://mne.discourse.group/t/eeg-data-in-edf-not-converting-in-volt/
The user provided an EDF file which specifies in its header that the data is in µV. When reading this file with MNE-Python, the data is treated as V.

Opening the file linked in the discussion thread in a hex editor shows that the units are declared as .V - so this is clearly an invalid EDF file.

invalid file → wontfix?

Yes. MNE has never been super strict, but we should not try to interpret .V as µV.

Which raises the question: since we do load the file, should we perhaps be stricter and raise an error? I've always argued not to do that, because having incorrectly scaled data is better than having no data.

I agree, +1 for a warning when we can't safely interpret the units. Then the user can fix their file or adjust their processing as necessary

Which raises the question: since we do load the file, should we perhaps be stricter and raise an error? I've always argued not to do that, because having incorrectly scaled data is better than having no data.

My personal feeling is we should throw an error. I feel that incorrectly scaled data is worse than no data ;)

Ok, a warning it is!

I have tried to address the issue, showing a warning if the unit read is in Volts


How to perform Semi-supervised VOS inference on LVOS and YTVOS dataset?

Hello,
I want to perform Semi-supervised VOS inference on LVOS and YTVOS dataset. However, the provided vos_inference.py does not support the inference for videos that objects may appear only in the middle. How should I do or are there any codes I can refer?
Thanks for the help in advance!

hei, have you tried the method in vider_predictor_example.ipynb?

hey, have you read video_predictor_example.ipynb? Maybe the method there can help you.


Fixed up several param serialization issues with Spark.

This pull request fixes several issues we had with Spark serialization/deserialization:

We no longer use copy with extractParamMap to copy params from a model to the transformer, this was not working
Fixed a deserialization issue with Spark categorical split serialization
Fixed several issues with missing parameters (mostly input/output)

Going to squash and merge this, fairly simple change.


Fix issue #39 | By shibinshibu01

Solves issue #39
Describe the changes you made briefly

[x] Display “Hello World”
[x] Read two numbers, add them and display their sum
[x] Read the radius of a circle, calculate its area and display it
[x] Area of the triangle after reading its sides

Thank you for your contributions


Contract page is broken

When trying to view this page: https://explorer.stacks.co/txid/SP2C2YFP12AJZB4MABJBAJ55XECVS7E4PMMZ89YZR.arkadiko-stacker-v1-1?chain=mainnet it always renders the missing or broken page view:

I'm getting a similarly broken experience:

BTW, I see the page render correctly for a second before it's replaced by the above screen. Do we know if it's impacting just this one contract or others too? Wondering if we should revisit the P3 prioritization.
Further, when I hover on the "X" under "Add a network", I get a weird, large circular shadow (see screenshot below):

Do we know if it's impacting just this one contract or others too?

Unclear at this point. I haven't seen reports for other contracts personally.

Wondering if we should revisit the P3 prioritization.

Agreed. Upgrading to P2 since this is blocking / critical functionality for at least some users (to view their desired contracts)

This has been fixed


Torch Script mixed with source code

@ahanio is in the process of preparing his pytorch model https://github.com/Ahanio/nucleoli_segment for our zoo. He encountered the following scenario:

saving the weights as pytorch state dict does not work (probably due to inferno version clash)
saving the weights as pytorch script does avoid the first issue, however the custom numpy pre/postprocessing is incompatible with torch script.

Source with custom weights? A model (just a python class) with a method 'load_custom_weights(file_like)' to control given weights format (e.g. 'custom_weights'; could internally use torch script in this example)
explicit format 'wrapped_[torch_script/keras_hdf5...]'? A model (just a python class) with a 'model' property that is set from another weights format.

Baseline: A model with custom pre/postprocessing might rely on source code, while standard weight formats can eleviate version clashes. 'solution' 1. or 2. are certainly not the only approaches to this problem. Let's discuss!
For the time being @ahanio is looking into porting his model weights to be compatible with a newer inferno version, so that we might use the regular 'pytorch_state_dict' for his model.

@FynnBe thanks for the problem description.
Installing inferno via conda solved the issue. But I met another problem.
When I do ''' model = torch.load('/whole/model/path') ''' everything works fine.
But if I try that:
''' model = ModelDefinition()
model.load_state_dict('/weights/path') '''
The predictions gets damaged.
I tried loading the model the first way, saving just state dict and running the second method (result is the same).
Downgrading inferno and torch versions (to the once used in model training) doesn't help.
Here is the comparison of predictions

This is very hard to give a remote diagnosis on...
To debug this I'd suggest:

compare model.state_dict() and model.load_state_dict('/weights/path').state_dict().
Check that your model and it's submodules are instantiated correctly: https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module
compare subparts of the two models for differences.

Is this maybe a problem with normalization not being applied properly? The predictions look a bit like that.

Found it: there was an issue with batch_norm layer in state_dict(). Now fixed it.
Thank you for the help!


K8SPXC-1183: Use caching_sha2_password plugin by default

CHANGE DESCRIPTION
Problem:
PXC docker images include a hard coded config that sets mysql_native_password as the default authentication plugin. MySQL 8.0 is using caching_sha2_password as the default and we want to switch to this plugin. The main problem is ProxySQL doesn't work with caching_sha2_password so in case if ProxySQL is enabled we need to continue to use the old plugin.
Solution:

Controller will pass the default authentication plugin to PXC containers using the env variable: DEFAULT_AUTHENTICATION_PLUGIN.
If ProxySQL is enabled mysql_native_password will be used. Otherwise caching_sha2_password will be the default.
If CR version is <1.13 the entrypoint will set mysql_native_password to keep the old behavior.
PXC entrypoint will decide how to configure the plugin by checking MySQL version. If MySQL <8.0.27, default_authentication_plugin will be used. If MySQL >8.0.27 authentication_policy will be used.
If ProxySQL is enabled, the controller will check if cluster is already deployed with HAProxy by checking if HAProxy statefulset exists and if it's return the following error: failed to enable ProxySQL: you can't switch from HAProxy to ProxySQL on the fly
Also in this PR I removed obsolete CR version checks (<v1.11.0)

Accompanying PR: https://github.com/percona/percona-docker/pull/799
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?
[x] Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PXC version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

affinity-8-0
failure

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
failure

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
failure

limits-8-0
failure

monitoring-2-0-8-0
failure

one-pod-5-7
failure

one-pod-8-0
failure

pitr-8-0
passed

proxy-protocol-8-0
failure

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
failure

scheduled-backup-8-0
passed

security-context-8-0
failure

smart-update1-8-0
failure

smart-update2-8-0
passed

storage-8-0
failure

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
failure

upgrade-haproxy-8-0
failure

upgrade-proxysql-8-0
failure

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/658d36d9943c912bdfd0ab2c2c27d58ca2ad3d45
image: perconalab/percona-xtradb-cluster-operator:PR-1415-658d36d9

Test name
Status

affinity-8-0
failure

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
failure

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
failure

limits-8-0
failure

monitoring-2-0-8-0
failure

one-pod-5-7
failure

one-pod-8-0
failure

pitr-8-0
passed

proxy-protocol-8-0
failure

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
failure

scheduled-backup-8-0
passed

security-context-8-0
failure

smart-update1-8-0
failure

smart-update2-8-0
failure

storage-8-0
failure

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
failure

upgrade-haproxy-8-0
failure

upgrade-proxysql-8-0
failure

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/1fb8c950b3c705dba502b879c8a49e3de77b49b8
image: perconalab/percona-xtradb-cluster-operator:PR-1415-1fb8c950

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
failure

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
failure

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
failure

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
failure

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
failure

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/e4ac65fdfeeb501620a1cd76067f35c951b45471
image: perconalab/percona-xtradb-cluster-operator:PR-1415-e4ac65fd

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
failure

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
failure

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
failure

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/e4ac65fdfeeb501620a1cd76067f35c951b45471
image: perconalab/percona-xtradb-cluster-operator:PR-1415-e4ac65fd

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
passed

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
failure

one-pod-8-0
passed

pitr-8-0
failure

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
failure

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/552deca2832daf29c4140171df08a06b4dc2adf2
image: perconalab/percona-xtradb-cluster-operator:PR-1415-552deca2

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
failure

haproxy-8-0
passed

ignore-labels-annotations-8-0
failure

init-deploy-5-7
failure

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
failure

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/552deca2832daf29c4140171df08a06b4dc2adf2
image: perconalab/percona-xtradb-cluster-operator:PR-1415-552deca2

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
failure

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

ignore-labels-annotations-8-0
failure

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
failure

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
failure

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/0a4998e090492097c93dd848134f363f73633881
image: perconalab/percona-xtradb-cluster-operator:PR-1415-0a4998e0

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

ignore-labels-annotations-8-0
failure

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/31daa714d1528e2d9c6e8f287349f46ccb4ffbe7
image: perconalab/percona-xtradb-cluster-operator:PR-1415-31daa714

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

ignore-labels-annotations-8-0
failure

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 37 out of 37

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/31daa714d1528e2d9c6e8f287349f46ccb4ffbe7
image: perconalab/percona-xtradb-cluster-operator:PR-1415-31daa714

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
failure

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
failure

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/8438e47536cf8f09b248e656b9e90cc8b2d211b9
image: perconalab/percona-xtradb-cluster-operator:PR-1415-8438e475

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/8438e47536cf8f09b248e656b9e90cc8b2d211b9
image: perconalab/percona-xtradb-cluster-operator:PR-1415-8438e475

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
failure

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/033b44b31301b5fc5282b816211710b4d9347356
image: perconalab/percona-xtradb-cluster-operator:PR-1415-033b44b3

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
failure

users-8-0
failure

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/357df4d211e72d429484f41b570affe677c2b30c
image: perconalab/percona-xtradb-cluster-operator:PR-1415-357df4d2

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
failure

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/9055728bb1a98ee1523d4a8b6dbc9ee26914e9d9
image: perconalab/percona-xtradb-cluster-operator:PR-1415-9055728b

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/9055728bb1a98ee1523d4a8b6dbc9ee26914e9d9
image: perconalab/percona-xtradb-cluster-operator:PR-1415-9055728b

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1415/commits/5e4f0eebb9013f0a5e1218d49ff720d21a78afa0
image: perconalab/percona-xtradb-cluster-operator:PR-1415-5e4f0eeb


$state.go should treat toParams optional but it does not

Wiki says that toParams are optional. But they are not. I wrote a failing test proving it.
Please, review test and notify me to create a pull request.

Options is the third parameter to go(). Try go("state", undefined, options)

That works of course. Just thought that go(state, options) is an available signature.

Nope!


After https://github.com/Granulate/gprofiler/pull/772 this is done - full suite of executable tests passed on Aarch64.


Adds support for animated gif images

Fixes #76

SwiftLint found issues
Warnings

File
Line
Reason

AgrumeCell.swift
51
Delegates should be weak to avoid reference cycles.

  Generated by :no_entry_sign: Danger


Update CI-CD-Article.md

Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer

Looks Great!
Thanks @richardbluestone

@ChanochShayner I think you have to formally approve it before we can merge this.

@ChanochShayner I think you have to formally approve it before we can merge this. Although there may be another issue which is preventing it from merging.

Yes, first I will finish implementing it...

The code was merged to the sdk repo, in the next SDK release I will merge this PR.
@richardbluestone

@ChanochShayner Do you need to approve and then merge this, or can we close it?


http and grpc server have their own service handler instance

Both the http and the grpc/http2 server create their own service handler instance. This might lead to problems, as both service instances are accessing the same files. So if concurrent requests come in we don't have a chance to lock properly.
We could either get rid of the http server entirely (api gateway) or move the service handler instance to a higher level, so that both servers can reuse the same shared service handler instance.

@kulmann this is an old issue that was transferred from the archived ocis-settings repo a few weeks ago.
Please close if no longer relevant.

Will become irrelevant when we switch to an API gateway in our current proxy service.


undefined reference to MXNDArrayGetShapeEx & MXSymbolInferShapeEx when build xdl

I built the xdl from source in a nvidia/cuda:9.0-devel docker.
First, I followed the instruction of https://github.com/alibaba/x-deeplearning/wiki/%E7%BC%96%E8%AF%91%E5%AE%89%E8%A3%85，and then built mxnet as backend.
The mxnet version is the master, and I built it successfully. And add the libmxnet.a /.so to in LD_LIBRARY_PATH and LIBRARY_PATH。The mxnet headers are also copy to mxnet python package path.
But when I built the XDL from source，it occured that
../../xdl/core/libxdl_core.a(backend_op.cc.o): In function `mxnet::cpp::NDArray::GetShape() const':
/usr/local/lib/python2.7/dist-packages/mxnet/cpp-package/include/mxnet-cpp/ndarray.hpp:415: undefined reference to `MXNDArrayGetShapeEx'
../../xdl/core/libxdl_core.a(mxnet_runner.cc.o): In function `mxnet::cpp::Symbol::InferShape(std::map<std::string, std::vector<unsigned int, std::allocator<unsigned int> >, std::less<std::string>, std::allocator<std::pair<std::string const, std::vector<unsigned int, std::allocator<unsigned int> > > > > const&, std::vector<std::vector<unsigned int, std::allocator<unsigned int> >, std::allocator<std::vector<unsigned int, std::allocator<unsigned int> > > >*, std::vector<std::vector<unsigned int, std::allocator<unsigned int> >, std::allocator<std::vector<unsigned int, std::allocator<unsigned int> > > >*, std::vector<std::vector<unsigned int, std::allocator<unsigned int> >, std::allocator<std::vector<unsigned int, std::allocator<unsigned int> > > >*) const':
/usr/local/lib/python2.7/dist-packages/mxnet/cpp-package/include/mxnet-cpp/symbol.hpp:248: undefined reference to `MXSymbolInferShapeEx'
collect2: error: ld returned 1 exit status

The symbols are checked in the libmxnet.so with nm. And the path of definition(mxnet/c_api.h) of MXSymbolInferShapeEx is also in the C_INCLUDE_PATH & CPLUS_INCLUDE_PATH.

Fine, The XDL code can only be compatible with mxnet(version=1.3.x).
If i build the mxnet=1.3 first, the above error will disappear.
It's really.....


Error in loading gist (Index.html is not parsed correctly)

There is something really strange going on and I think that it is Gist's fault. Check at this example: https://bl.ocks.org/oikonang/2ddc174270177a4111c90627277775ed

You’ll have to be more specific about what the perceived problem is. The syntax highlighting of your index.html file seems not great, but that appears to be a problem with highlight.js misidentifying your HTML as XML. But I’m probably not going to do anything to fix that, sorry.


Interpolation with perplexity optimization fails with large models

I have two 4-gram models, 191567768 and 38095008 bytes in MITLM binary format.

When I use interpolate-ngram to LI them without any perplexity
optimization, it works fine. However, when I add --optimize-perplexity
option, I get segmentation fault.

This is what happens:

$ ~/lbin/mitlm-svn/interpolate-ngram -l build/lm/tmp/model1.mitlm
model2.mitlm -o 4 --optimize-perplexity dev.txt -write-lm out.arpa.gz
Loading component LM model1.mitlm...
Loading component LM model2.mitlm...
Interpolating component LMs...
Interpolation Method = LI
Loading development set dev.txt...
Optimizing 1 parameters...
Segmentation fault (core dumped)

Backtrace from gdb:

(gdb) bt
#0  0x0000000000430c9c in InterpolatedNgramLM::_EstimateProbsMasked
(this=0x7fffa952a110, params=@0x7fffa952a210, pMask=0x5b4280) at
src/InterpolatedNgramLM.cpp:342
#1  0x00000000004316dd in InterpolatedNgramLM::Estimate
(this=0x7fffa952a110, params=@0x7fffa952a3a0, pMask=0x5b4280) at
src/InterpolatedNgramLM.cpp:214
#2  0x0000000000441f7a in PerplexityOptimizer::ComputeEntropy
(this=0x7fffa952a250, params=@0x7fffa952a3a0) at src/PerplexityOptimizer.cpp:61
#3  0x0000000000443381 in
PerplexityOptimizer::ComputeEntropyFunc::operator() (this=0x7fffa9529f90,
params=@0x7fffa952a3a0) at src/PerplexityOptimizer.h:64
#4  0x0000000000445076 in
MinimizeLBFGSB<PerplexityOptimizer::ComputeEntropyFunc>
(func=@0x7fffa9529f90, x=@0x7fffa952a3a0, numIter=@0x7fffa9529f8c,
step=1e-08, factr=10000000,
    pgtol=1.0000000000000001e-05, maxIter=15000) at src/optimize/LBFGSB.h:79
#5  0x0000000000442643 in PerplexityOptimizer::Optimize
(this=0x7fffa952a250, params=@0x7fffa952a3a0, technique=LBFGSBOptimization)
at src/PerplexityOptimizer.cpp:122
#6  0x000000000046db3e in main (argc=10, argv=0x7fffa952aab8) at
src/interpolate-ngram.cpp:277

A similar thing happens with -i CM, but it crasher earlier:

$ ~/lbin/mitlm-svn/interpolate-ngram -l build/lm/tmp/model1.mitlm
model2.mitlm -o 4 --optimize-perplexity dev.txt -write-lm out.arpa.gz -i CM
Interpolating component LMs...
Interpolation Method = CM
Loading counts for model1.mitlm from log:model1.counts...
Loading counts for model2.mitlm from log:model2.counts...
Loading development set dev.txt...
Segmentation fault (core dumped)

(gdb) bt
#0  0x0000000000429924 in Copy<unsigned char const*, unsigned char*>
(input=0xa0 <Address 0xa0 out of bounds>, begin=0x2aaad1028010 "",
end=0x2aaad15da9f0 "")
    at src/util/FastIO.h:56
#1  0x000000000042db71 in DenseVector<unsigned char>::operator=
(this=0x5b4810, v=@0x5b3ea0) at src/vector/DenseVector.tcc:146
#2  0x0000000000431974 in InterpolatedNgramLM::GetMask
(this=0x7fff0e36af40, probMaskVectors=@0x7fff0e36ad30,
bowMaskVectors=@0x7fff0e36ad10) at src/InterpolatedNgramLM.cpp:153
#3  0x0000000000442c6e in PerplexityOptimizer::LoadCorpus
(this=0x7fff0e36b080, corpusFile=@0x7fff0e36b2f0) at
src/PerplexityOptimizer.cpp:55
#4  0x000000000046db01 in main (argc=12, argv=0x7fff0e36b8e8) at
src/interpolate-ngram.cpp:274

BTW, the same thing works with small toy models.

I'm using MTLM from SVN, Linux, amd64.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Dec 2008 at 1:41

I have two 4-gram models, 191567768 and 38095008 bytes in MITLM binary format.

When I use interpolate-ngram to LI them without any perplexity
optimization, it works fine. However, when I add --optimize-perplexity
option, I get segmentation fault.

This is what happens:

$ ~/lbin/mitlm-svn/interpolate-ngram -l build/lm/tmp/model1.mitlm
model2.mitlm -o 4 --optimize-perplexity dev.txt -write-lm out.arpa.gz
Loading component LM model1.mitlm...
Loading component LM model2.mitlm...
Interpolating component LMs...
Interpolation Method = LI
Loading development set dev.txt...
Optimizing 1 parameters...
Segmentation fault (core dumped)

Backtrace from gdb:

(gdb) bt
#0  0x0000000000430c9c in InterpolatedNgramLM::_EstimateProbsMasked
(this=0x7fffa952a110, params=@0x7fffa952a210, pMask=0x5b4280) at
src/InterpolatedNgramLM.cpp:342
#1  0x00000000004316dd in InterpolatedNgramLM::Estimate
(this=0x7fffa952a110, params=@0x7fffa952a3a0, pMask=0x5b4280) at
src/InterpolatedNgramLM.cpp:214
#2  0x0000000000441f7a in PerplexityOptimizer::ComputeEntropy
(this=0x7fffa952a250, params=@0x7fffa952a3a0) at src/PerplexityOptimizer.cpp:61
#3  0x0000000000443381 in
PerplexityOptimizer::ComputeEntropyFunc::operator() (this=0x7fffa9529f90,
params=@0x7fffa952a3a0) at src/PerplexityOptimizer.h:64
#4  0x0000000000445076 in
MinimizeLBFGSB<PerplexityOptimizer::ComputeEntropyFunc>
(func=@0x7fffa9529f90, x=@0x7fffa952a3a0, numIter=@0x7fffa9529f8c,
step=1e-08, factr=10000000,
    pgtol=1.0000000000000001e-05, maxIter=15000) at src/optimize/LBFGSB.h:79
#5  0x0000000000442643 in PerplexityOptimizer::Optimize
(this=0x7fffa952a250, params=@0x7fffa952a3a0, technique=LBFGSBOptimization)
at src/PerplexityOptimizer.cpp:122
#6  0x000000000046db3e in main (argc=10, argv=0x7fffa952aab8) at
src/interpolate-ngram.cpp:277

A similar thing happens with -i CM, but it crasher earlier:

$ ~/lbin/mitlm-svn/interpolate-ngram -l build/lm/tmp/model1.mitlm
model2.mitlm -o 4 --optimize-perplexity dev.txt -write-lm out.arpa.gz -i CM
Interpolating component LMs...
Interpolation Method = CM
Loading counts for model1.mitlm from log:model1.counts...
Loading counts for model2.mitlm from log:model2.counts...
Loading development set dev.txt...
Segmentation fault (core dumped)

(gdb) bt
#0  0x0000000000429924 in Copy<unsigned char const*, unsigned char*>
(input=0xa0 <Address 0xa0 out of bounds>, begin=0x2aaad1028010 "",
end=0x2aaad15da9f0 "")
    at src/util/FastIO.h:56
#1  0x000000000042db71 in DenseVector<unsigned char>::operator=
(this=0x5b4810, v=@0x5b3ea0) at src/vector/DenseVector.tcc:146
#2  0x0000000000431974 in InterpolatedNgramLM::GetMask
(this=0x7fff0e36af40, probMaskVectors=@0x7fff0e36ad30,
bowMaskVectors=@0x7fff0e36ad10) at src/InterpolatedNgramLM.cpp:153
#3  0x0000000000442c6e in PerplexityOptimizer::LoadCorpus
(this=0x7fff0e36b080, corpusFile=@0x7fff0e36b2f0) at
src/PerplexityOptimizer.cpp:55
#4  0x000000000046db01 in main (argc=12, argv=0x7fff0e36b8e8) at
src/interpolate-ngram.cpp:274

BTW, the same thing works with small toy models.

I'm using MTLM from SVN, Linux, amd64.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Dec 2008 at 1:41

hello
I have a question about the dev.txt that you pass
does the "dev.txt" file contain the same text as on of your language models ?
because I am trying to figure out how to combine a generic and a domain specific language model and I want also to give more weight to the domain specific model.


SAK-41346: Site Info > allow maintainer to delete last roster in course site

https://jira.sakaiproject.org/browse/SAK-41346
Currently if an instructor tries to delete the only remaining roster attached to a course site (and there are no manually enrolled users with the maintain role), the instructor will receive an error message:

Alert: The site has to have at least one user with role Instructor.

This PR proposes to change this behaviour so that the user is automatically enrolled as a non-provided maintainer role in the course site so that they are able to delete the last roster attached to a site. This has been reported as a pain point for users, as they have to remember to add a roster before they can remove the last roster. It also allows them to utilize the site without having a roster attached.

I considered putting this behind a new sakai.property, but reconsidered as I think this may be desired across the board.

I'm going to put this behind a sakai.property after all, which will default to OOTB functionality.

@ern, this has been updated to be behind a new sakai.property which defaults to false to preserve OOTB functionality.
I've also provided a warning and explanation regarding any legal concerns in both the JIRA ticket, and in default.sakai.properties.


Update README with installation instructions

Update the README to include the NPM installation and how to import using ES6

Thanks.


Display Multiple Entries At The Same Time

Is your feature request related to a problem? Please describe.
I would like to display multiple entries at the same time. Lets say a subtle message as statusbar overlay that says when you're offline plus an other one that displays custom notifications / infos as popups.
What I want to avoid is that the notifications dismiss the you're offline message.

Hi @Blackjacx,
That is a good idea but a really big one in terms of architectural change.
It changes the current premise on which the project is built upon - that only a single entry can be displayed at the same time. I've actually already begun implementing parts of it a couple of weeks ago.
I really hope to be able to complete that feature in the near future.
In the meantime, if you don't want one entry to dismiss the other, you can set the display priority priority. See DisplayPriority.

Cool looking forward to this change :-) Yep I think in the mean time I'll prioritize the offline message and drop the other ones.
Nice work btw :-)

Hi @huri000 ,
we would love to have that feature aswell! :-)
In our case, it would be nice if we could show several Float Views at the same time.
Amazing framework nonetheless! 🍻

** A small update - **
One of the features I've been working on lately is an entry queue.
Instead of being totally ignored or dropped in case of a low-display priority, entries will just wait for their turn (Until the queue is empty).
You will be able to decide whether you want to drop/override (like you do today) entries or enqueue them. You will also be able to decide how to prioritize the order - using the display-priority or a simple FIFO heuristic (chronological order)
I think it is necessary and should add an additional possibility to handle multiple entries.
In the future, there will be even more approaches to dealing with multiple entries.

Wow thats awesome

@Blackjacx, @ralfboesch - Please see the new feature that suggests an alternative of entry queue, as of version 0.7.0.

Closing. As of today, there are multiple alternative solutions (mentioned above). I'm not sure this feature is needed anymore.

This is perfectly fine now, thank you :-)


Add images for RCT1 toilets

This includes a thumbnail that I created myself, which matches the original one as closely as possible. I created it so it doesn't have the built-in mask that RCT1 thumbnails have.

0.png appears to be an information kiosk.


SAK-45196 Made adjustments to Overview synoptic tools to render properly in dark mode

https://jira.sakaiproject.org/browse/SAK-45196

Well played.


Release v0.20.1

[Fix] Fix Windows support for coverage.

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   67.95%   67.95%
=======================================
  Files          36       36
  Lines         958      958
=======================================
  Hits          651      651
  Misses        307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596b5b6...65a11a0. Read the comment docs.


Set the default blob type as 'Page Blob' in Upload dialog for premium accounts

Storage Explorer Version: 1.5.0
Platform/OS Version: Windows 10/ Linux Ubuntu 16.04/ MacOS High Sierra
Architecture: ia32/x64
Build Number: 20180926.5
Commit: d6717c99
Regression From: Not a regression
Steps to Reproduce:

Drill down one premium storage account.
Open one blob container then open Upload dialog.
Check the default Blob type in Upload dialog.

Suggestion:
Set the default Blob type as Page blob. It is convenient when uploading a page blob with non .vhd/vhdx file.
Actual Experience:
The default Blob type is Block blob .

AzCopy doesn't support uploading non .vhd files as page blobs. So that's why the transfer failed. I've requested that this be supported: Azure/azure-storage-azcopy#69

Duplicate of #703


Feature/ch122 update startup process

See "digital-register-frontend" for related changes and comments on tests.

Doesn't work properly and no more time to fix it :-(


Release 1.0.2

Hi,
@camunda-community-hub/devrel:
I want to get a new release published. Upfront before the first release there were some problems, also regarding the GPG secrets (https://github.com/camunda-community-hub/community/issues/62#issuecomment-1398953610). Unfortunately, the secrets are gone! Also for the related project https://github.com/camunda-community-hub/vanillabp-camunda8-adapter.
This is the reason why the action for this release failed: https://github.com/camunda-community-hub/vanillabp-camunda7-adapter/actions/runs/4023024758
Can you please fix this (also for the second project), rerun my action and publish the release afterwards. Please keep in mind to make a permanent fix for this because we use this in customer projects and we need to create releases in a reliable way.
@NPDeehan: You helped last time. Thank you for this. Can you tell me if someone of the community-hub team is also from Europe, so I can expect responses also during European daytime or are all members of this team located in US?
Thx, Stephan

@camunda-community-hub/devrel: Beside that current problem (GPG): Why the stage is not automatically published to Maven-Central? Why always this manual step of asking for publishing the release is necessary? My current expirience is that this slows down - especially until this extension is out of the incubating phase.

Hi @stephanpelikan - I saw your escalation via Stephan. I am not sure how we generally handle the credentials but can check in with @xomiamoore later. For now I added those credentials manually to both projects.

@stephanpelikan Hang on - can it be that you did not properly onboard your repo like described here: https://github.com/camunda-community-hub/infrastructure/#use-case-onboarding-a-new-community-hub-repository - seems like your repo is not within the list of onboarded repo (which I think is used by Terraform to add credentials - which means manual changes are overwritten)

Onboarded repo properly: https://github.com/camunda-community-hub/infrastructure/pull/53

This is not something I should have done!?

That PR is actually part of the onboarding of Community Extensions - but I double checked and this is either gone from the documentation or more likely pretty hidden - @xomiamoore - could you create the appropriate issue to sort this out? I know we had this very front of docs once but have not found it linked any more.

Ok I found it in https://github.com/camunda-community-hub/community/blob/29a9a6a3ba11db474f304b2288de7b4486f3066e/RELEASE.MD - the first bullet-point. I didn't get that this is a another issue. I thought one would be good. Should I follow that right now?

I created that PR and approved it for you - so that should be good already

I created https://github.com/camunda-community-hub/community-action-maven-release/issues/48 for the auto release of artifacts pushed to Maven Central. This was discussed a couple of times in the past - but I am not sure what the latest state of discussion was. But I agree that it is pretty inconvenient for everybody involved to have a manual step forced in here.

Did you also adopt the configuration for the sister-project vanillabp-camunda8-adapter ?
The current action gives me this error:
Error:  Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy (default-deploy) on project camunda7-spring-boot-adapter: Failed to deploy artifacts: Could not transfer artifact org.camunda.community.vanillabp:camunda7-spring-boot-adapter:jar:1.0.2 from/to central (https://oss.sonatype.org//service/local/staging/deploy/maven2/): transfer failed for https://oss.sonatype.org//service/local/staging/deploy/maven2/org/camunda/community/vanillabp/camunda7-spring-boot-adapter/1.0.2/camunda7-spring-boot-adapter-1.0.2.jar, status: 504 Gateway Time-out -> [Help 1]

(see https://github.com/camunda-community-hub/vanillabp-camunda7-adapter/actions/runs/4023024758/jobs/6952230722)

I saw it - this is kind of related to what other community users saw earlier today (https://github.com/camunda-community-hub/zeebe-redis-exporter/issues/5) - I wonder if that is some network hiccup on the Sonatype site - as I have never seen this so far and also have no idea what to do about it. But I can open an issue with SOnatype

And yes, vanillabp-camunda8-adapter got also onboarded properly

I also get it on the Sonatype UI - so I think some propblem on their side - sorry

hmm. I think we need to wait?
by-the-way: thank you for supporting me 👍 and sorry, that I also missed something to configure 👎

Created https://issues.sonatype.org/browse/MVNCENTRAL-7816 - I have no other ideas than waiting at the moment :-(

seems like Sonatype has some challenges with "unexpected" workload, we're not the only ones having issues since the last weekend. See e.g. https://issues.sonatype.org/projects/OSSRH/issues/OSSRH-8825.

https://issues.sonatype.org/browse/MVNCENTRAL-7816:

Sorry for the late reply, but oss.sonatype.org was clearly not able to keep up with the extraordinary load it experienced this morning and also late last week.  We completed a maintenance window to apply configuration updates that seem to have restored performance, but we will continue to monitor activity on the host.

I restarted the release action, 🤞

Published successfully - and I also released it to Maven Central @stephanpelikan

I close this for now @stephanpelikan - let me know if you object. The auto-release will be followed up in https://github.com/camunda-community-hub/community-action-maven-release/issues/48, so there is nothing left to do here, right?

Thank you, yes everything is fine now! I hope next time it will be more smooth 😄. I'm always sorry to reach out but I try to avoid bringing internal problems to the customer. I'm also sorry, that this time it was caused by me missing to create this infrastructure issue.

No worries - every glitch is a great learning opportunity to see how we can improve onboarding experience or reduce your dependency on us. So never hesitate to reach out!
Just Sonatype was bad luck 😬

Thank you to @berndruecker for sorting this while I was out sick -- you're right, I want to take everything we've learned from this and improve the onboarding experience for everyone! So thank you for all the feedback @stephanpelikan and don't worry about reaching out too much :)


Move p-xylene

I think we had decided we wanted to have examples/binding/t4-lysozyme/ with both explicit.yaml and implicit.yaml but otherwise the same input structures/files.
Can you reorganize this @Lnaden?
Apologies for not catching this earlier!

Yeah, I'll put it in the PR im working on


Karma: configuration of the context iframe

Context iframe works very well in general. But in some types of applications tests are a bit more sensitive of the on-the-screen content and it'd be great to have an option to customize this iframe's size/position. Currently it is styled to be width:100%; height: 100%. With the Karma runner header, the bottom of the iframe is always cut off from the bottom of the screen. For some tests it'd be convenient to configure the iframe to take the whole screen, e.g. by setting its styles to position:fixed; top: 0; width: 100%; height: 100%.

You can provide you own version using customContextFile configuration option.
Not sure whether it is sustainable to start adding extra options to customise various aspects of the context file. Can you elaborate about what kind of test is affected by the current setup? Maybe we can improve the built-in one instead.

@devoto13 thanks for the suggestion! It looks like actually the customClientContextFile option is what we need. I'm closing this issue.


Add .gitignore

Add .gitignore file in root folder. Fill it up with new ignore stuff as needed.

Done.


HEC-1058 json library swap

@AndyHWChung @priyankadhiman3006 I've added tests for the readers/writes in this commit, can you review them, thanks

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Good question, I think it's better to do them all together @AndyHWChung ?

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Yeah, we should merge everything together including updates to hec-ui-journey-tests where it's calling our BE test-only endpoint. It'd be a good idea just to clear our mongo databases in the test environments as well once it's merged in

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Yeah, we should merge everything together including updates to hec-ui-journey-tests where it's calling our BE test-only endpoint. It'd be a good idea just to clear our mongo databases in the test environments as well once it's merged in

I'll keep this in Draft until we are ready to merge

Then again, other code will keep on piling  and you have to do rebase and stuff. i think we should divide and conquer :) happy to help


Problem with multitouch on big screens

Do you want to request a feature or report a bug?
Bug?
What is the current behavior?
When a user put his hand on the tablet to sign, the the canvas stops to recognize movemets and not write anything.
Only if the object that holds on screen is big the problem appears. If puts a finger and tries to write it works.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template:
With your live demo
http://szimek.github.io/signature_pad/
What is the expected behavior?
On big devices is common to hold the hand on screen while writting. I am not sure that it would be fixed but its a very common problem
Which versions of SignaturePad, and which browser / device are affected by this issue? Did this work in previous versions of SignaturePad?
With your live demo
http://szimek.github.io/signature_pad/
3.0.0-beta-3?
Related:
https://github.com/szimek/signature_pad/issues/48
Video with the problem:
https://drive.google.com/open?id=1HymdaNwNlGEyezcEmckM0nlupT29z7Ah

this seems to be working as expected it should not draw when multiple fingers are touching


Add missing support for inline images

Additional mapping in Transmission::$parameterMappings to support inline images.

Thanks for the PR @chandon - we're going to be taking a look at the incoming PRs soon.

@richleland no problem, you have till April 27 :)

Hi @chandon can you merge in the latest from master - I just merged in the attachments support.

You should merge by solving conflict, i've no write access to do that

This PR has been merged into master manually. Thanks for the contribution @chandon.


SILCombine: handle upcasts when converting from alloc_ref_dynamic to alloc_ref

@swift-ci Please smoke test and merge

(btw, the only reason I requested the changes was to stop the merge from the smoke test.)

Looks great Erik!

@swift-ci Please smoke test and merge


Debugger error upon save

OS: Ubuntu 18.04
VS-Code version: 1.37.0
Swift Version: 5.1-dev
Error upon saving:
Request textDocument/completion failed.   Message: Request textDocument/completion failed with message: Cannot call write after a stream was destroyed   Code: -32603
So I installed the SDE extension and sourcekite thanks to your documentation :smiley:
For SDE I configured swift.path.swift_driver_bin to be the absolute path of ..../usr/bin of Swift for TensorFlow.
I git cloned sourcekite and followed  instructions (including commented ones), and executed make install PREFIX=/usr/local;  and file was saved as /usr/local/bin/sourcekite . I then set the swift.path.sourcekite option to be /usr/local/bin/sourcekite in vs-code.
Is this something I can disregard, or will it affect code completion/highlighting abilities? Thank you

Hi @kennethz3 thanks for your feedback!
What happens if you try to run /usr/local/bin/sourcekite manually from the terminal?
Does restarting the vscode window solve the issue?
Essentially the error means, that you don’t have any auto completion. Code highlighting isn’t affected, as SDE does not handle it.
In most cases the error is either produced by wrong/missing configs or by dynamic libraries linking issues.

Thanks @vknabel!
Reloading/restarting vscode window (and all windows) does not help the issue unfortunately.
When I run /usr/local/bin/sourcekite it does not print out anything, as if it is listening to further commands.
Could it be there are issues upon make install or maybe a problem with vs-code extension settings?

That there is no output when executing sourcekite is correct!
What happens if you enter the following request? (you need to include the trailing newline)
$ /usr/local/bin/sourcekite
1
{
key.request: source.request.protocol_version
}

It should respond as follows
1
{
  "key.version_major" : 1,
  "key.version_minor" : 0
}

Could you dump your VS Code settings?

You're right, the output is just as you described :smiley:
$ /usr/local/bin/sourcekite
1
{
"key.request": source.request.protocol_version
}

yields:
1
{
  "key.version_major" : 1,
  "key.version_minor" : 0
}

This is everything I have in settings.json:
{
    "python.jediEnabled": false,
    "python.linting.pylintArgs": [
        "--load-plugins=pylint_django"
    ],
    "terminal.integrated.fontSize": 13,
    "swift.path.swift_driver_bin": "/home/kenneth/libraries/swift-5.0.2-RELEASE-ubuntu18.04/usr/bin/",
    "swift.path.sourcekite": "/usr/local/bin/sourcekite",
}

So sourcekite works as expected!
Regarding your settings.json your swift.path.swift_driver_bin should point to the swift-binary directly. Just to be sure, restart after changing your configs.
{
    "python.jediEnabled": false,
    "python.linting.pylintArgs": [
        "--load-plugins=pylint_django"
    ],
    "terminal.integrated.fontSize": 13,
-     "swift.path.swift_driver_bin": "/home/kenneth/libraries/swift-5.0.2-RELEASE-ubuntu18.04/usr/bin/",
+     "swift.path.swift_driver_bin": "/home/kenneth/libraries/swift-5.0.2-RELEASE-ubuntu18.04/usr/bin/swift",
    "swift.path.sourcekite": "/usr/local/bin/sourcekite",
}

If that doesn't help either, could you temporarily add the following settings, restart vscode, just hover one single variable and paste all output of Swift below?
"sde.enableTracing.LSPServer": true,
"sde.enableTracing.client": true

Thereafter remove these settings as logging is very verbose and consumes too many resources.

Thank you for your suggestion to modify the setting. Unfortunately it didn't really change the output, but I will still keep the setting pointing to the actual binary.
This is the log when setting those 2 options to true, and hovering over something in the code. The issue seems to have to do with the libsourcekitdInProc.so symlink
Debugger listening on ws://<IP_ADDRESS>:6004/f511d978-37c1-4ce1-bc2e-19a30d6de9bd
For help, see: https://nodejs.org/en/docs/inspector
[-->onInitialize ] isTracingOn=[true],
	skProtocolProcess=[/usr/local/bin/sourcekite],skProtocolProcessAsShellCmd=[false]
[-->onDidChangeConfiguration]
[-->onDidChangeConfiguration tracing:
	    swiftDiverBinPath=[/home/kenneth/libraries/swift-5.0.2-RELEASE-ubuntu18.04/usr/bin/swift],
		shellPath=[/bin/sh]]
[sourcekite] ***sourcekite initializing with skProtocolProcess at [/usr/local/bin/sourcekite]
[-->SourcekiteResponseHandler constructor done]
[---onDidChangeContent]
[ERROR][1]
[request] {
  key.request: source.request.cursorinfo,
  key.sourcefile: "/home/kenneth/Documents/swift_projects/first.swift",
  key.offset: 1625,
  key.compilerargs: ["/home/kenneth/Documents/swift_projects/first.swift","-target","x86_64-unknown-linux"],
  key.sourcetext: "class NamedShape {\n    var numberOfSides = 0\n    var name: String\n\n    init(name: String) {\n        self.name = name\n    }\n\n    func simpleDescription() -> String {\n        return \"A shape with \\(numberOfSides) sides.\"\n    }\n\n}\n\nclass Square: NamedShape {\n    var sideLength: Double\n\n    init(sideLength: Double, name: String) {\n        self.sideLength = sideLength\n        super.init(name: name)\n        numberOfSides = 4\n    }\n\n    func area() -> Double {\n        return sideLength * sideLength\n    }\n\n    override func simpleDescription() -> String {\n        return \"A sqaure with \\(numberOfSides) sides of length \\(sideLength)\"\n    }\n}\n\nclass Circle: NamedShape {\n    var radius: Double\n\n    init(radius: Double, name: String) {\n        self.radius = radius\n        super.init(name: name)\n        numberOfSides = 1\n    }\n\n    func area() -> Double {\n        return Double.pi * radius * radius\n    }\n\n    override func simpleDescription() -> String {\n        return \"A circle with \\(numberOfSides) sides and radius \\(radius)\"\n    }\n\n}\n\nclass EquilateralTriangle: NamedShape {\n    var sideLength: Double = 0.0\n\n    init(sideLength: Double, name: String) {\n        self.sideLength = sideLength\n        super.init(name: name)\n        numberOfSides = 3\n    }\n\n    var perimeter: Double {\n        get {\n            return 3.0 * sideLength\n        }\n\n        set {\n            sideLength = newValue / 3.0\n        }\n    }\n\n    override func simpleDescription() -> String {\n        return \"An equilateral triangle with sides of length \\(sideLength).\"\n    }\n}\n\nvar triangle = EquilateralTriangle(sideLength: 3.1, name: \"a triangle\")\nprint(triangle.perimeter)\ntriangle.perimeter = 9.9\nprint(triangle.sideLength)\n"
}

[sourcekite] ***stderr***Fatal error: Loading libsourcekitdInProc.so failed: file /home/kenneth/libraries/sourcekite/.build/checkouts/SourceKitten/Source/SourceKittenFramework/library_wrapper.swift, line 39

[sourcekite] [exited] code: null, signal: SIGILL

@vknabel I think we might have fully/partially solved the issue. The symlink was pointing to the correct file, but the symlink itself was not named correctly. I might have erroneously blindly copied the installation instructions
- sudo ln -s /your/swift/usr/lib/libsourcekitdInProc.so /usr/lib/sourcekitdInProc
+ sudo ln -s /your/swift/usr/lib/libsourcekitdInProc.so /usr/lib/sourcekitdInProc.so

So now if I remove
"sde.enableTracing.LSPServer": true,
"sde.enableTracing.client": true

I don't get any logs in the OUTPUT tab, only the init:
Debugger listening on ws://<IP_ADDRESS>:6004/1dd57ede-46ee-48cd-a4f1-b4af3366bc5b
For help, see: https://nodejs.org/en/docs/inspector

If I re-enable those two options, my output is as follows, still has issues, but I guess not as severe as before right?
Debugger listening on ws://<IP_ADDRESS>:6004/12fb8ba2-ab4e-4d8c-aa95-ee2b39121086
For help, see: https://nodejs.org/en/docs/inspector
[-->onInitialize ] isTracingOn=[true],
	skProtocolProcess=[/usr/local/bin/sourcekite],skProtocolProcessAsShellCmd=[false]
[-->onDidChangeConfiguration]
[-->onDidChangeConfiguration tracing:
	    swiftDiverBinPath=[/home/kenneth/libraries/swift-5.0.2-RELEASE-ubuntu18.04/usr/bin/swift],
		shellPath=[/bin/sh]]
[sourcekite] ***sourcekite initializing with skProtocolProcess at [/usr/local/bin/sourcekite]
[-->SourcekiteResponseHandler constructor done]
[---onDidChangeContent]
[ERROR][1]
[request] {
  key.request: source.request.cursorinfo,
  key.sourcefile: "/home/kenneth/Documents/swift_projects/second.swift",
  key.offset: 2,
  key.compilerargs: ["/home/kenneth/Documents/swift_projects/first.swift","/home/kenneth/Documents/swift_projects/second.swift","-target","x86_64-unknown-linux"],
  key.sourcetext: "print(\"hello world\")"
}

[sourcekite] ***stderr***sourcekit: [1:operator(): 0.0000] did not find primary SourceFilesourcekit: [1:failed: 0.0000] cursor info failed: did not find primary SourceFile
[SourcekiteResponseHandler] 0
{

}

Great to we got a step further! Currently I am mobile and can’t write or test a lot.
A brief search suggests that the extension passes wrong arguments (compare with sourcekit-lsp).
Currently you are using two flat Swift files without any Package.swift-file (which is fine and SDE should handle this correctly). If you are using a Swift Package Manager project these arguments will be calculated differently. This might solve your problem.
Once I’ve got time I will have a deeper look.

having the exact same problem =(

Sorry for the late response, but I did not have a lot time.
I could fix you issue. Essentially SDE did not pass some global environment variables (like PATH, ...).
The fix has been released as 2.8.1.

@vknabel it is working now, thanks!

Works. Thanks a lot @vknabel 👍

Same issue with libsourcekitdInProc.so. Due to a non-root user my workaround is to correctly set PATH and LD_LIBRARY_PATH before starting VScode.
If I add the following to ~/.bashrc and start VScode from console (instead from desktop icon) it works fine:
export PATH="$HOME/swift-tensorflow/usr/bin:$PATH"
export LD_LIBRARY_PATH="$HOME/swift-tensorflow/usr/lib:$LD_LIBRARY_PATH"


Changed LDFLAGS to LDLIBS - g++ can mislink SDL if -lsdl comes before…

When trying to build your example (which is excellent btw), I was getting link errors on SDL:
g++ -std=c++14 -Ofast -march=native -Wall -Wextra -DMAXITER=8000 -DESCAPE_RADIUS_SQUARED=6*6 -Wno-clobbered -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL -DPROG_NAME="\"implicit-simd\"" -pthread -lSDL  mandelbrot-implicit-simd.cc   -o mandelbrot-implicit-simd
mandelbrot-implicit-simd.cc: In instantiation of ‘std::array<double, N> plog2(const std::array<double, N>&) [with long unsigned int N = 8ul]’:
mandelbrot-implicit-simd.cc:83:19:   required from ‘std::array<double, N> Iterate(const double*, const std::array<double, N>&) [with bool WithMoment = true; unsigned int N = 8u]’
mandelbrot-implicit-simd.cc:124:57:   required from here
mandelbrot-implicit-simd.cc:9:77: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     std::uint64_t half_bits    = reinterpret_cast<const std::uint64_t&>(half);
                                                                             ^
/tmp/ccGtzT2f.o: In function `std::thread::_Impl<std::_Bind_simple<Display::Display()::{lambda()#1} ()> >::_M_run()':
mandelbrot-implicit-simd.cc:(.text._ZNSt6thread5_ImplISt12_Bind_simpleIFZN7DisplayC4EvEUlvE_vEEE6_M_runEv[_ZNSt6thread5_ImplISt12_Bind_simpleIFZN7DisplayC4EvEUlvE_vEEE6_M_runEv]+0x2c): undefined reference to `SDL_Flip'
/tmp/ccGtzT2f.o: In function `_GLOBAL__sub_I__Z7GetTimev':
mandelbrot-implicit-simd.cc:(.text.startup+0x717): undefined reference to `SDL_SetVideoMode'

Looking closely, it's because -lSDL is before mandelbrot-implicit-simd.cc, so the link's happening at the wrong time (at least with g++ 5.4.0). I don't know a lot about gcc or g++ but this stackoverflow post indicates that libraries need to be added after their use. I then found this guide on Makefile intrinsics (again, I'm not a C++/C coder) that indicates that LDLIBS is added after the input wheras LDFLAGS comes before.
I changed those two around and your examples now compile on my machine just fine. Even if you think this pull sucks, thanks a lot for these videos. I usually code in high-level languages but your videos have inspired me to play around in the lower levels much more.

As an aside, I ran your make run and got these quite interesting results:
make run
for s in mandelbrot-implicit-simd mandelbrot-openmp-simd mandelbrot-cilkplus-simd mandelbrot-explicit-simd mandelbrot-vanilla ; do ./$s ; done
Frame    22, 3.52 fps...
22 frames rendered
Frame    22, 3.52 fps...
22 frames rendered
Frame    22, 3.52 fps...
22 frames rendered
Frame    45, 8.47 fps....
45 frames rendered
Frame    47, 11.21 fps...
47 frames rendered

Which seems to indicate that vanilla is fastest? This might be because I'm using an AMD CPU and g++ doesn't want to play ball?
processor	: 9
vendor_id	: AuthenticAMD
cpu family	: 23
model		: 1
model name	: AMD Ryzen 5 1600 Six-Core Processor
stepping	: 1
microcode	: 0x8001105
cpu MHz		: 1550.000
cache size	: 512 KB
physical id	: 0
siblings	: 12
core id		: 11
cpu cores	: 6
apicid		: 11
initial apicid	: 11
fpu		: yes
fpu_exception	: yes
cpuid level	: 13
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf eagerfpu pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_l2 mwaitx hw_pstate vmmcall fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 clzero arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold
bugs		: fxsave_leak sysret_ss_attrs

That would seem to be the implication re: vanilla v.s. other timings. Note that there is the displaying-thread overhead involved. To use the exact timing method I did, edit defs.inc, enable TIMINGS_VERSION #define and choose the first (largest) resolution at the top of that file.

As another note, I was using GCC 7.1.0. There may be significant chances to vectorization between 5.4.0 and 7.1.0.


Encoding / charset guessing inconsistencies

Problem Description
This is unrelated to #3969, I'm just coincidentally looking into the whole encoding thing anyway (oh happy day).
I'm currently exposing http.Message.guess_encoding to be able to store it alongside the content in my addon. I figured this would be better than storing just  content (without knowing the encoding) or text (possibly wrongly encoded and I'd lose the original raw data) or both (wasting space). So I'm sending the content bytes alongside the encoding string via gRPC. I'm not touching request/response.text at all. I'd manipulate the stuff on the Node.js end and then send the content bytes back, preserving the encoding (I want to avoid the update magic here https://github.com/mitmproxy/mitmproxy/blob/dac0bfe786a8d1dfdd97f29d6bb262ed258153fa/mitmproxy/net/http/message.py#L218-L223)
If you look at the screenshot you'll notice what inconsistencies I'm talking about.

I'm seeing multiple "utf-8" which comes from text/html; charset="utf-8". Blame Facebook for the quotes (I'm not even sure what the spec says about it). But I think we need to handle them here https://github.com/mitmproxy/mitmproxy/blob/7fdcbb09e6034ab1f76724965cfdf45f3d775129/mitmproxy/net/http/headers.py#L191-L215. That's probably easier than convincing the Facebook team to update :smile:
All "non-text" (I know it's impossible to know if something might not be text in the end using some weird encoding) falls back to latin-1. I'll have to think about this a bit more, I'm currently using https://github.com/gjtorikian/isBinaryFile on the Node.js end, which kind of works but fails for exotic encoding. At least I'd like to be able to distinguish between a latin-1 that was found and latin-1 the fallback.
I'm seeing UTF-8 vs utf-8 vs utf8. Maybe we should normalize them, but I assume every library will treat them equally (maybe we should lower-case them?)

Honestly I'm lacking energy right now to think about this in detail. I'll promise I come back.

Quotes are okay, see https://tools.ietf.org/html/rfc7231#section-<IP_ADDRESS>. I'm happy to accept a PR that improves the parser, but this doesn't really affect us. I'm closing this here as it isn't really a mitmproxy problem - it's ._guess_encoding and not .guess_encoding for a reason. 😉
In Python, normalization is done by the standard library (https://docs.python.org/3/library/codecs.html#standard-encodings). If you need to normalize, you can call codecs.lookup(x).name.

Thanks once again for your patience and help!

Quotes are okay, see https://tools.ietf.org/html/rfc7231#section-<IP_ADDRESS>.

Nice. I was definitely expecting codecs.decode(x, '"utf-8"') to throw, but it just doesn't care. It's very liberal and trims away everything it doesn't like. TIL.
>>> codecs.lookup('"~`+-*/_# \t\nutf8')
<codecs.CodecInfo object for encoding utf-8 at 0x7f69f7aa2e80>

So I guess this will do exactly what I need then :tada:


(PDB-4192) Curl Puppet Server status endpoint

Hitting an endpoint instead of using netcat will work when Puppet Server
is behind a load balancer.
We tried this approach earlier but weren't specifying HTTPS and the
-k flag when curling.

Test PASSed

CLA signed by all contributors.

I don't think the --insecure flag is an issue for getting the status, and as you noted, there's not really a good way around that.

@austb Yeah, no way around --insecure in this case. This seems fine long-term.
Ready for Merge.


Added Contact component for the website.

Also, there is merge-conflict. Can you fetch upstream and resolve it?


macos-pkg: apply required entitlements to vfkit binary during pkg build

although the required entitlements are already applied to the released vfkit
binary, they gets overwritten when codesiging again during the pkg build
process, so we download the entitlements file from code-ready/vfkit and re-apply

/hold

/unhold

Note: waiting for a signed pkg to test from rcm

The biggest question is why are we always resigning everything? Ideally, we'd only sign vfkit once per vfkit release, and reuse the signed binary in crc, same for admin-helper.

indeed, It'd be better if while doing the vfkit release we can publish signed binaries, (its just that we have to follow the whole rcm process) provided the releases of vfkit, admin-helper will be of lesser frequency this is something we should look into