sqlpackage parameter VerifyExtraction

To obtain the database schema and data while skipping the schema validation, perform an Export with the property /p:VerifyExtraction=True
should read
To obtain the database schema and data while skipping the schema validation, perform an Export with the property /p:VerifyExtraction=False

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d81bc053-0d2a-b2c7-d60d-d275bfcda033
Version Independent ID: d81bc053-0d2a-b2c7-d60d-d275bfcda033
Content: Troubleshooting issues and performance with SqlPackage - SQL Server
Content Source: docs/tools/sqlpackage/troubleshooting-issues-and-performance-with-sqlpackage.md
Service: sql
Sub-service: tools-other
GitHub Login: @dzsquared
Microsoft Alias: drskwier

@stephenkeogh -- Stephen, thank you for catching that.  I am updating the article.


VTODO's Last-Modified without 'Z'

According to RFC-5545

The property value MUST be specified in the UTC time  format

(e.g. LAST-MODIFIED:20210326T212333Z)
Storing datetime.datetime.utcnow() produces localtime format (w/o 'Z').
Using datetime.datetime.now(datetime.timezone.utc) produces error:
  File "/usr/local/lib/python3.9/site-packages/vobject/base.py", line 226, in transformFromNative
    raise NativeError(msg, lineNumber)
vobject.base.NativeError: At line 18: In transformFromNative, unhandled exception on line 18 <class 'vobject.base.VObjectError'>: 'Unable to guess TZID for tzinfo UTC'

Maybe this is linked with another bureport #154
PS. macOS 15.7 'Catalina', vobject <IP_ADDRESS> from brew

Not sure if it applies to your situation, but I found that the vobject library does not seem able to work with instances of datetime that use datetime.timezone.utc.
If you have Python 3.9 or later, you can use zoneinfo.ZoneInfo("UTC") instead.  This also works if you install backports.zoneinfo on older versions of Python. Alternatively you can use pytz.utc instead.
In my case the datetime objects were being created by my psycopg2 database layer so I had to adapt them for use with vobject by doing this:
utc = zoneinfo.ZoneInfo("UTC")
vtodo.add("last-modified").value = todo.updated_at.astimezone(utc)


workspace job result viewer needs a loading messgage

in workshop, we're showing assembly result report.txt file, clicked view button, it took a few seconds to load content of the file. it would be nice to have some information that we are loading content.

PR for fix: https://github.com/PATRIC3/p3_web/pull/506

Deployed


Log the user or channel being sent the message

https://github.com/peter-obrien/binoculars/blob/554199c5912ad959ec79c8c4a6b2fa387ad423a7/alarm_handler.py#L79

Fixed with 16553ac9d577ada30e986b4e81ae8f6e62ca343f


change tf.image.decode_image to tf.io.decode_image

tf.image.decode_image to tf.io.decode_image for API migration and consistency which include decode_ jpeg, decode_gif, and decode_png.
Please see https://www.tensorflow.org/api_docs/python/tf/io/decode_image

Afaik, tf.io.decode_image is currently just an alias for tf.image.decode_image. But since the later might get removed in the future, it's ok to replace usage with the more consistent alias.

Oh...Sorry, I accidentally dismissed mihaimaruseac's review approval and added four more commits to this PR during the experiment with vscode pull request extension. Any way I can withdraw these four changes...

git rebase and then git push -f. But it seems copybara merged some of the PR, so closing this and let's create another one to fix

@mihaimaruseac Thank you. I will create another one later.


Correcting documentation issue with Windows Authentication

IdentityServerConstants.ExternalCookieAuthenticationScheme ("idsrv.external") causes failure in the Callback action whose first line calls HttpContext.AuthencicateAsync(IdentityConstants.ExternalScheme);
Changing to
await HttpContext.SignInAsync(
IdentityConstants.ExternalScheme,
allows it to succeed.

This line depends on if you're using ASP.NET Identity or not, so it's not always what you're proposing.


Preview circle is not updated properly after certain edits to fields (ArcMap)

Procedure

With Circle tab create point on map using Map Point Tool
Click in Radius / Diameter field and enter a value
Select all in Radius / Diameter field
Press Delete or backspace

Result:
The Radius / Diameter text box is empty, but the preview circle remains visible
Result expected:
The preview should disappear because the text box is empty
Additional:
Same problem observed with Time and Rate fields in Distance Calculator section of Circle tab.
Also a variation on above:

With Circle tab create point on map using Map Point Tool
Click in Radius / Diameter field and enter a value with a single non zero integer followed by enough zeros to make the preview large enough to be visible
Press Home key
Press Delete key (not backspace)

Result
The Radius / Diameter text box equals zero, but the preview circle remains visible
Result expected:
The preview should disappear because the text box contains only zeros

Fixed in local branch, will hold off making a pull request until appropriate.

PR: https://github.com/Esri/distance-direction-addin-dotnet/pull/316

@kgonzago I'd appreciate your input on something - the Time and Rate text boxes on the Circle tab suffer the same issue as the Distance text box (before my last PR), i.e. clearing them does not clear the graphic. However, I cannot use the same fix for Time and Rate as for Distance due to differing data types of the bound variables - Distance is bound to a string, whereas Time and Rate are bound to double data type variables. The effect of this is that clearing the Distance text box completely still results in the 'set' method of the Distance variable being called, and therefore I can clear the graphic if I need to, whereas clearing Time or Rate completely results in the xaml Validation.ErrorTemplate being triggered, and the set method for Time and Rate is never called, thus no opportunity to clear the graphic.
There look to be several potential fixes, none of which are a 5 minute job. However, the simplest that occurs to me is to change the variables TravelTime and TravelRate to string data type and update the code accordingly, so that the structure for handling Distance, TravelTime and TravelRate is identical. Before I do this - are you aware of any reason why TravelTime and TravelRate are not handled in the same way as Distance?

@rjones0  I believe another developer authored the rate and time logic and did not follow what was already outlined with distance. I'm perfectly fine with having rate and time handled the same way as distance.

Expect this will require manual testing as explained in #316.


Fix manifest scanning in RemoveSnapshots

This PR fixes manifest scanning logic in RemoveSnapshots and prevents orphan files. We are reusing containers while reading manifests for a snapshot but don't create copies when adding entries to the set of manifests to scan.

+1
Good catch. I'm glad we found this before a release.


⚠ T:Riza Community Forum has degraded performance

In 30eb3d8, T:Riza Community Forum (https://community.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 2128 ms

Resolved: T:Riza Community Forum performance has improved in d89aff4.


When quickly drawing shapes with brush tool previous fog sometimes disappears

Likely a race condition with the server updates to fog, I will add a check to make sure any pending fog updates have resolved before processing new updates.

Added check that should mitigate the most noticeable causes of this but it is probably still possible in edge cases

I think actually fixed now


[Purrfect-UI] TopBar

This pull request has been deployed to Vercel.

✅ Preview:
https://matou-technologies-purrfect-ui-storybook-38.vercel.app

🔍 Inspect:
https://vercel.com/matou-technologies/purrfect-ui/CLBm16eBTyxShecwzdB2Uiqk8Lqj


Can't merge in system RAM

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Expected to use the command:
CUDA_VISIBLE_DEVICES="" python3 -m axolotl.cli.merge_lora examples/your_config.yml --lora_model_dir="./completed-model" --load_in_8bit=False --load_in_4bit=False
To be able to merge in system RAM as suggested.
Current behaviour
Running in Windows WSL2 Ubuntu. After successfully creating a lora checkpoint, now it gets a No CUDA GPUs are available error when running said command:
CUDA_VISIBLE_DEVICES="" python3 -m axolotl.cli.merge_lora qlora-70b-sunda.yml --lora_model_dir="qlora-out/checkpoint-2049" --load_in_8bit=False --load_in_4bit=False
/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/bitsandbytes/cextension.py:34: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers, 8-bit multiplication, and GPU quantization are unavailable.
  warn("The installed version of bitsandbytes was compiled without GPU support. "
/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cadam32bit_grad_fp32
/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/deepspeed.py:23: FutureWarning: transformers.deepspeed module is deprecated and will be removed in a future version. Please import deepspeed modules directly from transformers.integrations
  warnings.warn(
[2023-12-26 17:43:22,155] [INFO] [datasets.<module>:58] [PID:11653] PyTorch version 2.1.1+cu121 available.
                                 dP            dP   dP
                                 88            88   88
      .d8888b. dP.  .dP .d8888b. 88 .d8888b. d8888P 88
      88'  `88  `8bd8'  88'  `88 88 88'  `88   88   88
      88.  .88  .d88b.  88.  .88 88 88.  .88   88   88
      `88888P8 dP'  `dP `88888P' dP `88888P'   dP   dP

[2023-12-26 17:43:23,243] [WARNING] [axolotl.validate_config:228] [PID:11653] [RANK:0] We recommend setting `load_in_8bit: true` for LORA finetuning
[2023-12-26 17:43:23,245] [INFO] [axolotl.normalize_config:150] [PID:11653] [RANK:0] GPU memory usage baseline: 0.000GB ()
[2023-12-26 17:43:23,245] [INFO] [axolotl.common.cli.load_model_and_tokenizer:49] [PID:11653] [RANK:0] loading tokenizer... /home/owen/models/NousResearch_Llama-2-70b-hf
[2023-12-26 17:43:23,445] [DEBUG] [axolotl.load_tokenizer:184] [PID:11653] [RANK:0] EOS: 2 / </s>
[2023-12-26 17:43:23,445] [DEBUG] [axolotl.load_tokenizer:185] [PID:11653] [RANK:0] BOS: 1 / <s>
[2023-12-26 17:43:23,445] [DEBUG] [axolotl.load_tokenizer:186] [PID:11653] [RANK:0] PAD: 0 / <unk>
[2023-12-26 17:43:23,445] [DEBUG] [axolotl.load_tokenizer:187] [PID:11653] [RANK:0] UNK: 0 / <unk>
[2023-12-26 17:43:23,445] [INFO] [axolotl.common.cli.load_model_and_tokenizer:51] [PID:11653] [RANK:0] loading model and (optionally) peft_config...
[2023-12-26 17:43:23,447] [INFO] [axolotl.load_model:297] [PID:11653] [RANK:0] patching _expand_mask
Loading checkpoint shards:   0%|                                                                 | 0/15 [00:00<?, ?it/s]
[2023-12-26 17:43:24,181] [ERROR] [axolotl.load_model:478] [PID:11653] [RANK:0] No CUDA GPUs are available
Traceback (most recent call last):
  File "/home/owen/axolotl/src/axolotl/utils/models.py", line 357, in load_model
    model = LlamaForCausalLM.from_pretrained(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3706, in from_pretrained
    ) = cls._load_pretrained_model(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 4116, in _load_pretrained_model
    new_error_msgs, offload_index, state_dict_index = _load_state_dict_into_meta_model(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 778, in _load_state_dict_into_meta_model
    set_module_tensor_to_device(model, param_name, param_device, **set_module_kwargs)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/accelerate/utils/modeling.py", line 317, in set_module_tensor_to_device
    new_value = value.to(device)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/torch/cuda/__init__.py", line 298, in _lazy_init
    torch._C._cuda_init()
RuntimeError: No CUDA GPUs are available
Traceback (most recent call last):
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/owen/axolotl/src/axolotl/cli/merge_lora.py", line 27, in <module>
    fire.Fire(do_cli)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/owen/axolotl/src/axolotl/cli/merge_lora.py", line 23, in do_cli
    do_merge_lora(cfg=parsed_cfg, cli_args=parsed_cli_args)
  File "/home/owen/axolotl/src/axolotl/cli/__init__.py", line 70, in do_merge_lora
    model, tokenizer = load_model_and_tokenizer(cfg=cfg, cli_args=cli_args)
  File "/home/owen/axolotl/src/axolotl/common/cli.py", line 52, in load_model_and_tokenizer
    model, _ = load_model(cfg, tokenizer, inference=cli_args.inference)
  File "/home/owen/axolotl/src/axolotl/utils/models.py", line 479, in load_model
    raise err
  File "/home/owen/axolotl/src/axolotl/utils/models.py", line 357, in load_model
    model = LlamaForCausalLM.from_pretrained(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3706, in from_pretrained
    ) = cls._load_pretrained_model(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 4116, in _load_pretrained_model
    new_error_msgs, offload_index, state_dict_index = _load_state_dict_into_meta_model(
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/transformers/modeling_utils.py", line 778, in _load_state_dict_into_meta_model
    set_module_tensor_to_device(model, param_name, param_device, **set_module_kwargs)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/accelerate/utils/modeling.py", line 317, in set_module_tensor_to_device
    new_value = value.to(device)
  File "/home/owen/miniconda3/envs/axolotl/lib/python3.10/site-packages/torch/cuda/__init__.py", line 298, in _lazy_init
    torch._C._cuda_init()
RuntimeError: No CUDA GPUs are available

Steps to reproduce

Create a lora checkpoint
Try to merge it without enough GPU memory, needing system RAM instead.
Result in the following error.

Config yaml
base_model:
model_type: LlamaForCausalLM
tokenizer_type: LlamaTokenizer
is_llama_derived_model: true
load_in_8bit: false
load_in_4bit: true
strict: false
device_map: sequential
max_memory: {0: "18GIB", 1: "24GIB"}
datasets:
dataset_prepared_path:
val_set_size: 0.05
output_dir: ./qlora-out
save_safetensors: true
adapter: lora
lora_model_dir:
sequence_len: 512
sample_packing: true
pad_to_sequence_len: true
lora_r: 8
lora_alpha: 32
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
lora_target_modules:

gate_proj
down_proj
up_proj
q_proj
v_proj
k_proj
o_proj

wandb_project:
wandb_entity:
wandb_watch:
wandb_name:
wandb_log_model:
gradient_accumulation_steps: 4
micro_batch_size: 2
num_epochs: 1
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0.0002
train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false
gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint: false
local_rank:
logging_steps: 1
xformers_attention: false
flash_attention: true
warmup_steps: 10
evals_per_epoch: 4
eval_table_size:
eval_table_max_new_tokens: 128
saves_per_epoch: 1
debug:
deepspeed:
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
bos_token: ""
eos_token: ""
unk_token: ""
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[X] Windows

Python Version
3.10
axolotl branch-commit
main/628b754824008f2d7c1aad079925a1d8e8cf9f48
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

#918 might address this issue.
@Nero10578 you can check it out and install it using the below (from the axolotl directory)
git fetch origin pull/918/head:pr-918
git checkout pr-918
pip3 install -e '.[flash-attn,deepspeed]' --no-deps

Then you can add
gpu_memory_limit: 20GiB
lora_on_cpu: true

to your axolotl.yml file before running the merge. (change 20GiB to whatever you have minus a few GB since it tends to overshoot a bit).

Awesome! This seems to work great! Just to be sure I should be launching the merge command with python and not accelerate right? Also it does not seem to work with the regular max_memory: {0: "18GIB", 1: "23GIB"} option in the yaml.

It doesn't? That's odd! It definitely should work with both max_memory and gpu_memory_limit (but don't use both at the same time).

As a side note that may be more relevant to your actual issue, in order to do CPU merging, you sometimes need to disable certain flags, such as flash attention, which depend on there being a GPU. My merge script explicitly does --flash_attention=False, for example.

OK, I see why max_memory is not working unless you use gpu_memory_limit -- the latter will add an entry "cpu": "256GiB" to the max memory dictionary before deriving the device map.
So to do your own max_memory thing, add the cpu entry and it should work. E.g.
max_memory: {0: "18GIB", 1: "23GIB", "cpu": "256GiB"}

You probably still need lora_on_cpu: true or it might OOM at the LoRA loading part.

As a side note that may be more relevant to your actual issue, in order to do CPU merging, you sometimes need to disable certain flags, such as flash attention, which depend on there being a GPU. My merge script explicitly does --flash_attention=False, for example.

I am making a PR to make these false by default to remove confusion. Thank you for pointing it out.

Hey @Nero10578 , may I ask if the PR linked by @kallewoof fix it for you?

Hey @Nero10578 , may I ask if the PR linked by @kallewoof fix it for you?

Hi, sorry for the late reply. Have been away since around Christmas. Will get to try this soon and report back.

@Nero10578 , it's merged to main, so you can just pull.


Decouple jsdoc documentation parsing from IDE mode.

Currently the parsing of JSDoc documentation is coupled to the IDE mode
option so normally JSDoc documentation strings are not parsed.  This
prevents the implementation of custom compiler passes like API Documentation
generation.  This patch introduces a new compiler option
(parseJsDocDocumentation) which can be used to enable the documentation
parsing even when not in IDE mode.  The functionality is backward
compatible, when IDE mode is enabled then documentation parsing is always
enabled)

While we're generally hesitant to add more flags (because it adds complexity and provides new and interesting ways that things can go wrong) this makes sense to me. I wonder if it would make sense to get rid of "IDE mode" boolean on the CompilerOptions object, and just have the --ide_mode flag be shorthand for both parseJsDocumentation and the other things that are controlled by IDE mode (I don't recall what all of those are right now).

Sorry, just noticed you added a "needs-cla" label. I already signed a CLA, please check your CONTRIBUTORS file.

I don't see an entry for kayahr. Did you switch usernames at some point?

Nope. I already signed the CLA before you switched to GitHub so you may have no reference to my GitHub account. The CONTRIBUTORS file lists E-Mail addresses and not usernames. My email address is<EMAIL_ADDRESS>as you can see in the details of my Github account.

Someday I'll get around to cleaning that up. See #412

Looking closer, you're not adding a new flag to the command-line, just a new option in the CompilerOptions, which is good as it keep the command-line interface from becoming any more complex than it already is. Cool :)

@MatrixFrog ide_mode prevents the compiler from failing early on errors (so it can cause instability due to unexpected AST contents) and skips the optimization phase
I'm ok with change, did anyone have any outstanding concerns or should we ask the author to update pull request so we can merge it?

Sure, I think we can merge this.

Had to do the merge from the command line so I uploaded it as a separate PR in order to get Travis to run again. Committed as 7e9f3b2855fa40e678c2b70254f7d886802bb409


DRAFT circle file viewer

on-going draft to provide circle model viewer.
Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #790


Execute the function in the scheduled task immediately when the program starts。

For example, I have a task that is executed every minute. When I start the program, cron will start to execute my task in the next minute. Can I add an option such as "Execute once now" task。
If I manually call the task once in the program, it will look very ugly, and some situations cannot be satisfied

you can write a custom schedule,but this only support stand parser.
type StartNowSchedule struct {
	firstTime int32
	schedule  cron.Schedule
}

func NewStartNow(spec string) (*StartNowSchedule, error) {
	schedule, err := cron.ParseStandard(spec)
	if err != nil {
		return nil, err
	}

	return &StartNowSchedule{schedule: schedule}, nil
}

func (schedule *StartNowSchedule) Next(t time.Time) time.Time {
	if schedule.firstTime == 0 {
		schedule.firstTime = 1
		return t
	}

	return schedule.schedule.Next(t)
}

this is quite needed indeed. the AddJob(spec string, cmd Job) could be simply refactored to AddJob(spec string, cmd Job, runOnStart ...bool) to keep the backwards compatibility and the scheduler would fire the tasks one after another in the order they were added.


APIM-4805: User can search APIs within a category

Issue
https://gravitee.atlassian.net/browse/APIM-4805
Description
Added possibility to search by category id, or category key.
Before my changes: the endpoint only allows keyword search and cannot be given a category context.
Additional context

📚  View the storybook of this branch here

🏗 Your changes can be tested here and will be available soon:
Console: https://pr.team-apim.gravitee.dev/7422/console
Portal: https://pr.team-apim.gravitee.dev/7422/portal
Management-api: https://pr.team-apim.gravitee.dev/7422/api/management
Gateway v4: https://pr.team-apim.gravitee.dev/7422
Gateway v3: https://pr.gateway-v3.team-apim.gravitee.dev/7422

Why allow the user to send either the category id or key? Can we limit the user to send only the category id?

Works on localhost
https://github.com/gravitee-io/gravitee-api-management/assets/8080303/9f719063-c020-40eb-91b1-0371079ac37d


[docs] Please add RSS support for the blog

tracked in https://github.com/tauri-apps/tauri-docs/issues/1845


Presentation: Add support for the old KeySetJSON format

https://github.com/iTwin/itwinjs-core/pull/2402 changed KeySetJSON to use compressed IDs instead of an array of IDs. Turns out some consumers have been persisting these JSONs in the old format and now they fail to deserialize. No problem to support both formats...

@mergifyio backport release/3.4.x

@mergifyio backport release/3.5.x


Add-on (phpMyAdmin) #ddev-generated files not added to .ddev/.gitignore

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
After switching to the phpMyAdmin add-on (see #3534), I noticed the files that are generated (with #ddev-generated in themdon't get added to.ddev/.gitignore` like I would expect.
Describe your solution
I added this to my root .gitignore for the time being:
/.ddev/.disabled-services/docker-compose.phpmyadmin.yaml
/.ddev/docker-compose.phpmyadmin-norouter.yaml
/.ddev/docker-compose.phpmyadmin.yaml
/.ddev/commands/host/phpmyadmin

I'd much rather DDEV handled this automagically it its own .gitignore.
Am I missing something
Describe alternatives
No response
Additional context
DDEV version is v1.22.1
Our DDEV config can be found in https://github.com/neurocracy/omnipedia/tree/9.x/.ddev
I also found #2180 while searching but unsure if it's directly related.

I think it's behaving correctly. People in general want to check in add-ons so their whole team has the same behavior.
The files you list are intended to be checked in with git.

I very much favour an automated workflow as my methodology; we use Composer to manage our many custom Drupal modules along with Yarn for front-end packages; as a result, we avoid committing anything that can or should be pulled in automatically, instead relying on lock files and similar things to keep different environments synced. Given all of the other stuff that's not meant to be checked in which gets built or pulled in automatically, this feels unexpected from a DX point of view, or at least it does from my point of view.

The DDEV philosophy is that everything that is part of a project can be checked in. Sorry it doesn't match yours. The basic idea is that any developer should be able to check out a project and ddev start and have it work the same as every one of their colleagues. That's why it's this way.

Doesn't running ddev start for the first time download and build a bunch of stuff (automatically .gitignored by default) as defined by .ddev/config.yaml (which I check in)? I clearly don't need to check in the stuff that it adds to .gitignore to reproduce the project on another machine. Ultimately it's your project and you can decide what you want to do, but I was just suggesting that how DDEV already treats its own generated configs be extended to how the generated configs for add-ons are treated by default, because I found it confusing that it did that in the former case but not the latter.

ddev start does not install add-ons. ddev start does generate many files that you do not need to check in. But it has no way to know what add-ons you might have.
It might be possible to make ddev start use the new metadata that's available to reinstall all add-ons... if you checked in the metadata. There are no plans to do that.

Of course you can take over the .ddev/.gitignore by removing the #ddev-generated from it and checking it in. You can also use a project or global .gitignore to implement the way you prefer to work. The way it's working for add-ons right now is the way it's planned to work. Happy to continue the conversation here or elsewhere, but closing for now.

Fair enough. I guess I misunderstood how add-ons are intended to work.


LLVM 12 support

Resolved by https://github.com/tomhrr/dale/commit/d4c9669316c7d25c80618e858a75ebe09ab32c85 (includes LLVM 13 as well).


Using Mosby V3 to add views to the WindowManager directly crashes

Hello!
We've been using Mosby for a fair amount of time on a production app. We've had a lot of work coming in, and we haven't been able to update it to the v3. We were happy with v2, but there were several weird crashes that we wanted to solve.
After reading the instructions, the update process went super smooth. All the views that we've been using on the app were correctly rendered. Here is where the complain begins 😄
Our app is using the WindowManager to show contextual info when you are outside of the app. Just like the Facebook Bubbles. For example, our root view inherits from MvpRelativeLayout.
When the views are attached to the window, the PresenterManager class tries to obtain the Activity, with no success. The context you can retrieve there, is directly the Application object, so it is impossible to cast it to Activity.
If you want to me to assemble a little project with the parts that would reproduce the issue, don't doubt to ask
Mosby Version:
v3.0.4
Actual behavior (include a stacktrace if crash)
11-22 23:58:49.622 17039-17039/? E/AndroidRuntime: FATAL EXCEPTION: main
                                                   Process: com.XXX, PID: 17039
                                                   java.lang.IllegalStateException: Could not find the surrounding Activity
                                                       at com.hannesdorfmann.mosby3.PresenterManager.getActivity(PresenterManager.java:229)
                                                       at com.hannesdorfmann.mosby3.mvp.delegate.ViewGroupMvpDelegateImpl.<init>(ViewGroupMvpDelegateImpl.java:79)
                                                       at com.hannesdorfmann.mosby3.mvp.layout.MvpRelativeLayout.getMvpDelegate(MvpRelativeLayout.java:77)
                                                       at com.hannesdorfmann.mosby3.mvp.layout.MvpRelativeLayout.onAttachedToWindow(MvpRelativeLayout.java:85)
                                                       at XXXX.onAttachedToWindow(WidgetContainer.kt:107)
                                                       at android.view.View.dispatchAttachedToWindow(View.java:17377)
                                                       at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3319)
                                                       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1658)
                                                       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1386)
                                                       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6733)
                                                       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:911)
                                                       at android.view.Choreographer.doCallbacks(Choreographer.java:723)
                                                       at android.view.Choreographer.doFrame(Choreographer.java:658)
                                                       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
                                                       at android.os.Handler.handleCallback(Handler.java:789)
                                                       at android.os.Handler.dispatchMessage(Handler.java:98)
                                                       at android.os.Looper.loop(Looper.java:164)
                                                       at android.app.ActivityThread.main(ActivityThread.java:6541)
                                                       at java.lang.reflect.Method.invoke(Native Method)
                                                       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
                                                       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Steps to reproduce the behavior or link to a sample repository
Add any MvpViewGroup class to the WindowManager (using the SYSTEM_ALERT_WINDOW permission)
Thank you very much!

Yep, Actvity is required to determine if view is destroyed temporarily or
permanently and therfore release / destroy Presenter. Im not sure how to
get this information without activity. I will check that next week but I'm
afraid that there is no simple solution.
What you can do, however, is to stick with Mosby 2.x for activityless
ViewGroups. You can totally use Mosby 2 and Mosby 3 at the same time in
your project.
Luis R<EMAIL_ADDRESS>schrieb am Do., 23. Nov. 2017, 11:45:

Hello!
We've been using Mosby for a fair amount of time on a production app.
We've had a lot of work coming in, and we haven't been able to update it to
the v3. We were happy with v2, but there were several weird crashes that we
wanted to solve.
After reading the instructions, the update process went super smooth. All
the views that we've been using on the app were correctly rendered. Here is
where the complain begins 😄
Our app is using the WindowManager to show contextual info when you are
outside of the app. Just like the Facebook Bubbles. For example, our root
view inherits from MvpRelativeLayout.
When the views are attached to the window, the PresenterManager class
tries to obtain the Activity, with no success. The context you can retrieve
there, is directly the Application object, so it is impossible to cast it
to Activity.
If you want to me to assemble a little project with the parts that would
reproduce the issue, don't doubt to ask
Mosby Version:
v3.0.4
Actual behavior (include a stacktrace if crash)
11-22 23:58:49.622 17039-17039/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.XXX, PID: 17039
java.lang.IllegalStateException: Could not find the surrounding Activity
at com.hannesdorfmann.mosby3.PresenterManager.getActivity(PresenterManager.java:229)
at com.hannesdorfmann.mosby3.mvp.delegate.ViewGroupMvpDelegateImpl.(ViewGroupMvpDelegateImpl.java:79)
at com.hannesdorfmann.mosby3.mvp.layout.MvpRelativeLayout.getMvpDelegate(MvpRelativeLayout.java:77)
at com.hannesdorfmann.mosby3.mvp.layout.MvpRelativeLayout.onAttachedToWindow(MvpRelativeLayout.java:85)
at XXXX.onAttachedToWindow(WidgetContainer.kt:107)
at android.view.View.dispatchAttachedToWindow(View.java:17377)
at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3319)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1658)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1386)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6733)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:911)
at android.view.Choreographer.doCallbacks(Choreographer.java:723)
at android.view.Choreographer.doFrame(Choreographer.java:658)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

**Steps to reproduce the behavior or link to a sample repository**
Add any MvpViewGroup class to the WindowManager (using the `SYSTEM_ALERT_WINDOW`)

Thank you very much!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/sockeqwe/mosby/issues/281>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjnrl4vJZe3gdI1pJO7RuD1-KYgf6clks5s5VrfgaJpZM4QooGS>
.

Sorry for the long delay in getting back to you.
In the end, we went with both versions of Mosby on our app.
Thanks

I'd like to revive this Thread. This Android-X mosby3 only is needed


email validator with empty string slow?

Hey, I've been writing some unit tests for my node.js project and one of the tests is showing as slow quite often, 40-100ms. Basically its validating an empty string against an email. eg:
validate({email:""},  {
  email: {
    presence: true,
    email: true,
    length: {
      minimum: 6,
      maximum: 255
    }
  }
});

Running in the browser it seems to be about 15-20ms which isn't as bad but still seems pretty slow?

Test code
// This line is node specific
var validate = require("validate.js");
console.time("validate");
validate({email:""},  {
  email: {
    presence: true,
    email: true,
    length: {
      minimum: 6,
      maximum: 255
    }
  }
});
console.timeEnd("validate");

Results
           | Chrome  | Node.js |
-----------+---------+---------+
    Run #1 | 7.328ms |     2ms |
    Run #2 | 0.246ms |     0ms |
    Run #3 | 0.094ms |     0ms |
    Run #4 | 0.085ms |     0ms |
    Run #5 | 0.109ms |     0ms |
    Run #6 | 0.103ms |     1ms |
    Run #7 | 0.242ms |     0ms |
    Run #8 | 0.125ms |     0ms |
    Run #9 | 0.159ms |     0ms |
   Run #10 | 0.159ms |     0ms |
-----------+---------+---------+
      Mean | 0.865ms |     0ms |
 Std. dev. | 2.272ms |     1ms |

Conclusion
Measuring performance is tricky.
Chrome has lots of JIT compilation which speeds up subsequent calls.
Node seems to be consistently fast.

Sorry didn't get round to this before but heres a jsperf test http://jsperf.com/js-validate-empty-string
Noticeably slower across the 3 browsers I tested. I would of though the performance would be comparable to null/undefined

This particular problem was fixed in d9944f48595b1f74d0edb844bb8035dd0cd8c20b but the problem probably comes from the RegExp that parses the email.
It is bound to be pretty slow. Is this causing any actual problems?

Yeah I guess its not a huge deal, but eking out a little more performance would be nice. But just had a quick look at the source and it doesn't look as easy as something like email === "" return false though

If you rerun the test against the 0.4.0 source it should be faster for empty strings
On Mon, Feb 9, 2015 at 12:10 AM, Jesse<EMAIL_ADDRESS>wrote:

Closed #25.
Reply to this email directly or view it on GitHub:
https://github.com/ansman/validate.js/issues/25#event-232175160


[general] Custom favicon colour enhancement

This new feature in beta version allows users to define colors for the org favicons.
The current red (screenshot) and orange colors are similar. In addition, I'd like the red to be deep-dark-red and visually alarming.

Describe the solution you'd like
The best option is to allow end users to determine colors as they want in a color palette.
Alternatively, it's ok if the red is enhanced.

Hi @ext-xixiao,
I did some improvements on the releaseCandidate version which is not yet released as beta. Basically you'll be able to choose any html color
More details on the how to page
https://github.com/tprouvot/Salesforce-Inspector-reloaded/blob/releaseCandidate/docs/how-to.md#customize-extensions-favicon

Looking forward to the color enhancement in beta! Thanks for pointing to the doc ❤！

Hi @xixiaofinland ,
I submitted the new beta on the chrome web store yesterday, it should be available soon!

Hi @xixiaofinland the beta version has been released by Chrome, it should be available soon.

Worked like a charm @tprouvot , thank you so much!
I can happily remove the other plugin now!


Introduce Entity.__type__ to replace ApiMessage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e1eac6) 96.67% compared to head (3154565) 96.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   96.67%   96.69%   +0.02%
==========================================
  Files          14       14
  Lines         992      999       +7
  Branches      140      140
==========================================
+ Hits          959      966       +7
  Misses         29       29
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Retrieve array from RecordBatch for a leaf column

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

While working filter pushdown for iceberg-rs: https://github.com/apache/iceberg-rust/pull/295, I am going to use the APIs like ArrowPredicateFn and RowFilter.
When constructing ArrowPredicateFn for iceberg predicate, we provide a filtering function that takes RecordBatch based on the given projection.
The RecordBatch contains the columns specified in the projection. And we need to access correct column in the batch to evaluate the predicate.
For top-level column, it should be straightforward. But for nested column, seems no way to access the particular array from the RecordBatch.
We only have the projection (i.e., ProjectionMask) which contains indices of leaf columns in the batch.
For example, if the schema has [a, b, c] top columns. b is a struct column with [aa, bb, cc] columns. Give a predicate like cc > 1, and we know the leaf indices of the nested column cc is 3.
Is there API we can use to access the array of cc in the RecordBatch?
Describe the solution you'd like

Describe alternatives you've considered

Additional context

I don't believe we currently have a mechanism for nested projection of RecordBatch but this is something that I think would be generally useful and a worthwhile addition


Some melee weapons do not use Brawn

These weapons need a damage field.  Maybe an option to specify that the melee weapon does not use brawn

Now in dev branch


Ensure the codebase respects PSR-2.

Ensure the codebase respects PSR-2.

Definitely agree on the trailing whitespace trimming + adding new line to the end of a file, a couple instances where braces haven't been placed on the next line, and some missing explicit visibility declarations.
Most of the changes are to brace placement though.
While I generally like most the of PSR-2 recommendations, I don't like their (seemly arbitrary to me) decision to recommend that class/method braces should look like this:
class Foo
{
    public function bar()
    {
        ...
    }
}

but control structure braces should look like this:
foreach ($foo as $bar) {
    if ($bar === 'boo') {
        ...
    }
}

Personally I prefer the former style because it separates each structure into distinct (more readable) blocks. What I really don't want is having (again, apparently arbitrary) inconsistencies in style for different code structures.
That and I tend to like to leave whitespace either side of the logical negation operator so it's not so easy to skim over 🤷♂

I am pretty sure you can enforce your custom style guide with a tool like PHPCodeSniffer. It has presets for PSR-2, but can be adapted to more custom rools like these ones as well. And finally, you can use Travis-CI to check these issues as well.

I like this!
Any idea if there are any nice presets that I can switch on when defining the custom ruleset? Otherwise I'll take a more in depth look at the custom rules tomorrow.

I am afraid I don't know. But it should just be a matter of enabling a few flags (in a special file that PHPCS reads, I believe).
If that is too complicated, you can also try out StyleCI. It allows the configuration through a GUI, but might not be as flexible.
Good night...

No worries.  So it appears I may have to hunt down the right options. There also appears to be a way to do it by specifying custom PHP scripts to do parts of the validation, which may not be too difficult if it comes down to it (since these are very minor specific changes). But I'll leave that till tomorrow.
I think I'd prefer this over StyleCI if I can get it working, (the only way to get my current styling to pass in StyleCI appeared to be turning off brace checks all together – which would make it considerably less useful).

Good night...

Night!

@franzliedke
Okay, so as promised I did take a look at phpcs. Unfortunately while a lot of the options they've added as configurable are pretty easy to turn on/off – it looks like I won't be able to (even make minor changes) to the stuff I want without greping for the error messages I'm seeing and making many minor code changes.
(Unfortunately the existing code isn't that extensible, so changing small bits of functionality means re-implementing entire methods). I've also had issues where validation rules that aren't listed by phpcs -e are still being applied (meaning rules are using each other without being configurable within the ruleset files :/).
I still think this is a good tool to use (since most of the code I want to use has been written), but it'll require a bit more work to get right than I had hoped.

Hmm, at this point I would humbly suggest configuring this as far as you can get with PHPCS, and then just rolling with it. IMO, an enforcable style guide is more important than personal preferences, but ultimately that's your decision, of course. ;)

Fixed conflicts

What about this PR @aidantwoods ?

I could not see the build status of StyleCI either @aidantwoods

Conflict resolved @aidantwoods

Alright, so I've given it some thought and I think making it easier for others to contribute is probably more important than my personal preferences RE the code styling.
If at some point in the future I can find something that'll enforce my style guide then I'll probably switch back, but for now I'll go with what's available :)

So I'm looking into StyleCI again – it appears the only way to isolate which repos it has write access to would be to:

Make use of GitHub's ToS allowance for an additional free bot account by creating one to use exclusively to facilitate StyleCI access.
Transfer the SecureHeaders repo to an organisation
Give this new account admin access to the repo from within the organisation
Configure StyleCI from this new account

Ping @GrahamCampbell

From StyleCI's end, I can't see why they'd need any more permissions than TravisCI:

In contrast this is what StyleCI requests:

As far as that goes, even the GitHub help page cautions that level of access:

StyleCI has to do this so that it can add it's webhook and deploy key. Travis does not need this, since it has special integration with GitHub.

We have no plans to change the access level we need, since it's perfectly reasonable.

Any chance to make these permissions optional and create webhook and deploy key manually?

Sorry, there are no plans to add this.

For security reasons, we can't reveal our webhook secret key.

Based on that response I don't think I can allow StyleCI persistent access to my repos. If they are compromised at any point, I'd rather my repos didn't go with them. And I don't really like the sound of a global secret being used here :/

And I don't really like the sound of a global secret being used here :/

It's actually not a global secret. It's generated on a per repo basis, however, we're still not giving it out to users.

We have asked GitHub to implement more fine grained permissions, however they haven't yet.
Also, actually, to get the most out of StyleCI, we need push access to the code, you can make use of our one-click fix system, designed to save people time. Most people want things to just work, with no effort on their part.

@aidantwoods I guess you either need to live with it, or use an alternative like PhpCodeSniffer on Travis. Not as comfortable, though.

I've had another look at phpcs, but it seems that's it isn't happy with the current code (despite StyleCI giving it the OK), so it might require a few big fixes before I can use it.
Unfortunately I'll never just be comfortable giving admin access to all my repos when I only the only functionality I actually want could be satisfied by read. It's an huge unnecessary risk, but I'd love to give StyleCI a go if they ever implement a a mode that doesn't require giving them admin access to all my repos for the entire duration of use.
@GrahamCampbell can StyleCI not just request access to webhooks if you really can't let users access these keys? Webhooks are a very different level of access to that given by admin on the whole repo.

Unfortunately I'll never just be comfortable giving admin access to all my repos when I only the only functionality I actually want could be satisfied by read.

Well unfortunately that means you can't use StyleCI. Sorry.

I've had another look at phpcs, but it seems that's it isn't happy with the current code (despite StyleCI giving it the OK), so it might require a few big fixes before I can use it.

I'd recommend PHP-CS-Fixer over phpcs. :)


An installation issue on windows via "python -m pip install manim"

Collecting manim
Using cached manim-0.14.0-py3-none-any.whl.metadata (10 kB)
Collecting Pillow (from manim)
Using cached pillow-11.0.0-cp313-cp313-win_amd64.whl.metadata (9.3 kB)
Collecting click>=7.1 (from manim)
Using cached click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
Collecting click-default-group (from manim)
Using cached click_default_group-1.2.4-py2.py3-none-any.whl.metadata (2.8 kB)
Collecting cloup<0.8.0,>=0.7.0 (from manim)
Using cached cloup-0.7.1-py2.py3-none-any.whl.metadata (7.8 kB)
Collecting colour (from manim)
Using cached colour-0.1.5-py2.py3-none-any.whl.metadata (18 kB)
Collecting decorator<6.0.0,>=5.0.7 (from manim)
Using cached decorator-5.1.1-py3-none-any.whl.metadata (4.0 kB)
Collecting isosurfaces==0.1.0 (from manim)
Using cached isosurfaces-0.1.0-py3-none-any.whl.metadata (2.9 kB)
Collecting manimpango<0.5.0,>=0.4.0.post0 (from manim)
Using cached ManimPango-0.4.4.tar.gz (4.1 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [21 lines of output]
Traceback (most recent call last):
File "C:\Users\王钧盛\scoop\apps\python\current\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 353, in
main()
~~~~^^
File "C:\Users\王钧盛\scoop\apps\python\current\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
~~~~^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\王钧盛\scoop\apps\python\current\Lib\site-packages\pip_vendor\pyproject_hooks_in_process_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
File "C:\Users\王钧盛\AppData\Local\Temp\pip-build-env-z3xprmlt\overlay\Lib\site-packages\setuptools\build_meta.py", line 332, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=[])
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\王钧盛\AppData\Local\Temp\pip-build-env-z3xprmlt\overlay\Lib\site-packages\setuptools\build_meta.py", line 302, in _get_build_requires
self.run_setup()
~~~~~~~~~~~~~~^^
File "C:\Users\王钧盛\AppData\Local\Temp\pip-build-env-z3xprmlt\overlay\Lib\site-packages\setuptools\build_meta.py", line 318, in run_setup
exec(code, locals())
~~~~^^^^^^^^^^^^^^^^
File "", line 42, in
File "", line 38, in get_version
KeyError: 'version'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
[notice] A new release of pip is available: 24.2 -> 24.3.1
[notice] To update, run: python.exe -m pip install --upgrade pip
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.

Anyone could help?Thanks really a lot!

Thanks for the report, this is a duplicate of #112 and #114. Will be fixed with the upcoming Manim release (and has already been fixed in ManimPango's codebase).
You can use Python 3.12 in the meantime as a workaround.


MeshInstance as a child of RigidBody looks crooked in game, but fine in editor.

Godot version
3.3.2.stable.official
System information
Linux Mint (Ubuntu 20), GLES3, RTX 3090, Driver Version: 460.27.04
Issue description
A cube as a child of a rotated rigid body looks crooked in the final game. This is only the case, when it is a child of the rigidbody. The cube looks fine in the camera preview in the editor.

It seems to have something to do with the transforms properties of the child objects.
Steps to reproduce
Create a RigidBody, with a MeshInstance as a child. Rotate the RigidBody. The Mesh will look different in the game, than it does in the camera preview in the editor.
Minimal reproduction project
Pinball.zip

The RigidBody is scaled, but it should not be as its scale will be reverted to Vector3(1, 1, 1) when the project is run:

Instead, scale the MeshInstance and resize the CollisionShape's extents (but do not scale it!).

 Though that was the case, but wanted to report it nevertheless.

Scaling of RigidBodies is currently not supported and is a known limitation. There are plans to support uniform scaling of RigidBodies in the future (but non-uniform scaling is unlikely to ever be supported): #5734

This should really be implemented soon. I can't be the only noob, that fell for that. It is not really intuitive. One could at least give a warning or something.

One could at least give a warning or something.

Judging from the screen, you did have a warning (the yellow triangle) in editor...

That warning was for the missing collision shape, not from scaling of the rigidbody.

A warning is already supposed to be emitted, but it's not working for some reason: https://github.com/godotengine/godot/blob/902911e3afcaabcc9f09a6f2c3ec770ee6aa112d/scene/3d/physics_body.cpp#L783-L796
cc @pouleyKetchoupp

Is there a reason, why it is not emmited, when the mode is static or kinematic?
One could just change
get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER
to
'get_mode() == MODE_RIGID || get_mode() == MODE_CHARACTER || get_mode() == MODE_KINEMATIC || get_mode() == MODE_STATIC'

A warning is already supposed to be emitted, but it's not working for some reason:

There's no warning in MRP because mode is set to Kinematic. No idea whether the problem in this case is no warning or if in Kinematic mode scale can be modified just fine and there's something else going on.

The RigidBody is scaled, but it should not be as its scale will be reverted to Vector3(1, 1, 1) when the project is run:

The problem is I don't see it being reverted to (1, 1, 1) after run. Maybe in the physics server it's set to such scale but the scale of RigidBody.transform is unchanged.


Parameter in constraint created for template 'K8sRequiredLabels' appears as 'object:object' in edit view

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a cluster, navigate to dashboard, enable OPA gatekeeper.
Create a constraint for K8sRequiredLabels with parameter key='labels' and value = [ { "allowedRegex": "^[a-zA-Z]", "key": "gatekeeper" } ].
Click edit as form .

Result:
Parameter's value appears as '[object Object]'.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-2463-head- e651c7a81
Installation option (single install/HA): Single

Verified on master branch on 2.4-head 454daa475 rancher set up.
For parameter other than string should be entered in yaml view. In form view user can only enter a string key value pair.
For the key value pair given in steps to reproduce the issue, value is entered in yaml view and it worked as expected.


Feature to discuss: configure list of actions to notify

Hi Philip,
First, thanks for sharing your work :)
In our project, we find the notifications quite noisy. We are only interested in :deployed actions. I am wondering if you're open to add a new config parameter. Something like:
set :slackistrano, {
  channel: '#your-channel',
  actions: [:deployed]
}

That would be nicer to implement rather than to hack into rake / capistrano internals or monkey patch your gem.

Makes sense! Thanks for the pointer, I missed it when I looked.


Please type another input file name

Hello, I meet a problem when I run the .tex file. It says "\usetikzlibrary{quotes,arrows.meta}  Please type another input file name".

same, have you solved it ?


More unit tests

Adds tests and fixes a few unfound bugs

Closing for inactivity. Let's re-open if you want to fix merge conflict + tests and merge this through.

I'm not going to fix these tests until #231 is fixed. Leaving out security tests for the sake of passing tests doesn't seem sensible to me 😂

So my conclusion is that the security is implemented properly, but no control hooks are in place anymore to configure the maximum memory usage.

once tests are passing i'll review 👍


Change repo name

I'm suggesting to change the repository name from phenotypic_profiling_model to phenotypic_profiling. We do more than just present the "model" in this repo. What do you think @jenna-tomkinson , @roshankern, @MattsonCam

I think this is a good idea. 👍 Makes the repo name simpler and reflects the manuscript title.

I agree, feel free to change!

Perfect! Let's change this after we merge all outstanding PRs but before DOI minting 👍

renamed! Closing this issue now.
The next steps are 1) to perform a final full pass through the manuscript; 2) add any additional minor modifications to this repo; 3) Mint!


Point cloud support

Description 📝
Point clouds are present in many use cases of the built environment. Especially, it would be interesting to be able to open E57 and LAS files.
Suggested solution 💡
There are some libraries available to make it possible:
E57:

http://www.libe57.org/
https://github.com/asmaloney/libE57Format
https://github.com/cry-inc/e57

LAS:

https://github.com/visgl/loaders.gl/tree/master/modules/las
https://github.com/gadomski/las-rs

Alternative ⛕
No response
Additional context ☝
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

For the sake of keeping the library as small and scoped as possible, we are skipping this for now. There are libraries out there that can do this, including three.js.


Add ESLint

I'm thinking we should use Prettier. I already have a setup I've been working on, so maybe I'll steal this story from you.

I'm all for Prettier. We're using it at my work now. Are you thinking of some sort of post commit hook, or have Travis complain if people don't run it through Prettier?
Also, we are thinking of Phoenix/Elm stack, so perhaps we won't need any JS formatting tool. Elm has elm-format, which is quite similar.

Actually, I have a pretty good pre-commit Prettier setup, so I'm thinking I'll use that.
I thought we decided on Phoenix/Vue?

We did? Haha. I thought we were still considering Elm. No big deal, I'm fine with Vue.

I'm fine with whatever, just somehow had the impression we decided to give Vue a go, maybe I misremembered.

I'm fine with whatever as well. At some point in the next year my hope is to try and integrate Elm at work, so I was thinking I might start here. That being said, I've never used Vue and would be willing to go that route as well.


UnParse does not match Parse - FormatCommandLine extension ignores Required

 Issue by StefanBertels
Thursday Dec 01, 2016 at 17:31 GMT
Originally opened as https://github.com/gsscoder/commandline/issues/381

Thanks for the great lib.
I have an option class like this:
public class TargetArguments
{
    [Option('m', Required = true, HelpText = "might be an empty string?")]
    public string TargetCallMode { get; set; }

    public override string ToString() => Parser.Default.FormatCommandLine(this);
}

When my property is set to an empty string (zero length) I get no error when calling FormatCommandLine and there is no "-m" in output.
I suggest that FormatCommandLine throws an Exception if it would produce output that cannot be parsed later. UnParse should match Parse here.
Another question: Should an empty string cause the option to be missing? I would expect an zero length string to be a valid option value (it's more clear that null  can be seen as missing). I guess this might be difficult to parse? Anyway: how to pass an empty string value? Something like  -m ""

Related to your empty string / null question: https://github.com/commandlineparser/commandline/issues/187

FormatCommandLine do't apply parser validation rules, By-Design.


Fixed index of unknown district

Issue
Unknown district was causing consecutive districts with the same background-color
Fix
Filtered out unknown district while computing as the UI is written separately for it
Type of PR

[x] Bugfix

Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Before:

After:

Hah I knew someone would fix this! Thank you :P


process stop to support list of processes

Feature Request
I can do
process stop my1
process stop my2

I cannot
process stop my1 my2

Use Case:
process list | xargs process stop

like with docker
docker ps -aq | xargs docker stop

Proposed Change:
Who Benefits From The Change(s)?
Like docker.
Alternative Approaches
for loop or something more complicated than xargs

Added in v0.60.0
Feel free to reopen if it doesn't work as expected.


Add type annotations

Is this issue still relevant ? I would like to work on it

Yes, still relevant. Your contribution would be quite welcome.


Make aggregated values available for labels

Use case:
We want to make a cluster map. We can use our clusterCount function for that, for example:
const viz = new carto.Viz(`
  @c_count: clusterCount()

  color: red
  width: @c_count
  resolution: 16
`);

It's a common convention for cluster maps to be labeled with the number of features represented by the cluster marker:

However we can't use the clusterCount in a label.
Right now VL requires us to use an original dataset attribute for labels instead, like in this example:
https://carto.com/developers/carto-vl/examples/#example-point-labels
const viz = new carto.Viz(`
  @c_count: clusterCount()
  @v_features: viewportFeatures($poi_name)

  color: red
  width: @c_count
  resolution: 16
`);

....
const features = viz.variables.v_features.value;
...
"label_field": `${f.properties['poi_name']}`,

Can we create a way to use aggregated values for labels, so something like this would work?
const viz = new carto.Viz(`
        color: fuchsia
        width: 6
        strokeColor: white
        strokeWidth: 2
        filter: $major == "YES"
        @cc: clusterCount()
        @v_features: viewportFeatures($poi_name, @cc)
      `);

Hi @ztephm 👋 I added two examples in this PR https://github.com/CartoDB/carto-vl/pull/1259, but I'd like to know if there's another dataset we can use in order to have a better one. Thanks! ✨

cc @makella

Thanks, it looks great!
Here's an open dataset of Montreal parking signs I used for a cluster map. Depending on the settings it can have clusters with numbers up to 3 digits—in the example it could be good to show clusters with 1-, 2- and 3-digit numbers:
signalisation_rd_tt.zip
Or you could just use Populated Places, @ramiroaznar did a test a while ago that has clusters showing 2 and 3 digits depending on zoom:
ne_10m_populated_places_simple.zip

Also, you can use Gencat data as I did in this example (not working because of the API Key)
https://bl.ocks.org/ramiroaznar/f856209982304290f1152828a7bf7f2b

Merged in master ✨ We'll have to document it properly and research how can we improve the labels visualization. Meanwhile, we've added a couple of examples 👍

Before the final examples are ready, we want to look into a couple of additional functionalities with Mapbox GL labeling and also fine-tune the ones we have. @ztephm @ramiroaznar thanks for the datasets! Will take a look through!


Create glossary.mdx

Init the glossary for unit 2 and added the strategies to find the optimal policy and the value-based methods studied in the unit.

Hey there 👋 , nice work 🤗. I think there's other terms that you and classmates can add to the glossary: Q-Learning, Q-Function, Epsilon greedy / Greedy strategy, Monte Carlo, TD.

Related to: #128

@simoninithomas should we merge this as discussed and then let people add new PRs? That way we have the content up for people in unit 2 and we develop this iteratively :)

FYI #128 has a couple of ideas we could add here

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Is there any method which can adjust the speed of synthesized speech?

test_result.zip
"audio = net_g.infer(x_tst, x_tst_lengths, noise_scale=.667, noise_scale_w=0.8, length_scale=1.1)[0][0,0].data.cpu().float().numpy()"
I increased the value of length_scale, then the speed of synthesized speech slowed. But the last word of the audio doesn't sound clear.


Add args to Docker env

addresses https://github.com/systemslab/popper/issues/454

Hello @Franko1307! Thanks for submitting the PR.

In the file cli/popper/commands/cmd_env.py, following are the PEP8 issues :

Line 100:80: E501 line too long (80 > 79 characters)
Line 105:80: E501 line too long (101 > 79 characters)

In the file cli/popper/commands/cmd_init.py, following are the PEP8 issues :

Line 105:80: E501 line too long (110 > 79 characters)

awesome, thanks a lot!


Exclude muted users from stream pushes.

@showell the second commit has a bug due to not handling topics being case-insensitive.  Otherwise looks good.

Ah, good catch.  I also need to build  an index here.

index here = index on MutedTopic?  Yeah, I noticed actually that table is probably missing some indexes it should have.

Merged, thanks @showell!


javax.net.ssl.SSLException: Received fatal alert: certificate_unknown

I'm trying to send push notifications to iOS devices.
I've created a developer certificate for the APNS and bonded it with the application identifier.
I then proceeded to use Pushy to establish a connection to the APNS server, using the examples provided:
final PushManagerFactory<SimpleApnsPushNotification> pushManagerFactory =
        new PushManagerFactory<SimpleApnsPushNotification>(
                ApnsEnvironment.getSandboxEnvironment(),
                PushManagerFactory.createDefaultSSLContext( DEV_CERT_P12__PATH, DEV_CERT_P12__PASSWORD )
                );

final PushManager<SimpleApnsPushNotification> pushManager = pushManagerFactory.buildPushManager();

pushManager.registerFailedConnectionListener(new MyFailedConnectionListener());

pushManager.start();

public static class MyFailedConnectionListener implements FailedConnectionListener<SimpleApnsPushNotification> {

    public void handleFailedConnection(
            final PushManager<? extends SimpleApnsPushNotification> pushManager,
            final Throwable cause) {

        System.out.println("ERROR  -  "+ cause.toString());

        if (cause instanceof SSLHandshakeException) {

            // This is probably a permanent failure, and we should shut down
            // the PushManager.
        }
    }
}

I get this error: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown.
I tried to ask on stackoverflow, by so far no luck: http://stackoverflow.com/questions/24101643/apple-apns-and-entrust-secure-ca-root-certificate
Could it be an issue with Pushy ?

We faced the same issue today.  On a linux server running pushy the p12 file from the Mac works perfectly.  The same on a Windows server running pushy was failing.  Exported and reconverted the certificate and the Windows server pushy started working.  I also noticed that the size of the certificate reduced from 7KB or thereabouts to 3KB after the command line export/convert.  Maybe this is some hint?

+1 I have the same trouble now

My best guess is that this is being caused by a bug in Keychain Access; we've documented the problem and a workaround on the wiki. We've also filed a bug report with Apple.
It's worth noting that this problem will basically go away when the APNs servers move to a token-based authentication scheme and we no longer need to present client certificates when connecting; please see #314 for additional details and discussion.

Thanks, it works, but I think that too little attention is given to it in the readme. It took about an hour to find this solution, I think, not me alone.


Add InputStats to track bytes processed by a task

This is based on #12750 and #10407
Description

Track bytes processed by a task and expose in task reports along with row stats
Supported for classic batch and streaming ingestion
Not supported for MSQ ingestion in this PR
Not supported for FirehoseToInputSourceReaderAdaptor
processedBytes measure the uncompressed input bytes. e.g. in case of the sample "wikipedia" datasource, it measures the total size of the unzipped wikipedia.json file (and not the wikipedia.json.gz)
Records that are counted as unparseable, thrownAway or processedWithErrors also count towards processedBytes

Implementation

Add class InputStats to track processed bytes
Add method InputSourceReader.read(InputStats) to read input rows while counting bytes.

Since we need to count the bytes, we could not just have a wrapper around InputSourceReader or InputEntityReader (the way CountableInputSourceReader does) because the InputSourceReader only deals with InputRows and the byte information is already lost.

Classic batch: Use the new InputSourceReader.read(inputStats) in AbstractBatchIndexTask
Streaming: Increment processedBytes in StreamChunkParser. This does not use the new InputSourceReader.read(inputStats) method.
Extend InputStats with RowIngestionMeters so that bytes can be exposed in task reports

Tests and refactors

Update tests to verify the value of processedBytes

HdfsInputSourceTest
S3InputSourceTest
GCSInputSourceTest
OssInputSourceTest
SqlInputSourceTest
DruidSegmentReaderTest
KinesisIndexTaskTest
KafkaIndexTaskTest

Rename MutableRowIngestionMeters to SimpleRowIngestionMeters and remove duplicate class
Replace CacheTestSegmentCacheManager with NoopSegmentCacheManager
Refactor KafkaIndexTaskTest and KinesisIndexTaskTest

Pending items

docs

Further work

Support for MSQ ingestion

Release note
Track bytes processed by a task and publish them in the task report along with the row stats.
Sample row stats in a task report:
"rowStats": {
    "buildSegments": {
        "processed": 24433,
        "processedBytes": 11956576,
        "processedWithError": 0,
        "thrownAway": 0,
        "unparseable": 0
    }
}

Screenshots
Batch ingestion

Streaming ingestion

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[x] a release note entry in the PR description.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

Thanks a lot for the review, @AmatyaAvadhanula !
Thanks for doing the initial work on this, @somu-imply , @pjain1 !


Enable proxy tests

Proxy test is currently disabled.
We need to have a proxy server that we own for testing the feature

Proxy testing is now running as part of tests.


Usage example for run -d

I have an app that consists of a backend (Java) and a UI (static html files). The jar and the HTML files are then assembled into a WAR.
What does cflocal offer in such a case? I want to be able to change the Java or the UI coding and automatically have this reflected in the running app.
I have a Maven build where in the target directory I can see the extracted app, containing the html files in the root, the libraries in the lib folder etc. I figured this would be the natural candidate to point to but when doing so I get the error that catalina.sh could not be found.
Are there any examples that show where to point the -d work dir to? Are there best practices when working with Eclipse and Maven? Using a Tomcat inside Eclipse I get a roundtrip time of around 5s if I change Java and a roundtrip time of 0.5s when changing the HTML. It's hotdeployed. But this is outside the CF environment so I need to use cflocal. Is it possible to achieve similar times there?

CF Local provides the same buildpacks as CF. The Java buildpack requires a compiled Java JAR or WAR, so instead of cf local run -d, the recommended development work for CF Local is to use Spring Boot DevTools, which can update a running app as you develop locally. You can use SBDT with CF Local just like you would with CF.
https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-devtools.html

@sclevine is it possible to get some docs up on how to use -d anyway? I am evaluating cf-local currently for a local development environment and it would seem like it checks all the tings, but some of the docs are lacking.

CF Local is currently on hold while we build out the Cloud Native Buildpacks project, which has a CLI that's similar to CF Local. I plan to update CF Local to use pack underneath once we finish converting all the CF buildpacks to the new Cloud Native Buildpacks API.
Cloud Native Buildpacks has an API intended to support local development that should work in cases where -d doesn't.

@sclevine so, I am not sure if -d works, or doesn't. I was mostly interested how to use it. Most of CF Local seems to do. It's just this and my inability to forward a service (see my comment on #27).

Figured out another way, just export to docker using cf local export app and then run it in docker while mounting only the public dir and vendor using
docker run --rm -p 8080:8080 -v /.../public:/home/vcap/app/public -v /.../vendor:/home/vcap/app/vendor app
Paths may differ for you, I am using this options.json file
{
	"WEBDIR": "public",
	"COMPOSER_VENDOR_DIR": "vendor"
}


feat(queryRules): add queryRuleCustomData widget

This is the 2nd PR in the series "Merchandized Query Rules".

This creates the queryRuleCustomData widget, responsible for showing custom data (userData) coming from Query Rules.
Usage
instantsearch.widgets.queryRuleCustomData({
  container: widgetContainer,
  transformItems: items => items[0],
  templates: {
    default({ title, banner, link }) {
      if (!banner) {
        return '';
      }

      return `

${title}

      `;
    },
  },
});

Stories
See stories →
Related

Merchandized Query Rules RFC

GitHub seems to also display the changed introduced in #3599, that's weird.

These changes seem to be a different PR? Not sure what to review here

I think the base might be wrong :)

I said in https://github.com/algolia/instantsearch.js/pull/3600#issuecomment-472837790 I think that's a GitHub bug. You can ignore the changes related to Storybook.

Without custom CSS classes, the inserted div container is not easily customizable because nothing identifies it.
I think we should create an InstantSearch.css spec for this widget with the following markup:

It would imply adding a cssClass option to the widget, like in most widgets.
WDYT?

makes sense to me!


dffml: accuracy: Accuracy type plugin

addresses #732
Signed-off-by:  Sudhanshu<EMAIL_ADDRESS>

Great work!!


Need more clear and detailed process status.

For example: It keep showing SERVER ERROR while getting problems. But it is unclear what the error is. I've uploaded the image in the demo page (via mobile browser) and the server seems to get the file, but when showing NOW COLORING it suddenly shows an error.

you can investigate through the command prompt or bash output in your computer.
but if you are talking about the demo site (i.e. http://paintschainer.preferred.tech/ )
outputing those messages could be helpful because afaik they are mainly caused by busy server or io stream locking or other gateway failure etc.
the program itself is quite robust from my use experiences.

Sorry, the demo sever was in trouble because of hosting server resetup.

Well then. Sorry for too long reply. At least we can see uploading and coloring status.


Added a note about Docker Toolbox for Windows 7 users

The Docker will not run on Windows 7 but the error is not informative and someone(like me) could spend lots of time trying to find what is the issue and how to solve it.

Description
Windows 7 users should use Docker Toolbox instead of Docker. Docker installation will fail with not informative message LightWeightInstaller has stopped working. After enabling assembly binding logging (FusionLog) one may find, that the issue is PresentationFramework.Aero2.dll can't be found. But instead of trying to solve the issue, one should just use Docker Toolbox.
CLA

[ ] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

Thanks @Serhiy-Shekhovtsov !


Loading referenced libraries from BuildScript csproj file

When buildscript has csproj referenced libraries could be loaded from csproj so #ass directives wouldn't be needed in most scenarios.
You could still use #ass directives when needed.. for example when you are executing deploy script on production enviroment or executing script with web api and you don't have csproj file.

referenced libraries are resolved from csproj file if csproj file is at the one of the next locations:
   private static List<string> _csprojLocations = new List<string>()
        {
            "BuildScript.csproj",
            "BuildScript.csproj",
            "Build.csproj",
            "BuildScript/BuildScript.csproj",
            "BuildScripts/BuildScripts.csproj",
            "Build/Build.csproj",
        };

You can disable loading of referenced libraries with attribute:
 [DisableLoadScriptReferencesAutomatically]
 public class BuildScript : DefaultBuildScript


docs: update form and input examples

Description

Adds docs as requested in issue #18
Checklist
Please ensure your pull request fulfills the following requirements:

[x] The commit messages follow our guidelines (CONTRIBUTING.md)
[x] Tests for any changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Type
What kind of change does this pull request introduce?

[ ] Bug
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other (please describe below)

Breaking Changes
Does this pull request introduce any breaking changes?

[ ] Yes
[x] No

Other Information

n/a

@frankiereyes Our pipeline wasn't properly configured for pull requests. Do you mind rebasing this branch? Thanks!

@justinlettau done! Let me know if you need anything else. Thanks!!


PHOENIX-6950 PhoenixDriver APIs should unlock closeLock only if thread is able to take lock

Thank you @shahrs87, the checkstyle warnings don't seem relevant, let me merge this soon.

let me merge this soon.

@virajjasani  My vote is non-binding. Good to get a review from committer also. FYI.

oh, my bad


[flutter_tools] pin frontend_server_client because upgrading from 3.2.0 -> 4.0.0 regresses test

Example failing build: https://ci.chromium.org/p/flutter/builders/try/Windows tool_integration_tests_2_6/26698?
From attempted roll: https://github.com/flutter/flutter/pull/145959

I ran this locally and added debug prints on the stdout and stderr of the dart.bat invocation:
[stderr] Checking Dart SDK version...

[stderr] Downloading Dart SDK from Flutter engine ...

[stderr] Rename-Item : Access to the path 'D:\git\flutter\bin\cache\dart-sdk' is denied.
At D:\git\flutter\bin\internal\update_dart_sdk.ps1:74 char:9
+         Rename-Item $dartSdkPath "$oldDartSdkPrefix$oldDartSdkSuffix"
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (D:\git\flutter\bin\cache\dart-sdk:String) [Rename-Item], IOException

[stderr]     + FullyQualifiedErrorId : RenameItemIOError,Microsoft.PowerShell.Commands.RenameItemCommand

[stderr]

[stderr] Error: Unable to update Dart SDK. Retrying...

[stderr] ERROR: Input redirection is not supported, exiting the process immediately.

[stderr] Checking Dart SDK version...

[stderr] Downloading Dart SDK from Flutter engine ...

The timeout was happening for me locally because batch_entrypoint_test.dart tries to rename frontend_server_aot.dart.snapshot, but this happens when frontend_server_aot.dart.snapshot is actively in use, because it is used by the test runner, which makes Rename-Item fail. The changes in https://github.com/flutter/flutter/pull/146229 make the test pass locally, but the CI check is still timing out, so there must be something else going wrong.

I added some logging statements to https://github.com/flutter/flutter/pull/146229 and observed that the test times out on CI because a file is not getting copied successfully. Excerpt from these logs:
../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/bin/flutter_tools.dart:5:8: Error: Error when reading '../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/lib/executable.dart': The system cannot find the path specified.

import 'package:flutter_tools/executable.dart' as executable;
       ^
../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:14: Error: Method not found: 'main'.
  executable.main(args);
             ^^^^

Error: Unable to create dart snapshot for flutter tool.

I updated the PR with the following additional expectation to confirm this:
https://github.com/flutter/flutter/blob/2bd2ef93389c1ba649c43ac0328c049e096a2995/packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart#L68-L76
Excerpt from these logs:
22:45 +11 ~2 -1: test/integration.shard/batch_entrypoint_test.dart: flutter/bin/dart updates the Dart SDK without hanging [E]
  Expected: <true>
    Actual: <false>

  package:matcher                                         expect
  test\integration.shard\batch_entrypoint_test.dart 68:5  main.<fn>

One solution is to make batch_entrypoint_test.dart do a clone of the flutter/flutter repo into the temp folder instead of trying to copy it there. Is that acceptable, @christopherfujino? Or do you have another idea?

I added some logging statements to #146229 and observed that the test times out on CI because a file is not getting copied successfully. Excerpt from these logs:
../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/bin/flutter_tools.dart:5:8: Error: Error when reading '../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/lib/executable.dart': The system cannot find the path specified.

import 'package:flutter_tools/executable.dart' as executable;
       ^
../../../../t/flutter_batch_entrypoint_test.d8ce6ed5/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:14: Error: Method not found: 'main'.
  executable.main(args);
             ^^^^

Error: Unable to create dart snapshot for flutter tool.

I updated the PR with the following additional expectation to confirm this:
https://github.com/flutter/flutter/blob/2bd2ef93389c1ba649c43ac0328c049e096a2995/packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart#L68-L76
Excerpt from these logs:
22:45 +11 ~2 -1: test/integration.shard/batch_entrypoint_test.dart: flutter/bin/dart updates the Dart SDK without hanging [E]
  Expected: <true>
    Actual: <false>

  package:matcher                                         expect
  test\integration.shard\batch_entrypoint_test.dart 68:5  main.<fn>

One solution is to make batch_entrypoint_test.dart do a clone of the flutter/flutter repo into the temp folder instead of trying to copy it there. Is that acceptable, @christopherfujino? Or do you have another idea?

I'm taking a look at this now...

So after investigating this issue and the proposed fix in https://github.com/flutter/flutter/pull/146229, here are my conclusions:

The disk i/o implementations of dart.exe foo.appjit.snapshot and dartaotruntime.exe foo.aot.snapshot are different in that the latter will keep the snapshot file open for the duration of VM execution while the former will (presumably) close it after having read the data. I verified this with running a minimal dart program that runs indefinitely from both appjit and aot snapshots, and from another powershell session tried calling Rename-Item on the snapshot file--the rename succeeded on the appjit snapshot but failed on aot snapshot with Rename-Item : The process cannot access the file because it is being used by another process..
version 4.0.0 of frontend_server_client is changing the package:test runner to use an aot snapshot of the frontend_server rather than an appjit snapshot: https://github.com/dart-lang/webdev/pull/2263.
The tool's batch_entrypoint_test is validating the logic in Flutter's update_dart_sdk.ps1 powershell script. Of interest to this issue is that at line 74, before downloading a new version of the Dart SDK, we call Rename-Item on the existing (or old) Dart SDK to move it to a path with dart-sdk.old in the name. I believe we do this because just deleting the old one while the tool is running would fail.
The fact that this test is failing after this change to the frontend_server_client depended on by the test runner is incidental to the specific behavior the test is running, and thus Derek's proposed test changes would make sense there.
The fact that this test is failing inadvertently revealed what I believe would be a real customer regression, in that when calling flutter upgrade, if there is any running dart process that is using an aot snapshot from the Dart SDK within the Flutter SDK's cache, flutter upgrade would likely fail at the step where it tries to download the new version of the Dart SDK. Re-running the flutter CLI tool would likely repeatedly fail as long as said Dart process is running.

It seems like the immediately implications of rolling frontend_server_client forward will be that--on windows--any user using flutter upgrade while a dart process spawned via frontend_server_client is running will experience a crash (of the flutter upgrade process), and likely not be able to download the new Dart SDK until the other dart process exits.
@elliette & @derekxu16 do you know if anything else in Flutter is using frontend_server_client other than testing?

For context, I filed a more general tracking issue for how this will affect Flutter users: https://github.com/flutter/flutter/issues/146164#issuecomment-2040805169

@elliette & @derekxu16 do you know if anything else in Flutter is using frontend_server_client other than testing?

I don't know of anything else in Flutter that uses package:frontend_server_client. This commit (https://github.com/flutter/flutter/commit/1a44710d19809134fac64ab3fc3cf112e48b0868) added some sites where flutter_tools launches processes that run the frontend_server AOT snapshot though. These processes never outlive the invocation of the flutter tool that starts them.

Fixed by https://github.com/flutter/flutter/pull/146650

Fixed by #146650

Thanks!


Keyboard/commands to navigate back and forth between terminal and editor

Say I launch:
 "Hydrogen Launcher: Launch Jupyter Console in Platformio Terminal"

I now have two "windows": the original one for editing my python code, and the new one running the terminal running the Jupyter console.
How can I navigate between them using only the keyboard?

It looks like you can do this from the Platformio Terminal itself: https://github.com/platformio/platformio-atom-ide-terminal#terminal


added np.size() overload and added tests

[x] - resolves #9464
[x] added unit tests for the np.size() function

Hi @shourya5, Thank you for your contribution. :smile:
As this feature will be mentioned in our next release notes, could you add a short description of this feature as a small release note .rst file. Here are the instructions to do so.


Cognito ID/Access Token do not contain user pool custom attributes

Hi,
I notice here that user pool custom attributes are not injected into the JWT
https://github.com/getmoto/moto/blob/624de34d82a1b2c521727b14a2173380e196f1d8/moto/cognitoidp/models.py#L526
As described in the AWS Cognito docs:

"The ID token can also contain custom attributes that you define in your user pool. Amazon Cognito writes custom attribute values to the ID token as strings regardless of attribute type."

Would it be possible to add the custom attributes to this method?

Hi @davidtwomey, welcome to Moto! I'll raise a PR with this feature in a bit.

This is now part of moto >= 4.2.14.dev8 - just let us know if you run into any (other) problems.

Awesome that was very quick!
Thanks @bblommers!


Use of custom editor component causes console warning "Invalid data sent to remark."

Describe the bug
I have made a custom editor component called "YouTube". It is possible to add multiple YouTube videos to this component.

The first time you add the component to a post it works fine, - you can add and remove YouTube videos to your hearts desire.
The issue arises when you want to modify the list of YouTube videos. When loading the editor component a warning is printed in the console, and then when using the Netlify CMS UI to add a new YouTube video, the preview disappears and the add button stops working completely.
I am able to manually add another YouTube video via markdown editing, but that isn't exactly user friendly.
To Reproduce
You can find the repository here: https://github.com/Healios/netlify-cms-add-issue
Steps to reproduce the behavior:

Go to the "News" collection.
Click on the news piece "11/08/21 Demo Title".
See error:

Sent invalid data to remark.
Plugin: youtube. Value: `youtube https://www.youtube.com/watch?v=kpSwmLlMu9E title image /uploads/paid.png alt awdawdawdawdawdawdawd placement Center end youtube https://www.youtube.com/watch?v=kpSwmLlMu9E title undefinedimage /uploads/paid.png alt awdawdawdawdawdwadawdsgsesef placement Center end`.
Data: [{"youtube":"https://www.youtube.com/watch?v=kpSwmLlMu9E","title":"","image":"/uploads/paid.png","alt":"awdawdawdawdawdawdawd","placement":"Center"},{"youtube":"https://www.youtube.com/watch?v=kpSwmLlMu9E","title":"undefined","image":"/uploads/paid.png","alt":"awdawdawdawdawdwadawdsgsesef","placement":"Center"}]

Scroll down to the "Content" field.
Click the "Add youtube video" button.
See YouTube video placeholders disappear from preview.

Expected behavior
I expected another YouTube video editor to be added to the editor component, and another YouTube video placeholder to be shown in the preview pane.
Screenshots

Applicable Versions:

Netlify CMS version: 2.10.139
Git provider: GitHub
OS: Ubuntu Xenial 16.04
Browser version: Brave 1.28.106
Node.JS version: 12.18.0

CMS configuration
https://github.com/Healios/netlify-cms-add-issue/blob/master/static/admin/config.yml
Additional context
I am using Gridsome.

I give up.
It's sad to see that there's so many issues with Netlify CMS and that they're seemingly not being worked on. I have another significant issue where I'll be lagged to oblivion for simply having a page with a lot of content...
You're generally told by maintainers that you're free to provide solutions to these issues, which is fair but not realistic. It takes a lot of time to get into a large codebase, and you need experience with the technologies used.
Frankly it'd be easier to start from scratch on a new CMS (for someone like me).
I wasn't able to solve this issue, but from changing the editor component to an object instead of a list (and thereby only supporting one youtube video per editor component), it worked. It works even though I get the same console error.
In it's current state I can't recommend Netlify CMS.


A few comment fixups in BigQueryIO

Some of the comments were lost in a recent cleanup PR.
Some other comments, I just made them shorter and equally or more clear.
(the fact that builder methods don't modify the current object, I
believe, does not need to be spelled out on every builder method
of every transform)
R: @tgroh
CC: @reuvenlax

lgtm

Coverage decreased (-0.01%) to 70.183% when pulling f82ac27abc7aad825483e14c8d48b653e3f33bea on jkff:bq-comments into 477e789a4f554a23c9a100364c95bee1e01b23f8 on apache:master.


The storage can be used normally, but the LDC status is "pending"

kubectl get ldc
NAME                NODEMATCH           PHASE
controller-node-1   controller-node-1   Pending
node-1              controller-node-1   Pending
node-2              worker-node-1       Pending
node-3              worker-node-2       Pending
worker-node-1       worker-node-1       Pending
worker-node-2       worker-node-2       Pending
The disk is SDD, but the HDD is issued, so the LDC is recreated through YAML，Node-1, node-2 and node-3 are the LDC of SSDs created through YAML，And because the SC created is HHD by default, it is recreated through YAML as the type of SSD
kubectl describe ldc node-1
Name:         node-1
Namespace:
Labels:
Annotations:
API Version:  hwameistor.io/v1alpha1
Kind:         LocalDiskClaim
Metadata:
Creation Timestamp:  2023-02-28T02:23:31Z
Generation:          1
Managed Fields:
API Version:  hwameistor.io/v1alpha1
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
.:
f:kubectl.kubernetes.io/last-applied-configuration:
f:spec:
.:
f:description:
.:
f:diskType:
f:nodeName:
Manager:      kubectl-client-side-apply
Operation:    Update
Time:         2023-02-28T02:23:31Z
API Version:  hwameistor.io/v1alpha1
Fields Type:  FieldsV1
fieldsV1:
f:status:
.:
f:status:
Manager:         local-disk-manager
Operation:       Update
Subresource:     status
Time:            2023-02-28T02:23:31Z
Resource Version:  216654
UID:               951fd045-982b-47fe-bf3b-73cbab1a705d
Spec:
Description:
Disk Type:  SSD
Node Name:    controller-node-1
Status:
Status:  Pending
Events:
kubectl get pvc
NAME            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS            AGE
task-pv-claim   Bound    pvc-6231892a-dcbd-4288-8fde-21b5ab90c75c   3Gi        RWO            local-storage-ssd-lvm   64m

can you provide 'lsn', 'ld' status and yaml configuration?

no response, close!