Singin/Login page layout

Describe the bug
Login and sing-in page needs layout changes
I am not UX designer at all but there is a pretty major list of problems that I would fix (there might be more problems which I don't mention)

Remember me checkbox is not styled at all
Login button should be bigger centred and should be only one element inline
Social login buttons shouldn't be a circle with an icon (it looks like a social link in footer), I don't have an idea how to make it better
Login in with a forgot password is not aligned with other elements
Forgot password stands out too much
Show password icon (eye) should be inside a textbox

Discussion about these changes is welcome
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser: Vivaldi (chromium)

Are you working on this issue? (Yes/No)
No

Yes true I didn't make it during design therefore it was copied as it is from previous design.
There is a reason the button is left aligned. This might help you. https://www.interaction-design.org/literature/topics/fitts-law
There are no hard and fast rules for button styling. It should follow just some few basic guidelines: It must appear clickable and should clearly depict what'll happen on clicking. So, no need.
Yes there are aligment issues in the developed version. Correction is needed. You might refer to the XD prototype I've made.
Forgot password has similar styling and size like New User? Sign up and Login with elements. So that doesn't really stand out.
Yes it should be inside.

I would like to work on this issue and come up with a solution covering all the suggested changes
Thanks

I am a UI/UX designer and can make a better Log-in/Sign-in page.
I am planning to make a Figma file with the design of the new Log-in page, before starting to code.
Can I take this issue? (The PR linked to this issue is inactive for a long period of time.)

It's already completed and has a pr linked to it.

@angrycharas Nitin is coordinating UX remake, We already have prortotype. If you would like to work on new UX please ask on #UX on Slack

Hi i am Harshal Goyal
I am an undergraduate student and i am willing to participate in gsoc 2020

Can you please help me out by guiding me about project

Hello @HarshalGoyal The best place for asking such things is our Slack

Still relevant

What is still relevant? Also, we'll be styling all checkbox uniformly soon.

@nitin10s

Login in with a forgot password is not aligned with other elements
Show password icon (eye) should be inside a textbox

I can work on the login-page for whatever seems off if all the claimers aren't working on it anymore, It's the second page all user's sees while visiting, I did a styling of the checkbox  #1259  (awaiting reviews)
@MrBartusek @nitin10s

@nitin10s @abstrekt I completely re-elaborate the whole issue, now it should be cleaner

Removing some padding & margin will fix point 3

CV uses fontawesome, so we can use their social icons, should look good for point 2.

maybe for 4

Shall I start working on it now? @nitin10s @MrBartusek

We've tweaked the input boxes actually, I'll send the new design soon.

was it Sign-in/Sign-up page layout ..

https://github.com/CircuitVerse/CircuitVerse/pull/853#issuecomment-633228560


Add screenshot to README

Or animated gif you want to be fancy 😄

Thanks for reminding us to do this Eddie!


Change "Secrets" to "Secrets and variable" in README.md

@connorads It's really cool project!
I changed a little bit of README.md due to a change of UI text in GitHub settings.

Thank you for the awesome idea and project.

Nice one @HwangTaehyun 🫡 감사합니다~~ ㅋㅋㅋ


kernel[0]: Sound assertion - 8086:a170 FIFO error (Stream 8)

mac os 10.11.6
asus z170-a alc892
clover fixhda audio inject 1
kernel[0]: AppleALC: (DEBUG) patcher @ last kext is  and its name is com.apple.iokit.IOSerialFamilySound assertion in AppleHDACodecGeneric at line 366

when the log show
kernel[0]: Sound assertion - 8086:a170 FIFO error (Stream 8)
the sound will stop working
if i pause the music, wait a monment,
play again the music,it's normal.
so? how can i to do?

I see.
Unfortunately this is not a problem with AppleALC but the resources you use and/or the hardware you have. I am sorry but I cannot really help you.
What I could imagine happening is some physical interference from some other device nearby or maybe heat. But that's just a blind thought, don't rely on it.


Add Samoan

I created a new project as this here is not maintained anymore, including your list:
https://github.com/LDNOOBWV2/List-of-Dirty-Naughty-Obscene-and-Otherwise-Bad-Words_V2/

I created a new project as this here is not maintained anymore, including your list:
https://github.com/LDNOOBWV2/List-of-Dirty-Naughty-Obscene-and-Otherwise-Bad-Words_V2/


Get current bibserver code running on agreed bibjson spec

Working on agreeing bibjson (schema is on the website), then make bibsoup example site parse incoming collections to meet this spec. So, update the bibtex parser, and update the blog to show how the parse comes out. Ensure that future parsers meet this spec.

Done.


Joystick visualization widget

Both for calibration and visualization

Added RCrosshair today; should probably move to "RSomethingWidget" or "RSomethingDrawable" naming scheme soon


Ensure the hooks directory is created before writing to it.

This addresses issue https://github.com/cf-platform-eng/tile-generator/issues/276.

If it breaks if there is no hooks directory that would be a good first check and create if non existent bit of code that should be done.
On August 23, 2018 6:50:26 PM UTC, Pete Wall<EMAIL_ADDRESS>wrote:

@petewall requested your review on: cf-platform-eng/tile-generator#277
Ensure the hooks directory is created before writing to it..
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/cf-platform-eng/tile-generator/pull/277#event-1806064866


BottomBar cuts the content!

I had a problem that is described here: https://github.com/roughike/BottomBar/issues/737
I was prompted by such a decision:
https://github.com/roughike/BottomBar#how-do-i-draw-it-under-the-navbar
But this solution does not work right!
Android 4 (nexus 5):

Android 5 (nexus 5X) after using style v21:

Original picture:

@SergeyAppDroid do you have the shy mode as well? or just undernavbar?

use shy|underNavbar:
<com.roughike.bottombar.BottomBar             android:id="@+id/bottomBar"             android:layout_width="match_parent"             android:layout_height="@dimen/bottomBarSize"             android:layout_alignParentBottom="true"             android:layout_gravity="bottom"             android:background="@color/colorPrimary"             app:bb_behavior="shy|underNavbar"             app:bb_tabXmlResource="@xml/bottombar_tabs"             app:bb_inActiveTabAlpha="0.6"             app:bb_activeTabAlpha="1"             app:bb_activeTabColor="@color/icons"             app:bb_showShadow="false"             app:bb_inActiveTabColor="@color/colorInActive"             app:bb_badgesHideWhenActive="true"/>

yes, so the shy behavior if i'm correct @roughike can correct me if i'm wrong, what it does is that it allows the content to be drawn underneath so that when you scroll and the bottobar hides, you can still see the content behind it without having to resize as you scroll. And that's why you are getting that behavior, if you don't want that then remove shy, and if you do want shy, then you need to add the margins to the imageview so that it only uses the visible area, or use the anchor attribute of the coordinatorlayout, hope this helps

Now I do this:

determine the height of the NavigationBar for a particular device
2) imageView.setPadding(0,0,0,navBarHeight);

It works, but can there be a more correct way?


More robust sed regex syntax in compile_nsync.sh

The syntax \t for a tab character in sed is not standard. That escape is a GNU sed extension.

But OS X sed, like other *BSD sed, doesn't support \t for tab and instead treats \t as meaning backslash followed by t.

So currently, nsync Android build in MacOS fails with

ar cr nsync.a common.o counter.o cv.o debug.o dll.o mu.o mu_wait.o note.o once.o sem_wait.o time_internal.o wait.o "nsync_semaphore_mutex.o per_thread_waiter.o yield.o ime_rep_timespec.o nsync_panic.o"
ar: nsync_semaphore_mutex.o per_thread_waiter.o yield.o ime_rep_timespec.o nsync_panic.o: No such file or directory
make: *** [nsync.a] Error 1

So added a $ to the seq syntax to enable ANSI-C Quoting, and problem resolved.
Reference: Simple sed replacement of tabs mysteriously failing

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

Jenkins, test this please.


(t)weet doesn't work in Docker container

Description

After running a typing test and pressing t, nothing happens.
To Reproduce

Run in Docker (docker run -it coloradocolby/thokr)
Complete a typing test
Press t

Expected behavior

I would expect some sort of Twitter-friendly text to copy paste or Twitter opens up with the tweet pre-filled.
Environment

OS: macOS
Terminal Emulator: xterm
Crate version: 0.1.0

@amorriscode I saw this as well when testing in Docker. The reason is docker isn't aware of what your BROWSERS environment variable is. If you passed that in it might work, but I wouldn't be surprised if it didn't given you're not actually taking the test on your host. 🤔 I'm not a huge fan of the copy/paste idea, especially in comparison to the convenience of how it nicely it works outside of docker. Maybe what I'll do is just hide the tweet option if I can rule out that a browser is unavailable.

That's fair. Worlde does the clipboard so I'd say that's a pretty safe/expected approach if available. I'd bet most people don't run it in Docker anyways but who knows!

tracking https://github.com/amodm/webbrowser-rs/issues/46


Crate release is missing

It seems that we had not new release after the last PR #8, so this functionality is still not available. Last release happened 5 months ago; PR was merged this July...

Done, Sorry it took so long


Fix typo, formatting, and indicate rule key shouldn't contain spaces in wiki (pull request)

I fixed a typo, formatting, and indicated the rule key shouldn't contain spaces in the wiki page "Custom-Validation-Rules.md".
Please see my repository here: https://github.com/icnocop/specbind-wiki
Thank you! :)

I made the update in the docs, thanks!


JSON Format ellides empty repeated fields

Say I have this proto:
message Foo {
repeated string bars = 1;
}
In scala:
JSONFormat.toJsonString(Foo()) => "{}"
This is surprising. I expected "{ "bars": [] }", which is the behavior in Google's JavaPb -> JSON serialization.
Is it perhaps because of this match, where Nil is ignored?
https://github.com/trueaccord/ScalaPB/blob/master/scalapb-runtime/shared/src/main/scala/com/trueaccord/scalapb/GeneratedMessageCompanion.scala#L80

It looks like the default behavior in Google's Java PB->Json is to omit repeated fields: https://github.com/google/protobuf/blob/d58b92ae5169ba888e6b5ca91c0ec9814668fa2c/java/util/src/test/java/com/google/protobuf/util/JsonFormatTest.java#L1163
However, they have a setting called includeDefaultValueFields which makes it include those empty lists. It would be nice if we supported that.

Ah hah. You are right -- I've been using includeDefaultValueFields. Maybe I'll look into adding this..

I have some initial code already, would probably commit it in a few hours. Thanks though!

Wow! That's great
On Sun, Oct 30, 2016, 9:27 PM Nadav Samet<EMAIL_ADDRESS>wrote:

I have some initial code already, would probably commit it in a few hours.
Thanks though!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/trueaccord/ScalaPB/issues/183#issuecomment-257201166,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAdPGGYPGAXhE5YhfN-sl1d3inVWW2Uks5q5VIfgaJpZM4KkZPa
.

This is fixed in scalapb-json4s 0.1.4


python3 setup.py install failed

What version of gRPC and what language are you using?
tried master branch current and v1.42
What operating system (Linux, Windows,...) and version?
tried MacOS Montery v12.1 Inter  and CentOS x86_64
What runtime / compiler are you using (e.g. python version or version of gcc)

Python3.8.4 on MacOS Montery + Apple clang version 13.0.0
Centos + gcc (GCC) 11.1.0

What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.
try both on MacOS Montery and CentOS
git clone https://github.com/hanzhichao/grpc.git
cd grpc
python3 setup.py install

MacOS Montery and CentOS xcode-commandline is installed .
CentOS python36-devel is installed by yum

What did you expect to see?
successfully build complete
What did you see instead?
In MacOS it seem stacked when build clang ... /tmp/tmpmq13qzt4/a.c -o None/tmp/tmpmq13qzt4/a.o
...
creating None/tmp/tmpmq13qzt4
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -iwithsysroot/System/Library/Frameworks/System.framework/PrivateHeaders -iwithsysroot/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/Headers -arch arm64 -arch x86_64 -Werror=implicit-function-declaration -I/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/include/python3.8 -c /tmp/tmpmq13qzt4/a.c -o None/tmp/tmpmq13qzt4/a.o

Traceback (most recent call last):
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/unixccompiler.py", line 118, in _compile
    self.spawn(compiler_so + cc_args + [src, '-o', obj] +
  File "/Users/superhin/CLionProjects/grpc/src/python/grpcio/_spawn_patch.py", line 54, in _commandfile_spawn
    _classic_spawn(self, command)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/ccompiler.py", line 910, in spawn
    spawn(cmd, dry_run=self.dry_run)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/spawn.py", line 36, in spawn
    _spawn_posix(cmd, search_path, dry_run=dry_run)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/distutils/spawn.py", line 157, in _spawn_posix
    raise DistutilsExecError(
distutils.errors.DistutilsExecError: command 'clang' failed with exit status 1
...

In CentOS it stacked the same step gcc ... /tmp/tmpivcaghgg/a.c -o None/tmp/tmpivcaghgg/a.o
creating None/tmp/tmpivcaghgg
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -I/usr/include/python3.6m -c /tmp/tmpivcaghgg/a.c -o None/tmp/tmpivcaghgg/a.o

Make sure you include infor
python3_setup_install_fail_on_CentOS.txt
mation that can help us debug (full error message, exception listing, stack trace,
python3_steup_install_fail_on_MacOS.txt
logs).
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?

@lidizheng Appreciate for your replay. After update submodule, It works on CentOS.
Well on  MacOS Montery + Apple clang version 13.0.0, it failed the same place while clang ... /tmp/../a.c -o None/tmp/.../a.o
Refer to the bazel test result stdout output and the python3 setup.py install output for details
bazel_test_result.txt
python_setup_install_failed.txt

Bazel seems to be passing, if you take a look at the error log, it might contain why the tests are failing. Probably, due to no Python2 installation.
For the Python setup, I didn't find the failing line in your attachment. I wouldn't recommend to compile from source, if acceptable, you can use arch -x86_64 /bin/bash to simulate x64 arch and use gRPC Python binary wheel normally.

谢谢，您的邮件我已收到！


List storage adapters identifiers

Hi all,
Just bumped to this repo from here.
I'm wondering if I could also get the Storage Adapter Identifiers from each Host.
How to achieve this?

this helped me https://github.com/vmware/pyvmomi/issues/849

@CrashLaker thanks for sharing! could you add this functionality in a PR?


Roll Flutter Engine from 5a824e22deb2 to b735b76bf376 (9 revisions)

https://github.com/flutter/engine/compare/5a824e22deb2...b735b76bf376
2024-04-09<EMAIL_ADDRESS>Delete engine v1 android embedding (flutter/engine#51229)
2024-04-09<EMAIL_ADDRESS>better output from engine layer unit test failures (flutter/engine#51975)
2024-04-09<EMAIL_ADDRESS>Revert "Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (#51980)" (flutter/engine#51990)
2024-04-09<EMAIL_ADDRESS>[skwasm] Reify the SkPicture pointer as the right type. (flutter/engine#51991)
2024-04-09<EMAIL_ADDRESS>Reverts "Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (#51986)" (flutter/engine#51989)
2024-04-09<EMAIL_ADDRESS>Move the Dart SDK to //flutter/third_party/dart (flutter/engine#51917)
2024-04-09<EMAIL_ADDRESS>[macOS] Implement hit testing and handle platform view cursor changes (flutter/engine#43101)
2024-04-09<EMAIL_ADDRESS>Roll Dart SDK from 7a5e410f982e to db99af14c4bc (1 revision) (flutter/engine#51986)
2024-04-09<EMAIL_ADDRESS>Roll Dart SDK from 78174b41ab0f to 7a5e410f982e (1 revision) (flutter/engine#51980)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


web app display: Authentication Not Configured

after sync fork and rerun the action workflow: Deploy Python API and Deploy App, when access the web site, it display

I found only 3 tabs have this issue: Chat, Ask a question and PIB.

That's by design.  Introduced a way to secure the website (and selected features) as that was ask.   I will change the message to be more clear, but for those feature in current state you will have to deploy in your tenant and will provide instruction on how to configure that.

got it, thanks!

@akshata29 Thanks for the support. Is there anyway to disable the authentication feature above?

I followed this doc, it could allow AAD user to access the website:
https://learn.microsoft.com/en-us/azure/app-service/scenario-secure-app-authentication-app-service#3-configure-authentication-and-authorization

@akshata29 Thanks for the support. Is there anyway to disable the authentication feature above?
@cyberflying can I please ask if you found any work-around to diasble authentication ?

Thanks @cyberflying.
@Mshz2
If you want to disable the authentication by itself, the core code are in ChatGpt.tsx, OneShot.tsx and Pib.tsx.  For each of those in the useEffect method, comment following lines of code
if (window.location.hostname != "localhost") {
getUserInfoList();
setShowAuthMessage(true)
} else
setShowAuthMessage(false)


fix: compute dimensions of container correctly when text pasted on container

fixes https://github.com/excalidraw/excalidraw/issues/5834
https://user-images.githubusercontent.com/11256141/200546741-49962628-679b-4306-b51c-90192ebf712f.mov

Merging🚀
Thanks @zsviczian for helping with testing!

@ad1992 @zsviczian This indeed seems to fix #5834.  However, #5789 is not entirely fixed.  Further, I found another possible bug:
https://excalidraw.com/#room=98df69ce4bb92d1855c2,ZZbaq49yo-1aAs2hd_qYSQ


i think this saves a little bit of gas since you do one less mload

title:
its a bit less clear to read but its a little cheaper. basically instead of doing two mloads into x1 and x2, just read them like a hi-lo
its a pretty simple change i dont think it should break anything unless im misunderstanding the casts somewhere, tests passed at least.
and sorry for some reason my indenting has been weird but i think i fixed it

completely unrelated but

is there any reason that this is / 2 / pi instead of / 2PI
bc otherwise /2PI is much cheaper

Looks great, nice job! Two small comments before merging:

The 2 / PI should be changed to TWO_PI, good catch
Could add some more comments just explaining the logic, since like you said it's less clear but also because I love comments 😛

sure hold on

This looks awesome, thanks so much! 🙌
Can you enable the "allow edits by maintainers option" on the PR? Just want to force push a rebase which updates the gas snapshots, squashes the commits, and adds some comments around the sine table size

this?

Yep, thanks! You might have already had it enabled. It was rejecting when I tried git push https://github.com/elee1766/solidity-trigonometry.git HEAD -f, but it worked with git push https://github.com/elee1766/solidity-trigonometry.git HEAD:main -f


Provide help when encountering O (uppercase o) in version numbers

Describe the problem you are trying to solve
When typing version numbers for a crate, it can happen to write an uppercase o (O) instead of a zero 0. On French keyboards for example, the numbers require SHIFT, and the 0 key is near the o key. You can therefore type O and not remark it because in monospaced fonts it looks like a zero.
You can then appreciate a not-that-helpful error from Cargo, and remark your mistake either immediately or never:
error: failed to parse manifest at `path/to/Cargo.toml`

Caused by:
  failed to parse the version requirement `O.7.3` for dependency `rand`

Caused by:
  the given version requirement is invalid

Describe the solution you'd like
It would be easy to diagnose that the user typed an uppercase o, and suggest them to replace it with a zero. This is the kind of suggestions rustc has adopted to handle mistakes with the Greek question mark or the non-breaking space.
You may have an error like:
error: failed to parse manifest at `path/to/Cargo.toml`

Caused by:
  failed to parse the version requirement `O.7.3` for dependency `rand`

Caused by:
  the given version requirement is invalid

Help:
  the uppercase "o" `O` looks like a zero `0`, but it isn't

Working on it ;)

Created dtolnay/semver#307

The current error is
unexpected character 'O' while parsing major version number

@LeSeulArtichaut would that have worked for you?  If not, I'd recommend commenting in dtolnay/semver#307

Sounds good enough for me :+1:


add --sync-from-height command-line option

This causes lightwalletd to discard cached blocks at the given height
and beyond. This in turn causes it to re-fetch those blocks from zcashd.
It's similar to --redownload, except that option discards all blocks
(equivalent to --sync-from-height 0, but the existing --redownload is
retained for compatibility).
This is mostly intended for testing. It's sometimes useful to force the
node to (re)sync some recent blocks, but redownloading all of them takes
around an hour.

Force-pushed to rebase to v0.4.11


Allow configuration

Made the package configurable, allowing the user to only import certain files from the GTFS zip. updated to version 0.3

Thanks, Patrick. Looks good!


Update init.py

I wanted to fix the problem for when the SERPs generated were less than the num_results specified and then the code got stuck in an infinite loop. With this new code, that shouldn't happen anymore and during my tests the code was able to keep on working as intended.

Thank you for the PR and fixing this bug! Have some small changes but overall it looks good.

 I made a new commit fixing the problems you pointed out. Thank you for the useful code, take care!


Update CRDs: TriggerAuthentication and ClusterTriggerAuthentication

Signed-off-by: Shubham Kuchhal<EMAIL_ADDRESS>Update the CRDs according to kedacore/keda#1862
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

ref: #1826

Thank you!

you're welcome!


About S6 Selection Mechanism and Induction Heads Task

Thank you for developing this beautiful architecture; it has greatly inspired our research.
I am curious about how a Mamba block can be efficient in induction heads tests, which is somewhat related to the previously closed issue #31. I find it hard to believe that a single S6 block can be efficient in this context. Consider the following task structure:
A 3 B 2 C 8 D 4 ... (avalanche of tokens) ... A -> 3
The core idea is that the selection mechanism can regulate the integration window and almost disregard irrelevant inputs. However, in such tasks, a token like A becomes crucial only at the very end. Before the last token, model does not know which token is the task-relevant token, Therefore, a single S6 layer might struggle to control the $\Delta$ value, especially in a recurrent mode.
Yet, Mamba performs exceptionally well in induction head tasks, suggesting that a two-layer S6 structure might be effective. Could it be that the first S6 layer forms an intermediate nonlinear kernel, enabling the second layer to manage its $\Delta$ effectively, even when it's theoretically uncertain which token is significant until the task's conclusion?
Alternatively, does considering induction heads in a recurrent setting not make sense? Is $\Delta$ at $t = n$ not a function of an input at $t = n$, but a function of the entire input data?  If so, it suggests that in recurrent mode, Mamba possesses a "prophet" feature that informs the main SSM of the appropriate discretization window. Given this, would Mamba still excel in induction head tasks in recurrent mode?
Appreciate your consideration!

For sequences that are not too long, the model can commit to memory the mapping A -> 3, B -> 2, C -> 8 etc, then recall at the end.
Ofc for sequences that are super long and there's no pattern in the mapping, it would have more information than what the model can store in the states (depending on state dimension, number of layers) and it won't work.

I see. If I've understood correctly, the model might learn to ignore token pairs it has already seen, performing well as long as the task doesn't exceed the maximum information capacity of a single S6 block (depends on state size). Does this suggest that a single S6 block has the potential to handle induction head tasks of a reasonable size effectively?


c++17 cannot be activated.

Here's the CocConfig:
{
    "languageserver": {
        .
        .
        .,
        "coc-clangd": {
            "command": "clangd",
            "filetypes": ["c","cc","cpp","c++","objc","objcpp"],
            "clangd.arguments": ["-std=c++17"]
        }
    },
    "clangd.path": "~/.config/coc/extensions/coc-clangd-data/install/13.0.0/clangd_13.0.0/bin/clangd"
}

Here's tho result of :CocInfo:
## versions

vim version: NVIM v0.6.1
node version: v17.6.0
coc.nvim version: 0.0.80-03c9add7cd
coc.nvim directory: /Users/parsa/.config/nvim/plugged/coc.nvim
term: iTerm.app
platform: darwin

## Log of coc.nvim

2022-03-28T13:18:38.149 INFO (pid:5054) [services] - registered service "languageserver.hdlChecker"
2022-03-28T13:18:38.151 INFO (pid:5054) [services] - registered service "languageserver.coc-clangd"
2022-03-28T13:18:38.158 INFO (pid:5054) [services] - coc-clangd state change: stopped => starting
2022-03-28T13:18:38.239 INFO (pid:5054) [plugin] - coc.nvim 0.0.80-03c9add7cd initialized with node: v17.6.0 after 144ms
2022-03-28T13:18:38.246 INFO (pid:5054) [language-client-index] - Language server "languageserver.coc-clangd" started with 5055
2022-03-28T13:18:38.262 INFO (pid:5054) [services] - registered service "clangd"
2022-03-28T13:18:38.262 INFO (pid:5054) [services] - clangd state change: stopped => starting
2022-03-28T13:18:38.285 INFO (pid:5054) [language-client-index] - Language server "clangd" started with 5056
2022-03-28T13:18:38.312 INFO (pid:5054) [services] - coc-clangd state change: starting => running
2022-03-28T13:18:38.328 INFO (pid:5054) [services] - service languageserver.coc-clangd started
2022-03-28T13:18:38.335 INFO (pid:5054) [services] - clangd state change: starting => running
2022-03-28T13:18:38.337 INFO (pid:5054) [services] - service clangd started
2022-03-28T13:18:38.983 INFO (pid:5054) [attach] - receive notification: highlight []
2022-03-28T13:18:40.739 INFO (pid:5054) [attach] - receive notification: runCommand [ 'workspace.showOutput' ]
2022-03-28T13:18:42.559 WARN (pid:5054) [plugin] - Slow action "runCommand" cost 1819ms
2022-03-28T13:18:43.175 INFO (pid:5054) [attach] - receive notification: highlight []
2022-03-28T14:52:18.490 INFO (pid:5054) [attach] - receive notification: highlight []
2022-03-28T14:52:22.550 INFO (pid:5054) [attach] - receive notification: showInfo []

Here's the result of :CocCommand workspace.showOutput:
I[13:18:38.277] Apple clangd version 13.1.6 (clang-13<IP_ADDRESS>)
I[13:18:38.281] Features: mac+xpc
I[13:18:38.281] PID: 5055
I[13:18:38.281] Working directory: /tmp
I[13:18:38.281] argv[0]: /Library/Developer/CommandLineTools/usr/bin/clangd
I[13:18:38.281] Starting LSP over stdin/stdout
I[13:18:38.281] <-- initialize(0)
I[13:18:38.310] --> reply:initialize(0) 28 ms
I[13:18:38.329] <-- initialized
I[13:18:38.329] <-- textDocument/didOpen
I[13:18:38.329] Failed to find compilation database for /private/tmp/partition.cpp
I[13:18:38.330] ASTWorker building file /private/tmp/partition.cpp version 1 with command clangd fallback
[/private/tmp]
/Library/Developer/CommandLineTools/usr/bin/clang /private/tmp/partition.cpp -resource-dir=/Library/Developer/CommandLineTools/usr/lib/clang/13.1.6
I[13:18:39.393] --> workspace/semanticTokens/refresh(0)
I[13:18:39.399] <-- reply(0)
I[13:18:39.416] --> textDocument/publishDiagnostics

I still can't initialize a vector with initializer list:

you don't need to set coc-clangd section in your coc-settings.json, remove it from languageserver
set "clangd.fallbackFlags": [ "-std=c++17" ] https://github.com/clangd/coc-clangd/issues/20

Thanks.
More specification is needed in the Configurations section I think.


REST events API prices

This PR is for adding prices model to REST API.

Hold on, I've just noticed the copyright headers. Let me double check my IDE settings and get rid of them before merging.

Commit amended. All good now.


Keep documentation clear and up-to-date

Description
Developers often review the documentation for guidance on how to use the library, and since its first launch, we haven't reviewed it. So, we should review it and update all references and documentation that are out of date.
Expected Result

All references in the docs are still relevant.
All documentation is clear. Mainly, how each repo work and the contribution process.
All linked docs are up to date.

Some suggestions I've gathered from the community survey on the challenges section:

I would only improve the documentation a little bit. For example, in the section on creating a filter it talks about two different filters, which may cause confusion. I think it would be good to show an example of a filter implemented from start to finish, which contains all or at least most of the functionality offered by the library. additionally, the openedx-filters-samples repository has a great variety of examples, but it shows the filter creation part, but not (I think) the filter usage which is also important.

At the beginning it was understanding how the filters and events worked, also the difference that exists between each one. But in general it has good documentation to learn how to use it and create new ones.
There is a link to see live examples, https://github.com/openedx/openedx-filters/blob/main/docs/quickstarts/use-filters-to-change-enrollment.rst. This is good, but that repository is a bit out of date in references.

The first and only challenge I had was understanding how it works (that you need a point in edx-platform and create a pipeline), but then it was very useful.


Include special nodes in root ns duplicate interface detection

This is to extend #1514 which could not cope with interfaces defined in the special LinkNodes "mgmt-net" and "host".
Their endpoints weren't considerred in the duplication check implemented in #1514.

thanks @steiler


Return room avatar URLs in /publicRooms

LGTM

It might be nice if there was an "avatar_url" in the example response.


Check if author_email field contains author name (fix #77)

This test is a bit naive, and will yield a false positive for emails like:
"very.(),:;<>[]\".VERY.\"very@\\ <EMAIL_ADDRESS>which is a valid email address (though I'm not sure if pyproject.toml supports it).
Good enough, or a more robust approach needed?
Fix #77

(FYI, you need to include Fix #ISSUENUMBER in the OP, not the title or commit message, to trigger GitHub's linking and autoclose)

Thanks. Let me know if I should squash the commits.

It would also be good, and should be pretty streightforward, to include a test for this, and metadata generated from Setuptools' new pyproject.toml reader in general.
You could just create a new subdir of testdata named e.g. pep621, use ini2toml to convert the setup.cfg in the pep517 directory to pyproject.toml, and then add a new test, e.g. test_pep621, just like test_pep517 except passing pep621 as the directory name instead of pep517.

Thanks. Let me know if I should squash the commits.

Its up to @regebro ; he could also just squash-merge them if he wants.

Hmm, the test passes on my end. I'll see what I can do.

Here's the problem, of course: build.BuildBackendException: Backend 'flit_core.buildapi' is not available.
Let's see if the latest commit solves it.

Hmm, well it really shouldn't be needed, since as long as flit_core is specified in the to-be-built package's build-system.requires, the frontend should automatically download and install any required dependencies in the isolated build env. As such, I'm not sure if this issue is due to how the tests are being run, or will be an actual issue at runtime; I haven't had time to dig into that yet. But either way, if there isn't something obvious/straightforward going on, that's probably out of scope here, and this is otherwise LGTM. I'll try to take another look tomorrow, thanks.

I just ran into this, gentle bump :)

Sorry for loosing track of this!
Upon (finally) giving this "another look", build.ProjectBuilder, which we call .prepare on to get the metadata, just invokes the backend hook in the current environment rather than creating a new isolated one.
However, we should actually be using build.util.project_wheel_metadata(), which does exactly what we manually re-implemented here (builds the metadata with the project's build backend in a temp directory and an isolated env, automatically installing any build-time requirements there, and directly returns the metadata in a MESSAGE object). Pretty sure the only reason I didn't suggest originally was because I was confused by the docs and thought it returned only the WHEEL metadata, not the METADATA metadata (but in fact it returns the latter, which is what we actually want).
In any case, instead of adding flit to extras require (i.e. drop the last commit), you can instead make the following change in pyroma/projectdata.py
diff --git a/pyroma/projectdata.py b/pyroma/projectdata.py
index 4851c65..2775bb9 100644
--- a/pyroma/projectdata.py
+++ b/pyroma/projectdata.py
@@ -1,5 +1,5 @@
 # Extracts information from a project that has a distutils setup.py file.
-import build
+import build.util
 import email
 import email.policy
 import logging
@@ -23,10 +23,7 @@ METADATA_MAP = {

 def get_build_data(path):
-    with tempfile.TemporaryDirectory() as tempdir:
-        metadata_dir = build.ProjectBuilder(str(path)).prepare("wheel", tempdir)
-        with open(pathlib.Path(metadata_dir) / "METADATA", "rb") as metadata_file:
-            metadata = email.message_from_binary_file(metadata_file, policy=email.policy.compat32)
+    metadata = build.util.project_wheel_metadata(path, isolated=True)

     if "Description" not in metadata.keys():
         # Having the description as a payload tends to add two newlines, we clean that up here:

That should get everything working for the tests, and also fix the genuine pyroma issue that it still requires the project's build backend to be installed in the local env (which isn't generally true these days), which this test will also validate.
On another note, it seems I've discovered a new form of MISSINGNO...that's also a legendary Pokemon.

Thanks!

FYI, the patch in my above comment both gets the test working without actually needing to have the particular project's backend (flit) installed in the user's env, but more importantly improves several issues with the original approach that I'd suggested for reading project metadata, such that it actually works properly with any PEP 517 build backend, and is simpler, more efficient and more reliable.
I've opened a followup PR, #92 , to implement a refined version of that (which first tries a non-isolated env for efficiency and backward compat, and then falls back to a an isolated env if that fails).


Changes to support Pioneer receiver

Changes to support Pioneer VSX 831 receivers, etc.

https://github.com/tillbaks/node-eiscp/pull/19


Create a timeline

Add a list of all my activities, achievements, work experience. Add as much info as I can remember. As long as I don't have working experience, I should tell about my pet-projects.

Adding my pet-projects info and adjusting styles of experience section

Adding educational information.

Adding languages.

Fixing typos and minor style issues.

Done


Buttons break on 11th click in Flutter Web

Steps to Reproduce

Create a new Flutter web project
Add a FlatButton, MaterialButton or RaisedButton
Implement their onPressed() methods
On the 11th time the function is called, the function / button breaks

Here is an example file: https://gist.github.com/laoal11/64d0f9091f2c75456d1e2ba9708c934f

Target Platform:Web
Target OS Windows 10/Google Chrome (78.0.3904.108):
Logs

The Google Chrome console log (Flutter does not throw an error):
Uncaught TypeError: Cannot read property 'Symbol(dartx.remove)' of null
at _engine.DesktopSemanticsEnabler.new.tryEnableSemantics (semantics_helper.dart:124)
at _engine.SemanticsHelper.new.shouldEnableSemantics (semantics_helper.dart:43)
at _engine.EngineSemanticsOwner.__.receiveGlobalEvent (semantics.dart:1349)
at HTMLElement. (pointer_binding.dart:172)

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, v1.12.16-pre.19, on Microsoft Windows [Version 10.0.17763.864], locale de-DE)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Chrome - develop for the web
[!] Android Studio (version 3.5)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.40.2)
[√] Connected device (2 available)
Once the error was thrown, the application is frozen and can not be used any further.

same here

For me, this was fixed by the latest Flutter update

for me this is still relevant.
I have a tabbar and none of the buttons mentioned above. On the ninth click switching between tabs the application hangs. In the debug mode I get the same error. Moreover this error starts repeating endlessly whenever I move my mouse across the page.
The crash can be seen here https://album-tracker-d87a6.firebaseapp.com/#/ (switch between tabs n the top for several seconds and the page stops responding)
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, v1.12.16, on Microsoft Windows [Version 10.0.18362.476], locale uk-UA)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[√] Chrome - develop for the web
[√] Android Studio (version 3.5)
[√] VS Code (version 1.40.2)
[√] Connected device (2 available)
• No issues found!

this still occures in current latest dev: 1.12.16. I have created new ticket linked to this one to reopen then issue: #46069


Remove doc about function that is not being only a proxy

For insert_all/2 it is creating a span: https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/8af382e26a8bbf306662bc745f1c000ad1323cc5/instrumentation/opentelemetry_oban/lib/opentelemetry_oban.ex#L107

Ok. There are several grammatical errors. Can you please fix those?

Ok. There are several grammatical errors. Can you please fix those?

Can you point some errors? I did not find it in the README.md

No worries, I got it :)


[Bug Report]: Tiny images on PDF export

Describe the Bug
Exporting to PDF renders the images tiny.
Viewing and HTML works just fine
Steps to Reproduce

Create page, add image trough upload dialog.
Save page and view, all is fine
Export page to HTML, all is fine
Export to PDF, images are tiny

Expected Behaviour
Images to be the same as HTML view / export
Screenshots or Additional Context
Here is a screen snippet of a correct view / html export:

And here is a snippet of a PDF export woth the same image, its tiny:

Exact BookStack Version
v21.12
PHP Version
No response
Hosting Environment
I am using the https://docs.linuxserver.io/images/docker-bookstack docker container.

This should be fixed in v21.12.1 (duplicate of #3120)

thanks for the info, i tried searching for a similar issue but didnt see that one.


[VS Code] Opening source-controlled changes: Request sourceControl.getDiffForResource failed with message: Cannot read property 'path' of undefined

%0A%0A%23%23 Error:%0AOpening source-controlled changes: Request sourceControl.getDiffForResource failed with message: Cannot read property 'path' of undefined%0A%0A%23%23 Steps to Reproduce:%0A1.%0A2.%0A%0A||Version Data|%0A|-:|:-|%0A|**extensionName**|VSLS|%0A|**extensionVersion**|1.0.311|%0A|**protocolVersion**|2.2|%0A|**applicationName**|VSCode|%0A|**applicationVersion**|1.34.0|%0A|**platformName**|MacOS|%0A|**platformVersion**|18.6.0|

Upload liveshare logs, you can get them by running "Liveshare: Export logs" from vscode command palette.

I think I know where the bug may be lurking. We'll ship the fix in the upcoming or the next release.

The fix will release on week of 06/10.


fix(toml): Warn, rather than fail publish, if a target is excluded

What does this PR try to resolve?
We have a couple of problems with publishing

Inconsistent errors: if a target that package doesn't verify is missing path, it will error, while one with path won't, see #13456
Users may want to exclude targets and their choices are

Go ahead and include them.  I originally excluded my examples before doc-scraping was a think.  The problem was if I had to set required-features, I then could no longer exclude them
Muck with Cargo.toml during publish and pass --allow-dirty

This fixes both by auto-stripping targets on publish.  We will warn the user that we did so.
This is a mostly-one-way door on behavior because we are turning an error case into a warning.
For the most part, I think this is the right thing to do.
My biggest regret is that the warning is only during package/publish as it will be too late to act on it and people who want to know will want to know when the problem is introduced.
The error is also very late in the process but at least its before a non-reversible action has been taken.
Dry-run and yank help.
By enumerating all targets in Cargo.toml, it makes it so rust-lang/crates.io#5882 and rust-lang/crates.io#814 can be implemented without any other filesystem interactions.
Fixes #13456
How should we test and review this PR?
Tests are added in the first commit and you can then follow the commits to see how the test output evolved.
The biggest risk factors for this change are

If the target-stripping logic mis-identifies a path as excluded because of innocuous path differences (e.g. case)
Setting a minimum MSRV for published packages: auto* were added in 1.27 (#5335) but were insta-stable.  autobins = false did nothing until 1.32 (#6329).  I have not checked to see how this behaves pre-1.32  or pre-1.27.  Since my memory of that error is vague, I believe it will either do a redundant discovery or it will implicitly skip discovery

Resolved risks

#13729 ensured our generated target paths don't have \ in them
#13729 ensures the paths are normalize so the list of packaged paths

For case-insensitive filesystems, I added tests to show the original behavior (works locally but will fail when depended on from a case-sensitive filesystem) and tracked how that changed with this PR (on publish warn that those targets are stripped).  We could try to normalize the case but it will also follow symlinks and is likely indicative of larger casing problems that the user had.  Weighing how broken things are now , it didn't seem changing behavior on this would be too big of a deal.
We should do a Call for Testing when this hits nightly to have people to cargo package and look for targets exclusion warnings that don't make sense.
Additional information
This builds on #13701 and the work before it.
Note: this won't make much of a difference in performance because we unconditionally walk the file system just in case autodiscover != Some(false) or a target is missing a path.  A follow up PR will focus on the performance side of this.

Blocked on #13701.  Posting now to get Windows testing.

@ChrisDenton I'd be curious if you have any thoughts on the case-preserving change in this PR.
Existing behavior (shown in the first commit): we can detect SrC/MaIn.rs as src/main.rs and publish it.  Windows consumers will be able to use the package.  Linux consumers of it won;'t.
With us tracking targets in the published package, src/main.rs (what cargo sees) and SrC/MaIn.rs (what the filesystem sees) wouldn't match and we'd strip the target from the published manifest, preventing anyone from using it.  The publisher will get a warning.
In the last commit, I use canonicalize to try to read the case from the filesystem and preserve that through Cargo, allowing the targets to be included and Linux users can now consume them.
This is shown in the commit history of the PR with the changes to the package::normalize_case test.
The one case not handled is if the user sets path = "src/main.rs" but the file is SrC/MaIn.rs then we will still strip the target.

Hmm... I would just quickly note the case sensitivity is not necessarily just a cross-platform concern. E.g. Windows can have case-sensitive directories. So anywhere there is a mismatch between expected and actual case means that it's non-portable even possibly within the same system. This does make erroring on detected case mismatches more appealing to me as I'd personally want to be made very aware of the situation before I publish, especially if Cargo is unable to handle all such cases automatically. However, I can also see how that might be frustrating for other users so I don't feel that strongly about it. "It just works" is always appealing.
On a technical level I would worry a bit about canonical paths not necessarily matching the packaged directory structure, due to symlinks or something. Admittedly I'm uncertain if this would be a problem in practice or not.

@ChrisDenton thanks for the input!  I've taken out that commit for now and instead going with the approach of it needing a strong justification to go in.  I want to do a call-for-testing on this when it hits nightly and will particularly call out publishing from Windows.

Starting the conversation on the behavior changes in parallel to the review of the implementation
This change snapshots implicit build targets into the published package, making them explicit.
Immediate benefits

Makes implicit targets, explicit-without-path targets, and explicit-with-path targets consistent for error reporting (#13456) and for intentionally excluding targets (not needing --allow-dirty (as discussed in #13695)
Disallows adding build.rs to vendored source (#5806)
As a crate maintainer, makes it easier to inspect what the published result is

This unblocks

Performance optimizations.  This allows us to shift all of the burden onto TOML parsing which would likely be easier to optimize
crates.io specializing their rendering on bin vs lib (rust-lang/crates.io#5882, rust-lang/crates.io#814)

Behavior changes that I'm looking for consensus on:

Switching some publish errors to warnings

Excluded implicit target

Before: silently ignored
After: silently ignored

Excluded explicit target without a path

Before: error since a path can't be discovered
After: silently ignored

Excluded explicit target with a path

Before: error if its a bin/lib, silently ignored otherwise
After: silently ignored

Case mismatches

Situations:

Implicit file target with alt case of (e.g. src/Main.rs)
Implicit target search with alt case of (e.g. Src/Bin/)
Explicit target without path whose name has different case than actual file
Explicit target whose path has different case than the actual file

Before:

Publish worked
Package would work on case-insensitive filesystems
Package would fail on case-sensitive filesystems

After:

Ignored with a warning during publish

Justification:

This is a portability hazard, even within the same machine
We've not seen people organically bring up the problem that their packages don't work on other platforms.  The main organic case situation was cargo.toml and that mostly came about because windows users didn't think to add the required case.  This is the opposite.
These case mismatches could be indicative of more fundamental case problems and this could have a long tail of holes to patch

Alternative: normalize the case

One option is to use canonicalize but that will also resolve symlinks
We could enumerate directories and find a best match.  This avoids "how is case-insensitivity implemented" because the cases we care about are ASCII.  However, we don't really know whether the filesystem is case-sensitive or not

@rfcbot fcp merge

:umbrella: The latest upstream changes (presumably #13804) made this pull request unmergeable. Please resolve the merge conflicts.

@bors r+
Thanks!

:pushpin: Commit 8cc2f391ba4c72cee9129342e47b1ecb7ba959d3 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 8cc2f391ba4c72cee9129342e47b1ecb7ba959d3 with merge ba6fb405284df654362275405175f3fac2b79dbf...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing ba6fb405284df654362275405175f3fac2b79dbf to master...

How is this related to #5806?

If I understand correctly cargo vendor will vendor "published" Cargo.toml files.  With #5806, you could drop a build.rs and it would be automatically picked up.  After this change, it will be ignored and the only way to add a build.rs is to hand-edit the Cargo.toml which will result in a checksum error.

So, if I understand correctly, this only "fixes" #5806 for crates published to crates.io, but e.g. crates vendored from a git repo, will still have the problem.

From my understanding cargo vendor effectively runs cargo package on every dependency, regardless of the source.  This change affects cargo package.
I tried this out locally by running cargo vendor on https://github.com/crate-ci/cargo-release/ which has git dev-dependencies.  The vendored versions of those git dev-dependencies had the standard "this is from cargo package" boilerplate at the top and they had all of the auto* fields set to false from this change.
So I believe this fixes it for git as well.  Feel free to test it when this hits nightly and let us know if it works or not!

I tested 1.80.0-nightly (c987ad527 2024-05-01), and vendoring indeed adds the auto* and build fields (and more).

FYI: This PR might have introduced a "warning" regression: https://github.com/rust-lang/cargo/issues/14290.


Where Param Converts Integer to String

When using where, say for math, the data for the filtered column is converted to a string.

Are you sure about this? I'm not able to reproduce this with a minimal example. Can you create a reproduceable example?
If you inspect the resulting dataframe from this, header1 and header2 are both still integers.
read:
  - test:
      rows: 5
      values:
        header1: 1

wrangles:
  - copy:
      input: header1
      output: header2
      where: header1 = 1

Interestingly, this actually makes it a float:
Still a number at least, but would be better if it preserved the data type
read:
  - test:
      rows: 100
      values:
        header1: <int>

wrangles:
  - copy:
      input: header1
      output: header2
      where: header1 > 50

Yes, I recreated like so:
wrangles:
  - math:
      input: (Column2 - Column1)/Column1
      output: Column3
      where: NULLIF(Column1, '') IS NOT NULL

data = pd.DataFrame({
    'Column1': [65, 72, '', 92, 87, 79],
    'Column2': [2, 5, 4, 2, 1, 6]
})

If you put a break point on math, you can see that the column that was filtered on is now made up of strings.

Interesting. It's actually nothing to do with being filtered on that per se. It's the presence of the '' in the data.
To apply the where we convert it to sqlite and back to be able to use the SQL syntax. However, SQL has fairly strict data type enforcement and it's applied to the whole column. By including the empty string, it can't store it as a numeric column so pandas instead has it as an object. Seems like that's converted to a string.
That's a tricky little bug. We do already have some logic to deal with objects to JSON and back. Perhaps we can also handle this case somehow.


locked mock failure not reported to jtreg logs

the jtreg logs dont seem to be logging the failure with locked chroot (mock), this results in seemingly passing tests whereas in reality the test didnt even properly run due to the failure
How to reproduce:
chroot should get locked for any old fedora version in init arguments in utils/mock/mock_executor.py, starting old fedoras start at "f31" currently
results:
see jtregLogs logs of binaries test or any other testscase, that reports locked chroot into jsf.log and see, that there is no mention about the locked chroot in jtregLogs whatsoever
expected results:
failure about locked chroot recorded in jtregLogs in the relevant file (e.g. BinariesTest_*.jtr.xml for binaries test)

https://github.com/andrlos/jdk-rpms-specification-framework/pull/5/commits/e16efc976bd51054bae45a13aff7530706e56318


variable name typo

Thanks for making this parser !
https://github.com/MaJerle/gps-nmea-parser/blob/develop/gps_nmea_parser/src/include/gps/gps.h#L186
gps_float_t coarse;                         /*!< Ground coarse */
should be
gps_float_t course;                         /*!< Ground course */

You are right. Fixed on develop branch.


Add graphql using Apollo 2.0

Remember to yarn.
There is an example in pages/test-gql.js
Test endpoint: http://localhost:3000/test-graphql

There is a withData HOC which you wanna import in root page where you want to use graphql as it does the ssr.
Change the URL in initApollo.js

Great job @pantharshit00 ! Thank you!


add rpmdev-bumpspec logic

Description
Right now, the user has to implement release bumping, which can be quite complicated. It would be nice if we could copy logic from rpmdev-bumpspec. That would honor autorelease if used. And simply bump up something by one if needed.
Benefit
User does not need to study what can be in release and what should be bumped. Logic in one place.The user does not need to study what can be in the release and what should be bumped.
Importance
I have a workaround right now.
Workaround

[X] There is an existing workaround that can be used until this feature is implemented.

Participation

[ ] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Note for myself:
I use this code:
def increment_last_number(input_string):
    # Split the input string into parts based on the dot
    parts = input_string.split('.')

    index = -1
    success = False
    while not success:
        try:
            # Convert the last part to an integer, increment it by 1, and convert it back to string
            parts[index] = str(int(parts[index]) + 1)
            success = True
        except ValueError:
            index -= 1

    # Join the parts back into a single string with dots
    return '.'.join(parts)

if not specfile.has_autorelease:
    specfile.release = str(increment_last_number(specfile.expanded_release))

But this failed for
Release:       30%{?alphatag:.}%{?alphatag}%{?dist}

resulting with
Release:       31%{?dist}

Note for myself, the last issue can be fixed by
specfile.release = str(increment_last_number(specfile.release))


fix: mask access token when login

What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Mask access token like password during login
$ supabase login
You can generate an access token from https://app.supabase.com/account/tokens
Enter your access token:
Error: Invalid access token format. Must be like `sbp_0102...1920`.
Try rerunning the command with --debug to troubleshoot the error.
exit status 1

Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

77 of 87 (88.51%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 60.998%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/functions.go
0
1
0.0%

cmd/login.go
2
3
66.67%

internal/link/link.go
0
2
0.0%

internal/utils/credentials/input.go
10
16
62.5%

Files with Coverage Reduction
New Missed Lines
%

cmd/login.go
2
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
4243

Relevant Lines:
6956

💛  - Coveralls


OTBR: Amount of RAM on Raspberry PI

Hi,
When using a Raspberry Pi for the OpenThread Border Router (ex: a Raspberry Pi 4 Model B), is there a minimal amount of RAM?
This board exists with 4 or 8 GB of memory so I'm wondering if 4GB is enough.
Thank you

There is no such requirement, you are free to choose 4 GB to save money :)

Good. Thank you


Add smart app banner

https://developer.apple.com/documentation/webkit/promoting_apps_with_smart_app_banners
In the future, also whatever equivalent for android.

Added in 81f92e91ae8300013d7c48a54009b72299d67e67. Still want to make sure it's visible in general.


Why MaxPool3d instead of MaxPool2d?

Because MaxPool2d can't pooling in channel dimension.

What's the benefit of pooling in channel dimension?@sirius-ai

its LPRNet architecture network, maybe less paramerers and cost less compute power.


Dataverse marketplace and modularity

This is a follow up from last weeks front-end meeting where I presented a small example of how plugins could be integrated within an SPA. You can re-watch it on DataverseTV and inspect the code here.
According to @GPortas the addition of a marketplace and plugin-support is more of a long-term goal than something that should be implemented in this phase. Hence, this issue is set as a reminder and collection of ideas how we can conceptualize this even further.
I am happy to further investigate this and it would be awesome to collect ideas within this issue. Here are my previous thoughts condensed into some bullet points:

Marketplace for community and Dataverse plugins (+ metadatablocks?)
Plugins could modify the Dataverse UI and add extra buttons/tabs (Small utilities such as an ORCID Finder)
Plugins could transfer data to another web-app (such as a Review Tool)
Dedicated Plugin-Registry from which users can choose and transfer to the "Plugin-Store"-State

Related:

https://github.com/IQSS/dataverse-pm/issues/278


Added page-up/page-down

Changed the named keys to do the named things
Added basic keymap -- should this be generated from the code somehow?

Does it work?

I thought I'd gotten it working. It may need more work than I thought. :slightly_frowning_face:

Hey, I was just asking, not saying it doesn't work. I didn't test yet, but was going to merge anyway if you answered "yes".

It does work.

Thanks!

It's me that should be thanking you!

Well, the patch had functionality and some docs, but no tests, so I appreciate your forbearance. It looks like upstream has tests, which I'm thinking of ripping off^W^Wusing.

This is just a quick hack I did because originally jid advertised itself as a jq tool, but actually it had nothing to do with it.
I'm planning on doing a full rewrite with decent interface, but haven't found time for it yet.

There's nothing quite so permanent in computing as a quick hack ;)
Do you have a sketch of what you have in mind for the next version?

Something using https://github.com/jroimartin/gocui which seems very very simple and fast.
And https://github.com/threatgrid/jq-go, if it works.


NIV & IV respiratory support badges are malfunctioning in patient list page

Describe the bug
When we readmit a patient without consultation in a facility, and if the patient has respiratory support of IV or NIV in his/her last consultation, the respiratory support-related badge will be shown on the patient list page along with the no consultation badge
To Reproduce
Steps to reproduce the behavior:

Readmit a patient without consultation who has previous consultation of respiratory support NIV or IV
go to the patient tab and search for that patient
See error

Expected behavior
the respiratory support badge in the patient list page should be showing the badge only if the patient is having an active consultation
Screenshots

mind assigning this to me? @nihal467
On a side note, how do I add a respiratory support for a new consultation? Where is that located in log update?

click on the patient tab in the sidebar
click on any patient card with live consultation
once you are on the consultation , click on the log update button
on the log update page, select the round type "Detailed Update" and click save
now, on the critical care, click on the respiratory support section, and click on any oxygen support
save the form now


ADD CONTACT  SECTION

name: Pull request
about: Maintain this format while making a PR
title: "Add Contact Section to README"
labels: "documentation"
assignees: "alo7lika"
Description
Please include a summary of the changes and the related issue(s) if applicable. Explain the motivation behind these changes and what benefits they bring to the project.
ADD CONTACT SECTION on README file: This change introduces a contact section in the README, allowing users and contributors to reach out for inquiries or suggestions. This enhances communication within the community and improves user engagement.
Fixes #38  (issue)
Type of Change
Please delete options that are not relevant:

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update (changes to documentation only)
[ ] Chore (cleanup or minor improvement that does not change functionality)

Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings or errors.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

Screenshots (if applicable)

Additional Information
Please add any other relevant information or context for the reviewers.
This addition helps improve community involvement by providing clear contact details for project inquiries. The new contact section will be visible in the README, ensuring it's easily accessible for everyone interested in the project.

@Git21221  the task has been completed.

@alo7lika looks good but can you make this PR to dev branch? for more info see guide. main branch has some pipeline to NPM and other services.

@alo7lika any update on PR?

@alo7lika it's fine, I got it.


[ENH] - Handle the case when Traefik is already installed

Feature description
I would like to be able to install Nebari on a stock k3s cluster. Unfortunately, by default, it has Traefik already installed, and it seems your terraform doesn't like that. The documentation doesn't seem to allow for this possibility or how to bypass it.
As a temporary workaround I remove the duplicate CRDs, but it would be better if I could avoid having to use the terraform resources that are duplicate in this case.
[terraform]: ╷
[terraform]: │ Error: namespaces "default" already exists
[terraform]: │
[terraform]: │   with module.kubernetes-initialization.kubernetes_namespace.main,
[terraform]: │   on modules/initialization/main.tf line 1, in resource "kubernetes_namespace" "main":
[terraform]: │    1: resource "kubernetes_namespace" "main" {
[terraform]: │
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.ingress_route,
[terraform]: │   on modules/traefik_crds/main.tf line 1, in resource "kubernetes_manifest" "ingress_route":
[terraform]: │    1: resource "kubernetes_manifest" "ingress_route" {
[terraform]: │
[terraform]: │ resource "/ingressroutes.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.ingress_route_tcp,
[terraform]: │   on modules/traefik_crds/main.tf line 200, in resource "kubernetes_manifest" "ingress_route_tcp":
[terraform]: │  200: resource "kubernetes_manifest" "ingress_route_tcp" {
[terraform]: │
[terraform]: │ resource "/ingressroutetcps.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.ingress_route_udp,
[terraform]: │   on modules/traefik_crds/main.tf line 348, in resource "kubernetes_manifest" "ingress_route_udp":
[terraform]: │  348: resource "kubernetes_manifest" "ingress_route_udp" {
[terraform]: │
[terraform]: │ resource "/ingressrouteudps.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.middleware,
[terraform]: │   on modules/traefik_crds/main.tf line 423, in resource "kubernetes_manifest" "middleware":
[terraform]: │  423: resource "kubernetes_manifest" "middleware" {
[terraform]: │
[terraform]: │ resource "/middlewares.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.middlewaretcp,
[terraform]: │   on modules/traefik_crds/main.tf line 1073, in resource "kubernetes_manifest" "middlewaretcp":
[terraform]: │ 1073: resource "kubernetes_manifest" "middlewaretcp" {
[terraform]: │
[terraform]: │ resource "/middlewaretcps.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.serverstransports,
[terraform]: │   on modules/traefik_crds/main.tf line 1132, in resource "kubernetes_manifest" "serverstransports":
[terraform]: │ 1132: resource "kubernetes_manifest" "serverstransports" {
[terraform]: │
[terraform]: │ resource "/serverstransports.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.tls_option,
[terraform]: │   on modules/traefik_crds/main.tf line 1209, in resource "kubernetes_manifest" "tls_option":
[terraform]: │ 1209: resource "kubernetes_manifest" "tls_option" {
[terraform]: │
[terraform]: │ resource "/tlsoptions.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.tls_stores,
[terraform]: │   on modules/traefik_crds/main.tf line 1287, in resource "kubernetes_manifest" "tls_stores":
[terraform]: │ 1287: resource "kubernetes_manifest" "tls_stores" {
[terraform]: │
[terraform]: │ resource "/tlsstores.traefik.containo.us" already exists
[terraform]: ╵
[terraform]: ╷
[terraform]: │ Error: Cannot create resource that already exists
[terraform]: │
[terraform]: │   with module.traefik-crds.kubernetes_manifest.traefik_service,
[terraform]: │   on modules/traefik_crds/main.tf line 1334, in resource "kubernetes_manifest" "traefik_service":
[terraform]: │ 1334: resource "kubernetes_manifest" "traefik_service" {
[terraform]: │
[terraform]: │ resource "/traefikservices.traefik.containo.us" already exists
[terraform]: ╵

Value and/or benefit
It seems to me that it would be quite common to want to deploy Nebari onto cluster with existing ingress definitions.
Anything else?
No response

Hi @mcg1969, you are correct, we don't currently support this feature. I have tagged it as an enhancement request. Thanks for submitting this, I think it would be a good addition, but we will need to discuss it with the rest of the team.

I did indeed assume it was an enhancement request!

We discussed on the community call today, and the community seems open to this, but it's not currently prioritized by anyone.  Is this something you'd be interested in working on @mcg1969?

I won't be able to do a lot of development, I don't think. But one of my team members might be doing some investigation to "post-process" the terraform output at some point. If we get there we can move it upstream. We certainly wouldn't keep it to ourselves

In the meanwhile I have good workarounds. The Terraform-installed ingress created by nebari is compatible with other applications that are running on our k3s instances—it's really just the stock ingress with some added ports exposed.


improves ComprehensiveIT and adjust sunny ITs

This change adds a new security test to Comprehensive IT and moves some test from ReadWriteIT into comprehensive IT.  Each test in ReadWriteIT spins up a mini cluster, which takes a lot of time for really simple test.  Also remove the sunny tag from shell ITs as ComprehensiveIT now covers most of what thost test were covering, but using public API instead of shell.

Running all of the sunny ITs with this changes looks like the following.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.accumulo.test.rpc.ThriftBehaviorIT
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.544 s -- in org.apache.accumulo.test.rpc.ThriftBehaviorIT
[INFO] Running org.apache.accumulo.test.InMemoryMapIT
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.911 s -- in org.apache.accumulo.test.InMemoryMapIT
[INFO] Running org.apache.accumulo.test.functional.NativeMapIT
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.737 s -- in org.apache.accumulo.test.functional.NativeMapIT
[INFO] Running org.apache.accumulo.test.functional.ReadWriteIT
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.15 s -- in org.apache.accumulo.test.functional.ReadWriteIT
[INFO] Running org.apache.accumulo.test.functional.WALSunnyDayIT
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 89.27 s -- in org.apache.accumulo.test.functional.WALSunnyDayIT
[INFO] Running org.apache.accumulo.test.ComprehensiveIT
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.19 s -- in org.apache.accumulo.test.ComprehensiveIT
[INFO] Running org.apache.accumulo.test.start.KeywordStartIT
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.436 s -- in org.apache.accumulo.test.start.KeywordStartIT
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0


Add Bookmark support for mango json queries

This adds a bookmark that is sent with each query and can be used to
continue a query from a specific key. This will allow users to paginate
mango queries.
Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[ ] Documentation reflects the changes;

testing a basic case where no results are returned, I get a response:
{"warning":"no matching index found, create an index to optimize query time",
"docs":[
],
"bookmark": "nil"}

However, passing "nil" back as a bookmark returns an error:
$ curl 'http://<IP_ADDRESS>:15984/test/_find' -H 'Content-Type:application/json' -d '{"selector":{"id":"willnotmatch"},"bookmark":"nil"}'
{"error":"invalid_bookmark","reason":"Invalid bookmark value: \"nil\""}

suggest adding a pagination test where each document emits the same value into the index to ensure progress is made using startkey_docid.

Thanks @willholley I've fixed the issue and added another test.

@tonysun83 thanks for the review. I've make some fixes based on your feedback

+1 after that fixing that weird end of line issue

This adds a bookmark that is sent with each query and can be used to
continue a query from a specific key. This will allow users to paginate
mango queries.

How exactly is bookmark implmented? [I have no knowledge of Erlang, but have written a couchdb client in dart]. Is it base64 enocded of json of last index[or doc] sent to user ?

@anuragvohraec the code is here https://github.com/apache/couchdb/blob/master/src/mango/src/mango_json_bookmark.erl
We basically take the startkey and startkey_docid and convert to erlang binary and then to base64


Find libraries with SONAME

find_libpython does not find libpython currently if only a shared object with a SONAME exists, i.e. only "libpython3.8.so.1.0", but no "libpython3.8.so". That's the case in RHEL8 with the Red Hat python38 package installed, so a rather common scenario.
Here's how it looks on my RHEL8 machine:
$ ls -l /usr/lib64/libpython3*
lrwxrwxrwx. 1 root root      20 14. Jun 18:56 /usr/lib64/libpython3.6m.so -> libpython3.6m.so.1.0
-rwxr-xr-x. 1 root root 3285672 14. Jun 18:57 /usr/lib64/libpython3.6m.so.1.0
-rwxr-xr-x. 1 root root 3714264 16. Sep 2021  /usr/lib64/libpython3.8.so.1.0
-rwxr-xr-x. 1 root root    6888 14. Jun 18:57 /usr/lib64/libpython3.so

See also https://github.com/cocotb/cocotb/issues/3097

Looking at the code I guess we could either attach the soname to the suffix and see if that file exists (I don't think anything other than "1.0" exists), or use the config var INSTSONAME. I wonder why that wasn't used before? @ktbarrett you have the best overview on the options you tried and the mess surrounding it, so maybe you could have a look?
As data point, here's what I get on RHEL8, which in both cases is exactly the right library.
python3.8 -c 'from distutils.sysconfig import get_config_var; print("%s/%s" % (get_config_var("LIBDIR"), get_config_var("INSTSONAME")))'
/usr/lib64/libpython3.8.so.1.0

python3.6 -c 'from distutils.sysconfig import get_config_var; print("%s/%s" % (get_config_var("LIBDIR"), get_config_var("INSTSONAME")))'
/usr/lib64/libpython3.6m.so.1.0

Looks like something may have changed recently? https://github.com/ktbarrett/find_libpython/actions was passing RHEL8, then started failing. And the action stopped working for some reason...
Seems like a good way to reliably find the library on some systems, not sure why it wasn't used in the original code. Could you open a PR to add it somewhere?

Looks like something may have changed recently? ktbarrett/find_libpython/actions was passing RHEL8, then started failing. And the action stopped working for some reason...

The action only tested the system Python (3.6), not the additional Python versions available on RHEL7 and 8 throgh SCLs (https://github.com/ktbarrett/find_libpython/blob/master/.github/workflows/tests.yml#L118). Python 3.6 as shipped with RHEL8 has the symlinks from .so.1.0 -> .so in place, only the AppStream versions don't.


Tracer ark plugin

Add tracer-sofa-boot-plugin

Pull Request Test Coverage Report for Build 104

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 49.331%

Totals

Change from base Build 103:
0.03%

Covered Lines:
1658

Relevant Lines:
3361

💛  - Coveralls


Activity palette not visible on Tank Operation activity

The activity palette that should open when the user click on the activity icon in the toolbar is never visible on Tank Operation activity.

So it's not possible to change the name of the instance.

Possibly #377 solves this.

I think this issue is solved as I am not able to reproduce this problem in my system.


[v2] Index support for nested Astro class

Consider the following:
Child = Astro.Class.Create({
  name: 'Child',
  fields: {
    name: {type: String}
  }
});

Parent = Astro.Class.Create({
  name: 'Parent',
  collection: new Meteor.Collection('parents'),
  child: {type: Child, default() { return new Child(); }}
});

How can one setup an index on Child's name field, provided it has no collection attached to it.

Do you think it would be possible to have astro work it out, if it's done this way:
Child = Astro.Class.Create({
  name: 'Child',
  fields: {
    name: {type: String, index: 1}
  }
});

Parent = Astro.Class.Create({
  name: 'Parent',
  collection: new Meteor.Collection('parents'),
  child: {type: Child, default() { return new Child(); }}
});

Right now it throws an error, because an index is being set on an Astro Class that doesn't have a collection field specified, however i think that warning should be removed and it should automatically setup an index in the parent class that uses that class, which has a collection defined. Let me know your thoughts.

I haven't been trying it but this should work:
import { Class } from 'meteor/jagi:astronomy';

const User = Class.create({
  name: 'User',
  /* ... */
  fields: {
    address: Address
  },
  indexes: {
    cityName: { // Index name.
      fields: { // List of fields.
        'address.city': 1
      }
    }
  }
});

Indexes in nested classes is not so easy problem to solve. Index is something related with Collection, so storing index information in a nested class that does not have any associated collection seems to be wrong. However, parent class could look for nested classes and compose indexes. So in my example it could look for indexes in the Address class and it would found index on the city field, so it would compose index for the field address.city. Seems to work fine. But what about array of nested classes? Should it create index for each index? addresses.0.city, addresses.1.city, addresses.2.city etc.? Or should it create index for addresses.city? I don't know if it's even possible. I would have to check it out.

OK yes it's possible https://docs.mongodb.org/manual/core/index-multikey/#index-arrays-with-embedded-documents however I have to rethink it carefully.

The way you mentioned was in my mind as well and i think it will work, i haven't given it a try.
However i think what you explained is exactly how i think it should work and yes i think it will work that way for arrays as well.

I would like to help implement working out indexes from child or used classes.
Please point me in the right direction.

Hmmm one way of implementing it would be scanning Class schema for nested fields where a field is of Astro Class type. Then we should create indexes with appropriate names in the parent class. In theory it's not hard to implement. Are you familiar with the modules structure in Astronomy 2.0?

I have glanced at it a few times, but I think I can get familiar with it when i'll start writing it, hopefully this weekend. :)

Ok, if you have any questions just ask here. I will try to help. Thanks for contribution!

I added a pendingIndexes hash to index module, thinking it can be used by the Class schema where a field is of Astra Class Type.
I glanced at the fields module and I think it's the one I need to add code to, however can't seem to understand the right place for it, some direction here maybe.

What is the pending index? The correct place to add any index functionality is the indexes module. You actually don't have to add any new fields/properties. It can be done in the apply definition hook. You just have to scan nested classes add collect all the nested indexes. Later you have to build indexes names and just add them to the collection.

@jagi You're right we don't need pending index, we can directly add it, but i don't know if there are easier ways to do what i am doing, not very familiar with the utilities or ways you use to determine things. Can you give the below code a go and see if it this is good enough?
import _ from 'lodash';
import throwParseError from '../../core/utils/throw_parse_error.js';

function onApplyDefinition(Class, parsedDefinition, className) {
	if (parsedDefinition.indexes !== undefined) {
		let Collection = Class.getCollection();

		if (!Meteor.isServer || (Collection && !Collection._connection)) {
			return;
		}

		let schema = Class.schema;

		// Add indexes to the collection
		_.each(parsedDefinition.indexes, function(index, indexName) {
			schema.indexes[indexName] = index;
			Collection._ensureIndex(index.fields, index.options);
		});

		// Add indexes to the collection from nested classes
		let classFields = Class.getFields();
		_.each(classFields, (field) => {
			if (Class.classes[field.type.name] && field.type.class === Class.classes[field.type.name]) {
				let nestedIndexes = Class.classes[field.type.name].getIndexes();
				_.each(nestedIndexes, (index, indexName) => {
					schema.indexes[field.type.name + '_' + indexName] = index;
					Collection._ensureIndex(index.fields, index.options);
				});
			}
		});
	}
};

export default onApplyDefinition;

Ok you've started it correctly but there are some helper function that will make your life easier and code much more cleaner. Take a look at two methods:

Class.getObjectFields()
Class.getListFields()
The first one will return list of fields that have types being Astronomy classes (type: CustomClass)
The second one will return list of fields that have types being arrays of Astronomy classes (type: [CustomClass] but also type: [String]) I think I can improve this helper to take argument class: true so it will only return fields like [CustomClass].
And later you can do what you did with creating nested names for indexes.

Thanks, i saw those helper functions but wasn't sure what they did. Do you think schema.indexes[field.type.name + '_' + indexName] = index is the right approach?
I'll try and add the argument to that helper as well.

It should rather be field.name + '_' + indexName. I would also use . notation for consistency.

Makes sense. I'll update you soon. Thanks.

commit
Please review and let's think about:

As I think about it, they may also be a problem when extending a class definition with extra fields that may be of Astro class type. In such case it would not initialise indexes from nested classes... I have to think about a way of doing so.

It looks quite good but there are some things that need fixing like collecting indexes from nested nested fields and nested nested nested fields etc. :). I'm actually working on it.
As I'm investigating it, I'm considering storing indexes in array instead of object. Right now we have to replace not only fields, name option but also object keys which is redundant.

Ok nested indexes implemented. Sorry for not merging your commit but I had to rewrite a lot of things however I've used some parts of your code. And as I started doing it I've decided to finish it. Thanks a lot for your help!
Support for nested indexes in on GitHub so you can clone current version. I had one feature to implement before release. However the one I'm working on is causing me some problems. Closing for now. Let me know if it works.

Oh could you create PR with Readme changes?

Sure, no problem and thanks. Just wanted to help :)

Getting this error from the latest clone:
W20160721-14:59:52.354(5)? (STDERR) TypeError: Cannot read property 'indexes' of undefined
W20160721-14:59:52.354(5)? (STDERR)     at packages/jagi:astronomy/lib/modules/indexes/hooks/apply_definition.js:42:19

You also missed bringing in the changes for Class.getListFields()

Oh right I forgot about that. Fixed. Check it out now.

https://github.com/jagi/meteor-astronomy/blob/v2/lib/modules/fields/class_static_methods/get_list_fields.js still seems the same, forgot to push?

Oh sorry it rejected push and I didn't notice that. Right now it should be available. Thanks!


main/e2e: Readability improvements

Turn main's run(...) with N args into a mainCmd struct,
that has fields for global/OS-level state like stdin/stdout, etc.
and a Run method to accept CLI arguments to run with.
Use this struct to build a helper inside e2e_test
that runs main with provided arguments
and returns results to make the assertions inside the test easier.

Codecov Report

Merging #72 (9de39bf) into main (25be6fc) will decrease coverage by 0.20%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   86.51%   86.30%   -0.21%
==========================================
  Files          38       38
  Lines        2061     2066       +5
==========================================
  Hits         1783     1783
- Misses        222      227       +5
  Partials       56       56

Impacted Files
Coverage Δ

main.go
64.13% <38.09%> (-1.80%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Failure to legalize tm_tensor.scatter

What happened?
Compiling Stable Diffusion with iree-compile (and attention slicing enabled) outputs
<eval_with_key>.8:185:12: error: failed to legalize operation 'tm_tensor.scatter' that was explicitly marked illegal
<unknown>:0: error: Failures have been detected while processing an MLIR pass pipeline
<unknown>:0: note: Pipeline failed while executing [`mlir::iree_compiler::IREE::HAL::{anonymous}::ConvertToHALPass` on 'builtin.module' operation]: reproducer generated at `iree-tmp/core-reproducer.mlir`

Steps to reproduce your issue

Run cat core-reproducer.mlir | /home/gap/code/SHARK/venv/lib/python3.11/site-packages/iree/compiler/tools/../_mlir_libs/iree-compile - --iree-input-type=none --iree-vm-bytecode-module-output-format=flatbuffer-binary --iree-hal-target-backends=cuda --iree-llvm-embedded-linker-path=/home/gap/code/SHARK/venv/lib/python3.11/site-packages/iree/compiler/tools/../_mlir_libs/iree-lld --mlir-print-debuginfo --mlir-print-op-on-diagnostic=false --mlir-pass-pipeline-crash-reproducer=iree-tmp/core-reproducer.mlir --iree-llvm-target-cpu-features=host --iree-hal-cuda-disable-loop-nounroll-wa --iree-hal-cuda-llvm-target-arch=sm_80 --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 --iree-util-zero-fill-elided-attrs --iree-preprocessing-pass-pipeline='builtin.module(func.func(iree-flow -detach-elementwise-from-named-ops,iree-flow-convert-1x1-filter-conv2d-to-matmul,iree-preprocessing-convert-conv2d-to-img2col,iree-preprocessing-pad-linalg-ops{pad-size=16}))'

What component(s) does this issue relate to?
MLIR
Version information
20230302.322
Additional context
This is produced for both cuda and vulkan on an Nvidia A100

Here is the mlir file

The command line seems wrong, don't you need --iree-input-type=tm_tensor?

It compiles fine with --iree-input-type=tm_tensor for me. Could you please verify and close the issue if this is the case?

That does fix it, odd that it was set to none.


Configuring automatic tuning on server with previously unspecified settings results in no action

I have an SQL Database server that has never had its automatic tuning settings specified. The portal displays the message "The automatic tuning configuration is not specified. Please specify it by selecting one of the options above." All of the tuning settings are disabled.
I have a PowerShell script that tries to set the default automatic tuning settings for the server level:
Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "CreateIndex" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName
Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "DropIndex" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName
Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "ForceLastGoodPlan" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName

However, when this script runs, none of the automatic tuning settings are changed. The output from the script running in Azure DevOps is below:
2019-04-30T14:35:48.7271310Z ResourceGroupName              : xxx
2019-04-30T14:35:48.7271944Z ServerName                     : xxx
2019-04-30T14:35:48.7272669Z AdvisorName                    : CreateIndex
2019-04-30T14:35:48.7274615Z AdvisorStatus                  : GA
2019-04-30T14:35:48.7274759Z AutoExecuteStatus              : Disabled
2019-04-30T14:35:48.7275423Z AutoExecuteStatusInheritedFrom : Server
2019-04-30T14:35:48.7275861Z LastChecked                    :
2019-04-30T14:35:48.7276424Z RecommendationsStatus          :
2019-04-30T14:35:48.7276987Z RecommendedActions             : {}
2019-04-30T14:35:48.7277279Z
2019-04-30T14:35:49.6788231Z ResourceGroupName              : xxx
2019-04-30T14:35:49.6788998Z ServerName                     : xxx
2019-04-30T14:35:49.6789317Z AdvisorName                    : DropIndex
2019-04-30T14:35:49.6789597Z AdvisorStatus                  : GA
2019-04-30T14:35:49.6790396Z AutoExecuteStatus              : Disabled
2019-04-30T14:35:49.6790869Z AutoExecuteStatusInheritedFrom : Server
2019-04-30T14:35:49.6791015Z LastChecked                    :
2019-04-30T14:35:49.6791572Z RecommendationsStatus          :
2019-04-30T14:35:49.6791851Z RecommendedActions             : {}
2019-04-30T14:35:49.6792030Z
2019-04-30T14:35:50.6907382Z ResourceGroupName              : xxx
2019-04-30T14:35:50.6908123Z ServerName                     : xxx
2019-04-30T14:35:50.6908643Z AdvisorName                    : ForceLastGoodPlan
2019-04-30T14:35:50.6908816Z AdvisorStatus                  : GA
2019-04-30T14:35:50.6909209Z AutoExecuteStatus              : Disabled
2019-04-30T14:35:50.6909357Z AutoExecuteStatusInheritedFrom : Server
2019-04-30T14:35:50.6910240Z LastChecked                    :
2019-04-30T14:35:50.6910632Z RecommendationsStatus          :
2019-04-30T14:35:50.6911327Z RecommendedActions             : {}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ef45327-7cdf-fc60-2a04-b785bc12f4cf
Version Independent ID: b4f8c915-9651-14df-92d7-fa1387780a41
Content: Enable automatic tuning for Azure SQL Database
Content Source: articles/sql-database/sql-database-automatic-tuning-enable.md
Service: sql-database
Sub-service: performance
GitHub Login: @danimir
Microsoft Alias: danil

The docs page would not let me add an attachment. Here is a screenshot of the portal after running the script:

@sugarjig Thank you very much for bringing this to our attention. We are investigating and will get back to you with an update with regard to this functionality.

@sugarjig You will have to set the -AutoExecuteStatus to "Enabled"
Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "ForceLastGoodPlan" -AutoExecuteStatus Enabled -ServerName $serverName -ResourceGroupName $resourceGroupName
By Default, Automatic Tuning is Disabled on the server.
Please let us know if you have any further questions.

This doesn't make sense to me. If I have enabled automatic tuning through the Azure Portal, I can use Default with the above mentioned Powershell command, and I get the desired result. Observe.
> Get-AzureRmSqlServerAdvisor -ServerName $serverName -ResourceGroupName $resourceGroupName
ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : CreateIndex
AdvisorStatus                  : GA
AutoExecuteStatus              : Enabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : DropIndex
AdvisorStatus                  : GA
AutoExecuteStatus              : Disabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : DbParameterization
AdvisorStatus                  : GA
AutoExecuteStatus              : Disabled
AutoExecuteStatusInheritedFrom : Default
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : DefragmentIndex
AdvisorStatus                  : PrivatePreview
AutoExecuteStatus              : Disabled
AutoExecuteStatusInheritedFrom : Default
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : ForceLastGoodPlan
AdvisorStatus                  : GA
AutoExecuteStatus              : Enabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

The corresponding Portal view of this server is below. Notice that the settings are inheriting from the Azure defaults.

When I run the commands to set the advisor configurations using Default, I observe no changes:
> Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "CreateIndex" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : CreateIndex
AdvisorStatus                  : GA
AutoExecuteStatus              : Enabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

> Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "DropIndex" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : DropIndex
AdvisorStatus                  : GA
AutoExecuteStatus              : Disabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

> Set-AzureRmSqlServerAdvisorAutoExecuteStatus -AdvisorName "ForceLastGoodPlan" -AutoExecuteStatus Default -ServerName $serverName -ResourceGroupName $resourceGroupName

ResourceGroupName              : xxx
ServerName                     : xxx
AdvisorName                    : ForceLastGoodPlan
AdvisorStatus                  : GA
AutoExecuteStatus              : Enabled
AutoExecuteStatusInheritedFrom : Server
LastChecked                    :
RecommendationsStatus          :
RecommendedActions             : {}

If what you're saying is true, then by using Default, I would expect CreateIndex and ForceLastGoodPlan to be Disabled, not Enabled.
There seem to be 2 pieces to this: enabling automatic tuning itself, and enabling the individual advisors (force plan, create index, drop index). The Powershell command Set-AzureRmSqlServerAdvisorAutoExecuteStatus does not seem to address the first piece, and there doesn't appear to be a command that does. When automating deployments from a CD environment, one needs to be able to configure a new environment from scratch using the same idempotent scripts that are used to configure existing environments.

@sugarjig my sincere apologies for the confusion. I assumed that your database server is created from the portal and you are creating new databases using Azure DevOps.
Thank you very much for clarifying.
Coming to the issue, yes enabling the tuning itself isnt supported via the powershell cmdlet.
However this is supported using the rest api and you can easily extend it to powershell.
Infact this is already done. Please check this article
You can configure your database to inherit from Azure defaults instead of inheriting from the server.

Please let us know if you have further questions.

@sugarjig We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

Thank you for your help!


SAK-43349 Use user id and "anonymous" in anon Grader

https://jira.sakaiproject.org/browse/SAK-43349

LGTM!

@mpellicer Could you just approve this, please? We need to get Jesus write access!


Add podspecs for macOS frameworks

What this pull request adds:

Ability to use SourceryFramework and other macOS frameworks with Cocoapods (it also works without need to release it to global Spec repo)

Use case:
We have project that uses Cocoapods, we use Sourcery directly from Swift, and it is very convenient for our case to use Sourcery from Swift code, we are migrating from ton of independent templates and entry points to code generation to a single nice Swift project.
We don't really need to have podspecs to be able to use Sourcery, since our project for code generation uses SPM. But our iOS which works with that code generation uses Cocoapods, and it's very nice to be able to work in a single project, also cocoapods have nice features that is missing in SPM, such as development pods (also SPM can't work with mixed Obj-C, Swift code, so there is no way to migrate everything to SPM). So SPM is used only to build binaries.
Drawbacks
If you want to support this, you will have to update versions of podspecs, so, additional work. Note that the use case seems to be rare, at least for now, so releasing those frameworks to global spec repo seems unnecessary, they can be used without it just fine, by specifying url to git repo.
P.S.
I don't know if the descriptions of podspecs suits, I just copypasted them. We also don't expect this to be released to global spec repo, but podspecs are nice to have. If you want me to improve something in this PR, I'm willing to do so.

thanks for contributing :+1:

Thank you for your amazing work! ❤