Shrinking expandables target area + updating date

Two changes:

This shrinks the expandable target area on the bureau-structure page to make it easier to scroll without hitting a target area unintentionally. I talked through it with @schaferjh to make sure this reflects the intended UX behavior of having the expandable header section be the target.
Updated the date to reflect the changes made in #1553

Testing

Visit http://localhost:8000/about-us/the-bureau/bureau-structure/ on mobile and note the target area
Visit the same page on iOS simulator and try scrolling. @schaferjh noticed some strange behavior where it would close during scrolling. I assumed it was because of accidentally tapping the large target area, but please let me know if you see anything suspicious.

Review

@jimmynotjim
@sebworks
@anselmbradford

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

This probably isn't going to fix the expandable issue on mobile devices, but it does shrink the target area to be just the clearly marked expandable section like this.

Is it still worth reviewing and merging, @schaferjh?

hmmm, it might be just to clean up the interaction. I know @sebworks said he was going to explore this issue a bit last night -- any thoughts?

So IOS is firing the resize event onScroll and we collapse expandables on mobile:
https://github.com/cfpb/cfgov-refresh/blob/36c96327a92b49c77e163ff298a30f5303970d60/cfgov/unprocessed/js/molecules/Expandable.js#L239. I'm fixing the issue now.
http://stackoverflow.com/questions/8898412/iphone-ipad-triggering-unexpected-resize-events

Should we still move forward with this PR? The smaller tap targets still seem plenty large for tapping with fingers, so we might still avoid some accidental taps with this. :+1: if so

:+1:


duplicate values in typeahead search

Seen a few of these duplicates in the search box:
e.g. TTF1

Anyone else seeing that?

Here is another example:


[stacked] Form values is sometimes null

I have experienced some issues when using FormViewModel.
Related issues
#355
#453
I think it works well sometimes.
I've defined my view like this
@FormView(fields: [
  FormTextField(name: 'phoneNumber'),
])
class RegisterView extends ViewModelBuilderWidget<RegisterViewModel>
    with $RegisterView {
   // etc.
}

TextFormField(
  controller: phoneNumberController,
  decoration: InputDecoration(
    labelText: 'Phone number',
    hintText: 'Enter Your Phone number',
  ),
  keyboardType: TextInputType.phone,
  // onChanged: (String? value) =>
  //     model.formValueMap[PhoneNumberValueKey] = value,
  validator: (String? value) {
    if (value == null || value.isEmpty) {
      return 'the field phone number is required';
    }

    return null;
  },
)

But when I implement the field this way, using onChanged instead of controller, it's always works
TextFormField(
  // controller: phoneNumberController,
  decoration: InputDecoration(
    labelText: 'Phone number',
    hintText: 'Enter Your Phone number',
  ),
  keyboardType: TextInputType.phone,
  onChanged: (String? value) =>
       model.formValueMap[PhoneNumberValueKey] = value,
  validator: (String? value) {
    if (value == null || value.isEmpty) {
      return 'the field phone number is required';
    }

    return null;
  },
)

experiencing same issue with stacked: ^2.2.5

it is an issue with hot reloading and hot restart apparently.

OK. Is there a way we can fix it?
Using this code, fix the issue
onChanged: (String? value) =>
       model.formValueMap[PhoneNumberValueKey] = value,

@kodjosama for hot-reload we haven't looked into the issue since it doesn't affect production builds and only happens when hot reloading is involved.

Ok got it. Thanks 👏👍

If there's still a problem with this in a production app please post a sample I can run in release mode that causes this issue


Make pickadate work out of box with npm and browserify.

pickadate doesn't work with browserify out of box.
There are steps to make it work with browserify out of box.

picker.js should require picker.date.js and picker.time.js. Not the other way around.
set "main" attribute in package.json and publish the library to npm.

Hi @amsul,
The current version of pickadate as a module only exposes the instance of PickerConstructor but it doesn't expose DatePicker neither TimePicker so every time we try to instantiate a date picker or time picker we got the error undefined is not a function because neither of them have been loaded and so no jquery.extend invocation have been made to append them to the jQuery object.
@crocket tried to show the problem but he couldn't explain it clearly, as you pointed out. The dependency graph is as you said both pick.date and pick.time depend on picker.js not the other way around.
What is needed is some kind of facade / wrapper to expose all the pickadate functionality out of the box.
For this I made some small changes. I added an index.js that works as the facade / wrapper for picker.js, pick.date and pick.time, allowing them to be used out of the box with Browserify by issuing the typical require('pickadate'). It doesn't need to be assigned to a variable since pickadate attaches itself directly to the jQuery object.
This change is a copy of the way the CryptoJS library by @evanvosberg exposes its different algorithms through the same pattern implemented in its index.js file.
It would be great if this feature addition could be incorporated to the pickadate code. For that I can see this options:

You may check the CrytpoJS index.js file and create a copy for pickadate or
you can check the this gist with the contents for the index.js I created to include in pickadate or
I can make a push request to integrate this feature directly.

The only additional change would be to modify the property main in package.json to point to index.js.
What you think? Is it possible to add this to pickadate to finally made it browserify ready out of the box? :)
Greetings and congratulations for such excellent plugin! You've made the day of many many devs outhere. :D

Thanks @mogarick your gists saved me a lot of time!

@mogarick thanks for posting the solution above. Just in case anyone else makes the same mistake as me. I had to import the package via bower not npm. Then prepended "index.js" to the bower.json file within the package.

@amsul , any way this @mogarick solution could be added to this project?

The solution @mogarick has provided works well, please can it be added.


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2022-05-12T21:28:54+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.13
ccd2e4febe602b37310207a36642155d1a1bb625
link
unknown
/test unit-tests_istio_release-1.13

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.13


[ISSUE-2983] Fix the wrong doc description.

Issue Number: close #2983

@wolfboys
Hello, this issue is a good merge, in fact, I am not sure whether it is appropriate to deal with it like this


[Kubernetes cronjob] pg_isready only works interactively (pod user permissions maybe?)

Summary
TL;DR: pg_isready only seems to work when executed interactively in the pod, as opposed to when the pod is executed. This happens after I had to manually add the PGSSLMODE=require env variable because it was throwing a /root/.postgresql/postgresql.crt: Permission denied error.
Steps to reproduce
What I did was I:

Created the k8s job
Followed the steps here
After just setting the env variables listed above (MODE=MANUAL, MANUAL_RUN_FOREVER=FALSE, CONTAINER_ENABLE_SCHEDULING, and CONTAINER_ENABLE_MONITORING), it wouldn't start on its own (was waiting on user input).
Adding /etc/services.available/10-db-backup/run to the "command" field of the container definition resulted in a "no such file or directory" error.
I took inspiration from this comment which had me add the ['/init', 'backup-now'] commands which worked.
At that point, with all the envs loaded, I was getting a failed connection to my postgres server with /root/.postgresql/postgresql.crt: Permission denied being cited as the issue.
I added PGSSLMODE=require to the env list, and the error went away.
Now, I am facing the issue where pg_isready won't see that the server is ready. In order to debug, I grabbed the command that was being executed in the debug logs and ran it interactively in the pod with pg_isready --host=$DB01_HOST --port=$DB01_PORT --dbname=$DB01_NAME --username=$DB01_USER and it worked perfectly.

I suspect that this is a permissions issue with how the commands are being executed, but I'm not entirely sure.
I have the following k8s config:
apiVersion: batch/v1
kind: CronJob
metadata:
 name: postgres-storage-backup
 namespace: mastodon
spec:
 schedule: "30 1 * * *"
 concurrencyPolicy: Forbid
 suspend: false
 successfulJobsHistoryLimit: 1
 failedJobsHistoryLimit: 1
 jobTemplate:
   spec:
     template:
       metadata:
         name: postgres-storage-backup
       spec:
         volumes:
           - name: postgres-completion
             configMap:
               name: postgres-completion
               defaultMode: 0500
         containers:
           - name: postgres-storage-backup
             image: tiredofit/db-backup:4.1.3
             imagePullPolicy: IfNotPresent
             command:
               - /init
               - backup-now
             volumeMounts:
               - name: postgres-completion
                 mountPath: "/script"
             env:
               - name: DEBUG_MODE
                 value: "TRUE"
               - name: PGSSLMODE
                 value: "require"
               - name: MODE
                 value: "MANUAL"
               - name: MANUAL_RUN_FOREVER
                 value: "FALSE"
               - name: CONTAINER_ENABLE_SCHEDULING
                 value: "FALSE"
               - name: CONTAINER_ENABLE_MONITORING
                 value: "FALSE"
               - name: DEFAULT_POST_SCRIPT
                 value: "/script/postgres.sh"
               - name: DEFAULT_BACKUP_LOCATION
                 value: 'S3'
               - name: DEFAULT_S3_BUCKET
                 valueFrom:
                   configMapKeyRef:
                     name: storage-backup
                     key: postgres_bucket
               - name: DEFAULT_S3_KEY_ID
                 valueFrom:
                   configMapKeyRef:
                     name: storage-backup
                     key: DEFAULT_S3_KEY_ID
               - name: DEFAULT_S3_KEY_SECRET
                 valueFrom:
                   configMapKeyRef:
                     name: storage-backup
                     key: DEFAULT_S3_KEY_SECRET
               - name: DEFAULT_S3_REGION
                 valueFrom:
                   configMapKeyRef:
                     name: storage-backup
                     key: DEFAULT_S3_REGION
               - name: DEFAULT_S3_HOST
                 valueFrom:
                   configMapKeyRef:
                     name: storage-backup
                     key: DEFAULT_S3_HOST
               - name: DB01_TYPE
                 value: "pgsql"
               - name: DB01_HOST
                 valueFrom:
                   configMapKeyRef:
                     name: mastodon-env-tf
                     key: DB_HOST
               - name: DB01_PORT
                 valueFrom:
                   configMapKeyRef:
                     name: mastodon-env-tf
                     key: DB_PORT
               - name: DB01_NAME
                 valueFrom:
                   configMapKeyRef:
                     name: mastodon-env-tf
                     key: DB_NAME
               - name: DB01_USER
                 valueFrom:
                   configMapKeyRef:
                     name: mastodon-env-tf
                     key: DB_USER
               - name: DB01_PASS
                 valueFrom:
                   configMapKeyRef:
                     name: mastodon-env-tf
                     key: DB_PASS
         restartPolicy: OnFailure
 successfulJobsHistoryLimit: 1
 failedJobsHistoryLimit: 1

What is the expected correct behavior?
pg_isready sees that the server is up and backs it up
Relevant logs and/or screenshots
I've attached the debug logs with everything sensitive scrubbed: private-logs.txt
Environment

Image version / tag:  tiredofit/db-backup:4.1.3
Host OS: k8s 1.30.2-do.0

Possible fixes
I've spent a fair amount of time debugging this, so I felt like there was just a point where it would be best to track my progress with a bug open

update: I see that the path listed in this part of the readme is incorrect, and it should be /etc/services.available/dbbackup-01/run instead of /etc/services.available/10-db-backup/run. At least, that's what is in my docker image.
It's now able to execute "run" as was mentioned in the docs, but it's still stuck at the pg_isready not working in an automated fashion.


Lazy loaded module not loading css

Bug Report
i have imported following module to app module
CovalentCoreModule.forRoot(),     CovalentHighlightModule.forRoot(),     CovalentMarkdownModule.forRoot(),     CovalentChartsModule.forRoot(),
i have one lazy loaded module, which has following code od line
schemas: [     CUSTOM_ELEMENTS_SCHEMA   ],
i am able to use covalent html directive in submodules but thing is that css is not loading....
my package.json file
 "dependencies": {     "@angular/common": "^2.3.1",     "@angular/compiler": "^2.3.1",     "@angular/core": "^2.3.1",     "@angular/forms": "^2.3.1",     "@angular/http": "^2.3.1",     "@angular/platform-browser": "^2.3.1",     "@angular/platform-browser-dynamic": "^2.3.1",     "@angular/router": "^3.3.1",     "@angular/material": "2.0.0-beta.1",     "core-js": "^2.4.1",     "rxjs": "^5.0.1",     "ts-helpers": "^1.1.1",     "zone.js": "0.7.2",     "@covalent/core": "0.10.0",     "@covalent/charts": "0.10.0",     "@covalent/dynamic-forms": "0.10.0",     "@covalent/highlight": "0.10.0",     "@covalent/http": "0.10.0",     "@covalent/markdown": "0.10.0",     "hammerjs": "^2.0.8",     "highlight.js": "9.6.0",     "showdown": "1.4.2",     "@swimlane/ngx-charts": "^3.0.5",     "moment": "^2.17.1",     "d3": "^4.4.0"   },   "devDependencies": {     "@angular/compiler-cli": "^2.3.1",     "@types/jasmine": "2.5.38",     "@types/node": "^6.0.42",     "angular-cli": "1.0.0-beta.25.5",     "codelyzer": "~2.0.0-beta.1",     "jasmine-core": "2.5.2",     "jasmine-spec-reporter": "2.5.0",     "karma": "1.2.0",     "karma-chrome-launcher": "^2.0.0",     "karma-cli": "^1.0.1",     "karma-jasmine": "^1.0.2",     "karma-remap-istanbul": "^0.2.1",     "protractor": "~4.0.13",     "ts-node": "1.2.1",     "tslint": "^4.3.0",     "typescript": "~2.0.3",     "node-sass": "3.8.0",     "sass-loader": "^4.0.2"   }
no errors are coming, but css is not loading....

can you update the covalent versions to 0.10.2? we had a bug in 0.10.0
to load the css you'll need to add the files to the angular-cli:
https://github.com/Teradata/covalent-quickstart/blob/develop/angular-cli.json#L21-L24

@kyleledbetter i have updated to 0.10.2 and updated my whole package.json, i have deleted node_modules and installed fresh node modules
"angular-cli": {},
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "lint": "tslint \"src/**/*.ts\" --project src/tsconfig.json --type-check && tslint \"e2e/**/*.ts\" --project e2e/tsconfig.json --type-check",
    "test": "ng test",
    "pree2e": "webdriver-manager update --standalone false --gecko false",
    "e2e": "protractor"
  },
  "private": true,
  "dependencies": {
    "@angular/common": "2.4.1",
    "@angular/compiler": "2.4.1",
    "@angular/core": "2.4.1",
    "@angular/forms": "2.4.1",
    "@angular/http": "2.4.1",
    "@angular/material": "2.0.0-beta.1",
    "@angular/platform-browser": "2.4.1",
    "@angular/platform-browser-dynamic": "2.4.1",
    "@angular/platform-server": "2.4.1",
    "@angular/router": "3.4.1",
    "@covalent/core": "0.10.2",
    "@covalent/charts": "0.10.2",
    "@covalent/dynamic-forms": "0.10.2",
    "@covalent/highlight": "0.10.2",
    "@covalent/http": "0.10.2",
    "@covalent/markdown": "0.10.2",
    "core-js": "^2.4.1",
    "hammerjs": "^2.0.8",
    "highlight.js": "9.6.0",
    "rxjs": "^5.0.1",
    "showdown": "1.4.2",
    "zone.js": "^0.7.2",
    "@swimlane/ngx-charts": "^3.1.2",
    "moment": "^2.17.1",
    "d3": "^4.4.0",

    "ts-helpers": "^1.1.1"

  },
  "devDependencies": {
    "@angular/compiler-cli": "2.4.1",
    "@types/hammerjs": "2.0.30",
    "@types/jasmine": "2.2.31",
    "@types/node": "6.0.34",
    "@types/selenium-webdriver": "2.53.36",
    "angular-cli": "1.0.0-beta.24",
    "codelyzer": "0.0.26",
    "ember-cli-inject-live-reload": "1.4.0",
    "jasmine-core": "2.4.1",
    "jasmine-spec-reporter": "2.5.0",
    "karma": "1.2.0",
    "karma-chrome-launcher": "2.0.0",
    "karma-cli": "1.0.1",
    "karma-jasmine": "1.0.2",
    "karma-remap-istanbul": "0.2.1",
    "karma-firefox-launcher": "1.0.0",
    "karma-phantomjs-launcher": "1.0.1",
    "node-sass": "3.8.0",
    "phantomjs-prebuilt": "2.1.7",
    "protractor": "4.0.5",
    "sass-loader": "^4.0.2",
    "ts-node": "1.2.1",
    "tslint": "3.14.0",
    "typescript": "2.0.10"
  }

i have already added css in angular-cli
"styles": [
        "styles.scss",
        "theme.scss",
<EMAIL_ADDRESS><EMAIL_ADDRESS>      ],
      "scripts": [
        "../node_modules/hammerjs/hammer.min.js",
        "../node_modules/showdown/dist/showdown.js"
      ],

here is the demo code. please you can review code here: => https://github.com/imVinayPandya/covalent-project

So just took a glance, but CUSTOM_ELEMENTS_SCHEMA is what is making the app not have errors with unknown components.
So even if you are using covalent elements, you need to re-import the module in the submodules since components arent shared across them.
https://github.com/imVinayPandya/covalent-project/blob/master/src/app/login/login.module.ts#L18
If you arent using non-angular component, i would avoid using CUSTOM_ELEMENTS_SCHEMA at all.

yes for now i am importing covalent module in each module.
i think this should not happen, bcz if i want to use one module as global i should be imported only once. like HttpModule of angular 2 i have imported only in mainmodule but still i can access through all submodule.

This is an @angular thing, not covalent.
Angular forces you to import the modules you will use in a submodule so they are decoupled and an app can be truly modularized (hence ngModule)

ok thank you for explaining.......... @emoralesb05

Closing this issue


API paths differ from docs

Was working on some integration tests and found out that the requested path from ListAccounts is /accounts and not /sites.{siteId}/accounts as it says in the docs and the OpenAPI reference.
Wanted to know how to handle this, as we are trying to implement integration tests using an external mocker (so that we do not need the whole ClientInterface). As a side note, the HTTPCaller.Call interface has an unexported parameter type, so I guess that cannot be used to mock, as we do not have the type available...
References:
[1] client.ListAccounts: https://github.com/recurly/recurly-client-go/blob/7281b1a215a4935e9274891b46191ffcd21db5af/client_operations.go#L578
[2] Docs to Accounts: https://developers.recurly.com/api/v2019-10-10/index.html#operation/list_accounts

@tarasyarema, I apologize for the delayed response to your inquiry.
As you've pointed out, the /sites/{site_id} prefix is not required for the API endpoints. Recurly API will infer the required site_id from the private API key that is used when making requests. The client libraries do not include this in the operations in order to remove the need for the site_id to be specified for each request. We are considering removing this from the candidate version of the openapi specification, currently called v2020-01-01.
As for how to handle this in your external mocker, I'm not 100% certain as I don't know what you're using exactly. If it is a self developed mocker, you could strip the prefix (excluding the get_site endpoint /sites/{site_id})
We will get that optionsApplier to be exported. Sorry about that.

Ok, could not find why the site_id was missing. Thanks for the explanation.
In the end as we could not mock it because of the unexported struct, we had a proxy approach, which seems to be working fine.

Closing the PR, thanks!


Provide dart2js API to disable generating source maps

Dart2js internally has a flag used to control whether or not source maps or generated, but the public API does not expose this. In pub, I don't want to generate source maps in a release build since that build doesn't include the source .dart code that the source map would point to.
I have a workaround, so it's not at all blocking, but it would be nice to not do the work to generate the source map if pub isn't going to write it.

I believe the --no-source-maps flag is now exposed, but let me know if not.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 610

Questions ?
Please refer to the Backport tool documentation


theme background rendering problem

VSCode Version: Version 1.5.3
OS Version: macOS Sierra 10.12

Since upgrading to Sierra I see the rendering glitch in all themes except those with solid black or white background.  ##

Tracked as #12473


feat: reducer functions

Now
% fgrep -r 'assert False, "TODO' src | wc -l
51

This PR filled in 11 (all of the reducers).


[Bug] Step 0 workflow not being triggered

Summary
When I create a repository from template by following the instructions on the README, the README does not update itself after refreshing the page after 20 seconds. In investigating the cause, I noticed that there was not execution for the Step 0 workflow in the 'Actions' tab. This is a consequence of the type of trigger being used (create instead of push).
I did notice one exception to this that is if the user selects the check box 'Include all branches', which also creates a branch besides 'main' during repository creation and thus runs the workflow. However, this checkbox is not selected by default and I suspect it would not trigger the automation if at any point there are no other branches besides 'main'.
How to reproduce

Follow the steps on the README for creating repository from template.
Notice the README will not be changed after 20 seconds.

Thanks for the contribution, @RelicCornhusk! ❤ https://github.com/skills/code-with-codespaces/pull/86


Specified API version doesn't contain scope_maps

ValueError: API version 2019-12-01-preview does not have operation group 'scope_maps'

@kwikiel Thanks for the contribution!


Past leaderboard X Rank data is different from the actual final standings

First of all thanks for making the site I use it all the time and I find the data in json format very useful.
I have a bug report/feature request. I found that past season's leaderboard is different from how it appears in the app. Here is an example:
      "node": {
              "id": "WFJhbmtpbmdIb2xkZXItYToyOmxmOnUtYTM2YXFjYWRjeDc3cm9wYjVubW0=",
              "name": "papoguapo",
              "rank": 336,
              "rankDiff": null,
              "xPower": 2618.7,
              "weapon": {
                "name": "Splash-o-matic",

From: https://splatoon3.ink/data/xrank/xrank.detail.a-2.towercontrol.json

From the app (Chill Season 2022 / Tentatek / Tower Control) - screenshot from today.

if I had to guess this is that the final "live update" is different from the "final reports" in some cases. Would you consider upgrading the past season data to reflect the final standing? Thanks for consideration.

Hey @Sendouc! Thank you for all your contributions to the Splatoon community as well :)
You're absolutely right, the data updater missed the last report for the previous season because it was only pulling data for the "current" season.
I just pushed an update to fix this issue. Player papoguapo now correctly shows as rank 342 in the file you linked.
Let me know if you notice any other issues, and thanks for reporting this!!

Thanks for the quick response! Looks good now :)


OpenStax

https://openstax.org
Probably very small in comparison to other datasets, but the textbooks are designated with Creative Commons Attribution 4.0

https://huggingface.co/datasets/crumb/openstax-text

Since this is only 75 textbooks, I very much do not expect it to be worth the work.


realm: take ownership of instance layout for all calls to create_instance

Calls to RealmInstance::create_instance or RealmInstance::create_external accept a pointer to a dynamically allocated InstanceLayoutGeneric * (or really, a subclass of that), and in nearly all cases, take ownership of that allocation to avoid the overhead of a copy.  However, there are a few cases right now where Realm doesn't and the caller must delete the layout object to avoid a memory leak.  It makes much more sense to be consistent here and have Realm take ownership in all cases.
@lightsighter can you point me at the places in Legion where you delete layout objects?  I'll remove those as part of this change.

In InstanceBuilder::create_physical_instance in the file legion_instances.cc we have a block of code that looks like this:
// Clone the realm layout each time since (realm will take ownership
// after every instance call, so we need a new one each time)
Realm::InstanceLayoutGeneric *inst_layout = realm_layout->clone();

and then in the file legion.inl there are a bunch of calls that Realm::InstanceLayoutGeneric::choose_instance_layout in the constructors of DeferredBuffer objects (and related) that we then turn right around pass back into create_instance or create_external calls. The code blocks will look like this:
Realm::InstanceLayoutGeneric *layout =
        Realm::InstanceLayoutGeneric::choose_instance_layout(bounds,
            constraints, dim_order);
      Realm::ProfilingRequestSet no_requests;
#ifdef LEGION_MALLOC_INSTANCES
      // Ask Legion to malloc this instance for us
      Runtime *runtime = Runtime::get_runtime();
      const size_t footprint = bounds.bounds.volume() * sizeof(FT);
      uintptr_t ptr = runtime->allocate_deferred_instance(memory, footprint);
      Internal::LgEvent wait_on(Realm::RegionInstance::create_external(
            instance, memory, ptr, layout, no_requests));
#else
      Internal::LgEvent wait_on(Realm::RegionInstance::create_instance(
            instance, memory, layout, no_requests));
#endif


when it comes to non-fungible, only check events for tokens with balance

Don't bother checking events for tokens with zero balance.

Are you sure:

this only affects none-fungible tokens
that this change does not affect the case where the user has 0 crypto-kitty and he got sent 1?

Are you sure:

this only affects none-fungible tokens
that this change does not affect the case where the user has 0 crypto-kitty and he got sent 1?

It now only affects NFTs.
This particular change is picked up from OpenSea query not from events. We would only pick up the balance change event if the script had added it; which is an impossible assumption as you would need to replicate it for every ERC721. Far simpler to rely on the author registering with OpenSea.


Feature request: Use OrderedDict instead of dict for model class _attribute_map

The serialized XML tag sequence follows the sequence of properties  defined in _attribute_map of a model class.
But _attribute_map uses dict so the generated XML doesn't guarantee the tags sequence because dict has no sequence in python 3.5 and earlier.
I suggest using OrderedDict instead of dict for the _attribute_map.
ServiceBus namespace API does care about the XML tags sequence even though they're siblings. I now use a workaround to by setting the _attribute_map with an OrderedDict.

Need thinking, since it makes the model slightly heavier. There is different approaches possible, like having a list of keys in order, and use that instead.
I consider this low-priority.

Yes, a sequence (list/tuple) of keys would work.

3.5 is dead, and 2.7 almost, we won't do it


two Shopify stores using the same app at the same time will cause some bugs

Sorry, my english is poor.
In the same browser, two shopify stores using the same app at the same time will cause some bugs.
ex:
1. Reapply for authorization from shopify

2. laravel_session missing in request header cookie
Response header has set-cookie, but it is invalid

This is starting to become a bit of a problem. I have customers who manage multiple stores that use the same app and there has been some crossover, i.e. the wrong info got saved to the wrong store.

This is starting to become a bit of a problem. I have customers who manage multiple stores that use the same app and there has been some crossover, i.e. the wrong info got saved to the wrong store.

Hi @darrynten, can you more explain that issue, please?. I'm going to this package to sell in Shopify

@nguyentvnhat xin chào bạn!
If you switch to using the JWT from Shopify and auth.token routes you will no longer experience this issue.

is this still a problem ?

Cleanup... Closing for now, cookies are removed in v17.0.0
Re-open if still and issue.
Thanks!


Standardize request logging with RFC3339 timestamps

Switch to adding Request.Namespace and Request.Name and use nicer timestamps, e.g. past:
1.6547026149781811e+09	DEBUG	controller.vpcendpoint	Searching for security group by ID	{"reconciler group": "pso.example.com", "reconciler kind": "VpcEndpoint", "name": "demo", "namespace": "demo", "id": "sg-0bc3b12b1da744606"}

present:
{"level":"info","ts":"2022-06-08T15:15:35-04:00","logger":"vpcendpoint","caller":"vpcendpoint/cleanup.go:67","msg":"Deleting AWS resources","Request.Namespace":"demo","Request.Name":"demo","SecurityGroup":"sg-0bc3b12b1da744606"}

/lgtm


Ltsc2019 is also being chosen for Windows 10, HyperV not installed.

Describe the issue
Ltsc2019 is also being chosen for Windows 10, HyperV not installed.
Previously was using "2004".
Scripts used to create container and cause the issue
        New-Bcimage `
            -artifactUrl $artifactUrl `
            -imageName $navimage `
            -isolation process `
            -baseImage $baseImage `
            -includeTestToolkit:$tests -includeTestLibrariesOnly:$tests `
            -skipIfImageAlreadyExists

2024-03-14T07:25:04.1226600Z Generic Tag: <IP_ADDRESS>
2024-03-14T07:25:04.1630572Z Container OS Version: 10.0.17763.5576 (ltsc2019)
2024-03-14T07:25:04.1645309Z Host OS Version: 10.0.19045.4170 (22H2)
2024-03-14T07:25:04.1701450Z WARNING: Host OS and Base Image Container OS doesn't match and process isolation is specified. If you encounter issues, you could try to specify -isolation hyperv
2024-03-14T07:25:04.1709749Z Using process isolation

2024-03-14T07:26:37.1143303Z Step 5/6 : RUN \Run\start.ps1 -installOnly -multitenant -includeTestToolkit -includeTestLibrariesOnly
2024-03-14T07:26:37.3328832Z  ---> Running in 82225614aff6
2024-03-14T07:26:40.4013128Z DockerDo : hcs::CreateComputeSystem 82225614aff6b80974637bd17d8556a3a9486501ceba3d3735105199e0600956: The container
2024-03-14T07:26:40.4014374Z operating system does not match the host operating system.
2024-03-14T07:26:40.4014716Z ExitCode: 1
2024-03-14T07:26:40.4016360Z Commandline: docker build --isolation=process --memory 8G --no-cache --tag navimage:daily-gb.4
2024-03-14T07:26:40.4017087Z c:\bcartifacts.cache\yzxzhwh5.yym
2024-03-14T07:26:40.4018958Z At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.9\ContainerHandling\New-NavImage.ps1:715 char:27
2024-03-14T07:26:40.4020790Z + ...       if (!(DockerDo -command build -parameters @("--isolation=$isola ...
2024-03-14T07:26:40.4021305Z +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-03-14T07:26:40.4021925Z     + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
2024-03-14T07:26:40.4022526Z     + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,DockerDo
2024-03-14T07:26:40.4023071Z
2024-03-14T07:26:40.4984930Z ##[error]PowerShell exited with code '1'.

Full output of scripts
2024-03-14T07:24:39.7258808Z ##[section]Starting: Create Build Image, Daily
2024-03-14T07:24:39.7352967Z ==============================================================================
2024-03-14T07:24:39.7353201Z Task         : PowerShell
2024-03-14T07:24:39.7353297Z Description  : Run a PowerShell script on Linux, macOS, or Windows
2024-03-14T07:24:39.7353538Z Version      : 2.236.2
2024-03-14T07:24:39.7353618Z Author       : Microsoft Corporation
2024-03-14T07:24:39.7353749Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/powershell
2024-03-14T07:24:39.7354080Z ==============================================================================
2024-03-14T07:24:40.5443470Z Generating script.
2024-03-14T07:24:40.5945400Z Formatted command: . 'C:\Agents\Agent1\_work\8\s\Self\.azureDevOps\Scripts\Create-Image.ps1' -bcSelect Daily
2024-03-14T07:24:40.6224605Z ========================== Starting Command Output ===========================
2024-03-14T07:24:40.6444624Z ##[command]"C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'C:\Agents\Agent1\_work\_temp\d87ce9bd-afc9-4031-86f7-6a7c1d905902.ps1'"
2024-03-14T07:24:40.8638939Z ### Artifact country gb ###
2024-03-14T07:24:40.8652398Z ### Artifact version  ###
2024-03-14T07:24:40.8660200Z ### Artifact type sandbox ###
2024-03-14T07:24:40.8667937Z ### Artifact select Daily ###
2024-03-14T07:24:40.8762942Z ### Using Docker image navimage:daily-gb.4 ###
2024-03-14T07:24:40.9175760Z >>> Locking image build  + Global\RunningBCImage
2024-03-14T07:24:41.0463191Z BcContainerHelper version 6.0.9
2024-03-14T07:24:41.3525491Z Setting MicrosoftTelemetryConnectionString =
2024-03-14T07:24:41.4719358Z Running on Windows, PowerShell 5.1.19041.4170
2024-03-14T07:25:03.2402929Z ### Using Artifact  https://bcartifacts.azureedge.net/sandbox/23.5.16502.17362/gb  ###
2024-03-14T07:25:03.5047623Z Untagged: navimagev:22.5.59966.63884-gb
2024-03-14T07:25:03.5088857Z Untagged: navimagev:24.0.16410.17172-gb
2024-03-14T07:25:03.5131935Z ### Running New-Bcimage ###
2024-03-14T07:25:03.6499872Z ### Using base image  mcr.microsoft.com/businesscentral:ltsc2019  ###
2024-03-14T07:25:03.8195935Z navimage:daily-gb.4
2024-03-14T07:25:03.8210172Z Fetching all docker images
2024-03-14T07:25:03.8639140Z Building image navimage:daily-gb.4 based on mcr.microsoft.com/businesscentral:ltsc2019 with https://bcartifacts.azureedge.net/sandbox/23.5.16502.17362/gb
2024-03-14T07:25:03.8646170Z Pulling latest image mcr.microsoft.com/businesscentral:ltsc2019
2024-03-14T07:25:04.0596773Z ltsc2019: Pulling from businesscentral
2024-03-14T07:25:04.0609375Z Digest: sha256:ca49064a275b9e95c8d3a0ae8264a4222cd7597a84dd6d007276151cfe6bebfa
2024-03-14T07:25:04.0617823Z Status: Image is up to date for mcr.microsoft.com/businesscentral:ltsc2019
2024-03-14T07:25:04.0642619Z mcr.microsoft.com/businesscentral:ltsc2019
2024-03-14T07:25:04.1226600Z Generic Tag: <IP_ADDRESS>
2024-03-14T07:25:04.1630572Z Container OS Version: 10.0.17763.5576 (ltsc2019)
2024-03-14T07:25:04.1645309Z Host OS Version: 10.0.19045.4170 (22H2)
2024-03-14T07:25:04.1701450Z WARNING: Host OS and Base Image Container OS doesn't match and process isolation is specified. If you encounter issues, you could try to specify -isolation hyperv
2024-03-14T07:25:04.1709749Z Using process isolation
2024-03-14T07:25:04.1816667Z Files in c:\bcartifacts.cache\yzxzhwh5.yym\my:
2024-03-14T07:25:04.1884640Z Copying Platform Artifacts
2024-03-14T07:25:04.1945727Z c:\bcartifacts.cache\sandbox\23.5.16502.17362\platform
2024-03-14T07:25:09.8804239Z Copying Database
2024-03-14T07:25:12.0200559Z Copying Licensefile
2024-03-14T07:25:12.0338653Z Copying ConfigurationPackages
2024-03-14T07:25:12.0347186Z C:\bcartifacts.cache\sandbox\23.5.16502.17362\gb\ConfigurationPackages
2024-03-14T07:25:12.1108935Z Copying Extensions
2024-03-14T07:25:12.1120664Z C:\bcartifacts.cache\sandbox\23.5.16502.17362\gb\Extensions
2024-03-14T07:25:13.0722937Z Copying Applications.GB
2024-03-14T07:25:13.0731652Z C:\bcartifacts.cache\sandbox\23.5.16502.17362\gb\Applications.GB
2024-03-14T07:25:13.5219223Z c:\bcartifacts.cache\yzxzhwh5.yym
2024-03-14T07:25:31.6093510Z Sending build context to Docker daemon  2.567GB
2024-03-14T07:25:31.6102225Z
2024-03-14T07:25:31.6887038Z Step 1/6 : FROM mcr.microsoft.com/businesscentral:ltsc2019
2024-03-14T07:25:31.6894396Z  ---> 64568c89e98d
2024-03-14T07:25:31.6902752Z Step 2/6 : ENV DatabaseServer=localhost DatabaseInstance=SQLEXPRESS DatabaseName=CRONUS IsBcSandbox=Y artifactUrl=https://bcartifacts.azureedge.net/sandbox/23.5.16502.17362/gb filesOnly=False
2024-03-14T07:25:31.9176364Z  ---> Running in 9fbf1c195d93
2024-03-14T07:25:33.1665717Z  ---> Removed intermediate container 9fbf1c195d93
2024-03-14T07:25:33.1680590Z  ---> 191973ccf1ac
2024-03-14T07:25:33.1692746Z Step 3/6 : COPY my /run/
2024-03-14T07:25:34.4380398Z  ---> d7e320034195
2024-03-14T07:25:34.4391918Z Step 4/6 : COPY NAVDVD /NAVDVD/
2024-03-14T07:26:37.1130444Z  ---> 03bbf76a6031
2024-03-14T07:26:37.1143303Z Step 5/6 : RUN \Run\start.ps1 -installOnly -multitenant -includeTestToolkit -includeTestLibrariesOnly
2024-03-14T07:26:37.3328832Z  ---> Running in 82225614aff6
2024-03-14T07:26:40.4013128Z DockerDo : hcs::CreateComputeSystem 82225614aff6b80974637bd17d8556a3a9486501ceba3d3735105199e0600956: The container
2024-03-14T07:26:40.4014374Z operating system does not match the host operating system.
2024-03-14T07:26:40.4014716Z ExitCode: 1
2024-03-14T07:26:40.4016360Z Commandline: docker build --isolation=process --memory 8G --no-cache --tag navimage:daily-gb.4
2024-03-14T07:26:40.4017087Z c:\bcartifacts.cache\yzxzhwh5.yym
2024-03-14T07:26:40.4018958Z At C:\Program Files\WindowsPowerShell\Modules\BcContainerHelper\6.0.9\ContainerHandling\New-NavImage.ps1:715 char:27
2024-03-14T07:26:40.4020790Z + ...       if (!(DockerDo -command build -parameters @("--isolation=$isola ...
2024-03-14T07:26:40.4021305Z +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-03-14T07:26:40.4021925Z     + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
2024-03-14T07:26:40.4022526Z     + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,DockerDo
2024-03-14T07:26:40.4023071Z
2024-03-14T07:26:40.4984930Z ##[error]PowerShell exited with code '1'.
2024-03-14T07:26:40.5259541Z ##[section]Finishing: Create Build Image, Daily```

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
- does it happen all the time?
- did it use to work?

That is correct.
In order to use Microsoft official images going forward, you will have to use HyperV on Windows 10.
Reason for this is, that I can only build new images for supported OS' - Microsoft policy.
You can however build the generic image for 2004 yourself, by cloning https://github.com/microsoft/nav-docker and running the build.ps1 script in the generic folder.
This will build mygeneric:latest on your machine for the version you specify - and you would have to specify that in your settings file or in the useGenericImageName parameter.
You can also push this to the docker hub to your account and use it from there.
Note that when there are updates to nav-docker - it should be re-built.
Not ideal, but possible.

Okay, I've found that my actual issue is that the Microsoft docker install script doesn't actually turn on Hyper-V despite claiming that it is already turned on. Once it's turned on the provided docker successfully uses Hyper-V to create a real VM to run the image.
So I've discarded the remaining Win10 VM agents and am installing Hyper-V on the old laptops.
Enable-WindowsOptionalFeature -Online -FeatureName "Microsoft-Hyper-V" -All
BTW: Yes a mygeneric image works fine.


TODO: Bump AWX Operator version to 2.1.0

I was able to deploy 2.1.0 / AWX 22.2.0 with this repository as-is, once from upgrading 2.0.1 -> 2.1.0 and the other time by deploying 2.1.0 from the start.

@drlamb
Thanks for providing information! Now I'm testing the latest release and luckily my guide seems works almost as-is, as you've tested. Thanks!


chore(main): release 0.1.1

:robot: I have created a release beep boop
0.1.1 (2023-12-13)
Bug Fixes

config: create config file (9bc9774)

Miscellaneous Chores

release 0.1.0 (cda2c03)
release 0.1.1 (3cd7eb1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/christian-vdz/hassio-mqtt2prometheus-addon/releases/tag/v0.1.1 :sunflower:


Invalid access of discarded

Bug Report
Is you/your team sponsoring this project

[ ] Yes
[x] No

If your team sponsoring this project, please attach here your team lead or who purchased license GitHub login
Minimal reproducible repo
Link here
Current Behavior
A canceled request crashes the service
Expected behavior/code
Canceled requests should not throw errors and crash the service
Environment

Node/npm version: Node 16/npm 8
OS: Windows 11

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.
Note

Project is provided as-is without any support nor warranty
If this issue not related to this project and exists on core of this project, please close issue or not open

add
res.onAborted(() => {
  return false;
});

@Najsar unfortunately the error persists
import nanoexpress from 'nanoexpress';

const app = nanoexpress();

app

.get('/test', async (req, res) => {
  req.onAborted(() => false);

  res.onAborted(() => false);

  await new Promise(resolve => setTimeout(() => resolve(), 5000));

  return res.send('success');
});

app.listen(3000);

or
import nanoexpress from 'nanoexpress';

const app = nanoexpress();

app

.get('/test', async (req, res) => {
  req.onAborted(() => res.send('error'));

  res.onAborted(() => res.send('error'));

  await new Promise(resolve => setTimeout(() => resolve(), 5000));

  return res.send('success');
});

app.listen(3000);

not works


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Fri Mar 25 2016 21:09:58 GMT-0500 (Central Daylight Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\Thomas\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\Thomas\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


Driver: Uart: Add support of 9 bits data length for STM32

Some STM32 MCU (F0, F1, F2, F3, F4, L0, L4) supports USART/UART with 9bits data word length.

Codecov Report

Merging #14831 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14831   +/-   ##
=======================================
  Coverage   52.51%   52.51%
=======================================
  Files         309      309
  Lines       45048    45048
  Branches    10419    10419
=======================================
  Hits        23656    23656
  Misses      16584    16584
  Partials     4808     4808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9c7a4...8c438c2. Read the comment docs.

Hello @erwango
I splitted my changes into 2 commits.

@galak, can we merge this one now?


Update Welcome.md

typo

@dcbrown16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.


windows_task resource: Allow non-system users without password

Minor changes in validations under validate_user_and_password to handle this feature
validate_interactive_setting would no longer be needed
Simple changes in error verbiage
Added test cases
Fixes MSYS-924

Signed-off-by: Nimesh<EMAIL_ADDRESS>Description

Non-System users would only need to provide a password for Non-Interactive tasks
For interactive tasks, they may or may not provide a password
System users always creates non-interactive tasks and password should not be sent

Issues Resolved
#7834
Sub Task
win32-taskscheduler needs to be merged and updated for these changes.
Check List

[x] New functionality includes tests
[x] All tests pass
[x] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Appveyor is failing for an expected reason. As we are now givin a support to interactive property and have added a parameter in set_account_information of win32-taskscheduler.
Once we merge win32-taskscheduler, it would probably get resolved.
Specs are working fine with local changes in win32-taskscheduler gem.


add first example

It looks quite promising, but at the moment it is a bit vague what it is going to do. Make sure to write the introduction very clearly so people will understand the goal (it is always a challenge that more fun examples are harder to follow). Of course, MAP-Elites has to be outlined as well.
There are some things that make your life easier:
sum([f(x) for x in vector]) => sum(f, vector)
any([f(x) for x in vector]) => any(f, vector)
Also some stylistic things: only types have a capital, variables not, so attacker, functions also need to be lower case: battle, create_army etc.
I am curious to see where this is going!

 I really enjoyed the tool you made (might use it later 😄 ).
It's really nicely structured which makes it easy to understand and follow! Maybe just a small remark, but in the Neighbour function you state "adapt the fridgeList so that only ingredients from the removed ingredient are available", is it possible that you mean recipe instead of ingredient?

Hey Ward,
I haven't had breakfast, yet. So your project really made me hungry!
I agree with Ceri-Anne that your project is well-structured. The experimental section is super valuable and adds another layer of interactivity to your notebook. And on top of that, the recipe scraper made experimenting with your notebook super accessible.
For my fridge, which currently also just contains the example ingredients ("chocolate", "potato", "salt", "cheese") your algorithm wants me to drink beer? How would you explain that? If you receive soft money from the alcoholic beverage industry maybe add an acknowledgment to your notebook. 😄✌
From worker 7:    Found chocolate in the ingredient database.
From worker 7:    Found potato in the ingredient database.
From worker 7:    Found salt in the ingredient database.
From worker 7:    Found cheese in the ingredient database.
From worker 7:    Done checking ingredients.
From worker 7:
From worker 7:    The best recipes to make are:
From worker 7:
From worker 7:    Frieten  (Belgian French Fries) : Any["potato", "salt", "oil"]
From worker 7:    Gourmet Belgian Hot Chocolate : Any["milk", "vanilla bean", "chocolate"]
From worker 7:    Stella & Tanqueray Chillin & Sippin.... : Any["beer"]

Joking aside, keep it up!
One minor suggestion: Not sure if you did it on purpose but If you add the doc strings of the functions in the appendix above the function, you will get a nicely formatted documentation.

 I really enjoyed the tool you made (might use it later 😄 ).
It's really nicely structured which makes it easy to understand and follow! Maybe just a small remark, but in the Neighbour function you state "adapt the fridgeList so that only ingredients from the removed ingredient are available", is it possible that you mean recipe instead of ingredient?

Yes that should indeed be recipe! Thanks for the feedback

Hey Ward,
I haven't had breakfast, yet. So your project really made me hungry! I agree with Ceri-Anne that your project is well-structured. The experimental section is super valuable and adds another layer of interactivity to your notebook. And on top of that, the recipe scraper made experimenting with your notebook super accessible.
For my fridge, which currently also just contains the example ingredients ("chocolate", "potato", "salt", "cheese") your algorithm wants me to drink beer? How would you explain that? If you receive soft money from the alcoholic beverage industry maybe add an acknowledgment to your notebook. 😄✌
From worker 7:    Found chocolate in the ingredient database.
From worker 7:    Found potato in the ingredient database.
From worker 7:    Found salt in the ingredient database.
From worker 7:    Found cheese in the ingredient database.
From worker 7:    Done checking ingredients.
From worker 7:
From worker 7:    The best recipes to make are:
From worker 7:
From worker 7:    Frieten  (Belgian French Fries) : Any["potato", "salt", "oil"]
From worker 7:    Gourmet Belgian Hot Chocolate : Any["milk", "vanilla bean", "chocolate"]
From worker 7:    Stella & Tanqueray Chillin & Sippin.... : Any["beer"]

Joking aside, keep it up!
One minor suggestion: Not sure if you did it on purpose, but if you add the doc strings of the functions in the appendix above the function, you will get a nicely formatted documentation.

That is indeed a bit weird! I will surely look into it. Thanks for the feedback!


Fill in some null BA codes using BA names

Fill in a handful of BA codes w/ BA names.
There are two strange things in the PR (imo):

how to grab the "correct" map between codes and names. There are three options:

(my choice) use the cleaned/harvested/encoded plants table to compile the most frequently reported association of codes and names.
build a lil map of names and codes that are known to have missing codes/known names. There aren't that many, but these names could stray so I don't love this:

bac_map = {
     "Hawaiian Electric Co Inc": "HECO",
     "PJM Interconnection, LLC": "PJM",
     "Midcontinent Independent Transmission System Operator, Inc..": "MISO",
     "Duke Energy Progress East": "CPLE",
 }

use the map in CODE_METADATA. I used the BA names as the description column, so we could use this. BUT this is an implied connection and it would not be good to couple these two things and make an implied requirement for future codes/descriptions

Where to do this? I choose after the harvesting process for several reasons. Mostly because this moment is when  we have presumably cleaner data (harvested and encoded). But most practically because these codes and names show up in SO MANY of the input tables, and this is the only moment where they are all in one place.

These are very fair comments! I was a lil bit of a quick draw to push. I updated a lot of docs given your questions and comments. Let me know what you think!

okay @zaneselvans  I think i've addressed everything


fix: Add wait for cache sync for the storage version dropper

Description
Changes proposed in this pull request:

the client.list in the storage version dropper sometimes throws this error "the cache is not started, can not read objects", that's why I added the wait for sync cache so that we wait for the cache to be initialized before we run the dropper.

Related issue(s)
Resolves #1383

@nesmabadr Checkmarx reports potential race conditions on mgr and err objects. Looking at the code, I think the usage of the err object when logging the error seems like a mistake. It has been assigned earlier unrelated to dropping the storage versions.
Regarding mgr, would it be possible to extract the mgr.GetCache().WaitForCacheSync(context.Background()) to before invoking to goroutine and then pass mgr.GetClient() as argument? This may resolve the vulnerability as it also doesn't flag the same usage below on go runKymaMetricsCleanup. Btw., not sure why it hasn't occurred yet but the runKymaMetricsCleanup goroutine may be subject to the "the cache is not started, can not read objects" error as well. So maybe a good idea to anway wait for the cache to sync before invoking any of these.


[RFC]: vLLM plugin system

Motivation.
There is an increasing need to customize vLLM, including:

out-of-tree model registration, where users want to register their model outside of vLLM repo. This is partially fulfilled by https://github.com/vllm-project/vllm/pull/3871 . But later users find that it does not work in distributed setting with ray: https://github.com/vllm-project/vllm/issues/5657
custom executor class, already added in https://github.com/vllm-project/vllm/pull/6557
custom scheduler, requested in https://github.com/vllm-project/vllm/issues/7123
custom tensor parallel implementation, requested in https://github.com/vllm-project/vllm/issues/7124

Usually, the request is to swap out some functions / classes in vLLM, or call some functions before vLLM runs the model. While implementing them in vLLM is not difficult, the maintenaince burden grows.
In order to satisfy the growing need of customization, I propose to introduce vLLM plugin system.
It is inspired by the pytest community, where a plugin is a standalone pypi package, e.g. https://pypi.org/project/pytest-forked/ .
https://github.com/vllm-project/vllm/pull/7130 is a draft implementation, where I added a new env var VLLM_PLUGINS. The way it works, is similar to the operating system's LD_PRELOAD, with a colon-separated list of python modules to import.
One of the most important concern, is to fight against arbitrary code execution risk. When a user serves a model using vLLM, the endpoint user cannot activate the plugin, so this does not suffer from code injection risk. However, there is indeed a risk, if the user runs vLLM in an untrusted environment. In this case:

we require the plugin package name starts with vllm_ , so that vLLM user does not accidentally add irrelevant modules to execute.
we explicitly log the plugin module vLLM is using, so that vLLM user can easily see if any unexpected code is executed.

With these efforts, the security level should be the same as LD_PRELOAD. And since LD_PRELOAD exists for so many years, I think VLLM_PLUGINS should be acceptable in terms of security risk.
Proposed Change.
see https://github.com/vllm-project/vllm/pull/7130 for the draft implementation
Feedback Period.
No response
CC List.
No response
Any Other Things.
No response

This looks like a step in the right direction to me (:
I have 2 questions regarding this:

Currently it seems like it wouldn't really be possible to replace the scheduler implementation, or add the uneven tensor-parallel implementation using these plugins, or at least not in an intuitive way that I can see.
Don't you think it would make more sense to make different types of plugins each focused on a different cause?
For example one plugin type would be a scheduler plugin, another would be a model architecture plugin, and perhaps a few more.
This could come as an addition to your suggestion of "general-purpose" plugins, but in most cases it'd be simpler to implement a well-defined plugin interface instead of a general-purpose one.

I suggest using Python's built in entrypoints to implement plugins, similar to how pytest implements it (see #4769 which I worked on as an example for this), are there any advantages you see with the environment variable approach compared to this approach?

I really believe implementing such plugin system concept could make vLLM an even greater technology, and personally it could solve a lot of problems for me by allowing great modularity and costumization.
I'd be more than happy to help in implementing it (:

Currently it seems like it wouldn't really be possible to replace the scheduler implementation, or add the uneven tensor-parallel implementation using these plugins, or at least not in an intuitive way that I can see.

It might not be easy, but should be possible. By allowing loading a plugin, the plugin has the total control to do anything it wants. In the extreme case, swap the whole vLLM code into another implementation.

For example one plugin type would be a scheduler plugin, another would be a model architecture plugin, and perhaps a few more.

We can consider this as a TODO. It needs to clean up the interface of each components in vLLM, so that users can bring in their implementation more easily.
In the begining, we can reserve the space for them, e.g. use vllm_general_plugin for a general plugin that is blindly executed, and later introduce vllm_scheduler_plugin that is dedicated to replace scheduler.
Currently, we can have vllm_models_plugin to register out-of-tree models, and vllm_executor_plugin to register user-specified executor.

I suggest using Python's built in entrypoints to implement plugins, similar to how pytest implements it

I think this is great! I didn't know it before. It is much better than env var I think. The only concern is, if users installed many plugins for the same component, e.g. scheduler, how can they select the one they want? We might need to design some config file format, to determine which plugins to use.

I think either LD_PRELOAD way or the Python entrypoints ways are proven patterns. At the current experimental stage, I have two concerns:

We should stress that this is experimental feature and the API can change without notice. Therefore, we should make sure the variable names are VLLM_EXPERIMENTAL_PLUGINS etc. Also in any documentation or examples, these are highly subject to change; and any plugins can break across any version of vLLM.
Plugins works because they have a well documented interface that is backward compatible. We cannot guarantee any of that at the current state of the project. Therefore, we should start thinking about what interfaces are exposed and start thinking about which ones to stabilize.

Regarding the exact code being executed, I don't have much concern about security, rather it is how the plugins is being called and invoked. Will it swap in a class implementation for an abstract class, or some function, or insert some callbacks? It does seems like it needs several use cases to prove out and design over time.

It does seems like it needs several use cases to prove out and design over time

agree. so this RFC is just a start to explore how we interact with plugins. There are already 2 usecases now: out-of-tree model registration, and user-specified executor registration.

Plugins works because they have a well documented interface that is backward compatible.

that is the stable state of plugin system. we don't need to guarantee that at the moment. it is the plugin's author's responsibility to keep their plugin up-to-date. and we can see what the community makes out of the plugin, and gradually make some part of the system pluggable with stable API.

we should make sure the variable names are VLLM_EXPERIMENTAL_PLUGINS

I think we can directly call it VLLM_PLUGIN. Although the plugin system is immature for plugin developer, the usage is quite stable for end-users. They will need to install some packages and select them.

Overall I got positive feedback for this RFC.
I will use the entrypoint mechanism mentioned by @NadavShmayo  to collect all the installed plugins, and use VLLM_PLUGIN to control which plugins are loaded.

I see that you have already implemented the general-purpose plugin system, nice!
I implemented a basic version of the model architecture plugin system, which as we discussed I think comes as an addition to this.
Would be great if you could have a look at #7438 and give your feedback.

#7426 finished the framework.
TODOs:

[ ] doc update
[ ] modular plugins for specific purpose

I use sitecustomize and PYTHONPATH to deploy custom models with parallelism. In other words, Python has a plugin system to a certain extent. For security, it's nice that PYTHONPATH must be audited anyway, while we might miss VLLM_PLUGINS unless it's well-documented. In my opinion, PyTest cannot utilize sitecustomize because PyTest and its plugin system should not disturb other packages much. vLLM doesn't have to work with arbitrary packages (for example, since #2155 many dependencies are pinned).


back end for workout summary

back end for workout summary page
-mutations
-queries
-graphql

Mutations and queries for work out summary have been created and added to graphQL.


Add shared tslint config for all packages

Add a tslint config with tslint-config-airbnb preset shared for all packages.
Then add a lint command to be executed by CI.

Closed in ff84a41648ffaab7b06628d3b106d3b0b7e01383.


Improve check.py output readability

Current output:
[ ] Check results checksum
        ./power/server.json + ./power/client.json results checksum values and calculated . content checksum comparison:
 Expected key values are 'power/client.log, ranging/mlperf_log_detail.txt, ranging/mlperf_log_summary.txt, run_1/mlperf_log_detail.txt, run_1/mlperf_log_summary.txt, power/client.json, power/ptd_logs.txt, power/server.log, ranging/spl.txt, run_1/spl.txt',
but got 'power/client.json, power/client.log, power/ptd_logs.txt, ranging/mlperf_log_detail.txt, ranging/mlperf_log_summary.txt, ranging/spl.txt, run_1/mlperf_log_detail.txt, run_1/mlperf_log_summary.txt, run_1/spl.txt'.

Expected output:
Something more readable. E.g. in the example above, the only missed file is power/server.log.

Output after #202 got merged:
[ ] Check results checksum
        ./power/server.json + ./power/client.json content checksum comparison:
 Missing 'power/client.log'


nothing rendered. dom element and scene created

Hi,
i use three.js 0.162.0 within an angular project and added everything as described.
what can i do when nothing of the gizmo is renderered? DOM is created inside the container but nothing is rendered on it.
    const viewportGizmoElement = document.getElementById('viewportGizmo') as any;
    var options = {
      container: viewportGizmoElement,
      size: 100,
    }
    this.viewportGizmo = new ViewportGizmo(this.camera, this.renderer, options);
    this.viewportGizmo.target = this.controls.target;

handles work and camera moves when clicking the invisible axes.

Can you please reproduce the issue here:  https://jsfiddle.net/eovL86hy/1/
Sorry for the delay!

Hello! I've recreated the issue
Please check: https://stackblitz.com/edit/stackblitz-starters-4kcphs?file=src%2Fapp%2Fapp.component.ts,index.js,src%2Fapp%2Fapp.component.html

It's also not showing me anything, I'm using threejs 0.171.0: https://github.com/arx-tools/editor/blob/52cf20550d0ce5b35474f108e2e1639daeb2b8eb/src/index.ts

Sorry for the delay,
This line should fix the issue as long as the canvas fits the entire element
container: canvas.parentElement as HTMLElement


God damn you, guys, put somewhere the list of hotkeys.

macOS version:
Kap version:
Steps to reproduce

install the app
give the permission to read the screen
push the button to start record
make the record
realize that you don't have any info about how to stop the record.
kill the process
Google the "mac kap hotkeys" to figure out that developers were too busy to put this info somewhere.

Current behaviour
Expected behaviour
Workaround

Three years later and I found this discussion because I can’t find the hotkeys. Can anyone point me in the right direction?


Fix the peridnum variable

The PERIDNUM variable looks like:<PHONE_NUMBER>139642000000
This is too big to fit into a 64bit integer. Therefore, to make it work I've opted to ignore the errors which makes it stay as a string.

Hi @Rambatino, thanks for the PR! Setting errors to "ignore" makes sense to me. Since you forked I added a lint and test workflow (something I had previously only been running locally). If you could sync your fork I think that should prompt it to run (or at least, prompt me to approve it to run).

Hey I had some time so I went ahead and made the small change and added an accompanying test. (Also added an explanatory comment and linked to this PR for reference.) Going to go ahead and close this PR. Thanks again for raising and let me know if you have any further thoughts.


Crashes

Weights and Biases version: latest
Python version: 2.7
Operating System: ubuntu

Description
I installed wandb and typed wandb init
Traceback (most recent call last):
File "/home/l2k/.local/bin/wandb", line 7, in
from wandb.cli import cli
File "/home/l2k/.local/lib/python2.7/site-packages/wandb/init.py", line 8, in
from .sync import Sync
File "/home/l2k/.local/lib/python2.7/site-packages/wandb/sync.py", line 3, in
from watchdog.observers import Observer
ImportError: No module named watchdog.observers
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Ok I did:
pip install watchdog
pip install sets
now I get
Traceback (most recent call last):
File "/Users/lukasbiewald/.pyenv/versions/3.5.2/bin/wandb", line 7, in
from wandb.cli import cli
File "/Users/lukasbiewald/.pyenv/versions/3.5.2/lib/python3.5/site-packages/wandb/cli.py", line 4, in
from sets import Set
ImportError: cannot import name 'Set'

I guess Set was deprecated in python 3
http://stackoverflow.com/questions/14855110/importing-sets-in-python

Fixed in 0.4.1


IVAN version number on the high score server

Do you know if it will be possible to add the IVAN version number to the high score server page? It means that players will be able to distinguish between victories over successive releases of the game.

Yeah I'm going to add this feature at some point. It's pretty high on the todo list. 👍

Actually I just implemented it, should work now!


Device detection should be performed in parallel

Each device should be detected in the dedicated thread, as detection operations take a long time to complete.

Done.


Improve article 2310.01693. PGFPLot produces catastrophic failure

This file: https://ar5iv.labs.arxiv.org/html/2310.01693 fails to render completely. I have seen some other issues with pgfplots, most related to a infinite loop. This does not seem the case, it looks a totally different error.
Exact location of issue
fig/test.tex :
\pgfplotsset{style a/.style={error bars/.cd, y dir=both, y explicit}}
\pgfplotsset{
	/pgfplots/bar cycle list/.style={
		/pgfplots/cycle list={
			{blue,fill=blue!30!white,mark=none},
			{red,fill=red!30!white,mark=none},
			{brown!60!black,fill=brown!30!white,mark=none},
			{black,fill=black!30!white,mark=none},
			{cyan,fill=cyan!30!white,mark=none},
			{orange,fill=orange!30!white,mark=none},
		},
		},
		}

\begin{tikzpicture}
	\begin{axis} [
			ybar,
			symbolic x coords={Small, Medium, Large, XL},
			xtick=data,
			legend pos=south east,
			legend cell align=left,
			enlarge x limits=0.25,
			bar width=4pt,
            xlabel=Model size,
            ylabel=MAUVE,
            height=4cm,
            width=0.6\textwidth,
            legend pos=outer north east,
		]
		% \addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/Bottleneck-aware.csv};
		\addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/BA_Eta.csv};
		\addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/Eta.csv};
		\addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/Nucleus.csv};
		\addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/BA_Epsilon.csv};
		\addplot +[style a] table [col sep=comma, x=Size, y=Mean, y error=SEM] {data/test/Epsilon.csv};
		\legend{BA-$\eta$, $\eta$, Nucleus, BA-$\epsilon$, $\epsilon$}
	\end{axis}
\end{tikzpicture}

Problem details
The log outputs:
(Processing content /dev/shm/KRChnbu7gQ/fig/test.tex...
Package pgfplots info on input line 29: Using 'lua backend=false' for axis: x coord trafo unsupported.
PGFPlots: reading {"data/test/BA_Eta.csv"}
PGFPlots: reading {"data/test/Eta.csv"}
PGFPlots: reading {"data/test/Nucleus.csv"}
PGFPlots: reading {"data/test/BA_Epsilon.csv"}
PGFPlots: reading {"data/test/Epsilon.csv"}
Warning:perl:warn Argument "1Y9.374214214840683e1]" isn't numeric in numeric eq (==)
 at test.tex; line 37 col 0 - line 37 col 11
 at /usr/local/share/perl/5.34.0/LaTeXML/Package/pgfmath.code.tex.ltxml line 348, <$IN> line 37
 In<EMAIL_ADDRESS>/usr/local/share/perl/5.34.0/LaTeXML/Package/pgfmath.code.tex.ltxml; line 364
Error:expected:Until: cs: Missing argument Until: cs: for Core::Definition::Expandable[\tikz@parse@coordinatesystem Until:(Until: cs:Until:)]
 at test.tex; line 39 col 0 - line 39 col 0
 Ended at test.tex; line 39 col 0 - line 39 col 0
 Next token is ...

@dginev , you seem to be tackling some pgfplots problems. Hope this helps! :)

Thanks for the report! As you say, this could be a useful test to keep in mind when testing latexml enhancements for pgfplots.
Two additions to the issue: forest.sty and linguex.sty are reported as missing packages in the log. Possibly those are separate enhancements from the pgfplots issue, but bookkeeping for completeness.

Quick update here: if we disable the customizations in pgfutil-common.tex.ltxml for \pgfutil@in@ and \ifpgfutil@in@ the reason for the Fatal error is addressed, and the article converts to a healthy Warning status.
There are some other issues to address (a curious --0.5 offender in pgfmath, and a vertical overflow in height for Figure 1), and the missing files I mentioned in the previous comment.
But we can resolve the Fatal with very little pain it looks like.

"nightly ar5iv" is not really the timescale we are working on - I am afraid we are not yet in a position to rerender articles on demand at all, let alone nightly. Also our team is small, so most nights there are no meaningful changes for the vast majority of articles.
The commits I mentioned are not yet in latexml proper, the PR there is a draft, which will likely get merged by the end of this month. We have a scheduled v0.8.8 release of latexml soon after, which we have been wrapping up since summer.
Once we have v0.8.8 I will reconvert the entire corpus and sync up with the live ar5iv site, then walk issues which have been resolved and close them. So you won't see the improvement until at least early 2024, as a full rerun on our current hardware takes about 3 weeks of runtime.
What can be done overnight - naturally - is to install a local latexml at a newly changed commit, then reconvert a specific article locally. That is one of the reasons I made ar5ivist, so that people who don't want to wait on ar5iv updates have an easy alternative course of action.

"nightly ar5iv" is not really the timescale we are working on - I am afraid we are not yet in a position to rerender articles on demand at all, let alone nightly. Also our team is small, so most nights there are no meaningful changes for the vast majority of articles.
The commits I mentioned are not yet in latexml proper, the PR there is a draft, which will likely get merged by the end of this month. We have a scheduled v0.8.8 release of latexml soon after, which we have been wrapping up since summer.
Once we have v0.8.8 I will reconvert the entire corpus and sync up with the live ar5iv site, then walk issues which have been resolved and close them. So you won't see the improvement until at least early 2024, as a full rerun on our current hardware takes about 3 weeks of runtime.
What can be done overnight - naturally - is to install a local latexml at a newly changed commit, then reconvert a specific article locally. That is one of the reasons I made ar5ivist, so that people who don't want to wait on ar5iv updates have an easy alternative course of action.

Oh thanks! I will test my latex locally :).  This should be part of the future of arXiv!! Keep up the good work :)

This should be part of the future of arXiv!!

Well, that's the good news - it likely is! Keep your eyes open for an announcement soon, as ar5iv may be sunset when arXiv itself starts providing HTML in-house. Currently tracked at:
https://info.arxiv.org/about/accessible_HTML.html
On our end, we will keep pushing for 100% conversion coverage, since we are at 75% successful conversions today.

This article has healthy HTML with the latest ar5iv update to latexml v0.8.8.
One remaining issue is sizing of the resulting SVG figure in the Introduction, which has a pathologically large height of 22,000+
The rest of the article is still available, but one has to scroll for quite some time to reach it.


Asteroids game as a separate new feature is created for issue #27. game made using pygame is done in its own file with no dependency on other issues

Issue #27 is closed after this pull.
Asteroids fits the retro feel that other games in the repo have. Simplistic vector inspired graphics and 5 different asteroids. Bullets are shot from the the users and asteroids hit split in two.  Option to go back to main menu is implemented as well as score stored in a text file. Stats page will depend on this. 0 changes have been made so far to the main menu or any file outside of the new asteroids.py. Followed structure of snake game. Resource folder is made to hold asteroids images.

Thanks for the suggestions!  I'm not used to python so they were very helpful.  I've implemented those changes and removed all code smells that sonarcloud detected. The code is now easier to understand and change. Expanding the game by adding larger asteroids can now be done by updating the "max_size_asteroid" and "number_asteroids" variables, rather than dealing with magic numbers.


Customize Data Rows

Hi, is there a way to add custom styling to the table data rows similar to the headerLabelStyle prop?

For now there's no such prop however you can highlight the row by sending specific property inside the data. Please have a look at the docs for this.


Update dx-graphics-hlsl-to-load.md

Misleading description of input parameters.
For example in the description of the function "GetDimensions"
we have a template type of an input variable, that can be changed amid parameters.
https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-to-getdimensions
But in the current function ( I am speaking about "Load") is said, that each parameter has type int.
And when you scroll down the page, you can observe, that objects of different types also accept
different types of parameters

@LuridHound : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@LuridHound : Thanks for your contribution! The author(s) have been notified to review your proposed change.


first pixel is wrong with ringWidth=1 (possible rounding issue)

I changed from CGPoint(x: x, y: y) to CGPoint(x: x + 1, y: y) in the MKGradientGenerator.gradientImage() function:
// after
let c = pixelDataForGradient(type, colors: [colors, colors2], locations: [locations, locations2], startPoints: [startPoint, startPoint2], endPoints: [endPoint, endPoint2], point: CGPoint(x: x + 1, y: y), size: CGSize(width: w, height: h))

// before
let c = pixelDataForGradient(type, colors: [colors, colors2], locations: [locations, locations2], startPoints: [startPoint, startPoint2], endPoints: [endPoint, endPoint2], point: CGPoint(x: x, y: y), size: CGSize(width: w, height: h))

My setup:
ring.startColor = UIColor(hex6: 0xFF0000)
ring.endColor = UIColor(hex6: 0x00FF00)
ring.backgroundRingColor = UIColor(hex6: 0x000000)
ring.ringWidth = 1
ring.shadowOpacity = 0
ring.progress = 0.75
ring.style = .square

I use:

Xcode 8.3.2
MKRingProgressView commit c2db5129293d0ff990c0e7052ee0f708d8dcc8d7

@neoneye this actually happens because of the quality of generated gradient image being reduced by default for better performance.
You can try setting ring.gradientImageScale = UIScreen.main.scale - it will generate high res backdrop gradient that should precisely match a small-width ring. This shouldn't have any performance problems for small rings anyway.
Let me know if it helps!

It works. I just tried it. Thank you @maxkonovalov

@neoneye you are welcome!


Handle datastores missing in the datatore cache and special chars in datastore names.

See issue #1116 for the root cause, there are two issues, one triggering the   ##other,

Issue #1 - The VM used in the test was located on a datastore "local-0 (11)", the mkdir command in vmdk_ops.py:get_vol_path() fails with the space and the '(' and ')' chars in the datastore name. This is fixed in get_vol_path().

Issue #2 - (1) opens up another issue. In vmdk_utils.py:get_datastore_name() the given datastore isn't found but the empty list is accessed and causes the exception.

The change handles (1) and (2) by allowing vmdk_utils.py:get_datastore_name() to return None if a datastore isn't found. The same scenario may happen where a datastore is temprarily inaccessible and hence not included in the in-memory datastore list. A subsequent request for the datastore name can cause the exception.

To handle the None return from vmdk_utils.py:get_datastore_name() changes are done in places where this function is called to handle the None return value.

Tests:

WIth these fixes, tested with a datastore named "bigone (1)" and no issues.

04/03/17 12:13:37 1177180 [Thread-1] [DEBUG  ] Running cmd /usr/lib/vmware/osfs/bin/osfs-mkdir -n  '/vmfs/volumes/bigone (1)/dockvols' <---------
04/03/17 12:13:37 1177180 [Thread-1] [INFO   ] Created /vmfs/volumes/bigone (1)/dockvols
04/03/17 12:13:37 1177180 [Thread-1] [DEBUG  ] Running cmd /bin/mkdir '/vmfs/volumes/bigone (1)/dockvols/11111111-1111-1111-1111-111111111111' <----------
04/03/17 12:13:37 1177180 [Thread-1] [INFO   ] Symlink /vmfs/volumes/bigone (1)/dockvols/_DEFAULT is created to point to path /vmfs/volumes/bigone (1)/dockvols/11111111-1111-1111-1111-111111111111
04/03/17 12:13:37 1177180 [Thread-1] [INFO   ] Created /vmfs/volumes/bigone (1)/dockvols/11111111-1111-1111-1111-111111111111

Tested a scenario where a datastore isn't on the datastore list, but get_datastore_name is called with the same datastore name.

Without fix:
04/03/17 06:58:09 1162246 [Thread-1] [ERROR  ] Unhandled Exception:
Traceback (most recent call last):
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 1513, in execRequestThread
opts=opts)
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 804, in executeRequest
vm_datastore = get_datastore_name(vm_datastore_url)
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 778, in get_datastore_name
datastore_name = vmdk_utils.get_datastore_name(datastore_url)
File "/usr/lib/vmware/vmdkops/Python/vmdk_utils.py", line 359, in get_datastore_name
return res[0]
IndexError: list index out of range
04/03/17 06:58:09 1162246 [Thread-2] [ERROR  ] Unhandled Exception:
Traceback (most recent call last):
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 1513, in execRequestThread
opts=opts)
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 804, in executeRequest
vm_datastore = get_datastore_name(vm_datastore_url)
File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 778, in get_datastore_name
datastore_name = vmdk_utils.get_datastore_name(datastore_url)
File "/usr/lib/vmware/vmdkops/Python/vmdk_utils.py", line 359, in get_datastore_name
return res[0]
IndexError: list index out of range
With fix:
administrator@hte-1s-eng-dhcp98:~/vpl-ut/docker-volume-vsphere$ docker volume create --driver=vsphere --name=TestVol1 -o size=400mb
Error response from daemon: create TestVol1: VolumeDriver.Create: Invalid datastore 'None'.
Known datastores: datastore1.

@govint You need to rebase and resolve conflicts.

I'm closing this one for now and reopen once #1155 is merged. The same code is modified in #1155 and I need to rework the logic if any based on those changes.

@govint We have customer already running into this issue. #1155 is much different in scope. Also, there are pending comments on this PR. Can you please address comments, resolve conflicts and get this merged asap.

Failing when there is a space in a name should be done asap regardless of other fixes , IMO

CI is failing as service isn't coming up for almost 10 - 20 secs when vmdk_ops_test.py is started.,
04/11/17 11:41:39 106779 [photon.vmfs-datastore1._DEFAULT.dockerVol_1491910877] [INFO   ] executeRequest 'remove' completed with ret=None
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Checking DB mode for /tmp/test-auth.db...
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:44 107506 [MainThread] [INFO   ] Auth DB /tmp/test-auth.db is missing, allowing all access
04/11/17 11:41:45 107512 [MainThread] [INFO   ] Running tests. Directory used: /vmfs/volumes/datastore1/dockvols
04/11/17 11:41:45 107520 [MainThread] [INFO   ] Connecting to the local Service Instance as 'dcui'
04/11/17 11:41:45 107528 [MainThread] [INFO   ] Connecting to the local Service Instance as 'dcui'
04/11/17 11:41:46 107528 [MainThread] [INFO   ] Checking DB mode for /etc/vmware/vmdkops/auth-db...
04/11/17 11:41:46 107528 [MainThread] [INFO   ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:46 107528 [MainThread] [INFO   ] Auth DB /etc/vmware/vmdkops/auth-db is missing, allowing all access
04/11/17 11:41:46 106779 [MainThread] [WARNING] Received signal num: 10, restarting.
04/11/17 11:41:46 106779 [MainThread] [WARNING] Operations in flight will be terminated
04/11/17 11:41:46 106779 [MainThread] [INFO   ] ==== Starting vmdkops service pid=106779 ====
04/11/17 11:41:46 106779 [MainThread] [INFO   ] Loading VMCI server lib.
04/11/17 11:41:46 106779 [MainThread] [INFO   ] Connecting to the local Service Instance as 'dcui'
04/11/17 11:41:47 107512 [MainThread] [INFO   ] Checking DB mode for /etc/vmware/vmdkops/auth-db...
04/11/17 11:41:47 107512 [MainThread] [INFO   ] Config DB exists and has modifications, mode SingleNode
04/11/17 11:41:52 107512 [MainThread] [INFO   ] datacenter='vim.Datacenter:ha-datacenter' vm_folder='vim.Folder:ha-folder-vm' hosts=(vim.ManagedEntity) [
'vim.ComputeResource:ha-compute-res'
] resource_pool='vim.ResourcePool:ha-root-pool'

CI is failing as service isn't coming up for almost 10 - 20 secs when vmdk_ops_test.py is started.,

@govint Where is 10-20Secs delay?
@shuklanirdesh82 Can you please check CI run why there is "connection closed" error.

Sorry, its just over a 10 second delay. Test-esx started at this time,
=> Running target test-esx Tue Apr 11 11:41:42 UTC 2017 <-------
Running unit tests in /tmp/vmdk_ops_unittest5002/vmdk_ops_test.py...
Creating new DB at /etc/vmware/vmdkops/auth-db
...........Connection to <IP_ADDRESS> closed by remote host.  <-------
make[2]: *** [test-esx] Error 255
make[1]: *** [test-esx] Error 2
make: *** [test-esx] Error 2
=> Build + Test not successful Tue Apr 11 11:42:49 UTC 2017 <--------- Test completed with error.
ESX service comes up after this time,
....
04/11/17 11:41:46 107528 [MainThread] [INFO ] Checking DB mode for /etc/vmware/vmdkops/auth-db...
04/11/17 11:41:46 107528 [MainThread] [INFO ] Config DB does not exist. mode NotConfigured
04/11/17 11:41:46 107528 [MainThread] [INFO ] Auth DB /etc/vmware/vmdkops/auth-db is missing, allowing all access
04/11/17 11:41:46 106779 [MainThread] [WARNING] Received signal num: 10, restarting.
04/11/17 11:41:46 106779 [MainThread] [WARNING] Operations in flight will be terminated
04/11/17 11:41:46 106779 [MainThread] [INFO ] ==== Starting vmdkops service pid=106779 ====
04/11/17 11:41:46 106779 [MainThread] [INFO ] Loading VMCI server lib.
04/11/17 11:41:46 106779 [MainThread] [INFO ] Connecting to the local Service Instance as 'dcui'
04/11/17 11:41:47 107512 [MainThread] [INFO ] Checking DB mode for /etc/vmware/vmdkops/auth-db...
04/11/17 11:41:47 107512 [MainThread] [INFO ] Config DB exists and has modifications, mode SingleNode
04/11/17 11:41:52 107512 [MainThread] [INFO ] datacenter='vim.Datacenter:ha-datacenter' vm_folder='vim.Folder:ha-folder-vm' hosts=(vim.ManagedEntity) [
'vim.ComputeResource:ha-compute-res'
] resource_pool='vim.ResourcePool:ha-root-pool'

The code change looks good to me. Will give LGTM when CI passes

https://github.com/vmware/docker-volume-vsphere/pull/1140#issuecomment-293286864
@shuklanirdesh82 Can you please check CI run why there is "connection closed" error.

As we are using snapshot, the esx vm state was gone. I had checked sshd connection and esx VM has sufficient configuration.
FYI:Restarted the failed run and it passed.

I haven't changed the DS name during the test, this is the CI run that was failing.
Can I get approval to submit this change as CI also has passed?

If there was no change DS during the run, then the fix is for a symptom, not root cause. I  think we should merge the 'spaces' fix, and get the race fixed before  deciding on merging the rest .


GH-20339: [C++] Add residual filter support to swiss join

Rationale for this change
Add residual filter support to swiss join.

What changes are included in this PR?

Added class JoinResidualFilter as a centralized structure to evaluate residual filter in swiss join. It has various flavors of filtering for various join types. Zero-overhead is guaranteed for trivial filters (literal true and sometimes literal false/null). More detailed explanation in code comments.
Tuned the structure of swiss join main body (JoinProbeProcessor::OnNextBatch) to better cope with JoinResidualFilter calls.

Are these changes tested?

Legacy UTs (HashJoin.Random, HashJoin.ResidualFilter and HashJoin.TrivialResidualFilter) cover part of this change. New fine-grained residual filter cases added as well.
Are there any user-facing changes?
No.

Closes: #20339

@zanmato1984 would it be possible to add some test cases?

@zanmato1984 would it be possible to add some test cases?

Yes, I am working on that.

@zanmato1984 I will completely review once the test cases are there.

Hi @vibhatha , I've updated the tests and the PR is ready for review. PTAL. Thanks.
cc @westonpace

Hi @vibhatha , did you have a chance to take a look? Thanks.

@zanmato1984 will take a look. Sorry about the delay.

@zanmato1984 I have added a few comments, though I need more time to fully review the core change to the join. Test cases seems to be fine to me, but I will checkout and validate it again.

Thanks a lot @vibhatha . Reviewing something complex as hash join is even more harder than implementing it. Really appreciate that. Let me know if there is anything I can do to help on your review.

Thanks a lot @zanmato1984, I will keep you posted.

I've also added some benchmarks (w/o touching files in the original PR) to justify this PR perf-wise (I've been curious myself). Swiss join using residual filter still outperforms the legacy implementation by 2x to 4x.
Here attached the detailed benchmarking results.
For trivial filter:
Run on (16 X 2400 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB
  L1 Instruction 32 KiB
  L2 Unified 256 KiB (x8)
  L3 Unified 16384 KiB
Load Average: 2.98, 2.39, 2.09
------------------------------------------------------------------------------------------------------------------------------------------
Benchmark                                                                                Time             CPU   Iterations UserCounters...

 Thanks.

Hi @westonpace , would you kindly help on reviewing this? Appreciate it!

This appears to be well written, documented, and tested. Thank you. I don't really know the swiss join internals thoroughly enough to validate the logic here or to offer performance advice and my C++ is already getting rusty.
The tests, API, etc. all look correct to me. It might be nice to have a unit test covering the multiple-batches case. I think it is covered implicitly by your benchmark but those aren't run as often.

Thanks a lot for reviewing. Really appreciate it!
I think the current HashJoin_Random already has pretty good coverage in terms of multi-batch-ness,
https://github.com/apache/arrow/blob/c6f20a2348b3336f2ceff5b245e5eb10db7f8ce3/cpp/src/arrow/acero/hash_join_node_test.cc#L1112-L1136
though the pattern is rather fixed, i.e., l_key = r_key. Do you think we still need the multi-batch cases with more extensive filter patterns?

I tried to rebase and get things messy. Let me fix my branch first. Sorry for the trouble, guys :(

Hi @westonpace , I've addressed the comments you previously left except one thing I'm uncertain about in my last post. Would you please take a look again? Thanks!


Update dependencies

Hi,
I updated the dependencies, so the plugin is working with the latest version of the esbuild package.
BTW thanks for this plugin, saved me a lot of time :smile:

0.4.0 has been released with updated dependencies :-)


fix userland repo links

There was a point at which repos-using-electron was omitting all those foo_bar_baz_url properties that are returned by the GitHub API, but now those properties (though largely redundant) are retained, because having them doesn't really hurt anything.
So... some repos are missing htmlUrl. This PR works around that by constructing the repo URL with fullName, a property which every repo is guaranteed to have.
Also opened https://github.com/electron/repos-using-electron/issues/13 as a reminder to eventually fix the data at the source.
Thanks to @pfrazee for reporting.

cc @bcomnes, a bystander.

cheers
On Wed, Dec 21, 2016 at 1:50 PM, Zeke Sikelianos<EMAIL_ADDRESS>wrote:

cc @bcomnes https://github.com/bcomnes, a bystander.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/electron/electron.atom.io/pull/637#issuecomment-268621939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU_1JT839Pkkypr5Vbf8RBYz4mcbBks5rKYMYgaJpZM4LTTwg
.

Woohoo!

Working: http://electron.atom.io/userland/starred_apps?q=browser

@zeke not a big issue, but beaker is still listed under pfrazee when it should be under the beakerbrowser org. Is there some metadata I need to update somewhere?

@pfrazee I just need to rerun the collection scripts in https://github.com/electron/repos-using-electron and generate new reports in https://github.com/electron/electron-userland-reports
I'll keep you posted on that.

cool, thanks. I love this userland page. The metrics are great
On Wed, Dec 21, 2016 at 4:26 PM, Zeke Sikelianos<EMAIL_ADDRESS>wrote:

@pfrazee https://github.com/pfrazee I just need to rerun the collection
scripts in https://github.com/electron/repos-using-electron and generate
new reports in https://github.com/electron/electron-userland-reports
I'll keep you posted on that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/electron/electron.atom.io/pull/637#issuecomment-268659608,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhUzQmRll3aRp4FkmPkHkEFsja0Vxsks5rKaekgaJpZM4LTTwg
.


Runtime error

I was trying to make a deep fake.
First it gave a message that vox-cpk.pth.tar file was missing. But it was already there in my drive.
After that its showing this message. I am.not a coder. Please help?
Also, thank you for sharing this code with us
RuntimeError                              Traceback (most recent call last)
 in ()
1 from demo import load_checkpoints
2 generator, kp_detector = load_checkpoints(config_path='config/vox-256.yaml',
----> 3                             checkpoint_path='/content/gdrive/My Drive/first-order-motion-model/vox-cpk.pth.tar')
10 frames
/usr/local/lib/python3.6/dist-packages/torch/cuda/init.py in _lazy_init()
188             raise AssertionError(
189                 "libcudart functions unavailable. It looks like you have a broken build?")
--> 190         torch._C._cuda_init()
191         # Some of the queued calls may reentrantly call _lazy_init();
192         # we need to just return without initializing in that case.
RuntimeError: cuda runtime error (100) : no CUDA-capable device is detected at /pytorch/aten/src/THC/THCGeneral.cpp:47

This is the error message i get even though i have both tar files in google drives directory properly named.
/usr/local/lib/python3.6/dist-packages/torch/serialization.py in init(self, name, mode)
208 class _open_file(_opener):
209     def init(self, name, mode):
--> 210         super(_open_file, self).init(open(name, mode))
211
212     def exit(self, *args):
FileNotFoundError: [Errno 2] No such file or directory: '/content/gdrive/My Drive/first-order-motion-model/vox-cpk.pth.tar