[SP-2596] - Backport of PDI-15013 - Create zip files runs successfully with wrong Source path (6.1 Suite)

fail on non-existing path
in JobEntryZipFile, remove useless assignments (highlighted by Intelij)
add tests
(cherry-picked from ef893f58535aa489e7c959f1c23ec06ae7f3c811)

@brosander, review it please. This is a backport of https://github.com/pentaho/pentaho-kettle/pull/2338

http://<IP_ADDRESS>:8080/job/wingman/17/

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dpentaho.coding.standards.version=1.0.4 -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/zipfile/JobEntryZipFile.java
engine/test-src/org/pentaho/di/job/entries/zipfile/JobEntryZipFileIT.java
Unit test coverage change:
org.pentaho.di.core.lifecycle.KettleLifecycleSupport:

Branch Change :  + 8.33%
Complexity Change :  + 9.09%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Complexity Change :  + .10%
Instruction Change :  + .31%
Line Change :  + .39%
Method Change : -1.57%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 2.95%

org.pentaho.di.trans.Trans:

Branch Change : -.10%
Complexity Change : -.14%
Instruction Change : -.09%
Line Change : -.11%

Integration test coverage change:
org.pentaho.di.core.gui.JobTracker:

Branch Change :  + 6.25%
Complexity Change :  + 3.33%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Branch Change :  + 18.75%
Complexity Change :  + 4.66%
Instruction Change :  + 15.32%
Line Change :  + 24.41%
Method Change :  + 10.20%

org.pentaho.di.job.entry.JobEntryBase:

Complexity Change :  + .73%
Instruction Change :  + .71%
Line Change :  + .91%
Method Change :  + .80%

org.pentaho.di.job.Job:

Branch Change :  + 2.00%
Complexity Change :  + 2.66%
Instruction Change :  + 1.50%
Line Change :  + 1.53%
Method Change :  + 1.45%

org.pentaho.di.workarounds.BufferedOutputStreamWithCloseDetection:

Branch Change :  + 50.00%
Complexity Change :  + 66.67%
Instruction Change :  + 84.62%
Line Change :  + 90.91%
Method Change :  + 100.00%

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/engine/src/org/pentaho/di/job/entries/zipfile/JobEntryZipFile.java

Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.AbstractFileValidator.putVariableSpace. at Line: 25
Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.AndValidator.putValidators. at Line: 26
Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.FileDoesNotExistValidator.putFailIfExists. at Line: 27
Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.JobEntryValidatorUtils.andValidator. at Line: 28
Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.JobEntryValidatorUtils.fileDoesNotExistValidator. at Line: 29
Message: Using a static member import should be avoided - org.pentaho.di.job.entry.validator.JobEntryValidatorUtils.notBlankValidator. at Line: 30

@brosander, review it please

@akhayrutdinov seeing checkstyle errors

@brosander, I resolved them. Mind reviewing once again please?

http://<IP_ADDRESS>:8080/job/wingman/30/

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dpentaho.coding.standards.version=1.0.4 -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/zipfile/JobEntryZipFile.java
engine/test-src/org/pentaho/di/job/entries/zipfile/JobEntryZipFileIT.java
Newly Broken Tests:
org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.repositorySerialization:
java.lang.RuntimeException
java.lang.RuntimeException: Error validating dateFormatLocale
	at org.pentaho.di.job.entry.loadSave.LoadSaveBase.validateLoadedMeta(LoadSaveBase.java:128)
	at org.pentaho.di.job.entry.loadSave.TransStepLoadSaveTester.testRepoRoundTrip(TransStepLoadSaveTester.java:79)
	at org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest.repositorySerialization(TextFileInputMetaLoadSaveTest.java:162)
Caused by: org.pentaho.di.core.exception.KettleException:
Attribute dateFormatLocale started

Unit test coverage change:
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.job.entries.sql.JobEntrySQL:

Instruction Change : -1.64%
Line Change : -1.97%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Complexity Change :  + .10%
Instruction Change :  + .31%
Line Change :  + .39%
Method Change : -1.57%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 2.95%

org.pentaho.di.trans.step.StepMeta:

Instruction Change :  + .19%
Line Change :  + .27%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta:

Instruction Change : -.08%

org.pentaho.di.trans.steps.randomvalue.RandomValueMeta:

Branch Change :  + 2.17%
Complexity Change :  + 2.17%
Instruction Change :  + .15%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Instruction Change :  + .18%

Integration test coverage change:
org.pentaho.di.core.gui.JobTracker:

Branch Change :  + 6.25%
Complexity Change :  + 3.33%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Branch Change :  + 18.75%
Complexity Change :  + 4.66%
Instruction Change :  + 15.32%
Line Change :  + 24.41%
Method Change :  + 10.20%

org.pentaho.di.job.entry.JobEntryBase:

Complexity Change :  + .73%
Instruction Change :  + .71%
Line Change :  + .91%
Method Change :  + .80%

org.pentaho.di.job.Job:

Branch Change :  + 2.00%
Complexity Change :  + 2.66%
Instruction Change :  + 1.50%
Line Change :  + 1.53%
Method Change :  + 1.45%

org.pentaho.di.workarounds.BufferedOutputStreamWithCloseDetection:

Branch Change :  + 50.00%
Complexity Change :  + 66.67%
Instruction Change :  + 84.62%
Line Change :  + 90.91%
Method Change :  + 100.00%

http://<IP_ADDRESS>:8080/job/wingman/32/

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dpentaho.coding.standards.version=1.0.4 -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/job/entries/zipfile/JobEntryZipFile.java
engine/test-src/org/pentaho/di/job/entries/zipfile/JobEntryZipFileIT.java
Unit test coverage change:
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Complexity Change :  + .10%
Instruction Change :  + .31%
Line Change :  + .39%
Method Change : -1.57%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 2.95%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

Instruction Change : -.07%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Instruction Change :  + .18%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta:

Branch Change : -.53%

Integration test coverage change:
org.pentaho.di.core.gui.JobTracker:

Branch Change :  + 6.25%
Complexity Change :  + 3.33%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Branch Change :  + 18.75%
Complexity Change :  + 4.66%
Instruction Change :  + 15.32%
Line Change :  + 24.41%
Method Change :  + 10.20%

org.pentaho.di.job.entry.JobEntryBase:

Complexity Change :  + .73%
Instruction Change :  + .71%
Line Change :  + .91%
Method Change :  + .80%

org.pentaho.di.job.Job:

Branch Change :  + 2.00%
Complexity Change :  + 2.66%
Instruction Change :  + 1.50%
Line Change :  + 1.53%
Method Change :  + 1.45%

org.pentaho.di.workarounds.BufferedOutputStreamWithCloseDetection:

Branch Change :  + 50.00%
Complexity Change :  + 66.67%
Instruction Change :  + 84.62%
Line Change :  + 90.91%
Method Change :  + 100.00%


Crash in dart migrate

Ran dart migrate in the root of package:quiver at 35f6d18fe989f92314210c20e3a2636cb90ba4ad.
Dart SDK version: 2.11.0-260.0.dev (dev) (Mon Oct 26 03:52:00 2020 -0700) on "linux_x64"
Expected behaviour: runs migration and hands me a URL for the tool service.
Actual behaviour:
Analyzing project...
[----------------------------------------------------------------------------------------------------------------/]No analysis issues found.

Generating migration suggestions...
[-                                                                                [---------------------------------------------------/                                                             ]Aborting migration due to an exception.  This most likely is due to a
bug in the migration tool.  Please consider filing a bug report at:

https://github.com/dart-lang/sdk/issues/new
To attempt to perform migration anyway, you may re-run with
--ignore-exceptions.

Exception details:

NoSuchMethodError: The getter 'node' was called on null.
Receiver: null
Tried calling: node

#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      EdgeBuilder._handleAssignment (package:nnbd_migration/src/edge_builder.dart:2297:56)
#2      EdgeBuilder._handleInvocationArguments (package:nnbd_migration/src/edge_builder.dart:2842:7)
#3      EdgeBuilder.visitMethodInvocation (package:nnbd_migration/src/edge_builder.dart:1244:24)
#4      MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:7129:49)
#5      EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#6      EdgeBuilder._checkExpressionNotNull (package:nnbd_migration/src/edge_builder.dart:1920:20)
#7      EdgeBuilder._handleTarget (package:nnbd_migration/src/edge_builder.dart:2949:14)
#8      EdgeBuilder.visitMethodInvocation (package:nnbd_migration/src/edge_builder.dart:1227:22)
#9      MethodInvocationImpl.accept (package:analyzer/src/dart/ast/ast.dart:7129:49)
#10     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#11     EdgeBuilder._handleAssignment (package:nnbd_migration/src/edge_builder.dart:2248:20)
#12     EdgeBuilder.visitReturnStatement (package:nnbd_migration/src/edge_builder.dart:1446:7)
#13     ReturnStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:8559:49)
#14     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#15     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1288:9)
#16     GeneralizingAstVisitor.visitStatement (package:analyzer/dart/ast/visitor.dart:517:39)
#17     GeneralizingAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:165:31)
#18     BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1070:49)
#19     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#20     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1288:9)
#21     GeneralizingAstVisitor.visitFunctionBody (package:analyzer/dart/ast/visitor.dart:324:45)
#22     GeneralizingAstVisitor.visitBlockFunctionBody (package:analyzer/dart/ast/visitor.dart:168:55)
#23     BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1025:49)
#24     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#25     EdgeBuilder._handleExecutableDeclaration (package:nnbd_migration/src/edge_builder.dart:2398:7)
#26     EdgeBuilder.visitMethodDeclaration (package:nnbd_migration/src/edge_builder.dart:1202:5)
#27     MethodDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:6976:49)
#28     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#29     EdgeBuilder._dispatchList (package:nnbd_migration/src/edge_builder.dart:2148:7)
#30     EdgeBuilder.visitClassOrMixinOrExtensionDeclaration (package:nnbd_migration/src/edge_builder.dart:601:7)
#31     EdgeBuilder.visitClassDeclaration (package:nnbd_migration/src/edge_builder.dart:568:5)
#32     ClassDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:1522:49)
#33     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2134:22)
#34     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1288:9)
#35     GeneralizingAstVisitor.visitCompilationUnit (package:analyzer/dart/ast/visitor.dart:202:51)
#36     CompletenessTracker.visitCompilationUnit.<anonymous closure> (package:nnbd_migration/src/utilities/completeness_tracker.dart:52:24)
#37     PermissiveModeVisitor.reportExceptionsIfPermissive (package:nnbd_migration/src/utilities/permissive_mode.dart:26:24)
#38     CompletenessTracker.visitCompilationUnit (package:nnbd_migration/src/utilities/completeness_tracker.dart:43:5)
#39     CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:2113:49)
#40     NullabilityMigrationImpl.processInput (package:nnbd_migration/src/nullability_migration_impl.dart:222:12)
#41     NonNullableFix.processUnit (package:nnbd_migration/src/front_end/non_nullable_fix.dart:165:15)
#42     _FixCodeProcessor.runLaterPhases.<anonymous closure> (package:nnbd_migration/migration_cli.dart:1169:19)
#43     _FixCodeProcessor.processResources (package:nnbd_migration/migration_cli.dart:1111:30)
<asynchronous suspension>
#44     _FixCodeProcessor.runLaterPhases (package:nnbd_migration/migration_cli.dart:1167:11)
#45     MigrationCliRunner.run (package:nnbd_migration/migration_cli.dart:773:48)
<asynchronous suspension>
#46     MigrateCommand.run (package:nnbd_migration/migration_cli.dart:277:72)
#47     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#48     DartdevRunner.runCommand (package:dartdev/dartdev.dart:299:24)
#49     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#50     new Future.sync (dart:async/future.dart:223:31)
#51     CommandRunner.run (package:args/command_runner.dart:112:14)
#52     runDartdev (package:dartdev/dartdev.dart:121:27)
#53     main (file:///b/s/w/ir/cache/builder/src/third_party/dart/pkg/dartdev/bin/dartdev.dart:11:9)
#54     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:32)
#55     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

/cc @stereotype441

Marking this as a P2 - we can bump up in the future if we determine this is impacting more than a few users.

Can we repo this consistently?

@devoncarew how do we know it's just a few users? We have less than 100 users using the null safety experiment, so even with a single repro, that a 1% failure rate.

We haven't seen this before, with non-trivial internal usage.
@stereotype441 - do you mind looking at this, to determine if this is likely to be something user will hit (i.e., not a less likely coding construct)?

I'm able to reproduce this using Quiver commit https://github.com/google/quiver-dart/commit/6d9643fc3228280befd949a25cd049332be5974f and the latest Dart SDK as of 332ce760558233294898ab34916483ee523402ec.
I'll investigate further to try to figure out the root cause, and when I do, I'll update this bug with information about how large I think the impact is.
Side note: users who encounter this problem are not dead in the water.  Following the tool's suggestion of re-running with --ignore-exceptions does successfully work around the bug.

Ok, I've tracked the bug down far enough to estimate its impact.  I believe it's fairly common.
The bug will occur with any call to Iterable.firstWhere, Iterable.lastWhere, or Iterable.singleWhere where the value supplied to the orElse argument is () => null and the target of the method call is a sufficently complex expression (e.g. a method call like allMatches(str) as opposed to a simple variable reference like x).  In Quiver, the bug is triggered by this code:
  @override
  Match matchAsPrefix(String str, [int start = 0]) {
    return allMatches(str)
        .firstWhere((match) => match.start == start, orElse: () => null);
  }

I think this is sufficiently bad to consider a P1.  Fortunately the fix should be fairly easy, and I have time available to work on it now.
I should have a fix out for review within an hour or two.

Fix is out for review: https://dart-review.googlesource.com/c/sdk/+/170162


Display relations and facts counts in Analysis explored by location

For each location, the number displayed currently is the node count.
Example for France.
Like Analysis explored by network, KPN could display distance, nodes, routes and facts.
Lyon Saint Exupéry en Dauphiné 97% 😃
63 km, 27 nodes, 33 routes
PS:

Analysis explored by network don't display yet facts
Left panel could filter networks in the future :

with fact
without routes
…

Route and fact counts added in v4.3.50.


Comments in tokenizer

Take a look at tokenizer and how well it can handle comments, make sure that double back slash as default is working ok. I noticed strange behaviour when fixing bug in m2tools, token had only one backslash (but two in the file) and didn't get recognized as comment.

There was indeed a bug. Fixed in 55939d00e99744eb4f935a8a059b8e239665ece4.


Create a wrapper to run pds4_create_collection_member_index.py recursively

The tool pds4_create_collection_member_index.py, as described in #21, works only on a single collection_*.xml file.  Once this is in working condition, create a wrapper to run it recursively on collection_*.xml files specified in an input file (such as the bundle_member_index produced by #20).

I changed the name and description of this issue to clarify that we do not want to generalize pds4_create_collection_member_index.py itself (which was the previous wording), but rather create a wrapper that will run it recursively.

Since the creation of this issue, the design plans for the indexing tool were changed. This functionality is now represented in the current iteration of the indexing tool, pds4_create_xml_index.py


Styling for "proof" too loud?

I vote to remove the red background for proof: https://sphinxcontrib-prettyproof.readthedocs.io/en/latest/syntax.html
I love the styling over everything else.  Theorems need to attract attention to themselves.
The same is not true of proofs.  Often they are skipped on first reading.
I suggest a plain background and a light grey side bar.
What do you think @najuzilu ?

I created a draft PR (#15) but would be happy to merge if others are okay with the style @jstac suggested. Personally, I prefer it over the red background. This is what the suggestion would look like when rendered:

I like it, thanks!

I went ahead an merged #15.


remove redundant comments

Not much, just removed some unneeded comments

Thanks for the PR, but since there is no functional change here we will not merge it.


fix: printer import

There is a problem with importing printer package after calibration was embedded to spycer. And it is necessary to add src folder to PYTHONPATH. This pr makes printer import in the main controller module.

There are also small fixes included to this pr:

requests package added to requests.txt
and hardcoded fixture 2 height was changed from 0.15 to 0.1 (later I believe we move it to some fixture config file)

Do we already create one pr for one task or we can still make these changes within this pr?


ENH: special: Add sinpi, cospi, tanpi, and cotpi to public API and make sinpi, cospi IEEE-754 conforming

What does this implement/fix?

Modified sinpi and cospi to conform to IEEE754-2008 specification.
Added tanpi and cotpi.

"IEEE Std 754™-2008 (Revision of IEEE Std 754-1985), IEEE Standard for Floating-Point Arithmetic" p44
sinPi(+n) is +0 and sinPi(−n) is −0 for positive integers n. This implies, under appropriate rounding modes,
that sinPi(−x) and −sinPi(x) are the same number (or both NaN) for all x. cosPi(n + ½) is +0 for any integer
n when n + ½ is representable. This implies that cosPi(−x) and cosPi(x) are the same (or both NaN) for all
x

The sign of 0 in tanpi conforms to IEEE754-2019, p61.
tanpi and cotpi are equivalent to:
tanpi(x)=sinpi(x)/cospi(x)
cotpi(x)=cospi(x)/sinpi(x)

Additional information

The pros and cons of implementation were discussed here:
https://discuss.scientific-python.org/t/rfc-add-sinpi-cospi-tanpi-and-cotpi-functions-to-special/1193
Sorry to call on you, but I would appreciate it if you could review this PR when you have a moment.
@fancidev @dschmitz89 @WarrenWeckesser

Thanks for moving this forward!
I have a few high-level questions:

Do the original _sinpi and _cospi functions accept complex inputs? If they do, does that have any implication in the behavior of the function? (The IEEE-754 standard only defines the functions for real input, if I understand correctly.)

I recall the original _cospi function was ok and the original _sinpi function was almost ok except for the sign of zero. Those functions are called from the implementation of a few special functions. Would you be able to confirm that, after aligning the sign of zero with IEEE-754 recommendation, do those special functions still work correctly? (I.e. do the special function implementations rely on the sign of zero being the way it was coded?)

You could run tests locally using python dev.py test -t scipy.special.test_blabla. Hipe that makes it easier for you than relying on the Continuous Integration testing.

@fancidev
Thank you for your comment.
This PR seems to me as if I as the initiator of the issue need to be responsible for completing it.
https://github.com/scipy/scipy/issues/20761
However, I am more familiar with the boost source than with scipy, so I am very glad to hear your advice!

Do the original _sinpi and _cospi functions accept complex inputs? If they do, does that have any implication in the behavior of the function? (The IEEE-754 standard only defines the functions for real input, if I understand correctly.)

It is implemented to support complex input.
I need to design this PR to comply with IEEE specifications when the imaginary part is 0.

I recall the original _cospi function was ok and the original _sinpi function was almost ok except for the sign of zero. Those functions are called from the implementation of a few special functions. Would you be able to confirm that, after aligning the sign of zero with IEEE-754 recommendation, do those special functions still work correctly? (I.e. do the special function implementations rely on the sign of zero being the way it was coded?)

The function to be changed is called in relation to the gamma function. In this case, the sign of the poles is expected to change, but are there any cases where this sign is important?
Thank you for letting us know about the commands for the test.

Reference line list

gamma functions
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/digamma.h#L166-L173
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/loggamma.h#L130-L134
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/gamma.h#L172-L174
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/gamma.h#L292-L294
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/rgamma.h#L82-L84

bessel functions
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/bessel.h#L16-L30
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/wright_bessel.h#L466-L470
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/scipy_iv.h#L443-L445
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/scipy_iv.h#L480-L482
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/scipy_iv.h#L677-L679
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/scipy_iv.h#L734-L736

fresnel integrals
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/fresnl.h#L158-L160
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/cephes/fresnl.h#L173-L175

misc.
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/_hyp0f1.pxd#L94-L100
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/_orthogonal.py#L1675-L1680

complex sinpi, cospi
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/trig.h#L26-L35
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/trig.h#L75-L84

Implementation of complex tanpi and cotpi may require discussion.
import numpy as np

sin = np.array([1,   -0.0, -1,   -0.0, 0.0, 1,    0.0, -1],   np.complex128)
cos = np.array([0.0, -1,    0.0,  1,   1,   0.0, -1,    0.0], np.complex128)

tan = sin / cos
cot = cos / sin

# tan
[ inf+nanj   0. -0.j -inf+nanj   0. +0.j   0. +0.j  inf+nanj  -0. -0.j -inf+nanj]

# cot
[  0. +0.j -inf+nanj  -0. -0.j  inf+nanj  inf+nanj   0. +0.j -inf+nanj  -0. -0.j]

I think this is fine because tan(z) can be regarded as 0+sgn(Im(z))j when |Im(z)| >> 0.
template <typename T>
XSF_HOST_DEVICE std::complex<T> tanpi(std::complex<T> z) {
    if (std::abs(z.imag()) > 10.0) {
        return {0.0, std::copysign(1.0, z.imag())};
    }

    return sinpi(z) / cospi(z);
}

template <typename T>
XSF_HOST_DEVICE std::complex<T> cotpi(std::complex<T> z) {
    if (std::abs(z.imag()) > 10.0) {
        return {0.0, -std::copysign(1.0, z.imag())};
    }

    return cospi(z) / sinpi(z);
}

I know why the test didn't pass.
complex numbers with a real part of minus 0 do not seem to be possible to construct.
import numpy as np

x = -0.0
z = -0.0+0.0j

assert np.signbit(x), "sgn(x) must be minus"
assert np.signbit(z.real), "sgn(Re(z)) must be minus"

complex numbers with a real part of minus 0 do not seem to be possible to construct.

Guess you could try the following:
>>> 0j, 0j*(-0.0j), -0.0-0j, -0.0j
(0j, -0j, (-0+0j), (-0-0j))

Use the complex name:
In [4]: complex(-0.0, -0.0)
Out[4]: (-0-0j)

Known issues:
Failure to compute on input values with small imaginary part in complex cotpi and tanpi.

@steppi
Thanks for the title change.
Come to think of it, there is something strange about having cotpi and cotdg but no cot.

All of the added tests were passed!
Remaining Issue:

cot
cotdg, cotpi exist but cot does not.
Should it be implemented in numpy?
digamma
Should it be replaced by cotpi?
https://github.com/scipy/scipy/blob/701cd9afec92a24eaa09225f0abc5036910fecad/scipy/special/xsf/digamma.h#L166-L173
sindg, cosdg
Call sinpi or cospi internally?
It appears that sindg is different from the IEEE-754 code specification.
Users may be confused.
https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.sindg.html
sindg(180.0)=-0.0

Error evaluation near the pole
tanpi_error.csv

Error evaluation near pole [Rev.2]
tanpi_error.csv
tanpi(1/2+1/1024 + x j)

The relative error is considered accurate enough, with a maximum of 1e-15.
Please let me know if you have any comments or suggestions.

@tk-yoshimura, can you share the script you used to generate these csv files and plots?

cot
cotdg, cotpi exist but cot does not.
Should it be implemented in numpy?

There's a closed issue where someone had suggested adding cot to NumPy, https://github.com/numpy/numpy/issues/3013. The proposal was rejected because there isn't a nice way to do argument reduction like you can with cotdg or cotpi, so a cot implementation doesn't add much value over 1/tan(x) or cos(x)/sin(x).

digamma
Should it be replaced by cotpi?
Yeah, I think that's a good idea.

sindg, cosdg
Call sinpi or cospi internally?
It appears that sindg is different from the IEEE-754 code specification.
Users may be confused.
https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.sindg.html
sindg(180.0)=-0.0

Let's leave this for later. This PR is already touching a lot of things.


[Bug]:

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[ ] Was able to see the Start Screen.

Describe the issue.
Latest.log
https://github.com/LavaGang/MelonLoader/assets/37788089/61787ada-0b77-45c4-a545-1f2e3f89f43b
after finish title "Starting game" , the game ,and back to epic games launcher main
Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Loading a mod invalidates this issue, if you can reproduce this without mods, please open another issue.


New message box model

Following the new proposal put forth in #4485 we need to change the current implementation.
As described in the proposal we can do the changes of incoming and outgoing messages independently.
Since it is not changing the apis from inside the network. It don't need to be finished by 18 of Feb where dog-fooding starts again.
Note: Look for "TODO(#4492)" in the codebase.
Outbox
The circuit requirements to match the new outbox is already planned as part of the #3533 task. But some sections have not been finished yet.
### Dependent on
- [ ] #3868
- [ ] #3938
- [ ] #4031
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4250

When we have handled the above our hands are less tied, and we can get properly started.
### Tasks
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4560
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4561
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4562
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4768
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4769

Inbox
The inbox requires quite a lot more changes to replace the existing implementation. However, there are no blocking dependencies before the work can be kicked off.
As the changes are quite large, we should look at targeting it piecemeal without bricking the existing system. Essentially, allow us to run the old, or the new where a few new E2E tests should be usable to check the new flow. Essentially running the uniswap example when we have a  few pieces in place.
### Circuits
- [x] discussion: align on divide and conquer or a new circuit then write stuff here
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4558
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4678
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4633
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4833
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4829

### Contracts
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4825
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/4828
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5071
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5072

### Misc
- [ ] #3976
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5263
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5264

### Finale
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5073
- [ ] #697
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/5836

Remaining tasks of the message box model is low priority and can be addressed if needed at some point, but left to die off for now.

All issues semes to have been resolved. Will be closing this.


thanks, one more question，In the data_augmenttation.ipynb file, synonyms['premise'], what is 'premise' that is not specified in the file- uploaded final_data.csv

          - uploaded final_data.csv

fixed contrastive loss

Originally posted by @patrick-batman in https://github.com/patrick-batman/Med-ViLT/issues/1#issuecomment-1885286012

thanks, one more question，In the data_augmenttation.ipynb file, synonyms['premise'], what is 'premise' that is not specified in the file

it was used during paraphrasing of original questions of VQA-RAD dataset; you can generate your own questions


Describe execution context / runtime for python in PowerBI service

I need to point to a reference how python models published to PowerBI service are being executed - currently, the only information to this effect that I've found has been in a blog post:

The Python scripts in your reports are executed by the Power BI service in an isolated sandbox that restricts the access of the scripts to the network and the other machine resources. This ensures that your datasets and the Power BI service are not vulnerable to attacks.

Note that the above quote is the absolute barest minimum of the information that would be necessary for any enterprise customer seriously considering the security implications of using python scripts for visualization of sensitive data.
There also isn't much relevant information on the info page about the runtime, nor in the security whitepaper (where the only relevant scenario being discussed seems to be the premium-only "special case" AutoML).

Thanks for your comment, @h-vetinari. This issue has been assigned to the doc author for review.

Hello @KesemSharabi, thank you for your response.
I don't really appreciate you closing this right away, before I even had a chance to respond.

This looks like product feedback or a product question, rather than documentation feedback.

I strongly disagree on this - it's deployed functionality that's severely underdocumented (by several measures, including how extensively other functionality is documented), not a product feedback.
It's impossible for me to understand from the current docs how things work, and therefore equally impossible to make an informed judgement about the security context and implications of publishing a python model/visualisation to PowerBI Service. How can this be not in scope for documentation? 🤔

As for blog posts and whitepapers [...]

All I was trying to say with those references is that I did my homework with looking around for any source of documentation on this, and failed. This exacerbates the documentation shortcomings, rather than rendering them irrelevant.


4.11.0

releases new version of Prism.

Closing to start a fresh PR to resolve any left over issues from the circle ci outages experienced yesterday.


Use CopyMethod Direct when setting up VolSync ReplicationDestination

In this PR, added the option for VolSync to sync directly to the application PVC. This will resolve the issue where CephFS takes a long time to create an RWX PVC from a snapshot. Moreover, it resolves the issue where in some cases (PVC data size and latency) the first sync after failover/relocation takes a long time to fully copy the PVC to the destination side. Instead, with this change, only the delta is transferred.
By default, the CopyMethod from source to destination will remain snapshot-based. If users want to use this new feature, they have to enable it through the Ramen configmap.
volSync:
  destinationCopyMethod: "Direct"

The caveat with this solution is that (affects only the failover), there is a probability of about 5% where the delta sync is in progress when we lose connectivity to the secondary cluster. If the user decides to failover at that point, then the data written to the destination PVC might be inconsistent as opposed to crash-consistent.
For 4.13, we will change this to make it granular, per VRG, which requires UI change. For now, it is for all.
Signed-off-by: Benamar Mekhissi<EMAIL_ADDRESS>

@tesshuflower and @ShyamsundarR Should we make this new option the default? If the answer is yes, then we also need to update the downstream Makefile to inject the destinationCopyMethod. Otherwise, we will need to document it.

Unit test still remains to be done.

@tesshuflower @ShyamsundarR. I just completed e2e and unit tests. I added one more commit to address one small issue found during the e2e test.

(already discussed, but leaving it here again)
Historically applications typically are prepared for recovering from application quiesced snapshot points or crash consistent snapshot points.
The semi-synced state that may be left behind by this PR on the destination can have partial file contents or file contents that are different across files in the volume, as compared to the prior and current snapshot that was in flight when this was promoted as primary for use by the application.
While this provides a faster RTO in cases noted, it is at the cost of consistency that applications are not prepared for.
In the future as this is improved, we would need to ensure we do not leave behind this new option, as that would incur maintenance cost for the added copy method.

Historically applications typically are prepared for recovering from application quiesced snapshot points or crash consistent snapshot points.

The semi-synced state that may be left behind by this PR on the destination can have partial file contents or file contents that are different across files in the volume, as compared to the prior and current snapshot that was in flight when this was promoted as primary for use by the application.

While this provides a faster RTO in cases noted, it is at the cost of consistency that applications are not prepared for.

In the future as this is improved, we would need to ensure we do not leave behind this new option, as that would incur maintenance cost for the added copy method.

Agreed. Maybe the default for this feature should be OFF initially, then we ask QE to turn it on for testing. QE feedback after testing should determine whether to leave it OFF or default it to ON before the final build.


Little help with two errors?

Goodday,
Yersterday I asked the owner of Leaflet Routing Machine if LRM also supports openrouteservice (see my question asked here https://github.com/perliedman/leaflet-routing-machine/issues/469)
He guided me to you . I am using your plugin, but I encouter different issues.
First one is the following error code: L.Routing.OpenRouteService.js:52 Uncaught ReferenceError: corslite is not defined
Second, there is no polyline on the map. I see two markers, but that's it. The json response I get from openrouteservice is fine
{"routes":[{"summary":{"distance":1735.7,"duration":1249.7},"geometry_format":"geojson","geometry":{"type":"LineString","coordinates":[[5.27243,51.507831],[5.2729,51.50848],[5.273059,51.508697],[5.273288,51.50901],[5.273051,51.509192],[5.272982,51.509256],[5.27288,51.50922],[5.27266,51.50919],[5.27078,51.50948],[5.26992,51.50965],[5.26971,51.50971],[5.26957,51.50977],[5.26932,51.50993],[5.26835,51.51122],[5.26758,51.51234],[5.26751,51.51248],[5.26744,51.51278],[5.26729,51.51437],[5.26735,51.51458],[5.267655,51.51506],[5.267966,51.515404],[5.268613,51.516091],[5.268636,51.516109],[5.268761,51.516208],[5.268711,51.516298],[5.268831,51.516565],[5.268837,51.516691],[5.268638,51.517146],[5.26852,51.517383],[5.268219,51.517677],[5.26828,51.51865],[5.267989,51.518671],[5.26753,51.51893],[5.26751,51.51897],[5.267574,51.519126],[5.267772,51.519594],[5.267622,51.519621],[5.266814,51.519725],[5.26687,51.519818],[5.266901,51.519871],[5.26692,51.519902],[5.266911,51.519946],[5.266868,51.519973],[5.266699,51.520025]]},"segments":[{"distance":1735.7,"duration":1249.7,"steps":[{"distance":143.9,"duration":103.6,"type":11,"instruction":"Richting noordoost op Groenewoud","name":"Groenewoud","way_points":[0,3]},{"distance":34.6,"duration":24.9,"type":0,"instruction":"Keer om links","name":"","way_points":[3,5]},{"distance":1198.2,"duration":862.7,"type":0,"instruction":"Doorgaan links richting Beerseveld","name":"Beerseveld","way_points":[5,29]},{"distance":108.3,"duration":77.9,"type":5,"instruction":"Keer om flauw rechts","name":"","way_points":[29,30]},{"distance":63.1,"duration":45.4,"type":0,"instruction":"Keer om links richting Watermolenweg","name":"Watermolenweg","way_points":[30,32]},{"distance":76.4,"duration":55,"type":5,"instruction":"Keer om flauw rechts richting Watermolenweg","name":"Watermolenweg","way_points":[32,35]},{"distance":67.9,"duration":48.9,"type":0,"instruction":"Keer om links richting Spoordonkseweg","name":"Spoordonkseweg","way_points":[35,37]},{"distance":21.1,"duration":15.2,"type":1,"instruction":"Keer om rechts richting Spoordonkseweg","name":"Spoordonkseweg","way_points":[37,40]},{"distance":22.3,"duration":16,"type":4,"instruction":"Keer om flauw links richting Spoordonkseweg","name":"Spoordonkseweg","way_points":[40,43]},{"distance":0,"duration":0,"type":10,"instruction":"Arrive at Spoordonkseweg, on the left","name":"","way_points":[43,43]}]}],"way_points":[0,43],"bbox":[5.266699,51.507831,5.273288,51.520025]}],"bbox":[5.266699,51.507831,5.273288,51.520025],"info":{"attribution":"openrouteservice.org | OpenStreetMap contributors","osm_file_md5_hash":"00dbdb64edfeaad82649a77d599421a7","engine":{"version":"4.4.0","build_date":"2018-02-27T14:24:56Z"},"service":"routing","timestamp":1521092165977,"query":{"profile":"foot-walking","preference":"recommended","coordinates":[[5.275272,51.507033],[5.2666,51.5199]],"language":"nl","units":"m","geometry":true,"geometry_format":"geojson","geometry_simplify":false,"instructions_format":"text","instructions":true,"elevation":false}}}
Regards,,
Monique

Monique,
I apologize for not getting back to you sooner. We're in the process of
moving and my time has been very limited lately.
The first error  ( L.Routing.OpenRouteService.js:52 Uncaught
ReferenceError: corslite is not defined) is most likely because the
corslite dependency is not satisfied. I regret that the plugin I wrote is
not NodeJS-friendly or
Browserify-friendly at this point. Here is the script portion of the
index.html file I used during development, which includes the corslite
dependency:

Using npm, you can install the dependencies, and then just include them in
your HTML file. That should resolve the issue. If not, please let me know.
The second error is odd. I just did a quick test and I can see the
linestrings for the routes built. However, I am using the OSRM application
itself on my machine and not pointing to the 'Net. That * could* be one
reason. Another possibility is the corslite dependency is fouling the
ability to show the route properly.
My suggestion is to see if the first issue is fully resolved first (the
error is eliminated and no longer present in the web browser's console). If
the second issue is still present, if possible, send me your code and I can
test on my end to see what may be happening.
Again, my apologies for not getting back to you sooner and please let me
know how you make out.
On Thu, Mar 15, 2018 at 2:55 AM, NiekRood<EMAIL_ADDRESS>wrote:

Goodday,
Yersterday I asked the owner of Leaflet Routing Machine if LRM also
supports openrouteservice (see my question asked here
perliedman/leaflet-routing-machine#469
https://github.com/perliedman/leaflet-routing-machine/issues/469)
He guided me to you . I am using your plugin, but I encouter different
issues.
First one is the following error code: L.Routing.OpenRouteService.js:52
Uncaught ReferenceError: corslite is not defined
Second, there is no polyline on the map. I see two markers, but that's it.
The json response I get from openrouteservice is fine
{"routes":[{"summary":{"distance":1735.7,"duration":
1249.7},"geometry_format":"geojson","geometry":{"type":"
LineString","coordinates":[[5.27243,51.507831],[5.2729,51.
50848],[5.273059,51.508697],[5.273288,51.50901],[5.273051,
51.509192],[5.272982,51.509256],[5.27288,51.50922],[5.
27266,51.50919],[5.27078,51.50948],[5.26992,51.50965],[5.
26971,51.50971],[5.26957,51.50977],[5.26932,51.50993],[5.
26835,51.51122],[5.26758,51.51234],[5.26751,51.51248],[5.
26744,51.51278],[5.26729,51.51437],[5.26735,51.51458],[5.
267655,51.51506],[5.267966,51.515404],[5.268613,51.516091],[
5.268636,51.516109],[5.268761,51.516208],[5.268711,51.
516298],[5.268831,51.516565],[5.268837,51.516691],[5.268638,
51.517146],[5.26852,51.517383],[5.268219,51.517677],[5.
26828,51.51865],[5.267989,51.518671],[5.26753,51.51893],[5.
26751,51.51897],[5.267574,51.519126],[5.267772,51.519594],[
5.267622,51.519621],[5.266814,51.519725],[5.26687,51.519818]
,[5.266901,51.519871],[5.26692,51.519902],[5.266911,51.
519946],[5.266868,51.519973],[5.266699,51.520025]]},"
segments":[{"distance":1735.7,"duration":1249.7,"steps":[{"
distance":143.9,"duration":103.6,"type":11,"instruction":"Richting
noordoost op Groenewoud","name":"Groenewoud","way_points":[0,3]
},{"distance":34.6,"duration":24.9,"type":0,"instruction":"Keer om
links","name":"","way_points":[3,5]},{"distance":1198.2,"
duration":862.7,"type":0,"instruction":"Doorgaan links richting
Beerseveld","name":"Beerseveld","way_points":[5,29]},{"distance":108.3,"
duration":77.9,"type":5,"instruction":"Keer om flauw
rechts","name":"","way_points":[29,30]},{"distance":63.1,"
duration":45.4,"type":0,"instruction":"Keer om links richting
Watermolenweg","name":"Watermolenweg","way_points":[
30,32]},{"distance":76.4,"duration":55,"type":5,"instruction":"Keer om
flauw rechts richting Watermolenweg","name":"Watermolenweg","way_points":[
32,35]},{"distance":67.9,"duration":48.9,"type":0,"instruction":"Keer om
links richting Spoordonkseweg","name":"Spoordonkseweg","way_points":[
35,37]},{"distance":21.1,"duration":15.2,"type":1,"instruction":"Keer om
rechts richting Spoordonkseweg","name":"Spoordonkseweg","way_points":[
37,40]},{"distance":22.3,"duration":16,"type":4,"instruction":"Keer om
flauw links richting Spoordonkseweg","name":"
Spoordonkseweg","way_points":[40,43]},{"distance":0,"
duration":0,"type":10,"instruction":"Arrive at Spoordonkseweg, on the
left","name":"","way_points":[43,43]}]}],"way_points":[0,43]
,"bbox":[5.266699,51.507831,5.273288,51.520025]}],"bbox":[5.
266699,51.507831,5.273288,51.520025],"info":{"attribution":"
openrouteservice.org | OpenStreetMap contributors","osm_file_md5_hash":"
00dbdb64edfeaad82649a77d599421a7","engine":{"version":"4.4.
0","build_date":"2018-02-27T14:24:56Z"},"service":"routing","timestamp":
1521092165977,"query":{"profile":"foot-walking","
preference":"recommended","coordinates":[[5.275272,51.
507033],[5.2666,51.5199]],"language":"nl","units":"m","
geometry":true,"geometry_format":"geojson","geometry_
simplify":false,"instructions_format":"text","instructions":
true,"elevation":false}}}
Regards,,
Monique
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/willmorejg/lrm-openrouteservice/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABBR3vhIwIv2HaFY8tVpeh3wVOvdFOFkks5tehBwgaJpZM4SrpD9
.

--
Jim
==========
Sent using GMail account

Ugh.
I reverified the behavior using OpenRouteService and was able to reproduce
the issue you are having by using an invalid API key. Using a valid API
key, I can see the lisestrings. I am not saying this is the issue, because
you appear to be getting a valid response back from OpenRouteService. But I
do suspect that something with the rendering of the response related to the
first issue you experienced is playing a part in the second issue.
If you continue to experience issues, please provide the code you are using
(MINUS ANY API KEYS, PASSWORDS, ETC.) so I can try on my end to reproduce /
troubleshoot.
With invalid API key:
With valid API key
On Sun, Mar 18, 2018 at 4:44 AM, James Willmore<EMAIL_ADDRESS>wrote:

Monique,
I apologize for not getting back to you sooner. We're in the process of
moving and my time has been very limited lately.
The first error  ( L.Routing.OpenRouteService.js:52 Uncaught
ReferenceError: corslite is not defined) is most likely because the
corslite dependency is not satisfied. I regret that the plugin I wrote is
not NodeJS-friendly or
Browserify-friendly at this point. Here is the script portion of the
index.html file I used during development, which includes the corslite
dependency:

Using npm, you can install the dependencies, and then just include them in
your HTML file. That should resolve the issue. If not, please let me know.
The second error is odd. I just did a quick test and I can see the
linestrings for the routes built. However, I am using the OSRM application
itself on my machine and not pointing to the 'Net. That * could* be one
reason. Another possibility is the corslite dependency is fouling the
ability to show the route properly.
My suggestion is to see if the first issue is fully resolved first (the
error is eliminated and no longer present in the web browser's console). If
the second issue is still present, if possible, send me your code and I can
test on my end to see what may be happening.
Again, my apologies for not getting back to you sooner and please let me
know how you make out.
On Thu, Mar 15, 2018 at 2:55 AM, NiekRood<EMAIL_ADDRESS>wrote:

Goodday,
Yersterday I asked the owner of Leaflet Routing Machine if LRM also
supports openrouteservice (see my question asked here
perliedman/leaflet-routing-machine#469
https://github.com/perliedman/leaflet-routing-machine/issues/469)
He guided me to you . I am using your plugin, but I encouter different
issues.
First one is the following error code: L.Routing.OpenRouteService.js:52
Uncaught ReferenceError: corslite is not defined
Second, there is no polyline on the map. I see two markers, but that's
it. The json response I get from openrouteservice is fine
{"routes":[{"summary":{"distance":1735.7,"duration":1249.7},
"geometry_format":"geojson","geometry":{"type":"LineString"
,"coordinates":[[5.27243,51.507831],[5.2729,51.50848],[5.
273059,51.508697],[5.273288,51.50901],[5.273051,51.509192]
,[5.272982,51.509256],[5.27288,51.50922],[5.27266,51.
50919],[5.27078,51.50948],[5.26992,51.50965],[5.26971,51.
50971],[5.26957,51.50977],[5.26932,51.50993],[5.26835,51.
51122],[5.26758,51.51234],[5.26751,51.51248],[5.26744,51.
51278],[5.26729,51.51437],[5.26735,51.51458],[5.267655,51.
51506],[5.267966,51.515404],[5.268613,51.516091],[5.268636,
51.516109],[5.268761,51.516208],[5.268711,51.516298],[
5.268831,51.516565],[5.268837,51.516691],[5.268638,51.
517146],[5.26852,51.517383],[5.268219,51.517677],[5.26828,
51.51865],[5.267989,51.518671],[5.26753,51.51893],[5.26751,
51.51897],[5.267574,51.519126],[5.267772,51.519594],[5.
267622,51.519621],[5.266814,51.519725],[5.26687,51.519818],[
5.266901,51.519871],[5.26692,51.519902],[5.266911,51.519946
],[5.266868,51.519973],[5.266699,51.520025]]},"segments"
:[{"distance":1735.7,"duration":1249.7,"steps":[{"di
stance":143.9,"duration":103.6,"type":11,"instruction":"Richting
noordoost op Groenewoud","name":"Groenewoud","way_points":[0,3]},{"
distance":34.6,"duration":24.9,"type":0,"instruction":"Keer om
links","name":"","way_points":[3,5]},{"distance":1198.2,"dur
ation":862.7,"type":0,"instruction":"Doorgaan links richting
Beerseveld","name":"Beerseveld","way_points":[5,29]},{"
distance":108.3,"duration":77.9,"type":5,"instruction":"Keer om flauw
rechts","name":"","way_points":[29,30]},{"distance":63.1,"du
ration":45.4,"type":0,"instruction":"Keer om links richting
Watermolenweg","name":"Watermolenweg","way_points":[30,32]},
{"distance":76.4,"duration":55,"type":5,"instruction":"Keer om flauw
rechts richting Watermolenweg","name":"Watermo
lenweg","way_points":[32,35]},{"distance":67.9,"duration":
48.9,"type":0,"instruction":"Keer om links richting
Spoordonkseweg","name":"Spoordonkseweg","way_points":[35,37]
},{"distance":21.1,"duration":15.2,"type":1,"instruction":"Keer om
rechts richting Spoordonkseweg","name":"Spoord
onkseweg","way_points":[37,40]},{"distance":22.3,"duration":
16,"type":4,"instruction":"Keer om flauw links richting
Spoordonkseweg","name":"Spoordonkseweg","way_points":[40,43]
},{"distance":0,"duration":0,"type":10,"instruction":"Arrive at
Spoordonkseweg, on the left","name":"","way_points":[
43,43]}]}],"way_points":[0,43],"bbox":[5.266699,51.507831,5.
273288,51.520025]}],"bbox":[5.266699,51.507831,5.273288,51.5
20025],"info":{"attribution":"openrouteservice.org | OpenStreetMap
contributors","osm_file_md5_hash":"00dbdb64edfeaad82649a77d5
99421a7","engine":{"version":"4.4.0","build_date":"2018-02-2
7T14:24:56Z"},"service":"routing","timestamp":1521092165977,
"query":{"profile":"foot-walking","preference":"
recommended","coordinates":[[5.275272,51.507033],[5.2666,
51.5199]],"language":"nl","units":"m","geometry":true,"
geometry_format":"geojson","geometry_simplify":false,"
instructions_format":"text","instructions":true,"elevation":false}}}
Regards,,
Monique
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/willmorejg/lrm-openrouteservice/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABBR3vhIwIv2HaFY8tVpeh3wVOvdFOFkks5tehBwgaJpZM4SrpD9
.

--
Jim
==========
Sent using GMail account

--
Jim
==========
Sent using GMail account

Hi James,
Thank you for your response. The problems  had to do with three missing files. (thanks for showing your index.html)
<EMAIL_ADDRESS>https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS><EMAIL_ADDRESS>I  made a reference to the above files and now everything is working . The missing polyline had to do with polyline.min.js.  (I don't know why this plugin is needed?)
Good luck with moving!!

Great to hear and thank you!
On Sun, Mar 18, 2018 at 5:57 AM, NiekRood<EMAIL_ADDRESS>wrote:

Hi James,
Thank you for your response. The problems had to do with three missing
files. (thanks for showing your index.html)
<EMAIL_ADDRESS>https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS><EMAIL_ADDRESS>I made a reference to the above files and now everything is working . The
missing polyline had to do with polyline.min.js. (I don't know why this
plugin is needed?)
Good luck with moving!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/willmorejg/lrm-openrouteservice/issues/1#issuecomment-373985676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBR3r3_Dh4cDh77EpMO6TOvUBXAy38qks5tfi-ngaJpZM4SrpD9
.

--
Jim
==========
Sent using GMail account

Hi @NiekRood , do you know how to solve this issue?

ERROR TypeError: L.Routing.openrouteservice is not a constructor

i already include the script into my project.

I  added the three files listed above to solve the corslite issue. Thanks for this.
I am using a self-hosted OpenRouteService and up to now I have not looked into how one sets an api key. So I simply used a blank key and everything worked first time. To be clear, I set the router as follows
router:  new L.Routing.openrouteservice('')
Many thanks for the excellent work.
For Gérald Niel's equivalent Leaflet Routing Machine - OpenRoute Service
https://framagit.org/gegeweb/leaflet-routing-machine-openroute/
I tried setting my ORS service in his leaflet-routing-openroute.js but this did not work. I'll try initialising the router in the main script using:
const osrRouter = .....
router:  osrRouter,
as he describes.


sbt-release + sbt-sonatype support

Adding SBT plugins that make releases easier.
Running sbt release does:

Runs tests
Tags the release (which means it goes into the releases section on github)
Automates the tedious Maven central / Sonatype release process
Increments version.sbt

New process is also documented in CONTRIB.md.
Also added Roger as author in POM.xml file :)

Needs to be merged with Travis-CI before build will stop failing.

LGTM except minor new line.


[CP][beta channel] Improve messaging on invalid use of >>>

commit(s) to merge: 72de10d9381304d8a9ec68a4d1f2f0d474d29c87
merge instructions: https://dart-review.googlesource.com/c/sdk/+/211700 (no merge conflicts, but unittests needed infra changes)
What is the issue: Using the >>> operator in a <2.14 library results in confusing parser errors because >>> is parsed as >> followed by a >, instead of mentioning that >>> needs the triple-shift language feature. Running dart on this program
// @dart=2.13
class Class {
  operator >>>(o) => null;
}
method(int i, int j) {
  i >>> j;
  i >>>= j;
}

results in these confusing messages
test.dart:3:12: Error: A method declaration needs an explicit list of parameters.
Try adding a parameter list to the method declaration.
  operator >>>(o) => null;
           ^^
test.dart:3:14: Error: Expected '{' before this.
  operator >>>(o) => null;
             ^
test.dart:3:12: Error: Operator '>>' should have exactly one parameter.
  operator >>>(o) => null;
           ^^
test.dart:3:14: Error: Operator declarations must be preceded by the keyword 'operator'.
Try adding the keyword 'operator'.
  operator >>>(o) => null;
             ^
test.dart:6:7: Error: Expected an identifier, but got '>'.
Try inserting an identifier before '>'.
  i >>> j;
      ^
test.dart:7:7: Error: Expected an identifier, but got '>='.
Try inserting an identifier before '>='.
  i >>>= j;
      ^^

What is the fix: The fix is to special case >> immediately followed by > in the parser. This is done just after parsing operator > and just before parsing >> followed by > as a binary expression. At these points the normal message for an unavailable language feature is reported, instead the parser error it would normally have led to.
This means that after the fix, the output for the program above is:
test.dart:4:12: Error: This requires the 'triple-shift' language feature to be enabled.
Try updating your pubspec.yaml to set the minimum SDK constraint to 2.14 or higher, and running 'pub get'.
  operator >>>(o) => null;
           ^^^
test.dart:8:5: Error: This requires the 'triple-shift' language feature to be enabled.
Try updating your pubspec.yaml to set the minimum SDK constraint to 2.14 or higher, and running 'pub get'.
  i >>> j;
    ^^^
test.dart:9:5: Error: This requires the 'triple-shift' language feature to be enabled.
Try updating your pubspec.yaml to set the minimum SDK constraint to 2.14 or higher, and running 'pub get'.
  i >>>= j;
    ^^^^

Why cherrypick: Since the triple-shift feature is launched with the upcoming stable release, the messaging should clearly recognize failed attempts to use the features, and not indicate that the feature is unknown.
Risk: Low-medium risk. The parser change is added at points where parser errors are inevitable, but the error recovery might still result in unwanted cascading messages.
Link to original  issue(s): https://github.com/dart-lang/sdk/issues/46886
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @devoncarew @lrhn @jensjoha

@johnniwinther - I think the resolution here is that:

we don't want to take the cherry pick for stable
this should likely be combined with a follow on fix that was found

GIven that we should likely close this issue, and potentially come up with a new cherry pick (after seeing if this is an issue that people do hit?).

Closing this cherry-pick; we can re-formulate as a cp to stable.


feat: disable IMDS in controller to support MSI

What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: disable IMDS in controller to support MSI
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Release note:
feat: disable IMDS in controller to support MSI

/lgtm

/test pull-blobfuse-csi-driver-e2e-vmss


Apply ColorTransform directly when rendering text and shapes

This patch refactors and de-duplicates code in the Cairo and Canvas rendering classes and implements the application of color transforms to TextFields and (Shape) Graphics.
Luckily worldColorTransform was already implemented so it turned out to be fairly straightforward :-)
It introduces 2 new macros to ColorTransform that help calculate the RGBA values without temporary allocations. If and when Haxe supports multiple inline return values, these could be rewritten. Hopefully you'll find these readable enough... :)
Added some ColorTransforms to my little test program here
Before this patch, the ColorTransforms change nothing on targets other than Flash:
HTML5:

Flash:

Drawing Bitmaps with ColorTransform is untested and not implemented by this patch.

I can confirm that this fix the issue,
but no idea about the code itself, cc @jgranick

The patch also works for the "Tint" Color Effect in Flash / SWF files.

@jgranick maybe 4.4.0? 😀

Maybe... 4.8.0? 😃

How about having a threshold in Graphics (count of draw commands?) for this to kick in VS pixel/shader based color transforms?
If you're drawing a square and transforming the color, it's probably faster to do in software?


gpu tests for ci.dmlc.ml

only included lenet with mnist, will add more later

since only tests/nightly is touched, this PR should not affect others. i'll do a merge first to test if jenkins works


Update cloud-recording.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/5653.

@tonysmit PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Quilt

Description
Quilt is a new mod loader forked from Fabric that recently made its first beta release, and a number of mods have already moved to it (or are at least endorsing its use). Quilt can load Fabric mods, though the other way around isn't true. However, FabricClassPathAppender uses internal APIs that don't exist in Quilt.
Proposed Behaviour
Either release a native Quilt version, or modify FabricClassPathAppender to not rely on the internal and deprecated FabricLauncher.propose method.
Extra Details
No response

I am happy to support Quilt if alternative APIs are available to replace the Fabric specific ones.

As far as development is concerned, Quilt API supports almost all of Fabric API. However, implementation details aren't the same, so anything using impl will crash with ClassNotFoundExceptions and such.

As of quilt-loader 0.17.0 we should now include net.fabricmc.loader.launch.common.FabricLauncher.propose(java.net.URL) in quilt-loader's legacy fabric-loader folder. Could you please retry using quilt-loader 0.17.0 or later?

LuckPerms 5.4.30 on Minecraft 1.19 with quilt-loader 0.17.0 seems to work.


Is this Python 2 only?

Tried installing requirements.txt, got:
  Downloading https://files.pythonhosted.org/packages/a9/f7/bcc7fec63ca0ddedf4e2a7f04c3261ff668ea2e580962a743de3a4569771/cloud-2.8.5.tar.gz (247kB)
    100% |████████████████████████████████| 256kB 19.4MB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/ch/v8wwjmsd66z8_x20jstpv8080000gn/T/pip-install-orgleqsd/cloud/setup.py", line 23
        print 'using regular setup tools'
                                        ^
    SyntaxError: Missing parentheses in call to 'print'. Did you mean print(int 'using regular setup tools')?

Currently only Python2 is supported. I'm currently working to make it compatible with both Python2 and 3. I'll let you now when I finish it.

Hi @ktrnka ,
I've ported most code to a Python 2.7 - 3.6 compatible version. If you find any compatibility problem, please open an issue.


Mac - El Capitan PyCLI Error

Stop!  Use http://jsonlint.com/ to check.

YES

Have you searched to see if there are other issues for the same issue? If so, comment on that issue instead.

Yes, but this seems to be different from the other issues.

Are you running master? We work on the dev branch and then add that functionality to master. Your issue may be fixed on dev and there is no need for this issue, just wait and it will eventually be merged to master.

I have ran both master and dev and the issues is with both.
Expected Behavior
Actual Behavior
Shortly after running I get an the below error.
Traceback (most recent call last):
  File "pokecli.py", line 514, in <module>
    main()
  File "pokecli.py", line 83, in main
    tree = TreeConfigBuilder(bot, config.raw_tasks).build()
  File "/Users/toastmaster/projects/PokemonGo-Bot/pokemongo_bot/tree_config_builder.py", line 43, in build
    worker = self._get_worker_by_name(task_type)
  File "/Users/toastmaster/projects/PokemonGo-Bot/pokemongo_bot/tree_config_builder.py", line 21, in _get_worker_by_name
    raise ConfigException('No worker named {} defined'.format(name))
pokemongo_bot.tree_config_builder.ConfigException: No worker named SpinFortWorker defined
2016-08-11 11:43:08,140 [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
    super(ThreadedHTTPTransport, self).send(data, headers)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
    ca_certs=self.ca_certs,
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/raven/utils/http.py", line 66, in urlopen
    return opener.open(url, data, timeout)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/future/backports/urllib/request.py", line 494, in open
    response = self._open(req, data)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/future/backports/urllib/request.py", line 512, in _open
    '_open', req)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/future/backports/urllib/request.py", line 466, in _call_chain
    result = func(*args)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/raven/utils/http.py", line 46, in https_open
    return self.do_open(ValidHTTPSConnection, req)
  File "/Users/toastmaster/projects/PokemonGo-Bot/lib/python2.7/site-packages/future/backports/urllib/request.py", line 1284, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1053, in request
    self._send_request(method, url, body, headers)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1093, in _send_request
    self.endheaders(body)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1049, in endheaders
    self._send_output(message_body)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 891, in _send_output
    msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-11 11:43:08,142 [sentry.errors.uncaught] [ERROR] [u'ConfigException: No worker named SpinFortWorker defined', u'  File "pokecli.py", line 514, in <module>', u'  File "pokecli.py", line 83, in main', u'  File "pokemongo_bot/tree_config_builder.py", line 43, in build', u'  File "pokemongo_bot/tree_config_builder.py", line 21, in _get_worker_by_name']
Thu Aug 11 11:43:08 CDT 2016 Pokebot  Stopped.
Press any button or wait 20 seconds to continue.

Your config.json (remove your credentials and any other private info)
{
    "auth_service": "google",
    "username": "",
    "password": "",
    "location": "",
    "gmapkey": "",
    "libencrypt_location": "",
    "tasks": [
          {
            "type": "RecycleItems"
          },
          {
            "type": "SpinFortWorker"
          },
          {
            "type": "MoveToFortWorker"
          }
    ],
    "map_object_cache_time": 5,
    "forts": {
      "avoid_circles": true,
      "max_circle_size": 50
    },
    "websocket_server": false,
    "walk": 6,
    "action_wait_min": 1,
    "action_wait_max": 4,
    "debug": false,
    "test": false,
    "health_record": true,
    "location_cache": true,
    "distance_unit": "km",
    "reconnecting_timeout": 15,
    "evolve_captured": "NONE",
    "catch_randomize_reticle_factor": 1.0,
    "catch_randomize_spin_factor": 1.0,
    "logging_color": true,
    "catch": {
      "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
      "// Example of always catching Rattata:": {},
      "// Rattata": { "always_catch" : true }
    },
    "release": {
      "any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
      "// Example of always releasing Rattata:": {},
      "// Rattata": {"always_release": true},
      "// Example of keeping 3 stronger (based on CP) Pidgey:": {},
      "// Pidgey": {"keep_best_cp": 3},
      "// Example of keeping 2 stronger (based on IV) Zubat:": {},
      "// Zubat": {"keep_best_iv": 2},
      "// Also, it is working with any": {},
      "// any": {"keep_best_iv": 3},
      "// Example of keeping the 2 strongest (based on CP) and 3 best (based on IV) Zubat:": {},
      "// Zubat": {"keep_best_cp": 2, "keep_best_iv": 3}
    },
    "vips" : {
         "Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate!": {},
        "any": {"catch_above_cp": 1200, "catch_above_iv": 0.9, "logic": "or" },
        "Lapras": {},
        "Moltres": {},
        "Zapdos": {},
        "Articuno": {},

        "// S-Tier pokemons (if pokemon can be evolved into tier, list the representative)": {},
        "Mewtwo": {},
        "Dragonite": {},
        "Snorlax": {},
        "// Mew evolves to Mewtwo": {},
        "Mew": {},
        "Arcanine": {},
        "Vaporeon": {},
        "Gyarados": {},
        "Exeggutor": {},
        "Muk": {},
        "Weezing": {},
        "Flareon": {}

    }
}

Steps to Reproduce
Master Repo

git clone --recursive -b master https://github.com/PokemonGoF/PokemonGo-Bot
cd PokemonGo-Bot
virtualenv .
source bin/activate
pip install -r requirements.txt
cp ../../encrypt.so .
./run.sh

DEV Repo

git clone --recursive -b dev https://github.com/PokemonGoF/PokemonGo-Bot
cd PokemonGo-Bot
virtualenv .
source bin/activate
pip install -r requirements.txt
cp ../../encrypt.so .
./run.sh

Other Information
OS: OSX El Capitan
Git Commit: 138b66413e45efcef1ae015388b80a2725e7a7d8
Python Version: Python 2.7.10

The error message explains your problem. You're using an outdated config. See this file and update your tasks.
SpinFortWorker & MoveToFortWorker are not valid.

Unrelated to the unicode issue:
The tasks names are MoveToFort and SpinFort

Run the following:
cd PokemonGo-Bot
git pull
You are running an outdated Bot.

Thanks! That was my issue. I got that task from your wiki... Might need to update that. BTW, what happened to the wiki?


Int b 21509 db add poe and pod

B-21509
Summary
We are adding the ports and port_location tables to the database along with adding the Port of Debarkation (POD) and Port of Embarkation (POE) columns to mto_service_items.
Also added tests for ports and port_location and updated mto_service_items tests.
Verification Steps for the Author
These are to be checked by the author.

[x] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Run the migrations:

I ran mine using make db_dev_reset db_dev_migrate, though the reset might not be necessary.
You could also run make server_test

Verify that the tables and new columns have been added.

I verified mine using DBeaver.

Database
Any new migrations/schema changes:

[x] Follows our guidelines for Zero-Downtime Deploys.
[x] Have been communicated to #g-database.

Test coverage on client failed.
Last run: Mon 04 Nov 2024 11:00:50 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Conflicts need to be resolved

Conflicts need to be resolved

Yeah I am doing everything through GitHub directly so I can't run tests locally at the minute until I get access to my MacBook. Just trying to get some of the conversations addressed in the code

Conflicts need to be resolved

Should be ok now

@danieljordan-caci Could you provide some feedback on whether or not we need the validators for this?

@danieljordan-caci Could you provide some feedback on whether or not we need the validators for this?

Validators exist for when we insert/update data into the database
So if the table is meant to be static data that will not change within the app, then the validators can be removed - but I would recommend adding a read only attribute to the struct.

Ok I am following now. And yes so far I have been tracking that we will be inserting the port_locations data but the ports data will be static and I have those all set to read only in this commit here bf6e2f9. I will remove the validators and tests for port.go. Thanks everyone for clarifying

Did we want to wait to approve this until the upstream features get finished? If so I can move this PR to draft and move the BL out of Peer Review. @deandreJones and @brianmanley-caci


[Bitwarden] Can't log in to bitwarden

Extension
https://www.raycast.com/jomifepe/bitwarden
Description
Can't login to bitwarden using the extension, it shows an error message Please check your API Key and Secret. When I use the copy last error command it says Traffic from your network looks unusual. Connect to a different network or try again. [Error Code 2

Already triple-checked the credentials.
Rotated new API keys and secrets
I can log in using the CLI
I can log in using the web vault
I can log in using the browser extension

Steps To Reproduce

Try to search vault
Fail to login

Current Behaviour
No response
Expected Behaviour
No response

Hello, thanks for reporting. This is the first time I've seen this error, and as I don't have enough information to diagnose it, I recommend the following:

Try reinstalling the extension. Maybe update the CLI if that doesn't work.
Follow this help guide, which has a couple of other things to try: https://bitwarden.com/help/unusual-traffic-error/

It randomly started working again 🤷♂ Thanks for taking a look @jomifepe!


Move isRestrictedAccountCreationEnabled inside FlowServiceAccount

Creating an account  in the FVM checks a setting isRestrictedAccountCreationEnabled before checking FlowServiceAccount.isAccountCreator. This setting needs to be moved to from the FVM to the FlowServiceAccount, so that checking this setting can go within the setupNewAccount function. This will allow the call to setupNewAccount to be a direct function call instead of a meta-transaction (which would be faster).
This relates to: https://github.com/dapperlabs/flow-internal/issues/1513

Added tests. Though this make the PR a lot larger :)

@janezpodhostnik Looks good to me! Can we merge this?


CIS 3.x CloudWatch Alarm Notifications Not Working as Expected

Describe the bug
Alerts are not being sent out from CloudWatch after setting up a subscription to the topic SO0111-SHARR-LocalAlarmNotification.
To Reproduce

Deploy the latest 1.3.1 version of the aws-security-hub-automated-response-and-remediation project
Perform the CIS 3.x remediations to have a metric filter and alarm setup within CloudWatch
Add a subscription to the SO0111-SHARR-LocalAlarmNotification SNS topic
Adjust the SHARR_Alarm_CIS_1_2_Finding_3_2_ConsoleSigninWithoutMFA CloudWatch alarm so that the "Datapoints to alarm" is set to "1 out of 1" instead of "240" (This will make the alarm trigger after first event instead of needing 240)
Log out of account and then back in and navigate to CloudWatch and see the alarm state for consolelogin.
The alarm state should be "In alarm" however no notification is received. If you click on the "History" tab within the alarm you should see an error: "Failed to execute action arn:aws:sns:us-east-1:xxxxxxxxx:SO0111-SHARR-LocalAlarmNotification. Received error: "Resource: arn:aws:cloudwatch:us-east-1:xxxxxxxxx:alarm:SHARR_Alarm_CIS_1_2_Finding_3_2_ConsoleSigninWithoutMFA is not authorized to perform: SNS:Publish on resource: arn:aws:sns:us-east-1:xxxxxxxxx:SO0111-SHARR-LocalAlarmNotification because no resource-based policy allows the SNS:Publish action"
Navigate to SNS and edit the SO0111-SHARR-LocalAlarmNotification topic's access to policy. Change the services included in the access policy to include "cloudwatch.amazonaws.com"
After a new alarm is triggered, you should now see an error in the CloudWatch alarm about access denied to the KMS key: "Failed to execute action arn:aws:sns:us-east-1:xxxxxx:SO0111-SHARR-LocalAlarmNotification. Received error: "null (Service: AWSKMS; Status Code: 400; Error Code: AccessDeniedException; Request ID: xxxxxxx; Proxy: null)"
Navigate to KMS and modify the key policy for the SO0111-SHARR-Remediation-Key. Add "cloudwatch.amazonaws.com" to list of services in the key policy.
You should now see a successful notification one the alarm is triggered.

Expected behavior

I would expect for a notification to be sent and received to the subscription on the SO0111-SHARRLocalAlarmNotification SNS topic once an alarm in CloudWatch is in alarm state.

[x] Version: 1.3.1

[x] Region: us-east-1

[x] Was the solution modified from the version published on this repository? No

[x] Have you checked your service quotas for the sevices this solution uses? Yes

[x] Were there any errors in the CloudWatch Logs? Yes, included in screenshots

Screenshots

This is fixed in an upcoming release. What we missed was adding the action (send to sns). Also, a subscription to the sns topic is required to satisfy the config rule.
You can fix this manually in the mean time:

Go to Cloudwatch
Click on Alarms
Select the alarm you want to fix
Select Edit from the Actions drop-down
Next to the Notification page
Set up sns notification for the OK and Alarm states

Upon further review, this is a bug we didn't catch. Digging into it now.

It appears we used the wrong service principle in the sns topic's access policy. Please try the following:

Go to the SNS console
Select the SO0111-SHARR-LocalAlarmNotification topic
Click the Access policy tab
Change the principle from logs.amazonaws.com to cloudwatch.amazonaws.com

https://aws.amazon.com/premiumsupport/knowledge-center/cloudwatch-receive-sns-for-alarm-trigger/

I found a few issues in our remediation code:

Need to change the service principal on the sns topic from logs.amazonaws.com to cloudwatch.amazonaws.com
Need to add cloudwatch.amazonaws.com to the list of principals on the KMS CMK used to encrypt the sns topic
Not necessarily part of the bug, but the EvaluationPeriods are set to 240 (20 hours), which seems to be awfully long and therefore not terribly useful. I changed the value to 12 (60 minutes)

These are changes you can make locally. These will be fixed in the next release.

Thank you, those are indeed the same changes I have made locally to get the notifications to work from cloudwatch alarms. Looking forward to the next release!

@j-erickson thank you for the thorough feedback. Without it I may not have gone as deep, and certainly it would have taken longer. This is patched in our internal repo. I'm working on a maintenance release, as well as merging the changes into the next minor release. I'm really happy with how this came out, as I got 2 alarms last night for UnauthorizedAPI activity. The main issue here was the permission on the KMS key and the SNS topic, but going deeper, the 1/240 alarm threshold was not useful. 1/12 works so much better. I also found that units on the filter and on the alarm appeared to break the threshold. Those were fixed, as well.


Vasil hardfork compatibility

Hello, will db sync 13.0.0 official release be out anytime soon? Or will 12.0.2 be able to handle a connection to 1.35.0 node? The hardfork is scheduled for this sunday.
Thanks

No 12.0.2 cannot handle the hardfork. Tags 13.x.x can handle it and will be released soon.

Released now https://github.com/input-output-hk/cardano-db-sync/releases/tag/13.0.0, sorry for the noise


3 d assays issue 1346

closes issue #1346
This changes labels, textual and logical definitions of assays in "3D structure determination assay" branch.

Discussed on the OBI call 2021-09-20: No objections on the call. I plan to merge this.

@hectorguzor Could you please resolve this merge conflict? I think we should just take everything from this branch, but I'm not 100% sure.


Add ScrollView in CustomHeader

Current If CustomHeader have image, app run perfect. But If I have a UIScrollView in CustomHeader and scrollview have many image (scroll horizontal image in scrollview), I can't scroll table from touch on CustomHeader. I debug and I see app don't call in funtion if I scroll from CustomHeader
-(void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context
Please help me check it.

You can look up a method called hitTest,may be it's helpful !
发自我的 iPhone

在 2015年9月22日，12:24，vinh-savvycom<EMAIL_ADDRESS>写道：
Current If CustomHeader have image, app run perfect. But If I have a ScrollView in CustomHeader and scrollview have many image (scroll horizontal image in scrollview), I can't scroll table from touch on CustomHeader. I debug and I see app don't call in funtion if I scroll from CustomHeader
-(void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context
Please help me check it.
—
Reply to this email directly or view it on GitHub.

override func hitTest(point: CGPoint, withEvent event: UIEvent?) -> UIView? {
let view = super.hitTest(point, withEvent: event)
if view == self.scrollView {
return nil
}
return view
}
I called hitTest in CustomHeader, I scroll down ok, but I can't scroll horizontal image in scrollview
Please help me


Vertical orientation regions

Short description of changes:
This PR adds support for vertically-oriented waveforms to the regions plugin. It's a follow up to the original vertical waveform PR #2195.
API breakages:
None AFAIK.
Todos/Notes:
Other plugins still need vertical track support.
Related Issues and other PRs:
PR #2195, issue #634.

Coverage decreased (-0.07%) to 82.15% when pulling bfe8b56b873f3eab717889eaf2ade67cb5eb62cb on valrus:vertical-orientation-regions into 29cbdbcb2114e28c9a75c13389f3b63bac9ee43f on katspaugh:master.

Thanks for the cool PR @valrus!
Do you have it deployed anywhere so that we can play around with the vertical waveform?

Thanks for the cool PR @valrus!
Do you have it deployed anywhere so that we can play around with the vertical waveform?

Hey - sorry, I don't. I'm using it in a personal project but it's not ready to be more publicly available yet. When I have the time maybe I can throw up a basic demo that doesn't depend on a server like the aforementioned project does.

@katspaugh OK, I tossed up a quick demo for you! It's really just the existing regions example with vertical: true and some CSS tweaks also used in the current vertical example. Here it is: https://ian.mccowan.space/wavesurfer-vertical-demo/

Works great, thank you!


codet5-base.commons-math.mid-4558.idx-26887.3.mutant

Here, considering the use of Optional for handling potential null values could further improve the code, though it is not strictly necessary.

I think the goal of reformat is not to change code function, but make it fit the format of code around it.


Error opening capture

Hi,
I'm running eve-ng (the latest version  on Ubuntu 18.04.5 LTS server. A browser is firefox. When I click on node interface capture I get this:

The issue doesn't look as related to this project. Please send the issue to eve-ng devs.


Tests wanted for Grammar parse failure type - possibly different for 6.c and 6.d

The Grammar parse routine is currently documented as returning Nil on failure - https://docs.perl6.org/routine/parse.  There was a test for the Nil return type at one point in S05-grammar/example.t but that test was removed as part of work to change the return type which is now expected to be part of 6.d.  The old test referred to RT 81136 which doesn't really seem relevant to the return type anyway.  The plan for 6.d seems to have parse returning a Failure that wraps an X::Syntax::Confused exception.
I would propose that a test for Nil on failure be added to S05-grammar/parse_and_parsefile.t on the 6.c branch because of the planned change.  Hopefully part of the work on changing to Failure/X::Syntax::Confused will include tests for the exception type and relevant attributes, possibly also in S05-grammar/parse_and_parsefile.t or its own test file.

a Failure that wraps an X::Syntax::Confused exception.

FWIW that's a poor exception type and should be different. This is the exception we throw due to compilation failures. We should use something more relevant to indicate grammar parse failure.

Looking at it more, the feature has actually been removed, pending further discussion


Next

When the next swagger is released with removed swagger-ui this PR has to be merged.

Checklist

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@mcollina could you please approve, merge and release? Thx

@mcollina
Would you please release @fastify/swagger-ui?
#5 is not released and i dont want that somebody complains that the removal of swagger-ui from @fastify/swagger was not done properly. ;)


add orai18n jar to Oracle ZHS16GBK character

fix #4774

Could you squash commits into one and update the commit message as
Add orai18n for Oracle globalization support
Have you tried adding a test for this?

OK

Could you squash commits into one and update the commit message as
Add orai18n for Oracle globalization support
Have you tried adding a test for this?

test container's Oracle container  only use UTF8 character and can not change, I try to add some other tests

Merged, thanks!


Lokalise: Translations update - adding German

This pull request was initiated by Lokalise (user Do Hee Kim) at 2020-10-03 00:18:00

@jyclam do you know why the translation file ended up at root (locale/translations/de.json) instead of within client/ like the rest (e.g. client/src/locales/translations/pl.json)
I guess we also need to uncomment client/src/locales/index.js

@joshmorel that was my b -- I wrote "locale" not "locales". I'm to blame!!

@joshmorel good catch! Culprit has confessed.
I see that you've enabled the language and added it to the menu on this PR too. We were actually thinking it might be better to do it separately because:

Current workflow only builds on feature/ or hotfix/ branches. So QA can't do a quick click through unless we change our flow.
Subjective, but I think it's cleaner to keep the Lokalise PR strictly to make changes to the language JSONs

@idjevm

LGTM! Are we doing to have a JSON file for every language that our platform uses?
Yes, every language will have its own JSON that will be managed by Lokalise

Ah okay should have asked @jyclam . Going forward this makes total sense.
Should I undo it for this one? I did test it locally and it seems to be working fine like the other options. You decide.

@joshmorel I am going to close this PR and initiate a new one from Lokalise just to make sure that it was only the typo that threw it off. Sound good?


report missing modules

What does this PR do?
reports the missing modules

I was expecting this to pick up failure to locate from multiple node types. I am not so sure the factory function is the only or the real place to check things.

This needs a rebase on current develop, I don't think I did a rebase, so this is strange, maybe mishandling git on your side?

I am going to merge this one, right after I stabilized my current changes. One thing that I feel is missing is that we should save the line numbers to the data file, they are currently more or less lost when going though cache, which is not a big issue, but still not as nice as it should be. Maybe we also should not put a source ref, but the module_name and line number of the code making the attempt, which then of course would have to resolved to a filename later, should we want to output it, but for persistence, filenames are kind of bad.


[Flaky CI] [rfe_id:3423][crit:high][vendor:cnv-qe@redhat.com][level:component]VmWatch [test_id:3466]Should update vmi status with the proper columns using 'kubectl get vmi -w'

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/triage build-officer
What happened:
Flakefinder reported a flaky test:
[rfe_id:3423][crit:high][vendor:cnv-qe@redhat.com][level:component]VmWatch [test_id:3466]Should update vmi status with the proper columns using 'kubectl get vmi -w'

in this Prow job:

Timeout

What you expected to happen:
Test to pass
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@jean-edouard would you mind having a look?

/assign @jean-edouard

This test has quite a flaky history, however the problem here seems to be related to VMI management issues rather than actual test code.
I will look into it more closely and hopefully find something.

Thanks @jean-edouard

There are a lot of errors in https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3784/pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6/1283178938201280512/artifacts/k8s-reporter/pods/1_kubevirt_virt-handler-66sf7-virt-handler.log
This one happens a few times:
{"component":"virt-handler","kind":"","level":"error","msg":"Updating the VirtualMachineInstance status failed.","name":"testvmitcz59lb99cgfbn67nbhjpnbz8sxzpxv2fndnkdj5fc6f8nwp","namespace":"kubevirt-test-default","pos":"vm.go:1193","reason":"Operation cannot be fulfilled on virtualmachineinstances.kubevirt.io \"testvmitcz59lb99cgfbn67nbhjpnbz8sxzpxv2fndnkdj5fc6f8nwp\": the object has been modified; please apply your changes to the latest version and try again","timestamp":"2020-07-15T02:55:11.448255Z","uid":"39eea595-f23d-4c58-86cf-27c2cccab659"}

It seems like that could prevent the restart request from going through, which would lead to the exact failure that happened here. (timeout waiting for a new VMI to appear).

The above was a red herring...
I think the problem really is the timeout this time. 60 seconds to reboot a cirros VM is pretty tight, especially on an ipv6 system, since part of the boot process involves pinging IPs.
I ran the test with added debug a few times on my non-IPv6 setup, and it already routinely hits 35+ seconds just for the reboot.
I could increase the timeout, but we could also switch to using alpine instead of cirros, since it doesn't ping IPs as part of its boot process.
@rmohr what do you think?

I ran the test with added debug a few times on my non-IPv6 setup, and it already routinely hits 35+ seconds just for the reboot.
I could increase the timeout, but we could also switch to using alpine instead of cirros, since it doesn't ping IPs as part of its boot process.

This normally only happens if the cirros VM does not have cloud-init payload attached. Cirros is the fastest booting OS (if the workload is there). I assume that it tries to find a cloud-init source on the network?

@rmohr, that's probably the issue! The VM is definitely created without cloud-init. However, I could only find examples of adding cloud-init data to VMIs, not VMs. Is that something that has yet to be implemented? If that's complicated, wouldn't it just be easier to fallback to alpine? Thanks

Something like
$ git diff
diff --git a/tests/utils.go b/tests/utils.go
index 76e601caf..752113768 100644
--- a/tests/utils.go
+++ b/tests/utils.go
@@ -1917,6 +1917,13 @@ func NewRandomVMIWithDataVolume(dataVolumeName string) *v1.VirtualMachineInstanc
        return vmi
 }

+func NewRandomVMWithEphemeralDiskAndConfigDriveUserdata(containerImage string, userData string) *v1.VirtualMachine {
+       vmi := NewRandomVMIWithEphemeralDiskAndConfigDriveUserdata(containerImage, userData)
+       vm := NewRandomVirtualMachine(vmi, false)
+
+       return vm
+}
+
 func NewRandomVMWithEphemeralDisk(containerImage string) *v1.VirtualMachine {
        vmi := NewRandomVMIWithEphemeralDisk(containerImage)
        vm := NewRandomVirtualMachine(vmi, false)

should do the trick.


Add pipelines for Windows Audit and Log Sources

Adds 2 new pipelines for windows-audit and windows-logsources, based on pySigma-pipeline-windows, modified for Panther schemas.

@akozlovets098 looks great, ty!


Option to trigger build on closed pull request, build step to comment on pull request

I'd like to contribute the following:

Option to trigger build on closed pull request: when we build a pull request, we have created database and deployed a test instance of our app to validate the fixes and to test the new features. The test instance of the app should be available until the pull request is merged/closed. So we need to be able to trigger a build when a pull request is closed to delete the database and the test instance as well as clean up any other resources used by the pull request.

Build step to comment on pull request: until now I have to use curl to post comment using GitHub REST API, it'd be handy to have this build step.

@tphongio Hi, ever have further luck with this?

@tphongio I need to be able to trigger a build when a PR is merged, given this PR has not been merged, is there an alternative to achieve the same

Hi - I'm signed on to help out on this repo. If you think this PR still should get attention, could you rebase it against current master and resolve merge conflicts? Then I can take a closer look.
Please at-mention me when it's ready for a look?

Oh, and just to end my participation in this story, long time ago i made such features in https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Integration+Plugin So not interested anymore and you can ignore any my comments. Good luck!

Closing this as abandoned for now unless other folks want to take up the mantle.


Recovering from ECONNRESET on client

We use a long running client to push data to our CH server. That process looks like:
const send = async (rows: Array<Row>) => {
   const stream = new Readable({ objectMode: true, read: () => {}});
   const insert = this.client!.insert({
      table: this.table,
      values: stream,
      format: "JSONEachRow",
   });

   stream.push(rows);
   stream.push(null);
   await insert;
}

Occasionally when invoking this send function the client throws a ECONNRESET error.  The error is caught and we are able to reconnect and carry on.
My question is: is there a reliable way to know how many (if any) of the rows array has been sent to the CH server when the connection reset occurs? I'd like to be able to resend any of the rows that have not otherwise been sent.

@vincenzon, considering your example:
const send = async (rows: Array<Row>) => {
   const stream = new Readable({ objectMode: true, read: () => {}});
   const insert = this.client!.insert({
      table: this.table,
      values: stream,
      format: "JSONEachRow",
   });

   stream.push(rows);
   stream.push(null);
   await insert;
}

As the rows type is already an Array, this could've been simplified to just
const send = async (rows: Array<Row>) => {
  return this.client!.insert({
      table: this.table,
      values: rows,
      format: "JSONEachRow",
   });
}

There is no need to use a stream here explicitly.
Regarding your question: IIRC, there is no reliable way to track how many rows were inserted in the database before we finalize the input stream cause we don't get this information from the server.
Smaller batches and the ClickHouse insert deduplication feature could be an option here.
Do you think it could work in your scenario?

Thanks for the reminder about the stream, you are right, I no longer am using streaming and can just use an array. Thanks also for the tip about the deduplication feature that sounds like what I am looking for.