set{qf,loc}list functions silently ignore invalid “action” argument

Currently if you write something like setqflist([], []) Vim will act as if you wrote setqflist([]). Fix is as simple as
diff --git a/runtime/doc/eval.txt b/runtime/doc/eval.txt
index 022a5da..56fa6be 100644
--- a/runtime/doc/eval.txt
+++ b/runtime/doc/eval.txt
@@ -6049,11 +6049,12 @@ setqflist({list} [, {action}])				*setqflist()*
 		|getqflist()| returns.

 		If {action} is set to 'a', then the items from {list} are
-		added to the existing quickfix list. If there is no existing
-		list, then a new list is created. If {action} is set to 'r',
+		added to the existing quickfix list.  If there is no existing
+		list, then a new list is created.  If {action} is set to 'r',
 		then the items from the current quickfix list are replaced
-		with the items from {list}. If {action} is not present or is
-		set to ' ', then a new list is created.
+		with the items from {list}.  If {action} is not present or is
+		set to ' ', then a new list is created.  All other strings
+		are reserved and currently ignored.

 		Returns zero for success, -1 for failure.

diff --git a/src/eval.c b/src/eval.c
index cc30308..32091f0 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -18241,7 +18241,7 @@ set_qf_ll_list(
     {
 	list_T  *l = list_arg->vval.v_list;

-	if (action_arg->v_type == VAR_STRING)
+	if (action_arg->v_type != VAR_UNKNOWN)
 	{
 	    act = get_tv_string_chk(action_arg);
 	    if (act == NULL)

So then, should be an error?
diff --git a/src/eval.c b/src/eval.c
index db9c6b7..3740e70 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -18274,13 +18274,18 @@ set_qf_ll_list(
     {
 	list_T  *l = list_arg->vval.v_list;

-	if (action_arg->v_type == VAR_STRING)
+	if (action_arg->v_type == VAR_UNKNOWN)
 	{
 	    act = get_tv_string_chk(action_arg);
 	    if (act == NULL)
 		return;		/* type error; errmsg already given */
 	    if (*act == 'a' || *act == 'r')
 		action = *act;
+	    else
+	    {
+		EMSG2(_(e_invarg2), fromstr);
+		return;
+	    }
 	}

 	if (l != NULL && set_errorlist(wp, l, action,

@mattn

!= VAR_UNKNOWN, not == VAR_UNKNOWN.
You forgot that *act == ' ' is also valid.
If one wants to filter out all incorrect strings this would be if ((act[0] == 'a' || act[0] == 'r' || act[0] == ' ') && act[1] == NUL): length of the string should be one.
I am not really sure that nobody uses 0 or "" in place of the action argument, these variants are pretty commonly used to mean absense of arguments. But floats, funcrefs  and containers are very unlikely here and their presence indicates an error almost for sure.
 If error message is given it should describe what is the error. Check differences between neovim/neovim#4131 (specifically search for exc_exec starting from https://github.com/ZyX-I/neovim/blob/35c4b0454b2ef5fabc4c8af96894b559a63f07f6/test/functional/eval/json_functions_spec.lua#L86) and current Vim implementation and say what you like more, especially in big JSON strings. This problem is very common in Vim code.

I just give you example. (but mistaken) So please fix your patch.

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().
Thanks.
Best regards,
Hirohito Higashi (a.k.a. h_east)

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

mattn

Hi mattn!
2016-2-25(Thu) 21:50:37 UTC+9 mattn:

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

I see.
Is attached patch OK?
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

2016-02-25 16:30 GMT+03:00 h_east<EMAIL_ADDRESS>
Hi mattn!
2016-2-25(Thu) 21:50:37 UTC+9 mattn:

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

I see.
Is attached patch OK?

As I said earlier if you want to filter out all incorrect strings this
should also have && act[1] == NUL condition. Also consider the case
when user used setqflist([], ''), it will display “E475: Invalid
argument: ”. Now guess what argument it meant, this error message
looks more like a bug then like a reference to ''.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to<EMAIL_ADDRESS>For more options, visit https://groups.google.com/d/optout.

Hi Nikolai,
2016-2-25(Thu) 22:58:19 UTC+9 ZyX:

2016-02-25 16:30 GMT+03:00 h_east:

Hi mattn!
2016-2-25(Thu) 21:50:37 UTC+9 mattn:

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

I see.
Is attached patch OK?

As I said earlier if you want to filter out all incorrect strings this
should also have && act[1] == NUL condition. Also consider the case
when user used setqflist([], ''), it will display “E475: Invalid
argument: ”. Now guess what argument it meant, this error message
looks more like a bug then like a reference to ''.

It will be able to grasp when you see help.
Vim's document is very good.
Thanks.
Best regards,
Hirohito Higashi (a.k.a. h_east)

2016-02-25 17:21 GMT+03:00 h_east<EMAIL_ADDRESS>
Hi Nikolai,
2016-2-25(Thu) 22:58:19 UTC+9 ZyX:

2016-02-25 16:30 GMT+03:00 h_east:

Hi mattn!
2016-2-25(Thu) 21:50:37 UTC+9 mattn:

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

I see.
Is attached patch OK?

As I said earlier if you want to filter out all incorrect strings this
should also have && act[1] == NUL condition. Also consider the case
when user used setqflist([], ''), it will display “E475: Invalid
argument: ”. Now guess what argument it meant, this error message
looks more like a bug then like a reference to ''.

It will be able to grasp when you see help.
Vim's document is very good.

What I will be able to grasp? Consider setloclist(0, [], ''): to see
the problem in help file without any pointers from the error message I
need

:h setloclist()
Verify that 0 is indeed a valid window number in this context.
This is in second paragraph.
<C-]> on setqflist() because setloclist() documentation does not
contain anything useful.
Verify that [] is indeed a valid argument. This is two paragraphs,
a table, and another four paragraphs below. Super: see how many time
you have wasted for this.
Another two paragraphs below there is actually a paragraph about
{action}. It lists three possible values, but they are scattered over
the paragraph in place of being arranged into a table, so to get a
list of possible values in mind you need to read the whole paragraph.
Double super. And nobody said explicitly that these are the only
accepted values, even though this is logical?.. no, in the current
state of your patch 'at' is also accepted, but is not in a list.

Now please write what you will do if you see “Exxx: Invalid action
argument: ” after doing setloclist(0, [], ''), pretending that you
do not know what is the problem.
Of course, you probably will not write setloclist(0, [], ''), but
you will setloclist(winnr, constructed_list, action) (action has
high chances of being a string literal though). This makes debugging
with e_invarg2 even more interesting, especially if you had an opinion
that '' is a valid action (e.g. because it worked in your previous
Vim version) and thus will check other arguments first.
Clear message “Invalid action argument” points right to the argument
which contains error, unclear “Invalid argument” requires checking all
arguments to set*list() functions.

Thanks.
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to<EMAIL_ADDRESS>For more options, visit https://groups.google.com/d/optout.

2016-02-25 18:46 GMT+03:00 Nikolay Aleksandrovich Pavlov<EMAIL_ADDRESS>
2016-02-25 17:21 GMT+03:00 h_east<EMAIL_ADDRESS>
Hi Nikolai,
2016-2-25(Thu) 22:58:19 UTC+9 ZyX:

2016-02-25 16:30 GMT+03:00 h_east:

Hi mattn!
2016-2-25(Thu) 21:50:37 UTC+9 mattn:

On Thursday, February 25, 2016 at 9:07:46 PM UTC+9, h_east wrote:

Hi,
I think Nikolai's patch is simple and better.  Looks good for me.
This is perfect when adding a test :-)
mattn>
Detailed error will be output in get_tv_string_buf_chk().

No. When the option is passed neither a nor r, it should be error, I think.

I see.
Is attached patch OK?

As I said earlier if you want to filter out all incorrect strings this
should also have && act[1] == NUL condition. Also consider the case
when user used setqflist([], ''), it will display “E475: Invalid
argument: ”. Now guess what argument it meant, this error message
looks more like a bug then like a reference to ''.

It will be able to grasp when you see help.
Vim's document is very good.

What I will be able to grasp? Consider setloclist(0, [], ''): to see
the problem in help file without any pointers from the error message I
need

:h setloclist()
Verify that 0 is indeed a valid window number in this context.
This is in second paragraph.
<C-]> on setqflist() because setloclist() documentation does not
contain anything useful.
Verify that [] is indeed a valid argument. This is two paragraphs,
a table, and another four paragraphs below. Super: see how many time
you have wasted for this.
Another two paragraphs below there is actually a paragraph about
{action}. It lists three possible values, but they are scattered over
the paragraph in place of being arranged into a table, so to get a
list of possible values in mind you need to read the whole paragraph.
Double super. And nobody said explicitly that these are the only
accepted values, even though this is logical?.. no, in the current
state of your patch 'at' is also accepted, but is not in a list.

Now please write what you will do if you see “Exxx: Invalid action
argument: ” after doing setloclist(0, [], ''), pretending that you
do not know what is the problem.
Of course, you probably will not write setloclist(0, [], ''), but
you will setloclist(winnr, constructed_list, action) (action has
high chances of being a string literal though). This makes debugging
with e_invarg2 even more interesting, especially if you had an opinion
that '' is a valid action (e.g. because it worked in your previous
Vim version) and thus will check other arguments first.
Clear message “Invalid action argument” points right to the argument
which contains error, unclear “Invalid argument” requires checking all
arguments to set*list() functions.

Does not matter how good the help is, it can never replace the proper
error message. Help can teach what tutorials can’t. Help contains a
reference. Help may be the final argument. But using help to determine
where is the problem is a just a huge waste of time when you have a
Vim which knows where is the problem exactly and for sure, just you
need to make it tell you.
 Otherwise
there are two other locations to check which also do not contain
anything useful, and even are misleading because :h E475 will point
you to :h :call by talking about Ex commands.

Thanks.
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to<EMAIL_ADDRESS>For more options, visit https://groups.google.com/d/optout.

Hi,
If conflict between actual behavior and documentation, to correct either.  You modify the document.  But I modified the source code.
If we want to modify the source code, backward compatibility is considered may not have to worry about.  in this case.
Update a patch.
Adding E917 and E918 like as E474 and E475.
This error code displays the argument number of the error.
If this patch is included, I will also modify other E474 and E475. If possible.
--
Best regards,
Hirohito Higashi (a.k.a. h_east)

2016-02-26 9:52 GMT+03:00 h_east<EMAIL_ADDRESS>
Hi,
If conflict between actual behavior and documentation, to correct either.  You modify the document.  But I modified the source code.
If we want to modify the source code, backward compatibility is considered may not have to worry about.  in this case.
Update a patch.
Adding E917 and E918 like as E474 and E475.
This error code displays the argument number of the error.
If this patch is included, I will also modify other E474 and E475. If possible.

I do not like emsg… functions, it is better to have one emsgfmt
function: just copy smsg function with one modification, it is varargs
and the only modification needed is replacing msg(IObuff) with
emsg(IObuff).
And still you are not checking for string length, thus accepting any
actions that start with space, 'r' or 'a'.

--
Best regards,
Hirohito Higashi (a.k.a. h_east)
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to<EMAIL_ADDRESS>For more options, visit https://groups.google.com/d/optout.

Hi Bram,
I rewrote a patch and added a test.
This issue is in the TODO list.
TODO> Patch to have better check for {action} argument of setqflist().
TODO> Nikolai Pavlov, Feb 25, #661.  Can be even more strict.
TODO> Also see patch from Hirohito Higash, Feb 25.
Please include this.
Best regards,
Hirohito Higashi (a.k.a. h_east)

Hirohito Higashi wrote:

I rewrote a patch and added a test.
This issue is in the TODO list.
TODO> Patch to have better check for {action} argument of setqflist().
TODO> Nikolai Pavlov, Feb 25, #661.  Can be even more strict.
TODO> Also see patch from Hirohito Higash, Feb 25.
Please include this.

Thanks!  Hopefully I soon have time to include lots of patches.
--
hundred-and-one symptoms of being an internet addict:
129. You cancel your newspaper subscription.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Update staging to fix reported issues

What is the Purpose?
Update staging to fix reported issues and final QA testing
What was the approach?
Update staging to fix reported issues and final QA testing
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@ninetteadhikari @sannleen @andrewtpham
Issue(s) affected?
None

Codecov Report

Merging #369 into staging will increase coverage by 0.07%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           staging     #369      +/-   ##
===========================================
+ Coverage    50.10%   50.17%   +0.07%
===========================================
  Files           93       96       +3
  Lines         8283     8297      +14
===========================================
+ Hits          4150     4163      +13
- Misses        4133     4134       +1

Impacted Files
Coverage Δ

activity/views.py
19.83% <0.00%> (-0.07%)
:arrow_down:

workflow/views.py
30.26% <ø> (+0.02%)
:arrow_up:

workflow/migrations/0014_auto_20200403_0134.py
100.00% <100.00%> (ø)

workflow/migrations/0015_auto_20200403_0135.py
100.00% <100.00%> (ø)

workflow/migrations/0016_auto_20200403_0138.py
100.00% <100.00%> (ø)

workflow/models.py
79.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f835d5...ea069b8. Read the comment docs.


Document how to run Cucumber from the CLI

Running though CLI (how to) - see:
https://groups.google.com/forum/#!topic/cukes/bM_ZHHwks8U
https://www.jeroenreijn.com/2017/10/running-cucumber-from-the-command-line.html

@mlvandijk ,
so you would like a section to be added inside the Guides topic explaining how to run Cucumber through the CLI?

I think the best place for this would be: http://docs.cucumber.io/cucumber/api/#from-the-command-line.
Note that that is a polyglot page, so any general information should be valid for all (major) programming languages, and things specific to a particular language should be inside language blocks. Please see http://docs.cucumber.io/community/contributing-to-documentation/#polyglot-pages for how to deal with polyglot pages. (Contact me/us in the #docs channel on Slack if you have questions).
And please check that the page renders for each language tab while you are working on it.

@mlvandijk I was running through this process so I could document it properly, and I'm facing the same issue as: https://stackoverflow.com/questions/31946114/syntax-of-glue-option-for-java-cucumber-cli-cucumber-api-cli-main
From the command line I'm running:
java -cp "/home/annabaker/.m2/repository/io/cucumber/cucumber-core/4.8.0/cucumber-core-4.8.0.jar:/home/annabaker/.m2/repository/io/cucumber/gherkin/5.1.0/gherkin-5.1.0.jar:/home/annabaker/.m2/repository/io/cucumber/cucumber-expressions/7.0.2/cucumber-expressions-7.0.2.jar:/home/annabaker/.m2/repository/io/cucumber/datatable/1.1.14/datatable-1.1.14.jar:/home/annabaker/.m2/repository/io/cucumber/datatable-dependencies/1.1.14/datatable-dependencies-1.1.14.jar:/home/annabaker/.m2/repository/io/cucumber/cucumber-java/4.8.0/cucumber-java-4.8.0.jar" io.cucumber.core.cli.Main /home/annabaker/Development/git/hellocucumber/src/test/resources/hellocucumber/is_it_friday_yet.feature --glue hellocucumber
Here is my glue code:
`package hellocucumber;
import io.cucumber.java.en.Given;
public class StepDefinitions {
@Given("test data")
public void test_data() {
    // Write code here that turns the phrase above into concrete actions
   throw new cucumber.api.PendingException();
}

@Given("dev data")
public void dev_data() {
    // Write code here that turns the phrase above into concrete actions
   throw new cucumber.api.PendingException();
}

}`
(Sorry it's not formatting properly).
I'm using the proper syntax of using the package name (hellocucumber).  Do you spot any issues with the jars I'm using?  Every time I run it, my glue code is ignored and the CLI tells me to implement the missing steps.


[Parse] Treat '@unknown' as the start of a statement

...allowing a plain return to work in a switch in a Void-returning function.
SR-9920

@rintaro Can you think of any other test cases I should add, or related issues I should fix while I'm here?
@swift-ci Please smoke test

@swift-ci Please test source compatibility

👍
This patch should improve recovery for:
enum E {
  case foo, bar
}
func foo(e: E) {
  switch e {
  case .foo:
    _ = [1
  @unknown default:
    ()
  }
}

$ ../build/Ninja-ReleaseAssert/swift-macosx-x86_64/bin/swift test.swift
test.swift:8:11: error: expected ',' separator
    _ = [1
          ^
          ,
test.swift:9:3: error: expected expression in container literal
  @unknown default:
  ^
test.swift:6:3: error: switch must be exhaustive
  switch e {
  ^
test.swift:6:3: note: add missing case: '.bar'
  switch e {
  ^

@swift-ci Please smoke test


Requests to /_api cause unhandled error

Working on solutions for #49, I curled requests at the root apiPath _api. Surprisingly, these cause an unhandled server crash.

Confirmed that any undefined api requests cause an unhandled server crash (not just root api request).

Handle any undefined api requests with graceful response.

Fixed with express-error-handler update: 98b936225e2620f66b4fb99837b67d1a120943c5
Added check for error.statusCode


Implementation of [muti_loss_fusion_max]  Missing in isnet.py

HI @xuebinqin ,
I hope you are doing well. Anyway, you did great work indeed. However, one issue was raised. The implementation of the [muti_loss_fusion_max] is missing at line 435. Could you please tell me the reason and the way to solve it? Please find attached.

sorry about that. That loss was designed for debugging. Just deleted that.
Should be fixed now.
On Thu, Aug 25, 2022 at 4:28 AM Md Ashikur Rahman @.***>
wrote:

HI @xuebinqin https://github.com/xuebinqin ,
I hope you are doing well. Anyway, you did great work indeed. However, one
issue was raised. The implementation of the [muti_loss_fusion_max] is
missing at line 435. Could you please tell me the reason and the way to
solve it? Please find attached.
[image: dIS]
https://user-images.githubusercontent.com/6106868/186652469-86735f5f-c78f-40de-a842-392d73895a90.png
—
Reply to this email directly, view it on GitHub
https://github.com/xuebinqin/DIS/issues/31, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSGORKMDF22KMBCAFT6X5TV25KHPANCNFSM57SXI3BA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Xuebin Qin
PhD
Department of Computing Science
University of Alberta, Edmonton, AB, Canada
Homepage: https://xuebinqin.github.io/


[2.1] Include Identity UI in the 2.1.11 patch

[2.1] Include Identity UI in the 2.1.11 patch

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=157290

Merging because all required checks passed.


do you hava a plan to support http2?

do you hava a plan to support http2?

See the main HTTP/2 issue at https://github.com/twitter/CocoaSPDY/issues/118. There are no plans at the moment to implement HTTP/2 support --the benefits just don't outweigh the cost.


Video playing black screen on iOS 10, 10.1..

I faced a critical issue for video playing with PBJVideoPlayer.
Sometimes, video playing is showing a black screen with only sound. The sound is working good.
This was worked on iOS 9.x well.
I am not sure the reason.
Please review that and help soon.
Looking forward to your fixing or replying
Thanks

hey @polihym thanks for the feedback. if i can repro, i'll check into it. also check out the swift based player, http://github.com/piemonte/Player
📎 https://github.com/piemonte/PBJVideoPlayer/issues/57

Thanks for your reply and looking forward to your news soon


Get Orderref as a txn claim

Is your feature request related to a problem? Please describe.
If the application that uses ActiveLogin BankId needs to keep an audit trail of the sign-in, it is not possible toady. We can store the completionData and orderRef and correlate it with a user, but it is not possible to correlate it to the exact sign-in. This means if the user sign-in, sign-out and then sign-in again we'll have two orderRef and completionData for the user, but it's not easy to correlate which orderRef corrsponds to which sign-in. Authentication Time is not good enough. Instead it would be nice if it was possible to get the orderRef as a claim on the user. The txn claim could preferably be used for this.
From OpenId Connect for Identity Assurance (https://openid.net/specs/openid-connect-4-identity-assurance-1_0.html):
The txn Claim as defined in [RFC8417] is used in the context of this extension to build audit trails across the parties involved in an OpenID Connect transaction.
IANA (https://www.iana.org/assignments/jwt/jwt.xhtml) list txn as a transaction identifier.
What area is it related to
UI and issued user claims.
Describe the solution you'd like
A txn claim with the orderRef value should be issued when the user is authenticated.
Describe alternatives you've considered
If not always issuing the claim, make a setting to enable the issuance of the txn claim.

That is great input! I think it should be on by default, but configurable.
I'm thinking something like this to allow for a more flexible Claim handling in the future:

Ensure that BankIdLoginResult contains the orderRef
Make GetClaims in BankIdHandler pluggable

Regarding 2. This could be made in primarily 2 different ways.

Add all the default claims and allow for a "TransformClaims" at the bottom. Basically allowing for removing/changing/adding claims given the context available. But you always start with the default setup.
Remove all default claim adding handling and move that into a default implementation that can be swapped. A common scenario would then be to inherit from the default implementation and add/remove/change claims doing so (or completely swap the whole implementation).

Solution 2 would be the cleanest I think. Easier to test also.
Any input @equist ?

I agree that 2 is cleaner and allows full flexibility, but still with an easy default.

I place my vote on solution 2 also. Please make nameidentifier part of the default implementation 😊

I'm adding this to the 5.0.0 milestone as it seems many of you want this feature.

We are implementing this now and have read up on the txn claim spec. To issue the txn claim out of the box is a much commitment than we can take on, because of the lines marked below (from the spec). If we were to issue that claim we need to ensure that all the data specified is retreivable by the orderRef, and that very much depends on what data you log / store.

What we can do though is to make it very simple for you to implement that yourself. We are now looking at the "extension model" to be able to override/customize the claims issuing yourself. We will ensure that the context provided will contain enough info.

@equist A draft PR is now available. We still need to write docs and test, but from what you can see - any input?
https://github.com/ActiveLogin/ActiveLogin.Authentication/pull/350

It looks good! My first reaction was to allow the DefaultBankIdClaimsTransformation method to be overriden, but when I looked at it again, it aw possible to have multiple transformation classes so that will work even better.
I'm thinking, if it would be possible to make the BankIdLoginOptions and the LoginResult more extensible somehow. (for example with something like Items on AuthenticationProperties). I see the difficulty since it is passed as query string parameters, but if possible it would have been easier to extend the possiblity to pass orderref without requiring it to be implemented in the main code. I can also see other scenarios, for example beeing able to pass the clientId down to the login controller (could be used to resolve client specific options, for example custom stylesheets). Also related to passing messages for the purpose of authentication. Just some loose thought spinning in my head, but not fully thought through.

It looks good! My first reaction was to allow the DefaultBankIdClaimsTransformation method to be overriden, but when I looked at it again, it aw possible to have multiple transformation classes so that will work even better.

Exactly. You can remove the default implementation if you want, but easiest would be to register your own and just clear/remove the claims you don't want. The advantage of multiple transformations is that different modules can add their own claims transformations.

I'm thinking, if it would be possible to make the BankIdLoginOptions and the LoginResult more extensible somehow. (for example with something like Items on AuthenticationProperties). I see the difficulty since it is passed as query string parameters, but if possible it would have been easier to extend the possiblity to pass orderref without requiring it to be implemented in the main code. I can also see other scenarios, for example beeing able to pass the clientId down to the login controller (could be used to resolve client specific options, for example custom stylesheets). Also related to passing messages for the purpose of authentication. Just some loose thought spinning in my head, but not fully thought through.

I like the idea. We won't solve that in this PR, but the thoughts are good for a potential new architecture (#257).


Determines if number of concurrent connections to Postgresql DB is ap…

…proaching 90% of the  defined.
Please check off the steps below as you complete each step

[ ] Put the Jira ticket or Github issue number in parentheses in the Title e.g. (SUP-XXXX) Add Super Duper State Check
[ ] Update the Jira ticket status to Ready for Review if there is one
[ ] Review any CI failures and fix issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sandra Jiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Team, thanks for reviewing.


Added variant and selected props to MenuOption

MenuOption component has two new properties:

variant: At this moment, there's only one variant: nav that change the text color to blue.
selected (true|false): To mark the option as selected.

With these props we can create aside menus like this:

@pedroparra "nav" because it's used for navigation purposes. Some different that, for example, a dropdown menu: https://zeroheight.com/22mjgbuf6/p/88cf8e-tooltip
But I'm open to other names. The problem with "primary" is that it's not really the main option of a menu. All options have the same style (or variant), because all have the same purpose (navigation). Why "light" name? Other option could be "link".

@oscarotero Ok, we can use nav as variant and check in next versions.


Update play-json to 2.10.4

About this PR
📦 Updates com.typesafe.play:play-json from 2.10.0-RC7 to 2.10.4
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.play", artifactId = "play-json" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.typesafe.play", artifactId = "play-json" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #396.


test docker images

Still struggling with GitHub Actions glitch while attempting to exercise this change in a mock release in my fork: https://github.com/qrkourier/ziti-tunnel-sdk-c/actions/runs/10618563803

Next steps:

GitHub support to continue investigating the file corruption issue
Get all checks to pass
Mark ready for review


Remove sites that no longer seem to exist. Close #119

Remaining errors are for a (hopefully transient) 502 and a site I've confirmed manually just loads slowly sometimes.


PayPal and multi-factor auth support?

Currently the PayPal flow does not seem to support any kind of MFA from PayPal w/ no error being displayed. Is there any planned support for PayPal + MFA soon ?
Currently the login page just looks like it failed without any indication that two-factor is not supported  (even though the 2.7.3 changelog indicates that there should/might be a two-factor failure message).
There are a significant number of our potential users who have been turned away due to a lack of MFA support and confused by the lack of a failure message  FWIW.

While 2FA is not currently supported, version 2.7.3 includes an update to our error messaging explaining these failures. If you're using the latest version of this library from GitHub, npm, or Bower, you should be seeing these new error messages. Can you confirm you're using the most recent version?

I use the JS vended form https://js.braintreegateway.com/v2/braintree.js which looks like its in version 2.7.2 and hence I don't see the new version.
Any time estimates on :
1- https://js.braintreegateway.com/v2/braintree.js vending version 2.7.3 of the library?
2- 2FA + PayPAl support ?

@avinash-ananth the currently hotlinked version is now 2.8.1 so the 2.7.3 changes have been released.
As of right now there are no plans to support 2FA.
Sorry for the delay in response.

Just tried paying on a site using this SDK.. No 2FA support? No plans to support it? You must be joking right... With PayPal heavily pushing Braintree's v.zero SDK at https://developer.paypal.com you'd imagine this product would have complete support for PayPal authentications.

@night, there have since been updates to the sdk to support a PayPal with two factor auth, but would require updates on the merchant's side to enable the new flow. See here: https://developers.braintreepayments.com/guides/paypal/vault/javascript/v2

@sornon1 The site I was checking out on uses the "Checkout with PayPal" option by enabling singleUse on payments. This is probably because it's not a subscription service, so they have no reason to vault my information. I'm not sure why anyone would choose to support 2FA only on part of their SDK. There should be a fix that works for all existing setups, not making it a problem that merchants have to resolve.

The one time checkout flow also supports Two Factor Auth

Hi all,
2FA is indeed supported for both of our new payment flows - in our new vaulted payment flow and our Checkout with PayPal flow. Our older payment flows are in the process of being deprecated and have no plans to support 2FA at this time.
If you have any questions on how to enable these new flows please let us know.
Thanks,
Dan

Can you explain what the older flows look like then. The site I was using was loading https://checkout.paypal.com/pwpp/2.15.4/html/braintree-frame.html
Attempting to login yields the following message:

Login failed. PayPal Security Key is not supported.

This merchant is using one of our older payment flows that is in the process of being deprecated. We are working with all of our merchants to ensure they are using the latest payment flows that support things like multi-factor auth, funding selector, etc.

Just verified 2fa works by checking the "Vault" checkbox in Processing settings:

Log into the Control Panel
Navigate to Settings > Processing
Under Accept PayPal click Edit
Check the Use Vault Flow checkbox

No code changes necessary, just checking that box is all that's needed to enable 2-factor authentication.


CI: point action to codecov.xml as generated by pytest-cov

Addresses the issue in https://github.com/mesonbuild/meson-python/pull/657#issuecomment-2265481244

Okay, that isn't it, no change. This broke something in the last 4 weeks says the dashboard for PRs:

It worked 4 weeks ago and doesn't work today, nothing changed on our side. There is zero useful logging in CI (it claims success) or in the dashboard. codecov-action didn't change in that time, and neither did pytest-cov. One `coverage release (7.6.0) but no relevant open issues. I'll park this for now.

Does anyone know hot to get codecov unstuck?
@rgommers Should we switch to something else? coveralls.io seems to be another popular option.

Maybe it fixed itself in the meantime and there's nothing left to do? The percentages are no longer missing and https://app.codecov.io/gh/mesonbuild/meson-python/commits looks like:

It seems like the code browser is also up to date again (https://app.codecov.io/gh/mesonbuild/meson-python/blob/main/mesonpy%2F__init__.py).

Should we switch to something else?

I rarely look at codecov, so I'd be fine with anything.

I just look at the reports that pop up along the CI tests results. I haven't seen these working in a very long time. Therefore I thought codecov was still broken for us. Do you know how to get these back?

Ah, in https://github.com/mesonbuild/meson-python/settings/installations I now see that the GitHub App is suspended, so that's probably why the notifications don't show up:

I don't know what happened though; it can only be re-enabled by an org owner. @jpakkane would you mind hitting the Configure button on that link and then the Update Access one on the next screen?

We disabled codecov on the main repo because it was too spammy and not really helpful. Should be fixed now.

I think everything is fixed; in the most recent push for gh-681 I see:

I'll close this PR.


signalbackup-tools: 20230316 -> 20230317

Description of changes
Update to latest version. No changes that effect build (diff: https://github.com/bepaald/signalbackup-tools/compare/20230316...20230317).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 221710 run on x86_64-darwin 1

1 package built:

signalbackup-tools

Result of nixpkgs-review pr 221710 run on aarch64-darwin 1

1 package built:

signalbackup-tools

Result of nixpkgs-review pr 221710 run on aarch64-darwin 1

1 package built:

signalbackup-tools

@SuperSandro2000, can you merge if this looks good to you?


feat: migrate @rename annotations

Closes #1120.
Summary of Changes
The migrate command for rename annotation is now working:
If an annotation is mapped via an One/ManyToOneMapping, a new remove annotation would be created for this one apiv2 element.
Otherwise, there are two options:

If the same name is found in the mapping, an unsure @remove annotation would be created for this element.
Else, all apiv2 elements will be annotated with a @todo annotation.

Testing Instructions
run the migrate command or view and run the test_migration.py file

If you're done with a feature, feel free to merge it in.


allow global types swagger to define types used across resources like tags and subject

allow multiple -s flag to seal compile:
./seal compile -s $(dir)/global.types.swagger -s $(dir)/petstore.all.swagger -f $(dir)/petstore.all.seal

global.types.swagger would define things like subject and tag:
openapi: "3.0.0"
components:
  schemas:
    subject:
      type: object
      properties:
        iss:
          type: string
        sub:
          type: string
        aud:
          type: string
        exp:
          type: integer
          format: int32
        nbf:
          type: integer
          format: int32
        iat:
          type: integer
          format: int32
        jti:
          type: string
      x-seal-type: none
    tag:
      type: object
      additionalProperties: true     # map[string]string
      x-seal-type: none

https://tools.ietf.org/html/rfc7519 (iss, sub, aud, exp, nbf, iat, jti)
subject is a type and reserved keyword that refers to the authenticated user
deny subject group everyone to use petstore.* where subject.iss != "petstore.com";

REGO:
wanted:
deny {
...
	seal_subject.iss != `petstore.com`
}

# Helper to get the token payload.
seal_subject = payload {
	[header, payload, signature] := io.jwt.decode(input.jwt)
}

the parser constructor will change:
NewPolicyCompiler(backend string, resourceTypes ... string)

type resourceTypes will be merged allowing for conflicts in later types to override the type previously defined...  i.e. there will be a warning that subject defined in global types[0] is being overridden by swagger types[2]

Seems here is the implementation: https://github.com/infobloxopen/seal/pull/80

done


Make JWTManager::$userIdClaim nullable

Fixes #590

Is this going to be released soon ?
Thanks

Yes sorry, it will be released at the end of the week.

Hi,
When will this fix be tagged ? The last tag is 2.6.1 and this fix is not inside it.
It is merge into master but not yet usable for alot of applications.
Thank you.

Released in v2.6.2, apologies for the delay!


CockroachDB in Comparison Doc Update

Re: CockroachDB in Comparison
Issue Description
The label "Eventually Consistent Reads" sounds much worse than it is (if I understand correctly)
Suggested Resolution
Change to "Permits Stale Reads"

Thanks, @daxfohl. I like your suggestion.
@bdarnell, are you ok with this change? The dimension would be labeled Permits Stale Reads, with the following hovertext:

Optionally allows reading from replicas that do not have the most recently written data.

Actually, there are a few other options here:

We could make the label a nominative to stay consistent with the other dimensions, perhaps Optional Stale Reads. The rest of the row could stay Yes and No.
We could make the label just Stale Reads and make change the per-db answer to either No (never stale), Yes (always stale), or Optional (can choose stale).

Thoughts?

fwiw 5 CRL engineers preferred stale reads to eventually consistent reads (whereas 0 preferred the converse).
Regarding the fix, your second option makes a lot of sense to me, @jseldess. I think it elucidates CRDB's behavior in relation to other databases really clearly. It's easy to imagine a developer seeing the flexibility of allowing stale reads to be a benefit.

Yeah, it's good to capture the fact that stale reads are optional in some databases. "Stale reads: yes" is generally a bad thing, but "Stale reads: optional" is a good thing (even then, the "staleness" isn't the desirable part; it's the low-latency "read from any replica" part that this option implies). I like the "Stale reads: yes (red)/no (yellow)/optional (green)" phrasing (I know we're not color-coding these currently, but I feel like for this line in particular it's unclear what the "good" answer is and some guidance would be helpful).
There's another important dimension here: bounded vs unbounded staleness. Eventual consistency usually implies unbounded staleness; Spanner (for one) offers optional bounded staleness. (CockroachDB plans to eventually offer bounded staleness; we have decided against exposing unbounded staleness in the meantime even though it would be technically easy to do). We may want to consider adding that to this chart although it may be too much clutter.

@daxfohl Also, I'm curious: What, in your view, is the distinction between "eventually consistent reads" and "stale reads"? To me they're nearly equivalent in this context.

@bdarnell I look at Eventually Consistent Reads:  No and think "Wait, this database doesn't guarantee consistent reads?  Not even eventually consistent?  Isn't that the whole purpose of it though?"  It took me a while to figure out that what it meant was that the label means allowing possibly-stale reads as an optimization.
Also to answer the question more directly, I'd say "eventually consistent" is a property of a system, and "stale" is a property of a read.  So "eventually consistent reads" seems not entirely well-defined.

Ah, you interpreted the "no" as "our reads aren't consistent, even eventually". That argues against trying to get too clever with the matrix here (such as a yes/no/optional framing where "yes" is bad and "optional" is best. It will take a very knowledgable reader to interpret that correctly). Maybe the line should be "Local reads" with values like "stale" for the eventually consistent systems and "optional bounded staleness" for spanner. But I'm not sure what we'd put for cockroach - we only support fully consistent reads, which may mean you have to read from a remote replica, but we try to optimize lease placement as much as possible.

Also to answer the question more directly, I'd say "eventually consistent" is a property of a system, and "stale" is a property of a read. So "eventually consistent reads" seems not entirely well-defined.

Yeah, that's why I prefer the "stale read" terminology too.

@bdarnell It would have been most clear to me, to use 2nd option from @jseldess, but with No** instead of Optional, with a note at the bottom that they can be configured to deliver stale reads as an optimization if desired.

Appears to have been changed. Closing.

Appears to have been changed. Closing.


ConnectionError: All APIs are unreachable

A program I develop based on BitCash worked without issues since the last days.
I started to get a ConnectionError every time I tried to broadcast a tx: "Transaction broadcast failed or unspends were already used". Now, all APIs are unreachable. I don't use any custom API, does BitCash use rest1.biggestfan.net as default? Is it giving troubles to anyone else?
EDIT: Despite the "All APIs are unreachable" error message, the script is working and txs are being broadcasted.

A program I develop based on BitCash worked without issues since the last days.
I started to get a ConnectionError every time I tried to broadcast a tx: "Transaction broadcast failed or unspends were already used". Now, all APIs are unreachable. I don't use any custom API, does BitCash use rest1.biggestfan.net as default? Is it giving troubles to anyone else?
EDIT: Despite the "All APIs are unreachable" error message, the script is working and txs are being broadcasted.

Yes I'm having the same issue. Will reach out to BiggestFan.

Just to leave some more info, reading the docs it seems that BitCash uses BitPay API. Browsing https://bitpay.com/insight/#/ALL/mainnet/home I found that a 429 error is raised for BCH and many other networks:
Error 429: Http failure response for https://api.bitcore.io/api/BCH/mainnet/block?limit=5: 429 Too Many Requests

Just to leave some more info, reading the docs it seems that BitCash uses BitPay API. Browsing https://bitpay.com/insight/#/ALL/mainnet/home I found that a 429 error is raised for BCH and many other networks:
Error 429: Http failure response for https://api.bitcore.io/api/BCH/mainnet/block?limit=5: 429 Too Many Requests
Nvm, I've been reading the Python code and it seems that BitCash uses https://rest.bch.actorforth.org/v2/ as first option by default. I tried sending a raw transaction using their web interface and it worked. The raw tx was constructed from BitCash, so it's the broadcasting the failing point. I always broadcast the tx this way:
NetworkAPI.broadcast_tx(my_tx)

BitPay is used to calculate the fiat rate.
Yes I tried sending transactions through the web interface directly and it worked. It also works if I query the UTXO, wait 1 second then broadcast the transaction.
I will try to write a script that reproduces the issue so I can investigate this with BiggestFan

I'm not sure if this is related or not, but I am getting the same error when trying to get_transactions().
Code
#!.venv/bin/python

# .venv/bin/pip install coincurve bitcash qrcode[pil]

import os
import qrcode
import bitcash
from bitcash import Key, PrivateKeyTestnet

class Wallet(object):
    BCH_DIR = os.path.join(os.path.dirname(__file__), '.bch')
    def __init__(self, name, net='mainnet'):
        self.name = name
        self.net = net
        bch_dir = f'{self.BCH_DIR}' if net == 'mainnet' else f'{self.BCH_DIR}{self.net}'
        if not os.path.isdir(bch_dir):
            os.mkdir(bch_dir)
        key_dir = os.path.join(bch_dir, name)
        if not os.path.isdir(key_dir):
            os.mkdir(key_dir)
        self._key_path = os.path.join(key_dir, 'pkey')
        if not os.path.exists(self._key_path):
            with open(self._key_path, 'w+') as pkey:
                print(f'creating wallet {name} private key on net: {net}')
                key = Key() if net != 'test' else PrivateKeyTestnet(network=net)
                pkey.write(str(key.to_pem().decode()))
        with open(self._key_path, 'r') as pkey:
            K = Key if net != 'test' else PrivateKeyTestnet
            self._key = K.from_pem(pkey.read().encode('utf-8'))
        self._qr_path = os.path.join(key_dir, 'address_qr.png')
        if not os.path.exists(self._qr_path):
            with open(self._qr_path, 'w+') as pkey:
                print(f'creating qr image for {name} private key on net: {net}')
                qr = qrcode.QRCode(
                    version=1,
                    error_correction=qrcode.constants.ERROR_CORRECT_L,
                    box_size=10,
                    border=4,
                )
                qr.add_data(key.address)
                qr.make(fit=True)
                img = qr.make_image(fill_color="black", back_color="white")
                img.save(self._qr_path, format=img.format)

    @property
    def key_path(self):
        return self._key_path
    @property
    def key(self):
        return self._key
    @property
    def address(self):
        return self._key.address
    @property
    def balance(self, currency='bch'):
        return self._key.balance_as(currency)
    @property
    def transactions(self):
        return self._key.get_transactions()
    @property
    def qr_path(self):
        return self._qr_path

if __name__ == '__main__':
    wa = Wallet('a', net='test')
    wb = Wallet('b', net='test')
    for w in [wa, wb]:
        print(f'wallet {w.name}: {w.address} -> {w.balance}')
    for w in [wa, wb]:
        print(f'keytype {w.name}: {type(w.key)}')
    for w in [wa, wb]:
        print(f'transactions {w.name}: {w.transactions}')

Output
$ ./bch-ping-pong.py
wallet a: bchtest:qqgsu0pcsyp3c23yxn5ny56fpa6yzv33nswsnn0zz9 -> 0
wallet b: bchtest:qp2zw5e32k2cc5jzkgp6e3y625nh89qm3urwc6vxaj -> 0
keytype a: <class 'bitcash.wallet.PrivateKeyTestnet'>
keytype b: <class 'bitcash.wallet.PrivateKeyTestnet'>
Traceback (most recent call last):
  File "./bch-ping-pong.py", line 71, in <module>
    print(f'transactions {w.name}: {w.transactions}')
  File "./bch-ping-pong.py", line 57, in transactions
    return self._key.get_transactions()
  File "/Users/will/williamcharltonengineering/bch-ping-pong/.venv/lib/python3.8/site-packages/bitcash/wallet.py", line 238, in get_transactions
    self.transactions[:] = NetworkAPI.get_transactions(
  File "/Users/will/williamcharltonengineering/bch-ping-pong/.venv/lib/python3.8/site-packages/bitcash/network/services.py", line 112, in get_transactions
    raise ConnectionError("All APIs are unreachable.")  # pragma: no cover
ConnectionError: All APIs are unreachable.

@willcharlton could you submit a minimal reproducible example?
With that I would be able to investigate this issue further.

This should be fixed.


Could not build by Pod install and Xcode 10.2b1 ~ b4.

Module compiled with Swift 4.2 cannot be imported by the Swift 5.0 , use RealmSwift 3.13.1.
Can I build success in Xcode12

Duplicate of #6115


go: more regression fixes for optional values

Signed-off-by: Matt Klein<EMAIL_ADDRESS>

@danielhochman Thanks for the fix. This should solve my issue reported in https://github.com/envoyproxy/protoc-gen-validate/issues/562


Warning on build

PROBLEM:
When I cloned this repository I got warning when executing make.
In file included from source/mine.cpp:1:
source/field.hpp:575:13: warning: enumeration value 'MINE' not handled in switch [-Wswitch]
    switch (cells[x][y].state)
            ^~~~~~~~~~~~~~~~~
source/field.hpp:575:13: note: add missing switch cases
    switch (cells[x][y].state)
            ^
1 warning generated.

SOLUTION:
I added
    default:
        break;

in line 615

The proposed solution is correct because the possible cell states are EMPTY, MINE and ADJ_TO_MINE, but MINE is missing from that switch because nothing has to be done (thus break; is the correct thing to do).
However, you changed the format of the entire file. Please commit just the change and then I will approve it.

There is still formatting changes.

are*


Error while setting up farmvibes.ai cluster

On below command:
bash farmvibes-ai.sh setup
got below error :

module.services.kubernetes_deployment.worker: Still creating... [9m20s elapsed]
module.services.kubernetes_deployment.worker: Still creating... [9m30s elapsed]
module.services.kubernetes_deployment.worker: Still creating... [9m40s elapsed]
module.services.kubernetes_deployment.worker: Still creating... [9m50s elapsed]
module.services.kubernetes_deployment.worker: Still creating... [10m0s elapsed]
Error: Waiting for rollout to finish: 1 replicas wanted; 0 replicas Ready
with module.services.kubernetes_deployment.worker,
on ../services/worker.tf line 15, in resource "kubernetes_deployment" "worker":
15: resource "kubernetes_deployment" "worker" {
Error: timed out waiting for the condition on deployments/terravibes-rest-api

Hi, Kuldeep. Thank you for raising this issue.
You might see this error if the deployment times out when getting the worker pod up and running. Tuning the amount of time we should wait for deployments is tricky, as they will depend on each user's machine.
If ~/.config/farmvibes-ai/kubectl get pods  shows that all pods are running, you should be good to go.


moves ocsp connect failures to Debug

This closes #1452

Milestone: 8.0.0
Labels: TLS, Backports
Project: 7.x releases
Backport Rationale: This is very noisy on some systems, and it would be good to ease debugging on production hosts running current releases.

I'm the one who promoted this to an error. I'm pretty sure this logging would've helped us debug one of our properties before, but I'm not sure it's worth all the extra noise.
I say go for it.

Cherry-picked to 7.1.x.

Thanks, everyone


font transparency

Presently, the labels aren't drawn with any transparency as this is a pretty significant deficiency of the image crate. There's a hack for the shade fill, but  not for the font drawing.

switched to ril crate


[SPARK-33020][PYTHON] Add nth_value as a PySpark function

What changes were proposed in this pull request?
nth_value was added at SPARK-27951. This PR adds the corresponding PySpark API.
Why are the changes needed?
To support the consistent APIs
Does this PR introduce any user-facing change?
Yes, it introduces a new PySpark function API.
How was this patch tested?
Unittest was added.

Test build #129204 has started for PR 29899 at commit 179bdea.

cc @zero323 would you mind taking a look when you find some time?

cc @beliefer and @cloud-fan FYI

Test build #129207 has started for PR 29899 at commit dccf85d.

Test build #129204 has finished for PR 29899 at commit 179bdea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129204/
Test PASSed.

@HyukjinKwon Thank you! I learned more about PySpark.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33819/

Test build #129207 has finished for PR 29899 at commit dccf85d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129207/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33819/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33819/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33822/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33822/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33822/
Test PASSed.

Test build #129210 has started for PR 29899 at commit 98b04a2.

Test build #129210 has finished for PR 29899 at commit 98b04a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129210/
Test PASSed.

Merged to master.

Merged to master.

Thank you @dongjoon-hyun.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33825/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33825/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33825/
Test PASSed.

cc @zero323 would you mind taking a look when you find some time?

Looks good. I am going to add this to R as well, unless there someone already works on that.

Thanks @zero323 please go ahead!


Build Fail : Build using MSbuild to create whl file (pip package)

I am trying to build Tenserflow following these steps:
https://www.python36.com/install-tensorflow-gpu-windows/
I am on Step 10
Build using MSbuild to create whl file (pip package) using the following command:
MSBuild /p:Configuration=Release /verbosity:detailed tf_python_build_pip_package.vcxproj
I am getting following error and build is failing can anyone help?

Done executing task "Touch".
Done building target "FinalizeBuildStatus" in project "tf_python_copy_scripts_to_destination.vcxproj".
Target "Build" in file "C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140\Microsoft.BuildSteps.Targets" from project "C:\tensorflow\tensorflow\c
ontrib\cmake\build\tf_python_copy_scripts_to_destination.vcxproj" (entry point):
Done building target "Build" in project "tf_python_copy_scripts_to_destination.vcxproj".
Done Building Project "C:\tensorflow\tensorflow\contrib\cmake\build\tf_python_copy_scripts_to_destination.vcxproj" (default targets).
Done executing task "MSBuild" -- FAILED.
Done building target "ResolveProjectReferences" in project "tf_python_build_pip_package.vcxproj" -- FAILED.
Done Building Project "c:\tensorflow\tensorflow\contrib\cmake\build\tf_python_build_pip_package.vcxproj" (default targets) -- FAILED.
Build FAILED.
"c:\tensorflow\tensorflow\contrib\cmake\build\tf_python_build_pip_package.vcxproj" (default target) (1) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\pywrap_tensorflow_internal.vcxproj" (default target) (3) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\pywrap_tensorflow_internal_static.vcxproj" (default target) (4) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\tf_c.vcxproj" (default target) (5) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\tf_cc_framework.vcxproj" (default target) (6) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\tf_core_framework.vcxproj" (default target) (7) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\proto_text.vcxproj" (default target) (8) ->
"C:\tensorflow\tensorflow\contrib\cmake\build\grpc.vcxproj" (default target) (9) ->
(CustomBuild target) ->
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\tensorf
low\tensorflow\contrib\cmake\build\grpc.vcxproj]
0 Warning(s)
1 Error(s)

System information

OS Platform and Distribution: Windows 8
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 1.5
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 9.1/7
GPU model and memory:
Exact command to reproduce: MSBuild /p:Configuration=Release /verbosity:detailed tf_python_build_pip_package.vcxproj

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
Mobile device

Hello,
Follwing are the details:
System information
OS Platform and Distribution: Windows 8
TensorFlow installed from (source or binary): Source
TensorFlow version (use command below): 1.5
Python version: 3.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: 9.1/7
GPU model and memory: N/A
Mobile device: N/A
Exact command to reproduce: MSBuild /p:Configuration=Release /verbosity:detailed tf_python_build_pip_package.vcxproj
Thanks

@imrsayyed29 Hi, can you provide information for this field.
GPU model and memory:

CMake support is dropped, please see the bazel instructions here:
https://www.tensorflow.org/install/source_windows
Moreover, for support with such 3rd party resources, please contact their authors.


package use deprecated "rnpm"

Requesting update for next releases.
The packages use deprecated "rnpm" config that will stop working from next release of React-native. Please give a release update for the same.
React-Native 6.0 have some breathtaking changes like:

completely removing "rnpm" in next release.

AndroidX migration for mantained support lib version. All the support libs are updated to jetpack AndroidX. you can check these changes here.

These changes seems mandatory and I will be great if I can help you on same.

Any update on this?

same problem.

same problem

Seems to have been solved by ce99dd3ab201f16f55394ce85d003454afda59e5 they just hasn't released it to npm yet

When will this be released? The fix looks like it has been in for a while on master.

@vonovak Any update on this?

released in v3, thanks


Add St. James' and St. George's days to ChristianHolidays

Proposed change

Add St. James' and St. George's days to ChristianHolidays.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.944% (+0.02%) from 99.926% when pulling 1a26b89a0de1e644490a54c8e9f72e8aad5501f9 on KJhellico:add-christian-holidays into 6b959829d4f57e26da17e81bdb0d632afaaf093f on dr-prodigy:beta.


Don't understand how to identify individual users

How do I identify individual users?
Users on my application are currently being tied to sessions.
So for instance I have 250 sessions recorded and 256 recorded users, even though I only have 7 people using the test extension currently.

The library offers a subset of functionality offered by the Google Analytics service. The support offered is documented on the wiki (https://github.com/GoogleChrome/chrome-platform-analytics/wiki). Anything not covered by the wiki is either unsupported, undocumented, or documented by the Google Analytics team's documentation.


Prepend rows

Hello!
Is it possible to prepend new rows with values to an existing sheet? I can't seem to find out how unless adding a totally new spreadsheet which I don't want.
Thanks!

It is actually possible to prepend rows with insertDimension and addRows. Just reload cached rows with await sheet.getRows() after sheet.insertDimension().


Revert "Fixes after JPA 2.0 -> 2.1 upgrade"

Reverts droolsjbpm/drools#1019

I guess we don't need this anymore as the revert was already pushed to master: https://github.com/droolsjbpm/drools/commit/94b79436bec5ffbd70a03e081ef8cf2ba57b9662


Abandoned?

Looks like nothing is getting though anymore.

Not really abandoned, just low maintenance, I plan to move things a bit once svelte 5 comes out.

I see.  Thanks for stopping by.  I made a table component that I wanted to include in your list of tables.  It is for Svelte v5 only.  Should I wait to make the PR?  Or do I do it now? Or...?

Finally cleaned up everything, PRs welcome.


Fix and add checkings to Target and Logger

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
-

👍


Research MAVLink statustexts

https://github.com/dronecore/DroneCore/pull/119 adds support to print statustexts from the vehicle.
This issue is to review the messages and determine whether they:

Can remain FYI console logs
Should be escalated to users
Should result in code errors
Require other actions.

Also determine best place for handling messages (proposal is to defer to relevant plugins).
Relevant discussion:  https://github.com/dronecore/DroneCore/pull/119#pullrequestreview-69720267

@julianoes is that solved now that we have the statustext in the telemetry plugin?

This will improve once we have the event interface, closing for now.


Keep hasMask bits for nodes not involved in merge operation step.

@baldersheim : please review
@geirst , @vekterli : FYI

@vekterli Please have a look.


Personal Details - Data does NOT show after a few seconds with HT expensifail account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Found when executing PR https://github.com/Expensify/App/pull/17944
Action Performed:

Open the app and logout if you're currently logged in
Log in with HT expensifail account
Disable network
Open Settings > Profile > Personal Details
Observe that data (Legal name, Date of birth, Home address) isn't showing yet
Enable network
Verify that data shows after a few seconds

Expected Result:
Data shows after a few seconds with HT expensifail account
Actual Result:
Data does NOT show after a few seconds with HT expensifail account
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/234665258-3e492d5b-786f-458b-923e-bd8b55809ceb.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018af1590591eb5887
Upwork Job ID:<PHONE_NUMBER>132850688
Last Price Increase: 2023-05-24

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I wasn't able to reproduce this bug on my account. After looking at the Network Tab in the OP, I think the tester may have had an extremely slow internet connection, causing all the requests that were added to the queue while offline to stall for a really long time. This was evidenced by how it took an abnormally long amount of time to sign in.
Here's a video of it working on my account:
https://user-images.githubusercontent.com/31285285/234758051-9b5bd981-653a-41e1-b0ab-d0d3a4af06a2.mov
@anmurali If you're also unable to reproduce this let's just close it out.

TLDR: With the parallel Pusher stuff that's being worked on right now this problem should go away eventually, closing

@jasperhuangg is this still true? If yes, we can close this yea?

@anmurali
Ionatan's parallel pusher stuff https://github.com/Expensify/Web-Expensify/pull/37120 should be deployed to staging pretty soon (it's already been merged to main). Let's just keep this open for now and leave it as is (Needs Repro). Once that PR gets deployed to staging let's ask @kbecciv to test again. My theory is that it should go away once that PR goes out.

Ok I am going to add the reproduction needed label, assign to @kbecciv

@anmurali Is it PR merged already?

Ah sorry this completely flew under my radar, @kbecciv can you use the HT account to retest this?

Ugh, I'm kind of unclear what's going on here and why I was assigned? Assigning Jasper back in any case.

Just following up. Can someone provide a summary of what's going on?

@JmillsExpensify Sorry for the delay was OOO.
The HT expensifail account is an account with a TON of data. Here's my theory on why this is happening:

We go offline.
We navigate to the Personal Details page. This makes a read request OpenPersonalDetailsPage, which is in charge of the loading the personal details. Since it's a read request, it only runs AFTER all the write requests on the SequentialQueue have cleared.
The HT expensifail account is a member of some huge workspaces/reports, which makes a lot of these SequentialQueue requests take forever to run (since Pusher is slow).
 I bet if we left the window open for long enough it would run eventually.

@kbecciv can you confirm this by providing another screen recording of the issue run on the HT Expensifail account. The Parallel Pusher stuff was deployed a while ago, which should dramatically speed up the SequentialQueue requests. Please remove the bank filter so we can see all the requests, and click Fetch/XHR:

@kbecciv friendly bump here!

@jasperhuangg Checking, sorry for delay

Works much better, attached the video.
https://github.com/Expensify/App/assets/93399543/0a71835f-bf6e-47a1-9bf1-7c729f7c4a12


[ci] Added GitHub workflow to replicate commits to version branch

Checklist

[x] I have read the OpenWISP Contributing Guidelines.
[x] I have manually tested the changes proposed in this pull request.
[ ] I have written new test cases for new code and/or updated existing tests for changes to existing code.
[ ] I have updated the documentation.

Blockers

[ ] https://github.com/openwisp/openwisp-utils/pull/423

coverage: 99.801%. remained the same
when pulling 68ca2458c00b8ecf4b58e82933aa31392dc0aea7 on replicate-version-branch
into bd38b25f860ca47ada9f430ddcfa3c6dbb6c55f6 on master.


⚠ ClamAV has degraded performance

In 5b0e843, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 448 ms

Resolved: ClamAV performance has improved in 12c37ad.


Can't rearrange tabs anymore

Issue Type: Bug
Hi,
I don't know if it accidentally changed a setting but I can no longer sort and order my open tabs. Is this a bug or an options somewhere?
Thanks,
Roy
VS Code version: Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T11:04:09.886Z)
OS version: Windows_NT ia32 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

Memory (System)
7.67GB (2.66GB free)

Process Argv
C:\Program Files (x86)\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

python
ms-
2018.1.0

Reproduces only with extensions

@rdcastro86 could it be that in your settings you have "workbench.editor.showTabs": false ?

Hi bpasero,
Nope, that setting is set to true.
Thanks,
Roy

@rdcastro86 can you somehow record a video to show what you are doing?

Hi Ben,
video.zip
I'm trying to click and hold on the tabs so I can move them, but they stay fixed.
Thanks,
Roy

@rdcastro86 crazy, I have no explanation why it does not work anymore. Does other drag and drop work, e.g. in the files explorer?

I would like to confirm that I've noticed since updating to 1.21.0 (could have surfaced earlier but I just noticed today) I can no longer drag to rearrange editor tabs. Trying to drag results in tab selection but there's no feedback after that nor does dragging to another location change any order.
Thanks,
David.

@rdcastro86 @davidonstate
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Hi @bpasero,
Nope, still unable to reorder tabs by dragging in the insider build.
Kind regards,
David.

@davidonstate are you on windows as well? Can you drag and drop in the file explorer or "open editors" view list?

@bpasero I am on windows as well and noticed that I cannot drag files on the file explorer. I am also having this issue with my firefox and explorer tabs. Tabs on chrome are working however.

@rdcastro86 could it be that you are running as a different user/administrator?

No, but after a windows update, it is now working. If it happens again i'll let ya'll know.
Thanks,
Roy

Ok, closing then as this seems Windows related.

Just confirming that this issue now appears to be resolved when still running version 1.21.0.


javascripts: polishing some leftovers

This commit removes some leftovers from the Coffeescript -> Javascript
move.
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

LGTM


Feature Request: Integrate with SSO

Allow integration with single sign on providers.

whoops. duplicate of #202


feat: add sidecar functionality

Tested here: https://github.com/celestiaorg/knuu-example/blob/feature/sidecar-functionality/basic/sidecar_test.go
Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Thank you @Bidon15 for the great review!


I just plagiarized your project 😈

By "plagiarized" I mean I created a program and used this code:

😁 (I spend a lot of time maintaining this program of mine, I'm really lazy busy! 🤣).

好好好（


python312Packages.pytorch-lightning: 2.3.3 -> 2.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pytorch-lightning is: Lightweight PyTorch wrapper for machine learning researchers
meta.homepage for python312Packages.pytorch-lightning is: https://github.com/Lightning-AI/pytorch-lightning
meta.changelog for python312Packages.pytorch-lightning is: https://github.com/Lightning-AI/pytorch-lightning/releases/tag/refs/tags/2.4.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.0 with grep in /nix/store/k5c7f05qb4m786sm6m2kl3zqhlrz17x5-python3.12-pytorch-lightning-2.4.0
found 2.4.0 in filename of file in /nix/store/k5c7f05qb4m786sm6m2kl3zqhlrz17x5-python3.12-pytorch-lightning-2.4.0

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

9 package rebuild(s)

First fifty rebuilds by attrpath

piper-train
python311Packages.finetuning-scheduler
python311Packages.pyannote-audio
python311Packages.pytorch-lightning
python312Packages.finetuning-scheduler
python312Packages.pyannote-audio
python312Packages.pytorch-lightning
whisper-ctranslate2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k5c7f05qb4m786sm6m2kl3zqhlrz17x5-python3.12-pytorch-lightning-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.pytorch-lightning https://github.com/r-ryantm/nixpkgs/archive/1f16df4ab9b8e4fa71585aaf87df233b06f3ca73.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1f16df4ab9b8e4fa71585aaf87df233b06f3ca73#python312Packages.pytorch-lightning

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k5c7f05qb4m786sm6m2kl3zqhlrz17x5-python3.12-pytorch-lightning-2.4.0
ls -la /nix/store/k5c7f05qb4m786sm6m2kl3zqhlrz17x5-python3.12-pytorch-lightning-2.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:

piper-train
piper-train.dist

4 packages failed to build:

python311Packages.finetuning-scheduler
python311Packages.finetuning-scheduler.dist
python312Packages.finetuning-scheduler
python312Packages.finetuning-scheduler.dist

10 packages built:

python311Packages.pyannote-audio
python311Packages.pyannote-audio.dist
python311Packages.pytorch-lightning
python311Packages.pytorch-lightning.dist
python312Packages.pyannote-audio
python312Packages.pyannote-audio.dist
python312Packages.pytorch-lightning
python312Packages.pytorch-lightning.dist
whisper-ctranslate2
whisper-ctranslate2.dist

Maintainer pings
cc @tbenst for testing.

Dup of #333415


SONARMSBRU-42 Forward properties defined in the global sonar-runner.p…

@duncanpMS could you have a look? This code is going to be reverted with http://jira.sonarsource.com/browse/SONARMSBRU-84 - but for the time being it is required to get ITs back to green

(I mean just a code review - I'll re-assign this one back to you for functional validation after it's merged)

LGTM


Restrict access to certain people

At the moment anyone with a google account can login. We need to compare the email address to a whitelist of allowed addresses.

I'm on it


created clone on crash

I filled up my hard drive and crashed my server. Now this villager has a clone. It's certainly better than data loss.

Curious, but I don't think this is a working_villages issue, this may have to do with minetests way of saving the world.


#72 Add code styling stadards git hook

PR for #72, alt PR for #73 to resolve conflicts

Cool. I think all bundles should have something similar. Its very handy.
Maybe afer merging this PR you can close a few issues like https://github.com/aerialship/SamlSPBundle/issues/81
https://github.com/aerialship/SamlSPBundle/issues/72
https://github.com/aerialship/SamlSPBundle/issues/68
https://github.com/aerialship/SamlSPBundle/issues/66

Maybe should increase timeout to 1hr in .scrutinizer.yml since travis for open source is not very fast...
tools:
    external_code_coverage:
        timeout: 3600


Prepare Chromium-based Edge release

The "new Edge" based on Chromium comes out on Jan 15th, but beta/dev/canary builds are already available at https://www.microsoftedgeinsider.com/en-us/.  They support both Windows and Mac (as well as Android).
We should do some initial testing on Cesium to make sure there are no surprises and everything works.  I expect it to go smoothly since it's essentially Chrome.
One thing we should verify is FeatureDetection Currently, FeatureDetection has functions such as isEdge, isChrome, etc.. when the "new Edge" comes out based on Chromium, it's user agent will be changing once again.  We need to figure out if isEdge works on the new Edge or if it's going to return false.  The version number will also jump to be on par with Chrome.
I think what we want is to rename current isEdge and edgeVersion functions to isLegacyEdge and legacyEdgeVersion and just write new versions for the new Edge.  Once "old Edge" is dead (which I think will happen fairly quickly) we can then remove the legacy versions.

I marked this next release since the new Edge is slated for Jan 15th we should at least confirm that Cesium works before our next release.

I did initial testing of Sandcastle examples and no big surprises.  We can do more thorough testing once the official version is out.  I'll leave this open until we know all tests are passing

@mramato can this be closed?  what is left to do here?


Reorganized tests to avoid copy and paste

Instead of having (more or less) the same tests for every solver, we now have tests for specific purposes and define which solvers shall be tested.  This should avoid excessive copy & paste and make the tests clearer.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.61%. Comparing base (aead1d0) to head (fa13dab).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #83       +/-   ##
===========================================
- Coverage   98.19%   86.61%   -11.58%
===========================================
  Files           4        4
  Lines         665      665
===========================================
- Hits          653      576       -77
- Misses         12       89       +77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: "The object type Query has to at least define one field in order to be valid. (HotChocolate.Types.ObjectType)"

What happened?
If a stored procedure doesn't return any resultset, like this one:
create procedure dbo.stpDummy
as
print 'This is dummy'
go

and that stored procedure is used in DAB configuration file, for example:
"entities": {
    "Dummy": {
      "source": {
        "object": "dbo.stpDummy",
        "type": "stored-procedure"
      },
      "permissions": [
        {
          "role": "anonymous",
          "actions": [ "*" ]
        }
      ]
    }
  }

when trying to access the /graphql endpoint, the exception
"The object type `Query` has to at least define one field in order to be valid. (HotChocolate.Types.ObjectType)"

will be generated and no GraphQL schema will be available.
I think there are two options to solve this.
Option 1: a warning is generated in the log output, static that such stored procedure will not be available in GraphQL as no schema is returned. The stored procedure is node made available in the GraphQL endpoint
Option 2: maybe there is an option to tell GraphQL that there is really nothing returned so that we can avoid the error altogheter?
Note that with REST everything works just fine (including the OpenAPI and Swagger support)
Version
Microsoft.DataApiBuilder 0.8.51+9b0304e790689b2604ce40803cd088d1adaf0694
What database are you using?
Azure SQL
What hosting model are you using?
Local (including CLI)
Which API approach are you accessing DAB through?
GraphQL
Relevant log output
Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HMTQQOMKE8LK", Request id "0HMTQQOMKE8LK:00000003": An unhandled exception was thrown by the application.
      HotChocolate.SchemaException: For more details look at the `Errors` property.

      1. The object type `Query` has to at least define one field in order to be valid. (HotChocolate.Types.ObjectType)

         at HotChocolate.Configuration.TypeInitializer.Initialize()
         at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types, LazySchema lazySchema)
         at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context)
         at HotChocolate.SchemaBuilder.Create(IDescriptorContext context)
         at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create(IDescriptorContext context)
         at HotChocolate.Execution.RequestExecutorResolver.CreateSchemaAsync(NameString schemaName, RequestExecutorSetup options, RequestExecutorOptions executorOptions, IServiceProvider serviceProvider, TypeModuleChangeMonitor typeModuleChangeMonitor, CancellationToken cancellationToken)
         at HotChocolate.Execution.RequestExecutorResolver.CreateSchemaServicesAsync(NameString schemaName, RequestExecutorSetup options, CancellationToken cancellationToken)
         at HotChocolate.Execution.RequestExecutorResolver.GetRequestExecutorNoLockAsync(NameString schemaName, CancellationToken cancellationToken)
         at HotChocolate.Execution.RequestExecutorResolver.GetRequestExecutorAsync(NameString schemaName, CancellationToken cancellationToken)
         at HotChocolate.Execution.RequestExecutorProxy.GetRequestExecutorAsync(CancellationToken cancellationToken)
         at HotChocolate.AspNetCore.HttpPostMiddlewareBase.HandleRequestAsync(HttpContext context, AllowedContentType contentType)
         at HotChocolate.AspNetCore.HttpPostMiddlewareBase.InvokeAsync(HttpContext context)
         at Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.<>c__DisplayClass13_0.<<UseCancellation>b__1>d.MoveNext()
      --- End of stack trace from previous location ---
         at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
         at Azure.DataApiBuilder.Core.Authorization.ClientRoleHeaderAuthorizationMiddleware.Invoke(HttpContext httpContext)
         at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
         at Azure.DataApiBuilder.Core.AuthenticationHelpers.ClientRoleHeaderAuthenticationMiddleware.InvokeAsync(HttpContext httpContext)
         at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
         at Azure.DataApiBuilder.Service.Startup.<>c__DisplayClass10_0.<<Configure>b__3>d.MoveNext()
      --- End of stack trace from previous location ---
         at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)
         at Azure.DataApiBuilder.Core.Services.PathRewriteMiddleware.InvokeAsync(HttpContext httpContext)
         at Azure.DataApiBuilder.Core.Services.CorrelationIdMiddleware.Invoke(HttpContext httpContext)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I did other tests and it seems that the problem is with stored procedures in general. I tested this stored procedure:
create or alter procedure dbo.stp_Dummy2
as
select * from (values(10,20),(30,40)) as t (col1, col2)
go

with this configuration:
"Dummy2": {
      "source": {
        "type": "stored-procedure",
        "object": "dbo.stp_Dummy2"
      },
      "permissions": [
        {
          "role": "anonymous",
          "actions": [
            "execute"
          ]
        }
      ]
    }

and have the same issue.

Issue, by design, but can be updated in docs:

GraphQL Schemas require at least one field (query) in the root Query field. When you define one entity in the DAB config and it is a stored procedure, stored procedures default to mutations. This will result in a failure to generate a GraphQL schema.
Explicitly set the single stored procedure entity to be generated in the GraphQL schema as a query:

     "graphql": {
       "operation": "query"
     }

The following entities section configuration works as intended because at least one of the entities is defined as a query:
 "entities": {
   "Dummy2": {
     "source": {
       "type": "stored-procedure",
       "object": "dbo.stp_Dummy2"
     },
     "graphql": {
       "operation": "mutation"
     },
     "permissions": [
       {
         "role": "anonymous",
         "actions": [
           "execute"
         ]
       }
     ]
   },
   "Dummy3": {
     "source": {
       "type": "stored-procedure",
       "object": "dbo.stp_Dummy2"
     },
     "graphql": {
       "operation": "query"
     },
     "permissions": [
       {
         "role": "anonymous",
         "actions": [
           "execute"
         ]
       }
     ]
   }
 }

The following query/mutation can be used:
query execDummy3QuerySP {
  executeDummy3{
    col1
    col2
  }
}

mutation execDummy2MutationSP {
  executeDummy2 {
    col1
    col2
  }
}

Result:
{
  "data": {
    "executeDummy3": [
      {
        "col1": 10,
        "col2": 20
      },
      {
        "col1": 30,
        "col2": 40
      }
    ]
  }
}

Thanks, that makes sense. The error I got wasn't helping and I thought it was a bug, but it really isn't. Same goes for the first problem mentioned in this issue, stored procedures without any resultset works perfectly fine. Definitely a mention to the documentation is needed.


Instance Segmentation

Forgive me if this is obviously covered in the README, but I wonder whether you've trained this on the task of instance segmentation.
So in other words, instead of using ShapeNet parts where all table legs have the same label, you might want each individual part to be separated from the others.
More specifically, do you have results relating to that, or intuition on whether using the same procedure for Object Segmentation you describe would generalise well to this task?
Thanks!

Hi @snakch,
No, I have not trained a KPConv network on an instance segmentation task (neither on a panoptic segmentation task btw). The network architecture is very similar to an image network, so it is definitely possible to adapt my segmentation architecture to detect instances by imitating instance segmentation strategies in other works like mask R-CNN. However, it would require a lot of coding, as implementing a deep point cloud network is not as easy as implementing image networks.
You can also have a look at other works that perform instance segmentation on point clouds and replicate their idea with KPConv architecture. I think of Deep Hough Voting or Occuseg for example. Have a look at the 3D Semantic instance benchmark on the scannet benchmark for a good overview on the state of the art methods.
Best,
Hugues

Thank you this makes sense!
Incidentally, while reading this paper https://arxiv.org/pdf/2010.15157.pdf I noticed that they compare their panoptic seg results to a combo of KPConv and either RangeNet ++ or PointPillars, meaning there exists such implementations out there. As far as I could find, they're not open-sourced but oh-well.
Anyway, thanks!


glob support in exclude list

It would be incredibly useful if there was some kind of glob support for exclude:
For example, */build/* to exclude everything from directories in a /build/.

Good suggestion, will try to have something for this in the next release.

I ended up adding support for the gitignore pattern format. I think this will be a nice improvement, given it's much more expressive than what I had before and is somewhat standardized.
Although this includes globs, now you should be able to just use an entry like build/ for your example use case. The change is included in the latest release v0.2.3.


Upgrade tutorial scripts

Not sure how often we need NO_AUTO_COPYRIGHT, but we either have duplicates or it is missing from one of the folders


Test Selinium Web app

Posted by @jslee5 on teams:
Here are a few test cases I'm looking into possibly running on our tutorial site. Nothing set in stone just a few ideas for our coding team to know what they will be tested on.
Verify Website Loading: Ensure that the Selenium tutorial site loads successfully without any errors.
Login Test: Test the login functionality by entering valid credentials and verify that the user is logged in successfully.
Invalid Login Test: Attempt to log in with invalid credentials and confirm that the appropriate error message is displayed.
Logout Test: Log in first and then test the logout functionality to ensure that the user is logged out successfully.
Navigation Test: Verify that all main navigation links (e.g., Home, Tutorials, About Us, Contact) lead to the correct pages when clicked.
Search Functionality Test: Test the search functionality by entering a keyword, clicking the search button, and confirming that the relevant search results are displayed.
Tutorial Page Test: Click on a tutorial link, and verify that the tutorial page loads correctly with content and images.


Fix determination of line-breaing parent element. #1548.

Fix determination of line-breaing parent element.  It was moving too high in some cases.  E.g., in
  <mrow>
    <msqrt>
      ...
    </msqrt>
  </mrow>

the inferred mrow in the msqrt was stepping out to the msqrt (correctly) but then stepped out to the mrow and its parent (since it was an mrow with one child).  The change to parent.isEmbellished() causes the stepping out to occur only when the outer mrow represents an embellished operator.  (We only want isTop to be true in that case.)
Resolves issue #1548.

lgtm.


Code for query types

Hello,
I would like to check the code for each query type(e.g. "high-cpu-all", "lastpoint"), and to edit it for benchmarking reasons but i didn't find it here. Am i missing something?

Yes I'd like to see that too.


Module/single-port-sg: Support source_security_group

name: Pull request template
about: Make a PR to terraform-aws-foundation
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's.  Including these will more likely lead
to your PR being reviewed and accepted.

[ ] Update the changelog
[ ] Make sure that modules and files are documented. This can be done inside the module and files.
[ ] Make sure that new modules directories contain a basic README.md file.
[ ] Make sure that the module is added to tests/main.tf
[ ] Make sure that the linting passes on CI.
[ ] Make sure that there is an up to date example for your code:
- For new modules this would entail example code for how to use the module or some explanation in the module readme.
- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
[ ] Make sure that there is a manual CI trigger that can test the deployment.

Is there a way to use this without a targeted apply? I'm running into this situation that I think is stemming from the changes in the PR:
count                    = local.udp * local.by_src_sg

The "count" value depends on resource attributes that cannot be determined
until apply, so Terraform cannot predict how many instances will be created.
To work around this, use the -target argument to first apply only the
resources that the count depends on.

I feel like this is a dep issue. I got this while destroying resources again. The source SG was gone (and this rule), but TF says it cannot calculate the count.
The reason I do it this way is that, source_security_group and cidr_blocks cannot be set at the same time, even one is an empty value.

@Magicloud please update the above, TY!

Updated new design. Tested in PR https://github.com/fpco/terraform-aws-foundation/pull/304.