TS-3607: Integrate ats_pagespeed into the automake build

This commit adds _STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS to
fix the missing macros defined in stdint.h when building a C++ source
code.

Great! LGTM

Wait, why isn't page speed integrated into the automake build? We add these macros to the build globally at configuration time.

@jpeach Because the pagespeed libraries currently do not support all the platforms that ATS does, so some work has to be done to exclude the plugin in some platform builds.

That's fine, we have other stuff that only builds when it's dependencies are available. I'm happy to advise if you want help doing this in autotools.

How does it look? I'm quite new in writing autotools. Is it ok to rename gzip.so to ats_pagespeed_gzip.so? Documentation would need an update too.

@caguado my 2p is that renaming the specific gzip module for ats_pagespeed is fine for now.
From the top of my head the gzip version from ats_pagespeed is nearly identical to the real one.
I will have a look at merging and eliminating this gzip plugin for later.

https://issues.apache.org/jira/browse/TS-3607

@oschaaf can you please work on this and get it committed?

@bryancall yes. We've got some changes in our pipeline as well, I'll follow up shortly.

@oschaaf  Ping!

Change looks good to me! What is the flow with regard to committing a pull request?

Easiest is to look at the Jira, which has instructions how to merge and push. Make sure you "git pull --rebase" before you push upstream to ASF, otherwise the "Committer" field isn't update properly. Basically, we want the author to be the person submitting the PR, but you as the committer should show up as well (so we can see who actually pushed it).

@zwoop thanks!

Ping @oschaaf . Also, Otto, you must do the git-dual setup steps to make your account properly enabled here, otherwise, we can't assign PR's to you.

@zwoop done

Can one of the admins verify this patch?

The patch looks good to me, but @jpeach had an improvement in mind. @jpeach would you be OK with committing this and doing https://github.com/apache/trafficserver/pull/210#discussion_r57108812 in a follow-up?

Sure either way is fine.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

This unfortunately now runs into issues with clang-format. Can you rebase, and run clang-format again, and then force push? See
https://ci.trafficserver.apache.org/view/github/job/Github-Linux/70/

.

Rebased against current 5.3.x and passed clang-format.
@jpeach, please let me know whether this is what you had in mind.

We still need an update to this. @oschaaf and @jpeach , assigning to you for final reviews, but we should try to land this assuming it seems reasonable (once clang-format etc. has been addressed).

This would be a great to add pagespeed to the build.  The patch would need to be updated against the master branch.

I haven't seen an update to this PR for awhile.  I will close it in a week if it hasn't been updated.

Please reopen or create another pull request if you want to resolve this.


Reenable fetching references for cncf/xds module

This one works now because the new dependency https://buf.build/google/cel-spec is already being synced.

Successfully tested: https://github.com/bufbuild/modules/pull/368


Problem with non-UTF8 encoded RSS feed

Hi,
thanks for a great script, it does exactly what need, however I get garbled umlaut special characters for an RSS feed which is encoded in charset=ISO-8859-1.
Does feedrapp.info not handle RSS feeds which are not UTF8 encoded? Unfortunately the site providing the RSS feed is not run by me, so I cannot influence the RRS feed encoding.
Many thanks!
P.

Do you have an example feed?

We had a problem with this feed: http://www.comicforum.de/external.php?type=rss2&forumids=36&lastpost=1 unfortunately the website http://www.comicforum.de seems to have a problem this afternoon, so it is not reachable at the moment...
Thanks!

Guess I could try to forward a property during the API request to axios: https://github.com/axios/axios/pull/869. Something like
feedrapp.info?q=url&charset=ISO-8859-1

Are you saying this is already woking with
&charset=ISO-8859-1
or is this a proposed implementation?

Proposal :) will have a look during the weekend

Am 01.11.2019 um 21:29 schrieb philoupin<EMAIL_ADDRESS>
Are you saying this is already woking with
&charset=ISO-8859-1
or is this a proposed implementation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I need to do some more testing but there is this: https://github.com/sdepold/feedrapp/commit/3d161a5b86be02c3d67a30d8cfa7a532cbbf5024

And the feature has landed in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Just set the option encoding to ISO-8859-1 and you should be good to go


Update neo4j python driver

Updated neo4j python driver as it should not contain the performance issues as in neo4j itself. Atleast working without any problems so far:

Why not the latest version ?

ok for me and even using the latest 5.18

Why not the latest version ?

It is using 5.18 when you look at the lock file.

ah yeah good catch ^^


Chunk VBOs should be interleaved

To reduce VBO binds, combine position, color, normal, and id into one VBO

Using VAOs now. This likely won't help, but still probably good to do.

LibGDX deals with this now


KEIL AC6编译报错

./components/cm_backtrace\cm_backtrace.h(32): warning: In file included from...
./components/cm_backtrace/cmb_def.h(364): error: function definition is not allowed here
attribute( (always_inline) ) static __inline uint32_t cmb_get_msp(void) {
^
./components/cm_backtrace/cmb_def.h(369): error: function definition is not allowed here
attribute( (always_inline) ) static __inline uint32_t cmb_get_psp(void) {
^
./components/cm_backtrace/cmb_def.h(374): error: function definition is not allowed here
attribute( (always_inline) ) static __inline uint32_t cmb_get_sp(void) {

Error: L6218E: Undefined symbol Image$$ER_IROM1$$Base (referred from cm_backtrace.o).
Error: L6218E: Undefined symbol Image$$ER_IROM1$$Limit (referred from cm_backtrace.o).
Warning: L6330W: Undefined symbol STACK$$Base (referred from cm_backtrace.o). Unused section has been removed.
Warning: L6330W: Undefined symbol STACK$$Limit (referred from cm_backtrace.o). Unused section has been removed.

Error: L6218E: Undefined symbol Image$$ER_IROM1$$Base (referred from cm_backtrace.o). Error: L6218E: Undefined symbol Image$$ER_IROM1$$Limit (referred from cm_backtrace.o). Warning: L6330W: Undefined symbol STACK$$Base (referred from cm_backtrace.o). Unused section has been removed. Warning: L6330W: Undefined symbol STACK$$Limit (referred from cm_backtrace.o). Unused section has been removed.

https://my.oschina.net/u/4428324/blog/4623734
reset your "stack" begin name and "Irom1" name in def.h,it's from your mcu's start file and your scf file

Error: L6218E: Undefined symbol Image$$ER_IROM1$$Base (referred from cm_backtrace.o). Error: L6218E: Undefined symbol Image$$ER_IROM1$$Limit (referred from cm_backtrace.o). Warning: L6330W: Undefined symbol STACK$$Base (referred from cm_backtrace.o). Unused section has been removed. Warning: L6330W: Undefined symbol STACK$$Limit (referred from cm_backtrace.o). Unused section has been removed.

链接文件没有定义这几个地址

Error: L6218E: Undefined symbol Image$$ER_IROM1$$Base (referred from cm_backtrace.o). Error: L6218E: Undefined symbol Image$$ER_IROM1$$Limit (referred from cm_backtrace.o). Warning: L6330W: Undefined symbol STACK$$Base (referred from cm_backtrace.o). Unused section has been removed. Warning: L6330W: Undefined symbol STACK$$Limit (referred from cm_backtrace.o). Unused section has been removed.

链接文件没有定义这几个地址

意思是那个配置文件.h的那个默认的STACK和IROM你要按照你自己的项目的.s文件的启动stack名和rom名来替换


Fixed some usecases in ZPOPMIN command and updated documentation

Changes made:

Made some changes in GETMIN function in sorted_set.go
Updated tests with the new assert package
Updated Documentation to follow new documentation template

@apoorvyadav1111 @JyotinderSingh .
I have made some fixes related to ZPOPMIN command. Can you please review this PR


Maya: Rendering multilayer EXR images always resulting into names with "_beauty" suffix

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?
When rendering from maya host in Deadline and having set merge AOVs option leading to single image file containing all AOVs  results into rendered image with <filename>_beauty.exr even tho there is no reason to append the _beauty suffix as it contains all RGBA data not just beauty component.
Currently there is now way to produce renders without _beauty suffix for multilayer EXR.
Here are staged files when rendering (all seems normal):

And when rendered and published (containing the "_beauty" suffix which cant be turned off)

How would you imagine the implementation of the feature?
When rendering into multilayer EXR containing all AOVs (merged) there should not be appended _beauty suffix at all. But only when multiple files being produced and such file might contain just the beauty component.
There should be Template naming used for such a task as now it is not ...being somewhat hardcoded as seen here
Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:
No response
Additional context:
No response

Maybe solved by this PR

@LiborBatek is this still present for Maya? If so, should this move to the ayon-maya repo?

@BigRoy it should be already resolved by using Publish Templates with  token ...can be closed IMHO

Thanks. Feel free to re-open on ayon-maya if you find new issues.

resolved by using Publish Templates

If there were specific changes need in settings for this it may be good to mention the required changes here so we have it as a reference for the backlog.


New blog link - CodeCouple.pl

Coverage remained the same at 68.25% when pulling f07616a9787edffaa0c3ab8492667d0369956e5e on kchrusciel:master into e093a8a83df53c091c17f6c346083ffad95f62ac on tdziurko:master.


CMake creates config.mk and installs config.mk and test.mk [cwsmith/cmake_create_config.mk]

This was tested with a spack install of hypre, metis, zlib, and pumi.
My mfem cmake script is below:
#!/bin/bash -ex
usage="Usage: $0 <path to mfem source> <enable pumi=0|1>"
[ $# -ne 2 ] && echo $usage && exit 1
src=$1
[ ! -e $src ] && echo "mfem source dir '$src' is not accessible" && exit 1
pumi=$2
[[ $pumi -ne 0 &&  $pumi -ne 1 ]] && echo $usage && exit 1
use_pumi=ON
[ $pumi == 0 ] && use_pumi=OFF

hypre=`spack location -i hypre`
metis=`spack location -i metis`
zlib=`spack location -i zlib`
pumi=`spack location -i pumi`

cmake $src \
-DCPPFLAGS="-DFOO=1" \
-DCMAKE_CXX_COMPILER=mpicxx \
-DCMAKE_CXX_FLAGS='-g -O2' \
-DMFEM_USE_MPI=ON \
-DHYPRE_DIR=$hypre \
-DMETIS_DIR=$metis \
-DZLIB_DIR=$zlib \
-DMFEM_USE_PUMI=$use_pumi \
-DPUMI_DIR=$pumi \
-DCMAKE_INSTALL_PREFIX=$PWD/install

So, assuming the above script is named config-mfem.sh the mfem install sequence is:
git clone git@github.com:cwsmith/mfem
git checkout cwsmith/cmake_create_config.mk
mkdir build-mfem
cd build-mfem
/path/to/config-mfem.sh ../mfem 1 # build with pumi enabled
make install -j

Laghos can then be built with:
git clone git@github.com:CEED/Laghos.git
d=/path/to/mfem/install/dir
make MFEM_DIR=$d CONFIG_MK=$d/share/mfem/config.mk TEST_MK=$d/share/mfem/test.mk

Resolves #312

I'm fixing the build without pumi now that appveyor found.

Thanks for doing this @cwsmith!
Added a note that it resolves #312.

@cwsmith, can you give me permission to push to your branch - I have some small additions and changes I want to push.

@v-dobrev I sent you an invite.

Looks good to me.  Following the instructions from the OP, I was able to successfully build and run Laghos.
CMake has CMAKE_SHARED_LIBRARY_CXX_FLAGS.  The policy here:
https://cmake.org/cmake/help/v3.12/policy/CMP0018.html?highlight=cmake_shared_library_ lang _flags
indicates that the logic for creating PIC libs has changed, but, as I understand, this variable will remain in cmake and we can read from it to get the flag.  The part that leaves me in some doubt is the statement that there are 'new undocumented platform variables to select (PIC) flags'.  It seems like using one of those may be more future proof... if using undocumented variables can be considered safe at all.
If there is a resident cmake expert we can consult with it may be a good idea to double check this.

Thanks @cwsmith!
I tried your suggestion to use the variable CMAKE_SHARED_LIBRARY_CXX_FLAGS instead of the hard-coded -fPIC value and it worked for me, so I made the change.


Proposal: Tag to indicate the podcast is "podpinging"

Hello All,
As a developer of a podcast aggregator, I like the idea of "watching" the Hive blockchain for updates.
It would be interesting to have information in the feed that indicates I can rely on the hive blockchain information instead of polling the feed from time to time.
This is also an opportunity to consolidate it as a decentralized podcast and include information on the feed that allows the client to validate if the information on the blockchain was inserted by a trusted "writer" (I don't know the terms here, is it an account? a public key? something like that).

Really interesting. It would solve the problem where the app doesn't know when to stop polling the RSS feed, and when to resume polling the RSS feed too in case the publisher choses to quit/suspend using podping. The latter might not be great for us, but developers must be sure their apps data don't get stale.

I'm 100% for this and I think the feed should absolutely include the authorised Hive account which might be unique to that podcast or a standard one for a given Host.
Right now all of rss.com transistor.fm, buzzsprout and captivate would list hivehydra
<podcast:podping authorized="hivehydra">

I'm not thinking that the watcher will check for the authorised account (it's too big an operation) but there could be a dedicated server that scans for feeds declaring a new hive account that hasn't been seen before to automate the process of allowing new accounts to Ping in the future.

I'm also 100% for this!

And @daveajones  the PodcastIndex probably should have a database entry and api call for authorized podping sender which will serve as a way of knowing if a show needs to be polled or can just be watched for on Podping.

This is the draft I wrote, perhaps it's a bit early to send a pull request.
The "podcast:podping" Sepcification
Version 1.0 by Brian of London - 2021.06.08

Purpose
The Podping notification system is rapidly developing as a new standard for signalling new episodes of podcasts to reduce constant polling. Once a new episode or entirely new podcast is sent out as a podping on the Hive blockchain, aggregators and apps can query the feed.
However, as pointed out in issue https://github.com/Podcastindex-org/podcast-namespace/issues/258, there is, as yet, no way to know which feeds are using Podping.
This tag proposal will allow feed owners and the hosts of multiple feeds, to signal that future updates will be sent via Podping and there is no need to speculatively poll this rss feed.
An additional benefit will derive if feeds signal the name or names of the Hive accounts authorized to send Podpings. These authorized Hive accounts will be included in a <podcast:podpingAuth> tag
API Requirements
This tag can also contribute to a future API endpoint for the PodcastIndex which can easily return whether or not any given RSS feed is using Podping and return the Hive accounts authorized to send pings.
Specification
For the <podcast:podping> tag there are no attributes.
For the optional but helpful <podcast:podpingAuth> tag there is one attribute, a single value with a single allowed Hive account.
Example
<podcast:podping>
    <podcast:podpingAuth account="hivehydra"/>
    <podcast:podpingAuth account="hive-hydra"/>
</podcast:podping>

As for how the tags go, I'm not sure if XML it would be better to do this:
<podcast:podping>
    <podcast:podpingAuth>hivehydra</podcast:podpingAuth>
    <podcast:podpingAuth>hive-hydra</podcast:podpingAuth>
</podcast:podping>

I'm currently working on 3speak RSS feeds and while it makes sense to notify that this feed uses podping, the idea of saying which Hive account can actually send the notification doesn't make a lot of sense and we're unlikely to every use that feature.
I'm thinking that this is more appropriate.
        <podcast:podping usesPodping="true"/>

Phase 4

There's no harm in sticking that in feeds right now is there?

No harm other than having to change it later if it gets altered.  It'll be universally ignored now, so it's not going to hurt anything.

Let's close this issue, it's taken over by the Proposal for Podping tag


if you edit a query after submitting a search it should reset

This perhaps matters more once history is implemented.

Maybe: History for searches and Undo/Redo for app state.


Remove for-of loop for es3 compatibility

Heya - how about the attached PR?  for..of generates code dependent on Symbols.  By replacing it  with an old-school for-loop, there's no need to include babel-polyfill for older browsers.

Thanks Jonathan!


file path to language association settings need window reload to work for existing files

testing #3925
OS: Linux

configure "file path to language association settings"

Observe: existing files that match the path or extension do not show the new language when opened in an editor.
If this cannot be fixed I suggest to add a comment like this: "This setting requires reload/restart of VSCode to take effect."

@weinand it should have this comment in the settings, or do you mean somewhere else?

@bpasero yes, like other settings with the same requirement.

:+1:

Now reads like this:

@bpasero how do I get this info notification?

@weinand when selecting "Configure file associations..." after you click on the language mode in the status bar.

@bpasero aha, I've never used that action. I always changed the associations in the settings.


[FX-5762] Completely hide axis when needed

FX-5762
Description
Describe the changes and motivations for the pull request.
How to test

Temploy
Compare with https://picasso.toptal.net/?path=/story/picasso-charts-barchart--barchart

Screenshots
Comparison with master
https://github.com/user-attachments/assets/62a7211a-1768-4c5c-b154-21719287e9c4
Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[N/A] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[N/A] Annotate all props in component with documentation
[N/A] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


[DOC] Create better info on staking pool contract for validator nodes

Is your feature request related to a problem? Please describe.
Validator nodes can make changes to the staking smart contract instead of all using the same ones. Certain amount of innovation can be done on this smart contract to attract stakes
Describe the solution you'd like
Better documentation on this https://github.com/near/core-contracts/tree/master/staking-pool to foster innovation

Yep, this could be a game changer. Unclear whitelisting process for custom staking pool contract is the blocker here (from my perspective).


Support for ALPHA ESS Wallbox

Hey there,
I'm using the integration for a while now. I'm planning to install a WallBox for charging an electric car. Now I wonder if the integration supports an ALPHA ESS Wallbox and allows control of charging behavior etc.
Best regards and thanks for your contribution to us!

Hey there, we currently pull all the data we can from the offical alphaESS openapi. which the full list of what we get is here (you need an openAPI account to see).
You could maybe make an issue here and suggest it? not sure how far it will go tho, as the lead dude isn't too cooperative at the best of times


[1.2.0] Unable to exclude new core plugins in tailwind config

Hi there,
Just updated to v1.2 today and noticed that autoprefixer was really noisy - I'm using autoprefixer grid: autoplace for IE 11 CSS grid support. It seems the new grid utilities are causing the warnings because they're unable to prefix for IE 11. IE support
So, I decided I would disable the new utilities for now, updated the corePlugins in my tailwind.config.js, setting the new utilities to false but they all still are compiling. If I revert back to 1.1.4, my utitlities set to false (ie. wordBreak) work as expected and the CSS for these is excluded.

Hi, could you elaborate on how you excluded the new core plugins?
I just did this and it's working fine for me.
  corePlugins: {
    // Disable Grid classes
    gap: false,
    rowGap: false,
    gridTemplateColumns: false,
    gridTemplateRows: false,
    gridColumn: false,
    gridColumnStart: false,
    gridColumnEnd: false,
    gridAutoFlow: false,
    gridRow: false,
    gridRowStart: false,
    gridRowEnd: false,
    columnGap: false
}

@Macxim I have added them to the corePlugins in my tailwind.config.js.
However, I've tried again on a few repositories this morning and it looks like the issue must have been with my code. Disabling the core plugins does seem to work as intended. Apologies for the confusion - facepalm


Add Base IRI to objects with relative IRIs

Hi everyone,
the R2RML specification says the base IRI is added to a term if the term map's term type is rr:IRI and the IRI is relative. As far as I understand, in the current version, this behavior is implemented only with respect to subjects so I modified the Executor to behave similarly also for named objects. Please let me know if the behavior described is correct and, eventually if the proposed changes can be the right way to introduce the modification. I tested it and it seems to behave as expected.

@marioscrock thank you for your remark. I will let one of the other guys look into the implementation but I will just add a clarification following your comment:
There are actually multiple ways of generating an IRI in RML and we need to make sure that the base IRI is properly handled in all cases. I think the table in this chapter: http://ebooks.iospress.nl/volumearticle/56006 has a very detailed table with all possible cases.

@marioscrock thank you for your remark. I will let one of the other guys look into the implementation but I will just add a clarification following your comment:
There are actually multiple ways of generating an IRI in RML and we need to make sure that the base IRI is properly handled in all cases. I think the table in this chapter: http://ebooks.iospress.nl/volumearticle/56006 has a very detailed table with all possible cases.

Thank you @DylanVanAssche and @andimou for your reply and very detailed explanation. I think this pull request is associated with a quite old version of the source code, so if you prefer we can close it and maybe add an issue on this topic.
Some comments on the proposed patch:

I assumed isValidIRI performed the checks mentioned
To avoid the problem of dealing with different Term Maps and term types, I added the patch before writing the triples in the output store and checking only for NamedNodes. However, I agree that a set of tests should be defined to check that all the possible cases are handled correctly (relevant also for ?)

@marioscrock
Yes, the validation of IRIs is verified using isValidIRI but does not enforce the R2RML conditions mentioned in the spec to easily concat them.
Indeed, we need a set of test cases first, we can discuss that at https://github.com/kg-construct/rml-test-cases-support :)


[bug] Extension no longer detects installed wallets when Wagmi config changes

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.1.2
wagmi Version
2.10.7
Current Behavior
Whenever the config provided to WagmiProvider changes it breaks "Installed" wallets detection in the RainbowKit modal.
Expected Behavior
I expect the installed wallets list to remain the same despite what happens to the config object.
Steps To Reproduce

Navigate to Superbridge and click "Connect"
Observe the "Installed" wallets list
Close the modal
Click the settings cog and turn on Testnets
Click "Connect"
Observe missing "Installed" wallets list

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
See https://github.com/rainbow-me/rainbowkit/issues/1839 for another issue we had when the config object changes.

@AlexBHarley Can you provide a minimal reproducible example on how your Wagmi config changes ?

Going to close this issue for now. Feel free to re-open this if you're still stuck.

@magiziz here's a reproduction https://jlqqqp-5173.csb.app/

Ensure you have some browser extension wallets installed
Click "Connect"
Observe the "Installed" wallets list
Connect a wallet
Disconnect
Toggle the chains list
Click "Connect"
Observe missing "Installed" wallets list

@AlexBHarley Are you able to move getDefaultConfig outside of your component ? Possibly putting it in a wagmi.ts file ? Both Wagmi and RainbowKit documentation shows that you should have getDefaultConfig / createConfig outside of React components.
Since if you're not putting getDefaultConfig outside of your <App /> component then it'll cause re-renders which would result into Wagmi state being reset.
We've also had situations where users wanted to change chains in getDefaultConfig / createConfig and we've suggested them to include all of their chains, but only show / filter the supported ones in frontend.

Got it, yes doable for us.

What do we do if we need to dynamically change the list of chains the user is allowed to connect to? For example, let's say it's a store, and product A can only be purchase on Mainnet, but product B can only be purchase on Arbitrum and Polygon. We can't just include all the chains, since most of them make no sense.
You suggest showing/filtering in the frontend, but how do we that in Rainbowkit itself? Specifically in the chain selector:

@ZimM-LostPolygon In that case i'd suggest building your own chains modal where you filter the supported chains. Currently the chain modal gets the chains from createConfig / getDefaultConfig.

@magiziz That's a theoretical option. But I believe you understand how this is a gargantuan amount of work for something seemingly so special, especially considering everything worked flawlessly as-is in 1.x.
If at least there is an option to override the list of "visible"/"active" chains, that would pretty make everything just work again with minimal code changes compared to 1.x. Can this be considered?
Thank you!

@ZimM-LostPolygon Yeah i know, we realized that in 1.x we were doing some double work that wasn't needed, e.g we already defined chains for wagmi and defined them again in RainbowKitProvider.
I know that this is a breaking change, but this solution works for us as of now. Another thing we could do is to maybe expose a prop to ChainModal so we can filter out the unnecessary chains that's not needed. Is this something that'd be useful in your case ?

@ZimM-LostPolygon Yeah i know, we realized that in 1.x we were doing some double work that wasn't needed, e.g we already defined chains for wagmi and defined them again in RainbowKitProvider.
I know that this is a breaking change, but this solution works for us as of now. Another thing we could do is to maybe expose a parameter to useChainModal hook so we can filter out the chains that's not needed. Is this something that'd be useful in your case ?

@magiziz I only use <ConnectButton> and nothing else, so unless that parameter can be passed to <ConnectButton>, it's not going to help in my case, unfortunately...

@ZimM-LostPolygon Gotcha. You could use <ConnectButton.Custom> component to add custom connect button if that's helpful by any chance ? https://www.rainbowkit.com/docs/custom-connect-button.

@magiziz It's much of the same issue as writing my own modal. I don't want to implement my own thing from scratch, that would only be beneficial if I needed to do some truly big changes. I'm perfectly happy with the visuals and 99% of the behavior of <ConnectButton>, and I do want to benefit from RainbowKit updates instead of having to maintain my own custom implementations, I just that small change to limit the chain list.
Even if I were to use <ConnectButton.Custom>, there doesn't seem to be a way to preserve the original look, as all the CSS styles are minified and with obfuscated class names, which means I have to make my own layout/styles for the button as well. I personally feel there just should be some kind of extension point for more advanced users that doesn't require basically writing their Rainbowkit variant.
Those are just my thoughts, though, I understand that this might not be the most popular request. Just wish RainbowKit allowed for some more customization in existing components, instead of requiring to completely abandon them for every tiny change.

@ZimM-LostPolygon Got it. I'll look into this more and let you know as soon as possible, but i can't guarantee 100%.


Before the first city is built, revealing a science hut opens up a menu to choose the research for next advance

Menu for research of next advance should be opened up only after the first city is built.

That's a bug, I'll fix it in the next version.


[P1] Storage: Make GeoReplicationStatus a regular enum

https://apiview.azurewebsites.net/Assemblies/Review/231f6f1802d44c8e9f7c1bfe0819a413#Azure.Storage.Queues.Models.GeoReplicationStatus
We have one for Blobs/Files/Queues.  Note that it will get renamed by #8148.

Files: We don't have GeoReplicationStatus in Files.
Blobs: It is already a regular enum for Blobs.
Queues: PR  is out to make this a regular enum for Queues.

Closed with https://github.com/Azure/azure-sdk-for-net/pull/8197#event-2723097278


Some issues with floating point literal parsing

Case I:
function foo() {
    float f = 5.;
}

Above is parsed as a valid code.
Case II:
function foo() {
    float f = 5.4e;
}

Above gives multiple error messages for a single error. Below are the error messages and the resulting tree.
// Error messages
xxx.bal:0:0:missing digit
xxx.bal:0:0:invalid token '5.4e'
xxx.bal:0:0:missing  MISSING[]

// Resulting tree
function foo() {
    float f =  MISSING[]5.4e;
}

Case III
function foo() {
    float f = 5.e1;
}

Above also get parsed as a valid code.

@SupunS I allowed case I and III intentionally. Test cases for them also added.
floating-point-literal := DecimalFloatingPointNumber
DecimalFloatingPointNumber := DottedDecimalNumber [Exponent] [FloatingPointTypeSuffix]
DottedDecimalNumber := DecimalNumber . Digit*

IIUC , DecimalNumber . Digit* means it is allowed have no digits after dot token right?

I will have a look on case II. :)

@SupunS I allowed case I and III intentionally. Test cases for them also added.
floating-point-literal := DecimalFloatingPointNumber
DecimalFloatingPointNumber := DottedDecimalNumber [Exponent] [FloatingPointTypeSuffix]
DottedDecimalNumber := DecimalNumber . Digit*

IIUC , DecimalNumber . Digit* means it is allowed have no digits after dot token right?

I see. Yes you are correct. I didn't notice that part.

I think for case-III, we can can log an error in the lexer, but still return a valid floating-point-literal token, so that the rest of the parser will work normally.. WDYT?

I think for case-III, we can log an error in the lexer, but still return a valid floating-point-literal token, so that the rest of the parser will work normally.. WDYT?

Case III should be fine. I think you are referring to case II here. Yeah we can do that change. +1

Yes, I meant Case-II

Similar to case II, we have another two scenarios where numerical literals are processed as invalid tokens.

When an int or a float starts with a zero. e.g. float f = 02.3
When hex-digit starts with a dot token and there's no at least one hex-digit after that.  e.g. float f = 0x.p12

Are we going to allow them to parse as well while logging an error at lexer level?

hmm.. yeah we should do that.
Anyway, I'm lowering the priority of the issue since this doesn't break any code, and only an improvement.


I am getting CLS issue of unsupported CSS property: width

How to fix unsupported CSS property: width (CLS issue) of slick slider.

Also getting this issue with both color and visibility properties.


I put it down waiting for #13147, which merged yesterday. Will pick up again today

Reviewed 21 of 109 files at r1, 89 of 89 files at r2.
Review status: all files reviewed at latest revision, 30 unresolved discussions, some commit checks failed.

include/grpc/grpc.h, line 414 at r2 (raw file):

/** Enable or disable a tracer.

    TraceFlags (usually controlled by the environment variable GRPC_TRACE)

Cosmetic nit: Do we need to refer to TraceFlags here, since that's not exposed as part of the API?

src/core/ext/filters/client_channel/client_channel_plugin.cc, line 82 at r2 (raw file):

  grpc_http_connect_register_handshaker_factory();

#ifndef NDEBUG

Don't need this anymore.

src/core/ext/filters/client_channel/lb_policy.h, line 37 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_lb_policy_refcount;

DebugOnlyTraceFlag

src/core/ext/filters/client_channel/resolver.h, line 33 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_resolver_refcount;

DebugOnlyTraceFlag

src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc, line 459 at r2 (raw file):

}

static void pf_connectivity_changed_locked(grpc_exec_ctx *exec_ctx, void *arg,

I think there will be some changes needed when you merge in the code from #12878.

src/core/ext/transport/chttp2/transport/chttp2_plugin.cc, line 24 at r2 (raw file):

extern "C" void grpc_chttp2_plugin_init(void) {
#ifndef NDEBUG

Don't need this anymore.

src/core/ext/transport/chttp2/transport/chttp2_transport.h, line 35 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_chttp2_refcount;

DebugOnlyTraceFlag

src/core/lib/debug/trace.cc, line 37 at r2 (raw file):

}

void TraceFlag::List() {

Suggest calling this LogAllTracers().

src/core/lib/debug/trace.h, line 47 at r2 (raw file):

namespace grpc_core {

class TraceFlag {

Could we have two separate classes for the individual trace flag and the list of trace flags?  I think it might be easier to read and understand that way.

src/core/lib/iomgr/closure.h, line 37 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_closure;

DebugOnlyTraceFlag

src/core/lib/iomgr/error.h, line 42 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_error_refcount;

DebugOnlyTraceFlag

src/core/lib/iomgr/ev_posix.cc, line 43 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_fd_refcount(false, "fd_refcount");

DebugOnlyTraceFlag

src/core/lib/iomgr/pollset.h, line 33 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_fd_refcount;

DebugOnlyTraceFlag

src/core/lib/iomgr/timer_generic.cc, line 46 at r2 (raw file):

#define MAX_QUEUE_WINDOW_DURATION 1

extern "C" {

Not needed anymore.

src/core/lib/iomgr/timer_uv.cc, line 32 at r2 (raw file):

#include <uv.h>

extern "C" {

Not needed anymore.

src/core/lib/security/context/security_context.cc, line 33 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_auth_context_refcount(false,

DebugOnlyTraceFlag

src/core/lib/security/context/security_context.h, line 26 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_auth_context_refcount;

DebugOnlyTraceFlag

src/core/lib/security/transport/security_connector.cc, line 47 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_security_connector_refcount(

DebugOnlyTraceFlag

src/core/lib/security/transport/security_connector.h, line 37 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_security_connector_refcount;

DebugOnlyTraceFlag

src/core/lib/surface/alarm.cc, line 31 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_alarm_refcount(false, "alarm_refcount");

DebugOnlyTraceFlag

src/core/lib/surface/alarm_internal.h, line 31 at r2 (raw file):

#ifndef NDEBUG

extern grpc_core::TraceFlag grpc_trace_alarm_refcount;

DebugOnlyTraceFlag

src/core/lib/surface/completion_queue.cc, line 45 at r2 (raw file):

grpc_core::TraceFlag grpc_trace_pending_tags(false, "pending_tags");
grpc_core::TraceFlag grpc_trace_cq_refcount(false, "cq_refcount");

DebugOnlyTraceFlag

src/core/lib/surface/completion_queue.h, line 36 at r2 (raw file):

extern grpc_core::TraceFlag grpc_trace_pending_tags;
extern grpc_core::TraceFlag grpc_trace_cq_refcount;

DebugOnlyTraceFlag

src/core/lib/surface/init.cc, line 129 at r2 (raw file):

    grpc_channel_init_init();

#ifndef NDEBUG

Not needed anymore.

src/core/lib/surface/init_secure.cc, line 41 at r2 (raw file):

void grpc_security_pre_init(void) {
#ifndef NDEBUG

Not needed anymore.

src/core/lib/transport/metadata.cc, line 52 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_metadata(false, "metadata");

DebugOnlyTraceFlag

src/core/lib/transport/metadata.h, line 29 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_metadata;

DebugOnlyTraceFlag

src/core/lib/transport/transport.cc, line 35 at r2 (raw file):

#ifndef NDEBUG
grpc_core::TraceFlag grpc_trace_stream_refcount(false, "stream_refcount");

DebugOnlyTraceFlag

src/core/lib/transport/transport.h, line 47 at r2 (raw file):

#ifndef NDEBUG
extern grpc_core::TraceFlag grpc_trace_stream_refcount;

DebugOnlyTraceFlag

test/core/iomgr/timer_list_test.c, line 35 at r2 (raw file):

extern grpc_core::Tracer grpc_timer_trace;
extern grpc_core::Tracer grpc_timer_check_trace;

I assume these should be TraceFlag?

Comments from Reviewable

Closing in preference to @ncteisen's version


Dex-TTS checkpoint

Hi there, is there a pretrained weights checkpoint for DEX-TTS? Looking forward to trying it out!
Thank you for your great great work!!

Hi,
I will upload the checkpoint in near future. (after new recipes for multi-gpu and preprocessing)
Thanks for your interest.

Does using the training

Hi,
I will upload the checkpoint in near future. (after new recipes for multi-gpu and preprocessing)
Thanks for your interest.

Hi Thank you for that! Does running through the steps in  the below link,  lead to exactly the same checkpoint that you are producing?
https://github.com/winddori2002/DEX-TTS/tree/main/DEX-TTS

For training GeoDEX-TTS is there a max number of speakers that can be in a dataset?  is this like 100,1000,10000 speakers?
ideally how many samples do you need to achieve good results per speaker? Assuming each sample is about 6 seconds in length.  @winddori2002
Thank you!

Hi,
I tested on the VCTK dataset which consists of 100 speakers, and it works fine.
If the number of speakers increases, the model size should be increased.
Considering the VCTK or LibriTTS dataset, more than 30 minutes per speaker is necessary.
Thanks.


[BUG]: Adding the front-end files in a separate directories like client or front-end

Description
Manageable Front-end
Currently, our project has a separate directory for the back-end, but the front-end files are not organized into a dedicated directory. This lack of structure is causing scalability issues and may lead to complications in the future, particularly when establishing API connections through global state management in the front end using technologies like Redux and Redux Toolkit.
Proposed Changes
Create a Separate Front-end Directory:
Move the existing front-end files into a new directory to improve organization and scalability.
Establish a Clear Folder Structure:
Implement a more manageable folder structure to handle different components of the front end. The proposed structure is as follows:
Copy code
`/Backend`              # Backend Related Files
`/Frontend`             # Frontend Related Files
    ├── `index.html`    # Entry Point of the Application
    ├── `Pages`         # All Pages of the Application (e.g., Home, About, Blogs, Contact)
    ├── `Animations`    # Animation Related Files
    ├── `CSS`           # All CSS Files
    ├── `JS`            # All JS Files
    ├── `Others`        # All the other related folders...
    └── `Dist`          # Production Build

This restructuring will enhance the maintainability of our codebase and streamline the development process moving forward.

@ANSHIKA-26 I want to hear your thoughts on this before I start working on it.

im okay , take a lot at pr #1095 , wont you encounter issues like this PR ?

I won't encounter the same issues as that PR cause I have a better way of solving this problem. What I'll do is I'll keep the current files the same without changing anything in them. I'll copy all the files related to frontend and paste it inside a frontend directory and refactor that copied code instead of changing actual. So even if some changes come in the real file they won't have any merge conflicts with the front-end directory. So in the future we will start deleting the files outside of the frontend and backend directory in a way that they don't create conflicts.

@ANSHIKA-26 I tried to improve the readability of the code while keeping the same features, but it's difficult due to unnecessary and confusing components in different parts of the project. So, I’ve decided to rebuild the entire frontend from scratch, keeping the same functionality but changing the UI. Don’t worry, I won’t modify the existing code. I'll create a new folder called 'Frontend' for the changes.

okay..
and you will be deleting files from outside of the frontend folder ?

@tejasbenibagde Hey, are you sure this will work out? I'm a bit worried after closing another PR related to this without merging it, and I couldn’t award points for that. Since it’s nearly the end of the contribution period, I just want to make sure you’re confident about this.
If you haven’t put in too much effort yet or aren’t 100% sure it’ll work out, no pressure from my side! If it feels too complex or challenging, feel free to unassign yourself—there's absolutely no problem with that. Thanks again for your efforts

@ANSHIKA-26 I'm keeping the files outside of the frontend folder as it is for now because if I do any changes in them or even try to remove them will lead to the merge conflicts. So I want to go step by step. Like let me first create the working frontend directory. And after that little by little we can start deleting the unnecessary files outside of the backend and frontend folder. It will surely take the time but it is way better than making a huge change all of a sudden without proper planning.

yep , this makes sense , a lot of PRs are being merged everyday , so we cant just delete things from root directory altogether, just to make it clear-
after u make completely new frontend UI folder , the site will still be hosted as a static site on github pages right ?

@tejasbenibagde Hey, are you sure this will work out? I'm a bit worried after closing another PR related to this without merging it, and I couldn’t award points for that. Since it’s nearly the end of the contribution period, I just want to make sure you’re confident about this.
If you haven’t put in too much effort yet or aren’t 100% sure it’ll work out, no pressure from my side! If it feels too complex or challenging, feel free to unassign yourself—there's absolutely no problem with that. Thanks again for your efforts

Don't worry I'll uplift your project from ground zero to the production ready full stack application just keep a little trust in me.

im confused about hosting it , since it will have 2 frontends , one inside the folder and one in root directory

Nah I'm making the contributions but don't host it yet. Since it might have many bugs at first and you might want to have your own opinions about my frontend Design. We can discuss these design topics and I'll fix them in the next PR. If you like the final result you can host the frontend in the free hosting providers like netlify or GitHub sheets etc. how does it sounds?

sounds perfect ! go ahead !

That’s really awesome of you! I truly appreciate your dedication and understanding of what open source is about. It’s rare to find contributors who prioritize meaningful work over points, and it really shows your commitment. I’m glad you’re confident about this—thank you for your effort and for keeping the project’s best interests at heart !

That’s really awesome of you! I truly appreciate your dedication and understanding of what open source is about. It’s rare to find contributors who prioritize meaningful work over points, and it really shows your commitment. I’m glad you’re confident about this—thank you for your effort and for keeping the project’s best interests at heart !

At first I wanted to enter the compitition for winning but I quickly realized that the participants are just spamming the PR and Issues just for points even if it does not make project any better that what it currently is. So I gave up on contributing for points. I'm now working only because I love the OpenSource.

@ANSHIKA-26 By the way I'll be opening the PR for this issue today at night.


[BANKING] Add Bank Accounts

The following features should be added to support Bank Accounts:

[ ] Create a specific Bank Account
[ ] Update a specific Bank Account
[ ] Delete a specific Bank Account
[ ] Show a specific Bank Account
[ ] List All Bank Accounts

You can find the official documentation here!

Implementation Tips:
You can draw inspiration from this PR. Don't forget to write good tests, and to document it on our README

can i work on it @joaolucasl

Sure! Go ahead @ankitbhardwaj78! Just bear in mind the REST API docs I linked to are in Portuguese, if that's not a problem for you :)


Return and tab keys add tag to tag list

Pressing the return and tab keys should now add a tag to the tag list without any other side effects.

This also fixes https://github.com/levlaz/braindump/issues/24
Thanks @ProjectFrank :)


Unclear how to create a private stream

I wanted to create a private stream, and found this UI:

It's not at all obvious that the "Create new stream" button leads to an additional dialog box that allows making the stream private:

I was hesitant to click the button for fear of creating a public stream instead.  I ended up hunting unsuccessfully for the UI to create private streams, and ultimately had to ask another user to point me in the right direction.

Yeah.  I think in general that page could use an overhaul.

I suppose even the name of the stream should be asked in the dialog box only.What say @timabbott ?

Yeah, I think that (and just removing the text box on the main page) would be a good incremental improvement here.
@wdaher what do you think?

So, @timabbott do you think if I should take this as my first project?

Yeah seems like a great starter project!

Now that I was going through the code, Just moving stream name inside the dialog box isn't a very good idea, as it searches if the user has already subscribed or not to the stream but having filling all the options and than getting the error you are already subscribed would not be a very good idea, What do you think?

It's probably a pretty rare case that someone will try to create a stream
that they're already subscribed to, so I think it's fine to give an error
in that case.

Ah, okay. Working on it. :)

@timabbott I've opened a PR #514 , Please review it and tell if any further changes are required.


Add option to lowercase default entity collection name

Option to lowercase the default entity collection name when nothing is specified in the @Entity annotation!

Would also be nice if capital letters in the class name were prepended with an underscore.

This is great.  But it'd be event better with tests.  :)

Added a test. I used the already existing MapperOptionsTest class because it seemed like an appropriate place to put it.
The commit messages got messed up on my fork, but thankfully it didnt mess up the pull request :)

Since you added it manually and not merging I guess this can be closed.

It is closed.

Oh wow, how did I not notice that...


Release 0.17

Summary

Previous release: 0.16 (#613)
Release notes: #629
Milestone: 0.17
Feature Freeze: evening of November 1st, 2018 (see #581)
Release date: November 17, 2018

Long over due I will try and make a release in about 30 min If you got time to test, now is the time.

SoCo 0.17 has been released 🎉

PyPI package
GitHub release
Release notes
Commit log

This release had 16 commits by 5 authors.
Thanks to @pmac, @ghcs27, @amelchio and @EliSchleifer for their contributions!
Our next release will be 0.17 (#630)

Great work 🎉 Congrats!

@stefankoegl, yeah congrats.
Hey I was wondering. If you have a little extra time in the near future, could I get you to swing that magic auto-deply-to-PyPI-from-travis-triggered-by-tag-wand over socos?

@KennethNielsen great idea! I've created a pull request at SoCo/socos#82


Fix typo in the README

Hi @andresbono,
thank you for very much for your PR.  I really appreciate it. 👍
I have just merged it into the master branch.
Enjoy using the library! 🙂


Add Twitter Image Pipline in Image

Project URL
https://github.com/twitter/ios-twitter-image-pipeline
Description
The Twitter Image Pipeline is a streamlined framework for fetching and storing images in an application.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 3 link issues

Link issues by awesome_bot

Line
Status
Link

1083
301
https://github.com/MerrickSapsford/Listenable redirects tohttps://github.com/msaps/Listenable

1210
301
https://github.com/nestproject/Frank redirects tohttps://github.com/kylef/Frank

1477
301
https://github.com/MerrickSapsford/Pageboy redirects tohttps://github.com/msaps/Pageboy

  Generated by :no_entry_sign: Danger

@aalok05 did an awesome job on the lib!


Support for markdown

Would be great to support block of comment that contains markdown, looks like currently these are not parsed correct.
To be checked.

All good, already supported.


If primitive contains targets set sequential encoding

Check if the primitive contians any morph targets. If it does, set sequential encoding to preserve the order of vertices.
This fixes https://github.com/AnalyticalGraphicsInc/gltf-pipeline/issues/365

Works for the model in #365 and AnimatedMorphSphere.
Thanks @FrankGalligan


Create/append search should prefer items starting with typed text

Problem you would like to solve
I was surprised to discover that I have to scroll the menu to find End Event after typing "en", even though it's the only element which starts with "en". IMO it should be on top of the list.
https://user-images.githubusercontent.com/28307541/217778860-452750ee-f2df-4666-92c9-4d797b717779.mov
Proposed solution
If an item starts with the searched text, it should appear on top.
Alternatives considered
Leave it as is.
Additional context
No response

CC @smbea I found the same thing, trying to search for ter (Terminiate End Event).

Good question. Maybe it makes sense to look at this in a more holistic manner; consider group names, too, and consider display (with group headers or not)?
An (simple) alternative would be to only match from the start of a token; from what I understand this is what @barmac stumbled upon. en should match End rather than went.
One assumption I have (not tested) is that re-ordering elements in the search results will confuse me.

CC @YanaSegal. Maybe you have some general UX insights to share.

Me and @YanaSegal discussed this topic yesterday and ended up discussing how the search could work in a more general aspect.

Search by "starts with" or "contains strict term". For example:

If you search for "en":

"end event" will match
"start event" would not match

If you search for "end": "error end event" will also match

Search by group name too
Keep groups during search and do not re-order entries. Instead, re-order groups by relevance of search results

Prioritization order would be: label > description > group

With this discussion, the capability of collapsing/expanding groups also came up. I created a separate issue for this: https://github.com/bpmn-io/diagram-js/issues/764

Depends on https://github.com/camunda/camunda-bpmn-js/pull/393 to be released and incorporated.

Unfortunately not fully addressed (yet):

(Fails with Event as a search term, expected to prioritize Event-based Gateway over other search results).

I looked into this again, via https://github.com/bpmn-io/diagram-js/pull/953. First I thought that it would be unexpected that we still group search results (while the results are actually in a chaotic order). However https://github.com/camunda/camunda-modeler/issues/3439#issuecomment-1481069503 backed up that we want to:

Still have items grouped
Show most relevant group first

:arrow_right: This is what we do today, and will ship, cf. https://github.com/bpmn-io/diagram-js/pull/953.


Thank you for your help

Thank you very much.
At first, my goal is to do an automatic calculation of the length of the glacier.
I was amazed when I saw your code on gihub and it inspired me.
So thank you.
I want to end with a question.
In the looking for the path step, whether it can be based on both the distance weight and the altitude value.
Thus, the path with the shortest cutting distance from low altitude to high altitude is obtained?

Hi @Nullaha!
The tool creates a networkx.Graph in between so what you can do is to start from here and use one of the graph functions to do whatever you need to do with the graph: https://networkx.github.io/documentation/stable/reference/index.html
When reading the elevation values you can use rasterio and its sample() function to get the elevation value over a certain point: https://rasterio.readthedocs.io/en/latest/api/rasterio._io.html#rasterio._io.DatasetReaderBase.sample

Ok, thank you @ungari!
i will keep trying.


Android 'notify' not working

Hi,
I saw that in v1.2.0 you have added the support for Android in 'notify' method. But this code is simply not there so in the latest version I'm not able to notify android device. Instead of successful notification I have this: "Unknown platform type! Please chose between ios-mac or safari!". Is there any possibility we can release the new version soon with this commit included https://github.com/linitix/nzero-push/commit/c365816a8c69138e1204447ec85d428924c78b0d?
Thanks in advance!
P.S. I need this like asap, like now, like 10 minutes ago ;)

Sorry for the delay. Can you try the latest version ? npm install [--save] nzero-push@latest

You probably fix this one, but I'm not able to test it, because you made a mistake in last commit: https://github.com/linitix/nzero-push/commit/db3742a0f7014cb5e2ab7c345259d60310fe8e56 . Basically, you forgot to change a file name from /lib/schames/device_token_schema.json to /lib/schames/device_tokens_schema.json (so 'token' -> 'tokens') so code is not working (at least notify method) from v2.0.0

v2.1.1 published on npmjs.
Thanks for your help!

All is fine now! I'm closing the issue. Many thanks for your effort!

Thanks for your patient.


Initializing static var with CbType instance crashes on Neko

package;

import nape.callbacks.CbType;

class Main
{
    public static var cb = new CbType();
    public static function main() {}
}

haxe -main Main -lib nape -neko run.n
neko run.n

Called from zpp_nape/callbacks/CbType.hx line 348
Called from nape/callbacks/CbType.hx line 179
Called from nape/callbacks/CbType.hx line 198
Called from zpp_nape/callbacks/CbType.hx line 174
Called from zpp_nape/callbacks/CbType.hx line 353
Called from zpp_nape/ID.hx line 186
Uncaught exception - Invalid operation (+)

Haxe 3.2.0, Nape 2.0.19. Seems to be an issue with static initialization order - creating a static CbType leads to ZPP_ID.CbType() being called without _CbType being initialized to 0 yet.
Somewhat related to #81 I guess. This has also been brought up in #77.

I'm getting this still with haxe 3.4.0, neko 2.1.0, and Nape 2.0.20, on linux64.
The output is slightly different in that it has a few extra lines about C:
Called from zpp_nape/callbacks/CbType.hx line 348
Called from nape/callbacks/CbType.hx line 179
Called from a C function
Called from nape/callbacks/CbType.hx line 198
Called from zpp_nape/callbacks/CbType.hx line 174
Called from a C function
Called from zpp_nape/callbacks/CbType.hx line 353
Called from zpp_nape/ID.hx line 186
Uncaught exception - Invalid operation (+)


Deleting one include of median from BOOST library to arithmetics_counter file

Two times "#include <boost/accumulators/statistics/median.hpp>" is included. So, one should be removed .
@hkaiser Would you mind to review !!

@hkaiser Sir, I have updated it . Sorry, I haven't recognized that previously.


Refactor latex method using pylatex

[x] I have added the tests to cover my changes.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

Summary
Fixes #763
I've removed most of the string manipulation in the latex method and replaced it with pylatex. I need to do more testing (and clean up all the debugging statements in the branch) but this is the initial idea.
Details and comments
My refactor in latex improves this module a little bit, but it doesn't really get at the fundamental issue of maintainability. The next step would be defining pylatex subclasses for each Qcircuit command (gate, cw, etc.) and mapping directly from the circuit to those instances instead of the string representation of the commands by refactoring the latex_array methods. I'm not sure that would be better than the current way of doing it; we're either mapping to strings or instances and then appending a bunch of commands to qcircuit. I don't have a great idea for how to significantly reduce the size of the module using pylatex and am looking for suggestions, thanks!

PR for this issue https://github.com/Qiskit/qiskit-terra/pull/4059

@scottwn are you still working on this? If/when it's ready can you remove the "WIP"
I think one obvious way to improve this file is to factor out some repetitive pieces of code into functions. For example the piece of code starting on line 443 is basically the same as the one starting on line 499. There are more examples like this.

Still working! Refactoring some of the repeated code blocks, should complete this week

I think these tests are failing because pdflatex doesn't exist in the build environment. We can add it or go back to skipping the latex tests, what do y'all think?

Sorry this PR was neglected! If you are still interested @scottwn, can you fix the conflicts? I can help with the tests...

Thanks! I'll update the branch today and then we can look at the tests.

Hi, Scott. I did a refactor of the mpl drawer a few months ago and I used this test file which sort of grew organically. It's a bit of a mess, but it did show me a lot of edge issues in the drawer. There are many things that need to be fixed in the latex drawer, and I figure if some are easy you might want to do them here, or maybe create some new issues for some of these. Just rename it .py.
test_ctrl_gate.txt
Here's the latex output (using master. Your version may have already addressed some of these.)

Issues to note,

barrier and snapshot are commented out because they crash the drawer
register names with multiple _ will also crash the drawer
id gate should be I
params on cu1 and zz are out of place
inconsistent capitalizing of gate names (might be solved by using _style.disptext from qcstyle.py).
there have been gates added that are not covered in the lists in the drawer
reset, ctrl-swap, ctrl-rzz, and rcccx break the wires
ctrl connections on swap and rzz go through the gates
the ccFred... gate converts the number part of the name into e notation
the multi-control U gates near the right side and initialize do not show parameters
the text and mpl drawers now support labels. I assume the latex drawer should as well.

As I said, you don't need to do any of this, but just wanted a place to note some of the issues.

Issues to note,
* barrier and snapshot are commented out because they crash the drawer

I suspect that the version of the qcircuit latex package installed on your system is too old this is normally what causes barrier to fail for people with the latex drawer. You need the latest (released 2 years ago) version, 2.6.0, of qcircuit installed: https://ctan.org/tex-archive/graphics/qcircuit?lang=en which added the \barrier command.

Thanks, Matthew.

Thanks guys, I need to fix some stuff with cregbundle and then I'll take a look at that list of issues

Thanks guys, I need to fix some stuff with cregbundle and then I'll take a look at that list of issues

Ping when ready.

I've cleared most of the merge issues except the TestLatexSourceGenerator failures. Because the source is now being generated by PyLaTeX it doesn't match the style of the reference source files and is missing comments. Is it better to try to include the comments in the PyLaTeX source output or just replace the reference source with the PyLaTeX source as it is?

I'm not the LaTeX guy, but when we make major changes on the mpl drawer, for example the spacing between gates, that affect all the reference images, we regenerate a new set, and also give it an eyeball test.
I don't believe there's any reason to keep the format previously used for the reference latex source, so the real test is does the output produce a circuit image that's correct.

I agree with that, I'm going to regenerate all the reference source files, check that they compile correctly and update the branch

when ready, hit the "Ready for review" button!

Some conflicting files... how far you think it might be ?

The test is failing because the test environment can't compile LaTeX. Not sure what the best way is to resolve this.
    pylatex.errors.CompilerError: No LaTex compiler was found

Either specify a LaTex compiler or make sure you have latexmk or pdfLaTex installed.


fix Fix incorrect merged tablet stats

Previous impl. of get_detached_tablet_stats() may miss some detached KVs or tablet stats due to KV iterating paging (RangeGetIterator.more() == true), which leads to zero detached stats and produce buggy data size report to FE.

run buildall

run buildall

run buildall


Sidebar - add copyright

@fichtner added my copyright!

@fichtner
my internet connection has passed during the pr. that has meant that some things have been "weird". ...
thx franco,
regards rené


Render directive as a popup window

Hello!
First of all, amazing component you have here, great work!
I will try to explain my use case below:
I really like the «selector» part of the component, but in my use case I want to render main list of selected items myself (the «button» part) and popup the selector when user clicks on some button, e.g. «Add item». Also, I want the selector's list to only contain items which are not added to the main list already. When user clicks on an item inside of the selector's list I want to add this item to the main list and remove it from selector's list dynamically.
I've tried to show the idea visually on the mockup:

I think I can handle the list management part programmatically, but I'm not sure how to hide/replace the original «button» and trigger popup on custom event (button click).
Is it possible to achive this behavior without modifying the directive?
If not, let's just consider this a feature request = )
Thank you very much!

It seems to me you want a different component. What you're describing is much more like a dual list builder (like this). I'm not sure angular-multi-select could be made to do what you want without a pretty heavy redesign.
On a separate note, I'm curious how the Main List would look after selecting additional items. Would they be added immediately upon selection, or only after it's closed? I guess I'm not seeing how to avoid the Selected Items list from growing, and therefore forcing the Selector's List to move down with it.
I think a modal popup with a dual-list might be a better way to go (that's how I'm handling a situation where the list is really long).

Hi @slavafomin ,
You can, at least to a certain extent.
Say your output-model is $outputData, so in your controller;
$scope.outputData = []; // just some initialization
$scope.isHidden = true; // to hide n show the directive

Then in your view, do something like this;

<button type="button" ... ng-click="isHidden = false"></button>

The only thing is that you need to close the directive after you select something. On single-selection mode it will automatically close, but not in multi-selection mode. You'll need to modify things a bit, and I leave that your own discretion :)

Thank you @tedyoung and @isteven!
I've tried to use your approach @isteven to hide the component and show it with the ngShow directive, but it will show/hide the entire component. I'm looking for a way to show only selector part of it.
I'm not familiar with architecture and code of the component, but maybe there is a way to provide more granular control of the component in the API?

Hi @slavafomin ,
By displaying only the selector, you mean the list items? If so, then yes you can hide the rest of the button (select all, none, reset, filter).

I'm not sure I understand, how do I hide the button part and show only the list selector? I will need a way to transit the component from «button» state to the «list» state programmaticlly somehow.


Incorrect type for DirectorySyncEvent.data.active

DirectorySyncEvent.data.active has a boolean type but Azure AD Directory Sync seems to be giving back data.active: "False" (as a string)
{
  action: 'user.updated',
  data: {
    id: 'xxx',
    first_name: '',
    last_name: '',
    email<EMAIL_ADDRESS>    active: 'False',
    raw: {
      schemas: [Array],
      externalId: 'steven',
      userName<EMAIL_ADDRESS>      active: 'False',
      displayName: 'Steven Dub',
      emails: [Array],
      meta: [Object],
      id: 'xxx'
    }
  }
}

Thanks for reporting this issue.
Can you please check the directory type is azure-scim-v2. To comply with the SCIM 2.0 standard, Jackson adds a query parameter to the SCIM URL if the directory type is azure-scim-v2.
For example api/scim/v2.0/876394bf-d131-4dba-bfcd-48f6bb9f5cb9/?aadOptscim062020 where aadOptscim062020 is the query parameter added by Jackson. This is to ensure that the SCIM endpoint is compatible with the SCIM 2.0 standard.

Yes, that's correct – the directory is indeed azure-scim-v2! The issue is regarding the type of the active attribute – which is string for Azure and boolean for Okta 😅

@steven-tey I was looking at the dsync implementation at dub codebase, sharing a few issues I noticed.
You don't need to do provide webhook_url and webhook_secret in the directorySyncController.directories.create call. Those are only needed when you host Jackson as a service and want to receive events from Jackson to your app. In this case you are embedding Jackson into your app and you don't need to provide those parameters.
https://github.com/steven-tey/dub/blob/main/pages/api/projects/[slug]/scim.ts#L33-L42
directorySyncController.directories.create({
  name: "Dub SCIM Directory",
  tenant: project.id,
  product: "Dub",
  type: provider,
}),

In the UI while displaying the SCIM URL/Tenant URL, you have to display scim.endpoint. It has some additional parameters that are needed for the SCIM integration to work with certain providers (Eg: Azure AD).
https://github.com/steven-tey/dub/blob/main/components/app/modals/scim-modal.tsx#L175-L184
${scim.directories[0].scim.endpoint}

@devkiran Thanks a lot for looking into this!

You don't need to do provide webhook_url and webhook_secret in the directorySyncController.directories.create call.

 – just fixed this!

In the UI while displaying the SCIM URL/Tenant URL, you have to display scim.endpoint.

Does this mean that instead of displaying scim.directories[0].webhook.endpoint, on L175 and L182, I should be showing scim.directories[0].scim.endpoint instead?

@steven-tey So Azure returns a boolean value for data.active now? Let me know if you need any help with this.

Took me a while to test this (thanks to Azure AD and it's 40-min provisioning cycles 🥴) but I was finally able to confirm that this setup returns data.active = false (boolean values)!
Thank you so much for your help again @devkiran!!


[Enhancement] releases Releases on Repository of Chocolatey packages

Hello, this is not an issue in itself. Just an suggestion. I see you have in your repo 3 Plugins today already. Would be nice to have a auto update feature for this primary security applications plugins from trusted source. The sha hash of PLRGX can be verified by installation automatically optionally if specified.  For the lazy ones :) and to fix incompatibility issue with future of keepass with plugin by getting all in one place for example.
I don't know if you have the spare time to maintain in parallel the "packages". Which basically would contains a script to URL of github latest release asset.
If you may want to take a look here if you don't know already:
keepass packages
There are many plugins and packages count is growing.
Perhaps for the day, this goes out of "Pre-release"? While in current version so far it works very well anyway.

Thanks for suggestion. Sounds easy. Why not to do it if there exists (or can be created) a single script that will create and publish Chocolatey package.
The plugin is "pre-relase" because there will be a name change. It is now not only a dark theme.

My plugins at Chocolatey.


Bundle install reuses layer even when bundle-respected env vars should change app image setup

What happened?
Please provide some details about the task you are trying to accomplish and
what went wrong.
We were trying to use some build-time configuration that the bundle tool natively respects to change the contents of the built app image. In particular, we wanted to take advantage of the BUNDLE_WITHOUT environment variable to exclude certain gems from the built app image. Rather than rebuilding the gems layer, the buildpack reused the cached version of the layer. The resulting app image included gems we didn't want in our image.
Reproduction steps

Clone this sample app
Change the Gemfile to contain:

source 'https://rubygems.org'

ruby '~> 2.0'

group :test do
  gem 'rspec'
end

gem 'puma'
gem 'sinatra'

Run bundle locally to generate a Gemfile.lock.
Build the app with all of its gems:

pack build exclude-gems  --builder paketobuildpacks/builder:0.1.20-base --buildpack gcr.io/paketo-buildpacks/ruby:0.1.5 --clear-cache

Hop into the built app and see that the rspec gem is present:

docker run -it --entrypoint=launcher exclude-gems /bin/bash
cnb@fa0d8cb9967f:/workspace$ ls /layers/paketo-buildpacks_bundle-install/gems/ruby/2.7.0/gems/
diff-lcs-1.4.4    nio4r-2.5.4  rack-2.2.3             rspec-3.10.0       rspec-expectations-3.10.0  rspec-support-3.10.0  sinatra-2.1.0
mustermann-1.1.1  puma-5.0.4   rack-protection-2.1.0  rspec-core-3.10.0  rspec-mocks-3.10.0         ruby2_keywords-0.0.2  tilt-2.0.10

Rebuild the app with the BUNDLE_WITHOUT env var to exclude the test group:

pack build exclude-gems  --builder paketobuildpacks/builder:0.1.20-base --buildpack gcr.io/paketo-buildpacks/ruby:0.1.5 --env BUNDLE_WITHOUT=test

The output should contain:
[builder] Paketo Bundle Install Buildpack 0.1.0
[builder]   Reusing cached layer /layers/paketo-buildpacks_bundle-install/gems
[builder]

Hop into the app container again and see that rspec is still present in the app container

docker run -it --entrypoint=launcher exclude-gems /bin/bash
cnb@546bd3d68aea:/workspace$ ls /layers/paketo-buildpacks_bundle-install/gems/ruby/2.7.0/gems/
diff-lcs-1.4.4    nio4r-2.5.4  rack-2.2.3             rspec-3.10.0       rspec-expectations-3.10.0  rspec-support-3.10.0  sinatra-2.1.0
mustermann-1.1.1  puma-5.0.4   rack-protection-2.1.0  rspec-core-3.10.0  rspec-mocks-3.10.0         ruby2_keywords-0.0.2  tilt-2.0.10

The buildpack should rebuild the gems layer in a way that respects this native configuration.
Notably, running
pack build exclude-gems  --builder paketobuildpacks/builder:0.1.20-base --buildpack gcr.io/paketo-buildpacks/ruby:0.1.5 --env BUNDLE_WITHOUT=test --clear-cache

produces the desired result, where rspec gems are not present.
Checklist
Please confirm the following:

[x] I have included log output.
[ ] The log output includes an error message.
[x] I have included steps for reproduction.

@paketo-buildpacks/ruby-maintainers This issue has been open for a while. Does this need to be investigated further before it's workable?
@richardTowers Is this still a problem for you?

@fg-j while this specific example doesn't fully apply anymore (because the buildpack runs with bundle-without already now), the case in which the environment variables aren't taken into account still stands. I don't think further investigation is necessary.


Error: Could not set SubstructureRedirect to root window event_mask

Error
    at XClient.req_proxy [as ChangeWindowAttributes] (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/xcore.js:189:30)
    at /home/spaceboyross/RDE/src/panel/node_modules/ewmh/lib/ewmh.js:16:15
    at ReadFixedRequest.callback (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/xcore.js:545:21)
    at ReadFixedRequest.execute (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:41:10)
    at UnpackStream.resume (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:165:30)
    at UnpackStream.write (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:102:10)
    at Socket.<anonymous> (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/xcore.js:88:21)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at addChunk (_stream_readable.js:250:12)
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: Could not set SubstructureRedirect to root window event_mask
    at /home/spaceboyross/RDE/src/panel/node_modules/ewmh/lib/ewmh.js:19:29
    at ReadFixedRequest.callback (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/xcore.js:490:39)
    at ReadFixedRequest.execute (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:41:10)
    at UnpackStream.resume (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:165:30)
    at UnpackStream.write (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/unpackstream.js:102:10)
    at Socket.<anonymous> (/home/spaceboyross/RDE/src/panel/node_modules/x11/lib/xcore.js:88:21)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at addChunk (_stream_readable.js:250:12)
    at readableAddChunk (_stream_readable.js:237:11)

Hey, can you post sample code that reproduces the issue?

NTK is used.
		ntk.createClient((err,app) => {
			if(err) throw err;
			this[SYMS["app"]] = app;
			this[SYMS["win"]] = app.createWindow({ width: this.width, height: this.height, x: this.x, y: this.y, title: "RDE Panel" });
			this[SYMS["win"]].map();
			this[SYMS["ewmh"]] = new EWMH(app.X,app.display.screen[this[SYMS["opts"]].screen].root);
			this[SYMS["ewmh"]].set_class(this[SYMS["win"]].id,["panel"],err => {
				if(err) throw err;
			});
		});

Is another WM already running in the same xserver?

Yes, I'm running OpenBox

That seems to be the problem. I don't know exactly what are you trying to accomplish but only one X11 client can set SubstructureRedirect mask in a specific window, and I guess openbox has set the mask in the root window. /cc @sidorares

I'm trying to make a panel/dock.

yes, only one client can own SubstructureRedirect. If somebody already started WM you'll need to make it quit before you start new one. There is a "polite way to do that" ( this is what some wm's offer under --replace command line key ). To do that, you try to request selection for WM_S0 ( 0 screen number ) and other wm should notice it's lost selection and quit
https://github.com/bbidulock/icewm/blob/77196178450accf0a959155c94ec8c1c401633a8/src/wmapp.cc#L98-L105

The replace key didn't fix it.

There is no "replace" key built in to node-x11 or node-ewmh library
You need to kill your WM or follow standard "hey other WM please let me replace you" protocol, that is you need to create a window and acquire WM_S0 selection to that window.

The replace key in my window manager, that's what I was meaning.

But you are launching your script after some other WM already started, right? So it's your script responsibility to try to replace wm, not that other WM

Yeah, after OpenBox has started because my DE is RDE.

You can't have both OpenBox running and request SubstructureRedirect for root window

I was meaning like an option to disable SubstructureRedirect because I'm using this in RDE's toolkit and panel.

Still not clear to me. Which code tries to get SubstructureRedirect ?

None

can you show panel source code?

Okay, I think I now remember. It's been a long time without using this module. node-ewmh as it is now, it's meant to help implementing the [Extended Window Manager Hints](http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html) to a window manager  implementation. So one of the first things it does is trying to set the SubstructureRedirect in the root window. So yes, to use this module you have to avoid any other x11 client to have that mask value set.

https://github.com/Ross-Technologies/RDE-Panel

Why do you need node-ewmh? If it's only to set the WM_CLASS property in a window, then use https://github.com/santigimeno/node-x11-prop#set-property and avoid all the problems.


Use non-capturing lambdas for lazy initialization

See issue #4789
This requires a new initializer class since the BCL LazyInitializer doesn't support passing parameters to the creation delegate.

:shipit:


Remove the dependency on uuid while still supporting window.crypto

Relates to the following 2 pull requests https://github.com/IdentityModel/oidc-client-js/pull/848 https://github.com/IdentityModel/oidc-client-js/pull/769
For my use case, I am creating es6 web components and using rollup to bundle them as es to be included as a script on a webpage. One of the components selectively imports oidc-client modules to be included in the bundle, so I only import what I need. I have karma-esm running tests on my code without bundling in the browser.
Here are the problems I have with the uuid dependency. One was that rollup would not bundle the oidc-client code due to random.js using import uuid4 from 'uuid/v4. I would get the error 'default' is not exported by node_modules/uuid/v4.js presumably due to mixing es import with module.exports =  If I changed the line back to const uuid = require('uuid/v4') I could then create a bundle, but then my own tests would fail due to not understanding 'require' in the browser as this code would be imported.
I did try using @rollup/plugin-commonjs but this just caused different problems, I would get unresolved external errors instead. I also tried taking the oidc-client.min.js built code and including this on my webpages but this also caused me headaches in testing with components needing to import or require to deal with the Oidc variable.
So this solution is by far the easiest for me, it has the benefit of reducing dependencies for oidc-client and you can minimize the included code while still using crypto. The oidc-tests pass so it still creates the uuid with the correct pattern.
I know there are many ways to create uuid4 (see https://stackoverflow.com/questions/105034/how-to-create-guid-uuid/43901924) and you may want to revert to the previous version of random.js using Math.random, it doesn't matter the implementation to me as long as there is no dependency on uuid package.
Do you think it worth merging in some form?

@simoncowie -- any thoughts/concerns on this request?

any thoughts/concerns on this request?

All good from me

@sereeena  - any chance you tested this on IE11?

Thanks for this, I manually merged due to the recent conflict!

I did a preview for this feature, please test: https://www.npmjs.com/package/oidc-client/v/1.11.0-beta.1

Thanks it is working well but I don't have IE11 so am unable to test that, sorry.

Thanks, tested and working, but have not done extensive browser tests so no IE11, sorry.


Gradle exclusions should include both group and module

Presently, when gradle publishes POMs for CAS modules, it does not account for exclusions defined by the gradle build. This is because none of the exclusions actually define a group. In order for all dependency exclusions to be accounted for, gradle must include both the group and the module for all exclusions.

I'll work on the same patch for master in the coming days.

Applies fix for both 4.2 and master.


CI: update TPU docker

What does this PR do?
fixing the names after repo rename, but as they were consistent, it is not critical
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @borda

This PR should be added to pl:1.7.x instead of pl:future, I think?

This PR should be added to pl:1.7.x instead of pl:future, I think?

I do not mind, just this is not very critical, have it on master is fine

Then this goes into 1.8. Future is for issues


feat: modularised K8s deployments of components of UI and server

Closes: #230

/code pr

:robot:
Review Summary
Overall, the changes made in this commit are well-structured and aim towards modularising Kubernetes deployments for UI and server components, which is a positive step towards maintainability and scalability. However, there are a few suggestions and issues to address:
deployment/argocd/application.yml

Suggestion: The update to targetRevision: v2023.03 is appropriate for tracking the latest changes. Ensure that all dependencies and configurations are compatible with this version to avoid deployment issues.

deployment/k8s/base/kustomization.yml

Issue: The transition from individual files to directories (./ui and ./server) is a good practice for modularity. However, ensure that the kustomization.yml files within these directories are correctly set up to include necessary resources like deployments, services, and HPAs. Missing these could lead to incomplete deployments.

Deleted deployment/k8s/base/network-policy.yml

Issue: The deletion of the network-policy.yml file raises concerns about the security posture of the deployment. Network policies are crucial for defining how pods communicate with each other and the outside world. If this policy is being moved or redefined elsewhere, ensure it is adequately documented and implemented to avoid potential security gaps.

File Renaming (Server and UI components)

No Issue: The renaming and reorganisation of deployment, HPA, and service files into their respective server and ui directories are well-executed. This change enhances the clarity and manageability of the deployment configurations. Just ensure that all references to these files (e.g., in CI/CD pipelines or documentation) are updated accordingly to reflect the new paths.

Code Examples and Enhancements
Given the nature of the changes (mostly file deletions, renamings, and a minor update in a YAML file), there are no specific code examples to provide. However, for the deleted network-policy.yml, if the intention is to redefine network policies more granitely, consider an example structure like:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: specific-policy-name
spec:
  podSelector:
    matchLabels:
      app: specific-app
  policyTypes:
  - Ingress
  - Egress
  ingress:
  - from:
    - ipBlock:
        cidr: <IP_ADDRESS>/24
    ports:
    - protocol: TCP
      port: 80
  egress:
  - to:
    - ipBlock:
        cidr: <IP_ADDRESS>/0

This example defines a more specific network policy that could be tailored per application needs.
Conclusion
The modularisation effort is commendable and aligns with best practices for Kubernetes deployments. Addressing the highlighted issues and considering the suggestions will further solidify the deployment's effectiveness and security.
> gpt-4-turbo-preview [pr | 0]

/code pr

:robot:
Review Summary
Overall, the changes introduced in these patches are well-structured and aim towards modularising Kubernetes deployments for UI and server components, which is a positive step towards maintainability and scalability. However, there are a few points that need addressing:
Patch 1/2 Review

deployment/argocd/application.yml:

The update to targetRevision: v2023.03 is straightforward and assumes a new versioning. Ensure that this version is correctly tagged in your repository to avoid deployment issues.

deployment/k8s/base/kustomization.yml:

The simplification from individual files to directory references (./ui and ./server) is a good practice, making the structure cleaner. Ensure that the directories exist and are correctly structured to avoid deployment failures.

Deletion of deployment/k8s/base/network-policy.yml:

The removal of a network policy could have significant implications on the security and accessibility of the services. Ensure this change is intentional and reviewed for security implications.

File Renaming:

The renaming and reorganisation of deployment files into server and ui directories are well-executed. This change should help in better managing the resources.

Patch 2/2 Review

Addition of kustomization.yml in both server and ui directories:

This is a positive change, ensuring that each component can be deployed independently with its resources. The structure in the kustomization.yml files is correct and follows best practices.

Reintroduction of Network Policy in ui/network-policy.yml:

The addition of a new network policy specifically for UI egress to the server is a good security practice. However, the policy name ui-egress-to-server-only suggests it only allows egress to the server, but the policy also allows ingress. Ensure the policy accurately reflects its intended function, and consider renaming or adjusting the policy to match its actual behaviour.

Recommendations

Security Review: Given the changes in network policies, a thorough security review is recommended to ensure that the new policies do not inadvertently expose services or restrict necessary traffic.
Testing: Ensure thorough testing in a staging environment to verify that the modularisation and network policy changes do not affect the functionality or accessibility of the services.
Documentation: Update any relevant documentation to reflect the new structure and deployment strategies, including any necessary steps to deploy using the new kustomization.yml files.

Conclusion
The patches are well-structured and aim towards improving the deployment process. With the recommended checks and adjustments, these changes should contribute positively to the project's maintainability and security posture.
> gpt-4-turbo-preview [pr | 1]


Upgrade to go1.6.x

Relates to https://github.com/sensu/uchiwa/pull/498#discussion_r69080175

Done via https://github.com/sensu/uchiwa/pull/528


Brick getReps and recGetReps refactoring

Description
This PR aims to refactor the getReps and recGetReps methods on Brick. Especially the recursive method, is now much easier to read and much more efficient than the previous version. Furthermore, three more tests on the BrickTest class were added to ensure the correctness of the methods.
Bug fix
When the strings set had a size of one, the wrong set of concatenations would be returned.

The Brick's tests do not work, closing.

Fixed and reopened.
Also changed methods name to be more accurate and added one more test on BricksTest class.

Will close as outdated as discussed.