Add LIFX bulb support

Tested to work with 6 bulbs (latest firmware on two different hardware revisions) using scripts and automation.
Supports auto-discovery of LIFX bulbs.
Supports power on/off, RGB, brightness & temperature setting.
Tests clean using ./scripts/lint

How is this PR different from #824? Seems to be for the same hardware, isn't it? Is there an advantage not using the lazylights module?

I'm not sure how well the lazylights module works...reading the comments suggests that there are some outstanding issues.
Advantages? I don't think lazylights does auto-discovery.

Also, I thought the main goal was to reference 3rd party libraries instead of building everything within the component? If that is the case you could simply break out your code into a it's own library.

It seems like #824 has gone stale so I am open to take this PR to integrate LIFX support. However it will require the actual code that implements the LIFX protocol to be extracted into a 3rd party library that Home Assistant can install via REQUIREMENTS.
HA would then just forward calls for discovery and turning on/off to objects it gets from the lib.

I agree with @TangoAlpha. If this implementation works and isn't throwing errors in the log I'd be fine to use this. The lazylights pull #824 is pretty close as well, but there are outstanding issues with the Lazylights module that need to be addressed before the pull can be merged.

LIFX protocol extracted to external library.
Can anyone suggest how to fix the Travis and/or Coverage fails?

Add your component to be excluded from code coverage by adding it to .coveragerc.
For CI, see the logs

I ran script/gen_requirements_all.py but I still get the same error.

It's because you committed a change related to Nest requirements too.

Thanks for the help. Not sure how that happened as I just ran the gen_requirements_all script.
What happens next?

Anyway to add transition before this gets merged? Would love to see that capability. I think #824 included this.

How does ATTR_TRANSITION get set? Is it a value from the configuration file somewhere?

Transition is set when the light.on service is called. It fades between the previous color and the set color. It's easy to add to the component, but you'll need to update liffylights to support it.
if ATTR_TRANSITION in kwargs:
    fade = kwargs[ATTR_TRANSITION] * 1000

Thanks for the changes! In giving this a quick shot, it's throwing an error in the log. I'll do some digging tomorrow and see if I can figure out what's going on. Thanks for you work on this!
16-01-24 23:30:23 homeassistant.core: BusHandler:Exception doing job
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/core.py", line 829, in job_handler
    func(arg)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/core.py", line 682, in _execute_service
    service(call)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/core.py", line 554, in __call__
    self.func(call)
  File "/usr/local/lib/python3.4/dist-packages/homeassistant/components/light/__init__.py", line 237, in handle_light_service
    light.turn_on(**params)
  File "/var/opt/homeassistant/custom_components/light/lifx.py", line 206, in turn_on
    brightness, kelvin, fade)
TypeError: set_color() takes 6 positional arguments but 7 were given

I think we should get this merged without transition and have it added later. Small steps at a time, feature by feature.

Your requirements is out of date again btw.

I am down to merge this, the code looks good. It does however seems like @brusc  discovered a bug, let's get that fixed, update the requirements and we should be good to go.

I think it's working fine now if you want to merge it.

Awesome :dolphin: , merging

Thanks for the work on this, @TangoAlpha!

So this doesn't work for me; how should I reinstall HA to get it to work?

Are you running the latest dev version?

Have you run pip --upgrade homeassistant ?
On Jan 27, 2016 12:47 AM, "Aditya Vaidyam"<EMAIL_ADDRESS>wrote:

So this doesn't work for me; how should I reinstall HA to get it to work?
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/pull/930#issuecomment-175414801
.

That did the trick, thanks! :)


No code prompt

Go to definition can be used normally, but there is no code prompt

What do you mean by "code prompt?"

I solved it after using self compiled ZLS

What do you mean by "code prompt?"

For example, the prompt of variables and functions after you input


[Bug] Slash menu text appears under images

Describe the bug
The slash menu text (e.g., "Type / to use the slash commands...") is visible under images, if the image is selected or the cursor is before the image.
To Reproduce
Steps to reproduce the behavior:

Go to https://milkdown.dev/online-demo
Remove all text
Paste in any image
Place cursor before the image or select the image

Expected behavior
The slash menu is not present when the cursor is on the same line as the image (that's consistent with how text appears).
Screenshots

Desktop (please complete the following information):

OS: Linux
Browser Chrome
Version 95

Additional context
Not sure if this is intended, but images appear inside the "empty-node" that represents the menu, like this

In my app, I toggle the editor between read-only and editable modes. In the read-only case, I also hide empty-nodes to hide the slash command. So this effectively hides my images when clicked (or when they are the only content in the editor). [I have an easy solution, but thought this info might be useful anyway.]

I think it is already fixed in https://github.com/Saul-Mirone/milkdown/commit/dbf7de0c465f83899c9e2846a02953c6fceda4c2.
It's not been released yet, but the oneline demo should work right now.
Do you still have this issue in online demo?

I believe it already been fixed after my double check. Feel free to reopen if you think it's still there.

@Saul-Mirone do you have any sense of when the next release will come? It'd be great to have these patches if you have time :)

@Saul-Mirone do you have any sense of when the next release will come? It'd be great to have these patches if you have time :)

Today

Awesome, the bug is gone. Thanks!


Don't add playing songs to the bottom of the list, play in place

Hey for some reason I'm on this chain and I'm not on this project. How do I get off of the chain? It's sending me like 30 emails a day! Ack!
-LA Johnson
Sent from my iPhone
On Jan 30, 2015, at 10:45 AM, Suyeon Son <notifications<EMAIL_ADDRESS>wrote:
Closed #98https://github.com/nprapps/austin/issues/98.
—
Reply to this email directly or view it on GitHubhttps://github.com/nprapps/austin/issues/98#event-227600634.


Landscape homepages consumes 100%+ CPU

Describe the bug, optionally with screenshots
If I leave the landscape homepage open it soon consumes 100% CPU
To Reproduce
Steps to reproduce the behavior:

Go to my Urbit's home URL
Leave it open for a day or less.

Expected behavior
The page is quiescent.
Additional context:

Ship type: Planet (~ritpub-sipsyl)
Instance type: self-hosted
OS/browser: Brave (Chromium) on Linux (NixOS)

Closing in favor of urbit/garden#53


[in-app-purchase] queryPastPurchases returns empty on iOS

Hi
Using in-app-purchases in production. recently updated the library. on iOS, for users who purchased a subscription, the queryPastPurchases() returns now an empty list, especially those who purchased a subscription with a 3-months-free -trial. all transactions have been completed with 'completePurchase(details)'.
any thoughts as to why this is happening?

Hi @lironzemingo
Are you using latest in_app_purchases
Can you please provide your flutter doctor -v and pubspec.yaml
Thank you

pubspec.yaml:
`name: my_module
description: A new flutter module project.
This version is used only for the Runner app, which is used if you just do
a flutter run or a flutter make-host-app-editable.
Use with the CupertinoIcons class for iOS style icons.
dev_dependencies:
flutter_test:
sdk: flutter
freezed: ^0.12.7
build_runner: any
flutter:
uses-material-design: true
assets:

assets/images/
packages/time_machine/data/cultures/cultures.bin
packages/time_machine/data/tzdb/tzdb.bin

fonts:
- family: Roboto
fonts:
- asset: assets/fonts/Roboto-Regular.ttf
- asset: assets/fonts/Roboto-Italic.ttf
- asset: assets/fonts/Roboto-Medium.ttf
- asset: assets/fonts/Roboto-Bold.ttf
weight: 700
For details regarding fonts from package dependencies,
see https://flutter.dev/custom-fonts/#from-packages
module:
androidX: true
androidPackage: com.example.tempdrop_ovuview_flutter_module
iosBundleIdentifier: com.example.tempdropOvuviewFlutterModule
`
flutter doctor:
`[✓] Flutter (Channel stable, 2.0.2, on macOS 11.2.3 20D91 darwin-x64, locale en-IL)
• Flutter version 2.0.2 at /Users/lironitzhaki/flutter
• Framework revision 8962f6dc68 (3 weeks ago), 2021-03-11 13:22:20 -0800
• Engine revision 5d8bf811b3
• Dart version 2.12.1
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc1)
• Android SDK at /Users/lironitzhaki/Library/Android/sdk
• Platform android-30, build-tools 30.0.0-rc1
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.4, Build version 12D4e
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] Connected device (1 available)
• Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90
• No issues found!
`

@lironzemingo Could you post a reduced test case so we can try to reproduce the issue?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Write unit tests for bot/patches/message_edited_at.py

Write unit tests for bot/patches/message_edited_at.py.
Implementation details
Please make sure to read the general information in the meta issue and the testing README. We are aiming for a 100% branch coverage for this file, but if you think that is not possible, please discuss that in this issue.
Additional information
If you want to work on this issue, please make sure that you get assigned to it by one of the core devs before starting to work on it. We would like to prevent the situation that multiple people are working on the same issue. To get assigned, leave a comment showing your interesting in tackling this issue.

Internal discussions deemed these tests to be unnecessary.


Constraint type automatically

One of advantages of Javascript is dynamic. It's delightful to write code without caring about type. It's tired to write type and rewrite it over and over at the beginning of developing.
But I know type is necessary when develop a huge app.
So, can Typescript provide a way to constraint type automatically after I finish my code? I just need to check if it's right which Typescript compiled then fix it.
example
my code:
function foo({name, age, country}) {
  // ...
}
foo({name: 'my-name', age: 0, country: 'my-country'})
foo({name: 'her-name', age: '10'})

Typescript compiles code to:
interface Interface1 {
  name: string;
  age: number | string;
  country?: string;
}
function foo({name, age, country}: Interface1): void {
  // ...
}
foo({name: 'my-name', age: 0, country: 'my-country'})
foo({name: 'her-name', age: '10'})

Then I fix compiled code:
interface Info {
  name: string;
  age: number;
  country?: string;
}
function foo({name, age, country}: Info): void {
  // ...
}
foo({name: 'my-name', age: 0, country: 'my-country'})
foo({name: 'her-name', age: 10})

This seems potentially viable as a codefix.  You could highlight any one function which took an any and the codefix could look at all calls to that function, the types at each callsite, and try to infer a type out of all of it.

This is just the existing "Infer from usage codefix", which doesn't yet work on destructured arguments

Can "infer from usage" compiles "no type code" to "type code"? I think it's delightful to write typescript without handle type manually.

You seem to be using the word "compile" in a non-standard way - TS never emits TS implementation files. Can you clarify?

Oops, I give an example here. (It's like "git rebase")
example

I finished my code: main.ts (But no type, I need type for better maintainability)
I use typescript to compile main.ts from no-type-file to typed-file. Imagine there is a command: "tsc type main.ts".
I fix and rename some interface or something in typed-file. then "tsc type --continue".
Typescript finishes all work and apply all changes.

That's kind of a weird workflow (and a ton of extra implementation work) compared to using the codefix/refactor workflow already available in most editors. We're also looking in to making language service operations available from the commandline, so you could potentially write something like (syntax 100% tbd):

ts-refactor foo.ts --fix-all infer-from-usage

Thx :)


Fix issue #4 and add docker support.

Thanks for this PR @arush-sal. I'm going to cherry pick some of your commits. Good work! :+1:

I've cherry picked the following commits

14e3f1f2607f91d1fdaaf31bf41d9ad19a40e987
073a77ddd650a820cf77edff408b237328cb1adc
ad6066b5e64b8c8b80bce4e49e919779454dbcbf
4d2b70b217dfbbb7a2c44fad0d9fc8c1b140f123

These changes will be included in v1.0a1 with few modifications. Thank you very much for the PR.


Does PicoKit work with current AFNetworking (2.5.4)

My project uses the latest AFNetworking pod. However, PicoKit specifies AFNetworking 1.3.4. Does it also work with version 2.5.4?

Have the same question.

Hi, sorry for the late response, I was on vacation.
Currently, it does not work with higher versions than 1.3.4. It needs a bit of rework to be compatible with AF 2.+
Don't know when I will have time to do so, hope soon. Otherwise, contributions are welcomes ;)
Regards,


[Bug]: no such package '@@spdlog~//': BUILD file not found in directory '' of external repository @@spdlog~.

What happened?
Expect the spdlog dep works well, however when I use deps = ["@spdlog//:spdlog"] in a cc_library, bazel raises an error:
ERROR: no such package '@@spdlog~//': BUILD file not found in directory '' of external repository @@spdlog~. Add a BUILD file to a directory to mark it as a package.

Other deps works well, only the spdlog does not work.
Version
Development (host) and target OS/architectures:
Output of bazel --version:
Language(s) and/or frameworks involved:
bazel --version
bazel 7.1.2-homebrew
Version of relevant rules from the WORKSPACE or MODULE.bazel file:
bazel_dep(name = "spdlog", version = "1.14.1")
How to reproduce
No response
Any other information?
No response

spdlog 1.14.0+ uses overlays, which are only supported in Bazel 7.2.1+. We should actually have marked it with bazel_compatibility, but it's a bit late for that.


Colours are almost impossible to read on a light shell theme

I use a light shell theme and it's basically impossible to read the warning messages because of the yellow.

The blue isn't much better but I can at least read that. I hacked my own CSS to use #aa0 to it's a bit more readable :stuck_out_tongue:

Yeah, it's hardcoded right now which of course makes it horrible on some
themes. Sorry about that. Would you mind having a go at trying to use some
colours from the current theme? I hope there are some vars defined
somewhere ^^
On Fri, Mar 6, 2015, 00:44 Aaron Powell<EMAIL_ADDRESS>wrote:

I use a light shell theme and it's basically impossible to read the
warning messages because of the yellow.
[image: Log]
https://cloud.githubusercontent.com/assets/434140/6517227/19afdde4-c3ed-11e4-92ad-39d37b42b175.PNG
The blue isn't much better but I can at least read that. I hacked my own
CSS to use #aa0 to it's a bit more readable [image: :stuck_out_tongue:]
—
Reply to this email directly or view it on GitHub
https://github.com/nickclaw/atom-grunt-runner/issues/38.

Possible fix in PR #68

Fixed with #68. It's on master now so if you install from there you'll get it.
Otherwise there will hopefully be a new version soon-ish :)


Cleanup old Monotouch non-unified projects

Fixed in https://github.com/jdehlin/Xamarin-Sidebar/pull/84


Load ex-mode earlier

Currently ex-mode loads only when :  is pressed. Loading it earlier will help with stuff like #91

I briefly experimented with this by just removing the activationCommands from package.json, but ex-mode then adds about 100-110ms to startup time which is a bit much IMHO.


mimic dataset

Is only the finding part or the impression and finding part used in the mimic dataset? Could you explain what downsampling operation is done on the picture part of the mimic dataset

If it's convenient, could you show me the json file of the mimic dataset? Just one

Is only the finding part or the impression and finding part used in the mimic dataset? Could you explain what downsampling operation is done on the picture part of the mimic dataset

Hi, only finding section is used as the report prediction. We directly used the dataset from the R2GenCMNhttps://github.com/cuhksz-nlp/R2GenCMN, hence for the details of the downsampling operation, please kindly ask the authors of R2GenCMN.
Sorry that we cannot directly provide the json file of the mimic dataset due to the license issue, but the format of the annotation file of MIMIC is exactly the same as the one of IU-Xray dataset provided in the files directory.
Hope this information help you figure out the problem.

Thank you very much for your answer

I applied for a R2GenCMN datasets, but has not passed, do you have any other way to apply for.


Fix and improve search highlighting and behaviour

Fixes some bugs with search highlights and behaviour, bringing behaviour more in line with Vim.

[x] VIM-1535 - Use same text attributes ("Text search results") and highlight layer (selection - 1) as IntelliJ's own Find feature. This makes search results more visible. Previously, it would add the highlight below e.g. "identifier under caret" and would use the same colours as Highlight Usages, meaning the current search highlight could easily be lost.
[x] VIM-1413 - Fix smartcase option being ignored in incremental search.
[x] Fix incremental search not matching when search term has trailing options, e.g. /Foo/+1
[x] Move the current line during incremental search, to match Vim behaviour. Original caret location and scroll position is restored if the search is cancelled
[x] VIM-128 - Fix :substitute not respecting ignorecase and smartcase options
[x] Fix next/previous search not handling smartcase override for search next word. E.g. * on Editor overrides smartcase. Now n/N will remember if smartcase was overridden.
[x] Fix search highlights being reset and redrawn when the ignorecase, smartcase and hlsearch options are modified. Does not redraw if the highlights have been hidden with :nohlsearch
[x] Fix exception when trying to show search highlights for the last \n in the file
[x] Add tests for search highlights and incremental search behaviour
[x] Remove old search highlights when starting to type a new search with incsearch and hlsearch enabled
[x] Highlight all find results instead of just first with incsearch and hlsearch enabled
[x] Support incremental search for :s, :g and :v (as per Vim)
[x] Disabling Vim emulation does not remove search highlights
[x] Improved <Del> and <BS> support in ex entry to better match Vim's behaviour

This PR has turned into a bit of a beast. I'm not going to add any more features. I've taken these items out, and will do them as a new PR, based on this, after it lands in master:

Support /_CTRL-G/c_CTRL-G and /_CTRL-T/c_CTRL-T to move between next/previous match during incremental search
Support /_CTRL-L to add one character to search from word at current match
Support c_CTRL-R_CTRL-W to add word to search from current match

I think it's possible to add a new text attribute for "IdeaVim text search results", which has a fallback to the default "text search results" attribute. So it would have the same colour as the IDE by default, but you can override it in settings if you want to. How does that sound?

Thank you very much @citizenmatt ! IdeaVim search is much better now!


Getting error on mac every 30 mins

TypeError: Object has been destroyed
    at BrowserWindow.s.reload (node:electron/js2c/browser_init:2:11004)
    at fo (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:123696)
    at PowerMonitor.<anonymous> (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:113273)
    at PowerMonitor.emit (node:events:525:35)

Kit 1.40.62
Electron 22.0.0
darwin 22.3.0
Locale: en-GB

Does it still work?
Try quitting Kit.app then re-opening. I bet it will fix it.
Each time your computer wakes from sleep, Kit.app reloads the window UI to a clean start. The error reads like it's trying to reload a cached window that somehow was destroyed. I'll have to investigate what could cause that


Add New Ldap Flag --active-users

New ldap flag --active-users listing active users on domain. In real life test i encountered so many deactive accounts and it's wasting time.

@termanix Looks like there's 1 Ruff error if you could fix that!

Fixed now. Thank you for feedback and thoughts ^^


Add "tag_uncommitted" option to "builder"

Discussed in issue https://github.com/basecamp/kamal/issues/775
This adds an option to builder so it doesn't mess up remote building when there are uncommitted local changes. Defaults to the same behaviour as now, so should not disrupt anyone's workflow, assuming there is anyone who actually wants that behaviour of making random build tags that can't be deployed later.
Apologies for the "Bump version" commits... this is my very first pull request..! I guess I shouldn't have run bin/release...
Usage is really simple:
builder:
  multiarch: false
  tag_uncommitted: false
  remote:
    arch: amd64
    host: ssh://[redacted]@[redacted]

With that line, now the random tag won't be added when there are uncommitted changes.
TODO: mention this in the docs?

This can be closed as #775 is resolved


Update make "all"

Folders should be created when we want to use make all, right?

I guess. Merged.


macOS dependencies: Build libpng16 for freetype, so can render colored emoji

Maintainer merge checklist

[ ] Title is descriptive/clear for inclusion in release notes.
[x] Applied a Component: xxx label.
[ ] Applied the api-deprecation or api-break label.
[ ] Applied the release-highlight label to be highlighted in release notes.
[x] Added to the milestone version it was merged into.
[ ] Unittests are included in PR.
[ ] Properly documented, including versionadded, versionchanged as needed.

freetype (a dependency of SDL_ttf) should be built with libpng support, otherwise colored emoji which make use of PNG (like the default Noto Color Emoji provided on Ubuntu).
FYI: For Noto Color Emoji,  only https://github.com/googlefonts/noto-emoji/blob/main/fonts/NotoColorEmoji_WindowsCompatible.ttf and the NotoColorEmoji.ttf available on /usr/share/fonts/truetype/noto/NotoColorEmoji.ttf seem to render correctly.
✅ Tested locally
✅ Tested with wheel artifact
⚠ Unfortunately we do not handle (and maybe SDL does not) an error when rendering is not possible, so we can't add a test ATM.
Linked issue (do not close as support on Linux -and likely other platforms- is missing): #7565
Linux one: https://github.com/kivy/kivy/pull/8313
Demo:
from kivy.app import App
from kivy.lang import Builder
from kivy.uix.boxlayout import BoxLayout

class UI(BoxLayout):
    pass

Builder.load_string(
    """
<UI>:
    Label:
        text: "😀 🎉 📷 👕 🐞"
        font_size: dp(100)
        font_name: "Apple Color Emoji.ttc"
"""
)

class Testapp(App):
    def build(self):
        return UI()

Testapp().run()

Output:

@misl6 maybe add your example to examples/dir ?

Looks Nice!


Add support for Neovim

It works fine for me. Not sure what feature patch1067 of Vim 8 had, though, so it may need to check the version of Neovim as well.

Vim version is because of this https://github.com/vim/vim/commit/e723c42836d971180d1bf9f98916966c5543fff1. I don't think Neovim has the same problem.


🌱 Make ks/ks repo publish ocm-transport-controller Helm chart

Summary
This PR continues the campaign of merging the ks/ocm-transport-plugin repo into ks/ks. The step here is moving where the Helm chart source is and where the packaged chart is published to.
Related issue(s)
This PR is based on PR #2429 and I will rebase if 2429 merges first.

The force-push to a3b80bdc2 fixes a typo in the goreleaser workflow.

Successfully tested by applying tag v0.24.0-alpha.3-experiment.2 to commit a3b80bdc2204f9815829adab846ca4d3db4dab0c . The commit after that fixes a doc bug revealed in that test.

/cc @nirrozenbaum
/cc @waltforme
/cc @ezrasilvera
/cc @pdettori

The latest commit fixes a bug exposed by testing that published Helm chart.


Support Python with pydantic

I regularly exchange data between Rust and Python (with pydantic).
When I saw this project, I really wanted to be able to incorporate it into my workload.
Would I be welcome to make python-enabled contributions?
Also, it would be helpful if you could share any concerns you have with python support.

Started giving this a shot. Here are a couple initial thoughts:
Order of globals matters
type MyTypeAlias = MyType
struct MyType{}

By default this library writes out globals in a fixed order: https://github.com/1Password/typeshare/blob/e461bb680bb1b0f943bee6c38498eaf1027f62e9/core/src/language/mod.rs#L30-L40
The Python implementation will need to override this and topologically sort globals to write them out in a valid order. I was generally able to do this but:

It's pretty invasive overriding of generate_types
We'd have to either bring in a dependency or vendor a topological sorting algorithm
We need to error out if there are cycles (Python doesn't support this)

I'd consider changing the default to topological sorting since I don't think that will be a problem for any other language and is likely more readable.
Mutable state on Language
Python needs some sort of mutable state to keep track of the imports it needs (from pydantic import BaseModel, from typing import Dict, etc.)
Each Language is supposed to be able to have mutable state:
https://github.com/1Password/typeshare/blob/main/core/src/language/mod.rs#L21
But the trait methods are declared with &self so self is immutable:
https://github.com/1Password/typeshare/blob/main/core/src/language/mod.rs#L27
I think it should have been &mut self but changing that would be a breaking change (it seems like Rust doesn't have the ability to "refine" traits to a more-general version w.r.t. mutability).
I got around this using RefCell but this can lead to runtime panics and makes things a lot more clunky.
Python versions and typing-extensions
The best way to a unit enum  or a tagged union with a string discriminant
enum Foo {
  Bar,
  Baz,
}

#[typeshare]
#[serde(tag = "type", content = "content")]
pub enum EnumWithManyVariants {
    UnitVariant,
    TupleVariantString(String),
}

Is
Foo = Literal["Bar", "Baz"]

class EnumWithManyVariantsUnitVariant(BaseModel):
  type = Literal["UnitVariant"]

class EnumWithManyVariantsTupleVariantString(BaseModel):
  type = Literal["TupleVariantString"]
  content: str

EnumWithManyVariants = EnumWithManyVariantsUnitVariant | EnumWithManyVariantsTupleVariantString

Python typing features differ amongst Python versions. For example, Literal is only available in Python > 3.9. For older versions you get it from typing-extension, which is a 3rd party dependency. Thus, we'd have to add:
import sys
if sys.version_info < (3, 9):
   from typing_extensions import Literal
else:
  from typing import Literal

And users would have to know to add the typing-extensions dependency if needed. I think this is doable, but I'd hold off from the first prototype. So initially I'd target Python 3.10+.
Knowing type variables and imports ahead of time
This library works sorta like a visitor pattern: it visits types/structs and calls back to write them out. Since Python needs to write out imports, type variables and such before they are encountered it can be a bit awkward to first traverse structs and write those out. The way I implemented this was by creating a new io::Writer and using that to write out the body, mutating a list of imports along the way, then writing out the imports and copying one io::Writer to another. I think it would make more sense for Python to do two traversals:

Visit all of the types and collect imports, type variables and globals.
Topologically sort the globals.
Visit every global and write it out.

This is currently possible but once again it would be super invasive because it requires rewriting or duplicating a lot of the logic in mod.rs .

@InquisitivePenguin just curious if this is something you'd be interested in supporting? I think between https://github.com/1Password/typeshare/issues/20#issuecomment-1328332069 and #25 I've explored enough of the complexity of supporting Python that it would be good to step back and see if this is something you actually want.

We would definitely be interested in supporting this! Thank you for the write-up and the work you've done. I'd be happy to assist with this effort once I can find the time.

Awesome just ping me whenever you feel is a good time for you. Thanks for looking over this!

Python 3.7 is almost EOL. I don't think it makes sense to support that. Literal is available since Python 3.8.


[ENHANCEMENT] change type of refreshRate and pid flag to unsigned int

In cmd/proc.go and cmd/root.go the type of the refreshRate flag is an int32.
In cmd/proc.go the type of PID is int32.

In both these cases, I feel like it would be better to keep the type to unsigned integers as the values can never be allowed to be negative.

int32 for refreshRate could be changed to uint64 to handle the case of an extremely large refresh rate since refresh rate is to be provided in milliseconds.
int32 of pid could be changed to unit32.

The default value of PID could be changed to 0.

To be solved after #64

Picking this one up also.

picking up this!

https://github.com/pesos/grofer/pull/68

@prncvrm LOL, don't rush to add an incomplete PR to an issue, which someone has already started working and commented so also.

Hi guys,
As a general good practice, its always recommended that you ask if an issue is available to be worked on and if so, whether you can work on it, rather than declaring that you will be working on this. As far as I can tell, both of you commented in the same manner at more or less the same exact time, there's no real way to decide this.
In order to try and be as fair as possible to you guys, we will be closing the PR by @souvikmaji for this issue since he has already contributed to this repo (this is done because there's a conflict in terms of whose PR should be accepted). But @souvikmaji's PR is valid too and that's why we'll be adding the hacktoberfest-accepted to it so that it counts towards hacktoberfest even though it is closed.
And one last thing, please follow the PR template. It is extremely important that you do so. The only reason that we'll be considering @prncvrm's PR is that it is borderline acceptable in terms of the issue it is solving, but bear in mind to follow templates and contribution guidelines.

@MadhavJivrajani thanks. @souvikmaji i really didn't see your comment back then. its less than a 1 min diff btwn our comments 👍


Update-ServiceNowNumber Issue

When trying to update a service now sc_task with this function, it fails when trying to add the "assigned_to" field.
Cannot process argument transformation on parameter 'AssignedTo'. Cannot convert the %sysID of user% value of type "System.String" to type "System.Management.Automation.ParameterAttribute".
When using Update-ServiceNowTableEntry, I can pass the value assigned_to with no problems.

I'm able to run Update-ServiceNowNumber with -Values @{assigned_to='FirstName LastName'} and with -Values @{assigned_to='MySysId'} successfully.  The code under the hood for ServiceNowNumber and ServiceNowTableEntry are exactly the same for the Values parameter.

Hi @tosso91.  Is this still an issue?


checkpoints.md

Tried to access IU X-ray: https://www.dropbox.com/s/0llg5e77l6nlb2b/iu_xray.pt?dl=0 but it says I don't have permission, how do I get the file inside the link? Thanks.

@BA-de-BA-jiao-shen-me Hello. As mentioned in #2, I recently received a reminder regarding potential policy issues associated with releasing the model checkpoints, due to the fact that not all pretraining / downstream datasets are fully open-sourced. I need to review the relevant policies and licenses to ensure the legality of sharing the weights. Once I can confirm this, I will inform you as soon as possible. Thank you for your patience.

@BA-de-BA-jiao-shen-me The checkpoint of UI X-ray, is available now! You can download it via https://www.dropbox.com/s/0llg5e77l6nlb2b/iu_xray.pt?dl=0.

Thank you so much for sharing!


feat: LCM, GCD and Factorial

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/5838.
Rationale for this change

What changes are included in this PR?
Implementation "GCD", "LCM" and "Factorial" SQL functions.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes

BTW I think the fact that the compiler didn't tell you where to update when you added a new function is confusing -- I will make a PR to fix that


Remove test dependency on locale

Since some tests were not working because relying on a specific locale I fixed them.
NLog version
4.3.0
Work arounds
None
Config when implemented
No changes

Current coverage is 75.17%

Merging #1393 into master will not affect coverage as of 4ca0279

@@            master   #1393   diff @@
======================================
  Files          267     267
  Stmts        15607   15607
  Branches      1642    1642
  Methods          0       0
======================================
  Hit          11732   11732
  Partial        383     383
  Missed        3492    3492

Review entire Coverage Diff as of 4ca0279

Uncovered Suggestions

+0.09% via ...gingConfiguration.cs#374...387
+0.09% via ...gingConfiguration.cs#340...353
+0.08% via ...argets/FileTarget.cs#1741...1753
See 7 more...

Powered by Codecov. Updated on successful CI builds.


[BUG] Issues with Saving Chat Flows, Adding Tools, and Using Chats

Describe the bug
I cannot save chat flows, add tools, or utilise chats.
To Reproduce
Before encountering this error, I uploaded files to the Pinecone vector store. The maximum total uploaded file size was not more than 200MB. This is a new deployment, so the disk is currently empty.
Screenshots

Setup

Installation [deployed on the railway.app; 8 GB of RAM, 8 vCPU, and 100 GB of Shared Disk]
Flowise Version [e.g. 1.6.0]

Additional context
I attempted to change the file size limit to 2000MB by adjusting the variable FLOWISE_FILE_SIZE_LIMIT=2000MB, but this did not work.

@qbbqqb  Did you make the change under the UI Variables?

For anyone coming across this issue, you need to update the ".env" file under the "/your_path/Flowise/docker/.env".  Stop the container and then rebuild.
sudo docker-compose up --build -d


Error: unable to decode 831061 transactions

Hi,
I'm using bitcoind v0.18.0 and I have the node up2date.
When I run the btcposbal2csv.py, it process up to transaction #58027800 before die with the error "unable to decode 831061 transactions".
(btcbal) [bitcoin@btcd btcposbal2csv]$ python btcposbal2csv.py /home/bitcoin/.bitcoin/chainstate/ addrs2.txt
reading chainstate database
inmem
 parsed transactions: 58027800
unable to decode 831061 transactions
totaling<PHONE_NUMBER>4994 satoshi
writen to addrs2.txt

I have enough RAM (the process does not die with an out of memory error). At the moment of the unexpected exit, is just using around 6gb of memory.
Do anyone have any idea of what can I check?
Thanks

Hi @komodin
what you are seeing isn't an error at all. It is just to state that there are 831061 unspent transaction outputs, in the UTXO set, for which there is no easy way to "decode the address". The address itself, as usually understood, is only proxy for humans...
For more information see https://en.bitcoin.it/wiki/Transaction#Types_of_Transaction.

Hi @graymauser, thanks for your response.
As far as I understand, the current number of total transactions is around 430 million (as you can see on blockchain.com), and the script is just parsing around 58 million TX.
Do I have any way to avoid the script exit when it found this behavior?
Thanks in advance!

Hi @komodin
this script processes only the UTXO transaction set -> These are the unspent transaction outputs - not all transaction (ie. https://www.blockchain.com/charts/utxo-count).
However, if you have up to date utxo set then there is some problem, because the total number of transactions should be about 80M now.
I'll investigate when I have more time, however, this can be related to segwit or something like that.

Thanks!

Hi @komodin
I've investigated a little and it looks that about 58 milion transactions is valid.
When you run the bitcoin-cli with gettxoutsetinfo
you get something like this:
{
"height": 586378,
"bestblock": "0000000000000000001b8d1d8dcd720da68c61f53105b33ec7b04bbb0363e8c6",                                        "transactions": 33810842,
"txouts": 59089178,
"bogosize":<PHONE_NUMBER>,
...
"disk_size":<PHONE_NUMBER>,
"total_amount": 17829554.82325440
}

You want to look at the txouts entry which lists number of transaction outputs (i.e. spendable bitcoins) in the UTXO set.
And you can see that is is about the same number as what you are seeing in the tool output.
Now why the blockchain shows about 80 mil transactions ... I don't know.
There is a library which does lot of stuff related to bitcoin and also can return the addresses with unspent output see https://github.com/citp/BlockSci/issues/264. It appears that is can handle segwit transactions out of the box, so it might be interesting to compare...
Regarding the issue, I conclude that the scripts sees all the transaction outputs defined in the UTXO set - which should be complete set of unspent transaction outputs in the blockchain.


Update 2-Adding-Sections.ipynb to remove language model dependencies

Currently this notebook (https://github.com/medspacy/medspacy/blob/master/notebooks/section_detection/2-Adding-Sections.ipynb) does not execute because it depends on a model (en_info_3700_i2b2_2012) which has not been re-generated for spacy v3.
While we could re-generate this for v3, it might be simpler to maintain if there is no dependency.  To illustrate the purposes intended in the notebook, it might be easier to set up simple rules in-line so that expected entities can be extracted to demonstrate section handling.
This is just from memory, so I'm not 100% certain that this idea is as simple as I think.
I could take this one since I need to address some QuickUMLS issues in the short term.

@abchapman93 gave me a really good idea for this today.  While we will break this dependency on this other custom model, we might be able to use a well supported model for this and similar examples.  We might consider using MedCAT:
https://github.com/CogStack/MedCAT

Hey there, really appreciate the great work on Medspacy @burgersmoke and @abchapman93!
Is there anyway we could get the i2b2 model up and working on spaCy v3? It would be super helpful for the clinical NLP community if we could easily use it with Medspacy. Alternatively, do you have any recommendations on good pre-trained models that work well with Medspacy?

@prestonlimlianjie Good question.  I agree that this would be useful for the clinical NLP community.  You are certainly welcome to train the model yourself.  If you did so, we might be able to integrate into medspacy.
As of now, there are many things we could do to help the NLP community, but as we do most of medspacy as volunteer effort, I cannot promise this is a priority any time soon.
As far as other existing models, I would suggest the following:

https://github.com/CogStack/MedCAT
https://github.com/allenai/scispacy
https://huggingface.co/connorboyle/bert-ner-i2b2 (note I have not tried this and there's almost no documentation, but I found this when searching for "huggingface i2b2")

I've decided to close this issue.  The purpose of the notebook listed in this issue is merely to show how sections work, rather than entity or concept extraction.
As such, there's no need for another model to use in such a demonstration.  We might do such a thing later, but this serves the purpose of illustrating how sections work and how to add them.


Add fp16 support to fused batchnorm op

Attention @zheng-xq

This commit adds a mixed-precision fused_batch_norm_v2 op.
The inputs and outputs are fp16, while the scale, offset, mean
and variance are kept in fp32.
The tf.nn.fused_batch_norm op has been modified to use the v2
fused batchnorm whenever inputs are fp16 (this does not affect
compatibility because fp16 was not previously supported).
The high-level layers API has also been updated to store the
scale, offset, mean and variance variables as fp32.

Can one of the admins verify this patch?

I signed it.

Looks like some sanity checks failed
FAIL: Found 2 non-whitelited pylint errors:
tensorflow/python/layers/normalization.py:246: [W0311(bad-indentation), ] Bad indentation. Found 8 spaces, expected 6
tensorflow/python/layers/normalization.py:248: [W0311(bad-indentation), ] Bad indentation. Found 8 spaces, expected 6

Fixed.

Jenkins, test this please.

CLA bot seems to be confused with multiple commits again. As all the CLAs seem to be signed, I can merge once the tests have passed.

Jenkins, test this please.

Looks like api compatibility test has detected a change in the public TF python API.
ERROR:tensorflow:1 differences found between API and golden.
ERROR:tensorflow:Issue 1	: Change detected in python object: tensorflow.layers.BatchNormalization.

Could you confirm the change is intended, run the test in a python2 + linux setup (you may use our devel docker images) and pack the change into this pull request?
Then we will need an API review before we can merge this PR.

The API change was actually unnecessary, as dtype can be passed to the underlying base.Layer in kwargs. The current PR should pass the api compatibility test.

Thanks for checking. Could you also look into the merge conflicts before I trigger tests?

The conflict has been resolved.

Jenkins, test this please.


Code style, pre-commit hooks, contribution guidelines.

This PR adds code style requirements and pre-commit hooks to the project (see comments in review of #445).
It uses:

black for code formatting

which enforces a consistent, PEP8-compliant codestyle
with line length 100 (default is 88, but since the project had some very long lines I thought to up it to be closer to the original format)

isort for import sorting
pre-commit to automatically run black and isort on each commit as well as some nice-to-haves (such as removing trailing whitespace)

I ran those settings over the entire repo, so you can see what the enforced style looks like.
CONTRIBUTING.md contains guidance on how to setup the hooks, as well as some additional info for tests.
Let me know what you think!

@timlod to be completely honest this PR will never get in, I simply dont have the time (read: get paid) to spend that much time on this project, I have bills to pay, people to look after, etc :(
sorry, closing for now, better is to

update the developer notes wiki about good tools we prefer to use
clean-up the code as we go

I think there may still be some misunderstanding, I'm sorry if I may have framed it badly.
The goal of this PR is to save time in the future, as contributions will all come in the same code style, making it easier to read and review.
There is no need to review all the changes in this specific PR (in case that is what you're referring to) - almost all of them are merely automatic formatting. They don't change any of the behaviour of the code. The only actual contributions I've made are in commits 5a651b5 and 04cffeb.
Of course I understand if you don't like the specific style enforced by black. From experience working on Python projects though, having a formatter work for you is a productivity boost, so a personal recommendation would still be finding one that does suit you, as it's just very nice to have :)


Accept Vault UUID as input parameter

Previous version of the deployer was using a randomly generated UUID. Although it was convenient, it broke the usecase of re-deploying a vault since it generated all new public key.

I have tested this and is working fine :
May 2 13:03:57  3d61fcae-788c-47b6-9442-d1a03e62a5d3  compose-vault-releases-1 INFO  [] Vault ID:                         b1e02330-7142-4c11-9c45-e935f4013b4d


Store contract source hashes

As suggested by @hackaugusto

in setup.py compile_contracts perform two actions - compile the json abi+bytecode + store hash of contract source files in the json
in setup.py build compare hashes from the json abi. Abort if they don't match.

This should prevent bugs like #280 or situations where the compiled abi differs from the updated source.

Actually I was proposing to remove the commands from the setup.py and have the CI system ensure the json files are available in the filesystem and matches the existing smart contracts.

After yesterday's discussion with @hackaugusto and as mentioned in https://github.com/raiden-network/raiden-contracts/issues/291#issuecomment-425879878:

contracts.json will be included in master and updated on every source code change
contracts.json will contain the ABIs, bytecode & source code checksums, in order to verify that the existing compiled file matches the existing source code
raiden-contracts package installation will not compile the contracts, but it will do the above verification
add a CI contracts verification test
run the verification test before uploading the package to pypi

Proposed by @konradkonrad :

check the solc version with which the contracts were compiled

@loredanacirstea Sounds good. So the generation of contracts.json should be done manually by someone with solc?
Can contracts.json also contain the version of solc used?

Yes, the generaltion of contracts.json should be done by someone with solc - the person who last changes the source code. Otherwise, tests will fail because the checksum verification will fail.
We can add the solc version to contracts.json and I think it is a good idea. It does not currently contain it. But I would make another issue & PR for this and not include it in https://github.com/raiden-network/raiden-contracts/pull/295.


Out of Memory (OOM) error when running the code

Hello,
Thank you for this work and sharing the code.
Unfortunately I have trouble trying to use it.
First, I correctly installed the required packages with:
pip3 install -r requirements.txt
But when running the code, I encountered the following error with clu:
  File "/home/student/slot-attention-video-main/savi/lib/input_pipeline.py", line 105, in create_datasets
    train_split = deterministic_data.get_read_instruction_for_host(
TypeError: get_read_instruction_for_host() got an unexpected keyword argument 'dataset_info'

When upgrading clu to version 0.0.5, the error disappears, and the code runs.
But after a short wait I receive an Out of Memory error on my A5000 (24Go) GPU (which is detected and used as confirmed by nvidia-smi):
...
Original error: RESOURCE_EXHAUSTED: Out of memory while trying to allocate<PHONE_NUMBER> bytes.

To ignore this failure and try to use a fallback algorithm (which may have suboptimal performance), use XLA_FLAGS=--xla_gpu_strict_conv_algorithm_picker=false.  Please also file a bug for the root cause of failing autotuning.

The stack trace below excludes JAX-internal frames.
The preceding is the original exception that occurred, unmodified.

--------------------

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/student/miniconda3/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/student/miniconda3/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/student/slot-attention-video-main/savi/main.py", line 63, in <module>
    app.run(main)
  File "/home/student/env/lib/python3.9/site-packages/absl/app.py", line 308, in run
    _run_main(main, args)
  File "/home/student/env/lib/python3.9/site-packages/absl/app.py", line 254, in _run_main
    sys.exit(main(argv))
  File "/home/student/slot-attention-video-main/savi/main.py", line 59, in main
    trainer.train_and_evaluate(FLAGS.config, FLAGS.workdir)
  File "/home/student/slot-attention-video-main/savi/lib/trainer.py", line 253, in train_and_evaluate
    opt, state_vars, rng, metrics_update, p_step = p_train_step(
RuntimeError: UNKNOWN: Failed to determine best cudnn convolution algorithm for:
%cudnn-conv.7 = (f32[9216,64,64,64]{2,1,3,0}, u8[0]{0}) custom-call(f32[9216,64,64,64]{2,1,3,0} %bitcast.516, f32[5,5,64,64]{1,0,2,3} %copy.64), window={size=5x5 pad=2_2x2_2}, dim_labels=b01f_01io->b01f, custom_call_target="__cudnn$convForward", metadata={op_name="pmap(train_step)/jit(main)/conv_general_dilated[window_strides=(1, 1) padding=((2, 2), (2, 2)) lhs_dilation=(1, 1) rhs_dilation=(1, 1) dimension_numbers=ConvDimensionNumbers(lhs_spec=(0, 3, 1, 2), rhs_spec=(3, 2, 0, 1), out_spec=(0, 3, 1, 2)) feature_group_count=1 batch_group_count=1 lhs_shape=(9216, 64, 64, 64) rhs_shape=(5, 5, 64, 64) precision=None preferred_element_type=None]" source_file="/home/student/env/lib/python3.9/site-packages/flax/linen/linear.py" source_line=282}, backend_config="{\"conv_result_scale\":1,\"activation_mode\":\"0\",\"side_input_scale\":0}"

Original error: RESOURCE_EXHAUSTED: Out of memory while trying to allocate<PHONE_NUMBER> bytes.

To ignore this failure and try to use a fallback algorithm (which may have suboptimal performance), use XLA_FLAGS=--xla_gpu_strict_conv_algorithm_picker=false.  Please also file a bug for the root cause of failing autotuning.

Some interesting lines among the warning messages:
Removing feature ('frames',) because ragged tensors are not support in JAX.
...
jax._src.traceback_util.UnfilteredStackTrace: RuntimeError: UNKNOWN: Failed to determine best cudnn convolution algorithm for:
%cudnn-conv.7 = ...

Although everything seems well installed and I had no issues with libcudnn...
Would you have any information that may help us to debug this?
Thanks in advance!

That's curious, thanks for sharing the detailed error message & background!
I didn't have the chance yet to look into this in detail, but it's indeed strange that the ragged tensor makes its way to JAX (it should only be part of the TF data pipeline). Could you print the shapes of the batch tensor (i.e. all tensors in the batch)?


Tags should be configurable

I'd like to configure internal tags (contained into jsonpickle/tags.py):
e.g.
OBJECT = 'py/object'    # OBJECT = 'py_object'
TYPE = 'py/type'    # TYPE = 'py_type'
because the / char could be a problem on deserializing again to other languages, such as Java.

From the implementation perspective: for better or worse python is a monkeypatch-friendly language.
If you import the jsonpickle.tags module and change the corresponding variables then the rest of the implementation should work as expected.
I'd be happy to document this as part of the public API, with the understanding that you're in control of main() so you have the ability to set this up before using jsonpickle.
If any code is relying on stuff not defined by that module then that is considered a bug.  You will have to redefine RESERVED yourself as well.

Curious, why would the "/" be a problem?  Can Java not store strings in hash table keys that contain /?


HADOOP-15960. Update guava to 27.0-jre in hadoop-common

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
530
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
58
Maven dependency ordering for branch

+1
mvninstall
1000
trunk passed

+1
compile
942
trunk passed

+1
checkstyle
191
trunk passed

+1
mvnsite
324
trunk passed

+1
shadedclient
1240
branch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-project

+1
findbugs
411
trunk passed

+1
javadoc
258
trunk passed

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

+1
mvninstall
207
the patch passed

+1
compile
892
the patch passed

-1
javac
892
root generated 15 new + 1482 unchanged - 1 fixed = 1497 total (was 1483)

-0
checkstyle
192
root: The patch generated 1 new + 61 unchanged - 1 fixed = 62 total (was 62)

+1
mvnsite
324
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
688
patch has no errors when building and testing our client artifacts.

0
findbugs
1
Skipped patched modules with no Java source: hadoop-project

-1
findbugs
107
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1
findbugs
141
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1
javadoc
263
the patch passed

_ Other Tests _

+1
unit
28
hadoop-project in the patch passed.

-1
unit
505
hadoop-common in the patch failed.

-1
unit
4625
hadoop-hdfs in the patch failed.

+1
unit
1006
hadoop-hdfs-rbf in the patch passed.

+1
unit
332
hadoop-mapreduce-client-core in the patch passed.

+1
unit
1111
hadoop-yarn-services-core in the patch passed.

+1
asflicense
53
The patch does not generate ASF License warnings.

15452

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Null passed for non-null parameter of writeXml(String, Writer) in org.apache.hadoop.conf.Configuration.writeXml(Writer)  At Configuration.java:of writeXml(String, Writer) in org.apache.hadoop.conf.Configuration.writeXml(Writer)  At Configuration.java:[line 3490]

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Null passed for non-null parameter of com.google.common.base.Preconditions.checkState(boolean, String, Object, Object, Object) in org.apache.hadoop.hdfs.qjournal.server.Journal.getPersistedPaxosData(long)  Method invoked at Journal.java:of com.google.common.base.Preconditions.checkState(boolean, String, Object, Object, Object) in org.apache.hadoop.hdfs.qjournal.server.Journal.getPersistedPaxosData(long)  Method invoked at Journal.java:[line 1064]

Null passed for non-null parameter of com.google.common.base.Preconditions.checkArgument(boolean, String, Object) in org.apache.hadoop.hdfs.qjournal.server.JournalNode.getLogDir(String, String)  Method invoked at JournalNode.java:of com.google.common.base.Preconditions.checkArgument(boolean, String, Object) in org.apache.hadoop.hdfs.qjournal.server.JournalNode.getLogDir(String, String)  Method invoked at JournalNode.java:[line 343]

Nullcheck of jid at line 346 of value previously dereferenced in org.apache.hadoop.hdfs.qjournal.server.JournalNode.getLogDir(String, String)  At JournalNode.java:346 of value previously dereferenced in org.apache.hadoop.hdfs.qjournal.server.JournalNode.getLogDir(String, String)  At JournalNode.java:[line 343]

Failed junit tests
hadoop.util.TestDiskCheckerWithDiskIo

hadoop.util.TestReadWriteDiskValidator

hadoop.hdfs.web.TestWebHdfsTimeouts

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/637

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux 438cbc377bda 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d18d085

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/diff-checkstyle-root.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/testReport/

Max. process+thread count
4817 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-637/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

this has to be applied to each branch differently, created a new issue for trunk to closing this


Stream stack does not take care of garbage-collected Stream (i.e. weakref is None)

import cupy as cp
from cupy import cuda

with cuda.Stream() as s1:
    s2 = cuda.Stream()
    s2.use()
    with cuda.Stream() as s3:
        del s2

This fails when exiting s3 context:
Traceback (most recent call last):
  File "test.py", line 8, in <module>
    del s2
  File "cupy/cuda/stream.pyx", line 197, in cupy.cuda.stream.BaseStream.__exit__
  File "cupy/cuda/stream.pyx", line 34, in cupy.cuda.stream._ThreadLocal.set_current_stream_ref
AttributeError: 'NoneType' object has no attribute 'ptr'

Related https://github.com/cupy/cupy/pull/4337

Since #4337 is closed and the focus is shifted to #5172, where I am refactoring the stream stack, it may be a good idea for me to fix this issue at the same time.

In this case, after leaving the s3's context, since s2 is deleted the current stream will fall back to null, but we are still in s1 's context. Is this expected behavior?

I think this line is problematic:
https://github.com/cupy/cupy/blob/97acfcdd7293ea5f06083b95d4d14947366542f3/cupy/cuda/stream.pyx#L34
It assumes the weakref is alive, which is incompatible with weakref. If this assumptions is needed (which I think is the case), we shouldn't use weakref at all.
I traced back to e9aaa3c from #306, which added the weakref usage, but the commit message made little sense to me...

Yes, we need to rewind the stream stack until we find an alive one. If everything is dead we should fallback to the default stream.

Yes, we need to rewind the stream stack until we find an alive one. If everything is dead we should fallback to the default stream.

Ah...OK so this is what you meant for #4337. Let me think about it. I feel it might be possible to just peek at the latest stream in the stack.

Yes, we need to rewind the stream stack until we find an alive one. If everything is dead we should fallback to the default stream.

Ah...OK so this is what you meant for #4337. Let me think about it. I feel it might be possible to just peek at the latest stream in the stack.

OK I don't think this is feasible, as it means when calling stream.use() we also need to push the current stream to the stack, which has no way to be popped correctly and is inconsistent with the current behavior.

Yes, we need to rewind the stream stack until we find an alive one. If everything is dead we should fallback to the default stream.

Ah...OK so this is what you meant for #4337. Let me think about it. I feel it might be possible to just peek at the latest stream in the stack.

I was being silly. To enable this we just need to push the current steam to the stack as well.


Update bootstrap.sh

modified by @fedex1 3/15/2015 seems to be the latest version at this point in time.

arikfr merged... deleting to clean up.


Improved support for custom image loaders

The fixup for #19374 which I messed up but have cleaned up here.
Removed image loader limit. Support to add/remove/find/list image loaders. Resolves both #19322 and #19037
@reduz can you check this now. Ta

Thanks @LikeLakers2, I forgot to come back and check everything was mergable. Should all be good now.

Ah, I forgot about this, and it was much better than my fix. Can you please rebase it/fix it, so I can merge it?

@reduz Rebased all ready for you to merge!

We already discussed 16 PNG support and rejected it, sorry. The reason is that users have no idea what are they saving their image as, and both applications and converters don't really tell you much about this.. the result is huge exports without the users noticing.

Woops! Sorry, I didnt see that go in with my rebase. I'll remove it


Question: Sourcemap Support

OS:

[X]  Windows
[ ]  MacOS
[ ]  Linux

Platform:

[ ]  iOS
[ ]  Android
[X] Windows

Question, not an issue: For whatever reason I cannot get the sourcemaps to upload correctly for my react-native-windows project. Is it a limitation of using react-native-windows?
Does the upload-sourcemaps command in the cli supposed to take a bundle and a map file? ie: index.windows.bundle and windows.main.bundle.map? I was able to get them uploaded to the Sentry Release I created just fine, but my Issue which also has the same release tag cannot be deciphered.
It also still shows:
Source code was not found for app:///index.windows.bundle?platform=windows&dev=true&hot=false Collapse
{
  "url": "app:///index.windows.bundle?platform=windows&dev=true&hot=false"
}

Thoughts?

Using --validate shows - Warning: missing sourcecode ... too

So there currently is a bug when uploading sourcemaps in debug mode see:
https://github.com/getsentry/react-native-sentry/issues/294
This might be related, I will take a look at this.

I was finally able to get it working, the final command was something akin to:
sentry-cli releases files $RELEASE upload-sourcemaps --dist $DIST --strip-prefix $CHECKOUT_DIR --rewrite --validate $CHECKOUT_DIR\index.windows.bundle $CHECKOUT_DIR\index.windows.bundle.map

and when I generated my sourcemap I needed to make sure the following was run:
node node_modules/react-native/local-cli/cli.js bundle --platform windows --entry-file index.windows.js --bundle-output index.windows.bundle --assets-dest windows/MyApp/ReactAssets --dev false --sourcemap-output index.windows.bundle.map --sourcemap-sources-root ./

the key part was the sourcemap-sources-root ./ which might have been because of the way my project was setup with all of the source files/folders being at the root of the project

Thanks, so I will close this for now.


Don't convert mp3 or wav

Following https://github.com/huggingface/datasets-server/pull/1743
Fixes (hopefully) #1255 if the speed is finally good enough.

Codecov Report
Patch coverage has no change and project coverage change: -3.68% :warning:

Comparison is base (d32c5ea) 90.24% compared to head (c94f9a9) 86.57%.
 Consider uploading reports for the commit f3d83e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
- Coverage   90.24%   86.57%   -3.68%
==========================================
  Files         223       92     -131
  Lines       13709     3114   -10595
==========================================
- Hits        12372     2696    -9676
+ Misses       1337      418     -919

Flag
Coverage Δ

jobs_cache_maintenance
99.42% <ø> (ø)

jobs_mongodb_migration
85.92% <ø> (ø)

libs_libapi
?

libs_libcommon
?

services_admin
87.44% <ø> (ø)

services_api
87.21% <ø> (ø)

services_rows
?

services_search
79.16% <ø> (ø)

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 131 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP(iox-11398): (moar) patched df upgrade 2024-07-02

⚠ This will not be merged. ⚠
Same as the existing branch here, but added an additional two cherry-picked commits:
https://github.com/apache/datafusion/commit/6038f4cfac536dbb54ea2761828f7344a23b94f0
commit a33679d0bf33d960e83c6d47d3c420922d0c3271
Author: wiedld<EMAIL_ADDRESS>Date:   Wed Jul 10 11:21:01 2024 -0700

    Track parquet writer encoding memory usage on MemoryPool (#11345)

https://github.com/apache/datafusion/commit/1dfac86a89750193491cf3e04917e37b92c64ffa
commit f07e3431e356eeed5d7a1cf9d3cc9eeeafaf8c5f (HEAD -> wiedld/update-df-july-week-1, influx_origin/wiedld/update-df-july-week-1)
Author: wiedld<EMAIL_ADDRESS>Date:   Fri Jul 12 04:04:42 2024 -0700

    fix(11397): surface proper errors in ParquetSink (#11399)

We have advanced beyond this branch. Closing.


Add Remarks

#691

The maximum number of drivers registered to receive load-image notifications is 64 in Windows 10 1709 (Windows 10 Kernel Version 16299 MP (1 procs) Free x64).
PsSetLoadImageNotifyRoutineEx:

Index check:

If index is 64, it returns 0C00009Ah:


Update MD file on new branch 2017-12-03_16-47-31

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Avoid running slow benchmarks as part of testing

It's good to test that these benchmarks run. It's really annoying to run
a billion iterations of them every time you try to run tests. This
literally takes longer than all the other tests combined. Instead, make
these binaries and invoke them for testing with
--min_benchmark_time=0.
This introduces CMake and Bazel -> CMake support for run_binary_test,
which runs the specified executable target with the specified args.
Punted on support for data dependencies, since these are not required
for this use case and I think we still haven't figured out how to do
that for CMake tests.

Depends on #4362. Only the last commit is part of this PR

Argh crosscompiling :-/

Argh crosscompiling :-/

Well it's a bit difficult for me to debug this, since I can't get cross-compiling to work for me locally at all...

The issue isn't even with iree_run_binary_test, it's having an iree_cc_binary that depends on iree::testing::benchmark_main

CMake Error at build_tools/cmake/iree_cc_binary.cmake:89 (add_executable):
Target "iree_base_synchronization_benchmark" links to target
"iree::testing::benchmark_main" but the target was not found.  Perhaps a
find_package() call is missing for an IMPORTED target, or an ALIAS target
is missing?

Blargh IDK what's going on here

@antiagainst can you offer any insight on what might be going on with the cross compiling? I can't get a successful local build, so a bit hard for me to debug, but it at least seems to be dependent on which target depends on benchmark_main. Maybe this is the same bug that requires adding subdirectories in a certain order somewhere else?

@antiagainst can you offer any insight on what might be going on with the cross compiling? I can't get a successful local build, so a bit hard for me to debug, but it at least seems to be dependent on which target depends on benchmark_main. Maybe this is the same bug that requires adding subdirectories in a certain order somewhere else?

So yes, the issue appears to be that during cross compilation, we can't find the benchmark_main library specifically for the synchronization_becnhmark... that's awful. But moving synchronization_benchmark to vm/ doesn't fix the problem either, so it's not just the directory location :cry:

So yes, the issue appears to be that during cross compilation, we can't find the benchmark_main library specifically for the synchronization_becnhmark... that's awful. But moving synchronization_benchmark to vm/ doesn't fix the problem either, so it's not just the directory location :cry:

So yes, the issue appears to be that during cross compilation, we can't find the benchmark_main library specifically for the synchronization_becnhmark... that's awful. But moving synchronization_benchmark to vm/ doesn't fix the problem either, so it's not just the directory location

It's that I didn't mark it TESTONLY and Bazel -> CMake doesn't work on that file :facepalm:. I still find this cross compilation a bit sketchy...

So yes, the issue appears to be that during cross compilation, we can't find the benchmark_main library specifically for the synchronization_becnhmark... that's awful. But moving synchronization_benchmark to vm/ doesn't fix the problem either, so it's not just the directory location

It's that I didn't mark it TESTONLY and Bazel -> CMake doesn't work on that file :facepalm:. I still find this cross compilation a bit sketchy...

Nice catch! My goal (after this HAL rewrite) is to stamp out the last few (reasonable) files that don't bazel-to-cmake - will be much nice when able to be consistently relied upon.

Nice catch! My goal (after this HAL rewrite) is to stamp out the last few (reasonable) files that don't bazel-to-cmake - will be much nice when able to be consistently relied upon.

Ok that's working now. I got a successful run on the android build, but force pushed over all my debugging and reverting since I figured no one had been looking at the commit history yet. I'll trigger another one. Sending this for review as a first step. This handles the worst offenders. I think we could actually wrap this in a macro that creates a binary and a test for it. Could either be specialized to benchmarks and automatically pass --benchmark_min_time=0 or be a general binary-with-test that just has a test_args attr.

Ok that's working now. I got a successful run on the android build, but force pushed over all my debugging and reverting since I figured no one had been looking at the commit history yet. I'll trigger another one. Sending this for review as a first step. This handles the worst offenders. I think we could actually wrap this in a macro that creates a binary and a test for it. Could either be specialized to benchmarks and automatically pass --benchmark_min_time=0 or be a general binary-with-test that just has a test_args attr.

Sorry just noticed this.. Looks like it's already resolved? Do you still need my help?

Sorry just noticed this.. Looks like it's already resolved? Do you still need my help?

No worries. Yeah I figured out this issue, thanks. Of course now running the tests on android is failing (I only tested the build, whoops...)

No worries. Yeah I figured out this issue, thanks. Of course now running the tests on android is failing (I only tested the build, whoops...)


when i try to use multiple serverSideTranslations in getStaticProps it doesn't works.

when i try to use multiple serverSideTranslations in getStaticProps it doesn't works.
export const getStaticProps = async ({ locale }) => ({
props: {
...(await serverSideTranslations(locale, ["landingPage", "LogoutBanner"])),
...(await serverSideTranslations(locale, ["translation", "PrivateLayout"])),
...(await serverSideTranslations(locale, ["header", "HomepageBanner"])),
},
});
this overrides the translations.

Why are you attempting to do this in the first place? Just pass all your namespaces into one array. Good luck!


Checkbox: no way to prevent to be focused

Bug Report
Hello :)
Steps
With the current implementation, I cannot find a way to prevent a checkbox to be focused when clicked. I tried with e.preventDefault() and also by forcing the tabIndex to be "null", undefined, etc.
Expected Result
There should be a way to prevent a checkbox to acquire the focus when clicked, for exemple using preventDefault. It would be closer to the input checkbox behaviour.
(For information: my use case is a focus problem with react-hotkeys)
Actual Result
The checkbox is focused no matter what
Version
0.84.0
Testcase:
Check the focused element in the consle
https://codesandbox.io/s/l97zrrpq87
Please let me know if I missed something

In native input[type=checkbox] you can prevent focus in onMouseDown handler: https://codesandbox.io/s/semantic-ui-react-wq5ys
We should do the same thing in our component, fix is coming 🚀


Tests: List App Variants and edge cases

Converting to draft to resolve merge conflicts and fixed some bugs.


Feature request: Task priority

First off, thank you very much for this very useful framework.
I do apologise in advance if this isn't the correct place to raise a feature request or if you're not looking at requests at all. In any case some basic task prioritisation would be very useful. The ideal implementation would allow multiple worker nodes (a single resource pool) to pick up tasks from a single task queue that handles the prioritisation internally, abstracted away from the consumer.
To illustrate:
from saq import Queue

# Create queue
queue = Queue.from_url("redis://localhost")

# Enqueue tasks (We assume a higher number is a higher priority)
low_priority_task = await queue.enqueue("some_task", a=5, priority=25)
high_priority_task =await queue.enqueue("some_task", a=5, priority=100)
medium_priority_task = await queue.enqueue("some_task", a=5, priority=50)

Now when starting up a worker once these jobs have been enqueued successfully, these jobs will be popped in the order:

high_priority_task
medium_priority_task
low_priority_task

P.S. Queue-based priorities can be nice but often have significant infrastructure/configuration trade-offs so I much prefer Enqueue-time prioritisation.

there are no plans to implement priorities since you can just have different queue based priorities.
that said if you made a simple pr to do this i would accept it


Connecting tch-rs examples to published paper models

The vae example features a paper citation, but I am looking at some of the other models including the cifar example and am not always finding paper references. For example, the cifar example appears to be a "fast resnet" in the source but I can't find a paper mentioning that model-- is this resnet50?

It's actually not a resnet 50 but rather a custom very lightweight resnet if I remember correctly - I don't think there is a paper describing it properly but the proper resnet-50 architecture can be found in the vision module here - with a link to the paper at the top of the file.


Is SharePoint Starter Kit ready for Production use?

Category

[x] Question
[ ] Bug
[ ] Enhancement

I understand that the starter kit works in targeted release tenant only. We showcased the sample implementation of sharepoint starter kit to our client and now they want it implemented in production tenant.
Is SharePoint starter kit as of its current state recommended for production tenants? Please clarify.

The SP Starter Kit requires the entire tenant be configured for targeted release for all users. I would never recommend a production tenant be configured for targeted release.
That does not mean you cannot provision most of the starter kit to a non-targeted release tenant though. You can, you will have to work through a few errors and warnings during installation, and certain SPFx webparts that require the GraphClient will not function at this time. Hopefully soon the targeted release requirement will not be needed although there is no official timeline yet.
That all being said, the starter kit is a community driven effort, meaning, although the implementation strategy and code is solid in my opinion, it is not officially supported or maintained by Microsoft or any other third party vendor. The starter kit was definitely designed to help you kickstart your Office 365 / SPO journey, showing off what is possible, as well as delivery solutions now.
You should expect more changes to the kit throughout the year and beyond. If you were to use the kit in production, I would recommend you review all components you intend to use including the provisioning, site scripts, site designs, webparts, and extensions so that you are confident you know what is there, and you could fix any issue that may arise. If you are at that point, I see no reason why would couldn't use part or all of the current kit in a production tenant.

I saw Beau Cameron has a version for standard release mentioned here: https://beaucameron.net/2018/06/25/pnp-starter-kit-for-standard-release-tenants/

As @nicholas-morris  mentioned, I did post a version of it for tenants that aren't in First-Release. But please please be aware, that some bugs still exist in the PnP Starter Kit and be cognizant of where you deploy this, and I also won't be maintaining that repo with any new fixes.

Hi all, do we have any updates on when the targeted release requirement will no longer be needed for the starter kit? Like many, I've found the kit to be a brilliant way to sell the benefits of 365 and show the "art of the possible" to the institution. I would really like to use the kit as a basis for our intranet development but we can't really do this until it supports standard release. I guess the main obstacle are the web parts using the new Graph client.... Any updates would be appreciated.
-Max

@mag210 The targeted release requirement is due to the utilization of the GraphClient which has not yet gone GA in SPO itself. Based on recent PnP Community calls, we are expecting SPFx v 1.6 in the next few weeks or early Q4. We have been told that v1.6 is expected to include the GA of the GraphClient.
Also consider that Ignite 2018 is later this month (Sept 2018). I have to believe that is a big driver to release 1.6 either right before or right around Ignite although that is only speculation.

Hi @eoverfield , I see that the 1.6 version of SPFX is now in general release. Does this mean we can now use the starter kit in production tenancies which are not setup for First Release? The Graph APIs look like they are now available for GA so I would assume so?
Thanks,
-Max

Thanks @eoverfield. Looks like we're not too far off. This is going to be a huge help for SPFX Intranet developers all over...

@mag210 Yes, once @waldekmastykarz's commit is merged into the master branch, we should all be set and all tenants should be able to use the starter kit without the targeted release requirement. If you want to test the updates now, pull the dev branch and deploy that to one of your dev tenants.

hi guys any update on this ?  i want to test it in production tenant. Thanks

@Rtoribiog This is related to https://github.com/SharePoint/sp-starter-kit/issues/168#issuecomment-427535039. I am working to get us an updated timeline.

Dear All,
looking on https://provisioning.sharepointpnp.com/  Targeted release option is requested despite 1.8.x SPFX version is available. could u kindly update?

Closing - This has been answered on this thread. If you have any further questions,  please open a new issue.


Clue juggling

Description:

Changes:

Other checks:

[ ] I have tested all my changes thoroughly.

Closes https://github.com/oldschoolgg/oldschoolbot/issues/5902


Netapp: Java ReadMe Update

Added tag for latest NetApp release to the java readme.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Can one of the admins verify this patch?


feat: add CI to push container to ghcr

@budimanjojo thanks for the contribution! let me know if that allows you to use the docker image directly from your fly config.


addresses race conditions with slow loading frames

For #299 we supported selectors for frames by doing a lookup of all the frame elements and all the frame elements matching the provided selector. I'm hitting a race condition where the frame hasn't finished loading on the page. With the current code the all_elements variable returns a size of zero, but the ElementCollection#elements call returns with a size of one.
The subset of matching iframes should never be greater than all the iframes on the page.

I do not 100% understand what's going, can you somehow show example to reproduce the problem or write a spec for it?
From what I got, case when frame hasn't finished loading (i.e. not in DOM?) should be handled by test, isn't it?

For example, my test does something like:
browser.table(id: 'table_id').iframes.find { |iframe| iframe.element(id: 'element_id').exists? }
The iframe is inside a wysiwyg element that takes a long time to fully load.
The code as it is currently written:

searches frames matching the selector
searches for all frames
maps the arrays to assign the index value of the matching frames to entire list of frames

When the component loads quickly, both #1 & #2 steps result in an array with a single iframe and everything maps as expected
When the component loads very slowly, both #1 & #2 steps result in empty arrays because the iframe is not found, yet. This can be dealt with in the test code using when present logic.
The problem is when the wysiwyg hasn't yet finished loading in step #1 (so empty array), but finishes loading in before step #2 (array with single element).
when all_elements == []
then
elements.map { |el| all_elements.index(el) } => [nil]
Which results in the to_a method returning an iframe with an index of nil, which then causes errors in the lookup later. There is no easy way to deal with this in just the test code. I can't access the selector of the element to see if an index key is defined and verify it isn't nil.
Since the subset of the set should never be larger than the set, it makes sense to address the issue here. If the condition does not apply, no looping happens and everything is as it was.

Ok, I now understand the case, but I believe we can do something like this:
diff --git a/lib/watir-webdriver/elements/iframe.rb b/lib/watir-webdriver/elements/iframe.rb
index 5caed9f..2d305ff 100644
--- a/lib/watir-webdriver/elements/iframe.rb
+++ b/lib/watir-webdriver/elements/iframe.rb
@@ -64,7 +64,12 @@ module Watir
           element_class.attribute_list
       ).locate_all

-      elements.map { |el| all_elements.index(el) }
+      # In case first lookup `all_elements` returns empty array,
+      # but second lookup `#elements` returns non-empty empty array
+      # (i.e. frame has loaded between these two calls),
+      # index will return nil. This is a race condition that should
+      # be gracefully handled.
+      elements.map { |el| all_elements.index(el) }.compact
     end

   end # IFrameCollection

Or actually locate all_elements inside map:
diff --git a/lib/watir-webdriver/elements/iframe.rb b/lib/watir-webdriver/elements/iframe.rb
index 5caed9f..b5bded6 100644
--- a/lib/watir-webdriver/elements/iframe.rb
+++ b/lib/watir-webdriver/elements/iframe.rb
@@ -62,9 +62,14 @@ module Watir
           @parent.wd,
           {tag_name: @selector[:tag_name]},
           element_class.attribute_list
-      ).locate_all
-
-      elements.map { |el| all_elements.index(el) }
+      )
+
+      # In case first lookup `all_elements` returns empty array,
+      # but second lookup `#elements` returns non-empty empty array
+      # (i.e. frame has loaded between these two calls),
+      # index will return nil. This is a race condition that should
+      # be gracefully handled.
+      elements.map { |el| all_elements.locate_all.index(el) }
     end

   end # IFrameCollection

I believe those two implementations will have the same result but won't require introducing additional begin ... while loop and 2 additional wire calls (i.e. calling #size on each of elements set).

We also need to come up with spec for this (guess it can only be implemented with stubs).

Oh good, I like both of those better than the while loop, especially the 2nd one.
I'll write up a spec for it and push it tomorrow.
Thanks!

Refactor is slightly different from your example, but the same idea. Made it easier to write the test implementing it this way. Let me know if both of these pull requests work for you, and if you wouldn't mind, let me make sure I can push directly to the project and update the submodule properly.

Coverage increased (+0.01%) to 95.79% when pulling f1684c8b5daf24005b67d1d57f0e1ac638281da9 on titusfortner:frame_race into 6a8d1d41a3c91a300a4eb7608fa70c1e5acd452f on watir:master.

Coverage increased (+0.01%) to 95.79% when pulling f1684c8b5daf24005b67d1d57f0e1ac638281da9 on titusfortner:frame_race into 6a8d1d41a3c91a300a4eb7608fa70c1e5acd452f on watir:master.

Coverage increased (+0.01%) to 95.79% when pulling f1684c8b5daf24005b67d1d57f0e1ac638281da9 on titusfortner:frame_race into 6a8d1d41a3c91a300a4eb7608fa70c1e5acd452f on watir:master.

Changes seem great! I'm leaving this as is so you can push directly.


hibernate reactive + multi threaded network applications

Hello everyone, that's not kind of issue and supposingly there is a variety of articles related to this problem, but anyway I want to hear some recommendations from hibernate-reactive developers. Some days ago I noticed interesting exceptions:
java.lang.IllegalStateException: Session/EntityManager is closed and io.vertx.core.impl.NoStackTraceThrowable: Transaction already complete
After doing some investigations I jumped to conclusion, that the main reason of these exceptions is a multi-threaded network layer (in my case netty's working threads). As you know netty has core_numbers * 2 working threads by default and it means, that connections are evenly distributed over them (one working thread can handle thousands of users). And that's why hibernate-reactive can be useful there to achive real "non-blocking" packets execution.
Now my connection between database and network layer looks like:

one session factory, which creates at server's initialization
so-called "repositories" (something like in spring boot framework), each entity has his own repository, which provides operations for working with it (only repositories are able to access session factory and work with methods sessionFactory.withSession { // work }, sessionFactory.withTransaction { // work }).
netty's network handler (connection/user handler) can access to repositories and do necessary operations with entities.

And some basic aspects:

in the "idle" state (when there is no database operations) there aren't any opened sessions or transactions.
when connection wants to do something with database entity (or executes a query), it refers to appropriate repository, then repository opens session or transaction (using methods sessionFactory.withSession { // work }, sessionFactory.withTransaction { // work }) and executes some operations.
there aren't any extra synchronization code or something like that, just netty's native handler.

Bringing back to mentioned exceptions java.lang.IllegalStateException: Session/EntityManager is closed and io.vertx.core.impl.NoStackTraceThrowable: Transaction already complete, I'm not an expert in hibernate, but in my view such exceptions are happening because different threads (netty's working threads) concurrently trying to use sessions (or transactions) and sometimes "session's pool" thinks that there is an already opened session in current context, but when it comes to execution of query, session is already closed by another thread. And that's why I made a conclusion, that supposing there is something wrong in server's code design.
Now I have possible solutions:

To use method sessionFactory.openSession, which always opens new session
To create sessionFactory for each netty's working thread (lol, is it possible?), to made threads using their own context
To do some synchronizations, for instance, implement a concurrent queue of repositories' queries with callbacks and run them asynchronously in one session in main thread's loop (but then the main idea of reactive approach will be violated :/)

So what do you think about it and it would be nice to hear some recommendations about improving my current network/database logic to bypass such annoying exceptions.

It sounds like you need to make sure you allocate exactly one Session for each thing you're calling a "connection".
You haven't talked about Vert.x contexts, so I'm not terribly surprised that withSession()/withTransaction() aren't working for you. They will only work if you make sure you have one Vert.x context per connection.

To do some synchronizations

That sounds like it would completely undermine the whole point of reactive.

Closing this due to inactivity.


fix yaml key (format->type)

should be type, not format, I believe.  Fixes #106
Target branch:
Resolves issue #

[ ] It is a Bug fix
[ ] It is a New feature
[ ] Breaks BC
[ ] Includes Deprecations

It appears that screenshots and icons have different keys :-(
        icons:
          -
            src: icons/icon-1024x1024.png
            sizes:
              - 1024
            type: image/png

        screenshots:
              - src: screenshots/screenshot-1200x1100.png
                width: 1200
                height: 1100
                format: image/png

So my PR probably breaks one.  I think the best solution would be to make them consistent names.

Hello. Many thanks. I am AFK with limited access to the Internet. I will have a look at the last issued you raised on Sunday.

Many thanks.
Screenshots use type when icons use format.

Screenshots use type when icons use format.

What's the benefit of that?  There's no 'format' in the docs for either icons or screenshots, only 'type'.

What's the benefit of that?

This is just a hint for the browser that will use the most suitable icon/screenshot.
I am not sure but e.g. I think Chrome will prefer webp images instead of jpeg or png.

There's no 'format' in the docs for either icons or screenshots, only 'type'.

I missed that. The documentation is now up to date.

OK I understand. I wanted to have key/values in line with the spec. But your remark is legit to me.
To me, type is correct as we are talking about mime type for both properties.


Is the library still in maintenance ?

Hi, greetings, I like this library is usefully for a feature that I'm working, but maybe I want upgrade a bit the component, with hooks and more custom properties for the classnames or disable the search bar and only leave the categories list, are you interested in those changes if I send a pr soon ? :)

Hi @franjorub,
Yes, the package is still accepting pull requests and issue reports. https://github.com/10up/insert-special-characters is using it for their Wordpress plugin and so some form of maintenance is ongoing, they also have a list of potentially useful changes (the default charsets grouping etc) that are in need of assistance, it might be worth noting if the changes you're looking to do cover any of those issues.
Feel few to discuss changes you want here too.


Write all numbers as floats

I had the type conflict issues for numbers.
Both the:

'write failed: field type conflict: input field "XYZ" on measurement "ZYX" is type int64, already exists as type float
'write failed: field type conflict: input field "ABC" on measurement "ZYX" is type float64, already exists as type integer

InfluxDB (v2) sets the type int or float for a specific field based on the data first written (to a shard(!) impossible to control) and since javascript/typescript both input values 1.0 and 1 are Number.isInteger == true, then it's only a matter of time before a subsequent write fails in the above mentioned errors.
An old InfluxDB discussion (2015) suggest always writing numbers as floats (except for the timestamp), so this PR suggests doing the same in the n8n-nodes-influxdb-package.

I just had the same issue with this node, It would be great if @naskio could take a look at this


Add missing function return types (mostly None) to reloader.py

Description
This PR improves type hinting by adding return type hints to the functions in reloader.py that didn't have them.

PR Checklist
Please ensure that:

[X ] The PR contains a descriptive title
[X ] The PR contains a descriptive summary of the changes
[X ] You build and test your changes before submitting a PR.
[X ] You have added relevant documentation
[X ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

[X ] Ensure that you have run the pre-commit hooks on your PR.

Hi @sansyrox
I'm getting lots of false ci failures at the moment (mostly timeouts). Is that upgrade to uv going to fix these?

Hey @dave42w 👋
Thank you for the PR, just have one suggestion

Sorry about that.
I'm getting so many ci errors that it's hard to spot the real ones.
Also a worry that some real errors only show up on only one platform when it should be consistent.
Anyway this is now showing the rust warning.
https://github.com/sparckles/Robyn/actions/runs/12095320152/job/33728364712#step:4:1


environment_check.sh: add nfs client kernel support

Longhorn/longhorn#3157
Signed-off-by: Derek Su<EMAIL_ADDRESS>

@Mergifyio backport v1.4.x

@Mergifyio backport v1.3.x


Page privacy groups

Here is a take on how restricting pages to users in specific groups could work. This builds on the same flow that was already in place for page restrictions and adds a groups option to the PageViewRestriction model. The login process uses the normal django auth. Please take a look and let me know what you think and if I missed anything. Thanks!

This looks great, @smakinson! Thanks a lot. We'll review ASAP.

Nice one! No issues from me with the UI.

Rebased here, along with some minor fixes: https://github.com/gasman/wagtail/tree/smakinson-page-privacy-groups
A couple of remaining issues to clear up:

https://github.com/gasman/wagtail/blob/smakinson-page-privacy-groups/wagtail/wagtailcore/wagtail_hooks.py#L28
  # Super users can browse the site in full. TODO: Is this what we want?

Yes, I think so. (Any objections...?)

Currently, a user who has successfully authenticated but has insufficient permission for a page, is redirected back to the login page, with no message to indicate what's happened. Not entirely sure what the best approach for this is - adding a new template specifically for a "you are authenticated but don't have permission" message seems a bit heavyweight, but any alternative methods (e.g. sticking an error message in the 'messages' dict before redirecting back to the login view) would probably involve extra assumptions on how the site's login system is set up.

Providing our own registration/login.html template is probably a bit too disruptive for existing users, as it's likely to override any existing login template (since standard practice is to put Wagtail's apps at the top of INSTALLED_APPS). Ideally, we want a solution that works for new Wagtail sites out of the box, but also gets out of the way as soon as the developer implements their own auth views (and still works properly regardless of how complex or non-standard those views are). Maybe adding a default login template to the 'wagtail start' project template is the answer... needs more thought, though.

I've posted an update on the current state of this feature at https://github.com/torchbox/wagtail/issues/257#issuecomment-248401768 - since we have several issues and PRs open about this feature, I suggest that any further discussion (unless it specifically relates to the code in this PR) is continued there.

Now incorporated into #3071.


TAA off screen reprojection FXAA fallback

Update
I'm abandoning this in favor of using https://github.com/DGriffin91/bevy_mod_taa which addresses many issues with the current TAA implementation.
I also don't think falling back to FXAA is a great approach.
Objective

TAA reprojection clamps to the screen edges causing smearing when reprojection is off screen.

Solution

If the reprojection is off screen, fall back to FXAA.

This PR also updates the anti_aliasing example with a noise texture and camera movement needed to illustrate the issue.
These images show the camera under motion. View at full resolution and note right side of image.
Current TAA:

FXAA fallback:

No FXAA fallback:

In light of https://github.com/bevyengine/bevy/pull/8974#issuecomment-1624501534 I think we should hold off on this and discuss our options for 0.12. If this behavior is only present for worst case "super noisy" textures, adding in more complexity here might actually make the common case worse (given that the seams on the FXAA fallback line are pretty stark).

@DGriffin91 could you open a new PR / modify this one to make FXAA a function in order to allow FXAA to be able to be called from TAA? I'll then integrate it into my PR.

I'm abandoning this in favor of using https://github.com/DGriffin91/bevy_mod_taa which addresses many issues with the current TAA implementation.
I also don't think falling back to FXAA is a great approach.


Bullet list of form widgets

Bullet list of form widgets - Simple and standard doc across like the other pages.

@sharat87 @Nikhil-Nandagopal for review 👍

@valerianpereira this is a low-quality PR and doesn't add much value to our documentation as such I'm rejecting it. If you would like to contribute in a meaningful way, I suggest having a look at our many open good first issues 😃


Improve compatiblity

This PR improves compatiblity with other projects that DPP is included into.
#include <dpp/win32_safe_warnings.h> is to prevent dll-interface warnings while compiling the main application.
#ifndef SOCKET is used to prevent possible incompatiblities with projects that already handle that case (such as network libraries). This way the socket will still be defined but only if it wasnt earlier.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Renamed PR to follow naming scheme