Feature/issue 776

Codecov Report

Merging #957 (c25c7d9) into _V2.2.X_IPV6_issue#776_feature_ipv6_import (b56f85c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                             Coverage Diff                             @@
##           _V2.2.X_IPV6_issue#776_feature_ipv6_import     #957   +/-   ##
===========================================================================
  Coverage                                       72.12%   72.12%
===========================================================================
  Files                                             303      303
  Lines                                           22245    22245
===========================================================================
+ Hits                                            16044    16045    +1
+ Misses                                           6201     6200    -1

Impacted Files
Coverage Δ

apps/node_man/handlers/job.py
85.79% <0.00%> (-0.54%)
:arrow_down:

apps/backend/subscription/steps/plugin.py
48.13% <0.00%> (+0.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56f85c...c25c7d9. Read the comment docs.


Build failure in FreeBSD i386

https://github.com/icing/mod_h2/blob/9ef8f6b838d062ca55807b3c8faaaded316c342a/mod_http2/h2_util.c#L1183
--- mod_http2_la-h2_util.lo ---
h2_util.c:1183:23: error: result of comparison of constant<PHONE_NUMBER>854775807 with expression of type 'apr_size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
         && b->length > APR_INT64_MAX)
            ~~~~~~~~~ ^ ~~~~~~~~~~~~~
1 error generated.
*** [mod_http2_la-h2_util.lo] Error code 1

This is for the previous version 2.0.13, but this code hasn't changed for 6 months. Recently updated the port from 2.0.7 to 2.0.13 after which this build failure is reported by the FreeBSD ports builders https://pkg-status.freebsd.org/beefy15/data/131i386-default/25decddf345c/logs/ap24-mod_http2-2.0.13.log

Issue persists in 2.0.14 fwiw.
https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pda2b1b709c95_s21ef48af5c/logs/errors/ap24-mod_http2-2.0.14.log

Fixed by adding -Wno-error=tautological-constant-out-of-range-compare to CFLAGS for i386 port.


Fix issues brought up in code review (Issue #1)

This takes care of everything but the license listed in Issue #1. As I'm not the original author, I'm not comfortable changing the license on @AltarBeastiful's behalf.
I'm using the integration right now, and it works quite well.

Thanks for the fixes, just need to update the license now.


First (index) page is hitting /api/v1/spans?serviceName=undefined

When first loading the Zipkin UI (tested with zipkin-query 1.39 docker container) it seems that the Javascript is trying to load spans with undefined serviceName.

@eirslett mind helping on this one? I'm not quite sure the best way to early exit on this..

Actually i thought it was even simpler than that. Maybe I should have rephrased things a little better.
When loading zipkin ui homepage (/ url) it shouldn't be loading any spans since nothing has been selected. This is also where the undefined comes from for the serviceName. Is it possible to make this a conditional of sorts just for the homepage case?

Yes, the event that triggers the API call should only be triggered when service name is set in the query string. We use query-string for that already, in other places.


Added Tabs

Two variants

TabPrimary
TabSecondary

This PR fixes the issue of Badge Component -  Right calculation
Preview 👁
https://github.com/user-attachments/assets/cffa9ef2-c7b7-4985-bd4b-ca195409c081
https://github.com/user-attachments/assets/1e4bf6d3-ad52-420b-a3bb-686a356b0b7b

📍 TODO: Need to add the Scrolling logic to the Tabs, so that it can handle many tabs by adding Scrolling logic by keeping the Gap between.

📍 TODO: Need to add the Scrolling logic to the Tabs, so that it can handle many tabs by adding Scrolling logic by keeping the Gap between.

Scrolling has been done with the commit link


Tests Failing on Master

I cloned the repo today, and I'm seeing tests fail out of the box:
component:infinity-loader: it throws error when scrollable element is not found
    ✘ Should raise error

component:infinity-loader: it throws error when multiple scrollable elements are found
    ✘ Should raise error

component:infinity-loader: it throws error when scrollable is something other than nothing or string
    ✘ Promise rejected after it throws error when scrollable is something other than nothing or string: Cannot read property 'off' of undefined

    ✘ Expected 1 assertions, but 2 were run

component:infinity-loader: it checks if in view on the scroll event
    ✘ Promise rejected before it checks if in view on the scroll event: Assertion Failed: You cannot use the same root element (#ember-testing) multiple times in an Ember.Application

    ✘ Died on test #2     at testWrapper (http://localhost:7357/assets/test-support.js:6236:11)
        at test (http://localhost:7357/assets/test-support.js:6250:39)
        at Module.callback (http://localhost:7357/assets/tests.js:825:24)
        at Module.exports (http://localhost:7357/assets/vendor.js:65:34)
        at Module.build (http://localhost:7357/assets/vendor.js:115:10)
        at findModule (http://localhost:7357/assets/vendor.js:163:9)
        at requireModule (http://localhost:7357/assets/vendor.js:150:12): this.subject is not a function

    ✘ Expected 1 assertions, but 2 were run

component:infinity-loader: it checks if in view on the resize event
    ✘ Assertion after the final `assert.async` was resolved

    ✘ Expected 1 assertions, but 2 were run

master is passing again.


No date separator in message list

Description
There is no date separator between messages
Devices and Versions

Your Rocket.Chat.Android version: 2.2.0 build 2021
Your Rocket.Chat Server version: 0.65.1

Mobile device model and OS version: (e.g. "Huawei P8 Lite- Android 7.0")
Steps to reproduce

Open #general to see the issue
Logs

"[UI] Day marker or date with time. #865" still to be merged in 2.2.0

This will be shipped soon. There is a opened PR to do that. I'm closing this issue since you can track/interact from #865
Thanks.


Figure out how to correctly retrieve dependencies from source distributions

Our current method of getting dependency requirements for a source distribution is to install it in a virtual environment and then query the list of packages with pip list. We then construct a series of requirements that look like: {package}=={version}. This is overly restrictive and doesn't capture what the actual requirement is. You can see the code that does that here.
For example, a package foo might require bar>=1.0. When we install into a virtual environment we'll probably install the latest version (let's say that's bar-3.0). We'll assume that the requirement is bar==3.0. If we later get a package that requires bar==2.0, then we'll throw an impossible resolution because we can't satisfy both of these requirements. In reality, we should have just selected bar-2.0.
I think that in order to continue with this current approach where we bundle our own resolver, we need to somehow teach pip-audit how to find requirements for arbitrary source distributions, similar to what pip figures out when you do pip install .. This seems difficult as pip probably doesn't expose any of this in a way that we can consume as a library.
The other possibility is that we remove the resolver entirely and just lean on pip to do everything and do pip install -r (and perhaps the new --dry-run and --report flags) and pip list inside a virtual environment.
CC: @woodruffw @jleightcap @di

The other possibility is that we remove the resolver entirely and just lean on pip to do everything and do pip install -r (and perhaps the new --dry-run and --report flags) and pip list inside a virtual environment.

I'm a big fan of switching to this -- IIRC the only real risk/challenge there is that we need to figure out how to make the progress spinner responsive when our resolution step goes from something that we control (with resolvelib) to an opaque subprocess.

I'm a big fan of switching to this -- IIRC the only real risk/challenge there is that we need to figure out how to make the progress spinner responsive when our resolution step goes from something that we control (with resolvelib) to an opaque subprocess.

Yeah, that could be tricky. I think the solution might be to just let pip print it's output since it offers a lot of feedback already. But I imagine we'll have to work around it to stop it from messing with the spinner that we already have.

I'm thinking that it might be better to fix this immediately rather than cutting an release in the interim with the hash checking removed. Because even if we fix the issue where dependency resolution is running with hashes, this bug is still really easy to run into now that we're all resolving all dependencies at once as we're meant to.


Undeprecate bookmark

Relevant Issues
Closes #1219
Description
Undeprecated the .bookmark command, for reasons outlined in #1219. A majority of the code and logic was a straight copy paste from an older version of this repository, however some changes have had to be made to be compatible with the new version (as the rewrite to a context menu command had come with other code changes as well)
Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the contributing guidelines?

Seems fine in testing - is there anything I should be looking out for due to the changes made that weren't an exact copy?


Add b-j-roberts ( Brandon ) as a code owner

[ ] issue #
[ ] follows contribution guide
[ ] code change includes tests
[ ] breaking change

Adding myself as a code owner to the project. Going to be joining the team to build piltover.

Warm welcome @b-j-roberts! Let's rock this! :rocket:


fix: Remove Attachment Lg template when they are deleted in the Response Editor

Description
fRemove Attachment Lg template when they are deleted in the Response Editor
Task Item
Closes #6404
Screenshots

Coverage increased (+0.003%) to 52.984% when pulling e2cbb1a2dd827c1aa26e3a72ae7631e38b6f20b9 on fix/lg-remove-attachments into 230ac9a2124958be7518557995f51c945f3d9cef on main.


fix: Switch to qemu Package from hugelgupf/vmtest

Let me know what you think, or if you would do it differently.
Another option would be to collect the arguments in []qemu.FN and use qemu.Start(fn).
Fixes #17

Thanks for your PR! I had a quick look, seems like mostly argument handling has changed. What would you say is the benefit of changing to the new package?

I guess the biggest benefit would be not being stuck with u-root < v0.12.0.


overcoming UnicodeTable.txt download

I am not the package maintainer but I'll leave this info here because it may be useful:
The other way to overcome UnicodeTable.txt download problems under corporate networks, weird proxies, etc is to download everyting manually and distribute "unicode" under "bundledDependencies" in package.json:
{
  "bundledDependencies": [
    "unicode"
  ]
}

Then just place unicode package with downloaded UnicodeTable.txt and generated category dir under your project's node_modules and keep it versioned (actually package.json file and category directory is enough for unicode to work).
I hope it helps someone. I think it can be also mentioned in a README.

try to read file /usr/share/unicode/UnicodeData.txt …
/usr/share/unicode/UnicodeData.txt not found.
try to read file /usr/share/unicode-data/UnicodeData.txt …
/usr/share/unicode-data/UnicodeData.txt not found.
try to read file UnicodeData.txt …
UnicodeData.txt not found.
try to download …
GET unicode.org:80/Public/UNIDATA/UnicodeData.txt
request timed out.
mac pro os x node install.js not work

same thing again
could you do something with this?
curl -vvv -s -i 'http://unicode.org:80/Public/UNIDATA/UnicodeData.txt'
* About to connect() to unicode.org port 80 (#0)
*   Trying <IP_ADDRESS>... Connection timed out
* couldn't connect to host
* Closing connection #0

Why not bundle the file with the lib? This is really annoying..

update  the  install.js  by replacing this code :
unicodedatafile = {
host: "unicode.org",
By this code :
unicodedatafile = {
host: "http://unicode.org",

Finally, how to solve the questions on MacOs?

I've started hitting this timeout issue a lot on a Travis build:
><EMAIL_ADDRESS>postinstall /home/travis/build/guyellis/plant/node_modules/unicode
> node install.js
try to read file /usr/share/unicode/UnicodeData.txt …
/usr/share/unicode/UnicodeData.txt not found.
try to read file /usr/share/unicode-data/UnicodeData.txt …
/usr/share/unicode-data/UnicodeData.txt not found.
try to read file UnicodeData.txt …
UnicodeData.txt not found.
try to download …
GET unicode.org:80/Public/UNIDATA/UnicodeData.txt
request timed out.

Any ideas why Travis would be timing out?

I doubt that it is limited to your Travis environment. When it happens, try getting the file in your web browser. The file is simply not reliably available at that location.
You have two option:

remove the dependency (considering how stale this lib is, I recommend that)
Implement some hack to bypass the flaw

^ cause above is your host being blacklisted for excess downloads, see #16


[Bug]: Missing skybox parts (Deep Lake, others?)

As discussed in #21, the water in Deep Lake shows up as a black void, which gives the water reflection a pretty obvious seam between the "reflected" stage model & the void itself

The void seems to be caused by the skybox itself missing the bottom section, on OR2Xbox the skybox displays as

But in C2C PC, the skybox is

Some other stages do include both sections of the skybox though, eg. Tulip Garden, and can have the model file switched over fine - though since these skyboxes aren't designed for Deep Lake it does seem to cause a small part of the upper sky to leak into the water.

C2C Xbox actually seems to include both skybox sections, the model format between Xbox & PC is really similar too, at least for the C2C releases, maybe that can be reused, though when I tried copying file over it just resulted in sky not displaying, at least it didn't crash though - if we're lucky that could just be some texture incompatibility.

I believe the lake in Cloudy Highlands also has this issue, but it's not as noticeable from the angle you drive in at.

Tried a bunch of edits to see if I could get Xbox model loading but didn't have any luck, some reason almost all the positions/radius/indexes of things had been changed between the two releases, so don't really have any point of comparison to see what could be breaking it :/
Only thing I've really noticed is that the vertex_format_size field is different between Xbox & PC, but the flags that specify what the vertex format contains are the exact same - maybe there's some difference in how Xbox & PC / D3D8 & D3D9 store vertices which changed the size?
Best bet might be to somehow get the model vertices exported to view in another app, can probably figure out what's different between them then, haven't really dealt with 3D models much before though...

Aha got the xbox model running, was just those packed normals that were messing it up 🐱 (that and textures being raw on Xbox while DDS on PC, luckily could just copy the PC texture data over and fix up some offsets)
Result isn't really too noticeable though, like the Tulip fix there's not really any blurring with it so void just seems colored blue, IMO it's still closer to what the intended C2C would have been like though.
OutRun2006Tweaks-DeepLakeSkyboxFix-1.0.zip

Looks like Cloudy Highlands matches between xbox/PC, at least the model file does anyway, didn't check in-game yet - if anyone spots any other black voids let me know.
Did notice the CH skybox model actually had vertex positions matching up between PC/Xbox too, no idea why the DeepLake ones are completely different, maybe they decided to remodel it to improve performance or something.
Might try seeing if I can make a tool to compare all the model vertexes and see what ones got changed, guess the Xbox ones would probably always be closer to original.

Ran a check over all the xbox/pc models, only ~79 out of 524 had vertex differences,
obj_course_obj_sky_lake_pmt seems to be only skybox mentioned there, most of the stage cs_CS files are changed too (though a lot seem to still match up)
BK\ANIMS\obj_bo_prop_pmt different vertex buffer count
Stage\CLOU_R\cs_CS_CLOU_R_pmt different vertex buffer count
Stage\LAKE\obj_course_obj_sky_lake_pmt different vertex buffer count
Stage\LASV_R\cs_CS_LASV_R_pmt different vertex buffer count
Stage\PRIN\cs_CS_PRIN_pmt different vertex buffer count
Stage\PRIN_R\cs_CS_PRIN_R_pmt different vertex buffer count
Stage\YOSE_R\cs_CS_YOSE_R_pmt different vertex buffer count

BK\cs_LRBK_PALM_pmt different vertices
Cars\obj_plcar_328gts_pmt different vertices
Cars\obj_plcar_328gts_t_pmt different vertices
Cars\obj_plcar_575sa_t_pmt different vertices
Cars\obj_plcar_dino_pmt different vertices
Cars\obj_plcar_f40_t_pmt different vertices
Cars\obj_plcar_fx_pmt different vertices
Cars\obj_plcar_fx_t_pmt different vertices
Cars\obj_plcar_testa_t_pmt different vertices
Cars\obj_rc_328gts_pmt different vertices
Cars\obj_rc_512bb_t_pmt different vertices
Cars\obj_rc_550b_pmt different vertices
Cars\obj_rc_550b_t_pmt different vertices
Cars\obj_rc_575sa_pmt different vertices
Cars\obj_rc_f355sp_pmt different vertices
Cars\obj_rc_f430_t_pmt different vertices
Chr\obj_chr_aut04_cvt_pmt different vertices
Chr\obj_chr_aut04_pmt different vertices
Chr\obj_chr_dr_g00_pmt different vertices
Chr\obj_chr_dr_g00_usa_pmt different vertices
Chr\obj_chr_dr_gh00_pmt different vertices
Chr\obj_chr_dr_gh00_usa_pmt different vertices
Chr\obj_chr_dr_l00_pmt different vertices
Chr\obj_chr_dr_lh00_pmt different vertices
Chr\obj_chr_dr_m00_pmt different vertices
Chr\obj_chr_dr_mh00_pmt different vertices
Chr\obj_chr_fal_pmt different vertices
Chr\obj_chr_gal_pmt different vertices
Chr\obj_chr_gal_usa_pmt different vertices
Chr\obj_chr_mal_pmt different vertices
Common\obj_COURSE_OBJ_BK_PALM_pmt different vertices
Common\obj_pc_color_pmt different vertices
Common\obj_tour_pmt different vertices
Driver\obj_driver_galusa_pmt different vertices
Driver\obj_driver_gal_pmt different vertices
Driver\obj_driver_rival_pmt different vertices
OBJ\obj_end_5a_pmt different vertices
OBJ\obj_end_5b_pmt different vertices
OBJ\obj_end_5c_pmt different vertices
OBJ\obj_end_5d_pmt different vertices
OBJ\obj_end_5e_pmt different vertices
OBJ\obj_end_east_pmt different vertices
OBJ\obj_end_flor_pmt different vertices
OBJ\obj_end_maya_pmt different vertices
OBJ\obj_end_newy_pmt different vertices
OBJ\obj_end_prin_pmt different vertices
OBJ\obj_end_property_pmt different vertices
BK\ANIMS\obj_bo_ball_pmt different vertices
BK\ANIMS\obj_bo_bird_group_pmt different vertices
BK\ANIMS\obj_bo_bird_minority_pmt different vertices
BK\ANIMS\obj_bo_figh_pmt different vertices
BK\ANIMS\obj_bo_fram_pmt different vertices
BK\ANIMS\obj_bo_hang_pmt different vertices
BK\ANIMS\obj_bo_hawk_pmt different vertices
BK\ANIMS\obj_bo_jetl_pmt different vertices
BK\ANIMS\obj_bo_panz_pmt different vertices
BK\ANIMS\obj_bo_pega_pmt different vertices
BK\ANIMS\obj_bo_ship_pmt different vertices
BK\ANIMS\obj_bo_ufoo_pmt different vertices
BK\ANIMS\obj_bo_waib_pmt different vertices
BK\ENV\cs_ENVBK_SUMOEND_pmt different vertices
Stage\CAPE_R\obj_COURSE_OBJ_CS_CAPE_R_pmt different vertices
Stage\DESE_R\cs_CS_DESE_R_pmt different vertices
Stage\EAST_R\obj_COURSE_OBJ_CS_EAST_R_pmt different vertices
Stage\MAYA\cs_CS_MAYA_pmt different vertices
Stage\NEWY_R\cs_CS_NEWY_R_pmt different vertices
Stage\PALM_BR\cs_CS_PALM_BR_pmt different vertices
Stage\PALM_BR\cs_ENV_PALM_BR_pmt different vertices
Stage\PALM_BR\obj_CORS_OBJ_CS_PALM_BR_pmt different vertices
Stage\YOSE\cs_CS_YOSE_pmt different vertices
Stage\YOSE\obj_course_obj_cs_yose_pmt different vertices

Not really sure if it's worth trying to convert all of those, at least this gives an idea what to look at wrt any changes though.

Also compared poly counts between them, seems Chr\obj_chr_* characters all had poly counts reduced quite a bit, along with bunki & end anim objects:
BK\cs_LRBK_PALM_pmt different poly count
  Xbox polys: 8316 (3 objects: 2757 2779 2780 )
  PC polys: 9552 (3 objects: 3993 2779 2780 )

Cars\obj_plcar_dino_t_pmt different poly count
  Xbox polys: 4081 (17 objects: 1818 75 75 77 698 112 112 7 12 61 185 185 198 198 188 72 8 )
  PC polys: 4213 (17 objects: 1950 75 75 77 698 112 112 7 12 61 185 185 198 198 188 72 8 )

Cars\obj_rc_360sp_pmt different poly count
  Xbox polys: 1243 (24 objects: 2 390 32 34 38 7 5 41 42 54 240 20 22 26 5 24 25 149 0 2 6 5 56 18 )
  PC polys: 1248 (24 objects: 2 390 32 34 38 7 5 41 42 54 240 20 22 26 5 24 25 153 0 2 6 5 56 19 )

Cars\obj_rc_f355sp_t_pmt different poly count
  Xbox polys: 1806 (24 objects: 2 617 16 16 19 7 11 42 42 60 433 16 16 19 10 23 23 199 16 16 19 7 107 70 )
  PC polys: 1802 (24 objects: 2 617 16 16 19 7 11 42 42 60 429 16 16 19 10 23 23 199 16 16 19 7 107 70 )

Cars\obj_rc_f40_pmt different poly count
  Xbox polys: 1348 (24 objects: 2 408 32 34 36 7 16 44 44 48 257 20 22 24 16 31 31 166 0 6 8 16 60 20 )
  PC polys: 1349 (24 objects: 2 408 32 34 36 7 16 44 44 48 257 20 22 24 16 31 31 167 0 6 8 16 60 20 )

Cars\obj_rc_f40_t_pmt different poly count
  Xbox polys: 1518 (24 objects: 2 451 32 34 36 7 16 44 44 48 305 20 22 24 16 31 31 225 0 6 8 16 79 21 )
  PC polys: 1521 (24 objects: 2 451 32 34 36 7 16 44 44 48 305 20 22 24 16 31 31 227 0 6 8 16 79 22 )

Cars\obj_rc_f430_t_pmt different poly count
  Xbox polys: 1479 (24 objects: 2 560 8 8 15 6 22 23 23 54 263 8 8 15 23 23 23 191 8 4 9 14 112 57 )
  PC polys: 1480 (24 objects: 2 560 8 8 15 6 22 23 23 54 263 8 8 15 23 23 23 195 8 4 9 15 110 55 )

Cars\obj_rc_fx_pmt different poly count
  Xbox polys: 1270 (24 objects: 3 450 32 32 34 3 6 37 44 40 204 32 32 34 8 17 17 139 4 4 6 9 65 18 )
  PC polys: 1267 (24 objects: 3 450 32 32 34 3 6 37 44 40 204 32 32 34 8 17 17 139 4 4 6 9 62 18 )

Chr\obj_chr_aut04_cvt_pmt different poly count
  Xbox polys: 1359 (36 objects: 23 19 23 19 21 14 12 24 12 12 515 32 2 13 17 2 13 17 85 13 6 6 13 21 29 16 29 16 72 24 24 65 76 36 36 2 )
  PC polys: 395 (36 objects: 9 7 9 7 6 6 4 7 4 4 113 8 1 5 5 1 5 5 26 5 4 4 5 8 8 6 8 6 23 7 7 24 25 11 11 1 )

Chr\obj_chr_aut04_pmt different poly count
  Xbox polys: 1359 (36 objects: 23 19 23 19 21 14 12 24 12 12 515 32 2 13 17 2 13 17 85 13 6 6 13 21 29 16 29 16 72 24 24 77 64 36 36 2 )
  PC polys: 400 (36 objects: 9 7 9 7 6 6 4 7 4 4 115 8 1 5 5 1 5 5 26 5 4 4 5 8 8 6 8 6 23 7 7 29 23 11 11 1 )

Chr\obj_chr_dr_g00_pmt different poly count
  Xbox polys: 2259 (36 objects: 84 12 26 24 12 26 16 8 4 16 16 40 12 631 20 2 4 20 10 8 16 10 8 100 66 16 308 10 10 32 32 162 162 162 162 12 )
  PC polys: 637 (36 objects: 31 4 7 7 4 7 5 3 2 5 5 11 4 133 7 2 2 8 4 3 7 4 3 36 17 6 102 4 4 12 12 42 42 42 42 8 )

Chr\obj_chr_dr_g00_usa_pmt different poly count
  Xbox polys: 2369 (37 objects: 36 12 26 24 12 26 16 8 4 16 16 40 12 631 20 2 4 20 8 10 16 11 100 50 16 364 13 12 48 27 29 80 162 162 162 162 12 )
  PC polys: 662 (37 objects: 9 4 7 7 4 7 5 3 2 5 5 11 4 136 7 2 2 8 3 3 4 3 36 13 6 115 5 5 22 11 11 21 42 42 42 42 8 )

Chr\obj_chr_dr_gh00_pmt different poly count
  Xbox polys: 3961 (30 objects: 36 60 26 24 12 26 16 8 4 16 16 40 12 2137 90 5 21 27 20 43 104 78 446 17 17 162 162 162 162 12 )
  PC polys: 970 (30 objects: 9 26 7 7 4 7 5 3 2 5 5 11 4 438 22 3 8 8 7 11 36 23 129 7 7 42 42 42 42 8 )

Chr\obj_chr_dr_gh00_usa_pmt different poly count
  Xbox polys: 3913 (33 objects: 84 12 26 24 12 26 16 8 4 16 16 40 12 2137 48 15 8 6 11 37 6 104 60 42 403 12 34 34 162 162 162 162 12 )
  PC polys: 977 (33 objects: 31 4 7 7 4 7 5 3 2 5 5 11 4 438 14 7 3 2 5 11 2 36 19 14 126 5 12 12 42 42 42 42 8 )

Chr\obj_chr_dr_l00_pmt different poly count
  Xbox polys: 2034 (31 objects: 48 12 26 27 21 26 476 24 3 8 23 33 5 13 20 34 5 92 68 22 206 10 9 19 19 127 162 162 162 162 10 )
  PC polys: 572 (31 objects: 11 4 7 8 8 7 98 8 1 3 10 10 3 4 9 10 3 30 26 8 64 4 4 6 6 47 42 42 42 42 5 )

Chr\obj_chr_dr_lh00_pmt different poly count
  Xbox polys: 3755 (28 objects: 48 12 26 27 21 26 2120 40 23 33 5 20 34 5 106 68 40 259 10 9 19 19 127 162 162 162 162 10 )
  PC polys: 933 (28 objects: 11 4 7 8 8 7 442 14 10 10 3 9 10 3 36 26 14 71 4 4 6 6 47 42 42 42 42 5 )

Chr\obj_chr_dr_m00_pmt different poly count
  Xbox polys: 1787 (26 objects: 37 24 32 37 24 32 737 30 34 37 22 32 34 27 60 32 66 56 12 12 37 37 84 84 84 84 )
  PC polys: 627 (26 objects: 12 7 9 12 7 9 332 10 12 12 6 11 11 7 13 10 19 16 6 6 10 10 20 20 20 20 )

Chr\obj_chr_dr_mh00_pmt different poly count
  Xbox polys: 3220 (27 objects: 37 24 32 37 24 32 1841 37 38 32 23 27 34 27 60 32 24 37 388 12 12 37 37 84 84 84 84 )
  PC polys: 926 (27 objects: 12 7 9 12 7 9 402 13 13 11 6 10 11 7 13 10 10 12 240 6 6 10 10 20 20 20 20 )

Chr\obj_chr_fal_pmt different poly count
  Xbox polys: 41853 (109 objects: 246 21 36 246 21 36 40 4 24 16 8 8 8 8 12 4 4 12 8 12 4 7 12 8 45 45 497 40 12 4 90 54 84 8 12 4 90 54 84 8 8 8 166 54 30 2 48 2 222 54 5 84 50 2 2 112 22 13 111 24 47 55 80 108 294 55 55 14 14 14 14 77 64 2 2 217 217 64 64<PHONE_NUMBER> 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 1566 2393 1156<PHONE_NUMBER> 816 580 580 580 580 )
  PC polys: 9222 (109 objects: 69 7 16 69 7 16 19 2 10 8 4 5 4 4 5 2 2 5 4 5 2 4 5 4 12 12 125 14 4 2 20 17 23 3 4 2 20 17 23 3 4 4 76 18 12 1 16 1 63 24 2 29 18 1 1 29 7 7 26 8 20 22 28 29 73 18 18 4 6 4 6 18 15 1 1 66 65 17 17 42 42 314 314 314 314 314 314 314 314 314 314 314 314 314 314 314 314 314 314 682 255 111 111 258 199 129 129 129 129 )

Chr\obj_chr_gal_pmt different poly count
  Xbox polys: 37198 (117 objects: 318 28 319 26 2 43 95 2 1 83 2 107 41 14 22 10 3 28 7 4 50 8 45 2 13 8 59 39 13 15 95 12 17 12 11 5 16 8 20 7 4 13 56 4 4 13 56 4 819 44 24 60 54 42 21 2 66 4 40 44 24 1 2 2 336 87 87 132 54 47 47 22 224 107 91 377 20 17 28 16 28 16 185 181 3 224 8<PHONE_NUMBER> 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 502 502 816 580 580 580 580 580 )
  PC polys: 8047 (117 objects: 84 10 85 10 1 25 40 1 1 39 2 41 24 5 7 3 2 9 2 2 16 3 19 1 5 3 20 13 5 6 27 4 7 5 4 2 5 3 6 3 2 6 13 2 2 6 13 2 216 18 7 18 13 16 9 1 20 2 11 15 9 1 1 1 100 27 27 42 16 17 17 8 53 39 26 118 7 6 11 6 11 6 68 67 1 52 4 19 19 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 111 111 199 129 129 129 129 129 )

Chr\obj_chr_gal_usa_pmt different poly count
  Xbox polys: 34386 (105 objects: 324 26 319 26 2 7 109 2 42 37 22 111 41 25 11 7 22 6 10 18 108 23 125 5 22 16 8 16 8 11 13 7 8 4 2 4 8 4 838 66 61 6 39 40 3 47 13 46 40 3 345 88 4 81 134 54 78 7 16 72 16 8 180 79 89 481 12 12 28 16 28 16 195 195 3 224 8<PHONE_NUMBER> 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 1346 502 502 816 580 580 580 580 580 )
  PC polys: 7429 (105 objects: 86 10 85 10 1 4 42 1 20 17 11 42 23 7 5 3 6 2 3 7 29 9 31 2 6 5 3 5 3 5 5 3 4 2 1 2 4 2 216 21 17 3 13 11 1 15 5 14 11 2 107 26 2 25 35 16 22 3 7 19 7 4 47 25 30 140 5 5 11 6 11 6 70 70 1 52 4 19 19 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 263 111 111 199 129 129 129 129 129 )

Chr\obj_chr_mal_pmt different poly count
  Xbox polys: 51017 (112 objects: 169 16 58 169 16 58 1 6 1 2 8 11 4 2 5 1 3 1 6 1 1 40 1 40 590 106 37 36 20 45 22 37 36 20 45 22 35 35 14 51 3 53 3 396 18 40 21 6 18 6 14 26 82 157 697 42 45 14 32 14 32 103 103 61 61 64 64 1 1<PHONE_NUMBER> 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 1369 604 604 604 604 604 604 604 604 771 771 771 604 604 )
  PC polys: 11272 (112 objects: 44 6 17 44 6 17 1 4 1 1 4 6 2 1 3 1 2 1 3 1 1 11 1 11 160 34 10 10 8 13 7 10 10 8 13 7 9 9 7 17 1 17 1 235 7 16 7 4 6 4 5 9 23 39 353 13 15 4 9 4 9 25 25 15 15 19 19 1 1 32 36 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 273 152 152 152 152 152 152 152 152 206 206 206 152 152 )

Common\obj_pc_color_pmt different poly count
  Xbox polys: 200 (2 objects: 8 192 )
  PC polys: 36 (2 objects: 4 32 )

Common\obj_tour_pmt different poly count
  Xbox polys: 521 (17 objects: 98 40 18 13 26 7 6 1 1 1 1 1 153 84 43 10 18 )
  PC polys: 589 (17 objects: 98 40 18 13 26 75 6 1 1 1 1 1 153 84 43 10 18 )

Driver\obj_driver_galusa_pmt different poly count
  Xbox polys: 1332 (3 objects: 584 500 248 )
  PC polys: 340 (3 objects: 146 127 67 )

Driver\obj_driver_gal_pmt different poly count
  Xbox polys: 1332 (3 objects: 584 500 248 )
  PC polys: 337 (3 objects: 144 126 67 )

Driver\obj_driver_rival_pmt different poly count
  Xbox polys: 2837 (13 objects: 102 2 617 490 254 625 489 218 12 10 6 6 6 )
  PC polys: 775 (13 objects: 1 157 134 75 161 134 55 30 8 5 5 5 5 )

OBJ\obj_end_5a_pmt different poly count
  Xbox polys: 12035 (1 objects: 12035 )
  PC polys: 8281 (1 objects: 8281 )

OBJ\obj_end_5b_pmt different poly count
  Xbox polys: 17996 (1 objects: 17996 )
  PC polys: 9916 (1 objects: 9916 )

OBJ\obj_end_5c_pmt different poly count
  Xbox polys: 9471 (1 objects: 9471 )
  PC polys: 4343 (1 objects: 4343 )

OBJ\obj_end_5d_pmt different poly count
  Xbox polys: 6051 (1 objects: 6051 )
  PC polys: 3544 (1 objects: 3544 )

OBJ\obj_end_5e_pmt different poly count
  Xbox polys: 10384 (1 objects: 10384 )
  PC polys: 7653 (1 objects: 7653 )

OBJ\obj_end_east_pmt different poly count
  Xbox polys: 15149 (1 objects: 15149 )
  PC polys: 10105 (1 objects: 10105 )

OBJ\obj_end_flor_pmt different poly count
  Xbox polys: 11271 (1 objects: 11271 )
  PC polys: 3924 (1 objects: 3924 )

OBJ\obj_end_maya_pmt different poly count
  Xbox polys: 24519 (1 objects: 24519 )
  PC polys: 15224 (1 objects: 15224 )

OBJ\obj_end_newy_pmt different poly count
  Xbox polys: 33477 (1 objects: 33477 )
  PC polys: 16611 (1 objects: 16611 )

OBJ\obj_end_prin_pmt different poly count
  Xbox polys: 10824 (1 objects: 10824 )
  PC polys: 5281 (1 objects: 5281 )

OBJ\obj_end_property_pmt different poly count
  Xbox polys: 9007 (29 objects: 2337 124 126 126 183 126 126 126 132 576 2 12 2 312 15 768 42 1512<PHONE_NUMBER> 2 2 2 2 2 2 16 20 )
  PC polys: 3009 (29 objects: 605 55 50 52 80 52 52 52 60 126 1 6 1 64 18 293 18 275 375 374 355 1 1 1 1 1 1 19 20 )

BK\ANIMS\obj_bo_ball_pmt different poly count
  Xbox polys: 2041 (1 objects: 2041 )
  PC polys: 551 (1 objects: 551 )

BK\ANIMS\obj_bo_bird_group_pmt different poly count
  Xbox polys: 288 (3 objects: 96 96 96 )
  PC polys: 69 (3 objects: 23 23 23 )

BK\ANIMS\obj_bo_bird_minority_pmt different poly count
  Xbox polys: 96 (1 objects: 96 )
  PC polys: 23 (1 objects: 23 )

BK\ANIMS\obj_bo_figh_pmt different poly count
  Xbox polys: 2977 (1 objects: 2977 )
  PC polys: 280 (1 objects: 280 )

BK\ANIMS\obj_bo_fram_pmt different poly count
  Xbox polys: 234 (1 objects: 234 )
  PC polys: 49 (1 objects: 49 )

BK\ANIMS\obj_bo_hang_pmt different poly count
  Xbox polys: 1512 (3 objects: 504 504 504 )
  PC polys: 423 (3 objects: 142 141 140 )

BK\ANIMS\obj_bo_hawk_pmt different poly count
  Xbox polys: 2886 (3 objects: 962 962 962 )
  PC polys: 504 (3 objects: 168 168 168 )

BK\ANIMS\obj_bo_jetl_pmt different poly count
  Xbox polys: 2000 (2 objects: 1000 1000 )
  PC polys: 670 (2 objects: 335 335 )

BK\ANIMS\obj_bo_panz_pmt different poly count
  Xbox polys: 3170 (1 objects: 3170 )
  PC polys: 510 (1 objects: 510 )

BK\ANIMS\obj_bo_pega_pmt different poly count
  Xbox polys: 2258 (2 objects: 1129 1129 )
  PC polys: 548 (2 objects: 274 274 )

BK\ANIMS\obj_bo_prop_pmt different poly count
  Xbox polys: 1850 (2 objects: 925 925 )
  PC polys: 502 (2 objects: 251 251 )

BK\ANIMS\obj_bo_ship_pmt different poly count
  Xbox polys: 543 (1 objects: 543 )
  PC polys: 143 (1 objects: 143 )

BK\ANIMS\obj_bo_ufoo_pmt different poly count
  Xbox polys: 840 (1 objects: 840 )
  PC polys: 264 (1 objects: 264 )

BK\ANIMS\obj_bo_waib_pmt different poly count
  Xbox polys: 2967 (1 objects: 2967 )
  PC polys: 476 (1 objects: 476 )

Stage\ALPI_R\cs_CS_ALPI_R_pmt different poly count
  Xbox polys: 37733 (7 objects: 3405 2889 6547 8527 1997 770 13598 )
  PC polys: 37762 (7 objects: 3405 2918 6547 8527 1997 770 13598 )

Stage\CLOU_R\cs_CS_CLOU_R_pmt different poly count
  Xbox polys: 41199 (8 objects: 3387 1481 80 255 9379 142 22769 3706 )
  PC polys: 40747 (8 objects: 3383 1451 80 255 9379 142 22769 3288 )

Stage\DESE_R\cs_CS_DESE_R_pmt different poly count
  Xbox polys: 39336 (8 objects: 3290 2167 7866 192 6423 9606 113 9679 )
  PC polys: 39376 (8 objects: 3290 2167 7866 192 6463 9606 113 9679 )

Stage\LAKE\obj_course_obj_sky_lake_pmt different poly count
  Xbox polys: 530 (3 objects: 180 70 280 )
  PC polys: 176 (3 objects: 70 36 70 )

Stage\LAKE_R\cs_CS_LAKE_R_pmt different poly count
  Xbox polys: 38946 (10 objects: 15862 1441 7211 4710<PHONE_NUMBER> 1058 4000 2042 )
  PC polys: 38952 (10 objects: 15862 1441 7217 4710<PHONE_NUMBER> 1058 4000 2042 )

Stage\LASV\cs_CS_LASV_pmt different poly count
  Xbox polys: 39135 (8 objects: 4194 9423 311 24421 170 12 603 1 )
  PC polys: 37245 (8 objects: 4194 7533 311 24421 170 12 603 1 )

Stage\LASV_R\cs_CS_LASV_R_pmt different poly count
  Xbox polys: 38892 (8 objects: 3907 8836 319 25011 203 12 603 1 )
  PC polys: 39185 (8 objects: 4200 8836 319 25011 203 12 603 1 )

Stage\PRIN_R\cs_CS_PRIN_R_pmt different poly count
  Xbox polys: 23762 (11 objects: 2039 3608 1640 1844 9986 80 370 1957 1485 1 752 )
  PC polys: 23763 (11 objects: 2040 3608 1640 1844 9986 80 370 1957 1485 1 752 )

Stage\SEQU_R\cs_ENV_SEQU_R_pmt different poly count
  Xbox polys: 2771 (4 objects: 1449 591 671 60 )
  PC polys: 2790 (4 objects: 1449 591 671 79 )

Stage\YOSE\cs_CS_YOSE_pmt different poly count
  Xbox polys: 23132 (7 objects: 3383 2888 13319 1255 365 1644 278 )
  PC polys: 23134 (7 objects: 3383 2888 13319 1255 367 1644 278 )

Stage\YOSE_R\cs_CS_YOSE_R_pmt different poly count
  Xbox polys: 23432 (7 objects: 3376 2827 13035 1735 514 1670 275 )
  PC polys: 23572 (7 objects: 3376 2967 13035 1735 514 1670 275 )

Maybe worth converting one of the characters some time and see if there's any noticeable difference with it.

Also discovered an odd issue, some models include primitives which are primitive_type = 8, but D3D9 primitive types only go up to type 6.
Looks like type 8 was some kind of xbox extension D3DPT_QUADLIST, doesn't look like D3D9 includes any support for that.
Need to check if game is actually trying to send type 8 to D3D9 or maybe it has some conversion stuff built in, if it doesn't maybe this could explain some of the missing gfx like the reverse jungle water

Ice Scape Skybox is also very noticable, not sure yet how it looked in other releases though:

This one is especially bad:

Wow, I never noticed that second one. An entire section of the sky is just gone.

Metropolis tunnel also had a big skybox issue, not sure how repeatable it is since I just now saw it online. I also forgot I was even using your WIP skybox fix until I saw it lol. I'll try to get a screenshot next time.

Hmm, don't think the skybox was any different in Xbox C2C like the deep lake skybox was, if there's any other release that doesn't have it broken maybe can look into porting those too.
(or we could just do a tulip swap there, if there's no water reflection for the upper skybox to leak into that would probably work fine)

I noticed the missing graphics in the Ice stage too. Seems to be a black void in the far background at the second half of the stage.
This issue is exclusive to the PC version. I tested the original arcade, PSP, PS2 and XBOX versions and none have this black void.

I think the ice stage issue might be the same thing that happens on palm beach, where ocean texture has a void missing until you get close enough.
Seems the draw-distance stuff doesn't affect that (even though that was one of the main things I coded draw-dist for >.<), not really sure what's up with it yet, guess the animated textures might be handled differently.

Might have found cause for the sunny beach issue, the game is doing a QuickSort on all the alpha drawables in the frame, before the quicksort the water alpha & the reflection alpha are in the right order to display fine, but after sorting it puts the reflection above it for some reason, causing that black area to show on the water.
Removing the quicksort can fix that but I'd guess it could end up breaking other alpha stuff in the game (though if sunny beach doesn't have any other issue with it maybe we could just only skip it during that stage...)
Oddly Lindbergh & xbox both seem to use the exact same quicksort code but aren't affected by the ordering issue, it might be related to the same thing that FixZBufferPrecision is working around (another issue that only happens on PC), but not completely sure.


ENH: Add TaskName metadata to BOLD outputs

Changes proposed in this pull request
Add "TaskName" metadata to BOLD outputs.
Closes #1713.

Double checking the artifacts now. Will merge when done


[T2A4][C03-02]Teh Chee Yeo

Made code smellier

@cheo1994
This PR should be against nus-cs2103-AY1617S1 :-)
Closing...


The inspector crashes trying to look at a DuckDB HISTOGRAM

---
sql:
  gaia: ./lib/gaia-sample.parquet
---

```js echo
(await sql`SELECT HISTOGRAM(phot_g_mean_mag) FROM gaia`)[0]
```

Filed https://github.com/apache/arrow/issues/40407.
PR https://github.com/apache/arrow/pull/40408.


Hyper not observing system's login shell

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: macOS Sierra 10.12.6

Hyper.app version: 1.3.3

Link of a Gist with the contents of your .hyper.js: https://gist.github.com/tjfwalker/b0f98c0bb927c5fd3a73349dac67e6e3

Issue

You are right. We need to update the current session shell!


Feat/explain declarative ddl

Related Issue(s) & Descriptions

Checklist

[ ] Tests were added or are not required
[ ] Documentation was added or is not required

Don't forget to update the docs


Message when trying to scan  - unable to get local issuer certificate

i have run snyk auth -d and attached details
snykMsg.txt
Can anyone advise as this is very new to me.

Hi @LibbyYoung !
It looks like this issue is not specific to the VS plugin, but rather an issue with the Snyk CLI in general.
This error is usually due to having self-signed certificate in your certificate chain.
If you understand the implications, you can try to use the --insecure flag as explained here.
If you're using the VS plugin you can check the Ignore Unknown CA option in the settings to get the same effect.
Regards,
Asaf


ObjectInitializerCodeFixProvider crashes

Hi.
When I wanted to resolve aprox. 60 Warnings via BatchFixAllProvider of CC0008, I encountered crash.
So I started to make it manually and I found one, that is crashing ObjectInitializerCodeFixProvider and I think that was a reason for BatchFixAllProvider crashes.
Here is the snippet:
var quitButton = new GButton( 0x7D9, 0x7DB, 0x7DA, 18, 445, new OnClick( FinalGumps.Quit_OnClick ) );
quitButton.Tooltip = new Tooltip( ClientLocalization.GetString( "#57#Ukončit Ultimu Online" ) );

Hope it helps to solve these crashes, regards.

Bug confirm, I will work on it.

Fix confirmed on our codebase via alpha-nuget package.

Awesome! :D


what "spatial dimensions" means?

Hi, Miguel:
I have a simple problem. I see that in your code that spatial dimensions=2. I want to know what does spatial dimension refers to? can you please explain to me?
Best wishes!
Hao

Hello,
It means 2D or 3D.
Best,
Miguel


Ilogger traces are prefixed with il. Update to stable 2.8 of base and…

… web. Bump version
Fix Issue # .

[ ] I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

[ ] Changes in public surface reviewed

[ ] Design discussion issue #

[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue.

[ ] The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)

Please follow [these] (https://github.com/Microsoft/ApplicationInsights-aspnetcore/blob/develop/Readme.md) instructions to build and test locally.

Merge after 2.8.0 is in myget.

prefixes updated here: https://github.com/Microsoft/ApplicationInsights-Home/pull/269 👍


[Udacity course l06] Fixed wrong example object usage and format_imag…

In the Udacity "Intro to TensorFlow" course, lesson 6 Colab, found a number of bugs in the data preprocessing section, specifically when accessing the training set's elements.

Hi,
These changes bump the code out of sync with the text, and seem to ignore that the datasets are returning tuples, not dicts.
The "def format_image(data):" change looks right, but the others are not. If you make a new PR with just that change I would accept it.


Bump golang.org/x/crypto from 0.25.0 to 0.31.0

Bumps golang.org/x/crypto from 0.25.0 to 0.31.0.

Commits

updated-dependencies:

dependency-name: golang.org/x/crypto dependency-type: direct:production ...

This PR fixes #154 by updating crypto to the latest version (which is not affected by the CVE)

Handled by dependabot


Not able list pgvector-cpp in windows

Hello,
I am new to vector but old to postgres.
Is there any tutorial steps to install pgvector-cpp on windows and some sample cpp file to do vector search
Any lead is helpful

Hi @temporarypassword, I'm not aware of any tutorials. The test file might be helpful. In general, I'd recommend getting libpqxx working without pgvector, then following the instructions in the readme (if you run into the error from #3, use master instead of v0.1.1 when cloning). You could also copy the headers directly into your project if you don't want to install it globally.


Prep for DIGITAL-1129

https://jirautk.atlassian.net/browse/DIGITAL-1129 (related)
What Does This Do
Restructures  ./src/components and adds new components that will be extended.
Anything Else You Should Know
Just take a look and make sure that the build does not destroy the layout of an object on the netlify deploy preview.

Thanks @markpbaggett


Recording of Registration Districts

In FreeCEN Registration Districts are included in piece names. The rule is that there should be no punctuation (e.g. full stops. St not St.)
In FreeBMD full stops are permitted in the Registration district. This is stopping entry matching when the entry is keyed for a second time, despite the entries being otherwise identical.
This will cause a matching issue if, as and when one search searches all of the data held by FreeUKGen.
We therefore need a consistent set of rules for the entry of data where the systems have fields containing data that records the same thing.
This will need to be considered during future development. With the development of FreeBMD2 maybe this is a good time to consider it.
Geoff

@richardofsussex might be interested in this...


[BUG][Functional] File copy mechanism broken in v1.2.4+

Required Basic Info

Accelerator Version:  v1.2.4 and master branch
Install Type: Upgrade

Describe the bug
Issue1:

customer provided "override" / replacement files are not being copied from customer bucket to the the deployment bucket
customer ability to overwrite repo default files appears to have been dropped/changed
customer scp overrides are ignored and latest version from the repo are used after upgrade

Issue2:

Deleting a file from the root Phase0 config bucket (tested with scp folder file(s)), file(s) are not recopied from repo defaults
state machine fails with missing files

Failure Info

1: wrong version of config files/scps are being deployed
2: no config files available for deployment

Steps To Reproduce

Customer bucket to contain an scp file with a date older than new release files.  ASEA uses repo version, not customer version
delete files from phase0 bucket, old version persists

Expected behavior

proper file is deployed
For the customer bucket, I believe we are doing a file date check and only copying newer files, whereas we always want to use the customer version
For the config bucket - no idea why the files are failing to update

Thought the process was, in this order

Copy files from repo to config0 bucket, overwrite if exists (each execution)
Copy files from customer bucket to config0 bucket, overwrite if exists (each execution)
this allows customers to remove their custom config files and default to the standard repo versions
this allows customers to always leverage their custom config files, if supplied (no matter when they created them)
The timestamp on each file is irrelevant

after upgrade customer supplied file would always be an older timestamp
if customer updated an scp, it would have a newer timestamp, when deleted from customer folder it would never be overwritten
disadvantage:  we update the config files on every SM execution, but, they are very small/few

Additional context

Broken for customer after upgrade from v1.2.3 to v1.2.4 and in master branch
Did we change anything related to file copy, or only CDK version change?

After further testing this does not appear to be a codebase issue.  Will work with TAM to determine customer issue.  Closing ticket, will re-open if it turns out to be a codebase issue

After further testing this does not appear to be a codebase issue.  Will work with TAM to determine customer issue.  Closing ticket, will re-open if it turns out to be a codebase issue

General:

customer bucket always remains unmodified/untouched
we then copy files into our config bucket, with the final versions used to determine the deployed configuration

Current behavior:

Copy Customer bucket files only if each is the newest timestamp (on every SM execution), then
Copy repo files, overwriting existing files and deleting extra files (on new install/upgrades/Lid change)
Completely wrong outcome, as customer could easily supply extra files, also customer files should always win

Needed Behavior:

Copy repo files, overwriting existing files and deleting extra files (on new install/upgrades/Lid change)
Copy Customer bucket files regardless of timestamp (every execution), then

Thought:

this behavior means customers (maybe more restrictive) guardrails are not ignored during upgrades
this means customers could fail to receive latest updates to secondary config files during upgrades, if they updated them, which could cause state machine to fail - added new manual step to upgrade documentation
the risks of the first outweigh the second

Shipping in v1.2.5


Add Hash Table to structures and functional

Add the function hash_table(keys: Tensor, values: Tensor) -> Tensor to the functional module and the class HashTable to the structures module.

[x] F.hash_table(keys, values)
[x] S.HashTable(dim)
[x] S.HashTable().from_tensors(keys, values)
[x] HashTable[key] -> value
[ ] HashTable[key] = value -> value
[x] HashTable.get(key) -> value
[x] HashTable.add(key, value)
[ ] HashTable.set(key, value)
[x] HashTable.remove(key)
[ ] del HashTable[key]

Remaining tasks are not performed because they require access to the exact value in order not to introduce noise. The desired behavior can be achieved with the implemented functions.


intergration not working with new beta

I agree to the following

[X] I have read the documentation right now
[X] I have read the FAQs right now
[X] I am aware of the latest release notes
[X] The Backend (CCU/Homegear/...) is working as expected and connected devices are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
the intergration its not working with beta
What version of HomematicIP (local) has the issue?
1.49.0
What was the last working version of HomematicIP (local)?
1.49.0
What type of installation are you running?
Home Assistant OS
What type of installation are you running for your homematic backend?
CCU2
Which version of your homematic backend are you running?
No response
What hardware are you running for your system?
No response
Which config details do you use

[X] Username and password
[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[X] Homematic IP
[X] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information
No response
Anything in the logs that might be useful for us? The log (full log) is the best source to support trouble shooting!
No response
Additional information
No response

its working now with 1.52.0


[Component Request] - Sidebar

@yannickholzenkamp  & @Gagne87 Could we use the sidebar from the portal to add into the Design System?

 Sidebar


First try at month/year menus

what do you think?

Can you include a screenshot and/or a link to a demo page?

Sure. Here are some.

What happens if you select a month/year that falls outside of the selectable range?

It displays the calendar but the days are grayed out. You cannot select them.

This, of course, is not ready to be merged as all tests have failed. I do not have experience using the test tools so I did not check before doing the pull request.
Feel free to delete this pull request. Just wanted to do a "proof of concept" and show you.

It seems like if you can navigate to a useless month, there should be an easy way to jump back to the closest month with selectable days. Alternatively, based on the "year" setting, months with no selectable days should not be selectable.

Will get to it. Thanks for the help.

How is this coming along? We could really use this feature in our current project.

Any progress in this feature ?

This particular implementation is going to be really hard to resolve with the structural changes that have been included in react-dates since this PR was opened. I'm going to be investigating this conceptually pretty soon tho and trying to push something through the door.


update code snippets

🚀 Deployed on https://62a8eff469ffc8114c8ae243--cozy-fox-0defec.netlify.app


Systray icon is invisible (Windows 10)

The Syscoin icon is invisible in my Windows system tray. Syscoin does occupy a slot; you can right-click on it to open the context menu. The icon is visible on the wallet's title bar and in Windows Explorer. But when you minimize the wallet to the system tray, it's easy to forget that Syscoin is running. That's a security risk.

By the way, if the icon was displayed, it would still be hard to notice against a dark background.
Release: 2.1.4
Build: Syscoin Core version v<IP_ADDRESS>-71e929b (64-bit)
Operating system: 64-bit Windows 10 Pro Creators Update

Update: tested in Windows 7; systray icon was visible there.

Some other icons are missing too:
send tab / end of 'Pay to:' line all three icons not showing
Shouldn't the wallet show the HD / nonHD , connections and synced icons in the lower right corner?


Listhostsmetric cpuallocated >100%

ISSUE TYPE

Bug Report

COMPONENT NAME

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

When listhostsmetric calculates cpualocated and cpualocatedghz, it does not set the cpu.overprovisioning.factor The coefficient is included, resulting in cpualocated > 100%
capabilities: "hvm,snapshot"
clusterid: "2c95571e-5cf9-4ff8-b09a-750a517d6dc4"
clustername: "cl01"
clustertype: "CloudManaged"
cpuallocated: "113.84%"
cpuallocateddisablethreshold: false
cpuallocatedghz: "76.50 Ghz"
cpuallocatedthreshold: false
cpudisablethreshold: false
cpuloadaverage: 3.93
cpumodelname: "Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz"
cpunumber: 32
cpusockets: 2
cpuspeed: 2100
cputhreshold: false
cputotalghz: "67.20 Ghz (x 4.0)"
cpuused: "7.66%"
cpuusedghz: "5.15 Ghz"
cpuwithoverprovisioning: "268800"
created: "2021-03-04T18:36:38+0800"
STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

@div8cn In listHosts API response, we get two different values cpuallocated with and without operprovisioning applied.
(localcloud) SBCM5> > list hosts id=4937aa4f-6f27-4dc8-af70-2335279edf27
{
  "count": 1,
  "host": [
    {
      "capabilities": "hvm,snapshot",
      "clusterid": "881c01ec-7a4b-4c55-af5c-d53de5880b5e",
      "clustername": "p1-c1",
      "clustertype": "CloudManaged",
      "cpuallocated": "7.09%",
      "cpuallocatedpercentage": "7.09%",
      "cpuallocatedvalue": 500,
      "cpuallocatedwithoverprovisioning": "3.55%",
      "cpuloadaverage": 0.09,
      "cpunumber": 3,
      "cpusockets": 3,
      "cpuspeed": 2350,
      "cpuused": "2.09%",
      "cpuwithoverprovisioning": "14100",
      "created": "2021-03-03T06:09:26+0000",
      "details": {
        "Host.OS": "CentOS",
        "Host.OS.Kernel.Version": "3.10.0-957.12.2.el7.x86_64",
        "Host.OS.Version": "7.6.1810",
        "com.cloud.network.Networks.RouterPrivateIpStrategy": "HostLocal",
        "secured": "true"
      },
      "events": "PingTimeout; AgentDisconnected; StartAgentRebalance; AgentConnected; ShutdownRequested; Ping; ManagementServerDown; HostDown; Remove",
      "hahost": false,
      "hostha": {
        "haenable": false,
        "hastate": "Disabled"
      },
      "hosttags": "test,ha",
      "hypervisor": "KVM",
      "id": "4937aa4f-6f27-4dc8-af70-2335279edf27",
      "ipaddress": "<IP_ADDRESS>",
      "islocalstorageactive": false,
      "lastpinged": "1970-01-19T06:13:21+0000",
      "managementserverid": "2bb26158-495c-472e-865f-d24205d2befc",
      "memoryallocated": 268435456,
      "memoryallocatedbytes": 268435456,
      "memoryallocatedpercentage": "3.69%",
      "memorytotal":<PHONE_NUMBER>,
      "memoryused": 396492800,
      "memorywithoverprovisioning": "7277121536",
      "name": "pr4710-t3640-kvm-centos7-kvm1",
      "networkkbsread": 1131042,
      "networkkbswrite": 1,
      "outofbandmanagement": {
        "enabled": false,
        "powerstate": "Disabled"
      },
      "podid": "496029eb-411a-4736-954d-73d5a8d15e56",
      "podname": "Pod1",
      "resourcestate": "Enabled",
      "state": "Up",
      "type": "Routing",
      "ueficapability": false,
      "version": "<IP_ADDRESS>-SNAPSHOT",
      "zoneid": "3f4d015c-7d6b-4b5e-86b0-79552910f77b",
      "zonename": "pr4710-t3640-kvm-centos7"
    }
  ]
}

I've created PR #4795 to enable this in listHostsMetrics response as well. Should this be done for memory allocated as well?
@rhtyd @DaanHoogland @weizhouapache thoughts?

+1 for getting listHosts as a subset of listHostsMetrics

agree, just make sure you don't change the semantics or format of any key causing backwards incompatibilities (unless the current filling of a value is obviously a bug, but even than,...)

Fixed in https://github.com/apache/cloudstack/pull/4795


feat: design review polish

The following items have been changes:

[x]  background images in hero and footer have been replaced with larger images spanning the full screen width at larger breakpoints
[x]  “Register” button text is centered
[x]  Storage provider benefits section subtext changed to 1.25 rem and line height changed to 1.7 rem
[x]  Same adjustments to the Moonlanding capsule section font size and line height as well as image size adjusted to be 20% smaller
[x]  Spacing above and below moonlanding capsule section reduced
[x]  Resources CTA underline is always visible and redraws on hover

Ticket:
https://www.notion.so/agencyundone/Implement-Moonlanding-design-review-changes-4096c317802d451dafc84a8b819e85ec?pvs=4

@svvimming change requests based on Em seeing the above PR -

[ ] Can we add the same draw effect that is on 'View All Resources' to nav items (Register, Learn More) on hover ?

[ ] section intro_1 - the 2 columns that we have the text divided into are not equal in size so the way the description text wraps looks off - can we even them out and make these 2 equal in size? I've got screenshots to show what we mean but please feel free to let me know if this is unclear!

hey @svvimming sorry to bug you on this but i had a chance to look on my actual mobile device since the build preview is working -
the /resources page nav is kind of cut off here -

also - the resources item in the footer is sitting on top of the moon image which actually makes it kind of hard to see - can we shift that so the grey text isn't right on top of a grey planet image?


Create seperate host & user cars for more fine grained control

This splits up context a bit. The original context car is still in place. It adds a host and user context so the user can optionally define just a user or host to be displayed how they want, with optional symbols of course.

Hey @gregf ,
we should discuss this. So is your idea here to just be able to format the output better, like should only one of the components be displayed OR you also want to be able to move the info around separately?
If you want to be able to move the user and host infos around separately then I see a good point in this PR. If you only wish to turn on/off the text inside, some more env vars are suitable IMHO.
Let me know what was your intention as I don't want to keep redundant cars around.

Hmm, Both? I think being able to display just one piece of info and move it around would be good. I looked at other bars before implementing this and this setup seems to be standard in most of them. I was originally going to just add a few env vars to handle this, but after looking to see what that would take this seemed like the better solution to me.

Sorry I should have been more clear. Context should stay. What if you want user@hostname displayed all in one block. You still need context.

I for one most certainly don't need 3 cars with overlapping functionalities. If someone misses the context car, then can add it later as a superlightweight plugin because it's just dead simple text :)

Fair enough, I'll remove it shortly.

@gregf here is a reminder 🏓 4 U 👋 no 🏃

Think this is ready to roll now if you want to look over it? Sorry, it took me so long, just been busy.


Home-rolled "is Component?" test is throwing false negatives for React 16.3.0 features

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Overview
React 16.3 will include a utility for ref forwarding called React.forwardRef. Its RFC has been ratified and the initial implementation is available in alpha builds of 16.3.
The typeof objects returned by forwardRef happens to be "object", not "function", which means that if you wrap your Page component in a HOC that uses forwardRef, it will fail the overly-aggressive test here.
Expected Behavior
If I wrap a top-level Page component with React.forwardRef, I expect Next.js to render it without issue.
Current Behavior
If I wrap a top-level Page component with React.forwardRef, Next.js throws the following error:
Error: The default export is not a React Component in page: ...

Steps to Reproduce (for bugs)
For any Page component in a Next.js app, add the following lines:
// ...
const MyPage = () => (...);
export default React.forwardRef((props, ref) => <MyPage {...props} forwardedRef={ref} />);

Context
As soon as the forwardRef API is released, library that expose HOCs are going to start using it to provide a standard way of accessing the ref of the wrapped component. (Prior to this, each HOC library would take a slightly different approach.)
As more libraries and apps are updated, the number of people impacted will grow. I expect this to happen fairly rapidly, at least for actively-maintained libraries.
Your Environment

Tech
Version

next
5.0.1-canary.17

I'm also experiencing this, using Next.js v6.1.1.
Based on https://github.com/facebook/react/issues/12453, it sounds like the way forward is to replace the current check with ReactIs.isValidElementType(Component): https://github.com/facebook/react/tree/v16.4.2/packages/react-is#determining-if-a-component-is-valid
I'm trying this out now and it appears to work well. Pull request coming.

Pull request is here: #5095
FWIW, I found this issue using react-cookie, using this workaround in the meantime:
// pages/index.js

const AppWithCookies = withCookies(App);
export default () => <AppWithCookies />;

// compared to this, which produces an error:
// export default withCookies(App);

https://github.com/zeit/next.js/pull/5095 implement pretty much all that is needed for this to work, it had some merge conflicts however. So if someone wants to take on this issue feel free to 🙏


Misalignment in GHS layer

When calibrating the urban / rural split, we extract the GHS information into the dataframe with the raster_to_dataframe method. This is causing reading of some NaNs in the borders of the layer.

This is apparently a problem that happens when reprojecting layers in the data processing step.


[GHSA-6qq8-5wq3-86rp] Traefik vulnerable to Open Redirect via handling of X-Forwarded-Prefix header

Updates

Affected products

Hi there @emilevauge! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Hi @avivdolev,
Thanks for submitting your community contribution. The very short version is that we can include the API links, but Traefik presents some unique challenges that lead us to include information that is important for completeness but initially appears duplicative.
When advisory curators review an advisory for a Go package, we look for package names that correspond to packages in pkg.go.dev. Although github.com/containous/traefik is no longer used on GitHub, it's still part of valid packages on pkg.go.dev and people still map their dependencies to packages that contain containous/traefik. We specifically ensure we mention packages with both names because the containous/traefik packages cover different version ranges than the traefik/traefik packages, and people using versions of the package that are vulnerable to CVE-2020-15129 are likely to be using the versions with the older name.
Here are the pkg.go.dev links that correspond to the packages currently listed:

https://pkg.go.dev/github.com/traefik/traefik (which covers v1.0.0-beta.211 to v1.7.34)
https://pkg.go.dev/github.com/traefik/traefik/v2 (which covers v2.3.0-rc6 to v2.8.1)
https://pkg.go.dev/github.com/containous/traefik (which covers v1.0.0-beta.211 to v1.7.28)
https://pkg.go.dev/github.com/containous/traefik/v2 (which covers v2.0.0-rc1 to v2.3.0-rc5)

I think including the API links is also fine, with a caveat that pkg.go.dev doesn't show me anything with the v2 versions of the API links. I find active packages at:

https://pkg.go.dev/github.com/traefik/traefik/api
https://pkg.go.dev/github.com/containous/traefik/api

But not at:

https://pkg.go.dev/github.com/traefik/traefik/v2/api
https://pkg.go.dev/github.com/containous/traefik/v2/api

(Trying other configurations, like traefik/api/v2, didn't produce results either.)
I'm also still interested in including https://github.com/traefik/traefik/commit/e2c5f3712f68993de8ed3cb30da9ec0aa11acb09 in the advisory to demonstrate the existence of vulnerable code early in the history of the 2.x branch.
Shelby

Hey @shelbyc
Yes, my bad, in v2 they moved the api package under pkg folder:

https://pkg.go.dev/github.com/traefik/traefik/v2/pkg/api

I understand regarding keeping the containous names, my original problem was that the module-level traefik/traefik link was missing, and that "api/v2" is simply wrong go syntax..
To conclude, I think the entries should be:

https://pkg.go.dev/github.com/traefik/traefik : from v1.0.0-beta.211 to v1.7.34
https://pkg.go.dev/github.com/traefik/traefik/api : from v1.0.0-beta.211 to v1.7.34
https://pkg.go.dev/github.com/traefik/traefik/v2 : from v2.3.0-rc6 to v2.8.1
https://pkg.go.dev/github.com/traefik/traefik/v2/pkg/api : from v2.3.0-rc6 to v2.8.1
https://pkg.go.dev/github.com/containous/traefik : from v1.0.0-beta.211 to v1.7.28
https://pkg.go.dev/github.com/containous/traefik/api : from v1.0.0-beta.211 to v1.7.28
https://pkg.go.dev/github.com/containous/traefik/v2 : from v2.0.0-rc1 to v2.3.0-rc5
https://pkg.go.dev/github.com/containous/traefik/v2/pkg/api : from v2.0.0-rc1 to v2.3.0-rc5

What do you think?
Thanks!

All of these packages except one are good to include. All of the versions in https://pkg.go.dev/github.com/containous/traefik/pkg/api are marked incompatible and none of them cover the 1.x branch, so https://pkg.go.dev/github.com/containous/traefik/api will have to cover API versions on the 1.x branch.
For github.com/traefik/traefik/v2 and github.com/traefik/traefik/v2/pkg/api, I'll keep the same vulnerable version ranges as github.com/containous/traefik/v2 and github.com/containous/traefik/v2/pkg/api but make 2.3.0-rc6 the first patched version, because that's the first version people can use on the 2.x branch of traefik/traefik packages.
Thanks again for being so patient with my long comments and dealing with the intricacies of this particular advisory! I appreciate the care and attention you've put into helping make sure the information is complete and accurate.


Xaero's World Map integration

Thanks for the contribution! I've continued from where you left off and finished the integration, along with claim support for 1.21.


Feature: Add the cunet model

Looking forwrad to adding cunet model to this project.

https://github.com/nagadomi/nunif/blob/master/nunif/models/waifu2x/cunet.py
Here is the construction of Cunet. I'm trying to port it from pytorch model to chainer model. But I'm not familiar with deep learning. I'd appreciate it if you could help me

Unfortunately I'm not that great with ml either. Sorry I can't be of more assistance on this one


uiBreadcrumbs: Dropdown within the breadcrumbs?

Hi Michael,
I saw this Stack Overflow question asking about a dropdown in the breadcrumbs, and I too was also wondering if this is something that may be implemented?
StackOverflow question you responded to: http://stackoverflow.com/questions/21970406/how-to-make-automated-dynamic-breadcrumbs-with-angularjs-angular-ui-router

Hi,
Can you describe the specific functionality you envisage? To be honest, I am no longer working on the project which gave rise to the uiBreadcrumbs module, so I'm probably not going to get the time to implement any new functionality right now.
However, I can also give a suggestion on how to go about implementing it, and maybe you or someone else wants to try doing it.

Hi Michael,
Yes, so the specific function I envision would be to add a dropdown within the breadcrumbs that would then allow the user to navigate to child values of that parent.
As an example, say you had brands > campaigns for marketing. You might have Coke, Pepsi, Mountain Dew in the dropdown with different marketing campaigns under each of them.
<md-select ng-model="vm.selectedBrand" aria-label="Brands" placeholder="Select a brand">
                <md-optgroup label="Brands">
                    <md-option ui-sref="brands.detail.campaigns({ brandId: {{::bra.id}} })"
                        value="{{bra.name}}"
                        ng-repeat="bra in vm.brands">
                        {{bra.name}}
                    </md-option>
                </md-optgroup>
            </md-select>

So you'd see the brand names in the dropdown and clicking on one would change the routing and then navigate you correctly to the campaigns page with the correct breadcrumbs.
Hope that makes sense and you could provide suggestion/s as to how best to do this!

Okay, I had time to think about this briefly now. The central problem to solve is "how do we get the child states of a given state?"
The current implementation relies on the fact we can use $state.$current.parent to get the parent of the current state. If we keep doing this all the way up the tree, we get our breadcrumbs.
However, in order to get the children of the first parent, we'd need something like $state.$current.parent.children. Unfortunately there is no such method available. So here is a way it could be done - read this StackOverflow answer.
Basically, we can use $state.get() to get an array of all the states. Then it is a matter of using some pattern matching to identify which are the children of a given state. So in your example, let's say we are in the state campaigns, and we want to list the various children of the parent brands state.
So we can use $state.get() and we'll get an array of objects, something like this (this is simplified):
[
  {
    name: "brands"
    templateUrl: "app/brands/index.html"
    url: "/brands"
  },
  {
    name: "brands.coke"
    templateUrl: "app/brands/c.html"
    url: "/coke"
  },
  {
    name: "brands.pepsi"
    templateUrl: "app/brands/p.html"
    url: "/pepsi"
  },
  {
    name: "brands.mountainDew"
    templateUrl: "app/brands/md.html"
    url: "/mountain-dew"
  },
  {
    name: "contact"
    templateUrl: "app/contact/contact.html"
    url: "/contact"
  }
]

So then we just need to take the state name - "brands" - and filter the states array for any of those which have a name matching ["brands" - period - something]. (Bear in mind that ui-router also allows you to define parent-child relationships in a different way too, not relying on the period convention. In that case a different strategy would be needed, but might be even easier).
So now you have solved the biggest challenge, the rest is a matter of figuring out the implementation problems that come up.
Hope that helps, and if you implement this, I'd be very interested to see it!

Closing. Please re-open if this is still an issue.

I'm working on an implementation @michaelbromley apparently Ryan made his own solution, but it's kind of difficult with the uiBreadcrumbs structure.


MOM-2024-3-15

Problem description
MOM-2024-3-15
Expected action

Additional context

Linked to https://github.com/camaraproject/NetworkSliceBooking/pull/10


Incorrect a type of phone number

Phone number : +52<PHONE_NUMBER>
I tested the above phone number in https://libphonenumber.appspot.com/phonenumberparser.
(I assume that the test web page uses the latest libphonenumber library)
The result webpage said that the type of phone number is FIXED_LINE.
Validation                                                   Results
Result from isPossibleNumber()	           true
Result from isValidNumber()	                   true
Result from isValidNumberForRegion()	   true
Phone Number region	                           MX
Result from getNumberType()	                   FIXED_LINE
However, it's not a landline number but a mobile phone number (Carrier : Nextel) in Mexico.
Please check it out and fix the bug.

Do you have any documents as to whether everything in this range is mobile only, or can these numbers be a mix of fixed line or mobile numbers?

Sorry, I got this feedback from my one customer and therefore, I don't have any document to give you some phone range information.
But I'm gonna ask the customer that his phone can be a mix of fixed line or mobile numbers and update the issue. Thanks,

Looking at the documentation from the ITU (https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200008A0002PDFE.pdf page 2), when dialling a cell phone in Mexico from abroad, the phone number must be prefixed with a 1:
• International calls: operators of international ports have to adapt their networks with a view to enabling calls originating abroad and having as their destination users in the local mobile service in Mexico using the “national calling party pays” mode to be made by dialling the following sequence:
+ 52 + 1 + national number

Using https://libphonenumber.appspot.com/ with the phone number yields the following results:
Supplied number: +52<PHONE_NUMBER> => FIXED_LINE
Using the 1 prefix: +51 1<PHONE_NUMBER> => MOBILE

@booknara
We aren't classifying beyond mobile token(prefix 1 before the number) absence/presence at the moment. But we'll take it on as a feature request. As there is already a open issue(#273) for same context, merging this issue into #273 issue.


[Improvements]: Upgrade to c++20

Description

upgrade to ubuntu 22.04 for last gcc/boost version
fix trezorcrypto compilation
add missing optional include
upgrade to c++20 standalone, don't use any feature
use TW:: for erase/erase_if algorithm, need to check if available on all platform before deleting the code.

How to test
run unit tests
Types of changes
Upgrade C++ standard
Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

@catenocrypt @hewigovens It compiles on c++20 everywhere, but there is a llvm crash on command line regarding coverage:
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
Stack dump:
0.	Program arguments: /usr/bin/llvm-cov-11 /usr/bin/llvm-cov-11 gcov /home/runner/work/wallet-core/wallet-core/build/CMakeFiles/TrustWalletCore.dir/src/Base64.cpp.gcda -b -x -i

If someone have an idea please let me know

I guess we need to upgrade llvm-cov too

Looks good, can you update Dockerfile as well?

Should we keep apt-add-repository -y ppa:mhier/libboost-latest ? I think installing the libboost package comes with boost 1.74 on ubuntu 22.04

no need if we can install boost from official source, also thinking of managing boost by the script

no need if we can install boost from official source, also thinking of managing boost by the script

Sure, I need to fix that on another machine, somehow if I try to run this dockerfile on a mac os M1 it tries to use ubuntu arm version

@hewigovens The reason the dockerfile fails now is that it need this pr as fixes for trezor-crypto.

I see, let's merge trezor fix for master first?

I see, let's merge trezor fix for master first?

done

@Milerius try to run tools/android-build tools/ios-build and tools/ios-xcframework to see if that works

@Milerius try to run tools/android-build tools/ios-build and tools/ios-xcframework to see if that works

All passed

This pr needs to rebase master, I see a few commits already in master


[Horoscope][Aurascan][CW20] Display wrong holders data of Halo tokens

Bug description:

ISSUE 1: CW20 Tokens list, CW20 token details: Display wrong holders number and % holders of Halo tokens
ISSUE 2: CW20 token details: Not display Holders data in the Holders tab

Link:

Token A (TKA)

Expected result:

[x] ISSUE 1: CW20 Tokens list, CW20 token details: Display correct holders number and % holders of Halo tokens
[x] ISSUE 2: CW20 token details: Display correct Holders data in the Holders tab

Screenshot:

Verified PASS on serenity (21/12/2022)


Add Hadean as a friend of Rust

r? @ashleygwilliams
(rust_highfive has picked a reviewer for you, use r? to override)

closing in favor of the new website.


Error when added next-typescript to .babelrc

Hi, We want to add existing next application the typescript module. I did every step what is in the README, after try compile this I got an error:
Module build failed: Error: .presets[0][1] must be an object, false, or undefined
I tried update the babel, babel-core to the newest version, but the error occur.
My .babelrc looks like:
{   "env": {     "development": {       "presets": ["next/babel"]     },     "production": {       "presets": ["next/babel"]     },     "test": {       "presets": [["next/babel", { "preset-env": { "modules": "commonjs" } }]]     }   },   "presets": [     [       "next/babel",       "@zeit/next-typescript/babel",       {         "styled-jsx": {           "plugins": [             "styled-jsx-plugin-sass"           ]         }       }     ]   ] }
rest packages and version which we're using:
"node": "8.11.4"
 "@weco/next-plugin-transpile-modules": "0.0.2",
    "@zeit/next-sass": "0.2.0",
    "@zeit/next-typescript": "^1.1.1",
   "babel-core": "6.26.0",
    "babel-eslint": "7.2.3",
    "babel-loader": "7.1.2",
    "next": "6.1.1",

Hi, thanks for creating an issue. We currently recommend using the built-in typescript support.


Enable the Workspace settings for any admin not only the policy owner

Problem
As NewDot has been primarly built with Free plan in mind, that expects only one admin per policy. This means that as we are now getting to more convoluted usecases of paid plans which have multiple admins, some features were limited only for policy owners hence other admins cant take action. For example the entire workspace settings is not visible for them
Why is it important
Any admin should be able to take actions updating the workspace settings
Solution
Change the logic to check for policy admin instead of policy owner
cc @JmillsExpensify @Beamanator

Its a role in the policy json, making a PR 🚀

@mountiny Need me to do anything for this so far?

Nope, I think actaully there will be nothing to do here as the PR should be handled internally too

I am pretty sure that this is 100% done now, so I'm closing.
@mountiny reopen if I'm wrong!


Fixes #208: Profile progress updates on route changes

Fixes #208
Checklist:

[x] Test your work and double check you didn't break anything
[ ] Update any relevant READMEs and docs

Description:
Please explain the changes you made here:

The progress loader didn't start on route changes and only worked on page refreshes.

My suggested solution: Set the progress in the state everytime the component is mounted.

Please suggest if a better solution comes to your mind. :pray:

Simple enough ✔ Thanks @anshumanv, sorry it took so long to merge.


Implement InputPin trait

(Ref japaric/embedded-hal#41)
This implements the unproven InputPin trait of embedded-hal.

I am waiting for this to test my waveshare e-ink driver. Is there anything missing?

@octycs Could you rebase this to the current master?


Integrate Yarn 3

Hello,
I just found your website after integrating a monorepo with Yarn 3, and I feel it could compare against other solutions. I would understand why Yarn 1 or 2 are not present, but is there a specific reason Yarn 3 has been omitted?
Thank you for your great website and have a nice day,
Adrien

Hi @adrienharnay
Thank you for your comment and need of clarification on this domain, I actually think we should have a section on the website explaining the sentiment about using only Yarn/PnPm workspaces for a monorepo setup.
Even if they can work for some projects and folks, answering their need at the time, we wouldn't really qualify these as "monorepo solution" since they lack all the features for managing and scaling a monorepo. They are, though, an intrinsic element of monorepos by handling all the Nodejs dependencies (aka node_modules), whatever the tool being used.
Let me explain a little deeper
First let see what these tools are, Yarn and Pnpm are Nodejs dependency manager tools. They are alternatives to the default Npm command delivered with Node by default.
With the latest versions, these tools are better and give you more features in the management of your dependencies. Specifically Yarn 3 (Berry) that now allows you to have a thing called "Zerro Install" and "Plug'n'Play" to make everything even faster since your dependencies are basically now Gitted.
They also introduced the concept of workspaces. These workspaces are basically a way to have multiple folders containing your source code for apps & libs with each one a package.json. The main goals behind this concept is to deduplicate the number of packages downloaded for each projects you have in the repository and to link your projects together to have a coherent way to think about them.
Example, if you have 2 projects (folders) that use the same dependencies with the same versions, like reactjs, Yarn will download only the reactjs package once then will reference these 2 projects dependencies to the root node_modules. It will make the installation of packages faster since you only need to download one and only one package. They also allows you to link project references which can help you using your own code as if it was a published package (but this is limited).
More information on Yarn workspaces here: https://yarnpkg.com/features/workspaces#what-does-it-mean-to-be-a-workspace
This is great and this is something that can be used in a monorepo by folks for small project or if they only want to have project linking setup in their repository. Though, as soon as you want to do more with your monorepo, you will lack many features for scaling your monorepo and have the best possible outcome.
Yarn/Pnpm have to be complemented by other tools to add the CI/CD and Developer Experience layers & capabilities for a monorepo to be usable and scalable. You can add these manually, one by one, even creating them from scratch or trying to find other packages that help you achieve them. There are also dedicated monorepo tooling which exists specially for that and the main goal of monorepo.tools is to make these tools more visible.
Using monorepo tools on top of Yarn and Pnpm will allow you to have:

Local computation caching
Local task orchestration
Distributed computation caching
Distributed task execution
Transparent remote execution
Detecting affected projects/packages
Workspace analysis
Dependency graph visualization
Code sharing convention and guidelines
Consistent tooling for multiple programming languages
Code generation
Project constraints and visibility

For this reason, we can not put Yarn or Pnpm in the comparison table since they would lake all the features we need to manage at scale a monorepo.
Though, we will probably be adding a new section to website to talk about this.


Change unit of length for pipeline from km to meters

This is an issue raised by Moise which I mistook the unit of length for pipeline, the unit of length should be meters instead kilometers.
@mirankunda
I just made an issue which was reported by you. If you have any additional to this issue, please add here.

@mirankunda
Sorry for inconvenience. I fixed this bug, please try to update the source code and confirm it.
Open Command Prompt or Powershell, then enter postgis2inventoryreport directory using cd command.
cd postgis2inventoryreport
git pull origin master

Then, launch run_postigis2inventoryreport.bat file.


Updating css classes and fetching skillset

Updating the CSS classes and tags and including a new method to fetch the top skills in the profile

LGTM -- thank you @mattkc7

Adding your name to the authors + change log


Tether should be linked/listed as a requirement from the doc home page

Tether is not listed as a requirement on the home page of the BS4 docs. Simply including the two references listed will result in a error about missing Tether

The documentation home page talk about Bootstrap CDN, if you want to see Bootstrap requirement go to this link : http://v4-alpha.getbootstrap.com/getting-started/introduction/#quick-start and you'll see Tether as required


update TF to version 1.3.2

Description
Updating Terrafrom version from 1.12 to 1.3.5. This is not the latest version of Terraform because Atlantis' current release only supports 1.3.2
Changelog or Releases
Add the changelog or release URL for the tool being updated. Some examples below (delete the ones that do not apply
for clarity).

atlantis
terraform
tfsec

Should this say "Updating Terrafrom version from 1.12 to 1.3.2" and not 1.3.5?

It should indeed. ^_^


Add onDone function

Added a function that will be performed when all rounds are complete.

Published this as 2.1.0


basic setup for ldes feed

Basic setup for an ldes endpoint. Currently only publish VerkeerboordsConcept (and only the skos:label & image)

[@nvdk quick demo with vlag:
https://cloud.bittich.be/s/zWpwFTtQfkw4my7


fix: try avoid some typescript setting show error

https://github.com/keithamus/sort-package-json/issues/172

It is not yet fixed.
node_modules/sort-package-json/index.d.ts:14:14 - error TS1134: Variable declaration expected.
14   var default: <T extends Record<any, any>>(packageJson: T, options?: sortPackageJsonCore.Options) => T;

Now it is fixed in #189 and version 1.42.3


[ADAP-571] Dataproc Custom Subnetwork Location

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Currently, DataProc Serverless does not provide an option to add a custom subnetwork in model configuration. This makes it impossible for users to select a network that fits their specific requirements. As a result, I suggest adding a “subnetwork” parameter to the DataProc Serverless model/project configuration.
Describe alternatives you've considered
No response
Who will this benefit?
Dataproc users with VPC network restrictions
Are you interested in contributing this feature?
No response
Anything else?
No response

Thanks for reaching out @alimasri !
Could you share a link to the relevant documentation in from BigQuery? Or even better, do you see anywhere in here where that subnet configuration would go?

Thanks for reaching out @alimasri !
Could you share a link to the relevant documentation in from BigQuery? Or even better, do you see anywhere in here where that subnet configuration would go?

Thanks for you attention to this issue @dbeatty10.
I believe it would replace the following:
https://github.com/dbt-labs/dbt-bigquery/blob/7bc2af0cef1e42b625cee6d996b48cb91dc2e49c/dbt/adapters/bigquery/python_submissions.py#L116
So instead of auto-generating the subnetwork based on the execution project, dataproc region and default network, the user can add a dataproc_subnet parameter to their model or profiles.yml.
I did not get a chance to read how user configuration is passed to the adapter, but from a quick glance I think this can be achieved by adding dataproc_subnet to the line below:
https://github.com/dbt-labs/dbt-bigquery/blob/7bc2af0cef1e42b625cee6d996b48cb91dc2e49c/dbt/adapters/bigquery/python_submissions.py#L25
then reference it with self.credentials.dataproc_subnet. Please correct me if I am wrong.

Thanks for looking into this @alimasri.
User configuration
Passing user configuration in profiles.yml to the adapter is via a one-line addition like this:
https://github.com/dbt-labs/dbt-bigquery/blob/512f5f3da0c1158e7ebff5821d920083d936b535/dbt/adapters/bigquery/connections.py#L133
Then self.credentials.dataproc_region (or in this case self.credentials.dataproc_subnet) can be referenced downstream wherever it is needed.
Submitting to BigQuery
Once a value is saved within self.credentials, then it just needs to be passed along to BigQuery. But I couldn't determine from the BigQuery documentation how exactly to pass in the subnet.
How would you modify the following to included self.credentials.dataproc_subnet?
https://github.com/dbt-labs/dbt-bigquery/blob/7bc2af0cef1e42b625cee6d996b48cb91dc2e49c/dbt/adapters/bigquery/python_submissions.py#L116
Or would you submit the dataproc_subnet to BigQuery some other way?

Thanks @dbeatty10.
The problem is passing this to dataproc not to BigQuery. But based on your reply this should be an easy fix.
We first add the dataproc_region to connections.py then we modify the python_submissions code to override the default variable if it was set by the user.
if dataproc_region:
    parent = dataproc_region
else:
    parent = f"projects/{self.credential.execution_project}/locations/{self.credential.dataproc_region}"

This way the dataproc job runs in the default subnet if the user did not give any dataproc_region value, and use a custom subnet otherwise.
Please correct me if I am wrong.

The problem is passing this to dataproc not to BigQuery

Ah yes, thank you for pointing that out! ❤
I'm not quite following the approach you outlined.
dataproc_region is already in connections.py here and afterwards it can be referenced via self.credential.dataproc_region.
So this example doesn't make sense to me:
if dataproc_region:
    parent = dataproc_region
else:
    parent = f"projects/{self.credential.execution_project}/locations/{self.credential.dataproc_region}"

Did you mean self.credentials.dataproc_subnet instead of dataproc_region?

Oh sorry, yes I meant subnet

Cool, in that case, it sounds like it would be something like this:
if self.credentials.dataproc_subnet:
    parent = self.credentials.dataproc_subnet
else:
    parent = f"projects/{self.credential.execution_project}/locations/{self.credential.dataproc_region}"

Would you be interested in contributing this feature, by any chance?
We're not likely to prioritize this ourselves soon, so we'd rely on a motivated community member to contribute this feature.

Sure I'll work on it. Thanks for your support.

I figured out that this could be done by adding subnetwork_uri in the profiles.yml file:
dataproc_batch:
  environment_config:
    execution_config:
      service_account: SERVICE_ACCOUNT_INFO
      subnetwork_uri: CUSTOM_SUBNET


Remove invalid timestamp check

I can't understand this check:
AFAIK check_inherents is run after the block is build. Thus Self::now() contains the block timestamp.
So:
t < minimum
== timestamp_block < Self::now() + MinimumPeriod
== timestamp_block < timestamp_block + MinimumPeriod
== false

I guess it is not a fatal error, and that's probably why it was working fine.
Or maybe I missunderstand what value contains Self::now() in this context, but anyway it seems to me this check is redundant with the assert in the set call:
https://github.com/paritytech/substrate/blob/743accbe3256de2fc615adcaa3ab03ebdbbb4dbd/frame/timestamp/src/lib.rs#L199-L202
If I'm correct we can then refactor timestamp InherentError.

AFAIK check_inherents is run after the block is build. Thus Self::now() contains the block timestamp.

It is run after the block is build, but using the state of parent block. So, Self::now is returning the timestamp of the parent block. These checks are done before we import the block.

ok good to know, then it might be a bit redundant but there is no error


Whitespaces added although setting is disabled

As said, I turned off the setting to add two whitespaces at every line at it however it still does.

Thank you for your report. I really appreciate that.
I have fixed this issue in v0.1.0

Thank you!


Created a seperate function to add binary sensor information to the s…

…ensors list for the Airzone cloud integration

Proposed change

Reduced the cognitive complexity of the Airzone cloud integration.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist
[ ] I have followed the perfect PR recommendations
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

Kishor Peneff Group 10
2: The function async_setup_entry was quite complex and confusing to understand due to the three for loops which had an additional for loop as well as an if statement inside of them. This unnecessary complexity could make it difficult to maintain the code as developers would need to spend more time to familiarise themselves with it compared to less complex functions.
3: I decided to split up the addition of the binary sensor information into a separate function due to the three for loops following the same structure. This way, the complexity of the original function gets reduced. The addition of a new function also allowed me to add type hints to the various parts of the structure, therefore making to clearer what type each of the variables are expected to have. This change may simplify the process of understanding the code and thus shorten the time needed for future modifications.

looks good


cluster is_shared bugfix

#574  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BelSasha and the rest of your teammates on  Graphite


Easily enable local mode

There are currently two or three places where we have to change code in order to be able to run Cloudburst in local mode. In particular, this requires relaxing the scheduling and executor constraints on the number of pinned functions per thread.
@saurav-c, I know you've made these changes before, so can you wrap those changes in an if statement that relies on a local mode flag (specified in the config YAML file), so we don't have to change the code to run locally? Let me know if you have any questions.

Fixed by #24.


Consider updating the version hash of luajit

For context see this issue I submitted to the Mineclonia project which it appears may be due to the luajit version this Dockerfile uses and the fact I'm running on arm64.
The Dockerfile specifies a commit of luajit from February 2023 and comments that this is prior to the release of 2.1 -- luajit has now moved to a rolling release and 2.1 was marked 'production' in August 2023. There have been a number of arm64 related commits to luajit in that period and since.
The most recent commit to 2.1 is 04dca7911ea255f37be799c18d74c305b921c1a6

Thank you for the update! I'm find upgrading to the more recent version of 2.1 branch, I would rather have a "released" version tag instead of a rolling one but it is what it is!

I just experimented  with redefining the LUAJIT_VERSION in my Containerfile
# Use the default stable 5.x version
FROM ghcr.io/ronoaldo/minetestserver:stable-5

# Most recent LuaJIT commit on 2.1 branch as of 2024-06-06
ARG LUAJIT_VERSION=04dca7911ea255f37be799c18d74c305b921c1a6

But still end up with  a version luajit-2.1.0-beta4-mercurio in the container, so I assumed that hasn't worked.
It seems there is no way to override that without building my own base image too?
Wanted to do some testing.

Yes... Unless you rebuild the luajit version in your base image, it won't rebuild what it inside the FROM clause, as each layer is immutable.
I'll try to add a branch and publish a version so you can confirm it works for you by pulling from a different tag. This way we can both test a newer version with our servers.

I created a two stage build file based on yours and used the latest LuaJIT 2.1 (as in my last comment), rebuilt my containers and two of my worlds work fine (plain Minetest and Minetest plus a handful of mods in creative mod).
But Mineclonia was crashing on start.
I need to look a little deeper into why, and I can try a slightly older LuaJIT version, but I'm done for the day. Will let you know if I make any progress.

Tried an older version of LuaJIT (ARG LUAJIT_VERSION=6807e60af13c7f9a582dbf4cabc56e57dc791808) and Mineclonia was no  longer crashing. But i was unable to mine blocks when I logged in and still found errors.
So instead of using Minetest master branch I specified a stable release (5.8.0). No crashes, seems to be working.
Right now I have this section in my Containerfile:
# Build-time arguments
ARG MINETEST_VERSION=5.8.0
ARG MINETEST_GAME_VERSION=5.8.0
# Note IRRLICHT is in main minetest repo from 5.9.0 onwards
ARG MINETEST_IRRLICHT_VERSION=1.9.0mt13
ARG MINETOOLS_VERSION=v0.2.2
# Most recent LuaJIT commit on 2.1 branch as of 2024-06-06
ARG LUAJIT_VERSION=04dca7911ea255f37be799c18d74c305b921c1a6

And this seems to work without errors - though  I have yet to stress test it with multiple players.
(Also note that irrlichtmt has been moved into the minetest repo from 5.9.0. https://github.com/minetest/irrlicht  is archived and pulling the head of master was probably  pulling in an old version as far as Minetest master is concerned -- it's possible that was ignored during the build -- but may also have been causing issues.)

Because this images are not rebuilt frequently, I decided to go with branch v2.1 (rolling release of Lua) as a default when none of the build-time arguments are passed.
For the 5.9.0 release, I pinned a commit hash in order to keep this stable build consistent. This is done via the Github workflow. For downstream builds, if basing from 5.9.0 tags (including the updated stable-5 one), this hash is the one pinned.
There is no easy way to change linked libraries downstream unless rebuilding the container yourself with the proper --build-arg arguments.


Is it possible to make version 2.0.0 available in https://pypi.org/project/pghoard/ ?

pghoard 2.0.0 (and 2.1.0) is available in PyPI.