Larastan doesn't detect custom model collection after map()

Larastan Version: 2.9.5
PHPStan Version: 1.10.67
Laravel Version: 10.48.8

Description
My User model overrides newCollection() to return custom ModelCollection that extends Eloquent\Collection. The user model has a relationship created_by_user to User. I want to fetch a few users, and map them to their creator users.  Instead PHPStan thinks it's a Eloquent\Collection.
Code
$models = User::query()->get();
\PHPStan\dumpType($models); // 👍 App\Base\ModelCollection<int, App\Models\User>
$users = $models->map(fn(User $model) => $model->created_by_user);
\PHPStan\dumpType($users); // 👎 Illuminate\Database\Eloquent\Collection<int, App\Models\User>

If I make the closure more verbose:
$users = $models->map(function(User $model) : User {
    return $model->created_by_user;
});

the result is the same, because the User bit isn't the problem (Larastan knows the result is a collection of User), but the collection is.
Demo
MapController in https://github.com/rudiedirkx/larastan-demo
It tests with User and Post. User has the custom collection, Post doesn't. The Post map result is fine, but the User map result is not.
$ ./vendor/bin/phpstan analyze app/Http/Controllers/MapController.php

  16     Dumped type: Illuminate\Database\Eloquent\Collection<int, App\Models\Post>
  18     Dumped type: Illuminate\Database\Eloquent\Collection<int, App\Models\User>
  24     Dumped type: App\Base\ModelCollection<int, App\Models\User>
  28     Dumped type: Illuminate\Database\Eloquent\Collection<int, App\Models\User>

The weird union type Illuminate\Support\Collection<int, null> only happens with the short closure I think:
$users = $models->map(fn(Post $model) => $model->created_by_user);

The long closure (with User) results in a prettier Illuminate\Database\Eloquent\Collection<int, App\Models\User> but no ModelCollection.

I removed the weird union type bits, I don't care about those. Just use a long closure with return type. But the disappearing ModelCollection ... 😢

Issue is that static<...> in the EloquentCollection stub is not supported: https://github.com/phpstan/phpstan/issues/5512
We would have to wait until this is implemented or create a dynamic return type extension for those methods

Issue is that static<...> in the EloquentCollection stub is not supported: https://github.com/phpstan/phpstan/issues/5512
We would have to wait until this is implemented or create a dynamic return type extension for those methods

Yes,that's exactly what we already have.

Yes,that's exactly what we already have.

No, there's an extension for the SupportCollection, but the only extension for the EloquentCollection is for the find method

Yes, it just needs to be updated for the map* methods on the EloquentCollection

No it's already doing it. It just has a bug.

Wooow I found an actual bug? I'm kinda proud of that. Larastan has been stellar, it's me with the bugs usually. Great work once again guys ❤

Fixed with 1a05ac6dd0bbde4dc52b9d24c0a2a493f2c3784c


software aborts when lowercase letters are in the reference sequences

Hi (again, sorry!),
I was running eventalign earlier with this command:
nanopolish eventalign -t 8 --sam -r mydata.fasta -b reads.sorted.bam -g myreference.fasta --models nanopolish_models.fofn
and got the following error message:
nanopolish: ./src/common/nanopolish_alphabet.h:173: virtual std::string Alphabet::disambiguate(const string&) const: Assertion 'IUPAC::isValid(out[i]' failed. Aborted
After investigating the code, my reference sequences and my 2D read data I managed to figure out that nanopolish doesn't like lowercase bases in the reference sequence(s). Once I amended those bases to uppercase, eventalign worked as expected.
Figured it was worth mentioning here for future releases?

Ah, good catch. I'm not sure if I want to require the reference to be upper case (and emit a better error) or change the bases internally. I'll think about this, thanks for reporting.

Finally fixed in 046e7c6, thanks for the report


update domain name for ImproveOSM

Closes #9993

@k-yle Hello Kyle, not sure of the whole process here but do you think we can get this merged soon ? We've extended the deadline of Dec 4th but really need to move forward with decommissioning the old URLs. If there's something needed from our end please let me know.

Hey @radubaba-grabtaxi, sorry only @tyrasd can merge PRs. Releases seem to happen every 3 months, sometimes more often. As far as I know, there is no longer a regular release schedule. @tyrasd would be the best person to ask.

Hello @tyrasd, is there a possibility we could expedite this change? As @radubaba-grabtaxi has previously indicated, our initial Dec 4th deadline has been greatly extended and is blocking our progress with the root URL decommissions. In addition, the certificates for the old URLs have now expired.
Your prompt attention to this matter would be much appreciated.


Show/Hide icon is visible on the comment thread

Show/Hide icon is visible on the comment thread


feat: Add ping ability

This PR adds a Ping and PingContext method to the Driver which satisfy the sql driver interface.
It uses a simple SELECT 1 to test the connection, which I believe is how most drivers implement a ping.
I have added a test to test the funcitonality and also included an example.
Closes #96

This adds the Ping only to websockets, no?
We have also HTTP transport that needs the support too.

This adds the Ping only to websockets, no? We have also HTTP transport that needs the support too.

Ah at first glance it didn't look like that had a diver but I guess it needs to be added to the hranaV2Conn
I'll amend that now

@haaawk Should be ready for re-review


tmt test lint --fix - indentation not unified

When a linting is fixed using tmt test lint --fix, strings and dicts have different indentation.
Example of main.fmf after lint fix (relevancy got converted to adjust):
description: |
    Runs upstream test suite against content built from the source RPM.
component:
- scap-security-guide
test: ./runtest.sh
framework: beakerlib
require:
-   url: https://github.com/beakerlib/distribution
    name: /Cleanup
- library(distribution/RpmSnapshot)
recommend:
- scap-security-guide
- python2-pytest
duration: 2h
enabled: true
adjust:
-   enabled: false
    when: distro < rhel-7
    continue: false

The adjust part has 4-space indentation, recommend has 2-space indentation, and require is mix of both.

The following would be an ideal indentation from my point of view:
description: |
    Runs upstream test suite against
    content built from the source RPM.
component:
  - scap-security-guide
test: ./runtest.sh
framework: beakerlib
require:
  - url: https://github.com/beakerlib/distribution
    name: /Cleanup
  - library(distribution/RpmSnapshot)
recommend:
  - scap-security-guide
  - python2-pytest
duration: 2h
enabled: true
adjust:
  - enabled: false
    when: distro < rhel-7
    continue: false

Basically keep 4 spaces consistently everywhere and use ␣␣-␣ for prefixing lists (space, space, dash, space).

This looks like the same issue - https://stackoverflow.com/questions/25108581/python-yaml-dump-bad-indentation
Unfortunately, the proposed solution with Dumper doesn't work for me.
Easy way how to at least unify the indentation could be change of the indent to 2-space - https://github.com/psss/tmt/blob/master/tmt/utils.py#L744 - with this change, the file file looks like this:
description: |
  Runs upstream test suite against content built from the source RPM.
component:
- scap-security-guide
test: ./runtest.sh
framework: beakerlib
require:
- url: https://github.com/beakerlib/distribution
  name: /Cleanup
- library(distribution/RpmSnapshot)
recommend:
- scap-security-guide
- python2-pytest
duration: 2h
enabled: true
adjust:
- enabled: false
  when: distro < rhel-7
  continue: false

I'd say that 2 spaces do not provide enough visual indentation for the human eye to quickly see/parse the overall structure at first sight.

I've looked into it and seems like there is no way to achieve this formatting using the PyYAML library. I will try to migrate tmt to ruamel.yaml, will see how it goes


Tested the lights by running the examples files and it works fine. Connection is for sure right.
Please help, I'm not a super experience coder and it will be great if you could explain to me with written directions!
I am currently working on a light experience relating to how lights would affect an individual for school. This is a basic opening for us to see how it will work for our testing only.
The following is code prompt after trying to run visualization. Thank you very much
pi@raspberrypi:~/dancyPi-audio-reactive-led/python $ sudo python visualization.py scroll
Expression 'alsa_snd_pcm_hw_params_set_period_size_near( pcm, hwParams, &alsaPeriodFrames, &dir )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 924
ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5036:(snd_config_expand) Args evaluate error: No such file or directory
ALSA lib pcm.c:2565:(snd_pcm_open_noupdate) Unknown PCM bluealsa
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5036:(snd_config_expand) Args evaluate error: No such file or directory
ALSA lib pcm.c:2565:(snd_pcm_open_noupdate) Unknown PCM bluealsa
ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Expression 'paInvalidSampleRate' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2048
Expression 'PaAlsaStreamComponent_InitialConfigure( &self->capture, inParams, self->primeBuffers, hwParamsCapture, &realSr )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2719
Expression 'PaAlsaStream_Configure( stream, inputParameters, outputParameters, sampleRate, framesPerBuffer, &inputLatency, &outputLatency, &hostBufferSizeMode )' failed in 'src/hostapi/alsa/pa_linux_alsa.c', line: 2843
Traceback (most recent call last):
File "visualization.py", line 370, in
microphone.start_stream(microphone_update)
File "/home/pi/dancyPi-audio-reactive-led/python/microphone.py", line 14, in start_stream
frames_per_buffer=frames_per_buffer)
File "/usr/lib/python2.7/dist-packages/pyaudio.py", line 750, in open
stream = Stream(self, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/pyaudio.py", line 441, in init
self._stream = pa.open(**arguments)
IOError: [Errno -9997] Invalid sample rate

Hi Max,
Not sure if you're still having this issue, one thing that helped someone else in a similar situation is to turn off the Pi, plug in the mic, and then turn it back on. It seems that sometimes the Pi has a hard time picking up new devices if they are plugged in while the pi is on.

I just updated the tutorial and repo this past week. I tried automating as much as I can.  Hope it helps!
Here's the written tutorial: https://www.easyprogramming.net/raspberrypi/audio_reactive_led.php
And video tutorial: https://www.youtube.com/watch?v=7YLF-N0596I

@naztronaut  Hey, not to hijack the thread, but I'm actually having the same issue. See below:
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_dsnoop.c:638:(snd_pcm_dsnoop_open) unable to open slave
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib conf.c:5036:(snd_config_expand) Args evaluate error: No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm.c:2565:(snd_pcm_open_noupdate) Unknown PCM bluealsa
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib conf.c:4568:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib conf.c:5036:(snd_config_expand) Args evaluate error: No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm.c:2565:(snd_pcm_open_noupdate) Unknown PCM bluealsa
Oct 31 16:45:44 raspberrypi librespot[629]: Cannot connect to server socket err = No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: Cannot connect to server request channel
Oct 31 16:45:44 raspberrypi librespot[629]: jack server is not running or cannot be started
Oct 31 16:45:44 raspberrypi librespot[629]: JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Oct 31 16:45:44 raspberrypi librespot[629]: JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Oct 31 16:45:44 raspberrypi librespot[629]: Cannot connect to server socket err = No such file or directory
Oct 31 16:45:44 raspberrypi librespot[629]: Cannot connect to server request channel
Oct 31 16:45:44 raspberrypi librespot[629]: jack server is not running or cannot be started
Oct 31 16:45:44 raspberrypi librespot[629]: JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Oct 31 16:45:44 raspberrypi librespot[629]: JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pulse.c:243:(pulse_connect) PulseAudio: Unable to connect: Connection refused
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pulse.c:243:(pulse_connect) PulseAudio: Unable to connect: Connection refused
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_a52.c:823:(_snd_pcm_a52_open) a52 is only for playback
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm.c:2565:(snd_pcm_open_noupdate) Unknown PCM iec958:{AES0 0x6 AES1 0x82 AES2 0x0 AES3 0x2  CARD 0}
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
Oct 31 16:45:44 raspberrypi librespot[629]: ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
Oct 31 16:45:45 raspberrypi librespot[629]: Cannot connect to server socket err = No such file or directory
I have a custom asound.conf file.. not sure if that makes a difference. here it is:
Change to the card number or name that you want to be the default control card.
Default: 0
defaults.ctl.card 0
Change to the card number or name that you want to be the default playback card.
It should usually be the same as defaults.ctl.card.
Default: 0
defaults.pcm.card 0
Change to the device number that you want to be the default device on the default card.
0 or 1 is usually the correct device number.
Default: 0
defaults.pcm.device 0
Change to the subdevice number that you want to be the default subdevice on the default device.
Should rarely need to be changed.
Default: -1
defaults.pcm.subdevice -1
defaults.pcm.rate_converter speexrate_medium
pcm.!default {
type plug
slave {
channels 2
rate 48000
format S16_LE
pcm {
type softvol
slave.pcm {
type dmix
ipc_key 1024
ipc_perm 0660
ipc_gid audio
slowptr true
hw_ptr_alignment roundup
slave {
pcm {
type hw
card {
@func refer
name defaults.pcm.card
}
device {
@func refer
name defaults.pcm.device
}
subdevice {
@func refer
name defaults.pcm.subdevice
}
}
channels 2
period_size 0
buffer_size 0
buffer_time 0
period_time 250000
periods 4
rate 48000
format S16_LE
}
bindings {
0 0
1 1
}
}
control {
name PCM
card {
@func refer
name defaults.ctl.card
}
}
}
}
}
pcm.spotify {
type plug
slave {
channels 2
rate 48000
format S16_LE
pcm {
type softvol
slave.pcm default
control {
name spotify
card {
@func refer
name defaults.ctl.card
}
}
}
}
}
pcm.alexa {
type plug
slave {
channels 2
rate 48000
format S16_LE
pcm {
type softvol
slave.pcm default
control {
name alexa
card {
@func refer
name defaults.ctl.card
}
}
}
}
}

@naztronaut Running it on a Logitech C270 if that makes a difference!

Your default card is set to device 0. Is that correct? Can you output the results of this:
cat /proc/asound/cards

Did you use the installer that I have in the repo or did you make the edits manually?

@naztronaut No worries I figured it out! Thanks though. I have another question, but I'll ask in a different thread.

@farhandsome Awesome!! Glad you figured that out. What was the issue? Your resolution may help others in the future.


reset after receing an uplink

my gateway is receiving after receiving an uplink why?

A readUdp:: NTP msg rcvd
G addLog:: fileno=0, rec=1: 1 4 B4 0 3C 71 BF FF FF FF 1B DC {"rxpk":[{"tmst":29878605,"chan":0,"rfch":0,"freq":868.099975,"stat":1,"modu":"LORA","datr":"SF7BW125","codr":"4/5","lsnr":10,"rssi":-30,"size":28,"data":"QGoUASaAAAABE0IDngpw1AhSBvFPUeSgOqMMSw=="}]}
A readUdp:: Error: PKT_PULL_RESP sendPacket failed
Guru Meditation Error: Core  1 panic'ed (StoreProhibited). Exception was unhandled.

Hi,
I have the same issue on my side too.
If the debug level = 2 then it is possible to see the error:
00:51:58.258 -> {"txpk":{"imme":false,"tmst":129525217,"freq":868.099975,"rfch":0,"powe":14,"modu":"LORA","datr":"SF7BW125","codr":"4/5","ipol":true,"size":33,"ncrc":true,"data":"IPW3aWpLJmqs+KyKJcFMcjmamHDHjXiRIVCka9fttDfz"}} 00:51:58.258 -> <T sendPacket:: ERROR: data is NULL 00:51:58.305 -> A readUdp:: Error: PKT_PULL_RESP sendPacket failed 00:51:58.305 -> Guru Meditation Error: Core  1 panic'ed (StoreProhibited). Exception was unhandled. 00:51:58.305 -> Core 1 register dump: 00:51:58.305 -> PC      : 0x400d402a  PS      : 0x00060a30  A0      : 0x800db3d1  A1      : 0x3ffb1f00   00:51:58.305 -> A2      : 0x00000000  A3      : 0x00000000  A4      : 0x3ffc1fe8  A5      : 0x3ffbeca7   00:51:58.305 -> A6      : 0x00000003  A7      : 0x00060423  A8      : 0x00000000  A9      : 0x00000000   00:51:58.305 -> A10     : 0x00000022  A11     : 0x00000000  A12     : 0x3ffc1fe8  A13     : 0x3ffbeca7   00:51:58.352 -> A14     : 0x00000000  A15     : 0x3ffb0060  SAR     : 0x0000000e  EXCCAUSE: 0x0000001d   00:51:58.352 -> EXCVADDR: 0x00000000  LBEG    : 0x400014fd  LEND    : 0x4000150d  LCOUNT  : 0xffffffff   00:51:58.352 ->  00:51:58.352 -> Backtrace: 0x400d402a:0x3ffb1f00 0x400db3ce:0x3ffb1f20 0x400de7a7:0x3ffb1f50 0x400dea30:0x3ffb1f90 0x400e8255:0x3ffb1fb0 0x40088ddd:0x3ffb1fd0

Aha, now I understood the down-link pull request.
Have a look at this change:
https://github.com/things4u/ESP-1ch-Gateway-v5.0/pull/72/commits/f3f4f194a6e1059c15b6397fd8bfc8a32d631ac9#diff-0a7fba24a3dd3d3ea7934244ea958757
Now it is working and is allowing another TTGO flashed with the PAX counter to join and send some data.
Thank you.

Dear RaveGun,
OK I understand it. But with GitHub and pull requests I don't know how it works and what I have to do to get the code into my code. Is there any automatics. Thanks

Seems to be working with it now. But the pull request! Thanks RaveGun.


Java null-dereference error

Hi,
I was wondering if the following is a bug or not:
// Does not generate null_dereference error
String s = null;
if (s != null) {
    return s.length();
}
return 0;

// This generates null_dereference error
String s = null;
try {
    return s.length();
} catch (NullPointerException e) {
    return 0;
}

Shouldn't the 2nd example behave the same as the first one? I know the error is called NULL_DEREFERENCE, and in the second example a null dereference happens, but I thought that if it is handled by a try-catch it is fine because it does not crash the program.

This is a conscious decision not to silence warnings if the NullPointerException is caught, see for instance #423.


ES6: Destructure components

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

@shivam-sharma7 is there a reason for this to be a draft PR?  is there anything else you want to change?

@johnaohara I actually want to merge #1004 first, so take a look please

@johnaohara you can merge this!

Merged,
Thanks for your contribution

Thanks


Add Sort Type information to html and display that info from server.

@nunofilipesf Updated to refactor this code.


Is there a server that would produce both an edit and a command in a single CodeAction?

I am updating my client's code action support.
I am unsure how to implement code actions with mixed edit and command in them.
Having a server to test against would be very useful.
If there is such a server, knowing how to trigger this use case would also be appreciated.

Another question is:
In the "mixed code action" case, do clients have to apply the edit, send didChange notification(s) and only then execute the command?
Or can clients agreggate the edit with the changes that executing the command produces and only then actually apply?

If you have both a edit and a command, first the edit should be applied, including sending out change notifications and then the command should be applied.

If you have both a edit and a command, first the edit should be applied, including sending out change notifications and then the command should be applied.

What is the purpose of this complex feature? What use cases is it for?

historical reasons
to trigger API commands if the client supports them (this is client specific)
to let the server know about the execution of a code action in case there needs to be some follow-up work.

To add to the above, clangd's use case is deferring the expensive computation of a text edit to after a completion item has been selected (so that the computation only has to be done for the selected proposal, not all offered proposals).

The Dart LSP server sometimes does this when the edits are inlined (because they were already computed), so that the server knows that the action was invoked (for ex. if analytics are enabled, metrics on the number of times each action is used can be collected):
{
	"command": {
		"arguments": [
			{
				"action": "dart.assist.add.typeAnnotation"
			}
		],
		"command": "dart.logAction",
		"title": "Log Action"
	},
	"diagnostics": [],
	"edit": {
		"documentChanges": [/*...*/]
	},
	"kind": "refactor.add.typeAnnotation",
	"title": "Add type annotation"
}

If you want to test with it, this can be triggered by having the code a = 1; in a .dart file and sending a CodeAction request on the a to get the Add type annotation" action. The Dart LSP server is part of the Dart SDK and started with dart language-server`.

I have managed to implement this kind of "mixed" code actions.
@DanTup Thanks for pointing me in the Dart direction.
@dbaeumer Thaks for clarifying the client expectation.

I will close the issue since it looks answered to me.


Patch 1: Update Workflow/ Pull Requests

Summary
Changes made to steps 1 - 3 of the "Workflow/Pull Requests section", to clarify a few of the steps for beginner contributors. As a beginner, some of the steps can be confusing/ unclear.
Test plan
Updates to edits from: Patch 1

Thank you for your contribution! I made some small amends to make sure the Contributing guide only contains what most people actually need.

Hi @cpojer Thank you for making the amends!
This is my first time contributing to an open source project, and I want to thank you all for making the process easy and fun.

Hey! Please keep it up and feel free to contribute anything you want :)


Some constraint setups seem to be solved incorrectly

Take a look at the following example: http://jsfiddle.net/We33V
The non-static composition of bodies do not fall off the edge as expected.

Closing this at appears to have been solved by the constraint improvements made as of 0.13.0, thanks for providing the case!


Feature/jaor/modify docker compose

I'm gonna go ahead and merge this, as @martin31821 already tested this and docker setup does not work for @iris-ersc due to SELinux


Recovery progress indicator

Restoring a large basebackup currently shows no progress at all.
It'd be nice to see the progress of download, tar extraction, etc.

This is done can we close


Update SpeechRecognitionDelegate.swift

#231 mic input button issue
other file ss

@baquer the issue states to enable/disable the button when Speech Recognition is not available and instead show the send button.


feat: Update noir

Benchmark results
Metrics with a significant change:

node_database_size_in_bytes (10): 5,137,812 (+45%)
note_successful_decrypting_time_in_ms (8): 360 (+18%)
note_trial_decrypting_time_in_ms (8): 71.7 (+236%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 14d39edb and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,656
866,920
3,448,300

l1_rollup_execution_gas
314,075
984,592
3,667,889

l2_block_processing_time_in_ms
1,429 (-10%)
5,240 (-1%)
20,812

note_successful_decrypting_time_in_ms
:warning: 360 (+18%)
921
3,556

note_trial_decrypting_time_in_ms
:warning: 71.7 (+236%)
47.4 (-4%)
148

l2_block_building_time_in_ms
16,065
63,920
255,835

l2_block_rollup_simulation_time_in_ms
11,690
46,587
186,745

l2_block_public_tx_process_time_in_ms
4,342
17,243
68,794

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,851 (-3%)
30,036 (-4%)

note_history_successful_decrypting_time_in_ms
2,344 (+4%)
4,207 (-9%)

note_history_trial_decrypting_time_in_ms
88.7 (-69%)
159 (-35%)

node_database_size_in_bytes
3,521,474
:warning: 5,137,812 (+45%)

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
215 (+1%)
44,681
25,561

private-kernel-ordering
165 (-1%)
43,753
14,809

base-rollup
1,224 (+2%)
128,338
881

root-rollup
79.2
4,088
677

private-kernel-inner
300 (+3%)
71,208
25,561

public-kernel-private-input
206
31,863
25,561

public-kernel-non-first-iteration
203
31,905
25,561

merge-rollup
7.64
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
12.1
17.6 (-2%)
14.9 (+1%)
19.7 (-1%)
24.4 (-5%)
67.2 (-3%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.627 (+1%)
0.610 (-1%)
0.605 (+1%)
0.556 (+1%)
0.483 (-1%)
0.444
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
82.5 (+1%)
52.2
249
478 (-1%)
916
3,579

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.476 (+2%)
0.501 (+1%)
0.438
0.436
0.430
0.427

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
117 (-2%)
62.3 (-1%)
375 (+2%)
761 (-4%)
1,431
5,644

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.507 (+1%)
0.505
0.484 (+2%)
0.483 (-1%)
0.474
0.473

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
66.9 (-3%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
94.1
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
0.595 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,222

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
376
1,093 (+1%)

Metric
1 public data writes

tx_sequencer_processing_time_ms
535 (-1%)

Oops, forgot to update the aztec-packages branch on noir. Doing that now!


rename fargate to ecs and remove hardcoded nlbs

• Does any part of it require special attention?
• Does it relate to or fix any issue?
closes #116 and closes https://github.com/klothoplatform/klotho-history/issues/633
Renaming fargate to ECS so it aligns with the service name and we can build off of that.

To do this we check in the Merge of config for exec units and just change the name while throwing a warning. This does log multiple times but we never have a singular place up front to do this (We should likely write the config class to be easier to interact with)

Removes the hardcoded NLBS (Regression of the NLB showing up in topology, however i think the tradeoff is worth it and correct as we wrote code in plugins just to make that happen, but that code wasnt even used in the IAC)
removes GatewayTargets - IMO A gateway target can be derived from dependencies at this stage and when we move AWS code back to compiler we can expand the actual links
For IAC, switched the ecs code off of awsx for load balancing stuff and making it use our LoadBalancing IaC class so that it resembles eks and other lb features in a standardized way
if anyone has a better place to put the warning, im all ears because this is what the output looks like
new update is available, please run klotho --update to get the latest version
Execution unit type 'fargate' is now renamed to 'ecs'
Execution unit type 'fargate' is now renamed to 'ecs'
Adding resource exec_unit:main
Found 2 route(s) for middleware 'router'                                                                                unit: main
Adding resource gateway:app
Adding resource persist_kv:users
Execution unit type 'fargate' is now renamed to 'ecs'
Execution unit type 'fargate' is now renamed to 'ecs'
Execution unit type 'fargate' is now renamed to 'ecs'
Execution unit type 'fargate' is now renamed to 'ecs'
Adding resource topology:ts-ms-ecs
Execution unit type 'fargate' is now renamed to 'ecs'
Execution unit type 'fargate' is now renamed to 'ecs'
Adding resource aws_template_data:ts-ms-ecs
Adding resource infra_as_code:Pulumi (AWS)

Standard checks

Unit tests: Any special considerations? this didnt break any unit tests and actually simplifies our code base
Docs: Do we need to update any docs, internal or public? need to update to ecs instead of fargate
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? yeah, fargate will still work, but will throw a warning about the renaming. Eventually we will want to remove fargate

I thought we were moving things out of deploylib and into Go - doesn't this do the other way around?

so a couple things

Having fargate and nlb hardcoded in expose plugins i dont think ever was a good idea and all this pr really does is remove that. I agree we eventually want it to live in the provider section but we arent ready for that.
The reason we arent ready is because we need to do the better results and dependencies structs task. How are we storing dependencies of the lower level aws resources? We cant put them right back in the same dependencies map without it being over saturated and we really need a dependency tree to understand deployment order.

So this doesnt move us to the goal, youre right, but its really just code removal, theres not many additions within pulumi outside of moving the nlb code into the ecs service function. I do think if we want to move things into go we have to start picking up the ground work because we dont have the ability to support making it smarter yet IMO

so pulumi also cant switch load balancers when they are attached to the service, which is annoying, so i switched back to awsx so that we dont break anyone with an existing setup and can save all the breaking changes for later. Ran an upgrade test which would have failed


Add a Dockerfile

Signed-off-by: yeya24<EMAIL_ADDRESS>This Dockerfile is used for building the Docker image of this cli so that it can run in openshift later.

/lgtm
/approve


Error when run tutorial: 06-fused-attention.py

Hi when I run tutorial 06, it will throw some errors like below:
ENABLE_TMA=0 ENABLE_MMA_V3=0 python 06-fused-attention.py
loc(callsite(callsite("/opt/conda/envs/triton/lib/python3.9/site-packages/triton/language/core.py":1398:21 at "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py":52:35) at "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py":167:67)): error: 'triton_gpu.cmpf' op requires the same encoding for all operands and results
Traceback (most recent call last):
File "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py", line 634, in
bench_flash_attention.run(save_path=".", print_data=True)
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/testing.py", line 321, in run
self._run(bench, save_path, show_plots, print_data)
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/testing.py", line 276, in _run
ret = self.fn(**x_args, **{bench.line_arg: y}, **bench.args)
File "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py", line 615, in bench_flash_attention
ms = triton.testing.do_bench(fn, warmup=warmup, rep=rep)
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/testing.py", line 104, in do_bench
fn()
File "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py", line 610, in
fn = lambda: attention(q, k, v, causal, sm_scale)
File "/opt/conda/envs/triton/lib/python3.9/site-packages/torch/autograd/function.py", line 506, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/share/chuaijunna/code/triton/python/tutorials/06-fused-attention.py", line 458, in forward
_attn_fwd[grid](
File "", line 63, in _attn_fwd
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/compiler/compiler.py", line 476, in compile
next_module = compile_kernel(module)
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/compiler/compiler.py", line 383, in
lambda src: optimize_ttgir(ttir_to_ttgir(src, num_warps), num_stages, arch))
File "/opt/conda/envs/triton/lib/python3.9/site-packages/triton/compiler/compiler.py", line 91, in optimize_ttgir
pm.run(mod)
RuntimeError: PassManager::run failed

And the version is:
triton: 2.1.0
torch: 2.0.1
NVCC: cuda_11.8
Please help me. Thanks!

Please try triton/main?

After build by source in main branch, everything goes well! Thanks for your help.
PS: this is the my environment. Maybe some one can refer to.
cuda_12.1
torch 2.1.1

I encountered the same error this day, and I find that if we change the source code to a equal form, the compile error will not appear, link is. So I think it's may be the compiler's mistake.


server: fix 2 panics in RunPodSandbox

When running cri-tests with cri-o, I found out that cri-o panicked immediately with the following message. Fix it by accessing to the labels map only if it's non-nil.
panic: assignment to entry in nil map

goroutine 57 [running]:
.../cri-o/server.(*Server).RunPodSandbox(0xc42048e000, 0x7efcad4cd400,
0xc42066ec90, 0xc4201703d0, 0x0, 0x0, 0x0)
        .../cri-o/server/sandbox_run.go:225 +0xda5
.../cri-o/vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime
._RuntimeService_RunPodSandbox_Handler(0x21793e0, 0xc42048e000,
0x7efcad4cd400, 0xc42066ec90, 0xc4204fe780, 0x0, 0x0, 0x0, 0x0, 0x0)
        .../cri-o/vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime/api.pb.go:3645 +0x279
.../cri-o/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc420
09e3c0, 0x33e79c0, 0xc4203d1950, 0xc42080a000, 0xc4202bb980, 0x33b1d58,
0xc42066ec60, 0x0, 0x0)
        .../cri-o/vendor/google.golang.org/grpc/server.go:638 +0x99c

Also handle cases of both GetSecurityContext() and GetNamespaceOptions()  being nil. Otherwise it will panic like below:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1 pc=0x1cc43f6]

goroutine 66 [running]:
.../cri-o/server.(*Server).RunPodSandbox(0xc42060e300, 0x7f611d37a0b8,
0xc420207e60, 0xc42015e318, 0x0, 0x0, 0x0)
        .../cri-o/server/sandbox_run.go:261 +0xfe6
.../cri-o/vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime._RuntimeService_RunPodSandbox_Handler(0x2180920,
0xc42060e300, 0x7f611d37a0b8, 0xc420207e60, 0xc420505950, 0x0, 0x0, 0x0,
0x64ed0d, 0xc42064bc80)
        .../cri-o/vendor/k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime/api.pb.go:3645 +0x279
.../cri-o/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc4200a4240,
0x33f28e0, 0xc4204b0360, 0xc42074a870, 0xc420476de0, 0x33bcd38, 0xc420207e30, 0x0, 0x0)

/ok-to-test

@mrunalp @runcom PTAL

Overall this looks good.  @dongsupark Thanks.

This is awesome, thanks a lot for this!

LGTM

Hmm, thought I added an LGTM if testing, @mrunalp and @runcom were happy.   I've now I guess!

/test all

LGTM, thanks for the fix.

We get the expected failure in Fedora, will wait for RHEL to complete.

/test e2e_rhel

The e2e_rhel timed out again.

/test e2e_rhel

/test e2e_rhel

/test e2e_rhel

Since this is passing tests other then the known failure, I am merging.


Calibrated DH Parameters

The Panda-arm I'm using has a significant Cartesian error intrinsic to itself, where the expected point of the end effector is deviating >1cm from the expected position based on the standard DH parameters.
I'm assuming the robots are all calibrated before shipping, and am hoping that the associated controller hardware has the calibrated DH parameters that would account for this manufacturing tolerance. Currently the jacobian created from the standard DH parameters and the jacobian from the libfranka controller are identical, meaning that I believe that the DH parameters used in the robot controller are not the calibrated ones. Is there a way to access and use the calibrated DH parameters? Otherwise it seems impossible to use the robots to their specified accuracy.

Hi @John-HarringtonNZ ,
thank you for your feedback. Without disclosing to much internal information, while our robot has a very good repeatability in joint space, we are not that precise for the Cartesian space (as you figured out). Of course, we always try to improve but there is still room for improvement :)
Cheers,
Andreas


Adding a single relative require() call turns other calls into a crazy game of whack-a-mole in JS project with Node

Steps
mkdir ughrepro
cd ughrepro
mkdir src
code .

Create the file ./src/index.js:
// @ts-check

const net = require("net");
const path = require("path");
const readline = require("readline");
const stream = require("stream");

If at this point nothing seems off (ATA has taken effect and you can jump to definitions on each of those paths), then try reloading the editor or just wait a few seconds.
If you suddenly get errors, try inserting a space into one of the paths. That path will still be invalid but the rest will suddenly work.

What even

Workaround 😢


removing unnecessary limitation of scope to maximum 1 parameter

Fixes #
This pull introduces/changes:

scope can now take more than 1 parameter
the previous error message was very confusing if defined scope with 2 parameters and called with 2:
 wrong number of arguments (given 0, expected 1)

Pings:
@cheerfulstoic
@subvertallchris

I noticed this problem as well, this is great :+1:
I left a comment on it

Current coverage is 97.00% (diff: 100%)

Merging #1297 into master will increase coverage by <.01%

@@             master      #1297   diff @@
==========================================
  Files           199        199
  Lines         12064      12073     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          11703      11712     +9
  Misses          361        361
  Partials          0          0

Powered by Codecov. Last update 063e53b...7ffadd2


JSR and Client Side Rendering with gfm

https://github.com/denoland/deno-gfm/issues/119
We use esbuild to compile a control that is delivered to the client.  This was previously working, we just upgraded to JSR and now with the latest version of GFM (0.8.2), we are getting error:
Error: Dynamic require of "path" is not supported
    at eacIslandsClient.js?revision=1723577690368:12:9
    at<EMAIL_ADDRESS>(map-generator.js:4:43)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at<EMAIL_ADDRESS>(lazy-result.js:4:20)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at<EMAIL_ADDRESS>(postcss.js:5:18)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at<EMAIL_ADDRESS>(index.js:6:33)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at<EMAIL_ADDRESS>(mod.ts:8:26)

We are in the process of checking older version to see if they work, 0.7.0 does not seem to work either.

Uppon further look, it seems the render is working. The issue happens in mod.ts at this line:
import sanitizeHtml from<EMAIL_ADDRESS>

Yep seeing the same thing over here while attempting to integrate into a small Fresh app.


Automated cherry pick of #1057: 修复zstack绑定多个storage时重复创建disk问题

Cherry pick of #1057 on release/2.10.0.
#1057: 修复zstack绑定多个storage时重复创建disk问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@dec1485). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1058   +/-   ##
================================================
  Coverage                  ?    7.9%
================================================
  Files                     ?     356
  Lines                     ?   56351
  Branches                  ?       0
================================================
  Hits                      ?    4453
  Misses                    ?   51503
  Partials                  ?     395

Flag
Coverage Δ

#aFlag
7.9% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec1485...d94b0e1. Read the comment docs.

/lgtm
/approve


@WenchaoIOS 😂 actually there is more than I think:
FSCalendar.m

And then Xcode told me that every file needs a newline at the end:

Sorry to bother.....

Alright, that's what I thought. I don't have the latest version of Xcode right now. I'll handle it tonight.

Sure.
Be careful about XcodeGhost :p

It seems that my Xcode7.0.1 didn't come up with the warnings.

OK I got it.
In my Xcode project settings:

There is a 'Hidden local variables' and here it is 'YES', whereas in your example project it's 'NO'. This is the reason.
Resolved.

:+1:


Single quotes in README settings

Thanks for this plug-in, this is a trivial issue! I wanted to add linter options and copied the line
"fortran.linterExtraArgs": ['-Wall'],
from the README into the JSON settings. But you actually need double quotes like
"fortran.linterExtraArgs": ["-Wall"].
Same for "fortran.gfortranExecutable": '/usr/local/bin/gfortran-4.7',.

Thank you.


Images in the Canvas (Core Plugin) are also being deleted

Images which are directly added in the canvas are considered to be not in use and are getting deleted.

Hi, thanks for raising the issue.
I'll take a look at it over the weekend.

There seem to be a delay from when adding an image to the canvas until it is actually registered as having a parent (aka not unused / orphaned), this seem to be a couple of seconds.
This can be forced by saving the canvas manually.
Other than that I've not been able to entirely replicate it.

Thanks, will try to replicate it and check once more.

I can confirm this issue.
In my extensions settings i have the wildcard .* filter
If i create a canvas, and add media to it, without have that media referenced elsewhere, it clean up that media's..
P.S. Even .canvas files if not referenced/backlinked are added to cleanup. (maybe add a setting to cleanup only 0 kb files?)

Hi @00xBAD thanks for the added information about images being embedded into cards, this should allow me to replicate it and get a fix out.
As for

P.S. .canvas files if not referenced/backlinked are added to cleanup. (maybe add a setting to cleanup only 0 kb files?)
This should not be the case, but if you still see it, please create a separate issue for it and we'll take a look.

@premgowda98 I suspect the above mentioned issue is what you also saw?

I've prepared a fix for this and it will be part of v0.8.2 and should be available soon.
For now the issue will be closed but please feel free to re-open if needed.


Codelens screen cheese

VSCode Version: 1.52 Insiders
OS Version: macOS

After some refactoring, the codelens are messed up. The view zone behind the codelens is disposed (as they are gone) but the codelens is still there.
It's an interesting issue that occurred to me multiple times per month (I remember I reported similar issue before). I'm wondering if we should have some better troubleshooting helper in the editor, similar to the keybindings troubleshoot command.

Does this issue occur when all extensions are disabled?: Yes/No

I have made some changes to code lens yesterdays and also saw this today. Tho, no good steps

The view zone behind the codelens is disposed (as they are gone) but the codelens is still there.

I don't think so. In your screen capture there is blank space between line (like above 737) but it seems that the content widget is misaligned.

regression from https://github.com/microsoft/vscode/issues/16038


Extension Host - Error: Channel has been closed

Summary
I am an author of Windows VS Code extension - IIS Express for VS Code  and I have recently come across this 'Channel has been closed` detailed in the Extension Host Log output, as shown below.
Machine Info

Version 1.23.1
Commit d0182c3417d225529c6d5ad24b7572815d0de9ac
Date 2018-05-10T17:11:17.614Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Steps to Reproduce:

First run of extension works fine (Uses node to spawn process of IISExpress exe)
Close/stop the site & kill the process
Restart the site - the IIS Express .exe process never fires back up & the error below is thrown

Extension Host Error Log
[2018-06-01 17:31:59.926] [exthost1] [error] Error: Channel has been closed
    at e.validate (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:554:591)
    at e.show (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:554:379)
    at IIS.startWebsite (C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\IISExpress.js:37:22)
    at IIS.restartSite (C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\IISExpress.js:154:18)
    at C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\extension.js:60:17
    at e._executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:636:704)
    at e.$executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:637:141)
    at e._doInvokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:599:737)
    at e._invokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:599:455)
    at e._receiveRequest (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:598:529)
    at e._receiveOneMessage (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:598:298)
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:597:226
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:600:324
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:88:119
    at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:89:496)
    at Socket.<anonymous> (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:145:1008)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20) extension.iis-express.restart

Other extensions - experiencing the same
It seems with a quick google there seems to be some other users of other extensions experiencing similar issues with this Channel has been closed problem, very recently too.

https://github.com/Microsoft/vscode-jshint/issues/60
https://github.com/JakeBecker/vscode-elixir-ls/issues/73
https://github.com/redhat-developer/vscode-java/issues/533

Full Extension Host Log
[2018-06-01 17:31:36.151] [exthost1] [info] extension host started
[2018-06-01 17:31:36.190] [exthost1] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.190] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\emmet\out\extension
[2018-06-01 17:31:36.284] [exthost1] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.284] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\git\out\main
[2018-06-01 17:31:36.546] [exthost1] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.546] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\merge-conflict\out\extension
[2018-06-01 17:31:36.566] [exthost1] [info] ExtensionService#_doActivateExtension dbaeumer.vscode-eslint {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.566] [exthost1] [info] ExtensionService#loadCommonJSModule C:\Users\warre\.vscode\extensions\dbaeumer.vscode-eslint-1.4.10\client\out\extension
[2018-06-01 17:31:36.653] [exthost1] [info] ExtensionService#_doActivateExtension eamodio.gitlens {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.653] [exthost1] [info] ExtensionService#loadCommonJSModule C:\Users\warre\.vscode\extensions\eamodio.gitlens-8.3.3\out\extension
[2018-06-01 17:31:36.975] [exthost1] [info] ExtensionService#_doActivateExtension ms-vsliveshare.vsliveshare {"startup":true,"activationEvent":"*"}
[2018-06-01 17:31:36.975] [exthost1] [info] ExtensionService#loadCommonJSModule C:\Users\warre\.vscode\extensions\ms-vsliveshare.vsliveshare-0.3.246\out\src\extension
[2018-06-01 17:31:38.113] [exthost1] [info] ExtensionService#_doActivateExtension vscode.html-language-features {"startup":false,"activationEvent":"onLanguage:html"}
[2018-06-01 17:31:38.113] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\html-language-features\client\out\htmlMain
[2018-06-01 17:31:39.222] [exthost1] [info] eager extensions activated
[2018-06-01 17:31:43.495] [exthost1] [info] ExtensionService#_doActivateExtension warren-buckley.iis-express {"startup":false,"activationEvent":"onCommand:extension.iis-express.start"}
[2018-06-01 17:31:43.495] [exthost1] [info] ExtensionService#loadCommonJSModule C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\extension
[2018-06-01 17:31:59.926] [exthost1] [error] Error: Channel has been closed
    at e.validate (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:554:591)
    at e.show (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:554:379)
    at IIS.startWebsite (C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\IISExpress.js:37:22)
    at IIS.restartSite (C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\IISExpress.js:154:18)
    at C:\Users\warre\.vscode\extensions\warren-buckley.iis-express-1.1.0\out\src\extension.js:60:17
    at e._executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:636:704)
    at e.$executeContributedCommand (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:637:141)
    at e._doInvokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:599:737)
    at e._invokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:599:455)
    at e._receiveRequest (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:598:529)
    at e._receiveOneMessage (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:598:298)
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:597:226
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:600:324
    at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:88:119
    at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:89:496)
    at Socket.<anonymous> (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:145:1008)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20) extension.iis-express.restart

Seems to be coming from https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHostOutputService.ts#L68
Forwarding @sandy081

Assigned to June for investigation

@warrenbuckley Looks like you are trying to use the channel which is disposed. Can you please check your code path that you disposed your channel before you are using  it again?


Allow different section headers in consent summary screens and document

Currently the titles used in the consent summary screens are also used in the consent document, however, users have requested the ability to use a separate title in the consent document itself.

This issue is no longer relevant, as ResearchKit has deprecated ORKVisualConsentStep.


[DO NOT MERGE] Convert OpenShift SDN to a CNI plugin

Based off @danwinship's plugin reorg branch, so start with the "Use CNI for IPAM instead of docker" commit.  Not quite ready for merge yet, but I'd love feedback on the approach, especially the pod info server parts.
cc @pravisankar @rajatchopra @smarterclayton

@danwinship PTAL, thanks!

Do you guys have a design doc / writeup / proposal to cover this work?

Do you guys have a design doc / writeup / proposal to cover this work?

Yes, I'll mail you a link.

@smarterclayton after prototyping using the kube/openshift clients in the CNI plugin and discussing with @danwinship, I've decided to drop the podinfo server for now.  We may need it in the future if things become more complicated or contacting the apiserver becomes a performance issue.
I agree with your points (2) and (4) in https://github.com/openshift/openshift-sdn/pull/320#discussion_r68142557; the other points are moot with the latest commits.  We'll work on making those changes.
In the mean time, PTAL and let me know what you think.  Thanks!

@smarterclayton any thoughts on this approach?  One issue with not having communication between the CNI plugin and the openshift node process is that it somewhat complicates hostport/containerport redirect functionality (eg, like docker's "-p host:container" functionality) since the long-lived node process doesn't know when pods start/stop since the CNI plugin is now using its own k/os clients.

@liggitt any thoughts on the podinfo server vs. hitting up the apiserver directly here?

@eparis any thoughts here either?

Relevant comments are buried, so here they are:
https://github.com/openshift/openshift-sdn/pull/320#discussion_r67255635
https://github.com/openshift/openshift-sdn/pull/320#discussion_r68142557
https://github.com/openshift/openshift-sdn/pull/320#issuecomment-228480623

So I like the general approach of having CNI do more.  We may need to consider the perf impact, but it makes it truly modular rather than baked in.  Since you have the node credentials it's no worse.  If the hostPort stuff was rolled in (and it doesn't seem like there's a reason it can't be?) then it would remove the need for the node to do anything except maybe in the future be a caching proxy for the SDN tool.

Why isn't hostPort managed by cni setup and tear down?

There currently isn't any way to get two things from the CNI plugin: (a) whether it handles HostPort itself, and (b) what interface name to do the iptables SNAT/DNAT on.
We're working on some of this upstream in CNI (https://github.com/containernetworking/cni/pull/145 and https://github.com/containernetworking/cni/pull/255) and will use this functionality in the Kubernetes CNI plugin then too.

So I like the general approach of having CNI do more. We may need to consider the perf impact, but it makes it truly modular rather than baked in. Since you have the node credentials it's no worse. If the hostPort stuff was rolled in (and it doesn't seem like there's a reason it can't be?) then it would remove the need for the node to do anything except maybe in the future be a caching proxy for the SDN tool.

The HostPort is the only thing that's really icky about this right now.  I'm working to get that rolled into the kubernetes CNI network plugin but it's taking more upstream work to update the CNI spec than I thought.  But I expect that to be solved in the next month or two.

openshift-sdn is now merged into origin, so see https://github.com/openshift/origin/issues/9981 for the continuation of this PR.


Fragment / id selector with initial number doesn't work

Current behavior
#0 is invalid selector, it was valid in v2
Expected behavior
#0 should be a valid selector
Your environment
Jest
API

[ ] shallow
[x] mount
[ ] render

Version

library
version

Enzyme
3.3

React
16

Adapter

[x] enzyme-adapter-react-16
[ ] enzyme-adapter-react-15
[ ] enzyme-adapter-react-15.4
[ ] enzyme-adapter-react-14
[ ] enzyme-adapter-react-13
[ ] enzyme-adapter-react-helper
[ ] others ( )

Work around:
component.findWhere(
      n => n.prop('id') === SOME_NUMERICAL_ID,
    );

document.querySelector('#0') throws for me in safari; I'm relatively sure that it's invalid for IDs to start with numbers?

Looks like it, same in Chrome.


Calling langgraph up i get the error langgraph-api-1 | FileNotFoundError: [Errno 2] No such file or directory: '/deps/langgraph-example-pyproject/my_agent\\agent.py

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code
langgraph up

Error Message and Stack Trace (if applicable)
langgraph-api-1       | 2024-10-09T06:31:32.686169Z [error    ] Traceback (most recent call last):
langgraph-api-1       |   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 693, in lifespan
langgraph-api-1       |     async with self.lifespan_context(app) as maybe_state:
langgraph-api-1       |   File "/usr/local/lib/python3.11/contextlib.py", line 210, in __aenter__
langgraph-api-1       |     return await anext(self.gen)
langgraph-api-1       |            ^^^^^^^^^^^^^^^^^^^^^
langgraph-api-1       |   File "/api/langgraph_api/lifespan.py", line 23, in lifespan
langgraph-api-1       |   File "/api/langgraph_api/shared/graph.py", line 205, in collect_graphs_from_env
langgraph-api-1       |   File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/config.py", line 590, in run_in_executor
langgraph-api-1       |     return await asyncio.get_running_loop().run_in_executor(
langgraph-api-1       |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langgraph-api-1       |   File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
langgraph-api-1       |     result = self.fn(*self.args, **self.kwargs)
langgraph-api-1       |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
langgraph-api-1       |   File "/usr/local/lib/python3.11/site-packages/langchain_core/runnables/config.py", line 581, in wrapper
langgraph-api-1       |     return func(*args, **kwargs)
langgraph-api-1       |            ^^^^^^^^^^^^^^^^^^^^^
langgraph-api-1       |   File "/api/langgraph_api/shared/graph.py", line 233, in _graph_from_spec
langgraph-api-1       |   File "<frozen importlib._bootstrap_external>", line 936, in exec_module
langgraph-api-1       |   File "<frozen importlib._bootstrap_external>", line 1073, in get_code
langgraph-api-1       |   File "<frozen importlib._bootstrap_external>", line 1130, in get_data
langgraph-api-1       | FileNotFoundError: [Errno 2] No such file or directory: '/deps/langgraph-example-pyproject/my_agent\\agent.py'
langgraph-api-1       |  [uvicorn.error] api_revision=e09c235 api_variant=licensed
langgraph-api-1       | 2024-10-09T06:31:32.686561Z [error    ] Application startup failed. Exiting. [uvicorn.error] api_revision=e09c235 api_variant=licensed
langgraph-api-1 exited with code 3

Description
I want to test the langgraph locally fist before deploy and when i run langgraph up i get the following error langgraph-api-1 | FileNotFoundError: [Errno 2] No such file or directory: '/deps/langgraph-example-pyproject/my_agent\\agent.py. While i encountered this issue i cloned the example project from this and attepmpted to serve it up but i got the same issue. Might it be because i am using windows? But it shouldnt matter since it runs in a docker container.
System Info
langgraph.json
`
{
"dependencies": ["."],
"graphs": {
"agent": "./my_agent/agent.py:graph"
},
"env": ".env"
}
`
pyproject.toml
`
[tool.poetry]
name = "my_agent"
version = "0.1.0"
description = "Example LangGraph project for deployment to LangGraph Cloud"
authors = [
"langchain-ai"
]
packages = [
{ include = "my_agent" },
]
[tool.poetry.dependencies]
python = ">=3.9.0,<3.13"
langgraph = "^0.2.0"
langchain_anthropic = "^0.1.0"
langchain_core = "^0.2.0"
langchain_openai = "^0.1.0"
tavily-python = "^0.3.0"
langchain_community = "^0.2.0"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
`
OS Name	Microsoft Windows 10 Enterprise
Version	10.0.19045 Build 19045
❯ langchain --version
langchain-cli 0.0.31

this is the config for the other project
`
[tool.poetry]
name = "quinn_agent"
version = "0.1.0"
description = ""
readme = "README.md"
packages = [
{ include = "quinn_agent" },
]
[tool.poetry.dependencies]
python = ">=3.12,<3.13"
langchain = "^0.3.2"
langchain-openai = "^0.2.2"
langchainhub = "^0.1.21"
langchain-pinecone = "^0.2.0"
python-dotenv = "^1.0.1"
langgraph = "^0.2.34"
neo4j = "^5.25.0"
lark = "^1.2.2"
pydantic = "^2.9.2"
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
`
{     "python_version": "3.12",     "dependencies": [         "."     ],     "graphs": {         "agent": "./quinn_agent/agent.py:graph"     },     "env": ".env" }
File structure

+1

+1
I see the error like below...tryies to use npm to install for python instead of pip

[langgraph-api 3/5] RUN cd /deps/langgraph_001 && npm i:

Is this live? Still having the error on my end

This should be fixed now, but feel free to reopen if you're still running into it. We also now recommend using langgraph dev for local testing: https://langchain-ai.github.io/langgraph/tutorials/langgraph-platform/local-server/

I am Still facing the same relative path error on windows, any help would be appreciated

As a Temporary Fix, we could create a main.py in same directory as langgraph.json with
from agents.graph import create_workflow

# useful for LangGraph Server
graph = create_workflow()

And tweak the config to match the path with
    "python_version": "3.12",
    "dockerfile_lines": [],
    "dependencies": [
      "."
    ],
    "graphs": {
      "agent": "./main.py:graph"
    },
    "env": ".env"
  }

PS: This works perfectly fine for me


incorporate http and tcp/udp loadbalancing

nginx supports http and tcp/udp loadbalancing
https://www.nginx.com/resources/admin-guide/load-balancer/
https://www.nginx.com/resources/admin-guide/tcp-load-balancing/
will be nice to incorporate this with the inbuilt swarm mode in docker 1.12 to be able to loadbalance nodes in a swarm cluster using the built in loadbalancing capability of nginx
Thanks

There is also a nginx tcp proxy module available, don't know which is better but it can be interesting to have a look at this solution too


Viewer: Display most recent crawl times

This commit modifies the viewer page HTML to always show when the last crawl occurred and how long it took.
The header now includes a human-friendly message of when the last crawl happened ("Last website crawl: 2 months ago"), which links to the footer which has more detail ("Last website crawl: April 11, 2022, 4 a.m. - April 11, 2022, 6:18 a.m. (2 hours, 17 minutes and 59.27 seconds)").
TODO: I've hardcoded a bit of CSS here; when #18 comes in it introduces a separate CSS file which this should be migrated to.
Header:

Which links to footer:

@sonnakim @jenn-franklin design input welcome!

We reviewed this during team time! The team gave it 👍 👍 👍


tx-generator: fix a bug

The bug was introduced in :  #3815.
The number of total output transactions of the tx-generator was used for the number of outputs of a single transaction.
It was not found because the tests were only run for Plutus workloads and the bug was in a non-Plutus code-branch.

bors r+

bors r+

bors retry

bors r+


"Cannot read property 'subscribe' of undefined" with Nuxt implementation

vuex-persistedstate version: 3.0.1
node version: 12.13.1
npm (or yarn) version: 6.12.1

Relevant code or config
// plugins/local-storage.js
import createPersistedState from 'vuex-persistedstate'

export default ({ store, isHMR }) => {
  if (isHMR) { return }
  if (process.browser) {
    window.onNuxtReady(() => {
      createPersistedState({
        key: 'vuex',
        paths: ['my-module1', 'my-module2'],
        // ...
      })(store)
    });
  }
}

// ../nuxt.config.js
plugins: [
    { src: "~/plugins/local-storage.js", mode: "client" }
  ],

// ../store/index.js
import defaultBoard from "../static/default-board.js";
import { saveStatePlugin, uuid } from "../plugins/utils.js";
import localStorage from "../plugins/local-storage.js";

const board = defaultBoard;

export const state = () => ({
  board
});

export const mutations = {
}

export const actions = {
}

export const plugins = [
  saveStatePlugin,
  localStorage
];

What you did:
Tried to implement the vuex-persistedstate as given in ReadMe docs for NUXT.
What happened:
Got an error that cannot find "Subscribe" of undefined. (i.e. 'store' value is not defined inside onNuxtReady method)
This is generated in subscriber property of vuex-persistedstate. I think this may be a problem with Nuxt with how the value of store is passed but lets focus on the solution.
The value of store is undefined inside onNuxtReady function.

Cannot read property 'subscribe' of undefined
Reproduction sandbox:

Problem description:
Getting "Cannot read property 'subscribe' of undefined" error.
Suggested solution:
Make changes as below in local-storage plugin for vuex-persistedstate. (i.e. pass 'nuxt' as argument in onNuxtReady method then redefine "const store = nuxtj.$store".
import createPersistedState from "vuex-persistedstate";

export default ({ store, isHMR }) => {
  // if (isHMR) { return; }
  console.log("Run Process", store, process.server, process.client, isHMR);
  if (process.client) {
    console.log("Inside Local Storage1", store, process.server, process.client);
    window.onNuxtReady((nuxt) => {
      const store = nuxt.$store;
      createPersistedState({
        key: "vuex",
        paths: ["board"]
        subscriber: store => (handler) => store.subscribe(handler)
      })(store);
      console.log("onNuxtReady End");
    });
  }
};

Suggested Solution works fine.


以 $ 开头的变量使用 Tab/Enter 键补全后被删除

@sxzz Seemed to be a vuejs/repl issue, since it cannot be reproduced in local environment.

Could it be caused by @volar/monaco?

I think so

Hmmm so we should transfer the issue to https://github.com/volarjs/volar.js /cc @johnsoncodehk

Fixed by https://github.com/volarjs/volar.js/pull/69


location and regulations selections db support

OSS-side DB support for PROD-1372 and PROD-1456 .
Since this is a paid feature, the API support is in a corresponding fidesplus PR.
Description Of Changes
DB table and corresponding SQLAlchemy class for persisting state of location and regulation selections. We don't store a lot of data in the DB, at least for now: just a single-row table with two array columns to maintain the active selections.
I've included some utility class methods (both sync and async versions) for easy getters and setters of the single-record table.
Code Changes

[x] DB table migration
[x] SQLAlchemy class with utility classmethods (sync and async versions)
[x] test coverage: async tests needed to go in a different subdir to work well with our existing fixtures

Steps to Confirm

[x] we've done some pretty solid integration testing with the UI and API in the corresponding fidesplus PR and using the UI branch. we may need to make some API-level tweaks, but the DB layer seems relatively stable and should get us what we need for an initial iteration 👍

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

TODO: need to make a readme entry but want to let CI run to completion! 😬


Removing DU_DRAW_QUADS

As most of You know, nowadays, there is no QUAD primitive. Especially when You work with Core Profile OpenGL or DX. What do You guys think about removing this primitive from debug drawer ? Maybe there should be virtuals for passsing point/line/triangle/quad in duDebugDraw so engine would handle quad as a two triangles instead ?
It could be done by having branch in virtual vertex(...) and when 4th vertex comes, just split four cached vertices to two triangles. But that seems hacky to me.
Whats would be even better is to have custom isVisible in duDebugDraw that passes bounding box of current tile. This way You can hook up frustum culling when rendering debug mesh of vast views. Currently I had to duplicate most of the rendering methods from the lib to inject this frustum pass.

Appreciate this suggestion!  While this is an interesting idea I'm not certain it's the right move here.  Being able to specify quads simplifies the debug-draw calling code in multiple locations at the expense of an additional method for subclasses of duDebugDraw to implement.
The intention with debug draw code like this is mostly there just to provide hooks for games or game engines to provide their own implementations of drawing routines.  Also where it's debug draw, there's been very little effort put towards making things fast or hardened.
That being said, it's worth providing the ability for folks like you with extreme circumstances to enhance the default behavior as needed.  I feel like that flexibility is already provided with the current debug draw system.
If people wanted to re-implement the default quad drawing as a method that explicitly draws two triangles instead, I think that's a PR worth considering though!


Fix Note Bugs

LGTM! Perhaps we could take some screenshots in our PRs so that we could verify the actual behavior of the app as well?

note without any args

note with index of application shows how to use both prefixes

note with the insert prefix specifically teaches how to add

note with delete prefix specifically teaches how to delete

Duplicate prefixes in note will have the same behavior as other command prefixes

Updated to add "Invalid Command Format!" to be in line with other commands


add typechecking in js

Add typechecking approach in JS

Codecov Report

Merging #129 (778ef12) into main (46133dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   96.12%   96.12%
=======================================
  Files           5        5
  Lines         361      361
=======================================
  Hits          347      347
  Misses         14       14

Impacted Files
Coverage Δ

service/routes.py
96.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46133dd...778ef12. Read the comment docs.

IBM Cloud toolchain: Delivery Pipeline deployed wishlists to dev, including commit d0f22ba6db4452b4bf39442ae5ac8ff4eb8ff015

IBM Cloud toolchain: Delivery Pipeline deployed wishlists to prod, including commit d0f22ba6db4452b4bf39442ae5ac8ff4eb8ff015


Bugfix: Do not show professors from other schools

Description
Take "Alice Wang" for example. There are no reports for her at UTD:

However, we are currently populating with a professor of her name, but not at UTD. Since we cannot confirm that it's the same person, we should decide what to show instead.

Solutions

Could display "No UTD Professor Found. Click here for all instances of Alice Wang", which would hyperlink to the https://www.ratemyprofessors.com/search/professors/1273?q=alice wang page.

Anyone have a new example of this? Alice Wang seems to exist now in RMP making it hard to recreate and address the problem


Document and comment on the AuthService interface

I saw that checkUser was being called by some recently checked in code and thought that was strange. I wanted to find out what the difference between checkUser, checkUserPermission, and check was, so I read the implementations and filled in the documentation for those methods. I documented the other methods as well while I was at it.
While I was documenting the methods, I also included comments from points brought up during meetings about methods we don't like and might want to refactor or deprecate. This way they're down in writing in a place that's hard to miss.

Please resolve conflicts.

Please resolve conflicts.

Resolved.


Added repartition after jdbc load

resolves #53
Description
Repartition is added after the data is loaded from jdbs source. In this case dataset will be partitioned by default number of partitions instead of "splitby" used by jdbc connection.
Checklist

[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the README.md file

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f4af615). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             develop      #54   +/-   ##
==========================================
  Coverage           ?   43.61%
==========================================
  Files              ?       22
  Lines              ?      548
  Branches           ?       42
==========================================
  Hits               ?      239
  Misses             ?      309
  Partials           ?        0


fix: better handle utf8 paths in CmdExe and Powershell

Adds a function to force a shell to handle utf8 encoding. An implementation is provided for cmdexe through the use of the chcp 65001 command and something similar for Powershell.
This should fix the issue encountered here https://github.com/prefix-dev/pixi/issues/930

@wolfv Please take a closer look if you think this is the right approach.


perf: enable xxhash64 hash function by default

Summary

Enable xxhash64 hash function by default for performance.
output.hashDigestLength now defaults to 16, as the hash value generated by the xxhash64 algorithm is up to 16 characters. This can also reduce the bundle size.
Rsbuild has been using xxhash64 since v0.1, so this change will not affect Rsbuild.

Benchmark
md4 is slow when building large files, case: https://github.com/hardfist/performance-compare-ng/tree/add-big/apps/10000-big
hyperfine --warmup 1 --runs 3 'HASH_FUNCTION=md4 node --run build:rspack' 'HASH_FUNCTION=xxhash64 node --run build:rspack'
Benchmark 1: HASH_FUNCTION=md4 node --run build:rspack
  Time (mean ± σ):     11.428 s ±  0.758 s    [User: 83.504 s, System: 5.808 s]
  Range (min … max):   10.892 s … 12.295 s    3 runs

Benchmark 2: HASH_FUNCTION=xxhash64 node --run build:rspack
  Time (mean ± σ):      9.697 s ±  0.318 s    [User: 79.664 s, System: 6.127 s]
  Range (min … max):    9.374 s … 10.009 s    3 runs

Summary
  HASH_FUNCTION=xxhash64 node --run build:rspack ran
    1.18 ± 0.09 times faster than HASH_FUNCTION=md4 node --run build:rspack

Related

https://github.com/webpack/webpack/pull/14306
https://github.com/webpack/webpack/pull/14860

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

!bench

!bench


eglext_angle.h not copied at install

include\EGL\eglext_angle.h  should be copied to the install... \include like eglext.h

Hi @mediabuff
Thanks for your posting this issue.
It seems that there is no eglext_angle.h in current angle version. We need to update angle to the latest to add this header.

Also, angle_util.lib is not built - as this library is required to run angle samples

Hi @robmikh @driver1998 @isanych
Would you like to help update angle to the latest? I checked the latest source codes and found there were a lot of changes. Since I'm not familiar with this port. So could anyone help?
Thanks in advance.

Unfortunately I no longer use ANGLE for my cross-platform projects (I've moved onto wgpu), so I don't have a good way to validate a potential port update. I can't make promises about my schedule and when I may have time for this, but having a good way to validate changes would help me or whomever picks this up.

@robmikh
Thanks for your response. It doesn't matter even though you have no enough time to do this. Can you give some advice on the new version update? Maybe I can try to do some work.

I submitted a pull request that includes eglext_angle.h. The issue was caused by all header files with "EGL" in their name being excluded at the end of ports/angle/CMakeLists.txt.
Since I worked on this one before reading this issue, this PR does not solve the angle_util.lib issue or points at the up-to-date version of ANGLE.

This PR also does not let you call eglCreateDeviceANGLE directly. At least in my machine for x64-windows.
The way I currently work with it is through using eglGetProcAddress. I first call
PFNEGLCREATEDEVICEANGLEPROC createDeviceANGLE = (PFNEGLCREATEDEVICEANGLEPROC)eglGetProcAddress("eglCreateDeviceANGLE");
then use createDeviceANGLE instead of eglCreateDeviceANGLE.

@LilyWangLL Close. The header is copied according to the file list.

Now eglext_angle.h has installed to include folder of angle, so I am closing this issue for now.


Can't call node function from a thread

Godot version
4.1
System information
Windows 11, Godot 4.1.2
Issue description
Previously in Godot 4.0.0 it was possible to call functions like "get_children()" or "get_parent()" within a thread without errors (although this method wasn't thread safe I was okay with it because the functions only read data). Now (in Godot 4.1.2), as I try to call those functions an error shows up telling me to use "call_deferred". this doesn't help me solve the problem because call_deferred always returns null and I can't get any data back to the thread.
An example of the error I get:
  <C++ Error>    Condition "!is_readable_from_caller_thread()" is true. Returning: (Vector3())
  <C++ Source>   scene/3d/node_3d.cpp:249 @ get_global_position()

While it helps the code become more thread-safe I suggest to make an option to make this error a warning or simply ignore it in the project settings so that some of my older projects will continue to work in the newer versions.
Am I missing something? I couldn't find any solution other than editing long code structure and losing performance to get rid of the errors.
Steps to reproduce
I added a simple script that shows the issue with a test project:
extends Node2D

# Work-around to get the child node outside of the thread
@onready var child = get_child(0)

var a: Thread
var b: Thread

func _ready():
	# Case A shows writing and the error when reading
	a = Thread.new()
	a.start(_threaded_func_A)

	# Case B shows reading
	b = Thread.new()
	b.start(_threaded_func_B)

func _threaded_func_A():
	# In this case call deferred will work and solve the issue.
	child.call_deferred("set_visible", true)

	# Will only work in Godot 4.0.1 (tested)
	print(get_child(0).visible)

# Should print the visibilty state but doesn't
func _threaded_func_B():
	# In this case call deferred won't work and require a work-around.
	# The first call deferred will return null.
	print(call_deferred("get_child", 0).call_deferred("get_visible"))

func _exit_tree():
	a.wait_to_finish()
	b.wait_to_finish()

Minimal reproduction project
Test project:
https://filebin.net/dhp7bjgojfjrhvfl

You can use Thread.set_thread_safety_checks_enabled(false) to disable the safeguards, but then you are on your own to correctly call the methods.

Thank you @KoBeWi, this works well, unfortunately it only solves half the problem. For write calls (like add_child), the safety checks still apply and it can reduce performance in some cases forcing users to use "call_deferred".
In addition,  Thread.set_thread_safety_checks_enabled(false) can't be called from the main thread for some reason.
  <C++ Error>    Condition "::Thread::is_main_thread()" is true.
  <C++ Source>   core/core_bind.cpp:1264 @ set_thread_safety_checks_enabled()
  <Stack Trace>  main.gd:8 @ _ready()

The function must be called from a different thread like so:
var a: Thread

func _ready():
	# Testing
	a = Thread.new()
	a.start(_threaded_func_A.bind(a))  # Passing the thread as an argument to disable safety checks

func _threaded_func_A(a: Thread):
	# can only set the safety checks within a thread that isn't the main thread
	a.set_thread_safety_checks_enabled(false)

	# Will now work in Godot 4.1.2 (tested)
	print(get_child(0).visible)

	# Will only work with call_deferred (just calling the function will result an error)
	var control_node_test= load("res://control.tscn")
	call_deferred("add_child", control_node_test.instantiate())

	# This will give an error in 4.1.2
	#add_child(control_node_test.instantiate())

func _exit_tree():
	a.wait_to_finish()

I think Thread.set_thread_safety_checks_enabled(false) should also disable the write calls safety checks. Or instead, that a different function will does so. It breaks older projects and requires manual refactoring of code while also sacrificing performance. While not being thread safe, in some cases it doesn't really matter.
(I have a project that suffers from this problem, I had to refactor it which took a long time to find all the write calls. After refactoring, the performance decreased significantly.)

It breaks older projects and requires manual refactoring of code while also sacrificing performance. While not being thread safe, in some cases it doesn't really matter.

We shouldn't sacrifice thread safety because it requires work to update code that isn't safe, this isn't optional

But adding and removing nodes from the tree isn't safe, no matter if you use mutexes, that's not something you can make thread safe with those methods

Thread guards were added to allow processing nodes in threads. You can offload branches of your scene tree to a thread. This would be super brittle if it wasn't safeguarded properly.


fix(chronver): Fix chronver version_parsing regex

Fixes #1295
Context

Allows chronver release versions like '2023.03.26-latest'

Checklist

[x] Review Contribution Guidelines.
[x] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Update documentation when applicable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you! 😄


[Tutorial 1] Suggestion: use a neuroimaging viewer

Instead of matplotlib, I believe that this tutorial would be a lot more effective using nipy/niwidgets or nibabel's orthoview. The rationale is that niwidgets will allow students to navigate the 3D data.

Thanks for this suggestion. This is now resolved in #31


Fix an extra indirection in the FreeRTOS version of ErQueueTimedPopFront()

Unilaterally approving and merging. The list of reviewers are included as a "head up".


Include a diagram from Confluence

Include existing draw.io diagrams (created via Confluence-draw.io-Plugin) in the Jira tickets. The only way I found is simply putting hard hyperlinks in Jira, pointing to the Confluence pages containing draw.io charts. But would rather have the chart show up directly within the JIRA ticket:
https://desk.draw.io/a/tickets/13236

Embedding Confluence stored diagrams in Jira cloud is supported.


Add support for the STM32F071-EVAL Board

This PR adds minimal support for the STM32F072-EVAL Evaluation board.

Can the STM32 tag be added ?
Howcome I can change tags to other PRs but not mines ?? is this a wanted policy ?

Can the STM32 tag be added ?

Done

@galak I just rebased on arm branch and fixed merge conflicts, it may still conflict with #5199

@dbkinder good with doc updates?

@galak what is the status of the PR ? will it be merged ?


[SDK] - Add "getMinimumBidValue" to marketplace

Feature Description
Currently with the marketplace prebuilt contract there is no way to get the minimum bid a user must place to outbid the previous highest bid.
Let's add it!
Goal
Add a function to the marketplace smart contract called getMinimumNextBid
The logic needs to be something like this:
if (auction has current highest bid) {
  return currentHighestBid + (bid buffer * highest bid)
}
else {
  return minimum bid value
}

This must take into account Bid Buffers; i.e. the next bid must be a certain amount higher than the current highest bid.

Hi @jarrodwatts, I made a PR for this issue here


Update to docs

You need to update the docs to include adding:
'Illuminate\Html\HtmlServiceProvider', to the providers
and
'HTML'		=> 'Illuminate\Html\HtmlFacade'``` to the aliases

True, I don't know why I was under the impression adding them as dependencies would be enough. I think its because I use my boilerplate for testing and it already has them so it never errored. Would you like to make a pull request for this one?

I've created #3 which updates them

Merged


Added buffered plugin.

@patant we were tyring to use @htgc buffered plugin and it worked good.

Thanks looks like this one can be merged

Thanks, for the input. Will have a look at it today.

Thank you guys!


Run locally

update the line require('../vendor/autoload.php');
to require('../../../../vendor/autoload.php');
in stream.php and video_info.php
then run the command
php -S localhost:8000 -t vendor/athlon1600/youtube-downloader/public

I think you can create the PR for the issue :).

I think it's the instructions in the readme that are wrong. FIXED https://github.com/Athlon1600/youtube-downloader/commit/f214319026435c4c571128464a8d8404f9b3353d