[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript

Details

Migrate 'CurrencyUtils.js' lib to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/24891
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Click on the main action button -> Request Money
Select the 'Manual' option on the Request Money screen => make sure it shows the right currency
Enter the value => press next
Select user to split the money with => press add to the split
Check the split screen, and make sure the amount of money and currency are ok
Press split -> Check money request details on the chat screen

Make sure the functionality works as before.
Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Click on the main action button -> Request Money
Select the 'Manual' option on the Request Money screen => make sure it shows the right currency
Enter the value => press next
Select user to split the money with => press add to the split
Check the split screen, and make sure the amount of money and currency are ok
Press split -> Check money request details on the chat screen

Make sure the functionality works as before.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/23176449/48b8600f-01e3-4a69-97a1-91e0ccf9a7e4

Mobile Web - Chrome
https://github.com/Expensify/App/assets/23176449/07c09ed7-dbc0-4b0d-8548-5203739bd2f7

Mobile Web - Safari

https://github.com/Expensify/App/assets/23176449/4fb9c4b4-e887-492d-a7ba-75b1d8024bd9

Desktop

https://github.com/Expensify/App/assets/23176449/5debf953-d2b3-48be-81fb-8cf1a9e946fa

iOS

https://github.com/Expensify/App/assets/23176449/31ea5e3e-839c-426a-ab98-fe6c68832360

Android

https://github.com/Expensify/App/assets/23176449/1d1b6bd9-4735-4c4c-b714-c183e4a8d27b

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

LGTM though we got some merge conflicts

@arosiclair I've resolved conflicts

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Remove backoffmaxretries from pubsub.mqtt metadata spec

Describe the issue
backoffmaxretries was removed from pubsub.mqtt metadata in v1.9 (https://github.com/dapr/components-contrib/pull/1798). It needs to be updated in docs as well in both v1.9 and 1.10 branch
URL of the docs
https://v1-9.docs.dapr.io/reference/components-reference/supported-pubsub/setup-mqtt/
https://v1-10.docs.dapr.io/reference/components-reference/supported-pubsub/setup-mqtt/
Expected content
Remove backoffmaxretries from the supported metadata spec
Screenshots

Additional context

/assign


[SPARK-28382][SQL] Add array function - unnest

What changes were proposed in this pull request?

Function
Return Type
Description
Example
Result

unnest(anyarray)
set of  anyelement
expand an array to a set of rows
unnest(ARRAY[1,2])
1 2 (2 rows)

https://www.postgresql.org/docs/11/functions-array.html
unnest is not explode, but like explode recursively
postgres=# select unnest(null);
ERROR:  function unnest(unknown) is not unique
LINE 1: select unnest(null);
               ^
HINT:  Could not choose a best candidate function. You might need to add explicit type casts.
postgres=# select unnest(array[null]);
 unnest
--------

(1 row)

postgres=# select unnest(array[null, null]);
 unnest
--------

(2 rows)

postgres=# select unnest(array[array[1, 2], array[3, 4]]);
 unnest
--------
      1
      2
      3
      4
(4 rows)

postgres=# select unnest(array[array[1, 2], array[3, 4, 5]]);
ERROR:  multidimensional arrays must have array expressions with matching dimensions

Why are the changes needed?

from SPARK-27764: Feature Parity between PostgreSQL and Spark
Does this PR introduce any user-facing change?

add an array generator.
How was this patch tested?

add uts

Test build #112759 has started for PR 26279 at commit ac7e5a5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17705/
Test PASSed.

Test build #112759 has finished for PR 26279 at commit ac7e5a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnNest(child: Expression) extends UnaryExpression with Generator with CodegenFallback

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112759/
Test PASSed.

cc @wangyum thanks in advance

This is a general question; is this function common in the other DBMS-like systems? Also, is there the array pattern that unnest can't expand and explode can?  If no, we don't need explode any more when unnest implemented?

@maropu explode support map type

postgres=# select unnest(array[array[1, 2], array[3, 4]]);
 unnest
--------
      1
      2
      3
      4
(4 rows)

this case seems unsupported in this PR:
scala> sql("select unnest(array(array(1, 2), array(1, 2)))").show()
+------+
|unnest|
+------+
+------+

I will do re-check, thanks very much @HyukjinKwon

Test build #113451 has started for PR 26279 at commit a254585.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18344/
Test PASSed.

postgres=# select unnest(array[array[1, 2], array[3, 4]]);
 unnest
--------
      1
      2
      3
      4
(4 rows)

this case seems unsupported in this PR:
scala> sql("select unnest(array(array(1, 2), array(1, 2)))").show()
+------+
|unnest|
+------+
+------+

these case should be supported now with the lastest commit

Test build #113451 has finished for PR 26279 at commit a254585.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113451/
Test PASSed.

Test build #113867 has started for PR 26279 at commit b4afb80.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18735/
Test PASSed.

Test build #113867 has finished for PR 26279 at commit b4afb80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113867/
Test PASSed.

Thanks @yaooqinn. Will take a closer look soon within few days.

Test build #113996 has started for PR 26279 at commit 61b1ed1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18859/
Test PASSed.

Test build #113998 has started for PR 26279 at commit 49010d2.

Thanks @yaooqinn. Will take a closer look soon within few days.

You're welcome. And thanks very much for your patience and help.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18860/
Test PASSed.

Test build #113996 has finished for PR 26279 at commit 61b1ed1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113996/
Test FAILed.

Test build #113998 has finished for PR 26279 at commit 49010d2.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113998/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18876/
Test PASSed.

Test build #114015 has started for PR 26279 at commit 49010d2.

Test build #114015 has finished for PR 26279 at commit 49010d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114015/
Test PASSed.

close this because it seems pg only,  and other systems have their own different implementations

close this because it seems pg only,  and other systems have their own different implementations


man_pages says can't chmod

The current man cmd is set to man -c, but on my Linux system that produces the below error.
I've overridden the default to have just man %s | col -bx and it's working great now, but filing this just in case someone else hits it.
Thanks!

$ man -c printf | col -bx
man: can't chmod (null): Bad address
man: can't unlink (null): Bad address
printf.

$ man --version
man 2.10.1

Ty for the report @mikesart.
This is what -c does on my machine, the below from man's own man page:
     -c      Copy the manual page to the standard output instead of using
             less(1) to paginate it.  This is done by default if the standard
             output is not a terminal device.

My man doesn't have a -v or --version flag, I was able to get the version from the package name:
man-pages-5.13_2                        Linux Documentation Project (LDP) manual pages

Can you check if you have a mention of the -c flag does in your man version?

Mine says this:
     -c, --catman
              This option is not for general use and should only be used
              by the catman program.

Interesting there are two man versions so different. I had no idea.

Since this issue didn’t come up until now I would assume the more prevalent version is the one that supports -c, maybe we can just add a note in the README regarding the different man versions?

Turns out I have this one:
https://nongnu.org/man-db/
Which distro are you using? More for curiosity than anything else.
And sure - happy to resolve however you feel is best. I've got this fixed in my .vimrc so I'm all good. :) Thanks!

Turns out I have this one:
https://nongnu.org/man-db/

I wonder which distros use that, the -c flag also works on MacOS so I assume Apple also uses man-pages.

Which distro are you using? More for curiosity than anything else.

I'm using Void Linux, which distro are you using?

And sure - happy to resolve however you feel is best. I've got this fixed in my .vimrc so I'm all good. :) Thanks!

I'll add a note to the README in the next commit, will wait to close this issue until I do so.

I'm running Debian Testing w/ xfce. Thanks ibhagwan!
System:
  Host: mikesart-tr3 Kernel: 5.16.0-4-amd64 x86_64 bits: 64
    Desktop: Xfce 4.16.0 Distro: Debian GNU/Linux bookworm/sid
Machine:
  Type: Desktop System: Gigabyte product: TRX40 AORUS PRO WIFI v: -CF
  Mobo: Gigabyte model: TRX40 AORUS PRO WIFI
    UEFI: American Megatrends LLC. v: F4p date: 04/12/2021
CPU:
  Info: 64-core model: AMD Ryzen Threadripper 3990X bits: 64 type: MT MCP
    cache: L2: 32 MiB
Graphics:
  Device-1: AMD Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT]
    driver: amdgpu v: kernel
  Display: x11 server: X.Org v: <IP_ADDRESS> driver: X: loaded: amdgpu,ati
    unloaded: fbdev,modesetting,radeon,vesa gpu: amdgpu
    resolution: 3840x1600~60Hz
  OpenGL:
    renderer: AMD Radeon RX 5700 (NAVI10 DRM 3.44.0 5.16.0-4-amd64 LLVM 13.0.1)
    v: 4.6 Mesa 21.3.7

https://github.com/ibhagwan/fzf-lua/commit/4edaa792ff1ef07414365d7facabdac622747cc9 -  added this note above the setting:
-- NOTE: remove the `-c` flag when using man-db


Enable osquery installation in EKS worker nodes

This PR makes it possible to install and run osquery in EKS cluster nodes.
System logs from EC2 created during https://github.com/atlassian-labs/data-center-terraform/actions/runs/3223847380/jobs/5274353633:
         Starting The osquery Daemon...
[  OK  [   39.167333] audit: type=1130 audit(1665458936.178:74): pid=1 uid=0 auid=4294967295 ses=4294967295 msg='unit=osqueryd comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success'
] Started The osquery Daemon.
[   39.078458] cloud-init[3138]: Created symlink from /etc/systemd/system/multi-user.target.wants/osqueryd.service to /usr/lib/systemd/system/osqueryd.service.
[   39.149259] cloud-init[3138]: â osqueryd.service - The osquery Daemon
[   39.149339] cloud-init[3138]: Loaded: loaded (/usr/lib/systemd/system/osqueryd.service; enabled; vendor preset: disabled)
[   39.149361] cloud-init[3138]: Active: active (running) since Tue 2022-10-11 03:28:56 UTC; 73ms ago
[   39.149540] cloud-init[3138]: Main PID: 3286 (osqueryd)
[   39.149717] cloud-init[3138]: CGroup: /system.slice/osqueryd.service
[   39.149895] cloud-init[3138]: ââ3286 /opt/osquery/bin/osqueryd --flagfile /etc/osquery/osquery.flags --config_path /etc/osquery/osquery.conf
[   39.150072] cloud-init[3138]: ââ3289 /opt/osquery/bin/osqueryd
[   39.150246] cloud-init[3138]: Oct 11 03:28:56 ip-10-0-2-201.ap-southeast-1.compute.internal systemd[1]: Starting The osquery Daemon...
[   39.150433] cloud-init[3138]: Oct 11 03:28:56 ip-10-0-2-201.ap-southeast-1.compute.internal systemd[1]: Started The osquery Daemon.
[   39.150606] cloud-init[3138]: Oct 11 03:28:56 ip-10-0-2-201.ap-southeast-1.compute.internal osqueryd[3286]: osqueryd started [version=5.0.1]

Logs showed up in Splunk too.
🟢 e2e https://github.com/atlassian-labs/data-center-terraform/actions/runs/3246913405/jobs/5326234919 (can't run with the label since workflow yamls will be used from master, not this branch, so workflow kicked off manually)
Checklist

[x] I have successful end to end tests run (with & without domain) https://github.com/atlassian-labs/data-center-terraform/actions/runs/3223847380/jobs/5274353633
[x] I have added unit tests (if applicable)
[x] I have user documentation (if applicable) - added docs in Atlassian wiki as it's Atlassian only feature

In terms of the resource_tags, are you going to create another ticket to tackle it later?

Now, with a launch template in place, there's no need to tag instances and ASG. I'll create another ticket to remove this module entirely and a function from install.sh


Increase hour height to improve readability of text in 30min bookings

A lot of people are making small 30 min bookings and the text in these blocks is chopped off a bit at the bottom. Suggesting increasing the overall height to improve readability / neaten up a bit.
Before

After

15 minute meetings would still look terrible however, not sure how to resolve that (if anyone ever books one).
Feedback pls,
Ta! :)

Current spacing looks pretty bad for the Fish Bowl today as there are lots of back to back 30 minute meetings.


[BUG] Aborted by you

Every time i run it, it immediately stops and says aborted by you. The confirmation window doesn't pop up.

Sounds like a duplicate of #230 ? Maybe try what they did.

Just started to get this issue today, worked fine in the past for copy and paste version, now getting this error as well today.

I got the same

last week worked fine, but yesterday and today i got this error
someone find the solution?

Could be Feature: Remove alert(), confirm(), and prompt for cross origin iframes.
Solution would be to render an alert yourself.

Workaround for people interested:
Press F12 / open the developer tools in the "delete messages" window.
In the developer console, paste the following:
window.confirm = () => true;

Once you press start, it will work. Be careful, it will not ask for permission at all after this.


CLI should support reading JSON formatted policy sets (as opposed to single policies)

Category
CLI features/changes
Describe the feature you'd like to request
The Cedar CLI supports JSON formatted policies by passing the --policy-format json argument, but this expects exactly one policy in the JSON policy.
We recently added a JSON format for policy sets in #783, but did not add support for this format to the CLI. We should update the CLI to accept this format. It ideally should continue to accept the single policy format to avoid making an unnecessary breaking change.
Describe alternatives you've considered
.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

The actual deserializing the policy set from json appears to be easy.
About the non-breaking behaviour, the current logic looks like this:

try parsing as policy
if fails, try parsing as template
if fails, return (template parsing) error

Where in this small cascade do we want to add the "try parsing as policy set" step?

The procedure I had in mind would look at JSON attributes to decided what it needs to parse.  Something like:
Parse policies as a serde_json::Value using serde_json::from_str. Error if it is not a JSON object. Then parse based on contents of object:

If it contains any of the attributes required for JSON policies, then try to parse as a JSON policy.
If it contains any of the attributes required for JSON policy set, then try to parse as a JSON policy set.
Otherwise, error.

Ok, sounds reasonable.
If we determine that it's not a policy set, should we then call the same logic as above (parse as policy, parse as template, error)?

I would like to start development on this given we are heading the 'check if set and parse as set' path.
@memark what did you mean by coupling?
If I was to implement it that logic would remain as is, so far as I can tell

If we determine that it's not a policy set, should we then call the same logic as above (try parse as policy, try parse as template, error)?

Granted I might be missing a lot of context but happy to try this on for size

I would like to start development on this given we are heading the 'check if set and parse as set' path.

I'm actually planning to develop this myself. That's why I'm investigating and discussing the solution here. :)

@memark what did you mean by coupling?

I mean that the CLI would now know the structure of the json schema, and use it to decide what parser to call. As of right now, the CLI knows nothing about this.

@memark awesome, looking forward to your contribution. I didn't realise you were planning to develop it :)

Is it safe to have this issue closed since it's take care of? @memark @john-h-kastner-aws

@muse254 Actually, it's not implemented yet. The PR above is just a first refactoring step. I'm following up with another PR, adding the actual functionality.

I had not given the merged PR a cursory look, thats ok @memark


keytree: add serialization for xpub, xprv

Addresses https://github.com/interstellar/slingshot/issues/179

looks good, just left a bunch of stylistic rusty nitpicks

Awesome. I'm going to commit your suggestions, fix any breakages, and then make the bigger changes. Thanks very much!

Ready for an (I think) final pass!

Ready for another pass! (I will not jinx it this time by suggesting it's final.)


Warning: session_regenerate_id(): Cannot regenerate session id - session is not active

how we remove or modify this warning when user is logged in and click the change password link and after this warning redirect to login page
Warning: session_regenerate_id(): Cannot regenerate session id - session is not active
Help us with step-by-step instructions.

Duplicate of https://github.com/silverstripe/silverstripe-framework/issues/9259, please upgrade your Silverstripe version


Pass argument to extract as reference

  %3 = load %struct.Headers, %struct.Headers* %h   %4 = getelementptr %struct.Headers, %struct.Headers* %h, i32 0, i32 1   %5 = getelementptr %struct.hu, %struct.hu* %4, i32 0, i32 0   %6 = load %struct.hdr, %struct.hdr* %5   call void @extract(%struct.hdr %6)
In the above code snipped, the argument to extract function call is passed by value. I think it should be by reference so that any expression following extract will think that the argument might not be the same as the original.
What do you think?

Fixed by passing all extern functions' out params as reference


fix documentation of divergence angle

the returned divergence is the full angle not the half angle as previously implied. See definition in Kogelnik and Li, 1966, eq. 22, or the Newport Gaussian Beam Technical note (https://www.newport.com/n/gaussian-beam-optics)
Kogelnik, H., and T. Li. 1966. “Laser Beams and Resonators.” Applied Optics 5 (10): 1550–67. doi:10.1364/AO.5.001550.

Huh, good catch. The other possible fix of course would be to remove the '2' from that line, so that it does return the half angle instead of full angle. You think it's better to just change the docs? Looking through a couple different references just now it doesn't seem like people are very consistent about whether they're talking about full angle or half angle...  I'm fine with just fixing the docs to be consistent but wanted to at least ask the question.

Coverage remained the same at 65.406% when pulling 40421ae4b8fe366dcee6468756e660c7c1ca6223 on douglase:patch-1 into 569d5c60f7cf86a256c661227bd6269de4144005 on mperrin:master.

Kogelnik and Li drop the 2, as you suggest, and Newport and Verdeyen (Laser Electronics) define it as it is currently.  It doesn't look like it's called anywhere else in POPPY, I was hesitant to break anyone's code in case they were using it appropriately but I would be inclined to drop the 2 if you don't think anyone else is using it (correctly).

It doesn't look like it's called anywhere else in POPPY, I was hesitant to break anyone's code in case they were using it appropriately but I would be inclined to drop the 2 if you don't think anyone else is using it (correctly).

In that case let me ping both @maciekgroch and @corcoted, who I know are using the Fresnel code. If either of you have got a spare moment would you be so kind as to take a look at this issue, and weigh in on which way you would rather see this inconsistency fixed?  Thanks in advance!

This factor of two is inconsistent throughout the laser literature, too.  As noted above, manufacturers tend to quote to full divergence angle and scientists tend to use the half angle.  For example, the half angle is easier to use when doing paraxial propagation using the complex beam parameter equations, but the full angle is the number that the beam profiler reports.
I prefer the half angle myself, but I think either is acceptable if we're consistent and clearly document it.

@douglase in your last comment on this you said "I would be inclined to drop the 2 if you don't think anyone else is using it (correctly).", and I think we don't have any objections to doing it that way. Would you like to go ahead and modify the PR to fix is that way instead?  Either way's fine with me, I just don't want to leave this an orphan hanging PR too long (like I did to your other one!)

switched to half angle in 1c1ffca.

Coverage increased (+0.03%) to 65.432% when pulling 1c1ffca2c698e1ab8d8713de7e278121c74919a4 on douglase:patch-1 into 569d5c60f7cf86a256c661227bd6269de4144005 on mperrin:master.

Thanks! I'm going to go ahead and merge this because all the actual code tests pass, apart from the known issue of the docs not building on Travis any more.


Large Types IRGen Pass: bugfixes for global large type

radar rdar://problem/28680453
Add support for calling functions that contain a large type as the return value from inside functions that maintain the old calling conventions + Adds support for the this case when parsed as a library: handling builtin instructions.
This also resolves a test-case failure on some 32-bit targets

@swift-ci Please smoke test


Is there a hotkey feature?

It would be nice to have the ability to press shift to increase the brush size or F to go full screen, like IMG2IMG's inpaint feature. Does this feature exist, and if not, could you add it if it's not a difficult process?

fix here https://github.com/novitalabs/sd-webui-cleaner/pull/6 , please wait for the author merges


Snow updates cause mismatching snow, and different precip partitioning for coupled NoahMP and SnowModel sims

Bug Description
Three bugs were identified:

Differences in snow density between coupled NoahMP and SnowModel simulations could cause differences in the sign (positive/negative) of snow depth and SWE adjustments. This case doesn't correspond with any conditions in the snow update code, causing no change to SWE and depth.
Reductions in snow depth and SWE in the snow update code sometimes reduced the number of layers (isnow) by too much, causing reductions in SWE that were too large.
SnowModel has user-defined precipitation partitioning schemes which differ from the options within NoahMP. These cause differences in the simulated rainfall and snowfall quantities.

@sujayvkumar @karsenau
Steps have already been taken to address each of these issues. I will follow this issue with a pull request containing the suggested changes.

The first two bullet points were addressed in #1352.  The snow partitioning schemes will be updated in a subsequent PR.


Fix TextInput in dark mode: Unconditionally apply foreground color

Summary
This PR should fix a bug which fixes TextInput color being white in dark mode on iOS.
It seems like on Line 217, the intention is that if no _foregroundColor is set, it falls back to [UIColor blackColor].
However, the effectiveForegroundColor is only being applied if _foregroundColor is not nil. Therefore the fallback is never triggered in the first place. This means that NSForegroundColorAttributeName is unintentionally being set to nil, which still meant that by default the text is being rendered black. However in iOS 13, the text would be rendered in white if you have enabled dark mode.
Having a fallback to black that is never triggered makes me believe that this is a bug and that the current behavior is not intended. I am fixing the bug by removing the if statement completely as it seems to me that the effectiveForegroundColor is already sufficiently performing null checks.
Changelog
[iOS] [Fixed] - TextInput color has the same default (#000) on iOS whether in light or dark mode
Test Plan
I have applied this patch in my project and it has solved the bug that the TextInput turns white when in dark mode. I have no further plans on how to perform tests.

See Twitter for video of the bug and for further context: https://twitter.com/JNYBGR/status/1237440821445767171
This PR should also fix #27696 #27437 #27856

@shergin When the if statement is removed, it will always use the value of effectiveForegroundColor which can be seen above in the same file:
https://github.com/facebook/react-native/blob/c49e8d34350c5fb58c05040a1b9707dba9b55a0d/Libraries/Text/RCTTextAttributes.m#L216-L225

Why do you think so?

Because in the effectiveForegroundColor getter, a fallback is defined: _foregroundColor ?: [UIColor blackColor];

Why unintentionally?

I believe so because there is logic for a fallback to [UIColor blackColor] defined, however it is never being used because effectiveForegroundColor is guarded by an if statement that checks if _foregroundColor is truthy (or opacity but in this case I think it doesn't matter).

Why do you think all props are gated with ifs but this particular prop should not?

Because both _foregroundColor being falsy and _opacity being not NaN are already handled in the getter of effectiveForegroundColor.

Currently the logic is:
-> foregroundColor truthy _or_ opacity set
    true:
         use *effectiveForegroundColor*
         --> foregroundColor set?
                if false:
                        --> set to black
         --> opacity set?
                if true:
                        --> change the color to match opacity
    false:
         *use foregroundColor* (this is the buggy case, in this case it does not default to black)

I want to remove the if statement so that the logic is just:
use *effectiveForegroundColor*
 --> foregroundColor set?
        if false:
            --> set to black
--> opacity set?
        if true:
            --> change the color to match opacity

So the difference is that in the case that neither foregroundColor nor opacity is set, now the color is being set to [UIColor black] rather than foregroundColor which is nil.
Hope I did a good job explaining!

@JonnyBurger I am truly sorry, but I still cannot understand why it's the right approach to fix this problem. I understand your logic but you described how it would work in your case but not why it will work as desired in all other cases.
I see several problems here (not in your approach, in the whole problem).

Seems we have incorrect implementations of effectiveForegroundColor and effectiveBackgroundColor, these method assumes that the default is always black on white (which is clearly not the case in dark mode).
The background of the text input stays white in dark mode. Not sure why.

Note that all text attributes are applied cascadingly, they are being applied several times (directly and indirectly) to the attributed text and because of that we never should override anything there without a good reason.
I would suggest just try to explicitly set self.textColor = [UIColor blackColor]; right inside RCTUITextField constructor (exactly as we do in RCTUITextView) to override iOS defaults (which are seems change with dark/light mode).

@shergin I understand!
I will take this into consideration, go back to the drawing board and come back with a more straightforward PR solving the problem more explicitly.

Did this get resolved? I'm still seeing this issue.


Cast function dont work with GeoJSON map

When i try to cast a GeoJSON map it fails

When i do this, it works:

But i can work with Ecto because it fails the validation for cast. I dont know why is not working since in the geo_postgis code the definition is supported (?):

Thanks

Hi @pdelgadohurtado!
Can you paste the code snippets as text code? And can you also provide the error message you're getting?
Thank you!


Bot Match Action Mismatch

OS:win10
Screen Resolution: 1920x1080
Browser/Version: chrome
Link to page with the issue, or screenshot:
https://www.opendota.com/matches/2798099685/actions

The radiant is bot... and dire are my friends. However, the action data is wrongly mapped.

Bot matches have always been weird since the player slots in the replay get assigned weirdly.  If someone wants to dig into the parse output that'd be great, but consider bot matches not officially supported


Chrome web store: Browser restart issue

When I start the browser, the Audio EQ is not applied although the GUI is still at the previously set EQ. After browser restart, to make Audio EQ work, I have to hit reset and then click on the desired EQ.

I can't reproduce this. Is there a certain site it's happening on?  If that's the case you should be able to fix it by uninstalling/reinstalling or by deleting the extension's local storage from DevTools.

Its a report from google web store (https://chrome.google.com/webstore/detail/audio-eq/lfafdlnjaliaghpjdajmlcnnblkgcefh/support). I didnt had time to dig into it yet. I just added it here so I will not forget about it.

I'm facing the same issue on Chrome 47.


Force targetRevision to be always a string

Jonny had a branch called '410' and the installation broke like this:
$ make install
make -f common/Makefile operator-deploy
make[1]: Entering directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
Checking repo https://github.com/mbaldessari/multicloud-gitops.git - branch 410
https://github.com/mbaldessari/multicloud-gitops.git - 410 exists
helm upgrade --install multicloud-gitops common/operator-install/ -f values-global.yaml --set main.git.repoURL="https://github.com/mbaldessari/multicloud-gitops.git" --set main.git.revision=410 --set global.hubClusterDomain=apps.mcg-hub.blueprints.rhecoeng.com
Release "multicloud-gitops" does not exist. Installing it now.
Error: Pattern.gitops.hybrid-cloud-patterns.io "multicloud-gitops" is invalid: spec.gitSpec.targetRevision: Invalid value: "integer": spec.gitSpec.targetRevision in body must be of type string: "integer"
make[1]: *** [common/Makefile:70: operator-deploy] Error 1
make[1]: Leaving directory '/home/michele/Engineering/cloud-patterns/multicloud-gitops'
make: *** [Makefile:10: operator-deploy] Error 2

Make sure we always quote the targetRevision.
Tested and it fixed the deployment with a numeric-only branch

Hohum this actually breaks the namespaces argo:
Failed sync attempt to 0acec2c2db00a3cd2c00b45fb8d42a8eb63e90e8: one or more objects failed to apply, reason: Application.argoproj.io "acm" is invalid: spec.source.targetRevision: Invalid value: "integer": spec.source.targetRevision in body must be of type string: "integer",Application.argoproj.io "config-demo" is invalid: spec.source.targetRevision: Invalid value: "integer": spec.source.targetRevision in body must be of type string: "integer",Application.argoproj.io "golang-external-secrets" is invalid: spec.source.targetRevision: Invalid value: "integer": spec.source.targetRevision in body must be of type string: "integer",Application.argoproj.io "vault" is invalid: spec.source.targetRevision: Invalid value: "integer": spec.source.targetRevision in body must be of type string: "integer" (retried 5 times).


Add API key support to Google-Auth-Library

Add fromAPIKey method to jwtClient and supporting
logic in oauth2client.js. Applying an API key to
an instance of the oauth2client will bypass token
checking/refresh and append the given API key as
a query string to each request made from the
instance in the following form:
`{target_base_url}?key={given_key}`

cc @google/google-node-team

Coverage decreased (-1.6%) to 92.448% when pulling 189758b91c4ecec390a7de6c44cb32c21c485e60 on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage decreased (-1.6%) to 92.448% when pulling 189758b91c4ecec390a7de6c44cb32c21c485e60 on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage decreased (-1.6%)

Can we keep coverage up?

Coverage decreased (-0.4%) to 93.62% when pulling 749bccd4341bafb9a5418d6fb2ccf4f57c36f2cd on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage increased (+0.06%) to 94.102% when pulling 01c2feb3a2b129800718cf0392f2e17b7a07c86a on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage increased (+0.06%) to 94.102% when pulling 01c2feb3a2b129800718cf0392f2e17b7a07c86a on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage increased (+0.06%) to 94.102% when pulling 01c2feb3a2b129800718cf0392f2e17b7a07c86a on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

@jmdobry Code has been simplified to increase test coverage

Coverage increased (+0.06%) to 94.102% when pulling e6fd2add57c86ddcfaeddb4428dd55b05bbab541 on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage increased (+0.2%) to 94.233% when pulling 3ce2bf7d93a703ec6db2a1801750f7ecb46f1abd on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Coverage increased (+0.2%) to 94.233% when pulling 1685c648d25f624faebbecd165da47cec582b8bf on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

Added API surface is now fully exercised via automated tests.

Coverage increased (+0.2%) to 94.233% when pulling ceded2438362efb9d781c5b0a25431f50c70af8e on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

/cc @stephenplusplus

👍 created an issue to add the feature to google-auto-auth: https://github.com/stephenplusplus/google-auto-auth/issues/9

Coverage increased (+0.2%) to 94.233% when pulling 48ce2893ea305e67a540b69273a5a86b849fd624 on cristiancavalli:add-api-key-support into 48aa6ea3e7f889b21c41ef7c7f3b3d1e05b3025a on google:master.

@ofrobots updated


Package change for Eclipse Adoptium Temurin 16 binaries 🧪

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Suggested package changes for:
Vendor name change from Eclipse Foundation to Eclipse Adoptium
Product name change from AdoptiumOpenJDK to Temurin
Microsoft Reviewers: Open in CodeFlow

Ah! This is a mess. I will raise another PR later


fix(rust): change context import from ockam_node to crate

A small fix related to #2197

rebased and merged in #2266


support a fixed bond length in the MolDraw2D code

The functionality for this was added as part of 435a07a30ef7 but there is no example showing how this works in the tests. I'll add that.


feat(isthmus): support PrecisionTimestamp in isthmus

Fix #246

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Viggo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@vbarua The Dry-run release chek fails, how can I fixed it.

@vbarua All checks have passed, could you review this PR.

@vbarua thanks, it looks good to me.


Select / SelectInput Memory Leak

When the Select component is unmounted it should be GC'd.
I'm using a component that does dynamically load a Select, the first 1 to 2 times the Component containing the select is GC'd, after that the whole component will not get GC'd. (This is happening after triggering the Select).

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Parent component of the Select will not get GC'd.
Expected Behavior 🤔
Parent component(s) getting GC'd.
Steps to Reproduce 🕹

Steps:

Component to dynamically mount Select
Click Select
Re-Mount Component

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.3.0

React
16.8.6

Browser
Chrome  76.0.3809.87

TypeScript
/

etc.

@Fabbok1x Do you have a reproduction?


how to manage mount options of Azure File Volume for 'az container create'

Is your feature request related to a problem? Please describe.

I'd like to be able to manage mount options of Azure File Volume for 'az container create'.
Currently I have the following situation:
root@SandboxHost-637499546240241415:/# mount
\.file.core.windows.net<YYY> on /var/lib/pgpro/std-13/archivedir type cifs (rw,nosuid,nodev,relatime,vers=3.0,cache=strict,username=pgproassa,uid=0,noforceuid,gid=0,noforcegid,addr=<IP_ADDRESS>,file_mode=0777,dir_mode=0777,soft,persistenthandles,nounix,serverino,mapposix,noperm,rsize=1048576,wsize=1048576,bsize=1048576,echo_interval=60,actimeo=1)
Describe the solution you'd like

To have more options for this command in addition to existing ones:
--azure-file-volume-account-key  : The storage account access key used to access the Azure File share.
--azure-file-volume-account-name : The name of the storage account that contains the Azure File share.
--azure-file-volume-mount-path   : The path within the container where the azure file volume should be mounted. Must not contain colon ':'.
--azure-file-volume-share-name   : The name of the Azure File share to be mounted as a volume.
Describe alternatives you've considered

Additional context

container

any news about the issue ?
the reason I ask for this feature is that some applications/databases need specific permission for the file system
for example PostgreSQL database requires its datafiles filesystem to be owned by user 'postgres' (i.e. chown postgres:postgres) and only accessible by user 'postgres' (i.e. chmod 0700)
currently I cannot run PostgreSQL database in ACI with Azure File Volume to keep the state after ACI restarts

There are also issues on symbolic links.


Add getting started on CentOS and RHEL

Signed-off-by: Frank A. Zdarsky<EMAIL_ADDRESS>Closes #84

/lgtm


[Bug]: [Highlights] Horizontal highlights for Fill widgets are misaligned.

Objective:

Horizontal highlights should have equal gap on either side.

Highlights are horizontally aligned, moving to done.


Get status

Godday
I've been using this since it's by far the simplest KNX library to get your head around.
Though I wonder if there is possible to get the status from a group address and save it in a bool. I would like to change a few visual stuff depending on if the bus is active or not.
I've tried calling functions or setting variables from Event/Status but that does not work.
any help would be appriciated.
Edit:
"Although you can implement a wrapper function that would lock until the value expected is received"
Found this comment in a closed thread but I can't seem to make such a function. and I'm unsure of what I'm missing.
A call like this:
string state = connection.RequestStatus(address);
Is what I would like to end up with

You can request the status of a device with connection.RequestStatus(address);
This will prompt a status message to be sent over the knx bus by all devices in the group if they support that feature that will in turn fire the status delegate.
However this only works with certain devices. What I do is I use the event/status delegates. I have an object for each GA that I want to monitor and set the timestamp and data for it when the delegate fires, as well as write those things to a database for graphical display later.

That worked, thanks! unfortunately I don't have access to the code anymore since the work ended a few months ago and I forgot to post here. my bad


Fix duplicate on drag issue when dragging from flyout

Gif says it all.

(Notice how two things get duplicated and the whole block gets duplicated when dragging from the flyout)

Closing in favor of https://github.com/Microsoft/pxt/pull/4567


Seemingly high number of page faults when loading a large application.

Obsservable in startup tracing as lots of Uninterruptible Sleep (I/O) during startup. Need to figure out what's happening there and if there's anything we can do about it.
This is probably more observable in larger realistic applications - Gallery is likely not big enough to show it, but will do more investigation.
May need help form the Dart VM team on this one as well. One quick thought is to see if adding MAP_POPULATE and/or MAP_LOCKED to the VM binaries would help.

Somewhat puzzling.
If I build the app and run it on a local device, I'm not seeing the same uninterruptible sleeps. However, in the lab it's reproducing more consistently.
It does reproduce more consistently in an app that has much greater memory constraints though.

This appeared to be more related to a weird device in the lab than anything reproducible on hardware we care about.


Build with electron-packager fails with Error: Cannot find module 'package.json'

Please describe your issue:
I am getting the message "Error: Cannot find module 'package.json'" in a build for any OS.  package.json is present.  I have read threads about the same message and ensured that the Electron version is set, both in the package.json and, in testing, on the command line with --version.

Console output when you run electron-packager with the environment variable DEBUG=electron-packager. Please include the stack trace if one exists.
Please NOTE that 'gnome' is the name of my Macbook Air, not the OS that is running.
gnome:electron-quick-start Peter$ node_modules/.bin/electron-packager  . --out=dist/osx --platform=darwin --arch=x64
node_modules/.bin/electron-packager  . --out=dist/osx --platform=darwin --arch=x64
  electron-packager Electron Packager 7.5.0 +0ms
  electron-packager Node v6.1.0 +3ms
  electron-packager Host Operating system: darwin (x64) +2ms
  electron-packager Target Platforms: darwin +0ms
  electron-packager Target Architectures: x64 +0ms
module.js:440
    throw err;
    ^

Error: Cannot find module 'package.json'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.Module._load (module.js:386:25)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19)
    at getNameAndVersion (/Users/Peter/hack/electron-quick-start/node_modules/electron-packager/index.js:52:13)
    at packager (/Users/Peter/hack/electron-quick-start/node_modules/electron-packager/index.js:207:3)
    at Object.<anonymous> (/Users/Peter/hack/electron-quick-start/node_modules/electron-packager/cli.js:22:1)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
gnome:electron-quick-start Peter$

What command line arguments are you passing? Alternatively, if you are using the API, what
parameters are you passing to the packager() function?
node_modules/.bin/electron-packager  . --out=dist/osx --platform=darwin --arch=x64

Please provide either a failing minimal testcase (with code) or detailed steps to reproduce your
problem. Using electron-quick-start is a good
starting point.
Start with electron-quick-start
Add electron-packager
Run npm run pack:osx
My particular failing build is here: https://github.com/TopCat2/ElectronApp
Strangely, I was able to build at one point.  My main branch no longer builds, a checkout of an older version no longer builds, and a fresh copy of electron-quick-start and electron-packager no longer builds.  This leads me to suspect something environmental.  I am running OSC El Capitan, Version 10.11.6

Installing electron-packager globally, instead of as a dev dependency, allows me to build.  Curious.
I've been working on this for three days.  I just did yet another clone of electron-quick-start and tried the build, which failed.  I then cleaned out node_modules, removed electron-packager and electron-builder from the package.json, did an npm install and tried the build.  It worked.
I went back to my original failed directory and did the same thing.  The package worked.  So either something changed overnight or it behaves differently when installed globally.

Have you tried using electron-packager 7.5.1 (released yesterday)? That version should fix the exception you're seeing.

I'll be darned.  It does indeed work.  Is that why the -global install worked for me, that it pulled down 7.5.1?  I'll go read the comments for this version.
Many thanks!


[1.0.1] Crash when moving blocks with Funky Locomotion

I wasn't expecting it to work well on a ship, but thought I'd test in case it did work - it seems to be a rendering issue, with the entire world unloading when the block is moved, then promptly crashing. Upon loading back into the world, the blocks do seem to have been moved correctly though.
It seems to happen whether the frames moved are on a ship or not, and even if there aren't any ships currently in the world when the frames are moved. I'm not sure if this would have to be fixed on your end, or on FunkyLocomotion's.
Tested with:

Valkyrien Skies Control 1.0.1
Valkyrien Skies 1.0.0
Valkyrien Skies World 1.0.0
Funky Locomotion 1.1.2.
JEI <IP_ADDRESS>1

(for that test I had to change FunkyLoco's config to be 0 RF/block moved, since there's no RF generation in those mods, but, that shouldn't matter since it also happened when RF powered in a larger pack I found it in to start)
Using forge <IP_ADDRESS>54
crash-2020-09-27_16.28.26-client.txt

It looks like they're sending the world load event more than once, or maybe they just forgot to send the world unload event?
Either way I think VS is probably the only mod that would care about the world events so much. I can make this send a warning message instead of crashing.

Fixed in 8124fd9edb053022bfb398958ee18d14d63c5f6b


How can I use typescript types with this module?

Hi,
I'm aware this is an implementation of the node path module, but how can we use this module with typescript types?
Cheers,
Ben

import * as pathUtils from 'path-browserify';
pathUtils.join('path','filename');

import * as pathUtils from 'path-browserify';
pathUtils.join('path1', 'filename');

You mean like doing import path from 'path-browserify'? You probably have to add a typings file to your project and do something like
// path-browserify.d.ts
declare module 'path-browserify' {
  export * from 'path';
}

(Not super familiar with TypeScript so I can't guarantee that that'll work)

Thanks for getting me on the right track!
I found out you can use types like this:
// types.d.ts
declare module 'path-browserify' {
  import path from 'path'
  export default path
}

// usage
import path from 'path-browserify'
path.join(...)

Types are working!


Not working with onItemTouchListener

I have added a custom onItemTouchListener for reacting to touch events,that works well but ripple effect is all gone.Is there some sort of conflict between these two??I am pretty new to android so please dont mind if i am missing something really easy

You're right, it's maybe a conflict between this two. Today I don't have a good solution, but I'm working on it ;)


Example code seems to be broken - search method not provided

Description
I have a meilisearch server running in local.
When following the code example in my local Nextjs app :
const searchClient = instantMeiliSearch(
  'http://localhost:7700',
  '***********************'
);

const App = () => (
  <InstantSearch indexName="posts" searchClient={searchClient}>
    <SearchBox />
    <Hits hitComponent={Hit} />
  </InstantSearch>
);

const Hit = ({ hit }) => <Highlight attribute="name" hit={hit} />;

export default App;

I got the following error :

There probably must have been breaking changes on react-instantsearch.
Environment (please complete the following information):

OS: macOS 14.1.1 (23B81)
Browser: Chrome 120.0.6099.234
Meilisearch version: 1.6.0
instant-meilisearch version: 0.15.0
react-instantsearch version: 7.5.3
React version: 18.2.0

I had to destructure the instantMeiliSearch method because the searchClient is now inside it :
const { searchClient } = instantMeiliSearch( // Destructure here
  'http://localhost:7700',
  '1X-MtRbaXJHTBgk7vxOEDWoB3aNUi8r2cTvpQ_0FlBE',
);

const App = () => (
  <InstantSearch indexName="posts" searchClient={searchClient}>
    <SearchBox />
    <Hits hitComponent={Hit} />
  </InstantSearch>
);

const Hit = ({ hit }) => <Highlight attribute="name" hit={hit} />;

export default App;


[Synapse] Add endpoint Uri property to clients generated by both autorest and LLC generators

Per this feature requested for Synapse.Artifacts, add a Uri property to autorest-generated and LLC clients to aid in debugging.

Hi @mciancia8, can you please give a bit more details on why private field doesn't work for you under debugger and public property does?
Thank you!

I am not using a debugger, like working in Visual Studio. I want to be able to log the Uri to my log file for investigations in production. A lot of other azure clients do this already, like key vault, and I found it really nice to have the Uri as part of the client.


Adding x-goog-api-client

Should these be set for the admin RPCs as well?

The headers are set for admin as well. See BigtableSession.createChannelPool

Sorry, misread the code


App Version Updated As Per Design

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/opensrp/fhircore/issues/342
Type
Choose one: Feature
Checklist

[x] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[x] I have added any strings visible on UI components to the strings.xml file
[x] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[x] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

Pull Request Test Coverage Report for Build #172

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 80.207%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/org/smartregister/fhircore/activity/LoginActivity.kt
1
96.77%

Totals

Change from base Build #169:
0.03%

Covered Lines:
928

Relevant Lines:
1157

💛  - Coveralls


chore: Change the conventional commit type to fix for sdk-platform-java-config.

This PR removes the grouping of sdk-platform-java-config and gapic-generator-java. Change the conventional commit type for sdk-platform-java-config to fix.
In the future, maybe we should change all the deps update PR to fix, which is consistent with what we are doing in other repos. See relevant section in sdk-platform-java

I want to see how gapic-generator-java removal affects the behavior.

It would probably like this https://github.com/googleapis/google-cloud-java/pull/11121.


Port DH-11168: Indexing enhancements to Community.

This issue was auto-generated
PR: https://github.com/deephaven/deephaven-core/pull/3851
Author: lbooker42
Original PR Body
Port DH-11168: Indexing enhancements to Community.

Same as #77


[W6.5][W10-B2]Ong Kuan Yang

Adds button and changes font size.

@ongkuanyang
Some comments added. Please ack & close the PR after reading comments.


Small modif done in Theano version.

This allow Theano to continue to use hidden symbol by default.
This is needed to work around strange default on Mac.

Merged! Thanks a lot!


(addon/AdotCollectorAddOn): Avoiding CoreAddonProps to be filled

Describe the bug
If using CoreAddonProps, requires version to be filled
Expected Behavior
If want to use the default auto, version could be omitted
Current Behavior
Argument of type '{ namespace: string; }' is not assignable to parameter of type 'AdotCollectorAddOnProps'.   Property 'version' is missing in type '{ namespace: string; }' but required in type 'Omit<CoreAddOnProps, "saName" | "addOnName">'.
Reproduction Steps
new blueprints.addons.AdotCollectorAddOn({   namespace: "adot-collector", }),
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.134.0
EKS Blueprints Version
1.14.1
Node.js Version
v20.12.0
Environment details (OS name and version, etc.)
mac 14.3.1
Other information
No response

@Falco152 Thankyou for submitting this issue. Its a minor fix like this, Do you mind testing and submitting a PR. We will patch this.

Issue is fixed.


Invite to 4C via site

It would be cool if there was some sort of link we could visit that could redirect to 4C, (ie. join.4c.rocks or 4c.rocks/join) instead of using discord invite links, just for some branding

I want to work on this issue, please assign me.

cool! assigning

Completed.


Fixes #615 - set QD_LISTENER_BACKLOG to SOMAXCONN

Thanks, kgiusti for tip about QD_LISTENER_BACKLOG.
BTW - on F36 SOMAXCONN is 4096.
We had this backlog set to 50.
On my box this changed single-client connection rate through the router from 140 to 3400 per second.

Codecov Report

Merging #616 (982287b) into main (a841a21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   23.78%   23.78%
=======================================
  Files         117      117
  Lines       28969    28969
  Branches     4711     4711
=======================================
  Hits         6889     6889
  Misses      21157    21157
  Partials      923      923

Flag
Coverage Δ

unittests
23.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/adaptors/adaptor_listener.c
4.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a841a21...982287b. Read the comment docs.


just files for fxl6408

created this branch so i can add only the relative files to the pull request

Het lijkt erop dat je de files in de rootdirectory hebt gezet, klopt dat? Kun je ze weer zetten in de drivers map waar ze eerst stonden?

Nice! A few things still:

Please either (respond to and) 'resolve' the comments that haven't automatically been resolved by github through the code changes
I still see a merge conflict in CMakeLists, can you solve that?
You still haven't added a README file describing the current functionalities and how the driver is used by the sample application, please add that
I'm still missing some comments in the driver, describing globally what's happening (obviously doesn't have to be done for every line, but please see if there's some groups of lines that you can summarize and create a comment for).

Almost there!

Everything looks! Approved :)


Feature Request: make [In this article] navigation always visible

To navigate easier and see the progress in reading the document content, it would be nice to keep the [In this article] navigation panel (on the right) to be always visible and do not move away when I scroll down the document.

@y-dima  Please help with the link to the document on which the above document feedback request is created.
In case your query is not related to document content, open a new forum thread in Microsoft Q&A or Stack Overflow as it could be better place to get help on your scenario. These forum community members could provide their expert guidance on your scenario based on their experience. Thanks.

This is a general UX-related request related to all documents at https://docs.microsoft.com/

@y-dima This issue are specific to azure docs. I'm not sure which team to contact to share your feedback.


fix(applications-service-api): ni submission complete bug

Describe your changes
ASB-xxxx
Fix regression introduced by #850 where completing a NI submission does not set the validated field for every row in the submissions table with the given submissionId, only the first one.
The change which caused the regression has been reverted - switching the function back to updating by submissionId, rather than id.
Useful information to review or test

Prior to the change introduced in https://github.com/Planning-Inspectorate/applications-service/pull/850/files#diff-e320b91b50789dde422e5a21d6b3aae480a27ead3782b5fa2ecd5b3927b39913 - the completeSubmission function was calling updateSubmissionsBySubmissionId. When that function was moved (new name completeNISubmission), the updateSubmissionsBySubmissionId was removed in favour of updateSubmission (which updated by id, not submissionId).

Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[x] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade next v3 - v4 build error "Field 'browser' doesn't contain a valid alias configuration"

In order to upgrade stripe.js v2 to v3 (to support bitcoin donations to open source projects on Open Collective), we had to upgrade to React 16.
So we decided to upgrade nextjs v3 to v4.
But our build step fails now and can't find a solution to this. I looked at other issues.
> Using external babel configuration
> Location: "/Users/xdamman/github/opencollective/frontend/.babelrc"
> Using "webpack" config function defined in next.config.js.
(node:88335) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
> Failed to build on /var/folders/59/3lq4c4mj1wlflr5n85ky2v500000gn/T/c7e5cbb6-b690-422e-9ffa-e3c30510ead6
{ Error: ./build/components/Profile.js
Module not found: Error: Can't resolve 'next/node_modules/babel-runtime/core-js/object/get-prototype-of' in '/Users/xdamman/github/opencollective/frontend/build/components'
resolve 'next/node_modules/babel-runtime/core-js/object/get-prototype-of' in '/Users/xdamman/github/opencollective/frontend/build/components'
  Parsed request is a module
  using description file: /Users/xdamman/github/opencollective/frontend/package.json (relative path: ./build/components)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file: /Users/xdamman/github/opencollective/frontend/package.json (relative path: ./build/components)
    resolve as module
      looking for modules in /Users/xdamman/github/opencollective/frontend/node_modules/next/node_modules
        using description file: /Users/xdamman/github/opencollective/frontend/node_modules/next/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
        after using description file: /Users/xdamman/github/opencollective/frontend/node_modules/next/package.json (relative path: ./node_modules)
          using description file: /Users/xdamman/github/opencollective/frontend/node_modules/next/package.json (relative path: ./node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/xdamman/github/opencollective/frontend/node_modules/next/node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/xdamman/github/opencollective/frontend/node_modules/next/node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /Users/xdamman/github/opencollective/frontend/node_modules/next/node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of.json doesn't exist
            as directory
              /Users/xdamman/github/opencollective/frontend/node_modules/next/node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of doesn't exist```

our .babelrc: https://github.com/opencollective/frontend/blob/bitcoin/.babelrc
our package.json https://github.com/opencollective/frontend/blob/bitcoin/package.json
our next.config.js https://github.com/opencollective/frontend/blob/bitcoin/src/next.config.js
Thank you for the help!

If that's useful,  find . -name "get-prototype-of.*" returns plenty of results.
So it looks like it's trying to locate get-prototype-of.js from ./node_modules/next/node_modules/babel-runtime/core-js/object/get-prototype-of but it's in ./node_modules/next/node_modules/core-js/fn/object/get-prototype-of.js (and many other places)
Any idea how to solve this?
⚡ find . -name "get-prototype-of.*"
./node_modules/babel-runtime/core-js/object/get-prototype-of.js
./node_modules/babel-runtime/core-js/reflect/get-prototype-of.js
./node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/cuid/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/cuid/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/cuid/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/cuid/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/enzyme-adapter-react-16/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/enzyme-adapter-react-16/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/enzyme-adapter-react-16/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/enzyme-adapter-react-16/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/fbjs/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/fbjs/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/fbjs/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/fbjs/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/next/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/next/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/next/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/next/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/react/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/react/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/react/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/react/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/react-dom/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/react-dom/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/react-dom/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/react-dom/node_modules/core-js/library/fn/reflect/get-prototype-of.js
./node_modules/react-test-renderer/node_modules/core-js/fn/object/get-prototype-of.js
./node_modules/react-test-renderer/node_modules/core-js/fn/reflect/get-prototype-of.js
./node_modules/react-test-renderer/node_modules/core-js/library/fn/object/get-prototype-of.js
./node_modules/react-test-renderer/node_modules/core-js/library/fn/reflect/get-prototype-of.js

Mmmm... it works on my ubuntu machine but not on my MacOSX Sierra. I wonder what's different in the setup. Both using node v8.4.0. babel --version 6.26.0 (babel-core 6.26.0).

I figured the problem, I had to manually remove the build folder of next (in our case it's within the build directory).

I had to manually remove the build folder of next
@xdamman thanks for the info.


Crashed and shutdown

Description
When i open folder, the software just shut down.
Steps To Reproduce

Just open particular folder from the sidebar
Not always will crash but when it crash, it will happen for few times

Requirements
Fix crash that occurs when open a particular folder
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045
Log File
debug.log

Thanks for the report, Please update to <IP_ADDRESS> and see if this is still an issue. https://files.community/download


Fix user's comment may be deleted when webapp:config

Remove none comment elements of runtime node instead of remove runtime directly when users use another os, which may delete user's comments when webapp:config

Codecov Report

Merging #647 into develop will increase coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #647      +/-   ##
===========================================
+ Coverage    35.11%   35.23%   +0.12%
===========================================
  Files           74       74
  Lines         2913     2903      -10
  Branches       411      409       -2
===========================================
  Hits          1023     1023
+ Misses        1811     1801      -10
  Partials        79       79

Impacted Files
Coverage Δ

...m/microsoft/azure/maven/webapp/utils/XMLUtils.java
0% <0%> (ø)
:arrow_up:

...n/webapp/serializer/V2ConfigurationSerializer.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b562894...8244cee. Read the comment docs.


Replace debian type with deb

Per the spec the TypeDebian value should be deb (which would render pkg:deb/...) otherwise the TypeDebian value is not useful (rendering to pkg:debian/...).

Merged via https://github.com/package-url/packageurl-go/pull/28


Expose connection outside context manager

Hello,
I'm using aiosqlite and it works well for me, but I can suggest useful improvement.
Currently aiosqlite creates thread and connection when user enters created context manager and destroys thread and connection when user leaves context. It means user have to reopen database and run all connection setup pragma's every time I access database. In order to reuse connection and thread I have to invoke __aenter__ and __aexit__ directly.
Why connection reuse is important:

Database open and thread launch adds some overhead.
Statement cache is discarded when thread and connection is destroyed. Practically, with such context manager it doesn't work.

My practical use case is following: I create some pool of connections and since my journal_mode is WAL, often reads do not block each other and play well together.
Is it possible to expose connection start/stop as coroutines besides context manager?

This was added in v0.10.0.  See the updated readme for expected usage.

Thank you!


Cosmos DB Samples issue

Section link

Reason:
The input content is invalid - 'analyticalStorageTtl' is not a valid property in the current payload.
Suggestion:
Change to cosmosContainerProperties.setAnalyticalStoreTimeToLiveInSeconds(0);
@josefree, @KrzysztofCwalina, @kyle-patterson and @xinlian12 for notification.

According to kushagraThapa's rcomments in PR#31916 , after change the Azure Synapse Link to enable for the cosmos account in Portal, the test class AnalyticalStorageCodeSnippet.main runs successfully. We will close it.


[4.1.x][Feature] Upload & upload_multiple fields inside repeatable field

Because repeatable strips away the name of the inputs, it's currently impossible to use upload and upload_multiple fields inside a repeatable group. That should be fine to begin with, since we have an alternative - the browse and browse_multiple fields.
But. We should provide direct-upload support inside repeatable, somehow, without depending on third-party libraries like elFinder. Installing elFinder just to be able to upload files inside repeatable is totally overkill.
I see two possible solutions:

(A) redo the repeatable field in a way that would NOT strip out the name;
(B) create a new field that will allow us to upload files inside repeatable; and I think this is the perfect opportunity to implement a kickass dropzone field, especially since the heavy lifting has already been done in https://github.com/Gaspertrix/laravel-backpack-dropzone-field

I would like to point out that while you provide the browse and browse multiple options this is not a solution for associating data with images from a repeatable field type. For example if I wanted to add multiple images and provide a ALT tag value or a title to go along with the image. This type of functionality is not available through the browse_multiple. It simply lets you attach images.


Install Failed ree-1.8.7-2012.02 on Ubuntu 16.04

Hello,
I am trying to install rbenv install ree-1.8.7-2012.02
This is the message from terminal-
Downloading ruby-enterprise-1.8.7-2012.02.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/ecf4a6d4c96b547b3bf4b6be14e082ddaa781e83ad7f69437cd3169fb7576e42
Installing ruby-enterprise-1.8.7-2012.02...

WARNING: ruby-enterprise-1.8.7-2012.02 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

BUILD FAILED (Ubuntu 16.04 using ruby-build 20170914-2-ge40cd1f)

Inspect or clean up the working tree at /tmp/ruby-build.20180315100334.3649
Results logged to /tmp/ruby-build.20180315100334.3649.log

Last 10 log lines:
src/tcmalloc.cc:1010:47: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
   write(STDERR_FILENO, buffer, strlen(buffer));
                                               ^
src/tcmalloc.cc: In function ‘void PrintStats(int)’:
src/tcmalloc.cc:523:47: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
   write(STDERR_FILENO, buffer, strlen(buffer));
                                               ^
Makefile:3317: recipe for target 'libtcmalloc_minimal_la-tcmalloc.lo' failed
make: *** [libtcmalloc_minimal_la-tcmalloc.lo] Error 1

ree-1.8.7 is EOL status now. We couldn't support it with modern distributions.


arm-unknown-linux-gnueabihf generates dependency on GLIBC_2.28

Hi,
We're using rust-cross in our CI to generate FFI libraries for a number of targets:
https://github.com/stepfunc/dnp3/blob/refactor/jni-ci-gen/.github/workflows/ci.yml#L274
The generated GLIBC dependencies are as advertised with the exception of arm-unknown-linux-gnueabihf.  The table in the README says 2.27 for this target, whereas we have the following two 2.28 dependencies in the .so:
00000000      DF *UND*  00000000  GLIBC_2.28  fcntl
00000000  w   DF *UND*  00000000  GLIBC_2.28  statx

The full objdump.txt
Is this expected? Can the minimum required GLIBC be lowered for this target?
thanks!
Adam

The ARM toolchain referenced in the dockerfile explicitly says it contains 2.28 so maybe best to update the table from 2.27 -> 2.28.
I have a user who'd like to use our ARM cross builds on Ubuntu 18.04 which only has 2.27 and is TLS until 2028.

Thanks for the issue!
Yeah, the table is not accurate, feel free to submit a pr to correct it. We also have #591 which probably will change stuff as well, we haven't gotten to that though yet.
See #680 for a way to possibly select glibc version

@Emilgardis Thanks for these.
cargo-zigbuild is pretty fascinating. I just tried to do this locally installing it, zig, and the arm-unknown-linux-gneuabihf target.
My project has ring as an indirect dependency which has a complicated, platform-dependent build script.
  error: Unknown CPU: 'armv6'
  thread 'main' panicked at 'execution failed', /home/jadamcrain/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/build.rs:656:9

I'll take this issue over to the cargo-zigbuild project for suggestions to see if they can help.
Regardless of outcome with zigbuild, is rust-cross interested in supported older GLIBC for this architecture?

It looks like I'm hamstrung by https://github.com/ziglang/zig/issues/4911 and unable to use cargo-zigbuild until that resolves.

Regardless of outcome with zigbuild, is rust-cross interested in supporting older GLIBC for this architecture?. Not supporting Ubuntu 18.04 doesn't seem portable.

Yes, as hinted in #680, we want to try to do that

This has actually been fixed: we've lowered this (for this target only) to glibc 2.17 (see supported targets). This was part of another bug fix (reported in #426 and fixed in #734).

That's great! How often are releases done? Does it matter if the referenced docker image are updated more frequently?
I guess I'm just wondering when this fix would show up if I'm using Github actions with cross: true.

You can try it out already if you add
- run: cargo install --git https://github.com/cross-rs/cross --locked to your action
#761


Terminating app due to uncaught exception .

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** Multiple audio/video AVCaptureInputs are not currently supported.'
this happened  when I called [scannerView startCaptureSession]; again after stop the session and the capture ?
self	RMScannerView *	domain: nil - code: 0	0x15549d30 ???

@Sam-Spencer  Any update ?

Hi Omarj,
i resolved adding this code at the end of stopCaptureSession (RMScannerView.m):
[self.captureSession removeInput:videoInput];

You can solved this by
[scannerView setVerboseLogging:YES];
if ([scannerView isScanSessionInProgress]) {
[scannerView stopScanSession];
self.sessionToggleButton.title = @"Start";
} else {
[scannerView startScanSession];
self.sessionToggleButton.title = @"Stop";
}


v6 Site Search Keyboard A11y

Feature Request
Description
It would be nice to auto focus on the search field when opening the site search modal so I can immediately start typing.
It would also be nice to have arrow key (up/down) functionality to quickly select items in the search results list.
Additional Context / Screenshots
When first opening the site search modal, focus is immediately moved to the search field:

Pretend that I can browse the search list via up/down arrows:

@scottwilmarth Any thoughts on this from an accessibility perspective.

Talked with Scott and Emily about this, they are ok with shifting focus to this search input when the modal opens, but they would not recommend this pattern for more complex modals.

Resolved as far as we're going to.


Lists next to floated images lose nesting indentation

Describe the Bug
If I have text with a list beside of an image, the list entries will not change their positions at "Test #1", but in an exported PDF or Markdown file it works.
Please see attachment.

List with problems beside of an image.
List without problems with no image.

Steps to Reproduce

Add an image to a article
Change the image to "Align left"
Add some text beside of the image
Add a list with multiple tabbed items

Expected Behaviour
A list beside of an image should looks normal, like a list without an image besides of it.
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v22.07.3
PHP Version
8.1.2
Hosting Environment
Ubuntu 22.04.1 LTS, installed using official installation script.

Thanks for reporting @Android1338!
Looking into this, I've learnt some new CSS: display: flow-root. Should fix this issue since it creates a new block formatting context. Relatively new yet well supported. Will apply to lists for the next feature release.


HTTPS mode and HMR reload loop

Describe the bug
Basic install of svelte kit with the only setting being changed is adding the --https flag to the dev server start command.
The HMR websocket connection fails to connect and you end up in a refresh loop.
$ npm init svelte@next .
npx: installed 5 in 0.886s

create-svelte version 2.0.0-next.82

Welcome to SvelteKit!

This is beta software; expect bugs and missing features.

If you encounter a problem, open an issue on https://github.com/sveltejs/kit/issues if none exists already.

✔ Which Svelte app template? › Skeleton project
✔ Use TypeScript? … No / Yes
✔ Add ESLint for code linting? … No / Yes
✔ Add Prettier for code formatting? … No / Yes
✔ Copied project files

Reproduction
https://github.com/rockfreak/svelte-kit-https-issue
Logs
From chrome dev tools

Error with Permissions-Policy header: Unrecognized feature: 'interest-cohort'.

Page then refreshes
System Info
npx: installed 1 in 0.942s

  System:
    OS: Linux 5.10 Ubuntu 18.04.6 LTS (Bionic Beaver)
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 8.17 GB / 24.73 GB
    Container: Yes
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 14.18.0 - ~/.nvm/versions/node/v14.18.0/bin/node
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.0/bin/npm
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.180
    svelte: ^3.42.6 => 3.43.1

Severity
blocking all usage of SvelteKit
Additional Information
This repo has been tested on WSL2 and from within a docker container.
Both work fine in http mode but when switching into https mode hmr fails to connect.

If you search the issue tracker there are other discussions about this that should help you get it working

I tried to reproduce your issue but I couldn't.
I cloned your GitHub repository and run npm i and npm run dev on WSL2.
Surely, when I access http://localhost:3000, browser reloaded infinitely.
But when I access https://localhost:3000, browser reload didn't happen.
Could you please check it again?
I would like to know exact reproduction way.
System info
  System:
    OS: Linux 5.10 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
    Memory: 1.80 GB / 5.80 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.17.0 - /usr/local/bin/node
    npm: 7.14.0 - /usr/local/bin/npm

It's not only on https.
There is actual on http too.
I'm on a true SPA mode. All of the packages are the latest.
client.ts:28 WebSocket connection to 'ws://local.mydev.tld:24679/' failed:
[vite] server connection lost. polling for restart...

I have found that it happens from this "@sveltejs/kit": "^1.0.0-next.169",
168 working fine.

Maybe. Did you try it ?

This might be the same as https://github.com/vitejs/vite/issues/6068, which I expect will be fixed in Vite 2.9

My proxy was configured to send traffic to http instead of ws - just mentioning in case anyone finds useful coming from google

Can't reproduce the original report with kit version 1.0.0-next.304 (uses vite 2.9).  svelte-kit dev --https serves at https://localhost:3000 the site loads after confirming cert trust and hmr updates work.
@rockfreak please update and let us know if it works.