Redux issue

I have an issue as same as https://github.com/Flipkart/ReactEssentials/issues/60 but in both android and iOS (I think the problem is not depends on OS)
My rowRenderer return an element connected to redux and I need to use redux , and I put dataProvider in the mapStateToProps
Can you please provide an example that show how we can use this library with redux?

I put a log at rowHasChanged of dataProvider
(r1, r2) => {
  console.log('r1, r2',r1, r2,r1 !== r2);
  return r1 !== r2;
}

I understand that always r1 and r2 is repeated to and r1 !== r2 is always false , I change rowHasChanged to (r1, r2) => {return true} just for testing , but not solved

Only keep data in Redux store and create DataProvider inside the component that renders RecyclerListView. When data changes simply create a new one. Don't have it inside the store, that will solve it.
If this doesn't help it would be simpler if you can repro the issue on snack so that I can take a look. Here @Flipkart we already use RecyclerListView with Redux.

@naqvitalha DataProvider is not in store and is in connect , I tried inside component  too , But not working
I will provide simple repro within an hour

Please clone and run this https://github.com/sm2017/issue-68
In this line https://github.com/sm2017/issue-68/blob/master/src/App.js#L7 , I just put data as initial sate , we never ever change state in this example
https://github.com/sm2017/issue-68/blob/master/src/flights/FlightsPage.js#L90-L98 I add dataProvider to props and if state change new dataProvider is created
As you can see https://github.com/sm2017/issue-68/blob/master/src/flights/FlightData.js#L13 we have only one Green_circle Icon  , But if you scroll down , you can see duplicated

@naqvitalha I see that https://github.com/naqvitalha/travelMate without redux has same issue , Please run https://github.com/naqvitalha/travelMate when you change FlighData with  Green_circle Icon

in the example if you use this methods yo can see that error
componentDidMount() {
this.setState({
dataProvider: this.dataProvider.cloneWithRows(this._generateArray(3))
})
}
if you use it with  setTimeout
its working
componentDidMount() {
setTimeout(() => {
this.setState({
dataProvider: this.dataProvider.cloneWithRows(this._generateArray(3))
})
},2000)
}

@vvmgev Try version 1.2.0-beta.4 ... Should be fine. But know that version is under testing right now.
@sm2017 I'm looking into your issue. Will get back.

@sm2017 I checked the travelMate code, if you look at the bottom I'm using concat to make list longer. This will duplicate object references and cause the issue. I've fixed it can you try and repro now?

@naqvitalha ok thanks I will use it
and I have a small question
Now I can set  the scroll position when initializing, like scrollTo function

@vvmgev Use initialRenderOffset or initialRenderIndex while mounting. Make sure you don't mount with empty data to fully leverage it.

@naqvitalha thanks

@naqvitalha My problem is solved , I can use Redux without issue

I have just a mistake , actually this code works well
const mapStateToProps = state => {
  return {
    dataProvider: new DataProvider((r1, r2) => {
      return r1 !== r2
    }).cloneWithRows(state)
  }
}

Great.


Create a fully featured daemon with ppa

As has been discussed elsewhere. This is to continue discussion on the topic.

For anyone stumbling across this issue, https://github.com/Spotifyd/spotifyd is a good solution whilst librespot-daemon is non-existent.


fix: disable deposits on solana

Due to issues reported by our users with deposits using the Phantom wallet on the Solana network, we have decided to disable it.

:tada: This PR is included in version 2.15.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Adopt Change Policy

Doc review: https://github.com/MicrosoftDocs/data-api-builder-docs-pr/pull/85


Clean up old branches from this repository

Contributing to this repo is a bit hardened by branch clutter.

This is just a small suggestion. Feel free to close this without detailed comments if you so wish.

Good call, lots of extra branches removed.


Added public and private suffixes accordingly to subnet types

What

Added public and private suffixes to subnet names accordingly to subnet types

Why

We need an option to easily distinguish private and public subnets

Plan

I recommend never using the same value (e.g. test) for multiple fields. It makes it impossible to identify if a field was misused.


Refined composer.json to create autoloader

I refined composer.json to create autoloader and edited readme and examples as appropriate. I hope you consider to merge it as your current composer.json has no benefit.

Thanks for consideration.


🐛 fix(bal-carousel): Scroll Y on mobile blocked and Controls have wrong z index

Current Behavior
Somehow the scroll-y prop does not enable vertical scrolling for mobile devices anymore. Scrolling by touch is currently blocked. Also the controls seem to have the wrong z index since scrolled content will overlap the background (not the text content).
Overlapping controls:

Expected Behavior
The carousel should not block vertical scrolling on the page and the controls should be positioned consistently over the rest of the content.
Steps to Reproduce
Carousel with sticky tab controls and card interface. Currently used for the product packages table.
Version
15.0.2
Browsers
Firefox, Chrome, Safari, Microsoft Edge
Device
Mobile, Tablet
Code Reproduction URL
https://www.baloise.de/de/privatkunden/kfz.html
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

/cib


bugfix: oracle and postgreSQL can't query column info(#3496)

Ⅰ. Describe what this PR did
When using Oracle or PostgreSQL as the database,  can't query column info
Ⅱ. Does this pull request fix one issue?

fixes #3496
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3500 (900283b) into develop (5a09c25) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@              Coverage Diff              @@
##             develop    #3500      +/-   ##
=============================================
- Coverage      51.60%   51.57%   -0.04%
- Complexity      3390     3391       +1
=============================================
  Files            621      621
  Lines          20529    20513      -16
  Branches        2559     2514      -45
=============================================
- Hits           10594    10579      -15
+ Misses          8873     8851      -22
- Partials        1062     1083      +21

Impacted Files
Coverage Δ
Complexity Δ

...a/server/storage/db/store/LogStoreDataBaseDAO.java
76.64% <16.66%> (+5.45%)
33.00 <0.00> (+2.00)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

... and 28 more

Codecov Report

Merging #3500 (900283b) into develop (5a09c25) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@              Coverage Diff              @@
##             develop    #3500      +/-   ##
=============================================
- Coverage      51.60%   51.57%   -0.04%
- Complexity      3390     3391       +1
=============================================
  Files            621      621
  Lines          20529    20513      -16
  Branches        2559     2514      -45
=============================================
- Hits           10594    10579      -15
+ Misses          8873     8851      -22
- Partials        1062     1083      +21

Impacted Files
Coverage Δ
Complexity Δ

...a/server/storage/db/store/LogStoreDataBaseDAO.java
76.64% <16.66%> (+5.45%)
33.00 <0.00> (+2.00)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

... and 28 more


Lock/unlock icon is not updated after the unlocking process is cancelled

When you lock your wallet and then try to unlock it but abort the unlocking process, the "lock/unlock" icon in the top right corner becomes inconstant with the current status of the wallet .
Chrome / Win 7

Also, it takes 2 clicks to dismiss the "Unlock wallet" pop-up with the CANCEL button. The first time you click nothing happens.

Also, it takes 2 clicks to dismiss the "Unlock wallet" pop-up with the CANCEL button. The first time you click nothing happens.

This is already fixed, I'll update hosted wallet later today.


IOExceptions thrown by FileMatchProcessors not reported in ScanResult

ScanResult#.getMatchProcessorExceptions() doesn't capture IOExceptions thrown by a FileMatchProcessor

Fixed and released in 2.18.1. @fmarmar Thanks for the report!

You're welcome


CB-7352 Introduce 7.2.1 SDX templates

https://cloudera.atlassian.net/wiki/spaces/ENG/pages/596149312/How+to+introduce+a+new+Cloudera+Runtime+version

Do we need a similar file to 7.2.1? https://github.com/hortonworks/cloudbreak/blob/master/template-manager-cmtemplate/src/main/resources/cloudera-manager-template/cdh/7.2.json

yes, we do need the component list json

Yes, we need, that file, but this is only SDX, and for SDX it is not needed.


x86_64: "practically" thread-safe  Pool

Summary / motivation
this PR makes Pool Sync on x86_64 with the main goal of being able to test no_std code that uses Pool (e.g. via the singleton pool! macro) on x86_64 (as it's not straight forward to run tests on embedded devices, and even less to CI those tests).
Details
this PR reduces the chance of Pool running into the ABA problem (which corrupts the underlying lock-free stack) by using 32-bit version tags (search term: IBM ABA-prevention tags). Version tags do not 100% prevent the ABA problem but make it almost impossible to run into it in practice (the bigger the tag, in bits, the less the chance of running into ABA). See module level docs for details and limitations.
As this does not eliminate ABA with 100% certainty perhaps it should live behind a Cargo feature?
It seems to me that hazard pointers may be able to completely get rid of ABA but implementing those, AFAICT, require Thread Local Storage (#[thread_local]) which is not supported in no_std code.
r? @korken89

@korken89 fixed the warnings (not everything needed to be documented so I only document what was generating a warning). Do you have any thoughts on putting this behind a Cargo feature?

Awesome!
Hmm, as it is only for testing maybe just put it behind #[cfg(test)]? Else is that is not possible a cargo feature would be good.
I don't think this should be part of the official (semver) API?

Hmm, as it is only for testing maybe just put it behind #[cfg(test)]?

yeah, I don't think that would work. cargo test doesn't compile the whole dependency tree with --cfg test; it only does that for the crates in the current package.

Else is that is not possible a cargo feature would be good.

I'll add a Cargo feature.

I don't think this should be part of the official (semver) API?

by "semver" you mean that this Cargo feature could be removed in a new patch release? or something else?

(added Cargo feature and rebased)

by "semver" you mean that this Cargo feature could be removed in a new patch release?

Yeah, exactly. As it is only for internal testing I mean.

bors r+

@japaric It seems you are using ptr::cast which is unstable, could you change this one out?

@korken89 done, latest commit should fix compatibility with the MSRV

Awesome, thanks!

bors r+


Make onUnhandled safe for undefined errors

This pull request fixes cases where the error argument of the onUnhandled method in Libraries/Promise.js is undefined. Previously this would result in a redbox with the helpful message: Cannot read property message of undefined. With this pull request, unhandled promise rejections result in the desired yellowbox saying that a promise rejection went unhandled.
I still do not know what would cause the error argument to be undefined, but this change makes the module behave as expected in an app I am building.
cc @bestander
Relevant issue: #8452

By analyzing the blame information on this pull request, we identified @davidaurelio and @skevy to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@facebook-github-bot shipit

Thanks for importing.


Revert "[BZ-1322171] drools-osgi: upgrade XStream bundle from 1.4.7_1…

… to 1.4.9_1 (#471)"
This reverts commit 9a2f00b632942dfe673fff458243c55c417fef96.

+1 once the build succeeds (just to be sure).


Raft Reverse-Proxy doesn't work when UseSSL = true

This issue is similar to https://github.com/openark/orchestrator/issues/873
Actual behaviour:
When orchestrator.conf.json is configured that way:
{
  "HTTPAdvertise": "http://{{ orchestrator_hostname }}:{{ orchestrator_port }}",
  "UseSSL": false
}

Then reverse-proxy works fine and curl - D - http://{orchestrator_ip}:{orchestrator_port}/api/clusters request returns correct information about known clusters both for a raft leader and its followers.
But when it is configured that way:
{
  "HTTPAdvertise": "https://{{ orchestrator_hostname }}:{{ orchestrator_port }}",
  "UseSSL": true
}

Then curl -D - -k https://{orchestrator_ip}:{orchestrator_port}/api/clusters request returns correct information only if it was sent to a raft leader. If it's sent to a follower, it returns 502 Bad Gateway and Orchestrator logs say: remote error: tls: bad certificate.
Expected behaviour:
reverse-proxy should work properly, so any follower should be able to provide requested information from its leader.
Root cause analysis:
https://github.com/openark/orchestrator/blob/f818d8a135667574a14b4a3cb33dacb54f330dab/go/http/raft_reverse_proxy.go#L46-L47
Creates a new proxy without any HTTP transport and starts serving HTTP . Since no transport is configured, a default HTTP transport is created automatically:
   func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
   	transport := p.Transport
    	if transport == nil {
    		transport = http.DefaultTransport
    	}

This works when SSL is disabled, but it breaks routing logic in the middle when it is enabled.
Workaround:
Sending all requests directly to a raft leader works pretty well both with and without SSL.
Solution proposal:
A suitable HTTP transport is already being created for raft health requests:
https://github.com/openark/orchestrator/blob/f818d8a135667574a14b4a3cb33dacb54f330dab/go/raft/http_client.go#L37-L68
This code can be reused to get a proper HTTP transport for a reverse-proxy as well.

also possibly related to #979?

also possibly related to #979?

I don't really think so. It is about authentication and this issue is about wrong TLSClientConfig for Proxy transport.
Followers' logs were saying remote error: tls: bad certificate and leader's logs were saying: x509: certificate signed by unknown authority. And I don't have AuthenticationMethod set at all, so it's basically none.
The proposed PR was tested "manually" on a 3-members cluster and it solved the issue for me.

fixed by https://github.com/openark/orchestrator/pull/1344


Setup testing the dotfiles

GitHub actions have support for macos (https://help.github.com/en/github/automating-your-workflow-with-github-actions/virtual-environments-for-github-actions#supported-virtual-environments-and-hardware-resources).
Let's leverage this to see if entire Ansible run works.
The tests

[ ] does gpg work when installing Spacemacs
[ ] is custom shell /usr/local/bin/zsh set in the shell
[ ] are paths correct in shell and Spacemacs
[ ] does SSH / git work from Spacemacs
[ ] does the bootstrap script work
[ ] is brew in front of the asdf paths
[ ] is /usr/bin after asdf paths (so we're not using system Ruby)

Example to programmatically open a tab in iTerm2
osascript -e 'tell application "iTerm" to activate' -e 'tell application "System Events" to tell process "iTerm" to keystroke "t" using command down'


Add headless Chrome parameters to work on ResinCi

Change-type: minor
See: https://github.com/resin-io/resin-concourse/pull/248/
See: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-on-alpine
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>

Mocked a Dockerfile in resin-auth to run the tests as resin-ci would do and testing on Chrome worked out of the box :)


[5.8] Sema: Lift restriction requiring decls with @_backDeploy to have explicit availability

Cherry pick of https://github.com/apple/swift/pull/62876
Swift Evolution has concluded that it is inappropriate to require decls with @_backDeploy to also have explicit availability. Lift the restriction and assume declarations with no explicit availability are back deployed as far as possible.
Lifting a simultaneous attribute restriction sounds like it should be an easy task, but that was not the case here. The diagnostics for availability conflicts with the back deployment before: version were greatly simplified by the assumption that an explicit @available attribute would be present. With the removal of the restriction the implementation of the diagnostics had to be enhanced to look for both inherited availability and unavailability.
Additionally, this PR fixes a bug that would have caused the wrong @_backDeploy attribute to be used when attributes for both iOS and macCatalyst are present.
Resolves rdar://103880356

@swift-ci please test


Pager looks busted after 20 pages.

Go to: http://pub.dartlang.org/packages?page=24
It looks horrendous. We should probably put ellipses in the middle of the pager.

This issue has been moved to dart-lang/pub#505.


Reflected time on some segments of SensorGlucoseReadingsEvent

This issue is probably a remnant of issue #28, which indicates that that issue was only partially solved.
In the graph included in the screenshot below, observe the sensor glucose values from time -40 min. to 0 min. There can be observed two sequences of five and three points, which are separated by apparant discontinuities. If those two sequences are reflected in time around their respective centres, the whole graph becomes continuous, up to discretization.
Especially note the earliest (~7 mM) and latest (~8 mM) values of the latest segment, and note the current SG value (7.10 mM) at the top if the image. The current value should correspond to the latest value in the graph, but instead it corresponds to the first value in the latest segment of the graph. If that segment was reflected in time around it's centre, there would be a match.
It is further clear, that not all segments, presumably each contained in a SensorGlucoseReadingsEvent object, should be reflected in time. The main trajectory leading up to t = -40 min is a segment which should not be reflected. When looking into the data structures, I find no obvious data element to tell, whether a segment should be reflected or not.

The following patch solves the issue for me.
diff --git a/pump_history_parser.py b/pump_history_parser.py
index a94d397..e371faf 100644
--- a/pump_history_parser.py
+++ b/pump_history_parser.py
@@ -397,7 +397,7 @@ class SensorGlucoseReadingsEvent(NGPHistoryEvent):

     def allNestedEvents(self):
         pos = 15
-        for i in range(self.numberOfReadings - 1, -1, -1):
+        for i in range(self.numberOfReadings):^M
             #const timestamp = new NGPUtil.NGPTimestamp(this.timestamp.rtc - (i * this.minutesBetweenReadings * 60), this.timestamp.offset);
             timestamp = self.timestamp - timedelta(minutes = i * self.minutesBetweenReadings)
             payloadDecoded = struct.unpack( '>BBHBhBB', self.eventData[pos:pos + 9] )

In addition, for using read_minimed_next24.py as a module, I would like to suggest the following patch:
diff --git a/read_minimed_next24.py b/read_minimed_next24.py
index 380126a..ab6a19a 100644
--- a/read_minimed_next24.py
+++ b/read_minimed_next24.py
@@ -1,8 +1,10 @@
 #!/usr/bin/env python

 import logging
-# logging.basicConfig has to be before astm import, otherwise logs don't appear
-logging.basicConfig(format='%(asctime)s %(levelname)s [%(name)s] %(message)s', level=logging.WARNING)
+
+if __name__ == '__main__':
+    # logging.basicConfig has to be before astm import, otherwise logs don't appear
+    logging.basicConfig(format='%(asctime)s %(levelname)s [%(name)s] %(message)s', level=logging.WARNING)
 # a nasty workaround on missing hidapi.dll on my windows (allows testing from saved files, but not download of pump)
 try:
     import hid # pip install hidapi - Platform independant


fix 404 link on devel landing page

reported here: https://github.com/mne-tools/mne-python/pull/12309#issuecomment-1863180667
also closes #12312

self-merging as I checked the doc render after the first commit, and the link worked


feat: add commit hash to comments

Resolves #663

Can you open a pull request on your fork and link it here to prove that it works? Otherwise can you post any other proof that it works?

Can you open a pull request on your fork and link it here to prove that it works? Otherwise can you post any other proof that it works?

Please check this PR: https://github.com/PhantomCracker/ubiquity-dollar/pull/7

I don't see the commit hashes there. What are you showing with your linked pull request? I'm not asking to see the code. I'm asking to see proof that it works according to the spec.

@pavlovcik recheck the PR please; here is also the proof of testing:

I don't see any comments posted by the bot with the commit hashes on your fork.

Ok, I think that everything is ok now; i have a issue on my side with that Netlify, but i think that you can generate some logs to see if everything is ok here.
Thank you.

As far as I understand this issue required to convert netlify deploy URL from Deployment: Mon May 29 2023 10:18:51 (UTC) to Deployment: Mon May 29 2023 10:18:51 (UTC) | Commit: c123456
@PhantomCracker could you show how it works in your forked environment?

@rndquu can you help with how can I do a deployment message on my fork like this?

As far as I understand this issue required to convert netlify deploy URL from Deployment: Mon May 29 2023 10:18:51 (UTC) to Deployment: Mon May 29 2023 10:18:51 (UTC) | Commit: c123456
@PhantomCracker could you show how it works in your forked environment?

I think only the seven character commit hash is sufficient. Time stamps can be derived from the edit history times. But time stamps seem not particularly useful in my experience.

@rndquu can you help with how can I do a deployment message on my fork like this?

I guess you should add netlify app to your forked environment and use your own github PAT here for testing purposes

I always receive this error on my fork:

Maybe we can wait for another deployment message?

I always receive this error on my fork:  Maybe we can wait for another deployment message?

I guess here you need to setup the NETLIFY_SITE_ID_DEVELOPMENT env variable in your github secrets

@rndquu i come back with another question, what access does cloudflare need for the CLOUDFLARE_API_TOKEN?

There is a template called Edit Cloudflare Workers . You could use this one on API token generation.

@rndquu  can you also please provide these two secrets?
secrets.UBIQUITY_BOUNTY_BOT_APP_ID
secrets.UBIQUITY_BOUNTY_BOT_PRIVATE_KEY

@rndquu can you also please provide these two secrets? secrets.UBIQUITY_BOUNTY_BOT_APP_ID secrets.UBIQUITY_BOUNTY_BOT_PRIVATE_KEY

You should setup you own bot's instance and set your own env values for UBIQUITY_BOUNTY_BOT_APP_ID and UBIQUITY_BOUNTY_BOT_PRIVATE_KEY

Please check the following GH action results: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5445801433/jobs/9905580034
Here is also a screenshot:

@PhantomCracker pls check this PR https://github.com/rndquu/ubiquity-dollar/pull/20
It prints [Deployment: Tue Jul 04 2023 08:22:14 (UTC) | Commit: 2c143d6c0018b081b8b8c865e6d9ff0647763c4a](https://a630927c.ubiquity-dollar-1cd.pages.dev/) but the latest commit hash is a82e8ca6894d37b50a3a336352362afb49e15101. So they are expected to match.

@PhantomCracker pls check this PR rndquu#20
It prints [Deployment: Tue Jul 04 2023 08:22:14 (UTC) | Commit: 2c143d6c0018b081b8b8c865e6d9ff0647763c4a](https://a630927c.ubiquity-dollar-1cd.pages.dev/) but the latest commit hash is a82e8ca6894d37b50a3a336352362afb49e15101. So they are expected to match.

Thank you for feedback, work in progress!

Hm... @rndquu i come back with different tests:
https://github.com/PhantomCracker/ubiquity-dollar/commit/dcd6a09fd116d210b173ca8569b94c8a1ab40a83#comments
and https://github.com/PhantomCracker/ubiquity-dollar/commit/6d39638c6e1a746a1db66b1df97133f01a497208#comments
I have also tried to create a new PR to test this: https://github.com/PhantomCracker/ubiquity-dollar/pull/8
As you can see, the SHA is:  a3b4d077cb2000fa5862d382856cb514c4054812 which is the same as in this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453519281/jobs/9922468500
But the last commit have the following SHA: 975a32998e1f9fee285bc2a038090ffe06d6ea05 which corresponds to this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453525015/jobs/9922481199
The difference between these two is that on the first action, we display the SHA for the PR, while on the second we display the SHA for the commit https://github.com/PhantomCracker/ubiquity-dollar/commit/975a32998e1f9fee285bc2a038090ffe06d6ea05#comments
Is this the expected functionality?

Hm... @rndquu i come back with different tests: PhantomCracker@dcd6a09#comments and PhantomCracker@6d39638#comments
I have also tried to create a new PR to test this: PhantomCracker#8 As you can see, the SHA is: a3b4d07 which is the same as in this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453519281/jobs/9922468500 But the last commit have the following SHA: 975a329 which corresponds to this action: https://github.com/PhantomCracker/ubiquity-dollar/actions/runs/5453525015/jobs/9922481199 The difference between these two is that on the first action, we display the SHA for the PR, while on the second we display the SHA for the commit PhantomCracker@975a329#comments
Is this the expected functionality?

pls merge the latest development branch and try again, commit hashes should be the same now

Indeed it works! 👍 🥳
Proof of testing: https://github.com/PhantomCracker/ubiquity-dollar/pull/9

I hope you verified that the way you're deriving the seven character SHA matches what GitHub displays or ill have to revert this.

I hope you verified that the way you're deriving the seven character SHA matches what GitHub displays or ill have to revert this.

For dcd6a09fd116d210b173ca8569b94c8a1ab40a83 we will display dcd6a09.
Please let me know if something is wrong and I will fix it 😄


Get MeSH for multiple PMIDs

This PR adds a new function (and related test) for getting MeSH identifiers for multiple articles by PMID.
Example:
from indra_cogex.client.queries import get_mesh_ids_for_pmids

pmids = ["27890007", "27890006"]
mesh_ids = get_mesh_ids_for_pmids(pmids, client=client)
>>> mesh_ids
{
   "27890007": ["D000544", ...],
   "27890006": [ ... ]
}

@bgyori this is done and unit tested


custom integration between WooCommerce Subscriptions and Thawani Pay

السلام عليكم
I would like to inquire! Can this plugin be activated with WooCommerce Subscriptions? And is it possible to guide me on how to do this or provide an update for this plugin to make it possible to use it with WooCommerce Subscriptions?
Thank you.

Hi @k6111  Thanks for reaching out to us
Subscriptions offer two methods for handling renewals Automatic renewal and Manual renewal which one is that you need to use

السلام عليكم
I would like to inquire! Can this plugin be activated with WooCommerce Subscriptions? And is it possible to guide me on how to do this or provide an update for this plugin to make it possible to use it with WooCommerce Subscriptions? Thank you.

Hey @k6111  no the plugin does not support WooCommerce subscription plugin.

@w7shdev thank you ..
Is there an upcoming plan to develop the plugin to support WooCommerce subscriptions?

No there isn't at the moment and the reasons are :
From the product perspective thawani-for-woocommerce plugin :

Adding extra feature most of the users do not need them.
WooCommerce subscription is paid plugin and this one is open source and free.
We can not provide license keys for paid product for all the contributors. Which leads to make this product a commercial one.

Development here is what will happen when you maintain 1 plugin that requires or support 2 plugins:

Implementation of 2 checkout logic
keep up to date with plugins update and this one to make sure that the plugin will work without any issue.

and there are many more reasons for not adding this as a feature to the plugin.

Do you have any tips that might help me enable payment or subscription in Omani Rial for WooCommerce subscriptions?

Well, you will need to build a new one, you can use this plugin for starting point!

@k6111 There are many limitations with Omani(s) payments gateways (PG), myself, I don't use any of the Omani PG, I always push my clients to use GCC PG like
https://paymentservices.amazon.com/
or
https://www.tap.company/kw/en
Although they ask for extra fees per transaction or monthly subscription, but at least with the above payment gateways, you can get official SDKs (or plugins) from the provider themself, and no need to chase developers to re-invent the wheel again and again. Also I can get quick support when needed.
also there are many other features you will get like subscriptions OR other feature like in-app entering card details for better UX for the app. and many more.
I can see Omani payment gateway providers are still not up-to-date for that market need, they have totally different perspective about how the payment gateway should look like which is totally different from the global.
in the other hand, until now there is no initiatives for putting OMR as currency for processing payment in an International Payment gateways like Paypal, https://www.2checkout.com/ or https://stripe.com/
for example, the Talabat app uses https://paymentservices.amazon.com/
therefore I advise you to contact https://paymentservices.amazon.com/ support and discuss with them the implementation of subscription.
https://paymentservices.amazon.com/  support Omani riyal and they transfer the amount to Omani National bank (NBO).

@k6111
You need to understand very important point about the subscription, it is not about asking someone to develop it for you, it is about does the payment gateway support the subscription?
The answer is thawani is not supporting the subscription , you can contact them via support WhatsApp number to ensure this..

@k6111 i advise you to contact https://paymentservices.amazon.com/
They have subscription feature, you can ask them to provide you plugin for WooCommerce that supports subscription.
You need to open account at National Bank Of Oman in order to register with them ..

Not all payments gateway around the world support subscription feature even if the WooCommerce feature allows..
All Omani payment gateways don't suppose subscription.
Enabling the subscription feature cost the companies or organisation lots of fees by the providers (visa and MasterCard). Thus only the BIG companies/organisation around the world support subscription features.

I know many websites here in oman uses payments gateways from GCC
Note that Amazon payments services  https://paymentservices.amazon.com/ located in UAE/KSA and it supports OMR.
Another option is to use https://tap.company it supports OMR as well.
I tested both of them

@k6111 also https://paymentservices.amazon.com/ support in-app entering card information, so no redirect happen in your website/mobile app. This gives better UX for your end users.

@k6111 if the issue is not solved yet!

"Error processing checkout. Please try again." I am using version 1.3.0.

please check this comment here https://github.com/PhazeRoOman/thawani-for-woocommerce/issues/90#issuecomment-1221318338 and if it's not please open a new issue.
Best of luck


Python 3.12 support without

When used with Python 3.12 we can see a lot of warnings, such as:
/var/task/index.py:20: SyntaxWarning: invalid escape sequence '\d'
std_matcher = re.compile("\d\d\d\d-\d\d-\d\d\S+\s+(?P<requestID>\S+)")

This is not urgent as there is no EOL planned by AWS for the python3.9 runtime yet

hey @vhiairrassary can you try the new version, I think the problem should be solved since I switched to raw strings.


release v0.8.1

merge after #577 & #601 closed
Signed-off-by: Wang Xu<EMAIL_ADDRESS>

retest this please, hykins


Adding French language fr.json

Hi ngocjohn,
Thank you very much for your lovelace!
I am a French user with a Mercedes vehicle, HA and MercedesME 2020... This is the minimum to use this Lovelace!
This is my very first Git contribution and I hope I do the right step...
Some translations are not necessarily obvious. I tried to rely on the excellent work of @Renenuischde and also on the Mercedes app on iPhone.

I can propose to regularly follow the developments and continue to contribute to developing, adding or adapting this Lovelace translation for the French public.
Any criticism or help to find the fairest words are welcome!
With my best greetings
Joebar16

Hi, thanks for the PR, the added localization will be in the next release!  ❤


oculus request 2 , only black screen displayed

oculus request 2
macOS install scrcpy
brew install scrcpy
run scrcpy
$scrcpy
/usr/local/Cellar/scrcpy/1.16/bin/scrcpy ; exit;
2020-12-30 13:03:35.192 scrcpy[19631:953439] INFO: scrcpy 1.16 https://github.com/Genymobile/scrcpy
/usr/local/Cellar/scrcpy/1.16/share/sc...hed. 16.7 MB/s (33622 bytes in 0.002s)
[server] INFO: Device: Oculus Quest 2 (Android 10)
2020-12-30 13:03:35.430 scrcpy[19631:953439] INFO: Renderer: metal
2020-12-30 13:03:35.433 scrcpy[19631:953439] INFO: Initial texture: 3664x1920
screen is black whatever headset on head of off.

https://github.com/Genymobile/scrcpy/issues/1991#issuecomment-751723795


Download links pointing to unreleased version

Description
Right now the public docs are pointing to downloading the community edition are pointing to an unreleased version.
Location
The public docs page - https://tanzucommunityedition.io/docs/latest/cli-installation/
The code (for mac) - https://github.com/vmware-tanzu/community-edition/blob/main/docs/site/content/docs/assets/cli-install-mac.md
An example:
cd <DOWNLOAD-DIR>
tar xzvf ~/<DOWNLOAD-DIR>/tce-darwin-amd64-{{< release_latest >}}.tar.gz

resolving to:
cd <DOWNLOAD-DIR>
tar xzvf ~/<DOWNLOAD-DIR>/tce-darwin-amd64-v0.10.0.tar.gz

Let's plan to disconnect the automation that is associated with bumping the version in the docs site and associated yaml file here: https://github.com/vmware-tanzu/community-edition/pull/3138/files


fix(responses) to not set content type header for 204 (no content)

Summary
When there is no content (204 status code), there is no need to set Content-Type header. It may even be misleading.
Issues resolved
Fix #3342

Let's wait on CI and merge if it passes, thanks!


Table examples use deprecated scope attribute

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
RE: https://getbootstrap.com/docs/5.1/content/tables/
Table examples here are using scope="col" and scope="row" - but these HTML attributes are marked as deprecated. Do you think we should remove them from the examples? They wouldn't effect how they display or function.
REF:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td
https://html.spec.whatwg.org/multipage/obsolete.html#:~:text=scope on td elements
Reduced test cases
n/a
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
No response
What version of Bootstrap are you using?
v5.1.0

Closed this. Realised using scope on a th is fine (as is done in the examples), it's just on tds where it is deprecated. :-)


set z-index for dropdown so it stays on top

Why was this change made?
Fixes #3310:

adjust zindex for drop-downs to ensure they stay on top
adjust scroll position for left nav links to account for header

Drop down menu no longer obscured:

After clicking "Template Label" in left nav, scroll position set correctly:

How was this change tested?
Localhost
Which documentation and/or configurations were updated?

Closed in favor of #3317


Enhancement: custom header/metadata

Hello! It would be useful to be able to include additional, custom information with the messages that are published to Kafka.
The use case that I'm thinking of is running multiple Zeebe clusters (e.g. during a migration since horizontal scaling is not supported). Assuming, the same Kafka topics are reused, it would be useful to know which Zeebe cluster produced each event.
I was originally thinking that this could be supported by providing static attributes that would be merged into the JSON payload for each message.
But with Kafka support for headers, maybe this is better supported by specifying attributes to be included as headers in the exporter configuration.
What do you think?

Sounds reasonable, but keep in mind that the information we have available is typically just the record - if we wanted more info available to the exporter, then we should open an issue on the Zeebe repo to extend the exporter API.
But I think your proposal is a good first step, if I understand correctly - we add a new config property where users can add static attributes (e.g. clusterName), and we always add it to the headers of each record. Makes sense to me :+1:

Yes, we were discussing this use case internally again yesterday.
A new config property that holds a sub-map of static key-value pairs would be ideal for now. We would use this to include a cluster name/address as a header with messages, and perhaps an indicator if the cluster is currently is the primary one where we are starting new workflow instances.

Hello everyone!
If it is still free issue, I would like to take it and resolve. I think I could be the first step at contributing in an open source project.
And one more question. @npepinpe said that it has to be one more issue in Zeebe project that can extend the exporter API. Has not that issue already opened? If it has not opened, I can open it and try to resolve also.

@npepinpe
Hi Nicolas,
Could you tell me, please, who is a maintainer for this project for now? Anyone could help me release my changes when they will be complete?
Thank you for answer in advance.


How to get more animation sequences ?

Hi @mayank64ce, you can use the Video-based 3D Human Pose and Shape Estimation model to obtain an animation sequence from a video.

Thanks!


Add C# language editor icon

As discussed in #31319.
The icon is pretty much the Visual Script icon, except the 'v' was replaced with a 'c' I took from icon_color.

Thanks!


Jio tv volume

I try all channel volume is very low i play every channel in 90 volume please do something

I am not sure if it is related. For me the volume button doesn't work. Happens only with Jio TV channels; other IPTV channels in Simple PVR Client
Device: Fire stick


llvmPackages.libc: init at 20.0.0-unstable-2024-12-08

Things done
Adds LLVM libc, we've got the overlay building but full is still kinda borked. We're only going to support from >= LLVM 20 because it requires a lot of patching in previous versions. We're hoping the inclusion of LLVM libc at the point it is right now could help further its development and we can figure out how to package it better early on.

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The non-full variant doesn't seem to be used?

What is "the overlay build"?  I don't see it explained anywhere here.

The overlay build is the non full build of LLVM libc.

What's the point of it?

I asked the LLVM libc team on their Discord server:

Statically link a few libc dependencies, it's mostly a concession to make it usable until we can provide a complete C library

What does "kinda borked" mean?

So then why add two attributes, one that works and one that doesn't?  Why not just one libc attribute that builds as much as we can?
Is this actually useful for anything yet?  If not, maybe we should just wait until we can at least build it properly.

I was recommended to have both as an option since it'll allow for flexibility if things are broken. I'm going to be working on fixing the full build soon, just haven't gotten time. I've got some PR's merged upstream and some other might've flown under my radar so it could be working.

For flexibility, wouldn't a single attribute with an option we could flip be better?  Otherwise, we'd have to change everything that referred to the attribute all at once if we wanted to go from full to overlay.

But if the full build is working, why would we ever need the alias?  Why does it need an attribute too?

We already have to set a boolean anyways for full builds. The dependencies are different too. Providing both makes it easier to test if both work and for people to experiment with.

If full is building, why would I want to test with overlay?

I was meaning people who write software using nix could try it out. I know some people who would want to try it out.

Yes, but is there a reason they'd specifically want to test out the non-full version, even if full is available and building?

LLVM libc doesn't implement every libc function yet so overlay mode is a compromise which it overlays on top the existing libc.

I figured out why LLVM libc doesn't build in full mode, it's because GCC doesn't support gnu::naked on aarch64. Using pkgsLLVM or clangStdenv is working after I adjust the CC wrapper to remove -lunwind.

LLVM libc doesn't implement every libc function yet so overlay mode is a compromise which it overlays on top the existing libc.

Got it.  In that case,  we should probably support both

We'd need some sort of stub libc in the overlay one to pull in both since the overlay uses a different library name.

Oh, it's not called libc?  That's weird — how is it supposed to be used then?

Oh, it's not called libc?

libllvmlibc.a

That's weird — how is it supposed to be used then?

-llvmlibc

Oh, it's not called libc?

libllvmlibc.a

That's weird — how is it supposed to be used then?

-llvmlibc

With -nostdlib I guess?

No, you need a libc to overlay on top of. So you'd have both.


🔖(minor) release 1.4.0

Added

✨(backend) Add link public/authenticated/restricted access with read/editor roles #234
✨(frontend) add copy link button #235
🛂(frontend) access public docs without being logged #235

Changed

♻(backend) Allow null titles on documents for easier creation #234
🛂(backend) stop to list public doc to everyone #234
🚚(frontend) change visibility in share modal #235
⚡(frontend) Improve summary #244

Fixed

🐛(backend) Fix forcing ID when creating a document via API endpoint #234
🐛 Rebuild frontend dev container from makefile #248

Full Changelog: https://github.com/numerique-gouv/impress/compare/v1.3.0...v1.4.0

Just tested the new features. Great work !
What is not working (so well) yet:

When having a url as a first word in the title, nothing shows in the table of content, only empty space.
Similarly when first word in the title is bold / Italic / underlined and a second word is not, only first word is shown in the table of contents.
For me this is not a dealbreaker and we could go on and release.


Fix Image Size for Team Members [GSSOC ' 23]

Issue Description:

The current images of the team members on the project website are not fitting properly within their respective sections. We need to fix the image sizes to ensure a consistent and visually appealing display.

Issue Details:
Image Dimensions:
Review the dimensions of the team member images and ensure that they are consistent in size. This will create a more uniform and professional appearance across the website.
Aspect Ratio:
Verify that the aspect ratio of the images is maintained during resizing. Stretching or distorting the images can negatively impact the visual quality and make team members appear distorted or disproportionate.
Responsive Design:
Ensure that the images are responsive and adjust appropriately based on different screen sizes. This will guarantee that team member images look good on various devices, including desktops, tablets, and mobile phones.
CSS/HTML Adjustments:
Make any necessary CSS or HTML modifications to accommodate the desired image sizes. Review the relevant stylesheets and HTML templates to ensure that the images are displayed optimally.
I am ready to work on this issue and solve them! Please assign me to this

I am GSSOC contributor i want to work on this issue please assign to me

No changes required in images in team members section.


Curve2D Get Closest Offset incorrect between final two baked points

Godot version:
3.2.2.rc2
OS/device including version:
Linux Mint 18.3 Cinnamon 64-bit
Issue description:
Expectation: Get_closest_offset finds closest offset anywhere on path.
Actual result: Get_closest_offset fails to correctly find closest offset between final two baked points.

Steps to reproduce:

Download the attached project. There are three demo scenes, 2, 3 and 4. Both have a path that starts at the top and goes clockwise. Baked points are shown as red circles.
Run Demo2.tscn.

This is a demonstration of the issue in a real use case. Each frame, the sprite's offset along the path is calculated by passing its currrent position into get_closest_offset. That offset is then increased, and passed into interpolate_baked to position the sprite further along the path.
Use the up/down arrow keys to change the speed (hold shift to go faster).
Notice how (when going CW) the sprite gets stuck between the last two points. If you increase the speed it inches further, until it finally gets over. Going CCW the same happens in reverse.
Try moving the last point over the starting point to complete the loop. Now (when going CCW) the sprite appears to get stuck crossing the start (again, until you increase the speed).

Run Demo3.tscn (pictured above).

Use the mouse to control the blue sprite. The green sprite will be positioned at the closest point on the baked curve using get_closest_offset.
Try tracing the red line with the mouse. Notice how the green sprite tracks the mouse perfectly, except between the final two points, where the closer you get to the end, the more the sprite falls behind.

Run Demo4.tscn.

This demonstrates that get_closest_offset is at fault, and not interpolate_baked. The yellow sprite is positioned with a steadily increasing offset fed into interpolate_baked. Get_closest_offset is not used. Notice how the motion is as expected.

Minimal reproduction project:
Curve2DGetOffsetBug.zip
Video:
Curve2DGetOffsetBug_Videos.zip
Or on youtube: Demo2, Demo3, Demo4

I think I've found the problem:
https://github.com/godotengine/godot/blob/091e500a887b68c1734d17dd40c5ea47a83b73cc/scene/resources/curve.cpp#L875
This finds the length between baked points, assuming they are bake_interval distance apart - which is true everywhere except at the end, where it will be <= bake_interval (specifically, baked length mod bake_interval).
This can be fixed by checking if we are at the second-to-last bake point and, if so, the length is just whatever's left. Something like this:
Vector2 direction = r[i + 1] - origin
if (i < pc-2) {
	direction /= bake_interval;
} else {
	direction /= get_baked_length() - offset
}

It looks like the same would apply to get_closest_point too.
(I tested by porting the get_closest_offset function to gdscript and making the above change there. It fixes the observed issue, but I've not done further testing beside so I can't speak to any possible ramifications.)

Ran into this today on curve3d, I had workarounds in place, but it started causing crashes in recent builds when trying to interpolate_up_vector. Would be great to see this fixed.
v4.0.alpha.calinou [8adf04804]

@shuvit-game Feel free to open a pull request with @tom-jk's proposed change :slightly_smiling_face:


Bump velero library and deployment to 1.14 + go update and kubevirtci

Release note:

Update velero to 1.14 and go to 1.22.3

So I don't fully understand it yet but somehow the .gitignore directive for velero* introduced in https://github.com/kubevirt/kubevirt-velero-plugin/pull/208/commits/71c67b4ea7918955eee34ee8e9b2dd92784909d1
is dropping some critical additions in the velero vendored dir
$ git status
On branch bump-velero
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   .gitignore

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        vendor/github.com/vmware-tanzu/velero/pkg/apis/velero/shared/
        vendor/github.com/vmware-tanzu/velero/pkg/cmd/util/flag/orlabelselector.go
        vendor/github.com/vmware-tanzu/velero/pkg/features/verify.go
        vendor/github.com/vmware-tanzu/velero/pkg/plugin/framework/common/plugin_config.go

no changes added to commit (use "git add" and/or "git commit -a")

/test pull-kvp-functional-test

/test pull-kvp-functional-test

/retest

/retest

/test pull-kvp-functional-test

Looks good, nice commit separation
/lgtm

/approve


Custom textstyle for aboutdialog action button

Added an additional argument to showAboutDialog, AboutListTile and AboutDialog that will allow developers to override the default style of the action buttons of the AboutDialog.
Closes #76535
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is an interesting idea however it doesn't scale well. There are many similar parameters we could add to AboutDialog et al. to change the appearance of its buttons, icons, and text. It's preferable to handle customizations with the existing themes. For example:
import 'package:flutter/material.dart';

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showDialog<void>(
              context: context,
              builder: (BuildContext context) {
                return TextButtonTheme(    // The AboutDialog uses TextButtons
                  data: TextButtonThemeData(
                    style: TextButton.styleFrom(
                      textStyle: const TextStyle(fontSize: 20),
                    ),
                  ),
                  child: AboutDialog(
                    applicationName: 'applicationName',
                    applicationVersion: 'applicationVersion',
                  ),
                );
              },
            );
          },
          child: Text('Show AboutDialog'),
        ),
      ),
    );
  }
}

void main() {
  runApp(MaterialApp(home: Home()));
}


How to control agent command line?

We now want some control over the OCM Status Add-On Agent command line, to allow control over log verbosity and client-side self-restraint in the request rate to the apiservers. How should this be done?
In terms of the OCM Status Add-On Controller, there are two approaches we could take.
The simplest would be to define some additional flags to the controller.
However, it is worth noting that the OCM Add-On framework has a designed way to configure the agent. It would be less surprising to use that rather than controller flags. Also, that way is dynamic --- which may be an advantage in the future. Perhaps we might as well start out using the designed way.
This designed way is explained in https://open-cluster-management.io/developer-guides/addon/#add-your-add-on-agent-supported-configurations . This would involve a AddOnDeploymentConfig or a ConfigMap in the ITS that holds the desired parameters, or an annotation on the ManagedClusterAddon in the ITS that holds the desired parameters (per https://open-cluster-management.io/developer-guides/addon/#values-definition).
In either approach, there is an additional step needed to have a proper interface. The OCM Status Add-On Controller runs in a namespace in the KubeFlex hosting cluster and this namespace is not part of the KubeStellar interface. The ITS also is an implementation detail, not part of the KubeStellar interface. So in either case, some additional definition is needed.
Currently, examples.md says this about how to create an ITS:
kflex create its1 --type vcluster -p ocm

The ocm PostCreateHook takes no parameters for agent log verbosity or client-side self-restraint. We could define such, but remember that a PostCreateHook does not have the concept of default values for parameters; every use would have to supply value for those parameters.
In the near future we hope to wrap this up in Helm chart(s). These do have a concept of default values.

@pdettori
@francostellari

It occurs to me that there is a possible variation on the simple idea of adding a controller flag per agent flag. That is to add one controller flag whose value is all the agent flag settings to apply. Perhaps as a space-separated string. I suggest space separation because commas are already used in some values (e.g., --vmodule) and spaces are not (as far as I know).


Remove Cryptocurrency Codes from Fiat List

The purpose of this task is to remove the cryptocurrency codes (eg "LTC", "BTC", "ETH") from the list of ISO fiat currency codes and therefore remove those items from the list of fiats that you can set for a wallet during the CreateWallet process.
I accomplished this by removing the package from which we were acquiring our list of cryptocurrencies and replaced it with a list of fiat currencies that have ISO codes from Wikipedia.
Asana Task: https://app.asana.com/0/361770107085503/613641312549211/f

I would wait until after this point release before merging this into develop (in my opinion).

This is worth getting into the point release. Looks safe enough


Adding RabbitMQ Container

This pull request provides a basic container for rabbitmq to use it in tests.

Coverage increased (+1.3%) to 83.667% when pulling cdf2270d544c22bde200bca53c8167da472c1228 on GDATASoftwareAG:rabbitmq into e1504690ee6af996a3956adf92ff242a24f98606 on testcontainers:master.


Use Redux toolkit but do not use Immutable

What docs page needs to be fixed?

https://redux.js.org/style-guide/style-guide/
https://redux.js.org/style-guide/style-guide/#use-redux-toolkit-for-writing-redux-logic
https://redux.js.org/style-guide/style-guide/#use-plain-javascript-objects-for-state

What is the problem?
Redux style guide says: "use redux toolkit", "do not use immutable.js"
Redux toolkit recipe says: "use immutable.js"
https://redux.js.org/recipes/using-immutablejs-with-redux/
What should be changed to fix the problem?
It's confusing, stick with one recommendation.

We should probably just drop that page entirely. Many folks are moving off Immutable to Immer or TypeScript (or both!).

Yes, I plan to drop that page entirely as part of the docs rewrite.
When we do that, I want to redirect any external incoming links to that page to the "Immutable Update Patterns" page instead, using the _redirects file.

We should probably just drop that page entirely. Many folks are moving off Immutable to Immer or TypeScript (or both!).

how can one drop Immutable in favor of TS? these are different tools

Readonly types or fields.

@timdorr if I don't ask too much, can you please give me a more detailed example. I know we might get out of subject, but might be handy also for other folks reading these comments :)

Fixed by #4053 .


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/4 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 0a371bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

archvieSourceFolder/TOC.yml
:white_check_mark:Succeeded

archvieSourceFolder/content/someContent.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Explain select pgq query leads to segfault

-EXPLAIN SELECT study.name, study.school
FROM GRAPH_TABLE (pg
     MATCH
     (a:Person)-[s:StudyAt]->(b:School)
     WHERE a.name = 'Daniel'
     COLUMNS (a.name as name, b.name as school)
     ) study;

The following query leads to a segfault

Related to #66

Fixed as of https://github.com/cwida/duckpgq-extension/pull/71


The width/height attributes set on the placeholder.png images aren't removed when the actual image loads

While a grid is generating, you can view the index.html and watch the images load as each one is generated. For each unavailable image it sets the src to 'placeholder.png' and adds width/height attributes to match the smallest (I think) width/height used in the row. The problem is that It doesn't remove the width/height attributes from the img when the actual thing loads.
This means that if one of the row's items had a shorter height than the rest (it's a square), everything else that gets loaded in the row will be show up with the wrong aspect ratio (forced to fit into a square).
The width/height attributes are only added when the src is set to placeholder.png, so it looks like this can just be fixed by updating proc.js' checkForUpdates(), adding
img.removeAttribute('width');
img.removeAttribute('height');

before it changes the src property of the img.
Edit: This also has to be fixed when 'auto-scale images to viewport width' is on.

Good report - replicated the issue, and confirmed the suggested fix works. Thank you!


bump dcos-diagnostics sha

High Level Description

bump dcos-diagnostics sha.
update integration test to exclude system field validation.

Related Issues

DCOS_OSS-143 Remove system field from dcos-diagnostics health response.
DCOS_OSS-671 Diagnostics bundle naming improvement.

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
Current set of integration tests provides a good coverage.
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[X] Change log from the last version integrated (this should be a link to commits for easy verification and review): dcos-diagnostics
[X] Test Results: jenkins#11
[X] Code Coverage (if available): jenkins#11

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

Hi @darkonie can you find someone to do a second review on this? thanks!

@lingmann done! approved

Awesome, thank you @darkonie ! 🚀