Please describe which access is required to update Agent

Hi,
in the following section https://learn.microsoft.com/en-us/azure/virtual-machines/extensions/agent-windows?context=%2Ftroubleshoot%2Fazure%2Fvirtual-machines%2Fcontext%2Fcontext#upgrade-the-azure-windows-vm-agent you write that  "Azure Windows VM Agent for Windows is automatically upgraded on images deployed from Azure Marketplace. The new versions are stored in Azure Storage, so ensure that you don't have firewalls blocking access." Could you please also add what access is needed in terms of URLs/IPs etc.?
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab75f449-661d-bd1e-3ebd-61e2384a911a
Version Independent ID: e7c93a31-6076-26b8-a53d-d36df01ec6bc
Content: Azure Windows VM Agent overview - Azure Virtual Machines
Content Source: articles/virtual-machines/extensions/agent-windows.md
Service: virtual-machines
Sub-service: extensions
GitHub Login: @GabstaMSFT
Microsoft Alias: gabsta

@dimilider
Thanks for your feedback! We will investigate and update as appropriate.

@dimilider
you can find more information on the URLs and IP addresses required for the Azure Windows VM Agent upgrade in the following Microsoft documentation:
Azure Windows VM Agent for Windows
Azure IP Ranges and Service Tags – Public Cloud
The first document provides an overview of the Azure Windows VM Agent for Windows and how to upgrade it, while the second document provides a list of the IP address ranges and service tags used by Azure services, including the URLs and IP addresses required for the Azure Windows VM Agent upgrade.

@dimilider
if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Hey,
so yes, the docs say "The Azure Windows VM Agent for Windows is automatically upgraded on images deployed from Azure Marketplace. The new versions are stored in Azure Storage, so ensure that you don't have firewalls blocking access." do I have to make sure that access to Azure Storage is not blocked? Or will the VMAgent be updated via <IP_ADDRESS> address so that only access to <IP_ADDRESS>. is required? This is not very clear here.


Handle optimistic response for reactions

Use regular gql query with skip condition instead of lazy query
Fix type policy handling for proposal objects
Update reaction badge active colour according to design
Handle proposal reaction optimistic response

refs #224

@chihimng updated 🙏

any way for us to fetch the true value from server after successful mutation?

or alternatively, do we revert the optimistic result if we receive error currently?

let me see see

@chihimng

any way for us to fetch the true value from server after successful mutation?

I have changed to using the reaction value provided by the update function instead of user input, the flow is now as follows
user press reaction -> sends request to gql server -> generates optimistic response -> update function called with optimistic response -> update ui -> response returned from server -> update function called with actual data -> update ui

alternatively, do we revert the optimistic result if we receive error currently?

yes it rolls back automatically, tested by throwing error on server side


Allow CORS for multiple websites

Can we add CORS for multiple websites? Just comma separated values would be great (unless that's supported already?)
Thanks

Thanks for contacting us @ferarnoled
Unfortunately, multiple CORS is not supported currently, but we would think how we can support the multiple CORS in the next update.
For example, we could check if origin is in the multiple CORS websites or not, and if the website is in the configuration, we can pass Access-Cortrol-Allow-Origin header.

Is this still on a potential roadmap? I would also like to have this functionality


Typescript default extension example

Typescript example with .js as default extension
I couldn't find an example of how to write Typescript code without specifying the file extension in imports. I do not know if what I've done is a good example, so please give some feedback if needed.

@joeldenning Thanks for your input! I've updated the pull request based on your feedback.


[Feature] Improve the sidebar: column orders, modified state, and no column node for non-profiled models.

preserve the column orders in the comparison schema diff

Propagate the modified state to upper node if a folder is folded

For non-profiled models, don't show the columns in the sidebar

[x] Ensure you have added or ran the appropriate tests for your PR.

[x] DCO signed

sc-31384


Read Port Config file in multiple python versions

This PR solves an issue where the localstack image comes with python 3.7 instead of 3.8 affecting the reading of a file.
Addresses localstack/localstack#4115

Awesome, thanks for fixing this @pinzon ! 👍


Updated mermaid.min.js to v 10.6.0

Updated mermaid.min.js with the content from<EMAIL_ADDRESS>The content of LICENSE in the Mermaid v 10.6.0 package (https://github.com/mermaid-js/mermaid/archive/refs/tags/v10.6.0.zip had no changes compared to mermaid.min.js.LICENSE.txt

Close #102

Thanks


Sparse cff2vf support

See history on PR #1547.
Built a new branch to allow a clean merge, without overwriting any of the main branch fixes  in the many weeks since PR #1547 was opened.
In varLib/cffLib.py, add support for sparse sources, and sources with more than one model, and hence more than one VarData element in the VarStore.
CFF2 source fonts with multiple FontDicts in the FDArray needed some extra work. With sparse fonts, some of the source fonts may have a fewer FontDicts than the default font. The getfd_map function() builds a map from the FontDict indices in the default font to those in each region font. This is needed when building up the blend value lists in the master font FontDict PrivateDicts, in order to fetch PrivateDict values from the correct FontDict in each region font.
In specializer.py, add support for CFF2 CharStrings with blend operators.
Add test case for sparse CFF2 sources.
The test font has 55 glyphs. 2 glyphs use only 2 sources (weight = 0 and 100). The rest use 4 source fonts: the two end points of the weight axis, and two intermediate masters. The intermediate masters are only 1 design space unit apart, and are used to change glyph design at the point in design space. For the rest, at most 2 glyphs use the same set of source fonts. There are 12 source fonts.
Add test case for specializer programToCommands() and commandsToProgram by converting each CharString.program in the font to a command list, and back again, and comparing original and final versions.

See history in PR https://github.com/fonttools/fonttools/pull/1547


InlineNodes don't work with headers

I just tried building a book that uses {glue:} in the header of the page, and got this error:
NotImplementedError: <class 'sphinx.transforms.SphinxContentsFilter'> visiting unknown node type: PasteInlineNode

Do we want to support {glue:} roles in headers?
If so, this is a bug and we should fix / test it
If not, this is a docs update issue

is there some magic going on somewhere such that docutils knows about these nodes without use registering them?

I think this is because these nodes are generally picked up before and Visitor parses, since they should have already been transformed by:
https://github.com/executablebooks/MyST-NB/blob/50fd0b373280321aa869bcfbc1d861aa45d03bcf/myst_nb/nb_glue/transform.py#L17

@chrisjsewell check the latest version of the issue text - I realized that there was a more specific issue than the nodes not being recognized

This is the transform in question: https://github.com/sphinx-doc/sphinx/blob/62711bc081744cecba2af799ad8dbf678f6a97a4/sphinx/transforms/init.py#L308, which subclasses https://github.com/docutils-mirror/docutils/blob/e88c5fb08d5cdfa8b4ac1020dd6f7177778d5990/docutils/transforms/parts.py#L70.
It has a priority of 720, which is higher than the glue transform (699), so I guess in our tests we just don't call any with such a high priority.
But yes we should register this then.

I think you should be able to register it as part of the domain class: https://github.com/executablebooks/MyST-NB/blob/50fd0b373280321aa869bcfbc1d861aa45d03bcf/myst_nb/nb_glue/domain.py#L262


get vs. add

Regarding the latest developments in addAlpha() in #460  I realized that we could also need getAlpha() as an exported function.
For instance in altExp mechanism one might like to retrieve the alpha diversity estimates from altExp but often wants store them in the main tse object where most other sample data is stored.
It would then be more clear to do obtain the values with getAlpha(altExp(tse)) and then assign them manually to colData(tse), like:
colData(tse) <- cbind(colData(tse), getAlpha(altExp(tse, "myaltexp"), index=c("shannon", "faith")))
The other option would be to do addAlpha()
indices <- c("shannon", "faith")
colData(tse) <- cbind(colData(tse), colData(addAlpha(altExp(tse, "myaltexp"), index=indices))[, indices])

or  something like..
tse <- addAlpha(altExp(tse, "myaltexp"), index=indices), altexp=NULL)

I think the first option is the most clear for the user.
Essentially, this is a suggestion to reconsider that for most add* functions we would have the corresponding get* function. This is intuitive, and has clear uses at least with altExps.

@TuomasBorman does it seem we could close this one..?

On my phone, so hard to close. But yes, this issue has been taken into account, can be closed


Added statuscake alerts for apply for qts

Updated terraform scripts to integrate app with statuscake.
Updated keyvault secret with status cake related configuration
[x] Rebase to main
[x] Attach to trello

 Add statuscake alerts for apply for qts


Support ECL 1.5

This PR migrates the current grammar to support the latest 1.5 ECL specification:
https://confluence.ihtsdotools.org/download/attachments/33493263/doc_ExpressionConstraintLanguage_v1.5-en-US_INT_20210215.pdf?api=v2

Grammar-wise it looks OK, but tests are complaining.


implement redis-backed log retrieval for async queries

Currently, the TRAPI response contains a very verbose "log" object.  That log is not very useful for most BTE users, but very useful for developers and experts to debug.  This ticket proposes to completely replace the current "log" object with a single URL, which is where the current log can be downloaded from.  Based on a conversation with @newgene, the log can be stored in an existing redis object that tracks async jobs.  Redis can be configured to wipe the log after 10 mins.  For simplicity, this feature can be limited to the /asyncquery endpoint.
Separately, I'll be creating a ticket to create a more user-friendly log for direct inclusion in the TRAPI response.

Gah, I knew I saw this somewhere before.  Closing this one as a duplicate of #304...


Tabs Group Extension extension (name)

Please consider changing the name of the extension:

from Tabs Group Extension
to Tabs Group

– the word Extension is superfluous. It's categorised under Extensions –

– and so on.
Thanks

@grahamperrin, yep, you're right!
Changed.


Compile Error with Oracle Client 12.2 and option OCI_ATTR_CALL_TIMEOUT

The OCI_ATTR_CALL_TIMEOUT is not defined in connection.c
Environment :
Ubuntu Linux 18.04
Oracle Client :12.2

Hi,
Thanks for reporting the issue !
I will fix it asap and include for 4.6.1 release!
Best regards,
Vincent


Improve README and feature docs

Description
This PR improves the RIG feature documentation. The goal is to have a clean README that explains in short what RIG is about and its main features without going into much details.
close #284
What to look out for
Dear reviewer, I want you to

gain knowledge - I think it's important for you to know about the change.
check that the code works on your machine.
suggest implementation-code design/structure/readability improvements.
suggest test-code design/structure/readability improvements.
suggest documentation improvements.
suggest language/writing improvements.
help to find bugs (described below!).

Process
The goal is to improve not only the code in this PR but also our skills! The "rules":

The review is considered "done" as soon as all reviewers have added their review, and all their comments have been addressed.
For knowledge-sharing reviews, each reviewer should "approve" the PR after studying its content.
After the approval, the merge is concluded by the developer.

Have fun!

I am not yet finished, I want to document the feature of integration with external authn/z systems... let's look into the build afterwards...

I am not yet finished, I want to document the feature of integration with external authn/z systems... let's look into the build afterwards...

perhaps in a new PR? would like to prevent conflicts, e.g. with #338


Support for encrypted secretes instead of plain text ~/.2fa

Hi,
First of all, this is a great command line utility so thank you for making it.
Adding support for a password encrypted using PGP/GPG could be cool. A JSON format like the one outputs the backup mechanism of https://github.com/andOTP/andOTP could be great, because the secrets can be shared easily between the 2fa and andOTP on Android.
Here is an example of a formatted decrypted JSON backup made by andOTP:
[
  {
    "secret": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
    "label"<EMAIL_ADDRESS>    "period": 30,
    "digits": 6,
    "type": "TOTP",
    "algorithm": "SHA1",
    "tags": []
  },
  {
    "secret": "XXXXXXXXXXXXXXXX",
    "label": "GitHub - GitHub:doronbehar",
    "period": 30,
    "digits": 6,
    "type": "TOTP",
    "algorithm": "SHA1",
    "tags": []
  },
]

I'll be glad to hear your thoughts :)

TL;DR:
Create an alias or function in your shell to use GPG to encrypt and decrypt your ~/.2fa file:
BASH  function:
2fa() { gpg --decrypt ~/.2fa.gpg > ~/.2fa; **/path/to**/go/bin/2fa "$@"; rm ~/.2fa; }
Fish function:
function 2fa
    gpg --decrypt **/path/to**/.2fa.gpg > ~/.2fa
    /path/to/go/bin/2fa $argv
    rm ~/.2fa
end

Long Response:
I was able to solve this by writing a function in my shell (fish) to use gpg to decrypt the file. You could do the same thing with BASH using an alias or just writing a shell script.
It's a sloppy solution but it totally works and relies on the security of GPG rather than keeping the file stored in plaintext.
As an example, here is my function for fish:
function 2fa
    gpg --decrypt ~/.2fa.gpg > ~/.2fa
    /path/to/go/bin/2fa $argv
    rm ~/.2fa
end

This example presumes that the ~/.2fa file has been encrypted with gpg and stored as ~/.2fa.gpg. Once the encrypted file exists, you can remove the original ~/.2fa file that has everything stored in plaintext.
To break down the function:
gpg --decrypt ~/.2fa.gpg > ~/.2fa will decrypt the gpg file and create a ~/.2fa file.
/path/to/go/bin/2fa $argv will run the 2fa binary and accept arguments.
rm ~/.2fa will remove the ~/.2fa file. You could erase it securely using shred instead.

Cool! Thanks for your response, I'm using pass-otp now which fits well to my workflow with pass So I don't need this workaround anymore.


do not require sudo for Travis builds

There is something fishy, the newly built lcov isn't actually used as it seems. Investigating…

I completely removed the custom lcov, the one from the distro seems to work fine, too.

Wow nice changes I really didn't need to update all g++ and install custom lcov. No you really don't need  sudo permisions.
Before I merge your commit only one last question do you know which g++, CMake and lcov version are installed in Travis? Are this more stable version or the latest releases?
Great job by the way 👍

According to the build log:
$ g++ --version
g++ (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4

That is correct but there is no lcov... and according to log files it's using gcov 4.8.4 for code coverage. That's weird... I could take a look at that but tomorrow... Or maybe you know why is using gcov instead of lcov?

When I look at the Travis log (why isn't travis enabled for this repo so one could see it directly?) lcov is called and there is no complaint that it is not available, as I had it in one of my builds.

I don't know what you mean by seeing it directly but you can click on build badge or on commit or even here at this pull request you can see Travis log. You can show me where to enable and I will enable it.
I checked log in this repo and in your repo and both show the same that Travis is using gcov.
Here is screen shot from you Travis log from your repo and its the same as here:

Hm, yes, all fine, I'm just blind because it was collapsed.

It's okey I also notice the second time I went through the log.
I am only asking this annoying questions because I want to found out what is happening behind the scenes and not just removing code and hopes that Travis will take care of that.
PS: I hope that I don't annoy you with this details.

Those output is exactly the same on the previous build, even with less warnings about versions.

After this commit the default gcc (4.8) is used instead of (5).


Please Update Flatpak Runtime

Info: runtime org.freedesktop.Platform.GL.default branch 19.08 is end-of-life, with reason:
   The Freedesktop SDK 19.08 runtime is no longer supported as of September 1, 2021. Please ask your application developer to migrate to a supported version
Info: applications using this extension:
   io.atom.electron.NewCP

Resolved in v1.6.0


/data file missing

is it possible to share the final HV maps for each country?

Since we put everything in OpenStreetMap, that's the best resource for getting the HV map information. It's maintained/updated there by the community.

Hey @george-harris, glad you found it helpful!
Right now, smaller distribution grids might be difficult with our analysis pipeline because the infrastructure (i.e., 11-33kv poles/lines) are hard to see in satellite imagery. It's possible you could do something similar with drone or aerial imagery, but that imagery is more expensive and time-consuming to collect :/
Substations are certainly doable. We just didn't add that component in this iteration of the project :)
What mini-grid developer are you working with?


add codes to log events

wait to merge into the feature branch till #4266 is in.
Description
Uses mypy to enforce codes for every log event.
The proposed format for codes is one capital letter followed by 3 digits:
aka ^[A-Z][0-9]{3} Ex A123 or E003 etc.
TODO

[ ] get format approved by team
[ ] add concrete codes to each class
[ ] change base branch of PR back to feature/logging-phase2

Checklist

[ ] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change

@emmyoop returncode is specific to the log event SystemReportReturnCode. code on the otherhand is a new field that mypy will enforce is on every log event to uniquely identify each event.

A proposal for event code prefixes:

Code
Description

A
Pre-project loading

B
DB adapter setup

C
Project parsing

D
Deps generation

E
Node testing

F
Node processing

G
Misc


2.4.7: Settings confusion... IPV6??

Ihave IPV6 (and ipv4) - do I enable ipv6... but also block it?

@EC-O-DE
If you have IPv6 connectivity, you can enable IPv6, you proably won`t block it.

Yes, but every now and then I see on the log that your very nice and great app isn't encrypting DNS requests... :00


Puppet integration Net::ReadTimeout  error

Hello TraGicCode
We are facing the issue of trying to integrate azure KeyVault with Puppet.
The Puppet server is deployed in the AKS cluster. Version is 6.18.1
tragiccode-azure_key_vault version: v3.1.1
Configure manage identity between Azure KeyVault and puppet master.
Our manifest:
$admin_pass = azure_key_vault::secret("my-kv","AdminPass", {
metadata_api_version => '2018-04-02',
vault_api_version    => '2016-10-01',
})
notify{"The ADMIN PASS from KeyVAULT is: $admin_pass": }
$rewraped_secret = Sensitive("password: ${admin_pass.unwrap}")
file { 'C:\Config\secret.secret':
content   => $rewraped_secret,
ensure    => file,
}
}
Also have used Service Principal for testing but had the same errors in both cases.
Facing error when running puppet agent on the node
2023-03-10 12:48:39,185 ERROR [puppetserver] Puppet Evaluation Error: Error while evaluating a Function Call, Net::ReadTimeout (file: /etc/puppetlabs/code/environments/env/modules/users/manifests/install.pp, line: 14, column: 17) on node xx-xx-xx-xx-xxxx
2023-03-10 12:48:39,186 ERROR [puppetserver] Puppet Server Error: Evaluation Error: Error while evaluating a Function Call, Net::ReadTimeout (file: /etc/puppetlabs/code/environments/env/modules/users/manifests/install.pp, line: 14, column: 17) on node  xx-xx-xx-xx-xxxx

Hey @GalynaPchelianska ,
Based on that error message, This looks to be like some networking related issue in regards to your AKS cluster.  I'm not really going to be able to assist much with this.
I would think you would be able to reproduce a similar result if you were to attempt to communicate directly with azure key vault from your puppet server within AKS.
For now, i'm going to close this issue for now.


Problems back on HTU21D-F follow up of #457

Hi all,
I spent some time few months ago on HTU21D-F and even if not detected on i2c bus measurements were possible. I have started another project and when I plugged again HTU21D-F  it did not show up and sent error messages.
I have checked my sensors with an arduino, all of them work well but when using mraa/upm on Edison or RaspberryPi  no measurement is possible. The sensor seems to be  connected but all write failed with the same error  :
ValueError: UPM Invalid Argument: Unknown error in I2c::readReg()
Am I the only one to get this error or is-it a general problem?
Thanks

Hi @g-vidal, I've tested the sensor on the Edison with the Arduino breakout and noticed the same capacitance problem as we encountered on many other I2C sensors. If I power it from 5V, it will read the data once or twice before it throws the error. At 3V3 I can get several readings before it bails out.
My suggestions are:

Wire the sensor to 3V3 and wrap the sensorData() function call in a try..catch block. This way your application will continue to run even when it fails to read and you can log the error/retry. No hardware needed, just a bit of extra code.
Use an I2C bus repeater/redriver/hub that isolates capacitance on the I2C bus. A good example is the PCA9517 (I have the one from here). With this, I can get all the sensors listed in the known limitations to work on the Edison with the Arduino breakout with no issues. Perhaps the TCA9548A mux you have works too.

Tested with the latest MRAA/UPM libs and Edison image. I've also updated the known limitations page, and added the Py/JS examples for this sensor.


add immutable_id column to azuread_user table

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
steampipe query "select on_premises_immutable_id from azuread_user"
+--------------------------+
| on_premises_immutable_id |
+--------------------------+
| <null>                   |
| AADBackdoor              |
+--------------------------+

Hi, @maceip thanks for using Steampipe. great to see this PR. We are looking into it and update you soon. 👍

Hello @maceip, once again thanks for your contribution 👍
This feature is now available on azuread v0.1.0 (https://hub.steampipe.io/plugins/turbot/azuread).
Please let us know how your experience has been so far and if we could help in case of any blockers 👍


Add Pop_up

🛠 Fixes Issue (#1659)
✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Please Review It @swapnilsparsh
📷 Screenshots

@Lokeshsuwalka05 Instead of pop up, don't allow the user to enter negative values.

Ok,Sir.

hello Sir @swapnilsparsh , please reveiw it.

@Lokeshsuwalka05 Thank you for contributing to this repo. Looking forward for more 🚀


Suggestion: Archive the old logo

Archive the old logo instead of replaceing them with new logo. Just like Browser Logos.

Hey @Geeyun-JY3
Unlike Browser Logos' repo, which is very specific and historical, this is a generic collection of tech logos, and I think keeping the old ones would generate confusion and misinformation.
I'll take this into consideration when I refactor the database used to generate this repo but I don't have time for this right now.
Thanks anyway

Hey @Geeyun-JY3
Unlike Browser Logos' repo, which is very specific and historical, this is a generic collection of tech logos, and I think keeping the old ones would generate confusion and misinformation.
I'll take this into consideration when I refactor the database used to generate this repo but I don't have time for this right now.
Thanks anyway


Map generation error

After the server is restarted, the map will be wrong.

working on a fix currently

That's just a bug where it shows chunks from the old world that haven't unloaded. Just fly around a little and it'll be fine.

If the bug can be fixed by a restart or flying around, then there is no need for a patch

Server core issue, not loading chunks fast enough.


Cmd/ctrl-drag of parent element should unbind it from all bound elements

Holding Cmd/ctrl while dragging bindable element should unbind currently bound linear elements from it.

/cc @xixixao do you want to take this on?

Sounds reasonable (I left it out intentionally). Shouldn't be too complicated. I can help/review whoever wants to take this on.

Can assign to me please. Would like to give it a try


Claiming certification after certificate completion

Some users seem to be confused after completing projects for the first certification on how they could receive their certification.
A redirect or a flash message notifying users after finishing the required projects to complete a certificate could be helpful.

I think that's a great idea. When I earned my first certification for the updated curriculum, it wasn't clear how I was supposed to claim it.

Why redirect and not use the modal. The primary reason we had this weird way of claiming the cert from the settings page was because:

Learn was deployed at learn.fcc.domain
The API could work on www.fcc.domain
The user profile was at www.fcc.domain/<username>

All these legacy limitations are gone.
There is no need for us to redirect them to the settings. All the functionality is right there in the challenge page.

We are planning to  show status of each certification on each certification page. It might be more useful to have a claim/show certification button similar to the one we have on the settings page instead, so users don't have to go to the settings page to claim/show their certifications.

@moT01 @raisedadead any thoughts?

We are planning to  show status of each certification on each certification page. It might be more useful to have a claim/show certification button similar to the one we have on the settings page instead, so users don't have to go to the settings page to claim/show their certifications.

@moT01 @raisedadead any thoughts?

Yes - this seems logical to me. We should still keep a button in the settings at the same time for users who are used to finding it there.
We can revamp the settings page a bit in the upcoming days to make it cleaner.

Yes - this seems logical to me. We should still keep a button in the settings at the same time for users who are used to finding it there.
We can revamp the settings page a bit in the upcoming days to make it cleaner.

I'm a little biased - but, I kinda like the first image - an empty circle that fills in when you finally get the cert. Feels like it gives it a little gamification. I would maybe try and put the cert in with the white background though. FYI - That text will link to the cert if it's claimed. What about adding the button from the right image at the bottom of the left image if the cert is claimable? One other thing to maybe consider, is that there's at least one obstacle before you can claim a cert - they need to accept the honesty policy. I think they need to enter their name as well. So if they try to claim the cert from here, they may just get a flash message about having to do those - in which case, they will need to go to the settings page.
I do agree that it would be nice to have some easier ways to claim certs.

I'm a little biased - but, I kinda like the first image - an empty circle that fills in when you finally get the cert. Feels like it gives it a little gamification. I would maybe try and put the cert in with the white background though. FYI - That text will link to the cert if it's claimed. What about adding the button from the right image at the bottom of the left image if the cert is claimable? One other thing to maybe consider, is that there's at least one obstacle before you can claim a cert - they need to accept the honesty policy. I think they need to enter their name as well. So if they try to claim the cert from here, they may just get a flash message about having to do those - in which case, they will need to go to the settings page.
I do agree that it would be nice to have some easier ways to claim certs.

I agree that some of our error messages could provide a link where the user could resolve the error. For instance, errors about the honesty policy might be confusing as some users might not know honesty policy is located in the settings page. (even if they are claiming the cert from the settings page)

One of the other motives to remove that cert completion element is to avoid information overload at the end of each superblock page where 5-4 elements are completing for the user's attention.

I think we should do one or few of the followings:

eliminate the less important elements ( do we need the sign in button there?)
group/ separate elements if possible ( should we use spacing and break lines to group items in the UI?)
give emphasis selectively (can we lower the width, size, contract, and remove some icons and still achieve the same results?)

I added the sign in button, seemed like a good spot for it - definitely not necessary - although, it does add some color - which I think is nice.
Seems like the items are grouped pretty good - each block has a white background, with a space between them - there could possibly be something better though

Logically to me:

The "Sign in" button and a "Claim your X cert." button should be mutually replacing each other depending on the user state.
The issue of user not having a name and not having accepted the honesty policy could be handled with a modal with one/two messages explaining the needs, with links to settings page (open in a new page, maybe be even auto scroll to the item).

Something like:
------------------------------------------------

  You are almost there! All you need is to:
  - [ ] Add a name to your profile {link here}.
  - [ ] Read and accept our academic honesty
        policy {link here}.
------------------------------------------------

I agree that some of our error messages could provide a link where the user could resolve the error. For instance, errors about the honesty policy might be confusing as some users might not know honesty policy is located in the settings page. (even if they are claiming the cert from the settings page)

@ahmadabdolsaheb

Why don't we redirect the user to the honesty policy when the first course is completed? After that make the certification claimable on the curriculum page.
Why not redirect the user to the login page if the user is not logged in and just completed one of the courses?

This should already remove most of the unneeded error messages and elements that are displayed in the superblock.
Thoughts?

Why not redirect the user to the login page if the user is not logged in and just completed one of the courses?

One of the philosophies that we believe in is to be able to go through the curriculum (but not claiming a cert.) without creating an account. You can be an anonymous learner. We do not need your data (email, name, etc.) unless you want us to have it for awarding a cert.

I understand,
I think my first statement is still valid. If the user is logged in (I don't know if the user has to be logged in to accept the honest policy) Why not directly move them to the honest policy (when the course is completed) with a notice that they are about to enter the certification part of the current course and recommend to log in to be able to claim the certification?

Here is the current user journey for the user to claim their certification.

Enter the  the link to last project, click on  'I have completed this challenge'
See progress modal 100%, click on 'submit ...'
See Donation modal, click 'maybe later'
land on the first project of the next certificate (this is confusing)

If we don't mind showing a third modal, I think we can have one after the donation modal with a minimal confetti animation that have relevant info and links for claiming the cert that the user worked so hard for.
We could also, have a claim certificate card that display this relevant info and links with claim cert button in certification map so the user has a place to go back to in case there are multiple items that needs attention before.
Thoughts?

Fun idea to add a confetti animation after completing a course. I also recommend showing the donation model after completing the course.
What if the user is able to claim the certificate inside the confetti-course-completion widget?

We could have the cert claimable if all requirements are passed.
If the user visits settings or claim and visit cert we will not be able to show the donation modal with relevant info. Therefore, donation modal need to come first.
Additionally, we might need to research what an optimal flow would be regardless of what we are offering currently.

I don't really understand what you mean by: "showing a donation modal with relevant info" ?

@Sembauke I understand the issue to be: Unless a Camper is donating, a modal containing a reminder about donating pops up every few challenges (5, I think).
So, with the current workflow, there is a conflict at step 2 (summarised this https://github.com/freeCodeCamp/freeCodeCamp/issues/38569#issuecomment-777745309):

Finish 5 projects, and submit
Donation modal appears (action must be taken - donate or close)
Camper needs to go to settings to claim cert

@ahmadabdolsaheb Personally, I would say please do not have a third modal.
What about changing the progress modal to include the certificate claiming information Mrugesh mentioned?

If it is a project modal && progress is 100%

That is a great idea Shaun. I understand an other modal popping up could be annoying.
Ps- After reading so many different messages in this discussion I get a bit lost.

@Sembauke I understand the issue to be: Unless a Camper is donating, a modal containing a reminder about donating pops up every few challenges (5, I think).

We do have a block completion donation modal that pops up after every 100% block completion and has a congratulatory message regarding the recently completed block.

What about changing the progress modal to include the certificate claiming information Mrugesh mentioned?

If it is a project modal && progress is 100%

I thought about that, but the project submission from the completion modal needs happen before showing certification info.

@ahmadabdolsaheb Can we combine this and #40873 to make the "widget" a button which brings up a Claim Certification  with Check modal?

Here is the the user journey that I think would make the most sense at this point. Feel free to leave your feedback.
Current

User enters the solution on the project form and clicks on button
User sees a completion modal and click submit
User is taken to the next superblock’s first project challenge.
User is shown a donation Modal and closes it.
User searches for how to claim a freeCodeCamp certificate
User lands on settings page
User finds and completes certification requirements one by one
User claims certificate and visits it
User sees donation element on top of the certification

Proposed

User enters the solution on the project form and clicks on button
User sees a completion modal and click submit
User is taken to the certificate part of super block page ( which has links to cert requirements, their status, and claim/show cert button)
User is shown a donation Modal and closes it
User follows links and completes requirements
User claims certificate and visits it from superblock page
User sees donation element on top of the certification.

note:

If this is implemented, we could a/b test removal of the donation modal for the projects block.
the certification card will be combined with the certification  or replace it.

I do not understand this section:

the certification card will be combined with the certification or replace it.

What is a 'certification card' ?

It is a pattern we use in the superblock page and landing page to group related information in a container.
ex. https://github.com/freeCodeCamp/freeCodeCamp/issues/38569#issuecomment-770375970

Here is what I have in mind for the certification card. We would probably just show the Show certification button after the certificate has been claimed.
I agree that incorporating the card into @moT01's widget would make it more appealing, but I could not find a way to make it functional and aesthetic at the same time.
Please let me know about your feedback so we could move forward with the implementation.

Might be my first thumbs down ever - it's a sarcastic thumbs down though. It's fine to get rid of my widget - I just liked it. This does look pretty good, I suppose.

We can have that widget replace this "card" when the cert is claimed? I kind of liked that too.

Some side notes on our current flow that I just noticed: you don't actually need to have your timeline or certifications public to claim a cert. Also, setting your timeline to private doesn't actually disable your certs, this look like a bug - you can still view the cert.

Also, setting your timeline to private doesn't actually disable your certs

Should it? I know the settings page says it does, but why? The timeline is the bit at the bottom, but the certificates would still be visible as buttons at the top. I'm wondering if that message should be removed, instead.

That's certainly something we can discuss. I suppose if you hide your timeline, you perhaps intend to hide your submitted projects - which need to be visible for the certs?

@ahmadabdolsaheb I am alo "thumbs down" in approval. That looks excellent.

We can have that widget replace this "card" when the cert is claimed?

I would like this too.

Should it?

@nhcarrigan This is related here, I think: https://github.com/freeCodeCamp/freeCodeCamp/issues/40403#issuecomment-779957353

You'd also have to hide the actual certifications, tho - since we now have the projects showing up there.

I made [an issue] to move the discussion around the private timeline over there, but it might be related enough to just keep here.


GoogleSignin.signIn() Promise never resolved.

I'm trying to use this library using Android 7.1.2 developing with RN 0.50.3 and ExpoKit (SDK23). I already had installed and compiled everything just fine. Everytime I call this function the Google Sign In shows in the phone, I choose my account and then nothing, the promise is never resolved, not even rejected.
I tried adding this line of code to search for the resolving data but it seems that the event is never called.
DeviceEventEmitter.addListener('RNGoogleSignInSuccess', user => console.log("RNGoogleSignInSuccess", user));
If later of that I call the function currentUserAsync() it shows that the user is logged in. I can do signOut() too. The single promise that is never resolved is signIn()
I followed every single step of installation, no errors, not even in the logcat.
Any help please?

Check in your MainActivity.java if you override onActivityResult. The same thing happened in our project where we had overridden it without calling super on it.
Make sure it looks like this:
@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    // Your other code
}

I got this problem too and get an error message { [GoogleSigninError: DEVELOPER_ERROR] name: 'GoogleSigninError', code: 10 }

In an effort to clean the issues up, this is being closed. Please open a new issue with a reproduction if you're still experiencing a problem.

@guidotajan did you find a solution? Worried this is a Expo issue.


SYNSPEC not generating an output for low abundance input

Many a times when the program is run with low values of abundances, SYNSPEC doesn't generate any output. This might lead to an incorrect estimation of the zero value. There are two strategies to make sure that an output is generated:

Having a sufficiently large abundance.
Having a sufficiently small value of the parameter RELOP in fort.55

We could begin with the program giving a warning whenever the output is not generated.

Issue solved by reducing the RELOP parameter till the program starts doing the calculations.


Remove semicolon in withSafeArea HOC children

Closes: #35

Timing is everything haha, caught me at the right moment


Chrome Extension

Hello, people!
Some time ago I've got tired to switch tabs between ramdajs.com/docs. And today I had some free time and decide to do small Chrome Extension(Ramda Docs) for the sake of easier access to documentation.
I did think at the moment of coding and publishing, but now I understand, that it would be better to ask your permission to use Ramda logo for extension... But better later than never, so I'm asking your permission.
Otherwise, I'll change it on somthing another.
Cheers!

:+1:

@kedashoe thanx 😀

As it says in Ramda's README

Thanks to J. C. Phillipps for the Ramda logo. Ramda logo artwork © 2014 J. C. Phillipps. Licensed Creative Commons CC BY-NC-SA 3.0.

So long as you abide by the license, you should be fine.
And I look forward to trying out your extension!

@CrossEye thank you! Would be great to here any feedback :+1:

@iamstarkov Before the topic closes I just wanted to say, I think this extensions sounds like a great idea. I just installed it and gave it a spin.
I'm actually going to make a PR if that's ok, to fix the header links.

@mrosata thank you very much! :+1:

@mrosata hm?

Added this to the Tools Section of the Wiki.


Retrieve invoice PDF not working for me

I am trying to get a recurly invoice pdf.
routes.get('/invoices/:invoice_number', (req, res) => {
  const invoiceNumber = req.params.invoice_number
  recurly.invoices.exportPdf(invoiceNumber, (response) => {
    if(response.status === 'ok') {
      sendPdf(res, response.data)
    } else {
      res.send(response)
    }
  });
});

const sendPDF = (res, data) => {
  res.setHeader('Content-Type', 'application/pdf');
  res.send(data);
}

The recurly response looks like this...

Client code looks like this...
 client.get('/invoices/' + this.props.invoiceNumb)
    .then(function(result) {
      const blob = result.blob()
      var blobUrl = URL.createObjectURL(blob);
      window.open(blobUrl);
    })
    .catch((err) => {
      console.log('invoice error:', err)
    })

I've tried adding encoding:null in the request headers and converting the recurly response to a base64 string and a few other things, but whenever the pdf opens in a new url I get "Failed to load PDF document". Any ideas what the problem is?

Fixed by #15 & released as v2.4.2, closing.
This is how I got it to work:
recurly.invoices.exportPdf(invoiceNumber)
.then(result => {
	res.setHeader('content-type', 'application/pdf');
	# to omit the (automatically added) charset from the content-type header
	res.send(200, new Buffer(result.data));
});


Implement reverseTransitionDuration for TransitionRoute

Description
This change allows developers to implement a reverse duration for a page transition. It defaults to the forward transitionDuration if it isn't specified.
// SAMPLE CLASS:
class ModifiedReverseTransitionDurationRoute<T> extends MaterialPageRoute<T> {
  ModifiedReverseTransitionDurationRoute({
    @required WidgetBuilder builder,
    RouteSettings settings,
    Duration reverseTransitionDuration,
    bool fullscreenDialog = false,
  }) : _reverseTransitionDuration = reverseTransitionDuration,
       super(
         builder: builder,
         settings: settings,
         fullscreenDialog: fullscreenDialog,
       );

  @override
  Duration get reverseTransitionDuration => _reverseTransitionDuration;
  final Duration _reverseTransitionDuration;
}

// USAGE:
Navigator.of(context).push(
  ModifiedReverseTransitionDurationRoute<dynamic>(
    builder: (BuildContext innerContext) {
      return Container(color: Colors.green);
    },
    reverseTransitionDuration: const Duration(milliseconds: 150), // modified value
  ),
);

Related Issues
n/a
Tests
I added the following tests:
Added a test for the default reverse transition duration
Added a test for a custom reverse transition duration
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

What does it look like when you have a transitionDuration of x and a reverseTransitionDuration of y and while the push of a route is ongoing you pop it again? Is there a jump in the animation? Or does it smoothly switch direction?

When you interrupt the push of a route that is ongoing with a pop, it does not cause a jump in animation if the animations are properly defined. For example, with ZoomPageTransitionsBuilder and FadeUpwardsTransitionsBuilder smoothly switch directions. The only difference was that the reverse transition duration was honored.

@goderbauer I added the forward smooth transition test. PTAL


New version: WinDirStat.WinDirStat.Beta (version <IP_ADDRESS>4.10.04)

Checklist for Pull Requests

[Y] Have you signed the Contributor License Agreement?
[N] Is there a linked Issue?

Manifests

[Y] Have you checked that there aren't other open pull requests for the same manifest update/change?
[Y] This PR only modifies one (1) manifest
[Y] Have you validated your manifest locally with winget validate --manifest <path>?
[Y] Have you tested your manifest locally with winget install --manifest <path>?
[Y] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Verify:

FYI: https://github.com/windirstat/windirstat/issues/88


fix slug to point to right name

Addressing issue #132

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   79.17%   79.17%
=======================================
  Files           4        4
  Lines         869      869
=======================================
  Hits          688      688
  Misses        181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4485719...e29ff60. Read the comment docs.


Circular dependency

I'm using the latest stable version of react-tooltip-lite, 1.10.0.
When I build my packages for production I get the following warning :

(!) Circular dependency: node_modules/react-tooltip-lite/dist/position.js -> node_modules/react-tooltip-lite/dist/getDirection.js -> node_modules/react-tooltip-lite/dist/position.js

It seems to be handled gracefully by npm but maybe worth looking at ?

Hey @maeligg I'll be looking at this soon as I'm working on a bunch of these issues this week.

@maeligg this should be fixed now in v1.11.2


Installing v0.17 on system with Controlled Folder Access triggers alerts

Environment
Windows build number: 10.0.18363.778
PowerToys version: 0.17 (in place upgrading from 0.16)
PowerToy module for which you are reporting the bug (if applicable): installer

Steps to reproduce
as a non-admin, download and install 0.17 over 0.16. Respond to UAC prompt for elevation.
Expected behavior
installation does not throw Controlled Folder Access errors
Actual behavior
Installer throws two Controlled Folder Access errors (see screenshots). PowerToys eventually appears to install - though install state is unknown, but appears OK
Screenshots

I see there's no response to this issue. Perhaps I could add a little more information that might attract some response. This issue is observed when a Standard User installs and uses UAC elevation prompts for Admin password to complete the installation.
I can't comment on the behaviour in 0.18.1 because I have an issue in that version that prevents me from accessing the Settings. I have raised a separate issue for that.

@mccrispy, can you revisit this in .19 come Tuesday when we release the updated version.  The settings issue should be resolved.

@@mccrispy any chance you got to see if 0.19 corrected this?


Load theme on Blue Ocean

Part of https://github.com/jenkinsci/dark-theme-plugin/issues/89

Should the theme extension have an option to decide whether it wants to be enabled for BlueOcean or not?

I was wondering about that, sure

I would recommend disabling themes for Blue Ocean by default, because it
has a different CSS structure which still needs an update IMHO.
On Tue, Jun 16, 2020 at 9:05 AM Tim Jacomb<EMAIL_ADDRESS>wrote:

Should the theme extension have an option to decide whether it wants to be
enabled for BlueOcean or not?
I was wondering about that, sure
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/theme-manager-plugin/pull/11#issuecomment-644574841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW4RIH7SQYTXCEMBZBZRX3RW4KSTANCNFSM4N7KGIRA
.

and it works 😂

and it works 😂

I won't believe until I see the screenshots :P

😂

BlueOcean development is painful, haven't managed to get it live reloading.
Only way I've managed to get css changes to work is to update is to run:
mvn clean install -D skipTests -Dspotbugs.skip

on the jenkins-design-language submodule which takes ~50 seconds -.-

BlueOcean development is painful, haven't managed to get it live reloading.

https://chrome.google.com/webstore/detail/live-editor-for-css-less/ifhikkcafabcgolfjegfcgloomalapol?hl=en and so on?

BlueOcean development is painful, haven't managed to get it live reloading.

https://chrome.google.com/webstore/detail/live-editor-for-css-less/ifhikkcafabcgolfjegfcgloomalapol?hl=en and so on?

probably not the most helpful as it's less files that need to be changed,
but maybe for prototyping.
It's looking like this now anyway:


green screen

When I use large stream video to play, there will be a green screen phenomenon, how to solve it
Video stream: 8192x3840 25fps

Did you manage to fix this?


Adding version to status endpoint

Description
Added chef-server version in status endpoint
Issues Resolved
resolves #2147
Check List

[ ]  All buildkite tests pass

closing in favor of #2190


Server certificate validation failed

Hello Mat !
Tanks for your Job !
I want to add your integration to my HA v2023.12.4 but  when HA alone detects my DSS, I enter the user password as well as the fingerprint key
07:97:68:03:29:9C:3A:B5:44:B8:0D:C2:69:B8:CA:F4:C7:92:E7:C8:54:D3:3E:84:88:65:A8:BA:D7:5D:AF:BF
and y have a error message Server certificate validation failed

You have any ideas for me ?
My DSS its updated to V <IP_ADDRESS>
Many Tanks

That usually means that the fingerprint does not match the server certificate. Did you follow these steps to get the fingerprint from the DSS?

Yes exactly but not working. Its not possible to bypass this ?

Not with the current version of this component. I can add an option to bypass it in a future version.

Ok i have reboot my DSS, change password but noway :-(

Okay, I added the option. To try it you need to re-install the integration in HACS, enable "Show beta versions" and select "main" as the version. Then instead of the fingerprint type the word "ignore".

Tanks ! Its work ! Tank you so mutch !!!!

Tanks ! Its work ! Nice job :-)


When logging into authenticated rancher, it takes me to Hosts page instead of Services

v0.22.0-rc1
Steps:

Go to rancher and authenticate
Log out then log back in

Results:
Takes me to Host page as default
Expected:
Should take me to Services main list page

This was fixed at some point..

build from master - June 10th
Verified fixed


docs: add greptimedb as a compatible prw receiver

The patch adds greptimedb as remote writer receiver.

@sunng87 Thanks! I have a feeling that this remote write spec doc (which is also somewhat out of place in the menu hierarchy and should be more of an internal hidden detail somewhere) is probably not the right place to maintain a full list of remote write integrations, especially since we already have that here: https://prometheus.io/docs/operating/integrations/#remote-endpoints-and-storage - so I would recommend adding yourself to that list instead (or in addition, I'm fine with both places being updated, I just think we should probably not maintain two in the long run).

@juliusv Nice. I was reading the spec and finding it might be helpful add greptimedb there. I just added on integration page as well.

:+1: Thanks! Yeah we might remove that other list sometime, but for now it's good :)


Update to work with Gradle 7

Change dependency type from 'compile' to 'implementation', runtime config name from 'runtime' to 'default'

taken care of in #75


Add pool to README

Zcash Pool http://luckpool.org Custom Frontend w/Miner's Jackpot

Zcash Zclassic Pool https://www.minergpu.com

minergpu seemed to be down so I didn't add it

@hellcatz
Unable to reject invalid share,
How to solve.
I saw
Http://luckpool.org also cannot deny invalid sharing.

@hellcatz
https://github.com/ceozero/equihashverify/commit/3c2cb9eb4334b4c7fa6714375a2cb62633a2d397
This is my fork, this coin can not accept zcash miners "find the block are orphans", but my pool can not refuse to share zcash miners.


fix styleguidist configuration so that everything gets its own page

Signed-off-by: Christopher Shepherd<EMAIL_ADDRESS>Impact: minor
Type: bugfix

Component
No components or dependencies changed, just updated styleguidist.config.js so that every topic gets its own page instead of rendering the whole style guide on one huge slow page

🚀 Preview deployed
Built with commit c90a25284e09f6bf4d8249045c48cb2ed81d92bd
https://deploy-preview-423--stoic-hodgkin-c0179e.netlify.com

Confirmed:

Lint failed tho!

@cshepherd be careful using the word fix in non-npm-module code-fix commits. (like any work on Styleguidist itself). i dont think this pr will trigger a release, cos that requires fix: though

Merging.

:tada: This PR is included in version 0.66.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Question about observers implementation

If you allow me, I have some questions about the way used for the implementation of the observers.

Firstly, why use three times the same observer on one property instead of one observer on three properties (like _updateFormattedDateMoment(date, dateFormat, utc))?

Secondly, why use an observer without parameter instead a computed property for isValid?

Finally, why do you prefer use observer without parameters? Is it a performance concern or readability?

Thank you for your answers and your help.

Thanks for asking the questions. It helps me to improve this element.

An observer with multiple properties is called if all of the properties were defined. e.g. if I use an observer like  _updateFormattedDateMoment(date, dateFormat, utc), the date, dateFormat and utc should be not undefined.
Thanks for the suggestion :pray: . I'll try to replace it with a computed property.
It's not a performance concern. I just want to have readable code :smirk:

Thank you for the answer.

That's why I couldn't make it work with parameters!  👊 😵 😴 🏥
The computed property works, I already tried it. ✅
This point is subjective.

@LM450N Could you create a PR for changing the isValid to a computed property?

@LM450N Thanks for really quick PR.


FFI Improvements

Fixes/Improvements:

FFI::load allows only string arguments
FFI::cdef returns an instance of FFI in cases where declarations are more than one.
Although it is noted in the documentation that some FFI functions/mettods passes objects by reference (that is, they can change them), but in reality this is not so. Fix it.

P.S. In addition, there are still problems:

FFI::new(...) can be called both statically and using the current FFI scope: FFI::load('...')->new(...) however, stubs do not allow this
Same with FFI::cast, FFI::type and FFI::arrayType

$function = new ReflectionMethod('FFI', 'free');
foreach ($function->getParameters() as $param) {
    if ($param->isPassedByReference()) {
        echo $param->getName() . ' is passed by reference';
    }
    echo PHP_EOL;
}

says that it's still by reference.
@SerafimArts Could you please elaborate on how you checked that objects are not passed by reference.

says that it's still by reference.

Aha, interesting.
Maybe CData & should be replaced with CData|CData& ...? But I'm not sure about using & in @param is a valid type notation or not on tools.
In case of any good solution couldn't be found, I suggest to revert changes only about pass by reference.
<?php // test1.php
$function = new ReflectionMethod('FFI', 'free');
foreach ($function->getParameters() as $param) {
    if ($param->isPassedByReference()) {
        echo $param->getName() . ' is passed by reference';
        if ($param->canBePassedByValue()) {
            echo ' and also can be passed by value';
        }
    }
    echo PHP_EOL;
}

% php test1.php
ptr is passed by reference and also can be passed by value

<?php // test2.php
\FFI::cast('void *', \FFI::new('char *'));
echo 'accepts passed by value', PHP_EOL;
(function (\FFI\CData &$param) {
    echo 'outputs notice at passed by value', PHP_EOL;
})(\FFI::new('char *'));

 % php test2.php
accepts passed by value
PHP Notice:  Only variables should be passed by reference in /home/sji/work/test2.php on line 6
outputs notice at passed by value

2nd parameter of \FFI:cast() can be passed by value without notice.
Actually all parameters in methods of this class accept passing parameter by value, including \FFI::memcmp().
FYI:
They are defined as ZEND_SEND_PREFER_REF in its arginfo.
https://github.com/php/php-src/blame/fee614f66bfb72384c7c6f316cad0c5c68fa9c0c/ext/ffi/ffi.c#L4460-L4538
They accept both value and reference.
It seems that extensions can define such functions unlike userland functions.
array_multisort() is another example of such functions, though the manual says the first parameter is simply a reference here too.
https://www.php.net/manual/ja/function.array-multisort.php
% php -r "var_dump(array_multisort([]));"
bool(true)

@bzixilu
FFI::free(FFI::new('int8_t', false));

If the argument required passing by reference, this code would cause an error like this:
function my_free(\FFI\CData &$ref)
{
    FFI::free($ref);
}

my_free(FFI::new('uint8_t', false));
// Notice: Only variables should be passed by reference in xxxx

Unfortunately the FFI extension contains quite a bit of "magic". A number of parameters are declared using the PREFER_REF send mode, which will try to pass by reference is possible and by value otherwise. In ReflectionParameter, such a case should be visible by both isPassedByReference() and canBePassedByValue() returning true (usually, only one of them can be true).
The reason for this behavior is this (example taken from 040.phpt):
$y = FFI::new("int[2]");
$y[0] = 6;
var_dump(FFI::cast("int8_t[4]", $y[0]));

Normally, writing $y[0] will return just int(6). However, FFI::cast() wants to receive FFI\CData instead. By accepting the parameter by reference, it will be fetched "for writing", in which case $y[0] will return the FFI\CData value, not the scalar it contains. Other FFI parameters work similarly.
This is bad design in the FFI extension (it should have always provided FFI\CData, and an extra call or cast to get the scalar value), but well, this is the situation we have to deal with now...
For the purposes of this PR, I agree that it's best to remove the & in stubs. From the end-user perspective the fact that by-reference passing is used is not important (and it's really just an internal hack anyway). So this looks good to me (modulo the suggested change by @sj-i, to keep phpdoc in sync).

@SerafimArts merged, thank you for your contribution!


Ingres jdbc port parsing

Closes #1198 - allow non-numeric port in connection URL parsing (not sending port, but avoid failing parsing).

Codecov Report

Merging #1199 into master will increase coverage by 10.59%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #1199       +/-   ##
=============================================
+ Coverage     59.20%   69.79%   +10.59%
- Complexity       83     2321     +2238
=============================================
  Files           338      228      -110
  Lines         15927    10370     -5557
  Branches       2223     1343      -880
=============================================
- Hits           9429     7238     -2191
+ Misses         5853     2687     -3166
+ Partials        645      445      -200

Impacted Files
Coverage Δ
Complexity Δ

...stic/apm/agent/jdbc/helper/ConnectionMetaData.java
89.18% <100.00%> (+0.18%)
11.00 <0.00> (+11.00)

...a/co/elastic/apm/agent/profiler/ThreadMatcher.java

...stic/apm/agent/kafka/BaseKafkaInstrumentation.java

...o/elastic/apm/agent/okhttp/OkHttpClientHelper.java

...ain/java/co/elastic/apm/attach/RemoteAttacher.java

...apm/agent/quartz/job/JobTransactionNameAdvice.java

...spring/webmvc/ExceptionHandlerInstrumentation.java

...apm/agent/okhttp/OkHttp3ClientInstrumentation.java

.../agent/hibernate/search/HibernateSearchHelper.java

.../apm/agent/process/ProcessExitInstrumentation.java

... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa4a3b...43c35c7. Read the comment docs.

:broken_heart: Tests Failed

Expand to view the summary

Build stats

Build Cause: [Pull request #1199 opened]

Start Time: 2020-05-24T10:33:58.570+0000

Duration: 20 min 46 sec

Test stats :test_tube:

Test
Results

Failed
1

Passed
796

Skipped
1

Total
798

Test errors
Expand to view the tests failures

Name: Tests / Unit Tests / testHttpCallWithIpv4 – co.elastic.apm.agent.okhttp.OkHttp3ClientAsyncInstrumentationTest

Age: 1
Duration: 1.81
Error Details: null

Steps errors
Expand to view the steps failures

Name: Shell Script

Description: #!/bin/bash                set -euxo pipefail                ./mvnw test

Duration: 8 min 56 sec

Start Time: 2020-05-24T10:45:27.890+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-05-24T10:53:36.033Z] | Lettuce34StopSpanInstrumentation$OnCancel          |      31,024,183 |       1,240,410 |
[2020-05-24T10:53:36.033Z] | Lettuce5StartSpanInstrumentation                   |       3,368,814 |               0 |
[2020-05-24T10:53:36.033Z] | Lettuce5StopSpanInstrumentation$OnComplete         |       2,884,421 |               0 |
[2020-05-24T10:53:36.033Z] | Lettuce5StopSpanInstrumentation$OnCancel           |       1,997,162 |               0 |
[2020-05-24T10:53:36.033Z] | Lettuce5StopSpanInstrumentation$OnCompleteExceptionally |       1,863,748 |               0 |
[2020-05-24T10:53:36.033Z]
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,777 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.impl.transaction.AbstractSpan - decrement references to 'transaction' 00-81f66f43bb61bad681c0af3bc94b8e30-1af7d66eaf3bc301-01 (720a1ab3) (2)
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,777 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.impl.transaction.AbstractSpan - decrement references to 'SET' 00-81f66f43bb61bad681c0af3bc94b8e30-9e584340495caf7e-01 (70790b54) (0)
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,777 [elastic-apm-circuit-breaker] INFO  co.elastic.apm.agent.impl.circuitbreaker.CircuitBreaker - Stopping the Circuit Breaker thread.
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,786 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.objectpool.impl.BookkeeperObjectPool - recycling pooled object: 'SET' 00-81f66f43bb61bad681c0af3bc94b8e30-9e584340495caf7e-01 (70790b54)
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,792 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.impl.transaction.AbstractSpan - decrement references to 'transaction' 00-81f66f43bb61bad681c0af3bc94b8e30-1af7d66eaf3bc301-01 (720a1ab3) (1)
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,792 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.impl.transaction.AbstractSpan - decrement references to 'GET' 00-81f66f43bb61bad681c0af3bc94b8e30-92169098f60eef62-01 (25976988) (0)
[2020-05-24T10:53:36.033Z] 2020-05-24 10:53:35,792 [elastic-apm-init-instrumentation-shutdown-hook] DEBUG co.elastic.apm.agent.objectpool.impl.BookkeeperObjectPool - recycling pooled object: 'GET' 00-81f66f43bb61bad681c0af3bc94b8e30-92169098f60eef62-01 (25976988)
[2020-05-24T10:53:36.609Z]
[2020-05-24T10:53:36.609Z] Results :
[2020-05-24T10:53:36.609Z]
[2020-05-24T10:53:36.609Z] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[2020-05-24T10:53:36.609Z]
[2020-05-24T10:53:36.609Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:integration-test (default) on project apm-lettuce-plugin: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:integration-test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[2020-05-24T10:53:36.609Z] [ERROR] Command was /bin/sh -c cd /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin && /var/lib/jenkins/.java/oracle-10+46-linux/bin/java -javaagent:/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/.m2/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin/target/jacoco.exec -jar /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin/target/surefire/surefirebooter2298976822715600114.jar /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin/target/surefire/surefire1322507723093091725tmp /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java/apm-agent-plugins/apm-redis-plugin/apm-lettuce-plugin/target/surefire/surefire_112681148873461904257tmp
[2020-05-24T10:53:36.609Z] [ERROR] -> [Help 1]
[2020-05-24T10:53:36.609Z] [ERROR]
[2020-05-24T10:53:36.609Z] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[2020-05-24T10:53:36.609Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[2020-05-24T10:53:36.609Z] [ERROR]
[2020-05-24T10:53:36.609Z] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[2020-05-24T10:53:36.609Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[2020-05-24T10:53:36.609Z] [ERROR]
[2020-05-24T10:53:36.609Z] [ERROR] After correcting the problems, you can resume the build with the command
[2020-05-24T10:53:36.609Z] [ERROR]   mvn <goals> -rf :apm-lettuce-plugin
[2020-05-24T10:53:36.905Z] script returned exit code 1
[2020-05-24T10:53:38.373Z] Post stage
[2020-05-24T10:53:38.404Z] Recording test results
[2020-05-24T10:53:38.469Z] Post stage
[2020-05-24T10:53:38.497Z] Recording test results
[2020-05-24T10:53:39.426Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java
[2020-05-24T10:53:39.443Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199/src/github.com/elastic/apm-agent-java
[2020-05-24T10:53:39.476Z] [INFO] Codecov: Getting branch ref...
[2020-05-24T10:53:39.491Z] [INFO] Codecov: Getting branch ref...
[2020-05-24T10:53:39.528Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-24T10:53:39.557Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-24T10:53:39.884Z] [INFO] Codecov: Sending data...
[2020-05-24T10:53:39.910Z] [INFO] Codecov: Sending data...
[2020-05-24T10:53:40.396Z] + curl -s -o codecov.sh https://codecov.io/bash
[2020-05-24T10:53:40.396Z] + bash codecov.sh
[2020-05-24T10:53:40.396Z]
[2020-05-24T10:53:40.396Z]   _____          _
[2020-05-24T10:53:40.396Z]  / ____|        | |
[2020-05-24T10:53:40.396Z] | |     ___   __| | ___  ___ _____   __
[2020-05-24T10:53:40.396Z] | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
[2020-05-24T10:53:40.396Z] | |___| (_) | (_| |  __/ (_| (_) \ V /
[2020-05-24T10:53:40.396Z]  \_____\___/ \__,_|\___|\___\___/ \_/
[2020-05-24T10:53:40.396Z]                               Bash-20200430-d757c17
[2020-05-24T10:53:40.397Z]
[2020-05-24T10:53:40.397Z]
[2020-05-24T10:53:40.397Z] ==> Jenkins CI detected.
[2020-05-24T10:53:40.397Z]     project root: .
[2020-05-24T10:53:40.499Z] + curl -s -o codecov.sh https://codecov.io/bash
[2020-05-24T10:53:40.657Z] --> token set from env
[2020-05-24T10:53:40.658Z]     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
[2020-05-24T10:53:40.658Z] ==> Running gcov in . (disable via -X gcov)
[2020-05-24T10:53:40.658Z] ==> Python coveragepy not found
[2020-05-24T10:53:40.658Z] ==> Searching for coverage reports in:
[2020-05-24T10:53:40.658Z]     + .
[2020-05-24T10:53:40.763Z] + bash codecov.sh
[2020-05-24T10:53:40.763Z]
[2020-05-24T10:53:40.763Z]   _____          _
[2020-05-24T10:53:40.763Z]  / ____|        | |
[2020-05-24T10:53:40.763Z] | |     ___   __| | ___  ___ _____   __
[2020-05-24T10:53:40.763Z] | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
[2020-05-24T10:53:40.763Z] | |___| (_) | (_| |  __/ (_| (_) \ V /
[2020-05-24T10:53:40.763Z]  \_____\___/ \__,_|\___|\___\___/ \_/
[2020-05-24T10:53:40.763Z]                               Bash-20200430-d757c17
[2020-05-24T10:53:40.763Z]
[2020-05-24T10:53:40.763Z]
[2020-05-24T10:53:40.763Z] ==> Jenkins CI detected.
[2020-05-24T10:53:40.763Z]     project root: .
[2020-05-24T10:53:40.763Z] --> token set from env
[2020-05-24T10:53:40.763Z]     Yaml not found, that's ok! Learn more at http://docs.codecov.io/docs/codecov-yaml
[2020-05-24T10:53:40.763Z] ==> Running gcov in . (disable via -X gcov)
[2020-05-24T10:53:40.763Z] ==> Python coveragepy not found
[2020-05-24T10:53:40.763Z] ==> Searching for coverage reports in:
[2020-05-24T10:53:40.763Z]     + .
[2020-05-24T10:53:41.229Z] --> No coverage report found.
[2020-05-24T10:53:41.229Z]     Please visit http://docs.codecov.io/docs/supported-languages
[2020-05-24T10:53:41.339Z] --> No coverage report found.
[2020-05-24T10:53:41.339Z]     Please visit http://docs.codecov.io/docs/supported-languages
[2020-05-24T10:53:41.732Z] Failed in branch Smoke Tests 01
[2020-05-24T10:53:41.855Z] Failed in branch Smoke Tests 02
[2020-05-24T10:53:42.153Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-05-24T10:53:42.256Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-24T10:53:42.311Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-24T10:53:42.411Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-05-24T10:53:43.241Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1199
[2020-05-24T10:53:43.355Z] [INFO] getVaultSecret: Getting secrets
[2020-05-24T10:53:43.432Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-24T10:53:44.349Z] + chmod 755 generate-build-data.sh
[2020-05-24T10:53:44.349Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1199/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1199/runs/1 FAILURE 1185504
[2020-05-24T10:53:44.900Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1199/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-24T10:53:45.451Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1199/runs/1/tests/?status=FAILED -o tests-errors.json

That seems to fix the Exception and allow the agent to push data to the APM-Server. Thanks!

Great, thanks for confirming!


A script to fix up the configuration for k3s

a relevant discussion on slack: https://kubernetes.slack.com/archives/C09R1PJR3/p1552987976101700

/lgtm

/approve
@shashidharatd I'll leave you to lgtm.

/lgtm


Change tiling/packing order to be more vectorization friendly

This PR tries to first pack to improve the chances of getting the desired pack and then chooses the inner k tile based on the resulting untiled size.

This commit LGTM. But I would suggest to further refactor the selection of tile sizes including the ones used by ukernel path that @Abhishek-Varma have currently.

This commit LGTM. But I would suggest to further refactor the selection of tile sizes including the ones used by ukernel path that @Abhishek-Varma is working currently.
@Abhishek-Varma is going to work on that tomorrow.


Update provider versions

Upgrades the azurerm provider to version 3.27.0
This changes needed some further adjustments. Now usage of an oms_agent requires a distinct aks-cluster to be created.
Further removes values that were set to their default value.

Replaced by https://github.com/dspace-group/simphera-reference-architecture-azure/pull/44


Footer note misplacement fix false positive

Fix false positive mentioned in the https://github.com/nblockchain/conventions/issues/118.

Fix false positive mentioned in the https://github.com/nblockchain/conventions/issues/118.

Why is this not written in the commit msg of the last commit? /cc @webwarrior-ws


fix minor issues

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@devel dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Changing the +monster command

🚀 Feature Proposal
Changing the +monster (name) command to a +info (name) this way it can be used for monsters, minigames and skilling. I personally think it makes more sense as the +monster command gives info on certain things anyway.
Thanks Kowzy

was resolved with slash command


Win platfom: Popup show on unexpected window when app using multiple window

like https://github.com/CommunityToolkit/Maui/issues/1616
reproduce:
1.open 2 new windows
2.invoke var result = await DialogService.DisplayCheckBoxPromptAsync("Title", new []{ "Option 1", "Option 2", "Option 3"}); on the second window
3.the Popup will show on the first window

UraniumUI doesn't implement popup logic by itself. It has options such as CommunityToolkit and Mopups.
Probably the problem is related to CommunityToolkit.
Can you try Mopups dialogs if the same problem occurs or not?

Mopups  tested, it also shows on the first window.

in the latest 2.8.0-pre version, UraniumUI implemented different logic for IDialogService, so if you don't use any adapter like Mopups or CommunityToolkit, it'll use the current page to display dialogs and renders it itself instead real native popup.
In this way, it'll not be a platform native dialog but it serves its purpose

Awesome! Thank you very much!


Please let me know how to request a full snap shot when proceeding with the snap shot.

Please let me know how to request a full snapshot when proceeding with the snapshot.
ISSUE TYPE

Bug Report
Improvement Request
Enhancement Request
Feature Idea
Documentation Report
Other

COMPONENT NAME

CLOUDSTACK VERSION

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Hi @tjkim980702 , What is the underlying hypervisor used? I think, except XenServer, for other hypervisors, the full snapshot is taken.

Hi @tjkim980702 there isn't any details provided for us to investigate the issue any further - for this reason I'm closing this for now. However, kindly re-open the issue if you've any further details for us.


added quota rate limit

WIP

Coverage decreased (-11.6%) to 78.723% when pulling abf305455e46a28388de134dda800c39d48f6e59 on lchayoun:Feature/QuotaRateLimit into ffc9b4d808dc588c8bbbf69c8ae44e8dd957ce6f on marcosbarbero:master.

Coverage decreased (-11.6%) to 78.723% when pulling abf305455e46a28388de134dda800c39d48f6e59 on lchayoun:Feature/QuotaRateLimit into ffc9b4d808dc588c8bbbf69c8ae44e8dd957ce6f on marcosbarbero:master.

Coverage decreased (-11.2%) to 79.144% when pulling be16c1931d129e8157f40db98db00c03fdb8bbcd on lchayoun:Feature/QuotaRateLimit into ffc9b4d808dc588c8bbbf69c8ae44e8dd957ce6f on marcosbarbero:master.

Coverage decreased (-11.2%) to 79.144% when pulling be16c1931d129e8157f40db98db00c03fdb8bbcd on lchayoun:Feature/QuotaRateLimit into ffc9b4d808dc588c8bbbf69c8ae44e8dd957ce6f on marcosbarbero:master.

@marcosbarbero coveralls didn't run on the last commit, how can we make it run?
I think this pull is ready for review.

I'll run it


Storybook : Cleanup and test of existing components

The PR by @telamonian to add Storybook has been merged.
Each component is expected to have an associated .stories.tsx file as we can already see here : https://github.com/Quansight/conda-store-ui/tree/main/src/features/requestedPackages/components
4 components out of the 6 have their .stories.tsx file done, 2 are missing :

[ ] List of dependency packages - read-only
[ ] List of dependency packages - edit mode

PR: https://github.com/Quansight/conda-store-ui/pull/42


Prevent empty decommits

fix #1502
Add a test that convinces us empty inputs in decommit tx are prevented.

[x] CHANGELOG updated or not needed
[x] Documentation updated or not needed
[x] Haddocks updated or not needed
[x] No new TODOs introduced or explained herafter

@v0d1ch Please also resolve the corresponding TODO in HeadLogic.hs https://github.com/input-output-hk/hydra/blob/1246d3590d247c945bd9f04d213ab33f0ac0f390/hydra-node/src/Hydra/HeadLogic.hs#L735


Improving the Custom Methods and Add Batch on get Method

I merged this PR on wrong branch, i will open another PR


[cache] #45109 add stale while revalidate cache header

Q
A

Branch?
5.4

Bug fix?
no

New feature?
yes

Deprecations?
no

Tickets
-

License
MIT

Doc PR
-

This PR allow support for RFC5861.Meaning you can now use stale_while_revalidate and stale_if_errorhttps://httpwg.org/specs/rfc5861.htmlVery interesting doc from Fastly on the subject:https://developer.fastly.com/learning/concepts/stale/

Link to the issue
https://github.com/symfony/symfony/issues/45036

What the bot said :)

Sorry, I move on the correct project.


add events

var db = new PouchDB('dbname')
var api = db.hoodieApi()

api.on('add', function(object, options) {})
api.on('update', function(object, options) {})
api.on('remove', function(object, options) {})
api.on('change', function(eventName, object, options) {})

api.one('add', function(object, options) {})
api.off('add', handler)

Events should be implemented using EventEmitter. See implementation / tests in https://github.com/hoodiehq/wip-hoodie-store-on-pouchdb

ignore sync / clear events
ignore scoping with storeOptions.type
Implementation should not bloat the code for modular usage:

PouchDB.plugin({
  add: require('pouchdb-hoodie-api/add')
})

@patriciagarcia could you add a test, in which a doc gets created in the db before we initiate the api, to make sure that no change event gets triggered for it?

@gr2m, before we initiate the API or before we start listening to events?

excellent good question :) Before listening to events makes sense, it will cover the "before we initiate the API" part, too

there is one here https://github.com/hoodiehq/pouchdb-hoodie-api/commit/993c1a9ec880a82b4d29eca52fb02dac851eec40 :)

closed via https://github.com/hoodiehq/pouchdb-hoodie-api/pull/34


oauth / simple HTTP auth

Would be nice just to put a password so can have concrete running on a public webserver,
Ideally oauth would be cool, so you can login from a github organisation.
I beleive janky implements this, and so the code may be reusable.

I'd love to see someone submit a pull request for this.

I'll have a look when a get some free time
Dharmesh
On 7 Feb 2012, at 19:03, Ryan Kee
<EMAIL_ADDRESS>wrote:

I'd love to see someone submit a pull request for this.

Reply to this email directly or view it on GitHub:
https://github.com/ryankee/concrete/issues/9#issuecomment-3853965


how to open pc.csv

After configuration my site show thumbnail of my point-cloud.
I click View which is link to
http://localhost/pointclouds/view?c=pointcloud_1
However,my site returns
`
Not Found
The requested URL was not found on this server.
`
Needless to say there isn't view directory under pointclouds.
Does anyone know how to open pc.csv itself?

I found the URL text http://localhost/pointclouds/view?c=pointcloud_1 is conbined at line-87 in homephp

<a class="btn btn-lg btn-primary" href="view?c=<?php echo $folderName >">View

Howevr, view doesn't explode  at linw-e24 in url.php
    $path['call_parts'] = explode('/', $path['call']);
I need to change  line-87 in homephp to

<a class="btn btn-lg btn-primary" href="view/?c=<?php echo $folderName >">View

or
$path['call_parts'] = array($path['call']);

Now,it has been stopping at 3% of its progress with error at .
var scene = new THREE.Scene();
The messages is ...
 ?c=pointcloud_1:68 Uncaught ReferenceError: THREE is not defined     at HTMLDocument.<anonymous> (?c=pointcloud_1:68)     at l (jquery.min.js:4)     at Object.fireWith [as resolveWith] (jquery.min.js:4)     at Function.ready (jquery.min.js:4)     at HTMLDocument.S (jquery.min.js:4)
`

Adding  is work.


Add the possibility to return metadata in binary format.

subxt codegen can use metadata as an input, it expect metadata in binary format, but subwasm metadata can return metadata in only JSON format.

Yeah that might be nice. Tbh would love the rpc layer to be able to return scale as binary rather than just json encoded binary because they may as well.


⚠ ClamAV has degraded performance

In 4566900, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 677 ms

Resolved: ClamAV performance has improved in cc202c4.


Change travis configuration for only supporting python 3.6

As discussed yesterday at the meetup it makes sense to change this setting in travis because otherwise all the checks will fail all the time

closed in #25


Refactor and Test of ConfigSecurity

What changes were proposed in this pull request?
Refactor of how to build Vault Url and a test class to test it
This PR has been tested with Kafka job( using Datastore profile) and an Elastic job.

LGTM


New version: MSI.Kombustor.4 version <IP_ADDRESS>

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves #168167

Microsoft Reviewers: Open in CodeFlow


chore: remove go workspace, handle them personal to each developer

Motivation and Context
Introduction
Although go workspace has been built to simplify managing multiple modules in a single codebase, we run into couple of very serious issues that we were not able to solve deterministically.
One example: We upgraded a dependency that is not used in any other Go module. This upgrade had the effect that another module dependency was upgraded. Due to this behaviour it was impossible to understand the dependency tree because the change was not reflected in the mod or sum file of any module. Luckily, our CI has catched this before it become a serious issue.
Conclusion
We used workspaces the wrong way. Meanwhile, community has built an opinion around the usage of Go workspaces. Go workspaces should be handled as personal to each developer and therefore not be committed.

https://github.com/SeldonIO/seldon-core/pull/4676
https://github.com/golang/go/issues/53502#issuecomment-1939306495

This makes sense, if you see them as a more manageable approach to replace directives.
More information https://earthly.dev/blog/go-workspaces/

Checklist

[ ] I have discussed my proposed changes in an issue and have received approval to proceed.
[ ] I have followed the coding standards of the project.
[ ] Tests or benchmarks have been added or updated.
[ ] Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
[ ] I have read the Contributors Guide.

@df-wg addressed, thanks.


Cleanup and simplification of test

I found this lib the other day and with only minor additions it'll fit my needs very nicely. These changes are only cleaning up (whitespace, alignment, etc) and simplifying (in particular the test I found to be difficult to grok at first). Hopefully you find these changes worthwhile.

Looks great, thank you!


Apply the ToQuantity fix to STU3 and DSTU2 versions of FHIR

Apply this fix #557 to the FHIR ModelInfo for STU3 and DSTU2.

Released in 1.5.1


Add endpoint for more efficient deleting

With this commit we add a new endpoint in Spandex-http for deleting all of the documents (dataset
copies, columns, and field values) associated with a particular dataset. The new endpoint returns
the counts of the different types deleted from the index. It uses the existing queries for finding
all documents by dataset ID and deleting (using ES's scan-and-scroll API).
Unit tests pass. Tested locally.

This build looks good.

Build failed.

not sure what to make of that jenkins error - your changes had nothing to do with versioning, so um ....?
Aside from that though, this looks fine and 🚢  when ready.

retest this please

This build looks good.


Lambda Layer Update : OTel Collector v0.63.0

This PR is created to update the collector and collector-contrib deps to v0.63.0.
Testing:

Superseded by #312.


[REQUEST] Softban lift

So, as some of us know, there is an easy way to lift softban:
walk to a pokestop, spin it and close it. You won’t be getting any rewards from it, however, doing so up to 40 times (or until you finally receive the rewards) will remove your soft ban.
This feature should be implemented.

Great

This is not true! It the soft ban is depending on your "jump" distance and can remain from 5 min to 4 hours. (Experts in bans, got a lot this and learn how to jump without getting a softban, but I will not post it public.)
The solution for the bot will be better like this:
If you don't get a rewards from pokestops (at least 2 pokestops need to be checked) logout for 5 min and try again.

I implemented what @svista said. Yet, didn't test if it works.

Dont implement that feature, it wont remove your softban, spinning 40 times just takes long enough to let it expire.

Spinnig 40 times will remove your soft ban.

I just tested this myself and it is 100% accurate. Softban was completely lifted and activity returned to normal after spinning and exiting a Pokestop around 40 times.

This "feature" sounds like "Autoban"

Works perfectly well for me. Should be implemented imo.

It is exactly 40 spins on the same pokestop. On the 40th spin, the pokestop will give you the items. We need to have this implemented asap in my opinion.

You know what else removes the soft ban? Just waiting a few minutes and restarting the bot...

Dont work if u across 5000km in 1 sec.

Is this legit? I feel like I need to test it. Would be great for when I want to teleport to the states to catch that elusive pokemon that's just appeared...

@wandering7man it actually does... just try it out ^^

Wow, is that real?  CC to @douglascamata @TheSavior

There is definitely something to this.
I had a bot running in new york, and decided to move it to australia after I caught two Tauro so that I could capture something new and try this out.
Upon restarting the bot, it did all the evolutions, then removed all dupes except the best two of each. - Well over 40 commands, but cannot remember the exact figure.
Once the bot started farming, it had no issues. Pokemon are being caught and stops are being spun.
So is it just 40 commands?
Needs more testing, but interesting none the less.


WIP: Migrate gengo v2

Working on moving our generators to the upstream WIP gengo v2 project.
Current issues I need to work through:

[ ] Gengo v2 has no verify-only option which we rely on in deepcopy, prerelease-lifecycle generators
[x] OpenAPI WIP branch is not up to date with K/K PR, so cannot integrate that yet
[ ] Pre-release lifecycle gen not integrated with codegen, it would be easier to manage if it were, very black box and only working on apps API group right now
[ ] Have a WIP proto integration to codegen that wasn't working in non GOPATH, may work now
[x] Check if deepcopy etc works correctly in non-gopath

/test verify

/remove-lifecycle stale
I need to come back to this


spark installation issue

Description

I created a new dsvm and had some problems when installing the spark environment. This fixes this problem
Related Issues

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging and not master.

TODO: review this with a new DSVM

On a new DSVM, SPARK_HOME is set correctly
$ echo $SPARK_HOME
/dsvm/tools/spark/current


Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout

Describe the bug
Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout
Steps to Reproduce

Load from file: Connection of bond to atom inside s-group supergroup cause it connected incorrectly in terms of layout.zip

Connect bond and the ring as shown on the pic:

Contract abbreviation

Actual behavior
Abbreviation label looks not attached to the bond

Expected behavior
Abbreviation label is attached to the bond

Environment details  (please complete the following information):

Indigo Toolkit Version 1.18.0-rc.8.0-g85a393c7c-x86_64-linux-gnu-11.2.1
Ketcher Version 2.18.0-rc.8 Build at 2024-02-22; 17:34:35
Chrome Version 122.0.6261.58 (Official Build) (64-bit)
Win10
Issue found while testing https://github.com/epam/Indigo/issues/1436

Dev team decided to implement another solution.

Not fixed.
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Moved to Refined Backlog as per process


Custom Functions

Hi all
Just wanted to give you a heads up that it should be possible to implement custom functions again. Custom functions are defined inside the dynamic scripting language and then registered with libsass. Then they can be called/referenced from scss/sass files, similar to internal functions.
Not sure if node-sass had that feature before the libsass refactoring. I fixed some bits on libsass so the Perl Bindings, which already had custom functions, would work again. So maybe you can profit off of that work, since both implementations are bindings to a dynamic scripting language. Maybe you also want to expose sass2scss to convert indented syntax to scss syntax.
There is a new custom precision feature, which unfortunately has a regression. I also added the offical spec-tests to the Perl-Binding test-suite, IMO it would be usefull to include them in node-sass too.
Kind regards
Marcel Greter

Hi, this is a critical feature to the extensibility of Sass as users are accustomed to in ruby. I am planning to port a large portion of Compass to node and we need this capability. I have an engineer at my work (linkedin) who is willing to work on this, but he are not accustomed to libsass or node.js's internals so we could really use some pointers about how to get started implementing this feature. As I understand it there are three pieces that are needed here:

libsass <--> js function binding (in C++)
Javascript implementation of Sass value objects.
execution environment and helper functions (exposed as methods and properties of this)

Since I wrote a lot of the similar API for ruby, I'd be happy to help define or review the javascript interfaces.

@mgreter is certainly the person to talk to in regards to the libsass side of things. We have some documentation on the libsass wiki for custom functions that should be of use https://github.com/sass/libsass/wiki/Custom-Functions-internal

@xzyfer Ok, I think I get it. So the string passed to sass_make_function is a fully qualified sass function argument declaration supporting defaults, etc?

I'm not entire familiar with the API, but that sounds about right. You might be able to use https://github.com/sass/perl-libsass/blob/8fa1bb0b765bd6b0f1e8391171b09f31eed0c573/lib/CSS/Sass.xs and https://github.com/wellington/wellington as references for using the C API.
Also I'm sure @mgreter will happily help where needed in https://gitter.im/sass

BTW, this is on 2.1 milestone.

This is addressed by 07a9540 via #644.


Apparent missing load instructions after unrolling

Aim
To compile poseidon_bn254_hash
Expected Behavior
^
Bug
Crashes
The application panicked (crashed).
Message:  internal error: entered unreachable code: ICE: Id(456) should have been in cache Instruction { instruction: Id(233), position: 0, typ: Array([Numeric(NativeField)], 3) }
Location: crates/noirc_evaluator/src/ssa_refactor/acir_gen/mod.rs:345

Which arises from:
After Unrolling:
fn main f15 {
  b0(v0: [Field; 2], v1: Field, v2: [Field; 4], v3: Field):
    v5 = allocate
    store [Field 0, Field 0, Field 0] at v5
    v1089 = load v5
    v1090 = array_get v0, index Field 0
    v1091 = array_set v1089, index Field 1, value v1090
    store v1091 at v5
    v1093 = load v5
    v1094 = array_get v0, index Field 1
    v1095 = array_set v1093, index Field 2, value v1094
    store v1095 at v5
    jmp b3()
  b3():
    v11 = load v5
    v13 = allocate
    store v11 at v13
    v226 = cast Field 3 as u8
    v228 = mul v226, u8 65
    v229 = truncate v228 to 8 bits, max_bit_size: 16
    v231 = cast Field 195 as u8
    v232 = eq v229, v231
    constrain v232
    v236 = load v13
    v238 = allocate
    store v236 at v238
    v239 = cast u8 8 as Field
    v241 = eq Field 8, v239
    constrain v241
    v242 = cast u8 57 as Field
    v244 = eq Field 57, v242
    constrain v244
    v245 = allocate
    store Field 0 at v245
    v457 = array_get v456, index Field 0   ; <--- uses non-existent v456

This corresponds to:
fn permute f11 {
  b0(v0: Field, v1: u8, v2: u8, v3: Field, v4: [Field; 195], v5: [Field; 9], v6: [Field; 3]):
    v7 = allocate
    store v6 at v7
    v22 = eq v0, Field 3
    constrain v22
    v23 = cast v1 as Field
    v24 = eq Field 8, v23
    constrain v24
    v25 = cast v2 as Field
    v26 = eq Field 57, v25
    constrain v26
    v28 = allocate
    store Field 0 at v28
    jmp b1(Field 0)                ┐
  b1(v29: Field):                  |
    v31 = lt v29, Field 4          |
    jmpif v31 then: b2, else: b3.  |
  b2():                            | folds
    jmp b4(Field 0)                |
  b4(v32: Field):                  |
    v33 = lt v32, Field 3          |
    jmpif v33 then: b5, else: b6.  |
  b5():                            ⌟
    v34 = load v7
    v35 = load v7
    v36 = array_get v35, index v32  ; <---- originally from load immediately before

To Reproduce

Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

This has now been tested to work. Exact commit not known, will reopen if comes up again.