Fix issue with auto-refresh transactions not firing after they should

This should fix some issues with any dialog that has auto-refreshing set up on any of the fields. Now that we are using a concurrent web server, when fields change it was immediately kicking off a trigger to auto-refresh, and that transaction was completing before the field change transaction would be completed. Ideally, the field change wouldn't need a transaction and the state of the form would be handled in the javascript, but right now it's all handled server side so the order things were being done was causing problems.
This should solve these, at least:
@gmcculloug https://github.com/ManageIQ/manageiq/issues/7272 (http://talk.manageiq.org/t/reading-dialog-form-values-from-a-refresh-event/1322)
@bzwei http://talk.manageiq.org/t/azure-windows-service-provisioning-failure-basic-information-parameters-virtual-machine-size-is-required/1320

@mkanoor I think this might also fix the issue you were experiencing with your dynamic dialogs.

@syncrou Please review.

@mkanoor Can you please validate if this resolves your issue?

@eclarizio It does not solve the problem with azure orchestration provisioning. Is there browser cache that I need to clean to sync with your fix?

@bzwei Just updated the PR, the $.when wasn't behaving properly so there were still issues with concurrent requests, but now that should be fixed and the forms should get updated so you won't see the "required" errors even if you've already filled something out.

@eclarizio when a text box has a default value (yellow background), if the user does not change the value, the default should be taken. However there is a flash error saying the text box needs a value.

It turns out the problem I reported above is not directly related to this fix. Those are not default values but auto filled by browser. Unfortunately the auto filled text is not passed to server, which is another bug needs to be addressed by  a separate PR.
This fix works for me.Thanks.


Implements support for PHP 5.3

Hi again,
I created a new branch and rebased my changes onto you latest commits. These changes implement support for PHP 5.3.
Have fun,
Hendrik

Thanks !

The new version v1.1.0 is available on Packagist. :ok_hand:


[Docs] Added Remark plugin as another way to use SVGO

Hello,
Thank you for the great work! I made a remark plugin to inline SVG image files within Markdown and optimise them with SVGO. This PR adds a link to the plugin in Other Ways to Use SVGO in the Readme.

@alvinometric please change to the new tabular structure. Thanks.

@ADTC Done 😃


New features to investigate for 2.0

integration of mail check js for email validation (see #99)
better 3rd party account services control: only sign in, only sign up, only link... (see #111)
add more helpers to expose single sign up fields, and their validation process, for user profile pages (see #114)
tests! (see #73)
two factor authentication
mixed case username/password detection (see this issue on telescope)

@splendido sorry to bump but issue #114 is still a large priority for me. I was thinking that I could add a accounts package for http://creativepure.meteor.com/. But which of all the beautiful input options should I pick? I think v2 should have a lot less stylized packages and be a lot more customizable.

@Kestanous, could you explain it a bit more?
You mean you'd like to create a useraccounts:creativepure package?
...how is this connected with #114?

So creating a creativepure package would not make sense. The point of that package is to only add the css you want with an import. Any uses of it will want different inputs styles for their user forms. I guess #114 is not a perfect example. Maybe something closer to https://github.com/aldeed/meteor-autoform. Have you seen how they do custom styles?

See the trello board

What is the state of the new code? Anything to look at? The V2.0 bunch look stale and I was curious if you moved it. No pushing, just wonder.
Quick thought on V2, are you going to make it with ES2015? Having it be built in a class structure might make extending it very easy for third party packages.

I went back to v2.0 a little in the last couple days...
I have some local code which has still to be pushed to GitHub, hopefully it will be by the end of the week ;-)
In any case at the moment there's a bit of OAuth flow and FR working quite good, but the code is still to be polished and a few patterns need to be figured out to make it esay for plugin packages to play easily with base ones...
At the moment I have no idea when an alpha release could be published, but it could be helpful to throw out something, even if not really comprehensive, to let who is interested about it to play around and give feedbacks...
ES2015 would be a god thing, for sure!
The class structure is more or less already in place for modules and plugins bout would actually benefit from ES2015 ;-)

Hi all.
So, last month the clinical:active-entry package got a suite of Gagarin tests and Nightwatch tests set up and running on Circle CI.  Yay!  Everything is green!  We're ready for refactoring and V2!
I also recently received an email from the Open Health Imaging Foundation, and they have some grant funding and are going to be getting a developer to work on a list of enhancements to the entry page(s).
Long story short, we have test suites and some grant funding, and would be amenable to merging efforts, and combining the useraccounts:core and clinical:active-entry projects in some way.  Most likely by moving logic from our ActiveEntry object into useraccounts:core, and using it as a dependency.
We have some usecases that are specific to the healthcare industry... Card UI, Autologout, FullName fields on signup, etc.  But nothing that wouldn't make the useraccounts:core package a better product in the long run.  We're also Blaze-centric, and using inline style helpers as part of our page components, which is one peculiarity; but that logic could stay in the clinical:active-entry package.
Other than that...  any reasons why we shouldn't combine efforts here?

Hi Abigail!
I really appreciate you considered useaccounts packages as something to leverage and contribute to!
Unfortunately I never had a chance to check out your clinical:active-entry package and have no idea about its features and state.
Out of curiosity, which are the differences between the two at the moment? Is there something that can be done with one and not with the other?
Some months ago I started a big refactoring of the code (which can be found in v2.0 branches here and there, e.g<EMAIL_ADDRESS>to make everything more modular and even more customizable (LDAP sign-in was among the targers for example but difficult to integrate within current code base...).
I think I got to a good point at that time: I had a bunch of working modules (title, 'separator', OAuth, and flow-routing) and a configurable skin layer allowing to attach different class attributes to the form elements based on the selected UI framework. The 'only' missing part was the one deailng with accounts-password, the most complex actually, but since logics and workflows are already dealt with in the current version I'd say there wasn't that much missing to get to a release candidate...
My dream was to get v2.0 onto atmosphere soon but then I started to have very few spare time, the discussion about Blaze-React opened some questions about whether try to support both or not, the Meteor Guide project brought me back to revise the current version and in the meanwhile issues and PRs started to pile up...
I was also about to write tests but suddenly no one knew which was the official way to test Meteor code...
What more, the new support for ES6 syntax and the upcoming modules support of Meteor 1.3 are making me a little lost...
Eventually everything evolved into a frozen state! :-(
...and now everytime I have a spare hour I don't know where to start from: only trying to reply to all open issues would probably require more time than I have available.
Despite this I still dream of a v2.0! And I'd say the right direction would be continuing to work on it rather than adding new features to v1.
My idea is still to make every bunch of independent features into a separate package so we might end up with (all under the useraccounts namespace):
packages providing logic-less templates

blaze-templates
react-templates

packages providing underlying logic for templates

title
OAuth
password
invites
re-captcha
password-strength-meter

routing packages

flow-routing
iron-routing
react-routing

plugin packages (providing additioal behaviour)

meld
tfa
auto-logout
etc. etc.

If you asked me to consider your list of enhancements, I'd say most of them could became plugin packages for<EMAIL_ADDRESS>(while a couple items are already implemented...).
I'm not sure what you might think about this plan but what I think is the meteor community would need somethink like this!
This said, what would you suggest? How to proceed, also considering your availability to contribute to the project?
In any case thanks for the offer, I truly appreciate it.
Lets try to combine efforts and see whether there's a possibility to start again supporting all community requirements (at least at design level).
Cheers,
Luca

I'm happy to pitch in for the React version if I can help :)

That'd be lovely @SachaG!

@awatson1978 have you had a chance to read my above comment?
I realize only now I haven't mentioned you therein, so you might have not received any notifications...
How could we go about this alltogether?


Add schemas for tracker, iglu repo, and collector telemetry

This PR adds 3 schemas for the telemetry of trackers, collectors and iglu repos found in the wild:
com.snowplowanalytics.telemetry/collector_telemetry/jsonschema/1-0-0
This is to be used with the upcoming runnable snippets documentation feature to help with discover what collectors may be out there in the wild by tracking the collector URLs entered by users, along with being used by the poplin extension to replace the endpoint analytics struct event.
com.snowplowanalytics.telemetry/tracker_telemetry/jsonschema/1-0-0
Used for analytics on created trackers in the runnable snippets UI, and tracker analytics in the poplin extension.
com.snowplowanalytics.telemetry/iglu_repo_telemetry/jsonschema/1-0-0
This is a schema specifically for the poplin extension, for use in repo analytics.

After talking with @stanch and @jethron, it's probably better to leave these off iglu central and put them directly on the pipelines. I'm closing this PR.


feat: Apple vision recognize text run on backgrounnd thread

@Knightro63  kindly review the pr

I have added the ability to change DispatchQueue. If it is set to background it will not allow for default use.


Improve prefetch unit until it passes all mgba timing tests

1234/2020 passing as of today with timers working fairly well. IWRAM tests pass each time so the instructions themselves are about right. Likely to be issues with prefetch unit and other issues that I don't know about yet

Fixes for DMA to share wait states with CPU have caused massively broken DMA tests

needs investigation

I've fiddled around with this a bunch tonight and got to 1341 (have had it higher but probably by accident). Specifically now the standard NOP tests all time correctly w/ prefetch (where they shouldn't activate it because there's no spare bus cycles)
The LDRH tests look two cycles high on prefetch activated versions which is fairly consistent across.

The key learning here that fixes prefetch is that prefetching is always sequential (obviously) and pays no attention to the state of the SEQ signal from the CPU if a prefetch is already occurring. Not at all surprising but needed fixing nonetheless.
The remaining issues can be grouped as:

Thumb multiplication (and follow on thumb bios timings) - suspect straightforward bug in thumb mul use of SEQ.
DMA - screw DMA timings
LDMIA across boundary of ROM - edge case which I would have expected to fall out but definitely doesn't

that's an example of DMA timings

Multiplication issues are resolved, they were caused by incorrect operand ordering for masks.
BIOS calls from thumb are not resolved though, so presumably there's something in there about switching from thumb/arm and back.

Fix bios timings by clearing the prefetch unit when the pipeline is cleared

118 tests left to go, I haven't counted but I think the two cases left are:

LDMIA across ROM boundary (maybe just a case of checking when SEQ is set during LDMIA? Or possibly what order the LDMIA loads happen in although I'd have hoped that was already right)
DMA - Likely two issues here,

Should take 2 cycles in certain cases (particularly around iwram?) - egregious timing differences!
Various times I take less cycles than expected but hard to pin down exactly when.

The large number of "2 cycle" failures are because the CPU should have managed to read the timer value before getting blocked by DMA because the code is in IWRAM and so it taking very little time to run.
Trouble is that I thought that I'd nailed down the exact blocking behaviour for other tests!

Rough plan to solve the DMA/CPU issue is to properly emulate the bus owner at any given cycle. That means a new flag on the bus and DMA setting/unsetting it depending on what state it's in. Not doing it now because it's late but at worse it's a slightly indirect way of writing the same code I have now. Hopefully it fixes this without breaking any other tests!

Hot damn was that ever really tedious to figure out.


Merge next branch to master

Changes:

Rename "orderbook-contract" directory to "market-registry" since this name matches the functionality of what the smart contract in this repository does.

Add fuzzing tests to the orderbook-contracts repository.

Fix the issue where price could not be less than $1.

Bumping to version 0.2.1

Edit README

Looks fine. Discuss with Alex folder renaming and if he approves the rename the Orderbook contract name also


llama: add compiler tags for cpu features

Replaces #7009 now on main
Support local builds with customized CPU flags for both the CPU runner, and GPU runners.
Some users want no vector flags in the GPU runners. Others want ~all the vector extensions enabled. Each runner we add to the official build adds significant overhead (size and build time) so this enhancement makes it much easier for users to build their own customized version if our default runners CPU: [none,avx,avx2] and GPU:[avx] don't address their needs.
Fixes https://github.com/ollama/ollama/issues/2281

Temporarily removed AVX512 support to de-risk the Go server switch.  I'll bring that back with #7199

Deferred the requirements gathering logic to reduce risk on the Go server switch.  Will follow up with #7199 in the future after we've completed the switch.


Added config.json variables to readme

Would you mind adding the available config.json variables to the readme? Or if they are already listed somewhere, include that file location in the readme?
I am trying to set the renameTemplate to {date} {agent.selected} {map}{extension}

Thank you so much!


Core: view change as a transaction

This adds an execution service to change the roster through transactions.

@nkcr You can ignore the json package for now, the tests are missing.


Set free data pointer to a known bad value for debugging

After just debugging a use-after-free I think it's a good idea to set the data pointer used for memory management to a known bad pointer. This will make debugging easier since it's a very obviously bad.
Probably will just use the ever classic 0xDEADBEEF.

Eh, actually it's already in the logs and then it just obscures what the data was...nah lets not do this.


replacing the users not possible

If the users don't want to put multiple users in the .htpass file created,It is not possible. It has the functions to add users and password but cant make a single entry file.
I tried to list the users existing with users and apply the pop  method before adding the new entry for now but that didn't work either

If the users don't want to put multiple users in the .htpass file created,It is not possible. It has the
functions to add users and password but cant make a single entry file.

What? You can add a single entry. It is autotested here.

I tried to list the users existing with users and apply the pop method before adding the new entry for
now but that didn't work either

User deletion is also autotested here.
So without code examples this is completely pointless.


Delete a user's public key via admin api (closes #3014)

Let admin delete a user's key via API

Codecov Report

Merging #3059 into master will increase coverage by 0.01%.
The diff coverage is 9.3%.

@@            Coverage Diff             @@
##           master    #3059      +/-   ##
==========================================
+ Coverage   33.37%   33.38%   +0.01%
==========================================
  Files         270      270
  Lines       39549    39590      +41
==========================================
+ Hits        13198    13216      +18
- Misses      24464    24485      +21
- Partials     1887     1889       +2

Impacted Files
Coverage Δ

routers/api/v1/admin/user.go
0% <0%> (ø)
:arrow_up:

routers/api/v1/api.go
75.12% <100%> (+0.12%)
:arrow_up:

modules/indexer/repo.go
63.47% <0%> (+2.6%)
:arrow_up:

models/repo_indexer.go
51.98% <0%> (+6.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cc5b0...cce1b3b. Read the comment docs.

Can you also add test that adds and later deletes that key?
Also test for deleting not existing key and test deleting key with user that does not have rights to do that would be great

@lafriks done!

@ethantkoenig done

LGTM

LGTM


replaced PropertyAccessor with dumb property altering

PropertyAccessor doesn't work in new laravel/symfony versions

Does anybody know why the tests fail?

@kvanhoorn The tests use https://github.com/winzou/state-machine/blob/master/spec/SM/DummyObject.php as the object. state in not a property there but uses getters/setters instead. Why exactly doesn’t PropertyAccessor work in new laravel/symfony versions? I think that can be fixed!

Wow, this took me really 4 hours. Apparently, the function to retrieve the state was called 'state' and the variable I was trying to get with PropertyAccessor was also 'state'. But no warning, error, just a apache pid that crashed.
You would expect that PHP would give me some kind of error, maybe a small bug in the new traits...
Thanks for your concern!


Use dnssec enabled version of dnsmasq

This uses dnsmasq-dnssec instead of the dnsmasq version where dnssec is disabled.

I created a docker image of it - seems to work fine:
https://hub.docker.com/r/simon21783/dnsmasq/tags


Add Docker 19.03.11 to install-docker scripts for CVE-2020-13401

https://github.com/docker/docker-ce/releases/tag/v19.03.11
Changelog

19.03.11 (2020-06-01)
Network
Disable IPv6 Router Advertisements to prevent address spoofing CVE-2020-13401

Verified on v2.4.4-rc3

Deployed AWS RKE clusters with k8s v1.15.12, v1.16.10 and v1.17.6
Docker version seen for the nodes - Docker Version: 19.3.11


VideoFrame videos not showing outside of Roblox Studio

I use VideoFrame videos in my game and I noticed that the videos dont play anywhere outside of Roblox Studio (Launching the game from the roblox site).
Is there something I need to do to fix this? a script?

The thing is your roblox studio is modded and Video frames are not released to public you just edited your roblox studio
one more question.. how did you install video frames on your studio?

I followed this tutorial exactly

The feature is not available outside of Roblox Studio yet, as Roblox hasn't officially released it.
My mod manager provides you with tools to enable features early, but only locally on your machine and not in-game.


Lazy loading in scaffold body gives scrollposition error

I have a horizontal List that has vertical items. Whenever i try to scroll vertical items within each list I get
════════ Exception caught by animation library ═════════════════════════════════
The following assertion was thrown while notifying status listeners for AnimationController:
The provided ScrollController is currently attached to more than one ScrollPosition.

The Scrollbar requires a single ScrollPosition in order to be painted.

When the scrollbar is interactive, the associated Scrollable widgets must have unique ScrollControllers. The provided ScrollController must be unique to a Scrollable widget.

This is minimum code I use:
  ScrollController scrollController = ScrollController();

List<DragAndDropItem> _generateItems(ProjectColumn col) {
    List<DragAndDropItem> list = [];
    for (var c in col.cards) {
      // Card
      list.add(DragAndDropItem(
        child: Text(c.content),
      ));
    }
    return list;
  }

  List<DragAndDropList> _generateLists() {
    List<DragAndDropList> list = [];
    for (var i in project.columns) {
      // Each column
      list.add(
        DragAndDropList(
          header: Text(i.title),
          children: _generateItems(i),
        ),
      );
    }
    return list;
  }

body: Padding(
        padding: const EdgeInsets.all(10),
        child: DragAndDropLists(
          lastItemTargetHeight: 300,
          scrollController: scrollController,
          listWidth: 350,
          listPadding: const EdgeInsets.all(5),
          axis: Axis.horizontal,
          itemGhostOpacity: 0.5,
          children: _generateLists(),
        ),
      ),

I found how to fix this bug:

That doesn't work for me. Still have the same issue.

That worked. Just had to rebuild the project. @philip-brink can you please add this fix?


Field changes

This PR introduces three changes:

[x] Fixes a duplicate label issue present on advanced search
[x] Introduced 'keyword' and 'neutral citation' fields within structured search (and the additional options on search results)
[x] Removes the neutral citation checkbox on the home page

Change this to draft to remind me not to merge it, as we need to wire up the fields to actual search terms in the query


docs: Adding Social Banner in Support of Ukraine

Summary
Our mission at Meta Open Source is to empower communities through open source, and we believe that it means building a welcoming and safe environment for all. As a part of this work, we are adding this banner in support of Ukraine during this crisis.
Testing

Great stuff!
There is https://docusaurus.io/docs/api/themes/configuration#announcement-bar which will be on all pages, not just the landing page. Maybe something to consider in addition?

Hmm, maybe in the long run we should consider something like that - I made a bit more elaborate PR for Reactjs because they have a bit more responsive UI https://github.com/reactjs/reactjs.org/pull/4397, so we definitely have many options to choose from for the future usages of these social banners

It takes about 40 minutes due to fetching translations and the amount of versions we have, but it's currently building 🙂 See https://app.netlify.com/sites/jestjs/deploys


Link to Going the Distance with Babylon.js book is broken

content/guidedLearning/journeyBeyond.md
The https://packt.link/josh link seems to be a 404 rather than go to https://www.packtpub.com/product/going-the-distance-with-babylonjs/9781801076586 (presumably?)
cc @jelster (found you from book repo 😄)

hi @sheepsteak thanks for pointing this out! The correct link should be https://packt.link/Josh -- it is tragically a case-sensitive link that my publisher provided me. @PirateJC -- would you prefer a PR for this or is this something you'd prefer to fix yourself?

@jelster - please submit a PR with the right link, i'll merge it asap :-)

Thanks, done!


[NVIDIAGeForceNowLibrary] Name Matching for Origin and Epic games is broken when using the "display games as library feature"

Extension name
NVIDIAGeForceNowLibrary
Bug Description
[NVIDIAGeForceNowLibrary] Name Matching for Origin and Epic games is broken when using the "display games as library feature"
a sanitized name (from the playnite database) is compared against an unsantized name from Gefore now in this case (see screenshot)
To Reproduce
Use feature to display the games as a library instead of modifying existing games and try adding a game from origin or epic games it should mostly fail even when the game name is 100% the same as in the database viewer
you can use the demo from this game for example to test https://store.epicgames.com/en-US/p/immortals-fenyx-rising
Logs
not applicable
Screenshots

you just need to call SanitizeGameName on ItemVariant.title in this case in this location

hmm the bug might be elsewhere maybe the changes done by SatinizeSupportedListTitles are not applied or the function is not called somewhere where it should

Fixed in https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/7bec0d4dd13e3aeb43f388577538a259c42e5ce2


[SPARK-15818] [BUILD] Upgrade to Hadoop 2.7.2

What changes were proposed in this pull request?
Updating the Hadoop version from 2.7.0 to 2.7.2 if we use the Hadoop-2.7 build profile
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Existing tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
I'd like us to use Hadoop 2.7.2 owing to the Hadoop release notes stating Hadoop 2.7.0 is not ready for production use
https://hadoop.apache.org/docs/r2.7.0/ states
"Apache Hadoop 2.7.0 is a minor release in the 2.x.y release line, building upon the previous stable release 2.6.0.
This release is not yet ready for production use. Production users should use 2.7.1 release and beyond."
Hadoop 2.7.1 release notes:
"Apache Hadoop 2.7.1 is a minor release in the 2.x.y release line, building upon the previous release 2.7.0. This is the next stable release after Apache Hadoop 2.6.x."
And then Hadoop 2.7.2 release notes:
"Apache Hadoop 2.7.2 is a minor release in the 2.x.y release line, building upon the previous stable release 2.7.1."
I've tested this is OK with Intel hardware and IBM Java 8 so let's test it with OpenJDK, ideally this will be pushed to branch-2.0 and master.

Can one of the admins verify this patch?

That's probably fine. I suppose we should do this for all of the 2.x Hadoop branches?

Good point, I see the latest Hadoop 2.6 version is 2.6.4 (mentions fixing critical bugs) and for 2.5 it's 2.5.2 (same story), so ideally we'd ensure each "best for profile" version gets used.
Should I submit the version changes with this pull request so instead it's a "Update Hadoop versions" change?
Does your build farm exercise all Hadoop permutations (so we can test the best available 2.3.x, 2.4.x, 2.5.x, 2.6.x, 2.7.x?

Best versions for our profiles are as follows
2.7: 2.7.2
2.6: 2.6.4
2.5: 2.5.2
2.4: 2.4.1 (users immediately encouraged to move up for a security fix)
2.3: 2.3.0 (as is)

Jenkins test this please

Jenkins add to whitelist

Test build #60165 has started for PR 13556 at commit 8829086.

Test build #60165 has finished for PR 13556 at commit 8829086.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60165/
Test FAILed.

Merged build finished. Test FAILed.

You'll have to run ./dev/test-dependencies.sh --replace-manifest to update the expected dependencies. And we can see if somehow a transitive dependency changed.

Done, didn't giff automatically so git diffed myself and see plenty of differences (as you'd expect Hadoop transitive dependencies should be, say, 2.4.1 not 2.4.0 now, 2.7.2 not 2.7.0, etc).
Where do we update the expected values? Grepping for "hadoop-annotations" for example only shows dev/deps/spark-depsjar name.
Looking in the script I see pr-deps is created based on the Hadoop profiles, so perhaps we need to add the explicit Hadoop version when we define the Hadoop profiles...
Sample output for 2.7:
-hadoop-annotations-2.7.0.jar
-hadoop-auth-2.7.0.jar
-hadoop-client-2.7.0.jar
-hadoop-common-2.7.0.jar
-hadoop-hdfs-2.7.0.jar
-hadoop-mapreduce-client-app-2.7.0.jar
-hadoop-mapreduce-client-common-2.7.0.jar
-hadoop-mapreduce-client-core-2.7.0.jar
-hadoop-mapreduce-client-jobclient-2.7.0.jar
-hadoop-mapreduce-client-shuffle-2.7.0.jar
-hadoop-yarn-api-2.7.0.jar
-hadoop-yarn-client-2.7.0.jar
-hadoop-yarn-common-2.7.0.jar
-hadoop-yarn-server-common-2.7.0.jar
-hadoop-yarn-server-web-proxy-2.7.0.jar
+hadoop-annotations-2.7.2.jar
+hadoop-auth-2.7.2.jar
+hadoop-client-2.7.2.jar
+hadoop-common-2.7.2.jar
+hadoop-hdfs-2.7.2.jar
+hadoop-mapreduce-client-app-2.7.2.jar
+hadoop-mapreduce-client-common-2.7.2.jar
+hadoop-mapreduce-client-core-2.7.2.jar
+hadoop-mapreduce-client-jobclient-2.7.2.jar
+hadoop-mapreduce-client-shuffle-2.7.2.jar
+hadoop-yarn-api-2.7.2.jar
+hadoop-yarn-client-2.7.2.jar
+hadoop-yarn-common-2.7.2.jar
+hadoop-yarn-server-common-2.7.2.jar
+hadoop-yarn-server-web-proxy-2.7.2.jar

If you run that script it will update the deps/* files for you automatically. Just push the results so we can review them here.

Test build #60174 has started for PR 13556 at commit 402463e.

LGTM

Test build #60174 has finished for PR 13556 at commit 402463e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60174/
Test PASSed.

Merged to master/2.0


Mention datasauRus when discussing Anscombe

https://cran.r-project.org/web/packages/datasauRus/vignettes/Datasaurus.html


(Docs) : Added contributing guidelines

Added Contributing guidelines

@jhdalek55 review required :)

I haven't reviewed this yet, but I'm wondering if we might want to think about the purpose of adding this here. We definitely want people to contribute ideas to the website, but I'm a little unsure about whether we want direct contributions to the text.  This is the face of the project and maybe we want to exercise some control here?  I may be completely wrong about this, so I'll just look at the text for now.

I haven't reviewed this yet, but I'm wondering if we might want to think about the purpose of adding this here. We definitely want people to contribute ideas to the website, but I'm a little unsure about whether we want direct contributions to the text. This is the face of the project and maybe we want to exercise some control here? I may be completely wrong about this, so I'll just look at the text for now.

@jhdalek55  Thank you for sharing your thoughts on this, I agree with you, I think we might need to create a separate contributing.md file for this purpose. Alternatively, we can also add these guidelines to the wiki and provide a link to those documents (as a link to contributing guidelines).
However, I would like to point out that these guidelines might change soon as we are still unsure about how we will proceed to improve the site. If we decide to stick with Jekyll, then these guidelines would make sense, but if we need to iterate, we may need to revise them.
For now, I think it would be best to put this on hold, although I will make the changes you suggested.

new guidelines are needed as site is updated

Sorry. I don't know how to submit a PR now that the MD files are gone.

I don't know how to submit the revised text as the MD files are now gone.
On Fri, Oct 13, 2023 at 11:12 AM Abhijay Jain @.***>
wrote:

sure, submit a pull request for this and if some changes are needed, we
will create a new issue for that
On Fri, Oct 13, 2023 at 8:40 PM Lois Anne DeLong @.***>
wrote:

Text has been drafted for this. Should I submit as a pull request?
—
Reply to this email directly, view it on GitHub
<
https://github.com/uptane/uptane.github.io/pull/61#issuecomment-1761679560>
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uptane_uptane.github.io_pull_61-23issuecomment-2D1761679560-253E&d=DwQFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=cs3aE8F5m3rQG6AKbWKG5vocQe5qvPTXxyFiaIAofUioQTubYW93FiVbNOgXgPDC&s=gcBeYZdzi3Wq76CiRse1eAO_MNPv93Kl6wovxakMAvg&e=,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/APLHP3UMVLBZOZJPLJVTZ63X7FKW7ANCNFSM6AAAAAAWYBPS2Q>
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_APLHP3UMVLBZOZJPLJVTZ63X7FKW7ANCNFSM6AAAAAAWYBPS2Q-253E&d=DwQFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=cs3aE8F5m3rQG6AKbWKG5vocQe5qvPTXxyFiaIAofUioQTubYW93FiVbNOgXgPDC&s=ZAXlsFryYSVh8tZ6xoAgMm7mnwbdWL7TS-VT6sdQ06w&e=
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uptane_uptane.github.io_pull_61-23issuecomment-2D1761682210&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=cs3aE8F5m3rQG6AKbWKG5vocQe5qvPTXxyFiaIAofUioQTubYW93FiVbNOgXgPDC&s=qCYq6PNCS6-B4PAyIUSWnoaSpzZsCMiJ79iz3XhSKgg&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADPGUX6OVD6HQMPXFY2DMDLX7FK6DANCNFSM6AAAAAAWYBPS2Q&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=cs3aE8F5m3rQG6AKbWKG5vocQe5qvPTXxyFiaIAofUioQTubYW93FiVbNOgXgPDC&s=4OW4Rt7XQubaiDz-l3qJ-pCtrGOYHjcfnwJyLrkSufk&e=
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sorry. I don't know how to submit a PR now that the MD files are gone.

you can create a new file contributing.md and can submit the PR with the revised text

Done
On Fri, Oct 13, 2023 at 11:40 AM Lois A DeLong @.***> wrote:

Ok, I will try.
Lois
On Fri, Oct 13, 2023 at 11:39 AM Abhijay Jain @.***>
wrote:

Sorry. I don't know how to submit a PR now that the MD files are gone.
you can create a new file named contributing.md and can submit the PR
with the revised text
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_uptane_uptane.github.io_pull_61-23issuecomment-2D1761721495&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=77Z2InA5Xe1B-pjoYrzlYiBwzEx-IG93iZRDrAp_g2JfH1r0sdHjTh1mLSOkUXUZ&s=HzjFPk7tHBW44YC0eBxzjw5J_1jQBnQ0ImGqsx5LwPE&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADPGUX22MM75O4U7HAQFO7TX7FOBJANCNFSM6AAAAAAWYBPS2Q&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=hgBKIqNYIOwzXeBjPUaKRw&m=77Z2InA5Xe1B-pjoYrzlYiBwzEx-IG93iZRDrAp_g2JfH1r0sdHjTh1mLSOkUXUZ&s=4BjmBPw3KWHDlGdZnPUrNXjn1JXgnJ4039eBoYg9Uc8&e=
.
You are receiving this because you were mentioned.Message ID:
@.***>


Document the Nlog version an element became obsolete

Document on XML comment as well as the [Obsolete] attribute the NLog
version where a class, method or property was marked as obsolete.
This might help in the future releases to evaluate if an element should
be removed completely from the code and it provides the users with more
information.

This change is

Current coverage is 81% (diff: 100%)

Merging #1814 into master will increase coverage by <1%

@@             master      #1814   diff @@
==========================================
  Files           274        274
  Lines         18256      18256
  Methods        2834       2834
  Messages          0          0
  Branches       2091       2091
==========================================
+ Hits          14865      14867     +2
+ Misses         2924       2923     -1
+ Partials        467        466     -1

Powered by Codecov. Last update 6b197e5...f75f330

Good idea.
Maybe it's event better to use the real version (we should find it with git) and update https://github.com/NLog/NLog/issues/531?

Thanks! Great work!


pptx.exc.PackageNotFoundError: Package not found at '../Lecture03bECD.pptx'

I'm trying to convert a back catalog of powerpoint lectures to md.  The first two I did worked great.  The next two, I'm getting a mysterious error:
pptx2md ../Lecture03bECD.pptx -o Lecture03bECD.md
/Users/ralmond/Library/Python/3.7/lib/python/site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
Traceback (most recent call last):
  File "/Users/ralmond/bin/pptx2md", line 8, in <module>
    sys.exit(main())
  File "/Users/ralmond/Library/Python/3.7/lib/python/site-packages/pptx2md/__main__.py", line 77, in main
    prs = Presentation(file_path)
  File "/Users/ralmond/Library/Python/3.7/lib/python/site-packages/pptx/api.py", line 28, in Presentation
    presentation_part = Package.open(pptx).main_document_part
  File "/Users/ralmond/Library/Python/3.7/lib/python/site-packages/pptx/opc/package.py", line 125, in open
    pkg_reader = PackageReader.from_file(pkg_file)
  File "/Users/ralmond/Library/Python/3.7/lib/python/site-packages/pptx/opc/pkgreader.py", line 33, in from_file
    phys_reader = PhysPkgReader(pkg_file)
  File "/Users/ralmond/Library/Python/3.7/lib/python/site-packages/pptx/opc/phys_pkg.py", line 32, in __new__
    raise PackageNotFoundError("Package not found at '%s'" % pkg_file)
pptx.exc.PackageNotFoundError: Package not found at '../Lecture03bECD.pptx'
dhcp138177:Markdown ralmond$

I just figured this out.  PPT saved the file to the wrong directory, so the file did not exist.  I'll leave this as a minor issue, because "Package not found" is a confusing error message.

The error is counter intuitive, so I added file existence check before loading, thanks!

i'm having this error on some of the files I try to convert, any reason why?

i'm having this error on some of the files I try to convert, any reason why?

If this error happens on well-formed pptx file, please send them to<EMAIL_ADDRESS>for debugging.


Click drag functionality

Some interactions in SS13 that are behind click drag functionality:

buckling a mob to a chair;
opening another mob's inventory pane;
moving things into a bin/gibber/meathook;
emptying inventories on tables;
climbing onto tables;

The interaction system needs to support these cases and click drag should be a good way to go about it.
I propose we add an IDroppable interface for components to implement.
When a client's click key is pressed we should store the click's information and permit a small time window before assuming a drag.
We can immediately look up the entity that's being dragged as locations can be different once the timeframe is up.
Once it is established that an interaction is a drag all visible entities should be checked for IDroppable implementations.
Entities that allow the dragged entity to be dropped unto them should be highlighted.
For this, IDroppable should force some method that tests an Entity as well as the actual behavior.

Well I did this for unitystation so why not do it again...Taking this on.

Click-dragging isn't very discover-able.
Since we have a right-click menu that doesn't take a century to open, we can probably use that instead.

We could make it more discoverable - and click-dragging is the sensible choice for interactions, like moving stuff that's too big to carry. I agree that it's not so good for buckling or opening other peoples inventory - but pulling a human into a gibber is a natural drag action.
The only question is how to make it discoverable. I think highlighting any IDroppable entities is a good idea, but we could also make the cursor change into a sprite copy of the thing being dragged. That way it's clear what you're using to interact with stuff.

If a click turns into a drag, it'd be nice to have a small icon of whatever you're dragging show up next to the cursor.

The only question is how to make it discoverable. I think highlighting any IDroppable entities is a good idea, but we could also make the cursor change into a sprite copy of the thing being dragged. That way it's clear what you're using to interact with stuff.

Both of these are good yeah.

Need some feedback...
With current interaction system, we pretty much send every mouse click to the server and leave it up to server to tell us what happens next. For drag and drop interaction, in the presence of lag I worry this leads to an unsmooth experience.
For example, with the current "pattern" for interactions, the flow would be like:

Server side component has IDroppable
Client mousedown, message goes to server
server checks if there's a draggable entity, tells client that a drag is initiated (spawning a drop shadow of the object being dragged and the entities that can be dropped on)
client gets this info and can proceed to drop the entity
server gets the mouseup and the drop happens

The part where client has to wait for server to tell it if a drag can be initiated is what concerns me, coupled with the need for a slight delay before initiating the drag and drop.
Does this approach sound okay instead?

Client side component has IDraggable, marking that it can be dragged (could have a "Draggable" marker component that just returns true if it's in range).
Client mousedown
Client checks if any entity has IDraggable, and if so creates the clientside drag shadow while telling the server that it wants to start a drag (bypassing the normal clientside click behavior where it sends the mousedown cmd to the server)
Server validates the dragged object is in range and sends client list of entities that can be dropped on (if any)
Client gets the entities and highlights them (if any)
Client drops it on one of the entities and then server validates + performs the drop logic (via some new interaction interface like IDragDrop)

My suggested approach means that client will get the drag shadow instantly (assuming they held click for long enough), but it may not immediately see the "candidates" for dropping...even so the client can still go ahead and drop it before they know what are valid candidates if they already have a good knowledge of what can be dropped on. IMO this leads to a more responsive interaction.
Does anyone see potential issues with that approach? The issue I can potentially see is the client not knowing if an object is really in a "draggable" state if there are entities which are only draggable in certain situations, but IMO if an entity is ever draggable it should always be draggable, the server will just tell client there's no candidates to drop on. That way it would avoid frustrating "why can't I drag this?".
I'm not concerned ATM about conflicting with other kinds of interactions as I already have a pretty good idea how that should work.

Thinking about it more...I think we don't even need to bother asking the server for possible drop targets...the client should be able to know what the valid drop targets are just looking at visible entities that have particular components.

Sounds like a good design. Making it smooth and client-based is definitely desirable.

Sounds good to me.

Not sure if it is the same feature, but inventory click-drag would finally allow to open the backpack/belt by clicking on it, instead of taking it in hands before, and only unequip it with a click drag.

Running into some limitations with the current binding system because you can't register multiple InputCmdHandlers to a given BoundKeyFunction, and the constructor system already is bound to Use on clientside but I also need to bind to Use for the drag and drop stuff. It's inspiring me to add support for this to the binding system. Right now I think we're kind of lucky that all key functions are only bound by one system / manager.
Gonna focus on that first - support for adding multiple bindings to a given key function while being able to explicitly define the order in which the handlers should be resolved. Unless someone thinks that's a really bad idea.
I will do that as a separate PR and get a draft up to get someone to take a look at my proposed design before I do the drag and drop changes, otherwise the PR for both will be too big (and I expect I might need to make significant changes to the new binding approach depending on feedback)
I think I can come up with a good approach for solving that, but feel free to tell me if I shouldn't even bother with the binding stuff though and just come up with a temporary hack to get the drag and drop + constructor system to work together.


Reusable method

Hey, as I'm writing test for voronoid, I realised that there are a few methods I need to reuse. Those methods are

concat all data into allValues
_calculateScale

I do think that it's good to factor out this method in util.js or as a (mixins)[http://facebook.github.io/react/docs/reusable-components.html#mixins]. I suggest to add another /src/mixins/ folder so that we can add resuable code here.
However we can do this in the next publish if you think that there are too much to do. No worries :smile:

mixins are good if the code you're factoring out needs access to the React components instance (e.g., if it needs to access this.state or this.props, or if the mixin needs to add a component lifecycle).
Otherwise, just a utils.js would be good.  Sounds like in this case probably just a utils.js would work.

@esbullington  Sounds good. Do you want to take over this or it's ok to let me factor out those reusable code.
I will put them in src/common/utils.js =)

Do you want to take over this or it's ok to let me factor out those reusable code.

Sure,  you're welcome to if you'd like.  But would you mind putting that in a separate PR from the Voronoi?
But if you don't get to it, I'll remember to factor that out later.

Thanks, @yang-wei I merged that PR.  I moved it from src/common to src since I'm planning on keeping only React components in the src/commons directory.  I'm probably going to make that a separate NPM package soon, something like react-d3-components.  If the utils.js gets big enough, we should probably break it out into a src/utils directory, or maybe even a react-d3-utils package.
I removed the lodash dependency -- no more lodash.  In its place, I'm using a lot of ES5 functional features like map and forEach, along with the ES6 arrow functions.  I considered using 6to5 for ES6, but I'm sticking with the ES6 features offered by reactify:

arrow functions
destructuring
ES6 template strings
object short notation

But for now, let's not use:

ES6 classes (no need with React classes, mixins, and regular JS prototypal inheritance)
const and let are unfortunately not available with reactify, which is too bad

By the way, I went ahead and added you to collaborators list so you can go merge your own PRs if they're small and if they pass all tests.  That doesn't mean there there's now any pressure to regularly contribute -- just whenever you want!
But I'd ask you to please let me review if you're adding a new chart or major feature, and I'll do the same if I'm adding a major new feature or chart (if that's OK with you).  Oh, and please don't forget to run npm lint before you make a PR.
We passed 100 stars on Github today :)  And growing fast.
I'll let you close this issue when you've read this.

@esbullington Thank you for adding me as a contributor, much appreciated. I like the idea of react-d3-components. All above are noted.
Yeah this is growing faster than what I thought. Congrats ! Let's keep this go on =)


(possible) errors in pagination partial

(I'm a Hugo newbie, so this issue / pair of issues might be entirely my fault.)
I have a Hugo site, themed with this theme, at http://people.cs.umass.edu/~liberato/home/. My config.toml contains:
baseurl = "http://people.cs.umass.edu/~liberato/home/"

Some sections of the site, for example, the Posts, are paginated. The pagination partial for the Academic theme (in layouts/partials/pagination.html) contains lines that generate the Previous and Next links that look like:

« Previous

But when I generate my site, two perhaps-unrelated things happen.
First, using the above partial, I get the .Site.BaseURL prepended to the Previous and Next links twice; I think that .Paginator.Prev.URL and .Paginator.Next.URL might already be including the baseurl. If I remove {{ .Site.BaseURL }} from the partial in those two places, the URLs don't contain the duplicate baseurl.
Second, the leading tilde (~) is stripped from the baseurl in both cases. My local web administrator has a redirect set up such that it doesn't 404 when I deploy, but it breaks local preview. Is this an Academic theme thing, or maybe a Hugo thing, or maybe I'm just miswriting the baseurl and don't see it? I don't fully understand the template language so I'm not sure where or how to start debugging this problem. Any pointers welcome.

I can't reproduce this issue locally. However, it looks like someone else has the same issue with Hugo - see Funatiker's comment from 2 days ago at https://github.com/spf13/hugo/issues/2177 . So perhaps this is a bug in Hugo (0.18?). I would check the Hugo forums and then consider filing a bug report with them.

try put the baseURL to http://people.cs.umass.edu/~liberato/home

Alas, the problem persists. I'm going to investigate the Hugo forums further and see if someone there can help me.

you can also try setting canonifyurls = true / or false in your config file to see if that fixes it.
Good luck!

Thanks @chasgames. That fixes the tilde problem, but breaks the Academic theme in other ways (for example, the link to the avatar no longer respects the baseurl in the rendered HTML:

Hmm, Did you try to clear your cache or a ctrl+refresh?
I see different to you :

Yes, I did clear my cache and refresh.
With canonifyurls = true I get the code in my previous comment. With it set to false (or unset) I get the (correct) code:

I just want to try a different tactic, set canonifyurl to false again.
When you start hugo, use "-b" to specify your baseurl and start your hugo server, like this.
hugo server --watch -b http://<IP_ADDRESS>/~chas/home/ -p 80
This seems to work some extra magic for me http://<IP_ADDRESS>:8080/~chas/home/

Unfortunately it does not appear to work any extra magic for me; the tilde remains missing.

Very strange works fine for me and i'm using the tilde.. something is different between our setups.
If canonifyurls fixes the tilde problem, then set it back to true in your config.
Navigate to my_website/themes/academic/layouts/partials/widgets
Edit about.html and FIND "/img/"  and REPLACE with "//people.cs.umass.edu/~liberato/home/img/"
Now it should look something like this

save and restart hugo

@chasgames Thank you for the workaround, but I'd rather fix the error (if that's what it is) in Hugo than hardcode a workaround into the theme.
@gcushen I'll follow up further in the Hugo repo re: baseurl and the disappearing tilde. But, is the unneeded {{ .Site.BaseURL }} a bug that needs to be fixed, or (in your opinion) a consequence of the baseurl stuff?

unneeded {{ .Site.BaseURL }}

Maybe I missed something as I'm not sure what you mean. When {{ .Site.BaseURL }} is used, it gives a full absolute URL. In cases where it is not present, the URL will be a partial URL relative to the current resource. Perhaps that answers your question?
I attempted to convert all the URLs from absolute to relative a while back and meant to replace most if not all of the {{ .Site.BaseURL }} instances with relURL. However, your issue has made me realise that there are still some absolute URLs in the code. I'll make an update in the next day or two which will convert the remaining ones to relative URLs, which may make the apparent Hugo bug less of an issue for you.

Closing this as Bep has confirmed it's a bug in Hugo (https://github.com/spf13/hugo/issues/2177) - which he has now fixed in the master Hugo version and which is expected to be officially released in Hugo v0.19.

Thanks very much @gcushen! I sincerely appreciate your looking into this issue.


Unable to transform test data after MCA fitting training data

Hi, I'm having an issue that I've seen other people post issues about before. I'm unable to transform a test dataset after MCA is fit on a training dataset. It seems to be a shape issue. Here is the code to recreate the error.

Create example dataframe

X = pd.DataFrame(
data=[
['A', 'A', 'A', 'm'],
['A', 'A', 'A', 'f'],
['B', 'A', 'B', 'm'],
['B', 'A', 'B', 'm'],
['B', 'B', 'B', 'f'],
['B', 'B', 'A', 'f']
],
columns=['feature1', 'feature2', 'feature3', 'feature4'])

Fit on training data

from prince import MCA
mca = MCA()
mca.fit(X[:4])

Transform on test data

mca.transform(X[4:])

Error message:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-55-8524ce01518f> in <module>
      3 mca.fit(X[:4])
      4
----> 5 mca.transform(X[4:])

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/prince/mca.py in transform(self, X)
     48         if self.check_input:
     49             utils.check_array(X, dtype=[str, np.number])
---> 50         return self.row_coordinates(X)
     51
     52     def plot_coordinates(self, X, ax=None, figsize=(6, 6), x_component=0, y_component=1,

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/prince/mca.py in row_coordinates(self, X)
     36         if not isinstance(X, pd.DataFrame):
     37             X = pd.DataFrame(X)
---> 38         return super().row_coordinates(pd.get_dummies(X))
     39
     40     def column_coordinates(self, X):

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/prince/ca.py in row_coordinates(self, X)
    132
    133         return pd.DataFrame(
--> 134             data=X @ sparse.diags(self.col_masses_.to_numpy() ** -0.5) @ self.V_.T,
    135             index=row_names
    136         )

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/scipy/sparse/base.py in __rmatmul__(self, other)
    568             raise ValueError("Scalar operands are not allowed, "
    569                              "use '*' instead")
--> 570         return self.__rmul__(other)
    571
    572     ####################

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/scipy/sparse/base.py in __rmul__(self, other)
    552             except AttributeError:
    553                 tr = np.asarray(other).transpose()
--> 554             return (self.transpose() * tr).transpose()
    555
    556     #####################################

~/.conda/envs/nonrootenv/lib/python3.7/site-packages/scipy/sparse/base.py in __mul__(self, other)
    518
    519             if other.shape[0] != self.shape[1]:
--> 520                 raise ValueError('dimension mismatch')
    521
    522             result = self._mul_multivector(np.asarray(other))

ValueError: dimension mismatch

If the train and test datasets are the same shape like below, I get no error.
mca = MCA()
mca.fit(X[:3])
mca.transform(X[3:])

My guess is that with prince you can apply the transform function only on the same data set that you used to fit the model.

My guess is that with prince you can apply the transform function only on the same data set that you used to fit the model.

See if this helps:
To apply clustering on a test set, you might want to perform an additional logistic regression as a workaround:

Same you did

Same you did

Transform the train set

X_train_transformed = mca.transform(X_train)

Use your favorite technique to determine the number of clusters you want to create; plotting a dendrogram is one such technique.

Perform clustering on the transformed data set:

from scipy.cluster.hierarchy import fcluster, linkage

cluster_nums = fcluster(
    linkage(
        y=X_train_transformed,
        method='ward',
        metric='euclidean'
    ),
    t=5, # here goes the max number of clusters you want to create
    criterion='maxclust'
)

y_train = cluster_nums.astype(str)

Perform one-hot label encoding (dummy label encoding) on both X_train and X_test data sets:

X_train_dummies = pd.get_dummies(X_train)
X_test_dummies = pd.get_dummies(X_test)

Perform logistic regression on X_train:

from sklearn.linear_model import LogisticRegression
from sklearn.model_selection import GridSearchCV

param_grid = {
    'max_iter': [10000],
    'multi_class': [
        'auto',
        # 'multinomial',
        # 'ovr'
    ],
    'penalty': [
        'l1',
        # 'l2',
        # 'elasticnet'
    ],
    'solver': [
        # 'newton-cg',
        # 'sag',
        'saga',
        # 'lbfgs',
        # 'liblinear'
    ],
    'C': np.logspace(-5, 5, 25)
}
clf_log_reg = GridSearchCV(
  LogisticRegression(),
  param_grid=param_grid,
  cv=5,
  verbose=True,
  n_jobs=-1
).fit(X_sample, y_sample)

Apply the results on the test set

X_test['cluster'] = clf_log_reg.best_estimator_.predict(X_test).astype(str)

I hope this helps

See if this helps:
To apply clustering on a test set, you might want to perform an additional logistic regression as a workaround:

Same you did

Same you did

Transform the train set

X_train_transformed = mca.transform(X_train)

Use your favorite technique to determine the number of clusters you want to create; plotting a dendrogram is one such technique.

Perform clustering on the transformed data set:

from scipy.cluster.hierarchy import fcluster, linkage

cluster_nums = fcluster(
    linkage(
        y=X_train_transformed,
        method='ward',
        metric='euclidean'
    ),
    t=5, # here goes the max number of clusters you want to create
    criterion='maxclust'
)

y_train = cluster_nums.astype(str)

Perform one-hot label encoding (dummy label encoding) on both X_train and X_test data sets:

X_train_dummies = pd.get_dummies(X_train)
X_test_dummies = pd.get_dummies(X_test)

Perform logistic regression on X_train:

from sklearn.linear_model import LogisticRegression
from sklearn.model_selection import GridSearchCV

param_grid = {
    'max_iter': [10000],
    'multi_class': [
        'auto',
        # 'multinomial',
        # 'ovr'
    ],
    'penalty': [
        'l1',
        # 'l2',
        # 'elasticnet'
    ],
    'solver': [
        # 'newton-cg',
        # 'sag',
        'saga',
        # 'lbfgs',
        # 'liblinear'
    ],
    'C': np.logspace(-5, 5, 25)
}
clf_log_reg = GridSearchCV(
  LogisticRegression(),
  param_grid=param_grid,
  cv=5,
  verbose=True,
  n_jobs=-1
).fit(X_sample, y_sample)

Apply the results on the test set

X_test['cluster'] = clf_log_reg.best_estimator_.predict(X_test).astype(str)

I hope this helps

I'm also facing this issue and have not been able to overcome it yet
Its usefulness decreases if we can't apply it on another test set
@kirisakow your answer is a good idea, but not simple as calling transform(), which is what one would expect

@anishafluffy
I have been able to overcome this issue.
After inspecting mca.py in the repo, I've noticed that one of the first things is the one hot encoding with pd.get_dummies(X) (line 24).
The dimension mismatch error occurs when you have unseen labels on the test set, or categories that are not present.
The solution was:
1 - Onehotencode my dataset before using mca.fit() with pd.get_dummies
2 - Save pd.get_dummies metadata
3 - Onehotencode the test set with pd.get_dummies
4 - Drop unseen labels based on saved metadata
5 - Create encoded columns not present in the test set, filling the columns with 0
6 - Use mca.transform() method. Now it works!

the problem is
when to transform training data using MCA one of the step is transforming using OHE
lets say your training dataset contains 100 features after transforming using OHE
you apply same values on the testing data which may not contain one of the categories leading to 99 features instead of 100
this will not make the transformation happens until you add the missing column to the testing dataset or find another way to do so.

Hello there 👋
I apologise for not answering earlier. I was not maintaining Prince anymore. However, I have just refactored the entire codebase. This refactoring should have fixed many bugs.
I don’t have time and energy to check if this fixes your issue, but there is a good chance it does. Feel free to reopen this issue if the problem persists after installing the new version — that is, version 0.8.0 and onwards.

@anishafluffy I have been able to overcome this issue.
After inspecting mca.py in the repo, I've noticed that one of the first things is the one hot encoding with pd.get_dummies(X) (line 24). The dimension mismatch error occurs when you have unseen labels on the test set, or categories that are not present.
The solution was: 1 - Onehotencode my dataset before using mca.fit() with pd.get_dummies 2 - Save pd.get_dummies metadata 3 - Onehotencode the test set with pd.get_dummies 4 - Drop unseen labels based on saved metadata 5 - Create encoded columns not present in the test set, filling the columns with 0 6 - Use mca.transform() method. Now it works!

good shout, one of the other options is just to use model's objects's MCA.active_cols instance and then append columns that are not present in the test dataset and set with 0

@anishafluffy I have been able to overcome this issue.
After inspecting mca.py in the repo, I've noticed that one of the first things is the one hot encoding with pd.get_dummies(X) (line 24). The dimension mismatch error occurs when you have unseen labels on the test set, or categories that are not present.
The solution was: 1 - Onehotencode my dataset before using mca.fit() with pd.get_dummies 2 - Save pd.get_dummies metadata 3 - Onehotencode the test set with pd.get_dummies 4 - Drop unseen labels based on saved metadata 5 - Create encoded columns not present in the test set, filling the columns with 0 6 - Use mca.transform() method. Now it works!

This is my version of the initial example after following cnmoro's approach:
import pandas as pd
import prince # 0.13.0

X = pd.DataFrame(
data=[
['A', 'A', 'A', 'm'],
['A', 'A', 'A', 'f'],
['B', 'A', 'B', 'm'],
['B', 'A', 'B', 'm'],
['B', 'B', 'B', 'f'],
['B', 'B', 'A', 'f']
],
columns=['feature1', 'feature2', 'feature3', 'feature4'])

# training data
X0 = X[:4]
Xd = pd.get_dummies(X0)

# test data
X_test = X[4:]
Xtd = pd.get_dummies(X_test)

unseen_labels = [x for x in Xtd.columns if x not in Xd.columns]
new_cols = [col for col in Xd.columns if col not in Xtd.columns]
for name in unseen_labels + new_cols:
    Xtd[name] = 0

from prince import MCA
mca = MCA(one_hot=False)
mca = mca.fit(Xd)
mca.transform(Xtd)

@vcuziol Please annotate your code block properly in order to activate syntax highlight, like this:
import pandas as pd
import prince # 0.13.0

X = pd.DataFrame(
data=[
['A', 'A', 'A', 'm'],
['A', 'A', 'A', 'f'],
['B', 'A', 'B', 'm'],
['B', 'A', 'B', 'm'],
['B', 'B', 'B', 'f'],
['B', 'B', 'A', 'f']
],
columns=['feature1', 'feature2', 'feature3', 'feature4'])

# training data
X0 = X[:4]
Xd = pd.get_dummies(X0)

# test data
X_test = X[4:]
Xtd = pd.get_dummies(X_test)

unseen_labels = [x for x in Xtd.columns if x not in Xd.columns]
new_cols = [col for col in Xd.columns if col not in Xtd.columns]
for name in unseen_labels + new_cols:
    Xtd[name] = 0

from prince import MCA
mca = MCA(one_hot=False)
mca = mca.fit(Xd)
mca.transform(Xtd)


Missing conformer config files?

Title

Training Config File for Conformer Models

Description
I am trying to train conformer-small model. On the readme it says the command line argument "conformer_large_train" should be passed for training conformer model. But I am unable to locate config file conformer_large_train. Is it currently not available or am I missing? Thanks.
Linked Issues

resolved #

In Hydra, configuration can manage using class. Check https://github.com/sooftware/KoSpeech/blob/latest/kospeech/trainer/init.py

You are right, I missed that part. Thanks for the answer, I am closing the issue.


Adding logging middleware

Adds a middleware that will extract the x-request-id headers and will automatically insert it into the log messages.

If we agree with this method I will need to change all of the getLogger calls in DAB to use this.
I could easily be convinced to turn this into an application so that you can just add ansible_base.logging_middleware to your installed_apps and dynamic_config could add our middleware class.

Link https://github.com/ansible/django-ansible-base/pull/478, how is that one looking to you? I would prefer it.


Fix some of the remaining mbf abstract nav todos

This PR will fix some of the ToDos we added during the initial ROS2 migration. In contrast to how I named the branch, the PR does not yet remove all ToDos. This is to get more easily digestible PRs and there were more ToDos than I anticipated... :D
Changes:

Some easy replacements from boost to std
Change const &T member to be shared_ptr<const T>

I think having const references to class members is a code smell. This particular instance (T=RobotInformation) didn't cause any issues during the tests. Some other cases (already fixed) already caused segfaults or similar crashes during the unit tests. Generally, I think it's better style to use a shared ptr here and the overhead is minimal (reference counting) (your opinions?).
Note that this changes the interface for all subclasses, which is quite a pain... But as we need to change the interface anyways for ROS2, it's a got moment to change this.

I think the changes to shared ptr are a good idea :-)


Add support for 'next line' heading markdown

Overview: Generally, markdown headers use hash characters (#) to represent levels of headings. Alternate headings markdown characters exist: - (dash) for 1st level heading, and = (equals) for 2nd level heading.
Expected: This extension will create a table of contents from level 2 headings creating using the = markdown character.
Actual: This extension will not attempt to make a table of contents from level 2 headings created in markdown with the = character.

Completed with v0.3.1 release via PR #15


Cloudflare's cf-connecting-ip header is not forwarded

I'm using Zeit cname config with external domain, Cloudflare in front (dns).
It turns out that Zeit is not forwarding the cf-connecting-ip header from Cloudflare. That header contains the original IP the request is coming from.
How can I get access to this header?

@satyavh can you check if X-Forwarded-For contains the user IP address?

x-forwarded-for contains Cloudflare's ip.
But I've noticed cf-connecting-ip is now included in the headers. Now sure what has changed :-|
Closing this now. Sorry to bother.

No worries!


proposal: support customized spiffeId format

Background:
We are migrating our existing large-scale north-south gateway from Nginx to Istio/Envoy, at Ant Group.
We want to enhance Istio to support our scenario without hacking the existing Istio core codebase.
Here is a case:
ParseIdentity only supports the standard spiffe ID, but we have a customized format.
https://github.com/istio/istio/blob/master/pkg/spiffe/spiffe.go#L65
Here is my thought:

introduce an interface:

type SpiffeIdParser interface {
    Parse(s string) (domain, namespace, serviceAccount string, err error)
}

and register the existing logic in ParseIdentity as the default SpiffeIdParser.

So that we could register our customized spiffe id parser, without hacking Istio.
Any suggestions are welcome, thanks!

This approach would still require a fork. My recommendation would be a configurable url template with named variables that correspond to the service account and namespace. I do agree though that this needs to be solved

Thanks @keithmattix , url template would be simple and works in most scenarios.
but in our scenario, there are multiple versions of spiffeId format, so, we need to configure multiple url templates, which would also work for us.
A fork is acceptable and desired for us, maybe we can support registering SpiffeIdParser interface first?
It gives us the ability to customize more flexibly.

Thanks @keithmattix , url template would be simple and works in most scenarios. but in our scenario, there are multiple versions of spiffeId format, so, we need to configure multiple url templates, which would also work for us.
A fork is acceptable and desired for us, maybe we can support registering SpiffeIdParser interface first? It gives us the ability to customize more flexibly.

i agree, Registering SpiffeIdParser will be more flexible.

Maybe there are too many places in istio that can be easily and cleanly extended through the interface

#43105 has a lot more discussion/context on custom spiffe formats, though it doesn't seek to necessarily address the forking use case. I imagine any kind of progress here would result in a new interface so I'm inclined to close this issue in favor of the ongoing discussion

Hi @keithmattix , sorry for the late, I'm happy to take non-interface ways, i.e. multiple url templates.
An interface is just a prefered choice for us, since we already need a fork based on othe requirements.
So, do you think multiple url templates is accepted? if yes, I would like to have a try, thanks~

Not stale

I think for the general purpose case of customized ID we are tracking in https://github.com/istio/istio/issues/43105. The project is not currently making generic interfaces to make forking Istio easier.


CLID-67: feat: adds --v1 flag to redirect to legacy code

Description
As part of the v2 migration, it is necessary to guarantee that v1 (legacy code) is available until the deprecate period finishes. It was added a --v1 flag to redirect the flow to v1.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
./bin/oc-mirror --help

Expected Outcome
--v1 flag should show in the --help

@aguidirh - could you update the target version in the JIRA

/lgtm


Improve mobile view

Currently the app looks quite squishy within in-app browser. Steps to adjust layouting, texts and other elements should be taken to make it feel more natural.

[ ] Redesign mobile header menu

Mobile menu needs to be redesigned.


Fix cargo publish; fix linking errors when using backends other than GL3

Referencing #56.
The linking error was caused by nanovg-sys being always built with gl3. The way feature selection works is that default features are always on unless explicitly turned off. In other words if I said:
nanovg-sys = { path = "nanovg-sys", features = ["gl2"]}

then because nanovg-sys defaults to:
default = ["gl3"]

the enabled features would be gl3 and gl2. Now, because build.rs checks for gl3 first, it would build with gl3. Hence the linking error.
As you said nanovg-sys won't build without a default feature so I gave it one and then disabled it in nanovg-rs. This works because cargo publish does not publish the binaries. It runs the clean build only as a validation check (afaik).
I also removed the default feature from nanovg-rs so that users don't have to set default-features = false. But this is a judgement call, maybe it should stay. Dunno.

You're welcome. Btw. now that I think of it I should've kept the default and moved gl3 to the end of the list in build.rs or added some validation there. Would also work. I don't see an option to add a file in the online editor so it's up to you if you want to do it.


TRAMP complex - New component ontology term

Hi,
I would like to propose the following complex term be added to the
component ontology as an instance of protein complex
(GO:43234) and a child term of nucleus (GO:5634):
Term: TRAMP complex
Synonyms:  Trf4p-Air2p-Mtr4p polyadenylation complex; Trf4
poly(A) polymerase complex; Trf4 complex
Definition: A multiprotein complex in yeast consisting of Trf4p,
Air1p or Air2p and Mtr4p. This nuclear RNA surveillance and
quality control complex is involved in the distributive
polyadenylation of substrates that include: hypomodified and
incorrectly folded tRNAs, snoRNA precursors and rRNA
precursors. It is also required for the degradative activity of the
nuclear exosome in vivo.
Definition_references:
PMID: 15828860
PMID: 15935758
Thanks,
Rob
Reported by: rnash
Original Ticket: "geneontology/ontology-requests/2590":https://sourceforge.net/p/geneontology/ontology-requests/2590

I would like to revert TRAMP complex to this definition.
There are a couple of old papers referring to en-processing but this appears to be a phenotype of stuffing up non-functional RNA decay (I will double check this)

ignore


[BEAM-11289] [Python] Integrate Google Cloud Recommendations AI functionality

Integrate Google Cloud Recommendations AI functionality

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PostCommit

Run Python 3.8 PostCommit

@matthiasa4 - Is this ready for review?

@aaltay there seems to be issues with the tests still. I am assuming it might be related to the service account permissions that run them since the API is returning nulls which make the test fail, wdyt? I don't think I can grant these permissions.
cc @pabloem

@aaltay there seems to be issues with the tests still. I am assuming it might be related to the service account permissions that run them since the API is returning nulls which make the test fail, wdyt? I don't think I can grant these permissions.
cc @pabloem

I do not know much about it. Why can't you grant these permissions? What do you need?

So the pipeline tests call an API that sit in a test project (to which @pabloem has access) - last time we enabled the API, but since the API is returning nulls while, when I run locally against my own project, the tests pass, hence I think it might be a permission issue.

So the pipeline tests call an API that sit in a test project (to which @pabloem has access) - last time we enabled the API, but since the API is returning nulls while, when I run locally against my own project, the tests pass, hence I think it might be a permission issue.

That makes sense. Which project is this, is it apache-beam-testing?

@aaltay yes, that's the one!

@aaltay yes, that's the one!

I added you to the project. That should give you enough permissions to make the changes you need. Let me know if that does not work.

@aaltay - getting the following message in the console at the moment: You don't have permission to set up a catalogue. Please get 'Owner' or 'Recommendations AI Admin' IAM role assigned to you. - I think the later should do.
Also, is it fair to assume for the pipelines, the regular compute service accounts are used? Then I will be able to give this one the right permissions to call the API.

Recommendations AI Admin

Done. Give it a try.

@aaltay - getting the following message in the console at the moment: You don't have permission to set up a catalogue. Please get 'Owner' or 'Recommendations AI Admin' IAM role assigned to you. - I think the later should do.
Also, is it fair to assume for the pipelines, the regular compute service accounts are used? Then I will be able to give this one the right permissions to call the API.

Done. Give it a try.

Run Java PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

@pabloem @aaltay looks like the failing test is not related to the contributed code - any advise on if that's ok to merge? I rebased onto master yesterday.

@pabloem @aaltay looks like the failing test is not related to the contributed code - any advise on if that's ok to merge? I rebased onto master yesterday.

Agreed. It is fine.
Do you want to squash your commits?
Also, have @pabloem completed his review?

Thanks @aaltay - I'll wait for a lgtm from @pabloem before squashing and merging :)

ah so sorry about the delay. Looking...

this LGTM : ) thanks @matthiasa4 - feel free to merge as you see fit!

Thanks @pabloem and @aaltay for the continued help! :)


Application mode: Issue with side menu

Issue appears when unsupported (for Application mode) menu templates are used.


Problem id higher than 2127 doesn't show and cannot found.

I want to solve problem 2376 but found out that the extension only have 2127 problems.

So I tried to create my own file to cope with this problem.

But it doesn't work with error.

Yeah, I can confirm I'm getting the same issue

I tried but nothing changed, by the way i use third party login with github account to login leetcode.com.

Have you tried to refresh your list by clicking the "Refresh" button above the problem list?

I update the node version to v18.12.1 and reset all settings in extension. The extension now works fine.


Add CBMC Proof of s2n_stuffer_read()

Issue # (if available): N/A
Description of changes:
Adds a Proof of s2n_stuffer_read() function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (cbmc_s2n_stuffer_read@ce9627a). Click here to learn what that means.
The diff coverage is n/a.


Add Student  perfomance datasource into cQube 4

Merge the cQube v1 student perfomance datasouce in to cQube v4 and change the look and feel according to cQube 4 Dashboard.
Expected outcome:-
To be able to see the student perfomance screen with new styling

[ ]  SAT Map Report

[ ]  SAT Heat Chart

[ ]  PAT map Chart

[ ]  PAT Heat Chart

[ ]  PAT LO-Table


[SPARK-15637][SPARK-15931][SPARKR] Remove R version check since masked functions are fixed

What changes were proposed in this pull request?
Because of the fix in SPARK-15684, this exclusion is no longer necessary.
How was this patch tested?
unit tests
@shivaram

Test build #60386 has started for PR 13636 at commit a5eb3da.

Test build #60386 has finished for PR 13636 at commit a5eb3da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60386/
Test PASSed.

LGTM. Just to confirm your local tests pass with R version > 3.2 ?

great point - @wangmiao1981 it looks like startsWith and endsWith are still masked on R 3.3?
re: PR #13476

I'm still seeing errors after this change in my environment:
Failed -------------------------------------------------------------------------
1. Failure: Check masked functions (@test_context.R#31) ------------------------
length(maskedBySparkR) not equal to length(namesOfMasked).
1/1 mismatches
[1] 22 - 20 == 2

2. Failure: Check masked functions (@test_context.R#32) ------------------------
sort(maskedBySparkR) not equal to sort(namesOfMasked).
Lengths differ: 22 vs 20

DONE ===========================================================================

For reference, I was using
R version 3.3.0 (2016-05-03) -- "Supposedly Educational"
Copyright (C) 2016 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)

@liancheng we can use this PR to also address https://issues.apache.org/jira/browse/SPARK-15931

@shivaram True.
@felixcheung Could you please also add SPARK-15931 to the PR title if this PR also targets that one? Thanks.

FYI, this is what I see running on R 3.3:
1. Error: string operators (@test_sparkSQL.R#1163) -----------------------------
unable to find an inherited method for function ‘startsWith’ for signature ‘"character"’
1: expect_true(startsWith("Hello World", "Hello")) at /opt/spark-2.0.0-bin-hadoop2.6/R/lib/SparkR/tests/testthat/test_sparkSQL.R:1163
2: expect(identical(as.vector(object), TRUE), sprintf("%s isn't true.", lab), info = info)
3: as.expectation(exp, ..., srcref = srcref)
4: identical(as.vector(object), TRUE)
5: as.vector(object)
6: startsWith("Hello World", "Hello")
7: (function (classes, fdef, mtable)
   {
       methods <- .findInheritedMethods(classes, fdef, mtable)
       if (length(methods) == 1L)
           return(methods[[1L]])
       else if (length(methods) == 0L) {
           cnames <- paste0("\"", vapply(classes, as.character, ""), "\"", collapse = ", ")
           stop(gettextf("unable to find an inherited method for function %s for signature %s",
               sQuote(fdef@generic), sQuote(cnames)), domain = NA)
       }
       else stop("Internal error in finding inherited methods; didn't return a unique method",
           domain = NA)
   })(list("character"), structure(function (x, prefix)
   {
       standardGeneric("startsWith")
   }, generic = structure("startsWith", package = "SparkR"), package = "SparkR", group = list(), valueClass = character(0), signature = c("x",
   "prefix"), default = `\001NULL\001`, skeleton = (function (x, prefix)
   stop("invalid call in method dispatch to 'startsWith' (no default method)", domain = NA))(x,
       prefix), class = structure("nonstandardGenericFunction", package = "methods")),
       <environment>)
8: stop(gettextf("unable to find an inherited method for function %s for signature %s",
       sQuote(fdef@generic), sQuote(cnames)), domain = NA)

I will double check if there is indeed a problem with startsWith("Hello World", "Hello") when SparkR is loaded, or the tests are not up-to-date on what's being masked.

verified test passed and startsWith working

 Welcome to
    ____              __
   / __/__  ___ _____/ /__
  _\ \/ _ \/ _ `/ __/  '_/
 /___/ .__/\_,_/_/ /_/\_\   version  2.0.0-SNAPSHOT
    /_/

 Spark context is available as sc, SQL context is available as sqlContext
> startsWith("Hello me", "Hello")
[1] TRUE

Test build #60471 has started for PR 13636 at commit 3f053ee.

Test build #60471 has finished for PR 13636 at commit 3f053ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60471/
Test PASSed.

changed test output to show a diff, for example:
Failed -------------------------------------------------------------------------
1. Failure: Check masked functions (@test_context.R#35) ------------------------
length(maskedBySparkR) not equal to length(namesOfMasked).
1/1 mismatches
[1] 22 - 21 == 1

2. Failure: Check masked functions (@test_context.R#40) ------------------------
sort(maskedBySparkR, na.last = TRUE) not equal to sort(namesOfMasked, na.last = TRUE).
10/22 mismatches
x[13]: "rank"
y[13]: "rbind"

x[14]: "rbind"
y[14]: "sample"

x[15]: "sample"
y[15]: "sd"

x[16]: "sd"
y[16]: "startsWith"

x[17]: "startsWith"
y[17]: "subset"

x[18]: "rank"
y[18]: "rbind"

x[19]: "rbind"
y[19]: "sample"

x[20]: "sample"
y[20]: "sd"

x[21]: "sd"
y[21]: "startsWith"

x[22]: "startsWith"
y[22]: "subset"

Test build #60477 has started for PR 13636 at commit 92785ad.

Test build #60477 has finished for PR 13636 at commit 92785ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60477/
Test PASSed.

Thanks @felixcheung - @JoshRosen / @liancheng can you also test this PR with R 3.3.0 before we merge ?

This passes tests for me on R 3.3.0 on OS X.

This passes for me, too. Thank you, @felixcheung .

Thanks for testing. Updated as per the last comment.

Test build #60576 has started for PR 13636 at commit 014a5b6.

Works for me too, passes tests on R 3.3.0 on OS X 10.10. Thanks!

LGTM. Thanks all. I will merge this after Jenkins passes

Test build #60576 has finished for PR 13636 at commit 014a5b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60576/
Test PASSed.


Rubber duck is no longer animated

Somehow the rubber duck gifs are not playing the animation (it was in v0.11). It's currently only showing the first frame. The media files seem to be fine.

thats weird. is it still moving around? Which state is it in?

It is still moving and state switching works. I'll re-export the gifs to check if the files have been corrupted somehow 🤷♂. All the other pets work as expected.


Adds lifecycle option to main container

Description

Adds a lifecycle option to the helm chart in order to add a lifecycle section to the main container.
This allows for us to use create a preStop hook in order to keep the pod's processes alive and serving
requests while an AWS Application Loadbalancer Target Group deregisters the pod from its set of targets.
Example usage:

lifecycle:
  preStop:
    exec:
      command:
        - "sh"
        - "-c"
        - >
          curl -XPOST localhost:8001/healthcheck/fail;
          /bin/sleep 45;

Related Issues
List related issues.
Testing

Deployed a very similar version of this change to non-production enviroments
at HMH (Houghton Mifflin Harcourt)

production to follow soon
this was on a branch sprung from version 6.7.13 as we are currently
running AES 1.13.0 in these environments

TODO: add ci tests (once I can get the current version of those tests to
run successfully on my machine
TODO: manual testing against Emissary 2.x.x

Checklist

[ x ] I made sure to update CHANGELOG.md.
Remember, the CHANGELOG needs to mention:

Any new features
Any changes to our included version of Envoy
Any non-backward-compatible changes
Any deprecations

[ x ] This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:

Any significant changes in memory use that might require adjusting the memory limits
Any significant changes in CPU use that might require adjusting the CPU limits
Anything that might change how many replicas users should use
Changes that impact data-plane latency/scalability

[ x (hopefully) ] My change is adequately tested.

For automated, I've added charts/emissary-ingress/ci/19-test-lifecycle-values.yaml to exercise the lifecycle option; the other existing test files would exercise the lifecycle option not being set.
For manual, I've done helm installs with and without the "lifecycle" block against docker.io/datawire/emissary:2.0.2-ea using helm install ambassador ./charts/emissary-ingress/ --set enableAES=false, checking to see if pods take at least the specified amount of seconds to terminate and go unready (see the example lifecycle block in values.yaml)

[ x ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

I did not use any special dev tricks

Hi @etotten, Thanks so much for the contribution. I cherry-pciked your commit and merged it as part of https://github.com/emissary-ingress/emissary/pull/4030 since we wanted to get CI to run on the chart test and push it through. This should be available in the next chart version :) Please let me know if you have any questions, comments, or concerns.

Hi @AliceProxy  - thanks you for helping to move it forward!


C++17 build error

There are a few places in the source code that is not C++17 standard compliant when built under that standard, for example so far I am able to identify the following
      fields[i] = field(field_names[i].to_string(), field_values->type(),
                        field_builders_[i].nullable, Kind::Tag(field_builders_[i].kind));

which can be found in cpp/src/arrow/json/parser.cc around line 369
C++17 string_view does not have a to_string method which is causing compile errors when built against C++17. It is necessary to built it under C++17 if the user want to make use of C++17 in their own code because otherwise there would be ABI  issues.
More on the ABI problem, it could be avoided if all use of util::string_view is implemented in header and delegate the pointer version of the overloads to source file, instead of the other way around, which seems to be way done at the moment. For instance the for following segments of code in the DictionaryBuilder

  /// \brief Append a scalar value
  Status Append(const Scalar& value);

  /// \brief Append a fixed-width string (only for FixedSizeBinaryType)
  template <typename T1 = T>
  Status Append(typename std::enable_if<std::is_base_of<FixedSizeBinaryType, T1>::value,
                                        const uint8_t*>::type value) {
    return Append(util::string_view(reinterpret_cast<const char*>(value), byte_width_));
  }

  /// \brief Append a fixed-width string (only for FixedSizeBinaryType)
  template <typename T1 = T>
  Status Append(typename std::enable_if<std::is_base_of<FixedSizeBinaryType, T1>::value,
                                        const char*>::type value) {
    return Append(util::string_view(value, byte_width_));
  }

The problem of this style of implementation is that the built library is tied to a specific string_view ABI. So it requires that the same flags and ABI being chosen during both the time that the library is built and the time library headers included in user code. Which is usually the most desirable but not always possible (for example, user use a pre-built binary from package manger which is built against C++11 instead of C++17).  I understand there are configure macros to avoid this issue but in my experience it is better to avoid the ABI troubles all together to begin with.

Hi can you please open a JIRA issue? PRs welcome. Note we have a PR pending that affects the DictionaryBuilder code path so you may want to wait for that to go in

Also @bkietz

@zhouyan would you mind opening a JIRA issue?

https://issues.apache.org/jira/browse/ARROW-5404?filter=-1

Thanks!


Update CSS assets from dashboard - needed for the dashboard ButtonDro…

Like Mark said, this should be pulled out of the image-magic PR - but it's needed for that PR to work.
Signed-off-by: Eric Promislow<EMAIL_ADDRESS>

LGTM ("M" for "Mark")


typo in readme

a word object has a typo in "Instructions for training (fine-tuning) of objedct detection models"

Fixed! Thanks for reporting the issue.


Draft guidance for publishing open source code

draft guidance based on:
http://gds-operations.github.io/

+1 from me to merge this one!

Thanks all, I just need to rinse this through the 2i content review with a colleague then I'll publish. This should be within the week. Thanks for your patience.


NIFI-1698 Improving customValidate in AbstractHadoopProcessor and HBa…

…seClient service to not reload Configuration unless it changed

+1 Looks good. Pushed changes to master and the support/nifi-0.6.x branches.


Update deprecating-ie-support.md

Docs Build status updates of commit 8477396:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/web-platform/deprecating-ie-support.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Custom "can't preview" messages

Make them a bit more descriptive and informative so that it's clear the file type isn't supported for previews


Don't support baidu push

Push.prototype.register only have wns, gcm or apns, I need to use what device platform when i register baidu
I try this but not work
       baidu_push.startWork("BNafRPUIqamfe1mRxDXfYG09", function(data){                 console.log(data);                 var handle = data.appId;                 alert("baidu appId");             client.push.register('gcm', handle, {                   mytemplate: { body: { data: { message: "{$(messageParam)}" } } }               });         });

Baidu is not supported by Azure Notification Hubs.  Once Baidu is supported, the registration process (which wraps Notification Hubs registration process) will work as well.


Table List Add Info

For the table list, instead of just returning the table names I would like the following info as well.

Big and small blind size
Number of players
Max number of players
Private? If you want to list private games as well.

I am thinking it should return a list of JSON objects like:
[
  {
   "table_name": "TEST",
   "small_blind": 1,
   "big_blind": 2,
   "num_of_players": 3,
   "max_players": 9
  },
]

kk will do next. ill also include num_bots i think

Sure. I was mostly wanting to calculate the number of available seats. Therefore in my mind the number of players included both humans and bots.

dun


ci: raise goreleaser cnpg plugin build timeout

should fix this issue in the CI/CD: https://github.com/cloudnative-pg/cloudnative-pg/commit/6b41d6cedda5f79580fe948fee46996cf90ae442/checks

/ok-to-merge

/ok-to-merge


suggest replacing all files xxxx_Impl.h by xxxx.cpp

May I suggest suggest replacing all files xxxx_Impl.h by xxxx.cpp?
Having all code in .h header files creates linking errors if you "#include <MySQL_Generic>" from different .cpp modules of the same project, because the linker will find several times functions with the same name.
Having a proper .h corresponding to a proper .cpp, you can include the .h several times from everywhere without causing lining problems.
It happened to me.
Just a suggestion.

Have a look at

HOWTO Fix Multiple Definitions Linker Error or similar issues.
Different behaviour using the src_cpp or src_h lib #80

I forget to convert this to h-only library with example similar to multiFileProject how to deal with the issue.
Will publish new release to deal with this, but never going back to .cpp-style, unless absolutely necessary.

thank you for that info.
I ll read those links.
thanks

Hi @pabloandresm
The new MySQL_MariaDB_Generic releases v1.7.0 has just been published. Your contribution is noted in Contributions and Thanks
Please test one of the new examples, such as multiFileProject_Ethernet, to see how to do for multiple-file projects to avoid Multiple Definitions Linker Error
Best Regards,
PS:
I'm excited and so busy to follow up with your suggestions, but still wish you provide many more ;-))

Releases v1.7.0

Convert to h-only style
Add multiFileProject examples to demo for multiple-file projects

thank you very much.
I will try to keep up with the suggestions and fixes.
Are you going to publish it soon? so I can install it via Arduino.
Let me try the 1.7.0 and stress it and I will let you know.
thank you very much

Already published. You can install from Arduino or PlatformIO now.

strange.....arduino shows me the latest one as 1.6.1, and not the 1.7.0

It takes some time to propagate to Library Manager (some hours ??). You can download directly from the GitHub, then unzip.
PS:
You have a good talent to finding bugs, especially using your stress tests. I wish you can use that to spots the bugs in my other libraries.

yes, sure. Which other libraries you need to test?
one detail I forgot to mention.....since 1.6.0, when I update this library on Arduino IDE, it asks me if I want to update just this library or the dependencies also (it shows me a list of 5 dependency libraries). If I choose all dependencies, it successfully updates ONLY this library and fails with an error. Maybe this is caused by some dependency you marked that are ment to be for platformio?
I will screenshot it next time.

Because this library is written to support too many boards, shields, libraries, architectures and platforms, I have to add all of them to the list. Many users complaint long ago if not. So better extra than nothing.
Sometimes, the Arduino IDE and/or PIO is not intelligent enough to select the correct libraries for that architectures / platform.
So, you have to manually install the necessary libraries, at least you know the list.

You can see my full list of 130+ libraries in KH Libraries
Just jump into any library you're interested and possibly will use in your project, then click Homepage to jump to GitHub to download / test. All are in Arduino IDE Library Manager as well and you can use the name to install.

@pabloandresm
I'm going to invite you to a Private Repo to deal with the libraries' testing as this is not the suitable place and topics.

Already invited and waiting for your acceptance.


Refactoring: Replace using namespace with using for the individual elements

Given the example
#include <algorithms>
#include <array>
using namespace std;

int main() {
    array<int, 10> s = {5, 7, 4, 2, 8, 6, 1, 9, 0, 3};
    sort(s.begin(), s.end());
    return s[0];
}

it would be nice if I would have a refactoring tweak available to replace using namespace std; by
using std::array;
using std::sort;

Not sure if something like this can be implemented, though.
Afaict, the information which UsingDirectiveDecl was used during the resolution of which DeclRefExpr is not available in the AST

We have RemoveUsingNamespace which is very similar.
It has some limitations but works on your example. It could be adapted to add using declarations instead.

Afaict, the information which UsingDirectiveDecl was used during the resolution of which DeclRefExpr is not available in the AST

This is true, but finding unqualified references to names from the namespace is pretty close...

Amazing! I should have double-checked for the existing functionality.
Somehow I assumed replacing the UsingDirectiveDecls with UsingDecls would be simpler, and was sufficient for my case (i.e. get rid of namespace-polluting using namespace).
Feel free to close this issue - or keep it open if you consider this to be useful functionality to be implemented in the future

Feel free to close this issue - or keep it open if you consider this to be useful functionality to be implemented in the future

FWIW, I would consider this functionality useful. Depending on the prevailing code style, you may not want to fully qualify all the names in the file.

Is there a way to do this? This simulates named imports of the other languages


feat: update to eye v2.13.0

feat: update to eye v2.13.0

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v3.1.0

Your semantic-release bot :package::rocket: