Windows build: cannot enter command mode :

It seems to ignore the : key. I've tried bumping crossterm up to 0.18 (it crashed for higher versions) — no luck.

Hey, thanks for the bug report! Which terminal emulator are you using on Windows?

Additionally, in https://github.com/Gskartwii/teehee/commit/e0273d0d17c923786468a21d81628d7462d82574, I've upgraded the crossterm dependency and ported the code accordingly. Perhaps it can be helpful for fixing the issue (unfortunately I'm not able to test it right now).

I'm using ConEmu, but this has been tested with running from «Run» menu Neovim and Far Manager are working fine, so nothing is bothering in the way. Some other keys aren't working too, but I think : is the most obvious to test and fixing this will fix others.
I've cloned the repo from scratch and built it — nope, still no luck, no command mode.

My new hypothesis is that the crossterm interface reports the SHIFT key modifier differently depending on the platform. Perhaps the newest commit will fix it?

Nope, didn't work.

cargo install --path . should be perfect, if you subsequently run the program that is located in Cargo's bin folder (which typically is in the PATH).
I've made yet another attempt to remedy the issue (the last one had a glaring flaw that I missed, sorry!) If this one doesn't fix it, I'll look into setting up ConEmu for myself for easier debugging.
The relevant commit: https://github.com/Gskartwii/teehee/commit/198932aee4556a3a8bd93f45218185a96eec0508

Now it seems to work as expected 👍

Good to hear so!


add interactions journey to investments

This work adds the following features for interactions to investment:

list
create
edit
details

I have built this using the foundations @tyom has created for the structure of investments.
Of Note

You will notice the investment interactions are on the /investment url. Because of the current jumping in and out of interactions we have and interactions not feeling a "part of things". Also because this interaction journey has some differeces to the current one, TBD.

/investment/:id/interaction/:interactionId/create
/investment/:id/interaction/:interactionId/edit
/investment/:id/interaction/:interactionId/details

There is a bit of boiler plate around that could do with tidying up, but it felt like this tidying up would be easier to see when its in and as it grows
I have placed the interactions work for investments into controllers/investments/interactions this is potentially a temporary name-spacing
The markup for the interactions list view is verbatim and needs looking at in a separate PR when I have designs
Due to time constraints there are no tests with this PR they will be coming next

No cancel button ? There's no way to go back
Should show the company & project at the top of the edit/add form in case you walk away from keyboard, come back and forget what you are doing
Also I'd like to see a flash message after saving and editing to inform you what you did in case you forgot (adhd)
Once in the interaction you feel lost.
View of interaction should include company and project so you can click on them
Date should default to today
Pressing save on a new interaction should take you to the list view
DIT Advisor should default to current user
Dit advisor was empty when you edit an interaction, should this be populated, I thought it's required?
Didn't see in the video if the interactions in the list expand or not and how you click on an interaction to view it
I still think the expanding thing is a Bad idea as it feels more natural to have it expanded and click on the title to view it.

Comments on comments

No cancel button ? There's no way to go back

browser back works, but if I suspect it's a low impact change

Should show the company & project at the top of the edit/add form in case you walk away from keyboard, come back and forget what you are doing

Should show project, but company is awkward in the context of Investment. Fix this in a future PR.

Also I'd like to see a flash message after saving and editing to inform you what you did in case you forgot (adhd)

Low priority. Raise as issue

Once in the interaction you feel lost.
View of interaction should include company and project so you can click on them

Project yes, company no. Fix in future PR

Date should default to today

Minor, raise issue

Pressing save on a new interaction should take you to the list view

Medium. Fix in next PR.

DIT Advisor should default to current user

Minor. Fix in future PR.

Dit advisor was empty when you edit an interaction, should this be populated, I thought it's required?

Same as above

Didn't see in the video if the interactions in the list expand or not and how you click on an interaction to view it

Needs a go-round with design. Fix when we are asked to update the Investment Project as whole.

No cancel button ? There's no way to go back

I can add one if required?

Should show the company & project at the top of the edit/add form in case you walk away from keyboard, come back and forget what you are doing

I did have this but removed it. Agreed, do we have designs for this?

Also I'd like to see a flash message after saving and editing to inform you what you did in case you forgot (adhd)

Is this a design requirement? Do we have flash messages on the site?

Once in the interaction you feel lost.

Agreed

View of interaction should include company and project so you can click on them

Agreed, I'm not sure what the designs latest thinking are on this.

Date should default to today

In the UI? Feels odd to be able to set a date and then it gets set to today.

Pressing save on a new interaction should take you to the list view

Can do

DIT Advisor should default to current user

Dit user is saved as the current user in the backend. Speaking with reupen yesterday he mentioned this field will be made writable so other DIT users can be placed in.

Dit advisor was empty when you edit an interaction, should this be populated, I thought it's required?

The DIT user is not showing because it doesn't match anything in the list of DIT users on that page. See above explanation.

Didn't see in the video if the interactions in the list expand or not and how you click on an interaction to view it

The expansion is in the video. Or have a look on the prototype associated with this pr

I still think the expanding thing is a Bad idea as it feels more natural to have it expanded and click on the title to view it.

Yeah as said in the Of Note section this needs revisiting. The design and the layout are pretty bad and it feels like we have common components here that can be used.

DIT Advisor should default to current user

Dit user is saved as the current user in the backend. Speaking with reupen yesterday he mentioned this field will be made writable so other DIT users can be placed in.

It's been amended on dev, so that field is writable now.

Just spotted a problem with our date handling:
Typing 1 into the month box uses the current month rather than January. We may need to revisit how we ask for and validate dates. Not sure the 3 boxes is also useful in our situation. It tests well with a wide range of users but our users are often doing multiple a day rather than one-off transactions.
We could also add shortcuts for common values, for example Set as today or Set as yesterday for interactions.

Just spotted a problem with our date handling:
Typing 1 into the month box uses the current month rather than January. We may need to revisit how we ask for and validate dates. Not sure the 3 boxes is also useful in our situation. It tests well with a wide range of users but our users are often doing multiple a day rather than one-off transactions.
We could also add shortcuts for common values, for example Set as today or Set as yesterday for interactions.

Agreed. Design have been speaking about a better way of doing dates. Maybe a good one to start component chats


Attempted hotfix of data CI

FIxes #850
Current theory is creating dask clusters in parallel is tripping over each other and interfering with other tests
Developers certificate of origin

[X] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #851 (f27465e) into main (cf2bec6) will increase coverage by 14.10%.
The diff coverage is n/a.

Additional details and impacted files

Ok think this is working, merging for hotfix.


Automagically comment on style issues inline on PRs.

This was a sideproject that proved to be useful before, I've added the
ability to traverse commits in a PR as well as a single commit. More
detail about this on sevki.org/joker.
 joker -repo=$REPO_NAME \
       -owner=$REPO_OWNER \
   -token=$GH_TOKEN \
   -pr=$PR \
   -scanner=golint

If the scanner flag is todo joker will parse comments in
 // TODO(sevki): write better documentation

format in the source and open issues assign them to people on github.
Joker can be easily extended to do go/vet or go/build analysis just
as easily as it does golint. Which is why there is a hack/github.sh
based on @icecrime's PR #14780

cool project ;)

@jfrazelle

So I think this is something we could add to the Gordon bot possibly

Yeah this is perfect for Gordon :) I'll checkout adding it tomorrow

yeah, I think it would work better in leeroy, other project could benefit of it.

ok cool I'm going to close this here and we can continue talking about it as integration into https://github.com/jfrazelle/leeroy


Allow ';' as query string delimiter as well as &.

There is conflicting information on what is or is not accepted as a
query delimiter string, but at some point in history, both & and ; have
been used.
https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Generic_syntax
Since the ';' is only allowed as a delimiter in the url, it seems that we
should be be able to parse the query string by splitting on the ; in the
same way we split on the &.

I don't see any good reason why we should do this. As pointed out by yourself and by the footnote

Historic RFC 1866 (obsoleted by RFC 2854) encourages CGI authors to support ';' in addition to '&'

I never came across this in the wild (could be me though) and we shouldn't support it just because some servers in 1980 used this format. There's also a reason why we are dropping support for Node.js 0.10 and 0.12 and choose not to maintain deprecated stuff.
So feel free to come up with arguments why you think it should be added :).

Not got a lot of spare cycles to argue for it, just looked like a quick change that wouldn’t break anything else, since ; is only allowed as a delimiter.

J.

On Apr 18, 2017, at 10:30 AM, Sam Verschueren<EMAIL_ADDRESS>wrote:
I don't see any good reason why we should do this. As pointed out by yourself and by the footnote
Historic RFC 1866 (obsoleted by RFC 2854) encourages CGI authors to support ';' in addition to '&'
I never came across this in the wild (could be me though) and we shouldn't support it just because some servers in 1980 used this format. There's also a reason why we are dropping support for Node.js 0.10 and 0.12 and choose not to maintain deprecated stuff.
So feel free to come up with arguments why you think it should be added :).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/sindresorhus/query-string/pull/92#issuecomment-294862943, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAnxfWEyOksNKwruYAQEnKbwxmm773mks5rxMkBgaJpZM4NAV66.


Client doesn't start and leaves a prompt

I get above prompt after clicking on the installed "Client.v1.0.0-beta.3" application. I'm on a windows 11 system and I have both Visual C++ Runtime and WebView2 installed on my device. Could you provide a fix for the above issue?

The client shouldn't be making this prompt. Are you running a "debloated" install of windows? I think you may be missing Microsoft Edge or something that registered a browser protocol.

closing for inactivity


(1 min change) Could CUDA setup use logging instead of printing?

Right now https://github.com/TimDettmers/bitsandbytes/blob/main/bitsandbytes/cuda_setup/main.py#L138 prints instead of using standard logging, making it impossible to lower the verbosity of the library. It would be an easy change to implement.

This would be a great feature! I would love to get a PR for this. Would you be able to work on this?


RHIDP-2871: Update Backstage CR in TechDocs doc

Version(s):
1.2
Issue:
https://issues.redhat.com/browse/RHIDP-2871
Link to docs preview:
Operator section: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-439/admin-rhdh/#proc-techdocs-configure-odf-operator_assembly-admin-templates
Helm section: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-439/admin-rhdh/#proc-techdocs-configure-odf-helm_assembly-admin-templates
Reviews:

[ ] SME: @kadel
[ ] QE: TBD
[ ] Docs review: TBD

@kadel I'm picking up this PR that @linfraze had created and you reviewed.
After applying your suggestions, I just wanted to check that your comment in the Jira has been applied (I don't think it has).
Could you please confirm if this section still needs to be updated per your Jira comment:

Could you please confirm if this section still needs to be updated per your Jira comment:

The section that you mentioned and showed in the screenshot is correct.

After applying your suggestions, I just wanted to check that your comment in the Jira has been applied (I don't think it has).

This Jira issue talks about this:

And TBH, I got a little bit lost there :-/
Now,  when I'm reading it it looks ok. In the highlighted block there should NOT be any kind as it is not Kubernetes Custom Resource, but snippet from Helm Chart configuration (values)
I think it looks ok NOW
/lgtm
/approve

/cherrypick 1.2.x


create Shopify one-time swag codes

hit the shopify API
check that achievement criteria is met
send code back (possibly to the activity hub (still in questions)) and store it (for issue #456)

we'll need to create a PriceRule that has all the logic for the given achievement
it appears we also have to create a discount code using the DiscountCode API endpoint that follows the price rule, which I want to test because it seems odd to have to do it twice if both are required

this can happen in a serverless function
the function MUST validate that the given user ID meets the criteria to create a new discount code
the function MUST check to see if an existing code already exists

we'll need to create a PriceRule that has all the logic for the given achievement
it appears we also have to create a discount code using the DiscountCode API endpoint that follows the price rule, which I want to test because it seems odd to have to do it twice if both are required

this can happen in a serverless function
the function MUST validate that the given user ID meets the criteria to create a new discount code
the function MUST check to see if an existing code already exists


X509: Flag modified when X509_req_info_st updated - follow-up for 3.0+

This is a variant of #18879 for 3.0 and master, rebasing that PR from 1.1.1.
On this occasion, I added a further commit that to add some NULL parameter checks and improve coding style in crypto/x509/{x509_req,x_all}.c.

This would not be eligible for 3.0 IMO.

Or maybe it would, although I am not a big fan of such cleanup kind of changes on older branches.

Asking @openssl/committers for 2nd approval.

This pull request is ready to merge

Merged to master and 3.0 - thanks @t8m and @hlandau for the approvals.


cc-wrapper: Allow specifying extra compilers to wrap.

Motivation for this change
This change allows users of cc-wrapper to specify the name of the compiler that they are wrapping. I'm using this to package a fork of clang that is proprietary and distributed as a binary with a different name. I'd be happy to change the approach this PR takes if an extraCCs option isn't desirable.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @Ericson2314 @orivej

distributed as a binary with a different name

Have you considered renaming the binary?

In my opinion we should make cc-wrapper more modular, in that you provide what is needed for your compiler. If that's not going to be done anytime soon I think your solution is good. But I don't maintain this part :)

distributed as a binary with a different name

Have you considered renaming the binary?

I did, but other tooling (such as the CMake for using this compiler) expects it to have the original name, so when I tried to do this it complicated things pretty significantly.

ping @Ericson2314 @orivej - sorry to be a bother, just in case you missed this.

You could also use override like:
gcc.overrideAttrs (old: {
  installPhase = old.installPhase + ''
    wrap ${old.targetPrefix}mycc $cc-wrapper $ccPath/${old.targetPrefix}mycc
  '';
})

The only problem is how to reach cc-wrapper.sh. I think it needs to be added as an attribute. Something like
diff --git a/pkgs/build-support/cc-wrapper/default.nix b/pkgs/build-support/cc-wrapper/default.nix
index cf2d38cd997..60f18e7b4d1 100644
--- a/pkgs/build-support/cc-wrapper/default.nix
+++ b/pkgs/build-support/cc-wrapper/default.nix
@@ -132,6 +132,8 @@ stdenv.mkDerivation {
     src=$PWD
   '';

+  cc-wrapper = ./cc-wrapper.sh;
+
   installPhase =
     ''
       set -u
@@ -173,42 +175,42 @@ stdenv.mkDerivation {
       export default_cxx_stdlib_compile="${default_cxx_stdlib_compile}"

       if [ -e $ccPath/${targetPrefix}gcc ]; then
-        wrap ${targetPrefix}gcc ${./cc-wrapper.sh} $ccPath/${targetPrefix}gcc
+        wrap ${targetPrefix}gcc $cc-wrapper $ccPath/${targetPrefix}gcc
         ln -s ${targetPrefix}gcc $out/bin/${targetPrefix}cc
         export named_cc=${targetPrefix}gcc
         export named_cxx=${targetPrefix}g++
       elif [ -e $ccPath/clang ]; then
-        wrap ${targetPrefix}clang ${./cc-wrapper.sh} $ccPath/clang
+        wrap ${targetPrefix}clang $cc-wrapper $ccPath/clang
         ln -s ${targetPrefix}clang $out/bin/${targetPrefix}cc
         export named_cc=${targetPrefix}clang
         export named_cxx=${targetPrefix}clang++
       fi

       if [ -e $ccPath/${targetPrefix}g++ ]; then
-        wrap ${targetPrefix}g++ ${./cc-wrapper.sh} $ccPath/${targetPrefix}g++
+        wrap ${targetPrefix}g++ $cc-wrapper $ccPath/${targetPrefix}g++
         ln -s ${targetPrefix}g++ $out/bin/${targetPrefix}c++
       elif [ -e $ccPath/clang++ ]; then
-        wrap ${targetPrefix}clang++ ${./cc-wrapper.sh} $ccPath/clang++
+        wrap ${targetPrefix}clang++ $cc-wrapper $ccPath/clang++
         ln -s ${targetPrefix}clang++ $out/bin/${targetPrefix}c++
       fi

       if [ -e $ccPath/cpp ]; then
-        wrap ${targetPrefix}cpp ${./cc-wrapper.sh} $ccPath/cpp
+        wrap ${targetPrefix}cpp $cc-wrapper $ccPath/cpp
       fi
     ''

     + optionalString cc.langFortran or false ''
-      wrap ${targetPrefix}gfortran ${./cc-wrapper.sh} $ccPath/${targetPrefix}gfortran
+      wrap ${targetPrefix}gfortran $cc-wrapper $ccPath/${targetPrefix}gfortran
       ln -sv ${targetPrefix}gfortran $out/bin/${targetPrefix}g77
       ln -sv ${targetPrefix}gfortran $out/bin/${targetPrefix}f77
     ''

     + optionalString cc.langJava or false ''
-      wrap ${targetPrefix}gcj ${./cc-wrapper.sh} $ccPath/${targetPrefix}gcj
+      wrap ${targetPrefix}gcj $cc-wrapper $ccPath/${targetPrefix}gcj
     ''

     + optionalString cc.langGo or false ''
-      wrap ${targetPrefix}gccgo ${./cc-wrapper.sh} $ccPath/${targetPrefix}gccgo
+      wrap ${targetPrefix}gccgo $cc-wrapper $ccPath/${targetPrefix}gccgo
     '';

   strictDeps = true;

@veprbl Thanks for your comment.
If I'm not mistaken, to apply your proposed solution to the package that I am writing, I would need to invoke wrapCCWith/wrapCC on the package, and then override the result of that? I think this would be the only way to get a value for targetPrefix?
I'm not sure if that would be a better solution to my problem than what I've submitted in this PR. If my description of the motivation was unclear, you can see the package I am writing here and here.

@davidtwco In your case you might not need the value of targetPrefix, it is an empty string unless you cross compile. Also you don't even need to override, you can put extra logic to the extraBuildCommands argument.
This PR, as it is now, doesn't make cc-wrapper more flexible. It seems to cover only your specific case, and this functionality will have to be maintained in the future. My approach does not introduce any feature specific to your case, it just makes it more convenient to do overrides on the wrapper.

This PR, as it is now, doesn't make cc-wrapper more flexible. It seems to cover only your specific case, and this functionality will have to be maintained in the future. My approach does not introduce any feature specific to your case, it just makes it more convenient to do overrides on the wrapper.

I agree that your suggestion would make cc-wrapper more flexible. I'd be happy to modify this PR to go that route.

@davidtwco In your case you might not need the value of targetPrefix, it is an empty string unless you cross compile. Also you don't even need to override, you can put extra logic to the extraBuildCommands argument.

The only part of your suggestion I'm still struggling to understand is how I would access cc-wrapper if I put the extra logic into extraBuildCommands?

@davidtwco
After the change, you should be able to access it via "cc-wrapper" environment variable:
{
  extraBuildCommands = ''
    wrap compute $cc-wrapper $ccPath/compute
    wrap compute++ $cc-wrapper $ccPath/compute++
  '';
}

This change should also allow cc-wrapper script to be easily overridden. If you want you can propose it in a separate PR. I expect, it will be accepted.

@veprbl thanks, I've tried to get that working, but unfortunately I hit an error that I'm not sure how to resolve. I'm not sure if it is a problem with the approach or my overlay:
copying path '/nix/store/0mr3jzmbc6ldg9bzmb0pm1iszwk19grx-unzip60.tar.gz' from 'https://cache.nixos.org'...
building '/nix/store/lb6xw8hc3had3ivywzx58ki47jnw1vvq-bootstrap-stage1-gcc-wrapper.drv'...
unpacking sources
patching sources
installing
substitute(): ERROR: file '/nix/store/n9acaakxahkv1q3av11l93p7rgd4xqsf-bootstrap-tools-wrapper' does not exist
builder for '/nix/store/lb6xw8hc3had3ivywzx58ki47jnw1vvq-bootstrap-stage1-gcc-wrapper.drv' failed with exit code 1
cannot build derivation '/nix/store/xcz8bxy4zj15iifxm8vh29v0s07ky776-binutils-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3rkpqbm3hb3pr6xrlcgymjc6iidz661i-bootstrap-stage1-stdenv-linux.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/snz3x8p3dmm9haap84awpb66ggsmpv2w-perl-5.28.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cjfwy6sa5kg996f2lrvwknrc4kzc4lhm-autoconf-2.69.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yvzjdahwk2y1726k6nkq2pwq8panw3hg-autoconf-2.69.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n6skbd4qx4f5hnn218gma1g39q7ymlib-automake-1.15.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3jhy7p9mc0j42drvlk9pk4asvpzawwmd-automake-1.16.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/81divwlrrq5hndipa3v9xx4y1ac7lm3f-binutils-wrapper-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/f5bmqs4acn27f6dzpwjblyfi5gxk0y9i-binutils-wrapper-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n59kwqjhaqhp4bwnwmp4q3k2npb0rxcs-bison-3.4.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vwhgvyizbqxcbaib1lcvml7irnbfgriv-coreutils-8.31.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/18kzf9l58fh0jwjssnd1bziydakazzqk-expand-response-params.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c72ad313d2la8zyj72nvjjyfxl375gyv-gcc-7.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/knsnmiqlblln5v6q2vw2wlphj3r1m49c-gnugrep-3.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/clnb9jd41iipl7y1g2b0rg3zb4yil1z9-gnused-4.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hdvlwwfvfjxi5xc04ganqc3dkwsw83l4-libtool-2.4.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ibyrnvxlq2s6m2ky2l8nr4agpqwggahi-linux-headers-4.19.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/39pxjw72mv3lyk31bi1fq84xwia6d0w0-texinfo-6.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bgdjk786p214hz15y2i9ixdz092yld76-computecpp-wrapper-1.1.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bgdjk786p214hz15y2i9ixdz092yld76-computecpp-wrapper-1.1.4.drv' failed

Oh my bad, this is other binaries to wrap?

Yeah, this would enable wrapping binaries with names other than clang and gcc.

What is the main one of CC? named_cc is set to that. You might want to make a staging one where [ "gcc" "clang" "g++" "clang++" ] is the default or something. OTOH you might want to distinguish between ones that are optionally there and ones that are mandatorily there.

In my case, there are two binaries, compute and compute++ (compute is a symlink to compute++). They are modified builds of clang. If I understand correctly, named_cc would be compute and named_cxx would be compute++?
In the approach this PR currently takes, the existing gcc and clang wrapping still takes place as normal, but extra wrap invocations are added for each name in extraCCs.
Locally, I have the alternate approach, proposed by @veprbl, also working, which uses extraBuildCommands to call wrap twice and set named_cc and named_cxx - but in order to do this, it modifies cc-wrapper to expose ./cc-wrapper.sh as $wrapper.
If either of these approaches are suitable, I can update this PR with them. If you'd prefer I attempt to modify cc-wrapper in some other way to achieve this, then I'm happy to do that also - I'm not quite sure I understand what you're suggesting in the quoted reply.

@Ericson2314 What changes would you like me to make so that this can be merged?

@davidtwco I think my proposed solution [1] would be less invasive and that change to nixpkgs should have greater a chance to be accepted.
[1] https://github.com/NixOS/nixpkgs/pull/65813#issuecomment-522516799

@veprbl I've updated the PR with your suggested approach.

@davidtwco Since this is a mass rebuild you need to rebase to the "staging" branch.

@veprbl thanks, changed. Might have accidentally requested more reviewers automatically while doing that, sorry!

@davidtwco No problem. This can be avoided if you first reset your PR branch to a common state, then switch the github target branch and then push your PR branch by your change on top of the new target branch. It would be also fine to just open a new PR, especially because you have a new change now.
@GrahamcOfBorg build stdenv.cc

Rebased
@GrahamcOfBorg build stdenv.cc

@GrahamcOfBorg build hello

OK, It's fine in its current state to me


Project planning: Analyze Software Requirement Specification

Analyze gathered user, supplier, admin and deployment engineer requirements, groom them and prepare roadmap for development.

All user stories groomed and grouped to features.
Issues are now in developers' hands and they may further analyze, extend and develop product!


Week day not properly computed in axis

Expected behavior
When i use date for axis with Date-fns adapter (format 'yyyy-MM-dd')
when we use DisplayFormats week: "yyyy'FW'II",
Date of 12 Sept 2022 should be in 2022FW37
Current behavior
But as reported in attached picture bar is plot at the date 2022FW36.
What is strange tooltip formated as tooltipFormat: "yyyy'FW'II", works properly.

Reproducible sample
https://codepen.io/prunith/pen/BaxRGNL
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
V3.9.1
Browser name and version
No response
Link to your project
No response

Having a look to the provided reproducible sample, the mentioned bug is not occurring.  Is it possible to have the data you are using int the picture?

Yes it is reproducible on codeopen exemple. As you can see on picture bellow there is a mismatch between tooltips that display proper value and axis label
@.***
De : stockiNail @.>
Envoyé : mercredi 21 septembre 2022 14:33
À : chartjs/Chart.js @.>
Cc : Prunier, Thierry (GE Healthcare) @.>; Author @.>
Objet : EXT: Re: [chartjs/Chart.js] Week day not properly computed in axis (Issue #10679)
AVERTISSEMENT: cet email provient de l'extérieur de GE. Veuillez valider l'adresse e-mail de l'expéditeur avant de cliquer sur les liens ou les pièces jointes, car ils risquent de ne pas être sûrs.
Having a look to the provided reproducible sample, the mentioned bug is not occurring. Is it possible to have the data you are using int the picture?
—
Reply to this email directly, view it on GitHubhttps://github.com/chartjs/Chart.js/issues/10679#issuecomment-1253642893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATO2BF7KEM3GHGNON7LDGKTV7L57RANCNFSM6AAAAAAQQD72JA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I confirm the trick. Now axis aligned to proper date.
Thanks


SignalR Groups

Is there some limitation on the maximum number of groups created in signalr at a particular time?

No, there's no limit

Thanks. Please clarify the below points:

Can we know how many groups got created  in signalr
If there are no active users in the group. Will the group remains in signalr or not.

It's worth noting that be be no limit, but memory & performance may be a limiting factor; @davidfowl I appreciate no optimisation has been performed yet and this would possibly correct what I've seen when having a large number of users 2,000 sending to a group scans the metadata of the connection to see of that is in a group, even if no user is in the group your sending too

Can we remove the group if there is no user in the group?

@grahamehorner Yep, we're aware of the current performance issues with groups. But no performance work has been done at all and there's tons of low hanging fruit. We're still working through all of the big rocks so it's not the most important thing at the moment.

Can we know how many groups got created in signalr

No, there's currently no way to query the group. We're still designing this, so depending on where we land we might let you query the groups but you can't at the moment.


implemented iterstrat for multi label classification

small code change for Multilabel Stratified KFold using iterstrat.

Closing based on readme comment :)


NPCData 'OnActivate()' not working as expected

The NPC dialogue doesn't always open when entering the activation distance:
https://github.com/decentraland-scenes/dcl-npc-toolkit/assets/1031741/d2a624a1-cb30-4a12-8a05-69c182d9644e
That can be easily tested using the "Simple NPC" test scene from sdk7-goerli-plaza: https://github.com/decentraland/sdk7-goerli-plaza/tree/main/Simple-NPC
(the npc.closeDialogWindow(marsha) line from onWalkAway() has to be removed as it's old and also breaks the functionality)

Did you solve this? I'm having the same issue when trying to open talk window by clicking on an entity:
pointerEventsSystem.onPointerDown(         {             entity: leftClickArea,             opts: {                 button: InputAction.IA_POINTER,                 hoverText: 'Présentation'             }         },         function () {             npc.talk(alice, AliceDialog)         }     )
It's not working at all.


Error 'module' object is not callable does not say which function call failed

Environment data

VS Code version: 1.52.1
Extension version (available under the Extensions sidebar): v2020.12.424452561
OS and version: Host machine = Windows 10 Pro, remote env (WSL 2) = Ubuntu 20.04 LTS
Python version (& distribution if applicable, e.g. Anaconda): 3.9.1
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): poetry
Relevant/affected Python packages and their versions: n/a
Relevant/affected Python-related VS Code extensions and their versions: n/a
Value of the python.languageServer setting: Pylance

Expected behaviour
When debugging a Python file, if a function call is invalid, for the error "'module' object is not callable", the error message tells me which function call isn't allowed.
Actual behaviour
When I have a single line of Python code with two function calls, the error during debugging highlights the entire line, and I can't tell where the problem is.
Steps to reproduce:
I have the following app.py file:
import requests

from generate_events import search

URL = 'http://example.com'

response = requests.post(URL, data=search())

(URL replaced with example to hide proprietary info)
When I run it, I see this:

I didn't know exactly what was wrong. I thought my imported function search was okay, so I assumed I wasn't using the library requests properly. To double check though, I broke the code up and ran it again:
import requests

from generate_events import search

URL = 'http://example.com'

request_data = search()
response = requests.post(URL, data=request_data)

This made it clearer what the problem was because of the line the error related to:

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

User belongs to experiment group 'AlwaysDisplayTestExplorer - experiment'
User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'ShowExtensionSurveyPrompt - control'
User belongs to experiment group 'DebugAdapterFactory - experiment'
User belongs to experiment group 'PtvsdWheels37 - experiment'
User belongs to experiment group 'UseTerminalToGetActivatedEnvVars - control'
User belongs to experiment group 'AA_testing - experiment'
User belongs to experiment group 'LocalZMQKernel - experiment'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'
User belongs to experiment group 'EnableIPyWidgets - experiment'
User belongs to experiment group 'RunByLine - experiment'
User belongs to experiment group 'CustomEditorSupport - control'
User belongs to experiment group 'pythonaacf'
User belongs to experiment group 'pythonJoinMailingListVar1'
User belongs to experiment group 'pythonSendEntireLineToREPLcf'
User belongs to experiment group 'pythonInstallPylintButtonFirst'
> conda --version
> pyenv root
> conda info --json
> python3.7 ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3.6 ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python3 ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python2 ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> ~/.pyenv/versions/3.9.1/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
> pyenv root
> pyenv root
> pyenv root
> pyenv root
> pyenv root
> pyenv root
Error 2021-01-12 13:46:36: Failed to check if file needs to be fixed [EntryNotFound (FileSystemError): Unable to read file 'vscode-remote://wsl+ubuntu-20.04/home/matt/.config/Code/User/settings.json' (EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, open '/home/matt/.config/Code/User/settings.json')
	at _handleError (/home/matt/.vscode-server/bin/ea3859d4ba2f3e577a159bc91e3074c5d85c0523/out/vs/server/remoteExtensionHostProcess.js:769:473)
	at processTicksAndRejections (internal/process/task_queues.js:94:5)
	at async y.readText (/home/matt/.vscode-server/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:9:262389)
	at async p.doesFileNeedToBeFixed (/home/matt/.vscode-server/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:489303)
	at async /home/matt/.vscode-server/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:488430
	at async Promise.all (index 0)
	at async p.getFilesToBeFixed (/home/matt/.vscode-server/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:488376)
	at async p.updateTestSettings (/home/matt/.vscode-server/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:488003)] {
  code: 'FileNotFound',
  name: 'EntryNotFound (FileSystemError)'
}
Starting Pylance language server.
Python interpreter path: ~/.pyenv/versions/3.9.1/bin/python
> conda --version
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py pip --version
Python interpreter path: ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py autopep8 --diff ~/python-data-generator/generate/search_event.py
cwd: ~/python-data-generator
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py autopep8 --diff ~/python-data-generator/generate/search_event.py
cwd: ~/python-data-generator
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"

Formatting with autopep8 failed.
You could either install the 'autopep8' formatter, turn it off or use another formatter.
Error: Module 'autopep8' not installed.
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py autopep8 --diff ~/python-data-generator/generate/search_event.py
cwd: ~/python-data-generator
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py autopep8 --diff ~/python-data-generator/generate/search_event.py
cwd: ~/python-data-generator
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"
> ~/.cache/pypoetry/virtualenvs/python-data-generator-e0bvtbsJ-py3.9/bin/python ~/.vscode-server/extensions/ms-python.python-2020.12.424452561/pythonFiles/pyvsc-run-isolated.py -c "import autopep8"

Formatting with autopep8 failed.
You could either install the 'autopep8' formatter, turn it off or use another formatter.
Error: Module 'autopep8' not installed.

Just filled out a survey about Pylance, where I referenced this issue. It occurred to me while filling out that survey that the static analysis from the Python extension (or Pylance) didn't warn me I was trying to call something not callable (a module) either. If that isn't ideal behavior, I can make an issue to report that static analysis issue.

Just filled out a survey about Pylance, where I referenced this issue. It occurred to me while filling out that survey that the static analysis from the Python extension (or Pylance) didn't warn me I was trying to call something not callable (a module) either. If that isn't ideal behavior, I can make an issue to report that static analysis issue.

The error message comes from Python itself, and this is the ideal behavior atleast for debugging. If you're looking for Intellisense to warn you about this prior to running/debugging the file, I'm not sure if that's possible, but try opening that issue in Pylance. Closing this.

The error message comes from Python itself, and this is the ideal behavior atleast for debugging. If you're looking for Intellisense to warn you about this prior to running/debugging the file, I'm not sure if that's possible, but try opening that issue in Pylance. Closing this.


Resources with Array types have regressed to strings

Related to #2473 .
A property such as address_prefixes should save in Cosmos as a native array type. Instead it's being saved as a string, which is then causing issues in substitutions in pipelines.

@damoodamoo Take a look at #1846 - a requirement of this will be to have multiple address prefixes for a workspace. Hence address_prefixes should likely be in array.

I'm agreeing - it needs to be an array, yet it's being saved to cosmos as an encoded string - "[\\\"github.com\\\",\\\"www.github.com\\\",\... This was previously saving as a proper JSON array so I need to work out what's changed.


Update dependency (Windows compat)

<EMAIL_ADDRESS>incorporates https://github.com/beaugunderson/github-current-user/pull/7 - this makes friends work out-of-the-box on my Windows 8 x64 machine

:+1:


ClusterLoader - Reimplementing wait for pods measurement logs

Reimplementing wait for pods logs, so it provides more information about pods states.
Ref #293

/assign @wojtek-t


you-space services

This will be a better way to plugins and themes access the system functions in boths client and server side
Examples:
// server
import { types } = from '@you-space:services'

await types.fetchItems('articles')

// client
import { types } = from '@you-space:services'

await types.fetchItems('articles')

This ideas was abort because of #63


Regarding Loading a custom object and the replication of training code

Hi @yzqin,
I had a couple of questions I was hoping to get some insight on.

Upon inspecting load_ycb_object() in dexpoint-release/dexpoint/utils/ycb_object_utils, I see that one needs the following files for loading an object:

textured_simple.obj
collision.obj
However, in order to load a new object (like a spoon for example) in the codebase, I am unable to find the corresponding collision.obj on the YCB dataset website. Where may I obtain these assets?

I was trying to replicate the training of the policy in the codebase but encountered an error in doing so.

Here's a replication of my error:
After cloning the modified codebase here.
Run the command: python training_ppo.py
I get the following error:

It would be great if you could kindly give some insight to resolve these issues.
Thanking you in anticipation!

Hello @anupampatil44,
The textured_simple.obj file originates from the YCB dataset, while we created the corresponding collision.obj, which is the collision mesh of the relevant YCB objects.
You can readily create the collision mesh from the textured_simple.obj file by utilizing CoACD. Here's how:
pip3 install coacd
coacd -i textured_simple.obj -o collision.obj

For further details on how to utilize CoACD and optimize the parameters, please visit the original CoACD repository at this link: https://github.com/SarahWeiii/CoACD

For your second question about the error. I think you are using the PPO that is designed for training state RL with the point cloud environment. The solution is pretty simple, for debugging purposes, you can use this PPO code to train an environment without point cloud visualization, like this one


Optional query params with None not working

Hello! I have code like below:
class PaginationParams(Group):
    page: Optional[int] = 1
    page_size: Optional[int] = 100

class MyApiView(PydanticView):
    async def get(self, pagination: PaginationParams):
        ...

And it works perfectly, but if I change the default values to None, the view responds with validation error details in the response:
[{"type": "missing", "loc": ["page"], "msg": "Field required", "input": {}, "in": "query string"}, {"type": "missing", "loc": ["page_size"], "msg": "Field required", "input": {}, "in": "query string"}]

For pagination parameters, it is not critical, but for filter parameters, it may be necessary.

Thanks for the bug report. It's fixed

Released in version 2.1.1
https://pypi.org/project/aiohttp-pydantic/2.1.1/


Simplified BufferHandle and Pinning

This change allows the called of BufferHandle ctor to decide how GCHandle is constructed. For example, permamently pinned buffers can use default GCHandle and array based buffers can create single GCHandle per OwnedBuffer which gets released when reference count goes to zero.
The main changes are in BufferHandle.Create/ctor

@dotnet-bot test this please

@dotnet-bot test this please

LGTM


[WIP] MobSpawnerData Processor implementations

Implementation of REPLACE_WITH_DATA_MANIPULATOR.

[ ] Registration of field getters and setters
[ ] Accurately used the appropriate AbstractData implementation

Implementation of REPLACE_WITH_IMMUTABLE_MANIPULATOR

[ ] Accurately extended the appropriate AbstractImmutableData implementation
[ ] Accurately instantiating final instance fields with an ImmutableValue counter part for any value getters
[x] If necessary, creating a new ImmutableValue for a value that should not be cached, or, using the existing caching utils.

Implementation of the VALUE_PROCESSOR(s):

[x] Appropriately extended AbstractSpongeValueProcessor
[ ] Individual processors for each source type possible (one for ItemStack/TileEntity/Entity as necessary).

Registration:

[ ] Registered the Key correctly by FIELD_NAME in the KeyRegistry
[ ] Registered the DataProcessors and DataManipulatorBuilder in SpongeSerializationRegistry
[x] Registered the ValueProcessors in the SpongeSerializationRegistry

Test Plugin code:
There will be a lot of tests for such a large plugin, will post to a gist:
https://gist.github.com/ZephireNZ/187e1b6960feea9a0a80
Notes:
Your test plugin should test using all possible value related methods with your DataManipulators and also test the serialization and deserialization of your DataManipulators.

@gabizou are you still willing to test this personally, or should I set up one?

I'll rebase regardless :)

Still a WIP?

@gabizou, I think the method I use currently seems like it will work with the forge entity system, however I'm not experienced with it.
https://github.com/MinecraftForge/MinecraftForge/blob/6644e8c9ed4eb9db868540f8672bb83cb8aa09c0/src/main/java/net/minecraftforge/fml/common/registry/EntityRegistry.java#L178
It looks like Forge has it's own registry, in addition to registering them into Vanilla's EntityList. Only thing I can think of is if mod entities are not serialised to NBT in the format that is saved in EntityList.

Yeah, basically, you'll have to work with it through the forge side, where there's another ForgeMobSpawnerDataProcessor and likewise value processor variants on the forge end, with higher priorities (so they get called earlier).

Just did some testing of the Mob spawners with mods to ensure that it's fine as is.
As expected - I am able to add a modded entity to the spawner, and have it properly serialise and deserialise from NBT.
However I have encountered a hiccup - generally the NBT for an entity's spawner data is very limited. With the current system, everything is added, including location, uuid, etc.

It looks like the base game never has to deal with this - spawners in dungeons only ever have a type, not data when generated, and the /blockdata command expects players to choose the data to use.
@gabizou, thoughts on how to proceed?

Ok, so after some more thinking:
Perhaps add to javadocs that using EntitySnapshot created directly from an entity is bad, unless you really really want all data copied across.
Then, for EntitySnapshots created without a tag:

If they exist, serialise location/rotation from snapshot
For custom data manipulators, save as normal
This is the tricky bit

Create an entity of the given type
For each non-custom manipulator, serialise to the dataholder all values
Compare the old and new tags, and save the difference to the container (it's more work, but stops us from saving an entire entity to the tag)

There's a high chance I'm missing an easier way haha

@ZephireNZ Care to update me on what's holding this up?

Right now trying to implement what I mentioned above. Entity based on the DataManipulators on the snapshot, not just the raw NBT data.
What are you thoughts on what I mentioned?

@ZephireNZ in working with @Deamon5550 for EntityArchetype, I believe this will end up replacing the use of EntitySnapshots entirely for the use case of MobSpawnerData and the immutable equivalent.

In that case, will put this on ice until we have the EntityArchetypes, as those will be better than me hacking together the solution I described above.

Closed by #710


x/tools/gopls: panic during completion in go template (crash)

gopls version: v0.16.1/go1.22.0
gopls flags:
update flags: proxy
extension version: 0.41.4
environment: Visual Studio Code linux
initialization error: undefined
issue timestamp: Sun, 14 Jul 2024 07:29:06 GMT
restart history:
Sun, 14 Jul 2024 05:00:06 GMT: activation (enabled: true)
ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.
Describe what you observed.

panic: runtime error: slice bounds out of range [91:90]

goroutine 118 [running]:
golang.org/x/tools/gopls/internal/template.(*completer).complete(0xc0028b32c0)
	  completion.go:117  0xd25
golang.org/x/tools/gopls/internal/template.Completion({0xc0007e1980%3F, 0x5a%3F}, 0x8%3F, {0x131daa0, 0xc001b380c0}, {0x50d688%3F, 0xc0%3F}, {0x1, {0x0, 0x0}})
	  completion.go:56  0x308
golang.org/x/tools/gopls/internal/server.(*server).Completion(0xc00020c600, {0x131c608, 0xc000451230}, 0xc0002ee5a0)
	  completion.go:54  0x499
golang.org/x/tools/gopls/internal/protocol.serverDispatch({0x131c640, 0xc00054c550}, {0x1337cd0, 0xc00020c600}, 0xc000375cb0, {0x131c800, 0xc00036af00})
	  tsserver.go:361  0x2587
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3({0x131c640, 0xc00054c550}, 0xc000375cb0, {0x131c800, 0xc00036af00})
	  protocol.go:160  0x85
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4({0x131c640, 0xc00054c550}, 0xc000375cb0, {0x131c800, 0xc00036af00})
	  lsprpc.go:509  0x923
golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1({0x131c640, 0xc00054c550}, 0xc00019d020, {0x131c800, 0xc00036af00})
	  handler.go:35  0xc6
golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2()
	  handler.go:103  0x96
created by golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2 in goroutine 96
	  handler.go:100  0x1c5

gopls stats -anon
{
  "DirStats": {
    "Files": 134,
    "TestdataFiles": 0,
    "GoFiles": 40,
    "ModFiles": 1,
    "Dirs": 76
  },
  "GOARCH": "amd64",
  "GOOS": "linux",
  "GOPACKAGESDRIVER": "",
  "GOPLSCACHE": "",
  "GoVersion": "go1.22.0",
  "GoplsVersion": "v0.16.1",
  "InitialWorkspaceLoadDuration": "813.282514ms",
  "MemStats": {
    "HeapAlloc": 34401120,
    "HeapInUse": 52289536,
    "TotalAlloc": 579967608
  },
  "WorkspaceStats": {
    "Files": {
      "Total": 2107,
      "Largest": 935931,
      "Errs": 0
    },
    "Views": [
      {
        "GoCommandVersion": "go1.22.0",
        "AllPackages": {
          "Packages": 338,
          "LargestPackage": 161,
          "CompiledGoFiles": 2103,
          "Modules": 53
        },
        "WorkspacePackages": {
          "Packages": 14,
          "LargestPackage": 5,
          "CompiledGoFiles": 40,
          "Modules": 1
        },
        "Diagnostics": 0
      }
    ]
  }
}

OPTIONAL: If you would like to share more information, you can attach your complete gopls logs.
NOTE: THESE MAY CONTAIN SENSITIVE INFORMATION ABOUT YOUR CODEBASE.
DO NOT SHARE LOGS IF YOU ARE WORKING IN A PRIVATE REPOSITORY.
<OPTIONAL: ATTACH LOGS HERE>

Related Issues and Documentation

x/tools/gopls/internal/lsp/template: panic - slice bounds out of range (crash) #57621
x/tools/gopls: out of bounds panic in template completion #49600 (closed)
x/tools/gopls: automated issue report (crash) #48492 (closed)
x/tools/gopls: crash when primary diagnostics have invalid positions #66731 (closed)
x/tools/gopls: panic in semantic tokens #51731 (closed)
x/tools/gopls: crash in completion.Selection.Suffix #68169 (closed)
x/tools/gopls: crash during internal/imports.scanDirForPackage (crash) #67156
x/tools/gopls: automated issue report (crash) #40819 (closed)
x/tools/gopls: crash in typeparams.Free.Has (empty type set) #68213 (closed)
x/tools/gopls: crash in adjustRangeForCommentsAndWhiteSpace #55271 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Dup of https://github.com/golang/go/issues/57621


Terminal: Ctrl + L doesn't clear terminal

As per the title the normal ctrl + L shortcut to clear the terminal doesn't work in onivim2.
(os: macos catalina 10.15.4
tested on bash and fish terminals)

dupe of #1636


Consistent rendering of ValidationErrors across all StreamField blocks

Part of #7250
Incorporates #10108; fixes #5663 and #7997
This PR drops the telepath serialisation mechanism from our *BlockValidationError subclasses, in favour of a standardised JSON serialisation (performed by wagtail.blocks.base.get_error_json_data, delegating to the exception's as_json_data method where available) consisting of a dict with one or both of the keys:

messages - a list of error messages to be rendered on the block as a whole (otherwise known as non-block errors within the *BlockValidationError classes)
blockErrors - some structure, specific to the corresponding block type, that contains error objects (also following this structure) to be propagated to the child blocks

This standardised format means that it's no longer necessary for validation errors triggered on ListBlock / StreamBlock / StructBlock / TypedTableBlock to match their respective *BlockValidationError classes - a plain ValidationError is sufficient to set an error against the block as a whole.
The following setup can be used to test against Bakerydemo, based on the one in #10108 - add to bakerydemo/base/blocks.py:
from wagtail.blocks import PageChooserBlock, URLBlock
from wagtail.contrib.typed_table_block.blocks import TypedTableBlock
from django.forms.utils import ValidationError

class LinkBlock(StructBlock):
    page = PageChooserBlock(required=False)
    url = URLBlock(required=False)

    def clean(self, value):
        result = super().clean(value)
        if not(result['page'] or result['url']):
            raise ValidationError("Either page or URL must be specified")
        return result

class MyTableBlock(TypedTableBlock):
    text = CharBlock()
    url = URLBlock()

    def clean(self, value):
        result = super().clean(value)
        if len(result.row_data) > 3:
            raise ValidationError("The maximum number of rows is 3.")

class BaseStreamBlock(StreamBlock):
    # ...
    link = LinkBlock()
    table = MyTableBlock()

Have now confirmed that this fixes #7997 - previously the lack of support for non-block errors on TypedTableBlock caused this issue.


Botoanalytics not working

Tried Alexa Sample, in the logs it says 2021-03-21T06:13:51.093Z 679e619f-4aa4-4de0-9b71-d551b6bed753 INFO [Botanalytics] Successfully logged incoming message.
But on the Botoanalytics website, there is no data coming up.
Logs show that data is being sent
INFO [Botanalytics] Logging enabled.
INFO [Botanalytics] Configuration: { baseUrl: 'https://api.botanalytics.co/v1/', debug: true }
INFO [Botanalytics] Successfully logged incoming message.

We are working on a completely new version of Node SDK. Closing this.


Turd-O-Meter not visible when using Windows High Contrast Mode / forced-colors

The Turd-O-Meter, which measures the degree of HTML De-crapification*, is visually separated from the background by a contrasting background color. This works fine under default conditions, but isn't visible in Windows High Contrast Mode / forced-colors. Adding a 1px transparent border to the meter element will make it visible in forced-colors mode and won't affect the default presentation.
 I mean, literally.


App: create default config file in launch script

Brought up in https://github.com/Zarel/Pokemon-Showdown/pull/3536#issuecomment-308049780. I don't think it'd be feasible to install the dependencies and import newly recreated config files from app.js because of how much  of a hassle that caused with the launch script trying to accomplish the same thing.

Changed this back to throwing errors instead of making the process exit, moved creating the default config file to the launch script

Still waiting for @xfix

Changed the errno to 128  + 69

Why 128?

See https://nodejs.org/api/process.html#process_exit_codes

Maybe just use code 1 and call it a day.

Changed the errno to 1

Added back the fs require to the top of the module


♻ Extract shared code

New attempt to extract common files into shared package, plus e2e test for inference package (#165) to check it actually works.
Background:

Inference package includes .ts source code and references it in types of package.json
This is because compiled *.d.ts file loses proper doc strings
However, when such package is installed in a node TS project, .ts code imports outside of inference package scope result in error (#164)

Approach:

Put common code in private "shared" package in the workspace
Reference it as dev dependency in other packages using workspace protocol
Have it listed in bundledDependencies in package.json so the shared .ts source code is included

Note: in GH action had to update pnpm to v8 because v7 doesn't honor bundledDependencies when installing from a local folder. Can change this to pnpm pack + pnpm install from tgz.

Thanks a lot @vvmnnnkv , it's really neat and lets us use our own internal packages but also external packages like type-fest.
Can you upgrade all pnpm lock files to pnpm 8 too, as well as in the CI file, and change @huggingface/hub's source code to use the shared package?


Contractions

https://www.enchantedlearning.com/grammar/contractions/list.shtml

Rebasing this in #30 after landing #29 seems to have fixed the build issue. I'm going to close this version, and take the rebased version (you still get authorship credit for the patch you wrote when it comes in through that PR).


ZITADEL Quotas and Log Stores: Standardize the way of writing and running unit and integration tests.

As a developer, I want to have an easy way to run unit and integration tests, so that I can easily maintain them.
Acceptance Criteria

[ ] An example unit and integration test is easily runnable locally.
[ ] Changes are just merged to main, if all unit and integration tests succeed.
[ ] The CONTRIBUTING.md states the relevant Ready for review expectations:

Unit tests ensure that non-trivial functions map certain inputs to expected outputs.
Integration tests ensure that access logs are stored correctly.
Integration tests ensure that execution logs are stored correctly.

We don't store logs anymore


Review Process

This should not be a really feature request, but only an inspiration.
Problem
I would use InvenTree in a different usecase, so not for inventory management, but only as part database in combination with KiCad. So the idea is to store every part with a symbol (only the name of the symbol, not the definition it self) and a footprint in the database. When drawing in Kicad it can be accessed the database and when selecting a part, the assigned symbol can be placed in the schematic.
I would prefer to have a review process when creating a new part. So the idea is to modify the database locally and then adding it to a version control system. Then it can be reviewed normaly as normal source code.
Two problems there exist then:

The database must be lokally on computer
A diff of a database has to be made (InvenTree has nothing to do with it)

So my idea would be creating a standalone application of InvenTree where the folder of the database can be choosen. I did already some investigation and it looks not that easy to create a standalone application because a webserver, python and so on must be packed into the application.
Maybe you have other proposals to manage this problem?

@Martin2278 have you looked into Ki-n-tree?

@Martin2278 have you looked into Ki-n-tree?


chowning certificates in startup.sh during BATS tests break CI environements

Hey :)
First, thanks for taking the time to design that image! It's very practical and complete.
We've been trying to automate build of our own images based on this one in Bamboo,
but stumbled on a problem: upon running the tests, and as a result launching
the docker image, startup.sh chowns a bunch of stuff in /container including the certificates directly to openldap user.
When tests are ran from a CI environment, this results in a bunch of files in host filesystems to be chowned to openldap's in-container user, rendering them unable to be subsequently removed by the CI system.
I can see a few ways to solve that problem, but i'm not sure which one is the most appropriate:

chmod 644 the certificates at startup rather than 600+chown, and set the host directory 600, effectively making the in-container files 644 without giving access to them on host.
copy the certificate files on startup rather than affecting the mapped files directly
perform BATS magic to circumvent the problem when running tests, such as ro'ing the files when mapping them to docker

I can propose a PR if you'd be so kind as to give some input on which method you consider best.
Regards, fir4

Hello,
As i remember Openldap is pretty strict on certificate file permissions and required 600 for the key ?
Methods 2 or 3 seems ok :)
Method 2 can be done by adding --copy-service to the run command.
In test_helper.bash:
docker run $@ -d $IMAGE_NAME

becomes
docker run $@ -d $IMAGE_NAME --copy-service

on container start /container/service directory and subdirectories will be copied to /container/run/service and these files will be used in startup script. More info: https://github.com/osixia/docker-light-baseimage/
I did something similar to method 3 in our mariadb image:
https://github.com/osixia/docker-mariadb/blob/stable/test/test.bats#L49-L50
No sure wich method is better, i let you test and choose the one that fits your needs.
Pull requests are welcomed :)

Ugh, i tried both, it just doesn't work with read-only filesystems even with chown --quiet, i'm not sure why exactly... As for --copy-service, it works perfect, but it doesn't actually help much since there's the same problem for config/ and database/, which don't benefit from it.
A complete fix would probably require a full test-mode to be implemented in startup.sh to copy database/config data aswell and prevent them from being affected by modifications. I also noticed that current BATS tests will leave orphaned docker containers every time a test fails, due to the fact it stops at first error.
Might just end up dropping the tests from the pipeline instead, 95% of the problems i've been having are with the test system itself rather than the image.... I'll check back on this tomorrow :|...

For the existing database test something like this should do the trick:
docker run -v $PWD/database:/tmp/database -v $PWD/config:/tmp/config osixia/openldap:1.1.7 --cmd "cp -rf /tmp/database /var/lib/ldap" --cmd "cp -rf /tmp/config /etc/ldap/slapd.d" --copy-service

I'll check if it's possible to add an option to clean orphaned docker containers when a test fails.
But sometimes it's useful to keep containers to check logs and debug.

Opened PR, here's what i did overall:

Use --copy-service to copy certificates and use ../run/..
Add test.sh in image to copy data from /container/test/ to correct places
Make test.sh be called explicitly by BATS when launching the image
Hopefully this makes everything covered by current tests be copied over, and prevents test data files on host from being modified, chowned or chmodded by the container.
Once this is done, running BATS in a CI pipeline seems to work just fine, no more lingering permission issues! :+1:


HDDS-4530. Add authorization check for SCM

What changes were proposed in this pull request?
Add authorization check about stopReplicationManager, forceExitSafeMode, startReplicationManager, deactivatePipeline, closePipeline in SCMClientProtocolServer .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4530
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Add unit test.

@wycccccc Can you please check if this integration test failure is related to this change?
Error:  Failures:
Error:    TestDecommissionAndMaintenance.testContainerIsReplicatedWhenAllNodesGotoMaintenance:394 expected:<5> but was:<6>
[INFO]
Error:  Tests run: 213, Failures: 1, Errors: 0, Skipped: 15

@vivekratnavel I passed this test, no failure like this.So I think the failure is not related to this change.

I passed this test, no failure like this.So I think the failure is not related to this change.

We prefer to commit only green builds.  If it's an intermittent test, there are two options:

Add an empty commit and have a green build
Disable the test with a simple commit on master and create a JIRA with the log which proves the intermittency.

Let me re-trigger this build...

I passed this test, no failure like this.So I think the failure is not related to this change.

We prefer to commit only green builds.  If it's an intermittent test, there are two options:

Add an empty commit and have a green build
Disable the test with a simple commit on master and create a JIRA with the log which proves the intermittency.

Let me re-trigger this build...

Thax @elek review, I will try to create a jira to solve it.

Thax @elek review, I will try to create a jira to solve it.


ARROW-11973 [Rust][DataFusion] Boolean kleene kernels

This PR adds two boolean kernels kleene_or and kleene_and.
As described in the corresponding JIRA ticket, the kleene operator handels null values differently compared to plain OR and AND operators.

Operator
Left
Right
Result

AND
TRUE
NULL
NULL

AND
FALSE
NULL
FALSE

OR
TRUE
NULL
TRUE

OR
FALSE
NULL
NULL

@ch-sc thanks for your PR
In the JIRA ticket it is mentioned that these semantics are default for SQL - however - these return NULL in PostgreSQL (the dialect we want to target for DataFusion.
SELECT TRUE AND NULL;
SELECT TRUE OR NULL;

Hi @Dandandan, I actaully checked on Postgres (11) beforehand and it did return exactly the values I provided in the table.
SELECT TRUE AND NULL; --> NULL
SELECT FALSE AND NULL; --> FALSE
SELECT TRUE OR NULL; --> TRUE
SELECT FALSE OR NULL; --> NULL

Which Postgres version are you using?

I tried on mysql, postgres and big query and was happy with the table you provided on JIRA. I am also curious how I got a different result than @Dandandan  xD

Haha @ch-sc  @javierluraschi I tried it on this website which I used before https://rextester.com/l/postgresql_online_compiler
but it shows null on every input now 🤣
So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1:

Codecov Report

Merging #9772 (d024f2b) into master (29feea0) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9772      +/-   ##
==========================================
- Coverage   82.59%   82.36%   -0.24%
==========================================
  Files         248      252       +4
  Lines       58294    58893     +599
==========================================
+ Hits        48149    48507     +358
- Misses      10145    10386     +241

Impacted Files
Coverage Δ

rust/arrow/src/array/transform/fixed_binary.rs
5.26% <0.00%> (-73.69%)
:arrow_down:

rust/arrow/src/array/transform/null.rs
0.00% <0.00%> (-66.67%)
:arrow_down:

rust/arrow/src/array/transform/structure.rs
44.44% <0.00%> (-38.89%)
:arrow_down:

rust/arrow/src/array/transform/primitive.rs
71.42% <0.00%> (-28.58%)
:arrow_down:

rust/arrow/src/array/transform/mod.rs
70.23% <0.00%> (-22.96%)
:arrow_down:

rust/arrow/src/array/transform/variable_size.rs
87.87% <0.00%> (-12.13%)
:arrow_down:

rust/arrow/src/array/array_binary.rs
79.84% <0.00%> (-11.80%)
:arrow_down:

rust/parquet/src/arrow/schema.rs
86.57% <0.00%> (-5.79%)
:arrow_down:

rust/arrow/src/buffer/mutable.rs
87.73% <0.00%> (-3.04%)
:arrow_down:

rust/arrow/src/array/array_union.rs
87.17% <0.00%> (-2.37%)
:arrow_down:

... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a9f5d...d024f2b. Read the comment docs.

@Dandandan @jorgecarleitao the integration tests fail because of scarce disk space:
+ npm install
##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 57 MB
npm WARN tar ENOSPC: no space left on device, write

Any ideas what we can do about this?

For the record the issue of the integration test running out of space is known and not related to this PR


Autoformat build! macros with PowerShell script

Closes #827
We convert the build! (and generate!) macro calls to use curly braces, so that we can then replace the call with a use something::{ that allows rustfmt to perform all its formatting tricks like it normally would to use trees, to clean up the blocks and make them look more like the use blocks in main.rs.
This is wrapped up in a PowerShell script and pipes the replaced result through rustfmt to not modify and/or leave garbled files on disk. The script is ran in the CI to enforce proper formatting at all times; contributors are encouraged to run the script themselves if formatting differs.

Now we have an example of a failed CI run at https://github.com/microsoft/windows-rs/actions/runs/887995007, including the ::error:: annotation:

Follow the CI link to see the full diff output.

Sweet - will take a look soon!

I had a quick look and not knowing anything about PowerShell am a little concerned about what this actually does and how. It would also be great if I could run it locally to observe its behavior, but when I run it I get errors.
C:\git\windows-format>powershell scripts\Format-Build-Macro.ps1
Get-Content : Cannot find path 'C:\git\windows-format\build.rs' because it does not exist.
At C:\git\windows-format\scripts\Format-Build-Macro.ps1:15 char:18
+   $fmtResult = ((Get-Content -Raw $File).replace($Pattern, $shim) | & ...
+                  ~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\git\windows-format\build.rs:String) [Get-Content], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetContentCommand

You cannot call a method on a null-valued expression.
At C:\git\windows-format\scripts\Format-Build-Macro.ps1:15 char:3
+   $fmtResult = ((Get-Content -Raw $File).replace($Pattern, $shim) | & ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    + FullyQualifiedErrorId : InvokeMethodOnNull

Another option is to write a Rust command to perform this operation. I think that would ultimately be a better choice anyway e.g. cargo windows-fmt. I'd prefer to keep everything in Rust if at all possible. Then we don't have to worry about making sure some other toolchain/scripting environment is present/enabled or have general expertise in other languages. I imagine a Rust tool could pretty easily do this reformatting with the help of the syn crate or just regex. 😊 Anyway, that's something I might explore when I get a moment. It's worth a try.

I had a quick look and not knowing anything about PowerShell am a little concerned about what this actually does and how.

That is unfortunate, I had assumed PowerShell to be the go-to scripting language for Microsoft projects, like how win32metadata exists almost exclusively of PS scripts (and some C#). Would it help if I document it with some comments?

It would also be great if I could run it locally to observe its behavior, but when I run it I get errors.

Definitely! It runs fine on the CI under Windows and has me curious what's going on on your system.

C:\git\windows-format>powershell scripts\Format-Build-Macro.ps1
Get-Content : Cannot find path 'C:\git\windows-format\build.rs' because it does not exist.
...

This makes zero sense. Get-ChildItem (gci) managed to find a build.rs file that doesn't actually exist, there's no build.rs in the root. Can you run gci -r -fi build.rs in PowerShell in this tree and report what it managed to find? Alternatively I can push some extra logging here.

Another option is to write a Rust command to perform this operation. I think that would ultimately be a better choice anyway e.g. cargo windows-fmt.

I'm not a fan of binaries that have to be installed first, but it seems the xtask "trick" perfectly suits this need. It works beautifully in other projects like rust-analyzer.

I'd prefer to keep everything in Rust if at all possible. Then we don't have to worry about making sure some other toolchain/scripting environment is present/enabled or have general expertise in other languages. I imagine a Rust tool could pretty easily do this reformatting with the help of the syn crate or just regex.  Anyway, that's something I might explore when I get a moment. It's worth a try.

The syn crate would have worked perfectly to solve the lost bracketing issue when the macro consists of a single top-level namespace. However, there is no way to maintain formatting when replacing the substituted use XXX::{} back to the original macro - that's after all what windows-rs currently calls rustfmt for on emitted output. A regex works but can be used from PowerShell as well, though it is not necessary with the current implementation.
Let me know if you'd like to debug this script a little or jump to an extra Rust crate immediately.

I'm not a fan of binaries that have to be installed first

It could be something simpler like the the way the "bindings" crate is run. The simplest possible solution (in Rust) would be ideal.

https://github.com/microsoft/windows-rs/pull/828/checks?check_run_id=2766964459 Awesome, the new Rust script is still working exactly as PowerShell :tada:

That's fair; I think most community driven projects (ie. winit and their repos) have something along the lines of authors = ["The Rust Windowing contributors"] :)

And after re-pushing the CI succeeds, as expected. @kennykerr given https://github.com/microsoft/windows-rs/pull/842#issuecomment-856158943, in what steps do you want to land this?

And after re-pushing the CI succeeds, as expected. @kennykerr given #842 (comment), in what steps do you want to land this?

Looks great! It looks like this takes care of it all so I'm happy to just merge this in.

Looks great! It looks like this takes care of it all so I'm happy to just merge this in.

Works for me!


type errors in node env

Hey,
is this example giving you errors in TS 5.5 or am I missing any type declarations?
Replicated in sandbox: typescriptlang.org

TypeScript is lagging behind JavaScript in the implementation of resizable ArrayBuffer. See the PR https://github.com/microsoft/TypeScript/pull/58573#issuecomment-2254718432 from the comment/reference
https://github.com/guest271314/native-messaging-typescript/blob/cd0d2fc81fd0e7bac88d6f374c67688b7e3d25e9/nm_typescript.ts#L9C27-L9C154
  * /// <reference types="https://raw.githubusercontent.com/microsoft/TypeScript/eeffd209154b122d4b9d0eaca44526a2784073ae/src/lib/es2024.arraybuffer.d.ts" />

The TypeScript playground doesn't recognize the embedded interface. Neither does deno check https://www.reddit.com/r/Deno/comments/1e6hyeh/comment/lffpz70/

You might want to look into the behaviour of deno check. The output is full of errors when we include the declaration in the file, but not yet defined in the TypeScript compiler that checks the file. deno executes the file just fine. Download this file https://raw.githubusercontent.com/guest271314/NativeMessagingHosts/main/nm_typescript.ts and run deno check locally. First error

error: TS2740 [ERROR]: Type 'ArrayBuffer' is missing the following properties from type 'ArrayBuffer': maxByteLength, resizable, resize, detached, and 2 more.
const buffer: ArrayBuffer = new ArrayBuffer(0, { maxByteLength: 1024 ** 2 });

The Deno folks banned me so I can't file an issue over there in denoland for check failing to recognize the embedded interface. From what I gather Deno uses a tsc that doesn't stay up to date with the JavaScript implementation in Deno. The same must be true for Bun and Node.js.
The code runs in deno, bun, and node, anyway.
The .js source does not produce any errors for deno check, as well as deno lint, after I fixed what those commands output.
So it's an internal TypeScript issue, that is observable in TypeScript and downstream for programs that use "stable" TypeScript.

I see.
Which minimum node version does it run in?
Got any unit tests or plan on setting them up?

I'm running v23.0.0-nightly202407272d1b4a8cf7.
I've got a test I've been running that I included the TypeScript version in https://gist.github.com/guest271314/7d2118bd395bf1e3475b70b0187910f2.
node is slower than deno, which is slower than bun running the same .ts file.
From a few seconds ago
0	'nm_qjs'	0.1102999999821186
1	'nm_tjs'	0.15969999998807907
2	'nm_bun'	0.2365
3	'nm_deno'	0.2684000000059605
4	'nm_typescript'	0.31259999999403953
5	'nm_nodejs'	0.36440000000596046
6	'nm_spidermonkey'	0.39559999999403955
7	'nm_d8'	0.4537000000178814

How are you testing those?
Got a script you can share?

In DevTools Sources => Snippets in my custom new tab extension. For each host manifest I include the extension URL of my new tab extension.
test_stdin.js
var runtimes = new Map([
  ["nm_nodejs", 0],
  ["nm_deno", 0],
  ["nm_bun", 0],
  ["nm_tjs", 0],
  ["nm_qjs", 0],
  ["nm_spidermonkey", 0],
  ["nm_d8", 0],
  ["nm_typescript", 0]
]);
for (const [runtime] of runtimes) {
  try {
    const {
      resolve,
      reject,
      promise
    } = Promise.withResolvers();
    const now = performance.now();
    const port = chrome.runtime.connectNative(runtime);
    port.onMessage.addListener((message) => {
      runtimes.set(runtime, (performance.now() - now) / 1000);
      port.disconnect();
      resolve();
    });
    port.onDisconnect.addListener(() => reject(chrome.runtime.lastError));
    port.postMessage(new Array(209715));
    if (runtime === "nm_spidermonkey") {
      port.postMessage("\r\n\r\n");
    }
    await promise;
  } catch (e) {
    console.log(e, runtime);
    continue;
  }
}
var sorted = [...runtimes].sort(([, a], [, b]) => a < b ? -1 : a === b ? 0 : 1);
console.table(sorted);

Ok I'm managed to complete a test script myself. This could be used similarly to your extension script code. I'll make a gist out of it once I figure out how I want to package it

to replicate how chrome launches these hosts? I haven't figured out how to do it myself.

What do you mean by how Chrome launches the hosts? You can read the arguments to the script in the script. See the args variable here https://github.com/guest271314/NativeMessagingHosts/blob/main/nm_host.js.
If you mean implement the Native Messaging protocol, I've done it. I'll have to go through my archives to locate the code.
Basically just implement the Native Messaging protocol https://developer.chrome.com/docs/extensions/mv3/nativeMessaging/#native-messaging-host-protocol between discrete applications/shell scripts/programs/runtimes.
It's similar to HTTP Transfer-Encoding: chunked. Length of message, followed by message. See https://github.com/guest271314/direct-sockets-http-ws-server/blob/main/assets/script.js#L307-L361.
Other experiments implementing I/O between browser and arbitrary application using files https://github.com/guest271314/fs.

If you mean implement the Native Messaging protocol, I've done it. I'll have to go through my archives to locate the code.

This is what I meant. But I managed to get it working myself. So now I can run integration tests against my host if I want to.
However, this is not relevant to the issue submitted so I'll take this elsewhere.

@salmin89 https://github.com/guest271314/NativeMessagingHosts/discussions


Unable to preview drafts

Hello, not sure if a "bug" per-se, but I do not see how to preview a draft: true post locally (or within, say, a staging environment).
How would you recommend going about this?

You could modify this line to render the post all the time in dev and only in prod if draft !== true


How to load 'child' modules into 'parent' modules from Deep Level Example

I am new to Angular, ui-router and generator-ng-poly and am hoping someone can help with what is likely a simple syntax issue.
I am using geneartor-ng-poly for a new project and working from the "Deep Level Example" with an Angular 1.3 based app using ui-router and HTML.
First I created a "home" module, then a "header" module inside that. So...
yo ng-poly:module home
yo ng-poly:module home/header

Which gives me the two controllers: app/home/home.js and app/home/header/header.js
Now I want to use the "header" from within home.tpl.html and I am struggling with how to do this. From what I understand either

or

should work, but neither is. Hours of Googling has not helped since all the examples use the more common $stateProvider format where there are chained states.
How should I be referencing "header" to have it show up properly inside home.tpl.html?

Hey Kaned. This isn't how states should be treated, in my opinion. States should describe the application's current state. Sounds like you're actually just wanting to import a header template into your home view. If that's the case, I'd encourage looking into directives. Directives can have templates. From there, just use the directive you made inside the home view.

Thanks Dustin, I'll check them out.
Kane

On Mar 3, 2015, at 3:52 PM, Dustin Specker<EMAIL_ADDRESS>wrote:
Hey Kaned. This isn't how states should be treated, in my opinion. States should describe the application's current state. Sounds like you're actually just wanting to import a header template into your home view. If that's the case, I'd encourage looking into directives. Directives can have templates. From there, just use the directive you made inside the home view.
—
Reply to this email directly or view it on GitHub https://github.com/dustinspecker/generator-ng-poly/issues/118#issuecomment-77065616.

Dustin set me right on this. That I should be looking at directives instead of modules and that worked right away. Thanks Dustin!


🚀 [Feature] Change newsletter message when sign in and out.

🚀 Feature
When you sign in and out of the newsletter the german success or information message shows a text that is to techy.
ToDos

[ ] Change german text: "Du bist im Newslettersystem eingetraten." to "Du erhältst Informationen per E-Mail."
[ ] Change german text: "Du bist aus Newslettersystem ausgetragen." to "Du erhältst keine Informationen per E-Mail."
[ ] Change english text: "You are subscribed to newsletter system." to "You will receive information per e-mail."
[ ] Change english text: "You are unsubscribed from newsletter system." to "You will not receive any information by e-mail."

@Elweyn Is this merged?


Validation error using ISJSON in stored procedure within database project in Visual Studio 2022

SqlPackage or DacFx Version:  <IP_ADDRESS>
.NET Framework (Windows-only) or .NET Core:  both
Environment (local platform and source/target platforms):

Steps to Reproduce:

Using SSDT, create a table:  CREATE TABLE tbl_json([JsonData] NVARCHAR(MAX))

Using SSDT, create a stored procedure:    CREATE PROCEDURE [dbo].[usp_TestJsonData]
AS
Select ISJSON( JsonData, VALUE ) From tbl_json

The database project will not compile and the SQL error 71501 will be reported
SQL71501: Procedure: [dbo].[usp_TestJsonData] has an unresolved reference to object [dbo].[tbl_json].[VALUE].

The same error is thrown for the values of:  OBJECT, ARRAY, and SCALAR
This issue is similar to that of: Export/extract validation error with ISJSON #375:
https://github.com/microsoft/DacFx/issues/375

NOTE: this works fine in SSMS <IP_ADDRESS>

Did this occur in prior versions?  If not - which version(s) did it work in?   This is newer functionality supported in SQL 2022 and Azure SQL Database, so it did not exist before.
(DacFx/SqlPackage/SSMS/Azure Data Studio)

It appears that this can be closed.  The fix is in SSDT 17.12 Preview 4 per ssreerama.


Add a window hint for setting app_id on wayland

Simple change to support setting app_id on wayland windows, closes #2121 .

@TheBrokenRail When would that be preferable over this window hint string?

Mainly so that you don't have to set the hint string. Right now on X11, everything just works by default because the WM_CLASS default is the window title. Of course, you can change this if you want to, but the default behavior makes things really simple: just set StartupWMClass to the window's title in your .desktop files and everything's good to go.
On Wayland, app_id isn't set at all right now, so you can't assign it to a .desktop file at all (at least on GNOME, StartupWMClass seems to correspond to the app_id on Wayland). And if this PR were merged as is, you'd still have to specify the app_id manually, rather than it defaulting to the window's title like X11.


Add a fixture for UAT that is CH only

The existing companies house entry in the fixture data already has a data hub company associated with it. In order to test the front end an entry is required in the companies house table and index that isn't in the companyh table.

Codecov Report

Merging #636 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #636   +/-   ##
========================================
  Coverage    96.44%   96.44%
========================================
  Files          129      129
  Lines         3878     3878
  Branches       334      334
========================================
  Hits          3740     3740
  Misses          97       97
  Partials        41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfb58f...4365bd3. Read the comment docs.


Register custom factories

Enhancement - Having the ability to register custom factories.
In our code base, we have common factories that are used a lot across the project.
And we want one place to register these factories instead of assigning them manually as factory property.
For example:
  class NestedModel(pydantic.BaseModel):
      a: str

  class ParentModel(pydantic.BaseModel):
      nested: NestedModel

  class NestedModelFactory(ModelFactory):
       a = "const value"
       __model__ = NestedModel

  parent_model_factory = create_factory(ParentModel)
  #  parent model factory should use the NestedModelFactory.
  parent_model_factory.nested.a == "const value"

Suggested usage:
Option 1 - Overriding get_provider_map class method
@classmethod
    def get_provider_map(cls):
        provider_map = cls.super()
        provider_map.update(AModel: CustomAModelFactory)
        return provider_map

Option 2 - add a class method to register factories
For example:
@classmethod
    def register_factory(factory):
        pass

Option 3 - creating a factory will automatically register it.
 class AModelFactory(ModelFactory):
      a = "const value"
     __ model__ =  AModel
     __auto_register__ = True

or
create_factory(AModel, auto_register=True, a="const value")
This can be implemented by customizing the metaclass of ModelFactory.

Hi, can't you simple create a subclass of model factory with this field defined?

I can, but I want to globally register a factory the same way as providers.
Imagine that I have ModelA, which is used as a field in 50 Pydantic Models.
Now I want to create a custom Factory for ModelA.
For that, I need to go over the Pydantic model factories and define this field.
Instead, we can have the same mechanism that providers give us today but extend it for custom Pydantic factories.

ok, I now understand. I have no issue with this. If you would like to add a PR - @jtraub and myself will gladly review it.

@jtraub @Goldziher, I will add a PR.
Which option do you prefer from the above-listed options?

This has been implemented in #125 and #131.


Added footer

Pull Request Type
What kind of change does this PR introduce?
[x] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
There was no footer so I added footer with paragraph.
Issue Number:
What is the new behavior?
HTML page has footer now
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


remove eval dataset contamination

Consider removal of eval dataset contamination.
We would like to make sure that any downstream eval data is not memorized by the model by being in the sampled OSCAR files.
We would want to remove at a minimum exact matches, after lowercasing and strip special chars. We can create a hash of each line of data or even a minhash. Then when we process OSCAR, we will filter those data out. Datasets we will wish to address:
arc_challenge, arc_easy, boolq, copa, headqa, hellaswag, lambada, logiqa, mathqa, mc_taco, mrpc, multirc, openbookqa, piqa, prost, pubmedqa, qnli, qqp, race, rte, sciq,sst, triviaqa, webqs, wic, winogrande, wnli, wsc, wikitext

duplicate


witch python version to use

Please, can you indicate which version of Python you are using? Most libraries cannot be installed on 3.11 , 3.9 and 3.7 or less

i used python 3.9.2 . You can find in articles from previous post the virtualenv installation instructions.
doing copy/paste:
apt install python3-virtualenv
virtualenv passganenv
cd passganenv
source bin/activate
git clone https://github.com/beta6/PassGAN
pip install --upgrade pip
pip install -r PassGAN/requirements.txt
cd PassGAN

if you find more problems, let me know and i will try to help you


[Suggestion] Enchantments for the Gohei

Minecraft Version

[X] 1.12.2 (End of support)
[X] 1.16.5
[X] 1.18.2
[X] 1.19.2
[X] 1.20/1.20.1

What happened?
The Gohei should be compatible with some custom enchantments such as:

Impeding Bullets I-IV: Bullets now inflict slowness I - IV on the enemy.
Speedy Bullets I-II: Bullets travel x2 regular speed at lv I and x3 at lv II, please note that the vanishing time for the bullets will also need to be changed to prevent bullets from keep traveling unto unloaded chunks.
Keen Hands: Increasing Gohei's DPS aka the maid will be able to fire the bullets at double the speed, waiting only half the cooldown before they fire another round.
Spread Bullets I-IV: When firing a singular bullet against a lone enemy, maids will get a bonus bullet, at level IV that would be 5. Please note that this enchantment only make sure that the maid fire multiple bullets instead of one, not actually add in any extra bullets when spread firing.
Enders Ender: Bullets can actually hit Enderman and damage them without cause them to teleport away.
Unbreaking and Mending - this has already been implemented.

I tried to make these enchantments to be as loyal to the Touhou's mechanic as possible, instead of having these as enchantments, you can make it so maids can learn these as their favor goes up instead, such as the Keen Hands enchant is more dependent on the maid's skill instead of a good Gohei, it's up to you to decide.
Relevant log output
If possible make this compat with Enchantment descriptions https://www.curseforge.com/minecraft/mc-mods/enchantment-descriptions
Contact Details
No response

Great idea, I have implemented it
Two enchantments from the vanilla are reused.

Outstanding tbh :)) I don't think you will add in all of these enchantments since with all of these upgrades, the staff will turn into a literal machine gun.


Limit shadow range for global tile trees.

When shadows are enabled we ask each shadow-casting tile tree to disclose the volume of space containing shadow-casting geometry. For global tilesets like the OpenStreetMap buildings, that volume is the size of the Earth, making the shadow map useless. In such cases, limit the shadow-casting range to the viewed volume.
Unless you're zoomed very far in and/or looking mostly top-down, the resolution of the shadow map is still pretty lousy, but at least it produces recognizable shadows.

Queued ImageTests run.

No image differences reported. Force-merge because flaky tests.