bug: activate_version deletes rows inserted in earlier batches (and deletes despite hard_delete not being set)

Singer SDK Version
0.30.0
Is this a regression?

[ ] Yes

Python Version
3.9
Bug scope
Targets (data type handling, batching, SQL object generation, etc.)
Operating System
Linux
Description
I was attempting to transition to using meltanolabs-target-snowflake (version 0.5.1) from the pipelinewise variant.
When I run EL from a tap_mysql (pipelinewise-tap-mysql) to this target on a table that has 21k rows, I find that after EL completes the destination table only has 1k rows instead.  From some investigation it appears that this code snippet is the problem: https://github.com/meltano/sdk/blob/299acc046990db9b2e3d68a9bb8a72eb73511857/singer_sdk/sinks/sql.py#L381-L389
I see two problems here:

This seems to be defaulting to hard_delete being enabled, which is not the documented default
This is deleting rows with the current version, should this be < instead of <=? That would seem to agree with the soft delete logic below this.

Proposed patch might look like
        if self.config.get("hard_delete", False):
            with self.connector._connect() as conn, conn.begin():  # noqa: SLF001
                conn.execute(
                    sqlalchemy.text(
                        f"DELETE FROM {self.full_table_name} "  # noqa: S608
                        f"WHERE {self.version_column_name} < {new_version}",
                    ),
                )
            return

Loader config
    - name: target-snowflake
      variant: meltano
      config:
        account: ${TARGET_SNOWFLAKE_ACCOUNT}
        user: ${TARGET_SNOWFLAKE_USER}
        password: ${TARGET_SNOWFLAKE_PASSWORD}
        database: MY_DATABASE
        default_target_schema: MY_SCEHMA
        warehouse: MY_WAREHOUSE
        add_record_metadata: true

Code
No response

One thing I was unsure of is if it's expected for activate_version to be called multiple times during EL. Is there a chance the tap is the one misbehaving? (although the default still would be wrong in that case)

Hi @msg555!
Thanks for logging and for the detail investigation into the issue. This does seem like a significant problem that could lead to unexpected data loss.

This is deleting rows with the current version, should this be < instead of <=? That would seem to agree with the soft delete logic below this.

Yeah, I think that's right.

This seems to be defaulting to hard_delete being enabled, which is not the documented default

Trying to think what users would experience by changing the default to not hard delete. Would they just start seeing that data is now upserted/soft-deleted instead of removed and would that cause issues to downstream data modeling? I still think we should apply your suggested patch but we should call out this change in the release notes of both the SDK and downstream targets.

One thing I was unsure of is if it's expected for activate_version to be called multiple times during EL. Is there a chance the tap is the one misbehaving? (although the default still would be wrong in that case)

I think there would be at most one activate_version message for each stream in the tap, but I could be wrong. What's the tap in question?
cc @pnadolny13 Curious if you've seen this problem come up with target-snowflake. And fwiw target-postgres seems to do the right thing.

Ah, apologies if I've identified the wrong repository. Perhaps the code you linked that's directly in target-snowflake is what is relevant in my case; it still seems to use the <= rather than < operator. Perhaps I should create a new issue over there.

Ah, apologies if I've identified the wrong repository. Perhaps the code you linked that's directly in target-snowflake is what is relevant in my case; it still seems to use the <= rather than < operator. Perhaps I should create a new issue over there.

The activate_version method is not re-implemented by target-snowflake so this still seems like the right place to look at the issue, imo.

The tap is pipelinewise-tap-mysql==1.5.6

Thanks! The tap does seem to emit a single message per stream: https://github.com/transferwise/pipelinewise-tap-mysql/blob/572e08a3576702895e2a9edae188773ec9d7a096/tap_mysql/sync_strategies/full_table.py#L137-L138

On a second thought, an issue and PR are probably needed for target-snowflake since failing tests are blocking bumping the SDK: https://github.com/MeltanoLabs/target-snowflake/pull/105

@edgarrmondragon I havent noticed to me honest. I dont use activate version for anything really.
I agree though that seeing hard_delete defaulting to true seems weird. I also dont think hard_delete is registered as a default config because the hub/--about isnt listing it.
In terms of breaking changes I also agree that its better to break someone by getting them back to the behavior they expect vs leaving the bug.


Sink type refactoring

This commit is motivated by the fact that the linkMerge and pickValue fields were repeated in the Sink and WorkflowOutputParameter types.
To remove this repetition, these two fields have been isolated in a new type called Sink. The previous Sink type, which is now named InputSink extends Sink with the source field, while a new OutputSink type extends Sink with the outputSource field.
The WorkflowInputParameter type extends the InputSink, while the WorkflowOutputParameter type inherits from OutputSink. Note that this separation will be useful also for future extensions. For example, the proposed loop feature will build upon the OutputSink type to map the step outputs into the inputs of the next iteration.

Object model before:

Object model after:


Jade: Release Check List

This ticket is used to collect things that need to be done for the upcoming Jade release.
Existing Task Sets:

[ ] Jade kickoff list #6435
[x] Jade documentation audit #6878
[ ] Jade community documentation audit #8284

Documentation:

Update verbiage on these wiki pages, e.g. 'upcoming release' vs. 'current release':

[x] http://wiki.ros.org/jade/Installation

[x] http://wiki.ros.org/jade

Check the state of links:

[x] http://wiki.ros.org/jade/Installation/UbuntuARM (http://www.ros.org/debbuild/armhf/jade.html)

[x] Turtlesim icon @wjwwood

[x] k-turtle name @esteve

[ ] rosbuild tickets @wjwwood

[x] indigo-jade debbuild comparison page @dirk-thomas

Checklist from internal Google Drive doc:
ROS Wiki

[x] make distroN the default distro

https://github.com/ros-infrastructure/roswiki/blob/master/custom/js/rosversion.js#L40 (https://github.com/ros-infrastructure/roswiki/commit/cea8bc5b704ba54a0ab0421b58909249ccfbbc5a)

[x] Version macro for distroN needs to be updated from “Expected in distroN” to “distroN” (https://github.com/ros-infrastructure/roswiki/commit/44b62e47d188487952ccd65775bac24305500eec)
[x] Update symlink for default API doc:

/home/rosbot/docs/api → /home/rosbot/docs/distroN/api

[x] Update http://wiki.ros.org/Distributions
[x] Update http://wiki.ros.org/ROS/Installation to point to distroN

ROS browse

[x] update default distro:
https://github.com/ros-infrastructure/rosbrowse/commit/55dbea7565ccad7159f531de3ed9cd2ed4ec540e

Communication

[ ] Announcement email pointing to migration guide
Post to ros-users
Post to blog
Post to G+
Post to Twitter

www.ros.org

[ ] Update www.ros.org bottom row widget to point to new release with logo
[ ] Update www.ros.org/install to point to new release with logo

Referencing #6435 and #6878.

[x] update REP 142 to move tutorials to desktop metapackage: ros-infrastructure/rep#100
[ ] update REP 142 to include geneus for Jade
[ ] release metapackages

@dirk-thomas @tfoote @esteve I'm going to start working on these. I might delegate some tasks. Let me know if you don't have time to do it.

@dirk-thomas can you tell me how to do the "Update symlink for default API doc" item or do it for me?

K-turtle will be named Kinetic Kame.

@esteve it's supposed to be a secret :stuck_out_tongue:.

@wjwwood I created a visualization of the Jade development cycle up to today: https://www.youtube.com/watch?v=-Bpaz94krAo  We've had 40 committers and over 500 packages.

Thanks, I'll include that in my draft email (I'll send it around to you guys tonight and send it tomorrow).

@wjwwood  api is imply a symbolic link to indigo/api. I updated it.

@wjwwood api is simply a symbolic link to indigo/api. I updated it.

I wasn't sure which server it was on, thanks.

How do I do the www.ros.org updates?

I would suggest to put both releases on the install page (http://www.ros.org/install/):

Indigo (LTS)
Jade (latest release)

I agree, I've been sort of showcasing them both in each place I can.

I still need to know how to update www.ros.org, has someone done that before? Is that on the internal wiki (I can't seem to access it from here)?

@wjwwood I emailed you pointers to the credentials

@tfoote I didn't get an email like that, did you send it to my work account?

Yeah, I've resent it with the subject "ros.org credentials"

Ok, I got the www.ros.org updates.


Compiler optimization issue (/Od)

Hello.
First of all, thanks for creating this library it's really helpful.
Library works great with /O2 compiler flag (thats default option for a new project), but problem comes with /Od flag and /Ob1.

As you can see everything is fine, except fact that our original integer is shown and not even used. This issue persist in any variable type. This library works great with those flags, thing is that library supports only strings.
Thanks.

Thanks for your reporting,
Optimization must be enabled, and this problem may be due to some parameter passing


Add SMARTY_LICENSE_TYPE variable to Terraform and GitHub secrets

Resolves https://github.com/CDCgov/phdi/issues/329

Finally got a successful run!!


Hand-written thank you cards for speakers

21 total, see speaker page for a list of names
http://citycampnc.org/speakers/
We should get 25 to have a few extras

Note cards have been purchased


Steam's "Steam Play" feature does not work on NixOS

Issue description
For background info, Steam Play is Valve's new compatibility layer that allows you to run any Windows-only game as long as you have Steam installed. Here is the announcement.
The feature partially works on NixOS. It allows you run a Windows game for about a minute but it eventually crashes with error eventfd: Too many open files. This issue is documented here and is ultimately because the linux kernel is not configured to support enough file descriptors. Running ulimit -Hn, I get a result of 4096 file descriptors per process.
This is not the first time this issue has caused problems for NixOS. See https://github.com/NixOS/nix/issues/875 and https://github.com/NixOS/nixpkgs/issues/22454. For modules, I see here that it is possible to increase the limit. Is this possible to do so on a per-package basis (for steam)? Or should this limit be increased globally for the entire distro?
Steps to reproduce

Install steam
Try to run a windows-only game via Steam Play

Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
[owner@Taha-Desktop-Linux:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.63, NixOS, 18.09pre149415.8395f9aa85e (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.0.4`
 - channels(owner): `"nixos-18.09pre145524.2a8a5533d18, stable-18.03.132845.5e10df3982d"`
 - channels(root): `"nixos-18.09pre149415.8395f9aa85e, stable-18.03.133017.0e55dde2eaa"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I played Sonic Mania for a while (probs 40 minutes) and didn't hit this problem. Is it only certain games?

According to this document, "esync creates one eventfd descriptor for each synchronization object". Honestly, I don't fully understand what a "synchronization object" is but it appears that some games require more synchronization objects. The game I tested was Quake Live.

Steam uses buildFHSUserEnv which internally creates a user namespace. This namespace will be limited to your user namespace's ulimit, so ultimately the fix is either to raise the ulimit globally in systemd or configure a separate user with a higher ulimit and run steam as that user.

Another option is to disable esync via PROTON_NO_ESYNC=1. You can set this per-game in Steam's launch options (PROTON_NO_ESYNC=1 %command%) or in Steam's environment.

@tgharib Did you package the new version of steam yourself?  The version in the repo seems to be pretty far out of date.

@Wolfereign Steam installs itself to the user's home on first boot (~/.local/share/Steam) so the package version doesn't really matter.
Incidentally, I've found that Steam Play doesn't work at all unless I override with steam.override { nativeOnly = true; }.

@tadfisher Thank you for the info.  I haven't tried to install Steam yet but that cleared up alot of confusion that I had.  My apologies for derailing the thread a bit.

Incidentally, I've found that Steam Play doesn't work at all unless I override with steam.override { nativeOnly = true; }.

@tadfisher what nixos version are you on? I just found out native is marked broken both in master and 18.03. Still, I confirm it works for me and indeed I could play a game with steam play that was not working without the override
@abbradar is it still segfaulting for you?

As for the ulimit issue, this works for me:
# Set limits for esync.
systemd.extraConfig = "DefaultLimitNOFILE=1048576";

security.pam.loginLimits = [{
    domain = "*";
    type = "hard";
    item = "nofile";
    value = "1048576";
}];

I have played some (older) games using Steam play and never had such problems. So it's not a general issue but affect only some games.

I also did not experience issues with Steam Play on NixOS. It's probably a very specific game that crashes without increasing the file handle limit.

I can't remember why I subscribed to this issue a couple years ago, but I've also been using Steam Play on NixOS for quite a while now without this issue.

As I mentioned in #86480, I don't think programs.steam.enable should change file handle limit, if anything because Ubuntu has the same file handle limit as NixOS. If file handle limit causes issues on NixOS, it will also cause them on Ubuntu (which is officially supported by Valve).

Great, looks like this issue is resolved :tada:


infer ajax from data_source if no ajax specified

In relationship field, if you define data_source but don't define ajax => true, field would not be an ajax field ignoring data_source definition.
When developer define data_source, ajax should be true if not otherwise specified .
This:

If ajax => true you need data_source ONLY if your name does not match fetchName or not using fetch operation, otherwise you are good to go.

if you specify data_source => smt, even if smt is a fetch url, at the present moment the field would not be ajax unless you specify ajax => true plus data_source.

Like I said, I don't think people define data_source if they don't want an ajax field. It's the only use of it 👍 😺

A new inspection was created.

The inspection completed: No new issues

A new inspection was created.

The inspection completed: No new issues


Some fixes and test cases for handling of missing file

Codecov Report
Base: 67.57% // Head: 67.87% // Increases project coverage by +0.30% :tada:

Coverage data is based on head (7c1d1c3) compared to base (af40b24).
Patch coverage: 58.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   67.57%   67.87%   +0.30%
==========================================
  Files          16       16
  Lines        1764     1765       +1
  Branches      796      798       +2
==========================================
+ Hits         1192     1198       +6
+ Misses        132      125       -7
- Partials      440      442       +2

Impacted Files
Coverage Δ

src/applier.cpp
77.18% <0.00%> (+0.48%)
:arrow_up:

src/patch.cpp
53.61% <50.00%> (+1.59%)
:arrow_up:

src/cmdline.cpp
76.82% <100.00%> (+0.87%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Hotfix/email help desk stuck registrations [#OSF-5848]

Purpose
There is an existing script that is not being run currently to find stuck registrations, delete them, and send an email to both Desk.com and the user telling them there is a problem.
This PR changes this script to only email the help desk so we can deal with stuck registrations on a case by case basis, and NOT email the user.
Changes

Add email_users flag to handle_archive_fail function
Set that flag to False to only email the Help desk with stuck registrations

Side effects

None anticipated

Ticket
https://openscience.atlassian.net/browse/OSF-5848

Pass finished.

Pass finished.

@erinspace Did you verify that this works locally?

Tested locally; seems to work as expected.

Merged into develop. 👍


MGMT-14936: Remove user-managed-networking cluster attribute

Related to https://issues.redhat.com/browse/MGMT-14936

For vsphere + umn/cmn we can save it in the state API that we have, If the user already set VIPs we know that he uses CMN
We use these feature support levels: 'CLUSTER_MANAGED_NETWORKING', 'USER_MANAGED_NETWORKING'

CLUSTER_MANAGED_NETWORKINGUSER_MANAGED_NETWORKINGOption selected by default
SupportedUnsupportedCMN
SupportedSupportedCMN
UnsupportedSupportedUMN

If the platform is none or baremetal UI needs to update the platform accordingly:

Choosing CMN will patch the cluster using:
cluster.platform.type = "baremetal"
Choosing CMN will patch the cluster using:
cluster.platform.type = "none"

please rebase


[Backend] Event Subscription and Query Entity Remove Deleted

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Since these entities does not support soft-deleted we don't need deleted in the db.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fixed


Update Pybind11 again

Before submitting
Please complete the following checklist when submitting a PR:

[x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[x] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[x] Ensure that the test suite passes, by running make test.

[x] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[x] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context: Aim to update Pybind11 to the latest release (2.13.5) for enabling Numpy 2.0 support, amongst other fixes.
Description of the Change: Pybind11 updated to v2.13.5
Benefits:
Possible Drawbacks:
Related GitHub Issues:

Due to upstream dependency on PennyLane, we can await the NP2.0 migration to complete before proceeding with this PR. CI will currently indicate any breakage with 1.x numpy support


Add unformatted share options

This would help when sharing to places that don't have markup syntax

After further review this isn't needed, as copying and pasting from the normal views works fine.


Fix 104/avatar resize img

[fix]/[avatar]
TASK: Fix avatar image resize
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Only
[ ] Refactor

Description, Motivation and Context
Resize large images to cover the avatar
Screenshots - Animation

Thank  you @carlosriveroib 🙌🏻 , I'm going to take a look at this

Codecov Report

Merging #109 (e81d161) into main (a086e3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   84.99%   84.99%
=======================================
  Files         117      117
  Lines        2079     2079
  Branches      697      697
=======================================
  Hits         1767     1767
  Misses        302      302
  Partials       10       10

Impacted Files
Coverage Δ

packages/nextui/src/avatar/avatar.tsx
97.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a086e3a...e81d161. Read the comment docs.


All uses of %llu gen warnings in clang, replace with PRIu64

uint64_t is "unsigned long long" on 32-bit, and "unsigned long" on 64-bit, and sometimes "unsigned long int".  So the assumption that uint64_t sizes are printed with %llu generates formatting errors when a VMA_DEBUG_LOG is defined to be used with printflike parameter testing.  I'm building various platforms in Xcode and VS.
I also split off VMA_DEBUG_LOG which is overly verbose into VMA_DEBUG_LOG_LEAK.  And I defined VMA_ASSERT to a non aborting assert that we have so that shutdown doesn't kill the app on leaks which are non-critical then.   Otherwise, or code was originally skipping destroying non-empty pools and the allocator to avoid those asserts.  So then leaks were never shown.
static inline void VmaUint64ToStr(char* VMA_NOT_NULL outStr, size_t strLen, uint64_t num)
{
        snprintf(outStr, strLen, "%" PRIu64, num);
}

void VmaBlockMetadata::DebugLogAllocation(VkDeviceSize offset, VkDeviceSize size, void* userData) const
{
    if (IsVirtual())
    {
        VMA_DEBUG_LOG_LEAK("UNFREED VIRTUAL ALLOCATION; Offset: %" PRIu64 "; Size: %" PRIu64 "; UserData: %p", offset, size, userData);
    }
    else
    {
        VMA_ASSERT(userData != VMA_NULL);
        VmaAllocation allocation = reinterpret_cast<VmaAllocation>(userData);

        userData = allocation->GetUserData();
        const char* name = allocation->GetName();

#if VMA_STATS_STRING_ENABLED
        VMA_DEBUG_LOG_LEAK("UNFREED ALLOCATION; Offset: %" PRIu64 "; Size: %" PRIu64 "; UserData: %p; Name: %s; Type: %s; Usage: %u",
            offset, size, userData, name ? name : "vma_empty",
            VMA_SUBALLOCATION_TYPE_NAMES[allocation->GetSuballocationType()],
            allocation->GetBufferImageUsage());
#else
        VMA_DEBUG_LOG_LEAK("UNFREED ALLOCATION; Offset: % " PRIu64 "; Size: %" PRIu64 "; UserData: %p; Name: %s; Type: %u",
            offset, size, userData, name ? name : "vma_empty",
            (uint32_t)allocation->GetSuballocationType());
#endif // VMA_STATS_STRING_ENABLED
    }

}

Thank you for these suggestions. I applied PRIu64 and added VMA_LEAK_LOG_FORMAT macro as you suggested.


How can i run template jobs in parallel

Hey running a couple of template jobs, but am unable to get them to run in parallel, tried using "strategy" with no luck! the yaml template has an object parameter and an each "${{ each projectName in parameters.projects }}" this works fine but only in sequence!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6724abea-bbdc-bf66-ed5e-3214fa6c3e66
Version Independent ID: 4f8dab21-3f0e-da32-cc0e-1d85c13c0065
Content: Templates - Azure Pipelines
Content Source: docs/pipelines/process/templates.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

Thanks for your question. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your question:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow


natchez sttp module

Would there be interest in a sttp module for natchez?

Or would we rather contribute this to sttp itself?

We seem to have only a handful of services using sttp so probably not too much interest from our end, but on the other hand I don't see why not if you're keen to contribute.
@tomverran has a majority vote here so you'll need his blessing, although I think he's a fan of sttp 😄


chore: fix some comments

Summary
fix some comments
Background
Brief background on why these changes were made, ie "why?"
Changes

List changes which were made.

Testing
How are these changes tested?
Metrics

List out metrics added by PR, delete section if none.

Breaking Changelist

Bulleted list of breaking changes, any notes on migration. Delete section if none.

Related Issues
Link any issues that are related, prefer full github links.
closes

To avoid airdrop farming noise with PR review and core team cycles we don't accept external contributions offering simple spelling and grammar fixes.


opening dropdown for state.

Is your feature request related to a problem? Please describe.
currently user can open dropdown as many they wish to. which make the page very long in mobile view which is frustrating for users and even in desktop view after opening dropdown for 2-3 states, users are not able to see the map view of state. one more problem, on hover of rows alternate rows doesn't show any effect which look like it's not clickable.
Describe the solution you'd like
i want to allow users to open only one dropdown of state. like if, already one dropdown is open, then automatically close that one before opening of newer one. and for dropdown i'll change some style to give it better look on hover.
Describe alternatives you've considered
i have already worked on the solution which i described, it's working well. if it's get accepted, i will raise pull request.
Additional context
present situation

after solving it.

This would be a nice enhancement. Making this available :)

This could be annoying for people who wish to compare districts in different states, like when you want to look out for family members scattered over India

Well , we can use accordian here for this . @Binu42

@sudevschiz can you please assign it to me.

Duplicate of #326. Please go through that discussion as well

That's great...opening dropdown for state.


Mail Flow Rules + Outbound Spam Filter

What if you have both configured to block auto-forwarding? Will the user get the mail flow rule kickback or the kickback from the outbound spam rule?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43299e41-87fe-d6f1-20f7-83791d8ef90b
Version Independent ID: e5e69845-7040-f5b7-b922-e2d2fd9a7d5e
Content: Configuring and controlling external email forwarding, Automatic forwarding, 5.7.520 Access Denied, disable external forwarding, Your administrator has disabled external forwarding, outbound anti-spam policy - Office 365
Content Source: microsoft-365/security/office-365-security/external-email-forwarding.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@HarrisburgUSysAdmin, I'm told that transport rules will hit first.

Ok, we are having a significant issue with the outbound spam filter and working with Microsoft.  They can't figure out why our emails are coming back with the NDR when our outbound spam policy clearly is set to allow external forwarding.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Chris Davis<EMAIL_ADDRESS>Sent: Friday, December 4, 2020 2:09:58 PM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Michael A. Platt<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Mail Flow Rules + Outbound Spam Filter (#3610)
[EXTERNAL EMAIL]
@HarrisburgUSysAdminhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHarrisburgUSysAdmin&data=04|01|mplatt%40harrisburgu.edu|f548f6d36ca64124895808d89888320a|45d5405ab095420ea3caf3395aeb3654|0|0|637427058004164211|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ApPfrAwNHmfzhm6cOWlF4%2F6z3uJCO54MmZHbV8x9uVg%3D&reserved=0, I'm told that transport rules will hit first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F3610%23issuecomment-738964260&data=04|01|mplatt%40harrisburgu.edu|f548f6d36ca64124895808d89888320a|45d5405ab095420ea3caf3395aeb3654|0|0|637427058004164211|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=dEUidXpJfVpTlH4cUKVjfAY%2F5omLRwZSt1pms07SbAQ%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMOAFBZ2DBH64QADYQ5G7NDSTEXYNANCNFSM4UJRRDGA&data=04|01|mplatt%40harrisburgu.edu|f548f6d36ca64124895808d89888320a|45d5405ab095420ea3caf3395aeb3654|0|0|637427058004174210|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Iw4eVoXcghfiPA6mSqyCQCubORyZReG5bP3w7R7tDAE%3D&reserved=0.

@HarrisburgUSysAdmin Thank you for your feedback. I was able to test this and I see the NDR from the mail flow rule.Let us know how the Support Personnel fixes this and based on the outcome, we can modify the document if needed.
Thanks
Sri

@chrisda and @msbemba - I'm unable to test this because we are having issues with our outbound spam filter.  We have 2 polices the default policy and the HU Outbound Spam Policy. Both have auto forwarding set to ON. We still get the NDR. Our support tech is unable to figure this one out.
[Case #:23164797]

I think I may know why this is not working for us. Our "default" outbound spam filter is not viewable via the GUI.  A user on reddit tipped me off about this saying how he manages some 10 tenants and all have the default outbound spam filter viewable in the GUI. We do not.  This is only accessible via PowerShell.

@HarrisburgUSysAdmin That is definitely a bug.The outbound spam policy should be viewable on the GUI to make changes. Unfortunately, we do not have access to support tickets to view the current status. Did you get this escalated for them to fix? Let us know the outcome. There are no changes required in the document but will wait for you to confirm before we close this issue.
Thanks
Sri

I'm tempted to close #3644 as a dupe of this issue.

@msbemba  Thank you very much for the contribution and sharing this explanation. @HarrisburgUSysAdmin
Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future


[Cordova] Add 64 bit support for all in one pack script

It's fine to pack all in one packages

https://crosswalk-project.org/jira/browse/XWALK-5430

LGTM


Fix a pair of docstrings in offamazonpayments

capture is missing two parameters, copy from refund which has them
add linebreak between docstring text and info fields in capture and refund, tooling generally doesn't deal well otherwise
remove todo comment: though incomplete the docstrings in the file match sphinx's docstring style

Updated the docstrings to try and document most everything. There are a few sticking points though:

the same parameter names are used for client-side references and amazon-generated identifiers, which I fear may be confusing to users? (I'm not actually a user of the API) e.g. the auth_id of authorize and get_authortization_status or capture are completely different things
the API exposes get_billing_agreement_details which is part of the automatic payments APIs, but no other API of that set seems exposed, is it actually useful?
I added currency to authorize as it's part of the Amazon API and the other functions expose it, figured it might come in handy
I did not document get_order_reference_details (and the rest of the order details stuff) either because the call here doesn't match the documented API so it seemed odd: there is no AddressConsentToken in the API (neither is there one in get_billing_agreement_details), though both have an AccessToken. Is AddressConsentToken the older name for AccessToken and both can be used still?

the same parameter names are used for client-side references and amazon-generated identifiers, which I fear may be confusing to users? (I'm not actually a user of the API) e.g. the auth_id of authorize and get_authortization_status or capture are completely different things

I think it's fine to re-use auth_id in those contexts. Amazon makes them more verbose arguments like AmazonAuthorizationId and AuthorizationReferenceId, but that distinction is more important to Amazon than to us. If we can at least document what the argument maps to, it should be fine.

the API exposes get_billing_agreement_details which is part of the automatic payments APIs, but no other API of that set seems exposed, is it actually useful?

I'm not a user of the API myself, but I figure this module is intended to cover the whole Amazon Pay legacy API for MWS. Likely the author of our first merge of this API only needed these particular methods.
We have missing methods in other APIs, as well, so not really that big of a deal.

I added currency to authorize as it's part of the Amazon API and the other functions expose it, figured it might come in handy

👍 Thanks!

I did not document get_order_reference_details (and the rest of the order details stuff) either because the call here doesn't match the documented API so it seemed odd: there is no AddressConsentToken in the API (neither is there one in get_billing_agreement_details), though both have an AccessToken. Is AddressConsentToken the older name for AccessToken and both can be used still?

Possibly, and good catch! I'd appreciate an update for those so they're more complete.

@GriceTurrble updated the get_order_reference_details and get_billing_agreement_details to take an access_token and set it as AccessToken.


Issue In Usage

There is an issue in 3rd step(window.plugins.launcher.launch()).
It should be called like this,
var launcher = new Launcher(); // create launcher object as function launch is private
launcher.launch({packageName:'com.facebook.katana'}, successCallback, errorCallback);

Ok - So, I've been trying t follow the usage instructions and  i get compilation errors. Does anyone  know f an example app using this plugin i can look at or have a link to a tutorial with a better explanation?


fix function for shutting down headless process

@ieivanov I think you ran into a problem where you couldn't get headless mode to shutdown correctly in the tests, right? I think this may be the fix. Do you remember what this was relevant to? There might be some more tests we could add in now that this behavior is correct


Fix TextUtils.toHexString having incorrect result for negative values

The check b < 16 was faulty and would have added a '0' for negative values.
E.g. for (byte) 0xFF the result would have been "0ff".

@Marcono1234 Ported to 5.1.x as well. Many thanks for contributing this fix.


bond_core: 1.7.19-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository bond_core to 1.7.19-0:

upstream repository: https://github.com/ros/bond_core.git
release repository: https://github.com/ros-gbp/bond_core-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.26
previous version for package: 1.7.18-0

bond

No changes

bond_core

No changes

bondcpp
* fix unused var warning
* Contributors: Mikael Arguedas

bondpy

No changes

smclib

No changes

waiting for other packages...


Something wrong with ImageTest.php

This probably needs to be investigated. My Travis CI build failed due to this:
There was 1 failure:
1) Faker\Test\Provider\ImageTest::testDownloadWithDefaults
Failed asserting that null matches expected 640.
/home/travis/build/fzaninotto/Faker/test/Faker/Provider/ImageTest.php:52

How ever, as far as I know there has been no changes to this file after May 20, 2015.
The line failing is as follows:
$this->assertEquals(640, $width);

For some reason, the variable $width is null. Why?
On my side, the test is actually OK:
$ phpunit --filter testDownloadWithDefaults test/Faker/Provider/ImageTest.php
PHPUnit 4.8.23 by Sebastian Bergmann and contributors.

.

Time: 17.27 seconds, Memory: 5.25Mb

OK (1 test, 4 assertions)

Few notes: Composer is up to date, and this error happens only with PHP 7.0.4. This might explain why the test works on my side, as my local development server is running PHP 5.5.9.
This issue might have an impact to further Pull Requests (causing them to fail the Travis CI build), such as the case stands in #862.
Edit: One possible explanation for this behaviour is curl not being enabled on Travis PHP 7.0.4 environment. It might be worth checking. Another issue might be that LoremPixel is down? The site seems to work and generate images but it might be that the site does not pass data to Faker.

Yep, the problem comes from LoremPixel. I think the Image Test should ping lorempixel first, and skip tests if the response time si too long.

If you need help with this one, I can create a PR for that.

Hi. I checked the HTTP header using curl and looks like the site is moved permanently:
$ curl -I http://www.lorempixel.com
HTTP/1.1 301 Moved Permanently
Date: Tue, 29 Mar 2016 13:05:51 GMT
Content-Type: text/html; charset=iso-8859-1
Connection: keep-alive
Server: Apache
Location: http://lorempixel.com/
Vary: Accept-Encoding

As a band-aid, I've created a PR #866 to check the HTTP status before assertions.

Fixed by #866


mimalloc >= 2.0.6 has issues in Windows

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
The ci build on Windows is failing.
Azure pipeline has 2 windows versions.

Windows Server 2022 with Visual Studio 2022
Windows Server 2019 with Visual Studio 2019

Upstream issues

https://github.com/microsoft/mimalloc/issues/623#issuecomment-1255274872

https://github.com/microsoft/mimalloc/issues/575

https://github.com/microsoft/mimalloc/issues/657#issuecomment-1412646519

In Windows Server 2019, BCryptGenRandom is reportedly worked

v2.0.6 uses RtlGenRandom by default

Our ci still fails with v2.0.9 which uses BCryptGenRandom

Installed packages
.

Environment info
.

Would add 2.0.9 doesn't even seem to build on conda-forge

v2.0.10 fixed windows but broke linux

Windows builds fine in v2.1.1.

Thanks @elbaro! 🙏
In that case let's migrate to the new version ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4310 ). Hopefully that will clear up the remaining issues


Refactor the code for Experiment and CustomRecord controllers

Some of their functionalities are really similar. Might be able to achieve more code sharing,

We now have their separate contexts.


Consider "napoleon" style of docstrings.

http://sphinx-doc.org/ext/napoleon.html

Napoleon is a pre-processor that parses NumPy and Google style docstrings and converts them to reStructuredText before Sphinx attempts to parse them.

scikit-learn uses numpy-style docstrings, and they're certainly much easier to read for long lists of parameters.  I'm not sure we have any methods that take enough parameters for this to really be an issue though.

In my opinion, streamparse has dense enough docstrings to benefit from a move to "napoleon" style, e.g. Component. pykafka especially needs it, e.g. BalancedConsumer.

This issue was moved to pystorm/pystorm#4


Don't Pre-Populate Required Columns

I understand that this is a simple way to ensure a build is better, but I spend a ton of time deleting these values so I'd rather they not be populated at all.

For some reason a while back I decided to prefill the Required column if the Monster already had runes. The numbers are based on ~80% of the current stats.
Gonna get rid of it.


Update README with the latest docker-app version for WGET

The WGET link under README seems to be broken. The release page is not captured under GITHUB repository. Hence, updating it to correct link.

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:ajeetraina/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ajeetraina can you sign-off your commit ? :angel: :pray:

I have signed off the commit from my end. Please check.


数据集中有数据被误封了，见desc中的截图，请求帮忙解封

General Question

问题数据集：
https://www.modelscope.cn/datasets/ccmusic-database/bel_canto/files
Before asking a question, make sure you have:

Searched the tutorial on modelscope  doc-site
Googled your question.
Searched related issues but cannot get the expected help.
The bug has not been fixed in the latest version.

Please @ corresponding people according to your problem:
Model related: @wenmengzhou @tastelikefeet
Model hub related: @liuyhwangyh
Dataset releated: @wangxingjun778
Finetune related: @tastelikefeet  @Jintao-Huang
Pipeline related: @Firmament-cyou @wenmengzhou
Contribute your model: @zzclynn

数据可以通过git 历史回滚，在本地恢复


dataset help

Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it on AWS.

Yeah sure I'll share my Google drive link with you.
On Thu, Dec 5, 2019 at 7:38 AM zccd<EMAIL_ADDRESS>wrote:

Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it
on AWS.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rambasnet/DeepLearning-IDS/issues/12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ
.

Yeah sure I'll share my Google drive link with you.
…
On Thu, Dec 5, 2019 at 7:38 AM zccd @.***> wrote: Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it on AWS. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ .

Thank you very much! how can I get the dataset?

Yeah sure I'll share my Google drive link with you.
…
On Thu, Dec 5, 2019 at 7:38 AM zccd @.***> wrote: Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it on AWS. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ .

Thank you very much! how can I get the dataset?

I'm very sorry i can't use Google drive, could you share it on your github?

mail me personally once
On Fri, Dec 6, 2019 at 6:38 AM zccd<EMAIL_ADDRESS>wrote:

Yeah sure I'll share my Google drive link with you.
… <#m_7872353785081107349_>
On Thu, Dec 5, 2019 at 7:38 AM zccd @.***> wrote: Hi, could you provide
me a CSE-CIC-IDS2018 dataset? I can not download it on AWS. — You are
receiving this because you are subscribed to this thread. Reply to this
email directly, view it on GitHub <#12
https://github.com/rambasnet/DeepLearning-IDS/issues/12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ
.
Thank you very much! how can I get the dataset?
I'm very sorry i can't use Google drive, could you share it on your github?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rambasnet/DeepLearning-IDS/issues/12?email_source=notifications&email_token=AHP6VCTSEBQWLZK5T4JUZ6LQXGQXFA5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCVXGI#issuecomment-562387865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHP6VCWVOQU2QFGTBT7LTODQXGQXFANCNFSM4JVS25EQ
.

Yeah sure I'll share my Google drive link with you.
…
On Thu, Dec 5, 2019 at 7:38 AM zccd @.***> wrote: Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it on AWS. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ .

Hi, could you provide me your google drive link? Thank you very much!

Yeah sure I'll share my Google drive link with you.
…
On Thu, Dec 5, 2019 at 7:38 AM zccd @.***> wrote: Hi, could you provide me a CSE-CIC-IDS2018 dataset? I can not download it on AWS. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AHP6VCXPY3WWQSGMBMSZC6LQXBPB7A5CNFSM4JVS25E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6GEH7A>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHP6VCWHIJ7NQ6SHZCEYBGLQXBPB7ANCNFSM4JVS25EQ .

Hi, could you share your google drive link with me? I really need it, and i am sorry i cann't download it from AWS. Thank you very much!

<EMAIL_ADDRESS>this is mail id mail me personally

<EMAIL_ADDRESS>this is mail id mail me personally

Ok, I have mailed you. Do you receive it?

Hello, like the above people, I can't download cse-cic-ids2018 data set. Can you send it directly to my email<EMAIL_ADDRESS>or<EMAIL_ADDRESS>thank you very much

Hi, could you share your google drive link with me? I really need it, and i am sorry i cann't download it from AWS. Thank you very much!
<EMAIL_ADDRESS>this is mail id mail me personally

In case anyone come here for the Dataset, you can download it from the: https://www.unb.ca/cic/datasets/ids-2017.html
as suggested.
or if you want only the CSV files you can download them from kaggle:
https://www.kaggle.com/solarmainframe/ids-intrusion-csv


BULK VALIDATION duplicate H2 fixes

Docs Build status updates of commit f264a48:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/CALCDATE-Function--Date-.md
:bulb:Suggestion

Details

dynamics-nav/CHANGECOMPANY-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/CLEAR-Function.md
:bulb:Suggestion

Details

dynamics-nav/DELCHR-Function--Code--Text-.md
:bulb:Suggestion

Details

dynamics-nav/DELETE-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/FIELDERROR-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/FILTERGROUP-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/FIND-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/FINDSET-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/FORMAT-Function--Code--Text-.md
:bulb:Suggestion

Details

dynamics-nav/GETRANGEMAX-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/GETRANGEMIN-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/MODIFY-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/OPEN-Function--Dialog-.md
:bulb:Suggestion

Details

dynamics-nav/RENAME-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/REPORT-RUN-Function.md
:bulb:Suggestion

Details

dynamics-nav/REPORT-RUNMODAL-Function.md
:bulb:Suggestion

Details

dynamics-nav/SETAUTOCALCFIELDS-Function--Record-.md
:bulb:Suggestion

Details

dynamics-nav/SETCURRENTKEY-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/CALCDATE-Function--Date-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/CHANGECOMPANY-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/CLEAR-Function.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/DELCHR-Function--Code--Text-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/DELETE-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/FIELDERROR-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/FILTERGROUP-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/FIND-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/FINDSET-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/FORMAT-Function--Code--Text-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/GETRANGEMAX-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/GETRANGEMIN-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/MODIFY-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/OPEN-Function--Dialog-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/RENAME-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/REPORT-RUN-Function.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/REPORT-RUNMODAL-Function.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

dynamics-nav/SETAUTOCALCFIELDS-Function--Record-.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8667ed0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/CALCDATE-Function--Date-.md
:white_check_mark:Succeeded

dynamics-nav/CHANGECOMPANY-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/CLEAR-Function.md
:white_check_mark:Succeeded

dynamics-nav/DELCHR-Function--Code--Text-.md
:white_check_mark:Succeeded

dynamics-nav/DELETE-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/FIELDERROR-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/FILTERGROUP-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/FIND-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/FINDSET-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/FORMAT-Function--Code--Text-.md
:white_check_mark:Succeeded

dynamics-nav/GETRANGEMAX-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/GETRANGEMIN-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/MODIFY-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/OPEN-Function--Dialog-.md
:white_check_mark:Succeeded

dynamics-nav/RENAME-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/REPORT-RUN-Function.md
:white_check_mark:Succeeded

dynamics-nav/REPORT-RUNMODAL-Function.md
:white_check_mark:Succeeded

dynamics-nav/SETAUTOCALCFIELDS-Function--Record-.md
:white_check_mark:Succeeded

dynamics-nav/SETCURRENTKEY-Function--Record-.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@buck1ey
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


tests: add tests for Socialite provider

This adds some initial tests for the provider. Also dropped support for PHP 7.4, as we aren't using it ourselves and this was left over from my initial repository (moved this to https://github.com/worksome/socialite-worksome/pull/3). 👍🏻
Closes #1

Merging as it's better to have tests than not. 👍🏻 (And I discussed this with Luke at kick-off). 👌🏻


Ink stained blocks aren't inkproof

In more detail  Ink stained glass, Ink stained glass panes and ink stained carpets are inkable (they have the #splatcraft:inkproof from the fact the #splatcraft:inkproof has #forge:glass, #forge:glass_panes and, #forge:carpets)

Why make ink stained wool inkproof? , Ink stained glass, glass panes, carpets makes sense since their non-ink counterparts can not be ink, doesn't apply to wool tho


Incorrect vertebra segmentation

Came across a strange segmentation and was wondering if there was a root cause, or just a hiccup by the model.  Was wondering if anyone has come across something like this.

This mixing of neighouring vertebrae happens in roughly 1-2% of cases. It is a known problem which is not easy to solve unfortunately.


Issue compiling template running on macOS Catalina 10.15.5

I have ExtentReports.Core v1.0.2 implemented on a .Net core test suite (core v3.0) and when I execute the tests on a mac with the above mentioned OS I receive the following error when trying to generate the test report results. Is there support for using Extent Reports on macOS/Linux? I understand the overall issue is with the RazorEngine template but since that is a dependency of the extent report library I'm posting the issue/question here. I've read about having to either fork the RazorEngine project and make a change to the code or use RazorLight. Thanks
Error Message:
TearDown : RazorEngine.Templating.TemplateCompilationException : Errors while compiling a Template.
Please try the following to solve the situation:

If the problem is about missing/invalid references or multiple defines either try to load
the missing references manually (in the compiling appdomain!) or
Specify your references manually by providing your own IReferenceResolver implementation.
See https://antaris.github.io/RazorEngine/ReferenceResolver.html for details.
Currently all references have to be available as files!
If you get 'class' does not contain a definition for 'member':
try another modelType (for example 'null' to make the model dynamic).
NOTE: You CANNOT use typeof(dynamic) to make the model dynamic!
Or try to use static instead of anonymous/dynamic types.
More details about the error:

warning: (18, 5) The variable 'isbdd' is assigned but its value is never used

warning: (9, 4) Unnecessary using directive.
warning: (7, 4) Unnecessary using directive.
warning: (8, 4) Unnecessary using directive.
warning: (6, 4) Unnecessary using directive.
warning: (5, 4) Unnecessary using directive.
warning: (10, 4) Unnecessary using directive.
error: (0, 0) Unexpected error writing debug information -- 'COM Interop is not supported on this platform.'
Temporary files of the compilation can be found in (please delete the folder): /var/folders/dh/5r5228yj7w920w6dsr02k1mm0000gs/T/RazorEngine_lcknchxe.21p
The template we tried to compile is:
------------- START -----------
@using RazorEngine
@using RazorEngine.Templating

@{
var isbdd = false;
var cls = "";
if (Model.TestList.Count > 0 && Model.TestList[0].IsBehaviorDrivenType)
{
isbdd = true;
cls = "bdd-report";
}
}

@bgoggan I will look into this and update you. By the way, the package you are using has been created by the SimplyTest team.  Packages I create are available here:  https://www.nuget.org/packages/ExtentReports/4.1.0-beta1https://www.nuget.org/packages/ExtentReports/4.1.0-beta1

@anshooarora thank you for your time with it. If I need to re-direct elsewhere I don't mind doing that.

I ran it on Catalina and the package I mentioned works without any issues.  I did however face an issue while installing this package, for which I had to install Newtonsoft.Json first, followed by ExtentReports 4.1.0-beta1.  I will fix this issue and try to push the release version by tomorrow.

@anshooarora sounds good. One additional question. Does the package you mentioned support .net Core 3.0? I believe that's why I originally switched to the package I'm using now because previous versions didn't.

@bgoggan Please use this:  https://www.nuget.org/packages/ExtentReports/4.1.0.  This package is built as a .NET Standard 2.0 library.  The previous versions were targeting .NET Framework which is why but all development starting release 4.1.0 will target .NET Core/Standard.

@anshooarora Thabk you. I will update my version in the morning and let you know. Much appreciated

@anshooarora So, I updated my package this morning to the one mentioned and prior to testing the creation on my mac machine I ran a test on windows as a regression. Previously I was creating the report with a specific name, using the "Nam" attribute from the test context. For whatever reason now the test report just ends up being named, "index.html". My code is below. Is there something different in the CreateTest method is this package than what I may have been doing before? I validated the TestContext Name value is present.
`            currentDir = Directory.GetCurrentDirectory();
ParentDir = Directory.GetParent(currentDir).Parent.FullName;
Directory.CreateDirectory(Path.Combine(ParentDir, "AutoResults"));
FileName = Hooks.TestContext.Test.Name + "_" + DateTime.Now.ToString("yyyy-mm-dd-HHmmss") + ".html";
var htmlReporter = new ExtentHtmlReporter(Path.Combine(ParentDir, "AutoResults", FileName));
FilePath = Path.Combine(ParentDir, "AutoResults", FileName);
        report = new ExtentReports();
        report.AttachReporter(htmlReporter);

        htmlReporter.LoadConfig(Path.Combine(currentDir, "extent-config.xml"));

        **test = report.CreateTest(TestContext.CurrentContext.Test.Name);`**

@anshooarora Hey, so it appears the issue comes from switching the ExtentV3HtmlReporter to just the ExtentHtmlReporter, which I see is necessary with version 4. I looked at the documentation and I don't see how I'm using it incorrectly but maybe I am.


Added evaluation metrics and visualisation

Related Issue
#171
Description
Added evaluation metrics like f1 score, and auc-roc score, also created visualisations to get insights from these metrics.
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshot

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

I understand, but the only code removed was redundant also some outputs of large dataframe were shrunken, So that notebook is readable easily. Also, I shrunk some code to particular functions and dictionaries following the DRY convention in coding. Should I expand my file again?

your work is good and I also agree with your point, but there are some visualizations so include it too then I will merge it too.Till the time I have merged it

Sure


New: innerproduct-triangleinequality

Link to paragraph
https://dbalague.pages.ewi.tudelft.nl/openlabook/Chapter1/Inner_Product.html
What type of applet is this?
Interactive applet 2D
What state is the static image?
Yes, Dennis has created a static image
Static image

Requirements
|v+w |<=| v| + |w|
What elements are interactive?
W of v draggen in alle richtingen, highlight de situatie van de driekhoek ongelijkheid.
Does this issue relate or depend on other issues?
No response

is already implemented and merged in the book


Clean up prop-types

replaced elementType with builtin one
removed unused custom prop type

/cc @jquense


Bug fixes

made bug fixes, can build now.

YOU BETTER MERGE THIS 😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡😡

closing due to possible interferece with Tyler's pull request


[WIP] Read bounty profitability and adjust defaults accordingly

Depends on https://github.com/ethereum-alarm-clock/eac.js-client/pull/40

Orphaned. Closing.


Long term graphs title

I just updated to the latest available version. I noticed that when I click on one of the long range graphs, and it enlarges, at the top left of the screen I get the "title" of that graph (i.e. 24-hour or 1 week). If then I change to another graph using the left/right arrows on screen, the graph does change, but the title does not. It should change to constantly reflect what graph is being shown...
Cristian

Fixed the second part and labeled the charts better.


[docs]: updates connecting_to_a_feature_store.ipynb

fixes FeastPromptTemplate.format example to use driver_id

ah nice catch!

Please merge whenever!


Question: how to identify the API call is from SSR/CSR

I'm creating API on server.js that uses user authentication via passport.
I already add code to use passport and it works fine. If the user is not authorized, then redirect to login page for page, or return 403 Forbedden for APIs.
const isAuthenticatedAPI = (req, res, next) => {
    if (req.isAuthenticated()) {
        return next();
    } else {
        res.sendStatus(403);
    }
};

server.get("/api/item/:id", isAuthenticatedAPI, (req, res) => {
    // API implementation
});

But it is too strong. The code reject API calls during SSR. I hope to omit authentication check during SSR. I thought two solutions, but they were fragile:

Checking user-agent is node-fetch/1.0 (+https://github.com/bitinn/node-fetch) or not.
Checking req.ip is local or not (via is-local-ip)

Is there any cool solution to identify the API client is for SSR or CSR?
thanks,

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

We will get any good solution to decide authentication check should be omitted or not.
Current Behavior

I couldn't identify API call is for SSR/CSR in Express.js's handler.
Steps to Reproduce (for bugs)

Add passport to next's server.js
Call the API during SSR (it's ok on CSR)

Context

I am creating the website that has uses user authentication via passport.
Your Environment

Tech
Version

next
5.0

node
8.9.4

OS
macOS 10.12.6

browser
Chrome M63

etc

You should check in getInitialProps, and then you can check for !!req, if true it's ssr, if false it's the browser.

Yes. Checking in React layer is easy. But it is difficult on Express (or any API server). I could detect on getInitialProps(), but inside http handlers, I couldn't check. The handlers are accessed via isomorphic-unfetch.
getInitialProps() : OK
          ↓
isomorphic-unfetch
          ↓
http handlers on Express : No idea

That's unrelated to how next handles things, if you need to know if it comes from the server/client you should add that to the body of a request sent to your api. Another idea, is adding cors configuration to pass cookies to your api. But that only works for apis on the same domain. And makes your api stateful. So it's not really a recommendation.


Type assertions & type predicates can have incorrect narrowing logic

🔎 Search Terms
Type assertion, type predicates, type narrowing
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about assertion functions, type predicates, and narrowing. I failed to find anything covering type predicates and assertion functions.

⏯ Playground Link
see on TS playground
💻 Code
type Animal = { legs: number };
type Cat = Animal & { legs: 4, meow: () => void };
type Bird = Animal & {legs: 2, chirp: () => void };

// This function doesn't have sufficient logic to narrow from `Bird | Cat` to `Bird`
function isBird(pet: Bird | Cat): pet is Bird {
	return true;
}
// This function doesn't have sufficient logic to narrow from `Bird | Cat` to `Bird`
function isBirdAssertion(pet: Bird | Cat): asserts pet is Bird {
}

function insufficientAssertions(pet: Bird | Cat){
  if(isBird(pet)){
    pet.chirp();
  }
  isBirdAssertion(pet);
  pet.chirp()
}

// The typescript compiler clearly has the means to handle narrowing between these types:
function validNarrowing(pet: Bird | Cat){
  // the same logic as `isBird` is known to be insufficient to narrow the type of `pet`
  if(true){
    // @ts-expect-error: 2339
    pet.chirp();
  }

  if(pet.legs === 2){
    // With proper narrowing logic, the compiler knows the type can be narrowed to `Bird`
    pet.chirp();
  }
}

🙁 Actual behavior
An assertion function or type predicate which contains insufficient logic to narrow the input type generates no errors and can be used to narrow a type in the calling code, despite not having certainty the type is narrower.
🙂 Expected behavior
an assertion function or type predicate which doesn't sufficiently narrow the input type before the return or end of function should result in an error.
Additional information about the issue
No response

The primary reason to write a UDTG is to do type checks that the compiler isn't capable of doing itself, so it's very much intentional that the implementation isn't checked.  Otherwise you'd get spurious errors in cases where the logic is sufficient for narrowing but the compiler isn't able to prove it.

The primary reason to write a UDTG is to do type checks that the compiler isn't capable of doing itself, so it's very much intentional that the implementation isn't checked.  Otherwise you'd get spurious errors in cases where the logic is sufficient for narrowing but the compiler isn't able to prove it.

Could you share an example? The TS handbook doesn't seem to imply that, and in fact gives an example similar to mine that the compiler definitely was capable of doing itself. See "using type predicates" for example.
Where is it more useful for type predicates to not also have the compiler perform the checks it can?

I have yet to encounter a scenario where it is more useful for type predicates to not also have the compiler perform the checks it can.

You’re basically asking TS to spit out an error whenever it thinks that you “haven’t done enough” to narrow the value according to the function signature, via the checks it’s able to do itself.  Lots of non-trivial type guards would be broken by such an error; see https://github.com/microsoft/TypeScript/issues/29980#issuecomment-467945410.
tl;dr: The proposed behavior would error on any type predicate where the same check wouldn’t already work to narrow the value inline.  In other words, almost all of them.

An example that may be useful for the docs is when the property to narrow on
interface SuccessStatus {
    code: 0;
    message: string;
}
interface FailureStatus {
    /* in failure case this will be an integer other than 0 */
    code: number;
    message: string;
}
type ProcessStatus = SuccessStatus | FailureStatus;

function isFailure(response: ProcessStatus): response is FailureStatus {
    return response.code !== 0;
}

Types like "any number other than this specific one" can't be explicitly expressed in typescript and therefore can't be automatically narrowed.

example that may be useful for docs:
interface SuccessStatus {
    code: 0;
    message: string;
}
interface FailureStatus {
    /* in failure case code will be anything other than 0 */
    code: number;
    reason: string;
}
type ProcessStatus = SuccessStatus | FailureStatus;

function isFailure(response: ProcessStatus): response is SuccessStatus {
    return response.code === 0;
}

declare const a: ProcessStatus;

if (a.code === 0){
    // this doesn't work since typescript can't determine that failure case can't be 0
    console.log(a.message);
}
if (isFailure(a)){
    console.log(a.message); // works as intended.
}

example that may be useful for docs:
interface SuccessStatus {
    code: 0;
    message: string;
}
interface FailureStatus {
    /* in failure case code will be anything other than 0 */
    code: number;
    reason: string;
}
type ProcessStatus = SuccessStatus | FailureStatus;

function isSuccess(response: ProcessStatus): response is SuccessStatus {
    return response.code === 0;
}

declare const a: ProcessStatus;

if (a.code === 0){
    // this doesn't work since typescript can't determine that failure case can't be 0
    console.log(a.message);
}
if (isSuccess(a)){
    console.log(a.message); // works as intended.
}

@tadhgmister In the example you shared the type could be narrowed safely:
interface SuccessStatus {
    code: 0;
    message: string;
}
interface FailureStatus {
    /* in failure case code will be anything other than 0 */
    code: number;
    reason: string;
}
type ProcessStatus = SuccessStatus | FailureStatus;

function isSuccess(response: ProcessStatus): response is SuccessStatus {
    return 'message' in response;
}

declare const a: ProcessStatus;

if (a.code === 0){
    // this doesn't work since typescript can't determine that failure case can't be 0
    console.log(a.message);
}
if ('message' in a){
    // this works and is verifiable by the compiler
    console.log(a.message);
}
if (isSuccess(a)){
    console.log(a.message); // works as intended.
}

It seems like it would be preferable to have the narrowing occur safely, and that seems to be the standard expectation of TS developers who are unfamiliar with the current behavior.

@Masstronaut then consider a case where message and reason are both optional. (Playground Link) I do think my original example is sufficient to get the point across but I respect your need for an example that has no alternative.


feat(k8s): Switch from CoreV1 Endpoints to DiscoveryV1 EndpointSlice

EndpointSlice API is available as V1 since K8s 1.21. Let's do not rely on old Endpoint API in KTF.
It's been spotted during work on https://github.com/Kong/kubernetes-ingress-controller/issues/3916.
TestValidationWebhook from KIC uses WaitForConnectionOnServicePort function from KTF. When KIC drops Endpoints in favour of EndpointSlice this test doesn't pass, because Endpoints are not created (and KTF expecting them).
Mirroring works in other way from Endpoints to EndpointSlices under circumstances described in docs. Thus after this change KTF should be still backward compatible with Endpoints and does not break someone's tests that rely on old Endpoints.
I've tested this change with KIC and everything passes

KIC with old Endpoints and KTF with EndpointSlice
KIC with EndpointSlice (WIP) and KTF with EndpointSlice

Thus this PR with high certainty (maybe some edge cases exist) shouldn't break someone's setup.
Other improvements - reduce coupling by replacing concrete K8s client as parameter with corresponding interface.

Codecov Report
Patch coverage has no change and project coverage change: -29.27 :warning:

Comparison is base (3b8ce68) 58.40% compared to head (f63c56b) 29.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #643       +/-   ##
===========================================
- Coverage   58.40%   29.14%   -29.27%
===========================================
  Files          43       43
  Lines        3455     3462        +7
===========================================
- Hits         2018     1009     -1009
- Misses       1173     2308     +1135
+ Partials      264      145      -119

Flag
Coverage Δ

integration-test
29.14% <0.00%> (-29.27%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/utils/kubernetes/networking/services.go
0.00% <0.00%> (-14.00%)
:arrow_down:

... and 27 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@programmer04 You'll need to re-push the commits after you've signed them


Support background load for audio and progress info

Sound/music loading was happening in render thread. This change moves it to rayon threadpool.
There are two updates:

Move file content loading in thread pool.
Use pool.spawn instead of the blocking pool.install which was causing file parsing to block render thread.
Support for loading screen by having new assets_loaded() function.

Testing:

OK: Absolute path codepath for loading
NOT TESTED: WASM code path. If anyone else can test it please do.
OK: verified assets_loaded() returns # of textures and images correctly.
Not sure if I missed a test - let me know and/or please check yourself :)

WARNING! If this PR is merged, first or early music/sound played may stop working because it may not be asynchronously loaded. For example, main menu music may stop working since play() is called before load completes.
It is up to the developer to verify if assets have been loaded by calling assets_loaded() which will return a number of assets loaded so far. This can be used for a progress bar.
Example:
        draw_text(
            &format!("Loaded assets: {}", assets_loaded()),
            vec2(0.0, 1.0),
            WHITE,
            TextAlign::Center,
        );

I'm totally OK if anyone makes any changes on top of this code or removes/rewrites any way.

Thanks for this, I've cherry picked some of the changes, but unfortunately I can't merge it as on the surface level it seems to break wasm by switching from bytes to path (haven't checked this in detail), but maybe more improtantly I'm doing bigger restructuring of the asset code, and it's just easier to just pick a few bits and do the rest from scratch :) It'll land on master shortly.

Closing since https://github.com/darthdeus/comfy/pull/42 was merged and includes this.

thanks for the fast update! glad WASM is also working!


Player list

Back : may not be optimized (has to do 3 requests in total)
Front : are new types for the filters needed ?

Looks good for now, going to merge. If any issues come up I will fix them on my branch since I'll use this for tournament registrations.


Compatibility Confusion

Hello friend, i've downloaded your template. But for what module is available. For example im using wordpress this one what compatibility have?

This is pure PHP template. Not wordpress module/plugin


[bug]  Project Id can be visible in the network section

Link to minimal reproducible example
https://appkit-lab.reown.com/library/wagmi/
Summary
Bug Description
The projectId passed through the query parameter in the network request is visible in the Network tab of the browser's developer tools. This could potentially expose sensitive information or internal identifiers, which may lead to security concerns.
Steps to Reproduce

Open the application in a browser.

Connect your wallet using reown

Open the browser’s Developer Tools (e.g., Chrome: F12 or Ctrl+Shift+I) and go to the Network tab.

Observe the network requests being made.

Look for the request containing the projectId in the query parameters.

Environment

Browser: Brave
Operating System: Windows 11
Client: NextJS

List of related npm package versions
@reown/appkit/react
Node.js Version
v22.2.0
Package Manager
<EMAIL_ADDRESS>

hi @NufailIsmath .. it's not a bug ...
People should Setup and Verify theirs Domains in order to use it online into http://cloud.reown.com


toast: download error

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[X] Bugfix
[ ] Feature
[ ] Refactoring

Context

[X] Related to #7375
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[X] My contribution builds clean without any errors or warnings
[X] I've merged recent default branch -- main and I've no conflicts
[X] I've tried to respect high code quality standards
[X] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[X] Fill up your DOT address: Payout

Community participation

[ ] Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at bb7ec50
Improved the user experience of the downloadImage function by adding translation and error notification features. Updated the locales/en.json file with a new message for download failures.

🤖 Generated by Copilot at bb7ec50

downloadImage fails
Shows toast message in $i18n
Autumn leaves fall fast

@roiLeo And maybe add a warningMessage('Unable to download image') in the catch?

Yessir (maybe toast?)

From #7390


strage error

error: [Errno 2] No such file or directory: 'libopenblas.UWVN3XTD2LSS7SFIFK6TIQ5
GONFDBJKU.gfortran-win32.dll'
No idea
Regards

I've removed python completly and re-install it with its require libraries needed by Puffader.
It's working fine. Closed it.

I've removed python completly and re-install it with its require libraries needed by Puffader.
It's working fine.

Issue is resolve , I was working an other stuff where I installed numpy , scapy as well. due to these packages above error occurred. I've changed the path and now every thing set back to normal. If any one else having this issue so kindly check your windows path at %appdata%  in Roaming folder python rename it for a while and recompile Puffader.py file with python setup.py . It will work for sure .
Thanks


[C++][Docs] Document our ABI stability policy

With the 16.1.0 release, there have been a few issues related to whether this minor / feature release is expected to be ABI stable or expected to have bumped the so version.:

https://github.com/apache/arrow/issues/41659
https://github.com/apache/arrow/issues/41679
https://github.com/conda-forge/arrow-cpp-feedstock/pull/1409

Our release scripts do bump the so version for minor releases, as has been discussed and implemented around the time of the first 1.0.0 release (https://github.com/apache/arrow/pull/4801, mailing list thread).
However, we don't document this policy anywhere AFAIK (and there was clearly also confusion about this among the committers as well). We should document this in the C++ docs somewhere, that the so version is bumped for every major and minor version, and thus consequently that bug-fix releases are expected to be ABI stable.

This will be review for most people discussing here, but just wanted to summarize explicitly to make sure we're clear and all on the same page:
Status quo

SOVERSION=${MAJOR}${MINOR} (so version 16.1.0 produces libarrow.so.1601, while version 16.0.1 produces libarrow.so.1600)
Patch versions are promised to be ABI-compatible (but this is not explicitly verified in any way)
Minor versions are not promised to be ABI-compatible
Packaging metadata (for conda, haven't looked at others) claims that the packages are compatible between minor versions, so the runtime library is allowed to float across minor versions within the same major family.

Conservative solution

SOVERSION=${MAJOR}${MINOR}${PATCH} (so version 16.1.0 produces libarrow.so.160100, while version 16.0.1 produces libarrow.so.160001)
Assumes a completely unstable ABI
Might be the most strictly accurate claim at the moment
Would be quite painful for consumers

Compromise solution

Same as the status quo, but packaging is updated to reflect the real ABI guarantees rather than the current misaligned state where packages promise wider ABI-compatibility than the compiled libraries in the package.

Desired state

SOVERSION=${MAJOR} (so version 16.1.0 and version 16.0.1 produce libarrow.so.16)
Both minor and patch versions are promised to be ABI-compatible
This may not be possible for arrow right now.

Summary
If minor or patch releases can break ABI, then the SOVERSION must reflect that so that libraries built against libarrow have the appropriate requirements baked into the executable (e.g. DT_NEEDED entries in ELF files). Downstream of the library, packaging metadata (in particular, conda metadata as is being discussed in https://github.com/conda-forge/arrow-cpp-feedstock/pull/1409) must account for this by setting runtime dependencies of dependents of libarrow to account for the right version of libarrow at runtime. Making a decision on https://github.com/apache/arrow/issues/41707 (i.e. clarifying the intended stability promises) is the first thing to be done, then we can work on updating packaging files.


Image doesnt show on new slide

There is a trailing quote on the image link. Preventing the image from loading

fixed with previous pull request
#5


Improve diff mode code modifications

Our current implementation only reliably works with Claude 3.5 Sonnet.
Explore other methods that work reliably with other models.

With the latest 1.13.5, I was bit confused because I was using claude-3-5-sonnet-20240620, but then I found
    if (options.diff && modelKey !== 'claude-3-sonnet-20240229') {

Wow, thanks my ai-assistant... I'll push a quick fix.


DD-996. Remove schemaLocation attribute

Fixes DD-996
Description of changes
Removes the schemaLocation attribute from the new provenance.xml. I want to avoid Dataverse/tika trying to validate the XML. I am not sure it would with a schemaLocation, but why take the chance?

Notify
@DANS-KNAW/dataversedans

Seems it is already used in everyt provenance.xml, so let's keep it.


Implemented '/INSPECT open' command when connecting to a debug bot vi…

…a url.
===
One of #1443

Coverage increased (+0.1%) to 57.161% when pulling 0272212ec8faea77e64525260fe34cb7a3acec7b on toanzian/sidecar-via-url into 4422c69393f9e1ea50192e4b71fd8284adefd8b6 on master.


Java bridge and synthetic methods should not be exported to JS object proxy

On some conditions Java compiler (as well as Kotlin compiler) generates bridge and synthetic methods.
Such methods are needed to provide either backward compatibility (methods with covariant return types are java 1.5+ only) or provide behaviour defined by specification, but not possible with JVM directly (accessing private members of parent class in inner or nested classes).
These methods are not defined in the source code directly and should not be exported to the JS.

@crahda  thanks for taking care of PR. I am closing this issue since changes are merged to master.


可以缩小一下嘛？为中小型网络测试

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

请详细描述一下场景，谢谢


waffle.io Badge

Merge this to receive a badge indicating the number of issues in the ready column on your waffle.io board at https://waffle.io/microweber/microweber
This was requested by a real person (user peter-mw) on waffle.io, we're not trying to spam you.


Remove Ignore annotation from SnackbarHostTest (#66)

WHAT
Remove Ignore annotation from SnackbarHostTest
WHY
As the test snackbarHost_returnedResult is not failing @Ignore annotation should be removed
HOW

Remove @Ignore annotation from snackbarHost_returnedResult() and SnackbarHostTest

Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[x] Run spotless check
[x] Run tests
[x] Update metalava's signature text files

I have signed the License.


Failure to bundle install the gem

I am trying to install gem using bundler. I setup the initializers. and I got errors as below.
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:94:in rescue in block (2 levels) in require': There was an error while trying to load the gem 'billplz-api'. (Bundler::GemRequireError) Gem Load Error is: uninitialized constant Billplz::Flexirest Backtrace for gem load error is: /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/billplz-api-0.1.0/lib/billplz/model.rb:2:in module:Billplz'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/billplz-api-0.1.0/lib/billplz/model.rb:1:in <top (required)>' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/billplz-api-0.1.0/lib/billplz-api.rb:8:in <top (required)>'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:91:in require' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:91:in block (2 levels) in require'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:86:in each' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:86:in block in require'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:75:in each' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler/runtime.rb:75:in require'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.14.5/lib/bundler.rb:107:in require' /home/bantu-hakim/Workspace/Bantu/ProjectAPI/config/application.rb:17:in <top (required)>'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:156:in require' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:156:in require_application_and_environment!'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:77:in console' /home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands/commands_tasks.rb:49:in run_command!'
/home/bantu-hakim/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/railties-5.0.1/lib/rails/commands.rb:18:in <top (required)>' bin/rails:4:in require'
bin/rails:4:in `'

A new version has been released ,please use the new version. Thank you.

ty for the fast fix


The cdn version of Vimeo's player.js is not appropriate for a

[ ] Issue does not already exist
[ ] Issue observed on https://plyr.io

Expected behaviour
Vimeo videos should play correctly
Actual behaviour
A Mismatched Anonymous Define Modules error fires. More info on that error: http://requirejs.org/docs/errors.html#mismatch
Basically, the UMD in player.js is simply not necessary for embedding via a script tag.
Environment

Browser: Chrome
Version:  54
Operating System: OSX
Version: 10.11.16

Steps to reproduce

Use Plyr.js on a site which uses require.js and load a Vimeo video.

Might be worth raising this over at the player.js repo?
https://github.com/vimeo/player.js

@SamPotts I've raised the above pull request for this issue. I'm not sure that that Vimeo would alter the CND'd version of their player.js for this. I think it could be related to this issue though: https://github.com/vimeo/player.js/issues/36
I've implemented the above PR on a couple of Magento 2 sites, which heavily use require.js, and it thoroughly fixes the mentioned issue.

Here's a Codepen which kind of clumsily illustrates the issue: http://codepen.io/jodi/pen/ObMjbM?editors=1010

FWIW I've opened an issue on Vimeo's repo too: https://github.com/vimeo/player.js/issues/79
Sorry for the issue spam!

This issue can be alleviated with a fix in the 'vimeoTimer' callback interval by checking for require and then load the CDN version using require if it's available:
var vimeoTimer = window.setInterval(function() {
    if (_is.object(window.Vimeo)) {
        window.clearInterval(vimeoTimer);
        _vimeoReady(mediaId, container);
    } else if ("function" == typeof define && define.amd) {
        require([
            config.urls.vimeo.api
        ], function(player){
            window.Vimeo = { Player: player };
            _vimeoReady(mediaId, container);
        });
        window.clearInterval(vimeoTimer);
    }
}, 50);

Vimeo now supports amd (in case they didn't before).
Example of how to import vimeo player in require.js:
http://jsbin.com/filogakaqu/edit?js,console
If someone has issues with this (I'm not using require.js myself), a PR with an alternative method to load the URL is welcome. For example, you could detect if require.js exists globally and use it to load the URL instead of loadjs.


How will we use to see particular state

how to use this api to see a perticular districts only

Check this documentation :  https://api.covid19india.org/documentation/
The fields in the json are clearly mentioned there. Please use any programming language of your choice to filter particular districts.


Undefined symbols of ungoogled switches

Describe the bug
Switches in the switches namespace are not exported.
Undefined symbols for architecture x86_64:
  "switches::kFingerprintingClientRectsNoise", referenced from:
      (anonymous namespace)::SetRuntimeFeaturesFromCommandLine(base::CommandLine const&)::switchToFeatureMapping in runtime_features.o
      content::RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(base::CommandLine const&, base::CommandLine*)::kSwitchNames in render_process_host_impl.o
  "switches::kFingerprintingCanvasImageDataNoise", referenced from:
      (anonymous namespace)::SetRuntimeFeaturesFromCommandLine(base::CommandLine const&)::switchToFeatureMapping in runtime_features.o
      content::RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(base::CommandLine const&, base::CommandLine*)::kSwitchNames in render_process_host_impl.o
  "switches::kFingerprintingCanvasMeasureTextNoise", referenced from:
      (anonymous namespace)::SetRuntimeFeaturesFromCommandLine(base::CommandLine const&)::switchToFeatureMapping in runtime_features.o
      content::RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(base::CommandLine const&, base::CommandLine*)::kSwitchNames in render_process_host_impl.o
ld: symbol(s) not found for architecture x86_64

To Reproduce
Steps to reproduce the behavior:
Build Chromium using own build process.
Expected behavior
Should not have such errors.
Environment (please complete the following information):

OS/Platform and version: macOS 10.15.3
ungoogled-chromium version: 80.0.3987.132

Using self-compiled LLVM toolchain, not Xcode one.

Additional context
It seems that normal build process has build config //build/config/gcc:symbol_visibility_hidden which adds -fvisibility=hidden flags, causing all symbols to be unexported unless explicitly requested. I had to remove that build config in BUILD.gn to make it compile:
component("switches") {
  sources = [
    "ungoogled_switches.h",
    "ungoogled_switches.cc",
  ]
+  configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
}

Related docs in build/config/gcc/BUILD.gn:
# This config causes functions not to be automatically exported from shared
# libraries. By default, all symbols are exported but this means there are
# lots of exports that slow everything down. In general we explicitly mark
# which functions we want to export from components.
#
# Some third_party code assumes all functions are exported so this is separated
# into its own config so such libraries can remove this config to make symbols
# public again.
#
# See http://gcc.gnu.org/wiki/Visibility
config("symbol_visibility_hidden") {
  cflags = [ "-fvisibility=hidden" ]

  # Visibility attribute is not supported on AIX.
  if (current_os != "aix") {
    cflags_cc = [ "-fvisibility-inlines-hidden" ]
    cflags_objcc = cflags_cc
  }
}

Hmm I wonder why this issue doesn't occur in any of our Linux platforms?

I'm also not sure and it seems other macOS builds are not encountering this issue, however from the doc it does seem that removing that flag should be needed as I'm not seeing ungoogled switches are explicitly exported...

btw, I was checking libswitches.dylib when it happens and those switches were indeed not exported (s instead of S in nm output).

In that case it's probably that different build configurations lead to different shared libraries. We should follow the Chromium convention here and fix the exports as you suggested.


Fixed bootstrap_nodes taken from profile must be deleted as custom bootstrap_nodes loaded

Coverage increased (+0.001%) to 49.003% when pulling 2832a03668bc26ba540045e62070b8e0d1bc285b on RomanZacharia:develop into cd0aef920ce537287af0f8949fde03c0d97c019b on ethereum:develop.

@heikoheiko Do I need to fix these "buildbot/Linux PyEthApp PRs" failed checks or the PR can still be puled?


Admissions trial review:- module 1

Admissions trial  milestone in module 1:-
this milestone includes 👍
Add the index page to the admissions trial
Add the styles to the form page
Add attribution  note  and acknowledgment

STATUS: APPROVED ✅

Hi @yesuf023 , 🥰

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights
✅ ... Good github inline comment
✅ ... Polite communication with the student

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me(@joskalenda) in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Error reporting dialog could not be instantiated

Saw a situation where the error reporting dialog could not be instantiated. It came about after an ArrayIndexOutOfBoundsException on the Payments table after clicking Row 0. I could not get it to repeat.
The fallback dialog appeared but didn't provide much information that the user could relay back to us.
This issue covers additional work to harden the error reporting dialog.

I couldn't repeat the error so I'm happy for this to be closed once all other issues have been closed in preparation for release.
Marking as awaiting issue to force a delay in closing.

In all my testing since I've not seen a recurrence of this so I'm closing it.


Fix useful_array when unaligned and dtype > 1 byte

This fix the function useful_array when unaligned and dtype's size is 2 or more bytes. See the added test that fails with previous' function.
The issue is that the current fonction crops the numpy array using sizes in bytes instead of in number of array elements. When dtype is not a byte, the wrong cropping occurs.
There are several way to fix the function, such as expressing total_line_size and useful_line_size in number of elements instead of bytes. I choose to crop the numpy array in bytes before reinterpreting it in dtype.

This looks like a good catch, thanks! Let's let CI run but I'm happy with the changes, especially as they come with a unit test

Can you merge this please? I have another PR that depends on this :P

Merged, thanks! I am swamped with work ATM so I have great trouble keeping up with PyAV + aiortc + aioquic + etc..