Issues about Positional Embedding and Reference Point

Hi, thanks for sharing your wonderful work.
I got a question in here, https://github.com/Atten4Vis/ConditionalDETR/blob/ead865cbcf88be10175b79165df0836c5fcfc7e3/models/transformer.py#L33
which embedes positional information in the query_pos.
however, I don't understand the reason why does 2*(dim_t//2) has to be devided by 128, instead of the actual dimension pos_tensor has (e.g., 256 by default).
https://github.com/Atten4Vis/ConditionalDETR/blob/ead865cbcf88be10175b79165df0836c5fcfc7e3/models/transformer.py#L38
Is it works correctly even dim_t is divided by 128?
I would appreciate to be corrected !
And another question is,
when we do the calculation of the equation (1) in the paper,
https://github.com/Atten4Vis/ConditionalDETR/blob/ead865cbcf88be10175b79165df0836c5fcfc7e3/models/conditional_detr.py#L89
can I understand that the model would learn "offsets" from the corresponding reference points?
what is precise role of the reference points?
Thank you!

I have the same question about the dim_t that is divided by "128" in Line 38, I agree "256" may be reasonable since the hidden_dim is "512", any special design here？
Looking forward to your reply.

Hi, for question (1), why does 2*(dim_t//2) has to be devided by 128, since the position embedding performs on both the x and y direction, then concat.


context-fill inconsistent with browser rendering

Test SVG
<svg width="100mm" height="100mm" viewBox="0 0 100 100" version="1.1" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg" >
   <defs>
      <pattern patternUnits="userSpaceOnUse" width="2" height="2" viewBox="0 0 2 2" id="circular-pattern">
         <circle fill="#117611" stroke="none" id="circle-in-pattern" cx="1" cy="1" r="1" />
      </pattern>
      <marker orient="auto" id="test-marker" refX="0" refY="1" markerWidth="10"
         markerHeight="10" viewBox="0 0 2 2" preserveAspectRatio="xMidYMid">
         <rect x="0" y="0" width="2" height="2" fill="context-fill" fill-rule="evenodd" stroke="none" />
      </marker>
   </defs>
   <path fill="url(#circular-pattern)" stroke="#ff0000" stroke-width="1" marker-end="url(#test-marker)" d="M 25,50 H 75" id="test-path" />
</svg>

Output
I'm not sure which rendering is correct.

Please test with Chrome 126.0.6425.0 or above, they just fixed an issue.

This SVG also renders differently in the three engines, so it could be a similar issue.

Will take a look.

Oh yeah, looks like we don't reverse the viewbox transform of the marker...

Classic SVG. No one was able to figure out what the spec suppose to mean.
librsvg for the reference:

Safari, Inkscape and Batik do not support context-fill with pattern at all.

@LaurenzV Which rendering do you think is correct regarding the first test case?

The Chrome one is correct.


Compilation error under node 17

Some APIs were changed or removed in node v17, better-sqlite3 requires uodate.
Temp\prebuild\node\17.0.0\include\node\v8-persistent-handle.h(10,10): fatal error C1083: Cannot open include file: 'v
8-weak-callback-info.h': No such file or directory (compiling source file ..\src\better_sqlite3.cpp) [d:\downloads\package\build\better_sqlite3.vcxproj]

This appears to be a bug in Node.js, not better-sqlite3
https://github.com/nodejs/node/pull/40526

Yes, fixed in node v17.0.1.


Guided remediation: Interactive mode TUI

The final part to open source :tada:
I really want to spend some time refactoring all of this, but it's probably better to get this out there sooner rather than later.
To help with reviewing, the first commit (e3669953445e7744b08dc079f92d3fc990150296) is basically a direct copy-paste from the internal code, with things only renamed to the new counterparts in osv-scanner - it should all already have been reviewed. You can see new things to review by comparing the other commits against that first one.

Codecov Report
Attention: 1929 lines in your changes are missing coverage. Please review.

Comparison is base (ef3a2a4) 71.79% compared to head (1388a9d) 58.62%.

Files
Patch %
Lines

cmd/osv-scanner/fix/state-relock-result.go
0.00%
390 Missing :warning:

cmd/osv-scanner/fix/state-choose-strategy.go
0.00%
258 Missing :warning:

cmd/osv-scanner/fix/state-in-place-result.go
0.00%
202 Missing :warning:

internal/tui/vuln-info.go
0.00%
162 Missing :warning:

internal/tui/dependency-graph.go
0.00%
145 Missing :warning:

cmd/osv-scanner/fix/model.go
0.00%
141 Missing :warning:

internal/tui/vuln-list.go
0.00%
121 Missing :warning:

...d/osv-scanner/fix/state-choose-in-place-patches.go
0.00%
112 Missing :warning:

internal/tui/in-place-info.go
0.00%
98 Missing :warning:

internal/tui/relock-info.go
0.00%
86 Missing :warning:

... and 10 more

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #811       +/-   ##
===========================================
- Coverage   71.79%   58.62%   -13.18%
===========================================
  Files         118      132       +14
  Lines        8677    10602     +1925
===========================================
- Hits         6230     6215       -15
- Misses       2078     4013     +1935
- Partials      369      374        +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Codecov Report
Attention: 1929 lines in your changes are missing coverage. Please review.

Comparison is base [(ef3a2a4)](https://app.codecov.io/gh/google/osv-

It's basically impossible to end-to-end test this so I don't think I there's anything I can easily do to avoid this large drop in coverage...


nerdctl compose up

e.g.,
$ nerdctl compose -f ./examples/compose-wordpress/docker-compose.yaml up

YAML:
version: '3.1'

services:

  wordpress:
    image: wordpress:5.7
    restart: always
    ports:
      - 8080:80
    environment:
      WORDPRESS_DB_HOST: db
      WORDPRESS_DB_USER: exampleuser
      WORDPRESS_DB_PASSWORD: examplepass
      WORDPRESS_DB_NAME: exampledb
    volumes:
      - wordpress:/var/www/html

  db:
    image: mariadb:10.5
    restart: always
    environment:
      MYSQL_DATABASE: exampledb
      MYSQL_USER: exampleuser
      MYSQL_PASSWORD: examplepass
      MYSQL_RANDOM_ROOT_PASSWORD: '1'
    volumes:
      - db:/var/lib/mysql

volumes:
  wordpress:
  db:

nerdctl compose up --build is not implemented yet. Will be implemented in a separate PR later.

Thanks for reviewing @fuweid , updated


Indirectly changing values within switch cases causes an 'unintentional comparison' error

🔎 Search Terms
switch, case, indirect, unintentional, comparison, change, equality, update, modify, if
🕗 Version & Regression Information
This is the behavior in every version I tried, and I could not find FAQ entries related to the issue.
⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.0-beta#code/DYUwLgBAHhC8EFYDcAoAZgVwHYGMwEsB7LCHACwEMsBzEAfSgAoBKCAb2jggEYAmJCAF8UKAM4B3fGHKMorNighLSFUSEQAuRcp3kqtBi1TadS-Gllx4feRAD0AKggA6VxAd2hKQUA
💻 Code
let x = 5;
function change_x() { x = 12; }

switch(x) {
    case 5:
        change_x();

        if(x == 12) { /* ... */ }
}

🙁 Actual behavior
bug.ts:8:12 - error TS2367: This comparison appears to be unintentional because the types '5' and '12' have no overlap.

8         if(x == 12) { /* ... */ }
             ~~~~~~~

This error should not show when compiling as x is set to 12 when calling the change_x function.
🙂 Expected behavior
It is expected that there is no error given when compiling.
Additional information about the issue
This can be navigated around by introducing a second variable before the switch statement.
let x = 5;
function change_x() { x = 12; }

let y = x; // here
switch(y) {
    case 5:
        change_x();

        if(x == 12) { /* ... */ }
}

This code no longer produces an error in the latest version
see playground

Duplicate of #9998.


Time measurement: scale line + scale view mode

two view modes: 1) left-aligned; 2) bars in the scope of the scale
for more 2 should be implemented scale and position cursor

done with 2.5.1


Adding Roku hub and remote

Description:
Add a base Roku component, add a remote/Roku component, and update the media_player/Roku component to match.
An added update is changing the Roku platform initialization to async calls.
Most of the credit here goes to @alandtse for his initial attempt on #12542. Hopefully I have more free-time to be able to get this across the finish line :)
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6944
Example entry for configuration.yaml (if applicable):
roku:
    host: <IP_ADDRESS>

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Docs PR has been opened.

I know that there are a lot of Hacktoberfest PRs and probably not enough reviewers to go around, but is there something I can do to get this reviewed faster? :)

Ok to merge when build passes


[BACKLOG-11726] Not able to create a Database Repository connection-f…

…ixed all bugs associated with this
@mdamour1976 @bmorrise @pamval @dkincade @kcruzada

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -B -fn -DrunITs=true -f plugins/repositories-plugin/pom.xml clean install && mvn -B -f plugins/repositories-plugin/pom.xml site

Cleanup Commands
mvn -B -f plugins/repositories-plugin/pom.xml build-helper:remove-project-artifact

Changed files
  plugins/repositories-plugin/src/main/resources/web/js/controllers.js

@dkincade
Jira: http://jira.pentaho.com/browse/BACKLOG-11726
Master PR: https://github.com/pentaho/pentaho-kettle/pull/3059


Fix budget to zero feature

Feature works for me after little fixes.

:+1: Works for me! Thanks for the fix, I saw the typo and considered making my own PR just for that.

Thank you!

Oops! This is what happens when I copypasta chunks of code...


Add checksumming to Citrix downloads

The installer archives for Workspace and HDX-RTME are downloaded from Citrix's site using wget, but currently there is no integrity check. The download checksums should be verified.

If #6 is implemented, this enhancement becomes unnecessary.


Volume Mounts issue

I am trying to setup volume mounts using Kubernetes patch specifications. Unfortunately after applying it ,I noticed errors in operator pod logs.
I created PV and PVC separately and the setup of Persistent volume and claim looks fine. I tested out this with another pod.
When I refer the same as below , it fails.
kubernetesPodTemplateSpecPatches: |
    - op: add
      path: /spec/volumes
      value:
        - name: "demoplanning"
          azureFile:
            secretName: demo-azure-secret
            shareName: demoplanningdata
            readOnly: false
    - op: add
      path: /spec/containers/0/volumeMounts
      value:
        - mountPath: "/mnt/azure"
          name: "demoplanning"

I do see during shinyproxy pod creation it detecting the volume correctly but below error throws up and shinyproxy is deployed as vanilla installation. Funnily I can access shinyproxy (vanilla installation) but none of customisations like authentication and new containers get applied.
pool-1-thread-1] WARN  e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] Updating latest marker to c28a3f90feed4054d3667bb849cc8e800a33ef15, status: ShinyProxyStatus(instances=[ShinyProxyInstance(hashOfSpec=a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a, isLatestInstance=true), ShinyProxyInstance(hashOfSpec=c28a3f90feed4054d3667bb849cc8e800a33ef15, isLatestInstance=false)])
java.lang.Throwable: null
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController.updateLatestMarker(ShinyProxyController.kt:207)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController.reconcileSingleShinyProxyInstance(ShinyProxyController.kt:272)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController$receiveAndHandleEvent$2.invokeSuspend(ShinyProxyController.kt:106)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController$receiveAndHandleEvent$2.invoke(ShinyProxyController.kt)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController.receiveAndHandleEvent(ShinyProxyController.kt:117)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController.run(ShinyProxyController.kt:67)
        at eu.openanalytics.shinyproxyoperator.controller.ShinyProxyController$run$1.invokeSuspend(ShinyProxyController.kt)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:122)
        at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:111)
        at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:308)
        at kotlinx.coroutines.CancellableContinuationImpl.completeResume(CancellableContinuationImpl.kt:395)
        at kotlinx.coroutines.channels.AbstractChannel$ReceiveElement.completeResumeReceive(AbstractChannel.kt:872)
        at kotlinx.coroutines.channels.ArrayChannel.offerInternal(ArrayChannel.kt:83)
        at kotlinx.coroutines.channels.AbstractSendChannel.send(AbstractChannel.kt:133)
        at eu.openanalytics.shinyproxyoperator.controller.ResourceListener.enqueueResource(ResourceListener.kt:78)
        at eu.openanalytics.shinyproxyoperator.controller.ResourceListener$1$onUpdate$2.invokeSuspend(ResourceListener.kt:50)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at eu.openanalytics.shinyproxyoperator.controller.ResourceListener$1.onUpdate(ResourceListener.kt:50)
        at eu.openanalytics.shinyproxyoperator.controller.ResourceListener$1.onUpdate(ResourceListener.kt:42)
        at io.fabric8.kubernetes.client.informers.cache.ProcessorListener$UpdateNotification.handle(ProcessorListener.java:107)
        at io.fabric8.kubernetes.client.informers.cache.ProcessorListener.run(ProcessorListener.java:57)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
        at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.base/java.lang.Thread.run(Unknown Source)
14:14:22.523 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/global] Trying to update status (attempt 1/5)
14:14:22.539 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/global] Status successfully updated
14:14:22.539 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 5/6: Ok] [Status/LatestMarker]
14:14:22.540 [ool-13-thread-1] DEBUG e.o.s.controller.ShinyProxyListener  - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Event/Update]
14:14:22.589 [pool-1-thread-1] DEBUG e.o.s.i.skipper.IngressController    - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Component/Ingress] Reconciling
14:14:22.623 [pool-1-thread-1] DEBUG e.o.s.ingress.skipper.IngressFactory - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Component/Ingress] Created sp-shinyproxy-ing-a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a [latest=false]
14:14:22.623 [pool-1-thread-1] DEBUG e.o.s.i.skipper.IngressController    - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Component/Ingress] Reconciling
14:14:22.634 [pool-1-thread-1] DEBUG e.o.s.ingress.skipper.IngressFactory - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Component/Ingress] Created sp-shinyproxy-ing-c28a3f90feed4054d3667bb849cc8e800a33ef15 [latest=true]
14:14:22.634 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 6/6: Ok] [Component/Ingress]
14:14:22.650 [pool-1-thread-1] INFO  e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 0/6: Ok] ReconcileSingleShinyProxy
14:14:22.650 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 1/6: Ok] [Component/ConfigMap]
14:14:22.650 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 2/6: Ok] [Component/ReplicaSet]
14:14:22.650 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 3/6: Ok] [Component/ReplicaSet] ReplicaSet ready
14:14:22.650 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 4/6: Ok] [Component/Service]
14:14:22.650 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 5/6: Ok] [Status/LatestMarker]
14:14:22.656 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 6/6: Ok] [Component/Ingress]
14:14:22.663 [pool-1-thread-1] INFO  e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 0/6: Ok] ReconcileSingleShinyProxy
14:14:22.663 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 1/6: Ok] [Component/ConfigMap]
14:14:22.663 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 2/6: Ok] [Component/ReplicaSet]
14:14:22.663 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 3/6: Ok] [Component/ReplicaSet] ReplicaSet ready
14:14:22.663 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 4/6: Ok] [Component/Service]
14:14:22.664 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 5/6: Ok] [Status/LatestMarker]
14:14:22.669 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/a5f70bedbb2eba4683e6c0a96a4e69777a0d1b2a] [Step 6/6: Ok] [Component/Ingress]
14:14:22.675 [pool-1-thread-1] INFO  e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 0/6: Ok] ReconcileSingleShinyProxy
14:14:22.675 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 1/6: Ok] [Component/ConfigMap]
14:14:22.675 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 2/6: Ok] [Component/ReplicaSet]
14:14:22.675 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 3/6: Ok] [Component/ReplicaSet] ReplicaSet ready
14:14:22.675 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 4/6: Ok] [Component/Service]
14:14:22.675 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 5/6: Ok] [Status/LatestMarker]
14:14:22.690 [pool-1-thread-1] DEBUG e.o.s.c.ShinyProxyController         - [shinyproxy/shinyproxy/c28a3f90feed4054d3667bb849cc8e800a33ef15] [Step 6/6: Ok] [Component/Ingress]

Hi @anoop7181
Thanks for your interest in the operator. The error/stacktrace you are getting, is not an error, we purposely added an extra log statement in order to debug a possible bug. However, in Java/Kotlin you'll have to use a fake exception in order to log a stacktrace (see: https://github.com/openanalytics/shinyproxy-operator/blob/develop/src/main/kotlin/eu/openanalytics/shinyproxyoperator/controller/ShinyProxyController.kt#L207 (the actual comment is wrong..)). I understand this is confusing, so I'll adapt the statement before our first release.
Regarding your main issue: the problem is (probably) in your patch. What your patch currently is doing is "at the /spec/volumes path, add an array with a single value name: "demoplanning", ...". In other words, you are replacing the existing volumes array with a new array, which only contains the value you provided in your patch. Therefore, the configmap created and mounted by the Operator is removed from the list. This is the exact reason why you now see that ShinyProxy is using the default configuration. You can adapt your patch, so that it appends your element to the list of volumes:
kubernetesPodTemplateSpecPatches: |
    - op: add
      path: /spec/volumes/-
      value:
          name: "demoplanning"
          azureFile:
            secretName: demo-azure-secret
            shareName: demoplanningdata
            readOnly: false
    - op: add
      path: /spec/containers/0/volumeMounts/-
      value:
         mountPath: "/mnt/azure"
          name: "demoplanning"

I hope this helps!

Thank you so much @LEDfan .  I copied the syntax from the documentation below https://shinyproxy.io/documentation/configuration/#kubernetes
Now it works and I see the volumes being mounted. Currently these volumes are mounted on the proxy container. Can you please let me know how can I get it mounted on to shiny app container.

Got it working but adding respective Kubernetes-pod-patches template into the container specs. The syntax is different from KubernetesPodTemplateSpecPatches.
For container spec pod template patch , used below syntax
`- id: 01_hello_manifests_espression
container-specs:

image: "openanalytics/shinyproxy-demo"
cmd: ["R", "-e", "shinyproxy::run_01_hello()"]
port-mapping:
default: 3838
kubernetes-pod-patches: |

op: add
path: /spec/containers/0/env/-
value:
name: PROXY_ID
value: "#{proxy.id}"
op: add
path: /spec/volumes
value:

name: "home-dir-pvc-#{proxy.userId}"
persistentVolumeClaim:
claimName: "home-dir-pvc-#{proxy.userId}"

op: add
path: /spec/containers/0/volumeMounts
value:

mountPath: "/home/#{proxy.userId}"
name: "home-dir-pvc-#{proxy.userId}"`

@LEDfan  Thank you for the Operator. It has helped me ease the deployment on AKS.

Great that you found the correct configuration options! Good to know that the operator works on AKS as well and that it is useful to your.
I'm closing this issue now, feel free to open a new one if you encounter any issue!


Fix broken link in Host Application email

Broken link reported on Slack.
Depends on https://github.com/opencollective/opencollective-frontend/pull/9402
Updates the link in collective.apply.for.host email template.

Would be great if we can have the frontend backward-compatible, to make sure links sent in previous emails still work

Would be great if we can have the frontend backward-compatible, to make sure links sent in previous emails still work

@Betree thanks for the review! Fixed the comments and updated the frontend PR to be fully backwards compatible.


[Bug] Unhandled Thrown Error!

Just tried to play with demo examples and throw this error:
Unhandled Thrown Error!
Failed to fetch dynamically imported module: https://react-resizable-panels.vercel.app/dist.369669ea.js

Works fine for me 🤷🏼♂

maybe it was local issue sorry for that

No worries :)


Add example csv files for phantompeakqualtools

Thanks @chuan-wang! How are these generated?

@ewels With the custom R script in the nextflow pipeline.

OK, sorry I missed that comments. I will look into it next week. Do you
have any example module in which there is custom R scripts associated?
On Fri, Aug 17, 2018 at 4:23 PM, Phil Ewels<EMAIL_ADDRESS>wrote:

Ah, yeah then this shouldn't really be a MultiQC module as only people
using the pipeline will be able to use this (not all users of
phantompeakqualtools). See my comment: https://github.com/nf-core/
chipseq/pull/51/files#r210842311
Because it's generated by a custom R script, not taken directly from the
tool, it shouldn't be in the main MultiQC module. Instead, add headers to
the csv file and take it in as custom content.
Alternatively, put the functionality that's in the R script into the
MultiQC module, then everyone can use it :)
The R script doesn't look very complex, so it should be possible to move
that logic into the MultiQC module so that it runs directly with the .Rdata
files for all phantompeakqualtools users.
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ewels/MultiQC_TestData/pull/101#issuecomment-413882028,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARdKNMNiDXsyExe6MCOEA7wNEJoNZjBQks5uRtHHgaJpZM4WBn4a
.

Ah of course, RData files are easy to load in R and difficult in Python. Looks like there is a package to do this: https://stackoverflow.com/a/21288178/713980
But may be overkill. It's probably better to just make the R script generate custom_content files for MultiQC then.
Let's talk about this next week.

I have edited the code so that a header line is added in the csv file.

Thanks @chuan-wang! I merged just the deepTools commits and removed the phantompeakqualtools commits, now that we're no longer writing a MultiQC module for those.


Add symiirorder2 to cupyx.scipy.signal

See https://github.com/cupy/cupy/issues/7403
Depends on https://github.com/cupy/cupy/pull/7511

/test mini

Do you think it makes sense to have performance comparisons on symiirorder1 and symiirorder2? I know both use lfilter; if possible, I'd like to have them in #7511 and #7518 for reference.


fix(template): replaced custom logic with materialized

This PR is an example on how we could also unify the channels.
But I 'm sure the custom operator is faster.
loc vs maintenance .. opinions?

Why didn't I know about that materialize operator earlier...?
I would add this after line 94 (after tap(cfg.updateObserver) part) to log the error:

catchError(err => {
  console.error(err);
  return EMPTY;
}),

If it basically does what we did with our custom logic, I would keep it. Do you think it would give us trouble in the future?

We will keep it as is :)


Upgrading gson to 2.8.9

Signed-off-by: Vacha<EMAIL_ADDRESS>Description
Upgrading gson to latest 2.8.9 in direct dependency and via hadoop-common.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[X] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌   Gradle Check failure d7b78ba Log 1066
Reports 1066

Tests with failures:
 - org.opensearch.discovery.StableMasterDisruptionIT.testStaleMasterNotHijackingMajority

2632 tests completed, 1 failed, 4 skipped

1> [2021-11-12T16:43:27,115][WARN ][o.o.c.NodeConnectionsService] [node_t2] failed to connect to {node_t1}{sPuJWTDSQC-Dglo7tjZfog}{6VrTsrXIRcaOHwn8m9dFdw}{<IP_ADDRESS>}{<IP_ADDRESS>:43109}{dimr}{shard_indexing_pressure_enabled=true} (tried [1] times)
  1> org.opensearch.transport.ConnectTransportException: [node_t1][<IP_ADDRESS>:43109] connect_exception
  1> 	at org.opensearch.transport.TcpTransport$ChannelsConnectedListener.onFailure(TcpTransport.java:1064) ~[main/:?]
  1> 	at org.opensearch.action.ActionListener.lambda$toBiConsumer$2(ActionListener.java:213) ~[main/:?]
  1> 	at org.opensearch.common.concurrent.CompletableContext.lambda$addListener$0(CompletableContext.java:55) ~[opensearch-core-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2162) ~[?:?]
  1> 	at org.opensearch.common.concurrent.CompletableContext.completeExceptionally(CompletableContext.java:70) ~[opensearch-core-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.SocketChannelContext.connect(SocketChannelContext.java:160) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.EventHandler.handleConnect(EventHandler.java:130) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.transport.nio.TestEventHandler.handleConnect(TestEventHandler.java:139) ~[framework-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.attemptConnect(NioSelector.java:446) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.registerChannel(NioSelector.java:469) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.setUpNewChannels(NioSelector.java:458) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.preSelect(NioSelector.java:279) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.singleLoop(NioSelector.java:172) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.runLoop(NioSelector.java:148) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at java.lang.Thread.run(Thread.java:833) [?:?]
  1> Caused by: java.net.ConnectException: Connection refused
  1> 	at sun.nio.ch.Net.pollConnect(Native Method) ~[?:?]
  1> 	at sun.nio.ch.Net.pollConnectNow(Net.java:672) ~[?:?]
  1> 	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:946) ~[?:?]
  1> 	at org.opensearch.nio.SocketChannelContext.connect(SocketChannelContext.java:157) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	... 9 more

start gradle check

❌   Gradle Check failure d7b78ba Log 1067
Reports 1067

> Task :test:fixtures:s3-fixture:composeUp

ERROR: for 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ec2_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-repositories-metering_1 ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ecs_1              ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-session-token_1    ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-other_1                 ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture_1                       ... done

ERROR: for s3-fixture-with-ec2  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
An HTTP request took too long to complete. Retry with --verbose to obtain debug information.
If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-repositories-metering_1 ...
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ecs_1              ...
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture_1                       ...
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-other_1                 ...
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-session-token_1    ...

start gradle check

❌   Gradle Check failure d7b78ba Log 1068
Reports 1068

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" -Dtests.seed=20C97377870AC21B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=nb -Dtests.timezone=Australia/Sydney -Druntime.java=17

org.opensearch.monitor.fs.FsHealthServiceTests > testFailsHealthOnHungIOBeyondHealthyTimeout FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([20C97377870AC21B:A2BD2D7EF3F6B453]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout(FsHealthServiceTests.java:239)

The test failure from ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" has been reported before, in issue #1307 and #1450.

start gradle check


docs(readme.md): fix project name, link to sub-docs

Is your feature request related to a problem? Please describe.
As a developer reading about Cactus, right now, the readme.md is my main landing page, it contains references to the old project name, and it's not linking to the new markdown documentation that's being generated
Describe the solution you'd like
Update the main readme
Describe alternatives you've considered
Updating our readthedocs directly, but since we are going to automatically pull the information for the markdowns it makes more sense to keep those up to date
Acceptance criteria

[ ] Delete old references
[ ] Improve pointers to other markdown doc files

working on this.

References to other documents are correct.


Security issue

Hi,
From our security analysis tool we found that there is a security threat in below method since AFNetworking  is generating random numbers to add a boundary to multiform data using arc4random.
static NSString * AFCreateMultipartFormBoundary() {
return [NSString stringWithFormat:@"Boundary+%08X%08X", arc4random(), arc4random()];
}
Will it possible to use secure random generation instead of arc4rand.
Thanks

arc4random() is a secure generator, but even if it wasn't, the boundary identifier is not a sensitive value, it's just used to separate the parts of a form.


Allow plugins to be disabled

This introduces a new config value PLUGINS_DISABLE, which is a list of plugins which should not be loaded, despite being discovered successfully.
Default behaviour does not change: if PLUGINS_DISABLE not configured or left empty, all discovered plugins get loaded.
Use-case:
A container image can be produced, shipping multiple plugins, but still giving users control over which ones get actually loaded, or rather: not loaded.

hi @hoegaarden, Why opt-out instead of opt-in? Or in other words why PLUGINS_DISABLE and not PLUGINS_ENABLE?

Don't have a strong opinion on that.
To me it makes slightly more sense to, by default, load all plugins that happen to reside in the plugins directory, but allow users to selectively disable certain plugins.
FWIW, tho probably not super important: this keeps the current default behavior.
But again, no strong opinion.

I prefer to focus on and specify what I need instead of what I do not need. Also, imagine what will happen when you release a new version of your image, with some new plugins bundled. They will be automatically activated. I doubt if that is desired.

/ptal @kbialek


Suppress spacebar keyup for dropdowns

Firefox and Chrome both fire click events when the spacebar is released on a <button>; however, Chrome suppresses this event if preventDefault is called from the keydown handler and Firefox still fires it so it must be explicitly prevented from the keyup as well to get them both working the same.
Alternatively, could change the dropdown to work with the keyup event instead of keydown but I took this approach as it seemed less destructive with existing code.
Fix for issue https://github.com/twbs/bootstrap/issues/21159

Am currently on the road with no access to a properly set-up dev machine. Will review this next week once I'm hopefully back home. Sorry for the delay...

Superseded by https://github.com/twbs/bootstrap/pull/21535


Improved proxyRoute to support ssl and route patterns

This fixes https://github.com/divmain/drydock/issues/11 and https://github.com/divmain/drydock/issues/12
It could still use some tests and documentation before merging, but I probably won't do this until we finish our prototype.  So I thought I would at least push the code and open a PR with the code if anyone wants or needs it.
I was on the fence if letting proxyRoute take a function was overkill but this is its current usage:
 drydock.proxyRoute({
      method: "GET",
      path: "/something/{path*}",
      forwardTo: (request) => `https:/host/something/${request.params.path}`
});

I'm on-board with allowing functions for forwardTo option.  Let me know how this works out for you - I'm happy to merge it in as-is, and add documentation as a later step.

Thanks.  Updated and added to docs.

Looks good, thanks!

Released as part of<EMAIL_ADDRESS>


Create automated LLVM bump action

It would be nice if we had a GitHub action which periodically attempted to bump LLVM, creating a PR that we can just submit on green (or take over and patch). Would be a good way to stay ahead of things and know when big things need attention.

https://github.com/shark-infra/megabump/ (and the bot: https://github.com/shark-infra/megabump/tree/bot) are attempts to solve this. Let's close this issue?


add useMin in props as used in source code

useMin is used to put item in lower column
instead of the next one.

Thank you!


Will there be an update due to set-output command is deprecated?

I like this action but unfortunately it may come to an end if update is not made.
When I run; I get that set-output command is deprecated and will be disabled soon.
Is there a workaround or fix I can apply? TIA
[Setup Dynamic Evnironment Variables](https://github.com/<my_awesome_org>/<my_awesome_repo>/actions/runs/6658302472/job/18094839303#step:4:8)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

~Laith

A fork with the updates: https://github.com/guibranco/github-file-reader-action-v2


Update LICENSE.ASSETS

The wrong license was listed in this file, it should be BY-SA instead of just BY.
@karst and ThatGuyYouKnow have consented to this change. @IntelOrca's consent is still required.
This means that the samples will use the same license as OpenMusic aswell as being able to include other BY-SA licensed samples.
If you wish to know what BY-SA entails you can see that here: https://creativecommons.org/licenses/by-sa/4.0/

@karst and ThatGuyYouKnow have consented to this change.

Just to put this here as well,
I'm okay with the sounds I contributed being under this license.

Is it possible to partially license samples to BY-SA and others to just BY?
@Generalcamo do you know more about this?


Resolve: Add progress bar to run_inference_algorithm

Closes #610. Adds progress bar to run_inference_algorithm.
A few important guidelines and requirements before we can merge your PR:

[ ] If I add a new sampler, there is an issue discussing it already;
[x] We should be able to understand what the PR does from its title only;
[x] There is a high-level description of the changes;
[x] There are links to all the relevant issues, discussions and PRs;
[x] The branch is rebased on the latest main commit;
[x] Commit messages follow these guidelines;
[x] The code respects the current naming conventions;
[x] Docstrings follow the numpy style guide
[x] pre-commit is installed and configured on your machine, and you ran it before opening the PR;
[ ] There are tests covering the changes;
[ ] The doc is up-to-date;
[ ] If I add a new sampler* I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

@junpenglao I am trying to figure out why some of the tests are failing. Also, should I adapt some tests to use the progress_bar?

Looks like there is a flaky test - could you change the rng_key of that test until it pass, and add a comment that it is a flaky test?

@reubenharry found a bug in the function, cause by this line: https://github.com/blackjax-devs/blackjax/blob/540db419f0ccddb0368443049492b6c0448fe273/blackjax/util.py#L174
Could you remove this line and add a test? Something like:
import jax
import jax.numpy as jnp
from blackjax.mcmc.hmc import hmc
from blackjax.util import run_inference_algorithm

def logdensity_fn(x):
    return -0.5 * jnp.sum(jnp.square(x))

alg = hmc(
    logdensity_fn=logdensity_fn,
    inverse_mass_matrix=jnp.eye(2),
    step_size=1.0,
    num_integration_steps=1000,
)

_ = run_inference_algorithm(
    rng_key=jax.random.PRNGKey(0),
    initial_state_or_position=jnp.array([1.0, 1.0]),
    inference_algorithm=alg,
    num_steps=10,
    progress_bar=True)

@junpenglao I think you meant to tag me instead of @reubenharry? But yes definitely!, sorry about that.

test_util.py sounds good.

@junpenglao I have to step away for the rest of the day. Just added a test for run_inference_loop but haven't done anything with the flaky tests yet. I'll be back tomorrow. Thanks for all the help!

The flaky test is not failing now, so I am going to go ahead and merge it. Thanks!


Clean up deprecated ZK metadata keys and methods

Clean up the deprecated keys and methods as planned after releasing 0.9.0.
Also remove the deprecated and unused BackfillSegmentUtils which accesses the deprecated keys.

Codecov Report

Merging #7846 (1e3e010) into master (fc3de45) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7846      +/-   ##
============================================
- Coverage     71.69%   71.62%   -0.07%
  Complexity     4089     4089
============================================
  Files          1579     1579
  Lines         80819    80781      -38
  Branches      12017    12013       -4
============================================
- Hits          57940    57862      -78
- Misses        18971    19023      +52
+ Partials       3908     3896      -12

Flag
Coverage Δ

integration1
29.38% <83.33%> (-0.13%)
:arrow_down:

integration2
27.84% <83.33%> (-0.03%)
:arrow_down:

unittests1
68.69% <100.00%> (+0.02%)
:arrow_up:

unittests2
14.61% <50.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../core/realtime/PinotLLCRealtimeSegmentManager.java
78.97% <ø> (-0.08%)
:arrow_down:

...lix/core/realtime/PinotRealtimeSegmentManager.java
83.76% <ø> (-1.21%)
:arrow_down:

...ot/controller/helix/core/util/ZKMetadataUtils.java
100.00% <ø> (ø)

...manager/realtime/HLRealtimeSegmentDataManager.java
82.79% <ø> (-0.16%)
:arrow_down:

...va/org/apache/pinot/spi/utils/CommonConstants.java
23.63% <ø> (-2.68%)
:arrow_down:

...not/common/metadata/segment/SegmentZKMetadata.java
82.63% <100.00%> (+8.08%)
:arrow_up:

...ntroller/helix/core/PinotHelixResourceManager.java
64.27% <100.00%> (-0.08%)
:arrow_down:

...data/manager/realtime/DefaultSegmentCommitter.java
0.00% <0.00%> (-80.00%)
:arrow_down:

...er/api/resources/LLCSegmentCompletionHandlers.java
43.56% <0.00%> (-18.82%)
:arrow_down:

...data/manager/realtime/SegmentCommitterFactory.java
88.23% <0.00%> (-11.77%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3de45...1e3e010. Read the comment docs.


Syntactically wrong Kusto example

The example code
set query_datascope="hotcache";
T | union U | join (T datascope=all | where Timestamp < ago(365d) on X

Is either missing the closing bracket - closing the one opened in join ( - or the opening bracket after join is wrong.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e81a2cf-15af-04b4-f09b-1ffdda66e4f9
Version Independent ID: f1eeb141-cffa-3d81-3ff7-c586fda1a00f
Content: Cache policy (hot and cold cache) - Azure Data Explorer
Content Source: data-explorer/kusto/management/cachepolicy.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

@chriswue  Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@chriswue, thanks for noticing this. You are correct, it is missing the closing bracket before the word "on". I have opened a PR to fix this in the docs.

#please-close


Multiline REPL option doesn't do anything

Turn on the multiline repl window option in Options.
Try and use multiline repl.

Note that, regardless of the setting, we can still do multiline via Shift-Enter.

Has this ever worked?  If not should we remove it? Or do we have good scenarios for it?

@adamdriscoll


airbnb rule "no-unexpected-multiline" not covered

Hi there,
I ran into a small problem. For the following eslint config:
{
  "extends": ["airbnb-base", "prettier"]
}

and this non-pretty code:
const objectWithFunctions = {
  foo: (value) => Promise.resolve(value)
};

const functionThatReturnsObject = () => objectWithFunctions;

const someVariableThatGivesUsTheKey = 'foo';

functionThatReturnsObject()[someVariableThatGivesUsTheKey]('hello world').then(res => console.log(res))

Prettier outputs the following:
const objectWithFunctions = {
  foo: value => Promise.resolve(value),
};

const functionThatReturnsObject = () => objectWithFunctions;

const someVariableThatGivesUsTheKey = 'foo';

functionThatReturnsObject()
  [someVariableThatGivesUsTheKey]('hello world')
  .then(res => console.log(res));

and ESLint complains with the following:
error  Unexpected newline between object and [ of property access  no-unexpected-multiline

Not sure if this is an issue with the config here or maybe even with Prettier itself. If it's something with the config I could help out with a PR.
Using:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Thanks for your issue! I don't have time to look at this right now. Could you read through #8 in the meantime and see if anything in there helps?

Hey... sorry, completely forgot about this issue. I checked it and no, the rule no-unexpected-multiline was not mentioned in there.

I'm confused ... as far as I can tell the no-unexpected-multiline is mentioned 3 or 4 times in #8?

@lydell So sorry, you are absolutely right. Don't know what I was reading... I'll close this issue


Replace ✔ and ✘ in print() with STRINGS.CHECK_CHAR and STRINGS.CROSS_CHAR

Use constants from constant.py to print ✔ and ❌

@NavpreetDevpuri, I'd like to take this up.


stripe plans empty

I followed the tutorial on the readme and https://dev.to/paul_freeman/adding-payment-to-django-app-4cc9 (I did not overwrite the Django-SAAS-Boilerplate  html and python code with what was on the link). I set my .env to Debug=1 and created the keys for STRIPE_TEST_API_KEY, STRIPE_PUB_TEST_KEY, and STRIPE_WEBHOOK_TEST_API_KEY using stripe. In stripe I created a product and payment link. I also installed the stripe cli and ran the command:
stripe listen --forward-to  http://<IP_ADDRESS>:8000/stripe/webhook/
When I go to the  http://<IP_ADDRESS>:8000/pricing/ page, I do not see my stripe details populated. Could you please let me know if I am missing a step?

Hi @krajan2, did you add the plan details in the admin panel? you are supposed to add the pricing and comma separated.

Thanks! I thought it pulled product/plan details from stripe.


Fix wait for scene textures

render default scene directly after load on android
(without moving manually the map, etc.)
cleaups

I think I also noticed this on osx on master yesterday. Will test this PR.


fix(engine): fail on autostart STREAM or SERVICE

close #121

Reimplemented in #123 removing calls to loop.run_until_complete


follow linux-setup.md can't download server package

curl -s -L https://github.com/SkygearIO/skygear-server/releases/latest | egrep -o '/SkygearIO/skygear-server/releases/download/[v.0-9]*/skygear-server-linux-amd64' | wget --base=http://github.com/ -i - -O skygear
can't download server package.
I got this error:
--2017-06-14 15:05:24--  http://github.com/SkygearIO/skygear-server/releases/download/v0.24.0/skygear-server-linux-amd64
Resolving github.com (github.com)... <IP_ADDRESS>, <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://github.com/SkygearIO/skygear-server/releases/download/v0.24.0/skygear-server-linux-amd64 [following]
--2017-06-14 15:05:26--  https://github.com/SkygearIO/skygear-server/releases/download/v0.24.0/skygear-server-linux-amd64
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-06-14 15:05:28 ERROR 404: Not Found.

@yuchangfu Thanks for reporting the issue! Let me fix that.

@yuchangfu This is fixed! Please check out the updated installation guide.


When I was building the AAR file, it displayed Fetching @maven all the time

OS Platform and Distribution
window10
Compiler version
No response
Programming Language and version
python 3.10.9
Installed using virtualenv? pip? Conda?(if python)
Conda
MediaPipe version
No response
Bazel version
5.3.2
XCode and Tulsi versions (if iOS)
No response
Android SDK and NDK versions (if android)
Android SDK 30 ， NDK 21.3.6528147
Android AAR (if android)
Yes
OpenCV version (if running on desktop)
3.4.10
Describe the problem
When I execute "bazel build -c opt --strip=ALWAYS --action_env PYTHON_BIN_PATH="D:\\Develop\\anaconda3\\python.exe" --fat_apk_cpu=arm64-v8a,armeabi-v7a  Mediapipe/examples/android/SRC/Java/com/Google/mediapipe/apps/build_aar_face: build the aar mediapipe_face_detection," Always get stuck on "Fetching @maven; Resolving and fetching the transitive closure of 29 artifac ", then the following error will appear. Since I am in China now, I have tried to replace the download address of maven in "workspace" as Alibaba Cloud image. I have also tried to use vpn, but neither of these two methods can work. In addition, I have the "activity-1.2.2.aar" file mentioned in the error locally. I am very confused about what is the problem and who can help me

Complete Logs
INFO: Repository maven instantiated at:
  D:/develop/mediapipe1/mediapipe/WORKSPACE:444:14: in <toplevel>
  C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/rules_jvm_external/defs.bzl:105:19: in maven_install
Repository rule coursier_fetch defined at:
  C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/rules_jvm_external/coursier.bzl:1009:33: in <toplevel>
INFO: Repository 'maven' used the following cache hits instead of downloading the corresponding file.
 * Hash 'babba8a144533f041a4de791d32de00552e31fa56231f241560a2ce6a7a72702' for https://github.com/coursier/coursier/releases/download/v2.0.7/coursier.jar
 * Hash '5c0a0a3ea600f302ee458b30317425dd9632d1ad8882259fcaf4e9b868b2b1ef' for https://github.com/stedolan/jq/releases/download/jq-1.6/jq-osx-amd64
 * Hash 'af986793a515d500ab2d35f8d2aecd656e764504b789b66d7e1a0b727a124c44' for https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64
 * Hash 'a51d36968dcbdeabb3142c6f5cf9b401a65dc3a095f3144bd0c118d5bb192753' for https://github.com/stedolan/jq/releases/download/jq-1.6/jq-win64.exe
If the definition of 'maven' was updated, verify that the hashes were also updated.
ERROR: An error occurred during the fetch of repository 'maven':
   Traceback (most recent call last):
        File "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/rules_jvm_external/coursier.bzl", line 862, column 40, in _coursier_fetch_impl
                artifact.update({"sha256": shas[str(repository_ctx.path(file))]})
Error: key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/WORKSPACE:444:14: fetching coursier_fetch rule //external:maven: Traceback (most recent call last):
        File "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/rules_jvm_external/coursier.bzl", line 862, column 40, in _coursier_fetch_impl
                artifact.update({"sha256": shas[str(repository_ctx.path(file))]})
Error: key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face/BUILD:3:14: //mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection_android_lib depends on @maven//:com_google_code_findbugs_jsr305 in repository @maven which failed to fetch. no such package '@maven//': key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face/BUILD:3:14: //mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection_android_lib depends on @maven//:com_google_flogger_flogger in repository @maven which failed to fetch. no such package '@maven//': key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face/BUILD:3:14: //mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection_android_lib depends on @maven//:com_google_flogger_flogger_system_backend in repository @maven which failed to fetch. no such package '@maven//': key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face/BUILD:3:14: //mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection_android_lib depends on @maven//:com_google_guava_guava in repository @maven which failed to fetch. no such package '@maven//': key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: D:/develop/mediapipe1/mediapipe/mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face/BUILD:3:14: //mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection_android_lib depends on @maven//:androidx_lifecycle_lifecycle_common in repository @maven which failed to fetch. no such package '@maven//': key "C:/users/yang dada/_bazel_yang dada/e5li6e5p/external/maven/v1/https/maven.aliyun.com/repository/google/androidx/activity/activity/1.2.2/activity-1.2.2.aar" not found in dictionary
ERROR: Analysis of target '//mediapipe/examples/android/src/java/com/google/mediapipe/apps/build_aar_face:mediapipe_face_detection' failed; build aborted:
INFO: Elapsed time: 28.842s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)

@ShaunMaple,
Closing this as Duplicate of #4641, Please follow up with another issue raised. Thank you!!


Assertion error when updating already existing property of document

Trying to set a key into an FLDict where the key already exists and saving its CBLDocument results in crash:

FAILED PRECONDITION: index<_items.size() not true when calling class fleece::impl::ValueSlot &__cdecl fleece::impl::internal::HeapArray::setting(unsigned int) (at HeapArray.cc line 129)

More details on the forum here:
https://forums.couchbase.com/t/couchbase-lite-c-assertion-error-when-updating-already-existing-property-of-document/27825
To avoid any possible issues with Dart interop, I wrote this simple C program, that has the same error.
I'm using a Windows build based on the latest commit.
#include <stdio.h>
#include "stdbool.h"
#include "CBLDatabase.h"
#include "CBLDocument.h"
#include "CBLBase.h"
#include <fleece/Fleece.h>
#include <fleece/slice.hh>

using namespace fleece;

#ifdef __cplusplus
extern "C" {
#endif

void DocTest(bool firstRun, bool useFix) {
    printf("------Starting DocTest------\n");

    CBLError outError = {};

    CBLDatabaseConfiguration config = {};
    config.directory = "w:/tmp/";
    config.flags = kCBLDatabase_Create;

    CBLDatabase *db = CBLDatabase_Open("cbltestdb", &config, &outError);
    printf(" * dabatase created/opened\n");

    if (firstRun)
    {
      printf("---- First run\n");
      CBLDocument *doc = CBLDocument_New("testdoc");
      CBLDocument_SetPropertiesAsJSON(doc, "{\"dupe\": 1, \"foo\": \"bar\"}", &outError);
      CBLDatabase_SaveDocument(db, doc, kCBLConcurrencyControlLastWriteWins, &outError);
      printf("---- New document created\n");
    }

    printf(" * Reading document:\n");

    CBLDocument *doc1 = CBLDatabase_GetMutableDocument(db, "testdoc");

    FLMutableDict props = CBLDocument_MutableProperties(doc1);

    if (useFix) {
      printf(" * Using fix: reading existing property \n");
      FLDict_Get(props, slice("foo"));
    }

    FLSlot sl = FLMutableDict_Set(props, slice("dupe"));
    FLSlot_SetInt(sl, 2);

    printf(" * document slot was set\n");

    CBLDatabase_SaveDocument(db, doc1, kCBLConcurrencyControlLastWriteWins, &outError);
    printf(" * document was saved\n");

    CBLDatabase_Close(db, &outError);
    printf(" * database closed\n");
}

int main()
{
  DocTest(true, false);
  DocTest(false, true);
  DocTest(false, false);

  return 0;
}

#ifdef __cplusplus
}
#endif

My CMakeList.txt if it can be useful - mostly stuff copied from the couchbaselite's cmakelist
cmake_minimum_required (VERSION 3.1)
cmake_policy(VERSION 3.1)

project (cbltest)

set(COMPILE_FLAGS   "${COMPILE_FLAGS}   -Wall -Werror")
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_C_STANDARD_REQUIRED ON)
set(CMAKE_C_STANDARD 11)

include_directories("w:/projects/couchbase-lite-C_win/include/cbl/"
                    "w:/projects/couchbase-lite-C_win/vendor/couchbase-lite-core/C/include"
                    "w:/projects/couchbase-lite-C_win/vendor/couchbase-lite-core/LiteCore/C"
                    "w:/projects/couchbase-lite-C_win/vendor/couchbase-lite-core/LiteCore/Support"
                    "w:/projects/couchbase-lite-C_win/vendor/couchbase-lite-core/vendor/fleece/API"
                    "w:/projects/couchbase-lite-C_win/vendor/couchbase-lite-core/vendor/fleece/Fleece/Support")

link_directories("w:/projects/cbltest/")

add_executable(cbltest main.cc)

TARGET_LINK_LIBRARIES(cbltest CouchbaseLiteC)

The output:
> w:\projects\cbltest\Debug>cbltest
> ------Starting DocTest------
> 20:00:00.412552| [DB]: {DB#1}==> class litecore::SQLiteDataFile w:/tmp\cbltestdb.cblite2\db.sqlite3 @00000242C6EBBF60
> 20:00:00.415818| [DB]: {DB#1} Opening database
>  * dabatase created/opened
> ---- First run
> ---- New document created
>  * Reading document:
>  * document slot was set
>  * document was saved
> 20:00:00.445484| [DB]: {DB#1} Closing database
>  * database closed
> ------Starting DocTest------
> 20:00:00.447292| [DB]: {DB#2}==> class litecore::SQLiteDataFile w:/tmp\cbltestdb.cblite2\db.sqlite3 @00000242C6F08F90
> 20:00:00.449754| [DB]: {DB#2} Opening database
>  * dabatase created/opened
>  * Reading document:
>  * Using fix: reading existing property
>  * document slot was set
>  * document was saved
> 20:00:00.469395| [DB]: {DB#2} Closing database
>  * database closed
> ------Starting DocTest------
> 20:00:00.471999| [DB]: {DB#3}==> class litecore::SQLiteDataFile w:/tmp\cbltestdb.cblite2\db.sqlite3 @00000242C6EBAAD0
> 20:00:00.475064| [DB]: {DB#3} Opening database
>  * dabatase created/opened
>  * Reading document:
>  * document slot was set
> FAILED PRECONDITION: `index<_items.size()` not true when calling class fleece::impl::ValueSlot &__cdecl fleece::impl::internal::HeapArray::setting(unsigned int) (at HeapArray.cc line 129)

I have tested this with the current code in master branch, and I couldn't reproduce the issue. Please try this gain and if the issue still exists, we can reopen this issue.
Code that I test:
TEST_CASE_METHOD(DatabaseTest, "Issue-87") {
    CBLError outError;
    CBLDocument* doc1 = CBLDocument_CreateWithID("testdoc"_sl);
    REQUIRE(doc1);
    CBLDocument_SetJSON(doc1, "{\"dupe\": 1, \"foo\": \"bar\"}"_sl, &outError);
    CHECK(CBLDatabase_SaveDocument(db, doc1, &outError));
    CBLDocument_Release(doc1);

    doc1 = CBLDatabase_GetMutableDocument(db, "testdoc"_sl, &outError);
    REQUIRE(doc1);
    FLMutableDict props = CBLDocument_MutableProperties(doc1);
    FLSlot sl = FLMutableDict_Set(props, slice("dupe"));
    FLSlot_SetInt(sl, 2);
    CHECK(CBLDatabase_SaveDocument(db, doc1, &outError));
    CBLDocument_Release(doc1);

    doc1 = CBLDatabase_GetMutableDocument(db, "testdoc"_sl, &outError);
    REQUIRE(doc1);
    props = CBLDocument_MutableProperties(doc1);
    sl = FLMutableDict_Set(props, slice("dupe"));
    FLSlot_SetInt(sl, 2);
    CHECK(CBLDatabase_SaveDocument(db, doc1, &outError));
    CBLDocument_Release(doc1);
}

Run only the second block, the document should exists in the database, with the fields that you are trying to change already set. It should be the first operation.
I actually get random messges and crashes, but the most common is when saving the document.

ERROR: Function CBLDatabase_SaveDocumentWithConcurrencyControl() failed: LiteCore CorruptRevisionData, "Document key is not properly encoded"

I use a dummy read like FLDict_Get(props1, FLSTR("test")); that fixes the issue. The read doesn't even have to be on the same property, and it's enough once for the duration of the whole script. See example below. I believe creating the document and CBLDocument_SetJSON does the same trick, which is why you don't see the error.
    CBLDocument* doc2 = CBLDatabase_GetMutableDocument(db, FLSTR("testdoc20"), outError);
    FLMutableDict props1 = CBLDocument_MutableProperties(doc2);

    // FLDict_Get(props1, FLSTR("test")); // workaround

    FLSlot sl1 = FLMutableDict_Set(props1, FLSTR("dupe"));
    FLSlot_SetString(sl1, FLSTR("12"));
    CBLDatabase_SaveDocument(db, doc2, outError);
    printf(allocCString((FLSlice)CBLDocument_CreateJSON(doc2)));
    CBLDocument_Release(doc2);

    CBLDocument* doc3 = CBLDatabase_GetMutableDocument(db, FLSTR("testdoc20"), outError);
    FLMutableDict props = CBLDocument_MutableProperties(doc3);
    FLSlot sl = FLMutableDict_Set(props, FLSTR("dupe"));
    FLSlot_SetString(sl, FLSTR("13"));
    CBLDatabase_SaveDocument(db, doc3, outError);
    printf(allocCString((FLSlice)CBLDocument_CreateJSON(doc3)));
    CBLDocument_Release(doc3);


Tensorflow 2.0

Congratulations for this work. This library is unfortunately incompatible with TensorFlow 2.0, as well as the usage examples. Are then any plans to release a version which supports TF2 in the future?

@JivanRoquet I'm not planning to do that, but others are working one it, this is a TF 2 version forked from here https://github.com/atomicbits/posenet-python. ... it also includes support for the more recent/better ResNet50 based models
There are some comments and bechmark #s posed by the author in an issue here #14


Travis Failing

Travis is currently failing for all PRs with:
Finished in 5.076543s, 643.7452 runs/s, 1286.5054 assertions/s.
  1) Failure:
Casks::copay#test_0001_passes audit [/usr/local/Library/Taps/caskroom/homebrew-versions/test/Casks/compliance_test.rb:9]:
[copay] Cask audit must be error free.
--- expected
+++ actual
@@ -1 +1 @@
-[]
+["cannot use the sha256 for an empty string: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"]

Should be fixed.


typing non-ascii (korean) in search box (databrowser) is buggy

Describe the bug
when I type 한글 it is typed something like as ㅎㅏㄴㄱ-ㄹ
Dejavu Version
Your version of Dejavu and how you're running it: Web, Chrome Extension or as a Docker Image.
3.4.3
running locally
To Reproduce
Steps to reproduce the behavior:
databrowser
type non ascii character
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
I tried to track down where the bug is,
thought downshift might be the cause but it doesn't seem to
(I could type 한글 correctly in their sample sandbox https://codesandbox.io/s/simple-downshift-with-getrootprops-example-24s13)

I'd like to try newest reactivesearch with newest downshift and somehow it's hard to do that.. can you help me ?

I made a pull request, although it fails for some reason :(
https://github.com/appbaseio/reactivesearch/pull/1423


Dotnet Core Worker fails to start when MassTransit.Prometheus reference added

Is this a bug report?
Yes
Can you also reproduce the problem with the latest version?
Yes I'm using the latest version
Environment

Dotnet version: 5.0.202
Operating system: MacOS BigSur
IDE (Rider, VS Code, Visual Studio):  Rider

Steps to Reproduce

Create new dotnet core console application using generic host
Add reference to MassTransit.Prometheus
Add UsePrometheusMetrics to MassTransit configuration
Run application which then throws:

System.MissingMethodException: Method not found: 'MassTransit.Scoping.IConsumerScopeContext MassTransit.Scoping.IConsumerScopeProvider.GetScope(MassTransit.ConsumeContext)'.
   at MassTransit.ExtensionsDependencyInjectionIntegration.Registration.ServiceCollectionBusConfigurator.<>c.<AddMassTransitComponents>b__10_1(IServiceProvider provider)

Note: Package works as expected in an aspnet core application
Expected Behavior
Expect a dotnet console application configured with MassTransit Prometheus to work and report metrics as it does for an aspnet core application.
Actual Behavior
Throws exception as mentioned above. Exception is throw even without cfg.UsePrometheusMetrics(); when MassTransit.Prometheus package is added
Reproducible Demo
There is a sample project here
When adding the MassTransit prometheus integration to the project it fails, however the same configuration in the API project within the same solution works.

You have an assembly version mismatch, not an MassTransit problem.


added option to replace ambiguous characters

as in title, this option replaces similar characters to their closest ASCII equivalent
for example:
𝙎 -> s
𝘽 -> b
Drake - WizKid Kyla - One Dance (𝙎𝙇𝙊𝙒𝙀𝘿 + 𝙍𝙀𝙑𝙀𝙍𝘽) -> drake-wizkid-kyla-one-dance-slowed-reverb
before:
𝙎 ->
𝘽 ->
Drake - WizKid Kyla - One Dance (𝙎𝙇𝙊𝙒𝙀𝘿 + 𝙍𝙀𝙑𝙀𝙍𝘽) -> drake-wizkid-kyla-one-dance
full list: https://pastebin.com/yY9UmByb
based on the: https://github.com/hediet/vscode-unicode-data/

Looks good, please rename, prune and re-push.  Thx

Hi there. Thanks a lot for taking the time to put a PR together with this contribution!
Something that would be awesome to see in PRs, in general, is the rationale behind the proposed changes. It helps make the subsequent discussion much more fruitful.
That would be my first question here. What problem took you to this change?
I'll add another:

Is there any advantage of this approach over adding the additional replacement as an after-step of the slugification. I mean, what if you use the list of ambiguous characters and run the same replacement after the slug is created with this library?

0 Something that would be awesome to see in PRs, in general, is the rationale behind the proposed changes. It helps make the subsequent discussion much more fruitful.

I've felt that it would be a good change to add this since the current version just removes ambiguous characters.
In my opinion the intended behaviour should be to replace them with the closest ASCII equivalent the same way Cyrillic, asian, greek characters, etc are being processed.

1.1 Also, the linked repo quoted as the source does not have a readme, which leaves me with more questions about this list of replacements, and since you are also the owner there, please allow me:

I am not the owner of that repo, I've found it by accident. I've noticed that VS Code suggests replacements for ambiguous characters so I've checked the source code and that led me to that repo.

2.1 What is the source of the list?

From what I've check it's based on the official Confusable characters dataset from unicode org and some manually added ones https://github.com/hediet/vscode-unicode-data/blob/main/data/README.md

2.2 If it is manually curated, what is your process to decide on the replacements that get added or not?

2.1

2.2 How might we ensure the copy you are bringing in the PR is in sync?

This list shouldn't change that often. Unicode Standard is updated once a year, but it mostly brings new emojis and scripts (ex. Nag Mundari) which shouldn't affect
Unicode standard 8 released in 2015: 6069 characters
Unicode standard 12 released in 2019: 6296 characters
Unicode standard 13 released in 2020: 6311 characters <- no new updates from 2020, only 15 new characters added in 2020
Unicode standard 14 released in 2021: 6311 characters
Unicode standard 15 released in 2022: 6311 characters

2.4 Have you thought of publishing those replacements, if you are curating them, as a small package?

1.1

1.2 Is there any advantage of this approach over adding the additional replacement as an after-step of the slugification. I mean, what if you use the list of ambiguous characters and run the same replacement after the slug is created with this library?

I've just noticed that the Unidecode package works as expected with ambiguous characters so this PR is obsolete now 🤦♂, I will close this sorry for the trouble

@xnetcat thank you for the info on this PR. I have included the info on the wiki page.
https://github.com/un33k/python-slugify/wiki/Python-Slugify-Wiki#notes-on-unidecode


dest option does not work with prefixes

Our webpack assets are generally under /_assets so that they don't interfere with HTML5 URL rewrites.
This means that the http://.../carte-blanche url is really at http://.../_assets/carte-blanche. Carte Blanche refers to its assets by absolute path, so that doesn't work. Specifying a dest option just replaces the carte-blanche part, not the prefix.
IMHO, assets should be loaded without path, since they will be in the same location as the index.html file.

Another option would be to also include the configured public path into the url…

IMHO, assets should be loaded without path, since they will be in the same location as the index.html file.

We had that, but the problem then is that you have to go to /dest/ (notice the trailing slash), otherwise the assets will refer to the root domain. I'm about 99% sure that we'd get tons of bug reports about that, so I fixed it by prepending the dest option.

Another option would be to also include the configured public path into the url…

That sounds a lot more reasonable. :+1:

The trailing / could be fixed by passing staticOptions: {redirect: true} to the webpack-dev-server.
Also, a bit of javascript before the main js loading could check for the url matching /(index.html)?and if not, redirecting.


GitHub Actions, Windows

Wondering if there's interest in running any CI on GitHub Actions.  It supports MRI Ruby 2.2 and later on Ubuntu, macOS, & Windows.  JRuby & TruffleRuby are also available.
For an example run, see:
https://github.com/MSP-Greg/rspec-core/actions/runs/88352990
yaml script is at:
https://github.com/MSP-Greg/rspec-core/blob/actions-windows/.github/workflows/rspec-core.yml
There are a few issues on Windows that could be updated, all are test/spec issues, not 'lib' code issues.

Yes there is interest. Its something I've been considering and I think @benoittgt has looked into a bit.
We'd consider having rspec-rails move over first as it only supports modern Rubies and doesn't have windows builds, but eventually I like the idea of having all the CI on Github with a matrix of modern rubies on linux and windows at least.
We would have to keep some Travis builds until RSpec 4 due to needing older Ruby support such as 1.8.7, but we could have "legacy builds" only there.

but we could have "legacy builds" only there

Probably a good idea to continue with "legacy builds" on both AppVeyor & Travis.  Some repos keep all their 'allow failure' jobs there also.
Re Windows, I can't remember Win7 & 8 or Vista very well, but Windows consoles have worked with ANSI escape/color codes for quite a while.  Windows supports spaces & single quotes (apostrophe)  in filenames, but it does not support a standard double quote.  I haven't tried unicode quotes.
Anyway, if you want me to do anything, let me know.  Feel free to close.

Thanks a lot @MSP-Greg for the help offer.
I looked a it https://github.com/rspec/rspec-dev/issues/234 and ended up stopping for a moment because I had too many side issues when testing with Github Actions. The cost of change was too big.
I thought the switch would have been easier. I tried only rspec-core and it was already many surprises and issue open in other open-source repo, like https://github.com/actions/virtual-environments/issues/267. I ended up with a complicated error that I was no able to reproduce locally, I tried two hours, then drop. :/
To be honest, I thought: What will be the major gain to switch? I read that other smaller ruby lib like rom switched to Github actions and enjoyed the fast boot, but in our case rspec is different, little bigger, bigger build matrix.

I started with the AppVeyor script, and added the Unbuntu & macOS jobs.
I now see that the Travis script does a lot more than the AppVeyor script.
A lot has changed with Actions, but if you're auto-generating all your CI scripts/yaml, changing to Actions is more involved...

Whilst they say they are auto-generated, what they mean is they are copies of those in scripts in rspec-dev this is done to keep them in sync. (Its a lot easier to run a rake task to update them than to copy pasta each time we make a change etc).

This is done, closing.
https://github.com/rspec/rspec-core/blob/addcfb47cb0582b8e976c938ff18728144a7dcee/.github/workflows/ci.yml#L68


[PENDING REVIEW] Clean up seed ISO image attached to Arc VMs

Workitem - https://msazure.visualstudio.com/One/_workitems/edit/29805309
This PR has the WMI changes for retrieving the DVD disk and DVD drive attached to an Arc VM. This code would be invoked by helper code in moc-pkg which would detach the seed ISO from the VM and ultimately delete it from the storage container.
Testing
Able to detach and delete an attached ISO file from a HyperV VM
HaaS testing - In progress

/azp run

/azp run


Python-hashids is being depreciated in favor of python-sqids

The old hashids package is replaced by sqids (https://sqids.org/python).
Although this happened very recently I wanted to open this issue to discuss the path forward for the django-hashids package.
What are your thoughts on this?
I'm in favor of making the default "hashid" library used a setting, for example: "HASHID_LIBRARY_USED", which can be hashids or sqids or something else.

Thanks for the heads up. That's a good suggestion, I'll look into it later.

@gabn88 thank you for bringing this new library to my attention. I've always preferred this project over the more intrusive alternative (django-hashid-field) so I went ahead and forked this project and adapted it to Sqids: https://github.com/julianwachholz/django-sqids - feel free to check it out :)


neko: 2.0.0 -> 2.1.0

Motivation for this change
The motivation was to add Darwin support to Neko. I bumped the version to 2.1.0 where there the build process has been improved and dependencies have been updated. The patch specified in the previous version of this build has been merged into 2.1.0.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Looking into breakage.

Looks like this is the culprit: https://github.com/HaxeFoundation/neko/issues/131
Still can't reproduce the actual error :(

Patched version passes tests! I'm guessing the error was a result of an interaction of the kernel with Neko's low-level ELF concatenation hackery. The patches swap in a more robust technique, and should become part of the next release.


Removing go-mix from awesome-go

https://github.com/avelino/awesome-go/pull/4105

Thanks for the heads up @spekary we're working on it and will apply for re-entry when the criteria are met.


📎 Implement lint/noElseReturn - eslint/noElseReturn

Description
eslint/no-else-return.
The rule should be implemented with the Control Flow Graph query.
Question: should we use the name noUselessElse instead?
Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

Replaced by #247


Security plumbing

This doesn't yet add security support to any client/server generators, but threads through the defined security schemes to enable that.
Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

I ended up semi-redoing this.  I noticed that the swagger parser doesn't implement "inheritance".  That is, if there's a toplevel security: item, it doesn't get automatically set on all the Operation instances.
I created a new SecurityRequirements case class that is now a member of RouteMeta.  It propagates the security requirements on the Operation (falling back to the requirements on the root object if there aren't any), the security schemes marked as optional (via our vendor extension), and whether or not the requirement comes from the global/root level or not.
For the last bit, I want clients to be able to know if the security requirement is there for all operations, or just some.  This way a client can make the API a little nicer: if the requirement is at the global level the constructor for the client itself can take credentials, and then the individual operation methods can take creds as an optional param.  If the requirement is at the operation level, then the client constructor won't take credentials, and the operation methods will take creds as required params.


Add ExtraFDs field to CreateContainerRequest

This allows extra open fds to be passed through into the container, relying on
opencontainers/runc#1320 to actually pass them to the init process.
These fds are opened in the order they appear in the ExtraFDs array and begin
at fd 3 after stdio.
Initially only two kinds of extra fd are supported, /dev/null (mostly as a PoC
to have more than one, its not actually very useful) and a named tap device.
Other useful types which could be considered might include anything which could
be returnable by Go's net.Dial or Fds received as ancillary data over a Unix
domain socket.
The fds are opened in the main containerd process and passed through to the
shim as a simple count. This slightly complicates passing the open gRPC socket
fd through to the shim since inserting the extra fds before it means it is no
longer fixed at fd 3. The number is now communicated through an environment
variable, this seemed to have less potential for confusion than retaining the
fd at 3 and then requiring containerd-shim to shuffle the extra fds down one as
it does the exec of runc.
NB revendoring crosbymichael/go-runc also pulls in
db0c87b Remove - from temp process name
c098a32 Remove process options from ExecOpts
as well as the changes from crosbymichael/go-runc#8.
Signed-off-by: Ian Campbell<EMAIL_ADDRESS>

Force pushed with https://github.com/crosbymichael/go-runc/pull/8 merged and rebased onto latest master. Dropped "DO NOT MERGE"

My only issue with this is that this is very unix specific.
Maybe we should use google.protobuf.Any to allow passing arbitrary parameters to the runtime for CreateRequest?
wdyt @crosbymichael ?

@mlaventure I suppose the non-Unix you are thinking about is Windows? I know they have ways to similarly inherit fds/handles over process creation but I'm not sure how that interoperates with containers. AIUI the container engine in Win uses some hypervisor components and I don't know where containerd lives WRT that, my guess is outside in which case it seems likely that fd inheritance from containerd isn't an option. Inheritance from the equivalent of containerd-shim might be?
Adding an Any or some other host and/or os specific field to CreateRequest does sound like an option.
Somewhat tangentially related, but is remote access to the containerd gRPC end point supported or do we expect it to always be local?

@ijc25 Windows has a DuplicateHandle routine to do the equivalent of dup2. But other runtime may not (e.g. a vm based runtime?)
containerd only provides a local gRPC access otherwise.

Would it be better to just write your own runtime that creates the tap and everything in process and just pass the fds to the shim that way?  Its really hard and ugly to try to do this over GRPC.

@mlaventure a vm based runtime is a good example, thanks. In that case you might still want to expose fds from within the vm space to containers running within it, although I concede that there are very likely to be naming/scoping issues with any attempt to do that. Perhaps one might want to pass in a virtio-chan from the host to the vm and then to the container as an fd. (I confess this is a usecase which doesn't sound very useful or practical to me right now, but people are pretty creative!).
Anyhow I'll have a look at prototyping the addition of an Any.
Thanks for confirming that the gRPC interface to containerd is local only.

@crosbymichael I did consider that, but a new runtime to support this use case would want to incorporate/wrap basically all of the existing linux runtime (and the shim) just to add a few dozen lines of code, since the desired result is still a Linux container, just with a few extra preprepared fds open. Due to where the code needs to be I don't think it would be a matter of wrapping one runtime in another in a clean way, it'd need to either add functionality to the inner runtime (essentially what's done here anyway, just obfuscated in a wrapper) or clone-and-hack it.
To me the problem becomes readily apparent when I try to think of a name for a new runtime of this nature, "linux-tap", "linux-extra-fds" etc all come to mind and nothing at all good or satisfactory does.
Also, FWIW, although I implemented tap here as a first pass I do have other use cases in mind for the near future, specifically passing in an open fd for an RPC connection.

I think this change is too intrusive for containerd and you don't really have another choice but to extend it with an additional runtime.  You can call it anything, it does not have to be general purpose because callers will pick which runtime to use at create time.  The default linux runtime will still be installed and yours can be used whenever you need it.


Add group block enumeration method

@macdrevx @jnjosh Please review.
Adds a block enumerator method that returns a dictionary that groups the elements in a collection by their return value from a block. For example:
NSArray *iOSDevelopers = @[ @"Ameir", @"Andrew", @"Duncan", @"Jill", @"Josh", @"Kevin", @"Prachi", @"Steve", @"Tom" ];

NSDictionary *groups = [iOSDevelopers twt_groupWithBlock:^id<NSCopying>(NSString *name) {
    return @(name.length);
}];

The resulting groups dictionary would look like:
@{ @3 : @[ @"Tom" ],
   @4 : @[ @"Jill", @"Josh" ],
   @5 : @[ @"Ameir", @"Kevin", @"Steve" ],
   @6 : @[ @"Andrew", @"Duncan", @"Prachi" ] }

Looks good to me. I feel like we should add the equivalent to flatMap too… because, reasons…

I'd want this block to receive the object's array index, too.

@kconner It might not be an array. This works for sets, ordered sets, and dictionaries too.


Remove legacy organ donor api code

There were two api's relating to promotion data. This removes one
leaving a single api.
There will be a migration to tidy up the data in the Publisher PR.
Corresponding PR's:
https://github.com/alphagov/frontend/pull/972
https://github.com/alphagov/publisher/pull/484
https://github.com/alphagov/govuk_content_api/pull/248
Trello card

Looks good to me 👍


GetTimeSeriesAsync returns bad datetimes

All datetime values for GetTimeSeriesAsync are 1/1/0001 12:00:00 AM +00:00

I was wrong, looks like this was an implementation error on my part. sorry.

Thanks for raising this issue. Could you provide some additional details on the Time Series request, such as the symbol and interval used?


If I click on radio button on Welcome to Rancher screen, it unselects both

Steps:

Create new setup
On Welcome to Rancher screen click directly on radio button

Results:
Both radio buttons become unselected

Fixed


Page navigation with thumbnails

Im looking forward a way to implement a scrolling navigation which will contain thumbs of all pages. Can I incorporate thumbs with scroller or can I get a list of thumbs of all pages?

Currently there is no such possibility, you can create it by yourself using PdfiumAndroid.


Ctrl + Shift + L to replace the selected items may remove surrounding code in Java

I use Ctrl + Shift + L frequently to select multiple matches and then replacing the selected items with something else. When writing a C++ code, this works very well. I recently started coding in Java and installed Java Extension Pack. vscode version 1.34.0, operating system Ubuntu 18.04.
Here is how the problem occurs:
Suppose you have a variable I that is used throughout the code. Consider the for loop
for(int i = 0 ; i < I ; i++ )
Move the cursor next to I and press Ctrl + Shift + L to select all matches of I. Then start typing. A window comes up and you select one of the suggestions, say Global (a class). Once you press enter, some of the code is just disappeared. For example, the for loop is changed to
for(int i = 0 ; iGlobal ; i++ )
which means that the < sign as well as the surrounding spaces are all repalced with the Global. As in C++, I expect that only the I variable is replaced with Global not the surrounding characters including the spaces. I attached a toy java project to reproduce the issue.
Reproduce.zip
This issue also occurs in other cases than the attached example and also when you use Ctrl + D to add selection. It makes the add-selection approach highly unreliable and risky to use.
EDIT: I think the source of issue is not in the add-selection, although add-selection is also affected by the issue. I just realized after pressing the enter button to select one of the suggestions for a variable A in [A], the right bracket of the array is removed.

Hey, sorry for replying late. As I can't reproduce this issue, can you help check if you can still reproduce with all extensions disabled?


SocketStream read error [0x2811f18c0]: 1 54

Whenever i am trying to write something on socket, it is returning "SocketStream read error [0x2811f18c0]: 1 54".

Hi @pratyushpratik Can you please give more details. What version are you using and maybe a test project?


Add AddMul custom op

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.75%. Comparing base (377a5e5) to head (52f2ddf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   84.75%   84.75%
=======================================
  Files          58       58
  Lines        7051     7051
=======================================
  Hits         5976     5976
  Misses       1075     1075

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add interface names into NSM metrics

Task: https://github.com/networkservicemesh/sdk-vpp/issues/768
Keep in mind that "client_interface" for nsc and "client_interface" for forwarder are slightly different in meaning.
The "client_" or "server_" prefixes on the forwarder are related to the internal structure of the forwarder (see diagram).

@NikitaSkrynnik @d-uzlov @denis-tingaikin @glazychev-art @VitalyGushin please review

Done in this PR: https://github.com/networkservicemesh/sdk-vpp/pull/789


Difference with tqdm

Hi,
Thanks for your project. Would you please mention differences (implemented or planned) between fast_progress and tqdm in README or somewhere?

This is inspired by tqdm (obviously from the way the progress bars are designed) but we had some little problems by using tqdm (one with annoying vertical spaces when the nested bar disappeared, or others with multiprocess).
This is very specific to a training loop (though they might be some other situations where people want to use something like this, which is why we shared), tqdm is far more general.


Could not find any USB device

When using the --otg parameter, I get this error:
scrcpy 1.24 https://github.com/Genymobile/scrcpy
INFO: Killing adb daemon (if any)...
ERROR: Could not find any USB device

On Windows I guess? Is USB debugging enabled? (#3050)

Yes, I'm having this error on Windows. My USB debugging is active

Does scrcpy work for mirroring (without the otg option)?
What is the result of:
scrcpy --otg -Vdebug

Also see #3052 comments.

Here is the result of scrcpy --otg -Vdebug

??

i have the same error, i searched on issues and FAQ for a while but i didnt found any solutions :(

THIS WILL REALLY HELP YOU (almost 90% of the time this might be the problem)
Download the latest version of ADB from the official Android developer website.

Extract the contents of the ADB ZIP file to a directory on your system, such as ~/Tools.

Add the directory containing the ADB binary to your PATH environment variable by adding the following line to your .bashrc file:

        'export PATH=$PATH:/path/to/adb/'

Reload the .bashrc file by running the following command:
'. ~/.bashrc'
Try running scrcpy again and see if the error message goes away.

THIS WILL REALLY HELP YOU (almost 90% of the time this might be the problem)

Download the latest version of ADB from the official Android developer website:
[https://developer.android.com/studio/releases/platform-tools]
Extract the contents of the ADB ZIP file to a directory on your system, such as ~/Tools.
Add the directory containing the ADB binary to your PATH environment variable by adding the following line to your .bashrc file:  `export PATH=$PATH:/path/to/adb-file-just-downloaded-and-extracted/`

Reload the .bashrc file by running the following command:
. ~/.bashrc
Try running scrcpy again and see if the error message goes away.

How to do this in Windows? As i searched this is for Linux not for the Windows is there any solution for Windows? Thanks

Okay i think that i have a work around for this issue
Just change usb mode on ur phone into charge mode and not MTP mode and it will work perfectly (as i tested lol)

Please also read https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#hidotg-issues-on-windows

I tried to reinstall the driver but no luck, the phone i use is LG V60(Android 12) and it has auto mode when you connect to usb it change to mode MTP(file transfer) and when i tried to change it into charge only mode it work as it should
I don't think that this method is 90% sure will fix the problem but it is worth a try!

My Phone is Already connected right now as transfer files and nothing appear .. so what i can do ?
also i try another devices same problem otherwise my cable is the original one

Did you installed adb and connect it through adb as u should?, you should try to change usb mode on your phone to charging and try again, if not install your phone driver


Add validation string for invalid Secure Settings manifest

@zendesk/dingo @zendesk/wattle-dev @sostopher @zendesk/localization
Description:
Add new string. String would suggest developers to use secure settings.
Also in this PR

Update comment generated by Rakefile in en.yml

Before: "# This file is generated by rake i18n:standardize. Do NOT edit it directly.\n"
After: "# This is a generated file. Do NOT edit directly.\n# To update, run 'bundle exec rake i18n:standardize'.\n"

Add string to validate marketingOnly or requirementsOnly apps,

Javascripts, stylesheets, and templates are not required for marketingOnly or requirementsOnly apps

Add string to warn developers about using secure settings

Make sure to set secure to true when using keys in Settings. Learn more: %{link}

Obsoleting strings which are no longer called.

References:

https://zendesk.atlassian.net/browse/MPORT-501 - Secure settings
https://zendesk.atlassian.net/browse/MPORT-498 - Source check

Risks:
Low - Strings don't show up?

Build is failing because zendesk_apps_support v4.18.0 has been yanked from ruby gems. Will update this to v4.19.0 once that fix is up.
Changes to strings by localization team can still be reviewed separately.

Strings look good to me. Thank you Keith!!

Thank you, @seangoedecke


[BEAM-6182] Cherry-pick: Disable conscrypt by default (#7203)

Disable conscrypt by default

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 Waiting for tests to pass.

Run Portable_Python PreCommit


Middle click for rotating the camera

The readME file should say middle mouse button is used for rotating the camera (in stand of right button now).
Also, the right mouse button is for rotating the building, not the spacebar.
Users should not go into the code the understand that.

Sorry about that, my mistake. It's fixed now


Search Checksum

Here you can see, that checksum for VIN Mask is with high probability in adress 0000h-0001h. I have some idea for this, but we need more information about the possible range. I have no 5E FW file, so i can't test it myself. Can you flash 5F test files to enclose the range for this part?

Hi, thanks.
Yes, our eyes were on this position as well, as it's basically the only one that's not declared in the template. I'm running some brute force tests on multiple files to determine what range the checksum is being calculated on. So far, no consistent luck there.

I think it could be XOR... for a limited amount of bytes. This is why i ask if you can flash testfiles to limit the bytes concerned. I think it is defently not the whole bytes from complete file.

Yes, we flashed several test files. Changes  in any location lead to checksum errors.

Yes there too.
I've spent some time going over the various CRC16CCITT ranges from 2 to EOF (and everything in between). There are some hits of course, but none are reproducable on other firmwares. a XOR hash could be it. I guess I could write a simple script that goes over all ranges and does the same trick for XOR

I found XOR in different Datasets. VAG, Audi etc. but always with different checksum, sometimes the byte sum is 0, on other files it was e.g. 55555555... I wrote me some 010 scripts for it. Feel free to let me know when i can help you with some input for it.

Closing :-) fixed with 7e2f7b2dc8106736337ad0c29de7f56b6367f206


Update hard coded english text with locale properties

This needs to be done for all UI components with english text

This is a localisation task which needs to be divided by screen/journey and assigned to different team members.

Closing this as an example has been done for login screen and the rest can be planned and completed when translations are available.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nancho313 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Image cache lock

Refactor some code around imageCache handling. Primarily fixes missing locking, but also simplifies logic a little

/ok-to-test

/test all

/test integration_rhel

@nalind PTAL

LGTM

All Green.
Merging
@redbaron Thanks.