parquet.read_table opens files twice

Describe the bug, including details regarding any error messages, version, and platform.
It appears that parquet files are opened twice when using parquet.read_table.  The first time seems to be to read in the schema, the second to do the actual data read.
This seems to be the case when use_legacy_dataset=False and without specifying a schema argument.  It also is the case for datasets and single parquet reads.
My use case is that i'd like to use a custom fsspec filesystem that interfaces to an s3 like API. It handles the remote download of the parquet file and passes to pyarrow a handle of a temporary file downloaded locally.  Without cached access, this behavior results in files being downloaded twice.
Here is where the file is opened to read in table schema.
Here is code to reproduce:
import pandas as pd
import pyarrow as pa
import pyarrow.parquet as pq
from fsspec.implementations.local import LocalFileSystem
import os

# create a fsspec filesystem to track the number of times files are opened
class LocalFSWithAccessCounter(LocalFileSystem):
    def __init__(self, *args, **storage_options):
        super().__init__(*args, **storage_options)
        self.access_count = {}

    def open(
        self,
        path,
        mode="rb",
        block_size=None,
        cache_options=None,
        compression=None,
        **kwargs,
    ):
        if path in self.access_count:
            self.access_count[path] += 1
        else:
            self.access_count[path] = 1

        return super().open(
            path,
            mode,
            block_size,
            cache_options,
            compression,
            **kwargs,
        )

# create a simple test table
df = pd.DataFrame({'col1':range(2),'col2':range(2)})
out_table = pa.Table.from_pandas(df)

# write then read as single parquet file.
# file is opened twice using read_table
pq.write_table(out_table, 'example.parquet')
fs = LocalFSWithAccessCounter()
in_table = pq.read_table('example.parquet', filesystem=fs)
print('files open count:\n', fs.access_count, '\n\n')
#files open count:
# {'example.parquet': 2}

# write then read as dataset with partitions.
# one file is opened twice when using read_table
pq.write_to_dataset(out_table, 'example_ds.parquet', partition_cols=['col1'])
fs = LocalFSWithAccessCounter()
in_table = pq.read_table(os.path.join(os.getcwd(), 'example_ds.parquet'), filesystem=fs)
print('dataset file open count:\n',fs.access_count)
#dataset file open count:
# {'example.parquet': 2, 'example_ds.parquet/col1=0/237b18616a4844b3b094c264f6a09c48-0.parquet': 2, example_ds.parquet/col1=1/2d70ed145ee742e99f4c5528b053446d-0.parquet': 1, }

Component(s)
Python

Do you know which version of pyarrow you were using?  There was a fix put in place for 12.0.0 (https://github.com/apache/arrow/issues/33972) that may have addressed this.

I am using 12.0.0.  I read through #33972 and it seems that was an issue within the Dataset API, whereas the extra file opening seems to be initiated from the python shim.

it seems that was an issue within the Dataset API

Yes, however, pretty much all reads are using the dataset API internally now.  The paths have been merged for simplicity of maintenance.  read_table will create a dataset with one file and then read it.  The first time the file is opened happens when the dataset is created (to get the schema of the file).  I am pretty sure it isn't actually reading the schema twice though.  I think it is something like...

Create dataset

open file
read metadata
close file

Read dataset

open file
read data
close file

I agree that it is somewhat less than ideal that the file is opened twice.


Fix typos

Fixes the lowercase L in MAIL and the example config :smile:

THX a lot!!!
On Thu, May 4, 2023 at 7:59 PM Richard Kuhnt @.***>
wrote:

Fixes the lowercase L in MAIL and the example config 😄
You can view, comment on, or merge this pull request online at:
https://github.com/KlausSchaefers/qux-java/pull/16
Commit Summary

71ff267
https://github.com/KlausSchaefers/qux-java/pull/16/commits/71ff2678f9f4cec73f5a79503a5cf6cedcb26540
Fix typos

File Changes
(6 files https://github.com/KlausSchaefers/qux-java/pull/16/files)

M README.md
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(12)
M src/main/java/com/qux/MATC.java
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-cf4e547dfb6e2b2791e5f9ffc623fc8c781e9f07474c024e118f2f930c03d622
(8)
M src/main/java/com/qux/bus/MailHandler.java
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-0cda292de80359ca9e2bff0854983ae423931f7b757036b92ad35557b72eb5d7
(4)
M src/main/java/com/qux/rest/ContactRest.java
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-14e354b53b81d4609dbecce4cc3f5a0179438c4edaeecfd1656f7cb97523e24a
(4)
M src/main/java/com/qux/util/Config.java
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-d049b90906c1a0c3297c4452c219b4ed71e5d254cc2950c95f48ba5633f3c7fe
(24)
M src/main/java/com/qux/util/Mail.java
https://github.com/KlausSchaefers/qux-java/pull/16/files#diff-ffb39b1f9adf35115bc3680c24ed556d29a81a14cce60abf66ee4335df517b9d
(12)

Patch Links:

https://github.com/KlausSchaefers/qux-java/pull/16.patch
https://github.com/KlausSchaefers/qux-java/pull/16.diff

—
Reply to this email directly, view it on GitHub
https://github.com/KlausSchaefers/qux-java/pull/16, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWHOQD67DFZLQ52LXO2UY3XEP4CFANCNFSM6AAAAAAXWFSVFE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
“Overfitting” is not about an excessive amount of physical exercise...


Can not deploy to another server, always

Hi,
I was able to deploy to server-1.
Later I want to deploy to another server, server-2, and changed the mup.json file accordingly, (ip, etc).
It failed in mup deploy:
[<IP_ADDRESS>] - Uploading bundle
[<IP_ADDRESS>] - Uploading bundle: SUCCESS
[<IP_ADDRESS>] - Setting up Environment Variables
[<IP_ADDRESS>] - Setting up Environment Variables: SUCCESS
[<IP_ADDRESS>] - Invoking deployment process
[<IP_ADDRESS>] x Invoking deployment process: FAILED
-----------------------------------STDERR-----------------------------------
mver/-/semver-4.1.0.tgz
npm http 200 https://registry.npmjs.org/underscore/-/underscore-1.5.2.tgz
npm http 304 https://registry.npmjs.org/chalk/0.5.1
npm http 200 https://github.com/meteor/node-eachline/tarball/ff89722ff94e6b6a08652bf5f44c8fffea8a21da
npm http GET https://registry.npmjs.org/type-of
npm http 304 https://registry.npmjs.org/type-of
npm http GET https://registry.npmjs.org/type-of/-/type-of-2.0.1.tgz
npm http GET https://registry.npmjs.org/source-map/-/source-map-0.1.32.tgz
npm http 200 https://registry.npmjs.org/type-of/-/type-of-2.0.1.tgz
npm http 200 https://registry.npmjs.org/source-map/-/source-map-0.1.32.tgz
sh: 1: node: not found
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm ERR! weird error 127
npm http GET https://registry.npmjs.org/amdefine/-/amdefine-0.1.0.tgz
npm http 200 https://registry.npmjs.org/amdefine/-/amdefine-0.1.0.tgz
npm ERR! not ok code 0
-----------------------------------STDOUT-----------------------------------
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/integra
├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/bson
└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/markdown
 > ./bcrypt: npm install due to binary npm modules
<EMAIL_ADDRESS>node_modules/bindings

<EMAIL_ADDRESS>node_modules/nodeunit
└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
><EMAIL_ADDRESS>install /opt/Ucar/tmp/bundle/programs/server/node_modules/fibers
> node ./build.js

What should I do for this?
Looking forward to hearing some answers
Thanks

I found this info which might help...
http://plaidzooks.tumblr.com/post/36894116867/using-nodejs-on-debianubuntu-systems
seems it's called "nodejs" and not "node"? I'd guess a link would do it.
Sounds like it might be a different instance your server2 is trying to deploy to then server1?

Thanks Master. I installed nodejs-legacy, and the node error disappear.
But new error showed up:
"

Setting up Environment Variables: SUCCESS

Invoking deployment process
x Invoking deployment process: FAILED
-----------------------------------STDERR-----------------------------------
pm http 304 https://registry.npmjs.org/escape-string-regexp
npm http 304 https://registry.npmjs.org/ansi-styles
npm http 304 https://registry.npmjs.org/type-of
npm http GET https://registry.npmjs.org/ansi-regex
npm http GET https://registry.npmjs.org/ansi-regex
npm http GET https://registry.npmjs.org/source-map/-/source-map-0.1.32.tgz
npm http 304 https://registry.npmjs.org/ansi-regex
npm http 304 https://registry.npmjs.org/ansi-regex
npm http 200 https://registry.npmjs.org/source-map/-/source-map-0.1.32.tgz
npm http GET https://registry.npmjs.org/amdefine/-/amdefine-0.1.0.tgz
npm http 200 https://registry.npmjs.org/amdefine/-/amdefine-0.1.0.tgz
js-bson: Failed to load c++ bson extension, using pure JS version
/usr/local/lib/node_modules/wait-for-mongo/bin/wait-for-mongo:14
throw err;
^
Error: TIMEOUTED_WAIT_FOR_MONGO
at null._onTimeout (/usr/local/lib/node_modules/wait-for-mongo/lib/waitForMongo.js:20:14)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
-----------------------------------STDOUT-----------------------------------
.1:27017]
wait-for-mongo: failed to connect to [<IP_ADDRESS>:27017]
"

Still it seems something is different from server1's image then 2's ?! It sounds like an incompatible version somewhere.
Did you try extending this mupx setting
"deployCheckWaitTime": 15
Upto maybe 120 even?

Thanks, Master. I am using mup, not mupx.
Do I need to migrate to mupx?
I am using waitTime = 15. Will try 120.

Master, it would be great if there exist some example of using meter-up in a few well known servers, like aws, digital-ocean, etc, so that the users just need to follow the instruction, not need to repeat & struggle the same errors.

There are a few tuts/examples out there but this
https://www.npmjs.com/package/mupx
Should provide enough if follow closely, and stick to supported versions migration etc.
Meteor's Galaxy is only available to big companies for now. I suspect this is somewhat tied to AWS's EFS also in private beta.
It will get easier in time but the more you know underneath the hood the better. For now the advantage is to those that perserver and prevail.
Yes it seems mupx is the better route but none of it is official safe for production I don't think because we are missing a few things from Mongo like syncing via oplogs and larger data size limits or something like that too apparently.
I suppose it's a topic for another thread but if anyone can add to that please enlighten us.
I'm sure it's excellent for many projects.


"editorGroup.border" controls border on up/down splits, but not left/right splits

VSCode Version: 1.27.2 (1.27.2)
OS Version: OSX 10.13.6 (17G65)

Steps to Reproduce:

set "editorGroup.border" within "workbench.colorCustomizations" to some custom color (I use
"editorGroup.border": "#888888")
Split an editor window up or down, and observe the border between the editor panels is rendered in the correct color.
Split an editor window left or right, and observe the border between the editor panels is not rendered.

Does this issue occur when all extensions are disabled?: Yes

Screenshot showing three panels: upper one split left/right, and lower one not split. Notice only one border.

Wow, that's impressive. Yes. I have my zoom level set to -1. I never thought to test that settings combination.

Duplicate of #58437


[Question] How to set some border or separator when viewing definition?

When viewing a definition with k, how can I set some separator of the definition popup from the background?
In this image, the red mark box is the definition window. I want some border or background color difference here. How can I achieve this?

It's a configuration on nvim-cmp :
      cmp.setup({
        window = {
          documentation = cmp.config.window.bordered({
            winhighlight = "Normal:Normal,FloatBorder:FloatBorder,CursorLine:Visual,Search:None",
          }),
        },
       ...

I'm using following in my cmp.lua script under plugins directory for lazyvim:
return {
    "hrsh7th/nvim-cmp",
    dependencies = {
        "hrsh7th/cmp-nvim-lsp",
        "hrsh7th/cmp-buffer",
        "hrsh7th/cmp-path",
        "hrsh7th/cmp-cmdline",
        "saadparwaiz1/cmp_luasnip",
        "L3MON4D3/LuaSnip",
    },
    config = function()
        local cmp = require("cmp")
        cmp.setup({
            snippet = {
                expand = function(args)
                    require("luasnip").lsp_expand(args.body)
                end,
            },
            mapping = cmp.mapping.preset.insert({
                ["<C-n>"] = cmp.mapping.select_next_item(),
                ["<C-p>"] = cmp.mapping.select_prev_item(),
                ["<C-d>"] = cmp.mapping.scroll_docs(-4),
                ["<C-u>"] = cmp.mapping.scroll_docs(4),
                ["<C-Space>"] = cmp.mapping.complete(),
                ["<C-e>"] = cmp.mapping.abort(),
                ["<CR>"] = cmp.mapping.confirm({ select = true }),
            }),
            sources = cmp.config.sources({
                { name = "nvim_lsp" },
                { name = "luasnip" },
                { name = "buffer" },
                { name = "path" },
            }),
        })
    end,
}

But no improvements:

I've you tried like this :
return {
    "hrsh7th/nvim-cmp",
    dependencies = {
        "hrsh7th/cmp-nvim-lsp",
        "hrsh7th/cmp-buffer",
        "hrsh7th/cmp-path",
        "hrsh7th/cmp-cmdline",
        "saadparwaiz1/cmp_luasnip",
        "L3MON4D3/LuaSnip",
    },
    config = function()
        local cmp = require("cmp")
        cmp.setup({
            window = {
              documentation = cmp.config.window.bordered({
                winhighlight = "Normal:Normal,FloatBorder:FloatBorder,CursorLine:Visual,Search:None",
              }),
            },
            snippet = {
                expand = function(args)
                    require("luasnip").lsp_expand(args.body)
                end,
            },
            mapping = cmp.mapping.preset.insert({
                ["<C-n>"] = cmp.mapping.select_next_item(),
                ["<C-p>"] = cmp.mapping.select_prev_item(),
                ["<C-d>"] = cmp.mapping.scroll_docs(-4),
                ["<C-u>"] = cmp.mapping.scroll_docs(4),
                ["<C-Space>"] = cmp.mapping.complete(),
                ["<C-e>"] = cmp.mapping.abort(),
                ["<CR>"] = cmp.mapping.confirm({ select = true }),
            }),
            sources = cmp.config.sources({
                { name = "nvim_lsp" },
                { name = "luasnip" },
                { name = "buffer" },
                { name = "path" },
            }),
        })
    end,
}

Hi, thanks for sharing the snippet. but it still not working.

Maybe you can have a look to this issue : https://github.com/LazyVim/LazyVim/issues/2708
Or to the nvim-cmp config : https://github.com/hrsh7th/nvim-cmp/blob/main/doc/cmp.txt#L817-L827
It's not a nord.nvim issue, the snippet I've provide should work :shrug:

Thanks it worked finally for me: https://github.com/LazyVim/LazyVim/issues/2708#issuecomment-1988506351


fix slack url

I found https://slack.k8s.io/ is broken to me.
But https://kubernetes.slack.com is fine.

/assign @bogdando

Thanks for the fix!


[FEAT] windows buttons icons

Hello AdamXweb,
i hope you can add that icons for windows users.
https://github.com/aminomancer/uc.css.js/tree/master/resources/window

Hi, are you referring to the Close, maximise and minimise buttons?
They still seem to be working, could you provide a screenshot with your issue?


Openstack provisioning broken with latest openshift-ansible

As shown in this end to end CI run:
https://travis-ci.org/openshift/openshift-ansible-contrib/jobs/267210691
This is broken with the current openshift-ansible master (commit b107f677a3563f6db9a1ef17fe10518d321d495c).
I've verified that this commit does not have the issue: 1febf0b20de622d358dc890417dc4cda7c3f71a9
BUG REQUEST INFO:
Environment:

Cloud provider: RDO Newton (openstack)

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"): centos7

Version of Ansible: (ansible --version): ansible2.3

Version of Jinja: (pip freeze | grep -i jinja) n/a

Version of Shade: (pip freeze | grep -i shade) n/a

Openstack-ansible-contrib version (commit) (git rev-parse --short HEAD): 027210b

I have as strong suspicion this is the culprit:
https://github.com/openshift/openshift-ansible/commit/00afac6ef3235ab66e0a0c02cc863cb577e127f2

Yep, I've just tested it locally, d7d97964f5e3b5d2df9985e7f9d7b74a974458cb is the commit that broke us.


fix: recovering 3.0 changes

BREAKING CHANGES: This version is incompatible with 2.0

:tada: This PR is included in version 1.0.0-next.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Implements Jump

Implemented the Jump node. Corrected the behavior of nodes with a single option, which should show the option, not treat it as a Jump.

You might need to update the tests too. They are failing atm

I can fix the test and will resubmit pr.


Gemma-7b

Type of Change
feature or bug fix or documentation or others
API changed or not
Description
detail description
Issues: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

f32 inference result

gemma_2b inference result

model_name
model_type
piqa

gemma_2b
weight_dtype f32
77.09

w4cint8g32
75.68

pytorch
77.3

gemma_7b
weight_dtype f32
80.25

w4cint8g32
78.56

pytorch
81.2

model_name
model_type
piqa

gemma_2b
weight_dtype f32
77.09

gemma_2b
w4cint8g32
75.68

gemma_2b
pytorch
77.3

gemma_7b
weight_dtype f32
80.25

gemma_7b
w4cint8g32
78.56

gemma_7b
pytorch
81.2

model_name	model_type	piqa
gemma_2b	weight_dtype f32	77.09
gemma_2b	w4cint8g32	75.68
gemma_2b	pytorch	77.3
gemma_7b	weight_dtype f32	80.25
gemma_7b	w4cint8g32	78.56
gemma_7b	pytorch	81.2

here is gemma7b&2b accuray,the inference result of gemma7b is bad when quantize config is weight_dtype int4 compute dtype int8 group_size 128, but gemma2b's result looks good.

https://inteltf-jenk.sh.intel.com/job/neural_speed_extension/103/artifact/report.html
gemma-2b performance, looks so bad.
@luoyu-intel , I profiled the gemma-2b performance, and find the main cost is on the innerproduct,  gemma-2b has two innerproduct, lm_head.weight[2048, 256000] and token_embd.weight[256000,2048], can you have solution to fix it?

new gemma2 performance, @luoyu-intel ,thanks.
https://inteltf-jenk.sh.intel.com/job/neural_speed_extension/107/artifact/report.html


Fix - Zero passed or Zero total should fail

Changes

If the project does not compile or does not opens and we have githubToken we have tests 0/0 (passed/total).
Since failed is 0, setFailed was not set and the tests were passing despite not running at all.

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

I suspect that there may be people who rely on the fact that the test runner passes when there are no tests.
They probably shouldn't rely on that, but I still worry about breaking their workflow with this change.
Maybe we can make some announcement before this change is released?

We're still in alpha, so we're allowed to make breaking changes. But perhaps this would be a good change for v2.x then.
Personally I'm more in favour of showing green marks when the pipeline is set up correctly, even when there are no tests to be run yet.
What do you think @davidmfinol?

I agree that breaking changes are fine since we're still in alpha.
I also agree that showing green checks for 0/0 tests passed is fine if there legitimately aren't any tests set up.
The real problem is that we should immediately fail the workflow when errors happen while opening the project, instead of interpreting that the same as having no tests configured.
Specifically, if there is a non-test error, we should exit with the exit code here, but we also want to ignore the exit code in the case that the only errors are related to failing tests.
Does Unity have an exit code that specifically indicates that unit tests failed?

Yes, it should be those error codes that we capture.

FWIW, we had the same situation in this run:
https://github.com/freezy/VisualPinball.Engine/actions/runs/1035453699
The source code didn't compile, yet it looked like success and never executed the tests.
editmode.log:
AssetDatabase: script compilation time: 17.797706s
Scripts have compiler errors.

As a work around until this gets a solution, we removed the githubToken, and switched to the nunit-reporter action to parse the results:
      - uses<EMAIL_ADDRESS>        if: always()
        with:
          path: ${{ steps.test.outputs.artifactsPath }}/*.xml
          access-token: ${{ secrets.GITHUB_TOKEN }}

Sure though the whole idea is that you don't need yet another action to see the results.
I'd suggest we come up with a fitting solution that fails on compilation errors but not for 0 tests found.


kele-resource: Display the group-version as an infix; allow switching if kind has multiple group-versions

Currently, when kele-resource is given a kind with multiple group-versions associated with it, it prompts the user to select one of those group-versions to work with. It then records the selection in the prefix scope, but does not show it to the user. Not only is this potentially confusing, but in order to switch the group-version used, the user needs to exit the entire transient and start over again. This is bad UX.
In cases where there are multiple group-versions to select from for the chosen kind, user should be able to toggle between them with an infix.

transient-switches should be useful inspiration here. However, transient-switches is very clearly designed to be "CLI-esque." We'll have to design a similar-but-different sub-class of transient-infix that draws inspiration from transient-switches but displays differently etc.


Window dimensions and position not being saved

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom 1.18.0 is not saving window positions on multi-monitor Mac setups, in particular circumstances.
Steps to Reproduce

On a Mac with 2 monitors, arrange them so that the secondary monitor is positioned higher and to the left of the primary monitor, like so:
Open Atom and mentally note the window size and position.
Open settings to ensure that "Restore Previous Windows On Start" is set to "always".
Move Atom's application window fully onto the secondary monitor, so that the top left corner of it is positioned above the height of the primary window. Optionally, resize the window to be noticeably different than the original size.
Open the Developer tools and enter atom.getPosition() into the console.
Observe that the current widow position x and y values are both negative, like so:

Quit Atom via CMD+Q or via the File menu.
Open Atom.

Expected behavior: Atom should restore the window position and size due to the "Restore Previous Windows On Start" setting.
Actual behavior: The window will open in the position it was in at step 2.
Reproduces how often: 100% (if the above steps are followed)
Versions
Atom:
Atom    : 1.18.0
Electron: 1.3.15
Chrome  : 52.0.2743.82
Node    : 6.5.0
apm:
apm  1.18.1
npm  3.10.10
node 6.9.5 x64
python 2.7.10
MacOS:
System Version:	macOS 10.12.5 (16F73)
Mac Model Identifier:	MacBookPro13,2
Additional Information
The issue appears to be caused by an assumption that window positions are calculated relative to the monitor they reside on, not relative to the primary monitor position. The validation logic is found in the isValidDimensions method of atom-environment.coffee at line 635:
# Returns true if the dimensions are useable, false if they should be ignored.
# Work around for https://github.com/atom/atom-shell/issues/473
    isValidDimensions: ({x, y, width, height}={}) ->
    width > 0 and height > 0 and x + width > 0 and y + height > 0

The intent seems to be to prevent saving positions that would place the window outside the viewable area of the monitors, but in our case it generates a false negative due to the way the position data is calculated, and therefore the window position is not saved if your setup is as described above.

This comment seems related.  Also, electron/electron#473 was closed back in 2014...I'm not sure that isValidDimensions is still useful at this point.

This issue is not isolated to just MacOS, I was just about to file the same issue for Windows.

Move Atom's application window fully onto the secondary monitor, so that the top left corner of it is positioned above the height of the primary window

You don't even have to be this specific on position - as long as one of the values is negative it won't save the new position.

I'd hesitate recommending removing isValidDimensions given that it was added to address a specific issue. On taking a second look at electron/electron#473 the reason isValidDimensions was added was to address odd values being returned when the window was minimized on Windows. On Mac you can detect if the window is hidden or minimized by calling the window's isVisible method which returns a boolean. I've verified on Mac that it would logically work as a direct replacement in the three places in atom-environment.coffee that call isValidDimensions. Can someone running on other platforms verify that linux and Windows are the same?
The check is pretty easy:

Open the Atom console as an undocked window.
Execute w = atom.getCurrentWindow().
Minimize the Atom window.
Execute w.isVisible(), which should return false.
Maximize the Atom window.
Execute w.isVisible(), which should return true.

If that works on linux and Windows, we could update isValidDimensions it to use isVisible instead of the broken logic, or simply replace the calls to isValidDimensions with isVisible checks.

Windows 10
isVisible does not work, but isMinimized does:

Ubuntu 16.04 (VM)
Same as windows:

Confirm still reproducable:
Atom 1.28.2 x64
Mac OS 10.13.5
Steps as per comment 1 above.

Also confirm this is still an issue in 1.28.2 x64 in Windows 10.
if atom.getPosition() returns a negative number, settings revert back to previous POSITIVE values.

I also have the same problem on my Mac. Really annoying.

Issue is still reproducible:
Version of Atom: 14.0.1 x64
OS and version: MacOS Mojave 10.14.6 (18G87)
Steps to reproduce:

Open atom session (opens on default screen - e.g. laptop)
Drag window to LEFT to an external screen (laptop is on the right)
Open a directory and create and save a dummy file (not sure if this is required but I did it anyway).
Quit Atom.
Open Atom again and the window appears incorrectly on the laptop screen and doesn't remember it's position on the external monitor.
As noted above by 0bytesolutions it's an issue with negative numbers.

...three years later...

...four years later...

Still reproducible
Atom 1.58.0 x64
macOs <IP_ADDRESS>
steps to reproduce as shown above

If someone could verify that https://github.com/atom/atom/pull/22973 works that would be great


Update Playground for 0.24 release.

fixed in https://github.com/SAP/chevrotain/commit/b8845c97ac07e6ae256feda9cb8f54fd39574b29


checkov: 3.2.334 -> 3.2.336

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.2.334...3.2.336
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.2.336

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365649

x86_64-linux

:white_check_mark: 2 packages built:

checkov
checkov.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365649

x86_64-linux

:white_check_mark: 2 packages built:

checkov
checkov.dist


Add: maximum_subarray

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          45     46    +1
  Lines         501    511   +10
=====================================
+ Hits          501    511   +10

Impacted Files
Coverage Δ

problems/maximum-subarray/maximum_subarray.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b89ba...350d144. Read the comment docs.


fix: Longer file/folder input

Hi @realekhor, I have the latest version but I'm not seeing a change?

i had the same issue while debugging it yesterday. not sure why it seems to "lag". will investigate this.

@realekhor could we stick to the topic of this PR, lengthening the fields for file/folder inputs?
I would like to discuss the logging changes separately if that's okay.

sure.


Bump guava dependency to 19.0

Any objections to bumping the guava dep to 19.0? I've got a project I want to incorporate this into but it has a dependency on 19.0. I rebuilt this project with 19.0 and did not find any compilation issues. I can submit the PR for this change if need be.

Have you try using netty-http by excluding the guava 13 it brings and have a guava 19 as a direct dependency in your project? If that's work, you don't have to wait for netty-http to bump to guava 19.
On a side note, I think we can remove usage of guava from netty-http library to make it more user friendly.

@chtyim the project already brings in guava 19 ahead of the version you guys supply. I was more just going over this code and seeing what could be bumped up to newer versions so as to use the latest and greatest while not breaking anything.

I see. We currently have other projects that uses guava 13 and netty-http. That makes the bumping of the guava in netty-http slightly tricky.

Fair enough. We can close for now then. Thanks for the insight.


Is need to connection pool disconect?

I use redis connection pool.
When app server shutdown( ex. reboot or shutdown and start ..), need to pool disconnect ?
underline is my example.
Is pool disconnect need? or not?
fastapi
redis.py
from rediscluster import ClusterConnectionPool, RedisCluster

pool = ClusterConnectionPool(startup_nodes = [ {~~~~}], decode_responses=True )

def redis_get(key):
    rd = RedisCluster(connection_pool=pool)
    return rd.get(key)

main.py
app = FastAPI()

@app.on_event("shutdown")
def shutdown_event():
    pool.disconnect()

@hjlee9182 I do not get your question really, are you asking how to access the pool and to make a proper shutdown? or are you asking that if you really need to shutdown a pool?

So if the question is regarding that if you need to or not, it depends on how your FastAPI process and code works. If you are going to reuse the same pool object multiple times instead of just making a new instance of it then yes you Must disconnect or you migt even want to run pool.reset() if you are going to reuse it as that does some other cleanup resetting it back to 0 to be able to be used again at a later time. I do however recommend that you create a new pool instance if possible as that ensures that you get back to a good and empty state properly.
Also note that this does depends on if your process shutsdown or not. If your process manager just restarts your server then a new pool will be created each time and any old objects and old sockets/connections will automatically be reaped and deallocated and new ones will be created when your next process starts up. If you are within the same process then you must deallocate and reap these things yourself like you do in your example above, if that is how a shutdown event is processed within FastAPI, i dunno about that tho.


Missing docs contribution process

Description of problem
Currently, CONTRIBUTING doesn't offer any guidance on how to contribute to Cartographer's documentation
Proposed solution
Add detailed steps necessary for a potential contributor to check in new content to the project's documentation, including how to handle versioning and how to integrate documentation into the release process

As a reference, the Contour project makes this process a separate "Contributing to docs" guide:
https://projectcontour.io/resources/contributing-docs/

Rash please update this

#377 introduced a CONTRIBUTING guide for logs


YARN-1926 tests done

changes completed , tests look that run properly

Can one of the admins verify this patch?


Deprecate alpha features

Changes
Deprecate the following features from Shipwright Build:

spec.sources in Build (multiple sources and HTTP artifact downloads)
status in Build (controller validations for Build objects)
spec.dockerfile in Build (provide path to Dockerfile)
spec.builder in Build (provide builder image for s2i builds)
spec.serviceaccount.generate in BuildRun (generated service accounts)

/kind cleanup
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
The following features are deprecated: 1) Multiple sources for builds, 2) HTTP artifact downloads, 3) Status validations for `Builds`, 4) Providing a builder image in a `Build`, 5) Providing the path to a Dockerfile in a `Build`, 6) Generating service accounts in a `BuildRun`.

/assign @SaschaSchwarze0

/lgtm


Repo sync for protected CLA branch

The pull request is created from main638006725179214713sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 5b05016:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


[SPARK-43696][SPARK-43697][SPARK-43698][SPARK-43699][PS] Fix TimedeltaOps for Spark Connect

What changes were proposed in this pull request?
This PR proposes to fix TimedeltaOps test for pandas API on Spark with Spark Connect.
This includes SPARK-43696, SPARK-43697, SPARK-43698, SPARK-43699 at once, because they are all related similar modifications in single file.
Why are the changes needed?
To support all features for pandas API on Spark with Spark Connect.
Does this PR introduce any user-facing change?
Yes, TimedeltaOps.lt,  TimedeltaOps.le, TimedeltaOps.ge, TimedeltaOps.gt are now working as expected on Spark Connect.
How was this patch tested?
Uncomment the UTs, and tested manually.

This is the last one for DataTypeOps.(lt|le|gt|ge) FYI.

Merged to master.


Fix task timeout, support schedulerOverrides. Miscellaneous code cleanup

1.2 PR mirror for https://github.com/RackHD/on-tasks/pull/184 (review and discussion in there).
Fixing task timeout functionality, and also supporting the old "schedulerOverrides" option still in use in most places. Also the unit tests weren't valid for testing this, so updating those as well.
@RackHD/corecommitters @vulpesartificem @stuart-stanley @hohene @heckj

*** BUILD #692 ***
Test Name: test_node_workflows_del_active
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '108', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6c-KZlwzqgoAPKeC/Z4WTwq7Q"', 'Date': 'Tue, 10 May 2016 01:06:14 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"RequestTimedOutError: Request Timed Out (on.task-graph-runner:methods.cancelTaskGraph:Object)."}

Stack Trace: Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/tmp/.venv/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/on-tasks/workspace/RackHD/test/tests/api/v2_0/nodes_tests.py", line 348, in test_node_workflows_del_active
    raise e
ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '108', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"6c-KZlwzqgoAPKeC/Z4WTwq7Q"', 'Date': 'Tue, 10 May 2016 01:06:14 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"RequestTimedOutError: Request Timed Out (on.task-graph-runner:methods.cancelTaskGraph:Object)."}

:+1:

👍

test this please

Should this be going into 1.2 branch rather than RackHD:master?

@johren whoops, thanks


enable --env-file parameter

implements #47

Pull Request Test Coverage Report for Build #

27 of 28 (96.43%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 83.212%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

dockerrun/builder/mocks/Builder.go
10
11
90.91%

Totals

Change from base Build #133:
0.3%

Covered Lines:
1031

Relevant Lines:
1239

💛  - Coveralls


allow build on windows, disabling syslog

try to build krakend for windows, but building failed.
I just recognise, as far as i tested it, the only reason why krakend-ce build failed for windows is, that the logging is using syslog, which is not availble for windows and plan9.
I would like to have a krakend as a windows binary.
I just dig a little deeper in this issue and implemented a little work around, 2 src files with different build tags, one for windows without syslog and one for the rest.

@willie68 there are several other windows incompatibilities in the entire KrakenD ecosystem (such as plugins). Too many for the small interest the users have been showing on the platform for the last 3 years, so we decided to not support it.
on the other hand, doesn't this PR remove support for syslog?

Hi there,
okay.
No, syslog support is only removed for Windows and Plan9. The syslog is still available on all other operating systems.


allow snapshot releases to use commit hash as tag

Affected Packages
pkg:cli
Problem
Right now snapshot releases use a timestamp as the extra unique identifier that is appended to the version. This is a good idea in theory to make them unique, but in practice it makes it really hard to figure out which release maps to which commit (especially when setting up an automated workflow to make a dev channel release for every commit to main).
Proposed solution
I think there should be an option (or make the change completely) to have the latest commit hash the identifier instead. So you'd end up with releases like:
1.3.3-1fe6d0c
1.3.3-25a6994

An example of this pattern in the wild is that @headlessui uses it:

And it has been nice to work with as a consumer.

Slight problem with that approach is that there is a hidden caveat that people dont realize. Prerelease segment of the version (where the hash would be) is comparable alphabetically and some random/older version could potentially be installed instead of a newer one. Locks usually guards alus from this but it can happen and I've seen it happening accidentally.

@Andarist I'm not totally sure I follow. Do you mean it's compared alphabetically when someone is doing an install at a specific version (ie. not using the tag dev)? Just wondering because I don't think I've run into it, but I'm always doing yarn add x@dev or yarn upgrade x@dev.

One case that is easy for me to mention specifically (as its about public packages) is that some people got this installed https://github.com/ReactiveX/rxjs/releases/tag/6.0.0-smoosh.0 over this https://github.com/ReactiveX/rxjs/releases/tag/6.0.0-rc.1 . Even though they have wanted to install the rc (which was newer). How exactly did this happen for them - im not sure. Maybe they just put ^6.0.0-rc.1 in their package.json and tried to install without a lock?
im not saying that im completely opposed to the idea - its certainly popular and convenient, just also associated with this caveat and it was a specific reason why we have chosen the date as the suffix

The other thing using the hash does is makes it difficult to know what order versions were published in. It is certainly possible to sort versions by publish date but it's not usually the default.
The way I've tackled this in the past (on an internal project) is to use both the timestamp and hash, e.g. 1.3.3-2021316102044.1fe6d0c

The timestamp+hash route is also interesting because it means we could have shorter time stamps which are easier to read as time stamps when scanning—like 2<IP_ADDRESS>ed370.

This should actually be already possible with smth like:
changeset version --snapshot $(git rev-parse --short HEAD)

See here:
https://github.com/atlassian/changesets/blob/de2b4a5a7b244a37d94625bcb70ecde9dde5b612/packages/assemble-release-plan/src/index.ts#L39
Although it actually would put that hash before the date and not after - so close to the original request but in the end, I'm not sure if that's the best as it creates the mentioned problem with sorting.

Can default timestamp be modified/shortened? And what time is used, local time zone?


Can't connect with proxydroid

As the title says, do I have to configure it a certain way? I prefer using proxydroid over the built in system settings so if someone could help me, that'd be great, thanks!

All good with proxydruid - if you are using PTC, just make sure you login first, quit the app, activate proxydruid and finally start the app again. Cheers!

just realized the proxy was the problem, the port 8081 wasn't even open :P


Currently-active tab isn't always visible in the tab bar

Environment
Windows build number: 10.0.18363.1198
Windows Terminal version (if applicable): 1.5.3242.0

Steps to reproduce

Set tabSwitcherMode to "disabled" in settings.json.
Open enough tabs that you have to scroll the tab bar to see them all.
Use the keyboard to cycle through all of the tabs.

Expected behavior
The currently active tab is always visible in the tab bar. This requires that the tab bar sometimes scroll itself so that the currently active tab remains visible.
Actual behavior
The currently active tab is not always visible.

This seems reasonable. That being said, I'm not sure we can do this with the TabView currently. It almost seems like something the TabView should be doing for us. I'll file something upstream, since it doesn't look like there are any existing issues.

This seems reasonable. That being said, I'm not sure we can do this with the TabView currently. It almost seems like something the TabView should be doing for us. I'll file something upstream, since it doesn't look like there are any existing issues.

@austin-beer , @zadjii-msft - this looks very similar to #3638

@austin-beer , @zadjii-msft - this looks very similar to #3638

It sure is! Thanks!
/dup #3638

It sure is! Thanks!
/dup #3638


saveDeployDefaults before deploying Trial app

Extracted these changes out of #1614
This makes it so when deploying a trial app, the user doesn't have to pick the trial app node as the deploy target.

I'm wondering if we should also check if they are logged in before we call saveDeployDefaults. If they are logged in we might not want to save the trial app as default. Or maybe if they are logged in we prompt like we normally do.

I agree with that.  We should probably only save the defaultNodeId if they're not logged in.  Otherwise when they deploy, they'll be asked if they want to deploy to this app, which is the normal user experience.
P.S. Good initiative extracting it out into a function :)


SizeT: make SizeT.t a new type

This PR improves responsiveness whenever we use a SizeT.t in a context where it is wrong to do so, like if the expected type is int (and we forgot the v). Instead of trying to prove int == SizeT.t by SMT, F* will now just fail during typechecking/unification. All other integer types already use new.
To do this, we must redefine SizeT.t as a fresh inductive, otherwise we cannot claim that it is new. I wonder if there's a reason against this, since I remember that this module had some custom extraction rules. Maybe @R1kM or @msprotz know?

I think the custom extraction rules are in FStar.Extraction.Krml.fs and as long as you can still pattern-match just like before, it should be good.
I think before the new keyword existed, you had to do something like:
type t = t'
type t' = | T: ...

and then sometimes in reduction you would see one or another which complicated the custom extraction. But that was ages ago, and I'm not even sure I remember this correctly.

I got an everest green locally, so I think this should be fine. Also HACL* dist had no diff, but I'm not sure if it's still regenerated on every make? I'm merging, please report if you find anything weird.

sadly HACL* has not been switched over to use sizet so I'm not surprised there's no diff there -- ping @cmovcc though for the starmalloc diff

Can confirm that StarMalloc's dist/ is left unchanged by this PR. Thanks for the ping Jonathan!


Suggestion: Alter LoggingConnector default TensorboardLogger when trainer.default_root_dir is specified

Proposed refactor
In the LoggerConnector, replace;
def configure_logger(self, logger: Union[bool, LightningLoggerBase, Iterable[LightningLoggerBase]]) -> None:
        if isinstance(logger, bool):
            # default logger
            self.trainer.logger = (
                TensorBoardLogger(
                    save_dir=self.trainer.default_root_dir,
                    version=self.trainer.slurm_job_id,
                    name="lightning_logs"
                )
                if logger
                else None
            )
        elif isinstance(logger, Iterable):
            self.trainer.logger = LoggerCollection(logger)
        else:
            self.trainer.logger = logger

with
def configure_logger(self, logger: Union[bool, LightningLoggerBase, Iterable[LightningLoggerBase]]) -> None:
        if isinstance(logger, bool):
            # default logger
            self.trainer.logger = (
                TensorBoardLogger(
                    save_dir=self.trainer.default_root_dir,
                    version=self.trainer.slurm_job_id,
                    name=("lightning_logs" if not self.trainer.default_root_dir else ""),
                )
                if logger
                else None
            )
        elif isinstance(logger, Iterable):
            self.trainer.logger = LoggerCollection(logger)
        else:
            self.trainer.logger = logger

Motivation
Traditionally, the default logger structure will produce files that look like:
lightning_logs/
    version_0
    version_1
    ...

When default_root_dir is specified, however, this causes a somewhat unintuitive behavior, as it inserts an extra 'lightning_logs' on top of the expected root directory:
default_root_dir='train_logs'
train_logs/
   lightning_logs/
       version_0
       version_1
       ...

making this change alters the log directory structure by default to place the version_x files directly in the default_root_dir, which IMO seems a bit more intuitive to the notion of the default_root_dir (and allows users to take a bit more control over the behavior of the logging module without forcing them to override the logger):
default_root_dir='train_logs'
train_logs/
    version_0
    version_1

Reasons not to do this
To be honest, this is really a minor nit: if it really bugs anyone, then they can override the logger directly by replacing it with the above code. It may break users who expect the lightning_logs directory in every output. Possibly could be a complex change relating to the log directory structure (if other callbacks rely on the default logger name to get output locations).

Bump as not stale / needs triage


OnMapReady callback, addMarker does not work.

Tangram 0.7 version error
RESULT:
At onMapReady() function, I write code
marker = mapController.addMarker();
marker.setStylingFromString(U.clickEffectStyle);
marker.setDrawable(U.selectedCircleDrawable);
marker.setDrawOrder(0);

But this marker did not appear.
ENVIRONMENT:
Nexus 5X, Naugat 7.1.1
Tangram 0.7.0
OTHER:
To solve this problem I write code
new Handler().postDelayed(new Runnable() {
                        @Override
                        public void run() {
                            marker = mapController.addMarker();
                            marker.setStylingFromString(U.clickEffectStyle);
                            marker.setDrawable(U.selectedCircleDrawable);
                            marker.setDrawOrder(0);
                        }
                    }, 150);

and It works. I think that marker can be drawn after some internal tangram task ...

Thanks for the report! This is interesting. Don't you set any geometry on the marker, e.g. setPoint()?
I've tested this snippet in onMapReady in the demo app and it works:
     LngLat startPoint = new LngLat(-74.00976419448854, 40.70032700869127);
     Marker p = map.addMarker();
     p.setStylingFromPath(pointStylingPath);
     p.setPoint(startPoint);
     pointMarkers.add(p);
     map.setPosition(startPoint);

I write wrong sample code on top
I write my code
public Marker getMarker() {
  Marker marker = mapController.addMarker();
   marker.setStylingFromString(U.clickEffectStyle);
   marker.setDrawable(U.selectedCircleDrawable);
   marker.setDrawOrder(0);
   return marker;
}

@Override
public void onMapReady(MapController mc) {

  // ...
   Marker maker = getMaker();
   marker.setPoint(position);
}

and It doesn't work at onMapReady function.
MyMapView is on Fragment and ViewPager have fragment. I guess this structure causes problem. But I don't know exact cause.
At click callback or after 150 or more after onMapReady drawing marker works well, but only in onMapReady it doesn't work

Oh I found why My code does not work!!
At onMapReady function
@Override
public void onMapReady(MapController mapController) {

  List<SceneUpdate> sceneUpdateList = new ArrayList<>();
  // add scene ...
  mapController.queueSceneUpdate(sceneUpdateList);
  mapController.applySceneUpdates();

  // draw marker, getMaker  function is same as above code
  Marker maker = getMaker();
  marker.setPoint(position);
}

I think that after sceneUpdate is done, map is initialized.
so I do sceneUpdate at getMapAsync() . and It works thank you

Glad to hear you found a solution! You can also apply your scene updates the first time the map is loaded by passing a list of updates as the 3rd argument to getMapAsync(), if that simplifies your application.


Fix broken nick autocomplete caused by #856

Since #856 changed the structure of the userlist, it couldn't find the users to use to autocomplete

Thanks!

Woops, good catch and great community work!!


Add "additional config" to PBft

This obsoletes the need for ExtNodeConfig for PBft. Flattening the
PBft structure will be necessary; a later step (it will require a few
steps in the middle) will be to flatten WithEBBs also.
The particular flattening in this PR is needed because we're going to
pass context to the DSIGN algorithm, and that context is the node config
-- but ExtNodeConfig just calls applyChainState on the underlying
protocol, so we'd lose the context we need by the time that we actually
need it.

@mrBliss just for you, removed the cfg argument. Don't say I never do anything for ya :grin:


Customizable select and dropdown menu

Hello,
since I needed a customizable drop-down menu, I tried adding this option to your library. I hope it will be useful to someone else as well.
I'm not sure about the select version, but the drop-down menu seems to work quite well.

@MPapini91 thank you very much for your contribution!

Good catch! Thanks for reporting that 🙏 @stevermeister shall I file an issue for this?

@bampakoa yes, please!

@stevermeister it is tracked at #172 Thanks @MPapini91 for pointing it out 🙏


add a button (or something) to fetch latest data

There's no easy way to fetch latest data if I have a chart currently open (e.g. had it open last night, want to see new data reported overnight)

@cjosephson I would love work on this. If possible can you provide steps to reproduce?


Jenkinsfile: do not push images if job was PR-triggered

I have understood the the images created in PR-triggered builds dont get any use afterwards, so the idea is to reduce stress and space consuming on registry, also saving some job time.
I moved push stmt from post block to become a stage, as I think conditional is not possible in post block.
Running push as a last stage instead of post-if-success should have same effect.

Codecov Report

Merging #1022 (72f577c) into main (5ebd0d3) will increase coverage by 0.06%.
The diff coverage is n/a.

:exclamation: Current head 72f577c differs from pull request most recent head 1b815e9. Consider uploading reports for the commit 1b815e9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   53.02%   53.09%   +0.06%
==========================================
  Files          40       40
  Lines        4351     4351
==========================================
+ Hits         2307     2310       +3
+ Misses       1917     1915       -2
+ Partials      127      126       -1

Impacted Files
Coverage Δ

pkg/deviceplugin/server.go
85.05% <0.00%> (+1.72%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Arnej/set rawscore for locations

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@havardpe please review
@toregge FYI
i believe we can remove the old iterator afterwards.

@arnej27959 Do we have sufficient testing of the location iterators (and use of raw score)?


Configuring documentation

Codecov Report

Merging #1 (577363e) into master (8244bfe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          103       103
  Branches        13        13
=========================================
  Hits           103       103

Impacted Files
Coverage Δ

chatter/bot.py
100.00% <ø> (ø)

chatter/chat_client.py
100.00% <ø> (ø)

chatter/feature.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8244bfe...577363e. Read the comment docs.


added Rickshaw.version fixes #538 fixes #224

Coverage remained the same at 62.814% when pulling 28f45cb3b3754e151d56e9558bb2ca1eab1ae383 on cesine:preversion into f92fe3d6237dd0ccdee834e9b7594c298d04b373 on shutterstock:master.

Coverage remained the same at 62.814% when pulling c52d5ee22ffa57739dc195611ee1811bbb71379b on cesine:preversion into f92fe3d6237dd0ccdee834e9b7594c298d04b373 on shutterstock:master.


Performance improvements

Some perf improvements regarding the flatpages extension. Relevant because these are loaded on every request (News & Navbar depend on that).
left to do:

[ ] lazy loading (i.e., server side rendering) of meeting calendar

some hyperfine reports (not logged in, no session cookies) along these commits:
(sipa) ➜  sipa git:(305aa27) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      46.6 ms ±   3.6 ms    [User: 2.8 ms, System: 2.9 ms]
  Range (min … max):    42.9 ms …  66.5 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(318da40) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      46.0 ms ±   8.1 ms    [User: 2.9 ms, System: 2.4 ms]
  Range (min … max):    40.3 ms …  90.2 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(7ae0ed0) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      43.8 ms ±   2.9 ms    [User: 2.4 ms, System: 2.7 ms]
  Range (min … max):    40.3 ms …  61.9 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(1020047) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      46.1 ms ±   7.6 ms    [User: 2.5 ms, System: 3.0 ms]
  Range (min … max):    40.6 ms …  99.7 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(b18fc74) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      45.5 ms ±   8.5 ms    [User: 3.2 ms, System: 2.5 ms]
  Range (min … max):    40.0 ms … 121.2 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(a57e33b) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      25.8 ms ±   2.7 ms    [User: 3.2 ms, System: 2.5 ms]
  Range (min … max):    22.6 ms …  43.7 ms    100 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

(sipa) ➜  sipa git:(560f52e) hyperfine --warmup=100 --runs=100 'curl -s http://localhost:5001/news/ -o /dev/null'

Benchmark 1: curl -s http://localhost:5001/news/ -o /dev/null
  Time (mean ± σ):      12.8 ms ±   0.8 ms    [User: 3.3 ms, System: 2.4 ms]
  Range (min … max):    11.2 ms …  17.0 ms    100 runs


Wrap around negative indexing for cuda atomic operations

Feature request
The CUDA atomic operations currently do not support negative indices as offset from the end of the array. One would expect that
cuda.atomic.add(ary, idx, val)
performs
ary[idx] += val
Like the docs state, independent of whether idx is negative or positive. This can lead to anoying bugs to track down if you translate sequential code to parallel code.

I think the documentation is further misleading - for example, might one expect:
cuda.atomic.add(ary, slice(2,4), val)

to add val to elements 2 and 3 of ary?
I think this is both a documentation bug and a feature request, so I'll label as such.

Adding support for negative indices seems pretty easy to me, as cgutils.get_item_pointer already support wraparound.
https://github.com/numba/numba/blob/00ad12751725391e8423d67ef845ba56110c55df/numba/cuda/cudaimpl.py#L610
https://github.com/numba/numba/blob/00ad12751725391e8423d67ef845ba56110c55df/numba/core/cgutils.py#L667-L668

This is now implemented.


Build error with stack on Ubuntu

While trying to build the slack-lambdabot package that depends on slack-api, I encountered an issue when trying to build with the latest version (0.12). The slack-lambdabot package depends on the 0.6 version, but that version unfortunately causes a hard runtime error because of a missing JSON field. Looking up this error on Google, I read about how Slack apparently changes its API in breaking ways, requiring a newer version of the slack-api package, which is why I tried it with 0.12 in the first place.
Here is the specific error I get:
--  While building package slack-api-0.12 using:
      /home/mhenrion/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-7.10.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
    Logs have been written to: /home/mhenrion/slack-lambdabot/.stack-work/logs/slack-api-0.12.log

    Configuring slack-api-0.12...
    Building slack-api-0.12...
    Preprocessing library slack-api-0.12...
    [ 1 of 29] Compiling Web.Slack.Utils  ( src/Web/Slack/Utils.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Utils.o )
    [ 2 of 29] Compiling Web.Slack.Types.Topic ( src/Web/Slack/Types/Topic.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Topic.o )
    [ 3 of 29] Compiling Web.Slack.Types.Time ( src/Web/Slack/Types/Time.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Time.o )
    [ 4 of 29] Compiling Web.Slack.Types.Presence ( src/Web/Slack/Types/Presence.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Presence.o )
    [ 5 of 29] Compiling Web.Slack.Types.Preferences ( src/Web/Slack/Types/Preferences.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Preferences.o )
    [ 6 of 29] Compiling Web.Slack.Types.Id ( src/Web/Slack/Types/Id.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Id.o )
    [ 7 of 29] Compiling Web.Slack.Types.Self ( src/Web/Slack/Types/Self.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Self.o )
    [ 8 of 29] Compiling Web.Slack.Types.TeamPreferences ( src/Web/Slack/Types/TeamPreferences.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/TeamPreferences.o )
    [ 9 of 29] Compiling Web.Slack.Types.Error ( src/Web/Slack/Types/Error.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Error.o )
    [10 of 29] Compiling Web.Slack.Types.Comment ( src/Web/Slack/Types/Comment.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Comment.o )
    [11 of 29] Compiling Web.Slack.Types.ChannelOpt[boot] ( src/Web/Slack/Types/ChannelOpt.hs-boot, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/ChannelOpt.o-boot )
    [12 of 29] Compiling Web.Slack.Types.IM ( src/Web/Slack/Types/IM.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/IM.o )
    [13 of 29] Compiling Web.Slack.Types.Channel ( src/Web/Slack/Types/Channel.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Channel.o )
    [14 of 29] Compiling Web.Slack.Types.Base ( src/Web/Slack/Types/Base.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Base.o )
    [15 of 29] Compiling Web.Slack.Types.Bot ( src/Web/Slack/Types/Bot.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Bot.o )
    [16 of 29] Compiling Web.Slack.Types.File ( src/Web/Slack/Types/File.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/File.o )
    [17 of 29] Compiling Web.Slack.Types.Item ( src/Web/Slack/Types/Item.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Item.o )
    [18 of 29] Compiling Web.Slack.Types.Event.Subtype ( src/Web/Slack/Types/Event/Subtype.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Event/Subtype.o )
    [19 of 29] Compiling Web.Slack.Types.Message ( src/Web/Slack/Types/Message.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Web/Slack/Types/Message.o )

    /tmp/stack98644/slack-api-0.12/src/Web/Slack/Types/Message.hs:110:5:
        ‘toEncoding’ is not a (visible) method of class ‘ToJSON’

    /tmp/stack98644/slack-api-0.12/src/Web/Slack/Types/Message.hs:110:20:
        Not in scope: ‘toEncoding’
        Perhaps you meant ‘sumEncoding’ (imported from Data.Aeson.TH)

Needless to say, any help would be greatly appreciated!

The lower bound for aeson is wrong, it should be aeson >= 0.11.


[FEATURE] Translation of labels into Italian

I would like to propose the addition of Italian label translations to make the user experience more accessible for Italian speakers. I am willing to personally take care of the translation and implementation of these changes. This issue serves as a starting point to discuss the best approach and gain the consensus of the community and project maintainers. It would be a pleasure to contribute to making "Dungeon Paper" more inclusive for the Italian community.

Hi @KernelPanic92, thanks for opening the issue!
I appreciate your willingness to help.
Note that this is no small undertaking, so if you get help it will make things easier. I myself don't know Italian so I can't help unfortunately. I will also have to trust you to have good translations and not joke/harmful ones. Please be kind :)
If you want to get started translating, there are 2 main areas to focus on.

The app itself needs translation
All the DW data needs translation

Here are some instructions to get started:
Translating the app
For translating the app, you will want to:

Fork this repository
If you want to actually run the app, it will be an involved process. Let me know and I will update some documentation and provide some more info.
Find the file lib/l10n/intl_en.arb
Copy it to the same directory and name it something like intl_it.arb.
Go over the values of each key in the JSON file (not the keys!) and translate them. Here is official documentation to read. TLDR:

There are programs to help you do that if you want
ARB files have tokens inside them. The following should not be translated:

Variable tokens like {coins}

SELECT statements have the following format, the number labels are to easily reference them when I explain here:
  1      2      3        4        3         4            3           4
{var, select, opt1 {opt 1 label} op2 {opt 2 label} ... other {unmatched label}}`

Example:
{alignment, select, chaotic {Chaotic} evil {Evil} good {Good} lawful {Lawful} neutral {Neutral} other {{alignment}}}
1, 2 and 3 should not be translated. Only 4.

PLURAL statements are similar to SELECT statements -
{count, plural, =0 {No coins} one {One coin} other {{fmtCount} coins}}

Translating the DW data

Fork the repository https://github.com/DungeonPaper/dungeon_world_data
Find the directory lib/data/en-US
Copy the directory and add the language code as the dir name, e.g. it-IT
Start translating all the values of the game data. Again, keys should not be updated (in: "name": "Divine Protection", only the "Divine Protection" part should be translated, not "name"

What then?
You can open a PR for each repo and once I make sure it looks good we can merge it in.
I will have to also work on some small updates to the mechanisms involving changing the language on the app, so that will probably also take a bit.

See translation section at the README file


tinyllama training?

is there any code for training tinyllama, I just saw the code for llama inference.

There's a 500$ bounty for "Training TinyLlama with >50% MFU"

so there is no any basic training code with low MFU to use, right?

maybe I should add the baseline code for tinyllama training?


feat: supports configs.config.mjs

:tada: This PR is included in version 6.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Droplet out of memory

Describe the bug
Droplet out of memory
To Reproduce
Steps to reproduce the behavior:

Use all available disk space

Screenshots

Partly solved by deleting ELK volume (which was about 5GB)
Steps to implement a temporary solution:

[ ] Delete ELK volume
[ ] Accept pull req #305
[ ] Deactivate ELK stack in compose.prod
[ ] Run ./run_script.sh


Capital letters not allowed in .ogg file names

Some time after 1.19.2, Mojang decided that they shouldn't allow capital letters in .ogg file names, and rather than simply ignore that particular file, they decided to invalidate the entire JSON file, breaking every sound in your pack.
Despite capital letters being perfectly valid JSON, I now need to make the pack checker scan for capital letters and flag an error.
Thanks, Mojang!

I think the file count is still off, because it counts a file with the wrong case as being part of the pack, but this is less urgent than the previous commit.


Add exporter and integration test for docker

Towards #1
This adds the exporter code, a Dockerfile and a first integration test that uses the Docker container.
As you can see it took a few commits 😅 but the github action is done. It uses a local docker registry. The integration test is just a go test that connects to the container on port 8000.
Later I'd like to add deployment manifests for Nomad and Kubernetes and we can add more integration tests for them.

@ofpiyush I'm pretty happy with this, personally. Because there's not much to merge into, are you cool with raising any issue in an separate PR, or making any separate issue for stuff that leaps out at you?

@rossf7 we don't have any real guidelines about merges vs rebases in git repos at TGWF. What do you prefer to work with on go projects?
Once I know, I'll either merge in, or rebase accordingly, as I'm happy with this 👍

We don't have any real guidelines about merges vs rebases in git repos at TGWF. What do you prefer to work with on go projects?

Thanks @mrchrisadams I'm used to doing squash merges but the history was messy. So I cleaned it up and did a force push. I hope that's OK? I try to avoid force pushes but seemed like a good option in this case.
I don't mind if we merge or rebase. Also I think you can run github actions locally. I'll try that next time as it also means there is a shorter feedback loop when working on the tests.

Yes I will find proper time to look at this over the weekend.
No reason to block both of you till then.
I'll create issues if I see something odd.
Squash merge is my default too!

Great, thanks @ofpiyush!


(refactor, bugsbash) fixes implicit memory aliasing in for loop.

Signed-off-by: aSquare14<EMAIL_ADDRESS>Related to bugsbash

Codecov Report

Merging #576 (7771b24) into master (8431671) will increase coverage by 0.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   48.55%   49.30%   +0.74%
==========================================
  Files          73       73
  Lines        3359     3359
==========================================
+ Hits         1631     1656      +25
+ Misses       1572     1551      -21
+ Partials      156      152       -4

Impacted Files
Coverage Δ

db/kubernetes/convert.go
61.11% <0.00%> (ø)

...er/blockdeviceclaim/blockdeviceclaim_controller.go
39.52% <0.00%> (ø)

cmd/ndm_daemonset/probe/udevprobe.go
66.29% <0.00%> (+3.86%)
:arrow_up:

cmd/ndm_daemonset/probe/addhandler.go
75.25% <0.00%> (+4.12%)
:arrow_up:

cmd/ndm_daemonset/probe/eventhandler.go
50.90% <0.00%> (+10.90%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8431671...7771b24. Read the comment docs.


Update to disable collecting PodLogs by default & rev Conformance versions

Due to reported experience #84
However I was not able to repro a bug that was reported there.
Signed-off-by: Timothy St. Clair<EMAIL_ADDRESS>

did you mean #82? #84 seems unrelated

@chuckha yes.  updated.


Create a function or class that appends the summary contents for a sprint to the single history file for the particular project

I've got some of this already operational.
What I want to do with this is to print out a standard 1 line summary of the current sprint snapshot to a file for a particular project.
In addition to the column points count, the line will have a date stamp, a sprint name, and (and this is not yet in the code I have yet) a marker for the sprint kickoff measurement.

I could use the number 1 for the sprint start measurement and 2 for the last sprint measurement.
I could also throw in a 4 to represent a regular measurement.
Or use text tags instead. Not important as long as the markers are there.
The time needs to be something that is easily understood by the machine.
I could add an additional column for human friendly time/date.

Having this data start to accumulate will be a big step towards feeding reports.

Today to help me understand if the results are accurate I added item counts to the summary report:
Column	Size	CardCount
▶ SPRINT READY	370	18
This Sprint 🏃♀ 🏃	36	5
IQSS Team - In Progress  💻	162	8
Ready for Review ⏩	43	5
In Review 🔎	43	8
Done 🚀	929	497
ActiveSprint	284	26

So that now the resulting transposed data has 2 lines:
▶ SPRINT READY This Sprint 🏃♀ 🏃 IQSS Team - In Progress  💻 Ready for Review ⏩ In Review 🔎 Done 🚀 ActiveSprint      DateTime  SprintName
           370                 36                        162                 43          43    929          284 datetimestamp sprint_name
            18                  5                          8                  5           8    497           26             -           -

This needs to be dealt with

I made a lot of progress on this.
The last piece will be to the the results out to a file
I will leave it off there
The file contents look like this
DateTimeStamp	SprintName	▶ SPRINT READY	This Sprint 🏃♀ 🏃	IQSS Team - In Progress  💻	Ready for Review ⏩	In Review 🔎	Ready for QA ⏩	QA ✅	Done 🚀	SprintActiveCards	▶ SPRINT READY_	This Sprint 🏃♀ 🏃_	IQSS Team - In Progress  💻_	Ready for Review ⏩_	In Review 🔎_	Ready for QA ⏩_	QA ✅_	Done 🚀_	SprintActiveCards_
2023_04_26-17_32_18	No Sprint Name	370	36	162	43	43	0	0	929	654	18	5	10	4	8	0	0	497	45


Purge subtypes that do not map nicely to HXB2

Alternatively, try to modify them slightly, as we have done with HXB2 sequence.


Add a notice to virtctl console about logs

What this PR does / why we need it:
Guest serial console output can now be streamed
to cluster logs. This could be eventually enabled
at cluster level being not so visible to VM owners. Those logs include the boot logs but also the output of an interactive usage of the first serial console. No access passwords for the console nor
properly handled passwords (not echoed to the screen) are going to be collected n the logs.
However, if the VM user types a password by mistake instead of a command name or if the password is visible on the screen as a clear text parameter or in the
output of any command, it could be streamed
to cluster logs along with all other screen visible text.
Let's have virtctl console emitting a notice
(if LogSerialConsole is not explicitly disabled) for the user suggesting to use SSH when handling sensitive informations.
Adding a test covering virtctl console output.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/CNV-34999
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[X] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[X] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Add a notice to virtctl console about logs

/retest

/hold

/cc @nunnatsa

Closing: after debating it, we decided to close this since every virtualization system (excluding confidential computing ones) is potentially exposed and so the warning is pointless.


No JSON in response for Radarr v<IP_ADDRESS>22. Sonarr is working perfectly.

URL is correct, I copied Sonarr URL to Radarr slot and it doesn't work. Maybe some API changes in Radarr.

I know I can't use Sonarr URL for Radarr, I meant the URL address is correct, as Sonarr works.
I'll wait for you update  the script to support V4 then. My Radarr automatically updates to latest version, I'm guessing you turned off auto updates.

Should be fixed in v15.2.


CPU intrinsics

This pull request is here to generate some discussion about integrating the CPU intrinsics available in .NET Core 3.0 into NAudio by providing a code example of how it might be integrated into a class.
I benchmarked this pull request, and as expected, VolumeSampleProvider runs significantly faster:

Is this compatible with your vision for NAudio?
Would you be interested in a larger pull request that uses intrinsics in a wide variety of places?

I've set up a proper benchmarking project in my repo to allow for impartial comparison.
Benchmark for VolumeSampleProvider:

I'm initially focusing on the classes that I use personally so my next class to optimise is the BiQuadFilter.

Haven't had a chance to look at this in detail yet (unfortunately, other projects taking priority at the moment), but just wanted to jump in and say I like the idea of providing optimised versions of some of these classes, and looks like you've achieved a really impressive  speedup there.
One thing that I have been experimenting with is whether an NAudio 2.0 should fully embrace Span. I made a quick proof of concept a while ago in this repo.  With this approach ISampleProvider would look like this
If I do get time to create that sort of NAudio 2.0, then making use of new features like CPU intrinsics would definitely be of use. There are also some benefits of making use of the new compiler intrinsics to access the Calli instruction which would help resolve some threading headaches with the COM interop
For the existing NAudio 1.9, I'm happy to take PRs for any performance changes that don't make breaking changes to the public interface, and have been adequately tested.

I would say the use of Span in the way you suggest for NAudio 2.0 is ideal. The existing offset and sampleCount simply become:
volumeSampleProvider.Read(buffer.Slice(offset, sampleCount));

This is still a very interesting prospect, I'd like to see these tests done in .NET 5 to see if there's even more of a performance bump.
Are we going to see something like this in the next version of NAudio?

.NET 5 doesn't provide any additional gain in the case where CPU intrinsics are used.
(understandably - CPU instrinsics is the absolute fastest way to do this)

In the case of no CPU instrinsics being used, the act of simply moving to .NET 5 from a .NET Core runtime does not yield any improvement.

Still, CPU intrinsics appear to be a clear win even if there's no difference between 3.1/5.0

Yep, another example of CPU intrinsic speed up is in #794 if you’re curious.


webview_flutter: loadHtmlString Unable to correctly parse image address

Steps to reproduce
loadHtmlString(htmlData, baseUrl: 'http://<IP_ADDRESS>:8686');
print(htmlData);
can show image
img src="https://www.mlito.com/wp-content/uploads/2018/03/bf478dbc95-768x1152.jpg"  data-mce-src="https://www.mlito.com/wp-content/uploads/2018/03/bf478dbc95-768x1152.jpg"
can't show image
img src="http://<IP_ADDRESS>:8686/upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"  data-mce-src="../upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"

Expected results
show correct
img src="http://<IP_ADDRESS>:8686/upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"  data-mce-src="../upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"
Actual results
show error
img src="http://<IP_ADDRESS>:8686/upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"  data-mce-src="../upload/202405/23/75FF1B117A2B4887910110F0D2F9F6A1.jpg"
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[Paste your output here]

@qiuweilu
Your issue is not clear to me. Please provide clear reproducible code sample along with actual vs expected behavior in properly formatted text so that we can properly address the issue.

@qiuweilu
Please check plugin example and see if using it you still get same behavior or not.


Fixes for jobqqeue_init and removed exit()

OK, I think your code is more readable so the redundancy seems justified.

Hi Johan,
thank you for your feedback. jobqueue_clear() unfortunately also calls bsem_reset(). bsem_reset() calls bsem_init() and this function initializes the bsem mutex (that is already initialized at that point. So jobqueue_clear() should not be called here ;-)
If you would accept my merge request I´ll send a second one for the unlikely required free()s in the case a malloc() returns NULL.
BTW: Thank a lot for your very handy piece of code. It is quite often usable - very cool :)

I see your point. Well I merged the request now and it seems to pass the tests. So cheers for that!
PS. Good to hear :)


Fail to parse FQ cards

Describe the bug
It seems that montepy is not able to parse correctly FQ cards
To Reproduce
problem = montepy.read_input("foo.imcnp")

Error Message (if any)
Traceback (most recent call last):
  File "D:\DATA\laghida\Documents\test\profiler_cmodel.py", line 11, in <module>
    problem = montepy.read_input(input_file)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\input_parser\input_reader.py", line 31, in read_input
    problem.parse_input(replace=replace)
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\mcnp_problem.py", line 382, in parse_input
    raise e
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\mcnp_problem.py", line 367, in parse_input
    obj = obj_parser(input)
          ^^^^^^^^^^^^^^^^^
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\data_inputs\data_parser.py", line 47, in parse_data
    return data_input.DataInput(input, prefix=prefix)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\data_inputs\data_input.py", line 340, in __init__
    super().__init__(input, fast_parse)
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\data_inputs\data_input.py", line 58, in __init__
    super().__init__(input, self._parser)
  File "C:\ProgramData\Anaconda3\envs\monte\Lib\site-packages\montepy\mcnp_object.py", line 59, in __init__
    raise ParsingError(
montepy.errors.ParsingError:     test.i, line 13

        14| FQ11    s u
        15| C
The input ended prematurely.
sly: Parse error in input. EOF

MCNP input file snippet
If applicable, please include a small section of the input file you were working on. If it includes any specific values please change or remove them. For example:
TEST
1 0 -1 IMP:N=1
2 0 1 IMP:N=0

1 SO 20

NPS 1
MODE N
C
FC11    Neutron current
F11:N   1
FT11    INC
FU11    0 1
FM11    1.9730E+19
FQ11    s u
C

Version

Version 0.5.0

Thanks @dodu94. This doesn't surprise me with how FQ syntax is. This should be tackled with #11.
Though a stop gap measure is probably a good idea.

I quickly went through #11 and, if I understand correctly, that is about having a full support of tallies. I support that, but in the meantime I guess montepy should just recognize FQ simply as a data card without knowing what it is exactly and just go on with the parsing right?

Yes. It's just that we don't have a rule for a data card that is all text right now. So yes we'll do a stop gap measure to just make it parsable and not error out.


feat: use read API for interleaved rows

This PR changes how interleaved rows are retrieved in the generated API.
Previously interleaved APIs were always executed by running a SQL query with the
interleaved rows hoised to the parent table with SELECT AS STRUCT.
This led to excessive table scanning when using filters (either primary keys or
arbitrary filters), because all interleaved rows would need to be scanned before
the filter was evaluated.
Since interleaved tables can not be part of the filters, these excessive read was wasteful.
Instead interleaved tables are always read with read API after the parent rows have been
loaded. This ensures that no excessive table scanning occurs.
One downside is that it is not possible to stream interleaved reads (need to correlate
interleaved rows to their parent), and instead rows are buffered in memory. However,
it is likely that callers would buffer the results anyway, so will probably not be an issue.
No breaking changes in the API (same query struct etc) but some changes have been made
in the interpretation of options:

Interleaved rows that are deleted are never returned, even if ShowDeleted is set to true.
This can be changed, but for now this seems like the most sensible default.

Callers using interleaved APIs must provide a ReadOnlyTransaction (instead of a Single)
because of the read APIs happening in different calls to Spanner.

RowIterator is changed to an interface (instead of struct) to hide the buffered approach
when reading interleaved tables. The old struct is kept, but renamed to streamingRowIterator.

fix!: put row iterator behind interface
feat: implement buffered row iterator
feat: implement read interleaved rows helper
feat: implement get row interleaved  with read API
feat: implement batch get interleaved with read API
feat: implement list interleaved with read API

Codecov Report

Merging #71 (3cee691) into master (12032b1) will increase coverage by 2.59%.
The diff coverage is 50.25%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   42.76%   45.36%   +2.59%
==========================================
  Files          20       20
  Lines        3157     3040     -117
==========================================
+ Hits         1350     1379      +29
+ Misses       1718     1560     -158
- Partials       89      101      +12

Impacted Files
Coverage Δ

internal/examples/musicdb/database_gen.go
22.18% <21.05%> (-5.00%)
:arrow_down:

internal/examples/freightdb/database_gen.go
25.69% <35.90%> (+9.40%)
:arrow_up:

...nternal/codegen/databasecodegen/readtransaction.go
100.00% <100.00%> (+2.14%)
:arrow_up:

internal/codegen/databasecodegen/rowiterator.go
100.00% <100.00%> (ø)


Fix switchless sample code

In order to use the switchless feature of the SGX, the app binary needs
to be linked with the following flags.
-Wl,--whole-archive -lsgx_uswitchless -Wl,--no-whole-archive

Noted that there is currently no proper way to pass custom link flags to
all the binaries in a cargo project. As such, the link_args macro need
to be set for each of Rust files with main methods.
References:

Build flags used in Intel SGX sample code: https://github.com/intel/linux-sgx/blob/ce4a18d9a0963b14f717cc7462241cfadd233f55/SampleCode/Switchless/Makefile#L104
Rust tracking issue on link_args: https://github.com/rust-lang/rust/issues/29596
PR for cargo:rustc-link-arg-bins in cargo build script: https://github.com/rust-lang/cargo/pull/8441

thanks!

I understand this issue has been closed but I needed more clarity on this one.  I tried including -Wl,--whole-archive -lsgx_uswitchless -Wl,--no-whole-archive in my file with main() however I run into following error:
= note: /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sl_urts_loader_untrusted.o): In function urts_loader_t::urts_loader_t()':
sl_urts_loader_untrusted.cpp:(.text._ZN13urts_loader_tC2Ev+0x8): undefined reference to sgx_set_switchless_itf'           /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sl_workers_untrusted.o): In function tworker_process_calls':
sl_workers_untrusted.c:(.text.tworker_process_calls+0x21): undefined reference to sl_run_switchless_tworker'           /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sgx_ecall_switchless_untrusted.o): In function init_tswitchless':
sgx_ecall_switchless_untrusted.c:(.text.init_tswitchless+0x10): undefined reference to sl_init_switchless'           collect2: error: ld returned 1 exit status
Looks like it cannot find sgx_urts or other files.  Not sure what I am missing here.
Apologies in advance if this is not the right place to post this.

I understand this issue has been closed but I needed more clarity on this one. I tried including -Wl,--whole-archive -lsgx_uswitchless -Wl,--no-whole-archive in my file with main() however I run into following error: = note: /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sl_urts_loader_untrusted.o): In function urts_loader_t::urts_loader_t()': sl_urts_loader_untrusted.cpp:(.text._ZN13urts_loader_tC2Ev+0x8): undefined reference to sgx_set_switchless_itf' /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sl_workers_untrusted.o): In function tworker_process_calls': sl_workers_untrusted.c:(.text.tworker_process_calls+0x21): undefined reference to sl_run_switchless_tworker' /opt/intel/sgxsdk/lib64/libsgx_uswitchless.a(sgx_ecall_switchless_untrusted.o): In function init_tswitchless': sgx_ecall_switchless_untrusted.c:(.text.init_tswitchless+0x10): undefined reference to sl_init_switchless' collect2: error: ld returned 1 exit status  Looks like it cannot find sgx_urts or other files. Not sure what I am missing here. Apologies in advance if this is not the right place to post this.

You can refer to switchless example

Hi @volcano0dr , thank you for your response.  I did refer to this switchless example.  However, it still doesn't work.
Original post states that the switchless flag is required in link_args wherever main is.  Does this mean entry point? My cargo project builds internally calls to build shared library with trusted and untrusted code.  The error I run into is linking of this sgx_uswitchless, where the error probably wants path using -L.  But that causes a cascaded effect as it cannot find other dependent libraries.


Allow setting admin password by configuration

When the admin username / password is set via configuration (parameters admin.create, admin.username, admin.password) and the admin username already exists, then the admins password should be updated according to the configuration parameter.

invalid issue


Improve diffing between previous release and new dist

What
Limit the chances of Git considering that the files in the previous release and the ones in the release PR are different files entirely, as it leads to the diff showing the old file being removed and the new one being created.
We're currently using Git's -M/--find-renames option for which we can adjust the similarity index. This may just be pushing the issue to a later point, so it could be worth considering other routes (explicitely naming the files to compare, for example, as our releases as pretty structured).
Why
The last release's diff had to be done locally rather than through the action as Git decided the old and new files were entirely different.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[ ] We've implemented a way of diffing that compares the actual contents of the new and old files more reliably

A suggestion by @36degrees for an alternative for not dealing with similarity index would be to compare the files using their explicit names, relying on the VERSION.txt file to pick the version number:
git diff $GITHUB_BASE_REF:dist/govuk-frontend-$(git show $GITHUB_BASE_REF:dist/VERSION.txt).min.css dist/govuk-frontend-$(cat dist/VERSION.txt).min.css


[SPARK-10554][Core] Fix NPE with ShutdownHook

https://issues.apache.org/jira/browse/SPARK-10554
Fixes NPE when ShutdownHook tries to cleanup temporary folders

Can one of the admins verify this patch?

ok to test

Merged build triggered.

Merged build started.

Looks fine. I would add a comment to explain that the blockManagerId could be null if the block manager is not initialized properly.

Test build #42345 has started for   PR 8720 at commit 2639ffd.

@andrewor14 fixed here 40e487b8f7ac636158a5e4be210bd173a80ce702

Merged build triggered.

Merged build started.

Test build #42354 has started for   PR 8720 at commit 40e487b.

Test build #42345 has finished for   PR 8720 at commit 2639ffd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ShuffleDependency[K: ClassTag, V: ClassTag, C: ClassTag](
class CoGroupedRDD[K: ClassTag](
class ShuffledRDD[K: ClassTag, V: ClassTag, C: ClassTag](
class MultilayerPerceptronClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,
class MultilayerPerceptronClassificationModel(JavaModel):
class StringIndexer(JavaEstimator, HasInputCol, HasOutputCol, HasHandleInvalid):
        ("thresholds", "Thresholds in multi-class classification to adjust the probability of " +
class HasHandleInvalid(Params):
class HasElasticNetParam(Params):
class HasFitIntercept(Params):
class HasStandardization(Params):
class HasThresholds(Params):
    thresholds = Param(Params._dummy(), "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")
        self.thresholds = Param(self, "thresholds", "Thresholds in multi-class classification to adjust the probability of predicting each class. Array must have length equal to the number of classes, with values >= 0. The class with largest value p/t is predicted, where p is the original probability of that class and t is the class' threshold.")

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42345/
Test FAILed.

Hm, it's failing the save hive test again. retest this please?

Merged build triggered.

Merged build started.

Test build #42360 has started for   PR 8720 at commit 40e487b.

Test build #42354 has finished for   PR 8720 at commit 40e487b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42354/
Test FAILed.

Test build #42360 has finished for   PR 8720 at commit 40e487b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42360/
Test PASSed.

Merged build finished. Test PASSed.

Merged to master / 1.5


Workbench 2023.03.0

Bump release version to 2023.03.0+386.pro1
Small update to sed expression so it would catch versions in READMEs

@ianpittwood did we want to batch any R / python version changes into this change of Workbench?

Nice! Yeah, I think dev-workbench is a great target. Or you can use this path for sure, too 😄