Missing acces-token in Response Header

I'm having a problem that the access-token in my Response Header is sometimes empty. My application is pretty new and I started with authentication. For my Frontend I am using React and the redux-token-auth library.
Registering and loggin in users works without a problem. After refreshing my page I send a request to validate my token. In the response I get the new access-token  which is stored in localStorage via redux-token-auth. Most of the time this process works like a charm but for some Requests the access-token in the Response is empty (still getting SUCCESS - 200), which breaks redux-token-auth because an empty access-token gets saved in localStorage.
Is this a problem with redux-token-auth and after a 200 I can just use the old access-token or is this a bug that an empty access-token is sent?
Versions:

Ruby 2.3.3
Rails 5.1.4
Devise Token Auth 0.1.43.beta1
Devise 4.3.0

Fronted:

redux-token-auth

Try turning off, "change_headers_on_each_request" . See the README

Random question from the README docs on this:

Note that when the server identifies that a request is part of a batch request, the user's auth token is not updated. The auth token will be updated and returned with the first request in the batch, and the subsequent requests in the batch will not return a token. This is necessary because the order of the responses cannot be guaranteed to the client, and we need to be sure that the client does not receive an outdated token after the the last valid token is returned.

Does the behaviour (of not returning an auth-token on batch requests) still occur if config.change_headers_on_each_request is set to false?  Or in those cases, will devise_token_auth always return an auth-token no matter how quickly it receives a batch of requests?

Or in those cases, will devise_token_auth always return an auth-token no matter how quickly it receives a batch of requests?

That should be correct. Are you seeing different behavior?

@lynndylanhurley   No I just wanted to confirm as the documentation didn't clarify, and it definitely would have definitely been a gotcha for my API consumers.  Thanks for clarifying!

I believe the explanation for blank token are here:
[https://github.com/lynndylanhurley/devise_token_auth/blob/master/docs/conceptual.md]

About batch requests
Note that when the server identifies that a request is part of a batch request, the user's auth token is not updated. The auth token will be updated and returned with the first request in the batch, and the subsequent requests in the batch will not return a token. This is necessary because the order of the responses cannot be guaranteed to the client, and we need to be sure that the client does not receive an outdated token after the the last valid token is returned.

Had the same issue. What I have noticed is that if devise_token_auth is not sending the token, it means the token hasn't changed since the last request. In other words, if the token is not present, use the one from the previous request. Works for both tokens that change on each request and those that don't.

also having same issue, token is created after user signup but not appended to header.

Update your gem. Force update.
The last version is working ok.
Em sex, 14 de jun de 2019 09:58, Alie-Ammaar<EMAIL_ADDRESS>escreveu:

also having same issue, token is created after user signup but not
appended to header.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lynndylanhurley/devise_token_auth/issues/1053?email_source=notifications&email_token=AAOMOSX4A2UH6GOUP5K2G43P2OIXXA5CNFSM4EJ36KP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWW4UQ#issuecomment-502099538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOMOSXISML54BM5S3WL2RTP2OIXXANCNFSM4EJ36KPQ
.

I already applied "change_headers_on_each_request" and updated the gem but the problem still there.
However, I saw that, if I use the create  method from the DeviseTokenAuth::SessionsController, the problem will not occur.
It just occured when I tried to override create  method in my controller.
Anyone have idea about it?

I am using redux-token-auth, and it does not handle missing token and just replaces with nil in localStorage, causing a logout(lost token).
I handled nil token in my requests, but seems like will have to do the same in external libs as well :/

I am using redux-token-auth, and it does not handle missing token and just replaces with nil in localStorage, causing a logout(lost token).
I handled nil token in my requests, but seems like will have to do the same in external libs as well :/

Same issue here, and i would like to use the feature to change tokens in each request, thats the main feature of this library.
@ziaulrehman40  Are you handling the token by setting the previous one when it comes null in the response? Are you doing it on front end or in Rails?

Issue was with redux token auth, i have wrote some patching scripts in it and have commented them on respective issues in redux token auth, when i am back to my machine will try to find and link them here

@laurenmacam
Complete script i am using which fixes both https://github.com/kylecorbelli/redux-token-auth/issues/45 and https://github.com/kylecorbelli/redux-token-auth/issues/57 is following:
echo '----------------------'
echo 'Patching redix token auth due to https://github.com/kylecorbelli/redux-token-auth/issues/45 and https://github.com/kylecorbelli/redux-token-auth/issues/57'
echo 'It adds if checks of empty access-token and sets headers for sign-out request'
echo '----------------------'
echo 'UPDATE THIS SCRIPT!!!!! if redux-token-auth is not on version: 0.19.0'
echo '----------------------'

REPLACE="                        if (response.headers['access-token'] && response.headers['access-token'] !== '') auth_1.setAuthHeaders(response.headers);";
ESCAPED_REPLACE=$(printf '%s\n' "$REPLACE" | sed -e 's/[\/&]/\\&/g');
sed -i.buk "165s/.*/$ESCAPED_REPLACE/" node_modules/redux-token-auth/dist/actions.js

REPLACE2='                        if (response.headers["access-token"] && response.headers["access-token"] !== "") auth_1.persistAuthHeadersInLocalStorage(response.headers);';
ESCAPED_REPLACE2=$(printf '%s\n' "$REPLACE2" | sed -e 's/[\/&]/\\&/g');
sed -i.buk "167s/.*/$ESCAPED_REPLACE2/" node_modules/redux-token-auth/dist/actions.js

REPLACE3='                                data: userSignOutCredentials, headers: userSignOutCredentials,';
ESCAPED_REPLACE3=$(printf '%s\n' "$REPLACE3" | sed -e 's/[\/&]/\\&/g');
sed -i.buk "234s/.*/$ESCAPED_REPLACE3/" node_modules/redux-token-auth/dist/actions.js

rm node_modules/redux-token-auth/dist/actions.js.buk

And further instructions to use this patch can be found here.
Hope it helps

Try include this code:
config.middleware.insert_before 0, Rack::Cors do
      allow do
        origins '*'
        resource '*',
          :headers => :any,
          expose: ['access-token', 'expiry', 'token-type', 'uid', 'client'],
          :methods => [:get, :post, :path, :options, :put, :delete]
      end
    end

...on your config/application.rb file. Works fine for me.


Improving a Custom functions debugging documentation regarding sideloading an add-in when using Visual Studio

I am writing in reference to the current documentation regarding Custon functions debugging documentation: https://docs.microsoft.com/th-th/office/dev/add-ins/excel/custom-functions-debugging.
I was trying to use the VS Code debugger for Excel in Chrome Devtools. I know that I have to use sideloading to install an Office Add-in for testing without having to first put it in an add-in catalog, but it's kinda hard to follow. I would greatly appreciate if you guys can improve the documentation by adding some screenshots or pictures while running your add-in from VS Code as well as starting the VS Code debugger so we, developers, can follow through.
Thank you in advance.

@keyur32 okay transferred. @topkoong thanks for this suggestion!

Just to follow up on this image request, it has been added to the list of items prepared in our image audit and will be going to design soon.

Hi there @topkoong - to follow up on this, wanted to let you know about some new documentation on our add-in debugger for VSC. Let me know if that helps. Thanks!

Hi @topkoong, I am going to close this issue for now, but let me know if you need any other assistance by commenting on this thread and I will reopen. Thank you!


1.8 Performance Boost via Soft Prompting - dataset['train'] - KeyError: "Column train not in the dataset. Current columns in the dataset: ['question', 'answer', 'options', 'meta_info', 'answer_idx', 'metamap_phrases']"

I'm getting
KeyError: "Column train not in the dataset. Current columns in the dataset: ['question', 'answer', 'options', 'meta_info', 'answer_idx', 'metamap_phrases']"

When running 1.8 Performance Boost via Soft Prompting  on colab
def evaluate_model(model, tokenizer, dataset, conversation_history):
    correct = 0
    total = 0

    # Iterate through the dataset
    for example in dataset['train']: # Fixed from get_split to dictionary-style access
        try:
            question = example["question"]
            options = example["options"]
            correct_answer_idx = example["answer_idx"]

            # Combine the question with the options
            input_text = conversation_history + question + " " + " ".join([f"{k}: {v}" for k, v in options.items()]) + 'only respond with a single alphabetical character.'

            # Generate model's answer
            input_ids = tokenizer.encode(input_text, return_tensors="pt").to('cuda')
            output = model.generate(input_ids, num_beams=4)
            generated_text = tokenizer.decode(output[0]).strip()

            # Extract the selected option from the generated text
            predicted_answer_idx = generated_text[0]  # Assuming the generated text starts with the selected option letter

            # Compare with the correct answer
            if correct_answer_idx == predicted_answer_idx:
                correct += 1

            total += 1

        except KeyError as e:
            print("KeyError encountered for example:", example)
            raise e  # To see the full traceback and understand the origin of the error.

    return correct / total

Full message
User:
['question', 'answer', 'options', 'meta_info', 'answer_idx', 'metamap_phrases']
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-28-bb8bf40a3938> in <cell line: 83>()
     81
     82 # Evaluate the model
---> 83 accuracy = evaluate_model(model, tokenizer, dataset, conversation_history)
     84 print(f"Accuracy: {accuracy * 100:.2f}%")

4 frames
/usr/local/lib/python3.10/dist-packages/datasets/formatting/formatting.py in _check_valid_column_key(key, columns)
    518 def _check_valid_column_key(key: str, columns: List[str]) -> None:
    519     if key not in columns:
--> 520         raise KeyError(f"Column {key} not in the dataset. Current columns in the dataset: {columns}")
    521
    522

KeyError: "Column train not in the dataset. Current columns in the dataset: ['question', 'answer', 'options', 'meta_info', 'answer_idx', 'metamap_phrases']"

I encountered the same problem. The solution is:
"for example in dataset['train']"  change to "for example in dataset"
The input dataset is already the train split, no need to split it again.

Same here...also when running 1.8, it will really slow down (especially when running locally on 24GB) without some garbage collection. I may do a pull request w/ periodic GC if I figure out how to do pull requests lol. On my 4090 it ran about 500x before hitting the memory swap wall (which increased the time per iteration by about 9x --.7s to about 6.5s per iteration). With GC run every 100 iterations, it kept it running fast.


Feat(impl)/225 use caching for discovery finder requests

https://github.com/eclipse-tractusx/item-relationship-service/issues/225


Update AWS AMI Base OS to CentOS 7.3.1611

High Level Description

Update the AWS AMI to CentOS 7.3
Ensure we don't blindly update to untested versions

Related Issues

DCOS_OSS-655 Create CentOS 7.3 AMI's and update CFN.

To keep the change small I only updated existing regions with the new AMI image. We need a separate issue to add additional regions including CoreOS images. The AMI has been build for all currently existing regions however and the AMI names can be found in the CHANGELOG.md.

coreos: https://github.com/dcos/dcos/pull/1258

@spahl you want me to integrate those CoreOS AMI changes from #1258 into this PR or will the two merge automatically?
What I meant in my original comment was that we're currently missing the regions
ap-northeast-2
ap-south-1
ca-central-1
eu-west-2
us-east-2

entirely. I was about to add them but didn't know which version of CoreOS we're going to support in 1.9 - which AMIs to use.

Oh I see. Yeah we need to add all the new regions at the same time.

coreos v1235.9.0

@mesosphere-mergebot bump-ee

@BenWhitehead please review. @lloesche is there anything else you are currently working on related to this?

@lingmann this and #1279 are somewhat related insofar as once they both land I'll create new AMIs that have CentOS 7.3 and Docker 1.13.1 in them.

closing in favour of #1305


[otbn/util] Add control-flow data structure for OTBN

This adds a data structure to determine and represent the control flow of an OTBN subroutine or program (as long as the control flow can be determined statically). This will be useful for future static checks.
Basic usage:
>>> from shared.decode import decode_elf
>>> from shared.control_flow import subroutine_control_graph
>>> program = decode_elf('/home/jadep/opentitan/build-bin/sw/otbn/p256.elf')
>>> graph = subroutine_control_graph(program, "mod_mul_256x256")
>>> print(graph.pretty(program)) # prints the graph

I think I've addressed the comments now.

Hi @jadephilipoom and thanks for addressing the (many) nitty comments. I think there are a couple that are still open. The GitHub UI isn't massively helpful and hides them above but these are the ones that I think are still worth thinking about:

Do-nothing constructor: https://github.com/lowRISC/opentitan/pull/9628#discussion_r767201080

Oops, I should have checked more carefully! Anyway, after another pass I believe all those are now taken care of.


APT whitelist request for catch in trusty

catch (C++ Automated Test Cases in Headers) is already whitelisted for precise (see #1862) but not for trusty yet.
Ubuntu package: https://packages.ubuntu.com/trusty/catch

See 5761eccc.


Model completion

This PR adds basic shell completion for models in the show and copy subcommand, where the command expects exactly one model name as a positional CLI parameter. This also bumps the cobra version used to v1.1.1 from v1.0.0 to support dynamic zsh completion
Usage
The shell completion is the vanilla completion script generated  by spf13/cobra.
ddbt completion --help has more instructions, for zsh (adjust to your zsh configuration when appropriate):
# If shell completion is not already enabled in your environment you will need
# to enable it.  You can execute the following once:
% echo "autoload -U compinit; compinit" >> ~/.zshrc

# This puts the generated script in stdout as _ddbt file in your $fpath
% ddbt completion zsh > "${fpath[1]}/_ddbt"

Example
The auto completion shows you the model name as well as  the path to the source SQL file.
% ddbt show my_example[tab][tab]
my_example            -- models/example/subdirectory/my_example.sql
my_example_in_parent  -- models/example/my_example_in_parent.sql

Future improvements

Fuzzy match (but could be confusing)
The run command's -m flag supports more than just model name (modelf filters, e.g. tags:..., or +model_name) which is out of scope for now but can be added in the future.

@nickng Do you want to maybe update the Readme file to include the instructions for adding autocomplete to your shell?


Test Adapter: parametrized tests are discovered/logged to data collector as 1 test (no information about specific parameters)

Description
Hi,
MsTest tests may be parametrizable, for example a method with DataTestMethod and DataRow attributes. For example:
        [DataTestMethod]
        [DataRow("baz", false)]
        [DataRow("foo", true)]
        public void TestMethod(string name, bool expectedResult)

Current behavior
For such test, MsTest Test Adapter:

during test discovery, only 1 VSTest TestCase is discovered (which represents whole TestMethod)
during test execution, the method is executed for data row, but VSTest's DataCollectors (both In-Proc and out of process) receive only 1 TestCaseStart/TestCaseStop event (for TestMethod)

Desired behavior
Would it be possible to have per data row discovery/logging resolution? That is, ideally:

discovery would discover 2 test cases: TestMethod("baz", false) and TestMethod("foo", true)
DataCollector would receive TestCaseStart/TestCaseStop for both above test cases

In fact, the 2nd point is more important for me - I would like to change environment and monitor each execution of TestMethod (for each data row separately).
If it is not possible, could you please share the reason?
Thanks
Environment
mstest.testadapter.1.2.0
microsoft.testplatform.15.6.0-preview-20171211-02

@pkruk2 Having separate tests for each datarow is not in plan for the near future. Would it be possible to check the parameter value in your test code (or) does this need to be done outside the test code ?

@cltshivash It must be outside of the test code.
In case I need to add this myself to the test adapter, do you have any suggestions? Ideally it'd be accepted upstream.
I understand it'd also change VS behavior, because currently when you discover/run such parametrized test, VS shows 1 test in Test Explorer, and all data rows results are visible in test details section.

Tagging @pvlakshm , @cltshivash to see if and how can we bring this in?

@pkruk2 this is by design and it is a non-goal to have discovery by data row.
But your ask for DataCollectors to be aware of iterations is a valid ask and can be solved (Given the constraint of not discovering each data row as a separate test method) is for us to add new events for test iteration start and test iteration end for data collectors to hook in to. But this will require a breaking change in the test Platform object model.
A simple solution is for us to have custom events in the Test Platform for datacollectors. Anyone who wants to send custom events from their adapters (in our case MsTestv2) can use this Extensible List of events to register and listen to custom events like test iteration start and test iteration end. But this won't be a simple thing to implement.

Closing this as duplicate. Having seperate test method for each data row will fix this As mentioned in #1 of this issue : https://github.com/Microsoft/testfx/issues/464


Feature Request: #[context] attribute for functions

I really love this crate. The Context trait's error messages are very nice looking.
In fact, I love it so much, I want every single error produced by my binary to be in that style! But to do that, this is how my code has to look:
let s = String::new();
let mut f = std::fs:::File::open("foo.cfg").context("Reading configuration")?;
f.read_to_string(&mut s).context("Reading configuration")?;
let cfg: ProgramConfig = toml::from_str(&s).context("Reading configuration")?;
// ...

Every single time I do a question mark, everywhere in my code, I need to remember to type .context(), and what string I picked for that region.
On even the 1,000 line project I'm working on right now, that's a lot of contexts! And I forget, I'm back to the "unhelpful" error message style -- on an error I won't actually hit until much later, according to Murphy's Law. I'd much rather be able to define a context scope that applies to all errors within that scope.
While I looked into an anyhow::context! macro, I found it to be too ugly. Since most context changes are at function boundaries, I would thus propose this new attribute:
#[anyhow::context("Reading configuration")]
pub(crate) fn read_config_file(path: &Path) -> anyhow::Result<ProgramConfig> {
    /* code goes here, and every single Error will be annotated with that context  */
}

If this would be acceptable, I would happily implement it myself.

Reading my example, I suppose one might ask, "why not just call the function and then put a .context() on the result before it is re-thrown?"
Because if the function is called in 4 different places (like read_config_file will be, across different command-line utilities within the same package), then that still means I have to put a context on it four times.
Even more importantly (and more difficult for me), I have to make sure the string is the same across all those different locations. After all, if I see two slightly different messages, I'll go looking for two different pieces of code, and the end user (who will also see them) think something different was going on.
This attribute anchors the context to the callee, rather than the caller. That is what I really want to achieve.

Reading my example, I suppose one might ask, "why not just call the function and then put a .context() on the result before it is re-thrown?"
Because if the function is called in 4 different places (like read_config_file will be, across different command-line utilities within the same package), then that still means I have to put a context on it four times.
Even more importantly (and more difficult for me), I have to make sure the string is the same across all those different locations. After all, if I see two slightly different messages, I'll go looking for two different pieces of code, and the end user (who will also see them) think something different was going on.
This attribute anchors the context to the callee, rather than the caller. That is what I really want to achieve.

I don't want this in this library, but https://github.com/yoshuawuyts/context-attribute does something similar.

I don't want this in this library, but https://github.com/yoshuawuyts/context-attribute does something similar.

Thanks for the pointer, @dtolnay. I'll look into it.

Thanks for the pointer, @dtolnay. I'll look into it.


Doesn't work.

Using --path doesn't return any results, but if I use --dump-all-handles, I can find handles for the path I previously specified

Hello @cow1337killer3,
Thank you for submitting the issue.
Sorry for the bug. I will look into it.
Do you have any particular details? Maybe a way how to reproduce it?
In the meantime I will try it on my machine on some generic use cases.

Tried it on my machine. It works:
C:\Users\username\Downloads>Handle2.exe --path "C:\Users\username\Downloads"
C:\Program Files\Adobe\Acrobat DC\Acrobat\Acrobat.exe pid: 21376 DLAPTOP/username
  C:\Users\username\Downloads\DOC-1.pdf
------------------------------------------------------------------------------

Could you please provide more details?


Many new features implemented

Hello!
I have added some new features:

admin tab now working. Shows actual snapshot, HD snapshot and livestream

if path is empty (default path is used), available files can be selected by date
tested with ios and android mobile phones, chrome browser and edge browser

support for overlay text

bottom left: day and date, localized
top right name of camera

support for automatic save pictures and/or livestream every x minutes (helpful, if no subscription)
HD Snapshot to capture actual picture with higher resolution (HD)

tested with ring intercom. Get actual picture after ring the doorbell in front of my door (snapshot always too late)
Filter for sharpness and contrast, selectable for night only  (depends on camera?)
Night is calculated automatically via admin config location and suncalc

Ring Adapter Client changed to actual ffmpeg-static usage

filters can be used directly for livestream and HD snapshot with Ring API (w/o copy again files and buffers)

Ring Adapter Client snapshot function is used one level before to take more actual snapshots
some code clean-up and minor corrections

Have fun with testing ;-)

So many features. Thank you!


Error on Bitrise integration

I'm following this guide here to integrate Oversecured to our Bitrise CI but keep getting this error:
oversecured: Step 'Signed URL' failed with code 422, server message: Validation Failed
Any place I can get more information about it?

Hi @DavisJP,
Thanks for reporting the issue! We're looking at it

@DavisJP,
Can you make sure that APK was already generated before running Oversecured step? E.g. you need to place Gradle Runner and Deploy to Bitrise.io steps higher than Oversecured. This error happens when the APK file is missing on the defined path.
We will add more helpful error messages for such cases.

@bagipro Thanks for checking so quickly but the step was after the deploy step. I will check again later the path but adding more error messages would surely be helpful.
Thanks.

Closing the issue as not using the integration anymore.


Monday - the first day of the week [ISO 8601]

Please consider creating a template for displaying the week in accordance with the ISO 8601 international format:

...
2.2.8
Сalendar week: time interval of seven calendar days starting with a Monday
...

It would be very convenient if the format of the week can be switched using the parameter.
For example:
<Datepicker
    week-format= "ISO"
/>

monday-first parameter.
Sorry, didn't see it right away! :)


Options zoomWindowOffetx??

For some reason, the documentation (in both the examples and API) specifies using the property "zoomWindowOffetx" for offsets on the x-axis, this property doesn't actually exist and instead you need to use "zoomWindowOffsetX", might be worth updating the documentation?

yeah your are right. Originally it actually was zoomWindowOffetx
I decided in the code to use the better naming, but the latest demo had the old stuff still.
Its now fixed with the latest commit. Thanks.


feat: introduce macos support

sister PR: https://github.com/nix-rust/nix/pull/2347

let's waiting for https://github.com/nix-rust/nix/pull/2347 released!

let's wait for nix-rust/nix#2347 released!

New libc has been released: https://github.com/nix-rust/nix/pull/2398

when is the plan for this to be completed? I'm eagerly waiting for it to use it in my encrypted filesystem app

when is the plan for this to be completed? I'm eagerly waiting for it to use it in my encrypted filesystem app

I will push forward in these days, thank you for you to pay attention to it.

Nix 0.29.0 has just been released, sorry for letting you guys wait for such a long time.

Hi, how's it going with this? Would very much appreciate this being merged. I started developing GUI in Kotlin and starting with macos. So +1 for this :)

@oowl sorry to keep pushing on this, but any news on when it will be merged? I'm eagerly waiting for this to integrate it in my app as I'm very close to a stable release and would be great to include this also

@oowl any updates on this? I'm eagerly waiting to integrate it in my app :) Is there something I could help with?

Sorry for my lateness. It will finish in these days.

no worries, great to hear that, thank you very much
On Sat, Sep 7, 2024, 08:21 Jun Ouyang @.***> wrote:

Sorry for my lateness. It will finish in these days.
—
Reply to this email directly, view it on GitHub
https://github.com/Sherlock-Holo/fuse3/pull/90#issuecomment-2335048751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5TC4EFF4TSI7T7NFOYSWLZVKEPBAVCNFSM6AAAAABFQG342GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVGA2DQNZVGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@oowl sorry to bother you again, any chance to get this in soon?

Recreate it as a new PR due to rebase hell.


Add k6 test to cronjob

Describe your changes
Try to add the test to overnight workflow controlled by cronjob
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review
[x] I do not need any deviation from our PR guidelines

Closing this because all the work is now in #5573


[Schema] update protobuf schema to support Network Configuration Manager

This change enabled the new Network Configuration Manager, it includes:

introduce GoalStateV2, so that doesn't break existing GoalState(V1) implementation
updated: rpc PushNetworkResourceStatesStream (stream GoalStateV2) returns (stream GoalStateOperationReply)
new: rpc RequestNetworkConfigurations (NetworkConfigurationsRequest) returns (NCMReply)
deleted: rpc RetrieveNetworkResourceStates (GoalStateRequest) returns (stream GoalState)

Codecov Report

Merging #551 (1a334a7) into master (e26b494) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #551      +/-   ##
============================================
+ Coverage     34.34%   34.38%   +0.03%
- Complexity     1229     1236       +7
============================================
  Files           501      501
  Lines         12365    12398      +33
  Branches       1558     1567       +9
============================================
+ Hits           4247     4263      +16
- Misses         7541     7557      +16
- Partials        577      578       +1

Impacted Files
Coverage Δ
Complexity Δ

...wei/alcor/portmanager/service/PortServiceImpl.java
63.25% <0.00%> (-3.89%)
22.00% <0.00%> (+3.00%)
:arrow_down:

...alcor/elasticipmanager/dao/ElasticIpAllocator.java
63.53% <0.00%> (-0.28%)
48.00% <0.00%> (ø%)

...portmanager/service/implement/PortServiceImpl.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...lcor/portmanager/processor/DataPlaneProcessor.java
68.29% <0.00%> (+0.79%)
34.00% <0.00%> (+2.00%)

...ortmanager/request/UpdateNetworkConfigRequest.java
80.00% <0.00%> (+2.22%)
4.00% <0.00%> (+1.00%)

...ortmanager/request/CreateNetworkConfigRequest.java
72.72% <0.00%> (+2.72%)
4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26b494...1a334a7. Read the comment docs.


Clarify deprecation message for FileTrees as outputs

The userguide does not say what a directory tree is.

@pledbrook I adjusted the deprecation warning, please take another look.


Add "Mutual-TLS"/"Client-Cert"-Authentication example to wildfly-camel-examples

Hello James,
follow up to Pull Request 47, I added an example that does mutual-TLS / Client-Cert Authentication.
Possible I should change the name to meet the use-case better, but I fist wanted you to reviwe it, before I put more work into it.
Best regards,
Jochen

Hi,
I just added #72 as reference for this request.

hopefully I implemented all your improvement requests. anything else I can do?
thanks,
Jochen

Thanks. I'm pretty busy with other things at the moment, but I'll try to do a final review by the end of the week or early next week.

thank you very much, but there's no need to hurry.
I wanted to do this in August/September and had to time until now.....

One final request, please can we extract the CLI commands from steps 3, 4 & 5 in the README to a CLI script. It'll make things simpler for folks who aren't familiar with the WildFly CLI. We'll also need a script to undo the changes.

I just added the CLI commands and added them to the POM. I tried to follow what's done in the jms example, but did two things diifferently:
1.) The "beforeDeployment" and "afterDeployment" of the deploy goal are deprcated, so I used the execute-commands goal as described in the plugin documentation
2.) I did something very ugly, since my script needs a ":reload" before the deployment: I added a sleep of 3 seconds, using the antrun-plugin.
Sorry for that, but di you have any other idea?
I found, this JIRA:
https://issues.jboss.org/browse/WFLY-208
so other people also found that ":reload(blocking=true)" is missing....

ok to test

Merged (with some small tweaks) - thanks for contributing :+1:


[JS] Media element support

This PR implements https://github.com/Microsoft/AdaptiveCards/issues/196 and https://github.com/Microsoft/AdaptiveCards/issues/1361
Notes:

HostConfig.playButton isn't supported: a better experience is achieved with native styling via CSS
HostConfig.maxMediaSize isn't supported: as far as I can tell, there is no way to retrieve the size of the actual stream for several reasons:

I can't know which stream from the sources will be picked by the Media control (since it depends on the codecs installed on the machine)
Determining the size of the stream would require making a HEAD request on the stream's URL which would generate a cross-domain error anyway

Here is what things look like in Chrome (note that all browsers have their own UI for controls).

Notes:

The default Play button is somewhat customizable in CSS and is designed to mimic Chrome's media player button, which provides for a smooth transition between the poster and the actual player.
When the is no poster, the background is also customizable in CSS.

Once video is playing (controls disappear once mouse is idle or moves out of the player's box):

Audio player works just the same. Here is what it looks like while playing in Chrome:

When inline playback isn't allowed, the host application can handle the static Media.onPlay event.

Great screenshots, thanks David!
@matthidinger I kinda agree that it's okay the HostConfig playButton isn't supported... if hosts are customizing, they probably would want to use CSS rather than an image which doesn't scale well.
@RebeccaAnne on UWP were you able to implement the HostConfig maxMediaSize? I'm curious if anyone was able to implement that. If not, it should just be removed.

Looks good, thanks David!

I think for an audio with poster, it should display the static poster image while the audio is playing.

If that's what we want then I'd say that playback controls should always appear below the poster for Audio, with no default play button overlay. The <audio> tag can be made to only load metadata or no data at all until the play button is pressed.


GEODE-2967: ResultCollection instead of StructCollection

* If we have one runtime iterator which is in case of self joins, ResultSet or ResultBags are created
* Otherwise StructBag or StructSets are used

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Potential reviewers
@jhuynh1 @ladyVader @boglesby @gesterzhou @upthewaterspout

@DivineEnder


Fix various typos

Found via codespell -q 3 -S "./docs/ChangeLog.*" -L aswell,ba,gord,ifset,iif,inout,invokation,lod,msdos,pard,reenable,ro,siz,tesselator

Thanks for fixing the typos and providing the PR. Please, see attached comments to files.

3 more typos found, please review 680d8f5


Investigate compliance with "ISO house style"

As title.
https://www.iso.org/ISO-house-style.html
Perhaps we need some pointers from Metanorma documentation to the "ISO house style"
cc: @metanorma/editors for thoughts too.

There are a few additional warnings we could issue on content, e.g. the positioning of "e.g." (Use “e.g.” when giving an example in brackets or at the end of a sentence), but (a) the ISO/IEC DIR 2 complaints on content are noisy enough already, and I don't have much evidence they are being found useful; (b) the style guide ITSELF does not observe those rules, and (c) I've seen little evidence of compliance in past ISO documents. I don't think even more content warnings is a useful thing for us to be doing.

I have also received new information with the ISO House Style from ISO/CS:

The preferred structure of a vocabulary document is to have a parent clause which heading is “Terms and definitions” with subclauses.
3             Terms and definitions
               3.1         General
               3.2         Refinery products

It is also possible to have separate/distinct clauses provided that the heading starts with “Terms …” with subclauses.
3             Terms related to raw pigments
               3.1         Organic pigments
               3.2         Mineral pigments
4             Terms related to coated pigments
…

Use “one billion” for “1 000 million”.

Style guide contradicts ISO/IEC DIR 2:

Ambiguous terms such as “billion” shall not be used.

“…in accordance with IETF RFC 2046.”

@ronaldtse You might want to advise IETF that their rejection of the prefix is news to them.

List casing check: an all caps acronym (like ISO) is ambiguous as to whether it is lowercase or uppercase.


Keystrokes get dropped in Spectrum editor window

If you use Listener in Spectrum's editor window, only some of the keystrokes generated by the NDA seem to reach the application.  For example, if the app hears:
This is a test of listener
Then, you might see this inserted into the Spectrum editor.
Thss aet fltner
I have already added code to try to pace the rate at which the NDA inserts keystrokes.  The NDA now will only insert a keystroke event if there are no other keystroke events on the queue.  But even with that, keystrokes are getting lost.

In further testing, it appears as though you can reproduce dropped characters in the Spectrum editor by just typing on the keyboard.  The pacing code in the NDA does seem to be working based on testing in AppleWorks GS and Medley which are both very slow but do accept all text from the NDA without losing characters.  I no longer think this is an issue in Listener itself.


Add personal website to index.html.

@neauoire please review the file and if everything is ok with index.html as well as wit my site, add me to this list of magical web creations.
Thanks a lot, Jo<3

Oh i forgot! The webring icon is on the bottom left of the homepage.

Hi :) Thank you for applying to the webring. The website is a bit bare right now, I can only find 2 or 3 pages is there a way to go deeper into the site that I'm not seeing?
Side note: Your images are pretty heavy, even tho they display quite small, they are not optimized for web and some are pretty big. I'd recommend making those smaller for bandwidth challenged people like me ^^.

Thanks for the feedback<3
I'll use responsive images to help out with lower bandwidth. And make it responsive for mobile devices.
As for the content, you probably didn't miss anything. At the moment these are all the pages. I am slowly adding content, whenever I have something new. I hope this is enough to be included in the ring. If not, please give me some advice and i'll create a new pull request later.
Happy new week.

Feel free to open a new PR later, I'll close this one because it will probably create a conflict when if I accept another in the meantime. Good luck with your website, lemme know if you ever want to bounce some ideas :)


Add DURI-compatible security scheme

With the relatively recent approval of AAI and Passport specs, we should extend #29 with the corresponding security scheme compatible with DURI based on their advice.

Let's revive this and also clearly demonstrate auth(z) via Passports/AAI.
More info: https://docs.google.com/document/d/1xIHFWRisQJ27f5Cc4l0djEDx87-f-Oid3356AP74-0k/edit?ts=606dc807#

Let's wait for the resolution of Passport/DRS integration as a starting point.


Include insert size standard deviation along with mean insert size as tuple in to the final metrics json output?

https://github.com/c-BIG/NPM-sample-qc/blob/1ea47eb7d9df3b6363c67cc9fa008e7c7a99e0de/bin/metrics/metrics.py#L124

As defined in the GHIF WGS QC doc Include insert size standard deviation along with mena insert size as tuple in to the final metrics json output?

https://github.com/c-BIG/NPM-sample-qc/issues/72

Closing this (redundant See #72 ) issue


Added Instagram portfolio theme

and .gitignore to avoid tracking Webstorm, PHPStorm project files.

@ssokurenko  Great theme. Thanks for adding Instagram portfolio. Keep it up. Cheers.

I like your approach @geraldb ! Very proactive!
Cheers


Revert "Let the connectivity test use local subchannel pool to create multipl…"

Reverts grpc/grpc#22922
The PR highly increases flakiness of sequential_connectivity_test on mac.
See internal bug: b/156552866

Test is still failing and bisect is pretty clear about this being the rootcause.


[bug] Hide No Matches Found when a query doesn't have auto-suggestion

Could not reproduce this issue.


Option to trim translations

It would be nice to have an option to trim all spaces and newlines at the beginning and end of the translation.

added


Update nix channel for python; use stock pip; monkeypatch pip to chan…

…ge shebang line
Why

We want to upgrade Python to nixpkgs-unstable
due to an update in nixpkgs, we had to change how we package pip, we chose to:
a. use the stock pip instead of our custom one
b. add back a customization for the shebang line via monkeypatching, via python site customization, which has the advantage of working for a pip that's been installed in .pythonlibs. Thanks @blast-hardcheese for this!

What changed

Use unstable channel for Python 3.10 and 3.11, but not 3.8.
Updated pip to use stock pip, plus site customization

Test plan

create a Python Repl
pip install gunicorn
cat .pythonlibs/bin/gunicorn see that the shebang line starts with #!/usr/bin/env python3
make sure template tests (in particular pip and poetry tests) pass

@blast-hardcheese I think we should expose PIP_CONFIG_FILE var to the repl so that an upgraded pip will have break-system-packages = yes set as well.

@blast-hardcheese I think we want to make the script not break if for some reason pip was not available on PYTHONPATH.

I can't find a way to break it by setting the PYTHONPATH though, so it ok.

I'm concerned about the test plan here, because it already does what the test plan says without this change.

@ryantm That won't be true in the upgraded nixmodules -- that is the case today, and our goal is to effectively have a noop through this upgrade


Add experimental flag to enabling tasks property

This resolves #156

I realize I'm late, but wouldn't a property such as spring.cloud.dataflow.features.experimental.tasksEnabled be better? Also, I'm not sure this is as strongly encapsulated as @markpollack was originally requesting. Would it be better to have a lower-level mechanism (EnvironmentPostProcessor perhaps) that does not allow the simple tasksEnabled property to be overridden directly BUT does set that underlying property itself if and only if the more explicit "experimental" key is provided (with a value of true)?

@markfisher That's what I had in mind too at first, but then discussed with Ilaya, and realized that property is in dataflow core. So would have to be renamed for all implementations, even the ones that don't consider tasks as experimental :(

could spring-cloud-dataflow-server-cloudfoundry contribute an EnvironmentPostProcessor as part of it's autoconfiguration? (at least temporarily while we have "experimental" features to manage)

You mean an EnvironmentPostProcessor  that exposes the value of spring.cloud.dataflow.features.experimental.tasksEnabled as spring.cloud.dataflow.features.tasksEnabled ? Technically possible but wouldn't prevent someone from messing with the latter directly.
More in line with what I had in mind at first though.

wouldn't prevent someone from messing with the latter directly

can we check if it's true and fail if so (but also set it to true ourselves only if the other key we expose is mapped to a value of true)?

This seems convoluted.
I like it. Challenge accepted...

I can't look through the PR, but I was thinking to have something (property/env var) where the user has to type 'experimental' so they know why they are getting into.


new nepal topojson

https://www.npmjs.com/package/new-nepal-topojson
might be useful for you

Thanks for the link. I'll contact the author for permission.

Will be closed after @arkoblog opens  a PR.


Update listbox list action

Add an action to update items in the store
Add items in the store for the listBox

Codecov Report

Merging #838 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
+ Coverage   99.75%   99.75%   +<.01%
==========================================
  Files         276      276
  Lines        7012     7020       +8
  Branches     1719     1724       +5
==========================================
+ Hits         6995     7003       +8
  Misses         17       17

Impacted Files
Coverage Δ

src/components/listBox/ListBox.tsx
100% <100%> (ø)
:arrow_up:

src/components/listBox/ListBoxConnected.tsx
100% <100%> (ø)
:arrow_up:

src/components/listBox/ListBoxReducers.ts
100% <100%> (ø)
:arrow_up:

src/components/listBox/ListBoxActions.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9718f80...dfe36da. Read the comment docs.


Use data transformer in expect_events

Blocked by https://github.com/software-mansion/protostar/issues/394


Features for disabling.

I don't mind adding these in a PR myself if you're ok with them, but I have a few suggestions.

[ ] Allow temporarily disable for the next item added on the Pasteboard (regardless of source) make sure menubar icon indicates this.
[ ] Allow toggling disabled state by cmd click on the menu bar icon and make sure menubar icon indicates this.

I could go either way with key-binds, however disabling for the the next item in the pasteboard, can't be a special "copy" key-bind, you might need this for things that come externally, like say Screenshot to pasteboard or stuff copied from iOS via handover.
I noticed there is a PR here and you got option+rightclick for disabling.
There are a few issues.

Time based stuff rarely works out, and people keep toggling to give themselves more time.
option+rightclick is the wrong method for disabling, as it should be used to show additional information, maybe change to cmd+click shift+click - Related

I can fix these as well.
Edit: If it makes any difference I am not using a mouse, but the touch pad. And for me, it's not option+click but option+rightclick or technically, two finger press.

Allow toggling disabled state by cmd click on the menu bar icon and make sure menubar icon indicates this.

Nothing to be done here per discussion in #355.

Allow temporarily disable for the next item added on the Pasteboard (regardless of source) make sure menubar icon indicates this.

Can you elaborate more on the use-cases for such a feature?

Allow toggling disabled state by cmd click on the menu bar icon and make sure menubar icon indicates this.

Nothing to be done here per discussion in #355.

My suggestion is to use shift+click for this instead of option+rightclick. As option is usually to show more context in the menu.
You can try it yourself on the Wifi or Bluetooth menu.
This is a perfect opportunity to show the settings and quit items even if they are disabled by the user. This is merely a UX improvement, and not really a big deal.

Allow temporarily disable for the next item added on the Pasteboard (regardless of source) make sure menubar icon indicates this.

Can you elaborate more on the use-cases for such a feature?

I am about to take a screenshot that's copied to the clipboard.
I use shift+cmd+4 (not default) for this.
But before doing that, I do the "disable next item" shortcut, either via UI or keybind - open for suggestions on which to use.
Once the copy has been done, Maccy ignores it (doesn't store it) and re-enables itself.
This helps for one-off copies that should not be stored, as opposed to a full disable.

My suggestion is to use shift+click for this instead of option+rightclick. As option is usually to show more context in the menu.

Option+click is used to do an alternate function in the menu bar. For icons that have hidden information, like bluetooth or wifi, then it makes sense to display additional info. For items that can be disabled, like Maccy, or the Notification Center, I  would say option+click is the expected modifier.

I'm a little confused. I'm just starting to play with Maccy for the first time. From the above and #355 it sounds like I should be able to Option-Click, or maybe Option-Right-Click, on the menu bar icon to toggle Maccy being enabled or disabled. But I can't get any keystroke-click combination to do so. Am I supposed to be able to Option-(Right)Click to enable/disable?
I do see the Advanced > Turn off option in the Preferences. I'd like to do exactly what it does without having to dig into the Preferences or go to the command line.
Maccy 0.22.0,9 installed via brew, macOS Monterey 12.1 (21C52).
If I'm misunderstanding what Option-(Right)Click is supposed to do, please let me know. In that case I'll likely open an enhancement request for a quick toggle feature. Thanks!

I think there may be a bug in the latest version. I’m running three
versions behind (0.20.1) and option+click works perfectly.
I plan to update to the next version though once it comes out.
On Fri, Feb 4, 2022 at 5:35 PM Mac Hale @.***> wrote:

I'm a little confused. I'm just starting to play with Maccy for the first
time. From the above and #355 https://github.com/p0deje/Maccy/issues/355
it sounds like I should be able to Option-Click, or maybe
Option-Right-Click, on the menu bar icon to toggle Maccy being enabled or
disabled. But I can't get any keystroke-click combination to do so. Am I
supposed to be able to Option-(Right)Click to enable/disable?
I do see the Advanced > Turn off option in the Preferences. I'd like to
do exactly what it does without having to dig into the Preferences or go to
the command line.
Maccy 0.22.0,9 installed via brew, macOS Monterey 12.1 (21C52).
If I'm misunderstanding what Option-(Right)Click is supposed to do, please
let me know. In that case I'll likely open an enhancement request for a
quick toggle feature. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/p0deje/Maccy/issues/354#issuecomment-1030432726, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQYZ2EKIMZ2PDPHRMA432NDUZRPFDANCNFSM5LYVDKUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

You are right, I totally forgot that there was a flaky bug when Option+Click stops working and I fixed it 7cf2933304d7871f4b9e51f2f704575d25f1a5dc. I couldn't reproduce it because I was running the master HEAD version locally.
I'll prepare a new release soon.

I am about to take a screenshot that's copied to the clipboard.
I use shift+cmd+4 (not default) for this.
But before doing that, I do the "disable next item" shortcut, either via UI or keybind - open for suggestions on which to use.
Once the copy has been done, Maccy ignores it (doesn't store it) and re-enables itself.
This helps for one-off copies that should not be stored, as opposed to a full disable.

@seivan Ok, I see your use case. However, I still don't know how to make a nice UX for this feature. Would clicking on the menu icon with both Shift+Option pressed be enough?
The logic here is:

Option+click toggles Maccy forever
Option+Shifht+click toggles Maccy for the next copy only

The bug with option+click should be fixed in 0.22.1

Hello,
I have upgraded to the latest version. However, I'm having the same problem I had the last time I tried to update. All my pins have gone invisible. I am able to run the terminal command described here:
https://gist.github.com/p0deje/72cc0b408f5d7b47f59ee82772499711
Unfortunately, that only seems to last until my next reboot and then they are all invisible again.
Perhaps I will just paste all of my pins into a word document, and delete everything and start fresh. Just wondering if you had any advice for something else to try before I do that?  Thanks!

Confirmed Option-Click now works fine in 0.22.1 on macOS Monterey 12.1 (21C52).
Thanks for the super-quick update!
Minor issue, but I thought you should know: If you have Preferences > Advanced open and Option-Click on the menu bar icon, the enable/disable works but the Turn off checkbox in the Preferences pane does not immediately update. If you move to a different Preferences pane and then back to Advanced, the update shows just fine.

@Stickyhavr

Only pins? What about unpinned? It might be a different bug if it only affects pins. Can you also try looking at the "Pins" tab in preferences and check if titles are shown there? You can also try to edit any title there and then restart app to check that it persists.
Does it only happen after reboot? What about quitting and restarting Maccy.app?
I mentioned this before, but this bug could happen if some older version of Maccy starts at login. Please try running find . -name "Maccy*" in Terminal.app - maybe you see some lingering version that somehow starts at login and messes up the database.

You are correct on 1 and 2. I hadn’t noticed because I did a clear right
before I updated, so I didn’t have any other copies to lose.
And yes it was happening after closing and re-opening Maccy. I never close
Maccy, so I was associating that with a reboot but it was true any time the
app closed.
I used App Cleaner to get rid of all traces of Maccy, then installed the
latest version fresh. I’ll redo my pins manually.  I imagine I will be all
set now but I’ll let you know if I have any issues. Thanks!

@seivan Could you please take a look at https://github.com/p0deje/Maccy/issues/354#issuecomment-1030533095

So, folks, do we still need to do anything here? If there is still a need to have Maccy ignore the next copy, would Option+Shift+click work?

Option + Click has been working fine for me.
Option + Shift + Click seems like a good choice to me for ignore next
copy.  Thanks for all that you do!


how to remove the line dash around the Edge arrow?

g6 version :     "@antv/g6": "^4.3.7",

how to remove the line dash around the arrow?
I can do it by adding lineDash:[0,0]
endArrow: {
path: arrowPath,
d,
fill: '#acaeaf',
lineDash: [0, 0],
},
however ts reports error:
'lineDash' does not exist in type 'ArrowConfig',
is there any more cleaner solution?
many thanks!

try strokeOpacity: 0 for endArrow, and I will add lineDash to ArrowConfig in next small version

It seems that strokeOpacity is also not in ArrowConfig. Anyway, thanks a lot for the fix.

yes, also fixed by v4.3.11


Maintain correct cursor size on displays with scale factors

When using a scale factor on a display, the cursor size was incorrectly handled. With multiple displays and differing scale factors on each display, this caused the cursor size to differ visibly between displays.
For example, I have two 27" monitors side by side. Monitor 1 runs at 2560×1440 with scale 1 and monitor 2 runs at 3840×2160 with scale 1.5. Everything should have the same apparent size on this setup. On monitor 1, everything looks good. On monitor 2:

in any UI rendered by sway, the cursor appears to be half size.
in native wayland applications, the cursor appears to be be quarter size.
on xwayland applications, the cursor appears to be the correct size.

It appears that cursor->output->impl->set_cursor considers the output scale but also divides the dimensions of the cursor by scale. Indeed, everywhere else this function is called in types/wlr_output.c, 1 is always passed as scale.
Passing 1 in output_cursor_attempt_hardware causes the cursor size to be correct in all cases.

Turns out software cursors were also broken, but in a different way. There are two cases to consider:

In wlr_output_cursor_set_image, which appears to be used for cursors rendered by sway's own UI. Multiplying the logical cursor size by the output scale factor fixes the software cursor size issues on sway's UI.
In output_cursor_commit, which appears to be used for cursors submitted by wayland clients. GTK, for example, divides the cursor size by the current scale, then keeps track of the scale. This information was tracked in wlr_surface_state::scale, but was not used. Multiplying by wlr_surface_state::scale fixes the software cursor size issues in these wayland clients.

I have been running this locally for a while now and it seems to work perfectly. This should be ready for review.

Hi, I only have one display and scaled with 1.12. I tested your branch and my cursor on gtk apps goes big :)

@mozartilize I believe sway controls the titles and background, while wayland clients like gtk apps set their own cursors.
The problem is that on the current master, the cursors over gtk apps are a factor of two smaller than they are supposed to be when using a scale factor > 1 (due to the missing multiply by cursor surface scale factor).
If this is the case, then changing the scale factor to 1 while on wlroots master should also result in cursors appearing too large over gtk applications.

It appears that this patch only works in cases where the minimum cursor size in the active cursor theme is larger than the cursor size setting. In all other cases it would create cause the cursor to appear overly large Instead, increasing the cursor setting to the minimum cursor size in the active cursor theme would fix the sizing issues.


Add support for GitHub Enterprise

Hi,
Thanky you for your tool, very helpful.
It would be great for this action to have baseUrl input for using in different environment other than "https://api.github.com".
Right now that URL is the default baseUrl of Octokit.

this is for GHES, right? I don't mind adding an option to make that possible. Are you aware of any conventions that other actions use to be compatible with GitHub Enterprise Server?

Thanks Paul.
I'd happily accept a PR that takes GITHUB_API_URL into account

Thank you!
i'll put something together unless @armkillbill beats me to it.

I have created a PR.


Layout on bigger font size

Hi and thanks for your plugin!
The only issue I have so far is that I work on a big screen and my studio system font size is set to 20.
Which I guess leeds to this layout issue :

Me too.


The release artifact contains native changes, which cannot be applied with a patch

Run shorebird patch android
⠋ Fetching apps...
✓ Fetching apps (0.3s)
⠋ Building patch...
✓ Building patch (392.9s)
⠋ Detecting release version...
✓ Detected release version 2.2.0+1 (1.1s)
⠋ Fetching releases...
✓ Fetching releases (0.2s)
⠋ Fetching release artifacts...
✓ Fetching release artifacts (0.2s)
⠋ Fetching aab artifact...
✓ Fetching aab artifact (57ms)
⠋ Downloading release artifacts...
✓ Downloading release artifacts (1.1s)
⠋ Verifying patch can be applied to release...
✓ Verifying patch can be applied to release (1.6s)
[WARN] The release artifact contains native changes, which cannot be applied with a patch.
    Changed files:
        base/dex/classes.dex
Exiting.
Error: Process completed with exit code 70.

I don't have this warning when running the patch from local. What's the issue and how to fix it?

We definitely could have a more informative message there.
classes.dex is the compiled Java/Kotlin code.  So typically that means either your changes include some java/kotlin changes or in some cases it could be you didn't change any java/kotlin but a dependency did (e.g. a flutter plugin) or even less common, sometimes there are gradle dependendencies/gradle plugins which modify the build every time it's made (e.g. to add a timestamp of when the build happened) which can cause this type of change to appear every time.
Depending on which of those cases you think you fall into, it could be safe to continue, it could not be.  Worst case your app will behave differently than you expect after patching, since it would only contain the Dart changes, and none of the Java/Kotlin changes.


RE: Address bar holds the focus when URL entered from address bar.

This is still not fixed in Beaker v1.0.0-prerelease.2
https://github.com/beakerbrowser/beaker/issues/1535

Okay I'm going to reopen that issue since it has more details. Thanks for letting me know.


Housekeeping

Library version changes. Uncontentious ones

When observing a LiveData object from a fragment's onCreateView, | onViewCreated, onActivityCreated, or onViewStateRestored method | getViewLifecycleOwner() should be used as the LifecycleOwner rather than the | Fragment instance. The Fragment lifecycle can result in the Fragment being | active longer than its view. This can lead to unexpected behavior from | LiveData objects being observed longer than the Fragment's view is active.


Update link on README.md

Please update README.md for Seed Starter
You can read a quickstart guide for this sample here.
No link exist. Thanks.

This was fixed, thanks!


Use fallback when replacement symbol unavailable

In some fonts, there's no rendering for the symbols used for &&& and |||. It would be good to detect this case and use either a sensible fallback or just forgo the replacement.

I'm not sure if auto-detection is easy but this should be fixable locally for yourself by running M-x customize-variable RET verus-symbols-alist RET which will open up a nice interface where you can edit the symbols used for prettification (in particular, you'll be able to remove any prettifications that you do not like by hitting enter on the relevant [DEL] or edit it to something your fonts supports---the numbers there correspond to the unicode code point for the prettified character). You can hit [Apply] for it to be temporary, or [Apply and Save], to make your changes permanent for your machine.

This worked, thanks! It would probably be useful to put this in the instructions.


Unable to detect Sonos One devices from local network.

I wanted to mention I love this project and am really excited to start contributing to it. I've recently downloaded and installed Budgie on Windows 10 and after permitting it access through my local network, when you run the application and click "Select devices" button, the dialog pops up and it just keeps searching for device seemingly forever. I have a local network using a 192.168.1.x network without any other intermediate firewalls, on this local network I have two Sonos One devices. Is there any sort of troubleshooting I can do from the dev version in order to help expedite a fix for this?

Thank you for showing interest in the project, I really appreciate it!
Hmm yea that sounds odd, it's basically the same setup I'm running. If you run the dev environment the server should output logs regarding the device discovery (in your bash console, not the chrome dev one). The logs should help us narrow down the problem. Let me know how it goes

Yeah, here is the output from running the development server as you've listed the instructions in your readme and doing a yarn install. It looks like it's looking for a bindings file
[1] Error: Could not locate the bindings file. Tried:
[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]  →<EMAIL_ADDRESS>[1]     at bindings (D:\code\budgie-stream\budgie-stream\node_modules\bindings\bindings.js:126:9)
[1]     at Object.<anonymous> (D:\code\budgie-stream\budgie-stream\node_modules\@suldashi\lame\lib\bindings.js:1:37)
[1]     at Module._compile (internal/modules/cjs/loader.js:967:30)
[1]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
[1]     at Module.load (internal/modules/cjs/loader.js:815:32)
[1]     at Module._load (internal/modules/cjs/loader.js:727:14)
[1]     at Function.Module._load (electron/js2c/asar.js:769:28)
[1]     at Module.require (internal/modules/cjs/loader.js:852:19)
[1]     at require (internal/modules/cjs/helpers.js:74:18)
[1]     at Object.<anonymous> (D:\code\budgie-stream\budgie-stream\node_modules\@suldashi\lame\lib\decoder.js:7:15)
[1] (node:7504) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

I've had problems with that package as well. In my case a electron rebuild solved my problems.
Have a look at the steps presented here https://github.com/filahf/budgie-stream#common-errors , might solve your problems as well

Thanks for the instructions, I did the rebuild on that package and the dev environment started up. When I hit Select Devices I see the following in my bash console ```[1]
[1] [Function]
[1] (node:2380) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[1] Https App started
[1]  Error in discovery {}
[1] undefined

Crises adverted, after a reboot the app appears to be working as expected! Thanks for taking time to work with me on this item.

 No worries. Thanks again for your interest in the project!


MatMenu html validity and accessibility consequences

Reproduction
Steps to reproduce:

navigate to https://material.angular.io/components/menu/overview
inspect the basic menu example code (menu-overview-example)

Expected Behavior
The html code should be valid: no "div" tag inside a "button" tag
Actual Behavior
There are two "div" tags inside the "button" tag, which breaks W3C validator :
Error: Element div not allowed as child of element button in this context.
It also breaks accessibility criterias as html code is supposed to be correct
Environment
https://material.angular.io/components/menu/overview website

Thanks for the submit, this issue was addressed in
https://github.com/angular/components/issues/16350
And has a PR to address it :-)

Closing as a duplicate of https://github.com/angular/components/issues/16350.


Can not render this simplest GS.

GS_make.zip
def gauss(color_rgb2sh=1):
def sigmoid(x):
return 1 / (1 + np.exp(-x))
def sigmoid_inverse(y):
return np.log(y / (1 - y))
p = np.array([
        [0.0, 0.0, 0.0],
        [1.0, 0.0, 0.0],
        [0.0, 1.0, 0.0],
        [0.0, 0.0, 1.0],
    ])  #WANT: [-∞,+∞]            #REAL: [-1,+1]*N  by tanh()*N
c = np.array([
        [0.6, 0.5, 0.4],
        [1.0, 0.0, 0.0],
        [0.0, 1.0, 0.0],
        [0.0, 0.0, 1.0],
    ])  #WANT: [0,1] by sigmoid()
a = np.array([
        [1.0],
        [0.9],
        [0.8],
        [0.7],
    ])  #WANT: [0,1] by sigmoid()
s = np.array([
        [0.030, 0.030, 0.030],
        [0.300, 0.300, 0.300],
        [0.001, 0.010, 0.100],
        [0.003, 0.030, 0.300],
    ])  #WANT: [-∞,+∞] by exp()    #REAL: [0.01,0.3]
r = np.array([
        [1.0, 0.0, 0.0, 0.0],
        [1.0, 0.0, 0.0, 0.0],
        [1.0, 0.0, 0.0, 0.0],
        [1.0, 0.0, 0.0, 0.0],
    ])  #WANT: [-1, 1]  #unit-quaternion  #torch.nn.functional.normalize

color_activation = ''  #sigmoid
if color_activation == 'sigmoid':
    c = sigmoid_inverse(c)
else:
    pass
if color_rgb2sh:
    c = (np.array(c)-0.5)/0.28209479177387814
else:
    pass

alpha_activation = ''  #sigmoid
if alpha_activation == 'sigmoid':
    a = sigmoid_inverse(a)
else:
    pass

scale_activation = 'exp'  #sigmoid
if scale_activation == 'sigmoid':
    s = sigmoid_inverse(s)
    scale_sigmoid_min = 0.001
    scale_sigmoid_max = 0.300
    s = scale_sigmoid_min + (scale_sigmoid_max-scale_sigmoid_min) * s
elif scale_activation == 'exp':
    s = np.log(s)
elif scale_activation == 'softplus':
    pass #TODO
else:
    s = s

return np.concatenate([p, c, a, s, r], axis=-1).astype(np.float32)

I'm not sure what this code is supposed to do. Also, it's all python and my repo only contains Javascript... was this question meant for a different project?

This python code generated a mini GS .ply.
gs.zip
But different render/viewer generated different output image.

It looks like your .ply file is ASCII format, can you re-export in binary format (little endian) and try again? Currently my viewer only supports binary format.

00 GS_make_view.zip
Thanks!!!

All the .ply files in that .zip bundle are still ascii format :)

Sorry, updated...  :-)
Uploading 00 GS_make_view.zip…

For some reason that just links to the github issue :)

A zip, downloadable ...

With that binary .ply I was able to see something similar to what you think you should be able to see:

The background is black because the default background for my viewer is black. (I don't currently have a way to change, that, I should probably add an option to set that).

@mkkellogg
yes, GREAT-MASTER:
I found that the binary .ply is right, and the text .ply can not be supported.   :-(
you can close this issue.
Thanks a lot.

Binary PLY format makes more sense for large scenes since it requires much less space :)


[DOCUMENTATION UPDATE] DCO_C1_2024.04.1

This ticket will track the changes in Chapter 1 documentation for April 2024

This task did not reach completion before the deadline. I will move this ticket to the 2024.04.2 Sprint.

Add Delivery Management Module in Chapter 1
reference #59


Inference Engine supported model?

May I know which models currently support model parallelization in inference? As a result of the verification, some models appear to replicate parameters as-is to other devices.

https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/module_inject/replace_policy.py
Are only the above 4 models currently supported?

Hi @hyunwoongko
This is true that we need to have replace policies for different models in order to both correctly parallelize and inject the kernels.
One caveat though is that it always needs to run through the DeepSpeed Inference API which knows where the results across different GPUs can be merged. Currently we support encoder-only or decoder-only architectures. I am working on the remaining pieces to add in the case of encoder-decoder models.
Thanks,
Reza

https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/module_inject/replace_module.py#L152
By the way, why doesn't qkvb change to fp16 in this part?

It might be None. I just moved it here: https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/module_inject/replace_module.py#L234

It looks to me like it's for GPTNeo. Thank you.
Could you tell me when the Inference Engine of the Seq2Seq architecture will be released?

@RezaYazdaniAminabadi
Could you tell me when the Inference Engine of the Seq2Seq architecture will be released?

Hi @hyunwoongko
Sorry for the late reply.
I am not exactly sure about the time this will be ready, but I would say this is not going to take that long. I am just looking into different models and understand their differences to find a generic way of supporting them that does not require too many changes for the inference engine. Can I ask for a few models that you have in mind regarding the seq2seq architecture?
Thanks,
Reza


MaterialDesignFloatingHintTextBox not displaying hint correctly

Hey, first I want to thank you for your great work :smile:
Since the update from 1.3.1 to 1.4 I have a small issue regarding the rendering of the floating hint in textboxes.
The bound values for the textboxes in my startup-control are initialized with default values in the constructor.
Before updating to 1.4 the floating hint was placed above the content (as it should be).
After updating to 1.4 the floating hint is placed behind the content (wrong behaviour).

If I switch to another control and back to the startup-control, the hint is placed above the content (right behaviour).
At design-time everything looks fine.

Hi, are you running on latest pre-release?  (1.4.1.x)

I am currently running the latest stable. I will try the latest pre-release and tell you the result.

If you're using a TemplateSelector I think I know what is the cause of this problem. I've faced the similar problem and been able to temporarily solve it by removing ManagedPropertyChangedCallback from TextFieldAssist. I know it's not a permanent solution but I might have found the reason why this bug happens.
It's because the state of TextBoxHint is being set twice after the form loads. Once in TextPropertyChangedCallback on the Loaded event. which is the right one and the other on RefreshState right after the control appears on the screen. The reason why the second call takes the control to the wrong state is that IsVisibleChanged event is being called before the binding happens. and while there is no text on the textbox. but for some unknown reason it changes the object's state using Dispatcher.BeginInvoke which makes the queue on the SynchronizationContext (I guess it's what it's called :) ). and for some reason Loaded event which is the right one happens right after the IsVisibleChanged, changes the object state to the right state but right after that the queued code comes and changes the state of HintText to the wrong state.
I have checked these steps on my debugger for multiple times. I might have made a mistake understanding why they happen like this but I know it is the cause of this bug.

@hshahdoost thanks for the info.

I've added some stuff to the demo to test templates, but I wasn't able to reproduce.  However someone had kindly sent me a repo with another example in a dialog (no - I havent added that example to the demo) which shows the error.
Seems to be fixed now, but please report back.

I checked it and it's fixed. thanks a lot.
There is just one thing. The following lines in TextPropertyChangedCallback seem to useless now. I removed them and everything worked just fine.
frameworkElement.Loaded += (sender, args) => VisualStateManager.GoToState(frameworkElement, state, false);
frameworkElement.IsVisibleChanged += (sender, args) => VisualStateManager.GoToState(frameworkElement, state, true);

You want to raise a PR with that?

I'm thinking more like it's a part of the bug. But if you think it's necessary to raise a PR I'll do that.

Just thought you might want credit :)

Just code reviewing it again.  I think I am going to leave those handlers in place.  Attached properites get applied after first load (I think, correct me if I'm wrong).  So if a control is loaded > managed property applied > unloaded > text changes...then you need to wait for next load to reapply the state.
So I think this should have some more of the complex load flows covered.

Sorry, for the delay, and also sorry for the mistake I made. You were right. I checked it and ManagedPropertyChangedCallback is not called when the form is reloaded.

Hi! I'm using the latest stable version from NuGet (<IP_ADDRESS>3), and bug is still here:

Then I select or enter value, anything works fine - hint flies away. But if I change active tab and return back, all hints are below entered or selected values

And on 2.0?

I'll check


Documentation on Methodology

Hi,
Great Repo!
I see that there are some papers listed in the comments. Do you think you could give us quick guide or list of papers corresponding to the techniques you have implemented?
Thanks!

Hi,
Thank you for your interest in the TextRL library! While I can't provide specific papers corresponding to the implementation, as TextRL is a composition of multiple techniques and ideas, I can provide you with a list of papers that are related to the general concepts of text generation, reinforcement learning, and fine-tuning pre-trained language models. These papers might help you understand the techniques and motivation behind TextRL.
https://rl4lms.apps.allenai.org
https://github.com/anthropics/hh-rlhf/tree/master
If you're looking for more specific details, you can check out the documentation and source code of the libraries that TextRL builds upon, such as Hugging Face's Transformers, PFRL, and OpenAI GYM.


Is the sim agents benchmark still running?

Hello,
I made a submission to the validation eval for the sim agents benchmark about 2 days ago and it hasn't finished evaluating yet. I wanted to check if the evaluation server is down?
I see this message when I view the submission:

Thank you!

Hi,
thanks for reaching out. Our evaluation server has some stability issues, I've just triggered a reprocessing of your submission. The results should be ready within ~1 day. Apologize for the inconvenience.

Thank you very much for the prompt response!
I've just uploaded a new submission to the sim agents test server. I was wondering if it would be possible to verify that the evaluation is running on that submission now? I'm guessing it is, but I want to be absolutely sure there isn't a problem given there are conference deadlines coming very soon.
Thank you!

Hello,
I made a submission to the sim agents benchmark 12 hours ago but it still says it's processing. Is the server down again?

Hello, I submitted to the sim agents test server 26 hours ago but it says it's still processing (I was struggling to upload results and ended up submitting 2 that are the same by accident, sorry about that). I wanted to check if the server is down?


[YouTube Downloader] ...

Extension
https://www.raycast.com/vimtor/youtube-downloader
Description
Ability to select start and end time for the video to be downloaded. To speed up the download process.
Who will benefit from this feature?
No response
Anything else?
No response

Hi, @HardIsEasy! (cool name btw)
I will try to implement this soon. I've tried in the past by attempting to cut the video using ffmpeg. However, I've realized that the ytdl-core library has built-in trimming, so I will give it a try and see what happens.


Remove IServerFactory

#698 @davidfowl @DamianEdwards @JunTaoLuo @muratg @mikeharder
Hosting now configures the addresses via IServerAddressesFeature, just like it was doing with defaults before.
One oddity: The server gets disposed twice. Once to stop the server, and once when we dispose the container. This is harmless.

Updated.

:shipit: from me, you may want to check with others.


Detect and copy images

Problem
Logseq has its local images stored in the /assets folder (directly in the root of your graph). And all Logseq pages use the standard markdown image syntax to include them:
- ![image.png](../assets/image.png)

logseq-exporter only copies the text, not the assets that the text points to
Solution

Detect relative links in the pages markdown and export the images as well.
The logseq-exporter will take two additional parameters:

--assetsFolder where it will export all images from public pages
--imagePathPrefix - this is going to be prepended to the image path in Markdown. If the imagePathPrefix is /images, then ![image.png](../assets/image.png) will transform into ![image.png](/images/image.png)

Extra consideration
For my usecase (blog posts) it would be useful if a hero image could be included in the Markdown front matter in the blog post. Maybe the tool could detect images in a page property image:: ../assets/image and copy these images as well.

Released now in 0.0.2


new 'required' build JSON plugin keyword

If required is set to false, absence of the plugin will not cause the build to fail.

Coverage increased (+0.009%) to 88.176% when pulling 83ae938116f99c8585e3c3f7e60186a6179ffd68 on plugin-required into ff27e0b5893a9c8e68fd0d52a24dddb939e21e93 on master.


configure.ac: add --disable-werror

Allow the user to disable -Werror to avoid the following build failure:
In file included from hash.c:7:
xxhash.h:2667:5: error: #warning is a GCC extension [-Werror]
 2667 | #   warning "XXH3 is highly inefficient without ARM or Thumb-2."
      |     ^~~~~~~
xxhash.h:2667:5: error: #warning "XXH3 is highly inefficient without ARM or Thumb-2." [-Werror=cpp]

Fixes:

http://autobuild.buildroot.org/results/3124bae73c207f1a118e57e41e222ef464ccb297

Signed-off-by: Fabrice Fontaine<EMAIL_ADDRESS>

Thanks!
What platform is that?
Any reason why this is being papered over instead of addressing the warning?

Not sure I really buy that. Yes, new compilers/different compilers have different warnings. Most of my "users" aren't actually building memcached, they're packagers; often on bleeding edge distro's. The packages are downstream from there.
Since I don't have bleeding edge versions of everything I often get reports as things are found, then they get fixed quickly, then anyone who does happen to build from tarballs on odd platforms don't get warnings. I feel like that's worked pretty well so far?
In this case we'd be running a potentially glacially slow hash algo on some platform, which seems like a real bug to me. There's no way I would ever build the software on this ARM platform myself (even with all of my buildbots that include a few ARM platforms), so I will never see this warning, and it will never get fixed, and any user who happens to use the software may be disappointed.
It'd be nice if the next branch is the thing that got tested against everyone's bleeding edge platform so I don't release things with warnings, but I take what I can get :)
The issue is more subtle than that of course, "what does a user do if they do hit a warning?" but the answer is almost always holding off on an upgrade of some kind and almost nobody ever upgrades off of an upstream packaged version, which has already resolved these issues.

@ffontaine can you share more info about what this platform/toolchain is? I'm curious if it has thumb2+ but is just missing the defines or if it's actually going to be glacially slow.

The failing build was for an arm926t (a variant of an arm920t, so it's an armv4 with Thumb, but not Thumb2.

Sorry I was pretty behind again.. since september apparently.
Thought about this more and decided to flip it; Werror is now off by default and this change adds a --enable-werror flag I can use in buildbots + local dev (or anyone who cares enough I guess). I don't want to disable pedantic and it seems like pedantic errors trigger some people.
Thanks again!


refactor: rewrite @volar/vue-typescript

Close #1045

pug :eyes: :raised_hands:

Make a save point...


Schema filtering for Hive catalogs

Currently Hive connector allows to specify uri for Hive Metastore and makes all schemas form default catalog visible.
In case, some schemas need to be skipped for security or convenience reasons (for example, we have two hive catalogs with different properties that use the same Hive Metastore)
Hive Metastore Thrift API supports filtering schemas (databases) with get_databases(String pattern) method.
Pattern allows to select only few databases in the default catalog: schema1|schema2 or 'schema*or select schemas from different Hive metastore catalog@catalog#schema1`
Hive connector could support new property:
hive.metastore.thrift.client.database-pattern=<pattern> (Default * that means everything from default catalog)
That property should be passed to get_databases instead of using get_all_databases
Known limitation. We can't ask for databases from different catalogs @cat1#|@cat2# will ignore databases from cat2

This is actually a security feature which is already supported. Simply filtering in the get_databases() metastore call is not sufficient, as that would not help with other calls like get_table(), alternate metastore implementations, etc. It could lead to strange situations such as a user creating a new schema that does not matched by the filtering pattern.
If you're using file based authorization for Hive, you can add schema rules to restrict the available schemas.
You can also use the file based system access control to limit schemas in any catalog.

File based system access control solves problem only partially:

It denies access to the tables, but they are still visible it causes confusion for end-users
@cat1# pattern allows to access non default catalogs from Hive Metastore

That is a problem tho - "It could lead to strange situations such as a user creating a new schema that is not matched by the filtering pattern."

File based system access control solves problem only partially:

@kosinsky Can you please try to check https://github.com/prestosql/presto/pull/5039 and see if it helps to you?

Looks like testSchemaRulesForCheckCanShowSchemas in #5039 tests that schemas that people don't have access will be hidden. That should cover my scenario.

@kosinsky Can we close the issue then?


Adding pixel spacing feature to have z stack defocus.

Adding pixel spacing feature to have z stack defocus.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.45%. Comparing base (d2dfc0c) to head (4fc3766).
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   83.33%   83.45%   +0.12%
==========================================
  Files           4        4
  Lines         132      133       +1
==========================================
+ Hits          110      111       +1
  Misses         22       22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ProtectedBranches should be able to handle pushing tags gracefully

This is a fix for Issue #480
When pushing tags, the pushed ref will look something like this:
refs/tags/release-0.1 e0250d9551467b32e2292ff163961b3af0f8ac67 refs/tags/release-0.1<PHONE_NUMBER>000000000000000000000000000000

This does not match the regular expression pattern of refs/heads, hence the failure.

Thanks for the PR, @hasghari!
Would be nice if we could protect against pushing arbitrary refs, but feels like this solution satisfies the common case.
The failure on Windows seems to be spurious (I've retried that build multiple times at it seems to always fail on a different version of Ruby, so the lack of consistency tells me the failure is not caused by your changes.

Thanks for the merge @sds. Can we get a patch release for this fix?

Looking to release a new version soon, @hasghari. Just waiting for #479 to be wrapped up. Thanks for your patience!


Handle multidigit nested arrays

currently, arrays with index comprehension longer than one digit would fail.
(i.e. "arrayName[12]")
this PR handles this and takes care of indexes with variable length

This is great! Thank you very much!


svg: Transform is not applied on clipPath's child

Even if transforms are declared for children of clipPath, they are not applied.
<svg viewBox="0 0 100 100"  xmlns="http://www.w3.org/2000/svg">
  <clipPath id="myClip">
     <path id="path" d="M20,20 L70,20 L70 70 L 20 70 Z" fill="red" transform="translate(20 0)"/>
  </clipPath>

  <path
    id="heart"
    d="M10,30 A20,20,0,0,1,50,30 A20,20,0,0,1,90,30 Q90,60,50,90 Q10,60,10,30 Z" clip-path="url(#myClip)" />

</svg>

a temporal regression during dev