Syntax error when running desktop utility

Scenic Landmarks.zip
Receiving the following error when running kml file:
System.Data.SqlClient.SqlException (0x80131904): Incorrect syntax near ','.
at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)    at System.Data.SqlClient.SqlInter nalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)
at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource1 completion, Int32 timeout, Task& task, Boolean asyncWrite)    at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at KML2SQL.Uploader.Upload(SqlConnection connection, Boolean dropExistingTable)
at KML2SQL.Uploader.Upload(String connectionString, Boolean dropExistingTable)
at KML2SQL.MainWindow.<>c__DisplayClass11_1.b__1()
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
ClientConnectionId:750ae162-19b0-4cbc-9030-de077c98eae0
Error Number:102,State:1,Class:15

I just released a new version. Let me know if that fixed the issue for you.

Worked like a charm! Thank you!

On closer inspection I see a problem. A particular placemark may have multiple sets of polygon coordinates. The utility is lumping them together in the placemark column creating one polygon by  joining the individual polygons. This produces weird results. It would be better to create one row for each polygon. I don't know if this is beyond the scope of this utility but it seems to be common in the kml's that I am using.  Attached is a kml which illustrates this issue.  The very first precinct is made up of four distinct polygons. Thank you for your efforts.
Police Precincts.zip


Remove error 9020 from getInitializationContextAsync call

Updates the getInitializationContextAsync snippet as the 9020 error is no longer returned when there is no initialization context. Related change: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/63441.
Other related PRs: https://github.com/OfficeDev/outlook-dev-docs/pull/979

@jasonjoh I can't seem to add you as a reviewer. This change is related to the one you recently merged: https://github.com/OfficeDev/outlook-dev-docs/pull/979. Would you be able to review and merge this change as well? Thanks!

No sorry, I don't have the access to do that. @davidchesnut can you help?


rustic check needs too much memory

rustic check run on a 64TB repo gets killed with OOM.
 - checking trees...
[00:29:17] █████████████████████████████████████░░░       4479/4751
Killed

@borkd Thanks for reporting!
Now, this is an issue I'm very much interested in fixing as one of rustic's promise is to use less memory than restic. However, I have never tried it on such an large repository.
There might be some non-ideal algorithms (most likely the one reading all trees) which use too much memory in your situation. I'll have to take a look and think about it.
Can you determine how much memory rustic uses here? And how much restic for comparison?
Running /usr/bin/time rustic ... or /usr/bin/time restic ... should suffice.
Even better would be to get a memory profile for your rustic check run...

Rustic's memory usage seems quite reasonable. This issue can be closed.
It appears that earlier OOM during check was a side effect of rustic caching in my test env. Without caching both restic and rustic finish check --no-cache in comparable amount of time and without issues.
restic
[...]
15478 additional files were found in the repo, which likely contain duplicate data.
You can run `restic prune` to correct this.
check snapshots, trees and blobs
no errors were found1 / 4751 snapshots
[32:06] 100.00%  4751 / 4751 snapshots
12768.21user 1063.38system 45:45.97elapsed 503%CPU (0avgtext+0avgdata 25802328maxresident)k

rustic
[...]
checking snapshots and trees...
- reading snapshots...
[00:00:01] ████████████████████████████████████████       4751/4751
- checking trees...
[00:43:49] ████████████████████████████████████████       4751/4751
6748.48user 10709.71system 48:54.87elapsed 594%CPU (0avgtext+0avgdata 11435812maxresident)k

Thanks for your results! Now, memory usage is very fine. And I'm also very satisfied with user CPU. But system CPU is very high - especially compared with restic.
Moreover total CPU usage is quite a bit higher than restic which is not expected...
I have to think about possible system bottlenecks.
So I leave this issues open :wink:

Here are my numbers from a ~200GB repo (local, without cache):
restic check:
85.71user 2.80system 0:47.30elapsed 187%CPU (0avgtext+0avgdata 239752maxresident)k
6328inputs+8outputs (39major+66427minor)pagefaults 0swaps

rustic check:
40.84user 5.12system 0:31.00elapsed 148%CPU (0avgtext+0avgdata 64980maxresident)k
3720inputs+0outputs (0major+371270minor)pagefaults 0swaps

So user CPU always seems to be about 50% of restic's user CPU. In my case rustic's system CPU is double the restic one, in case of your big repo, its 10 times. So this might be an effect which is even growing for bigger (in terms of trees) snapshots...
Could be because of memory allocations, though. In my case rustic gets 5 times minor pagefaults compared to restic.
@borkd: Can you also specify information about page faults for your example?

I tested to use the jemalloc allocator. In my case this did speed up rustic a bit, but left system cpu time and minor pagefaults still high.
There is now #54 which can be used for tests.

Level of parallelism may be behind some of the differences in execution profiles.
IIRC, stock restic parallelism was hardcoded to values which yield decent performance for typical consumer grade systems found in the wild. Finding those knobs and fiddling with them proved fruitful to experiment and balance the speed and resource use for different applications.
I have not looked at what rustic tries to do in terms of greed/most effective use of available resources, but I'm strongly in favor of sane defaults which are user tunable.
If the check requires 20M calls to filesystem where a repository is stored to complete that is what it takes. Host may have CPU cores and memory available to spin up excess workers, but they won't help much after backend becomes saturated.

Closing this as there seems to be no performance problem ATM.
If you encounter any similar or other performance topic, feel free to open a new issue !


First attempt at clustered submits and sorting jobs by priority

Changed state send by server.py to state how many jobs of a certain kind need to be submitted. Adjusted submit.py and client.py accordingly. Resolves #10 and #16

This will also resolve #16


Add more logging to scaffolding

We only log a small amount of information, and almost exclusively just for console output. We can add more thorough logging for provider writers who are building/testing their own reveng implementations.

[ ] Index on column that could not be scaffolded (see https://github.com/aspnet/EntityFramework/pull/3509/files#r42923752)

Fix checked in with commit 2d14e47. Addresses both the issues above.


0.12 Beta4

This is just a placeholder for when beta 4 is ready

Map 8555 tcp and udp
I made the webrtc ports mapped by default because I believe when go2rtc isn't looking for a connection there is no data exposed or accessible. May need to do more consideration for this.

I'm just wondering here, does the 8554 port need to be forwarded for viewing from Home Assistant? If so, it would be perhaps a good idea to have it forwarded by default.

I'm just wondering here, does the 8554 port need to be forwarded for viewing from Home Assistant? If so, it would be perhaps a good idea to have it forwarded by default.

Yes it's needed but we don't want to auto forward anything that gives unauthenticated access to sensitive info. This would be the case for 8554 so it should not be auto mapped

Also I think the ingress part may be usable as well

Sure. Thank you.


Refactor out the keyset pagination code

While working on:

#1999

I noticed that some of the most complex code in the existing table view is the code that implements keyset pagination:
https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/views/table.py#L417-L493
Extracting that into a utility function would simplify that code a lot.

The inputs and outputs for this are pretty complex.
Inputs:

?_next= from the query string
is_view - is this for a table or view? If it's a view it uses offset/limit pagination - which could actually work for arbitrary queries too. Also views could have keyset pagination if they are known to be sorted by a particular column.
Current sort order, in the form of sort and sort_desc
use_rowid for if the table is a rowid table with no primary key of its own
pks - the primary keys for the table
params - the current set of parameters, I think used just to count their length so new params can be added as p5 etc without collisions. This could be handled with a s0, s1 etc naming convention instead.

Outputs:

where_clauses - a list of where clauses to add to the query
params - additional parameters to use with the query due to the new where clauses
order_by - the order by clause

Crucial utility function: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/utils/init.py#L137-L160

Found more logic relating to this:
https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/views/table.py#L684-L732

Relevant issue:

https://github.com/simonw/datasette/issues/1773

Explains this comment: https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/views/table.py#LL697

Maybe the correct level of abstraction here is that pagination is something that happens to a SQL query that is defined as SQL and params, without an order by or limit. That's then wrapped in a sub-select and those things are added to it, plus the necessary where clauses depending on the page.
Need to check that the query plan for pagination of a subquery isn't slower than the plan for pagination as it works today.

For the SQL underlying this page (the second page in that compound primary key paginated sequence):
The explain for the default query: https://latest.datasette.io/fixtures?sql=explain+select
++pk1%2C
++pk2%2C
++pk3%2C
++content
from
++compound_three_primary_keys
where
++(
++++(pk1+>+%3Ap0)
++++or+(
++++++pk1+%3D+%3Ap0
++++++and+pk2+>+%3Ap1
++++)
++++or+(
++++++pk1+%3D+%3Ap0
++++++and+pk2+%3D+%3Ap1
++++++and+pk3+>+%3Ap2
++++)
++)
order+by
++pk1%2C
++pk2%2C
++pk3
limit
++101&p0=a&p1=d&p2=v
The explain for that query rewritten as this:
explain
select
  *
from
  (
    select
      pk1,
      pk2,
      pk3,
      content
    from
      compound_three_primary_keys
  )
where
  (
    (pk1 > :p0)
    or (
      pk1 = :p0
      and pk2 > :p1
    )
    or (
      pk1 = :p0
      and pk2 = :p1
      and pk3 > :p2
    )
  )
order by
  pk1,
  pk2,
  pk3
limit
  101

https://latest.datasette.io/fixtures?sql=explain+select+*+from+(select+
++pk1%2C
++pk2%2C
++pk3%2C
++content
from
++compound_three_primary_keys
)
++where
++(
++++(pk1+>+%3Ap0)
++++or+(
++++++pk1+%3D+%3Ap0
++++++and+pk2+>+%3Ap1
++++)
++++or+(
++++++pk1+%3D+%3Ap0
++++++and+pk2+%3D+%3Ap1
++++++and+pk3+>+%3Ap2
++++)
++)
order+by
++pk1%2C
++pk2%2C
++pk3
limit
++101&p0=a&p1=d&p2=v
Both explains have 31 steps and look pretty much identical.

Even more complicated: https://latest.datasette.io/fixtures/sortable?sortable_with_nulls__notnull=1&_next=0~2E692704598586882%2Ce%2Cr&_sort=sortable_with_nulls_2
The rewritten SQL for that is:
select * from (select pk1, pk2, content, sortable, sortable_with_nulls, sortable_with_nulls_2, text from sortable where "sortable_with_nulls" is not null)
  where (sortable_with_nulls_2 > :p2 or (sortable_with_nulls_2 = :p2 and ((pk1 > :p0)
  or
(pk1 = :p0 and pk2 > :p1)))) order by sortable_with_nulls_2, pk1, pk2 limit 101

And it still has the same number of explain steps as the current SQL witohut the subselect.

So I think I can write an abstraction that applies keyset pagination to ANY arbitrary SQL query provided it is given the query, the existing params (so it can pick names for the new params that won't overlap with them), the desired sort order, any existing _next token AND the columns that should be used to tie-break any duplicates.
Those tie breakers will be either the primary key(s) or rowid if none are provided.
What about the case of SQL views, where offset/limit should be used instead? I'm inclined to have that as a separate pagination abstraction entirely, with the calling code deciding which pagination helper to use based on if keyset pagination makes sense or not.
Might be easier to design a class structure for this starting with OffsetPaginator, then using that to inform the design of KeysetPaginator.

Doing this as a class makes sense to me. There are a few steps:

Instantiate the class with the information it needs, which includes sort order, page size, tiebreaker columns and SQL query and parameters
Generate the new SQL query that will actually be executed - maybe this takes the optional _next parameter? This returns the SQL and params that should be executed, where the SQL now includes pagination logic plus order by and limit
The calling code then gets to execute the SQL query to fetch the rows
Last step: those rows are passed to a paginator method which returns (rows, next) - where rows is the rows truncated to the correct length (really just with the last one cut off if it's too long for the length) and next is either None or a token, depending on if there should be a next page.

I'm going to build completely separate tests for this in test_pagination.py.

Most complicated example of a paginated query: https://latest.datasette.io/fixtures?sql=select
++pk1%2C
++pk2%2C
++content%2C
++sortable%2C
++sortable_with_nulls%2C
++sortable_with_nulls_2%2C
++text
from
++sortable
where
++(
++++sortable_with_nulls+is+null
++++and+(
++++++(pk1+>+%3Ap0)
++++++or+(
++++++++pk1+%3D+%3Ap0
++++++++and+pk2+>+%3Ap1
++++++)
++++)%0D%0A++)%0D%0Aorder+by%0D%0A++sortable_with_nulls+desc%2C%0D%0A++pk1%2C%0D%0A++pk2%0D%0Alimit%0D%0A++101&p0=h&p1=r
select
  pk1,
  pk2,
  content,
  sortable,
  sortable_with_nulls,
  sortable_with_nulls_2,
  text
from
  sortable
where
  (
    sortable_with_nulls is null
    and (
      (pk1 > :p0)
      or (
        pk1 = :p0
        and pk2 > :p1
      )
    )
  )
order by
  sortable_with_nulls desc,
  pk1,
  pk2
limit
  101

Rather than duplicate this rather awful hack:
         try:
             prefix = rows[-2][sort or sort_desc]
         except IndexError:
             # sort/sort_desc column missing from SELECT - look up value by PK instead
             prefix_where_clause = " and ".join(
                 "[{}] = :pk{}".format(pk, i) for i, pk in enumerate(pks)
             )
             prefix_lookup_sql = "select [{}] from [{}] where {}".format(
                 sort or sort_desc, table_name, prefix_where_clause
             )
             prefix = (
                 await db.execute(
                     prefix_lookup_sql,
                     {
                         **{
                             "pk{}".format(i): rows[-2][pk]
                             for i, pk in enumerate(pks)
                         }
                     },
                 )
             ).single_value()

I'm going to say that the code that calls the new pagination helper needs to ensure that the sort or sort_desc columns are selected. If it wants to ditch them later (e.g. because they were not included in ?_col=) it can do that later once the results have come back.


Unclear docs example for Dialog component

Dialog with a result example in the docs is a little bit unclear in my opinion on how to return the value back to DialogResultExample component. If you open the plunker version, you can nicely see two .html files where it shows you that on close method you pass in the parameter. But in the docs version, there is only html for DialogResultExample component.
I am suggesting that the html tab for docs on this example would be like this:
//dialog-result-example.html
<button md-button (click)="openDialog()">Launch dialog</button>
You chose: {{selectedOption}}

//dialog-result-example-dialog.html

Dialog

What would you like to do?

  <button md-button (click)="dialogRef.close('Option 1')">Option 1</button>
  <button md-button (click)="dialogRef.close('Option 2')">Option 2</button>

P.S. also, the title of example is Dailog with a result (notice the typo for Dialog).
Btw, you are doing an amazing work on Angular Material!

@kara The code to fix this is probably out side of the scope of what the 'Git' touches.
I've looked everywhere this feature is in there.. (Might not be 'good for community contribution)
@DevVersion You seem to do the tooling, I think these issues are related to that. I would love to help but really cannot find the code that generates these issues.
See :
https://github.com/angular/material2/blob/f526c9de8725496b04743a326c47f6fcc35b54e2/src/examples/example-module.ts#L111
https://github.com/angular/material2/blob/master/src/examples/example-data.ts#L27
The files are supposed to be injected into the md-tab-group inside the docs-example-viewer-source but they're not ¯_(ツ)_/¯.
Would gladly try and fix this if I could find out where exactly where the tabs for examples are generated
https://material.angular.io/components/component/dialog --> examples  --> (view source)
Notice: html ts css  but no additional html file.
These issues are related to #3002 but that is also missing additional files list in its definition in example-module.ts

Tracking via https://github.com/angular/material.angular.io/issues/165

great job! i have been working on the issue for a very long time when i was following the doc. your solution magically made it work!!! thanks


FileDialog: Avoid selecting the first item automatically in Open Folder Mode

Fixes #80744

Any chance of this making it in before the feature freeze? 🙏

This is a bug fix so not affected by features freeze

tbh this makes me wonder whether the selection is even necessary. When you use native dialog, it does not select anything in any mode. Maybe selecting is nice when you navigate with a keyboard, but I think file dialogs are mostly used with mouse? idk

Thanks!


Sensors and not binary ones

Hello. I m using delta dore door sensor.
They gives me sensors and not binary sensors.
Si i Can t see them
Using tydom plugin.
How Can i add my sensors to alarme.
Thanks for your help

Security sensors typically are binary devices (on/off, open/closed etc.)
If your tydom integration does not support this, you may need to add template sensors to convert to a binary state.
Take a look here: https://www.home-assistant.io/integrations/binary_sensor.template/


The filter category doesn't function

Even though I posted a lot of products, and created some categories in the admin dashboard, but when I go to the store and try to filter the products, it shows "No results". What should I do in this case?

@Grace-Endy  I have checked and it works. Are you sure that you are choose different categories in your product? If you edit an product you have option to select category for that product.


XMPP account never gets online

Sometimes XMPP account once became offline never reconnects again. In this situation when user tries to disable the account the app will freeze on "Disconnecting account" progress dialog.
Investigation shows that "disconnect" thread is waiting on "initializationLock" of Jabber provider. At the same time another thread(Keep alive thread) owns the same lock and tries to unregister the account. But it never does as it's blocked on another monitor in close() method of BufferedReader. Since "initializationLock" is never realesed we have a deadlock. The reason why close() method is blocked is unknown for now.
(Issue migrated from https://trac.jitsi.org/ticket/1266)

The situation from description above was also caused by "enter password" dialog being hidden by the contactlist on startup. Dialog was waiting forever thus blocking login thread and not allowing to disconnect. Fixed in  https://github.com/jitsi/jitsi-android/commit/89e6c44dc6d63ec8abb807f73af7770dff7f2635.

Sometimes Smack gets blocked on Socket connect() for even a minute, because it's called without specified timeout. This will also block "Disconnecting account" dialog on accounts list screen for the same amount of time.
java.lang.Thread.State: RUNNABLE
	  at libcore.io.Posix.connect(Posix.java:-1)
	  at libcore.io.BlockGuardOs.connect(BlockGuardOs.java:85)
	  at libcore.io.IoBridge.connectErrno(IoBridge.java:127)
	  at libcore.io.IoBridge.connect(IoBridge.java:112)
	  at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:192)
	  at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:459)
	  at java.net.Socket.connect(Socket.java:842)
	  at java.net.Socket.connect(Socket.java:785)
	  at org.jivesoftware.smack.proxy.DirectSocketFactory.createSocket(DirectSocketFactory.java:28)
	  at org.jivesoftware.smack.XMPPConnection.connectUsingConfiguration(XMPPConnection.java:527)
	  at org.jivesoftware.smack.XMPPConnection.connect(XMPPConnection.java:976)
	  at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.connectAndLogin(ProtocolProviderServiceJabberImpl.java:1172)
	  at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.connectAndLogin(ProtocolProviderServiceJabberImpl.java:946)
	  at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.connectUsingSRVRecords(ProtocolProviderServiceJabberImpl.java:885)
	  at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.initializeConnectAndLogin(ProtocolProviderServiceJabberImpl.java:678)
	  at net.java.sip.communicator.impl.protocol.jabber.ProtocolProviderServiceJabberImpl.register(ProtocolProviderServiceJabberImpl.java:475)
	  at net.java.sip.communicator.util.account.LoginManager$RegisterProvider.run(LoginManager.java:426)


Need to add MAPL_FileMetadataUtilsMod to base/Base.F90

For my refactoring of an external program I want to interaction with a netcdf file and use the class extension to FileMetadata class in PFIO but noticed that it is not in exposed with a "use MAPL" statement (so requires an explicit use). I'm going to  add this, just making it here so I can reference the issue in the PR.

Also found need to add one more module MAPL_VerticalDataMod...


Added metrics for number of tables and IS znode size.

Current coverage is 64.32% (diff: 90.00%)

No coverage report found for master at 00047a7.

Powered by Codecov. Last update 00047a7...1a9f4ed


Will Metal 3 be supported?

When Metal 3 releases, so probably with macOS 13 and iPadOS 16, October 24, will it get support for it? Metal 3 has some awesome features like MetalFX, Mesh shaders and Offline shader compilation. Metal 3 is a game changer for gaming on Mac, so I hope The Forge will support it. 😃

If you watched the last Apple keynote. They have shown the game No Man's Sky running on MacOS ... this game uses The Forge and it uses Metal 3.

Alright thanks

Any news on this?

They have been supporting Metal 3 for quite a while...


Add test for test execution in source dir

This closes #92

Thank you for writing this test, @andir! Awesome.


[Misc] Some logo work

I tried to integrate some Julia colors into the Awkward logo without alternating it, there are a few possible variations:

name
design

baseline

no dot

grouped dots

awkwardly placed dots

I liked the grouped dots: it's more obviously Juliesque. It would be good if the ".jl" is in the same gray as the letters. (If I remember right, it's exactly 50% gray so that it can be used equally on light backgrounds and dark backgrounds.)

so this?

Yeah! The three circles are tipped!
Also, I think you got the font right on the ".jl". I don't remember the name of the font that I had used, and it got converted into a path to do the modifications. The ".jl" is in a serif-font, and that looks right.

haha, yeah I went with a play with the k w distortion; the font is https://juliamono.netlify.app/ which is some serif-mono width

I like it 😄


Fix/style and state

run yarn or npm install

env vars for production and local
syntax highlighter
styling
localstorage
state management

I added error display to output.
There is error log output in driver that I think should return error and not just log to console? link


Add HTML

What is the expected behaviour?
Add the HTML <rp> tag, as specified here: https://www.w3schools.com/tags/tag_rp.asp

Closed via #228 thanks to @stiwwelll :rocket:


[Bug]: litellm doesn't support function calling model from OpenRouter. bug cause codeactagent couldn't interact with  internet solely without ask  browser agent  for  help

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
configuration:

litellm doesn't support function calling model from OpenRouter. bug cause codeactagent couldn't interact with  internet solely without ask  browser agent  for  help
I'm using model name anthropic/claude-3.5-sonnet
OpenHands Installation
Docker command in README
OpenHands Version
main
Operating System
MacOS
Logs, Errors, Screenshots, and Additional Context
No response

A quick hacky way for solving this problem for now would be adding 'claude-3.5-sonnetdirectly toFUNCTION_CALLING_SUPPORTED_MODELSinllm.py. We can also cleanup the other two sonnet` with suffix there.

I was getting this from OpenAI, OpenRouter, and Google.  The agent was not able to generate anything at all with 0.12
03:03:37 - openhands:WARNING: codeact_agent.py:101 - Function calling not supported for model openai/gpt-4o-mini. Disabling function calling.

03:10:05 - openhands:WARNING: codeact_agent.py:101 - Function calling not supported for model gemini/gemini-1.5-flash-002. Disabling function calling.

04:12:39 - openhands:WARNING: codeact_agent.py:101 - Function calling not supported for model openrouter/deepseek/deepseek-coder. Disabling function calling.

Who's 'we'? I have been using the project since it was OpenDevin and did not have a point release until the rename and investment. I'm glad the three are finally getting serious about it, but I got much more done on .09.
LiteLLM has always supported OpenRouter function calling.
https://docs.litellm.ai/docs/providers/openrouter
I have used many Open Router tool-calling models for testing in this project. Even when you had to manually chmod +x the work directory manually :)
LiteLLM supports Gemini
https://docs.litellm.ai/docs/providers/gemini
Anthropic has been low-tier for months.
I would use GPT-4o for the orchestrator maybe but for sub-agent processing makes no sense whatsoever.
https://openrouter.ai/qwen/qwen-2.5-coder-32b-instruct came out a few days ago and I am looking forward to putting it through its paces.
gemini-1.5-Flash-002 is the current gold standard for all of my agentic processing via other projects.
https://artificialanalysis.ai/models
https://openrouter.ai/rankings/programming/scripting?view=week
Even captured API projects like AutoGen MagenticOne can delegate to lower-cost apis like 4o-mini.
Maybe it was a bug and I will try .13 later today.  If the project is surreptitiously reducing compatibility in order to drive the Enterprise front end for people who don't know any better that would be unfortunate and I would have to move on.
To directly answer your question it was a new directory with just the docker pull and no manual editing in the IDE.

@FarVision2 In this PR we just merged, we evaluated a bunch of different models on SWE-Bench and find that not all models "that supports function calling" would work well on the current framework:

Based on these results, we currently only enable default function calling for OpenAI and Anthropic, and use mocked version of function calling for other providers.
For example, Gemini-series model have some bug where function calling would suddenly stopped working when conversation gets longer: https://github.com/All-Hands-AI/OpenHands/pull/4711#issuecomment-2476865857
We also tested Qwen 2.5 Coder 32B instruct (through OpenRouter) on SWE-Bench Lite as well, but the result were pretty low (3.33%). I look into some trajectories, it seems to get into loops and then start to output garbage at some point, not sure if it is a LLM hosting bug or something else.

@FarVision2 Sorry for the misunderstanding. Let me clarify:

we, the openhands project, are compatible with all LLMs supported by liteLLM. That does not change.
until fairly recently, we were using all these models without using their function calling feature. They supported it, but we didn't make use of it. We had our own implementation of "actions" (the rough equivalent of functions) and always told the LLM how to use them.
we have introduced function calling for several models, these. We are still testing and fixing compatibility of other models.

We are not decreasing compatibility, to the contrary, I'd say increasing it. Because we just didn't have function calling at all, and now we do.
Moreover, we are heading towards making it default, so the meaning of compatibility becomes keeping a supporting layer for the others, for the models that don't have function calling or litellm's layer doesn't work fully yet.
The warning messages you see only mean that this feature is not used, and openhands falls back to its own "actions" implementation, instead. That should be fine since it is how it always worked!
If it doesn't, can you please explain some more what doesn't work, what does it do, what do the logs say? Please note that the docker pull command in the readme has a new parameter -e LOG_ALL_EVENTS=true \ to log events.


NASA ADS

NASA Astrophysical Data System

Can take a look for this one.

Seems like we can't use this.
I had a look at the Terms and Condition
https://ui.adsabs.harvard.edu/help/terms/
It's not under a creative commons or any open licensed.

Full-text articles and abstracts of papers available from the ADS databases are copyrighted by the respective publishers and are subject to all applicable copyright protection under the laws of the United States and other countries. The reproduction of full-text articles or abstracts requires express written permission from the publisher.

The terms of use for NASA ADS don't seem scrape friendly.

Users may not perform systematic downloads of articles, abstracts, or tables of contents for any purpose, whether commercial or not, without the written permission of the ADS. This includes indiscriminate, mass downloads of search results and the use of robots.

Thanks for making note of this.


chore: make link in settings description clickable

For some reason you have to make links in settings descriptions with markdown syntax for them to turn into clickable links.

The link in the bottom right, which uses the bracket parenthesis syntax ([123](https://example.com)), is underlined and clickable while the plain link at the top center is not converted into a link and has to copy pasted.
I just took the title of the docs page and the section heading as the link text.

Wait let me just verify this works real quick.


Minimized and not ShowInTaskbar shows windows buttons command

Hello, if you set the property ShowInTaskbar to false in any MetroWindow and the window is minimized, when mouse over the minimized window it displays the standard Windows buttons commands which does not fit with the style.
It would be nice if the Metro Windows Commands button shows instead or at least not display the Windows one.
You an recreate it by setting ShowInTaskbar as false in any of your examples.
Thanks

@Antonyo can you show me a screenshot? which MahApps version?

@Antonyo ???

Sorry about this, the version I'm using is 1.1.3-ALPHA009 and this is a recording of the case
https://antonyo.tinytake.com/sf/MTY3NTAyXzEwNTk1NzY
Thanks in advance

No, I just cropped the video by a region of my screen but when minimized there´s no icon in taskbar (that´s the point of ShowInTaskbar=false).


Change from Set/GetNamedSecurityInfo to Nt{Query,Set}SecurityInfo

This PR changes the way that we were obtaining and setting ACLs to ensure accuracy. Set/GetNamedSecurityInfo would do some merging, which made it not entirely accurate for backups. However, the Nt{Query,Set}SecurityInfo APIs do not do merging, and allow for considerably more accurate preservation of ACLs.

TODO: an automated test to double check


remove classcast exception on topology.message.timeout.secs

closes  #32

Is there any update on accepting this merge request? Issue #32 still exists but just needs this merge request to be accepted.


change models ( with choices)

@PKpacheco how it is going with issue solving? Do you need any help? I have merged few other PRs in the mean time, so please update your fork.

@PKpacheco just wondering if you will have time ti finish this? Or if I should ask someone else to do it?

Closing due to lack of follow up.


Test-Connection fails when run as root on MacOS

Steps to reproduce

Install Powershell Core from .pkg
run 'sudo pwsh' to run powershell as root
Try a Test-Connection to any IP address.

Expected behavior
Test-Connection attempts to connect to the IP and returns the results of the connection attempt.

Actual behavior
Test-Connection errors instantly with the following error message and nothing is returned. Error is still instant even if a timeout is specified.

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.3
PSEdition                      Core
GitCommitId                    7.0.3
OS                             Darwin 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Can you call Get-Error after this and post the result?

Sure thing

@tipzie It may be already implied, but just so I'm clear, does Test-Connection work when you run pwsh as a regular user instead of sudo?

Yup, runs as expected on non-root. That's the output I posted under Expected Behavior.

@tipzie Please check with latest PowerShell 7.1 Preview.

Works as expected with 7.1 Preview

Sounds like there might have been an issue in .NET core that has since been fixed? 🤔

It comes from .Net. I do not think it makes sense to ask the fix for .Net 3 because we already moved to .Net 5.0. Also the cmdlet is an experimental and it is not ready for production (there are many other issues in the .Net API).

@tipzie Thanks for checking the preview version!
The root cause looks like this one: https://github.com/dotnet/runtime/issues/34879 and it's fixed in 5.0.
The labels on the PR don't suggest it's going to be back ported to 3.1.


Optimize In performance by reducing allocations for common queries

name          old time/op    new time/op    delta
In-8             466ns ± 1%     328ns ± 0%  -29.69%  (p=0.000 n=10+10)
In1k-8          6.42µs ± 0%    7.49µs ± 0%  +16.73%  (p=0.000 n=8+9)
In1kInt-8       9.71µs ± 8%    8.32µs ± 0%  -14.38%  (p=0.000 n=10+10)
In1kString-8    9.86µs ± 1%    9.05µs ± 0%   -8.22%  (p=0.000 n=10+9)

name          old alloc/op   new alloc/op   delta
In-8              512B ± 0%      272B ± 0%  -46.88%  (p=0.000 n=10+10)
In1k-8          22.7kB ± 0%    19.5kB ± 0%  -14.16%  (p=0.000 n=10+10)
In1kInt-8       22.7kB ± 0%    19.5kB ± 0%  -14.16%  (p=0.000 n=10+10)
In1kString-8    22.7kB ± 0%    19.5kB ± 0%  -14.16%  (p=0.000 n=10+10)

name          old allocs/op  new allocs/op  delta
In-8              10.0 ± 0%       4.0 ± 0%  -60.00%  (p=0.000 n=10+10)
In1k-8            5.00 ± 0%      3.00 ± 0%  -40.00%  (p=0.000 n=10+10)
In1kInt-8         5.00 ± 0%      3.00 ± 0%  -40.00%  (p=0.000 n=10+10)
In1kString-8      5.00 ± 0%      3.00 ± 0%  -40.00%  (p=0.000 n=10+10)

Pull Request Test Coverage Report for Build 156

15 of 17 (88.24%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 68.4%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bind.go
15
17
88.24%

Totals

Change from base Build 155:
0.03%

Covered Lines:
1039

Relevant Lines:
1519

💛  - Coveralls


eval_file_with_extras with ":raw" seems like it's trying to do two incompatible things

I'll start by showing what I'm trying to do (which doesn't work):
config.fetch("tiers", []).each do |tier|
  if tier
    all_tasks.push("tier_#{tier}")
    CfnDsl::RakeTask.new("tier_#{tier}") do |t|
      t.cfndsl_opts = {
        verbose: true,
        pretty: true,
        files: [{
          filename: "templates/app.rb",
          output:   "output/sandbox/app-#{tier}.template"
        }],
        extras: [
          [ :yaml, config_file ],
          [ :raw,  "tier=#{tier}" ]
        ]
      }
    end
  end
end

So, I'm starting with one template file, and producing output for a set of tiers. There is code in the template file that relies on tier being a Ruby value rather than a CloudFormation parameter.
As written, the Rake task fails with undefined local variable or method dev'` (where "dev" is one of my configured tiers), because the entire raw string is evaluated here.
However, if I change the code to include quotes ("tier=\"#{tier}\""), then the parameter is stored with the quotes here.
Trying to work-around by doing an assignment in the evaulated code fails, because that provides too many arguments to set_param.
I may be completely missing the point of :raw, but it seems that it shouldn't include the set_param call. And if that's true, then there needs to be another way to specify a single-value mapping.

We are actively working on making the API for converting templates in code better, sorry for this inconvenience. In the meantime, I'd encourage you to look at using either external parameters(which you can access programatically), or use the -D flag when setting simple key-value pairs on the command line.
The :raw directive (and command line flag) are not very safe, nor very intuitive and they will most likely be completely removed in newer versions of cfndsl. For the time being, you should be able to achieve what you would like with something like this:
config.fetch("tiers", []).each do |tier|
  if tier
    all_tasks.push("tier_#{tier}")
    # Use this way of defining tasks for now
    task "tier_#{tier}" do
      CfnDsl::ExternalParameters.defaults(tier: tier)
      model = CfnDsl.eval_file_with_extras("templates/app.rb", extras: [[ :yaml, config_file ], $stderr)
      output =  "output/sandbox/app-#{tier}.template"
      File.open(output, 'w'){ |f| f.puts model.to_json }
    end
  end
end

Hopefully this helps.

For future reference, here's my rewrite of the Rakefile per above:
tiers = ["sandbox", "prod"]

tiers.each do |tier|
  task tier do
    ["vpc", "app", "bastion", "db"].each do |s|
      CfnDsl::ExternalParameters.defaults(tier: tier)
      model = CfnDsl.eval_file_with_extras("templates/#{s}.rb", [[ :yaml, config_file ]], $stderr)
      output =  "output/sandbox/#{s}-#{tier}.template"
      File.open(output, 'w') do |f|
        f.puts JSON.pretty_generate(model)
      end
    end
  end
end

Thanks @kdgregory


Enter key freezing using the Python Microsoft extension

Does this issue occur when all extensions are disabled?: This issue DOES NOT occur when I disable the Microsoft Python extension.

VS Code Version: 1.6.0g
OS Version: Windows 10 Pro

Steps to Reproduce:
I am not able to reproduce this bug.
The enter key randomly stops working. After a while it starts working again for a bit, then it stops... and so on. I could not catch any regularity in this behaviour.
This happens only on python files when the Microsoft Python extension (version v2021.9.1191016588) is enabled.
This behaviour started right after upgrading VS and the Microsoft Python extension to their latest versions.

What do you mean by "enter key freezing"? Are you saying that VS Code literally does not insert a newline? That editor features stop working? That the editor itself freezes or crashes?

What do you mean by "enter key freezing"? Are you saying that VS Code literally does not insert a newline? That editor features stop working? That the editor itself freezes or crashes?

The editor does not insert a new line: it accepts all the other keys and it simply refutes to enter a new line. This only happens on Python files. It does not depend on the location of the Python file, if local or remote. Disabling the Microsoft Python extension solves the issue, but, obviously, you give up all the functions related to Python programming.
After a while, it "wakes up" for some key presses, then it stops again in accepting the enter/new-line. I am not able to find a pattern of typing that replicates such freezing.

This isn't the tracker for the Python extension; this is for Pylance.
If you disable the Pylance extension, does the issue remain?


Aggregate Support optimization

how about using pfr to implement this feature

the link of pfr project: https://github.com/boostorg/pfr

There is no reason to add a dependency to another library (other than libpq, of course), not even if we were to copy the code for PFR into our repository. PFR is multiple headers with 5000+ lines of code to replace a single header of ours with ~150 lines of code. And I won't even start on the complexity of the implementation. So, no, that provides no benefit and I will absolutely not do that.

Thanks for your reply. Is it possible to increase the limit of the number of struct field from 26 to some larger number like 128.

I've raised the limit to 99 for now. Is this sufficient or do you need more?

Yes, thanks a lot


Can't connect to Openshift Server - more than one authentication method found for admin

Command issued on MacOSx using version 0.4.27 when we try to connect to OSEv3 version v1.1.6 :
gofabric8 -s https://<IP_ADDRESS>:8443 --user admin --password admin validate
returns
Could not initialise a client - is your server setting correct?
invalid configuration: more than one authentication method found for admin; found [token basicAuth], only one is allowed

could you connect via oc get pods already?

Yes.

what happens if you omit the user/password arguments?

Then we will get a prompt to encode the username and password.

Nevertheless, we get these errors after being authenticated
Service account...............................................................✘ User "system:anonymous" cannot get serviceaccounts in project "default"
Console.......................................................................✘ User "system:anonymous" cannot get replicationcontrollers in project "default"
Failed to get PersistentVolumeClaims, User "system:anonymous" cannot list replicationcontrollers in project "default" in namespace default

what happens if you don't specify -s? I thought it reused the token you've generated via oc login?

are you setting any environment variables or something to force basicAuth?

No
On Fri, Jun 3, 2016 at 9:44 AM, James Strachan<EMAIL_ADDRESS>wrote:

are you setting any environment variables or something to force basicAuth?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/gofabric8/issues/64#issuecomment-223512898,
or mute the thread
https://github.com/notifications/unsubscribe/AAcTrhPUF7WajHddqBjYwrRC_eJWlqgJks5qH9tagaJpZM4ItNLA
.

@cmoulliard whats the output of
oc get pods
gofabric8 validate

oc get pods
NAME                      READY     STATUS             RESTARTS   AGE
apiman-gateway-d6vpz      0/1       CrashLoopBackOff   6          7m
apiman-pricz              0/1       Running            0          24m
cdi-cxf-2upd9             1/1       Running            0          30m
docker-registry-1-bq1gh   1/1       Running            0          1h
....
&
gofabric8 validate
Validating your OpenShift installation at https://<IP_ADDRESS>:8443 in
namespace default
Service
account...............................................................✔
Console.......................................................................✔
REST Proxy Service
API........................................................✘ Cannot query
the
Router........................................................................✔
Templates.....................................................................✔
SecurityContextConstraints....................................................✔
PersistentVolumeClaims........................................................✔
ConfigMaps....................................................................✔
On Fri, Jun 3, 2016 at 11:00 AM, James Strachan<EMAIL_ADDRESS>wrote:

@cmoulliard https://github.com/cmoulliard whats the output of
oc get pods
gofabric8 validate
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/gofabric8/issues/64#issuecomment-223527648,
or mute the thread
https://github.com/notifications/unsubscribe/AAcTrjoi3vsrRjQaGfvBu9GV5lE6_Yd3ks5qH-0wgaJpZM4ItNLA
.

--
Charles Moulliard
Apache Committer & PMC / Architect @RedHat
Twitter : @cmoulliard | Blog :  http://cmoulliard.github.io


"Panic: runtime error" when a workflow step is force closed after a timeout

Describe the bug
Running a complex workflow on a low-powered ARM system, we are running into occasional step timeouts in workflows, which the Arcaflow engine responds to by cancelling the step. After that step is cancelled, a series of related dependencies result in failures, and then ultimately the workflow fails with a traceback:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x135d790]

goroutine 358 [running]:
go.flow.arcalot.io/engine/workflow.(*executableWorkflow).Execute(0x400026d180, {0x1b4f450, 0x40006601e0}, {0x1553560?, 0x4000666b10?})
	/home/runner/go/pkg/mod/go.flow.arcalot.io/engine@v0.20.0-rc.3/workflow/workflow.go:256 +0x1360
go.flow.arcalot.io/engine/internal/step/foreach.(*runningStep).executeSubWorkflows.func1()
	/home/runner/go/pkg/mod/go.flow.arcalot.io/engine@v0.20.0-rc.3/internal/step/foreach/provider.go:882 +0x1f0
created by go.flow.arcalot.io/engine/internal/step/foreach.(*runningStep).executeSubWorkflows in goroutine 322
	/home/runner/go/pkg/mod/go.flow.arcalot.io/engine@v0.20.0-rc.3/internal/step/foreach/provider.go:864 +0xc8

To reproduce
Reproducible on the slow ARM systems we are testing on consistently with the below workflow (disable-steps branch), but presumably if you set closure_wait_timeout for the pcp step in the workflow-stressng.yaml file to some low value like 1000 the failure will be triggered even on a powerful system.
https://gitlab.com/redhat/edge/tests/perfscale/arcaflow-workflow-auto-perf/-/tree/disable-steps?ref_type=heads
Use the example-input-quick.yaml input file, and set all enable_<step> to False except enable_stressng: True
arcaflow --config config.yaml --input example-input-quick.yaml

output.txt
Full workflow output with traceback attached.

I've realized that it is possible that this failure is sourcing from the podman config having the read_only = true setting rather than the pcp timout specifically.

Fixed with #239


Documentation version tag incorrect

I believe the version is incorrect in the generated documentation:

This is most likely just an issue with the automation that builds the docs not receiving the correct version number from setuptools-scm.
https://conda-incubator.github.io/conda-project/user_guide.html

I'm not quite sure why the version number is incorrect, but I did notice we are building the docs for every push to the main branch. We should decide whether we want to continue doing that, or should build for tagged versions. We don't have the option to do all of them since we aren't using ReadTheDocs.
Alternately, I think we can adjust to the Sphinx settings to drop the version specifiers after the main SemVer format.

Closing, as the update to the conda theme made it irrelevant.


23 character length limitation on node identifier

Does the character limitation on the node identifier in the transactions subsystem still need to be only 23 characters?
https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L95
I just (accidentally) ran into this error when specifying a value longer than 23 characters, and was curious about the origin of this specific limitation, and whether or not it could/should be increased.

See https://issues.jboss.org/browse/AS7-5135?focusedCommentId=12705161&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12705161


Automatically pack static web assets for consumption

Generate Microsoft.AspNetCore.StaticWebAssets.props and pack it into
build\Microsoft.AspNetCore.StaticWebAssets.props
Generate <<PackageId>>.props and pack it into build\<<PackageId>>.props
importing Microsoft.AspNetCore.StaticWebAssets.props
Generate <<PackageId>>.props and pack it into buildMultiTargeting`<>.propsimportingbuild<>.props`
Generate <<PackageId>>.props and pack it into buildTransitive`<>.props importing buildMultiTargeting\<>.props`
Pack all the static web assets from the current project into staticwebassets\**

Last PR involving MSBuild!

Last PR involving MSBuild!

LOL no there will be bugs you have to fix 😆

LOL no there will be bugs you have to fix

I hatez you 👿

/AzurePipelines run

Updated


Duplicated afterEachAdLoaded when $.dfp() has been called more than once

Hi,
First of all, thanks for creating this plugin.
I have a page with an infinite scroll and I have followed the steps given in the instructions and also explained in some issues like #112, but when I create a callback to afterEachAdLoaded, each time I invoke dfp() to define the new ad, afterEachAdLoaded receives a repeated callback.
I have followed the code and I think the issue is related to the pubadsService.addEventListener('slotRenderEnded') made on line 137. This listener is added with each call to dfp().
I cannot show public code right now, but it can be reproduced with:
var options = {
    dfpID: 'xxxxxxxxx',
    enableSingleRequest: false,
    afterEachAdLoaded: function(ad) {
        console.log('afterEachAdLoaded', ad);
    }
};

$(document).ready(function() {
    $.dfp(options);
});

// This event is triggered when a new page is loaded using ajax
$(document).on('new-page-loaded', function($page) {
    console.log('New page');
    $page.find('.adunit').dfp(options);
});

The output shown in the console will be something like:
afterEachAdLoaded banner1
New page
afterEachAdLoaded banner2
afterEachAdLoaded banner2

After some develop I have created a version that distinguishes between "init" and "new ad" calls.
I am going to make a pull request for your consideration. I have made a strong effort to make it backward-compatible with current code.
I have not added the minified version or propose changes in the readme prior to your comments.

@tatai Any chance you'd be able to share the code here? I'm trying to get this going as well but to no avail.

@pribeh I created pul request #136 but it does not passed all tests so it cannot be evaluated for merging. Hopefully this week or next I will have some time to fix it. Feedback is welcomed

#136 didn't help me, slotRenderEnded listener is still being added on each $.dfp call.

#143 should fix this issue.


[Autocomplete] Extend componentsProps to include popper and popupIndicator slots

Closes #33233
Closes #33234

[x] I have followed (at least) the PR section of the contributing guide.

@ZeeshanTamboli I just added the missing slots to the highlighted function - that's all that needs to happen, right?

@ZeeshanTamboli I just added the missing slots to the highlighted function - that's all that needs to happen, right?

Yes, thanks.


Regression in 0.53.0rc1 for boolean conversion

See reproducer below. Reverting the temporary assignment change (d938288) solves the issue, but the underlying bug is most probably something else. This only happens with inlining so maybe inliner needs a closer look.
import numba
import numpy as np
import pandas as pd

val_one = True

def f(S):
    pass

@numba.extending.overload(f, inline="always")
def f_overload(A):

    def impl(A):
        for i in range(len(A)):
            val = val_one
            if A[i]:
                val = A[i]
        return val
    return impl

@numba.njit
def f2(A):
    return f(A)

print(f2(np.array([True, False, True])))

Traceback (most recent call last):
  File "../bool_cast_err2.py", line 25, in <module>
    print(f2(np.array([True, False, True])))
  File "/Users/ehsan/tmp/numba/numba/core/dispatcher.py", line 420, in _compile_for_args
    error_rewrite(e, 'typing')
  File "/Users/ehsan/tmp/numba/numba/core/dispatcher.py", line 361, in error_rewrite
    raise e.with_traceback(None)
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
No implementation of function Function(<function f at 0x7fc275ff3f70>) found for signature:

 >>> f(array(bool, 1d, C))

There are 2 candidate implementations:
  - Of which 2 did not match due to:
  Overload in function 'f_overload': File: ../bool_cast_err2.py: Line 10.
    With argument(s): '(array(bool, 1d, C))':
   Rejected as the implementation raised a specific error:
     TypingError: No conversion from bool to Literal[bool](True) for 'val', defined at ../bool_cast_err2.py (15)

   File "../bool_cast_err2.py", line 17:
       def impl(A):
           <source elided>
               if A[i]:
                   val = A[i]
                   ^

   During: typing of intrinsic-call at ../bool_cast_err2.py (17)

   File "../bool_cast_err2.py", line 17:
       def impl(A):
           <source elided>
               if A[i]:
                   val = A[i]
                   ^

  raised from /Users/ehsan/tmp/numba/numba/core/typeinfer.py:1071

During: resolving callee type: Function(<function f at 0x7fc275ff3f70>)
During: typing of call at ../bool_cast_err2.py (23)

File "../bool_cast_err2.py", line 23:
def f2(A):
    return f(A)
    ^

Many thanks for the report!
I can reproduce the issue with current master, and also observe that reverting the merge d938288 resolves the issue. The issue doesn't reproduce with Numba 0.52, hence is a regression.


Instr::AssertFailure must support error messages

The Instr::AssertFailure is utilized throughout codegen to stop execution when something invalid happens. We do not display any useful message for the developer about why the code stopped working.
The instruction must be refactored, using the new ABI encode algorithms, to support error messages created in code generation. This should improve developer experience.

This is implemented now.


Change serialization

I was looking at the interfaces and I think we could use JSON.stringify instead of serialize. E2E tests pass. Unit won't for now since we are testing File. Although I think it is possible to solve it too. Since the only place it can occur is "CallMessage" in args (its any type), so we could just map through args, find if there is File instance, serialize it, and JSON.stringify entire object.
Deserialization would be opposite, JSON.parse and then map serialize on args

Edit: Looking further has shown that we actually are not using any non serializable type in processes, so JSON.stringify / parse are enough to handle it. Based on this, I removed unit tests which were testing functionalities/cases which were not used in our code base.

Thanks for taking a look at our serialization.
Using JSON.stringify works in most situations, but there are situations where it doesn't. For example, if a user configures a custom karma configuration inside a stryker.conf.js file with some more complex stuff.
module.exports = {
    karma: {
        config: {
            proxyReq: function(proxyReq, req, res, options) {
              proxyReq.setHeader('Referer', 'https://www.example.com/');
            },
            client: {
              mocha: {
                grep: /fooComponent.*/
              }
           }
        }
    }
}

See: https://karma-runner.github.io/5.2/config/configuration-file.html
Same goes for other test runners.
This is sort of a hidden feature, so we might be able to get rid of this feature (obviously our e2e tests don't have anything like this).
We could also opt for using serialize-javascript, which is wildely used. We're using it in mocha as well, to serialize state in --parallel mode.

Uhh.... could we try at least making this as an option? Like making option:
{
  'files': ...,
  'testRunner': ...,
  'advanced': {
     'serialization': true/false
  }
}

and just making: const serialization = config.advanced.serialization ? surrial : JSON.stringify,
Something like this

Honestly I see no difference between serialize-javascript and surrial. Their basic behaviour is the same, which adds up to the same issues :/

Yes. It's more to improve maintenance than improve performance 🤷♂


FIX #103: copy fully yaml from extraVolumeMounts

Copy full yaml for extraVolumeMounts, so it will support subPath (and future proof).
Added test cases that pass now.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I think this is a duplicate of PR #97

Yeah looks like a duplicate of #97. I'll close this as a duplicate, thank you anyway for the contribution @bentatham!


YARN-11339. Upgrade Junit 4 to 5 in hadoop-yarn-services-api

Description of PR
Upgrade Junit 4 to 5 in hadoop-yarn-services-api
JIRA - YARN-11339
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 55s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  1s

trunk passed

+1 :green_heart:
shadedclient
23m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 17s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-api.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api: The patch generated 15 new + 1 unchanged - 0 fixed = 16 total (was 1)

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
23m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hadoop-yarn-services-api in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

101m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4995

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 1d60fbbff9ee 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a5b04636abd3fe042d4fda4c7d90d50eb059a479

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/1/testReport/

Max. process+thread count
603 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
83m 48s

trunk passed

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  1s

trunk passed

+1 :green_heart:
shadedclient
23m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 23s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 16s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-api.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
0m 47s

the patch passed

+1 :green_heart:
shadedclient
23m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  7s

hadoop-yarn-services-api in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

143m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4995

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 71c801a7c87d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5587ffa860604d220c13a8d50bf2a2aca5c4c949

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/2/testReport/

Max. process+thread count
604 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 49s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 37s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  0s

trunk passed

+1 :green_heart:
shadedclient
23m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 23s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
0m 48s

the patch passed

+1 :green_heart:
shadedclient
23m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  7s

hadoop-yarn-services-api in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

101m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4995

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle

uname
Linux 49c685a6cd9b 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3c1e6b6bc051accaeec0881958b817747b8b7e23

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/3/testReport/

Max. process+thread count
606 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-api

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4995/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@aajisaka please help in reviewing this PR. Thanks

Thanks @aajisaka for reviewing and merging


Remove did change workspace folders dynamic registration

#713

@bmewburn removing this defeats the whole purpose of the listener. If a server doesn't want to be notified about workspace folder events since the client don't support them it should not call the method. The listener / event code is helper code to make the registration easier. I am closing the PR because without registering we should remove the whole code.

@bmewburn removing this defeats the whole purpose of the listener. If a server doesn't want to be notified about workspace folder events since the client don't support them it should not call the method. The listener / event code is helper code to make the registration easier. I am closing the PR because without registering we should remove the whole code.

Actually thinking about it again we should guard this against the server capability to support the auto registration.

Actually thinking about it again we should guard this against the server capability to support the auto registration.

See comment https://github.com/microsoft/vscode-languageserver-node/issues/713#issuecomment-754510832. This requires a different change so. So I will close the PR since not registering at all makes the code wrong in other cases.

See comment https://github.com/microsoft/vscode-languageserver-node/issues/713#issuecomment-754510832. This requires a different change so. So I will close the PR since not registering at all makes the code wrong in other cases.

No problem, thanks for reviewing @dbaeumer

No problem, thanks for reviewing @dbaeumer


Improve test coverage for both unit and integration test s

Problem
Currently, unit and integration test coverage is not that great
Solution
Add test cases and improve coverage
Alternatives
No response
Additional context
No response

Duplicate of https://github.com/ansible/vscode-ansible/issues/139?

I've assigned Sorin since he's been looking into this lately anyway. Feel free to drop the assignment tho.

@ssbarnea since the issue is closed to card is moved in done column i project board. I assume it is closed because of the issue linked by @webknjaz. If yes please add it in the devtools project board under the right column

Reopening the issue at the original issue it closed and does not completely cover the scope of this issue

[ ]  Target code coverage ~70%

Sounds like we also need to integrate Codecov to track this metric.


BeginUpdateResource requires custom handle handling

Actual behavior
The handle returned by BeginUpdateResource must be closed by a call to EndUpdateResource instead of the normal CloseHandle call.  The default destructor for SafeFileHandle calls CloseHandle, which throws an error because it's attempting to close a handle it was never meant to close.  I worked around the issue by setting the handle as invalid after calling EndUpdateResource.
Expected behavior
The disposal of the HANDLE from BeginUpdateResource shouldn't throw an exception, which can't be traced because it's hidden in a generated Dispose call at the close of using block.
Repro steps

NativeMethods.txt content:

CreateTypeLib2
LoadTypeLibEx
CreateFile2
CreateFileMappingW
MapViewOfFileEx
UnmapViewOfFile
BeginUpdateResourceW
UpdateResourceW
EndUpdateResourceW

NativeMethods.json content (if present):

Any of your own code that should be shared?

Code using the various UpdateResource functions
        // And now it's time to take that shiny brand new type library, and shove it into a dll.

        var typeLibSize = new FileInfo(tempTypeLibPath).Length;

        // UpdateResource takes a ushort for the number of bytes to write, but the type lib size
        //  comes back as a long, so we need to check that the type lib will actually fit, and
        //  abort if it doesn't fit
        if (typeLibSize > uint.MaxValue)
          throw new Exception("Type library is too big to embed as a resource");

        using var hTypeLib = PInvoke.CreateFile2(tempTypeLibPath, FILE_ACCESS_FLAGS.FILE_GENERIC_READ, 0, FILE_CREATION_DISPOSITION.OPEN_EXISTING, null);
        if (hTypeLib.IsInvalid)
          throw new Win32Exception();

        using var hMap = PInvoke.CreateFileMapping(hTypeLib, null, PAGE_PROTECTION_FLAGS.PAGE_READONLY, 0, 0, null);
        if (hMap.IsInvalid)
          throw new Win32Exception();

        var lpData = PInvoke.MapViewOfFileEx(hMap, FILE_MAP.FILE_MAP_READ, 0, 0, UIntPtr.Zero, null);
        if (lpData == null)
          throw new Win32Exception();

        try
        {
          // PInvoke wraps the returned handle in a SafeFileHandle, which is annoying because the
          //  handle from BeginUpdateResource needs to be closed by EndUpdateResource instead of
          //  the usual CloseHandle call.  So we need to make sure to do that manually and then
          //  mark the handle as invalid so that SafeFileHandle doesn't die trying to close it for us
          using var hUpdate = PInvoke.BeginUpdateResource(destDllPath, false);
          if (hUpdate.IsInvalid)
            throw new Win32Exception();

          try
          {
            // In order to properly embed the type library (and make sure we replace the existing one)
            //  we have to use a very specific 'type' and 'name' that are defined by convention.
            //  The 'type' is straightforward, but while the 'name' is typed as a LPWSTR, it can also
            //  take the result of the `MAKEINTRESOURCE(i)` macro, which essentially passes an integer
            //  constant instead of a pointer (i.e. `(char*)1` but more complicated).  This is very
            //  straightforward in C++, but the C# bindings generated by PInvoke take a normal string,
            //  which doesn't let us pass a specific "address" like we need to.  So we had to copy/
            //  define our own overload that lets us do all the unsafe things that the
            //  API allows (and requires, in this case).
            if (!PInvoke.UpdateResource(hUpdate, "TYPELIB", 1, 0, lpData, (uint)typeLibSize))
            {
              // We don't care if this fails, we're already aborting anyway
              PInvoke.EndUpdateResource(hUpdate, true);
              throw new Win32Exception();
            }

            // This gave me a lot of trouble during development, returning a failed status but not actually
            //  reporting any errors. I finally narrowed it down to some leaked ITypeInfo objects up above,
            //  and after properly releasing those, this started working. Why those particular objects
            //  matter is beyond me, I was leaking other ITypeInfo objects and ICreateTypeInfo objects
            //  in CopyTypeInfo with no issues, but I've cleaned those leaks up as well and things
            //  seem to be working just as well as the C++ implementation now.
            if (!PInvoke.EndUpdateResource(hUpdate, false))
              throw new Win32Exception();
          }
          finally
          {
            // Set the handle as closed/invalid so that SafeFileHandle doesn't try to close it for us
            //  with the wrong function and throw an exception.
            hUpdate.SetHandleAsInvalid();
          }
        }
        finally
        {
          PInvoke.UnmapViewOfFile(lpData);
        }
      }

UpdateResource overload
#pragma warning disable CS1591,CS1573,CS0465,CS0649,CS8019,CS1570,CS1584,CS1658,CS0436
namespace Windows.Win32
{
  using global::System;
  using global::System.Diagnostics;
  using global::System.Runtime.CompilerServices;
  using global::System.Runtime.InteropServices;
  using winmdroot = global::Windows.Win32;

  internal static partial class PInvoke
  {
    // Copied (and slightly modified) from the autogenerated pinvoke stuff
    // Needed an overload to handle the case where lpName comes from MAKEINTRESOURCE
    /// <inheritdoc cref="UpdateResource(winmdroot.Foundation.HANDLE, winmdroot.Foundation.PCWSTR, winmdroot.Foundation.PCWSTR, ushort, void*, uint)"/>
    internal static unsafe winmdroot.Foundation.BOOL UpdateResource(SafeHandle hUpdate, string lpType, short lpName, ushort wLanguage, void* lpData, uint cb)
    {
      bool hUpdateAddRef = false;
      try
      {
        // fixed (char* lpNameLocal = lpName)
        // {

        // the lpName transformation is patterned after the MAKEINTRESOURCE macro
        // #define MAKEINTRESOURCEW(i) ((LPWSTR)((ULONG_PTR)((WORD)(i))))
        // I manually evaluated all of the defines in the above expression to show all the base types
        // #define MAKEINTRESOURCEW(i) ((*wchar_t)((unsigned long long)((unsigned short)(i))))
        char* lpNameLocal = (char*)(ulong)lpName;
        fixed (char* lpTypeLocal = lpType)
        {
          winmdroot.Foundation.HANDLE hUpdateLocal;
          if (hUpdate is object)
          {
            hUpdate.DangerousAddRef(ref hUpdateAddRef);
            hUpdateLocal = (winmdroot.Foundation.HANDLE)hUpdate.DangerousGetHandle();
          }
          else
            hUpdateLocal = default(winmdroot.Foundation.HANDLE);
          winmdroot.Foundation.BOOL __result = PInvoke.UpdateResource(hUpdateLocal, lpTypeLocal, lpNameLocal, wLanguage, lpData, cb);
          return __result;
        }
        // }
      }
      finally
      {
        if (hUpdateAddRef)
          hUpdate.DangerousRelease();
      }
    }
  }
}

Context

CsWin32 version: 0.1.619-beta
Target Framework: netstandard2.0
LangVersion:  8.0

This will have to be fixed in the metadata. We should define a new typedef struct that's decorated with the proper release function and force BeginUpdateResource to return that. Then CsWin32 will generate a new SafeHandle type.


Update and document Beyla requirements

The official docs did not show any requirements section. Also, the README requirements were outdated. We need version 5.8 because we are using BPF_MAP_TYPE_RINGBUF

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (da4aaef) 77.23% compared to head (6a7b014) 66.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #500       +/-   ##
===========================================
- Coverage   77.23%   66.00%   -11.24%
===========================================
  Files          67       64        -3
  Lines        5311     5195      -116
===========================================
- Hits         4102     3429      -673
- Misses        988     1493      +505
- Partials      221      273       +52

Flag
Coverage Δ

integration-test
66.00% <ø> (+0.17%)
:arrow_up:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.8 to before v4.9.292",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9c4566a117a6fe404a0e49b27ac71b631945a70f",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7afc6600ba3e2190a798c28898f132025d303d5a"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "9c4566a117a6fe404a0e49b27ac71b631945a70f",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "7afc6600ba3e2190a798c28898f132025d303d5a",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.292 by commit 7afc6600ba3e2190a798c28898f132025d303d5a, it was introduced in version v3.8 by commit 9c4566a117a6fe404a0e49b27ac71b631945a70f. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002371


Add suppressed exceptions support to AbstractThrowableAssert

While AbstractThrowableAssert allows to run assertions on the Throwable itself, its cause & its root cause; there is no dedicated API for suppressed exceptions.
I believe it could be useful to check that:

No suppressed exception is attached to the Throwable
A given Throwable is present in the suppressed exception list (and its usual variants: contains, containsExactly etc.)

I suggest to use hasNoSuppressedException for the first requested assertion.
The second request raises an interesting question: how do you compare exception ?
contains assertion relies on equals method  elements and exception equals is just inherited from Object which means that it only compares references.

Thanks for the feedback. I indeed noticed that hasCause and hasRootCause are not using object equality but their own mechanism based on the message and the class.
I will try to hack something using the same idiom and let you review it.

👍 would like to have at least something to check suppressed exception classes.

done.

@joel-costigliola : My pull request only added hasNoSuppressedExceptions so the hasSuppressedExceptions part is still missing.

ok my bad


Trouble in synthesizing MNIST model

Hello,
I trained my own MNIST model but synthesis is stuck. I am attaching my mnist.json and mnist.h5 files.
For testbench, I made an x_test.dat file which contains the pixel values of 10 images from mnist. So, the file has 10 rows and 784 columns.
y_test.dat file similarly contains 10 rols with 10 columns as the target labels.
The four files are attached:
issue.zip
This is my configuration file:
KerasJson: keras/mnist.json
KerasH5:   keras/mnist.h5
InputData: keras/x_test.dat
OutputPredictions: keras/y_test.dat
OutputDir: my-hls-test
ProjectName: myproject
XilinxPart: xc7a100tcsg324-1
ClockPeriod: 5
Backend: Vivado
IOType: io_parallel # options: io_serial/io_parallel
HLSConfig:
Model:
Precision: ap_fixed<16,6>
ReuseFactor: 2000
Strategy: resource
The other lines are commented
But when I run
hls4ml build -p my-hls-test -a
The synthesis is getting stuck at this message:
***** C SIMULATION *****
INFO: [SIM 211-2] *************** CSIM start ***************
INFO: [SIM 211-4] CSIM will launch GCC as the compiler.
Compiling ../../../../myproject_test.cpp in debug mode
Compiling ../../../../firmware/myproject.cpp in debug mode
Generating csim.exe
Processing input 0
INFO: Saved inference results to file: tb_data/csim_results.log
INFO: [SIM 211-1] CSim done with 0 errors.
INFO: [SIM 211-3] *************** CSIM finish ***************
***** C SIMULATION COMPLETED IN 0h0m6s *****
***** C/RTL SYNTHESIS *****
INFO: [SCHED 204-61] Option 'relax_ii_for_timing' is enabled, will increase II to preserve clock frequency constraints.
INFO: [HLS 200-10] Analyzing design file 'firmware/myproject.cpp' ...
WARNING: [HLS 214-114] Since the only kind of statements allowed in a dataflow region are variable declarations and function calls, the compiler may not be able to correctly handle the region: firmware/nnet_utils/nnet_dense.h:139:9
WARNING: [HLS 214-104] Only for-loops and functions support the dataflow: firmware/nnet_utils/nnet_dense.h:151:9
WARNING: [HLS 200-471] Dataflow form checks found 2 issue(s) in file firmware/myproject.cpp
INFO: [HLS 200-111] Finished Linking Time (s): cpu = 00:02:42 ; elapsed = 00:02:46 . Memory (MB): peak = 569.855 ; gain = 118.969 ; free physical = 891 ; free virtual = 5302
INFO: [HLS 200-111] Finished Checking Pragmas Time (s): cpu = 00:02:42 ; elapsed = 00:02:46 . Memory (MB): peak = 569.855 ; gain = 118.969 ; free physical = 892 ; free virtual = 5303
INFO: [HLS 200-10] Starting code transformations ...
Could you please have a look at my input files?

It's not stuck, it just needs a lot of time to partition the enormous weights arrays that you are trying to use. Try reducing the number of units in the Dense layers (now at 512) and applying some regularization so that the number of non-zero weights decreases.

I did. Now I made a small model. Now the synthesis completed but failed. Am I doing something wrong?
issue_2.zip
Here is the error log:
vivado_hls.log

It looks like the generated project uses PIPELINE pragma instead of DATAFLOW. The issue comes from here. You can specify Strategy: Resource (with a capital R) and it will work.

Thanks a lot! Everything was completed.
However, I did face some issues with the test files. So I had stored values with e notation and that had a lot of errors. But when I converted to %1.4f format, all the steps were completed.
Again thanks. I am closing this issue.


Download just EN subtitle

Hello.
I want to download a course which has 3 subtitle languages. English - Portuguese & Spanish,
i want to download just EN subtitle.
how to do that ?
Thank you.

@rhodesgod01 currently there is no option but i will consider this as future enhancement.


Match Location

Hello YARA developers.
I will keep my question short for your convenience:
When running YARA to check for matches within a file, YARA returns the rule name as well as the file that matched, and if requested with '-s' option, it returns the string that matched as well as the line location within the file. For instance:
RuleName File.txt
0x37c7a7:$str37: UNION
My question is, is there a way that I can use YARA so that it prints not only the line location like 0x37c7a7 above, but also the full line content (i.e. print the entire line in the file that matched)?
It looks something like this in my head:
RuleName File.txt
0x37c7a7:$str37: UNION "(?=.*(UNION.*ALL.*SELECT))"
Thank you for your time.

No, YARA doesn't have the notion of "line", because it wasn't designed with text files in mind. YARA treats all files as a sequence of raw bytes.


Integrate SLSA ("Supply-chain Levels for Software Artifacts") support

Problem

Any software can introduce vulnerabilities into a supply chain. As a system gets more complex, it’s critical to already have checks and best practices in place to guarantee artifact integrity, that the source code you’re relying on is the code you’re actually using. Without solid foundations and a plan for the system as it grows, it’s difficult to focus your efforts against tomorrow’s next hack, breach or compromise.

from https://slsa.dev/
Proposed Solution
SLSA is in essence a framework/specification/ for software supply chain security.
SLSA seems to be a big industry effort on getting to deal with supply-chain security, which has never been done before in that essence AFAIK: https://openssf.org/press-release/2023/04/19/openssf-announces-slsa-version-1-0-release/
There is a big theory block to unpack, and I also have not yet gotten it all and also think this is quite… huge…, but in general it makes sense: There are many risks associated and we of course target the OSS use case here though in general.

in general everything is about publishing attestations about how the software was built, in the end to a public source like this
there are different security levels
you may have seen projects like Docker etc. currently implementing support for it

(mostly copied from another project)
Notes
There has been previous discussion here about that. But I wanted to raise it as an issue, as it seems(?) to be getting the most popular or (currently) the one that is working best right now.
This is heavily related to https://github.com/rust-lang/crates.io/issues/75 / https://github.com/sigstore/community/issues/25
To get to this topic more easily the first step may actually not be cargo integration, but…

writing a builder for rust projects, so they can publish provenance outside of that world.
actually getting the cargo build to publish provenance in the first step (which is a different issue IMHO, so feel free to track it in a different issue)

Sure, do that, I guess we can keep this issue as a meta issue? I am not very much in the details of crate etc., but given recent incidents I guess this topic get's more important/attention, because SLSA is, IMHO, a partial solution or at least the best technical solution we can get for this issue…

npm and PyPI also don't verify any kind of signatures of downloaded packages

It seems npm now supports slsa provenance file natively. Creating the provenance file and checking the provenance of an installed package is supported from npm command line (see publishing and auditing). Could be very nice to have the same behaviour with cargo.
I'm currently trying to create provenance file manually but I have some issues linked to the files inserted into the crate before uploading like Cargo.toml.orig (related to this issue)


Ensure that API MNFR modifying functions modify the object

What type of PR is this?
Bug
What this PR does / why we need it?

Ensures that the object mutating functions for the ManagedFleetNotificationRecord type actually modify the object for which the functions are being called.
Adds unit tests to verify correctness of operation.

Codecov Report

Merging #64 (f652f7e) into master (223f3f9) will increase coverage by 1.90%.
The diff coverage is 91.17%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   61.82%   63.72%   +1.90%
==========================================
  Files          19       19
  Lines        1061     1078      +17
==========================================
+ Hits          656      687      +31
+ Misses        348      333      -15
- Partials       57       58       +1

Impacted Files
Coverage Δ

...i/v1alpha1/managedfleetnotificationrecord_types.go
39.75% <91.17%> (+36.72%)
:arrow_up:

Thanks a lot Matt.. Adding LGTM for now
/lgtm


Guest are also allowed not only members

Under heading "How does Azure AD control access to VSTS?" in first line It says "directory so that only users who are members "
I think this can create confusion, it should say " users who are members or guest in that directory..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a13b33d2-ea72-cc70-4572-f65ad9f357d6
Version Independent ID: 502c6ac4-320b-41b6-21d5-cd66072fa9ef
Content: VSTS - Access with Azure AD
Content Source: docs/accounts/access-with-azure-ad.md
Service: unspecified
GitHub Login: @douge
Microsoft Alias: chcomley

@PrateekChaudharyDevOps  Thanks for the update! I've added this detail to the topic and it should be live online sometime today.


Question - tinyember - VSM - Parameter access after restart

Hello!
This question is maybe a little bit too much about VSM and not ember+, but I hope this is the right forum to ask this question. I'm using ember+ (tinyember client) to communicate with VSM and have a question regarding how the parameters in the glow tree behaves after a VSM restart.
When VSM has been restarted parameters with access ReadWrite switches access to ReadOnly. As indicated by the VSM gui (black text instead of blue in gadget view).  This does not happen if the parameter is assigned to a VSM button.
It looks like this in VSM. This is before the restart, it is possible to modify both parameters.

But after the restart only the one connected to a button (Video Format) is modifiable.

It is possible to get the right access back by restarting the tinyember client, but I feel like it should not be necessary to do this.
To replicate this:

Start VSM.
Start tinyember.
Create a node in tinyember and fill it with two EnumParameters (haven't tried with other parameters).
Connect VSM to tinyember.
Assign one of the parameters to a button in VSM.
Save and restart VSM.
One of the parameters is modifiable (the one connected to the button) and the other is not modifiable.
Save and restart tinyember.
Now both parameters is modifiable.

Is this intended behaviour?
If it is, is it possible to make the second parameter modifiable?
Kind regards Emil

Hi Emil,
Unfortunately your question is too specific to VSM to be answered here. I suggest you contact the VSM service either by writing an email to<EMAIL_ADDRESS>indicating that you need help with a VSM specific problem or by calling +49 611 262 390 50, which is the VSM specific support hotline as mentioned here: https://www.lawo.com/en/services/service-support/service-contact.html
Best regards,
Kimon