[Parser] can't parse inner await of export default.

Input
export default obj({
    async f() {
        await g();
    }
});

Output
ERROR in ./src/index.js
Module parse failed: The keyword 'await' is reserved (3:8)
You may need an appropriate loader to handle this file type.

Version
"@swc/core": "^1.0.33",
"swc-loader": "^0.1.4",

If this is not so hard issue, I want to tackle this too!

@Knium @kdy1
Actually, i belive this should be a syntax error.
Because obj(...) is an expr, but async f() { ... } is a stmt, if u realy want do that, u should use function expr not function stmt. like this async f() => { }.

@LuoZijun
Hi, thanks for your mention! I read your explanation and some syntax in spec. Your opinion sounds correct but it is legal input in Babel... I should confirm why Babel accepts my input.

I think

async f() {
      await g();
}

is a method property and if then, it is a bug of parser

@dy
BindingPropertyList need key, if have a key, that's fine.

@Knium
BTW: the babel support a lot of syntax , but them not belong ecmascript spec.

This error comes from swc's transform, not parser.
swc emits
export default obj({
    f () {
        await g();
    }
});


FIX #1709

fixes: #1709
What I did
Moved cacheDirectory back to webpack config from babel config
How to test
See issue (I think it should be apparent when using storyshots?)

RE: testing -- yes this was a storyshots issue, test the various app modes in SS.

Seems like we .eslintignore everything related to vue: https://github.com/storybooks/storybook/blob/master/.eslintignore#L9
Is there any good reason for that?

That's what I get when I remove this line:
111 problems (10 errors, 101 warnings)
0 errors, 85 warnings potentially fixable with the `--fix` option.

Seems doable, I'll try to handle it

Here it is #1715

❤
Could we have a patch release? :D


Add support for default certificate

What this PR does / why we need it:
This adds support for using the default TLS Secret provided by the ingress controller.
Special notes for your reviewer:
secretName is optional for Ingress, for instance if you use --default-ssl-certificatein the ingress-nginx and have a wildcard certificate, you do not need to specify the default secret every time.

/assign
/ok-to-test

Please rebase master and resolve merge conflicts

@rjkernick rebased and resolved conflicts.

/lgtm


fixBadValues flag for reader

#20

I don't think classes should be modified to accept wrong values, that would lead to a value inconsistent api
I think it's better to add an interface like DeserializationErrorHandler (or something like that), similar to what you suggested in #20

I think we should:

Add API for handling errors when deserializating values
Make serializer-minecraft subproject use that API instead of always throwing exceptions

unfortunately my skills are too low to do this


Ipaddr does not provide an export named 'default

Issue
Setup:

Deno Version: 1.12.2
v8 Version: <IP_ADDRESS>
Typescript Version: 4.3.5
Opine Version: 1.7.0

Details
error: Uncaught SyntaxError: The requested module<EMAIL_ADDRESS>does not provide an export named 'default'
export { default as ipaddr } from<EMAIL_ADDRESS>~~~~~~~~~~~~~~~~~
at  (https://deno.land/x/opine@1.7.0/deps.ts:54:10).

Hmm, can’t reproduce with that error, but am seeing 408 timeouts when try to access that asset via esm.sh - wonder if the CDN is having issues 🤔

Have reproduced reliably now - curious as nothing has changed from Opine's side - indeed CI passed for this version, importing this dep etc.
From what understand esm.sh maps to a mutable cdn.esm.sh/v* like url, and suspect that a version has revved and introduced a regression. It doesn't appear that you can fix the version of esm.sh that you use as it just bounces you, so we are suspectible to breaking changes. Going to give migrating to skypack a go.


Update concord232.py to fix the home/stay command

Description:
Related issue (if applicable): fixes #5049
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @CTLS,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I have not solved why the away mode does not work still, but this allows the stay/ home mode to work so at least the alarm can be armed and disarmed.

Did you try the 'exit' arm type as mentioned in https://github.com/home-assistant/home-assistant/issues/2194?

Just tried that and it doesn't work.  I am not sure if it is an error with the concord232 server or the component.

After looking at the code of the concord232 server and comparing to the nx584 which it was built off of it looks like the concord232 server is missing the code for away mode and auto.  I believe updating the stay code as I have changed it is the best that can be done on this side everything else would need to be updated on the concord232 server code by @Jasoncarter80 and not in the home assistant component.

Ok. If you know what to fix upstream, you can make a PR to concord232, and hopefully get that in.
I'll merge this now. This will autoclose #5049. Either open a new issue for the remaining problem or let me know in #5049 if we should keep that open.

My Concord is offline, so I can't test any pull.  If you submit a PR to
the Concord I can add you as an admin to the repo to help maintain it.--
Best Regards,
Jason Carter
m:<PHONE_NUMBER>
e<EMAIL_ADDRESS>"Anyone who stops learning is old, whether at twenty or eighty" -
Henry Ford
On Sun, May 28, 2017, at 01:37 AM, CTLS wrote:

After looking at the code of the concord232 server and comparing to
the nx584 which it was built off of it looks like the concord232
server is missing the code for away mode and auto.  I believe updating
the stay code as I have changed it is the best that can be done on
this side everything else would need to be updated on the concord232
server code by @JasonCarter80[1] and not in the home assistant
component.> — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[2], or mute the thread[3].>

Links:

https://github.com/jasoncarter80
https://github.com/home-assistant/home-assistant/pull/7789#issuecomment-304494181
https://github.com/notifications/unsubscribe-auth/AAot94qg2BLT2a1hg_RPjmnO8lgernz1ks5r-QgKgaJpZM4NoF7a


Paste GitHub (Preview) auth token with mouse won't work

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

[ ] Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[ ] Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
[ ] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
[x] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
[ ] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Using Atom 1.18.0-beta2 on Windows, right-click to paste the auth token for GitHub (Preview) won't show "paste" as an option; instead you have bunch of options for splitting and closing the pane.
Not a major issue (since Ctrl-v will do it), but still it doesn't seem to be the "correct" behaviour to me, hence the issue.
Cheers! 🍻
Versions
1.18.0-beta2

Thanks for the report!  Can you open this in https://github.com/atom/github?  I think that might be a better repo for this issue - if not we can always re-open this one :v:


Web component on port 3011

Move fully to port 3011 due to web component builds being reliant on it locally and docker port mapping not cutting the mustard

completed as part of another PR and live


Get jquery from cypress when running in cy context

This change allows you to instantiate a webhmi machine within the cypress testing context.
Having a webhmi machine in the cypress testing context is useful for forcing IO or initiating commands that aren't available through the DOM.
The concept is well tested, but this particular implementation is not - the nodejs check and jQueryImport var are new.

I'm not sure why we need this. I think in the cypress example we should just make sure jquery is loaded before webHMI. Is there a reason that doesn't work?

I'll need to revisit this. I don't have an answer right now.


Feature request: Optimize Circuit-Breaking for SQS FIFO Partial Processor on records with different group IDs

Use case
Discussed in https://github.com/aws-powertools/powertools-lambda-python/discussions/2936
We confirmed that SQS FIFO queues can deliver messages from different Group IDs to the same Lambda invocation. Right now, when a record fails processing, we short-circuit an fail the rest of the items on the invocation, regardless if they are from the same message group  ID or not.
This un-optimal experience can lead to unintended messages landing on DLQs or failing completely.
We need to explore the idea of continuing to process other group IDs on the same invocation.
Solution/User Experience
When a message fails processing on the SQS FIFO resolver, collect the remaining messages from the same group ID. When a new group ID is found, start processing again.
At the end, return all the failed messages from each message group ID.
Alternative solutions
Depending how the implementation and behaviour turns out, we might consider not making the new behavior the default one, and keep it behind a feature flag.
Acknowledgement

[X] This feature request meets Powertools for AWS Lambda (Python) Tenets
[X] Should this be considered in other Powertools for AWS Lambda languages? i.e. Java, TypeScript, and .NET

From the discussion

Originally posted by duc00 August  8, 2023
Hello,
According to Implementing partial batch responses AWS doc:

If you're using this feature with a FIFO queue, your function should stop processing messages after the first failure and return all failed and unprocessed messages in batchItemFailures. This helps preserve the ordering of messages in your queue.

I see that Powertools implementation of the doc, with SqsFifoPartialProcessor, is strictly following this recommendation. This question is thus more specific to AWS implementation of partial batch responses with FIFO. Posting the question on this repo seems to be a good entry point nonetheless, since both AWS developers and community interact on those subjects.
My problem is the following:
I am processing a SQS FIFO queue with SqsFifoPartialProcessor. My batch size is 10. Since the queue is not high-scale, the batch often contains messages with different message group IDs. When a failure occurs, the rest of the processing is stopped and all records left are returned as failures to the queue. So I often end-up with valid records in my dead-letter queue just because they were processed in a batch containing an unrelated invalid one.
My question:
Would it be valid, after a failure, to return all remaining records in the batch but only the ones with the same group ID? According to the doc, current implementation is recommended to preserve the ordering of messages in your queue. I am not seeing why processing other records with a different group ID would go against that. Thus my question.
Many thanks!

Here's our plan:

we'll write some sample code to try to emulate the behavior, to make sure we can test it
we'll try and test to continue to process other message group ids, to see if there isn't any bad consequences
we'll assess how this may or may not be a breaking change, and evaluate if this should be the default behavior or behind a feature flag

Hello @duc00! I'm adding this issue to our next iteration (09/09 - 22/09) so we have time to validate scenarios and decide the way forward.
Thank you for your patience, but this is a complex case and may involve a breaking change in the current behavior.

Hello everybody! Updating this issue after some time. We continued working on this and we opened an internal ticket to the service team in order to fully understand this issue, as we found some more data that leaves me confused.
As soon as we receive a response to this ticket, I will update this issue and we will work on it.
Thank you, everyone, for your patience.

Hey @leandrodamascena, great news, thanks. 😄 Let me know if I can help review the code once it's out.

1 - Add a flag to SqsFifoPartialProcessor so that the customer can intentionally choose whether to stop processing at the first error or whether to stop processing just that MessageGroupId and process the others.

Do you think the flag set to MessageGroupId only could be made default in a future major release? This seems like a sensible default behaviour, once the AWS SQS doc is updated.

Do you think the flag set to MessageGroupId only could be made default in a future major release? This seems like a sensible default behaviour, once the AWS SQS doc is updated.

Hello @duc00! I think we can wait for customer feedback before deciding whether to make this behavior the default in Powertools v3. However, I'll keep this idea in mind to ensure we don't lose track of it.
The PR is all set for review. If you have any comments or spot any issues, feel free to share them and make comments. Your feedback is always appreciated!

Awesome! Thank you all 😊

And the Lambda team has updated the documentation to make it clear that a batch can have more than one MessageGroupID. Thank you so much for bringing this topic up and helping us improve the Powertools experience and AWS documentation, your contribution has been invaluable here @duc00.
https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#events-sqs-scaling
Before

"For FIFO queues, Lambda sends messages to your function in the order that it receives them. When you send a message to a FIFO queue, you specify a message group ID. Amazon SQS ensures that messages in the same group are delivered to Lambda in order. Lambda sorts the messages into groups and sends only one batch at a time for a group. If your function returns an error, the function attempts all retries on the affected messages before Lambda receives additional messages from the same group."

Now

For FIFO queues, Lambda sends messages to your function in the order that it receives them. When you send a message to a FIFO queue, you specify a message group ID. Amazon SQS ensures that messages in the same group are delivered to Lambda in order. When Lambda reads your messages into batches, each batch may contain messages from more than one message group, but the order of the messages is maintained. If your function returns an error, the function attempts all retries on the affected messages before Lambda receives additional messages from the same group.


Missing code autocomplete for referential actions with mongodb

Bug description
Not sure if this is a bug or a missing feature, but when adding any referential actions (onDelete or onUpdate), it does not give any auto-suggestion in vscode even while using the Prisma extension.
Normally it gives fields, names, references when creating any type of relation between models but it does not give for onDelete or onUpdate. Also all the support actions with it (Cascade, SetNull, etc).
How to reproduce

Create a relation between 2 models,
Try adding a referential action for say onDelete.
Here, you have to type it it up all manually.

Expected behavior
the actions gets auto-suggested as to what type of relation you want to set.
Prisma information

generator client {
   provider = "prisma-client-js"
}

datasource db {
   provider = "mongodb"
   url      = env("DATABASE_URL")
}

model Post {
   id       String @id @default(auto()) @map("_id") @db.ObjectId
   title    String
   author   User   @relation(fields: [authorId], references: [id], onDelete: Cascade)
   authorId String @db.ObjectId
}

model User {
   id    String @id @default(auto()) @map("_id") @db.ObjectId
   posts Post[]
}

Environment & setup

OS: Windows 11
Database: MongoDB
Node.js version: v20.10.0

Prisma Version
Environment variables loaded from .env
prisma                  : 5.10.2
@prisma/client          : 5.10.2
Computed binaryTarget   : windows
Operating System        : win32
Architecture            : x64
Node.js                 : v20.10.0
Query Engine (Node-API) : libquery-engine 5a9203d0590c951969e85a7d07215503f4672eb9 (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 5a9203d0590c951969e85a7d07215503f4672eb9 (at<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.10.0-34.5a9203d0590c951969e85a7d07215503f4672eb9
Default Engines Hash    : 5a9203d0590c951969e85a7d07215503f4672eb9
Studio                  : 0.499.

Hey @milindgoel15, I can confirm what you're seeing as a bug, this is due to an issue in engines where we were using the incorrect set of referential actions specifically for completions offered by the extension.
There's a fix in review :)


Game doesn't render loading chunks while primal magick

Hello I'm using primal magick 3.2.1 and get it error from immersive engineering about affinities https://pastebin.com/chmyxHqs is the pastebin for the error

seems like removing primal magick fixes the issue

If I'm understanding your bug report correctly, it sounds like this is a duplicate of another bug, the one that causes lag spikes when getting affinity values when certain item-heavy mods are installed.  This should be fixed in the upcoming 1.20.1 release.  Should you continue to encounter it, please file a new ticket.  Thanks!


Update to 1.21 Please

Thank you 🥳

Could you release please the Fabric version as well 😊

Any update on this @PaintNinja? 😄

Many thanks! 😊


Traceback when launching app contains error with itsdangerous

I followed the instructions pretty carefully, but when launching the app and visiting the site I get
kithara_base_1  | ERROR:    Exception in ASGI application
kithara_base_1  | Traceback (most recent call last):
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/http/httptools_impl.py", line 371, in run_asgi
kithara_base_1  |     result = await app(self.scope, self.receive, self.send)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 59, in call
kithara_base_1  |     return await self.app(scope, receive, send)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/fastapi/applications.py", line 199, in call
kithara_base_1  |     await super().call(scope, receive, send)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/starlette/applications.py", line 111, in call
kithara_base_1  |     await self.middleware_stack(scope, receive, send)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 181, in call
kithara_base_1  |     raise exc from None
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 159, in call
kithara_base_1  |     await self.app(scope, receive, _send)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/starlette/middleware/sessions.py", line 42, in call
kithara_base_1  |     data = self.signer.unsign(data, max_age=self.max_age)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/itsdangerous/timed.py", line 110, in unsign
kithara_base_1  |     raise sig_error
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/itsdangerous/timed.py", line 95, in unsign
kithara_base_1  |     result = super().unsign(signed_value)
kithara_base_1  |   File "/usr/local/lib/python3.9/site-packages/itsdangerous/signer.py", line 240, in unsign
kithara_base_1  |     raise BadSignature(f"No {self.sep!r} found in value")
kithara_base_1  | itsdangerous.exc.BadSignature: No b'.' found in value

Thank @jlerman44 !
Can you send me your installed packages list? I will check it out.
pip list

Also what version of python are you using?
Are you running this on Mac or Linux? and what OS/Version?

Hi dudil,
I have a Mac OS X 11.4 host, but running docker with Linux python:3.9-rc-slim inside.
Package                  Version

aiofiles                 0.7.0
anyio                    3.1.0
argon2-cffi              20.1.0
asgiref                  3.3.4
async-generator          1.10
attrs                    21.2.0
azure-core               1.14.0
azure-storage-file-share 12.2.0
Babel                    2.9.1
backcall                 0.2.0
bleach                   3.3.0
certifi                  2021.5.30
cffi                     1.14.5
chardet                  3.0.4
click                    8.0.1
cryptography             3.4.7
decorator                5.0.9
defusedxml               0.7.1
ecdsa                    0.14.1
entrypoints              0.3
fastapi                  0.63.0
fastapi-msal             0.1.5
gunicorn                 19.9.0
h11                      0.12.0
httptools                0.2.0
idna                     2.8
iniconfig                1.1.1
ipykernel                5.5.5
ipython                  7.24.1
ipython-genutils         0.2.0
isodate                  0.6.0
itsdangerous             2.0.1
jedi                     0.18.0
Jinja2                   3.0.1
json5                    0.9.5
jsonschema               3.2.0
jupyter-client           6.1.12
jupyter-core             4.7.1
jupyter-server           1.8.0
jupyterlab               3.0.16
jupyterlab-pygments      0.1.2
jupyterlab-server        2.6.0
MarkupSafe               2.0.1
matplotlib-inline        0.1.2
mistune                  0.8.4
msal                     1.12.0
msrest                   0.6.21
nbclassic                0.3.1
nbclient                 0.5.3
nbconvert                6.0.7
nbformat                 5.1.3
nest-asyncio             1.5.1
nose                     1.3.7
notebook                 6.4.0
numpy                    1.20.3
oauthlib                 3.1.1
packaging                20.9
pandas                   1.2.4
pandocfilters            1.4.3
parso                    0.8.2
pexpect                  4.8.0
pickleshare              0.7.5
pip                      21.1.2
pluggy                   0.13.1
prometheus-client        0.11.0
prompt-toolkit           3.0.18
ptyprocess               0.7.0
py                       1.10.0
pyasn1                   0.4.8
pycparser                2.20
pydantic                 1.8.2
Pygments                 2.9.0
PyJWT                    1.7.1
pyparsing                2.4.7
pyrsistent               0.17.3
pytest                   6.1.0
python-dateutil          2.8.1
python-dotenv            0.17.1
python-jose              3.2.0
python-multipart         0.0.5
pytz                     2021.1
PyYAML                   5.4.1
pyzmq                    22.1.0
requests                 2.21.0
requests-oauthlib        1.3.0
rsa                      4.7.2
Send2Trash               1.5.0
setuptools               50.3.0
six                      1.16.0
sniffio                  1.2.0
starlette                0.13.6
terminado                0.10.0
testpath                 0.5.0
toml                     0.10.2
tornado                  6.1
traitlets                5.0.5
typing-extensions        <IP_ADDRESS>
urllib3                  1.24.3
uuid                     1.30
uvicorn                  0.14.0
uvloop                   0.15.2
validate-email           1.3
watchgod                 0.7
wcwidth                  0.2.5
webencodings             0.5.1
websocket-client         1.0.1
websockets               9.1
Werkzeug                 1.0.1
wheel                    0.35.1
xlrd                     1.2.0
XlsxWriter               1.3.3

By the way, I came from https://github.com/tiangolo/fastapi/issues/754#issuecomment-808705933 where you eloquently described the problem with session data not being persistent to followup calls....  I'm excited for your project here :)

Since you mentioned that you were taking the example as is - I do hope that on the following line you did changed the secret:
app.add_middleware(SessionMiddleware, secret_key="SOME_SSH_KEY_ONLY_YOU_KNOW")  # replace with your own!!!

Anyway - can you try maybe a different secret? I suspect this might be the root cause of the exception.

fastapi_app:app is the code from your README. I removed one stray ")" going from:

Thanks! I Will fix that 😊

By the way, I came from tiangolo/fastapi#754 (comment) where you eloquently described the problem with session data not being persistent to followup calls.... I'm excited for your project here :)

Thank you for that, and your help here is very much appreciated!
This version includes a nice workaround to this issue by using both the fastapi approach of session cookie and msal approach of local datastore.
You remind me that I need to add a support for external cache datastore.... 😅

It works!  I am not sure what I changed, but now I am on a PC using docker. I'll check again later and get back to you. I also had to set a redirect URL in my Azure App Registration to "/docs/oauth2-redirect".

Great - happy to hear that.
I'm closing the ticket but if you find the source of it or have any other insights, feel free to reopen it.
Thanks!

@dudil , Still failing on Mac OS X 11.4. Can we reopen for that purpose?

Never-mind!  I just had to clear my browser cache.. Silly me.


README: Add how to get a Team Drive Root Node ID

This follows #319 and contains quick instructions to get a Team Drive's Root-Node-ID

@herver Thank you! It works.

Thanks for spotting the typo :+1: , I've fixed it as you suggested

HI, how i can install this new functionallity?
in the release page doesnt appear

@hardlick There is no new release, you'll have to compile yourself with golang:
go get -d -u github.com/dweidenfeld/plexdrive

Then install the binary from your $GOPATH/bin directory.
Currently go 1.13 is untested, so I'd recommend sticking to go 1.12.

@hardlick There is no new release, you'll have to compile yourself with golang:
go get -d -u github.com/dweidenfeld/plexdrive

Then install the binary from your $GOPATH/bin directory.
Currently go 1.13 is untested, so I'd recommend sticking to go 1.12.

Not that plexdrive needs much active development at this moment, granted there's always convience level features that could be added, should we just be forking like madmen if we are planning to make any significant changes? Or are you still planning to be active/involved enough to accept PRs?
I feel as if there's 5 different forks currently that have implemented a new feature or made an attempt at doing so and then only some of those actually made the effort to send a PR.

I can merge PRs, if the tests are green and they have at least one review.
That said I'm not a go programmer, so I'm somewhat limited in the changes I can make and review.
I'm also rather busy, so responses can be slow.
I don't think there's a need for forks, we just need one or more active maintainers on this repo and @dweidenfeld would probably be happy do help out with the necessary permissions.
I think if the problems with the Team Drive support are ironed out, it makes sense to make a new release.


Is the FCM_VERSION variable still required?

I'm doing cloud builds using volt.build and after a long absence I'm getting back to some projects. In the past there were issues with the FCM_VERSION and we had to specify (see below), is this still necessary and, if so, what are the new desired settings?
<plugin name="@havesource/cordova-plugin-push" spec="3.0.1">
      <variable name="SENDER_ID" value="xxxxxxxxxx" />
      <variable name="FCM_VERSION" value="18.+" />
  </plugin>

BTW the cloud build docs are really outdated need updating as phonegap and intelXDK are long since dead. I'm sure if you reached out to the guys at volt.build they'd give you what you need for theirs (although with everything else its pretty much the same as a local build).

Looking in the plugin.xml, the FCM_VERSION still controls the version of com.google.firebase:firebase-messaging that is used.  So, I'd say, yes it is still needed.

Thanks Jim!
The guys over at volt.build checked their logs for me and found most builds are using 23+ so I set mine to that.
Now to get a good Android build.


Add an example project using Parcel JS

Problem
https://parceljs.org/ can be used to build / package a Yew-based webapp but we don't have an example for doing so yet
Solution
Review https://github.com/spielrs/yew-parcel-template and possibly move / fork it under the yewstack org

I believe that @dancespiele has some working code using parcel (https://gitter.im/yewframework/Lobby?at=5db2102fa3f0b17849820526)
I don't know the state that their code is in (eg. public, private, public but modified to the point its not usable in a minimal example), but they might have something that could be pared down to a minimal example.
https://github.com/rustwasm/rust-parcel-template Would also be a logical place to start.

Thanks @hgzimmerman! I created this issue before realizing that they already created the template: https://github.com/spielrs/yew-parcel-template

@jstarry I think already you have seen my template based in https://github.com/rustwasm/rust-parcel-template . I'm worry how the restricted is Apache license, I don't know a lot about it. Maybe I can create another repository which is not based in that rust-parcel-template with only MIT license. What do you think?

INAL, but https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952/2 provides a quick overview for the use of the dual license within rust, and by extension, the broader community building on top of rust.
In short, MIT + clause about patent infringement  == Apache 2.0; AFAIK.
No one stands to lose anything by dual-licensing w/ Apache, as if someone is involved in a patent dispute, they can still use the software under MIT. Yew doesn't have any patents, and I don't think the creators of the templates are using any patents in their templates - I think the Apache 2.0 license inclusion is strictly just for maximizing license compatibility with libraries in the ecosystem.

I think you are free to remove the Apache license should you choose to (because you, as someone deriving something from their software are free to either or both MIT, or Apache), but since it doesn't really bind the users of your software to anything more than MIT, I don't see why you would want to remove it.

ok thanks for the information then I will keep the dual license

Since Trunk seems to be the way forward for Yew and the popularity of wasm-bindgen has given rise to plenty of tutorials and examples on the subject already, I don't think we still need this today.


Set up Conditional ember-source Import for CLI 2.11

Radical needs to be able to check which version of CLI a consuming app is running and determine whether to import Ember from Bower or NPM, to ensure compatibility with the latest release of CLI and older releases going forward.
We can use the same method we used for fountainhead

Done-zo


Fix   that breaks links

All the #foo links on https://ipfs.io/docs/commands/ are broken.  Pretty sure this will fix it, but I can't easily test.

i dont think so, i think this only affects the /docs page, not the /docs/commands page.
also the baseUrls are there because of styles.

On 09/17/2015 11:04 PM, Juan Benet wrote:

i dont think so, i think this only affects the |/docs| page, not the
|/docs/commands| page.
also the baseUrls are there because of styles.
—
Reply to this email directly or view it on GitHub
https://github.com/ipfs/website/pull/55#issuecomment-141354057.

Ah, well the broken part is:
https://ipfs.io/docs/commands/
Has:

Which changes every https://ipfs.io/docs/commands/#ipfs-add command into
https://ipfs.io/#ipfs-add.
So every link to a command is broken.

I understand. Just that we cannot change the baseUrl without also changing all the other links. Maybe easier to make sure the # links include /docs/commands first

That's easy.  I wasn't sure if the binary that makes that file had other uses that would break if we start assuming that the binary is always run from docs/commands.

we should either (a) run a script here to fix the links, or (b) make the metalsmith code fix the links in the markdown (find/replace)

I just ran a script in #58. Seemed easier. Not sure if permanent? Opening dual PR now in go-ipfs.
This PR is also related to #35.
@spikebike This should be easy to test. Run make and then check out localhost:8081. If that isn't working, let me know.

Closing this as it doesn't fix the issue.


IoT security

Work in progress
connects to #38

Hi @JohnPWSharp, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

Connects to #163


Update README.md

Fixes https://github.com/ML-KULeuven/dtaianomaly/issues/53

Thanks for the addition! You can also add yourself to contributors.md.


Continue recognitionStream ?

Great implementation, very instructive :-)
I'm wondering what would be the best implementation to keep speech recognition after a first hotword, which is mostly the case on a conversationnal boot, user won't say everytime the hotword, dosen't make sense.
The problem there is that sonus  trigger the intent processing after the final-result emitted at the end of recognitionStream, so we need a way to manualy trigger the hotword in order to avoid a painfull UX.
Maybe a const detector > sonus.detector ?

Dupe of #18


Wrong instruction when running python runner.py -- --data_path=$EMBEDDINGS

Hi,
In my experiments that middle empty '--' basically tells the flags parser to ignore everything that comes after, including the important data_path definition.
The result will be failing due default 'None' data_path defined in the config file.
Guy

Thank you for spotting the error. Apparently interactive python (which I have aliased to python) requires these double dash.


implement missing languages

As always, some languages are missing.
I don't know how many languages missing but it seems like Mangadex added a bunch recently.
The Plan:
1- List all Mangadex supported languages:
Should be easy:

Just go to the mangadex.org,
click to user icon at the top right
go to chapter languages
list them all

2- Implement them :
Mangadex uses the ISO 639-1 standard.
All "currently" supported languages is here : mangadex-api-types::language::Language

List of existing languages

[ ] English
[ ] Albanian
[ ] Arabic
[ ] Azerbaijani
[ ] Bengali
[ ] Bulgarian
[ ] Burmese
[ ] Catalan
[ ] Chinese (Simplified)
[ ] Chinese (Traditional)
[ ] Croatian
[ ] Czech
[ ] Danish
[ ] Dutch
[ ] Esperanto
[ ] Estonian
[ ] Filipino
[ ] Finnish
[ ] French
[ ] Georgian
[ ] German
[ ] Greek
[ ] Hebrew
[ ] Hindi
[ ] Hungarian
[ ] Indonesian
[ ] Italian
[ ] Japanese
[ ] Kazakh
[ ] Korean
[ ] Latin
[ ] Lithuanian
[ ] Malay
[ ] Mongolian
[ ] Nepali
[ ] Norwegian
[ ] Persian
[ ] Polish
[ ] Portuguese
[ ] Portuguese (Brasil)
[ ] Romanian
[ ] Russian
[ ] Serbian
[ ] Slovak
[ ] Spanish
[ ] Spanish LATAM
[ ] Swedish
[ ] Tamil
[ ] Telugu
[ ] Thai
[ ] Turkish
[ ] Ukrainian
[ ] Vietnamese


Consult the first phase.

The code is written very well, but I noticed that Label was just input data in the first stage(applications/DeepSpeed-Chat/training/step1_supervised_finetuning/main.py), but I didn't find the code for adding Label for a long time. It was strange. When creating DataSet, there was only input and mask. DataLoader also found it for a long time. Find the code to add Label

Hi @csxrzhang - can you explain more on your issue?  Are you still looking for code or would you like to make a PR if you have a code improvement/suggestion?

Hi @csxrzhang - closing this issue as stale for now.


Update tutorial-virtual-network.md

Add some clarifying text introducing the list of default rules that are applied to a Network Security Group (NSG) when it is created.
When reading this, I was confused at first about what information this list was showing.

@boykoc : Thanks for your contribution to the Azure documentation! The author, @neilpeterson, has been notified to review your proposed change.

#sign-off


Hunger Calculations fail after eating large amounts of food items

Environment
Minecraft Version: 1.12.2
Forge Version: <IP_ADDRESS>60
Mod Version 1.0.3
Describe the bug
After eating a large number of food items (independent of how much hunger each item restores) you will eventually come down to 1 hunger point on your hunger bar, but unlike all the other times you've reached 1 hunger point you'll stop regenerating HP completely and won't be able to eat any food to recover any lost HP.
Log File
Latest.log: https://mclo.gs/RxUhgcj
Screenshots

I'm unable to eat the persimmon in my main hand despite clearly being hurt and playing on Hard difficulty with 1 hunger point remaining
Final Notes
In addition to fixing this bug, add a config option that allows the player to eat food even if they have hunger left, removing the ability to eat until you're completely out of food defeats the whole purpose of the hunger bar in the first place. Even versions of Minecraft that used food to directly restore health let you use food items even if you weren't at zero health (because obviously that would defeat the entire purpose of having a health bar in the first place now wouldn't it?) Restarting the world doesn't fix this issue.

@OpenSauce04 Please look into this issue. I want to use your mod but as long as this bug exists I simply can't until it gets fixed.

Hey, sorry I missed your report until now! I'm busy today, but I will investigate your report tomorrow
Thanks for bringing this to my attention, and I will look into adding the config option :)

I couldn't recreate this issue, I sat in a creative world with poison and stacks of food for a long time and it just didn't happen. I am however going to add the config option to allow you to always eat food. I hope this helps you out

@Delfite 1.0.4 has released, read the patch notes for more detailed info

@Delfite Update 1.1.0 has been released; Please check the patch notes for more detailed information

Thanks a bunch for this patch. Even if it's just a config option it's still massively helpful to have now. Though don't think I'm done with you yet on suggestions...


[curl] update to 7.61.0

Is the hash correct? I am getting a hash mismatch error.

@pravic Please remove Patch 0005_winssl_http2.patch , cURL fixed see https://github.com/curl/curl/issues/2591
Pull 3616

@alexkaratarakis It was invalid.
@fcharlie Thanks, I've made the requested changes.

Thanks for the PR!


refactor: Only set GlobalObjectId if it's not set

This change is not yet ready, and I don't want it solved this way.


Improve history event view for activity with retry that is started

This will reduce the confusion like https://github.com/uber/cadence/issues/3802
We already have the
Option 1: Append dummy activity started event in history for activity with retry that is started
Option 2: Do something like CLI to show the started activities at the end of the history.
============Pending activities============
[
  {
    "ActivityID": "0",
    "ActivityType": {
      "name": "main.batchProcessingActivity"
    },
    "State": "STARTED",
    "LastStartedTimestamp": "2020-10-11T22:47:16-07:00",
    "LastHeartbeatTimestamp": "2020-10-11T22:47:16-07:00",
    "Attempt": 0,
    "MaximumAttempts": 15,
    "ExpirationTimestamp": "2020-10-11T22:47:36-07:00"
  }
]
NOT

We are proposing a new feature to create a pending tab with a pending activities button at the bottom of history which will take users to the pending tab that will show all pending activites, decisions, children, and potentially timers in the future.

Closing this since it was implemented


Azure data warehouse support - Ticket resolution w Microsoft (ref. EDW - ADF usage)

Describe the issue
Azure Data Factory service support ticket with Microsoft to help either fix their service or provide an workaround internal to Azure
TLDR: Azure Data Factory is an ETL/Job Runner, a data transfer and transformation service to ship data from one place to another.
Additional context
The Azure Data Factory service has a s/w module that helps client reach their internal data\DB sources via standard networking back to their on-prem data center resources.  In many cases the purpose for this is to create periodic 'jobs' that capture real-time data sources\live data, transform it according job rules through the IR coordinated process and output the results to a repo or location where further, possibly BI-type processes, analysis is done (into Azure Databrickes for example) and\or stored\streamed to somewhere for final reporting (frontend web app, PowerBI, etc.)
In our case our Gov Azure infrastructure (Test\Dev\PoC\Non-prod) by default restricts direct Internet use from inside Azure (internal networking and inter-service private links only) - Equivalent in principal to on-prem zone B.  All Internet and IP-based resources having destinations outside of our Gov Azure managed infrastructure get routed automatically down to on-premise - whereby internal traffic is re-routed to its local destination (if fw rules there allow it) and, unless otherwise allowed by proxy, external Internal calls are ignored.
To process these normally ignored Azure VM Internet calls and allow them through in the future will take the use of either direct Azure-based direct-to-Internet routing set up (whereby they can be captured by MS and re-routed to service internally, or force traffic to outbound to Internet on-prem.  There are several difficulties to using on-prem as the outbound point and the use of a proxy there so a workaround with Microsoft is seen as the optimal option for standardized Azure Service calls back to their internal service endpoint.
In the context here, we either find a re-route solution with Microsoft as the simplest method, or we'll have to consider creating an on-prem proxy solution for these standard Cloud Services outbound calls.  We could consider as well using the on-prem F5 Forward Proxy for this Azure traffic but the service is whitelist based and would require client knowledge of all Azure service possible outbound calls beforehand, and constant inquiries\tickets with CPF.  This would require extensive testing and knowledge by Ministry client, ending in long inexact iStore orders every time, which CPF would like to avoid if at all possible for it clients.
Service issue involved here is with Azure Data Factory - Self Hosted IR (Integrated Runtime) - SHIR
and although configured to communicate internally, it is still making internal IR function calls to external Servicebus endpoints.
Definition of done

Azure Data Factory is viewed as a key cloud service that enables easy transformation\estraction\manipulation of data sets and therefore will likely be commonly used, so understanding and fixing this ADF issue is the goal for this ticket
Work with Microsoft Support specialists to help fix the issue or find a workaround so this service will be functional for clients in the future
Confirm fix or workaround
Test with last group that had problems with this Azure Service if possible - EDW specialist (if available), and\or review with TRAN Enterprise Architecture

On hold - Waiting for MS to confirm which UDR forced routing rules are being triggered and\or if there is a more optimal configuration.  Once we know this then question is why there is no response to the SH-IR 'Interactive Authoring' public URL calls from the Azure VM (left on) or why it is not responding.  Will put in Blocked until I get word back from them on this

Unblocked now as MS has a specialist that will do packet tracing to analyze routing traffic, and where the DataFactory ServiceBus calls (URL based) are going and why there is no response from the service.

Met with MS again a couple times and currently doing some troubleshooting back and forth.  Waiting on MS currently for latest config changes to implement for testing

Jon has reengaged with the team to try prove out the network connectivity

Jon says Tran turned away from this work for now.  Please put on pause until we get caught up on other tickets and then we can refine as another ticket in future refinement/roadmapping.
There is a ticket on the Microsoft side and Jon says he'll shut this down.  We agree to "close" this by putting it back in New Items as a reminder to review it later.

Tie off meeting was completed with Microsoft support and TRAN present.  The specific internal DataFactory service trying still to connect to the Internet was not able to be identified (to create a specific UDR [forced route rule]).  We could also not implement the MS solution suggested due to restrictions on internal servers not allowed to make general calls to the Internet.  It was also found that the additional suggestion of setting the rule to apply solely to the TRAN subnet was not possible.  So, only a proxy solution would be a workable alternative, which we do not have currently available.  This was clarified with TRAN and that they could work get on-prem data extracted with how the IR tool functioned still but not with the full functionality in the meantime.

old ticket, closing


Increase in 504 timeouts from source envoy since 1.3.x upgrade

Bug description
Following on from what I raised on the test and release call today, we're approximately 3 days into 1.3.x. and we've noticed an increased in upstream timeouts from the perspective of the source envoy, with a 504 response_code and a UT response_flag.
This graph shows from the source:

However there are no timeouts reported at the destination:

We aren't seeing any issues in the destination application logs, only the source application logs which show connection timeouts.
I'm still investigating and trying to gather more information, but felt this is now more than a coincidence so I'm raising the issue here to track.  We alert on such failures so it isn't that I'm now just seeing them as I'm looking more closely, they are firing alerts that weren't firing before so the issue wasn't there.
I've decided to roll back to a 1.2.6 proxy on some of the higher throughput (and higher 504 rate) applications, and will monitor them over the next 12-24 hours and report back here.
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
No 504s when the upstream isn't timing out
Steps to reproduce the bug
Unsure as of yet, only seeing so far on 1.3.1
Version (include the output of istioctl version --remote and kubectl version)
1.3.1
How was Istio installed?
Helm
Environment where bug was observed (cloud vendor, OS, etc)
GKE
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

@yxue can you take a look?

Just to confirm we're seeing similar issues across multiple isolated clusters within the same GCP region, and in some occasions spikes are at identical times.
This is now leading me more towards there being some underlying network issue that's happened to start at the same time as our istio upgrade, and I'm trying to get Google to investigate further (albeit not having much joy).
It's proving extremely difficult to pin point at the point in time but will update as and when I have more information.

Google have finally accepted they've got small amounts of packet loss between VM's in europe-west4, this started at the same time we pushed istio 1.3.0 through those environments.  At this point in time I'm relatively confident this is NOT actually an istio problem, but will confirm (and close) as I find out more in the coming days.

Ummm, yay?
Thanks @Stono for finding the needle in the haystack.

Ummm, yay?

@duderino conflicted feelings? ;)

Exactly ;)

Hey @Stono  we've just deployed  1.3.1 from 1.1.7 two days ago and we saw an increase in our 5xx errors - especially the  random 'DC' ones.. The percentage is still low, but is happening too much frequently and its making us want  to go back to  1.2.x versions.
Are you back on 1.3.x versions again?

Stocco I rolled one cluster back to 1.2.6 and saw the same issues, hence why I believe it to be the GCP packet loss.

OK so Google are still having this issue and I'm confident that it's the source of my issues however, I've noticed that despite retry policies being in place, istio is not retrying the timeouts despite being configured to do so, as a result our apps aren't as tolerant as they should be.
https://github.com/istio/istio/issues/17613#issuecomment-538457757

Thanks for verifying this isn't an Istio issue. Looks like we are tracking the timeout issue in https://github.com/istio/istio/issues/17613 so I'll close this


Mark requests as nullable and expose FC server

The helper function used to fetch data from Lodestone would return null if a 404 is returned, so it is more accurate to mark these as nullable.
I also exposed the Server property as World for FCs.

Thank you, looks good!


refactor to run long processes in background

Long processes :

get ppn
get unimarc records
should be
start a goroutine for it
return to /ts/{myts}
send info through a channel about where it's at in the process
send report when it closes

done with commit d41ec8b7f2aeb197f96a443eac9d9a5b87fd1ae1


Validate problem

I've been trying to validate the RealESRGAN training by uncommenting the lines that are commented and adding the paths for the validation part of the dataset. However, when I execute the training, it says that "801.png" (the image that is part of the validation) is not in the path list. I saw that the validation requires a paired image dataset, so I created a meta_info file using the generate_meta_info_pairdata.py script for the LR and HR images of the validation, but it still says the same.
The question is, in the training.md file, they don't specify if all the images need to be in the meta_info text file that needs to be created. So, in order to validate, what exactly needs to be in the meta_info file? Additionally, can someone share their meta_info file where the validation works?
Thanks.

Hey, were you able to resolve this? I'm facing the same issue where my validation files (2 images) are not getting saved in the logger even though they have the same name and I have tried adding in meta_info file to match them as well. No matter what I do validation pictures do not show up in my visualization folder or shows up on my training logger.

Hello,
In the end, I gave up and created a script myself to calculate the metrics.

Hey Jhoe, could you explain to me how you created the script and how you integrated it with the config file to use it for validation during finetuning/training? If you don't mind could you share the script or the repo with me?


Adds react-redux-starter-kit to examples

This boilerplate is still a work in progress but is currently functional. I'm actively working on it and am focused on keeping it up to date with the latest Redux and React Router API changes so people can get an idea of how to use both.

Great job.


SkipGram fails on embedding a protein-protein interaction file

I created a new branch called link_prediction_ppi in which I am testing graph embedding and link prediction on protein-protein interaction graph. In the first step, I just tried to embed the training graph with SkipGram. The algorithm fails, while it successfully run on karate.train graph.
The error is:

Traceback (most recent call last):
File "/Users/ravanv/PycharmProjects/N2V/runLinkPrediction_ppi.py", line 52, in
model.train(display_step=2)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 414, in train
batch_x, batch_y = self.next_batch_from_list_of_lists(walkcount, self.num_skips, self.skip_window)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 377, in next_batch_from_list_of_lists
current_batch, current_labels = self.next_batch(sentence, batch_count, num_skips, skip_window)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 341, in next_batch
batch[i * num_skips + j] = buffer[skip_window]
ValueError: invalid literal for int() with base 10: 'ENSP00000264028'

Does anyone know what cases this issue? In karate.train, nodes are integers, but in ppi graph, nodes are ensembl ids likeENSP00000264028. Do you think it might have caused the error?
Thank you.

The error message that you listed does seem to suggest that the problem is that an integer is expected, but it's getting passed a string. Can you try it with the same graph, but first map the string labels to integers?

Thank you, Tiffany. Ok. I will map string labels to integers. But, I thought the type of data does not matter for SkipGram.

@vidarmehr - Great question! So, the current version of SkipGram does expect the data to be input as integers.
That said, I think text_encoder.py() is currently intended to be used for free-text input, but I don't see why it could not be extended to also handle paths with labels. Perhaps that is something worth talking about further on Thursday during our paired session.

@callahantiff Thank you very much for your explanations, Tiffany! Yes. We should extend SkipGram to encode text data, too.
I mapped the string data to int. But, now I get another error.

Traceback (most recent call last):
File "/Users/ravanv/PycharmProjects/N2V/runLinkPrediction_ppi.py", line 54, in
model.train(display_step=10000)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 417, in train
self.run_optimization(batch_x, batch_y)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 391, in run_optimization
emb = self.get_embedding(x)
File "/Users/ravanv/PycharmProjects/N2V/xn2v/word2vec.py", line 273, in get_embedding
x_embed = tf.nn.embedding_lookup(self.embedding, x)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/embedding_ops.py", line 364, in embedding_lookup_v2
return embedding_lookup(params, ids, "div", name, max_norm=max_norm)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/embedding_ops.py", line 317, in embedding_lookup
transform_fn=None)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/embedding_ops.py", line 135, in _embedding_lookup_and_transform
array_ops.gather(params[0], ids, name=name), ids, max_norm)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/util/dispatch.py", line 180, in wrapper
return target(*args, **kwargs)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/array_ops.py", line 3965, in gather
return params.sparse_read(indices, name=name)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/resource_variable_ops.py", line 640, in sparse_read
self._handle, indices, dtype=self._dtype, name=name)
File "/Users/ravanv/anaconda3/envs/N2V/lib/python3.7/site-packages/tensorflow_core/python/ops/gen_resource_variable_ops.py", line 670, in resource_gather
_six.raise_from(_core._status_to_exception(e.code, message), None)
File "", line 3, in raise_from
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[0] = 3621 is not in [0, 21) [Op:ResourceGather] name: embedding_lookup/

Do you know what causes this error? Thank you.

No problem! Happy to take a look. How big is the data file? Can you upload it to this issue so I can play with it? Can you also include here the lines of code you are running when you get this error?
I have seen this error before, but I want to make sure that I can reproduce it! 😄

@callahantiff Thanks a lot, Tiffany! Please go to the branch "link_prediction_ppi". The code is runLinkPrediction_ppi.py and the file is "pos_train_edges" which has been uploaded.
At this time, I just try to embed the  nodes in "pos_train_edges" file using SkipGram model.

@vidarmehr - Perfect, thanks for the details! I will be able to take a close look this evening and will send some updates then.

@callahantiff I solved the issue, Tiffany! Sorry. I had made a mistake in the first parameter of SkipGram. I am going to check in the code and close this issue. Thanks again for your helps.

Nice catch @vidarmehr!

PS. let's add some more Q/C code to the constructors. Users should get an error message like" Parameter 1 needs to be apples but you passed oranges" and not a stack trace.
I would recommend we have code like this
if not isinstance(param1, apple):
   raise TypeError(" Parameter 1 needs to be apples but you passed oranges")

we should do this for all of the parameters!

Are these parameters for the CLI? If so please check out https://click.palletsprojects.com/en/7.x/
Click will do this for you. No need to manually write it all.

Second that, click is pretty handy

PS. let's add some more Q/C code to the constructors. Users should get an error message like" Parameter 1 needs to be apples but you passed oranges" and not a stack trace.
I would recommend we have code like this
if not isinstance(param1, apple):
   raise TypeError(" Parameter 1 needs to be apples but you passed oranges")

we should do this for all of the parameters!

I added Q/C code to the constructors to check the first parameter of the SkipGram. Please check the word2vec.py in link_prediction_ppi branch.

Are these parameters for the CLI? If so please check out https://click.palletsprojects.com/en/7.x/
Click will do this for you. No need to manually write it all.

Thanks, Mike! The parameters are not for the CLI. At this time, I just followed what Peter suggested.

Might be worth linking them up anyways and having defaults. But whatever works!

Might be worth linking them up anyways and having defaults. But whatever works!

Ok. Thanks, Mike!

@pnrobinson Could you please let me know if we can close this issue? Thank you.

I think we can close. We will need click etc primarily for the driver scripts but not for the library itself.


fix spec

Closing this out - changes are reflected in this PR https://github.com/retirable/unit-ruby/pull/21