Require time plugin first draft

Codecov Report

Merging #22 (6a1aef9) into main (9ef71dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        28    +3
  Lines          462       528   +66
=========================================
+ Hits           462       528   +66

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

src/plugins/code-duplication/cmd.js
100.00% <100.00%> (ø)

src/plugins/require-time/cmd.js
100.00% <100.00%> (ø)

src/plugins/require-time/loadDep.js
100.00% <100.00%> (ø)

src/plugins/require-time/reporters/text.js
100.00% <100.00%> (ø)

src/plugins/utils.js
100.00% <100.00%> (ø)

src/utils.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef71dd...6a1aef9. Read the comment docs.

Codecov Report

Merging #22 (6a1aef9) into main (9ef71dd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        28    +3
  Lines          462       528   +66
=========================================
+ Hits           462       528   +66

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

src/plugins/code-duplication/cmd.js
100.00% <100.00%> (ø)

src/plugins/require-time/cmd.js
100.00% <100.00%> (ø)

src/plugins/require-time/loadDep.js
100.00% <100.00%> (ø)

src/plugins/require-time/reporters/text.js
100.00% <100.00%> (ø)

src/plugins/utils.js
100.00% <100.00%> (ø)

src/utils.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef71dd...6a1aef9. Read the comment docs.


Create scripts to setup the elixir-omg project

:clipboard: PLAN-244
As a developer of elixir-omg, I have easy set up scripts for my development environment, So that I can get started quickly

From the root of the elixir-omg directory: docker-compose -f docker-compose-full-services-mac.yml up will start everything for you. If there's something that needs to be improved please let me know :)


setBoundParameter doesn't support string

In the readme we've got examples like this:
Lodata::add((new class('identity') extends Operation implements FunctionInterface {
    public function invoke(String_ $code): String_
    {
      return $code;
    }
})->setBoundParameter('code');

But this doesn't work for me, the parameter PipeInterface or null:
https://github.com/flat3/lodata/blob/f7c2760d1c7e532b6d995284cc6b1ecb5158b14d/src/Operation.php#L224-L239

Ah apologies that's another documentation glitch, the example is wrong and the method should be setBindingParameterName.

Fixed the documentation issue in https://github.com/flat3/lodata/commit/b16352927c1999f490645ffa99af679546164d73


🐛 Bug Report: Session duration not saved

Reproduction steps
I change the session duration in the application configuration menu (eg. to 120) and save and it says "Application configuration updated successfully".
Expected behavior
It should keep the new value.
Actual Behavior
It keeps the default value (60).

Thanks, this should be fixed in v0.2.1.


Add Goland Datadog Agent Dev Container configurations.

What does this PR do?

Add Goland run configurations for the Datadog Agent Dev Container.

Run linter: Runs invoke lint-go on the whole codebase.
Run unit tests: Runs invoke test on the whole codebase.
Run development container: Runs a Dev Container that will sleep indefinitely. You can then exec into it and run any command you might need.

Motivation

The current Jetbrains implementation of Dev Containers is still pretty rough with degraded performance and running in an EAP version of Goland.
Those configurations improves development process if you do not want to rely on Jetbrains' default mechanism of Dev Containers.
Additional Notes

You will need the latest version of the Datadog Agent Dev Container.
Note that Jetbrains also allow you to run Dev Containers the same way VS Code does (https://www.jetbrains.com/help/idea/connect-to-devcontainer.html). Although it does come with a few limitations.
Possible Drawbacks / Trade-offs

No drawbacks.
Describe how to test/QA your changes

No QA.
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[x] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[x] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[x] If applicable, the need-change/operator and need-change/helm labels have been applied.
[x] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[x] If applicable, the config template has been updated.

/merge


Add a option to play at VLC

Would be nice if had a way to watch what i want at VLC or other video players...

I'm closing this as a duplicate of #624.


Prices shipment line items when shipment is delivered [delivers #161269448]

Description
We recently decided that pre-approval requests should have their pricing calculated when a shipment is delivered. This is for a couple reasons: a number of the 400ng items depend on the final shipment weight, and we don't actually show invoice line items until a shipment is delivered anyway. This PR does that and more!

Prices approved pre-approval (o_0) requests when a shipment is delivered
Adds new rateengine function PricePreapprovalRequestsForShipment that iterates through a list of approved pre-approval requests for a shipment and tacks on the computed cost of that item
Adds a few new testdatagen functions, MakeCompleteShipmentLineItem, MakeTariff400ngGeoModelsForShipment, and MakeShipmentForPricing that help stand up data needed for pricing
Changes some calls to testdatagen functions to use Fetch functions that try not to duplicate records
Stands up new testdatagen file for Tariff400ngServiceArea
Adds amount_cents to shipment line item model in Swagger

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #dp3-engineering

[ ] There are no aXe warnings for UI.
[ ] This works in IE.
Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:

[ ] Communicated to @willowbl00
[ ] Added to the list of network dependencies

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

Talked with @rdhariwal and approved changes after writing a story for addressing the validation concern above.  Since these records get added only on delivery of a shipment, our risk should be minimized and approving this PR unblocks some other stories/PRs.


Add support for Basic Authentication in outbound HTTP requests

Currently Junebug supports supplying URLs for sending messages, message status updates and channel status updates to. These URLs should allow a username and password to be specified within the URL and have those converted into Basic Authentication HTTP headers when HTTP requests are made to them.
E..g<EMAIL_ADDRESS>should become a request to https://example.com/ with user and pw supplied as the basic authentication username and password.

@rudigiesler can you point me at the code that needs fixing for this? Is it in Junebug (I couldn't see where mo_url is consumed in this repo) or deeper in Vumi?
When we try to use Basic Auth in mo_url we get stuff like the following in the logs:
File "/usr/local/lib/python2.7/site-packages/idna/core.py", line 253, in check_label
5/17/2017 3:59:57 PM    raise InvalidCodepoint('Codepoint {0} at position {1} of {2} not allowed'.format(_unot(cp_value), pos+1, repr(label)))
5/17/2017 3:59:57 PMidna.core.InvalidCodepoint: Codepoint U+003A at position 8 of u'junebug:password@api' not allowed

@imsickofmaps The code that makes the http request is here: https://github.com/praekelt/junebug/blob/develop/junebug/workers.py#L282-L289 . We use treq for the request, and I'm guessing that treq doesn't support basic auth in the URL, or maybe we need to set a flag or something, we would investigate treq to see what can be done there.
If treq doesn't support it, then we need to extract the auth details from the URL, and pass the auth details and URL as separate fields to treq.

@rudigiesler properly supporting auth seems like a better solution for Junebug. Treq does support basic auth, as a param on the request: http://treq.readthedocs.io/en/latest/api.html#treq.request

@imsickofmaps In that case, we'll need to extract the basic auth details from the URL, and pass the URL and auth details as separate parameters to treq.

Implemented in #129


Zero-overhead abstraction?

I think the abstractions are great but it seems that you have to clone / allocate the frame buffer for every frame you want to encode. Is there a way that lets you reuse a buffer, or even modify the ffmpeg's internal data pointer to our existing buffer so you don't have to do any copying?
Encoder takes a VideoFrame and the freeze method of VideoFrameMut consumes/moves it which prevents me from reusing it. Is there a reason for this design?
Thank you for making the library open-source!

Hi @harrynull and thank you for your feedback.
I'm not sure what exactly is your use case but let me ensure you that cloning audio/video frames is quite cheap. FFmpeg uses reference-counted buffers internally, so cloning a frame typically won't copy any data. There used to be some edge cases because not all decoders were allocating frame buffers as reference-counted but it should be quite rare these days.
So if you're, for example, using a typical transcoding pipeline (i.e. demux -> decode -> encode -> mux), then there won't be really too much of data copying. There might be something inside the FFmpeg itself but there shouldn't be anything in our abstraction.
If you're using a pure encoding pipeline (i.e. generate a frame -> freeze -> encode -> mux), then you also don't have to copy any data. You can generate your frames using AudioFrameMut/VideoFrameMut and write the frame data directly into the frame planes. Reusing a frame for repeated encoding might not be possible because your encoder might buffer the frame internally (keep reading for more info).
The only use case that isn't properly covered is the one where you already have existing audio/image data and you need to modify the data before encoding it (e.g. a pipeline like demux -> decode -> modify -> encode -> mux). There is a mechanism for it but we've haven't implemented it for frames yet. It's a similar mechanism to what you can already find in the implementation of Packet/PacketMut (see https://docs.rs/ac-ffmpeg/0.17.4/src/ac_ffmpeg/packet.rs.html#340-355).
The reason why we have Packet/PacketMut, AudioFrame/AudioFrameMut and VideoFrame/VideoFrameMut is the same as for Bytes/BytesMut that you can find in the bytes crate. The type system ensures that there is only one copy of a mutable frame/packet. Then if you transform your frame/packet into the immutable version, you can easily create cheap copies without copying the frame/packet data. The reverse transformation from immutable to mutable is a bit tricky because there might be multiple copies of your immutable frame/packet sharing the same data. The Packet::into_mut() method implements this by copying the packet data only if there is more than one copy of the packet.
The concept of frame/packet immutability is important here because decoders, encoders and muxers can use internal queues for incoming frames/packets. If you were, for example, allowed to modify a frame after passing it to an encoder, then the encoder output would be unpredictable because you could be modifying a frame that hasn't been encoded yet.
If you'd like to implement the into_mut method also for AudioFrame and VideoFrame, feel free to open a pull request.

Thank you for your quick and detailed response!
To give some more context, my use case is screen capturing and then streaming with WebRTC (so I don't need mux from ffmpeg).

You can generate your frames using AudioFrameMut/VideoFrameMut and write the frame data directly into the frame planes.

Due to system API limitations it's not always possible to do that. d3d's Map only gives a pointer to an existing buffer.

Reusing a frame for repeated encoding might not be possible because your encoder might buffer the frame internally

I'm not super familiar with ffmpeg's implmentation so I didn't know about this behavior. I wonder if it is dependent on the specific encoder I use. I actually did some hacking and it appears to be fine to reuse the frame. Is there a way to prevent this buffering or to know if the frame is being buffered? In that case I could preallocate say 2 frames and alternately use them.
I did some quick benchmarking and it seems that

allocation of a 4K frame takes 4ms
copying takes 2ms
the actual encoding takes 4ms

We only have 16ms for the entire capture - encode - stream process to achieve 60fps, so I don't really want to afford 6ms just to allocate and copy buffer unless absolutely necessary.
I wonder if into_mut (which I guess internally call av_frame_make_writable) would help in this case (could it detect if frame is being buffered and safely reuse the frame?)

I was also looking into avcodec_alloc_frame and av_image_fill_arrays. It seems that they might be doing what I want.

We only have 16ms for the entire capture - encode - stream process to achieve 60fps, so I don't really want to afford 6ms just to allocate and copy buffer unless absolutely necessary.

I see.

the actual encoding takes 4ms

That's quite impressive. Is it H.624? I guess you must be using some really powerful HW encoder to achieve this.

I wonder if it is dependent on the specific encoder I use. (...) Is there a way to prevent this buffering or to know if the frame is being buffered?

This may depend on a lot of things. It is both codec and encoder specific and it may also depend on encoding profile, preset and and the encoding schema. There is no reliable way how to tell how deep your encoding queue is. At least not directly. It may also change with FFmpeg or driver updates. Encoders typically need to buffer a few frames if B frames are being used to improve compression ratio. But it isn't the only case.

I actually did some hacking and it appears to be fine to reuse the frame.

I wouldn't count on that.

I wonder if into_mut (which I guess internally call av_frame_make_writable) would help in this case (could it detect if frame is being buffered and safely reuse the frame?)

That's precisely the purpose of this method. Or at least partially. The method would be useless if the encoder have buffered any frames. In such case, the method would end up allocating a new frame and you'd be right where you are now.
The FFmpeg documentation says the following:
Ownership of the frame remains with the caller, and the encoder will not write to the frame. The encoder may create a reference to the frame data (or copy it if the frame is not reference-counted).
In other words, the encoder may create an internal copy of the frame data. This is cheap with reference-counted buffers that are being used by default but if the encoder does create a copy and you then try to make the frame writable again using av_frame_make_writable, the function will allocate a new buffer for the frame data. It would be also pointless to create frames directly from the buffer received from d3d because the encoder could easily end up creating a copy of the data. Not mentioning potential safety issues because FFmpeg requires the frame data to be properly aligned for each line of the image.
I'd propose the following solution:

Let's implement a method called try_into_mut for VideoFrame and AudioFrame. This method would have the following signature:
pub fn try_into_mut(mut self) -> Result<VideoFrameMut, VideoFrame> { ... }

It could be implemented with a little help from the av_frame_is_writable function.

This would allow you to create a pool of reusable frames. Something like this:
struct FramePool {
    frames: VecDeque<VideoFrame>,
}

impl FramePool {
    /// Put a given frame back to the pool after it was used.
    fn put(&mut self, frame: VideoFrame) {
        self.frames.push_back(frame);
    }

    /// Take a writable frame from the pool or allocate a new one if necessary.
    fn take(&mut self) -> VideoFrameMut {
        if let Some(frame) = self.frames.pop_front() {
            match frame.try_into_mut() {
                Ok(frame) => return frame,
                Err(frame) => self.frames.push_front(frame),
            }
        }

        VideoFrameMut::black(...)
    }
}

You could then use the pool knowing that the number of frames in the pool would eventually match the depth of the input queue of your encoder. This will help you to shave off those 4 ms for the frame allocation and initialization but those 2 ms for copying the frame data would be still needed.

That's quite impressive. Is it H.624? I guess you must be using some really powerful HW encoder to achieve this.

Yes, it's H264 and nvenc with low-latency preset.

This may depend on a lot of things. It is both codec and encoder specific and it may also depend on encoding profile, preset and and the encoding schema.

That makes sense!

I'd propose the following solution:

That is precisely what I was thinking. I will try to implement that and then perhaps make a PR. Thank you so much for your help.


SASL/SCRAM authentication

This patch aims at adding SASL/SCRAM authentication api and message flow to pgwire library.

[x] message formats
[x] api design and implementation
[x] demo

@sunng87: Good job!
Linked to:

https://github.com/scram-sasl/info/issues/1
https://github.com/sunng87/pgwire/pull/26
https://github.com/sunng87/pgwire/issues/27
https://github.com/sunng87/pgwire/pull/31

@sunng87: Good job!
Can you add RFC 9266: Channel Bindings for TLS 1.3 support too?

https://github.com/sunng87/pgwire/issues/126

Linked to:

https://github.com/scram-sasl/info/issues/1
https://github.com/sunng87/pgwire/pull/26
https://github.com/sunng87/pgwire/issues/27
https://github.com/sunng87/pgwire/pull/31


Enable for use in application extensions

Allows you to use Reachability.swift in application extensions.

poke @ashleymills this is ready to merge in.

@younata Thanks for the PR
Cheers
Ash


Error on composer update

Getting the following error on composer update.
[Composer\Downloader\TransportException]   The "http://packagist.org/p/realexpayments/rxp-remote-php%24e5f419fd415bde8632bb23162029f6f9ba8c459759862f46b19b733dd29ce014.json" f   ile could not be downloaded: php_network_getaddresses: getaddrinfo failed: nodename nor servname provided, or not known   failed to open stream: php_network_getaddresses: getaddrinfo failed: nodename nor servname provided, or not known

Turns out updating to latest version of composer fixed the issue.


Training dataset

Thank you for the excellent work you've done. Have you uploaded your training dataset to a cloud drive? Could you send me a private message with a copy?

OK, I will upload it these days.

I have released the WeatherKITTI dataset!


Get Error while waiting for Protractor to sync with the page: true with Angular2

My app navigates to the overview page after user logged in so I test it like this:
    I.amOnPage('/users/roles');
    I.click('role1', 'myComponent');
    I.seeInCurrentUrl('/users/overview');
    I.see('role1', 'nav');

but get the error message:
Uncaught Error: Error while waiting for Protractor to sync with the page: true
      at node_modules/protractor/built/browser.js:272:23
      at ManagedPromise.invokeCallback_ (node_modules/selenium-webdriver/lib/promise.js:1379:14)
      at TaskQueue.execute_ (node_modules/selenium-webdriver/lib/promise.js:2913:14)
      at TaskQueue.executeNext_ (node_modules/selenium-webdriver/lib/promise.js:2896:21)
      at asyncRun (node_modules/selenium-webdriver/lib/promise.js:2775:27)
      at node_modules/selenium-webdriver/lib/promise.js:639:7
      at process._tickCallback (internal/process/next_tick.js:103:7)

When I add amOnPage directive then everything works fine:
    I.amOnPage('/users/roles');
    I.click('role1', 'myComponent');
    I.amOnPage('/users/overview');
    I.seeInCurrentUrl('/users/overview');
    I.see('role1', 'nav');

Any ideas how I can test that user is redirected to overview page after he/she is logged in?
Details

CodeceptJS version: 0.4.14
NodeJS Version: 7.2.1
Operating System: Mac OSX El Capitan
Protractor: 4.0.14
Configuration file:

useAllAngular2AppRoots: true,
rootElement: 'app-root'

seems that the real cause wasn't the row described above but the fact that I ran several scenarios without restarting the browser(some bug there?).
I got sessionId is null error or local settings are not available for 'data' urls all the time I ran more than one scenario. Not sure about actual reason but once I added restart: true to the protractor helper in codecept config, everything works smoothly.

Fixed after updating to last versions of protractor(5.1.1) and codeceptjs(0.5.0). Can be closed.


Sidebar styling incorrect

About styles 🛠
Your version puts the active element in a box with all-caps text.

Zeit's just makes the text bold.

It's just the style of the document, but I think you're right, I'll fix it.

@unix I think you should also remove the background, like this:

@ofekashery I did mention that zeit-ui puts it in a box


util/release: Add MariaDB to release manifest

Without this, the image will not be uploaded.

LGTM


Fix NPC shield labels

This fixes NPC shield stat labels, which broke sometime between 5.7.4 and 5.8.0 when the old localized text was removed.
For the moment I've pointed the text to the newer PF2E.Actor.Character.Shield and PF2E.Item.Physical strings since they're already there rather than adding Shield to PF2E.Actor.NPC and having duplicates there. I suspect it's best to have one place outside of Character and NPC for these shield specific strings but wasn't quite sure where, so let me know what/where is preferred.
Before:

After:

Could you move the localization strings to the Creature level?

All moved.


Update VRT

Shot Type
Count
Status

Added
20
🟡

Deleted
0
❌

Regression
0
❗

🟡 page/astro__[w1024px] (click to expand)

Image

🟡 page/astro__[w1440px] (click to expand)

Image

🟡 page/astro__[w375px] (click to expand)

Image

🟡 page/astro__[w768px] (click to expand)

Image

🟡 page/index__[w1024px] (click to expand)

Image

🟡 page/index__[w1440px] (click to expand)

Image

🟡 page/index__[w375px] (click to expand)

Image

🟡 page/index__[w768px] (click to expand)

Image

🟡 page/index-masked__[w1024px] (click to expand)

Image

🟡 page/index-masked__[w1440px] (click to expand)

Image

🟡 page/index-masked__[w375px] (click to expand)

Image

🟡 page/index-masked__[w768px] (click to expand)

Image

🟡 page/programming__[w1024px] (click to expand)

Image

🟡 page/programming__[w1440px] (click to expand)

Image

🟡 page/programming__[w375px] (click to expand)

Image

🟡 page/programming__[w768px] (click to expand)

Image

🟡 page/typescript__[w1024px] (click to expand)

Image

🟡 page/typescript__[w1440px] (click to expand)

Image

🟡 page/typescript__[w375px] (click to expand)

Image

🟡 page/typescript__[w768px] (click to expand)

Image

Shot Type
Count
Status

Added
20
🟡

Deleted
0
❌

Regression
0
❗

🟡 page/astro__[w1024px] (click to expand)

Image

🟡 page/astro__[w1440px] (click to expand)

Image

🟡 page/astro__[w375px] (click to expand)

Image

🟡 page/astro__[w768px] (click to expand)

Image

🟡 page/index__[w1024px] (click to expand)

Image

🟡 page/index__[w1440px] (click to expand)

Image

🟡 page/index__[w375px] (click to expand)

Image

🟡 page/index__[w768px] (click to expand)

Image

🟡 page/index-masked__[w1024px] (click to expand)

Image

🟡 page/index-masked__[w1440px] (click to expand)

Image

🟡 page/index-masked__[w375px] (click to expand)

Image

🟡 page/index-masked__[w768px] (click to expand)

Image

🟡 page/programming__[w1024px] (click to expand)

Image

🟡 page/programming__[w1440px] (click to expand)

Image

🟡 page/programming__[w375px] (click to expand)

Image

🟡 page/programming__[w768px] (click to expand)

Image

🟡 page/typescript__[w1024px] (click to expand)

Image

🟡 page/typescript__[w1440px] (click to expand)

Image

🟡 page/typescript__[w375px] (click to expand)

Image

🟡 page/typescript__[w768px] (click to expand)

Image


Populate initial test database

Create a simple test database for development

Before working on this ticket, please check our bounties eligibility at https://github.com/CaravanaCloud/.github/blob/main/BOUNTIES.md
/bounty 20.00

@faermanj can i start working on it?

/attempt #12

Please provide more information on this issue.

/attempt #12


brew upgrade error occurred

brew config output
HOMEBREW_VERSION: 3.6.7
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 6a7eac25e167a1eb2d49e13c8cc530a3188af995
Last commit: 8 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core.git
Core tap HEAD: 58741df50893d1afe9aa3c4ef2666f63d125ac5e
Core tap last commit: 42 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_REPOSITORY: /opt/homebrew
HOMEBREW_CELLAR: /opt/homebrew/Cellar
HOMEBREW_BREW_GIT_REMOTE: https://github.com/Homebrew/brew.git
HOMEBREW_CASK_OPTS: []
HOMEBREW_CORE_GIT_REMOTE: https://github.com/Homebrew/homebrew-core.git
HOMEBREW_MAKE_JOBS: 10
all_proxy: socks5://<IP_ADDRESS>:7890
http_proxy: http://<IP_ADDRESS>:7890
https_proxy: http://<IP_ADDRESS>:7890
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit westmere
Clang: 14.0.0 build 1400
Git: 2.37.0 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 7.84.0 => /usr/bin/curl
macOS: 13.0-x86_64
CLT: <IP_ADDRESS>.1.1661618636
Xcode: N/A
Rosetta 2: true

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: A newer Command Line Tools release is available.
Update them from Software Update in System Preferences or run:
  softwareupdate --all --install --force

If that doesn't show you any updates, run:
  sudo rm -rf /Library/Developer/CommandLineTools
  sudo xcode-select --install

Alternatively, manually download them from:
  https://developer.apple.com/download/all/.
You should download the Command Line Tools for Xcode 14.1.

Warning: Your Homebrew's prefix is not /usr/local.

Many of Homebrew's bottles (binary packages) can only be used with the default prefix.
Consider uninstalling Homebrew and reinstalling into the default prefix.
It is expected behaviour that some formulae will fail to build in this unsupported configuration.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from MacHomebrew on Twitter.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

Warning: Your Command Line Tools (CLT) does not support macOS 13.
It is either outdated or was modified.
Please update your Command Line Tools (CLT) or delete it if no updates are available.
Update them from Software Update in System Preferences or run:
  softwareupdate --all --install --force

If that doesn't show you any updates, run:
  sudo rm -rf /Library/Developer/CommandLineTools
  sudo xcode-select --install

Alternatively, manually download them from:
  https://developer.apple.com/download/all/.
You should download the Command Line Tools for Xcode 14.1.

Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
brew upgrade
What happened (include all command output)?
HOMEBREW_BREW_GIT_REMOTE set: using https://github.com/Homebrew/brew.git for Homebrew/brew Git remote.
HOMEBREW_CORE_GIT_REMOTE set: using https://github.com/Homebrew/homebrew-core.git for Homebrew/core Git remote.
Running `brew update --auto-update`...
Error: Cannot install under Rosetta 2 in ARM default prefix (/opt/homebrew)!
To rerun under ARM use:
    arch -arm64 brew install ...
To install under x86_64, install Homebrew into /usr/local.

What did you expect to happen?
successful
Step-by-step reproduction instructions (by running brew commands)
brew upgrade

You are running brew in Rosetta.  This could be a consequence of the shell or terminal emulator (or even something like running tmux or screen).
Run it natively to avoid the error. One way to do this is to follow the suggestion:
To rerun under ARM use:
    arch -arm64 brew install ...

Your CLT is also outdated. Download the Command Line Tools for Xcode 14.1 (this may still be a release candidate) from https://developer.apple.com/download/all, do
sudo rm -rf /Library/Developer/CommandLineTools

and install the CLT you just downloaded above.


Package request: qBittorrent-Enhanced-Edition

Project description
An unofficial version of qBittorrent featuring community enhancements such as: automatic banning of Xunlei, QQ, Baidu, Xfplay, DLBT, and Offline downloader; an option to automatically ban unknown peers from China; automatic updating of public trackers list; an option to automatically ban BitTorrent media player peers; and peer whitelisting/blacklisting.
Metadata

homepage URL: https://github.com/c0re100/qBittorrent-Enhanced-Edition
source URL: https://github.com/c0re100/qBittorrent-Enhanced-Edition
license: gpl2/gpl3, See copying
platforms: unix, linux, darwin, windows

It is currently available in berberman's flake: https://github.com/berberman/flakes


[Android] Fix the launch screen not working correctly

The launch screen dialog has its own lifecycle. The main Activity's attributes
should not be directly applied to the launch screen dialog. So remove these here.
As to XWALK-4688, if you want to apply custom on xwalk_launch_screen, you need
to call window.screen.show(); in your javascript.
BUG=XWALK-4688, XWALK-4687, XWALK-4261

@lincsoon  @fujunwei  @halton

The code LGTM.
But about this,
if you want to apply custom on xwalk_launch_screen, you need
to call window.screen.show(); in your javascript.

Do we need to give any instruction on the official website?

It was here: https://crosswalk-project.org/documentation/manifest/launch_screen.html

Thanks! Then LGTM

LGTM.

does this need to be backported?

This only happens crosswalk 15. So no need.

You've fixed this in Crosswalk 16.

So does this need to be backported or not?

OK, Will do it soon.


Failing to extract with latest files

Heya,
The WAD extract is failing with the following error:
> wad.extract("files/plugins/rcp-be-lol-game-data/default-assets.wad", "files/plugins/rcp-be-lol-game-data/default-assets", function(error){console.trace(error)});
{ state: 'pending' }
> { > Trace: { Error: incorrect header check
    at Zlib._handle.onerror (zlib.js:370:17) errno: -3, code: 'Z_DATA_ERROR' }
    at repl:1:147
    at C:\Users\atoah\Desktop\Teemo\FTP\node_modules\expandjs\lib\constructors\Promise.js:59:68
    at _rejected (C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:864:24)
    at C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:890:30
    at Promise.when (C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:1142:31)
    at Promise.promise.promiseDispatch (C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:808:41)
    at C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:624:44
    at runSingle (C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:137:13)
    at flush (C:\Users\atoah\Desktop\Teemo\FTP\node_modules\q\q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)

several times with several files on the latest client. The reader / parser is working as expected.
Example failing file:
http://l3cdn.riotgames.com/releases/live/projects/league_client/releases/<IP_ADDRESS>/files/Plugins/rcp-be-lol-game-data/default-assets.wad.compressed
PS: I'm inflating it first, and even copying an original one just extract it partially before failing.

After some investigation, I've found out it has something with the "header.compressed" component.
It seems that might exist a new version?
A temporary fix that will solve the issue (and keep extracting, although it fails later) will be included here.
Still need to find out the real reason and provide a better fix - this was purely a temporary and most likely not ready to production fix.

So header.compressed is true but the file is not actually compressed? Also the file you linked 404s

Sorry about the link, this is the correct one:
http://l3cdn.riotgames.com/releases/live/projects/league_client/releases/<IP_ADDRESS>/files/Plugins/rcp-be-lol-game-data/default-assets.wad.compressed
Note that it is "compressed", you still need to inflate before trying to extract.
Yes, the header compressed is always > 1, but the content isn't compressed for some reason.
A few examples:
{ pathHash: '4defcfd3e29cf33',
  offset: 677883556,
  compressedFileSize: 1112685,
  fileSize: 1112685,
  compressed: 256,
  sha256: '9277fd2e8921a69e',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }
{ pathHash: '51b1b9f9b26ba28',
  offset: 677696800,
  compressedFileSize: 186756,
  fileSize: 186756,
  compressed: 256,
  sha256: 'b44031c4dac0bd14',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }
{ pathHash: '107776a2f6730113',
  offset: 331138,
  compressedFileSize: 198078,
  fileSize: 198556,
  compressed: 257,
  sha256: '1a1a5c61d887d43a',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }
{ pathHash: '18fc53a34bfaf3ac',
  offset: 122249097,
  compressedFileSize: 48,
  fileSize: 48,
  compressed: 256,
  sha256: '5eec52c622954826',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }
{ pathHash: '1faef1496b7b469e',
  offset: 122249097,
  compressedFileSize: 48,
  fileSize: 48,
  compressed: 256,
  sha256: '5eec52c622954826',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }
{ pathHash: 'f9ae01e1a22864b2',
  offset: 6627815,
  compressedFileSize: 36120,
  fileSize: 43255,
  compressed: 257,
  sha256: 'f744fbb8283bf0a9',
  fileName: null,
  output: 'files/plugins/rcp-be-lol-game-data/default-assets' }

It seems that, for some reason, there is an extra byte sometimes after the fileSize.
I don't know exactly why or what for, the only info that seems to be true is:
256 = not compressed,
257 = compressed

Ok, fixed this. The compressed filed was wrongly parsed. v2 seems to be holding multiple flags instead of just compressed at that offset.
Researching to solve this another flag popped up, which is used to show that multiple files point to the same contents. Basically they have the same file in multiple locations for some reason.


⚠ Bofrost.at has degraded performance

In dd7dc69, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1900 ms

Resolved: Bofrost.at performance has improved in f2467ec.


Add log levels feature (for internal logging)

We need a way to have different internal log levels, to avoid outputting debug information when running on production.

Fixed by #22


[Bug - Partner Center] No email when extension is approved

Describe the bug
My extension update was approved but I received no email about it. I had to check the partner center manually.
To Reproduce
Submit an extension update for review
Expected behavior
An email should be sent when the update is approved. I got emails for previous submissions but not this one.

Hi @infinitepower18
Thank you for bringing this to our attention.
Could you please email us your Seller ID and the extension details to<EMAIL_ADDRESS>so we could investigate this issue?

Hi @infinitepower18
Could you please help us with your CRX ID, so we could investigate this issue?

@prithamkasiMSFT sent an email

Hi @infinitepower18
Thank you for sending us the email.
I will go ahead and close the ticket here, and further communication will be continued via email.
Thank you for your patience!


Support AC Context Notes / Modifiers

Gate Archon: Has an Armor Type Context Modifier, which sbc currently does not support ([...]; +2 deflection vs. evil)
Originally posted by @Lavaeolous in https://github.com/Lavaeolous/PF1-StatBlock-Converter-Module/issues/412#issuecomment-841786420

Added support in 3.2.1


DO NOT MERGE! Fast Forward stable to 6024135c4b47b8cba4aeda55f311c0913c379aeb.

This PR will be merged automatically once checks are successful.

Jenkins job manager/postsubmit passed

Jenkins job manager/e2e-suite passed


Code Fomatting

Issue Type: Feature Request
My code formatting options in vs code is not working. What should I do ? I have tried all the options  using mouse and shortcut keys but it does'nt work at any time.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

What language is this for?


Custom ICal Adapters for our backend

Adapt JavaFX calendar backend to use our ical data directly using custom adapters

v1.5+: Future enhancement


How do I properly output data from a field with a relationship using blade?

Hey, guys.
I am having a problem trying to call a data field with a relationship using blade. I have followed the steps mentioned in the documentation (https://the-control-group.github.io/voyager/docs/v0.10/#core-concepts-bread-relationships) still with no luck. I did exactly as instructed, but on my 'posts' table.
In a page I have a blade @foreach that displays the post fields. All the fields output data as expected, except the post author. I am calling the field using {{ $posts->authorId()->name }} and I get the following error:

Undefined property: Illuminate\Database\Eloquent\Relations\BelongsTo::$name (View: /home/anderson/atom-projects/planeta-gundam/resources/views/blog/index.blade.php)

Am I doing something wrong? I'm using the latest version of Voyager (0.10.15) and Laravel 5.3. Thanks.

Please read the Laravel documentations about relationships.
{{ $post->authorId()->first()->name }}

i don't think you need to add the custom functions now you can $post->authorid->name simply now

tried but says
Trying to get property of non-object

This issue has been closed for 8 months now and was for a much older version.  Please open your own issue if you're having trouble

I have this problem too, I am new in voyager 1.0 and laravel 5.5.*, I solved in this way
in web.php
Route::get('/posts', function () {
$posts = TCG\Voyager\Models\Post::all();
return view('posts', compact('posts'));
});
Route::get('post/{slug}', function($slug){
$post = TCG\Voyager\Models\Post::where('slug', '=', $slug)->firstOrFail();
return view('post', compact('post'));
});


Incorrect let binding crashes compiler

Description
#let 5 = 6

When calling typst::ide::tooltip() on the let of the above statement, the compiler will crash with
thread 'main' panicked at 'internal error: entered unreachable code', [...]\src\eval\mod.rs:1402:18.
I hope I did not miss any open issues for this bug.
Reproduction URL
No response
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

See also #1213


Modularization

Will you consider a PR that will split this package into multiple modules?
e.g. at this point when I just want to use encode I need to import module that also comes with decode and some other stuff. It'll be great to have possibility to import just encode related logic in that case.
I envision it so content of this package is organized as:

lib (folder for common modules used by more than one of modules below)
usc2 (folder)

decode.js
encode.js

toASCII.js
decode.js
encode.js
toUnicode.js
index.js (exports all modules, and result of it would be same as of requiring punycode now)

Since punycode.js is included as-is in Node.js & io.js doing so would complicate the upstreaming process.
I’d rather not do this.
The most common standalone functionality is probably ucs2.encode and ucs2.decode, but ES6 String.fromCodePoint (polyfill) and String#codePointAt (](https://mths.be/codepointat)) solve the same problem. If you need modularity, why not use those?

Thanks @mathiasbynens, all understood.
I've actually wanted to use some stuff from node's url module, which I started to modularize to not take it in full into browser, but then I found it also needs punycode.toASCII and imports full punycode for that, this directed me here :)
I'll probably just prepare modular versions of two projects, for my needs. That would at least solve the problem on my side.

Sounds good! :+1:
Please leave a link to those projects here once they’re done.

I published modular version as punycode2. Same way I published modular versions of other node.js modules: url3, querystring2 and a while ago path2


New package: AbstractMCMC v0.1.0

Registering package: AbstractMCMC
Repository: https://github.com/TuringLang/AbstractMCMC.jl
Created by: @yebai
Version: v0.1.0
Commit: 65c1f4ea0bd4c0cef2d9f8b8f587debb69ec785d
Reviewed by: @yebai
Reference: https://github.com/TuringLang/AbstractMCMC.jl/issues/2#issuecomment-557932214

We were wondering if it was possible to override the naming requirement for the automerger on this one, since the last four characters of the package name are a very common acronym and there isn't much reason to add an extra letter.

Yea, its just a heuristic to catch "weird" names. Do you want to add the bounds? https://github.com/bcbi/CompatHelper.jl might be of interest. [noblock]


Fix for subscribing to large messages

Using pubsub when you are subscribed to a channel and a large message is delivered in multiple packets the message is incorrectly handled. Only the first packet in the stream for the message is parsed.  This patch demonstrates a fix for the issue.

@azafty468 @macdiesel is this still an issue as of today? Would you be so kind and check and otherwise try to write a failing test?

Sorry, I rebased this thing once and have long since moved past this.  No clue if this is or is not still an issue, but I'm well past any support here.

@azafty468 That sad, but I totally understood your frustration :/


Wrong string substitutions

Describe the bug
Tried to migrate a project, got errors in some files, like so:
class ProviderConsumerWidgetatelessWidget {
Widget build(BuildCo, WidgetRef refntext context) {
        firef.watchumber = watch(numberProvider).toString();

To Reproduce
Migrate https://github.com/JohannesMilke/riverpod_modifiers_example
Did 'y' once, then 'A'. Needed to do one more 'y' (also a bug :)
Check provider_page.dart, state_provider_page, maybe others are affected, too. future_provider_page is fine.
Thanks for your work, Remi :-)

I'll close this. I have no plan to fix the remaining bugs for the migration tool as it's been quite a while now since the breaking change happened.


ViT-CoMer with O365 Pretrained Result?

Hi, amazing work here! I am wondering have you tried to pre-train ViT-CoMer with O365 and then train on COCO2017?
It is amazing that it can achieve 64+ mAP without the O365 pre-train, but I am still curious about how far can this method go. Because in Co-DETR, using O365 pretrain, the Swin-L backbone would go from 60.4 to 64.1, it is huge boost.
Look forward to your reply😃

Thank you for your interest in our work. Due to resource limitations, we have not yet attempted to pre-train ViT-CoMer using Obj365 and fine-tune it on the COCO2017.


dask-searchcv -> dask-ml in docs (#585)

Replace dask-searchcv in main dask-ml docs (but left appropriate mention in history).

Thanks!


Hardcoded path to icons.svg

Is there a better solution then to hard code the path to icons.svg? When deploying assets to for example S3 the icons can't be found.
Or maybe a setting to set a custom path.

@martin-ro I'm not sure about this to be honest because the path to icons.svg comes from the trumbowyg package itself but it's definitely something that needs to be addressed.

There is an option to  change the path to the icons in trumbowyg. Not sure if that can be used to fix the issue.

And a prop on vue-trumbowyg which is used underneath so definitely seems possible. I'll try and get a look at it this week, if you need it sooner feel free to make a PR.


Converge on scala_import and java_import

The #101 switches from using scala_library to scala_import for importing external jars. For uniformity, we would like to switch from java_library to java_import too but we decided to hold until java_import stabilizes, see: https://github.com/bazelbuild/bazel/issues/3769

I have a branch that has this working. I'll try to get it cleaned up, passing tests, and in code review next week.

@jjudd thanks!

@jjudd how did you go? would love to start using this so I don't have to use transitivity:exports anymore just to make aws sdk dependencies compile.


find_prefix errors

I keep getting this when trying find_prefix or find_prefixes_asn
[2015-12-28 21:34:56 +0000] [9711] [ERROR] Error handling request /analytics/find_prefix
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gunicorn/workers/sync.py", line 130, in handle
self.handle_request(listener, req, client, addr)
File "/usr/local/lib/python2.7/dist-packages/gunicorn/workers/sync.py", line 171, in handle_request
respiter = self.wsgi(environ, resp.start_response)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1836, in call
return self.wsgi_app(environ, start_response)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1820, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1403, in handle_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1817, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1477, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1475, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1461, in dispatch_request
return self.view_functionsrule.endpoint
File "/usr/local/lib/python2.7/dist-packages/sir/agent.py", line 100, in analytics_view_find_prefix
return sir.analytics.views.find_prefix(request)
File "/usr/local/lib/python2.7/dist-packages/sir/analytics/views.py", line 104, in find_prefix
context['date'] = context['available_dates'][-1]
IndexError: list index out of range
<IP_ADDRESS> - - [28/Dec/2015:21:34:56 -0800] "GET /analytics/find_prefix HTTP/1.1" 500 - "-" "-"

Do you have data in your database? There is a bug that I haven't had time to fix that triggers that when the database is completely empty.

Ah yes.  I do now.  I didn't realize i could only query data after each hour.
Also I for some reason am unable to search the prefixes.  For example I see all the prefixes in the bgp output file for pmacct but when I search any of them it gives me an internal error.  Am I searching wrong?

Ah yes. I do now. I didn't realize i could only query data after each hour.

That's a bug, would probably be nicer to don't break and inform there is no data yet but I haven't had the time to fix it.

Am I searching wrong?

Does gunicorn report anything back? How are you searching exactly?

Just noticed:
IOError: [Errno 13] Permission denied: '/pmacct-1.5.1/output/bgp-184_164_192_2-2015_12_29T01_00_01.txt'
Restarted in sudo and it works fine now.
Sorry for the headache.  Snap: http://cl.ly/1L1b3L0h1w1u

Glad to be your rubber duck : )
Feel free to provide feedback and report issues and even pull requests if you want to fix them : )


Add Service Controller

Description:
Add a Service controller to the Kubernetes Provider package similar to the HTTP Route Controller that will be needed by the Gateway API Translator
[optional Relevant Links:]

Any extra documentation required to understand the issue.

The Kube provider should not need a service controller. Since Services are a dep of HTTPRoutes, the httproute controller should include a watch for services. When a service is CRUD'ed, an HTTPRoute reconciliation will be triggered by the httproute controller. The controller should get/list the necessary objects, e.g. Gateways, Services, etc required to call the translate func or pub the translate message. Post v0.2.0, we should consider an approach to filter the services to reduce the reconciliation churn.

reopened this issue since we haven't yet reconciled and stored the service resources in the provider resources message

xref https://github.com/envoyproxy/gateway/pull/230#discussion_r953151075, need to decide on the pattern for this


Is possible to have helper/private method implemented outside contract macro?

Last time I tried, VSCode and CLion is having trouble debug code inside macro. I think it is because the code in the macro can get modified in such way confused the IDE.
So I want to have most of the logic outside macro and only the interface and delegation call in macro.
I think it is already possible, just want to make sure this point is considered in the design of the contract syntax.

Currently all contract definitions have to be contained within the macro body contract!.
There are no plans to change this in the near future.

ok. It will be good if there is a workaround for it. But I am ok as it is.


server side data with virtual scroll

ENHANCEMENT
I wonder or can't find in the doc if it's possible to have this with this lib 2 and 3 example: http://saulis.github.io/iron-data-table/demo/
The awesome of this angular2-data-table is virtualscroll is it possible to have virtuaclscroll but data from server and fetch data when we scroll to bottom of the table similar  to link lib...?

Its possible, I'll make a demo later to show it.

any up here ?

Sorry, busy week. What API would you have in mind to handle this?

I think:
virtual scroll but we calla  request first load to fetch 100items then when we are closed to bottom when scrolling so show a "loading bar" (for loading bar you can check this lib http://rintoj.github.io/angular2-virtual-scroll/ this 3th example called LOADING IN CHUNKS) then fetch new data and append new data to the existant..... arrayData , like this when we scroll again top we don't need fetch anything only when we are close to bottom when scrolling
something like this for api http://rintoj.github.io/angular2-virtual-scroll/#demo
i think two function can realize this scrolling() and scrollUp()
you actual example from server use"pager" but I don't want pager I expect your awesome virtual scroll,

any ETA @amcdnl

Up?

one month I wait this example in docs ? load on scroll what'about ? thanks

Any hints how virtual scrolling and remote data (loaded in chunks as required) would work? I presume server side pagination rules out virtual scrolling which implies client side pagination?

When you can see the demo?

@amcdnl any news here (since 8 Dec 2016)?

I have this working with a very old version 0.9.3.
Every time I have tried updating I have had to wait because this issue has not been fixed. I took a very weak attempt at fixing it which can be seen in this PR here. There were issues with my solution, and probably needs a solution as described in the PR.
@amcdnl, is this wrong, is there actually a way to do it right now?

@java2kus - any thoughts on this?

@amcdnl, @java2kus was the one commenting in the PR about the calculation that needs to be added back in to calculate the virtual height of the scroller.
I have some free cycles at work to take another attempt at fixing it so I'm going to proceed as this is not yet possible. Please stop me if you learn otherwise in the mean time.

So I took a much deeper dive into this at the end of last week, and I wanted to come back with how I understand the current implementation, and discuss some possible solutions forward.
The main change that broke this feature was the addition of the row detail feature, which allowed rows to be one of two heights. Either the defined rowHeight, or the rowHeight + detailRowHeight.
In order to be efficient in calculating the new height of the scroller, a row-height-cache class was added in which used the fenwick tree to calculate the total height of a given set of rows, and get the row index for a given scroll position. It took me awhile to understand how this was working, but in the end it does seem really neat and allows you to calculate the heights and row indexes in O(log n) time.
Given all of this information I tried to update the current row-height-cache to work with the case of virtual scrolling WITHOUT loading all of the rows into the treeArray since there could be millions of rows on the server. The problem I see with the fenwick tree solution is it breaks down if all of the rows are not filled in the treeArray. Lets take the following example:

I load the table and the first page loads.
I then drag the scroller all the way down the page and load the very last page.

Since the pages are not next to each other in treeArray and there could be pages in the middle, the bit shifting technique which fenwick tree uses breaks down, unless there is something fundamental I'm not understanding. If you can suggest a way to make the fenwick tree work in this situation, please ping me and lets talk!
So the way I see it we have a coupple solutions:

Keep the fenwick tree solution in place for non server-side pagination and turn to another maybe less efficient technique of calculating height and positions.
Remove the fenwick tree solution in both cases and come up with a new technique which works in both situations.

@amcdnl, @java2kus I wanted to reach out to you guys to find out your thoughts before I moved too much further.

@deeg I would suggest a third solution that would keep the row detail intact for the current viewport and use a linear equation to calculate the row position when the page changes.   This way you can allow for server side pagination with row detail.   Following is what I would suggest:

Currently with or without server side pagination, the total number of rows are divided into pages.   This helps with the pagination/pager feature in the datatable.
In case of both client side and server side pagination, total row count is available to the datatable component.  Hence calculation of page count based on viewport size remains the same irrespective of server/client side pagination.
When the pagination type is server, the fenwick tree array size can be the same as the total number of rows that are available inside the page whereas for client side pagination, the algorithm can be set as is.
Translating scroll position to row position can utilize a linear equation just like how it was in the version you were using. const offset = (this.state.options.rowHeight * action.limit) * action.offset;.   If the row window falls within the current viewport then re-initialize the fenwick tree cache.

I think the above can be implemented keeping the interface same i.e. get the row height, row position, scroll position.   Currently I am starved for cycles given we have a production release for one of the applications I am working or else I would have submitted the PR myself. Hopefully the above should help you get started.    Let me know once you submit the PR so that I can help with the reviews.

Any news here @amcdnl @deeg @java2kus

I ended up moving away from virtual scrolling with my server side pagination, so I am no longer working on this unfortunitly.

Unfortunatly

how can we disable virtual scroll for server side pagination ?

So is it currently possible to do virtual scrolling with server-side fetching on-demand? I.e. a user scrolls down, and more data is loaded at the bottom automatically in a chunk of "page" size (e.g. 10 events at a time). If I understand the API correctly, we either:

catch (page) event, as per https://github.com/swimlane/ngx-datatable/blob/master/demo/basic/virtual.component.ts, but in my tests using the current demo this event gets generated on every scroll, not just when the page "limit" is reached.
use (scroll) event and then manually calculate the offset for which to fetch additional data.

In my tests, there is no problem adding more data to the table dynamically (e.g. I just add more elements to the rows array, and the table automatically expands), it is rather how to properly register "page limit" event.
Thanks!

[scrollbarV]="false"


docs(wasm-languages): ruby updates

Sample setup/code/manifest updates similar to https://github.com/fermyon/developer/pull/1403
Bonus: I did see the following error in the app logs when pinging the endpoint.  Cause for alarm?  Fixable?  (Response was still a 200 and contained the expected "Hello, Fermyon" body)
$ spin up
Logging component stdio to ".spin/logs/"

Serving http://<IP_ADDRESS>:3000
Available Routes:
  ruby: http://<IP_ADDRESS>:3000
2024-10-30T22:37:06.498213Z ERROR spin_http::wagi: Invalid header name error=invalid HTTP header name header_name=ruby 3.4.0dev (2024-06-28T17

Could you raise an issue on Spin for the header error please?  It seems like it's just a quirk, but at least then we'll have a reminder to check it out.  Thanks!


pin LuaSocket version to 3.0rc1-2

The newly release 3.0 version of LuaSocket apparently breaks the Copas test suite. For now pinning it to the old RC.

updated rockspecs uploaded.


Bypass gRPC stack when the search service is local

Description
Per title. I'm doing so by refactoring how the search job placer accesses the available list of searcher nodes/clients.
How was this PR tested?

[x] Updated unit tests
[ ] Re-enable some tests

@fmassot, this is ready for review, I just have to re-enable a few tests, and it should be good to go.

I wrote a really nice unit test for you and my future self :)


[ALLUXIO-3099] Avoid spurious log messages from PrimarySelectorClient

https://alluxio.atlassian.net/browse/ALLUXIO-3099
Otherwise the message gets logged at error level when
we stop the server normally with alluxio-stop.sh

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18597/
Test PASSed.

I don't see a risk of receiving unexpected interrupts in takeLeadership - the thread is only accessible by the Curator LeaderSelector class. tbh we really don't have any business handling InterruptedException here anyway. I've updated the code to let it propagate

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18598/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18605/
Test PASSed.


Cannot pop the current screen with the back gesture on android

Navigated to a new screen with navigator.push
when I try to move back to the previous screen with the back gesture on android
it closes the entire app
worked well previously

my code
Navigator.push(
context,
PageTransition(
isIos: Platform.isIOS ? true : false,
child: screen,
type: PageTransitionType.fade,
duration: const Duration(milliseconds: 400),
));

solved it by
setting the to false
android:enableOnBackInvokedCallback = "false">
wasn't a problem with the package


Need guidance on using echoprometheus.NewMiddleware for metrics server setup

Description:
I'm currently working on a Go project where I'm building an API using the Echo framework. Previously, I was using the prometheus.NewPrometheus method from github.com/labstack/echo-contrib/prometheus to set up my metrics server and seperate the metric endpoint. However, the method is deprecated, and the documentation suggests using the echoprometheus package instead.
I have been trying to find examples or documentation on how to use the echoprometheus.NewMiddleware method, but I couldn't locate any. I would greatly appreciate some guidance on how to correctly set up my metrics server using echoprometheus.NewMiddleware, and it would be helpful if the documentation could be updated accordingly. Currently, the documentation still refers to prometheus.NewPrometheus as the recommended approach.
https://echo.labstack.com/middleware/prometheus/
Here is the code snippet that I have been using with prometheus.NewPrometheus, and now I am looking for a solution using echoprometheus.NewMiddleware:
func NewMetricServer(subsystem string, appServer *echo.Echo) *echo.Echo {
	metricServer := echo.New()
	metricServer.HideBanner = true
	p := prometheus.NewPrometheus(subsystem, nil)
	p.SetMetricsPath(metricServer)
	p.Use(appServer)
	return metricServer
}

Any help or code examples illustrating the use of echoprometheus.NewMiddleware would be greatly appreciated. It would also be helpful if the documentation for echoprometheus could be updated to reflect the recommended approach.

This example adds prometheus middleware to gather metrics (on port 8080) and exposes gathered metrics on port 8081
func main() {
	app := echo.New()
	app.Use(echoprometheus.NewMiddleware("myapp"))

	go func() {
		metrics := echo.New()
		metrics.GET("/metrics", echoprometheus.NewHandler())
		if err := metrics.Start(":8081"); err != nil && !errors.Is(err, http.ErrServerClosed) {
			log.Fatal(err)
		}
	}()

	app.GET("/hello", func(c echo.Context) error {
		return c.String(http.StatusOK, "hello")
	})

	if err := app.Start(":8080"); err != nil && !errors.Is(err, http.ErrServerClosed) {
		log.Fatal(err)
	}
}

I'll update website soon (this weekend)

I updated website https://echo.labstack.com/middleware/prometheus/


Model JPN electricity generation exactly from FY 2011-16

This issue can be closed when individual demand processes for coal, nuclear etc have been created to model post-Fukushima electricity generation

Completed by creating multiple MIN processes, and specifying STOCK values for each year.


sync_ldap_user_data return errors

OS: ubuntu 20.04 , python 3.8
zulip version 3.3
2020-12-10 17:27:12 [minion@s06 current]$ sudo su - zulip /home/zulip/deployments/current/manage.py sync_ldap_user_data
/home/zulip/deployments/current/manage.py: line 2: import: command not found
/home/zulip/deployments/current/manage.py: line 3: import: command not found
/home/zulip/deployments/current/manage.py: line 4: import: command not found
/home/zulip/deployments/current/manage.py: line 6: syntax error near unexpected token `('
/home/zulip/deployments/current/manage.py: line 6: `if sys.version_info <= (3, 0):'

I think that's because, running sudo su - zulip /home/zulip/deployments/current/manage.py sync_ldap_user_data makes manage.py to be run as a shell script, rather than as a python program. Arguments specified after the username are supplied to the user's login shell.
You can try passing the '-c' argument to 'su' to run it as a single command.
sudo su - zulip -c /home/zulip/deployments/current/manage.py sync_ldap_user_data runs on my PC.


IJ build version

I noticed we were still targeting 15.0.3 in our plugin configuration (this determines which version of the IDE the plugin supports from the plugin repository).
This updates it to 15.0.6.
@patflynn

@chanseokoh, I updated the url to a page that references the mapping between 15.0.6 and the full version number.

LGTM

lgtm
On Mon, Jun 27, 2016 at 12:01 PM, Chanseok Oh<EMAIL_ADDRESS>wrote:

LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/762#issuecomment-228790929,
or mute the thread
https://github.com/notifications/unsubscribe/AHf5HVfRIFakzyfw02xof2y_qIA0xPweks5qP_PSgaJpZM4I_LWj
.


Allow use of systemd for worker management

Allow for workers to be run and managed by systemd.  This follows exactly the containerized worker model so it doesn't remove a lot of code, but I see this as a way to get it in and start testing.
A worker consists of the following component:
A target which groups multiple logical units together so they can be managed as a group
cat /etc/systemd/system/generic.target
[Unit]
PartOf=cfme.target

A service template which defines the options for the service, this is the basis for multiple unit services like most queue workers
cat<EMAIL_ADDRESS>[Unit]
PartOf=generic.target
[Install]
WantedBy=generic.target
[Service]
Environment=HOME=/root
WorkingDirectory=/var/www/miq/vmdb
ExecStart=/bin/bash -lc 'exec ruby lib/workers/bin/run_single_worker.rb MiqGenericWorker --heartbeat --guid=%i'
Restart=always
Slice=cfme-generic.slice

A settings directory where the per worker settings are stored:
cat<EMAIL_ADDRESS>[Service]

MemoryHigh=524288000
TimeoutStartSec=600
TimeoutStopSec=600

When running it looks like this:
systemctl status cfme.slice
● cfme.slice
   Loaded: loaded
   Active: active since Wed 2019-04-10 11:43:32 EDT; 4h 48min ago
    Tasks: 16
   Memory: 846.1M
   CGroup: /cfme.slice
           ├─cfme-event_handler.slice
           │<EMAIL_ADDRESS>           │   └─25044 MIQ: MiqEventHandler id: 88, queue: ems
           ├─cfme-generic.slice
           │<EMAIL_ADDRESS>           │   └─25222 MIQ: MiqGenericWorker id: 89, queue: generic
           ├─cfme-priority.slice
           │<EMAIL_ADDRESS>           │   └─25052 MIQ: MiqPriorityWorker id: 90, queue: generic
           ├─cfme-reporting.slice
           │<EMAIL_ADDRESS>           │   └─25056 MIQ: MiqReportingWorker id: 91, queue: reporting
           └─cfme-schedule.slice
<EMAIL_ADDRESS>               └─25060 MIQ: MiqScheduleWorker id: 92

Apr 10 11:43:32 agrare-thinkpad systemd[1]: Created slice cfme.slice.

We can get logs by slice:
journalctl --unit=cfme-generic.slice
-- Logs begin at Wed 2019-04-10 11:41:48 EDT, end at Wed 2019-04-10 16:33:02 EDT. --
Apr 10 11:43:32 agrare-thinkpad systemd[1]: Created slice cfme-generic.slice.
Apr 10 11:43:39 agrare-thinkpad ruby[2261]:  INFO -- : MIQ(Vmdb::Loggers.apply_config) Log level for journald has been changed to [INFO]
Apr 10 11:43:39 agrare-thinkpad ruby[2261]:  INFO -- : MIQ(Vmdb::Loggers.apply_config) Log level for azure.log has been changed to [WARN]
Apr 10 11:43:42 agrare-thinkpad bash[2261]: ** Using session_store: ActionDispatch::Session::MemCacheStore
Apr 10 11:43:42 agrare-thinkpad bash[2261]: ** ManageIQ master, codename: Ivanchuk
Apr 10 11:43:43 agrare-thinkpad MIQ: MiqGenericWorker id: 87, queue: generic[2261]:  INFO -- : MIQ(MiqGenericWorker::Runner#sync_config) ID [87], PID [2261], GUID [327d1248-7257-41c9-8d18-ae82b5e913d5], Zone [d
Apr 10 11:43:43 agrare-thinkpad MIQ: MiqGenericWorker id: 87, queue: generic[2261]:  INFO -- :

And also only for example show log levels warn or above, journalctl --unit=cfme-generic.slice --priority=warning
TODO:

[x] Define how to handle provider workers, do we use the unit instance for the ems_id (can't handle ems_id and count then) or do we write out unit files with the ems_id builtin to the unit file env vars, or can we use the env vars in the unit settings
[x] Remove dependence on temporary worker instance column

Depends on: https://github.com/ManageIQ/manageiq-loggers/pull/5

Okay I got provider workers working by passing the ems_id as an env var defined in a per-unit settings file:
root@agrare-thinkpad:/etc/systemd/system# cat<EMAIL_ADDRESS>[Service]
Environment=EMS_ID=1

Okay @Fryguy @jrafanie @carbonin can you take another look?

@Fryguy @agrare is this ready to go?

@carbonin it is ready from my side

So this is still off by default. Do we know who from QE we should rope in to see if they can run some tests with this enabled?

@dmetzger57 can we get QE to setup an appliance with this feature turned on?

I'll work with QE to get a resource(s) allocated for initial testing, @agrare should I have then contact you directly with any specific questions?

@agrare should I have then contact you directly with any specific questions?

Definitely not :laughing: of course


list-prs-for-branch broken

Description
No error, not shown. https://github.com/refined-github/sandbox/pull/4 is open from that branch

Similar issue:

#6299

Related:

https://github.com/refined-github/refined-github/issues/5234

How to replicate the issue + URL
https://github.com/refined-github/sandbox/commits/sdfsdfds
Extension version
23.2.1
Browser(s) used
Safari

This seems to be working fine for me:

Can we double check if the provided personal token is valid or not expired?

hmm you're right 🤷♂

Good thing I took a screenshot last time or I'd think I was crazy 😅


Delegate ask for a UIView rather than an NSString

Hi !
It can be great to replace or add the possibility to ask for a UIView rather than an NSString. With this, we can do all that we want with your nice tool 😊
Good Day,
Léo

Just use the other delegate method:
https://github.com/veader/V8HorizontalPickerView/blob/master/V8HorizontalPickerViewProtocol.h#L28


fix AudioContext.decodeAudioData being sync

Was not respecting successCallback and errorCallback arguments.
Remove stub audio classes.

Thanks! Passes on CI (obviously, since they're skipped), and the previously failing A-Frame test passes now.


[Question] How to prevent Solasta updates when using UB

I've been told by @ThyWoof to turn off auto-updates when using the UB mod to avoid errors on new Solasta patches, and I had seen this kind of advice on Reddit before. But on Steam there is no obvious way to do so. These are the options available: https://i.imgur.com/tFdeeUR.png
What am I missing?
In a more programming philosophy note, is there a way to code UB so that it gracefully fails when there is an error, e.g. instead of Solasta reporting a broken mod and prevent saving (presumably to avoid corruption), have UB notify with a popup what is wrong and allow safe saving?

We do our best to prevent that but whenever TA changes interfaces signatures we get into these issues. We would require a full refactor on how we apply patches. Not worthy with 400 of them. Even more that I don’t expect more ruleset changes. Only bug fixes from TA

Solasta will always have a Steam beta branch with previous game version. So on an update easiest you can do is switch over to it to buy us time to fix. I usually fix these beforehand but got caught by surprise today.

Solasta will always have a Steam beta branch with previous game version. So on an update easiest you can do is switch over to it to buy us time to fix. I usually fix these beforehand but got caught by surprise today.

I wasn't criticizing, what you have achieved and your responsiveness are impressive.


TLA connection / Alpha release

Successful merging of this pr means that engine can handle some game.
So alpha is coming.
TLA repo (https://github.com/cvet/fonline-tla) will demonstrate how you can setup and extend your game.

No estimates, but I think it will take a few months.

Keep it up Cvet!!! Great work 🙌👏 😄


Update Sample Guidelines to recommend using exec:exec

See #1523 for example and reasoning

@gguuss FYI - since you appear to be solving this.

Putting some notes here for edges so far:
Multiple command utilities
If you have multiple command utilities to be executed by the Maven Plugin, specify them as a profile:
  <profiles>
    <profile>
      <id>mqtt</id>
      <activation>
        <property>
          <name>mqtt</name>
        </property>
      </activation>
    </profile>
  </profiles>

Required named arguments
Required named arguments are specified within the ...... section of the profiles section when you're using multiple execution runners.
The following example shows one style of specifying a required parameter
            <configuration>
              <executable>java</executable>
              <arguments>
                <argument>-classpath</argument>
                <classpath/>
                <argument>com.example.cloud.iot.examples.MqttExample</argument>
                <...>
                <argument>-project_id=${project_id}</argument>
                <...>
              </arguments>
            </configuration>

This parameter can be passed to the program as just the variable for exec to handle, for example, -Dproject_id=NOUN-VERB-NUMBER.
Optional named arguments
Because you don't want to specify optional named arguments unless they are passed, specify an argument where the variable alone is passed to the app.
The following example shows how to pass an optional parameter:
            <configuration>
              <executable>java</executable>
              <arguments>
                <argument>-classpath</argument>
                <classpath/>
                <argument>com.example.cloud.iot.examples.MqttExample</argument>
                <...>
                <argument>${cr}</argument>
                <...>
              </arguments>
            </configuration>

This parameter is be passed to the program with its named parameter, for example, -Dcd=cloud_region=us-central1.

Basic example POM.xml
Complex example POM.xml

Closing this as I believe we decided we no longer want to use this pattern.


Merge to live!

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/privacy-and-security.md
:white_check_mark:Succeeded

docs/design/dialog-boxes.md
:white_check_mark:Succeeded

docs/develop/bind-to-regions-in-a-document-or-spreadsheet.md
:white_check_mark:Succeeded

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded

docs/develop/create-and-debug-office-add-ins-in-visual-studio.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded

docs/develop/localization.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-multiple-ranges.md
:white_check_mark:Succeeded

docs/images/new-add-in.png
:white_check_mark:Succeeded

docs/images/power-bi-tiles-edit.png
:white_check_mark:Succeeded

docs/images/power-bi-tiles.png
:white_check_mark:Succeeded

docs/images/select-an-add-in.png
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-jquery.md
:white_check_mark:Succeeded

docs/includes/file-get-started-onenote.md
:white_check_mark:Succeeded

docs/includes/file-get-started-powerpoint.md
:white_check_mark:Succeeded

docs/includes/file-get-started-project.md
:white_check_mark:Succeeded

docs/includes/file-get-started-word.md
:white_check_mark:Succeeded

docs/includes/quickstart-yo-start-server.md
:white_check_mark:Succeeded

docs/index.yml
:white_check_mark:Succeeded

docs/publish/centralized-deployment.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


When editorId is not provided error is raised

adding editorId prevent this error, which should be optional
<email-editor #editor editorId="email-editor" (loaded)="editorLoaded()" [options]="options"></email-editor>

getting same issue when with Angular. Any one could help on this?

Add editorId input for email-editir component
In doc its optional but in fact its mandatory

Could you please provide me the sample code for providing the Id?


Added Vector store for PGVector

Kudos, SonarCloud Quality Gate passed!
  0 Bugs   0 Vulnerabilities   0 Security Hotspots   19 Code Smells
 0.0% Coverage  0.0% Duplication

Please resolve the code smell

A general approach to error handling:
use checked exceptions for conditions from which the caller can reasonably be expected to recover.
Use runtime exceptions to indicate programming errors.

Let's add comments for every public class

Wow, the PR is well-documented!!!

IDK why some comments are left here https://github.com/AyoTheDev/langtorch/pull/1


Added AWS cli with squid proxy wrapper

OSD-16086
Adds aws tool to this application so users can install, remove, and upgrade the tool. It also includes a bash wrapper script that routes all traffic through the squid proxy

The Mac installation appears to work.
Network route to proxy:
❯ ~/.local/bin/backplane/latest/aws sts get-caller-identity
{
    "UserId": "AROAUKIS7NN2WL7RX2VFP:RH-SRE-geadams",
    "Account": "296929422197",
    "Arn": "arn:aws:sts::296929422197:assumed-role/OrganizationAccountAccessRole/RH-SRE-geadams"
}

No network route to proxy:
❯ ~/.local/bin/backplane/latest/aws sts get-caller-identity

Failed to connect to proxy URL: "http://squid:3128/"

/label tide/merge-method-squash
/lgtm
/approve

/retest


Homepage Graphic Re-design

The homepage is currently a bit bland. It was the best we could do. It would be great if it were colorful and nice!
The "hero" image on the homepage is currently represented as clipart, but would ideally be a auto-rotating/refreshing set of images that we could upload from our events. See Issue #5
Suggested re-design 1

Suggested re-design 2

Since you all are working on this @dixita9 @bsaavedrabo I would suggest using one or more nice photo(s) from our Instagram or Google Photos account as the Splash background, rather than a stock clipart as shown in the examples.


⚠ Bofrost.de has degraded performance

In 110f6d0, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1317 ms

Resolved: Bofrost.de performance has improved in 08a3a07 after 9 minutes.


Fix encoding issue in path param

Purpose

$subject

Fixes #19666
Approach

Allow only encoded paths to be mentioned in the path segments except for path params which is covered with {}

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Shall we send a PR to the master as well?

Codecov Report

:exclamation: No coverage uploaded for pull request base (ballerina-0.990.x@6a367d7). Click here to learn what that means.
The diff coverage is 100%.

@@                 Coverage Diff                  @@
##             ballerina-0.990.x   #19785   +/-   ##
====================================================
  Coverage                     ?   64.43%
  Complexity                   ?      659
====================================================
  Files                        ?     2111
  Lines                        ?    93272
  Branches                     ?    12254
====================================================
  Hits                         ?    60102
  Misses                       ?    28279
  Partials                     ?     4891

Impacted Files
Coverage Δ
Complexity Δ

...allerinalang/langserver/index/dao/AbstractDAO.java
40.9% <ø> (ø)
0 <0> (?)

...allerinalang/net/uri/parser/URITemplateParser.java
66.66% <ø> (ø)
0 <0> (?)

...ang/langserver/formatting/FormattingSourceGen.java
52.51% <ø> (ø)
0 <0> (?)

...java/org/ballerinalang/model/util/FreezeUtils.java
45.45% <ø> (ø)
0 <0> (?)

...in/java/org/ballerinalang/model/values/BValue.java
71.42% <ø> (ø)
0 <0> (?)

...er/command/testgen/AnnotationConfigsProcessor.java
25% <ø> (ø)
0 <0> (?)

...ava/org/ballerinalang/net/http/HttpDispatcher.java
80.83% <100%> (ø)
0 <0> (?)

...n/java/org/ballerinalang/net/http/HttpService.java
87.05% <100%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a367d7...dc5d2f5. Read the comment docs.


be able to specify order when serializing data

and perhaps more importantly, preserve order when decoding -> serializing data.
This would require an API change as the value currently wrapped by Table is BTreeMap which always sorts values alphabetically.

This is sort of related to https://github.com/alexcrichton/toml-rs/issues/83, where in general lots of AST information is lost when decoding.

I think this is basically done in #137 as serde should be much more flexible than rustc-serialize

That's awesome news, thanks for doing it the right way, and so quick!


UI: Modules - view all button not resetting the filter

fixed by https://github.com/relative-ci/bundle-stats/pull/1326


Always install node.d.ts typing file

This change ensures that we install node.d.ts for intellisense, even if node is not explicitly required by another installed package.
I think we should merge this change in because it makes things better. However, there is currently an issue where OnIdleNodeModules is never fired for projects without any node modules. Because this callback is never fired, we never try to acquire any typings. I'm looking into handling that, but a proper fix may involve changing the existing behavior of the code.
closes #770

Gotcha. How about instead of handling node.d.ts in OnIdleNodeModules, we handle just this one case in ReloadHierarchy?

How about on FinishProjectCreation? That's where we create the TS Scripts/typings stuff currently.

Pretty sure that only gets fired when the project is being created. Not if it's being opened.
Also, oops - I totally meant NodejsProjectNode.Reload, not ReloadHierarchy

Minor comment and LGTM after that!

We can sort out the remaining comment later - going to go ahead and merge in the changes now and kick off a build.


iPad: Bring desktop-style split settings nav to iPad

@keybase/react-hackers CC @keybase/design
This PR harmonizes the Settings view between desktop and iPad.  Specifically:

Git and Devices are moved into a new "More" tab with hamburger icon and desktop-style split subnav, replacing Settings, on both desktop and iPad.  Git and Devices are no longer main nav tabs anywhere now -- they were already subnavs of Settings on Phone, and now they are on iPad and Desktop too.
Wallet is moved to the main nav on iPad.  It already was on Desktop.
Phone is unaffected by all of this, so Wallet is still a More subnav item there.
Badging: include Wallet badge number in More for Phone, don't include it for Desktop and iPad.

@chrisnojima, I know you've got a nav rework PR open affecting Git and Devices so I'll try to make this compatible with that.
Screenshots:
iPad: Bottom nav tabs changed to include Wallet and rename Settings to More, now uses new split-style subnav:

iPad portrait:

Desktop (Devices and Git are gone from the main subnav and moved inside More with the hamburger icon):

Phone (unchanged):

We should also change the provisioning instructions to reflect the fact that devices is in a subnav.

@cjb
• iPad looks great, can we make the settings side bar wider?
• I don't think we should change desktop for now. We have a design ticket to explore ideas.

I also have a PR up for crypto tab on mobile. I can wait for this to merge, then rebase and resolve.
https://github.com/keybase/client/pull/23122
@cjb @cecileboucheron

@cecileboucheron @chrisnojima Thanks, backed out all the desktop changes and made the iPad nav wider.  Screenshot:

@cjb Looks good! Any chance we can bring the nav icons, like on mobile? (sorry forgot to mention this in my previous comment)

@cecileboucheron Yep, done:

👍🏻 lgtm!

thanks! @chrisnojima, ready for the JS review when you have time.


keybase pgp decrypt -> Error: No username known

I've confirmed I'm logged in.
$ keybase id
▶ INFO Identifying xamox
✔ public key fingerprint: C71E E3E8 F61A 166A D268 5ADA 8447 06FB 6E28 BC35

Same key fingerprint in my gpg list
$ gpg --list-keys --fingerprint | grep C71E
      Key fingerprint = C71E E3E8 F61A 166A D268  5ADA 8447 06FB 6E28 BC35

I've also tried keybase logout, keybase db nuke, then keybase login again but still same issue occurs.
$ keybase version
Client:  1.0.48-20180516160417+b56432f520
Service: 1.0.48-20180516160417+b56432f520

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.4 LTS
Release:	16.04
Codename:	xenial

Thanks for the bug report, I'll look into it right away

@maxtaco Great, let me know if you would like the debug output as well.

Looks like the issue closed with my merge. We'll get a release out soon.  Thank you!

Great thanks!

What's the status on that release, or another workaround?  With increasing numbers of tools like vault and terraform integrating with keybase, I think fixing breakage like this is should be high priority

@mattvonrocketstein, does keybase logout; keybase login work?

Yes! tyvm


Support for Tags used in documenting custom elements

Search Terms
It would be nice if Typedoc has support for the tags used to document custom element.  JSDoc has these.  More here: https://www.npmjs.com/package/web-component-analyzer
Problem
If Typedoc had the corresponding JSDoc features it makes documenting web components more straight forward with Typedoc
Suggested Solution
Implement corresponding JSDoc tags like @element, etc.

Marking this wontfix.
TypeDoc can be configured with support for custom tags already. If custom parsing/rendering is desired for a tag, this can be done by an external plugin. TypeDoc doesn't need to support it natively, and in the interest of reducing the maintenance burden, I do not plan on supporting additional sets of non-standard tags in the core without a very compelling reason.


ß66 BezelHud shows no search results

After Update to ß66 BezelHud show no more search results. I tried clearing the caches as described in the FAQ. With Bezel results are shown as expected.
Console.app shows no output.
Quicksilver ß66 (3922)
OSX 10.7.3

66 is a pre-release, please always check the Developer discussions before
updating - it is available here:
http://groups.google.com/group/quicksilver---development/browse_thread/thread/116e261780ba95a4
There is an updated BezelHUD plugin available in that topic, we will work
on making plugins available through the update system for pre-releases soon.
On 24 February 2012 17:02, Oliver Schrenk <
<EMAIL_ADDRESS>
wrote:

After Update to 66 BezelHud show no more search results. I tried clearing
the caches as described in the FAQ. With Bezel results are shown as
expected.
Console.app shows no output.
Quicksilver 66 (3922)
OSX 10.7.3

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/issues/727

Thanks. For all with the same problem:
https://groups.google.com/group/quicksilver---development/browse_thread/thread/729e1535a6fa20a0#msg_4cd32714121e1b25


[BUG] BadRequest when utilizing data source "btp_subaccount_service_plan"

Is there an existing issue for this?

[X] I have searched the existing issues

What version of Terraform are you using?
1.5.6
What type of issue are you facing
bug report
Describe the bug
After defining a subaccount and an entitlement, when attempting to define an instance of an entitlement, the documentation says:

The service plan ID can be looked up via the data source btp_subaccount_service_plan

But when defining a data element of that kind, for example:
data "btp_subaccount_service_plan" "application_logs" {
  subaccount_id = btp_subaccount.products.id
  name          = var.logging_product_tier # "lite"
  offering_name = "application-logs"
}

And then defining the resource for the instance:
resource "btp_subaccount_service_instance" "logging_product1NameRedacted" {
  subaccount_id  = btp_subaccount.products.id
  serviceplan_id = data.btp_subaccount_service_plan.application_logs.serviceoffering_id
  name           = "product1NameRedacted-app-logs"
}

Expected Behavior
Given the reproduction steps below and what I've read in the docs, I would expect the data source to be populated and the instance to be suggested for creation.
Instead, I see:

Error: API Error Reading Resource Service Plan (Subaccount)
│
│   with module.product_environment.data.btp_subaccount_service_plan.application_logs,
│   on modules\product_environment\main.tf line 8, in data "btp_subaccount_service_plan" "application_logs":
│    8: data "btp_subaccount_service_plan" "application_logs" {
│
│ BadRequest

I also tried the data source using hard-coded values for the subaccount ID and "lite" for the service plan ID.
Since it's a BadRequest rather than a more specific error, I'm inclined to think this may be a bug.
Steps To Reproduce
ℹ NOTE: I also tried the data source using hard-coded values for the subaccount ID and name in the data entry, to ensure my variables weren't messing it up.
resource "btp_subaccount" "products" {
  name      = var.product_subaccount_name # known to be correct
  subdomain = var.product_subaccount_subdomain # known to be correct
  region    = var.product_environment_region # known to be correct "us10"
}

data "btp_subaccount_service_plan" "application_logs" {
  subaccount_id = btp_subaccount.products.id
  name          = var.logging_product_tier # "lite"
  offering_name = "application-logs"
  depends_on    = [btp_subaccount.products]
}

resource "btp_subaccount_entitlement" "app_logging_service" {
  subaccount_id = btp_subaccount.products.id
  service_name  = "application-logs"
  plan_name     = var.logging_product_tier
}

resource "btp_subaccount_service_instance" "logging_product1NameRedacted" {
  subaccount_id  = btp_subaccount.products.id
  serviceplan_id = data.btp_subaccount_service_plan.application_logs.serviceoffering_id
  name           = "product1NameRedacted-app-logs"
}

Add screenshots to help explain your problem
No response
Additional context
I'm new to this and going off the docs but fully aware of the fact that this might be a silly mistake on my end.

Analysis:

The service is a non-cross-consumable service available on CF only
The list  data source displays the service only if CF environment is enabled
The get data source throws an error (Bad Request) even if CF is enabled.

Works fine with cross-consumable services.
Clarification with BTP CLI needed

@SeanKilleen unfortunately this is not a bug but an impact of the environment-dependent availability of services in the SAP BTP.  You can create service instances in SAP BTP targeting different runtime environments namely Cloud Foundry, Kubernetes/Kyma and SAP BTP/other. Some services on support only specific runtime environments and can only be created there. You can see this in the SAP BTP Cockpit when creating a service instance via the UI (some services might even be visible only if the Cloud Foundry environment is enabled in your subaccount):

This availability is reflected in the tooling you can use to fetch information about the services as well as create services instances. In your case the service is available on Cloud Foundry only, so you are not able to fetch the service plan or create a service instance via the Terraform Provider for SAP BTP as this provider is only capable of handling services that are available in the runtime environment SAP BTP. Hence, the request you are executing, fails.
The data source and the underlying API is a bit inconsistent here as it allows to specify the environment (see https://registry.terraform.io/providers/SAP/btp/latest/docs/data-sources/subaccount_service_plans), but this is not supported by the data source you are using.
So this is not a bug, but a specific of the platform.

Hi @lechnerc77 thanks for the details. I'd just like to recap to confirm my understanding.
You're saying that I will not be able to use Terraform to create instances of entitlements in our BTP environment because that service is specific to the CloudFoundry runtime environment. And even though BTP itself encompasses all these environments, this Terraform provider product -- from a product direction standpoint -- is choosing to limit itself only to services that are within the "SAP BTP" runtime environment. This is fine if that's the case; I just want to make sure I'm clear.
It sounds like my only option would be to see if the CloudFoundry terraform provider -- the "wild west" we were seeking to avoid 😆 -- offers such functionality.
Setting up and managing entitlements and their instances is a core part of why we'd want Terraform in the first place, because that represents a chunk of time in setting up and managing environment. So I may need to abandon this product for now. But I appreciate your support!

Hi @SeanKilleen
the BTP terraform provider restricts itself to the entities (which comprises the services) available for the SAP BTP. From the point of view of service instances you can manage cross-consumable services with it. This restriction (beside some technical aspects) is also due to the fact that there are existing providers for Kubernetes as well as for Cloud Foundry that we do not want to duplicate.
Concerning your setup: I do not think that this severely impacts the setup of your accounts:

The basic setup of your accounts including the assignment of entitlements to your subaccounts, creating role collections etc. is covered by the terraform provider. This also comprises the creation of instances of these environments.
As soon as things become "runtime environment" specific, things need to be managed by the runtime-specific providers namely the Cloud Foundry or Kubernetes ones. For Cloud Foundry this means e.g. the creation of spaces or of service instances and bindings within the runtime environment.

Comparing that to the options you have to automate the setup via CLIs, you will face the same limits: the BTP CLI is capable of the BTP-specifics but e.g. cannot create CF spaces or Kubernetes namespaces. For the later two you need to use the CloudFoundry CLI or kubectl in order to handle the corresponding resources.
I agree that the experience might not be as smooth as one would wish, but you should be able to do your setup Terraform based however need to combine several providers. However, if you face any limitation from that approach, I am happy to jump on a call to learn about those.

@lechnerc77 totally fair and I appreciate the confirmation / clarification. I think at first distinction was lost on me but I've got it now. 👍 Thanks again!


EOS-18936: Provisioning: invoke cfgen in config phase of hare mini provisioner

Description:
jira ticket- https://jts.seagate.com/browse/EOS-18936
In order to hctl fetch-fids be working on all the nodes of the cluster, consul-kv.json must be present on every node in the cluster. Presently cfgen is invoked in the init phase of the hare mini provisioned which generates consul-kv.json.
Solution:

Invoking cfgen in config phase of hare mini provisioner.
hctl fetch-fids works on every node of the cluster post config phase execution of hare mini provisioner.

Signed-off-by: Shreya Karmakar<EMAIL_ADDRESS>

Commit message subject is too long, consider
EOS-18936: invoke cfgen in config phase of hare mini provisioner

Commit message subject is too long, consider
EOS-18936: invoke cfgen in config phase of hare mini provisioner

Done, updated commit message

@Shreya-18 please reword your last commit message. 'task' doesn't look good 😁

@Shreya-18 please reword your last commit message. 'task' doesn't look good 😁

Yes, done. Squashed and updated the commit.


Introductory text

We should have some intro text on the page to make clear about the "why" of this calculator.

Yes. I do think that this should be the / route. After the intro, there could be a "zum Rechner" Button


Python code doesn't take multiple files as argument.

Fixed the file problems and works with multiple file arguments


Enhancement: Allow searching/filtering on ZK app transactions

https://minasearch.com/transactions/zk-txn

This page is stubbed for now.

Closing, as this page is stubbed and hidden behind feature flag right now. It will go through another round of development, at which time we will develop all the features.


photoqt: 4.0.1 -> 4.1

Description of changes
https://gitlab.com/lspies/photoqt/-/releases/v4.1
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 275949 run on aarch64-linux 1

1 package built:

photoqt