Could not find com.google.android.exoplayer:exoplayer-core:2.11.4.

Describe the bug
Hi I install react native track player on a fresh project
and Im getting this error on android only:
Could not find com.google.android.exoplayer:exoplayer-core:2.11.4.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
- https://dl.google.com/dl/android/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
- https://www.jitpack.io/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
To Reproduce
Steps to reproduce the behavior:
yarn add react-native-track-player
Environment (please complete the following information):
Run react-native info in your project and share the content.
System:
Binaries:
Node: 14.17.5 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 7.20.6 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7583922
Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
Languages:
Java: 15.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.65.0 => 0.65.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
What react-native-track-player version are you using? 2.0.3
Are you testing on a real device or in the simulator?  android emulator
Which OS version are you running? MacOs Big Sur
Code
I get the error running the app
tried adding different maven url but none work.

Do you also get this issue when running the example?

Same issue here with fresh project.

I have just tried to make a new project and add the lib and it has worked.
These are the commands I used:
npx react-native init TestProject --template react-native-template-typescript
cd TestProject
yarn add react-native-track-player
yarn run android

I have just tried to make a new project and add the lib and it has worked.
These are the commands I used:
npx react-native init TestProject --template react-native-template-typescript
cd TestProject
yarn add react-native-track-player
yarn run android

Thanks that worked ok.

@giorodri0584 I haven't heard from you yet. Can you try the above?

@giorodri0584 I haven't heard from you yet. Can you try the abov

@giorodri0584 I haven't heard from you yet. Can you try the above?

At work right now. I'll try it when I get a chance and let you know. Thanks for the quick response

@dcvz next os, next issue! Same here, not working for me with react-native 0.65 and android. Exactly the same error message when I try to run  ./gradlew bundleRelease

FYI, npx npx react-native init TestProject --template react-native-template-typescript does not create a react-native project with 0.65.1 but rather 0.64.2(?) (I found this out bugfixing my ios issue)

@espenjanson does it work when you follow the commands in my comment above? My guess is your project is not including one of the important repositories. Like maven central.
Although perhaps it's the other way around.. I'll take a look more carefully now that you point out that the commands I used don't generate a 0.65 project.
How are you creating a new project?

@espenjanson can you post the contents of your gradle file in your Android project?

Sure!
`// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext {
buildToolsVersion = "29.0.3"
minSdkVersion = 25
compileSdkVersion = 29
targetSdkVersion = 29
ndkVersion = "21.4.7075529"
}
repositories {
google()
jcenter()
}
dependencies {
classpath("com.android.tools.build:gradle:4.1.0")
classpath('com.google.gms:google-services:4.3.3')
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
}
allprojects {
repositories {
mavenLocal()
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url("$rootDir/../node_modules/react-native/android")
}
maven {
// Android JSC is installed from npm
url("$rootDir/../node_modules/jsc-android/dist")
}
    google()
    jcenter()
    maven { url 'https://www.jitpack.io' }
}

}
`

@espenjanson if you try the command I mentioned above (which does not use 0.65) does it run for you?
There must be some difference in the gradle files across versions. I'm not at my computer atm though to check.

In the latest changelog at https://github.com/facebook/react-native/releases/tag/v0.65.0, it mentions: JCenter has been sunsetted and read-only now. We have removed JCenter as a maven repository and updated dependencies to use MavenCentral and Jitpack.
Is that the reason?

@xeoneux this definitely would be the reason.. I thought that might be it but the gradle file @espenjanson posted still has jcenter() in it.
So I was a bit confused. But if jcenter is no longer in the gradle file then that would be the reason.
I'll have to update the dependency to a version that's published to maven central.

Haha, sorry @dcvz my bad there, I actually just included jcenter() - however, it's still not building for me. Not sure if it's because of track-player though since there seems to be plenty of libraries hit hard by 0.65, I'm currently stuck because of react-native-reanimated (it seems).

Ok, I have updated the example in the repo to RN 0.65.0 and can confirm the issue.
For now the workaround is to add jcenter() to allprojects { repositories {  like I've done here: https://github.com/DoubleSymmetry/react-native-track-player/commit/5b3084745a58f81c1e49a5737e300801dc714cd7
The better fix will be to update the exoplanet dependency to one that is released under maven central but that will require some more work. I'll keep this issue open until then.

Ok, I have updated the example in the repo to RN 0.65.1 and can confirm the issue.
For now the workaround is to add jcenter() to allprojects { repositories {  like I've done here: 5b30847
The better fix will be to update exoplayer to a version that is released under maven central but that will require some more work. I'll keep this issue open until then.

Thanks a lot. It is working now.

@dcvz I can confirm having the same issue and adding jcenter fixes the issue. Also running RN 0.65.1.

Didn't realise this got closed. Reopening until it's fully fixed and not just worked around.

@dcvz Do you know that we are not able to compile our app anymore while this is not fixed ?
It is a critical issue. Is there any workaround (calling jcenter() won't work anymore), or quick fix ?

@GrimDev we know its an important issue and we're working on a fix. At the moment using jcenter() is still a valid workaround.. You cannot publish new packages there but it is still available as read-only.

@GrimDev As far as I know there's nothing wrong with doing this (yet?)
` repositories {
    mavenLocal()
    mavenCentral()
    jcenter()
    google()

}`

I guess jcenter was down when I tried last time, it seems to work today, sorry for then warn

Any updates?
Have same issue...

@espenjanson can you post the contents of your gradle file in your Android project?

Ok, I have updated the example in the repo to RN 0.65.1 and can confirm the issue.
For now the workaround is to add jcenter() to allprojects { repositories {  like I've done here: 5b30847
The better fix will be to update exoplayer to a version that is released under maven central but that will require some more work. I'll keep this issue open until then.

Thanks a lot sir. I stuck with this several day :) 💯

Have you any plans to move to maven or something else to avoid the jcenter-related riscs?

@SNNikitin please take the time to look through the thread. This question has been answered. We're working on it.

Thanks for your answer! :)
I'm just slightly frustrated, please sorry!

Ok, I have updated the example in the repo to RN 0.65.1 and can confirm the issue.
For now the workaround is to add jcenter() to allprojects { repositories {  like I've done here: 5b30847
The better fix will be to update exoplayer to a version that is released under maven central but that will require some more work. I'll keep this issue open until then.

Well I did this added jcenter() to my build.gradle and tried this on a fresh project but I am still getting the same error can anyone please help as soon as I install react-native-track-player my application fails to build.
It would mean a lot thank you.
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
Jetifier found 899 file(s) to forward-jetify. Using 8 workers...
info Starting JS server...
info Installing the app...
> Task :app:checkDebugAarMetadata FAILED
5 actionable tasks: 2 executed, 3 up-to-date
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find com.google.android.exoplayer:exoplayer-core:2.11.4.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/.m2/repository/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/Downloads/Documents/project/node_modules/react-native/android/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/Downloads/Documents/project/node_modules/jsc-android/dist/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - https://dl.google.com/dl/android/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - https://www.jitpack.io/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
     Required by:
         project :app > project :react-native-track-player

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 17s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Could not find com.google.android.exoplayer:exoplayer-core:2.11.4.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/.m2/repository/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/Downloads/Documents/project/node_modules/react-native/android/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - file:/C:/Users/bbwha/Downloads/Documents/project/node_modules/jsc-android/dist/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - https://dl.google.com/dl/android/maven2/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
       - https://www.jitpack.io/com/google/android/exoplayer/exoplayer-core/2.11.4/exoplayer-core-2.11.4.pom
     Required by:
         project :app > project :react-native-track-player

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 17s

    at makeError (C:\Users\bbwha\Downloads\Documents\project\node_modules\execa\index.js:174:9)
    at C:\Users\bbwha\Downloads\Documents\project\node_modules\execa\index.js:278:16
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async runOnAllDevices (C:\Users\bbwha\Downloads\Documents\project\node_modules\@react-native-community\cli-platform-android\build\commands\runAndroid\runOnAllDevices.js:106:5)
    at async Command.handleAction (C:\Users\bbwha\Downloads\Documents\project\node_modules\@react-native-community\cli\build\index.js:192:9)
info Run CLI with --verbose flag for more details.

Build.gradle:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext {
        buildToolsVersion = "30.0.2"
        minSdkVersion = 21
        compileSdkVersion = 30
        targetSdkVersion = 30
        ndkVersion = "21.4.7075529"
    }
    repositories {
        google()
        jcenter()
        mavenCentral()
    }
    dependencies {
        classpath("com.android.tools.build:gradle:4.2.2")
        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenCentral()
        mavenLocal()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url("$rootDir/../node_modules/react-native/android")
        }
        maven {
            // Android JSC is installed from npm
            url("$rootDir/../node_modules/jsc-android/dist")
        }

        google()
        maven { url 'https://www.jitpack.io' }
    }
}

Add jcenter() to allprojects section too

Add jcenter() to allprojects section too

thank you that worked!

It still gives different error after doing this.

This isn't working with the newer version of react native and android requirements.
jcenter() will create conflicts with mavenCentral repository.
we can't use a greater version of exoplayer because the library is outdated and too big to be fixed with a patch.
There are a lot of classes not more available in exoplayer newer versions :(
Are you going to update the lib?
Because I have a lot of apps in productions that are using this library and no one of these now is working :(

As jCenter was removed from react-native v0.65+ and no longer allows package updates, all packages should be obtained from mavenCentral. Thus, I would recommend defining the package such that other dependencies are no longer fetched from jCenter. So it is better to include jCenter dependent modules/groups to android/build.gradle like this:
allprojects {
    repositories {
        ...
        jcenter() {
            content {
                includeGroup("com.google.android.exoplayer")
            }
        }
        ...

    }
}

same issue on react-native 0.66

As jCenter was removed from react-native v0.65+ and no longer allows package updates, all packages should be obtained from mavenCentral. Thus, I would recommend defining the package such that other dependencies are no longer fetched from jCenter. So it is better to include jCenter dependent modules/groups to android/build.gradle like this:
allprojects {
    repositories {
        ...
        jcenter() {
            content {
                includeGroup("com.google.android.exoplayer")
            }
        }
        ...

    }
}

Thank you vary much!

Guys, shouldn't this be described on lib's documentation website?

Is there still any stable/fully working fix to this, I'm about to release an app with this library and I cannot generate an APK to test it, can someone please help.

Faced the same issue, at least doc should say in troubleshooting we need to add jccenter manually

All,
I understand that this is a super frustrating issue to encounter when trying to get new installs or upgrades running. With that said, v2.2.0 (currently in rc with v2.2.0-rc3 fixes this issue. As all the team efforts are going into that release we're not going to address this issue for v2.1.0.
I know it stinks! But it's the reality of the situation. The good news is that there is ample information on this issue to help folks find the solution for this issue themselves.
The issue will remain open until v2.2.0 is out of RC at which time it will be closed.

As jCenter was removed from react-native v0.65+ and no longer allows package updates, all packages should be obtained from mavenCentral. Thus, I would recommend defining the package such that other dependencies are no longer fetched from jCenter. So it is better to include jCenter dependent modules/groups to android/build.gradle like this:
allprojects {
    repositories {
        ...
        jcenter() {
            content {
                includeGroup("com.google.android.exoplayer")
            }
        }
        ...

    }
}

this one help me thank u buddy

This is not stale. It still conflicts with react-native-track-player's exoplayer (from KotlinAudio)

v3.1 is now out and fixes this issue. Please upgrade to the latest version.


gcc7

Build fails with gcc 7. See:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853701
I think this change is what was intended, but please check that I understood it correctly.

Hi.
What is the correct target branch now?
Should I change the target branch of the PRs to develop rather than develop-2.1.x now that the 2.1.x branch has been merged into develop?

What is the correct target branch now?

develop

Should I change the target branch of the PRs to develop rather than develop-2.1.x now that the 2.1.x branch has been merged into develop?

Yes, please.

The change is ok.

I have changed the base for this one now. I see that you already did it for the other PRs.


ci: Undo merging integrations into examples

Reverts parts of #6815
There is benefit to having a separate "integrations" folder to easily see which frameworks/bundlers have tests. Also, the CRA projects were never designed for use, and therefore aren't really "examples".

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c190f68) 41.78% compared to head (c9e5743) 41.76%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6821      +/-   ##
==========================================
- Coverage   41.78%   41.76%   -0.02%
==========================================
  Files         178      178
  Lines        7017     7017
  Branches     1421     1421
==========================================
- Hits         2932     2931       -1
- Misses       3722     3723       +1
  Partials      363      363

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tri 2 Final

Link to Blog
Link to Video

For Component A:
The blog is extremally thorough as it meets collegeboard requirements. Some issues I felt could be improved for College board grading is that commits, plans and depth details wouldn't be necessary. The requirements only states that the code made by the student be provided and which is shown through the Implementation section of your Final. Your implementation display is very thorough with concise captions below each image. For this component i give it a 2.3/2.5.
For Component B:
As i compared the college board requirements for the video I couldn't check the file type on youtube. According to you, it is in a .MP4 file. For future reference, you would submit the file directly under 30 mb which shouldn't be a problem. The video showed the required input through the button and its functionality as it could favorite properties. It then went over to the output to show the storing of these "favorited" properties. with no narration or distinguishing information, the only problem i would have as a CPT grader is the speed  up on the video. Without enough time to read some of the captions, it slightly defeats their purpose. Just  to be more thorough for next time, go to less pages elsewhere do that do. All things considered, i give this component a 2.4/2.5.
Final score of 4.7/5


fix untracked reserved memory was not release when attaching limiter tracker

What problem does this PR solve?
Problem Summary:
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[x] Previous test can cover this change.
[ ] No colde files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Release note
None

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Concurrent problems in default aggregator module

Describe the bug
The result value calculated by the default aggregator is wrong when aggregating and dumping are executed concurrently.
How to reproduce?
I can always reproduce this problem by running the following test case.

func TestConcurrentAggregator(t *testing.T) {
	aggKindMap := &AggregatedConfig{KindMap: map[string][]KindConfig{
		"duration": {
			{Kind: SumKind, OutputName: "duration_sum"},
			{Kind: CountKind, OutputName: "request_count"},
		},
	}}

	aggregator := NewDefaultAggregator(aggKindMap)
	labels := model.NewAttributeMap()
	labels.AddStringValue("key", "value")

	labelSelectors := internal.NewLabelSelectors(
		internal.LabelSelector{Name: "key", VType: internal.StringType},
	)

	wg := sync.WaitGroup{}
	wg.Add(1)
	stopCh := make(chan bool)

	var runLoop = 100000
	var duration int64 = 100
	go func() {
		for i := 0; i < runLoop; i++ {
			gaugeValues := []*model.Gauge{
				{"duration", duration},
			}
			gaugeGroup := model.NewGaugeGroup("testGauge", labels, 0, gaugeValues...)
			aggregator.Aggregate(gaugeGroup, labelSelectors)
			time.Sleep(time.Microsecond)
		}
		stopCh <- true
		wg.Done()
	}()

	wg.Add(1)
	var durationSum int64
	var requestCount int64
	go func() {
		ticker := time.NewTicker(500 * time.Microsecond)
		for {
			select {
			case <-ticker.C:
				ret := aggregator.Dump()
				for _, g := range ret {
					for _, v := range g.Values {
						if v.Name == "duration_sum" {
							durationSum += v.Value
						} else if v.Name == "request_count" {
							requestCount += v.Value
						}
					}
				}
			case <-stopCh:
				ret := aggregator.Dump()
				for _, g := range ret {
					for _, v := range g.Values {
						if v.Name == "duration_sum" {
							durationSum += v.Value
						} else if v.Name == "request_count" {
							requestCount += v.Value
						}
					}
				}
				wg.Done()
				return
			}
		}
	}()
	wg.Wait()
	expectedDurationSum := int64(runLoop) * duration
	expectedRequestCount := int64(runLoop)
	if durationSum != expectedDurationSum || requestCount != expectedRequestCount {
		t.Errorf("request_count = %v, duration_sum := %v", requestCount, durationSum)
	}
}

What did you expect to see?
The result value should be as expected in the above test case.
What did you see instead?
=== RUN   TestConcurrentAggregator
default_aggregator_test.go:84: request_count: exptected 100000, got 99545
default_aggregator_test.go:85: duration_sum: expected 10000000, got 9954700
--- FAIL: TestConcurrentAggregator (0.93s)
FAIL

This problem happens when the executions of default_aggregator run in the following order.

Get a recorder when calling the Aggregate method;
The same recorder is reset when calling the Dump method;
This recorder begins to Record a value.

In this case, the recorder can't be put into the map again, so the value it has calculated is missing. To fix this issue, the recorders can't be loaded from the map when the Dump method is called.

Closed via #195


Add ManUp.js to cdnjs

I was trying to add ManUp.js to cdnjs as per https://github.com/cdnjs/packages/issues/272 in pull request https://github.com/cdnjs/packages/issues/273 when I encountered an issue with missing version tag as there are currently no tags or releases for this repository.
I see a commit for version 0.7 at https://github.com/boyofgreen/ManUp.js/commit/1b46de310b98488e36de3793b75db0b7d130bafc and version 0.5 at https://github.com/boyofgreen/ManUp.js/commit/48309c9d843075e12615c7746a65b490af4a01ad but no associated tags or releases for the same.
@boyofgreen @radiovisual Could you please tag and release so that @MattIPv4 could proceed forward with my pull request at https://github.com/cdnjs/packages/issues/273?

(Releases aren't technically needed, we won't use them or the files in them, we just rely on a git tag and pull files from the repository at that point)

(Releases aren't technically needed, we won't use them or the files in them, we just rely on a git tag and pull files from the repository at that point)

Oh, thanks for the correction @MattIPv4! :)

@boyofgreen @radiovisual Any updates on this?


docs: update swagger proto path for wasm

Description

closes: #249
wasmd 0.17.0(#249) After merging, the legacy style wasm proto path was fixed.  This PR purpose is follow-up.
However, wasm doesn't have a service.proto, so it doesn't change swagger for wasm.
Other than that, it contains what appears to be missing during the merging of main in PR #249.(e.g reverted COSMOS SDK->LFB SDK)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Correction. Just add the wasm API you want to expose in your swagger config.json.


HA cluster communication failures

I'm getting a host of issues with communication between the nodes in my HA cluster.
This is a 3-node cluster running RHEL 7 (three separate VMs).
I've gone through the following steps to attempt to get this thing up, running and happy, but I'm still getting a lot of "context exceeded" errors in Calico.  I'm trying to get a POC set up for an HA deployment of dapr (http://dapr.io), but the unstable microk8s environment causes even more dramatic errors when adding deployments on top of the setup.
Mitigations attempted:

Followed the behind-the-proxy steps with /etc/environment changes
Configured containerd to use a Docker account to avoid the API metering problems (edits to /var/snap/microk8s/current/args/containerd-template.toml)
Overrode hostnames to lowercase
Configured NetworkManager to allow Calico to control interfaces (updates to /etc/NetworkManager/conf.d/calico.conf)
Disabled firewalld
Updated iptables using sudo iptables -P FORWARD ACCEPT

Inspection reports attached for all 3 nodes.  Any advice at all would be greatly appreciated
inspection-report-20210929_150321.tar.gz
inspection-report-20210929_150324.tar.gz
inspection-report-20210929_161420.tar.gz
.

Hi @Flern
Thanks for logging this one.  May i know what error you are facing?
Also just confirming your setup.
A 3 node microk8s.
With only coredns enabled
And then install dapr?
Another quick question, what happen if you disable HA, does it work?
Just a note it, this will nuke the cluster.

Hi @balchua
I get a variety of errors.  Most of the errors that I think point to the root problem have the "context deadline exceeded" language.
These are from the cluster-info-dump healthy indications:
Readiness probe failed: Get \"http://<IP_ADDRESS>:8181/ready\": context deadline exceeded (Client.Timeout exceeded while awaiting headers) Readiness probe failed: Error verifying datastore: Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations/default: context deadline exceeded; Error reaching apiserver: Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations/default: context deadline exceeded with http status code: 0 Readiness probe failed: Error reaching apiserver: taking a long time to check apiserver; Error verifying datastore: Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations/default: context deadline exceeded
And logs from calico-kube-controllers:
client.go 255: Error getting cluster information config ClusterInformation="default" error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations/default: context deadline exceeded main.go 203: Failed to verify datastore error=Get https://<IP_ADDRESS>:443/apis/crd.projectcalico.org/v1/clusterinformations/default: context deadline exceeded
Yes, that's the minimal setup I'm trying to achieve.  You can lose the 'dapr' installation - I get the same behavior with just the coredns enabled in the HA cluster.
I will disable HA and see if that changes the behavior.  I didn't think of that... that will go with etcd and flanneld, right?  Good idea!


Add function to only change table tags and table description

Fixed by https://github.com/ellipse-science/tube/pull/47


Only run DCO check job for PRs

Signed-off-by: Christophe Bedard<EMAIL_ADDRESS>

This only affects the DCO check job, so skipping all other CI jobs.


Replace slashes with hyphens

Handling slashes in branch names by replacing them with hyphens when generating tags for Docker images.
Example output tags after running the new version of the generate-docker-image-tags action on the branch sc-28060/testing/slashes/in/branches (see PR #29):

Awesome! Let there be branch "folders"!


handle missing type tag in relations

Coverage increased (+0.3%) to 92.727% when pulling cd946f5734173b1e14187fbc2d883e6b8cfa3661 on feature into 370901528c1709fa8af47ebb33ae1ba3282a67f4 on master.


Understand the Codebase and Create Documentation

Problem Statement
The current repository lacks detailed documentation that explains the codebase structure, functionality, and how different components interact. Although a Docs folder exists, it is underutilized and can be expanded to provide comprehensive technical documentation for the project.
Proposed Solution

Analyze the existing codebase (both frontend and backend).
Document the architecture, folder structure, and key functionalities.
Add a new markdown file in the Docs folder (e.g., Codebase.md) to centralize the technical documentation.

Task Details

Frontend Documentation:

Explain the purpose of each folder and file (e.g., components/, static/).
Describe the functionality of key Vue components such as NewPlayer.vue and App.vue.
Highlight the use of third-party dependencies like axios and fontawesome.

Backend Documentation:

Describe the folder structure, including files like server.js, Algorithm.js, and sqlconnect.js.
Provide details on API endpoints (/api/addPlayer, /api/teams, etc.) and their purpose.
Explain how database operations are handled via sqlconnect.js.

Setup Instructions:

Provide a step-by-step guide for setting up the frontend and backend locally, including required dependencies and environment variables.

Interaction Flow:

Illustrate how the frontend interacts with the backend and database using diagrams or text-based explanations.

File Structure Overview:

Include a tree-like directory structure to give users a high-level overview of the project organization.

Documentation Updates:

Keep placeholders or notes for future updates and features in the documentation.

Expected Deliverables

A new file in the Docs folder named Codebase.md with:

Detailed explanations of frontend and backend components.
Clear instructions for setting up the project locally.
An interaction flow and folder structure overview.

The Docs folder becomes a centralized location for all technical documentation.

Acceptance Criteria

A Codebase.md file is created in the Docs folder.
Documentation is complete, well-structured, and easy to understand.
Contributors can refer to the documentation for onboarding and development.

Resources

Markdown Guide
Vue.js Documentation
Express.js Documentation

Priority
High

Hey @TharunKumarrA  I am new to opensource can i take this up

Yes assigned @that-ar-guy


Integrate with released version of fuel-core beta-5 with the new flag

Once the new fuel-core is released with the correct stdouts we should test and integrate on this subgraph repo.

Deprecated


Suggestion: Better error messages

The issue:
Here is an example response:
{
  ...
  res: {
    ...
    data: {
      ...
        errors: [
          'Error: failed to send transaction: Transaction simulation failed: Error processing Instruction 1: invalid account data for instruction'
        ],
    },
  },
}

The SDK/API correctly tells me that there is an error when trying to process a payment. In this case the issue is that the destination address doesn't exist.
The problem is, the error message is far too long, and possibly subject to change. In our code, it is not realistic to write something like:
if (response.res.data.errors[0] === 'Error: failed to send transaction: Transaction simulation failed: Error processing Instruction 1: invalid account data for instruction') {
  console.log('Destination account doesn\'t exist!');
}

The solution:
It would be better if the client received an error from a known list of possible options. For example, the above example should return "DestinationNotFound" or something like that.
The existing Node SDK that uses Agora has the following error mesages:
    AccountExists,
    AccountDoesNotExist,
    Malformed,
    SenderDoesNotExist,
    DestinationDoesNotExist,
    InsufficientBalance,
    InsufficientFee,
    TransactionRejected,
    AlreadyPaid,
    WrongDestination,
    SkuNotFound,
    BadNonce,
    AlreadySubmitted,
    NoTokenAccounts,

Thanks @showered  for point it out.  I will work on this one next week.

Great suggestion. This is also related to #121

@showered in #287 we added initial support for better error handling. It should now give back messages like Insufficient funds or Account already exists.  Feel free to give it a go and let us know what you think!


Unpacking phyrox-esr-portable-win64-91.5.1-57.7z results in virus warning

Immediately after unpacking, I got this and the executable was quarantined.

Sometimes Antivirus scanner reports that a program is infected with a Virus or Trojan, even when the program is not really infected with any malicious code. This kind of problem is known as "False Positive". In other words, Antivirus companies cause a big headache to small developers.
As stipulated in the FAQ, those detections are generic. Most likely based on a heuristic detection and more prone to be false-positive and this happens quite often with programs written in Golang. The best you can do is to report this to your Antivirus software vendor as a false positive.
See also portapps/portapps#68 and https://github.com/search?q=org%3Aportapps+antivirus&type=Issues. Thanks for your support.


classifyMove Function

We need a function which computes properties of a given move. This will eventually be used as the first step in the pipeline of converting a move in the frontend into commands for robots to drive - in particular, it tells us which pattern we're currently executing.

Create an interface (or a class?), Move, which has the following properties:
An enum named MoveType saying the type of move:
LINEAR, (i.e. horizontal or vertical shift)
DIAGONAL,
KNIGHT,
CASTLE
A boolean named capture which says whether the move is a capture.

Write a function named classifyMove which takes two Squares and a PieceManager as arguments and returns a Move.
You may assume the move is valid; if it is not, you should throw an error.

Talk to Alex and/or Colin about writing tests for your function.

Ticket is now in draft until it is updated to fit the task request format, or is finished


Add London bike app

Santander Cycles are the official street bikes in London. But they're normally called Boris Bikes as he was the mayor at the time they were introduced. They were literally the only good thing he's ever done, and they were Ken Livingstone's idea anyway.
Features counts for e-bikes, which is very bleeding edge state of the art, as they've only just started introducing them last week. Also features a terrible drawing by me.

I think the drawing looks great! Thanks for yet another useful, readable and easy to review app!


Updated SHIR scale-out information

Customers have asked for transparency as to which algorithm is used to distribute jobs across a cluster of nodes. Information was provided by Abhishek Narain.

Learn Build status updates of commit 4b3a261:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/data-factory/create-self-hosted-integration-runtime.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@lrtoyou1223

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks for your submission to help us improve the ADF docs!  I merged this change now.  #please-close


XML parsing dependency migration

I'm raising this issue as suggested by @XiaoningLiu
Is your feature request related to a problem? Please describe.
Not exactly. But for improvements.
Describe the solution you'd like
We're currently dependent on xml2js library to parse XML. Fast-XML-Parser is a better alternative to this.
Additional context
Here is the comparison of both packages to parse XML data.

file size
fxp 3.0 parser (rps)
xml2js 0.4.19 (rps)

1.5k
14032.09323
4615.930805

1.5m
13.23366098
5.90682005

13m
1.135582008
-1

1.3k with CDATA
43160.52342
8398.556349

1.3m with CDATA
52.68877009
7.966000795

1.6k with cdata,prolog,doctype
41433.98547
7872.399268

98m
0.2600104004
-1

In the below chart, X-axis is about XML data size, and Y-axis is for throughput or number of parses per second.

@xirzec, @jeremymeng, @joheredi Thoughts here?

I had given fxp a try but it seems non-trivial to replace xml2js as fxp doesn't provide similar settings to those of xml2js that we used.  However if we could make fxp work and if it doesn't have the circular reference issue, then it would be great to the React-Native story.


Fix issues with iOS on reinstall

Description

Questions
Answers

Why?
After reinstalling the statistics plugin the "legs" entry in the bot-blacklist will exclude iOS devices from the shop functionalities

BC breaks?
no

Tests exists & pass?
yes

Related tickets?
SW-15730

How to test?
Reinstall the plugin and check the blacklist in the basic settings

Requirements met?
Does your PR fulfil our contribution requirements?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19464.
Please use this issue to track the state of your pull request.

Hi @mnaczenski,
we merged your pull request and the changes will be available in version 5.3.5


Upgrade Deno from v2.0.2 to v2.1.0

Here are some good reasons to upgrade to newest Deno:

Deno 2.1 is (or will be) the first ever LTS version of Deno

7% speedier?

Simple Bash script I'm using to benchmark this:
#!/bin/bash

set -euxo pipefail

hyperfine_jobs=()
for v in 2.0.6 2.1.0; do
    deno clean
    deno upgrade $v
    deno task compile
    mv pkgx pkgx-deno-$v
    hyperfine_jobs+=("./pkgx-deno-$v<EMAIL_ADDRESS>--version")
done

exec pkgx hyperfine --warmup 2 --shell none --runs 50 "${hyperfine_jobs[@]}"

deno 2.1.0 build currently failing for linux/aarch64; fix in research. https://github.com/pkgxdev/pantry/actions/runs/11946529159/job/33301044063

deno 2.1.0 build currently failing for linux/aarch64; fix in research. pkgxdev/pantry/actions/runs/11946529159/job/33301044063

Ops, got it.
I am also investigating another issue. I was expecting a much better startup time with Deno 2.1.0:

https://github.com/denoland/deno/pull/26528#issuecomment-2491735952

looks like the build worked for 2.1.1, so i'm guessing their changes fixed it.

Strictly ^2.0.2 will use 2.1.1 if available.

Hmm didn't mean to close this.

Maybe it would be a good idea to have full control over Deno's version. It would make the changelog easier and also improve reproducibility.
But anyway, whatever you prefer. What really matters is that the new Deno version is used.
@mxcl, slightly related, deno compile now has an --include flag to embed arbitrary files. Maybe it would be useful to embed the SQLite binary?


Merge by develop

Coverage remained the same at 98.63% when pulling 12d77e4102e26b2ae4302b870257aade2cf1472b on develop into cc38461f3d197d6ef4d463a48f546e19b123a6a9 on master.

Coverage remained the same at 98.63% when pulling 12d77e4102e26b2ae4302b870257aade2cf1472b on develop into cc38461f3d197d6ef4d463a48f546e19b123a6a9 on master.

Coverage remained the same at 98.63% when pulling 12d77e4102e26b2ae4302b870257aade2cf1472b on develop into cc38461f3d197d6ef4d463a48f546e19b123a6a9 on master.


Allow to set comfortably inet_protocols

Setting inet_protocols = ipv4 is almost a requirement when running behind Docker. Provide a way to make it easy.
@Tecnativa TT22925

Please could you help with travis? I don't understand those logs... :confused:

I restarted the test, but that kind of error indicates a major problem of some sort. It didn't even start to run the tests but failed very early.

Then what should I do?

The best would be if you could reproduce locally. However, I'm curious as to why you need this? Most if not all seem to be running fine without it. My docker image does not have ipv6 addresses even though the host sports them. Are you using host networking for some reason?

No, I'm using docker networks inside a docker container. However, I found some logs of a blocked server that was attempting to contact smtp.gmail.com with ipv6, although the container itself didn't have any ipv6 networks. However, if you run postconf -p mynetworks, you'll see some ipv6 networks that seem to make postfix believe it can use ipv6 normally.
Adding this setting saved my day, so I just wanted to make it easier for everyone in my situation. I use this image just as a local relay in this scenario.
Actually I believe ipv4-only should be the default, but I decided to not touch the default to avoid breaking others'.
I found a bug, let's see if CI works now.

:heavy_check_mark: now.

Great. One small request though. The current code sets the value "all" by default. That is not strictly backwards compatible. The old code did not touch the setting. Small thing but it can make a difference when it interacts with people's custom configuration.
Can you add an empty (or "default") option that is the default and skip the postconf command entirely unless the new option is set, please? Otherwise it looks fine.

Well I just imitated the way it was done for other settings. If someone overwrites the setting in postfix-main.cf it should work just like with any other, isn't it? :thinking:

Something like that in target/start-mailserver.sh:
if [ "$POSTFIX_INET_PROTOCOLS" != "all" ]; then
	_register_setup_function "_setup_inet_protocols"
fi

This ensures, that nothing is changed in a already running setup.

OK, done.


Fast, fail-safe and possibly async detach methods

Issue Type
[v] Improvement
[v] Performance
Description and/or steps/code to reproduce the problem
As stated in #776 regarding detach methods:

they should run very fast, as they're supposed to be called at critical moments (like an Activity being destroyed)
we should implement fail-safe code
possibly run async when the code may take time

The idea is to check if all detach methods match these criteria and fix them if necessary.
Version of osmdroid the issue relates to:
6.0.0

Possibly 100% covered by #908 regarding tile memory cache.

Closing this issue: I just had a look at the detach methods but couldn't find anything slow enough.


Chapter 20.7 and 20.8 have mismatching function names and titles

In Chapter 20.7, we have "Read Channel Attribute", but the function signature says "sbi_mpxy_read_attributes".
I don't know what is correct, I implemented it as of now as "read attributes", because that's what the text says too.
Chapter 20.8 has the same error (but "write channel attributes" instead of "read channel attributes").

Function signatures matters. Though we still have time to correct the title. "Read Channel Attributes". Same for "Write Channel Attributes". If you want you can raise the PR.

Okay, will do that.


Update tutorial-two-java.md

word error

@steven-wan Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@steven-wan Thank you for signing the Contributor License Agreement!


[Feature Request] esp32s3 support

Is esp32s3 support planned?

Hi @thomasklaush,
Sorry for the late reply. I cannot answer whether or not esp32s3 support is planned for this repository, but we do have a repository that currently works with the C3, that I believe could easily be made to work with an s3. Here is the repo: https://github.com/FreeRTOS/iot-reference-esp32c3. At the top of this file, you should be able to just remove the 3 lines from the top: CONFIG_IDF_TARGET_ARCH_RISCV=y
CONFIG_IDF_TARGET="esp32c3"
CONFIG_IDF_TARGET_ESP32C3=y
Then run:
idf.py set-target esp32s3, then follow the getting started guide.
I have not actually tested this because I have not been able to get my hands on an s3, but I think this should work. Alternatively, we recently partnered with espressif to update their esp-aws-iot repo. Every one of the folders inside the libraries folder of this repo can be dragged into an ESP-IDF project as a component to add any of our AWS libraries - they are also all configurable from ESP-IDF's menuconfig. This repo also offers examples that should work with the s3 in the examples folder.
Best,
Jason Carroll

Hi @jasonpcarroll,
thank you for your response.
I get some eval boards soon, I will try.
Best regards,
Thomas

@thomasklaush
Hope this answers your question. I will close the issue. Feel free to open issues if you have further questions.


[Cosmos] Update versions for release

Forgot the date.

API change check
API changes are not detected in this pull request.


HBASE-24000 Simplify CommonFSUtils after upgrading to hadoop 2.10.0

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  6s
master passed

+1 :green_heart:
checkstyle
1m 52s
master passed

-1 :x:
spotbugs
2m  8s
hbase-server in master has 1 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 52s
the patch passed

-0 :warning:
checkstyle
0m 23s
hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 28s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
4m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

46m 24s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 70e73e676523 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcfd6a4a8

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m 56s
the patch passed

+1 :green_heart:
compile
2m 56s
the patch passed

+1 :green_heart:
javac
2m 56s
the patch passed

-1 :x:
shadedjars
0m 15s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 29s
hbase-procedure in the patch failed.

-0 :warning:
javadoc
1m  9s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 12s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 27s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
135m 52s
hbase-server in the patch passed.

174m 45s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5024cb9be257 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcfd6a4a8

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/testReport/

Max. process+thread count
3970 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 10s
master passed

+1 :green_heart:
compile
1m 40s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 10s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m  1s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
5m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 22s
hbase-common in the patch passed.

-1 :x:
unit
0m 38s
hbase-procedure in the patch failed.

-1 :x:
unit
143m  1s
hbase-server in the patch failed.

178m 26s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ab724df8276b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcfd6a4a8

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-procedure.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/testReport/

Max. process+thread count
4127 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

TestWALProcedureStore passes for me locally. Looks like the test could be written a little more defensively to hand reruns. In this particular case, it seems reruns were blocked because the first invocation didn't delete it's directory, and the same directory path is reused over and over. It's not obvious to me why the first run failed, and there's no additional stack trace depth in the test logs.
  <testcase name="testLogFileAleadExists" classname="org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore" time="0.967">
    <error message="java.io.IOException: Stream Closed" type="org.apache.hadoop.fs.FSError"><![CDATA[org.apache.hadoop.fs.FSError: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.tearDown(TestWALProcedureStore.java:104)
Caused by: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.tearDown(TestWALProcedureStore.java:104)
]]></error>
    <system-err><![CDATA[2020-03-24 03:59:21,445 INFO  [Time-limited test] hbase.ResourceChecker(179): after: procedure2.store.wal.TestWALProcedureStore#testProcIdHoles Thread=8 (was 8), OpenFileDescriptor=89 (was 89), MaxFileDescriptor=1048576 (was 1048576), SystemLoadAverage=1007 (was 1007), ProcessCount=22 (was 22), AvailableMemoryMB=26738 (was 26789)
2020-03-24 03:59:21,453 INFO  [Time-limited test] hbase.ResourceChecker(151): before: procedure2.store.wal.TestWALProcedureStore#testLogFileAleadExists Thread=8, OpenFileDescriptor=89, MaxFileDescriptor=1048576, SystemLoadAverage=1007, ProcessCount=22, AvailableMemoryMB=26736
2020-03-24 03:59:21,469 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:21,476 INFO  [Time-limited test] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=1
2020-03-24 03:59:21,477 DEBUG [Time-limited test] wal.WALProcedureStore(436): Lease acquired for flushLogId=1
2020-03-24 03:59:21,477 DEBUG [Time-limited test] wal.WALProcedureStore(454): No state logs to replay.
2020-03-24 03:59:21,482 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=2
2020-03-24 03:59:21,483 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1221): Remove all state logs with ID less than 1, since no active procedures
2020-03-24 03:59:21,483 DEBUG [WALProcedureStoreSyncThread] wal.WALProcedureStore(1243): Removed log=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/c0fb2ae6-9b4d-e64a-6ae8-b8746f2e897c/proc-logs/pv2-00000000000000000001.log, activeLogs=[/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/c0fb2ae6-9b4d-e64a-6ae8-b8746f2e897c/proc-logs/pv2-00000000000000000002.log]
2020-03-24 03:59:22,393 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:22,395 WARN  [Time-limited test] wal.WALProcedureStore(1370): Remove uninitialized log: DeprecatedRawLocalFileStatus{path=file:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/c0fb2ae6-9b4d-e64a-6ae8-b8746f2e897c/proc-logs/pv2-00000000000000000002.log; isDirectory=false; length=0; replication=1; blocksize=33554432; modification_time=1585022361000; access_time=1585022361474; owner=; group=; permission=rw-rw-rw-; isSymlink=false}
2020-03-24 03:59:22,402 INFO  [Time-limited test] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=3
2020-03-24 03:59:22,403 DEBUG [Time-limited test] wal.WALProcedureStore(436): Lease acquired for flushLogId=3
2020-03-24 03:59:22,403 INFO  [Time-limited test] wal.WALProcedureStore(330): Stopping the WAL Procedure Store, isAbort=false
]]></system-err>
    <rerunError message="java.io.IOException: Stream Closed" type="org.apache.hadoop.fs.FSError">
      <stackTrace><![CDATA[org.apache.hadoop.fs.FSError: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.testLogFileAleadExists(TestWALProcedureStore.java:687)
Caused by: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.testLogFileAleadExists(TestWALProcedureStore.java:687)
]]></stackTrace>
      <system-err><![CDATA[2020-03-24 03:59:24,459 INFO  [Time-limited test] hbase.ResourceChecker(151): before: procedure2.store.wal.TestWALProcedureStore#testLogFileAleadExists Thread=9, OpenFileDescriptor=91, MaxFileDescriptor=1048576, SystemLoadAverage=1054, ProcessCount=22, AvailableMemoryMB=26379
2020-03-24 03:59:24,466 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:24,468 INFO  [Time-limited test] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=1
2020-03-24 03:59:24,469 DEBUG [Time-limited test] wal.WALProcedureStore(436): Lease acquired for flushLogId=1
2020-03-24 03:59:24,469 DEBUG [Time-limited test] wal.WALProcedureStore(454): No state logs to replay.
2020-03-24 03:59:24,480 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=2
2020-03-24 03:59:24,480 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1221): Remove all state logs with ID less than 1, since no active procedures
2020-03-24 03:59:24,481 DEBUG [WALProcedureStoreSyncThread] wal.WALProcedureStore(1243): Removed log=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/8f7fbc71-2e3e-2dbf-99cd-0c61da4671c4/proc-logs/pv2-00000000000000000001.log, activeLogs=[/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/8f7fbc71-2e3e-2dbf-99cd-0c61da4671c4/proc-logs/pv2-00000000000000000002.log]
2020-03-24 03:59:24,481 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:24,482 WARN  [Time-limited test] wal.WALProcedureStore(1370): Remove uninitialized log: DeprecatedRawLocalFileStatus{path=file:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/8f7fbc71-2e3e-2dbf-99cd-0c61da4671c4/proc-logs/pv2-00000000000000000002.log; isDirectory=false; length=0; replication=1; blocksize=33554432; modification_time=1585022364000; access_time=1585022364466; owner=; group=; permission=rw-rw-rw-; isSymlink=false}
2020-03-24 03:59:24,486 INFO  [Time-limited test] wal.WALProcedureStore(330): Stopping the WAL Procedure Store, isAbort=false
]]></system-err>
    </rerunError>
    <rerunError message="java.io.IOException: Stream Closed" type="org.apache.hadoop.fs.FSError">
      <stackTrace><![CDATA[org.apache.hadoop.fs.FSError: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.testLogFileAleadExists(TestWALProcedureStore.java:687)
Caused by: java.io.IOException: Stream Closed
	at org.apache.hadoop.hbase.procedure2.store.wal.TestWALProcedureStore.testLogFileAleadExists(TestWALProcedureStore.java:687)
]]></stackTrace>
      <system-err><![CDATA[2020-03-24 03:59:24,545 INFO  [Time-limited test] hbase.ResourceChecker(151): before: procedure2.store.wal.TestWALProcedureStore#testLogFileAleadExists Thread=9, OpenFileDescriptor=92, MaxFileDescriptor=1048576, SystemLoadAverage=1054, ProcessCount=21, AvailableMemoryMB=26507
2020-03-24 03:59:24,553 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:24,556 INFO  [Time-limited test] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=1
2020-03-24 03:59:24,556 DEBUG [Time-limited test] wal.WALProcedureStore(436): Lease acquired for flushLogId=1
2020-03-24 03:59:24,556 DEBUG [Time-limited test] wal.WALProcedureStore(454): No state logs to replay.
2020-03-24 03:59:24,559 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1134): Rolled new Procedure Store WAL, id=2
2020-03-24 03:59:24,560 INFO  [WALProcedureStoreSyncThread] wal.WALProcedureStore(1221): Remove all state logs with ID less than 1, since no active procedures
2020-03-24 03:59:24,561 DEBUG [WALProcedureStoreSyncThread] wal.WALProcedureStore(1243): Removed log=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/dd76aeb2-fe62-be76-3273-d13f409d446f/proc-logs/pv2-00000000000000000001.log, activeLogs=[/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/dd76aeb2-fe62-be76-3273-d13f409d446f/proc-logs/pv2-00000000000000000002.log]
2020-03-24 03:59:24,561 DEBUG [Time-limited test] wal.WALProcedureStore(401): Starting WAL Procedure Store lease recovery
2020-03-24 03:59:24,561 WARN  [Time-limited test] wal.WALProcedureStore(1370): Remove uninitialized log: DeprecatedRawLocalFileStatus{path=file:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-procedure/target/test-data/dd76aeb2-fe62-be76-3273-d13f409d446f/proc-logs/pv2-00000000000000000002.log; isDirectory=false; length=0; replication=1; blocksize=33554432; modification_time=1585022364000; access_time=1585022364554; owner=; group=; permission=rw-rw-rw-; isSymlink=false}
2020-03-24 03:59:24,567 INFO  [Time-limited test] wal.WALProcedureStore(330): Stopping the WAL Procedure Store, isAbort=false
]]></system-err>
    </rerunError>
  </testcase>

TestWALEntryStream looks like it read partial data,
2020-03-24 05:12:43,671 INFO  [Listener at localhost/38169] wal.AbstractFSWAL(756): Rolled WAL /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/8b31e9c5-e403-a068-d9ff-fc56f5c00237/WALs/testDifferentCounts/testDifferentCounts.1585026756453 with entries=1500, filesize=184.53 KB; new WAL /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1335/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/8b31e9c5-e403-a068-d9ff-fc56f5c00237/WALs/testDifferentCounts/testDifferentCounts.1585026763520
2020-03-24 05:12:43,672 DEBUG [Listener at localhost/38169] wal.AbstractFSWAL(845): Create new AsyncFSWAL writer with pipeline: [DatanodeInfoWithStorage[<IP_ADDRESS>:34733,DS-4271f034-e4f9-408c-9869-e101eb00f24c,DISK], DatanodeInfoWithStorage[<IP_ADDRESS>:43925,DS-4f6145c8-5eca-4ff4-afe6-b84495802210,DISK], DatanodeInfoWithStorage[<IP_ADDRESS>:40637,DS-e9928388-d36b-42de-bb16-1925e01cd86f,DISK]]
2020-03-24 05:12:44,270 WARN  [Listener at localhost/38169] wal.ProtobufLogReader(426): Encountered a malformed edit, seeking back to last good position in file, from 188958 to 188957
java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=188958
	at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:369)
	at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98)
	at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:86)
	at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:263)
	at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)
	at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101)
	at org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream.testDifferentCounts(TestWALEntryStream.java:169)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  6s
master passed

+1 :green_heart:
checkstyle
1m 51s
master passed

+1 :green_heart:
spotbugs
3m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 53s
the patch passed

-0 :warning:
checkstyle
0m 24s
hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 55s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
3m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

50m  5s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 059d23b13054 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eed730e492

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m  4s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
6m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 19s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 44s
the patch passed

+1 :green_heart:
compile
2m  2s
the patch passed

+1 :green_heart:
javac
2m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 19s
hbase-common in the patch passed.

-1 :x:
unit
0m 41s
hbase-procedure in the patch failed.

+1 :green_heart:
unit
102m  0s
hbase-server in the patch passed.

142m 46s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ce163234bf1b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eed730e492

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-procedure.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/testReport/

Max. process+thread count
4162 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  5s
the patch passed

+1 :green_heart:
compile
1m 59s
the patch passed

+1 :green_heart:
javac
1m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 41s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 16s
hbase-procedure in the patch failed.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 37s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
110m  2s
hbase-server in the patch passed.

157m 19s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ac1fbbdc10dd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eed730e492

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/testReport/

Max. process+thread count
4171 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Seems TestWALProcedureStore is broken... Anyway let me see how to fix it...

The test is strange, we wrap a already created procedure store with mockito and then call the recoverLease method again. Not sure why but after calling the real method of the procStore, the current stream is still fine but after we returned from the method of the mocked instance, the current stream has already been closed and cause the test to fail.
Since the class is only used for data migration and will be removed in 4.0.0, do not want to spend much time on it. Just catch the FSError exception when closing...

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 36s
master passed

+1 :green_heart:
checkstyle
1m 47s
master passed

+1 :green_heart:
spotbugs
3m 13s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 22s
the patch passed

-0 :warning:
checkstyle
0m 22s
hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  0s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
3m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

41m 56s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 0fb88ac35eea 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 76e3db6720

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  2s
master passed

+1 :green_heart:
compile
1m 43s
master passed

+1 :green_heart:
shadedjars
5m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 11s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 55s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

+1 :green_heart:
shadedjars
5m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 41s
hbase-procedure in the patch passed.

-1 :x:
unit
16m 59s
hbase-server in the patch failed.

51m 50s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4b00781154a9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 76e3db6720

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/testReport/

Max. process+thread count
916 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  1s
the patch passed

+1 :green_heart:
compile
1m 57s
the patch passed

+1 :green_heart:
javac
1m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 16s
hbase-procedure in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 36s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
100m 43s
hbase-server in the patch passed.

140m 47s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1335

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 26e338b4e269 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 76e3db6720

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/testReport/

Max. process+thread count
4150 (vs. ulimit of 10000)

modules
C: hbase-common hbase-procedure hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1335/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


[ios] [metal] Profile mode Metal API Validation Errors

Following errors are being hit:
2021-03-08 15:57:10.693070-0600 Runner[46398:11504702] flutter: Observatory listening on http://<IP_ADDRESS>:62200/TVd6mSApTOc=/
2021-03-08 15:57:10.973359-0600 Runner[46398:11504692] -[MTLDebugRenderCommandEncoder validateFramebufferWithRenderPipelineState:], line 1288: error 'Framebuffer With Render Pipeline State Validation
For stencil attachment, the render pipeline's pixelFormat (MTLPixelFormatInvalid) does not match the framebuffer's pixelFormat (MTLPixelFormatStencil8).
'
-[MTLDebugRenderCommandEncoder validateFramebufferWithRenderPipelineState:]:1288: failed assertion `Framebuffer With Render Pipeline State Validation
For stencil attachment, the render pipeline's pixelFormat (MTLPixelFormatInvalid) does not match the framebuffer's pixelFormat (MTLPixelFormatStencil8).
'

Repro instructions:

From CLI, in <framework>/dev/benchmarks/macrobenchmarks run flutter run -d <ios_device> --profile.
Quit the above command once the required ios/Runner.xcworkspace file is generated.
Run ios/Runner.xcworkspace from xcode. You hit the above errors.

When I go to Edit Schemes > Run > Diagnostics > Disable Metal API Validation the run succeeds.
Hit this while trying to repro: https://github.com/flutter/flutter/issues/77404

From CLI, in <framework>/dev/benchmarks/macrobenchmarks run flutter run -d <ios_device> --profile.
Quit the above command once the required ios/Runner.xcworkspace file is generated.

P.S. you can run flutter build ios --config-only to generate all the necessary files and build settings, but not actually compile anything.

Duplicate of https://github.com/flutter/flutter/issues/77397.


[FEATURE] how to get the value of tag

I write code like this
tagR = system.tag.readBlocking(['[default]xxx/xxx/xxx/xxx'])
tagR0=tagR[0]
testValue =tagR0.getValue()
print(tagR0.getValue())
but I get the value is java.lang.object  ,how to convert it to the python base type ?

Hello @xiahui1986,
Since the purpose of this library is to allow code completion, it does not provide the same functionality as running the code on the Ignition Designer or Script Console.
Hopefully this solves your question.


MDNavigationDrawer state

Just a quick question.
In previous versions, I there was an MDNavigationDrawer.panel.state that I could check, to see if the MDNavigationDrawer was open, so I would close it (e.g. when pressing the back button).
Trying to use the MDNavigationDrawer.__state does not work in the same way.
It gives me a very strange error:
AttributeError: 'MDNavigationDrawer' object has no attribute '_Base__state'
Base is my root class, but I don't know how it gets there..
Versions

OS: Win7x64 SP1
Python: 3.7.2
Kivy: 1.11.1
KivyMD: 0.103.0

@noembryo You do not need to check if the panel is open or closed. Just call the toggle_nav_drawer  method - it will open or close the panel itself, depending on the state
https://github.com/HeaTTheatR/KivyMD/blob/master/kivymd/uix/navigationdrawer.py#L292

Yes, but I don't want to open it if I press the back button for some other reason...

@noembryo I don't understand what you mean...

When I'm on the main page of an app and the MDNavigationDrawer is open, I want to close it by pressing the back button.
If the MDNavigationDrawer is closed, pressing the back button should exit the app, not re-open the MDNavigationDrawer...

@noembryo https://github.com/HeaTTheatR/KivyMD/commit/11807153bc04ec464702498ca95c9551a1bba63c

Great, thank you!

im looking for these properties as well... how would i open and close the nav drawer from python...
also i have set the same properties as the nav drawer has like
swipe_edge_width =  NumericProperty
elevation = NumericProperty
enable_swiping = BooleanProperty
swipe_edge_width = NumericProperty
set_state = StringProperty
but i just cant create or find the class to change these via a python function
thanx


make tests work with iojs-v3

We need to upgrade the hiredis dependency once this is merged:
https://github.com/redis/hiredis-node/pull/96

0.4.1 is released with iojs v3 support pushed \o/

see: https://github.com/NodeRedis/node_redis/pull/800


add support for Chef::Mixin::shellout

This makes it so when folks include Chef::Mixin::ShellOut in their libraries that it's properly catches any unstubbed calls to #shell_out.

@jasonwbarnett do you happen to know if this is currently exercised by any specs?

@tpowell-progress I'm pretty sure the answer is no, sadly.


Add -testable-import-module frontend flag (+ refactoring)

This PR has two functional changes:

Implicit imports specified using the -import-module flag are now processed by import resolution. This means they are fully validated and cross-imported. The -import-underlying-module flag is now also processed via this route, and it gets the same benefits (for what they're worth).
There is now a -testable-import-module frontend flag to match -import-module. As you might guess, this adds an implicit @testable import to every file, instead of an implicit ordinary import.

Those two functional changes are in the last two commits; they represent maybe 5% of the changes here. The other 95% of the PR enables these changes by refactoring the data types used to represent imports:

Centralizes more import-related types in AST/Import.h.
Creates one common currency type representing "an import with all of the options and attributes that can be specified by a user" and adopts it everywhere relevant. The new type can be used with either an unloaded module's name or a loaded module.
Allows the full range of import options through more of import resolution handling.

Fixes rdar://66544654.

Review suggestions: Probably best reviewed by commit. A lot of commits (especially the first one) are very mechanical, with lots of boring renaming at use sites. You can probably skim those bits. The commit messages may give some guidance on this.
The reason for a given change is not always clear until several commits later. In particular:

We un-nest and move types related to ModuleDecl::ImportedModule and SourceFile::ImportedModuleDesc because types currently in these two headers will become interdependent by the time we're finished.
We make AttributedImport a template because we will eventually use both the existing ImportedModule and a new type with a module name and access path instead. The template lets us have three types instead of four or five.
We introduce the ImplicitImportList type which just wraps ArrayRef<ImplicitImport> because (a) shifting to AttributedImport will complicate its definition enough to require a type, and (b) introducing that type at the outset avoids multiple rounds of renaming several use sites.
We start using AttributedImport in implicit imports to (a) allow the frontend to specify additional behaviors, and (b) make it easier to shift responsibility for loading implicit imports into ImportResolver.
We make ImportResolver resolve implicit imports because (a) this makes it validate the implicit @testable attribute added by -testable-import-module, and (b) it simplifies the code and is the right way to do things anyway.

@hamishknight, you worked a lot on import resolution recently and might have some opinions about what I'm doing. @CodaFi, you're most likely familiar with Hamish's work, but unlike him you're currently working on the compiler full-time. @varungandhi-apple, you clearly have opinions about names in this area.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 3a60f09cf3929cef82cef2aa5f92dab050790d5b

Build failed
Swift Test OS X Platform
Git Sha - 3a60f09cf3929cef82cef2aa5f92dab050790d5b

@swift-ci please smoke test

[snip]/llvm-project/lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp:1192:16: error: no member named 'AdditionalModules' in 'swift::ImplicitImportInfo'
20:08:25     importInfo.AdditionalModules.emplace_back(module, /*exported*/ false);
20:08:25     ~~~~~~~~~~ ^

Of course, I’ll need to update this.

With apple/llvm-project#1937
@swift-ci please smoke test


⚠ ClamAV has degraded performance

In 522197a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 191 ms

Resolved: ClamAV performance has improved in 486bc0e.


bump clap and use crate_version macro

There is also a crate_authors macro that can be used in a similar way

@humancalico Looks good, but you need to run cargo fmt

@humancalico hmm. There was some kind of suspicious log on the CI and it was taking quite a while to test. I'd like to confirm, did the test passed on your machine?

@utam0k the tests are kinda flaky. On three different runs I got different results each time and different tests failing

I create the PR to fix the unstable tests.
https://github.com/containers/youki/pull/267
However, I have a feeling that this error of ci at this PR is something different.

The test_run_hook function is failing for me right now
running 29 tests
test container::state::tests::test_create_status ... ok
test container::container::tests::test_set_id ... ok
test container::container::tests::test_basic_getter ... ok
test container::state::tests::test_creating_status ... ok
test container::state::tests::test_running_status ... ok
test capabilities::tests::test_reset_effective ... ok
test container::state::tests::test_paused_status ... ok
test container::state::tests::test_stopped_status ... ok
test hooks::test::test_run_hook_timeout ... ignored
test namespaces::tests::test_apply_namespaces ... ok
test hooks::test::test_run_hook ... FAILED
test process::init::tests::test_cleanup_file_descriptors ... ok
test process::init::tests::test_get_open_fds ... ok
test signal::tests::test_conversion_from_string_should_be_failed ... ok
test process::channel::tests::test_channel_id_mapping_ack ... ok
test signal::tests::test_conversion_from_string ... ok
test utils::tests::test_get_cgroup_path ... ok
test utils::tests::test_join_absolute_path ... ok
test utils::tests::test_join_absolute_path_error ... ok
test utils::tests::test_parse_env ... ok
test process::channel::tests::test_channel_init_graceful_exit ... ok
test process::channel::tests::test_channel_init_ready ... ok
test process::channel::tests::test_channel_intermadiate_ready ... ok
test process::channel::tests::test_channel_intermedaite_graceful_exit ... ok
error: test failed, to rerun pass '--lib'
h

@humancalico We have some problems with code coverage right now, so we have disabled it until further investigation. Please rebase and try again.

@Furisto still getting the same failure

lgtm


”Târnava”, ”Colonia Târnava” are listed in the drop-down menu

Description:
When user writes ”Târnava”, ”Colonia Târnava” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Târnava"

Expected results
The location appears in the drop-down menu as "Sat Târnava, SIBIU (Târnava)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Colonia Târnava"

Expected results
The location appears in the drop-down menu as "Sat Colonia Târnava, SIBIU (Târnava)".


Azure_CLI for local dev gives Access is denied: 'C:\Windows\system32\config\systemprofile\.azure'

[X] bug report -> please search issues before submitting
[ ] feature request
[X] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

### Minimal steps to reproduce
> I have the AZ CLI open,  az account get-access-token shows the right account, Visual Studio running as admin, but the CLI validation fails with

PermissionError: [WinError 5] Access is denied: 'C:\\Windows\\system32\\config\\systemprofile\\.azure'

### Any log messages given by the failure
> NO

### Expected/desired behavior
> it gets my token from Azure CLI

### OS and Version?
> Windows 10 Enterprise v 1809
### Versions
>

### Mention any other details that might be useful
Please document how to troubleshoot this error.

> ---------------------------------------------------------------
> Thanks! We'll be in touch soon.

Any update on this issue?

I am facing the same issue.

Trying to open cmd and executing azure cli commands through c#, Getting below error
Traceback (most recent call last):
File "runpy.py", line 194, in _run_module_as_main
File "runpy.py", line 87, in _run_code
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/main.py", line 38, in
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/init.py", line 903, in get_default_cli
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/azlogging.py", line 30, in
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 25, in
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/extension/init.py", line 18, in
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/config.py", line 40, in init
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/util.py", line 115, in ensure_dir
File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/util.py", line 112, in ensure_dir
File "os.py", line 223, in makedirs
PermissionError: [WinError 5] Access is denied: 'C:\windows\system32\config\systemprofile\.azure'


Permalinks allowing to view drafts of specific pages

UseCase:
Show Drafts to Stakeholder who shall not have editing access. E.g. Klimaschutzmanager
It would be nice to have hash-based permalinks, e.g. https://monitoring.localzero.net/aFLelX4rFljWAF/, which point to the same city/task even if they are renamed and allow access, even if they are in draft mode.

[ ] Add a model for a hash-based link for each page (city, task, checklists, ...?). Separate table is probably best.
[ ] Offer these links in the admin to be copied.
[ ] Add route for these links to urls.py to show the correct page.
[ ] Ensure the page is shown when accessed via such a link, even if it is in draft mode and no user is logged in. django.auth needs to be handled here.

Advantages, if the browser URL stays at the link:

The external user can copy the link from the browser URL and will have access again.
The task below might be easier.

Optional / later issues:

[ ] Allow user to navigate to pages below this page. E.g. from city to tasks to sub-tasks, ... (unclear, how)

My initial attempt is useless, since a view-only-user still has access to the admin and can therefore view internal fields and she/he can see all other cities. I will close the MR.


Adding new GUI, changes in Documentation and Shortcuts

Adding a new GUI based on PySimpleGUI.

Thank you!


Use ConfirmationTarget::Background to claim settle TX outputs

There is actually no protocol pressure to claim these outputs quickly, so it seems foolish to pay a possibly very high price for these claim transactions.
See https://github.com/get10101/rust-dlc/commit/906cb4d422dbd90bf2fe35991f2a709801c250e7.

Going ahead with the merge to prepare another app release.


Emojis do not display when sending SMS

Thanks for the Java API, it was very handy for getting an SMS framework up and running.
However, I've tried sending emojis using unicode characters in Java (e.g. \uD83D\uDE00) and they show up as a blank space in the SMS message.
This type of encoding works with other APIs for SMS and push notifications (FireBase and Twilio for example).  Any pointers on handling emojis with this API/code?
Thank you!

Hi @mwiley63
Thank you for contacting us!
We are not supporting emojis. We support normal GSM characters to be sent via SMS and to support emojis we need unicode character support which we don't offer as of now.
Reagrds
SendinBlue Team

Thanks for the explanation!