Crashes with accessing Help > Release Notes

Issue Type: Bug
On my Mac, 50% chance of VSC crashing when accessing Help > Release notes menu item with the mouse.
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:29:22.216Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.87GB free)

Process Argv
-psn_0_1651091

Screen Reader
no

VM
0%

Extensions (14)

Extension
Author (truncated)
Version

Bookmarks
ale
10.4.4

vscode-color
ans
0.4.5

npm-intellisense
chr
1.3.0

vscode-markdownlint
Dav
0.28.0

vscode-eslint
dba
1.9.0

EditorConfig
Edi
0.13.0

beautify
Hoo
1.5.0

remote-containers
ms-
0.59.0

remote-ssh
ms-
0.42.2

remote-ssh-edit
ms-
0.42.2

remote-ssh-explorer
ms-
0.42.2

remote-wsl
ms-
0.38.0

vscode-remote-extensionpack
ms-
0.15.0

Go
ms-
0.11.0

(1 theme extensions excluded)

Is it possible to provide any crash related logs or info to know where the crash happens? You can also follow this wiki https://github.com/microsoft/vscode/wiki/Native-Crash-Issues

Code Helper_2019-06-26-101732_Lees-MacBook-Pro.crash.txt
Electron_2019-06-26-154336_Lees-MacBook-Pro.crash.txt
Electron_2019-06-26-154411_Lees-MacBook-Pro.crash.txt
Electron_2019-06-26-154600_Lees-MacBook-Pro.crash.txt

Hope that helps  — please let me know if otherwise.

@deepak1556 Assigning to you as I do not see any instance of our code. Please take a look.

void std::__1::vector<linked_ptr<media::VTVideoDecodeAccelerator::Frame>, std::__1::allocator<linked_ptr<media::VTVideoDecodeAccelerator::Frame> > >::__push_back_slow_path<linked_ptr<media::VTVideoDecodeAccelerator::Frame> const&>(linked_ptr<media::VTVideoDecodeAccelerator::Frame> const&&&) (in Electron Framework) (vector:1578)
media::WebMClusterParser::Track::ApplyDurationEstimateIfNeeded() (in Electron Framework) (webm_cluster_parser.cc:732)
media::WebMClusterParser::~WebMClusterParser() (in Electron Framework) (webm_cluster_parser.cc:69)
af_glyph_hints_reload (in Electron Framework) (afhints.c:819)
WTF::HashTable<blink::Member<blink::CSSStyleSheet>, WTF::KeyValuePair<blink::Member<blink::CSSStyleSheet>, blink::Member<blink::InspectorStyleSheet> >, WTF::KeyValuePairKeyExtractor, WTF::MemberHash<blink::CSSStyleSheet>, WTF::HashMapValueTraits<WTF::HashTraits<blink::Member<blink::CSSStyleSheet> >, WTF::HashTraits<blink::Member<blink::InspectorStyleSheet> > >, WTF::HashTraits<blink::Member<blink::CSSStyleSheet> >, blink::HeapAllocator>::find(blink::CSSStyleSheet*) (in Electron Framework) (HashTable.h:753)
blink::MarginInfo::MarginInfo(blink::LayoutBlockFlow*, blink::LayoutUnit, blink::LayoutUnit) (in Electron Framework) (LayoutBlockFlow.h:783)
blink::LayoutBlockFlow::SetMaxMarginBeforeValues(blink::LayoutUnit, blink::LayoutUnit) (in Electron Framework) (Partitions.h:121)
blink::LayoutBoxModelObject::StyleWillChange(blink::StyleDifference, blink::ComputedStyle const&) (in Electron Framework) (ComputedStyle.h:2074)
blink::ThreadDebugger::GetEventListenersCallback(v8::FunctionCallbackInfo<v8::Value> const&) (in Electron Framework) (Vector.h:1285)
blink::LayoutBox::UnmarkOrthogonalWritingModeRoot() (in Electron Framework) (LayoutBox.cpp:5074)

stack trace shows its in the media layer from chromium.

@leegee I am unable to repro this crash, moving forward I would suggest the following workaround with version 1.35.1. Can you try launching code like:
$ code --disable-accelerated-video-decode

and see if the crash still exists ?
I would suggest updating code to 1.36 which should resolve this issue as well, this just a guess based on the changes that went into the media code path in chromium. If it still exists after updating I can look into it further. Thanks!

It's fine with 1.36 on OSX 14, thanks!


fix: password validation ux

Try out this version of the Hiro Wallet - download extension builds.

This PR finishes what was started by @talentdev0807 here: https://github.com/hirosystems/stacks-wallet-web/pull/2483
Hoping to get feedback from @kyranjamie and @landitus on the UX/UI behavior on this change to validating onChange.
cc/ @kyranjamie @fbwoolf @beguene

@fbwoolf I apologize in advance if some the feedback is out of scope of this PR. I just had to review this with fresh eyes and wrote down what felt off. We can pick and choose what's relevant for this fix and review the rest later

@fbwoolf I apologize in advance if some the feedback is out of scope of this PR. I just had to review this with fresh eyes and wrote down what felt off. We can pick and choose what's relevant for this fix and review the rest later

Yeah, tbh, @kyranjamie made the attached issue requesting the change and we had a dev in the community pick up the issue ...so that is how it ended up being worked on now. I don't totally understand the overall intention here bc we are using Formik validation and are validating the form now onChange here. I can look into how we can customize the validation as specifically as you have outlined in your comments. I agree, it needs refinement. I'll move this back into development and look into making the changes you outlined.

@kyranjamie I think this is one of those times when Fer asked for some changes and you are doing CR while I'm pushing up changes so some behavior you are seeing still might be being worked on by me locally.

I'm out the rest of the week, but maybe you and @landitus can run through the validation behaviour on the desktop wallet, and figure out what should be the same vs different in the extension?

Thanks for the feedback, I will look at the desktop behavior. That is a good idea. I do think the changes here need refinement.

@landitus @kyranjamie curious both your thoughts on this version. I referenced the desktop wallet ...but it doesn't have a confirm password field. So, I used that UX/UI and tried to implement something similar with password matching. Prob easiest to run on your own and test. Let me know what you think.

Basically, the only indicators we show are for strength and matching ...and the button only become enabled when both are met. This prevents the UI from being janky and shifting around while typing. If this works, I can clean up the SetPassword component a bit.

Thanks @fbwoolf for this! It's an improvement from what's today. This got me thinking though if we could take a stab at simplifying this screen way more, so the experience is more streamlined and there's less logic/states to account for in the end.
So I started looking at references and articles and found that today it's common not to have a password confirmation field. Instead, apps either add an option to unmask the password so the user can see what they have typed or just don't use passwords anymore (in favor of magic links or other auth strategies which don't apply here). But in this case, I believe that removing the confirmation field is low-risk since the password is not recoverable anyways. The only way to unblock the wallet would be using the Secret key. So asking for a password once, and adding a way to check if it's ok could be enough. Also, it would be less work for the user, so the initial onboarding would be quicker.
I know this is far away from a simple fix on this screen as the PR is intended to be but... wdyt @markmhx @fbwoolf @kyranjamie ? Is there something else to consider to keep the confirmation field?
Here's how it could look:

Thanks for the feedback, I do prefer this approach if everyone else is onboard with it? I think showing the password and allowing the user to copy it before continuing is likely more helpful than a confirmation field. I do think providing better guidance on the password not being recoverable would be an improvement too. 👍

Let's go with it! I can design all the states. @fbwoolf can you confirm if we can parametrize each state and 4 strengths? or 3 in the worse case? Let me know and I'll incorporate them into the design.

Let's go with it! I can design all the states. @fbwoolf can you confirm if we can parametrize each state and 4 strengths? or 3 in the worse case? Let me know and I'll incorporate them into the design.

Ok, let me look at this today. 👍

Yes, having 4 main requirements that we assign a % sounds good. If a password passes 2 of 4 reqs, it will still be considered weak, for example. Just out of curiosity, what does 'score' mean? Is that the algorithmic evaluation that's hard to specify?

Yes, having 4 main requirements that we assign a % sounds good. If a password passes 2 of 4 reqs, it will still be considered weak, for example. Just out of curiosity, what does 'score' mean? Is that the algorithmic evaluation that's hard to specify?

Yep, we appear to be using this library which provides back a strength score: https://github.com/dropbox/zxcvbn#readme
We set the requirement to be 4 which is the highest score.

Here's a design with 4 steps:
1 - Poor
2 - Week
3 - Average
4 - Strong
lmk what you think!

Here's the password reveal state

@landitus these great, should the Continue button be disabled until Strong is achieved?

Yes, good call

@kyranjamie I cleared your old review here bc it is outdated. I have refactored this with the new designs, so hoping you can review it again at some point. Thx.

If I enter a really small password and wait/blur the input, it should show poor imo

Not just length, this doesn't show a score

If I enter a really small password and wait/blur the input, it should show poor imo

Not sure why the score isn't returning anything on these. I'll do more testing today.

@kyranjamie can you test this out again on your end? I think I resolved the issues you pointed out.

Found another one. Must be duplicating some "is strong enough" logic somewhere, and there being a subtle difference in the logic:
https://user-images.githubusercontent.com/1618764/178934529-3a81e458-6587-496e-9fcb-8636a6ae4940.mp4

Love the progress on this @fbwoolf !

I think I have resolved the issues found.


zabbixWeb could not connect to a database

Nix tells ZabbixWeb to use file_get_contents function for retrieving DB password from file. And seems that it adds a newline symbol to a password string so auth failing.
        services.zabbixWeb = {
                enable = true;
                virtualHost = {
                        hostName = "zabbix.localhost";
                        adminAddr = "webmaster@localhost";
                };
                server.address = "localhost";

                database.type = "mysql";
                database.host = "<IP_ADDRESS>";
                database.name = "zabbix";
                database.user = "zabbix";
                database.passwordFile = zbxMysqlPassFile;

zabbix.conf:
<?php
// Zabbix GUI configuration file.
global $DB;
$DB['TYPE'] = 'MYSQL';
$DB['SERVER'] = '<IP_ADDRESS>';
$DB['PORT'] = '3306';
$DB['DATABASE'] = 'zabbix';
$DB['USER'] = 'zabbix';
$DB['PASSWORD'] = file_get_contents('/etc/nixos/creds/mysql-zabbix');

[root@box:~]# nix-shell -p nix-info --run "nix-info -m"

system: "x86_64-linux"
host os: Linux 5.10.71, NixOS, 21.05.3834.88b914e7e43 (Okapi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.15
channels(root): "nixos-21.05.3834.88b914e7e43, nixos-unstable-21.11pre323079.2cf9db0e3d4"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Thanks for reporting this. I'll take a look when I get a chance.
If actually you're connecting to localhost (as opposed to using localhost as a simple and reproducible example) I would really suggest using socket authentication which is more secure and doesn't require a password.

Oh... I reviewed the code:
$DB['PASSWORD'] = ${if cfg.database.passwordFile != null then "file_get_contents('${cfg.database.passwordFile}')" else "''"};
You mean that you put a newline in your password file? Just remove the newline in the password file.

Oh... I reviewed the code:
$DB['PASSWORD'] = ${if cfg.database.passwordFile != null then "file_get_contents('${cfg.database.passwordFile}')" else "''"};
You mean that you put a newline in your password file? Just remove the newline in the password file.

Of course not. Newline is added by file_get_contents I assume. Why do we need such an obscure way of configuration? Why we can't just add a 'password' option instead of passwordFile?

Your password ends up in the nix store and is readable by any user on the OS. Then you commit your configuration to github and the situation worsens. Unfortunately we must avoid password options in NixOS.

https://stackoverflow.com/questions/18254566/file-get-contents-seems-to-add-extra-returns-to-the-data
I'll whip up a PR.

Your password ends up in the nix store and is readable by any user on the OS. Then you commit your configuration to github and the situation worsens. Unfortunately we must avoid password options in NixOS.

It's up to end user to decide. I'd use blocks like this for example:
zbxMysqlPassFile = "/etc/nixos/creds/mysql-zabbix";
zbxMysqlPass = (builtins.readFile zbxMysqlPassFile);

It's up to end user to decide.

I agree, the user should be given a footgun in this scenario.

I'd use blocks like this for example:

What you're looking for is:
{
  services.zabbixWeb.database.passwordFile = pkgs.writeText "footgun.txt" "this-is-my-password";
}

It's pretty annoying to debug.

I bet it was. I'm sorry this issue exists and you ran into it :disappointed:. PR incoming.
Unfortunate (from your perspective, fortunate from other persons perspective) people who commit NixOS module generally agree that adding password options is a bad idea. The very first post of https://github.com/NixOS/nixpkgs/issues/102397 includes a number of links if you're interested in hearing the arguments.


Save checkpoint

Hi
how can I save checkpoint without waiting a full epoch?

You can use ModelCheckpoint to set the saving steps rather than epochs.
for instance mine code is as followed:
`
from pytorch_lightning.callbacks import ModelCheckpoint
checkpoint_callback = ModelCheckpoint(every_n_train_steps=5000, save_last=True,  save_weights_only=False, filename='exp_sd21_{epoch:02d}_{step:06d}')`


add Santa Tracker PWA showcase article

Thanks for the extensive review, @jpmedley and @petele !
I've pushed a new version which should resolve all comments.


@sravani

I am developing a bot in node.js in visual studio using blank azure web application.i tested it locally.but when i published it in azure i am unable to access my bot .it is just showing
"ok,helloWorld"(202 accepted).how to develop a bot in node.js and i don't have much skills in programming..........

Have you tried some of the samples found here?  https://github.com/Microsoft/BotBuilder-samples


lip-sync didn't work in the first two seconds

I found during the test that the lip-sync didn't work in the first two seconds of the video.

It does seem to be an issue with this preview model. I think from an engineering perspective, this can be mitigated by adding an extra segment of dummy audio at the beginning.

It does seem to be an issue with this preview model. I think from an engineering perspective, this can be mitigated by adding an extra segment of dummy audio at the beginning.

How to rectify this @ltzheng  ?

If you don't want to involve model training, a simple solution you can use is sampling a small segment of the original audio and concatenating it to the beginning of the original audio.

If you don't want to involve model training, a simple solution you can use is sampling a small segment of the original audio and concatenating it to the beginning of the original audio.

any ideas for resolving the issue in inference?

@runshouse I actually mentioned this in my earlier comment above — sampling a small segment of the original audio and concatenating it to the beginning of the original audio could help address the issue without involving model training.

@runshouse I actually mentioned this in my earlier comment above — sampling a small segment of the original audio and concatenating it to the beginning of the original audio could help address the issue without involving model training.

Got it, I misunderstood. What do you mean by "sampling" btw?


Contact users page has multiple h1 elements

Page should not have multiple h1 elements as per accessibility guidelines.

:+1:


Incorrect Sed Command [Enable Infiniband]

[Enter feedback here]
In the Enable IP over InfiniBand (IB) section, the sed command does not work. It should be
sudo sed -i -e 's/# OS.EnableRDMA=n/OS.EnableRDMA=y/g' /etc/waagent.conf

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f57aa98-f440-5657-7a2d-ca8ae1677ee2
Version Independent ID: 983c26ef-d1e2-6f62-19dc-67a214f0f217
Content: Enable InifinBand on HPC VMs - Azure Virtual Machines - Azure Virtual Machines
Content Source: articles/virtual-machines/workloads/hpc/enable-infiniband.md
Service: virtual-machines
GitHub Login: @vermagit
Microsoft Alias: amverma

Thanks for the issue, I've assigned it to the author to take a look at the command.

@jhollowe Thanks for catching the 'y'. I've now corrected it and it should go live soon.

Thanks!


The size of the extent is less than the minimum of 1MB.

Afternoon @JimMoyle, hoping you can help.
Looking to your script to assist with reducing the impact of container bloat. Unfortunately, getting the below error:
Get-RunspaceData : Exception calling "EndInvoke" with "1" argument(s): "The running command stopped because the
preference variable "ErrorActionPreference" or common parameter is set to Stop: Size Not Supported
Extended information:
The size of the extent is less than the minimum of 1MB.
Activity ID: {861b16e2-e9d2-4263-a4b9-2ad5e4cb1b82}"
At C:\users\admin\Desktop\FSLogix Shrink Disk.ps1:747 char:17
Get-RunspaceData -wait
CategoryInfo          : NotSpecified: (:) [Get-RunspaceData], MethodInvocationException
FullyQualifiedErrorId : ActionPreferenceStopException,Get-RunspaceData

I've not seen this before, can you tell me a bit more?  what is the size of the disk (max and current) was it created by FSLogix or some other method?

Good morning Jim,
Many thanks for your quick response.
The disks were created using a script from Christiaan Brinkhoff (https://www.christiaanbrinkhoff.com/2020/02/14/youtube-how-to-migrate-from-upd-to-fslogix-profile-container-profiles-to-windows-virtual-desktop/)
Following your response, I have tested your script with an FSLogix created disk, and I can confirm I do not see the error.
I’ve not had a chance to review the differences between the two disks in order to identify an exact cause, if I get the time to do this I will let you know.
Regards,
Ed
From: Jim Moyle @.>
Sent: 06 January 2022 20:40
To: FSLogix/Invoke-FslShrinkDisk @.>
Cc: Ed Hurrion @.>; Author @.>
Subject: Re: [FSLogix/Invoke-FslShrinkDisk] The size of the extent is less than the minimum of 1MB. (Issue #52)
I've not seen this before, can you tell me a bit more? what is the size of the disk (max and current) was it created by FSLogix or some other method?
—
Reply to this email directly, view it on GitHubhttps://github.com/FSLogix/Invoke-FslShrinkDisk/issues/52#issuecomment-1006919204, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXF4C2HZIDE4YN4CYBC4T4LUUX4ZPANCNFSM5LMQJ6OQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


WSL 403 Forbidden error in my University network while updating

Windows Version
Microsoft Windows [Versión 10.0.22621.1344]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Kali GNU/Linux Rolling 2023.1
Other Software
No response
Repro Steps
Basically, I use WSL on my home network and works flawlessly but when I connect to my college network I get 403 Forbidden errors while I sudo apt update. This not only happens in Kali Linux, it also happens in every distro I've tried. Also the network isn't blocking those servers because I do have connection with those on the browser.
 Done

Your college network has either a web proxy or a TLS middle box or both.
Your browser knows how to autoconfigure itself to work in that environment.  Your WSL distros cannot autoconfigure.  So, your network connections succeed in the browser but fail on WSL.
You will need your college network administrator to give you some instructions for how to configure your WSL linux distribution to work on their network.


Glyph launcher (Command line arguments)

I'm trying to get steam overlay in Archeage Unchained (not the steam version). Glyph launcher doesn't run archeage.exe, it instead runs EasyAntiCheat's launch_game.exe, which seems to then run archeage.exe passing some parameters (ex -eac_launcher_settings settings_64.json -t+auth_ip xxx.xx.xx.xxx -auth_port xxxx -handle xxxxxxxxxxxxxxxx -lang en_us -glyphid xxxx -lang en_us).
I've been looking into older issues and it seems that the CommandLineProxy/DetectedCommandLine functionality was the way to do that, but it has since been deprecated. Is there a new way to pass these command line parameters?
This is how I've set the OSOL ini.
[Paths]
LauncherPath=D:\Glyph\GlyphClientApp.exe
GamePath=D:\Glyph\Games\AAUnchained\Live\launch_game.exe
LauncherArgs=
LauncherURI=
GameArgs=
MonitorPath=D:\Glyph\Games\AAUnchained\Live\bin64\archeage.exe
PreLaunchExecPath=
PreLaunchExecArgs=
PostGameExecPath=
PostGameExecArgs=
[Options]
ReLaunch=True
SkipLauncher=False
CloseLauncher=True
AutoGameLaunch=True
MinimizeLauncher=False
ElevateExternals=False
PreGameLauncherWaitTime=15
PreGameWaitTime=0
PostGameWaitTime=0
ProcessAcquisitionTimeout=120
InterProcessAcquisitionTimeout=15
GameProcessAffinity=
GameProcessPriority=Normal
[Info]
ReleaseVersion=<IP_ADDRESS>

Unfortunately, there isn't a way to do this at this time. You'll have to do the login process by hand.
The CommandLineProxy feature was deprecated because many - though not all - authenticating launchers nowadays have checks to make sure the game has been launched from the authenticated launcher (usually by means of an auth string) and not through any other means. It's intended to prevent hacks and account theft.

If there is a way for me to get Steam Overlay inside the game I don't mind launching the game manually, however OSOL seems to never "find" the game process. I thought it was because it had to be launched from OSOL, is that not the case?

What happens if you add the launcher as a non-Steam game and launch Archeage that way (without OSOL)? Are you able to see the overlay in that case?

It doesn't work, I don't get overlay in game. Seems that steam hooks into the launcher, I get my controller config working while on the launcher but not in game.

Hmm, it's possible that the game is designed in a way where overlays are barred from hooking into the game at all. My only two suggestions for getting around that problem is to use a Desktop Mode config so KB&M input from the controller applies system-wide, or to use a GloSC shortcut so the overlay runs as a separate window on the desktop.

Alright, I'll try those suggestions. Thank you very much!


pkg/bpf: allow overriding constants during load

pkg/bpf: fix globalData big-endian issues
globalData extracts constants from an array of bytes using BTF. It does this
by copying up to 8 bytes into a temporary buffer and then using
ByteOrder.Uint64 to convert that to a uint64. This only works on little
endian machines.

Fix this by using the correct methods to convert to uint64. Since there are
approximately zero big-endian machines out there this isn't a particularly
critical fix.

Fixes: d10e8ebed3 ("bpf: dynamic-width static data inlining")
Signed-off-by: Lorenz Bauer<EMAIL_ADDRESS>
pkg/bpf: allow overriding constants during load
We inline constants found in a special .rodata map into the instruction
stream. This allows older kernels to do dead code elimination. At the same
time we use ELF substitution to rewrite the contents of that .rodata section
before load.

Allow overriding the values we inline into the instruction stream. This is
necessary to remove ELF substitution later on.

Signed-off-by: Lorenz Bauer<EMAIL_ADDRESS>

Going to do this in one go, when landing ELF substitution.


Items with no alternate recipes can't be added to crafting table

Items with no alternate recipes can't be added to crafting table, the Begin crafting tree doesn't do anything.

New behaviour is that the default recipe is both shown under the recipe filter and added to the crafting table when selected, if it is the only option. Previously the recipe filter returned an empty character field, and therefore could not be matched against any recipe in the source crafting data.


Migrate payroll service from MariaDB to PostgreSQL

Failing cus of this: https://travis-ci.com/apache/fineract-cn-payroll/builds/111139859


Trace Explorer: Sort outputs alphabetically

Outputs are now sorted arbitrarily, such that 2 traces having the same outputs or at least many common ones, will show the outputs differently sorted.
They should be sorted in a consistent way, such that if output X if before output Y for one trace, it is always so for other traces.

Trace Compass server providing a list of outputs in alphabetical order:
https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/177473


Test assertion nf-test

This PR populates the nf-test framework with assertions.
Tests needing Entrez Download are tested in PR #119
PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/metapep branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

As the changes within the pipeline accumulated quite a lot, I split the PR into two #127 and #128 which include the same changes as this PR, but a bit more organised and without that many snapshot updated and commits.

Both assertions and refactors are merged in #127 #128.


Improve performances by a ~30x factor

FastPolylines original purpose was being faster than Polylines. There is a way to do even better with native C extensions.
I implemented it, and since it now deviates a lot from it's counter part Polylines, I decided to change signatures.
Some useful links about Ruby and C binding:

Programming Ruby, The Pragmatic Programmer's Guide
The Definitive Guide to Ruby's C API
Gems with extensions
Creating Extension Libraries for Ruby

A short presentation of the work done here: Poly-glot.pdf.

Using travis-ci.org build matrix would allow us to test on various machines and ruby versions easily for free:
# .travis.yml
language: ruby
os:
  - linux
  - osx
rvm:
  - 2.4
  - 2.5
  - 2.6
  - 2.7

This will expand to 8 tests fully configured, and bundle caching.

@ccyrille there is a bit of configuration to stop expecting circleci and expect travis instead :)


Test creation Validation

Describe the bug
There are multiple validation failures while creating tests.

The test can be give negative marks
Duration can be negative (rolls over when processed by backend)
Answer provided in MCQ questions doesn't need to be one of the options (see bitfield in #82 for a solution)
Number of questions can be negative
Total marks and number of questions required in the generated test aren't validated with the number of questions in the question bank

To Reproduce
Steps to reproduce the behavior:

Create a new test

Give it negative marks (-100)

Give it negative duration (0 hours, -20 mins) (-ve hours gives a warning)

Add question, all 4 options need to be selected

Add negative no. of questions and negative marks

Press next after verifying

Check the dashboard (local build on latest master branch)

Expected behavior
Error message should be shown whenever a validation fails. And the next button blocked until the mistakes are corrected.
Desktop (please complete the following information):

OS: ArchLinux
Browser firefox
Version 86.0

Hey, can I work on this issue as a participant of GSSOC'21 ?

@kernal053 Yes, you can

Thank you, @Vidisha-kayal . Can any admin assign it to me ?

Hi, the validations are being performed on the client side only and not on the server side. So, if instead of creating the test using the UI I send a post request to the server with marks as negative, the test will be created. Therefore, validations need to be performed server side as well and in case the validations fail, the user should be redirected accordingly


crash when notifications are denied

If you configure Android to deny notification permissions, SubwayTooter crashes for me.

After the current notification-related improvements, I will make sure to check the notification authority before sending notifications or foregrounding  workers that require "on going" notification.

I believe fixed on 5.512 (test version


Added mastercard MCC list

Source: https://online.ogs.ny.gov/purchase/snt/awardnotes/7900822712rf018MerchantCategoryCodeList.xls

This is really good! Though I'm confused how you're sourcing this from mastercard if it's hosted on the new york government website -- where did you get the link from?
Two minor changes to make on the csv itself:

Ensure there is a newline at EOL (it's failing lint because of it)
Please change the first line to MCC,DESCRIPTION to be consistent with the other CSVs

Thank you!

Updated. I added newline at the end of file and changed row description.
I just found xls on Google, added a little magic to get a csv and was done.

Got it. thank you. Let me try to figure out what the actual original source is before landing it then.

FYI - I don't think this is specifically the mastercast list, so that's why I want to figure out where it's from.
The mastercard list is here: https://www.mastercard.us/content/dam/mccom/en-us/documents/rules/quick-reference-booklet-merchant-edition.pdf
You can see for example in your PR, 1740 is "Masonry, Stonework, Tile Setting, Plastering, Insulation Contractors", whereas the official PDF sets it as "Insulation, Masonry, Plastering, Stonework, and Tile Setting Contractors".


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.12 to before v5.16.11",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0c5fcf9e249ee1d94cf872c99baf9cba7ff9ce27",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d5e80a1840121ba727e1ca92c2cc4234e2390d2b"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "0c5fcf9e249ee1d94cf872c99baf9cba7ff9ce27",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "d5e80a1840121ba727e1ca92c2cc4234e2390d2b",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "ipv6: fix data-race in fib6_info_hw_flags_set / fib6_purge_rt\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.16.11 by commit d5e80a1840121ba727e1ca92c2cc4234e2390d2b, it was introduced in version v5.12 by commit 0c5fcf9e249ee1d94cf872c99baf9cba7ff9ce27. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000546


mkGoEnv cannot find go package in nixpkgs

With the following flake:
{
  description = "A reimplementation of Sandstorm in Go";

  inputs = {
    nixpkgs.url = "nixpkgs/nixos-23.05";
    gomod2nix.url = "github:nix-community/gomod2nix";
  };

  outputs = { self, nixpkgs, gomod2nix }:
    let
      supportedSystems = [ "x86_64-linux" "x86_64-darwin" "aarch64-linux" "aarch64-darwin" ];
      forAllSystems = nixpkgs.lib.genAttrs supportedSystems;
      nixpkgsFor = forAllSystems (system: import nixpkgs { inherit system; });
    in
    {
      packages = forAllSystems (system:
        let
          pkgs = nixpkgsFor.${system};
          gonix = (gomod2nix.legacyPackages.${system});
          tempest-src = pkgs.fetchFromGitHub {
            name = "tempest-src";
            owner = "troyjfarrell";
            repo = "tempest";
            rev = "main";
            hash = "sha256-V2+4VXqxbUpTWYrfzxpblzbsJKhAPXe5SoCii3+zxow=";
          };
        in
        {
          tempest = gonix.mkGoEnv {
            pwd = "${tempest-src}";
            modules = ./gomod2nix.toml;
          };
        });

      defaultPackage = forAllSystems (system: self.packages.${system}.tempest);
    };
}

evaluation during nix build fails with:
error: go.mod specified Go version 1.20, but no compatible Go attribute could be found.
Yet the following works in the repl:
nix-repl> :l <nixpkgs>
Added 19222 variables.

nix-repl> :t buildPackages
a set

nix-repl> lib.reverseList (builtins.filter (attr: lib.hasPrefix "go_" attr && lib.versionAtLeast buildPackages.${attr}.version "1.20")(lib.attrNames buildPackages))
[ "go_1_20" ]

So I don't exactly know why this was complaining since the current go version is 1.23 and I am using 1.22 which according to the comments on https://github.com/nix-community/gomod2nix/blob/master/builder/default.nix#L129
but I did this to resolve the error and make it happy
I added a go attribute pointing to the correct go package for the project
 devShells = forEachSupportedSystem ({ pkgs, gomod2nix }: {
   default = pkgs.mkShell {
     packages = with pkgs; [
       (gomod2nix.mkGoEnv { pwd = ./.; go = go_1_22; })
       gnumake
       gomod2nix
     ];
   };
 });


Split Semantic Services

This PR splits the Semantic Services code in the Semantic Hub and the Registry, which makes them independently deployable.

LGTM


[Issue] Firefox-developer version updates ALWAYS require --force to be installed

See this:
https://github.com/lukesampson/scoop/issues/3876
essentially, the version number parsing doesn't work anymore with firefox-developer's format (Major.minor[b]betaversion).
Running scoop update and scoop status does not notify the user of a new version of firefox-developer, even when present, if the change in version number is only on the last beta version number.
Moreover, running scoop cleanup firefox-developer breaks the /current/ folder junction. Example follow:
install<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>in this order. /current/ will point to 75.0b3
Now run scoop cleanup: only 75.0b1 will be left, but /current/ will still point to a (non-existant) 75.0b3

lukesampson/scoop#3721
Nonse to open issue here


[Feature] jwts for waterbutler

Use jwts for waterbutler credentials endpoint and remove restrict_waterbutler
OSF-4733

First review done :pill:

2nd pass finished, Good when Michael's comments are addressed.


Download only speciefic crates

Is it possible to download only speciefic crates, e.g., panamax sync my-mirror --crates="serenity,rand,songbird"?

Unfortunately it's not currently possible to only download specific crates. It would be pretty cool to have Panamax support this in the future, however doing so would be a pretty big feature, due to Panamax needing to implement two things:

The ability to reach into an existing crate archive file's Cargo.toml to grab all of its dependencies recursively, and

The ability to serve a crates.io-index repository that does not match with the upstream repository, in order to match up with only the crates on the mirror.

Between the large effort required to implement it, and the fact that it's not something I personally need, I don't believe I'll be getting around to implementing this functionality any time soon sadly.
At the same time though, this is an interesting feature and I'd be open to PRs for it.

@k3d3 As a first step, it could be good to download only crates passed as arguments by user and not their dependencies?
Because such a feature would put basic logic for this feature, but also to correct #64.

This should be solved with the new feature added in #71.


Contracting two caps

Contracting two caps horizontally is impossible:

The contraction itself does go through:

But then we try to smooth the central point (since it has orientation 0 and its surrounding cospan is self-similar) which is not impossible, so then we just fail the whole contraction sequence.

Fixed by ebb904b9348f9d39dba457b65066e64e1ac5008f


 I'm using it to cleanup my private registry. So one thing I would LOVEEEEEE is if the nice emit() output that runs on --dry-run was also on the real deal, otherwise I hvae no idea whats happening and am super sad and confused. Happy to make the patch just wasn't sure if you (a) agree, (b) want this hidden behind a --verbose flag or something

I did not realize the output differed. My expectation would be that the output on --dry-run would be the same as without it (without requiring an extra flag). I agree, let's see if @RichardScothern is ok with changing the output or if the output needs to stay constant and hide the new output behind a flag.

I'm okay with this. Should be a few line patch.

Sweet I totally have this locally fixed
Also maybe there could be a way to do this per repo, I have a 700GB private
registry and this takes 13 hours to run.
On Thursday, September 8, 2016, Stephen Day<EMAIL_ADDRESS>wrote:

I'm okay with this. Should be a few line patch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/distribution/issues/1950#issuecomment-245785986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbGPY8yyuG4raaXd79C0FTgM9f1u6ks5qoKr-gaJpZM4J2HkT
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

Also maybe there could be a way to do this per repo, I have a 700GB private
registry and this takes 13 hours to run.

@jfrazelle You have to sweep the whole registry or you risk removing data referenced in another repository.
Which storage driver are you using?

s3 and ya that makes sense
On Thursday, September 8, 2016, Stephen Day<EMAIL_ADDRESS>wrote:

Also maybe there could be a way to do this per repo, I have a 700GB private
registry and this takes 13 hours to run.
@jfrazelle https://github.com/jfrazelle You have to sweep the whole
registry or you risk removing data referenced in another repository.
Which storage driver are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/distribution/issues/1950#issuecomment-245789729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbLCyPI0RaBD4ob3_IKAsdzJmchGpks5qoLFBgaJpZM4J2HkT
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

s3 is dog slow (100ms+ for simple file listing) and they'll never fix it.
I know there is work to move metadata into a consistent data store but I am not sure about the progress on that. cc @RichardScothern

Hmm ya I shouldddd probably switch to gcs (kinda embarrassing) I'll try
that
On Thursday, September 8, 2016, Stephen Day<EMAIL_ADDRESS>wrote:

s3 is dog slow (100ms+ for simple file listing) and they'll never fix it.
I know there is work to move metadata into a consistent data store but I
am not sure about the progress on that. cc @RichardScothern
https://github.com/RichardScothern
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/distribution/issues/1950#issuecomment-245790727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbJExHP212HeWvb_GxMt7AkyqBN9Tks5qoLMDgaJpZM4J2HkT
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

Anyways it's not that bad I just run on cron weekly so whatever :) I love
the command tho makes me feel like it's cleaner haha
On Thursday, September 8, 2016, Jess Frazelle<EMAIL_ADDRESS>wrote:

Hmm ya I shouldddd probably switch to gcs (kinda embarrassing) I'll try
that
On Thursday, September 8, 2016, Stephen Day<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
wrote:

s3 is dog slow (100ms+ for simple file listing) and they'll never fix it.
I know there is work to move metadata into a consistent data store but I
am not sure about the progress on that. cc @RichardScothern
https://github.com/RichardScothern
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/docker/distribution/issues/1950#
issuecomment-245790727>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNbJExHP212HeWvb_
GxMt7AkyqBN9Tks5qoLMDgaJpZM4J2HkT>
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3
pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=
0x18F3685C0022BFF3>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/distribution/issues/1950#issuecomment-245790928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbOcPtY3IOL2Nc7HVsSogx4fNpNE3ks5qoLNhgaJpZM4J2HkT
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

I love
the command tho makes me feel like it's cleaner haha

Should have implemented it a long time ago...

whoops sorry for the delay in sending the PR I'll do it today, but I thought you might be interested in some cool things
So my private registry got up to be 1TB, I have continuous builds for my dockerfiles repo on a private jenkins and since i never cleaned up old shas it was just growing expontentially so I decided to clean it up. Now I thought about 2 ways to go about this:

purge the whole thing and just trigger a rebuild of "the world" aka my repo
zero downtime, actually cleanup the old shas so i can do this via a cron in the future

so I set about the ambitious goal of no. 2, which is no easy feat with that much crap.
I set the registry to not allow push momentarily via the auth system I'm using. wrote a terrible bash script (i know I would lol) to delete the old shas and a command line tool for the registry and then triggered the garbage collector.
and check it out, went from 1TB for 182 images to...
$ gsutil du -h -s gs://r.j3ss.co
15.24 GiB   gs://r.j3ss.co

now it takes like 5 min to garbage collect lol

that is impressive bash fu @jfrazelle
The use case for removing images -and by extension, blobs - that are not referenced by a tag (rather than those which have been deleted) is not currently supported with the garbage-collect subcommand, but I would be in favor of adding that as an option given that it's very commonly requested.

I set the registry to not allow push momentarily via the auth system

Refreshingly creative!


fixed MD5 test to also work if test file has been cloned with crlf endings

While preparing my development environment for the clean/forget command, I stumbled upon a failing test on Windows, Python 3.6.3, resulting from the fact that my GIT was checking out with crlf, leading to a different MD5 hash value.
I fixed the test by allowing both, the lf and crlf based hashes to be accepted. I verified the added hash in http://onlinemd5.com/.
It's weird that appveyor does not catch this, it seems to clone with lf only... Is that possible?

Coverage increased (+3.0e-05%) to 99.731% when pulling 4d1bd6dd922417bba9adf81133218891f0304a15 on moltob:master into 8e7405d1c2c15f37684c57346900c2e2b01167a7 on pydoit:master.

Thanks.
Not really happy with checking the result against 2 values... hope i never have to change this :grimacing:


Fix Test Operation issues with type comparison

I've fixed issue with Test operation described in https://github.com/raphaelstolt/php-jsonpatch/issues/8, please review the changes.

Does that close issue https://github.com/raphaelstolt/php-jsonpatch/issues/8 for you?

Yes, at least we can use test operations correctly. So you can close issue #8

Closed with https://github.com/raphaelstolt/php-jsonpatch/commit/8384b2f1c383a47940e779151ddd985db9400644.


Synchronous operations?

It is possibile do operations (find, update,etc..) in synchronous mode?

That would not make sense as performance would be I/O bound, and hence
disastrous
2016-08-29 16:15 GMT+02:00 badstorm<EMAIL_ADDRESS>
It is possibile do operations (find, update,etc..) in synchronous mode?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/louischatriot/nedb/issues/445, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4ik4lxTGQA7tV1j07uG8vs8aP82JJOks5qkul4gaJpZM4JvhJ0
.

@badstorm With promises you can get good performance using neDB, I use "Q".
Also, javascript is not a synchronous language.

When using memory-only mode, synchronous operations will be very useful, for example, if using NeDB as storage provider for redux. Also, when working in memory-only mode, there is no requirement to perform async operations, due there is not any read I/O

He's in a fantasy world where literally every DBO in the universe aside from his doesn't offer this and where database apps have sandwiches to make while they wait for a memory call

I would say it is more a result of his design goal to have a consistent API regardless of what backing store is being used (in-memory, localStorage, IndexedDB, Node.js file system, etc.).
Either way, please be sure to be respectful of other users and offer constructive feedback.


[core-http,core-amqp] Prepare for 2022 November release

update CHANGELOG

API change check
API changes are not detected in this pull request.


security/acme-client: add export of fullchain.pem

add export of fullchain.pem, solves 1732

@thutex Merged, thanks!


Implement Data.ValidateBasic

Currently there is no validation in ValidateBasic method of block Data.
https://github.com/celestiaorg/rollmint/blob/3a518be702b3d4183deb888fbc7958fcc2c3b2bc/types/validation.go#L38-L42
Methods should check:

[ ] Number of ISRs corresponds to number of TXs
[ ] ISR's are valid hashes (length is OK)

Related: https://github.com/rollkit/rollkit/issues/1271

Duplicate of https://github.com/rollkit/rollkit/issues/1271


LiveSearch performance

The fix implemented for the key word searching (ba65054cc966da18634f14a7215840e3e24edc31) unfortunately made the performance much worse again. The culprit is the .parent() function - somehow over half the performance improvement from #1516  was gained by the removal of .parent().
The best solution I can find is to move the .find('a') into the pseudo expressions, which allows to remove .parent() while still keeping the key words working. I was thinking there could be remove for some extra improvement as well though. Here's what I have in mind:

Move .find('a') into the pseudo expressions as mentioned above.
Use the token to store normalized text, eliminating the need for the extra pseudo expressions.
Use normal functions instead of pseudo expressions and optionally accept a function for the liveSearchStyle. This is marginally faster and would allow users to implement their own search function which could be used to do something like 'word starts with', or to provide optimal performance by ignoring tokens.

Any thoughts on this? I'm happy to make a PR for this if you think it would be a good idea.
(P.S. Much apologies for breaking the key word searching)

I'm working on an updated version of bootstrap-select that uses virtualization (rendering only the options that are actually visible). This makes live search instant (using a select with 4000 options in my testing) and works pretty awesome. The slowest part about the search currently is showing/hiding thousands of elements at once. I'm working on making this new version available in a separate branch so others can test it as well.

Awesome, I look forward to testing that out :)

I just added a virtual scrolling feature (which results in instant searching) in the virtual-scrolling branch. It's still a WIP, and there are a few features missing, some I'm aware of (the startsWith feature for example), and some I'm sure I'm not. Try it out - I'm looking for feedback. Please post all findings in #1229.


Fix issue in delete method.

Previously, when encountering a ProtectedError in the delete method, only one protected object was being returned with an error message. However, according to Django's delete behavior, all protected objects should be returned with a message. This commit addresses this issue by modifying the delete method to return all protected objects along with the appropriate message.
Dear @san4ezy, pls review the pull request, thank you!

Thank you @vardgeskarapetyan2 !
This code is already in latest version: 1.0.12


Load Language strings from other locations

Description
Fixes #1433
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

The fallback was not added...


Implement f64 FFNTs to multiply values a and b without precision loss

Implement f64 FFNTs to multiply values a and b without precision loss. Better if we can define number of useful bits. Useful for

RLWE x RGSW when useful bits are > 17 bits.
RGSW x RGSW in bootstrapping key-gen operation in multi-party setting

closing with #30

closing with #30


Create nightly_build.yml

Summary:

Test plan:

Fixes #{issue number}

Codecov Report
Base: 93.63% // Head: 93.63% // No change to project coverage :thumbsup:

Coverage data is based on head (65124e5) compared to base (53ab78b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   93.63%   93.63%
=======================================
  Files          54       54
  Lines        3237     3237
=======================================
  Hits         3031     3031
  Misses        206      206

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CNDB-7264 simplify getLevels and getCompactionArenas signatures

Remove filterUnsuitable and relly solely on compactionFilter. The filter is now a bipredicate to support filtering sstables that are being compacted.
This will allow CNDB to getLevels for all sstables (not only for the non-compacting ones).

@maxtomassi I changed the doc.


Right-click on arrow does not hide the bar

Describe the bug
After upgrading to version 1.9, I found that right-clicking on the arrow icon does not hide the bar icon, unlike the previous version. Currently I couldn't find a way to hide the bar icon at all
Steps to reproduce

Open Hidden Bar
Un-collapse menu bar
Right-click on arrow icon

Expected behaviour
Right-click should toggle bar icons that are used for configuration.
Screenshots
https://user-images.githubusercontent.com/21295738/165486583-9277846e-09b0-41f5-b357-914d25a4c154.mov
Environment
macOS 12.3
Hidden Bar v1.9

Same issue here

+1 facing same problem

Similar issue.
When I right-click the arrow icon, the two stick icons disappear and the all app icons in Always hidden section and Hidden section are still there.
macOS 11.2.3
Hidden Bar v1.8

Same.. Also the "icon width" looks fatter now, not smaller like the change notes said..
Going back to bartender..

For me, macos 12.4, the right-click hiding works on v1.8 but not on v1.9. Always hidden section never works.

This seems to have worked for me....
Fresh installed the latest version, v1.9.
Turned on the "Always Hidden" section, moved icons across using the command + drag after that seperator and THEN right-clicked the arrow key once.
This hides the Always Hidden section when you next LEFT-CLICK on the expand arrow. (or use a keyboard shortcut).
I do not believe it's meant to remove the HIDDEN SECTION, just the ALWAYS HIDDEN SECTION.


audio input via pulse is very slow

When using freshplayer using pulseaudio, audio input is extremely slow (unusable). Disabling pulse and running via alsa works fine. Running the pepperflash plugin directly (via chromium) works fine both using pulse and alsa.
See e.g. https://www.onlinemictest.com/microphone-test-in-adobe-flash to test.

audio input is extremely slow

Could you be more specific about "slow"? What does it mean? Sample rate doesn't match?
I used to use https://i-rinat.github.io/flash-test-cases/RecordAudio/index.html to make tests. That test app first records for five seconds from microphone, then plays recorded samples. Does it work well?

It misses a lot of input, about half the input I would say (saying 5x test results in only 2-3), a bit like working on a very slow old computer. The flash testpage I linked shows also something like only half time audio getting through, while the other half just seems to be dropped and the visualization is very slow there (which it is not on a 'native' pepperflash plugin) with a screen refresh only once every second or so instead of continuously. This was also what I experienced in a adobeconnect meeting I was in this afternoon, the audio output was fine, but the audio input was stuttered and slow.

Test app you gave link to, also freezes in Chrome on my machine.
And I realized I didn't try to capture longer than five seconds of sound. I think I need to make another test app to check whenever it's that app was broken or Flash itself acts that way.

Ah, that's annoying... Longer samples certainly might be useful for debugging.
I found http://www.adobe.com/devnet/flash/articles/flcs5_features_microphone_event.html
which might have been used by the one writing it.

Created MicrophoneOscilloscope test. I didn't like the test app from title message because it painted only sample from immediate capture, without storing a number of them for visual history. Does it work on your machine? I didn't notice any freezes on mine.

I've created screencaptures (xvidcap) for Firefox using alsa and pulse, plus one for chromium, see
https://surfdrive.surf.nl/files/public.php?service=files&t=b591b37ccf5c62fb3c1a567d0495c539
(The link will expire at the end of the year).

As far as I understand, PulseAudio tries to maximize latency, unless requested otherwise. I've changed the way capture streams created in 4ef12af9aa95e866c3609c097c3a054b8692c9b2. Could you test whenever that gives any positive effects?

Yes it does! Works perfectly. Many thanks for the quick fix! (and no, I don't like pulse (-; )
For completeness I've uploaded two captures from both your test and the other microphone test to https://surfdrive.surf.nl/files/public.php?service=files&t=b591b37ccf5c62fb3c1a567d0495c539
two files called pulse_master.mpeg and pulse_master2.mpeg.

OK, that's great.


Add bind mounts for selinux to all kubelet containers

Enable Kubelet to determine SELinux state and configuration, and let it specify relabelling of mounts for workloads.

Added Kubelet mounts for /etc/selinux and /sys/fs/selinux to all butane/clcs

Testing
Performed the steps from the reproducer described in the issue with one change to point to this branch:
$ diff tempest.tf tempest-fork.tf
24c24
<   source = "git::https://github.com/poseidon/typhoon//aws/fedora-coreos/kubernetes?ref=v1.23.6"
---
>   source = "git::https://github.com/solacelost/typhoon//aws/fedora-coreos/kubernetes?ref=fix/selinux-kubelet-mounts"

Command output:
$ kubectl logs -l kbench=fio -f
TEST_FILE: /volume/test
TEST_OUTPUT_PREFIX: test_device
TEST_SIZE: 30G
Benchmarking iops.fio into test_device-iops.json
Benchmarking bandwidth.fio into test_device-bandwidth.json
Benchmarking latency.fio into test_device-latency.json

=========================
FIO Benchmark Summary
For: test_device
CPU Idleness Profiling: disabled
Size: 30G
Quick Mode: disabled
=========================
IOPS (Read/Write)
        Random:              2,338 / 582
    Sequential:              284 / 1,733

Bandwidth in KiB/sec (Read/Write)
        Random:        203,861 / 211,113
    Sequential:        473,600 / 251,508

Latency in ns (Read/Write)
        Random:        603,878 / 697,203
    Sequential:        604,498 / 654,765

fixes #1123
rel: rook/rook#7575

@dghubble This should suffice for your minimal reproducer? Let me know if you need anything else.

Can you update with the info from the top part of https://github.com/poseidon/typhoon/issues/1123#issuecomment-1110015758?
Also, Flatcar Linux does not enforce SELinux. Was there reason its added there? That'll need testing as well (probably later this week) to be sure it doesn't have unexpected affects.


Projects using this - would you like to be linked from the README

Hello everyone,
I was looking to start a list of projects on my README that are using this library in the hopes of not only satisfying my own curiosity, but also to promote your works and hopefully draw others to both of our works.
So please comment with the link to your project, if you want, and let me know with a +1 if it would be alright to add your project to the README, otherwise I will assume you do not wish to be added.
Thanks in advance!

+1 https://github.com/ilgooz/stack


readium loader issue

is it possible to modify or change the loader in the reader when navigating from one page to another page

is there any possibility to remove the readium loader (spinner) from the reader

Sure:
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L210-L248
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L522
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L1077
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L1370
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L435
https://github.com/readium/readium-js-viewer/blob/57a5a47379acae01ad3c26ca8a31d22586f2a7be/src/js/EpubReader.js#L170


Disable API feature provider when network errors out

When corporate firewalls block the exp service this can cause the endpoint to time out. Sinc a lot of callers await exp via getTreatmentVariableAsync we effectively produce a ~10 second delay (how long it takes to timeout) at every await call. Since exp is non critical instead when the network errors out we should cease to make request to the exp endpoint for the duration of the session as things like a firewall block, empty response, or network errors are likely to be persistent for the duration of the session.

I generally recommend extensions use getTreatmentVariable instead of getTreatmentVariableAsync. The only time I think you should use getTreatmentVariableAsync is when you absolutely must have up-to-date flight info. Precisely for some of the issues you're trying to address here. Some more examples can be found here.
I wonder if that changes your thinking about how to address this?

things like a firewall block, empty response, or network errors are likely to be persistent for the duration of the session

I'm not sure how true this is. Definitely true for firewalls.. but for a spotty network connection, I don't think it's true (people leave VS Code running for days!) Since we background refresh the treatment assignment cache every 30 minutes, turning that off will lead to stale data on the next VS Code session (assuming using getTreatmentVariable instead of getTreatmentVariableAsync as discussed above).

Yeah these are all good points. We are still debating amongst the team what the solution should be to this issue. I am debating hiding getTreatmentVariableAsync within the GitHub Copilot Chat extension which is how we discovered this blocking issue as it seems to be what developers go for immediately as you would assume that you wanted up to date flight info. Also checkCache being default to false compounds this.


[Enhancement] allow create mv sql with bitmap index

Fixes #issue
https://github.com/StarRocks/starrocks/issues/32764
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[x] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 48 / 56 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
11
14
78.57%
[3168, 3173, 3174]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
31
36
86.11%
[512, 514, 515, 525, 530]

:large_blue_circle:
com/starrocks/sql/ast/CreateMaterializedViewStatement.java
6
6
100.00%
[]

How about altering the materialized view to add/drop indexes?

How about altering the materialized view to add/drop indexes?
https://github.com/StarRocks/starrocks/pull/31547

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 48 / 56 (85.71%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
11
14
78.57%
[3168, 3173, 3174]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
31
36
86.11%
[512, 514, 515, 525, 530]

:large_blue_circle:
com/starrocks/sql/ast/CreateMaterializedViewStatement.java
6
6
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 51 / 56 (91.07%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
11
14
78.57%
[3168, 3173, 3174]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
34
36
94.44%
[514, 515]

:large_blue_circle:
com/starrocks/sql/ast/CreateMaterializedViewStatement.java
6
6
100.00%
[]

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Can't find DS4 device(ps4 pro) with USB cable/--hidraw

[pc trialism]# ds4drv --hidraw
[info][controller 1] Created devices /dev/input/js0 (joystick) /dev/input/event23 (evdev)
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices
[info][hidraw] Scanning for devices

I'm on a fresh manjaro linux. I tried with bluetooth too but I got this:
[error][daemon] 'hcitool' could not be found, make sure you have bluez-utils installed.
bluez-utils is installed.

Same issue. Fresh install under Ubuntu with KDE.

Same issue. Linux Mint 19

Related to this issue:
https://github.com/chrippa/ds4drv/issues/104

I found solution. You need to edit /usr/local/lib/python2.7/dist-packages/ds4drv/backends/hidraw.py like here:
https://github.com/chrippa/ds4drv/pull/105/files

/usr/local/lib/python2.7/dist-packages/ds4drv/backends/hidraw.py

If you have python3.* installed, you may have installed ds4drv with pip3, so change the path slightly to /usr/local/lib/python3.*/dist-packages/ds4drv/backends/hidraw.py
where * is whatever version of Python 3 you're on

hcitool is an external tool you need to install.
Probably use bluetoothctl would make sense these days.
My controller shows: Sony Computer Entertainment Wireless controller, so maybe check case insensitive could help. Still I cannot connect by usb


Image data augmentation in BatchIterator

First, thank you very much for this. It's a fantastic tool!
I'm sorry to create an issue if this is user error but I'm totally stumped. Doing some googling, I've also saw that someone had a similar problem in the comments on the facial keypoints detection and I've seen comments about this same issue in the kaggle data science bowl competition. So I know that I'm not alone.
Anyway, I'm trying to modify the FlipBatchIterator example from your kfkd example to do some image translations (rotation and translation). Everything starts out ok and then after 10 epochs or so both the train and test loss starts to go up and the validation accuracy goes down. It could very well be a bug in my code but I can't figure it out. (This is MNIST data)
Here is the code. If I uncomment the plot_sample function and look at each image as it goes through the batch iterator it looks perfectly fine as well.
class DataAug(BatchIterator):

    def transform(self, Xb, yb):
        Xb, yb = super(DataAug, self).transform(Xb, yb)

        for i in range(Xb.shape[0]):
            # random rotations
            dorotate = randint(-3,3)

            # random translation
            trans_1 = randint(-2,2)
            trans_2 = randint(-2,2)

            # random zoom
            #zoom_1 = uniform(1, 1.01)

            tform = transform.AffineTransform(translation = (trans_1, trans_2))
									#scale = (1/zoom_1, 1/zoom_1))

            new = transform.warp(Xb[i][0], tform,
                            output_shape = (PIXELS, PIXELS),
                            mode = 'constant').astype(np.float32)

            new = transform.rotate(image = new, angle = dorotate,
                            resize = False, mode = 'constant').astype(np.float32)

            Xb[i][0] = new
            #plot_sample(Xb[i])

        return Xb, yb

And here is an image of the plot with the batchiterator loss.

Here is a plot in which I expanded the size of the dataset by doing the transformations and then appending them to the dataset. This worked very well, even though it was extremely slow due to the dataset size.

 Thank you again for this great tool.

When you write into Xb those changes will be persisted.  So next time you get an Xb, it will have images that are already translated and rotated, and you do it again.  If this is what's happening, then the way to fix this is to return a copy of Xb instead of writing into it.

 Thank you very much, that fixed it.


Remove non-standard paths from sandbox

A normal Nix installation (e.g. on NixOS) only adds /bin/sh to the sandbox. This script adds a few other paths that can cause builds to succeed when they wouldn't on NixOS, for example here: https://github.com/NixOS/nixpkgs/pull/74580#issuecomment-559759696
This PR removes the non-standard paths from the sandbox.

Very sorry for not responding to this PR sooner - apparently I managed to accidentally un-watch this repo and only just realised that there are a pile of PRs in here today.
Concerning this PR, these packages were all definitely necessary in the past for building from source, but clearly things have moved on since then and I haven't really kept up with it all, as I have recently moved from freelancing to working for a firm that requires me to use a Macbook for everything.  Would you consider becoming a maintainer of this package?  I think @tudurom may also be interested, so you could potentially share the burden?

@lopsided98 I've opened an issue (#12) to discuss maintainers - if you're interested, please let me know over in that issue.  Thanks :)


Imbalanced intent sample sizes during train

rasa NLU version): 0.7.1
Used backend & plattform: mitie_sklearn, Ubuntu 14.04
Issue: I will not provide any data examples they are so massive.
I found if I have 3 expressions in each intent and 9 expressions in one intent it's ok, if I add tenth expression and more the mess begins. Intents are eaten up by a greater intent and just ignored. Greater the quantitative difference, more and more small intents ignoring.
I can make a conclusion that more than triple quantitative difference broke it.

should be fixed with weighted class balancing (at least for the sklearn intent classifier - e.g. the spacy_sklearn pipeline)


NSNull saved in optional property is not exported to NSDictionary

I have some properties that needs to be optional. It looks like it is not possible to export this model with optional properties using toDictionary method in such way that NSNull will be saved in the NSDictionary. The correct behavior would be to skip only nil values from JSONModel when exporting to NSDictionary but [NSNull null] from JSONModel should be exported to NSDictionary. This way I could send json with null's to web service even for optional properties which currently seems to be impossible even when I explicitly set them to NSNull instead of nil.

Optional properties containing null values are ignored when serializing.

It would be good to have an option to force converting NSNull to null in json for optional properties as currently if we use optional properties then afaik there is no way to convert a model to json with null in it (and sometimes it would be useful when we need to send a null to a web service).

I have many cases where I need to send null to a web service. NSNull does seem like a good way of explicitly stating that you do want null to be sent.
I'd propose changing the default behavior to serialize instances of NSNull as null in all cases - even for properties marked as optional. Any opinions @icanzilb / @dbachrach ?

Yes I agree that this should definitely be possible. This will be a breaking change, though. Instead should we have this be opt in via a method:
- (BOOL)shouldSerializeNulls
{
    return NO; // Default
}

How often is NSNull actually used though? Surely in every normal use case, you'd just set it to nil. Along with that, sending null to most APIs is the same as not providing a value.
I'm just a tad concerned about the number of shouldXyz methods we're ending up with when really the default should be changed.

I think we should change the default behavior.
In case a null comes in from the server for an optional value - then JSONModel automatically converts that to nil so your "incoming" model would have nil for that property (or it will not be set in other words). So - if you are exporting your model to JSON to send it over to the server and you DO have an NSNull object stored in that property - it looks like you explicitly did set this value yourself - I can't see any other reason why you would have this value stored in an optional property.

Yes, that's my thought process also.

This seems fair. Let's make sure to call it out in the release notes.


Enable username recovery with case-insensitive attributes

Need to improve username recovery flow to work with case-insensitive attribute values.
Describe the improvement
By default, WSO2 IS queries the user claim values with case sensitivity. If the user provides the first name, last name, and email address in a different case, the username recovery flow will break by failing to find the user.
As an example, if the first name and email address in the database exists as john and<EMAIL_ADDRESS>and if the user provides claim values as joHn and<EMAIL_ADDRESS>in the username recovery flow, it will break.
For the cases where username recovery flow needs to work with case-insensitive attributes, we can improve the flow as below:

Introduce a new config to enable username recovery with case-insensitive attributes.
Improve the buildClaimWhereConditions method [1] to support case-insensitive attribute search

[1] - https://github.com/wso2/carbon-kernel/blob/4ebd8e135e2c1ef60878ff0818b7785abc5199c0/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/jdbc/UniqueIDJDBCUserStoreManager.java#L3680
Steps to reproduce

Configure a unique ID JDBC user store manager for the primary user store.
Enable username recovery and create a user. For example, set the first name to john and the email address to<EMAIL_ADDRESS>Try the username recovery flow by providing the first name and email address in different cases.

curl --location 'https://localhost:9443/api/identity/recovery/v0.9/recover-username/' --header 'Authorization: Basic YWRtaW46YWRtaW4=' --header 'Content-Type: application/json' --data-raw '[
    {
        "uri": "http://wso2.org/claims/givenname",
        "value": "joHn"
    },
    {
        "uri": "http://wso2.org/claims/emailaddress",
        "value"<EMAIL_ADDRESS>    }
]'

Additional context
https://github.com/wso2/product-is/issues/14957

Hi,
Found that isCaseSensitiveUsername] method is used to differentiate case sensitive and insensitive attributes and user names. We also decided to use this approach as a solution.
We need to set the CaseInsesitiveUsernames property to false in case DB is case insensitive.
We need to use LOWER() indexes to add to the product in case system DB is case-sensitive and case insensitivity support is enabled from the product level. like below:
 CREATE INDEX UM_ATTR_NAME_LVALUE_INDEX ON UM_USER_ATTRIBUTE(UM_ATTR_NAME, LOWER(UM_ATTR_VALUE));

Since the public PR is merged

Test Steps:

Configure a unique ID JDBC user store manager for the primary user store. (you can use following toml config)

[user_store]
type = "database_unique_id"

Enable CaseInsensitiveUsername

[user_store.properties]
CaseInsensitiveUsername=true

Enable username recovery
Try the username recovery flow by providing the first name and email address in different cases. You should get a email


Ndefries/signal spreadsheet updater script: updates to DUA and Quidel items

updates to DUA and Quidel items
Summary:

Prerequisites:

[ ] Unless it is a documentation hotfix it should be merged against the dev branch
[ ] Branch is up-to-date with the branch to be merged with, i.e. dev
[ ] Build is successful
[ ] Code is cleaned up and formatted

Sorry, wrong branch!


Rename query.toJSON to query.json.

The original PR, #94, made a poor choice in variable naming. We haven't released to npm, so we'd like to change the name before it's permanent.
Instead of:
table.read({
  keys: [...],
  columns: [...],
  toJSON: true
}, function(err, rows) {
  var row = rows[0]
  // row.Name = 'value'
})

This seems better:
table.read({
  keys: [...],
  columns: [...],
  json: true // <--
}, function(err, rows) {
  var row = rows[0]
  // row.Name = 'value'
})

@stephenplusplus Good call 👍


[Snackbar] Add support for multiline texts #3860

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Related to #3860.
Attempt to make the Snackbar support multiline text.
What do you guys think? I tried to follow as much as possible the material specs.
https://www.google.com/design/spec/components/snackbars-toasts.html#snackbars-toasts-specs
I added one example next to the simple one - would you like me to separate it? Its pretty much the same, only the second have the multiline property.

Also I changed the component to use ES6 class.. I saw we are doing it in some other components (TextField...) and I think that's the only way to the default value be displayed in the docs (Maybe I'm wrong, but I tried the getDefaultProps and it didn't work).

Thanks for putting this together @andrejunges.
Looking at the docs, it seems like multiline is only intended supported for mobile widths, and then only for two lines of text (80dp):

(There's also that last type, with the button below to accommodate longer mesaage / button text, but lets not overcomplicate things. :smile:
Desktop only allows for a single line of text, which is reasonable given they are for "showing a brief message". If the text takes more than one line on desktop, the message is too long, or it is the wrong component to use.

What do you think?
Second, I don't think we should require a prop for this. The message may be set from a variable, or based on i18n, and so the Snackbar could be single or multiline, depending on the message length.
For mobile sizes, we would need to detect if the text is wrapped (I think you should be able to read the height of the relevant container and see if it is over a certain size).
For the examples, having them in one is fine, but I think this syntax is cleaner:
onRequestClose={() => this.handleRequestClose('openMultiLine')}

Also, the buttons need vertical margin so that they don't mash together when wrapped at mobile widths. I think a single style for both buttons object with margin: '4px 8px 4px 0' would do the trick.
Finally, I assume the long timeouts was just for convenience while adjusting the layout? :smile:

Well, I don't see any problem in supporting it for desktop - it may be useful for some users and won't harm the others. Not sure if you wanna follow 100% the specs, then we can make it only for mobiles, not a big problem I guess, as you said maybe the user is using the wrong component.
For mobile sizes, we would need to detect if the text is wrapped (I think you should be able to read the height of the relevant container and see if it is over a certain size).
To detect the sizes, do you think it'd be better to render it and check it's size? maybe we could just establish a certain size per letter and check the text`s length (it would break if the user changes the fontSize though..)
Regarding the examples
That's a good suggestion - the changes on the handleRequestClose call. I don't see what you mean on the buttons mashing together on mobile, but I'm gonna check it again when I get some time.
And yes, I make them huge while I was doing my tests - forgot to change it back :smile:

Sure, there are many other things a developer could do with Material-UI that are out of spec (and Material-UI doesn't follow it perfectly in places), so lets limit to two lines, and if dev abuses that on desktop, it's their (users) loss. :)
Better to render and check rather than make assumptions about character width. Setting ref="message' on the , and using this.refs.message.scrollHeight should do the trick I think?

I don't see what you mean on the buttons mashing together on mobile

They have no vertical margin, so end up right on top of each other if they wrap at small screen widths.

Perfect.
Agree with you, scrolHeight should be enough. Also now I see what you mean.. I didn't include any padding/margin because they are way bigger than the text itself - and it would increase even more the element's height. Now that we're gonna support only two lines I can set it's height to 80p and add those margins easily I guess.

Also now I see what you mean..

I was talking about margin for the buttons on the example page specifically:

I think a single style for both buttons object with margin: '4px 8px 4px 0' would do the trick.

But I imagine you will need to adjust that internally for the Snackbar layout itself.

@andrejunges any updates on this?

@Aweary well, I didn't move forward on this because we weren't sure how to address the responsive problem - that will replace the mixin.
We discussed about using an HOC / react-event-listener / react-look.. but we didn't reach any conclusion..
What do you guys think about it? what would be the best approach?

@andrejunges - I would say that while switching to an ES6 class was a step in the right direction, and thanks for doing that - but if it prevents you from completing this PR because of the mixin, you're not obliged to continue down that path.
I would suggest to revert to createClass in order to complete this, and we can tackle the mixin issue separately.

@mbrookes @andrejunges That's actually why that component missed the boat in the refactor.

@andrejunges I'm working on porting this component to ES6 classes. Hold on.

@andrejunges - the mixin is gone, so you should be able to wrap this up when you get time. 👍