Fix a DestinationRule for the bookinfo egress test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-unit-tests

prow/istio-presubmit.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

/test istio-unit-tests

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [rshriram]
tests/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-pilot-e2e-envoyv2-v1alpha3

/test istio-pilot-e2e-envoyv2-v1alpha3

Removing the no-cla label, both of the commits are mine, including the one that is cherry-picked.

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c265555d0892743122027d5226f55525220b05c4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


refactor(coral): Replace hacky notification solution in ProfileDropdown

Linked issue
Resolves: #1810
What kind of change does this PR introduce?

[ ] Bug fix
[x] New feature
[ ] Refactor
[ ] Docs update
[ ] CI update

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x]  Tests for the changes have been added (for bug fixes / features)

Hey @dotarjun thanks a million for opening this PR! Just wanted to let you know that the Klaw teams experts and reviewers in this area are off today and tomorrow but will review it as soon as they are back :) Thanks a million!

Thank you for the PR! Reviewing it now. Regarding this requirement of a PR:

The commit message follows our guidelines

This also applies to the title of the PR, as we squash all commits when merging to main, the title becomes the commit message ^^

Hi! I checked the tests - the mock for useToastContext needs a little update, since it does not return one function (like useToast does) but an array with functions. These are the updates that need to be made:
I'll mark the changes in code!

@programmiri I think I have fixed it now

@dotarjun  saw you updated the PR, looks great! The snapshot test still needs to be updated, as you can see, the pipeline is failing. This is based in the update of the design system and the change is correct, so you can run pnpm jest --updateSnapshot or pnpm test -- -u in /coral to update the snapshots.

I get this error.
  ● Layout.tsx › enables user to navigate all navigation element with keyboard › sets focus on the first element of the quick link naviga
tion if user tabs 4 times

    ToastContext was used outside of provider.

      33 | const LOGOUT_KEY = "logout";
      34 | function ProfileDropdown() {
    > 35 |   const [toast, dismiss] = useToastContext();
         |                                           ^
      36 |   function navigateToAngular(path: string) {
      37 |     window.location.assign(`${window.origin}${path}`);
      38 |   }

@dotarjun  ah, sorry I didn't notice that sooner.
In the mock for toast, you returning an object, but useToastContext needs to return an array:
jest.mock("@aivenio/aquarium", () => ({
  ...jest.requireActual("@aivenio/aquarium"),
  useToastContext: () => ([
    mockToast,
    mockDismiss,
  ]),
}));

I checked out your branch and tested it there with the array and for me, it works. Can you try again? Thanks for hanging in there 🙏
Also, your branch needs to be updated manually as it has a conflict.

@dotarjun please fix the conflict so that the github actions can run ^^

The forced push was done as I accidentally pushed the changes I made for #1845 on this branch.
I cherry picked the relevant commits to the correct branch and then removed the unnecessary commits by interactive rebase.
Then I had to force push to remove the misleading commits on this branch.

@dotarjun there are many CI failures regarding the TS compiler and tests, do you need assistance?

@dotarjun there are many CI failures regarding the TS compiler and tests, do you need assistance?

@mathieu-anderson Yeah. I dont understand why. I think it's because of incorrectly resolving merge conflicts.

If you suspect this is the case, I would try:

delete node_modules and pnpm-lock.yaml
pull latest main
run pnpm install

Then run pnpm run tsc and pnpm test to verify is errors are still present.

@dotarjun you may also want to address the lst issue I pointed out on this PR: https://github.com/Aiven-Open/klaw/pull/1845#issuecomment-1768463744
And then you wo't have to update aquarium in this PR because it will already have been updated ^^

@dotarjun so now there is a new conflict because this PR was merged: https://github.com/Aiven-Open/klaw/pull/1845
Probably pull the latest main on your local branch and make it so that this branch uses aquarium 1.43.0 as well ^^

@dotarjun , I was going to merge but I found that there was still an oversight in the code ^^ https://github.com/Aiven-Open/klaw/pull/1824#discussion_r1370169960

@dotarjun I hope you don't mind but I pushed a commit to fix the broken tests, as this is the last day of Hacktoberfest and it would be nice to merge this PR today ^^

@mathieu-anderson thanks a ton. I've been quite busy with some personal obligations. It's the festive season here in India so I've been busy with that. I'll be getting back to contributing soon 🚀
I really appreciate your covering up for me 😄

@dotarjun merged ^^ Thank you!


Make it possible to test the REPL

As more features gets added to the REPL it would be nice to improve the testing for it. The REPL can however be tricky to test as one needs to be able to send commands to the terminal programmatically. In python I found the pexpect library which seems to be able to do this. It is a bit of a heavy weight solution to take on a python dependency just for some tests though and it would really nice if a library like pexpect could be ported to RUST. I don't have a good estimate to how much work such a port would be but it might be an interesting project to do (which would likely be useful outside of gluon as well)!

It appears a crate has been worked on recently with that aim - rexpect, and trying it with the gluon repl, and it works! I'll open a PR for some basic tests, mostly based off the tutorial as if a new user was following along. More tests needed, and currently, boilerplate could be cut down.

One issue, which may be a combination of a more general REPL issue, is if a test fails, the error is a bit of a mess due to unwrapping the error-chain struct. It was especially so when testing the :i names example in the readme.
repl.send_line(":i std.prelude.List").unwrap();
repl.exp_string("type std.prelude.List a = | Nil | Cons a (std.prelude.List a)").unwrap();

which fails while manually using the repl as well. It outputs the entire source of the prelude in the repl + the error does not have the field `List.  Wrap that in the error-chain struct then .unwrap() it -- it isn't pretty. Similarly, when manually creating a function in the repl with let f x = x + 1, the repl outputs the entire expansion in return, which I was unsure if expected behavior (instead of returning something like Int -> Int), so there are not tests included for that as well.

The error messages you see should be filtered down a bit it just haven't been implemented for https://github.com/gluon-lang/gluon/blob/d7ce3e81c1fcfdf25cdd6d1abde2b6e376b4bf50/vm/src/lib.rs#L120-L122 (unification errors gets filtering applied here https://github.com/gluon-lang/gluon/blob/d7ce3e81c1fcfdf25cdd6d1abde2b6e376b4bf50/check/src/typecheck.rs#L118 though there is rather a lot code ther right now.

Similarly, when manually creating a function in the repl with let f x = x + 1, the repl outputs the entire expansion in return, which I was unsure if expected behavior (instead of returning something like Int -> Int), so there are not tests included for that as well.

https://github.com/gluon-lang/gluon/issues/467


Adding Binghamton University

University webiste: https://www.binghamton.edu/
Computer Science undergraduate program URL: https://www.binghamton.edu/computer-science/undergraduate-programs/
URL to faculty profiles. Shows that domain is binghamton.edu: https://www.binghamton.edu/computer-science/people/

@NarmadaSambaturu I am sorry, the domain binghamton.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Hi,
I am sorry to hear that this domain was abused in the past.
I am a faculty at Binghamton University. Could you please let me know the
procedure to request for the JetBrains educational subscription as a
faculty?
Thanks,
Narmada Sambaturu
On Wed, Aug 21, 2024 at 2:28 AM Philip Torchinsky @.***>
wrote:

@NarmadaSambaturu https://github.com/NarmadaSambaturu I am sorry, the
domain binghamton.edu is removed from our trusted domains list because it
was abused in the past. If you are the student of this school, please
enroll to GitHub Student Developer Program
https://education.github.com/discount_requests/application. Then apply
for JetBrains educational subscription with your GitHub account (GitHub
tab at https://www.jetbrains.com/shop/eform/students).
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/22784#issuecomment-2301233230,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADR3EB3PQED4XUYYTZFCLW3ZSQXPRAVCNFSM6AAAAABM2M7CTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGIZTGMRTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Error on Raspberrian

Error occurs when trying to use await/async functions.
Here is full stacktrace returned by node
http://pastebin.com/4DAMxaTW

I see the stack trace, but I can't see the actual exception message in there. What is the text of the error message? And can you show the part of your source code where the error is occurring?

Yeah, this is a problem. No error text.
I run script like this

And all content from debug.log i pasted to pastebin.
Also my script contains:
var async = require('asyncawait/async');
var await = require('asyncawait/await');

async(function(){})

Looking at the stack trace, it seems to be failing at startup trying to load bluebird, on the line:
var Promise = require('bluebird');

Can you try running that line on its own in your source file? Does it work?

I've added bluebird into packages.json, and then add require on top of my script.
Script start and finish correctly.

OK. There is something strange about the stack trace. The error appears to come from bluebird as per line 1 of the stack trace. That line indicates the error occurs in the file /home/pi/smarthome/node_modules/asyncawait/node_modules/bluebird/js/main/queue.js.
The current version of bluebird 2.9.34 (that should have been installed with asyncawait) does not have a file at that location. There is a file bluebird/src/queue.js, but that does not contain anything called _makeCapacity as is referenced in line 1 of the stack trace.
So what version of bluebird is installed at /home/pi/smarthome/node_modules/asyncawait/node_modules/bluebird?

I have installed 2.3.11 which correctly according to package.json in asyncawait package
"dependencies": {
    "bluebird": "~2.3.11",
    "fibers": "~1.0.1",
    "lodash": "v2.4.1"
  },

I see. There is a _makeCapacity in that version of bluebird, and it is crashing according to your stack trace (but apparently with no error message). I'm not sure how else to help. I'm not sure why bluebird would crash on startup. I've never seen such an error in any other environment and I can't reproduce it.

I see node-fibers is also there at the bottom of the stack trace. That is a binary module and is not compatible with all platforms and node versions. Perhaps you could try to find out whether node-fibers is compatible with your setup.
You could try that out by doing npm install fibers and then running the following sample taken directly from the node-fibers README:
var Fiber = require('fibers');

function sleep(ms) {
    var fiber = Fiber.current;
    setTimeout(function() {
        fiber.run();
    }, ms);
    Fiber.yield();
}

Fiber(function() {
    console.log('wait... ' + new Date);
    sleep(1000);
    console.log('ok... ' + new Date);
}).run();
console.log('back in main');

The expected output according to the README should be something like:
wait... Fri Jan 21 2011 22:42:04 GMT+0900 (JST)
back in main
ok... Fri Jan 21 2011 22:42:05 GMT+0900 (JST)

I fixed it! I installed Node.js version 0.10.40 by compiling it on the Raspberry Pi itself. I used this walkthrough: http://www.armhf.com/node-js-for-the-beaglebone-black/
I think the problem is i have the latest Raspberry Pi which has a diffrent CPU architecture from other.
And all binaкies from repos are incompatible.

That's great to hear! I'll close this issue then. Happy coding.


Populate limit option on deep collection

The populate limit option doesn't seem to apply to deep collections as expected (or at least what I expect it to).
For example...
user.deepPopulate('items.subitems', { populate: { 'items.subitems': { limit: 3 }}}, ...
This returns only 3 total populated subitems, rather than 3 populated subitems per item. If there were 4 items, I thought this would return 12 total populate subitems, 3 from each.
Is this the expected functionality of the limit option?
It wouldn't be a significant issue for me if I had to just set the limit to 12, but the problem is the limit is applied to the first item's subitems, so it returns 12 subitems from only the first item.

The options look wrong. Try this:
user.deepPopulate('items.subitems', { populate: { 'items.subitems': { options: {limit: 3} }}}}, ...

Underneath, the plugin just invokes Mongoose#populate with these options. So the exact behavior is totally up to Mongoose.

Sorry, that's what I had in my code. I just forgot the options key in the example I included. I guess mongoose is applying the limit to the entire query...

Might be related to this bug https://github.com/Automattic/mongoose/issues/1490. Probably try to upgrade Mongoose?

Looks related, but I tried upgrading mongoose to 3.8.20 & 3.8.29 with no luck.

@mnort9 does seem like a bug to me because the behavior you described isn't intuitive. You might want create an example using populate() directly and post an issue in mongoose.


Crash when NI hardware in use is disconnected.

In the long term the way this gets fixed is to move communications with this hardware out of process and while trying to avoid the communications process crashing cope with the situation if it does. This approach may be required as NI DAQmx Base cannot be linked at runtime with a 64 bit binary on Mac OS X and it's only going to get harder to keep making 32 bit builds of Typica and its dependencies. There is a branch that attempts to solve this in process, but it is not yet clear how successful that work will be.

I had a branch where I was working on this problem without resorting to separating the code out of Typica's process, but I haven't been able to get to the bottom of some segmentation faults that are happening on the NI side of things. I may need to resign myself to the prospect of whatever process handles communication with this hardware crashing, in which case the most sensible thing to do is get that code out of Typica and into an external process that Typica can restart when needed. Unfortunately, I do not believe that I will be able to get that done before the release of Typica 1.7.


PaletteEditor

Description

PaletteEditor allows you to easily create palettes via GUI and preview the colors in real time.

You can save and load palettes.
You can directly input rgb HEX value of a color by pressing #
Select a color using the arrows on your keyboard
You can load PaletteSelect directly to easily select different palette.

Remaining Bugs

[ ] Palettes are not persistent

Can work around by manually setting them in MakeHome.CC like this: PaletteSet("MyNewPalette");

[ ] Pressing "CANCEL" from Palette Selector makes the OS crash

Improvements

[ ] Currently hardcoded path in ~/PaletteEditor and ~/PaletteEditor/Palettes
[ ] Sizing and positioning values of elements are convoluted
[ ] Saving just with the name? (no filepath or .CC)
[ ] Make text readable regardless of light or dark theme

There is a color treshhold that displays a differently colored background over light/dark text so as to make it readable.

Instead of a #CCCCCC threshold, should split the values of R,G,B and add them as to find luminosity, that way even a color like #00FFFF would work.

I like this! :+1:


Assess the usefulness of nmdc-schema (not MIxS) subsets

{'data_object_subset': ['DataObject'],
 'data_portal_subset': ['associated_dois',
                        'doi_value',
                        'doi_provider',
                        'doi_category'],
 'environment': [],
 'investigation': [],
 'nucleic acid sequence source': [],
 'sample_subset': ['Biosample', 'Study', 'DataGeneration'],
 'sequencing': [],
 'workflow_subset': ['WorkflowExecution',
                     'MetagenomeAssembly',
                     'MetatranscriptomeAssembly',
                     'MetagenomeAnnotation',
                     'MetatranscriptomeAnnotation',
                     'MetatranscriptomeAnalysis',
                     'MagsAnalysis',
                     'MetagenomeSequencing',
                     'ReadQcAnalysis',
                     'ReadBasedTaxonomyAnalysis',
                     'MetabolomicsAnalysis',
                     'MetaproteomicsAnalysis',
                     'NomAnalysis']}

I don't believe that any of these add and value at this time:

data_object_subset
data_portal_subset
environment
investigation
nucleic acid sequence source
sequencing

See also

xxx

some of the subset names above include white-space
some have already had white-space replaced with underscores
see also

xxx


Showing Local Notifications in Flutter using Native Code

I am trying to implement Push Notification in my Flutter application using Firebase Messaging.
I understand complete working of Firebase Messaging that If your app is in foreground onMessage is called for both android and IOS.
So, in that case, we need to create notifications locally and show it to the user.
I am using another flutter package for showing local notifications flutter_local_notifications. It works correctly in android but in IOS it conflicts with firebase_messaging library.
So now I need to know how I can handle onMessage. Can I just call the native code to create a local notification for each platform?
and did anyone out there handled this issue in a better way? Also if I need to call native code, How can I create notifications for both android and IOS.

I do, what I am doing is to comment out the delegate of the flutter_local_notification from the source code for iOS.

It has the drawback that you need to maintain that in the future if you upgrade the package, but is an easy one.
I hope this works for you.

@abumoallim ongoing discussions are going in https://github.com/MaikuB/flutter_local_notifications/issues/111 and https://github.com/flutter/flutter/issues/22099, please follow it. Closing as a duplicate.


[fix][doc]Correcting spelling mistakes in the pulsar-broker module

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications
Corrected all spelling mistakes I found in the pulsar-broker module.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #20798 (ff51d5e) into master (4e2ba4b) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #20798      +/-   ##
============================================
+ Coverage     73.10%   73.12%   +0.01%
- Complexity    32108    32131      +23
============================================
  Files          1866     1867       +1
  Lines        139028   139058      +30
  Branches      15294    15299       +5
============================================
+ Hits         101634   101683      +49
+ Misses        29333    29306      -27
- Partials       8061     8069       +8

Flag
Coverage Δ

inttests
24.08% <30.00%> (-0.10%)
:arrow_down:

systests
25.05% <30.00%> (+0.03%)
:arrow_up:

unittests
72.41% <50.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...dbalance/extensions/scheduler/TransferShedder.java
82.92% <ø> (ø)

...ache/pulsar/broker/service/plugin/EntryFilter.java
100.00% <ø> (ø)

...r/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
77.20% <ø> (ø)

...lsar/common/policies/data/OffloadPoliciesImpl.java
83.43% <37.50%> (-1.28%)
:arrow_down:

...va/org/apache/pulsar/broker/service/ServerCnx.java
71.27% <100.00%> (-0.12%)
:arrow_down:

.../persistent/ReplicatedSubscriptionsController.java
69.62% <100.00%> (-1.91%)
:arrow_down:

... and 86 files with indirect coverage changes


New home

Hey @diogoreisrodrigues,
Happy to see you find our website template useful! It seems like you forked before we updated our License in the README. Could you please remove our content assets from your repositories and website (i.e., https://github.com/feelab-info/feelab-info.github.io and https://feelab.info/)?
Please carefully remove our contents in the directories in:

https://github.com/feelab-info/feelab-info.github.io/blob/master/_bibliography/papers.bib
https://github.com/feelab-info/feelab-info.github.io/blob/master/_data/projects.yml
https://github.com/feelab-info/feelab-info.github.io/blob/master/_data/coauthors.yml
https://github.com/feelab-info/feelab-info.github.io/tree/master/_news
https://github.com/feelab-info/feelab-info.github.io/tree/master/_pages
https://github.com/feelab-info/feelab-info.github.io/tree/master/_supports
https://github.com/feelab-info/feelab-info.github.io/tree/master/_theses
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/og
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/pdf/papers
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/uzh-summer-school-2022
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/projects
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/support

Please consider the following licensing of this repository:
The website code and theme are available as open source under the terms of the MIT License. All content, including texts, blogs, images, and articles, are licensed under CC BY-ND 4.0, if not stated differently within a document or its nearest parent LICENSE file.
Thank you and happy coding,
Daniel

Hey @diogoreisrodrigues,
Happy to see you find our website template useful! It seems like you forked before we updated our License in the README. Could you please remove our content assets from your repositories and website (i.e., https://github.com/feelab-info/feelab-info.github.io and https://feelab.info/)?
Please carefully remove our contents from:

https://github.com/feelab-info/feelab-info.github.io/blob/master/_bibliography/papers.bib
https://github.com/feelab-info/feelab-info.github.io/blob/master/_data/projects.yml
https://github.com/feelab-info/feelab-info.github.io/blob/master/_data/coauthors.yml
https://github.com/feelab-info/feelab-info.github.io/tree/master/_news
https://github.com/feelab-info/feelab-info.github.io/tree/master/_pages
https://github.com/feelab-info/feelab-info.github.io/tree/master/_supports
https://github.com/feelab-info/feelab-info.github.io/tree/master/_theses
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/og
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/pdf/papers
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/uzh-summer-school-2022
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/projects
https://github.com/feelab-info/feelab-info.github.io/tree/master/assets/img/support

Please consider the following licensing of this repository: The website code and theme are available as open source under the terms of the MIT License. All content, including texts, blogs, images, and articles, are licensed under CC BY-ND 4.0, if not stated differently within a document or its nearest parent LICENSE file.
Thank you and happy coding, Daniel

Hi Daniel,
Thanks for reaching out and for the clarification. I’ll review the repositories and website content you’ve highlighted and ensure that all the necessary assets are removed as per the updated license.
Also, thank you for the amazing template! Apologies for accidentally making a pull request to the main repository. I'll get this resolved promptly.
Best regards,
Diogo


Actor boundary warning when conforms to a protocol that has non-isolated internal properties of public types

Description
I am getting warning when I build the following code with -warn-concurrency flag.
@MainActor
protocol MyProtocol {
    nonisolated var value: Value { get }
}

public struct Value {}

struct MyStruct: MyProtocol {
    let value = Value()
}

warning: non-sendable type 'Value' in conformance of main actor-isolated property 'value' to protocol requirement cannot cross actor boundary

Steps to reproduce

Copy the above code into a file named test.swift.
Run swift -warn-concurrency test.swift.

Expected behavior
The code should not produce a warning if it is legal code.
Environment

swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-<IP_ADDRESS>.2 clang-14<IP_ADDRESS>.100)
Target: arm64-apple-macosx13.0
Xcode 14.3, Build version 14E222b

Additional context
When the access modifier of Value is internal, I am not getting the warning.

This is correct behavior; because Value is public, the conformance to Sendable has to be explicit. The correct fix is to mark Value as Sendable:
@MainActor
protocol MyProtocol {
  nonisolated var value: Value { get }
}

public struct Value: Sendable {}

struct MyStruct: MyProtocol {
  let value = Value()
}


Unable to save MP4 movie file with H264 profile

Issue
When using File > Save > Movie or Sequence it doesn't seem be able to export H264 profile.

To reproduce:

Try to save to hello_world.mp4
Saving Options > Profile H264

Logs show:
ERROR: [save] C:/Users/User/Desktop/hello_world.mp4: Unknown error occurred

Specifications
Tested in mrv2 0.61 on Windows 10.

Additional info
Additional bug, when trying to save again afterwards the Save Dialog remembers the last filename - if that file exists then it directly highlights/selects it in the view as well. Then if you type a different name to write to it will still save to the selected entry and NOT to the manually typed name. The only workaround seems to be to clear the filename, browse to a different folder, go back into the folder and then type the name you want to write to instead.
If you write a .mp4 or .m4v file without a PROFILE selected (it's set to None in the Saving Options) then it writes out a file that mrv2 can read and playback, however when e.g. dropping them into an application like Slack the video will not play back correctly. (Likely unsupported codec?). As such, it currently seems to be impossible to write out a decent MP4 file to share with a client that works in e.g. an app like Slack they might be using.

@BigRoy Encoding of H264 movies requires x264 with a GPL License.  Unfortunately, that license is incompatible with mrv2's BSD-3 License.
The bug with the file requester is fixed in main HEAD.

Encoding of H264 movies requires x264 with a GPL License. Unfortunately, that license is incompatible with mrv2's BSD-3 License.

That's only really the case then for the precompiled releases, right? If one were to compile with ffmpeg manually it could support the x264 just fine? If so, any input on how to do so?

Alternatively, you can try the instructions (untested by me):
https://www.roxlu.com/2019/062/compiling-ffmpeg-with-x264-on-windows-10-using-msvc

I placed a script called ffmpeg_windows_gpl.sh in the root of mrv2 that will compile libx264 and ffmpeg on Msys.  The only thing missing is that it will not support webm (libvpx).

I updated ffmpeg_windows_gpl.sh to also compile libvpx, so you get a full GPL build of mrv2.


Naming

I'm not sure why I called this readme-standard. I think standard-readme is better. I know this is bikeshedding, just, thinking of changing it.
Anyone else have thoughts, while I'm at it?

Renamed.


[$250] Cursor goes to the start of a typed message when switching tabs

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.26-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724950469201189
Action Performed:
Prerequisite: User have two active tabs in browser

Go to staging.new.expensify.com and login
Initiate a DM with any user and compose message
Switch to next Tab and switch back to expensify tab

Expected Result:
Cursor position stays on end of the composed message
Actual Result:
When switching tabs on web from New expensify to a different tab and then switching back,  cursor goes to the start of a typed out message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/293a7bf3-5186-426f-b525-f42a86253d26

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b35c29cacea78360
Upwork Job ID:<PHONE_NUMBER>513970460
Last Price Increase: 2024-09-04

Issue OwnerCurrent Issue Owner: @sobitneupane

Was able to repro. This is minor but pretty annoying, seems worth fixing!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Cursor goes to the start of a typed message when switching tabs
What is the root cause of that problem?
Cursor position were being reset on losing focus.
What changes do you think we should make in order to solve the problem?
We re-render the component upon arrival to app so that all positions values get updated.The change is to pass the default value to child component so that the undefine may not cause cursor issue.
The "ComposerWithSuggestions" is showing the textfield whose value update after setting the cursor position. So we have included a useEffect() hook to check when browser switch tab or re-visit app then the component will update its state by updating the key value of view showing the content.Hence when component rendered then we update its state so that all values get aligned correctly.The "RNMarkdownTextInputWithRef" missed default value so we add that in order to remove undefine value warnings.
Following changes will fix the issue.

https://github.com/user-attachments/assets/ad5f6f7d-423a-442b-bc3f-cf483afcbc62

I cannot reproduce the issue in staging. Looks like the issue is no longer reproducible.

I can't repro either, seems fixed


Log git SHA when transformers/accelerate are installed from source from local

As per title.
e.g.
hydra:
  job:
    env_set:
      TRANSFORMERS_PATH: /home/fxmarty/transformers

can be set in the yml config (or manually).

Can you resolve the conflicts? I'd like to merge but I can't resolve the conflicts because it's on your fork I guess.
Also, can we make it log the sha of all the hf libraries since we use main branches 😅 dunno if that's too verbose.


Just for fun

https://cmake.org/cmake/help/latest/module/FetchContent.html

added to the lesson material.


[Candidate 1v1 Arizona Airfield ZH v1] Buildings at docks are not selectable but can be clicked into

Issue Description
Buildings at docks are not selectable but can be clicked into.
Expected behavior
Buildings at docks are selectable or cannot be clicked into (impassable).
Screenshots

Fixed. New version v2 will be on GR.org topic

They can now be selected, but not killed. May I suggest to make them killable if selectable, or impassable and not selectable, if not killable?

In latest version, all structures near Oils, except the crane, are destructible.
There are now 2 problems:

At the bottom, Units cannot move through the crane, but at the top they can. This ideally should be consistent.

After killing the Shipping containers, the terrain is still impassable and units cannot move over the empty space. On both sides.

Maybe we should have left it exactly like it was hey?

There are different ways to design this. The executed design just needs to be properly polished.
In original design buildings were not selectable, but could be clicked into, meaning the mouse cursor would show it was passable.
Now structures are selectable and destructible, but there are pathing issues.

ok in next version cranes made the same, plus shipping containers made indestructible so that the impassable terrain underneath remains always correctly.

Arizona Airfield v4.zip
ok everything fixed, including supply position and the dock area is now working perfect


Replace Left/Right with Failure/Success

Update to dry-monads 1.0.0.beta1 breaks dry-transaction

@Morozzzko Realised I should bump our "major" number, since this would break things for people still using Either monads, so this is now released in 0.12.0.


Feature request: Service Account mechanism

Hi,
Can we use Service Account mechanism instead of Basic authentication?
https://www.elastic.co/guide/en/elasticsearch/reference/current/service-accounts.html
Thanks

Hi @husnialhamdani, thanks for the suggestion. Honestly, I did not even know about service account support in ES so thanks for pointing that out too :-).
However, my understanding after reading the docs, is, that there are only 3 built-in service accounts, that should be used for 3 very specific cases:

Fleet server - ES authentication
Kibana - ES authentication
Enterprise search - ES authentication

From that, it seems like the ECK-CR operator authentication with ES won't work (or maybe it will but should not be used?), or did I misunderstand the usage of service accounts?


Expose YAML validation features as standalone tool

Looking at this document (which I found with some help) it seems that this repository contains all the necessary functionality to validate YAML pipeline definitions locally, without actually sending any build commands to build servers.
I tried to use run.sh --yaml  --what-if as shown in that document, but that complained about not finding bin/Agent.Listener and I couldn't find any instructions on how to build that file correctly. However, based on the descriptions in the document, it seems to do exactly what I would need to avoid having to push code to the repository just to see if my build config is valid.
It would be awesome if that could be exposed as something I can run from within my repository (e.g. a dotnet global tool).

+1 on this - Preferably via a CLI which we can pull in via NPM and maybe even a Azure DevOps task as well.

Yes, it's on our short backlog to create a cli

Did this ever get built?

Another thing which can be done is to make it like Gitlab - you can create an online validation tool (which is basically just a textarea) in the Azure Pipelines web app. The user will paste their yaml, and it'll show all the validation errors.

That's a good tool indeed and would certainly help!
However, a standalone tool is a must as it should be able to run as part of a CI build.

/cc @gopinathch

Is there any progress on providing this tool. The tool should  help you validate and test your yaml instead of running your pipelines all the time.

Since it has not been mentioned, the VSCode extension does at least some local validation (I get red squigglies using invalid keywords and indentation): https://marketplace.visualstudio.com/items?itemName=ms-azure-devops.azure-pipelines
(the extension appears to use ajv, which I tried to run manually, via pajv, but got some errors -- for a pipeline schema which otherwise builds successfully. Probably just a configuration issue.  Have not dug further as the extension is working great for me - thanks!)

We have shipped a server-side API for this. No plans to ship a fully standalone version, though, because the amount of server logic we would have to reimplement is too great.
POST to dev.azure.com/<org>/<project>/_apis/pipelines/<pipelineId>/runs?api-version=5.1-preview with a JSON body like this:
{
  "PreviewRun": true,
  "YamlOverride": "
# your new YAML here, optionally
"
}

The response will contain the rendered YAML.

@vtbassmatt Are there plans to provide a task for this at least?
It's a bit cumbersome to re-implement this for every customer.

No plans to implement a task. By default, the build identity doesn't have permissions to queue a dry-run build. But if you alter that, it's a relatively short shell script:
pool:
  vmImage: ubuntu-latest

steps:
- checkout: none
- bash: |
    RUNS_URL=${SYSTEM_TEAMFOUNDATIONCOLLECTIONURI}${SYSTEM_TEAMPROJECT}/_apis/pipelines/${SYSTEM_DEFINITIONID}/runs?api-version=5.1-preview
    echo $RUNS_URL
    curl --user PAT:$(System.AccessToken) \
      -sS \
      --header "Content-Type: application/json" \
      --request POST \
      --data '{"PreviewRun": true,"YamlOverride":"steps:[{checkout:none}]"}' \
      $RUNS_URL

(Obviously replacing the payload with your chosen YAML.)

Thanks!

@vtbassmatt This works great, I made a powershell cmdlet for it.
https://gist.github.com/JustinGrote/4ece827540da00d5ffce1d9eb593e56c
One thing: The most useful thing for this would be testing templates to make sure they expand properly. Is there any way in the YamlOverride to specify multiple files or somehow test templates?

@JustinGrote that cmdlet is great, thanks for sharing! We don't have a multi-file version of this endpoint right now, but feature request noted.

@vtbassmatt noted. What I would recommend is that since yaml supports multiple document syntax with '---', to be able to add a comment or something to indicate which file it would be (by file path), that way the document and all its related sub templates and whatnot could be supplied as one entry to YamlOverride

@JustinGrote Any plans on publishing this to PowerShell modules gallery?
+1 on multi-file support as we heavily use YAML templates

We are also using templates heavily, but have centralised them in a single repository. I've now setup a build pipeline for that repository to validate all the YAML pipelines that use that repository with the new changes being made to it. This allows us to validate the changes before merging them which could potentially break all our pipelines. Not anymore with this feature which is nice. Maybe I should write a blog post ;).

If YAML templates are supported then I'm happy - Will give it a go.
Feel free to write that post, happy to share.

@tomkerkhove it looks like @SebastianSchuetze is going to add it to the https://github.com/DarqueWarrior/vsteam module based on a twitter exchange we had :)

Great to hear, thanks!

@tomkerkhove I am currently sitting at the code for the PR

@SebastianSchuetze it's part of the preview API docs but I can't find the link anymore, however both of these reference the info:
https://github.com/microsoft/azure-pipelines-yaml/issues/34#issuecomment-584253286
https://docs.microsoft.com/en-us/azure/devops/release-notes/2020/pipelines/sprint-165-update#preview-fully-parsed-yaml-document-without-running-the-pipeline
Also if you look at my source code it's laid out there too.

We're working on getting the API docs to accurately reflect this (and other Pipelines endpoints).

@vtbassmatt thank you, and FYI while this is a welcome change, the inability to resolve/test templates (which requires a separate file unless theres some magic you can bestow upon me) kinda limits its usefulness, since expanding ${{ each and ${{ if statements is my primary big use case for this vs. commit over-and-over.

So I've been testing this out and this seems to only work if your entire pipeline definition is in a single file, and/or you are only trying to validate the pipeline entry point file, which doesn't work for us. We generally use templates, and as soon as you do that, it doesn't seem like it's possible for those to be picked up. If I make a typo in my local template file and then run this script, it succeeds and I see that my local files aren't being used in the expanded yaml. Is this scenario not supported?

@stevenbrix @vtbassmatt already commented on this. the short answer is "not yet"
https://github.com/microsoft/azure-pipelines-yaml/issues/34#issuecomment-590324653

So I've been testing this out and this seems to only work if your entire pipeline definition is in a single file, and/or you are only trying to validate the pipeline entry point file, which doesn't work for us. We generally use templates, and as soon as you do that, it doesn't seem like it's possible for those to be picked up. If I make a typo in my local template file and then run this script, it succeeds and I see that my local files aren't being used in the expanded yaml. Is this scenario not supported?

@vtbassmatt already commented on this. the short answer is "not yet"
#34 (comment)

Has something changed very recently? I've been trying this API for the first time today, and neither curl nor the PowerShell function provided @JustinGrote work for me.

Authorization for this API (not other DevOps APIs) only works if the username part of the HTTP Basic creds is left blank.
The response is a redirect to a web page. If run through a browser, I end up at https://aex.dev.azure.com/me?mkt=en-US

@joergjo that sounds like an authentication or authorization problem; nothing in our API would trigger that behavior. You can call other APIs without a problem, though?

FYI, related pull request to add this to the VSTeam Powershell Module
https://github.com/DarqueWarrior/vsteam/pull/272

what scopes do I need on the PAT for this to work? the bare minimum, obviosuly. thanks

@4c74356b41 Build - read & execute


Make a "metromap" for the pipeline

Description of feature
To complement the schematic overview in issue #145, we could have a "metromap" like in several other nf-core pipelines. This could be a way to show the different ways to run the pipeline, e.g. use the Sentieon subworkflow, use the annotation etc. These plots tend to get crowded and hard to read, one could have the complete plot on top and under it show the different options (highlighting the different "itineraries").
Inspiration: eager, cutandrun.

done in #432


logging_unittest failed for CMAKE_BUILD_TYPE=Release

All tests passed for Debug build type， but failed at "DeathNoAllocNewHook" for Release build type.
It seems that NewHook not called when testing new int;
$ ./loggint_unittest
[==========] Running 14 tests from 12 test suites.
[----------] Global test environment set-up.
[----------] 1 test from DeathNoAllocNewHook
[ RUN      ] DeathNoAllocNewHook.logging
Function didn't die (unexpected new): { new int; }

Context
GLOG version: commit cd8fbd5fbf6d16d0529978024f56132f67949ba7
System: MacOS Montery (Intel i7 CPU inside)
$uname -a
Darwin localhost 21.1.0 Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:23 PDT 2021; root:xnu-8019.41.5~1/RELEASE_X86_64 x86_64

Compiler: clang-13
$clang -v
Apple clang version 13.0.0 (clang-13<IP_ADDRESS>)
Target: x86_64-apple-darwin21.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

IDE: VSCode (Version: 1.62.3)
CMAKE: 3.22.0

Should be fixed by #1017.


⚠ Processors has degraded performance

In c7b5729, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 161 ms

Resolved: Processors performance has improved in 2be5421.


CLOUD-3089 / CLOUD-3088 - update imagestreams and templates for EAP 6.4 / 7.1

https://issues.jboss.org/browse/CLOUD-3088
https://issues.jboss.org/browse/CLOUD-3089
Signed-off-by: Ken Wills<EMAIL_ADDRESS>

@bstansberry Can you take a quick look at this for a second pair of eyes? If it looks OK, I'll go ahead and merge and tag this.

Needs the images released first.

Closing in favor of seperate updates for 7.1 and 6.4


Pub/Sub Subscriber Error Handling

We have a couple reports of Pub/Sub Subscriber behaving inconsistently. Unhandled errors should be recovered from, but we can add some additional handling to be able to track the errors when they happen.

What do you think about the names chosen in the PR? Logging's AsyncWriter uses last_exception, but Speech uses on_error. This PR adds both of those concepts to Pub/Sub's Subscriber.

I'm good with last_error and on_error.


Fix: Settings weren't included so no settings variables were being co…

When merged this pull request will:

Fix the anti nd module.

There were 3 issues:

The settings file wasn't being included so none of the settings variables were setup and therefore effectively ignored
The logic to remove the fired event handler was not checking a case where a time setting was active but the distance setting disabled
The logic to remove the fired event handler had the distance logic round the wrong way (checking for if the player was within the distance set, not outside of it, to remove the event handler)

Bug previously reported here by myself: https://github.com/Global-Conflicts-ArmA/Olsen-Framework-Arma-3/issues/49


Be able to specify Chrome web store extensions to install when using "pwa-chrome"

Be able to specify Chrome web store extensions to install when using "pwa-chrome" per:
https://code.visualstudio.com/docs/nodejs/browser-debugging#_launch-configuration

e.g. https://chrome.google.com/webstore/detail/fake-data-a-form-filler-y/gchcfdihakkhjgfmokemfeembfokkajj/related?hl=en

It looks like there is a --load-extension command line flag, where if you downloaded the extension locally you can load it from -- that argument can be specified in the runtimeArgs property in the package.json.
Not sure that I want any more intricate built-in support here

that argument can be specified in the runtimeArgs property in the package.json.

@connor4312 I presume you meant launch.json? 😁
If so then that's so nearly a great workaround, except I forgot to mention this is for use in a Codespace, and I suppose that puts this issue in the awkward devcontainers isn't Codespaces area 😑
For the record this approach won't work in a Codespace because the extension path has to be local since Chrome runs local, and that would require user to manually copy the .crx local, which is as burdensome as just reinstalling extension every time.

Perusing those command line switches I couldn't see anything which implied that you could pass profiles/sync options in directly (i.e. not ultimately referencing a local path), so I fear this is a non-starter for Codespaces? 😞

Yes, launch.json, sorry.
If we had some official support for this it would be possible to automatically copy the extension directories to the local machine if they don't already exist...


[Data] Async prefetching 2/n

Why are these changes needed?

Related issue number

Checks

[ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
[ ] I've run scripts/format.sh to lint the changes in this PR.
[ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
[ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy

[ ] Unit tests
[ ] Release tests
[ ] This PR is not tested :(

Current dependencies on/for this PR:

master

PR #41

PR #42   👈

This comment was auto-generated by Graphite.


Docker image creation faild

I am currently working on docker image creation step in Azure Machine Learning Service, but the feedback from the ACR always shows
Creating image
Running...........
FailedImage creation operation finished for image xxximage:3, operation "Failed"
Image creation failed with
StatusCode: 400
Message: Docker image build failed.

I follow the setting of this tutorial how-to-deploy-and-where with Model object, image_configure, myenv.yml and score.py all standby.
Is there any where I can have detailed information about the error?
PS: I have go to the ACR associated with my AML workspace, it shows nothing in the repo, so the creation is failed, but when I go the ACR's "Activity log", it shows the activities with all the statuscode: OK.
Can anyone give any information about this?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38e267fb-efa2-dab5-aa83-4a4addc39ee8
Version Independent ID: e1d506d0-c6bf-47ed-a12c-7bb50416c865
Content: Deploy models as web services - Azure Machine Learning service
Content Source: articles/machine-learning/service/how-to-deploy-and-where.md
Service: machine-learning
GitHub Login: @aashishb
Microsoft Alias: aashishb

@gitathrun Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for MS staff, I have found my answer here: https://aka.ms/debugimage
Need to download the log file and check what is the problem in image build.
Many thanks.

I am following a simiular tutorial and get the same error - Deploying Neural Network models to Azure ML Service with Keras and ONNX.
When I look in build.log, the error seems to be coming from line 8 of myenv.yml. See attached for full build.log. The line that fails is:
    ruamel_yaml.scanner.ScannerError: mapping values are not allowed here       in "<unicode string>", line 8, column 32:         with open("myenv.yml","w") as f:                                        ^ (line: 8)
build.log
@gitathrun - did you find a solution?

@aashishb FYI

I found the issue - it was a stupid mistake.
I had created the file myenv.yml containing the code:
from azureml.core.conda_dependencies import CondaDependencies

myenv = CondaDependencies()
myenv.add_pip_package("numpy")
myenv.add_pip_package("azureml-core")
myenv.add_pip_package("onnxruntime")

with open("myenv.yml","w") as f:
    f.write(myenv.serialize_to_string())

But this is just supposed to be run in python, which programatically creates myenv.yml.
image.wait_for_creation now runs successfully


search.getElementDeclerations doesn't include class constructors

I've moved my document symbol provider over to the new search.getElementDeclerations API but it seems to be missing constructors that aren't named (named constructors appear fine).

@scheglov

Any preference for what the label ought to look like? I'd generally assume "MyClass() MyClass", but that seems a bit redundant and inconsistent with "named() MyClass". We could remove the inconsistency if named constructors also duplicated the class name, but that only increases the redundancy.

@bwilkerson I struggled to come up with a good plan and hoped you'd have an idea! 😁
All of the options I can come up with seem wonky for one reason or another:
Option 1

() and MyClass
named() and MyClass

Option 2

MyClass() and ``
MyClass.named() and ``

Option 3

MyClass() and MyClass
MyClass.named() and MyClass

TypeScript is a lame one to copy here, as it doesn't show parens/args for anything. What does your current IDE do (assuming it has some sort of symbol list or outline view)?

https://dart-review.googlesource.com/c/sdk/+/46004
We will provide empty name, you can present it in the way you think is the best for users :-)
FWIW, IntelliJ includes the class name in names of constructors.

Great, thanks!

Is there still work to be done here, or can this be closed?

Yep, this is all done 👍


Memory leackage in BLock

Description:
Memory leakage is found when calling a lock.  When doing memory analyzing it is found that it takes more memory in the org.ballerinalang.jvm.BLock . The heap_dump file and jar file attached
Affected Versions:
1.1.0

Can you please attach a sample ballerina program to reproduce this issue?  Any other appropriate steps would be appreciated.

I am closing this issue since the it seems to be outdated with the latest code base. Please reopen this if you observe the issue again.


when running job from releng-testing it is failed in Argus submit and finish command

When running job from releng-testing it is failed in Argus submit and finish command:
https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/azure-image/326/
with an error:
11:03:08  + docker run -w /jenkins/workspace/scylla-master/releng-testing/azure-image/scylla-pkg/scripts/argus-client -v /jenkins:/jenkins -v /home/jenkins:/home/jenkins scylladb/argus-client-generic:latest argus-client-generic submit --api-key **** --id ccc72b48-a424-4acb-aa65-bcfc1362606d --build-id scylla-master/releng-testing/azure-image --build-url https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/azure-image/326/ --scylla-version 6.3.0~dev-0.20241118.572b005774b8 --started-by annamikhlin
11:03:09  Traceback (most recent call last):
11:03:09    File "/usr/local/bin/argus-client-generic", line 8, in <module>
11:03:09      sys.exit(cli())
11:03:09               ^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
11:03:09      return self.main(*args, **kwargs)
11:03:09             ^^^^^^^^^^^^^^^^^^^^^^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1078, in main
11:03:09      rv = self.invoke(ctx)
11:03:09           ^^^^^^^^^^^^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
11:03:09      return _process_result(sub_ctx.command.invoke(sub_ctx))
11:03:09                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
11:03:09      return ctx.invoke(self.callback, **ctx.params)
11:03:09             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
11:03:09      return __callback(*args, **kwargs)
11:03:09             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
11:03:09    File "/usr/local/lib/python3.11/site-packages/argus/client/generic/cli.py", line 26, in submit_run
11:03:09      client.submit_generic_run(build_id=build_id, run_id=id, started_by=started_by, build_url=build_url, scylla_version=scylla_version)
11:03:09    File "/usr/local/lib/python3.11/site-packages/argus/client/generic/client.py", line 23, in submit_generic_run
11:03:09      self.check_response(response)
11:03:09    File "/usr/local/lib/python3.11/site-packages/argus/client/base.py", line 68, in check_response
11:03:09      raise ArgusClientError(
11:03:09  argus.client.base.ArgusClientError: ('API Error encountered using endpoint: POST /api/v1/client/testrun/generic/submit', 'DoesNotExist')

The same process passed when running from staging:
https://jenkins.scylladb.com/job/scylla-staging/job/Anna/job/azure-image/23/
11:16:23  + docker run -w /jenkins/workspace/scylla-staging/Anna/azure-image/scylla-pkg/scripts/argus-client -v /jenkins:/jenkins -v /home/jenkins:/home/jenkins scylladb/argus-client-generic:latest argus-client-generic submit --api-key **** --id f10160c8-192f-4abc-813e-91fa37c65b7a --build-id scylla-staging/Anna/azure-image --build-url https://jenkins.scylladb.com/job/scylla-staging/job/Anna/job/azure-image/23/ --scylla-version 6.3.0~dev-0.20241118.572b005774b8 --started-by annamikhlin

both runnig from the same branch with the same params.

interestingly, we don't have logs from argus during that time:
Nov 27 09:03:24 ip-10-0-2-112 bash[1114542]: [pid: 1114542|app: 0|req: 50324/483474] <IP_ADDRESS> () {58 vars in 2844 bytes} [Wed Nov 27 09:03:24 2024] GET /api/v1/client/sct/cf1688b2-5cce-4514-a096-b86c1121b8c6/junit/get_all => generated 30 bytes in 6 msecs (HTTP/1.1 200) 3 h>
...skipping...
Nov 27 09:03:25 ip-10-0-2-112 bash[1114542]: [ERROR] <<IP_ADDRESS> - https://argus.scylladb.com/api/v1/client/testrun/generic/ccc72b48-a424-4acb-aa65-bcfc1362606d/finalize - api.client_api.run_finalize> - error_handlers::handle_api_exception - Exception in api.client_api.run_fi>
Nov 27 09:03:25 ip-10-0-2-112 bash[1114542]: Traceback (most recent call last):

@k0machi don't we need to create releng-testing group in Argus?
I see in argus logs: associated_test: ArgusTest = ArgusTest.get(build_system_id=self.build_id)  does not exist

That's probably the issue, other plugins allow to submit a run without a test, this one seems an outlier. I'll send a PR to allow that. For releng-testing I think we can allow that to be scanned and maybe hide that in releases we don't need.


Ensure the partition reassignment is finished after updating the number of replica

Ensure the partition reassignment is finished (thus the znode is missing) after updating the number of replica.
Fixes https://github.com/StephenSorriaux/ansible-kafka-admin/issues/46
Proposed Changes

Add a new method to ensure the znode is missing before AND after updating the number of replica for a topic.
Add a new method to refresh topics state after an action was done.
Add an example (and a warning) in the README.md file.
Add a test to verify the behaviour.

LGTM


Remove inapptics

Project closed in 2019
https://inapptics.com/

@stavares843 Thanks for the contributing!


WIP - Dynamically configurable Tap filter

A draft PR for making the tap filter more dynamic. This is PR is not intended to be merged - it is intended for a high-level review, as the features will be broken down via individual small PRs.
The features are covered here are:

A streaming GRPC sink in addition to the admin and file sinks.
Enabled runtime variable (for gradual roll-out \ sampling).
Matching on the destination cluster in addition to headers
More information on the trace: destination cluster and host, Metadata in the filter's namespace that's on the cluster and host.
Dynamic configuration via XDS (allows the filter to be configured from a control plane)

Risk Level: Low-Medium (mostly new opt-in functionality; no core changes)
Testing: Will be added in the per feature PRs.
Part of https://github.com/envoyproxy/envoy/issues/6110

@mattklein123 should I start a new PR with just the APIs? or change this one?
I slightly prefer to start a new one with just the api and keep this one as a reference.

@yuval-k yeah let's just do an API PR and nail that down. That would be great.


Adding support for ExtendedEnumInfos

When running tests against TwinCAT 3.1.4026, a warning is shown:
WARNING: Data type Tc2_System.E_OpenPath (UINT) has flag "ExtendedEnumInfos" which is not supported. Things might not work now. Please open an issue at Github

Adding support for it.

Done! The following works with TC 3.1.4026 and ads-client 2.0.0-beta.5
TYPE E_ExtendedEnum :
(
	Disabled 	:= 0, //Machine is disabled
	Starting 	:= 50, //Machine is starting
	Running 	:= 100, //Machine is running
	Stopping	:= 200, //Machine is stopping

	{attribute 'ads-client-enum-attribute' := 'example-enum-value-ääö'}
	Unknown		:= -99 //Machine is ääöööÄÄÖö
);
END_TYPE

const res = await client.getDataType('E_ExtendedEnum');
console.log(inspect(res.enumInfos));
/*
[
  {
    name: 'Disabled',
    value: 0,
    comment: 'Machine is disabled',
    attributes: [
      {
        name: 'ads-client-enum-attribute',
        value: 'example-enum-value-ääö'
      }
    ]
  },
  {
    name: 'Starting',
    value: 50,
    comment: 'Machine is starting',
    attributes: []
  },
  {
    name: 'Running',
    value: 100,
    comment: 'Machine is running',
    attributes: []
  },
  {
    name: 'Stopping',
    value: 200,
    comment: 'Machine is stopping',
    attributes: []
  },
  {
    name: 'Unknown',
    value: -99,
    comment: 'Machine is ääöööÄÄÖö',
    attributes: []
  }
]
*/


Encapsulate keyStorage and configStorage into a single object.

This removes the global singletons, and also allows/suggests replacing the storage implementation with something provided by the user.

Thanks for the review, I'll work on those right away.

One more thing that this PR breaks is that there is an explicit access to config. Some modules use

from .storage import configStorage as config
...
config["default_account"]

So we either need to modify all the appearance of similar code, or offer a way to provide a 'configStorage' that can be loaded like above.
Thoughts?

Oh, I see. Yes, I believe we need to remove all global/singleton configStorage mentions. Let's see...

Codecov Report

Merging #79 into develop will decrease coverage by 0.5%.
The diff coverage is 55%.

@@             Coverage Diff             @@
##           develop      #79      +/-   ##
===========================================
- Coverage    67.55%   67.05%   -0.51%
===========================================
  Files           56       56
  Lines         4475     4504      +29
===========================================
- Hits          3023     3020       -3
- Misses        1452     1484      +32

Impacted Files
Coverage Δ

tests/test_message.py
100% <100%> (ø)
:arrow_up:

bitshares/message.py
89.06% <100%> (ø)
:arrow_up:

bitshares/bitshares.py
47.04% <43.75%> (+0.12%)
:arrow_up:

bitshares/wallet.py
36.72% <58.33%> (+1.29%)
:arrow_up:

bitshares/storage.py
41.94% <67.5%> (-7.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd96ce7...09b4223. Read the comment docs.

Could you please take another look at this? Is there something else that should be done?

Sorry for the late reply. I will take another look today ..

I have worked on this (as promised) and came up with this solution

https://github.com/bitshares/python-bitshares/tree/feature/storage-models

much nicer encapsulated now and allows to replace with your own storage or key-dealing module.
Parts of the library need to me modified still, but the new unit test tests/test_storage.py for different storages works now. The libraries comes with a storage

in RAM
in sqlite
and allows to distinguish unencrypted from decrypted use of storages

#123 obsoletes this PR. I still have some extra feature I'd like merged, but since the codebase is way too different now (plus, part of it now goes to graphenelib), I'm closing this. I'll open new PRs here and in graphenelib.


Format Problem on IOS

Images works well on computer but I have a problem when using it on my Ipad where the image will always appear square despite not being square
Original Image :

Mac Example :

IOS Example :

Is there any fix possible or did i put wrong parameters ?

I tested all mode and it seems that some of them are working but the ones I need are sized like the image was square despite it being 2:1

Try to change the Image Stretch option to Scale To Fill

Scale to fill is working but i'd want image to be scaled to Fit (X and Y) which is working perfectly on computer but not on IOS

Scale to fill is working but i'd want image to be scaled to Fit (X and Y) which is working perfectly on computer but not on IOS

Then I think you are mostly using the wrong resolution for IOS, Ipad's resolution isn't 16:9, try to use a different image resolution for Ipad instead

Image resolution on IOS and Android devices are forced to be power of 2 so to maintain a 16/9ish image I need to have my image 2048/1024
I will investigate on my side


IA-2566: Embedded links - user field : Value not found when the current user has not user permission

Explain what problem this PR is resolving

When the current user has no User management - Admin the userSelect in embedded link display a no found error
This ticket is about to fix that
Related JIRA tickets : IA-2566

Self proofreading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

Give the possibility to define the value of managedUsersOnly parameter instead of the predefined "true" value

How to test

Remove the User management - Admin permission from one user
Connect with the user and try to create a new embedded link or edit one and check if there is no an error in userSelect field

Print screen / video
Screencast from 2024-01-08 10-06-40.webm

@cypress

@cypress

I still get an error in a polio page. I don't know if there's anything special with user id 1
Otherwise not much to say on the front-end side. I feel you could spare addinga prop and just pass false to useGetProfiles since both the dialog and the user select are custom for the embedded link (so they're not used anywhere else).
I have no clue what the backend does, but I guess there was a separate PR for that.

@quang-le the user with 1 as id has not a profile linked to it that's why it generates the error. I will talk with Martin to see how to handle situations like this.

I still get an error in a polio page. I don't know if there's anything special with user id 1
Otherwise not much to say on the front-end side. I feel you could spare addinga prop and just pass false to useGetProfiles since both the dialog and the user select are custom for the embedded link (so they're not used anywhere else).
I have no clue what the backend does, but I guess there was a separate PR for that.

In the backend there is a filter on managedUserOnly for users


Sm/email-and-source-org

What does this PR do?
flags that override the adminEmail and sourceOrg definitionFile props
What issues does this PR fix or reference?
@W-13191348@
https://github.com/forcedotcom/cli/issues/2130

QA Notes

✅ : set adminEmail in config, create org, click on profile, boom, email matches
✅ : use --admin-email flag -> 💥
✅ : set in config, pass in as flag. flag will override config
✅ : --source-org flag validation, length, starts with 00D
✅ : error when edition is specified and --source-org
with dev hub signed up for org snapshot feature:
sf org create shape -v <devhub>
sf org list snapshot verify it's in output
✅ : sf org create scratch --source-org 00Dxxx... -v <devhub>
✅ : sourceOrg specified in scratch-def
✅ : flag overrides
✅ : error messages when source org is invalid


Add ExtractTarWithoutTarsums

There is no need for tarsums when generating checksums of the data on disk (e.g. using go-tuf)

LGTM


riff-distro image list

Take this for a spin:
$ riff-distro image list --images=stable-image-manifest.yaml --check=false

If you have a docker client/daemon, you can also run without --check=false, but it will take a while.
Fixes https://github.com/projectriff/riff/issues/756

Flagged as DO NOT MERGE since this PR is stacked on another.

Removed DO NOT MERGE flagging as the PRs on which this PR was stacked have kindly been merged by @ericbottard.


Why dividing L by 20 to calculate Zdepth, in soiltemp function ?

Why dividing L (layer Thickness) by 20 to calculate Zdepth? Is it always correct to divide by a constant (20) whatever is the value (10, 20, or 30 cm) of L?
Zdepth=L/20
https://github.com/ilmenichetti/reclim/blob/f9366fd758f7f814187c623d80ce8cd65e83754a/R/re_crop.R#L127

True, sorry for the rather poor documentation... it is because we always assume we are working on the 0-20 cm interval...


Add Reset API Function

Problem
The Body prototype is not exposed by Engine preventing the manipulation of the bodies property directly.
Solution
Add a reset function to the API which takes a collection of object bodies and stands up new Body prototypes. This allows consumers to update the simulation externally.
Howto Test

[ ] Local test pass

Current coverage is 42.10%

Branch #22 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


Formatted Date component

Summary | Résumé
Adds a Formatted date component.
Things to test

Add a date element
Select different formats
Ensure date inputs display in correct format on Preview/Form view
In multi-page forms, ensure dates are displayed correctly according to selected format on Review
Ensure dates are displayed correctly when downloading responses in any format

Note
While the old date "component" (actually just a templated input) has been removed from the AddElement dialog, the rest of the code to support it remains in place so that existing forms or form files that include that type of input will continue to work as-is. There is no conversion/migration to the new component.

Add element dialog
Element panel

More modal/Options
Form/Preview render

Some observations from testing / tweaks to consider
1. Some valid dates are not accepted (ex: Dec 31, 2023 in FR)?

2. Missing translation text for the details component in the More modal?

3. Making default format pre-selected, but changeable in More modal?

4. Year allows for 3 character long dates, but not 2 or 1?


Pro 2939 piece page type doc

Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR adds a new reference page documenting the piece-page-type. Closes PRO-2939.
What are the specific steps to test this change?
For example:

Run the website and log in as an admin
Open a piece manager modal and select several pieces
Click the "Archive" button on the top left of the manager and confirm that it should proceed
Check that all pieces have been archived properly

Build the documentation
Navigate to reference->modules->piece-page-type.html

What kind of change does this PR introduce?
(Check at least one)

[ ] Bug fix
[ ] New feature
[ ] Refactor
[X] Documentation
[ ] Build-related changes
[ ] Other

Make sure the PR fulfills these requirements:

[X] It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
[ ] The changelog is updated
[ ] Related documentation has been updated
[ ] Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Approved. | build examples would make a nice follow-on but might be more appropriate in a guide section article.


add zero check to oldUSDPrice

Description
Gnosis beta deployment failed at block 26860006 due to a division by zero apparently coming from this line
https://api.thegraph.com/subgraphs/id/Qmd2dPi5cqyvntK8y8hS5mK4rCF5E3c4EiShM8CP4ZpGTV/graphql?query={
++tokens(block%3A{number%3A26860005}
++where%3A{latestUSDPrice%3A0}){
++++id
++++latestUSDPrice
++}
}
https://gnosisscan.io/tx/0xff83e8e64f2fed98fdd88857ff53f09e6dbb49b42b03799eab54989f77ab5c95#eventlog
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?
Gnosis should sync past block 26860006
Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas

closed in favor of #407


THRIFT-5551: java generator to add @Override where possible

java generator to add @Override where possible

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

These changes are harder to review than necessary, because they contain a lot of style changes. I would recommend minimizing the changes in this PR by retaining the existing style, so it's easier to review. For style standardization/improvements, I'd suggest creating a separate PR that does only that and no substantive changes.

Thanks for the suggestion - I wonder it too. The formatting changes were made by my editor, and I don't have a good way to separate it from the actual changes now.
If it's okay do you think I can create a separate, clean, style only change and merge that first. And then this change can be much cleaner? @ctubbsii

If it's okay do you think I can create a separate, clean, style only change and merge that first. And then this change can be much cleaner?

Yeah, I think that would be a good option. If a standard style can be enforced by people with any editor, something like what the formatter-maven-plugin provides for Java code, that would be even better, I would think.

yes @ctubbsii the tool is clang-format and it's also centrally configured here - which is also what my editor formatting is relying on.

I'm creating https://github.com/apache/thrift/pull/2560 as style only format to precede this change

@Jimexist I think you need to rebase and force-push to get this up-to-date.


Add spaceSeparatedCurrency config option

Add spaceSeparatedCurrency so that it would be possible to have space separated abbreviation but no space after prefixed currency e.g. $10 k
Fixes BenjaminVanRyseghem/numbro#423

Thanks for the PR.
Could you change your code so that spaceSeparatedCurrency defaults to spaceSeparated when not specified, so that we can ensure backward compatibility
Something like
spaceSeparatedCurrency = spaceSeparatedCurrency !== void 0 ? spaceSeparatedCurrency : spaceSeparated;

Note: void 0 is the most correct way to refer to undefined as undefined could be locally shadowed
Could you also add a set of tests specific to this feature (I haven't seen them at least :smile:)?
Finally, could you add yourself to then AUTHORS file as well as a line in the CHANGELOG?
Thanks again!

Added the fallback logic and a couple of tests.
Can't add language tests because there's no way to pass that configuration to the old format (although it works in numeral so it shouldn't be impossible to achieve).

Hi :)
despite what GitHub is saying (I quite fucked up while rebasing :smile:) your PR has been merged :smile:
Thanks again


/etc/profile not sourced

I've been testing updates to the ubuntu zfsbootmenu install script and noticed that the zfsbootmenu kernel/snapshot UI fails to launch. I get the following error following the rEFInd screen.
"WARNING: /etc/profile was not sourced; unable to proceed"
I am then presented with the "zfsbootmenu / >" prompt.
Zdykstra noted in a previous pull request that "/etc/profile" or "/lib/zfsbootmenu-lib.sh" is sourced by the shell.
https://github.com/zbm-dev/zfsbootmenu/pull/169
I've looked at recent commits and noticed that core library routines have been separated from main UI routines. Could that commit have caused an issue with sourcing "/lib/zfsbootmenu-lib.sh"?
https://github.com/zbm-dev/zfsbootmenu/commit/044df51857db3ad4f7e45be991114fb2e45a1dec
The ubuntu zfsbootmenu install script can be found at the following link for reference.
https://gitlab.com/Sithuk/ubuntu-server-zfsbootmenu/

From the recovery shell, please run cat /etc/profile and source /etc/profile. If possible, please share a screen shot or a picture of what is shown on your screen after each/both.

From the recovery shell, please run cat /etc/profile and source /etc/profile. If possible, please share a screen shot or a picture of what is shown on your screen after each/both.

Screenshot attached

.

Screenshot attached

.

Try set -x ; source /etc/profile  It'll probably spam a lot - but maybe it'll tell you where it stops/fails. Otherwise, run set +x (if you've run set -x) and then try to source each of the three files individually. One of those should fail - please let me know which one.

Try set -x ; source /etc/profile  It'll probably spam a lot - but maybe it'll tell you where it stops/fails. Otherwise, run set +x (if you've run set -x) and then try to source each of the three files individually. One of those should fail - please let me know which one.

If the return code is nonzero after sourcing /etc/profile, that means it gets a nonzero return code from zdebug.

If the return code is nonzero after sourcing /etc/profile, that means it gets a nonzero return code from zdebug.

After review, this is expected behavior, because zdebug returns 1 when the log level doesn't match. We missed this in testing because we set loglevel=7 by default, I think.
The zdebug line in /etc/profile should be or'ed with true to suppress the nonzero exit and avoid triggering the UI failure.

After review, this is expected behavior, because zdebug returns 1 when the log level doesn't match. We missed this in testing because we set loglevel=7 by default, I think.
The zdebug line in /etc/profile should be or'ed with true to suppress the nonzero exit and avoid triggering the UI failure.

This should be fixed now - thank you for the bug report and the additional information!

This should be fixed now - thank you for the bug report and the additional information!

I'm glad to help. Thank you for your and team's efforts on zfsbootmenu and for the fast response to fix the issue.

I'm glad to help. Thank you for your and team's efforts on zfsbootmenu and for the fast response to fix the issue.


Fix Resource Pack version, Change Fabric Required Minecraft version, added relic to round disk

cant promise if forge works

I've gone ahead and merged #44 instead of this one, since it just has a cleaner commit history.
Thanks for the effort anyway!


tetrapak-1.16.5-0.3.1 - multiplayer/PlayerController for invalid dist DEDICATED_SERVER Crash

Forge: 36.2.1
Minecraft: 1.16.5
Tetrapak: 0.3.1
Full Log: https://pastebin.com/16rBx618
Hi,
Tetrapak 0.3.1 crashes on server startup with the new version. Above it the full details.
Thanks

Hi,
This should be fixed in 03d8663 and public on next curseforge release.
Thanks for reporting

Alright, the release is out at https://www.curseforge.com/minecraft/mc-mods/tetra-pak/files/3401450
I'll close this issue, reopen if it persists


SSHLauncher tries to launch Windows agent for more than 13 hours

Jenkins and plugins versions report

Environment

Jenkins: 2.361.2
OS: Linux - 4.18.0-305.65.1.el8_4.x86_64
---
Parameterized-Remote-Trigger:<IP_ADDRESS>
ace-editor:1.1
ansicolor:1.0.2
antisamy-markup-formatter:2.7
apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61
authentication-tokens:1.4
authorize-project:1.4.0
aws-credentials:191.vcb_f183ce58b_9
aws-java-sdk-ec2:1.12.287-357.vf82d85a_6eefd
aws-java-sdk-minimal:1.12.287-357.vf82d85a_6eefd
badge:1.9.1
bootstrap4-api:4.6.0-5
bootstrap5-api:5.2.1-2
bouncycastle-api:2.26
branch-api:2.1046.v0ca_37783ecc5
build-timeout:1.24
caffeine-api:2.9.3-65.v6a_47d0f4d1fe
checks-api:1.7.5
cloud-stats:0.27
cloudbees-disk-usage-simple:170.va_fd5b_4ee6858
cloudbees-folder:6.758.vfd75d09eea_a_1
command-launcher:90.v669d7ccb_7c31
conditional-buildstep:1.4.2
config-file-provider:3.11.1
configuration-as-code:1512.vb_79d418d5fc8
credentials:1143.vb_e8b_b_ceee347
credentials-binding:523.vd859a_4b_122e6
description-setter:1.10
disk-usage:0.28
display-url-api:2.3.6
dumpling:2.2
durable-task:500.v8927d9fd99d8
ec2:2.0.2
echarts-api:5.3.3-1
email-ext:2.91
envinject:2.875.v9b_9e962da_a_ec
envinject-api:1.199.v3ce31253ed13
extended-read-permission:3.2
favorite:2.4.1
flexible-publish:0.16.1
font-awesome-api:6.2.0-2
ghprb:1.42.2
git:4.12.1
git-client:3.12.0
git-server:99.va_0826a_b_cdfa_d
github:1.35.0
github-api:1.303-400.v35c2d8258028
gitlab-plugin:1.5.35
greenballs:1.15.1
groovy:442.v817e6d937d6c
groovy-postbuild:2.5
h2-api:1.4.199
handlebars:3.0.8
htmlpublisher:1.31
instance-identity:116.vf8f487400980
ionicons-api:24.va_745a_b_a_97fc3
jackson2-api:2.13.3-285.vc03c0256d517
jakarta-activation-api:2.0.1-1
jakarta-mail-api:2.0.1-1
javadoc:226.v71211feb_e7e9
javax-activation-api:1.2.0-4
javax-mail-api:1.6.2-5
jaxb:2.3.6-1
jdk-tool:55.v1b_32b_6ca_f9ca
jersey2-api:2.37-1
jms-messaging:1.1.27
job-dsl:1.81
jobConfigHistory:1176.v1b_4290db_41a_5
jquery3-api:3.6.1-1
jsch:<IP_ADDRESS>.va_e9ee26616e7
junit:1119.1121.vc43d0fc45561
kerberos-sso:1.10
kubernetes:3706.vdfb_d599579f3
kubernetes-client-api:5.12.2-193.v26a_6078f65a_9
kubernetes-credentials:0.9.0
ldap:2.12
lockable-resources:2.16
mailer:438.v02c7f0a_12fa_4
matrix-auth:3.1.5
matrix-project:785.v06b_7f47b_c631
matrix-reloaded:1.1.3
metrics:4.2.10-389.v93143621b_050
mina-sshd-api-common:2.9.1-44.v476733c11f82
mina-sshd-api-core:2.9.1-44.v476733c11f82
momentjs:1.1.1
monitoring:1.91.0
naginator:1.18.1
node-iterator-api:49.v58a_8b_35f8363
okhttp-api:4.9.3-108.v0feda04578cf
openstack-cloud:2.63
parameterized-scheduler:1.1
parameterized-trigger:2.45
pipeline-build-step:2.18
pipeline-github-lib:38.v445716ea_edda_
pipeline-graph-analysis:195.v5812d95a_a_2f9
pipeline-groovy-lib:612.v84da_9c54906d
pipeline-input-step:451.vf1a_a_4f405289
pipeline-maven:1205.vceea_7b_972817
pipeline-milestone-step:101.vd572fef9d926
pipeline-model-api:2.2114.v2654ca_721309
pipeline-model-definition:2.2114.v2654ca_721309
pipeline-model-extensions:2.2114.v2654ca_721309
pipeline-rest-api:2.24
pipeline-stage-step:296.v5f6908f017a_5
pipeline-stage-tags-metadata:2.2114.v2654ca_721309
pipeline-stage-view:2.24
pipeline-utility-steps:2.13.0
plain-credentials:139.ved2b_9cf7587b
plugin-util-api:2.17.0
popper-api:1.16.1-3
popper2-api:2.11.6-1
postbuildscript:3.2.0-460.va_fda_0fa_26720
proc-cleaner-plugin:2.4
prometheus:2.0.11
rebuild:1.34
redhat-ci-plugin:1.5.16
resource-disposer:0.20
role-strategy:561.v9846c7351a_41
run-condition:1.5
scm-api:621.vda_a_b_055e58f7
script-security:1183.v774b_0b_0a_a_451
short-workspace-path:0.3
snakeyaml-api:1.31-84.ve43da_fb_49d0b
ssh-credentials:305.v8f4381501156
ssh-slaves:2.846.v1b_70190624f5
sshd:3.249.v2dc2ea_416e33
structs:324.va_f5d6774f3a_d
swarm:3.34
test-stability:2.3
testng-plugin:555.va0d5f66521e3
text-finder:1.20
timestamper:1.20
token-macro:308.v4f2b_ed62b_b_16
trilead-api:2.72.v2a_3236754f73
update-sites-manager:2.0.0
variant:59.vf075fe829ccb
windows-slaves:1.8.1
workflow-aggregator:590.v6a_d052e5a_a_b_5
workflow-api:1200.v8005c684b_a_c6
workflow-basic-steps:994.vd57e3ca_46d24
workflow-cps:2759.v87459c4eea_ca_
workflow-cps-global-lib:588.v576c103a_ff86
workflow-durable-task-step:1199.v02b_9244f8064
workflow-job:1236.vc3a_d1602f439
workflow-multibranch:716.vc692a_e52371b_
workflow-scm-step:400.v6b_89a_1317c9a_
workflow-step-api:639.v6eca_cd8c04a_a_
workflow-support:838.va_3a_087b_4055b
ws-cleanup:0.43
zmq-event-publisher:0.0.5

What Operating System are you using (both controller, and any agents involved in the problem)?
agent - Windows Server 2019 (CYGWIN_NT-10.0-17763)
Reproduction steps
Provision Windows nodes again and again until you hit the problem.
Expected Results
One of:

SSHLauncher should automatically re-launch JCloudsLauncher on Windows (re-try mechanism)
there should be timeout to drop launching (maybe re-launch)
log error message

Actual Results
Sometimes ("randomly") provisioning fails and node is stuck in state "launch", in cloud stats I can see 13 hr and counting (then I terminated node manually), however there is no issue with the agent. I can access node from my computer with ssh and there are no logs in /remoting (the directory does not exist, but remoting.jar is there). Using "relaunch agent" button does not help.
Here is edited log:
SSHLauncher{host='xx.xx.xx.xx', port=22, credentialsId='xxxxxx', jvmOptions='', javaPath='', prefixStartSlaveCmd='', suffixStartSlaveCmd='', launchTimeoutSeconds=600, maxNumRetries=5, retryWaitTime=15, sshHostKeyVerificationStrategy=hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy, tcpNoDelay=true, trackCredentials=true}
[01/26/23 20:59:31] [SSH] Opening SSH connection to xx.xx.xx.xx:22.
[01/26/23 20:59:39] [SSH] WARNING: SSH Host Keys are not being verified. Man-in-the-middle attacks may be possible against this connection.
[01/26/23 20:59:39] [SSH] Authentication successful.
[01/26/23 20:59:39] [SSH] The remote user's environment is:
..
Checking Java version in the PATH
openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment GraalVM CE 22.3.1 (build 11.0.18+10-jvmci-22.3-b13)
OpenJDK 64-Bit Server VM GraalVM CE 22.3.1 (build 11.0.18+10-jvmci-22.3-b13, mixed mode, sharing)
[01/26/23 20:59:42] [SSH] Checking java version of /<<some-path>>/jdk/bin/java
Couldn't figure out the Java version of /<<some-path>>/jdk/bin/java
bash: /<<some-path>>/jdk/bin/java: No such file or directory

[01/26/23 20:59:42] [SSH] Checking java version of java
[01/26/23 20:59:43] [SSH] java -version returned 11.0.18.
[01/26/23 20:59:43] [SSH] Starting sftp client.
[01/26/23 20:59:44] [SSH] Copying latest remoting.jar...
[01/26/23 20:59:45] [SSH] Copied 1,339,992 bytes.
Expanded the channel window size to 4MB
[01/26/23 20:59:45] [SSH] Starting agent process: cd "<<some_hudson_workspace_path>>" && java  -jar remoting.jar -workDir <<some_hudson_workspace_path>> -jar-cache <<some_hudson_workspace_path>>/jarCache
led 26, 2023 8:59:46 ODP. org.jenkinsci.remoting.engine.WorkDirManager initializeWorkDir
INFO: Using <<some_hudson_workspace_path>>\remoting as a remoting work directory
led 26, 2023 8:59:46 ODP. org.jenkinsci.remoting.engine.WorkDirManager setupLogging
INFO: Both error and output logs will be printed to <<some_hudson_workspace_path>>\remoting
<===[JENKINS REMOTING CAPACITY]===>channel started
Remoting version: 3044.vb_940a_a_e4f72e
Launcher: JCloudsLauncher
Communication Protocol: Standard in/out
This is a Windows agent

Anything else?
No response

Thanks for the report! I am not sure if this is a problem of openstack-cloud plugin in failing to bring the node online, or cloud-stats-plugin in failing to represent node status correctly.

Does the node report to be online in Jenkins, or not? Is the node accepting builds?
Do you have enough samples to be confident this appears on Windows machines only?
Can you extract Jenkins service logs and grep it for the node name?

@olivergondza thanks for getting back to me so quickly

Thanks for the report! I am not sure if this is a problem of openstack-cloud plugin in failing to bring the node online, or cloud-stats-plugin in failing to represent node status correctly.

Does the node report to be online in Jenkins, or not? Is the node accepting builds?

No, node is N/A (highlighted in red) and a job run is cancelled after timeout, but node is never terminated. I have a reason why I believe it's an openstack-cloud issue - if you inspect logging above, you can see there is never Agent successfully connected and online among other logging events.
Also I'd like to stress out this happen quite "randomly" (meaning I can't related it to the cause) as sometimes there is 20 nodes provisioned correctly in row, sometimes it's couple of this in row. On average, the "launch" phase is done within 14 seconds.

Do you have enough samples to be confident this appears on Windows machines only?

I can't disclose details, but we have quite a volume of linux-based runs and I can't see it there.

Can you extract Jenkins service logs and grep it for the node name?

I'll try that next time I see the problem and get back to you here. In short - ATM no, but I'll be watching it.


Added search progress spinner in search bar

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Added a search progress spinner in search bar with spinner start+visible and stop+hide control given to user.
SearchBar.swift:

inside search bar, added a new element for progress spinner which is enclosing the clear button in search bar.
User will have control over hide/show and start/stop animating the progress spinner.
tint color of progress spinner is kept same as that of other elements on search bar

NavigationControllerDemoController.swift

Made the controller to implement the search bar delegate
upon updating the text in search bar or cancel button press, stopping+hiding the progress spinner
when user hits search for a keyword, the progress spinner appears and starts spinning

Verification

Validated that user is able to show and hide the spinner and start and stop the spinner animation.
validated that the other search bar controls are working as before.

Before
After

No progress Spinner was present in search bar
Progress spinner ui element is added inside search bar surrounding clear button

Screenshots

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[ ] VoiceOver and Keyboard Accessibility
[x] Internationalization and Right to Left layouts
[x] Different resolutions (1x, 2x, 3x)
[x] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)

Microsoft Reviewers: Open in CodeFlow

in your screenshot the spinner colors stays the same which is not true in toolkit design.

in your screenshot the spinner colors stays the same which is not true in toolkit design.

Light mode / primary (= blue nav bar): Accent color Tint 10
Light mode / whiter: Gray 300
Dark mode / default: Gray 100

Updated colors as mentioned by Victor and updated screenshots in pull request

In reply to: 669304788 [](ancestors = 669304788)

Thanks Victor. Updated colors as mentioned here.

In reply to: 671489608 [](ancestors = 671489608)